ENH: Robust EPI Mask for heavily nonuniform image

Ref #1000
When processing heavily nonuniform bold data (eg, from 64 channels head coils), the MaskEPI step in init_enhance_and_skullstrip_bold_wf often give bad results.
This PR tweaks some parameters in MaskEPI and adds an addition N4 correction step before MaskEPI. I have tested the code on a multiband dataset and several legacy images. Generally it gives better or equal results with little additional computation cost.

Hi, thanks for this. Sorry about the slow response.
Looking at this, my main concern is that we're adding steps when we may achieve the same result by rearranging. That is init_mask and skullstrip_first_pass are the same command, as are init_correct and n4_correct.
Under the hypothesis that these two steps are doing very little after having been run previously, I would try removing skullstrip_first_pass and n4_correct, and hook the output of n4_mask where skullstrip_first_pass is being used, and see how that affects things.
That said, if 9 steps are required, that's fine. I just want to consider whether we can simplify before we go ahead and add.

I think this is all very reasonable (the proposed solution to a particular problem, and further revision from @effigies).
On the other hand, I have the feeling that we are touching on an edge case here. I checked visually more than 2000 masks (of 100000 which run without errors), and it'd be a waste to have a regression on this.
I propose the following: @ZhifangYe would you be satisfied if we add a flag (say --robust-bold-inu or similar) that enables your tweak?
In a future, if more and more users report they are using the flag, we could make it the default.
WDYT?

Hi all, after discussing this issue, we would like to set up some extra tests to avoid regressions on masking. We plan to work on these new tests along next week. This way this PR can be accepted as is (without implementing new optional arguments etc)

After review the process, I agree to the comment from @effigies that we can simplify the workflow. The idea here is we need to feed a uniformed image to MaskEPI node. The histogram based masking method in MaskEPI would fail for heavily nonuniform data no matter what parameters we use. As long as we normalize epi data before MaskEPI, I think results should be fine. In my experience, BET always gives a more loose mask for both corrected and uncorrected image.  So I think remove skullstrip_first_pass and n4_correct should be OK. I will test this idea and report back.
As for an addition flag suggest by @oesteban , I'm satisfied with it. But I'm little concerned that other users would be confused without context. So if this tweak don't change behaviors on tested data, I think we may want to include it as default. Look forward to the extra tests results.

I've asked for these data (https://neurostars.org/t/ica-aroma-error-in-fmriprep-mask-and-image-must-be-the-same-size/1605/4) to add in the test battery.
When "prescan normalize" is on, it seems that images are more homogeneous and our masking heuristics get lost. I wonder if this PR would fix that.

@effigies is currently working on setting up the masks tests for current and future implementations of this stage. Will let you know when this is available :+1:

Hi @ZhifangYe. Sorry for taking so long to get back to you on this. #1074 is almost done, so I'm going to merge it in here to see what effect your changes have on our existing datasets.

Well, that's failing. Running locally to see what the differences are. They could be minor.

Tests passing at a symmetric overlap threshold of 0.95. Here are the absolute sizes (in voxels) before and after:
1,14c1,14
< ds000116/sub-12_task-visualoddballwithbuttonresponsetotargetstimuli_run-02_bold_mask.nii.gz float32 [ 64,  64,  32] 3.00x3.00x4.00   sform 1:44517
< ds000133/sub-06_ses-post_task-rest_run-01_bold_mask.nii.gz                                  float32 [ 64,  64,  30] 4.00x4.00x4.00   sform 1:24680
< ds000140/sub-32_task-heatpainwithregulationandratings_run-02_bold_mask.nii.gz               float32 [ 80,  80,  42] 2.80x2.80x3.00         1:60263
< ds000157/sub-23_task-passiveimageviewing_bold_mask.nii.gz                                   float32 [ 64,  64,  30] 4.00x4.00x3.99   sform 1:21536
< ds000210/sub-06_task-rest_run-01_echo-1_bold_mask.nii.gz                                    float32 [ 72,  72,  46] 3.00x3.00x3.00   sform 1:57475
< ds000210/sub-06_task-rest_run-01_echo-2_bold_mask.nii.gz                                    float32 [ 72,  72,  46] 3.00x3.00x3.00   sform 1:55082
< ds000210/sub-06_task-rest_run-01_echo-3_bold_mask.nii.gz                                    float32 [ 72,  72,  46] 3.00x3.00x3.00   sform 1:52088
< ds000216/sub-03_task-rest_echo-1_bold_mask.nii.gz                                           float32 [ 80,  80,  36] 3.00x3.00x3.00   sform 1:45485
< ds000216/sub-03_task-rest_echo-2_bold_mask.nii.gz                                           float32 [ 80,  80,  36] 3.00x3.00x3.00   sform 1:42676
< ds000216/sub-03_task-rest_echo-3_bold_mask.nii.gz                                           float32 [ 80,  80,  36] 3.00x3.00x3.00   sform 1:40151
< ds000216/sub-03_task-rest_echo-4_bold_mask.nii.gz                                           float32 [ 80,  80,  36] 3.00x3.00x3.00   sform 1:38029
< ds000237/sub-03_task-MemorySpan_acq-multiband_run-01_bold_mask.nii.gz                       float32 [ 64,  64,  48] 3.00x3.00x3.00   sform 1:60327
< ds000237/sub-06_task-MemorySpan_acq-multiband_run-01_bold_mask.nii.gz                       float32 [ 64,  64,  48] 3.00x3.00x3.00   sform 1:51879
< ds001362/sub-01_task-taskname_run-01_bold_mask.nii.gz                                       float32 [ 88,  88,  64] 2.39x2.39x2.40   sform 1:8526
---
> ds000116/sub-12_task-visualoddballwithbuttonresponsetotargetstimuli_run-02_bold_mask.nii.gz float32 [ 64,  64,  32] 3.00x3.00x4.00   sform 1:42037
> ds000133/sub-06_ses-post_task-rest_run-01_bold_mask.nii.gz                                  float32 [ 64,  64,  30] 4.00x4.00x4.00   sform 1:24342
> ds000140/sub-32_task-heatpainwithregulationandratings_run-02_bold_mask.nii.gz               float32 [ 80,  80,  42] 2.80x2.80x3.00         1:59962
> ds000157/sub-23_task-passiveimageviewing_bold_mask.nii.gz                                   float32 [ 64,  64,  30] 4.00x4.00x3.99   sform 1:21592
> ds000210/sub-06_task-rest_run-01_echo-1_bold_mask.nii.gz                                    float32 [ 72,  72,  46] 3.00x3.00x3.00   sform 1:57717
> ds000210/sub-06_task-rest_run-01_echo-2_bold_mask.nii.gz                                    float32 [ 72,  72,  46] 3.00x3.00x3.00   sform 1:54989
> ds000210/sub-06_task-rest_run-01_echo-3_bold_mask.nii.gz                                    float32 [ 72,  72,  46] 3.00x3.00x3.00   sform 1:51198
> ds000216/sub-03_task-rest_echo-1_bold_mask.nii.gz                                           float32 [ 80,  80,  36] 3.00x3.00x3.00   sform 1:45502
> ds000216/sub-03_task-rest_echo-2_bold_mask.nii.gz                                           float32 [ 80,  80,  36] 3.00x3.00x3.00   sform 1:42192
> ds000216/sub-03_task-rest_echo-3_bold_mask.nii.gz                                           float32 [ 80,  80,  36] 3.00x3.00x3.00   sform 1:38919
> ds000216/sub-03_task-rest_echo-4_bold_mask.nii.gz                                           float32 [ 80,  80,  36] 3.00x3.00x3.00   sform 1:35955
> ds000237/sub-03_task-MemorySpan_acq-multiband_run-01_bold_mask.nii.gz                       float32 [ 64,  64,  48] 3.00x3.00x3.00   sform 1:60031
> ds000237/sub-06_task-MemorySpan_acq-multiband_run-01_bold_mask.nii.gz                       float32 [ 64,  64,  48] 3.00x3.00x3.00   sform 1:52943
> ds001362/sub-01_task-taskname_run-01_bold_mask.nii.gz                                       float32 [ 88,  88,  64] 2.39x2.39x2.40   sform 1:99964

The multi-echo runs in particular seem to produce more conservative masks. @oesteban I might want your eyes for some of this. It's hard to tell if they're over-conservative, given the overall image contrast level.

Plots of the old/new masks are being saved as artifacts.

What's red and what's green? Can I assume that red == old?

Yes
-------- Original message --------
From: Oscar Esteban<EMAIL_ADDRESS>Date: 8/10/18 15:54 (GMT-05:00)
To: poldracklab/fmriprep<EMAIL_ADDRESS>Cc: Christopher Markiewicz<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [poldracklab/fmriprep] ENH: Robust EPI Mask for heavily nonuniform image (#1050)
What's red and what's green? Can I assume that red == old?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/poldracklab/fmriprep/pull/1050#issuecomment-412188486, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAFF8nmlJqUn9vUlx8rIsl0JVho-bwguks5uPeTwgaJpZM4TR4_8.

Oh, you mean the contours? I think the more conservative masks are the new ones. Which I think does align red/green. But you wrote ROIsPlot, so you'll know better than I.

Since https://github.com/poldracklab/fmriprep/pull/1074 wa merged we should work on getting this contribution incorporated in FMRIPREP (since we can check if nothing regresses).

Right, sorry, Oscar and I discussed off-thread that there are regressions where previously good masks are now (slightly) too conservative. It's unclear whether the best path forward is further tweaking on this PR or permitting options.

Okay, getting back to this. If I remember correctly, @oesteban's thought was to use a quick affine registration to register a template EPI image, then dilate the mask by a few voxels to create the initial pre-N4 mask. Once that's done, we may be able to otherwise use the existing method.
I'll be looking into this this afternoon.

https://neurostars.org/t/fmriprep-bet-threshold/1486/15

Hi @ZhifangYe, it took excessively long for us to set up the regression tests and then summer fell over us quickly.
I've been working on an alternative to the current brain extraction workflow (see #1321), and now I'll test on the dataset you handled us (https://openneuro.org/datasets/ds001240).
First question is: would you be happy if we added the first 50 timepoints your dataset to our battery of regression tests? Any issues with sharing just the cropped bold file?
Second question is: do you have more failing examples you can test #1321 on?
I think we are going to go ahead with your PR and merge it, however in #1321 we are after a long-term, more robust solution.
These are the regression tests I'm talking about (green is your PR and red our pre-cached results with the current implementation in fmriprep):

https://5097-53175327-gh.circle-artifacts.com/0/tmp/data/reports/ds000116/sub-12_task-visualoddballwithbuttonresponsetotargetstimuli_run-02_bold_masks.svg
https://5097-53175327-gh.circle-artifacts.com/0/tmp/data/reports/ds000133/sub-06_ses-post_task-rest_run-01_bold_masks.svg
https://5097-53175327-gh.circle-artifacts.com/0/tmp/data/reports/ds000140/sub-32_task-heatpainwithregulationandratings_run-02_bold_masks.svg
https://5097-53175327-gh.circle-artifacts.com/0/tmp/data/reports/ds000157/sub-23_task-passiveimageviewing_bold_masks.svg
https://5097-53175327-gh.circle-artifacts.com/0/tmp/data/reports/ds000210/sub-06_task-rest_run-01_echo-1_bold_masks.svg
https://5097-53175327-gh.circle-artifacts.com/0/tmp/data/reports/ds000210/sub-06_task-rest_run-01_echo-2_bold_masks.svg
https://5097-53175327-gh.circle-artifacts.com/0/tmp/data/reports/ds000210/sub-06_task-rest_run-01_echo-3_bold_masks.svg
https://5097-53175327-gh.circle-artifacts.com/0/tmp/data/reports/ds000216/sub-03_task-rest_echo-1_bold_masks.svg
https://5097-53175327-gh.circle-artifacts.com/0/tmp/data/reports/ds000216/sub-03_task-rest_echo-2_bold_masks.svg
https://5097-53175327-gh.circle-artifacts.com/0/tmp/data/reports/ds000216/sub-03_task-rest_echo-3_bold_masks.svg
https://5097-53175327-gh.circle-artifacts.com/0/tmp/data/reports/ds000216/sub-03_task-rest_echo-4_bold_masks.svg
https://5097-53175327-gh.circle-artifacts.com/0/tmp/data/reports/ds000237/sub-03_task-MemorySpan_acq-multiband_run-01_bold_masks.svg
https://5097-53175327-gh.circle-artifacts.com/0/tmp/data/reports/ds000237/sub-06_task-MemorySpan_acq-multiband_run-01_bold_masks.svg

Probably, the only case that you would say your idea worked worse than before are https://5097-53175327-gh.circle-artifacts.com/0/tmp/data/reports/ds000216/sub-03_task-rest_echo-3_bold_masks.svg and https://5097-53175327-gh.circle-artifacts.com/0/tmp/data/reports/ds000216/sub-03_task-rest_echo-4_bold_masks.svg. However, in this case it worked better: https://5097-53175327-gh.circle-artifacts.com/0/tmp/data/reports/ds000237/sub-03_task-MemorySpan_acq-multiband_run-01_bold_masks.svg.

I've added some code to save a bundle of the mask files so that, in cases like this where we change the mask algorithm, we can easily upload the new files to OSF.

@ZhifangYe, in addition to https://github.com/poldracklab/fmriprep/pull/1050#issuecomment-430307448, please have a look on https://github.com/poldracklab/fmriprep/pull/1322#issuecomment-430035922 and let us know whether you want to have your name added in the .zenodo.json file

Hi, @oesteban , thanks for the efforts on this PR. The regression test looks really good.
I'm happy to have my data included in the battery of regression test. The BOLD files should already be anonymized.
I have a quick look at #1321 and feel it is very promising. I will build an image for this PR to test it locally and report back. There're several failed examples in my dataset I could test on.
Also, there's a related issue I recently discovered. For some BOLD image, the N4 correction works fine on the generated reference image before fieldmap unwrapping but fails on the unwrapped image. It produced bad final brain mask even in my current PR. I will see whether #1321 resolve this problem. If not, I think we should look into it.
BTW, I'm already in the .zenodo.json file because of previous PR. Thanks for asking.

Okay, then let's hold off merging this PR until we get feedback from you regarding those failing cases. I'll merge #1326 into #1321 so that you can get proper reports.

Closed via #1321


Failed error to publish

Interesting, this error probably means the plugin did not get the HTML rendered by preview mode, can you provide a list of plugins that you installed?

Hey, the same here:

Here's the list of my plugins:

Turns out it's indeed caused by a plugin, but it's one of mine, not yours, led me to use the wrong way to get the HTML of preview content. I've fixed this problem in release 1.1.1, please try again.

Thanks! it works now.

In case anyone still gets this error for edge cases, I added a new setting called HTML Source in release 1.2.0,
try to use MarkdownRenderer if you get into trouble.

It works fine, but when I post my note on Facebook it is impossible, is this due to Russian app censorship policies?


Add config system and the ability to disable mods

This adds the ability to enable/disable mods through the Mods menu, as well as a basic xml-based configuration system for HAT. I plan on expanding this to add the ability for mods to create custom config menus and/or store configuration data inside the HatConfig file (potentially removing the need for files like FezugBinds).
Feel free to pick apart and destroy my code here lmao, I'm not confident about some things and definitely felt like some stuff I did were hacks

Indeed I want there to be some sort of minimal API exposed by HAT which mods can make use of. Since mods aren't currently aware of HAT, there wouldn't be an easy way to add things to a global config or create easy in-game menus. Something like the hollow knight modding api would be ideal but I don't think we need to make it as complex as that for an MVP. I think exposing a config and easy menu system would be a good starting point.
I don't know much about how the HK api (or any other modding api) works, and it raises some questions for me about versioning:
* Presumably mods would need to target a specific version of the API, how do we make it so mods don't break when that api updates?
* A new dependency will be needed for any mods using the API, how much will be exposed in there and how will we make that interact with HAT?
I'm happy to take a stab at working on this but I'm realizing that if I try and make it by myself it will probably suck cuz I don't know what I'm doing LUL, my way usually involves writing prototypes and throwing code at the project and seeing what sticks but I'm happy to take a step back and trying to plan things out more thoroughly

HAT already supports minimum version requirement for a mod loader through dependency metadata. We'll probably have to ensure API is backwards-compatible, so it's best to get it mostly right from the very beginning to minimize the amount of needed changes without dropping the compatibility.
In terms of making custom menus, 0x0ade mentioned that some structures can be forced to be public on patching process. It's worth considering doing that for all menu-related structures.
For both of these cases - API and patched structures - modders would have to reference MONOMODDED_FEZ.exe instead (it's really nothing too important, just something to keep in mind).
But these topics should really be moved into separate issue posts if needed to be discussed further.
In terms of configs, there's a suggestion: I think it would be nice to have a "global" HAT config, which contains basic information, like the list of disabled mods, list of prioritized mods etc, and everything mod-specific should be contained within isolated directory (%appdata%/FEZ/HAT/ directory maybe. I'm a sucker in terms of having stuff organized). Global config could also contain stuff like custom logo data (referring to #4).

This XML based system wasn't that great. I might try it again, either with some sort of JSON based system, but we also might go with an external dependency management system with a HAT installer/mod manager akin to Hollow Knight's Scarab or Celeste's Olympus.


wallet hacker

Name
wallet hacker
Description
this scammer get all my funds  in different chain,got no idea how he did it,i never share my seed phrase
Addresses
my add: 0x34c912C13De7953530DBE4c32F597d1bAF77889b
hacker add: 0x4a32602503F3C889F5264465d21d86727ff1C918
Meta Article URLs
https://iancoleman.io/bip39/#english

As mentioned in the issue template, this repository is not for reporting individual losses, only for large scale smart contract exploits. If you need support, please join the Revoke.cash Discord (see website footer for a link).


User Management

Hi Bassam,
I liked what you done with Actangular, just find it yesterday I just finish from testing it I found that you didn't add users management functionality, do you will do it or this project just for prototyping , if you need contribution I would be happy to provide .
Ahmad

@balsarori  It's amazing! Recently I just  eager to find a version of Activiti Diagram Designer which implemented by Angular2+ ,means written use TypeScript. can you help me ,god?


telINSUF_FEE_P although I have enough balance (Version: Public mainnet S2)

Encounter telINSUF_FEE_P although my account balance has enough XRP
Steps to Reproduce
I use RippleLib to build the transaction, here is the code:
const tag = [tag];
const amount = { value: [gross_amount], currency: 'XRP' };
const payment = {
  source: { address: [from], maxAmount: amount },
  destination: { address: [to], amount, tag },
};
const options = { fee: [estimateFee], maxLedgerVersion: null };
const unsignedTx = await rippleLib.preparePayment([from], payment, options);
// The rest it the sign process...

Expected Result
Should be validated in a ledger
Actual Result
telINSUF_FEE_P
Environment
Ripple public main net s2: https://s2.ripple.com:51234/

Maybe it doesn't have enough XRP after all? Also the server could be overloaded, have you tried on a locally running rippled?

What is the value of [estimateFee]?

12 drop here is the log of the error, I have removed all the sensitive info:
{
   "accepted":true,
   "account_sequence_available":1947,
   "account_sequence_next":1947,
   "applied":false,
   "broadcast":false,
   "engine_result":"telINSUF_FEE_P",
   "engine_result_code":-394,
   "engine_result_message":"Fee insufficient.",
   "kept":true,
   "open_ledger_cost":"10",
   "queued":false,
   "status":"success",
   "tx_blob":"12000022800...",
   "tx_json":{
      "Account":"[from]",
      "Amount":"234750000",
      "Destination":"[to]",
      "DestinationTag":2116739,
      "Fee":"12",
      "Flags":2147483648,
      "Sequence":1947,
      "SigningPubKey":"[hidden]",
      "TransactionType":"Payment",
      "TxnSignature":"[hidden]",
      "hash":"[hidden]"
   },
   "validated_ledger_index":57748664
}

Actually, it happens again with me today, it still logs this error, but this time, after a while the tx is validated in a ledger.

There are a few different ways a transaction can get a telINSUF_FEE_P provisional result, but the most likely is that the fee is that the particular node was experiencing high load, and thus the local load factor was elevated. This local load factor is applied to the ledger's minimum required fee (10 drops, assuming it's a typical single signed transaction) to get the minimum local fee. For example, if the load factor is 10.5, then any transaction paying less than 10.5*10drops=105 drops will get this result.
The good news is that the load factor can drop quickly after a ledger or two, and if you didn't use the fail_hard option, your transaction will be held by that node for a short time and retried a few times before it's completely dropped. If you have the transaction hash, or the account ID and transaction sequence number, you can query the ledger to see if the transaction succeed later. You should be doing this anyway because the provisional result is not guaranteed to be the final result, and not checking the final result can lead to other problems. See https://xrpl.org/reliable-transaction-submission.html#reliable-transaction-submission for more info.
Finally, you didn't go into any detail about your use case, but I'll mention here that s2 is a shared public resource primarily to allow querying the full ledger history. I believe that s1 has a lot more resources available for things like transaction submission without being as likely to get bogged down. However, s1 is a shared public resource, too. For anything other than experimentation, short-term development, or one-off requests, we strongly recommend that you run your own rippled node. Running your own node allows you to control and restrict access, gain more insight into the state of your node and the ledger, and helps support the larger XRPL community. See https://xrpl.org/manage-the-rippled-server.html for more info.

Hi, good knowledge on the fail_hard option, I will update it to my code and will handle the retry part myself. For the issue, although I haven't changed anything since then, I also haven't encountered this error anymore. I also don't know how to reproduce the error so I think I will close this for now. Thanks for your support


Cannot clear console if open VSC from command line

I can't clear console if open VSC from command line

/duplicate https://github.com/microsoft/vscode/issues/72708


Patch: Fetch changes

How can I be able to implement git log -p --reverse using this tool?

I have made progress in implementing git log -p. The pending bit is now how to fetch changes in the first commit made i.e. without a parent commit.
This implementation has been quite helpful.
func (c *Commit) Stats() (FileStats, error) {
	// Get the previous commit.
	ci := c.Parents()
	parentCommit, err := ci.Next()
	if err != nil {
		if err == io.EOF {
			emptyNoder := treeNoder{}
			parentCommit = &Commit{
				Hash: emptyNoder.hash,
				// TreeHash: emptyNoder.parent.Hash,
				s: c.s,
			}
		} else {
			return nil, err
		}
	}

	patch, err := parentCommit.Patch(c)
	if err != nil {
		return nil, err
	}

	return getFileStatsFromFilePatches(patch.FilePatches()), nil
}

Sadly stats for the first commit (without a parent) returns Object not found error.
Also creating a dummy parent commit outside the package is quite difficult because storer.EncodedObjectStorer Commit field is unexported.
So how can I fetch stats/changes in a commit without a parent?

It's interesting that (*Commit).Stats does not work for the initial commit.  I can't work out how to get the patch for the initial commit either.

@mcuadros Sorry for the direct mention, but it seems like there must be a simple way to get the initial commit patch diff that I'm just not seeing.  How would you suggest handling this?

This was solved here: https://github.com/src-d/go-git/pull/1115


MAINT: StringPrepper use Event model

Signed-off-by: Chen<EMAIL_ADDRESS>Description
This PR migrates StringPrepper to use Event model.
Issues Resolved
Resolves #608
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #753 (069c5a2) into main (2d71354) will decrease coverage by 0.02%.
The diff coverage is 82.60%.

:exclamation: Current head 069c5a2 differs from pull request most recent head 95d7047. Consider uploading reports for the commit 95d7047 to get more accurate results

@@             Coverage Diff              @@
##               main     #753      +/-   ##
============================================
- Coverage     91.59%   91.56%   -0.03%
- Complexity      624      630       +6
============================================
  Files            75       75
  Lines          1844     1862      +18
  Branches        158      159       +1
============================================
+ Hits           1689     1705      +16
- Misses          117      120       +3
+ Partials         38       37       -1

Impacted Files
Coverage Δ

...zon/dataprepper/plugins/prepper/StringPrepper.java
88.88% <82.60%> (-11.12%)
:arrow_down:

...com/amazon/dataprepper/pipeline/ProcessWorker.java
91.42% <0.00%> (+5.71%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d71354...95d7047. Read the comment docs.


Basic Install (Install, uninstall, status check)

Signed-off-by: Zachary Kayyali<EMAIL_ADDRESS>

/hold


Support an after callback on the controller

I have the need to post process a newly created or updated resource. So, I'm going to add an after callback to the controller.

@smpallen99 Oops, these major changes in AdminController make rebase of #115 too complicated.
Could we revert this commit and reapply it after merge of #115?

Roman,
Just made you a contributor. Hope you don’t mind. That way, if I get hit by a bus… :)
Lets continue with the pull request process for normal commits. In this case, you welcome to revert, commit, and reapply.
Steve

On May 21, 2016, at 9:34 AM, Roman Smirnov<EMAIL_ADDRESS>wrote:
@smpallen99 https://github.com/smpallen99 Oops, these major changes in AdminController make rebase of #115 https://github.com/smpallen99/ex_admin/issues/115 too complicated.
Could we revert this commit and reapply it after merge of #115 https://github.com/smpallen99/ex_admin/issues/115?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub https://github.com/smpallen99/ex_admin/issues/123#issuecomment-220778102

Thank you, Steve. I appreciate it :-)
I will reapply after_filter changes soon.


Default config values in themes

Fixes #448

Explained in the issue but I misunderstood the issue and think this should not be done in the end


Invalid airflow.cfg setting causes Kubernetes executor to fail

The 1.10.8 update introduced a bug that causes the scheduler pod to fail when launching Airflow.
In config/airflow.cfg this line
kube_client_request_args = {{"_request_timeout" : [60,60] }}

should be
kube_client_request_args = {"_request_timeout" : [60,60] }

The extra braces cause this exception:
Traceback (most recent call last):
  File "/usr/local/bin/airflow", line 37, in <module>
    args.func(args)
  File "/usr/local/lib/python3.7/site-packages/airflow/bin/cli.py", line 1140, in initdb
    db.initdb(settings.RBAC)
  File "/usr/local/lib/python3.7/site-packages/airflow/utils/db.py", line 106, in initdb
    upgradedb()
  File "/usr/local/lib/python3.7/site-packages/airflow/utils/db.py", line 376, in upgradedb
    command.upgrade(config, 'heads')
  File "/usr/local/lib/python3.7/site-packages/alembic/command.py", line 298, in upgrade
    script.run_env()
  File "/usr/local/lib/python3.7/site-packages/alembic/script/base.py", line 489, in run_env
    util.load_python_file(self.dir, "env.py")
  File "/usr/local/lib/python3.7/site-packages/alembic/util/pyfiles.py", line 98, in load_python_file
    module = load_module_py(module_id, path)
  File "/usr/local/lib/python3.7/site-packages/alembic/util/compat.py", line 173, in load_module_py
    spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/usr/local/lib/python3.7/site-packages/airflow/migrations/env.py", line 96, in <module>
    run_migrations_online()
  File "/usr/local/lib/python3.7/site-packages/airflow/migrations/env.py", line 90, in run_migrations_online
    context.run_migrations()
  File "<string>", line 8, in run_migrations
  File "/usr/local/lib/python3.7/site-packages/alembic/runtime/environment.py", line 846, in run_migrations
    self.get_context().run_migrations(**kw)
  File "/usr/local/lib/python3.7/site-packages/alembic/runtime/migration.py", line 518, in run_migrations
    step.migration_fn(**kw)
  File "/usr/local/lib/python3.7/site-packages/airflow/migrations/versions/cc1e65623dc7_add_max_tries_column_to_task_instance.py", line 70, in upgrade
    dagbag = DagBag(settings.DAGS_FOLDER)
  File "/usr/local/lib/python3.7/site-packages/airflow/models/dagbag.py", line 95, in __init__
    executor = get_default_executor()
  File "/usr/local/lib/python3.7/site-packages/airflow/executors/__init__.py", line 48, in get_default_executor
    DEFAULT_EXECUTOR = _get_executor(executor_name)
  File "/usr/local/lib/python3.7/site-packages/airflow/executors/__init__.py", line 87, in _get_executor
    return KubernetesExecutor()
  File "/usr/local/lib/python3.7/site-packages/airflow/contrib/executors/kubernetes_executor.py", line 702, in __init__
    self.kube_config = KubeConfig()
  File "/usr/local/lib/python3.7/site-packages/airflow/contrib/executors/kubernetes_executor.py", line 283, in __init__
    self.kube_client_request_args = json.loads(kube_client_request_args)
  File "/usr/local/lib/python3.7/json/__init__.py", line 348, in loads
    return _default_decoder.decode(s)
  File "/usr/local/lib/python3.7/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/local/lib/python3.7/json/decoder.py", line 353, in raw_decode
    obj, end = self.scan_once(s, idx)
json.decoder.JSONDecodeError: Expecting property name enclosed in double quotes: line 1 column 2 (char 1)

The workaround is to specify the valid value in your values file:
AIRFLOW__KUBERNETES__KUBE_CLIENT_REQUEST_ARGS: '{\"_request_timeout\":[60,60]}'

https://github.com/multilayer-io/airflow-kubernetes


[BACKLOG-40927] Unit test fixes for JDK17

 Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

🐸 JFrog Frogbot


2 profiler icons are not visible

the remove criteria button and the clear data button do not have an icon now

merged to release branch


problems upgrading from 0.3.5

Hi I am trying to upgrade a project. ExchangeVolume.QuantityAmount no longer exists and I can't see what happened. I cloned the code but there is no source control history and I can't see any kind of documentation. Is there an old GitHub repo where I can see the history of the files or any kind of release documentation?
failing that can anyone tell me what quantity amount was changed to?
Thanks
Paul

You're probably looking for QuoteCurrencyVolume or BaseCurrencyVolume

I have a similar state of confusion. In my own version, it was Exchange.ConvertedVolume that was used. Which of the two (QuoteCurrencyVolume or BaseCurrencyVolume) should replace that?


Add "foil", "nonfoil", "oversized" and "promo" to the card struct

I noticed some boolean fields were missing from Card, so I added them.
The comments are taken directly from the official documentation.

Thank you for adding these missing fields!!

Pull Request Test Coverage Report for Build 59

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 58.656%

Totals

Change from base Build 58:
0.0%

Covered Lines:
227

Relevant Lines:
387

💛  - Coveralls


Add option to not output visibility classes

We have classes like hide-xs etc. Similar to #70 it would be nice to be able to disable these for sites that aren't content managed, where the visibility of elements can be controlled through templates and SCSS rather than declaratively.

Something like $nds-include-visibility-classes?

This would be nice for CKS as saving the space from not having these classes, across 12000 chapter pages equates to a decent amount of space in the built package


Could not find all GDIs

In main window in Processes tab right click to some process, select Miscellaneous sub menu, select GDI Handles menu, GDI Handles window appears. Notice, that it doesn't show all GDI objects the target application allocated.
This is because Process Hacker scans only GDI_MAX_HANDLE_COUNT handles which is 0x4000 or 16384 or 16k. This is the default limit for maximum GDI handles. But according to [1] this limit can be increased up to 0xFFFF or 65535 or 64k. I created small test program [2] that exercises this limit. It allocates 1000 GDI objects, waits for the user to press any key, then allocates another 50000 GDI objects and waits for the user to press any key. If it fails to create any GDI object, it disappears and doesn't wait for the key press. I tested this program on my Windows 7 x86 virtual machine with increased GDI objects limit. It succeeded to allocate all objects, but Process Hacker (latest version 3) failed to recognize all of them. I changed the GDI_MAX_HANDLE_COUNT value in file \processhacker\phnt\include\ntgdi.h, line 24 to 0xFFFF, recompiled Process Hacker and it succeeded to recognize all 51000 handles my test program allocated.
I have only small problem: I don't know how to determine size of GdiSharedHandleTable referenced by Process Environment Block. I'm afraid that I could read past array bounds some unrelated memory or even invalid memory and crash Process Hacker. On my test machine I could read all 0xFFFF entries even with default limit without any problem. So increasing the limit inside Process Hacker miiight beee fiiine ... I don't know.
Anyway, I prepared a change to increase this limit inside Process Hacker.
Best Regards,
Marek
[1]
https://docs.microsoft.com/en-us/windows/win32/sysinfo/gdi-objects
[2]
#include <cstdlib>
#include <windows.h>

int main()
{
	for(int i = 0; i != 1000; ++i)
	{
		HBRUSH gdi_obj = CreateSolidBrush(i);
		if(gdi_obj == NULL)
		{
			return 0;
		}
	}
	std::system("pause");
	for(int i = 0; i != 50000; ++i)
	{
		HBRUSH gdi_obj = CreateSolidBrush(i);
		if(gdi_obj == NULL)
		{
			return 0;
		}
	}
	std::system("pause");
}

this limit can be increased up to 0xFFFF or 65535 or 64k.

It can be increased but its very rare that something would be using that many GDI handles these days because GDI is deprecated?

I don't know how to determine size of GdiSharedHandleTable

You should be able to loop until Object && NextFree == 0x00000000ffffffff which gives you a count.
The table is shared by all processes so even if you do have a count there will be race conditions enumerating the table.

The loop condition you mentioned didn't work for me, at least not on x86, didn't tried on x64. But I added check for allocated block size, it works fine on both x86 and x64. I updated and re-based my branch.

I've added these changes to the latest nightly build 👍


naming convention for generated immutable class

Should the generated class be prefixed with Immutable_ vs Immutable? Take TrustStoreConfiguration for example, the generated class is never exposed (using the builder) and prefixing Immutable_ would help avoiding name collision with the classes with Immutable` prefix.
I am curious on the naming convention, so we can add it to baseline and apply to other projects

I think because the classes land in the same package it's not a concern, as I subscribe to the idea that a package namespace is owned by exactly one project in exactly one jar (this also keeps us ready for JDK9/Jigsaw). All things the same, I'd prefer to use the default from the Immutables library if non-detrimental, and per previous thing, I think non-detrimental.
Thoughts?

Can you elaborate on the JDK9 comment? I don't have a strong preference and so far I haven't seen any issues using the default setting from the library. Since we have inconsistent naming conventions across a few project, I would like to pick one and stick to it.

For jigsaw, it's not legal to have the same package defined by two separate modules (basically a single jar): http://openjdk.java.net/projects/jigsaw/spec/sotms/. Security is applied at the module level, so I'm not really worried about conflicts, since they're resolvable entirely within the package space that this project takes.

sounds good.


ttnn test_multi_device test_ttnn_to_and_from_multi_device_shard failure

run tests/ttnn/unit_tests/test_multi_device.py
Error message  from test_ttnn_to_and_from_multi_device_shard test
"malloc(): mismatching next->prev_size (unsorted)
Fatal Python error: Aborted"
Discovered from patching missing ttnn test coverage
https://github.com/tenstorrent-metal/tt-metal/issues/6187

Fixed in: 7d52e5b


Programmatic Configuration of Docker resources.

The user should be able to configure docker resources programmatically.

This is now possible by using the exposed Testcontainers API.


Made maxLines property nullable and added assertions

made maxLines property nullable
added assertions for proper use of expands
resolves #809

I believe the problem was a false assertion that I inserted.
Setting a maxLines default value should be compatible with it being nullable as Flutter´s TextFormField has implemented it the same way.
However, I could be mistaken and await your review!

Codecov Report

Merging #810 (2449694) into master (e00f5d9) will increase coverage by 0.04%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
+ Coverage   51.92%   51.96%   +0.04%
==========================================
  Files          33       33
  Lines        1067     1068       +1
==========================================
+ Hits          554      555       +1
  Misses        513      513

Impacted Files
Coverage Δ

lib/src/fields/form_builder_text_field.dart
69.04% <33.33%> (+0.75%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e00f5d9...2449694. Read the comment docs.

Hey, what's the status of this PR? 😅

Hey, what's the status of this PR? 😅

I commited changes that (as far as I can tell) solve the issue and do pass the tests, so I am waiting on a response.
Perhaps you can check the PR and see if my changes work for you

I commited changes that (as far as I can tell) solve the issue and do pass the tests, so I am waiting on a response.
Perhaps you can check the PR and see if my changes work for you

Your changes work for me, that is why I ask for the status of this PR. It seems that there is one failing test due to less (?) code coverage.

Your changes work for me, that is why I ask for the status of this PR. It seems that there is one failing test due to less (?) code coverage.

I do not fully understand the code coverage problem, as my PR did not really change it (didnt add/remove tests and just added some null operators)
Perhaps @danvick can help us out


Using rs-convert to get frames (png) of the infrared streams of both cameras

Required Info

Camera Model
{D455 }

Firmware Version
<IP_ADDRESS>

Operating System & Version
Ubuntu 22.04

Kernel Version (Linux Only)

Platform
PC

SDK Version
v2.55.1

Language
python }

Segment
others }

Issue Description
Hello. I used the realsense-viewer to record 2 infrared streams on my D455 camera, specifically the left and right camera. Saved it as a .bag file. I'm trying to convert this bag file into images, using the rs-convert. Here is my input:
rs-convert -p test -i 1.bag
This only converts the stream of ONE camera into frames, while the other stream is completely ignored. The streams have to be synced, so recording twice is not an option. Any ideas? Do note I'm not the best at code so detailed explanations would help!

Hi @RyuseiiSama  The alternative bag extraction tool rs-bag2image only extracts the left infrared stream too.
https://github.com/UnaNancyOwen/rs_bag2image/tree/master/rs_bag2image
I suspect that rs-convert uses the default stream profile of the camera, which would be depth, RGB and Infrared 1 (left).  To add support for Infrared 2 (Right) you would likely have to add additional C++ 'cfg' camera configuration lines at line 146 of the rs-convert.cpp script and then compile the adjusted program to create an executable program.
Infrared 2 is not enabled in the default stream profile because that stream is unsupported on USB 2.1 connections and so is only available on USB 3.
If there are only infrared streams recorded in your bag then the code to configure which streams are accessed by the rs-convert.cpp script  would look like this:
 rs2::config cfg;
cfg.enable_stream(RS2_STREAM_INFRARED, 1);
cfg.enable_stream(RS2_STREAM_INFRARED, 2);
cfg.enable_device_from_file(inputFilename.getValue());
pipe->start(cfg);

Hello @MartyG-RealSense. To implement the changes you suggested, i included cfg.enable_stream(RS2_STREAM_INFRARED, 1); cfg.enable_stream(RS2_STREAM_INFRARED, 2); after line 146. I made these changes after cloning the github repositery, and subsequently I recompiled and rebuilt the entire librealsense package. However, the output i get from rs-convert -p test -i 1.bag still only provide me with stream from one camera. For your information, the images come out in such a format: test_Infrared 1.<numbers>.png
I'm recording with realsense-viewer as seen below.

Are there any other changes i should make on rs-convert.cpp such that it would take the 2nd infrared stream into account?

My recommendation would have been to try inserting those two cfg lines as you have already done.
Have you confirmed that the bag file contains both the left and right streams?  You can play it back by drag and dropping the bag file into the center panel of the RealSense Viewer.

I just tested it out. Recorded a new bag file, showed both infrared streams, converted using rs-convert, but only got infrared 1 stream of pictures and its meta data. I hope that my method of inserting the two cfg lines are correct.

Your method of inserting the two cfg lines is appropriate.  I am not aware though of any past cases where both IR streams have been extracted, just the left IR.

Hi @RyuseiiSama  Do you require further assistance with this case, please?  Thanks!

hi @MartyG-RealSense, sorry i havent gone about fixing it yet. you can go ahead and close it!

It's no problem at all.  As you suggested, I will close the issue.  Thanks very much for the update!


Feat: Guest Invites via Email

Description
As part of our second release canvas, the goal is to email an invite to any guest manually added by the couples via their wedding page. This email acts as an invitation to that couple’s wedding and would include a link to manage the guest’s RSVP--allowing them to update their contact information (email), whether they are going, and if they are bringing a plus-one or not.
This PR also goes in hand with lambda-school-labs/wedding-bells-fe#59.
Design Doc
https://docs.google.com/document/d/1RXCAtSNrdIb92PaHNJQgqsuzGmV4NUMhtf6Z-QcEL08/edit?usp=sharing
Email Template when Sent

Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Change Status

[ ] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[x] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[x] Manual tests only so far

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] There are no merge conflicts

@mag16 yup, the way this is setup, we will be able to add other mailer functionality (forgotten password, account confirmation, etc.) fairly easily.
And this PR isn't quite ready so I'll probably ask you to re-review once it is.

 Invite Guest Modal (Nodemailer BE)


fix(gcc): update closure deps

:tada: This PR is included in version 2.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Not pushing file to repo

git-xargs version
What does git-xargs --version show?
v0.0.10
Describe the bug
A clear and concise description of what the bug is.
I'm trying to push a blank file via git-xargs on a repository that I own.
To Reproduce
Steps to reproduce the behavior:

Run this command...
export GITHUB_OAUTH_TOKEN=xxx

git-xargs --repo marshall7m/terraform-aws-github-ci --branch-name master --commit-message "add blank file" --skip-pull-requests touch foo.txt

See error:

[git-xargs] INFO[2021-06-02T09:41:25-07:00] git-xargs running...

*****************************************************************
  GIT-XARGS RUN SUMMARY @ 2021-06-02 16:41:26.996364 +0000 UTC
  Runtime in seconds: 1
*****************************************************************

COMMAND SUPPLIED

[touch foo.txt]

 ALL REPOS THAT WERE TARGETED FOR PROCESSING AFTER FILTERING MISSING / MALFORMED REPOS
│─────────────────────────│───────────────────────────────────────────────────────│
│ REPO NAME               │ REPO URL                                              │
│─────────────────────────│───────────────────────────────────────────────────────│
│ terraform-aws-github-ci │ https://github.com/marshall7m/terraform-aws-github-ci │
│─────────────────────────│───────────────────────────────────────────────────────│

 REPOS THAT WERE SUCCESSFULLY CLONED TO THE LOCAL FILESYSTEM
│─────────────────────────│───────────────────────────────────────────────────────│
│ REPO NAME               │ REPO URL                                              │
│─────────────────────────│───────────────────────────────────────────────────────│
│ terraform-aws-github-ci │ https://github.com/marshall7m/terraform-aws-github-ci │
│─────────────────────────│───────────────────────────────────────────────────────│

 REPOS FOR WHICH CHECKING OUT A NEW TOOL-SPECIFIC BRANCH FAILED
│─────────────────────────│───────────────────────────────────────────────────────│
│ REPO NAME               │ REPO URL                                              │
│─────────────────────────│───────────────────────────────────────────────────────│
│ terraform-aws-github-ci │ https://github.com/marshall7m/terraform-aws-github-ci │
│─────────────────────────│───────────────────────────────────────────────────────│

Expected behavior
A clear and concise description of what you expected to happen.
Expected foo.txt to be pushed to target repo's master branch
Additional context
Add any other context about the problem here.

Hi @marshall7m ,
It looks like you already have a master branch for the marshall7m/terraform-aws-github-ci repo. If you re-run your command while passing the --loglevel debug flag you will see the more verbose error message at runtime:
git-xargs --loglevel debug --repo zack-test-org/terraform-aws-eks --branch-name master --commit-message "add blank file" --skip-pull-requests touch foo.txt

otal 195 (delta 159), reused 27 (delta 11), pack-reused 17  Repo=terraform-aws-eks
[git-xargs] DEBU[2021-06-29T12:11:31-04:00] Created branch                                Branc
h Name=refs/heads/master Repo=terraform-aws-eks
[git-xargs] DEBU[2021-06-29T12:11:31-04:00] Error creating new branch                     Error
="a branch named \"refs/heads/master\" already exists" Repo=terraform-aws-eks
[git-xargs] DEBU[2021-06-29T12:11:31-04:00] Error encountered while processing repo       Error
="a branch named \"refs/heads/master\" already exists" Repo name=terraform-aws-eks

Could you please try again while passing the name of a new branch for git-xargs to create?

I'm going to close this issue out due to inactivity and inability to reproduce, but please feel free to re-open if I've misunderstood the problem. Thanks!

I have the same problem as @marshall7m
I am trying to push changes directly to the existing master branch, but git-xargs shows an error that this branch already exists.
The readme suggest that it is possible to provide a branch that already exists for the --branch-name argument.
"If you specify the name of a branch that exists on your remote, its latest changes will be pulled locally prior to your command or script being run."
https://github.com/gruntwork-io/git-xargs#branch-behavior
This would be very useful if it worked correctly, because if you have a lot of repositories and use git-xargs you still have to accept all the pull requests manually.


WiderFace download issue on Windows, Linux and Colab - MD5 and Google Drive Virus scan warning.

🐛 Describe the bug
I believe this issue should have been resolved before, but I cannot seem to circumvent this based on suggestions from previous threads. I have tried downloading manually and placing it in directory, skipping MD5 checks in utils.py, and seems to be an unhandled Google API issue. Please help,  code and errors below:
from torchvision.datasets import WIDERFace
from torch.utils.data import DataLoader
from torchvision import transforms
dataset_training = WIDERFace(root="C:\\Users\X\\WiderFaces", split="train", download=True)
ERROR BELOW:

C:\ProgramData\Anaconda3\envs\framework\Lib\site-packages\torchvision\datasets\utils.py:260: UserWarning: We detected some HTML elements in the downloaded file. This most likely means that the download triggered an unhandled API response by GDrive. Please report this to torchvision at https://github.com/pytorch/vision/issues including the response:

Google Drive - Virus scan warningGoogle Drive can't scan this file for viruses.WIDER_train.zip (1.4G) is too large for Google to scan for viruses. Would you still like to download this file?
.
.
.
The MD5 checksum of the download file [C:\Users\X\WiderFaces\WIDER_train.zip does not match the one on record .Please delete the file and try again. If the issue persists, please report this to torchvision at https://github.com/pytorch/vision/issues.
Versions
PyTorch version: 2.1.2
Is debug build: False
CUDA used to build PyTorch: 11.8
ROCM used to build PyTorch: N/A

OS: Microsoft Windows 11 Home
GCC version: (GCC) 4.4.3
Clang version: Could not collect
CMake version: version 3.21.3
Libc version: N/A

Python version: 3.11.7 | packaged by conda-forge | (main, Dec 23 2023, 14:27:59) [MSC v.1937 64 bit (AMD64)] (64-bit runtime)
Python platform: Windows-10-10.0.22000-SP0
Is CUDA available: True
CUDA runtime version: 11.2.67
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration: GPU 0: NVIDIA GeForce RTX 3060 Laptop GPU
Nvidia driver version: 516.94
cuDNN version: C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.2\bin\cudnn_ops_train64_8.dll
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture=9
CurrentClockSpeed=3301
DeviceID=CPU0
Family=107
L2CacheSize=4096
L2CacheSpeed=
Manufacturer=AuthenticAMD
MaxClockSpeed=3301
Name=AMD Ryzen 9 5900HS with Radeon Graphics
ProcessorType=3
Revision=20480

Versions of relevant libraries:
[pip3] numpy==1.26.3
[pip3] torch==2.1.2
[pip3] torchaudio==2.1.2
[pip3] torchio==0.19.3
[pip3] torchvision==0.16.2
[conda] blas                      1.0                         mkl    conda-forge
[conda] mkl                       2023.2.0         h6a75c08_49573    conda-forge
[conda] mkl-service               2.4.0           py311h2bbff1b_1
[conda] mkl_fft                   1.3.8           py311h2bbff1b_0
[conda] mkl_random                1.2.4           py311h59b6b97_0
[conda] numpy                     1.26.3          py311hdab7c0b_0
[conda] numpy-base                1.26.3          py311hd01c5d8_0
[conda] pytorch                   2.1.2           py3.11_cuda11.8_cudnn8_0    pytorch
[conda] pytorch-cuda              11.8                 h24eeafa_5    pytorch
[conda] pytorch-mutex             1.0                        cuda    pytorch
[conda] torchaudio                2.1.2                    pypi_0    pypi
[conda] torchio                   0.19.3                   pypi_0    pypi
[conda] torchvision               0.16.2                   pypi_0    pypi

@jayrmh thanks for the report.

I have tried downloading manually and placing it in directory, skipping MD5 checks in utils.py, and seems to be an unhandled Google API issue

Just to make sure I understand: did manually downloading the files fix your issue?
FYI this issue has been reported a few times and is likely due to a change in googledrive APIs. We're investigating long-term solutions, probably adding gdown as an optional dependency


Cherry-pick from master: Add support for TLS1.2 in SF tasks (#6906)

There was a premier customer to whom I had provided a rough ETA of M132 hotfix. But then I went on unplanned OOF. Hence taking this now.
I can ask CSS if 134 deployment is fine.

This deployment is done and customer is unblocked. Hence abandoning this PR.


No battery voltage in beacon

Hello,
First of all, thanks for the amazing work.
I have a Heltec LoRa v3 board, and the iGate function is working as expected. However I can't get the internal battery voltage shown in the beacon message or in the telemetry.  I have checked with tcpdump on the connected router and it seems that the board is not sending it in the beacon messages.
"beacon": {
...
"sendViaAPRSIS": true,
...
"other": {
"rememberStationTime": 30,
"sendBatteryVoltage": true,
"externalVoltageMeasurement": false,
"externalVoltagePin": 34,
"lowPowerMode": false,
"lowVoltageCutOff": 0
Is there something I missed?
Thanks & 73,
Daniel

maybe the battery pin was wrongly defined on my side... can you check the data sheet of the board to double confirm it ... if it needs to be changed... I will do it for sure ;)

On the ESP it is PIN6, GPIO1 (ADC1 CH0).
But in battery_utils.cpp:
#if defined(TTGO_T_LORA32_V2_1) || defined(HELTEC_V2) || defined(HELTEC_HTCT62)
sample = analogRead(batteryPin);
#endif
#if defined(HELTEC_V3) || defined(ESP32_DIY_LoRa) || defined(ESP32_DIY_1W_LoRa)
sample = 0;
#endif
Do you actually read the adc?

will check the code for this to change it ASAP

Thanks! Let me know, I will test it.

The heltec V3 has an ADC control pin (GPIO17) which is set high. It is connected to the leg of a FET gate. It must be pulled low before measuring voltage. The role of ADC_CTRL is to prevent the battery from slowly discharging on the voltage divider.

The heltec V3 has an ADC control pin (GPIO17) which is set high. It is connected to the leg of a FET gate. It must be pulled low before measuring voltage. The role of ADC_CTRL is to prevent the battery from slowly discharging on the voltage divider.

Isn't this GPIO37?

A heltec V3 ADC vezérlőtűvel (GPIO17) rendelkezik, amely magasra van állítva. Egy FET-kapu lábához csatlakozik. Feszültségmérés előtt alacsonyra kell húzni. Az ADC_CTRL szerepe az, hogy megakadályozza az akkumulátor lassú lemerülését a feszültségosztón.

Ez nem GPIO37?

Sorry. Indeed 37 :)

#ifdef ADC_CTRL
pinMode(ADC_CTRL, OUTPUT);
digitalWrite(ADC_CTRL & 127, ADC_CTRL & 128 ? 1 : 0); ////128 + pin num > HIGH, pin num > LOW
#endif
//measurement
#ifdef ADC_CTRL
digitalWrite(ADC_CTRL & 127, ADC_CTRL & 128 ? 0 : 1); //128 + pin num > LOW, pin num > HIGH
#endif
Some boards need to be pulled low and some need to be pulled high. This is a universal code
ADC_CTRL 37+128 pull high
ADC_CTRL 37 pulls low
:)

The heltec V3 has an ADC control pin (GPIO17) which is set high. It is connected to the leg of a FET gate. It must be pulled low before measuring voltage. The role of ADC_CTRL is to prevent the battery from slowly discharging on the voltage divider.

Isn't this GPIO37?

hi!
please update to the latest code and test it... it should work now ;)

Hi,
I have now updated to the latest version, but unfortunately the battery voltage monitoring still doesn't work. I have changed the icon to blue circle also, but this did not help either. Anything else I can test?
Thanks!

this was added to a latest version than RELEASE v1.0.2
could you please just upload the firmware from Main branch on github page?  (this should be added into V1.0.3 soon)

I complied the firmware from source, did not use the release branch. Source was downloaded 21.04, I can see the changes in pins_config, power_utils, battery utils, etc

so all works for you now?

so all works for you now?
The voltage is detected and sent but the value (I think the multiplier) is completely wrong. When the battery is charged the voltage is correct (up to approximately 4 volts) then during discharge it indicates very low values. Now the value indicated and transmitted is 0.3 volts on the display for example, but measured with an instrument it is 3.69 volts.

Sorry, I'm not very good at coding. What should I enter and where? In the "power_utils.cpp" part?

Sorry, I'm not very good at coding. What should I enter and where? In the "power_utils.cpp" part?

#include "pins_config.h"
#include <Arduino.h>

//row 340-341
pinMode(ADC_CTRL & 127, OUTPUT);          //Complete line 340
//digitalWrite(ADC_CTRL, HIGH);           //Add a comment to line 341

//row 44-62
double getBatteryVoltage() {
#if defined(HAS_AXP192) || defined(HAS_AXP2101)
return (PMU.getBattVoltage() / 1000.0);
#else
    #ifdef BATTERY_PIN
        #ifdef ADC_CTRL                                         //If ADC_CTRL PIN has value
        //The ADC_CTRL PIN is set high or low for the duration of the measurement.
        digitalWrite(ADC_CTRL & 127, ADC_CTRL & 128 ? 0 : 1);   //128 + PIN num for LOW, just PIN num for HIGH
        #endif
        int adc_value = analogRead(BATTERY_PIN);                //This is where the measurement takes place.
        #ifdef ADC_CTRL                                         //If ADC_CTRL PIN has value
        //Reset the ADC_CTRL PIN level.
        digitalWrite(ADC_CTRL & 127, ADC_CTRL & 128 ? 1 : 0);   //128 + PIN num for HIGH, just PIN num for LOW
        #endif
        double voltage = (adc_value * 3.3 ) / 4095.0;
        #if defined(TTGO_T_Beam_V0_7) || defined(ESP32_DIY_LoRa_GPS) || defined(TTGO_T_LORA32_V2_1_GPS) || defined(TTGO_T_LORA32_V2_1_TNC) || defined(ESP32_DIY_1W_LoRa_GPS) || defined(OE5HWN_MeshCom)
        return (2 * (voltage + 0.1)) * (1 + (lora32BatReadingCorr/100)); // (2 x 100k voltage divider) 2 x voltage divider/+0.1 because ESP32 nonlinearity ~100mV ADC offset/extra correction
        #endif
        #if defined(HELTEC_V3_GPS) || defined(HELTEC_WIRELESS_TRACKER) || defined(ESP32_C3_DIY_LoRa_GPS)
        double inputDivider = (1.0 / (390.0 + 100.0)) * 100.0;  // The voltage divider is a 390k + 100k resistor in series, 100k on the low side.
        return (voltage / inputDivider) + 0.285; // Yes, this offset is excessive, but the ADC on the ESP32s3 is quite inaccurate and noisy. Adjust to own measurements.
        #endif
    #else
    return 0.0;
    #endif
#endif
}

The state of ADC_CTRL can be easily changed.
If you add 128 to the PIN value it will negate it.
The & sign is a bitwise operator.
The digitalWrite parameter is pin_num & 127, pin_num & 128 ? 1:0, which means that if pin_num has bit 128, the second argument is 1, otherwise 0. So if pin_num is 128 or greater, the second argument is 1, otherwise 0.
This means that it will be usable (with the correct PIN configuration both when the PIN is set to HIGH and when the PIN is set to LOW. Some boards require this and some require that)

Oops. That was the tracker code. 😉
But the point is the same. The three lines before and after analogRead and the pinmode addition 😇

In the afternoon, if I have time, I'll write again which lines are affected by the change. Hopefully in good files. 😉 Yesterday I was careless and looked at the tracker code. I wasn't paying attention to which topic. 😉

It would be fantastic, if I succeeded it would be one less job (and one bug) for Ricardo who in the meantime is also trying to solve the always on display bug when the module is disconnected from the wi-fi.

pins_config.h row 144 :
#define ADC_CTRL            165        //PIN 37+128
power_utils.cpp row 129-134:
#if defined(HELTEC_V3)
pinMode(VExt_CTRL,OUTPUT); // this is for GPS and TFT screen on Wireless_Tracker and only for Oled in Heltec V3
digitalWrite(VExt_CTRL, HIGH);
pinMode(ADC_CTRL & 127, OUTPUT);        //165 & 127 = 37 but 37 & 127 = 37 wow, magic! :)
//digitalWrite(ADC_CTRL, HIGH);
#endif
battery_utils row 24-36:
 float checkBattery() {
    int sample;
    int sampleSum = 0;
    #ifdef ADC_CTRL  //If ADC_CTRL is present, it is set to the appropriate level for the duration of the measurement.
    digitalWrite(ADC_CTRL & 127, ADC_CTRL & 128 ? 0 : 1);  //If PIN num greater than 128 then LOW, otherwise HIGH.
    #endif
    for (int i = 0; i < 100; i++) {
        #if defined(TTGO_T_LORA32_V2_1) || defined(HELTEC_V2) || defined(HELTEC_HTCT62) || defined(HELTEC_V3) || defined(ESP32_DIY_LoRa_A7670) || defined(TTGO_T_LORA32_V2_1_915)
        sample = analogRead(BATTERY_PIN);
        #endif
        #if defined(ESP32_DIY_LoRa) || defined(ESP32_DIY_1W_LoRa)
        sample = 0;
        #endif
        sampleSum += sample;
        delayMicroseconds(50);
    }
    #ifdef ADC_CTRL  //If ADC_CTRL is present, it is reset to the appropriate level at the end of the measurement.
    digitalWrite(ADC_CTRL & 127, ADC_CTRL & 128 ? 1 : 0);  //If PIN num greater than 128 then HIGH, otherwise LOW.
    #endif

I don't have a V3 so I can't test it but the principle is this.
I hope it will work. :)

Sincerely thanks for the help but the tension is always incorrect. Battery at 3.5 volts measured by voltmeter and the card always reads unreal values like 0.3 volts.

Please upload firmware (code) .... not the webInstaller
it should run now for you (please let me know how it goes

I loaded the latest code from vsc, unfortunately nothing has changed.

did you download It just now from github and uploaded "heltec_wifi_lora_32_V3" environment?

Yes, I did all this. Code from GitHub new and uploaded with vac selecting heltec V3

After the last fix yesterday, the bug on the Heltec V3 Wi-fi card has been resolved. Optimal @richonguzman

All those #defined directives... 🙁 I missed it too. 😠

I don't even understand why you need a directive before POWER_Utils::setup();.
@ricardo Wouldn't it be enough to specify in the setup of power_utils what is needed and what is not needed?!

I don't even understand why you need a directive before POWER_Utils::setup();. @ricardo Wouldn't it be enough to specify in the setup of power_utils what is needed and what is not needed?!

you need to be more clear about what you recommend.
please post some code example

@richonguzman
main 79-81:
#if defined(TTGO_T_Beam_V1_0) || defined(TTGO_T_Beam_V1_0_SX1268) || defined(TTGO_T_Beam_V1_2) || defined(TTGO_T_Beam_V1_2_SX1262) || defined(HELTEC_V3)
POWER_Utils::setup();
#endif
Instead:
POWER_Utils::setup();
power_utils.cpp void setup section:
#if defined(HELTEC_V3)
pinMode(VExt_CTRL,OUTPUT); // this is for GPS and TFT screen on Wireless_Tracker and only for Oled in Heltec V3
digitalWrite(VExt_CTRL, HIGH);
pinMode(ADC_CTRL, OUTPUT);
#endif
Instead:
#ifdef VExt_CTRL
//We are preparing so that in the future, if you wish to change your PIN number from HIGH to LOW, you will only need to change the PIN number.
pinMode(VExt_CTRL & 127, OUTPUT); // It is worth using bitwise. This is for GPS and TFT screen on Wireless_Tracker and only for Oled in Heltec V3
digitalWrite(VExt_CTRL & 127, VExt_CTRL & 128 ? 0 : 1); //HIGH for normal PIN, LOW for PIN+128. ex: 36 = HIGH for heltecWT Ver05, (36+128)=164 = LOW for heltec WT Ver03
#endif
#ifdef ADC_CTRL
pinMode(ADC_CTRL & 127, OUTPUT); // It is worth using bitwise.
#endif
Also, I would put the HAS_AXPxxx directives before the voids (also in the .h file). Because if there is no AXP then empty voids are compiled in the code.

great, added


Create "Launch Stack" CloudFormation feature

This would be so much more handy than Terraform.
https://blogs.aws.amazon.com/application-management/post/Tx2YSVJV4VMPBHI/Construct-Your-Own-Launch-Stack-URL
LambCI does it for example: https://github.com/lambci/lambci

Likely going to switch to using https://github.com/tmaiaroto/aegis for this...But what would be really nice is if I could make it so that aegis could be imported to discfg giving it some command line options to self deploy. Then people won't need to download aegis, run aegis from discfg directory, etc. Instead, a single discfg binary would be all that's needed.
While clicking a button on a web page to deploy a key/value store for configuration needs is indeed convenient...So is a CLI tool and part of discfg's usefulness is to have access to configurations no matter where you are. Given most users will have discfg CLI, it fits well to deploy an optional API from your machine as well.
Further, aegis makes it very convenient as opposed to having a different Lambda function for each operation and then a very long Terraform config.

Moving to Aegis or SAM for this.


This opportunity is open to all, but I'm going to assign it to Paul

Need you to push our project forward - fast!Acceptance CriteriaYou must make us make progressProposal Evaluation Criteria1. Your name begins with "P"
2. Your name ends with "aul"

This opportunity has been assigned

closing -- this was a test

This opportunity has been un-assigned


Failed when launch start_arena.launch

After reconfiguring the project environment, I launched the test files
roslaunch arena_bringup start_arena.launch

Received an error message
File "/home/luo/arena_ws/src/arena/arena rosnav/task_generator/task_generator/manager/entity_manager/crowdsim_manager. py", line 383, in spawn_dynamic_obstacles
Msg. configuration=json. dumps ({})
AttributeError: 'Ped' object has no attribute 'configuration'

I checked the pedsim_msgs/Ped imformation and I really didn't find configuration in the msg
geometry_msgs/Point pos
  float64 x
  float64 y
  float64 z
string type
string yaml_file
int16 number_of_peds
float64 vmax
string start_up_mode
float64 wait_time
float64 trigger_zone_radius
float64 max_talking_distance
float64 max_servicing_radius
float64 chatting_probability
float64 tell_story_probability
float64 group_talking_probability
float64 talking_and_walking_probability
float64 requesting_service_probability
float64 requesting_guide_probability
float64 requesting_follower_probability
float64 talking_base_time
float64 tell_story_base_time
float64 group_talking_base_time
float64 talking_and_walking_base_time
float64 receiving_service_base_time
float64 requesting_service_base_time
float64 force_factor_desired
float64 force_factor_obstacle
float64 force_factor_social
float64 force_factor_robot
geometry_msgs/Point[] waypoints
  float64 x
  float64 y
  float64 z
int16 waypoint_mode

Is this because I installed an old version of arena-rosnav before or something else?

Hey,
should be fixed in https://github.com/Arena-Rosnav/arena-rosnav/pull/192.
Please verify.
Best


WSL folder operation errors on 21354 insider build in Surface Pro X/Windows ARM

Windows Build Number
Microsoft Windows [Version 10.0.21354.1]
WSL Version
WSL 2
Distro Version
No response
Other Software
Windows ARM64
WSL 2
Ubuntu
Windows Explorer
Repro Steps
Create or delete folders using file explorer in a WSL path.
Expected Behavior
Normal folder creation or deletion behavior.
Actual Behavior
Folder creation - returns error "File Too Large" stating "The file '<%1 NULL:NameDest>' is too large for the destination file system.". At first, no folder appears. Two new folders appear upon refresh, per folder created.
Folder deletion - windows returns error "1 Interrupted Action" stating "Error 0x80070057: The parameter is incorrect". No folder deletion occurs, even after refresh.
Folder name changes functions properly.
Folder creation/deletion/name changes via other programs (e.g. VSCode) work properly.
This issue has also affected other recent insider builds on SPX.
Diagnostic Logs
No response

Distro used was Ubuntu

This issue is still present in 21382

This issue persists on 21390 for SPX/Windows ARM.

This issue persists on 22000.100 for SPX/Windows ARM.

I'm still experiencing this issue on 22000.168 for SPX/Windows ARM.


wrap-around the file-list when reaching the top or the bottom

Handy for very large directory listings. Keybinds to go to the top or bottom of the listing can be an equivalent functionality I guess.

https://github.com/CogentRedTester/mpv-file-browser/blob/b6f03cba1e565b95493dadd42d737d7e7a5486c5/file-browser.lua#L690-L712
In fact, the function of wrap scrolling has been implemented in the code, but it has not been enabled.
I think we can put the state.wrap is changed to o.wrap so that the user can decide whether to cycle wrap scrolling.

Hmm yea, I forgot about that. The wrap code must be a holdover from the mpv-scroll-list implementation. What @dyphire suggests will indeed work. I'll try to do it in the next couple of days if I have time.

Should be supported now.

Working fine, thanks!


[Feature] Statefulsyncer

🚀 Feature of #106
Rust based Rosetta Statefulsyncer for SDK Spec
Description:

StatefulSyncer is an abstraction layer over the stateless syncer package. This layer handles sync restarts and provides fully populated blocks during reorgs (not provided by stateless syncer)

This is nice to have but low Priority ATM


Update dependency "sort-css-media-queries"

Would you consider to update your dependency "sort-css-media-queries"? New Version includes a fix on sorting media queries in mobile first option.

@alfredriesen done https://www.npmjs.com/package/postcss-sort-media-queries


Make sure compiled code calls ol.VectorTile#setProjection

This pull request fixes an issue which can be observed when looking at http://openlayers.org/en/master/examples/mapbox-vector-tiles.html: the tiles are reprojected, because the compiler strips out the code that sets the tile projection with the correct tile-pixels units in ol.featureloader.xhr (for whatever reason).

Thanks for any review.

LGTM


[ROCm][XLA:GPU] Merging xla postlayout assignment optimization pass

A continuation from the discussion here. Merging OptimizeHloPostLayoutAssignment pass such that:

AMDGPUCompiler can rely on its parent GpuCompiler's OptimizeHloPostLayoutAssignment pass
NVPTXCompiler uses GpuCompiler's routine as well as Cuda specific passes
GpuCompiler has the common functionality between Cuda and ROCm.

The benefit of this refactoring to to maximize code sharing between Cuda and ROCm. It will help eliminate subtle bugs caused by one pass adding to one platform but not another.
Note: Alternatively I can move every pass to GpuCompiler and do runtime check to determine what platform it is. However, that will make the current inheritance hierarchy lose its original purpose in determining the platform dynamically through vtable.
/cc: @whchung @deven-amd

Working on addressing Cuda test failure now. Will push an update when done.


Update Meta “tags”

Automatically generated by Netlify CMS

👷 Deploy Preview for festive-saha-f7160e processing.
🔨 Explore the source changes: 3b8658b72211fe464d71aa5e105b2ef840af7233
🔍 Inspect the deploy log: https://app.netlify.com/sites/festive-saha-f7160e/deploys/618cf51e16b7fc0007021f42


remove typo at iot-hub-device-streams-overview.md

@nnmer : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Verified the update.
@nnmer Thanks for the fix.


Updating to Helia-coord v1.2.24

:tada: This PR is included in version 5.2.1 :tada:
Your semantic-release bot :package::rocket:


Add support for PureScript

Could someone add support for PureScript?

I can definitely look into this. I'm assuming you'd want to precompile to JS and then run in node?

Yeah, something like that would work perfectly!


Dash daq iv tracer

Issue for app: #[issue number here]
App pull request

[ ] This is a new app
[x] I am improving an existing app (redesigns/code "makeovers")

About

Playground deployment URL (new version): https://dash-playground.plotly.host/dash-daq-iv-tracer
Current gallery app URL: https://dash-gallery.plotly.host/dash-daq-iv-tracer/

Workflow

[x] I have created a branch in the appropriate monorepo, and the
elements necessary for successful deployment are in place.
[x] If the app is a redesigned and/or restyled version of an
existing gallery app, I've summarized the changes requested in the
appropriate Streambed issue and confirm that they have been applied.

[x] If the app is on the Dash Gallery portal, I have added a link to
the GitHub repository for the source code in the portal description.
[x] I have removed all Google Analytics code from the app's
assets/ folder.

The pre-review review
I have addressed all of the following questions:

[x] Does everything in my code serve some purpose? (I have removed
any dead and/or irrelevant code.)
[x] Does everything in my code have a clear purpose? (My code is
readable and, where it isn't, it has been commented appropriately.)]
[x] Am I reinventing the wheel? (I have used appropriate packages to
lessen the volume of code that needs to be maintained.)

Note

Looks nice 💃 The only thing I would improve is the UsefulVariable class.
Also, is the app.py file needed?

Yes, I think @shammamah said to keep the file!


How to inspect devices of a sandbox?

From the source code libnetwork/drivers/overlay/ov_network.go, I see that the func initSubnetSandbox creates a bridge and vxlan device for one subnet and move it to the sandbox. I wonder how to inspect the bridge and vxlan device of sandbox on my env.
Is there any command like ip link show to inspect? Thanks!
@mavenugo

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

@xiangpengzhao This network sandbox is supposed to be internal to the overlay driver implementation and it is not expected for the users to manipulate it directly. Infact the overlay driver would behave incorrectly if the user modifies the network-sandbox namespace directly. Is there a reason for you to access this namespace directly ?
If you are determined to do that regardless of the consequences :-) follow these steps -

Use docker network ls command to identify the network-id of the corresponding network that you are trying to access the sandbox.
As a root user, cd /var/run/docker/netns and identify the namespace to enter. the namespace is named as {x}-{first 10 digits of network-id}. ({x} is a random number assigned by libnetwork).
you can use nsenter (easy install : docker run -v /usr/local/bin:/target jpetazzo/nsenter). For more info refer to https://blog.docker.com/2014/06/why-you-dont-need-to-run-sshd-in-docker/.
nsenter --net=/var/run/docker/netns/{x}-{10 digits of network-id} ip link show

Thanks @mavenugo
I have been reading source codes of docker. I'm interested in the details of overlay network, so I want to inspect the devices created for a sandbox. I will not modify anything :-)

@xiangpengzhao thanks :) BTW, with #18775 overlay network is supported in kernels < 3.16 as well. And we dont use the network-sandbox for kernels < 3.16. Meaning all the bridges and the vxlan devices are created on the host namespace. (Hence my comment above doesnt apply for kernels < 3.16).
Closing this issue.

OK. Thanks @mavenugo


Updates to support Data Ingest Board datasets/uploads bulk editing

These are the corresponding backend changes required by https://github.com/x-atlas-consortia/data-ingest-board/pull/198

New endpoints (PUT /datasets and PUT /uploads) to handle the bulk updating of entities - https://github.com/sennetconsortium/ingest-api/pull/449/files#diff-dbbd81613f45e75c24d247a0a00eaf8bc018218b14771a16b30b182368852c6e

Modifying the results from the /data-status endpoint to add a last_updated property to Redis. The new return format from these endpoints will look like

{"data": <data>, "last_updated": <last_updated>}

SenNet reference: https://github.com/sennetconsortium/ingest-api/pull/450/files However, we won't introduce those decorators and job queue features to HuBMAP, for now.

Only the second part has been done here. The first part has been moved to a new card https://github.com/orgs/hubmapconsortium/projects/40/views/1?pane=issue&itemId=68906593


opt end Kafka consume when meets partition EOF

Proposed changes
When all the partitions held by a consumer reach EOF, the consumer can end and give up resources to avoid ineffective occupation of resources.

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


Unable to see the screen which is shared by the presenter in the presenter view

Question
Would it be possible to see the screen shared by the presenter in the presenter view?
Additional context
All the persons can able to see the shared screen which is shared by someone in the conference. but the person who shared the screen, they can't see their screen on their view.
Is this the feature in Twilio video app or it's a known bug that i identified.
Please refer the attached presenter & participant views for more clarity in this scenario.
Presenter view

Participant view

Hi @Benitosam ,
Here are some of the changes you can try out in order for the presenter to see the screen that they are sharing. Please let me now if this works for you. I will close this ticket as I have answered your question, but we can continue the conversation here.

Thank you Manjesh, I will check it out.
On Tue, Jan 31, 2023 at 2:04 AM Manjesh Malavalli @.***>
wrote:

Hi @Benitosam https://github.com/Benitosam ,
Here are some of the changes
https://github.com/twilio/twilio-video-app-react/compare/show-local-screen-share
you can try out in order for the presenter to see the screen that they are
sharing. Please let me now if this works for you. I will close this ticket
as I have answered your question, but we can continue the conversation here.
—
Reply to this email directly, view it on GitHub
https://github.com/twilio/twilio-video-app-react/issues/784#issuecomment-1409296140,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW6HY75B2Z7KBT74EYBQQMDWVAQT7ANCNFSM6AAAAAAUEVC4TQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Avoid leaving an unclosed dangling FileInputStream

Closes #11
I couldn't figure out a meaningful way of testing this.

Thanks a lot for the PR!
I added that in a separate commit (b6df332), though, because I renamed all packages and that was easier than merging this PR. Thanks anyways!


Add requirements to README

A list of required files and credentials etc. would be useful for first time users.

Required (so far):
config file
AWS credentials
release config file (in the release)
s3 buckets for releases and storing state
folders with necessary write permissions for log files
....

We should defo add to README, but should also list out when writing tutorial (see #55)


Active state for current slide

I couldn't find a way to set styles for the current slide, is this possible?

Do you want to apply a style that only affects the currently visible slide? If so, that is currently no possible with pure CSS as the information for the selectors isn't there.
However, it would be possible to extend the code easily enough to add a previousSlide, currentSlide and nextSlide class to the relevant slides, and you could target your styling towards those.


Add window blur

Attempts to address #1113
mostly stolen from https://github.com/FelixKratz/SketchyBar/commit/d83c698fb82986fb31afaad149c3d1dbc0b2654d
@felixkratz

See my comment in the related issue.


Email address<EMAIL_ADDRESS>unable to accept external emails

Your message to<EMAIL_ADDRESS>couldn't be delivered.
The group pwdless only accepts messages from people in its organization or on its allowed senders list, and your email address isn't on the list.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6ca080bd-ed37-60a8-ec22-b1929166ff0c
Version Independent ID: d2742e0c-9d66-4b1f-8555-a1fb1546455b
Content: Passwordless Strategy - Microsoft 365 Security
Content Source: windows/security/identity-protection/hello-for-business/passwordless-strategy.md
Product: w10
Technology: windows
GitHub Login: @mapalko
Microsoft Alias: mapalko

Hm. That means we need to look for a different email address for that page, unless this is a temporary issue.
Alternatively, it could mean that we need to remove the sentence suggesting to use that email address.

Are there alternative places I could ask a question regarding this step/statement:
(2.d.) Remove password capabilities from Windows.
All of the methods that disable passwords also disable the ability to RunAs anything which is integral to administering systems and running standard accounts in least priviliged mode.
It seems odd I can't find anything which addresses this given I don't think it's viable to maintain a fleet of systems without RunAs.
Any recommendations on where to initiate that conversation would be excellent (and perhaps worth placing in this article)

Thank you for asking. This issue tracker is mostly intended to improve the documentation pages, either by reporting errors, suggesting improvements, updates or adjustments for the existing docs.
Regarding how to use the software technology, in case it is not described adequately or detailed enough, try the forum pages:

https://social.technet.microsoft.com/Forums/en-US/home
https://social.microsoft.com/forums
https://answers.microsoft.com/

The forum pages are usually quicker to respond and more appropriate for discussions as well as your type of question.
We will more than welcome feedback regarding changes to the existing documentation, so if your research ends up handing you updated information, please comment again and tell us what you found. 😉


Web payments docs

What's changed, or what was fixed?

Added headers, fixed line lengths, misc.

Fixes: #issue
Target Live Date: YYYY-MM-DD

[ ] This has been reviewed and approved by (NAME)
[ ] I have run npm test locally and all tests pass.
[ ] I have added the appropriate type-something label.
[ ] I've staged the site and manually verified that my content displays correctly.

CC: @petele

Whoops!
There were 9 critical errors that broke the build and prevented it from being automatically deployed.
There were 3 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
ERRORS
src/content/en/webpaymentsdocs/3WebPaymentsHowItWorks.md#L28 - Do not hard code developers.google.com in links.
src/content/en/webpaymentsdocs/3WebPaymentsHowItWorks.md#L30 - Do not hard code developers.google.com in links.
src/content/en/webpaymentsdocs/4WebPaymentsMethods.md#L122 - Do not hard code developers.google.com in links.
src/content/en/webpaymentsdocs/readme.md - No 'wf_blink_components' found, see https://goo.gl/VXmg9e
src/content/en/webpaymentsdocs/readme.md - Attribute 'book_path' missing from top of document
src/content/en/webpaymentsdocs/readme.md - Attribute 'project_path' missing from top of document
src/content/en/webpaymentsdocs/readme.md - WF Tag 'wf_updated_on' is missing (YYYY-MM-DD)
src/content/en/webpaymentsdocs/readme.md - WF Tag 'wf_published_on' is missing (YYYY-MM-DD)
src/content/en/webpaymentsdocs/readme.md - Page is missing page title eg: '# TITLE {: .page-title }'
WARNINGS
src/content/en/webpaymentsdocs/1WebPaymentsOverview.md#L26 - Common typo found: 'implicity' Should it be 'implicitly'?
src/content/en/webpaymentsdocs/3WebPaymentsHowItWorks.md#L26 - Common typo found: 'm68' Should it be '$1'? Do not use 'M' or 'milestone'
src/content/en/webpaymentsdocs/images/1-image1.png - Try to keep files below 500K, was 529K

Whoops!
There were 7 critical errors that broke the build and prevented it from being automatically deployed.
There were 3 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
ERRORS
src/content/en/webpaymentsdocs/4WebPaymentsMethods.md#L122 - Do not hard code developers.google.com in links.
src/content/en/webpaymentsdocs/readme.md - No 'wf_blink_components' found, see https://goo.gl/VXmg9e
src/content/en/webpaymentsdocs/readme.md - Attribute 'book_path' missing from top of document
src/content/en/webpaymentsdocs/readme.md - Attribute 'project_path' missing from top of document
src/content/en/webpaymentsdocs/readme.md - WF Tag 'wf_updated_on' is missing (YYYY-MM-DD)
src/content/en/webpaymentsdocs/readme.md - WF Tag 'wf_published_on' is missing (YYYY-MM-DD)
src/content/en/webpaymentsdocs/readme.md - Page is missing page title eg: '# TITLE {: .page-title }'
WARNINGS
src/content/en/webpaymentsdocs/1WebPaymentsOverview.md#L26 - Common typo found: 'implicity' Should it be 'implicitly'?
src/content/en/webpaymentsdocs/3WebPaymentsHowItWorks.md#L26 - Common typo found: 'm68' Should it be '$1'? Do not use 'M' or 'milestone'
src/content/en/webpaymentsdocs/images/1-image1.png - Try to keep files below 500K, was 529K

Whoops!
There were 6 critical errors that broke the build and prevented it from being automatically deployed.
There were 3 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
ERRORS
src/content/en/webpaymentsdocs/readme.md - No 'wf_blink_components' found, see https://goo.gl/VXmg9e
src/content/en/webpaymentsdocs/readme.md - Attribute 'book_path' missing from top of document
src/content/en/webpaymentsdocs/readme.md - Attribute 'project_path' missing from top of document
src/content/en/webpaymentsdocs/readme.md - WF Tag 'wf_updated_on' is missing (YYYY-MM-DD)
src/content/en/webpaymentsdocs/readme.md - WF Tag 'wf_published_on' is missing (YYYY-MM-DD)
src/content/en/webpaymentsdocs/readme.md - Page is missing page title eg: '# TITLE {: .page-title }'
WARNINGS
src/content/en/webpaymentsdocs/1WebPaymentsOverview.md#L26 - Common typo found: 'implicity' Should it be 'implicitly'?
src/content/en/webpaymentsdocs/3WebPaymentsHowItWorks.md#L26 - Common typo found: 'm68' Should it be '$1'? Do not use 'M' or 'milestone'
src/content/en/webpaymentsdocs/images/1-image1.png - Try to keep files below 500K, was 529K

Whoops!
There were 3 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/webpaymentsdocs/1WebPaymentsOverview.md#L26 - Common typo found: 'implicity' Should it be 'implicitly'?
src/content/en/webpaymentsdocs/3WebPaymentsHowItWorks.md#L26 - Common typo found: 'm68' Should it be '$1'? Do not use 'M' or 'milestone'
src/content/en/webpaymentsdocs/images/1-image1.png - Try to keep files below 500K, was 529K