[24.1] imageio AWT tests fail with JDK 23 ea

The imageio AWT integration tests seem to fail a JDK 23-based Mandrel 24.1 build with:
[...]
[INFO] --- shade:2.4.3:shade (default) @ imageio ---
[WARNING] Parameter 'localRepository' is deprecated core expression; Avoid use of ArtifactRepository type. If you need access to local repository, switch to '${repositorySystemSession}' expression and get LRM from it instead.
[INFO] Including org.jfree:org.jfree.svg:jar:4.1 in the shaded jar.
[INFO] Including org.jfree:jfreechart:jar:1.5.2 in the shaded jar.
[INFO] Replacing original artifact with shaded artifact.
[INFO] Replacing /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/imageio.jar with /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/imageio-1-shaded.jar
[INFO] Dependency-reduced POM written at: /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/dependency-reduced-pom.xml
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  1.804 s
[INFO] Finished at: 2024-06-26T15:07:24+02:00
[INFO] ------------------------------------------------------------------------
2024-06-26 15:07:24.284 INFO  [o.g.t.i.u.Commands$ProcessRunner] (run) Command: [java, -Djava.awt.headless=true, -agentlib:native-image-agent=config-output-dir=src/main/resources/META-INF/native-image, -jar, target/imageio.jar]
2024-06-26 15:07:26.031 INFO  [o.g.t.i.u.Commands$ProcessRunner] (run) Command: [jar, uf, target/imageio.jar, -C, src/main/resources/, META-INF]
2024-06-26 15:07:26.361 INFO  [o.g.t.i.u.Commands$ProcessRunner] (run) Command: [native-image, -J-Djava.awt.headless=true, --no-fallback, -jar, target/imageio.jar, target/imageio]
Warning: Option 'DynamicProxyConfigurationResources' is deprecated and might be removed in a future release. Please refer to the GraalVM release notes.
========================================================================================================================
GraalVM Native Image: Generating 'imageio' (executable)...
========================================================================================================================
For detailed information and explanations on the build output, visit:
https://github.com/oracle/graal/blob/master/docs/reference-manual/native-image/BuildOutput.md
------------------------------------------------------------------------------------------------------------------------
[1/8] Initializing...                                                                                (3.0s @ 0.16GB)
 Java version: 23-beta+28-202406240955, vendor version: Mandrel-24.1.0-dev22e2e94bb8f2
 Graal compiler: optimization level: 2, target machine: x86-64-v3
 C compiler: gcc (redhat, x86_64, 13.3.1)
 Garbage collector: Serial GC (max heap size: 80% of RAM)
 1 user-specific feature(s):
 - com.oracle.svm.thirdparty.gson.GsonFeature
------------------------------------------------------------------------------------------------------------------------
Build resources:
 - 26.49GB of memory (42.4% of 62.55GB system memory, determined at start)
 - 12 thread(s) (100.0% of 12 available processor(s), determined at start)
[2/8] Performing analysis...  [****]                                                                    (12.6s @ 0.57GB)
    5,798 reachable types   (75.9% of    7,644 total)
    9,530 reachable fields  (49.7% of   19,176 total)
   29,244 reachable methods (50.9% of   57,414 total)
    1,783 types,    79 fields, and   776 methods registered for reflection
       58 types,    58 fields, and    52 methods registered for JNI access
        4 native libraries: dl, pthread, rt, z
[3/8] Building universe...                                                                               (2.0s @ 0.65GB)
[4/8] Parsing methods...      [*]                                                                        (1.6s @ 0.44GB)
[5/8] Inlining methods...     [***]                                                                      (1.3s @ 0.52GB)
[6/8] Compiling methods...    [****]                                                                    (13.7s @ 0.77GB)
[7/8] Laying out methods...   [**]                                                                       (2.9s @ 0.96GB)
[8/8] Creating image...       [**]                                                                       (2.5s @ 1.12GB)
  13.02MB (46.83%) for code area:    17,964 compilation units
  14.20MB (51.09%) for image heap:  164,395 objects and 58 resources
 593.18kB ( 2.08%) for other data
  27.80MB in total
------------------------------------------------------------------------------------------------------------------------
Top 10 origins of code area:                                Top 10 object types in image heap:
   6.12MB java.base                                            3.41MB byte[] for code metadata
   5.27MB java.desktop                                         2.16MB byte[] for java.lang.String
   1.07MB svm.jar (Native Image)                               1.62MB java.lang.String
 116.92kB java.logging                                         1.36MB java.lang.Class
  67.01kB org.graalvm.nativeimage.base                         1.19MB byte[] for embedded resources
  49.32kB java.datatransfer                                  498.27kB com.oracle.svm.core.hub.DynamicHubCompanion
  48.63kB jdk.proxy2                                         359.67kB java.util.HashMap$Node
  43.31kB imageio.jar                                        325.87kB java.lang.String[]
  42.34kB jdk.proxy1                                         300.65kB byte[] for general heap data
  26.56kB jdk.internal.vm.ci                                 297.81kB byte[] for reflection metadata
  41.84kB for 6 more packages                                  2.72MB for 1215 more object types
------------------------------------------------------------------------------------------------------------------------
Recommendations:
 AWT:  Use the tracing agent to collect metadata for AWT.
 HEAP: Set max heap for improved and more predictable memory usage.
 CPU:  Enable more CPU features with '-march=native' for improved performance.
------------------------------------------------------------------------------------------------------------------------
                        1.8s (4.3% of total time) in 356 GCs | Peak RSS: 1.62GB | CPU load: 9.35
------------------------------------------------------------------------------------------------------------------------
Build artifacts:
 /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/imageio (executable)
 /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/libawt.so (jdk_library)
 /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/libawt_headless.so (jdk_library)
 /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/libawt_xawt.so (jdk_library)
 /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/libfontmanager.so (jdk_library)
 /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/libfreetype.so (jdk_library)
 /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/libjava.so (jdk_library_shim)
 /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/libjavajpeg.so (jdk_library)
 /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/libjvm.so (jdk_library_shim)
 /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/liblcms.so (jdk_library)
========================================================================================================================
Finished generating 'imageio' in 40.6s.
2024-06-26 15:08:08.376 INFO  [o.g.t.i.AppReproducersTest] (imageioAWT) Running...
2024-06-26 15:08:09.381 INFO  [o.g.t.i.u.Commands] (runCommand) Command: [./target/imageio, -Djava.home=., -Djava.awt.headless=true]
2024-06-26 15:08:09.424 INFO  [o.g.t.i.u.Commands] (pidKiller) Killing PID: 109047, forcefully: true
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 48.851 s <<< FAILURE! - in org.graalvm.tests.integration.AppReproducersTest
[ERROR] imageioAWTTest{TestInfo}  Time elapsed: 47.981 s  <<< FAILURE!
org.opentest4j.AssertionFailedError:
There were errors checking the generated image files, see:
mytest.jpg was not generated.
mytest_toL.png was not generated.
mytest.bmp was not generated.
mytest_toG.png was not generated.
mytest.gif was not generated.
mytest.svg was not generated.
mytest.png was not generated.
mytest.tiff was not generated.
mytest_Resized_Grace_M._Hopper.png was not generated.
mytest_toC.png was not generated.
mytest_toP.png was not generated.
mytest.wbmp was not generated.
mytest_toS.png was not generated. ==> expected: <true> but was: <false>
	at org.graalvm.tests.integration.AppReproducersTest.imageioAWT(AppReproducersTest.java:607)
	at org.graalvm.tests.integration.AppReproducersTest.imageioAWTTest(AppReproducersTest.java:501)

[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   AppReproducersTest.imageioAWTTest:501->imageioAWT:607 There were errors checking the generated image files, see:
mytest.jpg was not generated.
mytest_toL.png was not generated.
mytest.bmp was not generated.
mytest_toG.png was not generated.
mytest.gif was not generated.
mytest.svg was not generated.
mytest.png was not generated.
mytest.tiff was not generated.
mytest_Resized_Grace_M._Hopper.png was not generated.
mytest_toC.png was not generated.
mytest_toP.png was not generated.
mytest.wbmp was not generated.
mytest_toS.png was not generated. ==> expected: <true> but was: <false>
[INFO]
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Native image integration TS 1.0.0-SNAPSHOT:
[INFO]
[INFO] Native image integration TS ........................ SUCCESS [  0.104 s]
[INFO] testsuite .......................................... FAILURE [ 51.810 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  51.982 s
[INFO] Finished at: 2024-06-26T15:08:09+02:00
[INFO] ------------------------------------------------------------------------

Steps to reproduce
export JAVA_HOME=/path/to/mandrel-24.1
export GRAALVM_HOME=$JAVA_HOME
export PATH=$JAVA_HOME/bin:$PATH
mvn clean verify -Dquarkus.version=999-SNAPSHOT -Ptestsuite -Dtest=AppReproducersTest#imageioAWTTest

/cc @Karm

The test also fails on JDK 24 based Mandrel, fwiw:
========================================================================================================================
GraalVM Native Image: Generating 'imageio' (executable)...
========================================================================================================================
For detailed information and explanations on the build output, visit:
https://github.com/oracle/graal/blob/master/docs/reference-manual/native-image/BuildOutput.md
------------------------------------------------------------------------------------------------------------------------
[1/8] Initializing...                                                                                (2.9s @ 0.17GB)
 Java version: 24-beta+4-ea, vendor version: Mandrel-24.2.0-devbb7f14ee3621
 Graal compiler: optimization level: 2, target machine: x86-64-v3
 C compiler: gcc (redhat, x86_64, 13.3.1)
 Garbage collector: Serial GC (max heap size: 80% of RAM)
 1 user-specific feature(s):
 - com.oracle.svm.thirdparty.gson.GsonFeature
------------------------------------------------------------------------------------------------------------------------
Build resources:
 - 26.49GB of memory (42.4% of 62.55GB system memory, determined at start)
 - 12 thread(s) (100.0% of 12 available processor(s), determined at start)
[2/8] Performing analysis...  [****]                                                                    (12.4s @ 0.60GB)
    5,806 reachable types   (75.5% of    7,686 total)
    9,529 reachable fields  (49.6% of   19,225 total)
   29,317 reachable methods (50.4% of   58,121 total)
    1,788 types,    79 fields, and   776 methods registered for reflection
       58 types,    58 fields, and    52 methods registered for JNI access
        4 native libraries: dl, pthread, rt, z
[3/8] Building universe...                                                                               (2.4s @ 0.68GB)
[4/8] Parsing methods...      [*]                                                                        (1.7s @ 0.39GB)
[5/8] Inlining methods...     [***]                                                                      (1.1s @ 0.48GB)
[6/8] Compiling methods...    [****]                                                                    (14.5s @ 0.77GB)
[7/8] Laying out methods...   [**]                                                                       (2.7s @ 0.95GB)
[8/8] Creating image...       [**]                                                                       (2.4s @ 1.10GB)
  13.40MB (47.50%) for code area:    18,001 compilation units
  14.23MB (50.45%) for image heap:  164,724 objects and 58 resources
 592.98kB ( 2.05%) for other data
  28.20MB in total
------------------------------------------------------------------------------------------------------------------------
Top 10 origins of code area:                                Top 10 object types in image heap:
   6.25MB java.base                                            3.44MB byte[] for code metadata
   5.34MB java.desktop                                         2.16MB byte[] for java.lang.String
   1.24MB svm.jar (Native Image)                               1.63MB java.lang.String
 119.36kB java.logging                                         1.36MB java.lang.Class
  69.38kB org.graalvm.nativeimage.base                         1.19MB byte[] for embedded resources
  50.46kB java.datatransfer                                  498.95kB com.oracle.svm.core.hub.DynamicHubCompanion
  49.71kB jdk.proxy2                                         360.19kB java.util.HashMap$Node
  43.99kB imageio.jar                                        326.57kB java.lang.String[]
  43.30kB jdk.proxy1                                         300.67kB byte[] for general heap data
  27.31kB jdk.internal.vm.ci                                 298.55kB byte[] for reflection metadata
  42.62kB for 6 more packages                                  2.70MB for 1218 more object types
------------------------------------------------------------------------------------------------------------------------
Recommendations:
 AWT:  Use the tracing agent to collect metadata for AWT.
 HEAP: Set max heap for improved and more predictable memory usage.
 CPU:  Enable more CPU features with '-march=native' for improved performance.
------------------------------------------------------------------------------------------------------------------------
                        1.9s (4.5% of total time) in 378 GCs | Peak RSS: 1.57GB | CPU load: 9.23
------------------------------------------------------------------------------------------------------------------------
Build artifacts:
 /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/imageio (executable)
 /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/libawt.so (jdk_library)
 /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/libawt_headless.so (jdk_library)
 /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/libawt_xawt.so (jdk_library)
 /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/libfontmanager.so (jdk_library)
 /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/libfreetype.so (jdk_library)
 /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/libjava.so (jdk_library_shim)
 /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/libjavajpeg.so (jdk_library)
 /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/libjvm.so (jdk_library_shim)
 /disk/graal/upstream-sources/mandrel-integration-tests/apps/imageio/target/liblcms.so (jdk_library)
========================================================================================================================
Finished generating 'imageio' in 41.2s.
2024-07-05 09:16:45.260 INFO  [o.g.t.i.AppReproducersTest] (imageioAWT) Running...
2024-07-05 09:16:46.265 INFO  [o.g.t.i.u.Commands] (runCommand) Command: [./target/imageio, -Djava.home=., -Djava.awt.headless=true]
2024-07-05 09:16:46.311 INFO  [o.g.t.i.u.Commands] (pidKiller) Killing PID: 33770, forcefully: true
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 49.723 s <<< FAILURE! - in org.graalvm.tests.integration.AppReproducersTest
[ERROR] imageioAWTTest{TestInfo}  Time elapsed: 48.849 s  <<< FAILURE!
org.opentest4j.AssertionFailedError:
There were errors checking the generated image files, see:
mytest.jpg was not generated.
mytest_toL.png was not generated.
mytest.bmp was not generated.
mytest_toG.png was not generated.
mytest.gif was not generated.
mytest.svg was not generated.
mytest.png was not generated.
mytest.tiff was not generated.
mytest_Resized_Grace_M._Hopper.png was not generated.
mytest_toC.png was not generated.
mytest_toP.png was not generated.
mytest.wbmp was not generated.
mytest_toS.png was not generated. ==> expected: <true> but was: <false>
	at org.graalvm.tests.integration.AppReproducersTest.imageioAWT(AppReproducersTest.java:607)
	at org.graalvm.tests.integration.AppReproducersTest.imageioAWTTest(AppReproducersTest.java:501)

[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   AppReproducersTest.imageioAWTTest:501->imageioAWT:607 There were errors checking the generated image files, see:
mytest.jpg was not generated.
mytest_toL.png was not generated.
mytest.bmp was not generated.
mytest_toG.png was not generated.
mytest.gif was not generated.
mytest.svg was not generated.
mytest.png was not generated.
mytest.tiff was not generated.
mytest_Resized_Grace_M._Hopper.png was not generated.
mytest_toC.png was not generated.
mytest_toP.png was not generated.
mytest.wbmp was not generated.
mytest_toS.png was not generated. ==> expected: <true> but was: <false>
[INFO]
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------

Taking a look now...

I am sorry, I have a mixup in JDK versions I think.
Mandrel 24.1 + JDK 23 build works for me on amd64:
 Java version: 23-beta+30-ea, vendor version: Mandrel-<IP_ADDRESS>-devc49fbc560ec

....but the same job fails on aarch64:
WARNING: No platform-specific definition is available for distribution MUSL_CMAKE_TOOLCHAIN for your architecture (aarch64)-Final

No need to stress I haven't changed anything in the way Adoptium API is queried, I'm not downloading musl versions....

@Karm See https://github.com/graalvm/mandrel-packaging/issues/429. For graal/master you need JDK 24. For mandrel/24.1 you'd need JDK 23.
I haven't seen the error that you see on aarch64, though (don't have such hardware handy).

For 24.1: 23-beta+28 is known to work.
For 24.2: 24-beta+4 is known to work.
You might have to downgrade build JDK version.

@jerboaa Both master + JDK 24 ea and 24.1 + JDK 23 ea builds work fine for me on Windows, Linux amd64 and Mac aarch64 now. The only weird quirk is Linux aarch64 with 24.1+JDK 23 ea, captured here: https://github.com/graalvm/mandrel/issues/766

Thanks!

@jerboaa We have again the problem with loading awt so libs

As in the "visibility hidden" problem to be fixed in OpenJDK?

It's not that it seems :-/  Wip..

@jerboaa  @zakkak
Soo, I think there is a problem with the way the agent works.
When I manually babysit it and prepare correct jni-config.json by hand AND prepare fake JAVA_HOME as we had to do in Quarkus AND if I force the headless property on the executable at runtime, it works:
./target/imageio -Djava.awt.headless=true -Djava.home=/tmp/FAKE_JAVA_HOME

So it seems like -J-Djava.awt.headless=true for native-image command is not working nay more and that the agent also doesn' t generate acceptable config any more.
I will try to collect notes and prepare some more coherent report.

Thanks!

Upstream issue: https://github.com/oracle/graal/issues/9300

@Karm Any update on this? The upstream graalvm issue I see is solved. Yet, we still see builds failing for example here: https://github.com/Karm/mandrel-integration-tests/issues/266#issuecomment-2285197899

Lemme check if it got integrated properly.

@jerboaa It is broken again, i.e. Mandrel upstream build number 1430 worked, 1466 is broken. I'll take a look later today as to exactly why and whether it is a new issue or a regression of what was previously fixed.

@jerboaa So, the timeline is that https://github.com/oracle/graal/commit/71e6492 worked (as I note in the comment). Git bisect tells me that this is the first commit that broke it:
https://github.com/oracle/graal/commit/fa89c6bf1ba6
I know, doesn't seem like it.
And yet, I had to switch JDKs during the bisect between Temurin-24+3-202406211439 and my homemade JDK24 56dec215b0d to make Mandrel build due to virtual threads, which is exactly what was https://github.com/oracle/graal/commit/fa89c6bf1ba6 about.
All in all it's likely a change in JDK and not Graal that breaks it this time.
I've narrowed that to loadFonts and I'm gonna check what changed there in JDK.

@jerboaa It is broken again, i.e. Mandrel upstream build number 1430 worked, 1466 is broken.

@Karm Do you have links to those builds?

I'll take a look later today as to exactly why and whether it is a new issue or a regression of what was previously fixed.

@Karm Do we need to backport https://github.com/oracle/graal/commit/71e6492 to the 24.1 branch in order to fix imageio for that release? Something else?
Let's close this issue only when JDK 23 mandrel and JDK 24 mandrel are both fixed. Thanks!


Master branch currently does not build on Windows

I check out this git repo. I run cargo.exe run --example hello_world. It chugs for a bit then prints
    Updating crates.io index
error: failed to select a version for `wgpu`.
    ... required by package `eframe v0.25.0 (C:\Users\Andi\work\r\other\egui\crates\eframe)`
    ... which satisfies path dependency `eframe` (locked to 0.25.0) of package `egui_demo_app v0.25.0 (C:\Users\Andi\work\r\other\egui\crates\egui_demo_app)`
versions that meet the requirements `*` are: 0.16.2

the package `eframe` depends on `wgpu`, with features: `fragile-send-sync-non-atomic-wasm` but `wgpu` does not have these features.

I then check out tag 0.25.0. cargo.exe run --example hello_world says that example is not found, but if I cd examples/hello_world && cargo.exe run, it builds and runs successfully.
I am running Rust 1.72.0 for Windows, but I think you override my Rust version with Cargo settings. Complicating factors: I did not check out with git, I checked out with hg-git, but this should not matter. I am running the Windows version (Windows 10) but I am invoking the Windows exe from within WSL (WSL1). This also should not matter.
I have not yet tried building on other platforms and I since I have now switched to the 0.25.0 branch (IOW: I am not blocked) I have not yet tried a plain cargo.exe build on master.

You may need to do a cargo clean or something. main is currently on wgpu 0.18: https://github.com/emilk/egui/blob/301c72ba22da8f29596d65757cf3dacdf5309985/Cargo.toml#L58

Also, it is cargo run -p hello_world, not --example

Thanks. I now believe this was a local tools issue.


x/tools/gopls: doesn't recognize => token in go.mod

What version of Go are you using (go version)?

$ go version
go version go1.15.11 darwin/amd64

Does this issue reproduce with the latest release?
Yes
$ gopls version
golang.org/x/tools/gopls master
<EMAIL_ADDRESS>h1:7S2k0xuVYc3secjy2uz0n+fGYxGJU6gXsLOmQ/r1HoI=

What operating system and processor architecture are you using (go env)?
go env Output ($HOME path redacted to ~.
Added a replace directive to main workspace go.mod file.
replace github.com/apache/thrift v0.13.0 => github.com/apache/thrift/lib/go/thrift v0.0.0-20210120171102-e27e82c46ba4

What did you expect to see?
gopls handling this properly.
What did you see instead?
gopls doesn't parse the go.mod file correctly. It doesn't recognize => as valid tokens despite Go Modules specification clearly outlining the usage and grammar for the replace directive. https://golang.org/ref/mod#go-mod-file-replace

[Error - 3:42:26 PM] 2021/05/18 15:42:26 code lens upgrade_dependency failed: ~/go/src/[redacted]/go.mod:139: unexpected token after version: "v0.13.0"

[Error - 3:42:26 PM] 2021/05/18 15:42:26 code lens vendor failed: ~/go/src/[redacted]/go.mod:139: unexpected token after version: "v0.13.0"

[Error - 3:42:26 PM] 2021/05/18 15:42:26 code lens tidy failed: ~/go/src/[redacted]/go.mod:139: unexpected token after version: "v0.13.0"

[Error - 3:42:26 PM] 2021/05/18 15:42:26 errors loading workspace: ~/go/src/[redacted]/go.mod:139: unexpected token after version: "v0.13.0"
	snapshot=21
	directory=file://~/go/src/[redacted]

[Error - 3:42:27 PM] 2021/05/18 15:42:27 diagnosing go.mod: ~/go/src/[redacted]/go.mod:139: unexpected token after version: "v0.13.0"

[Error - 3:42:27 PM] 2021/05/18 15:42:27 diagnosing go.mod: ~/go/src/[redacted]/go.mod:139: unexpected token after version: "v0.13.0"

[Error - 3:42:27 PM] 2021/05/18 15:42:27 errors loading workspace: ~/go/src/[redacted]/go.mod:139: unexpected token after version: "v0.13.0"
	snapshot=22
	directory=file://~/go/src/[redacted]

Gopls supports =>, and in fact has a replace in its own modfile.  Also, per my reading of the error the unexpected token is "v0.13.0".
That error is present in the go command, related to retraction, though not at 1.15.11.  It's also present in x/mod (again for the retract verb), but I don't think an error from x/mod would present as the critical error you see.
Is it possible you typed 'retract' instead of 'replace'? Is it possible you have multiple versions of Go installed on your computer?

I pasted it here exactly as it appears in go.mod, namely
replace github.com/apache/thrift v0.13.0 => github.com/apache/thrift/lib/go/thrift v0.0.0-20210120171102-e27e82c46ba4
So it's definitely replace. To be fair, I left a comment on that repo's commit and got the response that the particular commit is actually in an invalid state and he instructed me to use the next commit, which negated the need to even use replace. So my issue is technically solved, but this issue for gopls still results in the reported error state.
If it is supported as you claim, then I suppose it might somehow be related to the invalid go.mod state of the repo in question, but the errors thrown by gopls itself are still questionable. The replace resolved the errors issued by the regular go commands, but resulted in these errors here.

I suppose it might somehow be related to the invalid go.mod state of the repo in question

The error indicates the local go.mod, and the go.mod in github.com/apache/thrift/lib/go/thrift at that version is empty.
Gopls uses the same modfile parser as the go command: golang.org/x/mod. The error you see is either originating from executions of the go command, or from calls to x/mod from gopls. When I looked for it, it appears that its only occurrence is related to module retraction (linked above). Something strange is going on.
Just as a sanity check, I did create a minimal module that uses that exact replace directive. Everything works fine.
> cat go.mod
module mod.test

go 1.12

require github.com/apache/thrift v0.13.0

replace github.com/apache/thrift v0.13.0 => github.com/apache/thrift/lib/go/thrift v0.0.0-20210120171102-e27e82c46ba4
> cat main.go
package main

import "github.com/apache/thrift"

func main() {
        println(thrift.UNKNOWN_APPLICATION_EXCEPTION)
}

So I suspect there is something else in your go.mod file that is contributing to the error you see. Would you be able to provide a redacted version of your go.mod file, or try trimming down your modfile to a minimal repro? Could you also search the start of your logs for "go version", and make sure it agrees with the version you see on the command-line (go1.15.11)?  I'd like to understand what's going on -- at the very least this is a confusing error message.

at the very least this is a confusing error message.
This was my argument for not dismissing this off-hand. I'll provide the full go.mod when I get back to work tomorrow.

The ultimate cause is possibly due to this being a massive monorepo using please.build for a build system, which ultimately does all it's individual builds in GOPATH mode. Despite that, as far as I'm aware, gopls should be pulling in the go.mod and initializing based off that. Perhaps that assumption is my failing...
I tried to be sure there weren't any queries being sent to the gopls server yet though, so the error occurs during initialization. If my assumptions there are false, then our repo itself could be at fault.

Hi, I'm closing this as unactionable for now. Please re-open if you are able to gather more details. Thanks.


AirPlay 2

This is an extraordinary plug-in.
In HomeKit, Alexa speaker works as an Airplay2 speakers with no differences.
Could you work to expanse the use also in iOS? I'm referring to shows as AirPlay speakers also if we launch the music by Music app

Unfortunately, this is not possible today. AirPlay 2 hasn't been fully reverse-engineered yet, and there's no support for it in Homebridge. Once those two problems are solved, I'd be happy to reconsider this feature.

Airplay2 was cracked already
Please check on google: Shairpor-sync

Even if AirPlay 2 was fully supported in Homebridge and this plug-in, you would need a device physically plugged into an Echo's audio input that was running the plug-in in order for AirPlay 2's audio sync to work.


os: remove extra clcs

This looks like it was leftover from testing how markdown handled
indented code blocks.

Looking at the diff in my PR these were added by mistake. Not sure how that happened.
https://github.com/coreos/docs/pull/1024/files#diff-4360a051ecdd7c0104f9c29a4dace7a7L265


Fix #75 - define tap as [touchstart, touchend] and dbltap as two quick taps

Merged as a2846732594c1a9059ba4f1fc74cf84249c7290f. Thank you!


New version: Alacritty.Alacritty version 0.12.3

Pull request has been created with WinGet Automation :rocket:
Microsoft Reviewers: Open in CodeFlow

Manual Validation ended with:

Faulting application name: alacritty.exe, version: <IP_ADDRESS>, time stamp: 0x651b29cd
Faulting module name: ucrtbase.dll, version: 10.0.19041.789, time stamp: 0x2bd748bf Exception code: 0xc0000005 Fault offset: 0x0000000000025f31
Faulting process id: 0x11a8
Faulting application start time: 0x01d9f65c86341691
Faulting application path: C:\Program Files\Alacritty\alacritty.exe
Faulting module path: C:\Windows\System32\ucrtbase.dll Report Id: 6847b6c5-a80a-4b59-a117-cd83d9a05f53
Faulting package full name:
Faulting package-relative application ID:

@vedantmgoyal2009 is there a chance that you could re-enter this PR? Would be great for the alacritty community to have the latest version on winget. Thank you very much in advance!!


feat(wallet): ability to customise invoice expire time

Description:
Ability to customise invoice expire time
Motivation and Context:
Fix #876
How Has This Been Tested?
Manually
Screenshots (if appropriate):

Types of changes:
Feature
Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes where needed.
[x] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage remained the same at 19.848% when pulling ff27701ec1df456d8f1e950e04a3a06c50db430c on mrfelton:feat/876-invoice-expire-custom into 097e081a0035cbecb0cd1a3fa4a5b3c191eb2449 on LN-Zap:next.


fixMake ES catalog and resource compatible

Proposed changes
close #16099

Make ES resource compatible with username property. Keep the same behavior with ES catalog.
Change ES catalog username to user to avoid confusion.
Add log in ESRestClient and make debug easier.

Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[x] No Need

Has document been added or modified:

[x] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.4 seconds
load time: 546 seconds
storage size:<PHONE_NUMBER>2 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230119103630_clickbench_pr_84068.html


[No QA] Tag staging instead of main before updating checklist

Details
Right here we're pulling main and creating a tag with the new version. Then in the next two steps we:

maybe CP the PR, and
always update the checklist using that tag as a reference to figure out what PRs were merged.

However, the tag created from main might include PRs that were merged but not deployed to staging. For example:

PR 1 is merged.
Tag A is created that includes PR 1.
Staging deploy is locked. Other stuff happens that doesn't matter in this example.
PR 2 is merged. No deploy happens and no tag is created.
PR 3 is merged + CP'd.
Tag B is created off main, and includes PR 2 in its history. But PR 2 was not deployed to staging ❌

This PR should fix this issue by tagging staging instead of main before updating the checklist.
Fixed Issues
Hopefully might (at least partially) fix https://github.com/Expensify/Expensify/issues/168349
Tests

With the deploy checklist locked, merge a PR (A).
Merge + CP another PR (B).
The checklist should be updated to include B but not A.

QA Steps
None.

Updated my previous copy suggestion

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @tgolen in version: 1.0.93-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @yuwenmemon in version: 1.0.94-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[FIXED] Server error utility CI failure

Notes for Reviewers
This PR fixes #
Signed commits

[x] Yes, I signed my commits.

@zakisk there's a merge conflict to have a look at.

@zakisk thanks much for this. I wonder if the commit went on hiatus.

@zakisk I don’t think we need this any longer, it was updated in one of my PR.

Thank you, gents.


New error with 8.0.0? Error [ERR_REQUIRE_ESM]: require() of ES Module - How to resolve?

 Exception during run: Error [ERR_REQUIRE_ESM]: require() of ES Module $$SOMEDIR/node_modules/chai-as-promised/lib/chai-as-promised.js from $$SOMEDIR/test/drivers/driverInterface.spec.js not supported.
Instead change the require of chai-as-promised.js in $$SOMEDIR/test/drivers/driverInterface.spec.js to a dynamic import() which is available in all CommonJS modules.
    at require.extensions.<computed> [as .js] ($$SOMEDIR/node_modules/ts-node/dist/index.js:851:20)

But the quoted driverInterface.spec.js is built from a TS which is:
import * as chai from 'chai';
import chaiAsPromised from 'chai-as-promised';

chai.use(chaiAsPromised);

class RandomInstrumentedResource extends ToolingInterface {
....

Which bit of the code is wrong?   (sorry, I'm maintaining a project, but didn't set up any of this TS/JS stuff)

This feels like a tsconfig problem?   My tsconfig.json file is
{
  "compilerOptions": {
    "target": "es2022",
    "module": "commonjs",
    "lib": [
      "es2022"
    ],
    "declaration": true,
    "strict": true,
    "noImplicitAny": true,
    "strictNullChecks": true,
    "noImplicitThis": true,
    "alwaysStrict": true,
    "esModuleInterop": true,
    "noUnusedLocals": false,
    "noUnusedParameters": false,
    "noImplicitReturns": true,
    "noFallthroughCasesInSwitch": false,
    "inlineSourceMap": true,
    "inlineSources": true,
    "experimentalDecorators": true,
    "strictPropertyInitialization": false,
    "typeRoots": [
      "./node_modules/@types"
    ]
  },
  "exclude": [
    "node_modules",
    "dist"
  ]
}

you're in a commonjs project (module: "commonjs")
8.0.0 is esm-only (like chai 5.x is too)
so you can either:

stay on 7.x if you want to continue using commonjs
migrate to ESM ("module": "nodenext", and set "type": "module" in your package.json)

Thanks. It looks like doing that and I'll have to change 500+ imports to include explicit .js extension?

Node will probably still handle the imports without extensions but I guess typescript may complain if they're not exported paths 😬
It should be scriptable at least but I understand your pain (code review won't be a fun one)
You may be able to loosen typescript's constraints by using module: "bundler"

The problem is you can't use 8.0.0 with Typescript yet, because the @types/chai-as-promised package hasn't been updated yet. I'm using this workaround for now:
import * as chaiAsPromised from "chai-as-promised";
use((chaiAsPromised as any).default);

Once the @types package is updated to 8.0, that can be changed to:
import chaiAsPromised from "chai-as-promised";
use(chaiAsPromised);

we should definitely push a new major to the @types package
if anyone has time to contribute that upstream to DT, i'd be happy to review


Added new attribute provacyPolicies to app creation

we need to get the bug fixed before we merge
@manojava-gk / @nidhigarg-bmw  / @oyo  can someone jump in here?


Touch event cant trigger penetrate '.pusher' when sidebar shown.

I'm new in SUI. I have used Bootstrap a long time.
As the title said. I am struggle with the touch event problem. Dose anyone seen the issue before?
PS: I'm using AngularJs.

            Home

            Search Jobs

            Saved Jobs

        Privacy Policy
        Term Conditions
        xxxx

$(document).ready(function () {
    'use strict';
    $(document).on('touchend', '.left-sidebar-btn', function (event) {
        event.preventDefault();
        $('.ui.sidebar.left').sidebar({
            mobileTransition: 'overlay'
        }).sidebar('toggle');
    });
});

What is the problem that occurs?

 I explain again and plus images.
I click the sidebar trigger button

Sidebar open then click search button

Browser jump to the search page

I expect it don't trigger the search button link. I just want the sidebar close. I mean the click event has penetrate to the search button and this is not correct. I hope you can understand. Thanks for your time.

It's weird. I found this problem only happened in desktop browser simulate mobile environment (Chrome mobile simulator). I test in mobile and Chrome native desktop environment, both don't have this problem.
I don't know is it valuable to fix this issue?

I think this is just related to chrome touch emulation.

It also happened in Chrome on iOS 9

I was able to reproduce this same issue within the current build within both Firefox and Chrome, using touch events. Issue is connected to overflow:x;overflow:y; properties causing 'mouse down' to penetrate the pusher layer.
To me this seems like some sort of brower bug.
For testing, add and the issue should be resolved.
.pushable > .pusher{
overflow-x: initial;
overflow-y: initial;
}

Unsure why overflow-x/y are being set, but you can actually reproduce this issue on the current Semantic UI website.

can anyone help me with this after opening sidebar menu inside that if i click a button it should trigger how to do it for ex: i had a form inside sidebar if i click on save button without entering any values validation messages should come how to do it??


feat; I want to be able to compare google spreadsheets in addition to .xlsx's

As an end user, I also want to be able to compare google spreadsheets for differences due to sharing permissions.

Key questions for translation:

Does Sheets API https://developers.google.com/sheets/api store data in the same way we expect for the program?
How does IO change? What methods need to be re-written for generalizability?


openjpeg: adding patch for CVE-2018-7648

Motivation for this change
Follow-up and replacement of #49262 targeted at staging
Part of #38993
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Success on x86_64-linux (full log)
Attempted: openjpeg
Partial log (click to expand)
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mgq20q9sdvms9hrz4gi335xi6q1jpd5r-openjpeg-2.3.0/lib  /nix/store/mgq20q9sdvms9hrz4gi335xi6q1jpd5r-openjpeg-2.3.0/bin
patching script interpreter paths in /nix/store/mgq20q9sdvms9hrz4gi335xi6q1jpd5r-openjpeg-2.3.0
checking for references to /build in /nix/store/mgq20q9sdvms9hrz4gi335xi6q1jpd5r-openjpeg-2.3.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/y8gchgvr7waqaxisn94s85d0lis0dyxi-openjpeg-2.3.0-dev
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/y8gchgvr7waqaxisn94s85d0lis0dyxi-openjpeg-2.3.0-dev/lib
patching script interpreter paths in /nix/store/y8gchgvr7waqaxisn94s85d0lis0dyxi-openjpeg-2.3.0-dev
checking for references to /build in /nix/store/y8gchgvr7waqaxisn94s85d0lis0dyxi-openjpeg-2.3.0-dev...
/nix/store/mgq20q9sdvms9hrz4gi335xi6q1jpd5r-openjpeg-2.3.0

Success on aarch64-linux (full log)
Attempted: openjpeg
Partial log (click to expand)
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rh6d7cw50cbcnpil7yz56aa4jk8l5cg1-openjpeg-2.3.0/lib  /nix/store/rh6d7cw50cbcnpil7yz56aa4jk8l5cg1-openjpeg-2.3.0/bin
patching script interpreter paths in /nix/store/rh6d7cw50cbcnpil7yz56aa4jk8l5cg1-openjpeg-2.3.0
checking for references to /build in /nix/store/rh6d7cw50cbcnpil7yz56aa4jk8l5cg1-openjpeg-2.3.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/5qahy472bn4zl74d51cl1fvv7pl5nck4-openjpeg-2.3.0-dev
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5qahy472bn4zl74d51cl1fvv7pl5nck4-openjpeg-2.3.0-dev/lib
patching script interpreter paths in /nix/store/5qahy472bn4zl74d51cl1fvv7pl5nck4-openjpeg-2.3.0-dev
checking for references to /build in /nix/store/5qahy472bn4zl74d51cl1fvv7pl5nck4-openjpeg-2.3.0-dev...
/nix/store/rh6d7cw50cbcnpil7yz56aa4jk8l5cg1-openjpeg-2.3.0


How to manipulate images from cloud?

hi, i am literally newbee to  #openseadragon, i have 1000s of high resolution of images (book's pages as jpg image format) in my cloud, i have a web app same as Image Reference Strip feature without openseadragon or zoom function, im fetching minimum 150 book pages per book in one click from my cloud along with book info from mysql (i dunno this is the best way and tell me if there is best way in openseadragon).  So i was planing to make that zoomable image to my app then only i found openseadragon, now im thinking, do i need to make Image Reference Strip instead of my previous feature or i can add some codes to make it zoomable by openseadragon? if its so, for me its really hard to find how to archive this in openseadragon, anyone please explain me how can i archive this

How big are your images? If they are under 3000px wide, you can probably load them with the "Simple Image TileSource" and not have to convert them:
http://openseadragon.github.io/examples/tilesource-image/
You should be able to just put the OSD viewer in place of your existing images, and use the reference strip you already have.
I'd recommend starting off by getting an OSD viewer working in a temporary page, just so you get the hang of it. Then you can work on integrating it into your viewer page. Let me know if you have additional questions.

Thank you very much for your reply mate, i have done it but when i click my other images from thumbnail old big image still there and it is adding other image bellow it, what should i do for this, do i need to hide the previous image when it click new image? how i can do that, explain me please

Are you adding the new images with  viewer.addTiledImage? If so, you can remove them with viewer.world.removeItem.
If just want to replace one image with the next, you can also just to viewer.open, which closes the current image and opens the new one.

No im not using viewer.addTiledImage , im just getting image url and sending into tilesource, so when i click new image old image still there

I see! You were creating a whole new viewer each time. You only need to create one viewer, and then you can have it open one image after the next, like so:
var viewer = OpenSeadragon({
     id:"seaDragon",
     prefixUrl: "js/images/"
 });

$(".book").click(function() {
        var currIndex = $(this).index();
        var src = $(this).find('img').attr('src');
        var tileSource = {
             type: "image",
             url: src,
             buildPyramid:false
        };

        viewer.open(tileSource);
});

Thank you very much mate, it was very helpful, i know it is very basic but im also new to this. i have some question,

as u said if images are under 3000px wide why Simple Image TileSource is enough and no need to convert into DZI? also what will happen if i convert my under 3000px images?
the way i did this getting 100s of images by one click from file server and put it as thumbnails then getting particular image src and placing in one place is efficient or is there is any other best and speedy way?
please explain me. i really do not know that much about image processing, again thank you very much

I was just saying that with internet speeds these days, a 3000px image can download pretty quickly, so it's okay if you don't turn it into a DZI. Even so, it's fine, and perhaps even smoother, if you do turn it into a DZI.
As for loading hundreds of images for your thumbnails, that'll probably cause some slowness, just because of how many transfers that is. One way to speed that up would be to put small versions of all of those images into a single image for the transfer and then break it apart for display in the browser. That's not something OSD can help you with though. Here's some information on doing this with CSS: https://www.w3schools.com/css/css_image_sprites.asp


Enable capability to disable a single invoker for maintenance

In an OpenWhisk deployment with multiple invokers, there may be an occasion to perform maintenance on a single invoker machine without wanting to bring down the entire OpenWhisk system.
Steps might look something like:

mark invoker as going-offline
controller no longer sends work to this invoker
invoker waits for current activations to complete
existing invoker queued action requests are either run/completed or re-queued to another invoker.. need discussion
invoker marks itself as offline
maintenance can be performed
invoker restart does not cause invoker to automatically become online.
mark invoker as being online

related issues
#2678

@markusthoemmes

Once we have the functionality in the invoker, we could connect it to kube's PreStop hook for the container lifecycle (https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/) to enable clean shutdown of pods during kube-initiated maintenance.

sounds good.  i want to suggest that if the "maintenance mode" invoker is restarted, it should still be in "maintenance mode" receiving no work.  only until it is explicitly taken out of maintenance should it be ready for work.

@markusthoemmes, after some experimenting with terminating an invoker actor system via REST endpoint, I noticed that activation records do not get posted to the database after the actor system has been shutdown. Perhaps a better implementation would consist of directly telling the controller an invoker is in maintenance mode, and to take that invoker out of the scheduling system.

Another option might be to disable the Scheduler in the invoker to stop it from sending the ping messages back to the controller.

Was able to stop only the actor responsible for ping the controller, which allows for activation records to be posted to the database for user containers that are still running when the actor is stopped.
Sample code: https://github.com/dubee/openwhisk/commit/40d655b327a6a2d47343dd08692f0f4d699c7329


question about getting RDP enabled on Windows 10 Home

Hi
I'm trying to get RDP enabled on Windows 10 Home
I tried running the MSI installation and something flashed up then I restarted but I see from ipconfig | findstr 3389 that windows remote desktop isn't started.
Then I looked here https://github.com/stascorp/rdpwrap/issues/885
It has a bunch of steps including extracting a zip and renaming an ini file, though there's no ini file in the zip.
I  look at the zip, it has an install.bat  I try that, still no listening on port 3389.
I try update.bat still no
I restart
still no
I try rdpconf.exe
https://i.imgur.com/vT7XWOt.png
wrapper state- installed
server state-running
listener state- not listening
also it says "[not supported]"

okay got it, I had to extract it to C:\program files\RDPWrap  and put autoupdate.bat with it run that and then it was fine.

Closed as solved.


[snapshot] Fix grouping for iPad Pro 12.9-inch (3rd gen) in sc…

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
When generating screenshots for iPad Pro (12.9-inch) (3rd generation), in screenshots.html they were grouped with other iPad Pro 12.9 inch generations. This has now been fixed.
Solves issue #14085
Description
Added a row for the iPad Pro (12.9-inch) (3rd generation) in   xcode_9_and_above_device_name_mappings of reports_generator.rb.
Tested manually with a few different snapfiles. Ran tests (see above).

Do I need to add something to this PR?

No, just someone from the team needs to find the time to test this out (or be confident enough on code alone) to be able to leave an "Approve" review and then merge this.

👍🏻

On 27 Jun 2019, at 21:49, Daniel Jankowski<EMAIL_ADDRESS>wrote:
@mollyIV approved this pull request.
Hey @claesjacobsson 👋
Thank you for creating this PR 🙇
I was testing the changes from your branch. Created the following Snapfile:
// Snapfile
devices([
"iPad Pro (12.9-inch)", "iPad Pro (12.9-inch) (2nd generation)", "iPad Pro (12.9-inch) (3rd generation)"
])
languages(['en-US'])
output_directory("./screenshots")
clear_previous_screenshots(true)
I made a quick summary screenshot from the results below:
iPad Pro (12.9-inch) (3rd generation) has now a dedicated section in the screenshots.html report, well done 👍👏 🎊
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

(If you have the time, you could look at https://github.com/fastlane/fastlane/issues/14951#issuecomment-506531575 @claesjacobsson - same area of the code again)


ci: add action for semantic PR titles and apply labels

This PR introduces a new GitHub Actions workflow to enforce semantic pull request titles for better clarity and consistency in the development process.

I think I'd prefer a conventional commit bot over this. There's 21.5k lines of Javascript in this PR! Anyways, it does not look wrong to me, so
/lgtm

Thank you @jiridanek , for reviewing.
We discussed this issue in our last meeting and decided to create a new branch for the conventional-release-labels GHA code. @thesuperzapper will take care of this, and I will update this PR to reference it using kubeflow/notebooks/PATH@BRANCH.

@Adembc can you make a new PR that only does the "validate PR titles" part, because we havent really decided on the labels for release notes generation yet.
If you do that, please update to the latest version of the amannn/action-semantic-pull-request  action, as there are new versions since this PR was made.

@thesuperzapper done 8202eecd9510b7292cc1025c169cf70347d9f8a7

@Adembc thanks!
Lets look into a few things after this:

Making a similar PR into the main branch
Doing the "apply labels" step using the outputs feature of the amannn/action-semantic-pull-request step:

Remove all relevant labels, apply the ones that correspond to the type/scope.
We would probably need to use a custom actions/github-script, or we could use the same fork of the conventional-release-labels step as we previously were.

/lgtm
/approve

I raised the same PR #158 into the main branch


Feature: support async call?

like Dubbo async call.
https://dubbo.apache.org/zh/docs/advanced/async-call/

I don't think the cost of creating a goroutine to implement async logic is high, so we won't support at this time.

so, I add a async example later  in kitex-examples?

daidai21

Of course,  welcome to add the example ; )

https://github.com/cloudwego/kitex-examples/pull/32


#558 print out named scalar as name = value in Symbol.render()

Description
Fixes #558
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Key checklist:

[x] No style issues: $ flake8
[x] All tests pass: $ python run-tests.py --unit
[x] The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.
Further checks:

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works
[x] Any dependent changes have been merged and published in downstream modules

overload the __repr__ operator for Scalar

tried that, but it doesn't play nicely when you print an equation (you get weird equals signs in there), so just defined it for render

use .format() instead of %s

Yes, I'll fix this


Support default return values for the function first or return null.

Environment
Knex version: 0.14.6
Database + version: Postgresql 10.4
OS: MacOS Sierra
Feature discussion / request
Support default return values for the function first or return null.
The current behavior of first when no row found is to return undefined and when having a function that returns a promise with knex query that ends with .first() it means that this function might return undefined.
This causes a problem if you use Hapi as your server.

I don't think this is a good idea.
Null and undefined means different things. If null is returned, it might mean that row was found and certain  column was selected, but there was NULL stored in that column.
If there would be added new builder method .returnNullInsteadOfUndefinedWhenRowNotFound() it would be as easy to just add .then(val => _.isUndefined(val) ? null : val) to that query (of course you would write some helper function for that).

Thanks @elhigu but that's not accurate... If the column value is null, knex will return an object with the column name as key and the value will be null.
By definition, if the row wasn't found we should get null - http://www.ecma-international.org/ecma-262/6.0/#sec-terms-and-definitions-undefined-type
4.3.10 undefined value

primitive value used when a variable has not been assigned a value

4.3.12 null value

primitive value that represents the intentional absence of any object value

If the column value is null, knex will return an object with the column name as key and the value will be null

In most of the cases yes, but in some cases it doesn't (IIRC if you use pick() or update with returning definition with single column given to returning part.
4.3.10 undefined value

primitive value used when a variable has not been assigned a value

4.3.12 null value

primitive value that represents the intentional absence of any object value

That is basically just talking about when you have variables. Real world doesn't really work like that. For example lodash returns undefined when value was not found and so does pretty much every other library when it is convenient to make distinction between value being null and undefined. Even Array.find and other javascript's "standard library" methods uses undefined to represent that something was not found.
Anyways that doesn't mean that this feature would be out of the question, it just means that it will never be default behaviour in knex.
Is it possible to extend hapi to prevent problems with this?
What is the proposed API for this feature?

So maybe we can do it not as default behavior but pass a 2nd argument which is the default in case the row wasn't found? like lodash get.
About hapi - that's its behavior.. Changing that changes the lifecycle - https://hapijs.com/api#lifecycle-methods

.first() currently supports both .first([column1, column2]) and .first(column1, column2) if I'm not mistaken. So applying a second argument there could be breaking, just pointing that out.
According to docs in that link it supports async functions, so shouldn't a simple || solve this?
Before
return knex(table).first()

After
return await knex(table).first() || null;

Maybe I'm wrong, I've never used Hapi myself before.

Thanks @wubzz , I think you're right regarding the 2nd (and rest) parameter.
I prefer not using the || operator for many reason - https://www.codereadability.com/javascript-default-parameters-with-or-operator/
I can use lodash get but it's not as nice as if I was able to use knex functionality...

Agreed, closing for now.


improved documentation of method get_filtered_output

description of method get_filtered_output missing on page develop/test/pytest
https://docs.zephyrproject.org/latest/develop/test/pytest.html
proposed changes to pytest

add documentation for method get_filtered_output
add method get_filtered_output to section shell-class on page develop/test/pytest

Environment

Page: develop/test/pytest
Version: main
SHA-1: e0f8a8f16ef3b8c32bc64aedfd04d5daea5b7aac

Thanks for the PR! Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request.

@tguenth  will you fix those compliance issues reported by CI?

@tguenth thanks again for the contribution. It would be really great if you could amend your commit to fix the compliance issues? It would be too bad for your pull request not to make it just because of that :)

@tguenth ping - thanks!

updated the commit message


some questions about the paper

Hi, Mr. Tekin
I am reading your paper(Real-time Seamless Single Shot 6D Object Prediction) and I have some questions. This is my first time dealing with object pose estimation problem. In your paper, you mentioned 9 control points, but YOLO can only regress 2D bounding box of the objects and its class. Previously, I was working on SSD, I am not very familiar with YOLO, but I think YOLO and SSD are similar. Here are the questions:

How to predict the projections of the 3D bounding box corners in the image by using YOLO? Since YOLO can only regress 2D bounding box(object's location in the image) of the objects and its class.

You selected 9 control points(8 points are the corners, 1 point is the center). How do you get these 9 points?  and the 3D ground truth points?

What data is known? For example, the dimension of objects?  the depth? the camera intrinsic? the point cloud data?

Here are the answers to your questions:

We modify the loss function of YOLO such that we do not predict the 2D bounding box, but the projections of the 9 control points in the 3D object model. Please see Section 3.1 of the paper for further details.

The ground-truth 3D model of the object is provided in the dataset. 8 corners of the 3D object model are basically [[min_x, min_y, min_z], [min_x, min_y, max_z], [min_x, max_y, min_z], [min_x, max_y, max_z], [max_x, min_y, min_z], [max_x, min_y, max_z], [max_x, max_y, min_z], [max_x, max_y, max_z]] positions of the 3D object model.

Here, in this model based 6D pose estimation problem, 3D object model and the camera intrinsic is assumed to be known. In our case, we do not assume to know the full detailed 3D model of the object as in previous studies but just a rough framing of the object (3D bounding box). The depth of the object is not assumed to be known but rather it is estimated (z-component of the translation vector).

P.S. As this is not an issue for the code, but rather general questions about the paper, maybe it's better to discuss about these on email.

i get it, thank you very much


Remove repeatability support for token revocation endpoint

Removing repeatability support for /identities/{id}/:revokeAccessTokens endpoint. Support will be implemented later in MVP1 feature.
This version is not GA yet -> no breaking change.

@jhendrixMSFT Can you help us override the breaking changes check - for background: the last merge had added repeatability headers for a future api-version. Now they've discovered that they won't be able to implement them for both routes and removed one again. So net-change there will be a new stable api-version which adds the headers only for one route.
(We probably shouldn't have merged to main and keep this as a feature branch a while longer)

I need more context here. Did a previous api-version ship that supported this header and now support for the header is being removed? I assume that 2023-08-01 never shipped, right?

@JeffreyRichter this version hasn't been shipped yet, so this shouldn't be a breaking change. Thank you.

The BreakingChange label isn't applied to this PR so I don't think I have to approve it, but I did anyway.
@mikekistler: What should I do here? Is this in the right branch? Maybe they just shouldn't not have tried to make the PR to main yet? I know you wrote up the rules around this, but I can't remember where they are, if they are final, and if they're somewhere available to others (so we could add the link to PRs like this). We need to get this information out to everyone (including me).

@mikekistler : Can you help on the above question from @JeffreyRichter and help us merge this PR.

I agree with this:

(We probably shouldn't have merged to main and keep this as a feature branch a while longer)

But that's water under the bridge.  This PR makes things right, so we should go forward.  This is good to merge.


Specify resultCode when using trackDependency

There doesn't seem to be any way to provide this, have I missed something or is this not supported in the current API?

A straightforward way to set this does seem to be missing. Thanks for catching this! Be aware, if you're using auto-collection of dependencies, the result code will still be tracked correctly.
For manual collection, you can store resultCode as a custom property, which will show up in the portal and analytics but not in the usual place you would expect resultCode. You can also combine this approach with a telemetry processor for a full workaround that places resultCode in the expected field rather than a custom property:
var appInsights = require("applicationinsights");

appInsights.client.addTelemetryProcessor((envelope) => {
    if (envelope.data.baseType === appInsights.contracts.DataTypes.REMOTE_DEPENDENCY) {
        // Instanceof check is optional. Provides type hinting for baseData
        let rdData = envelope.data.baseData; // May need to cast envelope.data to any if using TS
        if (rdData instanceof appInsights.contracts.RemoteDependencyData && rdData.properties.resultCode) {
            rdData.resultCode = rdData.properties.resultCode;
            delete rdData.properties.resultCode;
        }
    }
    return true;
});

appInsights.client.trackDependency("name", "commandName", 200, false, "HTTP", {resultCode: 404});


Move tests/Testing to Integration testing

Somewhere along the way the Testing directory got moved to the tests root. We need to do the following:

Move that directory to the integration tests directory.
Rename test_get_requests_failure to test_assert_ok_works.
Remove the todo comment and replace exception expectation with a PHPunit assertion failed exception expectation.

Solved by #199.


Add standard errors to stage duration plots

Currently the plots of stage duration either show CIs or standard deviation. Would be nice to add SEs.

This issue should be closed with PR #75 right?

No, it now has CIs and standard deviation, but I would also like standard errors. However, for that I need some xarray magic that I don't possess

Fixed by PR #96


Salesforce release type does not allow monorepo

Environment details

OS: OSX
Node.js version: 19.0.1
npm version:9.4.2
release-please version: 15.7.0

Steps to reproduce

create a config file with two entries: "." and "force-app" which is the minimum required for a single metadata directory. Note: Many projects will have multiple metadata directories such as "unpackaged" and various extension directories.
Create the same headings in the project config file.
Attempt to run release-please release-pr (token, repo, branch) and get an error that says

MissingRequiredFileError: salesforce (dschach/campaign-member-status): Missing required file: force-app/sfdx-project.json
But a given SFDX project should have only ONE sfdx-project.json file, with a separate packageDirectories object for each package or metadata grouping.
For an example, see my repo with three metadata directories (force-app, unpackaged, and triggerhandler)
I am concerned that this Salesforce release type has not been tested properly. It already violates rules by putting version numbers in packageDirectories objects that don't have a value for package.
Release Please Manifest
{
  ".": "0.0.0",
  "force-app": "0.0.0",
  "triggerhandler": "0.0.0",
  "unpackaged": "0.0.0"
}

Release Please Config

{
  "packages": {
    ".": { "release-type": "salesforce" },
    "force-app": { "release-type": "salesforce" },
    "triggerhandler": { "release-type": "salesforce" },
    "unpackaged": { "release-type": "salesforce" }
  },
  "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json",
  "release-type": "salesforce",
  "changelog-path": "CHANGELOG.md"
}

Hi @dschach !
The actual implementation is written to work with the very simple use case where the sfdx-project.json contains one package.
It will works if the packageDirectories attribut contains multiple entry but will update only the default one containing a versionNumber.
So, it does not work for other package declared in the file yet.
That being said, I would like to help, what would be the result of using release please with multiple package ?
How should it behave ?
Per exemple 2 package A and B under force-app folder

force-app/A
force-app/B

and the following sfdx-project.json:
{
    "packageDirectories": [
        {
            "path": "force-app/A",
            "default": true,
            "package": "A",
            "versionNumber": "1.0.0.NEXT"
        },
        {
            "path": "force-app/B",
            "default": true,
            "package": "A",
            "versionNumber": "3.2.0.NEXT"
        }
    ],
    "sfdcLoginUrl": "https://login.salesforce.com",
    "sourceApiVersion": "57.0"
}

Let's assume we have a commit creating a new major for A and a new minor for B
Then new content should be:
{
    "packageDirectories": [
        {
            "path": "force-app/A",
            "default": true,
            "package": "A",
            "versionNumber": "2.0.0.NEXT"
        },
        {
            "path": "force-app/B",
            "default": true,
            "package": "A",
            "versionNumber": "3.3.0.NEXT"
        }
    ],
    "sfdcLoginUrl": "https://login.salesforce.com",
    "sourceApiVersion": "57.0"
}

They both share the same changelog file right ? What should be its content ?
Note:
I think the complexity here is the package definition is in the same file for every package (the lerna use case, kind of)

Thanks for the reply @scolladon - yes, I think the complexity lies in the single file tracking all version numbers, AND I think there may be some complexity in the package name having spaces (because Salesforce allows that) while release-please seems to prohibit spaces. It appears to look for a package name somewhere, though I admit that I don't understand that complexity completely.
There are some multi-repo Salesforce repos (unoffialSF uses one) but those have individual package.json files.
It seems we have to look at multiple use-cases... multi-sub-repo, and monorepo. And we should account for all of those. (And yes, it does look somewhat like the lerna use-case.)
BTW, in your last code example, it has package and version number, but keep in mind:
People may use their repos for making packages, but some just use it to maintain an org or to host open-source projects. Those projects sometimes have multiple metadata directories but no package name for some of them. For orgs just breaking up metadata on their path to org-dependent packages, it resembles the ISV model, so that's fine.
Sorry for rambling - I see a few use-cases for an sfdx project, and I'd like us to be able to allow for all of those.
One last thought: Having separate changelogs would actually be really cool... as an option. Some orgs may want a unified changelog.
So much to think about... Of course Salesforce makes it complex. :)

To directly answer your question: Some packages have unpackaged metadata in separate directories, that are needed for Apex tests, or sometimes just for installation of extra metadata. See an example at https://github.com/salesforcelabs/actionplansv4 to see what I mean.


Fixing state code and debugging instructions

Changed return state to updateState(state); Also added basic instructions on how to view debug logs.

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
Public repo URL: https://github.com/Microsoft/azure-docs/blob/master/articles/azure-portal-overview.md
Private repo URL: https://github.com/Microsoft/azure-docs-pr/blob/master/articles/azure-portal-overview.md
We have closed this pull request. Please resubmit the updates through the private repo. If you need perms to the private repo, see the contributor guide instructions


HTML

HTML
User Story
As a bootcamp student,
I want to create a portfolio website,
So that potential employers can review several deployed website showcasing skills.
Acceptance Criteria
Given a Portfolio website
When the website can be visited via web browser.
The code utilises Bootstrap elements.

Bootstrap elements added


[SPARK-15342][SQL][PySpark] PySpark test for non ascii column name does not actually test with unicode column name

What changes were proposed in this pull request?
The PySpark SQL test_column_name_with_non_ascii wants to test non-ascii column name. But it doesn't actually test it. We need to construct an unicode explicitly using unicode under Python 2.
How was this patch tested?
Existing tests.

Test build #58637 has started for PR 13134 at commit b5abe42.

Test build #58637 has finished for PR 13134 at commit b5abe42.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58637/
Test PASSed.

Merged build finished. Test PASSed.

Test build #58665 has started for PR 13134 at commit 97fb7f5.

Test build #58665 has finished for PR 13134 at commit 97fb7f5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58665/
Test PASSed.

cc @davies Please take a look, thanks.

LGTM,
Merging this into master and 2.0, thanks!


OmniSharp isn't working at all in (Neovim, Visual Studio, Visual Studio Code)

For the past couple of days I couldn't work at all because omnisharp lsp wasn't working in my main ide AstroNvim so I thought the problem is with Mason a lsp package manager that AstroNvim uses so I tried to work in vscode and it wasn't also working so I thought maybe vs itself should work and still the same result  and the crazy part is that in each editor they were not working in an absolute different ways here are the problems:
Astro Neovim:
1 - it doesn't understand any of the projects context so it cannot understand any of the definitions it can't even understand the default C# packages like System
2 - lsp omnisharp times out
3 -  E5248: Invalid character in  group name
Visual Studio Code:
1 - have troubles loading the projects
2 - says my project and my files are a miscellaneous file
Visual Studio:
1 - Error	MSB4018: The "ResolvePackageAssets" task failed unexpectedly.
2 - it also doesn't understand the context of the project obviously for obvious reasons just like astronvim

Now everything is working fine in both vscode and vs except that AstroNvim is still giving me this error after typing anything: "E5248: Invalid character in group name"


Hardening ssh (DH moduli)

[ in the wake of https://stribika.github.io/2015/01/04/secure-secure-shell.html ]
Keep only higher than 2048 bits length prime numbers used for the Diffie-Hellman Group Exchange key exchange method
Before
[root@mail:~]# awk '$5 > 2000' /etc/ssh/moduli |wc -l
176
[root@mail:~]# awk '$5 < 2000' /etc/ssh/moduli |wc -l
86
[root@mail:~]# wc -l /etc/ssh/moduli
262 /etc/ssh/moduli

After
[root@mail:~/nixpkgs]# git cherry-pick d2fa06c37a4f1945ae7408c2d6a78fc658d32685
[root@mail:~/nixpkgs]# nixos-rebuild switch -I nixpkgs=/root/nixpkgs

[root@mail:~]# awk '$5 > 2000' /etc/ssh/moduli |wc -l
176
[root@mail:~]# awk '$5 < 2000' /etc/ssh/moduli |wc -l
0
[root@mail:~]# wc -l /etc/ssh/moduli
176 /etc/ssh/moduli

Shouldn't this be fixed upstream? I don't feel very comfortable messing with OpenSSH...

Devs, I intentionally specified there -gt 10 in order to make sure that there are at least 10 stronger than 2048 bits length primes, otherwise it will use the default openssh provided moduli.

@edolstra fixed upstream? I don't get..
I did this commit for myself basically, and it's just a proposal PR so that others could benefit from it. (to avoid re-creation of bicycle)
However, if you/folks would prefer not to mess with the OpenSSH, then please feel free to close this PR ;-)

If the moduli file produced by OpenSSH is bad, then this should be fixed upstream in OpenSSH, not by us (since most of us are not crypto experts so I'd rather defer to upstream's choices).

Alright, I agree with you.
Then I'll close this one ;-) Thx

@arno01 seems good to keep this open to keep track of upstream status, so people don't forget that it's a real issue. Or is it already in a good state upstream?

@copumpkin why not :-) let's keep it open and see what future brings ;)

OpenSSH still distributes small moduli. Apparently, cannot be removed from the file because that would render the server incapable of communicating with clients running on old hardware that cannot deal with large primes. IMHO, this means that we cannot throw out small moduli either, because we certainly don't want our users locked out of their server after running nixos-update switch.
Anyway, the available material on the web (http://security.stackexchange.com/questions/41941/consequences-of-tampered-etc-ssh-moduli and http://security.stackexchange.com/questions/79043/is-it-considered-woth-it-to-replace-opensshs-moduli-file in particular) suggests that it's actually more important to use different moduli on every server rather than using very large ones all the time, because attackers have pre-computed their attack vectors for the moduli file from OpenSSH long ago.
A moduli file is easy to generate with ssh-keygen, but the process requires lots of memory and takes well over on hour (on a fast machine), so we cannot do as part of the boot process. We cannot do it as part of the build either, obviously. So, I guess the only thing we can do is offer our users an option to configure their own moduli file in NixOS.


No channel choice

Hi
Thnaks for  your amazing project.
I'd just build from source CrystalFetch: there are no channel choice possibility for Windows 11 (Preview, Release) or Server,  or previous version. I don't undestand why !
Could you help me, please. Thanks.

I had this same exact issue.
Under view, once I clicked "Show Advanced Options", I got a button in the bottom left that said "All Builds" or something.

Once I clicked it, I got the interface that you see in the README


Document how current directory set in subninja

It was surprise that current directory changed to directory of .ninja file pointed in subninja.
I have tried to use subninja but .ninja files was generated in the same directory that build.ninja.
As a result building failed because of wrong current directory.
My fault,  it won’t change directories: https://groups.google.com/forum/#!topic/ninja-build/9QsfUZLCwSQ

To workaround not changing directory my ninja.generator produce such output:
builddir = dsp/main/Release # ninja build dir vs current dir
p = dsp/main # project dir vs current dir
pos = dsp\main # project_dir with windows psth.delimiter
a = dsp/main/Release
o = dsp/main/Release
rule compile_c6x
  command = pushd $pos && "$CXX" $CXX_FLAGS ${opts} -c $loc_in -o $loc_out && popd
build $o/adc_free.obj: compile_c6x $p/../hw/adc_free.c
  loc_out = $o_/adc_free.obj
  loc_in = ../hw/adc_free.c
  opts = -fr"$o_" -o3 -mi7000 -mv67p
build $o/busbar.obj: compile_c6x $p/../hw/busbar.c
  loc_out = $o_/busbar.obj
  loc_in = ../hw/busbar.c
  opts = -fr"$o_" -o3 -mi7000 -ms3 -mv67p
rule link_c6x
  command = pushd $pos; "$LINKER" $LINKER_FLAGS ${opts} -o$loc_out $loc_in && popd
build $a/main.out: link_c6x $o/adc_free.obj $o/busbar.obj
  loc_out = $a_/main.out
  loc_in = $o_/adc_free.obj $o_/busbar.obj

The idea is using pushd && compiler_cmd && popd and special variables {loc_in} and {loc_out}
Now build.ninja file can lay in directory 2 levels upper than project main.

@zlolik Can't you just use cd instead of pushd/popd? The commands are executed in a subshell anyway so a cd won't actually change the ninja processes' current dir.

Why not run the commands from the project root directory?

@NiklasRosenstein hm, really - just one cd is enough. Thanks!
@martine, I want to build some projects from one build.ninja that has one DG and I don't like building subprojects with ninja -C.


Add zoom config in preprocessing when using per_patch

Hello! Thank you so much for doing these changes Clement!
I have a suggestion here:

Change please the variable name to _C.DATA.PREPROCESS.ZOOM to follow the same preprocessing convention we are already using. Even if the zoom can only be aplied when predicting by_chunks I would do that way. I'd put in it's comment/description above a message warning the user that is only enabled in that case (see other cases in config.py that are described like that so you can follow the same message structure in case you have doubts). E.g. for Canny preprocessing this is hwo it's done: https://github.com/BiaPyX/BiaPy/blob/f872e1fd74fe55b66c694ef0289bb07495265c5f/biapy/config/config.py#L320

Hello thank you for your review @danifranco
I changed the structure as requested. Tell me if I can do something else to match BiaPy pattern.

Just few minro things more:

Add an example on how to use that in DATA.PREPROCESS.ZOOM.ZOOM_FACTOR above description please. Like: "E.g. [1,2,2,2,3] that needs to match Zarr axes"? or something like that.
It's length is related to TEST.BY_CHUNKS.INPUT_IMG_AXES_ORDER or TEST.BY_CHUNKS.INPUT_MASK_AXES_ORDER? If so put a check in check_configuration.py please.

Hello !

I added an example in the description
I added a configuration check to raise an error if the zoom factor is not the same size than the img_axes_order


Minor revisions for inference

This PR add some minor revisions:

Fixed a little issue in the marginalization;
Solved the name conflict issues when adding the activation layer to ResNet;
Add more logging information;
Update the prediction notebook.

@dusenberrymw Could you have a look at this PR?


Token creation should allow 'no expiration'

Feature description 💡
Currently both team tokens and user tokens don't allow to create tokens without expiration date. Even if the time values are set to 0, the expiration date is set.
I believe the value 0 should mean no expiration, and this should imply the tokens will never expire. On top, the info tooltips should provide info about this.
Anything else?
While team tokens have a default time-values set to 0, the user tokens creation dialog doesn't set 0 as default (blank value).

I am no a security expert but I think could create some issues. why would you need a token with no expiration?

I am no a security expert but I think could create some issues. why would you need a token with no expiration?

Automations (like GitHub Actions). I'm currently working on the PR preview plans feature via GitHub Actions (but any other API feature could fit also), and a TK API token is needed. I believe for these kind of use cases, the 'no expiration' feature is worth it. At the end, it's on the people using those tokens to keep them safe and to rotate them when they consider.
On top, TFC allows you to create tokens without expiration, so I believe it makes sense also in TK.

I will try to add this in the following weeks

Next version will allow to set "0" when creating the PAT or team tokens when you specify days, hours or minutes


[#18] Adds formatting for services and an additional example

Notes for Reviewer
Here is the pull request with fixed branch name and better formatting.
Pre-Review Checklist for the PR Author

[ ] Add sensible notes for the reviewer
[x] PR title is short, expressive and meaningful
[x] Relevant issues are linked
[x] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
[x] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
[ ] Commits messages are according to this guideline

[ ] Commit messages have the issue ID ([#123] Add posix ipc example)
[ ] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[ ] Tests follow the best practice for testing
[ ] Changelog updated in the unreleased section including API breaking changes
[ ] Assign PR to reviewer
[ ] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

[ ] Commits are properly organized and messages are according to the guideline
[ ] Unit tests have been written for new behavior
[ ] Public API is documented
[ ] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

References
Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.
Closes #29

@hydroid7 could you please also add this into the doc/release-notes/iceoryx2-unreleased.md release documentation under the features section.
The entry would look somehow like this:
* Add `Display` implementation for `PortFactory` [#29](https://github.com/eclipse-iceoryx/iceoryx2/issues/29)

I did not review the patch but please don't forget why this is done. We want to replace the custom printing code in these to locations

https://github.com/eclipse-iceoryx/iceoryx2/blob/main/iceoryx2/src/service/port_factory/publish_subscribe.rs#L24-L34
https://github.com/eclipse-iceoryx/iceoryx2/blob/main/iceoryx2/src/service/port_factory/event.rs#L24-L29

Pleas change those examples to just use println!("{}", pubsub); and println!("{}", event);
Oh, and the PR and commit messages use the wrong issue number. It's actually #18. #29 was the previous PR.

Thank you all for the constructive comments, I rewrote the commit messages, added the feature to the releasenotes, changed the documentation in order to reflect the new Display implementation and added the same for pubsub services.

Sorry that these took that long, but here they are.
Background for my contributions is that I'm writing a DDS middleware / message broker as my MSc Thesis.
Therefore I was first looking at iceoryx, but it was rather hard to use for someone without extensive knowledge in the project.

@hydroid7 you need to fix the clippy warnings to make the CI happy

@hydroid7 do you plan to finish this PR in the near future?

I think the PR is abandoned for now. @hydroid7 if you would like to continue working on this please feel free to reopen the PR again.


KOGITO-3930 Align archetype with settings from Quarkus

maybe change also in other pom where it configures org.jboss.logmanager.LogManager ?

@radtriste missed that, fixed.


Add plus button component

Reference the "add" button wireframe on Figma here
Start from the FAB in Material UI here
Add a property isVisible which will allow the button to be hidden for non-admin users (to be done later)
Emit an event to tell the parent when the button is clicked. To do this, add a property callback or onClick which takes a method such as addButtonClicked() as argument. Call this method when the button is clicked.

Closed by #64

Closed by #64


MudDatePicker: Key events handled twice

Bug type
Component
Component name
MudDatePicker
What happened?
Key events are handled twice (@onkeydown and keyinterceptor), which leads for example to open -> submit -> close on a single enter press and other fancy things.
https://github.com/MudBlazor/MudBlazor/blob/b0c7372cde3cba6281119cdfed9f6ef8dde07492/src/MudBlazor/Components/DatePicker/MudDatePicker.cs#L201
https://github.com/MudBlazor/MudBlazor/blob/10938e9fec0b529930e09479577a3ff9176fabf1/src/MudBlazor/Components/Picker/MudPicker.razor#L37
https://github.com/MudBlazor/MudBlazor/blob/10938e9fec0b529930e09479577a3ff9176fabf1/src/MudBlazor/Components/Picker/MudPicker.razor.cs#L416
I think this is related to an old PR draft:
https://github.com/MudBlazor/MudBlazor/pull/3458
Expected behavior
Should handle once
Reproduction link
https://try.mudblazor.com/snippet/mkGwYmQxQSozhUfS
Reproduction steps

Focus uneditable datepicker or click in editable datepicker
Press enter
Watch console

Relevant log output
No response
Version (bug)
6.0.6
Version (working)
No response
What browsers are you seeing the problem on?
Firefox, Chrome, Microsoft Edge, Safari, Other
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Yes with #3393 all keys fires twice, need a proper solution to achieve both solutions.

#3393 was just extending dialog on ESC
#2933 introduced the keyinterceptor on pickers while keeping the @onkeydown

Yes with #3393 all keys fires twice, need a proper solution to achieve both solutions.

As far as I can see, this is not the fault of #3393 but rather #2933 has introduced an additional key interceptor on top of an @onkeydown which introduces the bug that was reported here. I suggest to review your PR @mckaragoz

#3393 was just extending dialog on ESC
#2933 introduced the keyinterceptor on pickers while keeping the @onkeydown

Yes, i understand, but picker PR can not break this because picker PR merged first :) then we created other PRs for each picker (time picker, date picker) and they worked when they first merged.

#3393 was just extending dialog on ESC
#2933 introduced the keyinterceptor on pickers while keeping the @onkeydown

Yes, i understand, but picker PR can not break this because picker PR merged first :) then we created other PRs for each picker (time picker, date picker) and they worked when they first merged. But i agree with solution :)

Please dont feel offended by this, but just because it was merged first, doesnt mean it has not introduced the bug. Have you tried out reverting the changes to before #2933 and tested it out? Maybe it just didnt get noticed when your PR was merged. I cannot see a connection to this bug in #3393 . I am not searching for the person who is responsible, what I am trying to do is to find the source of the bug and obliterate it.
Our best guess is, that the bug originates from the presents of two different handlers in the picker: @onkeydown and the interceptor.
Both introduced by #2933 in this commit: https://github.com/MudBlazor/MudBlazor/commit/609889cdf2a8cfecead4f28f4cc3784dc1436867
I think the next steps should be:

Check if bug happens before #2933
If not, check if it is present after #2933

No, no you are right, i didn't take offended this. Only want to give information because i also noticed the bug before this issue opened. Probably at some point we add multiple events. And need to make a standard for valid for all components.

#3393 was just extending dialog on ESC
#2933 introduced the keyinterceptor on pickers while keeping the @onkeydown

_keyInterceptor.KeyDown += HandleKeyDown; deleting this line solves the problem, will it be negative affects with dialog esc key @MattChique ?

@mckaragoz No, removing this line has no impact to dialogs, because MudDialog (like other components with keyboard navigation) has its own connection to the IKeyInterceptor service.
But wouldn't it be better to preserve the keyinterceptor with possibility to preventdefault and stoppropagation instead of onkeydown? I don't know the circumstances for the onkeydown, just a thought.
Maybe this was just an overlap of both, because at the same time @henon invented the KeyInterceptor in #2851

@henon @mckaragoz closing this, since #6777 is merged now.


Crash to desktop when this ASI is installed alongside LML

When Rage-LowPriorityPropRestore.asi and Lenny's Mod Loader (LML) are both installed, the game immediately crashes to desktop. LML already has a built-in feature that does the same thing as this mod (restores low-priority props). I suspect either the hook itself or the patch location is conflicting. At any rate, it's not necessary to have both installed.
Could you please at least add a mention to the README that you shouldn't install this ASI alongside LML, and possibly add a check in the initialization code to exit the hook or display a warning if vfs.dll is present?

Hi, sorry I was dead for so long. I have added check so this will not initialize while using LML(un tested) thankx for the report xP

@0x-FADED it looks like from the recent commits that you're only detecting LML with RDR2, but it's also available (via vfs.dll) for GTAV.

@pnwparksfan just figured out that LML only causes crash in case of GTA5 so I have added checks for GTA5 now. it's working with RDR2 with LML in my case but needs more testing(pls do some testing if you have time) if it also causes issue on RDR2 I'll add a .toml to allow users to fine tune LML checks and initialization of this mod.


Match Processor Exception

Hey Luke!
Sooo, i'm guessing I need to expose something for a process exception?
JDK 10.0.1
Exception creating Injector : Multiple exceptions thrown of type: java.lang.NullPointerException. To see individual exceptions, call MatchProcessorException#getExceptions(), or call FastClasspathScanner#verbose() before FastClasspathScanner#scan().io.github.lukehutch.fastclasspathscanner.MatchProcessorException: Multiple exceptions thrown of type: java.lang.NullPointerException. To see individual exceptions, call MatchProcessorException#getExceptions(), or call FastClasspathScanner#verbose() before FastClasspathScanner#scan().
at io.github.lukehutch.fastclasspathscanner@3.1.10/io.github.lukehutch.fastclasspathscanner.MatchProcessorException.newInstance(MatchProcessorException.java:92)

Hi @GedMarc -- did you try calling the method this exception suggests? That will let you get all the individual exceptions, then you can call their printStackTrace() method to see what happened and where.

mmm
Caused by: java.lang.NullPointerException
at io.github.lukehutch.fastclasspathscanner@3.1.10/io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:359)
at io.github.lukehutch.fastclasspathscanner@3.1.10/io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:58)
at java.base/java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:264)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1135)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:844)

[SEVERE]

scanner.verbose(true);
	scanner.createClassLoaderForMatchingClasses();

	registerScanQuickFiles(scanner);
	scanner.suppressMatchProcessorExceptions(false);
	try
	{
		scanResult = scanner.scan(getThreadCount());
	}
	catch (MatchProcessorException mpe)
	{
		System.out.println(mpe.getExceptions());
	}

Thanks, modular scanning has not yet been widely tested, so please report any other issues you find. Fixed in 3.1.12.

It's happening on this error :) thanks I'll give it a try now

Yes, I hadn't tested verbose logging with a modular classpath recently. Module classpath elements don't have an associated File in FCS, since most of the URLs for modules are not valid URLs, they are of the form jrt:/module.name. I'm actually surprised that this module of yours does in fact have a valid file:/ URL, so I'll probably add that to the log as well.


Make the Counter page Increment by 3 instead of 1

Currently the Counter page increments by 1 when you click the button. I want it  to increment by 3.

Working on this now.


resolve a typo found by cppcheck

[server/Windows/wf_mirage.c:319]: (error) Invalid number of character '(' when these macros are defined: ''.
[server/Windows/wf_mirage.c:319]: (error) Invalid number of character '(' when these macros are defined: 'DFMIRAGE_LEAN'.
[server/Windows/wf_mirage.c:319]: (error) Invalid number of character '(' when these macros are defined: '_WIN64'.

@freerdp-bot test

@freerdp-bot test again


Update Italian localizations

cc @Titianbeetle

@Titianbeetle I apologise for butting in, I wanted to mention something that I only figured out how to do myself relatively recently that might be helpful to you.
When you're reviewing a translation and you want to suggest an alternative, you can click the button with the + and - symbols on a page and type in your suggestion:

It's then very easy for the PR owner to accept it with one click if they're happy with your suggested change.

@surfdude29 I'm not clear on the syntax of strings like this
"{0, plural, one {Like (# like)} other {Like (# likes)}}"
what are the words that need to be translated?

@surfdude29 I'm not clear on the syntax of strings like this
"{0, plural, one {Like (# like)} other {Like (# likes)}}"
what are the words that need to be translated?

This one is doubly confusing because the first Like is a verb and like/likes is a noun. The context is that this is the accessibilityLabel for the Like button on posts:
https://github.com/bluesky-social/social-app/blob/d614f6cb71bf2751834dbd800b5f43257d5c074a/src/view/com/util/post-ctrls/PostCtrls.tsx#L246-L255
So looking at the translations already done it seems like the verb should be Mi piace but I'm not clear what the noun for like/likes is, is it also Mi piace? 🤔

Is this one good to go?

@pfrazee for me, yes!

Is this one good to go?

Is this one good to go?

@pfrazee for me yes!

Sorry did you intend to close this PR?

Sorry did you intend to close this PR?

No, I'm sorry, I made a mistake, in reporting other changes I closed this PR by mistake, but I just wanted to realign my fork, I made a mess.

Cool no worries!


Add name to ShopTimeResolution and set default shop scenario time resolution

Description
Added some shop time resolution instances, allow our existing shop scenarios to reference them and create a scenario+ scenario set that used a 15 min version (within shop) test

Checklist:

[ ] Tests added/updated.
[ ] Documentation updated.
[ ] Changelog updated in CHANGELOG.md.
[ ] Version bumped. If triggering a new release is desired, bump the version number in pyproject.toml per semantic versioning.

I can't see the ShopTimeResolution instances defined here - I guess they should be added in this PR? Otherwise, it looks good.

Added the property name to ShopTimeResolution, so that the instances can be created here and also we reference them in the same way across the project
(same update needs to be done for customer envs)


n17: FreeNukum

This is the section about FreeNukum for Newsletter 17. I hope the quality is good enough. Thank you for your initiative!
https://github.com/rust-gamedev/rust-gamedev.github.io/issues/408

Thanks for the PR! Good luck with the project!

Thanks for the PR! Good luck with the project!


release install pack which does not require java installation

Is your feature request related to a problem? Please describe.
As you may have known that many people are having problems using ghidra because ghidra requires install and setup java properly. And some people may do not want to contaminate his system and they do not want to install java.
Describe the solution you'd like
We can release install pack which does not require java installation so people can use it out of box. For example, we can pack jar to exe on windows and we can make a dmg on macos which contains JDK and already set everything properly. Someone already did it:
https://gist.github.com/yifanlu/e9965cdb148b550335e57899f790cad2

Ghidra supports launching with Java's that have contaminated the system via an installer, as well as in-place Java extractions that minimally impact the system.  I recommend you read the Installation Guide to see all the possibilities.