RNNLM rescore + Low-order density ratio

This PR implements RNNLM rescore + LODR in pruned_transducer_stateless7_streaming. Compared with modified_beam_search_lm_rescore, it achieves lower WERs at a slight cost of decoding speed. Will post the benchmark later in this PR.
It requires kenlm as dependency. You can install kenlm via the following command:
pip install https://github.com/kpu/kenlm/archive/master.zip

WER comparison:
Medium RNNLM:
Num params: 17,306,100

decoding-method
lm_scale
lodr_scale
beam-size
test-clean
WERR
test-other
WERR

modified_beam_search
-
-
4
3.11

7.93

modified_beam_search
-
-
8
3.1

7.95

modified_beam_search
-
-
12
3.12

7.96

modified_beam_search_lm_rescore
0.46

4
2.97
4.5%
7.63
3.78%

modified_beam_search_lm_rescore
0.49

8
2.8
9.97%
7.22
8.95%

modified_beam_search_lm_rescore
0.49

12
2.74
11.9%
7.0
11.73%

modified_beam_search_lm_rescore_LODR
0.54
0.30
4
2.95
5.14%
7.62
3.9%

modified_beam_search_lm_rescore_LODR
0.58
0.30
8
2.75
11.6%
7.17
9.6%

modified_beam_search_lm_rescore_LODR
0.58
0.35
12
2.68
13.8%
6.96
12.2%

Large RNNLM:
Num params: 102,760,948

decoding-method
lm_scale
lodr_scale
beam-size
test-clean
WERR
test-other
WERR

modified_beam_search
-
-
4
3.11

7.93

modified_beam_search
-
-
8
3.1

7.95

modified_beam_search
-
-
12
3.12

7.96

modified_beam_search_lm_rescore
0.43
-
4
2.93
5.79%
7.6
4.16%

modified_beam_search_lm_rescore
0.48
-
8
2.67
14.15%
7.11
10.34%

modified_beam_search_lm_rescore
0.47
-
12
2.59
16.72%
6.86
13.49%

modified_beam_search_lm_rescore_LODR
0.54
0.50
4
2.9
6.8%
7.57
4.5%

modified_beam_search_lm_rescore_LODR
0.56
0.55
8
2.63
15.43%
7.04
11.2%

modified_beam_search_lm_rescore_LODR
0.58
0.45
12
2.52
19.0%
6.73
15.13%

Comparison of decoding speed (in seconds, evaluated on test-clean).

decoding-method
lm_size
beam=4
beam=8
beam=12

modified_beam_search
-
132
177
210

modified_beam_search_lm_rescore
medium
152
184
231

modified_beam_search_lm_rescore
large
156
203
255

modified_beam_search_lm_rescore_LODR
medium
147
206
252

modified_beam_search_lm_rescore_LODR
large
160
203
263


add publisher string support and versioning

I have created a object vendor consent string (who support versioning, encoding and decoding) and create the support of publisher consent string.

@visskiss Hi,
Why ? Generating a consent string on iOS is not allowed ? So, no CMP ? What is the purpose of reading a consent string if no-one can generate-it ?
Plus, others libraries have the support of generating the consent string (javascript, java)
I think that IAB needs to provide a supported way to generate a valid consent string

The swift API as published by the IAB is the ConsentStringProtocol found in this repository. When the API changes, the protocol and implementation will follow.

Hi Visskiss,
Yeah, I understand, but in this case, you will not have differents versions support ? If a consent string v2 is published by IAB, you should be able to decode a consent string v1, no ?
And what about the encode feature ? Some CMP may want to use an open source library supported by IAB. And maybe update the Readme because it says that the library

can encode and decode consent strings

Thanks

Hi Visskiss,
I completely agree with Jean (Jivyx), e.g. we the publishers(who act as CMP as well) would like to generate consent strings as well using this SDK (based on vendors list, purposes supported etc). Many publishers have raised this with IAB since the first day this SDK was released, otherwise this SDK is mainly  useless if we have to rely on one more party SDK to generate the Consent Strings. Same changes were requested in IAB Java SDK and have been approved and implemented. In-fact now there is a discussion on how to support this for whole Android Eco-system.
Regards,
Zahoor

Hi Zahoor,
The intent of the IAB from what I understand is that you should use the Consent Widget (I'm looking for a link) to manipulate the consent string.  The Swift framework is really intended just for decoding.  Why? Because the consent widget has access to the web and is viewed in a web view that allows access to the live json file. Doing the same thing across multiple frameworks was not the intent.  As a CMP, you should be using that widget to perform the necessary functions of obtaining consent.  This swift framework is intended to access the relevant values for publishers (and not CMP's).  I understand where you are coming from.  Is there any reason you are not using the consent widget?

the goal is to be able to use it in a native CMP.

Agree on @Pernic 's above- was under the impression that fully native SDK would be supported by the IAB.


How to release a app in staging at first

Let's say when we release a new podinfo chart, as HelmRelease will scan that chart in 5m, then new podinfo app will deployed on both production and staging environment.
Is there a way we can deploy in staging environment first?

We've had a lot of growing pains using a layout like this for some time now and I haven't landed on a good solution. Your example is a good one, but there are lots of others in terms of "how do i put something in stage first, and eventually promote it up?". Most of them time it involved a lot of yaml manipulation. (We're still on flux v1, but i think v2 just adds one level of indirection in this case)
In your case, I'm assuming you wouldn't have 'prod' pointing to the master branch, but maybe a tag. Then you could increase the chart tag in the stage yaml patch file, and ones it's good to go, you would make one commit to remove it from the stage file, and set that chart version on the 'base'
Version increases are easier because they're managed in the environment values file already, but anything that is a bit more complex becomes pretty involved. For instance, adding a key to the values in a helm-release. We we only want to do it in stage initially, but then to promote it up, eventually we want it to get to prod. Similarly, I would add the key in the stage values: https://github.com/fluxcd/flux2-kustomize-helm-example/blob/main/apps/staging/podinfo-values.yaml
Then once i was happy with it, I would 'promote' the change into production, probably in here https://github.com/fluxcd/flux2-kustomize-helm-example/blob/main/apps/base/podinfo/release.yaml and remove it from stage. Alternatively I COULD also put it in prod values (https://github.com/fluxcd/flux2-kustomize-helm-example/blob/main/apps/production/podinfo-values.yaml) but then I'd have it on two places going forward.

We've had a lot of growing pains using a layout like this for some time now and I haven't landed on a good solution. Your example is a good one, but there are lots of others in terms of "how do i put something in stage first, and eventually promote it up?". Most of them time it involved a lot of yaml manipulation. (We're still on flux v1, but i think v2 just adds one level of indirection in this case)
In your case, I'm assuming you wouldn't have 'prod' pointing to the master branch, but maybe a tag. Then you could increase the chart tag in the stage yaml patch file, and ones it's good to go, you would make one commit to remove it from the stage file, and set that chart version on the 'base'
Version increases are easier because they're managed in the environment values file already, but anything that is a bit more complex becomes pretty involved. For instance, adding a key to the values in a helm-release. We we only want to do it in stage initially, but then to promote it up, eventually we want it to get to prod. Similarly, I would add the key in the stage values: https://github.com/fluxcd/flux2-kustomize-helm-example/blob/main/apps/staging/podinfo-values.yaml
Then once i was happy with it, I would 'promote' the change into production, probably in here https://github.com/fluxcd/flux2-kustomize-helm-example/blob/main/apps/base/podinfo/release.yaml and remove it from stage. Alternatively I COULD also put it in prod values (https://github.com/fluxcd/flux2-kustomize-helm-example/blob/main/apps/production/podinfo-values.yaml) but then I'd have it on two places going forward.

@aleclerc-sonrai I just figure out how to use this pattern in multi-environment. This repo shows the detail, but let me explain why i did this.
We are talking about git-ops, not helmchart-ops or s3bucket-ops. So, the only way we deploy or update something, should be commit codes. That's the reason i put charts into repo directly(whether infra or apps) to prevent a release triggered by some incompatible infra charts.
And i use a staging branch to bootstrap staging environment, So if i have updates, i should update staging branch first, i won't influence master/main branch, so it won't influence production environment. And if everything works fine, i would merge staging into main, and push it.
I made /apps a registration place, when we add an app, we should add it here to make it works.
The others are barely the same, what i do is unify sources, and separate deployment by branch.

@aleclerc-sonrai I just figure out how to use this pattern in multi-environment. This repo shows the detail, but let me explain why i did this.
We are talking about git-ops, not helmchart-ops or s3bucket-ops. So, the only way we deploy or update something, should be commit codes. That's the reason i put charts into repo directly(whether infra or apps) to prevent a release triggered by some incompatible infra charts.
And i use a staging branch to bootstrap staging environment, So if i have updates, i should update staging branch first, i won't influence master/main branch, so it won't influence production environment. And if everything works fine, i would merge staging into main, and push it.
I made /apps a registration place, when we add an app, we should add it here to make it works.
The others are barely the same, what i do is unify sources, and separate deployment by branch.


Add support for invalidating IImage

Is your feature request related to a problem? Please describe.
In past it was possible to invalidate IImage but that was removed.
Describe the solution you'd like
A way to raise invalidation for IImage
Describe alternatives you've considered
No response
Additional context
No response

There is a problem with svg image object binding in avalonia xaml with Community MVVM.
The problem described here:
https://github.com/wieslawsoltes/Svg.Skia/discussions/254

This problem creates a lot of inconvenience and difficulty.
This creates problems in complex projects with many modules.
Please fix it.

Maybe it would be enough to make IAffectRender public implementable.
https://github.com/AvaloniaUI/Avalonia/blob/master/src%2FAvalonia.Base%2FMedia%2FImaging%2FCroppedBitmap.cs
I can't say for the team if that is okay or not, but probably worth to open a PR and test this package on your end then wether it suits your needs or not.

Thanks for the reply.

https://github.com/AvaloniaUI/Avalonia/blob/master/src%2FAvalonia.Base%2FMedia%2FImaging%2FCroppedBitmap.cs

No, it doesn't suits our needs. We need svg-image object usual binding.

Unfortunately it doesn't suits our needs. We need svg-image object usual binding.

The idea is that svgimage is then able to impl the interface and thus could be invalidating itself if needed. Its nothing that you as a consumer would have to care. So the question goes more to @wieslawsoltes

Ideally all this is implemented via custom CompositionVisual


Second pre-release

@JuliaRegistrator register
Almost ready for 0.1.0 but want to test some more

Registration pull request created: JuliaRegistries/General/114483
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.0.2 -m "<description of version>" a36e9f301aac3c02f37f7031bd02915dd6769201
git push origin v0.0.2


tx-generator: towards stand-alone mode

In stand-alone mode, the transaction generator can generate lists of transactions
and dump them to files, without a connection to a local or remote node.
This supports new use cases of the transaction generator outside of
benchmarking and makes it easier to test and debug the transaction generator.
This PR add the script action
{ "SetProtocolParameters": { "UseLocalProtocolFile": "/tmp/t2.json" } }
that reads the protocol parameters from a file (instead of querying a node).
And some other changes.

bors r+


Can't install pyth-sdk-solana depencendy

I'm trying to install pyth-sdk-solana sdk into my rust project for fetching price off-chain.
All I did is just put the config into my Cargo.toml
pyth-sdk-solana = "=0.0.8"

But I failed to build, when trying to run cargo build I got this error.

Do I need to install other dependencies manually ?

I can't quite reproduce, it seems cargo is fetching two different and incompatible versions of borsh

Please reopen and provide steps to reproduce if you still encounter the issue.


How to combine it into an Encoder stack

First, thanks for sharing this and other awesome repos!!
I was wondering how to create a transformer Encoder stack out of it, similarly to this: https://github.com/larngroup/DTITR  (there is a nice pretty clear diagram at the top there)
Apart from "manually" creating such architecture, I was wondering, is there some way to tell another lib of yours - x_transformers, to use this custom cross-modality-cross-attention layer (or any type of related cross-modality-cross-attention which you support) to build an Encoder stack with it?
Thanks again for the awesome repos :)

answering my own question in case it will help someone - it seems that you already have an example for that in tf-bind-transformer :)
https://github.com/lucidrains/tf-bind-transformer


impl Deref for newtype Vecs

Several types (Workspaces, Outputs, Marks, BarIds, and
BindingModes) are simply wrappers around Vec, but without any
sugaring to make them directly usable as Vecs.
This impls Deref for each of the mentioned types, thus avoiding
anti-patterns like let workspaces = ipc.get_workspaces()?.workspaces.
Not implemented for Command, as the name does not make it obvious
there can be multiple results, while the field (outcomes) does.

Sorry for the delay. This is worth doing something about but Deref is probably not the way to go:

... the rules regarding Deref and DerefMut were designed specifically to accommodate smart pointers. Because of this, Deref should only be implemented for smart pointers to avoid confusion. link

Let's remove the wrapper types. It's fine to break backwards compat as i3ipc-rs does not promise a stable API.
@Celti  would you want to take this on since you discovered the issue? I'm willing to if not


Automatically identify the class name based on the specified line number.

Motivation
Whenever some user passes the command -e <line_number>, it feels redundant to specify the class name.
The closest class name (above the specified <line_number>) should automatically be identified by the program, and updates the value of scene_names key in the run_config dict.
Proposed Changes
I couldn't find a better position to insert the code than in the insert_embed_line_to_module function. As it ensures that the scene_names updates only when the e flag is passed, and also the module lines can be used to determine the class name.
Also, resolving minor bugs in text_mobject and string_mobject files.

There are some cases where the scene that has the embed line is not the same as the one I'm running. For example, suppose you define some SceneA with a certain construct. Then you define SceneB as a subclass, which doesn't have its own construct method (so it effectively uses that of SceneA), but makes other changes to the class variables, methods, etc.
It may be that you want to drop an embed line in the construct method of SceneA, but to invoke SceneB.
The desired behavior is that if you do pass in a scene names, like manimgl file_name.py SceneB -se 123, then that scene name should take priority over whatever one lies above line number 123.
This should be a pretty quick fix, I believe all you need to do is check whether run_config already has scene_names defined, and if so, don't do the search for the scene.

Thanks @3b1b for the feedback.
I believe the recent changes is what you were suggesting.

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。


Logo in readme not visible in dark mode

The text gitmarkonics is not visible in the dark mode of github. I would like to add the logo that is there on the website with a white background to make it visible.
Please assign to me under LGMSOC.

I can make the ReadMe logo visible in dark mode as well as light mode, because once the logo is changed from dark to light it wont be visible on the light mode.
Please assign to me under LGMSOC21.

Hey @Yashnatani021-coder actually I opened the issue to work on it hoping that you would assign it to me.

@varshitha1707 You could always look for open issues or create your own and get assigned :)

@varshitha1707 You could always look for open issues or create your own and get assigned :)

I apologise for not noticing your request to also be assigned.
But, I already edited it and created a pull request.


Game crashes when breaking andesite stairs

Hello,
The issue is able to be recreated and the Log file is here: https://paste.atlauncher.com/view/90682beb
Line 5885 is where I log in and immediately break the other stair for testing. Line 5939 is where things go sideways.
Server logs are this:
[21:04:34] [Server thread/INFO] [net.minecraft.server.management.PlayerList]: Taqiri[/<IP_ADDRESS>:54491] logged in with entity id 3712366 at<PHONE_NUMBER>384855, 150.0,<PHONE_NUMBER>858409)
[21:04:34] [Server thread/INFO] [net.minecraft.server.dedicated.DedicatedServer]: Taqiri joined the game
[21:04:34] [Server thread/INFO] [Waila]: Player EntityPlayerMP['Taqiri'/3712366, l='TechWorld', x=173.44, y=150.00, z=284.10] connected. Sending ping
[21:04:34] [Server thread/INFO] [tfc]: Player Logged In - Checking for Calendar Updates.
[21:04:34] [Server thread/INFO] [tfc]: Reverted doDaylightCycle to true as players are logged in.
[21:04:52] [Server thread/FATAL] [net.minecraft.server.MinecraftServer]: Error executing task
java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: Cannot get property PropertyBool{name=can_fall, clazz=class java.lang.Boolean, values=[true, false]} as it does not exist in BlockStateContainer{block=tfc:stairs/smooth/andesite, properties=[facing, half, shape]}
at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_252]
at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_252]
at net.minecraft.util.Util.func_181617_a(SourceFile:47) [h.class:?]
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:723) [MinecraftServer.class:?]
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:397) [nz.class:?]
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:668) [MinecraftServer.class:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526) [MinecraftServer.class:?]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_252]
Caused by: java.lang.IllegalArgumentException: Cannot get property PropertyBool{name=can_fall, clazz=class java.lang.Boolean, values=[true, false]} as it does not exist in BlockStateContainer{block=tfc:stairs/smooth/andesite, properties=[facing, half, shape]}

Should be fixed in latest TNFC and TFC update.


Dev

:tada: This PR is included in version 2.13.16 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


New Message bar/Date marker overlaps blocked messages

Describe the bug
Title. The spacing is also a bit weird even with normal messages. It looks fine when between two different message groups though.
Screenshots

Infomation (please complete the following information):
Discord channel: Canary
OS: Windows
Mod: Powercord
Discord language: English

Doesn't seem to be an issue anymore?


windows conatiner, container-shim's memory useage increases infinitiely

Description
same this issue
https://github.com/containerd/containerd/issues/7375
Steps to reproduce the issue

Describe the results you received and expected
same this issue
https://github.com/containerd/containerd/issues/7375
What version of containerd are you using?
1.6.28
Any other relevant information
No response
Show configuration if it is related to CRI plugin.
No response

If same issue as #7375, can this be closed as duplicate?


No way to share singleton between Nitro plugin and routers

As discussed in a previous issue, Nitro's storage layer is for some reason not available within vinxi. It was suggested to simply use the unstorage library directly.  The issue with this approach is that unstorage needs to be instantiated in a singleton somewhere, most typically in a Nitro plugin that runs after server start up.  If I want to be able to populate data in that singleton then I need to have the file under reference be consistent between the Nitro plugin file and the router entrypoint file.  However, on build, for some reason these two diverge.
Here is a stackblitz example. Note how after building  npm install && npm run build && npm start the keyValueStore added to the singleton in nitro-plugins/test.ts is not available in the server.tsx.
Please let me know if there is some special configuration I can do to externalize this singleton so that the build doesn't double reference the file in the runtime.mjs output. I've tried many things and the only one that works consistently is to put the singleton in a completely separate npm package. However, it would be nice if this just worked out of the box as it does when using Nitro directly.
Finally, as I think you're already aware, plugins simply don't work at all in dev mode (which is actually acceptible for my use case).

Update: The hack solution of putting the singleton in a separate package only actually works when using pnpm or yarn. Issue persists with npm

Update: Found resolution. Closing issue.
If anyone else has this issue, the solution is to configure the rollupConfig of the server to mark any files you don't want to be bundled when running vinxi build as external. In addition I also found it necessary to configure a server.alias to these files to get the externalization to work properly. They obviously must also be javascript.
example:
export default createApp({
  server: {
    alias: {
      '@external': path.resolve(path.resolve(), '@external'),
    },
    plugins: ['./nitro-plugins/whateverPlugin.ts'],
    rollupConfig: {
      external: [
        path.resolve(path.resolve(), '@external', 'keyValueStore.js'),
      ],
    },
  },
});

and then in whateverPlugin.ts
import { keyValueSingleton } from<EMAIL_ADDRESS>

Edit: Update
This still isn't great. The above solution I described does in fact externalize the import but it does so via hardcoding an absolute path into the built output. You can then write a custom rollup plugin to find and replace these, while also copying over the source files to built output, but it feels like no more of a solution than simply putting all your code into a separate file linked package.
I'm going to reopen this issue because I think there can be a much better flow for the incredibly common need for sharing in-memory data between Nitro plugins and routers. Without Nitro's built in implementation of unstorage, singletons are kind of a must, and they're incredibly harrowing to implement right now.

@toakleaf I know, suboptimal workaround, but have you thought on just storing your singleton in globalThis? Thats how I am solving my singleton needs at the moment 😅

Related issue: #51

Thanks @katywings. I had totally forgot about globalThis as an option. I guess I'll go with that solution and close down the issue again. Still feels a little bit like a hack, but there are probably more pressing issues that can get the oxygen


Update intro.md

Fixes #7089
@skeeler  please review

@Rick-Anderson , had a quick look and some additional comments, but these may represent different issues and shouldn't affect this change going through:

In the Prerequisites section of the docs (https://docs.microsoft.com/en-us/aspnet/core/data/ef-rp/intro?view=aspnetcore-2.1#prerequisites) it states: ".NET Core SDK 2.0 or later". However, the only version of dotnet-aspnet-codegenerator is 2.1 -- does it work with .NET Core SDK 2.0?
The article version selector shows 1.0, 1.1, 2.0, and 2.1, but the article content doesn't change when different versions are selected.
The "--version" indicator is okay, but thinking more about this, would it make more sense to omit the "--version 2.1" specifier from the command? I'm assuming "dotnet tool install" would pick the latest stable version in this case. Might make it easier to not have to update the doc every time a newer version of the package is released.

@skeeler  This is a stop-gap quick fix until I have time to  update the entire article for 2.1
Currently all 2.0 topics show up as 2.1 and higher. We need to figure out how to fix that.
All of the issues you pointed out will be fixed with #6482 - which I hope to get to in a couple weeks.


Codable with date encoding / decoding strategy

How can i add date encoding / decoding strategy to response.decode()?

@Lang-le, can you tell us how do you finally fix this issue please? Thanks! 🙂

@alexruperez, I decode manually from response?.object()
let decoder = JSONDecoder()
decoder.dateDecodingStrategy = .formatted(myDateFormatter)
if let data: Data = try response?.object(),
    let json: MyClass = try? decoder.decode(MyClass.self, from: data) {
  // do something
}

Working @Lang-le, thanks again!


Update CDU4

Codecov Report

Merging #53 into develop will decrease coverage by 1.11%.
The diff coverage is 77.96%.

@@             Coverage Diff              @@
##             develop     #53      +/-   ##
============================================
- Coverage      64.02%   62.9%   -1.12%
- Complexity       327     328       +1
============================================
  Files             76      77       +1
  Lines           1084    1100      +16
  Branches          25      27       +2
============================================
- Hits             694     692       -2
- Misses           378     395      +17
- Partials          12      13       +1

Impacted Files
Coverage Δ
Complexity Δ

.../com/ufg/listaplic/converter/ListConverterDTO.java
100% <ø> (ø)
1 <0> (-2)
:arrow_down:

.../ufg/listaplic/converter/QuestionConverterDTO.java
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

...com/ufg/listaplic/model/ApplicationListStatus.java
66.66% <ø> (ø)
1 <0> (ø)
:arrow_down:

...va/br/com/ufg/listaplic/service/AnswerService.java
75% <0%> (-25%)
2 <0> (ø)

...r/com/ufg/listaplic/controller/ListController.java
64.28% <100%> (ø)
6 <1> (ø)
:arrow_down:

...ava/br/com/ufg/listaplic/dto/AnswerStatusType.java
100% <100%> (ø)
1 <1> (?)

...c/main/java/br/com/ufg/listaplic/model/Answer.java
73.68% <100%> (-7.57%)
9 <2> (ø)

.../main/java/br/com/ufg/listaplic/dto/AnswerDTO.java
69.23% <66.66%> (-0.77%)
5 <1> (+1)

...java/br/com/ufg/listaplic/service/ListService.java
76.92% <76.31%> (+11.53%)
8 <7> (+3)
:arrow_up:

...om/ufg/listaplic/converter/AnswerConverterDTO.java
86.66% <80%> (-13.34%)
2 <1> (+1)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3296013...cb3436b. Read the comment docs.


An empty list returns by method get_devices()

An empty list returns by method get_devices()
I found that response from server in method update_devices() return {"error":400,"msg":"params incomplete"}
Fix: https://github.com/lucien2k/sonoff-python/pull/13

Verified! Thanks @VDigitall for sharing!
Having a SSL issue now

Can you provide more information?

Sure, I have 2 sonoff basics. and I'm running:
s = Sonoff("xxx, "yyy", "us")
devices = s.get_devices()
if devices:
# We found a device, lets turn something on
device_id = devices[0]['deviceid']
s.switch('on', device_id, None)
time.sleep(10)
s.switch('off', device_id, None)
This is the stack trace:
/Users/estebanroblesluna/anaconda2/envs/please-smile2/bin/python /Users/estebanroblesluna/disk/code/ps/please-smile/test/sonoff_test.py
Traceback (most recent call last):
File "/Users/estebanroblesluna/disk/code/ps/please-smile/test/sonoff_test.py", line 10, in
s.switch('on', device_id, None)
File "/Users/estebanroblesluna/disk/code/ps/please-smile/services/v2/switch/SonoffLib.py", line 255, in switch
self._ws = self._get_ws()
File "/Users/estebanroblesluna/disk/code/ps/please-smile/services/v2/switch/SonoffLib.py", line 220, in _get_ws
self._ws = create_connection(('wss://{}:8080/api/ws'.format(self._wshost)), timeout=10)
File "/Users/estebanroblesluna/anaconda2/envs/please-smile2/lib/python2.7/site-packages/websocket/_core.py", line 511, in create_connection
websock.connect(url, **options)
File "/Users/estebanroblesluna/anaconda2/envs/please-smile2/lib/python2.7/site-packages/websocket/_core.py", line 220, in connect
options.pop('socket', None))
File "/Users/estebanroblesluna/anaconda2/envs/please-smile2/lib/python2.7/site-packages/websocket/_http.py", line 126, in connect
sock = _ssl_socket(sock, options.sslopt, hostname)
File "/Users/estebanroblesluna/anaconda2/envs/please-smile2/lib/python2.7/site-packages/websocket/_http.py", line 253, in _ssl_socket
sock = _wrap_sni_socket(sock, sslopt, hostname, check_hostname)
File "/Users/estebanroblesluna/anaconda2/envs/please-smile2/lib/python2.7/site-packages/websocket/_http.py", line 232, in _wrap_sni_socket
server_hostname=hostname,
File "/Users/estebanroblesluna/anaconda2/envs/please-smile2/lib/python2.7/ssl.py", line 369, in wrap_socket
_context=self)
File "/Users/estebanroblesluna/anaconda2/envs/please-smile2/lib/python2.7/ssl.py", line 599, in init
self.do_handshake()
File "/Users/estebanroblesluna/anaconda2/envs/please-smile2/lib/python2.7/ssl.py", line 828, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:727)
Process finished with exit code 1

This is probably a problem with either self-signed certs or expired certs.
export PYTHONHTTPSVERIFY=0
will work around it

Thanks that works

Hey, sorry to reopen the issue, but i'm having the same problem, returned device list is empty, i'm correctly connected.
If i try the get request using my bearer_token and the params in your code i'm receiving {"error":400,"msg":"params incomplete"}
Thanks for your help


Templating config in version 2

I used to template out the config string, using variables for passes, etc.
with the change now using 'to_yaml', this seems to break. in plain yaml, the vars are not being interpolated, and the |- notation does not work, as it generates a string with all control characters present, which is not yaml compliant.
i'm sure i'm missing something, how is everybody else doing that? @markstos

Hey @whysthatso
Can you please provide an example of the usage you're describing?

autorestic_config: |-
  version: 2
  locations:
    "{{ inventory_hostname }}_{{ domain.replace('.','_') }}":
      hooks:
        before:
[...]

Did you try this?
autorestic_config:
  version: 2
  locations:
    "{{ inventory_hostname }}_{{ domain.replace('.','_') }}":

yes, and it keeps the quoted string as a literal in the result.
however, now i saw that it actually interpolated the same variables correctly when they are part of a list further down:
autorestic_config:
  version: 2
  locations:
    "{{ inventory_hostname }}_{{ wp_domain.replace('.','_') }}":
      hooks:
        before:
          - mkdir /tmp
          - mysqldump --databases prod_{{  domain.replace('.','_') }} | gzip > //tmp/prod_{{ domain.replace('.','_') }}.sql.gz
          - 'curl -m 10 --retry 5 -X POST -H "Content-Type: text/plain" --data "Starting backup for {{ inventory_hostname }}_{{ wp_domain }}" https://domain.com/ping/{{ healthcheck_backup_uuid }}/start'

so it seems to be related to this string being a key and in double quotes.
is there another syntax i could try?

Hey @whysthatso
Have you tried using the template lookup plugin?
So specify the contents of autorestic_config as you had it before in a Jinja template file located in a templates/autorestic_config.j2 and then:
autorestic_config: "{{ lookup('ansible.builtin.template', 'autorestic_config.j2') }}"

If #11 was problematic, it can be reverted.

Hey @whysthatso
Have you tried using the template lookup plugin?
So specify the contents of autorestic_config as you had it before in a Jinja template file located in a templates/autorestic_config.j2 and then:
autorestic_config: "{{ lookup('ansible.builtin.template', 'autorestic_config.j2') }}"

Hi @whysthatso - Did you manage to test this out yet?

Hey @whysthatso
Have you tried using the template lookup plugin?
So specify the contents of autorestic_config as you had it before in a Jinja template file located in a templates/autorestic_config.j2 and then:
autorestic_config: "{{ lookup('ansible.builtin.template', 'autorestic_config.j2') }}"

Hi @whysthatso - Did you manage to test this out yet?

i haven't tried this and i'm pretty sure this would work. i reverted to not using a variable as a key in that particular situation, since it did not add any value there. i'll close it and consider this edge case documentation. i think having an easily lintable config is more important than providing for any edge case. it was just an educating find after all :)

i'm running into another issue, regarding variables and backends:
i have a backblaze b2 backend defined like so:
backends:
  b2:
    type: b2
    path: 'bucket-name:/{{ domain }}'
    key: {{ vault_restic_pass }}
    env:
      B2_ACCOUNT_ID: '{{ vault_b2_restic_target_account_id }}'
      B2_ACCOUNT_KEY: {{ vault_b2_restic_target_account_key }}

i need this to output:
backends:
  b2:
    type: b2
    path: 'bucket-name:/example.com'
    key: key
    env:
      B2_ACCOUNT_ID: 'id'
      B2_ACCOUNT_KEY: key

however, in any variance i try to escape the quotes, they are always stripped out.
i've tried
"'bucket-name:/example.com'"

''''bucket-name:/example.com'''

"''bucket-name:/example.com""

error on templating

"'bucket-name:/example.com'"

'bucket-name:/example.com'

@dbrennand  i've now also tried your version:
autorestic_config: "{{ lookup('ansible.builtin.template', 'autorestic_config.j2') }}"

contrent of my template looks like this:
version: 2
locations:
  wellpress:
    hooks:
      before:
...

but that just writes out a literal string with all control characters, not a proper yaml config.
i'm a bit out of options here, does anybody have working examples that they can add as documentation? @markstos

Hey @whysthatso - Do the values you're trying to pass through have special characters?
Ansible's to_yaml and to_nice_yaml use pyyaml under the hood: https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/filter/core.py#L45
Based on this comment:

YAML really doesn't need the quotes. Only if the string contains/starts with special characters, but in that case pyyaml will quote it automatically.

I have been looking into this, and I've been playing around with to_yaml and to_nice_yaml. I pushed https://github.com/dbrennand/ansible-role-autorestic/commit/48ca916a11687c74363a7d7ed37e1b96a9f04651
Here is my example:
domain: example.com
b2_key: test!
b2_secret: testing12!*
autorestic_config:
  version: 2
  locations:
    home:
      from: /home/me
      to: remote
      # Every Monday
      cron: 0 0 * * MON
  backends:
    remote:
      type: b2
      path: "bucket-name:/{{ domain }}"
      env:
        B2_ACCOUNT_ID: "{{ b2_key }}"
        B2_ACCOUNT_KEY: "{{ b2_secret }}"

Which outputs to below, which has the double quotes around the values:
"backends":
    "remote":
        "env":
            "B2_ACCOUNT_ID": "test!"
            "B2_ACCOUNT_KEY": "testing12!*"
        "path": "bucket-name:/example.com"
        "type": "b2"
"locations":
    "home":
        "cron": "0 0 * * MON"
        "from": "/home/me"
        "to": "remote"
"version": ! "2" <--- This is messed up

Unfortunately, I think I may have accidentally stumbled across a bug, because for some reason, the output for version is missing the rest of the YAML tag to show it is an integer (!int), and autorestic complains:
root@instance:/# autorestic info
Using config: 	 /root/.autorestic.yml
version specified in config file is not an int
Using lock:	 /root/.autorestic.lock.yml

When modifying the task to:
- name: Create autorestic configuration file
  ansible.builtin.copy:
    content: "{{ autorestic_config | to_nice_yaml(default_style='\"', canonical=True) }}"
...

It works but the output ~/.autorestic.yml is not ideal...
root@instance:/# autorestic info
Using config: 	 /root/.autorestic.yml

  Location: "home"

From	← /home/me
To	→ remote
Cron	0 0 * * MON

  Backend: "remote"

Type	b2
Path	bucket-name:/example.com
Env	✧ B2_ACCOUNT_KEY testing12!*
	✧ B2_ACCOUNT_ID test!

---
!!map {
    ? !!str "backends"
    : !!map {
        ? !!str "remote"
        : !!map {
            ? !!str "env"
            : !!map {
                ? !!str "B2_ACCOUNT_ID"
                : !!str "test!",
                ? !!str "B2_ACCOUNT_KEY"
                : !!str "testing12!*",
            },
            ? !!str "path"
            : !!str "bucket-name:/example.com",
            ? !!str "type"
            : !!str "b2",
        },
    },
    ? !!str "locations"
    : !!map {
        ? !!str "home"
        : !!map {
            ? !!str "cron"
            : !!str "0 0 * * MON",
            ? !!str "from"
            : !!str "/home/me",
            ? !!str "to"
            : !!str "remote",
        },
    },
    ? !!str "version"
    : !!int "2",
}

See how the version 2 shows the correct YAML tag !!int.

Hey @whysthatso
If time permits, could you please test changes I made in https://github.com/dbrennand/ansible-role-autorestic/issues/14#issuecomment-2198313786 and see if this works for you too?


Update path to container cert and key.

The current path is incorrect.
$ cf ssh proxy -c 'echo $CF_INSTANCE_CERT $CF_INSTANCE_KEY'
/etc/cf-instance-credentials/instance.crt /etc/cf-instance-credentials/instance.key

Cheers,
Angela and Gabe

Thanks, @chinangela ! Now that the Diego cell rep sets the values of those environment variables to the absolute paths of the certificate and private key files, they should be the canonical way to discover the locations of those files, and we should remove other references to their location. The Diego team may end up moving their location soon anyway: we're realizing that there's now a small collection of files and directories that the rep injects into containers, and so we'll likely try to consolidate their locations soon to provide a crisper filesystem contract. In any case, would you be interested in revising this PR to refer only to the environment-variable values? If not, I'd be happy to do that myself.
Best,
Eric

Hi @ematpl,
We've updated the doc. Please take a look and let us know if there are any issues.
Cheers,
Angela and Gabe

Thanks, @chinangela, looks great! I'll merge it in.
Best,
Eric


Subfleet CSV import

Importing CSV does not update the name of aircraft that already exist.
To replicate:
Import CSV for subtype changing the name of a particular subtype that already exists.
It will not change to the new name.

It's hard to keep track since the index is by name. Does it add a new aircraft?

Subfleet doesnt have tail number, thats aircraft within subfleet.
I thought the index would be by "Type" since that is whats used for aircraft CSV.
IT doesnt create a new subtype, it just skips.
I think you are confusing the Aircraft import and Subtype import CSV, this is the very first one that contains all subtypes.

I have an open task, which I naturally can't find right now, to combine the subfleet and aircraft into a single import. I'm probably thinking of that planned transition

I saw that, was closed #233

Ah right, I saw my note in that, they're separate because the subfleet does have extra information. What I will do is at least here in this import, if I don't see the subfleet, I'll create it, so it won't error out. But the subfleet import/export will stay as-is because the expenses info and that other stuff.


[Feature] Django Upgrade

Based on DRF changes in #5210
Some nice things that will be changed in future PRs.

LGTM. Putting this in RTM :feet:


MB-15610 - Add sit playwright tests

Jira ticket
Summary
This PR should introduce two testharness scenarios that create moves with shipments in SIT.
Something to pay extra attention to: I moved a bunch of waitForPage functions from the playwright/tests/office/servicescounseling/servicesCounselingTestFixture.js to playwright/tests/utils/officeTest.js since these pages are shared between all office users, and pages that implement OfficePage can add their own pages for specific user roles.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

check out the new testharness scenarios by visiting the testharness url
/testharness/list
new scenarios are named HHGMoveIn200DaysSIT and HHGMoveIn200DaysSITWithPendingExtension
run the new SIT playwright tests from a console window
yarn playwright test playwright/tests/office/txo/sitUpdates.js

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Screenshots

Messages

:book:
:link: MB-15610

  Generated by :no_entry_sign: dangerJS against 35d955983329fc33dddc2ddea18d65b74167231d


Channel 0 on Devices Using NI DAQmx Incorrectly Produces Measurements of 0

This has been reported on two separate devices. The problem does not exist on Typica 1.6.2, it does not exist with NI DAQmxBase devices. It is unrelated to Typica's configuration.
As soon as I am able to replicate and correct the issue, Typica 1.6.4 should be released.

I was able to replicate this issue with a NI USB TC01. Unfortunately, there don't seem to be any relevant code changes between 1.6.2 which works and 1.6.3 which doesn't. While I was trying to get to the bottom of this it stopped failing on me for unknown reasons. There are still some avenues for investigation. Prior to a release of 1.6.4 I'll send a build to people who have reported this issue. There's no point to that release without fixing this issue.

The 1.6.4 release candidate which I believe should fix this has been sent to the people who have reported this. I'm waiting for them to have a chance to test that and report if the issue truly is fixed before closing this.
http://www.randomfield.com/programs/typica/1.6.Typica-1.6.4.zip


CONTAINER_RUNTIME_ERROR when trying to test out litmuschaos 3.0

Environment: Minikube
minikube version: v1.31.2
commit: fd7ecd9c4599bef9f04c0986c4a0187f98a4396e
container runtime - minikube forced to use docker as container runtime via config
OS: Windows, running wsl2
Litmuschaos installation method: Helm
NAME    NAMESPACE       REVISION        UPDATED                                 STATUS          CHART           APP VERSION
chaos   litmus          1               2023-10-27 08:11:27.2414885 +0530 IST   deployed        litmus-3.0.0    3.0.0
The chaos infra has been configured with "cluster wide access" and not namespace scoped for now.
What happened:
I tried to install a fresh install of litmus 3.0 and take it for a spin as we have been extensively using the older version for our chaos tests internally.
I was able to create the chaos infra and register the local cluster.
I tried to create a http 500 fault for the HTTPBIN service (which was deployed using the istio sample here: https://raw.githubusercontent.com/istio/istio/master/samples/httpbin/httpbin.yaml
Service is running on port 8000.
Only one instance of the pod running (replica = 1)
But when running the experiment I am running into the following error:
{"source":"pod-http-status-code-helper-85fj8","errorCode":"CONTAINER_RUNTIME_ERROR","phase":"ChaosInject","reason":"failed to get container pid: E1027 03:20:16.491436 117340 remote_runtime.go:432] \"ContainerStatus from runtime service failed\" err=\"rpc error: code = NotFound desc = an error occurred when try to find container \\\"83bdb19e57cec8c4a7f848729e139089bf04dccc3ba027fe2cb48cfbfbcd39b4\\\": not found\" containerID=\"83bdb19e57cec8c4a7f848729e139089bf04dccc3ba027fe2cb48cfbfbcd39b4\"\ntime=\"2023-10-27T03:20:16Z\" level=fatal msg=\"getting the status of the container \\\"83bdb19e57cec8c4a7f848729e139089bf04dccc3ba027fe2cb48cfbfbcd39b4\\\": rpc error: code = NotFound desc = an error occurred when try to find container \\\"83bdb19e57cec8c4a7f848729e139089bf04dccc3ba027fe2cb48cfbfbcd39b4\\\": not found\"\n","target":"{containerID: 83bdb19e57cec8c4a7f848729e139089bf04dccc3ba027fe2cb48cfbfbcd39b4}"}

The container runtime has been updated in the YAML with the correct sock
kind: Workflow
apiVersion: argoproj.io/v1alpha1
metadata:
  name: httpbin-500
  namespace: litmus
  labels:
    infra_id: 3d12edc2-ce3c-4f08-9564-26a9da980a96
    revision_id: a270a30e-8813-45ff-b18f-3f6b40627658
    workflow_id: 557f5505-356a-4634-8cd0-abaf0cb4e456
    workflows.argoproj.io/controller-instanceid: 3d12edc2-ce3c-4f08-9564-26a9da980a96
spec:
  templates:
    - name: httpbin-500
      inputs: {}
      outputs: {}
      metadata: {}
      steps:
        - - name: install-chaos-faults
            template: install-chaos-faults
            arguments: {}
        - - name: pod-http-status-code-fje
            template: pod-http-status-code-fje
            arguments: {}
        - - name: cleanup-chaos-resources
            template: cleanup-chaos-resources
            arguments: {}
    - name: install-chaos-faults
      inputs:
        artifacts:
          - name: pod-http-status-code-fje
            path: /tmp/pod-http-status-code-fje.yaml
            raw:
              data: >
                apiVersion: litmuschaos.io/v1alpha1

                description:
                  message: >
                    It injects chaos inside the pod which modifies the status code of the
                    response from the provided application server to desired status code
                    provided by the user and reverts after a specified duration
                kind: ChaosExperiment

                metadata:
                  name: pod-http-status-code
                  labels:
                    name: pod-http-status-code
                    app.kubernetes.io/part-of: litmus
                    app.kubernetes.io/component: chaosexperiment
                    app.kubernetes.io/version: 3.0.0
                spec:
                  definition:
                    scope: Namespaced
                    permissions:
                      - apiGroups:
                          - ""
                        resources:
                          - pods
                        verbs:
                          - create
                          - delete
                          - get
                          - list
                          - patch
                          - update
                          - deletecollection
                      - apiGroups:
                          - ""
                        resources:
                          - events
                        verbs:
                          - create
                          - get
                          - list
                          - patch
                          - update
                      - apiGroups:
                          - ""
                        resources:
                          - configmaps
                        verbs:
                          - get
                          - list
                      - apiGroups:
                          - ""
                        resources:
                          - pods/log
                        verbs:
                          - get
                          - list
                          - delete
                          - watch
                      - apiGroups:
                          - ""
                        resources:
                          - pods/exec
                        verbs:
                          - get
                          - list
                          - delete
                          - create
                      - apiGroups:
                          - apps
                        resources:
                          - deployments
                          - statefulsets
                          - replicasets
                          - daemonsets
                        verbs:
                          - list
                          - get
                      - apiGroups:
                          - apps.openshift.io
                        resources:
                          - deploymentconfigs
                        verbs:
                          - list
                          - get
                      - apiGroups:
                          - ""
                        resources:
                          - replicationcontrollers
                        verbs:
                          - get
                          - list
                      - apiGroups:
                          - argoproj.io
                        resources:
                          - rollouts
                        verbs:
                          - list
                          - get
                      - apiGroups:
                          - batch
                        resources:
                          - jobs
                        verbs:
                          - create
                          - list
                          - get
                          - delete
                          - deletecollection
                      - apiGroups:
                          - litmuschaos.io
                        resources:
                          - chaosengines
                          - chaosexperiments
                          - chaosresults
                        verbs:
                          - create
                          - list
                          - get
                          - patch
                          - update
                          - delete
                    image: litmuschaos/go-runner:3.0.0
                    imagePullPolicy: Always
                    args:
                      - -c
                      - ./experiments -name pod-http-status-code
                    command:
                      - /bin/bash
                    env:
                      - name: TARGET_CONTAINER
                        value: ""
                      - name: LIB_IMAGE
                        value: litmuschaos/go-runner:3.0.0
                      - name: STATUS_CODE
                        value: "500"
                      - name: MODIFY_RESPONSE_BODY
                        value: "true"
                      - name: RESPONSE_BODY
                        value: ""
                      - name: CONTENT_ENCODING
                        value: ""
                      - name: CONTENT_TYPE
                        value: text/plain
                      - name: TARGET_SERVICE_PORT
                        value: "80"
                      - name: TOXICITY
                        value: "100"
                      - name: PROXY_PORT
                        value: "20000"
                      - name: NETWORK_INTERFACE
                        value: eth0
                      - name: TOTAL_CHAOS_DURATION
                        value: "60"
                      - name: RAMP_TIME
                        value: ""
                      - name: DEFAULT_HEALTH_CHECK
                        value: "false"
                      - name: PODS_AFFECTED_PERC
                        value: ""
                      - name: TARGET_PODS
                        value: ""
                      - name: CONTAINER_RUNTIME
                        value: docker
                      - name: SOCKET_PATH
                        value: /var/run/docker.sock
                      - name: NODE_LABEL
                        value: ""
                      - name: SEQUENCE
                        value: serial
                    labels:
                      name: pod-http-status-code
                      app.kubernetes.io/part-of: litmus
                      app.kubernetes.io/component: experiment-job
                      app.kubernetes.io/version: 3.0.0
      outputs: {}
      metadata: {}
      container:
        name: ""
        image: litmuschaos/k8s:2.11.0
        command:
          - sh
          - -c
        args:
          - kubectl apply -f /tmp/ -n {{workflow.parameters.adminModeNamespace}}
            && sleep 30
        resources: {}
    - name: cleanup-chaos-resources
      inputs: {}
      outputs: {}
      metadata: {}
      container:
        name: ""
        image: litmuschaos/k8s:2.11.0
        command:
          - sh
          - -c
        args:
          - kubectl delete chaosengine -l workflow_run_id={{workflow.uid}} -n
            {{workflow.parameters.adminModeNamespace}}
        resources: {}
    - name: pod-http-status-code-fje
      inputs:
        artifacts:
          - name: pod-http-status-code-fje
            path: /tmp/chaosengine-pod-http-status-code-fje.yaml
            raw:
              data: |
                apiVersion: litmuschaos.io/v1alpha1
                kind: ChaosEngine
                metadata:
                  namespace: "{{workflow.parameters.adminModeNamespace}}"
                  labels:
                    workflow_run_id: "{{ workflow.uid }}"
                    workflow_name: httpbin-500
                  annotations:
                    probeRef: '[{"name":"httpbin","mode":"Continuous"}]'
                  generateName: pod-http-status-code-fje
                spec:
                  engineState: active
                  appinfo:
                    appns: default
                    applabel: app=httpbin
                    appkind: deployment
                  chaosServiceAccount: litmus-admin
                  experiments:
                    - name: pod-http-status-code
                      spec:
                        components:
                          env:
                            - name: TARGET_CONTAINER
                              value: ""
                            - name: LIB_IMAGE
                              value: litmuschaos/go-runner:3.0.0
                            - name: STATUS_CODE
                              value: "500"
                            - name: MODIFY_RESPONSE_BODY
                              value: "true"
                            - name: RESPONSE_BODY
                              value: ""
                            - name: CONTENT_ENCODING
                              value: ""
                            - name: CONTENT_TYPE
                              value: text/plain
                            - name: TARGET_SERVICE_PORT
                              value: "80"
                            - name: TOXICITY
                              value: "100"
                            - name: PROXY_PORT
                              value: "20000"
                            - name: NETWORK_INTERFACE
                              value: eth0
                            - name: TOTAL_CHAOS_DURATION
                              value: "60"
                            - name: RAMP_TIME
                              value: ""
                            - name: DEFAULT_HEALTH_CHECK
                              value: "false"
                            - name: PODS_AFFECTED_PERC
                              value: ""
                            - name: TARGET_PODS
                              value: ""
                            - name: CONTAINER_RUNTIME
                              value: docker
                            - name: SOCKET_PATH
                              value: /var/run/docker.sock
                            - name: NODE_LABEL
                              value: ""
                            - name: SEQUENCE
                              value: serial
      outputs: {}
      metadata:
        labels:
          weight: "10"
      container:
        name: ""
        image: docker.io/litmuschaos/litmus-checker:2.11.0
        args:
          - -file=/tmp/chaosengine-pod-http-status-code-fje.yaml
          - -saveName=/tmp/engine-name
        resources: {}
  entrypoint: httpbin-500
  arguments:
    parameters:
      - name: adminModeNamespace
        value: litmus
  serviceAccountName: argo-chaos
  podGC:
    strategy: OnWorkflowCompletion
  securityContext:
    runAsUser: 1000
    runAsNonRoot: true
status: {}

What you expected to happen:
The chaos experiment was supposed to inject a fault where in the service would return 500 during the duration of the fault
Where can this issue be corrected? (optional)

How to reproduce it (as minimally and precisely as possible):

Run the latest minikube
ensure minikube selects the "docker container runtime"
install httpbin from https://raw.githubusercontent.com/istio/istio/master/samples/httpbin/httpbin.yaml in default namepace
create a pod http status fault and point to the httpbin service in default namespace

Anything else we need to know?:

UPDATE: the issue seems to have resolved. I deleted the experiment and published the YAML again and it worked. Closing the issues for now.


Theme Chrome Beta and Dev too

Since chrome already has a themed icon, you guys can link the same icon to Chrome Beta and Dev as well :)
EDIT: Add themed icons for Chrome Beta and Dev as done for Firefox :P

Missing Chrome Canary as well.

Thanks :)


feat: adding darwin arm64 build

replaces https://github.com/axelarnetwork/tofnd/pull/304

looks good from my side. can we add instructions for people who want to build whatever platform we are missing ?

I added a "build " section in the README, should I add more instructions ?


Focus Accessible Buffer terminology and command ID are still present

The terminal now uses the accessible view, so the concept of Accessible Buffer should be removed, but I don't want to break existing command IDs / custom key bindings 🤔.
https://github.com/microsoft/vscode/blob/33876c27f082973adbddc027e0e532c3648099dd/src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibilityHelp.ts#L78-L87
cc @Tyriar

I just realized this was needed to allow for the ctrl/cmd+UpArrow navigation. https://github.com/microsoft/vscode/blob/33876c27f082973adbddc027e0e532c3648099dd/src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts#L221


vendor: update kubernetes to v1.18.0-beta.1

~temporarily rebased on top of https://github.com/containerd/cri/pull/1414 to run CI before that one is merged~ done

That didn't work out well; that's a lot of "red". 😞

okay, that repo just tagged v3.0.0, so I'm gonna slightly diverge from the version that kubernetes uses, which is 5 commits behind; https://github.com/kubernetes-sigs/structured-merge-diff/compare/5e70324e7c1c...v3.0.0

Not out of the woods yet. Was afraid that would happen. Probably should update containerd first;
# github.com/containerd/cri/vendor/k8s.io/apimachinery/pkg/util/intstr
vendor/k8s.io/apimachinery/pkg/util/intstr/generated.pb.go:41:11: undefined: proto.GoGoProtoPackageIsVersion3
# github.com/containerd/cri/vendor/k8s.io/cri-api/pkg/apis/runtime/v1alpha2
vendor/k8s.io/cri-api/pkg/apis/runtime/v1alpha2/api.pb.go:47:11: undefined: "github.com/containerd/cri/vendor/github.com/gogo/protobuf/proto".GoGoProtoPackageIsVersion3
Makefile:87: recipe for target '_output/containerd' failed

Yes, always fun. It's why I make so many jokes about Go projects all of a sudden using "SemVer" because of go modules


fix: tolerate taints on control-plane nodes only (by default)

There are scenarios, albeit few and far between, where the daemonset pod would get scheduled on nodes that were not supported (or intended to deployed to) e.g. Fargate nodes.
This change also allows for complete control of the tolerations set on the daemonset pods (excluding those set by the K8s API itself)

Also, found and applied https://github.com/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/kubeadm/2067-rename-master-label-taint#renaming-the-node-rolekubernetesiomaster-node-taint as recommended by @redhatrises


Upgrade CustomerResourceHandler Nodejs to 18.x version?

I've recently upgraded SST to v2.36.0 to support our Nodejs 18 upgrade. The Lambda functions are now on the correct version but I've noticed that the CustomResourceHandler functions are still on Nodejs 16. I tried setting calling setDefaultFunctionProps with nodejs18.x but that didn't help.
How can I configure these fns to use v18?
-Thanks
"sst": "2.36.0",
"aws-cdk": "2.101.1",
"aws-cdk-lib": "2.101.1",

Can you upgrade to the latest and try? Also if you can share the exact function names?

I had the same problem, upgrade to latest helped. Thanks

I had the same problem.
How I can update it from nodejs 16.x to nodejs 16.x

We are transition this repo to https://github.com/sst/v2 and are closing this issue for now. If it is still relevant please reopen it there - sorry for the trouble


bento: style: better styling for basic table and with pagination on desktop

[x] header with rounded top corners to align with rounded borders theme
[x] chevron icons to the right, smaller and grayed out
[x] hover for table rows

Styling can keep being improved here imo, but good start. Text in the headers seems too big, borders maybe too strong.


serial unexpected data byte

I am trying to use hairless midi serial bridge and I am getting an error: got unexpected data byte 0xa or some such incorrect byte. When I first start sending messages I get this error: +2648.05 - Warning: got a status byte when we were expecting 3 more data bytes, sending possibly incomplete MIDI message 0xff
Do you have any suggestions. I noticed it outputs the string "midi:" is this what it is complaining about. Also I believe MIDI::sendNoteOn(pitch, velocity, channel) is the correct order. Is the package sending channel, pitch, velocity. There is a description of a fix in this link Control Change command "Unexpected data byte". thanks I look forward to getting it working over usb.

See #4


tests: remove spurious dependencies to ImporterTest

Another small test change that's in the way of Maven modularization.

No, that's a cherry-picking error on my side.


../config/default.yaml error Ask Question

I am trying to train the model through the google cloud but I getting the same error :
File "__main__.py", line 329, in <module>     main()   File "__main__.py", line 126, in main     with open('../config/default.yaml') as f: FileNotFoundError: [Errno 2] No such file or directory: '../config/default.yaml' tjinpa2019@cloudshell:~/EMSE-DeepCom/source code (bamboo-truck-281120)$
Could you kindly help me in this as I am stuck with the  problem for sometime now.

I think you can create directory "config" and put the file "default.yaml" into it. The default.yaml can be downloaded from this repo.


Cleanup ZUGFeRDExporter after merge errors

As a followup of #18: There were a couple of merge conflicts and the resolution of those were not quite complete. This PR fixes what went wrong during the merge.
This is in summary:

The enum PDFAConformanceLevel was contained twice in the codebase in different packages. This PR deletes the one in package model.
A lot of code was originally moved from the class ZUGFeRDExporter to the new class ZUGFeRDExporterFromA1Factory. While the new class survived the merge, the code is now duplicated in both the new class and the old ZUGFeRDExporter. This class removes the moved code from ZUGFeRDExporter in a backward compatible way and marks the old code as deprecated
The unit tests are now also adapted, so that they do not use the deprecated methods anymore.
As a follow-up to #16 the unit tests now also close the exporter.

I just rebased this PR on master (and resolved a conflict with PR #26 in the process)


Limit triangle count for optimized/output skinned meshes with shapekeys

As in title. Merging skinned meshes is good as long as you don't end up with high-poly ones with shapekeys on them.

By default the optimizer doesn't merge meshes that use shape keys with ones that don't.
There is an option to merge regardless which is useful for small avatars, but its off by default.


Add PHP 8.4 compliance for v4

 ------ -----------------------------------------------------------------
  Line   lib/Service.php
 ------ -----------------------------------------------------------------
  125    Parameter #1 $source of method XMLReader::XML() expects string,
         resource|string given.
  169    Parameter #1 $source of method XMLReader::XML() expects string,
         resource|string given.
 ------ -----------------------------------------------------------------

Hmmm - phpstan is complaining about this. It did not complain in the older 2.2 and v3 branches. I will check what the code looks like there.

I raised an issue with phpstan https://github.com/phpstan/phpstan/issues/11634
See the comments there. Actually the problem is in our code.
https://www.php.net/manual/en/function.is-resource.php
Note:
is_resource() is not a strict type-checking method: it will return false if value is a resource variable that has been closed.
When we use is_resource() that actually does "is open resource". The variable could still be a resource, but closed.
https://www.php.net/manual/en/function.stream-get-contents.php
If we call stream_get_contents with a closed resource, the worst that happens is that it returns false and when we cast false to string, that gives the empty string. And there is already exception handling for that.
So it is better, and we can safely, use if (!is_string($input))


How to set form into Angular view

Hi,
Before all, many thanks for your work. It's really imperssive !
I have a project using aspboilerplate (EF and AngularJs). I download your sample and I see that the authentification form is in an MVC view.
I try to implements a registration form and authentification form into angularJs.
Do you plan to implements this kind of feature in your project ?
Do you have any advice where I can look for to achieve this ?
Best regards,
Jérôme

Hi,
Thank you.
There is no restriction here, you can create a new angular controller&view for that. But I advice to not include it to the main application. Create a new angular layout and module for that.
But, actually I suggest to not do that, no need it since login and registration pages are very simple and can be remain as MVC.


OAK-11159: RDBDocumentStoreJDBCTest: improve diagnostics

Sree https://github.com/apache/jackrabbit-oak/pull/1749


Authorization Code Flow, Redirect URI HTTP method

I'm trying to use a code flow in a native iOS app through the custom URL schemes as redirect_uri (i.e. myapp://success). The issue is that IdentityServer is using a 302 POST instead of GET and that doesn't sit well with Safari on iOS.
Is there any way to configure the http method used for the redirect?

Is it native iOS - see here:
https://github.com/openid/AppAuth-iOS
or C#
https://github.com/IdentityModel/IdentityModel.OidcClient.Samples/tree/master/iOSClient

My question is how IdentityServer chooses the HTTP method to use for a redirect, because when Safari (at lease in iOS 10) doesn't allow a POST on a custom url scheme.

it's controlled by the response_mode parameter.  Different grant types allows for different response modes.
What's your grant type?

facepalm I completely missed it
response_mode=form_post, thank you for the support!


[18.09 backport] Ignore default address-pools on API < 1.39

These options were added in API 1.39, so should be ignored when using an older version of the API.
relates to https://github.com/moby/moby/pull/37558
backport of https://github.com/moby/moby/pull/38196 for 18.09
git checkout -b 18.09_backport_fence_default_addr_pools ce-engine/18.09
git cherry-pick -s -S -x 7632ccbc66c82179547b96524672bd5082ae7481
git push -u origin

cherry-pick was clean; no conflicts

pushed again to trigger CI


Add window and window assigner

Signed-off-by: Chen Dai<EMAIL_ADDRESS>Description
Add window and window assigner interface along with tumbling and sliding window assigner implementation.
Issues Resolved
https://github.com/opensearch-project/sql/issues/951
Check List

[x] New functionality includes testing.

[x] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[x] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #950 (b2c51c4) into feature/maximus-m1 (3a9d217) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                  Coverage Diff                  @@
##             feature/maximus-m1     #950   +/-   ##
=====================================================
  Coverage                 97.95%   97.95%
- Complexity                 3143     3145    +2
=====================================================
  Files                       300      302    +2
  Lines                      7784     7787    +3
  Branches                    500      500
=====================================================
+ Hits                       7625     7628    +3
  Misses                      158      158
  Partials                      1        1

Flag
Coverage Δ

sql-engine
97.95% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...search/sql/planner/streaming/windowing/Window.java
100.00% <100.00%> (ø)

...ing/windowing/assigner/TumblingWindowAssigner.java
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


PowerPC wheels through manylinux

Hi,
I noticed in this comment that ppc builds for releases were being considered but they do not appear to have been a part of the 5.5.0 release.  Would it be possible to enable these?  I would be happy to contribute a PR that modifies the GH actions script to only run the ppc manylinux image when the wip option is false.
Thanks!

I am always a bit struggling with actions because I am not too deep into them. You don't need to open a PR but a suggestion where/how to to put the check would be nice. Meanwhile, I'll build the ppc wheels. I wouldn't have thought that anyone is using clingo on the architecture.

Something changed and now installing the prerequisites to build clingo takes about 2 hours. It looks like it compiles cmake from source now. In total the ppc builds will most likely take more than 10 hours to build like this. We might hit limits with github's actions here...

In my auxiliary repository I just remove CMake from the requirements because I know that it's available on the Manylinux images:
https://github.com/joshessman-llnl/package-clingo-manylinux/blob/c3276bba73322f710b812745db4b91c3179e6833/adjust_name.patch#L7-L8
With that change the builds take about 2.5 hours in total, which is still a long time, but infrequent enough that it's not an issue.
There may also be a way to have the build system pick up the system-installed CMake, which would be preferable.

I think I somehow have to patch this into the build script because the deploy just failed because there is a 360 minutes limit. I want to keep the cmake dependency for the source releases though.

The PPC wheels are online now. I had a look at how to conditionally include/exclude elements in a matrix but all the solutions I saw where quite complicated. I would take your offer of a PR. :smile:

I als


Collection of fixes for the last sprint

This is a collection of fixes. Each commit is fairly simple and does one thing.
Most commits are trivial, however:

There's a refactoring for Merkle paths code to reduce allocations
There's a bug fix for deserialization
There's a removal of pure on serialization function (as @TrustHenry needs it)
There's a small reorganization of the code to better isolate getGenesis*

Small fix: Changed the bsf == bsr comparison.

Fixed the assert


Unclear README.me instructions

I am trying to install Winery.
Presentation problems with the README:

"There was no security of Eclipse Winey."
is rendered at ->  is available at
It does not say that you have to clone it first and cd into the folder
"You can also use the pre-built image and bin it to a local repository:" this sentence is not clear. Why should one want to do this.
Section "Next steps": this part is not getting started. Put it in the Issues?
Now that it's running what shoudl I do? Plese include a minimal
getting started.

Some errors during installation:
[INFO]
[INFO] --- frontend-maven-plugin:1.6:npm (build tosca-management) @
org.eclipse.winery.frontends ---
[INFO] Running 'npm run build-tosca-management-prod' in
/tmp/winery/org.eclipse.winery.frontends
[INFO]
[INFO] ><EMAIL_ADDRESS>build-tosca-management-prod
/tmp/winery/org.eclipse.winery.frontends
[INFO] > ng build tosca-management --prod
[INFO]
[ERROR] Browserslist: caniuse-lite is outdated. Please run next
command npm update
[INFO] Linting "tosca-management"...
[ERROR] Warning: member-ordering - Got empty options
[INFO] Linting "topologymodeler"...
[ERROR] Warning: member-ordering - Got empty options
[INFO]
[ERROR] Browserslist: caniuse-lite is outdated. Please run next
command npm update

Don't worry, these entries don't show build errors. The build only determines some npm build stuff as error logs.

At the moment we cannot update the README at https://github.com/radon-h2020/radon-gmt as the project/radon branch is currently processed by the Eclipse team to merge it into master. In the meantime, please refer to the official README at https://github.com/eclipse/winery.

RADON-related changes have been merged into the Eclipse Winery's master branch. Updated the README and redirect respectively to the docs on read-the-docs.


fix(wmg): 2272 FE Polish

Reviewers
Functional:
@hthomas-czi
Readability:

Changes

Tooltip labels should be fontWeight: 400 and values should be foregroundColor: .secondary
Less spacing between sections in the tooltip
Add question mark icon next to Scaled, on hover add definition: "Expression is scaled to the range [0,1]. Scaling is done by assigning the minimum value in the current view to 0 and the max is assigned to 1." <--- ⚠ NOTE: Instead of question mark, I use info circle, since that's the closest available in SDS. Hopefully that's okay!

Definition of Done (from ticket)
QA steps (optional)
Known Issues

Looks good to me!
It'd be great if we could increase the width of the tooltip so the Expressed in Cells line doesn't wrap, but no problem if that's not easy to do.

Ahh yeah great idea! Let me increase the max width and play with it a little!

@hthomas-czi just updated the max table width to be 500px, is that enough or should we make it even larger?
Thank you!

Thanks @tihuan! It looks good to me.

Awesome thanks, Harley! MERGINGG


feat(ci): add paths configuration to GitHub Actions for charts structure

Description
This Pull Request introduces an update to the GitHub Actions workflow to align with the current chart structure.
Key Changes:

Added path configurations in the CI workflow to ensure correct paths for both the main chart.
Updated Helm dependencies using helm dependency update to ensure all charts are up to date.
Maintained the automation for chart releases and publishing to GitHub Pages.

Why this change is necessary:
This update is required due to the specific chart structure of the repository. The previous configuration didn't account for the custom path locations of the charts, which could lead to issues during the CI/CD process. By adjusting the paths, we ensure that all charts are correctly linted, packaged, and published.
Checklist:

[x] Added path corrections for Helm charts.
[x] Verified that helm lint runs successfully for all charts.
[x] Tested the release process with the new path configurations.

This issue will also close both PRs:
https://github.com/getlago/lago-helm-charts/pull/55
https://github.com/getlago/lago-helm-charts/pull/16/files
Unfortunately, we are unable to implement such significant changes as proposed in these two PRs at this time. Some of our users rely on pulling the Git repository directly to deploy Lago, and we want to avoid introducing breaking changes for now. We truly appreciate your initiatives, gilliangoud and grafjo. 🙏


Some accounts and passphrase do not match.

Hi,
After formatting my computer, I reinstalled chrome and imported my exported keys. But I keep getting the error "Some accounts and passphrase do not match", even when using the correct password.
Sometimes I dont get the error and some keys show as Encrypted and other as blue dots.

I just installed and having the same issue on one of my computers. Any suggestions? Is there something subtle I may have done to cause this?

I investigated some more.  In Chrome I am using 2 different people so I can keep my work and personal bookmarks/extensions/history etc. separate.
In Chrome's settings, I see I am signed into Google with my work email and the "People" section shows I am using my work identity. And in another Chrome window I see I am signed in with my personal email and the the People section shows I am using my 'personal' identity.
To simplify, I will call person 1: personal and person 2: work.   I noticed that the data is stored with chrome.storage.sync.  And I noticed that the password I used for work successfully decrypts the personal user's values even though I initially chose a different password for the user personal.  So somehow it seems to be using the password I set for my work as my personal. But that doesn't seem right... first it doesn't seem right because I can't imagine Google Chrome would mix the settings... But also because I see a different list of accounts in Authenticator for each of the people I am using...
Maybe some of these findings will help debug the problem?

@darcyparker Hi, Darcy, thank you for your feedback, I'll check the code and locate the problem.

@darcyparker Authenticator was designed without considering working with more than one account on the same computer, and the password stored in LocalStorage has covered the one of the current account. I'm sorry about this. To fix this problem temporarily before a new version is available, please set a new password(or just type in the same password again) without checking Remeber Passphrase, and the extension will ask you for the password when you launch the browser first time. Please notice, though you unchecked Remeber Passphrase, Authenticator will still store your password in Cookies when you launch the browser first time so that you needn't enter password every time until you close or relaunch the browser. So, please remember to relaunch your browser after switching account to make the password stored in Cookies removed.

@Sneezry - thanks. That sounds like a a good workaround for now.  I look forward to a future fix.
This is probably obvious... but I am assuming @rodamora is using multiple accounts on the same login of a computer too. If not, then these may be different but similar sounding issues.

I am having the same issue.  Not sure what to do.  Please advise.  I opened Chrome & clicked on icon.  It asked for passphrase, which I entered (I had not changed it), then got the message indicated in header above.

+1 I also have this issue now. I removed all additional user accounts but still getting the error message. Oddly, just a second ago, I ran into the same issue in another OS install I have (Ubuntu) but was able to get past it by copy/pasting the password into the field again with no further changes (?!?).
Can't get past it on my Windows machine though.
I've never seen this on Mac.


Cancel pending build

A user could have added an image by mistake or entered the wrong ref.
There should be a "Cancel" button that would stop the repo2docker container currently building the image.

I believe, this more a "nice to have" feature than a "must have" one.
If a user add an image with the wrong reference, he can wait for the image to be built and than remove it. As a matter of fact, I'm a bit afraid to intervene to much with the repo2docker container...

Good. For now the interface doesn't have any button for the pending builds, so we could leave it like this.

As a matter of fact, I'm a bit afraid to intervene to much with the repo2docker container...

That would need require finding the right repo2docker container and stop it.

That would indeed require finding the right repo2docker container and stop it.

OK so let's close this then.
We can reconsider later if needed.


curl interceptor

rely on https://gist.github.com/terrakok/8e435c1473da4c21e1f4299a21e5e6e9

Great job @doyaaaaaken ! Changes are included in 0.11.0 milestone


Generalize the client?

Going by the examples, it looks like this might be great as a general graphql client that should be able to query any graphql server. Maybe a command line tool can be provided to run an introspection query against a graphql server to generate the appropriate types as well.

Yes, in the long term, absolutely.
As I wrote in https://github.com/google/go-github/issues/646:

It's very likely the end result package can be entirely generated. The GraphQL schema is entirely introspectable and very structured, and strongly typed. See https://developer.github.com/v4/guides/intro-to-graphql/#discovering-the-graphql-api. Aside from prototyping an initial version, there's really no need to write/maintain the entire package manually.

Nothing about this is GitHub specific. It's GraphQL specific. A good solution to this will likely apply to any other GraphQL API.

Once development is closer to completed, and this package is more stable and mature, I think I'll see about factoring out the common GraphQL-specific aspects and the generator into a separate component.
githubql itself will be 100% specified to GitHub's GraphQL schema, but you will be able to easily create/generate similar Go client libraries for other GraphQL schemas.
It's likely the only parameters the client generator will need is the URL of a GraphQL endpoint (for introspection) and the name.

Another request I have (once the package is generalized), is to make the transport pluggable. For example, I am currently using graphql over grpc. So, it would be nice if the package comes with a default HTTP transport, but provides an interface so that we can implement other types of transports.

NewClient already takes an *http.Client parameter. If you leave it as nil, then http.DefaultClient is used, otherwise the custom HTTP client. A custom transport can be provided as part of a custom *http.Client, see http.Client.Transport.
Is that what you're asking for, or are you referring to something else?

In terms of GRPC, we do not use the http.Client directly although GRPC is built on top of HTTP/2. It is wrapped by the GRPC client which provides more features on top of http.Client. Therefore, I can't pass a http.Client to NewClient if I want to use GRPC as my transport.
Here's a pretty good example of a generated GRPC client being used: https://github.com/grpc/grpc-go/blob/master/examples/helloworld/greeter_client/main.go

I see. That NewGreeterClient func takes a *grpc.ClientConn.
I'm not quite sure how to deal with this, but I want to support it if possible. Mind opening a new issue where we can track and discuss it in more detail?

This issue has been resolved by https://github.com/shurcooL/graphql/commit/6ac8ee219c8da29544f2659097d7d709d6420afe.


How to speed up the API development cycle?

Note: If your question is regarding the AWS Amplify Console service, please log it in the
official AWS Amplify Console forum

Which Category is your question related to?
I'm loving Amplify initially but when trying to actually "get stuff done" for real I'm finding myself slowed down by the current development cycle. I wondered if I'm missing something to help streamline that, something that is skipped over in the "how to get started" docs that could make changes quicker?
Amplify CLI Version
You can use amplify -v to check the amplify cli version on your system
4.29.4
What AWS Services are you utilizing?
API
Provide additional details e.g. code snippets
Making any change to my schema requires me to do a "amplify push" which requires waiting and saying "yes" to three questions (which I always answer yes too...so that seems a little defunct). This often takes 5-10 minutes to complete and I have to do this everything I need to make a change. As a result the development cycle is complete blown to bits with a lot of waiting going on.
Is there any way to speed this up? Is there a way it can only scan for changes or assume that my local setup is still the master so skip the checking it seems to do on live? Am I missing something?
If there is no way to speed it up currently then can I make the request that its looked into as currently its a killer for productivity.

Have you looked at local mocking: https://docs.amplify.aws/cli/usage/mock#local-mocking

I have, trouble is I was trying to do a data import at the time (via a function see #5553) so needed to have the schema in the cloud up to date as I found issues with it. A 7-10 minute push time is typical which means 6 changes an hour max :(

@PeteDuncanson You can use "amplify push --yes" to avoid answering yes to all the questions in the CLI each time. As @undefobj mentioned using "amplify mock" is a great way to speed up the feedback loop for your API development. Could you explain in more detail why you weren't able to use mock?

Running the mock and realising that it would re-compile the schema every time I made a change seemed helped a lot. It stopped me making silly errors/typos and catching them early. I was previously only seeing errors when I pushed and then the error messages where very vague which made debugging frustrating.
Some ideas for improvements on that could be:

Pushing will fail if the schema is invalid but it doesn't fail fast, could the schema validation be done sooner?
If the schema validation fails then maybe include a hint about "it can be easier to debug schema errors by running amplify mock api and visiting http://localhost:20002" to make that more discoverable?

The --yes or -y suggestion does wonders, thank you for that pointer 😃
My main grumble though was at the slowness of a push in general. If I add one field to my API it can still take 5+ minutes for it to churn through to get it live and I wondered if that could be optimised any to make it faster? I'll explain my use case some more at the time of opening this so maybe you can understand my frustration. I fear that this will all just come down to me having to do a bit more thinking/planning before I go coding but here is what I was doing.
When I opened this issue I was trying to run a data import via a Lambda triggered by a S3 upload. While doing it though I was finding additional fields that I needed or could inject in, ones that needed more cleaning before import or was having ideas on the fly while working with the data so was sort of doing some quick on the fly refactoring. But as the code I wanted to run was in the cloud as a Lambda Function I needed it to talk to the GraphQL that was also in the cloud. If I needed to add a new field to my schema I needed to do a push and wait. So my cycle of editing the schema, pushing, re-running my import script was taking a long time which leads to all the usual problems of getting distracted or just burning time. I could have mocked the api and the function in theory but the debugging experience for mocked functions simply doesn't work as I've raised here #5553 so the only way to get feedback (even catching a simply typo) when developing currently is to do it in the cloud.
I know nothing of what that push is doing under the hood but I do see all the log info that scrolls up my page, some many things seem to be touched to add a String field to a existing entity. It seems a bit wasteful and brute force. I guess my query is, is there a better way that push could do its magic so that it goes quicker? Like I said above if it could fail fast that would be great, if it could just push up the change that would be great too and faster. I get that there might be issues if whats in the cloud has been touched by someone else and that is maybe why it has to do all the work is seems to do but what if I could have a setting that says "I'm the only want developing this, just deploy the diff" or something that could cut down on that push time if I've opted in and know what I'm doing?
Some of my feedback here might be better as separate issues but I wanted to give you some context in one place.
Hope that helps and if I can add anything more let me know.

@PeteDuncanson Yeah, I get your pain. We introduced "mock" for the exact same reason and pain points that you've mentioned above. I'll ask the team to look at #5553 which looks like a bug in mocking functions - so that you don't have to push each of your changes to the cloud to test changes.

Can I sanity check my App to see if I'm stretching Amplify too much or something, I'm still having push times take 5+ minutes sometimes 10+ which is just a dev flow killer.
Even Nader Dabit said it shouldn't be taking this long: https://twitter.com/dabit3/status/1336672727806205953
Which makes me thing am I doing something wrong or is there something else that could be done?
Its all Amplify out of the box stuff, I've got 15 models in my GraphQL schema, they have relations between then, searchable is enabled on three of them, auth via Google, storage and some Lambda's for importing data. Thats it really. Why would this take so long to push up?
Could it be a location thing? I'm signed up to eu-west-1 so I'm assuming all my stuff gets pushed up to there or does it go up to USA somewhere first or something? All the demo apps with 3 models for a blog work a treat and nice and speedy but is this a false promise, is this now just the way it is when you start putting something bigger in there?
related: https://github.com/aws-amplify/amplify-cli/issues/5964

@PeteDuncanson The push times is dependent on the CloudFormation deploy times and it might take between 5-10 mins depending on the number of models and the number of resources being pushed.

@kaustavghosh06 well I guess that just is the way it is then. Thanks for getting back so I can manage my expectations.
Also thanks for getting #5553 looked at (and fixed).
Any chance you can do the same with #5981 which is also hindering mocking? :)
Also as mentioned in #5964 is there anyway you can limit what gets pushed up to speed up a push? It seems that it almost seem to redeploy everything all over again every push rather than what has changed?
With that I'll close this one as now I know that it is what it is, anything you can do to speed it up would be great though as like I said its a developer flow killer as it stands!

@kaustavghosh06 sorry to raise this here but I've noticed that since the last release of the CLI (v4.42) that pushing seems to be push quicker. Have you folks done any magic?


Fix filter_vcf_cle.cwl for CLE VCF filtration in the immuno CWL pipeline

I am working for testing the latest immuno workflow, by discussing with John and Jasreet.
The filter_vcf_cle step (tools/filter_vcf_cle.cwl) in subworkflows/filter_vcf.cwl was implemented to filter out any somatic variants that haven't been validated by the CLE somatic pipeline. For example, this step is required for some clinical cases when we make a pVACseq analysis using the immuno CWL pipeline. However, the current filter_vcf_cle.cwl doesn't work, ending up with writing the same output VCF as the input VCF.
Below, I have created a new PR to suggesting fixing this issue.
Fix filter_vcf_cle.cwl for CLE VCF filtration in the immuno CWL pipeline
#980

I closed the previous PR (#980) without merging, as Feiyu made that "filter_vcf_cle" step for CLE. John, Jasreet, and I discussed a plan to fix this issue, and we are going to create a new step in the immuno workflow as Feiyu suggests. I will update this.

This issue is now moved to a new PR, "Limit pvacseq input to passing cle and pipeline variants" #988.

This issue is now moved to a new PR, "Limit pvacseq input to passing cle and pipeline variants" #988.


Update floatlabels.min.js

What did you update?

Just regenerated floatlabels.min.js, the old version didn't work for me.


1.19.3-pre3

Added back KronHUD, DarkKore, LambDynamicLights, Puzzle
Updated Fabric API to latest

Pull request was made instead to give some times till next pre-release day.

Some errors were found when launching the game, related to indium. The modpack might be delayed if it is not fixed.
https://mclo.gs/45kOFeA

UPDATE: Found a cause of this issue. The DarkKore is still NOT ready for 1.19.3, so patience is the key.


Algolia DocSearchPage doesn't inherit searchParameters

🐛 Bug Report
The search parameters e.g. facets passed into searchParameters are used for the SearchBar, but don't carry over to the DocSearchPage.
Have you read the Contributing Guidelines on issues?
Yes
To Reproduce
If possible, use https://new.docusaurus.io to create a CodeSandbox reproducible demo of the bug.

Add a facet to searchParameters to algolia in docusaurus config'
Search in Search Bar
Click view all
See filter is not run on the search page

Expected behavior

any searchParameters specified in the config would carry over to the DocSearchPage
Actual Behavior

No searchParameters were used on the DocSearchPage
Your Environment

Public source code/URL https://codesandbox.io/s/magical-mclaren-byg9e?file=/docusaurus.config.js
Docusaurus version used: 70

Reproducible Demo
If possible, use https://new.docusaurus.io to create a CodeSandbox reproducible demo of the bug.
https://codesandbox.io/s/magical-mclaren-byg9e?file=/docusaurus.config.js

Yes you are right
Duplicate of https://github.com/facebook/docusaurus/issues/3805


statistics calculator (js beta) - step 54 Math.pow code check too strict

Describe the Issue
I think I ran into a bug in one of the statistics calculator project steps.
Basically, they're trying to get us to write a Math.pow call but the step doesn't accept the following code:
 const standardDeviation = Math.pow(variance, 0.5);

But it does accept this instead:
 const standardDeviation = Math.pow(variance, 1/2);

It is funny because the example in the step literally shows 0.5 being used (if via a variable).
Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-advanced-array-methods-by-building-a-statistics-calculator/step-54
Your code
 const standardDeviation = Math.pow(variance, 0.5);

Expected behavior
The step should accept any variable of 1/2 as the 2nd param of Math.pow (.5, 0.5 seem like valid variations of 1/2)
Screenshots
No response
System
N/A
Additional context
No response

Isn’t 0.5 the exact same as 1/2?
Also the instructions do not place backticks around the 1/2 so it is not clear at all that they actually meant that we should type exactly that? (Usually steps surround text that needs to be typed exactly in backticks which was not done here)
also, the example literally uses 0.5!!!
Please reopen for further discussion given all the above.
Thank you.

That's true. Sorry for the shortsightedness, we can update the example to 1/2?

Sure or simply accept both.

Lets do both then!


libgudev: add recipe for 234

Checklist

[ ] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
[ ] License file is packaged (see here for an example)
[ ] Source is from official source
[ ] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
[ ] If static libraries are linked in, the license of the static library is packaged.
[ ] Build number is 0
[ ] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
[ ] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

https://github.com/msys2/MSYS2-packages/issues/2171 😿


fix: update readme for kpf-profile-controller [skip ci]

This PR updates the README for the Kubeflow Pipelines Profile controller.

Good catch, thanks @welpaolo!


Update exported example ruleset files.

Exported all of the built-in rulesets to files to refresh the examples directory.
@TheGrayAlien: What should we do with the Revolutions ruleset JSON file?  It won't load in its current condition, and not sure what the intended fix is.

There shouldn't be a Revolutions JSON in the HouseRules build. You might have done leftovers from installing my Revolutions rebuild.