Support Drupal's preview mode

The routes are currently hard-coded in the HTMLRenderer:
https://github.com/chapter-three/next-drupal/blob/691a4b8bcf747b13e908c3dc4423ff168128d430/modules/next/src/Render/MainContent/HtmlRenderer.php#L98-L103
We should be able to make it configurable (hook? Settings form?) to be able to add preview URLs.
The previews can be made available in the API with the help of the module https://www.drupal.org/project/jsonapi_node_preview.

Yep. I had to edit this directly for this demo: https://twitter.com/shadcn/status/1491853030396141568
This could be handled in the NextPreviewer plugin or per entity type to be more flexible.
Let's see.

+1 for configurable per entity type.

We've been able to make the Drupal preview work on our project, but for that we had to do some important changes in the way the module works.
The main change is that we don't use the slug anymore for preview (either for revisions, or for the view of the node), but instead the URL for Next's preview mode contains the Entity type, the Entity bundle and the UUID.
HtmlRenderer
We've replaced the HtmlRenderer to add the "entity.$entity_type_id.preview" route.
Iframe
We made a custom iFrame plugin that provides the uuid, entityType and entityBundle.
We only provide the slug when the entity exists: if it's a new entity (example: click on the preview button during creation of the entity, before first save), the toUrl() return an error since the entity doesn't have an ID. The simple version:
    if (!$entity->isNew()) {
      $entityPath = '/' . $entity->toUrl()->getInternalPath();
      $query['slug'] = $this->pathAliasManager->getAliasByPath($entityPath, $entity->language()->getId());
    }

For that we had to entirely replace the way the URL is generated, and we currently don't use the NextSite::getPreviewUrlForEntity method anymore.
A preview parameter is added to the NextJS URL to specify that the API endpoint is not the same one (it's not /jsonapi/node/page/{uuid}, it's /jsonapi/node/page/{uuid}/preview, and is calculated this way:
$isPreview = $this->routeMatch->getRouteName() === 'entity.' . $entity->getEntityTypeId() . '.preview';
@shadcn all those changes have been reported on NextJS's side too. Do you think some of those changes, or at least the flexibility required, can be added to the module? Would you accept such a pull request, or do you think the logic above has to be adapted?

@Elendev This looks similar to the changes I had to do to make the POC work (regarding the handling of slug for the entity).

all the changes below have been reported on NextJS's side too

Can you link me to the issue please?
If you would like to work on this, I'd be happy to review and collab. Let's open a PR and hash out a way forward.
Appreciate all the help you're putting into making the project better.
Thank you

Can you link me to the issue please?

@shadcn sorry I haven't been clear, we have reported those changes on our NextJS by bypassing the existing package. I'll see with my colleague if it's easy to re-integrate in the base module.
In the meantime, I'll find time to propose some PR with improvements to allow more flexibility, and in the end be able to include the preview capability directly in the module 👍

In Acquia CMS we want two modes of headless operation:

pure headless where Drupal's node view capabilities are disabled
hybrid mode where Drupal can continue to render content.

When next.js site preview is enabled, it doesn't work in pure headless mode because Drupal is no longer using the HtmlRenderer to render the Drupal view. It also doesn't work in hybrid mode because it overtakes the render Drupal should be rendering.
Instead we've implemented site preview as a local task to a node and rendered it inside its own tab. This at least makes it work in pure headless mode but we'd need to be able to turn the HtmlRenderer off in hybrid mode to create an operable experience.
Happy to contribute our changes to this project rather than manage them ourselves if they make sense for this project.

@fiasco I see. This has been discussed here: #217
Let's hash this out on the other issue?
(This issue here is for adding support for https://www.drupal.org/project/jsonapi_node_preview)
Thanks

Graphql Compose is adding support for previews and Revisions https://drupal-graphql-compose.github.io/documentation/#/features/previews-revisions so would be good to make it compatible with that too.


fix(data-table): last table row no bottom border

closed #4216

Codecov Report
Base: 62.52% // Head: 62.52% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (ba14078) compared to base (9eab076).
Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head ba14078 differs from pull request most recent head b4f01b9. Consider uploading reports for the commit b4f01b9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4279   +/-   ##
=======================================
  Coverage   62.52%   62.52%
=======================================
  Files        1069     1069
  Lines       22420    22425    +5
  Branches     5882     5884    +2
=======================================
+ Hits        14017    14022    +5
  Misses       6880     6880
  Partials     1523     1523

Impacted Files
Coverage Δ

src/_internal/scrollbar/src/Scrollbar.tsx
40.28% <ø> (ø)

src/data-table/src/TableParts/Body.tsx
61.00% <100.00%> (+0.66%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


ig-text-editor is unaware the auto-fill happened and thus it does not send updates to the model

Description
ig-text-editor is unaware the auto-fill happened and thus it does not send updates to the model.
Steps to reproduce

Unzip the attached my-app3.zip, "npm install" and "npm start".
Open IE11 or Firefox and enable its autofill functionality to store user name and password in forms.
Open http://localhost:4200, type "aaa" in "User Name" and "bbb" in "Password" and click "Login".
You'll see a prompt window which asks you whether or not you would like to store the user name and the password. Answer "Yes" to it.
Click twice on "User Name" text box. You'll see a drop down open.
Select "aaa" from the drop down. You'll see "Password" text box is automatically filled.
Click "Login".

Result
In the developer tool console, you'll see "Login: [aaa][null]".
This means that the property bound to the password ig-text-editor is null although the text box is filled in UI.
Expected result
In the developer tool console, you'll see "Login: [aaa][bbb]".
The property bound to the password ig-text-editor has the auto-filled value.
Attachments
my-app3.zip

Related to https://github.com/IgniteUI/ignite-ui/issues/1776

IgniteUI/ignite-ui#1776 is resolving the issue


How to avoid intermediary values when combine uses the same input sources twice?

Is it possible to avoid glitches with synchronous receiving data from a few sources?
import w from 'wonka'

const log = []
const s = w.makeSubject()
w.pipe(
  w.combine(s.source, s.source),
  w.subscribe(v => log.push(v)),
)

s.next(0)
s.next(1)

console.assert(
  JSON.stringify(log) === JSON.stringify([ [0, 0], [1, 1] ]) // false
)

In example above the log will be  [[0,0],[1,0],[1,1]], where [1,0] is redundant data (glitch)

that isn't a glitch. combine gives you the combined data on each update, meaning that if you combine two sources that fire at the same time, it'll yield two events, since combined tupel outputs contain each update. So to avoid this you have multiple options, depending on your use-case and exact sources. But for instance for the small example you've posted this works:
pipe(
  combine(subject.source, subject.source),
  sample(subject.source),
  subscribe(console.log),
)

And this works because the sample operator takes the latest value it sees and only emits it when the source it receives emits. Since the subject will only be emitting once and the sample operator is processed after combine this discards the intermediate tupel.

that isn't a glitch. combine gives you the combined data on each update, meaning that if you combine two sources that fire at the same time, it'll yield two events, since combined tupel outputs contain each update. So to avoid this you have multiple options, depending on your use-case and exact sources. But for instance for the small example you've posted this works:
pipe(
  combine(subject.source, subject.source),
  sample(subject.source),
  subscribe(console.log),
)

And this works because the sample operator takes the latest value it sees and only emits it when the source it receives emits. Since the subject will only be emitting once and the sample operator is processed after combine this discards the intermediate tupel.

@kitten thx for so fast feedback (wow! =D)
It is a good local (manual) solution, but I want to find automatically solution, how do you think, it is possible with wonka? Typically it solved by topological sorting, but there are other options.

@kitten thx for so fast feedback (wow! =D)
It is a good local (manual) solution, but I want to find automatically solution, how do you think, it is possible with wonka? Typically it solved by topological sorting, but there are other options.

I'm not sure what you mean by automatic? Schedulers on sources like these are basically just output-bound, so if we suppose that each event has a certain timing after each source a scheduler alters when and how an event is issued.
In Wonka all events are issued synchronously which has a lot of benefits in terms of predictability. In never ended up adding operators that apply back pressure in more interesting ways or schedules events in more complex ways, but generally the operators around back pressure that do exist are debounce, throttle, and buffer. A good example of scheduling alterations is delay.
But ultimately none of this would never be automatic or implicit, since scheduling always includes an intent to process events differently. That being said, the highly synchronous nature of sources in Wonka is intentional and the most predictable manner in which events are issued and processed.

I'm not sure what you mean by automatic? Schedulers on sources like these are basically just output-bound, so if we suppose that each event has a certain timing after each source a scheduler alters when and how an event is issued.
In Wonka all events are issued synchronously which has a lot of benefits in terms of predictability. In never ended up adding operators that apply back pressure in more interesting ways or schedules events in more complex ways, but generally the operators around back pressure that do exist are debounce, throttle, and buffer. A good example of scheduling alterations is delay.
But ultimately none of this would never be automatic or implicit, since scheduling always includes an intent to process events differently. That being said, the highly synchronous nature of sources in Wonka is intentional and the most predictable manner in which events are issued and processed.

Here I make a demo with a performance comparison of wonka, effector, reatom: https://runkit.com/artalar/5ffc6163d282b40013440110
To avoid glitches:

Effector internally uses a graph traversal algorithm (it mostly work when links are created).
Reatom uses a pull approach and some variations of memoization (it works at every update).
Wonka uses sample (it works at every update, as I understand).

I don't why, but Wonka is 2-3 times slower. Have you interested in why?
I try to replace locally w_combine (with sample) by native combine and get execution median from 2-3 times to ~1.2 times bigger than Effector and Reatom (which is steel looks a lot, but better than earlier) and result value (wRes) is 7 times bigger, that show to us a possible glitchs impact. It is ok by the perf test because wD, wF, wG, wH, mapper functions are simple and make low-cost computation, so we may rerun it a few times without perf overhead, but as we don't know how heavy is a mapper function in some user code the case of this discussion is how to avoid glitches and make it with less perf cost, any ideas?

Here I make a demo with a performance comparison of wonka, effector, reatom: https://runkit.com/artalar/5ffc6163d282b40013440110
To avoid glitches:

Effector internally uses a graph traversal algorithm (it mostly work when links are created).
Reatom uses a pull approach and some variations of memoization (it works at every update).
Wonka uses sample (it works at every update, as I understand).

I don't why, but Wonka is 2-3 times slower. Have you interested in why?
I try to replace locally w_combine (with sample) by native combine and get execution median from 2-3 times to ~1.2 times bigger than Effector and Reatom (which is steel looks a lot, but better than earlier) and result value (wRes) is 7 times bigger, that show to us a possible glitchs impact. It is ok by the perf test because wD, wF, wG, wH, mapper functions are simple and make low-cost computation, so we may rerun it a few times without perf overhead, but as we don't know how heavy is a mapper function in some user code the case of this discussion is how to avoid glitches and make it with less perf cost, any ideas?


Consider using galemu in FixtureStore

Feature Request
Because of lacking GATs, FixtureStore clones data when an scanner is created from it. This makes benchmarks complicated (to bypass this clone cost) or inaccurate (clone cost is counted).
Looks like for now we have a choice to resolve this before GATs is landed: https://github.com/1aim/galemu

@breeswish Could we just modify the representation of FixtureStoreScanner and let it wrap an std::collections::btree_map::Iter which is an iterator that yields references of items in BTreeMap. And then we can clone the data in BTreeMap by need.
https://github.com/tikv/tikv/blob/cb0e3046ca315ce00964b9bf11bd210c08f4ccdf/src/storage/txn/store.rs#L278-L280

@breeswish I check the documentation of galemu, it seems that we need to change the definition of  trait Store to (some details omitted):
use galemu::{Bound, BoundExt};
pub trait Store {
    type Scanner: for<'s> BoundExt<'s> + Scanner;
    fn scanner<'s>(&self) -> Bound<'s, Self::Scanner>;
}

It will be a disaster when GATs is landed and harm for the current APIs the depends on Store.
Or, we could add a lifetime to Store:
pub trait Store<'s>: Send {
    type Scanner: Scanner;
    fn scanner(&'s self) -> Self::Scanner;
}

So, we can return a std::collections::btree_map::Iter which iterates over BTreeMap by reference as a Scanner when impl Store for FixtureStore.
Here is a demo:
use std::slice::Iter;
pub trait Store<'s>: Send {
    type Scanner: Iterator;
    fn scanner(&'s self) -> Self::Scanner;
}

pub struct FixtureStore<T> {
    data: Vec<T>,
}

impl<T> FixtureStore<T> {
    pub fn new(data: Vec<T>) -> Self {
        Self { data }
    }
}

impl<'s, T: 's + Send> Store<'s> for FixtureStore<T> {
    type Scanner = Iter<'s, T>;
    fn scanner(&'s self) -> Self::Scanner {
        self.data.iter()
    }
}

If you think it's worthwhile I will try to open a PR.

@iosmanthus Nice work. I previously tried to use Store<'s> but it is more complicated because Store is stored in a lot of places (so it's indeed also a large API change). May you try with fn scanner<'s>(&self) -> Bound<'s, Self::Scanner>; to see if it needs a lot of changes?

@iosmanthus Nice work. I previously tried to use Store<'s> but it is more complicated because Store is stored in a lot of places (so it's indeed also a large API change). May you try with fn scanner<'s>(&self) -> Bound<'s, Self::Scanner>; to see if it needs lesser changes?

fn scanner<'s>(&self) -> Bound<'s, Self::Scanner>; require Self::Scanner satisfy trait bound: BoundExt<'s>. To Add BoundExt<'s> for Store::Scanner, we need to use create_gal_wrapper_type_for for every Scanner type to create a wrapper type in order to lift the lifetime. It looks like:
#![feature(arbitrary_self_types)]
use galemu::{create_gal_wrapper_type, Bound, BoundExt};

pub trait Store {
    type Scanner: Scanner + for<'s> BoundExt<'s>;
    fn scanner<'s>(&'s self) -> Bound<'s, Self::Scanner>;
}

pub trait Scanner: for<'a> BoundExt<'a> {
    type Item;
    fn next(self: &mut Bound<Self>) -> Option<Self::Item>;
}

type Iter<'a> = std::slice::Iter<'a, i32>;
create_gal_wrapper_type! {
    pub struct IterWrap(Iter<'a>);
}

impl Scanner for IterWrap {
    type Item = i32;
    fn next(self: &mut Bound<Self>) -> Option<Self::Item> {
        let me = IterWrap::get_mut(self);
        me.next().cloned()
    }
}

pub struct NewStore(Vec<i32>);
impl Store for NewStore {
    type Scanner = IterWrap;
    fn scanner(&self) -> Bound<Self::Scanner> {
        IterWrap::new(self.0.iter())
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    #[test]
    fn it_works() {
        let store = NewStore(vec![1, 2, 3, 4]);
        let mut scanner = store.scanner();
        let mut result = vec![];
        while let Some(i) = scanner.next() {
            result.push(i);
        }
        assert_eq!(vec![1, 2, 3, 4], result);
    }
}

It we use GATs, no wrapper type are needed.
The wraper type created by the macro is annoying and will recude the readability of the code.
Maybe we cound wait GATs land and change the code. It seems like the core system for GATs is already in place.


Change Path

Add feature to change path.  Example /socket.io to /ws

In your laravel-echo.server.json use socket.io parameter to change. https://github.com/tlaverdure/laravel-echo-server#configurable-options

I actually tried it but still resulted in a CORS issue
socketio: {    attach: { path: '/echo' } }


Installing through Yarn fails for Node < 6.7.0

This is a (multiple allowed):

[ ] bug

[x] enhancement

[ ] feature-discussion (RFC)

Swiper Version: 3.4.1

Platform/Target and Browser Versions: Node v4.6.2, Yarn 0.18.1

What you did
Tried to install Swiper through Yarn using Node v4.6.2 (my project depends on that). Yarn gives an error since Swiper requires a 6.7.0 Node version in the engines entry on package.json:
"engines": {
  "node": ">= 6.7.0"
},

Is that the real minimum Node version or can it be downgraded to 4.x? Is the engines entry really needed at all given that this is a frontend library and Node is most likely used for tooling in the build process?
Thanks.

Opened PR #1972 for this.


Release v0.20.0

Describe your changes
Provide Issue ticket number if applicable/not in title
Provide link to Netmaker PR if required
Provide testing steps
Checklist before requesting a review

[ ] My changes affect only 10 files or less.
[ ] I have performed a self-review of my code and tested it.
[ ] If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
[ ] If it is a bugfix, my code is <= 200 lines.
[ ] My functions are <= 80 lines.
[ ] I have had my code reviewed by a peer.
[ ] My unit tests pass locally.
[ ] Netclient & Netmaker are awesome.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 5 committers have signed the CLA.:white_check_mark: mattkasun:white_check_mark: abhishek9686:white_check_mark: afeiszli:x: dependabot[bot]:x: GravitlGravitl seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Warn on duplicate value for variable

This feature proposes adding a warning/error on the case that a user's environment defines two variables with the same name. For example:

NEXT_PUBLIC_API_URL=http://localhost:4000
SOME_OTHER_VARS=12345

NEXT_PUBLIC_API_URL=https://api.quentli.com

This could catch situations in a user runs runs a process with an unintended env.

Although I like this feat, I vote for it to be an optional feature because sometimes we may need to have multiple variables just for rapid testing purposes as the env file will be still valid (I'm thinking of dotenv here)
Maybe under the flag --no-duplicate, idk

Although I like this feat, I vote for it to be an optional feature because sometimes we may need to have multiple variables just for rapid testing purposes as the env file will be still valid (I'm thinking of dotenv here)
Maybe under the flag --no-duplicate, idk

Interesting, can you explain why you would have multiple values for a variable? Doesn't a line comment (#) cover this use case? 🤔

Doesn't a line comment (#) cover this use case?

it does but (for me, while I'm testing various values) duplicating the line + changing it is quickler than duplicating + comment-in + changing the other one
But yeah, at same time I might not need to use envful before removing those duplicated values
My real concern here is that: before, I was using envful to check the presence of env. vars, but now (after that feat) it's also doing some validation that could be too strict (as dotenv won't complain on duplicate values)


Log a useful message when the PeerSet, peer crawler, syncer, or mempool hang

Motivation
It's hard to work out when one of Zebra's important tasks has hung, why it hung, and what state it is in.
Designs

Log an error when the PeerSet, peer crawler, syncer, or mempool hang, with useful diagnostics
Log an error when all the address book peers will never be used for outbound connections

Related Work
We might be better using tokio-console instead:

#2112

PR #3555 added some hang logs that should be independent of other tasks.


Guess column types from dataframe

Ability to guess whether a column is measure/dimension/attribute and present the user with the tool's guess at runtime, similar to how R's readr::read_csv or other CSV parsers work.
We can accept poor "guesses" at first - e.g., if a column is entirely numeric, assume it is a measure.
Report back to the user what the programme has guessed, like read_csv:
> readr::read_csv("https://people.sc.fsu.edu/~jburkardt/data/csv/addresses.csv")

#> ── Column specification ────────────────────────────────────────────
#> cols(
#>   John = col_character(),
#>   Doe = col_character(),
#>   `120 jefferson st.` = col_character(),
#>   Riverside = col_character(),
#>   NJ = col_character(),
#>   `08075` = col_character()
#> )

I think this is superceded by the configuration by convention approach used in csvcubed.


Disable the delete bdd test temporarily to unblock integration test stage

See #110
The test is successful locally. However, it fails on IBM cloud's integration test stage.
This is non functional for several days now.
So, let's disable it till we find the root cause.

IBM Cloud toolchain: Delivery Pipeline deployed products to nyu-devops-products, including commit 0506304aec3a26314308ed2d431cbe771fd2964c


CAMEL-19589: upgraded testcontainers to 1.18.3

Obs.: I'm waiting for the full tests on my own CI, so I'll merge when it's complete there.

Let's give it a try 🤞


CARDS-1164 (Smaller form headers on smaller screens) amendment: Moved the breadcrumb action to the RIGHT of the sticky header

This positioning of the resource header actions should be compared to what is proposed in #728 and to what is already in dev via #723 , and one of the 3 must be chosen.

tested - perfect!

confirmed: alignment is a bit off on both subject and form pages in Firefox

In Firefox the title is not vertically centered:

Fixed in 3fed284.


1.0.1g :: Missing symbols while linking libcrypto.a

Looks like there maybe a dependency issue which is not present in vanilla 1.0.2g.
Edit: Fails in all tested configurations: default configure options, no-shared, no-fips, etc.
if [ -n "libcrypto.1.0.0.dylib libssl.1.0.0.dylib" ]; then \
        (cd ..; /Applications/Xcode.app/Contents/Developer/usr/bin/make libcrypto.1.0.0.dylib); \
    fi
[ -z "" ] || cc -fPIC -fno-common -DOPENSSL_PIC -DOPENSSL_THREADS -D_REENTRANT -DDSO_DLFCN -DHAVE_DLFCN_H -arch x86_64 -O3 -DL_ENDIAN -Wall -DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT -DOPENSSL_BN_ASM_MONT5 -DOPENSSL_BN_ASM_GF2m -DCHAPOLY_x86_64_ASM -DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DMD5_ASM -DAES_ASM -DVPAES_ASM -DBSAES_ASM -DWHIRLPOOL_ASM -DGHASH_ASM -DECP_NISTZ256_ASM -Iinclude \
        -DFINGERPRINT_PREMAIN_DSO_LOAD -o fips_premain_dso  \
        fips_premain.c fipscanister.o \
        libcrypto.a
Undefined symbols for architecture x86_64:
  "_chacha_20_core_avx", referenced from:
      _CRYPTO_chacha_20 in libcrypto.a(chacha20.o)
  "_chacha_20_core_avx2", referenced from:
      _CRYPTO_chacha_20 in libcrypto.a(chacha20.o)
  "_poly1305_finish_avx2", referenced from:
      _EVP_chacha20_poly1305_init_draft in libcrypto.a(e_chacha20poly1305.o)
      _EVP_chacha20_poly1305_init in libcrypto.a(e_chacha20poly1305.o)
  "_poly1305_update_avx2", referenced from:
      _EVP_chacha20_poly1305_init_draft in libcrypto.a(e_chacha20poly1305.o)
      _EVP_chacha20_poly1305_init in libcrypto.a(e_chacha20poly1305.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[4]: *** [link_a.darwin] Error 1
make[3]: *** [do_darwin-shared] Error 2
make[2]: *** [libcrypto.1.0.0.dylib] Error 2
make[1]: *** [shared] Error 2
make: *** [build_crypto] Error 1

More build logs here updated: minimal examples

A custom version of Nasm for kernel dev work broke Intel's chacha avx codegen scripts, 2.12, 2.12 (head) and 0.98.40 (Apple fork) work fine.

Will troubleshoot because there is some dependency differences between Homebrew and user-attended causing it to fail.

Intel's avx-optimized asm scripts appear to output empty files with the following nasm versions on OS X:

0.98.40 (Apple Computer, Inc. build 11)
2.12
2.12 (head)

AVX Codegen Scripts

./crypto/chacha20poly1305/asm//chacha20_avx.pl &
./crypto/chacha20poly1305/asm//chacha20_avx2.pl &
./crypto/chacha20poly1305/asm//poly1305_avx.pl
./crypto/chacha20poly1305/asm//poly1305_avx2.pl &
./crypto/chacha20poly1305/asm//poly1305_x64.pl

& Generating empty files

@steakknife The problem is due to newer versions of Apple's clang no longer showing the original clang version, so you need to add another avx check at the top of each perl file:
if (`$ENV{CC} -v 2>&1` =~ /^Apple LLVM version [7-9]/) {
  $avx = 2;
}

After that the files get generated, but I'm running into another error:
Undefined symbols for architecture x86_64:
  "poly1305_finish_x64", referenced from:
      _poly1305_finish_avx2 in libcrypto.a(poly1305_avx2.o)
     (maybe you meant: _poly1305_finish_x64)
  "poly1305_update_x64", referenced from:
      _poly1305_update_avx2 in libcrypto.a(poly1305_avx2.o)
     (maybe you meant: _poly1305_update_x64)
ld: symbol(s) not found for architecture x86_64

I fixed this manually by replacing jmp	poly1305_update_x64with jmp	_poly1305_update_x64 inside poly1305_avx2.s it seems this is a translation error by the x86_64-xlate.pl script, which should also mangle the symbol for the jump, because it references a global that is mangled.

After reading the code of x86_64-xlate.pl I noticed that those unmagled symbols should've been marked as extern, so the complete fix is:
diff --git a/crypto/chacha20poly1305/asm/chacha20_avx.pl b/crypto/chacha20poly1305/asm/chacha20_avx.pl
index bf3e3f0..4a8e9f3 100644
--- a/crypto/chacha20poly1305/asm/chacha20_avx.pl
+++ b/crypto/chacha20poly1305/asm/chacha20_avx.pl
@@ -68,6 +68,10 @@ if (`$ENV{CC} -v 2>&1` =~ /(^clang version|based on LLVM) ([3-9])\.([0-9]+)/) {
   $avx = ($ver>=3.0) + ($ver>=3.01);
 }

+if (`$ENV{CC} -v 2>&1` =~ /^Apple LLVM version [7-9]/) {
+  $avx = 2;
+}
+
 if ($avx>=1) {{

 my ($rol8, $rol16, $state_cdef, $tmp,
diff --git a/crypto/chacha20poly1305/asm/chacha20_avx2.pl b/crypto/chacha20poly1305/asm/chacha20_avx2.pl
index 9f31f86..f6dcb31 100644
--- a/crypto/chacha20poly1305/asm/chacha20_avx2.pl
+++ b/crypto/chacha20poly1305/asm/chacha20_avx2.pl
@@ -67,6 +67,10 @@ if (`$ENV{CC} -v 2>&1` =~ /(^clang version|based on LLVM) ([3-9])\.([0-9]+)/) {
   $avx = ($ver>=3.0) + ($ver>=3.01);
 }

+if (`$ENV{CC} -v 2>&1` =~ /^Apple LLVM version [7-9]/) {
+  $avx = 2;
+}
+
 if ($avx>=2) {{

 my ($state_4567, $state_89ab, $state_cdef, $tmp,
diff --git a/crypto/chacha20poly1305/asm/poly1305_avx.pl b/crypto/chacha20poly1305/asm/poly1305_avx.pl
index cedeca1..c30f6a1 100644
--- a/crypto/chacha20poly1305/asm/poly1305_avx.pl
+++ b/crypto/chacha20poly1305/asm/poly1305_avx.pl
@@ -74,6 +74,10 @@ if (`$ENV{CC} -v 2>&1` =~ /(^clang version|based on LLVM) ([3-9])\.([0-9]+)/) {
         $avx = ($ver>=3.0) + ($ver>=3.01);
 }

+if (`$ENV{CC} -v 2>&1` =~ /^Apple LLVM version [7-9]/) {
+        $avx = 2;
+}
+
 if ($avx>=1) {{

 my ($_r0_, $_r1_, $_r2_, $_r3_, $_r4_,
diff --git a/crypto/chacha20poly1305/asm/poly1305_avx2.pl b/crypto/chacha20poly1305/asm/poly1305_avx2.pl
index d2dd51f..90dc4a8 100644
--- a/crypto/chacha20poly1305/asm/poly1305_avx2.pl
+++ b/crypto/chacha20poly1305/asm/poly1305_avx2.pl
@@ -57,6 +57,10 @@ if (`$ENV{CC} -v 2>&1` =~ /(^clang version|based on LLVM) ([3-9])\.([0-9]+)/) {
         $avx = ($ver>=3.0) + ($ver>=3.01);
 }

+if (`$ENV{CC} -v 2>&1` =~ /^Apple LLVM version [7-9]/) {
+        $avx = 2;
+}
+
 if ($avx>=1) {{

 my ($_r0_, $_r1_, $_r2_, $_r3_, $_r4_,
@@ -395,6 +399,7 @@ my ($state, $in, $in_len, $hlp, $rsp_save)

 $code.=<<___;

+.extern poly1305_update_x64
 ###############################################################################
 # void poly1305_update_avx2(void* $state, void* in, uint64_t in_len)
 .globl poly1305_update_avx2
@@ -907,6 +912,7 @@ poly1305_update_avx2:
 6:
   ret
 .size poly1305_update_avx2,.-poly1305_update_avx2
+.extern poly1305_finish_x64
 ###############################################################################
 # void poly1305_finish_avx2(void* $state, uint8_t mac[16]);
 .type poly1305_finish_avx2,\@function,2
diff --git a/crypto/chacha20poly1305/asm/poly1305_x64.pl b/crypto/chacha20poly1305/asm/poly1305_x64.pl
index 31c4c47..478f707 100644
--- a/crypto/chacha20poly1305/asm/poly1305_x64.pl
+++ b/crypto/chacha20poly1305/asm/poly1305_x64.pl
@@ -55,6 +55,10 @@ if (`$ENV{CC} -v 2>&1` =~ /(^clang version|based on LLVM) ([3-9])\.([0-9]+)/) {
         $avx = ($ver>=3.0) + ($ver>=3.01);
 }

+if (`$ENV{CC} -v 2>&1` =~ /^Apple LLVM version [7-9]/) {
+        $avx = 2;
+}
+

 {
 {

After that compilation and make test on macosx with OpenSSL_1_0_2-stable is successful.

Awesome, thanks Apple (sarcasm) but thanks @felixbuenemann.


create docker host failed when used generic drivers

The error message:
root@n14:~/.ssh# docker-machine create -d generic --generic-ssh-user yzxu --generic-ssh-key id_rsa --generic-ip-address <IP_ADDRESS> ubuntu
Importing SSH key...
SSH cmd error!
command: sudo hostname ubuntu && echo "ubuntu" | sudo tee /etc/hostname
err    : exit status 1
output : sudo: no tty present and no askpass program specified
Sorry, try again.
sudo: no tty present and no askpass program specified
Sorry, try again.
sudo: no tty present and no askpass program specified
Sorry, try again.
sudo: 3 incorrect password attempts

Does your ssh key require a password?

@ehazlett No,it doesn't.
yzxu@n14:~/.ssh$ ls
authorized_keys  config.bk  id_rsa  id_rsa.pub  known_hosts
yzxu@n14:~/.ssh$ ssh -i id_rsa<EMAIL_ADDRESS>Welcome to Ubuntu 12.04.5 LTS (GNU/Linux 3.8.0-29-generic x86_64)

* Documentation:  https://help.ubuntu.com/
New release '14.04.1 LTS' available.
Run 'do-release-upgrade' to upgrade to it.

Last login: Tue Aug 25 10:16:25 2015 from <IP_ADDRESS>
yzxu@ubuntu:~$

Are you on OSX?

+1
Running on OSX and Linux.
But in my case, I'm trying to specify a ".pem" key.

@dayiguizhen @marlonpp Did you get a chance to test a more recent version?

@dayiguizhen -- is this the same as #1569? Not sure if @marlonpp is different, though.

@dgageot I'm give up create that docker host.And I create another docker host,it was will.So I will close this issue.


Changes for cis-1.5, scheduling, profiles, alerts

Issues:
Schedule/Alert: rancher/rancher#25326
Profiles: rancher/rancher#25325
CIS 1.5 support: rancher/rancher#24987

go.mod conflicts need to be resolved, Changes are fine.


CLIMATE-725 Ensure that OCW 1.1 Test PyPi Works as Expected

This issue addresses https://issues.apache.org/jira/browse/CLIMATE-725
The remainder of the comment can be found over there and I am also going to augment the release procedure to accommodate publishing of OCW to the Cheeseshop.

Merged build triggered. Test Failed.

Merged build started. Test Failed.

Merged build finished. Test Failed.

@huikyole if you get time can you verify this patch please?

@lewismc I will test it after installing Ubuntu linux. Thanks a lot!

@lewismc just out of curiosity I went ahead and tried this patch. It worked successfully and I was able to import to all the packages mentioned in this commit in a python session. :)
Thanks.

Thanks @Omkar20895 I am going to commit this


Sensu API -> RabbitMQ connection failure on startup causes exit

When launching sensu-api, a failure to reach the rabbit server is logged as an error but causes the daemon to exit.
{"timestamp":"2014-04-30T10:34:27.958073-0400","level":"error","message":"[amqp] Detected TCP connection failure"}

Newer version of Sensu (currently 0.18) go into a reconnecting state and event reconnect in the event of AMQP channel errors.


sql/analyzer: refactor resolve_natural_joins rule

Now it's more simple, easier to understand and has way less code.

Good shaving you did there.


The 13th character of a "name" cannot be 's'

If the 13th character is 's', it will be transfered to 'c'.
e.g.
Name not properly normalized (name:<PHONE_NUMBER>11s, normalized:<PHONE_NUMBER>11c)

The 13th character can't be many things. Only 12 characters are allowed for account names.


x-timeplus http header

PR checklist:

Did you run ClangFormat ?
Did you separate headers to a different section in existing community code base ?
Did you surround proton: starts/ends for new code in existing community code base ?

Please write user-readable short description of the changes:

Unless the proton SDK relies on such headers, otherwise, Neutron and other components should not use any such headers.


Use correct UI/NSResponder class in presponder (fixes #134)

Tests only the appropriate class for the platform.
Verified working on OS X:

Verified working on iOS:

Thanks Kolin!


frsky_telemetry not working on release v1.1.3

The app frsky_telemetry is not working in the new released version as it did on the release v1.1.2
Have you noticed that? There have been any significant change that could explain that?
On previous releases just adding the the line:
frsky_telemetry start -d /dev/ttyS2
on the etc/extras.txt in the SD card was working.
Thanks

Are you using a Pixhawk? Also, which series of FrSky receiver are you using
(X or D)?
On Wed, Jan 27, 2016 at 10:49 AM Diamg<EMAIL_ADDRESS>wrote:

The app frsky_telemetry is not working in the new released version as it
did on the release v112
Have you noticed that? There have been any significant change that could
explain that?
On previous releases just adding the the line:
frsky_telemetry start -d /dev/ttyS2
on the etc/extrastxt in the SD card was working
Thanks
—
Reply to this email directly or view it on GitHub
https://github.com/PX4/Firmware/issues/3613.

To answer your question: the frsky_telemetry daemon has been modified to add SmartPort telemetry, but it should work the same as before for D series telemetry. I've tested it on FMUv2 port ttyS2 using a D4R-II and Taranis Plus running OpenTX 2.1.

We are using a pixhawk with D4R-II on port ttyS2 but with a FlySky TH9X flashed by 3DR.

Can you start the Frsky process from the console instead of from SD and share the output?
http://dev.px4.io/advanced-system-console.html
Please report back and share the output on the console. You have to make sure that you're not already starting it from the microSD.

I had the same problem. I share a picture with my wiring. I am using the 3DR X8+. I tried the default connction to TELEM2 and using:
frsky_telemetry start -d /dev/ttyS2
to start telemetry.
When I do that from the shell and I check the status it says the telemetry is working but I recieve no signal in my RC.
I also tried to connect the telemetry to SERIAL 4/5 and ttyS6.

If I try without -d I have an extra output line
nsh> frsky_telemetry start -d /dev/ttyS2
frsky_telemetry: opening uart
nsh> frsky_telemetry status
frsky_telemetry: running
nsh> frsky_telemetry stop
frsky_telemetry: .
frsky_telemetry: terminated.
nsh>
nsh> frsky_telemetry start /dev/ttyS2
frsky_telemetry: opening uart
nsh> frsky_telemetry: SmartPort receiver not detected, sending FrSky D type telemetry

nsh> frsky_telemetry status
frsky_telemetry: running
nsh> frsky_telemetry stop
frsky_telemetry: .
frsky_telemetry: .
frsky_telemetry: .
frsky_telemetry: .
frsky_telemetry: terminated.

In both cases the telemetry is not working.  I don't know if when it says SmartPort receiver not detected it is wainting for some response

There are two issues here:

You didn't wait in your first attempt for it to switch to D mode telemetry (which is your telemetry type)
You entered the wrong command on your 2nd attempt, which means it did not open /dev/ttyS2 but /dev/ttyS6

Can you re-try with the correct port and wait a little longer and provide the output of that?

@kd0aij You might have to disable hardware flow control explicitly, it might be connected here. Hard to see.

I tried again and wait more than a minute but there is no second output.
If I try connecting to SERIAL 4/5, and executing:
nsh> frsky_telemetry start
frsky_telemetry: opening uart
nsh>

I have no second output. It is not changing to D telemetry.

Ok, that was a great result. So something is wrong with the switch.
@kd0aij The D switch heuristic probably needs to be reworked. Are you maybe not basing it wether you can decode something, but based on wether you get any data? It might be that you get the data you're writing yourself back. So you might need to either flush the buffer after every write, or try to decode the data and see if its a valid sensor hub message.

Thanks a lot for your help.

Yes, there must be traffic on the receive input of ttyS2. I just noticed that the instructions here: http://px4.io/docs/frsky-telemetry/ say to connect both RX and TX, but a quick fix would be to disconnect the ttyS2 RX line since it's not used by the original driver anyway, and that's the way I've been testing.
I'll look further into D type telemetry to see what's coming from the RX.

The D series receiver is transmitting AD1, AD2 and "link quality" on its TX line. We could enhance the daemon to recognize this packet and perhaps also publish this data. Or we could just require that the D telemetry port TX line is not connected.

I would much prefer a software solution if possible. The finicky TX line difference between the versions will let a lot of users stumble. But only you can judge if that's a quick fix or a major undertaking.

Jumping into this thread from 30,000' high. From what I remember (well over a year ago), the FrSky RX sends Requests and the various sensors respond accordingly. If they have the requested sensor data type, they respond. I wrote a "sensor" using a Teensy back in 2014. I can look it up if needed.

That's true for SmartPort. But not for "D" type telemetry.

@LorenzMeier Should be a simple software fix to validate the D type incoming packet. Publishing RSSI to uORB should also be an easy enhancement, if there's an existing topic to publish to.

Don't have that topic yet. Right now my main concern is to have people with D setups going again.

:+1:  Firing up Eclipse

software fix ready for testing: https://github.com/PX4/Firmware/pull/3624

@kd0aij Nice!

I tested the fixed version and D frsky telemetry is working well!
Thank you vey much!

Cool! Merged to master, closing.


Some thoughts on "stories on web site"

So.. I've done a bit of digging since IG has started putting stories on the web page. I think it would be nicer not having to pretend to be a smartphone app and do some voodoo to the headers to fetch stories.
The official site sends a graphql query with id=17890626976041463, which roughly equates to _get(url_reels_tray). But it is "empty", in the sense that it has no "items" (comparable to the issue that commit 82ae31c dealt with).
It returns ['data']['user']['feed_reels_tray']['edge_reels_tray_to_reel']['edges'], with a list of nodes:
"node": {
	"expiring_at":<PHONE_NUMBER>,
	"id": "...",
	"latest_reel_media":<PHONE_NUMBER>,
	"ranked_position": 1,
	"user": {
		"id": "37...",
		"profile_pic_url": "https:...jpg",
		"username": "d..."
	}
}

So users whose stories are sought need to be queried for their actual stories: GQL id=17873473675158481 with {'reel_ids' = [uid(s)]}. Though I think it would be possible to make use the latest_media_reel timestamp to avoid polling for a user's stories unnecessarily, somewhat like what is done for fast_update.
Anyway, the "web-reels_media" query returns a list in ['data']['reels_media'] that roughly contains:
"items": [
	{
		"__typename": "GraphStoryImage" / "GraphStoryVideo",
		"display_url": "https://sconte...44320_n.jpg",
		"id": "168...",
		"is_video": true / false,
		"taken_at_timestamp":<PHONE_NUMBER>
		if is_video:
		"video_resources": [ { "src": "https://scontent...02434186091_n.mp4" } ]
	},
	...
],
"latest_reel_media":<PHONE_NUMBER>,
"user": {
	"id": "49165...",
	"profile_pic_url": "https://...8528_n.jpg",
	"username": "b..."
}

Which to me looks more in line with what is returned by the other website-GQL calls, and might be able to integrate with the Post class (if that even makes sense for stories).
I don't have any plans to work on migrating story-related methods from the app-spoofing at the moment, but I don't think it would be all that hard.

Implemented in v4-dev branch for Version 4. Thanks again!


train problem

Hello, could you help me solve the problem I encountered?
Traceback (most recent call last):
File "train_velodyne_td3.py", line 168, in
priority = network.to_priority(state,action,reward,done_bool,next_state)
File "/root/autodl-tmp/DRL-robot-navigation/TD3/TD3.py", line 57, in to_priority
target_Q = reward + self.discount * (1 - done) * target_Q
RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu!

Hi,
There is no such code in this repo:
priority = network.to_priority(state,action,reward,done_bool,next_state)
But your tensors are located on different devices.
Simple Google search will help you solve this problem.


Connection pool configuration contains port and ignores supplied port from host

It is not clear if this is misunderstanding on my end or if this is the intended behavior but I see that your connection pool configuration includes a host port.  That port is then used to overwrite the port in a supplied host:
ConnectionPoolImpl.java
public boolean addHost(Host host, boolean refreshLoadBalancer) {
host.setPort(cpConfiguration.getPort());
In our deployed env we would have N-redis instances on a single host.  Following the documentation we would then setup N nodes (dynomite + redis) on that host.  This would mean N ports.
Please let me know what I am missing.

Thanks opuneet -
In terms of modeling I would think that you DO NOT want the port in the connection pool configuration but rather with the host.  Would you add the host name to the connection pool configuration?  No, since then you would have to create N (host count) ConnectionPoolConfiguration objects.  Adding port to the ConnectionPoolConfiguration forces a similar issue for those use cases where a single host runs more than a single instance of redis/dynomite.
From a modeling perspective "port" relates to the host, not the runtime behavior of connection management.  It seems that using port from the Host object works for the Netflix use case as well as providing flexibility to those uses cases outside of 1-to-1 dynomite-node-to-host model and for that reason feels like the right direction.

I've recently run into this as well. I've mostly gotten around it by subclassing the host object to ignore the port set done by the connection pool.
  Redis and dyno seem to work better with many instances per box. Its easier to configure this with different ports than it is to beg for more ips on the lan for this.
So I'd most definitely vote to keep the port configuration at the host level.  The dynomite server instance doesn't seem to have any issues with this.

@alosix What are the advantages you have seen with running multiple Dynomite/Redis in the same bigger instance? If the instance goes down, you need to warm up two token ranges.

@ipapapa  For me its to more efficiently use the hardware at hand for processing higher loads vs availability. This is being using in some lambda counting in conjunction with twitter's summingbird, So the data this creates is ephemeral and used for about 2 hours until the map reduce side dumps the finalized counts into cassandra for longer term storage.

@alosix sounds a very interesting use case. Thank you for the information.


what is the dummy model and how to use it?

i see a new model named 'dummy model'  is commited. But i don't know how to use it and what is that model?
By the way,is there any other compressedd models,such as "MobileNet" ,"ShuffleNet" be added in future?or how to use this models to train the Network?

It's supposed to be a small model to be used for testing.


Publish Docker images

probably going to want the app to not run as root in the docker image with
Create appuser
RUN adduser -D -g '' appuser
USER appuser

Is that still relevant given FROM scratch?


Error importing Werkzeug

just in case someone encountered an error in running the API .
add Werkzeug in docker file: Werkzeug==0.16.1

Hi @moh55m55,
can you point me to a concrete error? I just build the container from scratch and ran the tests and didn't get any errors.

It has been a while. I really do not recall the error. It was an import error. Try to add --no-cache
docker build --no-cache
Also add "--no-cache" to the build command in this issue.


Avoid segfault when there are dynamic shapes in string inputs

@Tabrizian Can you also add a test in L0_perf_client? May be just change one of the object model to variable one?

Added a test: https://github.com/triton-inference-server/server/pull/2954


First 3d neighbor visualization

Code for experiments around visualizing Neighbors in 3D (especially the challenge to visualized them in VR mode)

I got this error:

Did you not get this?

I didn't get this; could you try npm install again and see if axios and html2canvas install properly or if there are any installation errors?

This is effectively merged already from the other PR?


[WIP] Try to speed up the CI for testing by building and caching in ghcr

Task linked: QF-4434 Try to optimize CI test builds

Build with ghcr.io caching of qfieldcloud images does run 7 m 7s  (app: 1 m 31 s, nginx: 19 s, qgis: 5 m 17 s)

Closing, as there are already improvements that were tested in this PR in the merged #1048 and #1050 .


Seamless SSO with ADFS

Can someone please explain what does the purple banner that says "Seamless SSO is not applicable to Active Directory Federation Services (ADFS)." mean?
What path should I take to allow users to login automatically to sharepoint, office365 and etc?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3e1db2d3-8e7d-0c60-f5c5-827b6a673505
Version Independent ID: f28d55d1-f974-7767-6c69-56b74f14ff50
Content: Azure AD Connect: Seamless Single Sign-On
Content Source: articles/active-directory/connect/active-directory-aadconnect-sso.md
Service: active-directory
GitHub Login: @swkrish
Microsoft Alias: billmath

@atfernando Thanks for your feedback! We will investigate and update as appropriate.

@atfernando This means that Seamless SSO works only on managed domains, and not federated ones. So if you are using ADFS, you already get this functionality out-of-the-box. But if you are using Password Hash Sync or Pass-through Authentication, you need to enable Seamless SSO explicitly to get the automatic sign-in capability on managed domains. HTH.
#please-close

@atfernando We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


feat: Contribute to your country link

What

feat: Added a method and map to get the correct country locale for the corresponding wiki page.
Screenshot

Fixes bug(s)

Fixes:

Part of

#525

Codecov Report
Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 6.85%. Comparing base (4d9c7fc) to head (eca3816).
Report is 481 commits behind head on develop.

Files with missing lines
Patch %
Lines

...pages/preferences/user_preferences_contribute.dart
26.66%
11 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5874      +/-   ##
==========================================
- Coverage     9.54%   6.85%   -2.70%
==========================================
  Files          325     428     +103
  Lines        16411   23598    +7187
==========================================
+ Hits          1567    1617      +50
- Misses       14844   21981    +7137

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Missing event watcher hook like useWatchContractEvent

There's no hook for logging contract events like https://wagmi.sh/react/api/hooks/useWatchContractEvent#usewatchcontractevent

Good catch! The good news is that the Starknet RPC spec includes a continuation token for the starknet_getEvents call so that we can use react-query infinite queries to implement this.

So we are getting a useWatchContractEvent hook for starknet-react? l'd be happy to contribute to it.

Yes, it should be useContractEvents. I will provide a shirt guide on what changes are required tomorrow morning.

To implement this hook you'll need to add some extra work since it's the first hook that uses infinite queries.

First you need to wrap useInfiniteQuery like we did with useQuery  in query.ts. It just makes only some parameters configurable.
Add the new useEvents hook. The hooks should return the events as the data and store the continuation token to implement fetchNextPage.
Add a type-safe useContractEvents hook that calls useEvents and additionally parses the events to javascript objects. You should be able to use starknet.js and abi-wan to make it type-safe. This is optional, you can implement in a second PR.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
We develop smart contracts in Solidity for Ethereum's testnet and mainnet, and we use Next.js and React with TypeScript for the front end. Now, we're starting smart contract development on the Stellar blockchain using Soroban (Rust).
I use Wagmi for wallet connections and hooks, and I've found it very effective. After reading the documentation, I have a good idea of how to implement something similar to the useWatchContractEvent hook.
My focus is on maintaining clean, scalable code that aligns with the structure and quality of our existing codebase.
How I plan on tackling this issue
Create a custom React hook similar to useWatchContractEvent for StartkNet. This hook would subscribe to specific events on the StartkNet smart contract and update your React component's state based on those events.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Hey! I'd like to collaborate on this project. I have five years of frontend development experience, I'm currently going through a Starknet bootcamp with Dojo Coding, which provides me with the foundational knowledge needed. I believe this combination of my experience and current training makes me well-suited to tackle this issue. I've already contributed to another project using Typescript and Starknet.js. Thanks for considering me.
How I plan on tackling this issue
I'd love this challenge, I would test the wagmi hook shared in issue and try to understand that implementation to replicate in this context.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
15 years of commercial development in Web 2.0
3 projects from 0 to 1
It's hard to tell, I know my way around technologies.
How I plan on tackling this issue
I'll do as describe in comment:
To implement this hook you'll need to add some extra work since it's the first hook that uses infinite queries.
First you need to wrap useInfiniteQuery like we did with useQuery in query.ts. It just makes only some parameters configurable.
Add the new useEvents hook. The hooks should return the events as the data and store the continuation token to implement fetchNextPage.
Add a type-safe useContractEvents hook that calls useEvents and additionally parses the events to javascript objects. You should be able to use starknet.js and abi-wan to make it type-safe. This is optional, you can implement in a second PR.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I am a web3 developer who has won multiple web3 hackathons and have contributed to web3 open source projects. I was the original poster of this issue which I raised because I encountered it in StarkHack hackathon. Because I was occupied with my university exams so I was not able to start working on this issue. Now that I'm back I can start working on this issue. I'll be able to implement this hook with the experience and the skills I have with react and typescript.
How I plan on tackling this issue
I think @fracek has provided a good detailed explanation about how to implement this hook. I'll be following that and start working on it.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Hi @fracek
I'm available to work on creating a hook for logging contract events. My name is Benjamin, and I have extensive experience in developing and integrating custom hooks to manage blockchain interactions efficiently. My background includes working with various hooks and APIs to enhance functionality and performance in decentralized applications.
Understanding the Issue
Currently, there is no hook available for logging contract events similar to useWatchContractEvent from Wagmi. The goal is to develop a hook that can efficiently watch and return emitted contract event logs. This involves creating a hook that can handle parameters such as address, ABI, event name, and various options for batching, polling, and error handling.
How I plan on tackling this issue
Develop Contract Event Hook

Hook Creation: I will create a custom hook similar to useWatchContractEvent that can listen to and return logs for specified contract events.
Parameters:

address: The contract's address.
abi: The contract's ABI.
eventName: The event to listen for.
args: Arguments to pass when calling the contract.
batch: Whether or not to batch events on each invocation.
chainId: ID of the chain to use when fetching data.
config: Config to use instead of retrieving from the nearest provider.
onError: Callback for handling errors.
onLogs: Callback for handling logs.
poll: Whether to use a polling mechanism to check for new blocks.
pollingInterval: Polling frequency in milliseconds.
strict: Whether to enforce strict checking.
syncConnectedChain: Set up a subscriber for connected chain changes.

Implementation Steps

Create Hook Function: Implement the hook function with the above parameters and functionality.
Testing: Test the hook to ensure it correctly handles contract events, including checking for proper handling of logs and errors.
Documentation: Document the usage of the hook, including parameter descriptions and examples.

Tasks
Develop Hook

Implement Hook Functionality: Create the hook to handle contract events, including configuration options and callbacks.
Integration: Ensure the hook integrates smoothly with existing systems and handles contract interactions as expected.

Testing

Functionality Testing: Verify that the hook correctly listens for and returns contract events.
Error Handling: Test the hook's error handling and logging capabilities.
Performance Testing: Ensure that the hook performs efficiently, including when handling multiple connectors in parallel.

Documentation

Write Documentation: Provide detailed documentation on how to use the hook, including code examples and configuration options.
Update Examples: Include examples for common use cases and configurations.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I'm Software Engineer frontend. I have experience with React and hooks
How I plan on tackling this issue
I will implemente a component useWatchContractEvent similar to the library wagmi. It's a useful component and the issue seems fun

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I'm a Full Stack Web Developer with a solid background in front-end and back-end development. So it will be a pleasure to contribute for the first time to this great project. I am a member of the Dojo Coding community.
How I plan on tackling this issue

Understand the Existing Hook (useWatchContractEvent):

I would begin by thoroughly analyzing the useWatchContractEvent hook provided by wagmi. This includes understanding the parameters it accepts, such as the contract address, ABI, event name, and the callback function onLogs. I would also study how it handles options like pollingInterval, batch, and syncConnectedChain to determine which are essential for the custom hook.

Define the Requirements for the New Hook:

Based on the analysis, I would define the requirements for the new hook. The goal is to provide similar functionality while ensuring it aligns with the specific needs of your project. The custom hook should be able to:

Watch for specific contract events.
Log or process event data through a callback function.
Handle various configurations, such as polling, strict mode, and chain synchronization.

Design and Implementation:

I would design the hook to be as flexible and reusable as possible. It would accept parameters such as address, abi, eventName, onLogs, and optional configurations. The hook will utilize ethers.js or wagmi’s underlying utilities to watch for contract events.
I would implement the core functionality by establishing a WebSocket or polling connection to listen for event logs, then trigger the onLogs callback whenever an event is detected. The hook would also handle errors and provide meaningful feedback via the onError callback.

Testing and Verification:

I would write comprehensive unit tests to ensure that the hook works as expected under various conditions, such as different chain IDs, event types, and error scenarios. Testing will include edge cases, such as handling large batches of logs or network failures.
Additionally, I would test the hook within the context of a sample project or an existing application to verify its behavior in a real-world environment.

Documentation:

I would document the hook thoroughly, including usage examples, parameter descriptions, and configuration options. This documentation will ensure that other developers can easily understand and integrate the hook into their projects.

Integration:

I would ensure the hook integrates seamlessly with the existing codebase, following any specific coding standards or patterns used in your project. This might include making the hook compatible with the existing state management system or aligning it with the current architecture.

Hey @0xmihirsahu have a go at implementing this. Notice that like I mentioned starknet events rpc call has the possibility of paginating responses so we can use the useInfiniteQuery hook from react query. Make sure to wrap it like we do with useQuery

@fracek is this issue still open?


Add possibility to use a domain as a send only domain

This changes enable to exclude domains for local delivery options. This is important to use this module as a send only instance.
I do not have too much time at hand, so I am just leaving that here, there is probably some work to do to pull it in, however I will very probably respond slow, so feel free to copy it over in your own terms, I am using my own image already though.

Thank you @wzrdtales for following the contributing guideline with opening an issue and a corresponding PR; we value contributions to this project. I will post this answer here as well as on the PR, so don't get confused.
I think this idea is worth merging, but there are some flaws which will need to be fixed up, by you if you want this in master. First of all, for this feature, we will need to see tests to verify that it works properly. Moreover, the documentation needs extension too. But you said:

I do not have too much time at hand, so I am just leaving that here, there is probably some work to do to pull it in [...]

Hearing you don't have time, and neither have we for this feature request, there is little chance this is going to be merged soon. If you're willing to invest more time in this, we will happily review and merge these changes. Therefore, I will close the PR for now and mark it as frozen. When the time has come for you or anyone else to pick up and finish this work, please rebase from (then) current master and create a new PR. I will close this issue too. You will not need to re-open it in case you create a new PR, because I now know about it. Feel free to re-open this issue if you changed your mind and want to finish this work sooner than later.
PS: Have a look at make shellcheck. The build failed just because of the shellcheck-tests.


Auto bucketized semantic commit/PR descriptions into changelog sections

The goal here would be to have zero cosmetic or cleanup work to make the changelog, and that part could be fully automated in CI.
The pre-work would be for Engineers (with support+guidance from EM and PM) to groom PR titles as closely as possible to what the change log entry should be.
Post-work would be for EM, PM, and/or Marketing to groom wording and add links - but this would happen in the Release Notes version and not the changelog.

https://commitizen-tools.github.io/commitizen/customization/#custom-changelog-generator
For instance, this mapping from the sample could be customized for our conventions:
    change_type_map = {
        "feat": "Features",
        "fix": "Bug Fixes",
        "refactor": "Code Refactor",
        "perf": "Performance improvements"
    }

We may also want to customize other parts of the rendering process, such as removing type prefixes.
Also consider:

Do we need to replace PR links with Issue links?
Can Commitizen do this for us if so?

@aaronsteers note that we can map types to headers without needing to implement our own changelog class. In the sdk, we have:
https://github.com/meltano/sdk/blob/26a3a8ff020b1e8b33eab4cf7c61cf9c6258286b/pyproject.toml#L124-L131

Closing as resolved. Changelogs are automated now. 🎉 🙌


Bug with concurrent docker run calls

TL;DR: When calling 6 docker run ... & commands, Kubedock sometimes logged fatal error: concurrent map writes. This is not a priority for us (we have migrated away from Kubedock), but I wanted to report it in case you wanted to take action. I realize this is not how most people use Kubedock, so if you want to close this ticket as WONTFIX, that seems reasonable to me.
Using this function from a Jenkins pipeline:
export DOCKER_HOST=tcp://localhost:2475
CONTAINER_DIRECTORY=/tmp
start_containers() {  # $1. num_containers. $2. image
  local -r num_containers="$1"
  local -r image="$2"
  local i local_port pid exit_code
  local -a pids
  for ((i = 1; i <= num_containers; i++)); do
    (( local_port = 3000 + i ))
    docker run -e "TIMEOUT=60000" -e "CONCURRENT=16" -p "$local_port:3000" --rm -d --name "container$i" "$image" > "$CONTAINER_DIRECTORY/$i" &
    pid=$!
    pids+=("$pid")
  done

  for i in "${!pids[@]}"; do
    pid=${pids[i]}
    # will exit the script if it failed since we have `set -e`
    echo "Waiting for container $i to start..."
    wait "$pid" || { exit_code=$?; echo "Container $i failed to start"; exit "$exit_code"; }
  done
}
start_containers "6" "ghcr.io/browserless/chromium:v2.7.1"

In a Kubernetes Pod with a kubedock sidecar set up as shown (ci is the Jenkins container):
apiVersion: v1
kind: Pod
metadata:
  name: "testpants"
spec:
  initContainers:
    # Jenkins won't let you create a configmap alongside the pod, and I don't want another ECR image
    # that is kubedock + the PodTemplate it should use, because that will hide the fact that exists
    # and make it harder to update. So we use an init container to create the configmap
    - name: kubedock-pod-template
      image: busybox:1.35.0
      command: ["/bin/sh", "-c"]
      args:
        - |
          suffix=$(</dev/urandom tr -dc a-z0-9 | head -c 10)
          cat << EOF > /share/kubedock-pod-template.yaml
          apiVersion: v1
          kind: Pod
          metadata:
            annotations:
              example: kubedock
          spec:
            tolerations:
              - key: target
                operator: Equal
                value: kubedock-e2e-$suffix
                effect: NoSchedule
          EOF
      volumeMounts:
        - name: shared-volume
          mountPath: /share
  containers:
    - name: ci
      image: $OUR_ECR.dkr.ecr.us-east-1.amazonaws.com/deploy/executors/ci-image:active-fe7d1296
      command: ["/tini", "--", "sleep", "infinity"]
      resources:
        requests:
          cpu: "28"
          memory: 52Gi
      volumeMounts:
        - name: shared-volume
          mountPath: /share
    - name: kubedock
      # Please grep for this image when you update it and change it everywhere
      # SHA for 0.16.0
      image: "$OUR_ECR.dkr.ecr.us-east-1.amazonaws.com/docker-hub/joyrex2001/kubedock@sha256:f9203c5da759d3097ea6d555837377d8aea7f954337abd104ac306afd4130de6"
      resources:
        requests:
          cpu: "1"
          memory: "2Gi"
      args:
        - server
        # Allows Kubedock to forward traffic to the Pod (e.g., lets `docker run -p 8080:80 $MYIMAGE` work)
        - --reverse-proxy
        # See the init container
        - --pod-template
        - /share/kubedock-pod-template.yaml
        # Without explicit resoure requests, the Pod won't have anything
        - --request-cpu
        - "8"
        - --request-memory
        - "8Gi"
        # default timeout of 1m is not sufficient for Karpenter to create a new Node and schedule the Pod
        - --timeout
        - "10m"
        # default grabs the image from public docker hub
        - --initimage
        # SHA for 0.16.0
        - $OUR_ECR.dkr.ecr.us-east-1.amazonaws.com/docker-hub/joyrex2001/kubedock@sha256:f9203c5da759d3097ea6d555837377d8aea7f954337abd104ac306afd4130de6
      volumeMounts:
        - name: shared-volume
          mountPath: /share
  volumes:
    - name: shared-volume
      emptyDir: {}

Full logs from Kubedock attached:
log.txt

Thanks, very helpful (especially the log). Fixed.


Creating and Subclassing Objective-C Class

Hi, I like your effort to bridge NodeJS and Objective-C. I looked at NativeScript's Documentation and I can see that Objective-C class can be subclassed or extended. I would like to achieve something similar using NodObjC.
var MyAppDelegate = UIResponder.extend({
    // Implement a method from UIApplicationDelegate.
    // We will obtain the method signature from the protocol.
    applicationDidFinishLaunchingWithOptions: function (application, launchOptions) {
        this._window = new UIWindow(UIScreen.mainScreen().bounds);
        this._window.rootViewController = MyViewController.alloc().init();
        this._window.makeKeyAndVisible();
        return true;
    }
}, {
    // The name for the registered Objective-C class.
    name: "MyAppDelegate",
    // Declare that the native Objective-C class will implement the UIApplicationDelegate Objective-C protocol.
    protocols: [UIApplicationDelegate]
});

Oh, I just read the Wiki again and found it! Thanks!


Froala Editor 3.x Support

Now that version 3 is out, this addon should pull in that version.
There are larger, major version changes that I'd also like to work through before releasing a v3 here. This includes Ember Octane stuff such as moving to Glimmer Components. Look at the 3.0 milestone for those.

Update; I had been working on this through the beginning of June but go pulled off due to other work duties (and summer family fun time). Hoping to get back to this soon, since Ember 3.11 includes many of the pieces I need to move this to Octane.

Update; Sorry for the delay here, still very excited to get this addon to Octane Edition. Unfortunately work and family time have gotten in the way. At this point I won't be able to get back to version 3.0 of this addon until September. But Ember now has a plan for the Octane release! (Roughly October 2019)

Again sorry for the delay, I will be able to get to this starting next week and already have some rough code in a local (offline) fork.

Hey @Panman8201  ... I am wondering if there is a plan to release a new version with the update to Froala 3.0 without all of the other work that needs to be done on the ember side?
https://www.froala.com/wysiwyg-editor/docs/migrate-from-v2
The migration seems like not much has changed...and I am thinking all of the Ember stuff you wanna do (that sounds awesome btw) could take a while. We have been waiting to upgrade to 3.0 since it came out but we are still waiting on this addon to get updated.
So yeah that was my question...just have a release in the meantime the ember upgrades get worked out.
Thanks.

@tavosansal Technically, yeah, it wouldn't be too hard to do (mainly just changing the initialization of it). I'm actually nearly done with the update (except docs). Just need the weekend to wrap things up and ensure I have the Octane patterns lined up. But it does also come at a cost of backwards compatibility (3.13 due to tracked properties). Are you needing to use it with an older version? I thought about also making a version that uses Ember Component for longer backwards compat.

@Panman8201 Oh wow...sounds like you got pretty far already! We are currently on Ember 3.12 so yeah, no tracked properties. It might be nice to have a longer compat version. I know we are probably not the only ones that will take us a bit to adopt the new style. Our codebase is pretty large.
I could help with that a bit if you give me some pointers. I just cloned the repo.

@tavosansal I've just published 3.0.0-alpha.1 with the v2 addon format (using Ember Component) but with Froala Editor v3. You can checkout the v2-with-froala-editor-3 branch to see the differences. You'll probably want to lock at that specific version since I'll be releasing beta's with Glimmer Component and it'll probably have breaking changes.
That felt good, probably should have done this long ago...

Ryan (@Panman8201) Thank you so much for doing this. We appreciate it a ton.

+1 for Froala 3.x for Ember ;-) thanks guys!

Thanks for putting this together, going to try this in our app soon. We found a bug in the latest version of 2.X that is preventing us from shipping a core feature and after contacting support, upgrading to version 3 is their suggested resolution.

Tried out the alpha today worked super well. Drop in replacement with no changes needed (other than option differences between froala v2 and v3).
Only thing is I am getting build warnings for both of our languages
Warning: ignoring input sourcemap for node_modules/froala-editor/js/languages/fr.js because ENOENT: no such file or directory, open '/var/folders/g4/qxspl7qx4q77mxb5h1mh7n7w0000gq/T/broccoli-85586iJ9Zov7oMaDN/out-824-broccoli_debug_debug_3_vendor_js/node_modules/froala-editor/js/languages/fr.js.map'
Warning: ignoring input sourcemap for node_modules/froala-editor/js/languages/es.js because ENOENT: no such file or directory, open '/var/folders/g4/qxspl7qx4q77mxb5h1mh7n7w0000gq/T/broccoli-85586iJ9Zov7oMaDN/out-824-broccoli_debug_debug_3_vendor_js/node_modules/froala-editor/js/languages/es.js.map'

We this config:
'ember-froala-editor': {
      languages: ['fr','es'],
      themes: 'gray'
    },

The language files seem to be included (or at least they are working).

@jrjohnson humm... interesting. It's trying to pull in the map file for some reason, when there aren't any. They're working because the language files actually exist. What version of ember & ember-cli are  you on? Also, is there a larger stacktrace you can post?

I'm not sure how to get more stack trace out of ember serve. That's the entirety of the output.
It's reproducible with ember-cli 3.13.1 as:
ember new test-app
cd test app
npm install<EMAIL_ADDRESS>--save

add
'ember-froala-editor': {
      languages: ['fr','es'],
      plugins: false,
    },

to ember-cli-build.js
npm start

I'm having some trouble with testing as well.
We use ember-cli-page-object so I've always had a custom version of the fillInFroalaEditor.
It doesn't seem to be possible any more to attach to the running editor to fill in / extract the value.
Using new FroalaEditor on the same DOM node as the original just creates a second copy of the editor. I have a support conversation going with Froala about this and you can see what that that looks like in this example Not sure if you're working around this somehow in the test-helper here that I just don't understand.

@jrjohnson Interesting, I changed the test helper to basically do the same thing and thought it was working properly but maybe not. If there is no way to get the editor instance otherwise, then yeah, that'll be a problem for any sort of testing. Realistically, it would be nice to mimic keyboard input into the editor, but I ran into problems when trying to do that previously. I don't see an open issue on the Froala Editor repo, so let me know what you hear back from your support ticket. I'll also try to reproduce the sourcemap error, but I suspect it's an upstream issue since nothing  has really changed with the importing process of this addon...
In other news, Glimmer Component work is coming along in the v3 branch. Just a few things left to add and then I should be able to cut the first beta. (I'll keep Ember Component stuff as alphas.)

Was able to track down the source map warning cause and added a comment to https://github.com/froala/wysiwyg-editor/issues/3665. TLDR there is a //# sourceMappingURL=es.js.map reference at the end of each language file, but that map does not exist because the files are not actually minimized.

Awesome, thanks for the detective work. Let me know what you hear back about the double editor with initializing on the same element (using the test helper). That's the last bit for me to work through with the v3 branch, then I'll be releasing betas. (This week sometime.)

Finally worked out a way to get into the running editor instance with support. It's a bit ugly, but you can see what they suggest here: https://jsfiddle.net/ilyasfroaal/p7ahjqb9/1/
In my page object helper I have access to the DOMElement and ember adds an ID to every classic component so my resulting helper code looks like:
getEditorInstance(element){
  return new Promise(resolve => {
    later(() => {
      const { INSTANCES } = FroalaEditor;
      const ourInstance = INSTANCES.find(instance => {
        const instanceElement = instance['$oel'][0];
        return instanceElement.id = element.id;
      });
      resolve(ourInstance);
    });
  });
}

This seems to be the only way to call html.set() and have it trigger the contentChanged event (and anything else that is bound on the original editor). I'm not sure if this will play well with CSS selectors and it's probably going to be an issue when moving to glimmer components which do not have an ID attribute automatically.

npm install<EMAIL_ADDRESS>--save-dev

Is this still the latest alpha, and is there anywhere I can go to follow along on this process? I'm planning to try this in my app soon, because it's my last dependency on jQuery 🥳
Anything I can do to help other than provide feedback when I try the alpha?

@dbollinger yes, that alpha is the only release with v3 ATM. I'm focusing releasing a beta today or tomorrow, working through the test helper issue that @jrjohnson highlighted above, then checking on maximizing backwards compatibility. What version of ember is everyone using here?

What version of ember is everyone using here?

Ember: 3.7.1

What version of ember is everyone using here?

I have apps ranging from 3.4 to 3.14 -- for me personally, support for anything older than 3.8 would be "nice-to-have".

Also, what is everyone's thoughts on requiring @content to be a SafeString from htmlSafe()

My instinct is to agree with this, but maybe a dev assertion would be a good starting point? I'm pretty sure my team's implementation wraps the component and enforces safe stings.

Alright, version 3.0.0-beta.1 is out! Unfortunately I'm waiting on a setComponentTemplate() polyfill to support anything prior to 3.13. 😢 But I think this should work back to 2.18 once that is out. Take a look at the README for details on what's changed. The docs site is not updated at this point, next task is to tackle ember-cli-addon-docs.
@jrjohnson I was able to make the test helpers not even need the editor instance by creating a wrapper around the build-in fillIn() helper. It was actually easier/simpler than I had expected. But I did also work through the access to the editor issue with the example you provided.

Forgot to mention, very open to feedback, none of this is set in stone.

That's fantastic @Panman8201! Love it.

Latest update, I'm waiting to get the backwards compatibility stuff in before releasing 3.0.0 proper. Still waiting on that setComponentTemplate() polyfill, which will drive how far back compatibility goes. At this point I have it working back to 3.4, which is where the ember-native-class-polyfill support ends.
FWIW, the back-compat PR #82 is green but I don't want folks to have to re-export the template when extending <FroalaEditor>. So that's where setComponentTemplate() comes in...

FYI, just finished a couple releases;

v3.0.0-alpha.2 to fix the fillInFroalaEditor() test helper
v3.0.0-beta.4 to include backwards compatibility back to ember 3.4

Folks who need to stick with v2 of this addon but want to use Froala Editor v3 can use the alpha. Otherwise work your way towards the betas, which use Ember Octane methodologies and specifically Glimmer Components.
Notes with beta 4;

When extending the <FroalaEditor /> you'll need to re-export the template from your app (see the example in the README) until the setComponentTemplate() polyfill is available
If you're upgrading from v2 and using ember < 3.10 you'll want to run the default blueprint (if not doing ember install ember-froala-editor) to get the other required polyfills. ember g ember-froala-editor

I'm going to close this case since v3 compatibility is now in releases. Feel free to open a new case for specific issues and/or discussion, I'd be happy to chat.

i am using ember-froala-editor v3.0.0-alpha.2 with froala-editor 3.1.1 ..............application runs after removing jquery as mentioned in the tag release notes like below
$.FroalaEditor.RegisterCommand('myButton', {});
to
FroalaEditor.RegisterCommand('myButton', {});
but when i run the test cases which throws error like
bootstrap.js:127 Uncaught TypeError: Cannot read property 'DEFAULTS' of undefined
got error on below line in ember-froala-editor
if (Ember.$.FroalaEditor.DEFAULTS.hasOwnProperty(propertyName)) {

i am using froala 3.1.1 and ember-froala v3.0.0.alpha-2.
error occurred while getting instance on didUpdateAttrs hook. only partial instance is seems to be loaded... editor.html return undefined

@Srinivasan-Natarajan The 3.x alphas here actually have Froala Editor 2.x, they were a way for folks to use Froala Editor 2 with Glimmer Components in Ember. I'd suggest using the latest beta here for now (which has Froala Editor 3) until we can release a stable version (the latest beta is "stable" at this point).

@Panman82 hi we are still using older way to extending the component. will it work on beta?
import FroalaEditorComponent from 'ember-froala-editor/components/froala-editor';
export default FroalaEditorComponent.extend({
options: {},
'on-blur': function() {}
});

@Srinivasan-Natarajan Yes, you are still able to apply default options and event handlers, but the export line has changed since it comes from the Glimmer Component class now. See "Extending <FroalaEditor> component" in the README: https://github.com/froala/ember-froala-editor#extending-froalaeditor-component


Fix incorrect issue filter in user dashboard

Fixes https://github.com/go-gitea/gitea/issues/22799
Changes:

Fixed logic problems when filtering issues.

Avoid displaying all issues of the repo which user only created an issues/be mentioned/be assigned
Team permission doesn't work

Display all issues count info in repo filter to avoid displaying strange ui as following:

(selected a repo in repo filter which have no issues created by user, then access created by you)
After fix:

Got the sql in mssql. Have no idea with the error.

sql
SELECT
    issue.repo_id AS repo_id,
    COUNT(*) AS count
FROM
    [issue]
    INNER JOIN
        [repository]
    ON  [issue].repo_id = [repository].id
WHERE
    (
        issue.is_closed = ?
    )
AND (
        issue.is_pull = ?
    )
AND repository.is_archived = ?
AND (
        repository.owner_id = ?
    OR  issue.repo_id IN(
            SELECT
                [access].repo_id
            FROM
                [access]
                INNER JOIN
                    repository
                ON  [repository].id = [access].repo_id
                INNER JOIN
                    user
                ON  [user].id = [repository].owner_id
            WHERE
                [access].user_id = ?
            AND [access].mode > ?
            AND (
                    (
                        [user].type = ?
                    AND (
                            [access].repo_id IN(
                                SELECT
                                    [team_repo].repo_id
                                FROM
                                    team_repo
                                    INNER JOIN
                                        team_user
                                    ON  [team_user].team_id = [team_repo].team_id
                                    INNER JOIN
                                        team_unit
                                    ON  [team_unit].team_id = [team_repo].team_id
                                WHERE
                                    [team_user].uid = ?
                                AND [team_unit].[type] = ?
                                AND [team_unit].[access_mode] > ?
                            )
                        OR  [access].repo_id IN(
                                SELECT
                                    repo_id
                                FROM
                                    [collaboration]
                                WHERE
                                    [collaboration].user_id = ?
                            )
                        )
                    )
                OR  [user].type = ?
                )
        )
    OR  (
            repository.is_private = ?
        AND issue.id IN(
                SELECT
                    issue_assignees.issue_id
                FROM
                    issue_assignees
                WHERE
                    issue_assignees.assignee_id = ?
            )
        )
    OR  (
            repository.is_private = ?
        AND issue.id IN(
                SELECT
                    issue_user.issue_id
                FROM
                    issue_user
                WHERE
                    issue_user.is_mentioned = ?
                AND issue_user.uid = ?
            )
        )
    OR  (
            repository.is_private = ?
        AND issue.id IN(
                SELECT
                    issue.id
                FROM
                    issue
                WHERE
                    issue.is_pull = ?
                AND issue.poster_id = ?
            )
        )
    )
GROUP BY
    issue.repo_id

Try to quote all names, like user, mode, type.

Hmm, CI passes. That's why I recommend to use two words for variable names / table names / column names @lunny It saves a lot of debugging time.
ps: the SQL seems quite complex ......

Hmm, CI passes. That's why I recommend to use two words for variable names / table names / column names @lunny It saves a lot of debugging time.
ps: the SQL seems quite complex ......

Yes, too complex.

It works now.
Then the next step is improving the SQL. 😄

Should re-test, I recall @lunny made some recent changes surrounding filters that may impact this.

Should re-test, I recall @lunny made some recent changes surrounding filters that may impact this.

These changes broke this PR.

Simplified the SQL in UserUnitAccessRepoCond, as I found AccessibleRepositoryCondition function which is what I need.

I think this has been replaced by #26657 ?

@yp05327 What do you think, can this PR be closed?

After update go version to 1.21.0 in my dev container, I can't run Gitea correctly now, so it will take some times for me to confirm this. 😕

Get it worked!
Then it seems that there's some new problems. I can not see some issues created by the user:
(these two screenshots come from Testuser)

As we have rewrite the search engine for issues, I will close this PR.
But there are still some issues now, and I think we need to add more CI tests.


"Replace Next" never dismisses

version 1.0.11

Duplicate of atom/find-and-replace#501, please subscribe there for updates.


truncate collection slowly

my environment running ArangoDB
I'm using the latest ArangoDB of the respective release series:

[ ] 2.8
[ ] 3.0
[ ] 3.1
[x] 3.2
[ ] self-compiled devel branch

Mode:

[x] Cluster
[ ] Single-Server

Storage-Engine:

[ ] mmfiles
[x] rocksdb

On this operating system:

[ ] DCOS on

[ ] AWS
[ ] Azure
[ ] own infrastructure

[x] Linux

[ ] Debian .deb
[ ] Ubuntu .deb
[ ] SUSE   .rpm
[ ] RedHat .rpm
[ ] Fedora .rpm
[ ] Gentoo
[ ] docker - official docker library
[x] other: CentOS 6

[ ] Windows, version:
[ ] MacOS, version:

this is an AQL-related issue:
[x] I'm using graph features
I'm issuing AQL via:

[ ] web interface with this browser:     running on this OS:
[ ] arangosh
[x] this Driver: Java

Truncate a collection that has more than ten million documents very slowly.

Yes, its a known issue.
Deleting and re-creating collections is much faster.

[edit] - the situation may improve with 3.2.7 and 3.2.8.

Hi @stuxuhai,
FYI version 3.2.9 has been released a few days ago.
It would be useful to know if the performance improved in newer versions?
Thanks

@maxkernbach
It looks the performance improved. And the version we upgraded to is 3.2.8, we will consider upgrade to version 3.2.9 later.

Hi @matcho,
ArangoDB 3.4 RC 1 has been released, which includes performance improvements. You can find the ArangoDB 3.4 RC 1 here. Let us know your feedback!
Thanks!

I just tried tried truncating a 15M docs collection via arangosh, on arangod 3.4 RC 1.
It resulted on a server crash/restart :/
First time I issued the command, it took ~ 4mn to crash; all subsequent attempts resulted in an immediate crash.
Arangosh output
db.images.truncate();
End of file
JavaScript exception in file<EMAIL_ADDRESS>at 99,7: ArangoError 2001: Connection reset by peer
!      throw error;
!      ^
stacktrace: ArangoError: Connection reset by peer
    at Object.exports.checkRequestResult (/usr/share/arangodb3/js/3.4.0/client/modules/@arangodb/arangosh.js:97:21)
    at ArangoCollection.truncate (/usr/share/arangodb3/js/3.4.0/client/modules/@arangodb/arango-collection.js:506:12)
    at <shell command>:1:11

Arangod.log
2018-09-28T14:35:08Z [32761] INFO using endpoint 'http+tcp://<IP_ADDRESS>:8529' for non-encrypted requests
2018-09-28T14:35:08Z [32761] INFO ArangoDB (version 3.4.0-rc.1 [linux]) is ready for business. Have fun!

---- crash happens here but nothing visible in log ----

2018-09-28T14:35:47Z [622] INFO ArangoDB 3.4.0-rc.1 [linux] 64bit, using jemalloc, build tags/v3.4.0-rc.1-0-g99e0d2026b, VPack 0.1.31, RocksDB 5.16.0, ICU 58.1, V8 5.7.492.77, OpenSSL 1.1.0h  27 Mar 2018
2018-09-28T14:35:47Z [622] INFO detected operating system: Linux version 4.15.0-33-generic (buildd@lcy01-amd64-024) (gcc version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)) #36-Ubuntu SMP Wed Aug 15 16:00:05 UTC 2018

Hi @matcho,
we would like to investigate your findings. Could you please provide the following information:

How did you create the collection?
Are you still using a standalone instance with RocksDB as described in your previous comment or a different setup? Is there a replication running?

Hi @maxkernbach
The collection was created a long time ago (like 8 months or so) on version 3.2 I guess, and the server was gradually upgraded until 3.4 RC1.
It is a standalone instance, running on my Ubuntu 18.04 dev machine, with RocksDB.
There is no replication running.

@matcho would it be possible to get a dump with the structure of the collection at least (or a complete dump with data as well) so we can try to reproduce the issue with your exact dataset?
You could send us a message to<EMAIL_ADDRESS>(this ML is not public) and attach the dump in that email, or if it is too big we will reply to your email and provide a password protected folder where you can upload the archive. Please reference the number of this issue in your email
Many thanks,

Hi @sleto-it
I tried dropping / recreating the collection from an existing dump, then truncating it again, same issue : after around 100s server restarts.
After logging-in again to aardvark (server restart logged me out), I see the collection but can't access the documents: the waiting (ping-pong) animation shows, and after a while I see an empty page saying "no documents". But, the documents count at the bottom left still says 21,558,956 doc(s)
In the log I can see
WARNING {queries} slow query: 'FOR x IN @@collection LET att = APPEND(SLICE(ATTRIBUTES(x), 0, 25), "_key", true) LIMIT @offset, @count RETURN KEEP(x, att)', bind vars: {"@collection":"img","count":10,"offset":0}, took: 69.167400 s

"Indexes" and "Info" views in aardvark show correct information, indexes are still present.
Sending you a message right now !

@matcho Thanks for providing the requested dump. I could reproduce the error exactly as you described by restoring the provided dump with version 3.4 RC1 (silent server crash + same error message). Using the latest version 3.4 RC2 the truncate ran multiple times without any problems though.
This issue might already be resolved, could you please retry with version 3.4 RC2?

@maxkernbach After the failed truncate() in 3.4 RC1 the collection was inaccessible (see my previous message).
I updated to 3.4 RC2, tried truncate() again from arangosh, it worked ! In around 3 minutes collection was truncated and accessible again.
Thank you very much !

thanks to you for the feedback @matcho and to anyone involved - glad it works now
we are now closing this ticket
thanks again,


[HOLD for payment 2023-06-21] [$1000]  'Link sent!' message is not dynamically updated when changing language preference

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Add a secondary login account, and leave it unverified
Open new tab
Navigate to sign in page
Enter the unverified email address
Click on Unlink button
Verify that 'Link sent!' message is displayed
Scroll down, and select Spanish as a language preference

Expected Result:
'Link sent!' message should be dynamically updated to Spanish
Actual Result:
'Link sent!' message is not dynamically updated to Spanish
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/2f37361c-60f6-4de9-8b6c-a1e93a3b3b99
Expensify/Expensify Issue URL:
Issue reported by: @natnael-guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683649359591549
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0198d8720bb9bfb004
Upwork Job ID:<PHONE_NUMBER>961388544
Last Price Increase: 2023-05-18

Proposal
Please re-state the problem that we are trying to solve in this issue.
Link sent isn't changed dynamically on language change
What is the root cause of that problem?
In the onyx success message we are storing the translated message so it won't get updated on language change.
https://github.com/Expensify/App/blob/6d27757667e0757d02a390623c072c69238c7070/src/libs/actions/Session/index.js#L713
What changes do you think we should make in order to solve the problem?
We should store the translation key in the onyx successData message instead of the translated value and In the component, we need to use this translation key to get the value which makes the text language specific.
https://github.com/Expensify/App/blob/6d27757667e0757d02a390623c072c69238c7070/src/pages/signin/UnlinkLoginForm.js#L65-L69

Discussing in slack
https://expensify.slack.com/archives/C049HHMV9SM/p1683937177713499?thread_ts=1683649359.591549&cid=C049HHMV9SM

Ok, got the go ahead yesterday on moving this forward in that slack thread above.

Ok, got the go ahead yesterday on moving this forward in that slack thread above.

@kevinksullivan if this is something that can be fixed, it might be a good idea to fix this issue too here - with a single PR. The issue I have referenced here has the same nature as the one that is being fixed here.

I'm willing to fix similar issues together as I mentioned in proposal
cc @parasharrajat @cristipaval

Offers sent in upwork @parasharrajat @Pujan92

Sorry for the delay @parasharrajat , just raised a PR.

@parasharrajat  wanted to check in on this since it's been a bit (hope you're feeling better!).  I see some comments from 3 days ago. What's your ETA for  finishing this out?

@Natnael-Guchima @parasharrajat @Pujan92 please accept the offer in Upwork when you get a chance. Thanks!

@kevinksullivan it seems you have sent me a $1000 offer by accident

Thanks @Natnael-Guchima , I modified the amount on the offer.

@parasharrajat bump on accepting offer, and can you complete the checklist above before we pay this out?

You are welcome 🙌. Accepted the offer, thanks.

bump @parasharrajat

Paid out. Thanks everyone!


Added Model Adaptation Tool to use with embARC MLI Library 2.0 for ARC

[10/11]
This PR adds ARC specific Model Adaptation Tool required for new MLI 2.0 layout.
BUG=#86

We recently added Python formatting to the Code Style checks. Instructions on how to get that set up are at: https://github.com/tensorflow/tflite-micro/blob/main/CONTRIBUTING.md#initial-setup
You can fix all the formatting errors with:
tensorflow/lite/micro/tools/ci_build/test_code_style.sh --fix_formatting

Please note that you should delete the pigweed folder prior to trying this out:
rm -rf tensorflow/lite/micro/tools/make/downloads/pigweed

and add a pre-push hook with
cp tensorflow/lite/micro/tools/dev_setup/pre-push.tflm .git/hooks/pre-push

We recently added Python formatting to the Code Style checks. Instructions on how to get that set up are at: https://github.com/tensorflow/tflite-micro/blob/main/CONTRIBUTING.md#initial-setup
You can fix all the formatting errors with:
tensorflow/lite/micro/tools/ci_build/test_code_style.sh --fix_formatting

Please note that you should delete the pigweed folder prior to trying this out:
rm -rf tensorflow/lite/micro/tools/make/downloads/pigweed

and add a pre-push hook with
cp tensorflow/lite/micro/tools/dev_setup/pre-push.tflm .git/hooks/pre-push

Hi Advait, sorry, this command do nothing for me. Tried on windows machine.

@advaitjain Figured that out, thank you.

Hi, @advaitjain can you please merge this one? Thank you!


PR for Issue #180 - updating the hacktoberfest image

Addressing issue : Improve the hacktoberfest image in Readme.md #180
Improved the quality
also added the solidity-pathshala logo in it to make it look cool
Also please tag it for SWOC contribution.
Thank you

Great ! Looking forward to see more contribution like this from your side .


Merge develop into master

Pull Request Test Coverage Report for Build 17

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 13:
0.0%

Covered Lines:
0

Relevant Lines:
7

💛  - Coveralls