Remove unnecessary assignment

This assignment achieves nothing because p is copied by value.
The compiler will always eliminate this line through reaching definition analysis.

Why would someone try to free it?
Remember it's just a local copy of the pointer, this isn't setting the pointer that was passed to Free to nullptr, it's setting the local copy to nullptr.
The next thing that happens to it after being set to nullptr is that it's discarded because it falls out of scope when the function ends, hence it's a wasted assignment.

It is good c++ style to null pointers after freeing them.  Even if only as a form of documentation.

@adrian3git It depends on how the pointer is being used.
If the pointer's lifetime is about to end anyway, then its final value is irrelevant.
p is just a copy of the pointer passed in, not the original pointer.
When the function returns, p ceases to exist, so its value prior to being destroyed is inconsequential.
In other words, if someone were to do this:
// allocator is a b2StackAllocator
void * object = allocator.Allocate(1024);

// ...

allocator.Free(object);

Then object itself would not be a nullptr after the call to Free, it would still have the same value as it did before.
If the intent was to nullify the passed in pointer then p would have to be defined as void * & p (a reference to a void *).

Setting pointer to nullptr make checking errors easier. If you try method from nullptr the you get exception right away. But if you try from free memory then you get exception only if you have allocated this part to something else.  And you can get exception if this part of memory was returned to the system.

@Pharap:  It is funny I have been programming in C++ for 20 years, so starting to call null pointers a nullptr one fine day gives me a bit of a headache.  Please just call it null as god and computer science intended it.
Look, we are discussing style and so you are completely welcome to your opinion.  However this opinion about pointer safety won't make you many friends among professional C and C++ programmers.  Pointer safety is a topic people tend to get a bit superstitious about.

@1aam2am1
It only makes error checking easier if the pointer is going to be reused later.
In this case it isn't going to be reused (and shouldn't be reused).

@adrian3git
Like I said, the parameter ceases to exist, so the line setting it to nullptr is a waste of time.
If the pointer is being stored in a register then that register will soon be used for something else.
If the pointer is on the stack then the stack frame is about to be destroyed anyway.
(Technically speaking the pointer's 'destructor' will be called as well, but the destructors of all fundamental types are just 'nops', so that doesn't really have a bearing on anything.)
And as I said before it won't affect the pointer being passed to the Free function, which is the thing that people ought to be worrying about.
(Though as that will most likely be in user code, it's almost certainly out of the library's hands anyway.)

However this opinion about pointer safety won't make you many friends among professional C and C++ programmers.

Every programming establishment has different style rules.
What's common practice in one place will be considered unthinkable elsewhere.

Pointer safety is a topic people tend to get a bit superstitious about.

Computer science should be about science, not superstition.
The rules about what happens here are well defined by the language specification.
And at any rate, if setting a pointer to nullptr after a delete or free prevents a bug then usually assigning nullptr is not actually a solution to that bug, it's merely masking the bug - the bug itself still exists.

I clearly have too much time on my hands right now.  :)
You have argued a series of technical points that I already completely agree with.
The only disagreement we have is about “style.”  And you already argued that style is a matter of opinion and feel that opinion varies widely.  But simultaneously won’t accept the style of the author of this codebase.  Extend the maintainers the courtesy of agreeing to disagree about a matter of preference.  This is a free service and picking a huge debate over something you keep arguing doesn’t matter doesn’t encourage people to publish their work for free.

But simultaneously won’t accept the style of the author of this codebase

How are you sure that this is the style of the code base?
I see no styleguide, and I have found very little evidence that this is part of the code's 'style'.
In fact I have found evidence to the contrary:
https://github.com/erincatto/Box2D/blob/ac9aaf2d5cba345a6ed116b27d587a26c48ecf86/Box2D/Common/b2GrowableStack.h#L57
Which is why I have assumed this was a mistake.
If there is some unwritten style guide, then perhaps that piece of code is the real 'mistake'?

Extend the maintainers

I have no idea who the maintainers are. I can find no list identifying them.
Every source I can find identifies "Erin Catto" as the maintainer, with no mention of anyone else.
I assume @jcs090218 is a maintainer given that they have been assigned to review the PR,
in which case is it not up to them to reject my PR?

picking a huge debate

I have merely reiterated my reasoning behind the change.
And of course, one cannot debate alone.
I did not 'pick' this debate, I have merely responded to the comments left by others.

If one of the maintainers wishes to reject and close this PR then they are free to do so and I will accept that decision.

In this case the pointer is going out of scope on the next line. If this was a larger function I agree that it makes sense to set it to null. I feel like this change is a subjective or stylistic change. It doesn't fix a bug. I'm guessing static analysis tools would not have a problem with the existing code either.
I also agree that we make this change here, then we would want to do this everywhere to be consistent. That would be a lot of code changes for no benefit other than style.

No I’m just bored.  Normally I consider the style guide to be the pattern’s in the code itself.  Possibly a controversial opinion, but nobody ever complains that my work doesn’t follow the style guide...   Which I haven’t read.  :)  But I would recommend looking at the Google style guide, it has a lot of good advice that you would learn the hard way.  Anyway, thank you for the random internet debate over nulling a pointer.  I’m going to get back to work now.

@erincatto
I did a search of nullptr. The vast majority of use cases are in constructors.
I found only one other place where a pointer was being set to nullptr before its lifetime ended, which suggests to me that it's the exception rather than the rule.
Unless GitHub's search feature is more limited than I'm expecting, "everywhere" doesn't appear to be many places.
All other nullptr use cases were cases where the variable was being reused (e.g. because it was a member variable).
From what I have read, the two cases where the pointer is explicitly set to nullptr as an attempt at cleanup appear to be the exception rather than the rule.
At any rate this is indeed a stylistic change.
If you are unconcerned with stylistic changes then by all means simply close the PR.

@adrian3git
I have read a relatively significant amount of the Google style guide before.
Enough to know that there are parts that I quite agree with and parts that I vehemently disagree with, as is the case with most style guides.
I'm far more interested in the C++ Core Guidelines.

@pharap I was force fed so much nightmare code over the years in the games industry that I managed to become somewhat dead inside when it comes to code.  It is easier that way.  However I also work on my own projects where I can take the time to do things right to remind myself of how satisfying it can be to have the time to do things right.

Thanks for the thoughtful comments. Closing.

Thanks Erin.  Sorry for trolling your PRs.  :)


youtube dash audio stream fixup is 55 times slower with ffmpeg 6.1.1 than 5.1.2, is this an ffmpeg bug or are fixup params no longer correct?

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
To repro you need to download a dash audio stream (m4a) of a recently completed live broadcast. Since dash streams are removed after a bit, I don't have a url. Save the unfixed m4a and then run the fixup command with ffpmpeg 5.1.2 and 6.1.1.
5.1.2: speed= 206x
6.1.1: speed=1.14e+04x (11400x)
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

FixupM4a is just a stream copy remux. This is an ffmpeg issue

I'm ok with ffmpeg 5.1.2 for now. In case you have any interest in confirming and reporting it:

go to the youtube live tab
pick a current stream and wait till it ends
for some time the audio should be available only as a dash stream
download it without fixup
execute the fixup command with ffmpeg 5.1.2 and latest
if the problem is present, this file can be used in a ffmpeg bug report


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade" workflow

AWS CodeBuild CI Report

CodeBuild project: GitHubPipelineAutoBuildProj-XK8ItpxnSow5
Commit ID: 9f8b369c66365e1cbdf2e297d261aeee8e876a34
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Add flags for expensive path algorithms

Added flags to disable request deduplication and path collapsing.

Coverage decreased (-0.1%) to 92.42% when pulling 1e661d1acfee64d93e0ff1782f2d70413213e2a9 on jcranendonk:feature_flags into 17db57d14ddf2c47519529a38b2e1d9c39c74e30 on Netflix:master.

just adding tests would be great, otherwise looks good!

Other than the minor nitpicks I made, looks good!


[VSCode] vsls npm package looks for a somewhat "hard-coded" file path

Product and Version [VS/VSCode]: VSCode
OS Version [macOS/Windows]: Windows 10
Live Share Extension Version: 0.3.954
Target Platform or Language [e.g. Node.js]: Node.js?
I'm using the live share npm package and running into a bundling issue with webpack. I am bundling all my node_modules into my bundle and because of this code:
On line 43 of vscode.ts in the vsls package
    const liveShareApiVersion = require(path.join(__dirname, 'package.json')).version;

Since this code is looking for hard paths (and it won't find them when bundled) it will throw, making any call to getApi unusable.
I'm not sure what the right workaround is here -- maybe the best solution is to just add a version parameter to the getApi call that avoids that code altogether if specified?
/cc @lostintangent

@eamodio Out of curiosity: if you set this property to false in your Webpack config, would that unblock it? That's obviously not a great workaround. I'm just curious, since I'd assume Webpack could successfully bundle JSON files that are required, as long as the paths can be resolved.
That said, we'll look into this and see how we can enable both Webpack and non-Webpack-based consumers of our API. Thanks for reaching out with this issue!

@lostintangent I currently do have that set, but it doesn't help. I am completely bundling (and minifying) all the node_modules directly into my extension.js there is no actual file on disk.
P.S. I thought I posted this weeks ago 🤦♂

Any update on this?  I would LOVE to get rid of my build-time hacks to go in and hand edit this file.

The problem with the require above is that when there is an expression in the require call (or require is inside a function), webpack will try to resolve the expression and load the file from the file disk on the runtime. Of course, it will not work for you since you won't have the file on your disk when the app is running.
I've changed it to a relative path a month ago and moved it into the beginning of the file so it is not nested in a function anymore. This should fix your problem as it will pull the JSON into the bundle during the build:
[12] const liveShareApiVersion = require('./package.json').version;

Unfortunately, the module author is OOF this week(cc. @jasongin), so unless it is super urgent, we can publish the module update next week.
Cheers.

Thanks for the update. It is certainly not urgent (as I've been living with my hacks for months). Although while this should fix the issue, it does seem like overkill to be causing the bundling of the whole package.json just to extract a version number. It ends up bloating bundle size and wastes parsing time.

@eamodio agreed on the file size. We can ship the fix so you can omit to maintain the hacks on your side and then work on the optimization.

This issue is now resolved. Please update your extension to the latest version.


custom error message causes typeError

using zod v3.21.3
this code causes typeError, which is not wrong with previous version(v3.20.6).
const px =
  z.custom <
  `${number}px` >
  ((val) => /^\d+px$/.test(val as string), "custom error message");

error message
Argument of type 'string' is not assignable to parameter of type 'CustomParams | ((input: any) => CustomParams)'

here is my code sandbox link.
https://codesandbox.io/s/upbeat-williams-scfj81?file=/src/index.ts

Apologies, looking into this

This is fixed in Zod 3.21.4, but I'd recommend passing this value as a param called message instead:
const px = z.custom<`${number}px`>(
  (val) => /^\d+px$/.test(val as string),
  {message:"custom error message"}
);

Thank you for your quick response!!!


Fix multiple issues in the source code of mbedtls-2.7 found by check-files.py

Description
This PR fixes multiple problems found by the check-files.py script. It does for mbedtls-2.7 what #1446 did for development.
Specifically:
* incorrect file permissions
* missing newline at the end of files
* trailing whitespace
* Tabs present
* TODOs in the souce code
It MUST be merged before #1708, to avoid #1708 immediately breaking the CI as soon as it's merged.

Isn't this a backport?

This is taking the same actions as the similar PR that landed upstream (removing TODO comments and filing GitHub issues in their place). While I'd personally prefer the code to link to the GitHub issues instead of the comment deleted, this PR is doing the same thing the upstream PR did.

This isn't a backport in the normal sense, because I've actually created a whole new series of changes, they just happen to only apply to mbedtls-2.7.

@gilles-peskine-arm / @andresag01 - You're both willing to accept the PR, but are making the same points about the documents. Do you want me to raise an issue, and fix it through the issue?
cc: @Patater

@sbutcher-arm: What do you mean with:

Do you want me to raise an issue, and fix it through the issue?

You suggest raising a separate ticket to create another PR that adds the comments back in? (And probably remove the TODO word along the way to prevent the script from failing)

Hi @andresag01!
I mean, shall I raise a Github issue, requiring the documentation be addressed to clarify what we're about to remove?

@sbutcher-arm: My preference would be to not remove the comments in this PR. If the problem is that the TODO causes a failure on the checking script, then we could just remove that word. However, if you prefer to remove the comment then I am happy with your suggestion to create a ticket to document this properly (though I am not sure where if not the code as it was)...

My preference would have been to keep the comments (without “TODO” if you don't like having “TODO”, I personally don't mind, and obviously they must not be there if check-files rejects “TODO”), but that ship has sailed. I have a strong preference for keeping the comments identical in all maintained branches as long as the code has the same behavior. I think the comments do have value, but it isn't critical to keep them in today, so please file a ticket to restore them.


[RFC] initial support for configuring avcodec_h264dec

Dear Alfred,
since we have now the ability to do hardware accelerated encoding in the avformat module, I've also taken an attempt to implement it similar for the decoder side.
The code so far works, but still requires some discussion/extension to be fully usable, although it works with properly with "h264".
For my use-case the main open point is the pixel format returned by the decoder. I'd like to use hardware acceleration through Nvidias h264_cuvid module, which does return "NV12" pixel format, at least thats what I get so far with this implementation.
I've checked the ffmpeg sources, and the only available pixel formats for h264_cuvid are NV12 & CUDA.
My personal view is that it nv12 would be the way to go, since this is a much more widespread and used pixel format. I've also already checked the rem sources for more details. The questions arising from this are:
Is it the way to go to implement a nv12_to_rgb32() function in rem-0.5.0/src/vidconv/vconv.c?
Is there another way convert the pixel formats in case NV12 is returned, e.g. a combination of nv12_to_yuv420p & yuv420p_to_rgb32?
Best regards,
Harald

thank you for this nice patch
the baresip core should handle any supported pixel format that is passed in
from e.g. vidsrc or vidcodec decode (for example YUV420P or NV12).
any conversion needed will be done in baresip core
if the conversion from NV12 to RGB32 is missing, we can just simple add support
for it (in librem).

With the pixel format conversion added to rem h264_cuvid works now properly.
I have to mention that I couldn't test nv21_to_rgb32, but since nv12_to_rgb32 works, I assume that this will be fine as well.
Switching the decoder to h264_cuvid with X11 output and 720p h264 video with -e/vidloop_codec at approx. 20 fps the cpu power required drops from approx. 100% to approx 75% in total on my test machine. Both figures include window drawing on Xorg which uses approx. 25-30%. Looking at the baresip pid only the results in the same test are approx. 64% to approx. 52%.
720p video re-encoding with approx. 20-22 fps at approx. 50% cpu load on my old AMD Athlon(tm) II X4 615e is pretty cool.
hargut@benchvice:~/baresip.git$ ./baresip -e/vidloop_codec -v
baresip v0.5.0 Copyright (C) 2010 - 2016 Alfred E. Heggestad et al.
Local network address:  IPv4=enp2s0:<IP_ADDRESS>
ui: stdio
aucodec: PCMU/8000/1
aucodec: PCMA/8000/1
aufilt: vumeter
avcodec: using libavcodec H.264 encoder
avcodec: using h264 decoder by name (h264_cuvid)
vidcodec: H264
vidcodec: H263
vidcodec: MP4V-ES
avcodec: using h264 encoder by name (h264_nvenc)
vidsrc: avformat
vidisp: x11
medianat: stun
medianat: turn
medianat: ice
uuid: loaded UUID a7eaa70b-877c-6095-f8c8-27b1770f8985 from file /home/hargut/.baresip/uuid
Populated 1 account
module: loading app auloop.so
module: loading app contact.so
Populated 3 contacts
module: loading app debug_cmd.so
module: loading app menu.so
module: loading app vidloop.so
Populated 2 audio codecs
Populated 1 audio filter
Populated 3 video codecs
Populated 0 video filters
baresip is ready.
/vidloop_codec
Enable video-loop on avformat,/home/hargut/dwhelper/st-pl.mp4: 352 x 288
vidloop: avformat,/home/hargut/dwhelper/st-pl.mp4: open video source: 352 x 288 at 500 fps
avformat: stream 0:  1280 x 720   time_base=0/1
vidloop: open video display (x11.nil)
vidloop: enabled encoder H264 (500 fps, 5000000 bit/s)
vidloop: enabled decoder H264
avcodec: h264 encoder activated
avcodec: video encoder H264: 500 fps, 5000000 bit/s, pktsize=1480
avcodec: h264 decoder activated
[h264_cuvid @ 0x55ce8fbc0f00] Invalid pkt_timebase, passing timestamps as-is.
avcodec: video decoder H264 ()
Enabled codec: H264
reg: sip:hargut@home: Register: Destination address required
vidloop: codec decode: Bad messagePS=0.0      0 kbit/s
vidloop: codec decode: Bad message
vidloop: codec decode: Bad message
vidloop: codec decode: Bad message
Quitus: [H264] [H264]  intra=8  EFPS=18.9      4491 kbit/s
ua: stop all (forced=0)
module: unloading app vidloop
module: unloading app menu
menu: close (redial current_attempts=0)
module: unloading app debug_cmd
module: unloading app contact
module: unloading app auloop
Stopping 1 useragent..
ua: sip-stack exit
ua exited -- stopping main runloop
hargut@benchvice:~/baresip.git$

Kindly let me know your thoughts on the rem patch & this implementation. I'd be happy if it can be merged into baresip & rem.
Best regards,
Harald Gutmann

Hi @hargut
many thanks for your work.
I merged your patch to master. I also created a separate PR for librem:
https://github.com/creytiv/rem/pull/6
/Alfred

@hargut could you please re-testing using vanilla GIT versions
of baresip and librem:
https://github.com/creytiv/rem/commit/123003ffbc84301439dd68bf3c07fc3704b8eb3e

Works properly with baresip & rem at master.


Glossary

ditching forked repo and clearing up git index for clarity sake. thanks to @skipjack!

this also closes #1223

Added the frontmatter and a link to this page from the footer. @bebraw I also updated the cc-by license image to a slightly tighter one and pointed that to our /license page:

The other badge was causing some overflow and tightness on mobile.
If everyone's good with it, I think we should merge this sucker and then maybe add another pr to start linking to this page from various articles... and obviously if anyone else comes up with other key terms that would be great as well.

Ok let's merge, the build is only failing due to the fact that the edit link doesn't exist yet (but will once this is merged). If any issues slip in we can fix in a separate PR.


Namespace Selection

I'm submitting a question.
Short description of the issue/suggestion:
I would like to know if there's a standard/blessed way in Readium CSS to select elements with a namespaced attribute.
In ReadiumCSS-night_mode.css I see this:
:root:--night-mode *[epub\:type~="titlepage"] img:only-child {
  -webkit-filter: invert(100%);
  filter: invert(100%);
}

But in ReadiumCSS-base I see namespace declarations, which are supposed to enable [ns|attr="value"] syntax:
@namespace url("http://www.w3.org/1999/xhtml");
@namespace epub url("http://www.idpf.org/2007/ops");
@namespace m url("http://www.w3.org/1998/Math/MathML/");
@namespace svg url("http://www.w3.org/2000/svg");

So...  | or \: ?  (I am targeting something in the epub namespace, so it's declared, in case that's a question.)

Ah right thanks for catching this.
So 2 notes (and a bug fix to implement on my side).

the ReadiumCSS-base is compiled in a before.css dist stylesheet, the ReadiumCSS-night_mode.css in an after.css dist stylesheet so the namespace doesn’t apply for this selector – here’s why there are different stylesheets;
in theory it shouldn’t happen but in case it happens, ideally ReadiumCSS wants to handle content being served as text/html instead of application/xhtml+xml as well.

That said, escaping doesn’t work for XHTML so there should have been a namespace declaration in the after stylesheet + epub|type and I’ll correct this – but if you want to cover the “served as html use case”, I’d say both should be used.
I’ll make this correction later today directly in the develop branch.

Okay so basically:
[ns|attr="value"], [ns\:attr="value"] {
    // ...
}

Got it, not too hard.
There's a lot of discussion at https://github.com/readium/r2-navigator-swift/issues/113 so I'm not even sure if I'll proceed this way but good to know.


Update fish-shell submodule, fix stream_redirect grammar rule

After updating submodule parser failed to parse new autocompletion files introduced in this PR https://github.com/fish-shell/fish-shell/pull/8141

Thanks!


Build on Win10 using VS2019

What OS are you using (uname -a, or Windows version)?
W10
What programming language are you using (C/C++/Go/Rust)?
C++ using Win32 project template with VS2019
What did you expect to see and what you saw instead?
I get a massive compile error dump > 2000 errors.  Unclear what header/lib I'm not correctly including but clearly I'm missing a reference to something.  I discovered I had to install the WebView2 NuGet package to have access to the WebView2 header/etc even though I had a Win10 SDK installed it didn't include this file.
So, I installed the WebView NuGet and still get compiler garbage error log.  Has anyone built a simple Win32 project using VS2019?  There must be something I'm missing.  I'm not getting to LINK stage, so I'm missing a header/etc apparently....
I of course included the webview.h in my project.  Project builds and runs as soon as I remove the include statement for this library.

I get the same issue. It seems like the only build method we support is by running build.bat in the scripts folder.


Missing padding-top for Form and Viewer

Describe the bug

To Reproduce
Open  Form or Viewer
Expected behavior
The image has paddings at the top and bottom as shown below<EMAIL_ADDRESS>
Your Environment
- pdfme package(@pdfme/generator or @pdfme/ui): @pdfme/ui
- pdfme version: 3.0.0-beta.2
- Operating system: MacOS
- Node.js version or Browser name & version: Google Chrome Version 118.0.5993.117 (Official Build) (arm64)

Your Error Log
No log

Additional context
No response

I removed this in the last PR (unintentionally).
If you are not already looking at it, I can fix this @hand-dot ?

I can fix this @hand-dot ?
Of course!


fix(material-experimental/theming): prefix elevation mixins with mdc

This adds an mdc- prefix in the _index.scss public API for material experimental. Without the prefix, this collides with the older elevation mixins. This collision is a problem in Google where we export both APIs through a combined entry-point.

Marking as merge safe because I ran a presubmit for this and nothing was affected


added image mask support

Support for image mask functions:
playdate.graphics.image:setMaskImage(maskImage)
playdate.graphics.image:getMaskImage()
Implemented in Love2D using stencil canvas drawing.
Documentation:
https://love2d.org/wiki/love.graphics.stencil

@pouleyKetchoupp Heya! Sorry this fell off my radar. If you reopen it, I'll try to get around to reviewing & merging it sometime soonish.


proposal: vet should warning on uncertain results caused by unspecified expression evaluation orders

As some evaluation orders in multi value assignments are unspecified,
the following two programs may print either 0 123 or 123 123.
package main

import "fmt"

func f(p *int) int {
	*p = 123
	return *p
}

func main() {
	var x int
	y, z := x, f(&x)
	fmt.Println(y, z)
}

package main

import "fmt"

func f(p *int) int {
	*p = 123
	return *p
}

func g(x int) (a, b int) {
	return x, f(&x) // <=> a, b = x, f(&x); return
}

func main() {
	fmt.Println(g(123))
}

I propose that go vet should warn on such use cases to avoid unexpected behaviors.

Is vet sufficiently smart to handle this?  Or do we need the equivalent of ubsan for Go?

One of the three vet criteria is frequency

y, z := x, f(&x)

how often do people write this kind of expression in real programs? Is this "evaluation-order confusion" actually source of a significant number of problems in the wild?

y, z := x, f(&x)
how often do people write this kind of expression in real programs?

There are many variants of the case in the above examples.

@dgryski

Is vet sufficiently smart to handle this?

Yes, I also think it is really hard for vet to detect some special such cases.
For example, it is hard for vet to determine whether or not p1 and p2 store the same address.
func f(p1, p2 *int) {
	y, z := *p1, f(p2)
	fmt.Println(y, z)
}

If this proposal is unpractical, I would make another proposal to remove the unspecified behavior.

In fact, sometimes, I feel that Go compilers should report a compilation error instead of a vet warning for the case in my starting comment. Because that code is definitely bad for sure.

There are many variants of the case in the above examples.

Yes... but you wrote those examples, except for the one from #25609, which is the only report by someone being bitten by this. What I asked is if this is actually a common source of errors; that's what the 3rd vet criteria asks for:

A new check that finds only a handful of problems across all existing programs, even if the problem is significant, is not worth adding

I can't say it is uncommon. Please see the code modifications mentioned in this issue by tamird.

Vet can't answer this perfectly. As long as it only reported true errors, it would be OK to have false negatives. The question is: how much work is it to detect these?

/cc @alandonovan

The analytical firepower required to do this is far beyond vet.  Every statement of the form a[i] = f(x) is a potential mistake of this kind; to prove it safe you must show that f(x) doesn't modify a or i, which means you need to prove that a and i don't escape (an escape analysis), or that they do escape but they are not mutated by f(x), which is an even more complex whole-program analysis. Even the most trivial case in which f contains nothing but an assignment to a or i requires an interprocedural analysis, and I doubt it would uncover significant bugs; it would certainly discover all kinds of infeasible scenarios.
A better approach would be a dynamic analysis along the lines of the race detector: statically transform a statement such as:
a[i] = f(x)

into:
saved_a := a
saved_i := i
tmp := f(x)
if a != saved_a { fail() }
if i != saved_i { fail() }
a[i] = tmp

The trick would be to eliminate as many of these checks as possible for efficiency.

@alandonovan's example makes me more tend to think that this unspecified behavior is common used in practice and this is a fundamental design issue of Go. After all, Go, as a so called C+ language, one of its main goals is to remove as many unspecified behaviors in C as possible, in particular for the unspecified behaviors which may be common encountered.
I feel this unspecified behavior can be removed for sure, there are no technique obstacles to achieve it.
The only opposed opinion I have ever heard of is removing the unspecified behavior would make some obstacles for complication optimizations. I think we should evaluate the degree of the negative impact for complication optimizations by removing the unspecified behavior. And I think even if the degree of negative impact for complication optimizations is not very very large, removing the unspecified behavior is still worth it.

I'm not so pessimistic; I think genuine bugs will be rare. Of course that means I'm less sanguine about the value of a vet check. A competent programmer knows whether the values f and x might have something do with a and i, or whether they are definitively unrelated. This intuition, when well honed, is far stronger than any practical static analysis.
Removing unspecified behavior entirely from the language is unlikely to be worth the considerable effort and dynamic costs. Even if you specify expression evaluation order completely, including the order in which error cases are checked by the runtime, and forbid "unsafe", concurrency, the libraries on which one builds any application are not specified to that same level of detail. Specifying the evaluation order also dramatically increases register pressure in the compiler, which is why even Scheme, with arguably the cleanest semantics of any language, resisted the urge to specify the evaluation order.

I think I agree on your opinion in theory. I just need to see some concrete examples to be persuaded.

It sounds like this is beyond vet, so closing.


Update to Angular RC1

Howdy Krispo. You may be waiting for the stable release, but I got this working with ng2 RC1 if you want it.
I had to make a couple of stylistic changes: if (condition) ; was being rejected by latest typescript, so I changed all those to if (condition) {}
Thanks for the work ;)

Thanks for your work! I'll check it soon.


Add message number field to description block

Add a field called "Meldungsnummer" to the description block and show the number on the map if filled out example "#55".

There is no example in #55
Add this to every feature or only for text features?


refactor: Move path functions, and make JSON parsing fallible

This Pull Request is in preparation for the upcoming PR about path expressions.

refactor: Move path expression functions into path_exp module
Specifically: matches_token, calc_path_weight, and path_length.

refactor: Make many JSON parsing functions fallible
This is in preparation for an upcoming change that will cause parse_path_exp to be called during JSON parse time.
There are now error messages for MatchingRule parsing.
Errors during MatchingRule parsing will now cause JSON parsing to fail overall, rather than just printing a warning.
Errors parsing the status code in a StatusCode matcher will also cause JSON parsing to fail overall, rather than just printing an error.

Notice
This software was produced for the U. S. Government under Contract No. FA8702-20-C-0001, and is subject to the Rights in Noncommercial Computer Software and Noncommercial Computer Software Documentation Clause DFARS<PHONE_NUMBER> (FEB 2014)
Approved for Public Release; Distribution Unlimited. Case Number 19-3203.
(c) 2021 The MITRE Corporation. All Rights Reserved.

It appears that the AppVeyor build failed here:
cd "%APPVEYOR_BUILD_FOLDER%\rust\pact_mock_server_ffi"
The system cannot find the path specified.
Command exited with code 1

Did my changes cause this to happen? I can't imagine how.

On closer inspection, it appears that AppVeyor's build script is out of date with respect to recent changes in the project's layout.
pact_mock_server_ffi does not exist anymore, and the new pact_models crate is not yet in the build script.

Oh, sorry about that. The appveyor build is not needed anymore, because GH actions support Windows agents. Please ignore that, I'm going to remove it.


Add redirect to new website

This commit adds a redirect from TheAlgorithms.github.io to the-algorithms.com. The old page would still be reachable under TheAlgorithms.github.io/index-old.html

No it doesn't. It just redirects when you visit the root of the page

At the bottom of https://the-algorithms.com, it says that https://vercel.com is sponsoring it.
Are they paying money to TheAlgorithms for use of our content and logo? @AnupKumarPanwar

No, they just provide free hosting

This does not match with the commitment made by @kvedala that he would cover these costs.  https://github.com/TheAlgorithms/TheAlgorithms.github.io/issues/15#issue-653358814
Giving away our rights to a for-profit company is not what we agreed to.

No rights have been given away. Vercel just provides free hosting on their platform in exchange for the link in the footer. Maybe we should change to wording to "Hosting provided by vercel". But if you really don't like vercel, we can also switch to github pages.

@kvedala also just offered to buy a domain, which @AnupKumarPanwar now did

No, they just provide free hosting

Isnt "hosting" also done by github pages?

Isn't "hosting" also done by GitHub pages?

Offtopic: We already use Vercel for hosting and deploying. If you want the website to use GitHub Pages, you may want to contact @AnupKumarPanwar, then.

Isnt "hosting" also done by github pages?

Yes, but we would have to write a workflow that builds and deploys the site to github pages (that should not be too hard) and there wouldn't be preview deployments on pull requests (that's a Vercel feature which I find pretty nice).


Question about input image

Hello,
What kind of image can be used as test image ? Trying to use your code and latest release of Tensorflow. As result I have got the errors:
Loading the model
Traceback (most recent call last):
File "C:\Program Files (x86)\JetBrains\PyCharm Community Edition 2016.3.2\helpers\pydev\pydevd.py", line 1596, in
globals = debugger.run(setup['file'], None, None, is_module)
File "C:\Program Files (x86)\JetBrains\PyCharm Community Edition 2016.3.2\helpers\pydev\pydevd.py", line 974, in run
pydev_imports.execfile(file, globals, locals)  # execute the script
File "C:\Program Files (x86)\JetBrains\PyCharm Community Edition 2016.3.2\helpers\pydev_pydev_imps_pydev_execfile.py", line 18, in execfile
exec(compile(contents+"\n", file, 'exec'), glob, loc)
File "C:/code/py/ddpwfcrn/predict.py", line 71, in
main('C:/code/py/ddpwfcrn/NYU_ResNet-UpProj.npy', 'C:/code/py/ddpwfcrn/img/test.png')
File "C:/code/py/ddpwfcrn/predict.py", line 66, in main
pred = predict(model_path, image_paths)
File "C:/code/py/ddpwfcrn/predict.py", line 47, in predict
pred = sess.run(net.get_output(), feed_dict={input_node: img})
File "C:\Python35\lib\site-packages\tensorflow\python\client\session.py", line 767, in run
run_metadata_ptr)
File "C:\Python35\lib\site-packages\tensorflow\python\client\session.py", line 944, in _run
% (np_val.shape, subfeed_t.name, str(subfeed_t.get_shape())))
ValueError: Cannot feed value of shape (1, 228, 304, 4) for Tensor 'Placeholder:0', which has shape '(?, 228, 304, 3)'

Hello,
The input is a RGB image of height 228 and width 304 (although other sizes could also be possible,  by changing the placeholder). Somehow your input seems to have four channels instead of three, which could be the reason for this error. I hope this helps :)

Hello，
I have a problem，I don't know how to use your methods to train。
Can you give me the original training code of matconvnet? I want to know more details about your experiment。So if you are willing，Please share your training source code of matconnet give me。thanks

i try many test pictures. they seem all have 4 channels? how to get 3 channels-pictures?


Mark copied configurations as non-resolvable so that we do not lock copies of BOM configurations

Based off of a change to use unique configuration names when making copies: https://github.com/gradle/gradle/pull/9638/files

Coverage decreased (-0.1%) to 78.826% when pulling 4d1be76c7807ed4c9b60f51d59ae7e23b04ef2d2 on unique_copies_are_non_resolvable into 16c06151baf721f66ab72f5b89ed06c6485d5740 on master.

awesome! 👍


:sparkles: Use space framework in mailbox-controller

Summary
Related issue(s)
Fixes #

/lgtm
/approve


Accessing parsedArgs in route middleware?

I see that Route::run()sets $this->parsedArgs, but how do I access this from route middleware?
For clarification, I'm looking at how I could add route middleware that sanitised the route's named parameters which doesn't appear possible.  Should it be?

Thinking aloud here, but I think that the route middleware should have access to the Route object and its parsedArgs property.
The most obvious way to to do this is to change Route::add() so that we do $callable->bindTo($this) rather than $callable->bindTo($this->container). This means that the route middleware would have to access the container some other way such as use ($app) when defining it.
We should also make $parsedArgs public so that the route middleware can manipulate them before they are passed to the action callable.
Thoughts?

Binding to the route makes sense, but the difference from app middleware should be well documented to avoid confusion.

Hmm... My ideas here solve the problem for a closure, but not if we get the route middleware via the CallableResolver. More thinking required.

Those args should maybe be in the request? After all they describe the request done by the client, I don't see how they are different from query parameters or POST data.

@mnapoli This is the conclusion that I'm coming to.
We don't find out what they are until Route::run() is called, but we could then put them into the Request object, which would make them available to the route middleware. They would then be accessible in the action callable via $request or via the $args parameter.

Doh! They are already there!
$request->getAttributes() and $request->getAttribute($name, $default = null) have the data already populated…

:+1: good to know!

Though, if some route middleware does sanitise the request's arguments, then the action's $args parameter to the isn't updated, so the action callable must use $request->getAttributes() and ignore $args...

https://github.com/slimphp/Slim/pull/1196 solves this problem and makes the Request's attributes and $args consistent at the point of dispatch.


Dashr ncbi explorer

Issue for app: #[issue number here]
App pull request

[x] This is a new app
[ ] I am improving an existing app (redesigns/code "makeovers")

About

Current gallery app URL: https://dash-gallery.plotly.host/dashr-ncbi-explorer/

Workflow

[x] I have created a branch in the appropriate monorepo, and the
elements necessary for successful deployment are in place.
[x] If the app is a redesigned and/or restyled version of an
existing gallery app, I've summarized the changes requested in the
appropriate Streambed issue and confirm that they have been applied.
[x] If the app is on the Dash Gallery portal, I have added a link to
the GitHub repository for the source code in the portal description.
[x] If the app is a reimplementation of a Python gallery app for the
DashR gallery, the app in this PR mimics, as closely as possible,
the style and functionality of the existing app.=
[x] I have removed all Google Analytics code from the app's
assets/ folder.

The pre-review review
I have addressed all of the following questions:

[x] Does everything in my code serve some purpose? (I have removed
any dead and/or irrelevant code.)
[x] Does everything in my code have a clear purpose? (My code is
readable and, where it isn't, it has been commented appropriately.)]
[x] Am I reinventing the wheel? (I have used appropriate packages to
lessen the volume of code that needs to be maintained.)

@HammadTheOne is this ready for review? If so, @KPhans you're probably the best person to give it a look (b/c it's in R)!
CC: @lundstrj

@matthewchan15 Yup, this one is ready to review and merge. We'll just need to redeploy it once it's merged into master since it's already on the gallery.


Error: An exception occurred while generating the template.

This is my ever first time using Strive, I used a First-person shooter template, and I get the error. "Error: An exception occurred while generating the template. " I am using  <IP_ADDRESS>1-beta and .NET 5.0.0. I also downloaded Strive straight from the website, not from another source.

If you're still around, could you try again and tell us if that still occurs for you ?


Build success with Mac OS X

With the very minor changes in https://github.com/mit-probabilistic-computing-project/crosscat/issues/32 to build CrossCat, it's possible to directly build and use BayesDB on Mac OS X in a virtualenv.  (This is probably preferable to the Docker approach.)
It will even draw figures with a little bit of extra encouragement.

That's pretty cool! But why not docker? I find it easier to handle dependencies. Nice work.

Docker would require use of the ClientRemote, which won't work cleanly with any of the examples.

Is there a bug here?  If not, perhaps time to close this?


ENV Variables Not Respected

Could you help me understand why the environment variables are not being respected when I run this? The way I understand Viper and Cobra this should work, but cmd.Flags().GetString("foo") always returns the Cobra default when I set configuration via an environment variable.
Running your example as written I get the following:
➜  cobra-example git:(dev) ✗ FOO=FROM-ENV go run main.go config
config called
--- Final configuration once command is executed ---
        verbose = true
        foo = FROM-ENV
---
foo is "bar"

You can see that during initConfig() it correctly parses foo as FROM-ENV but when it actually pulls the value of the config option it still gets the default of bar.

Dug into this a bit more - Viper does not actually modify Cobra's flag values. If using Viper and Cobra together you need to retrieve flag values via viper.Get functions instead of the Cobra getters.


Build odo on go1.12

go version go1.11.13 linux/amd64 does not support os.UserHomeDir
$ make bin
go build -ldflags="-w -X github.com/openshift/odo/pkg/version.GITCOMMIT=8f38f155b" cmd/odo/odo.go
# github.com/openshift/odo/pkg/util
pkg/util/util.go:975:14: undefined: os.UserHomeDir
make: *** [bin] Error 2
The command "make bin" exited with 2.

So building it on go1.12

ping @mik-dass @mohammedzee1000

https://travis-ci.com/github/openshift/odo-init-image/jobs/327504844#L494
@amitkrout Seems like all the builds have failed

https://travis-ci.com/github/openshift/odo-init-image/jobs/327504844#L494
@amitkrout Seems like all the builds have failed

The tests are now passing, checking the other failure

/approve


Add more information on data seeding restrictions

Fixes #736

@divega Any reason this is still blocked?

@AndriySvyryd, I still have the same concerns but it is possible than adding this with explicit guidance on all the scenarios in which you should not do it is better than not adding it.
Let's get together with @ajcvickers and discuss it once more, when there is a chance.

@divega Updated


Feature: support of qualities on myself tab

This PR adds the lookup buttons in front of the quality names on the "Myself" tab. Thus, it allows a quick lookup if you have forgotten what you got the quality for.
The title is extracted from the alt attribute of the icon - it's reliable, as opposed to trying to parse it from the actual text.
I must say I am not terribly happy with the resulting layout, and am very open to changes here. In particular, it gets somewhat ugly with qualities that can be uncollapsed, such as "A Patron of..." and "Acquainted With".

While I like the idea, the current iteration of it is too noisy and quickly becomes a nuisance due to icons being displayed on hundreds of rows. :(
Maybe it can be reworked to displaying the "Search" icon only on hover? For example, at the right end of a quality row or upon a quality's icon.

Do you have any preferred best practices on how to do that?


Fixed typo on Advanced Usage page

This PR is to fix the typo on the Advanced Usage page.
I fixed typo that was no space.

thanks very much!


Add ability to check state and wait for end of timeout

Use-case: blink LED when restart is possible

done


chore: run CI against the head of the branch, not a virtual merge with master

Fixes #2701
The default behaviour in Github CI is not to run CI against the head of the PR branch, but against a virtual merge with master. See discussion at #2701 for details.
This PR changes that behaviour to actually run CI (and hence also to build toolchains and lean-pr-testing-NNNN Mathlib branches) against the PR itself.
This should help reduce the number of CI failures against Mathlib due to unrelated changes, particularly if authors start making feature branches by branching off the nightly branch (as introduced in #2767), rather than master. This is much more likely to have a successful Mathlib build!

And look at that, magically succeeding on Mathlib, unlike #2767, made at about the same time!

I assume the more proper way to eventually test-build the PR merged/rebased onto master would be a future merge queue? LGTM then.

Yes, the merge queue is starting to look essential. I will try to set that up next week.

Note that this setting is somewhat dangerous without the “require branches to be up to date before merging”, because now one can merge a green PR without noticing that the merged state is bad, and would lead to a broken master.
With that setting merging requires updating first, which is ok for slow throughput repos.
Later, merge automation like mergify or GitHub's merge queue helps a lot.

This was already true before because CI is not restarted when master is updated, no? That is, the window of CI/master divergence merely widened from "most recent PR push to now" to "most recent PR rebase to now".

Indeed, its just more likely now. But yes, GitHub's default is broken in surprisingly many ways :-)


Use Azure Backup Server to back up workloads to Azure

I'm looking for content of how to backup "Linux - Linux running as Hyper-V or VMware guest" (list in the following link) specifically, but I cannot find content covering it. Where can I find it? I expect to follow a link from this page.
What can Azure Backup Server back up | Microsoft Docs
https://docs.microsoft.com/en-us/azure/backup/backup-mabs-protection-matrix#protection-support-matrix
The issue title "Use Azure Backup Server to back up workloads to Azure" is the title of this page actually, which is different from the heading title (and content).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 76dad6d5-9991-e15e-0283-1d8d49c35df4
Version Independent ID: baa58543-1be8-aa7c-15b9-db35f071f4fb
Content: Use Azure Backup Server to back up workloads to Azure
Content Source: articles/backup/backup-azure-microsoft-azure-backup.md
Service: backup
GitHub Login: @kasinh
Microsoft Alias: kasinh

@kazshi Thanks for the comment. For VMware Linux VM refer to -  and for Hyper-V Linux VM see this link

@SadiqhAhmed-MSFT Thanks for the link. I was aware of the page but missed the line about Linux.


vscode-stylelint throws an using this as a plugin

Firstly, I'm not sure if this is an issue with the vscode plugin or with stylelint-config-rational-order but I needed to start somewhere.
When I enable this by extending the stylelint config it works perfectly.
{
  "extends": [
    "stylelint-config-rational-order"
  ]
}

However if I enable it as a plugin and rule the vscode plugin throws an error about severity, see the below error.
{
  "plugins": [
    "stylelint-config-rational-order/plugin"
  ],
  "rules": {
    "plugin/rational-order": true
    // OR (both break)
    // "plugin/rational-order": [true, {
    //   "border-in-box-model": false,
    //   "empty-line-between-groups": false,
    // }]
  }
}

Error: `severity` property of a stylelint warning must be either 'error' or 'warning', but it was 'ignore' (string). at stylelintWarningToVscodeDiagnostic (/Users/ben/.vscode/extensions/shinnn.stylelint-0.48.0/node_modules/stylelint-warning-to-vscode-diagnostic/index.js:40:9) at Array.map (<anonymous>) at processResults (/Users/ben/.vscode/extensions/shinnn.stylelint-0.48.0/node_modules/stylelint-vscode/index.js:59:18) at stylelintVSCode (/Users/ben/.vscode/extensions/shinnn.stylelint-0.48.0/node_modules/stylelint-vscode/index.js:144:9)

I tried adding the severity option but the error is still throw.
"plugin/rational-order": [true, { "severity": "warning" } ]
Any ideas where this problem exists or how to fix it?
BTW I love this project, thank you :)

It's related to .stylelintrc (99.5%; I faced the same error). Could you please post here the full version of .stylelintrc (or another file where your store stylelint config)?

I made the smallest demo I could (which is essentially just the snippets above).
https://gist.github.com/rockingskier/e712728a447ba0e8bd78cc075c400131
MY actual project .stylelintrc is
{
  "processors": ["stylelint-processor-styled-components"],
  "extends": [
    "stylelint-config-recommended",
    "stylelint-config-styled-components",
    "stylelint-config-rational-order",
    "stylelint-config-prettier"
  ],
  "rules": {
    "plugin/rational-order": [true, {
      "border-in-box-model": true,
      "empty-line-between-groups": true,
    }]
  }
}

Ben, thank you for paying attention to this wrong behavior! My mistake =)
The documentation was fixed. So to fix the error just follow the steps:

add to dependencies all required packages: npm install --save-dev stylelint stylelint-order stylelint-config-rational-order
add stylelint-order to plugins
add "order/properties-order": [] to rules

That's all =)

Works perfectly, thank you 👍

If there are 11 or more rules, not placing "order/properties-order": [], first seems to still produce this error.
This .stylelintrc will show the 'severity' error:
{
  "plugins": ["stylelint-order", "stylelint-config-rational-order/plugin"],
  "rules": {
    "at-rule-name-case": "lower",
    "at-rule-name-newline-after": "always-multi-line",
    "at-rule-name-space-after": "always",
    "at-rule-no-unknown": true,
    "at-rule-no-vendor-prefix": true,
    "at-rule-semicolon-newline-after": "always",
    "at-rule-semicolon-space-before": "never",
    "block-closing-brace-empty-line-before": "never",
    "block-closing-brace-newline-after": "always",
    "order/properties-order": [],
    "plugin/rational-order": [
      true,
      {
        "border-in-box-model": true,
        "empty-line-between-groups": false
      }
    ]
  }
}

This .stylelintrc works fine ("order/properties-order": [], is first):
{
  "plugins": ["stylelint-order", "stylelint-config-rational-order/plugin"],
  "rules": {
    "order/properties-order": [],
    "at-rule-name-case": "lower",
    "at-rule-name-newline-after": "always-multi-line",
    "at-rule-name-space-after": "always",
    "at-rule-no-unknown": true,
    "at-rule-no-vendor-prefix": true,
    "at-rule-semicolon-newline-after": "always",
    "at-rule-semicolon-space-before": "never",
    "block-closing-brace-empty-line-before": "never",
    "block-closing-brace-newline-after": "always",
    "plugin/rational-order": [
      true,
      {
        "border-in-box-model": true,
        "empty-line-between-groups": false
      }
    ]
  }
}

This .stylelintrc also works fine (only 10 rules):
{
  "plugins": ["stylelint-order", "stylelint-config-rational-order/plugin"],
  "rules": {
    "at-rule-name-case": "lower",
    "at-rule-name-newline-after": "always-multi-line",
    "at-rule-name-space-after": "always",
    "at-rule-no-unknown": true,
    "at-rule-no-vendor-prefix": true,
    "at-rule-semicolon-newline-after": "always",
    "at-rule-semicolon-space-before": "never",
    "block-closing-brace-empty-line-before": "never",
    "order/properties-order": [],
    "plugin/rational-order": [
      true,
      {
        "border-in-box-model": true,
        "empty-line-between-groups": false
      }
    ]
  }
}


still issue if no -fix-faces-fidelity supplied

so, did a,  "pip install --upgrade imaginairy" to go up to v 2.3.0
now the following happens with no -fix-faces-fidelity supplied

(py-venv) shaun@Shauns-MBPro14 dev % imagine "a couple smiling" --steps 40 --seed 1 --fix-faces
🤖🧠 imaginAIry received 1 prompt(s) and will repeat them 1 times to create 1 images.
Loading model onto mps:0 backend...
Generating 🖼  : "a couple smiling" 512x512px seed:1 prompt-strength:7.5 steps:40 sampler-type:plms
PLMS Sampler: 100%|█████████████████████████| 40/40 [00:51<00:00,  1.29s/it]
Fixing 😊 's in 🖼  using CodeFormer...
Enhancing 2 faces
Failed inference for CodeFormer: '>' not supported between instances of 'NoneType' and 'int'
Failed inference for CodeFormer: '>' not supported between instances of 'NoneType' and 'int'
🖼  [generated] saved to: ./outputs/generated/000015_1_plms40_PS7.5_a_couple_smiling_[generated].jpg
(py-venv) shaun@Shauns-MBPro14 dev %

adding --fix-faces-fidelity 0.2 suppresses these..
so not sure, type error in default?

huh. thanks. I thought I addressed this but I'll take a look and see what I missed.

Many thanks for all your work on this BTW, its a great tool to explore SD with!

Fixed in 2.3.1

Thanks! Still in need of quite a bit of refactoring to make it easier to understand, test, and modify.   Let me know if you're doing anything interesting with it!

me IT prof. but complete noob to AI/ML + diffusion etc, so your tool makes it easy for someone like me who's happy on the command line, and just wants it to install and work (which it does, so you've met your goal there :-) ), so that I can explore its image creation potential to start with..
Your integrations of the most commonly mentioned/used 'addons' saves someone like me a heap of time, because again, they just work 'out of the box', and I can use or not use them with command line switches through your wrapper..
Eventually someone will build a 'no brainer' GUI wrapper I guess, which might be suitable for folks like me, but I can see that in your packaging that if I wanted to add more on, tinker with the Python etc. it's an easier development environment as a base..
Bit of unsolicited user feedback for you haha :-)
Have  goodly day!

Can confirm that I'm still seeing this same error in 2.3.1 if I don't provide a --fix-faces-fidelity value. This issue did at least point in the right direction so I could see how it works.
@brycedrennan thanks for putting this library together it's great to have a powerful little command line tool which works on Apple silicon.
Also appreciate you adding the rust setup tools to the documentation. I managed to figure this out on my own prior to that being added (based on the errors I received) but it will be future for anyone trying to install this in future.

Apologies @brycedrennan this appears to have been a PEBKAC issue. I have installed 2.3.1 in my local env but I must not have had my virtual environment activated so was using an old 2.2.1 version which I had previously installed globally. My bad!


Revisit usage of relative imports in python tests

Relative imports in Python can result in a number of non-obvious issues - most notably, the inability to run certain binaries except from a specific directory. If possible, we should convert the relative imports used in tests into absolute imports.

This appears to be the root cause of #219, and also causes unexpected behavior when manually running tests (i.e. with python3 -m pytest) as noted in #221. We should resolve this before the next release.


Running 'trunk serve --open --features csr' fails

When i run 'trunk serve --open --features csr'
I get the following error
Error: error getting canonical path to source HTML file "index.html"
if i add in the default index.html from trunks README to the root of the directory
<!doctype html>
<html>
  <head>
    <link data-trunk rel="rust" data-wasm-opt="z" />
    <link data-trunk rel="icon" type="image/ico" href="/assets/favicon.ico" />
  </head>
  <body></body>
</html>

then try the command again i get the following warnings
warning: output filename collision.
The bin target `leptos_start` in package `leptos_start v0.1.0 (/home/icy/development/rust/workspace/leptos-portfolio/testprojet)` has the same output filename as the lib target `leptos_start` in package `leptos_start v0.1.0 (/home/icy/development/rust/workspace/leptos-portfolio/testprojet)`.
Colliding filename is: /home/icy/development/rust/workspace/leptos-portfolio/testprojet/target/wasm32-unknown-unknown/debug/leptos_start.wasm
The targets should have unique names.
Consider changing their names to be unique or compiling them separately.
This may become a hard error in the future; see <https://github.com/rust-lang/cargo/issues/6313>.
warning: output filename collision.
The bin target `leptos_start` in package `leptos_start v0.1.0 (/home/icy/development/rust/workspace/leptos-portfolio/testprojet)` has the same output filename as the lib target `leptos_start` in package `leptos_start v0.1.0 (/home/icy/development/rust/workspace/leptos-portfolio/testprojet)`.
Colliding filename is: /home/icy/development/rust/workspace/leptos-portfolio/testprojet/target/wasm32-unknown-unknown/debug/leptos_start.wasm.dwp
The targets should have unique names.
Consider changing their names to be unique or compiling them separately.
This may become a hard error in the future; see <https://github.com/rust-lang/cargo/issues/6313>.

then my browser opens to an empty page.
am i doing something wrong? I know it says its ill advised to run build with csr but its my intention.
The site does work when i use cargo leptos serve

Having tried to reproduce this etc. it seems that this line
<link data-trunk rel="rust" data-wasm-opt="z" />

is what is causing the blank screen. Not sure what's going on there, but if you just remove that from your index.html it works fine.

Thanks so much that fixed it!


Embed in Godot?

This is great and finally adds a shortcut to toggle the bottom panel, which is all I wanted (I didn't need to toggle specific windows in the bottom panel.)
Why not put the Toggle Bottom Panel shortcut directly into the editor, like how Ctrl-\ or Cmd-\ toggles the scripts panel?  I would suggest using Ctrl-/ or Cmd-/ for toggling the bottom panel, since on Mac Cmd-Space is Spotlight Search (and for symmetry with the Scripts Panel shortcut.)

I mean, rather than doing it as a plugin that someone has to discover and install, they'd find the shortcut when they search for "bottom" in Editor Settings -> Shortcuts.

Skill issue on my side. I can write a simple plugin, I can't add changes to Godot itself.
I will be glad if somebody could do this, but for now it will be just a plugin.
And my solution itself is kinda hacky. It will work and I'm content with it being a plugin, but I'm not sure I want this as a part of Godot.

LOL, I tried understanding your code and couldn't figure out where the
actual toggling was happening, whereas looking through the C++ code I
figured I could at least copy-and-modify the approach used for the Scripts
panel.
I don't have the skill for either, and I'm just grateful I can press Cmd-/
now and toggle the panel.  Thanks!
On Wed, Oct 25, 2023 at 1:53 PM NoctemCat @.***> wrote:

Skill issue on my side. I can write a simple plugin, I can't add changes
to Godot itself.
I will be glad if somebody could do this, but for now it will be just a
plugin.
And my solution itself is kinda hacky. It will work and I'm content with
it being a plugin, but I'm not sure I want this as a part of Godot.
—
Reply to this email directly, view it on GitHub
https://github.com/NoctemCat/BottomPanelShortcuts/issues/1#issuecomment-1779774932,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHHGVMHFE3AHVOWGBGIVC3YBFG2HAVCNFSM6AAAAAA6PX74ZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZZG43TIOJTGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Haha, I can understand you, it really is hacky. It listens for 'toggle' signal on the bottom buttons in the editor, and when that signal happens it updates button variable. After when your input matches a shortcut it uses saved button variable, and emits a 'toggle' signal on that button.
Thanks to that it works with all bottom panels, even the ones that would be added by other plugins.

Oh, clever!
On Wed, Oct 25, 2023 at 2:15 PM NoctemCat @.***> wrote:

Haha, I can understand you, it really is hacky. It listens for 'toggle'
signal on the bottom buttons in the editor, and when that signal happens it
updates button variable. After when your input matches a shortcut it uses
saved button variable, and emits a 'toggle' signal on that button.
Thanks to that it works with all bottom panels, even the ones that would
be added by other plugins.
—
Reply to this email directly, view it on GitHub
https://github.com/NoctemCat/BottomPanelShortcuts/issues/1#issuecomment-1779807731,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHHGVMEUBQ5HEKCIMQKPJLYBFJLNAVCNFSM6AAAAAA6PX74ZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZZHAYDONZTGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Found out it is now possible in the engine with 'Toggle Last Opened Bottom Panel' so I'm closing this issue as completed (not by me, but completed nonetheless)


pinning the RHEL version due to missing RHUI repositories.

Pinning RHEL 7 version in RP VMs due to RHUI repositories not being in the "latest" config.

force pushed rebase to fix conflict

@Makdaam @mjudeikis I have created a new branch https://github.com/Azure/ARO-RP/tree/hotfix-20201112 with this change.

/azp run CI

@Makdaam please close this PR and reopen it to merge to master

https://github.com/Azure/ARO-RP/pull/1151/files opened to merge to master.


sw-6669: Adds hw subtype to caseload client list query

Codecov Report
All modified lines are covered by tests :white_check_mark:

Files
Coverage Δ

internal/server/caseload.go
77.11% <100.00%> (+1.01%)
:arrow_up:

internal/sirius/get_client_list.go
67.34% <100.00%> (+2.12%)
:arrow_up:

:loudspeaker: Thoughts on this report? Let us know!.


e2e: Fix path to config file

This is related to changes made in #1471.
PR #1645 was a previous attempt at fixing this, but the path wasn't
quite right. It missed instructlab/ within the base config dir.
Signed-off-by: Russell Bryant<EMAIL_ADDRESS>

I believe @leseb's comment needs to be addressed but otherwise LGTM.


Running custom script extension to change the locale on VM Scale Set does not change I18N formatting

We are trying to set the locale  on a AKS VM Scale Set via Custom Script Extension that is run at startup , this is not Ideal ,any other better way would help . The script extension that we run is :
if($(Get-WinSystemLocale).Name -ne "nb-NO"){
	Write-Host " not norwegian locale"
    Set-ItemProperty -Path "HKCU:\Control Panel\International" -Name sThousand -Value "."
    Set-ItemProperty -Path "HKCU:\Control Panel\International" -Name sDecimal -Value ","
    Set-WinSystemLocale nb-NO
    Set-WinUserLanguageList -LanguageList nb-NO -Force
    Set-Culture -CultureInfo nb-NO
    Set-WinHomeLocation -GeoId 177
    Restart-Computer
}

The problem is now that calling Get-WinSystemLocale return correct nb-NO after restart , But the currently format and date format is not honored. For example :
>>>"{0:C}" -f<PHONE_NUMBER>999
$9,999,999,999,999.00

How can we fix this ?

Host Process Containers for K8s is in v1.22. That would be the best way to do this. It will be available in AKS in a couple of months. https://kubernetes.io/blog/2021/08/16/windows-hostprocess-containers/


Add zod generator

Pre-Review
Mainly inspired by the typescript generator; added some extra zod related stuff

You can find a generated scheme for our database at https://privatebin.net/?f056e74faf7e19e7#84dWA3tHQyTzXmPsk4pZkdQfz7FmTPQ7sEZZeiMEdapF - it's abut 17,000 lines long though...

@psteinroe to speed up your review process: You can ignore the "apply linter" commit, as it only applies the linter but doesn't change any logic


Include TSD as a dep of this project?

Currently we rely on a global install of tsd.

or, typings (#3). Whichever comes first

It looks like tsd is already a dep of this project, but it's not actually using the installed version, and instead calling out to the global system install of tsd. Not a major concern for the 1.0.0 release, but re-{naming/tagging} as a bug.

Resolved when we switched to Typings from TSD (See #3). Whenever npm start is called, we now always call typings install (it runs quick, I promise) which uses the local typings install (vs. global)


refactor: Support AsyncLocalStorage

This PR refactor the handler code (middlewares and main API function).
The change is to run all functions in one Promise instead of creating a Promise for each middleware.
The Motivation is to support AsyncLocalStorage in order to have a context object cross all middlewares and the main API function.
Thanks.

Hey @ggurkal @leeuwis
How can I get review of this one please?
Am I missing something?
Thanks.


Setext-style headers are not recognized

Just look at First header:
Title
=====
<!-- TOC  -->

- [Second](#second)

<!-- /TOC -->

First
-----

### Second

Title
=====
<!-- TOC -->

- [First](#first)
    - [Second](#second)

<!-- /TOC -->

## First

### Second

After TOC update setext-style is not recognized but atx-style works as expected. This is very inconvenient for me as all my notes use setex-style.

Extension version: 1.4.3
VS Code version: 1.8.1

Really good extension by the way :).

Recognized title and ignore other grammar, it 's troublesome, I need a lot's time. Thank you for your issues.


EventHub: Geo DR API and Properties added

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[X] The title of the PR is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[X] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[X] If applicable, the PR references the bug/issue that it fixes.
[X] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[X] I have read the contribution guidelines.
[X] My spec meets the review criteria:

[X] The spec conforms to the Swagger 2.0 specification.
[X] The spec follows the guidelines described in the Swagger checklist document.
[X] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

@simongdavies new operations

@ravbhatnagar

Bypassing ARM  (@ravbhatnagar  and @simongdavies please follow up with Author on changes if required)

 https://github.com/Azure/azure-sdk-for-ruby/pull/1183

 https://github.com/Azure/azure-sdk-for-python/pull/1701


pytest on github workflows

What is the problem / what does the code in this PR do
Lately, travis is taking forever to build. This PR may kindle a new discussion to (partially) switch to github actions as those seem to run much faster than travis.
Can you give a minimal working example (or illustrate with a figure)?
See this PR as working example.

I think we are seeing how much faster github actions is, perhaps we can distribute as the interface between coveralls and travis is nice and none-trivial. Therefore I propose to move some tests to github actions and skimming down travis a little (it's doing 4 platforms at the moment).
Any objections?
Oh this also adds this extra message by the github bot, if we want to, we can delete it, or, we can just delete it whenever it's in the way of the PR review.


Fresh install error

Hi,
I wanted to update the theme (uno-zen-2.2.3 for the moment) on my Ghost. I choose to make a fresh install of it.
I have the following error :
sh: 3: /couby/ghost/content/themes/uno-zen/scripts/utils.sh: Syntax error: "(" unexpected
The install script didn't executed fully in this case.
It seems the bash of my VM doesn't accept function xxx(){} commands :-/
I don't know if there can be other users in the same case...
I noticed removing function line 3 of utils.sh makes it working.
Then I made a install2.sh in order to finish install.
. "$PWD"/scripts/utils.sh

welcome

echo "Getting the repository tagged commits"
git fetch --tags

echo "Resolving the latest tagged version"
latestTag=$(git describe --tags "$(git rev-list --tags --max-count=1)")

echo "Creating a stable branch from the latest tagged version"
git checkout "$latestTag"
git checkout -b stable

echo "\nTheme Installed Successful! Enjoy :-)"

If that can help someone else in the same case.

what version of batch are you sing? type bash --version, in my case:
GNU bash, version 4.3.42(1)-release (x86_64-apple-darwin14.5.0)
Copyright (C) 2013 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.


⚠ ClamAV has degraded performance

In 1187abd, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 201 ms

Resolved: ClamAV performance has improved in b3266c3.


ethereum-metrics-exporter fails to start

I had this issue where ethereum-metrics-exporter would not start and it was due to this name been different.
I don't know much about this code but maybe it broke because an update to the container.

+1
@alepacheco thanks for finding a solution to this issue. I confirmed your suggested fix does work.

Duplicate of #1199


Rewrite String#prepend with Ruby

String#prepend have unexpected behavior.
s = "abcdefghijkl"
p s.prepend(s)
#=> "abcdefghijkl\000\000\000\360\002\000\000\000\000\000\000\360"

And fix #3357
I think it will be able to write more simply.

I think, String#[]= should raise an error TypeError when argument is none String object.


refactor(assembly): speed up script compilation

This PR address https://github.com/maticnetwork/miden/issues/153.
This PR significantly reduces the script compilation time by a factor of 36.
The following benchmark were conducted on AMD Ryzen 5 3550H running Pop!_OS 22.04 LTS:
Before this commit:
sha256:  [2.8630 s 2.8750 s 2.8874 s]
Post this commit:
sha256:  [78.123 ms 78.921 ms 79.821 ms]
The reason for this big increase in the speed up is because now instead of iteratively combining two consecutive SPAN blocks(and applying hash elements), we are keeping track of all the consecutive SPAN blocks occured in a row and apply hash_elements only once when there's a discontinuity. That way we have to apply the hash_elements only once v/s every single time we get a pair of span blocks in the earlier case.

One other thing I'm curious about: does this noticeably reduce runtime of tests. Meaning, if you run cargo test before and after this change - do you see any improvement?

@bobbinth: Thanks for review!
Not for this PR (but maybe we should create an issue for this): There is probably a more efficient way to handle this.
I've created a new issue for this. You can assign it to me. #253
One other thing I'm curious about: does this noticeably reduce runtime of tests. Meaning, if you run cargo test before and after this change - do you see any improvement?
In terms of speed boost, we are not getting much. Earlier the integration tests(rest all are pretty quick) were taking ~440 secs and now post this commit they are taking ~424 secs on my system. There are few tests(div_fail, lt, cdrop, dupw, u32_rotr_b etc.) which are still taking considerable amount of time to run.
We should first address #253 and then see if it helps with other tests as I see it the ideal next step post this commit. Love to hear your thoughts on this.

In terms of speed boost, we are not getting much. Earlier the integration tests(rest all are pretty quick) were taking ~440 secs and now post this commit they are taking ~424 secs on my system.

Makes sense. One more question: we have a few tests which are being ignored now (test for SHA256 being one of them). Could you check what is the runtime of these tests before and after this PR? If the runtime is small now, we might as well turn them on.

Makes sense. One more question: we have a few tests which are being ignored now (test for SHA256 being one of them). Could you check what is the runtime of these tests before and after this PR? If the runtime is small now, we might as well turn them on.
2 tests were being ignored at the moment: keccak256_bit_interleaving & keccak256_2_to_1_hash. When I included them in the integration tests, the runtime I got on my machine is as follows:
Post commit: 430.62s
Pre commit: 602.36s
Based on the above finding I think it's fine if we turn them on. I've turned them on in this PR.


Move block generator to its own repo

Move block generator to its own repository, and use the AGPL license. block generator will continue to depend on go-algorand.
Users will thus still be able to use the block generator binary to generate block data, and then use this data in any project (of any license, without polluting their license).
Out of scope: refactor block generator to use the state delta endpoint from algod.

Closed by https://github.com/algorand/internal-tools/commit/1d6586f8e514d90bc0e77a85f9677928f462db6e


Rocky9

upgrade python 3.9, ubuntu 22.04 for running image
fix references to ice packages in defaults
bump omero-py
change platforms to rocky9 and add ubuntu 22.04 platform and thus 22.04 test
bump postgres to 14 (afai understand this is a desired version everywhere)

Inside the tasks/main.yml

remove python3 setup (it is present by default)
point to the config for omero-prometheus-tools directly under /etc on Ubuntu as the /etc/sys... dir does not exist there
create a logic for the above in the main.yml
create a separate templates/systemd-prometheus-omero-exporter-service-debian.j2 file with the correct path for Debian (i.e. /etc/prometheus-omero-exporter)

Test is passing on https://github.com/pwalczysko/ansible-role-omero-prometheus-exporter/actions/runs/7561213705
cc @jburel @khaledk2

The tests are green. I have

fixed the OS-dependent logic by introducing a new variable cf. @sbesson 's comment
reverted the minimal ansible version bump as discussed with @jburel on other PRs

Ready for review.

@sbesson

Note that this task could also been combined with the previous ones to use environment_file_path[ansible_os_family].

Sorry, simply went with your suggestion as:

I like it myself
It simplifies and shortens the code and thus facilitates maintenance
Do not see the reason for the when approach as just one line of difference between OS-es here is different from the cited postgresql-client case
I believe @jburel and, most probably @khaledk2 would agree with this approach - basically, have the cleanest code possible ?

cc @jburel @khaledk2
(it will need one more approving review please, as GitHub claims that I have "dismissed" the previous review by the new commit :)

Test is green. Thanks @sbesson @jburel . Merging.


fix: for interfaces, include properties from inherited interfaces in mappings

closes #128

Codecov Report

Merging #129 (75f6e75) into main (3dd71bd) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   89.73%   89.73%   -0.01%
==========================================
  Files          74       74
  Lines        2417     2416       -1
  Branches      305      305
==========================================
- Hits         2169     2168       -1
  Misses        181      181
  Partials       67       67

Impacted Files
Coverage Δ

src/Riok.Mapperly/Helpers/SymbolExtensions.cs
95.00% <100.00%> (-0.13%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Major rebase; add some delegate methods

Thanks a lot, this looks useful. Before I can merge, I'd appreciate it if you'd make some style changes.
It should be:
- (void)addSwipeGestureRecognizer:(UISwipeGestureRecognizerDirection)direction;

Not:
- (void) addSwipeGestureRecognizer: (UISwipeGestureRecognizerDirection) direction;

For example.

Wouldn't it just be easier to merge the pull request and make the changes? I'm sure it would be easier for both of us.

I'm too busy right now so it will have to wait, thanks.


Support for reactions in Mattermost

Summary

Matrix Connector does not support user reactions on message from Element/Matrix in Mattermost
We will use the node library https://www.npmjs.com/package/node-emoji

Summary

This feature is not implemented in current release
Hard to find how to implement this feature. We will use Playwright Test to record API calls in a HAR file.
Fallback for unknown emojis ?

Development Estimation
6 hours

Reactions now supported


Adding OpenShiftAsciiDoc rule for hard wrapped text

Rule that flags when a hard-wrapped line is detected in an AsciiDoc file

This implementation looks good. Although I'm a bit confused about the reason behind it... no hard-wrapping is allowed between characters 65 and 100 on a line? But it's allowed outside of those characters?
Only found one false positive so far (I think), the ifdef line triggers is here:
ifdef::openshift-origin,openshift-enterprise,openshift-webscale[]
* Hybrid cloud deployments. You can deploy {product-title} clusters to a variety of public cloud platforms or in your data center.
endif::[]

This implementation looks good. Although I'm a bit confused about the reason behind it... no hard-wrapping is allowed between characters 65 and 100 on a line? But it's allowed outside of those characters?
Only found one false positive so far (I think), the ifdef line triggers is here:
ifdef::openshift-origin,openshift-enterprise,openshift-webscale[]
* Hybrid cloud deployments. You can deploy {product-title} clusters to a variety of public cloud platforms or in your data center.
endif::[]

ifdef::openshift-origin,openshift-enterprise,openshift-webscale[]

Hybrid cloud deployments. You can deploy {product-title} clusters to a variety of public cloud platforms or in your data center.
endif::[]

Updated to account for if/endif lines

Or images, this triggers the rule:
image::product-workflow-overview.png[High-level {product-title} flow]


Fix git clone command in README

There is no ly on the end of the --recursive argument. I would cite the documentation for git clone, but this argument is not documented there. I did confirm it works on my machine with Git 2.44.

@dotnet-policy-service rerun


Quick question: Is there a way to ignore .css entry points?

I just got this lovely set of plugins building my project, thank you. I was using ESbuild to bundle both JS and CSS – not together, but as separate entry points:
es.build({
    entryPoints: [
        './module.js',
        './module.css'
    ],

    plugins: [...denoPlugins({
        configPath: workingdir + 'deno.json',
        lockPath:   workingdir + 'deno.lock'
    })]

    ...
}

Unfortunately denoPlugins() borks when fed CSS.
Expected a JavaScript or TypeScript module, but identified a Unknown module. ...

Is there a way to get it to ignore these entry points?

there "kinda" is:
    {
      name: "skip css",
      setup: (build) => {
        build.onResolve({ filter: /\.css$/, namespace: "file" }, (args) => {
          return {
            path: Path.resolve(args.resolveDir, args.path),
          };
        });
        build.onLoad({ filter: /\.css$/, namespace: "file" }, (args) => {
          const contents = Deno.readFileSync(args.path);
          return {
            contents: contents,
            loader: "css",
          };
        });
        build.onResolve({ filter: /.*/, namespace: "data" }, (args) => {
          return args.kind !== "url-token" ? undefined : { external: true };
        });
      },
    },
    ...denoPlugins({

so this basically handles css resolution and loading before one of the denoPlugins has a chance to handle that.

Of course, whack a handler in before denoPlugins(). I don't know why I didn't try that, I think I was influenced by this text in the README "In most cases, the denoResolverPlugin should be the first plugin in the plugin array".
Thank you, this solves my problem.

yeah, but the issue still exists, no?
On Wed, Aug 21, 2024, 20:29 stephband @.***> wrote:

Closed #134
https://github.com/lucacasonato/esbuild_deno_loader/issues/134 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/lucacasonato/esbuild_deno_loader/issues/134#event-13964783414,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACOHZTT3JJ35EKCLJ4XK3PTZSTMA3AVCNFSM6AAAAABLZE35DKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTHE3DINZYGM2DCNA
.
You are receiving this because you commented.Message ID:
@.***
.com>


Silicon OreDict

Issue description:
I know this has been reported before but... I'm still experiencing the issue where autocrafting using silicon doesn't use multiple types of silicon to craft with. For example it's only seeing the EnderIO silicon when I have enough RS silicon to complete the craft.
What happens:
I click to craft a 64k storage part and it says its missing some silicon.
What you expected to happen:
Actually allow me to craft the item using both types of silicon.
Steps to reproduce:

Setup a pattern to make 64k parts.
Put in 2 types of silicon.
Try to autocraft
Fail

Version (Make sure you are on the latest version before reporting):

Minecraft: 1.10.2
Forge: 2254
Refined Storage: 1.2.25

Does this issue occur on a server? [yes/no]
Yes
If a (crash)log is relevant for this issue, link it here:
[pastebin/gist/etc link here]

Change the patterns that use silicon to be an "oredict" pattern, toggle-able in the Pattern Grid/Processing Pattern Encoder GUIs.

Fixed it, forgot to OreDict the Printed Silicon! (someone helped me on the FTB Reddit)


our-boxen install is painfully slow

I'm running through the initial boxen setup on OSX 10.10.2 (Xcode installed) with a fresh copy of this repo. I'm basically just trying to get something working on my machine before I start customizing. The script stalled for over 30 minutes on Executing 'brew boxen-install boxen/brews/gcc48'
$ ./script/boxen --no-fde --debug

...

Notice: Package[boxen/brews/git](provider=homebrew): Updating homebrew formulas
Debug: Executing 'brew update'
Debug: Executing 'brew boxen-install boxen/brews/git'
Notice: /Stage[main]/Git/Package[boxen/brews/git]/ensure: created
Debug: /Package[boxen/brews/git]: The container Class[Git] will propagate my refresh event
Debug: Class[Git]: The container Stage[main] will propagate my refresh event
Notice: /Stage[main]/Boxen::Bin/File[/opt/boxen/bin/boxen]/ensure: created
Debug: /Stage[main]/Boxen::Bin/File[/opt/boxen/bin/boxen]: The container Class[Boxen::Bin] will propagate my refresh event
Debug: Class[Boxen::Bin]: The container Stage[main] will propagate my refresh event
Debug: Class[Hub]: The container Stage[main] will propagate my refresh event
Debug: Executing 'brew info boxen/brews/gcc48'
Debug: Executing 'brew boxen-install boxen/brews/gcc48'

Is it supposed to take so long? The whole script hasn't finished yet still, as I write this issue. It's been over 45 minutes total at this point...

Yes. The initial setup usually is longer, although I think your problem is that you are not using the packages cache, and it is compiling in your machine.

@rafaelfranca Thanks for the tip - can you clarify what you mean? I don't want to recompile everything if I don't need to. Is there some documentation available for how to use the packages cache?

Boxen by default use a package cache in a S3 bucket provided by GitHub, depending on what you use this bucket not contain the packages, and there is nothing that you can do. The best thing to do is create your own package cache and let things compile in the first time.
to configure it you just need to set https://github.com/boxen/our-boxen/blob/689633f05a16c6fc4589d5341a2e8f40a7419ead/config/boxen.rb#L10-13 and add a fact like this example https://github.com/boxen/our-boxen/blob/689633f05a16c6fc4589d5341a2e8f40a7419ead/facts.d/example.yaml#L7.
boxen_download_url_base: "http://my-packages.s3.amazonaws.com"

@rafaelfranca @mikemcquaid
How would you add the S3 credentials if you want to have your boxen repo public?? I seams that is no a great idea to just add them to the config/boxen.rb file, right?
any idea?

I don't know but maybe you could use environment variables and wrap them somehow with another tool to set them?


[BUG] PowerShell ISE deleted after OO

Why OO tool delete Powershell ISE from Windows? I know, that is the part of hardening of OS, but is it necessary to remove ISE? Later, there are some problems with reinstallation.

Optimize-Offline does NOT remove PowerShell ISE from Windows. PowerShell ISE is now a FOD that can be SELECTED by the user to be removed either using its Capability Package or Cabinet Package. The only PowerShell variation Optimize-Offline does anything with automatically is the DISABLING of PowerShell 2.0 because it has been labeled a security risk by Microsoft, as detailed in the ReadMe. Moreover, this is simply the disabling of the PowerShell 2.0 Optional Feature, which can certainly be re-enabled during runtime if so desired.
The removal of PowerShell ISE would only occur if it was selected for removal.
Later.


Update settings.py to include the new federal hierarchy

settings.py defines the relationship between entities at different geographic levels. Update it to include definitions that fit the new federal structure.
See here for the old definitions: https://github.com/Code4Nepal/nepalmap_app/blob/dev/wazimap_np/settings.py#L21-L40
Update settings.py so that it includes the new definitions.

Pull Request https://github.com/Code4Nepal/nepalmap_federal/pull/9

Covered in #9


Schema Folder

Upload a Schema folder.

Uploaded a schema folder that contains the main database and user database.


Allows other users besides ubuntu (2nd round)

1st attempt to address this was reverted due to a buggy commit.
I think I managed to capture with a test the use case that observed the buggy behavior. If you have time @zmc and @andrewschoen , could you please point me to other use cases in teuthology or ceph-qa-suite that are not covered by the unit tests?

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1647/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1648/
Test FAILed.

thanks @andrewschoen . Any idea how to deal with this?:
cannot import name wraps

I wasn't getting this yesterday :confused:

See https://github.com/ceph/teuthology/pull/568 for the root cause of this issue. I've rebased that branch (pin-to-specific-versions) from this one (wip-10086) and have tested locally that PR https://github.com/ceph/teuthology/pull/568 solves this issue, making tests for this PR pass.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1674/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1675/
Test PASSed.

So this depends on a closed PR; what's the plan here?

#568 became obsolete after #571 got merged . Tests pass now but they might not capture all the use cases in teuthology and ceph-qa-suite

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1808/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1818/
Test PASSed.

is anyone still interesting in this PR?

Stale PR, closing. Reopen if it's still relevant?


cmd/cue: fmt should not attempt to resolve imports

Originally opened by @myitcv in https://github.com/cuelang/cue/issues/728

What version of CUE are you using (cue version)?

$ cue version
cue version +fdccfbc5 linux/amd64

Does this issue reproduce with the latest release?
Yes
What did you do?
A variation on #653
exec cue fmt x.cue
rm a/a.cue
exec cue fmt x.cue

-- a/a.cue --
package a
-- cue.mod/module.cue --
module: "mod.com"
-- x.cue --
package x

import "mod.com/a"

x: 5

What did you expect to see?
No error
What did you see instead?
> exec cue fmt x.cue
> rm a/a.cue
> exec cue fmt x.cue
[stderr]
import failed: build constraints exclude all CUE files in mod.com/a (ignored: x.cue):
    ./x.cue:3:8

This "bug" makes working with heavily-nested/-complex CUE hierarchies very painful, in editors where cue fmt is (normally acceptably) invoked on file save. Even when the imports /do/ exist, cue fmt's desire to walk/resolve the imports means that developing files inside such a hierarchy can become extremely painful.

Actually this issue (rather than https://github.com/cue-lang/cue/issues/1938) is the one which we should address with some urgency because it interacts badly with modules.
cc @mvdan

One way would be to tweak the way cue fmt calls load.Instances so that any package import errors are ignored. Arguably we should do that no matter what.
I reckon a perhaps simpler workaround in the near term would be to support a "file mode" in cue fmt (https://github.com/cue-lang/cue/issues/1731), because on the Go side I run gofmt -w . much more often than I do e.g. go fmt ./..., and in such a mode we wouldn't use cue/load at all as we would simply walk directories and find files with the CUE extension.
For now, we could enable this mode when all the arguments are CUE files, e.g. cue fmt x.cue or cue fmt *.cue. Later on, i would also want some mode where I can tell cue fmt to walk an entire directory tree, akin to gofmt -w . such as cue fmt files: ., but we can think about that in #1731.


Relic attribute refresh issue

Sometimes I equipment a relics such as constitution, equipment doesn't increase maximum health for the first time, and I am always in a state of injury, the second equipment can normal calculation, maximum health and seems everything is normal, then equipment of other related physical properties of belongings, I am the properties of the panel will increase crazy property values.
Screenshots show the same problem with luck.
Sorry for using machine translation

i had this same problem and the forge 1.16.5 version of RelicEx (the mod that adds the stat changing artifacts) is no longer being maintained and has this as a major bug,
i found a way to fix it but it is very long and complicated so a machine translator likely will not give a working description but I'll put it here for anyone else having the same problem and it requires uninstalling the mod
(you need to not have the affected world open for this)
you need to first delete relicex from your mods folder,
then go into your world and unequip every item including artifacts from other mods, armour, weapons, etc.
then you need to close and save the world.
After that you need to go to your saves folder, go to the affected world's folder and find a file called level.dat,
you then need to take this file and put it into an nbt editor (i used NBTExplorer as it is faster but a web based one such as webNBT would also work though can be laggy with something like this) then in the nbt editor you need to go find a file named "Data",
then in that there will be one named "Player", then in that find one named "ForgeCaps", then in that go to "playerex:playerattributes"
then lastly go into "Modifiers". in that should be a bunch of attributes, the ones that have an abnormally high amount of "entries" or things inside of them should be the stats that were wrecked by relicex,
since we are resetting the stats you want to go through every stat in the "Modifiers" folder and delete every entire inside of each stat,
to delete a large number at once in NBTexplorer you can select the the top entry then while holding down shift select the bottom entry and that will select every entry in between,
once you have done this for each stat you need to save in nbtexplorer or download the modified nbt file with webnbt then replace the old one
(you can ignore the level.dat_old file as this is a backup and if you've done nothing wrong it will automatically become identical to level.dat)
then you need to go load up your world again and your stats should be reset,
this will also reset any stats and levels gained in the playerex menu so to reset that you can temporarily turn on commands by opening to lan and setting cheats to on in the open to lan menu
then do the commands /playerex reset  then /playerex levelup  [amount] with the amount being the amount of legitimate playerex stat levels you remember having,


Feature Request: Support for two different tariffs (Feed-in tariff and purchase tariff)

Hi,
so far your sensor add-on really works great!
Feature request:
I think many people that use your integration will have a pv panel installation. For example I have a different feed-in tariff and purchase tariff and created two helpers for it:

sensor.my_gross_purchase_tariff  = sensor.epex_spot_data_net_price (configured with an absolute surcharge of 1.2 ct /kWh and Tax 20%).
sensor.my_gross_feed_in_tariff =  sensor.epex_spot_data_price  / 10 * 1.2

(both in ct/kWh)
Now I tried to solve that with a helper that combines both tariffs, that changes if I currently have PV surplus electricity:
sensor.my_gross_combined_price =
{% if states('sensor.mySmartmeter_total_power_togrid') | float > 5 %}
{{ states('sensor.my_gross_feed_in_tariff') }}
{% else %}
{{ states('sensor.my_gross_purchase_tariff') }}
{% endif %}
So the value of the sensor.my_gross_combined_price  helper switches from sensor.my_gross_purchase_tariff  to sensor.my_gross_feed_in_tarif if I am currently feeding in more than 5 Watts into the grid.
This basically works but unfortunately I can not use my sensor.my_gross_combined_price as a Price Input Sensor for your ha_epex_spot_sensor. The reason is, I guess, that my combined price sensor only contains data about the present and no attributes for the future.
So I guess we need a different approach here. My proposal would be, that you add the following fields to the configuration of your EPEX Spot Binary Sensor:

Could you implement this?
Or is there a more elegant way to achieve my goal?
thank you very much!

My gross Feed in Tarif is just EPEX Spot AT * 1.2 (20 % VAT).
My gross Purchase Tarif  is (EPEX Spot AT + absolute surcharge of 1.2 ct /kWh) * 1.2 (20% VAT).
You are right, it would be necessary to "predict" when to switch between tariffs. The underlying logic is simple: Whenever my PV installations produces more energy than I consume in my house, the feed in tariff is used. Whenever I consume more than I produce, the Purchase tarif is used.
Of course an exact prediction is impossible, because you never know in advance what I will consume or produce. But I think it does not have to be very precise, a rough estimation would be enough.
The goal is, to find the cheapest hours when to load my warm water boiler and start my washing machine...
For the prediction how much energy I will produce in a certain hour in the future, we could just use the following sensors provided by Forecast Solar :
sensor.power_production_next_24hours (in Watt).
or maybe better:
sensor.energy_production_today (in kWh)
and
sensor.energy_production_tomorrow (in kWh)
For the prediction how much energy I will consume I would just simply add a field where the user can enter a value. For example I know that the base load of my house is about 150W.
I might just enter that value (or a bit more) and I think the results might be accurate enough.
What do you think, is this doable?

A solution that includes solar forecast and (if available) SOC of a battery is on my wishlist. But this is a major enhancement and will take time.

@mampfes
Thx for your reply!
I just sent you a little donation to express my appreciation for your work.
Please let me know once this feature is implemented. Also let me know if I can do something to speed up the process and help you. Cheers!