fix: fix node environment import

Fixes #59

The issue was obliquely build-related, but more specifically an issue with properties of an hls.js instance being referenced in a node runtime, including constants. By moving any of these references to within the corresponding method scopes, this obviates the problem occurring as a result of simply importing or requiring the @mux/videojs-kit in these environments.

Confirmed reproduction of issue in two ways:

in a project with @mux/videojs-kit as a declared dependency

run node to start REPL
const videojs = require('@mux/videojs-kit); // throws error

% node
Welcome to Node.js v14.17.3.
Type ".help" for more information.
> const videojs = require('@mux/videojs-kit')
Uncaught TypeError: Cannot read property 'NETWORK_ERROR' of undefined
    at Object.819 (/Users/cpillsbury/dev/tests/test-vjs-mk-nextjs/test-vjs-mk-nextjs/node_modules/@mux/videojs-kit/dist/index.js:77:4852)
    at Qe (/Users/cpillsbury/dev/tests/test-vjs-mk-nextjs/test-vjs-mk-nextjs/node_modules/@mux/videojs-kit/dist/index.js:78:1629)
    at Object.18 (/Users/cpillsbury/dev/tests/test-vjs-mk-nextjs/test-vjs-mk-nextjs/node_modules/@mux/videojs-kit/dist/index.js:77:4128)
    at Qe (/Users/cpillsbury/dev/tests/test-vjs-mk-nextjs/test-vjs-mk-nextjs/node_modules/@mux/videojs-kit/dist/index.js:78:1629)
    at /Users/cpillsbury/dev/tests/test-vjs-mk-nextjs/test-vjs-mk-nextjs/node_modules/@mux/videojs-kit/dist/index.js:78:2137
    at /Users/cpillsbury/dev/tests/test-vjs-mk-nextjs/test-vjs-mk-nextjs/node_modules/@mux/videojs-kit/dist/index.js:78:2155
    at /Users/cpillsbury/dev/tests/test-vjs-mk-nextjs/test-vjs-mk-nextjs/node_modules/@mux/videojs-kit/dist/index.js:1:83

try importing statically in a nextjs app

run yarn create next-app to create an example app
go to directory and run yarn
yarn add @mux/videojs-kit
in the default example nextjs Home page, add import videojs from '@mux/videojs-kit';
run yarn dev
attempt to load the page, note the error

Server Error
TypeError: Cannot read property 'NETWORK_ERROR' of undefined
This error happened while generating the page. Any console logs will be displayed in the terminal window.

Confirmed solution by

checking out branch referenced in this PR, installing and building the project
yarn link the project
yarn link @mux/videojs-kit in the aforementioned project(s)
follow the same repro steps to confirm RTE no longer occurs.


Add specialized exception to Python client.

Summary
When trying Python client I wanted to have this code be idempotent:
dj.new_namespace(namespace="foo.bar")

, but it is not because we get
DJClientException: Node namespace `foo.bar` already exists

With this addition of specialized exceptions it will be easier to catch the exceptions that are safe to pass. And instead of doing something like:
try:
    dj.new_namespace(namespace="foo.bar")
except DJClientException as e:
    if "already exists" not in str(e):
        raise e

I'll be able to do:
try:
    dj.new_namespace(namespace="foo.bar")
except DJNamespaceAlreadyExists:
   pass

Also adjusted the contributing guide.
Test Plan

[ ] PR has an associated issue: #
[ ] make check passes
[ ] make test shows 100% unit test coverage

Deployment Plan
n/a

You probably have to run make check to get the linters going.


Refactor generate_huffman_table task

Pulls this task out of lib and regenerate the table.

@igrigorik Can you tell me if this makes sense to do?

I did a local install of this gem and tested it with CloudWatchLogs start_live_tail and Transcribe Streaming (both http2) and it appears to work.

Regenerating the table seems dangerous. Someone with more experience in this area should probably take a look.


feat: remember the network and broadcast address

I noticed that the count function didn't consider that a subnet requires a network and broadcast address. I also added the edge case of a /31 subnet and how that is handled by providers (even though it's not compliant ;))

Thanks for your contribution @cloudcosmonaut :purple_heart:


NTRs for clinical measurements

We would like the addition of these units to the ontology:
kilometer
milligram per deciliter
microgram per deciliter
micromole per liter

micromole per litre already added at UO:0010003

added:

kilometre at UO:0010066
milligram per deciliter at UO:0010067
microgram per deciliter at UO:0010068

apologies for the delay in adding the terms.


Remove ReachFive Lints

This is no longer a custom_lint plugin.

Thanks!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[BUG] setuptools._vendor.pyparsing.ParseException on pypy wiht tox with setuptools 60.9.0

setuptools version
60.9.0
Python version
pypy 3.7
OS
ubuntu linux
Additional environment information
No response
Description
Runnign tox with pypy and setuptools 60.9.0 produces:
  setuptools._vendor.pyparsing.ParseException: Expected W:(abcd...) (at char 0), (line:1, col:1)

The full traceback can be seen in this CI run: https://github.com/pyca/cryptography/runs/5192122892?check_suite_focus=true
Pinning to a previous version of setuptools resolves this, as can be seen at https://github.com/pyca/cryptography/pull/6868
Expected behavior
The dependencies are installed correctly, as happens on previous versions of setuptools.
How to Reproduce

git clone https://github.com/pyca/cryptography
tox -e pypy3-nocoverage

Output
Traceback (most recent call last):
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/_vendor/packaging/requirements.py", line 102, in __init__
      req = REQUIREMENT.parseString(requirement_string)
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/_vendor/pyparsing.py", line 1654, in parseString
      raise exc
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/_vendor/pyparsing.py", line 1644, in parseString
      loc, tokens = self._parse( instring, 0 )
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/_vendor/pyparsing.py", line 1402, in _parseNoCache
      loc,tokens = self.parseImpl( instring, preloc, doActions )
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/_vendor/pyparsing.py", line 3417, in parseImpl
      loc, exprtokens = e._parse( instring, loc, doActions )
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/_vendor/pyparsing.py", line 1402, in _parseNoCache
      loc,tokens = self.parseImpl( instring, preloc, doActions )
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/_vendor/pyparsing.py", line 3739, in parseImpl
      return self.expr._parse( instring, loc, doActions, callPreParse=False )
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/_vendor/pyparsing.py", line 1402, in _parseNoCache
      loc,tokens = self.parseImpl( instring, preloc, doActions )
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/_vendor/pyparsing.py", line 3400, in parseImpl
      loc, resultlist = self.exprs[0]._parse( instring, loc, doActions, callPreParse=False )
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/_vendor/pyparsing.py", line 1402, in _parseNoCache
      loc,tokens = self.parseImpl( instring, preloc, doActions )
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/_vendor/pyparsing.py", line 2711, in parseImpl
      raise ParseException(instring, loc, self.errmsg, self)
  setuptools._vendor.pyparsing.ParseException: Expected W:(abcd...) (at char 0), (line:1, col:1)

  During handling of the above exception, another exception occurred:

  Traceback (most recent call last):
    File "/home/runner/work/cryptography/cryptography/.tox/pypy3-nocoverage/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 363, in <module>
      main()
    File "/home/runner/work/cryptography/cryptography/.tox/pypy3-nocoverage/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 345, in main
      json_out['return_val'] = hook(**hook_input['kwargs'])
    File "/home/runner/work/cryptography/cryptography/.tox/pypy3-nocoverage/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 130, in get_requires_for_build_wheel
      return hook(config_settings)
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/build_meta.py", line 178, in get_requires_for_build_wheel
      config_settings, requirements=['wheel'])
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/build_meta.py", line 159, in _get_build_requires
      self.run_setup()
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/build_meta.py", line [174](https://github.com/pyca/cryptography/runs/5192122892?check_suite_focus=true#step:12:174), in run_setup
      exec(compile(code, __file__, 'exec'), locals())
    File "setup.py", line 54, in <module>
      rust_version=">=1.41.0",
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/__init__.py", line 155, in setup
      return distutils.core.setup(**attrs)
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/_distutils/core.py", line 109, in setup
      _setup_distribution = dist = klass(attrs)
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/dist.py", line 462, in __init__
      for k, v in attrs.items()
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/_distutils/dist.py", line 293, in __init__
      self.finalize_options()
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/dist.py", line 851, in finalize_options
      ep(self)
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/dist.py", line 871, in _finalize_setup_keywords
      self._install_dependencies(ep)
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/dist.py", line 881, in _install_dependencies
      for req in map(requirements.Requirement, always_iterable(ep.dist.requires))
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/dist.py", line 879, in <setcomp>
      reqs = {
    File "/tmp/pip-build-env-7y3pjwes/overlay/site-packages/setuptools/_vendor/packaging/requirements.py", line 105, in __init__
      f'Parse error at "{ requirement_string[e.loc : e.loc + 8]!r}": {e.msg}'
  setuptools._vendor.packaging.requirements.InvalidRequirement: Parse error at "''": Expected W:(abcd...)
  error: subprocess-exited-with-error

I'm guessing that the relevant change (history) is the bump of packaging.

This repro is quite difficult to follow given that it requires pypy, rust, openssl, and still the error happens in an isolated pip environment without any access to the source.

Would it be helpful if I put together a Dockerfile that built an environment for reproducing this?
There's unfortunately not much I can do about the moving pieces here, they're what's involved in reproducing this. (As for the isolated pip environment, I can take even less responsibility for that!)

I've made some progress, but thanks. Still working on it...

I'm now confident 2d6cc80fae6d17455a124391eab39eb4eddfee2f is implicated.

The issue stems from the fact that importlib_metadata returns different types for cffi's requires:
cryptography main $ pypy -m pip-run -q cffi importlib_metadata -- -c "import importlib_metadata as md; print(md.requires('cffi'))"

cryptography main $ py -m pip-run -q cffi importlib_metadata -- -c "import importlib_metadata as md; print(md.requires('cffi'))"
['pycparser']

Hmmm, on pypy cffi is pre-installed and ships with the interpreter AFAIK (it's for this reason that we don't even list it as a dependency on pypy! https://github.com/pyca/cryptography/blob/main/pyproject.toml#L8). Where does the metadata come from in that case?
I guess in the first instance the question is whether PyPy is in the wrong for this to be an empty string, or whether it's an edge case that importlib_metadata fails to handle correctly?

My guess is the use-case is under-specified. What I can say is that the data is coming from the egg-info path:
cryptography main $ pypy -m pip-run -q cffi importlib_metadata -- -i -c "import importlib_metadata as md; dist = md.distribution('cffi')"
>>>> dist._read_dist_info_reqs()
>>>> dist._read_egg_info_reqs()
''
>>>> dist._path
PosixPath('/usr/local/Cellar/pypy3/7.3.7/libexec/lib_pypy/cffi.egg-info')


Error Module not found: Error: Can't resolve 'react-native'

Hello all,
I am using hybride-crypto-js with webpack but getting below error:
ERROR in ../node_modules/hybrid-crypto-js/lib/keymanager.js
Module not found: Error: Can't resolve 'react-native' in '/home/hyper1/Sawtooth-projects/webpkdemoo/node_modules/hybrid-crypto-js/lib'
@ ../node_modules/hybrid-crypto-js/lib/keymanager.js 1:0-42 30:8-20 40:8-20
@ ../node_modules/hybrid-crypto-js/lib/index.js
Can anyone help me to solve this issue?

I've got this same problem while using an Angular 4 project.
Any fix idea or that?

I'm getting a similar issue with a react web project; running the example code works in a fresh codesandbox project, but using the exact same code doesn't work in a create-react-app project.
I'm guessing no one has found a solution yet?

Hello all,
The hybrid-crypt package was written for React Native, so you have to comment the react native part out.
In hybrid-crypto-js>lib>index.js you have to comment the following section.
// Include keyManager if running React Native
// if (typeof navigator != 'undefined' && navigator.product == 'ReactNative') {
// var keyManager = require('./keymanager');
// libs['keyManager'] = keyManager;
// }
It should compile if you make that change.
Problem is that each time you add a new package you have to comment that code again. Don't know if one can comment that code when you import hybride-crypto-js

This should be now fixed. Key management is now deprecated and all the relations to react-native are gone.


Dormant submission reverts to "closed" status. Should be "open".

Received e-mail notifying submission had been dormant for 30 days and would be removed:

Issue 1:
The hyperlinks in the email are not accessible off VPN: http://<IP_ADDRESS>/gwas/deposition/submission/6063239a37158e000124e0de
Issue 2:
The submission status should revert to 'Open'.

Please revert the status of this PMID (33462484) back to 'open for submission'.

submission unarchived for now, the rest is TODO

dormant SS only submission => publication reverts to 'Open for SS submission'
dormant metadata or metadata + SS submission => publication reverts to 'Open for submission'
no changes for GCP behaviour


Feature - Allow ordered_logistic to take array of integers as input

Submission Checklist

[x] Run unit tests: ./runTests.py test/unit
[x] Run cpplint: make cpplint
[x] Declare copyright holder and open-source license: see below

Summary:
Adds functionality and testing for the ordered logistic distribution to take an array of integers and vector of continuous location variables as inputs - assuming that all have the same cutpoints (i.e. N responses on a given item).
What was this:
  for(n in 1:N)
    for(j in 1:J)
      y[n,j] ~ ordered_logistic(lambda[n,j], cut[j]);
    }
  }

Can now be written as:
  for(j in 1:J)
    y[j] ~ ordered_logistic(lambda[j], cut[j]);
  }

Intended Effect:
Simplify specification of ordered logistic distributions.
How to Verify:
./runTests.py test/unit/math/prim/mat/prob/ordered_logistic_test.cpp test/unit/math/prim/mat/prob/ordered_logistic_log_test.cpp

Side Effects:
The Stan parser will need to be updated to add signature:
int[] ~ ordered_logistic(vector,vector)

Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Andrew Johnson
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

Thanks for the quick review, much appreciated! I've addressed those comments. I'm still fairly new to c++, so I haven't done much with templating.
After some thought I've also added the option to specify an array of ordered cutpoints, so the signature would be:
int[] ~ (vector, vector[])

This would address the use case where the array of integers are an individual's responses to J different items. So instead of:
for(n in 1:N)
  for(j in 1:J)
    y[n,j] ~ ordered_logistic(lambda[n,j], cut[j]);

You could write:
for(n in 1:N)
  y[n] ~ ordered_logistic(lambda[n], cut);

Let me know if there's anything else I can do with this to make it more efficient.

Thanks for updating.
For templates, I'd recommend Vandevoorde and Josuttis's template book as well as Alexandrescu's. They need updates (as do I) for C++11.

Looks like the second edition of Vandevoorde and Josuttis's book is out with updates for c++11, perfect. Thanks!

The templates for ordered_logistic_log are now all sorted and working without issue.
There were a couple of the checks that I could pull out of the loop (checking that values were finite), but the rest couldn't be pulled out without compile errors (since each element of the array is a vector). Let me know if there's another way of vectorising those checks.
Unless there were more changes this should also be safe to test with Jenkins now as well.

Jenkins, retest this please.

@seantalts  I was going to merge this, but it looks like an issue with Jenkins not running.  Any idea what's going on here?  I still don't really get how we're supposed to test external pull requests.

@seantalts  never mind on that last comment (erased)---it did kick off Jenkins, it's just slower to respond than it used to be.

Jenkins, retest this please.

@seantalts I think the jenkins build for this one is stuck, would you mind having a look?

Jenkins, retest this please.

Jenkins, ok to test.
Jenkins, retest this please.


Setup "dialects" structure

@kibertoad would you be able to run me through the structure and ideas of the main Knex repo (primarily "dialects")? I'd like to keep the general structure / lingo the same here as for the main project, but I'm not that familiar with the internals of Knex itself yet.. (Also down to hop on a zoom/meet/whatever call if that's easier 🙂 )

@rijkvanzanten Honestly, I would question everything about Knex structure, it was designed ages ago and not everything stood the test of time. And since knex instance with active connection probably should be passed as a dependency to inspector, I don't think we need dynamic driver resolution, instead we can do something like Strategy resolver based on client inside knex.

I think currently we mostly use Gitter for knex discussions, but I'm down to setup a Slack channel if you prefer that.

I couldn't find you on Gitter 🤔 I'm down for Slack as well 👍


[BugFix] Revert "[Feature] Turn on query cache in default"

temporary reverts StarRocks/starrocks#29792
will take statistics collection error

[FE Incremental Coverage Report]
:heart_eyes: pass : 1 / 1 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
1
1
100.00%
[]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:heart_eyes: pass : 1 / 1 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
1
1
100.00%
[]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:heart_eyes: pass : 1 / 1 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
1
1
100.00%
[]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

@mergifyio backport branch-3.2


Mast: Watch mydock365.com

Mast requests the watch of the watch_keyword mydock365\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by tripleee in Charcoal HQ


SPIM transaction timeout leads to crash

I have discovered a defect in the spi_nrfx_spim.c driver causing hard faults on my nRF5340 based system. This is related to my question about the thread-safety of spi_transceive(). Apparently, this particular driver does serialize thread access to the SPIM. However, it turns out that it was timing out while waiting for the transaction to complete. I happened to be using a rather slow SPI clock (125KHz) that aggravates the problem. The calculated timeout was too short and no attempt is made to abort the SPI transaction. Subsequently, after the driver returned with an the timeout error, the transaction completed (after the interrupt fired)  leaving the SPIM driver in a corrupt state.
By necessity, I'm using a Nordic SDK v1.7.1 version of Zephyr, but this issue seems to still be present in the main branch.
Here is a patch showing my solution. Comments welcome.
diff --git a/drivers/spi/spi_nrfx_spim.c b/drivers/spi/spi_nrfx_spim.c
index 43502a6ec7..12695e2996 100644
--- a/drivers/spi/spi_nrfx_spim.c
+++ b/drivers/spi/spi_nrfx_spim.c
@@ -239,6 +239,30 @@ static int transceive(const struct device *dev,
        transfer_next_chunk(dev);

        error = spi_context_wait_for_completion(&dev_data->ctx);
+        if( error ) {
+            /* This is typically a -ETIMEDOUT error.
+               In this case, we MUST assume that the SPIM
+               transfer is still proceeding and that the
+               completion sync semaphore is in an unknown
+               state and that an interrupt indicating the
+               end of the transfer and setting the sync
+               semaphore MAY still happen.
+             */
+           const struct spi_nrfx_config *dev_config = get_dev_config(dev);
+            /* Disable the transfer interrupt. */
+            nrf_spim_int_disable(dev_config->spim.p_reg, NRF_SPIM_INT_END_MASK);
+            /* Abort the transfer */
+            nrfx_spim_abort(&dev_config->spim);
+            /* Since the chip-select is set to false in the ISR
+               which calls transfer_next_chunk() and the ISR MAY NOT
+               have happened, we need to deassert the chip-select here.
+             */
+           spi_context_cs_control(&dev_data->ctx, false);
+            /* Ensure the sync semaphore is reset in case an
+               interrupt actually did happen.
+             */
+            k_sem_reset(&dev_data->ctx.sync);
+        }
    }

    spi_context_release(&dev_data->ctx, error);

After a review of the other SPI drivers in the same directory that use spi_context_wait_for_completion() it seems that this may be a rather common problem if -ETIMEOUT is returned.

@mnmoron Thank you for reporting this! There are actually two problems here: the first is that the expected transaction time is calculated incorrectly (and this is addressed in #53957) and the second is that transaction timeouts are not handled properly in nRF SPI drivers (this is addressed in #53965). Please check if the provided solutions work for you.

@anangl Thank you for addressing this issue. I reviewed your changes and from what I can tell they accomplish approximately the same thing. However, as I mentioned in the original submission, we are using an older Nordic fork of the Zephyr code and upgrading is problematic at this point. Therefore, I won't be able to test your changes in the foreseeable future.
At this point, I am satisfied and you may close this issue.


Update InfluxDB AE details for 1.6

Data nodes don't "need" shards, they "own" them.

Document the meaning of AE log messages.

Document the process of how entropy is detected.


Provide auto-completion in CORS input fields for basic HTTP headers

From @bcollard on April 7, 2016 8:20
When you set CORS directives, you must type Allow-Headers & Expose-Headers manually. Please provide some kind of helpers to accelerate these inputs.
Copied from original issue: gravitee-io/gravitee-management-webui#135

This issue was moved to gravitee-io/ichiou#32


APIv2: ping endpoint is 404

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
libpod/_ping endpoint does not seem to be correctly wired up.
Steps to reproduce the issue:
sudo curl --unix-socket /run/podman/podman.sock http://d/v1.24/libpod/_ping returns Not Found.
Also tried libpod/ping, ping, _ping but all are 404. According to doc it should be libpod/_ping.

Ah thanks, I totally not guessed it would be unversioned.
The documentation does not mention this in any way and it it utterly confusing.

Do the above commands work as expected for you?

Yes it does.

Would additional details in the documentation have prevented this confusion?

Absolutely. It should be obvious how to use this endpoint, especially since it differs from other ones.


Reformat

White space is very inconsistent, naming conventions are all over the place, just a bit daunting to actually fix.

Can you assign me this issue?

Oh, uh sure you can also just make the change without being assigned. Try to stick to snake_case for as much as you can, and 4 spaces for tabs.

how to run this

Uh, run mkdir out to make the output directory, then run make to compile changes, then out/able with the arguments as given in the usage menu

Fixed by ea8d4b83290814fa4a78562689f40ab8386111cd, @khanh130202 don't worry about this anymore.


istioctl version cli

When I perform
istioctl version > toto                                                                                
Version: 0.5.0
GitRevision: c9debceacb63a14a9ae24df433e2ec3ce1f16fc7
User: root@211b132eb7f1
Hub: docker.io/istio
GolangVersion: go1.9
BuildStatus: Clean

and perform more toto, file is empty. Because output of command line is redirected to stderr:
istioctl version 2> toto
more toto
Version: 0.5.0
GitRevision: c9debceacb63a14a9ae24df433e2ec3ce1f16fc7
User: root@211b132eb7f1
Hub: docker.io/istio
GolangVersion: go1.9
BuildStatus: Clean

Is it possible to correct output of cobra subcommand version ?

I've propose #3450
Because it's my first PR on this repo let me know if it's correct

you're right that normal output should go to stdout not stderr - thanks for noticing this

pro tip add "Fixes xxx" in your PR to autoclose issues


Move state-storage functionality to separate package

Signed-off-by: Mykola Solianko<EMAIL_ADDRESS>

coverage: 81.5% of statements


Command line option for config location

I'm using phabulous on a FreeBSD system, and I've found that phabulous only picks up the config file if my shell session is in the same directory as the phabulous executable.  This makes it difficult to daemonize phabulous and treat it as a service.  I saw that it's possible to use environment variables to store the config settings, but I wonder if it might be easier to be able to specify the config location on the command line such as /usr/local/bin/phabulous --config /usr/local/etc/phabulous/main.yml serve.

Implemented in latest release.


Doc updates

This PR updates much of the existing Markdown documentation files for the project in the following ways:

Updates Grafana related images using Grafana 8
Updates OCI console related images using current version
Updates most of the plugin document files (except the main README.md file) to actually talk about the logging plugin instead of the metrics plugin.
New content related to:

Types of log data that can be presented
How to use Grafana Transform feature on log records
How to use the logs plugin to present log-based metric data (both with and without a specified time interval)
How to use the logs plugin template variables
How various features of the logging query language effect data presented in data panels

Other miscellaneous cleanup

Made some minor editorial changes to the updated documentation pages.


[WFLY-19028] Upgrade openjdk-orb to 10.1.0.Final

https://issues.redhat.com/browse/WFLY-19028
This upgrade is because JDK22 related modifications.
cc @ropalka

Thanks @tadamski !


feat: Added Gateway Route Reports Integration tests for PYTHON-SDK.

PR summary
The Integration Tests for PYTHON-SDK needed to be updated to cover the new Gateway Route Reports APIs.
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[x] Feature
[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[x] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?
All tests passing without the Route Report integration tests.
What is the new behavior?
All tests passing with the Route Report integration tests.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
N/A

:tada: This PR is included in version 0.14.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

Related to https://github.ibm.com/CloudBBS/ts-planning/issues/3374


[Request] Add RainWallpaper

RainWallpaper is a powerful live wallpaper engine that allows you to use various types of customizable animated wallpapers on your Windows desktop, including 3D and 2D animations, websites, videos, with mouse interaction and cool effects, and with minimum cpu and ram usage. Download live wallpapers via the built-in online gallery with one-click or create your own and share it to our DeviantArt Group!
A portable version is available on their website.

This app is now on Steam, so this issue can be closed.


simplify reflection code

Use https://github.com/oleiade/reflections to simplify the reflection code here

hard to say how much this is getting better tbh, the class shrunk by 4 lines and while code complexity is down - I dont think its worth carrying an extra dependency for this gain


Moving css files into own directory, using typography-plugin and whitelisting

First of all thank you very much for creating that starter template, it's one of many that I tested and one of only a few that works well in my repo!
I have a couple of questions as I want to adopt it to my needs, would highly appreciate if you could answer them:

Can I move the .css files into an directory to have it structured? I'm thinking about created multiple css-files (e.g. for the components) and would like to keep the files inside the root at a minimum.
What's the reason of "@tailwindcss/typography" needing to be in dependencies instead of devDependencies, shouldn't it be behave the same? And is there a down side of not using the typography-plugin? Looks like your boilerplate code is the only jekyll one using it, so wondering about the reason/benefit/alternative
How can I add css-styles/files that doesn't get purged? I'm using lightbox (or similar) and in my previous purgecss.config.js I had whitelistPatterns: [/mfp-.*/] defined, does that work the same in the tailwind.config.css

Thanks for your answers and time in advance

You're welcome and I'm glad it's working in you repo!

Can I move the .css files into an directory to have it structured?

Yeah I actually like that idea so I just pushed an update to do that. Get the latest on master and everything will be under the styles folder. Here's the commit in case you wanted to see how I did it/do it yourself.
Now when you add new CSS files you have two options:

Import them via the index.css file like syntax.css is. This will get picked up by Parcel and will bundle it along with everything into the dist/index.css file.
Import a CSS file directly via Jekyll by referencing it from the head.html file

What's the reason of "@tailwindcss/typography" needing to be in dependencies instead of devDependencies?

Yeah my bad. In this case it didn't affect anything in dependencies but I've just moved it to devDependencies to keep it clean.

is there a down side of not using the typography-plugin?

It just provides some nice default styles for markdown generated elements (like in the demo article here). Without it you would have to style and whitelist any generated elements via Tailwind yourself (like headers, paragraphs etc). More info here.
You can use it for blog posts (via the prose classes) and ignore it for everything else. And if you don't need it then feel free to remove it as it adds ~18KB to the final CSS file.

How can I add css-styles/files that doesn't get purged?

You can access all the PurgeCSS options via the tailwind.config.js as shown in the docs here. There's a good more advanced example here which I found useful before.

Hope that helps! Have any further questions at all?

Again, Thank you very much!


FEAT: Include test option for compiling notebooks selective with and without code tests

Thanks @jlperla for the following:
@arnavs You can take a shot at this.  The basic idea is that we would introduce a :class: test  as a parallel to :class: solution`
The beautiful thing now is that we can almost use identical code wherever the word solution is used in the https://github.com/QuantEcon/sphinxcontrib-jupyter/pull/72/files
In partiular,

in sphinxcontrib/jupyter/__init__.py

app.add_config_value("jupyter_drop_tests", False, "jupyter")

in sphinxcontrib/jupyter/writers/translate_code.py  we need to parse the test class and add a flag in the visitor

self.test= _parse_class["test"]

Then in the visitor if we are in a test and the option is set to drop them, we just pass and don't output the code.  i.e.
 if self.solution and self.jupyter_drop_solutions:
            pass

In tests/conf.py  we set the option with jupyter_drop_tests = True or jupyter_drop_solutions = False
Add tests, of course.

You can ask @mmcky  but I think a lot of the other stuff in the PR also does something with output blocks, which I believe is orthogonal?

@mmcky I think we can close this now.

thanks @arnavs


Add Stefan Yonkov as reviewer

contributions were listed in https://github.com/cloudfoundry/community/pull/794#issuecomment-2017726400

Welcome to the ARI working group.


Add the README.md file for the TodoTemplate project (#1544)

this closes #1544

How to change email template contents and test them (Local folder concept)? How to use the email server in prod?
How to change the password policy for signup?
What are known and unknown exceptions?
Talk about TodoTemplateJsonContext and System.Text.Json source generator
How the mechanism of syncing code between app and web work? (Talk about duplicated files such as index.html)
Client side exception handling WrapHandled

what is the issue of this PR?

what is the issue of this PR?

#1544

@MeysamBahadori
@ysmoradi
why this PR is closed?

This pr was based on the Develop Branch, which prevented parallel development, so it was removed and built on the related Issue branch base.
Senior .NET (Full-stack) Engineer
Meysam bahadori (+989397524270)

From: Saleh Yusefnejad @.>
Sent: Sunday, June 12, 2022 2:55:03 PM
To: bitfoundation/bitplatform @.>
Cc: Meysam Bahadori @.>; Mention @.>
Subject: Re: [bitfoundation/bitplatform] Add the README.md file for the TodoTemplate project (#1544) (PR #2154)
@MeysamBahadorihttps://github.com/MeysamBahadori
@ysmoradihttps://github.com/ysmoradi
why this PR is closed?
—
Reply to this email directly, view it on GitHubhttps://github.com/bitfoundation/bitplatform/pull/2154#issuecomment-1153123152, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZQP72WKWEXTLNOG7QRW4I3VOW3H7ANCNFSM5YDIXKSQ.
You are receiving this because you were mentioned.Message ID: @.***>


Alignment guarantees

I'm working on a multiphysics simulator and we switched from the standard VS allocator to mimalloc. That gave us for free an overall 10% decrease on wall time in our regression test suit!  That was really impressive.  Since we use some tagged pointers in the code, alignment guarantees are important for us and I want to fully understand what mimalloc is doing in order not to shoot myself in the foot!
In Visual Studio, malloc always returns an 8 byte aligned region for 32 bits code and a 16 bytes aligned region for 64 bits code.
When using mimalloc to override malloc and friends, the alignment guarantees are a bit different, and depend on the allocation bucket size, which is always a multiple of sizeof(uintptr_t) - 4 bytes on 32 bits and 8 bytes on 64 bits.
Available bucket sizes can be found on the MI_PAGE_QUEUES_EMPTY macro and multiples include 1, 3, 5, and 7 which gives bucket sizes that are NOT multiples of 8/16, so, for example, if an allocation fits in a 24 bytes bucket (but not in a 16 bytes bucket), the returned pointer will be 8 bytes aligned on a 64 bits machine. For bigger bucket sizes there are no differences since they will always be a multiple of 8/16.
Is this understanding correct?
Thanks,
catmendes

I had a similar issue. Here's what I found:
By default, MI_MAX_ALIGN_SIZE is 16 bytes, but this doesn't really affect allocations smaller than 16 bytes. On 64-bit platforms, the used bins are 8-bytes, 16-bytes, 32-bytes, 48 bytes, ... On 32-bit platforms, there's also a bin for 4-byte allocations. As you noticed, these are expressed as multiples of the word size. I think the 3, 5, and 7 bins are not used unless you change the value of MI_MAX_ALIGN_SIZE.
For  tagged pointers, the 1-word bin might be a problem. The alignment and choice of bin is controlled by _mi_bin. You can either modify _mi_bin or ensure that all your allocations are larger than 8 bytes.
https://github.com/microsoft/mimalloc/blob/6a744a8549263696ef8d620006a0de2249e59b46/src/page-queue.c#L100-L137

@catmendes @colesbury An object of size 16, can be created like so alignas ( 16 ) char, this creates a 16-byte object, containing 1 char of size 1 byte, the rest is padding (this requires to take care with memcpy, which will possibly copy a lot of rubbish.).

Apologies for not replying earlier, but @colesbury is right; Generally, on 64-bit:

up to 8 bytes is 8 byte aligned
anything larger is at least 16-byte aligned
If you use the aligned allocation API the alignment is always respected (recently).

Internally, but perhaps not guaranteed in the future, any power-of-2 size up to 4096 is also aligned to its own size.


[Bug]: zotregistry.io is down

zot version
not relevant
Describe the bug
The website under zotregistry.io is down.
To reproduce

Open a browser
point to https://zotregistry.io

Expected behavior
Website loads and documentation can be viewed
Screenshots
No response
Additional context
No response

This is worrying:
$ date;  whois zotregistry.io | head
Do 4. Jan 16:30:28 CET 2024
Domain Name: zotregistry.io
Registry Domain ID: dd1cc964ac71472d8d9ec5c4d77abe59-DONUTS
Registrar WHOIS Server: whois.1api.net
Registrar URL: http://www.1api.net
Updated Date: 2023-12-31T19:06:38Z
Creation Date: 2021-11-17T18:26:15Z
Registry Expiry Date: 2023-11-17T18:26:15Z
Registrar: 1API GmbH
Registrar IANA ID: 1387
Registrar Abuse Contact Email<EMAIL_ADDRESS>

I deleted my comment  with evidence of failure to renew earlier this morning CET, after considering the problems that this information might cause...

https://github.com/project-zot/zot/issues/2157
Yes, addressing this.

https://zotregistry.dev/
If using helm,
helm repo add zot https://zotregistry.dev/helm-charts/
Between Google domains sale to Squarespace, renewal notice sent out during holidays, etc, zotregistry.io has been parked. We are trying to revive it, however, going forward would move to https://zotregistry.dev/ - we have put in better control/process around this. Our sincerest apologies for this disruption 😞


Enable recording of identical requests

This PR will introduce the tracking of identical requests, thus enabling PHP-VCR to record different responses of the same request within the same cassette. This closes issue #132
Right now PHP-VCR only tracks one occurrence of a given request
per cassette. An example of why this is troublesome is given below.

(1) Request a resource from an external endpoint (GET /resource)
(2) Request an update to that resource (PUT /resource)
(3) Re-request the resource to confirm it was persisted remotely (GET /resource)

Requests (1) and (3) are identical, however the responses are expected
to be different. PHP-VCR will only record (1) and use the saved version
on (3).
This commit keeps track of the order of occurrence of requests, meaning
(1) is the 1st occurrence of (GET /resource) and (3) is the 2nd. When
the test is re-run, when running (3) PHP-VCR will now look for a
saved request which is the 2nd (GET /resource).
Ref #132

For me this is a +1, It would be great if someone else reviews this merge request to ensure that we won't break anything (I'm a maintainer but I'm relatively new to this codebase).

Okay, I am neither completely fluent in the codebase, however it seems that @adri has gone AWOL

What is current status of this PR, could I help somehow?


[Feature]: Beautify the Programs Page

Is your feature request related to a problem? Please describe.
The programs page at https://www.nsccbpit.tech/programs needs some beautification while staying aligned to the overall scheme of the project.
Describe the solution you'd like
Any efforts which lead to a more friendly UX and better responsiveness are appreciated.
Describe alternatives you've considered
No response
Additional context
No response

Hi @pradeeptosarkar! Please assign me this issue to work on for hacktoberfest 2023.

sure @yashthipsay go ahead

@yashthipsay are you still working on this issue

Hi, is it possible to assign me this issue? I have experience in UI/UX design as well as in web development.

@robo311 would you like to take it?

Hello, can you assign this issue to me? I'm also a UI/UX designer...... I and @robo311 can both work on it

@robo311 @A1ya1 assigned to you guys

Thank you, I'll work on it asap

[Feature]: Beautify Program Pages.

How is it?

@A1ya1 looks good

@A1ya1 looks good

oh, okay......Here's the figma file for @robo311  or anyone who'd be developing it.........
https://www.figma.com/file/6qx1WnhWb4DMYDiLkyb3bj/Untitled?type=design&node-id=2%3A196&mode=design&t=8lWnoQH5nZvnV8E7-1

@robo311 are you still working on this issue?


Adding deprecation warning for mbed-os 5.10

Starting mbed-os 5.10 the SD driver has moved into mbed-os.
Therefore this PR is adding a warning in the SD documentation for the incoming depreciation.
This PR is dependent on PR #7774
https://github.com/ARMmbed/mbed-os/pull/7774

@yossi2le - Warning in Readme is great.
Can we add additional warning in code as well?
https://github.com/ARMmbed/sd-driver/blob/master/SDBlockDevice.cpp#L147

@geky  - Should we remove travis builds as well?

To be merged after - Mbed OS 5.10 release

I think leaving travis as is is a good idea 👍
This repo is no longer supported, CI failures only help point that out.

@geky  - I created PR, before I saw this comment.. Feel free to close it without merge.

Ah I think I actually made the comment after you made the PR. But thanks for that anyways :)


Split up installation pages

This should make it a bit easier to figure out what is for what.

You can see what it looks like here: https://sharkwouter.github.io/pspdev.github.io/

looks good, much better. thanks wouter!


[ALLUXIO-3066]: Clean up Embedded Channel tests

https://alluxio.atlassian.net/browse/ALLUXIO-3066

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17951/Failed Tests: 2org.alluxio:alluxio-core-client-fs: 2alluxio.client.block.stream.NettyPacketWriterTest.writeFileManyPacketsalluxio.client.block.stream.NettyPacketWriterTest.writeFileManyPackets
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17952/Failed Tests: 4org.alluxio:alluxio-core-client-fs: 4alluxio.client.block.stream.NettyPacketWriterTest.writeFullFilealluxio.client.block.stream.NettyPacketWriterTest.writeFullFilealluxio.client.block.stream.NettyPacketWriterTest.writeFileManyPacketsalluxio.client.block.stream.NettyPacketWriterTest.writeFileManyPackets
Test FAILed.

Jenkins, test this please.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17959/Failed Tests: 4org.alluxio:alluxio-core-client-fs: 4alluxio.client.block.stream.NettyPacketWriterTest.writeFileChecksumOfPartialFilealluxio.client.block.stream.NettyPacketWriterTest.writeFileChecksumOfPartialFilealluxio.client.block.stream.NettyPacketWriterTest.writeFileManyPacketsalluxio.client.block.stream.NettyPacketWriterTest.writeFileManyPackets
Test FAILed.

@calvinjia Thanks for running the tests again. This is weird, this time different test cases failed. And if we try running these tests locally in Debug mode, they pass.

@gurmeetb I suspect there is some kind of race condition which can lead to some kind of deadlock or starvation (since the tests are timing out). Debug mode with breakpoints may cause the timing to be affected.

@calvinjia Yes, I also think so. An alternative would be to go with CountDownLatch since two threads may be affecting. I will test locally once and then push if it fixes the issue. Will keep posted soon.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17960/
Test PASSed.

Jenkins, test this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17973/
Test PASSed.

@gurmeetb Thanks for improving the code and removing the extraneous logic!


Enhance Test Infra to Support Latest Version of Golang

Is your feature request related to a problem?
When new versions of golangs are released, we have to spend a decent amount of time updating all of the docker files.
Describe the solution you'd like
Update the process to automatically get the latest version of go, and have that version applied to all dockerfiles. This can be accomplished by updating ./build-images.sh to curl/wget the latest version from golang's official site then pass that env to all of the docker files. Something like the below:
GO_VERSION=$(curl -s https://go.dev/VERSION\?m\=text 2> /dev/null | head -n1)
echo $GO_VERSION being passed to dockerfiles

Describe alternatives you've considered
NA

@a-hilaly Putting this down 'on paper', so we can refer to it later. Please add your thoughts, or things I missed in this process.


Password "Save Password" not working

If you hit "save password" and check the box, reopen "Jamf-Framework-Redeploy" the password is gone.
Thanks for app great work use it daily!

Hi there
Thanks for the feedback. I have just posted v1.0.1 which should fix the keychain issue. Let me know if you see any other issues.

Still no luck, its stays unfilled and greyed out.


Limit the action to specific arm modes

Alarmo Version
v.1.8.1
HA Version
2021.9.7
Bug description
Hi I would like to report this bug. When limit action mode is selected (es: Night Armed), push notification in case: 'Alarm is disarmed' does not occur. Push notification sends all Alarm is disarmed messages, for example also those set by armed_away
Steps to reproduce
No response
Relevant log output
No response

This is not a bug. In disarmed state there is no arm mode (the alarm is not armed anymore).
I could maybe hide the field in case disarmed is selected, to make it more clear.

OK thanks. Therefore only one notification is possible in disarmed state.


Detect animation ending

I would rather use the jQuery .on() listner instead of .one(). Animation could be triggered multiple times then, for example if you add an animation on .hover().
It's just a README.md related improvement …
$('#yourElement').on('webkitAnimationEnd mozAnimationEnd oAnimationEnd animationEnd', doSomething());

How can I detect animation end without using jQuery?


SQLSTATE[42000]: Syntax error or access violation: 1055 'portal.threads.author_id' isn't in GROUP BY

Any idea why I get this error?
It only happens when visiting the /forum route.

@wilburpowery are you using the DB on Homestead? I can't seem to reproduce.

I'm going to close this now but feel free to reply if you still experience this.

I managed to resolve it temporarily by adding the following groupby attributes to the query.
However, I believe a better fix is needed and I will continue digging into it and raise a PR when I can.

Laravel can enable ONLY_FULL_GROUP_BY when querying using config variable.
on config/datagase.php
set 'strict' => false
It should work.


fix: added pinned showcase entries

In #3726, adding another pinned entry put the landing page showcase off grid.  Added 4 others to fix this.
Now

Can we also update the mattermost app icon to one taken from AppStore (so it fills the icon shape better)?

https://apps.apple.com/us/app/mattermost/id1257222717


archive products page

[ ] <Archived Products Page -  folder fixed

i will have to open i new issue because i send it wrongly, i am trying fixing a problem with folders organization


Make the prompt interactive.

Instead of using flags, we can rather make the prompt interactive.

do you have any plans


convert new endpoint block data to props

modify the data from new endpoint to match expected props formats, populating components with blocks data.

pattern repeats for tx / tokens


I am coding in visual studio code and learnig C programming language. In this extension named code runner is not working, it is showing that "scriptcs is not recognized as internal or external command", can anybody help and it is also showing that the "system cannot find the path specified" .

can anybody help and it is also showing that the system cannot find the path specified in vscode.

Sorry, but nobody will able to help you with given you have provided no information

Wondering if this is an extension issue or even a setup issue (like misconfigured PATH variable)?
If this has to do specifically with Code Runner, please file an issue for it at https://github.com/formulahendry/vscode-code-runner.

can anybody help and it is also showing that the system cannot find the path specified in vscode.

Sorry, but nobody will able to help you with given you have provided no information

Sir what all information should i provide.

I looks like the error message comes from the code runner extension.
The extension readme says: To run C# script, you need to install scriptcs. Did you do that and is the command on the PATH?
If that isn't the problem, please file an issue with steps to reproduce against https://github.com/formulahendry/vscode-code-runner/issues


Refine memory management for SeqType

KrnlSeqAlloc and KrnlSeqDealloc are introduced to support deep deallocation for the sequence type.
The lowering of onnx sequence ops are changed according to the new design, which is described in docs/SequenceType.md.
The new design guarantees there is no memory leak or dangling pointer for operations on onnx sequence type.

@AlexandreEichenberger I made changes according to your comments.

Jenkins Linux ppc64le Build #7294 [push] Refine memory management... started at 16:05

Jenkins Linux amd64 Build #8228 [push] Refine memory management... started at 15:05

Jenkins Linux amd64 Build #8228 [push] Refine memory management... passed after 1 hr 4 min

Jenkins Linux s390x Build #8244 [push] Refine memory management... passed after 1 hr 26 min

Jenkins Linux ppc64le Build #7294 [push] Refine memory management... passed after 1 hr 37 min


NSSet/CFSet bridging

Implements the bridge between NSSet and CFSet in the same way as the other NSCF classes.
I believe that NSSet member() now behaves as expected, returning the actual object stored in the set, rather than the compared value.
Also includes a fix that allows bridged dictionaries to be copied.

@phausler can you take a look at this?

@henrybetts In the meantime, it would be great to add some test cases here.

as a cursory glance this looks about right
@swift-ci Please test

Thanks!


Unable to use components with some nested blocks

What's wrong?
Hello, we're currently migrating to Alloy from Grafana Agent. We've reworked our modules to use the new syntax, but we're getting issues with nested blocks, such as Error: mimir:84:3: nested blocks not supported here. What's strange is that there are a lot of nested blocks that don't cause us any issues. For example:
declare "mimir" {
	// several different blocks

	prometheus.remote_write "this" {
		endpoint { // this does not cause any issues at all
			url = env("MIMIR_URL")

			headers = {
				"x-scope-orgid" = env("CLUSTER_NAME"),
			}

			basic_auth {
				username = env("MIMIR_USERNAME")
				password = env("MIMIR_PASSWORD")
			}
		}

		external_labels = {
			project     = env("PROJECT_NAME"),
			cluster     = env("CLUSTER_NAME"),
			__replica__ = env("KUBE_POD_NAME"),
		}
	}

	mimir.rules.kubernetes "this" {
		address = env("MIMIR_RULER_URL")

		tenant_id = env("CLUSTER_NAME")

		basic_auth { // offending line
			username = env("MIMIR_USERNAME")
			password = env("MIMIR_PASSWORD")
		}
	}
}

This also happens in the main config and with different ordering, for example:
mimir.rules.kubernetes "this" {
	address = env("MIMIR_RULER_URL")
	basic_auth {
		username = env("MIMIR_USERNAME")
		password = env("MIMIR_PASSWORD")
	}
	tenant_id = env("CLUSTER_NAME")
}

The issue also occurred for us with pyroscope.write's endpoint block and loki.write's endpoint block.
Steps to reproduce
Use mimir.rules.kubernetes with basic_auth, pyroscope.write with endpoint or loki.write with endpoint.
System information
GKE, deployed via helm chart
Software version
Alloy 1.3.1, Helm Chart 0.6.1
Configuration
No response
Logs
No response

hi, the problem I see with your config is that you are naming the custom component "mimir" but you also use a core component that's named "mimir": mimir.rules.kubernetes. When this happens, the custom component will shadow the core component but because you use it in the same declaration you should get a self reference error: Error: -: self reference: declare.mimir
what exact error did you get? is it solved by changing the name of the custom component?

Hi @wildum , I did not get any self reference error - only the ones showed and in the cases of loki and pyroscope, a .receiver not found error that was due to the write component failing.
Renaming the module and the component to something else was one of the first things I tried. It didn't work back then, but it does work now - perhaps there was an error on my part. Thanks for the help.
Nonetheless, the error was misleading and I don't think I've seen any mention of that requirement in the docs, so I think that the issue is still relevant.

Yeah I agree that there is room for improvement in the error handling. Could you share the full config that you had before please? Because I'm not getting this error with the snipped that you shared above

Thanks, I could generate the same error, I think that it comes from the fact that it was taking the mimir.rules.kubernetes has a custom component because of the import.file "mimir" and it was unhappy because the custom components don't have nested blocks in their blocks (the declare statement have nested blocks but not the custom component itself).
Anyway, sorry that the error was confusing, we should improve that

No worries, I'm glad we could figure it out!
My suggestion would be to add a warning block to the documentation as well.

Sounds reasonable, I created a PR for the doc: https://github.com/grafana/alloy/pull/1581


[SPARK-40356][INFRA][PS] Upgrade pandas to 1.4.4 (infra and docs)

What changes were proposed in this pull request?
Upgrade pandas to 1.4.4 in infra and doc gen
Why are the changes needed?
https://pandas.pydata.org/docs/whatsnew/v1.4.4.html
Especially, fix bugs which mentioned in https://github.com/apache/spark/pull/36353:

Fixed regression in DataFrame.fillna() not working on a DataFrame with a MultiIndex (GH47649)
Fixed regression in DataFrame.eval() creating a copy when updating inplace (GH47449)

Does this PR introduce any user-facing change?
No
How was this patch tested?
CI passed

@HyukjinKwon Thanks! Ready to go

Merged to master.


[Document]: unocss already support rspack by @unocss/webpack

What problem does this feature solve?
See https://github.com/unocss/unocss/pull/4173.
Maybe the docs should be update. This provided a much easier way to use unocss.
What does the proposed API look like?
Update docs https://rsbuild.dev/guide/basic/unocss.

Thanks for the feedback! We have updated the UnoCSS documentation and example.


Suggestion required: Getting error while applying Featurizer

@SenWu @HiromuHota  .. can you pls suggest if my analogy is right?
I am getting error :-
File "abcd./anaconda3/lib/python3.7/site-packages/fonduer/utils/data_model_utils/structural.py", line 55, in _get_node
return doc_etree.xpath(sentence.xpath)[0]
IndexError: list index out of range
I am following Hardware tutorial on some Email HTML msgs and getting mentions count near 4000
Also :--
train_cands = candidate_extractor.get_candidates(split=0)
dev_cands = candidate_extractor.get_candidates(split=1)
test_cands = candidate_extractor.get_candidates(split=2)
Above steps returned outputs but,
on applying featurizer:
featurizer.apply(split=0, train=True, parallelism=PARALLEL)
I am getting error mentioned on top.
I looked stackoverflow but the reason that HTML syntax issue,.. is not there as it is rendering good on browser.
So can you share your thoughts on :

can it be because  no candidates being generated? or
something else

Thanks.

@AshutoshUpadhya
doc_etree.xpath(sentence.xpath)[0] should return HtmlElement that is corresponding to sentence.xpath.
You mentioned that "no candidates being generated" but the function _get_node will not be visited if you have no candidate.
This could be a bug at Fonduer, but I'm not sure at the moment. Please help me figure that out.
Can you check the followings?
train_cands = candidate_extractor.get_candidates(split=0)
print(len(train_cands))
for cands in train_cands:
    print(len(cands))

and
print(candidate_extractor.candidate_classes)
print(featurizer.candidate_classes)

Thanks @HiromuHota  for response.. I figured that out. candidates were generating .. but its failing due to type of data I have.
Can't fonduer parse strings written as 15th ('th' in small  like we write in dates)? Its failing there.
Can you confirm and suggest some solution.
When i removed th from the html , the step " featurizer.apply(split=0, train=True, parallelism=PARALLEL)"
ran through. But i need to pass "15th" as it is.
Image of sample file:

Thanks!

Can you dump the content for that sentence from the data model? I need that info to dig into the issue. Thanks!


me/status: allow testers to see the developer logs

Testers have a developer account but a developer status of 0
(they can see the private devices but not update them). That is
enough to let them see their own logs.

Pull Request Test Coverage Report for Build 2825

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 68.482%

Totals

Change from base Build 2824:
0%

Covered Lines:
7528

Relevant Lines:
10349

💛  - Coveralls


count() inside aggregate/joinaggregate transform returns 0 instead of the length of the data

Take this code as an example:
import altair as alt
import pandas as pd

source = pd.DataFrame({
    'a': ['A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I'],
    'b': [28, 55, 43, 91, 81, 53, 19, 87, 52]
})

alt.Chart(source).mark_bar().encode(
    x='a',
    y='total:Q'
).transform_joinaggregate(
    total='count()',
    # groupby=['a']
).transformed_data()

The result with vegafusion enabled is 0 for the total column:

Whereas it is 9 when vegafusion is not enabled (Open the Chart in the Vega Editor):

If I uncomment the groupby above, the result is 1 in both cases:

Thanks for the report Joel, and for diagnosing that the issue arises with the lack of a groupby.


Adding new stars

Hi,
it is more a question than an issue of your helpful piece of code. Is there any possibility to add new stars like Thuban or others that the user can define? It would be great for research and teaching purposes.
Thank you in advance for your time

Ah, that is a good feature idea, I'll work on adding it now 👍

Thank you so much!!

Thank you for your time, that was fast! It works like a charm, be sure that it will be useful used, and appreciated in my daily work.

Wonderful to hear, if you need any future features, feel free to ask 👍


Bump deployment target to iOS 15

The library currently supports iOS 14 since it's also used in KeyboardKit, which targets iOS 14.
KeyboardKit 9 will however bump the deployment target to iOS 15, at which this library should also be bumped to target iOS 15.

I will close this until it's relevant.


Remove unused deps

Removed

dropright
flowright
transform
zipobject

Good. I also don't think we are using fs-extra anywhere here?

Yes, let me remove it


Add dockershim faq

Adds faq regarding dockershim deprecation

/lgtm

Reviewing...

okay, I think all changes have now been made

lgtm :taco: Won't explicitly lgtm this one though.

/lgtm
/honk

Thanks! /lgtm

Page preview:
https://deploy-preview-25360--kubernetes-io-master-staging.netlify.app/docs/setup/production-environment/dockershim/
Not clear on this location, but I would place this page right after the Container runtimes page. Check the weight of the Container runtimes page.

@kbhawkey – I asked @mrbobbytables to move it to a blog post, because I'm not a fan of adding one-off/time sensitive FAqs.. There's quite a bit of discussion on that in #sig-contribex in slack, which he's done.

I think I addressed everything but the the nit on the links - I'm used the ref link format and didn't want to change all of them lol The ref link style is what we encourage in the contributor docs.

/approve
I leave the lgtm to some other kind soul :)

/lgtm
Thank you @mrbobbytables

/lgtm
thank you @mrbobbytables ! 😄


Incrementing / Decrementing Values Support

Describe the feature
This is a common pattern in Laravel for Cache and the Database.
Would be awesome to see it also supported, would be happy to help with a PR.
Additional information

[X] Would you be willing to help implement this feature?

We could support such API in entity layer (https://github.com/unjs/unstorage/issues/25)

We could support such API in entity layer (#25) on top of storage.

Interesting, is the idea that the entity layer would be abstract or that it should be specific for the driver?

Yes (a new package getting public soon).

Hey! I'm curious on the status of this new package. I'm currently in need of a solution where I can increment a counter (that is not prone to race condition errors).
Is there already a native solution, or should I build a custom thing for now?

Hi. I have reopened because more thinking might make sense to support atomic operations with leveraging driver natives. Still not sure the best way to avoid (mainly bundle) overheads but let's track it again 👍🏼

I think it is a non-goal or at least not something easily to implement being both agnostic and fast.


Note on Readme for benchmarks install

It was unclear that someone have to run npm i in the benchmarks folder. This small PR add a clarification in Readme.

Thank you.


Codecoverage

Analyze the codecoverage of the backend code.

[ ] Locally and in jenkins.
[ ] Generate a report in jenkins.
[ ] Have a 80% coverage check (for the backend) in CI.
Not sure yet, which tool to use. Will look into this some time soon.

@kitzbergerg do you know some tool?
Are there also codecoverage tools for frontend? (maybe separate issue)

@kitzbergerg do you know some tool?
Are there also codecoverage tools for frontend? (maybe separate issue)

I have never looked into that no. After a quick look something like the following might be usable (although I haven't tested it)

https://github.com/xd009642/tarpaulin
https://github.com/taiki-e/cargo-llvm-cov

not urgent, can also be done locally as needed for now


Fix broken link in docs.

Docs Build status updates of commit b731452:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/libraries/numerics/installation.md
:warning:Warning

Details

articles/libraries/numerics/installation.md

Line 31: [Warning] Invalid file link:(~/media/vs2017-nuget-console-menu.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


☂ analyzer hints for stored values marked @doNotStore

Follow up from https://github.com/dart-lang/sdk/issues/41941 and dart-lang/linter#2085, with the annotation landed (https://github.com/dart-lang/sdk/commit/37ba50cd0c838af2ececebf51ff3a67586df4be2) we can get to corresponding analysis.
From the docs:
/// Tools, such as the analyzer, can provide feedback if
///
/// * the annotation is associated with anything other than a library, class,
///   method or getter, top-level getter or function, or
/// * an invocation of a member that has this annotation is returned by a method,
///   getter or function that is not similarly annotated as `doNotStore`, or
/// * an invocation of a member that has this annotation is assigned to a field
///   or top-level variable.

FYI @jefflim-google, basic analysis  is implemented and landed in the internal SDK.  It'd be great to  get some feedback.
Thanks!

With basic analysis implemented and in use, closing this meta issue in favor of targeted follow-ups.


Hosted Tutorials

I am comfortable with the local version and would like to build a hosted version next.
We look forward to your hosted tutorial videos!!
We would appreciate it if you could upload it as soon as possible!

I second that! also is there a way to have a docker container to facilitate deployment?


Fix the upgrade issue for tracing

Signed-off-by: Chun Lin Yang<EMAIL_ADDRESS>When we installed the istio with tracing.provider=jaeger. then use helm to upgrade to use zipkin provider.
helm upgrade istio ./install/kubernetes/helm/istio --tls --set tracing.enabled=true --set tracing.provider=zipkin

it throws
Error: UPGRADE FAILED: Deployment.apps "istio-tracing" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app":"jaeger"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable

I suggest to share the same selector for both jaeger and zipkin. the fix changes the LabelSelector so when upgrade from 1.2.x to this version, it needs to use --force. in future, do not need to force upgrade.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[x] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@clyang82: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-lint-master
4e769f8172337b7c411502c41bf8e8fc8f653bd4
link
/test istio-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-lint-master
4e769f8172337b7c411502c41bf8e8fc8f653bd4
link
/test istio-lint-master

e2e-simpleTests-distroless-master
4e769f8172337b7c411502c41bf8e8fc8f653bd4
link
/test e2e-simpleTests-distroless-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-lint-master
4e769f8172337b7c411502c41bf8e8fc8f653bd4
link
/test istio-lint-master

e2e-simpleTests-distroless-master
4e769f8172337b7c411502c41bf8e8fc8f653bd4
link
/test e2e-simpleTests-distroless-master

istio-pilot-multicluster-e2e-master
4e769f8172337b7c411502c41bf8e8fc8f653bd4
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-lint-master
4e769f8172337b7c411502c41bf8e8fc8f653bd4
link
/test istio-lint-master

e2e-simpleTests-distroless-master
4e769f8172337b7c411502c41bf8e8fc8f653bd4
link
/test e2e-simpleTests-distroless-master

istio-pilot-multicluster-e2e-master
4e769f8172337b7c411502c41bf8e8fc8f653bd4
link
/test istio-pilot-multicluster-e2e-master

integ-telemetry-k8s-presubmit-tests-master
4e769f8172337b7c411502c41bf8e8fc8f653bd4
link
/test integ-telemetry-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-pilot-multicluster-e2e-master
4e769f8172337b7c411502c41bf8e8fc8f653bd4
link
/test istio-pilot-multicluster-e2e-master

integ-telemetry-k8s-presubmit-tests-master
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82 Have you merge the same PR to istio/installer? All installer PR should go to istio/installer firstly, see comments here: https://github.com/istio/istio/pull/16121#issuecomment-519552992

@clyang82 Have you merge the same PR to istio/installer? All installer PR should go to istio/installer firstly, see comments here: #16121 (comment)

PR https://github.com/istio/installer/pull/359 was created in installer.

Is this PR needed for 1.3?

Is this PR needed for 1.3?

I think we should have it in 1.3. that is related with upgrading.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-presubmit-tests-master
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-presubmit-tests-master

integ-telemetry-k8s-tests_istio
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cc @sdake

Seems pretty advanced scenario, not sure if it ever worked before.  Ok to not have it in 1.3 imho.

I don't think we should merge them. We can solve the issue without merging the charts into one complicated monolith by making them use the same labels,right?. This comment applies more to the change on istio/installer but I think it applies here as well

Thanks for your comment. Let me update to keep separated files with the same labels.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-presubmit-tests-master
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-presubmit-tests-master

integ-telemetry-k8s-tests_istio
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-tests_istio

e2e-simpleTests-cni_istio
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test e2e-simpleTests-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-presubmit-tests-master
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-presubmit-tests-master

integ-telemetry-k8s-tests_istio
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-tests_istio

e2e-simpleTests-cni_istio
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test e2e-simpleTests-cni_istio

lintmodern_istio
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test lintmodern_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-presubmit-tests-master
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-presubmit-tests-master

integ-telemetry-k8s-tests_istio
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-tests_istio

e2e-simpleTests-cni_istio
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test e2e-simpleTests-cni_istio

lintmodern_istio
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test lintmodern_istio

lint_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-presubmit-tests-master
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-presubmit-tests-master

integ-telemetry-k8s-tests_istio
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-tests_istio

e2e-simpleTests-cni_istio
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test e2e-simpleTests-cni_istio

lintmodern_istio
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test lintmodern_istio

lint_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test lint

release-test_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test release-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-presubmit-tests-master
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-presubmit-tests-master

integ-telemetry-k8s-tests_istio
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-tests_istio

e2e-simpleTests-cni_istio
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test e2e-simpleTests-cni_istio

lint_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test lint

release-test_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test release-test

unit-tests_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-presubmit-tests-master
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-presubmit-tests-master

integ-telemetry-k8s-tests_istio
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-tests_istio

e2e-simpleTests-cni_istio
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test e2e-simpleTests-cni_istio

lint_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test lint

release-test_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test release-test

unit-tests_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test unit-tests

racetest_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test racetest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-presubmit-tests-master
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-presubmit-tests-master

e2e-simpleTests-cni_istio
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test e2e-simpleTests-cni_istio

lint_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test lint

release-test_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test release-test

unit-tests_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test unit-tests

racetest_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test racetest

integ-telemetry-k8s-tests_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test integ-telemetry-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-presubmit-tests-master
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-presubmit-tests-master

lint_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test lint

release-test_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test release-test

unit-tests_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test unit-tests

racetest_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test racetest

integ-telemetry-k8s-tests_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test integ-telemetry-k8s-tests

codecov_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test codecov

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This doesn't seem like a good idea. We will break upgrade for 100% of users to support the very few that switch providers. Why not just have --force when you switch rather than make everyone --force?

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-presubmit-tests-master
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-presubmit-tests-master

lint_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test lint

release-test_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test release-test

unit-tests_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test unit-tests

racetest_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test racetest

integ-telemetry-k8s-tests_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test integ-telemetry-k8s-tests

codecov_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test codecov

integ-new-install-k8s-tests_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test integ-new-install-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This doesn't seem like a good idea. We will break upgrade for 100% of users to support the very few that switch providers. Why not just have --force when you switch rather than make everyone --force?

Yes. Just checked the upgrade document - there is no --force. this fix requires everyone to use --force which is not a good idea. but for istio tracing, i think we should use the same name instead of different provider. Anyway, this is a minor case. If no better idea for this case, I will close it. Thanks.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-presubmit-tests-master
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-presubmit-tests-master

release-test_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test release-test

integ-telemetry-k8s-tests_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test integ-telemetry-k8s-tests

integ-new-install-k8s-tests_istio
28a57c863c7e21c2477a25525de4ee7094c9854c
link
/test integ-new-install-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-presubmit-tests-master
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-presubmit-tests-master

release-test_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test release-test

integ-telemetry-k8s-tests_istio
35095ec33500291593a1fd325da659f6608a0eb9
link
/test integ-telemetry-k8s-tests

integ-new-install-k8s-tests_istio
28a57c863c7e21c2477a25525de4ee7094c9854c
link
/test integ-new-install-k8s-tests

integ-mixer-k8s-tests_istio
28a57c863c7e21c2477a25525de4ee7094c9854c
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-presubmit-tests-master
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-presubmit-tests-master

integ-new-install-k8s-tests_istio
28a57c863c7e21c2477a25525de4ee7094c9854c
link
/test integ-new-install-k8s-tests

integ-mixer-k8s-tests_istio
28a57c863c7e21c2477a25525de4ee7094c9854c
link
/test integ-mixer-k8s-tests

integ-telemetry-k8s-tests_istio
28a57c863c7e21c2477a25525de4ee7094c9854c
link
/test integ-telemetry-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-presubmit-tests-master
8905f55df4af0a8f33378dbb0271b846a022378b
link
/test integ-telemetry-k8s-presubmit-tests-master

integ-telemetry-k8s-tests_istio
28a57c863c7e21c2477a25525de4ee7094c9854c
link
/test integ-telemetry-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Fix logic for include_parent_namespaces option

Based on PR #1408.

Add specs to test different combinations of namespaces
Add documentation for the include_parent_namespaces option

I like this. This just needs a CHANGELOG entry, please.

@dblock, CHANGELOG updated => 8a7a24c

Merged via https://github.com/ruby-grape/grape/commit/7d1b3e334f5d3d5b045e9a48b08a8f1ed03a9f5e.


Retry tests

Spec tests have a ~30% failure rate

Codecov Report
Base: 80.02% // Head: 80.02% // No change to project coverage :thumbsup:

Coverage data is based on head (a07d528) compared to base (cad96c2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #354   +/-   ##
=======================================
  Coverage   80.02%   80.02%
=======================================
  Files          44       44
  Lines       11295    11295
  Branches     1017     1017
=======================================
  Hits         9039     9039
  Misses       2256     2256

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Adds russian language utility

@putnik, what do you think?

Current coverage is 88.53%

Merging #259 into master will increase coverage by +0.64% as of c1d2623

@@            master    #259   diff @@
======================================
  Files          191     193     +2
  Stmts         6113    6098    -15
  Branches         0       0
  Methods          0       0
======================================
+ Hit           5373    5399    +26
  Partial          0       0
+ Missed         740     699    -41

Review entire Coverage Diff as of c1d2623

Powered by Codecov. Updated on successful CI builds.


Remove all print statements #93

added logging functionality from python
logs will be shown with date-time

requested changes been added


Use simpler JSON form for a Revision

Motivation:
We do not and will not use the minor revision number in a Revision, and
thus there's no point of serializing the minor revision number if it's
zero.
Modification:

Write the dedicated JsonSerializer and JsonDeserializer for Revision

A revision, whose minor is 0, is serialized into a number.
A revision with non-zero minor is serialized into an object just
like before.
The deserializer understands various forms for backward
compatibility.

Result:
Simpler JSON representation

Codecov Report

Merging #87 into master will increase coverage by 0.04%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   49.65%   49.69%   +0.04%
==========================================
  Files         217      219       +2
  Lines       10035    10079      +44
  Branches     1355     1360       +5
==========================================
+ Hits         4983     5009      +26
- Misses       4285     4298      +13
- Partials      767      772       +5

Impacted Files
Coverage Δ

...rp/centraldogma/common/RevisionJsonSerializer.java
100% <100%> (ø)

...ava/com/linecorp/centraldogma/common/Revision.java
45.95% <100%> (+0.23%)
:arrow_up:

...er/internal/storage/repository/git/CommitUtil.java
65.62% <100%> (ø)
:arrow_up:

.../centraldogma/common/RevisionJsonDeserializer.java
60% <60%> (ø)

...internal/replication/ZooKeeperCommandExecutor.java
66.89% <0%> (-1.02%)
:arrow_down:

...internal/storage/repository/git/GitRepository.java
76.23% <0%> (-0.28%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f629fbc...199e886. Read the comment docs.

Thanks, @hyangtack @minwoox !


Refresh user signin after updating their profile

That way, the changes are immediately visible.

I'm not sure if this is necessary because there's a redirect that's about to happen anyway. I feel that even though this API is called, the "system" is overall in a "bad state" because half of it will think the user is the "old" profile, and half of it will think the user is the "new" profile.
@HaoK / @Tratcher / @blowdart - thoughts on this?

This makes sense. The user has just changed some of their profile information in the database but still has the old values cached as claims in the auth cookie. RefreshSignInAsync issues a new auth cookie with the updated information.

Its safe to call refresh sign in generally to update the claims on the response.  That said, identity doesn't put the phone number of email in the cookie by default, so this shouldn't actually result in any claims being updated

We should add it though, for "correctness" or an illustration of what should eb done.

@jbagga can you review & merge? @Tratcher and @blowdart say it's good, so let's do it.

@Eilon Which milestone is this in?

2.1.0-preview2, so just dev

The code has moved to Identity UI https://github.com/aspnet/Identity/pull/1615

@Biarity Thanks for the suggestion! The code change has been moved to the new location.

This issue was moved to aspnet/Scaffolding#736


Influx DB memory leak

What?
InfluxDB memory in few days increases from 2GB to 13-14GB. There is some leakage.
We had setup grafana-influxdb-heapster following this document - https://github.com/kubernetes/heapster/tree/master/deploy/kube-config/influxdb
Our machine spec:
node: m4.xlarge, 4cores 16GB
kubernetes version: 1.6.4
influx version: `image: gcr.io/google_containers/heapster-influxdb-amd64:v1.1.1

How can we fix this?

@alok87 can you upgrade to the latest release? We're on 1.3.3.

@e-dard need to ask kuberentes heapster community to bump the version. let me try

I'm on version 1.3.5 and have even cleared out my data storage.  I'm still seeing the same memory issues.  Is this issue still ongoing for anybody?
Ah I see 1.3.6 has been released since, will upgrade and test...

I also noticed a leak using the latest
https://dl.influxdata.com/influxdb/releases/influxdb_1.3.7_amd64.deb

I am not getting memory leak but, this is happening when heapster writes to influx. Not sure how to fix this yet
{"log":"E1115 14:45:05.485833       1 influxdb.go:186] InfluxDB write failed: {\"error\":\"partial write: max-series-per-database limit exceeded: (1000000) dropped=4929\"}\n","stream":"stderr","time":"2017-11-15T14:45:05.486074258Z"}


Import Shodan Class From Crossfeed

💡 Summary
Create scripts to pull Shodan data into P&E database.  Currently housed in Crossfeed Repo.
Implementation notes

Create class for Shodan data pulls.
Return dataframes

Acceptance criteria
How do we know when this work is done?

[ ]  run pip install -e .
[ ] run pre-commit run --all-files
[ ] run pytest /tests
[ ] run pe-reports $(date "+%Y-%m-%d") data/ output/ --db-creds-file=/creds
[ ] All code meets dev-standards

Resolved in PR #122


maximum call stack size exceeded when my graph is large

https://stackoverflow.com/questions/35380984/increasing-stack-size-in-browsers#
I  have the save problem ,when  my graph is too large ,there is 5000 nodes and 4999 lines.

function horizontalCompaction()   pass1,pass2  the recursion is too deep

Fixed by #228


Video redirect class

@mparent61 This passes the existing test cases.
My thinking is to extend this class in onion and override:
def choose_video_for_redirect(self, videos):

To filter on the feature_type. ( in python, not as a db query )
Thoughts?

Yeah this is a good workaround. I would add plenty of comments that this will be removed once unique constraint is in place.

Coverage increased (+0.02%) to 86.251% when pulling 86f2bbf522d9f987cc8d5ea40981769529d9b1c7 on video-redirect-class into de179606e7abd3721dd58d577bb892cbe0b0c904 on master.

Coverage increased (+0.02%) to 86.251% when pulling 86f2bbf522d9f987cc8d5ea40981769529d9b1c7 on video-redirect-class into de179606e7abd3721dd58d577bb892cbe0b0c904 on master.

Coverage decreased (-0.02%) to 86.214% when pulling 0d10f512fdf813e488cf090cf18b8522f1bf9b39 on video-redirect-class into de179606e7abd3721dd58d577bb892cbe0b0c904 on master.

@benghaziboy @MichaelButkovic Lookin' for that second 👍

LGTM

Coverage increased (+0.02%) to 86.282% when pulling 31247bfcd601941ca0f0e20ead70141042611736 on video-redirect-class into 67274b705182c0e1bbcbc61f6f6649dc2ce7bd36 on master.

Coverage increased (+0.02%) to 86.282% when pulling 31247bfcd601941ca0f0e20ead70141042611736 on video-redirect-class into 67274b705182c0e1bbcbc61f6f6649dc2ce7bd36 on master.


Implement early stopping (to avoid overfitting)

Never close an issue without referencing to the commit that fixes the issue, or if no fix is provided, explain why the issue can be closed.

Closing this issue as training is now done in ivadomed where early stopping is implemented as documented here: https://ivadomed.org/configuration_file.html#training-time


Add ability to exclude files and directories

Add ability to exclude files and directories from scans.
Closes #12

You might want to squash this into single commit :)

Looks good, merged!


streamline release process

[ ] make module: rake tasks invisible by default
[ ] change travis_release to a more speaking name like, puppet_community_release
[ ] after module:bump_commit, puppet_community_release should append -rc to our metada.json version

I think I see how the last step works, but can you elaborate on the desired workflow?
If it's what I think, the rake task that travis calls should check for -rc and call it a day if it finds it, rather than wasting time erroring out at the forge (I hope that errors!).

i very much hope that blacksmith's module:bump does the sensible thing and makes 1.2.3-rc into 1.2.4, if not, that's a bug in the semver gem.

all done as per https://github.com/puppet-community/puppet-community.github.io/issues/21
we're now trying to figure out if that works.
unfortunately, it appears to require a working ruby :D

after the (two;) successful release(s) of puppet-extlib (https://github.com/voxpupuli/puppet-extlib/pull/45 & https://github.com/voxpupuli/puppet-extlib/pull/43) we should migrate the rake task into this repository. (see also https://github.com/voxpupuli/puppet-blacksmith/issues/25 )

Actually, I'd love to have this option for my own modules. Could it be put into a ruby gem and included via Gemfile and spec/spec_helper.rb?

i thought about making it a task of blacksmith, but i'm not sure that's a good idea…

Probably not since it hides some tasks. But as a standalone that requires
blacksmith it could be useful when someone wants to opt in
--
Rob Nelson
<EMAIL_ADDRESS>

nod thanks for the feedback here, @rnelson0!

i think this is solid by now and can be closed


Add Statement methods

Allows methods to check if a Statement has been returned.
Refactored methods for ease of reuse.

@bradley2W1DL Here's the simple refactor.

dude... you move to SV and START to use all that slang... LGTM???
i see. looks good to me ;)
hope you are good @bjacobso
GTG


serverless.file_download() allow user to choose name for the local files

What is the expected enhancement?
Make names of downloaded files predictable
The current implementation  is:
serverless = IBMServerlessProvider()
...
out_files = serverless.files()
for x in out_files:
     serverless.file_download(x, download_location='out')

results with files having very clumsy local names:
ls out
downloaded_11b5c41b_hybr_9dc540_1.h5.tar  downloaded_7b7b9806_hybr_9dc540_2.h5.tar  downloaded_81f38010_hybr_b9e448_2.h5
downloaded_327599c6_hybr_b9e448_1.h5	  downloaded_7e0263a4_hybr_9dc540_0.h5.tar  d
ownloaded_a1efd5b3_hybr_b9e448_0.h5

It would be nicer if user is allowed to provide also the target name:
serverless.file_download(x, download_location='out',  target_name=x)
So the downloaded files have  do not have this prepended 'download_eq287r643q87rc 2837' strings.

@balewski Thanks for submitting this issue.  It seems a reasonable enhancement.


allow more gender options, case insensitive

@amillet89 Let me know when you or someone from the Segment team will have a chance to look at this. Appreciate it.

I don't think our spec documents this currently, but traits.gender will always be one of these values so you shouldn't need to check for it.

@f2prateek we don't/won't prescribe genders in the spec because not everyone self-identifies as one of these genders

So what happens if Flurry expects M but AppBoy expects Male (I see this PR makes it accept M as well, but it's easy to see that not all integrations will do this)? Users wouldn't be able to send that information to both integrations with one API call.

any update here guys?

@prestonwrthompson sorry for the delay. We've discussed this and gender will always be in lowercase, e.g. female, pangender. Since AppBoy is only interesting in grouping those by male, female and other, the code would look something like this:
if (traits.gender != 'female' && traits.gender != 'male') {
     traits.gender = 'other'
}

What if someone sends something like m or man? Can I expect that to be converted to male before it is sent?

We're adding this to our spec, but in general spec'd fields are documented to indicating that we accept them in a certain format. In this case we'll document that users  should always send gender a complete string (not just m or f) in lowercase.

@prestonwrthompson Thanks for the PR, we'll accept this for backwards compatibility for now!

Sounds good, thanks for the help!

@prestonwrthompson Could you rebase against master? You're on a stale version and this line in particular - https://github.com/prestonwrthompson/integration - https://github.com/segmentio/integration-appboy/blob/force-ci/test/index.js#L5 - cases the build to fail.
I did try without that line and it builds but tests are breaking -https://cloudup.com/c9zqFT-CyrT. Let me know when you can fix them and we can merge this PR.

@f2prateek all the test passed for me just now, let me know if it works for you

@f2prateek any update?

thanks

Sorry for the delay, this just fell of my radar. Thanks for the fix!

No worries, thanks for taking the time to review