Fix #2427: Deprecate sbtplugin.{Implicits, LoggerJSConsole}

Review by @sjrd

That's all.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3191/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4140/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3193/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4142/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3192/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4141/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3194/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4143/
Test FAILed.

That's all.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3200/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4151/
Test PASSed.

LGTM

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3199/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4150/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3203/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4154/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3204/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4155/
Test PASSed.


Publish: copy manifest URL copies the api/messages url - not the manifest one

A. The copy manifest URL does not copy the manifest url rather the messages/api url.
For example:
https://theskill.azurewebsites.net/api/messages
I expected the following:
https://theskill.azurewebsites.net/manifests/TheSkill-2-1-manifest.json
B. The text in the UI is truncated too early. (fit & finish).
See image:

@scheyal  which electron version are you using, we should fixed this in the private electron for skill experience which we shared in the skill v-team group.

should be fixed in the latest main branch.


F9 Key does nothing

Using the F9 key does nothing. I tried binding other key but same issue. I'm using the lastes version of both SharpPlugin and Stracker's Loader.
I'ts like SharpPlugin is not working at all.
I see nothing in Stracker's log and I have .NET desktop runtine V8.0.6 installed.

Is there anything in nativePC/plugins/CSharp/Loader/SharpPluginLoader.log?

There is 4 files but no .log file. I Assume it's because SharpPlugin does not even start. That's Weird because everything is up to date and I already managed to get it running in the past with old versions.

where I have to put the folder [SharpPluginLoader <IP_ADDRESS>]

I think you're not in the wrong place ?

where I have to put the folder [SharpPluginLoader <IP_ADDRESS>]

You have to copy the nativePC folder and winmm.dll into the Monster Hunter root folder.

There is 4 files but no .log file. I Assume it's because SharpPlugin does not even start. That's Weird because everything is up to date and I already managed to get it running in the past with old versions.

If you set the log level (in loader-config.json) to INFO/DEBUG is there any console that pops up? Do you have winmm.dll next to the game's exe?

Yes I confirm you I have the winmm.dll next to the exe and I've already set log level to INFO. The console is showing up at game start.
I'll set log level to debug, maybe I'll have more information about the problem.

I found the solution. My game was running as administrator and that was the issue. When running as non admin, everything in working like a charm.
Is the plugin intended to work only when the game is running as non admin ?
I mark this issue as closed since my problem is solved. I hope it will be useful.

Is the plugin intended to work only when the game is running as non admin ?

No, it isn't. But most likely Windows has some special behavior for winmm.dll when running in administrator, which causes it to not get loaded. Thanks a lot for posting the solution here! I have had other peopl report this issue and I could not figure out what was causing it. 👍


NodeJs 14 x runtime required for LambdaLayer

The error is with CDK deployment of Lambda:
Resource handler returned message: "The runtime parameter of nodejs10.x is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs14.x) while creating or updating functions. (Service: Lambda, Status Code: 400, Request ID: 6e09214d-1abc-4f66-8fc3-2f3ab42cb739, Extended Request ID: null)" (RequestToken: 44f58a32-76ce-1dab-4621-8d8e01eeb35d, HandlerErrorCode: InvalidRequest)

Fix has been applied. Pushed new change to lambda layers and updated runtimes to NodeJS 14. Please try cloning the repository and building a new environment with this new code so that you can deploy  the Lambda Functions with updated NodeJS version.


Release: 3.4.3

Changelog

nginx got deprecated (use external image)
based on redmine from docker library
all configuration options from this and library work
Change Quickstart example to start extra nginx
give ssl example.

Closes:

#301
#291
#283
#268
#168 Passanger Support
#147 Cors header

TODO

supply nginx.conf via mount point -> /etc/nginx/sites-enabled/redmine.conf
give instructions for ssl
adjust env vars for compat
redmine_without_nginx -> branch -> merge master

3.4.3 Features

backward compatible env names
extends the library redmine image
Adds mail configuration via environment variables.
Adds some helper scripts to work with dockerized redmine

nginx got deprecated (use external image)

What do you mean here? Are you removing NGINX from the image entirely? If yes, this will break the image for existing users who depend on the SSL support provided by the image and we should have clear instructions so that existing users can migrate their existing deployments properly.

based on redmine from docker library

I see that you intend to move the image to use the official redmine image as a base. I really don't see any advantage of doing so and also see a lot of effort from you to migrate the feature set of this image. There is no clear advantage of taking on this effort and there is no real advantage to the user.
I suggest you hold on to merging these changes and I'm sorry if i've missed any discussions on this matter. If you are really sold on the advantage of this migration, then my suggestion is to fork this image, make releases of the fork with these changes. Once any issues are ironed out and the new image is reasonably stable then I'd be happy to merge in the changes.

@sameersbn there will be no diffrence the only diff between this image and the other one is that we have imap scripts and nginx + ssl then we have a lot of issues with nginx and ssl .
So to solve all that issues and keep this compatible we simply split nginx out but don't the settings i will supply a clear migration path.
Pro of this merge is:

Reducing Issues.
More logical Deployment via kubernetes and other normal Moby Stack tech

Cons

No none needed nginx instance

@sameersbn befor i merge that in i will discusses that with you this issue is still in preparation but i think it will close near all open issues

IMHO it would seem logical to base in the official image.
It would at least simplify the version upgrades I guess.

I'm no expert but these changes to structure sound ideal.  Any updates on this?

Sorry about not looking into this.
I would like to get this PR well tested. Will try to spend some time to validate everything works as expected and users can upgrade without any issues.
It would be very helpful if you guys could help test this PR and validate it works for you. Thanks!

Just noticed that the PR is WIP and there are a couple of TODO tasks in the pipeline.
We could use help there as welll.

@sameersbn yes we will try our best on that at present that is a lot of work and we could need repo access or your assistance for the setup of automated tests as your the repo owner that is blocking

I also could not wait and made the switch.
Here is what I think are the interesting part:

cron supported through http://deck-chores.readthedocs.io (here used for the redmine reminder plugin).
use of docker secrets.
SSL/HSTS supported through passenger/nginx and a rails initializer using config.force_ssl = true.

version: "3.1"
services:
  web:
    image: redmine:3.4-passenger
    restart: always
    command: passenger start --ssl --ssl-certificate /run/secrets/ssl-certificate --ssl-certificate-key /run/secrets/ssl-key --ssl-port 3443
    environment:
      REDMINE_DB_MYSQL_FILE: /run/secrets/database-hostname
      REDMINE_DB_DATABASE_FILE: /run/secrets/database-name
      REDMINE_DB_USERNAME_FILE: /run/secrets/database-username
      REDMINE_DB_PASSWORD_FILE: /run/secrets/database-password
      REDMINE_PLUGINS_MIGRATE: 1
    ports:
      - '80:3000'
      - '443:3443'
    depends_on:
      - database
    secrets:
      - source: redmine-configuration
        target: /usr/src/redmine/config/configuration.yml
      - ssl-certificate
      - ssl-key
      - database-hostname
      - database-username
      - database-password
      - database-name
    volumes:
      - /etc/localtime:/etc/localtime:ro
      - ./data/files:/usr/src/redmine/files
      - ./initializers:/usr/src/redmine/config/initializers/customization
      - ./plugins:/usr/src/redmine/plugins
      - ./themes:/usr/src/redmine/public/themes
    labels:
      deck-chores.reminder-emails.command: 'rake redmine:reminder_plugin:send_notifications  >> log/due_date_reminder.log 2>&1'
      deck-chores.reminder-emails.interval: daily

  database:
    image: mysql:5.7
    restart: always
    environment:
      MYSQL_ROOT_PASSWORD_FILE: /run/secrets/database-password
    secrets:
      - database-password
    volumes:
      - /etc/localtime:/etc/localtime:ro
      - ./data/mysql:/var/lib/mysql

  officer:
    image: funkyfuture/deck-chores
    restart: always
    environment:
      TIMEZONE: Europe/Zurich
    volumes:
      - /etc/localtime:/etc/localtime:ro
      - /var/run/docker.sock:/var/run/docker.sock

secrets:
  redmine-configuration:
    file: ./data/secrets/redmine/configuration.yml
  ssl-certificate:
    file: ./data/secrets/ssl/redmine.pem
  ssl-key:
    file: ./data/secrets/ssl/redmine.key
  database-hostname:
    file: ./data/secrets/database/hostname
  database-username:
    file: ./data/secrets/database/username
  database-password:
    file: ./data/secrets/database/password
  database-name:
    file: ./data/secrets/database/name

Will use https://docs.docker.com/develop/develop-images/multistage-build/
to archive our goal faster!


Support for ZeRO-1

As per title.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Don't play favorites with concepts

These Concepts are the most central to building rich, reusable profiles.

Change to...

Verb, Activity Type, and Attachment Usage Type Concepts share the same properties.

I would also ditch the term "core concept". Are attachment usage types any more "core" than extensions and activities? You can delete it from the heading and change "core concept" to "Concept" in the table below.

Closing as duplicate of #123. I've linked to this issue to keep the suggested text.


ToDoLite: PushReplicator throws Exception

Steps to reproduce

Run ToDo Lite App on mobile
Store some tasks in mobile db. Maybe with photos
Stop ToDo Lite App
Start Sync Gateway
Start ToDo Lite App on Mobile
observe some logs at sync gateway
observe following exceptions.

01-28 00:32:52.233    2334-2385/com.couchbase.todolite E/CBLite﹕ Exception getting status from {error=forbidden<EMAIL_ADDRESS>reason=wrong user, status=403}
    java.lang.ClassCastException: java.lang.Integer cannot be cast to java.lang.String
            at com.couchbase.lite.replicator.ReplicationInternal.statusFromBulkDocsResponseItem(ReplicationInternal.java:1404)
            at com.couchbase.lite.replicator.PusherInternal$4.onCompletion(PusherInternal.java:500)
            at com.couchbase.lite.support.RemoteRequestRetry$1.completed(RemoteRequestRetry.java:193)
            at com.couchbase.lite.support.RemoteRequestRetry$1.onCompletion(RemoteRequestRetry.java:204)
            at com.couchbase.lite.support.RemoteRequest.respondWithResult(RemoteRequest.java:299)
            at com.couchbase.lite.support.RemoteRequest.executeRequest(RemoteRequest.java:249)
            at com.couchbase.lite.support.RemoteRequest.run(RemoteRequest.java:105)
            at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:422)
            at java.util.concurrent.FutureTask.run(FutureTask.java:237)
            at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:152)
            at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:265)
            at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
            at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
            at java.lang.Thread.run(Thread.java:818)

@ajres have you re-deployed the demo cluster?  There was some changes made to the way sync gateway treats facebook users, which the clients will need an update for.  I wonder if that is what got broken here.

@tleyden No recent changes to SG on the demo cluster, I think it's still running 1.0.3

I tried to repro but was not able to.  I was using the master branch with the genymotion emulator.  I uninstalled the app and then logged in.

My recent changes might cause this issue. After all PRs are merged, I will revisit this issue.

TODO: I should retest this issue with latest master branch.


Adding 4 more tools to Statistics section

@galaxybot test this

Deploy succeeded (got false failure in Jenkins log)


Fix event registration capital letters (closes #3037) (COMMUNITY)

This PR fixes the typos named in #3037

Hello @DerVogel2020, thank you for your suggestions. We have a convention that these texts stay with small letters. So I will not merge this suggestion. Thank you so much for your contribution!
Kind regards!

We have a convention that these texts stay with small letters.

Thank you for the feedback. I wonder whose convention it is? As described in https://github.com/corona-warn-app/cwa-wishlist/issues/491 I believe, it's a bug, independent from any conventions.
If it won't be fixed, please close also the issues

https://github.com/corona-warn-app/cwa-website/issues/1179
https://github.com/corona-warn-app/cwa-app-android/issues/3037
https://github.com/corona-warn-app/cwa-app-ios/issues/2600

This has been merged in #3177.


Refactor Smooch credential parsing and verification

Refactor getAuthenticationHeaders into a credential util that accepts app tokens, JWTs, or secret key/id pairs, and returns both the API auth headers and access scope. The scope I'll be using later when adding managed account APIs.

I don't think you need to close this... make Credential a proper class, make one for the browser that just blindly use the jwt or app token and assume an appUser scope and one for node that do everything... just like I did for smooch-node.js vs smooch,js


Drop eth0 packets in PREROUTING on Kind Nodes

According to the OVS documentation:
On Linux, when a physical interface is in use by the userspace datapath,
packets received on the interface still also pass into the kernel TCP/IP
stack. This can cause surprising and incorrect behavior. You can use
"iptables" to avoid this behavior, by using it to drop received packets.
The OVS documentation suggests dropping packets in the INPUT and FORWARD
chains. However, this is not sufficient for some edge cases. For
example, when receiving a TCP RST packet, the packet will clear the
conntrack entry for the TCP connection before it can be dropped, which
can cause the "second" TCP RST packet (the one processed by OVS
userspace) to be marked as invalid when going through conntrack.
So instead we drop the packet in PREROUTING:
iptables -t raw -A PREROUTING -i eth0 -j DROP
This rule is added to the start_ovs_netdev script.
By adding this rule, we no longer need to skip TCP e2e tests for the
Reject NetworkPolicy Action in Kind clusters.
It's possible that this is also going to help with various connectivity
issues we observed with Antrea in Kind over time. For example, I believe
we may also be able to remove the hack which reduces the value of the
tcp_retries2 sysctl parameter. I need to run tests to confirm.
Fixes #2025

/skip-all


List of tests that needs to be rewritten with the removal of AddressBook

Will be updated in a while


Feature/enrich entry error reporting

This adds error reporting to EnrichEntry.  EnrichmentDriver now returns a Try object to facilitate reporting.  Also, an enrichment now fails if TwoFishes is unreachable (thanks @moltude!)  This has been tested locally.  It addresses DT-1593.

@mdellabitta I've fixed up all my errors and this should be ready for review


Update readme with details about linguist-generated

@mkdynamic If you merge in master, resolve any conflicts, and then accept the CLA we can go ahead and :ship: this.

These changes have now been made to the README in https://github.com/github/linguist/pull/3588 so closing this PR as we don't need it anymore.


Add LeetCode support

Hi all! I've been using LeetCode (popular coding interview prep site) recently and really wished I could add Prettier integration to their site's editor. After talking with @nickmccurdy, he introduced me to this awesome project and I realized I could just contribute to this rather than make my own extension.
LeetCode uses a library called CodeMirror for their integrated editor (specifically, react-codemirror2). Though it's fairly tricky to get / set the editor's content by inspecting the DOM alone, the editor's CodeMirror instance is exposed as a property of the editor DOM element (.CodeMirror). This makes it super easy to call CodeMirror methods:
const editor = document.querySelector(".CodeMirror");
// Get the editor's content
editor.CodeMirror.doc.getValue();
// Set the editor's content
editor.CodeMirror.doc.setValue('some code');

Unfortunately, this property is only accessible within a page context - as extension content scripts are sandboxed, this CodeMirror instance can't be used in the same way. To get around this, I've created some helper methods that are injected into the page context to get / set the editor's content (see _addClientListeners).
Right now, this implementation works, though there are some things I'm not crazy about:

I'm currently injecting the client script by creating a script element, setting its textContent through a template literal, and injecting that into the DOM. This StackOverflow post nicely summarizes some other possible ways to run code within a page context - I'm open to other methods.
 Right now the flow is "GetEditorContent" -> "FormatEditorContent" -> "SetEditorContent", but this isn't super easy to follow. I'm not sure what a better way to handle client-extension communication would be.
Right now this implementation assumes the editor is set to JavaScript. I think this is the only language we could support right now with the current parser setup (unless we add community plugins, but that's another conversation), but we should probably remove the Prettier button when the editor language is set to something other than JavaScript.
I'm not super familiar with MutationObserver and mostly just copied the StackOverflow implementation. I'm pretty sure there's a more specific query to observe than body and I might not need the childList and subtree options - open to optimizations there.
I'm manually grabbing class names for button styling, but they seem to be auto-generated classes that might not stay constant with new LeetCode changes. Ideally, I'd like to either apply those styles manually or find a more consistent way of grabbing them from LeetCode.

I'm leaving this as a draft PR as I think it still needs some more work before being merged. Very open to any thoughts you guys may have!

I'm currently injecting the client script by creating a script element, setting its textContent through a template literal, and injecting that into the DOM. This StackOverflow post nicely summarizes some other possible ways to run code within a page context - I'm open to other methods.
 Right now the flow is "GetEditorContent" -> "FormatEditorContent" -> "SetEditorContent", but this isn't super easy to follow. I'm not sure what a better way to handle client-extension communication would be.

I'm not sure I fully understand the alternatives. It would be nice to have some simpler function calls, but if the other ones make it too hard to share code I'm fine with these events.

Right now this implementation assumes the editor is set to JavaScript. I think this is the only language we could support right now with the current parser setup (unless we add community plugins, but that's another conversation), but we should probably remove the Prettier button when the editor language is set to something other than JavaScript.

What other languages are supported besides javascript? Here are the parsers we support: https://github.com/prettier/prettier-chrome-extension/blob/master/src/content/parsers.js

I'm manually grabbing class names for button styling, but they seem to be auto-generated classes that might not stay constant with new LeetCode changes. Ideally, I'd like to either apply those styles manually or find a more consistent way of grabbing them from LeetCode.

Personally this seems like the most important improvement to me, as we wouldn't be sure when LeetCode could regenerate their styles and break the DOM manipulation logic. It would be nice if we can find more stable CSS classes or HTML tags to locate the same elements.

I'm not sure I fully understand the alternatives. It would be nice to have some simpler function calls, but if the other ones make it too hard to share code I'm fine with these events.

The only other reasonable alternative I see would be the first method described in the linked post: putting the page context script in a separate file and adding it to web_accessible_resources. This might just make the approach even more confusing so for now I'm okay leaving it as is.
As for event listeners, the main issue is just following the chain of events. Perhaps it's worth even briefly describing the flow in a comment block at the top of the file?

What other languages are supported besides javascript? Here are the parsers we support: /src/content/parsers.js@master

Tons! C++, Java, Python, C, C#, Ruby, Swift, Go, Scala, Kotlin, Rust and PHP. Obviously supporting all of these isn't a priority, but I think it's still a good idea to hide the button when on a non-supported language. I'll try to implement this soon.

Personally this seems like the most important improvement to me, as we wouldn't be sure when LeetCode could regenerate their styles and break the DOM manipulation logic. It would be nice if we can find more stable CSS classes or HTML tags to locate the same elements.

It looks like some elements actually have data-cy properties set on them including the languages select dropdown (data-cy="lang-select") - I'll look into this more and see if I can dynamically grab the select's classes and apply them to the Prettier button.

I managed to replace to hardcoded class names using the data-cy property mentioned above. I also made a _removeButton method to run when the language is set to something other than JavaScript.
My only lingering concern now is the frequency of the MutationObserver calls. Like I said in my initial comment, I'm almost certain there's a more specific querySelector than body, but I'm not entirely sure what that would be. Right now, either _createButton or _removeButton are called on every single DOM update after the initial load which, though it hasn't impacted my performance noticeably, is probably not a great idea.

I've gone ahead and marked this as ready for review - I'll leave it up to you guys to decide if the MutationObserver is fine for now. @lipis @kaicataldo if you guys have any thoughts on this let me know.

I'm fine with the mutation observer usage personally, though I've barely used them so take my opinion with a grain of salt, might want another opinion

Just checking on the status of this - not sure if we want to keep thinking about the mutation observer or just go ahead and merge

This is working on GitHub Actions (our new CI). Do we need anything else before merging?

Nope, I think we're okay based on the thread above.

Thanks, and sorry for the delay, I wasn't sure about the status


Upgrade TeamCity Kotlin DSL to 2021.1

@bot-gradle test and merge

OK, I've already triggered a build for you.

Error while merging successfully tested PR. Please contact the administrator.


Dispatch broadcast on np.ndarray and numbers together

cc @cpcloud
There is still an error here.  Something having to do with not passing unbiased to std correctly somewhere.

@mrocklin still an error after this PR?

Hrm, I had an error on my local machine.  Will check it out tomorrow.

Ah, it was unrelated.  Merging.


None of the panels show on click or hover.

I'm using flask 1.0.2, and have the debug toolbar installed but on hover or click of any of the items in the bar i.e templates, sqlalchemy, nothing happens?  Note that the menu is showing that there are 3 queries in the sqlalchemy section, but nothing expands.

Is this true with the latest release?
I suspect this is actually a javascript conflict issue, are there any errors listed in the browser console?

I had a similar issue. I didn't realize you don't have to call init in your app function. -- I am not using vanilla flask I am using flask-lambda, only may matter bc factory app creation.
Javascript is initialized twice causing the click handler in JS to be called 2x which opened and closed the panels immediately after.
I saw the behavior when I had the init call (doh!):
toolbar: DebugToolbarExtension = DebugToolbarExtension(app)
toolbar.init_app(app)

Fixed when I commented it out
toolbar: DebugToolbarExtension = DebugToolbarExtension(app)
'''toolbar.init_app(app)'''

I hope this can help someone else. Also this project is awesome.  Just what I needed. I may wanted to developer console for debugging SAML responses when testing endpoints. Very cool❗


Arc

Issue #, if available:
Adding ARC
Description of changes:
Adding ARC
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

added zonal shift


Exception when running Jarvis as administrator

I tried to start as an administrator:
UnauthorizedAccessException:
Access to the path "C:\ProgramData\Microsoft\Windows\Start Menu\Programme"
was denied.
Windows 10 Pro 1803(Build 17134.228)

I can't recreate it, but will add some exception handling when indexing files.
Related to #74


Tourists leave parked cars behind when leaving city

What happens:

Tourist enters city by car
Tourist goes to destination walks about a bit
Tourist leaves, often via public transport (eg. train) if it's fastest way to exit from their current position
Abandoned parked car will despawn when the tourist despawns

What should happen:

If tourist enters city by car, then, when leaving city, they should first travel back to their car and leave in the car.

I think this could potentially solve the parking loop (with tourists) issue as well.

I suspect the issue is caused by the custom CustomGetVehicleInfo method.
Specifically, it can detect and re-use a parked vehicle, but only if certain conditions are true (code).
The problem is, I think, this bit of that code:
if (Options.parkingAI && useCar && !useTaxi) .....

Not only does it require Parking AI to be enabled (why?), but it also requires useCar to be true, and useTaxi to be false. Those latter two are randomly decided each time the method is called (code).
I've no idea how that Randomizer works, so could be wrong. If it always results in same values for given citizen, then probably not an issue. However, if it can change over time then it is a problem.

Not only does it require Parking AI to be enabled (why?),

It's simple. Without ParkingAI that car wouldn't be parked earlier, so why bother checking 😉

Hello,
I think this issue is more important than the tags let on.

This is what happens when the tourist leaves the city. Their car becomes "confused" and sits there. Clicking the cim's name does nothing as they have already left the city.
Even with "realistic parking ai" on, my parking item count is always maxed. Removing parked cars works temporarily, but the amount goes up and up until the limit is reached again.
If tourists keep leaving their cars, parking will always end up maxed and will be filled with more and more non-interactive objects.
Needs a fix, tho there are lots of options. Despawning the car when the cim leaves; checking for abandoned cars and removing them; assigned these cars to new tourists as they enter the city and require a vehicle. Or forcing tourists to leave by car if they have a car in the city.

Problem with leaving city is that cims are take completely random outside connection and then try to find way to get there. If they select outside train, they obviously drive to a train station, park vehicle and get in the train there.
I remember there was a bug when tourist still try to use car waiting at outside connection. It was not related with TM:PE, just weird game bug


internal error

<!---   *** BEFORE SUBMITTING: PASTE CLIPBOARD HERE TO COMPLETE YOUR REPORT ***   ---!>
Press run and error happened. did not happen when i used VSC to run the same code.

Hey @tengzikun, thanks for reporting. Could you post a simple version of the code you're trying to run in Spyder?
Otherwise I'm afraid we won't be able to help you, sorry.

Hi ccordoba12. I appreciate your kind reply and attention for this matter. The code is rather simple - using python and pandas library to read a series of csv files and identify the matched entries.  The code works perfectly on VSC, just not spyder
As its my company's code, i can only show u the general picture:
import os
import pandas as pd
from datetime import datetime
def parse_datetime(datetime_str):
# Function to parse datetime from string
# (Unchanged from the original code)
# ... (Unchanged code)

def create_matching_records_csv(csv_files, vehicle_numbers):
# Function to create matching records CSV
# (Unchanged from the original code)
# ... (Unchanged code)

def main():
# Main function to prompt for input and process CSV files
# (Unchanged from the original code)
directory = r'path_to_directory'  # Replace with the actual directory path
vehicle_numbers_input = input("Enter vehicle IU numbers separated by ';': ")
vehicle_numbers = vehicle_numbers_input.split(';')

csv_files = [os.path.join(directory, file) for file in os.listdir(directory) if file.endswith('.csv')]

create_matching_records_csv(csv_files, vehicle_numbers)

if name == "main":
main()

Ok, thanks and sorry for the late reply. What's your Spyder version? And what operating system you're using?

I think this problem is fixed in our latest version available in Anaconda (5.5.1). Please update by closing Spyder, opening the Anaconda Prompt and running there the commands mentioned in our documentation.


 Can you please add a changelog entry about this?

@martijnwalraven also, the CI tests didn't pass on this PR.

@stubailo: Sorry I missed the changelog. I've added it to the 0.3.5 section because it was included in that release.
The tests passed on the CI but I missed the linter errors. Thanks for fixing these.

Yeah no problem! Next time just wait until Travis is done before merging.

I actually did look at the CI results but figured there was something else wrong because the tests themselves passed. Should have taken a closer look at the logs and spotted the linter errors.


App-gateway is truncating the rest api response

Describe the bug
App-gateway is truncating the rest api response.
To Reproduce
App-gateway is truncating the rest api response. Tried calling the rest api via kubectl port-forward, cluster ip and the private ip of the pod within the vnet and response is not truncated
Ingress Controller details
Have attached all the logs to support ticket -<PHONE_NUMBER>00827

Closing this due to inactivity. Feel free to open it again in case issue persists.


Offer FreeCAD fcstd files as an alternative to Solidworks

There are step files and igs files provided as alternatives to Solid works parts

If someone took the time to convert said step and igs files to FCstd files, would you consider including them in this repo ?

I'm unfimiliar with that file type. What benefit does that type have beyond igs and step files? By file size the CAD already takes up a huge amount of space so it's prefer not to just keep adding CAD file types unless there's a compelling argument

Agreed.  FCStd is basically a .zip file that includes a STEP file plus a lot of other things that we don't really need or use for this project, so I'm hesitant to include those files in the repository.  FreeCAD can import STEP files natively, so if anyone does need an FCStd file, FreeCAD would be an easy way to create one from the contents of this repository.


[ADD] Weblate Widget

I haven't tested macro. If anyone can check this.
@sbidoul @pedrobaeza
Following this : https://github.com/OCA/stock-logistics-warehouse/pull/950

Add a test please.

Arf, didn't there was some for that !
Ok

@Yajo Done and :green_apple:

@Yajo changes done. @sbidoul This could be added before 14.0 branches creation ?

@sbidoul wanna merge?


The final result is inconsistent with the expected result

OS: Win10
Build Version: 20200626.4
Does this occur consistently? Yes
Repro steps:

Create a Scrapbook and connect a database.
Type the following in Scrapbook.

db.heroes.drop();
db.heroes.insert({
    "name": "Batman",
    "saying": "I'm Batman"
});
db.heroes.insert({
    "_id": {"$oid" : "5a7e04558ceb7f33005d6134"},
    "name": "Joker",
    "saying": "Ha ha"
});
db.heroes.find({"name": "Joker",
"_id": {"$oid" : "5a7e04558ceb7f33005d6134"},
}, {"name": 0})

Execute all.

Expect:
Final result is:

Actual:
Final result is:

This is something to investigate. The issue may be in this line: }, {"name": 0})

Verified on the latest build 20201102.9, this issue also reproduces for GitHub codespaces.

The current supported api versions of MongoDB on Azure CosmosDB are 3.2 and 3.6.

https://docs.mongodb.com/manual/reference/method/db.collection.insert/

The current supported api versions of MongoDB on Azure CosmosDB are 3.2 and 3.6.

https://docs.mongodb.com/manual/reference/method/db.collection.insert/

The current supported api versions of MongoDB on Azure CosmosDB are 3.2 and 3.6.

https://docs.mongodb.com/manual/reference/method/db.collection.insert/

The current supported api versions of MongoDB on Azure CosmosDB are 3.2 and 3.6.

https://docs.mongodb.com/manual/reference/method/db.collection.insert/

Can you retest this with the latest build of VSCode?

Can you retest this with the latest build of VSCode?

Verified on the latest build 20210121.1, this issue still reproduces for now.

Verified on the latest build 20210121.1, this issue still reproduces for now.

I have the same problem with any version > 0.13.0.
When I do db.users.find({}) I get something like:
[
  {
    "_id": {
      "$oid": "5d3c9d0bf9872c048594328c"
    },
    name: "foo"
  }
]

When I want to retrieve that single document I would use:
db.users.find({
  _id: ObjectId("5d3c9d0bf9872c048594328c")
})

or
db.users.find({
  _id: { $oid: "5d3c9d0bf9872c048594328c" }
})

With versions above 0.13.0 this produces
[]

With versions below or equal to 0.13.0 it produces the expected result:
[
  {
    "_id": {
      "$oid": "5d3c9d0bf9872c048594328c"
    },
    name: "foo"
  }
]

This issue has become stale and is at risk of being closed. The community has 60 days to upvote the issue. If it receives 5 upvotes we will keep it open and take another look. If not, we will close it. To learn more about how we handle issues, please see our documentation.
Happy Coding!


Audit in Azure SQL Database with Read Scale-Out

The article indicates that Audit is not available for connections to Read Scale-Out.
Is it correct that no Audit collection for connection to Read Scale-Out is done?
Does this mean that there is no Threat Detection for Read Scale-Out connections?
Is the Query Performance Insight in the Azure Portal affected?
Is the Automatic tuning for Azure SQL Databases affected?
Is the Performance recommendation for Azure SQL Databases affected?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7a2961d1-4448-11b7-2dc2-3b738bd70939
Version Independent ID: 206eb022-25c4-66d7-7285-0d53a84956e3
Content: Azure SQL Database - read queries on replicas
Content Source: articles/sql-database/sql-database-read-scale-out.md
Service: sql-database
Sub-service: scale-out
GitHub Login: @anosov1960
Microsoft Alias: sashan

@Fabian-Schmidt Thanks for your feedback. We are investigating this issue actively and will get back to you soon.

@Fabian-Schmidt I have assigned this issue to content author to help you further.
@anosov1960 Could you please help the user with his concerns.

Any update?

Related feature: https://feedback.azure.com/forums/217321-sql-database/suggestions/34337935-monitor-queries-on-secondary-database-when-read-sc

#reassign: @MashaMSFT
@Sait-MSFT pls provide your input

#reassign: @sait-msft

sait-msft is not a valid GitHub ID, or is not a collaborator on this repo.

#reassign:@Sait-MSFT

Auditing on Read-Only Replicas is automatically enabled. For further details about the hierarchy of the storage folders, naming conventions, and log format, see SQL Database Audit Log Format.


Feat: Set grafana dashboard folder

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

What this PR does / why we need it:
Adds the functionality to pack the dashboard into a folder. (Grafana Browser)
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Checklist

[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] CHANGELOG.md updated

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: hehuels
Once this PR has been reviewed and has the lgtm label, please assign leogr for approval by writing /assign @leogr in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

06eff20 bump version to 0.9.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: hehuels
Once this PR has been reviewed and has the lgtm label, please ask for approval from cpanato by writing /assign @cpanato in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hehuels, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 462d8a337f0f1e4aa000d1a89abd5f267f52d03f

please bump the chart version

@cpanato PTAL again

@cpanato could you review again and remove the "change request" pls?
Otherwise, the PR can't be merged. Thank you!

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cpanato, hehuels, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [cpanato,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Expose HTTP/2 connection window settings as Pilot environment variables

Expose HTTP/2 connection window settings so that Envoy can be tuned to provide backpressure.  Without this slow upstreams can cause Envoy to consume too much buffer memory relaying requests and slow downstreams can similarly cause Envoy to consume too much buffer memory relaying responses.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Additional context

@howardjohn fixed this in https://github.com/istio/istio/pull/17058
John could you provide an example for configuring this here and then close out the bug?

--set pilot.env.PILOT_INITIAL_CONNECTION_WINDOW_SIZE=65535 --set pilot.env.PILOT_INITIAL_STREAM_WINDOW_SIZE=65535


unbound library is not storing result.data in the response structure for ANY requests

I'm using unbound library in my C++ application. Maybe I'm missing something but it seems that the ub_resolve() and ub_resolve_async() do not populate the the result.data in the response structure for ANY requests. The async method even doesn't call the callback function at all. Simple examples for both sync and async alternatives are attached.
How to compile and run:
g++ -o sync sync.cpp -lunbound
g++ -o async async.cpp -lunbound
./sync
./async

The debug output (verbosity level set to 4) shows that the ANY request was sent, received and the response properly validated.
However, in the result structure, the havedata is false (in the sync result) or the callback is not called at all (the async result). If I only  change ANY (255) to TXT (16) everything works as expected.
This is the output from the sync version. Last lines prefixed with dashes report the values in the response structure:
...
[1699030384] libunbound[656072:0] debug: switching log to stderr
[1699030384] libunbound[656072:0] debug: module config: "validator iterator"
[1699030384] libunbound[656072:0] notice: init module 0: validator
[1699030384] libunbound[656072:0] debug: validator nsec3cfg keysz 1024 mxiter 150
[1699030384] libunbound[656072:0] debug: validator nsec3cfg keysz 2048 mxiter 500
[1699030384] libunbound[656072:0] debug: validator nsec3cfg keysz 4096 mxiter 2500
[1699030384] libunbound[656072:0] notice: init module 1: iterator
[1699030384] libunbound[656072:0] debug: target fetch policy for level 0 is 3
[1699030384] libunbound[656072:0] debug: target fetch policy for level 1 is 2
[1699030384] libunbound[656072:0] debug: target fetch policy for level 2 is 1
[1699030384] libunbound[656072:0] debug: target fetch policy for level 3 is 0
[1699030384] libunbound[656072:0] debug: target fetch policy for level 4 is 0
[1699030384] libunbound[656072:0] debug: Forward zone server list:
[1699030384] libunbound[656072:0] info: DelegationPoint<.>: 0 names (0 missing), 1 addrs (0 result, 1 avail) parentNS
[1699030384] libunbound[656072:0] debug:    ip4 <IP_ADDRESS> port 53 (len 16)
[1699030384] libunbound[656072:0] debug: no config, using builtin root hints.
[1699030384] libunbound[656072:0] debug: pluggable-libevent 2.1.12-stable uses epoll method.
[1699030384] libunbound[656072:0] debug: mesh_run: start
[1699030384] libunbound[656072:0] debug: validator[module 0] operate: extstate:module_state_initial event:module_event_new
[1699030384] libunbound[656072:0] info: validator operate: query example.com. ANY IN
[1699030384] libunbound[656072:0] debug: validator: pass to next module
[1699030384] libunbound[656072:0] debug: mesh_run: validator module exit state is module_wait_module
[1699030384] libunbound[656072:0] debug: iterator[module 1] operate: extstate:module_state_initial event:module_event_pass
[1699030384] libunbound[656072:0] debug: process_request: new external request event
[1699030384] libunbound[656072:0] debug: iter_handle processing q with state INIT REQUEST STATE
[1699030384] libunbound[656072:0] info: resolving example.com. ANY IN
[1699030384] libunbound[656072:0] debug: request has dependency depth of 0
[1699030384] libunbound[656072:0] debug: forwarding request
[1699030384] libunbound[656072:0] debug: iter_handle processing q with state QUERY TARGETS STATE
[1699030384] libunbound[656072:0] info: processQueryTargets: example.com. ANY IN
[1699030384] libunbound[656072:0] debug: processQueryTargets: targetqueries 0, currentqueries 0 sentcount 0
[1699030384] libunbound[656072:0] info: DelegationPoint<.>: 0 names (0 missing), 1 addrs (0 result, 1 avail) parentNS
[1699030384] libunbound[656072:0] debug:    ip4 <IP_ADDRESS> port 53 (len 16)
[1699030384] libunbound[656072:0] debug: attempt to get extra 3 targets
[1699030384] libunbound[656072:0] debug: selrtt 376
[1699030384] libunbound[656072:0] info: sending query: example.com. ANY IN
[1699030384] libunbound[656072:0] debug: sending to target: <.> <IP_ADDRESS>#53
[1699030384] libunbound[656072:0] debug: dnssec status: not expected
[1699030384] libunbound[656072:0] debug: EDNS lookup known=0 vs=0
[1699030384] libunbound[656072:0] debug: serviced query UDP timeout=376 msec
[1699030384] libunbound[656072:0] debug: inserted new pending reply id=f810
[1699030384] libunbound[656072:0] debug: opened UDP if=0 port=58666
[1699030384] libunbound[656072:0] debug: comm point start listening 11 (-1 msec)
[1699030384] libunbound[656072:0] debug: mesh_run: iterator module exit state is module_wait_reply
[1699030384] libunbound[656072:0] info: mesh_run: end 1 recursion states (1 with reply, 0 detached), 1 waiting replies, 0 recursion replies sent, 0 replies dropped, 0 states jostled out
[1699030384] libunbound[656072:0] info: 0RDd mod1 cb example.com. ANY IN
[1699030384] libunbound[656072:0] debug: answer cb
[1699030384] libunbound[656072:0] debug: Incoming reply id = f810
[1699030384] libunbound[656072:0] debug: Incoming reply addr = ip4 <IP_ADDRESS> port 53 (len 16)
[1699030384] libunbound[656072:0] debug: lookup size is 1 entries
[1699030384] libunbound[656072:0] debug: received udp reply.
[1699030384] libunbound[656072:0] debug: udp message[163:0] F81081A00001000200000001076578616D706C6503636F6D0000FF0001C00C0001000100004F8D00045DB8D822C00C002E000100004F8D005F00010D0200015180655FD3A7654430580886076578616D706C6503636F6D001F2A1129737E715D1EC123939C84D9F50908DAA02556586468AFC773292980D17EFC9EF48FF1E0F28BB569E11FB29A5439F3190185822B65C0F45004851258860000290200000080000000
[1699030384] libunbound[656072:0] debug: outnet handle udp reply
[1699030384] libunbound[656072:0] debug: serviced query: EDNS works for ip4 <IP_ADDRESS> port 53 (len 16)
[1699030384] libunbound[656072:0] debug: measured roundtrip at 18 msec
[1699030384] libunbound[656072:0] debug: svcd callbacks start
[1699030384] libunbound[656072:0] debug: mesh_run: start
[1699030384] libunbound[656072:0] debug: iterator[module 1] operate: extstate:module_wait_reply event:module_event_reply
[1699030384] libunbound[656072:0] info: iterator operate: query example.com. ANY IN
[1699030384] libunbound[656072:0] debug: process_response: new external response event
[1699030384] libunbound[656072:0] info: scrub for . NS IN
[1699030384] libunbound[656072:0] info: response for example.com. ANY IN
[1699030384] libunbound[656072:0] info: reply from <.> <IP_ADDRESS>#53
[1699030384] libunbound[656072:0] info: incoming scrubbed packet: ;; ->>HEADER<<- opcode: QUERY, rcode: NOERROR, id: 0
;; flags: qr rd ra ; QUERY: 1, ANSWER: 2, AUTHORITY: 0, ADDITIONAL: 0
;; QUESTION SECTION:
example.com.    IN      ANY

;; ANSWER SECTION:
example.com.    20365   IN      A       <IP_ADDRESS>
example.com.    20365   IN      RRSIG   A 13 2 86400<PHONE_NUMBER>3519<PHONE_NUMBER>2720 2182 example.com. HyoRKXN+cV0ewSOTnITZ9QkI2qAlVlhkaK/HcykpgNF+/J70j/Hg8ou1aeEfsppUOfMZAYWCK2XA9FAEhRJYhg== ;{id = 2182}

;; AUTHORITY SECTION:

;; ADDITIONAL SECTION:
;; MSG SIZE  rcvd: 152

[1699030384] libunbound[656072:0] debug: iter_handle processing q with state QUERY RESPONSE STATE
[1699030384] libunbound[656072:0] info: query response was ANSWER
[1699030384] libunbound[656072:0] debug: iter_handle processing q with state FINISHED RESPONSE STATE
[1699030384] libunbound[656072:0] info: finishing processing for example.com. ANY IN
[1699030384] libunbound[656072:0] debug: mesh_run: iterator module exit state is module_finished
[1699030384] libunbound[656072:0] debug: validator[module 0] operate: extstate:module_wait_module event:module_event_moddone
[1699030384] libunbound[656072:0] info: validator operate: query example.com. ANY IN
[1699030384] libunbound[656072:0] debug: validator: nextmodule returned
[1699030384] libunbound[656072:0] debug: val handle processing q with state VAL_INIT_STATE
[1699030384] libunbound[656072:0] debug: validator classification qtype_any
[1699030384] libunbound[656072:0] info: signer is example.com. TYPE0 CLASS0
[1699030384] libunbound[656072:0] debug: val handle processing q with state VAL_FINISHED_STATE
[1699030384] libunbound[656072:0] debug: mesh_run: validator module exit state is module_finished
[1699030384] libunbound[656072:0] info: mesh_run: end 0 recursion states (0 with reply, 0 detached), 0 waiting replies, 0 recursion replies sent, 0 replies dropped, 0 states jostled out
[1699030384] libunbound[656072:0] debug: svcd callbacks end
[1699030384] libunbound[656072:0] debug: close of port 58666
[1699030384] libunbound[656072:0] debug: close fd 11
---- Arrived 0
---- Have data no
---- Bogus 0
---- Secure 0
---- Rcode 0
---- NX domain 0
---- Answer packet yes
---- Answer length 163
---- Data no
---- Data length 0
---- TTL 20365

Versions

OS: ubuntu 22.04
G++ compiler: g++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
libunbound-dev:amd64 1.13.1-1ubuntu5.3
libunbound8:amd64  1.13.1-1ubuntu5.3

examples.zip


how to save a model,I want to use it for Faster-RCNN

I want to use the model of resnet18 that author offered in model zoo,but the model author offered in the checkpoint.pth.tar has some other values like "epoch" and "optimizer_state_dict",what can I do ?

Hi @tongyutyr,
The checkpoint.pth.tar file format is pickle format, which means that the everything is stored in a kind of dictionary structure.  We store the model parameters in a field named state_dict, according to the PyTorch defacto standard:
https://github.com/NervanaSystems/distiller/blob/8c5de42cf08e8d32b966a570c207039cb799a528/distiller/apputils/checkpoint.py#L168
This means that you can load our models in other PyTorch applications.
Note, however, that when you load sparse weights and then train them outside of Distiller, the sparsity will most likely be removed because of the weight update (w += lr * gradient_w ).  In Distiller we make sure to maintain the sparsity during these updates.
Cheers
Neta

Hi @tongyutyr,
The checkpoint.pth.tar file format is pickle format, which means that the everything is stored in a kind of dictionary structure. We store the model parameters in a field named state_dict, according to the PyTorch defacto standard:
distiller/distiller/apputils/checkpoint.py
Line 168 in 8c5de42
model.load_state_dict(checkpoint['state_dict'])
This means that you can load our models in other PyTorch applications.
Note, however, that when you load sparse weights and then train them outside of Distiller, the sparsity will most likely be removed because of the weight update (w += lr * gradient_w ). In Distiller we make sure to maintain the sparsity during these updates.
Cheers
Neta

thank you,I know how to do that now


Normalization requests

This is after a discussion with Cédric, Tahina and Antoine. Here's an example:
module Test

type alg = | Alg1 | Alg2

let print3 () =
  FStar.IO.print_string "case 3"

let print4 () =
  FStar.IO.print_string "case 4"

inline_for_extraction
let generic'' (a: alg): Tot (unit -> ML unit) =
  match a with
  | Alg1 -> print3
  | Alg2 -> print4

inline_for_extraction
let generic' (a: alg) (): ML unit =
  match a with
  | Alg1 ->
      FStar.IO.print_string "case 3"
  | Alg2 ->
      FStar.IO.print_string "case 4"

inline_for_extraction
let generic (a: alg) (): ML unit =
  match a with
  | Alg1 ->
      let f' = generic' a in
      f' ();
      let f'' = generic'' a in
      f'' ();
      FStar.IO.print_string "case 1"
  | Alg2 ->
      generic' a ();
      generic'' a ();
      FStar.IO.print_string "case 2"

let specialized1 = generic Alg1
let specialized2 = generic Alg2

We would love for the following line:
      generic'' a ();

to be normalized to:
    print3 ();

right now, the intermediary let-binding is required to force normalization of the application.
Thanks,
Jonathan

Not sure why this should be expected of generic''. There is still a case analysis on a:alg.

Agree with Nik's comment there, the match in generic'' would be blocked in generic'' a (). Pinging @msprotz to clarify more, thanks!

Ping @msprotz

This issue doesn't make sense. Closing.


go to Defination in not showing on Ctrl + Click and even after pressing right click go tot defination option is not showing

Type: Bug
not able to
VS Code version: Code 1.75.0 (e2816fe719a4026ffa1ee0189dc89bdfdbafb164, 2023-02-01T15:23:45.584Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
AMD Ryzen 5 4500U with Radeon Graphics          (6 x 2371)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
7.36GB (1.23GB free)

Process Argv
C:\Users\Akshay Rathore\Desktop\NickelFox project\smpl_frontend_investor --crash-reporter-id ea0ee2fa-b192-4f49-ba39-619a188b5516

Screen Reader
no

VM
0%

Extensions: none
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
vsccc:30610678
pyindex848:30577860
nodejswelcome1:30587005
3biah626:30602489
pyind779cf:30657577
89544117:30613380
pythonsymbol12cf:30657549
vscup:30628656

What language is this for?

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Add build script for ESP32

Can you consider to build a ulab firmware for ESP32 and ESP32-S3?
The boards I have are:
ESP32_DevkitC_V4
ESP32-S3-DevkitM-1 v1.0
I'm following the directions to do this myself as well, but I am stuck on the final step of creating and running the make file.
For either of the above boards, can you elaborate on how to create the make file?  The part of the document I am trying to work through is here:

Can you consider to build a ulab firmware for ESP32 and ESP32-S3?

Yes, absolutely.

The boards I have are: ESP32_DevkitC_V4 ESP32-S3-DevkitM-1 v1.0
I'm following the directions to do this myself as well, but I am stuck on the final step of creating and running the make file. For either of the above boards, can you elaborate on how to create the make file?

Simply open a text editor, add
BOARD = GENERIC
USER_C_MODULES = $(BUILD_DIR)/ulab/code/micropython.cmake

include Makefile

and save it under ULAB_MICROPYTHON/micropython/ports/eps32/makefile, where ULAB_MICROPYTHON is the folder, where you have micropython, and ulab side by side.

I created the file at ./ULAB_MICROPYTHON/micropython/ports/esp32/makefile,
and added the 3 lines listed above as the contents to the file makefile.
I note among the many *.c and *.h files and other file types in the esp32
directory, there is another file called MakeFile
While in the esp32 directory, I run  the command make .
But my output is:
make: Nothing to be done for '.'.
Any idea what I am doing wrong?
Also, how to distinguish the firmware for my esp32 versus my esp32s3?  I
assume BOARD=GENERIC does something that should work with most esp32,but is
there way to make it more specific (not sure I really need that, but to
know how it is possible might help me to better understand the build
process)
On Mon, Oct 3, 2022 at 4:26 AM Zoltán Vörös @.***>
wrote:

Can you consider to build a ulab firmware for ESP32 and ESP32-S3?
Yes, absolutely.
The boards I have are: ESP32_DevkitC_V4 ESP32-S3-DevkitM-1 v1.0
I'm following the directions to do this myself as well, but I am stuck on
the final step of creating and running the make file. For either of the
above boards, can you elaborate on how to create the make file?
Simply open a text editor, add
BOARD = GENERIC
USER_C_MODULES = $(BUILD_DIR)/ulab/code/micropython.cmake
include Makefile
and save it under ULAB_MICROPYTHON/micropython/ports/eps32/makefile,
where ULAB_MICROPYTHON is the folder, where you have micropython, and ulab
side by side.
—
Reply to this email directly, view it on GitHub
https://github.com/v923z/micropython-builder/issues/4#issuecomment-1265103506,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGH5SSRT45ACTX7YRC326KLWBKKDTANCNFSM6AAAAAAQ3D4S4Y
.
You are receiving this because you authored the thread.Message ID:
@.***>

I created the file at ./ULAB_MICROPYTHON/micropython/ports/esp32/makefile, and added the 3 lines listed above as the

Here you need a directory name, not ULAB_MICROPYTHON. You should substitute here the name of your directory. So, e.g., in my case I have
artifacts  micropython  micropython-lib ulab

in a directory called
/home/v923z/sandbox/test

so you would create
/home/v923z/sandbox/test/micropython/ports/esp32/makefile

Basically,
/home/v923z/sandbox/test

is the directory, where you cloned both micropython and ulab.
I hope this helps.

Yes I started over again and this time I completed the build process.  My error in the last step was executing 'make .' instead of 'make' (note period).  Oops!
I used BOARD=GENERIC_S3 in the makefile, since my ESP32 is an S3 model, and the build completed without error.
Now I am trying to flash the board over the USB at port /dev/ttyACM0, which I have confirmed to be the correct port.  I am using the command:
idf.py -p /dev/ttyACM0 flash
Unfortunately I got an error:  No serial data received.
Maybe this isn't something you can help with, but if you have an idea, I would be glad to know.

One thing I see is that the esptool.py version used automatically for the flash process is esptool.py v3.2-dev.  The latest esptool.py version is 4.3.  Do you think this should be updated?  The reason I am confident that the port and physical hardware connection is correct is that I can still run 'mpremote a0' and connect to the esp32s3.

I was able to establish the connection.  It was a hardware issue.  However, I could not successfully flash the device. Following make, the created executable command fails since it recognizes the board as an S3. This may be because the S3 is flashed from memory 0x0, whereas older esp32 boards are flashed from 0x1000.

You might have to edit the partition table: https://github.com/v923z/micropython-ulab/#what-to-do-if-the-firmware-is-too-large

Yes there are few things that I believe must be changed.  I haven't found the right list or combination yet.  But I think there at least these three:

IDF tools version has to be at least v4.4.
In makefile, BOARD should be set equal to GENERIC_S3.  I don't think this also has to be set in Makefile, but perhaps it does.
Flash should start from location 0x0 rather than 0x1000, which differs from other ESP devices.  You hint about the partition relates to this.

There may need to be something else to let the idf.py tool know that the target is an esp32s3 and not an esp32.  I just notice in some of the messages during the build process that an esp32 is assumed as the default.

I succeeded in building ulab for my esp32 S3.

I used IDF tools version v4.4.
In makefile, BOARD should be set equal to GENERIC_S3.

I did not have to make any other changes.

Great! Would you mind adding your build script here?

Build script for ESP32 S3
First, clone the ulab, the micropython, as well as the espressif repositories:
export BUILD_DIR=$(pwd)

git clone https://github.com/v923z/micropython-ulab.git ulab
git clone https://github.com/micropython/micropython.git

cd $BUILD_DIR/micropython/

git clone -b v4.4 --recursive https://github.com/espressif/esp-idf.git

Then install the ESP-IDF tools:
cd esp-idf
./install.sh
. ./export.sh

Next, build the micropython cross-compiler, and the ESP sub-modules:
cd $BUILD_DIR/micropython/mpy-cross
make
cd $BUILD_DIR/micropython/ports/esp32
make submodules

At this point, all requirements are installed and built. We can now compile the firmware with ulab. In $BUILD_DIR/micropython/ports/esp32 create a makefile with the following content:
BOARD = GENERIC_S3
USER_C_MODULES = $(BUILD_DIR)/ulab/code/micropython.cmake

include Makefile

Now you can run make.


Check that operators are of type Mapping

What is the context of this PR?
In some areas in runner we were checking whether a routing rule has a valid operator, but not checking that it is of type Mapping. As a result, routing on backward journeys for confirmation questions sometimes was resulting in an error.
Adds a method to check that the operator is a Mapping type when evaluating routing rules.
How to review
Check routing in the test_new_confirmation_question schema is not broken (routing backward from the confirmation question).
Check that nowhere else needs to be updated.
Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

 New routing rules: Missing check that operators are Mappings

 Release: 4.9.2


ACME v2

I, along with many others, am super excited about Let's Encrypt supporting wildcard certs in 2018. According to their latest blog they should have a test endpoint up in early January.
I really like this library, as it has saved me from having to deal with acme directly at all. Is acme v2 and wildcard support on your radar at all? I am not even sure what the major differences are, or what is involved in upgrading. Will a single library be able to handle both, or will a separate package be needed?
If I had all my dreams come true I would love for lego to let me get wildcard certs asap, but I know this is may be a considerable undertaking. Thanks for everything.

Yes, I do plan on supporting the V2 API of Let's Encrypt along with ACMEv2. It will happen during my holidays in early January.

And I will be available on standby to help where needed!

I am not even sure what the major differences are, or what is involved in upgrading.

I left a short comment on a similar issue in the Dehydrated repo with a quick list of differences that might help folks get a rough idea of the work involved.

At the risk of sounding ungrateful, is there a status update on this? I'd love to be able to integrate and test things out before LE goes live this month.

Also eagerly waiting support so we can leverage it in Terraform!

Hey all! I'm sorry this is getting delayed but I had a lot more work in my day job than I anticipated during this time. Be assured that I'm working on this as much as possible though.

So another question just popped up and I wanted to see what all of you think. The issue is package naming.
ACMEv2 is largely incompatible with V1 so I developed it in a separate package. Seeing that it will probably be the default version going forward I'd move the V1 implementation into a new package to archive it and have the V2 implementation in the acme package.
What do you think?

Do you think the client api will need to change though? My code uses Register,  ObtainCertificate, and RenewCertificate. I don't see much in those signatures that would change from v1 to v2, even if all of the code underneath changes.
Possibly my saved json files for accounts and certificates would be invalid moving from v1 to v2? But I hope not.
In my dream scenario, the package recognizes automatically which version to use based on the directory endpoint you give it. Maybe have explicit v1 and v2 packages, but the acme package does some kind of auto-discovery dispatch thing? Does the protocol have an easy version identifier endpoint?

Do you think the client api will need to change though?
No, there are currently no changes to the existing API, only internal changes and new functions as V2 offers more endpoints.

Does the protocol have an easy version identifier endpoint?
No. The protocol is not versioned at all, the whole "V2" is just because LE chose to name their endpoint that way. The ACME protocol itself was never standardized and so did not have a V1.

Possibly my saved json files for accounts and certificates would be invalid moving from v1 to v2? But I hope not.
Most likely. All messages are different and existing AuthZ are not transferred to the V2 endpoint, accounts are though so we may look at transferring them.

Looks like they delayed their live rollout a little bit. https://community.letsencrypt.org/t/acmev2-and-wildcard-launch-delay/53654

Hello @xenolf,

Seeing that it will probably be the default version going forward I'd move the V1 implementation into a new package to archive it and have the V2 implementation in the acme package

If the API does not change, maybe the best solution would be to use type aliases?
Thus, you can define two packages as acmev1 and acmev2 and then using type aliases to define all the acme package types by linking them to acmev1 types and mark all the acme types as deprecated.
WDYT?

community.letsencrypt.org/acme-v2-and-wildcard-certificate-support-is-live

That's awesome news. Seems we're waiting on @xenolf here, and maybe there are some time demands outside his control.
I've got a dev environment set up and I'll try giving it a shot at converting to v2 myself.

Should only be a couple of hours :)

You can find initial ACMEv2 support in the acmev2 branch.
Please keep in mind that this is not completely done yet as some things like docs and final naming on the library are missing. I put it into its own folder for now because it was easier to write this way. I'm not sure if it will stay like that though - I'm open for suggestions.
Anyways, you should be able to get a certificate from the V2 endpoint (yes, wildcards) and it should not need many changes to your code.
For users of the CLI binary, it will attempt to convert your account to the new format on first run. Certificates can't be transferred and need to be requested again.
Please report any problems you encounter with it and also please let me know your thoughts about the naming - I spend considerable time on thinking about that and didn't come up with a really good solution.

Had to remove Azure as a dns provider, seems like they removed the sdk for dns or something from github, didn't investigate too much.
When I try a run, I get the following error:
2018/03/14 01:45:12 Could not load account for<emailHere>. Registration is nil -> &errors.errorString{s:"directory missing new registration URL"}

I replaced the 	import string in the azure.go providers directory with
"github.com/Azure/azure-sdk-for-go/services/dns/mgmt/2017-09-01/dns"
acmev2 branch has
"github.com/Azure/azure-sdk-for-go/arm/dns" <-- which doesn't exist
the go update still broke after that so I just removed azure and updated.
@stephenjamieson I got the same error using the non acmev2 branch against the acmev2 endpoint
Once the go update completed (-azure) the process worked flawlessly.

Hrm, @shaunbro I did switch to the acmev2 branch, not sure what else I'm missing.

Awesome. Super excited to test this tomorrow. One thing I noticed: the v1 and v2 directory endpoints have a noticeably different structure. Field names moved from underscore_case to camelCase, and some things like that.
What if...

We detect from the directory endpoint given which version of the protocol to use.
acmev1 and acmev2 packages implement a thin client interface, and the acme package does the higher level orchestration to get certificates and perform bigger actions in a version-independent way.

ACME v1 was never standardized and will be phased out. I don't really see a point in trying to keep it alive, other than to have it available for a while if people still need it; but I think everyone will be moving to v2. And if not, they'll have to anyway as v1 will be discontinued. In other words, I would rather we not make design decisions with the hope of preserving v1... but that's just me. 😇

Wow! this is working great. I managed to issue some certs with multiple wildcards and everything.
I did manage to get it to crash a few times. I think I failed some validations and then ran again, and it gave some super odd output and paniced:
2018/03/14 11:33:27 client.go:40: [INFO][teststackoverflow.com, www.teststackoverflow.com, *.teststackoverflow.com, *.ww33w.teststackoverflow.com] acme: Obtaining bundled SAN certificate
2018/03/14 11:33:27 client.go:40: [INFO][teststackoverflow.com, www.teststackoverflow.com, *.teststackoverflow.com, *.ww33w.teststackoverflow.com] acme: Validations succeeded; requesting certificates
panic: runtime error: index out of range

goroutine 1 [running]:
github.com/StackExchange/dnscontrol/vendor/github.com/xenolf/lego/acmev2.(*Client).requestCertificateForOrder(0xc0420bc900, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        D:/gopath/src/github.com/StackExchange/dnscontrol/vendor/github.com/xenolf/lego/acmev2/client.go:591 +0x490
github.com/StackExchange/dnscontrol/vendor/github.com/xenolf/lego/acmev2.(*Client).ObtainCertificate(0xc0420bc900, 0xc04252e600, 0x4, 0x4, 0x49d801, 0x0, 0x0, 0xc0425f9401, 0x0, 0x0, ...)
        D:/gopath/src/github.com/StackExchange/dnscontrol/vendor/github.com/xenolf/lego/acmev2/client.go:372 +0x453

This is against the staging LE server. It seems to be pretty consistent, so maybe I can help get more output to debug with.

Wow that's a weird error. I am sure it didn't do any validations in under a second. Were there some odd circumstances you could identify? If a challenge fails to verify, it should have been logged.

The previous run to the panics ended with acme: Error 400 - urn:ietf:params:acme:error:connection - DNS problem: NXDOMAIN looking up TXT for _acme-challenge.teststackoverflow.com

I will see if I can reproduce when I get home today.

I've been having a go with the branch and just get EOF errors when calling client.Register, client.ResolveAccountByKey. Have been using mitmproxy to look at the HTTP traffic and I just get empty responses from the staging and prod LE APIs. I'm probably using the v2 client incorrectly but thought I'd mention it anyway.

@adeslade can you post some output?

Sure! I've created a gist with the code and output

@adeslade ResolveAccountByKey() is only useful if you have an existing account with LE which you registered before and are using that exact private key. Is that the case? Otherwise you can remove it and only call Register().

@adeslade not sure what the problem is to be honest. I've tried your exact code minus the ResolveAccountByKey() call and it worked fine.

Okay, well thanks so much for having a look.

Hello @xenolf ,
I tried to use the V2 API with a boulder stack and I have the same issue than @captncraig :
	/usr/lib/go/src/runtime/panic.go:505 +0x229
xxx/vendor/github.com/xenolf/lego/acmev2.(*Client).requestCertificateForOrder(0xc420170240, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	xxx/vendor/github.com/xenolf/lego/acmev2/client.go:591 +0x489
xxx/vendor/github.com/xenolf/lego/acmev2.(*Client).ObtainCertificate(0xc420170240, 0xc4201b41c0, 0x1, 0x1, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	xxx/vendor/github.com/xenolf/lego/acmev2/client.go:372 +0x44c

The panic seems to be due to the instruction : https://github.com/xenolf/lego/blob/acmev2/acmev2/client.go#L591 because Identifiers is empty.
The real problem seems to appear when the newOrder is requested : https://github.com/xenolf/lego/blob/acmev2/acmev2/client.go#L476. An error is generated in the Boulder side and the response is empty.
By analyzing the boulder logs, I detected these erros messages  :
boulder_1  | E152630 boulder-wfe2 [AUDIT] Internal error - Error creating new order - rpc error: code = Unknown desc = rpc error: code = Unknown desc = Error 1054: Unknown column 'created' in 'where clause'
boulder_1  | I152630 boulder-wfe2 JSON={"Endpoint":"/acme/new-order","Method":"POST","Errors":["500 :: serverInternal :: Error creating new order","\u0026grpc.rpcError{code:0x2, desc:\"rpc error: code = Unknown desc = Error 1054: Unknown column 'created' in 'where clause'\"}"],"Requester":2,"Contacts":["mailto:test@foo.bar"],"UserAgent":"Go-http-client/1.1 (linux; amd64) xenolf-acme","Code":500,"Payload":"{\"identifiers\":[{\"type\":\"dns\",\"value\":\"localhost.com\"}]}"}

Unfortunately, I lost myself in the Boulder code and I did not analyze more the issue.

@nmengin Thanks for this! Is the response code 200 but the body is empty?

@xenolf No it's a code 500.
But I just found a SQL migration file in boulder wich has to ADD the unknown column.
I check if the script is really executed when Boulder starts and I give you a feedback ASAP.

@xenolf : it was the problem!!!
I connected myself to the mysql BD from the boulder stack and executed the content of the SQL files from this directory and it works!
Now, I'm going to see why these scripts are not executed :wink:

Just had another go @xenolf, using a new private key I was able to register successfully but the subsequent call resulted in the EOF behaviour from before. I'm not great at go but I'll try digging into the code to see if I can find anything.

@xenolf just wanted to report I've successfully issued some wildcard certs with very minimal changes to my code so thank you for your hard work! ❤
I too hit one error (my own fault) but it seems that in createOrderForIdentifiers if this call fails:
hdr, err := postJSON(c.jws, c.directory.NewOrderURL, order, &response)

the error is lost somewhere along the way and it immediately prints
2018/03/14 17:08:09 [INFO][*.richt.co.uk] acme: Obtaining bundled SAN certificate
2018/03/14 17:08:10 [INFO][*.richt.co.uk] acme: Validations succeeded; requesting certificates

and then panics. The error in my case with some debugging was:
acme: Error 400 - urn:ietf:params:acme:error:malformed - No Key ID in JWS header

@nmengin Nice! Let me know if there is anything else.
@moomerman Thanks a lot! This error seems to be common, so I hope I can get rid of it today.
@adeslade I think I see what is happening with your code. An account has to be Register()ed only once ever. Once you are registered you have to persist the Registration somewhere, load it on the next run and not call Register() again but move on to ObtainCertificate() for example.

@nmengin Great that you got it working! I think a check on the Identifiers would only supress the effect of a failure further up the chain. I need to figure out why its possible to have empty Identifiers in the first place. There has to be an error case somewhere we're not handling right.

Ok, here's the first issue debugged more:
this segment where it creates the order:
I can print my request and response:
SENDING {"identifiers":[{"type":"dns","value":"teststackoverflow.com"},{"type":"dns","value":"www2.teststackoverflow.com"},{"type":"dns","value":"*.teststackoverflow.com"},{"type":"dns","value":"*.sss.ww33w.teststackoverflow.com"}]}
ERR acme: Error 500 - urn:ietf:params:acme:error:serverInternal - Error creating new order

I'm not sure what the acme server does not like about that. May be an issue with them.
But the lego code continues past the error, which is misleading at best.

But the lego code continues past the error, which is misleading at best.

Agreed and it is a bug, it should quit the issuing process and return the error.

@captncraig I pushed the missing return statements. The process should now properly abort on error.

@captncraig It seems like your issue is because of overlapping wildcard domains. An issue will be opened in boulder to improve the error message that is returned.

What do you mean overlapping? *.example.com and *.foo.example.com don't overlap.
It does seem related to boulder though. If I request without any wildcards it proceeds. If I add any wildcards now it gives the "error creating order". I think I may have messed up something in my account.

Oh, the wildcard name conflicts with a non-wildcard name. Gotcha. Can't do foo.example.com and *.example.com on one cert. Thanks!

@captncraig It seems like your issue is because of overlapping wildcard domains. An issue will be opened in boulder to improve the error message that is returned.

https://github.com/letsencrypt/boulder/issues/3558 is the Boulder issue to track

(Another good reason Caddy doesn't try to put multiple names on a cert! 🕺 - keeps things simpler)
This is working pretty great in Caddy. I've just about figured out the updated flow as far as user accounts and wildcards go. Great work, @xenolf!

When I use renew lego is using *.domain instead of _. it is also another domain from many i use :)

I used run many times but i have an idea. I switched the commonName from .us Domain to .de. And he used the .us Domain. Maybe this is the case here. Will test it tomorrow but you might have an idea :)

@xenolf in the master branch, lego will use the first domains value mentioned by user as certificate's CN and file name. in this version it uses the first domains in alphabetical order (i think) for run only. for renew it still try to use master's behavior, so it can't find the files.
FWIW, I still prefer the old behavior so I can choose which domain as CN.

@jahmad That is a regression and not expected. Boulder seems to return the identifiers in alphabetical order in the response to the order creation request and not in the same order we submit them. I'll take a closer look at that.

@captncraig It seems like your issue is because of overlapping wildcard domains. An issue will be opened in boulder to improve the error message that is returned.

letsencrypt/boulder#3558 is the Boulder issue to track

As a quick update: letsencrypt/boulder#3558 is fixed in master, and the staging environment. The bug was not present in production. There shouldn't be any further staging newOrder 500s. Please open a Boulder issue if you find any!
Thanks!

@cpu Do you know if it is intentional that boulder returns the identifiers you request in an order in alphabetical order in the response to "new-order"?

@cpu Do you know if it is intentional that boulder returns the identifiers you request in an order in alphabetical order in the response to "new-order"?

It's intentional. This happens at the RA level. We normalize the names before storing the order with core.UniqueLowerNames:
https://github.com/letsencrypt/boulder/blob/7e5f22dd8d35c8f48dac8ff241b61cee41296dac/ra/ra.go#L1715
That function returns the names in alphabetical order: https://github.com/letsencrypt/boulder/blob/7e5f22dd8d35c8f48dac8ff241b61cee41296dac/core/util.go#L203:L218
The specification doesn't say anything about identifier order in the order (wow that's confusing to say) so I think the safest bet is to not assume anything about the order of the identifiers in the order returned by the server. Boulder sorts them but another ACME server may not. If pressed to change I would probably advocate for Boulder to move towards randomizing the identifier order in the order response to emphasize that it shouldn't be relied upon (Sounds like a good idea for Pebble actually! - https://github.com/letsencrypt/pebble/issues/104).

@cpu thanks for the clarification!

FWIW, I still prefer the old behavior so I can choose which domain as CN.

As far as I can tell common name usage is deprecated and will probably be removed from browsers: https://groups.google.com/a/chromium.org/forum/#!topic/security-dev/IGT2fLJrAeo

@arnested my main concern is seeing my typo domain as CN, it just feels ugly :)
that link You provided seems only talk about requiring SAN, which I believe won't affect any LE's certificates.

@arnesteed @jahmad CN deprecation is at the "you can add it but nobody will listen anyway" stage. Only took 17 years for reality to catch up to the RFC. Heh.

@zatricky nobody disputing that. Yes, browser will only use SAN and ignore CN for verification. There is no problem whatsoever with that reality. None. Zilch.
I'm only talking about cosmetic change, what's displayed first time when users check the certificate. and how I actually manage my own certs. and @xenolf already recognize it as regression anyway...

@xenolf Any update on when the acmev2 branch will be merged to master?

any update?


Add D2D renderer

GDI+ is really considered obsolete, and many libs/ui frameworks is moving to d2d.

Indeed, we should add D2D port. Dirk had once worked for WinDrawLib port, I guess it was a next step after GDI+ port. I want to hear his comment whether he found any critical problem and abandoned this project, or he moved to another port calling D2D directory.
BTW, I'm really newbie about D2D programming. Is there any nice tutorial?

@mpsuzuki If you used GDI+ before it is not hard to get into D2D. The basic idea of rendering is similar.
Would you be interested in working on the D2D port? I could try to get someone in my team interested but that will take a couple of weeks at least.

I think the request of the migration to D2D is reasonable, but I've never experienced with GDI+ programming. Maybe a couple of weeks is to short for me to learn D2D. I want to hear whether any experts from your team would be interested in this issue. If nobody would work (that's really OK, no problem), and there is no technical barrier, I should work for this.

@mpsuzuki No problem :)

An early prototype can be found here: https://github.com/dirkschulze/svg-native-viewer/tree/d2d-port (crashing after drawing  currently).


Add slashing tests

Slashing scenarios tests.
Checks that tests work at the vault's level.
TODO:

[x] Scenario 1.
[x] Scenario 2.
[x] Scenario 3.
[x] Scenario 4. (not supported) (Requires more than one Consumer)
[x] Scenario 5. (not supported) (Requires more than one Consumer)

Very nice to have some real numbers here. I added some question about the max lien amount. I am not sure if I have the correct understanding how they are calculated.

Take a look at https://github.com/osmosis-labs/mesh-security/blob/main/docs/provider/Vault.md#invariants and related, in case you're interested.

The tests cover the slash event on the consumer side and the event handling on the provider side. It would be great to also have the rebalance executed for the full cycle to ensure that the numbers match as well. This can be done in a new PR though.

Indeed. Will do that in a follow-up test.

I would be curious to see a slash on the provider side executed. But this can also be a new PR.

This would require the new version of the contracts (v0.9.0) which will be released soon. Let's release this version of the SDK, and then work on releasing that.


chore: bump mosaic to 60, update for breaking Menu changes

Related to https://github.com/stoplightio/mosaic/issues/140
The big breaking change when moving to react-aria ecosystem for menu component is that we provide menu structure as an items object, rather than react children. That is the majority of this PR.
One thing you might like @marcelltoth - nice news is that performance of menus has improved significantly :). Still plenty to improve down the line, but it's pretty good for now.
Before:

After (and this is with development react build which is much slower than normal, while the "before" capture above was captured from prod site). Also note that it looks kind of jumpy because the frame rate on the gif is not high enough:

Alrighty so this is good to go except for the create react app and angular examples. Haven't had time to look into it yet for more than 15 min, but getting this after building and serving, on all pages (https://reactjs.org/docs/error-decoder.html/?invariant=130&args[]=undefined&args[]=):

Not occurring in the demo site or the other examples - just create react app and angular. Before I dig in, @stoplightio/undefined how have you guys been debugging / working with these example apps? I started trying to figure it out but the basic iteration loop of make change, run elements build, run copy example, run build example, run serve (or start), takes forever. Am I missing a better way?

I'll take a look at those builds.
They are indeed cumbersome to debug, however I have loooooots of experience by now. 🌊

(sorry, accidentally closed) 😂

I tested around and it works very well.
My only problem is that the menu expands downwards always. On small screens this gives an illusion of the menu being broken. Scroll works there, so it's usable, but it looks strange.

My only problem is that the menu expands downwards always. On small screens this gives an illusion of the menu being broken. Scroll works there, so it's usable, but it looks strange.

Weird - works OK on the mosaic docs site, perhaps something to do with the scrolling containers in this context 🤔. In any case, nice catch! Will see if I have time today to take a peek, otherwise IMHO we might consider tackling this in a separate PR when we have bandwidth.

Ooo checks passing - thanks! What was the build issue in the end?

@marbemac Sure I would be okay with merging, it's not a huge issue.
Regarding the build - it was an old issue in JSV that we fixed already (caused by those infamous .ejs suffixes).
It was not an issue with your PR - it was on main also, because we didn't update JSV yet at that point.

Ok so that was kindd of a pain to track down ha. @mpodlasin I ended up bumping to mosaic ^1, but that didn't quite fix it. I ended up having to remove the lock files from the example folders, since something about how yarn resolves packages with local file paths (example-dev elements packages) results in it not cleaning up the old react-aria/* packages from the lock file that was copied over from examples. This results in multiple react-aria packages being installed - this is bad because they use react context providers, which don't play well when multiple versions of the package are loaded.
It's kind of confusing, happy to hop on a call or continue to chat async if you'd like. But basically since last you reviewed, the main change is to bump to mosaic v1, and delete the example yarn lock files. LMK what you think.


System alert sound is clipped on auto-quit

The completion alert sound when CZ is the front app is clipped when auto-quit is enabled. Presumably it doesn't finish plating before the app terminates. Notification Center alert is fine as expected as it's handled by the system.
Can the play sound action be handed off to the system for completion after app terminated or the app window hidden and a terminate be delayed until sound completed? Do you get notified when completed? Otherwise could be an issue for sounds longer than the system default.

Don't know if that actually is possible. I think the best solution is to always show a notification when auto quit is on. That way the user will always know what is happening.

That works. Notification on auto-quit makes sense as the interface is no longer present to indicate number of items processed, etc.

I would tie it to the background state settings for notification, i.e just one settings (notifications on/off).

Yup, done, committed.


[backport v3.5-branch] Bluetooth: Controller: Few control procedure and compiler re-ordering fixes

@cvinayak do you have a tracking bug for this? big PR for a backport btw, is it all reallly needed?


Adds aruco model and new aircraft model

What?
Adds new airframe model with a camera and new world file with aruco markers
Why?
Before adding the object detection node, we need to add a camera plugin for the sim
How?

New directory for aruco markers which is the basis for the future plugin, which will enable moving aruco markers.
new world file with two aruco markers
new aircraft model with a camera

Testing
Tested the entrypoint script on the AWS instance
Screenshot
https://github.com/user-attachments/assets/da8950bc-e867-40ff-bb8d-c1fafa3f4952

Rebasesd everything on v1.15.1 to have the latest stable


⚠ PrivateHD has degraded performance

In e9eb303, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 2936 ms

Resolved: PrivateHD performance has improved in 5b0df5c.


Fix unsupported agent condition flapping and resolve source of flaky tests.

A but was introduced in pr #3209 that caused some chaos in our functional test suite that was difficult to track down. What was happening is that every time the unsupported user agent condition was set, it would immediately trigger unsetting it, which would then immediately trigger setting it again... which resulted in an infinite tight reconcile loop. each loop would result in a write to etcd. So it created a storm of database writes as well.
This fixes condition setting issue and likely resolves many of our flaky tests in the process. During the process of investigating this, i noticed that we were comparing the conditions slice in a way that didn't account for ordering differences, so I resolved that as well.
Luckily we didn't have a release with this bug. We need to find a way to detect this sort of error in the future. Perhaps something that can detect how many reconcile loops our controllers invoke during the functional tests. For example, if a 60 second test has > 1000 writes to an object, something is probably wrong.
NONE

the first test results were positive. However this didn't fix the  should find one leading virt-controller and two ready test, so I have left that one marked as flaky.

/approve


Incompatible with Teensy 4.0

Hi, for some reason using BigNumber::begin begins heating the backside of the Teensy 4.0. If you are not fast enough and restore your Teensy with the self-rescue 15 second button press, this will eventually kill it.
Verified with a minimal sketch and two Teensy 4.0.
I have no idea how this could be happening, just wanted to let you now.

All that BigNumber::begin does is call bc_init_numbers which initializes a few default numbers (zero, one and two) by calling bc_new_num. All bc_new_num does is allocate some memory and assign a couple of variables.
I find it hard to believe that doing a couple of memory allocations would make your Teensy heat up and self-destroy. I suggest you have a hardware problem, what it is I don't know. Perhaps there is a piece of wire on your bench that is short-circuiting the board.
You could ask on the Teensy forum whether they think that badly-written software could possible make the board heat up and die. Not that I am suggesting that this particular library is badly-written. :)


Add pictorial ids, script for 118th Congress

Adds ids mapping to GPO's Pictorial Member Guide
pictorialapi.gpo.gov
This PR includes ids for all members of 118th Congress. It may also work for historical files -- at least going back to 110 -- but I have not included that work here, as it requires manual fixes and I imagine most interest is in current membership.
Closes #942

Sorry there is a conflict now.

@JoshData Should be all good now

TY!


Add a question-level config option for enabling friendly syntax errors.

Ha, I was doing almost the same thing in my upcoming PR, except I called it enableFriendlyErrors, because runtime errors are also modified, right?


Symlink staticfiles option

Django's collectstatic command has a --link option (https://docs.djangoproject.com/en/2.2/ref/contrib/staticfiles/#cmdoption-collectstatic-link) which symlinks files where possible instead of creating copies of them.
I've seen this reduce the size of collected-static directories by up to 40% so this should have a positive impact on slug sizes!
As far as I can tell this is also compatible with Whitenoise and doesn't interfere with how it generates gzipped versions of files as those remain as actual files.

I've filed a corresponding issue for this feature request as #1060 (in part so I can sync to our internal tracking tools, so I can ensure it's in the backlog).

I've filed a corresponding issue for this feature request as #1060 (in part so I can sync to our internal tracking tools, so I can ensure it's in the backlog).

Closing this out for now - let's track resolving the questions mentioned above in #1060 :-)


MAX_THREADS/NUM_THREADS not propagated to Makefile.conf_last

Makefile.install uses MAX_THREADS when writing the pkgconfig file, and falls back to the build host core/thread count when "NUM_THREADS" is not passed to make install.
NUM_THREADS is not written to Makefile.conf_last, contrary to e.g. DYNAMIC_ARCH. This is probably an oversight.
There are other options which apparently are not saved when building the library (i.e. everything related to install directories), and are evaluated by make install/Makefile.install, but there is unfortunately no documentation when each option is evaluated - by make, make install, or both.
It is probably save to pass all options to both calls, but this is not what the current documentation suggests or uses in the examples.

This is probably far from ideal, but the output produced at the end of the build says to repeat all the command  line arguments given to make in the make install. You are certainly right that this should be made clearer in the README

(And I do not recall offhand why it has to be like this - probably related to the cursed recursive operation of the makefiles)

Another variable which is not saved correctly is "CORE", it is exported as TARGET to Makefile.conf_last.
The  pkgconfig file then contains "UNKNOWN".
https://github.com/martin-frbg/OpenBLAS/blob/d11e7340024e919bde0dad4e8945ac86cf5fd06b/Makefile.install#L181


samples: add recipe finder

Pull Request Title
Add sample recipe finder to daytona.
Description
Add sample react recipe finder to daytona registry.

Please resolve the conflict


Image optimisation for the DIT training page

Images used on this page were a little big in terms of filesize so have optimised them.

Filename
Before (KB)
After (KB)
Diff
Converted to jpeg

DIT-banner@2x
1000
176
-82%
Yes

DIT-small-image
73.7
21.8
-70%
Yes

Images converted to jpeg, but very hard to spot the difference. And given they are background images 100% clarity isn't a requirement for the images for users anyway.

Imageoptim is an excellent tool. But if it encounters a PNG I believe it will still compress it in a lossless format. So the file will be smaller, but still huge. As you say, It's the converting to lossy jpeg that has reduced the size here.
My go to tool for this is https://squoosh.app/, an in-browser app where you can easily adjust settings and compare the original vs the optimised version.


[BUG] Violation warnings in verbose level chrome dev tools logging

Expected Behavior
Expect Chart.js to not cause logs in dev console
Current Behavior
touchstart and touchend event listeners log verbose level [Violation] messages (see below).
Possible Solution
addEventListener can now take a map {"passive": "true"} see the MDN entry
Steps to Reproduce (for bugs)

Go to the unedited codepen: https://codepen.io/pen?template=JXVYzq
Open chrome dev tools console and set log level to verbose
Refresh page
See verbose log in console: [Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. Chart.bundle.min.js:14

Context
It's helpful to have verbose logging turned on in development because chrome will warn you when javascript execution locks up the browser. Having Chart.js warnings comingled with application logs reduces signal to noise.
Environment

Chart.js version: tried in 2.0/2.5/2.6
Browser name and version: Chrome OSX Version 58.0.3029.110 (64-bit)

I'm happy to look at a PR for this

+1

+1

When will this be released? It seems like quite a long time between that fix and the release..

+1

Very soon: #4706