Web-Server device no longer available

Use case
The web-server option which used to be available no longer shows up in flutter devices and therefore is no longer an option in IntelliJ.
I need this because I haven't found a way to set flags in the chrome runner, and I need the insecure localhost flag enabled.
Proposal
Re-enable the web server device in the listing of devices.
I know that it is still supported because I can run flutter run -d web-server on the terminal.

Flutter Doctor results
[✓] Flutter (Channel beta, 1.25.0-8.1.pre, on macOS 11.1 20C69 darwin-x64, locale en-CA)
    • Flutter version 1.25.0-8.1.pre at /Users/morgan/devtools/flutter
    • Framework revision 8f89f6505b (3 days ago), 2020-12-15 15:07:52 -0800
    • Engine revision 92ae191c17
    • Dart version 2.12.0 (build 2.12.0-133.2.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/morgan/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/morgan/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.1)
    • Xcode at /Applications/Xcode 12.1.app/Contents/Developer
    • Xcode 12.1, Build version 12A7403
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 50.0.1
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Community Edition (version 2020.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 52.1.5
    • Dart plugin version 203.5981.152

[✓] VS Code (version 1.52.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.17.0

[✓] Connected device (2 available)
    • iPhone (mobile) • ce658d8044f32c23abe2d077b3793e8c5a9f8663 • ios            • iOS 14.3
    • Chrome (web)    • chrome                                   • web-javascript • Google Chrome 87.0.4280.88

• No issues found!

Hi @rmtmckenzie
This to be a proposal for intellij
Following the indication of jetbrains' Flutter plugin, the correct way to address the problem is to open an issue in the dedicated repository.
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

I can open an issue there, but I have a pretty strong feeling it's just going to be bounced back here. The flutter tool used to report both Chrome (web) and Server (web) devices but now only reports Chrome (web).
> flutter devices

2 connected devices:

iPhone (mobile) • ce658.................................. • ios            • iOS 14.3
Chrome (web)    • chrome                                   • web-javascript • Google Chrome 87.0.4280.88

I'm also seeing this.  Specifically the Get Started instructions for Flutter are no longer correct.  Following these instructions, I only see the Chrome(web) device.  The web server does not exist.

@rmtmckenzie  @tayo
Interesting, this is by design. Implemented in https://github.com/flutter/flutter/pull/71491
It should work fine with the command and you can still make a proposal for the Flutter plugin to still give option if they agree.
Since this is by design and verified by PR, no issues here
Thank you


Varying Title level leads to IndexError in __add_new_item_table_of_content

There are various issues with using title levels in a non-standard order which seems to trigger an IndexError.
To Reproduce
Steps to reproduce the behavior:
from mdutils.mdutils import MdUtils
md.new_header(level=3, title=infile)
md = MdUtils(file_name='test.md',title='test')
md.new_header(level=3, title='Level 3 header')

python3.7 mdutilstest.py

Traceback (most recent call last):
  File "faraday_markdown_parser.py", line 19, in <module>
    md.new_header(level=3, title=host_title)
  File "/usr/local/lib/python3.7/dist-packages/mdutils/mdutils.py", line 113, in new_header
    self.__add_new_item_table_of_content(level, title)
  File "/usr/local/lib/python3.7/dist-packages/mdutils/mdutils.py", line 130, in __add_new_item_table_of_content
    curr = curr[-1]
IndexError: list index out of range

Expected behavior
It should be possible to have title levels in arbitrary order/
Desktop (please complete the following information):

OS: Ubuntu
Version 20.04 LTS

Maybe you should add another example because you're using md instance before creating it. So your code will always crash 😅.


feat: display linked apps/dbs

@pradel this is also good to go.
I think it's better to do unlink task in separate PR as it will probably be quite a big one.
With the file changes from here, we can now see linked apps/dbs and in dropdown we only see those which are not connected to app or db.
Couple of screenshots below :

@pradel this is good to go now, with all the refactored queries. :)

@pradel fixed both feedbacks.
I didn't know that select === .apps(), but now I know :)


Task - browse nomenclature - explicitly indicate the valid name for invalid names

  when I click on an invalid name in browse nomenclature
      then I find it hard to determine which of the list items is in fact the valid name
          could it be highlighted

Place a check mark beside  with data-history-valid-name='true'


Update Azure Key Vault config provider to support MSI

MSI should allow us to use the ambient identity of the Azure App Service to acquire a token for talking to key vault using the ASAL library.

MSI? @danroth27 Can you elaborate?

Managed Service Identity. Infrastructure for getting an identity for the current app service that you then use to get a token to talk to key vault.

I achieved this by creating another extension method in case anyone else is looking for a solution:
public static IConfigurationBuilder AddAzureKeyVault(
    this IConfigurationBuilder configurationBuilder,
    string vault
    )
{
    var azureServiceTokenProvider = new AzureServiceTokenProvider();
    var keyVaultClient = new KeyVaultClient(new KeyVaultClient.AuthenticationCallback(azureServiceTokenProvider.KeyVaultTokenCallback));
    return configurationBuilder.AddAzureKeyVault(vault, keyVaultClient, new DefaultKeyVaultSecretManager());
}

And then it is possible to call that on startup. I store the key vault URI is app settings, so need the double build to access the key vault uri:
var builder = new ConfigurationBuilder()
    .SetBasePath(env.ContentRootPath)
    .AddJsonFile("appsettings.json", optional: true, reloadOnChange: true)
    .AddEnvironmentVariables();

_configuration = builder.Build();

builder.AddAzureKeyVault(_configuration["KeyVaultUri"]);
_configuration = builder.Build();

Is there an update on this request - the MSI feature is a huge advantage over creating Service Principals by hand and the AzureServiceTokenProvider understands the context the app is running in so no need to supply and appId and appSecret
@starcoda I think I see what you are doing - I assume the key valut uri to the secrets are stored in appsettings.json
Thanks in advance

You can use the key vault config provider with MSI today using the AzureServiceTokenProvider.
var azureServiceTokenProvider = new AzureServiceTokenProvider();
var keyVaultClient = new KeyVaultClient(new KeyVaultClient.AuthenticationCallback(azureServiceTokenProvider.KeyVaultTokenCallback));
builder.AddAzureKeyVault(keyVaultEndpoint, keyVaultClient, new DefaultKeyVaultSecretManager());

Given how simple this code is I'm inclined to say doing further integration isn't worth it, unless we hear otherwise. Closing.

That works - ty

We've discussed this some more and decided to make this a one-liner.
@glennc @pakrym

cc @muratg
We'll try to get this in 2.1.0

@muratg is this still planned for 2.1 if so can you assign this bug to someone?

@natemcmaster will likely take this (if we end up doing it.)
cc @davidfowl

Done https://github.com/aspnet/Configuration/pull/761


Update typing, utils, validating to 0.1.98

Updates

es.weso:typing
es.weso:utils
es.weso:validating

from 0.1.94 to 0.1.98.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "es.weso" } ]

labels: library-update, semver-patch

Superseded by #145.


Design App

Create some prototypes for the app (sketch/figma)

https://app.zenhub.com/files/457572675/b2e64603-ef2b-4222-8f95-f4c515a08e61/download


option for additional nvim cmp sources

Hi there,
First of all, id like to thank you for creating this plugin. I use it all the time and its wonderful, please keep up the good work!
This PR adds an extra configuration parameter so that the nvim user can define extra cmp sources to be used in the sidebar / selection buffers.
Selfishly this is helpful for another plugin that im working on but i think other users will find utility in the ability to tailor exactly which cmp sources contribute suggestions via cmp type-ahead. IE it may be helpful to have path suggestions to auto complete file names etc.
Let me know what you think,
~Nick

@aarnphm  would you be willing to allow me to add autocmds that get fired after InsertEnter, so that the user can make their own adjustments to the buffer without the sources being controlled by avante.nvim?

Can you give an example where additional_cmp_source would be helpful here? buffer only works within input buffer,meaning it don't have context from other buffer source (correct me if I'm wrong)
lsp also doesn't work afaict, given that lsp handler have to attach to the floating buffer (which doesn't contain any context for said code)

Absolutely!
the main reason i suggested this change is because i have been working on authoring a plugin: https://github.com/napisani/context-nvim
this plugin allows neovim users to manage contextual code and it provides a nvim-cmp source to retrieving the formatted contexts in any buffer.
for example you can add 3 files to your manual context, then you can start typing @manual_context in any buffer and it will allow you to reference the context.
i would love to be able to use this plugin with Avante to give users the ability to tailor their context selections to the areas of the code that they know are relevant to their prompt, similar to the cursor experience.
wdyt?

cool concept, but I felt like this use case should be covered with @codebase?
seems like similar to manual adding context #604
also that plugin are unrelated to the cmp change. nvim-cmp only applies in input buffer, which I don't really see a point of dumping the whole context here
probably should do it through repomap or proper workspace context. :)


Search box - Default Text

Is there a way , I can specify a default text in the search box like a prompt - 'Enter entity to search for' ?

@susmita-vps I wonder if I understood correctly, you are requesting to customize the search TextField placeholder, right?

That was also my interpretation @alielkhateeb.


pkg, supernode: cleanup code based on static check warning

Signed-off-by: hwdef<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
cleanup code based on static check warning
Ⅱ. Does this pull request fix one issue?

NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #969 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #969      +/-   ##
==========================================
- Coverage   46.48%   46.48%   -0.01%
==========================================
  Files         116      116
  Lines        6908     6906       -2
==========================================
- Hits         3211     3210       -1
+ Misses       3440     3438       -2
- Partials      257      258       +1

Impacted Files
Coverage Δ

supernode/daemon/mgr/cdn/cdn_gc.go
0% <0%> (ø)
:arrow_up:

supernode/daemon/mgr/cdn/reporter.go
8.64% <0%> (ø)
:arrow_up:

supernode/daemon/mgr/cdn/manager.go
20% <0%> (ø)
:arrow_up:

supernode/daemon/mgr/scheduler/manager.go
21.91% <0%> (-0.69%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc8da9...314b336. Read the comment docs.

LGTM

@hwdef  Where do you find the static check warning? Can you add this feature into our ci?

@yeya24
I use staticcheck.
And I found @SataQiu already added this feature into ci. #809


:gift: Easier to debug the failures, especially for in-cluster sender

Changes

:gift: Easier to debug the failures, especially for in-cluster sender

/kind enhancement
Fixes #129
Release Note
The failures are easier to debug, as in-cluster jobs and their pods are dumped in log files, and users are directed to them.

/test all

/test all

Nice PR, great work!
I do not have much time to review it thoroughly, but I am happy to ack it. @cardil, is there anything you want to add before merging?

/approve
/lgtm

BTW. I think we can adopt very similar error processing across all of kn and fun. WDYT?

That sounds like a good idea. Maybe start with talking to the func team, as this has more interactive elements already anyway. Also, we need to be sure, that the spinner is only active if there is a tty. Not sure if the PR deals already with that, that when no tty is available (i.e. used in a pipe or a redirection), then no control characters or colors should be printed.

@rhuss: we need to be sure, that the spinner is only active if there is a tty. Not sure if the PR deals already with that, that when no tty is available (i.e. used in a pipe or a redirection), then no control characters or colors should be printed.

That's already addressed in knative.dev/client/pkg library.


Use the b flag in fopen to write/read BinaryMemory strings

As per title.
A very useful feature would be to force usage of BinaryMemory strings instead of UTF-16 strings in the entire JPHP environment (with a flag).

The binary memory is always used for this. The f... functions implemented via the Stream classes which use for read and write operation binary memory. So there is no difference between binary data and text.

Data conversion between BinaryMemory and StringMemory occurs automatically if necessary.

If a function works with binary data, it must use the Memory.getBinaryBytes(env) method.


Bug: Navigating using arrows in Columns Layout break tab name

Description
Sometimes, while navigating between columns (using arrows), it happens that the tab name keeps changing.
I think this is caused by the focus bouncing between the last two blades.
I post here a video to show what happens.
Steps To Reproduce

Open a folder and set Layout to Columns
Navigate using arrows (Up/Down and Right/Left) for a while
See that tab name keeps on changing

Steps to fix

The focus should not bounce between the last two blades

Files Version
Version: <IP_ADDRESS> OS Version: 10.0.22621.755
Windows Version
Windows 11 Home Version 22H2 22621.755
Relevant Assets/Logs
https://user-images.githubusercontent.com/102259289/201476781-9387d55b-9ac8-4783-9d05-fb162fed2c48.mp4

This is not a bug anymore since the tab name shows only the name of the first column. I'm not sure this is the expected behaviour

Is this still an issue in the preview version? https://files.community/download/preview

Yes it is. Actually, the issue is that the tab name shows the name of the first column
For example if I open C:/Users tab name will be C: instead of Users

I can reproduce this issue as well

I can reproduce this issue as well

It seems to work on my end, both in preview and dev (last opened column path is displayed in the tab)

@yaira2 it's working on my side, can you confirm?


tronpy.exceptions.AddressNotFound: account not found on-chain (mainnet)

Hello,
Thank you very much for this great work creating this library!
I created a wallet using client.generate_address() and then sent some USDT to the resulting address ('base58check_address': 'TN7W2KXdpDiPj4STtPBrk8QAZuUCgqzuax'). USDTs are still there as the only transaction it has ever had.
However, after running print(client.get_account('TN7W2KXdpDiPj4STtPBrk8QAZuUCgqzuax')) I'm getting the tronpy.exceptions.AddressNotFound: account not found on-chain exception thrown.
After reading some documentation (Account Activation)... How do I activate this address using this library? If you could, please provide some steps (I'm very new to programmatically managing a wallet).
I must be missing something very obvious. 😓
Thanks in advance,

Hi! Just sending tokens to an address won't activate it. You would need to send TRX to it (1 TRX activation fee) for it to become active
That's because you could create your own spam tokens and activate addresses this way, that's why mainnet currency is required for activation


Include lib32-glibc-linux4 in known issues for WSL1

IMPORTANT
Please read README and Docs before creating the issue.
Please fill out the below information:
Describe the issue
I haven't used ArchWSL in a couple months, but I notice I was having upgrade issues complaining about lib32-glibc when upgrading so I had to use lib32-glibc-linux4 from the archlinuxcn repo.
This was on a new install.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Enviroment:

Windows build number: [e.g. 10.0.17134.228] (Type ver at a Command Prompt)
Security Software: [e.g. ESET Internet Security]
WSL version 1/2: [e.g. WSL1]
ArchWSL version [e.g. <IP_ADDRESS>]
ArchWSL Installer type zip/appx/other clean/update [e.g. appx update]
Launcher version [e.g. 19030700] (Type Arch.exe version at a Command Prompt)

Additional context
Add any other context about the problem here.

Now i can't even find lib32-glibc-linux4 and glibc-linux4 in repo

https://github.com/archlinuxcn/repo/issues/3237
https://github.com/wsldl-pg/ArchW-docs/issues/45
Now even upstream AUR package is outdated...

As the maintainer of glibc-linux4 said in [https://aur.archlinux.org/packages/glibc-linux4#comment-930385]

The normal glibc v2.38 works perfectly fine with WSL 1, which is on Linux v4.4.0. There is no need to update & use glibc-linux4 at the moment AFAIK.
If you do need glibc-linux4 v2.38 as normal glibc will not work for you, please be sure to provide the details when you flag this package.

You'd better install official package to replace glibc-linux4 and lib32-glibc-linux4
pacman -S glibc lib32-glibc


Enhancement: Include listing of test case failures within the test target when it is available

We currently track which test targets fail and keep a snippet of console output per target in the TRSS database.
For certain groups of tests like openjdk and jck we can summarize the list of testcase failures in the TAP file (and/or to console).
Currently, we have to inspect the console output to see if a particular target is failing with the same underlying set of test cases or not from run to run and across platforms.
We should consider pushing the summarized list of testcase failures to console (at the same time we are writing the list to the TAP file, see these related PRs in TKG).  Then grabbing that console output and storing it in the TRSS database for querying and comparison between results in the GUI.
This may help us hone in on when root causes for certain failures are introduced.

We should consider pushing the summarized list of testcase failures to console

This should be done in TKG. https://github.com/adoptium/TKG/issues/536


Support for disabling Anti-Aliasing & Sharpening

This can already be accomplished for some games via hex edits, so it shouldn't be too hard to add this as a toggle for all games.

@praydog
Could you please take a look?
RE8 has a hex edit to disable AA & Sharpening
RE7 has a hex edit to disable AA (but not sharpening)
RE3 has NO hex edit to disable AA or sharpening
RE2 has NO hex edit to disable AA (but for sharpening)
It would be really great to have a toggle for ALL RE engine games. Thanks.

Please, consider this, is incredibly oversharpened

Please, consider this, is incredibly oversharpened

@NineKain
In the meantime, you could try shadertoggler for ReShade.
I didn't test it yet, but it should be able to disable aa & sharpening.


apktool will fail and can be bypassed with weird utf8 string; Suggestion and solution included

Information

Apktool Version (2.4) -
Operating System (Linux and Windows) -
APK From? (Playstore,) -

apktool will fail and can be bypassed with weird utf8 string;
Suggestion/idea
hey coder, if I were as smart and as capable as you, I would first detect if there's unicode in the name,
public int canDisplayUpTo(String str)
then I replace the unicode in the name with a marker like /com/android/%mark1%/etc
Then I put a log file (ex: rename.log) in same folder, inside the log file, if 0 then no unicode, if 1 then u convert them to unicode. You can use json library to store the name.
if no unicode text:
0

proceed to recompile without the need of renaming after reading the rename.log value as 0, else
1
com{
 android {
                    %mark1% = \uFFFD\uFFFD\uFFFD\uFFFD\uFFFD\uFFFD9
           }
}

then you rename it back (/com/android/%mark1%/etc), covert unicode escape back then only compile.
Stacktrace/Logcat
command substitution: line 3: `B�F	1~(X�����K�W�%�h4���2�[Ȳ���&Ϲ������{O�����^��d�2�2��%<�A�4�8��
                                                                  f���lF�4�9w�QqK*4�����pOE
                �d�\ۯ48�jz��82���t������
                                         xMorx��okm/����'�u���a9ɦ��ݾ�!b^��e�~%�j�c�����m�d��^�a�rį�d�nǰ��g����1�al�S��.�8D��W+{�ٰ�����x��Ţ�fe�U�Q!�ya�7��̕m
      cBHI�v*8y��n�G���Ѣ;��
                              ;0��
                                   ��_Z�������<�A�lzduf��K1�@�k䭐eC@��
                                                                            �W�8<"�^���y,����J\L}��DƏ\�?��:d�9���s�
                                         9��Rjm���c�%*Gґ'
/home/NNN/Desktop/apktool_2.4.0.jar: line 3: $'\360\357\f~\317\340\367\r\376\300\340\017\r\376\330': command not found
Desktop/apktool_2.4.0.jar: line 3: !brut/apktool/Main.class�Smo�P~JK[���ӱu�k�С: No such file or directory

Steps to Reproduce

`Yes this problem exist in linux environment when decompiling, no joke.
https://wap.pp.cn/app/dl/fs08/2019/11/07/11/106_039ea82f26db61aa480f9000620c78f1.apk

Questions to ask before submission

Have you tried apktool d, apktool b without changing anything?
yes
If you are trying to install a modified apk, did you resign it?

not applicable

Are you using the latest apktool version?
yes

update apk sample http://download.zhushou.sogou.com/open/files/year_2019/day_20190329/3945a0bbcfad7bb39eae1871e23d2dd6.apk?dn=街机达人捕鱼<IP_ADDRESS>.apk

I think you would gain more attention if the original post would not be that confusing.
I would first describe what the actual problem is, not starting with somethings that reads like a new feature description. Describe it precise - what commands trigger the problem and describe what problem occurs.

I think you would gain more attention if the original post would not be that confusing.
I would first describe what the actual problem is, not starting with something that reads like a new feature description. Describe it precise - what commands trigger the problem and describe what problem occurs.

I thought the title already describe it? "apktool will fail and can be bypassed with weird utf8 string;"
If the apk string contain chinese character for example it will failed to recompile. Some may even failed to decompile in the beginning.
The basic command to decompile trigger it:
apktool input.apk
The problem it it can't recompile. It may even failed to decompile if the unicode string is long.
Do tell me if you need further clarification

Well, first the title is IMHO the place where you can summarize something. Placing important details in the title only is a bad idea. Second you use the term "bypassed" but forgot to mention what can be bypassed and where.
Third a good bug report should include the name of one of the classes that are causing this problem. Therefore it would be good if you could exactly name the package and class names (or at least one) causing this issue. That makes it easier to identify the root cause.

Well, first the title is IMHO the place where you can summarize something. Placing important details in the title only is a bad idea. Second you use the term "bypassed" but forgot to mention what can be bypassed and where.
Third a good bug report should include the name of one of the classes that are causing this problem. Therefore it would be good if you could exactly name the package and class names (or at least one) causing this issue. That makes it easier to identify the root cause.

bypassed as fail to even decompile as a decompiler function of this tool.
That is the error shown in console, it can't even display the class name so I can't show any.
I already provided the sample apk, I don't know if how is that still unclear.

I decompiled the linked APK yesterday on a Ubuntu VM and did not encounter problems on decompiling.
Recompiling failed not because of file-names but a image-resource that should be of PNG file format but contained some other data.
Therefore I would assume that the main problem is not apktool but your Linux installation. Make sure your system is capable of handling UTF-8 file name (selecting an UTF-8 locale?) and I would suggest using a recent Java version (v11 is IMHO the recommended version at the moment).

Recompiling failed not because of file-names but a image-resource that should be of PNG file format but contained some other data.

"Recompiling failed not because of file-names but a image-resource that should be of PNG file format but contained some other data." so what did you do about it? also do try if it can be installed after compiling

so what did you do about it?

Nothing because this is not the error you have described. If I disable resource decoding (apktool_2.4.0.jar d -r) upon decompiling the recompiling works without any problem. If the APK works or not is unknown, I don't install APKs I don't know on any of my devices.
As I wrote from my perspective your problem is not apktool, but your operating system. I recommend to close this issue.

so what did you do about it?

Nothing because this is not the error you have described. If I disable resource decoding (apktool_2.4.0.jar d -r) upon decompiling the recompiling works without any problem. If the APK works or not is unknown, I don't install APKs I don't know on any of my devices.
As I wrote from my perspective your problem is not apktool, but your operating system. I recommend to close this issue.

then try this another chinese apk: https://wap.pp.cn/app/dl/fs08/2019/11/07/11/106_039ea82f26db61aa480f9000620c78f1.apk

then try this another chinese apk, this one will fail in decompilation:

I am sorry, but I won't test this and any further APK files you post unless you have tested it yourself for verifying that it actually triggers a bug in apktool. In such a case post the APK files and include a detailed bug report.

I can't test it yet, I am not in my hometown, I'll be back on 21st
But I can tell you I am 99% positive this one you will fail to decompile for you because for mine I tried v8.1 of the apk it did failed on both windows and linux

Gosh we really need a Java coder to update this apktool to support unicode and rebrand as BetterApkTool

https://stackoverflow.com/questions/58666141/is-it-me-or-apktool-keep-failing-to-recompile-chinese-apk
:) - You are welcome to work on the open source project :)

Gosh we really need a Java coder to update this apktool to support unicode and rebrand as BetterApkTool

https://stackoverflow.com/questions/58666141/is-it-me-or-apktool-keep-failing-to-recompile-chinese-apk
:) - You are welcome to work on the open source project :)

I wish I can help, I'm not familiar with java unfortunately, I see, she took my post.  This one is more problematic: https://wap.pp.cn/app/dl/fs08/2019/11/07/11/106_039ea82f26db61aa480f9000620c78f1.apk

Not sure what is being reported here.
Application seems to decode fine.
➜  2195 apktool d "街机达人捕鱼<IP_ADDRESS>.apk"
I: Using Apktool 2.4.2-f545c2-SNAPSHOT on 街机达人捕鱼<IP_ADDRESS>.apk
I: Loading resource table...
I: Decoding AndroidManifest.xml with resources...
I: Loading resource table from file: /home/ibotpeaches/.local/share/apktool/framework/1.apk
I: Regular manifest package...
I: Decoding file-resources...
I: Decoding values */* XMLs...
I: Baksmaling classes.dex...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...
➜  2195

Feel free to open a report if you know what you expect vs see. I can't follow this existing thread. Closing.


Stack overflow of widgets breaks Flutter with no error message

Just run this:
import 'package:flutter/material.dart';
void main() => runApp(Demo());

class Demo extends StatefulWidget {
  final Widget child;
  Demo({this.child});

  _DemoState createState() => _DemoState();
}

class _DemoState extends State<Demo> {
  Widget build(BuildContext context) => widget;
}

Also, by Remi Rousselet:
void main() => runApp(
  Builder(builder: (context) => context.widget)

);

Can't at least the trivial case be fixed by checking if the widget returned by the build method is identical to the widget itself, and issuing a proper error message?

It's definitely easy enough to catch the trivial case and throw an error. Will do that.
void main() { runApp(Builder(builder: (context) => context.widget)); } // error

Unfortunately detecting when context.widget appears elsewhere in the built tree, would require walking the entire built widget tree. Which might cause a noticeable drag on debug-mode.
void main() { runApp(Builder(builder: (context) => Container(child: context.widget))); }

Even if we did that, it wouldn't really address the general problem, which is detecting loops in the build tree.
Widget foo = Container(child: Builder(builder: (BuildContext context) => bar));
Widget bar = Container(child: Builder(builder: (BuildContext context) => foo));

void main() { runApp(Builder(builder: (BuildContext context) => foo)); }

To do that might require a recursive analysis of the entire tree as it was being constructed.
Since this problem doesn't seem to come up very often, it's probably best to just check the trivial case.

flutter_tester will segfault when running a test based on this app:
void main() {
  testWidgets('test', (WidgetTester tester) async {
    await tester.pumpWidget(
      Builder(builder: (context) => context.widget)
    );
  });
}

This seems to be enum initialization happening without enough stack left. The VM assumes enum initialization can't fail, and lets an error escape to places that should only see instances. An even simpler program with the same crash:
enum Fruit {
  apple, banana,
}

getFruit() => Fruit.apple;

recurse() {
  try {
    recurse();
  } catch (e, st) {
    print("$e ${getFruit()}");
  }
}

main() {
  recurse();
}


Wrong store IDs for old Ubuntu releases

Windows Version
Microsoft Windows [Versión 10.0.22631.1830]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Ubuntu 18.04, Ubuntu 20.04
Other Software
No response
Repro Steps
Store App IDs for Ubuntu 18.04 and 20.04 are outdated:

Release
Currently
Should be

Ubuntu 18.04
9N9TNGVNDL3Q
9PNKSF5ZN4SW

Ubuntu 20.04
9N6SVWS3RX71
9MTTCL66CPXJ

They point to the old Ubuntu XX.XX on Windows. The "PackageFamilyName" confirms this. They need be changed as well. The *PackageUrl properties are outdated as well.
Expected Behavior
Install the right AppxPackage
Actual Behavior
Installs the old AppxPackage
Diagnostic Logs
No response

Fixed here:
https://github.com/microsoft/WSL/pull/10176

Closing since the fix has been merged.


Basic Timeline

Hi All,
I wanted to propose a timeline for generating ideas.

March 16 - All proposed rules submitted and discussed
March 23 - Final 10 rules decided, authors assigned to topics
April 13 - Rough draft of rules submitted to repo

I'm just sort of putting this out there for us all, but personally I find it useful to have a time line (to break) to help me prioritize all the other things I'm working on.  Please amend this if you think it's unreasonable I just put this together as a starting point.

+1

Agreed. I created milestones with dates. We use them in the lab not to miss deadlines, it's pretty efficient.

@emhart Can you define "submitted and discussed"? Have we completed this? Now we have three days for the final rules?

@dlebauer I was hoping that we would have completed our discussion of the rules and begun to finalize them.  I'm going to send out on more request for rules and then try and synthesize them.

:+1:


Generate Random name

Hello, I copy a lot of characters names from characters sheets. Often I miss click and select button "Name" to generate random name in character sheet. There is no option to revert it back? Can you add option to ctr+z when generated name replace original name or maybe add asking to confirm.

💡(red border cursors on image) Now when you hover mouse (red borders) and after LMB you generate name
💡(green border cursor on image) If it worked like you click on "Name" button, not also space near, maybe that would be the solution


flakyness

I really love your OSS CAD tool builds and the Chisel community has come to rely on them. Unfortunately the github action to set them up has been very flaky, especially on MacOS, but also on Linux lately. We ended up replacing it with our own action: https://github.com/chipsalliance/chisel3/pull/2901
Just wanted to let you know in case this is useful for improving your Github action. Thank you so much for providing the binaries!

Thanks you for feedback, and sorry to hear about issues. If you could provide more info about failure you got it would be great, so I could work on improving this.

This is the text log:
2023-01-09T16:20:41.5831835Z ##[group]Run YosysHQ/setup-oss-cad-suite@v1
2023-01-09T16:20:41.5832062Z with:
2023-01-09T16:20:41.5832253Z   osscadsuite-version: 2022-08-18
2023-01-09T16:20:41.5832482Z   python-override: false
2023-01-09T16:20:41.5832679Z ##[endgroup]
2023-01-09T16:20:41.6364730Z ##[group]Installing OSS CAD Suite
2023-01-09T16:20:41.6383960Z [command]/home/runner/work/_actions/YosysHQ/setup-oss-cad-suite/v1/dist/install-oss-cad-suite linux-x64 2022-08-18
2023-01-09T16:20:41.6445937Z ~/work/_temp/.setup-oss-cad-suite ~/work/_temp
2023-01-09T16:20:41.6911942Z ##[error]The process '/home/runner/work/_actions/YosysHQ/setup-oss-cad-suite/v1/dist/install-oss-cad-suite' failed with exit code 1
2023-01-09T16:20:41.6969989Z Post job cleanup.

From what I can gather this seems to be that the github API returns something other than the expected result causing the build variable to be unset, or set to an invalid result causing the wget to fail.
A potential fix would be to check if build is valid and if not, wait a while and try again. Maybe using something like curl -Is $build | head -1 | cut -c 8- then to check if the HTTP response code is good or not and if it's not delay abit then try again.
Another fix would be to do-away with the shell component of the action all together and to the API request and download in JavaScript, then to do something like ensuring the request succeeded or not.
Yet another, but less ideal option, would be to have a fixed known "good" URL to grab from in case the build fails, seeing as the release names and targets are well known, it might be possible to compute the URL for the release and just stagger it by a day in case the latest fails.
In either case this wouldn't solve the problem is the API request is fine but the actual download of the rease is causing problems. It's hard to say without any debug introspection into the action as it runs fine 100% of the time locally for me, so I suspect it's a GitHub CI issue itself with rate limiting

@ekiwi sorry for the direct ping, but the updated version of the action should now be much more stable, especially as you can now use the ${{ secrets.GITHUB_TOKEN }} to allow the action to use the authenticated API, which should prevent the random failures due to it hitting the public API rate limit on the CI worker, which turned out to be the main cause.

@mmicko this Issue should likely be closed at this point.

Agree, done and thanks for your work @lethalbit


freebsd i686 add ucontext/mcontext

close #3196.

@bors r+

:pushpin: Commit e6011f556da8d6ae3e17e2d3e33615bdc303dc09 has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit e6011f556da8d6ae3e17e2d3e33615bdc303dc09 with merge 6329a6aeef0667dcf06f4e5e5c8c8850dd8e7871...

:broken_heart: Test failed - checks-actions

@bors r+

:pushpin: Commit 7e388595f2f3df89266e7b4ddaaaa9771285a146 has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit 7e388595f2f3df89266e7b4ddaaaa9771285a146 with merge a01dd8e9ac9629832b63a7caf723cde711795c1a...

:broken_heart: Test failed - checks-actions

@bors r+

:pushpin: Commit b811b70f6676a24c16a786a3549eb6b35071c13c has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit b811b70f6676a24c16a786a3549eb6b35071c13c with merge 9cc77816fae6b66172798df7bc975e5faae754f2...


CIF-2211 - Update core WCM dependency to latest for CIF components

Updated version number to 2.17.2 and fixed test failures.
Related Issue
CIF-2211
Motivation and Context
JUnit.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[X] All unit tests pass on CircleCi.
[X] I ran all tests locally and they pass.

I've reverted the AEM image to 6.5.8 here and in the Venia PR (https://github.com/adobe/aem-cif-guides-venia/pull/165).
Both are passing.


Foxx Manager CLI commands should fail if the arguments are malformed

Some commands take JSON arguments, some take keyword arguments. It's easy to mix them up and succeed because the invalid arguments are ignored.
We might also want to consider switching to POSIX-style arguments instead (rewrite everything?).
Via #1427.

@pluma has this been solved?

@fceller Nope.

fixed by 7780b48539718a59bcec00a82788dd9712dfe853

This is done in i.e. scripts/unittest.js (which was also working with a json parameter before)
   if (argv.length >= 3) {
     try {
       if (argv[2].slice(0,1) === '{') {
         options = JSON.parse(argv[2]);
       }
       else {
         options = internal.parseArgv(argv, 2);
       }
     }
     catch (x) {
       print("failed to parse the json options: " + x.message);
       return -1;
     }
   }
   options.jsonReply = true;

which maintains backwards compatibility with the json format on parameter#2

Possibly related: https://github.com/arangodb/arangodb/issues/1625

Closing in favour of https://github.com/arangodb/foxx-cli


Log installations

How to categorize this PR?

/area deployers
/kind enhancement
/priority 3
What this PR does / why we need it:
Implement new logging for installations controller
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

NONE

/test


firewall4: Enable the HW offloading for Firewall4

Fixes the throughput issue while traffic run from LAN to WAN ports on AP yuncore ax820 model using wired clients.
Test scenario:
WiredClient[<IP_ADDRESS>] <======> (LAN)APX820(WAN) <=====> WiredClient[<IP_ADDRESS>]

Throughput reached ~938 Mbits/sec(UL or DL) between LAN/WAN ethernet ports using iperf3.

this should be rendered out via the data-model

this should be rendered out via the data-model

I am not able to find any data-model  in wlan-ucentral-schema which actually uses or override cases for firewall defaults section.
So the firewall defaults section is always intact.

provided alternative fix to benison


read rootcert from configured ns to connect to citadel

fix issue raised in https://discuss.istio.io/t/nodeagent-crashing/2827

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?
Courtesy of your friendly test nag.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: quanjielin
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: howardjohn
If they are not already assigned, you can assign the PR to them by writing /assign @howardjohn in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
security/OWNERS [quanjielin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@quanjielin: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
7d4e4746879ab1ef7b16eee22b5b778fd2286412
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
7d4e4746879ab1ef7b16eee22b5b778fd2286412
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e_pilotv2_auth_sds.sh
7d4e4746879ab1ef7b16eee22b5b778fd2286412
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
7d4e4746879ab1ef7b16eee22b5b778fd2286412
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e_pilotv2_auth_sds.sh
7d4e4746879ab1ef7b16eee22b5b778fd2286412
link
/test istio_auth_sds_e2e-master

prow/integ-mixer-k8s-presubmit-tests.sh
7d4e4746879ab1ef7b16eee22b5b778fd2286412
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio_auth_sds_e2e-master
/test istio-pilot-e2e-envoyv2-v1alpha3-master

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
7d4e4746879ab1ef7b16eee22b5b778fd2286412
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e_pilotv2_auth_sds.sh
7d4e4746879ab1ef7b16eee22b5b778fd2286412
link
/test istio_auth_sds_e2e-master

prow/integ-mixer-k8s-presubmit-tests.sh
7d4e4746879ab1ef7b16eee22b5b778fd2286412
link
/test integ-mixer-k8s-presubmit-tests-master

prow/release-test.sh
7d4e4746879ab1ef7b16eee22b5b778fd2286412
link
/test release-test-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-test-master

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
7d4e4746879ab1ef7b16eee22b5b778fd2286412
link
/test integ-mixer-k8s-presubmit-tests-master

prow/codecov.sh
b3567510f95a13993bd1e68b6c5ee7315cdf0fae
link
/test istio-codecov-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-codecov-master

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/codecov.sh
b3567510f95a13993bd1e68b6c5ee7315cdf0fae
link
/test istio-codecov-master

prow/integ-mixer-k8s-presubmit-tests.sh
b3567510f95a13993bd1e68b6c5ee7315cdf0fae
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/codecov.sh
b3567510f95a13993bd1e68b6c5ee7315cdf0fae
link
/test istio-codecov-master

prow/integ-mixer-k8s-presubmit-tests.sh
b3567510f95a13993bd1e68b6c5ee7315cdf0fae
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
b3567510f95a13993bd1e68b6c5ee7315cdf0fae
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/codecov.sh
b3567510f95a13993bd1e68b6c5ee7315cdf0fae
link
/test istio-codecov-master

prow/integ-mixer-k8s-presubmit-tests.sh
b3567510f95a13993bd1e68b6c5ee7315cdf0fae
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
b3567510f95a13993bd1e68b6c5ee7315cdf0fae
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
b3567510f95a13993bd1e68b6c5ee7315cdf0fae
link
/test integ-galley-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
b3567510f95a13993bd1e68b6c5ee7315cdf0fae
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
b3567510f95a13993bd1e68b6c5ee7315cdf0fae
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
b3567510f95a13993bd1e68b6c5ee7315cdf0fae
link
/test integ-galley-k8s-presubmit-tests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b3567510f95a13993bd1e68b6c5ee7315cdf0fae
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-galley-k8s-presubmit-tests-master

/test istio-pilot-e2e-envoyv2-v1alpha3-master

/test istio-pilot-e2e-envoyv2-v1alpha3-master

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
b3567510f95a13993bd1e68b6c5ee7315cdf0fae
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
b3567510f95a13993bd1e68b6c5ee7315cdf0fae
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b3567510f95a13993bd1e68b6c5ee7315cdf0fae
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
b3567510f95a13993bd1e68b6c5ee7315cdf0fae
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-bookInfoTests-envoyv2-v1alpha3-master

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
b3567510f95a13993bd1e68b6c5ee7315cdf0fae
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
b3567510f95a13993bd1e68b6c5ee7315cdf0fae
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-new-installer-k8s-presubmit-tests.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
b3567510f95a13993bd1e68b6c5ee7315cdf0fae
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-new-installer-k8s-presubmit-tests.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test integ-new-install-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-new-installer-k8s-presubmit-tests.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test integ-new-install-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, quanjielin
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [howardjohn]
security/OWNERS [howardjohn,quanjielin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-new-installer-k8s-presubmit-tests.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test integ-new-install-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test integ-security-k8s-presubmit-tests-master

prow/e2e-simpleTests.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-new-installer-k8s-presubmit-tests.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test integ-new-install-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test integ-security-k8s-presubmit-tests-master

prow/e2e-simpleTests.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test e2e-simpleTests-master

prow/codecov.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test istio-codecov-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-codecov-master

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-new-installer-k8s-presubmit-tests.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test integ-new-install-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test integ-security-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-v1alpha3.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-bookInfoTests-envoyv2-v1alpha3-master

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-new-installer-k8s-presubmit-tests.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test integ-new-install-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test integ-security-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-v1alpha3.sh
c38aa41eb63aea3a8c950d7ed9771d28916c6034
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-bookInfoTests-envoyv2-v1alpha3-master

cherrypick this PR to 1.2, per request from https://github.com/istio/istio/issues/15929


Compare IAM and CDL users

Our IAM profiles identifies faculty and staff.  In addition to that we have a list of title groups for users. CDL, by contrast uses this list of title code groups to identify who is and isn't included the the OA policy guidelines.  We want to compare the differences between these two methods, and come to aggreement on who gets added to the system.

@Vensberg for the purposes of V2 we are using the list of senate faculty as described be CDL group=438 correct? This is for a later date?

@qjhart created UC Davis (aggie-experts) Group ID: 1547 to include senate non-emeriti faculty for version 2.0 roll-out.


Using Interac Moneris Online Payment gateway

https://esplusqa.moneris.com/connect/en/download/feb05/HOSTED/HPP_Test_US.html, here when you click on submit, you ll visit moneris online page and do online payment.
HOW TO ACHIEVE THIS ONE USING RAILS. If not moneris then which API support similar feature.( using CAD currency)
I know its not relevant to you, but somehow  I will get help from your end.
Thanks in Advance.
Pradeep CS

Issues isn't the right place to ask questions about ActiveMerchant. Try the google group http://groups.google.com/group/activemerchant


chore: Add duration

value to error

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.786%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5302

Relevant Lines:
6996

💛  - Coveralls


Cats effects 3

Benchmarks coming ...

Monumental 🙇♂

Amazing! Are there any plans to cut out a release for this one? Thanks!

@andreamarcolin, we have been distracted by other things and the release remained in the wish list. I'll take care of it. Thanks for the message.


The scraper does not show that Tactical Purchaser with German job was duplicated and posted twice

ENVIRONMENT:
https://admin.peviitor.ro/
Browser: Chrome
Device: Laptop
OS: Windows 10
STEPS TO REPRODUCE:
Enter url in browser
In go to "https://admin.peviitor.ro/" and click to jobs for "Allianz"
Click on "Tactical Purchaser with German" tab on "Catre Job "option
EXPECTED RESULTS:
The page shows the full description of the job
ACTUAL RESULTS:
The page shows the same full description of the previous job announcement
See below the screenshot
Attachment:
Page from Validator for Allianz

Joburile sunt prezente și pe site-ul lor de cariere. Uită-te atent la link ul jobului ca au id uri unice. Nu sunt duplicate.


Crash on Android 6 Api 23

When using the ionic application in Android 6 API 23, cordova-plugin-background-geolocation crash and applicaiton stop, have you a solution for this issue, thanks

Can you send me output from adb logcat?

E/SysUtils: ApplicationContext is null in ApplicationStatus
E/chromium: [ERROR:browser_gpu_channel_host_factory.cc(258)] Failed to init browser shader disk cache.
E/libEGL: validate_display:255 error 3008 (EGL_BAD_DISPLAY)
E/cr.LocationProvider: Caught security exception while registering for location updates from the system. The application does not have sufficient geolocation permissions.
E/cr.LocationProvider: Caught security exception while registering for location updates from the system. The application does not have sufficient geolocation permissions.
E/cr.LocationProvider: Caught security exception while registering for location updates from the system. The application does not have sufficient geolocation permissions.
E/cr.LocationProvider: Caught security exception while registering for location updates from the system. The application does not have sufficient geolocation permissions.
E/cr.LocationProvider: Caught security exception while registering for location updates from the system. The application does not have sufficient geolocation permissions.
E/cr.LocationProvider: Caught security exception while registering for location updates from the system. The application does not have sufficient geolocation permissions.

I think is the new système of permission android 6 http://developer.android.com/about/versions/marshmallow/android-6.0-changes.html

Hi, I've just succefully tested SampleApp on android 6 emulator. Can you try to install SampleApp and check if it is woking?
https://github.com/mauron85/cordova-plugin-background-geolocation/tree/master/example/SampleApp

I have the same error with exemple, application stop after 10 sec !

I have a problem when start the background traking

12-18 16:25:05.676 11238-11296/com.transistorsoft.backgroundgeolocation E/PluginManager: Uncaught exception from plugin
12-18 16:25:05.676 11238-11296/com.transistorsoft.backgroundgeolocation E/PluginManager: java.lang.IllegalArgumentException: Receiver not registered: com.tenforwardconsulting.cordova.bgloc.BackgroundGeolocationPlugin$1@382b7dc
12-18 16:25:05.676 11238-11296/com.transistorsoft.backgroundgeolocation E/PluginManager:     at android.app.LoadedApk.forgetReceiverDispatcher(LoadedApk.java:780)
12-18 16:25:05.676 11238-11296/com.transistorsoft.backgroundgeolocation E/PluginManager:     at android.app.ContextImpl.unregisterReceiver(ContextImpl.java:1195)
12-18 16:25:05.676 11238-11296/com.transistorsoft.backgroundgeolocation E/PluginManager:     at android.content.ContextWrapper.unregisterReceiver(ContextWrapper.java:576)
12-18 16:25:05.676 11238-11296/com.transistorsoft.backgroundgeolocation E/PluginManager:     at com.tenforwardconsulting.cordova.bgloc.BackgroundGeolocationPlugin.execute(BackgroundGeolocationPlugin.java:142)
12-18 16:25:05.676 11238-11296/com.transistorsoft.backgroundgeolocation E/PluginManager:     at org.apache.cordova.CordovaPlugin.execute(CordovaPlugin.java:95)
12-18 16:25:05.676 11238-11296/com.transistorsoft.backgroundgeolocation E/PluginManager:     at org.apache.cordova.PluginManager.exec(PluginManager.java:130)
12-18 16:25:05.676 11238-11296/com.transistorsoft.backgroundgeolocation E/PluginManager:     at org.apache.cordova.CordovaBridge.jsExec(CordovaBridge.java:59)
12-18 16:25:05.676 11238-11296/com.transistorsoft.backgroundgeolocation E/PluginManager:     at org.apache.cordova.engine.SystemExposedJsApi.exec(SystemExposedJsApi.java:41)
12-18 16:25:05.676 11238-11296/com.transistorsoft.backgroundgeolocation E/PluginManager:     at org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method)
12-18 16:25:05.676 11238-11296/com.transistorsoft.backgroundgeolocation E/PluginManager:     at org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:37)
12-18 16:25:05.676 11238-11296/com.transistorsoft.backgroundgeolocation E/PluginManager:     at android.os.Handler.dispatchMessage(Handler.java:102)
12-18 16:25:05.676 11238-11296/com.transistorsoft.backgroundgeolocation E/PluginManager:     at android.os.Looper.loop(Looper.java:148)
12-18 16:25:05.676 11238-11296/com.transistorsoft.backgroundgeolocation E/PluginManager:     at android.os.HandlerThread.run(HandlerThread.java:61)
```
The log cat is different with exemple, the application dont ask to the user to accepte geolocalisation like applications in android M

Oh, You have been hit by new bug, I've unintentionally introduces in version 0.8.2. It has nothing todo with Android 6. I'm about fix it, I'll let you know so you can run SampleApp again.
In mean time, please send me your device manufucaturer, model and android version ...
Also I believe this plugin is not asking for any permissions. Are you sure, you're not using navigator.geolocation.getCurrentPosition, watchPosition ....?

Nexus 5x, Android 6.0.1, i use navigator.geolocation.getCurrentPosition, but when i comment bg.start(), the problème disappear, i use android target 23 because i have plugin require api 23, sorry for my english :)

Version 0.8.3. Can you try SampleApp. Need to remove plugin and readd to get new version.
cordova plugin rm cordova-plugin-mauron85-background-geolocation
cordova plugin add<EMAIL_ADDRESS>

I've have had this fixed since November 29th in my PremiumVersion, building for API 23
See here.  Search "Android Permissions"

fixed in 0.9.4. Reopen if you find any more issues.

It work, thanks ;)


compactblock: store in non-consensus store

We don't ever use the compact block inside the chain state.  Strictly speaking, it's not necessary to store it inside the verifiable part of the chain state, and keeping it outside allows it to be accessed more efficiently when serving clients (it can just be read directly from RocksDB, in a linear order...)
We don't currently verify the CB data with a light client anyways, but even if we wanted to, we probably wouldn't want to verify every single CB's merkle inclusion proof separately. One idea we discussed informally some time ago is to write the hash of the current CB into the state (to allow individual verification) and also to write a hash chain accumulator that hashes in each successive CB, so a client can stream many CBs all at once, hash them together in sequence, and then verify the accumulator hash of all-downloaded-CBs using a Merkle proof.
This commit does none of these options, leaving them for later work, and just makes sure that the CB data is stored in ordinary RocksDB in linear order.

Nope, it'd be good to file them though.


Run tests in parallel

Maybe we can make tests run in parallel again.

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   89.46%   89.46%
=======================================
  Files          10       10
  Lines         940      940
=======================================
  Hits          841      841
  Misses         99       99

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 556c40a...754b19f. Read the comment docs.


Docs: Live Service Templates

(docs): Adding the new Live Service Templates page. Making sure to make the necessary changes to the Platform Console page.
This PR takes care of Issue #524.

@dericksozo - I think we need to move the Live Template page to the Platform Features directory, and update the links to the "Live Template" in the various pages.


Use java8 for osx builds.

Looks like this fixes the osx build. I will submit after appveyor passes (which should not be related)

Codecov Report

Merging #1598 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1598   +/-   ##
=========================================
  Coverage     82.32%   82.32%
  Complexity     1788     1788
=========================================
  Files           262      262
  Lines          8215     8215
  Branches        793      793
=========================================
  Hits           6763     6763
  Misses         1206     1206
  Partials        246      246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b76005...e18071b. Read the comment docs.


Prepare 0.1.2

Codecov Report

Merging #34 (070ae07) into master (337081f) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff            @@
##             master      #34   +/-   ##
=========================================
  Coverage     82.26%   82.26%
  Complexity      206      206
=========================================
  Files            31       31
  Lines           840      840
  Branches         91       91
=========================================
  Hits            691      691
  Misses          118      118
  Partials         31       31

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Not able to install on eclipse 3.4+

An error occurred while collecting items to be installed
session context was:(profile=epp.package.java, phase=org.eclipse.equinox.internal.p2.engine.phases.Collect, operand=, action=).
Unable to read repository at http://beust.com/eclipse/plugins/org.testng.eclipse_<IP_ADDRESS>41201_2240.jar.
Read timed out

Have you tried again to install the TestNG plug-ins? As the mentioned time-out, for the jar, does not appear. I can download the jar.
In case the problem still exsists

Which version and distribution of Eclipse do you use?
What other plug-ins have you installed?

I am able to install it now... wondering, I did not make any changes, anyways closing this issue,
Thanks,
Manish Bansal


Fixed IndexError with empty related names

Hi.
When trying to make migrations for models containing fields with empty "related_name", this line raises an IndexError. This tiny patch should fix it.

Hi alilotfi,
Shouldn't we disallow an empty related_names with a field check instead?

You are right, so could we raise an exception with a suitable message?

First file a new ticket to track this enhancement proposal and have a look at our contributing guidelines.
I think the RelatedField._check_related_name_is_valid() is the method you want to look at. From what I can see changing the early if not related_name conditional return to if related_name is None should do since '' is not a valid Python identifier.

Thanks for guiding me to contributing guidelines.
And you're right about RelatedField._check_related_name_is_valid(), but it seems it does not work!
Will close this and open a ticket.
Thank you so much

Moved this to #5437.


MM-27004: SQLStore versioning and migration

Summary
This PR does a couple of things:

it creates the needed boilerplate for versioning and migration
it adds the first migration, that creates all the tables
it adds the data migration from the old kv store data to the brand new database
it modifies the checklist model to add an ID

This has been manually tested, but not at the extent that it should be. It seems to work, though. I am aiming to get this extensively tested when working on the unit test tickets, so I'm expecting the reviews here to focus on the versioning/migration structure, as well as an early look to the 0.1.0 migration itself.
The data migration is isolated in data_migration.go, so we will be able to easily remove when everyone is on 0.1.0 :)
I've set the base branch to the open PR #252. I'll refactor when that one's merged!
Ticket Link
https://mattermost.atlassian.net/browse/MM-27004
https://mattermost.atlassian.net/browse/MM-27140

I'd appreciate a quick look to the latest changes, @lieut-data, I ended up changing several things for better supporting transactions and the IR_System table


Show Review panel on Rollback action

Like when reviewing changes, a Rollback should immediate trigger a review panel before the rollback is applied.

@andersjohnsen Fixed in https://github.com/rigdev/dashboard/commit/53a75581b59d541530b235d38e867421eeaf733e
Will go into next release.


New Models

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[MWPW-147521] interactive marquee container is not seen displayed as expected with resize flow

Fixes the foreground container width of the interactive marquee so that the text does not touch the edge of the screen on lower desktop screen sizes
Also fixes the generate prompt for firefly interactive marquee, which was going out of the image for screen size > 1200px and < 1300px.

Resolves: MWPW-147521
Test URLs:

Before: https://main--cc--adobecom.hlx.live/docs/library/kitchen-sink/interactive-marquee?martech=off
After: https://int-fix--cc--drashti1712.hlx.live/drafts/drashti/bugs/interactive-marquee?martech=off

Verified the flow after the fix :in different browsers and devices.
https://int-fix--cc--drashti1712.hlx.live/drafts/drashti/bugs/interactive-marquee?martech=off


Add log to syslog

For debuging purpose, it would be cool if the script can log to syslog the rc and the message. For exemple:
#!/bin/bash

debug=0 #debug value can be 0 (disasbled) or 1 (enabled)
...
curl -m 5 --data-urlencode "${payload}" $url
err=$?
if [ ${debug} -eq 1 ]; then
  logger -t $0 "message sent (rc=$err): ${payload} URL: ${url}"
fi

Thanks, but I don't intend to implement debugging in to the script itself. It is simple enough to edit the script to echo to a file temporarily for testing/troubleshooting.


installing pangolin failed in vcpkg for linux platform.

command - vcpkg install pangolin
error - "could not find yasm" in vcpkg_find_acquire_program.cmake at line 44.

@ras0219-msft
can you guide me to address this issue?

@ras0219-msft any help?


Correct a typo in date on the changelog file

Signed-off-by: David Lin<EMAIL_ADDRESS>

Oh, and I was trying so hard not to make that very mistake this year! :D


stake moveCall locked SuiSystemState

Steps to Reproduce Issue

locally run validator, json-rpc and fullnode
transfer coins from gas objects to a wallet address like

target/debug/wallet switch --gateway http://<IP_ADDRESS>:5001
target/debug/wallet gas
                 Object ID                  |  Version   |  Gas Value
----------------------------------------------------------------------
 0x1643e3eba234466aac049eabaa25bda5c419ba61 |     0      |   100000
 0x1c1c06b77e777d41741ded826b37da450ce27862 |     0      |   100000
 0x21c87e7df1769252d328f8f2e516bed3e39fb13a |     0      |   100000
 0x87a25cafb136c1739b88973fd3f31a1759f36242 |     0      |   100000
 0xd5564c0ed7824e531eed87b6ed3abd5487c01f06 |     0      |   100000
target/debug/wallet transfer-coin --coin-object-id 0x1643e3eba234466aac049eabaa25bda5c419ba61 --to 0x627ac02b685d506cbf38cda62cae63cb48a5ec75 --gas-budget 10000
target/debug/wallet transfer-coin --coin-object-id 0x1c1c06b77e777d41741ded826b37da450ce27862 --to 0x627ac02b685d506cbf38cda62cae63cb48a5ec75 --gas-budget 10000

from sdk-test-app repo, replace first-gas-object-id and then insert this block of codes to SignerDemo.tsx after // Test Move call

    const stakeTxn = await signerWithProvider.executeMoveCall({
      packageObjectId: "0x2",
      module: "sui_system",
      function: "request_add_stake",
      typeArguments: [],
      arguments: [
        "0x0000000000000000000000000000000000000005",
        "<first-gas-object-id>",
      ],
      gasBudget: 10000,
    });

in test-sdk-app, run rm -rf node_modules && yarn && yarn start, in case it did not pop, go to http://localhost:3000/, press F12 to show the console
then click "get objects Get" -> "Sign"

Expected Result
The SuiSystemState shared object should not be locked
Actual Result
In the console, it showed something like
json-rpc-provider.ts:187 Uncaught (in promise) Error: Error executing transaction: Error: RPC Error: Failed to execute certificate on a quorum of validators, cause by : [
Error acquiring lock for object(s): [UnexpectedSequenceNumber { object_id: 0x0000000000000000000000000000000000000005, expected_sequence: SequenceNumber(1), given_sequence: SequenceNumber(2) }]",

the correct typeArguments should be something like  ["0x2::sui::SUI"] but otherwise it should not lock the shared object either.

You can also reproduce this with wallet cli
➜ ./wallet call --package 0x2 --module sui_system --function request_add_stake --args 0x0000000000000000000000000000000000000005 0xa2eec59c280fe641904f22ace7cc4eb2c4e7ef65 --gas-budget 2000
RPC call failed: ErrorObject { code: ServerError(-32000), message: "Failed to execute certificate on a quorum of validators, cause by : [\n    \"Error acquiring lock for object(s): [UnexpectedSequenceNumber { object_id: 0x0000000000000000000000000000000000000005, expected_sequence: SequenceNumber(1), given_sequence: SequenceNumber(2) }]\",\n    \"Error acquiring lock for object(s): [UnexpectedSequenceNumber { object_id: 0x0000000000000000000000000000000000000005, expected_sequence: SequenceNumber(1), given_sequence: SequenceNumber(2) }]\",\n    \"Error acquiring lock for object(s): [UnexpectedSequenceNumber { object_id: 0x0000000000000000000000000000000000000005, expected_sequence: SequenceNumber(1), given_sequence: SequenceNumber(2) }]\",\n]", data: None }

@lxfind / @patrickkuo , a separate question: do you know why we don't need to specify type-args in this case?
Given that the argument contains a generic, I thought we need to pass in type_args, but I am getting an error if I do that
./wallet call --package 0x2 --module sui_system --function request_add_stake --args 0x0000000000000000000000000000000000000005 0xa2eec59c280fe641904f22ace7cc4eb2c4e7ef65 --type-args 0x2::SUI::SUI --gas-budget 2000
RPC call failed: ErrorObject { code: ServerError(-32000), message: "ExecutionError: ExecutionError { inner: ExecutionErrorInner { kind: InvalidFunctionSignature, source: Some(\"Expected 0 type arguments, but found 1\") } }", data: None }

@lxfind / @patrickkuo , a separate question: do you know why we don't need to specify type-args in this case?
Given that the argument contains a generic, I thought we need to pass in type_args, but I am getting an error if I do that
./wallet call --package 0x2 --module sui_system --function request_add_stake --args 0x0000000000000000000000000000000000000005 0xa2eec59c280fe641904f22ace7cc4eb2c4e7ef65 --type-args 0x2::SUI::SUI --gas-budget 2000
RPC call failed: ErrorObject { code: ServerError(-32000), message: "ExecutionError: ExecutionError { inner: ExecutionErrorInner { kind: InvalidFunctionSignature, source: Some(\"Expected 0 type arguments, but found 1\") } }", data: None }

The type_arg is for function generic, e.g. fun transfer<T>


WIP: Pilo versionning and checks

This PR introduces schemas for Analyzed<T> and some checks on the validity of the binary format.
It uses schemars to produce a JsonSchema of the structure, and adds an executable (schema_update) that performs a diff between the current code structure and the one previously computed and then bumps the version number. This executable is meant to be called from a CI process automatically.
To perform the checks, this PR introduces a wrapper around Analyzed<T> that keeps track of a magic number, the version of the code structure and the type of the FieldElement used.
Possible improvements:

As for now, the analysis of the code structure ignore changes inside of the FieldElement, because schemars does not implement JsonSchema for ark data structures. It should be implemented before merging this PR, hence the WIP status.
We could also store a hash of the generated JsonSchema instead of the whole structure to save a few bytes (12kb at the time of writing)
The MAGIC number is kind of useless for now, it is just stored inside the structure but because of the serialization it does not appear at the start of the file as it should. I'm a little reluctant to prepend some arbitrary data to the serialized blob but we might have to do it anyway
I've put the new binary and the versioning system inside of the ast crate, but there might be a better place to put it and I'm open to suggestions about it :)
Add some tests for the schema generation and the version bumping

Just a quick comment before I check the whole thing: I think this shouldn't be in the ast crate, but rather in some more externally facing crate. The AST is ofc used for the binary but it's rather internal. I think it should be in one of these crates:

powdr
pipeline
its own crate? This is actually my fav option rn I think


ManagedIdentityCredential for Service Bus throwing error

I am trying to implement, managed identity authentication using the Azure SDK .NET in my C# application to establish connectivity to Service Bus and Send a Message to it but getting the error as below
Error Message: ManagedIdentityCredential authentication unavailable. No Managed Identity endpoint found
Below is my code snippet.
...
//Creation Service Bus Client connection
var serviceBusClientOptions = new ServiceBusClientOptions();
serviceBusClientOptions.TransportType = ServiceBusTransportType.AmqpWebSockets;
ManagedIdentityCredential managedIdentityCredential = new ManagedIdentityCredential("<My App Registration Client Id>");
var serviceBusClient = new ServiceBusClient("myservicebus.servicebus.windows.net", managedIdentityCredential , serviceBusClientOptions);

//Sending Message to queue
var serviceBusSender = serviceBusClient.CreateSender("testsb");
var serviceBusMessage = new ServiceBusMessage("TestMessage");
serviceBusMessage.ContentType = "Text/Plain";
serviceBusSender.SendMessageAsync(serviceBusMessage);
...

I am using the packages with below version :
.NET Core 3.1
Azure.Messaging.ServiceBus 7.2.1
Azure.Identity 1.4.1

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

@christothes I am executing the code directly in my Visual Studio IDE as a class library. A Web API is consuming this library.
A note, if I replace ManagedIdentityCredential with ClientSecretCredential in that case message sending works but I am more interested in making this ManagedIdentityCredential work. Am I missing anything?

@christothes I am executing the code directly in my Visual Studio IDE as a class library. A Web API is consuming this library.
A note, if I replace ManagedIdentityCredential with ClientSecretCredential in that case message sending works but I am more interested in making this ManagedIdentityCredential work. Am I missing anything?

Ah - if you are running this locally in Visual Studio, then what you are experiencing is expected. The Managed Identity credential only works inside an Azure environment. If you were to deploy that code to a Web App that has a system assigned Managed Identity, it should work.
This is one of the main reasons that DefaultAzureCredential is used. It falls back to other credentials when the MI credential is not available, but tries it first so that if the code is deployed to Azure, it works as expected.


CAMEL-17121: present the awaitConsumer from blocking indefinitely

@davsclaus this should fix the block (in case we want to retain the patch instead of reverting it).


Fix year and licence owner

Coverage remained the same at 81.85% when pulling e349649289918749273a296a3d21b30d37a05ba5 on adericbourg:fix_licence into b203f460e01b8540795f406fd0215267ac6900e6 on criteo:master.


fix(heatmap): not drawn properly after resize (caused by ctx cache)

Closes: #604

Checklist

[x] npm test passes
[x] tests and/or benchmarks are included
[x] commit message follows commit guidelines

@huxiaoyun 等 PR，会在这周的 patch 版本上线（3.0.9）


Update Custom Model encode type signature in README

Ran into a matrix math error when returning List[np.array] from my custom Model. Updating here so that others don't run into the same error and have to debug.
Let me know if this should instead be filed as a bug for List[np.array] return types not being supported

Thanks a lot for fixing. For which task did you run into that error?
I think it may be fixed by this PR: https://github.com/embeddings-benchmark/mteb/pull/145

Oh nice! I unfortunately don't have my computer with me this week so I can't check exactly, but I believe it was the first InformationRetrieval task

@rsmith49 feel free to submit a bug report on this if needed, but for now, I will close the PR.


hotlink common collection keywords for user search

Hey all,
I just had a rough time finding common structures like queue, stack, priority queue in phobos and after a long search I realized that you everything is already included. Hence for future users like me which blindly enter "dlang queue" in google, I propose to add some keywords with common terms or usages of these data structures.
This PR is in no way complete (ideas and suggestions are more than welcome), but I guess this should be a small step in the direction of user friendliness ;-)
If it finds consensus, I would also be happy to add more examples - especially dlist is pretty sparse.

I think this is a great idea.

LGTM

@quickfur thanks - changed ;-)

LGTM, thanks for the prompt response!

Auto-merge toggled on


Upgrade net version to 8.

Upgrade the .net version from 6 to 8
Also, upgrade the osu-framework-related package to the latest.
CI/CD will use the latest net version also.

CI 讓我過吧
我想睡覺了
求求你好心人


json: Added element descriptor macro and C++ support progress

Opening this PR to start the discussion, code formatting is not perfect.
I'm working towards cleaning up the JSON library and making it more maintainable, on my high priorities is compatibility with C++.
What are the Zephyr guidelines towards having empty macro arguments? In this specific use case the union_ parameter in JSON_ELEMENT_DESCR may be empty, this is to insure a single point of use for  (struct json_obj_descr[])
The underlying issue which motivates this PR is issue #18551, in this case macros that utilize struct json_obj_descr[] aren't able to run on C++. A possible patch is to replace all these occurrents for const struct json_obj_descr[1].

I appreciate the insight, thanks for the help!

I went ahead and prefixed with Z_
Improved C++ support by changing from  struct json_obj_descr[] to const struct json_obj_descr[1]
Rebased to pass CI

@martinjaeger rebased to avoid conflict due to #38061: Updated use of JSON_TOK_LIST_ to JSON_TOK_ARRAY_

@cfriedt Thank you for the review have updated accordingly.
I really appreciate all the help you and @martinjaeger have provided, you've both made the process of contributing to Zephyr seamless.

@mrfuchs - Would it be possible to get a review?

@cfriedt do you think this can be merged in? Not sure why @mrfuchs approval isn't counting, even though he's a collaborator. Maybe he doesn't have write access? (Apologies if this is obvious, this is new to me)

@mbolivar-nordic - I think that @mrfuchs is a collaborator for JSON. Any idea why have a approval might not work?


feature/STADTPULS 739/set recorded at via payload

feat(http): adds ability to post with own recorded_at prop
test(http): adds tests for pushing recorded_at payload and converting from is8601 utc offsets to utc

My only comment would be that you're using isDate to check if the provided recorded_at ist valid. But when it isn't you ignore the param and set the date yourself. I think it might be better if it fails with an appropriate error message. What do you think?

yes. You are right. The user tries to set the date.

Thanks for the review folks. I refactored the PR a little. We don't need isDate since ajv and the JSON Schema already take care of validation (I love fastify). So we never reach that situation that we need to check if the date is a date.
In a future version (with fastify v4 https://github.com/fastify/fastify/issues/3482) We also will have some more nice validators for iso-date-time formats and emails and what not. Using ajv-formats

:tada: This PR is included in version 3.1.0-rc.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


skills to compare versions in N(.N)* format

If your PR is related to a contribution to the taxonomy, please, fill
out the following questionnaire. If not, replace this whole text and the
following questionnaire with whatever information is applicable to your PR.
Describe the contribution to the taxonomy

Compare versions in N(.N)* format, like kernel-5.14.0-70.13.1.el9_0 is higher than kernel-5.14.0-70.8.1.el9_0.
Do not compare the two versions if the package names are not the same.

Input given at the prompt
>>> kernel-5.14.0-70.13.1.el9_0 and kernel-5.14.0-70.8.1.el9_0, which is higher?

Response that was received
>>> kernel-5.14.0-70.13.1.el9_0 and kernel-5.14.0-70.8.1.el9_0, which is higher?                                                                 [S][default]
╭─────────────────────────────────────────────────────────────────── merlinite-7b-Q4_K_M ───────────────────────────────────────────────────────────────────╮
│ Based on the naming convention, the kernel version with the higher kernelrelease number is higher. In this case, kernel-5.14.0-70.8.1.el9_0 has a higher  │
│ kernelrelease number than kernel-5.14.0-70.13.1.el9_0.                                                                                │
╰────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── elapsed 13.152 seconds ─╯

Response that is now received instead

Contribution checklist

[x] Contribution was tested with lab generate
[x] No errors or warnings were produced by lab generate
[x] All commits are signed off (DCO)
[x] The qna.yaml file was linted and prettified (yaml-validator can do both)

Thank you for your contribution to InstructLab! Unfortunately, once a Github repo is made public, all open PRs are automatically closed since they link against a private repo. We have detected that your PR might have been one of the ones affected by this change. If you are still interested in contributing your improvement, please fill out the following short form by no later than May 3rd, and we will get back to you with the additional steps necessary once we have had time to assess the PRs of those still interested:
https://forms.gle/V7SrPPMZDo6iGDYu8


simple-linked-list: update Ruby example to include null object pattern

In the simple-linked-list README we have the following example Ruby code:
Element.to_a(nil) #=> []
Element.from_a([]) #=> nil
Element.reverse(nil) #=> nil
one = Element.new(1, nil)
one #=> <Element @datum=1, @next=nil>
one.datum #=> 1
one.next #=> nil
two = Element.new(2, one)
two #=> <Element @datum=2, @next=<Element @datum=1 @next=nil>>
Element.to_a(two) #=> [2, 1]
Element.reverse(two) #=> <Element @datum=1 @next=<Element @datum=2 @next=nil>>
range = Element.from_a(1..10)
range.datum #=> 1
range.next.next.next.next.next.next.next.next.next.next.datum #=> 10

However in simple_linked_list_test.rb we have the following test:
  def test_empty_list_operations
    skip
    assert_equal [], Element.from_a([]).to_a
    assert_equal [], Element.from_a([]).reverse.to_a
  end

The issue of the linked-list returning nil was addressed in this commit, so I figured the Ruby code in the README should be updated to reflect that.

Ah. I didn't realize we still had ruby code in the README. I don't think we should have language-specific in the code, since the README gets delivered for all the languages.
@exercism/track-maintainers should we just remove the example code? Should we translate the code example into generic pseudocode?

I don't mind if there is very little code, just two or three lines of code, to provide an example.
The code shown in this issue looks like tests. Even translating it to pseudocode, it's too much for a README. It looks like specs describing the Element API, so I'd put that code in tests (it probably is), writing several test cases.

I know zero Ruby, so the above example code is a bit cryptic for me.  Maybe pseudo code is better, consider mine the LCD opinion!

I agree with @rchavarria -- that looks like tests more than pseudo-code.

Yeah, this is going to be confusing for all the other language tracks.
Should we remove the entire bit of code for now? People can always look at the test suites for details.

+1 for removal
The liked list example does not include sample code.
https://github.com/exercism/x-common/blob/master/linked-list.md
On Thursday, December 10, 2015, Katrina Owen<EMAIL_ADDRESS>wrote:

Yeah, this is going to be confusing for all the other language tracks.
Should we remove the entire bit of code for now? People can always look at
the test suites for details.
—
Reply to this email directly or view it on GitHub
https://github.com/exercism/x-common/pull/158#issuecomment-163805213.

Removing the example code makes the most sense to me. That way all implementation details are left in the tests themselves. I've updated the README accordingly.

Excellent! Thanks for taking the time to discuss and work through this.


[Feature Request] Advancements on other items like features or weapons

It would be nice if you could put advancements on items like features or maybe even weapons.
I see this mostly being useful for feats like Scion of the Outer Planes, Metamagic Adept or Weapon Master, These feats grant items, resistances and/or proficiencies, just like advancements can.
It might also be also be useful for some weapons that have extra actions/options like the Staff of Power that has has Power Strike, Spells and a Retributive Strike. I see this especially usefull/easy to use when combined with #1546
Maybe if the item has spells that use charges of the weapon, allow that to be set up as well, though the spell bit can be recreated with the module Items with Spells DnD5e

Duplicate of https://github.com/foundryvtt/dnd5e/issues/1524


Expose random for SecretBoolean in the language

We have:
    def random(cls) -> "SecretInteger":

but we also have implemented a protocol to return a SecretBoolean which is more efficient than running:
SecretInteger.random() > Integer(0)

to get the SecretBoolean. The SecretBoolean.random() is not exposed in the language and things like shuffling which calls _rand_bool will really benefit from it.

Both random and random boolean should be computed in preprocessing and then pulled at no cost during runtime.


Custom Rotation of game source per hour

Would be nice to have a way to choice which games music we use on a given hour.  A list of all 24 hours and we select which of the 4 games we want to use for each hour should be enough I think.

I could do the settings page to adjust this rotation, if someone else can implement it in the JS.


entry,processor(ticdc): enhancements to mounter

What problem does this PR solve?

reduce unnecessary goroutine
reduce mounter channel size
reduce lock contention

Issue Number: close #4401
Check List
Tests

Unit test

Code changes

Has interface methods change

Release note
None

Codecov Report

Merging #4400 (1ebc693) into master (ab62e6b) will decrease coverage by 0.2575%.
The diff coverage is 46.0396%.

Flag
Coverage Δ

cdc
59.0342% <52.5745%> (-0.5817%)
:arrow_down:

dm
52.0856% <42.2776%> (+0.0200%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #4400        +/-   ##
================================================
- Coverage   55.5183%   55.2607%   -0.2576%
================================================
  Files           495        495
  Lines         61151      61141        -10
================================================
- Hits          33950      33787       -163
- Misses        23789      23953       +164
+ Partials       3412       3401        -11

/merge

/run-dm-integration-test
/run-integration-test
/run-kafka-integration-test

/run-integration-test
/run-kafka-integration-test

/run-kafka-integration-test
/run-integration-tests

/run-integration-tests /tidb=pr/30558

/run-integration-tests /tidb=pr/30842

/run-integration-tests /tidb=pr/30558

/run-kafka-integration-test /tidb=pr/30558


Support audio

Let's add audio to the already supporting modalities like images and texts.
The plan:

Add an analogue of get_mock_images_dataset
Add the corresponding datasets inherited from the corresponding interfaces
Add a sound processing NN model to Zoo, or add a wrapper to 3rd party sound models (like HFWrapper)
Based on the objects above, create train / val example.
Evaluate an example on a dataset having larger scale in order to check the example may be applied on real data.

Hi, I'll do it!

@amanteur What a coincidence!
 :)