--exclude-if-present leads to lots of lstat-operations for each directory

Output of restic version
restic 0.7.3 (v0.7.3-28-g2080afd-dirty)
compiled with go1.9 on linux/amd64
How did you run restic exactly?
export RESTIC_REPOSITORY=/srv/storage/restic
export RESTIC_PASSWORD_FILE=$HOME/.config/restic-password
ionice -c 3 ./restic backup --exclude-caches --exclude /mnt/backup-snapshot/_backup --force /mnt/backup-snapshot
What backend/server/service did you use?
local mount of ZFS via CIFS
Expected behavior
lstat each CACHEDIR.TAG once per directory
Actual behavior
CACHEDIR.TAG is lstat'ed once per file
futex(0xc4204cf610, FUTEX_WAKE, 1)      = 1 <0.000007>
lstat("/mnt/backup-snapshot/[..sensitive pathname..]/cache/81/7969-tiny-816f5f5ad4039bdb6eb0bdeebe3fe69ed4f83c3a", {st_mode=S_IFREG|0600, st_size=7425, ...}) = 0 <0.000024>
lstat("/mnt/backup-snapshot/[..sensitive pathname..]/cache/81/CACHEDIR.TAG", 0xc545816518) = -1 ENOENT (No such file or directory) <0.000008>
lstat("/mnt/backup-snapshot/[..sensitive pathname..]/cache/81/7969-tiny-816f5f5ad4039bdb6eb0bdeebe3fe69ed4f83c3a", {st_mode=S_IFREG|0600, st_size=7425, ...}) = 0 <0.000010>
lstat("/mnt/backup-snapshot/[..sensitive pathname..]/cache/81/CACHEDIR.TAG", 0xc5458166b8) = -1 ENOENT (No such file or directory) <0.000007>
epoll_wait(4, {}, 128, 0)               = 0 <0.000006>
futex(0xe3feb0, FUTEX_WAIT, 0, NULL)    = 0 <0.008781>
epoll_wait(4, {}, 128, 0)               = 0 <0.000010>
pselect6(0, NULL, NULL, NULL, {0, 3000}, 0) = 0 (Timeout) <0.000064>
futex(0xc420108490, FUTEX_WAKE, 1)      = 1 <0.000013>
futex(0xc420108490, FUTEX_WAKE, 1)      = 1 <0.000008>
lstat("/mnt/backup-snapshot/[..sensitive pathname..]/cache/81/8236-81177c7d3b2c70e6a9a60bc53bdbc29b5a857be8", {st_mode=S_IFREG|0600, st_size=587571, ...}) = 0 <0.000068>
lstat("/mnt/backup-snapshot/[..sensitive pathname..]/cache/81/CACHEDIR.TAG", 0xc5fbc7f628) = -1 ENOENT (No such file or directory) <0.000009>
lstat("/mnt/backup-snapshot/[..sensitive pathname..]/cache/81/8236-81177c7d3b2c70e6a9a60bc53bdbc29b5a857be8", {st_mode=S_IFREG|0600, st_size=587571, ...}) = 0 <0.000007>
lstat("/mnt/backup-snapshot/[..sensitive pathname..]/cache/81/CACHEDIR.TAG", 0xc5fbc7f7c8) = -1 ENOENT (No such file or directory) <0.000008>

Steps to reproduce the behavior
run restic with --exclude-caches or own --exclude-if-present
Do you have any idea what may have caused this?
From looking at the code I'd judge that the problem is, that the exclude filter is only applied to entries of each path that is walked in Pipe.Walk. If it would be applied to the path itself, too, and skip walking the entries if the path itself is excluded, this should not happen. Otherwise this seems not the complete solution, as if it were true, the problem should only happen in the first level of path traversal and not in "deeper" levels. So I'd say my analysis is flawed somehow.
Do you have an idea how to solve the issue?
I see multiple possible solutions:

split exclude filters for paths and entries. This seems to be the most effective solution: if the exclude filters are split (--exclude-if-present goes only with path and not with entry filters) then there is no need to check the presence of these files for each entry, but rather for each path
implement a temporary cache for the files presence(s)

You are right, the test for the CACHEDIR.TAG is "stateless", it is executed once per item (file or dir) and does not remember results from previous items.
Can you please describe why this is a problem in your use case?

I don't get it. Naturally only when the current item is a directory, should restic look for the exclude file in that directory. If the current item is a file it shouldn't perform the check for an exclude file (in the current file's directory). Seems like a no-brainer?

That's not the way the code is structured right now, that'd mean changing things around. And I'd like to know if the current behavior is impacting something in some way. I agree that it's an issue and that we should resolve it, so it's just a matter of prioritizing.

I havent measured the exact performance impact yet, but syscalls are not free. Looking at the strace summary the lstat's for CACHEDIR.TAG is the top syscall of restic, so this must be a performance hit. I agree that this depends on the directory/entry ratio of the backup set.

I planned to add a internal "cache" (mutex and a map[string]bool) for storing the exclusion result of each directory in the first visit. I just have not got around to do that, yet.


Reformat catalog.json to be a unique_id: table dictionary

#883 adds unique ids to entries in the catalog. It should take this one step further, and format the catalog.json file parallel to the manifest, where it is structured like:
{
  "models.package.my_model": {
    "columns": [...],
    "metadata": {...}
  }
}

This way we can simply deep merge the manifest, catalog, and other files to get a JSON blob for docs.

Any entries in the catalog that do not have a unique_id can be thrown away -- they would be anyway given the current state of the docs.


Spotify app automatically reopens when quit.

Ever since updating, whenever I try to QUIT Spotify on my computer, it instantly reopens itself.
When I close Tuneful, it will not do this behaviour, which makes me think its linked directly to something Tuneful is doing.

+1

+1

If this is expected behaviour then would really appreciate having a toggle to disable it please? 🙏

Hi @martinfekete10 , thank you for this useful music companion.
I think modifying the playStateOrTrackDidChange function and doing something like this before calling refreshInfo might fix the issue:

// Check if Spotify is running before refreshing info
if connectedApp == .spotify && !isRunningFromNotification {
Logger.main.log("Spotify is not running, skipping refresh")
return
}

I can test it on my machine if you can help me with the build process

Hi @mrtysn I actually fixed this issue yesterday and took this approach basically 😄 It will be included in the next release

Just noticed the 1.8.0 branch, thank you!

Just a heads up, Apple Music does the same thing as well, not just spotify. Not sure if fixed in 1.8.0 branch

Yep, that will be fixed as well


Upgraded from SkiaSharp 2.80.2 to 2.80.3

I upgraded the stable SkiaSharp usages from Skia Sharp 2.80.2 to Skia Sharp 2.80.3
The reason is to use
SkPicture Deserialize and Serialize methods. I plan to use it in my Rasterizing Tiling Pull request.
https://github.com/Mapsui/Mapsui/pull/1429
see:
https://github.com/mono/SkiaSharp/issues/880
The Preview skia Sharp Usage stays at 2.88.0-preview.179
Uno, WinUI, Maui use this Version (Uno Samples had the wrong references and I fixed it here).

Uno, WinUI, Maui use this Version (Uno Samples had the wrong references and I fixed it here).

How is that determined? By looking at what Uno itself is using?

I upgraded the stable SkiaSharp usages from Skia Sharp 2.80.2 to Skia Sharp 2.80.3

The Svg.Skia version we are using still depends on 2.80.2. This violates our guidlines https://mapsui.com/documentation/contributors-guidelines.html#keep-our-direct-and-indirect-dependencies-in-sync. The newest non-preview release of Svg.Skia uses another version but it is an 2.88 preview. It is is a complicated situation with no proper solution. Since we are in between releases this is okay. I think our next release should aim to release with 2.88.0. And if it is not released by then we go for a 2.88 preview, like Svg.Skia.

Yes the  beweist Uno Release use a Preview Version of skia sharp. Because there are some important bugfixes.


Add an option to make predictions at round times

Make the Dockerfile use 15 minutes.
Fixes #31

Codecov Report

Merging #33 (6b9a52f) into main (119aba2) will increase coverage by 0.59%.
The diff coverage is 100.00%.

:exclamation: Current head 6b9a52f differs from pull request most recent head 85bffbf. Consider uploading reports for the commit 85bffbf to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   90.83%   91.42%   +0.59%
==========================================
  Files          10       10
  Lines         240      245       +5
==========================================
+ Hits          218      224       +6
+ Misses         22       21       -1

Impacted Files
Coverage Δ

pv_site_production/models/common.py
100.00% <ø> (ø)

pv_site_production/app.py
94.44% <100.00%> (+2.60%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix type annotation for LineItemType enum

The annotation says it would expect an instance of LineItemType. But it expects a string (a constant from the LineItemType).
This currently fails any autocomplete and static analysis.
Using LineItemType::* fixes this as allowed by phpstan, see https://phpstan.org/writing-php-code/phpdoc-types#literals-and-constants
But in general the same problem seems to apply to all enums in this library, e.g. also TransactionState.
Is this generated code? Then it needs to be fixed in the generator I assume.

@Tobion thank you for the update. We will take an overall look at the enum annotations on the PHP sdk.

@vttn any news one this one? It might also make sense to create a new version of the library requiring php 8.1 that can make use of native php enums.

Hello @Tobion,
We looked into changing the annotations and we discovered that the work around could not be found to apply this to all SDK classes in the library.
We are working on bringing out PHP 8.1 soon.


Last event not update

Possibly there is a issue with the last event for package with tracking code LB107580877SG. The event is not being returned.

At b3e20b7b159d72da53dc00068272a41dd97ddbb8 I added it to the test suite. Any chance I missed something?

Please check RH117939038TR too.

This tracking code generated a HTML response that didn't have the same pattern as other ones. It was lacking a strong node.
Fixed it on 1.0.1 (ba46f953bcba80b5bad5dc695460f81d27b526d6), please check it. :rocket:
By the way, thank you for the bug report. :pray:

Thanks, this fix solved the issue in my application.


[Bug]: Reset widget not working properly

Is there an existing issue for this?

[X] I have searched the existing issues

Description
I have a form with multiple fields and while selecting a dropdown value some data will be fetched from db and shown to other widgets . when deselecting the option the widgets filled with data should be changed to default value state. I tried by calling resetwidget() for each and every field but did not work.

Before selecting fee term

2.Here while select fee term the data are populating to the fields

3.After deselecting the fee term some widget like number field only are got reset.

Steps To Reproduce
1.Include a for with multiple  type widgets.
2. Populate some data to the widgets on change event of  select dropdown.
3. Reset widgets by calling resetWidget() in a js function on change event before executing the query to show data  and check.
Public Sample App
No response
Version
Self hosted v1.6.15

@ginjojohny can you share the code for the reset widget?
Also tried with the method you mentioned   as  resetWidget("fee_details",true);   where  'fee_details'   is my container name.
While inspecting errors showing as shown in the image.

@ginjojohny this seems like it needs deeper investigation by us. Can you share your app with<EMAIL_ADDRESS>

@Nikhil-Nandagopal  shared the app to the above mentioned mail id

I could not reproduce the problem. I am closing this issue for now.

Hi, @pranavkanade  shared loom video  which shows the issue to<EMAIL_ADDRESS>.

@ginjojohny just confirmed this is not the resetWidget issue. I am replying to your email with a detailed resolution.
RCA - The default values are bound to a query response that is not cleared when the option changes; hence, as expected, input fields show the values even after widget reset.

@pranavkanade  issue fixed as per your solution. Thank you.

@ginjojohny can you please forward the solution to<EMAIL_ADDRESS>Thank you.


'${workspaceFolder}' can not be resolved in a multi folder workspace

VSCode Version: 1.44.0
OS Version: Windows 10 Pro 1909 Build 18363.720

Steps to Reproduce:

Create a workspace
Add a folder to that workspace.
Add a launch configuration "Node.js: Attach to Process" in the workspace file.
Start the debug session.

Here is my workspace file:
{
  "folders": [
		{
			"path": "."
		},
		{
			"path": "app"
		}
  ],
  "launch": {
    "configurations": [
      {
        "type": "node",
        "request": "attach",
        "name": "Attach by Process ID",
        "processId": "${command:PickProcess}",
        "skipFiles": [
          "<node_internals>/**"
        ]
      }

    ],
    "compounds": []
  },
  "settings": {}
}

Here is a screenshot of the error:

Does this issue occur when all extensions are disabled?: Yes

`Version: 1.41.0-insider (user setup)
Commit: a747d26
Date: 2019-11-23T11:09:42.834Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.19025
        Steps to Reproduce:

        Using the TreeDataProvider API load a custom View into Explorer with icons
        Change out one of the icons on disk with another icon of the same name and path.
        Refresh the TreeDataProvider without a window reload.
        Note the icon with same URI will not change.
        Does this issue occur when all extensions are disabled?
        :This issue relates to an extension feature, therefore could not be tested without extensions.`

I'm also seeing this in a workspace that already uses the : syntax; indeed, it still fails if I change the config to remove all workspaceFolder entirely.

I also have the problem under Win 7, VS Code 1.44 and I am not able to debug a remote node process. I don´t have any ${workspaceFolder} variable entry in my configuration. It is also a multi folder workspace. Furthermore I don´t have problems to debug with the Chrome debug plugin.
With 1.43 my debug configuration worked without any problems. So I am using the previous version right now,
I hope these informations are helpful.

Sounds like a regression, investigating...

After some investigation the problem is the following for the workspace configuration our debug extensions appends the following attribute
__workspaceFolder:'${workspaceFolder}'
And the configuration resolver properly tries to resolve this and complains becuase the scope of the folder is not specified.
Proposed fix: the node extension which adds this attribute should scope it if it sees that we are in a multi root folder. So instead of ${workspaceFolder} use ${FOLDER_NAME:workspaceFolder}.
Forwarding to @roblourens and @connor4312  as they might know more about the changes in node debug. Adding label regression and candidate.

Looks similar to a problem I was going to report. I am doing simple Node.js debugging without folders or workspace. Things were working fine in 1.43.2 but when I upgraded to 1.44 I started seeing popup errors related to missing ${workspaceFolder}. Downgraded to 1.43.2 and the error went away. Most likely related to this.

@isidorn is the syntax really "${FOLDER_NAME:workspaceFolder}" and not the rev

@weinand you are correct as specified here https://code.visualstudio.com/docs/editor/variables-reference#_variables-scoped-per-workspace-folder

Oh. I think this is just so that we can apply defaults that contain ${workspaceFolder} but we won't be able to pick a default for multi-root workspaces.
I could just not add that property if we are in a multiroot workspace? And I guess it should fail in a nice way if there is a ${workspaceFolder} reference in a default that can't be resolved?
Is that right @connor4312 or do you remember if there's something else that I added this __workspaceFolder hack for?

Currently js-debug needs __workspaceFolder for quite a few things. I'll take a look at making those places optional/noop, if you need an interim fix you could pick the first workspace folder (should be no 'worse' than making js-debug no-op)

I've made changes in https://github.com/microsoft/vscode-js-debug/commit/4c29f9c08a59393e2a323dbbe2db1ac8ffe35e3b that should allow undefined workspaces for attach. Launch will still need a workspace folder set; in js-debug I derive this as path.dirname(program) if there's none set.

I realized that previously we only set it when useV3 is set, now we set it all the time. I suggest that we just restore that setting check for the candidate.

Does anyone know of any temporary workaround that can be done locally until the fix has arrived?
I'm quite stuck.. can't run the debugger.

@axeldavid You can either downgrade Code itself to 1.43 or upgrade the node-debug extension to 1.44.5 by searching for ms-vscode.node-debug and selecting Manage > Install Another Version….

@axeldavid You can either downgrade Code itself to 1.43 or upgrade the node-debug extension to 1.44.5 by searching for ms-vscode.node-debug and selecting Manage > Install Another Version….

@zwaldowski Thanks a lot. I upgraded the node-debug extension and it works perfectly now.

VS Code 1.44.2 (with node-debug 1.44.5) is out now. This should fix the issue.

VS Code 1.44.2 (with node-debug 1.44.5) is out now. This should fix the issue.

Can confirm that the latest release has fixed this :+1:


Link genericPage to other models

e.g. currently genericPage -> other genericPage through children, what about other datatypes?

not really needed if each datatype can connect to itself (ie courseItem grouped by subjectID, reddit links can just use the normal LinkExtractor


Fixing up issues with nuspec files

Fixing up issues with Http nuspec where a typo made it overwrite the Text.Formatting nuspec, creating a cyclical dependency; also, fixing the Time nuspec to place the binaries in the lib folder

LGTM


Add docs for eleventy-cache-assets to main docs

Part of #559
Adds docs from eleventy-cache-assets to main docs. I used the permalink "Cache API Data" and placed it at the end of "Using Data". I tried to use something with the word "Data" in it. The link name and or location of the documentation page can be changed.
Looking forward to having these docs on the site @zachleat

Note: I had to make the first key's value in relatedLinks a quoted scalar because the # wasn't playing nice in YAML. (the only text displayed was the stuff before the # without quotes, I tried escaping it with \# which worked but then the backslash shows). I know this isn't the uniform syntax for the items in relatedLinks but I wasn't sure how else to get the proper text content to display.
/docs/quicktips/cache-api-requests/: "Quick Tip #009 -- Cache Data Requests"

Ah, sorry—I honestly didn’t see this until just now but I did complete this task today (with also a ton of changes to the docs on both sides)

No worries! Thanks for the heads up.


Conflicts in svelte resolve

Hi,
I upgraded my project dependencies and some new warnings appeared. This is the message:
[vite-plugin-svelte] WARNING: The following packages use a svelte resolve configuration in package.json that has conflicting results and is going to cause problems future.
Here there is more info about the conflicts by the vite-plugin-svelte team:
https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/faq.md#conflicts-in-svelte-resolve

Should be fixed in v2.4.0 (lmk if not)


Can not add accounts that have no keyAuths

Hi,
i can not add accounts like @threespeakwallet that has not keyAuths but only @threespeak as accountAuth. Could you add support for this?

I thought a bit more about this. I think it would be enough to tell keychain "This tx is for accountA but just sign it as accountB and try to submit" then the developer only needs to specify the account that has the required authority over accountA


fix grid mode

Description
This PR closes #1400 by fixing grid mode which was broke in #1376
It still needs tests/ doc strings

This now has comprehensive tests model of model and vispy with screenshot and is ready for review @jni

tests failing, i will look tomorrow

Closing this PR due to revision of EVH in #1416, will preserve tests in new PR


Added a Word Counter App

Fixes #271
Created a simple Word counter app using HMTL, CSS, JavaScript.
Hope this solves the issue.
Looking forward for merging this PR.
Title and Issue number

Title : Word Counter App
Issue No. : #271
Code Stack : HTML, CSS, JavaScript
Close #271

Checklist:

[X] I have mentioned the issue number in my Pull Request.
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have created a helpful and easy to understand README.md
[X] I have updated the Index.html file for my contribution

Got it !!!


Could not receive image data Open the Browser Console to get details

I am getting "Could not receive image data Open the Browser Console to get details" error message when uploading the jpg images for annotation.
What could be the issue?

How can we reproduce it?

If that is local installation, you may check docker logs (e.g. docker logs cvat_server), but the command depends on CVAT version.
If that is app.cvat.ai, we need job id and we may check logs on our side.
Generally it is an error on the server.

@bsekachev I am facing this error from today morning

Job ID: #638014: OCR
Kindly check the logs and resolve the issue asap.
Thank you.

Access to the bound cloud storage is forbidden. Perhaps secrets are expired.
The data can not be fetched.

So, please, try to update access/secret keys: https://app.cvat.ai/cloudstorages/update/1238

How to update access/secret keys?

Go to cloud storage page
Select a cloud storage from the list
Open actions menu

Click "Update"
Provide new keys

Nothing is shown in cloud storage page for me, its empty for me..

Please, send the screenshot.

Perhaps you enabled the organization (I can't see because you drawn this information). When organization enabled, you see only the organization resources. So, go to personal workspace first.

How to go to the personal workspace and what should I do next?

username?

Username: Indirarajan

This username does not have access to the job, you specified before.

Job ID: #638014: OCR

I have deleted the older Job ID and currently working in the below job ID.
Job ID: #638498: Number Plate OCR

You shared Task ID, not Job ID.
Data in the shared task can be accessed

Does it depend on the screen size? Because both of the screen sizes differ.

No, it does not.

But I can open it in larger screen size devices but not in the smaller ones.


A tricky bad case

I've found that many clipping libraries, including Clipper2, don't handle the point-on-line situation very well. The image above shows a wrong case. The testing code goes here.
Paths64 subject, clip, poly_intersection, poly_union;
subject.push_back(MakePath("4,1,9,5,0,5"));
clip.push_back(MakePath("1,4,7,6,3,6"));
poly_union = Union(subject, clip, FillRule::NonZero);
poly_intersection = Intersect(subject, clip, FillRule::NonZero);

The union is correct, but the intersection is empty.

This isn't a clipping bug. You simply haven't understood that, because of integer rounding, you need to appropriately scale polygons when they are very small. And polygons with very small areas (<2 units) are routinely removed because or rounding inaccuracies / artefacts. I'm sure if you multiply all your coordinates by 10, you'll get the solutions you're anticipating.


New command: spo list view add

Usage
spo list view add [options]
Description
Adds a new view to a SharePoint list with a set of fields.
Options

Option
Description

-u, --webUrl <webUrl>
URL of the site where the list to remove the view from is located

--listId [listId]
ID of the list to which the view should be added. Specify either listId or listTitle but not both

--listTitle [listTitle]
Title of the list to which the view should be added. Specify either listId or listTitle but not both

--viewTitle <viewTitle>
Title of the view to be created for the list

--fields <fields>
Comma-separated list of case-sensitive internal- ordisplay names of the fields to add to the view

--personal
View will be created as personal, if specified

--defaultView
View will be set to default, if specified

--orderedView
View will be ordered, if specified

--paged
View will be paged, if specified

--query [query]
JMESPath query string. See http://jmespath.org/ for more information and examples

-o, --output [output]
Output type. json,text. Default text

--verbose
Runs command with verbose logging

--debug
Runs command with debug logging

Additional Information
Should be doable through the SharePoint REST API call. Below is an example:
https://{sample_site_URL}/_api/Web/Lists(guid'{sample_GUID}')/Views
Add-PnPView:
https://docs.microsoft.com/en-us/powershell/module/sharepoint-pnp/add-pnpview?view=sharepoint-ps

That's a very nice spec! I've updated the following things:

marked required options using <>: webUrl, viewTitle, fields
renamed fieldTitle to fields since it accepts both internal and display name
removed values for flag options --paged vs --paged [paged]. The latter indicates that you can specify a value whereas the description describes it as a flag.

Would you like to try building it? 🙂

@waldekmastykarz - thank you for the updates. Yes, I will take this, please assign it to me🙂

All yours @yeshwanthjagannath thank you for your help 👍🏻

I was reading this and thought it was an amazing idea! What could be even better is to add a parameter where you could define the view XML instead of just the fields. This would allow advanced scenarios like column formatting, etc.

Option
Description

-viewXml
Xml representation of the list View

You could either specified --fields OR --viewXml when calling this command. Do you think this would be a good idea @yeshwanthjagannath @waldekmastykarz?

If creating a view using XML is supported, definitely! Since this issue is already in progress, how about we define this suggestion in a separate issue as an enhancement and pick it up once this issue is closed?

I'll create the issue and add a bit of details around the APIs we could leverage and will work on it as soon as @yeshwanthjagannath is done doing the magic! Thanks!

Awesome! Thanks @sebastienlevert 👏

Thank you for the suggestion @sebastienlevert , definitely a good addition.

Hey @yeshwanthjagannath, are you still working on this?

@waldekmastykarz - Yes.

Awesome! Please, don't hesitate to reach out if you need any help 👍

@waldekmastykarz - Can you help me understand the POST JSON payload for adding the fields as part of this command for the 'ViewFields' parameter? I am unable to determine JSON request that needs to be sent for the field collection. I believe it is to be an array and when I tried the below snippet, got an error:
"A node of type 'StartArray' was read from the JSON reader when trying to read the contents of a resource reference navigation link; however, a 'StartObject' node or 'PrimitiveValue' node with null value was expected."
{
"Title": "TestView",
"ViewFields": ["Column1","Column2"]
}
What am i doing wrong?

I wonder if ViewFields shouldn't be specified as:
{
  "ViewFields": [
    {
      "StringValue": "Column1"
    },
    {
      "StringValue": "Column2"
    }
  ]
}

@waldekmastykarz - Thank you for the response. Yes, i tried setting that, but looks like it is not being accepted. I believe, we will have to use the /ViewFields/addviewfield('FieldName') API endpoint through an iteration and build out the view fields.
For Content-Type i had application/json; odata=verbose
Will give the above a shot and will reach out if i need anything else.

Hey @yeshwanthjagannath 👋
Are you still working on this?

Hi @garrytrinder - No, my apologies, it has been quite a busy period on my end with other assignments, so please go ahead and reassign this.

Thank you for the update @yeshwanthjagannath
Absolutely no problem, life and family takes priority 👍🏻

Thank you @milanholemans its all yours!

If you guys agree, I'll  add an extra option called --viewId. This way it works the same as --listId and --listTitle.

Great Idea @milanholemans!

Got some suggestions
The _api/web/lists/GetByTitle('...')/views endpoint didn't work pretty well for me. Views were created but are invisible in the view picker. At the moment I'm using _api/web/lists/GetByTitle('...')/views/add this endpoint does work as expected.
Because of this, I do have to drop the option --orderedView since it is not supported. Instead I can add a new option --rowLimit which specifies the page limit of the view. Is this fine?
Also I have a small suggestion to rename the --defaultView to --default. Since we are using a view command I don't think it's necessary to repeat the 'view' word. This way it is also more consistent with the --personal option. What do you guys think?
Last one, I think --viewTitle, should be renamed to --title to make it more consistent with option namings in other commands.
New specs would look something like this:

Option
Description

-u, --webUrl <webUrl>
URL of the site where the list to remove the view from is located.

--listId [listId]
ID of the list to which the view should be added. Specify either listId, listTitle or listUrl but not multiple.

--listTitle [listTitle]
Title of the list to which the view should be added. Specify either listId, listTitle or listUrl but not multiple.

--listUrl [listUrl]
Relative URL of the list to which the view should be added. Specify either listId, listTitle or listUrl but not multiple.

--title [title]
Title of the view to be created for the list.

--fields <fields>
Comma-separated list of case-sensitive internal names of the fields to add to the view.

--personal
View will be created as personal view, if specified.

--default
View will be set as default view, if specified.

--paged
View will be paged, if specified (recommended to use this).

--rowLimit [rowLimit]
Sets the number of items to display for the view.

What do you guys think?

Sounds great @milanholemans, I checked the pnp PowerShell version, I think they use the same API.
We'll update the specs for you. Go right ahead!
Seeing Add-PnPView I'm also wondering why we don't include a camlQuery option as well. @pnp/cli-for-microsoft-365-maintainers thoughts on that? Seems we're missing out if we create a view without allowing it to be filtered.

@martinlingstuyl do you mean the --viewQuery option?
There's a separate issue made for this #1862, but I can implement this right away if you want.

AH, good catch! 😋 no, let's continue as planned. Let's implement it separately

Awesome spec @milanholemans, nothing to add 🚀


S3 storagedriver URL problem in test suite

There appears to be a problem with the generated s3 URLs. Am I missing something?
$ export S3_ENCRYPT=false
$ export S3_BUCKET=mydockerregistry
$ export AWS_ACCESS_SECRET=XXXXXXXXXXX
$ export AWS_ACCESS_KEY=YYYYYYYYYYYYYY
$ go test -test.timeout=99h -test.short=true -check.vv -check.f TestContinueStreamAppendLarge
START: /Users/alp/workspace/gopath-docker-distribution/src/github.com/docker/distribution/storagedriver/testsuites/testsuites.go:95: DriverSuite.SetUpSuite
/Users/alp/workspace/gopath-docker-distribution/src/github.com/docker/distribution/storagedriver/testsuites/testsuites.go:100:
    c.Assert(err, check.IsNil)
... value *url.Error = &url.Error{Op:"Get", URL:"///mydockerregistry/?delimiter=&marker=&max-keys=1&prefix=%2Fvar%2Ffolders%2Fl0%2Fkj9cb1t95f5f73d3mbwhxdgm0000gn%2FT%2Fdriver-320629941", Err:(*http.badStringError)(0xc20801eae0)} ("Get ///mydockerregistry/?delimiter=&marker=&max-keys=1&prefix=%2Fvar%2Ffolders%2Fl0%2Fkj9cb1t95f5f73d3mbwhxdgm0000gn%2FT%2Fdriver-320629941: unsupported protocol scheme \"\"")

FAIL: /Users/alp/workspace/gopath-docker-distribution/src/github.com/docker/distribution/storagedriver/testsuites/testsuites.go:95: DriverSuite.SetUpSuite

START: /Users/alp/workspace/gopath-docker-distribution/src/github.com/docker/distribution/storagedriver/testsuites/testsuites.go:380: DriverSuite.TestContinueStreamAppendLarge
MISS: /Users/alp/workspace/gopath-docker-distribution/src/github.com/docker/distribution/storagedriver/testsuites/testsuites.go:380: DriverSuite.TestContinueStreamAppendLarge

START: /Users/alp/workspace/gopath-docker-distribution/src/github.com/docker/distribution/storagedriver/testsuites/testsuites.go:105: DriverSuite.TearDownSuite
PASS: /Users/alp/workspace/gopath-docker-distribution/src/github.com/docker/distribution/storagedriver/testsuites/testsuites.go:105: DriverSuite.TearDownSuite	0.000s

OOPS: 0 passed, 1 FAILED, 1 MISSED
--- FAIL: Test (0.01s)
FAIL
exit status 1
FAIL	github.com/docker/distribution/storagedriver/s3	0.027s

#question @stevvooe @AndreyKostov

I suspect that the problem is that you are not specifying a region. My bad for not detecting it earlier in the driver and making it clear that was the issue.

yep, driver initialization didn't ask for that.


ERROR START

Good afternoon, could you help me to solve this error when I turn on the bot

Simply install all the given required packages then you're good to go. Follow the steps given in Readme :)


Decrease the Gap padding in Navigation bar

Hi, please I'd like to work on this issue.

do we need to create kwoc and level1 labels

Hi sir, could you please assign it to me so I can work on it. Thanking you in advance.

Could you please assign this isssue to me under WOB


tests: HTTPServer test coverage

Adds HTTPServer test coverage.
Adds fakes for Probes and DebugServer, which are needed
for HTTPServer class.
0.0% -> 89.5%

Tests / CI System      [X]

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
No

@eduser25 I saw a related failure in one of my PRs:
2020-08-17T23:13:31.6097934Z •••••{"level":"fatal","component":"http-server","error":"http: Server closed","time":"2020-08-17T23:12:52Z","file":"httpserver.go:54","message":"Failed to start API server"}
2020-08-17T23:13:31.6098399Z FAIL	github.com/openservicemesh/osm/pkg/httpserver	0.069s


⚠ Secret Website 3 has degraded performance

In 0be2b7b, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 20890 ms

Resolved: Secret Website 3 performance has improved in 0b1ab9d.


Infer executable path

cargo objdump -- -d -no-show-raw-insn target/thumbv7m-none-eabi/debug/app is too long to write and redundant if you working on a binary crate. Let's have cargo-binutils infer the path of the executable. At the end we should be able to just write cargo objdump -- -d -no-show-raw-insn.
Here's what the logic should do (this may contain some errors / holes):

If the user passed a path after -- use that and don't try to infer the path
Else

Figure out where's the build directory; this will be the first part of our path

If CARGO_TARGET_DIR is set use that
If we are in a workspace use the $workspace_root/target
Else use $crate_root/target (XXX what about --manifest-path?)

Append the compilation target (e.g. thumbv7m-none-eabi) to the path.
If the user passed --release before -- use release as the next path segment; otherwise use debug as the next path segment
Figure out which executable we are dealing with

If the user passed --example $E before -- append examples/$E to the path.
else if the user passed --bin $B before -- append $B to the path
else if we are dealing with a binary crate (src/main.rs exists) append the crate name to the path
else (we are dealing with a library crate; src/main.rs is missing) error out (XXX we could check this earlier)

Append our inferred path to tools_args

Inferring the path should be done for these tools: nm, objdump, size and strip. And maybe objcopy; not sure about the last one as I haven't used it before via cargo-binutils.

Working on this because having to type the full path annoys me to no end.

PR #20 implements this


FogVolume problems

Godot version
4.0 beta rc2
System information
Windows 10 Forward+
Issue description
When using XRCamera

each eye has diffrent fog level.
https://github.com/GodotVR/godot-xr-tools/issues/381
Steps to reproduce
On godot 4.0 beta rc2
Launch https://github.com/GodotVR/godot-xr-tools
Place 2 cubes to make small corridor
In corridor add FogVolume node and setup it
Launch project and look at FogVolume.
Each eye should see FogVolume diffrently.
Minimal reproduction project
N/A

Duplicate of https://github.com/godotengine/godot/issues/72331.

Well I just want to say that I did look isn't it duplicate but didn't see any.


Allow resize and move in edit mode

This resolves #804 and #805. You can check-out this functionality here.

this is extremly cool! I love it!

Good stuff, I'll fix conflicts and merge. If there are any issues, I'll fix them as we find them. Cheers.


Using GitHub PR Number

Modifications are:

GitHub PR Number

When only_cancel_run_if_commit_is_using_pr_branch is set to true, we'll use the GitHub PR number to identify the dbt cloud runs to delete instead of the GitHub PR sha, which is far more complicated and raised some issues. Indeed, the changement of the sha when a rebasing (to the main/master branch) occurs implies an impossibility for the code to spot the right dbt cloud runs.
Instead of that, the user can provide the GitHub PR number which is an environment variable:
github_pr_number: ${{ github.event.number }}
And with dbt cloud API v2, we can also extract the PR number thanks to the data stored in trigger:
run_git_pr_number = run['trigger']['github_pull_request_id']
We just have to be careful that github_pr_number is a string whereas run_git_pr_number is an integer.
Therefore, some piece of code can be simplified quite easily with that.

Max Numbers of recent dbt cloud runs

Instead of having 10 as the definitive value of the number of recent runs to search for, I stored this value as a non-required variable ("10" by default). For some cases such as mine, I need to go back sometimes to at least 50 runs.

Next step for the next PR: Change the deprecating save state and set output commands to what is recommended by GitHub.

--
Thanks for having the time to review my PR. If you want to test it, you can refer to the latest release on Marketplace.

It seems that there is a problem to log the dbt cloud runs that have been cancelled. I don't know why, I'll keep looking.

@ThomasMonnier oh wow - love the thought process of using PR number instead of sha. That's much cleaner. Going to do some testing and review and hope to have it merged and in a release soon. Thanks for all the work on that!

Tested on a single running job with one in queue and worked accordingly
Tested with a running job and multiple queued jobs and worked accordingly
Tested on a singular run with nothing to cancel and worked accordingly
Tested on a brand new CI job with no previous runs and worked accordingly

Merging to main! I will update the docs and remove the github_repo_token input and then create release v1.2

Updated the action on the marketplace to v1.2 and updated all the docs/stale code. Thanks for all the work on this @ThomasMonnier! The action is much cleaner and runs faster.

Thanks a lot @Stevedow99 for having merged these contributions ! Happy to help.
I will delete my forked repository and my action on the marketplace in the next hours.


Persist incident cancelling data

Description
Use model.Incident instead of using function parameters alone, and persist the description of the cancellation in the database.

@flucas97 ta com conflito no internal/commands/cancel.go

@flucas97 ta com conflito no internal/commands/cancel.go

fixed


Api Docs of 3.4 miss main-nav bar: unable to use now

I know 3.4 is old, so not sure it is still build...
But current online version: https://qgis.org/api/3.4/ is unusable because it lacks the div 'main-nav' with which you can navigate into classes etc en search for something:

For 3.12 for example it looks like:

@jef-n Not sure if it is still possible to build/fix this?

I see the top nav bar for both 3.4 and 3.12 api docs:

The docs result generated respectively on Jan 19 2020 and on Mar 21 2020.

Ah, sorry, yes. @jef-n fixed this within a couple of minutes. I forgot to close this one. Thanks for reminding.


Reword and reformat "Breaking changes" page

Reformat so that it's more clear that the two issues under v1.10 belong to that release.

Deploy preview processing.
Built with commit b080146bac922cabdb5af28ce82fe048277de827
https://app.netlify.com/sites/chief-executive-officer-bear-63404/deploys/581e580b6686747371f158c3

Thanks @thaJeztah ! :)


Override Controller

Describe the bug
If I Want Override Controller in my new menu, my new menu get label error
To Reproduce
Steps to reproduce the behavior:

Create Table
Create Crud Management
Create New Controller(I follow step from tutorial)
Copy Name newControoler to Advanced Setting(Controoler Name) i naming App\Http\Controller\NewController

Expected behavior
i can override controller
Desktop (please complete the following information):

OS:Windows 10
Browser Firefox
Version 95

Could you share the error please ? with screenshot is better too
Thank you

Error After I follow over ride controller from documentation

why closed ?

You closed it by yourself sir, why asking others instead 🧐

lol sorry sir :D

How to close this issue, im some problem into override controller

follow tutorial one on one and dont typo
Pada tanggal Kam, 17 Feb 2022 05.01, Suseno @.***>
menulis:

How to close this issue, im some problem into override controller
—
Reply to this email directly, view it on GitHub
https://github.com/uasoft-indonesia/badaso/issues/504#issuecomment-1042352621,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH3XZFM3YKZMQRT3RR2JBIDU3QNB5ANCNFSM5KRUXY6A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you modified the open/close state.Message
ID: @.***>


Document process for creating a new CT log shard

Description

To rotate a log, the following needs to occur:

Spin up a new Trillian instance (log server and signer) and MySQL database

The log should use the same signing key unless there was a compromise. If there was a compromise, the log's verification key must first be distributed to clients via TUF
The log's prefix will be changed to the current year. Currently, the prefix is test. For the first sharding, it will either 2022

Verify the log's health
Update Fulcio's configuration to point to the new log
Roll out Fulcio. Fulcio will not dual write to both logs. One instance of Fulcio may write to a different log than another instance as it's rolling out, but this is not an issue.
Freeze the old log

This is a simpler process than Rekor, since we don't maintain a virtual index in front of all shards. Our tooling does not access the logs directly, it simply verifies SCTs on signing and verification. As long as the log signing key does not change, SCTs will continue to be verified without issue for all shards.

Also should add a prober pinging ct/v1/get-sth for each log shard

Chatted with @k4leung4 about the process for sharding a CT log. To summarize, we need to add support for creating an arbitrary number of CT log instances, where each will have its own Trillian tree and configmap.
One option is to create separate GCP instances for the database that backs Trillian. I opened up an issue to discuss separating Rekor and the CT log's infrastructure first. I'd be fine with having all of the CT logs' trees in a single DB, but I would prefer it be isolated from Rekor.
Assuming any Terraform changes are done outside of the scope of this work, we will focus on updating the Helm configurations. We will need to:

Add support to run an arbitrary number of CT log instances that share the same Trillian backend (Hopefully we can follow an example from the sharding work)
Handle ingress routing - Each log will have its own prefix, e.g ctfe.sigstore.dev/2022, ctfe.sigstore.dev/2023

For freezing the log, looks like we've already set up infrastructure to do this, which is documented in the sharding playbook and uses the updatetree job.

I'd be happy to help with this effort if help is needed :)
Since this issue is under Fulcio, I'd like to clarify the discussion about having multiple CT Log instances and 'ingress routing'. I'm not clear if we're talking about adding support for a single Fulcio to be able to write to multiple CTLogs based on some criteria (hence the question about ingress routing). Bear with me while I get my understanding of what's left to do :)
Today the CTLog endpoint is a flag like:
--ct-log-url=http://ctlog.ctlog-system.svc/sigstorescaffolding

Question: Are we expecting (as part of this effort or in the future to be able to write to multiple CTLogs?). Just trying to make sure I understand if this requires changes to Fulcio or not.
For the 'ingress routing', is that different from the flag above? As in, any Fulcio instance has 1:1 to a CTLog, or again are there some changes required to Fulcio?
But, from the comment above: https://github.com/sigstore/fulcio/issues/589#issuecomment-1144122837
I think we are saying that "we" as in Sigstore needs to be able to handle operating / writing to multiple CT Log instances. If we have multiple Fulcio instances running at the same time, each of them would still be writing 1:1 to a CT Log instance. Is that correct?

That all sounds great, thanks! That's how I roughly understood things, but got confused by some comment in some other bug, so just wanted to double-check :)
The one other thing (that's probably discussed elsewhere) is the "reverse" of this. When Fulcio Cert rotates, the new cert must be added to the trusted certs on the CT Log side. I looked quickly, but didn't see an issue for this, is there one for it somewhere?
read-only mode for the logs == 'freeze' of the trillian, or is there a knob for that in CTLog also?

Re: separate database, if we do that, then we'll basically have 1:1 of
Fulcio - CTLog - Trillian - mysql
So all four get operated as a "single entity"?
If so, kneejerk response is that I think it makes things easier to operate.

The one other thing (that's probably discussed elsewhere) is the "reverse" of this. When Fulcio Cert rotates, the new cert must be added to the trusted certs on the CT Log side. I looked quickly, but didn't see an issue for this, is there one for it somewhere?

That is a good question. Right now, the root is automatically fetched when createctconfig is run. https://github.com/haydentherapper/scaffolding/blob/079be7cd54dd47bb0df9ac1af3193f765986f3bc/cmd/ctlog/createctconfig/main.go#L106
Can it be rerun to fetch the latest root? If not, can you create an issue for this?

read-only mode for the logs == 'freeze' of the trillian, or is there a knob for that in CTLog also?

It should be the same configuration since CT is backed by Trillian.

So all four get operated as a "single entity"?

Yes, that would be the plan. Right now, the same Trillian (and mysql) instance operates Rekor and CT. There's an open conversation right now if we will take on the work of separating the two before GA, but I think we can if we set up the CT log sharding to use separate Trillian/mysql instances.

Yeah, I remember that code :) That's part of the reason I was asking. In particular if we have the 1:1 stack that gets operated as a single entity, then we'll have a case where we might need to rotate a Fulcio key. Would that trigger a new Stack creation (new ctlog, trillian, etc.), or merely we upgrade the cert for Fulcio and roll it out. If we do that, then we need to add that new cert of Fulcio to CTLog roots PEM. Current code works great but assumes there's only one. I think if we rotate they and launch new instances then we have to add the new one so ctlog will accept from both old and new, and then eventually we'll need to remove the old one once the roll out completes, I think.
So, I think the question really is: If we need to rotate fulcio, will that create a new stack or not?
If not, we'll need to do some work in createctconfig as well as add a cleanup step after fulcio rollout completes.

So, I think the question really is: If we need to rotate fulcio, will that create a new stack or not?

I would say no. I separate the two - Fulcio cert would be rotated due to expiration for example, which might happen mid year, or in an emergency due to compromise. The log sharding will happen yearly to keep size down (or in the event of a compromise of the CT log key).
I think we need to do the work you specified in the ticket. Maybe allowing for you to manually specify the root certificates in addition to fetching the certificate from Fulcio? Something like:

Create new Fulcio root
Manual job to append Fulcio root to trusted CT log roots
Change configuration for Fulcio, redeploy with new root
Manual job to re-sync Fulcio root to CT log (removing the old root)

Is that doable?

Something to mention, the root rotation will be very infrequent. Fulcio is configured with an intermediate certificate - that might change if we change the signing key for fulcio, but the intermediate doesn’t have to be distributed to the log. Still need a mechanism in place, but it’ll be used not very often.

Haven’t dug into this much to see if it’s useful, but there is some configuration options for limiting when logs will accept entires https://github.com/google/certificate-transparency-go/blob/master/trillian/docs/Operation.md#temporal-sharding

Yeah, I was looking at:
https://letsencrypt.org/2019/11/20/how-le-runs-ct-logs.html
Which had links to here:
https://www.venafi.com/blog/how-temporal-sharding-helps-ease-challenge-growing-log-scale
https://www.digicert.com/blog/scaling-certificate-transparency-logs-temporal-sharding
For some prior art as well.

Sounds good to me, I'll tackle next week, getting late here🤣
On Fri, Aug 12, 2022, 17:19 Hayden B @.***> wrote:

So, I think the question really is: If we need to rotate fulcio, will that
create a new stack or not?
I would say no. I separate the two - Fulcio cert would be rotated due to
expiration for example, which might happen mid year, or in an emergency due
to compromise. The log sharding will happen yearly to keep size down (or in
the event of a compromise of the CT log key).
I think we need to do the work you specified in the ticket. Maybe allowing
for you to manually specify the root certificates in addition to fetching
the certificate from Fulcio? Something like:

Create new Fulcio root
Manual job to append Fulcio root to trusted CT log roots
Change configuration for Fulcio, redeploy with new root
Manual job to re-sync Fulcio root to CT log (removing the old root)

Is that doable?
—
Reply to this email directly, view it on GitHub
https://github.com/sigstore/fulcio/issues/589#issuecomment-1213162374,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACWB45G7AZ334OXIZSRMN4TVYZMOFANCNFSM5WDGGGZA
.
You are receiving this because you were mentioned.Message ID:
@.***>


NetSuite - "Subsidiary" shows while the connection is syncs for the first time

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.26-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4901046&group_by=cases:section_id&group_order=asc&group_id=314239
Issue reported by: Applause - Internal Team
Action Performed:

Open the app
Log in with a new Gmail account
Click on FAB - New workspace
Enable "Accounting" in the "More features" page.
Navigate to "Accounting"
Connect to NetSuite and upgrade the workspace to Control when asked
Wait for the sync to finish

Expected Result:
"Subsidiary" should only show after the sync finished
Actual Result:
"Subsidiary" shows while the connection syncs for the first time
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/user-attachments/assets/464139e1-70a0-4d78-85ec-f0570e962eab
View all open jobs on GitHub

@garrettmknight  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-control

@Nodebrute Thank you for the proposal. While the observation mentioned in your proposal's RCA is not wrong, when it comes to the solution I think it's best to only hide integrationSpecificMenuItems specific sections if there's no information to be displayed for a specific section instead of hiding all sections based on isSyncInProgress.
The reasoning would be that if let's say isSyncInProgress is false (sync finished) but there's no data returned for that specific section -> then the UI will still show the empty Subsidiary section in our case.

@nyomanjyotisa's proposal looks good to me. The RCA is correct and the proposed solution fixes the issue as per the Expected result, following the code pattern we already use in the SageIntacct case.
PR Note: We should keep this within scope and only fix the NetSuite - Subsidiary issue by using the !netSuiteSubsidiaryList?.length ? {} : {... check, similar (but reverse) to what is used in the onPress to return early (see SageIntacct case model).

additionally, we can do the same for Xero Organization Name

cc @  What do you think about the above PR Note regarding keeping the fix for this issue within scope, do you agree or think we should extend the fix to handle the Xero - Organization case as well ?
🎀👀🎀 C+ reviewed

Currently discussing (scroll down from this comment) what to do with NetSuite related issues when it comes to people who don't have credentials, this includes all Contributors and all but one C+.
Quoting:

I could argue that the change / fix is obvious to the point where one wouldn't even need the credentials to test - but I understand that that's not not how we do things.
If I don't get access to the credentials soon (this week), I guess there's no other option then to have you take over.

C+ w/ Netsuite credentials said:
And contributors will not have access to these credentials anytime soon

^ Not sure what happens to the contributors which posted good proposals on these issues given they will never have the credentials to test the changes if they are assigned and have to complete their PR Author Checklist :think0:

cc @Beamanator for context.

@ikevin127 - honestly i think the solution is straightforward enough to also apply the Xero fix

⚠ Automation failed here -> this should be on [HOLD for Payment 2024-09-20] according to 5 days ago's production deploy from https://github.com/Expensify/App/pull/48519#issuecomment-2350595614.
cc @garrettmknight

Payment Summary:

Contributor: @nyomanjyotisa $250 via upwork
Reveiwer: @ikevin127 $250 via upwork

@ikevin127 can you complete the checklist?

[x]  [@ikevin127] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/44038.
[x]  [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/44038/files#r1772405331.
[x]  [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A.
[x]  [@ikevin127] Determine if we should create a regression test for this bug.
[x]  [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Enable "Accounting" in the "More features" page of a Workspace.
Navigate to the "Accounting" page.
Connect to NetSuite and upgrade the workspace to Control when asked.
Verify that 'Subsidiary' does not show while the connection is synchronizing for the first time, but only after the connection has successfully synced.

Do we agree 👍 or 👎.

BZ Checklist completed, awaiting for BZ team member to close the issue.

Assigning back to @garrettmknight for payment 🙏


can not validate url with hyphen in subdomain name

This url is treated as a false url
http://ggsipu-college-ranking.techbits.co.in/

This is a blocker for me, so I'm going to submit a pr later.

Fixed, thanks to @nkcraddock


Open PDF links in a new tab instead of the current one

Attach (recommended) or Link to PDF file here:
Configuration:

Web browser and its version: Firefox 109
Operating system and its version: Windows 10
PDF.js version: latest
Is a browser extension: no

Steps to reproduce the problem:

Open a PDF with a link
Click on the link

What is the expected behavior? (add screenshot)
It is preferable that the link opens in a new tab.
What went wrong? (add screenshot)
The link is opened in the current tab, so the PDF is lost.
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

The link target is configurable, hence you can achieve this by setting pdfjs.externalLinkTarget = 2 in about:config.

I think 2 should be the default value

It's very likely a matter of taste.
PDF.js behaves here like a normal website and you can ctrl+click to open in a new tab.
I'm not sure at all it'd be good idea in general to have different behaviours.


Update neovim_distros with OVIWrite

OVIWrite is a NVIM distro for writers and writing.

@MiragianCycle  - Thank you for your contribution.  I made one small syntax change.  Reinstalled nvims and then OVIWrite.  No issues.

@MiragianCycle - Thank you for your contribution. I made one small syntax change. Reinstalled nvims and then OVIWrite. No issues.

Thank you for accepting it!


Make getFlagFromCache method public

Motivation
I'm running go-feature-flags in my API and in my health endpoint I'd like to return all the flags that I have configured and the current version in cache. I see that the getFlagFromCache method could give me all the information that I need but it's currently private. Is it ok if we made it public? Happy to send a PR to address that.

Hey @marcosnils this is a good idea and I kinda need it too for one of my projects 😄
I am not sure that putting getFlagFromCache as public will be enough, but if you want to have a look on how to do that you can make a proposal.

@marcosnils I have seen your PR and this is not what I had in mind when I first checked this issue.
With this solution, you have to call the GetFlagFromCache function for all the flags one by one to get the value.
Is it what you wanted? I was also thinking about a function that returns the state of the cache at a specific moment.

Is it what you wanted?

This is what I need in the immediate term, yes. I'm  that creating a new method to retrieve all flags would be more useful. I'll make a quick change for this and update the PR :raised_hands:

:wave: just made a new commit that allows all flags from cache to be exposed. Shall we continue the discussion on the PR?

@thomaspoignant. gente ping!

Sorry @marcosnils it was a crazy week, let me check that on Monday if it is ok for you?


Error [ERR_REQUIRE_ESM]: require() of ES Module is not supported.

Hello! I stumbled upon this package which perfectly fits what I'm looking for, however I'm getting an error while using it.
Here is my index.js:
import express from 'express'
import { router } from 'express-file-routing'
import path from 'path'

const app = express()

app.use('/api', router({ directory: path.join(process.cwd(), 'routes') }))

app.listen(1337)

Here is my folder structure:
index.js
package.json
routes/
  users.js
  spaces.js
...

Finally, here is an example of a route file:
export function get(req, res) {
  res.send('gm world')
}

Here is the full error:
<path_to_project>\node_modules\express-file-routing\dist\index.js:157
        const exports = require(path__default["default"].join(file.path, file.name));
                        ^

Error [ERR_REQUIRE_ESM]: require() of ES Module <path_to_project>\routes\spaces.js from <path_to_project>\node_modules\express-file-routing\dist\index.js not supported.
Instead change the require of spaces.js in <path_to_project>\node_modules\express-file-routing\dist\index.js to a dynamic import() which is available in all CommonJS modules.
    at generateRoutes (<path_to_project>\node_modules\express-file-routing\dist\index.js:157:25)
    at createRouter (<path_to_project>\node_modules\express-file-routing\dist\index.js:182:20)
    at router (<path_to_project>\node_modules\express-file-routing\dist\index.js:211:12)
    at file:///<path_to_project>/index.js:7:17 {
  code: 'ERR_REQUIRE_ESM'
}

Node.js v18.16.0

It seems that the package is trying to require() the routes, however they are using ESM. Is this an incompatibility with plain JavaScript? I see that the examples in README.md are using TypeScript, is there a possibility this can be used with regular JavaScript and ESM as well?

hey @BluDood, thank you for filing an issue. You are right, currently, ESM is not supported due to internal use of synchronous require() instead of async await import().
There is a PR #18 wip that might be merged as part of v3 but also introduces a breaking change in the package's API.
// currently:
app.use(router())

// new draft (v3):
app.use(await router())

For now, you might take some inspiration from this boilerplate. Alternatively, there is a buggy, unstable v3 beta on npm that can be installed via:
npm install express-file-routing@beta

But it probably needs some work to get it running. If you like to contribute and speed up the process, feel free to take a look at the v3 branch of this repo and try to get it stable. There shouldn't be too much work to do left.

Thanks for the reply! I actually went back to commonjs for this project, as luckily none of the dependencies had any issues with it. It works great now, thanks!

Hello again! I've decided to work on this a bit now, and got it working fine. However, I'm not that experienced with TypeScript so I'll have to look a bit more into that. I'll post the fork here tomorrow with the changes, and from there I can do a pull request if you'd like.
Sorry for any confusion I may have caused, I was just a bit burnt out yesterday and decided to go with the easiest option.

hey @BluDood, thank you for putting in the work. Looking forward to it!

Hello @matthiaaas!
I have now created a fork with the changes: BluDood/express-file-routing@v3
This fixes compatibility with ESM, however it seems to then break CJS compatibility because of the wildcard feature, since the "default" export of a CJS module looks like this:
[Module: null prototype] {
  default: { get: [Function: get] },
  get: [Function: get]
}

And since the check only checks if default is undefined, Express throws an error since it received an object instead of a function. I changed exports.default.default to exports.default because ES modules can provide the default export as a function, while also having other named exports.
Other changes I did:

package.json: Changed type to module
rollup.config.js Changed the output format to es
src/lib.ts: Added file:// to the start of import paths, since that's how import() works apparently. Tested working on Windows and Debian
src/router.ts: Set the wildcard export to export.default instead of export.default.default
src/types.ts: Removed the & type from Exports because it was causing an error. I don't know much TypeScript, but this is what I managed to get working

This now works perfectly fine with ESM enabled for vanilla JavaScript, however it does break compatibility with CJS. This can probably be fixed with some changes to the types I had to remove, but I have very limited TypeScript knowledge.
Let me know if I should make a pull request, or if I should change anything first!

Thanks @BluDood, feel free to make a PR so we can discuss the changes over there.

#27 created :)

Merged it and fixed cjs compatibility. You can test the latest version with npm install express-file-routing@beta. Let me know if it works. Will work on this now to ship v3 soon so feedback is appreciated!

That's great! I'll be back in about an hour, then I'll test it both with CJS and ESM :)

Hey @matthiaaas, I've tested it with both ESM and CJS and here are my results:

CommonJS: It works fine, with one quirk that the "default" export for a wildcard route has to be default.default like so:

module.exports = {
  default: async (req, res) => {
    if (req.method !== 'GET') return res.status(405)

    return res.json({ hello: 'world' })
  }
}

ESM:
I get this error (Windows):

Error [ERR_UNSUPPORTED_ESM_URL_SCHEME]: Only URLs with a scheme in: file and data are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'c:'

As the error says, it seems that ES modules imported with an absolute path must start with file://. I implemented this fix here, however it seems you later removed it here. I suppose it worked without the fix if you're on a different platform than Windows, however adding file:// at the start still worked fine on Debian (WSL) for me, and also enables Windows support.
I hope we can fix this!

What beta version are you on? The latest should be beta.4

Also thanks. I will put file:// in front for ESM imports. For CJS, this has to be removed to work.

Alright, so the latest beta version beta.5 should cover all the fixes. Let me know if that works for you too. Thank you for the effort @BluDood.

Thanks! I will try it as soon as I can, and reply back with the results :)

After some testing, it works great now! Both CommonJS and ESM are compatible, and they both work as expected. Thanks for the help!

Perfect, thank you for your efforts @BluDood. I might do some minor changes and then publish v3 as stable and let you know. Thanks!


Fix MergeRollupTask uploading segments not updating their metadata

Will have test coverage in MergeRollupTask integration tests.

Codecov Report

Merging #7289 (5bea197) into master (6fb51d2) will decrease coverage by 2.37%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7289      +/-   ##
============================================
- Coverage     71.33%   68.96%   -2.38%
+ Complexity     3363     3185     -178
============================================
  Files          1505     1111     -394
  Lines         74224    52346   -21878
  Branches      10733     7812    -2921
============================================
- Hits          52950    36102   -16848
+ Misses        17678    13669    -4009
+ Partials       3596     2575    -1021

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
68.96% <ø> (-0.06%)
:arrow_down:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d40e2d3...5bea197. Read the comment docs.


Prototype #1: Moving Blocks

We'll focus our first prototype on the riskiest option for our homepage - grouping buildings by category with our animated block view. To complete the experience, we'll also have examples of our individual building page and a Ward-specific page.
Storyboard:
design-1.rotated.pdf
Mockup tool:
https://moqups.com/ (check your email for an invite to the project)
Roles (can be partially overlapping)

Box Page Lead: In charge of the main homepage view
Building Page Lead: In charge of assembling the building view
Component Maker: Makes custom graphs, icons, and components for the page leads to use in their views. Likely someone with moderate graphic design experience.
Icon/Asset downloader: Hunts down stock photos and icons in coordination with the component maker.
Data Checker: Looks up relevant data from our data sources to make sure that components look realistic - e.g. number of buildings in a Ward, min/max market rent in the city, etc.
Stitcher: Coordinates connecting all the views into one seamless experience for the user

Interested in reading about the process? Here's the chapter from the book Sprint, which I've used as a guide for our entire design process.
Sprint-prototype-chapter.pdf
Conventions:

Use gray to indicate elements that will be clickable/selectable in the final design but that are not included in the mockup (e.g. we may only mock up 2 out of 10 or so filtering options)
Replace hover options with click - we will direct test users to these places during demos
The goal of the mockup is to feel real - no Lorum Ipsum, real looking data, clean alignment of objects.

Realistic rent data background info:
We have two sources, which have very different methodologies and therefore values.

Zillow is based on listings in the market, so is more reflective of unsubsidized market rent, but doesn't normalize for home size and includes single family buildings. Bedroom and square foot normalized values are only available for a few neighborhoods (not enough data)
The American Community Survey has 5-year averages of what people actually pay for rent, so those are driven down by including subsidized units.

Zillow ranges from $1,273 to $6,553 as the total min max across 2010 and 2016 estimates across all neighborhoods in DC
ACS ranges from $254 to "$2000+" (exact amount over $2,000 is suppressed) across their 2009 and 2015 5-year estimates.
Let me know what neighborhood you want and I can get you more specific numbers; figuring out how to interpret these rent data is another task for the#datateam
Thomas' question via email:
I'm working on getting Joanne and Julia some close-to-real numbers for the first mockup. I'll start with the Preservation Catalog for much of it. Julia requested some info on market rent and rent costs for individual buildings that I didn't immediately see in the catalog. For now, assuming I could find market rents on something like Zillow, but is there a data source that we will eventually be using for unit costs and/or market rent?

Thanks, Neal! So far we have a Ward level from our mockup instead of
the neighborhood. We have Ward 5 at the moment, so if possible to get the
5-year rent data for that Ward that would be helpful. I also just mentioned
in an email that Joanne is working on the property view for Friendship
Terrace so we would ideally have the 5-year data for that property.
Thanks!
Thomas
On Thu, Jan 5, 2017 at 12:27 PM, Neal Humphrey<EMAIL_ADDRESS>wrote:

Realistic rent data background info:
We have two sources, which have very different methodologies and therefore
values.

Zillow is based on listings in the market, so is more reflective of
unsubsidized market rent, but doesn't normalize for home size and includes
single family buildings. Bedroom and square foot normalized values are only
available for a few neighborhoods (not enough data)
The American Community Survey has 5-year averages of what people
actually pay for rent, so those are driven down by including subsidized
units.

Zillow ranges from $1,273 to $6,553 as the total min max across 2010 and
2016 estimates across all neighborhoods in DC
ACS ranges from $254 to "$2000+" (exact amount over $2,000 is suppressed)
across their 2009 and 2015 5-year estimates.
Let me know what neighborhood you want and I can get you more specific
numbers; figuring out how to interpret these rent data is another task for
the#datateam
Thomas' question via email:
I'm working on getting Joanne and Julia some close-to-real numbers for the
first mockup. I'll start with the Preservation Catalog for much of it.
Julia requested some info on market rent and rent costs for individual
buildings that I didn't immediately see in the catalog. For now, assuming I
could find market rents on something like Zillow, but is there a data
source that we will eventually be using for unit costs and/or market rent?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/codefordc/housing-insights/issues/48#issuecomment-270703773,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOQ6Dus2JaMOuA4pejFd1bCP-G5wa44Sks5rPSgWgaJpZM4LXIx0
.

The source data for rent that we are starting with is from the American Community Survey, so for now I'm providing that "as-is", which is for the Census Tract.
Here is the full list of data for Friendship Terrace, copied from Thomas's email plus the additional fields I dug up (putting here to make available to everyone):
Friendship Terrace - 4201 Butterworth Place NW, Washington DC.
BuildingDetailedReport - pdf
Building info:

type of ownership (profit vs non profit) Nonprofit
management name + contact info Episcopal Church Home, Friendship, Inc. - 4201 Butterworth Place NW, Washington DC.
number of units - 199
break down of units by number of bedrooms - NA
subsidy history (timeline of when subsidies expire) 01/01/2023 (first ending) 09/01/2045 (last ending
reac inspection score - 93c (2013)
reac inspection history - see pdf

Neighborhood-level information:

number of metros and bus routes within x miles (for now x can be 0.5 miles) - 13 number of metros and bus routes withing .5 miles. They are: Tenleytown Metro (.3 miles), 30N, 30S, 31, 33, S2 (.2 miles), 92, H2, H3, H4, M4, W45, W47 (.3 miles)

number of subsidized units within x miles - 1 subsidized building within 1 mile, 15 units (Kennedy Institute)

average market rent - median rent was $1,358 in 2009 and "$2,000+" in 2014 (47% increase) per the American Community Survey. Note they suppress the amount above $2,000

median income: Average family income in Census Tract, 2014: $218,708  (Neighborhood Info)

% residents at 50% AMI - substitute Poverty Rate, 2015: 3.6% (+- 3.2% error margin), 2012: 5.9% (+- 2.8 % error margin)

% unemployment - Unemployment Rate 2014: 2.4%

Building permits: There were 61 building permits within 0.25 miles issued in the last 3 months (very very roughly calculated). See the tab-delimited file dump here.

PUD zoning applications filed: Change this to "Active PUD Applications" for now.  Go to this page. Type 3E into the search box and click ANC active cases (they don't provide a direct link to search results). There are 22 active PUD cases in the ANC. This is a good example of a PUD at 4700 Wisconsin, just a couple blocks away - you can put this one at the top of the list.

breakdown of residents: we don't have, might not be available....

Much appreciated! This looks great, and hopefully includes everything that
we need for the building view.
-Thomas
On Mon, Jan 9, 2017 at 12:48 PM, Neal Humphrey<EMAIL_ADDRESS>wrote:

The source data for rent that we are starting with is from the American
Community Survey, so for now I'm providing that "as-is", which is for the
Census Tract.
Here is the full list of data for Friendship Terrace, copied from Thomas's
email plus the additional fields I dug up (putting here to make available
to everyone):
Friendship Terrace - 4201 Butterworth Place NW, Washington DC.
BuildingDetailedReport - pdf
https://github.com/codefordc/housing-insights/files/694226/NL000120-detailed.1.pdf
Building info:

type of ownership (profit vs non profit) Nonprofit
management name + contact info Episcopal Church Home, Friendship,
Inc. - 4201 Butterworth Place NW, Washington DC.
number of units - 199
break down of units by number of bedrooms - NA
subsidy history (timeline of when subsidies expire) 01/01/2023
(first ending) 09/01/2045 (last ending
reac inspection score - 93c (2013)
reac inspection history - see pdf

Neighborhood-level information:

number of metros and bus routes within x miles (for now x can be 0.5
miles) - 13 number of metros and bus routes withing .5 miles. They are:
Tenleytown Metro (.3 miles), 30N, 30S, 31, 33, S2 (.2 miles), 92, H2, H3,
H4, M4, W45, W47 (.3 miles)
number of subsidized units within x miles - 1 subsidized building
within 1 mile, 15 units (Kennedy Institute)
average market rent - median rent was $1,358 in 2009 and "$2,000+"
in 2014 (47% increase) per the American Community Survey. Note they
suppress the amount above $2,000
median income: Average family income in Census Tract, 2014: $218,708 (Neighborhood
Info
http://www.neighborhoodinfodc.org/nclusters/Nbr_prof_clusb11.html)
% residents at 50% AMI - substitute Poverty Rate, 2015: 3.6% (+- 3.2%
error margin), 2012: 5.9% (+- 2.8 % error margin)
% unemployment - Unemployment Rate 2014: 2.4%
Building permits: There were 61 building permits within 0.25 miles
issued in the last 3 months (very very roughly calculated). See the
tab-delimited file dump here.
PUD zoning applications filed: Change this to "Active PUD
Applications" for now. Go to this page
https://app.dcoz.dc.gov/Content/Search/Search.aspx. Type 3E into the
search box and click ANC active cases (they don't provide a direct link to
search results). There are 22 active PUD cases in the ANC. This is a good
example of a PUD at 4700 Wisconsin
https://app.dcoz.dc.gov/Content/Search/ViewCaseReport.aspx?case_id=18839,
just a couple blocks away - you can put this one at the top of the list.
breakdown of residents: we don't have, might not be available....
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/codefordc/housing-insights/issues/48#issuecomment-271353649,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOQ6DtTyiG_haA8biqWq0qaVhXtLQiKEks5rQnL7gaJpZM4LXIx0
.

Hey team,
For us to continue to use and refine, a draft style guide for colors and fonts across prototype pages. Happy to make changes as needed!
https://app.frontify.com/d/bzmigF5Rncdy/housing-insights-style-guide

Yay closing this issue! Will migrate some of the resource type stuff over to the next one as needed.


Update serviceConsoleCaseTimerWrapperController.js

in doInit replaced the workspaceAPI.getFocusedTabInfo() call with workspaceAPI.getEnclosingTabId
this fixes the issue with not properly pausing / saving Session Times when multiple tabs are opened in parallel.

@tepp0f3l FYI

The code changes detailed in here are part of the wider changes to the app that are now merged into the master branch. Thanks for your contribution!


Multi-call to claim all rewards at once or individually

Job to be Done
Claim All -- When I'm claiming reward tokens in the app, I want to be able to claim all my pending rewards at once, so I don't need to claim one by one and waste time and pay more gas
Claim Individually -- When I'm claiming reward tokens in the app, I want to be able to claim my pending rewards one at a time, so I don't need to claim everything at once if I don't want to at that time

@masonchain are the options:

The actual design has not been finalized however, this is up to the app team.
Will be slotted into the existing design with 1-off claims while supporting a 'Claim All'.


[ios] Image resizeMode prop is broken for v0.11

'contain' mode doesn't work for remote images at all (defaultSource is shown always in this case). 'cover' shows stretched picture! Very strange, it works well for v0.10.1

This happens only if defaultSource is defined. Without defaultSource 'contain' works like in previous versions.

Same problem.


helm: change configuration templates

:tada: This PR is included in version 0.11.0-next.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Turning manual gas valves on and off has no feedback

Description
You get zero state indication.

Not really a fix but added a funny sound when you turn them.  #5193


Add documentation for AdPartner bid adapter

https://github.com/prebid/Prebid.js/pull/5196

released with 3.22


WebGL is not supported.

Good morning! Im trying to install app, but i have some errors:
Failed to load extension from: ~/com.and.games505.TerrariaPaid.android
WebGL is not supported

{
  "app": {
    "background": {
      "page": "app_main.html"
    }
  },
  "arc_metadata": {
    "apkList": [
      "custom-android-release-1400197.apk"
    ],
    "enableExternalDirectory": false,
    "formFactor": "phone",
    "name": "com.and.games505.TerrariaPaid",
    "orientation": "portrait",
    "packageName": "com.and.games505.TerrariaPaid",
    "useGoogleContactsSyncAdapter": false,
    "usePlayServices": [
      "gcm"
    ]
  },
  "default_locale": "en",
  "icons": {
    "16": "icon.png",
    "128": "icon.png"
  },
  "import": [
    {
      "id": "mfaihdlpglflfgpfjcifdjdjcckigekc"
    }
  ],
  "manifest_version": 2,
  "name": "__MSG_extName__",
  "oauth2": {
    "client_id": "133701689125-jj0hr4gb0ff4ulsbrn0uk2i4th946d4c.apps.googleusercontent.com",
    "scopes": []
  },
  "offline_enabled": true,
  "permissions": [
    "gcm",
    {
      "socket": [
        "tcp-connect",
        "tcp-listen",
        "udp-bind",
        "udp-send-to",
        "resolve-host"
      ]
    },
    "unlimitedStorage",
    "notifications",
    "clipboardRead",
    {
      "fileSystem": [
        "write"
      ]
    },
    "https://clients2.google.com/",
    "videoCapture",
    "clipboardWrite",
    "identity.email",
    "alarms",
    "storage",
    "identity",
    "audioCapture"
  ],
  "requirements": {
    "3D": {
      "features": [
        "webgl"
      ]
    }
  },
  "update_url": "https://localhost",
  "version": "1337"
}
Retry

Help me please!

Ok, solved, it was my system error.

I get the same error. How did you fix it?

I found how to do that. I enabled gpu hardware acceleration in my browser and webgl runs well now.

Enable hardware acceleration in settings....!

I got same error and enabling hardware acceleration does not help

Doesn't it work without hardware acceleration? I would like to run this on a remote server not supporting hardware acceleration...


RSA Key in release notes are out of date.

Background
Release notes using an old RSA Key in verification instructions.
Your environment
Not relevant.
Steps to reproduce
gpg --verify manifest-roasbeef-v0.13.0-beta.sig manifest-v0.13.0-beta.txt`

Expected behaviour
Output (based on release notes)
gpg: Signature made Wed Sep 30 17:35:20 2020 PDT
gpg:                using RSA key 4AB7F8DA6FAEBB3B70B1F903BC13F65E2DC84465
gpg: Good signature from "Olaoluwa Osuntokun<EMAIL_ADDRESS>[ultimate]

Actual behaviour
Output:
gpg: Signature made Thu 17 Jun 2021 17:48:09 BST
gpg:                using RSA key 60A1FA7DA5BFF08BDCBBE7903BBD59E99B280306
gpg: Good signature from "Olaoluwa Osuntokun<EMAIL_ADDRESS>[unknown]

The key is different, but the signature is newer. Also, older releases have this newer key.

Fixed! Looks like it was left over from the initial template our automated system puts up, thanks for pointing this out!

@Roasbeef it happened again with 1.13.1-beta
Also, is bitconner's sig supposed to be there? raspiblitz's build_sdcard script seems to prefer his.


chore: use exact version for deps when resolving local path deps []

In our colorful coin demo project, I observer the following issue:
We updated to the latest alpha version of the SDK but under the hood it resolves a deeper dependency from a month ago. This is since the range defined by the prefix ^ doesn't function as expected for alpha releases. In the example below it resolved ^0.0.2-alpha.15 to 0.0.2-dev-20240114T223125.0 which contains an outdated set of INCOMING_EVENTS and thus logged warnings and caused errors in the application.

https://github.com/lerna/lerna/tree/main/libs/commands/version#--exact

A few questions:

Could you explain the situation here? Locally, the packages in the monorepo reference each other via file paths, not versions ( see here for example). So I'm not sure as it would pull an errant version as it just uses the one in the monorepo.
--exact doesn't seem to be a valid option to lerna version/publish. I haven't tried myself but curious what it does or if it gets passed into another command.
We are using GH Actions now in the sdk repo, so we'll need to update the lerna commands in the action files here instead if we go forward with the change

Thanks @ely for the extensive feedback!

In the screenshot you can see that the colorful coin demo depends on @contentful/experience-builder which under the hood requires the<EMAIL_ADDRESS>This version range is then resolved by npm to a temporary dev release of the package as we don't enforce the exact version. Especially for the alpha releases, we should make sure that all deps are on the latest version. In the package.json, I saw that we're using local path specifiers which is resolved during lerna version so that later when someone installs one of the packages, they don't point to a non-existing local sibling package. So file://... will be replaced by a proper version for that. Unfortunately, the documentation by lerna is pretty sparse on this behavior but there is this blog post where the behavior is described like this:

A word on releasing
All local npm local path specifiers are temporarily resolved to the > version range of the package they point to before being packed into the tarball.

I can see here in the docs and in this test that the option --exact is supported and tested.

Thanks for the callout. Will update there as well!

A few questions:

Could you explain the situation here? Locally, the packages in the monorepo reference each other via file paths, not versions ( see here for example). So I'm not sure as it would pull an errant version as it just uses the one in the monorepo.
--exact doesn't seem to be a valid option to lerna version/publish. I haven't tried myself but curious what it does or if it gets passed into another command.
We are using GH Actions now in the sdk repo, so we'll need to update the lerna commands in the action files here instead if we go forward with the change

Thanks @ely for the extensive feedback!

In the screenshot you can see that the colorful coin demo depends on @contentful/experience-builder which under the hood requires the<EMAIL_ADDRESS>This version range is then resolved by npm to a temporary dev release of the package as we don't enforce the exact version. Especially for the alpha releases, we should make sure that all deps are on the latest version. In the package.json, I saw that we're using local path specifiers which is resolved during lerna version so that later when someone installs one of the packages, they don't point to a non-existing local sibling package. So file://... will be replaced by a proper version for that. Unfortunately, the documentation by lerna is pretty sparse on this behavior but there is this blog post where the behavior is described like this:

A word on releasing
All local npm local path specifiers are temporarily resolved to the > version range of the package they point to before being packed into the tarball.

I can see here in the docs and in this test that the option --exact is supported and tested.
Thanks for the callout. Will update there as well!

Gotcha, thanks for the explanation. Also, sorry I completely missed the docs on exact.


have parsePerms return a consistent array

so you can use something like
$perms = $gplay->parsePerms($pkg)['grouped'];

without risking PHP notices when no data was retrieved.

Hey Izzy, What up man?
It's been about one year I don't have updates from you. everything is fine there?
About the PR:
So the default value of "grouped" will be a empty array.
Thanks;

It's been about one year I don't have updates from you.

Thanks for asking, Max – but everything works fine, so why changing it? :smile: Or was there something I missed to deliver? Like from the reopened first issue?
And yes, all fine and much to do. Still alive and kicking, though :grin:

So the default value of "grouped" will be a empty array.

Exactly. Practically doesn't change a thing except for avoiding a PHP notice (which gracefully converts it to an empty array if addressed as such). If you want to make sure the app really has no permissions, there's still the success field you can check (i.e. empty array and success=1 means the app really has no perms, while with success=0 it simply means we failed obtaining data – that hasn't changed with this PR).


Clientside crash

Made a beef stew with tomato and dandelions as seasonings.
Attempted to hold it in hand and went straight to crash.
On a 1.14 server im running.
crash-2019-05-22_00.53.39-client.txt
latest.log

It looks like there's an incompatibility with Console Hud. I'll talk to the dev about it. File this there too.


Add ACS retirement note to doc header with details

See title... creating this work item in reference to #2431.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 58462e32-ad55-2351-ee7d-67c047fa4157
Version Independent ID: 0cba1f85-d95c-6b4e-583d-608a6743e15f
Content: Use an Office 365 SharePoint site to authorize provider-hosted add-ins on an on-premises SharePoint site
Content Source: docs/sp-add-ins/use-an-office-365-sharepoint-site-to-authorize-provider-hosted-add-ins-on-an-on.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

Add same note from this doc: https://docs.microsoft.com/en-us/sharepoint/dev/sp-add-ins/register-sharepoint-add-ins

Created pull request: https://github.com/SharePoint/sp-dev-docs/pull/4334
The ACS retirement note was present on the page. The issue was with markdown syntax. Updated the markdown to reflect ACS retirement note to doc header.
However, the actual page Impact of Azure Access Control retirement for SharePoint Add-ins seems to be down.


Revisions tab and commit signature

Gitea version (f148a4a):
Git version:
Operating system:
Database:

[x] PostgreSQL

Can you reproduce the bug at https://try.gitea.io:

[ ] not yet

Description
When displaying the revisions tab on a PR, when there are commit signatures, this error is shown:
template: repo/commits_table:45:90: executing "repo/commits_table" at <.Verification.Verifi...>: can't evaluate field Verification in type interface {}

Need testing on my side, as this probably due to wrong docker image. I suspect wrong version for latest tag on my machine.

@lafriks sorry, the bug is my fault. I should have investigated a little more before creating the issue.
This was due to docker compose which doesn't pull latest image when it already has it locally. It instead used my local latest image which was old. That's why commit verification were not present.
This can be closed, and sorry again for this.

@deguif you can close the issue yourself if no admin as done it before you read this message.

Thanks for letting know


[Bug]: Item can be added more than available stock

What happened?
An item can be added to cart and placed in order deespite not being available in stock or not having sufficient stock.

Screenshot of admin page showing seafood salad item as not being in stock (stock quantity = 0)

Screenshot of item seafood salad can be added to cart despite not having any in stock

Screenshot of order checkout for seafood salad can proceed without any error
What did you expect to happen?
The item is greyed out in the menu page and add item to cart button is disabled.
Version
3.4.x
What browser are you seeing the problem on?
Chrome
Relevant log output
No response

When you click Manage Stock - in the admin panel - what does that show?

This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days. If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue. If this issue is critical to your business, consider the Dedicated Support Service where a Service Level Agreement is offered.

I start having this issue as well. i deleted the extension and i couldn't even update it again so i upload it manual and still not working
![Screenshot 2022-09-05 at 17 58 45](https://user-images.githubusercontent.com/28953560/188624507-6dac4eab-8798-44ca-8aa1-29314ae55fc9.png)


Replaced request with typed-rest-client

Task name: DownloadGitHubNugetPackageV1
Description: Replaced request with typed-rest-client package. Request is deprecated and contains a critical vulnerability.
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) N
Checklist:

[x] Task version was bumped - please check instruction how to do it
[ ] Checked that applied changes work as expected

Hi @v-nmursapall,
Could you review and test these changes, please?

@v-nmursapall Could you review and test these changes, please?

@satbai Could you review and test these changes, please?

Hi, I have tested these changes and they look fine.

/azp run

@mmrazik Could you take a look at this PR


Error - in Saving the Trained Model

Hi There!
I am able to train the model but don't know why not able to save the model properly. I have checked the paths multiple times but all are valid.
=========================================================================
The following values were not passed to accelerate launch and had defaults used instead:
--num_processes was set to a value of 1
--num_machines was set to a value of 1
--mixed_precision was set to a value of 'no'
--num_cpu_threads_per_process was set to 1 to improve out-of-box performance
To avoid this warning pass in values for each of the problematic parameters or run accelerate config.
===================================BUG REPORT===================================
Welcome to bitsandbytes. For bug reports, please submit your error trace to: https://github.com/TimDettmers/bitsandbytes/issues
For effortless bug reporting copy-paste your error into this form: https://docs.google.com/forms/d/e/1FAIpQLScPB8emS3Thkp66nvqwmjTEgxp8Y9ufuWTzFyr9kJ5AoI47dQ/viewform?usp=sf_link
/usr/local/lib/python3.7/dist-packages/bitsandbytes/cuda_setup/paths.py:99: UserWarning: /usr/lib64-nvidia did not contain libcudart.so as expected! Searching further paths...
f'{candidate_env_vars["LD_LIBRARY_PATH"]} did not contain '
/usr/local/lib/python3.7/dist-packages/bitsandbytes/cuda_setup/paths.py:21: UserWarning: WARNING: The following directories listed in your path were found to be non-existent: {PosixPath('"<IP_ADDRESS>","jupyterArgs"'), PosixPath('true}'), PosixPath('6000,"kernelManagerProxyHost"'), PosixPath('"/usr/local/bin/dap_multiplexer","enableLsp"'), PosixPath('["--ip=<IP_ADDRESS>"],"debugAdapterMultiplexerPath"'), PosixPath('{"kernelManagerProxyPort"')}
"WARNING: The following directories listed in your path were found to "
/usr/local/lib/python3.7/dist-packages/bitsandbytes/cuda_setup/paths.py:21: UserWarning: WARNING: The following directories listed in your path were found to be non-existent: {PosixPath('module'), PosixPath('//ipykernel.pylab.backend_inline')}
"WARNING: The following directories listed in your path were found to "
/usr/local/lib/python3.7/dist-packages/bitsandbytes/cuda_setup/paths.py:21: UserWarning: WARNING: The following directories listed in your path were found to be non-existent: {PosixPath('/env/python')}
"WARNING: The following directories listed in your path were found to "
CUDA_SETUP: WARNING! libcudart.so not found in any environmental path. Searching /usr/local/cuda/lib64...
CUDA SETUP: CUDA runtime path found: /usr/local/cuda/lib64/libcudart.so
CUDA SETUP: Highest compute capability among GPUs detected: 7.5
CUDA SETUP: Detected CUDA version 111
CUDA SETUP: Loading binary /usr/local/lib/python3.7/dist-packages/bitsandbytes/libbitsandbytes_cuda111.so...
Steps: 100% 10/10 [00:20<00:00,  1.16s/it, loss=0.0371, lr=5e-6]output_dir:  /content/drive/MyDrive/Zarrar/diffusers/dreambooth_concepts/will_smith
Traceback (most recent call last):
File "examples/dreambooth/train_dreambooth.py", line 607, in
main()
File "examples/dreambooth/train_dreambooth.py", line 596, in main
pipeline.save_pretrained(args.output_dir)
File "/usr/local/lib/python3.7/dist-packages/diffusers/pipeline_utils.py", line 158, in save_pretrained
save_method = getattr(sub_model, save_method_name)
TypeError: getattr(): attribute name must be string
Steps: 100% 10/10 [00:57<00:00,  5.73s/it, loss=0.0371, lr=5e-6]
Traceback (most recent call last):
File "/usr/local/bin/accelerate", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.7/dist-packages/accelerate/commands/accelerate_cli.py", line 43, in main
args.func(args)
File "/usr/local/lib/python3.7/dist-packages/accelerate/commands/launch.py", line 837, in launch_command
simple_launcher(args)
File "/usr/local/lib/python3.7/dist-packages/accelerate/commands/launch.py", line 354, in simple_launcher
raise subprocess.CalledProcessError(returncode=process.returncode, cmd=cmd)
subprocess.CalledProcessError: Command '['/usr/bin/python3', 'examples/dreambooth/train_dreambooth.py', '--pretrained_model_name_or_path=/content/stable-diffusion-v1-4', '--instance_data_dir=will_smith', '--output_dir=/content/drive/MyDrive/Zarrar/diffusers/dreambooth_concepts/will_smith', '--instance_prompt=photo of will_smith person', '--seed=11111', '--resolution=512', '--mixed_precision=fp16', '--train_batch_size=1', '--gradient_accumulation_steps=1', '--use_8bit_adam', '--learning_rate=5e-6', '--lr_scheduler=constant', '--lr_warmup_steps=0', '--max_train_steps=10']' returned non-zero exit status 1.
========================================================================================

/content/gdrive/MyDrive/Zarrar/diffusers/dreambooth_concepts/will_smith
in the path, it's "drive" instead of gdrive, check that out.
it is preferable not to change the output_dit, instead, move the models to the desired paths after them being saved


RuntimeError: 0 INTERNAL ASSERT FAILED

Python 3.6.8, torch 1.5.0, Ubuntu/Windows.
Build graph gives me error: RuntimeError: 0 INTERNAL ASSERT FAILED at /pytorch/torch/csrc/jit/ir/alias_analysis.cpp:318, please report a bug to PyTorch. We don't have an op for aten::to but it isn't a special case.  Argument types: Tensor, None, int, Device, bool, bool, bool, int,.
So strange, in previous I can run this program succesfully. How to solve this?

Turns out that nn.DataParalel cause this error.