Right-to-Left (RTL) support for Hebrew and Arabic

Please add Right-to-Left (RTL) support for languages like Hebrew and Arabic...
Something like:
doc.rtl(true);

doc.text('...', {rtl: true});

maybe i'm late to the party; just wanted to mention i've implemented (a looong ago) a similar solution in DOS (with the old fashioned 16x16 bitmap fonts); but i think the same approach can be applied here
1- reorder the input string using the Bidi algorithm
2- reshape by applying single glyph substitution depending in the context (beginning, middle, end of the word or standalone glyph).
3- ligatures
4- inverse the alignment (possibly using a RTL flag); if this is supported then a more appropriate naming of alignment options should be : leading/trailing instead of right/left
1 and 4 are the 'easy parts'; for 2 and 3 it's another story: for the OpenType fonts i think there is a  GSUB table that can be used for this; but for other font types the only option i think is to implement the specific algorithm for each script (as you said this is a lot of work)

it seems another solution to Arabic shaping is the use of 'Text based Shaping' that transforms the characters on the string level rather than in the Glyph level (further details are there). And it seems there is already an implementation of this kind in Javascript by the ibm-js team. From the sources it appears that the text engine performs a bunch of operations at the character level:
1- Bidi reordering
2- Text shaping (AFAIK applies only to Arabic scripts)
3- symmetrical swapping (replace [(.. with their symmetrical RTL )]... )
4- Number shaping (replace 'Western-Arabic)' numbers 0, 1,2 ... with their Eastearn Arabic counterparts ٠,١,٢ ...)
This can be also a possible fallback to non OpenType fonts which doesn't have a GSUB table

Getting closer. With v0.8.0 the font engine changed to fontkit, which supports an Arabic shaper. Still need to implement the bidi algorithm for mixed script text.

If you prioritize Bidi reordering, and symmetrical swapping, it's enough for Hebrew support.
While technically Hebrew has characters that look different when they're in the end of the word, you shouldn't care about it because unicode defines them as separate characters.
Text & number shaping can be added later for Arabic support.

I found the following infos related to this topic. Python Arabic Reshaper is a library which can be used in cases when native Arabic support is not available. The readme contains a good explanation of the issue and the solution. Looking at the code, it does not seem too hard to port to Javascript. And for BIDI I found this test written in Javascript.

There are GSUB (Glyph substitution) tables in font files for Complex languages.
This link explains those tables with example.
https://www.microsoft.com/typography/otfntdev/arabicot/features.aspx

PDFKIT still has a problem with RTL
any updates? @devongovett

Hi! @devongovett any update on RTL support? Question 2, is this project dead?

Please don't be dead :(

@setpixel I needed this too, but since this doesn't sound that they have added this feature I want to inform you I found jsPDF really useful. they support arabic now.

pdfkit has more functionality than jsPDF. jsPDF doesn't have full unicode support but pdfkit does. The project and its committers deserve the praise. For RTL, right-aligned text works very well. However, when we want to use columns, things change. The need is just to start from right-most column through the left most column. @devongovett we don't need anything except this I think because the RTL text has its RTL way, no need to reverse the strings. (same for LTR inside RTL)

RTL is much more than right aligned text. There’s the issue of comma and
dot positions, and what happens when LTR stuff like numbers and English
text are mixed in a sentence.

I was able to manually handle Hebrew with code like:
npm install twitter_cldr
import * as TwitterCldrLoader from "twitter_cldr";
const TwitterCldr = TwitterCldrLoader.load("en");
class ... {
private isHebrew(text: string) {
var position = text.search(/[\u0590-\u05FF]/);
return position >= 0;
}
private maybeRtlize(text: string) {
if (this.isHebrew(text)) {
var bidiText = TwitterCldr.Bidi.from_string(text, { direction: "RTL" });
bidiText.reorder_visually();
return bidiText.toString();
} else {
return text;
}
}
}
Just pass all text that may be in Hebrew through the maybeRtlize function.
It's not perfect and I only tested it for Hebrew, but it seems to work pretty good. If you also need right alignment, use something like isHebrew(myText) ? { align: "right" } : null for alignment.
The problem is that if the text wraps onto multiple lines, the first word of the text will be on the last line, which is wrong. There needs to be more logic added to handle line breaks.

is there any solution to support urdu and arabic in pdfkit till now.

Simply reversing the text before it goes to pdfkit seems to work for both Hebrew and Arabic (I'm just eyeballing the text however since I speak neither)
const isHebrew = (text) => {
  return text.search(/[\u0590-\u05FF]/) >= 0;
};

const isArabic = (text) => {
  return text.search(/[\u0600-\u06FF]/) >= 0;
};

const rightToLeftText = (text) => {
  if (isHebrew(text) || isArabic(text)) {
    return text.split(' ').reverse().join(' ');
  } else {
    return text;
  }
};

You have to pay attention that Arabic script has symbols that combine with neighboring symbols based on what they are and where they are.

return text.split(' ').reverse().join(' ');

What of non-RTL text? Like a mix between Hebrew and numbers. Or English and Arabic. Consider the following example:
יש לי 500 tokenים של globus2000.

return text.split(' ').reverse().join(' ');

What of non-RTL text? Like a mix between Hebrew and numbers. Or English and Arabic. Consider the following example:
יש לי 500 tokenים של globus2000.
By the way, looks like GitHub is treating this wrong xD

Fair point but it doesn't actually apply in my use case. Perhaps splitting it into RTL and ltr chunks and then reversing the RTL chunks would work? Worth a shot, especially since none of the other solution in here worked for me.

That’s pretty much what the Unicode bidi algorithm does: http://www.unicode.org/reports/tr9/

That’s pretty much what the Unicode bidi algorithm does: http://www.unicode.org/reports/tr9/

Will the bidi algorithm be embedded in pdfkit?

Sure, if someone wants to implement it.

There's a JS implementation of tr9
https://github.com/bbc/unicode-bidirectional
not sure how accurate it is.

Simply reversing the text before it goes to pdfkit seems to work for both Hebrew and Arabic (I'm just eyeballing the text however since I speak neither)
const isHebrew = (text) => {
  return text.search(/[\u0590-\u05FF]/) >= 0;
};

const isArabic = (text) => {
  return text.search(/[\u0600-\u06FF]/) >= 0;
};

const rightToLeftText = (text) => {
  if (isHebrew(text) || isArabic(text)) {
    return text.split(' ').reverse().join(' ');
  } else {
    return text;
  }
};

rightToLeftText('أنا أتحدث اللغة العربية');
rightToLeftText('אני מדברת עברית');

This is exactly what I am looking for. Just a bit improvement:
For RTL languages like persian (as I use it), add a space to the end of the string:
text.split(' ').reverse().join(' ') + ' ';
This will work like a charm!!!
Remember that if your string have special characters (e.g. ":") at the end, put it before added white space.

Just a note for whoever is still stuck on this that reversing the text is not a good idea. It will reverse things like numbers and various other things that should not be reversed. 123456 might result in being reversed to 654321
Use a library meant for this, like TwitterCldr, see https://github.com/foliojs/pdfkit/issues/219#issuecomment-528292446

Just a note for whoever is still stuck on this that reversing the text is not a good idea. It will reverse things like numbers and various other things that should not be reversed. 123456 might result in being reversed to 654321
Use a library meant for this, like TwitterCldr, see #219 (comment)

Note: We are reversing array of strings, not array of characters!!!
I am trying twitterCLDR and problem still persists. In my case, problem isn't about character ordering, it is about white spaces. If you are using linux, as I, just install suitable language package, this will resolve character ordering and it will not be a problem anymore. TwitterCLDR is good for white space ordering but it operates character ordering simultaneously, and it is not good. The best manipulation is reverse() for me.

@weera-tech the actual letters need to be reversed too. Not just the word order is supposed to be reversed in rtl writing.

@weera-tech the actual letters need to be reversed too. Not just the word order is supposed to be reversed in rtl writing.

You are right, but I said that first install suitable language package, in RTL direction, you have to set align to right. Therefore it will have conflict with TCLDR character ordering. simple: -1 * -1 = 1 :)

I'm not sure what sort of mechanism would actually reverse characters for you, but not words, considering pdfkit has no rtl support whatsoever. Perhaps something weird is happening on Linux. I'm using pdfkit in the browser with webpack.
In my experience, and I have a production app using this approach with TwitterCLDR and pdfkit, simply reversing words resulted in support tickets being issued for exactly this problem. Words where in the correct order, but letters were in the wrong order.

Ooops!!!
You are using it in client-side? I am using server-side. Probably this is our difference.

The only correct implementation will be the Unicode bidi algorithm. Anything else, especially reverse(), will be incorrect.

There is a recent WASM build of the HarfBuzz engine which is a text shaping engine used by Firefox Chrome, and others.
https://github.com/harfbuzz/harfbuzzjs
It does support Unicode bidi algorithms among other things. I believe it could be integrated with pdfkit to solve RTL once and for all.
There is a demo here: https://harfbuzz.github.io/harfbuzzjs/
Some discussion about it being used to solve RTL issues for Photopea, which is a very popular online image editor: https://github.com/harfbuzz/harfbuzzjs/issues/10
Unfortunately I'm not familiar at all with pdfkit's text rendering, but perhaps someone could look into it.

I too would love to have an RTL support (Hebrew).

+1 for rtl support

Think out of the box

I was able to use Persian font like this, I use this link
http://pdfkit.org/docs/text.html#fonts
doc.font("your language font here")
   .text("text");

in my case, I used a Persian font you can use the font you need

How is this still not supported?

Wow, 7 years and still no full RTL-support out of box?…

How come this superior library isn't supporting RTL languages?!!
That's ridiculous:)
Though the package has implemented dozens of great functionalities, it's utterly incapable of supporting RTL text.
7 years and still no support:| That's a complete shame for the core developers!

For me I get all the arabic letters parsed correctly on { rtl: true }, but only the numbers are in reverse direction. So I wrote a function, pass the string into it before adding it to the text() function of PdfKit

Before

مروحة (002 - 001 م)

Code

revNumsInString = (s) => {
    var x = 0, keep = "", r = 0;
    s.replace(/(?:[\d])/gi, (i, q) => {keep += (r == q - 1 ? "" : "|") + i; r = q;});
    keep = keep.split("|").map(x => x.split("").reverse().join("")).join("");
    return s.replace(/(?:[\d])/gi, (i) =>keep[x++]);
}

Result

مروحة (200 -100 م)

@AmirABody Kinda  wondering, why would say this is a superior library, then?

It requires a higher level layout algorithm than what pdfkit offers, for example https://github.com/foliojs/textkit. React PDF uses it under the hood: https://github.com/diegomura/react-pdf. Not sure if it supports bidi yet but the architecture is there to support it. Personally I think pdfkit is too low level for advanced text layout, and that it belongs in a higher level library like React PDF or pdfmake, but I also don't work on pdfkit much anymore.

still an issue 9 years later.

to my understanding there are 2 challenges:

bi-directional text rendering (to support RTL and LTR and mixed) --> the words must be in the right order
layout of the document

PDF with locale: e.g. ar (arabic) shall be rendered from right to left
PDF with locale: e.g. en (english) shall be rendered from left to right

regarding point 1. which was discussed above
i think the solution might be to use from opentype specification ...
https://learn.microsoft.com/en-us/typography/opentype/spec/featurelist
the feature rtla
this works with pdfkit already since long time...
please test something like
var doc = new PDFDocument({})
const customFont = fs.readFileSync('./NotoSansArabic-Regular.ttf')
doc.registerFont(Regular, customFont)
doc.fontSize(15)
doc.font(Regular).fillColor("black").text("مرحبا كيف حالك")
doc.font(Regular).fillColor("black").text("مرحبا كيف حالك" , {features: ['rtla']})
doc.font(Regular).fillColor("black").text("مرحبا كيف حالك" , {features: ['']})
additionally you can mix arabic and non arabic texts and it shall render correctly
or am i wrong ?


use default browser search engine when click "Search" instead of ddg

Currently the Search feature only launches the search query using DuckDuckGo, but other users might be using a different default search engine on their browsers.

Trying to use
chrome.search.query({disposition: "NEW_TAB", text: request.payload})
but getting an error:
Unchecked runtime.lastError: The message port closed before a response was received. Error handling response: TypeError: Cannot read properties of undefined (reading 'message')     at chrome-extension://jddheofbghjfdcnpicakaiobceegfdbf/popboy.js:73:36
Not exactly sure how to deal with this.

Issue was solved by adding "search" to "permissions" in manifest.json. :)

#8


Updating To the Next Version

General Troubleshooting

[ ] I have checked for similar issues.
[ ] I have updated to the latest JDA version.
[ ] I have checked the branches or the maintainers' PRs for upcoming features/bug fixes.

Issue
Issue Type

[ ] Bug Report
[ ] Feature Request

Description
Replace this sentence with a description and include as many details as you think are needed to understand your issue.
When I try to update to the latest version I always get this error. Then downgrading it to the older version seems to make it work again. There are no errors in my workspace.

JDA-3.8.0_423 works. JDA-3.8.1_446 gives me this error.
No errors are in the java files.

The github issue tracker is reserved for feature requests and bug reports. Your issue is neither and should be sorted out inside of our discord server. Go to discord.gg/0hMr4ce0tIl3SLv5 to receive the needed help.

@MinnDevelopment Um... is this not a Bug Report?

No, this is not a bug.
You're encountering a problem either with your build process or bundling process.
The issue was closed because it isn't an error and is more of a "troubleshoot my setup" problem, which is what chat is best suited for.


Update twitter icon

The current display button for Twitter on the website still shows the old Twitter bird icon. Twitter has rebranded to "X" with a new logo, so this button should be updated to reflect the latest branding.
Replace the old twitter bird icon with the new twitter-X icon
Screenshots 📸

@yatulearn
Assign me under gssoc-ext and hacktoberfest.
Thank you.


I can not havet this solution build on visual studio 2015 RC

I need help on this issue. I open the solution with VS 2015 RC, but it does not build. Anyone with such an issue or a solution on how to solve it I would be glad

Please see the getting started instructions on Home repo. We are publishing nightly builds on MyGet so it could be that things might have been broken for a particular build.
This is not Identity related so I am closing this issue.


add '--create' option

The '--create' option creates the Rancher stack and service, if they don't exist.

Good question ;)
I rebased my fork. It's now ready to be merged, again.

Merged, thank you! :)


[CWS] Add workload deny list for Activity Dumps

What does this PR do?

This PR introduces a new configuration parameter for CWS:

runtime_security_config.activity_dump.workload_deny_list defines the list of workloads for which we shouldn't generate dumps. Workloads should be provided as strings in the following format "{image_name}:[{image_tag}|]". If "" is provided instead of a specific image tag, then the entry will match any workload with the input {image_name} regardless of their tag.

Motivation

This is needed to exclude specific workloads from the dump generation feature of CWS.
Describe how to test/QA your changes

Set runtime_security_config.activity_dump.workload_deny_list to a workload of your choice
Try to start a dump for this workload
You should see the datadog.runtime_security.activity_dump.workload_deny_list_hits metric reflect your attempts.

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.


python-bitcoinlib

use python-bitcoinlib for all messages.
this is a proposal to use python-bitcoinlib for all messages. I am already using this fork for 2 months a didn't had any issues. if you are interested in it feel free to comment/merge.

Interesting, thanks for creating this PR. As far as I see python-bitcoinlib doesn't support segwit yet, right? That would be needed for some of my things, but maybe I'll create a PR upstream to include segwit support there :wink:


Monitoring USB ports

Hi Tim,
For a Flutter app for the Windows Desktop, I'm looking for a way to monitor changes to the USB ports. FYI, the Flutter app should respond to plugging in or unplugging a USB joystick/gamepad.
Does the win32 package provide a suitable feature that I have overlooked?

Looks like RegisterDeviceNotification is the way to go about it: https://docs.microsoft.com/en-us/windows/win32/devio/registering-for-device-notification
However, this requires intercepting the message loop for a WM_DEVICECHANGE message. I think the only way you can do that is from the runner itself; I don't think there's any extensibility mechanism built into Flutter to allow this to be intercepted from Dart, even with the APIs wrapped with win32.
@cbracken, any thoughts on this?

Oh -- wondering if SetWindowsHookEx might allow installation of a hookproc to monitor these messages. Will investigate...

Flutter 2.10 includes stable Windows support.
@timsneath Does this have a positive effect on monitoring USB ports on Windows?

Not particularly: the same notes above apply, since this is really about integrating with the operating system through calling Win32 APIs rather than anything in the UI itself.
One minor update is that we now have an experimental runner written in Dart: https://pub.dev/packages/win32_runner
This is not supported or maintained by the team as a whole, and it has some sizeable caveats (e.g. it supports packages but not plugins) but it provides another path to writing the message handler above.

@timsneath I didn't know the Dart runner yet. Thanks for your work and the tip.

Oh -- wondering if SetWindowsHookEx might allow installation of a hookproc to monitor these messages. Will investigate...

@timsneath Can we use this function to hook message in flutter? I have tried this with WH_KEYBOARD_LL but it doesn't work

Would https://api.flutter.dev/flutter/dart-ffi/NativeCallable/NativeCallable.listener.html help with any of this?
@yanshouwang here you mention something about creating a message-only window in dart. Can you share more details about that?

Would https://api.flutter.dev/flutter/dart-ffi/NativeCallable/NativeCallable.listener.html help with any of this?
@yanshouwang here you mention something about creating a message-only window in dart. Can you share more details about that?

Here is the code I use to listen drives state, win32_util

Would https://api.flutter.dev/flutter/dart-ffi/NativeCallable/NativeCallable.listener.html help with any of this?
@yanshouwang here you mention something about creating a message-only window in dart. Can you share more details about that?

Here is the code I use to listen drives state, win32_util

Thank you very much! I'll take a look.

What's the latest update on this ?

@halildurmus FYI, A USB joystick/gamepad is not a USB drive which is handled in #917.

Well, you can probably adapt the example to suit your needs.


Search functionality in PDF

Is search functionality available in this PDF Viewer? if not, can you suggest way how I can implement it?

no, search is not supported
In order to search inside a document, you need to open it and parse its text, so it's not an easy issue.
I would suggest to open the PDF file directly and deal with its contents, outside PdfViewPager.

as @voghDev mentioned, it is very hard to implement search functionality in this library, and trust me I've searched for a lot of libraries none of them have this search functionality. Only paid SDKs have these features. But in case you want to play around with this library, you can just fork it. and maybe use MLKit for work search. I tried the below-mentioned code to achieve the search feature. but it is working for a single bitmap at a time (as we're just showing a single page at a time.). I placed this code in PDFPagerAdapter.java inside the instantiateItem() method after page.close(). I'm still working on it, and if I achieved what I want. I'll post the code here or will create a pull request.
Example:
TextRecognizer textRecognizer = TextRecognition.getClient(TextRecognizerOptions.DEFAULT_OPTIONS);
        InputImage image = InputImage.fromBitmap(bitmap, 0);
        Task<Text> task = textRecognizer.process(image);

        task.addOnSuccessListener(new OnSuccessListener<Text>() {
            @Override
            public void onSuccess(Text text) {

                System.out.println("text====" + text.getText());
                System.out.println("textBlock====" + text.getTextBlocks());

                Paint rectPaint = new Paint();
                rectPaint.setColor(Color.parseColor("#724CAF50"));
                rectPaint.setStyle(Paint.Style.STROKE);
                rectPaint.setStrokeWidth(4.0f);

                Bitmap tempBitmap = Bitmap.createBitmap(bitmap.getWidth(), bitmap.getHeight(), Bitmap.Config.RGB_565);
                Canvas canvas = new Canvas(tempBitmap);
                canvas.drawBitmap(bitmap, 0, 0, null);

                List<Text.TextBlock> textBlock = text.getTextBlocks();

                for(Text.TextBlock textItem : textBlock){
                    for (Text.Line line :
                            textItem.getLines()) {

                        for (Text.Element element :
                                line.getElements()) {
                            Log.d("=====", element.getText());
                            if(element.getText().equalsIgnoreCase("book")){ //I wanted to create a box around book
                                //Get the Rectangle/boundingBox of the word
                                RectF rect = new RectF(element.getBoundingBox());
                                rectPaint.setColor(Color.parseColor("#724CAF50"));

                                //Finally Draw Rectangle/boundingBox around word
                                canvas.drawRect(rect, rectPaint);

                                //Set image to the `View`
                                photoView.setImageDrawable(new BitmapDrawable(context.getResources(), tempBitmap));
                            }

                        }
                    }

                }

            }
        }).addOnFailureListener(new OnFailureListener() {
            @Override
            public void onFailure(@NonNull Exception e) {
                System.out.println("error====" + e.toString());
            }
        })


all: port to other OSes

There is interest in porting syzkaller to other OSes (Windows, Mac, FreeBSD, Fuchsia, etc). This looks like a very reasonable thing to do as we can reuse lots of syzkaller smartness across different OSes and benefit from contributions from larger group of users. A related issue is better support for target arch that is not equal to host arch, e.g. x86_64 host and arm64 target (see e.g. #173). Most likely it makes sense to work on support for different OSes/arches together. This issue is a tracking bug for such support (not for support for individual OSes).
Support for a particular OS can be implemented in several steps. The first step would be to get syz-stress running (no coverage, no VM management, no crash extraction/symbolization). Second step is to get syz-manager running (this requires VM management, crash extraction/symbolization, etc, but still no coverage). The last step would be to add coverage support.

Since the list of potentially supported OSes/archs is large, the main concern is code organization that would allow clean separation of generic code and OS-dependent code.
An assorted list of things that depend on OS/arch:

build system support to be able to build for different OSes
list of syscalls (some probably will be shared between OSes, e.g. POSIX subset)
VM customization (current qemu code is written with linux in mind)
report symbolization, symbol extraction, coverage reports
native code in syz-executor
ipc mechanisms in ipc package
crash extraction in report package
some binaries (syz-fuzzer/syz-executor) can assume that they work on host, others (syz-manager/syz-hub) needs to know target arch
csource package needs customization per OS
syz-extract needs customization per OS
host package needs to know how to determine supported syscalls per OS
prog package has some hardcode for linux (e.g. it uses mmap to allocate memory, syscall sanitization is linux-specific)
coverage is a big question
The first step will be to figure out general approaches to handle differences in all of these packages.

Hardcoded syscall number 313 added in #271 implies that we're dealing with linux/amd64 target.

We now have support for different OS/arches and have distinction between host and target OS/arch. Let's consider the generic issue done. Future work should proceed in separate, more targeted issues.


chore: update KEDA to version 2.5.0

Thank you for wanting to submit a Pull Request to the Civo Kubernetes Marketplace repository!
If your pull request concerns an existing Marketplace application, please make sure you have:

[x] Notified the Maintainer of the application in this pull request so that they are aware of your proposal.
[x] Outlined the changes you are proposing, and the reasons these are required (e.g. stability, compatibility with new versions of Kubernetes implementations, etc).
[x] Tested that the application works with the proposed updates applied (including a screenshot)

Update KEDA helm chart to version 2.5.0
https://github.com/kedacore/keda/releases/tag/v2.5.0

Thank you for the PR, LGTM


[don't-merge] create develop branch

Summary
chunk-test and agg-test could pass.

Close this PR since we already have develop branch.


Create new items

Not sure if this would be helpful but the ability to create new items from vscode?

closed in https://github.com/roemhildtg/vscode-arcgis-assistant/commit/412b31da9af541197fdefd4c2fb27af270388f96
Includes the ability to create new apps/maps/etc


Links to notes

It would be great to be able to copy a link to a note.
I saw users form other clients posting what looks like a note ID, then we would need a way to open those IDs, for now I cannot use them in Nostros.
If that's overlapping with the "search" feature on your list, please close issue.

We have a mock-up for a note drop-down menu with a copy key action, pending to develop

implemented, will be include in the next release


Add to clibs

I think this library would be a good fit for the clibs packet manager.

Interesting idea @erf! Can you (or someone else) post a good sample package.json file I can use as a template?

Hi, see my stb wrapper at https://github.com/erf/stb or examples at https://github.com/clibs/clib


BContainer tag prop, BTable items/rows selection

BREAKING CHANGES: .container & .container-fluid CSS classes now have a default 'block' display to behave as a 'div' element when the BContainer tag is changed
BREAKING CHANGE: BTable 'sorted' event output value was changed to an object with keys [sort(string), desc(boolean)] for better ts type support.
BREAKING CHANGES: BTable sortInternal prop default value is now 'false'
fix: added a few missing props to the BTable.d.ts file
fix: replaced BTable emits definition array with a typescript interface for better type support
fix: update the data type of a few of BTable props
feat: Added 'tag' prop to BContainer component
feat: Added BTable selectable prop that adds the selection functionality to the table
feat: Added BTable select-mode prop with a value of [multi, single, range] to expand how the table selection can be used.
feat: Added Btable select-head prop to show an extra Head & Cell to the table
feat: Added selectHead & selectCell slots to customize the selection of the extra head & cells.
feat: BTable selection-variant prop was added, giving the ability to use bootstrap's colors as bg to the selected rows

A working example:
<template>

      <template #selectHead>Is Selected?</template>
      <template #selectCell>✔</template>

      <template #cell(selected)="{ rowSelected }">
        <template v-if="rowSelected">
          ✓
          Selected
        </template>
        <template v-else>

          Not selected
        </template>
      </template>

      Selected Rows:

      {{ selected }}

      Internal Selected Rows:

      {{ internalSelected }}

</template>

More logic to be added later to give the ability to update selectedItems array through props using v-model, and provide few methods to control the internal selectedItems array (such as, selectAllRows, clearSelected, selectRow(index))

If you could possibly address https://github.com/cdmoro/bootstrap-vue-3/pull/608. Feel free to give them a message, figure out a solution, or copy both the changes together, as to not have any merge conflicts.

If you could possibly address https://github.com/cdmoro/bootstrap-vue-3/pull/608. Feel free to give them a message, figure out a solution, or copy both the changes together, as to not have any merge conflicts. @cattaneoinfoesse

If you could possibly address #608. Feel free to give them a message, figure out a solution, or copy both the changes together, as to not have any merge conflicts. @cattaneoinfoesse

done.

seems working fine for me except to know one thing, how i can change icon for not selected item it always show ✔ for all rows.<template v-slot:cell(selected)="rowSelected ">
      <template v-if="rowSelected">
      ✓
      Selected
    </template>
    <template v-else>

      Not selected
    </template>
   </template>

it looks like that part of code isn't working, always show ✔ for all rows

seems working fine for me except to know one thing, how i can change icon for not selected item it always show ✔ for all rows.<template v-slot:cell(selected)="rowSelected ">
      <template v-if="rowSelected">
      ✓
      Selected
    </template>
    <template v-else>

      Not selected
    </template>
   </template>

it looks like that part of code isn't working, always show ✔ for all rows

with the upcoming release update, it will be customizable using CSS. Please take a look at #643

I think it would be nice if additionally those values could be modified using slots, for those like me that don't like touching css.

I'm using 0.16.6 version of this package. But I cannot use rowSelected to render checkboxes for each row and select/deselect on row selection.
When I can expect this fix?

        <template #cell(null)="{ rowSelected }">
          {{ rowSelected }}
          <input type="checkbox" :checked="rowSelected">
        </template>

      ```

Same issue for me on 17.6 as well!


Maybe reduce one byte by removing the jae

If we replace those lines:
https://github.com/donno2048/snake/blob/aea033b4ec61579549bb613b862f36634e0fe74f/snake.asm#L26-L29
with any of those replacements:
cmp bx, di
sbb BYTE [di], 0xA0
jns start
or BYTE [di], 0x20

cmp di, bx
adc BYTE [di], 0x5F
jns start
or BYTE [di], 0x20

cmp di, bx
salc
xor [di], al
jns start
xor BYTE [di], 0x23

the game will still work, but two bytes are added.
However,  we can leave out the last three-byte instruction (thus saving one byte) by using jp .food instead of jnp .food which is simple, and by finding a replacement for and [bx], ah to set [bx] to 0x20 and reset SF without assuming that the sixth bit of [bx] is set.
I'll look into it tomorrow...

Maybe better to use OF

Turns out I already thought about this approach and abandoned it (#40)...


feat: Show Tracks under an Event

Fixes #872
Changes: Implmented Tracks module
Fetched Tracks for an Event
Saved it in the database for offline use
Show it in a RecyclerView
Screenshots for the change:

I think it would be better if you add the Track Table for Database Migration as well.

@Masquerade0097  How to add it for migration ? Would adding it to the recreated Array
Class[] recreated = new Class[] {Faq.class, Copyright.class}; work or would i have to bump up the database version to 10 ?

@srv-twry Creating version 10 would be fine.

Very nice, but use the color and font color of the track in card header to make it look nice

@iamareebjamal Ready for review.

The header should be match parent. Take a look at the sessions layout in Open Event Android

@iamareebjamal Please review.

Description should have padding and should not appear to be bold

@iamareebjamal Please review


Fix submit --create with no new remote branches

This PR avoids trying to create new branches when there are no new branches to create
Fixes #557

Thanks for the fix! I've also added you as a collaborator on the repository so that you can merge your own changes once they're accepted. Feel free to push your branches directly to this repository, if you prefer.


Fix some typos in the README

This change is

I tried to sign the CLA twice, couldn't get to the end of the process. Submitted the contact form, in case someone wants to look into it.

Thank you for fixing this. Almost LGTM - just a single comment.

Hi @dluc, any chance you could fix the typo and resolving conflicts? Thanks!

Looks like the file is considerably smaller than the time when I sent the PR. Let me close this one, I sent a new PR https://github.com/kubernetes/contrib/pull/2557


RFC9116

The website says: "Just as security.txt can be deployed into either the root or the .well-known directory of a webserver,...", but with RFC9116 this is no longer true. RFC9116 says: "For web-based services, organizations MUST place the "security.txt" file under the "/.well-known/" path"
UPDATE: In "3 Location of the security.txt File" it says different, so I was wrong. Please close ticket.

The /.well-known/security.txt is the correct path, and /security.txt is allowed only for backwards compatibility.
A complete quote from RFC 9116 section 3:

For web-based services, organizations MUST place the "security.txt" file under the "/.well-known/"
path, e.g., https://example.com/.well-known/security.txt as per [RFC8615] of a domain name or IP
address. For legacy compatibility, a "security.txt" file might be placed at the top-level path or
redirect (as per Section 6.4 of [RFC7231] ) to the "security.txt" file under the "/.well-known/" path. If
a "security.txt" file is present in both locations, the one in the "/.well-known/" path MUST be used.

While the website could argue both are allowed, they should still be in reverse order:

Just as security.txt can be deployed into either the the .well-known directory or root of a webserver,...

Looks like a job for @caseyjohnellis :)


support local build as an alternative to cascproxy

Closing, since wowless is really only supported inside the devcontainer at the moment and that's not likely to change any time soon.


[1.11.2] [Forge] Minecraft hangs on creation of a 'biome bundle' world

Here is a small snip-pit from my MultiMC Log:
[20:20:49] [Server thread/ERROR]: Encountered an unexpected exception
java.lang.NullPointerException
at com.khorn.terraincontrol.forge.TXDimensionManager.RemoveTCDims(TXDimensionManager.java:523) ~[TXDimensionManager.class:?]
at com.khorn.terraincontrol.forge.ForgeWorld.(ForgeWorld.java:155) ~[ForgeWorld.class:?]
at com.khorn.terraincontrol.forge.WorldLoader.getOrCreateForgeWorld(WorldLoader.java:284) ~[WorldLoader.class:?]
at com.khorn.terraincontrol.forge.WorldLoader.getOrCreateForgeWorld(WorldLoader.java:262) ~[WorldLoader.class:?]
at com.khorn.terraincontrol.forge.TXWorldType.getBiomeProvider(TXWorldType.java:67) ~[TXWorldType.class:?]
at net.minecraft.world.WorldProvider.func_76572_b(WorldProvider.java:58) ~[avf.class:?]
at net.minecraft.world.WorldProvider.func_76558_a(WorldProvider.java:40) ~[avf.class:?]
at net.minecraft.world.WorldServer.(WorldServer.java:112) ~[lw.class:?]
at net.minecraft.server.integrated.IntegratedServer.func_71247_a(IntegratedServer.java:85) ~[cch.class:?]
at net.minecraft.server.integrated.IntegratedServer.func_71197_b(IntegratedServer.java:120) ~[cch.class:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:442) [MinecraftServer.class:?]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_131]
[20:20:49] [Server thread/ERROR]: This crash report has been saved to: /home/royal-jelly/Desktop/Games/MultiMC[0.5.1]/instances/Forged with Maids [1.11.2]/minecraft/crash-reports/crash-2017-06-07_20.20.49-server.txt
And the whole log can be found here : https://paste.ee/p/OoHka

I have also posted this report over on the biome bundle Github just in case ~

Hey, are you using Sponge by any chance?

I'm not using sponge and i got a reply over on the biome bundle page
I was told they wont be taking bug reports until the 1.11.2 build of OTG has been officially released
and sorry for the faux bug report ~

Thanks for the bug report, looks like this is happening with the latest version of forge (<IP_ADDRESS>5), the recommended version (<IP_ADDRESS>8) should work fine though. Will fix this a.s.a.p.

Could you grab the latest dev version from the comment in this post and tell me if that fixes the problem?
https://www.reddit.com/r/openterraingen/comments/6g6zvq/new_otg_releases_for_1102_and_1112/
Thanks!

I have done what you asked it is going well so far ~ thank you ~

Glad to hear it, you're welcome :)


Add deletecollection role for globalIngressIPs

Add deletecollection role for globalIngressIPs to allow bulk delete
of ingressIPs when service/serviceexport is deleted.
Signed-off-by: Vishal Thapar<EMAIL_ADDRESS>

Could you explain why this is needed, in the commit message?

done


Missing dependency recommonmark

@bfortuner, thanks for getting us organized to put this together.
I cloned and installed the dependencies and found one to be missing: recommonmark
I am running the usual anaconda3 stack used in fast.ai/part2.
Perhaps you could add this dependency to the install guide.
pip install recommonmark

Thanks! Updated.


Feature request: add timeout option for image requests

When fetching media items/images it returns.
Fetching image_url is taking a long time time (longer than 15 seconds). This file is File_size MB  After few of this line it crashes with error RequestError: Timeout awaiting 'request' for 30000ms.
Here is my config
    {
      resolve: `gatsby-source-wordpress-experimental`,
      options: {
        url: `https://siteurl/graphql`,
        verbose: true,
        html: {
          imageMaxWidth: 700,
          imageQuality: 80,
        },
        schema: {
          timeout: 120000,
          requestConcurrency: 50,
          perPage: 50,
        },
        type: {
          __all: {
            limit: 500,
          },
        },
      },
    },

I don't understand why it would say error RequestError: Timeout awaiting 'request' for 30000ms.  as you can see the time out is set to 2min. Also how can I can increase the media fetching time more than 15sec. Please let me know what am I doing wrong or how can I resolve this issue.
Thank You

Hi @dipankarmaikap , the timeout setting you're mentioning is for GraphQL requests. There isn't currently a setting for the timeout of individual images. A new option would need to be added for this.

Hi @dipankarmaikap , the timeout setting you're mentioning is for GraphQL requests. There isn't currently a setting for the timeout of individual images. A new option would need to be added for this.

I've moved this to our internal backlog - if anyone feels strongly about this feature please add a feature request at https://portal.gatsbyjs.com/gatsby-cloud


Tons of GCP errors on API /api/dart-internal-subscription

Seems some messages keep being fetched but failed every time:
Null check operator used on a null value
#0      DartInternalSubscription._createTaskFromBuildbucketResult (package:cocoon_service/src/request_handlers/dart_internal_subscription.dart:95:38)
#1      DartInternalSubscription.post (package:cocoon_service/src/request_handlers/dart_internal_subscription.dart:66:29)
<asynchronous suspension>
#2      RequestHandler.service.<anonymous closure> (package:cocoon_service/src/request_handling/request_handler.dart:53:24)
<asynchronous suspension>
#3      SubscriptionHandler.service (package:cocoon_service/src/request_handling/subscription_handler.dart:138:5)
<asynchronous suspension>
#4      main.<anonymous closure>.<anonymous closure> (file:///app/bin/server.dart:298:11)
<asynchronous suspension>

Failed to process Instance of 'PushMessage'. (500) Null check operator used on a null value
#0      DartInternalSubscription._createTaskFromBuildbucketResult (package:cocoon_service/src/request_handlers/dart_internal_subscription.dart:95:38)
#1      DartInternalSubscription.post (package:cocoon_service/src/request_handlers/dart_internal_subscription.dart:66:29)
<asynchronous suspension>
#2      RequestHandler.service.<anonymous closure> (package:cocoon_service/src/request_handling/request_handler.dart:53:24)
<asynchronous suspension>
#3      SubscriptionHandler.service (package:cocoon_service/src/request_handling/subscription_handler.dart:138:5)
<asynchronous suspension>
#4      main.<anonymous closure>.<anonymous closure> (file:///app/bin/server.dart:298:11)
<asynchronous suspension>

/cc @drewroengoogle

This is from the branch I have deployed. I am looking into the issue, but I will redeploy main when complete and this should stop.

Yes, closing!


Error parsing sampling strategy

This is probably problem of (configuration of) all-in-one docker image, so it is more request for help than an issue.
TL;DR
Error: Error in parsing sampling strategy: SyntaxError: Unexpected token c in JSON at position 1.
Question1: Can someone please point me to the solution of this problem? According to my current understanding, it would probably be some documentation explaining how to configure the remote sampler, which I missed.
Question2: I tried with const sampler (sampler: { type: 'const', param: 1 }), but that would result no traces at all appearing in Jaeger UI. Could someone please point me to some more detailed documentation for samplers and their configuration?
Long Story
I start the all-in-one docker container with the command from the official documentation:
$ docker run --rm -p5775:5775/udp -p6831:6831/udp -p6832:6832/udp -p5778:5778 -p16686:16686 -p14268:14268 jaegertracing/all-in-one:latest
{"level":"info","ts":1500067556.8956976,"caller":"tchannel/bulider.go:95","msg":"Enabling service discovery","service":"jaeger-collector"}
{"level":"info","ts":1500067556.895823,"caller":"peerlistmgr/peer_list_mgr.go:117","msg":"Registering active peer","peer":"<IP_ADDRESS>:14267"}
{"level":"info","ts":1500067556.8969154,"caller":"standalone/main.go:82","msg":"Starting agent"}
{"level":"info","ts":1500067556.8984168,"caller":"standalone/main.go:117","msg":"Starting jaeger-collector TChannel server","port":14267}
{"level":"info","ts":1500067556.898527,"caller":"standalone/main.go:124","msg":"Starting jaeger-collector HTTP server","http-port":14268}
{"level":"info","ts":1500067556.9013727,"caller":"standalone/main.go:174","msg":"Starting jaeger-query HTTP server","port":16686}
{"level":"info","ts":1500067557.896384,"caller":"peerlistmgr/peer_list_mgr.go:165","msg":"Not enough connected peers","connected":0,"required":1}
{"level":"info","ts":1500067557.896504,"caller":"peerlistmgr/peer_list_mgr.go:172","msg":"Trying to connect to peer","host:port":"<IP_ADDRESS>:14267"}
{"level":"info","ts":1500067557.8978744,"caller":"peerlistmgr/peer_list_mgr.go:177","msg":"Connected to peer","host:port":"[::]:14267"}

Then I start the sample service with almost default configuration passed to the tracer:
const config = {
  'serviceName': 'foo'
};
const options = {
  'logger': console
};
const tracer = initTracer(config, options);

After sending some requests, it looks it is working (I see some traces in the Jaeger UI), but I keep getting the JSON parsing error while the tracer attempts to retrieve sampling strategy:
$ npm run start
Initializing Jaeger Tracer with RemoteReporter and RemoteSampler
API initialized
Error in parsing sampling strategy: SyntaxError: Unexpected token c in JSON at position 1.

This is due to the following problem:
$ curl -sS -i -H'Content-Type: application/json' --connect-timeout 10 --max-time 60 -X GET 'http://localhost:5778/sampling?service=foo'
HTTP/1.1 500 Internal Server Error
Content-Type: text/plain; charset=utf-8
X-Content-Type-Options: nosniff
Date: Mon, 17 Jul 2017 14:33:40 GMT
Content-Length: 37

tcollector error: no peers available

Hi there
Question1: this error currently occurs since we haven't open sourced the sampling processor logic in the collector yet. It's on our TODO list. I'd advise using a different sampling strategy.
Question2: this is weird, you should be seeing 100% sampling using the const sampler. Can you post the config and the options you pass into the tracer? Also you can add this to the config:
const config = {
  'reporter': {
    'logSpans': true
  }
};

The above will log all the traces that are being sampled. This can help us narrow down where the issue is. I'll add some documentation on the different sampling strategies.

Hi, thank you for fast response!
Please disregard my Question2, it was couple of silly problems between my keyboard and chair, now resolved.
As for the Question1, what would be your recommendation for our approach to the sampling strategy? Should we wait for the sampling strategy logic to be open sourced (what kind of timeline do you have in mind?) and use e.g. ProbabilisticSampler in the meantime? Regarding the documentation on the sampling strategies, if you are open to sharing some tips on it, we may be able to help with the documentation.

I'd recommend using ProbabilisticSampler or the Const sampler in the meantime depending on the QPS of your service.
We support 4(5) samplers:

Const - depending on the param, this sampler samples everything or nothing (no in between)
Probabilistic - probability based, the default is 0.001 (1 in 1000). ie one out of every 1000 requests will be traced.
Ratelimiting - Takes in param which stands for maxTracesPerSecond. ie if param is 2, every second the tracer will trace AT MOST 2 requests.
Remote - This strategy fetches sampling strategies from the collector once a minute (this interval is configurable). This returned strategy can either be probabilistic or adaptive.
Adaptive - A sampling strategy that is used by Remote. This strategy dynamically adjusts the sampling probability such that each service/endpoint is traced at a specific rate.

4 and 5 are still in the process of being open sourced. We have an OKR to get them done this quarter.

@mareq it looks like your questions have been answers, please re-open if not and clarify the issue.


Made a few assignment operators return references instead of copies

Made a few assignment operators return references instead of copies.
Fixes some LGTM warning found at https://lgtm.com/projects/g/godotengine/godot/alerts/?mode=list&id=cpp%2Fassignment-does-not-return-this (More Info).
Close if unnecessary/wrong or if it causes bad change in logic.

Looks good to me.

To save later confusion, these are '(copy) assignment operators', not copy constructors.
A copy constructor is Thing(const Thing &from).

To save later confusion, these are '(copy) assignment operators', not copy constructors.
A copy constructor is Thing(const Thing &from).

My bad.

Does this mean they are now COW? We don't want to change the original if we change a local variable.

Any updates?

Superseded by PR #37938.


Mace issues.

Idk why but you can use the Mace like a sword. So just attack anything without jumping to swing.
Mace crafting recipe is pretty cheap for being better than all the swords.
Mace can be enchanted with sharpness. (there also isn't new enchants)

I think the Mace is like a retexture iron sword with it's falling attack abilities.

Also you should provide source.

Idk why but you can use the Mace like a sword. So just attack anything without jumping to swing.
Mace crafting recipe is pretty cheap for being better than all the swords.
Mace can be enchanted with sharpness. (there also isn't new enchants)

I think the Mace is like a retexture iron sword with it's falling attack abilities.

Oh hey there buddy! Thanks for your reply

Oops it was originally based on the sword code but after testing on 24w13a today, it looks like you're right! It doesn't behave like a sword. This fix will be rolling out when I finish my classwork. As for point 3, the new enchants are out but not for some of the versions like 1.16.5 yet.
It's my fault for not making the issue requirements clear but lemme know which version of the mod you're actually using and which Minecraft version, and that'll make it much easier to debug.
Again thanks for your help!

I mainly use 1.12.2 and 1.16.5. I was wondering why a version that released the same day as the enchantment update for like 1.19 and 1.20 wasn't included in the 1.12 version.

Oh that's a great question! I'm not if you're sure with how Minecraft modding has journey'd but if you've played for a while you may remember a period of time when 75% of mods were basically stuck at 1.12.2 and not updating even though the game already moved on to 1.16.5.
I recommend reading this comment thread but I'll phrase my favorite part for you

1.13 in particular led to Forge rewriting a bunch of their codebase. As such, it took a lot of work to port mods over, and so many mods and packs stayed on 1.12 for quite a while as there just wasn't enough content on 1.13 compared to the highly mature 1.12 scene. Forge did release on every version, but the scene didn't adopt those versions. Since then, Minecraft releases have been so frequent, and Forge's refactor made it quick enough for them to release after Minecraft that no version has become entrenched in quite the same way. And there haven't been such drastic changes in the codebase to require total mod rewrites to update. So modders have mostly been targeting the most recent patch for a long time.

That's why I can rapidly address issues on the other versions a lot quicker than 1.12, which is way before the threshold. To work on 1.12, I actually had to recreate the mod from scratch and the only reason I could do it in a day was because of the low content this mod have. Rest assured, I have no plans to abandon the 1.12 work but it just takes a lot more work since that was more than half a decade ago, and a lot of the codebase is deprecated now.
1.16.5 got the enchantment update a day ago btwww so check it out!
Also I'm actively in class so my apologies if I don't reply fast

it's been two weeks without comment from you so I'll go ahead and close this now! What you detailed was addressed dw


remove facet from plots (wont be released phase 1)

my current work, axis label unit (#255), would need to change all plot vizs, so I can handle this as well - think it is simply remove facet variable input at Variable Selector.

QA looks good, moving to closed


Go to symbol in workspace only gives partial list

With just a minute or two of checking, it seems to me like the symbol finder is only finding user-defined symbols that are not prefaced with any + or ++ marks...   top-level objects seem to be found.
I notice that it comes back with some method names from the adv3 files, but not all. I don't know that it is listing any user-defined method names; just top-level objects, classes, and functions.

I agree, only top-level objects are found. A fix is coming up soon for this.


Do I need to be using typescript 4?

I seem to be getting compile errors because of https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-0.html#labeled-tuple-elements.
Is there a way around this? Upgrading is going to take too much time.
Cheers

@helpmeiamstuck just checking: do you have "skipLibCheck: true" in your tsconfig? If not, you can enable it and see if that fixes your issue.
If it doesn't, you can possibly write an unsafe wrapper around the library.
If that doesn't work, I would recommend you upgrade Typescript -- 4.x was released 3 years ago.


Fix persistent store initial state

We're currently creating a new persistent store as soon as a staging file is detected on the CLI. This is wrong.
If the given persistent store exists, we should load it.
We should apply the --balance_only_for_testing flag only when creating new storage, NOT when loading an existing one.
Print warnings to inform the user of ignored CLI flags.

Fixed by #292


Popup window

Capstone project
In this PR:

Created  a popup window with relevant information when it appears

Hi @Team,
Great job so far! 👏
You've done well setting up the Kanban board, however, there are some issues that you still need to work on to go to the next project, but you are almost there!
To highlight 🎯

No linter errors.✔
Nice setup. ✔
Descriptive Issue. ✔

Required Changes ♻
Check the comments below .

[ ] It is good how you've used the letter A and B to specify the student, however, it is very important that you add the student, not just use the letter A = @Iptysam. We should be able to assign the student to each of the respective tasks. Please kindly ensure you've done this, then ask for another review.

Optional suggestions

N/A

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi @Team,
Great job so far! 👏
You've done well setting up the popup window  there's nothing to say other than to merge it
To highlight 🎯

No linter errors.✔
Nice setup. ✔
Descriptive Issue. ✔

Required Changes ♻
Check the comments below .

[ ] It is good how you've used the letter A and B to specify the student, however, it is very important that you add the student, not just use the letter A = @Iptysam. We should be able to assign the student to each of the respective tasks. Please kindly ensure you've done this, then ask for another review.

Optional suggestions

N/A

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Tree data icon style

Hello,
I'm bringing up an issue from material-table that wasn't addressed - https://github.com/mbrn/material-table/issues/707.
Would it be possible to add different icons for the root table, and/or allow customization? The root table icon is very confusing when you have several layers of nesting. It's hard to distinguish what's a parent and what's a child.
A branch line indicator, different icons for nested layers, or even some color change would make it a lot easier to differentiate for a user.

Yes, that sounds like it should be possible. I can get around to this when I have some time, or if you would like it fixed quicker we are actively merging PR's here.

Really want this aswell

How about this.
If you want to adapt the icon, you pass a custom function to the DetailPanel icon and adapt it as you want it.
And the fallback would be the ChevronRight, since it is also used for the detail panel? Would that work for you?
@Tobbe129 @rokpu
 icons={{
        DetailPanel: (a) => {
          if (a.level === 0) {
            return a.level;
          }
          return <ChevronRight data-testid="chevron_right" />;
        }
      }}

How about this.
If you want to adapt the icon, you pass a custom function to the DetailPanel icon and adapt it as you want it.
And the fallback would be the ChevronRight, since it is also used for the detail panel? Would that work for you?
@Tobbe129 @rokpu
 icons={{
        DetailPanel: (a) => {
          if (a.level === 0) {
            return a.level;
          }
          return <ChevronRight data-testid="chevron_right" />;
        }
      }}

Thanks, @Domino987 this is awesome!
I'll adapt it to rotate through 3 different icons depending on the level.
Do you have any suggestions on the proper way to pass the level to the DetailPanel without altering other behaviors?

Good that you like it. I already have an implementation. I'll crate a PR that you can check it out in a bit. I'll link it here.

Awesome, thanks for the quick turnaround. Looking forward to it!

https://github.com/material-table-core/core/pull/451/files does this work for you?

I am releasing a new version right for. So should be a few minutes till you can try it out in real.


Start health checks of all running app versions after leader change

Before only the current version's health checks were started on leader change,
leading to missing health checks when, e.g. after scaling, when old app versions
were still running.
Fixes #912

Added test cases and rebased to latest master.

Added test cases and rebased to latest master.

From Travis CI test failure:
[info] - reconcileWith *** FAILED ***
[info]   Set() did not equal Set(HealthCheck(Some(/),COMMAND,0,None,3 seconds,10 seconds,20 seconds,3)) (MarathonHealthCheckManagerTest.scala:172)

I fear this is due to some timing issue in the tests. Maybe something asynchronous we have to wait for. Checking....

Found the problem: the appRepository.app method returns Futures, leading to asynchronous addAllFor calls in reconcileWith. Fixed that.

Awesome, thanks!


Smart advanced testing

Is this a feature OR bug:
feature
Details
@niphlod mentioned this command that finds command dependencies
http://poshcode.org/1075
Using that idea, can we make a test that triggers advanced tests for commands that we touched, even indirectly, in a PR? An advanced test would be on the dbatools lab -- that performs an actual migration, etc.

done didley


Do I need to add a buffer?

I've got a pi2, a string of WS2801 pixel LED's, and a 5v, 8A power supply. Tried hooking up the LED strip to the GPIO header based on info from the hyperion github page and the pinout diagram from RaspberryPi.
The LED's barely light up, sometimes the first 3 are off, sometimes they are the only ones on, sometimes the string lights up to the end, sometimes a random number of LED's... always a reddish-amber color that I can't change via the command line or via the hyperCon java app.
Trying to figure out if I need a buffering circuit between the SPI interface and the LEDs, but I'm an electronics noob, and don't really have a frame of reference to work from / way to troubleshoot the string.
Based on reading I've done, it sounds like the SPI output is possibly too low a voltage for the WS2801 LED strip to deal with --but I'm not sure as the hyperion wiki mentions that people apparently are using them directly connected to the pi2..
Is anyone else having this issue, or can help me troubleshoot what's going on to make sure I'm not missing something easy?
LED's are these:  http://www.amazon.com/gp/product/B00KFJTS86/ref=oh_aui_detailpage_o05_s00?ie=UTF8&psc=1

It sounds like you are on the right track. Sometime the 3.3v from the RPi will happily drive a WS2801strip but it doesn't seem consistent. I currently use an Arduino Uno connected via USB to the RPi to drive my WS2801 strip. I have experimented with connecting them directly to my RPi...it worked but introduced an annoying flicker and inconsistent brightness. I've been thinking about building a buffer circuit but the Arduino setup works so well I haven't been in a rush to do it.
If you have access to an Arduino I recommend using it to test your strip and Hyperion setup. If it all works with the Arduino you can be almost certain that it's the 3.3v causing your problem.
Hope that helps.

I also noticed the other day that the WS2801 strip I ordered was a 12v strip… I tried using a 12v @ 1A power supply (to the strip only)…wonder if that’s enough.  I was able to see some things flash / flicker but with no rhyme or reason —other than it seemed to happen when I moved wires around.
I purchased a buffer board (https://www.futurlec.com/Mini_Opto_Isolator.shtml https://www.futurlec.com/Mini_Opto_Isolator.shtml) and tried to use that too — but I’m not sure at this point if anything really works as I have no known-good point to work from.  I also ordered a WS2810 stand alone controller from amazon, thinking I could test the strip with that.. maybe..
Thanks for the reply and please excuse my noobishness in the area of electronics… I can do the work / follow instructions, but I’m pretty new to things like this, and the terminology / some of the principles are a little daunting to me.

On Jul 16, 2015, at 2:36 AM, croaker-1<EMAIL_ADDRESS>wrote:
It sounds like you are on the right track. Sometime the 3.3v from the RPi will happily drive a WS2801strip but it doesn't seem consistent. I currently use an Arduino Uno connected via USB to the RPi to drive my WS2801 strip. I have experimented with connecting them directly to my RPi...it worked but introduced an annoying flicker and inconsistent brightness. I've been thinking about building a buffer circuit but the Arduino setup works so well I haven't been in a rush to do it.
If you have access to an Arduino I recommend using it to test your strip and Hyperion setup. If it all works with the Arduino you can be almost certain that it's the 3.3v causing your problem.
Hope that helps.
—
Reply to this email directly or view it on GitHub https://github.com/tvdzwan/hyperion/issues/328#issuecomment-121862086.

I did notice your strip was 12v which, at first, I thought was odd but it turns out I had just never looked for 12v WS2801 strips before. Adafruit does a strand of 12v WS2801 LEDs https://www.adafruit.com/products/683 and, although different than yours, should have the same basic requirements. Reading through the specs for both strips (yours and Adafruits) it seems your power supply may not be providing enough current at 1A.  You will probably have better luck with a 5-6A 12v supply which are fairly common for driving LED strips. Adafruit also has a tutorial on wiring their strip and controlling it with an Arduino https://learn.adafruit.com/36mm-led-pixels/pwiring which may give you some insight on your setup.
I can really appreciate how these stuff can appear so simple on the surface but become deceptively complex once you start trying to apply it. I still fall into that trap more often than I'd like...it's a constant learning curve (especially when it is only hobby and not a profession) but man I enjoy it (especially LEDs)! I'm still a relative noob myself (only been at this for a couple of years) so I'm hoping that, if I am mistaken about anything, any more experienced folks here will correct me.

I have an old computer psu that I use for desk-assembling 12v stuff ... Think I'll try that next.  I would imagine (but I don't know) that the controller still wants a 5v signal.(?). Does it matter If the 3v or 5v comes from the pi and the 12v comes from an unconnected source?

On Jul 16, 2015, at 12:24 PM, Scot<EMAIL_ADDRESS>wrote:
I did notice your strip was 12v which, at first, I thought was odd but it turns out I had just never looked for 12v WS2801 strips before. Adafruit does a strand of 12v WS2801 LEDs https://www.adafruit.com/products/683 and, although different than yours, should have the same basic requirements. Reading through the specs for both strips (yours and Adafruits) it seems your power supply may not be providing enough current at 1A.  You will probably have better luck with a 5-6A 12v supply which are fairly common for driving LED strips. Adafruit also has a tutorial on wiring their strip and controlling it with an Arduino https://learn.adafruit.com/36mm-led-pixels/pwiring which ma y give you some insight on your setup.
I can really appreciate how these stuff can appear so simple on the surface but become deceptively complex once you start trying to apply it. I still fall into that trap more often than I'd like...it's a constant learning curve (especially when it is only hobby and not a profession) but man I enjoy it (especially LEDs)! I'm still a relative noob myself (only been at this for a couple of years) so I'm hoping that, if I am mistaken about anything, any more experienced folks here will correct me.
—
Reply to this email directly or view it on GitHub.

You are correct. The controller and the LED can have separate power sources as long as the grounds are tied together. Have a look at this image from the article I linked to earlier:

Should be done
Closed


Fix Histogram Concurrency Issue

Issue:
In Histogram, some values were being dropped when the histogram is accessed concurrently by multiple threads.
Fix:
In getOrCreateHistogram, the code was copying the dictionary into a local variable, and checking it for the label without a lock. If not there, it would take the lock again to add it. But in line 224, after taking the lock again, it was rechecking the local variable, which of course would not have changed in the meantime. But the original dictionary could have changed, and that's the one we should check the second time.
Improved the concurrency test, as it was missing the bug by only checking the total count and sum without labels.

Nice catch, thank you @Sam-Amin !
Sorry you've hit this but very thankful for the PR :)

I'll cut a 1.0.1 with this


Up/down buttons

Adding actions yielded from {{sortable-item}} to move up/down using buttons.

Closes #153.

[x] tests
[x] implementation
[x] demo
[x] docs

Thanks so much for the contribution. We’ll review it soon. In the meantime, could you squash the commits down to a single commit with a nice message such as Add move{Up,Down} item actions?

@jgwhite maybe I can help somehow?

Thanks for the nudge @H1D. Could you rebase and squash so we don’t have the Merge commit?

@jgwhite done

Thanks for the nudge.

@jgwhite well, I did refactor this.
Now group sorting based on item.index which can be set explicitly or via item.x / item.y update

Many thanks @H1D. I’m away over the weekend but will take a look next week.

Hey, sorry I’ve not gotten back to you on this. I like to take the time to really understand every addition and that time is proving hard to come by! I’ll get there, please keep nudging! Hi

👍  OK, I will

This project is now being maintained by the team at @heroku.
To get the project healthy and maintainable again, we're doing a bit of spring cleaning of older issues and pull requests.
This pull request still seems very valuable and we’d like to resume the conversation around it. Would you mind rebasing it upon master? If you’d rather not, let us know and we’ll look for ways to integrate the ideas.

@jgwhite a bit busy this month. But actually I will needs this functionality on my current project in a few month so definitely interested to have this merged.
P.S. I'm curious what happened with idea "let's rewrite this with ember-animated"? https://github.com/heroku/ember-sortable/issues/178

P.S. I'm curious what happened with idea "let's rewrite this with ember-animated"?

Haha 😅 I still this might be the future of ember-sortable, but we’d have to wait for ember-animated to become stable and battle-hardened, so it’s more of a distant-future idea.

Closing this as keyboard has been integrated in v2


fix fix data source properties do not persist in edit log

Proposed changes
Fix data source properties do not persist in edit log.

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Add CI

Add CI to test:

[x] Python scripts
[ ] Generated .mo files match output of Python scripts / are up-to-date
[x] Simulation coverage with OpenModelica
[x] Verification coverage with OpenModelica
[ ] Coverage with Dymola
[ ] CLA
[x] Add branch protection rules.

We won't test with Dymola.
Testing the Python script match the ANN in the Modelica examples is still open.


doc: write release notes

Go 1.7 beta needs proper release notes. They are in progress.

Slight change in compress/flate in that it now returns io.EOF eagerly. This may break some tests that incorrectly assumed flate never did that.

https://tip.golang.org/doc/go1.7 still mentions SizedReaderAt and File.Size
Also new package net/http/httptrace (https://tip.golang.org/pkg/net/http/httptrace/) is not mentioned.

Leaving these last few fixes for @adg. Thanks for catching those @kostya-sh. For that matter api/next.txt needs updating too.

@adg, in addition to what @kostya-sh said, see @dsnet's comment above.

I believe the docs are in good shape for the beta now.

Still no mention of net/http/httptrace
/cc @bradfitz

@tombergan I'm on it.

Ignore this update. Testing.

Hello!
not sure if this is separate issue or not.  My apologizes on nitpicking a sentence but this one confused me.   In the "Minor changes to the library" is this
compress/flate
As noted above, there are significant performance optimizations throughout the package.

It's not "noted above".  This is the first mention of compress/flate.  Its not noted in the performance section, although this appears to be a 2x improvement in many cases.
is this "significant" or "minor".  The is in the "minor changes" section but this is "significant". Which is it?

Maybe a simpler statement such as
"There are many performance optimizations throughout the package."
would be more clear.
Looking forward to 1.7
thanks!
n

@client9 good point.
@adg, others: should we close this out soon? What is remaining?

Seems done enough for me. I'd just fix @client9's thing and remove the DRAFT heading.


[UI] Use SMP to get list of service mesh for populating performance component

Use SMP to get list of service mesh for populating performance component
Render list after a call at SMP
Related Component - ui/components/MesheryPerformanceComponent.js

Fixed by https://github.com/layer5io/meshery/pull/1858


The CreateSPList flow doesn't work

I tried the "manual" way of creating the SP List last week and everything worked fine and I wanted to do it again today in a different domain with the Flow method and it didn't work. I have followed the steps one by one but when I run the flow it gives me this error:
Unable to process template language expressions in action 'Extracted_Tenant_Name' inputs at line '1' and column '2789': 'The template language function 'substring' parameters are out of range: 'start index' and 'length' must be non-negative integers and their sum must be no larger than the length of the string. Please see https://aka.ms/logicexpressions#substring for usage details.'.
As far as I know, I am putting the name of the Team correctly... Could anybody help, please?

I am having the same issue.

I am glad I am not the only one... Any solutions? It would be great to post the manual instructions back again, please. Thanks.

Solution:
Not the most elegant solution but it worked...
Delete the formula in the "Extracted Tenant Function" and replaced it with the manual string from the sharepoint url.
if the tenant sharepoint url is https://uniedu.sharepoint.com. paste https://uniedu in the "Extracted Tenant function".
Before

After

Thank you very much for your help @tinkerslab, but I couldn't make it work... I hope they either fix it or put the "manual" instructions back...

Same error. The workaround works for me but i'm still in error.
Last step, "For all Sharepoint sites" - Create session Metadata list. After 15 minutes give me a bad gateway error 502

Same error. The workaround works for me but i'm still in error.
Last step, "For all Sharepoint sites" - Create session Metadata list. After 15 minutes give me a bad gateway error 502

In the last step "for all SharePoint sites" the url is assembled for the SharePoint site created earlier. check if the url is assembled correctly and matches with the url of your SharePoint site. you can also check by visiting the url assembled in the last step.

Same error. The workaround works for me but i'm still in error.
Last step, "For all Sharepoint sites" - Create session Metadata list. After 15 minutes give me a bad gateway error 502

In the last step "for all SharePoint sites" the url is assembled for the SharePoint site created earlier. check if the url is assembled correctly and matches with the url of your SharePoint site. you can also check by visiting the url assembled in the last step.

The URL il correct
https://XXXXXXX.sharepoint.com/sites/Presenze
Altro trying to connect with the complete URL (https://XXXXXXX.sharepoint.com/sites/Presenze/_api/web/lists) returns a file
here's the error
{
"error": {
"code": 502,
"source": "europe-002.azure-apim.net",
"clientRequestId": "379e1890-754e-4593-bb15-6c100246060a",
"message": "BadGateway",
"innerError": {
"message": "Elenco, sondaggio, area discussioni o raccolta documenti con il titolo specificato già esistente in questo sito Web. Scegliere un altro titolo.\r\nclientRequestId: 379e1890-754e-4593-bb15-6c100246060a\r\nserviceRequestId: 960a529f-e044-b000-ccf4-709a39ae9121",
"status": 502,
"source": "https://XXXXXXXX.sharepoint.com/sites/Presenze/_api/web/lists",
"errors": [
"-2130575342",
"Microsoft.SharePoint.SPException"
]
}
}
}

This method worked for me. Thank you

The issue will be fixed with PR https://github.com/OfficeDev/microsoft-teams-apps-attendance/pull/23


Add test for measure-text

I merged some code earlier which touched this file, and realized it would be good to have a test around it.

Thanks!


Improved/added alt text

to improve readability for screen-readers

@dbeezt Thanks for your contribution. However talks.sourced.tech is no longer. So I don't think we'll merge this one.
cc @campoy should we archive this repo ?

Indeed, this repo is not active anymore.
I'll close this PR and archive the repo.
Sorry for the inconvenience, @dbeezt !


Observable.bufferTimedWithPressure operator with custom counting function

I need an operator that consider the sum of the size of elements as the count instead of the count of elements.
Something like:
def bufferTimedWithPressure[A](period: FiniteDuration, maxSize: Int, sizer: A => Int): Observable[Seq[A]]
The existing one could be rewritten in terms of the new:
def bufferTimedWithPressure[A](period: FiniteDuration, maxSize: Int): Observable[Seq[A]] = bufferTimedWithPressure(period, maxSize, _ => 1)
I implemented a version in our code base, I can propose a pull request.

This issue look sa lot like https://github.com/monix/monix/issues/447 but on another operator.

If you already have implementation, PR should help in decision and having it in time for 3.0.0 :)

Ok @Avasil I'll try my best to submit it promptly :)


If some one forked this repository this should automatically work under his username

What is left for forked user

Rename project
Set analytics id

Lets setup a config.json and get the custom settings like

Logo URL
Org/Profile Name
GITHUB User name (org name/ personal)
Google Analytics Code snippet

Can you give me some extra tips? I would like to help.

yeah. we can have a seperate json file including the custom options like the above mentioned,
Logo URL
Org/Profile Name
GITHUB User name (org name/ personal)
Google Analytics Code snippet
then we can load them in js, this will make the configuration part easy for a user who just fork the repo and hoping to use it

@PedroCSSilva Did you start to look into this ?

I'll look at it during the weekend, sorry guys.


Auto-refresh Bounds after setBounds()

Once we setBounds() it would be nice to have a way at a later time to stop using the set bounds and go back to automatic bounds calculation.  Maybe a clearSetBounds() which then sees if the bounds can be calculated and if so calculates, and if not then sets the bounds to null and proceeds as if they have never been set.  Cheers!

You can pass null to the setBounds method.   See the docs for the first parameter.

Thanks for the quick response - that makes sense.

Hmmm... just trying this out and I can't seem to get it to work.  I am getting 0 width after setting bounds to null.  It does not seem to matter if I move the c.addChild(r) around - and a delay did not help either.  If I do not set the bounds of c at all then the width does calculate correctly to 100.
var r = new createjs.Shape();
r.graphics.f("black").dr(0,0,100,100);
r.setBounds(0,0,100,100);

var c = new createjs.Container();
stage.addChild(c);
c.setBounds(0,0,10,10);
c.setBounds(null);
c.addChild(r);
// setTimeout(function() {
console.log(c.getBounds().width); // 0 - but should be 100
//}, 1000); // still 0

Looks like we are missing a return statement in setBounds(). Easy fix - it will be in the next release.
if (x == null) { this._bounds = x; return; }

Not sure - it seems this one did not get in the new versions 1.0?  I am getting a width of 0 for a container with setBounds(null);  Even if there is something in the container with the bounds set.  I tried re-adding the object with bounds to the container but still get 0 for the container bounds.

Hmm. The fix I mentioned above is definitely in place. Any chance you could toss a quick codepen or jsfiddle together and I'll take a look?

Ah - my fault - thought I was in a new file but was remaking some gesture work to act around pinch points when I tested this - and indeed, the CreateJS was an old one.  So sorry - yes it is working and glad it is working ;-)

Hey folks, Adobe Animate is using https://code.createjs.com/createjs-2015.11.26.min.js and this bug is still in that version.  So just founds a solution to reset the bounds based on Grant's internal fix.  If you set myObject._bounds = null; it does what myObject.setBounds(); should do and does do in newer versions of CreateJS.  Whew.


Aurora-mysql rotation fix

Within this file:
SecretsManagerRDSMySQLRotationSingleUser
/lambda_function.py
I found a verfication check that only supports mysql.
From my testing, I found that changing from aurora-mysql to just mysql creates a functional password rotation for the aurora-mysql db
Found on line 421:
    if 'engine' not in secret_dict or secret_dict['engine'] != 'mysql':
        raise KeyError("Database engine must be set to 'mysql' in order to use this rotation lambda")
    for field in required_fields:
        if field not in secret_dict:
            raise KeyError("%s key is missing from secret JSON" % field)

Propsed fix:
    if 'engine' not in secret_dict or (secret_dict['engine'] != 'mysql' and secret_dict['engine'] != 'aurora-mysql'):
        raise KeyError("Database engine must be set to 'mysql' in order to use this rotation lambda")
    for field in required_fields:
        if field not in secret_dict:
            raise KeyError("%s key is missing from secret JSON" % field)

This will allow for the verfication to pass aurora-mysql

Thank you for reaching out, we added the aurora engine types for the MySQL single user rotation lambda in the most recent PR.


Easier way to access answers than stream.meta.answers?

Maybe we make the first arg be (answers, ctx, meta) or something?

See https://github.com/saojs/sao/blob/master/CHANGELOG.md#version-0214-2017-8-20 I added it to ctx 😅

❤


Upgrading From 1.0.0 (timex_ecto 0.7.0) to 2.1.0 (1.0.1)

Steps to reproduce

Timex.set(%Timex.Date{}, month: Timex.month_to_num(month), year: year),
Repo.update(changeset)
"January", 2012

Description of issue

What are the expected results?
When attempting to create/update a Timex.Ecto.Date field I get the following error:

** (CaseClauseError) no case clause matching: {{2020, 1, 1}, {0, 0, 0}}
       (ecto) lib/ecto/query/planner.ex:29: anonymous fn/6 in Ecto.Query.Planner.fields/4
     (stdlib) lists.erl:1262: :lists.foldl/3
       (ecto) lib/ecto/query/planner.ex:21: Ecto.Query.Planner.fields/4
       (ecto) lib/ecto/repo/schema.ex:449: Ecto.Repo.Schema.dump_changes/5
       (ecto) lib/ecto/repo/schema.ex:146: anonymous fn/11 in Ecto.Repo.Schema.do_update/4
       (ecto) lib/ecto/repo/schema.ex:477: anonymous fn/3 in Ecto.Repo.Schema.wrap_in_transaction/9
       (ecto) lib/ecto/pool.ex:292: Ecto.Pool.with_rollback/3
       (ecto) lib/ecto/adapters/sql.ex:582: Ecto.Adapters.SQL.transaction/8
       (ecto) lib/ecto/pool.ex:244: Ecto.Pool.outer_transaction/6
       (ecto) lib/ecto/adapters/sql.ex:551: Ecto.Adapters.SQL.transaction/3
     (stdlib) erl_eval.erl:669: :erl_eval.do_apply/6
        (iex) lib/iex/evaluator.ex:135: IEx.Evaluator.handle_eval/6
        (iex) lib/iex/evaluator.ex:128: IEx.Evaluator.do_eval/4
        (iex) lib/iex/evaluator.ex:108: IEx.Evaluator.eval/4
        (iex) lib/iex/evaluator.ex:27: IEx.Evaluator.loop/3
        (iex) lib/iex/evaluator.ex:18: IEx.Evaluator.init/3

I've updated to the most recent timex and timex_ecto (at the time 2.1.0, and 1.0.1, respectively).
Note: I'm running ecto 1.1.3; is 2.0.0-beta required?

I'll take a look ASAP, thanks for reporting!

I've pushed a new release 1.0.2 of timex_ecto with the bugfix for this. It was a stupid issue, I definitely need a proper test suite for timex_ecto :/

Thanks for getting this out so quickly!
That resolves one issue, but it comes up with another:
** (FunctionClauseError) no function clause matching in Ecto.Adapters.Postgres.DateTime.encode_date/1
lib/ecto/adapters/postgres/datetime.ex:36: Ecto.Adapters.Postgres.DateTime.encode_date({{0, 1, 1}, {0, 0, 0}})

I think that postgres/datetime.ex maybe doesn't like the {{y, m, d}, {h, m, s}} format that Timex.to_erlang_datetime outputs (refer to: https://github.com/elixir-lang/ecto/blob/master/lib/ecto/adapters/postgres/datetime.ex#L36).
Around https://github.com/bitwalker/timex_ecto/blob/master/lib/types/date.ex#L54, could this be a possible solution:
  def dump(%Date{} = date) do
    {ymd, _} = Timex.to_erlang_datetime(date)
    {:ok, ymd}
  end

My apologies if I'm misunderstanding the nature of the issue.

@baoist Ok, this time I spent extra time actually roundtripping all the types to the database and back a few different ways. New release is 1.0.3. Should be solid now!


laravel policy @can

-->

Laravel Version: 5.5
PHP Version:
Database Driver & Version:

Description:
i have created a policy and also register it and create a method inside the policy but when i call that method using @can nothing is displaying iam uploading my project file as well as database kindly help me
Steps To Reproduce:
cms.zip

You forgot to read this part when you created the issue:

Please use this issue tracker only for reporting Laravel bugs.
If you need support, please use the forums:

https://laracasts.com/discuss
https://laravel.io/forum

Alternatively, you may use Slack (https://larachat.co/) or Stack Overflow (http://stackoverflow.com/questions/tagged/laravel).
If you would like to propose new Laravel features, please make a pull request, or open an issue at https://github.com/laravel/internals/issues.


The maintenance of a nix package/module

Packaging has been noted in episode 9, https://www.youtube.com/watch?v=VpUHb-GagBE
But once you have something upstreamed or in your own repo. How do you go about maintaining it for the long term? The strategies with tooling/CI to help make it easier for you. The new passthru.tests, passthru.updateScript options (maybe mention nix-update), their value to a well maintained package.

We talked more about this in the last Nix Hour, as always feel free to open another issue if there's more though :)


Bash .inc misclassified as PHP

Preliminary Steps
Please confirm you have...

[x] reviewed How Linguist Works,
[x] reviewed the Troubleshooting docs,
[ ] considered implementing an override,
(not my own repo)
[x] verified an issue has not already been logged for your issue (linguist issues).

Problem Description

ionic-team/ionic-storage has a Bash .inc file misclassified as PHP. Obviously the file does not match any of the heuristics. Maybe .inc should be added as a Bash file extension? (I have no idea how popular Bash .inc files are and further investigation is needed.)
URL of the affected repository:
https://github.com/ionic-team/ionic-storage
Last modified on:

Commit 1da388.
Expected language:

Bash, or none.
Detected language:

PHP

🤔 I don't believe .inc is an extension officially associated with Bash, or any shell language, so I'm not sure if it's right to add it. It would also be really hard to a) search for these on GitHub and b) implement a heuristic to differentiate Bash .inc files from PHP's (or any other language that uses this extension officially - we're missing heuristics for quite a few of these) so others don't end up in the situation you're reporting.
A better option would be to use an official extension like .sh or .bash, or add a shebang or modeline to the script. All of these would also ensure editors automatically select the correct grammar too. For within the repo, there's the option of an override too.


Menu doesn't automatically close when clicking a submenu item

I found this comment in the previous project describing the same problem.
Desktop:

OS: Windows 10
Electron version: 11.0.0-nightly.20200818
Node Version: 12.18.3

Reproduceable on the latest version of the example application.

Fixed with release 4.1.5. Thanks for reporting the issue!

Thanks for the quick fix!


Change few parameters (terrain, speed,...)

Hello,
I am currently working on DeepMimic and using the commit 521d348 (the last one to this day to my knowledge).
I am wondering whether it is possible to change the speed of the character as it seems to be the case in the video : can we graphically display the speed and make it vary when launching DeepMimic via python DeepMimic.py? Or is it only changeable in the training?
Moreover, I would like to change the terrain, add obstacles like boxes put on the trajectory. Is it possible to do that in the current version?
Best regards,

What do you mean by change the speed of the character? You mean changing the target speed that the character should walk/run in? If so, you can run run_amp_heading_humanoid3d_locomotion_args.txt, and decrease/increase the target speed using the '1' and '2' keys.
The code currently doesn't include obstacles. But you can modify the simulation to add objects in the sim with bullet.

Yes, I meant the target speed. Thank you for the answer.
Do you know how to modify the terrain? For example, adding holes etc.


Lets make cmd line argument for running blazingly-fast-releases

Lets make cmd line argument for running blazingly-fast-releases.

https://github.com/spf13/cobra

Users can do:
$ go install github.com/LeeWannacott/blazingly-fast-releases@latest
$ blazingly-fast-releases -target=leewannacott/blazingly-fast-releases -tags=quick-lint/quick-lint-js -token=$(cat token.txt) -changelog=docs/CHANGELOG.md
Good enough for now.


Snowplow migration doc

What do these changes do?
Created doc for Snowplow migration

@1abhishekpandey @pallabmaiti All the comments are addressed.


[Bug] Display unique challenge sponsors and challenge contributors

This ticket actually is no needed~ Sorry, close now.


Performance issues when expanding and collapsing the lists

🐛 Bug Report
Prerequisites

[X] I'm using the latest version of Docusaurus.
[x] I have tried the npm run clear or yarn clear command.
[X] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[] I have tried creating a repro with https://new.docusaurus.io
[] I have read the console error message carefully (if applicable)

Description
When we collapse or expand the lists, it is processed with a slow speed.
Have you read the Contributing Guidelines on issues?
Yes.
Steps to reproduce

Open the link:
https://docs.dhtmlx.com/suite/
Try collapsing and expanding the entries in the left menu.
It is done with a slow speed.

Expected behavior
The entries should be expanded and collapsed with a higher speed.
Actual behavior
The entries are expanded and collapsed with a slower speed.
Your environment

Public source code:
https://github.com/DHTMLX/docs-suite
Public site URL:
https://docs.dhtmlx.com/suite/
Docusaurus version used:
2.0
Environment name and version (e.g. Chrome 78.0.3904.108, Node.js 10.17.0):
91.0.4472.106
Operating system and version (e.g. Ubuntu 20.04.2 LTS):
Xubuntu 18.04.5

Reproducible demo
Demo:
https://docs.dhtmlx.com/suite/
Video:
https://files.dhtmlx.com/30d/755a3520f276b7a56857bc950354de17/vokoscreen-2021-06-30_16-56-23.mkv

Please use canary and test on your site to see if it improves anything: https://docusaurus.io/community/canary


Add env_vars to extra_arguments terraform block

This PR implements env_vars support as described in Issue #319 .

I'll merge now and let the tests run. Once they pass, I'll issue a new release, and paste the link here.

https://github.com/gruntwork-io/terragrunt/releases/tag/v0.16.8


Aggregate event logs for unsupported chains

Summary
Changes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

8 of 13 (61.54%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.05%) to 90.655%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/domain/hooks/hooks.repository.ts
8
13
61.54%

Totals

Change from base Build<PHONE_NUMBER>6:
-0.05%

Covered Lines:
8362

Relevant Lines:
8853

💛  - Coveralls


AreEquals and AreNotEquals seems to do opposite validation

Following the course from balta.io and using a code line as follows:
.AreEquals(0, subscription.Payments.Count, "Student.Subscription.Payments", "Esta assinatura não possui pagamentos."));
subscription.Payments.Count is 1 in this context.
So it should add a notification, does not? (I understand they are different, so add a notification). It's not adding one.
It only worked when I changed the condition to .AreNotEquals.

@munizig hey, i fix some AreEquals here, https://github.com/andrebaltieri/flunt/pull/32

@munizig hey, i fix some AreEquals here, #32

Tks Claudio, but for longs it is still the same. But, is it really makes sense to compare opposite of function's name? Function AreEquals testing if they are different to add notification? I'm understanding when they are Equals, add an error (notification).
public Contract AreEquals(string val, string text, string property, string message, StringComparison comparisonType = StringComparison.OrdinalIgnoreCase)
        {
            if (!val.Equals(text, comparisonType))
                AddNotification(property, message);

            return this;
        }

All of other methods are test this way, like
public Contract IsNullOrEmpty(string val, string property, string message)
        {
            if (!string.IsNullOrEmpty(val))
                AddNotification(property, message);

            return this;
        }

they test the opposite way, i think because if you are test some input of a user and you need a property to be not null you will add a notification if they are null, because if are not null you can continues the flow.

Thanks guys! Merged the PRs with the bug fixed!


Docs: Added Acknowledgement to ReadME, Changed Contact Us Email add.

Very Minor changes.

Coverage remained the same at 90.571% when pulling bdfef28054e09d6e49b66057402e5d89582a9715 on hanselblack:ReadMe into d7ca469f4d405547e8cfbdd4231534f134af60fa on CS2103AUG2017-W11-B4:master.


Migrate to Red Hat Build of Quarkus

See https://access.redhat.com/documentation/en-us/red_hat_build_of_quarkus/quarkus-3.2/guide/8c2d0754-31e2-4d6d-9d5f-9ade55c3b30d for instructions for 3.2; it'll probably be similar for later versions.
We'll want to wait for RHBQ 3.7/3.8 to be out, because migrating now would mean downgrading from Quarkus 3.6 to 3.2, and that would mean some annoying changes in tests.

Now we'd have to wait for a 3.10+ as we are using the standalone mapper.
And thinking more about this particular one, do we really want to stay on a RHBQ version or stay on the latest available and be able to test any new features we add to Search on a real application?

do we really want to stay on a RHBQ version or stay on the latest available and be able to test any new features we add to Search on a real application?

Depends who "we" is. Personally, I'd vote for the latest. But I understand the core Quarkus teams may want to focus testing on LTS.
I think we'll probably end up doing this only if some compelling arguments show up, or if someone else who thinks it's a good idea actually puts in the work to maintain this project.
So... let's put this on ice.