django-stubs: Testing related refactorings

A series of changes related to the backend test suites and tooling.
Affected errors:
6c6
< Found 143 errors in 40 files (checked 1405 source files)
---
> Found 127 errors in 38 files (checked 1405 source files)
11,13d10
< tools/test-backend error "int" object is not iterable  [misc]
< tools/test-backend error "DiscoverRunner" has no attribute "get_shallow_tested_templates"  [attr-defined]
< tools/test-backend error Cannot determine type of "failures"  [has-type]
70d66
< zerver/lib/test_runner.py error The return type of a generator function should be "Generator" or one of its supertypes  [misc]
72d67
< zerver/lib/test_runner.py error Module has no attribute "multiprocessing"  [attr-defined]
76,91d70
< zerver/lib/test_runner.py error Signature of "run_tests" incompatible with supertype "DiscoverRunner"  [override]
< zerver/lib/test_runner.py note          def run_tests(self, test_labels List[str], extra_tests Optional[List[Any]] = ..., **kwargs Any) -> int
< zerver/lib/test_runner.py note          def run_tests(test_labels List[str], extra_tests Optional[List[TestCase]] = ..., full_suite bool = ..., include_webhooks bool = ..., **kwargs Any) -> Tuple[bool, List[str]]
< zerver/lib/test_runner.py note      Subclass
< zerver/lib/test_runner.py note      Superclass
< zerver/lib/test_runner.py error "TextTestResult" has no attribute "failed_tests"  [attr-defined]
< zerver/lib/test_runner.py error Incompatible return value type (got "Tuple[int, Any]", expected "Tuple[bool, List[str]]")  [return-value]
< zerver/lib/test_runner.py error "TestCase" has no attribute "__iter__" (not iterable)  [attr-defined]
< zerver/lib/test_runner.py error "yield from" can't be applied to "TestCase"  [misc]
< zerver/lib/test_runner.py error "TestCase" has no attribute "__iter__" (not iterable)  [attr-defined]
< zerver/lib/test_runner.py error Argument 1 of "startTest" is incompatible with supertype "TestResult"; supertype defines the argument type as "TestCase"  [override]
< zerver/lib/test_runner.py note See https//mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
< zerver/lib/test_runner.py note This violates the Liskov substitution principle
< zerver/lib/test_runner.py error Argument 1 of "addSkip" is incompatible with supertype "TestResult"; supertype defines the argument type as "TestCase"  [override]
< zerver/lib/test_runner.py note See https//mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
< zerver/lib/test_runner.py note This violates the Liskov substitution principle
134,136d112
< zerver/tests/test_rate_limiter.py error "RateLimiterBackendBase" has no attribute "backend"  [attr-defined]
< zerver/tests/test_signup.py error "_MonkeyPatchedWSGIResponse" has no attribute "context_data"  [attr-defined]
< zerver/tests/test_signup.py error "_MonkeyPatchedWSGIResponse" has no attribute "redirect_chain"  [attr-defined]

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

I merged most of the commits as the series ending with 04d4c6a453a6f08212c9e202fa190851abb9398b; have a few concerns about some of the test_runner.py changes.

Merged after resolving the trivial merge conflict, thanks @PIG208!

Hey @PIG208, how did you fix the error "_MonkeyPatchedWSGIResponse" has no attribute "context_data"? Getting this in another project of mine, and this is the single google result for this error message.

Hey @PIG208, how did you fix the error "_MonkeyPatchedWSGIResponse" has no attribute "context_data"? Getting this in another project of mine, and this is the single google result for this error message.

That commit was 209bc5f3b73c1c502cdfb5df9b3240a755587381. It got merged separately so it did not show up in this PR. It was explained in the commit message.

Thanks @PIG208, appreciate it.


Refactor dartdoc.dart for proper versioning

[TODO audit]
From original TODO : https://github.com/flutter/flutter/blob/72986f7bcf8b0a4f9566076f8500975e7ba8fdd7/dev/tools/dartdoc.dart#L53

// TODO(dnfield): We should make DartDoc able to avoid emitting this. If we
// use the real value here, every file will get marked as new instead of only
// files that have otherwise changed. Instead, we replace it dynamically using
// JavaScript so that fewer files get marked as changed.
// https://github.com/dart-lang/dartdoc/issues/1982

https://github.com/dart-lang/dartdoc/issues/1982 was resolved by https://github.com/dart-lang/dartdoc/pull/2010
Regarding next actions here, per @dnfield

https://github.com/dart-lang/dartdoc/pull/2010/files added the ability to exclude the version in the footer info. I can no longer remember if it makes more sense to still do it this way or not - we would still want to inject the actual version number at runtime, but if we can make that dartdoc option work with that logic we can drop the ogic here that is forcing the version to initially appear as 0.0.0.

This is all being done to prevent firebase from seeing us changing every single page of the docs on every single commit.

I'm going to close this. What we have works, and it's not worth making a small and potentially erroneous change to end up doing the same thing.


This looks great, what library would you recommend to transform to png?

I just convert the files locally with Inkscape using a .bat file:
pushd my_folder_path 2>NUL || Exit /B
for %%i in (*.svg) do "c:\Program Files\Inkscape\inkscape" -d 85.33 -z %%i -e %%~ni.png
popd

Closed


Update Toaster-Eats Site

Update the Toaster-Eats Github Page:

Add personal github or linkedIn links of each member to Team section
Update Screenshots of site
Update description of each section if needed
Update Link to Deployment to the https link (currently broken)

Added techfolio links for all members
Updated landing, login, and sign up page descriptions
Updated link to live deployment


ref(scheduler): move away from using num internally and use the more descriptive replicas variable name

Current coverage is 81.84%

Merging #553 into master will increase coverage by +0.04% as of 008b844

@@            master    #553   diff @@
======================================
  Files           36      36
  Stmts         2303    2303
  Branches       331     331
  Methods          0       0
======================================
+ Hit           1884    1885     +1
+ Partial        116     115     -1
  Missed         303     303

Review entire Coverage Diff as of 008b844

Powered by Codecov. Updated on successful CI builds.


Implement OAuth2 PKCE

Additional security for the OAuth2 code flow
https://oauth.net/2/pkce/

https://www.oauth.com/oauth2-servers/pkce/

Note that since this will require storing the challenge key in the DB at the start of the login process (which currently doesn't result in any DB changes), we might as well store the state value there as well instead of in a cookie as in the current implementation.

Note that these changes will cause any in flight logins and links to fail on server restart.
Strategy of attack:

Rename some temp session data operations and methods to prep for the new login start temp session data.
Update the temp session data class to handle the login start op and new challenge key
On login and link start, now store the challenge key with the temp session data and return the SHA256 hashed, Base64 w/ url variant encoded challenge key & token
a. Check the expiration time for the link start token, use the same for the login start token.
Send the hashed challenge key to the 3rd party
On link / login complete, send the unhashed key to the 3rd party along with the access code
a. Check how temp session data is deleted for the link start cookie and do the same thing
Manually test with all 3 3rd party ID providers, including sending a bad challenge key.
a. Equivalent unit and integration tests should be added where possible, but doing integration tests where the flow runs through manual data entry in a 3rd party website is a non-starter

Note that OrcID does not support PKCE. Google and Globus do, however: https://github.com/ORCID/ORCID-Source/issues/5977


PackageManagement is broken in the latest alpha-12 on Linux

A user reported in https://github.com/OneGet/oneget/issues/239 that OneGet is broken in the Alpha12 on Linux.
Debugging into the issue, the following line seems causing the problem.  Microsoft.Win32.Registry throws an exception now which is peace and safe before. Per Dongbo, it is caused by the latest CoreCLR change.
System.TypeInitializationException
"Operation is not supported on this platform."
"Microsoft.Win32.Registry"
"   at Microsoft.Win32.RegistryKey.OpenBaseKeyCore(RegistryHive hKey, RegistryView view)\n   at Microsoft.Win32.Registry..cctor()"
Source: https://github.com/OneGet/oneget/blob/master/src/Microsoft.PackageManagement/Implementation/PackageManagementService.cs
      internal void LoadProviders(IHostApi request) {
       …

           var providerAssemblies = (_initialized ? Enumerable.Empty<string>() : _defaultProviders)
               .Concat(GetProvidersFromRegistry(Registry.LocalMachine, "SOFTWARE\\MICROSOFT\\PACKAGEMANAGEMENT"))
               .Concat(GetProvidersFromRegistry(Registry.CurrentUser, "SOFTWARE\\MICROSOFT\\PACKAGEMANAGEMENT"));

Steps to reproduce
Install the alpha12 on Linux
Get-PackageProvider
Expected behavior
PowerShellGet and NuGet providers should be listed from Get-PackageProvider
Actual behavior
Nothing returned. No assemblies are successfully initialized.
Environment data

PS /opt/microsoft> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      6.0.0-alpha
PSEdition                      Core
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   <IP_ADDRESS>
GitCommitId                    v6.0.0-alpha.12
CLRVersion
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

I am going to make PR soon

In Powershell for macOS is the same error

@jianyunt Is this issue resolved? if so, please close it, mark it fixed, and place it in the alpha.12 milestone. If you don't have permissions for that, let me know.

@mirichmo yes, checked-in. Can you place it to alpha12 milestone. After that i can close it.

I'm closing it since I am already modifying it.


when I am doing 'python create_slides.py --file static/presentation_template.ipynb'

subprocess.CalledProcessError: Command '['jupyter', 'nbconvert', './static/presentation_template.ipynb', '--to', 'slides', '--reveal-prefix', 'reveal.js-3.1.0', '--config', 'static/slides_config.py']' returned non-zero exit status 1.

Had the same. The filename of the hupyter_template.tpl has to be specified. There is a followup though jinja2.exceptions.TemplateNotFound: slides_reveal.tpl

@datitran are you still using this?

https://github.com/jupyter/nbconvert/issues/1528


Execute integration tests on Travis

Currently we do not execute the integration tests included in this repo in our CI tool.
Expected Behavior
Travis should automatically execute integration tests in addition to the other tests it currently executes.
Current Behavior
Travis executes the included unit tests but not the integration tests.

We support many different platforms and have tests for each, so it's likely worth splitting this down as many tasks for getting the different platform tests working.

because we are going to have to manage services I would suggest using kitchen-dokken. If you need help with this let me know and I can work with you on it.


fix: NPM publish

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
Fix release CI. Failing because npm scope is not specified

I think you can rename the commit to: ci: XXX instead of fix:
Fix is more for a fix within the lib itself.


how to get parent  index when click the child

I'm not able to get parent and child index individually I'm able to get id but when click the child I want to get the parent id.

Child Index returns wrong Value


arpeggiate support added

fixes #64

@jaredjj3 hope you like it :)

It looks great! Thanks for your patience, I'll try to review soon.


fix: optimize graphql requests

Description
Some users have reported facing 502 errors when using the GitHub Beta extension. This PR intends to fix it by optimizing the GraphQL requests:

Split the repository fragment into two versions: a short one used in issues and PRs commands and an extended one for the Search Repositories command
Fix some number of items to match the native extension

I also removed the avatarSize parameter. I didn't see how such a parameter would be useful since we always want the same size.
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

FYI: I tested this locally and the command is now working for me, whereas before it wasn't.


[Bug] Signature created outside VM is not valid in circuit

🐛 Bug Report
Hey, I'm trying to sign an arbitrary string (byte array) outside VM (in SDK) and validate it inside Aleo transition but it always fails.
Steps to Reproduce
First, I convert a string to a field in the same way it's done in VM:
(i'm tapping into aleo-wasm, also new to Rust, so my code is not perfect)
        let s = "test";
        let bytes = s.as_bytes();
        let bits = &bytes.to_bits_le();
        let fields = bits.chunks(FieldNative::size_in_data_bits()).map(FieldNative::from_bits_le).collect::<Result<Vec<FieldNative>,anyhow::Error>>().unwrap();

the resulting field is<PHONE_NUMBER>field
When I use SDK I just do
const bytes = textEncoder.encode('test')
const sign = account.sign(bytes)

The example signature for the following private key
APrivateKey1zkp5gkX61etNqNTibpEaZD7tC8FJV2NxYQQtwyzKgGY9vwD
and its address
aleo1zen02agt7udrz24ffqddfe633s8cuecjy4p4qg03p5vfukvrjqfqvx2tyc
and the string/field above is :
sign1mdks5v7yypepq6dqpk0zw3vlq3dha7l9wq6eghjdyvg8ehpwxgp7x0sj2mkhj9ywd5qltt7nuaeg55drmglju3p6uq97w5qfejlg6pr9c6pajt957g355dkue2l8mq00x7ur3zrlavsnvzyradh6kkcrqdpvfyd7pzwmn5s6f2v0mh6qcf92sqx7ng8lnxraqufle0dvkq2pz7na86y
which is valid if I verify in in both SDK and in sample Rust code
It's also valid if I verify it against field itself:
        let field = FieldNative::from_str("1953719668field").unwrap();
        let fields = vec![field];
        let signature = SignatureNative::from_str("sign1mdks5v7yypepq6dqpk0zw3vlq3dha7l9wq6eghjdyvg8ehpwxgp7x0sj2mkhj9ywd5qltt7nuaeg55drmglju3p6uq97w5qfejlg6pr9c6pajt957g355dkue2l8mq00x7ur3zrlavsnvzyradh6kkcrqdpvfyd7pzwmn5s6f2v0mh6qcf92sqx7ng8lnxraqufle0dvkq2pz7na86y").unwrap()
        let address = Address::from_str("aleo1zen02agt7udrz24ffqddfe633s8cuecjy4p4qg03p5vfukvrjqfqvx2tyc").unwrap();
        assert!(signature.verify(&address, &fields));

BUT
If I put it in leo transition:
    transition verify_field(public s: signature, public a: address, public v: field) ->bool {
        return signature::verify(s, a, v);
    }

with these inputs:
[verify_field]
public s: signature = sign1mdks5v7yypepq6dqpk0zw3vlq3dha7l9wq6eghjdyvg8ehpwxgp7x0sj2mkhj9ywd5qltt7nuaeg55drmglju3p6uq97w5qfejlg6pr9c6pajt957g355dkue2l8mq00x7ur3zrlavsnvzyradh6kkcrqdpvfyd7pzwmn5s6f2v0mh6qcf92sqx7ng8lnxraqufle0dvkq2pz7na86y;
public a: address = aleo1zen02agt7udrz24ffqddfe633s8cuecjy4p4qg03p5vfukvrjqfqvx2tyc;
public v: field =<PHONE_NUMBER>field;

It returns false
I'm out of ideas, maybe you have any

See this comment for a sample usage.
https://github.com/AleoHQ/sdk/issues/748#issuecomment-1729578823

@onetrickwolf see the above discussion, do we have an existing example or test of creating a signature using the SDK's aleo-wasm and verifying it in a transition? If not can you make one whenever you have time?

The SDK code for signing runs the signature algorithm outside of the context of a circuit. However when running a circuit via a leo function, and given the function executes properly and gives you a false there is no problem here.
What I imagine is happening here is that Leo types like Field Scalar Group etc. have a canonical byte encoding that is different from what you would get if you do:
const bytes = textEncoder.encode('123Field')
const sign = account.sign(bytes)

The code above will create utf-8 bytes which will lead to a different byte encoding than the 123Field type.  And this why this function is likely failing:
    transition verify_field(public s: signature, public a: address, public v: field) ->bool {
        return signature::verify(s, a, v);
    }

Currently there's not yet a function that will first try to serialize these types into the correct byte encoding in the SDK, but I'll put a ticket in to support this.

@iamalwaysuncomfortable I've traced what the word 'test' turns into when being signed and it turns into field<PHONE_NUMBER>field which is when verified on its own out of the circuit returns true. There are examples of that above.
However if I put the very same field in the circuit it fails. That's what confuses me

Can you post your Leo code + the leo run invocation you're using? This will help us reproduce this.


Branded and responsive styling

This PR inclides:

Changed font-family to Manrope same as https://near.org/brand/
Changed text, background, border, box-shadow colors with the NEAR palette I got from the above link.
Changed paddings, margins, leter-spacing, font size, font-weight following the Typograpy section.

These are the only aspects I worked until now in this #73 issue.

Does this correctly handle styling for "light" and "dark" themes? I ask because the task description shows us styling for what only looks like a "dark" theme


Better Error Reporting during Static Build

Let's revisit this by improving reports closer to the analyzer, not just for the static build.


[add-resource] New Plugin: grav-plugin-social-seo-metatags

Hello,
I would like to add my new plugin to the Grav Repository. Here are the project details:
https://github.com/clemdesign/grav-plugin-social-seo-metatags

Added to GPM for next release


Push Notification is not working in iOS 10 but yes in iOS 11

Describe your environment

Xcode version: 9.4
Firebase SDK version: Last in CocoaPods
Firebase Component: Messaging
Component version: Last in CocoaPods

[REQUIRED] Step 3: Describe the problem
iOS 10.3 device can't receive push notification fired from our custom backend.
Steps to reproduce:
First the project has been configured for push notifications and the device FCM is sent and registered in backend properly.
Then there are two scenarios:
a) Push is sended to a token id from the testing Firebase Messaging Console.

iOS 10.3 devices receive the push (notification is displayed and UNUserNotificationCenterDelegate methods are fired)
iOS 11.4 devices receive the push (notification is displayed and UNUserNotificationCenterDelegate methods are fired)

b) Push is sended to a token id from the backend.

iOS 10.3 devices does not receive the push (notification is not displayed and UNUserNotificationCenterDelegate methods are not fired)
iOS 11.4 devices receive the push (notification is displayed and UNUserNotificationCenterDelegate methods are fired)

The code for both iOS versions is the same and the way to manage push notifications in iOS 10 and 11 is the same so we can't find what is wrong.
Thanks.

What payload are you sending from the backend?

{
    "apns": {
        "payload": {
            "aps": {
                "alert": {
                    "title": "You have a new message"
                },
                "mutable-content": 1
            }
        }
    },
    "token": "TOKEN HERE",
    "notification": {
        "title": "You have a new message"
    }
}

{
  "apns": {
    "payload": {
      "aps": {
        "alert": {
          "title": "You have a new message"
        },
        "mutable-content": 1
      }
    }
  }
}

I have the same problem. I am using the old API. I have no idea why but if I send notification to single fcm token it is not working. It is not even displaying the notifications.

Are you able to send directly through APNs? This will help us isolate whether or not it's an issue in the client or an issue in FCM.

@morganchen12 Yes I am able to send through APNs.

Check if Method swizzling is on in the Info.plist. If it is on, turn it off.

On 23 Aug 2018, at 11:16, jmorgaz<EMAIL_ADDRESS>wrote:
@morganchen12 https://github.com/morganchen12 Yes I am able to send through APNs.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/firebase/firebase-ios-sdk/issues/1723#issuecomment-415332078, or mute the thread https://github.com/notifications/unsubscribe-auth/ADrjrUTZnZdTcnmPWbTR3XYjy9qYKGBdks5uTmTrgaJpZM4WFsLS.

@StarbuckBG do you mean FirebaseAppDelegateProxyEnabled key?

Yes.

On 23 Aug 2018, at 11:54, jmorgaz<EMAIL_ADDRESS>wrote:
FirebaseAppDelegateProxyEnabled

We do not have this key in the app info.plist, so, it should be off by default, right?

After a lot of testing, we've discovered that for iOS10 at least it's mandatory to send the "body" parameter in the payload when sending a dictionary in the "alert" field. Otherwise, the notification is considered empty by the notifications center and therefore ignores it.
So this payload will not work for iOS10:
{
  "apns": {
    "payload": {
      "aps": {
        "alert": {
          "title": "You have a new message"
        },
        "mutable-content": 1
      }
    }
  }
}

But this one will:
{
  "apns": {
    "payload": {
      "aps": {
        "alert": {
          "title": "You have a new message",
          "body": "Tap to see it"
        },
        "mutable-content": 1
      }
    }
  }
}

In iOS11, no body in the alert seem to be fine.

@jmorgaz swizzling is enabled by default. You can disable it as described in our docs here.

With the change in the payload we have fix this issue.
Thank you all!


Use ruff instead of flake8

As originally suggested by @schustmi, I tested out ruff as an alternative to flake8. It indeed runs much faster.
This PR does a little surgery to remove the following:

pydocstyle
darglint
isort
autoflake (mostly)
flake8
flake8-docstrings (plugin for flake8 that we were using)

The author of ruff is implementing something in the coming days that will allow us to remove autoflake as well (the automatic removal of unused variables).
Ruff is not only faster, but allows us pretty easily to extend with other rulesets in the future, all with ruff-speed.
The only thing that isn't what we had previously is flake8's warning when we exceed a McCabe complexity score of > 18. I have temporarily disabled this check (which was improperly implemented in our previous setup, and thus wasn't being evaluated) since it highlights some places with huge complexity scores that I didn't want to refactor as part of this PR. We can consider adding this back in in the future.
The main places to look in this PR:

the pyproject.toml file
updated scripts in scripts/
changes in .github/

Pre-requisites
Please ensure you have done the following:

[ ] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] If I have added an integration, I have updated the integrations table and the corresponding website section.
[ ] I have added tests to cover my changes.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

@fa9r @strickvl to test you can temporarily  change the github actions to trigger for this branch right?

Updated this to remove basically all of our linting / checking dependencies apart from autoflake (which can be removed in a few weeks), pyspelling and interrogate.
I think this update might mean that people start allowing the pre-commit scripts to run again since it's now fast enough.
As for checking, I did a bunch of manual tests on my machine to see whether things were caught or not. (Also did some fixes along the way).

Hmmm ruff worked, but mypy failed... Will look into this in a down moment tomorrow.

Apart from the two comments, if you ran the formatting script locally and it doesn't do any reformatting (and passes the linting), this would be good to go from my side

Changes LGTM, however I am unsure how we can test this. Perhaps we could checkout some old commits that had flake8/pydocstyle/... issues and check whether ruff finds them as expected. Other than that we can't test much here since the CI only runs with ruff once we merge to main I believe. I also just killed the GH Action of this PR for that reason.

Just to set the record straight, changes to existing workflows (usually) don't need to be propagated to main to take effect. Adding new workflows and sometimes changing the triggers of an existing workflow is when you need that.

Just to set the record straight, changes to existing workflows (usually) don't need to be propagated to main to take effect. Adding new workflows and sometimes changing the triggers of an existing workflow is when you need that.

Oh really, I thought workflows are always defined by whatever is on main, good to know!

@fa9r we were previously inconsistent. Some places we said set line length to 80, other config files we set to 79. I'm happy to unify to 79 if that's the standard.
There are some other things where we'd set values (cyclomatic complexity is the most prominent) but that weren't actually being factored into the linting tests. As a result, we have many functions/methods with really high cyclomatic complexity but I left those to one side for now. I'll address the rest of your review in a bit.


Update Operator SDK and Go to latest

/test all

This will need a bump on the OpenShift CI side.

Is this still needed?


Report global coordinates of each variant

The first commit of this PR represents my first steps toward solving the two following problems.

identifying the actual coordinate(s) of the variant from the CIGAR string reported by ksw2
transforming the coordinate from a local (small cutout from reference) to a global (entire chromosome) system; see #115.

So far I have only solved the first problem, and only for isolated SNVs. Before merging I'll need to solve both problems for at least:

[x] Isolated SNVs
[x] Indels
[ ] Clustered variants

The changes implemented so far are valuable and should be merged in. The changes required to support calling clustered / proximal variants will be a substantial effort itself, and is somewhat orthogonal to the main thrust of this PR, which for the most part is a solved issue.
I'm going to merge this now and continue discussion of the remaining work on #119.


Conda version is stuck at 0.4.2

Solution to issue cannot be found in the documentation.

[X] I checked the documentation.

Issue
Conda version is stuck at 0.4.2, bot PRs are failing, thus new version of mistal can not be installed
Installed packages
no need.

Environment info
active environment : lm-apis
    active env location : /home/ftopal/miniconda3/envs/lm-apis
            shell level : 2
       user config file : /home/ftopal/.condarc
 populated config files : /home/ftopal/.condarc
          conda version : 24.7.1
    conda-build version : not installed
         python version : 3.11.5.final.0
                 solver : libmamba (default)
       virtual packages : __archspec=1=skylake
                          __conda=24.7.1=0
                          __glibc=2.35=0
                          __linux=6.8.0=0
                          __unix=0=0
       base environment : /home/ftopal/miniconda3  (writable)
      conda av data dir : /home/ftopal/miniconda3/etc/conda
  conda av metadata url : None
           channel URLs : https://conda.anaconda.org/conda-forge/linux-64
                          https://conda.anaconda.org/conda-forge/noarch
                          https://repo.anaconda.com/pkgs/main/linux-64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/r/linux-64
                          https://repo.anaconda.com/pkgs/r/noarch
          package cache : /home/ftopal/miniconda3/pkgs
                          /home/ftopal/.conda/pkgs
       envs directories : /home/ftopal/miniconda3/envs
                          /home/ftopal/.conda/envs
               platform : linux-64
             user-agent : conda/24.7.1 requests/2.31.0 CPython/3.11.5 Linux/6.8.0-45-generic ubuntu/22.04.5 glibc/2.35 solver/libmamba conda-libmamba-solver/23.12.0 libmambapy/1.5.3
                UID:GID : 1000:1000
             netrc file : None
           offline mode : False

@jtpio Could you have a look? Thanks so much in advance

Unfortunately I won't time to look into this in the short term.
As noticed in https://github.com/conda-forge/mistralai-feedstock/pull/3#issuecomment-2284207540, the new 1.0.0 release seems to have changed quite a few things in how the source project is structured, and its dependencies.
A while ago I asked on the Mistral Discord channel if some maintainers could help maintaining the feedstock, but not sure it got any response. Maybe you could try to ask there too?


feat: add runes fiat balance, closes #5300

Try out Leather build 77c63eb — Extension build, Test report, Storybook, Chromatic

This pr adds fiat balance to runes

Summary by CodeRabbit

New Features

Enhanced the RunesLoader and RunesAssetList components to include market data, providing more comprehensive asset information.
Introduced fiat balance display for assets in the RunesAssetList, giving users a clearer understanding of the asset values in fiat currency.

Dependencies

Updated @leather.io/query from version 0.10.2 to 0.11.1.

All my balances are showing as <$0.01 so there may be something off with decimals or units somewhere.

Looks accurate to me! Do you think it would make more sense to sort Runes by USD balance, most valuable to least valuable?
Also, maybe this is part of our broader assets redesign, but it would be nice to filter out some of the lower-value stuff into "View More" like we do with SIP10 tokens.

Also, maybe this is part of our broader assets redesign, but it would be nice to filter out some of the lower-value stuff into "View More" like we do with SIP10 tokens.

Yep let's capture this need with https://github.com/leather-io/extension/issues/5404 or a new issue if preferred


@ caracter in password

Just to let people now that the script doesn't like having a "@" in the password, I've just changed my password.

I'll take a look at that soon. pyhydroquebec is in the process of being re-written from scratch. I will release few minor test version soon and once it's stable I'll release a new stable release.

Hi, I've neglected this repository. This project is now unsupported because the pyhydroquebec python library I used has been renamed and reworked from scratch.
Don't feel bad, it's now really better and there's a addon you can use in HA too. I will update the readme here to reflect those information.
New project website: https://hydroqc.ca/fr/
Gitlab project: https://gitlab.com/hydroqc
Hass-addon repository: https://gitlab.com/hydroqc/hydroqc-hass-addons
There's a Discord if you have questions or want to contribute: https://discord.gg/2NrWKC7sfF
I'll close this issue and the other than update the readme with the information above.
Thanks, have a great day!


feat: Single URLs layout

Closes #1325.
This PR introduces a single URLs layout mode, where user can publish several charts separately.
A new browser tab is opened for every chart, instead of the first one, which behaves in a regular way (goes to /v/chart-id?publishSuccess=true page).
How to test
⚠ Publishing possible to test when deployed to TEST.

Go to the preview link (only to test the non-publishing behavior) or to TEST link (once merged).
Add more charts.
Proceed to layout options.
Change layout mode to Single URLs.
See that it's possible to check charts to be published separately.
Click Publish button and see that every selected chart has been published in a different tab, with unique URL.

Looks really good. Thanks!

I like your new text instruction. It makes it more clear. Maybe we could even add here already a hint like: "Select the charts to publish separately. After proceeding to publish, the chosen charts will open in individual tabs." Or even shorter like: "Select the charts to publish separately and open in individual browser tabs".
I find the checkbox next to the button too small. Longterm I'd like to adapt the UI by changing the position and the style of the metadata button, so we would have more space above the charts. (UI design for the next sprint: https://www.figma.com/file/Hn9wvuEYLUmdJtg4KwZYUx/visualize.admin.ch---design?type=design&node-id=2752-406621&mode=design&t=NSIJ565wnYK4WpGx-4).


Images limit does not work for batch downloads

Bug description
No matter what limit is set for batch downloads, the downloader scours all results regardless.
Steps to reproduce

Add any batch download
Change the images limit to less than the total.
Initiate download
The downloader goes through all results

Expected behavior
The downloader must not check more images than the limit specified. This limit must include ignored/skipped files as well.
Screenshots

System information

OS: Windows 10
Grabber version: Nightly

@Bionus Please add a setting which makes it happen?


Importing the project in IJ/AS

I tried to import the project in IntelliJ 2020.1, Android Studio 3.6.2 and Android Studio 4.1 Canary 5, but on each version I'm encountering some problems:

not all references are resolved
GraphQL plugin doesn't provide completion in integration test files
untracked files are created and pollute the diff

The most success I've had with AS 3.6.2, but even there I see for example:

or

(all imports are actually necessary and used)
and these files are always changed:

I tried to import the root project (./settings.gradle) as well all the composite one (./composite/settings.gradle). The final state I was able to arrive at was importing the composite project, syncing/building everything I could (project compiles successfully) such that I can run tests, but there are still tons of unresolved references and lots of the code completion features don't work. Is there some specific configuration I'm missing, or a specific IJ version that's supported? Some set of required plugins?

Thanks for the report. This is because of introduction of Kotlin Multiplatform. We have more of those on Java files. Actually some of them are bugs in IntelliJ.
The Kotlin ones you reported were very helpful. They were because of compileOnly dependencies. Converted them to be implementation to fix. They should've been implementation.
The sqldelight sutff will be ignored with #2167
I'm afraid .idea/codeStyles/Project.xml is something to do with your local setup. You must have changes into Default codestyle. You can see that by going into Code Style settings and choose Default. It should be "blue" (indicates changes). Revert that to original settings and switch back to Project codestyle. Then this file change should automatically be gone.


Configurable docker image for runner

Hi, @npalm!
This PR introduces configurable docker image for runners.
In our case we need the ability to use custom images, because we work with private docker registries and need to configure credential helpers to perform pulls from them. To handle this, I've added the variable runners_image with default value docker:18.03.1-ce. So without setting this variable everything should work as before.

+1 I really need it too.

@mkalmykov thx will check your PR in the next days

@npalm Thank you for the response. We've noticed that we need one more item to be configurable. I will add the code tomorrow and notify you when PR is ready.

@npalm
We've found that there is already a PR #26 with changes that we need, so this PR is ready.

New release created, thanks for the contribution. See https://github.com/npalm/terraform-aws-gitlab-runner/releases/tag/1.8.0


Email notification toggle does not work properly

When try to toggle individual email to enable notification, it only changes the first one no matter which one I click on

I also only can delete the first email but not the others.

related to issue #269

Fixed by #284


containers: add support for interface "io.edgehog.devicemanager.apps.DeploymentEvent"

ref: #614
interface: https://github.com/edgehog-device-manager/edgehog-astarte-interfaces/pull/64/files#diff-f3c85a4a2c50521f620f0df63022695a966b16695088fabddceccf68340f57f5

resolved by #636


Scroll bar hit target for live chat tabs is too narrow making it really hard to target with a mouse

Current design is consistent with VSCode

We should consider adding left/ right arrow chevrons at min width (similar to what Edge does)


[Teams Toolkit - Certificate] Readme steps are not correct for graph-meeting notification and graph-change-notification-team-channel.

Running the sample using toolkit: Steps are missing to create and update the certificate:
Also, what all are the below values and how to update those in .env file are not explained in readme:
Base64EncodedCertificate= "<>"
EncryptionCertificateId= "meeting-notification-certId"
PRIVATE_KEY_PATH=<>
OPENSSL_CONFIG="C:/Program Files/OpenSSL-Win64/bin/openssl.exe"

Hi @ChetanSharma-msft
I have updated the Readme and attached the PR link below.

https://github.com/OfficeDev/Microsoft-Teams-Samples/issues/1121

Commit link: https://github.com/OfficeDev/Microsoft-Teams-Samples/pull/1113/commits/35e65bfa6a39b1103845aaceeeb1b07e5d1c601d

Merged the PR.
We are closing this issue for now, please feel free to reopen it, if required.


Add utility classes for Display

Adds variables and utility classes for the display property.

[x] block
[x] inline-block
[x] inline
[x] table
[x] none
[x] unset

How do we want to handle flex and grid, as they're already defined elsewhere?

Do we want to include inline-flex, inline-grid, contents, table-caption, table-cell, table-column, table-column-group, table-footer-group, table-header-group, table-row-group, table-row, or flow-root?

We would need all the table ones if we include display: table but I'm not convinced we need to include that one.

I removed all table classes because any problems they'd solved would likely be solved by using Flexbox, Grid, or semantic table markup.
cc @dbecherdialpad


python3 comparability, urlib and cypher related syntax change

Good morning. Thanks for sharing this beautiful code
Submitting below change request with following detail.
Reason of change

Python3 complained for few issues

Print format

urlib is refactored and so, we need to use url lib.parse
Cypher language no more accepts {}.  We need to use $. For example, {screen_name} should be $screen_name

Testing status:
I tested with twitter account and I see the code is working
Log trail example:
Found 100 tweets.
Search tweets added to graph for neo4j !
Found 100 tweets.
Search tweets added to graph for neo4j !
Found 100 tweets.
Search tweets added to graph for neo4j !
Found 100 tweets.
Search tweets added to graph for neo4j !
Found 100 tweets.
Search tweets added to graph for neo4j !
Found 100 tweets.
Search tweets added to graph for neo4j !
Found 2 tweets.
Search tweets added to graph for neo4j !
No search tweets found for neo4j

Also, I have restructured code considering modularity and design pattern.  Please check if it is good for parent .
Refer release notes for features


When using a header include to define  preview window states "Active editor doesn't show a MJML document"

Before you open an issue, please check if a similar issue already exists or has been closed before.
Expected behavior
I expect that the detection of an MJML document would take into account includes.
Actual behavior
If the MJML tag is specified in an included template, the MJML isn't detected and preview window shows "Active editor doesn't show a MJML document".
Steps to reproduce the problem

Create header template with <mjml>
Create footer template with </mjml>
Create a main template with:

<mj-include path="./header.mjml" />

<mj-body>
  x
</mjbody>

<mj-include path="./footer.mjml" />

Look at preview window and despair

Screenshot / GIF

Specifications

VS Code version: 1.68.1
MJML extension version: 1.6.0

Comments
The following works fine but it just seemed like a bug to me that mjml being defined in the include wasn't checked for. To be fair, it is an edge case.
<mjml>
  <mj-include path="./header.mjml" />

  <mj-section>
    x
  </mj-section>

  <mj-include path="./footer.mjml" />
</mjml>

Update: the above does not render correctly either, just rendering the header and nothing more.

You have no mj-body in your document that's why

@iRyusa would you take a look at this demo.
Both the MJML App can the node version render this correctly, but the VSCode extension shows the "Active editor doesn't show a MJML document" error for all the files.
At least index.mjml and about.mjml files should be rendered fine, although node and MJML App render the header.mjml and footer.mjml files too.


Library view / bookshelf, reader view(s) => must have main UI language in HTML top-level element

Fixed via https://github.com/readium/readium-desktop/commit/03bcef7d5161814ab285e15f11f1922d05265a8d


Expand the current state machine

The current state machine is very bare-bones, and needs to be expanded with the current RoboSub 2020 tasks. The current structure of the state machine can also be updated if there are betters ways of structuring it.
Once the RoboSub 2020 tasks are implemented and this issue is closed before the 2021 tasks are revealed, there needs to be a new issue addressing updating the state machine to fit the new tasks.
If the RoboSub 2021 tasks are revealed before this issue is closed, the state machine will have to be updated to the new tasks before closing the issue.

Closing this issue, in favor of more detailed and specific issues/notes in the project page.


x2goclient segfaults when trying to connect

Describe the bug
x2goclient segfaults when trying to connect to a client
Steps To Reproduce
Steps to reproduce the behavior:

Open x2goclient
try to open a connection with it
segfaults

Expected behavior
A connection is established
Additional context
Core dump
Notify maintainers
@mkg20001
Metadata

system: "x86_64-linux"
host os: Linux 5.16.8, NixOS, 22.05 (Quokka)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.6.0
nixpkgs: /nix/store/531v6sf2db04x3xqphfkh7zg2dgw135k-source

I am having the same issue while using sway. Here is my current workaround: QT_QPA_PLATFORM=xcb x2goclient (see my wrapper).