More solid webserver

This PR is to fix a mistake I made on sharing the connection to the database between different threads.
I've added a context manager to manage a pool of instances (Bigchain instances, in our case), and installed it in the views for the API.
I've also changed the default bind address from <IP_ADDRESS> to localhost.

Current coverage is 83.70%

Merging #183 into master will increase coverage by +0.39% as of 667b30e

@@            master   #183   diff @@
=====================================
  Files           19     19
  Stmts          923    945    +22
  Branches         0      0
  Methods          0      0
=====================================
+ Hit            769    791    +22
  Partial          0      0
  Missed         154    154

Review entire Coverage Diff as of 667b30e

Powered by Codecov. Updated on successful CI builds.

other then my comments :+1:

Other than some of my Q's for a better understanding (maybe update the comments/docs a bit) :+1:


Send data doesn't work

Description:
I'm trying to send the coordinates to my backend in the background, but it doesn't  do anything
The background tracking works properly  but  the plugin doesn't send the coordinates with the configuration
This is my config

This is my background subscription

Expected behavior
Send each location to the backend even in the background
Smartphone (please complete the following information):

Huawei Y5 2019

Additional context
If anyone can help me, I really appreciate  it

This looks similar to #58
I personally do not post request to the server.
You can debug the code using x code or android studio to see if you get location updates on one hand and send the requests to the server on the other hand.
Feel free to send a PR if you find a bug and its solution :-)

Thank you for your answer  I really appreciate it, so I have a couple of questions for you:

Can I send my location by calling a service inside the subscription listener without being paused?
like this:

Where the locations are stored when I'm calling the getLocations method? can I use this method to send my data sometime later?

You can, but note that the js code doesn't run when the app is in the background only the native code, so what I did is get all locations when the app returns from the background and use those.

Ok, I'm going to try that, thanks for your time!

See here for reference:
https://github.com/IsraelHikingMap/Site/blob/2a681dd83cd34efc673208b6d508825f968d44fb/IsraelHiking.Web/src/application/services/geo-location.service.ts#L139

I've checked your repo and I have a question for you, I'm pretty new using Ionic plugins by the way and I don't know if there is a difference between using this import and the import that you use?


Remove-DuplicateItems two questions

I want to say thank you, I have been able to use the merge-mailboxfolders.ps1 successfully, but I am running into issues running Remove-DuplicateItems using Oath.  Please see below.
.\remove-duplicateitems -mailbox $mailbox -archive -recursefolders -Office365 -OAuth -OAuthClientID $oathclientid -OauthTenantId $oath -VerboseLogFile -logfile c:\temp\remove_duplicates.log -EwsUrl $ewsurl -whatif
Remove-DuplicateItems.ps1 version 1.1.1 starting
Using EWS Managed API found at: C:\repos\Powershell-EWS-Scripts\Legacy\Microsoft.Exchange.WebServices.dll
Processing mailbox<EMAIL_ADDRESS>Unable to load locate
Failed to load ADAL, which is required for OAuth

The instructions say to use -OathSecretKeyID but that parameter isn't available.
When I run the script, I receive this error.
Unable to load locate
Failed to load ADAL, which is required for Oath

I've made quite a few updates in v1.1.2 which is now published.  If you still receive an error when using that version, please post back.  ADAL is not required, and MSAL would only be required for certificate auth.


impl. more dynamic rev-version command

#232

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: janjaali sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

I like this better than my fix :D I'll go ahead and merge this in.


Support StrEnum string autocomplete similar to Literal

Suppose I have the following:
from enum import StrEnum
from typing import Literal

class StrEnumExample(StrEnum):
    ABC = "abc"
    DEF = "def"

LiteralExample = Literal["abc", "def"]

I receive auto-completes off the literal:

And I receive auto-completes off the enum properties:

But I don't receive auto-completes off strings when the type is the StrEnum:

This would be a nice-to-have feature for supporting both an enum and a string as an input with great auto-complete support in both cases.
Not blocking anything as I could union these:

But thought I'd request so I don't need to maintain the list in two places. Thanks!

Wouldn't x: StrEnumType = "abc" be invalid?
I tried this:
x: StrEnumExample = StrEnumExample.ABC
print(x.name, x.value)

x = "abc"
print(x.name, x.value)

The first print succeeds, but the second raises an exception:
Exception has occurred: AttributeError
'str' object has no attribute 'name'
  File "C:\issues\pylance\6518\test.py", line 14, in <module>
    print(x.name, x.value)
          ^^^^^^
AttributeError: 'str' object has no attribute 'name'

Pylance reports a diagnostic for the str assignment also:

Ah yeah, fair point.
The convenience of comparing a StrEnum to a str covers my use case, but that's not comprehensive of all use cases, and other use cases would have a valid reason not to support this.
Thanks for the look and response!


Database can no longer be mocked with new manager API

Describe the bug
After upgrading drift (currently on 2.18), the build_runner outputs the following error when it tries to generate a mocked version of my database:
Invalid @GenerateMocks annotation: Mockito cannot generate a valid mock class which implements 'MyDatabase' for the following reasons:
    The property accessor '_$MyDatabase.managers' features a private return type, and cannot be stubbed. Try generating this mock with a MockSpec with 'unsupportedMembers' or a dummy generator (see https://pub.dev/documentation/mockito/latest/annotations/MockSpec-class.html).

I tried to follow the advice in the message and add a MockSpec, but to no avail for now. Is it necessary/expected that I need to add the custom mock spec, or is this an unintended result of recent changes in drift/drift_dev?
My annotation (I added the customMocks after first getting this error):
@generateMocks(
  [MyDatabase],
  customMocks: [
    MockSpec<MyDatabase>(unsupportedMembers: {#_$MyDatabase.managers}),
  ]
)

Had the same problem, but got it working somehow, don't remember if I disabled manager generation.
Try to use @GenerateNiceMocks and #managers as symbol name. Alternatively disable manager generation in build.yaml if you don't use them.
In general this should be changed in drift. The managers instance could be some interface type.

Thank you! It now works with
@GenerateNiceMocks([
  MockSpec<MyDatabase>(unsupportedMembers: {#managers}),
])

I'll leave the issue open for now, since this only circumvents the issue, and I indeed suspect this isn't intended behavior

As a workaround to this, the release notes for 2.18.0 mention you can turn this feature off in build.yaml - see https://drift.simonbinder.eu/docs/advanced-features/builder_options/ for more info.
Basically, create a file called build.yaml in the root of your Flutter project and add the following.  When you next run build_runner, it won't generate the managers.
targets:
  $default:
    builders:
      drift_dev:
        options:
          generate_manager: false

@frankvollebregt
This is my fault. I'll work on this.
I haven't had much experience with the Mockito library.
What sorta fix do you suppose would solve this issue?

Judging from the error message it sounds like making the manager class public could be enough?

@simolus3 Should we add this as a test?

Since we already have mockito as a dev dependency on drift I think it doesn't cost us anything to try to mock a generated database class as well, then the drift build fails if we break this again.

@simolus3
I'm having some trouble bootstrapping the project
mick@MD-LAPTOP-1:~/drift/drift_dev$ flutter pub get
Resolving dependencies...
The current Dart SDK version is 3.3.3.

Because macros >=0.1.0-main.0 requires SDK version >=3.4.0-256.0.dev <4.0.0 and no versions of macros match >=0.1.0-main.0 <0.1.0-main.0, macros >=0.1.0-main.0 is forbidden.
So, because drift_dev depends on analyzer ^6.5.0 which depends on macros >=0.1.0-main.0 <0.1.1, version solving failed.

You can try the following suggestion to make the pubspec resolve:
* Consider downgrading your constraint on analyzer: flutter pub add analyzer:^6.4.1

Upgrading to 3.4 causes other packages to fail
mick@MD-LAPTOP-1:~/drift/examples/encryption$ dart pub get
Resolving dependencies...
Note: meta is pinned to version 1.12.0 by flutter_test from the flutter SDK.
See https://dart.dev/go/sdk-version-pinning for details.

Because every version of drift_dev from path depends on analyzer ^6.5.0 which depends on meta ^1.14.0, every version of drift_dev from path requires meta ^1.14.0.
And because every version of flutter_test from sdk depends on meta 1.12.0, drift_dev from path is incompatible with flutter_test from sdk.
So, because drift_encryption_sample depends on both flutter_test from sdk and drift_dev from path, version solving failed.

Seems that flutter doesn't work with analyzer 6.5.0
I got a fix for this once you find a fix for this

Fixed via https://github.com/simolus3/drift/pull/3025

Awesome! Thank you everyone for getting this sorted 👍

@simolus3
I'm mocking the individual managers and this getting very annoying.
We are going to make all these classes public
Invalid @GenerateMocks annotation: Mockito cannot generate a valid mock class which implements '$$AppLauchStatsTableTableManager' for the following reasons:
    The method 'BaseTableManager.withReferences' features a private return type, and cannot be stubbed. Try generating this mock with a MockSpec with 'unsupportedMembers' or a dummy generator (see https://pub.dev/documentation/mockito/latest/annotations/MockSpec-class.html).
    The method 'BaseTableManager.withReferences' features a private type argument, and cannot be stubbed. Try generating this mock with a MockSpec with 'unsupportedMembers' or a dummy generator (see https://pub.dev/documentation/mockito/latest/annotations/MockSpec-class.html).
    The method 'BaseTableManager.withFields' features a private return type, and cannot be stubbed. Try generating this mock with a MockSpec with 'unsupportedMembers' or a dummy generator (see https://pub.dev/documentation/mockito/latest/annotations/MockSpec-class.html).
    The method 'BaseTableManager.withFields' features a private type argument, and cannot be stubbed. Try generating this mock with a MockSpec with 'unsupportedMembers' or a dummy generator (see https://pub.dev/documentation/mockito/latest/annotations/MockSpec-class.html).
    The method 'BaseTableManager.limit' features a private return type, and cannot be stubbed. Try generating this mock with a MockSpec with 'unsupportedMembers' or a dummy generator (see https://pub.dev/documentation/mockito/latest/annotations/MockSpec-class.html).
    The method 'BaseTableManager.limit' features a private type argument, and cannot be stubbed. Try generating this mock with a MockSpec with 'unsupportedMembers' or a dummy generator (see https://pub.dev/documentation/mockito/latest/annotations/MockSpec-class.html).
    The method 'BaseTableManager.orderBy' features a private return type, and cannot be stubbed. Try generating this mock with a MockSpec with 'unsupportedMembers' or a dummy generator (see https://pub.dev/documentation/mockito/latest/annotations/MockSpec-class.html).
    The method 'BaseTableManager.orderBy' features a private type argument, and cannot be stubbed. Try generating this mock with a MockSpec with 'unsupportedMembers' or a dummy generator (see https://pub.dev/documentation/mockito/latest/annotations/MockSpec-class.html).
    The method 'BaseTableManager.filter' features a private return type, and cannot be stubbed. Try generating this mock with a MockSpec with 'unsupportedMembers' or a dummy generator (see https://pub.dev/documentation/mockito/latest/annotations/MockSpec-class.html).
    The method 'BaseTableManager.filter' features a private type argument, and cannot be stubbed. Try generating this mock with a MockSpec with 'unsupportedMembers' or a dummy generator (see https://pub.dev/documentation/mockito/latest/annotations/MockSpec-class.html).
    The property accessor 'BaseTableManager.$state' features a private return type, and cannot be stubbed. Try generating this mock with a MockSpec with 'unsupportedMembers' or a dummy generator (see https://pub.dev/documentation/mockito/latest/annotations/MockSpec-class.html).
    The property accessor 'BaseTableManager.$state' features a private type argument, and cannot be stubbed. Try generating this mock with a MockSpec with 'unsupportedMembers' or a dummy generator (see https://pub.dev/documentation/mockito/latest/annotations/MockSpec-class.html).

Making the classes public isn't enough because managers have typed references to the (private) base class generated for the database, so it's hard to fix in general.
Enabling modular code generation appears to be a possible workaround.


Codechecker

Codechecker
Codechecker SAST analyzer

Import Codechecker static analyzer report in JSON format: https://codechecker.readthedocs.io/en/latest/
Report format described here: https://codechecker.readthedocs.io/en/latest/analyzer/user_guide/#parse
One could make Codechecker JSON report using command like this:
CodeChecker parse /path/to/codechecker/analyzer/output/directory -e json -o /path/to/output/file.json

Before this step you should build your project with Codechecker build process interception,
odeChecker log -b "make -j8" -o ./my.project.codechecker.log

then analyze it
CodeChecker analyze ./codechecker.log -o /path/to/codechecker/analyzer/output/directory

Out of curiosity. If only HASHCODE_FIELD is unique_id_from_tool, isn't it better to set DEDUPLICATION_ALGORITHM to DEDUPE_ALGO_UNIQUE_ID_FROM_TOOL?

Out of curiosity. If only HASHCODE_FIELD is unique_id_from_tool, isn't it better to set DEDUPLICATION_ALGORITHM to DEDUPE_ALGO_UNIQUE_ID_FROM_TOOL?

May be you are right,
but could you explain the difference in deduplication?  may be it will be faster? I don't understand completely...

May be you are right, but could you explain the difference in deduplication? may be it will be faster? I don't understand completely...

The calculation of hashcode is performed doesn't mether if you define fields
https://github.com/DefectDojo/django-DefectDojo/blob/4dfb3a43651846696823e2d3d7bd5ec485b54276/dojo/importers/reimporter/reimporter.py#L81
https://github.com/DefectDojo/django-DefectDojo/blob/4dfb3a43651846696823e2d3d7bd5ec485b54276/dojo/models.py#L2394-L2442
Question is if there is significant differents between compute_hash_code_legacy and concat of fields + hash_fields
Using DEDUPE_ALGO_HASH_CODE vs. DEDUPE_ALGO_UNIQUE_ID_FROM_TOOL looks might similar (is there some time difference in SQL SELECT for CharField(null=True,max_length=64) and CharField(null=True,max_length=500)?)
https://github.com/DefectDojo/django-DefectDojo/blob/4dfb3a43651846696823e2d3d7bd5ec485b54276/dojo/importers/reimporter/utils.py#L25-L34
https://github.com/DefectDojo/django-DefectDojo/blob/4dfb3a43651846696823e2d3d7bd5ec485b54276/dojo/models.py#L2183-L2188
https://github.com/DefectDojo/django-DefectDojo/blob/4dfb3a43651846696823e2d3d7bd5ec485b54276/dojo/models.py#L2234-L2238

thank you @kiblik :)
So, DEDUPE_ALGO_HASH_CODE computes hash from field set and stores in hash_code[64] field,
DEDUPE_ALGO_UNIQUE_ID_FROM_TOOL takes precomputed unique ID (an my case - also hash), stored in unique_id_from_tool[500] field
i.e. there is not difference in algorithm, just in hash compute mode


[hotfix][doc] Update rest documentation

What is the purpose of the change
Update rest documentation
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? no

Failed test case is unrelated, but fix it in this PR also.


Run CI on pull requests as well

This seems to be necessary to run them on PRs from forks.

CI issues are expected, as the code currently has some style and functionality issues.

Oh no, this build every workflow twice if the PR doesn't originate from a fork...


Benchmark results different from the original papers

Hi,
I was looking at the Table 1 in the paper (https://arxiv.org/pdf/2403.14548) and it seems to me that the results reported there do not agree with the numbers published in the respective papers.  Did you re-run all the methods yourself and re-evaluate them? Do you have some explanation of the differences?
And if you did re-run everything, would you please share the raw results (point-tracks and occlusion masks)?
Some examples on DAVIS (delta_avg, OA, AJ):

method
original paper
yours

TAP-Net
53.1, 82.3, 38.4
53.4, 81.4, 38.4

CoTracker(v1*)
79.1, 88.7, 64.8
79.2, 89.3, 65.1

TAPIR
73.6, 88.8, 61.3
74.7, 89.4, 62.8

(* CoTrackerv2 is also different)
The differences are not huge, but not exactly tiny in all cases either. I think it is still important to know what is going on.

Hi Jonas, thank you for your question.
For your question, we re-ran all methods ourselves and evaluated them. The reason for the gaps between our reported results and the papers' results are as follows.
Running TAP-Net evaluation code for TAP-Vid DAVIS yielded:
Eval scalars: {'average_jaccard': array(0.3835836, dtype=float32), 'average_pts_within_thresh': array(0.5339951, dtype=float32), occlusion_accuracy': array(0.81390005, dtype=float32),
Running the same evaluation code for TAP-IR on TAP-Vid DAVIS yielded:
Eval scalars: {'average_jaccard': array(0.6281295, dtype=float32), 'average_pts_within_thresh': array(0.7466243, dtype=float32), 'occlusion_accuracy': array(0.89445394, dtype=float32).
Running TAP-Net and TAP-IR's repo will yield these results.
For CoTracker we evaluated CoTracker(v2) using their repo. Their code however resizes target and query points coordinates to [0,255] range instead of [0, 256], this issue still exists in their repo.
Fixing this issue, resulted with the following results.
"average_jaccard": 0.64614, "average_pts_within_thresh": 0.79159, "occlusion_accuracy": 0.88447,

Hi, thanks for a very fast response. Good job trying to replicate their results.
Do you have some idea why the results are different? Are the method non-deterministic (running the evaluation twice gives slightly different results), or do you think it is caused by different software or hardware versions?

hi @serycjon,
the process should not be deterministic. I think the evaluation code of some of these repos underwent a few changes (such as scaling the points differently), so this may cause a slight discrepancy in the results.


HQQ quantization support

As we have a few models with Half-Quadratic Quantization (HQQ) out there, VLLM should also support them:
api_server.py: error: argument --quantization/-q: invalid choice: 'hqq' (choose from 'awq', 'gptq', 'squeezellm', None)

E.g.

https://huggingface.co/mobiuslabsgmbh/Mixtral-8x7B-Instruct-v0.1-hf-attn-4bit-moe-2bit-HQQ

+1, I would love this as well!

It looks like in the project they already attempted to plug into vLLM, albeit an old version: https://github.com/mobiusml/hqq/blob/63cc6c0bbb33da9a42c330ae59b509c75ac2ce15/hqq/engine/vllm.py
@mobicham would you be interested in contributing your quantization backend upstream?

@mgoin We had a hacky version working with an older version of vLLM just as a proof-of-concept and it was working, but we need to remove it because it's deprecated now.
I think it needs a proper PR to get integrated directly with vLLM, it shouldn't be too complicated since it's just a new custom linear layer. Would love to contribute but unfortunately I am really swamped with too many things, so it might take a while.
Happy to assist if someone wants to jump in first!

HQQ is now officially supported by HF and would be really nice to have support for:
https://huggingface.co/docs/transformers/main/en/quantization#hqq
https://twitter.com/younesbelkada/status/1786300992646246704

++ Please add support for this.

should remain open

https://github.com/vllm-project/vllm/pull/9766


Add exceptions for checkMountDest

We still should prevent mount in /sys for security, special
destionations like /sys/fs/cgroup we can treated as exceptions,
these can be unknown from users for now.
Signed-off-by: Qiang Huang<EMAIL_ADDRESS>

ping @ewindisch can you provide some feedback here?

:+1:  I absolutely prefer to whitelist than blacklist. If there are other paths we should whitelist, it would be good to get them in together before the next release.

LGTM
Dunno what other paths though.
ping @crosbymichael


ci: allow Actions workflow to create pull requests

This PR adds the required permission for 🦋 changeset action to create pull requests.

Ping @okonet

Looks like that wasn't enough...

Found this comment which hopefully helps: https://github.com/changesets/action/issues/179#issuecomment-1139116421


Iotdb 240 where fix

fix unknown time series in where clause and add test

Pay attention to the format of the title.


Compile with rsocket-rpc fails

Expected Behavior
A project with both gradle-intellij-plugin and rsocket-rpc compile successfully.
Current Behavior

When both gradle-intellij-plugin and rsocket-rpc are configured in Gradle build file, build process fails on compileJava with the following message (for readability on Pastebin, and attached below out-error.log out.log) : Pastebin
Steps to Reproduce

Pull example repository github
install protoc on your machine (please follow this link protobuf or use a handy tool like chocolatey
Import project to IntelliJ IDEA
Execute Gradle tasks "clean" and "build"
Observe error message on the console 😉
Copy contents from "buildWithoutIntellijPlugin.gradle.kts" to "build.gradle.kts"
Execute Gradle tasks "clean" and "build"
Build should pass this time.

Context (Environment)

I am implementing opensource plugin to IntelliJ idea which will connect to another program on another machine via rsocket-rpc. I need to have generated and compiled java files o be able to use RPC goodness.
Detailed Description

I have no experience in Gradle plugin development and I am not able to find out where exactly problem is. Maybe in the debug session, there would be a possibility to find exact solution

it seems it's not a #239 but #454. please try the workaround described here: https://github.com/JetBrains/gradle-intellij-plugin/issues/454#issuecomment-825696334. Does it help?


Serial console

Hi,
the readme says it's possible to install via serial console, but i can't find any information on how to connect to the MIB.
Does the device have a serial port to connect to?

Hello
I Herd it is Possible, Using a d-link dub-e100,
My Radio ( MIB STD3 PQ +/NAV ) has serial connection, i tried it with PuTTY but all i get is gibberish
I am not sure I am doing it wrong or it just can not be done this way
Let me know if you find something
Thanks

I Herd it is Possible, Using a d-link dub-e100,
My Radio ( MIB STD3 PQ +/NAV )

You heard about Delphi that has nothing to do with Technisat/Preh the Toolbox is developed for
MIB STD3 PQ +/NAV does not exist. I beleive your unit is MIB STD2 Composition Media with one SD slot. This means soldering is needed.

2. MIB STD3 PQ +/NAV does not exist. I beleive your unit is MIB STD2 Composition Media with one SD slot. This means soldering is needed.

You are right, I did a typo, it is the MIB STD2 With the one SD Slot
Thanks


Patch for 0.51

This PR shows our patches changes.

Close. As branch patched contains not only our minimal set of patches.


The term 'source' is not recognized

source : The term 'source' is not recognized as the name of a cmdlet, function,
script file, or operable program. Check the spelling of the name, or if a path
was included, verify that the path is correct and try again.
At line:1 char:1
+ source venv/bin/activate
+ ~~~~~~
    + CategoryInfo          : ObjectNotFound: (source:String) [], CommandNotFou
   ndException
    + FullyQualifiedErrorId : CommandNotFoundException


Add DateTimeRangeFilter

Description

A filter used by the #28  to search for appointments between two DateTimes
The DateTimeRangeFilter shall extends SelectFilter

Part of

#28

closed by #80


(yet another) Switch to Babel 6

#221 Was so outdated it was easier just to start fresh than rebase.
There is one remaining issue from the comments on that PR. This PR still does not intelligently drop babel-plugin-transform-async-to-generator. That plugin is now buried in the stage-3 preset, and I'm not sure if there is a way to still use that preset, but tell it to exclude that particular plugin. Recreating that preset would be fairly trivial (it aggregates only two plugins). I am not sure that is a good plan though. By definition, the stage-3 preset is subject to change over time, and it seems to me that we want to automatically stay up to date. We already track this with #148. Is there something special about async-to-generator that we feel we must handle it specially now before we "do it right" with #148?

Is there something special about async-to-generator that we feel we must handle it specially now before we "do it right"

I don't know how that plugin works now, but we need to polyfill generator support on Node.js 0.10. I don't really have a strong opinion of how that's solved though.

I read it wrong. We were dynamically blacklisting regenerator function, not async-to-generator. The decision to do that dynamically was made back in #61. Now that we reformat stack traces with source-map-support I don't think it is that big of deal.

@jamestalmage We only want to include regenerator on Node.js 0.10 though, as it's a lot slower than native generators.

OK,
The Babel docs no longer mention the ability to black list particular extensions. Unless it still exists and is just currently undocumented, our only option will be to build an equivalent to the es2015 preset ourselves. Not exceptionally difficult, but it will add to our overhead as the preset changes over time.

it's a lot slower than native generators.

Do we have good data on that? (I believe it, just curious).

Hmm - I'm seeing a blacklist option here, wonder if that is babelify specific or not. Need to check it out.

There's something mentioning blacklist here: https://github.com/babel/babel/blob/59f5e7f218ffa788e6e3f320a3e7e0cbe6d50894/packages/babel-plugin-transform-runtime/src/index.js#L14-L22
Or maybe we could just do a PR to babel-plugin-transform-runtime to only add the regenerator include when needed (based on has-generator).
I would prefer we didn't have to maintain our own preset.

transform-runtime would not be the right place. That only transforms what would otherwise be polyfilled globals into require statements to avoid polluting the global namespace:
var x = new Promise(...)
// =>
var runtime = require('runtime');
var x = new runtime.Promise(...);

I think it would need to be an config param to babel-preset-es2015 (can you even pass config params to presets?), or to whichever module would be the appropriate target for a blacklist option. Probably something near or around the OptionManager class; it looks like it does some work loading/configuring plugins.

I would prefer we didn't have to maintain our own preset.

Yeah - that was my feeling.

I think it would need to be an config param to babel-preset-es2015 (can you even pass config params to presets?)

I read somewhere on the Babel issue tracker they would be open to that.

A lot of stuff are blocked by Babel 6 support. I'm trying to think what's the minimum we can do to land this? Maybe we can just have regenerator even for newer Node.js version and open a ticket about submitting an option to babel-preset-es2015?

Maybe we can just have regenerator even for newer Node.js version and open a ticket about submitting an option to babel-preset-es2015?

:+1:

Done: https://github.com/sindresorhus/ava/issues/348
@jamestalmage Anything else before we can merge this?

Any feedback when this feature might be finished? Any points we could help?

Anything else before we can merge this?

That depends on our priorities. It breaks Babel 5 support (You can't use babel-5 to instrument your production code). I have no good solution for that.
Perhaps we could simply detect which Babel version resolves for a given test file, and then conditionally provide a Babel6 or Babel5 config based on what we find.
Or we just rip off the band-aid and go for Babel 6.

Or we just rip off the band-aid and go for Babel 6.

:+1: I'm not too concerned with that as Babel 5 is not supported anymore and people will have to upgrade sooner than later and they can just stay on AVA 0.8.0 in the meantime.

Landed. Yay! :)


[SPARK-15235][WEBUI] Corresponding row cannot be highlighted even though cursor is on the job on Web UI's timeline

What changes were proposed in this pull request?
To extract job descriptions and stage name, there are following regular expressions in timeline-view.js
var jobIdText = $($(baseElem).find(".application-timeline-content")[0]).text();
var jobId = jobIdText.match("\\(Job (\\d+)\\)")[1];
...
var stageIdText = $($(baseElem).find(".job-timeline-content")[0]).text();
var stageIdAndAttempt = stageIdText.match("\\(Stage (\\d+\\.\\d+)\\)")[1].split(".");

But if job descriptions include patterns like "(Job x)" or stage names include patterns like "(Stage x.y)", the regular expressions cannot be match as we expected, ending up with corresponding row cannot be highlighted even though we move the cursor onto the job on Web UI's timeline.
How was this patch tested?
Manually tested with spark-shell and Web UI.

Test build #58182 has started for PR 13016 at commit 1545bb2.

Test build #58182 has finished for PR 13016 at commit 1545bb2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58182/
Test PASSed.

Thanks - merging in master/2.0.


crashes on using quartz tools

this was specifically the quartz axe, but the mod crashes when using the pickaxe too.
I am also unable to use the axe in combat.
if this is an incompatibilty, please let me know so I can inform the other party.
https://pastebin.com/0SHSJ3KF

appologies, apparently am using an outdated mod. the mod author commented this.


all channels except digi24 don't work !

all channels except digi24 don't work !
Can you take a look?
thanks

Have you tried to access http://www.digi-online.ro/ ? The plugin is only a wrapper tool for the live channels available there, programmes that you can access from your browser would (with a very few exceptions) work from Kodi as well.
Updated DIsclaimer:
The author does not host or own any content found within this Addon. The author is not connected to or in any other way affiliated with Kodi, Team Kodi, the XBMC foundation, RCS RDS SA, digi24.ro or digi-online.ro Due to copyright and licensing reasons beyond the author's control, access to Digi-Online TV programmes may be subject to geoblocking (access restricted for viewers outside RCS-RDS Romania network).

you're right - i had to remove the other devices from my digi account
thanks !!!


panic: determinant of affine transformation matrix is zero

This is the error I found in logs of the docker container while trying to load a wall of ~95k photos.
Below is the whole stack trace:
photofield-photofield-1  |  panic: determinant of affine transformation matrix is zero
photofield-photofield-1  |
photofield-photofield-1  |  -> runtime/debug.Stack
photofield-photofield-1  |  ->   /opt/hostedtoolcache/go/1.19.7/x64/src/runtime/debug/stack.go:24
photofield-photofield-1  |
photofield-photofield-1  |     github.com/go-chi/chi/v5/middleware.PrintPrettyStack
photofield-photofield-1  |       /home/runner/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.4/middleware/recoverer.go:44
photofield-photofield-1  |     github.com/go-chi/chi/v5/middleware.Recoverer.func1.1
photofield-photofield-1  |       /home/runner/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.4/middleware/recoverer.go:30
photofield-photofield-1  |     panic
photofield-photofield-1  |       /opt/hostedtoolcache/go/1.19.7/x64/src/runtime/panic.go:884
photofield-photofield-1  |     github.com/tdewolff/canvas.Matrix.Inv
photofield-photofield-1  |       /home/runner/go/pkg/mod/github.com/tdewolff/canvas@v0.0.0-20200504121106-e2600b35c365/util.go:404
photofield-photofield-1  |     photofield/internal/render.(*Scene).Draw
photofield-photofield-1  |       /home/runner/work/photofield/photofield/internal/render/scene.go:116
photofield-photofield-1  |     main.drawTile
photofield-photofield-1  |       /home/runner/work/photofield/photofield/main.go:216
photofield-photofield-1  |     main.GetScenesSceneIdTilesImpl
photofield-photofield-1  |       /home/runner/work/photofield/photofield/main.go:715
photofield-photofield-1  |     main.(*Api).GetScenesSceneIdTiles
photofield-photofield-1  |       /home/runner/work/photofield/photofield/main.go:627
photofield-photofield-1  |     photofield/internal/openapi.(*ServerInterfaceWrapper).GetScenesSceneIdTiles.func1
photofield-photofield-1  |       /home/runner/work/photofield/photofield/internal/openapi/api.gen.go:892
photofield-photofield-1  |     photofield/internal/openapi.(*ServerInterfaceWrapper).GetScenesSceneIdTiles
photofield-photofield-1  |       /home/runner/work/photofield/photofield/internal/openapi/api.gen.go:899
photofield-photofield-1  |     net/http.HandlerFunc.ServeHTTP
photofield-photofield-1  |       /opt/hostedtoolcache/go/1.19.7/x64/src/net/http/server.go:2109
photofield-photofield-1  |     github.com/go-chi/chi/v5.(*ChainHandler).ServeHTTP
photofield-photofield-1  |       /home/runner/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.4/chain.go:31
photofield-photofield-1  |     github.com/go-chi/chi/v5.(*Mux).routeHTTP
photofield-photofield-1  |       /home/runner/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.4/mux.go:442
photofield-photofield-1  |     net/http.HandlerFunc.ServeHTTP
photofield-photofield-1  |       /opt/hostedtoolcache/go/1.19.7/x64/src/net/http/server.go:2109
photofield-photofield-1  |     github.com/go-chi/chi/v5.(*Mux).ServeHTTP
photofield-photofield-1  |       /home/runner/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.4/mux.go:71
photofield-photofield-1  |     github.com/go-chi/chi/v5.(*Mux).Mount.func1
photofield-photofield-1  |       /home/runner/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.4/mux.go:314
photofield-photofield-1  |     net/http.HandlerFunc.ServeHTTP
photofield-photofield-1  |       /opt/hostedtoolcache/go/1.19.7/x64/src/net/http/server.go:2109
photofield-photofield-1  |     github.com/go-chi/chi/v5.(*Mux).routeHTTP
photofield-photofield-1  |       /home/runner/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.4/mux.go:442
photofield-photofield-1  |     net/http.HandlerFunc.ServeHTTP
photofield-photofield-1  |       /opt/hostedtoolcache/go/1.19.7/x64/src/net/http/server.go:2109
photofield-photofield-1  |     github.com/go-chi/chi/v5.(*Mux).ServeHTTP
photofield-photofield-1  |       /home/runner/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.4/mux.go:71
photofield-photofield-1  |     github.com/go-chi/chi/v5.(*Mux).Mount.func1
photofield-photofield-1  |       /home/runner/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.4/mux.go:314
photofield-photofield-1  |     net/http.HandlerFunc.ServeHTTP
photofield-photofield-1  |       /opt/hostedtoolcache/go/1.19.7/x64/src/net/http/server.go:2109
photofield-photofield-1  |     github.com/go-chi/chi/v5.(*Mux).routeHTTP
photofield-photofield-1  |       /home/runner/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.4/mux.go:442
photofield-photofield-1  |     net/http.HandlerFunc.ServeHTTP
photofield-photofield-1  |       /opt/hostedtoolcache/go/1.19.7/x64/src/net/http/server.go:2109
photofield-photofield-1  |     github.com/go-chi/chi/v5/middleware.Recoverer.func1
photofield-photofield-1  |       /home/runner/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.4/middleware/recoverer.go:37
photofield-photofield-1  |     net/http.HandlerFunc.ServeHTTP
photofield-photofield-1  |       /opt/hostedtoolcache/go/1.19.7/x64/src/net/http/server.go:2109
photofield-photofield-1  |     main.instrumentationMiddleware.func1
photofield-photofield-1  |       /home/runner/work/photofield/photofield/main.go:114
photofield-photofield-1  |     net/http.HandlerFunc.ServeHTTP
photofield-photofield-1  |       /opt/hostedtoolcache/go/1.19.7/x64/src/net/http/server.go:2109
photofield-photofield-1  |     github.com/go-chi/chi/v5.(*Mux).ServeHTTP
photofield-photofield-1  |       /home/runner/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.4/mux.go:88
photofield-photofield-1  |     net/http.serverHandler.ServeHTTP
photofield-photofield-1  |       /opt/hostedtoolcache/go/1.19.7/x64/src/net/http/server.go:2947
photofield-photofield-1  |     net/http.(*conn).serve
photofield-photofield-1  |       /opt/hostedtoolcache/go/1.19.7/x64/src/net/http/server.go:1991
photofield-photofield-1  |     created by net/http.(*Server).Serve
photofield-photofield-1  |       /opt/hostedtoolcache/go/1.19.7/x64/src/net/http/server.go:3102

Maybe it's just to much photos, but I wanted to experiment with it and see if it would be possible.
Also I must say, it's a  great project, I hope to see it grow into something even more powerful!

Hey, thanks for reporting!
I think this happens for some of the low resolution tiles in bigger collections, so it's pretty reproducible. I think I even saw this before, but ignored it as it's low impact.
But I'll take a look when I get the chance, thanks!

Thanks for the response!
I forgot to add that I don't actually see anything in the browser (except for the settings ui, etc.), but I saw some http errors so I will try to post them when I get a chance.

Hey, https://github.com/SmilyOrg/photofield/releases/tag/v0.9.3 should include a potential fix for this. Let me know if you still see it!
For the HTTP errors it might be better to open a separate issue :)

FWIW am still seeing determinant of affine transformation matrix is zero with 0.10.3


Revert "Merge pull request #885 from knorth55/fix-doc-build"

Please merge hen chainer 6.1.0 is released.
Waiting for upstream.
This reverts commit 472da1ee5ed5c778e29f92ab3888fea242bc3cf0, reversing
changes made to 5b792b1bd00aff1a29cf3bf265f1aba5991bd67d.

Chainer 6.1.0, so we can revert https://github.com/chainer/chainercv/commit/472da1ee5ed5c778e29f92ab3888fea242bc3cf0


Add NVIDIA licenses

Motivation for this change
NVIDIA software is unfree, but redistributable. To facilitate data science infrastructure by community, the licenses should be made more precise.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/improving-nixos-data-science-infrastructure-ci-for-mkl-cuda/5074/25

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/improving-nixos-data-science-infrastructure-ci-for-mkl-cuda/5074/37

still relevant.

@silverhook Who could we talk to about such questions as if we can redistribute things for a specific license such as NVIDIA one? Thanks :)

@domenkozar , just so I understand the question correctly: you’re asking for a contact regarding all potentially problematic licenses?

A good start is here:
https://fedoraproject.org/wiki/Licensing:Main
https://wiki.debian.org/DFSGLicenses

Not necessarily a contact, could be a website or some authority that deal with such questions. OSI and similar have a strict list of requirements that make a license free. I'm looking for something that categorizes things based on each attribute and says if it's yay or nay.
There's https://tldrlegal.com/ but it doesn't have NVIDIA for example.

Unfortunately there is nothing that can be deemed as a canonical resource of such info.
Tldrlegal is a valiant try, but has its issues.
OSADL has something more reliable, but not many licenses:
https://www.osadl.org/Open-Source-License-Checklists.oss-compliance-lists.0.html
OSLiC and later OSCAd are another take, from the compatibility PoV:
https://github.com/telekom/oslic
https://github.com/AmadeusITGroup/oscad2
There are a few of us who are planning something in this direction, but it’s early days, very labour intensive and questionable if we get green light.

ScanCode has its LicenseDB public (now), and it groups its many many licenses into categories.
The categories may be not be fine-grained enough for your desired use case, but a great starting point. When it comes to custom licenses such as the NVIDIA one, you will inevitably need to read through them for now though.
Having (capable) humans go through long pieces of legal text, agree(!) on their interpretations, find a coherent, yet short (preferably human and machine-readable) way to parse the (at least most important) rights and obligations from licenses, is not an easy task. It has been tried before, and as you can see, none have been a full success so far.
That being said, even if you would get such a list, it would come with a big fat disclaimer saying that this is (and can) not (be) legal advice, it is just for informational purposes, you should talk to your own lawyer(s) etc. etc.

Having (capable) humans go through long pieces of legal text, agree(!) on their interpretations, find a coherent, yet short (preferably human and machine-readable) way to parse the (at least most important) rights and obligations from licenses, is not an easy task. It has been tried before, and as you can see, none have been a full success so far.

Thanks - I was afraid that is the answer :)

That being said, even if you would get such a list, it would come with a big fat disclaimer saying that this is (and can) not (be) legal advice, it is just for informational purposes, you should talk to your own lawyer(s) etc. etc.

:-) At some point, we'll have to do the due diligence, but we also have to start somewhere.

@maxhbr, this might be something you’d be interested in.

Would it be sane to assume that in most practical cases the downstream derivations (e.g. pytorch) would only link against libcuda.so? That is, they would not distribute modified cuda parts directly, but only reference them as paths in other derivations.
If we could introduce a special license in nixpkgs (like unfreeRedistributable but... not-redistributable) that would mark a derivation that it is to be omitted from the closure when uploading to the cache... we could deliver binary cache for pytorch, and each user would "build" libcuda.so from scratch (as it is done now, if understand it right) by downloading an unmodified binary and patching the headers locally. This would be cheap, compared to building pytorch
@domenkozar I'm wondering, would that be something that cachix could do?

Would it be sane to assume that in most practical cases the downstream derivations (e.g. pytorch) would only link against libcuda.so?

We should check that no static libraries get linked. E.g. PyTorch prefers statically linking MKL and will do that when the static libraries are visible. We could prevent this by moving static libraries to separate outputs.

If we could introduce a special license in nixpkgs (like unfreeRedistributable but... not-redistributable) that would mark a derivation that it is to be omitted from the closure when uploading to the cache... we could deliver binary cache for pytorch, and each user would "build" libcuda.so from scratch (as it is done now, if understand it right) by downloading an unmodified binary and patching the headers locally.

I think that is the direction to go, but I think it would require support from Hydra. AFAIK, derivations marked preferLocalBuild or allowSubstitutes are still added to the cache (?). Also, it would probably not work for Hydra instances where the store is just a proxy for /nix/store (not sure how this works in the project's Hydra instance and binary cache).

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nix-office-hours/11945/33

I have just learned (though you all, probably, already knew) about derivation's options
        preferLocalBuild = true;
        allowSubstitutes = false;

So it seems that most of the needed infrastructure has always been there, the remaining part being (1) some filters for the public cache that would reject to store any legally-dubious derivations and (2) ensuring that pytorch and alike do not link statically any licensed artifacts but only reference them indirectly in Runpaths.
Right now these options are not set for cudatoolkit nor for any other NVIDIA packages. Is there any reason they are not set? Why don't we start with them?

        preferLocalBuild = true;
        allowSubstitutes = false;

[...]
Right now these options are not set for cudatoolkit nor for any other NVIDIA packages. Is there any reason they are not set? Why don't we start with them?

Hydra still builds derivations with these options and IIRC the standard model is to just expose the Nix store. As you say, this probably requires filtering in whatever http interface is used for Hydra. But also Hydra itself needs to provide some filtering, so that build logs can be accessed, but build artifacts can't (to avoid redistribution).
I think the solution starts with someone adding such filters to Hydra. I think ideally we'd not rely on a name filter, but an additional attribute (e.g. dontRedistribute).

I think the solution starts with someone adding such filters to Hydra.

This is basically infeasible with Hydra, since the Nix post-build-hook on each worker is used to upload to binary cache. Hydra has no way to filter what ends up in binary cache to the best of my knowledge.
script here may give some inspiration. Sadly I've had no bandwidth to continue this work on tooling as now a "senior grad student"......

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/petition-to-build-and-cache-unfree-packages-on-cache-nixos-org/17440/53

Note that, as of https://github.com/NixOS/nixpkgs/pull/130862, license have a redistributable attribute.

CC https://github.com/NVIDIA/build-system-archive-import-examples/issues/3

I'm wondering if it would make sense to also introduce nvidiaCudaRedist: I think we'd be overriding its url on a per-derivation basis anyway, because nowadays NVidia ships a copy with every component, e.g. for cudart: https://developer.download.nvidia.com/compute/cuda/redist/cuda_cudart/LICENSE.txt
@tbenst would you like to finish and merge this PR, or would you like me to take over? The main outcome I want is make https://search.nixos.org display the notice instead of the un-clickable "Unfree"

Please take over, thx!

Closing as solved.


Make access permission Proof

Otherwise I believe token owner logic would be meaningless, since access permission seems to be the one that's relevant in this case.

I tested this locally


local issuer certificate error when using mjml api

I use the API since a few weeks and everything worked fine, but today I suddenly ran into this error when trying to send mails:
requests.exceptions.SSLError: HTTPSConnectionPool(host='api.mjml.io', port=443): Max retries exceeded with url: /v1/render (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1123)')))

I didn't change my config or anything. I also tried to retrieve new API Credentials, but I didn't receive a new email so far.

Having the exact same issue.

Same here, there seems to be a certificate problem on MJML end

Having the same issue in https://github.com/Automattic/newspack-newsletters. As of a few hours ago the MJML API started returning {"errors":{"http_request_failed":["cURL error 60: SSL certificate problem: unable to get local issuer certificate"]},"error_data":[]}

Hi everyone, sorry about that. We've identified the issue and working on a fix. There is a valid certificate on mjml.io but the issue is related to the intermediate chain.

issue seems solved

Yes, we just put a fix in place. Sorry for the issue and feel free to report if you see anything else.

thanks

Hi,
The problem seems to be back :(
SSL certificate problem: unable to get local issuer certificate (see https://curl.haxx.se/libcurl/c/libcurl-errors.html)
Thank you

Hi,
The problem seems to be back :(
SSL certificate problem: unable to get local issuer certificate (see https://curl.haxx.se/libcurl/c/libcurl-errors.html)
Thank you

The issue is back .. Any suggestion?

The issue is back .. Any suggestion?

how should one use mjml in production if it's not reliable?

how should one use mjml in production if it's not reliable?

For people using the API in PHP software you could "solve" by installing mjml cli.
Run this :
npm install -g mjml
Then in your code you can make something like this :
    $input_file     = "/tmp/".time()."_input.mjml";
    $output_file    = "/tmp/".time()."_output.mjml";

    file_put_contents($input_file, $mjml);

    $res = exec("mjml {$input_file} -o {$output_file}", $error, $return_var);

    // print_r($res);
    // print_r($error);
    // print_r($return_var);

    $html = file_get_contents($output_file);

    unlink($input_file);
    unlink($output_file);

For people using the API in PHP software you could "solve" by installing mjml cli.
Run this :
npm install -g mjml
Then in your code you can make something like this :
    $input_file     = "/tmp/".time()."_input.mjml";
    $output_file    = "/tmp/".time()."_output.mjml";

    file_put_contents($input_file, $mjml);

    $res = exec("mjml {$input_file} -o {$output_file}", $error, $return_var);

    // print_r($res);
    // print_r($error);
    // print_r($return_var);

    $html = file_get_contents($output_file);

    unlink($input_file);
    unlink($output_file);

since last past 2  weeks im receiving same error from one of our networks... seems like for us this issue is back

We appreciate any suggestion , we are gonna try to install it locally,
if you guys have any code to share we appreciate it

this is part of our code, builder.js


dom0_cfg: Configure image and dtb for the Domain config

Add domd image and dtb sections and load_addr_offset for the domain
config.
Where:
img_start - set to the beggining of the section where domain binary
was placed
img_end - end of the section where domain binary was placed
dtb_start - start of the section where domain device tree was
placed
dtb_end - end of the section where domain device tree was placed

LGTM

Added RB @firscity


v3.2.0 update

Update and remove @tschoonj as maintainer.
Closes #6

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Vielen dank!

Bitteschön. Nice hearing from you. Hope all is going well and you're steering clear from software packages containing the cc letters.

Bitteschön. Nice hearing from you. Hope all is going well and you're steering clear from software packages containing the cc letters.

Yeah all is well at the Franklin. Not much luck avoiding the CC packages though... CCP4 and CCPEM are still very much keeping me busy!
I heard you also got a new job within Diamond, congrats for that! Hope you don't miss scisoft too much 😄


yq: allow any filename in srcs

we have a number of files in our repository that are yaml, despite not having a .yaml suffix in their filename, and this filter prevents us from using the yq rule on them.

Type of change

New feature or functionality (change which adds functionality)

Test plan

Covered by existing test cases

I think that we automatically set some yq flags based on the file types seen in srcs. See https://github.com/aspect-build/bazel-lib/blob/main/lib/yq.bzl#L165.
It would be great if you could add some tests for different input types but without extensions to test that nothing broke there.

@kormide sure, added for a smattering of test cases for yaml and json with different-than-expected file extensions. seems to work fine, PTAL and see if there's some combination i missed here.

Thanks. LGTM with a minor nit: can you remove the .whatever/.dealerschoice extensions since the name of the test targets imply that they are testing no extension on the input file?

how about i change the test names instead? really meant wrong or different- "no" in the sense of "no hints from the extension". naming!

thanks! meant to circle back and fix that up.

Thanks for contributing @pjjw !!


Use Trust for 2.6

Travis changed things under the covers, breaking 2.6.
Signed-off-by: Brian Brazil<EMAIL_ADDRESS>

:+1:


Update New-NpsRadiusClient.md

Docs Build status updates of commit 1d81824:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/nps/New-NpsRadiusClient.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Question about the lowering of i1.

https://github.com/Sirraide/source/blob/8c8399bef054c983187f91b8cd1fdcdbcc68fd46/tests/cast.src#L50
Sorry if this is not a good way of asking questions about your project.
Do i1s get treated specially when lowering or in codegen or are they simply u8s underneath?
More specifically, does a vector<i1> have the same memory layout as a vector<u8>?
Also, what's the benefit from creating the distinction between bool and i1. I read the comment about what the difference is, but I don't think I saw one explaining why we need the distinction in the first place (Sorry if I missed it).
I'm looking to implement a compiler soon, that's why I am a interested in the project.

Do i1s get treated specially when lowering or in codegen or are they simply u8s underneath? More specifically, does a vector<i1> have the same memory layout as a vector<u8>?

An i1 is not the same as an i8 in that the former is 1 bit, the latter 8; e.g. adding two i1s that both have the value 1 will wrap and yield 0, whereas for i8s, it yields 2. However, CPUs typically don’t support addressing single bits, so an i1 will still have 1-byte alignment, which means that, yes, an array of i1 will occupy the same amount of space as an array of i8. One exception to this would be in a packed struct where all the fields are squished together w/ no regard for alignment, in which case 8 i1s in a row would only occupy 1 byte (however, in that case, you also would not be able to e.g. take the address of any of those i1s since a ‘pointer’ to a single bit is not representable). The same also applies to LLVM’s vector types (think SIMD vectors, not dynamic-array vectors).

Also, what's the benefit from creating the distinction between bool and i1. I read the comment about what the difference is, but I don't think I saw one explaining why we need the distinction in the first place (Sorry if I missed it).

bool is special in that 0 is false, but any other value is true. That means that e.g. 4 as bool yields true as 4 is truthy, but an i1 is just a regular integer type, so 4 as i1 yields 0, as 4 is 0b100, which is simply truncated by chopping off all but the last bit, which, in this case, ends up being 0. As to why we need to differentiate between the two... we don’t, really, but bool is logically a distinct type at the language level, and I see no harm in providing this distinction in case it’s ever needed. I don’t expect i1s to be used too widely. (Also, in the IR, both are represented by the i1 type).

I see now... I appreciate the detailed explanation.
Closing the issue.


I'm implementing the image embedding in your paper, what am I doing wrong?

Hey, so let me start by saying this is some impressive work! I've decided to take the challenge of implementing the image embedding + editing from your paper. I feel like I understand what I need to do, but I'm not getting good results.
Let me say that I have the W+ state for an embedded image. I used the dataset you used in your code to do the embedding with the system provided by Stylegan Encoder (https://github.com/Puzer/stylegan-encoder.git). It's in the shape of [1, 14, 512], and I get the correct image out after running it through the synthesis function Gs.components.synthesis.get_output_for(dlatents, randomize_noise = False).
So if I understand your paper and the Image2StyleGAN paper correctly, what I have is the W+ state of the image. According to your paper, I should be able to implement the following:

 is the image I'm trying to encode
 was the process I went through to encode said image with Stylegan Encoder
  is the [1, 14, 512] shape that I got from said Stylegan Encoder process
 is the Gs.components.synthesis.get_output_for func
and

is equal to

Now, for my implementation. I'm currently trying to manipulate one of the theta (ROT) variables.
In order to do this I have hijacked the truncate_generation function. I felt it was the best spot to implement this.
Here is how I have implemented it:
def truncate_generation(Gs,inputcoeff,rate=0.7,dlatent_average_id=None):
    embedded_w_plus_space = np.reshape(np.load('embedded.npy'),[1,14,512]).astype(np.float32) # embedded image
    embedded_w_plus_space = tf.constant(embedded_w_plus_space)

    # INPUTcoeff = tf.concat([IDcoeff,EXPcoeff,Rotcoeff,GAMMAcoeff], axis = 1)
    # INPUTcoeff = tf.concat([INPUTcoeff, noise_], axis = 1)
    # final shape = [160, 64, 3, 27, 32]

    id_exp_zero = tf.zeros([1,160+64])
    rand_rot_isolate = tf.concat([inputcoeff[:,160+64:160+64+1], tf.zeros([1, 2])], axis=1)
    gamma_noise_zero = tf.zeros([1,27+32])

    lambda_i_equals_a = tf.concat([id_exp_zero, rand_rot_isolate, gamma_noise_zero],axis=1)
    lambda_i_equals_b = lambda_i_equals_a * 0.0

    w_i_equals_a = Gs.components.mapping.get_output_for(lambda_i_equals_a, None ,is_training=False, is_validation = True)
    w_i_equals_b = Gs.components.mapping.get_output_for(lambda_i_equals_b, None ,is_training=False, is_validation = True)

    delta_w_iab = w_i_equals_a - w_i_equals_b #w(a) - w(b)

    x_t_pre_synth = embedded_w_plus_space + delta_w_iab

    x_t = Gs.components.synthesis.get_output_for(x_t_pre_synth, randomize_noise = False)
    x_t = tf.clip_by_value((x_t+1)*127.5,0,255)
    x_t = tf.transpose(x_t,perm = [0,2,3,1])

    return x_t

Am I on the right track? Can you give me some hints? Thanks! Let me know if you want me to explain anything further.

Hi, your understanding of each component is correct.
However, it might not be a good choice to use zero identity coefficient and zero noise as input to Gs.components.mapping because the network can hardly receive such input during the training process. You can give the generator zero identity/noise to see what image is generated. In my experiment, it leads to poor generation results.
As a result, you can use a reasonable identity coefficient (identity extracted from 3D reconstruction network) and a random noise sampled from normal distribution to replace the zero input. It should give you a better editing result.

YuDeng,
Thanks for the quick reply! Sorry I didn't get back to you yesterday, I had a flight to catch and no internet to reply.
Good point on the zero identity and noise coefficients.
So I have replaced the Identity coefficient with the result from random normal distribution run through the z_to_lambda function (this is how you are generating random identities in the source code). I do this with the assumption the resulting lambda latents are reasonable. I also used the random normal distributed noise.
Okay, so in order to better run tests, I have put the code that does the bulk of building x_t into its own method to allow for rapid testing.
def build_x_t_pre_synth(Gs, embedded_w_plus_space, id_lambda, exp_lambda, gamma_lambda, noise_lambda, rot_lambda_a, rot_lambda_b):
  lambda_i_equals_a = tf.concat([id_lambda, exp_lambda, rot_lambda_a, gamma_lambda, noise_lambda],axis=1)
  lambda_i_equals_b = tf.concat([id_lambda, exp_lambda, rot_lambda_b, gamma_lambda, noise_lambda],axis=1)

  w_i_equals_a = Gs.components.mapping.get_output_for(lambda_i_equals_a, None ,is_training=False, is_validation = True)
  w_i_equals_b = Gs.components.mapping.get_output_for(lambda_i_equals_b, None ,is_training=False, is_validation = True)

  delta_w_iab = w_i_equals_a - w_i_equals_b #w(a) - w(b)

  x_t_pre_synth = embedded_w_plus_space + delta_w_iab

  return x_t_pre_synth

I've then split out the piece that does the synthesis into its own method. This returns an object with the network as well as the name I assign it. (This is for easy file naming).
def produce_res(Gs, latent, name):
  network_out = Gs.components.synthesis.get_output_for(latent, randomize_noise = False)
  network_out = tf.clip_by_value((network_out+1)*127.5,0,255)
  network_out = tf.transpose(network_out,perm = [0,2,3,1])

  return {
      'network': network_out,
      'name': name
  }

And finally the guts (similar to method from previous post)
def run_edit_tests(Gs,inputcoeff,rate=0.7,dlatent_average_id=None):
  embedded_w_plus_space = np.reshape(np.load('musk_01.npy'),[1,14,512]).astype(np.float32) # embedded image
  embedded_w_plus_space = tf.constant(embedded_w_plus_space)

  # INPUTcoeff = tf.concat([IDcoeff,EXPcoeff,Rotcoeff,GAMMAcoeff], axis = 1)
  # INPUTcoeff = tf.concat([INPUTcoeff, noise_], axis = 1)
  # final shape = [160, 64, 3, 27, 32]

  id_from_coeff = inputcoeff[:,:160]
  exp_from_coeff = inputcoeff[:, 160: 160+64]
  gamma_from_coeff = inputcoeff[:, 160+64+3: 160+64+3+27]
  noise_from_coeff = inputcoeff[:, 160+64+3+27:]

  exp_zero = tf.zeros([1, 64])
  gamma_zero = tf.zeros([1, 27])

  # rot_a should end up being [0.2, 0.0, 0.0]
  rot_a = tf.concat([tf.ones([1, 1]) * 0.2, tf.zeros([1, 2])], axis=1)

  # rot_b should end up being [0.0, 0.0, 0.0]
  rot_b = tf.zeros([1, 3])

  # prepare test using zeros for expression and gamma
  x_t_test1 = build_x_t_pre_synth(
      Gs = Gs,
      embedded_w_plus_space = embedded_w_plus_space,
      id_lambda = id_from_coeff,
      exp_lambda = exp_zero,
      gamma_lambda = gamma_zero,
      noise_lambda = noise_from_coeff,
      rot_lambda_a = rot_a,
      rot_lambda_b = rot_b
  )

  # prepare test using values from coefficient for expression and gamma
  x_t_test2 = build_x_t_pre_synth(
      Gs = Gs,
      embedded_w_plus_space = embedded_w_plus_space,
      id_lambda = id_from_coeff,
      exp_lambda = exp_from_coeff,
      gamma_lambda = gamma_from_coeff,
      noise_lambda = noise_from_coeff,
      rot_lambda_a = rot_a,
      rot_lambda_b = rot_b
  )

  results = []

  # prepare the original as well as the two tests for rendering
  results.append(produce_res(Gs, embedded_w_plus_space, 'original'))
  results.append(produce_res(Gs, x_t_test1, 'test1'))
  results.append(produce_res(Gs, x_t_test2, 'test2'))

  # results are then iterated through, and saved with the name I ran them with
  return results

I ran 2 tests. One using the zero expression and zero gamma, and the other using the expression and gamma from the coefficient passed in.
Here are the resulting images.
ORIGINAL

TEST 1

TEST 2

I'm afraid that the mistake is in the encoding (it's perhaps not high enough quality? Or I'm doing something wrong).
Here are the dlatents I used. (change extension to .npy)
musk_01.txt
Let me know what you think. Thanks!

I just had a realization. I'm going to guess that the alignment of these images is incorrect (I'm using the alignment from the encoder project). I'm going to try and align them using your preprocess_data.py then encode them. If you think this isn't worth the time, and I should try something else, let me know.

I just used the preprocess_data.py script to align the image. It didn't work, in fact the results were worse.
However, I did notice that the aligned image that it produced seemed to consistently offset the face to the left. Perhaps I am doing something wrong?
Here's an example:
Before alignment

After alignment

Like I said, this skewing to the left result is consistent.

Ah, I just realized that you require center of left eye, center of right eye, nose, left mouth, and right mouth as the 5 points.
Just an FYI dlib doesn't give you back those 5 points. They give left of left eye, right of left eye, left of right eye, right of right eye and bottom of nose.
MTCNN gives the correct results.
I'm going to implement MTCNN and see if the results are better.

We are sooo close!!
Using MTCNN definitely improved the alignment. However, I just found in the code how I can get the 5 points from the 68 points that dlib returns.
In the function load_lm3d() you do the work for translating this. Here's a snippet with a comment I added
# calculate 5 facial landmarks using 68 landmarks
lm_idx = np.array([31,37,40,43,46,49,55]) - 1

# nose, left eye, right eye, left mouth, right mouth
Lm3D = np.stack([Lm3D[lm_idx[0],:],np.mean(Lm3D[lm_idx[[1,2]],:],0),np.mean(Lm3D[lm_idx[[3,4]],:],0),Lm3D[lm_idx[5],:],Lm3D[lm_idx[6],:]], axis = 0)
Lm3D = Lm3D[[1,2,0,3,4],:]

Anyway. Back to the matter at hand. Here is the aligned image of Elon Musk:

This is much better.
The embedded version of this image looks like this:

And using the same code as above, here are the two results:

THIS IS SO CLOSEE!!! Amazing. I'm still going to strive for better results however!
Just so you can follow along/ try it out yourself - here are the latent weights (change extension to .npy) for the embedding:
1_musk.txt
Here are the next few things I'm going to try to get improved results

Use dlib 68 landmarks and translate them to 5
Mimic FFHQ's image preparation process on image of Elon Musk
Retrain image embedding network on your network
Let the embedding process run longer (I'm currently letting it run for 10000 iterations and the loss is for the image above got down to 0.29)
Keep problem solving

As always, please chime in with any tips or advice or help!
P.S. In my fork I'm automatically generating the 5 landmarks, so I'm going to be making a PR soon that allows the user an option to have the 5 landmarks be generated automatically

Good news!
I switched to a different encoder and it works PHENOMENALLY!!! I will post my results tomorrow.
 Congratulations.

Well here are the results. Like I said, this is incredible.
The solution was switching to the following encoder https://github.com/rolux/stylegan-encoder
ORIGINAL

TEST 1

TEST 2

TEST 3 A

Hi, thanks a lot for your effort to the image embedding and editing task. The result obtained by using the new encoder seems reasonable.
It is quite interesting to use an encoder for embedding. In our paper, we do not train an encoder to get latent code from images. Instead, we directly update the latent code for an image through backprop.  Directly optimizing the latent code for each image can better preserve the attributes of the original image and may give you a better editing result.

Yu Deng,
I have noticed the limitations of using an encoder. I would like to give the method you recommend a try. Can you give me some guidance or direction as to what I should do next?
Is there a paper/repository you can direct me to? Or perhaps could you provide a description of the backprop process?

The backprop process is simple. We use a similar method as in (Image2StyleGAN)[https://arxiv.org/abs/1904.03189]. We start from an average latent vector in W+ space (1x14x512), where the average vector is calculated from 50k random samples. We use the latent vector as the input to the generator and obtain a generated image. By comparing the L2 loss and perceptual loss between the generated image and the real image which we intend to embed, the gradient can be backprop to the input latent vector in W+ space and we directly update it using an Adam optimizer. Finally, after around 3000 iterations, we obtain the final embedding vector we want.

(Thanks, both of you -- this thread has been really helpful for me!)

following encoder https://github.com/rolux/stylegan-encoder

Well here are the results. Like I said, this is incredible.
The solution was switching to the following encoder https://github.com/rolux/stylegan-encoder
ORIGINAL

TEST 1

TEST 2

TEST 3 A

Hi, the latent vector dimension of stylegan encoder(https://github.com/rolux/stylegan-encoder) is 18512, but the dimension is 14512 in DiscoGan, how did you deal with it.

@salfamusic
Hi, the latent vector dimension of stylegan encoder(https://github.com/rolux/stylegan-encoder) is 18512, but the dimension is 14512 in DiscoGan, how did you deal with it.

Yu Deng,
I have noticed the limitations of using an encoder. I would like to give the method you recommend a try. Can you give me some guidance or direction as to what I should do next?
Is there a paper/repository you can direct me to? Or perhaps could you provide a description of the backprop process?

@salfamusic Hi, the latend vector dimension in stylegan(https://github.com/rolux/stylegan-encoder) is 18512, but 14512 in DiscoGan, how did you deal with it? Is there is a pretrained model which is 256256 size not 10241024 size.

lol, what if musk see those photos

Yu Deng,
I have noticed the limitations of using an encoder. I would like to give the method you recommend a try. Can you give me some guidance or direction as to what I should do next?
Is there a paper/repository you can direct me to? Or perhaps could you provide a description of the backprop process?

Hi,
I am just wondering if you could share your codes on real image editing with DiscoFaceGAN. Thanks in advance!


Set default language as en

Hey guys, I'm using the module to create a headline display, using some dot displays, thanks for your efforts on this code, I liked it a lot!
Now regarding my suggestion,
What about setting the default language to en, this way we can use newsapi.get_top_headlines() only, without any arguments. Currently if we do so it raises an exception.
I can send a pull request to implement it if you want.

Hi @gabrieldespindula ,
I do not believe the language option is an available parameter for the top headlines endpoint. What is the current error you are receiving?
Thanks,
Matt

Hey there, I tested and it does work in some different languages.
My point is just a small improvement.
Currently if you run:
from newsapi import NewsApiClient
newsapi = NewsApiClient(api_key='your key')
top_headlines = newsapi.get_top_headlines()
you get this exception:

Traceback (most recent call last):
File "", line 1, in
File "C:\Python27\lib\site-packages\newsapi\newsapi_client.py", line 119, in get_top_headlines
raise NewsAPIException(r.json())
newsapi.newsapi_exception.NewsAPIException

but if you send
top_headlines = newsapi.get_top_headlines(language='en')
It works just fine.
My suggestion is set 'en' as default language instead of 'None'. Look at newsapi_client.py line 12
Then would be possible to request the headlines without any argument. English language will be the default when sending the API.
And it also prevent new users from receiving this exception.

Ok great. I think something may have changed, because this error is new. Either way, I think that is a great idea to default the language.
A PR would be fantastic, or I'll get around to updating it later this week.
Thanks!


User Tracking for Attestations

Ensure user actions related to Attestation Claiming is tracked

Should have been closed 3 months ago


Do we need one-hot encoded masks for multiple labels or single labeled image having distinct value for each mask?

@lidaiqing  thanks for your quick response. please correct me if i am wrong.  The data on the disk should be in the form of an image containing different labels in a sequence(e.g. 0,1,2,3,4 etc). and in your data-loader you are converting it into on-hot encoded mask.


💡 Concatenations of NotBlankString

📝 Description

Originally discussed in #39.

We would like to introduce the following function for concatenating the string representation of an object with a NotBlankString:
operator fun NotBlankString.plus(other: Any): NotBlankString

Here's an example of calling this function from Kotlin code:
val hello: NotBlankString = NotBlankString.create("hello")
val world = "world"
val message: NotBlankString = hello + ' ' + world
println(message) // hello world

Here's an example of calling this function from Java code:
final NotBlankString hello = NotBlankString.Companion.create("hello");
final String world = "world";
final NotBlankString message = hello.plus(' ').plus(world);
System.out.println(message); // hello world

🔗 Dependencies
This topic is blocked by the following items:

[ ] #587
[x] #588

✅ Checklist

[x] #53
[x] #146
[x] #542
[x] #543
[x] #544
[x] #547
[ ] Close this topic as completed and update tracking issues if present.

This issue was only used for tracking other ones and doesn't need further action.


fix(zfs): filesystem_limit/snapshot_limit/filesystem_count/snapshot_count can now be 'none'

On FreeBSD -CURRENT these properties are none by default now:
nvme/home  filesystem_limit      none                   default
nvme/home  snapshot_limit        none                   default
nvme/home  filesystem_count      none                   default
nvme/home  snapshot_count        none                   default

This was causing panics when parsing.

@unrelentingtech should none be mapped to 0 instead?

Having none set is semantically different from explicitly having 0 count / max limit, which is why ZFS itself started reporting it. I think we shouldn't hide what's actually happening.

I see makes sense.
On Mon, Feb 7, 2022, 4:58 PM unrelentingtech @.***>
wrote:

Having none set is semantically different from explicitly having 0 count
/ max limit, which is why ZFS itself started reporting it. I think we
shouldn't hide what's actually happening.
—
Reply to this email directly, view it on GitHub
https://github.com/Inner-Heaven/libzetta-rs/pull/163#issuecomment-1032102302,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABEFG27VBBSBTN5Q6TY22DU2BTDVANCNFSM5NVKYLIQ
.
You are receiving this because you commented.Message ID:
@.***>


Finish work on script exporter

Type: Haskell and PlutusTx/Cardano.Api
Currently exporter only prints text envelope version of serialized script to terminal. Script serialization is there and ready.

already solved by @mikekeke  and merged


[KYUUBI #2034] Hive Backend Engine - GetPrimaryKeys

Why are the changes needed?

Hive Backend Engine - GetPrimaryKeys.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

the test failures are relevant please check

Should we use new tickets to update flink and trino?

@zhaomin1423, if you have interest to support GetPrimaryKeys operation in other engines, you could create new tickets for this. Thanks.

Codecov Report

Merging #2177 (a5c99b6) into master (4eb5df3) will increase coverage by 0.03%.
The diff coverage is 63.93%.

@@             Coverage Diff              @@
##             master    #2177      +/-   ##
============================================
+ Coverage     61.46%   61.49%   +0.03%
+ Complexity      126       69      -57
============================================
  Files           327      329       +2
  Lines         15659    15718      +59
  Branches       2005     2008       +3
============================================
+ Hits           9625     9666      +41
- Misses         5214     5233      +19
+ Partials        820      819       -1

Impacted Files
Coverage Δ

...ine/flink/operation/FlinkSQLOperationManager.scala
87.17% <0.00%> (-2.30%)
:arrow_down:

...engine/trino/operation/TrinoOperationManager.scala
90.47% <0.00%> (-4.53%)
:arrow_down:

...org/apache/kyuubi/operation/OperationManager.scala
90.32% <ø> (ø)

...a/org/apache/kyuubi/metrics/MetricsConstants.scala
100.00% <ø> (ø)

.../apache/kyuubi/client/KyuubiSyncThriftClient.scala
85.27% <0.00%> (-5.64%)
:arrow_down:

...a/org/apache/kyuubi/operation/GetPrimaryKeys.scala
0.00% <0.00%> (ø)

...apache/kyuubi/server/api/v1/SessionsResource.scala
67.52% <60.00%> (-0.71%)
:arrow_down:

...in/scala/org/apache/kyuubi/server/api/v1/dto.scala
68.96% <75.00%> (+0.44%)
:arrow_up:

.../kyuubi/engine/hive/operation/GetPrimaryKeys.scala
100.00% <100.00%> (ø)

...i/engine/hive/operation/HiveOperationManager.scala
48.57% <100.00%> (+3.11%)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb5df3...a5c99b6. Read the comment docs.

thanks, merged to master


[FLINK-25728][task] Solve potential memory leaks in StreamMultipleInputProcessor

This is a draft PR to solve:

Let's assume we have two inputs, one is flipping between available/unavailable status, the other is continuously unavailable. Now per each StreamMultipleInputProcessor#getAvailableFuture call, we will create one CompletableFuture<?> anyInputAvailable, referenced by TWO instances CompletableFuture$UniRun, for inputProcessors[i].getAvailableFuture() from each of the inputs. anyInputAvailable will be returned, and it will be completed by first input sooner or later, waking up SteamTask in the process. That's fine. Now the problem is that each of those anyInputAvailable instance will be in this scenario referenced forever by the second input's inputProcessors[i].getAvailableFuture(). As long as the second input is not available, we are keep building up the memory leak.

and a counter proposal to https://github.com/apache/flink/pull/18475
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Benchmark results are within norm:
"Benchmark","Mode","Threads","Samples","Score","Score Error (99.9%)","Unit"
"org.apache.flink.benchmark.MultipleInputBenchmark.multiInputChainedIdleSource","thrpt",1,30,23902.067061,324.631108,"ops/ms"
"org.apache.flink.benchmark.MultipleInputBenchmark.multiInputMapSink","thrpt",1,30,18052.461462,557.067827,"ops/ms"
"org.apache.flink.benchmark.MultipleInputBenchmark.multiInputOneIdleMapSink","thrpt",1,30,10953.034248,329.316552,"ops/ms"

I think you fix is working. There is no hang-up after 300 MultipleInputBenchmark test runs.

Benchmark
Mode
Cnt
Score
Error
Units

MultipleInputBenchmark.multiInputMapSink
thrpt
300
14584.350
± 591.433
ops/ms


[docs] Fix truncated_bptt_steps docs

What does this PR do?
This PR fixes the docs of truncated_bptt_steps following the discussion with @carmocca on the PL slack.
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

Thank you @carmocca for giving me the opportunity to contribute! I hope to do more soon :)


Unwanted Text in PDF Preview/Output

I just went to use the PDF preview function and noticed that on the first page of content, after the title page, it inserted the words "Format: Screenplay" at the top of the page.
The text immediate proceeding it was my contact info of the title page:
Contact:
<EMAIL_ADDRESS>  4XX.XXX.2XXX

The text immediately following it was a forced transition:
>FADE IN:
A screenshot of the text is attached.

Er... umm... Well, nevermind. I went back to the document and somehow that line was actually added to the very top of the file, above the title page info and then it wound up on the next page in the preview. Something must have parsed the file at some point and appended that to the top of it... but I can't imagine what that would be.

Interesting.  I don't think we're doing anything that could add that string.  The text "Format" never appears in the Fountain-Atom source.  Maybe some edge case in the syntax highlighter?  I'll keep my eyes open for this.
Any chance you exported your script from another program which might have added it?

I have opened it/exported it through a couple different tools just playing with workflow. It appears one of those changed the file. We can close this out, just wanted to see if anyone else had seen it. Thanks for your time!
Kevin Dooley
469.446.2539
@KevinBDooley

From: superlou<EMAIL_ADDRESS>Sent: Sunday, November 5, 2017 2:33:52 PM
To: superlou/fountain-atom
Cc: captaindooley; Author
Subject: Re: [superlou/fountain-atom] Unwanted Text in PDF Preview/Output (#38)
Interesting. I don't think we're doing anything that could add that string. The text "Format" never appears in the Fountain-Atom source. Maybe some edge case in the syntax highlighter? I'll keep my eyes open for this.
Any chance you exported your script from another program which might have added it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/superlou/fountain-atom/issues/38#issuecomment-342003148, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AcXF_s2rUqjGjb2ptS4xlkM-ksBm1ZyOks5szhuwgaJpZM4QSgt3.

No problem.  Happy it's an easy resolution.


Translate English into Japanese

Fix easy word only. 😅

Thank you @ojiry — every little helps! :-)

Thank you for merged! :)

Thanks!


[fix] Enforced issue closing

Added an else block to test if long description is present when short description mentions an issue.
Closes #136

Coverage decreased (-0.3%) to 99.472% when pulling b8222f003f602fbcee8489516a41b031d824d6fd on KapilBansal320:patch-136 into ca385c577d7b3427186c2e287398ccf30254b902 on openwisp:master.

Related to #137

@nemesisdesign going back in time doesn't help. May be this issue was not known till now. Also,I had made changes according to latest file from master, not from the file you linked previously.


Revert default parser, add FutureWarning for v0.4.0 change

I'd like to release a new version with the awesome lxml parser added by @Nicholas-Schaub, but I'm just a bit wary of changing up the default all in one go (since I can't be certain that there aren't some consequences for untested applications).
This PR sets the default parser to None.  If parser is None, it shows a FutureWarning, explaining that the behavior will change in v0.4.0, and then defaults back to the xmlschema parser.  To silence the warning you can either opt in to the new behavior with parser='lxml', or retain the old behavior with parser='xmlschema'
@jmuhlich @Nicholas-Schaub, lemme know if this is ok with you guys.  If so,  I'll merge and release 0.3.0, then will release 0.4.0 with the new default (and no more warning in a month or two)

Works for me.


Code for Tizen plateform Renderer

Hello
Can you please provide the related code for Tizen plateform Renderer which is not described in this article?
Regards

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9c1bd30c-6e7a-df38-8c20-dff7361e901f
Version Independent ID: 013c6027-db9a-6039-3404-2e4f717133a9
Content: Customizing a WebView - Xamarin
Content Source: docs/xamarin-forms/app-fundamentals/custom-renderer/hybridwebview.md
Product: xamarin
Technology: xamarin-forms
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @hadihashem
We leave Samsung to handle Tizen support for samples. However, they have a fork of xamarin-forms-samples that includes Tizen projects: https://github.com/Samsung/xamarin-forms-samples
Hopefully you'll find what you need there.


private constructors

There is no need to for object creation for those classes which have all the static methods. So need to make their constructors to prevent object creation.
You are learn more from 'singleton design pattern in dart'

Sir, I would like to work on this, please assign me this issue

Sir, I would like to work on this, please assign me this issue


Incorrect velocity units in RCM example

Code sample, preferably able to be copy-pasted and run with no changes
Cell [6] in rcm-example.ipynb, i.e.
from cansen.profiles import VolumeProfile
exp_time = dp.volume_history.time.magnitude
exp_volume = dp.volume_history.volume.magnitude
keywords = {'vproTime': exp_time, 'vproVol': exp_volume}
ct.Wall(reac, env, velocity=VolumeProfile(keywords));

uses wrong units for the velocity entry (should be m/s, not m^3/s normalized volume/time). This is incorrect, but nevertheless works as the wall area defaults to 1 m^2.
Expected behavior
The example should be compliant with Cantera's API . An easy fix would be to clarify the usage of normalized volume, or to separately specify piston area or calculate it from the cylinder bore (which unfortunately is not saved in the YAML file used as input, although several useful parameters were discussed in #91).
PyKED/ChemKED version, Python version, OS version
Current, all python/OS.

I agree that this should be documented as using a normalized volume. It would probably be better to avoid the dependency on CanSen all together.
As for the cylinder bore, that is a fixed parameter that would be the same for every experiment run on a particular machine. We envision the ChemKED YAML files as only encoding data that will change on each experiment (T, p, phi, stroke, clearance, etc.). Hence, we think the bore belongs in a separate apparatus specification. Unfortunately, no such specification exists at the moment.
As I mentioned over at bryanwweber/CanSen#45, most RCM experiments that I'm aware of are not concerned with total quantities such as heat release, but only with intensive quantities that don't depend on the size of the cylinder, so the choice of using a normalized volume in the simulation is fine. That said, it should be possible to implement a VolumeProfile class that does not normalize the volume and requires the correct area be specified in the ct.Wall. I don't think that implementation should be included in the core PyKED code though.

Makes sense. As long as you specify the stroke and document volumes, the bore does not have to be specified, so the current ChemKED YAML format may be good as is.


Text as a promise

I've added the ability to pass Promise as a result of 'text' function.

this is definitely a feature clipboard should have.

Looks like this will not be possible because document.execCommand('copy') doesn't work asynchronously in some browsers as pointed out by @guillaumevincent on #338. See http://hansifer.com/clipboardCopyTest.html


Cancer driver gene widget for all diseases on the Target Prioritisation view crashes in PPP

Describe the bug
Cancer driver gene widget on Target Prioritisation view crashes in PPP
Observed behaviour
When you click on the any entry in the Cancer driver gene column, the entire page crashes
To Reproduce
Steps to reproduce the behaviour:

Go to a Target Prioritisation view for a disease. Example
Click on any entry in the Cancer driver gene column
See error

Additional context
Minified React error #130

Works on platform and PPP dev


Improve friend name matching for various edge cases

Fixes #215, #213

Hi there! Thanks so much for submitting a pull request!
Let's just make sure together that all of these boxes are checked before we
merge this change:

[ ] The code in these changes works correctly.
[x] Code has tests as appropriate.
[ ] Code has been reviewed by @JacobEvelyn.
[ ] All tests pass on Travis CI.
[ ] Rubocop reports no issues on Travis CI.
[x] The README.md file is updated as appropriate.

Don't worry—this list will get checked off in no time!

Coverage increased (+0.008%) to 98.266% when pulling acd7a172ade064022cbe016b4e12932d67ead83d on short-names-long-names into 802855e4468fabff08b0f0dd029c02b7efafd3f3 on master.


timer correlation?

should we provide correlation of timer evens? the start timer decision has a control field which is not returned by the TimerFired  event, so we could stash it in the correlator?

closed via #14


Update docker-compose so tests run

Changed volumes setting in docker compose for test container to comment out - /var/www/app/node_modules
node_modules need to be available for the tests to run

@nzmoore thanks for pushing up this pull request. Are you able to run to npm run dev with no build issues and also run npm test. Were you able to run both of these scripts successfully on fresh repo build

@jbelmont Yes I was able to do both 'npm run dev' and 'npm test' with no issues using using a fresh repo.
Here is the sequence of testing I did starting from a clean directory:
git clone git@github.com:Code-Craftsmanship-Saturdays/caching-and-memoization.git -b docker-compose-edits
npm install
npm run build
npm run dev
npm run stop
npm test
All ran without errors

Awesome thanks Bill


Lanugage selector script does not take in new language

I am working on a multi-language website, and wanted to add a language that is currently not part of the pre-translated 34 ones, Slovak.  I followed the instructions, created an sk.yaml in the i18n directory in root, give the menu parameters, and the website is built, but cannot be accesssed from the main language (English) interface.
For understanding what is happening, I created three languages, en, nl, and sk.
http://...url/sk/ shows the website, but it is not accessible from the English/Dutch interface language selector.
http://...url/nl/ not only shows the Dutch website, but the language selector works as expected.
http://...url/ shows the default English and allows the selection of the Dutch version (nl)
I think that there is a script that emunerates the languages, but I cannot locate it.  Because the all other UI elements are correctly shown in Slovak. I think that the problem is that the string 'Slovak' needs to be inserted to a language list, and of course, needs to be translated in existing languages.  For example, the Dutch version language list knows that English = Engels, but does not know how to call Slovak.
Creating menus
The new documentation (compared to earlier academic versions) suggests to create new toml files for each language.  As you can see if you click through, this is not necessary, the Dutch menu comes up nicely when the menus.toml is configured with both English and Dutch.
I tried to configure here the Slovak language, too, and then I also followed the suggested route, i.e. the creation of a separate menu.sk.toml  [This may require clarification in the documentation, but I think both approaches work fine.]
I believe that the problem is in the language selector script, becasue in fact the Slovak website is created properly, with Slovak title, and Slovak scripting.
Technical details:

Link to your GitHub project: https://github.com/dataobservatory-eu/listen-local-website/
Wowchemy Version (from your go.mod):  go 1.15, github.com/wowchemy/wowchemy-hugo-modules/wowchemy v0.0.0-20201220004521-6c434e6de205
Hugo Version (run hugo version): 0.79.0
Browser/OS: Windows10
Wowchemy Template:  module github.com/wowchemy/starter-academic

Extra:
Needless to say that as soon as I resolve this issue, I'll send a pull request with a new Slovak localization, and an update of Dutch, Estonian, Hungarian versions, as some recent improvements in the UI were not followed in the lanugage.yaml files.

You added your new language in your config/_default/languages.toml right?


[do not merge] [C#] bump: dotnet to 1.9.0

Linked issues
closes: #minor
Details

https://github.com/microsoft/teams-ai/pull/2210
https://github.com/microsoft/teams-ai/pull/2214
https://github.com/microsoft/teams-ai/pull/2227

We should merge this once the package is deployed to nuget.


Better organization of log output for code executions

(Creating on behalf of internal user feedback)
Is your feature request related to a problem? Please describe.
Currently, all code executions from various sas files (not sas notebook) are appended to a single output channel called SAS Log. This can make it confusing to follow over time for many executions. The ask is that we  offer a way to better organize output log generation from various sas program runs. One such option might be to have one output channel per run.

Just brainstorming, another option might be to keep one output channel, but switch out its contents when the user changes active document / tab focus.

Users seem to like what SAS Studio does in this context. SAS Studio allows for:

Having multiple SAS programs open concurrently, and each maintaining their own Log, Results, Output Data tab

But it also allows for submitting multiple SAS programs concurrently. This then results in them being queued (FIFO) and run sequentially in the same SAS Compute session. Queued Program tabs are displayed with a green circle inside the tab.