x-go-name not respected in "swagger generate model"

Problem statement
I want a different name in json as in go (the web developer keeps requesting name changes, and I don't want to change my go code each time).  I tried to use x-go-name, which seems the way to do this.
In a related note, when I want to get rid of omittempty, I seem to need to add x-nullable: false and make it required.  Here I really want to return 0 rather than omit it.  Is there some easier way to do this?
Swagger specification
  ViewWindow:
    title: The view window as two rotational angles, and the field of view (opening)
    type: object
    properties:
      yaw:
        type: number
        description: horizontal rotation in radians
        example: -0.982
        x-nullable: false
      pitch:
        type: number
        description: vertical rotation in radians
        example: 1.32
        x-nullable: false
      field_of_view:
        type: number
        description: field of view in radians (1 / zoom)
        example: 0.54
        x-nullable: false
        x-go-name: Fov
    required: ['yaw', 'pitch', 'field_of_view']

Go Code:
// ViewWindow The view window as two rotational angles, and the field of view (opening)
// swagger:model ViewWindow
type ViewWindow struct {

	// field of view in radians (1 / zoom)
	// Required: true
	FieldOfView float64 `json:"field_of_view"`

	// vertical rotation in radians
	// Required: true
	Pitch float64 `json:"pitch"`

	// horizontal rotation in radians
	// Required: true
	Yaw float64 `json:"yaw"`
}

Steps to reproduce
Ran this with the most recent master (commit 6755c2f)

related: #402


Array passed as argument is shorten

The following code:

MODULE Test;
IMPORT Out;
VAR
str : ARRAY 25 OF CHAR;
PROCEDURE Capacity(str : ARRAY OF CHAR): LONGINT;
BEGIN RETURN LEN(str)
END Capacity;
PROCEDURE CapacityVar(VAR str : ARRAY OF CHAR): LONGINT;
BEGIN RETURN LEN(str)
END CapacityVar;
BEGIN
Out.Long(LEN(str), 0); Out.Ln();
Out.Long(Capacity(str), 0); Out.Ln();
Out.Long(CapacityVar(str), 0); Out.Ln();
str := "test";
Out.Long(LEN(str), 0); Out.Ln();
Out.Long(Capacity(str), 0); Out.Ln();
Out.Long(CapacityVar(str), 0); Out.Ln()
END Test.

Outputs:

25
25
25
25
5
5

The array seems to be changed when passed as argument.

This is a known issue. I mentioned the problem when talking about the COPY procedures. The current implementation copies the entire array struct and thus "updates" the length of the array as well. In your examples, this happens when the array is passed as a non-variable parameter. In this case, the compiler will generate a copy and pass a pointer to that copy to the Capacity procedure.
As I mentioned elsewhere, I am not entirely happy with the current internal representation of arrays and plan to change it (again). This issue is precisely one of the reasons why I am not happy with it. Therefore, I propose that your example becomes a unit test that will help verify whether the planned refactoring will solve this issue down the line.

This has been fixed in the latest version of oberon-lang. Array and string assignment is now handled much more elaborately (and, hopefully, correctly) by CodeGen.


Add option to require custom schema definitions

When a type implements custom JSON marshalling, the autogenerated zod schema is very likely wrong. The new option WithStrictCustomSchemas() (using the functional option pattern) can be used to reject conversion when a type has a MarshalJSON() method but no custom schema.

I think this will run into merge conflicts with #10. If you merge one I'll be happy to rebase the other and update the PR. Let me know what you think!

Rebased and resolved conflicts!


submit form

thanks for your greate extension. is it possible to submit form with cloudflare protection? and how is it possible to post form?

Which programming language are you using? Using this in python is pretty simple and straight forward. You could do something like this :
import cfscrape
import requests

baseUrl = "https://www.webpage.com/login"

headers = {
            'User-Agent':
            'Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36'
        }

payload = {
            'Data1': 'Value1',
            'Data2': 'Value2'
        }

sess = requests.session()
scraper = cfscrape.create_scraper(sess=session)
webPageResponse = sess.post(
            url=baseUrl,
            data=payload,
            headers=headers).text

print("This is the webpage's response : %s" % webPageResponse)

This should do the job just fine.
sess would contain your session info. And avoid used session named variable, because requests library has session method and it could get confusing.


Fixed Visual Studio project files with incorrect paths

#290
This simply fixes the .vcxproject and .vcxproject.filters to point to the correct file.
It was previously just pointing to ..\SDL_ttf.h, I assume this was the case at one point in time but it has seeming changed. It now points to ..\include\SDL3\SDL_ttf.h.

Thanks for the fixes!

Off-topic: can we change SDL3_ttf CI to use setup-sdl like others?

I just merged https://github.com/libsdl-org/SDL_ttf/pull/289


fix: remove unused instances and added new instances

Issue #, if available:
Description of changes:
Remove unused and incorrect instances and added new instances
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/do-e2e-tests

/do-e2e-tests


Implement generalised Collective signup

Part of #2872

Implement the design of the general Collective signup flow shown here.
Questions

Is the FAQ menu always visible or does it slide out/appear from some tooltip? @piamancini @Memo-Es
Clarifying with design whether the windows to the right (see below) are modals over the first time Collective page or not

Update/still to do:

error handling
tablet responsiveness (mobile is done)


Cherry pick Allow casting Timestamp arrays into String to active_release

Automatic cherry-pick of f569e8f

Originally appeared in https://github.com/apache/arrow-rs/pull/664: Allow casting Timestamp arrays into String

Codecov Report

Merging #698 (bca820d) into active_release (3c0a8bd) will increase coverage by 0.01%.
The diff coverage is 100.00%.

:exclamation: Current head bca820d differs from pull request most recent head 987ecc2. Consider uploading reports for the commit 987ecc2 to get more accurate results

@@                Coverage Diff                 @@
##           active_release     #698      +/-   ##
==================================================
+ Coverage           82.39%   82.40%   +0.01%
==================================================
  Files                 167      167
  Lines               46568    46600      +32
==================================================
+ Hits                38371    38403      +32
  Misses               8197     8197

Impacted Files
Coverage Δ

arrow/src/compute/kernels/cast.rs
94.63% <100.00%> (+0.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c0a8bd...987ecc2. Read the comment docs.


time slider showing for mobile torque map with one step

The time slider and play/pause button appear on the mobile version of a one step Torque map. Wasn't the slider removed for these maps?

this is a cartodb.js issue, please move there

@javisantana : moved


Broken URL

The URL for aggregation functions https://docs.loganalytics.io/learn/tutorials/aggregations.html  is broken

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 22f7088d-dd07-e0dd-1204-50da3a29359c
Version Independent ID: 5ff9ae22-13b9-e19d-4e1e-9be42adf02d3
Content: A tour through Analytics in Azure Application Insights
Content Source: articles/application-insights/app-insights-analytics-tour.md
Service: application-insights
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

@AdityaSantoso,
Thanks for your feedback! We will investigate and update as appropriate.

#in-process

There were multiple broken links in this doc. Updates were merged to the private repo. They will go-live in production at 10 AM today.

#please-close

Also if a label of "application-insights" can be added to this issue for reporting purposes.


bump version in package.json to v2.23.0

release version v2.23.0

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


emacs: new package at 26.3

Description of package
GNU Emacs
Checklist

[x] Latest upstream version.
[x] I agree to maintain this package (required).
[x] I agree to notify KISS if I can no longer maintain this package (required).

LGTM :+1:
I'll land the package manager update first and will merge this afterwards.

Thanks :+1:


Problem with getConnection() failing to call back

I maintain a list of pools for each database.  My code calls module.pool(options, database, cb) to acquire a connection.
Pools = {}
exports.pool = (options, database, callback) ->
  options.database = database
  pool = Pools[database] ?= MySQL.createPool options
  pool.getConnection (err, connection) ->
    throw err if err
    callback err, new Connection connection

On occasion, pool.getConnection fails to call back with either a connection or an error.  The relevant part of my Connection class is:
class Connection
  constructor: (@conn) ->

  query: ->
    @conn.query.apply @conn, arguments

  release: ->
    @conn.release()

If I make release() a no-op, getConnection() always seems to work but, of course the pool fills up.
My work flow is to call connection.release() as the first line of the callback from connection.query() before accessing the rows parameter.  Is this reasonable?
Am I doing something stupid?  Should there ever be a time that getConnection() fails to call back?  I would mention that this happens in one case on the second call to pool() so it looks like there's a problem with re-use.

Hm, it's unfortunately hard to say. So far this question has never had an answer other than "you forgot to call conn.release() is some obscure code path (i.e. you left connections hanging somewhere in the code).
Most likely the getConnection hangs because all your requests for a connection have been enqueued (you can tell by listening to the enqueue event https://github.com/felixge/node-mysql#enqueue) and everything is waiting for you to call .release() on some connection you have checked out from the pool.
Without full, complete code I can re to reproduce the issue, it's really hard to say without you debugging the reason :(

That was the reason for my wrapping the connection class into my own Connection class.  It means I can add a debugging line to see every connection and release.  The code currently reads:
    release: ->
    @conn.release()
    connections--
    console.log "release: #{connections}" if DEBUG

and
  connections++
  console.log "getConnection: #{connections} (total: #{++total})" if DEBUG
  pool.getConnection (err, connection) ->

The output in the one script which fails is:
getConnection: 1 (total: 1)
release: 0
getConnection: 1 (total: 2)

and that's it!  It can't be an issue of failing to release() as (a) the debugging line shows up and (b) if I don't do the 'release()' the code works.
The oddest thing is that this only fails in one fairly simple script while it's running happily in other scripts and a server on the same machine.  I should probably have mentioned that I'm running under Node v0.12.7.

Ah, gotcha. I don't understand CoffeeScript, so when you first posted that, I just glossed over it because I have no idea what it even means (like what does the @ mean?). If you have a fairly simply script that fails, could you perhaps share the script?

Sorry, I should have converted it to Javascript.  @conn simply means this.conn and the constructor constructor: (@conn) -> translates to
function Connection(conn) {
this.conn = conn;
}

The script calls quite deeply into a library but I'll see if I can extract out a simple case that fails.

That'd be awesome!

OK.  After a day's worth of debugging with node-inspector, I found the problem.  The call to pool.getConnection() that was not receiving a callback had been called from within a function that had been deasynced.  Because of the way that this module calls the callback from deep in the EventEmitter module, it doesn't play well with deasync.  I think the event was not triggering but I got a bit lost.
I have now changed all my code to remove deasync and everything seems to be working.  Thanks for your help, Doug.  And thanks to all the contributors for such an excellent and well-written module.

Very interesting! I've never heard of the deasync library before, but I'm going to leave this open because I want to at least take a look into it to see if there is something we can change to make it function with deasync (perhaps we are using EEs in some weird way).

There is also a possibility that we may be encountering the bug https://github.com/abbr/deasync/issues/21

Hi! I'm going to close this for now, because it seems to be an issue with the deasync library, and not anything in particular we are doing wrong with the Event Emitter interface. If you have any ideas for a pull request to us that makes sense, please feel free!

I just set waitForConnections to false and handled the rest myself. I guess that's the only viable solution. I am only commenting on this since it's almost 2019 and this issue is still present.


Automated PR: Downstream develop rebase new changes

This PR was created automatically by the Fork Maintenance System to sync changes from the downstream main into downstream develop.

Unit Test Results\n\n\n\n\n### Performance Test Results\n\n\n


Proposal: Replace emitter with syntax tree transformations and a simplified node emitter.

In an effort to better support down-level transformations for complex emit like generators and Async Functions, and to be able to add new down-level transformations for the evolving ECMA-262 specification, we propose to replace the current emitter logic for the TypeScript compiler with an implementation that relies on transformations of the source tree.
Our current emitter is not built to handle the requirements for some of the more complex rewriting needed to support features such as generators (ES6/ES2015) and Async Functions (ES2016). In addition, as time goes on we will need to add more and more branching logic to handle down-level emit of new language features due to the yearly cadence that TC39 is adopting for the ECMAScript specification.
Syntax tree transformations will give us the ability to transform our source tree in an iterative fashion, allowing us to inject new transformations at the head of a transformation chain so that few (if any) changes need to be made to existing transformations in later iterations. As a result, there would be minimal maintenance for the complex transformations needed for down-level generators, as long as new features are already transformed into a syntactically valid ES6 tree.
Generally this will also help to reduce the branching logic of our current emitter, and keep syntactic transformations isolated to an individual file for a language version or feature. As a result, the emitter itself can be simplified drastically and focus specifically on emitting the given syntax tree with almost no branching logic.
Requirements:

No transformation should directly modify the original source tree.
Transformations should be isolated to a specific language version or, when necessary, a language feature (i.e. TypeScript to ES6, ES6 to ES5, AMD module transformations, etc.).
Transformations should reuse existing syntax tree nodes when possible.
Transformations should employ a mechanism to quickly identify whether a node or subtree requires transformation to avoid a full walk of a source tree for each iteration.
Transformations should preserve source locations for use with source maps.
Transformations should not significantly impact the performance of the compiler, and ideally should improve compile time.

Goals:

Transform a TypeScript syntax tree into a compatible JavaScript syntax tree based on compiler settings.
Source Map emit should behave as it does in the current compiler.
Comment preservation should behave as it does in the current compiler.

Non-Goals:

We will not be replacing our declaration emitter with transformations at this time, though we may consider this in a future proposal.
We will not support end-user extensibility of these transformations at this time, though we may consider this in a future proposal.

Remaining Tasks:

[x] Update to support block-scoped declarations captured in loops.
[x] Verify comment preservation
[x] Investigate comment preservation performance issues
[x] Verify/adjust source map output
[x] Fix failing tests
[x] Update transformations to match recent changes to the emitter.
[x] Investigate/improve performance of tree-transforming emitter.

+1 TypeScript should has more modularbility for testability and maintainability for implementations of new ECMA-262 specification. If possible, I want the plugable design and hook points for transforms like the babel. TypeScript team will be able to get feedbacks from user implemented plugins.

+1

It would be very nice to allow extending the emitter to output JSDoc comments with types, so transpiled ES5 code could then be fed into Closure Compiler with advanced optimizations turned on.

Will you be able to create the Syntax Tree from scratch?
Will be be to write the transformed Syntax Tree to a file (a .ts file)?

that is the plan :)

It would be great if this would be compatible to the Babel-plugin style. Great way to open the door to implement typescript "native" runtime type checking

I see this was bumped back to TypeScript 2.1. :-(

https://github.com/Microsoft/TypeScript/wiki/Roadmap hasn't been updated to match.

Hope to see it soon! another big step to make babel obsolete.

Completed as of 4685646.

@rbuckton where it is possible to read how to use committed changes?

@whitecolor see https://github.com/Microsoft/TypeScript/issues/1564#issuecomment-245148134 (wait until tomorrow, use typescript@next

Would it be possible to provide an example that creates a syntax tree from scratch and emits the TypeScript? I've been wanting to be able to do this for a couple of years now. See How do you do a straight TS emit?

One thing I would like to do is to manipulate the emitted values for string literals. For example I would love to be able to specify strings to be translated with some kind of special syntax in string literals, like "@foo", and have the emitter translate all strings that matches the syntax to a specific function call.
In the non-goal there is : "We will not support end-user extensibility of these transformations at this time, though we may consider this in a future proposal."
So should I assume that doing something like that is not currently possible?

So should I assume that doing something like that is not currently possible?

yes. but we intend to expose all the transformation and factory APIs so it should be possible in the near future.

Thanks for the answer, looking forward to that

In my Typescript packaging compiler I create a single module bundle (via import dependency analysis) and then directly minify the bundle. To minify the ts bundle I must first perform identifier shortening, compile the bundle and then perform whitespace removal on the js output ( a multistep process as I currently don't have access to the emitter ).
With the new transformation and factory APIs I am hoping to do this all in 1 step.
My question is how to provide directives to a transform within the ts source file. Since I have total control of how I package my bundle I can essentially make the whole package internal and thus shorten the majority of identifiers. However, when using Angular 2 components, mangling identifiers which are used within component html templates is a problem!. If I had a mechanism to provide a directive to the minification transform I could then selectively bypass identifier shortening for those used within the template.
As an alternative to transform directives would using /* @transformDirective /, like your use of / @internal */ be the way forward for now?
Thanks for any help!

Out of curiosity, might this change be of benefit to transforming ES6 Maps and Sets to ES5 (#11209)?

@mhegazy

yes. but we intend to expose all the transformation and factory APIs so it should be possible in the near future.

How near is this future?

@mischkl

Out of curiosity, might this change be of benefit to transforming ES6 Maps and Sets to ES5 (#4031, #11209)?

I'm not entirely sure, but I don't think it is a goal of TypeScript to transform non-language features.Map and Set are just references to constructor functions that are implemented by the JS engine, they are not language features really (i.e. they are not syntax features of the language, they are just runtime tools provided to us).
Is there any plan to compile such things in TypeScript?

Is there any plan to compile such things in TypeScript?

No


metrics for odors

It's great to see such a fantastic job. I'm a novice in the field of olfactory research, and I'm looking for some metrics, either physical or chemical, to quantify pleasant and unpleasant odors. Do you have any relevant literature to recommend?

You can use model predictions, such as from https://pubmed.ncbi.nlm.nih.gov/28219971/ or build your own from the data there or from https://bmcneurosci.biomedcentral.com/articles/10.1186/s12868-016-0287-2 or from https://www.jneurosci.org/content/27/37/10015.  One heuristic is that more "complex" molecules are often rated as more pleasant.


Besm4e extras wip

Changes / Comments
BESM4eExtras.html
v1.2.3
Fixed bug where combat rolls were not using new charactername variable.
v1.2.2
Added roll template for rollable attributes
Fixed power flux and power variation stat assignment
Removed stat assignment from attribute group (was not actually used for anything)
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[x] Is this a bug fix?
[x] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[x] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


Add language components

Pull Request Type
What kind of change does this PR introduce?
[X] Feature
Issue Number: #191
What is the new behavior?
3 new languages have been added - Pony, Reason and PureScript.
Does this introduce a breaking change?
[ ] Yes
[X] No

I have a few more I'd like to add so I if you could keep this open for a little bit that would be great!

I have a few more I'd like to add so I if you could keep this open for a little bit that would be great!

I have a few more I'd like to add so I if you could keep this open for a little bit that would be great!

Sure! Add as many as you like. Just tell me when you're ready to merge.

I have a few more I'd like to add so I if you could keep this open for a little bit that would be great!

Sure! Add as many as you like. Just tell me when you're ready to merge.

Are you still going to add more commits to this PR? We usually close pull requests that are in idle for couple days or more to make the repository clean. If you're not adding anything else i can merge this.

I have a few more I'd like to add so I if you could keep this open for a little bit that would be great!

Sure! Add as many as you like. Just tell me when you're ready to merge.

Are you still going to add more commits to this PR? We usually close pull requests that are in idle for couple days or more to keep the repository clean. If you're not adding anything else i can merge this.

I will add the last additions to this PR today, apologies for the delay

@nikohoffren those are the final changes I would like to include in this PR

Pull request merged

This is an automated message from Fork, Commit, Merge - web [BOT].

Thank you for your contribution! Your pull request has been merged and your name has been added to the List of Contributors in README.md.
Please leave a star if you enjoyed working on this project.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects here.


[dx12] patch the pipeline layout with read-only decorations

Fixes the read-only bindings now in dx12. What we used to get is the shader disagreeing with the pipeline layout as to which bindings are UAV and which are SRV. Now we are setting the NonWritable decorations where appropriate.
PR checklist:

[ ] make succeeds (on *nix)
[ ] make reftests succeeds
[ ] tested examples with the following backends:
[ ] rustfmt run on changed code

bors r+


Sync patient data from user to server

As a nurse, I want the patient records on device to be sent in batches to the backend, so that the central database is updated, and the data is safe.
Patient data model
ID - UUID [to discuss]
Full Name - String
Age when created - Integer
Date of Birth - Date
Gender (male / female / transgender) - Enum/String
Status (active, dead, migrated, unresponsive, other [define other]) - Enum/String
Address data model
id – uuid
street address - string
colony - string
village - string
district - string
state - string
country - string
pin - string
Phone number data model
number - string
type -string
active - boolean
Relationships
Patient belongs to an address
Patient has and belongs to many phone numbers

Questions:

Why are UUIDs needed?
What is the "other" patient status?
What should the status be when a patient is "Removed from call list"?
Should village/colony be the same field? Should they be mandatory?
Should we perform any validation on the mobile number?

What is the "other" patient status?
What should the status be when a patient is "Removed from call list"?

Not relevant for MVP.

Should we perform any validation on the mobile number?

No, as discussed with Daniel. To allow landlines, extensions, etc.

Should village/colony be the same field? Should they be mandatory?

Needs answers.


Option to switch off the heater

I would like to switch off the device from midnight to 7 am.

Alright. But can't you?

Maybe. I tried to find the "device" in the automation. But seems to me, I have to "Call service".


add more to text file downloads of taxa tables?

Hello:
Is it possible to add information indicating project name, datasets used, date of processing and analysis in QIITA to text files of taxonomic tables that are downloaded from QIITA? Could the taxonomic level be annotated on the downloaded text file of the taxonomic table (and graph) as well so it can be determined at a glance (phyla, class, family...)? Notation on parameters that we might be able to change prior to generation of the table, versions of QIIME and GreenGenes used to generate the table (as this is required during publication) on a downloaded text file could also be helpful. The same information would be helpful for the graphs and downloaded, especially when returning to datasets in the distant future. Certainly, we should plan to record this information and it will be in QIITA, I'm assuming, but it could still be helpful for documenting efforts. Just a thought - but I do understand if there are other reasons related to data analysis prohibiting this step.
Will OTU tables be available in the future?
Thank you -
Kerri

Decision to make the info available via the summary so it can be downloaded as a html.

This was addressed when we moved to a Qiime2 analytical plugin:


Support pageSize in c8y api command

It seems the --pageSize option is not passed when using the c8y apicommand. Here's a sample passing pageSize 10 (not added in the URL sent to c8y):
-> c8y api "/service/advanced-software-mgmt/software?deviceId=25458010" --pageSize 10 -v
2023-03-04T13:59:55.485+0100	INFO	Binding authorization environment variables
2023-03-04T13:59:55.486+0100	INFO	activityLog path: /Users/kobu/.cumulocity/activitylog/c8y.activitylog.2023-03-04.json
2023-03-04T13:59:55.486+0100	INFO	Loaded session: /Users/kobu/.cumulocity/session.json
2023-03-04T13:59:55.486+0100	INFO	command: c8y api /service/advanced-software-mgmt/software?deviceId=25458010 --pageSize 10 -v
2023-03-04T13:59:55.488+0100	INFO	Max jobs: 0
2023-03-04T13:59:55.489+0100	INFO	worker 1: started job 1
2023-03-04T13:59:55.489+0100	INFO	Headers: map[Accept:[application/json] Authorization:[Bearer {token}] User-Agent:[go-client] X-Application:[go-client]]
2023-03-04T13:59:55.489+0100	INFO	Sending request: GET https://{host}/service/advanced-software-mgmt/software?deviceId=25458010
2023-03-04T13:59:55.621+0100	INFO	Status code: 200
2023-03-04T13:59:55.621+0100	INFO	Response time: 132ms
2023-03-04T13:59:55.621+0100	INFO	Response Content-Type: application/json
2023-03-04T13:59:55.622+0100	INFO	Response Length: 0.7KB
2023-03-04T13:59:55.622+0100	INFO	Unfiltered array size. len=5
2023-03-04T13:59:55.622+0100	INFO	View mode: auto
2023-03-04T13:59:55.626+0100	INFO	No matching view detected. defaulting to '**'
...etc.

It returns 5 elements, 6 are returned when adding pagesize manually to the URL.
Tested in version 2.20.2.

This is actually by design, as I didn't want to assume that the c8y api call is related to a collection. As this command can also be used to get a single object (e.g. c8y api inventory/managedObjects/12345), so adding a pageSize query parameter on those calls does not make too much sense.
So at the moment if you want to specify the page size you can either provide it in the url, or using the --customQueryParam.
c8y api "inventory/managedObjects?pageSize=6"

c8y api "inventory/managedObjects" --customQueryParam "pageSize=6"

Though maybe it will be more useful if the global --pageSize flag is respected also in c8y api considering that pagination seems to work (using --totalPages and --includeAll).

Resolved by #223 and included in v2.21.0


commit notebooks without outputs?

I think it is a better practice to remove outputs before committing to Git and then execute the notebooks on readthedocs.org (or a similar service).
What about removing the outputs and instead adding an example config for RTD?
I guess this wouldn't hurt, right?

Notebooks without outputs should be executed by github actions here, https://github.com/cameronraysmith/nbsphinx-template/blob/cb1cbdb6b8484315860e5aac1045c2e46193168b/.github/workflows/default.yml#L19
which should install packages from requirements.txt in the source directory https://github.com/ammaraskar/sphinx-action#how-to-use.
However, I will point out that many of my personal use cases involve computations requiring computing environments that go beyond what is available in a standard build system like github actions or readthedocs. So, I think it is an advantage in some cases to be able to commit the output in an ipynb file along with a corresponding https://github.com/mwouts/jupytext md file that does not contain the output for inclusion of the output of reasonably demanding computations in the html and pdf versions of the nbsphinx output.
A broader question would be: What example notebooks would be useful to have in an nbsphinx template repository? I just placed a couple I had on hand as an example for now, but would certainly be open to updating them.

OK, using Github Actions and Github Pages is of course also good. I prefer RTD because of the multi-version hosting, but Github Pages is also fine for many cases.

many of my personal use cases involve computations requiring environments that go beyond what is available in a standard build system like github actions or readthedocs.

Sure, but I think this should not be the default case.
I think users should be encouraged to commit notebook without outputs unless there is a reason to commit them.

What example notebooks would be useful to have in an nbsphinx template repository?

I think very basic (and short) examples should suffice, but they should probably use common libraries, e.g. Matplotlib.
There are already many places with general Jupyter example notebooks, a few links could be included for interested readers.

Perhaps a template repository for a documentation generation framework that is already self-documented is superfluous to most users.

I don't know, but I think a template repo doesn't hurt.
I personally have never used any template repo, but I think there are people out there who like that workflow.


GetPath <IP_ADDRESS>

GetPath example page is not correct, 35 is now for example the plugin path.

Thanks for the update.
I've downloaded and installed 1.8 on my desk but I haven't had any time to play with it yet.
I have updated the page with the correct info.
If you are looking for the plugin path you should probably use GetPath("plugins") as the numbers will probably change from version to version.
I would like to find all of the string representations, but I haven't had much time to look for a list.
https://github.com/hossimo/GMA3Plugins/wiki/GetPath/_compare/c3e28dbc09937eb02a3855770c65bae79d902baa...70a5c4eeb9abd5453b6cd0a7a6aaf29ce3fc0bc4?diff=unified
Thanks again.


Fix arg scoping

Fixes #23 and #25, evaluating function arguments in the correct scope. This is an alternative to #30, it fixes the build and passes all tests.

thanks!


Prefix and suffix are not aligned with text when height of TextFieldBoxes is custom

I set the height of TextFieldBoxes to 80dp and found that prefix and suffix were not at the same height as a text.

This is a bug, yet currently I can't fix cuz the original textview behaves weird when cutting of characters.
However, actually you are not supposed to set the height lower than that at wrap_content.
Shrinking the textview will cause the top margin to disappear as well as other bugs (some characters get cut off).
All in all, wrap_content is suggested to be your minimum height :)


package:youtube_player_iframe - Making compatible with Flutter 3.22+

Thanks for this valuable repository
This Pull Request should fix the error described in https://github.com/sarbagyastha/youtube_player_flutter/issues/987
In Flutter 3.22+, the PopScope property onPopInvokedWithResult was renamed to onPopInvoked. As a result, projects using the old name will not be able to compile in the latest Flutter version.
By All-Win Software Team

Hi @nathanael-all-win-software
There is another one place need to be changed:

please fix it

please fix it

Isn't onPopInvokedWithResult the latest one ?

Closing for now. Reopen if needed.


CI: update Node versions in test workflow

Adds Node.js 18.x & 20.x to version matrix.
18 being the latest LTS release & 20 being "current" release.
For successful run of the pipeline, see the PR in the fork

Great, thanks @stscoundrel !


Update Starfinder (simple).html

Add roll buttons to Feats and Special Abilities fieldset, to display feat info in chat.

I have included the button addition on my push (Update Starfinder (simple) A #3600) without changing the feat type attribute.
I really do appreciate a desire to make the sheet better and am always open to suggestions. Please engage me prior to making changes to the sheet. I am very active on this forum post: https://app.roll20.net/forum/post/5576780/starfinder-simple-character-sheet.
Thank you.


multivalidator testnet test framework for integration and e2e testing

The multinode test suite can be run using:
docker-compose up --build --abort-on-container-exit || true && docker-compose down

Which will build and bring up the testnet service, then upon a container's completion it will exist and be brought down.
This work has test scripts as bash and shell scripts, however test files themselves could be called using go test ... if the test files were written in Go in the future.
To run a small testnet service continually (not stopping after tests) I recommend using:
# validator + single node (API port: 1337, RPC port: 26657)
docker-compose up --build --abort-on-container-exit dualityleader dualitynode0 || true && docker-compose down

# single validator (API port: 1315, RPC port: 26637)
docker-compose up --build --abort-on-container-exit dualityleader || true && docker-compose down

Test success example:

Test failure example:

☝ this (https://github.com/duality-labs/duality/pull/53/commits/9b3e79b31a5dc236cf8b3b2d1fe54fa4667c78e6) is the fist version (unnamed prototype version) using the ICS changes (https://github.com/duality-labs/duality/pull/79) that has tests passing by running:
docker-compose up --build --abort-on-container-exit || true && docker-compose down

The last known version before ICS changes (a multi-validator testnet setup) with passing tests (using the same command) was at commit https://github.com/duality-labs/duality/commit/84ac78b89deeccf583ec4a343b773a46f1c6b82b (which was previously included in this PR above: https://github.com/duality-labs/duality/pull/53#event-7731893923)

☝ The previous commits include Docker Compose setups for various versions with various fixes.
Each of the following commits work with Docker Compose tests passing:

https://github.com/duality-labs/duality/pull/53/commits/cee44d7cf9d079ad2302d2ffb6a9a67847aa0e10 release v0.1.0
https://github.com/duality-labs/duality/pull/53/commits/374eec40948564930c22f3f867be12a3b3168f02 release v0.1.0 + feeTier name fixes

this is an import base commit for the Front End PR: https://github.com/duality-labs/duality-web-app/issues/269

https://github.com/duality-labs/duality/pull/53/commits/4dd6d4b4e289cd7cc99fd8f459a7c938bff154e3 release v0.1.1 +  feeTier name fixes (so the Docker containers can start correctly)
https://github.com/duality-labs/duality/pull/53/commits/2023a013dc7dec4cd2978983199de6c1cbe65f22 release v0.1.2

This PR is being closed in favor of adding Docker fixes here, and Docker services in a new https://github.com/duality-labs/docker-services repo

https://github.com/duality-labs/duality/pull/391
https://github.com/duality-labs/docker-services/pull/2


(Bug) #2418 empty error message from FV

Description
Fix returning the correct error object (failedResponse) from the wrapApiCall method in case the HTTP call failed.
After research, I don't see any other reason for this issue.
About #2418
How Has This Been Tested?
There shouldn't be empty message in amplitude error logs for:
useVerificationAttempts
FaceRecognitionAPI
Checklist:

[x] PR title matches follow: (Feature|Bug|Chore) Task Name
[x] My code follows the style guidelines of this project
[x] I have followed all the instructions described in the initial task (check Definitions of Done)
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have added reference to a related issue in the repository
[x] I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
[ ] I have added screenshots related to my pull request (for frontend tasks)
[ ] I have pasted a gif showing the feature.
[x] @mentions of the person or team responsible for reviewing proposed changes

@serdiukov-o-nordwhale
I pushed a fixes for 3rd and 4th points.
Regarding 1st point - Almost all of those logs contain eMsg and attemptsHistory, just few of them didnt, but it should be fixed by https://github.com/GoodDollar/GoodDAPP/pull/2425/commits/0466ddb37cb0a944596d84f7f47308e58c01563e
Regarding 2 point - I don't understand how it should fix this issue? And what exactly you want to change here.

@serdiukov-o-nordwhale
Regarding 2 point - I don't understand how it should fix this issue? And what exactly you want to change here.

i pushed the fix. Please check and you could create PR for RN

Approved


Update Mapzen and Pelias information in readme

This updates the README section for Mapzen and Pelias. Fixes outdated rate limits, fills in the ?, and adds documentation and links to new pricing information for Mapzen, and also links for Pelias.
Thanks!
(disclosure: I am a Mapzen employee.)

Thanks for this! Just one thing: could you add the quota for MapZen/free plan (25k/mo?) in addition to the URL? We want people to be able to get some basic idea of what's available without having to visit another page.

Perfect--thanks!


suppress save of device if name not changed.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@276bc88). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage        ?   74.56%
=======================================
  Files           ?       17
  Lines           ?      983
  Branches        ?      151
=======================================
  Hits            ?      733
  Misses          ?      244
  Partials        ?        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 276bc88...fc88bcc. Read the comment docs.


Agr 305 orthologs revision 1

fix ortholog score denominator
sort orthologs by species taxonomic order, and when tie sort by score numerator
indicate species alteration by table row shading

for testing:
http://dev.alliancegenome.org:4001/gene/WB:WBGene00000912
AGR-305

Oops, I just noticed a small bug after I hit the approve button 😁
If the ortholog list goes directly from mouse to fish (i.e. doesn't include rat), the shading doesn't work. For example: http://dev.alliancegenome.org:4001/gene/RGD:61995
Also, maybe I was misunderstanding what the styling request was, but I thought they were asking for like a heavier line between different species. Maybe it would be easier to put an extra class on the first row for each species and use that to set a heavier/darker top border?

Thanks @paaatrick ! Haha I noticed kinda the same problem after I made the PR. I just pushed and re-deployed. How about this one: http://dev.alliancegenome.org:4001/gene/WB:WBGene00000912

@paaatrick I admit I use shading cuz it seems easier than line, which has to be added to the first of ortholog of a species. Couldn't think on top of my head of how to know if an ortholog is a first. So requirement says "11. Use visible marker (e.g. line, or different colours) to separate species".

works for me!


When in dark mode, MultiFireFox window uses white-on-white for unselected profile names

I can only see the name of the currently "selected" profile, which makes it very tedious to find a specific profile.

Here it is with another profile selected


[Issue-90] Record performance statistics during data loading

Design Method：

We record the earliest and latest time of different thread.
As to streaming like proccessing, we not only record the total time but also record the tiny action of each step who would block each other in thread, so in streaming like processing steps the total time != simple sum(each tiny times)  as the time-interleaving.
Use CarbonTimeStatisticsUtil to record each time point who wa stored in TreeSet structure, we only consider the first and the last time of each step.
After data loading, the statistics information will be printed.
5.“++” means it can be added to the total time while the time info without "++" means it is belong to streaming like processing steps who has time-interleaving and can not be simply added to total time.

The Recorded Steps:

Generate global dictionay total time :
// record csv input to memory time
a. load CSV files to DataFrame by using datasource "com.databricks.spark.csv"
// record csv local dictionay shuffle time
b. combine distinct value in a block and partition by column , including read old dictionary and dictionay RDD shuffle time
// record dictionay write time
c. write global dictionay into file

Generate surrogate keys total time:
// record csv input to memory before generate surrogate key time
a. CsvInputStep cost time
// record transform tuples to surrogatekeys time
b. generating surrogate keys

Sort rows step total time:
a. sort the surrogatekeys in memory and write to temp files
b. intermediate merge these temp files.

MDK generate total time:
// record merge sort time
a. finalMerger startFinalMerge to merge the merged temp files and the left sort temp files in step3
// record mdk generating and store into leafnode time together as this tiny step is stream processing
b. mdk generate step, the surrogate row will be transformed to mdk and this row will be add to store
// record write leafnode&leafnodeInfo to fact file time
c. the dataWriter writeDataToFile and writeleafMetaDataToFile

data move from local disk to HDFS

After data loaded successfully, the statistics information will be printed by each executor.

we need to support concurrency. please have a look StepMonitoringUtil.java of PR#178.


Create instasearch.js adaptor

Hello,
I think it would be pretty cool to be able to use Agnolia Instasearch.js with Open Search. The only low cost alternative that exist at the moment is typesense. The typesense adaptor could be used as reference to create the open search adaptor.
Agnolia Instasearch
https://www.algolia.com/doc/
Typesense adaptor
https://github.com/typesense/typesense-instantsearch-adapter

Hey @windbeneathyourwings !  Thanks for the note.  Is this something you'd be interested in contributing?  It does sound like a cool idea.

Hello @CEHENKLE
I'm considering it because I would like to provide it as part of my own project which exclusively uses open search for search. Its just a matter of prioritizing it considering I work on all this stuff outside of work.
https://github.com/ng-druid/platform

@windbeneathyourwings I haven't seen anyone working on anything similar yet.
My understanding is that you'd want to build an adapter so you'd be able to use Instantsearch (and potentially related React, Vue and Angular tools) with data indexed in OpenSearch (as opposed to a Typesense search server). Is that correct?

@ahopp
Yes, create an adaptor like the type sense one but for open search.

@windbeneathyourwings  are you still working on contributing to this issue? Thanks

@minalsha Yes, I still plan on building an open search adaptor unless someone takes it on before able to prioritize.

Hi !
i think this project for ES / OS with a instant search adapter : search do the work if some people can confirm.

Looks like some of it is covered, e.g.,

Searchkit provides a Search UI for Elasticsearch or Opensearch. With Searchkit, you can use Instantsearch components like Searchbox, refinement filters and results (and many more!) to build a search experience.

But it might be worthwhile from some validation since it still explicitly calls out an ES specification (e.g., Searchkit Node API proxies Elasticsearch requests from the browser and the use of Elasticsearch Query DSL for advanced queries) despite usability with OpenSearch (specifically, Opensearch 2.4 or higher).


Port mix() to Laravel 5.2

Would be possible to backport mix() to older Laravel versions?
I'm using webpack and mix already but I can't upgrade my project to 5.3 or 5.4 yet.

Laravel Version: 5.2.45
PHP Version: 5.6/7.0

Sorry, Laravel 5.2 is closed for changes like this.


npm installation of mbt issue

Please provide the following info:

MBT Version: v1.0.1
OS Version: "Ubuntu 18.04.2 LTS"

Steps to Reproduce:
1.npm install -g mbt
2.Got (https://github.com/SAP/cloud-mta-build-tool/files/3900865/log_file.zip)
an error, permission denied to use command mkdir
ERR { Error: EACCES: permission denied, mkdir '/usr/lib/node_modules/mbt/unpacked_bin'
at Object.fs.mkdirSync (fs.js:885:18)
at /usr/lib/node_modules/mbt/node_modules/binwrap/binstall.js:46:10
at new Promise ()
at untgz (/usr/lib/node_modules/mbt/node_modules/binwrap/binstall.js:21:10)
at binstall (/usr/lib/node_modules/mbt/node_modules/binwrap/binstall.js:11:12)
at install (/usr/lib/node_modules/mbt/node_modules/binwrap/install.js:20:10)
at Object.install (/usr/lib/node_modules/mbt/node_modules/binwrap/index.js:14:14)
at Object. (/usr/lib/node_modules/mbt/node_modules/binwrap/bin/binwrap-install:18:9)
at Module._compile (module.js:653:30)
at Object.Module._extensions..js (module.js:664:10)
at Module.load (module.js:566:32)
at tryModuleLoad (module.js:506:12)
at Function.Module._load (module.js:498:3)
at Function.Module.runMain (module.js:694:10)
at startup (bootstrap_node.js:204:16)
at bootstrap_node.js:625:3
errno: -13,
code: 'EACCES',
syscall: 'mkdir',
path: '/usr/lib/node_modules/mbt/unpacked_bin' }

Workaround (this command works): sudo npm install -g mbt --unsafe-perm=true --allow-root

Solution found in : https://github.com/npm/npm/issues/17268
Seems that the npm install step described in https://sap.github.io/cloud-mta-build-tool/download/
does not work for my system. Perhaps a bug or just need a correction to the MBT guide. Thanks for your help in advance. I have attached a more comprehensive log file of the exception.
log_file.zip

@katunin-ng - as this is related to OS user permission, I think we can add it to the troubleshooting guide.

Fixed, added to the troubleshooting section.

thank you @ShimiT !

i've got same issue and resolved by add  -unsafe-perm=true --allow-root
Full command: npm i -g mbt -unsafe-perm=true --allow-root
Hopefully can help


I can't see the chunksUpload event.

If I add it would you accept a PR?

Hi @benbowler
Yep more than happy to accept a PR.
Thanks,
Rowan

Relook at the dropzone doco and i dont think there is a chunksUpload event


Added connection string

Description
This is a draft - @benbrown you can take this branch and add the handling of the connection string with the runtime/migration.
Task Item
Screenshots

Coverage remained the same at 51.154% when pulling a4e7e85483fe2fe25655d65b615eff607195ddc6 on gcox/fix6842 into 31d20acc127db42abd8db7aa03f63d34f69c9ad2 on main.


Use SPAWN_DEFAULT_PRIORITY

There was one spot where the hardcoded value was still being used.

This Pull Request has been merged by GitConsensus.
Vote Totals

Yes
No
Abstain
Voters

3
0
0
3

Vote Breakdown

User
Yes
No
Abstain

tedivm
✔

ags131
✔

anisoptera
✔

Vote Results

Criteria
Result

Has Quorum
True

Has Votes
True


Automate smoke test on Azure

In order to improve deis' quality on various providers, we'd like to have a way to test deis on Azure in an automated fashion.
What I'd like to see is:

provision a 3 node cluster on Azure
run the smoke test script after provisioning is complete.

Also see #4035

This is not something we'll be able to get to fixing for the LTS release, and provisioning Deis v2 is done through installing a vanilla kubernetes cluster so I'm going to go ahead and close this.


addon-authentication: confirm_on_create? true is not working

In a new project created with igniter, email confirmation seems not working.

A newly created user is directly logged in
The confirmation link (displayed in the console) does nothing except showing an alert 'Incorrect email or password' if the user is logged out.

Project creation :
mix igniter.new auth_poc --install ash,ash_postgres --with phx.new --yes
cd auth_poc
mix igniter.update_gettext --yes
mix igniter.install ash_authentication_phoenix --yes
mix ash_authentication.add_strategy password
mix ash.setup

Authentication part of user.ex generated by the igniter tasks :
authentication do
    tokens do
      enabled? true
      token_resource AuthPoc.Accounts.Token
      signing_secret AuthPoc.Secrets
    end

    strategies do
      password :password do
        identity_field :email

        resettable do
          sender AuthPoc.Accounts.User.Senders.SendPasswordResetEmail
        end
      end
    end

    add_ons do
      confirmation :confirm_new_user do
        monitor_fields [:email]
        confirm_on_create? true
        confirm_on_update? false
        sender AuthPoc.Accounts.User.Senders.SendNewUserConfirmationEmail
      end
    end
  end

Confirmation link displayed in the console after sign in:
...
↳ AshPostgres.DataLayer.bulk_create/3, at: lib/data_layer.ex:1821
Click this link to confirm your email:

http://localhost:4000/auth/user/confirm_new_user?token=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJhY3QiOiJjb25maXJtIiwiYXVkIjoifj4gNC4yIiwiZXhwIjoxNzI5OTIxMjc1LCJpYXQiOjE3Mjk2NjIwNzUsImlzcyI6IkFzaEF1dGhlbnRpY2F0aW9uIHY0LjIuMyIsImp0aSI6IjMwMGZzdmh1czFsZm9kaTBybzAwMGFpMSIsIm5iZiI6MTcyOTY2MjA3NSwic3ViIjoidXNlcj9pZD1mNDExMjA5Yi04MzZhLTRlNTEtOWVmZi0yYmFmYjg3YzVkNGIifQ.3LZdHTkiQWrEdSgGWIpOE45qSFOE7XGOyQdTExuI4_s

[debug] QUERY OK db=0.3ms
commit []
...

Versions :

erlang 27.1.2
elixir 1.17.3
phoenix 1.7.14
ash 3.4.34
ash_authentication 4.2.3
ash_authentication_phoenix 2.1.9

This may be a problem with the generated code. Instead of the "token" query parameter, can you specify the token in the "confirm" query parameter?
It is intentional that the user is logged in immediately. If you don't want unconfirmed users to be able to log in you can implement a plug that redirects them to a page asking them to confirm their email.

This may be a problem with the generated code. Instead of the "token" query parameter, can you specify the token in the "confirm" query parameter?

It works if the token is passed as 'confirm' parameter in the query.
http://localhost:4000/auth/user/confirm_new_user?confirm=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJhY3QiOiJjb25maXJtIiwiYXVkIjoifj4gNC4yIiwiZXhwIjoxNzI5OTIxMjc1LCJpYXQiOjE3Mjk2NjIwNzUsImlzcyI6IkFzaEF1dGhlbnRpY2F0aW9uIHY0LjIuMyIsImp0aSI6IjMwMGZzdmh1czFsZm9kaTBybzAwMGFpMSIsIm5iZiI6MTcyOTY2MjA3NSwic3ViIjoidXNlcj9pZD1mNDExMjA5Yi04MzZhLTRlNTEtOWVmZi0yYmFmYjg3YzVkNGIifQ.3LZdHTkiQWrEdSgGWIpOE45qSFOE7XGOyQdTExuI4_s

Awesome, thanks for confirming. I will fix the generator in a few hours so that new projects will use the correct parameter.

It is intentional that the user is logged in immediately. If you don't want unconfirmed users to be able to log in you can implement a plug that redirects them to a page asking them to confirm their email.

Then what's the purpose of confirm_on_create?? That seems kind of confusing

confirm_on_create ensures that confirmed_at is not set to true, and sends a confirmation email. The confirmation plugin currently only does three things:

ensures the sender is invoked whenever its conditions are met (confirm_on_create/confirm_on_update)
manages the confirmed_at field when confirmation occurs
prevents upserting against non-confirmed rows (for safety)

What it means to be unconfirmed is up to the application currently. @jimsynz might have a better articulated explanation here.

This issue is fixed in the latest release.


CI test

Small commit to trigger CI (and if necessary this will be updated with fixes)

@AlexDBlack closing this now. I'll be viewing the CI changes from PR #277


fix(result): change naming to suit scannable

Context

What has been done

Validation

PR check list

[ ] As much as possible, the changes include tests (unit and/or functional)
[ ] If the changes affect the end user (new feature, behavior change, bug fix) then the PR has a changelog entry (see doc/dev/getting-started.md). If the changes do not affect the end user, then the skip-changelog label has been added to the PR.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (garancegourdel/refacto-output-handlers-to-remove-scanable-from-result@5eeff39). Learn more about missing BASE report.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@                                           Coverage Diff                                            @@
##             garancegourdel/refacto-output-handlers-to-remove-scanable-from-result     #908   +/-   ##
========================================================================================================
  Coverage                                                                         ?   91.75%
========================================================================================================
  Files                                                                            ?      173
  Lines                                                                            ?     7111
  Branches                                                                         ?        0
========================================================================================================
  Hits                                                                             ?     6525
  Misses                                                                           ?      586
  Partials                                                                         ?        0

Flag
Coverage Δ

unittests
91.75% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


grpcio fails to install as a dependency from pyhelm

Should this be an issue in the gRPC issue tracker?
What version of gRPC and what language are you using?
Python 3.6.4
Trying to install 0.3.post19
What operating system (Linux, Windows, …) and version?
Darwin HSz-MBP-J 16.7.0 Darwin Kernel Version 16.7.0: Thu Jan 11 22:59:40 PST 2018; root:xnu-3789.73.8~1/RELEASE_X86_64 x86_64
What runtime / compiler are you using (e.g. python version or version of gcc)
Python 3.6.4
What did you do?
Tried to install grpcio (as a requirement from pyhelm)
What did you expect to see?
package installing correctly
What did you see instead?
ip3 install --upgrade pyhelm grpcio
Collecting pyhelm
  Using cached pyhelm-0.0.1.dev33.tar.gz
Requirement already up-to-date: grpcio in /usr/local/lib/python3.6/site-packages
Collecting grpc==0.3.post19 (from pyhelm)
  Using cached grpc-0.3-19.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/x0/0fb1ckx53f58_t_yh8shttm80000gp/T/pip-build-2kh5qcw4/grpc/setup.py", line 7, in <module>
        version_tuple = __import__('grpc').VERSION
      File "/private/var/folders/x0/0fb1ckx53f58_t_yh8shttm80000gp/T/pip-build-2kh5qcw4/grpc/grpc/__init__.py", line 6, in <module>
        from .rpc import *
      File "/private/var/folders/x0/0fb1ckx53f58_t_yh8shttm80000gp/T/pip-build-2kh5qcw4/grpc/grpc/rpc.py", line 141
        except OSError, ex:
                      ^
    SyntaxError: invalid syntax

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /private/var/folders/x0/0fb1ckx53f58_t_yh8shttm80000gp/T/pip-build-2kh5qcw4/grpc/

Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).
Anything else we should know about your project / environment?
Not sure if this is relevant...
$ pip3 install  grpcio
Requirement already satisfied: grpcio in /usr/local/lib/python3.6/site-packages
Requirement already satisfied: protobuf>=3.5.0.post1 in /usr/local/lib/python3.6/site-packages (from grpcio)
Requirement already satisfied: six>=1.5.2 in /usr/local/lib/python3.6/site-packages (from grpcio)
Requirement already satisfied: setuptools in /usr/local/lib/python3.6/site-packages (from protobuf>=3.5.0.post1->grpcio)

being addressed here https://github.com/flaper87/pyhelm/issues/9

Probably a dupe of https://github.com/grpc/grpc/issues/14573 and should be fixed now. Please retry (ensure pip is not using previously cached package if it is failing). Let us know if that is fixed for you.

@joaocc I just tried installing on macOS, and it seems like there's a misconception here: grpc package is not us at all :-)
This gRPC project is served under grpcio PyPI package, not grpc.  I see pip install ends up fetching grpcio too, but it is depending on a very old version of that, and but nevertheless that's not where it is failing. It's failing on grpc compilation, which is not us (wrong number!).

lol. you are right. sorry about the confusion.


Disable walk on any invalid object/area

Maybe a nice QoL thing to have is when you could disable walking on any movement blocked tiles? Much like the "Invalid Movement" plugin is showing you where you can and cannot go. This would potentially fix your character running in random directions when you missclick.

Thanks for the suggestion. Feature has been added as two config options and the plugin will be updated whenever it is merged into the plugin hub. It only works for tiles that cannot be walked on. For example, a tile that has an object on it or a tile that is a wall. I tried to make it work for unreachable tiles that could be walked on but it is not easily done and at this point, its not worth the effort.


extensibility

Looks like any extra support (focus control, debounced validation, etc) requires to build own chains and register it in app level.
Currently index.js is very simple and in fact could be not used at all, if you decide to build your own chains.
Maybe we should better provide actions, factories, uttilities, etc in cerebral-forms package without module. We still can have cerebral-module-forms with default setup as easy start point.

@Guria Would really like to see helpers for focus control etc.


feat: support directly stream logs from container to stdout in debug mode

End-user friendly description of the problem this fixes or functionality that this introduces

[ ] Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions
This PR update the implementation of the old LogBuffer into LogStreamer. The problem with the old one is that: when pods crashes, some of the log might not be printed timely to stdout, making it hard to debug.
This PR introduces LogStreamer that directly stream docker container / {modal, runloop} sandbox's output to stdout so it is easier to see what happened inside runtime.

Link of any specific issues this addresses

To run this PR locally, use the following command:
docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:6de713f-nikolaik   --name openhands-app-6de713f   docker.all-hands.dev/all-hands-ai/openhands:6de713f

I think this is clearly necessary for working with the runtime. I have a question about the rest - we have too many logs, from unrelated parts of the code. Even as it is today, it's sometimes difficult to see the relevant logs from other components because the docker logs cover a large part of the available console. Fixable, just not great.
How do you think we could address that? I imagine we could consider:

splitting logs per component, to enable/disable separately
and/or set log level separately
introduce a trace level and move a lot there
set some env var for the runtime logs?

set some env var for the runtime logs?

@enyst Yeah i think this should be relatively easy to do now - we only need to enable it when we are developing runtime.
@openhands-agent - First, you should check the git diff against main and understand the purpose of this PR.
Can you help create a DEBUG_RUNTIME flag in the logger, and only log runtime when env var DEBUG_RUNTIME=true is set.

OpenHands started fixing the pr! You can monitor the progress here.

The workflow to fix this issue encountered an error. Openhands failed to create any code changes.

The reason why the agent failed: it actually did some, but then:
packages/openai/_base_client.py", line 1061, in _request
    raise self._make_status_error_from_response(err.response) from None
openai.NotFoundError: Error code: 404 - {'error': {'message': 'litellm.NotFoundError: AnthropicException - {"type":"error","error":{"type":"not_found_error","message":"model: *"}}\nReceived Model Group=claude-3-5-sonnet-20241022\nAvailable Model Group Fallbacks=[\'anthropic/claude-3-5-sonnet-20241022\']\nError doing the fallback: litellm.NotFoundError: AnthropicException - {"type":"error","error":{"type":"not_found_error","message":"model: *"}}No fallback model group found for original model_group=anthropic/claude-3-5-sonnet-20241022.

@openhands-agent This is what we need to fix now:

set some env var for the runtime logs?

@enyst Yeah i think this should be relatively easy to do now - we only need to enable it when we are developing runtime.
@openhands-agent - First, you should check the git diff against main and understand the purpose of this PR. Can you help create a DEBUG_RUNTIME flag in the logger, and only log runtime when env var DEBUG_RUNTIME=true is set.

OpenHands started fixing the pr! You can monitor the progress here.

The workflow to fix this issue encountered an error. Please check the workflow logs for more information.

Overview of Changes:
✓ Successfully implemented DEBUG_RUNTIME environment flag
✓ Runtime logging now properly conditional
✓ Correct log directory structure maintained
✓ Consistent with existing logging patterns
Status: All requested changes appear to be fully implemented with no remaining issues. The solution matches the original requirements for conditional runtime logging controlled by an environment variable.

openhands-agent, the last commit on this branch was mostly not correct:

the setup of runtime logging in the logger.py file calls the function _setup_llm_logger(), but that function is for the llm, not for the runtime; calling this function is incorrect and we must change it
to understand what logger we need instead, you need to understand what the runtime is, read as an example eventstream_runtime.py and its base class
read what other logger we have defined in logger.py. Prefer minimalistic, use existing if you can
the runtime logging happens in the LogStreamer, read this class.

Then fix the PR to do what xingyaoww said.

OpenHands started fixing the pr! You can monitor the progress here.

Overview of Changes:
Status: PARTIALLY RESOLVED with REMAINING ISSUES
Successfully Implemented:

Initial progress on DEBUG_RUNTIME flag
Basic logging infrastructure setup

Key Outstanding Issues:

_setup_llm_logger() usage still needs to be removed/replaced
LogStreamer class integration not yet implemented
No evidence of leveraging existing logging infrastructure
Lack of demonstrated runtime context understanding

Recommendation:
A follow-up implementation is needed focusing specifically on:

Removing _setup_llm_logger()
Properly integrating LogStreamer
Using existing minimal logging solutions
Showing clear understanding of runtime context

The changes represent initial progress but fall short of fully addressing the core requirements from the feedback.

The workflow to fix this issue encountered an error. Please check the workflow logs for more information.

Now OpenHands, we should pass a version of self.log to the log streamer that uses the runtime logger, instead of the openhands logger.

OpenHands started fixing the pr! You can monitor the progress here.

The workflow to fix this issue encountered an error. Please check the workflow logs for more information.

For sure!


Update codemirror -> 6.x

Thought this might be a drop-in upgrade as changes in https://github.com/codemirror/basic-setup/blob/main/CHANGELOG.md looked minimal, but I believe something might have changed with their default exports. Needs a bit of a closer look.

Changes from version 5 to 6 are major.
Version 6 exposes only modules, and the entire library has been split into separate packages, requiring more manual configuration. Other changes that I am aware of: events are handled differently, functionality and decoration is passed to the editor through extensions (I believe similar to editorSpec in the v5 hoist version but implemented differently), and the fromTextArea method is no longer supported (although the docs do provide a function with similar behavior).
Some documentation specifically about version 5 to 6 migration is available here in addition to the normal docs, which are quite thorough.

+1 on this one!


[BUG] Screen became orange upon pipeline completion (web)

Orange (minor issue and changing to new helped)

this looks like text highlighting using the mouse where a portion of the screen was selected.

Cannot reproduce on Firefox for linux.  Feel free to reopen with bug report template (version information and steps to reproduce).


Add support for --user units

Allows to do the following:
systemctl --user start<EMAIL_ADDRESS>I modified the service file to pass a second argument (%U) to the executable. The executable use this argument to know if it should pass either --system (default) or --user to journalctl or systemctl.

Systemd unit specifier:

"%U"
User UID
This is the numeric UID of the user running the service manager       instance. In case of the system manager this resolves to       "0". Note that this setting is not influenced by the       User= setting configurable in the [Service] section of the service       unit.

@c-meier thank you for your contribution!
I refactored the code a bit to just pass "--system" or "--user" instead of deriving it from the uid, since we already know that inside the respective unit file.


Fix missing trimming annotation and set couple cswinrt properties

We have IsTrimmable set in our projection projects.  But this doesn't show up in the resulting assembly as an assembly attribute.  This turns out it is due to at some point we started using a custom AssemblyInfo.cs which meant the attribute that was generated in the default one is no longer there.  While checking the assembly I also noticed the IIDOptimizer is inserting a type that is unused given nothing needs to be optimized and that the vtable lookup generation table was generated because CsWinRT failed to properly detect this as a projection project.  So, disabling those with the respective properties to control them.
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.

/azp run


Update README.md

Canonical CBOR in RFC 7049 (Oct 2013) requires encoding floating-point NaN values to 0xf97e00.
RFC 7049bis Draft 12 (Dec 2019) is more lenient (doesn't say "must") about encoding to 0xf97e00.
Thanks Faye for pointing out stricter requirements in the older but approved 7049.  I stopped reading RFC 7049 after the errata incident in #46 and only used the newer not-yet-approved 7049bis.
For now, document this library always encodes NaN to 0xf97e00 for all encoding configurations (not just Canonical CBOR) and consider adding an option to override this if the need arises.  While updating Limitations section, I reordered items.
I'm not sure if doing this is OK with CTAP2 because that standard says, "The representations of any floating-point values are not changed".  Maybe CTAP2 was just referring to conversions between float64, float32, and float16.  Even so, encoding a float64 NaN to 0xf97e00 means a conversion from float64 representation to float16 representation 0x7e00.
Updates #86

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   97.11%   97.11%
=======================================
  Files           6        6
  Lines        1422     1422
=======================================
  Hits         1381     1381
  Misses         28       28
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d7339...15e6430. Read the comment docs.


Optimize computing several lagrange coefficients in a row

Sometimes we have the same fixed set of polynomial points $\vec x$ and index $j$, and we're computing lagrange coefs $\text{coef}(j, x, \vec x)$ for different $x$. Recall that lagrange coef is computes as:
$$\text{coef}(j, x, \vec x) = \frac{\prod_{m \ne j} x - \vec x_m}{\prod_{m \ne j} \vec x_j - \vec x_m}$$
Note that denominator is independent of $x$. We can compute
$$\text{denom}_{j, \vec x} = (\prod_{m \ne j} \vec x_j - \vec x_m)^{-1}$$
then we can compute lagrange coef without doing modular inversion:
$$\text{coef}'(x, \text{denom}) = \text{denom} \cdot  \prod_{m \ne j} x - \vec x_m$$

Computing lagrange coef code:
https://github.com/dfns/generic-ec/blob/924bc18fc39996ee8f8886391cc95e6e4256fc78/generic-ec-zkp/src/polynomial.rs#L341-L363


Optimizing Website Structure: Integrating Blog Sections Seamlessly

The current approach involves creating a new blog to house articles. However, with the existing website framework, simply substituting sections within the blog can maintain the original appearance of the webpage!
By integrating blog sections seamlessly into the website's structure, we can preserve its initial design while still leveraging the blog's functionalities. This method not only retains the website's aesthetic but also enhances the user experience by offering cohesive navigation and content accessibility without significant alterations to the overall layout.

可以把文章生成在 inc/blog/blog_title 並且變成

 以現有 about, portfolio, resume, contact 按鈕切換顯示的方式來顯示文章，如此都可以在整個網頁 / 下做切換，不要再去 get post！

參考以下專案 blog POST api
https://github.com/chetanverma16/react-portfolio-template


Enable "Use GPU hardware acceleration" setting by default instead of disabling it

When the GPU option is disabled, it might cause flashing on the desktop app - see https://pre-release.mattermost.com/core/pl/gwwxyj9r13yc5q6pkt31afp9ao
We should not disable the GPU option on macOS.

Closed via #799


Allow dm.fs to be overridden

We're seeing some bad behavior when xfs is used and the underlying LV/VG/PV are completely full.  Experimentally, ext4 has better failure modes, so this commit allows setting the filesystem.

+1 looks good

This is an option which we directly pass to docker and don't take any action ourselves. And there are many docker options one might need to pass. For example, dm.mountopts, dm.basesize etc.
I am wondering why not create a generic option which will simply pass the option string to docker daemon. For example.
DOCKER_STORAGE_OPTS="--storage-opt dm.fs=xfs --storage-opt dm.mountopt=foo"
It is user's responsibility to provide option string which makes sense to docker and also which does not conflict with other options which will be generated internally by docker-storage-setup. That way we will not end up defining one option for every docker storage option.

Thinking more about it. Problem with DOCKER_STORAGE_OPTS is that we are not in a position to override some of the defaults and user specified options might conflict. For example, by default we are specifiying dm.fs=xfs and if user provides dm.fs=ext4 then it is not a pretty situation.
May be we can scan DOCKER_STORAGE_OPTS string and see if user has passed in dm.fs option or not. If not, we pass in dm.fs=xfs

Thinking more about it. Problem with DOCKER_STORAGE_OPTS is that we are not in a position to override some of the defaults and user specified options might conflict.

Yep, that's why I went for the simplest option here.

Can we scan and use dm.fs accordingly. Otherwise we will just end up creating a new knob for every docker storage option.

@rhvgoyal I've updated the pull request to scan and use the existing dm.fs accordingly.

CC @shishir-a412ed

bot, test pull request

@rhvgoyal Is there anywhere specific I should call out this new behavior in the man page?

@samuelkarp I thought you will create a new option say "DOCKER_STORAGE_OPTS=" which can be specified in docker-storage-setup. But you seem to be using get_docker_storage_options functions which reads /etc/sysconfig/docker-storage. That's not what we are looking for. That's the output file we are generating?

Ah, I misunderstood what you were asking.  I will change it as you suggest.  (As a note, my existing change does work, you just set --storage-driver devicemapper --storage-opt dm.fs=ext4 in /etc/sysconfig/docker-storage prior to running docker-storage-setup.  However, I think it's clearer with a separate variable in /etc/sysconfig/docker-storage-setup, so I will make that change.)

/etc/sysconfig/docker-storage is the output file of docker-storage-setup. And /usr/lib/docker-storage-setup/docker-storage-setup is the input file. So we should allow user to specify the options in input which get generated in output file appropriately.

@rhvgoyal I've updated it per your comments.

We need to modify man page too (docker-storage-setup.1)

I'm limiting it to dm.fs as that's the only one I really have time to test right now.  For other options, a more complete merging strategy is likely appropriate, but that can always be added in later.
docker-storage-setup.1 is modified with the latest revision.

You don't have to test everything. I think just test 2 together and if it works, it is reasonably safe to assume things are working. May be --storage-opt dm.fs=ext4 and --storage-dm.basesize=foo can be tested together. I don't want to limit it to dm.fs only. That defeats the purpose of introducing a generic option.

@rhvgoyal I've made it more generic.  Can you take a look?

@rhvgoyal Thanks for the review!  I've addressed your comments; can you take a look again?

bot, add author to whitelist

@rhvgoyal Updated

LGTM

@shishir-a412ed @rhatdan @cgwalters I am looking for one more review and LGTM and then I will merge it.

LGTM


[Tables] Emulator tests and binary serialization

Includes 2 updates:

Added tests for the Cosmos emulator endpoints (with some fixes to support this)
Fixes #18733 for de/serializing binary data in entities

/azp run python - tables - tests


golang 1.3.3 image

Looks like golang v1.13.2 or v1.13.3 image does not exist yet.
relates to https://github.com/golang/go/releases/tag/go1.13.3
Relates to https://github.com/roboll/helmfile/pull/897

It takes time. Please see this blog post: https://circleci.com/blog/build-image-update-schedule/
We also have a new image that will eventually replace this one in public beta. It already has both of today's Go releases: https://github.com/CircleCI-Public/cimg-go

@felicianotech Thanks a lot!


Diagnostics For Lux

Todo:

diags build vs optimized build (to enable/disable lux feedback)

Done:

diag method to show dep tree
look into separate lib (?) with component that renders dep tree (shows actions, etc)

Alas old issue
I come to bid you farewell
haiku, for the win


[Emscripten/Javascript] build compile error

Using Visual Studio's 2013 Developer Command Prompt, I was trying to compile a HTML5 platform build to experiment the new features of the web export, but not so much as getting this error when trying to complie:

scons: *** Multiple ways to build the same target were specified for: main.javascript.opt.debug.bc  (from ['main.cpp'] and from ['input_default.javascript.opt.debug.bc', 'main.javascript.opt.debug.bc', 'performance.javascript.opt.debug.bc'])

I was told on the Godot forums that it may be related to the Windows Case-Sensitivity, but what do I know. Hopefully this can get resolved so then I can try to export game projects to HTML5 format.

To be honest, never tried to build html5 backend on windows
On Jan 24, 2016 18:20, "Corruptinator"<EMAIL_ADDRESS>wrote:

Using Visual Studio's 2013 Developer Command Prompt, I was trying to
compile a HTML5 platform build to experiment the new features of the web
export, but not so much as getting this error when trying to complie:
scons: *** Multiple ways to build the same target were specified for:
mainjavascriptoptdebugbc (from ['maincpp'] and from
['input_defaultjavascriptoptdebugbc', 'mainjavascriptoptdebugbc',
'performancejavascriptoptdebugbc'])
I was told on the Godot forums that it may be related to the Windows
Case-Sensitivity, but what do I know Hopefully this can get resolved so
then I can try to export game projects to HTML5 format
—
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/3438.

what scons command are you running? and why is there no dots in the error?
how hard is it to get the emscripten sdk for windows?
On 24 January 2016 at 19:34, Juan Linietsky<EMAIL_ADDRESS>wrote:

To be honest, never tried to build html5 backend on windows
On Jan 24, 2016 18:20, "Corruptinator"<EMAIL_ADDRESS>wrote:

Using Visual Studio's 2013 Developer Command Prompt, I was trying to
compile a HTML5 platform build to experiment the new features of the web
export, but not so much as getting this error when trying to complie:
scons: *** Multiple ways to build the same target were specified for:
mainjavascriptoptdebugbc (from ['maincpp'] and from
['input_defaultjavascriptoptdebugbc', 'mainjavascriptoptdebugbc',
'performancejavascriptoptdebugbc'])
I was told on the Godot forums that it may be related to the Windows
Case-Sensitivity, but what do I know Hopefully this can get resolved so
then I can try to export game projects to HTML5 format
—
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/3438.

—
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/3438#issuecomment-174348482.

@punto- about the dots, it's a GitHub bug that somehow omits the dots in every email from a just opened issue. In the page you can see the dots.
Also, Emscripten for Windows needs Visual Studio 2010 to build. Don't know what it needs when it have the toolchain ready. Also, I think it doesn't need a Developer Command Prompt, a regular prompt should do it. I'll try to test this tomorrow.

Alright, so basically I was attempting to get the HTML5 compile to work on windows after managing to get the Developer Command Prompt for Visual Studio 2013 to work, what I did first was install the necessary downloads for Emscripten to work with Scons such as Node.js, Python, Java, and so forth. Next i was able to set the environment variable using the "setx" command used in Windows 7. (For Example: [setx EMSCRIPTEN_ROOT "Insert path to Emscripten SDK"]). Afterwards, I thought it could work but instead I got that error now.
Also the command I was using to try to compile HTML5 was: "scons -j 4 p=windows target=release tools=no bits=32", based on what this page told me:http://godotengine.org/projects/godot-engine/wiki/Batch_building_templates.
The Windows compile works, probably the same with WinRT as well, but javascript is where I am stuck on now...

There's a installer package for Emscripten to Windows, which makes it a little easier. The package install all dependencies, so no need to install them before.
It also installs a "Emscripten Command Prompt", which I guess is the best to compile Godot, but it might make not much difference from a regular prompt except from some small config in the environment. The "Developer Command Prompt" from Visual Studio will not work, and gives the error mentioned in the OP.
However, I get an error that the config file ~/.emscritpen is not found, because this is not a standard path in Windows (should be %USERPROFILE%\.emscripten).
If I pass the --em-config flag to emcc in order to set the correct path to the config file, I get yet another error saying it can't detect the number of cores. This comes from a Python script inside Emscripten. It supposedly reads the value from the  EMCC_CORES environment or from multiprocessing Python lib, but none of those work, even if the environment variable is set.
As a workaround, I edited Emscripten Python files under the installed SDK folder:

tools/shared.py to change the default EM_CONFIG to the correct path in my system. Otherwise the --em-config had to be passed to every command.
tools/system_libs.py to hardcode a number of processor cores.

Then I bumped into the "command line too long" problem. Not sure how to work around this.

Alright so I am getting closer to trying to get Javascript to work on windows, I added mingw to the PATH variable so then the windows command can use GCC to compile, emscripten almost works but now I have a new problem, I get this error:

Traceback (most recent call last):
File "C:[emscripten_path]\emcc", line 28, in
from tools import shared, jsrun, system_libs
File "C:[emscripten_Path]\system_libs.py", line 17, in
scons: *** [platform\javascript\javascript_main.javascript.opt.bc] Error 1
CORES = int(os.environ.get('EMCC_CORES') or multiprocessing.cpu_count())
File "C:\Python27\lib\multiprocessing_init_.py", line 136, in cpu_count
raise NotImplementedError('cannot determine number of cpus')
NotImplementedError: cannot determine number of cpus
scons: *** [platform\javascript\audio_server_javascript.javascript.opt.bc] Error 1

You mentioned about the cpu core issue within python and that you ended up on the command line too long, this is the same on what I was going through. Sigh, I wish there was an another way to fix this...

just realized, don't use the visual studio command prompt for this

visual studio command prompt is for building with msvc, if you are building something else, use regular command prompt or mingw command prompt

@reduz I pointed this out in my previous comment, however it doesn't work even in a regular prompt or Mingw. I tried to enable the spawn fix for Javascript but then got a cryptic error (%1 is not a valid Win32 application) which I don't know how to fix.

Well then, I guess I'll take your word for it. I'll see if the mingw command prompt works. Thanks for the feedback.

Have any of you had any progress on this? I can replicate the "command line too long", but don't quite understand how you handled that and ended up with the "%1 is not a valid Win32 application" error.

This is fixed, but I need to update the docs to add this info that you can't use the Developer Prompt.

Sounds good to me.


Go 1.13 error wrapping: Use fmt.Errorf as per 1.13.

Use fmt.Errorf as per 1.13. Changed errors.Wrap and errors.Wrapf to use fmt.Errorf.
Fixes #2308
Closes #2308

Description of the change:
As the code is upgraded to go 1.13, error handling has been changed. The PR addresses the same.

errors.Wrap(), errors.Wrapf(), are replaced with fmt.Errorf() with %w.
fmt.Errorf() calls that wrap an error, but use %s or %v, are replaced with fmt.Errorf() with %w
Uses of the github.com/pkg/errors package is transitioned over to Go's standard library errors package.

All fmt.Errorf() calls that wrap an error are changed as below:
fmt.Errorf("some context about my error: %w", err)
Motivation for the change:
Upgrade to go 1.13 version

@joelanford @jmrodri @jmccormick2001
Can you please take a look. I had made multiple commits but have now squashed them and CI has passed.
Let me know if there are any changes to be done.

@estroz can you please check the changes and let me know if additional changes are needed. Thanks

@camilamacedo86 I have rebased and pre-submit checks have passed. PTAL.
Let me know if any additional changes are needed. Thanks for accepting the contribution.

I hope I have addressed all the changes. @estroz @camilamacedo86 PTAL. Thanks.

@estroz @camilamacedo86 Travis error shows that there is a mismatch in go module versions.
I am not sure why the build is failing and how to fix it. Can you please help?


Reduce bundle size

My bundled file grew by ~5 Mb once I added the provider engine as a dependency. That's unminified, but still once I minify it it's roughly 4 Mb. That's way too big for a browser app -- for mobile anyway.
I think there are some dependencies we can remove. Here are some quick suggestions:

async - nicety, but we don't need the whole library for the little we use it.
ethereumjs-utils - it's used for minor hex stripping and conversion to buffers. We can get buy without it for most cases.

Will look for more.

Would this be included in every web app, or would this mostly be powering the browser extension?On Jan 28, 2016, at 4:14 PM, Tim Coulter<EMAIL_ADDRESS>wrote:My bundled file grew by ~5 Mb once I added the provider engine as a dependency. That's unminified, but still once I minify it it's still ~4 Mb. That's way too much for a browser app (at least, for mobile anyway). I think there are some dependencies we can remove. Here's some quick suggestions, though I need to look into it more:
async - nicety, but we don't need the whole library for the little we use it.
ethereumjs-utils - it's used for minor hex stripping and conversion to buffers. We can get buy without it for most cases.
Will look for more.—Reply to this email directly or view it on GitHub.

I'm not sure how this works wrt the browser extension. @kumavis would have to weigh in.

Would this be included in every web app, or would this mostly be powering the browser extension?
potentially both. it goes in the browser extension (which zipped is less than 2mb) but also optionally into the dapp so they can fallback without mist/metamask

regarding managing bundle size:

make sure you're measuring the size with js sourcemaps off, i've experienced them doing 6x size increases!
disc is a great tool for tracking down what modules are actually large in your dep graph -- I would do this before taking out modules on whim

did some tests. bundle source:
require('web3-provider-engine/example.js')

This example includes light-wallet, vm, the whole shebang.
here is some data im seeing on the bundle:
3.9M bundle.browserify.js
2.0M bundle.browserify.min.js

3.6M bundle.webpack.js
1.5M bundle.webpack.min.js

note that while the source is tested in node, these builds are untested. webpack may not be including some node/browserify globals like Buffer. I am not familiar with its behavior.
Here's disc's output (its interactive)

At first glance a couple of the offenders:

bitcore-lib (lightwallet)
lodash (lightwallet > bitcore-lib)
ethereum-common (ethereumjs-tx, ethereumjs-block, etc)

theres also a variety of crypto and bignumber libs that could potentially be reduced

Actually tried disc on the minified source and it paints a slightly different picture:

ethereum-common is incompressible (and totally unneeded here)
ping @wanderer

Here is an unminified bundle w/o lightwallet

primary offenders are:

ethereum-common
es6-shim x2 (ethereumjs-block, ethereumjs-vm)
elliptic x2 (ethereumjs-account+ethereumjs-tx, browser-crypto)
bn.js x2 (browser-crypto)
bluebird (ethereumjs-tx > secp256k1)

in summary:

lightwallet is a big player here and can be improved
ethereumjs is bringing along ethereum-common and possibly browser-crypto, the shim for require('crypto')

additionally note that provider-engine is essentially an entire ethereum client, not some helper lib, so its going to be a bit chunky.

https://github.com/cryptocoinjs/secp256k1-node/pull/57 Will get rid of bluebird

i'm not sure how to deal with ethereum-common though. Its just pure json files.

elliptic x2 (ethereumjs-account+ethereumjs-tx, browser-crypto)

This should be solved with the upcoming releases. All crypto is in ethereumjs-util (which depends on secp256k1).

awesome

@kumavis @wanderer we could also split out the crypto functions into ethereumjs-crypto and thus leave ethereum-utils much smaller (no secp256k1 dep)

@axic I like this idea

Added a change to ethereumjs-common (https://github.com/ethereumjs/common/commit/3d79d3b2c038054e567a1614685e2011949ff891) so hopefully ethereumjs-tx will be updated soon, removing the genesis data from it.

thanks @axic!

That change is out there with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>No need to update provider-engine given semver does the job.
My build is only 1.5MB which includes React, provider-engine, web3, ethereumjs-wallet, ethereumjs-tx and all the deps of these. I think that is a fair bundle size.

:clap:
On Mar 6, 2016 12:21 PM, "Alex Beregszaszi"<EMAIL_ADDRESS>wrote:

That change is out there with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>No
need to update provider-engine given semver does the job.
My build is only 1.5MB which includes React, provider-engine, web3,
ethereumjs-wallet, ethereumjs-tx and all the deps of these. I think that is
a fair bundle size.
—
Reply to this email directly or view it on GitHub
https://github.com/MetaMask/provider-engine/issues/20#issuecomment-192981554
.


[DCOS-46515] Bump sdk version

What changes were proposed in this pull request?
Bumped SDK version to 0.54.3

Closing this PR as this was created by mistake.


⚠ Bofrost.at has degraded performance

In 89998be, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1265 ms

Resolved: Bofrost.at performance has improved in 1e9c6e2 after 21 minutes.


TypeError when using w_retrain mode on resnet18 cifar10

Hi there! I am trying to use the worst case unlearn set generator with the retrain mode but getting the following error trace:
Traceback (most recent call last):
  File "/home/ppol/Unlearn-WorstCase/data-wise/main_selmu.py", line 216, in <module>
    main()
  File "/home/ppol/Unlearn-WorstCase/data-wise/main_selmu.py", line 121, in main
    unlearn_method(train_full_loader, model, criterion, args, w, mask)
  File "/home/ppol/Unlearn-WorstCase/data-wise/unlearn/impl.py", line 313, in _wrapped
    train_acc = unlearn_iter_func(
TypeError: w_retrain() takes 7 positional arguments but 8 were given

Command to reproduce the error:
python main_selmu.py --arch resnet18 --dataset cifar10 --cp_path results/cifar10/0model_SA_best.pth.tar --num_indexes_to_replace 4500 --unlearn w_retrain --unlearn_steps 182 --save_dir results/cifar10

Am I specifying the launching command wrong? I tried to follow the data-wise link
In the future I would like to use other unlearning methods besides w_retrain. An example command for each one as in the paper or a config file would have been very helpful.
For reference the resnet checkpoint was obtained with the following command:
python main_train.py --dataset cifar10 --save_dir "results/cifar10"

Thank you for your appreciation and recognition of our work. In our approach, we use Fine Tuning (FT) with SignSGD to solve the lower level. Of course, you can use other methods as well. We have updated the code to support solving the lower level with Retrain.
If you would like to use another method, such as Random Label (RL), for solving, you can modify --unlearned to w_RL. The specific command is as follows:
python main_selmu.py --arch resnet18 --dataset cifar10 --cp_path results/cifar10/0model_SA_best.pth.tar --num_indexes_to_replace 4500 --unlearn w_RL --unlearn_steps 10 --save_dir results/cifar10

If you have any other questions, please feel free to contact us!

The issue has been closed. If you have any further questions, please feel free to contact us.


Fix: view resources button does not fix to bottom of card

Fixes : #104
@rishipurwar1 Kindly please review the PR

Please make this pr to development branch not main branch

Please make this pr to development branch not main branch

I will be making a PR in the development branch shortly, meanwhile I am closing this PR @rishipurwar1


[Communication - Identity] CommunicationIdentityClient [Playback/Live] [AAD] successfully creates a user and gets a token in a single request failing in nightly runs

Communication - Identity nightly test runs are failing with:

Error message:
expected undefined to be a string
Stack trace:
AssertionError: expected undefined to be a string
at Context. (D:\a_work\1\s\sdk\communication\communication-identity\test\public\communicationIdentityClient.spec.ts:65:14)
at processTicksAndRejections (node:internal/process/task_queues:96:5)

For more details check here:

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1136380&view=results

@petrsvihlik this and #18181 - I took a quick look and seems like the latest manually triggered build succeeded, so it might be that this is fixed. But the failures didn't seem flaky - mind taking a look (or assigning to someone from your team?)

@maorleger I will take a look. thanks!


Added additional predefined easing options to Easings.js

Mapped the first 24 predefined Easing curves on http://easings.net/ for quick use. There are 6 more easing curves on that website, however they don't supply a bezier curve for them so we should probably leave those up to developers. Usually I would wrap all these in an object called easingTypes or something and set them to be const however bases on how the first one was set I decided to follow the standard. Let me know if I should wrap/export these cleaner. Also I would like to update the Animated docs page with this information, would you like me to do that in this PR? Or is that something that you guys usually handle.
The reason why I am doing this is to

Learn the open contribution process through something simple and easy to review.
Further enhance the core Animated library. When I started using it I found it difficult to figure out how and where to find Easing curves. After going through the code I realized that there was only one easing curve while the competing react-native animated library, react-tween-state, has a more encompassing predefined Easing library.

Looking forward to working with the react native community,
Cheers!

By analyzing the blame information on this pull request, we identified @gre and @trave7er to be potential reviewers.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

At this time, I don't think this is something we want to add to the core Animated library. It might be cool to provide this as a 3rd party add-on so people can import external easing functions?


heisenbug?

Hmm, I don't quite see how the cache at this level could be causing the issue, unless you mean removing this will make it easier to troubleshoot? But it probably won't hurt, let's try it :)