fix duplicates app URL in the URL

fix duplicates app URL in the URL

if you are working with a subdirectory in Laravel you will see this issue. Please fix it in the next version.

possible duplicate of the following: https://github.com/inertiajs/inertia-laravel/pull/437, https://github.com/inertiajs/inertia-laravel/issues/421 and https://github.com/inertiajs/inertia-laravel/pull/422

Sorry, I'm not sure we would merge a commented piece of code that says "old, incorrect code". Why was it there in the first place? What purpose did it serve?

Sorry, I'm not sure we would merge a commented piece of code that says "old, incorrect code". Why was it there in the first place? What purpose did it serve?

My brother it doesn't take a genius to figure this out, give or take 60 seconds of searching maximum and you would see it's there because you guys committed some busted https://github.com/inertiajs/inertia-laravel/pull/347 that yall have yet to fix.

Sorry, I'm not sure we would merge a commented piece of code that says "old, incorrect code". Why was it there in the first place? What purpose did it serve?

My brother, it doesn't take a genius to figure this out. Give or take 60 seconds of searching maximum and you would see it's there because you guys committed some busted code at https://github.com/inertiajs/inertia-laravel/pull/347 that yall have yet to fix.

It wasn't introduced in that PR; if you looked a bit closer, it was introduced as part of https://github.com/inertiajs/inertia-laravel/pull/333
In either case, despite being inactive / non-involved with Inertia for quite some time now and therefore reluctant to merge PRs at all, I honestly wouldn't just merge any PR like this in either case. You state something is broken, and I've seen the other reports and PRs on it just now, but the reality is that for over 99% of users it works just fine.
If you or whomever really needs a fix for this, please do show us a failing test instead of just having a PR with a fix. Something that beyond reasonable doubt displays that this is an issue with the adapter, and not just a misconfigured Nginx/webserver configuration, because regardless of whether we merge this or not, someone else's going to come along tomorrow with a different bug, that line's going to change again, and we'll be right back where we started.
It's easy to fix and merge something reproducible, but if as a maintainer you're not experiencing the issue and the reproduction is difficult or requires an unknown amount of active time investment to even just reproduce, the reality is that it's just not even going to get a lot of attention unless it either affects a significant amount of users frequently, or unless the maintainer has found enough time to try and resolve these kinds of difficult minor issues.

Sorry, I'm not sure we would merge a commented piece of code that says "old, incorrect code". Why was it there in the first place? What purpose did it serve?

My brother, it doesn't take a genius to figure this out. Give or take 60 seconds of searching maximum and you would see it's there because you guys committed some busted code at #347 that yall have yet to fix.

It wasn't introduced in that PR; if you looked a bit closer, it was introduced as part of #333
In either case, despite being inactive / non-involved with Inertia for quite some time now and therefore reluctant to merge PRs at all, I honestly wouldn't just merge any PR like this in either case. You state something is broken, and I've seen some other identical reports and PRs on it just now, but the reality is that for over 99% of users it works just fine.
If you or whomever really needs a fix for this, please do show us a failing test instead of just having a PR with a fix. Something that beyond reasonable doubt displays that this is an issue with the adapter, and not just a misconfigured Nginx/webserver configuration, because regardless of whether we merge this or not, someone else's going to come along tomorrow with a different bug, that line's going to change again, and we'll be right back where we started.
It's easy to fix and merge something reproducible, but if as a maintainer you're not experiencing the issue and the reproduction is difficult or requires an unknown amount of active time investment to even just reproduce, the reality is that it's just not even going to get a lot of attention unless it either affects a significant amount of users frequently, or unless the maintainer has found enough time to try and resolve these kinds of difficult minor issues.

Yes, I am well aware you all do not typically use IIS as your web server when developing Inertia apps because if you did you too would know this issue is not because of a misconfigured IIS web server and per the other half dozen issues that have been submitted regarding this exact bit of code, it's fairly clear that this isn't an isolated incident or a configuration mistake.
The issue at hand directly impacts those of us using IIS as our web server, which, while may not be the majority, still constitutes a significant portion of your user base deserving of support. I understand the constraints you face as maintainers, but I encourage you to consider the inclusivity of your support for various environments.
And yeah sure to assist in this, I am ready to put in the work necessary to provide detailed logs, configurations, and even a minimal reproducible example that showcases how this bug specifically affects those of us using IIS as our web server.
However, I'd like to point out that among the half dozen issues already submitted on this matter, there already exists a wealth of information that highlights the exact nature of this problem. These submissions include error logs, configuration details, and some even have steps to reproduce the issue, all of which could easily serve as your starting point for a deeper investigation without any additional information from me or anyone else for that matter.

Yes, I am well aware you all do not typically use IIS as your web server when developing Inertia apps because if you did you too would know this issue is not because of a misconfigured IIS web server and per the other half dozen issues that have been submitted regarding this exact bit of code, it's fairly clear that this isn't an isolated incident or a configuration mistake.

This is the first mention I see of IIS being the issue. There's not a single issue/PR that mentions IIS. The only comment about IIS is this one; https://github.com/inertiajs/inertia-laravel/issues/359#issuecomment-1146374973 and it only speaks about having tried multiple servers
Thing is, yes, there are many issues being reported, but it's difficult to replicate, as many don't include basic steps to replicate the issue (things such as nginx config that's used, or a reverse proxy being used). That would also need to be replicated in tests, to make sure it doesn't break existing applications that just run fine.
Also, if it's such a big issue, it's possible to rebind the ResponseFactory, overwrite the render method and implement your own response. If that solves it for a small group of people, that might be a good approach too, as hosting an app in a sub-directory is a rather specific use-case. Inertia might just choose to not support that.

Yes, I am well aware you all do not typically use IIS as your web server when developing Inertia apps because if you did you too would know this issue is not because of a misconfigured IIS web server and per the other half dozen issues that have been submitted regarding this exact bit of code, it's fairly clear that this isn't an isolated incident or a configuration mistake.

This is the first mention I see of IIS being the issue. There's not a single issue/PR that mentions IIS. The only comment about IIS is this one; #359 (comment) and it only speaks about having tried multiple servers
Thing is, yes, there are many issues being reported, but it's difficult to replicate, as many don't include basic steps to replicate the issue (things such as nginx config that's used, or a reverse proxy being used). That would also need to be replicated in tests, to make sure it doesn't break existing applications that just run fine.
Also, if it's such a big issue, it's possible to rebind the ResponseFactory, overwrite the render method and implement your own response. If that solves it for a small group of people, that might be a good approach too, as hosting an app in a sub-directory is a rather specific/niche use-case. Inertia might just choose to not support that.

I find it surprising that there's a perception of IIS issues being a novel topic when several discussions, albeit not labeled explicitly under IIS, describe symptoms unique to it. The assertion that there's scant mention of IIS is at odds with the reality that users have been flagging related problems, for nearly two years, complete with configurations and potential fixes, only to be met with silence.
It's concerning that the response to a known issue is to suggest a workaround that requires users to delve into framework internals. This isn't just about IIS or hosting in sub-directories; it's about acknowledging and addressing user-reported issues rather than suggesting band-aid solutions that sidestep the root problem.
If thorough issue reports are what's needed, ask for them. Many of us are ready to provide detailed logs, steps to reproduce, and configurations, some have already even done that. Ignoring these offers and leaving issues unaddressed for two years isn't a solution. My vote would be for the maintainers to take a more proactive approach to tackle this, rather than relegating it to the 'too hard to figure out' basket.

Thanks for the PR, and I'm sorry for the delay! Unfortunately, this PR would have re-introduced the bug that #333 was trying to fix, so I've merged #592 which should address both use cases.


Possibility to add filter column

It is not possible to add the filter column to the crud inside the MasterCrud.

It's possible for a CRUD: https://github.com/atk4/ui/pull/448, so just need to add option into MasterCRUD to use this feature.


Use Image ID Instead of Image Name

I have an issue where I installed Business Central Image using New-Navcontainerhelper, I saved the image as a .tar file and loaded it as an image on another machine. The image name is the same as the package for Business Central Sandbox on Docker.
New-NavContainer -containerName MSDYNBC -accept_eula -alwaysPull -assignPremiumPlan -auth NavUserPassword -doNotExportObjectsToText -enableSymbolLoading -imageName microsoft/bcsandbox:us -includeCSide -memoryLimit 3G -shortcuts Desktop -updateHosts
The issue is that even if I rename my image to something else, and remove -alwaysPull command:
New-NavContainer -containerName MSDYNBC -accept_eula -alwaysPull -assignPremiumPlan -auth NavUserPassword -doNotExportObjectsToText -enableSymbolLoading -imageName testImage -includeCSide -memoryLimit 3G -shortcuts Desktop -updateHosts
This still goes and looks for the microsoft/bcsandbox:us and proceeds to download the entire thing off the internet. Which Is why I am suggested if we could use Image ID instead.

I haven't used docker save before.
What are you trying to achieve here?

I am trying to reuse the Image(Download it once only). So I setup BC using the command above in one machine. I use docker image save to save the image in a tar file, and then I use docker load to load the image on another machine. I would like then, to use the same command as above to setup BC on that machine. However, instead of using the loaded image, it attempts to pull the image again from the internet. I have even renamed the image name and tags, but somehow it still attempts too pull from the docker package online.
The only solution I can think of is to have support for Image ID in New-NavContainer

New-NavContainer should be able to do this.
Could you paste the output from new-navcontainer here?

The mechanism used to determine whether it should force download the imagename is here:
    # Determine best container ImageName (append -ltsc2016 or -ltsc2019)
    $bestImageName = Get-BestNavContainerImageName -imageName $imageName

    if ($useBestContainerOS) {
        $imageName = $bestImageName
    }

    $imageExists = $false
    $bestImageExists = $false
    docker images -q --no-trunc | ForEach-Object {
        $inspect = docker inspect $_ | ConvertFrom-Json
        if ($inspect | % { $_.RepoTags | Where-Object { "$_" -eq "$imageName" -or "$_" -eq "${imageName}:latest"} } ) { $imageExists = $true }
        if ($inspect | % { $_.RepoTags | Where-Object { "$_" -eq "$bestImageName" } } ) { $bestImageExists = $true }
    }

    if (!($alwaysPull)) {
        if ($bestImageExists) {
            $imageName = $bestImageName
        } elseif ($imageExists) {
            Write-Host "NOTE: Add -alwaysPull or -useBestContainerOS if you want to use $bestImageName instead of $imageName."
        } else {
            $alwaysPull = $true
        }
    }

It works now. All I had to do was remove --alwaysPull from my command.
Thanks for your help Freddy.


[Feature/Question] Support for listeners

Hi :)
I was playing around with this neat module (good job btw) and I was thinking that it was lacking of support on event listeners.
Basically my queues are defined on one server and processed on another server (producer/consumer pattern), the producer needs to listen to some events, based on bull documentation, this is done by listening on global:* events.
But basically the principle would be the same with non-globals events aswell:
queue.on('global:active', doSomething);
queue.on('active', doSomethingElse);

I guess this kind of thing should be done when creating the queue, so I was thinking about something like this:
BullModule.forRootAsync({
    imports: [ModuleA, ConfigModule],
    inject: [ServiceA, ConfigService],
    name: '__TEST_QUEUE__',
    useFactory: async (serviceA: ServiceA, configService: ConfigService): Promise<BullModuleOptions> => ({
        name: '__TEST_QUEUE__',
        options: {
            redis: configService.get('redis'),
        },
        listeners: {
            'global:active': serviceA.onActive.bind(serviceA),
        },
    }),
}),

Or using a Map:
enum BullQueueEvent {
    GlobalWaiting = 'global:waiting',
    GlobalActive = 'global:active',
    GlobalCompleted = 'global:completed',
    Waiting = 'waiting',
    Active = 'active',
    Completed = 'completed',
    ....
}

type BullQueueEventListenerCallback = (...args: any[]) => void; // Could do a better typing here

BullModule.forRootAsync({
    imports: [ModuleA, ConfigModule],
    inject: [ServiceA, ConfigService],
    name: '__TEST_QUEUE__',
    useFactory: async (serviceA: ServiceA, configService: ConfigService): Promise<BullModuleOptions> => ({
        name: '__TEST_QUEUE__',
        options: {
            redis: configService.get('redis'),
        },
        listeners: new Map<BullQueueEvent, BullQueueEventListenerCallback>(
            [BullQueueEvent.GlobalWaiting, serviceA.onGlobalWaitingEvent.bind(serviceA)],
            [BullQueueEvent.GlobalActive, serviceA.onGlobalActiveEvent.bind(serviceA)],
            [BullQueueEvent.GlobalCompleted, serviceA.onGlobalCompletedEvent.bind(serviceA)],
            ....
        ),
    }),
}),

And the provider with an object literal:
// bull.provider.ts
function buildQueue(option: BullModuleOptions): Bull.Queue {
    const queue: Bull.Queue = new Bull(option.name ? option.name : 'default', option.options);
    if (option.listeners) {
        for (const event of Object.keys(option.listeners)) {
            queue.on(event, option.listeners[event]);
        }
    }
    ...
}

With a Map:
// bull.provider.ts
function buildQueue(option: BullModuleOptions): Bull.Queue {
    const queue: Bull.Queue = new Bull(option.name ? option.name : 'default', option.options);
    if (option.listeners) {
        option.listeners.forEach((cb: BullQueueEventListenerCallback, event: BullQueueEvent) => {
            queue.on(event, cb);
        });
    }
    ...
}

I tested it locally and it works fine, the only downside I found is that I have to bind context to the callback so I can keep using dependencies of my service(s), there might be something better to do.
I might by totally wrong by the way, if you guys have another way of handlings events, I'd be glad to discuss about it.
Dylan

Hi @DylanGauthier
I hope you're doing fine and are still interested in this feature. Do you think your issue will be covered by #53 ?

Hello @fwoelffel :)
I hope you're doing fine too. I definitely think #53 should cover this issue in a more elegant way. I have to say I didn't really think much about decorators there but the idea is waaaaaaaaaaaay better. Can't wait to see the implementation :)

Closed by #56


[BUG] Transformation changes are applicated to wrong GameObject

Describe the bug
After aplying changes to a transform of a GameObject using the Inspector, if you click to another Gameobject the changes are applied to it.
To Reproduce
Steps to reproduce the behavior:

Modify a GameObject transform using the inspector.
Click to another GamObject.
Profit

Expected behavior
Changes are not applied to the clicked game object

Fixed in #101


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 2.2.7 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


#778 autoreload facility for web server

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

[ ] I think the code is well written
[ ] Unit tests for the changes exist
[ ] Documentation reflects the changes

Guys, do you have any plans to work on the issue?
I really appreciate your help but if  you've decided to abandon the PR please let me know -- maybe somebody or I will pickup the work.

I would find this incredibly useful. Would be happy to try and help if no one is actively working on this.

We definitely going to finish this, give me two weeks, please.

cool!

close in favor of https://github.com/samuelcolvin/aiohttp-devtools


Group user guide pages by subject

Description
Split user guide documentation based on which part of Parsl they deal with: App definition, Config, Workflow. Also includes an "advanced" section for things that I couldn't figure out how to group and weren't specific enough to get their own header.

Divided into four sections, placing simple introductions where necessary
Did not reduce any contents. Only reshaping
Split long documents into multiple sections so they show up better on the table of contents

Changed Behaviour
N/A
Fixes
N/A
Type of change

Update to human readable text: Documentation/error messages/comments

renames of rsts turns into broken 404 on inbound hyperlinks/search results, I think. I don't know how much traffic goes into the docs but I would hope that at least search engines are sending people deep in.
A style for some deprecated stuff in the codebase has been labelling something as "this is deprecated. this warning will be removed in 6 months." - and maybe the equivalent here is put almost-empty RSTs that describe where the user's search result has been moved to, with a stated June 2025 removal date.

I also need to update links within the docs to those moved documents.n

I also need to update links within the docs to those moved documents.


[BUG] Unknown time zone Europe/Zurich

Unknown time zone Europe/Zurich

If you write down the plug-in version and the grafana version as shown in the form below, it will be faster to check.
Could you attach the grafana log as well?
**Describe the bug**
A clear and concise description of what the bug is.

**Grafana Version & Plugin Version**

**To Reproduce**
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Additional context**
Add any other context about the problem here.

When I look at the log, it appears that you are using window grafana.
When I tested it, it wasn't reproduced on Linux grafana, but it's reproduced on Window grafana.
I think this is a matter of how Golang handles timezone. (link1 link2)
I think it will take some time to resolve it.
I think you should run grafana through docker in the window or something else.

Issue modification pr has been merged.(#102)
It worked properly when I tested it on the window.
Available in the nextreleases.
The release schedule is likely to be mid-December.

Plugin Published.
close the issue.


MDDropdown menu call back not working

Description of the Bug
Call back function not working for me for any kivymd examples.
Tried all examples available in kivymd docs
Code and Logs
#Examples from https://kivymd.readthedocs.io/en/latest/components/menu/
Screenshots
Versions

OS: Windows 10
Python: 3.6.8
Kivy: 1.11.1
KivyMD: 0.104.1

I cannot reproduce the error. Also suggesting you to use the master version.
pip install https://github.com/kivymd/KivyMD/archive/master.zip

I did pip install https://github.com/kivymd/KivyMD/archive/master.zip, but no changes. I resolved issue by changing python version to 3.7

pip install https://github.com/kivymd/KivyMD/archive/master.zip doesn't made any change, I manually added kivyMD folder in venv folder  and it worked.


Migrate to jakarta package namespace ( and commons-email2 )

This PR fully migrates the project to jakarta package namespace .
It also introduces commons-email2 as asked by https://github.com/apache/commons-email/pull/80#issuecomment-1151018762
Please note I removed japicmp from the defaultGoal in absence of a better known solution. Otherwise, japicmp fails the build for breaking changes.

Codecov Report

Merging #133 (c60ea71) into master (d6e7164) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #133   +/-   ##
=========================================
  Coverage     65.90%   65.90%
  Complexity      305      305
=========================================
  Files            18       18
  Lines          1053     1053
  Branches        138      138
=========================================
  Hits            694      694
  Misses          280      280
  Partials         79       79

Impacted Files
Coverage Δ

.../org/apache/commons/mail2/ByteArrayDataSource.java
0.00% <ø> (ø)

...org/apache/commons/mail2/DefaultAuthenticator.java
100.00% <ø> (ø)

src/main/java/org/apache/commons/mail2/Email.java
76.99% <ø> (ø)

...java/org/apache/commons/mail2/EmailAttachment.java
100.00% <ø> (ø)

.../java/org/apache/commons/mail2/EmailException.java
30.00% <ø> (ø)

...main/java/org/apache/commons/mail2/EmailUtils.java
73.13% <ø> (ø)

.../main/java/org/apache/commons/mail2/HtmlEmail.java
49.03% <ø> (ø)

.../java/org/apache/commons/mail2/ImageHtmlEmail.java
82.50% <ø> (ø)

.../java/org/apache/commons/mail2/MultiPartEmail.java
53.17% <ø> (ø)

...ain/java/org/apache/commons/mail2/SimpleEmail.java
100.00% <ø> (ø)

... and 8 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

So are there any plans to merge this pull request or is this library going to stay on outdated Java EE forever?

@MaximeEsnol
So creating a major new release line is work we perform rarely and with deliberate intent, not as a knee jerk reaction. Since we are all volunteers, we must consider how to best use our time to support existing legacy users and the ones building on the latest environments. So it will happen eventually I am sure. When a new major release is planned is also the time when we can break binary compatibility, so this is when we reasses the public and protected elements of the component. I hope this helps you understand where we are coming from.

commons-email is a fairly small library, it could be possible to support both JEE namespaces with the same jar. New classes using the jakarta namespace would go into a different package, for example org.apache.commons.email.jakarta.

Are there any rough plans for timing on this?
Understand that this change must be very deliberate per @garydgregory, but with the forced migration to Spring Boot 3.0 later this year(based on 2.7 end of life) which has a Jakarta EE 9 baseline - it seems like applications will be forced off of this library.

which commons-email version support jakarta?

FTR, -1 on this PR. I propose we take the same approach as Apache Commons FileUpload (see that master branch).

+1 for this PR :)

+1 for this PR too. We need this as it's blocking us from upgrading to Jetty 11. How does this get progressed?

The next release will support Jakarta but not this way. See my previous comment. I should be able to work on this within a week or two.

@garydgregory Hey. Hope you are doing well. Will next release be available soon? :)

Hey! week or two already passed? Any news to support jakarta API?

Sorry Jan, we've moved our system to spring-mail quicker.
On Tue, Oct 10, 2023 at 3:41 PM Jan Cizmar @.***> wrote:

Hey! week or two already passed? Any news to support jakarta API?
—
Reply to this email directly, view it on GitHub
https://github.com/apache/commons-email/pull/133#issuecomment-1755584770,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGJRTFEHGSYCRWMVX5I2KDX6VNDPAVCNFSM6AAAAAAUCTMGGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJVGU4DINZXGA
.
You are receiving this because you commented.Message ID:
@.***>

Hey! week or two already passed! Any news to support jakarta API?

Hey! We're all volunteers with different priorities than yours ;-)

@garydgregory as i said 2 prs earlier, i'm happy to help. and this is still blocking me in a few projects to upgrade to spring 3.x :/ so is there any update? how can i help?

Hello @Loki-Afro,
This is my current plan:

Re-enable HtmlEmailTest, ImageHtmlEmailTest, MultiPartEmailTest, and port these to JUnit 5.
Create a release candidate for 1.6.0
Increase Commons Email to 2.0.0
Refactor the project to use Jakarta and Javax in the same style as Commons FileUpload 2.0.0-M1 (git master).
Release 2.0.0-M1
Monitor feedback

I need help with #1, please feel free to contribute a PR.

@garydgregory here you go https://github.com/apache/commons-email/pull/186

@garydgregory let me know if i can assist further, maybe with 4.?

I don't want to mix up the steps, especially if something goes wrong before 1.6, I don't want to deal with patching branches.

Hello,
Just to be sure to understand. Is version 1.6.0 compatible with Jakarta EE 9+ now ?
I have some doubt as when looking at the dependencies of https://mvnrepository.com/artifact/org.apache.commons/commons-email/1.6.0 it seems to have jakarta.mail:1.6.7 as a dependency but Jakarte EE 9+ requires at least jakarta.mail 2.0.

That confused me too. Despite its name, jakarta.mail 1.6.7 has javax.mail packages and not jakarta.mail.


undefined method `price' for #Stripe::SubscriptionItem:0x00007f883d67a328

What is the best way to handle these cases where the stripe API is updated and the schema changes?
     NoMethodError:
       undefined method `price' for #<Stripe::SubscriptionItem:0x00007f883d67a328>

As per the stripe documentation, the subscription item has the price information. But it seems the schema of the gem is using the version with plan instead. I understand that changing this directly will impact projects still on a previous stripe API version.

Any update when this will be merged into a release? As I can see, this is not part of release 3.1.0.rc3 yet?

@TastyPi Would you be able to cut a gem release with this fix? :pray:


[Show feed] Allow touch events to pass through to hero units.

lol, @neonichu

Yeah, looks good to me.

@alloy I should have never touched that Podfile.lock: https://github.com/artsy/eigen/commit/eda7c46d65deed84d9967fd114d4354dc8c8b7eb 😛


unit tests: to cleanly re-test need to delete endpoints

yeah, it doesn't test well on multiple tries.

should be fixed in that commit.


Fix ActionHeader icons display for small width

Before:

After:

What can we do to have this pull request reviewed and merged?


[rom] Configure the SRAM readback feature

Configure the SRAM readback feature as specified by OTP.
Supply default configurations with readback disabled.
Add tests to check the enabled case.

Addresses #23495.

CHANGE AUTHORIZED: hw/ip/otp_ctrl/data/otp_ctrl.hjson
CHANGE AUTHORIZED: hw/ip/otp_ctrl/data/otp_ctrl_mmap.hjson
CHANGE AUTHORIZED: hw/ip/otp_ctrl/rtl/otp_ctrl_part_pkg.sv
CHANGE AUTHORIZED: hw/ip/otp_ctrl/rtl/otp_ctrl_reg_pkg.sv
The changes above should not impact the RTL synthesis.

CHANGE AUTHORIZED: hw/ip/otp_ctrl/data/otp_ctrl.hjson
CHANGE AUTHORIZED: hw/ip/otp_ctrl/data/otp_ctrl_mmap.hjson
CHANGE AUTHORIZED: hw/ip/otp_ctrl/rtl/otp_ctrl_part_pkg.sv
CHANGE AUTHORIZED: hw/ip/otp_ctrl/rtl/otp_ctrl_reg_pkg.sv

Thanks @cfrantz for taking care of this so quickly. Should we apply the same setting also for the retention SRAM?


fix product name link for standalone

Signed-off-by: James Talton<EMAIL_ADDRESS>https://github.com/stolostron/backlog/issues/19946

/retest


feat: add parameters for restart suppression in crosswalk

Description
launch PR for https://github.com/autowarefoundation/autoware.universe/pull/8817

Tests performed
See https://github.com/autowarefoundation/autoware.universe/pull/8817
Effects on system behavior
See https://github.com/autowarefoundation/autoware.universe/pull/8817
Interface changes

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@yuki-takagi-66
Please approve this PR as well.

@kosuke55
Please approve the PR.


Pg certificate renewal

Description
Need to fix buildkite issue that is coming when we push the renewal changes in the PR. So need to fix it.

Pr: https://github.com/chef/automate/pull/6494

I tried to pin versionof upstream package to core/postgresql11/11.2/20200403150941 and core/postgresql11/11.2/20190311152155 , but build is failing .


Camera Screen parameters

Camera shouldn't contain screen Width and Height parameters.
Only Aspect ratio applicable to Camera this values should be set in case of any screen resize.

Also project and un project can be used without viewport parameters but in this case input position should be: value / screen_size


add generic get to GraphQLResponse

currently only get with String is supported:
    public String get(String path) {
        return context.read(path);
    }

could be there also generic
    public <T> T get(String path, Class<T> type) {
        return context.read(path, type);
    }

?

Added it for the next release. You can grab the context from it directly in the meantime using context(). Was thinking of perhaps adding some primitive convenience getters as well, such as getInt(String path), getBoolean(String path), etc.


Updated index.rst to fix overflow

The EC2 endpoint status was overflowing and creating a scroll bar on my screen. It was bugging me so I fixed it via the GitHub web interface. Will test to ensure it builds correctly when I get home from work, but it does render correctly on GitHub's preview.

Coverage decreased (-0.1%) to 92.136% when pulling 1267e201c53039146955a3df0085d520f5f1d063 on RobRoseKnows:patch-1 into bb6da93891482ddcb87c23e6abddc0e451f72d30 on spulec:master.

Thanks for this. Do you think we should update all of the services?

Not sure what you mean, were there others that were overflowing or are the docs as a whole out of date?


[Bug]: Errors while trying to build/Make the tsql extension

Contact Details
<EMAIL_ADDRESS>What happened?
While attempting to build Babelfish from source on a Ubuntu 18.04 box, I got the following errors while trying to  make the babelfishpg_tsql extension:
Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/^<.*>{ <-- HERE $/ at src/backend_parser/include.pl line 147.
Makefile:182: recipe for target 'src/backend_parser/gram-backend.y' failed
make: *** [src/backend_parser/gram-backend.y] Error 255
make: *** Deleting file 'src/backend_parser/gram-backend.y'

Version
BABEL_1_X_DEV (Default)
Extension
babelfishpg_tsql (Default)
What flavour of Linux are you running into the bug?
Ubuntu (Default)
Relevant log output
'/usr/bin/perl' src/backend_parser/include.pl src/backend_parser gram.y < /babelfish/postgresql_modified_for_babelfish/src/backend/parser/gram.y > src/backend_parser/gram-backend.y
Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/^<.*>{ <-- HERE $/ at src/backend_parser/include.pl line 147.
Makefile:182: recipe for target 'src/backend_parser/gram-backend.y' failed
make: *** [src/backend_parser/gram-backend.y] Error 255
make: *** Deleting file 'src/backend_parser/gram-backend.y'

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I just noticed that this is a duplicate of #23


Fixing issue with bait resetting during mooch catch

This should fix #363. Tested with Hedgemole Cricket and it recorded catches after the change, when it was erroring before. The issue ended up being that it was setting this.fishing to false when the bite happened, and when the fish was actually retrieved. The OnPlayerChange event (which includes bait updates) is set to only change the bait when not currently fishing. Apparently in that time while the reel animation plays, the bait given in memory is some kind of invalid data, and the overlay was respecting that. Now, the bait is locked in, by keeping this.fishing = true, until the catch is complete (in handleCatch and handleNoCatch), which more closely reflects the actual relationship between bait and catch.

Thank you!!


Automated cherry pick of #5456: Fix burst of PacketInQueue
#5460: Increase Rate-limit config

Cherry pick of #5456 #5460 on release-1.13.
#5456: Fix burst of PacketInQueue
#5460: Increase Rate-limit config
For details on the cherry pick process, see the cherry pick requests page.

/skip-all


Missing license

Thank you for developing this!
Two questions:

This project seems to be missing a license - which license is this made available under?

Was this client developed using the source of an existing Oracle library? (I'm mostly curious since its rare to find a client that doesn't rely on Oracle's SDK)

the license is open you can you can use the client as you need in any project without limitation
you can also modify the cod.
my primary goal for this project is solving the problem of oracle with go when I start to write a go code
using oracle I find many driver that use C code but difficult to install this drive me to start the project
the project depends mostly on network analysis, plus reverse engineering of an existing client  (especially for
authentication step)


Fixes issue 908

IMPORTANT: By submitting a patch, you agree that your work will be licensed under the license used by the project.
If your pull request does not pass CI, it will not be merged (unless heavily justified).
Description
Updated the grammar regex definition of a number to include negative numbers as well.
Tests
Added testbed test that compiles a class with a negative number guard and tests that it functions.
StateMachineWithNegativeNumberGaurd
Added two tests to StateMachineTest.java that tests two umple classes that have negative numerical guards in them.
StateMachineWithNegativeNumberGaurd
StateMachineWithNegativeNumberGaurd2
If closing issues, please write Closes #908, to automatically close the equivalent issue.
Note: This template is a guide, remove sections as applicable.

This fixes issue #908


CMS Cache

Adds

New tables for CMS cache
Task to sync CMS items
Adapter for CMS cache
Swap out all non-sync calls to Directus with calls to CMS Cache

Very curious to hear more about this. Are you solving a performance problem here or is this just to make things generally faster? In either case I'd love to see performance comparisons (Simon used ab on the command line for SPIN but also pointed out https://github.com/alexfernandez/loadtest).
Cache performance wins are definitely exciting but they also make me super nervous because cache-related bugs are the worst. Just want to make sure we need this.

Very curious to hear more about this. Are you solving a performance problem here or is this just to make things generally faster? In either case I'd love to see performance comparisons (Simon used ab on the command line for SPIN but also pointed out https://github.com/alexfernandez/loadtest).
Cache performance wins are definitely exciting but they also make me super nervous because cache-related bugs are the worst. Just want to make sure we need this.

This is a critical change to support scaling the app past a few instances.  Without this change you need to scale the CMS at the same rate as the API.
We weren't able to get to performance testing with the original client this was written for, but I would expect a significant performance gain.  Above and beyond the scaling updates, it removes a number of N+1 round trips to the CMS, and in general removes a lot of overhead of an additional network round trip.
As for reliability on the cache it is a real time update of data.  The application leverages web hooks from Directus, and if anything fails it will alert on error.

@afraser
In essence this moves the Directus DB information over to the main Algomart DB, and removes making calls to Directus in favor of doing queries against the Algomart DB.
The benefits being as Jon outlined


Setup Prisma for Database Management

This pull request adds the necessary configuration and models for integrating Prisma into our project for improved database management. The changes include:

Set up Prisma ORM for database interactions
Define models for users, clubs, events, attendance, departments, roles, and more other relevant entities
Configure database connection settings
Update API endpoints and controllers to use Prisma for database operations

These changes lay the foundation for future database-related features and optimizations. The implementation follows best practices and aligns with our project's architecture.

Pull requests should only be merged into the development branch, not directly into main.


CSS background images not showing

Hello,
I have an issue. When I scan a website with CSS background images they do not appear on screenshot. The HTML image tag works fine.
I enabled the verbose option, but there is no other message besides "✔ Generated 1 screenshot from 1 url and 1 size".

Try the latest version: https://github.com/sindresorhus/pageres/releases/tag/v7.0.0 It may have resolved the issue.
If not, I need an example website that reproduces the issue.


i18n(pt-BR): update tutorial/0-introduction/1.mdx file

Description (required)
update i18n/pt-br/tutorial/0-introduction/1.mdx file

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

pt-br
tutorial/0-introduction/1.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


get option from FederationConfig instead of specified in command line

kubefed2 should configure itself with FederationConfig
Currently, limited-scope and registry-namespace can be get from FederationConfig
Fixes #748

@xunpan Should this be dependent on #771?

@marun, this is independent from #771.
Without #771, all items in FederationConfig is set by helm or example/config yaml file. So, limited-scope and registry-namespace should exist in FederationConfig.

Thank you!
/lgtm

/approve


generator.py syntax error

The following error occurs when running generator.py under (at least) Python 3.8.5:
Traceback (most recent call last):
  File "generator.py", line 27, in <module>
    def _getID() -> tuple[str, str, str, str]:
TypeError: 'type' object is not subscriptable

To fix it, I had to add
from typing import Tuple

and change the function definition to:
def _getID() -> Tuple[str, str, str, str]:

ok changed it in 9110435


Variogram Refactorization and Improvements

This PR refactors the variogram initialization routine. It also fixes some deficiencies in and optimizes the automatic variogram estimation routine.

A few other notes...
(1) In the __init__ method in each of the four main classes (OK/UK 2/3D), I changed the code to something like this:
self.X_ORIG = np.atleast_1d(np.squeeze(np.array(x, copy=True, dtype=np.float64)))

The change here is that the datatype will now be forced to be a float. Two questions... Do you think this is appropriate? I've seen problems from users before where they inadvertently fed in integers instead of real numbers and bad things happened. Kriging complex numbers is a curious question, certainly something that can expanded upon but probably not appropriate for the library as is. So, I was thinking forcing to float of some sort would be good. Also, is float64 ok, or would float32 (or something else) be better?
(2) I removed the leading underscore on some of the methods in core.py (e.g., _adjust_for_anisotropy -> adjust_for_anisotropy). As I understand the underscore, it denotes a protected member of a module/class that is only used within that module/class. Since we use adjust_for_anisotropy and initialize_variogram_model in multiple other modules/classes, seemed to me that it shouldn't be 'protected'. But I'm also not as familiar as others with the standard practices with Python... thoughts?

Hi @bsmurphy,

The change here is that the datatype will now be forced to be a float. Two questions... Do you think this is appropriate?

Well IMO ideally it would have been better to preserve the dtype (i.e. if the input is float32, or float64 keep it that way), and only cast to float if the dtype is integer.  But that's a minor thing (and possibly less trivial thing), and we can address that later..

Also, is float64 ok, or would float32 (or something else) be better?

+1 for using float64 by default

I removed the leading underscore on some of the methods in core.py (e.g., _adjust_for_anisotropy -> adjust_for_anisotropy). As I understand the underscore, it denotes a protected member of a module/class that is only used within that module/class.

I think this depends on the convention used. In my understanding, a leading underscore denotes not so much a protected function/but but a semi-private one (that is designed for internal use). In practice this means that such internal metods/functions are not expected to be called by the end user, and therefore have much less constraints on backward compatibility and can be changed without warnings (as opposed to public functions, without the leading _). So I would be more in favour on putting an _ on as much internal functions as possible, in order to keep a small public API as that makes refactoring and development simpler.
Will try to review this PR in detail in the next few days.

Thanks for the review, @rth and @basaks... You're right about the 80 char limit thing, I didn't realize that the inspection in my IDE was set to use 120 chars on a line, so I was missing that...

I have been thinking about the use_psil flag and it actually a bit complicated (works only in combination with provided variogram_parameters and only with a subset of the possible values). Couldn't we just get rid of use_psil input parameter, and provide it inside the variogram_parameters so everything is in one place?
For instance something along the lines of,
The following parameters can be provided
     linear - [slope, nugget]
     power - [scale, exponent, nugget]
     gaussian, sherical, exponential, hole-effect
          -  [sill, range, nugget] -> use_psil=True (backward compatible format)
          -  [sill, range, nugget, use_psil]
and if non provided, parameters using the partial psil will be computed.

What do you think?

I've been thinking about the psill thing more, and maybe it would make the most sense to use a dict instead of a list... that way the user could specify specifically 'psill' or 'sill', something like this:
variogram_parameters = {'sill': 10., 'range': 5., 'nugget': 1.}

or
variogram_parameters = {'psill': 10., 'range': 5., 'nugget': 1.}

For backwards compatibility, if the user gives a list instead, then we'll automatically interpret as the full sill. @rth's idea about including a flag in the list would work as well, I guess I'm just thinking that the dict approach is more explicit...

@bsmurphy Definitely, since each parameter have a meaning, passing a dict would be even better.

@rth, how do these adjustments to the core  module look? Got rid of the use_psill kwarg and went with a joint dict/list format for the variogram_parameter kwarg, which is parsed by core._make_variogram_parameter_list.

Everting looks good to me. I think it's much better with a dict.

Cool, I've updated the changelog now as well. If all looks good, I'll go ahead and merge/close. Next step is the statistics...

@bsmurphy Sounds great. (And thanks for fixing the typos :) )


phase encoding direction

Hello,
How is fmriprep determining phase encoding direction? On the html output reports, I am getting
"Summary: Phase-encoding (PE) direction: Anterior-Posterior"
However, I believe my data is Posterior->Anterior. My scanning parameters as generated by the Siemens scanner say P -> A, and my json sidecars to the functionals have “PhaseEncodingDirection”:“j” and “InPlanePhaseEncodingDirectionDICOM”:“COL”, which I also believe mean P -> A.
I believe fMRIprep uses phase encoding direction for distortion correction, and if the phase encoding direction is read incorrectly, the SDC might warp might warp in an unexpected way
This is sort of a cross-post from https://neurostars.org/t/phaseencodingdirection-misreported-in-fmriprep-html-output/3403
Thank you!!
Yoni

Hi. So it looks like currently we just report the axis in our summaries, not the direction:
https://github.com/poldracklab/fmriprep/blob/dd4201caddaae6107f14553f84c5357757629c65/fmriprep/interfaces/reports.py#L180
I think I wrote this so that I knew which axis to expect correction along when inspecting a lot of reports, and the polarity was not very important to my purposes. But I agree that it would be less confusing to users if we did make the order indicate the direction of the encoding. Would you be interested in submitting a small patch?

thanks @effigies !  So I think the patch might be as simple as:
pedir = {'i': 'Left-Right', 'i-': 'Right-Left', 'j-': 'Anterior-Posterior', 'j': Posterior-Anterior'}[self.inputs.pe_direction[0]]

Yes? I am not 100% confident in my understanding of phase encoding, but that is what i understand

Yup. That looks right.
Looking at this, it does assume that the original image was in RAS orientation, which might be why I didn't do that, as many images come LPS, as well. So we would need to account for the image orientation before settling on this.

Please reopen if the question is not fully answered and the new issue in SDCflows does not address the remaining issue of determining the actual PE direction when orientation is not RAS.

Hi! I have encountered the same issue. This time, regardless I set the PhaseEncodingDirection to j, or j- in my .json file (I had Philips data hence this information was not automatically generated by dcm2niix), when syn-sdc is turned on, I got the warning:"Incorrect phase-encoding direction, assuming PA (posterior-to-anterior)."
Let's say it did not take the PE direction I fed in at all, then shouldn't it assume AP, as in the document, but not the PA? Thank you in advance for your help!

Hi, I have a question that might be basic, but I can't find the answer anywhere. If I have an Axial scan, that goes from left to right, with RPI orientation, what would the corresponding phase encoding direction be? i, -i, j, -j, k, or -k?
How do these parameters map to the letters?
Thanks,
Angela

The three axes are indexed by i, j, k, and the axis codes indicate which direction you are moving by following an axis from its smallest index to its largest. RPI indicates that the i dimension increases from left to right, j from anterior to posterior, and k from superior to inferior. Therefore, if your phase-encoding direction is left-to-right, then the direction should be i. (i- would be from right to left in an RPI image.)
I would note that RPI is LAS reversed, so I would check to verify that you're describing it as I said above. It is not unheard of for people to use axis codes to refer to the side of the origin, rather than the direction of increase. In Python:
import nibabel as nb
img = nb.load(fname)
print(nb.affines.aff2axcodes(img.affine))


Requesting from phone number says "Send to Phone Number"

Current behavior
When requesting from a phone number it says "Send to Phone Number"

Desired behavior
It should say "Request from Phone Number"
Steps to Reproduce

Select Request
Enter a phone number that is not in your contact list

Versions
1.14.2

Hey @MuckT We have verified this issue using latest Test flight build V 1.19.0 and Android internal build V1.19.0 & updated status in Gsuite.
GSuite Link: https://docs.google.com/spreadsheets/d/1bWi6smdTMClreG96sGjYxb2lee9Ja6eT4-Lm7eXm1gM/edit#gid=0&range=L3
Verified On Devices: Samsung Galaxy J5 Prime (8.0), Samsung Galaxy M01 Core (10.0)
CC: @isabellewei

Hey @MuckT We have verified this issue using latest Test flight build V 1.19.0 and Android internal build V1.19.0 & updated status in Gsuite.
GSuite Link: https://docs.google.com/spreadsheets/d/1bWi6smdTMClreG96sGjYxb2lee9Ja6eT4-Lm7eXm1gM/edit#gid=0&range=L3
Verified On Devices: OnePlus 7t (11.0) , Iphone 6+ (12.5.4)
CC: @isabellewei

https://valora.testquality.com requirement R81.

Hey @MuckT We have verified this issue using latest Test flight build V 1.19.0 and Android internal build V1.19.0 & updated status in Test Quality Tool
Test Quality Tool link:
Android  (9.0):

https://valora.testquality.com/project/12128/plan/21816/run/150277/result/2485114

Verified On Devices: Redmi Note 8 (9.0)
CC: @lisaqyli


docs: Standardize the README

What:
Standardizes the README file providing a common language and an implementation link.
Why:
There are differences between PSR's READMEs in regarding language and the lacking of implementations references. So I've updated all READMEs using the https://github.com/php-fig/http-factory as base.

@dbu any other requests?

sorry. i was expecting other to react and as nobody did, it dropped from my radar... thanks for making these readme consistent over all PSR!


[WIP] Set up grunt tasks

refs TryGhost/Ghost#6909

moves client-related tasks from Ghost's Gruntfile.js into Ghost-Admin ready for removal or use via subgrunt in the parent repository.
adds tasks to ease install

TODO:

[x] grunt init

[x] install dependencies (npm & bower, if used outside of Ghost npm install would still need to be run first but it does give us a single point to hook into for extra setup)
[x] buildAboutPage (as this generates a file for use in the admin client it seems sensible to keep it here)

[x] grunt lint (#36)

[x] add to Travis build matrix

[ ] grunt dev (needed to run csscomb alongside ember server)

Closing this as the work has been completed in separate PRs. I've moved the remaining grunt dev task to the overall repo split issue - https://github.com/TryGhost/Ghost/issues/6977


Add with_column and with_column_renamed to DataFrame

I'm interested in this, please assign it to me :)

[ ] https://github.com/apache/arrow-datafusion-python/pull/10
[ ] Add with_column_renamed


Creating context blows out custom adds to .kube/config

What happened:

Added OIDC provider information directly to ~/.kube/config in
unrelated sections
Successfully use OIDC information to query OIDC provider and populate
token information under users section
Automatically add contexts for our clusters
Verify with kubectl get pods, etc.
(Work without problems for days)
Add a context with kubectl set-context ...
Notice kubectl-login now fails
Inspect ~/.kube/config and discover OIDC config is now gone

What you expected to happen:
I expect anything using ~/.kube/config to respect the existing data
that is in it and not blow it out (which applications like kind do
correctly by using the yaml:",inline" approach). Forcing separate
configuration files for other user configurations is problematic. Such
information should be safe in that file and applications should only use
what they require.
Anything else we need to know?:
Environment:
Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.4", GitCommit:"e6c093d87ea4cbb530a7b2ae91e54c0842d8308a", GitTreeState:"clean", BuildDate:"2022-02-16T12:38:05Z", GoVersion:"go1.17.7", Compiler:"gc", Platform:"linux/amd64"}
Minikube/Kind local setup.
NAME="Ubuntu"
VERSION="20.04.3 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.3 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

/assign

Add anything by hand to ~/.kube/config
kubectl set-context ... to add new context
Open ~/.kube/config and see your adds are now missing

Apologies but I'm not able to reproduce this as described. I've included the steps I've taken to attempt to reproduce this at the end of this comment. All values copied from kubernetes docs so they aren't real.
Couple questions:

While testing I noticed that it will remove invalid keys. So for example if I set something like

users:
- name: test-oidc-user
  users:
...

is set, it will remove the users key and all configurations under it and replace it with a null valued user key.
2. Just in case, make sure you're actually saving your manual changes to your kubeconfig. I have pretty much all my editors set to save constantly and always forget to save when I'm not using my computer.
If it is not either of these and you can provide me a more exact reproduction method I can work on tracking down the source of the problem.
Reproduction steps
Version (couldn't get brew to cooperate so I just checked out the specified commit and built it manually)
kubernetes on 🌱HEAD (e6c093d) [$] via 🐹 v1.18.1 on ☁  (us-west-2)
❯ ./_output/local/bin/darwin/amd64/kubectl version
Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.4", GitCommit:"e6c093d87ea4cbb530a7b2ae91e54c0842d8308a", GitTreeState:"clean", BuildDate:"2022-04-27T20:53:35Z", GoVersion:"go1.18.1", Compiler:"gc", Platform:"darwin/amd64"}

Starting config added manually:
apiVersion: v1
clusters:
- cluster:
    server: https://<IP_ADDRESS>
  name: fake-cluster
contexts: null
current-context: ""
kind: Config
preferences: {}
users:
- name: test-oidc-user
  user:
    auth-provider:
      config:
        client-id: kubernetes
        client-secret: 1db158f6-177d-4d9c-8a8b-d36869918ec5
        id-token: eyJraWQiOiJDTj1vaWRjaWRwLnRyZW1vbG8ubGFuLCBPVT1EZW1vLCBPPVRybWVvbG8gU2VjdXJpdHksIEw9QXJsaW5ndG9uLCBTVD1WaXJnaW5pYSwgQz1VUy1DTj1rdWJlLWNhLTEyMDIxNDc5MjEwMzYwNzMyMTUyIiwiYWxnIjoiUlMyNTYifQ.eyJpc3MiOiJodHRwczovL29pZGNpZHAudHJlbW9sby5sYW46ODQ0My9hdXRoL2lkcC9PaWRjSWRQIiwiYXVkIjoia3ViZXJuZXRlcyIsImV4cCI6MTQ4MzU0OTUxMSwianRpIjoiMm96US15TXdFcHV4WDlHZUhQdy1hZyIsImlhdCI6MTQ4MzU0OTQ1MSwibmJmIjoxNDgzNTQ5MzMxLCJzdWIiOiI0YWViMzdiYS1iNjQ1LTQ4ZmQtYWIzMC0xYTAxZWU0MWUyMTgifQ.w6p4J_6qQ1HzTG9nrEOrubxIMb9K5hzcMPxc9IxPx2K4xO9l-oFiUw93daH3m5pluP6K7eOE6txBuRVfEcpJSwlelsOsW8gb8VJcnzMS9EnZpeA0tW_p-mnkFc3VcfyXuhe5R3G7aa5d8uHv70yJ9Y3-UhjiN9EhpMdfPAoEB9fYKKkJRzF7utTTIPGrSaSU6d2pcpfYKaxIwePzEkT4DfcQthoZdy9ucNvvLoi1DIC-UocFD8HLs8LYKEqSxQvOcvnThbObJ9af71EwmuE21fO5KzMW20KtAeget1gnldOosPtz1G5EwvaQ401-RPQzPGMVBld0_zMCAwZttJ4knw
        idp-certificate-authority: /root/ca.pem
        idp-issuer-url: https://oidcidp.tremolo.lan:8443/auth/idp/OidcIdP
        refresh-token: q1bKLFOyUiosTfawzA93TzZIDzH2TNa2SMm0zEiPKTUwME6BkEo6Sql5yUWVBSWpKUGphaWpxSVAfekBOZbBhaEW+VlFUeVRGcluyVF5JT4+haZmPsluFoFu5XkpXk5BXq
      name: oidc

Command:
kubernetes on 🌱HEAD (e6c093d) [$] via 🐹 v1.18.1 on ☁  (us-west-2)
❯ ./_output/local/bin/darwin/amd64/kubectl config set-context test-fake-set-context1 --cluster=fake-cluster --user=developer --namespace=fake-ns
Context "test-fake-set-context1" created.

Resulting config:
apiVersion: v1
clusters:
- cluster:
    server: https://<IP_ADDRESS>
  name: fake-cluster
contexts:
- context:
    cluster: fake-cluster
    namespace: fake-ns
    user: developer
  name: test-fake-set-context1
current-context: ""
kind: Config
preferences: {}
users:
- name: test-oidc-user
  user:
    auth-provider:
      config:
        client-id: kubernetes
        client-secret: 1db158f6-177d-4d9c-8a8b-d36869918ec5
        id-token: eyJraWQiOiJDTj1vaWRjaWRwLnRyZW1vbG8ubGFuLCBPVT1EZW1vLCBPPVRybWVvbG8gU2VjdXJpdHksIEw9QXJsaW5ndG9uLCBTVD1WaXJnaW5pYSwgQz1VUy1DTj1rdWJlLWNhLTEyMDIxNDc5MjEwMzYwNzMyMTUyIiwiYWxnIjoiUlMyNTYifQ.eyJpc3MiOiJodHRwczovL29pZGNpZHAudHJlbW9sby5sYW46ODQ0My9hdXRoL2lkcC9PaWRjSWRQIiwiYXVkIjoia3ViZXJuZXRlcyIsImV4cCI6MTQ4MzU0OTUxMSwianRpIjoiMm96US15TXdFcHV4WDlHZUhQdy1hZyIsImlhdCI6MTQ4MzU0OTQ1MSwibmJmIjoxNDgzNTQ5MzMxLCJzdWIiOiI0YWViMzdiYS1iNjQ1LTQ4ZmQtYWIzMC0xYTAxZWU0MWUyMTgifQ.w6p4J_6qQ1HzTG9nrEOrubxIMb9K5hzcMPxc9IxPx2K4xO9l-oFiUw93daH3m5pluP6K7eOE6txBuRVfEcpJSwlelsOsW8gb8VJcnzMS9EnZpeA0tW_p-mnkFc3VcfyXuhe5R3G7aa5d8uHv70yJ9Y3-UhjiN9EhpMdfPAoEB9fYKKkJRzF7utTTIPGrSaSU6d2pcpfYKaxIwePzEkT4DfcQthoZdy9ucNvvLoi1DIC-UocFD8HLs8LYKEqSxQvOcvnThbObJ9af71EwmuE21fO5KzMW20KtAeget1gnldOosPtz1G5EwvaQ401-RPQzPGMVBld0_zMCAwZttJ4knw
        idp-certificate-authority: /root/ca.pem
        idp-issuer-url: https://oidcidp.tremolo.lan:8443/auth/idp/OidcIdP
        refresh-token: q1bKLFOyUiosTfawzA93TzZIDzH2TNa2SMm0zEiPKTUwME6BkEo6Sql5yUWVBSWpKUGphaWpxSVAfekBOZbBhaEW+VlFUeVRGcluyVF5JT4+haZmPsluFoFu5XkpXk5BXq
      name: oidc

It's definitely blowing away entries that it doesn't accept because of the way it is unmarshalling the data. I can show you the code that is doing it, later. Just making you aware. Several other professionals from different companies in my peer group have confirmed as well.

Ok apologies I didn't realize you meant like actually not "valid" kubeconfig keys, as in keys not defined in the client-go specification, initially. I'll confer with others regarding this. As far as I'm aware this is expected behavior and I don't think we would support keys that are not defined in the client-go Config specification, located here - https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/tools/clientcmd/api/v1/types.go

Yep, I've read all through that and the kind source code as well. That's how I knew what to play with, and where to use yaml:",inline" to gather up and maintain existing configurations (as kind does, while client-go does not). I just find it a bit heavy handed, but I accept it. Thank you for the help.

Oh also, I don't know if this is a thing with this plugin, but I think the preference would be to set any custom keys within the config of the auth-provider block under the user, or possibly in this case the name field, but I'd have to look closer at the plugin code itself to know for sure. I assume you don't have control over this plugin, but maybe could ask them to support that type of configuration so it didn't get clobbered by kubectl config commands.


Add Error Comments to PRs If Workflow Fails

In addition to printing an error message to the GitHub Actions workflow error logs, the workflow should also add a comment to the PR explaining why the workflow failed.

Issue solved in PR#11


Issue connecting to MS SQL Server running on non default port 1433

@mahesji commented on Fri Feb 09 2018
Issue Title
Issue connecting to MS SQL Server running on non default port 1433 from Linux environment
OS Version
Linux 4.4.0-109-generic #132~14.04.1-Ubuntu SMP Tue Jan 9 21:46:42 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
dotnet core project settings
<Project Sdk="Microsoft.NET.Sdk.Web">

  <PropertyGroup>
    <TargetFramework>netcoreapp2.0</TargetFramework>
    <RuntimeFrameworkVersion>2.0.5</RuntimeFrameworkVersion>
  </PropertyGroup>

  <ItemGroup>
    <Folder Include="wwwroot\" />
  </ItemGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.All" Version="2.0.5" />
    <PackageReference Include="System.Data.SqlClient" Version="4.4.2" />
  </ItemGroup>

  <ItemGroup>
    <DotNetCliToolReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Tools" Version="2.0.2" />
  </ItemGroup>

</Project>

General
Using System.Data.SqlClient to connect to Sql server database. Following the sample in this post https://blogs.msdn.microsoft.com/dotnet/2016/11/09/net-core-data-access/
It works fine if the sql server is listening on port 1433 but fails when connecting to sql servers listening on port 1434. Confirmed that there is no network / firewall issues that that is blocking the ports. Able to connect to the same sql server on port 1434 using java code.
This connection string works >
Server=myhostname,1433;Database=mydatabase;User Id=myuser;Password=mypassword;
This connection string does not work in above linux environment.  Works fine on windows
Server=myhostname,1434;Database=mydatabase;User Id=myuser;Password=mypassword;
Both connect strings work fine in Windows environment.
Record Fetch Error: A network-related or instance-specific error occurred while establishing a connection to SQL Server. The server was not found or was not accessible. Verify that the instance name is correct and that SQL Server is configured to allow remote connections. (provider: TCP Provider, error: 35 - An internal exception was caught)

@usergiga commented on Fri Feb 09 2018
If an instance of SQL Server is listening on any other port, than 1433. You have to specify a server-alias or change the standard port globally.
You can have SQL Server listening on multiple ports.

@mahesji commented on Mon Feb 12 2018
@usergiga , Thank you for the reply.  I have the alias created and that doesn't seem to help. The connection works fine in Windows runtime.  Have this issue only in the Linux (Ubuntu) runtime.

As recently announced in the .NET Blog, focus on new SqlClient features an improvements is moving to the new Microsoft.Data.SqlClient package. For this reason, we are moving this issue to the new repo at https://github.com/dotnet/SqlClient. We will still use https://github.com/dotnet/corefx to track issues on other providers like System.Data.Odbc and System.Data.OleDB, and general ADO.NET and .NET data access issues.

The problem is in documentation. The correct address string for connecting to a database at <IP_ADDRESS> port 666 is <IP_ADDRESS>,666, not <IP_ADDRESS>:666 like in every other program.

Can we support the <IP_ADDRESS>:666 syntax, like in every other program? :smile:
Over time the ecosystem can move away from the comma style.

Hi @Petermarcu @GSPP
Just wanted to get confirmation on current status of the issue, can you confirm if connection to custom port works fine with Microsoft.Data.SqlClient (latest version) when specified with comma (server, port) in connection string?
Supporting colon (:) can be treated as a separate request.
@arthurvaverko
Please test and confirm the same issue with Microsoft.Data.SqlClient (latest version) in your environment and open a new ticket if that occurs.

@mahesji opened this issue. I just moved it to this repo.

Looks like latest nuget package works fine.
Now we have some issues under load tests.
Seems like linux libs are handling connections less efficiently than windows.
We get tcp connection establishment timeouts after a certain load has been achieved.
The affect does not end with sql .. same issues starts with any other outbound network communications like rabbit mq and basic http requests...
Still investigating root cause.

Hi @arthurvaverko
Please share your details for any networking issues with dotnet/corefx team for further investigations.
We can investigate any SqlClient specific use-case, please provide a repro for the same in that case and create a new issue.
Closing this issue.


OAP 1.0 cannot use Plasma Backend in docker Env when Plasma server and executor in different containers

In OAP 1.0, Plasma Backend will use Simple Cache strategy when plasma-store-server is not running. So OAP 1.0 cannot use Plasma Backend in docker Env when Plasma server and executor in different containers.
def plasmaServerDetect(): Boolean = {     val command = "ps -ef" #| "grep plasma"     val plasmaServerStatus = command.!!     if (plasmaServerStatus.indexOf("plasma-store-server") == -1) {       logWarning("External cache strategy requires plasma-store-server launched, " +         "failed to detect plasma-store-server, will fallback to simpleCache.")       return false     }     true   }
@winningsix @jikunshang, would consider and implement this feature.
Thanks

cc @offthewall123

cc @offthewall123


Added new compiler option "noImportCycles".

When enabled, it checks for any cycles in the import graph. Such cycles are legal within TypeScript, but they are often indicative of architectural layering issues in a program, so it is desirable to eliminate them.

Fixes #

Every major module specification is explicitly designed around allowing circular imports; it's somewhat odd to disallow them as if they were an error condition.
You can use https://www.npmjs.com/package/tslint-no-circular-imports if your project has decided to enforce a directed module import graph.

@RyanCavanaugh We find that they essentially always indicate poor layering in the engineering design.  I'm curious what you would consider to be an encouraged example of using these circulars?

A circular dependency between two ES6 modules is really much closer to a forward reference than, say, a circular dependency between two .NET assemblies. No one seriously proposes disallowing writing forward references (especially for types), yet a rule for no circularity between ES6 modules is effectively saying the same thing.
For example, you can write this code (without really caring what order it's in):
export interface Algorithm {
  hash(content: string): string;
}
export enum AlgorithmKind { SHA, MD5 };
export function getAlgorithm(kind: AlgorithmKind): Algorithm {
  switch(kind) {
    case AlgorithmKind.MD5: return md5;
    case AlgorithmKind.SHA: return sha;
  }
}

const md5: Algorithm = {
  hash(c) { return "nyi"; }
}
const sha: Algorithm = {
  hash(c) { return "nyi"; }
}

If I decided that md5 and sha were getting too long to be in the same file, I could split them out:
hashes.ts
import { sha } from './sha';
import { md5 } from './md5';
export interface Algorithm {
  hash(content: string): string;
}
export enum AlgorithmKind { SHA, MD5 };
export function getAlgorithm(kind: AlgorithmKind): Algorithm {
  switch(kind) {
    case AlgorithmKind.MD5: return md5;
    case AlgorithmKind.SHA: return sha;
  }
}

md5.ts
import { Algorithm } from './hashes';
export const md5: Algorithm = {
  hash(c) { return "nyi"; }
}

sha.ts
// Same-ish as above

But now I have a circular dependency. Can you decompose it so the graph isn't circular? Sure, trivially.
Does it improve the code to move Algorithm into its own file to prevent a circularity? Opinions vary, but I like that the file setup above presents a cohesive logical grouping that I can read without having a dozen editor tabs open or tons of import directives to pull in things that could have been declared locally without loss of clarity.
A no-circularity rule makes this code either have files that are smaller than I want (by putting Algorithm in its own file), or bigger than I want (by moving md5 and sha into hashes.ts).

Or to draw an analogy to WinForms, no one seems particularly concerned that Control has a  FindForm() method returning a Form, and Form has an ActiveControl property of type Control. But if you wanted to write Control and Form as separate ES6 modules, they'd have to circularly reference each other to declare that structure.

Ah, okay, so we'll just have to agree to disagree then. :)
I would reject a PR with the above code, as someone else will inevitably come along down the line and mess with your md5.ts file there and make things progressively worse.  You'll end up with real circulars that are impossible to unravel when you need to refactor it down the line.  Ask me how I know...

I agree with David that there are real benefits to keeping your code modules strictly layered. I've seen too many cases in a wide variety of systems (from kernels to apps and everything in between) where cyclical dependencies lead to maintainability problems.
That said, TypeScript handles these cycles much more elegantly than other languages, so I can understand why not everyone might agree.
In any case, since there's a tslint plugin already available, it's unnecessary to build this check into the TypeScript compiler.

@RyanCavanaugh We've played around with the tslint plugin and it's completely unusably slow (we let it run for 16 hours on our codebase and it still didn't finish.)  We're currently using eric's code rebased on the latest master typescript codebase.  We'd like to not have to maintain this fork and enable this feature for other devs (we still believe this is how all typescript code should be written to maintain layering, but, as always, reasonable people can differ.)  Any chance it can be reconsidered for making it into the typescript compiler properly?  It adds no measurable execution time to our compilation and gives us this huge advantage, so we'll be using it forever inside our codebase one way or another, we just hate maintaining permanent forks of open source code. :)

You can always write a custom tslint rule. we have a few in our code base, and good group in dtslint.

We considered writing a custom tslint rule. The problem is that this particular case requires global analysis across the entire program, but tslint rules run on individual files.

tslint allows you to run on a whole program, and does not need to run on a single file at a time (see more at https://palantir.github.io/tslint/usage/type-checking/). you will need to run it using the --project option instead (https://palantir.github.io/tslint/usage/cli/).
Here's a simple typed rule https://github.com/palantir/tslint/blob/master/src/rules/restrictPlusOperandsRule.ts
// cc @andy-ms and @ajafff for tslint questions


Update README.md

Updates readme to reflect the fact that the sample uses MediaPlayerElement and not MediaElement.

Pulled into staging branch.


[url_launcher] Move away from shared method channel implementation in native packages.

This PR eliminates the use of the shared method channel implementation in each of the native packages for the url_launcher plugin.
The changes to each native package are pretty much identical to each other. Only interface implementations and tests irrelevant to the respective platform have been removed.
This PR's contents are based on the steps outlined in the following issue:

flutter/flutter#94224

Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [relevant style guides] and ran [the auto-formatter]. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the [CLA].
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
[x] I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is [test-exempt].
[x] All existing and new tests are passing.

I think this change has broken the integration test of the core plugin for linux and macos (see this). The error for both is:
MissingPluginException(No implementation found for method canLaunch on channel
flutter: plugins.flutter.io/url_launcher)
Stack traces:
MacOS
Running command: "flutter drive -d macos --driver test_driver/integration_test.dart --target integration_test/url_launcher_test.dart" in /private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/packages/url_launcher/url_launcher/example
Running "flutter pub get" in example...                          2,141ms
Running pod install...                                           1,059ms
Building macOS application...
flutter: 00:00 +0: canLaunch
flutter: ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
flutter: The following MissingPluginException was thrown running a test:
flutter: MissingPluginException(No implementation found for method canLaunch on channel
flutter: plugins.flutter.io/url_launcher)
flutter:
flutter: When the exception was thrown, this was the stack:
flutter: #0      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:165:7)
flutter: <asynchronous suspension>
flutter: #1      canLaunch (package:url_launcher/url_launcher.dart:131:10)
flutter: <asynchronous suspension>
flutter: #2      main.<anonymous closure> (file:///private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/packages/url_launcher/url_launcher/example/integration_test/url_launcher_test.dart:16:12)
flutter: <asynchronous suspension>
flutter: #3      testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:170:15)
flutter: <asynchronous suspension>
flutter: #4      TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:830:5)
flutter: <asynchronous suspension>
flutter:
flutter: The test description was:
flutter:   canLaunch

Linux
Running command: "flutter drive -d linux --driver test_driver/integration_test.dart --target integration_test/url_launcher_test.dart" in /tmp/cirrus-ci-build/packages/url_launcher/url_launcher/example
Running "flutter pub get" in example...                             4.2s
Building Linux application...
flutter: 00:00 +0: canLaunch
flutter: ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
flutter: The following MissingPluginException was thrown running a test:
flutter: MissingPluginException(No implementation found for method canLaunch on channel
flutter: plugins.flutter.io/url_launcher)
flutter:
flutter: When the exception was thrown, this was the stack:
flutter: #0      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:165:7)
flutter: <asynchronous suspension>
flutter: #1      canLaunch (package:url_launcher/url_launcher.dart:131:10)
flutter: <asynchronous suspension>
flutter: #2      main.<anonymous closure> (file:///tmp/cirrus-ci-build/packages/url_launcher/url_launcher/example/integration_test/url_launcher_test.dart:16:12)
flutter: <asynchronous suspension>
flutter: #3      testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:170:15)
flutter: <asynchronous suspension>
flutter: #4      TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:830:5)
flutter: <asynchronous suspension>
flutter:
flutter: The test description was:
flutter:   canLaunch

This is the failing test:

https://github.com/flutter/plugins/blob/main/packages/url_launcher/url_launcher/example/integration_test/url_launcher_test.dart

Maybe the build is not picking up the latest versions of the macos/linux plugins?

Hmm, that's the wrong channel name, which suggests that registration of the Dart code isn't working correctly somehow.

Is it maybe an issue with flutter [drive](https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/commands/drive.dart) not initializing the app correctly?

I'm not quite sure what to do here. I cannot replicate the integration tests failing locally (at least on macos) and as far as I know the checks on the PR itself ran just fine?
Is this an issue with the changes I made or is this an issue with the CI? Should we revert?

It's actually a latent bug in url_launcher itself from the initial addition of the federated packages. Linux and macOS have a typo in the default_package, and that prevents Dart registration from working. I retracted _linux and _macos, and I'm going to do a long-term fix shortly, so there's no need to revert.

Linux and macOS have a typo in the default_package, and that prevents Dart registration from working. I retracted _linux and _macos

Windows too, which I missed before. Also now retracted.


Fix panic on unset commitSHA

If built with a Version number but not commitSHA, the application would compile but throw a panic on startup. Not sure how you want to handle this, or mark this is unsupported.
I hit this trying to update the package for nixos, where getting commitHash is really hard since the versions are built from release tarballs.

@dbalan released in v0.8.1!


License Check cannot deal with relative path one level up

At first I have placed the license file in the Project Folder instead of the MainApp Folder. Therefore I specified a path like the following:
{
  "bcLicense": "../CustomerLicence.bclicense",
  "idRanges": [],
  "objectRanges": {

    ]
  }
}

I received no warning or error, but when I checked the developer tools, there was the following error:

TypeError: Cannot read properties of undefined (reading 'uri')
at new BCLicense (c:\Users\kise.vscode\extensions\vjeko.vjeko-al-objid-2.9.1\out\lib\BCLicense.js:36:83)
at ObjIdConfigLinter. (c:\Users\kise.vscode\extensions\vjeko.vjeko-al-objid-2.9.1\out\features\linters\ObjIdConfigLinter.js:211:29)
at Generator.next ()
at fulfilled (c:\Users\kise.vscode\extensions\vjeko.vjeko-al-objid-2.9.1\out\features\linters\ObjIdConfigLinter.js:5:58)
at process.processTicksAndRejections (node:internal/process/task_queues:96:5)
$onExtensionRuntimeError @ mainThreadExtensionService.ts:80

This will be included in 2.10.0


Observable.js.map not found (Build warning in Webpack)

I'm submitting a ...  (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here

Current behavior

When included by import { NgxDatatableModule } from '@swimlane/ngx-datatable'; Webpack gives an error:

WARNING in<EMAIL_ADDRESS>Cannot find SourceMap 'Observable.js.map': Error: Can't resolve './Observable.js.map' in '/home/[...]/node_modules/@swimlane/ngx-datatable/release'

Expected behavior

No warning message should appear.
Reproduction of the problem

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Arch Linux, Chromium

Table version: 0.7.x

5.0.0

Angular version: 2.0.x

4.0.0-beta.2

Browser: [all]

Language: [all | TypeScript X.X | ES6/7 | ES5]
Typescript 2.1.4

The problem is that ngx-datatable uses Observable.map but your application does not add the operator to Observable. What you need to do is
import 'rxjs/add/operator/map';
A cleaner solution would be if ngx-datatable did not depend on the patched Observable but instead import the operators as functions like this:
import { map } from 'rxjs/operator/map';
and then do
map.call(observable, ....)

I think you misunderstood the problem, ".map" means the JS mapping file, not the Observable operator.

This is generated dynamically by the build, not sure how I can fix this.

Waht build tools do you use so I can investigate a little the next days?

Look in the package.json package step.

Maybe you could try adding the following to config/replace.js:
var baseRegex = '\\s*[@#]\\s*sourceMappingURL\\s*=\\s*([^\\s]*)';
replace({
  regex: '(//' + baseRegex + '($|\n|\r\n?)|/\\*' + baseRegex + '\\s*\\*/)',
  replacement: '',
  paths: ['./release'],
  recursive: true,
  silent: false
});

Code is untested, I'm under stress with a client's project ^^

I was getting this error when running my app's unit tests, but not during the dev or AoT builds.  I ended up adding the repo to the list of excluded folders for the source-map-loader.  Definitely not the desired course of action, but at least I can run unit tests again.
{
    enforce: 'pre',
    test: /\.js$/,
    use: ['source-map-loader'],
    exclude: [
    // these packages have problems with their sourcemaps
    helpers.root('node_modules/rxjs'),
    helpers.root('node_modules/@angular'),
    helpers.root('node_modules/@swimlane/ngx-datatable'),
    ]
},


Deterministic initial sort order in expanded model details table

Add a sort_slug that yields a deterministic initial sort order for the expanded model details H2H table. This means that rows won't shift around when the data is refetched on reopen.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.85%. Comparing base (7eb4186) to head (1572ff2).
Report is 1 commits behind head on trunk.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk      #67   +/-   ##
=======================================
  Coverage   96.85%   96.85%
=======================================
  Files          33       33
  Lines        1400     1400
=======================================
  Hits         1356     1356
  Misses         44       44

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


0.2.2 add a line after a "}" for f5 configuration

Current coverage is 100.00%

Merging #12 into 0.2 will not affect coverage as of 71eea54

@@              0.2     #12   diff @@
=====================================
  Files           2       2
  Stmts          98      99     +1
  Branches       22      22
  Methods         0       0
=====================================
+ Hit            98      99     +1
  Partial         0       0
  Missed          0       0

Review entire Coverage Diff as of 71eea54

Powered by Codecov. Updated on successful CI builds.


Implement the GraphQL Engine to Handle GraphQL Queries

The Ballerina GraphQL module should have a GraphQL engine to handle the inbound GraphQL queries.

Completed

Completed


Save "authored" as a timestamp; save "author"

Noticed in my dev instance:

Doesn't save authored as a ts (only date w/out time?)
Doesn't save author?

@achen2401  this is something that I noticed again today - can you please prioritize this?


Getting a warning: Connected to a ATEM Mini, but instance is configured for Mini.

I'm seeing this warning in the log:  Connected to a ATEM Mini, but instance is configured for Mini. It suggests that I change to auto detect but still seeing the same warning.

Duplicate of #97


byte[] property no longer nullable

We used version <IP_ADDRESS> of sqlite.
We have an entity with a property of type byte[]
When the table is created the column is set to 'not null' because
Nullable.GetUnderlyingType(prop.PropertyType) != null; returns false for this property.
Recently we installed a newer version of sqlite. Now we get errors because we try to write null values for this property to the database. The errors are actually correct because the column is 'not nullable', so apparently that constraint was not checked in the <IP_ADDRESS> version and it is now.  The bug is that you cannot make this property nullable, there is no attribute or declaration to do so.

Hmm, looks like we need some tests for byte[] nullability. I would have assumed to the schema generator would have tagged it as nullable... strange.


Use callback arg for acks in worker

When sending the ack, we should use the channel provided to us by the callback mechanism, not capture it from the outer scope. This lets use e.g. to extract the callback to a separate method.

@amosonn Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


Fix Helm sedfile template for Tinkerbell charts

In order for the sed command to work correctly, the sedfile should not have a leading v in the semver.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/approve


Question : upgrade peerDependency of mocha

Is it possible to upgrade the peerDependency of mocha to version 4 or 5 ?

The latest mocha-parallel-tests version supports mocha versions 3-5


[Feature] Chats Export and Import as Backup

[Feature] Chats Export and Import as Backup #2754
Screenshot :

Logs Commit :
[+] Export All data Include Settings
[+] Import All data Include Settings
[+] Fixed Model in export and import
[+] Added global settings & Minor improvement
[+] Added based of requested
[+] Fix in config when import success it will reload

Great! I've just tried it, and it works exactly as intended.
I recommend considering the following reordering and renaming suggestions:

I was thinking that perhaps we could replace the settings import and export feature with a backup button and a restore button. This way, users would be able to easily backup (Settings + Chats (including their settings) + Masks) and restore them. Considering that the number of individual settings is not significant, I don't believe it is necessary to have a separate backup option for settings alone.

A more comprehensive idea is to merge all synchronization-related features together, including:

Settings
Chat
Masks
Prompts

Community users have always wanted the subscription feature for masks and prompts. In fact, it can be done together with the synchronization feature, merging them into a unified synchronization panel.

alright will working on it

@Yidadaa, @Algorithm5838 check latest commits I've been push

This is definitely better. However, my new preferred approach would be like this:

Take notice of the new icon in the chat list. Clicking it will open a window that allows you to export or import all chats.
In terms of synchronization, I would prefer it to be a standalone feature. This way, I can have a local copy of my data without relying on a third party such as Google. Also, this would be useful when I want to just clear the browser's data or migrate to another browser.

still writing..

it will be better basically I made own for backup/restore because this one is not possible use default source from @Yidadaa so I have write it as own

@Algorithm5838
btw what is this icon for ?

Import/Export of all chats. By clicking on it, a window will open, giving you the option to export or import all chats.
I repurposed it from Masks:

Notice the two icons located in the upper-right corner.

oh that's ui
from now I'm gonna focusing it first to made possible about system for backup/restore
about ui later because its easy about ui
and can be customize by other developer

@Algorithm5838 check latest commits and try
screenshot :

I will do it in my way, sorry...

Note
About Backup/Restore All Data It's Syncing the process of synchronizing all data, including messages, from the latest backup when they are exported into a JSON file.
When restoring, it will retrieve data from the most recent backup created.
Support Restore All Platform or any browser
If you encounter any bugs, please let me know.

@Yidadaa it's fine
This repository has helped a lot of people from my country since I deployed it. That's why I started contributing. Initially, I was just looking around, but people from my country encouraged me to make my website featuring ChatGPT public.
and many people like it

https://github.com/Yidadaa/ChatGPT-Next-Web/pull/2796


iOS 10 is not firing the 'notification' event after clicking on a notification when the app is in hibernate

After clicking on a notification a hibernated app should open and the 'notification' event should fire, this is not the case for iOS 10 devices. The app opens but the event is not fired.
Tested on iPad Pro and iPhone 5S.
iOS version: iOS 10 public beta 6 & 7
Cordova version: 6.2.0
Cordova iOS version: 4.2.0
Plugin version: 1.8.1

Same here!
iOS version: iOS 10 gold master
Cordova version: 6.3.0
Cordova iOS version: 4.2.0
Plugin version: 1.8.1

I can also reproduce this with IOS 10.0.1 GM, cordova-ios 4.2.1, phonegap-plugin-push 1.8.1

Same here.

Hey all, I'm traveling for work all next week, 4 cities in 8 days, so if anyone can help out with this issue that would be great.

+1

+1 consistently reproduces.

Updating my dev environment in order to look at this. Hope for some news soon but any help is still appreciated.

Yup, I can reproduce it. After much struggling with iOS signing certs.

@NickAdriaenssens  Okay, I did a quick fix for this issue which I pushed up to the issue1199 branch. I'd appreciate some help in testing it.

Looks good on my end. Back to how it was before iOS.
Thank you!

@macdonst Thank you for looking into this!
I can confirm the fix works on multiple iOS 10 devices.

came across this issue as well. Good to hear that it is fixed.
But how can I install the plugin with the above changes?
Thanks,

cordova plugin add https://github.com/phonegap/phonegap-plugin-push.git#issue1199 --variable SENDER_ID="XXX"

@NickAdriaenssens @denyo any chance of you testing on iOS 9 devices as well? With me being on the road I only had one device which I had to upgrade for iOS 10 to reproduce the issue.

@macdonst It is working on iPhone 6 and iPad Mini with iOS 9.3.2

Great, I merged it into master and I will release a 1.8.2 sometime today.

Hi thanks a lot.
Could we install v1.8.2 via cordova plugin add ?
it is v1.8.1 currently. thanks again.

@WilsonFpz yeah, you should just be able to do cordova plugin add phonegap-plugin-push as it is the latest version on npm.

Hello,
I installed Phonegap today (npm install phonegap@latest), created a sample project with the tutorial on their site http://docs.phonegap.com/tutorials/develop/push-notifications/
But I am still having the issue described in this thread. Here are the steps to reproduce.
These are the plugin versions I am using:
$NotifTest>phonegap plugin
cordova-plugin-console 1.0.4 "Console"
cordova-plugin-dialogs 1.2.1 "Notification"
cordova-plugin-statusbar 2.1.3 "StatusBar"
cordova-plugin-whitelist 1.2.2 "Whitelist"
phonegap-plugin-push **1.8.2** "PushPlugin"

I then run the freshly download iOS PhoneGap app on my iOS 10.0.2 iPhone 6S. All looks good. Then, from the windows command line, I run the following commands to send notifications:
phonegap push --deviceID ** --service apns --payload "{ \"aps\": { \"alert\": \"click here please\", \"content-available\": 1, \"title\":\"test-title\", \"message\": \"test-message\", \"sound\": \"default\" }, \"data\": {\"content-available\":1, \"notId\":<PHONE_NUMBER>9}, \"moredata\": \"TEST PUSH\", \"content-available\": 1 }"

phonegap push --deviceID ** --service apns --payload "{\"aps\": {\"data\": \"Test silent background push\",\"moredata\": \"Do more stuff\",\"content-available\": 1}}"

phonegap push --deviceID ** --service apns --payload "{\"aps\":{\"alert\":{\"title\":\"Welcome\", \"body\":\"In this world\"},\"badge\":1,\"sound\":\"default\"}}"

What I expect from those 3 commands, when my PhoneGap app is in the background:

the first one is supposed to generate a notification with content-available:1, therefore, when I click on the notification, it should trigger the push.on('notification'... handler... well it doesn't. Nothing happens - I click the notification, the app opens and that's it. The event handler isn't triggered.

the second one is a "silent" push notification, without alert, it doesn't trigger the handler either

the last one is a simple alert without content-available, so it isn't supposed to trigger the handler, and well, it doesn't indeed.

Am I doing something wrong? What should I check for? I am new at this but I have spent the past 3 hours looking into the issue, without success.
Thanks for this amazing project and good luck for the future, I'll contribute any way I can.

Hi Macdonst,
It seems I am not alone to face this issue :-)
I have just replaced all the "console.log" by "alert" in push.js (1.8.2), put the new app in background, received a notification, clicked on it. The app is resumed but nothing happens and no alert displayed. If the app was killed before receiving the notification, the app does what I expect it to do.
Still don't know what to do... Please... :-)

Hi,
Do we have any update on this? I am facing the same issue as mentioned in this thread. We are planning to release a version of our app to App Store and found this as an issue with our existing functionality to handle push notification. Any suggestion or solution to this issue ASAP will be highly appreciated.
Thank you.

@KranthiVallamreddy please comment on #1265 as this issue is closed.