support ks3 objstore

About ks3
The website links：https://www.ksyun.com/nv/product/KS3.html
Changes

add ks3 object driver

Verification

e2eTest pass

💪🏻
The DCO check could done by git commit --amend --signoff .

Need update update THANOS_TEST_OBJSTORE_SKIP in file .circleci/config.yml makefile.

thanks


annotate.py does not run with newer versions of torchmetrics and setuptools

Tried python annotate.py -h after doing the indicated installation in a python=3.9.5 environment which left me with torch==1.9.0 and torchmetrics==0.11.  The result was
ImportError: cannot import name 'get_num_classes' from 'torchmetrics.utilities.data' (.../lib/python3.9/site-packages/torchmetrics/utilities/data.py)

Downgrading to torchmetrics==0.7 solved the issue as per https://github.com/pesser/stable-diffusion/issues/13
Then the same command yielded
AttributeError: module 'distutils' has no attribute 'version'

which I managed to solve by installing setuptools==59.5.0 as per https://stackoverflow.com/questions/74684612/attributeerror-module-distutils-has-no-attribute-version

Thank you for finding this! I guess torchmetrics removed a function, and its version wasn't pinned correctly within pytorch_lightning or torch (I don't have torchmetrics as an explicit dependency). Newer versions will solve this, and that is planned to be supported in the next major release as well.

Thanks, can confirm that everything works for me when using the output branch.


SIL+Optimizer: a better representation for class let-fields

We can use the [immutable] flag of ref_element_addr to let the optimizer know that a let-field of a class is immutable and can be optimized, e.g. by redundant load elimination.
For this it's required to strictly separate the lifetime of a class into

initialization
regular lifetime
destruction

Let-fields are only immutable within the regular lifetime.
This PR introduces two instructions to separate the life times of a class: end_init_let_ref and begin_dealloc_ref.
The begin_dealloc_ref is a replacement for the old set_deallocating instruction and is inserted by the ReleaseDevirtualizer.
The new LetPropertyLowering pass inserts end_init_let_ref in class initializers at points where all let-fields are initialized. The pass can then also set the [immutable] flags for ref_element_addr.
Although the pass runs in the mandatory pipeline (after DI and before RawSILInstLowering), it is not mandatory. If it doesn't run the effect is only that optimizations may be more conservative, but the SIL is still correct.
For details see the commit messages.

@swift-ci test

With regard to using InstructionRange undereneath PrunedLiveness...
PrunedLiveness provides the expectation that it does work in proportion to the size of the SSA graph. This is important because it's meant to be used inside algorithms that are designed to to query SSA of multiple values independently. As a thought experiment, imagine replacing an all-variable liveness data flow with per-SSA-variable liveness. That should not change the algorithmic compelixity relative to the number of instructions.
PrunedLiveness does not require traversing unrelated instructions (setting aside partially live blocks for a moment). Instead, a live block simply implies that all instructions are live.
If you want InstructionRange to be a more scalable data type, it should only visit instructions in partially live blocks, which seems straightforward.

If you want InstructionRange to be a more scalable data type, it should only visit instructions in partially live blocks, which seems straightforward.

@atrick Thanks for pointing that out. With this commit InstructionRange behaves like you described for PrunedLiveness

@atrick Thanks for pointing that out.  LGTM!

@swift-ci test

@swift-ci test

@swift-ci test source compatibility


E2E tests: Add a test for uploading webp

Feature Description
As of WordPress 5.8, webp files can be used in our editor. We should have some kind of test for it to make it works as expects.
Alternatives Considered

Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

How is a webp e2e test different from one for a jpeg? If anything, should we have tests for all image types?


use authorize-url from Secret - continuation of #180

Continuation of #180.
Let's wait until next week to merge this, but this should now do the trick I believe.
@kakkoyun @squat @bwplotka @metalmatze @krasi-georgiev
cc @maorfr

ping @brancz


ReferenceError: document is not defined

The intercom package is referencing the document which is a bad practise when using Angular. In my case it results in an error as I use Angular Universal to compile the app.

This is a direct port of the Intercom loading script. If you have a suggestion, I would be open to reviewing a pull request.

I'm getting the same issue and I'm guessing this is a SSR issue, can we make this happen? Prevent the server side to run the intercom loading script perhaps?

If you don't run the loading script, then the Intercom library won't load at all. You'll notice that the Intercom provider is an Angular-friendly wrapper around existing intercom methods. Unless someone knows a way to load the official intercom script at runtime, I don't think this will be available out of the box.

I'm not gonna go into much detail but this is pretty simple.

Remove this third party, since it does not work on Angular 5.
On you app.component.ts add the following inside ngOnInit():

    // Init Intercom
    if (isPlatformBrowser(this.platformId)) {
      const d = document;
      const s = d.createElement('script');
      s.type = 'text/javascript';
      s.async = true;
      s.src = `https://widget.intercom.io/widget/` + environment.intercomId;
      const x = d.getElementsByTagName('script')[0];
      x.parentNode.insertBefore(s, x);

      const w = <any>window;
      w.intercomSettings = {
        app_id: environment.intercomId,
        widget: {
          'activator': '#intercom'
        },
        custom_launcher_selector: '#intercom_launcher'
      };
    }

This will work with Angular 5 SSR/AOT!
Don't forget to use:
import { isPlatformBrowser } from '@angular/common';

@wbhob, we could move this lib into a modified boilerplate of https://github.com/CaliStyle/NgEngine. That has SSR/AOT testing built into it and ng-packagr to deploy libraries.

the issue is that Intercom depends directly on document to inject the intercom messenger script and modify the DOM to insert the messenger button. Other than working directly with intercom, I can't think of any way to support SSR.

So, when I built this originally, I used dependency injection. On the server side it would just use a bunch of noops, render correctly and then carry out the client side intercom boot when angular does it's startup on the client side. You can also do this by what @wildlifechorus was talking about, by checking if the environment is the browser and not the server.  You don't want to render the intercom button on the server anyhow.

I guess my question is: how do we render intercom if it is in a server-side context? We still want consumers to be able to use Intercom, so how to we go about including the intercom script?

Angular reboots even if it’s rendered server side, no worries mang, I can prove it and show it :-)

Sounds awesome

Closing this as fixed in 1.0.0-beta.12, however beta.12 is having it's own issues.


python310Packages.azure-keyvault-certificates: 4.4.0 -> 4.5.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.azure-keyvault-certificates is: "Microsoft Azure Key Vault Certificates Client Library for Python"
meta.homepage for python310Packages.azure-keyvault-certificates is: "https://github.com/Azure/azure-sdk-for-python"
meta.changelog for python310Packages.azure-keyvault-certificates is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 4.5.1 with grep in /nix/store/dpk3wcvh99g5bp1ysawljs0zjj5phs5x-python3.10-azure-keyvault-certificates-4.5.1
found 4.5.1 in filename of file in /nix/store/dpk3wcvh99g5bp1ysawljs0zjj5phs5x-python3.10-azure-keyvault-certificates-4.5.1

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.azure-keyvault
python310Packages.azure-keyvault-certificates
python39Packages.azure-keyvault
python39Packages.azure-keyvault-certificates

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/dpk3wcvh99g5bp1ysawljs0zjj5phs5x-python3.10-azure-keyvault-certificates-4.5.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.azure-keyvault-certificates https://github.com/r-ryantm/nixpkgs/archive/a91b487228dfa29849204b4b1024523f734e6a2f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/dpk3wcvh99g5bp1ysawljs0zjj5phs5x-python3.10-azure-keyvault-certificates-4.5.1
ls -la /nix/store/dpk3wcvh99g5bp1ysawljs0zjj5phs5x-python3.10-azure-keyvault-certificates-4.5.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages built:

python310Packages.azure-keyvault
python310Packages.azure-keyvault-certificates
python39Packages.azure-keyvault
python39Packages.azure-keyvault-certificates

Maintainer pings
cc @jonringer for testing.

Built went fine, only minor upstream changes


Fix the Kafka ApiKey query and add ApiKeyName field (human-readable ApiKey)

Before

After

Now I see that they failed and I guess it makes sense (which shows that the fix we did in the past to run then when the folder is changed are working ok)

Now I see that they failed and I guess it makes sense (which shows that the fix we did in the past to run then when the folder is changed are working ok)

@gadotroee updated the dataset for Kafka unit tests with https://github.com/up9inc/mizu/commit/b9cab623668c9e45affb2d4acd454c0a1a4ce827


Add Iometer 1.1.0

Microsoft Reviewers: Open in CodeFlow

No link for the uninstall, but the EXE in the folder works.


Enable StartTrainingSucceedsWithValidPrefix

@maririos commented on Mon Aug 30 2021
Currently service fails when trying to set a prefix

In order to make the prefix work, we need to append a slash / to the end of the string to indicate that it is a subfolder:
new BuildModelOptions() { Prefix = "subfolder/" }

The service team confirmed this is intended, but they want to improve the usability of this feature if possible. We need to sync with them about the progress in this task.
Also, even if we fix the test, it will only search the subfolder for training files, ignoring the files placed in the root of the container, so our test will fail anyway. If this behavior is kept, we need to include training files in the subfolder folder as well.


pre-trained model test

Hi
Thank you for your nice work.
I have a problem when I test your model in my private data.
I set the config path and load the pre-trained model in this way:
net = ViT_seg(config, img_size=224, num_classes=2).cuda()
net.load_from(config)

I inference my CTPA volume slice by slice, but the result seems not right.
I want to confirm:

if the model is loaded correctly.
the method of data preprocessing, such as normalization.

Thank you!

Hello i've two issues

with the minimal changes to the  proposed architecture and the training part go well and when it comes to testing the model it sucks with the model loading part of dimensionality error.

The Dataset part as i've seen that new FUMPE dataset and it's not in .npz format and anyone can help me with the part of code for conversion to the proposed format.

For the Issue 1 the problem ariases due to the below part of code
`def forward_up_features(self, x, x_downsample):
for inx, layer_up in enumerate(self.layers_up):
if inx == 0:
x = layer_up(x)
else:
skip = x_downsample[3 - inx]
# Reshape for MHA
B, L, C = x.shape
H, W = int(math.sqrt(L)), int(math.sqrt(L))
x = x.view(B, H, W, C).permute(0, 3, 1, 2)
skip = skip.view(B, H, W, C).permute(0, 3, 1, 2)
            # Adjust dimensions for MHA
            x_mha = x.flatten(2).permute(2, 0, 1)  # Shape: [H*W, B, C]
            skip_mha = skip.flatten(2).permute(2, 0, 1)  # Shape: [H*W, B, C]

            # Dynamically create a MultiheadAttention layer with the correct embedding dimension
            mha = nn.MultiheadAttention(embed_dim=C, num_heads=self.num_heads[inx], batch_first=True)
            mha.to(x.device)
            # Combine features using MHA
            attn_output, _ = mha(query=x_mha, key=skip_mha, value=skip_mha)

            # Reshape back
            attn_output = attn_output.permute(1, 2, 0).view(B, C, H, W).permute(0, 2, 3, 1)
            x = attn_output.flatten(1, 2)
            # Dynamically adjust the input dimension of the linear layer
            next_layer_dim = int(self.embed_dim * 2 ** (self.num_layers - 1 - inx))
            if self.concat_back_dim[inx].in_features != C:
                self.concat_back_dim[inx] = nn.Linear(C, next_layer_dim).to(x.device)
            x = self.concat_back_dim[inx](x)
            x = layer_up(x)
    x = self.norm_up(x)
    return x

`
@JustlfC03 @LiGengWan can anyone of help me with this


Bug in EluGradGrad

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes, see below
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
TensorFlow installed from (source or binary): binary - latest pip tf_nightly
TensorFlow version (use command below): v1.8.0-1674-gd8fac4cb80 1.9.0-dev20180515
Python version: Python 3.6.3
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: CUDA Version 9.1.85
GPU model and memory: GeForce GTX 970
Exact command to reproduce: See script attached

Describe the problem
There seems to be an issue with EluGradGrad that I have uncovered. Please see the post here: https://github.com/renmengye/tensorflow-forward-ad/issues/2#issuecomment-389321546
Source code / logs
Running this script will demonstrate the incorrect values:
import tensorflow as tf
import numpy as np

def fwd_gradients(ys, xs, d_xs):
    dummy = tf.zeros_like(ys)
    g = tf.gradients(ys, xs, grad_ys=dummy, name="gradients")
    return tf.gradients(g, dummy, grad_ys=d_xs, name="jvp")

def my_elu(x):
    return tf.where(x >= 0.0, x, tf.exp(x) - 1.0)

def main():
    print(tf.__version__)

    sess = tf.InteractiveSession()
    init = tf.global_variables_initializer()

    # activation = my_elu # Works correctly tf.nn.relu (or any other non-elu activation)
    activation = tf.nn.elu

    x_size = 3
    y_size = x_size

    # Single ELU or RELU op
    X = tf.placeholder(tf.float64, shape=[x_size]) # Input
    Y = activation(X) # Output

    # Define vjp and jvp
    Vx = tf.placeholder(tf.float64, shape=[x_size]) # Jac-vector product input V
    Vy = tf.placeholder(tf.float64, shape=[y_size]) # vector-jac product input V
    jvp = fwd_gradients(Y, X, d_xs=Vx)
    vjp = tf.gradients(Y, X, grad_ys=Vy)

    # Compute jacobians
    x = np.ones(x_size) - 1.5 # Bug only occurs in x < 0 region
    # x = np.random.normal(-1, 1, x_size)
    tf_jac, numeric_jac = tf.test.compute_gradient(X, [x_size], Y, [y_size], x_init_value=x)
    vjp_jac = np.array([sess.run(vjp, feed_dict={X: x, Vy: v})[0] for v in np.identity(y_size)])
    jvp_jac = np.array([sess.run(jvp, feed_dict={X: x, Vx: v})[0] for v in np.identity(x_size)])

    # Print results as maximum absolute error
    print("Numeric jac:", numeric_jac)
    print("jvp jac:", jvp_jac)
    print("tf error:", np.max(np.abs(numeric_jac - tf_jac)))   # ~0.0
    print("vjp error:", np.max(np.abs(numeric_jac - vjp_jac))) # ~0.0
    print("jvp error:", np.max(np.abs(numeric_jac - jvp_jac))) # LARGE! for ELU

    sess.close()

if __name__ == '__main__':
    main()

The solution is to edit the implementation of _EluGradGrad here.
I've created a pull request that references this issue.

Nagging Assignee @tatianashp: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@zero-impact Thank you for submitting PR #19334!


support Kubernetes Secret/ConfigMap lookup through resolver ('location' attribute)

support Kubernetes Secret/ConfigMap lookup through resolver ('location' attribute)
issue:

how to notify resource changes?

Too old. If needed please reopen.


Move codebase to JDK9

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Need to touch some code so that the build process is triggered, mostly a test to see if JDK9 is installed on Travis.

In order to merge the CQRS branch #137 it was necessary to move JDK version to JDK9.
In that case this branch is no redundant.


Fix configuration cache violations

Current dependencies on/for this PR:

main

PR #52   👈

This comment was auto-generated by Graphite.


Wrong regex is being used for account number which allows alphabets on web/desktop - Reported by @thesahindia

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open app
Navigate to settings > Workspace > Add bank account
Proceed to the manual flow
Enter IBAN

Expected Result:
No error appear when the wrong value is entered
Actual Result:
Wrong regex is being used for account number which allows alphabets on web/desktop
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
Desktop App

Version Number: 1.1.25-0
Reproducible in staging?: Y
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43995119/148335464-396b7ab1-4af0-4291-81cb-bcdbe885a9dd.mov

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1640031757416400
View all open jobs on GitHub

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Proposal
we need to add another regex for US bank accounts to use only numbers and we have to use it instead of IBAN
question: What should be the min-max for this input? (is it 4-17 digits for US bank accounts?)
https://github.com/Expensify/App/blob/580c9dbb1d2cf364bdcb6d7b3c06560f35b3ac6d/src/pages/ReimbursementAccount/BankAccountStep.js#L91

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

Current assignee @puneetlath is eligible for the Exported assigner, not assigning anyone new.

Upwork job is here: https://www.upwork.com/jobs/~01a104e8cf7c738d4c
@thesahindia based on this post, it seems 4-17 digits.

🎀👀🎀 C+ reviewed.
Regex matches any number of length 4-17 both inclusive. @thesahindia's proposal looks good.
cc: @puneetlath

Looks good to me too! @thesahindia I invited you to the job in Upwork.

📣 @thesahindia You have been assigned to this job by @puneetlath!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.29-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/7101

If no regressions arise, payment will be issued on 2022-01-21. :confetti_ball:

@thesahindia paid!
And @rushatgabhane sent you a hiring offer.


Initial draft of an explainer conversation around Declarative Custom Elements

Is this draft here meant to build off of this strawman @Westbrook , or is this draft meant to be understood in its own independent context?  (and if does build off the strawman, maybe a link back to that spec?)
I only ask because it would be great to show some code samples here to illustrate the point of what sort of declarative outcome are we looking for, e.g. serializing event handling, updating / connecting state to DOM, or is it more generic than that, in just stamping out a Single File Component with the user entirely filling in the blanks and just the "linking" / loading functionality from the browser?

Hello Example

<button onclick="hello()"›Say Hello</button>

<!DOCTYPE html>

    <import src="/wc-hello.html" />
    <title›Hello Example</title>

    <wc-hello></wc-hello>

Perhaps with HTML Modules, we can leverage ESM so the incoming custom element can share / link it's scope, but hello would not be a global function?

@thescientist13 I'd not see that straw person, when I get back to this, I'll be sure to include it! Code examples also make sense. However, I get a lot of feedback from browsers that they don't want APIs, they want use cases, so in all the work I'm looking at in the spec'ing space, I'm trying to lean away from that, at least in public.
This specific PR became a conversation with myself, for the most part, and the conclusion was that I was addressing a handful of specs that would be best to address as such rather than a single "Declarative Custom Elements" spec. Further, I made a personal decision that "Declarative Web Components", likely the compendium of all the ideas herein, made sense as quite different than "Declarative Custom Element", in that a custom element doesn't need shadow DOM and other specs...but at the intersection of all the "Declarative" specs a web component might later be possible in a declarative fashion.
Roughly, the various specs that I think this involves come out to:

declarative templating
declarative custom elements
declarative web components
custom element/web component modules,
scoped registries, possibly powered by the above modules
and likely more
The scope was too heavy, so while I want to get back to it, we'll see if/when that happens.

I've gotten specific excitement for https://github.com/Westbrook/custom-element-proposals/pull/3, so I'm focusing on that first, as it's much higher on https://w3c.github.io/webcomponents-cg/ and much more likely to benefit all people in that the places 😉


Add tests for foreign_key_type_checker

To follow up on https://github.com/djezzzl/database_consistency/issues/64

Hey, could you please force push the changes? I just changed the config for circleCI to be run on forked projects (at least I hope I did).
Other than that, I think we can add to_s to both base_key and associated_key instead, then we don't need any other to_s (including yours and the one I added to column method.

And thank you for your contributation, of course 👍

Awesome, thank you! I'll release it ASAP.


Support more settings of JettyServer, such as backlog

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[ ] Bug
[*] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?

Bug

Which version of SkyWalking, OS and JRE?

Which company or project?

What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.

Requirement or improvement

Please describe about your requirements or improvement suggestions.

The TCP backlog default is 50 in java,  Recv-Q of port 10800 up to 50 when system is busy, expected to support more settings of JettyServer, such as backlog(org.eclipse.jetty.server.ServerConnector.setAcceptQueueSize()).
show Recv-Q & Send-Q of 10800:
ss -lntp|grep 10800

Do you use http json to upstream traces? Jetty should use for UI query only.

I used 5.0.0-GA, the description of port 10800 in application.yml is:
naming:
  jetty:
    #OS real network IP(binding required), for agent to find collector cluster
    host: localhost
    port: 10800

Yes. But use for UI and maybe some 3rd party sdk, I don't know.
Could you inform me, why Jetty has such high payload?

I have not found the cause, I get alarm from monitor and than see that.
Is java agent use this port ?

In 5, yes. Removed in 6. And at 5, you could use grpc port too by set in direct link mode.

OK, thank you very mush.


Impossibile to set a color from another script

I've tried in many ways, but it seems to be impossibile to set a color from another script.
[HERE] (http://www.eyecon.ro/colorpicker/#implement) is an example at the bottom of the page.
Also, it's not possibile to call the  "renderCallback" twice.
I'm completly stucked......

Hi @nikto1
thanks for your interest in jqColorPicker!
Well, I can see your confusion ;) The link http://www.eyecon.ro/colorpicker/#implement you attached in your comment is from an other color picker,... but not mine.
jqColorPicker doesn't provide a setColor method. You set the color by providing the input field with a value and then call the initialization routine $('.color').colorPicker().
If you want to set a color of a specific input field, first set the value $('#myInputField').val('#FF0000') (or something like this) and then call $('.color').colorPicker() again. I wouldn't recommend this though, but it's possible.
Your second question: You can set options the first time you call $('.color').colorPicker({...}) but not a second time. If you need additional features for a second set you call, use a back door like:
var callCallBack = function(){};

$('.color').colorPicker({
    renderCallback: function($elm, toggled) {
        // do something here...
        callCallBack($elm, toggled);
    }
})

If you now need to do some more things in your callback, you can overwrite your empty callCallBack function.
If you want to do it right you should use javaScript's main feature: events!
$('.color').colorPicker({
    renderCallback: function($elm, toggled) {
        $(document).trigger('renderCallback', [ this, $elm, toggled ]);
    }
})

Now you can attach event listeners as many as you want (later on in your code):
$(document).on('renderCallback', function(event, instance, $elm, toggled){
    // do something here...
});

Good luck and let me know if it works for you. If you need more features then you might want to use https://github.com/PitPik/colorPicker, the big brother of jqColorPicker...
Cheers,
Peter

Hi Peter,
thanks for reply, very gently.
I attacked the link to the other colorPicker just to give an example :-)
Here's a short explanation what I'm trying to achive:
I call the colorpicker a first time to initialize the script. Inside the callback there's a function to modify the colors of a WP theme dynamically. When the user have finished with his modification, he could save them in an css file, created via php/ xml.
Once the css file is saved, you could modify it, selecting it through an select box. If you select a saved css file, all the colors of the theme and the respective input fields in the control panel changes their colors.
But then, if i click on an input field, the colorpicker doesn't react to the second callback. In other words, i tryed to initialize the colorpicker + callback a second time to set the appropriate color in the colorpicker from the input fields an not viceversa, but it's not working.
So i gave you the link as an example. Is it possibile somehow to set a color in the colorpicker from an input field; e.g. setColor(), and call this function from another script?
I've tried also to modify the colorpicker script for 2 days but no luck, because primarily i write php so i do not understand completely the javascript logic.
I really would like to use it, because it's very lightweight and fast.
Greetings and thanks again
Leonardo

@nikto1
did you have any success yet with my instructions?
I guess the easies would be the one where you overwrite your 'external' callback the second time you initialize it (the callCallBack example), so the first time you say:
var callCallBack = function($elm, toggled) {
    //... whatever you need the first time
};

$('.color').colorPicker({
    renderCallback: function($elm, toggled) {
        // do something here...
        callCallBack.call(this, $elm, toggled);
    }
})

...where you define callCallBack with what you need the first time...
and the second time you would call colorpicker you just overwrite the callback:
callCallBack = function($elm, toggled) {
    //... whatever you need the second time
};
$('.color').colorPicker(); // If your colors changed here

I follow your instructions, modied my code (merge some .js files) but still without luck :-((
My .js structure is:
 // CODE
 // Here i call the colorPicker with the callback var inside
 // other code
 // HERE comes an AJAX CALL and inside there should be something like
 $(this).ColorPicker(event.val);
 // where $(this) are each input field and event.val are the values from where the
 //  fields value should set the colors in the colorpicker

The problem is that the ajax call comes +/- 200 lines below the init call for the colorPicker; Also, i cannot declare the
  var callCallBack

outside the ajax call because i need it inside (i think, but no idea).
Still stucked but thanks a lot for the support.

Your problem here is that you can't set the colors by passing variables via colorPicker, you should first set the values of the input fields and then call colorPicker (without parameters) again, so:
$(this).each(function(index, element) { // if that $(this) are the input fields...
    $(element).val( /* here you set the value */ ); // ???
}).colorPicker(); // ...and here you initialize the newly set input fields again.

I don't exactly know how you get the single values and where event.val comes from (for your input fields), I guess it should be an array or an object) so the line $(elm).val(...) might look different in your case.
Your second concern: You can declare var callCallBack outside for the first time and then redeclare it (without var though) inside your ajax callback, that's perfectly ok...
...and also, be aware that it's .colorPicker() not .ColorPicker() (c not C)
Let me know if you get any further...

Well, I now I guess I know how it works... does your $(index)... come from an each loop already? I f so then you should just put:
    $(this).val(event.val);

and then outside this each loop the .colorPicker(); on the input collection again.
Well, it's really hard to guess code ;o)

Sent you a mail at  github[at]dematte[dot]at with part of my code. I hope this will clear the things.
Thank you really very much!

I tried with
$(this).val(event.val);

like you said for the second time, but i am still missing something on redeclaring the second callback in the ajax part

If i'm trying to set the colorpicker a second time i always get a
  Uncaught Error: Syntax error, unrecognized expression: '.color','.color'...eccc

each time i click the input field

Finally i think i figured it out, without a second callback:
The first time i called the colorPicker normally configuring it
But the second time is:
         $('.colori').colorPicker({
	 renderCallback: function($elm, toggled) {
         $(this).val(el.val);
	}
	});

Please let me know if it's a big problem if the colorPicker is initialized a second time in the ajax call. I coudn't figure it out with the callbacks.
Above that your help is/ was vital.


zlib module missing when --enable-optimizations

I don't know if you guys have this issue. I compiled python 2.7.13 with --enable-optimizations on, then zlib module is gone. Have anyone encountered this too?

Oh, that is strange. I didn't check that in my test for https://github.com/docker-library/python/issues/160 and could be a blocker if we seriously consider using it for all the images.  If you can make a reproducible case, you should probably report it to upstream in their issue tracker https://bugs.python.org/.

Right. This is solved finally by finding the libz.so.1 in my /lib/x86_64-linux-gnu folder and make a link sudo ln -s /lib/x86_64-linux-gnu/libz.so.1 /lib/libz.so according to a ubuntu forum thread(I, lost the link to that thread...). It actually worked. I'm working on Ubuntu 14.04, don' know if it's system specific problem. I'll report to python.org anyway. Thanks.

Closing, given that this appears resolved.


SCM: Placeholder text has overflow and is hidden

VSCode Version:1.38.1
OS Version: Ubuntu Disco Dingo 19.04

Steps to Reproduce:

open vscode
go to SCM extension

Does this issue occur when all extensions are disabled?: Yes
The placeholder text in the SCM extention tab (Message (Ctrl + Enter to commit on <Branchname>)) is hidden when the width of the bar is not big enough

This is fixed in master.


Microsoft Learn: Returning to Profile gets a CORS error

Describe the bug
When a user navigates from Profile and back, Profile does not fetch the data correctly.
To Reproduce

Go to Microsoft Learn > Profile
In In progress > Modules, click a module to navigate to the page for the module
Click Back of the browser:

the page is rendered without any user data
a CORS error appears in the console

SEC7120: [CORS] The origin 'https://techprofile.microsoft.com' did not find 'https://techprofile.microsoft.com' in the Access-Control-Allow-Origin response header for cross-origin  resource at 'https://docs.microsoft.com/api/gamestatus/fac50254-c10a-4855-b9ba-cb2fc1c92ea6'.

Expected behavior
The page is rendered as usual
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser: Edge (or Chrome)
Version: latest

Additional context
N/A

I'm facing the same issue, any update on this one ?


Sm engine

isotope_image_correlation - first image mask returned
measure_of_chaos small update (approved by Andy)

Hey guys, can I expect merging this changes into the master at some point?

Should we add a new version or what is your policy?

Good idea.


Fix type-coercion to Iterable<?>

@aledsage LTGM. Tests are passing for me. Tested successfully with a BP which fails without it.

LGTM.  @ygy what was your blueprint?

@geomacy You can find at https://gist.github.com/ygy/59c793028457c1f1f5a1f027df047fa6

@m4rkmckenna it's an issue when we try to coerce from some complex yaml values to jclouds parameter values - e.g. we try to reflectively call AzureTemplateOptions.secrets(Iterable<Secret>) if you use something like:
location:
  azurecompute-arm:
    templateOptions:
      secrets:
      - sourceVault:
          id: myid
        vaultCertificates:
        - certificateUrl: myurl
          certificateStore: mystore

Merging...

Merging


[google_sign_in] App Crashed in IOS after updating xCode 14.3.1 and Flutter 3.10.5

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

In project, You should use version of google_sign_in: ^5.4.1 or more recently.

Use Flutter 3.10.5 and Xcode 14.3.1

it tries to execute Google Sign in IOS devices

Expected results
The google authorization window should be clickable and after selecting an account, it should authorize the user.
Actual results
App is crashing just in IOS. Android is working very well.
Code sample
Code sample

final googleSignIn = GoogleSignIn();

final GoogleSignInAccount? googleSignInAccount =
          await googleSignIn.signIn().catchError((_) {
        emitter(const GoogleSigninErrorState());
        return null;
      });

final auth = await googleSignInAccount?.authentication;

Screenshots or Video

Screenshots / Video demonstration
https://github.com/flutter/flutter/assets/29807852/e80e033d-07c5-4a76-bc7b-2bf30a336b53

Logs
Logs
-[__NSCFString objectForKeyedSubscript:]: unrecognized selector sent to instance 0x28150c420
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[__NSCFString objectForKeyedSubscript:]: unrecognized selector sent to instance 0x28150c420'
*** First throw call stack:
(0x1a47dccb4 0x19d8843d0 0x1a4951ab8 0x1a47f30e8 0x1a4859900 0x102d7eea0 0x102d7f3dc 0x102d78728 0x102d773fc 0x10235dc48 0x10979272c 0x1091ecb80 0x1abca1320 0x1abca2eac 0x1abcb16a4 0x1abcb12f4 0x1a486bc28 0x1a484d560 0x1a48523ec 0x1dfcef35c 0x1a6bdf6e8 0x1a6bdf34c 0x10222c35c 0x1c3d2adec)
libc++abi: terminating due to uncaught exception of type NSException
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
    frame #0: 0x00000001e371e558 libsystem_kernel.dylib`__pthread_kill + 8
libsystem_kernel.dylib`:
->  0x1e371e558 <+8>:  b.lo   0x1e371e578               ; <+40>
    0x1e371e55c <+12>: pacibsp
    0x1e371e560 <+16>: stp    x29, x30, [sp, #-0x10]!
    0x1e371e564 <+20>: mov    x29, sp
Target 0: (Runner) stopped.
Lost connection to device.
Exited

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.10.5, on macOS 13.4 22F66 darwin-arm64 (Rosetta), locale en-BR)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.2)
[✓] Android Studio (version 2022.1)
[✓] IntelliJ IDEA Ultimate Edition (version 2022.2.3)
[✓] IntelliJ IDEA Ultimate Edition (version 2022.2.3)
[✓] VS Code (version 1.79.2)
[✓] Connected device (3 available)
[✓] Network resources

• No issues found!

@MattheusOliveira
Thanks for the report. We are unable to replicate this on Xcode 14.3.1 and lesser version and using stable 3.10.5 with below code sample:

 code sample

TextButton(
                      child: Row(
                        mainAxisAlignment: MainAxisAlignment.center,
                        children: [
                          Image.asset(
                            "assets/images/google.png",
                            height: 18,
                            width: 18,
                          ),
                          SizedBox(
                            width: 5,
                          ),
                          Text(
                            "Sign in with Google",
                            style: TextStyle(fontSize: 16),
                          ),
                        ],
                      ),
                      onPressed: () async {
                        final googleSignIn = GoogleSignIn();

                        final GoogleSignInAccount? googleSignInAccount =
                            await googleSignIn.signIn().catchError((_) {
                          // emitter(const GoogleSigninErrorState());
                          return null;
                        });

                        final auth = await googleSignInAccount?.authentication;
                       },
                    )

Can you try the same and check at your end if it crashes still ? If so, can you provide the crash log in properly formatted text ? Also, please try the same on latest master and see if crash persists or not.

@darshankawar I've tried again, and the crash is happening yet. I am using Flutter 3.10.5 channel stable.

Thanks for the update @MattheusOliveira
Is the crash occuring in debug mode or in release mode ? Are there more logs that you can provide that'll help to analyze it further ?
Also, can you run in verbose mode and provide the entire log in properly fomatted text ?  (ex: flutter run -v) The log will be huge so you can put that in a text file and share it here.
Also, can you provide more detailed code including emitter(const GoogleSigninErrorState()); ?

@darshankawar The crash is occurring in debug mode and release mode. I've executed through flutter run -v. I will share the logs in PDF annexed below.  emitter(const GoogleSigninErrorState()); is a management state of bloc. We use a lot of package in our project. I created a widget having a simple code from google_sign_in package, and it is still happening the crash:
LOG flutter verbose.pdf
import 'dart:developer';

import 'package:flutter/material.dart';
import 'package:google_sign_in/google_sign_in.dart';

class GoogleSigninIosPage extends StatelessWidget {
  const GoogleSigninIosPage({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Google signin ios'),
      ),
      body: Center(
        child: ElevatedButton(
          child: const Text('Google signin'),
          onPressed: () async {
            final googleSignIn = GoogleSignIn();
            final GoogleSignInAccount? googleSignInAccount =
                await googleSignIn.signIn();
            final auth = await googleSignInAccount?.authentication;

            if (auth != null) {
              log('success integration with google package');
            }
          },
        ),
      ),
    );
  }
}

Thanks for the update and patience while we figure our the root-cause @MattheusOliveira
From the log you shared, I see below error:
[ +65 ms] flutter: ----------------FIREBASE CRASHLYTICS----------------
[ ] flutter: PlatformException(EMPTY_APP_KEY, Please initialize the Amplitude with a valid
API Key., null, null)
[ ] flutter:
[ ] #0 StandardMethodCodec.decodeEnvelope
(package:flutter/src/services/message_codecs.dart:652:7)
[ ] #1 MethodChannel._invokeMethod
(package:flutter/src/services/platform_channel.dart:310:18)
[ ] <asynchronous suspension>
[ ] #2 Amplitude.init (package:amplitude_flutter/amplitude.dart:38:12)
[ ] <asynchronous suspension>
[ ] flutter: ----------------------------------------------------
[ +38 ms] ERROR: apiKey cannot be nil or empty, set apiKey with initializeApiKey: before
calling logEvent
[ ] ERROR: apiKey cannot be nil or empty, set apiKey with initializeApiKey: before calling
logEvent

It seems to be pointing to amplitude_flutter package. If removing it or properly setting the required api_key as applicable, does the crash still occur ?

@darshankawar I've removed amplitude_flutter package and crash still occurring.

Thanks for the update. Currently we are unable to replicate / properly verify it as we are hitting https://github.com/flutter/flutter/issues/83759 while trying to run the package example and also the code sample provided above, so based on the report, keeping the issue open for team's attention and tracking.

This crash looks like memory corruption. Could you provide a list of other plugins (not all packages, just plugins) you are using, as well any custom native code you may be using?

We have solved the problem. In info.plist file, the NSAppTransportSecurity has been put inside CFBundleURLTypes, but should be in root file. CFBundleURLTypes is where gets settings of Google Sign in. So, this package did not find the settings and consequently it crashed.
Solved by @guibsonarc

Ah, that sounds like an unchecked cast then, not memory corruption. There's no code in the plugin that reads that plist, so there's no change to make in the plugin here. (If it's crashing in the GoogleSignIn SDK you could file an issue there to consider checking types.)


rafthttp: fix data races detected by go race detector

fix the race in the test. fakeWriteFlushCloser is used by multiple routines without locking.

stopped variable has data race. Removing it since the stop logic is actually unnecessary.

LGTM if it passes race detection.

lgtm


[release-2.16.0][BEAM-8299] Upgrade Jackson to version 2.9.10

Cherry pick of #9636 (done in parallel)
R: @pabloem
CC: @markflyhigh

Run Python PreCommit

Run Java_Examples_Dataflow PreCommit

LGTM. I've merged https://github.com/apache/beam/pull/9636 -  I'll let the release manager merge this.

Run Java_Examples_Dataflow PreCommit

Run Python PreCommit

Run Java_Examples_Dataflow PreCommit

Run Java_Examples_Dataflow PreCommit

Run Python PreCommit

pydoc failure in Python Precommit will be fixed by cherry-pick https://github.com/apache/beam/pull/9654. We can ignore it since all test passed.

Run Java_Examples_Dataflow PreCommit


platform-configs/rpi-3b.robot: config has values that don't make sense

the config has values that don't make sense, for example here:
# Regression test flags
# Test module: dasharo-compatibility
${BASE_PORT_BOOTBLOCK_SUPPORT}=                     ${FALSE}
${BASE_PORT_ROMSTAGE_SUPPORT}=                      ${FALSE}
${BASE_PORT_POSTCAR_SUPPORT}=                       ${FALSE}
${BASE_PORT_RAMSTAGE_SUPPORT}=                      ${FALSE}

the values that are not used should be removed.

We should make a standard approach to the configs on different environments like Yocto vs. coreboot etc. Removing every unnecessary variable is the easiest approach, but TBD if it's the best. The document explaining which flag must be filled in based on the used firmware/software components/connected hardware would be a great addition.


Temporary disable tenant qualified disabled test cases

With the https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/2242, a startup validation will be added to check for the compatibility with client ID tenant unification. However a test added with the original feature requires running the server by disabling tenant qualified URLs and tenanted sessions. With the new change, a DB scheme change is required to start the server in that mode and this PR isto disable that particular fix until that test change is implemented.
Related issue

https://github.com/wso2/product-is/issues/17076
https://github.com/wso2/product-is/issues/17762

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6847984534

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6847984534
Status: success


Adds dialogs support, bump<EMAIL_ADDRESS>

Coverage remained the same at 100.0% when pulling fb53576daf44f016c435c77dcd19edd5c28ec989 on upgrade-slack-9 into 804f7aee1dfe83df830d270506fad592dbb41fd6 on master.

Coverage remained the same at 100.0% when pulling fb53576daf44f016c435c77dcd19edd5c28ec989 on upgrade-slack-9 into 804f7aee1dfe83df830d270506fad592dbb41fd6 on master.


Loading ontologies

There isn't a means by which to import ontologies via CyREST.
The steps to achieve this via the GUI are outlined here: http://manual.cytoscape.org/en/stable/Ontology_and_Annotation_Import.html
However, all the relevant TaskFactories are in org.cytoscape.tableimport.internal, and are not available, and what could have been a relevant CyAction is commented out in  abcaf57d095a1be7316681628d46973d6f63e626, possibly for very good reasons.
Making ontology loading part of the Cytoscape API needs to happen before this is addressed.

As pointed out by @bdemchak, the support for this in Cytoscape is now gone completely, so shouldn't be an issue at all.


Fixed typo in AuthenticationTokenExtensions.xml

Fixed typo in AuthenticationTokenExtensions.xml:165
toekns -> tokens

Thanks for your contribution. Per https://github.com/aspnet/ApiDocs/blob/master/README.md
API PR's ( api/autoapi/... ) should not be made here. Changes to API documentation should be made in the source repository against the triple slash /// comments.


Dropped database reappears on influxd restart

Three influxd instances in a cluster.  Created a database with a retention policy (replication=3), wrote some data into it.

Run "drop database", see that it has gone from "show databases".
Kill and restart the influxd instance I was talking to with the CLI (in this case it's just a ctrl-c as I'm running influxd in the foreground)
Run "show databases" again, see that the database is back from the dead.

My zombie database is called "ceph", and during daemon startup I see this line:
[server] 2015/04/12 10:58:44 retention policy 'default' auto-created for database 'ceph'

...so presumably something is getting replayed that shouldn't be when the daemon comes back up after unclean shutdown

Never mind, user error.  This was getting recreated because it was listed in a [graphite] configuration section.


[R-package] [ci] Fix CI timeouts for Mac builds on Travis (fixes #3091)

See #3091 for details. This PR fixes the recent issues with R Mac builds timing out on Travis.
It's not clear why these builds, which used to take around 10 minutes total, now take closer to 19 minutes
I'm a little worried that recent R PRs introduced a Mac installation performance problem, but I've also found (across many projects, not just LightGBM), that the Mac environments on Travis are not as reliable as the Linux environments.
Either way, that investigation can come later...this PR should unblock us.

Tested on my fork, the Mac build takes almost 19 minutes but doesn't time out: https://travis-ci.com/github/jameslamb/LightGBM/jobs/335519105


Installation issues

Environment:
MacPro Intel chip
Issues:
There are some issues when trying to install the binary using install.sh

the install.sh script suggested in README.md does not work, it cannot find the latest binary in releases page
on Mac, installing to binary to ~/.cargo/bin/sqlx-ts or /usr/local/bin/sqlx-ts result in [1]    82069 killed     /usr/local/bin/sqlx-ts --help

Fixed in the main branch


Failed to install into project using .Net 4.5.2

Could not install package 'Manatee.Json 9.7.1'. You are trying to install this package into a project that targets '.NETFramework,Version=v4.5.2', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.			0

According to the .NET Standard docs, .NET Standard 1.3 (which is what Manatee.Json builds to) is only compatible with .NET Framework 4.6+.

Ok, will try later as I am using Orchard CMS 1.10.1 which is targeting .Net 4.5.2

If your app is 4.6, you should have no problem consuming libraries at 4.5.2.

@lbcsy were you able to get this going?  Can this issue be closed?

Please close it, I am not able to try yet as the old Orchard is still in use.

Okay.  As I mentioned, you should be able to upgrade your app to .Net 4.6 and still use a 4.5.2 library.  That would allow you to use Manatee.Json.
Let me know if you have further difficulty with this.

See also https://github.com/gregsdennis/Manatee.Json/pull/149


Minimize window while displaying a MessageBox, window cannot be reopened again

Desktop (please complete the following information):
ttkbootstrap: 1.10.1
OS: Windows11
Describe the bug
Hello:
I'm writing a application with ttkbootstrap, and I found a issue that I cannot fix by myself.
When a MessageBox is displayed above the root window, if I use keyboard win+D to switch to desktop, or scenarios that MessageBox show with root window minimized, root windows and the MessageBox cannot be show on screen anymore.
I think it's line 89-90 in dialog.py, in method Dialog.show, led to this problem.
        self._toplevel.grab_set()
        self._toplevel.wait_window()

if I remove self._toplevel.grab_set(), this issue can be fix, but the root window will not be disabled while showing a messagebox, and this can lead to a lot of misoperations.
I wonder if there is a better solution here?
To Reproduce
Here I provide a small example to reproduce this issue：
import ttkbootstrap as ttk
from ttkbootstrap.dialogs import Messagebox

root = ttk.Window(size=(300,300))
Messagebox().show_info(message='test')

after run code above, use keyboard win+D to switch to desktop, the root window cannot be reopen again.
Expected behavior
Make the minimized window with dialog can be reopen normally, without affect the performance of other functions.
Screenshots
No response
Additional context
No response

Hello,I had the same problem when I minimized the window and closed it in the taskbar,the window did not close and cannot be reopened.
import ttkbootstrap as ttk
from ttkbootstrap.dialogs import Messagebox

root_total= ttk.Window()
def on_closing():
    T = Messagebox.show_question(message='close or not?', title="quit", buttons=["close:info", "not:secondary"],parent=root_total,position=(root_total.winfo_x() + root_total.winfo_width() // 2 - 100,root_total.winfo_y() + root_total.winfo_height() // 2 - 100))
    if T == 'close':
        root_total.destroy()
root_total.protocol("WM_DELETE_WINDOW", on_closing)

I made a slight modification to this part (dialog.py line 89-90), which seems to temporarily solve the issue.
However, this requires Dialog to have the parent parameter.
        if self._parent:
            self._parent.winfo_toplevel().attributes("-disabled", True)
            self._toplevel.wait_window()
            self._parent.winfo_toplevel().attributes("-disabled", False)
            self._parent.winfo_toplevel().lift()
            self._parent.winfo_toplevel().focus_force()
        else:
            self._toplevel.grab_set()
            self._toplevel.wait_window()


Switching tabs requires more than one press until transition animation is over.

Current behavior
I have tried using scrollEnabled: true or equivalently tabBarScrollEnabled: true on a createMaterialTopTabNavigator as well as directly in a react-native-tab-view.
In both cases, when tabBarScrollEnabled is true the top tabs don't switch on first press/tap in both modules, they only switch when double-pressed. They seem to be waiting for the indicator/centering animation to end before the press allows to switch to another tab. This issue only arises on Android via Expo.
Expected behavior
I am expecting the tabs to switch when pressed once even with tabBarScrollEnabled set to true.
Reproduction
https://github.com/roccosiffredi/react-native-tab-view/blob/main/example/src/ScrollableTabBarExample.tsx
Platform

[X] Android
[ ] iOS
[ ] Web
[ ] Windows
[ ] MacOS

Environment

package
version

react-native-tab-view
^3.1.1

react-native-pager-view
5.0.12

react-native
0.63.4

expo
^42.0.0

node
v14.15.3

yarn
1.22.10

repo is updated: https://github.com/roccosiffredi/react-native-tab-view/blob/main/example/src/ScrollableTabBarExample.tsx

Issue still exists after upgrading the indicated packages to their latest versions.

same issue

issue still present


ConflictingDomainExists

Encountered this issue when trying to deploy a tenant. I have three services, one is public and the other two are private. The onboarding process failed for one of the private service with this error appeared in cloudformation

branch: main

Hi @qwudssd , is this reproducible in your environment? If so, please provide in detail the configurations you have set for your environment, including the tiers, appConfig, and tenant onboardings.

Hi @PoeppingT yes i tried to onboard a tenant again just now and then the issue appeared again. Here are the pictures of the tiers, app configs and tenant settings. And only tellread is configured to provision a file system. On the onboarding page, i just noticed that the status of one of the tenants 'tenant' changed from failed to deploying today w/o any changes on the app config or images, not really sure why

Thanks for the information @qwudssd , I can successfully reproduce the issue. It looks like this is due to each tenant-onboarding-app stack attempting to create a private ServiceDiscoveryNamespace attached to the tenant VPC when only one is allowed. The proper solution for this is to either create the ServiceDiscoveryNamespace in the tenant-onboarding stack or create a custom resource to only create the ServiceDiscoveryNamespace if it does not already exist in the tenant-onboarding-app stack.
Unfortunately there is currently no workaround for this, other than to make one of your private services public. We are working on a fix.

okay i see, thank you!


Make switch a state machine

Getting this pushed up for visibility while I work on cleanup and add some additional tests.
Goal
This PR updates libp2p-switch to be a state machine, including its connections #24.
Updates

Switch will now emit start, stop, and error events. Callback legacy support is included.
Incoming connections will now ensure crypto is done before other muxing. Resolves #239 .
Outgoing and Incoming connections are now state machines. Rather than being internally, automatically driven, they are driven by dialer.js and handler.js respectively. This allows finer control over transitions and helps provide clarity around when and where errors occur.
Adds in some error standardization via the err-codes module
Fixed readme links

TODOs

[x] There is redundant logic with the new Connection FSMs that needs to be cleaned up.
[x] Add more, thorough tests for each of the connection FSMs.
[x] Ensure incoming connections are being properly reused
[x] General TODO cleanup
[x] Add class-is module and remove instanceof logic, as it's unreliable across package versions.

Thoughts on Future Additions

As error codes are added throughout the system, have the FSMs handle fatal and non fatal errors appropriately.
Add hooks for new connections to allow modules like the connection manager, to make intelligent decisions about those connections (dial backoffs, etc).

References

Libp2p State Machine#98

Required by https://github.com/libp2p/js-libp2p/pull/257

@diasdavid @pgte @vasco-santos I've still got some cleanup to do per my notes in the PR overview, but I'd love to get some feedback on the overall implementation of the FSM. There may be some considerations I've missed that we could roll into this update.

After reviewing the crypto logic in switch as it currently is, we're not actually supporting multiple crypto modules on dial, only on listen. This needs to be corrected, but after doing some small changes in this branch I think it should wait until this is done as it's a significant change. That will enable us to review those changes more easily to ensure they're done properly.
Also, since secio is currently our only crypto library in libp2p this isn't a critical need.

@vasco-santos this should be ready for final review. I have this branch integrated in https://github.com/libp2p/js-libp2p/pull/257, which should also be ready for review.

@vasco-santos I updated the order in the readme and fixed the improper usage of jsdocs @fires on individual methods and updated those events on the Switch class itself.


No way to jump on computer

This is cool. Just played the new version but no way to jump on computer. https://princejs.com/

Which browser do you use?
I tested it on Chrome and it works perfectly fine...
Can you recheck?
Jumps are performed using the UP arrow key. In combination with LEFT/RIGHT you can jump across...

Jump is performed using cursor key "up"


Can not play Apple Music Playlist

What version of Music Assistant has the issue?
2.1.0b1
What version of the Home Assistant Integration have you got installed?
2024.5.1
Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

[X] Yes

The problem
Browsing Apple Music Playlists is possible but i can not open them or play them
How to reproduce
Connect to Apple Music
Browse Playlists
Try to open a Playlist
Music Providers
Apple Music
Spotify
Player Providers
Home Assistant
Full log output
MA_Apple_Music_Playlist_.txt
Additional information
No response
What version of Home Assistant Core are your running
2024.5.5
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Generic x86-64 (e.g. Intel NUC)

@MarvinSchenkel

Can you please provide the apple music link (from music.apple.com) to the playlists that are not working? I think there's something wrong with personal playlist vs. Apple music playlist.

Here are some examples from my personal playlists:
https://music.apple.com/library/playlist/p.0vPsVqYNbM
https://music.apple.com/library/playlist/p.aRbhERJABW
https://music.apple.com/library/playlist/p.xYv6I46vaBq
This is a apple playlist wich can i can also not play (added to my favourite playlists)
https://music.apple.com/library/playlist/p.EmvkSzpB03M

Author

Could you make those playlists public, so I can see them?

You should see them on my profile @ubur

That is going to a GitHub profile?

That is going to a GitHub profile?

It's my Apple Music Profile Name

I am having a similar issue, but perhaps presents different.  I can open the playlist, but will recieve an error "tracks not found".  This happens with the apple playlists, but not always.  i.e. some work and some don't.  Oddly the only ones that I get the playlist picture don't work.  The ones that do work none get the playlist picture.  logs below.
2024-05-29 16:53:31.829 ERROR (MainThread) [music_assistant] Error doing task: Task exception was never retrieved Traceback (most recent call last):   File "/usr/local/lib/python3.12/site-packages/music_assistant/server/controllers/media/base.py", line 98, in add_item_to_library     await self.mass.metadata.get_metadata(item)   File "/usr/local/lib/python3.12/site-packages/music_assistant/server/controllers/metadata.py", line 334, in get_metadata     await self.get_playlist_metadata(item)   File "/usr/local/lib/python3.12/site-packages/music_assistant/server/controllers/metadata.py", line 265, in get_playlist_metadata     playlist_items = await self.mass.music.playlists.tracks(playlist.item_id, playlist.provider)                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/usr/local/lib/python3.12/site-packages/music_assistant/server/controllers/media/playlists.py", line 62, in tracks     tracks = await self._get_provider_playlist_tracks(              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/usr/local/lib/python3.12/site-packages/music_assistant/server/controllers/media/playlists.py", line 379, in _get_provider_playlist_tracks     for item in await provider.get_playlist_tracks(item_id, offset=offset, limit=limit):                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/usr/local/lib/python3.12/site-packages/music_assistant/server/providers/apple_music/__init__.py", line 253, in get_playlist_tracks     for track in await self._get_all_items(endpoint, include="artists,catalog"):                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/usr/local/lib/python3.12/site-packages/music_assistant/server/providers/apple_music/__init__.py", line 534, in _get_all_items     result = await self._get_data(endpoint, **kwargs)              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/usr/local/lib/python3.12/site-packages/music_assistant/server/helpers/throttle_retry.py", line 72, in wrapper     return await func(self, *args, **kwargs)            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/usr/local/lib/python3.12/site-packages/music_assistant/server/providers/apple_music/__init__.py", line 556, in _get_data     raise MediaNotFoundError(f"{endpoint} not found") music_assistant.common.models.errors.MediaNotFoundError: me/library/playlists/pl.c74ebd652d9f40a1b92dec44dc422a32/tracks not found 2024-05-29 16:53:33.811 ERROR (MainThread) [music_assistant.webserver] Error handling message: music/playlists/playlist_tracks: me/library/playlists/pl.c74ebd652d9f40a1b92dec44dc422a32/tracks not found
Don't mean to hijack, but also don't want to spam if it is the same root cause.  Let me know if I should open another issue.
Thanks.  and BTW, this is awesome!

I am having a similar issue, but perhaps presents different. I can open the playlist, but will recieve an error "tracks not found". This happens with the apple playlists, but not always. i.e. some work and some don't. Oddly the only ones that I get the playlist picture don't work. The ones that do work none get the playlist picture. logs below.
2024-05-29 16:53:31.829 ERROR (MainThread) [music_assistant] Error doing task: Task exception was never retrieved Traceback (most recent call last): File "/usr/local/lib/python3.12/site-packages/music_assistant/server/controllers/media/base.py", line 98, in add_item_to_library await self.mass.metadata.get_metadata(item) File "/usr/local/lib/python3.12/site-packages/music_assistant/server/controllers/metadata.py", line 334, in get_metadata await self.get_playlist_metadata(item) File "/usr/local/lib/python3.12/site-packages/music_assistant/server/controllers/metadata.py", line 265, in get_playlist_metadata playlist_items = await self.mass.music.playlists.tracks(playlist.item_id, playlist.provider) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/music_assistant/server/controllers/media/playlists.py", line 62, in tracks tracks = await self._get_provider_playlist_tracks( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/music_assistant/server/controllers/media/playlists.py", line 379, in _get_provider_playlist_tracks for item in await provider.get_playlist_tracks(item_id, offset=offset, limit=limit): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/music_assistant/server/providers/apple_music/__init__.py", line 253, in get_playlist_tracks for track in await self._get_all_items(endpoint, include="artists,catalog"): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/music_assistant/server/providers/apple_music/__init__.py", line 534, in _get_all_items result = await self._get_data(endpoint, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/music_assistant/server/helpers/throttle_retry.py", line 72, in wrapper return await func(self, *args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/music_assistant/server/providers/apple_music/__init__.py", line 556, in _get_data raise MediaNotFoundError(f"{endpoint} not found") music_assistant.common.models.errors.MediaNotFoundError: me/library/playlists/pl.c74ebd652d9f40a1b92dec44dc422a32/tracks not found 2024-05-29 16:53:33.811 ERROR (MainThread) [music_assistant.webserver] Error handling message: music/playlists/playlist_tracks: me/library/playlists/pl.c74ebd652d9f40a1b92dec44dc422a32/tracks not found
Don't mean to hijack, but also don't want to spam if it is the same root cause. Let me know if I should open another issue. Thanks. and BTW, this is awesome!

Can you provide some examples of playlist that are not working? If those playlists are your own, please make them public so I can access them and try to reproduce it.

@MarvinSchenkel Are you able to access my playlists?

@MarvinSchenkel Are you able to access my playlists?

Well no, I cannot find your username on apple music if I search for it and the playlists you linked are not public:

Can you maybe mark them as public?

If i follow this guideline there is no  setting like make public.
This is how it looks like in my profile:

Where can i configure to make a playlist public?

If i follow this guideline there is no setting like make public.
This is how it looks like in my profile:
Where can i configure to make a playlist public?
There are two things we can try:

Open apple music via the web on a laptop and edit the playlist > make visible on profile:

If that doesn't work, we can try to get the 'share link' of the playlist. E.g.

Sure, here are a few.  All of them are Apple Music playlists so should be accessible directly.
https://music.apple.com/us/playlist/pure-chill/pl.c74ebd652d9f40a1b92dec44dc422a32
https://music.apple.com/us/playlist/acoustic-memories/pl.97b3398e05f74257ac03d013b4726668
Just noticed something while I was pulling these.  Both have double entries (two playlists, one with "https:/..." one with just "p..."  neither work, but the first does get the playlist picture.
This one also doesn't work, but only a single entry and no playlist picture. https://music.apple.com/us/playlist/classic-rock-essentials/pl.1a7fd42205674dd282d106f533f4bea6
But this one works just fine but with no playlist picture, go figure! https://music.apple.com/us/playlist/dont-mess-with-texas/pl.3e854cd2fea14eadb57be1187e40dda1
The one thing they all have in common for me is that they are Apple Music playlists.  The apple playlists that I renamed locally (broke the link) all work.  even if I didn't change a song.

If i follow this guideline there is no setting like make public.
This is how it looks like in my profile:
Where can i configure to make a playlist public?
There are two things we can try:

Open apple music via the web on a laptop and edit the playlist > make visible on profile:

If that doesn't work, we can try to get the 'share link' of the playlist. E.g.

I already share the playlist "Elektro"

Here is in addition the link via share button:
https://music.apple.com/de/playlist/elektro/pl.895a00b8490f42e1b01ad8db237fe451

Thanks everyone! Managed to reproduce it and already implemented a fix. Hang tight for the next beta to re-test it :-)

Beta 2 has just been released. Could you please retest? Be sure to completely remove and re-add the apple music provider after installing the new beta.

Beta 2 has just been released. Could you please retest? Be sure to completely remove and re-add the apple music provider after installing the new beta.

Great news, thanks a lot for your quick fix!

Beta 2 has just been released. Could you please retest? Be sure to completely remove and re-add the apple music provider after installing the new beta.

I removed Apple Music Provider and reinstalled the Add-On. Then i integrated the provider again. Unfortunately i am not yet able to open a Playlist.
2024-06-05 20:24:07.707 ERROR (MainThread) [music_assistant.webserver] Error handling message: music/playlists/get_playlist: playlist://p.aRbhERJABW not found on provider apple_music 2024-06-05 20:24:41.810 ERROR (MainThread) [music_assistant.webserver] Error handling message: music/playlists/get_playlist: playlist://p.NJYLhP6ERJD not found on provider apple_music 2024-06-05 20:25:29.473 ERROR (MainThread) [music_assistant.webserver] Error handling message: music/playlists/get_playlist: playlist://p.aRbhERJABW not found on provider apple_music
I am not sure if i made everything correct?

Are you absolutely sure you updated the addon and properly removed and readded the provider? If so, please enable debug logging, try again and provide a full log so I can see some more details

Sorry for the confusion. My fault but i can confirm that i can now open my playlists. My self created as well as Apple playlists.
So it's working!
Thanks a lot! It's so cool to be able now to play music from Apple Music!!!

Sorry for the confusion. My fault but i can confirm that i can now open my playlists. My self created as well as Apple playlists. So it's working!
Thanks a lot! It's so cool to be able now to play music from Apple Music!!!

Awesome! No worries, happy it's all working well!

Much improved but sadly still having issues.
Each of the playlists started pulling tracks just fine until it tried to fetch the third page (101-150 presumably) and I got the same error as before.  Was wondering if there is a limit and took a look at each of the playlists and they all have exactly 100 tracks.  So I am thinking just a bit of cleanup on the eof or something.
But
I attempted to play one of the playlist and received an error "No playable items found".  Same on all of the other playlists.  So I played one of my own playlists and everything work as expected.
I then went back to one of the apple playlists and played just a single track off of the playlist and it played just fine.  Once again attempted to play the playlist and same error.  I double checked to make sure the "shuffle" wasn't on just in case it was something with the total tracks and randomizer.
Anyway hope that helps

Much improved but sadly still having issues.
Each of the playlists started pulling tracks just fine until it tried to fetch the third page (101-150 presumably) and I got the same error as before. Was wondering if there is a limit and took a look at each of the playlists and they all have exactly 100 tracks. So I am thinking just a bit of cleanup on the eof or something.
But
I attempted to play one of the playlist and received an error "No playable items found". Same on all of the other playlists. So I played one of my own playlists and everything work as expected.
I then went back to one of the apple playlists and played just a single track off of the playlist and it played just fine. Once again attempted to play the playlist and same error. I double checked to make sure the "shuffle" wasn't on just in case it was something with the total tracks and randomizer.
Anyway hope that helps

Are you sure you properly removed the entire provider and re added it? Might be that there were some left over faulty playlists in your MA library. If that seems fine, could you enable debug logging and find a playlist that doesn't work, share its URL and any logs related to the error?

One of my playlists has almost 300 tracks and i am able to scroll through the playlist and play e.g. the last title from the playlist. So on my side no issues with a playlist larger than 100 titles.

Doh!  My bad.  No I didn't remove the provider and re-add.  Just rushed in and tested.  Just remove/re-add was not enough so in the process of re-installing the add-in.  But, HA just updated the supervisor and it won't let me do that till I update.
So, fixing my blunder is still in-process.  back soon.

Still no joy, same issue.  To be clear, it is just those Apple playlists that have exactly 100 songs.  I found one with 129 songs and it was fine, no error scrolling, and no problem playing the playlist.  Unfortunately for me, a number of the Apple playlists I like have EXACTLY 100 songs.
Removed and re-added the add-on as well as the Apple Music Provider.  Twice, actually, for some reason the playlists never loaded the first time.

BTW, love that the playlist pictures are coming across now.

Still no joy, same issue. To be clear, it is just those Apple playlists that have exactly 100 songs. I found one with 129 songs and it was fine, no error scrolling, and no problem playing the playlist. Unfortunately for me, a number of the Apple playlists I like have EXACTLY 100 songs.
Removed and re-added the add-on as well as the Apple Music Provider. Twice, actually, for some reason the playlists never loaded the first time.

So.. Wat exactly is the issue that remains after you had reinstalled the addon? I also noticed that for example the Classic rock playlist has exactly 100 songs. It seems to load fine here.

Hmm, so it is just me.  I will completely nuke it and reload everything to see if that helps.  Here are some details.
Apple Music playlists with exactly 100 songs (at least all I have tried) appear to load just fine but when pressing the play button on the playlist screen I receive the error "No playable items found".  If I scroll down to the bottom of the playlist I get ...tracks not found.  The log shows:
2024-06-06 07:48:36.070 WARNING (MainThread) [music_assistant.player_queues] Skipping Playlist(item_id='20', provider='library', name='Classic Rock Essentials', version='', sort_name='classic rock essentials', uri='library://playlist/20', external_ids=set(), media_type=<MediaType.PLAYLIST: 'playlist'>, provider_mappings={ProviderMapping(item_id='pl.1a7fd42205674dd282d106f533f4bea6', provider_domain='apple_music', provider_instance='apple_music--iTp3bC4o', available=True, audio_format=AudioFormat(content_type=<ContentType.UNKNOWN: '?'>, sample_rate=44100, bit_depth=16, channels=2, output_format_str='?', bit_rate=320), url=None, details=None)}, metadata=MediaItemMetadata(description="Immortal radio smashes spanning the â€™60s all the way to the '90s.", review=None, explicit=None, images=[MediaItemImage(type=<ImageType.THUMB: 'thumb'>, path='https://is1-ssl.mzstatic.com/image/thumb/Features/v4/0b/ca/8a/0bca8aff-bb5a-5845-040b-b274a09e2516/eb19a238-36fe-4f02-bbcb-2652b59e752e.png/{w}x{h}SC.CAESS02.jpg', provider='apple_music--iTp3bC4o', remotely_accessible=True), MediaItemImage(type=<ImageType.FANART: 'fanart'>, path='/data/collage_images/751a398ab0d34ec4ad065c226cb6b754_fanart.jpg', provider='builtin', remotely_accessible=False)], genres={'Arena Rock', 'Hard Rock', 'Music', 'Metal', 'Rock', 'Blues-Rock'}, mood=None, style=None, copyright=None, lyrics=None, label=None, links=None, chapters=None, performers=None, preview=None, popularity=None, cache_checksum='2018-07-13T22:47:47Z', last_refresh=1717676832), favorite=True, position=None, owner='me', is_editable=0): catalog/us/playlists/pl.1a7fd42205674dd282d106f533f4bea6/tracks not found
2024-06-06 07:48:36.070 ERROR (MainThread) [music_assistant.webserver] Error handling message: player_queues/play_media: No playable items found

FYI, completely removed and re-built the add-on with an HA restart in the middle and getting the same results.  Apple playlists with > 100 or < 100 songs work just fine.  But if it works for you then something else must be up.
Only thing I can think of is to bring up MA in docker on a different machine architecture and see if it is different.  Unfortunately will be out for the next few days.
Let me know if you have any other thoughts on how to troubleshoot from my end

FYI, completely removed and re-built the add-on with an HA restart in the middle and getting the same results. Apple playlists with > 100 or < 100 songs work just fine. But if it works for you then something else must be up.
Only thing I can think of is to bring up MA in docker on a different machine architecture and see if it is different. Unfortunately will be out for the next few days.
Let me know if you have any other thoughts on how to troubleshoot from my end

Just did some tests, I can reproduce this. Just to verify, the syncing of all playlists works fine now? The only issue you occur is with hitting 'play' on specific playlists (the ones with exactly 100 songs)?

Yes, syncing of all playlists works fine.  Issue is hitting 'Play' or attempting to scroll past the end of apple playlists with exactly 100 songs.

Yes, syncing of all playlists works fine. Issue is hitting 'Play' or attempting to scroll past the end of apple playlists with exactly 100 songs.

Crystal clear! Will try to find some time this week to fix it

Just FYI.  Installed the latest beta 2.1.0b3 and now none of my playlist will play "No playable items found".  Did the full uninstall/re-install and same.

same bug. just today setup apple music provider.

Beta 4 is coming out soon with a lot of fixes including this one

2.1.0b4 is released please confirm if this is fixed

All of the playlists I tested, including those with exactly 100 songs, play as expected.
Two notes though:

I am no longer testing with the beta add-on, but running in a separate docker.  Ran into an issue that would not allow it to run on that hardware (logged separately) with airplay.
I still had the issue of when scrolling past the end on those apple playlists with exactly 100 songs I would get an error.  No issue for other playlists.  However, it does recover and plays without issue.

All of the playlists I tested, including those with exactly 100 songs, play as expected.
Two notes though:

I am no longer testing with the beta add-on, but running in a separate docker.  Ran into an issue that would not allow it to run on that hardware (logged separately) with airplay.
I still had the issue of when scrolling past the end on those apple playlists with exactly 100 songs I would get an error.  No issue for other playlists.  However, it does recover and plays without issue.

Yep I can confirm 2. Will fix this for the next beta

beta 5 working great.  No issues with the scroll, everything playing and really like that the artwork is pulled straight away.
Thank you!


Would you please fix the Z fighting for the Classic Model?

As comparison with the VanillaTweaks iron bars on the right :

Same happen with the horizontal bars :

You can use VanillaTweaks (in the bottom Category of the website) fix bar as reference.
Honestly I like your classic model than the 3D one but it have Z fight as screenshot (i found the file in on your jar!).
Maybe you can add config option to choose between 3D and 2D in the config menu?
Thank you very much! (1.18.2)

I've published 3.2.0 on GitHub Releases, can you check if the z-flight still persists?
Additional Bars 3.2.0

@gamma1772 it is now vertical fixed but somewhat make the horizontal have Z-fight instead :

Uploaded 3.3.1 to GitHub releases, should fix this and #13

Uploaded 3.3.1 to GitHub releases, should fix this and #13
Work perfectly now, thank you!

Awesome!


Remove

What
This PR removes the guidance to use calls for evidence as part of a consultation content type, as call for evidence is now live.
Text before

New text
Use this for consultations following the consultation principles.
Do not user for calls for evidence. If you are not sure, ask your legal team before uploading your content
Why
To ensure guidance to publishers is clear. We now do not advise to use a consultation content type to produce a call for evidence, so this is a text update
Trello card
https://trello.com/c/YCr9rinL/1303-update-current-guidance-on-consultations-in-whitehall
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
Follow these steps if you are doing a Rails upgrade.

@ollietreend @ryanb-gds - Barbara suggested I squash the commits for this, so I worked out how to do that and have raised this new PR to remove the call for evidence guidance from consultations. Could you check and merge for me tomorrow please?


refactor(bundler): switch to notarytool, closes #4300

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[x] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[ ] No

Checklist

[x] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[x] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ ] I have added a convincing reason for adding this feature, if necessary

Other information

It will break anyway in a couple months...

true but we could have a soft migration at the moment instead of breaking their CI early on.

tbh i feel like it's too late for that now, especially with our slow-ish release cycle

We could also look for the API key file on the known paths Apple used to look for it...


Feature/support comma separated version file paths

Addresses https://github.com/TriPSs/conventional-changelog-action/issues/43
@TriPSs please, review everything and let me know of any additional changes that need to be made before merging

Pr looks good, thanks for your contribution!


by argument not working for hist plot

I'm working on updating the docstrings for the hist plot. I would expect the by argument to work similarly to how it works for other hvPlot plots and/ or similarly to how it works for Pandas plot https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.plot.hist.html.

But it seems to have no effect.
With by

import hvplot.pandas # noqa
import pandas as pd
import numpy as np
age_list = [8, 10, 12, 14, 72, 74, 76, 78, 20, 25, 30, 35, 60, 85]
df = pd.DataFrame({"gender": list("MMMMMMMMFFFFFF"), "age": age_list})
df.hvplot.hist(y=["age"], by="gender")

Without by

import hvplot.pandas # noqa
import pandas as pd
import numpy as np
age_list = [8, 10, 12, 14, 72, 74, 76, 78, 20, 25, 30, 35, 60, 85]
df = pd.DataFrame({"gender": list("MMMMMMMMFFFFFF"), "age": age_list})
df.hvplot.hist(y=["age"])

Looking at the code here:
https://github.com/holoviz/hvplot/blob/17ce0cc18a0393ae82d3a9f6f11b3bc4cad29b30/hvplot/converter.py#L1623-L1637
It seems to not be supported when y is a list or tuple, so making by making ´y´ a string "fixes" it.

A small note is there is no indication of overlap:

With alpha on:

Thanks @Hoxbro . I'm trying to move more into hvplot and understand the intention.

Is it fair for me to expect it to work in this case?
Is it a bug? Should it be fixed?
Can I expect .hvplot to be a drop in replacement for Pandas .plot? Or is it "just" something with a similar api, where I should expect to have to adjust some of my code if I migrate from .plot to .hvplot?.

I think it is fair to work in this case or raise an error that by does not work when y is a list/tuple.
See the answer above.
In theory and in general, I would say yes. But in practice, it is not always possible. The pandas.plot API is a moving target and could change. Furthermore, consistency between different plot kinds could overrule how pandas do it. hvplot also gives more default values than pandas do.

For this example, it is harder to get the desired output. But try to make a scatter plot with your DataFrame with the index on the x-axis and age on the y-axis. With hvplot, it is as easy as df.hvplot.scatter(y="age"). It is a bit harder to get it working with pandas.plot I could get it to work with df.reset_index().plot.scatter(x="index", y="age").
If we then want to color the scatter based on gender, we can do it with:  df.hvplot.scatter(y="age", c="gender") or df.hvplot.scatter(y="age", by="gender"). I couldn't find an easy way to do this with pandas.plot (though there properly is a way to do it).

For the original question you can get the same output as pandas by using subplots: df.hvplot.hist(y="age", by="gender", subplots=True).cols(1). Which is not the way to do


AUTH-6000 added options_preflight_bypass to access_applications

Description
Has your change been tested?
Unit tests and linking to a dev build of the tf provider
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] This change is using publicly documented in cloudflare/api-schemas
and relies on stable APIs.

i'm not seeing this in the documentation; are you able to link me by any chance?

i'm not seeing this in the documentation; are you able to link me by any chance? otherwise, lgtm.

It's going out in this release https://jira.cfdata.org/browse/CR-866245 which should go tomorrow


ImportError: No module named utils

Tests now failing with:
  File "/home/shippable/build_ve/python/2.7/src/django-bootstrap3-datetimepicker/bootstrap3_datetime/widgets.py", line 2, in <module>
    from django.forms.utils import flatatt
ImportError: No module named utils

Introduced here:
https://github.com/nkunihiko/django-bootstrap3-datetimepicker/commit/4e2fa200058820b301b161844e5a012863c80f0b
Fixable with PR https://github.com/nkunihiko/django-bootstrap3-datetimepicker/pull/35, or https://github.com/nkunihiko/django-bootstrap3-datetimepicker/pull/34

i have the  same  problem...
File "/vagrant/src/project/app/cloudcheck/forms/myForm.py", line 7, in
from bootstrap3_datetime.widgets import DateTimePicker
File "/vagrant/eggs/django_bootstrap3_datetimepicker-2.2.3-py2.7.egg/bootstrap3_datetime/widgets.py", line 2, in
from django.forms.util import flatatt
`

Same here.

same

Django 1.9 renamed "django.forms.util" to "django.forms.utils"
I think should fix the import error

~\Envs\MSUM\Lib\site-packages\bootstrap3_datetime\widgets.py on windows ,
Add s after util. It should work perfectly

merge this please.

Please merge this

Problem is stll open! @nkunihiko Merge it, please!

Still an issue.

Still an issue

in the terminal type pip install django-bootstrap3-datetimepicker-2

Still an issue


widelands 1.1

Checklist

[x] Checked the nixpkgs master branch
[x] Checked the nixpkgs pull requests

Project name
nix search name: widelands
current version: 1.0
desired version: 1.1
Notify maintainers
maintainers: @jcumming
Note for maintainers
The widelands devs sent us an email about the release. I think this is a first for me.

Dear package maintainers,
the Widelands Development Team is proud to announce that a new version
of Widelands, 1.1, has been released.
Widelands is a free, cross-platform economy strategy game in which
players control the fate of a small tribe that can grow into a big
empire, in a style of play that is unique in the open source world.
Please visit our homepage at https://www.widelands.org to learn more.
The source code for release 1.1 as well as the full release statement
can be found under the following link:
https://github.com/widelands/widelands/releases/tag/v1.1
There have been several changes to the dependencies of Widelands since
the release of version 1.0:

Minizip is now an optional and recommended dependency. If it is
packaged on your system, please use it as a dependency. If Widelands
does not detect it as a system library, the embedded minizip sources
will be used.
Boost is no longer a dependency.
Asio is a new dependency. On systems where Asio is not packaged, you
can use the utils/download_asio.sh script to pull in the sources
before compiling.
Generated binaries are now placed in standards-compliant directories.
Visit https://github.com/widelands/widelands/pull/5359 to learn more in
case you need to update any paths.
I would like to note that Lua is not a dependency for Widelands. We
ship a complete non-standard Lua implementation with the source code.

Please update your packaging workflows accordingly.
We would greatly appreciate it if the new version was picked up into the
repositories of the various operating systems and distributions.
Thank you very much!
Best regards,
Benedikt Straub

I'm working on a PR for this (and once I figure out the github UI, I'll assign it to myself)..

Closing since https://github.com/NixOS/nixpkgs/pull/197492 fixes this. Please reopen if I'm wrong.


WIP: fix linting errors reported by hadolint

Hadolint is a nice too to detect common pitfalls in Dockerfiles. If desired I can add it to the travis file as well.

I restarted the build multiple times but there are always 1 or 2 tests not ok.
Can you have a look?

Sorry, have not seen it's still a WIP.

With the last commit the tests should be green now.  Apart from fixing hadolint warnings (and ignoring some others) I have added some todos to the code for items that should be refactored/changed.
I would suggest to squash before merge. If you want I could also split todos from the linting.

hm.. now there are test failures around opendkim. I am going to split my changes into multiple prs and am going to create issues for my todos.

Closing here since I already created the followup prs.


CRAYSAT-1799: Deprecate sat swap switch/cable

Summary and Scope
Deprecate the sat swap switch and sat swap cable commands and refer the user to the Slingshot Operations Guide for information on the Orchestrated Maintenance feature instead.
For now, this is only a deprecation and a prompt, but the user can still continue with sat swap switch/cable if they want. In the future, we will remove the ability to continue with the logic in sat swap and just log the deprecation message as an error or remove the command entirely.
Also log the same warning for the sat switch command which was just an alias for sat swap switch.
Issues and Related PRs

Resolves CRAYSAT-1799

Testing
Tested on:

Local development environment

Test description:
Tested running sat swap switch, sat swap cable, and sat switch in a local virtual environment and confirmed that the appropriate messages were logged and the prompt worked as expected.
Risks and Mitigations
Low risk. This adds a warning log message and a prompt. There is already a prompt in sat swap by default, so it seems unlikely to disrupt users. The only issue would occur if somebody had scripted sat swap switch/cable commands with the --disruptive option. That would not skip the deprecation prompt, but we really do want to bring this to the users' attention so they switch over to Slingshot Orchestrated Maintenance.
Pull Request Checklist

[x] Version number(s) incremented, if applicable
[x] Copyrights updated
[x] License file intact
[x] Target branch correct
[x] CHANGELOG.md updated
[x] Testing is appropriate and complete, if applicable
[x] HPC Product Announcement prepared, if applicable

I forgot to update the unit tests. I'll do that still. I will also update the man pages and usage info.


feat(openchallenges): add CI workflow for updating the DB dump files on a daily cadence

Fixes #2485
Fixes #2418
Changelog

add script for pulling data from the OC Data Google Sheet, cleaning it up, then dumping it into CSV files
add CI workflow to update the DB CSV files daily and open a PR
add Google client (GC) credentials file (needed for gspread Python library) to .gitignore

[!NOTE]
I need to figure out how to add and use schematic as a step, but the workflow as-is achieves the goal of updating the CSV files (see screenshots below).

Preview

Example PR:

Files updated:

TODO for repo admin
The CI workflow uses two secrets:

secrets.GC_JSON - used to create credentials file for the Google client APIs
secrets.GITHUB_TOKEN - used to push changes and create PR

From what I can tell with the other workflows, GITHUB_TOKEN is already set so no further action is required here.
For GC_JSON, the credentials will be shared over LastPass (see Shared-OpenChallenges > Google Service Account JSON Key).  The key will need to be added as-is (in JSON format) as a secret to this repo.

@tschaffter : Another "improvement" I have in mind would be to create an Nx project that enables developers to perform this task locally.

Oh yes, looking back at a similar ticket (from ages ago 🤣 ), you made a note about creating a project for this resource.  I will look into it after this PR - thanks!!

@tschaffter : An improvement would be to add steps to the workflow that check if a DB update PR already exists. If it does, the PR could be updated (preferred) or closed before opening a new one (more noise on the notification side).

This makes sense.  Currently, a PR is created with a unique title based on the current date.  With your suggestion then, I should add a step where it checks for a title like * DB update - if there is one, push a new commit rather than create a new PR . Should I also update the PR title?

2/12 update
Workflow has been updated so that commits are added to the existing PR if there is already a db-update-* branch open.  Below are screenshots of what we can expect:
Use case: db-update branch does not exist

New PR created

branch and PR title will include the current date
PR will be auto-labeled with sonar-scan-approved
commit message will also include the current date

Files updated

Use case: db-update branch currently exists

Existing PR will be updated

commit message will include the current date when changes are pushed

[!NOTE]
Because I tested the workflow on the same day, the commit dates are the same in the screenshot above

Files updated

Similarly to another comments, can you prefix the feature branch name with openchallenges/db-update- (<product>/). Here I suggest using the slash as separator similarly to pr/vpchung/2404.

Can the title of the PR be updated with the latest date in case the PR content is updated?

The workflow has been further simplified by leveraging the create-pull-request action.  By using a static branch name (openchallenges/db-update in this case), the action will auto-update the PR as needed, e.g.


logoutOtherDevices only work on default guard

Laravel Version: 5.7.20
PHP Version: 7.2.12
Database Driver & Version:

Description:
I can logout other devices but it only work on default guard. When i change default guard, it work correctly.
Steps To Reproduce:

create new guard and admin table.
use logoutOtherDevices on new guard ( it not work ).
change default guard to new guard and use logoutOtherDevices on default guard ( it work) but still not work on web guard ( not a default guard)

R.I.P my english =))

it is not working in laravel 5.7
 Auth::logoutOtherDevices($data['password'], 'password');
and
 Auth::guard('web')->logoutOtherDevices($data['password'], 'password');
are ok but below code is not working
 Auth::guard('custom')->logoutOtherDevices($data['password'], 'password');
@driesvints i can't find any solution or asked question on forums or stack over flow and i test it with Auth::attempt or Auth::loginUsingId but not working
and the i comment this in middlewareGroups AuthenticateSession
and use web middelware in all routes but not working with custom guard
to solve this problem i used this answer

I'm using Laravel 7.x and 8.x, can confirm this method didn't work on custom guard, only on default (web) guard.
This is annoying, tbh.

I ran into this issue as well, the "problem" seems to lie with the AuthenticateSession middleware (which needs to be active for logoutOtherDevices to work):
It works fine when the defaultDriver is set to the guard one wants to use.
e.g. Auth::setDefaultDriver('customguard'); in the __construct() of the controller in use.
Another solution I could find is a custom middleware that simply does this as well (e.g. here).
Since some other middleware work this way (e.g. Authenticate with ...guards), maybe it would be a good solution to pass the wanted guard as a parameter? Like auth.session:customguard - if I find the time I'll try to right a proper feature request.
Now I am having the issue that I can't control where the logged out sessions are forwarded to, it throws a AuthenticationException which (I think) always defaults to redirectTo=null (here and here) and therefore the fallback named route: login, so nothing guard specific here.
I was browsing the changes for the AuthenticateSession and this commit (https://github.com/illuminate/session/commit/661d81b72fa13c9ecaa89c521ab83fe176baf2f9) states:

Added guard name for handling redirection.

But I couldn't figure out how it would?
The AuthenticationException would take a third parameter for the redirect target.


Update README that fixes #15

added PlayFramework example

Coverage remained the same at 88.421% when pulling f684a4dfc4ba3c6b00946ba28f88e8e7a9f0f963 on mirkof:patch-1 into 3b4a57844cd8a249c9ec024994da56bec787577d on MonsantoCo:master.