Possible contrast concerns regarding setting foreground colours for typography

There could be potential colour contrast concerns with setting the foreground text colour to #252525   on light backgrounds and #F8FBFD on dark backgrounds. Since WCAG 2.0 AA requires at minimum 4.5:1 contrast ratio, moving the foreground colour closer to the middle will decrease the colour contrast and likely limit the range of possible background colours (that maintain the minimum contrast ratio).
For instance with grey backgrounds, #252525   for the foreground colour can only go with as light as #8B8B8B for the background colour whereas #000000   can go as light as #757575   (where #777777   seems to be commonly used). This gets even more limiting outside of the grey backgrounds. The issue isn't so bad with #F88FBFD since it is much closer to #FFFFFF than #252525   is to #000000.
What is the rationale for choosing a dark foreground colour (#252525) that is so much lighter than the default (#000000)? If this stays the choice for the dark foreground colour, will guidance be provided on how to avoid creating contrast issues since the background colour options will be much more limited and the risk of contrast issues will be increased?

@piet0024 For us to review.

@s-duffey Why was this issue closed?


Frontend: Default to "all" if one of the input fields is empty

Context
Currently blocked by:
#82
https://github.com/Police-Data-Accessibility-Project/design-system/issues/22
Requirements

If a user leaves one field blank, the value add to the url for that variable should default to 'all' (support for this on the backend is in review https://github.com/Police-Data-Accessibility-Project/data-sources-app/pull/91)
If a user leaves both fields blank, help text should appear telling them they need to fill out at least one field

_n.b. When the QuickSearchForm component is finished, it will handle this. Hold on this work until a new design-system version is published with the new component.
Tests

Request should be successfully submitted and results should be returned with at most one blank field, currently does not return any results for a blank field

@josh-chamberlain said that @joshuagraber already fixed this. This worked for me in the https://pdap.dev/ website, so I think this issue is resolved already!

maybe already done on dev
@josh-chamberlain @kalenluciano
pdap.io/dev, yes, 2.0.4; data-sources/dev, I goofed and bumped on main, which is still on 2.0.1. That will cause conflicts when we merge dev -> main. So maybe we want to revert that PR on main and apply it to dev and deal with the conflicts there instead?

Regardless, both will need to be bumped to 2.0.5 from ^2.0.4 (note removing the caret, for ensuring install of specific version).


github.com/influxdata/influxdb/services/collectd : too many errors

Bug report
_System info:
CentOS Linux release 7.4.1708
influxdata/influxdb version:   1.4.2
Go Version : 1.8.3
_Error
Hello,
When I try to test cmd/influxd/run, it fails with
github.com/influxdata/influxdb/services/collectd
../../../services/collectd/service.go:47: undefined: api.TypesDB
../../../services/collectd/service.go:51: undefined: api.NewTypesDB
../../../services/collectd/service.go:113: s.popts.TypesDB undefined (type network.ParseOpts has no field or method TypesDB)
../../../services/collectd/service.go:118: undefined: api.NewTypesDB
../../../services/collectd/service.go:148: s.popts.TypesDB undefined (type network.ParseOpts has no field or method TypesDB)
../../../services/collectd/service.go:155: s.popts.TypesDB undefined (type network.ParseOpts has no field or method TypesDB)
../../../services/collectd/service.go:317: s.popts.TypesDB undefined (type network.ParseOpts has no field or method TypesDB)
../../../services/collectd/service.go:317: undefined: api.NewTypesDB
../../../services/collectd/service.go:369: cannot use valueList (type api.ValueList) as type *api.ValueList in argument to s.UnmarshalValueListPacked
../../../services/collectd/service.go:371: cannot use valueList (type api.ValueList) as type *api.ValueList in argument to s.UnmarshalValueList
../../../services/collectd/service.go:371: too many errors
Thank you for your help

I'm not sure what the reason is, but it looks like a compilation error. You should check to see if you have an up to date version of the library. I updated my local copy to master and compiling it still worked.


gotktrix: init at 0.1.1

Motivation for this change
Add gotktrix, a Matrix client in Go and GTK4.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Also building gets stuck on Building subPackage . Already opened an issue.

Also building gets stuck on Building subPackage . Already opened an issue.

It did build in the end.

Builds and tests fine for me!


fix command of removing setgid permission

I couldn't find your contribution guide line and I just opened a pull request.
Sorry if I'm doing something wrong.
It's really minor documentation thing, but isn't it g-s instead of u-g ?
Also, I appreciate your great work!

@ru5j4r0 Thank you for your contribution!


Add SMAC optimization method

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

Checklist

[x] The documentation is up-to-date with the changes I made.
[x] I have read the CONTRIBUTING document and completed the CLA (see CLA).
[x] All tests passed, and additional code has been covered with new tests.

Argh, SMAC needs 40s for the recommendation check....

Too many problems... I give up. The package does not seem to be standalone, as shown by the SWIG stuff, and the API does not play well with our multithreading.

OK I am back on this PR. This will be complicated but there is a strong motivation by some users :-)

If I remember correctly, we did not finish this because of dependencies which require apt-get and so on, so we did not finish. We could do something like "no CI and Nevergrad uses it if the user has installed what is necessary", maybe. SMAC was one of the best BO tools though overall BO was not very impactful.


enableLegendStateReact is amazing

I was just checking in on legend-state, and saw the new observer-less/useComputed-less React integration. Like, lol, wat? That's super neat.
My understanding is that, by hooking into this setter, you're basically getting react to give you a "beginRender" and "endRender" API, which lets you wrap every React component with the equivalent of the observer HOC behavior.
Does that sound right?
If so, I wonder if a small TLDR of that might be useful in the docs and/or source, just as a hint to others who will wonder the same "wtf does this even work?" and potentially not trust it until they understand (e.g. I thought maybe it'd require the babel plugin or something like that).
I have conflicting emotions; this is even more amazing to get SolidJS-style brevity/reactivity in React, but I don't know I'd bet/couple a large codebase to something that might break in React 19/20/etc. I suppose the worst case scenario would be to go back and add observer HOCs to components. That wouldn't be terrible.
I wonder if the React team would be open to this sort of beginRender / endRender API. Or almost like render middleware. I imagine surely they've been asked this before, multiple times, and said no, so :shrug: .
But anyway, this is not an issue, just wanted to call out how amazing this is. Great work!

Yes exactly, it's hooking into ReactCurrentDispatcher.current changing in React's internals to detect when render begins/ends. I didn't even know it was possible until I saw Preact Signals: https://github.com/preactjs/signals/blob/main/packages/react/src/index.ts
That's a great idea to describe it more in the docs - will do that soon!
This is so deep in the React internals that it seems very unlikely that it would change completely, but I'll stay on top of alpha versions to make sure it's still working. And I'm keeping in contact with the Preact team who has a similar implementation, so if there ever is an issue we could help each other. I think it would be worth discussing with the React team to enable libraries like this to work in a more officially supported way. I'll look into that 👍.
Thank you for the comment! ❤

(Leaving open until I update the docs)

This is so deep in the React internals that it seems very unlikely that it would change completely

Yeah, that's a good point.
Also great to see that Preact is using the same approach, both in terms of sharing ideas on how to keep it working in future Reacts, but also hopefully brings more weight to convincing the React team that some sort of API to help 3rd-party frameworks more seamlessly/succinctly bridge the gap from observers (or whatever state idiom the library is using) into React's hooks-only world would be worth supporting. :crossed_fingers:

I think I have basically convinced myself that "just add observerss around everything" would be a sufficient fallback/mitigation, just in case it did end up not working in future Reacts, to make it worth using/betting on today.

Yes, I agree with that. If in the worst case future there is no way to hook into the lifecycle in a similar way, observer would always be a reasonable fallback.

I added some documentation about how it works to https://legendapp.com/open-source/state/react-basics/#enablelegendstatereact. Do you think that's good or is there anything I didn't comment well?

That's great! Thanks!


fix: update some broken links

Some links on the awesometalks.party domain appeared to be broken so I updated them to use the versions hosted on Youtube (like most of the other talks).
Thanks for the great post!

wow, thanks very much Bryan!


Make it easier to debug "using P# API after transition" errors

Its an error to call a P# transition API (e.g. Goto or Raise) and then call another P# API. This can be a bit confusing because someone might assume that Goto or Raise terminate the handler with a transition, which is not true in C# (you need a return).
During testing, we could perhaps capture the point in code (e.g. file/line) of a handler's transition, so if we report the error we can point to the first transition.
Another way would be to redesign handlers to optionally return a Task<Transition>, which forces the user to explicitly return a transition in the end of a handler. But this might be more expensive and a bit tedious (if you have to propagate transitions up in the call stack).

This is related to #100.

Closing this. Something along these lines has been implemented internally and will be released in the near future.


Enable Discussions Tab in Github

Hi,
Would you consider enabling the Discussions feature on this repo at all?
It is a useful way for people to ask questions that may not necessarily represent bugs, and also triage when they are and try to pinpoint an MRE. Issues can be moved back and forth AFAIK, so issues that are not really bugs can be converted into discussions and vice versa. Also as I don't know of any official community support forum for Keras, it might serve a useful purpose there.
Thanks!

Thanks for the suggestion. Let's try it out -- I just enabled the tab.


[BEAM-4762] Add Gearpump Nexmark PostCommit scripts

Add PostCommit scripts to run Nexmark on Gearpump runner in streaming mode
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

Run Seed Job

@echauchot @kennknowles Not sure why no tests have been triggered. How to verify the added PostCommit script is working ?

@manuzhang thx for your work ! The seed job just updates the jenkins conf (syncs the scripts dir) and checks the validity of the script but does not run it. To run it 2 possibilities:

temporary enable phrase triggering. But do not forget to disable it afterwards because we chose not to enable it to avoid pollution of perfkit dashbords with manual runs
wait for a commit on master (simplest solution) and watch the jenkins emails for failures of your script.

@echauchot Which do you prefer ? It seems no harm to go with the 2nd.

@manuzhang yes 2nd is less work for you but it introduces delays (wait for the next commit)

@manuzhang use PostcommitJobBuilder instead of NoPhraseTriggeringPostCommitBuilder object in your script. See the other scripts that enable phrase triggering to know how to configure this object.

Run Seed Job

Run Seed Job

Run Gearpump Nexmark

@manuzhang don't forget that if you enable phrase triggering it will be only for testing inside this PR. Once it works you will need in the end to disable phrase triggering and wait for a commit on master to ensure that last version works. And then, I'll merge

@manuzhang also please note that you need to create 2 dashboards here (https://apache-beam-testing.appspot.com/dashboard-admin): on for gearpump in streaming mode and one for gearpump in batch mode.

@manuzhang can you please check that the post commits logs are ok and give me a status? When it is ok, disable phrase triggering and I'll approve the PR. Can you then update the dashboards. See https://issues.apache.org/jira/browse/BEAM-5986

@echauchot Sorry for the delay. It seems the jobs were aborted due to timeout. Not sure what to do in this case. Any suggestion ?

Not sure yet, it is being taken care of.

Run Gearpump Nexmark Tests

@echauchot Added streamingOnlyJob

Run seed job

Run seed job

Run seed job

Run Seed Job

Run Gearpump Runner Nexmark Tests

This requires changes from Gearpump side. Hold on.

@manuzhang please fix checkstyle

Run Gearpump Runner Nexmark Tests

Run Seed Job

Run Gearpump Runner Nexmark Tests

@manuzhang nexmark gearpump test is still running after 2h. I guess your fix did not work. Can you fix, re-test and ping me once it is working so that I merge the PR ?


[MM-9785] Fix "add user to channel" from RHS when viewing different channel on center

Summary
Fix "add user to channel" from RHS when viewing different channel on center
Ticket Link
Jira ticket: MM-9785
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed
[x] Added or updated unit tests (required for all new features)

Thanks @jespino! I realized that I should be using the channel ID based from ephemeral post and not on the currently viewing channel.


Add MSE error handling warning

R: @wolenetz
Background: https://bugs.chromium.org/p/chromium/issues/detail?id=736940

@beaufortfrancois Let me know when you've addressed wolenets' issues.

Head's-up, I'm OOO tomorrow (Pacific time, Friday June 30) through the long US holiday, returning July 5th AM.

@jpmedley @wolenetz Your feedback has been addressed at https://github.com/google/WebFundamentals/pull/4770/commits/4e9e7812330b0d0a4172101c5be8c1e52af73b4a

@wolenetz If that doesn't look good to you, please let me know and we'll update the article again.


Final text additions

This will include all text additions/modifications found in issue #48.
Will use the task list feature to keep track of progress.

Cross linking introduced to previous commits.

Addressed #51

Makes sense to make separate PR's here, since content keeps coming in and the previous is to be altered.
This PR is ready for review.


Modifications by GP 1 (Mail Hans De Keersmaecker)

RIZIV_nursingprescription_listServiceRequested20220203_feedback1.xlsx

For reference to the xls file.

superseded by #65


Cancel the build of a commit.

Oftentimes it becomes clear very early in the life of a build that it will not succeed.  In these cases, canceling the build conserves scarce resources and allows other builds to proceed.  In short, Drone, like most things, needs a CANCEL button.

:+1: That would help a lot for when a build fails, stays stuck or simply to cancel some builds when a newer version is running.

Is it still expected for v0.3 ?
With the multi build support the lack of "stop build" button is even more important as :

Drone UI don't display the slave the build is executed on
There is no way from the docker slave itself to actually tell what is the host server and display it during the build (and drone does not pass the info as an env variable e.g,)

This means that finding the server where the build is currently stuck is crazy complicated in multi-slave mode.
My 2 cents :)

:+1:

:+1:, YKWIM

BTW, here is another usecase related to this Cancel request:

we run builds and test suites under Drone
the tests hang polling for data/events when a bug is introduced
it would be very useful to terminate an active build in such cases

BTW, what happens now in such cases? Is there an internal timeout?

@os12  There is an internal timeout that you can set.
But this will still waste lots of time because you will have to wait for the full timeout. The timeout will have to be longer than the minimum time required for your build when you CI servers is busy (otherwise timeout will kill working build).
So there is this solution for blocked builds but this is a bit frustrating to watch your build blocked.

So, it sounds like the queuing time is bundled with the building time.
The former has nothing to do with the individual build though...
Also, the manually set timeouts are a maintenance burden - the code
grows, tests are added...

This is a work in progress. There are pre-requisites to this task that we are addressing.

cancel for non-matrix builds added to 0.4 ... cancel to matrix build will be pushed to 0.4.1

update: this behavior was changed to cancel a single job. If you are running a matrix (which has multiple jobs) you would need to cancel each job individually. I'm not sure if people want to cancel the entire matrix at once, or just a single job. We'll launch 0.4 as-is and see what sort of feedback we get


[RFC] High-level naming and directory structure

Directory names
This RFC is intended to start a discussion about the high-level component names used by the Bareflank hypervisor. The bulk of the hypervisor code resides under the bfvmm directory:

bfvmm/src

debug_ring
exit_handler
intrinsics
memory_manager
serial
support
vcpu
vcpu_factory
vmcs
vmxon

The last two - vmcs and vmxon - are the only names that assume an architecture. I propose that we create a new directory called vmctl (short for virtual machine control), and place the vmcs/vmxon code under an x86-specific directory. Something like

bfvmm/src/vmctl

arch-independent vmctl files
arch/

x86/

intel/

vmcs files
vmxon files

amd/

vmcb files

aarch64/

I decided on vmctl because I think that it conceptually captures what the vmcs and vmxon currently do. This directory will be the location of the state needed to manage virtual machines. A "virtual machine" is any code that runs at a less-privileged level than the VMM. The VMM is code that runs with hypervisor privileges. So on ARM, the VMM will run in normal world at EL2, and will manage code that runs in normal world at EL1 and EL0 (i.e. VMs). In Intel-speak, the VMM runs in VMX-root and a VM is any code that runs in VMX-nonroot.
If we go this route, it will probably make sense to mirror the above layout for each of the bfvmm's high-level modules. So the bfvmm would look like

bfvmm/src/<module>

arch-independent files at the top level
arch/

x86/

intel/
amd/
...

aarch64/

...

where <module> = debug_ring, exit_handler, memory_manager, etc.
Other Issues

Right now the build system treats each child directory under bfvmm/src as a module.  Without any changes to the build system, the proposed directory change would create one "vmctl" module and would effectively decrease the modularity from before. With changes that @JaredWright is making to the build system now, I think this will be relatively simple to address though.

The intrinsics directory is by far the largest directory under bfvmm. Most of the code is under include/intrinsics and it already follows a structure similar to the proposed one above. Conceptually, the intrinsics code is the software layer that interacts directly with the hardware. One issue that I have with its current location is that the code is not specific to the bfvmm, as it is also used by the extended_apis and the hyperkernel, and really it could be used by any code that needs to interact with the hardware in some way.  I think that moving the intrinsics code to the top-level would help illustrate the role that the code actually plays

I like the proposed directory name and structure for bfvmm/src/vmctl. I also like that idea as the go to directory structure for every component that contains both architecture-agnostic and architecture-specific code. For components that don't have any architecture specific code, this directory structure can still be followed by just omitting the /arch subdirectory.
An alternate solution might be to keep the current vmcs and vmxon directories structured as they currently are, but rename them to "vmstate" and "vmminit". vmstate will contain all code that represents a vm's state, and vmminit will contain all code used for initializing (turning on) the vmm.
Comments about the "Issues" section above:

The new build system should be flexible enough to support any rearranging of directories that we want to do

I really like the idea of moving the intrinsics code out of the vmm directory into it's own directory one level up (to /hypervisor). I like this idea because the intrinsics code really is a separate software layer than the vmm code: the vmm code uses the intrinsics as an API to control hardware. In the context of Bareflank, I think the current "intrinsics" directory contains what I usually refer to a hardware abstraction layer, or hal for short. Further, the word "intrinsics" is a word that leads me to think about x86 (i.e. AVX, SSE, etc) or ARM (NEON, etc) intrinsic functions/features. With all of that in mind, I think it would be good to create a new directory /hypervisor/hal, and start migrating the current intrinsics components there.

Besides maybe the gdt/idt (which can be moved to the VMM and out of the intrinsics since it doesn't make much sense in it's currently location), the bulk of the intrinsics code really is "intrinsics". A good example is the following:
https://github.com/Bareflank/hypervisor/blob/dev/bfvmm/include/intrinsics/x86/common/pm_x64.h
Things like CPUID, VMCS, MSRS CRS, etc... all take on the same form as above with the only added code bing bit manipulations on the read / written values to simplify working with these instructions (very similar to what Linux does).
Now that being said, I am a fan of getting that code out of the VMM as it could be used by more than just the VMM. I'd love to rename the SDK (since it's not that anymore), and put the intrinsics in with the other includes as we already have the vmcall intrinsics in there.

@rianquinn I am thinking of "intrinsics" in this context:
https://stackoverflow.com/a/2268599
https://en.wikipedia.org/wiki/Intrinsic_function
https://software.intel.com/sites/landingpage/IntrinsicsGuide/#
… in other words, I think of an intrinsic as something that a compiler replaces with inline instructions instead of a function call. I'm thinking of things like halt() and stop() (and the other examples you mentioned) as something different: functions that belong to a hardware control library/API.
Granted, I'm not super familiar with the intrinsics directory yet, but at a first glance, it appears that most of the stuff in their belongs to the later category. It is all linked together into the bfvmm_intrinsics library, right? Or am I missing something, and those functions somehow get inlined into the VMM modules by the compiler?
Also, the stuff that is currently in the bfsdk directory seems like a distinct layer from the stuff that is in intrinsics. At a glance (again, I'm not super familiar yet), bfsdk seem to revolve around defining interactions between VMM software components, rather than between the VMM and hardware.

Hmm... after looking a little closer at the headers in bfvmm/include/intrinsics, it looks like it does work a little different than I thought. Those really are being used as intrinsic functions that are being inlined when VMM components use them. Is that correct?

yeah, we simply implement them in NASM because GAS is horrible. Intrinsics are not always inlined BTW (although they usually are). But yeah, they are intended to be just like the Intel intrinsics you listed in the previous post, with the only real difference being that we provide the bit manipulations for the intrinsics that manage bit fields, and we also provide some additional logic for intrinsics that return error codes in RFLAGs (as there is no simple way to convert them to C or C++).
The only thing that is in there that really doesn't make sense is the IDT / GDT source code, which probably needs to find a home in the VMCS module

FYI - I'm going to start implementing some of this locally as I need this structure at this point to properly implement aarch64. I'll continue to track this RFC and modify my implementation to match if this RFC changes at all - with @JaredWright's new build system this should be flexible enough to do that easily. At this point I have no additional input, the structure as is looks good to me. One minor change I do plan to make is renaming x86 to x86_64 as that is the name currently used by the build system to identify that target; we can also use x64 (just speak up if you prefer that) but x86 is 32-bit :P

I created another sandbox repository to continue the discussion on this RFC: https://github.com/JaredWright/bfdir_structure_sandbox.
That repo is my attempt to convey personal vision of what the 'end goal' for the source tree would look like after restructuring. Thoughts @rianquinn @connojd @cpavlina? Too much for this RFC? Any small bits and peices that people like?

I'm a bit disengaged right now so I don't have much to say but I will comment on two things:

I like moving intrinsics out of bfvmm.
I'm skeptical of removing the bf- prefix. It's used pretty thoroughly in the project and removing it here would add inconsistency. Case in point:

This is bfm, but sense I'm suggesting getting rid of the "bf" prefix on all the top level directories, I don't think we could really have a directory just called "m"

The executable compiled from these sources is actually called bfm, and we can hardly call it manager as the name of the executable shouldn't be so generic when it could be installed somewhere like /usr/local/bin by a user.

My notes:

I like the intriniscs being moved outside of the VMM as that would remove some duplication.
Use of hpp I am not a fan of, and it's not really a supported naming scheme for C++ (there are many discussions on the core guidelines about this)
I am fine with respect to removing the "bf" from the folders (thats an old carry over from 1.0), but some things still need it like "bfelf_loader.h" and BFM. We don't want "m" in /bin, and we cannot use "elf_loader.h" as it will interfere with the existing ELF loader headers in Linux.
I don't like the vmm_xxx folders. The current SDK headers are used by all of Bareflank and it's extensions, not just the VMM. The bfsysroot (which I agree needs to be renamed for sure), is used by not only the VMM but also guests in the hyperkernel so it's not a VMM specific thing, and the extensions folder I am not a fan of as I prefer the extensions being in their own repo as we want the hypervisor repo to be as small as possible, otherwise I think it would lead to confusion and be a bit overwhelming.
Also you missing the driver logic (or did I miss that)

I am fine with respect to removing the "bf" from the folders (thats an old carry over from 1.0), but some things still need it like "bfelf_loader.h" and BFM. We don't want "m" in /bin, and we cannot use "elf_loader.h" as it will interfere with the existing ELF loader headers in Linux.

I feel like we're risking introducing a lot of confusing inconsistency by only using bf- when necessary to avoid naming collisions. It doesn't make much sense to me to "randomly" have some things namespaced and others just lying around in the global space because they happen not to collide with anything. Either remove it from everything (not feasible) or from nothing, IMO...

To be honest, I'm actually cool either way on this specific topic as I see it both ways so likely it just makes sense to leave the part alone

@connojd @brendank310 @RicoAntonioFelix @josephsharkey Any comments?

+1


add .mem to gitignore

Codecov Report

Merging #3 (576b44e) into main (0863b2b) will increase coverage by 1.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   70.02%   71.35%   +1.33%
==========================================
  Files           9        9
  Lines         417      412       -5
==========================================
+ Hits          292      294       +2
+ Misses        125      118       -7

Impacted Files
Coverage Δ

src/structs.jl
80.00% <0.00%> (-2.61%)
:arrow_down:

src/header.jl
69.14% <0.00%> (-0.65%)
:arrow_down:

src/genotype.jl
76.56% <0.00%> (-0.25%)
:arrow_down:

src/dosage.jl
39.53% <0.00%> (+0.17%)
:arrow_up:

src/difflist.jl
98.43% <0.00%> (+0.61%)
:arrow_up:

src/uleb128.jl
94.59% <0.00%> (+1.73%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0863b2b...576b44e. Read the comment docs.


linux: Drop unused variable c by discarding unused assignment

The compiler doesn't spot this, but guru does.
This seems to have become unused in 79e6a93624d1 ("Fix incorrect reference to
the gRPC runtime name as a binary").
Signed-off-by: Ian Campbell<EMAIL_ADDRESS>

Codecov Report

Merging #1152 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1152   +/-   ##
=======================================
  Coverage   31.88%   31.88%
=======================================
  Files          27       27
  Lines        2161     2161
=======================================
  Hits          689      689
  Misses       1324     1324
  Partials      148      148

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13f90e9...0a580cb. Read the comment docs.

LGTM


move dev env deployment job to helm repo

:clipboard: https://github.com/omgnetwork/devops/issues/407
need helm repo PR changes: https://github.com/omgnetwork/helm-development/pull/470
Overview
Instead of overriding with kubernate commands in elixir-omg CI, it nows triggers job in helm-development repo to start the deployment.

For master updates, it will trigger an update to helm-development using git sha as the app_version and change the dev env version as well. This would end up having the CircleCI jobs inside helm-development to deploy it.
For release tags changes, it will trigger an update to helm-development using semver as the app_version (same as before)

Changes

add increase_chart_version_XXX jobs for master and release
remove old deployment script and jobs

Testing
used the playground repos: https://github.com/omgnetwork/elixir-omg-boolafish-playground, https://github.com/omgnetwork/helm-development-boolafish-playground

release tag job trigger: https://github.com/omgnetwork/helm-development-boolafish-playground/pull/75
master job trigger: https://github.com/omgnetwork/helm-development-boolafish-playground/pull/73

comment first before reviewing, fanzi


Update dashboard.php

[V ] Changes have been thoroughly tested to not break existing functionality.
[ ] New functionality has been documented or existing documentation has been updated to reflect changes.
[V ] Visual changes are explained in the PR description using a screenshot/recording of before and after.

minor type fix in heb translation

Thanks


No items fetched after fetching less than invisibleItemsThreshold items

Hit this issue when using invisibleItemsThreshold = 20 with a fetcher that returns one item at a time.
This code assumes a fetch only needs to be triggered when crossing the threshold, while further fetches may be required after that one completes.

Hi @KrisBraun. A page is only requested when the trigger index item (newPageRequestTriggerIndex) is built/rebuilt. When the invisibleItemsThreshold value is too high, the trigger index item won't be at the end of the list. So, when you reach the end of the list, no more items will be fetched.

Right. My use case is that I'd like to prefetch items early at an offset greater than the fetch page size (which is non-deterministic in my case).
If there's a way to detect when new items are added, this could be handled by generating another fetch if the total remaining items is still below the threshold.

You can listen to the pagecontroller, which will send a notification when new items are added.
Is that an appropriate solution for your issue?

I think for that to work, I'd need a way to determine the number of invisible items given the current position, so I could trigger additional fetches if there are fewer than the threshold remaining. As far as I can tell, none of that is accessible through the PagingController.
The cleanest solution from my perspective (external to the implementation) would be for the PagingController to fetch additional pages until it is above the threshold.

This seems reasonable on the first glance
but I am unsure if it is desirable for the package to start making many requests like that.
I dont have time to specify this right now, but

Does this align with what we want?
Would a user be surprised by this behaviour?
Is there a situation where this would have negative effects?


Question about case in _rpmalloc_span_double_link_list_remove

I was studying the rpmalloc implementation and noticed this piece of code:
https://github.com/mjansson/rpmalloc/blob/2b300ec5cd798e9288e7a61ddeaa8f0c8e92d795/rpmalloc/rpmalloc.c#L1087-L1089
In case of head node removal, it assigns the new head, but it does not update the new head node's prev pointer.
Is this intentional or a bug?
What I would have expected:
+ span_t* next_span = span->next;
  *head = next_span;
+ if (EXPECTED(next_span != 0))
+     next_span->prev = 0;

It is intentional, as the prev pointer is only used for non-head nodes - the new head node does not need a valid prev pointer

As you can see when adding a new node the prev pointer is correctly set on the existing head node
https://github.com/mjansson/rpmalloc/blob/2b300ec5cd798e9288e7a61ddeaa8f0c8e92d795/rpmalloc/rpmalloc.c#L1070

Alright, good to know, thanks!


A single-cell and single-nucleus RNA-Seq toolbox for fresh and frozen human tumors.

Project short name:
FreshFrozenHumanTumours
Primary Wrangler:
Ami
Secondary Wrangler:
Irene
Associated files

Google Drive: https://drive.google.com/drive/folders/1EZONxSWvdqrdUZU4Hn4CMLPEOVBgCtX6

Google Sheet:
https://docs.google.com/spreadsheets/d/1mUt7-zupyi_4rk0XGnqrutQJd1LjjmUkmBVyXBJrBGc/edit#gid=1612993960

Ingest: https://contribute.data.humancellatlas.org/projects/detail?uuid=5850583c-baec-4427-8656-cd3c96c07727

Published study links

Paper: https://doi.org/10.1038/s41591-020-0844-1

Accessioned data: GSE140819 and phs001983

Key Events

[ ] Convert published metadata to HCA spreadsheet
[ ] Manually curate dataset to meet HCA metadata standard
[ ] Collect any matrix and cell-type annotation files
[ ] Upload sheet to validate metadata
[ ] Check linking using ingest graph validator
[ ] Transfer raw files to ingest to validate data files
[ ] Ask the Secondary Wrangler for an end-to-end review of the project. Ask the Expertise Wrangler to review specific tabs if needed
[ ] Submit dataset to Production
[ ] Complete the Export SOP
[ ] Convert project data to SCEA format following the SCEA conversion SOP if appropriate

Requested ontology term for specimen collection process: https://github.com/HumanCellAtlas/ontology/issues/108

Have sent the authors an email to get some clarifications.

LGTM, good job on this project! I just have three small comments:
Project:

Add the estimated cell count. They stated it in the abstract of the paper, therefore it's also available in the project description in ingest.

Donors:

Why do donors MGH123 and HTAPP-443-SMP-5491 have two different development stages? According to https://tumor-toolbox.broadinstitute.org/ HTAPP-443-SMP-5491 is pediatric and I can't find the information for MGH123

Specimen from organism:

Some of the organs are set as "waiting to hear from author". Did you get a response from the authors?

graph validating

Submitted.

Exported.

Looks ok in the browser, however:
The project is duplicated in ingest. The actual project + submission is here https://contribute.data.humancellatlas.org/projects/detail?uuid=a62dae2e-cd69-4d5c-b5f8-4f7e8abdbafa and it's missing:

technology info
organ info
flag to be in catalogue
admin info

I will add them for now to move from here but please stop creating duplicate projects, use the ones existing

Actually, it was missing publication PMID and doi so I would rather update it

Moving to needs update: as stated in this message https://embl-ebi-ait.slack.com/archives/C9XD6L0AD/p1660584420081069 the ontology_label terms for lung and blood need to be changed to lowercase

Made update to lung, blood, ovary labels (upper case to lower case)

Submitted.

Form submitted.

looks ok


Tutorial on using segmentation and annotation features?

Hi jbms,
I wanted to learn more about how to use segmentation and annotation features of Neuroglancer.  For example, drawing boundaries on an image and save it for later use.  Or what do double clicked pixels on segmentation tab do and represent. (Picking up same rgb colors from the image?)  Currently, it seems to load precomputed data but I can't seem to figure out how other features work.  Do you have a tutorial or a YouTube video which describes the general use of these features?

Thank you,
m

Unfortunately there is no tutorial or video available as far as I am aware.
You might find this example more instructive to play with:
https://neuroglancer-demo.appspot.com/#!{"dimensions":{"x":[8e-9%2C"m"]%2C"y":[8e-9%2C"m"]%2C"z":[8e-9%2C"m"]}%2C"position":[2980.186767578125%2C3153.929443359375%2C4045]%2C"crossSectionScale":2.8863709892679617%2C"projectionOrientation":[0.2747986614704132%2C0.7059817314147949%2C0.6514520049095154%2C-0.041058510541915894]%2C"projectionScale":4593.980956070107%2C"layers":[{"type":"image"%2C"source":"precomputed://gs://neuroglancer-public-data/flyem_fib-25/image"%2C"name":"image"}%2C{"type":"segmentation"%2C"source":"precomputed://gs://neuroglancer-public-data/flyem_fib-25/ground_truth"%2C"tab":"segments"%2C"segments":["158571"%2C"21894"%2C"22060"%2C"24436"%2C"2515"]%2C"name":"ground-truth"}]%2C"showSlices":false%2C"selectedLayer":{"layer":"ground-truth"%2C"visible":true}%2C"layout":"4panel"}
When you double click on a segmentation layer, the id the mouse is hovering over is "selected", and if the data source provides 3d meshes those will be displayed for the object.
As far as annotation, you can place points, lines, axis-aligned bounding boxes, and axis-aligned ellipsoids.  To create an in-memory annotation layer, control+click on the + button on the layer bar.  Then select one of the 4 icons (which select an annotation type) next to the color picker in the side bar to begin placing annotations with control+click.  None of these annotation types are particularly well suited to drawing boundaries, though.  Additionally, these annotations are just stored in memory, in the URL itself.  If you want to save them, you will have to use the Python API (see python/neuroglancer/tool and python/examples) to create your own tool.

Thank you for the information and resources to look at jbms.
I'd like to know more in detail when you say "data source provides 3D mesh". In the given example, colored 3D mesh in "ground-truth" layer is served precomputed dataset. What is the original file format used in this example before converting it into precomputed dataset? Both two layers seem precomputed but do they differ in formats and how they are generated? I suppose CloudVolume is used to convert?
Yes, I'd like to explore more with annotation feature and thank you for providing me with where (how) to start.
m

For these datasets, I generated the precomputed format using Google-internal infrastructure.  The image (electron microscopy) layer uses jpeg encoding, while the ground truth layer uses "compressed_segmentation" encoding.  The meshes are generated automatically from the segmentation.
You can write precomputed or other formats supported by Neuroglancer using tensorstore (github.com/google/tensorstore) or cloudvolume.  For generating meshes, you can use igneous (https://github.com/seung-lab/igneous), which uses cloudvolume.

Hi @manoaman, I have started putting together some video tutorials on how to use these features for the collaboration I work with at Princeton: https://brainmaps.princeton.edu/. These are public, so feel free to browse them. Note that some features (like exporting annotations to a CSV file) are not supported by the google client. We have our own public fork of Neuroglancer (source code: https://github.com/braincogs/neuroglancer/), but it is privately hosted at the moment. We plan to publicly host it in the near future. In the meantime If you are interested in using some of those features, you could clone our repo and then build and run it on your own machine/server.

Your video tutorials are really awesome!

Hi @austinhoag This is really nice.  Thank you very much for sharing the awesome tutorials and repo.  It is very helpful!

Hi @austinhoag , I'm not sure if I should be asking here but is this custom annotation volume used in this example WHS_SD_rat_atlas_v3_annotation.tif open to the public?  I didn't know tiff file could contain segmention ids and I was wondering how you created and customized in a single tiff file.  (Sorry, probably not related to this post but very curious to know how if that is generated from third party software or in-house program.)   Thank you again for the very nice tutorial and instruction.  -m

That TIFF file just contains a 3D array with integer values, but it's not a segmentation volume yet. I converted to a precomputed segmentation volume using cloudvolume in steps 2 and 3 of the notebook. That exact file is not publicly available, but it is derived from the public Waxholm space Rat brain atlas: https://www.nitrc.org/projects/whs-sd-atlas.
We did not create the original file, the organization did. If you are just looking to explore one of these segmentation volumes, a quick way is to use cloudvolume to download one of the many publicly available datasets. Many of them on the readme of this repo are very large to download, but a few smaller ones are here: https://neurodata.io/ocp/
For example, to download the z-brain atlas segmentation volume from this dataset: https://neurodata.io/data/zbrain_atlas/ (click the eye icon to open the dataset in Neuroglancer) with cloudvolume:
from cloudvolume import CloudVolume
vol = CloudVolume('precomputed://https://zbrain-s3.neurodata.io/atlas_owen',parallel=True)
# download to a numpy array
data=np.transpose(vol[:][...,0],(2,1,0))
# Save as a tiff file:
import tifffile
tifffile.imsave('./zbrain_annotation_volume.tif',data) # takes up ~ 1 GB just FYI

@jbms I realized an anatomical region name associated with a segmentation appears on the lower left of the screen when mouse enters.  Are the regions provided as part of a info file?  I wasn't sure if this is a custom feature of the Neuroglancer fork which @austinhoag mentioned.
https://neurodata.io/data/zbrain_atlas/

Showing the region names on the bottom left like that is a custom feature of that Neuroglancer fork.  However, there is similar functionality in the upstream Neuroglancer.
See this FlyEM hemibrain example: https://hemibrain-dot-neuroglancer-demo.appspot.com/#!gs://neuroglancer-janelia-flyem-hemibrain/v1.0/neuroglancer_demo_states/base.json
The cell types and abbreviated region names are shown in the layer "tab" bar, and the full region names are shown in the "Selection" panel on the right.


Validator output not including field responsible for error (version)

The following event_pointset payload
{
  "points" : {
    "crac_demand_status" : {
      "present_value" : false
    },
    "crac_temperature_setpoint" : {
      "present_value" : 25
    }
  },
  "timestamp" : "2022-03-30T15:24:27.806Z",
  "version" : 1
}

Produces the following output in the output
While converting to json node: 1 schema violations found
  1 schema violations found
    instance type (integer) does not match any allowed primitive type (allowed: ["string"])

I think this output should describe the field (version), so that if we create an exception to prevent ignore  integer version 1, it doesn't inadvertently capture other errors because the error message is not specific.

How is this being generated?  Which tool is being used?
On Wed, Mar 30, 2022 at 7:44 AM Noureddine @.***> wrote:

Assigned #283 https://github.com/faucetsdn/udmi/issues/283 to @grafnu
https://github.com/grafnu.
—
Reply to this email directly, view it on GitHub
https://github.com/faucetsdn/udmi/issues/283#event-6335813027, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIEPD7VBVKDO3K5PBZF3TTVCRSDLANCNFSM5SCF2K3Q
.
You are receiving this because you were assigned.Message ID:
@.***>

bin/validator with a pubs subscription

https://github.com/faucetsdn/udmi/pull/286

While converting to json node: 1 schema violations found
  1 schema violations found
    instance type (integer) does not match any allowed primitive type (allowed: ["string"])

I searched for this error here, and while it is indeed missing "version" as the originator of the "instance type (integer) does not match...". It actually doesn't seem to be an actual error.
I tested sending version as string: "1" but it keeps being rejected by pubsub (there is no message coming into it).
I tested sending with version as int: 1, it gets into the pubsub correectly but validation says error as shown above "instance type (integer) does not match..."
so...which one is correct? version as string or int? maybe I have error in my settings? I have also changed my udmi schema to either version as int and version as string...but still the same error as I tested.

This is currently being addressed with
https://github.com/faucetsdn/udmi/pull/286 -- should be fixed in a day or
so once I can get the PR cleaned up and submitted. There's a new "upgrade
message" feature that should address this problem, but it wasn't fully
implemented correctly the first time (I missed the relevant code path in
the validator).
The old way of doing it was an integer (1) -- but that will be deprecated
in the future, but the message upgrader feature should automatically fix
that.
The new way of doing it is a string, which should ultimately have a full
version like "1.3.14"
On Mon, Apr 4, 2022 at 6:39 PM josephedwardchang @.***>
wrote:

While converting to json node: 1 schema violations found
1 schema violations found
instance type (integer) does not match any allowed primitive type (allowed: ["string"])
I searched for this error here, and while it is indeed missing "version"
as the originator of the "instance type (integer) does not match...". It
actually doesn't seem to be an actual error.
I tested sending version as string: "1" but it keeps being rejected by
pubsub (there is no message coming into it).
I tested sending with version as int: 1, it gets into the pubsub
correectly but validation says error as shown above "instance type
(integer) does not match..."
so...which one is correct? version as string or int? maybe I have error in
my settings? I have also changed my udmi schema to either version as int
and version as string...but still the same error as I tested.
—
Reply to this email directly, view it on GitHub
https://github.com/faucetsdn/udmi/issues/283#issuecomment-1088184765,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIEPD5W5DEFV4ABOMOUZJDVDOKWFANCNFSM5SCF2K3Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks for the info sir. I'll adjust version on my side now.
On Tue, Apr 5, 2022 at 12:55 PM Trevor @.***> wrote:

This is currently being addressed with
https://github.com/faucetsdn/udmi/pull/286 -- should be fixed in a day or
so once I can get the PR cleaned up and submitted. There's a new "upgrade
message" feature that should address this problem, but it wasn't fully
implemented correctly the first time (I missed the relevant code path in
the validator).
The old way of doing it was an integer (1) -- but that will be deprecated
in the future, but the message upgrader feature should automatically fix
that.
The new way of doing it is a string, which should ultimately have a full
version like "1.3.14"
On Mon, Apr 4, 2022 at 6:39 PM josephedwardchang @.***>
wrote:

While converting to json node: 1 schema violations found
1 schema violations found
instance type (integer) does not match any allowed primitive type
(allowed: ["string"])
I searched for this error here, and while it is indeed missing "version"
as the originator of the "instance type (integer) does not match...". It
actually doesn't seem to be an actual error.
I tested sending version as string: "1" but it keeps being rejected by
pubsub (there is no message coming into it).
I tested sending with version as int: 1, it gets into the pubsub
correectly but validation says error as shown above "instance type
(integer) does not match..."
so...which one is correct? version as string or int? maybe I have error
in
my settings? I have also changed my udmi schema to either version as int
and version as string...but still the same error as I tested.
—
Reply to this email directly, view it on GitHub
https://github.com/faucetsdn/udmi/issues/283#issuecomment-1088184765,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAIEPD5W5DEFV4ABOMOUZJDVDOKWFANCNFSM5SCF2K3Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/faucetsdn/udmi/issues/283#issuecomment-1088267381,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFCFUXBYM4IDA3VCEMMG35DVDPBVBANCNFSM5SCF2K3Q
.
You are receiving this because you commented.Message ID:
@.***>

Ok, I just submitted the PR that I believe should fix this problem.
Basically it takes any version specification (number or string) and
automatically upgrades the message it's validating to accommodate any
changes to the "latest" version. If you still run into problems then let me
know and we can figure out how to debug more. (Make sure you pull the
latest down for the tool, and update the cloud functions if you're using
them.)
On Tue, Apr 5, 2022 at 12:22 AM josephedwardchang @.***>
wrote:

Thanks for the info sir. I'll adjust version on my side now.
On Tue, Apr 5, 2022 at 12:55 PM Trevor @.***> wrote:

This is currently being addressed with
https://github.com/faucetsdn/udmi/pull/286 -- should be fixed in a day
or
so once I can get the PR cleaned up and submitted. There's a new "upgrade
message" feature that should address this problem, but it wasn't fully
implemented correctly the first time (I missed the relevant code path in
the validator).
The old way of doing it was an integer (1) -- but that will be deprecated
in the future, but the message upgrader feature should automatically fix
that.
The new way of doing it is a string, which should ultimately have a full
version like "1.3.14"
On Mon, Apr 4, 2022 at 6:39 PM josephedwardchang @.***>
wrote:

While converting to json node: 1 schema violations found
1 schema violations found
instance type (integer) does not match any allowed primitive type
(allowed: ["string"])
I searched for this error here, and while it is indeed missing
"version"
as the originator of the "instance type (integer) does not match...".
It
actually doesn't seem to be an actual error.
I tested sending version as string: "1" but it keeps being rejected by
pubsub (there is no message coming into it).
I tested sending with version as int: 1, it gets into the pubsub
correectly but validation says error as shown above "instance type
(integer) does not match..."
so...which one is correct? version as string or int? maybe I have error
in
my settings? I have also changed my udmi schema to either version as
int
and version as string...but still the same error as I tested.
—
Reply to this email directly, view it on GitHub
<https://github.com/faucetsdn/udmi/issues/283#issuecomment-1088184765
,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AAIEPD5W5DEFV4ABOMOUZJDVDOKWFANCNFSM5SCF2K3Q

.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/faucetsdn/udmi/issues/283#issuecomment-1088267381,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AFCFUXBYM4IDA3VCEMMG35DVDPBVBANCNFSM5SCF2K3Q
.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/faucetsdn/udmi/issues/283#issuecomment-1088352473,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIEPDYVLJXV7OGJGPOAJWTVDPS2HANCNFSM5SCF2K3Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks -- I can confirm I can reproduce it.  Tracking internally as
b/227464335
On Wed, Mar 30, 2022 at 8:12 AM Noureddine @.***> wrote:

The output is in the out/devices/event_pointset.out file
—
Reply to this email directly, view it on GitHub
https://github.com/faucetsdn/udmi/issues/283#issuecomment-1083264089,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIEPD4LMD6XV5VEEUX3N3LVCRVNHANCNFSM5SCF2K3Q
.
You are receiving this because you were mentioned.Message ID:
@.***>


Create page: scrollbar-gutter

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[x] New documentation
[ ] Correction or update

Details

I would like to request the creation of a page to document the standard CSS property scrollbar-gutter:

https://developer.mozilla.org/en-US/docs/Web/CSS/scrollbar-gutter

scrollbar-gutter gives control to Web authors over the presence of scrollbar gutters separately from the ability to control the presence of scrollbars (via overflow), allowing them to avoid layout changes when the content size changes and unwanted visuals when scrolling isn't needed.
This property has recently been implemented in Chrome (bug #710214) and is already available as an experimental Web feature, so  IMHO it would be important to have it documented in MDN.
If it helps, feel free to use material from the explainer linked below. Please don't hesitate to ask if there is anything that I could do from my side to help.
References:

Defined in the CSS Overflow spec
Explainer
Chromium intent-to-prototype
TAG design review

Hi @felipeerias ! Thanks for submitting this to MDN. This does sound like a useful property. My only concern here is whether it might be a bit too early to document it on MDN, if it is only available experimentally in Chrome. Is there interest in implementing in other engines (Gecko/WebKit), how stable is the spec.
Any thoughts here?
Also any thoughts on this @rachelandrew ?

@chrisdavidmills probably worth adding, it's part of Overflow 4, which is FPWD, but if there is an implementation it's probably a point at which we could doc it. There are a bunch of open issues on it: https://github.com/w3c/csswg-drafts/issues?q=is%3Aissue+is%3Aopen+scrollbar-gutter however several are on finer implementation details that won't be all that interesting to authors.
I'm generally of the feeling that where it isn't a huge amount of work, and it looks like the property won't vanish, it's worth having these things documented as it gives people writing about them somewhere to link to.

@rachelandrew OK, I'll agree to having this one documented then, thanks for the input!
@felipeerias if I create the page, are you willing to create the content for it?

@chrisdavidmills @rachelandrew : Thank you so much for your help! Yes, if you create the page, I will write the content for it.

Thanks @felipeerias ! the page is now created:
https://wiki.developer.mozilla.org/en-US/docs/Web/CSS/scrollbar-gutter
Use another CSS property page as a template for this one, and feel free to ping us to review it when you are done.

Great, thank you @chrisdavidmills !

This looks done

This looks done


Adding ReinforceGamma

I was thinking it would be nice to test the gradient calculation more thoroughly - possibly by calculating it numerically and then comparing, but I couldn't figure out how to deal with the random nature of the function.

Also not sure why git is stating that I've written all of test.lua myself

@ssampang  I wonder why the return of updataGradInput is "self.gradInput", since all your computation are "gradShape" and "gradScale"?

@ruinmessi you can see the logic for that here. Essentially, if the input is a tensor, then we assume its the shape, and we use the scale variable set at initialization. If the input is a table, then we assume the user is providing both shape and scale, and so we must return a self.gradInput that is a table where the first element is a tensor of the gradient with respect to shape, and the second element is a tensor of the gradient with respect to the scale. On lines 73-77, we set local variables equal to the relevant fields of self.gradInput, and so when we modify gradShape (and gradScale if a scale was provided as input), we are modifying self.gradInput as well.

@ssampang The real test.lua is in test/test.lua. Yours is another file. Could your rebase or submit a new PR?

@ssampang As for a valid unit test for these kind of modules, you could add a test that makes sure it learns what it is supposed to. I think you mentioned this before. As in https://github.com/Element-Research/dpnn/blob/master/test/test.lua#L1578-L1691, you can put the test under dpnnbigtest.ReinforceGamma which you can test using `th -ldpnn -e "dpnn.bigtest{'ReinforceGamma'}".

@nicholas-leonard could you explain the motivation for the buffer?

Allocates memory once per object instead of every call to function. Doesn't
rely on garbage collection to manage memory.
On Apr 18, 2016 9:56 AM, "Siddarth Sampangi"<EMAIL_ADDRESS>wrote:

@nicholas-leonard https://github.com/nicholas-leonard could you explain
the motivation for the buffer?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/Element-Research/dpnn/pull/51#issuecomment-211472219


Add Emoji's short codes to Emoji type

During those days is a common practice in social networks to use and support emoji's short codes.
I would suggest to add them to the type Emoji and add functions that let searching emoji using shortcodes.
So for example Emoji type should become:
type Emoji struct {
	Key        string `json:"key"`
	Value      string `json:"value"`
	Descriptor string `json:"descriptor"`
        ShortCode  string `json:"short_code"`
}

and an emoji should look like this:
Emoji{ Key:"1F437", Value:"🐷", Descriptor: "pig", ShortCode: ":pig:" }

Let me know what do you think, I can also make a PR for this.

This could be really useful! Feel free to submit a PR 👍


Open descriptions and defaults for environment variables

This is a list of all extension where defaults and decriptions are missing. Note that for some elements, the content is most likely the same over many extensions like logging or tracing or JWT token info. In any case, this MUST be filled in each extension with the same text - if this is the case. Note that also default is a field that must be populated!
Description texts should start with a capital letter. In case existing descriptions start in lower case - change them.
The users extensions has good texts for descriptions of the tracing stuff (defaults are missing tough).
Regarding the questions, for sure I did not catched them all, but you may see the pattern.
Pls add me in cc to each PR created so I can monitor the changes to trigger the documentation update.
@micbar @wkloucek @butonic pls assign responsibles to extensions by editing the issue. Self assignment of volunteers is welcomed too 😃

[x] App Provider :white_check_mark:
[x] App Registry :white_check_mark:
[x] Audit :white_check_mark:
[x] Auth Basic :white_check_mark:
[x] Auth Bearer :white_check_mark:
[x] Auth Machine :white_check_mark:
[ ] Frontend
FRONTEND_CHECKSUMS_SUPPORTED_TYPES missing type
[x] Gateway :white_check_mark:
[x] Graph :white_check_mark:
[x] Graph Explorer :white_check_mark:
[x] Groups :white_check_mark:
[x] IDM :white_check_mark:
[x] IDP :white_check_mark:
[x] NATS :white_check_mark:
Question: NATS_NATS_STORE_DIR is there a difference when using binary vs container?
[x] Notifications :white_check_mark:
[x] OCDAV :white_check_mark:
[x] OCS :white_check_mark:
[x] Proxy :white_check_mark:
[ ] Search
SEARCH_DATA_PATH and SEARCH_MACHINE_AUTH_API_KEY missing description
[x] Settings :white_check_mark:
[x] Sharing :white_check_mark:
[x] Storage-Publiclink :white_check_mark:
[x] Storage-Shares :white_check_mark:
[x] Storage-System :white_check_mark:
Questions:
STORAGE_SYSTEM_OCIS_ROOT is there a difference when using binary vs container?
STORAGE_SYSTEM_TEMP_FOLDER is there a difference when using binary vs container?
[x] Storage-Users :white_check_mark:
Questions:
STORAGE_USERS_OCIS_ROOT is there a difference when using binary vs container?
STORAGE_USERS_S3NG_ROOT is there a difference when using binary vs container?
STORAGE_USERS_OWNCLOUDSQL_DATADIR is there a difference when using binary vs container?
[x] Store :white_check_mark:
Question: STORE_DATA_PATH is there a difference when using binary vs container?
[ ] Thumbnails
THUMBNAILS_RESOLUTIONS missing type and description
Question: THUMBNAILS_FILESYSTEMSTORAGE_ROOT is there a difference when using binary vs container?
[x] Users :white_check_mark:
Question: USERS_LDAP_CACERT is there a difference when using binary vs container?
[x] Web :white_check_mark:
[x] WebDAV :white_check_mark:

@EParzefall FYI

Ckassified as bug, blocks docs-team!

@mmattel there are multiple questions about path for different packaging formats / release artifacts. They are valid, since the current configuration documentation doesn't reflect these differences at all.
In the current documentation we have a lot of default values for paths beginning with ~/.ocis. These paths are all dependent on the packaging / release artifacts:

for binaries released on our download mirror and GitHub releases, ~/.ocis from documentation equals ~/.ocis as base data path in the oCIS binary. (the base config path is ~/.ocis/config
for our docker images (containing a oCIS binary) released on dockerhub, ~/.ocis from the documentation equals /var/lib/ocis as base data path in the oCIS binary. (the base config path is /etc/ocis)

As of now, there are no other packaging formats / release artifacts.
So the current documentation only covers binary releases.
I could offer that we print something like this in our documentation:
<packaging dependent base path>/...
For example NATS_NATS_STORE_DIR would have the default value <packaging dependent base path>/nats
We could also go with /<oCIS data root>/.... If you have a better proposal, please let me know

Colleagues, I have updated the services listed in the comment on top with regards of open items based on the recent env merges. Only a view left, we are close to final 😃

@mmattel are your ... is there a difference when using binary vs container? questions answered?

Update: after a discussion with @butonic, when having a container and with all env's where you define a filesystem path, that path is INSIDE the container and must be made available to the OS if you want to keep data persistent. I will update the documentation accordingly.


Update google-drive-connector-reference.adoc

Fixed the typo
Writer's Quality Checklist
Before merging your PR, did you:

[x] Run spell checker
[x] Run link checker to check for broken xrefs
[x] Check for orphan files
[x] Perform a local build and do a final visual check of your content, including checking for:

Broken images
Dead links
Correct rendering of partials if they are used in your content
Formatting issues, such as:

Misnumbered ordered lists (steps) or incorrectly nested unordered lists
Messed up tables
Proper indentation
Correct header levels

[x] Receive final review and signoff from:

Technical SME
Product Manager
Editor or peer reviewer
Reporter, if this content is in response to a reported issue (internal or external feedback)

[x] If applicable, verify that the software actually got released

Thank you for your contribution, @AnilProlifics! We appreciate it.


Disabling inputStream cache when Transfer-Encoding=chunked

The current implementation for the HttpServletRequest returned from request.raw() (HttpRequestWrapper.class) caches the bytes when getInputStream() is called. When large data is transfered, an OutOfMemoryError is thrown, even when using chunked transfer encoding.

Why is this not merged/closed?
Any other existing solution to receive large files, without cache blowing up memory?
TIA,
Yuval

@sidneibjunior could you update this?

Replaced by #821


Changing hash in URL causes getInitialProps to be re-fired

Changing the hash in the URL causes getInitialProps to be fired, which I think should've been fixed in this PR. See the following example repo: https://github.com/ldthorne/nextjs-back-reproduction.

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
If the user clicks the go somewhere link that leads to an anchor -- which will add a hash to the url -- and then clicks the back button, getInitialProps should not be called.
Current Behavior
If the user clicks the go somewhere link that leads to an anchor -- which will add a hash to the url -- and then clicks the back button, getInitialProps is called.
Steps to Reproduce (for bugs)

Clone repo: https://github.com/ldthorne/nextjs-back-reproduction.
yarn.
Open dev tools.
Click the go somewhere link. Notice that nothing is logged.
Click the browser's back button. Notice that getInitialProps is logged.

Your Environment

Tech
Version

next
3.0.6

node
8.1.2

OS
macOS 10.12.6

browser
All

@arunoda it seems like you might have experience with this (based on the PR you opened) -- any thoughts on this issue?

So the issue here is that the hash change only checks as and you've not provided it. I guess this is kind of a bug 🤔 @arunoda will be able to give a definitive answer on how to fix it, since he wrote it 😄

@ldthorne I'm looking into this today.

Hi @arunoda, any chance you've had any luck tracking down the issue?

If you don't want to use route in anyway, I think has more sense to just use somewhere instead using the Link component. Maybe your real use case has some other implication?

Thanks for the suggestion, @coluccini. I tried that in my example repo, but it still fires getInitialProps.

Ups, I didn't read that this was happening when clicking back button. Sorry.

No worries. Thanks for your help!

Hi @arunoda, any chance you have any updates?


Adblock rule on requested url

When I use filters from EasyList:
http://localhost:8050/render.json?timeout=40&wait=0.5&url=https%3A%2F%2Fwww.youtube.com%2F&history=1&resource_timeout=15&images=0&html=1&filters=nofonts%2Ceasylist
I get for youtube.com:
{
	error: 502,
	description: "Error rendering page",
	type: "RenderError",
	info: {
		code: 301,
		url: "",
		type: "Network",
		text: "Protocol "" is unknown"
	}
}

I think the filter should not been applied on the main requested url.
There is another bug on filter.
An empty line in a rules file raise an error and splash does not start.

The second bug is https://github.com/scrapinghub/adblockparser/issues/4; PRs to adblockparser are welcome.
Hm, I think I agree that filters shouldn't be applied to the main request.

This should be fixed by https://github.com/scrapinghub/adblockparser/pull/5 and https://github.com/scrapinghub/splash/pull/402. Thanks!

Hm, it looks like the first issue is fixed only for filters which use 'domain' option.


Not able to rename jobs.N.templates to instance_groups.N.jobs

Hi,
I find this tool really helpful for the v1 to v2 schema migration. I was testing the convertion, but I´m facing the following issue:
When defining my transform.yml file, the following is not working:
transforms:
- type: filter
  sections: ["jobs", "releases", "stemcells", "update"]
- type: rename
  section: "jobs"
  to: "instance_groups"
- type: rename <------------ this rename
  section: "instance_groups[].templates"
  to: "jobs"

and the error I see is:
/Users/poolk/.rvm/gems/ruby-2.4.1/gems/mantra-0.2.3/lib/mantra/transform/rename.rb:23:in `block in perform': parent should be a hash (Mantra::Transform::ValidationError)

Any ideas on this?

hi, sorry for the late reply, I´m not longer using this repo. Let me close this issue. Thanks for your inquiry.


Skip ci with keywords at head commit message and pull request title

See #1627

@pascalgrimaud : here is the change proposal for ignoring the ci. I saw that the tests-windows don't have the if needed to ignore the job, so I kept it that way.
I am looking for an alternative to use the [ci skip] and [skip ci] keywords which is more elegant: https://stackoverflow.com/questions/76103981/how-can-i-override-github-actions-or-cloud-build-skip-ci

I am going to check that bug at my fork:

I am going to check that bug at my fork:

It is fixed: must remove commit line breaks.

thanks @renanfranca : let's give it a try :)


Sticky event bus

Hi.
First of all, thank you for the great samples, That's awesome!
I would like to get some advice. I really want to know how to implement sticky event with Rxbus.  Any operator can reach it? I can't find any example for that, should i custom operator  by .lift( )? If you feel it, what would you do?
I'm really really really confused. : (
Thanks.

you may what to use BehaviorSubject as RxHub middleman engine.
ex:
private final Subject<Object, Object> _bus = new SerializedSubject<>(BehaviorSubject.create());
you may also take a look into https://github.com/apptik/rxHub which was particularly built for Pub-Sub type of architecture.

@djodjoni is totally right. Simply changing from a PublishSubject -> BehaviorSubject should achieve what you need.
Note that i've upgraded the examples to use Jake Wharton's RxRelay so instead of a PublishRelay you're looking at a BehaviorRelay.
Let me know if you have any other questions.


dev mode help does not show option o

use LMP 3.7.1, start the dev mode, press h, will see following:
[INFO] ************************************************************************
[INFO] *        Automatic generation of features: [ Off ]
[INFO] *        g - toggle the automatic generation of features, type 'g' and press Enter.
[INFO] *            A new server configuration file will be generated in the SOURCE configDropins/overrides configuration directory.
[INFO] *        Enter - run tests on demand, press Enter.
[INFO] *        r - restart the server, type 'r' and press Enter.
[INFO] *        h - see the help menu for available actions, type 'h' and press Enter.
[INFO] *        q - stop the server and quit dev mode, press Ctrl-C or type 'q' and press Enter.
[INFO] ************************************************************************

Based on the doc at https://github.com/OpenLiberty/ci.maven/blob/main/docs/dev.md, there is an option o. Is it because that the option o is not released yet? If released, the help is missing that option. If not released, should hide it from the dev.md?
Also. several lines are longer than the top and bottom * lines. Should the content be wrapped/aligned?

@gkwan-ibm the 'o' option will only be shown in the help menu if automatic generation of features is 'On'.
h
[INFO] ************************************************************************
[INFO] *        Automatic generation of features: [ On ]
[INFO] *        g - toggle the automatic generation of features, type 'g' and press Enter.
[INFO] *            A new server configuration file will be generated in the SOURCE configDropins/overrides configuration directory.
[INFO] *        o - optimize the list of generated features, type 'o' and press Enter.
[INFO] *            A new server configuration file will be generated in the SOURCE configDropins/overrides configuration directory.
[INFO] *        Enter - run tests on demand, press Enter.
[INFO] *        r - restart the server, type 'r' and press Enter.
[INFO] *        h - see the help menu for available actions, type 'h' and press Enter.
[INFO] *        q - stop the server and quit dev mode, press Ctrl-C or type 'q' and press Enter.
[INFO] ************************************************************************

If a user types 'o' while automatic generation of features is off, they will see the following warning:
o
[WARNING] Cannot optimize features because automatic generation of features is off.
[WARNING] To toggle the automatic generation of features, type 'g' and press Enter.

Also. several lines are longer than the top and bottom * lines. Should the content be wrapped/aligned?

+1 I agree that we should wrap/align better with the header and footer

ok, I can see the option o. Thanks to let me know

Also suggest an option to show the following information or h will include them:
[INFO] *    Liberty server port information:
[INFO] *        Liberty server HTTP port: [ 9081 ]
[INFO] *        Liberty debug port: [ 7777 ]


1.12.2的缩放0异常，需要隐藏的组没有隐藏   1.12.2 zoom 0 exception, groups that need to be hidden are not hidden

1.12.2 zoom 0 exception, groups that need to be hidden are not hidden

1.12 is a very old version, I'd recommend updating if you want updates


⚠ Samsung has degraded performance

In a5d8c56, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2672 ms

Resolved: Samsung performance has improved in ebe480e.


Create a world clock widget

Create a world clock widget.
User should be able to select country. (timezone)
The clock should be abvailable in digital, as well as analog format.

Can i?

Sure!

@santoshhiremani can i work with you to see this issue being resolved?

Sure..

@Swati4star  I think we need have it in Utilities since user can't change timezone on widget itself. something like this https://github.com/arminha/worldclockwidget/wiki/Screenshots

We do have an issue for this also, https://github.com/project-travel-mate/Travel-Mate/issues/393

Is that merged ? Need to fix that than. Widget alone doesn't serve our purpose..

Ok

Fixed by https://github.com/project-travel-mate/Travel-Mate/pull/560


Clearing the errors array

Two separate error lists cannot exist on the same page as they share the same error array. This is due to the nature of the Error class containing a static array.
Currently finding a way around this.

Fixed by assigning each array element to a empty string.


Different Result

Hi Shashi,
I also use pyrouge (https://github.com/bheinzerling/pyrouge) to calculate the ROUGE score and I use exactly the same code as you do (in reward_utils.py).
However, the result I've gotten with the test set is a lot higher than yours.
Did you do any preprocessing before summarizing on the test set, or what do you think could cause me to get a higher score?
(I am using python2.7 and tensorflow 0.12)
Thank you very much!
Simeng

I found an error. pyrouge treats punctuations as a word and we must eliminate the punctuations in the test set before running the ROUGE test. However, my result is still higher.

Could you use the Pyrouge and let me know if you still get a different result? I am not doing anything other than also used for training data and reported in the paper.

I used pyrouge and, without doing anything on the data provided in this repo, got the same result.
Thanks!

@ you mean that you got the same rouge scores ?? i upgraded tf to tf =10 and python = 3.6 and try to run the code as it is with the same data but i did not get the same results.
could you suggest me anything ?


Transcripts not available

I used this library yesterday and was able to access a multitude of transcripts. However, when I try to use the library today, it says that it could not retrieve the transcript most likely because: the video is no longer available when it is. Did something change or am I doing something wrong?

Hi @ccrupp. I can not replicate this error. Which python version are you using? And are you sure it's not a network issue on your end?

Thanks for the response @jdepoix! I'm currently using Python 3.8.3, I don't believe it's a network issue on my end because I can access the video through my browser just fine. My thought is that I created too many requests but the rate limit is reset daily for the youtube API but it is still not working for me after waiting a day. Is this a common problem? I've tried with many other videos with no luck

@ccrupp Just to case you thought otherwise, this library does not use the Youtube Data V3 API so there is no "Quota" reset every day

Oh good to know, however, I'm more confused now. Any suggestions as to what I should try differently? I'm kind of at a loss for solutions

I am unsure and unable to investigate further right now. Rate limiting has been an issue before with this library and so maybe there are some solutions in the other threads? I would check out https://github.com/jdepoix/youtube-transcript-api/issues/60 for starters

Thank you, I will check them out. I'll close this thread for now


Created DevRizz.md

📝 Description
Generates pickup lines for developers in there prefered coding languages
💣 Is this a breaking change (Yes/No):

[ ] Yes
[x] No

🚧 How to migrate?
Don't need.
📝 Additional Information
lol

updated the branch @wenzhuo2022 ready to merge.


master broken currently?

Can't compile on Debian:
Throwing me:
find . -name '.o' -exec rm -r {} ;
rm libcryptonote.so
gcc -Wall -c -fPIC -O2 -g -Wno-pointer-sign -Wno-unused-function -Wno-strict-aliasing -Wno-discarded-qualifiers   -c -o bcrypt.o bcrypt.c
In file included from bcrypt.c:40:0:
./stdint.h:34:2: error: #error "Use this header only with Microsoft Visual C++ compilers!"
#error "Use this header only with Microsoft Visual C++ compilers!"
^
In file included from bcrypt.c:40:0:
./stdint.h:94:30: error: expected '=', ',', ';', 'asm' or 'attribute' before 'int64_t'
typedef signed __int64       int64_t;
^
./stdint.h:95:30: error: expected '=', ',', ';', 'asm' or 'attribute' before 'uint64_t'
typedef unsigned __int64     uint64_t;
^
./stdint.h:102:9: error: unknown type name 'int64_t'
typedef int64_t   int_least64_t;
^
./stdint.h:106:9: error: unknown type name 'uint64_t'
typedef uint64_t  uint_least64_t;
^
./stdint.h:112:9: error: unknown type name 'int64_t'
typedef int64_t   int_fast64_t;
^
./stdint.h:116:9: error: unknown type name 'uint64_t'
typedef uint64_t  uint_fast64_t;
^
./stdint.h:128:9: error: unknown type name 'int64_t'
typedef int64_t   intmax_t;
^
./stdint.h:129:9: error: unknown type name 'uint64_t'
typedef uint64_t  uintmax_t;
^
: recipe for target 'bcrypt.o' failed
make: *** [bcrypt.o] Error 1
cp: cannot stat '../Native/libmultihash/libmultihash.so': No such file or directory
find . -name '.o' -exec rm -r {} ;
rm libmultihash.so
rm: cannot remove 'libmultihash.so': No such file or directory
Makefile:26: recipe for target 'clean' failed
make: *** [clean] Error 1

Not having any trouble here compiling and running master. You compiling with gcc6?

i solved it by removing stdint.h
that should be excluded in universal build repos isn't it?

@justnx Could you help me out here. What's the issue with stdint.h?

when compiling: src/Native/libmultihash it throws:
./stdint.h:34:2: error: #error "Use this header only with Microsoft Visual C++ compilers!"
#error "Use this header only with Microsoft Visual C++ compilers!"
on my linux environment.
Weirdly on latest git pull it works again, so anything have been fixed/modified to bypass this header?

@justnx Nope. No recent commits touching this area.

@oliverw Very weird. Since it works, im closing this issue.


move to litmining organization

should we move this repo to the litmining github organization?
@koudyk WDYT

sounds reasonable to me !

done!


Setup for other datasets

First off, thanks for making this code available, it's really helpful for extending the comparison to other systems.
I wanted to check if you could also provide the code for assessing against the other datasets used in the paper. Particularly the SFU dataset, where you did some cropping/subsampling of the images?
Thanks in advance.

Hi, I've added some files in the folder SFU Code to give an example. The only real difference is the "offsetimage" call when you load the image. I haven't actually tested this code with the framework here, so if there are errors let me know and I can fix them.

That's great, thanks for the swift reply! I'll let you know if I have any problems with it.


feat: display packages versions in the side bar

display configured packages version at the bottom of the side bar
closes inveniosoftware/invenio-app-rdm#2838

Question: how are the versions of the packages added to the variable? is there a nice automatic solution or has it to be done by hand before of the deployment?

my two cents: a group name would be nice. we have "Site Management", "User Management" but the package -> version has no group name. maybe something like "Dev Management" and the sub name "Package versions" to make it open for other possible use cases.

Question: how are the versions of the packages added to the variable? is there a nice automatic solution or has it to be done by hand before of the deployment?

@utnapischtim this is how it gets propagated: https://github.com/inveniosoftware/invenio-app-rdm/pull/2839/files#diff-988eb51a0bc0a8bf6efd0b04d1bb6b6d8f24cc80504ea36699a202904a20af4dR1428
https://github.com/inveniosoftware/cookiecutter-invenio-rdm/pull/294/files


bug(Slider): Tooltip is not showed on thumb hover

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
Slider component doesn't work properly in Safari after changing slider's value.
https://github.com/angular/components/assets/84070515/186bb5cc-36bb-47d2-a7c1-8e86f9c5adc3
Reason: mat-slider-visual-thumb element is not getting mdc-slider__thumb--with-indicator css class on thumb hover
Reproduction
Steps to reproduce:
StackBlitz link: https://stackblitz.com/edit/components-issue-2ytten?file=src%2Fapp%2Fexample-component.html

hover thumb - tooltop is showed
click on slider to change its value
hover thumb - now tooltip is not showed

Expected Behavior
Tooltip must be always showed on thumb hover.
Actual Behavior
Tooltip is not showed on thumb hover after changing slider's value.
 Such a small bug but so annoyingly easy to reproduce that I need to fix it 😅


Write vmec input files

This pull request adds a routine to write vmec input files. Now at the end of a stage-1 optimization, the vmec input file for the optimized configuration is available. Previously just the output file was available.

@landreman ,
Some tests are failing. Could you please look into this?

@mbkumar all tests pass now in the CI.


Take photo from camera crashes app

I get this error in xCode with 0.26.3 release, when I try to use a photo taken by the camera.
2017-08-09 12:45:58.067658+0300 Stories[781:144006] 781: CFNetwork internal error (0xc01a:/BuildRoot/Library/Caches/com.apple.xbs/Sources/CFNetwork/CFNetwork-811.5.4/Foundation/NSURLProtocol.mm:183) 2017-08-09 12:45:58.068418+0300 Stories[781:144006] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSPlaceholderArray initWithObjects:count:]: attempt to insert nil object from objects[0]' *** First throw call stack: (0x18274afe0 0x1811ac538 0x18262c2d8 0x182638030 0x10026b4b8 0x100294240 0x10160da50 0x10160da10 0x10161b2e8 0x101611634 0x10161b810 0x10161d630 0x10161d39c 0x18180b100 0x18180acac) libc++abi.dylib: terminating with uncaught exception of type NSException
if ([imageURL.scheme caseInsensitiveCompare:@"assets-library"] == NSOrderedSame) {     assetID = [imageURL absoluteString];     results = [PHAsset fetchAssetsWithALAssetURLs:@[imageURL] options:nil];  }
@[imageURL]  is nil

+1
On Android, Im getting this error:
CameraService: connectLegacy: camera HAL module version 100 doesn't support connecting to legacy HAL devices! An error occurred while connecting to camera 0: -38 (Function not implemented)

Im think that the problem with android is the camera api version:
this plugin uses the deprecated API:
https://developer.android.com/reference/android/hardware/Camera.html
https://developer.android.com/reference/android/hardware/camera2/package-summary.html


Devimint + mprocs doesn't always cleanly shut down

Sometimes if I start mprocs with just mprocs and the close it with ctrl-a q y, some processes like fedimintd or lnd continue to run indefinitely.
I think there's 2 separate problems here:

More reliably stop child processes
Communicate to user when devimint fails to stop child processes. Currently, you have scrutinize logs for port conflicts to diagnose this problem.

There should be ProcessManager::wait_all_dead that should wait for all processes to die. (store all pids in ProcessMangaer)
and this function should be called at end of main() in devimint

There should be ProcessManager::wait_all_dead that should wait for all processes to die. (store all pids in ProcessMangaer) and this function should be called at end of main() in devimint

I made a little prototype of this: https://github.com/justinmoon/fedimint/tree/devimint-shutdown
I used a crate called sys_info to see if process with some pid were still alive. This crate seems unreliable, though, because sometimes during shutdown it will report that the number of processes has increased. Might be better to just have ProcessManager store child processes.
I think part of the problem here is that we redirect the output of devimint dev-fed to /dev/null so when you leave mprocs, you don't see any output. We could have mprocs.sh call something like devimint wait-shutdown like we do on startup and use a file to communicate progress.

one test is exiting mprocs without waiting the normal startup after running:
$ just mprocs && for i in $(seq 0 100); do killall -0 devimint  bitcoind electrs esplora lnd lightningd fedimintd gatewayd fedimint-cli faucet; echo $i;sleep 1;done
./scripts/mprocs.sh
Run with 'source ./scripts/build.sh [fed_size] [dir]
Setting up env variables in /tmp/nix-shell.7rPUBK/fm-Mb3j
    Finished dev [unoptimized + debuginfo] target(s) in 0.33s
Killing fedimint processes
gatewayd: no process found
fedimint-cli: no process found
faucet: no process found
0
gatewayd: no process found
fedimint-cli: no process found
faucet: no process found
1
fedimint-cli: no process found
2
fedimint-cli: no process found
3
fedimint-cli: no process found
4
fedimint-cli: no process found
5
fedimint-cli: no process found
6
fedimint-cli: no process found
7
fedimint-cli: no process found
8
9
10
11
fedimint-cli: no process found
12
fedimint-cli: no process found
13
fedimint-cli: no process found
14
fedimint-cli: no process found
15
fedimint-cli: no process found
16
fedimint-cli: no process found
17
fedimint-cli: no process found
18
fedimint-cli: no process found
19
fedimint-cli: no process found
20
fedimint-cli: no process found
21
fedimint-cli: no process found
22
devimint: no process found
bitcoind: no process found
electrs: no process found
esplora: no process found
lnd: no process found
lightningd: no process found
fedimintd: no process found
gatewayd: no process found
fedimint-cli: no process found
faucet: no process found
23

So it takes 23 seconds for devimint to kill all the processes. But what if something happens during initialization? like it keeps waiting a fedimint to startup or if it exits with an error? then it seems it will never kill anything

Good enough after https://github.com/fedimint/fedimint/pull/2873 ?

Yea let's close. If it still happens, we can re-open.


Clean resize

Ticket: #
Reviewer: @
Issue
unused variables in run_animated_gif method of Resize class
Solution
remove unused variables in run_animated_gif method of Resize class
Impact

Usage

Considerations

Testing

Coverage decreased (-0.006%) to 93.676% when pulling<PHONE_NUMBER>7b862f677873e6fcac4aa4d1584c3e on ahallais:clean_resize into 60aa0bb7e7d8ef67cc08b241ab35bb35a624e589 on timber:master.

Coverage decreased (-0.006%) to 93.676% when pulling 04baab8c1f9f0f1a3a4df3c1acc29b78222da0ad on ahallais:clean_resize into 60aa0bb7e7d8ef67cc08b241ab35bb35a624e589 on timber:master.

Coverage decreased (-0.006%) to 93.676% when pulling 04baab8c1f9f0f1a3a4df3c1acc29b78222da0ad on ahallais:clean_resize into 60aa0bb7e7d8ef67cc08b241ab35bb35a624e589 on timber:master.


args.json file not available in Market-1501 TF Checkpoint Release

Please provide the 'args.json' file which was used during training in Market-1501 TF Checkpoint Release, so that 'embed.py' fiile could be used for generating embeddings.

Very good point! As a quick fix here it is, but I should also include it properly into the release.
args.json
{
  "batch_k": 4,
  "batch_p": 18,
  "checkpoint_frequency": 1000,
  "crop_augment": true,
  "decay_start_iteration": 15000,
  "detailed_logs": false,
  "embedding_dim": 128,
  "experiment_root": "<path_to_experiment_root>",
  "flip_augment": true,
  "head_name": "fc1024",
  "image_root": "<path_to_market1501_root>",
  "initial_checkpoint": "<path_to_pretrained_checkpoint>/resnet_v1_50.ckpt",
  "learning_rate": 0.0003,
  "loading_threads": 8,
  "loss": "batch_hard",
  "margin": "soft",
  "metric": "euclidean",
  "model_name": "resnet_v1_50",
  "net_input_height": 256,
  "net_input_width": 128,
  "pre_crop_height": 288,
  "pre_crop_width": 144,
  "resume": false,
  "train_iterations": 25000,
  "train_set": "data/market1501_train.csv"
}

Thanks!!
I managed it the other way ;)


Fatal error with PHP8

Running Civi 5.59.2 under Backdrop with PHP8.0, we get a fatal error when registering for an event:
TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given in in_array() (line 40 of /var/www/vhosts/weyarun.org.uk/httpdocs/backdrop_demo/files/civicrm/ext/com.elisseck.civihoneypot-master/civihoneypot.php).
Disabling extension resolves this

Looks like a bug where the array can be empty if the user does not pick an option when configuring. Would accept a PR if you have time, I probably won't be able to get to this for a little while.
As a workaround you can fill out the event settings at the route /civicrm/honeypot/settings. Either check off "protect all events" OR choose at least one event from the list above.

@TomCrawshaw I also encourage you to try out this newer extension by Matt Wire that has implemented most of the concepts from this extension and more useful features as well. I think the only thing it doesn't have is IP bans: https://lab.civicrm.org/extensions/formprotection.