[Not an issue] How to create schema to generate a JSON Array using Schema and transformers provided by DataFaker API in Java?

Sorry to ask here but I am doubtful if I can get a solution on Stack overflow.
I am using DataFaker library to create schema for JSON Object and Array. Since the use of Format is deprecated, I am trying with Transformation Schemas. I tried examples given under the Format section of official documentation to create a schema for Json Array but wasn't successful. Example JSON Array -
[ { "firstName": "Oleta", "lastName": "Toy" }, { "firstName": "Gerard", "lastName": "Windler" } ]

I tried examples given under the Format section of official documentation to create a schema for Json Array but wasn't successful.

could you please share the code to make the discussion more fruitful?

Hi @amodmahajan2016 ,
I think the documentation on this is a little out of date, apologies for that. I think something like this should work:
    @Test
    fun `generate json with custom field names`() {
        val faker = Faker()

        val schema: Schema<String, *> = Schema.of(
            field("firstName", Supplier { faker.name().firstName() }),
            field("lastName", Supplier { faker.name().lastName() })
        )

        val transformer = JsonTransformer.builder<String>().formattedAs(JSON_ARRAY).build()
        val json = transformer.generate(schema, 2)

        println(json)
    }

Alternatively, in Java:
    @Test
    public void test() {
        var faker = new Faker();

        Schema<String, String> schema =
                Schema.of(
                        field("firstName", () -> faker.name().firstName()),
                        field("lastName", () -> faker.name().lastName()));

        JsonTransformer<String> transformer = JsonTransformer.<String>builder().formattedAs(JSON_ARRAY).build();

        String json = transformer.generate(schema, 10);

        System.out.println(json);

    }

Hope this helps!

Hi @amodmahajan2016 ,
I think the documentation on this is a little out of date, apologies for that. I think something like this should work:
    @Test
    fun `generate json with custom field names`() {
        val faker = Faker()

        val schema: Schema<String, *> = Schema.of(
            field("firstName", Supplier { faker.name().firstName() }),
            field("lastName", Supplier { faker.name().lastName() })
        )

        val transformer = JsonTransformer.builder<String>().formattedAs(JSON_ARRAY).build()
        val json = transformer.generate(schema, 2)

        println(json)
    }

Alternatively, in Java:
package test;

import net.datafaker.Faker;
import net.datafaker.transformations.JsonTransformer;
import net.datafaker.transformations.Schema;
import org.junit.jupiter.api.Test;

import static net.datafaker.transformations.Field.field;
import static net.datafaker.transformations.JsonTransformer.JsonTransformerBuilder.FormattedAs.JSON_ARRAY;

public class MyTest {

    @Test
    public void test() {
        var faker = new Faker();

        Schema<String, String> schema =
                Schema.of(
                        field("firstName", () -> faker.name().firstName()),
                        field("lastName", () -> faker.name().lastName()));

        JsonTransformer<String> transformer = JsonTransformer.<String>builder().formattedAs(JSON_ARRAY).build();

        String json = transformer.generate(schema, 10);

        System.out.println(json);

    }
}

Hope this helps!

Thanks, it worked. But how to create JSON Array at field level then? Something as below -
[
{
"firstName": "Oleta",
"lastName": "Toy",
"skills" : [{
"lang": "some"
},
{
"lang": "boo"
}]
}
]
Is "Format" will be removed soon as that has more clear and easy syntax.

But how to create JSON Array at field level then
just add compositeField to schema

    compositeField("skills", new Field[] {field("lang", () -> faker.nation().language())})

full code snippet
    @Test
    void test() {
        var faker = new Faker();

        Schema<String, String> schema =
            Schema.of(
                field("firstName", () -> faker.name().firstName()),
                field("lastName", () -> faker.name().lastName()),
                compositeField("skills", new Field[] {field("lang", () -> faker.nation().language())})
            );

        JsonTransformer<String> transformer = JsonTransformer.<String>builder().formattedAs(JSON_ARRAY).build();

        String json = transformer.generate(schema, 10);

        System.out.println(json);
    }

Will "Format" be removed soon

it's already removed in main if we are talking about json

But how to create JSON Array at field level then

just add compositeField to schema
    compositeField("skills", new Field[] {field("lang", () -> faker.nation().language())})

full code snippet
    @Test
    void test() {
        var faker = new Faker();

        Schema<String, String> schema =
            Schema.of(
                field("firstName", () -> faker.name().firstName()),
                field("lastName", () -> faker.name().lastName()),
                compositeField("skills", new Field[] {field("lang", () -> faker.nation().language())})
            );

        JsonTransformer<String> transformer = JsonTransformer.<String>builder().formattedAs(JSON_ARRAY).build();

        String json = transformer.generate(schema, 10);

        System.out.println(json);
    }

compositeField is generating nested JSON Object as below. My requirement is to generate a key with JSON ARRAY value.
[
{
"Text": "Elicia",
"Bool": false,
"skills": {
"lang": "Hindi"
}
},
{
"Text": "Sheldon",
"Bool": false,
"skills": {
"lang": "Arabic"
}
}
]

ok, in this case it will be a bit different
 void test() {
        var faker = new Faker();

        Schema<String, ?> schema =
            Schema.of(
                field("firstName", () -> faker.name().firstName()),
                field("lastName", () -> faker.name().lastName()),
                field("skills", () ->
                    List.of(compositeField(null,
                        new Field[]{field("lang", () -> faker.nation().language())})
                    )
                )
            );

        JsonTransformer<String> transformer = JsonTransformer.<String>builder().formattedAs(JSON_ARRAY).build();

        String json = transformer.generate(schema, 10);

        System.out.println(json);
    }

ok, in this case it will be a bit different
 void test() {
        var faker = new Faker();

        Schema<String, ?> schema =
            Schema.of(
                field("firstName", () -> faker.name().firstName()),
                field("lastName", () -> faker.name().lastName()),
                field("skills", () ->
                    List.of(compositeField(null,
                        new Field[]{field("lang", () -> faker.nation().language())})
                    )
                )
            );

        JsonTransformer<String> transformer = JsonTransformer.<String>builder().formattedAs(JSON_ARRAY).build();

        String json = transformer.generate(schema, 10);

        System.out.println(json);
    }

It is giving output (not correct) as below which is similar to when I used new Object[].
{
"firstName": "Darryl",
"lastName": "Champlin",
"skills": [
"net.datafaker.transformations.CompositeField@22101c80"
]
}

for me it outputs
[
{"firstName": "Tiffiny", "lastName": "Casper", "skills": [{"lang": "Zulu"}]},
{"firstName": "Lorena", "lastName": "Dibbert", "skills": [{"lang": "Japanese"}]},
{"firstName": "Jamal", "lastName": "Dibbert", "skills": [{"lang": "Russian"}]},
{"firstName": "Mario", "lastName": "Prohaska", "skills": [{"lang": "Korean"}]},
{"firstName": "Agustina", "lastName": "Pfeffer", "skills": [{"lang": "Hakka"}]},
{"firstName": "Edra", "lastName": "Watsica", "skills": [{"lang": "English"}]},
{"firstName": "Clarice", "lastName": "Ryan", "skills": [{"lang": "Marathi"}]},
{"firstName": "Edra", "lastName": "Schneider", "skills": [{"lang": "Kazakh"}]},
{"firstName": "Marlyn", "lastName": "Luettgen", "skills": [{"lang": "Japanese"}]},
{"firstName": "Art", "lastName": "Wisozk", "skills": [{"lang": "Hindi"}]}
]

are you sure you are running exactly the same code as i put in comment above?

for me it outputs
[
{"firstName": "Tiffiny", "lastName": "Casper", "skills": [{"lang": "Zulu"}]},
{"firstName": "Lorena", "lastName": "Dibbert", "skills": [{"lang": "Japanese"}]},
{"firstName": "Jamal", "lastName": "Dibbert", "skills": [{"lang": "Russian"}]},
{"firstName": "Mario", "lastName": "Prohaska", "skills": [{"lang": "Korean"}]},
{"firstName": "Agustina", "lastName": "Pfeffer", "skills": [{"lang": "Hakka"}]},
{"firstName": "Edra", "lastName": "Watsica", "skills": [{"lang": "English"}]},
{"firstName": "Clarice", "lastName": "Ryan", "skills": [{"lang": "Marathi"}]},
{"firstName": "Edra", "lastName": "Schneider", "skills": [{"lang": "Kazakh"}]},
{"firstName": "Marlyn", "lastName": "Luettgen", "skills": [{"lang": "Japanese"}]},
{"firstName": "Art", "lastName": "Wisozk", "skills": [{"lang": "Hindi"}]}
]

are you sure you are running exactly the same code as i put in comment above?

Yes, exactly the same code. I am using 1.8.0

ok i see,

I am using 1.8.0

that is probably the reason
the example I mentioned works after merge of this https://github.com/datafaker-net/datafaker/pull/693
that is only in main and will be a part of future releases

ok i see,

I am using 1.8.0

that is probably the reason the example I mentioned works after merge of this #693 that is only in main and will be a part of future releases

Thanks @snuyanzin, @erikpragt-connectid. Waiting eagerly for the next release. This feature is really awesome and unfortunately many are aware of this. This will be great for API automation testing. I will post some blogs/videos on these concepts.

I am using version 1.9.0 currently, but I experience the same behaviour as @amodmahajan2016. The #693 seems to be merged. What could be wrong? Has it been released yet?

it's merged to 2.x (main branch)
it's not merged to 1.x branch
may be makes sense to merge to 1.x as well..

Aha that makes sence. Also a merge into 1.x would be nice, since the 2.x is only available as SNAPSHOT version. I will make a remark in the original bug with a question if it can be merged into 1.x as well.

Well, 2.0 is the future release, we will release a 2.0 version soon.

merged to 1.x as https://github.com/datafaker-net/datafaker/commit/8ad4e56b28443fe7d5cd7752b08cde56b593874f

closing since it was merged to both 1.x and 2.x
also 2.0 has been released with this fix already


Fix(web): Focus control on button by tab key press

Before:

After:

We have discussed it on our Slack channel (https://lmccz.slack.com/archives/C02MZ3PNGCB/p1653575070117089) and the result is that the focus will be resolved in the future version. So I suggest to close this or create an issue for this case. Tahnk you.


Add files via upload

@skepptpvp I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host osbasagic.edu.ba not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


Retry when existing port file but ECONNREFUSED maybe?

/Users/viktor/dev/projects/atom-ensime/node_modules/ensime-client/release/js/lib/network/NetworkClient.js:27 Error: connect ECONNREFUSED <IP_ADDRESS>:50908(…)(anonymous function) @ /Users/viktor/dev/projects/atom-ensime/node_modules/ensime-client/release/js/lib/network/NetworkClient.js:27

Hi, I'm starting to use atom ensime, and I think I'm getting this error, I have latest version of Ensime package installed 0.40.0, latest sbt-ensime 1.12.6. After running ensimeConfig in a simple scala project, start atom and try a Ensime: Start, seems that nothing happens, but if I open the "Developer Tools Console" I see this error in it:

any help would be very welcome, thanks!

@eprequejo Try deleting the port file and try again.
I think this ticket was meant as a better way to handle when there's a dangling port file but no running server on that port due to some crash. Then the client should remove the port file and try again automatically I guess.

@hedefalk thanks for answering, I've been fighting with this some time now, I removed the port file but no luck and I even removed the http file, but still no luck, still having something similar in the console, I'm wondering why it's seeing a http file when there is non:

now I see I have some logs in the server.log: (let me know if you want me to move this to somewhere else, thanks)
13:02:59.091 INFO  akka://ENSIME/user/ensime-main o.e.s.ServerActor - ENSIME HTTP on /<IP_ADDRESS>
13:02:59.091 INFO  None o.e.s.PortUtil$ - creating port file: /Users/eprequejo/Development/scala-tapas/scala-tapas-001/.ensime_cache/http
13:03:00.145 ERROR akka://ENSIME/user/ensime-main o.e.s.ServerActor - Error with monitor actor exception during creation
akka.actor.ActorInitializationException: exception during creation
  at akka.actor.ActorInitializationException$.apply(Actor.scala:166)
  at akka.actor.ActorCell.create(ActorCell.scala:596)
  at akka.actor.ActorCell.invokeAll$1(ActorCell.scala:456)
  at akka.actor.ActorCell.systemInvoke(ActorCell.scala:478)
  at akka.dispatch.Mailbox.processAllSystemMessages(Mailbox.scala:263)
  at akka.dispatch.Mailbox.run(Mailbox.scala:219)
  at akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(AbstractDispatcher.scala:397)
  at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
  at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
  at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
  at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)
Caused by: java.lang.reflect.InvocationTargetException: null
  at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
  at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
  at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
  at java.lang.reflect.Constructor.newInstance(Constructor.java:422)
  at akka.util.Reflect$.instantiate(Reflect.scala:66)
  at akka.actor.ArgsReflectConstructor.produce(Props.scala:355)
  at akka.actor.Props.newActor(Props.scala:255)
  at akka.actor.ActorCell.newActor(ActorCell.scala:552)
  at akka.actor.ActorCell.create(ActorCell.scala:578)

@eprequejo Yeah, it seems your ensime-server crashes and therefore ensime-atom looses the connection. Maybe you could try with another editor and if it persists, open a bug on ensime-server.

I'm also falling to get it working with vim editor, I'll write on ensime-server, thanks for this!

Duplicate of #255


feat: Switch to :toc: left for the combined summary page

As the number of summaries will grow, the header of the combined summary page will get longer and longer.
A better solution is to use :toc: left, which has the added benefit of allowing skipping to a specific summary.
https://github.com/OurTechCommunity/catchup/blob/082cdefdf8c84b82663536244a76b694bc4bbbb5/summary/combined-summary.adoc#L4
Maybe look into making the sidebar collapsable.
Maybe reduce the summaries by one header level to allow subsections to be visible.

Oh yes, this is a good recommendation and we should implement this. Can you please open a PR for this?

Maybe look into making the sidebar collapsable.

That is a good idea, but I don't think Asciidoctor has built-in support for it. We can build something for ourselves or contribute to Asciidoctor and we can do that asynchronously, but for now we should just shift the Table of Contents (ToC) to the left. The collapsible feature would anyways really be very useful only on smaller desktop screens, I guess, to make more space for the content. A left ToC should be manageable for larger/normal-sized desktop screens IMO.

Maybe reduce the summaries by one header level to allow subsections to be visible.

I don't think this is really required, as the sub-sections are repetitive and can be scrolled to very easily. It will make the ToC list too long as well. (Remember that on mobile screens or very small screen sizes, the ToC will still appear on the top, so we would want to avoid unnecessary listings in the ToC to reduce its length.)

Resolved in commit ae639b06e6316cf7f6d76bb36f72ea50761ed30b.


Checkbox: Label is not read using Voice Over in Safari

Describe the bug
When navigating the checkbox page at https://sanomalearning.design/categories/components/checkbox/ I'm not able to hear the label of the checkboxes.
To Reproduce
Steps to reproduce the behavior:

Open Safari.
Go to https://sanomalearning.design/categories/components/checkbox/
Start Voice Over (if not running already)
Use Tab to navigate to the Checkbox group (a skip link at the top of the page would be nice :-) )
Notice that as you navigate within the checkboxes using arrow keys, it does not read the label.

Expected behavior
I expect to hear the label.
Screenshots

Desktop (please complete the following information):

OS: [macOS 13.6.1]
Browser [Safari 17.1.2]

It is read in Chomium and Firefox using Voice Over on the same example.

And testing the checkbox at https://kind-plant-088739303.1.azurestaticapps.net/?path=/story/checkbox--api&globals=theme:itslearning, the visual label is not read, but there is another label (using aria-label I take it) that is being read.
So it's just the example on the documentation page that fails for me in Safari.

@furstenberg we've made some changes to the sl-checkbox and sl-checkbox group. Can you please take a look at the version we currently have in storybook https://storybook.sanomalearning.design/?path=/story/form-checkbox--basic and on the website https://sanomalearning.design/categories/components/checkbox/usage/ and let us know if you can still reproduce the bug?

The label is now indeed read. So the issue I reported appears to be fixed. :-)
I did notice another issue though. The state of the checkbox is not read.
Using Voice Over in Safari, you can see in these videos that all checkboxes are reported as "unticked" even though some of them are "ticked". Voice Over uses "ticket" and "unticked" where other screen readers might use "checked" and "unchecked".
https://github.com/sl-design-system/components/assets/18802/633c50a1-b5af-4cea-95a5-562149af2929
https://github.com/sl-design-system/components/assets/18802/7eaa7142-5924-4793-a105-7292e20fa654

@furstenberg We've added another changes to the sl-checkbox component, can you please take a look once again?
In storybook: https://kind-plant-088739303-1330.westeurope.1.azurestaticapps.net/?path=/story/getting-started-checklist--basic and on the website: https://proud-water-0d02ee203-1330.westeurope.2.azurestaticapps.net/
The problem with not read checkbox state in Safari should be fixed.

Hi.
The checkbox now works as expected in Safari using Voice Over. :-)


fix broken builds due to pip upgrade which broke pip-tools

Description
Fix broken builds due to pip upgrade which broke pip-tools by pinning to older version of pip for now
See issue:
https://github.com/jazzband/pip-tools/issues/1558
and fix currently as an open PR:
https://github.com/jazzband/pip-tools/pull/1559
Areas changed

npm packages changed:

[ ] responsibleai/causality
[ ] responsibleai/core-ui
[ ] responsibleai/counterfactuals
[ ] responsibleai/dataset-explorer
[ ] responsibleai/fairness
[ ] responsibleai/interpret
[ ] responsibleai/localization
[ ] responsibleai/mlchartlib
[ ] responsibleai/model-assessment

Python packages changed:

[ ] raiwidgets
[ ] responsibleai
[ ] erroranalysis
[ ] rai_core_flask

Tests

[x] No new tests required.
[ ] New tests for the added feature are part of this PR.
[ ] I validated the changes manually.

Screenshots (if appropriate):
Documentation:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Codecov Report

Merging #1185 (3c7a55e) into main (39a7ff8) will increase coverage by 7.81%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1185      +/-   ##
==========================================
+ Coverage   67.76%   75.58%   +7.81%
==========================================
  Files          90       10      -80
  Lines        4291      258    -4033
==========================================
- Hits         2908      195    -2713
+ Misses       1383       63    -1320

Flag
Coverage Δ

unittests
75.58% <ø> (+7.81%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

erroranalysis/erroranalysis/_internal/metrics.py

responsibleai/responsibleai/_input_processing.py

erroranalysis/erroranalysis/analyzer/__init__.py

...idgets/raiwidgets/responsibleai_dashboard_input.py

responsibleai/responsibleai/_interfaces.py

.../responsibleai/_managers/error_analysis_manager.py

responsibleai/responsibleai/_internal/constants.py

...ibleai/responsibleai/managers/explainer_manager.py

...bleai/responsibleai/_tools/causal/causal_result.py

raiwidgets/raiwidgets/responsibleai_dashboard.py

... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39a7ff8...3c7a55e. Read the comment docs.

force merging due to flaky test


Add Playwright as another E2E testing framework option

Why
Add an alternative option to Cypress, and its limitation on having asynchronous tests
Who Benefits?
Developers 🤗

TODO: Add more ticket details to clarify the issue


Lint configuration missing

I was setting up this project locally based on the Development section of the readme and discovered the lint command is not working. It looks like eslint-config-airbnb was removed from package.json in fbea1c9. When I add this back in, it runs but finds 4 errors. Is adding this config back the desired approach? If so, ok if I look into fixing the errors, too?

This was fixed!


Fixed issue with not provided cloud config

cc @fgrzadkowski @jszczepkowski

Test fail is unrelated. Issue filled https://github.com/kubernetes/contrib/issues/1118.

LGTM


retries for group_manifests plugin

Signed-off-by: Robert Cerven<EMAIL_ADDRESS>

Need retries for:

check_output of manifest-tool runs
replace retries code in get_manifest_digests
no need to response.raise_for_status() in get_worker_manifest if it 404 - otherwise it would take 15 mins to realize that Pulp doesn't support schema 2

It might be easier to add check_output retries once we have a solution for git clone as it is a similar problem.
Not sure whta you mean by replacing retries code in get_manifest_digests.
Why isn't response.raise_for_status() needed for 404? This plugin does not interact with Pulp, only with the Docker distribution registry.

Not sure whta you mean by replacing retries code in get_manifest_digests.

Right, this code was already updated

Why isn't response.raise_for_status() needed for 404? This plugin does not interact with Pulp, only with the Docker distribution registry.

I was thinking registry (and pulp) would return 404 when a different schema is tried, but its actually 400, so nevermind

Not updating release notes draft because this is bugfix to an unreleased feature.


Jv change executable file path

Description
Integration test where argv[0] is changed after creating a listening endpoint. This makes it so that readlink exe and cmdline give different executable file paths.
Checklist

[ ] Investigated and inspected CI test results
[ ] Updated documentation accordingly

Automated testing

[ ] Added unit tests
[ ] Added integration tests
[ ] Added regression tests

If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.

Just out of curiosity, what are the test case expectations exactly, why this combination of fork/exec/listen/filepath? Could it be written somewhere in the plain text?


Vegas slideshow working in Google Chrome, but not Safari

Hi, i'm having some problems with vegas slideshow. It works fine in google chrome, but does not load in Safari. I've checked the debug console and there are no errors. I'm a little stumped here, any help would be appreciated!
You can check out the site via www.uglyhussle.com - please let me know if you need code posted

it's on the second page, after scrolling, btw.

false alarm guys -- simple(painful) mistake of me placing the container out the viewport haha.


stable-diffusion-v1-5 inaccessible

Hi,
Thanks again for this great work!
I'm encountering an issue when trying to use the code. Here’s the error message I receive:
loading LoRA with token azertyuiop
Couldn't connect to the Hub: 404 Client Error. (Request ID: Root=1-66e985f5-3f86e6850e6230a815cd36fb;a533c066-f43a-4967-9ddb-9fac036937e0)

Repository Not Found for url: https://huggingface.co/api/models/runwayml/stable-diffusion-v1-5.

stable-diffusion-v1-5 is inaccessible now. Is there an alternative plan for this?
Thanks a lot for your help!

Hi Zhening, I wasn't aware Runaway took down the v1.5 models, thanks for pointing it out here! It appears some users made these weights available again via HuggingFace, see here. If you replace the path in our code, it will work fine. Also if you want to try out a different version of SD, you can for example use SDv2 from StabilityAI, I remember trying it out. I hope this helps you!

Thanks a lot, I used https://huggingface.co/benjamin-paine/stable-diffusion-v1-5 and it works fine now!


Modal Interactive in Vscode Desktop App

Hello. Big fan of modal here!
I was wondering what the best way is to run modal interactively in the vscode desktop app.
The command
modal launch vscode

launches vscode in the browser. How can I run this in the vscode desktop app instead of the browser?
The command modal launch vscode connects to vscode via http (source). Is there some way to use http to connect to the vscode desktop app rather than the in-browser vscode? I'm not to familiar with http...
I also looked at the developing and debugging docs but this does not mention anything about modal launch.
Thanks!

Hi — you might be able to use vscode remote development via our tunnels feature, for this analogous to the Jupyter example in the docs. Let us know if you get it working!

PS feel free to reach out on modal.com/slack, we're typically much faster to respond there!


exception joining dataframes with different datatypes

In [71]: a=DataFrame(randn(10,2),columns=['a','b'])
In [72]: b=DataFrame(randn(10,1),columns=['c']).astype(np.float32)
In [73]: a.join(b)
TypeError                                 Traceback (most recent call last)
/Users/c.prinoth/ in ()
----> 1 a.join(b)
/usr/local/Cellar/python/2.7.2/lib/python2.7/site-packages/pandas/core/frame.pyc in join(self, other, on, how, lsuffix, rsuffix)
2614             return self._join_on(other, on, how, lsuffix, rsuffix)
2615         else:
-> 2616             return self._join_index(other, how, lsuffix, rsuffix)
2617
2618     def _join_on(self, other, on, how, lsuffix, rsuffix):
/usr/local/Cellar/python/2.7.2/lib/python2.7/site-packages/pandas/core/frame.pyc in _join_index(self, other, how, lsuffix, rsuffix)
2649
2650         # this will always ensure copied data
-> 2651         merged_data = join_managers(thisdata, otherdata, axis=1, how=how)
2652         return self._constructor(merged_data)
2653
/usr/local/Cellar/python/2.7.2/lib/python2.7/site-packages/pandas/core/internals.pyc in join_managers(left, right, axis, how, copy)
1032 def join_managers(left, right, axis=1, how='left', copy=True):
1033     op = _JoinOperation(left, right, axis=axis, how=how)
-> 1034     return op.get_result(copy=copy)
1035
1036 class _JoinOperation(object):
/usr/local/Cellar/python/2.7.2/lib/python2.7/site-packages/pandas/core/internals.pyc in get_result(self, copy)
1090             if lblk and rblk:
1091                 # true merge, do not produce intermediate copy
-> 1092                 res_blk = self._merge_blocks(lblk, rblk)
1093             elif lblk:
1094                 res_blk = self._reindex_block(lblk, side='left')
/usr/local/Cellar/python/2.7.2/lib/python2.7/site-packages/pandas/core/internals.pyc in _merge_blocks(self, lblk, rblk)
1206         else:
1207             common.take_fast(rblk.values, ridx, None, False,
-> 1208                              axis=self.axis, out=out[lk:])
1209
1210         # does not sort
/usr/local/Cellar/python/2.7.2/lib/python2.7/site-packages/pandas/core/common.pyc in take_fast(arr, indexer, mask, needs_masking, axis, out)
247         return take_2d(arr, indexer, out=out, mask=mask,
248                        needs_masking=needs_masking,
--> 249                        axis=axis)
250
251     result = arr.take(indexer, axis=axis, out=out)
/usr/local/Cellar/python/2.7.2/lib/python2.7/site-packages/pandas/core/common.pyc in take_2d(arr, indexer, out, mask, needs_masking, axis)
232             needs_masking = mask.any()
233
--> 234         result = arr.take(indexer, axis=axis, out=out)
235         result = _maybe_mask(result, mask, needs_masking, axis=axis,
236                              out_passed=out is not None)
TypeError: array cannot be safely cast to required type
In [77]: a.dtypes
Out[77]:
a    float64
b    float64
In [78]: b.dtypes
Out[78]: c    float32

Fixed the underlying cause of this. Thanks for reporting


fix: compare time ranges using actual unix time vs objects

We want to avoid false detection of stale time lines and compare using the underlying moment.unix() time stamp for the froms and the tos, so that we don't accidentally compare object instances.
See:

https://github.com/grafana/grafana/issues/78185

@darrenjaneczek added a release label, so there should be a new release soon of "@grafana/scenes"


Add certification tests for Hashicorp Vault

The HashiCorp Vault Secret Store Component requires certification tests to be created.
Add conformance tests if not present.

/assign

This is incomplete.
The Hashicorp Vault Certification tests created by @tmacam and merged by @artursouza are incomplete and don't cover most metadata options at this time. Hence this task was not complete yet.

Given this is incomplete, I think we should mark the component as Beta for now @artursouza @tmacam. It will be stable once we complete the remaining certification test scenarios.

I will send a PR later this week with the remaining tests,


ARROW-7103: [R] Various minor cleanups

Remove covr from Suggests so that it is not installed in CI; add a note to the README about how to use it (following ARROW-7067)
Add a note to NEWS about the Datasets work that was just merged (following ARROW-6340)
Remove suggestion to install_github() because it's unlikely to work (based on user reports)
Move setting of ARROW_R_CXXFLAGS to before where a debug message prints the flags being used
Remove boost_filesystem from lib flags for macOS and Windows build scripts (following ARROW-6743)

@ursabot crossbow submit macos-r-autobrew


Timeline not working on arch linux

Hi,
The timeline is not working for me on arch linux.  It just show a wavy line like this : https://i.imgur.com/jefkuZs.png
I see that some people could not make it work before the support activated something for them.
Could it be the same issue?

I will do some tests to see if I can replicate. The timeline data is sent in 15 minute chunks so the first data should be available after 15 minutes of timeline tracking.

Yeah, I read about the 15 minutes. So I waited, but still no result hours later :confused:
Will contact support too (like it was suggested in the other similar issues)

Hello Joe! I've enabled Timeline on our end; just reload the desktop app and you should be good to go! Let us know if everything starts working OK for you 👍

It works! Thanks!


no grammar

ralf@ark:~/wikidata/grammar-python-antlr/scripts> . genpython.sh
cp: cannot stat '../../grammar/ShExDoc.g4': No such file or directory
error(7):  cannot find or open file: ShExDoc.g4
rm: cannot remove 'ShExDoc.g4': No such file or directory

Why is this script reaching outside the repo directory? Where do I get ShExDoc.g4 ?

I see. I suggest to add a remark to the README and to make the g4 file path a parameter of genpython.sh. I'll do a pull request for each.

Our grand plan is/was to make grammar-python-antlr a sub-repo of shexSpec/grammar. In the cases where it was checked out automagically by git clone --recursive, ../ShExDoc.g4 might be a good default.


Should train.py and train_cart.py share the totally same parameters?

Should train.py and train_cart.py share the same "number of steps" and the totally same parameters in
"TRAIN" : 		{ 				"if_validate": true, 				"epochs" : 1000, 				"batch_size" : 3, 				"focal_loss_iou_threshold" : 0.3, 				"log_dir": "./logs/RadarResNet", 				"learningrate_init": 0.0001, 				"learningrate_end": 0.00001, 				"learningrate_decay": 0.96, 				"learningrate_decay_gap": 3000, 				"startup_steps": 1000, 				"learningrate_startup": 0.0001, 				"warmup_steps": 20000, 				"validate_start_steps": 2000, 				"validate_gap": 2000 		}, ?
Thanks a lot!

yes, as i tried the same so the results are ok.

yes, as i tried the same so the results are ok.

Thanks a lot. Here

yes, as i tried the same so the results are ok.

Thank a lot. I want to ask you another question. Can you tell me if the CONFIDENCE LOSS goes down for a while and then goes up in your results?

Here is the picture of my result.


Send money - User can send money to group by modifying the URL to ../send/new/..

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.81-6
Reproducible in staging?: Yes
Reproducible in production?: No. Send money is not available on prod
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:  Applause - Internal Team
Slack conversation:
Action Performed:

Go to staging.new.expensify.com
Go to any group chat
Modify the link to staging.new.expensify.com/send/new/<groupchat_ID>
Proceed with sending money process

Expected Result:
When navigating to staging.new.expensify.com/send/new/<groupchat_ID>, error should show up
Actual Result:
When navigating to staging.new.expensify.com/send/new/<groupchat_ID>, user can proceed with sending money to the group
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/78819774/40f4c6e7-f350-499b-9c13-e8d1e9836285

MacOS: Desktop

View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
Send money - User can send money to group by modifying the URL to ../send/new/..
What is the root cause of that problem?
This problem exists for all kind of iou requests. We have not implemented any conditions to prevent such cases.
I found this comment describing a function which is used to show available iou actions in report + button. Based on this comment we can see which combinations are not allowed, like send request in non 1:1 chats, or split in 1:1 chats
https://github.com/Expensify/App/blob/8c73c2bc0728d2bb56c3036406949120d0167d0b/src/libs/ReportUtils.js#L3353-L3376
What changes do you think we should make in order to solve the problem?
We can leverage this getMoneyRequestOptions function to check if iou request is valid or not and show NotFoundPage in corresponding places
https://github.com/Expensify/App/blob/main/src/pages/iou/MoneyRequestSelectorPage.js#L92
like this:
                <FullPageNotFoundView shouldShow={!IOUUtils.isValidMoneyRequestType(iouType) || (!isFromGlobalCreate && !ReportUtils.getMoneyRequestOptions(props.report,props. report.participantAccountIDs).includes(iouType))}>

This will ensure that combination of current report and iou type is allowed one, and prevent from unwanted cases.
Note that, we only apply this check if route has report params, not creating new without selecting report yet.
What alternative solutions did you explore? (Optional)
If this usage is confusing or overloads a function usage, we can create similar function which will check for above cases based on conditions similar to getMoneyRequestOptions conditions

I don't think this is Deploy blocker since we can reproduce similar issue using .../split/new/...  in 1:1 chats.

cc @techievivek since this seems related to your recent Send Money PR

I'm removing the blocker label because this is a new feature we’re bringing back, we can’t easily revert it, and the fix won’t be super quick, so we should not block everything on it. Also the reproduction steps for this one are pretty weird.

I'm assuming we don't want to allow sending money to a group because it's unclear who the money is being sent to. If that's correct we should fix it on the backend too. I'm re-assigning this to @techievivek because it's related to a project he is working on.

As mentioned by Ali this seems to happen for all iou requests so it makes sense not to hold this as a blocker, thanks for handling it.

If that's correct we should fix it on the backend too.

We expect to only see a singe user for send money requests so we are already handling this.

I think a minor fix is required here to prevent users from accessing send money or any other IOU flow, and we have the logic in the backend to help us deny such requests, so I have updated the bounty to only $100.

@hannojg  Update it to 250, but I think these are minor fixes with no edge case(hopefully) and shouldn't take long other than just verifying it across platforms.
can you please review the proposal posted by Ali, thanks.

@techievivek @muttmuure This issue is a dupe and will get fixed here: https://github.com/Expensify/App/issues/26523

@techievivek did you tag me by accident? I don't see why I was tagged

@hannojg

did you tag me by accident? I don't see why I was tagged

Sorry, I tagged you by accident 😄

The issue https://github.com/Expensify/App/issues/26523 is requesting money, this issue is sending money. But because they share the same component. So looks like we can fix them together.

Yes, that will be great.

@alitoshmatov Do you mind posting your proposal to the other issue so we can tackle them all together.

@techievivek Looks like proposal(https://github.com/Expensify/App/issues/26523#issuecomment-1703288168) provided in that issue is very similar to mine and solve the issue. So I think there is no need for my proposal

This is a duplicate of https://github.com/Expensify/App/issues/26523 so I will close this one.


Bucket Sort in C++

I would like to add Bucket Sort in C++ as a part of DWOC. @shraddhavp @anushkrishnav Could you assign me this issue?

is this issue still open?

is this issue still open?

I am working on it @am-here

@shraddhavp @anushkrishnav Can I implement Bucket Sort in Go as well?

@shraddhavp @anushkrishnav Can I implement Bucket Sort in Go

I would like to add Bucket Sort in C++ without using Insertion Sort as a part of DWOC. @shraddhavp @anushkrishnav Could you assign me this issue?

You can implement this but it would be better if you can add the required changes in the existing Bucket Sort file, and make proper changes in the driver code to format the output.

@shraddhavp @anushkrishnav Can I implement Bucket Sort in Go as well?

Sure, go ahead.

@shraddhavp @anushkrishnav Can I implement Bucket Sort in Go

I would like to add Bucket Sort in C++ without using Insertion Sort as a part of DWOC. @shraddhavp @anushkrishnav Could you assign me this issue?

You can implement this but it would be better if you can add the required changes in the existing Bucket Sort file, and make proper changes in the driver code to format the output.

Okay will make the changes in it and raise a pr.


Decoder: Allow double space before tag. Fixes #243

I'm not sure if this is strickly permitted in the GEDCOM standard and the extra space will not be retained when encoded.

This change is

Codecov Report

Merging #244 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #244   +/-   ##
======================================
  Coverage    65.1%   65.1%
======================================
  Files         191     191
  Lines        6188    6188
======================================
  Hits         4029    4029
  Misses       2029    2029
  Partials      130     130

Impacted Files
Coverage Δ

decoder.go
95.86% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a04449...ba2e951. Read the comment docs.


Missing context for method declaration

Hi, I followed all steps to install and link all dependencies but after putting the code in AppDelegate.m I get the following error:

Any help appreciated.

Hey @gsdias!
I think the problem is that you need to define that method after the @implementation AppDelegate line and before the @end statement in your AppDelegate.m file. See the example below:
#import "AppDelegate.h"

#import "RCTBundleURLProvider.h"
#import "RCTRootView.h"
#import "RNQuickActionManager.h"

@implementation AppDelegate

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
  // SNIP
}

- (void)application:(UIApplication *)application performActionForShortcutItem:(UIApplicationShortcutItem *)shortcutItem completionHandler:(void (^)(BOOL succeeded)) completionHandler {
  [RNQuickActionManager onQuickActionPress:shortcutItem completionHandler:completionHandler];
}

@end

Our README could be clearer about that. Let me know if that resolves your issue 🚒

Hi @jordanbyron, yes I manage to find the same solution. Including that code inside implementation AppDelegate fixes the problema and works just fine. Tks.


Sync observability improvements branch with master branch

Purpose

Sync observability improvements branch with master branch

Codecov Report

Merging #22347 into observability-improvements will not change coverage by %.
The diff coverage is n/a.

@@                     Coverage Diff                     @@
##           observability-improvements   #22347   +/-   ##
===========================================================
  Coverage                       14.59%   14.59%
===========================================================
  Files                              51       51
  Lines                            1411     1411
  Branches                          219      219
===========================================================
  Hits                              206      206
  Misses                           1189     1189
  Partials                           16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 976c333...976c333. Read the comment docs.


added snapdragon rc pwm driver

This branch can be used to fly snapdragon with Pixfalcon / Pixracer or Pixhawk as companion for rc input and pwm output.
You can flash this branch onto the Snapdragon AND the Pixfalcon.
You will have to configure e.g. the Pixfalcon such that it suits the vehicle you are flying. This is because the mixing is happening on the Pixfalcon and not on the Snapdragon.
This step allowed much easier integration of the two systems.
Also make sure to calibrate the rc on both the Pixfalcon and the Snapdragon. The vehicle can be armed as usual with the safety switch and the rc control.
Comment: The actuator commands are sent form Snapdragon to Pixfalcon using UART at 115200 bit/s. It appears that this link is too slow to run at 250 Hz, therefore there is a usleep(5000) in uart_esc.cpp at line 474. We need so see if we can run the UART at a higher rate.
https://github.com/PX4/Firmware/blob/rc_pwm/src/drivers/uart_esc/uart_esc.cpp#L474
The UART on the Pixfalcon which is used to communicate with Snapdragon is specified here
https://github.com/PX4/Firmware/blob/rc_pwm/ROMFS/px4fmu_common/init.d/rcS#L817
Make sure that this replicates the port you are using. This is tested with the Pixfalcon!
You will have to create a serial cable with connects the ESC connector J12 J13 to the serial output of the Pixfalcon (telem output).
This branch was tested on a quad in the lab, see video below.
https://www.youtube.com/watch?v=spBVfxyKi3Q&feature=youtu.be
Summary:

Flash this branch to Pixfalcon using make px4fmu_v2_default upload

Flash this branch onto the Snapdragon using the commands in the devguide

Push the startup scripts onto the Snapdragon (they have been modified)

Do the complete setup of the Pixfalcon via QGC as if you wanted it to fly the quad you are using.
This is important because otherwise Pixfalcon will not arm and so no pwm is output.

Do the rc calibration on the Snapdragon after you have connected the system together.

Start mainapp on the snapdragon

Switch safety off on the Pixfalcon and try to arm the system via rc.

Impressive PR documentation!

Impressive PR docs!

The overall implementation makes sense and its great to see a proper MAVLink interface! We still have some architectural work to do, since our goal is use a single link implementation, not just replace the previous encoding with MAVLink encoding. I think there are three things that we likely will want to improve:

Switch to 921600 baud. There should be nothing holding us back from using a slower baud rate.
We should use the same API as for offboard control on Pixhawk, because this is essentially the very same use case. This means using the normal MAVLink app on the Pixhawk side and publishing the actuator controls there. The code for this is already present.
Enable offboard mode by default in a new config for Pixhawk, but allow to override it with the offboard switch if configured. This will allow us to use Pixhawk as safety net if the main flight solution fails.

All of this is already present in the current architecture, so it's merely a question of integration and testing.

If you add a new config (instead of editing the main startup script on Pixhawk) we could merge this state as-is and replace the standalone app with the default MAVLink app once we're done. As this already works it would be good to get it in.

@julianoes thanks for keeping this going!

@tumbili no worries, I'm currently working on integrating ekf2. Once that's done, I'll consolidate these changes.

@julianoes @tumbili Once the autostart is done according to this guide instead of hardcoded this would be good to go:
http://dev.px4.io/airframes-adding-a-new-frame.html
The driver app should be build for FMUv2 and v4 (Pixfalcon and Pixracer).

@LorenzMeier I'm on this and I'll get to the autostart, thanks for the link.

@LorenzMeier:

We should use the same API as for offboard control on Pixhawk, because this is essentially the very same use case. This means using the normal MAVLink app on the Pixhawk side and publishing the actuator controls there. The code for this is already present.

Which mavlink message do you suggest?

ACTUATOR_CONTROL_TARGET. But not right now. Right now we should just make this a little cleaner / easier to use in the startup config and get it in.

Ok, I just realized that the uart_esc driver is actually made for the Qualcomm 4in1 ESCs but has now been bastardized for mavlink communication. I think I should either split the code in two modules, or just delete all Qualcomm specifc stuff because I have no way to test it.

Delete all Qualcomm specific stuff. The Qualcomm ESC doesn't really exist in the wild, and there is no point for us right now in supporting it.

Ok, will do, and if we ever need it again we'll go back in time :).

I've pushed the changes that were needed to get this to fly. There are various issues remaining but stabilized flight was possible.
I think the current changes don't break anything else, so we can merge this to master.
Since I was using an old Pixracer as IO board for which params don't work, I needed the following hack locally:
diff --git a/ROMFS/px4fmu_common/init.d/rcS b/ROMFS/px4fmu_common/init.d/rcS
index 97b98fe..12ba08e 100644
--- a/ROMFS/px4fmu_common/init.d/rcS
+++ b/ROMFS/px4fmu_common/init.d/rcS
@@ -87,6 +87,12 @@ then
 	fi

 	#
+	# XXX: Hack to have passthrough mode on old Pixracer boards
+	#
+	param set SYS_AUTOSTART 20000
+	param save
+
+	#
 	# Start system state indicator
 	#
 	if rgbled start

Merged, thanks @tumbili and @julianoes


Data tree won't stay expanded in Data Explorer in devtools

Describe the bug
The data tree in devtools won't stay open, it just minimizes almost right away. It seems like it won't remember the open/close state and goes back to the initial one (closed).
This started happen in version 3.34.17 and is still visible in the latest version 3.39.1.
I will attach two videos of this, one from version 3.34.16 that works as it should and one from 3.39.1 that doesn't work as it should.
Look at the Elements tab in Chrome devtools in the video, you will see a lot of rerenders which doesn't happen in version 3.34.16 and lower. When those rerenders happen, the tree minimizes right away.
Your minimal, reproducible example

Steps to reproduce
Open devtools, expand some data in Data Explorer. It will minimize itself instead of stay open.
Expected behavior
I expect the data tree to stay open.
How often does this bug happen?
Every time
Screenshots or Videos
Version 3.34.16
https://user-images.githubusercontent.com/26097801/172307897-09f274c6-d017-4f7c-bf18-d29f0f532201.mov
Version 3.39.1
https://user-images.githubusercontent.com/26097801/172308444-23d6bb04-2d58-4fea-a0aa-79311fb5c603.mov
Platform

macOS - version 12.3
Electron - version 19.0.1
React Native Web - 0.17.7

react-query version
v3.39.1
TypeScript version
v4.3.5
Additional context
No response

I just tried it out in our first codesandbox example, and it works just fine?
https://codesandbox.io/s/github/tannerlinsley/react-query/tree/master/examples/simple
can you please provide some way to reproduce the issue other than some videos?

I did test it in codesandbox also, but could not reproduce it there either.
The change happened between version 3.34.16 and version. 3.34.17 so something has been changed between those versions.
I have a very data intensive app that refetches a lot of data every 5 seconds. It could be related to that, but I will try to create a new Codesandbox that simulates my app to see if this happens.

I just tried to set refetchInterval to a low number in useQuery in that codesandbox that you linked to and I could reproduce it there as well.

@mathias-berg then please add that codesandbox to the issue description

Fixed!


Tweak the base key notion

Revisit the core problem and fix that.

This would be with a view to replacing the System variant of PublicKey and Signature.

@Fraser999 Could we retitle this to specify Cryptographic key, cause the base key notion I figure implies our trie Keys


fix: middleware wrapper

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

onRequest
Not awaiting sendWebResponse can cause event.handled to not be true by the time h3 checks it and the next hook/handler will potentially be called.
https://github.com/unjs/h3/blob/6d1e48438bcbbecfaafa4b9fb800bfb1a03ee592/src/event/utils.ts#L76-L83
https://github.com/unjs/h3/blob/6d1e48438bcbbecfaafa4b9fb800bfb1a03ee592/src/utils/response.ts#L531
Reproduction:

Refresh enough times and you will get one of 3 results.

Page instead of file content
File content with wrong content-type header
Crash ERR_STREAM_WRITE_AFTER_END

onBeforeResponse
Calling sendWebResponse in here does not seem to be supported. There are no checks for event.handled by h3 unlike for onRequest and the next hook will be called.
https://github.com/unjs/h3/blob/6d1e48438bcbbecfaafa4b9fb800bfb1a03ee592/src/event/utils.ts#L84-L91
Reproduction:

Refresh enough times and you will get one of 3 results.

Page with wrong content-type header
File content with correct content-type header
Crash ERR_STREAM_WRITE_AFTER_END

What is the new behavior?
onRequest
Await sendWebResponse
onBeforeResponse
Assign return value to response.body instead of calling sendWebResponse. With this the response value of handler or previous hook will be replaced.
H3 will call sendWebResponse for Response objects.
https://github.com/unjs/h3/blob/6d1e48438bcbbecfaafa4b9fb800bfb1a03ee592/src/app.ts#L185
https://github.com/unjs/h3/blob/6d1e48438bcbbecfaafa4b9fb800bfb1a03ee592/src/app.ts#L277-L279
Other information

Related issues:
https://github.com/solidjs/solid-start/issues/1523
https://github.com/nksaraf/vinxi/issues/292

I had a suspicion there was was some timing disconnect here but I hadn't gotten into it. Your explanation makes sense to me.  Very much appreciate you looking into this.

+1 for making it as close to the Nitro/h3 design as possible. One additional thought that I wanna leave here is about h3 v2: the new way will be to return the value/Response/stream directly instead of using sendXYZ(xyz) in eventHandlers. As it currently stands utilities like sendWebResponse will be deprecated in v2 https://github.com/unjs/h3/blob/cda0bb29b243625516aa57e9497126e8d3594c7f/MIGRATION.md#response-handling

I don't have much of an opinion about returning a response. It's an additional option that h3 doesn't have. Maybe convenient to some and makes onRequest and onBeforeResponse a bit similar/consistent.
@katywings Unclear to me if this applies to event handler hooks in v2. They don't seem to have changed much and return value of onRequest isn't handled. Mybe work in progress or I am missing something. https://github.com/unjs/h3/blob/cda0bb29b243625516aa57e9497126e8d3594c7f/src/handler.ts#L81


Add RateLimiter config property to enable limiting on specific nodes

Added ratelimiter config property nodesEnabled
App can set comma separated list of solr nodes to enable ratelimiter on those nodes only. Example "nodesEnabled": "localhost"

This looks good now I think (again, provisionally, with the expectation that we'll revert and pursue similar upstream).
I edited the issue title to be more descriptive.

Definitely, that should part of whole pluggable architecture proposal.


Android not working anymore with Expo SDK 48? List of tested dependencies available?

Describe the bug
Any time you start dragging, the selected element instantly becomes first in the list. It does not even matter if you drag down or up. See gif here:

Bug appeared after upgrading Expo SDK 47 to 48 (and all involved dependencies).
To Reproduce
My app is open source, if you like to verify: https://github.com/tomwaitforitmy/mangi-bevi
Platform & Dependencies
Please list any  applicable dependencies in addition to those below (react-navigation etc).

react-native-draggable-flatlist version: 3.1.2
Platform: Android
React Native or Expo version: react-native: 0.71.8 expo: 48.0.15
Reanimated version: 2.14.4
React Native Gesture Handler version: 2.9.0

Additional context
react-native-draggable-flatlist version: 3.1.2 worked fine on Android and iOS with Expo SDK 47. After migrating to Expo SDK 48, I found out that it is not working on Android anymore. I tried upgrading to 4.0.1, but that only breaks iOS as well and introduces a lot of flickering. Since 3.1.2 seems to be an older version, I don't expect any fixes, but is there is a list of compatible/tested Expo/React native versions anywhere? Docs are very sparse on what works and what doesn't.
Is there a chance, that this works again with a newer Expo version supporting newer versions of Reanimated/Gesture Handler?

I upgraded to SDK 49 and installed "react-native-draggable-flatlist": "^4.0.1" which fixed the issue for me. It is not running super smooth, but it works more or less. It used to be much better in Expo SDK 47 on Android, however.


ProtocolError raised when used in flexible environments w/custom runtime

I just tried this code with gcloud==0.12.1 in my Flask app that's running in a custom runtime of the flexible environments (formerly managed vms). I'm using the .patch() method and calling it before any of my code runs. The following is the traceback that I see.
Traceback (most recent call last):
  File "/env/local/lib/python2.7/site-packages/flask/app.py", line 1817, in wsgi_app
    response = self.full_dispatch_request()
  File "/env/local/lib/python2.7/site-packages/flask/app.py", line 1477, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/env/local/lib/python2.7/site-packages/flask/app.py", line 1381, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/env/local/lib/python2.7/site-packages/flask/app.py", line 1475, in full_dispatch_request
    rv = self.dispatch_request()
  File "/env/local/lib/python2.7/site-packages/flask/app.py", line 1461, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/vmagent/app/backend/application/indexing/views.py", line 380, in index_sequential_backup_file
    fp = _open_gcs_file(bucket, filename)
  File "/home/vmagent/app/backend/application/indexing/views.py", line 74, in _open_gcs_file
    bucket = gcs_client.get_bucket(bucket_name)
  File "/env/local/lib/python2.7/site-packages/gcloud/storage/client.py", line 167, in get_bucket
    bucket.reload(client=self)
  File "/env/local/lib/python2.7/site-packages/gcloud/storage/_helpers.py", line 77, in reload
    _target_object=self)
  File "/env/local/lib/python2.7/site-packages/gcloud/connection.py", line 339, in api_request
    target_object=_target_object)
  File "/env/local/lib/python2.7/site-packages/gcloud/connection.py", line 240, in _make_request
    return self._do_request(method, url, headers, data, target_object)
  File "/env/local/lib/python2.7/site-packages/gcloud/connection.py", line 269, in _do_request
    body=data)
  File "/env/local/lib/python2.7/site-packages/oauth2client/client.py", line 597, in new_request
    self._refresh(request_orig)
  File "/env/local/lib/python2.7/site-packages/oauth2client/client.py", line 863, in _refresh
    self._do_refresh_request(http_request)
  File "/env/local/lib/python2.7/site-packages/oauth2client/client.py", line 895, in _do_refresh_request
    self.token_uri, method='POST', body=body, headers=headers)
  File "/env/local/lib/python2.7/site-packages/httplib2/__init__.py", line 1609, in request
    (response, content) = self._request(conn, authority, uri, request_uri, method, body, headers, redirections, cachekey)
  File "/env/local/lib/python2.7/site-packages/httplib2/__init__.py", line 1351, in _request
    (response, content) = self._conn_request(conn, request_uri, method, body, headers)
  File "/env/local/lib/python2.7/site-packages/httplib2shim/__init__.py", line 133, in _conn_request
    raise _map_exception(e)
ProtocolError: ('Connection aborted.', BadStatusLine("''",))"

Thanks for reporting. Do you get this same issue when running locally?

I haven't tried it locally, but it would be in a Docker container and I'm not certain how the Google SDKs handle the differences.  Do you expect that it would work locally but has bugs in production?

gcloud-python itself doesn't care where you run. oauth2client does, but only in terms of what auth methods it tries.
I would expect the same error locally, docker container or not. If you can reproduce locally, it'll help us debug exactly what's going on.

Well, I spent a couple hours trying to get it to run locally but ended up hitting failures where the runtime tries to connect to Google's internal hostnames like this one.
I'm not sure where to go from here because there's really no documentation for running these locally.

Ah, you're using compat - compat explicitly can't be run locally.
Hmm. Can you try just running that piece of code locally without all of your other app stuff?

Seems to work locally.

Regarding compat: Would you mind asking someone from that team to update the docs to make it clear that it's not possible to run it locally? I wasted a lot of time trying and it would have been great to know that upfront.

You can run your app locally just not the full runtime, see here.

So, I'm interested in seeing where the compat runtimes causes this issue. Can you let me know if you got your application running under dev_appserver? And if so, can you tell me if the issue is present when using dev_appserver?

Closing this due to inactivity and due to the fact that the compat runtimes are now deprecated.


Access to googlesheet

Hi, I was trying to use selfdesctructin5::make_mdb_df()  but within  USAID network the access to the connection with Tidyverse API is blocked, Is possible to work with this package without connecting to the internet?

this has been fixed in the dev version and should now work without the need to access the USAID network. Note, if you are using the resolved known issues option, you will need to be connected to the network.


Support for multiple embeds in message routes

As mentioned in #995,  Discord's API now supports multiple embeds for message routes (https://discord.com/developers/docs/change-log#support-for-multiple-embeds-in-message-routes)
This change allows multiple embeds per message while maintaining backwards compatibility.

PR number 1000, yay :rocket:


Update packages

Updates:

openapi-generator version
fastapi
swagger version in react

Fixes:

trailing slash redirect

Adds:

mypy and fixes related issues

Looks good!
Though would you mind reverting the nagim-parser changes? I've go similar changes, plus some more for in a branch. No big deal if not, just wanted to avoid resolving conflicts.


Enable dependabot to automatically get dependency updates

It would be great to have Dependabot configured to get dependencies updates filed automatically. This will help avoiding bugs or security vulnerabilities from old dependencies.
Some helpful documentation about Dependabot to fine adjust it if needed:

Keeping your dependencies updated automatically: https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/keeping-your-dependencies-updated-automatically
Avoiding security vulnerabilities: https://docs.github.com/en/free-pro-team@latest/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates
Fine adjusting the configuration: https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/configuration-options-for-dependency-updates

cc: @gbois @marshall777

Superseded by #42


Add helm options for specifying ETCD CPU requests & limits

Coverage remained the same at 76.107% when pulling fc7b64b6d95b2b903cd88a3b3ac785f5fed9424e on rastislavszabo:master into 8bcf51320ddfc9985f4639dc4ba1fde32c262d74 on contiv:master.


Migrate intellij tests and context_test to null safety

Part of #71511

These aren't really related files, am trying to keep these migration reviews relatively small.


Endpoint for fetching the top releases for a given time period

I was really unsure where to put this endpoint, without pulling lot's of new dependencies into all the classes. This was my favorite, but I'm open for suggestions 😉 The endpoints take a time range, the minimum followers and how many releases to return.

 Top albums of the week


Using styled-jsx to merge traditional CSS with modern JS??

So i really want to get into using CSS in JS, but i really feel a lot of the time it's an "all or nothing" solution to a problem that mostly goes away if you just write well structured, namespaced CSS. It's great for components like a "button", but gets quite clunky when doing bigger things. Things that would be quite fast to write in vanilla HTML and CSS end up needing a React component and then tests, and it just gets a bit too unnecessarily abstract (like grids etc).
I'm a big fan of NextJS. And normally i include a base.css full of reusable patterns (written in Sass) in the head, and then start writing my app—only really using CSS in JS (styled-jsx) to enrich the patterns used in my base.css.
But a lot of the time, 50% of that css file goes to waste. It's not used in the app, which results in unnecessary downloaded bytes. This is why CSS in JS appeals to me, as you get dead code elimination for free.
I'd really like to convert my CSS pattern library (a group of reusable CSS objects, that just structure content, and don't add any visual styling like colours etc) to use something like styled-jsx. The idea would be if i exported each block small enough, I could just import the sections each component needed and then i'd get a ton of dead code elimination as i visit each page.
I'm trying out a few things, and would really like someone's input on whether i've completely lost the point with this CSS in JS stuff, or whether there's some sense in what i'm doing.
Here's an example of a CSS pattern called the block pattern that i've attempted to port over.
import css from 'styled-jsx/css';
import { globalSpacingUnit, spacingUnit } from '../settings/settings';

/* ==========================================================================
#BLOCK
========================================================================== */

/**
 * Stacked image-with-text object. A simple abstraction to cover a very commonly
 * occurring design pattern.
 */

export base css`
.o-block {
    display: block;
    text-align: center;
}

.o-block__img {
    margin-bottom: ${globalSpacingUnit}px;
}

.o-block__body {
    display: block;
}
`;

/* Size variants
====================================================================== */

export const flush = css`
.o-block--flush > .o-block__img {
    margin-bottom: 0;
}
`;

export const tiny = css`
.o-block--tiny > .o-block__img {
    margin-bottom: ${spacingUnit.tiny}px;
}
`;

export const small = css`
.o-block--small > .o-block__img {
    margin-bottom: ${spacingUnit.small}px;
}
`;

export const large = css`
.o-block--large > .o-block__img {
    margin-bottom: ${spacingUnit.large}px;
}
`;

export const huge = css`
.o-block--huge > .o-block__img {
    margin-bottom: ${spacingUnit.huge}px;
}
`;

/* Alignment variants
========================================================================== */
export const right = css`
.o-block--right {
    text-align: right;
}
`;

export const left = css`
.o-block--left {
    text-align: left;
}
`;

This could then be consumed in a component like so:
import React from 'react';
import { base, small, right }  from '../jss/objects/block';

export default () => (

This is some text.

);

I see these patterns as global styles. Then custom styling like colours can be scoped on the component.
What i notice straight away is there would be a hell of a lot of style tags if i did this. Is that scalable? Or am i going to hit problems?
Have i got the right idea? Or am i using styled-jsx wrong?
Another way i could do it is be a bit more clever with the composition of my styled jsx rules, as each of the variants in that css-jsx file depend on the base class/variable. So is there a way i can merge the rules?
Example:
export const base = css`
.o-block {
    display: block;
    text-align: center;
}

.o-block__img {
    margin-bottom: ${globalSpacingUnit}px;
}

.o-block__body {
    display: block;
}
`;

/* Size variants
====================================================================== */

export const flush = css`
{ ...base } /* <--- Some way to describe css class dependencies?? */
.o-block--flush > .o-block__img {
    margin-bottom: 0;
}
`;

flush requires base in order to work. I'm keen not to lose my syntax highlighting by removing the css function call, so it would be cool if i could say that flush requires base as a dependency.
That way, i'd only need to do:

Instead of:

What are people's thoughts?
I'm aware styled jsx is string based, and not object based (is that still true?), but if the styles are broken down small enough, importing just the bits you need should still be really beneficial.
I can definitely see that there's power in CSS in JS, but i'd really like to merge old world with new world. Traditional CSS enriched with JS to take advantage of the added benefits without losing the flexibility of writing raw HTML and CSS.

Hi @KingScooty styled-jsx is string based only and composition as you want it is not possible because of the way how we transpile our styles (it might be possible though in the future with this syntax https://github.com/zeit/styled-jsx/issues/383#issuecomment-358287330).
The cost of external styles right now is double see https://github.com/zeit/styled-jsx/issues/345 We will fix that in v3.
Doing dead code elimination with string based libraries is not that easy and can only be done for colocated and static styles only. That said when you use something like Next.js that does automatic code splitting for you having CSS in JS modules is nice. For completeness you could achieve the same using CSS Modules and including a common.css and page-name.css (page specific) bundles, but if you have ajax navigation etc you'd need to then to add/remove link tags on page transitions (I've built apps like this in the [very] past).
FYI styles in styled-jsx are de duped, meaning that the styles for .o-block will render only once in your page (even if you have multiple instances of the consumer component).
Looking at your examples I would say that maybe you can make a component library rather than importing the styles all the time. For instance I would use a Block component:
export default () => (
  <Block size="small" align="right">
    <Block.Image>

    </Block.Image>
    <Block.Body>

This is some text.

    </Block.Body>
  </Block>
)

// or

export default () => (
  <Block size="small" align="right">
    {{
      image: ,
      body:
This is some text.

    }}
  </Block>
)

Open to discuss on the merits of Object literals based CSS-in-JS solutions (something like React Native for Web's StyleSheet is next level imho).

Hi @giuseppeg! Thanks for the reply! #383 looks interesting! It would certainly add more power to styled-jsx.
I think you're right regarding building a component library as opposed to importing styles. The more i've played with various CSS in JS implementations, the more i've realised what i was doing was very unconventional.
I really like that syntax in your first example. I've not seen that before:
export default () => (
  <Block size="small" align="right">
    <Block.Image>

    </Block.Image>
    <Block.Body>

This is some text.

    </Block.Body>
  </Block>
)

How are those children blocks defined? (<Block.Image> etc.).  If you could show an example of what the definition of this component looks like that would be amazing.

@KingScooty not sure if that's the best pattern but I would implement that like this https://codepen.io/giuseppegurgone/pen/bLpaGW

@giuseppeg you're a star! Thanks so much for that example! I'd actually been trying out some of @jxnblk's tools this weekend, so it's nice how this fits in with Dan's comments over at macro-components!

Nice! I am going to close this issue but feel free to reply here if you need further help/want to brainstorm.


implement devfile conversion ( with --now support) on --s2i without --git flag

What type of PR is this?
/kind feature
What does does this PR do / why we need it:
when user provides --s2i flag on odo create we convert the s2i component into devfile and use that for all future workflows
Which issue(s) this PR fixes:
Fixes #4281
Fixes https://github.com/openshift/odo/issues/4527
PR acceptance criteria:

[ ] Unit test

[x] Integration test

[ ] Documentation

[x] I have read the test guidelines

How to test changes / Special notes to the reviewer:

I was trying to get nodejs-ex working with odo built from this PR. It seems like DEBUG_PORT value is not getting populated which is preventing the application from starting up.
Here's logs (odo log) from successful run when odo is built from current master:
+ run_node
++ node --version
+ echo -e 'Using Node.js version: v12.19.1'
Using Node.js version: v12.19.1
+ echo -e 'Environment: \n\tDEV_MODE=true\n\tNODE_ENV=development\n\tDEBUG_PORT=5858'
Environment:
	DEV_MODE=true
	NODE_ENV=development
	DEBUG_PORT=5858
++ id
+ echo -e 'Running as user uid=1000590000(1000590000) gid=0(root) groups=0(root),1000590000'
Running as user uid=1000590000(1000590000) gid=0(root) groups=0(root),1000590000
+ '[' true == true ']'
+ echo 'Launching via nodemon...'
Launching via nodemon...
+ exec npx nodemon --inspect=5858
[nodemon] master: <none>
[nodemon] to restart at any time, enter `rs`
[nodemon] watching: *.*
[nodemon] starting `node --inspect=5858 server.js`

And here's from unsuccessful run:
Using Node.js version: v10.24.0
Environment:
	DEV_MODE=true
	NODE_ENV=development
	DEBUG_PORT=
+ echo -e 'Using Node.js version: v10.24.0'
+ echo -e 'Environment: \n\tDEV_MODE=true\n\tNODE_ENV=development\n\tDEBUG_PORT='
++ id
Running as user uid=1000590000(1000590000) gid=0(root) groups=0(root),1000590000
Launching via nodemon...
+ echo -e 'Running as user uid=1000590000(1000590000) gid=0(root) groups=0(root),1000590000'
+ '[' true == true ']'
+ echo 'Launching via nodemon...'
+ exec npx nodemon --inspect=
[nodemon] master: <none>
[nodemon] to restart at any time, enter `rs`
[nodemon] watching: *.*
[nodemon] starting `node --inspect= server.js`
node: --inspect= requires an argument
[nodemon] app crashed - waiting for file changes before starting...
time="2021-03-19T13:31:35Z" level=debug msg="wait program exit" program=devrun

Since the DEBUG_PORT env var is not getting populated, the component is failing to start correctly.

@girishramnani @kadel would https://github.com/openshift/odo/issues/4197 help take care of the kind of issue I found here -  missing DEBUG_PORT causing failure in pod to start well?

@kadel @girishramnani Not sure if this is expected behaviour.
odo create --s2i --port works without an error. But the resulting devfile.yaml doesn't have any endpoints in it.
$ odo create --s2i --port 8080 nodejs
Validation
 ✓  Validating component [4ms]
Conversion
 ✓  Successfully generated devfile.yaml and env.yaml for provided S2I component

Please use `odo push` command to create the component with source deployed

Should we track this in a separate issue or should this be fixed via this PR?

IMO, we should update docs on odo.dev as a part of this PR. It's fundamentally changing the behaviour of odo create --s2i. Maybe that would mean renaming the Migrating S2I (Source-to-Image) components to Devfile components to "Creating components using s2i images" and changing the content accordingly.
@kadel wdyt?

IMO, we should update docs on odo.dev as a part of this PR. It's fundamentally changing the behaviour of odo create --s2i. Maybe that would mean renaming the Migrating S2I (Source-to-Image) components to Devfile components to "Creating components using s2i images" and changing the content accordingly.
@kadel wdyt?

Yeah I haven't thought of how much of the doc should change

Failure on kuberenetes:
[ssh:Fedora 32] Command Error failed to wait for command completion failed to wait ssh command: <nil>, failing gracefully
INFO[2021-04-15T08:51:05Z] [ssh:Fedora 32] !!!run failed, skipping!!!
INFO[2021-04-15T08:51:05Z]
INFO[2021-04-15T08:51:05Z] 2021/04/15 08:50:56 : failed due to err Failed the test, see logs above ^
INFO[2021-04-15T08:51:05Z] {"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"prow/entrypoint/run.go:80","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2021-04-15T08:50:56Z"}
INFO[2021-04-15T08:51:05Z] error: failed to execute wrapped command: exit status 1

Its openstack issue. Sometimes VM creation takes more than 1 min and we are trying to iterate on vm ssh for 1 min. To fix this failure options are:

We iterate for more than 1 min but yes there should be a limit set.
We increase the default retryloop in ci-firewall.
I am looking for suggestions to set the limit. cc @mohammedzee1000 @kadel

/test psi-kubernetes-integration-e2e

Things that could break for vs code adapter
All the below points only apply on s2i components. which would work as devfiles after this PR is merged.

[ ] odo url create after odo create --s2i would fail, you shouldn't do that as odo would create url directly without asking https://github.com/openshift/odo/issues/4621
[ ] wildfly and dotnet s2i components will not anymore https://github.com/openshift/odo/issues/4623
[ ] now flag for odo env wont work https://github.com/openshift/odo/issues/4594
[ ] odo delete --wait wouldn't work https://github.com/openshift/odo/issues/4593
[ ] oc based checks that checks for image streams and deployment configs would fail - https://github.com/redhat-developer/vscode-openshift-tools/blob/3cd96beac9c6a27360947c49b34d7e33d022e3fe/test/unit/oc.test.ts#L87
[ ] json output of odo list, describe and create would be different from before as s2i component creation would yield into a devfile component now.
[ ] odo env set DebugPort wont work as there is no "debug" specific commands for s2i converted devfiles. But I have added a work around so basic debugging would work. and you can change the port via odo config set --env DEBUG_PORT

🥳 Finally all tests are passing

Some questions asked by adapters team and their replies

Why odo create URL would fail as it is allowed for devfile ?

it won’t fail in the sense that if you tried the conventional s2i approach and try to create odo url create it would fail with url for 8080 port already present  as there would already be one for you. issue - https://github.com/openshift/odo/issues/4621

is odo env --now and odo delete --wait permanent or temporary as we already have the issue for “normal” devfile components

Each and every change listed if they have an issue at the end of it will be fixed as a follow up  e.g. https://github.com/openshift/odo/issues/4594 for odo env and https://github.com/openshift/odo/issues/4593 for odo delete

Not sure to understand the status of the debug

odo env set DebugPort wont work, instead you would need to use odo config set --env DEBUG_PORT  - this is because the s2i to devfile converted devfiles dont have a debug type command defined in them. We would fix this too.

So every component will now be reported as devfile component but what about existing S2I components

They should work as is mostly because I tried them and they work, maybe try odo list because that one is quite complex to work across the board.

If oc based checks are not going to work, is there an alternative odo support around it ?

I wouldn't say you cannot use oc based checks but they would break because now s2i components being converted to devfile would generate a deployment but the oc would try to find a DeploymentConfig.

wildfly and dotnet s2i components will not work anymore - This one is specific to the next release, can be fixed in the upcoming releases ?

I think dotnet was mostly fixed but yeah the goal is to get both working asap and its the most important one right now.

Main question how we are going to deal with existing components pushed or not pushed after extension update installed with new odo version. If we cannot distinguish components using odo list how are we going to detect them? If odo cannot work with them transparently (so user would not see any problems), then we have a problem and need a way out of it.

My understanding is that newly created components will be reported as devfile whereas older ones will still be S2I

My understanding is that newly created components will be reported as devfile whereas older ones will still be S2I

Yes that is correct, all the s2i code is still there so existing s2i components would work as is.

Main question how we are going to deal with existing components pushed or not pushed after extension update installed with new odo version. If we cannot distinguish components using odo list how are we going to detect them? If odo cannot work with them transparently (so user would not see any problems), then we have a problem and need a way out of it.

odo list and odo list -o json show existing "Pushed" components under s2i components.
A component that's not pushed, shows up as "Pushed" (this is incorrect behaviour).

However, in both cases, an existing component created with odo create --s2i shows up as s2i component.

So does that mean that newly S2I components will be reported as devfile only after they have been pushed ? That's a major change as our tooling does not handle type change after it has been discovered

So does that mean that newly S2I components will be reported as devfile only after they have been pushed ?

Yes.

That's a major change as our tooling does not handle type change after it has been discovered.

We're pushing this change for 2.1.1 release. 2.1 release is already on the way without this change.
How can we help make this less painful? Showing components created with odo create --s2i under "S2I Component" in odo list and odo list -o json outputs would mean to track this somewhere other than devfile.yaml. It might be doable, but I'm not sure if that's the direction we want to take. From VS Code tooling point of view, do we differentiate between s2i & devfile components? I'm asking this because in odo we're trying to move towards having only devfile components.

My understanding is that newly created components will be reported as devfile whereas older ones will still be S2I

Yes that is correct, all the s2i code is still there so existing s2i components would work as is.

Given a scenario, a user migrates to new version of extension support this latest odo, and the components are migrated as s2i component. Now if the user does undeploy and again pushes that component, the component changes to s2i or devfile ?
If it changes to devfile (as per the new workflow being suggested in the PR), then the scenario of s2i and devfile components is going to be confusing.

How can we help make this less painful? Showing components created with odo create --s2i under "S2I Component" in odo list and odo list -o json outputs would mean to track this somewhere other than devfile.yaml. It might be doable, but I'm not sure if that's the direction we want to take. From VS Code tooling point of view, do we differentiate between s2i & devfile components? I'm asking this because in odo we're trying to move towards having only devfile components.

For many developers, they want have the support both for s2i and devfile components using the extension. Is there any specific discussion or reason why odo want to support only devfile components ?

For many developers, they want have the support both for s2i and devfile components using the extension.

The support isn't going away. odo is only converting those components to devfile components.

Is there any specific discussion or reason why odo want to support only devfile components ?

#4281

A component that's not pushed, shows up as "Pushed" (this is incorrect behaviour).

We can record this in an issue because changes in this PR shouldn’t have affected this behaviour

From VS Code tooling point of view, do we differentiate between s2i & devfile components?

VSCode Ext detects S2I based on spec.sourceType attribute in 'odo list -o json' output.

My suggestion would be to please use this branch ( should be merged to master soon too ) with vs code openshift plugin and if you can find some pain points, I can fix them before the release is around? Can we condsider trying this branch @dgolovin ?

Blocked on https://github.com/openshift/odo/pull/4637,
Test failing on unavailability of kubectl binary
odo push command tests
INFO[2021-04-17T20:24:45Z] /go/src/github.com/openshift/odo/tests/integration/cmd_push_test.go:15
INFO[2021-04-17T20:24:45Z]   when push command is executed
INFO[2021-04-17T20:24:45Z]   /go/src/github.com/openshift/odo/tests/integration/cmd_push_test.go:76
INFO[2021-04-17T20:24:45Z]     should push only the modified files [It]
INFO[2021-04-17T20:24:45Z]     /go/src/github.com/openshift/odo/tests/integration/cmd_push_test.go:156
INFO[2021-04-17T20:24:45Z]
INFO[2021-04-17T20:24:45Z]     Unexpected error:
INFO[2021-04-17T20:24:45Z]         <*exec.Error | 0xc0009dee00>: {
INFO[2021-04-17T20:24:45Z]             Name: "kubectl",
INFO[2021-04-17T20:24:45Z]             Err: {
INFO[2021-04-17T20:24:45Z]                 s: "executable file not found in $PATH",
INFO[2021-04-17T20:24:45Z]             },
INFO[2021-04-17T20:24:45Z]         }
INFO[2021-04-17T20:24:45Z]         exec: "kubectl": executable file not found in $PATH
INFO[2021-04-17T20:24:45Z]     occurred
INFO[2021-04-17T20:24:45Z]

@anandrkskd @rnapoles-rh PTAL

/hold
remove hold once 2.1 release is out.

/hold cancel


May I ask how to do PPO training?

Is there some advises?

Thanks for your interest in our work. I have updated the readme file.


Update Angle to <IP_ADDRESS>3020321

What does the pull request do?
See https://www.nuget.org/packages/Avalonia.Angle.Windows.Natives/<IP_ADDRESS>3020321

Fixes win7-x64/x86 limitation, angle is now copied with the app for win-x64/x86 build as well
Includes angle custom license (inherited from google/angle repository) with the package.
Outside of this PR, but also deprecated technically previously latest angle package, which was never used and never properly worked.

Fixed issues
Fixes https://github.com/AvaloniaUI/Avalonia/issues/9359
Fixes https://github.com/AvaloniaUI/Avalonia/issues/4995
Fixes https://github.com/AvaloniaUI/Avalonia/issues/9531
Fixes https://github.com/AvaloniaUI/Avalonia/issues/6028
Fixes https://github.com/AvaloniaUI/Avalonia/issues/8834
Fixes https://github.com/AvaloniaUI/Avalonia/issues/8888
Fixes https://github.com/AvaloniaUI/Avalonia/issues/9519

You can test this PR using the following package version. 11.0.999-cibuild0029564-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]


Hyperlinks doesn't work on material design buttons

Bug, feature request, or proposal:
Hyperlinks doesn't work on material design buttons
What is the expected behavior?
Redirect or start downloading from specified url
What is the current behavior?
When yo click on a md button with an hyperling, is happening noting.
What are the steps to reproduce?
Providing a Plunker (or similar) is the best way to get the team to see your issue.
Plunker template: https://goo.gl/DlHd6U
<!button class="main-button" md-button >Download
Download
What is the use-case or motivation for changing an existing behavior?
It more like a bug than like
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Material 2, Angular 2
Is there anything else we should know?

Please use the template or fix the code to see or reproduce the issue.

Closing this issue as it does not follow the issue template. Please file a new issue that follows the template (including steps for reproduction), which gives the team the information needed to investigate.


Fix exec node error tests on Windows

Hi @dceejay,
I fixed several error tests which occurred only on Windows environment.
I also noticed that there are two results that the payload length becomes 6 or 8 on the following test case.
"exec node calling spawn should spawn a simple command and return binary buffer"
I'm not sure the exact condition but in my environment, the payload length is 6 on Windows 7, and the one is 8 on Windows 10.
So I fixed to accept both of them.

Coverage increased (+0.07%) to 87.131% when pulling 2912f35b7306645f7c692d35e39c18a03a454111 on Kazuki-Nakanishi:0.17 into 11ee1a7dcb7c537ad6b8fe62e5654da6111de0aa on node-red:0.17.

Coverage increased (+0.07%) to 87.131% when pulling 2912f35b7306645f7c692d35e39c18a03a454111 on Kazuki-Nakanishi:0.17 into 11ee1a7dcb7c537ad6b8fe62e5654da6111de0aa on node-red:0.17.


2.3.0.Alpha1 announcement

Thanks @jpechane, this got lost in the shuffle yesterday, appreciate merging.


Question about 1203: security.ssl.disable_session_identifiers

What does mean, if I set security.ssl.disable_session_identifiers to false?
I do not use FPI, but I am using TC in Auto mode.
Just for info: I have cases where I need to use USB Token with client certificate, but it doesn't work when 1203 is set to true.
Thank you a lot
Cheers

I suggest to set security.ssl.disable_session_identifiers to false if you

use auto TC and/or FPI
privacy.clearOnShutdown.cache (IIRC)
network.cookie.cookieBehavior 0 or 4

because

better performance (no continuous renegotiation of the ssl session)
no real privacy improvement since you are already identifiable
restart / cpd / new container reset this

I though so too, but better to ask than be sorry. 😄
Thank you @rusty-snake  for clarification.


ReferenceArrayList::elements returns K[]

Attempting to assign the array turned by ReferenceArrayList::elements to K[]—or anything else other than Object[]—causes a ClassCastException because Object[] cannot be cast to anything except Object[], so either elements should return Object[] instead or the element array should actually be a K[].

Please read the class documentation.

I understand now. Thank you.


[Developer Experience]: Add Cypress test for 'About Page Content' Component

Developer Experience Issue
Please describe your Developer Experience Issue.
A clear and concise description of what the problem is. Ex. I have an issue when [...]
Add Cypress test for 'About Page Content' Component
Describe the solution you'd like
A clear and concise description of what you want to happen. Add any considered drawbacks.
A Cypress test should be written to:

Test if the About Page content renders properly

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Teachability, Documentation, Adoption, Migration Strategy
If you can, explain how users will be able to use this and possibly write out a version in the docs.
Maybe a screenshot or design?

@chadstewart can I please be assigned to this issue?

@chadstewart can I please be assigned to this issue?

Sure, no problem. Go ahead.

Hello @chadstewart
Can this be assigned to me?
I already worked on this
https://github.com/TechIsHiring/techishiring-website/pull/171

hi! sorry it took me so long. I will assign you @Lizzy223


First Time Install Problem - Failed to fetch from /www.mirrorservices.org - Service Unavailable

I'm doing a first time install (Rpi HQ Camera) with ./install.sh (from within the allsky directory)
Multiple "Failed to fetch from /www.mirrorservices.org/.......... - Service Unavailable
Install terminates with "Installing dependencies failed!
Is this short-term and can be resolved by trying again later, or longer-term?
221204 1233 Response to install.sh cmd.docx

@EdwardonGitHub   I was just able to "ping" the server it couldn't contact, so I suggest trying again.  We don't have any control over which server the Linux update gets its files from.
Let me know if it works the second time.

Eric,
I have tried again the result being the same failure reports.
I can ping <IP_ADDRESS> with an immediate successful response.
I’ll keep trying, it seems it will resolve given time.
Thanks Edward
From: EricClaeys @.>
Sent: 04 December 2022 17:14
To: thomasjacquin/allsky @.>
Cc: EdwardonGitHub @.>; Mention @.>
Subject: Re: [thomasjacquin/allsky] First Time Install Problem - Failed to fetch from /www.mirrorservices.org - Service Unavailable (Issue #1969)
@EdwardonGitHub https://github.com/EdwardonGitHub  I was just able to "ping" the server it couldn't contact, so I suggest trying again. We don't have any control over which server the Linux update gets its files from.
Let me know if it works the second time.
—
Reply to this email directly, view it on GitHub https://github.com/thomasjacquin/allsky/issues/1969#issuecomment-1336470217 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ATHG5G2QUNLVSC7L3I5D2BLWLTGL7ANCNFSM6AAAAAASTKUWA4 .
You are receiving this because you were mentioned.  https://github.com/notifications/beacon/ATHG5G7K4RNWNQV3FETG2XLWLTGL7A5CNFSM6AAAAAASTKUWA6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSPVDVMS.gif Message ID: @.*** @.***> >

Okay, now resolved and the installation completed.
The issue can be closed.
Thanks for your attention. Edward
From: @.*** @.>
Sent: 04 December 2022 18:47
To: @.' @.>
Cc: 'Mention' @.>; 'thomasjacquin/allsky' @.>; 'thomasjacquin/allsky' @.>
Subject: RE: [thomasjacquin/allsky] First Time Install Problem - Failed to fetch from /www.mirrorservices.org - Service Unavailable (Issue #1969)
Eric,
I have tried again the result being the same failure reports.
I can ping <IP_ADDRESS> with an immediate successful response.
I’ll keep trying, it seems it will resolve given time.
Thanks Edward
From: EricClaeys @.*** @.> >
Sent: 04 December 2022 17:14
To: thomasjacquin/allsky @. @.> >
Cc: EdwardonGitHub @. @.> >; Mention @. @.***> >
Subject: Re: [thomasjacquin/allsky] First Time Install Problem - Failed to fetch from /www.mirrorservices.org - Service Unavailable (Issue #1969)
@EdwardonGitHub https://github.com/EdwardonGitHub  I was just able to "ping" the server it couldn't contact, so I suggest trying again. We don't have any control over which server the Linux update gets its files from.
Let me know if it works the second time.
—
Reply to this email directly, view it on GitHub https://github.com/thomasjacquin/allsky/issues/1969#issuecomment-1336470217 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ATHG5G2QUNLVSC7L3I5D2BLWLTGL7ANCNFSM6AAAAAASTKUWA4 .
You are receiving this because you were mentioned.  https://github.com/notifications/beacon/ATHG5G7K4RNWNQV3FETG2XLWLTGL7A5CNFSM6AAAAAASTKUWA6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSPVDVMS.gif Message ID: @.*** @.***> >


Database Appender

I have created a simple database appender to write log files to a database.
Because we are currently using dbGo (ADO) coomponents to connect to a MS SQL Server I did the initial work using that connection stack.
As we are planning on migrating to FireDAC, I have refactored into a base class and created two child classes - one for ADO and one for FireDAC.
Due to security considerations I have used stored procedures.
One thing I am looking at it the retry mechanism, as occasionally a DB call may not succeed so a retry is often warranted. I see the TryToRestart virtual method but this just seems the reset the logging thread while discarding the actual logItem. Is there some guidance around retries (I could imagine this would happen with REST providers too) so I can refactor this before sharing the code.

Thank you for your contribution, David. I added the FireDACDBAppender with an example for postgresql. There is a ddl script to create all the needed db objects to run the sample.
Regarding the logitem discard, I added a fallback logger to not loose nothing. However, we could just mantain the log in the queue, but this is a false solution because the queue will eventually gets full.
Please, let me know if the changes work for you.

Thanks for adding the FireDAC examples and enhancing the fallback logging - I found your code educational :)
I'm happy to close this ticket.


Evoked plot ordinates only contain UNIT, but no actual LABEL

See the abscissa for comparison, which has label and unit:

Probably needs to be fixed upstream in MNE, but just leaving this here because I just stumbled upon this while browsing our build artifacts…

what would you suggest?

Field strength (fT) for magnetometers, and d/dL Field strength (fT/cm) for gradiometers. But I can already see how awkward this would be :(

Maybe just Signal (fT) and Signal (fT/cm)?

i find this not more informative. But I am obviously very biased...

It just bites me very much as I had an engineering education and just writing the unit would be a no-go.. and this inconsistency between ordinate and abscissa is not very pleasant from aesthetic point of view ;)
--
Sent from my phone, please excuse brevity and erroneous auto-correct.

On 6. Jul 2020, at 17:40, Alexandre Gramfort<EMAIL_ADDRESS>wrote:

i find this not more informative. But I am obviously very biased...

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


fix(Tactic.PushNeg): push_neg makes loose bounded variables

example (a : α) (o : Option α) (h : ¬∀ hs, o.get hs ≠ a) : ∃ hs, o.get hs = a := by
  push_neg at h
  exact h

In this example, h become o.isSome = true ∧ o.get #0 = a (#0 is a loose bounded variable).
This PR fixes this bug.

bors merge


Add hypercore-replicate debugging

@mafintosh more debug()s for the debug god. Make sure it looks correct and gets everything we need

bump

4.17.0


Is CGImageWithCorrectOrientation really necessary?

Hey! I just noticed that each operation in Toucan starts off with a call to CGImageWithCorrectOrientation function which involves creating a new context and drawing an image into it. So, for example, if I want to crop an image with UIImageOrientation.Left then instead of simply cropping the image (which is extremely fast) Toucan would first physically rotate its bitmap (which is much more expensive then cropping itself) and just then crop the image. It would also change the image orientation to UIImageOrientation.Up.
I understand that it might be tempting to just "fix" an orientation so that all the other functions would only have to deal with images in UIImageOrientation.Up. However, if would be nice if Toucan could add a proper support for images in all orientations.

Indeed it is more a ground-work-ensure-all-the-things. Ideally Toucan wouldn't actually perform the operations when called, but have a more optimistic-builder-style syntax, and only perform the operations when retrieving the image property, so at that point we could optimize the callstack and remove the redundant calls.... happy for PR or hopefully I'll get there :)

@gavinbunney Is this still an issue, I have used Toucan for so long and would love to contribute and make this a reality.