Handling Truncated Records?

We've just noticed a few timeTrunc errors in our crawl logs and the resulting WARC-Truncated: time headers in our WARC records. Does OpenWayback handle these specifically?
At the moment it just seems to silently fail to render anything. I'm not sure, however, what it should be doing. For instance:
WARC/1.0
WARC-Type: response
WARC-Target-URI: http://www.---.com/images/---.jpg
WARC-Date: 2015-04-13T18:59:40Z
WARC-Payload-Digest: sha1:7VXVD5DY2ORDVSV3L46PFR2LS2BDU4ZN
WARC-IP-Address: ---.---.---.---
WARC-Truncated: time
WARC-Record-ID: <urn:uuid:cae241d0-6839-4bb1-a0c2-9ab65799b557>
Content-Type: application/http; msgtype=response
Content-Length: 1368

HTTP/1.1 200 OK
Date: Mon, 13 Apr 2015 18:59:41 GMT
Server: Apache
Last-Modified: Mon, 16 Apr 2012 09:16:55 GMT
ETag: "3d47296-dd8f-4bdc848972690"
Accept-Ranges: bytes
Content-Length: 56719
Connection: close
Content-Type: image/jpeg

ÿØÿà^<EMAIL_ADDRESS>
Here we've a partial JPEG—should OpenWayback return the partial? Or treat it like a revisit and try to find the nearest record (although the hash would be wrong...)?

I vote for returning the partial. Could be useful in the case of audio streams for example. We happened to run into such a capture today, where we got a 2 hour snapshot of http://mozart.wkar.msu.edu/wkar-fm-mp3

Wouldn't it make more sense to display an interstitial page explaining the issue and offering a link to the partial content? If we just present the partial content without any context, users are likely to conclude that there is an issue with the archive service.

This is another one of those times I'd prefer a iframe approach, as the fact that this is known to be damaged from capture could be relayed around the edge.
If that's too difficult, I'd rather we provided an interstitial, but either way, I think we should be able to return the item as-is rather than hide it.

Sure, interstitial is a good idea, although my guess is that truncated urls are usually not gonna be html pages viewed at the top level. The examples mentioned here are a jpeg and an audio stream, so the interstitial wouldn't come into play in these cases (right?)

No, at least not when viewing them as embedded resources. Only when they are accessed directly.


BUG: Line wrapping with Align.center is wrong for TextraLabel

This is how it looks like:

This is how it is supposed to look like (In this image TypingLabel is used, seems like the issue does not exist for it):

This is an interesting one... The wrap width also seems smaller for that TypingLabel. This is using the latest release, 0.7.1 ? I'll try to verify over here and track down what might be causing this.

There's now a test that tries to replicate this, though I don't know all of the code involved with the buggy original screenshot. The test looks like this with TextraLabel, and the same with TypingLabel:  It's quite likely that there's some corner-case bug somewhere in the library, because that type of bug seems to pop up like a weed... Maybe you encountered the bug in a scene2d.ui Cell that contained a TextraLabel, rather than a TextraLabel on its own like in Issue6Test?

This might be fixed by the latest commit:

You can try it yourself using a JitPack dependency; I'd really like to know if this fixes the bug in your case. https://jitpack.io/#tommyettinger/textratypist/7168f0590c
A potential issue here is that TypingLabel seems to wrap more frequently (with less space permitted for the words) than TextraLabel. I'm not sure what's happening other than a possible difference between the two methods that can do word wrapping.

Thanks, I'll try it and tell you if it fixes the issue.
About wrapping more frequently - it is probably due to the fact that the width of my TypingLabel is just smaller than yours, so it is no surprise.

Seems to be working, closing the issue


feat(root): "I confirm I have" section to issue template

You can test this one out by just going into here

Closing this one @gabrielmfern, let's not add it


pull request for e2e test at 12/05/2016 01:15:02

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Integration configuration error

Hello, I have an issue since few days about the govee integration configuration. In a first time the integration stopped working and I couldn't reload it. Then I tried to uninstall it and reinstall but at the point to insert the api I got an error like the api was incorrect. Of course the api number was correct. I requested a new one from govee app and tried it but the issue was still there. How can I fix it? Any ideas? Thanks

I am having the same issue here.

I am getting this as well. For me it seems to be that the underlying API library (govee_api_laggat) is not installed weirdly.
2024-12-07 21:48:28 GMT−8 | info | File "/config/custom_components/govee/__init__.py", line 5, in <module>
2024-12-07 21:48:28 GMT−8 | info | from govee_api_laggat import Govee
2024-12-07 21:48:28 GMT−8 | info | ModuleNotFoundError: No module named 'govee_api_laggat'

If I go into the shell of the HA container and it is indeed not installed when trying to import it when going into python. But after a pip install govee_api_laggat python now sees it, and when I go to the HA UI I can add a new entry, but I haven't figured out how to fix existing entries for the integration. Also when I reboot the container, the install is lost and we are back to square one.

Same issue

Same issue...

Did anyone come up with a solution?

I changed my Poll Interval to "60" and that fixed it for me.  Maybe I was bumping against the API Limits not sure.

I moved to this addon and recommend it to you too. It works for me.
https://github.com/wez/govee2mqtt


Outline Proxy Routing Controller dows not start on CentOS 8

Describe the bug
Does not work on CentOS 8 Stream
To Reproduce

I changed this section. Previously there was a screenshot of GUI with an error message.

$ docker run -itv ~/outline-client/tools/outline_proxy_controller/dist:/w centos /w/OutlineProxyController
/w/OutlineProxyController: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.26' not found (required by /w/OutlineProxyController)

Expected behavior
  -h [ --help ]                print this message
  -d [ --daemonize ]           run in daemon mode
  -s [ --socket-filename ] arg unix socket filename where controller listen on
                               for commands
  -l [ --log-filename ] arg    the filename to store the loggers output

Exception: missing socket-filename argument is mandatory

Client System (please complete the following information):

Outline Client Version: AppImage 1.4.0
Your Operating System:

Submit Feedback
I noticed that the client uses sudo to put some files into /tmp
I found an outline_proxy_controller.service service and tried to do service outline_proxy_controller status, which revealed the following:
$ service outline_proxy_controller status
Redirecting to /bin/systemctl status outline_proxy_controller.service
● outline_proxy_controller.service - Outline Proxy Routing Controller
   Loaded: loaded (/etc/systemd/system/outline_proxy_controller.service; enabled; vendor preset: disabled)
   Active: failed (Result: exit-code) since Thu 2021-05-06 23:25:24 MSK; 15min ago
  Process: 8079 ExecStart=/usr/local/sbin/OutlineProxyController --socket-filename=/var/run/outline_controller (code=exited, status=1/FAILURE)
 Main PID: 8079 (code=exited, status=1/FAILURE)

мая 06 23:25:24 centos-lenovo systemd[1]: Started Outline Proxy Routing Controller.
мая 06 23:25:24 centos-lenovo OutlineProxyController[8079]: /usr/local/sbin/OutlineProxyController: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.26' not found (required by /usr/local/sbin/OutlineProxyController)
мая 06 23:25:24 centos-lenovo systemd[1]: outline_proxy_controller.service: Main process exited, code=exited, status=1/FAILURE
мая 06 23:25:24 centos-lenovo systemd[1]: outline_proxy_controller.service: Failed with result 'exit-code'.

I'm going to try compiling an OutlineProxyController to replace your /usr/local/sbin/OutlineProxyController binary, but anyway the problem exists.

Here's the binary I got after compiling on my host system. Anyway, looks like the app copies its own binary every time, and I can't use my compiled one...
OutlineProxyController.zip
P.S.: Please check every strange binary for viruses before running, and never execute them on your main host system.

@fortuna any updates on this?


Destination folder not working

First, thank you for the amazing program.
I run a fan web page for a PC game I play and would like to automate the ripping of the game images.  After reading about this it seems I should be able to run "uTinyRipper.exe sourceFolder destinationFolder" but this doesn't work (and no other combination that I can think of it either).  Do you have a document on the CLI syntax you can share with me.
Also, is there a way to filter for just Texture2D or just TextAsset?
Thanks again.

No, ripper doesn't support any command line arguments (it accept source file paths only). Same for filter.
The only way is to modify source code and rebuild the project.
Filter function:
https://github.com/mafaca/UtinyRipper/blob/281ddc86f0b28e1ae532c59d758a53a015efa88b/uTinyRipperGUI/MainWindow.xaml.cs#L28-L31
replace to
return asset.ClassID == ClassIDType.Texture2D || asset.ClassID == ClassIDType.TextAsset;
Destination path:
https://github.com/mafaca/UtinyRipper/blob/281ddc86f0b28e1ae532c59d758a53a015efa88b/uTinyRipperGUI/MainWindow.xaml.cs#L288
replace m_exportPath to actual path

You may also try @spacehamster 's UtinyRipperExporter . It seems that it is support command line arguments you want

Thank you very much for the quick reply and all the information.
Again, great program!!!


feat: create lambda wallet/getTxById

Acceptance Criteria

create lambda wallet/getTxById

Security Checklist

[ ] Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

Can you link the design on this PR? Took me a while to find it as it is on the internal-issues project:
https://github.com/HathorNetwork/internal-issues/issues/124


freeze versions ahead of release

Part of the release process, freezing the runners to their current versions according to this:
https://github.com/actions/runner-images

I'm not too sure why but the CI failed with weird errors.

I saw that too. I'm not sure what is going on, I tried restarting the jobs and they failed again. Maybe he values i got from the table weren't right?  Or I had a typo?  I'll look later.

Codecov Report

Merging #1403 (0ce493a) into main (cbef407) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1403   +/-   ##
=======================================
  Coverage   85.99%   85.99%
=======================================
  Files         200      200
  Lines       20934    20934
  Branches     2459     2459
=======================================
  Hits        18002    18002
  Misses       2331     2331
  Partials      601      601

Flag
Coverage Δ

py-unittests
85.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbef407...0ce493a. Read the comment docs.

I'm not too sure why but the CI failed with weird errors.

Got it working. I'm going to merge other release changes into this pr- setting the version # and so on

@meshula I forget, are the VFX platform versions listed in the README.md accurate for this release?
vfx platform 2018-2021

@ssteinbach  vfx platform should be current year + 3, so 2022, 2021, 2020, and 2019.


gcr.io/kpt-functions/set-namespace deletes comments in file

Start with file:
# This object and its stored inventory is subsequently
# used to calculate the set of objects to automatically
# delete (prune), when an object is omitted from further
# applies. When applied, this "inventory object" is also
# used to identify the entire set of objects to delete.
#
# NOTE: The name of this inventory template file
# does NOT have any impact on group-related functionality
# such as deletion or pruning.
#
apiVersion: v1 # NOTE: auto-generated. Some fields should NOT be modified.
kind: ConfigMap
metadata:
  # DANGER: Do not change the inventory object namespace.
  # Changing the namespace will cause a loss of continuity
  # with previously applied grouped objects. Set deletion
  # and pruning functionality will be impaired.
  namespace: metallb-system
  # NOTE: The name of the inventory object does NOT have
  # any impact on group-related functionality such as
  # deletion or pruning.
  name: inventory-82029660
  labels:
    # DANGER: Do not change the value of this label.
    # Changing this value will cause a loss of continuity
    # with previously applied grouped objects. Set deletion
    # and pruning functionality will be impaired.
    cli-utils.sigs.k8s.io/inventory-id: e947bb0e-56f3-450c-96ed-8c5ecff10017

Run:
kpt fn run --image gcr.io/kpt-functions/set-namespace .
Results:
diff --git a/inventory-template.yaml b/inventory-template.yaml
index f40ca14..398c152 100644
--- a/inventory-template.yaml
+++ b/inventory-template.yaml
@@ -1,5 +1,3 @@
-# This object and its stored inventory is subsequently
-# used to calculate the set of objects to automatically
 # delete (prune), when an object is omitted from further
 # applies. When applied, this "inventory object" is also
 # used to identify the entire set of objects to delete.

Run again:
diff --git a/inventory-template.yaml b/inventory-template.yaml
index f40ca14..28e9ded 100644
--- a/inventory-template.yaml
+++ b/inventory-template.yaml
@@ -1,7 +1,3 @@
-# This object and its stored inventory is subsequently
-# used to calculate the set of objects to automatically
-# delete (prune), when an object is omitted from further
-# applies. When applied, this "inventory object" is also
 # used to identify the entire set of objects to delete.
 #
 # NOTE: The name of this inventory template file

kpt version is 0.39.2`.
I am not sure if this is a bug with set-namespaces or kpt in general.

@mengqiy can you please take a look?

Looks like function gcr.io/kpt-functions/set-namespace is old set-namespace function.

I am not 100% sure but with some brief testing it seems like it may happen with any function, or at least another function (https://github.com/mgoltzsche/khelm) has the same issue.

I think this has been fixed in https://github.com/GoogleContainerTools/kpt-functions-catalog/pull/222.
@howardjohn Can you please try to use image gcr.io/kpt-fn/set-namespace:v0.1 which is our latest image

gcr.io/kpt-fn/set-namespace:v0.1 seems to have an even more critical issue - it deletes all my files with config.kubernetes.io/local-config: "true" configs (including the file actually declaratively configuring set-namespace to run!).
It also seems a lot more destructive, completely re-ordering the YAML which has the side effect of massive diffs and some removed comments (when the comment is on the same line as yaml, like a: b # comment)

it deletes all my files with config.kubernetes.io/local-config: "true" configs (including the file actually declaratively configuring set-namespace to run!).

A work around is separate the sources and fn configs by directories. And then use kpt fn run --fn-path fn-config/ resources/.
The docs related to config.kubernetes.io/local-config:

https://github.com/kubernetes-sigs/kustomize/blob/master/cmd/config/docs/api-conventions/config-io.md#configkubernetesiolocal-config
https://github.com/GoogleContainerTools/kpt/releases/tag/v0.34.0

It's not very clear to me what is the desired behavior for kpt fn and functions when dealing with config.kubernetes.io/local-config: "true". @droot @frankfarzan @Shell32-Natsu Can you someone clarify it?
If the function config object is in items of the input resourceList, gcr.io/kpt-fn/set-namespace:v0.1 currently will NOT output it in items in the output resourceList.
Current behavior is not a problem for the new kpt fn UX, but it can be a problem for existing kpt (v0.39.x) when the resources and fn configs are not separated by directories.
@frankfarzan We should standardize if functions should drop its fn config from resourceList.items. WDYT?

completely re-ordering the YAML which has the side effect of massive diffs and some removed comments (when the comment is on the same line as yaml, like a: b # comment)

This formatting issue may happen. We are working on a "format" function in https://github.com/GoogleContainerTools/kpt-functions-catalog/pull/242. We will recommend our users to always use it as the last one in the mutators.

some removed comments (when the comment is on the same line as yaml, like a: b # comment)

@howardjohn Can you please provide steps to reproduce this? e.g. example resources.

pipeline-validate example is a good repro of disappearing files:
~/kpt/package-examples/pipeline-validate » kpt fn render .

I didn't find any existing functions deleting comments in the catalog. I created some test cases to ensure that in https://github.com/GoogleContainerTools/kpt-functions-catalog/pull/324

Currently all of our mutator functions are written in golang. They works fine.
But it appears there is an issue when a mutator function is written with the TS SDK. It is tracked in https://github.com/GoogleContainerTools/kpt/issues/2069

The work about functions should not drop resources with local-config is tracked in https://github.com/GoogleContainerTools/kpt/issues/1933

kpt copies comments from input to output after running the functions. However, we found some bugs and they are being fixed in PR https://github.com/kubernetes-sigs/kustomize/pull/3965.
We will need to upgrade kpt's kyaml dependency to pick up the fix.

With #2169 merged, we can close this.


[Que] is it possible to search on tags which are added with text?

As per my understanding, embeddings are only built on text and we can do search on them; while meta tags can be used to filtering out the results.
I want to do search on text as well as meta tags (stored in data field), so can we build embeddings on tags and configure txtai to do search on meta tags as well?
My requirement is both text as well tags should be considered while searching.  Is this possible with txtai or any other way to achieve this?

As long as content storage is enabled, you can search tags as part of a SQL query.
For example:
select id, text, score from txtai where similar('text') and tags like '%tag%'

Additional metadata can also be added to records at index time.
record = {"text": "text to index", "flags": {"f1": 1, "f2": 1, "f3": 1}}

# Build embeddings and index with record
embeddings = Embeddings(...)
embeddings.index([(0, record, tags)])

select id, text, score from txtai where similar('text') and flags.f1

Another thing that trips people up is the similar candidate list when using filters. If you don't get the results you expect, try changing the candidate parameter - https://neuml.github.io/txtai/embeddings/query/#similar-clause

Thanks for the reply.
I already using SQL query for filtering out the result using tags. I wanted to use search on tags like we do search on text, so that score will also get affected. If tags/keywords mentioned in search query then, it will have higher score.

Unfortunately, only a single text similarity field is supported per index for similarity queries. This has also been discussed in #288 and it's on the roadmap to allow multiple similarity fields per index.
Couple options to consider as of now:

Make the text field text + keywords. You could have a format like "[tags] text".

Add a custom score function that takes (score, query, tags) and builds a custom score. For example:
def tscore(score, query, tags):
    return score + 0.25 if tags and query in tags else score

embeddings = Embeddings({"path": "sentence-transformers/nli-mpnet-base-v2",
                         "content": True, "functions": [tscore]})

embeddings.index([(0, "text", None), (1, "text", "tag1")])

embeddings.search("select id, text, tscore(score, 'tag1', tags) score from txtai where similar('text')")

Note that this only scores after results have already been obtained from the ANN index.

good to know it's on the roadmap to allow multiple similarity fields per index.


Fix invalid LLVM IR in join builtin

Add pointer casts to store instruction where required and use GEP
instructions to do pointer arithmetic instead of incorrect use of
add instruction.
Fixes #2222

Checklist

[x] Language changes are updated in man/adoc/bpftrace.adoc and if needed in docs/reference_guide.md
[x] User-visible and non-trivial changes updated in CHANGELOG.md
[x] The new behaviour is covered by tests

I see, didn't know that, I'll add that to the commit to test that properly :)

Unrelated tests (intptrcast.Casting ints,variable.32-bit tracepoint arg) still failing, I put them back into the disable list.

Unrelated tests (intptrcast.Casting ints,variable.32-bit tracepoint arg) still failing, I put them back into the disable list.

Could these be caused by an issue similar to this one?

It's highly probable, opt reports an invalid cast for the first one and an invalid store for the second one.

It's highly probable, opt reports an invalid cast for the first one and an invalid store for the second one.

Any chance you'd be able to fix it as a part of this PR?


[$1000] Web- Preferences - The recent mode description is truncated in Spanish preference

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to Web chrome
Change language to Spanish
Go to preferences and mode
See that the description is truncated at the end

Expected Result:
The recent description should not be truncated at the end and should be shown in two lines
Actual Result:
The recent description is truncated at the end
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/232520168-0e30024c-0b61-4151-8ecf-f22f0fe1ccfc.mp4

Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681621048024679
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01decf2433726a790f
Upwork Job ID:<PHONE_NUMBER>492830208
Last Price Increase: 2023-04-26

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Job added to Upwork: https://www.upwork.com/jobs/~01decf2433726a790f

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

Proposal
Please re-state the problem that we are trying to solve in this issue.
The recent mode description is truncated in Spanish preference
What is the root cause of that problem?
Option of priorityModes have property alternateTextMaxLines is undefined.
https://github.com/Expensify/App/blob/4019be1c2d41bb27bab90544a84dff7c502f1d3c/src/pages/settings/Preferences/PriorityModePage.js#L41
Then, style white-space: "pre" is applied. So that when text description is too long it will be truncated.
https://github.com/Expensify/App/blob/4019be1c2d41bb27bab90544a84dff7c502f1d3c/src/components/OptionRow.js#L128
What changes do you think we should make in order to solve the problem?
Change alternateTextMaxLines to 2
https://github.com/Expensify/App/blob/4019be1c2d41bb27bab90544a84dff7c502f1d3c/src/pages/settings/Preferences/PriorityModePage.js#L41
What alternative solutions did you explore? (Optional)
NA
Result
Screencast from 18-04-2023 16:53:06.webm

Triggered auto assignment to @marcochavezf (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

As @allroundexperts mentioned and this comment https://github.com/Expensify/App/pull/15130#issuecomment-1498022925, numberOfLines 0 with lineHeight style will throw an error on Android, but this only happens on our fork. It could be means that something missed when we are upgrading the react native. I think we should investigate that.

@dukenv0307 Thanks for the proposal. Your RCA seems about right. But I think the fix can be improved. We want alternateTextMaxLines to take as many lines as needed and not just limited to 2.

@bernhardoj Right, this is a regression from https://github.com/Expensify/App/pull/15130 (https://github.com/Expensify/App/commit/bdf28204faa48f783ef14b599cc29af69fc9c898). We should have kept alternateTextMaxLines set to 0 not to restrict the number of lines. Setting alternateTextMaxLines to undefined is basically the same as setting it to 1 since we use lodashGet here where we fallback to 1.
cc @priyeshshah11 @aimane-chnaif @roryabraham

@allroundexperts Oh so sorry, I didn't see the proposal it was before Help Wanted label. I used to only review proposals below that :sweat_smile: Checking now...

@allroundexperts Thanks for the proposal. I agree with you on the RCA. But I don't think setting alternateTextMaxLines to 2 will crash the App, will it? If not then that would be our backup plan.
We can't really keep running from fixing the RN bug especially since it only happens on our fork (based on @bernhardoj comment). What I'm looking for here is to be able to set alternateTextMaxLines back to 0 and fix the Android crash.

@s77rt I think if we want to improve alternateTextMaxLines we need to set value to it in OptionRow depend on this.props.option.alternateText and with of wrap content

@dukenv0307 We want to set it to 0 and fix the Android crash.

@allroundexperts I think the bug only exists on our fork and not on RN. I'm not sure if this was ever a bug upstream that was fixed or it's just a bug that was introduced in our fork.

@s77rt I tried to test this bug in main branch of my fork after sync fork. I used correctly version RN now, it will crash in Android when set alternateTextMaxLines to 0, but it's not happen when I reverted version RN to v0.71.2-alpha.0

@dukenv0307 Thanks for the confirmation. Do you have any suggestion on how we can fix the Android crash?

I think the root problem of the Android crash is this PR when apply numberOfLines and maximumNumberOfLines props on iOS and Android

Sharing my finding.
Yes, the error comes from this PR https://github.com/Expensify/react-native/pull/37, specifically this changes:
https://github.com/Expensify/react-native/pull/37/files#diff-3067d6082d9bb646602ef7588f03fc4cc294a65341042f83a4a54afcd4d01dfd
where the NUMBER_OF_LINES is changed to -1.
The crash comes from this code

TOP value is 1

and mColumns value is COLUMNS_NORMAL (5)

which makes the number
5 * -1 + 1 = -4
the same number we got from the crash
and looks like the call comes from this code

if numberOfLines is 0, we take the default value which is -1. I tried to change it and other occurrences to ViewDefaults.MAX_NUMBER_OF_LINES. It doesn't crash, but the numberOfLines doesn't work anymore 🙃.
Maybe the PR author @Szymon20000 can help us.

Sure, I forgot to update few places in the Text component and somehow In RNtester I wasn’t able to spot a problem. Will do my best to fix it quickly.

Hey!
I think this one should fix it. https://github.com/facebook/react-native/pull/35703/commits/b58d91490f0b23798e38cd29c807d04c6a7e6fc9

@Szymon20000 Thank you. Can you please post a proposal following the proposal template?

Waiting on a final proposal to move this forward.

Friendly bump @Szymon20000!

To be honest not sure if my proposal is needed here.
Someone pointed that the issue is causes by my recent pr (https://github.com/Expensify/react-native/pull/37.
I update my upstream pr in react-native repository and the fix will be available from the next expensive RN fork release.

@Szymon20000 I think the proposal is still needed for us to get an idea on what went wrong and how we are fixing the bug. I understand that you made the first changes in the first PR and fixed that recently but still we can't merge blindly. I would still have to review the PR unless it was already reviewed and merged upstream. Is it the case here?

@Szymon20000 would it be too much trouble to get the proposal in? We'd really love to keep making progress here.

Sorry @flaviadefaria @s77rt  I was super busy last few days.
Let me write it now if that's helpful

Proposal
Please re-state the problem that we are trying to solve in this issue.
App is crashing or not showing views within nested text components
What is the root cause of that problem?
I created a pr that was supposed fix numberOfLines prop on android and add support for iOS  in TextInput component. However, it turned out that Text component also supports the prop but in an inconsistent way. In the Text component numberOfLines={3} would actually mean that we want to truncate the text if it has more than 3 lines. However, if the text has 2 lines we don't increate the height to 3. So it behaved as maximumNumberOfLines. I made it consistent by renaming it on the native side as maximumNumberOfLines as some parts of the implementation is shared between TextInput and Text components. I also changed the default value for numberOfLines props as it was no longer in used in the Text component. However it turned out that even though it was no longer used in Text shadow node and textLayoutManager it was still used in some parts of the ReactTextComponent.java as a result it wasn't working properly.
What changes do you think we should make in order to solve the problem?
Just make Text Input component to use previous default value which is now set in ViewDefaults.MAXIMUM_NUMBER_OF_LINES
here is the full pr: https://github.com/facebook/react-native/pull/35703/commits/b58d91490f0b23798e38cd29c807d04c6a7e6fc9
AS we recently finally got a review from a RN contributor I think we will publish our fork without my changes and once the pr is merged in upstream repo we will publish another version with accepted solution
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@Szymon20000 Thanks for the proposal. Can you please explain why the change of numberOfLines prop on Text / TextInput was necessary. Wasn't the main goal of the PR the addition of maxNumberOfLines prop for both Android and iOS? I understand that would keep numberOfLines essentially the same as maxNumberOfLines on Text but that is the current behaviour, maybe this should have been fixed by a follow up PR instead.
Checking the linked PR https://github.com/facebook/react-native/pull/36394 mapping numberOfLines to maximumNumberOfLines does not feel right. Those are different props that do different things, why we are mapping one to another?

@roryabraham Do you think we should revert https://github.com/Expensify/react-native/pull/37? That PR should not have been included in the latest version since it's incomplete, there is a complementary PR upstream https://github.com/facebook/react-native/pull/36394 but it's not ready yet.
We are also getting some reviews on the initial upstream PR here https://github.com/facebook/react-native/pull/35703.

@s77rt It does feel right.
The goals was actually to implement numberOfLines for textInput but I also added maxNumberOfLines as android and Ios work asynchronously in comparison to web. Please read the rn docs to check that numberOfLines for TextInput and Text behaved differently. Because both components on the native side in new arch shares the same code for computing the layout I had to make it consistent. NumberOfLines on the Text component should only set a maximum Limit of lines while in Text Input ot should set the exact height in lines. Please check docs for TextInput for android. It also uses setLines on the native side that should do exactly that.

@Szymon20000 I understood that. What I'm trying to say is that I don't see why we are mapping props.
 However this was actually used somewhere else where we did not map it correctly thus causing the bug.
maxNumberOfLines: :heavy_check_mark:

TextInput

numberOfLines: :heavy_check_mark:
maxNumberOfLines: :heavy_check_mark:

Suggestion:
Text:

numberOfLines: :grey_question: I still don't understand why you had to modify this, isn't the new behaviour exactly the same as it was before? This is lacking on iOS I understand that, but why making change to Android if the final results are the same?
maxNumberOfLines: :heavy_check_mark:

TextInput

numberOfLines: :heavy_check_mark:
maxNumberOfLines: :heavy_check_mark:

Hey @s77rt !
Thanks for spending your time on it!
So the reason for renaming it is that numberOfLines and maximumNumberOfLines has different names in Fabric but the same native C++ component is reused in TextComponent and TextInputComponent. To avoid runtime checks in Js code We decided to go this way. Let me send you few links.
https://github.com/facebook/react-native/blob/714b502b0c7a5f897432dbad388c02d3b75b4689/packages/react-native/ReactCommon/react/renderer/components/text/ParagraphProps.cpp#L77 <- before my changes
https://github.com/facebook/react-native/blob/714b502b0c7a5f897432dbad388c02d3b75b4689/packages/react-native/ReactCommon/react/renderer/components/textinput/androidtextinput/react/renderer/components/androidtextinput/AndroidTextInputProps.cpp#L55 <- before my changes.
Both Text and TextComponent uses the same class for layouting on Fabric and the same structure for sending text attributes from C++ to Java. in order to avoid coping all of that I had to rename it.
You may ask why it worked before on android. Why we can't do what was there before. So in Fabric they changed behaviour of numberOfLines in textInput to the same as in Text which doesn't make sense as on React-native for web we set fixed number of lines in TextArea and want to have consistent behaviour across platforms.
So we actually have 3 goals here:

make fabric and paper consistent
make Android, iOS, consistent
As Text and TextComponent reuses a lot of native classes (Make them consistent too (use maxNumberOfLines in Text component) as that's what it's actually doing )

@Szymon20000 Thanks a lot for the follow up and quick responses!
@roryabraham Would you please hold-assign @Szymon20000

@Szymon20000 Any ETA on the linked complementary PR? Also I see some requested changes on the initial PR, would you please resolve those as well

@roryabraham ^

@roryabraham @marcochavezf what are your thoughts on this one?

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Thanks @aimane-chnaif and @s77rt for pointing out the related PRs. Let's put this issue on hold in favor of https://github.com/facebook/react-native/pull/35703 and https://github.com/facebook/react-native/pull/36394. After those PRs are merged, we can re-evaluate the situation to determine if the problem still persists or has been resolved.

If we are not going with the patch here https://github.com/Expensify/App/issues/17509#issuecomment-1525753477, I would say we revert the PR https://github.com/Expensify/react-native/pull/37 to allow numberOfLines 0 and solve these issues https://github.com/Expensify/App/issues/17441 https://github.com/Expensify/App/issues/17368 https://github.com/Expensify/App/issues/17433 which I think is really bad if we keep those issues unsolved for an indefinite amount of time.

Thanks @aimane-chnaif and @s77rt for pointing out the related PRs. Let's put this issue on hold in favor of facebook/react-native#35703 and facebook/react-native#36394. After those PRs are merged, we can re-evaluate the situation to determine if the problem still persists or has been resolved.

How does this affect #17441? Has anyone verified?

Not overdue.
@marcochavezf Shouldn't this be on hold already :sweat_smile:? Or are we planning to revert https://github.com/Expensify/react-native/pull/37?

Oops I forgot to apply the hold label here

Still on hold

I'll switch this to weekly while it's on hold. If anyone removes it from hold, please also switch the priority to daily.

Same ^

On hold

On hold

Still on hold

Still on hold

Still on hold

@marcochavezf @flaviadefaria This seems fixed already. I think we can close this? or pay the bug reporter and close

Do you know by chance if this issue was reported in another GH issue?

Can we close this?

Will I get paid for this?

This is fixed in #18507

@flaviadefaria I see that the other issue was created after my issue. So I guess, I should be the initial reporter for this issue. Thanks.


Update/clean up email

The email users are sent can use some clean up. Would be good to add email confirmation

moved to 1.1.3 because it needs a new backend confirmation function


Updated Test Cases Sheet

added 2 missing testcases
arranged test cases in order of tests/ folder

fixes #19

@kritikash18 Thanks for your contribution. Your PR has been accepted for the Hacktoberfest. Please fill this form to get the awesome LoginRadius swags. :)


Add -t to include test dependencies

Fixes #8.

You based your changes off an old version for some reason, but it was an easy enough merge ;)

Whoops, sorry about that. Thanks!


test_phantom_grad: support ops which return non-differentiable outputs

Fixes: https://github.com/Lightning-AI/lightning-thunder/issues/119

Windows failure looks related to : https://github.com/Lightning-AI/lightning-thunder/issues/296


Is the trained-model saved somewhere, in drive or cloud?? Its taking too long to train

I wanna run the model on the data that I have, but the training is taking too long(even after using Google Colab GPU). Can you please share the trained model....

I guess you can finish the training within one day. I am so sorry that I do not have the pretrained model. You can train the model on your own dataset.

Alright


Does this player advance to the next item while in the background

Just wondering if this player advances to the next playlist item while playing in background mode?

@hounsellal It does advance to the next playlist/item; however, backgrounding is not yet supported by Expo. :(


Add chocolatey option to download client

Feature Request
I use chocolatey to download package on Windows, not Scoop.
It would be great if this option is available to download Godot

I don't think this is something we should get involved with. The same way we don't get involved in providing packages for every package manager across Linux distributions.
The most we can do is put a reference in the website if someone is maintaining the package.

I understand, thx you.

https://github.com/NuGetPackageExplorer/NuGetPackageExplorer
a number of chocolatey packages use zip.
exile game... I think is one.
can rework,  for godot. publish to chocolatey.org and done. , exe to msi.. can record install to msi.
can do msi install via chocolatey even easier.
start10 I basically reworked from start8.
stepson is game dev student.
chocolatey+boxstarter + (chef /ansible/pupet/salt) ntlite.. base windows10 iso..  can easily deploy w10.. rest will automatically dl. and install via pxe boot over lan.  not having to rot all day on a Saturday fixing his laptop due to (ransomware/virus/drive failure or other issues)  priceless...
add zfs Service to lan with resillosync can keep profile in sync.  and stream restoration.


Upgrade version of react-dnd and react-dnd-html5-backend

For some reason, everything compiles and works fine under yarn but I can't get it to work with npm. @liubko please take a look.

@feihong what exactly isn't working for you?
bsb and webpack compiled without errors, but I have a runtime error
DragDropContext.js:57 Uncaught TypeError: React.useEffect is not a function
    at exports.DragDropContextProvider (DragDropContext.js:57)
    at mountIndeterminateComponent (react-dom.development.js:14811)
    at beginWork (react-dom.development.js:15316)
    at performUnitOfWork (react-dom.development.js:18150)
    at workLoop (react-dom.development.js:18190)
    at HTMLUnknownElement.callCallback (react-dom.development.js:149)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:199)
    at invokeGuardedCallback (react-dom.development.js:256)
    at replayUnitOfWork (react-dom.development.js:17437)
    at renderRoot (react-dom.development.js:18309)


Meeting Agenda: Github flow & Important notes

We will have a meeting to explain the GitHub flow our team will follow and share important notes to keep in mind.
Date: Sunday, 29th December
Time: 10:00 AM EST

[x] 1. Explaining the GitHub Workflow

Step-by-step tutorial on the GitHub flow work.
Guidance on how to review a pull request.

[x] 2. Extensions for VS Code

Recommended extensions to enhance productivity when working with Markdown and Python files.

[x] 3. Important Notes About GitHub

Key practices to collaborate more effectively and efficiently.

[x] 4. Q&A

Addressing any questions to clarify doubts.

Meeting Conclusion
The meeting successfully covered all the planned topics, ensuring the team is well-prepared to work collaboratively using the GitHub flow. Here's a summary of the key takeaways:
1. GitHub Flow

A clear understanding of the step-by-step process for using the GitHub flow was established.
Guidance on reviewing pull requests was provided to maintain high-quality contributions.

2. VS Code Extensions

Recommended extensions were shared to boost productivity and to pass the ci checks, particularly for Markdown and Python files.

3. GitHub Best Practices

Essential collaboration practices were highlighted to ensure efficient and effective teamwork.

4. Q&A Session

All questions and doubts were addressed.

With these actions, the team is now equipped with the necessary knowledge and tools to implement the GitHub flow and collaborate more effectively. Let’s continue to uphold these best practices as we move forward.


Improve w3c_batterystatus.js

With this PR I split the commits into small targeted commits. I am hoping this makes it easier to consume. If not I can split the PR or squash the commits.

It should be noted that I assume that when this lands in closure, then google/elemental2#108 will need to be simultaneously applied.

Created internal issue http://b/130163668

@jDramaix it looks like we would need to coordinate this PR and google/elemental2#108 to avoid breaking things.
Are you interested in doing that now?

yep let coordinate. I've commented in the internal buganizer ticket.

With help from @jDramaix I've imported a combination of the two PRs and sent the resulting change for testing.


support products without password reset functionality

Usually, we do not set an initial password for the admin user, and we direct the user to use the password reset functionality to get a fresh and secure password.
For example for Tryton, there is no password reset functionality for the admin user via the web client.
Therefore we set an initial password, and display that initial password for the admin user in the frontend page which shows the details of the assigned instance.

we need to have an icon for copying the password to the clipboard, because double click on password and Ctrl-C might add an extra space.
See discussions for Firefox (https://support.mozilla.org/gl/questions/950377) and Windows (https://social.technet.microsoft.com/Forums/ie/en-US/6382c1cc-2a91-42bb-ab05-1fc6f7becef6/double-click-to-select-word-without-trailing-spaces?forum=outlook)

we need to have an icon for copying the password to the clipboard, because double click on password and Ctrl-C might add an extra space.
See discussions for Firefox (https://support.mozilla.org/gl/questions/950377) and Windows (https://social.technet.microsoft.com/Forums/ie/en-US/6382c1cc-2a91-42bb-ab05-1fc6f7becef6/double-click-to-select-word-without-trailing-spaces?forum=outlook)
see for Javascript solution: https://stackoverflow.com/questions/400212/how-do-i-copy-to-the-clipboard-in-javascript


Remove unneded mutating webhook configuration

This causes and error when doing make deploy:
https://github.com/dana-team/rcs-ocm-deployer/blob/9ada8016915f873cc0450a888bd25fdc181fc6fc/config/default/webhookcainjection_patch.yaml#L3-L13
There are no mutating webhooks so this shouldn't be here

/kind bug

/assign @sahar2339

Fixed #16


Bug fix revert

Revert back the change you implemented in the previous task using the git revert command.

Looks Good


ModSecurity not compiled with GeoIP support on arm64

Hi, when running the nginx image on arm64 arch, I have to disable (delete) the REQUEST-910-IP-REPUTATION rule to be able to start nginx, otherwise it fails with
nginx: [emerg] "modsecurity_rules_file" directive Rules error. File: /etc/modsecurity.d/owasp-crs/rules/REQUEST-910-IP-REPUTATION.conf. Line: 76. Column: 22. This version of ModSecurity was not compiled with GeoIP or MaxMind support.  in /etc/nginx/conf.d/modsecurity.conf:2

The amd64 arch doesn't have this problem.
I can see that libgeoip-dev is installed in the owasp/modsecurity:nginx image before building ModSecurity, so I don't understand why it fails. I have tried installing various packages (libgeoip1 libgeoip-dev geoip-database geoip-database-extra geoip-bin) into the container, but it doesn't help. Am I missing something? Could you please verify that ModSecurity gets built with GeoIP or MaxMind support?
Thanks so much for providing this image.

This is solved by https://github.com/coreruleset/modsecurity-docker/pull/98.

@rfricz It is building now, should take ~~ 4 hours.


Add support for format of "Keep a Changelog"

Keep a Changelog is an initiative for consistent CHANGELOG.md formatting. It especially includes links to GitHub diffs.
Example Changelog: https://github.com/olivierlacan/keep-a-changelog/blob/master/CHANGELOG.md
This PR adds support for that format.

This partially fixes #1. The result for the linked HISTORY.md is
> Mar 28, 2016

* [#76] - Fix errors in exit handlers called via `onmount.teardown()`.

[v1.2.1]: https://github.com/rstacruz/onmount/compare/v1.2.0...v1.2.1

The spurious markdown link is because the linked HISTORY.md does not put all links to versions to the end of the file. Further, the linked file does not follow the convention to put links to issues es "embedded links" and not the end of the file.

I use ## all the times as second level title for my release, so not sure it's safe this way. I didn't touch this code for a while.
Here is an example https://github.com/phenomic/phenomic/blob/0.x/CHANGELOG.md#0210---2017-04-01
Do you think your change won't break anything?
Sorry I didn't write any tests haha

The good thing is that your ## headings are not links:

The code checks for links at level 2:

So, the patch should just add support and break nothing ^^

Should not break nothing for me. But what about some others that might have links?
Can't we find a better way to detect the format before parsing?
Eg:

detect that we have # Changelog
detect that ## [ have semver number after?

OK, I included a check for the format of "KeepAChangelog" (# Changelog at the first line and a line containing a secon-level-heading with a link having the version as link text).
As a consequence, second-level headings are only regarded if the format is approximately the format of "KeepAChangelog". The edge cases where users use #Changelog and ## [1.3.0], but do something strange such as ### [1.3.1] should be very rare and thus are not treated in the check.

I successfully released version 1.1.1 of MADR using this patch on Windows 10. So the PR is finally 😇 good to go from my side!

LGTM, thanks for this work!


[FIX] Extract class names with hyphens

This PR fixes #5.
Solution description
When Vite compiles CSS modules, it creates a JS module and exports the classnames both as named exports and also in a default export object:
export const title = "_title_drylp_12";
export const small = "_small_drylp_17";
export const medium = "_medium_drylp_20";
export const large = "_large_drylp_23";
export default {
        title: title,
        small: small,
        medium: medium,
        large: large
};

However, when the classname contains an hyphen, it'll be exposed only in the default export object:
export const success = "_success_h5dzl_10";
export const error = "_error_h5dzl_13";
export default {
        "basic-button": "_basic-button_h5dzl_6",
        success: success,
        error: error
};

The fix was to extract the classname strings from both types of exports.

Good job!
Thank you @zyishai!

👍 I tested it on a local project on my machine and it worked beautifully. According to the CSS Specification, an identifier (including class names) can contain only alphanumeric letters, hyphen and underscore, so I'm pretty sure those Regexes cover every valid class name.
If there are more things to work on for the next release, please let me know. I really like Stylin and would be happy to contribute more.

Thank you @zyishai!
I have tested it and everything looks good to go.
I have published a new release which you can find at https://github.com/sultan99/stylin/releases/tag/v0.5.0.

@sultan99 It was a great pleasure working on the Vite plugin!
Of course, I'll continue to support it and this project (already thinking of supporting raw css files, we'll see how it goes 😁).
Thanks for being quick to respond and to act. I'm off to explore and experiment @holycow 😉


Reallow edu.bme.hu

Please reallow edu.bme.hu, this is the main mailing O365 subdomain for all faculties of BME (Budapest University of Technology end Economics), which includes VIK (Faculty of Electrical Engineering and Informatics) students.
https://www.vik.bme.hu/
https://login.bme.hu/

I can confirm, that these emails are only issued to admitted students with an active student status and are refreshed every semester. This university is big (1000+ freshmen every year; source) and it's possible the abuse checks were triggered incorrectly because of this.
Official info about the email service: https://login.bme.hu/en/about/

@gombossb First stage of verification passed, official domain is bme.hu as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@gombossb I am sorry, the domain edu.bme.hu is removed from our trusted domains list because the school allows to register an email address there even if you are not a student of the school. If you are the student of this school, please apply with official document (OFFICIAL DOCUMENT tab at https://www.jetbrains.com/shop/eform/students).

@philipto Please cite your source for that as that is not true.
You need to be enrolled in order to get a valid email as stated on the official website linked above.

@philipto This issue will be forwarded to the student council and university administrators unless you can provide proper sources to back up your claims, as it is already causing an influx of support questions from students not being able to request their rightful licenses.


Update class 'powerplant'

Update definition
Add 'has part' relations to 'power generating unit' and 'grid component'

Closes #588

My understanding of the discussion in #588 is that powerplant stays an artifical object as the powerplant can contain different types of power generating units and additionally has a grid component.

That makes sense. In this case we should change the definition of powerplant accordingly, maybe to A powerplant is an artificial object consisting of power generating units and a grid component that feeds electric energy into an electric grid.


Fix for concurrent modification exception on removing table

Fix for the issue https://github.com/instaclustr/cassandra-exporter/issues/77
I am able reproduce the issue with below code snippet.
`package com.zegelin.cassandra.exporter;
import com.google.common.collect.Sets;
import java.util.Set;
public class TestSets {
public static void main(String args[]) {
    Set<String> set1 = Sets.newHashSet("E1", "E2", "E3", "E4", "E5", "E6");
    Set<String> set2 = Sets.newHashSet("E4", "E5", "E6");
    Set<String> removedMBeans = Sets.difference(set1, set2);
    for (String e : removedMBeans) {
        set1.remove(e);
    }
}

}
`

This PR fixes the issue https://github.com/instaclustr/cassandra-exporter/issues/77

Would it be possible to reproduce the issue in a unit test? That way it would be easy to verify the fix, and to make sure that the issue is not re-introduced in a future refactoring.
Also, your PR contain a range of different changes. Perhaps it will be easier for maintainers to review/merge your PR if you can extract your fix into a separate branch before you create the PR.

Would it be possible to reproduce the issue in a unit test? That way it would be easy to verify the fix, and to make sure that the issue is not re-introduced in a future refactoring.
Also, your PR contain a range of different changes. Perhaps it will be easier for maintainers to review/merge your PR if you can extract your fix into a separate branch before you create the PR.

Lot of mocking required to initialize and call the method reconcileMBeans of the class JMXHarvester as the constructor itself triggering lot of functionality through metadataFactory. Since the fix I made is very simple and straight forward,I would prefer not to add any test case in this particular case.
Sorry for the inconvenience made by the rage of changes in my PR, I pulled all merged changes form zegelin/cassandra-exporter as it contains important fixes. I will find a better way next time.


Optional feature: tile-map rendering of location data

Is your feature request related to a problem? Please describe.
The MBTA V3 API contains a lot of latitudinal and longitudinal data: it'd be cool to provide some simple, optional functionality to plot this data!
Describe the solution you'd like
Leveraging the staticmap crate seems to be the simplest solution: it's a no-frills library that can render the simplest elements necessary (lines, circles, icons) without being too hefty of an addition.
Describe alternatives you've considered
There are plenty of crates related to OpenStreetMap and Google Maps, but none of them are quite as "batteries-included" a.k.a "no-implementation-required" as staticmap.

will also need the polyline crate for converting polyline strings into


SVG is loading is not loading as a component

Hi
The plugin does not seem to load the svg file as a component.
I imported svg file like this:
import ThankYou from '/images/illustrations/placeholders/thankyou.svg?component';

I also setup vite.config.ts like so:
svgLoader({
   defaultImport: 'component',
})

Despite all that I get this error:
Uncaught (in promise) DOMException: Failed to execute 'createElement' on 'Document': The tag name provided ('/images/illustrations/placeholders/thankyou.svg?component') is not a valid name

I am using version 3.4.0, which supposed to solve this issue as stated here: https://github.com/jpkleemans/vite-svg-loader/issues/51

It was an issue because file did not exist on that path. It would be easier if an error message was displayed stating the error.
I created a pull request to show the error when the file can not be loaded.


CF Demo

[ ] Update FunctionPlugin to create triggers

[x] NOTE: currently only visible in stack
[ ] Combo picker should select from published functions
[ ] When enabled should instantiate local subscription in browser (reuse logic from core/functions)

[ ] Stretch

[ ] Update ChainPlugin to create prompts
[ ] Create chess function scripts
[ ] Create GPT function script that imports prompt object

[ ] Deploy to labs.compsoer.space


Services should not be changeable

metatada.Service should be treated as constants and managed by the digital team via code instead of being changeable via the admin.
This is because we need to reference Services by their ids in different parts of the code and we need data to be consistent.
So:

disallow admin creation/edit
align environments with the prod records to fix the mess.

 It's a hangover from the old system that drives bad behaviour.


LuckPerms 4.4.18 and 4.4.19 - Gson StackOverflowError

Executing command on console was fine. but player executing command that they have permission to will result in lost connection, or sometimes cause command error for some plugin
The text "You do not have permission to execute this command!" also turn white when using affected version of luckperms, not sure if those info will help
BungeeCord : latest
Errors only occur when using LuckPerms 4.4.18+
No error while initialize
This is error when I try to execute /find
https://gist.github.com/Porama6400/53cf73b98f6b42f29e4fdd48ae003013

I have the same error.  Here are the relevant parts of the log.
https://hastebin.com/azekalevon.cs
First stack happens after user with wrong MC version tries to join.
Second stack happens when a player runs custom command that uses TextComponent to get the result.
It never mentioned LuckPerms once, so it took me a while to find out that LuckPerms is the culprit of the issue.  I'm not sure if the logs will help in debugging the problem, but it should help on knowing what libraries are affected by it.

I think the fact that the messages of permission are no longer coloured and they may be White may finally help.

https://github.com/KyoriPowered/text-extras/pull/7


Missing many special characters in desired_characters file (Swedish)

The file desired_characters does not contains many of the important special characters like "@".
All special characters in english is also important for swedish language.
Law documents contains section sign § character. Please add this as well.

From https://github.com/tesseract-ocr/tesseract/issues/2075:

It's also possible to use script/Latin for Swedish. That should contain all characters.

Only symbols included in swe.unicharset will be detected during OCR. If a symbol is missing, it can be added by fine tuning training.

The desired_characters file is used for the training done by Google. The tesseract training tools which are available in https://github.com/tesseract-ocr/tesseract do not use it.

@amitdo should I then use https://github.com/tesseract-ocr/tesseract/wiki/TrainingTesseract-4.00#fine-tuning-for--a-few-characters ? Is there any easier way? A training GUI for tesseract 4?

should I then use https://github.com/tesseract-ocr/tesseract/wiki/TrainingTesseract-4.00#fine-tuning-for--a-few-characters ?

That suppose to be the way...
but it's not so easy.

Is there any easier way? A training GUI for tesseract 4?

I don't know.

The current danish traineddata has the same issue. Really danish should be exactly the same as swedish except for ö->ø and ä->æ.

@poizan42, I suggest to create a pull request which adds the missing characters to the list of desired characters.
You can try the script/Latin model which should already support all Danish characters, or you could enhance the existing dan.traineddata, either by fine-tuning (see link above) or by using tesstrain. I prefer tesstrain because I found it easier to use.

@stweil, I have created a PR in #34

I merged that PR now, thanks. Please note that we cannot expect new training done by Google, so it is up to the Open Source community (= you, me, ...) to use the fixed information and train new models.


Swift3.0 support

        func convert<S: NumericType>(_ s: S, arr: [S], f: (S) -> S) -> [S] {
            switch arr.match {
            case let .some(h, t):   return [f(h) + s] as! [] + convert(h + s, arr:t, f: f)
            case .none:             return []
            }
        }

I dont know how to re-write this part in swift 3

+1 for Swift 3 Support

+1 for Swift 3 Support

please!

Such good framework please update to swift 3.0!!! PLZ @ohida  @emeitch @remore @kasajei

Please!


pythonPackages.mercantile: init at 1.2.1

Motivation for this change
Mercantile - spherical mercator coordinate and tile utilities.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 123592 at e52d94cc run on x86_64-linux 1

3 packages built successfully:

python38Packages.mercantile
python39Packages.mercantile
tests.trivial


[Android] build failed

Bug
build failed on react-native 0.73, using openjdk 17
Here is the error message:
'compileDebugJavaWithJavac' task (current target is 17) and 'compileDebugKotlin' task (current target is 11) jvm target compatibility should be set to the same Java version. Consider using JVM toolchain: https://kotl.in/gradle/jvm/toolchain

Environment info

Library
Version

react-native-image-colors
2.3.0

Steps To Reproduce

Install this library and setup the expo modules
run npm run android

Describe what you expected to happen:
1.build success with no error
Reproducible sample code

Fixed by https://github.com/osamaqarem/react-native-image-colors/pull/85
Please try version 2.4.0 and re-open the issue if problem persists.


Added no-unnecessary-condition rule

Closes: https://issues.redhat.com/browse/RHOAIENG-511
Description
added no-unncessary-condition eslint rule

How Has This Been Tested?
npm run test:lint

Test Impact

Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

/hold until next sprint

@christianvogt this line has similiar case  as that for the data connection type

@pnaik1 the line you mention above is unnecessary because there's only 2 literals in the enum. If the first check fails, the else condition can only represent the other literal. Therefore you can remove part of that function. Leaving the conditions in comments is something you can do.

/lgtm
/approve


chore: Disabled Bubble test

SUMMARY

I observed that test which I enabled recently in some runs started to fail - After try of reproduce I also had unstable runs this time. I tried to fix this but failed. I suggest skipping again.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #11630 (2e370b8) into master (5be1dbe) will decrease coverage by 0.99%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11630      +/-   ##
==========================================
- Coverage   61.92%   60.92%   -1.00%
==========================================
  Files         422      422
  Lines       26295    26284      -11
==========================================
- Hits        16282    16013     -269
- Misses      10013    10271     +258

Flag
Coverage Δ

python
60.92% <ø> (-1.00%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
31.91% <0.00%> (-59.58%)
:arrow_down:

superset/db_engine_specs/hive.py
53.90% <0.00%> (-30.08%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/presto.py
69.76% <0.00%> (-12.53%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/databases/api.py
81.94% <0.00%> (-6.02%)
:arrow_down:

superset/databases/dao.py
94.11% <0.00%> (-5.89%)
:arrow_down:

superset/views/database/validators.py
78.94% <0.00%> (-5.27%)
:arrow_down:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be1dbe...2e370b8. Read the comment docs.


Cannot authorize

Every time I try to send a request I get an error saying it is unauthorized despite me using the same auth-id and auth-token in both postman and curl requests successfully.
I added some logs into the package and this is what I get:

console.log
{ data: 'Unauthorized<PHONE_NUMBER>)\n',
status: 401,
statusText: 'Unauthorized',
headers: { 'content-type': 'text/plain; charset=utf-8' },
config:
{ adapter: [Function: xhrAdapter],
transformRequest: { '0': [Function: transformRequest] },
transformResponse: { '0': [Function: transformResponse] },
timeout: 10000,
xsrfCookieName: 'XSRF-TOKEN',
xsrfHeaderName: 'X-XSRF-TOKEN',
maxContentLength: -1,
validateStatus: [Function: validateStatus],
headers:
{ Accept: 'application/json, text/plain, /',
'Content-Type': 'application/json; charset=utf-8' },
method: 'post',
params:
{ agent: 'smartystreets (sdk:javascript@1.6.0)',
'auth-id':  {correct auth id},
'auth-token': {correct auth token} },
baseURL: 'https://us-street.api.smartystreets.com/street-address',
data:
'[{"street":"330 N 100 W","street2":"closet under the stairs","secondary":"APT 2","city":"Provo","state":"Utah","zipcode":"84601","addressee":"John Doe","match":"invalid","candidates":3},{"street":"1600 Amphitheater Pkwy","lastline":"Mountainview, CA","candidates":5},{"street":"1600 Amphitheatre Parkway Mountain View, CA 94043","candidates":1}]',
'axios-retry': { retryCount: 0, lastRequestTime:<PHONE_NUMBER>613 },
url: 'https://us-street.api.smartystreets.com/street-address' },
request: XMLHttpRequest {} }

  at Axios.then.response (node_modules/smartystreets-javascript-sdk/src/HttpSender.js:49:14)

It has the correct auth-d and auth-token (I copied and pasted them into curl and postman requests from this log and those requests worked) but doesn't seem to authorize.  I even added the same agent param to postman and curl, and those requests work.

Hey guys, I am having a very similar issue...
I'm using the javascript sdk to validate an address on the backend. By following the example (https://github.com/smartystreets/smartystreets-javascript-sdk/blob/master/examples/us_autocomplete_pro.js) I have
import SmartyStreetsSDK from 'smartystreets-javascript-sdk';
const SmartyStreetsCore = SmartyStreetsSDK.core;
const Lookup = SmartyStreetsSDK.usAutocompletePro.Lookup;

const credentials = new SmartyStreetsCore.SharedCredentials(process.env.SS_WEB_KEY);
const client = SmartyStreetsCore.buildClient.usAutocompletePro(credentials);

export default async function handler(req, res) {
  const { address } = req.query;
  try {
    const lookup = new Lookup(address);
    const res = await client.send(lookup);
    console.log('res', res);
  } catch (err) {
    console.log('err::', err);
  }
 ...
}

and getting an authorization issue
err:: Response {
  statusCode: 401,
  payload: 'Unauthorized<PHONE_NUMBER>)\n',
  error: BadCredentialsError: Unauthorized: The credentials were provided incorrectly or did not match any existing active credentials.

However, I'm doing a similar lookup on my front end code and works just fine (using the same key)
...
const query = querystring.stringify({
  key: process.env.SS_WEB_KEY,
  license: 'us-autocomplete-pro-startup-cloud',
  search: inputValue,
  prefer_geolocation: 'CITY',
});

const res = await axios.get(`https://us-autocomplete-pro.api.smartystreets.com/lookup?${query}`);
...

Any idea why this could be happening?

The US Autocomplete Pro API only supports website key authentication:
https://smartystreets.com/docs/cloud/us-autocomplete-pro-api#pro-http-request-url


Use kubernetes Node status' addresses ExternalIP field for autodetecting node-to-node mesh BGP peer ip

When I set-up new node in a cloud environment it's common that it uses internal ip like <IP_ADDRESS> even though it has assigned and is accessible by public ip. Then trying to connect this node into a cluster outside of the same cloud environment create issue that such internal ip cannot be used, public ip should be used instead.
The public ip is not visible among network interfaces though, so I suppose it's hard to auto-discover it from inside the node. However kubernetes node's status contains the necessary information as ExternaIIP address field:
https://kubernetes.io/docs/concepts/architecture/nodes/#addresses
I would like calico to use that information (if available) to assign peer IP in BGP node-to-node mesh instead (or alternatively when a different autodetection algorithm is specified) of trying to guess it from a source like list of network interfaces, which sometimes might be ambiguous or simply do not contain the right information at all.
Expected Behavior
Autodetection of IP address in calico/node queries kubernetes for current node's status and uses the information, e.g.
status:
  addresses:
    - type: ExternalIP
      address: <IP_ADDRESS>

to assign projectcalico.org/IPv4Address and advertise it to BGP peers as ip to connect to
Other nodes shoudl then correctly establish connection using external ip set on a node, e.g.
./calicoctl node status
Calico process is running.

IPv4 BGP status
+---------------+-------------------+-------+----------+-------------+
| PEER ADDRESS  |     PEER TYPE     | STATE |  SINCE   |    INFO     |
+---------------+-------------------+-------+----------+-------------+
| <IP_ADDRESS> | node-to-node mesh | up    | 03:46:41 | Established |

Current Behavior
calico/node reports in logs the autodetected ip from listing interfaces:
[INFO][95] monitor-addresses/startup.go 713: Using autodetected IPv4 address on interface enp0s3: <IP_ADDRESS>/24
This internal ip is set as value of  projectcalico.org/IPv4Address annotation and BGP peers (being outside of that internal network) are unable to establish connection:
./calicoctl  node status
Calico process is running.

IPv4 BGP status
+---------------+-------------------+-------+------------+-------------+
| PEER ADDRESS  |     PEER TYPE     | STATE |   SINCE    |    INFO     |
+---------------+-------------------+-------+------------+-------------+
| <IP_ADDRESS>     | node-to-node mesh | start | 14:15:41   | Connect     |

while status reported on the affected node is:
./calicoctl node status
Calico process is running.

IPv4 BGP status
+---------------+-------------------+-------+----------+---------+
| PEER ADDRESS  |     PEER TYPE     | STATE |  SINCE   |  INFO   |
+---------------+-------------------+-------+----------+---------+
| <IP_ADDRESS> | node-to-node mesh | start | 01:58:52 | Passive |

Possible Solution

use ExternalIP address discovered at runtime by quering kubernetes
this could be a new autodetection algorithm selected by new name for IP_AUTODETECTION_METHOD though it could also be used by default (when the ExternalIP is set, which might not always be the case)

Steps to Reproduce (for bugs)

create two nodes, where at least one of them uses private cloud and is assigned internal-ip, both nodes should have connectivity using their public ips
set-up kubernetes with calico and wireguard enabled on those nodes
observe calico detecting internal ip and advertising it to the other node as BGP peer ip
the other node cannot access internal ip (from different private cloud), thus can't connect to the peer

Context

the projectcalico.org/IPv4Address annotation on kubernetes can be manually modified and it fixes the connectivity of nodes in my case (calico/node detects the change and rebuilds / re-advertise the new address)
Right now I'm exploring a way to override the ip used by calico node by using IP env variable, but I need to find a way to extract it from runtime information available to use in config

Your Environment

Calico version - docker.io/calico/node:v3.21.1
Orchestrator version (e.g. kubernetes, mesos, rkt): k3s kubernetes version v1.22.3+k3s1
Operating System and version: linux, Ubuntu 20.04.3 LTS

FYI this PR introduces something similar - a new autodetection method for KubernetesInternalIP - sounds like you want ExternalIP though?

Yes, well, the point is for nodes to be able to reach each other, so depending on the setup you may be able and prefer internal ip, but in my case of connecting nodes in different private clouds the only choice is using external ip.
I suppose the connectivity of other nodes to current node's either internal or external ip might be out of scope of current node's detection, so probably an option would be necessary to prefer either one.
BTW, which PR exactly are you referring to?

but in my case of connecting nodes in different private clouds the only choice is using external ip

Hm, this is a bit of an odd choice. I generally wouldn't recommend this - would be curious to hear what's your use case?
Running a single cluster across multiple public clouds introduces new failure modes for that cluster. Most folks I speak to run separate clusters on different clouds for redundancy, which is what I'd reocmment.

BTW, which PR exactly are you referring to?

Whoops! This one: https://github.com/projectcalico/node/pull/1242

Well, I know it is not the most popular or generally advised approach, but
multi-cloud (mentioned in places like this
https://cloud.netapp.com/blog/gcp-cvo-blg-multicloud-kubernetes-centralizing-multicloud-management?hs_amp=true)
seems like a simpler way to build a distributed environment that avoids
vendor lock-in, optimizes cost and spreads the failure domain across
largely independent entities.
K8s, network virtualisation (as provided by Calico), distributed storage,
etc. are generally the kind of abstractions that I prefer to work with
instead of building new layers of replication, failover and resource
scheduling that would be required in a multi-cluster approach. And I
suspect they are still going to suffer from the kind of failure modes that
I imagine can appear when you join resources connected over the public
internet.
In my current set-up I do have control plane nodes inside a single cloud
provider (tight latency requirements provide a strong argument here, but
technically it still works in wider layout with a few ms larger distances),
but I'm adding worker nodes from different providers and experimenting with
adding some on-premise NATed devices (Raspberry PI) treating k8s and
underlying network plane as the simplest way to cluster all my resources
into single-access pool.


Fixes #930 CC0020 cannot be used when types are declared

Fixes #930 by checking if the calling method has generic type definitions. There could be cases that the generic type can be inferred but I'm not checking for that.

Coverage increased (+0.002%) to 91.687% when pulling 9ccc2bb21012d0845156af28fab4e56f15cd8474 on Muppets:CC0020-cannot-be-used into d1561e7919823f722ff29d6e71a9acfc3a287006 on code-cracker:master.


Extra space in one of the contributers names

The link was being rendered differently than all of the other links existing on this page

Took the chance and added https links for all contributors that are currently listed on master (issue #68)

@luisf1821 - Merged! Don't forget to add yourself!

@scrabill done ;)


How to use fluent api to build /filters/

Hello,
How to use /**filters**/ to build dynamic conditions when using fluent api?
Thanks
Use QueryBuilder
var filters = new Filters(Filters.FiltersType.AND);
filters.Add(new Filters()
{
    new Filter($"Weight >= {20}"),
    new Filter($"Weight <= {30}")
});

var builder2 = new QueryBuilder(null, $@"SELECT ProductId, Name, ListPrice, Weight
FROM [Production].[Product]
WHERE 1=1 /**filters**/
ORDER BY ProductId");

builder2.Where(filters);
Console.WriteLine(builder2.Sql);

Output
SELECT ProductId, Name, ListPrice, Weight
FROM [Production].[Product]
WHERE 1=1 AND (Weight >= @p0 AND Weight <= @p1)
ORDER BY ProductId

It works great!

Use FluentQueryBuilder
var builder = new FluentQueryBuilder(null);

builder.Select($"ProductId");
builder.Select($"Name");
builder.Select($"ListPrice");
builder.Select($"Weight");
builder.From($"[Production].[Product]");
builder.Where($"1=1");
builder.Where($"{filters}");   //the filters defined in the above code
Console.WriteLine(builder.Sql);

output
SELECT ProductId, Name, ListPrice, Weight
FROM [Production].[Product]
WHERE 1=1 AND @parray0

The filters were replaced with @parray0?

By the code looks like FluentQueryBuilder.Where can take a Filters object.
Try builder.Where(filters); - it should get what you expect

Great, Thanks!