Bradjohnl gh sre 486 new nctl test w custom override

Adding tests with the custom overrides to this PR directly so that Michal can test using bors.
This change introduce some duplication in the test overrides, but it is making use of the current approach implemented in the nightly-test.sh logic.
Doing it in another way would have required to rework the CI script logic and it would have risked going out of scope and would have required more time.

bors try


Allow the admins to enable/disable plugins at runtime

This disables the plugin. If you provide a boolean value of true, it disables it permanently. If you give false, it is only until you restart the bot or re-enable it.
!disableplugin <tag>
!disableplugin <tag> <ispermanent>
This enables the plugin. If you provide a boolean value of true, it enables it permanently. If you give false, it is only until you restart the bot or disable it again.
!enableplugin <tag>
!enableplugin <tag> <ispermanent>
If you want to do it permanently, it should save this in the bot settings using the settings API.
If you try to use a plugin command for a plugin that is disabled, it should give you a message.

Added


2<IP_ADDRESS> set charging power

I just upgraded my Tesla Model 3 with SW version 2<IP_ADDRESS>
The release note states, that there is now the possibility to configure the charging power via the Tesla App. I checked and this seems true. There is now a new configuration option in the iPhone Tesla App.
If the App can control charging power, then there is most probably another option available in the API.
Could you try to figure this out and update the API documentation?

Kind regards,
Urs.

Duplicate of #445


Feedback for "Getting Started in the Kyma Environment"

https://help.sap.com/docs/BTP/65de2977205c403bbc107264b8eccf4b/d1abd18556f24fb091d081b2e3454b8b.html?
Would be helpful to also mention Free Tier. At the moment the documentation only has links saying:

"Getting Started with an Enterprise Account in the Kyma Environment"
"Getting Started with a Trial Account in the Kyma Environment"

Maybe have Free Tier in there as well.

Thank you for your feedback! We’ll look into it and come back to you if we have any questions.

Hi, @KevinMuessig!
This is already being worked on.
We have our own internal ticket for this (not going to link it here for security reasons), so I'm going to close yours.
Thank you for your contribution 😊

https://people.sap.com/kevin.muessig


failed when mapping pacbio data to reference

hi, when I try to map pacbio data to reference via NextGenMap-LR 0.1.6 (build: Nov 29 2016 16:41:27, start: 2016-12-26.22:31:35), the program was Terminating.
command line: /data/xthua/tools/nextgenmap-lr/ngmlr-0.1.6/ngmlr -t 128 -r ../XH317.fa -q ../../../XH988-XH317/Analysis_Results/combined.fa -o ng.sam
The error information was listed below:
Could not decode reference for alignment
Could not align reference sequence for read m161212_181230_42256_c101054842550000001823247601061741_s1_p0/127521/0_18785.
Thanks very much!
Best wishes,
Xiaoting

Hi,
I got the same error while I was mapping fasta reads to the reference.

ngmlr -r $REF -q $READ -o $OUT -t 20
NextGenMap-LR 0.1.6 (build: Nov 29 2016 16:41:27, start: 2016-12-27.16:08:58)
Contact<EMAIL_ADDRESS>Opening for output (SAM): /data/run/wangj/projects/05_Erwinia_genomics/structuralVar/mapping/249.sam
Reading encoded reference from /data/run/wangj/projects/05_Erwinia_genomics/refGenome/ATCC49946.fna-enc.2.ngm
Reading 3 Mbp from disk took 0.00s
Reading RefTable from /data/run/wangj/projects/05_Erwinia_genomics/refGenome/ATCC49946.fna-ht-13-2.2.ngm
Reading from disk took 0.26s
Input is Fasta
Mapping reads...
Could not decode reference for alignment
Could not align reference sequence for read m161022_170429_42146_c101102972550000001823260204261761_s1_p0/88005/24115_38554.
Terminating

Thanks,
Jie

@xthua I kind of solved this problem. I have merged all three fasta files into one combined fasta file. I guess the combined fasta file caused this problem. Now I just mapped each fasta file to reference separately, it worked just fine.

Hi and thanks for the bug report!
I just uploaded ngmlr 0.2.1. Could you please try whether this update solved the problem?
If not, please let me know!
Thanks,
Philipp

I am testing it on NextGenMap-LR 0.2.2 (build: Jan 15 2017 13:38:00, start: 2017-01-18.09:13:27), which was installed from bioconda.

Thats perfectly fine as well. 0.2.2 should give the same results as 0.2.1 as it only adds conda compatibility.


Tag ent tests

Put ent tests behind tag integrationEnt until we have infra to bring up a postgres instance in our integration tests.

Note: postgre is being brought up in the CI workflow but not in the postmerge workflow yet causing it to fail. @jeffmendoza did we want to make an issue to capture this?

Oh, I see. I'll update this one then.


[Feature Request] Default Themes to be bundled.

Currently Lib Themer does not ship with any default themes. During the early beta it had its default theme as well as the Cobalt Theme.
These served as both a useful demo for the sort of styles that were possible as well as an easy way to reset all settings back to their default value, which is not currently possible without painstakingly resetting all settings individually or making a backup immediately upon loading LibThemer for the first time.
Shipping LibThemer with a few attached themes would make it easier to understand and easier to reset when a user inevitably breaks something.

I did actually have this idea, if you look at the github, there is a presets folder, but those appear to not be included in the actual release. Seems like a small oversight and should be easy to fix on my end.

Added two default themes that can be enabled via a settings in the settings window in version 1.0.5 https://github.com/mouse0270/lib-themer/releases/tag/1.0.5


Add i18n translations

Given how little actual text there is in the app, it would be really easy to internationalise it using angular-translate. Am thinking Spanish, German, French, Japanese, Cantonese and Mandarin to start out with, in that order.

Wanting to help with translating Axis?
It's easy! Fork [this file] and add your language's strings as the translation values (Make sure to keep all the "ALL CAPS" text intact — don't edit it!). Then either submit a PR (preferred) or post it as a Gist, linking to it via a comment on this issue.
Many thanks! The non-English-speaking data journalists of the world thank you!


chore(NODE-5455): benchmark FLE

Description
What is changing?

Add FLE benchmark

Is there new documentation needed for these changes?
No
What is the motivation for this change?
Determine what the performance of FLE is.
- cpu: Apple M1 Max
- node: v22.0.0
- cores: 10
- arch: arm64
- os: darwin (23.5.0)
- ram: 32GB

Decrypting 1500 fields median ops/sec : 74

Double check the following

[x] Ran npm run check:lint script
[x] Self-review completed using the steps outlined here
[x] PR title follows the correct format: type(NODE-xxxx)[!]: description

Example: feat(NODE-1234)!: rewriting everything in coffeescript

[x] Changes are covered by tests
[x] New TODOs have a related JIRA ticket

Switching from cryptoCallbacks to native crypto: https://github.com/mongodb-js/mongodb-client-encryption/pull/18 shows good signs of being a large perf improvement


Segregate reporting of internal breaking changes

Hi! thanks for this awesome tool!
Is your feature request related to a problem? Please describe.
It seems that the package considers the removal of internal APIs(@internal) as breaking changes. It is my understanding that internal APIs are not intended for public use and can change without notice so treating their removal as major breaking changes might not be accurate.
Describe the solution you'd like

One solution would be to add a CLI option to allow users to opt in for checking internal breaking changes.
(Or) Report internal changes under a separate category("Internal Breaking Changes").

Hi.
Nice idea. I think it would be best to just support the internal annotation just like dart_apitool already supports the sealed and experimental annotations. 👍

Yea, that'll be good too.


Brew installation in docs but not on brew.sh

The installation of slidy with brew doesn't work.
Warning: No available formula with the name "slidy". Did you mean slides or solid?
==> Searching for similarly named formulae...
These similarly named formulae were found:
slides                                   solid
To install one of them, run (for example):
brew install slides
==> Searching for a previously deleted formula (in the last month)...
Error: No previously deleted formula found.
==> Searching taps on GitHub...
Error: No formulae found in taps.

fixed in doc


Support for multiple tsconfig.xxx.json per app/library

I have a monorepo setup (pnpm workspaces), where each package has essentially three tsconfigs

tsconfig.build.json - for the build options
tsconfig.spec.json - for test-specific options (e.g. including test files)
tsconfig.json - which ties them together via references with the content:

{
    "extends": "../../tsconfig.base.json",
    "files": [],
    "include": [],
    "references": [
        {
            "path": "./tsconfig.build.json"
        },
        {
            "path": "./tsconfig.spec.json"
        }
    ]
}

Where tsconfig.base.json is the very root one.
When I run this script in the project, it removes those references completely, leaving me with this:
{
    "extends": "../../tsconfig.base.json",
    "files": [],
    "include": [],
+    "compilerOptions": {}
-    "references": [
-        {
-            "path": "./tsconfig.build.json"
-        },
-        {
-            "path": "./tsconfig.spec.json"
-        }
-    ]
}

which I don't want, because it breaks editor support.
I just want it to add references to libraries that this one depends on. Is there any way of achieving that?

Thank you for the reply, the structure looks almost like what you show, but with the exception that each lib has one tsconfig.json (that references the root one). that is referenced by spec and build
├── 📂 packages
│   ├── 📂 package-a
│   │   ├── 📄 tsconfig.spec.json  // extends  ⬇⬇
│   │   ├── 📄 tsconfig.build.json // extends  ⬇
│   │   ├── 📄 tsconfig.json       // extends "base", references "spec" and "build", possibly "package-b/tsconfig.json"
│   │   ├── 📦 package.json
│   ├── 📂 package-b
│   │   ├── 📄 tsconfig.spec.json  // extends ⬇⬇
│   │   ├── 📄 tsconfig.build.json // extends ⬇
│   │   ├── 📄 tsconfig.json       //extends "base", references "spec" and "build",
│   │   ├── 📦 package.json
├ 📄 tsconfig.base.json  // extends/referencs nothing
├ 📄 tsconfig.json       // extends "base", references all root tsconfigs in packages (for editor support)
├ 📦 package.json

When I understand correctly the approach this build config is also used for local development which in my eyes isn't necessary I even would say this an antipattern, because it abused project references to trigger a additional build step for the same package. In your case I assume it does two for spec and build under the hood.

The build tsconfig (sometimes called tsconfig.app.ts or tsconfig.lib.ts) is generally for files in the src subfolder. The tsconfig.spec.ts is for files in the test folder.
The reason two are needed is because test files generally also need the testing framework types, which are not exposed to the app. Also, in the test files, we might want to loosen the strictness of typescript to enable easier mocking. This is definitely not an exhaustive list, but separating these tsconfigs is by no means an anti pattern.

However, I am not sure where you're coming from with your question/remark?

However, I am not sure where you're coming from with your question/remark?

I was reading this below and this was pointing out to add them as project references to ensure that the lib folder is created to access the types.

However, there is a giant caveat with this approach! Because TypeScript utilizes Node.js's module resolution, it will reference the declarations defined by the package.json types or exports fields, instead of the outDir compiler option, and the other tsconfig.json does not guarantee these files will exist. This results in TypeScript failing to find the appropriate types! To solve this, add the tsconfig.build.json as a project reference to tsconfig.json.

To just underline my reasoning (without blaming or offending) here the explanation from the docs:

Project references allows you to structure your TypeScript programs into smaller pieces, available in TypeScript 3.0 and newer.
By doing this, you can greatly improve build times, enforce logical separation between components, and organize your code in new and better ways.

By giving TS the info via references it determines what to build first and in which order.
Now the example with reference two local tsconfigs and let's assume package a depends on package b and you want to build a

it will look for references and finds the path to the tsconfig of package b
in the package b tsconfig.json it will find the tsconfig.build.json so it will build/process your package a the first time
as next it will find the second ref in the tsconfig called tsconfig.spec.json so it will build/process your package a the second time but with tests included
afterwards it will continue with package a and build/process that one and if you have again to configs additional to the dependency it will build/process them to

If you have a huge repo with a lot of packages and dependency that will advantage of having an improvement on the build time might turn in the opposite in my opinion.

I agree that it might not be the ideal solution, but there's no perfect setup for monorepos and TypeScript (this guy wrote a great sunnary).
As I said, I need these references for editor support (VSCode, but I would assume it's not the only one). If the references are not there, then go to source and name refactoring doesn't work (it instead goes to the built version)
I also need multiple tsconfigs per project for the reasons stated earlier.
I can solve both of my problems by adding those references, maybe at the expense of a slower builds, but since I also employ incremental build (composite: true), I don't see that as an issue at all.
What is also nice is that I can type-check the entire codebase at once instead of iterating over all projects and triggering the type-check for each one.

Currently I need to remember to add a new reference to the base when I add a new library, and to all the referenced libraries that it uses (which people forget a lot).
I was hoping to use this tool to automate the process, but unfortunately, it fell short for out setup (which is by no means unique).
The simplest solution I see would be to add a CLI flag that prevents removing existing references (--no-remove?), since that covers 99% of all cases. Otherwise, some heuristic (best-guess) would be probably needed - like, don't touch references to files in the same folder?

Is this something you'd consider adding?


Multi Data Source Zabbix

I have created data source variables for Zabbix in GRAFANA. I have several Zabbix instances.
Zabbix z instance has HostA.
Zabbix p instance has HostB.
If I select "multi" Values DataSource Zabbix z+Zabbix p or "All" option on my dashboard, I don’t see Items of HostA + HostB, but I see only items of HostA
My Grafana version is: Grafana v9.1.8 (f7035b8d72)
My ZABBIX Plugin version: 4.2.10
If I select only one Datasource: Zabbix z or Zabbix p, I see HostA or HostB.
I need to see the items of HostA+HostB

Zabbix Datasource Variable config:

Zabbix Host variable config:

Is it a bug?
What is the solution for this case?
Thanks
Omid

May I have update?


question about adding geojson data

hi, @robhawkes . this repo is real cool! great job.
I found VIZI.geoJSONLayer() function need a url path like 'http://vector.mapzen.com/osm/roads,pois,buildings/14/4824/6159.json'
what is this url service? is it a http service defined by mapzen format or yourself format?
and how can I want to change to my own data?
thanks.

another fan here :)
geoJSON is defined in http://geojson.org/
am not aware of any differences to it in mapzen nor vizi, afaik they just use standard geojson


Filtering metrics?

We're using Hosted Graphite (great service btw), and we are charged by our metric count. We have ring metrics, JVM metrics, and custom metrics and are going over our cap. I'd like to filter some of the ring metrics as we only need a few from here, but it's not clear if/how to do that? I read the docs on removing metrics, but it seemed like they would just be recreated later.
What's the recommended way of filtering the metrics that get sent to a (graphite) reporter?

You can either

Remove metrics and not collect them (so that they do not get recreated)
Develop a custom reporter (a Java interface implementation)

I'm not aware of a way to filter out metrics in reporters other than duplicating the entire metric registry and removing some keys right before sending the data.

By the way, I am open to ideas about how to address this but I'm afraid this specific library is largely at the mercy of a feature provided in Dropwizard Metrics. Unless we want to subclass every single reporter, at least.

Actually, there is MetricFilter which can be passed in but there is no way to define one as a Clojure function.

When you say "passed in", where is it passed?

To functions that instantiate metric reporters.

Awesome, I'll take a look at this. If it works well, I'll put together a PR to make it more Clojure native.


NO-JIRA: Add rpms-signature-scan task

What this PR does / why we need it:
Adding required rpms-signature-scan task to pipelines.
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/ok-to-test
/lgtm

/retitle NO-JIRA: Add rpms-signature-scan task

/area ci

/area testing

/approve


bpf: Introduce per-cluster conntrack maps

This is a part of the Cluster Mesh with overlapping PodCIDR support. When the remote cluster has an overlapping PodCIDR, we must identify the remote endpoint using IP + ClusterID. CT is not an exception, so it's ideal for extending the CT map's key with a new ClusterID field. However, the problem is we cannot extend the CT map without breaking users' connections now. Thus, we created a new map-in-map containing the CT maps for each cluster.
This PR only contains basic map definitions and tests. No one uses it. We also don't have GC for per-cluster maps because GC depends on the NAT map. Once I implement per-cluster NAT (it has the same problem), I'll publish another PR for GC.
bpf: Introduce per-cluster conntrack maps

Applied the fix suggested by Timo.

/test

k8s-1.16-kernel-4.9 is failing because map-in-map is from 4.12

I surrounded the per-cluster CT maps with guard macro ENABLE_CLUSTER_AWARE_ADDRESSING.
https://github.com/cilium/cilium/pull/22857/files#diff-5c024a095befbdabbdd926da1b0c8937d6dec93f4b7f7f09cfcf431b73bed814R40
And added new maps to ignore list.
https://github.com/cilium/cilium/pull/22857/files#diff-24b6dbe6806c91a53adf84e5aa545c62de4474c19e276e1ff2bc6e8207273143R65

/test


Make markymark safe to use in extensions

Currently, when trying to use markymark via cocoapods, and linking it into a framework, we get the compiler error 'shared' is unavailable: Use view controller based solutions where appropriate instead.. This is because UIApplication cannot be used from extensions or dynamically linked frameworks.
A possible solution to make markymark extension safe is outlined here: https://gist.github.com/natecook1000/151d8de423eb77fc87bf#gistcomment-1656503

Thanks for your input.
Is it possible to be any more specific? Which parts of markymark are not safe for extensions and whats solution are you proposing?
Regards,
Jim

The problem is the use of UIApplication.shared.openURL(url) in AttributedInteractiveLabel. UIApplication is not extension safe.
The proposed solution is to "hide" the API usage by using NSClassFromString(@"UIApplication") instead of UIApplication directly. This approach apparently also worked for SDWebImage.

An alternate, less hacky, solution could be delegation, where AttributedInteractiveLabel would have a delegate that gets informed about opening the url, but that might be a breaking change in the API. Also the AttributedInteractiveLabel will not be a drop-in solution any more if link handling is required.

Thanks for your input @mhoeller-clue, i looked into your pull-request and made https://github.com/M2Mobi/Marky-Mark/pull/74 inspired by your approach.
This pull request will allow markymark to compile in extension by using NSSelectorFromString("sharedApplication") instead using UIApplication.shared directly.
Also, this pull request will allow customization of the open url behavior by providing an implementation of URLOpener
My collegues will review the pull request and i will let you know as soon as i release a new version. Also, let me know what you think of this approach!

Looks perfect! It has much deeper integration throughout the system and extends the example project too 👍
Thanks for putting the work into this library! Looking forward to the new version.

Just release the new version!


How to use this in ReactJS ?

I've been having problem of cutting 128kbps mp3 files in valid chunks. I think this library can solve my problem.
But I can't find a way to load it in my React project.

.
├── ...
├── public
│   ├── simple-mp3-cutter
│        ├── lib
│        ├── src
│   ├── index.html
│   └── manifest.json
└── ...

This is how I structured my public folder. I included loadFile function in script of index.html.
I am accessing it from any component with window.loadFile
I know, it's probably very newbie approach to the problem. I am open to the better options.


Add first wlr_surface example implementation

Implements no real new functionality for it but makes sure buffer attaching already follows the wayland protocol and updates the compositor example. The base for further work on implementing wl_surface.

Thanks!


Uncaught TypeError: (namespaces || "").split is not a function

vendor.js:131093 Uncaught TypeError: (namespaces || "").split is not a function
    at Function.enable (vendor.js:131093)
    at Object.<anonymous> (vendor.js:18660)
    at Object.isArray (vendor.js:18679)
    at __webpack_require__ (vendor.js:588)
    at fn (vendor.js:112)
    at Object.toString (vendor.js:20812)
    at __webpack_require__ (vendor.js:588)
    at fn (vendor.js:112)
    at Object.<anonymous> (vendor.js:191488)
    at __webpack_require__ (vendor.js:588)

If process.env.DEBUG is set to a value other than a string a TypeError occurs. This can easily happen when using webpack to build a project, as you can see from the error stack above.

Fixed on 2.6.4  Thanks for the PR @LucianBuzzo


'this' escapes constructor bugpattern

A simple checker for the issue #184 . Does not use more advanced features such as dataflow to detect the pattern more accurately (that is if everything has been initialized at that point/expression).
Closes #184.

I added a note to https://github.com/google/error-prone/issues/184 with some more history.
Based on our experience with the previous ConstructorLeaksThis check, this isn't a good fit for core Error Prone unless we can find additional heuristics to reduce the false-positive rate. (Also as I noted in the bug, this may be unnecessary to add to Error Prone now that javac has a related built-in diagnostic.)


exiv2: 0.26.2018.12.30 -> 0.27.1

Motivation for this change
Fixes https://github.com/NixOS/nixpkgs/pull/50496
Currently working through the failures and fixing them.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Last packages to fix (I think) are

cataract-unstable (not sure stable can be fixed)
ufraw
gimpPlugins.gimplensfun

And I think maybe remove gegl_0_3.


Suggest use of ColorPickerButton to show picker.

It's not obvious that the color picker "pop-up" behaviour (as seen in the Godot Editor) is implemented via a ColorPickerButton rather than use of a ColorPicker directly.
This adds a pointer to the ColorPickerButton in the docs for ColorPicker. (Which would've saved me a web search.)
(There's already a pointer to ColorPicker in the ColorPickerButton docs.)
[Feel free to edit wording to taste as I'm not currently checking/acting on GitHub notifications very regularly.]

@follower Bump :)

Supersedes by https://github.com/godotengine/godot/pull/53040. Your contribution is noted in the commit.


text show err

VSCode Version: Code 1.11.1 (d9484d12b38879b7f4cdd1150efeb2fd2c1fbf39, 2017-04-06T13:55:56.395Z)
OS Version: Linux x64 4.4.0-72-generic
Extensions:

Extension
Author
Version

cpptools
ms-vscode
0.10.5

vscode-lua
trixnz
0.4.0

Please try uploading the image again. Also, please provide a description of the problem and steps to reproduce it so that we can investigate


[MV-404] A temporary fix for broken ios screencast

Please test it on some iOS device. This bug is quite non deterministic.
Make sure that the other side is receiving both screencast and video from the camera.

I tried it a few times on iPhone 14 IOS 16.3 and for me it still does not always work. Additionally' I've found another bug related to screencast:

Join the room
Start screencasting
Disconnect without manually stoping screencast
Screencast is broken as ios does not know that we've left the call and notification about screencasting is still present, and another request for screencasting will fail(eg. rejoining the room and triggering screencast).

but it can be fixed later since it's not related to simulcast.


Clean up API Reference section of docs

The API section is pretty messy due to formatting of docstrings that aren't picked up by sphinx.

Remove classes from docs here: https://arosen93.github.io/quacc/user/api/quacc.recipes.dftb.core.html#module-quacc.recipes.dftb.core
Hyperlink to other modules in docstrings like here: https://arosen93.github.io/quacc/user/api/quacc.recipes.dftb.core.relax_job.html#quacc.recipes.dftb.core.relax_job
Fix return description in schemas like here: https://arosen93.github.io/quacc/user/api/quacc.schemas.ase.summarize_run.html#quacc.schemas.ase.summarize_run


Feature/link-shortener

This PR adds:

handlers for both creating short links and extracting data from them
db operations on short links
API docs

Why PostgreSQL and not Redis? it is better to use key-value storage here

What to do with expired links? Are you planning to add the "runner" that will delete expired data?

Also don't forget to add rate limiter and set max request body size when saving link data. It can be done by Nginx configuration

Why PostgreSQL and not Redis? it is better to use key-value storage here

Switching to Redis makes sense here. I'll consider doing this

What to do with expired links? Are you planning to add the "runner" that will delete expired data?

Yep, I already did it in another branch, just didn't push yet

Also don't forget to add rate limiter and set max request body size when saving link data. It can be done by Nginx configuration

Sure, will do
Agree with all the other comments


Remove duplicate

Remove duplicate during queue declaration at cmd/setup/main.go

Remove duplicate during queue declaration at cmd/setup/main.go

👀 👀 👀


git reset --hard

I would like to run git reset commands using the VSCode graphic interface. It seems like every other git operation is available. Without this, then how can a GUI user resolve rewritten history on the remote?
If I pull a branch, and then someone else in the world runs git commit amend && git push --force to my branch so that the hash of the HEAD has changed, does VSCode's git interface offer any way of resolving that? From a terminal I would normally just git fetch && git reset --hard origin/my-branch, but I work with people not comfortable on the command line. It would be great to have a way for them to express to VSCode "abandon what I have without reservation and set my code to the latest remote"

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

For now, you can create your own task:
Go to task.json and add the following:
{
   "tasks": [
               // add this in the tasks
   	{
   		"label": "Rollback",
   		"type": "shell",
   		"command": "git reset --hard ${input:commitHash} ; git push --force"
   	}
   ],
   "inputs": [
   	{
   		"id": "commitHash",
   		"type": "promptString",
   		"description": "Enter the commit hash to rollback to"
   	}
   ]
}


As a user, I want to sort a list of all cities in a specific country, organized by population from largest to smallest so that I can easily identify the most populous cities within the country

SQL:
select city.Name, country.Name as Country, city.District , city.Population  from city inner join country  on city.CountryCode = country.Code
where country.Name  ='%country%'
order by city.Population desc;
Parameters:
%country%

report10.xml added to feature/reports branch


Model save repetition causes threading synchronization issue

Hi everyone,
Short description
I have encountered a problem with saving a model, or rather overriding a saved model. It seems that the problem is somehow connected with threading. Below a paste a source code to reproduce, and logs:
Source code
import tensorflow as tf

path = './checkpoint/model'

model = tf.keras.Sequential([
    tf.keras.layers.Dense(100),
    tf.keras.layers.Dense(100)
])

model(tf.zeros([1, 100]))

checkpoint = tf.train.Checkpoint(model=model)
manager = tf.train.CheckpointManager(checkpoint, directory=path, max_to_keep=5)

manager.save()
print('saved1')
manager.save()  # here an error occurs
print('saved2')

Errors:
The errors I get are (every script execution causes randomly a different error, thus I expect that it's synch issue):
terminate called after throwing an instance of 'std::system_error'
  what():  Invalid argument

or
terminate called after throwing an instance of 'std::system_error'
  what():  Owner **died**

or simply without error but with exit code:
Process finished with exit code 136 (interrupted by signal 8: SIGFPE)

or:
python: ../nptl/pthread_mutex_lock.c:428: __pthread_mutex_lock_full: Assertion `e != ESRCH || !robust' failed.

or
Process finished with exit code 139 (interrupted by signal 11: SIGSEGV)

or:
The futex facility returned an unexpected error code.

System and libraries
The TensorFlow package that I use is compiled by myself in r2.9 version for GPU (RTX 3060 12GB, 8.6 CC, cudnn 8.4, cuda 11.6, GCC 9.3). The CPU is: AMD® Ryzen 9 5950x 16-core processor × 32
TensorFlow compile command:
bazel build --jobs=16 --config=nogcp --config=numa --config=monolithic --config=cuda //tensorflow/tools/pip_package:build_pip_package

Help
Does anyone have any idea what the problem may be? When I compiled tensorflow in a similar way on another computer (laptop) everything works fine.

Hello again, after a couple of TensorFlow recompilations I finally managed to solve the issue (or at least I found a build config that works fine). It seems that --config=monilithic was the source of the problem. After removing that one TF works fine. Below I paste the command for successful compilation:
bazel build --jobs=16 --config=nogcp -c opt --copt=-mavx --copt=-mavx2 --copt=-mfma --copt=-mfpmath=both --copt=-msse4.2 --config=cuda --config=numa //tensorflow/tools/pip_package:build_pip_package

Anyway, it still seems worthful of finding out why a monolithic build (which afaik should disable the possibility for building custom operations only) causes such a strange threading error.

@jbed94 Thank you for the update!
Could you please confirm if this issue is resolved and move this ticket to closed status ?
Thank you!


Option to retain diacritics?

Would you be open to a PR which adds an option, disabled by default, to disable transliteration of diacritics? For my use case I'd strongly prefer that they were all retained, at least in genera and epithets.

@tobymarsden could you post an example of names where you would use this option, and its effect in results?
I guess I could be interested in using it but I don't really understand Go code.

@tobymarsden I would also be interested to understand the usecase, ICZN does not allow diacritics, while in ICN there is a quite obscure permission to use 'é' in some very specific cases.

@dimus @abubelinha
I'm building two related things:

a programmatic interface to multiple "trusted" (but sometimes conflicting!) sources of plant data -- for example, Plants of the World Online, World Flora Online, Red List, CITES.
a system for maintaining data on living botanical collections, which accepts names as input from the user in order to, for example, accession new material and associate it with a taxon and then a name.

For (1), we have two issues:
a) We have some names from a data source such as World Flora Online which contain diaereses, e.g. Hieracium kalsoeënse. The use of diaereses is permitted under the ICN. Transliterating it to e is reasonable as the mark doesn't change the spelling, and this is useful for matching purposes. But leaving it as-is (particularly for display purposes) is also reasonable because a reliable source included it and the ICN allows it. A flag allows the user to make the judgement according to their use case.
b) There are other names such as Anthurium gudiñoi which are not valid under the ICN, but they were still referenced somewhere notable -- in this case, on a type specimen sheet in the herbarium at Missouri. Normalizing the name in every respect other than transliteration would still be useful, though I can't get particularly exercised about it. Similarly with Senecio nordenskjöldii -- there are many more sources which reference Senecio nordenskjoldii than Senecio nordenskjoeldii, so the transliteration to oe doesn't help here when matching names.
The main thing here is that we're working with "trusted" data, not cleaning up junk. When getting names from a somewhat authoritative source, we want to avoid providing an interpretation as far as possible. There may be a few problem names parsed, but that needs to be solved further up the stack, so to speak, and not in our parsing phase.
Use case (2) is similar -- in our system, the user input is to be respected, at least where diaereses are concerned. If they want to refer to names like Hieracium kalsoeënse, that's fine and we need to be able to normalize that without removing the diaeresis, which would be overstepping.
To sum up, I'm ambivalent about having an option to disable transliteration entirely, though this is simplest to implement and there's an argument that it's helpful when dealing with names from normally-reliable sources. However I do really need to be able to retain diaereses from the source data. (We'll actually end up using both -- matching on a version with no diaereses but normalizing for display with the original marks.)

@tobymarsden I think I understood, so yes, lets add the flag.
So in this case you would need to keep diacritics in normalized version, canonical forms (stemmed included), details?

The use of diaereses is permitted under the ICN.

My bad, I did not double check in the code, and trusted memory incorrectly, not 'é' but diaresis 'ë',

@dimus Thanks!
I think it does need to be everywhere, yes.
On reflection I'm thinking that making the option "preserve diaereses" would be more conservative and less of a departure for gnparser as these are referenced in the ICN. More complex of course because it's transliterating everything that doesn't match (I think) [aeiou][ëï] but I could give it a shot and you can see what you think.
I can only find a tiny handful of examples where other diacritics have been used in non-junk names anyway.

There are definietly legacy names with diacritics, and other inconsistencies. For example Algaebase has a few names with capitalized epithets for "patronyms".
One possible solution is to keep diaereses in normalized and canonical full and, may be canonical simple, but remove it from canonical stemmed. Also keep it in detail.
I used to preserve ë for for all parsed names, but it is not compatible with ICZN names

Another complication are names with latinized german words where diaeresis umlaut characters   ö, ä, ü, do suppose to change spelling during transliteration at least by ICZN recommendations


Migrate viewport declaration from govuk_frontend_toolkit

The viewport declarations for Opera and IE used to be defined in govuk_frontend_toolkit. It would be better if that was purely mixins and functions, and it makes sense that these declarations should live in the same place as the meta viewport declaration.
I looked into removing them completely, but there’s conflicting evidence as to what versions of Opera uses them, and at least IE10’s snap mode on desktop needs an @viewport.

Is it worth including something about the purpose of these viewport rules?

Minor comment, otherwise :+1:

That occurred to me last night. I’ll do that today.

In the end it turns out that Opera doesn’t need this any more. Added a comment for the IE requirement.


www: require prefix field on manual assignment

The input field has to be filled in when we are manually adding a new
prefix. Since it shouldn't be entered at all for from-pool or
from-prefix operations we use a conditional ng-required statement that
checks that the allocation method is 'manual'.
Fixes #482.

Didn't know about that, nice solution!


docker: journald log driver

--log-driver=journald in docker.service

https://github.com/resin-os/meta-resin/pull/267

PR is merged.


fix(@schematics/angular): only ngcc in prepare

This fix is to make is so an npm/yarn install with --production mode will not fail as ngcc won't have been installed yet. This allows for workflows with docker and other production build mechanics.

Hi - Can you first open an issue and explain what the use case is? We don't understand under what circumstances you are encountering this issue.

Thank you for the contribution.
The post-install script is no longer present so this change will not be necessary.

While I understand this is no longer needed, to @vikerman the use case is for a build that needs to run a --production npm install first then a full install, this allows for a docker cache to create a layer of just your production values speeding future builds.
example
FROM node:10-alpine as builder
WORKDIR /app

RUN apk add --no-cache --virtual builds-deps build-base python cairo-dev freetype-dev pkgconfig git

ARG NPM_TOKEN

COPY .npmrc yarn.lock package.json ./

COPY build ./build
COPY libs/scss ./libs/scss

RUN npm config set unsafe-perm true
RUN npm i -g @angular/cli

# first set aside prod dependencies so we can copy in to the prod image
# install all dependencies and add source code
RUN yarn install --pure-lockfile
COPY . .

RUN yarn set:version && yarn set:mdi
RUN yarn build:prod:lite

FROM nginx:alpine
WORKDIR /app

RUN apk add --no-cache sed

COPY ./server/nginx.conf /etc/nginx/conf.d/default.conf
COPY ./server/entrypoint.sh /entrypoint.sh
RUN chmod +x /entrypoint.sh

RUN rm -rf /usr/share/nginx/html/*
COPY --from=builder /app/dist/manager-client /usr/share/nginx/html

EXPOSE 80
CMD /entrypoint.sh && nginx -g 'daemon off;'

Just adding this in case you need to run down a similar path in the future.


Add support for more OHM liquidity pools in Sushi and Balancer subgraphs

We are trying to get a complete view of the status of the Olympus protocol liquidity pools. Unfortunately, some of the most relevant pools are currently not captured by the Sushiswap and Balancer subgraphs.
Describe the solution you'd like
Please add the following contracts to the respective subgraphs:
Sushiswap:

SushiSwap OHM V2-DAI Liquidity Pool 0x055475920a8c93CfFb64d039A8205F7AcC7722d3

Balancer:

Balancer V2 OHM-WETH Liquidity Pool  0xd1ec5e215e8148d76f4460e4097fd3d5ae0a3558
Balancer V2 OHM-DAI Liquidity Pool 0x76fcf0e8c7ff37a47a799fa2cd4c13cde0d981c9
Balancer V2 BTRFLY-OHM LP 0x2de32a7c98c3ef6ec79e703500e8ca5b2ec819aa
Balancer V2 Bond-OHM 0xf5f6fb82649df7991054ef796c39da81b93364df
Balancer V2 wETH-FDT Liquidity Pool  0xfb46bc8fc0d06421d362a31b7230f39462efa79a

Describe alternatives you've considered
I have searched for other subgraphs that could hold this data, but I have not found them. I also appreciate standardized schemas, so being able to pull everything from one spot would be ideal.
Thanks!

Hi @EdgeCaser! I am getting queries back from the subgraphs for those pools:

SushiSwap OHM V2-DAI Liquidity Pool 0x055475920a8c93CfFb64d039A8205F7AcC7722d3

All Balancer pools

It looks like for the sushiswap pool it may be because the contract address is not in all lowercase. Also quick note, there was a mispricing for a token pair on that Balancer deployment earlier this week, which cause the TVL to spike. There is a new deployment pending and it doesn't look like it affected any of the pools above, but just incase your using protocol snapshots too.

d'oh! Thanks a lot for the help.
On Fri, Jan 20, 2023 at 9:35 AM bye43 @.***> wrote:

Hi @EdgeCaser https://github.com/EdgeCaser! I am getting queries back
from the subgraphs for those pools:

SushiSwap OHM V2-DAI Liquidity Pool
0x055475920a8c93CfFb64d039A8205F7AcC7722d3
https://api.thegraph.com/subgraphs/name/messari/sushiswap-ethereum/graphql?query={
++liquidityPool+(id%3A+"0x055475920a8c93cffb64d039a8205f7acc7722d3")+{
++++name
++++totalValueLockedUSD
++}
}
All Balancer pools
https://api.thegraph.com/subgraphs/name/messari/balancer-v2-ethereum/graphql?query={
++liquidityPools+(where%3A+{id_in%3A+["0xd1ec5e215e8148d76f4460e4097fd3d5ae0a3558"%2C+"0x76fcf0e8c7ff37a47a799fa2cd4c13cde0d981c9"%2C+"0x2de32a7c98c3ef6ec79e703500e8ca5b2ec819aa"%2C+"0xf5f6fb82649df7991054ef796c39da81b93364df"%2C+"0xfb46bc8fc0d06421d362a31b7230f39462efa79a"]})+{
++++name
++++id
++++totalValueLockedUSD
++++inputTokens+{
++++++name
++++++id
++++++lastPriceUSD
++++}
++}
}
It looks like for the sushiswap pool it may be because the contract
address is not in all lowercase. Also quick note, there was a mispricing
for a token pair on that Balancer deployment earlier this week, which cause
the TVL to spike. There is a new deployment pending and it doesn't look
like it affected any of the pools above, but just incase your using
protocol snapshots too.
—
Reply to this email directly, view it on GitHub
https://github.com/messari/subgraphs/issues/1629#issuecomment-1398725157,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABORUYKUYXHURNMZZCD4GDLWTLEHZANCNFSM6AAAAAAUAP6U64
.
You are receiving this because you were mentioned.Message ID:
@.***>


2024.11.0 Depreciation Warning

The problem
The following depreciation warning was introduced by HA core 2024.11.0:
Logger: homeassistant.core
Source: helpers/deprecation.py:222
First occurred: 05:42:52 (1 occurrences)
Last logged: 05:42:52
Config was used from openevse, this is a deprecated alias which will be removed in HA Core 2025.11. Use homeassistant.core_config.Config instead, please report it to the author of the 'openevse' custom integration
What version of Home Assistant?
2024.11.0
What version of OpenEVSE?
2.1.46
Diagnostics information
No response
Anything in the logs that might be useful for us?
No response
Additional information
No response

This is already fixed in 2.1.47.
Thanks!


Added Known Issues section

I started working on documenting the issues mentioned in #49 and #53. I have added a Known Issues section at the top TOC, and have appended issue #49's details for now.
I would like to tackle #53, and some others but I am not sure how to go about documenting #53. Since you mentioned, you released a temporary fix but need to push it upstream, I am not sure whether it should be documented in the mean-time or not.
What do you reckon?

@dikaiosune - we might want to add a note about needing to use Expo's location apis rather than navigator.geolocation for now. I'll be resolving this sometime over the next few weeks.

@dikaiosune – Thanks for reviewing and responding to my PR!
That's great. If those issues are going to vanish in the next build of CRNA, it'd be irrelevant to document them.
Troubleshooting makes more sense.  It could be useful in the long term as well, as more and more intricacies surface.
I'll issue an undo-commit and start working on the Troubleshooting guide.

@dikaiosune – There was a mix up at my end while reverting the last commit. Should I issue another PR or is this okay? The changes are gone now, though. :confused:

@abhisheksoni27 no worries! Let's close this out and you can submit a fresh PR with the WebStorm info.


Adjusting font?

Is there a way to change what font the code is auto adjusted to on colorize?

Not at the moment.
The font is hardcoded into the sources: https://github.com/floitsch/syntax-addon/blob/master/theme/theme.ts#L88

Theme support would solve this, so I'm closing this issue as a duplicate of #3.

If it's only for the Font support, maybe it could be done in a simpler (?) way, or at least a way that does not require you to support themes (which seems like a lot of work): simply don't replace the initial font of the code when formatting/highlighting code. That way the user is in charge of the font. Would that be easier ?

imho, it is a viable option: let the user decide what font they want. If they didn't change the font to a monospace font, they'll see it soon enough and simply select the code and modify the font, then all subsequent "colorize" command will just use that font they selected. Just mention this in the docs and you're done (or so to speak, I know it's easier said than done)


Alt text hall of fame submissions - January 22, 2022

As a part of the January 22 alt text sprint, the planning team would like to celebrate the hard work of sprint participants by showcasing the best alt text authored during the event!
To add an alt text submission for us to vote on, please include:

Author's name via Github handle (please use @)
The alt text you are submitting (copied over)
A link to where the alt text suggestion was made

Thank you for helping us give recognition to people participating and providing great alt text examples for people to reference in the future!

I said I wouldn't nominate, buuuut since nothing has been written here yet, I will add some proposals!
@ohrely's when an image shouldn't be an image. make image into text suggestion on Jupyter docs PR

@peytondmurray
"In GitHub, the ipywidgets repository page is open. A banner notification at the top of the page is displayed, reading "Okay, that hook was successfully created.""
https://github.com/isabela-pf/jupyter/pull/1/files#r790164519

My submission:
@MarsBarLee
I'm submitting this because it's a more advanced level of alt-text writing. It is an example of providing both short alt-text and long alt-text. In this context, longer alt-text is valuable as short-alt text would be excluding essential information.
File I'm working on: In jupyter repository, in the docs/source/contributing/dev-contributions/contrib_guide.rst
Link to image in documentation

Short alt-text for above image:
'A flow chart with 14 labeled boxes linked by arrows. The chart is uni-directional.  At each step, arrows point forward to one or more boxes and back to the previous box or boxes. Refer to the link above the image for full, long alt-text.'
Link to long alt-text I wrote, hosted on a gist. This link would go above the image. This way, the user can decide between getting a summary with alt-text, and if they want the full alt-text by going to the link.
Below is a snippet of the long alt-text:
1. Start
  1a. forward to 'Find an issue to address'
2. Find an issue to address
  2a. forward to 'Identify the relevant section of the codebase'
3. Identify the relevant section of the codebase
  3a. forward to 'Write simple test cases to verify that your fix or enhancement works.'
...


Header not showing on wallet unlock

There are several problems with the choice of thread to execute the credentials wizard hide and handover operations. It is now running on the EDT which is different to before and will require some investigation to determine what has caused the change.
As a workaround to get the DetailView populating correctly, MainController.hideCredentialsWizard can be edited to remove the EDT wrapper for mainView.reset() around line 1248.

I've put in the fix Gary mentioned into MainController and the DetailView is being shown correctly now when a Trezor wallet is loaded. I'll leave this issue open as it's only a proximal fix.

I've been creating some Trezor wallets from scratch today and have seen this a couple of times.

Fixed. There are some diagnostic debugs that I will leave in the logs for a while until we are sure this is squashed.
Awaiting review and closing.

Verified this is working.
Closing.


Hook this repo up to jenkins

Need to run some hooks on push to make bazel-test (and probably lots more).

closed in #9


Build for Production fails to display Map

Describe the bug
Everything works fine using a standard npm run serve but as soon as I do a npm run build the Map fails to load.
I have hardcoded the API key in the main.js so its not pulling from an env file.
I added a development build script to the package.json = "buildDev": "vue-cli-service build --mode development" and tested the new app.js file it created and it worked.  No CSS was changed so it can only be the Vue CLI build for production which is stopping the map displaying.
So to confirm the Vue is running ok as its pulling data from an API to display a list down the side of the map - its just the Google Map itself which will not display.
Just wondered if you had come across this before.
Thanks

@markbarton
Can you please post a link to a repo where I can reproduce the bug? I can unfortunately not reproduce this bug.

I will close this issue due to no response. Feel free to reopen it, if you still have problems.


1.0.0 version and CHANGELOG

This is a quick first attempt at a 1.0.0 changelog, based on the description of commits to master since the 0.3.0 release.
I skipped changes to documentation, typo fixes and similar "non-functional" things. Please do review and comment if something's missing.

Coverage remained the same at 81.853% when pulling 56da2aa59be0068e08177ea63ba8df5e7d57c1f3 on larsnaesbye:master into dc756d1180ae0fa6c90fe79ee116701e8e240e02 on voxpupuli:master.

@daenney do you have merge access here? i think this is go. once we have that in, we just need to lay tag and push to pypi, we're almost there!

Unfortunately I don't anymore. @bastelfreak Would you mind temporarily re-adding me to tools/python so I can help get this release out? Currently both of the tools/python members appear to be otherwise occupied.

Ah, looks like he's on vacay. @voxpupuli/project-maintainers please?

For some reason I'm still able to do that (lol) and it is done. @daenney

@nibalizer Haha. Awesome. Thanks :heart:

@othalla - if you'd like to review Python code, there's been a request to review the PRs that passed CI. I've only looked at two of them.

For the new release, I think it'd be best if we set up travis to build and deploy tags.  I can create a separate PR to add a suitable travis secret for the voxpupuli.org pypi account etc.  Might not get the time over the (long) weekend though.
@larsnaesbye Thanks for compiling the changelog.  Are you ok waiting a couple of days to get the travis bits setup?

@alexjfisher I sure am. Getting it right is worth waiting for :)

Hi everybody. Our account is now registered as maintainer for the puppetboard and pypuppetdb projects. @mterzo already created a PR to automatically do releases through travis. This needs to be rebased, reviewed and added to the puppetboard project as well. I will do the rebase on pypuppetdb and propose a PR here. It would be nice if one of you could review it. Afterwards we should be able to do a release for both projects.

Hi again. I created https://github.com/voxpupuli/puppetboard/pull/503 to automate releases through travis. Whoever knows some python: please feel free to review.

#503 is merged, so... is this PR the last thing to do before the release?

Not quite, I have a few things I'd like to fix:

[ ] Author in setup.py should be changed to Vox and the Vox mailinglists
[ \ Fix tests on Python 3.7

Changed the author and email address to VP. Also edited the Python versions to match the one we support. It decreased coverage a tiny bit.

Yap, I see. Those calculations are always a bit wonky. Now we just need to get the tests passing. I don't want to release 1.0.0 in 2019 without Python 3.7 support sorted.

In that case, I'll add 3.7 to this too.

@larsnaesbye can you please rebase it?
Should we add CI enhancements to CHANGELOG?
Then we may be ready for the release !

Looks like better now, what do you think @bastelfreak @alexjfisher ?

Yap, seems good. Now all we need is a PR first to fix Python 3.7 tests and then we can merge this.

@daenney looks like it is done https://travis-ci.org/voxpupuli/puppetboard/builds/537735682

In my opinion this is fine now. Do we have a dependency to the latest pypuppetdb pypi? So should we first release pypuppetdb and puppetdb 1.0.0 depends on latest pypuppetdb?

Sounds good. At this point we should bump pypuppetdb to 1.0, it's been long enough. And then have puppetboard 1.0 released depending on that one.

@daenney agreed

So....the Travis build will work when pypuppetdb is out in v.1.0.0, right?

Yes it should.  I will try to have a look in the next days for a pypuppetdb. Any help for an updated changelog there is appreciated.

https://github.com/voxpupuli/pypuppetdb/pull/150 <- there you go!

Hi. I published the pypuppetdb release. I will now try to release puppetboard.


Refactor core/accounts  Remove private key from the Account interface.  Separate out the signing message functionality.  Adds MultiKeyAccount

Description

This is all groundwork refactor for the keyless PR.  I encountered circular dependencies when developing keyless due to accounts being under /core and a lot of packages importing Account.

Moves src/core/account to src/account
Adds MultiKeyAccount class
Removes privateKey from Account interface
Refactors signing message functions

Trying to merge this while Keyless work is ongoing to reduce diff and merge conflicts.
Test Plan

Related Links

I am not completely sure about the motivation for this PR, it feels like a lot of different changes squeezed into one PR. Can we split it into separated PRs for each change?

I could but ultimately am lazy and don't quite have a flow for stacked PRs yet (I should try graphite).  In the future I will do this though.  This PR is already split from the main Keyless PR to be more reviewable.

Also, I can't find justifications for different changes like
return Signature from sign function

Not sure what that is referring to

change signWithAuth to accept only a transaction

Ok, so I need to move the generateSigningMessage logic to accounts.  It used to live here in a function called sign before this PR.  I need to do this because Keyless breaks the assumption of how we normally generate these signing messages.  It does a lot of custom stuff.  But this custom stuff is specific to the context of signing transactions as in the sign function.  I realize now an Authenticator is a (publicKey, signature) pair and can be used outside of a context of signing txns (I confused Authenticator with SignedTransaction).
Perhaps what I want is a separate signTransactionWithAuth where the input is typed as a AnyRawTransaction.  I assume that that's ok.  Will update to do this.

MultiKeySignature rename

This is just for 'correctness'.  I'm happy to not rename.  I'll remove this.


devices: allow using lvm_volumes with devices

Exclude device from lvm_volumes while osd_auto_discovery is true
Sum num_osds on both lvm_volumes and devices list
Exclude lvm_volumes defined disks from existing osds while it has been counted by the "count number of osds for lvm scenario" task.

jenkins test centos-non_container-lvm_batch

@guits These failures don't look like be related to the change 🤔

ping @guits @asm0deuz

@clwluvw Hi! I am waiting for this https://github.com/ceph/ceph/pull/50413 to be merged before re-running your tests otherwise some tests might fail.

jenkins test centos-non_container-lvm_batch

jenkins test centos-non_container-lvm_osds

the osd_auto_discovery 'feature' should be dropped IMHO 😛

rm -rf ceph-ansible 🚶♂


Implement Persistent Volumes

This pull request is a continuation of the work already done on the persistent-volumes branch to implement persistent volumes as per #2438.
Summary:

the scheduler syncs volumes from all hosts and persists them to the volumes and job_volumes tables in the controller database
when placing a job which requires volumes, the scheduler first tries to locate existing, unassigned volumes for the job's app / release / type and the volume's path, and if it finds one then places the job on the same host as the volume whilst also assigning the volume to the job (i.e. setting Volume.JobID)
volumes can be "decommissioned" via flynn volume decommission ID which causes the volume to not be attached to any new jobs
if a host which has unassigned volumes is down, jobs are still scheduled on that host but enter a new blocked state waiting for either the host to come back up or the volume to be decommissioned. This then means if a host is rebooted which has data for a process type, the job just stays down until the host comes back rather than being restarted on a different host with an empty volume, but if the host has really gone away then it is up to the operator to decommission the volume and unblock the job to be scheduled on a different host

Things which need to be considered but not included in this PR:

volumes won't be persisted through deployments, but the design allows for that to be added later (see this comment)
we should add flynn volume backup and flynn volume restore so that if a host is lost and volumes need to be decommissioned in order to move jobs to other hosts, operators can first restore volumes so that the unblocked job doesn't have to start with a completely empty volume

@titanous comments addressed.


Start Read me

Tertiary Goal after wireframes You can find detailed read mes that meet a high quality .

Issue upgraded to completing read me


Text Formatting

Under the "See also" section, "reference" is not capitalized.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b02cc636-50ed-7c7f-0695-f9700450dbe1
Version Independent ID: adcd6a17-c683-1860-4aa7-0e4ce2acf00b
Content: Overview - Visual Studio Live Share - Visual Studio Live Share
Content Source: docs/index.md
Product: visual-studio-family
Technology: live-share
GitHub Login: @fubaduba
Microsoft Alias: fubaduba

Hello @anphonic, sorry about the issue you noticed with the text formatting. Can you clarify exactly where you noticed the issue in the Live Share extension?

Hi, it's actually with the Microsoft doc's page for live share, at the
bottom the word reference isn't capitalized in line the rest of the
formatting.
On Wed, Dec 2, 2020, 9:19 AM alyssajotice<EMAIL_ADDRESS>wrote:

Hello @anphonic https://github.com/anphonic, sorry about the issue you
noticed with the text formatting. Can you clarify exactly where you noticed
the issue in the Live Share extension?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/live-share/issues/3997#issuecomment-737297032,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHP2J2UOJGXSA5OSSYNL3DSSZLJJANCNFSM4UJGXZEA
.

This has been resolved. Thanks!


Can't join quiz

Hi! Thanks for this repo. It seems as if I have set it up succesfully, but I am unable to join a quiz. :(
I managed to get the webapp deployed at https://squizzy-sepia.now.sh/. However, I cannot access https://squizzy-sepia.now.sh/studio (does that indicate something is wrong?) as suggested by the readme, but I can access the studio via https://wouter.sanity.studio/ and create a quiz and play it.
However, if I go to the suggested link to join the quiz: https://squizzy-sepia.now.sh/match/9150a I get 'match cannot be found'. I can verify in the developer console that an XHR requests succeeds and it also seems to return a question so it seems an issue in the front-end. Do you have any suggestion how I can fix this?
Thanks!

Same issue here.

I have this issue as well. Is there a way around this error?

I managed to get it to work by making the dataset public in sanity... but I am not sure if it should be public?

Mine is on public. I can see that XHR request your talking about. But with me it's failing. It gets an CORS error. I did however follow the last stap: sanity cors add https://your-name.now.sh --no-credentials And it did add a cors setting. Did you add the cors step manual or with the cli?

Dears, in my case the projectID in ./sanityClientConfig.js was wrong. I confused my userID with the projectID and that's why it was not working. So no bug at all in the code. Now it's working fine.

Mine is on public. I can see that XHR request your talking about. But with me it's failing. It gets an CORS error. I did however follow the last stap: sanity cors add https://your-name.now.sh --no-credentials And it did add a cors setting. Did you add the cors step manual or with the cli?

I don't remember exactly t.b.h. ... I tried to follow the instructions carefully but I also added and removed again some settings manually. I found however that different domains where created (probably since project name squizzy was already taken), so you might need to play around a bit with that.


Update SuspendExcNodes to include nodes with KeepAlive=true

When we generate or regenerate the slurm.conf, we should add SuspendExcHosts= a node list of all nodes where KeepAlive is true in CycleCloud.

Hi @ryanhamel
I'm wondering if SuspendExecHosts is sufficient in a Slurm only configuration.
What's the benefit of having CycleCloud KeepAlive in addition?
Could KeepAlive=true be set only for few VMs within a nodearray?

this is done.


Adding default_keyspace_rf and minimum_keyspace_rf configuration options

Patch by Sumanth Pasupuleti; reviewed by Jaydeepkumar Chovatia and Alex Petrov for CASSANDRA-14557.
PR raised to simplify management of review comments.

Merged with https://github.com/apache/cassandra/commit/5fdadb25f95099b8945d9d9ee11d3e380d3867f4.


Awake DestroyObject with condition?

  protected virtual void Awake()
    {
        if (instance == null)
        {
            instance = this as T;
            DontDestroyOnLoad(gameObject);
        }
        else if (instance != this)
        {
            //If there is already an instance of this class, destroy the object we just created.
            Debug.LogWarning("Attempted to spawn more then one singleton object. destroying new instance of " + gameObject.ToString() + "\nIf you would like more than one instance, ensure that the class you have written does not Inherit from a Singleton class.");
            Destroy(gameObject);
        }
    }

I found another snippet from Naphier which the instance!=this make sense when destroy it.
Could you please explain it why you didn't add condition? Thanks.

Hi.
That's the same, which condition do you mean?
As I see, both scripts work the same way.
Thanks.

Sorry for wasting your time as a unity novice. I thought awake will be invoked when the gameobject is enabled. I didn't realize it will be only invoked once during its lifetime.

Ah, no problem, that's my pleasure.


docs(config): add stats option outputPath

Append stats option outputPath
https://github.com/webpack/webpack/blob/master/lib/Stats.js#L214-L217

This PR is stale. I close it

Hi @terrierscript if we cannot find out default value now, let's change it to outputPath: bool and merge. Someone can improve it later

@EugeneHlushko Sorry, I haven't time to fix this.

Thanks!


Improve WSL 2 docs

Proposed changes

described that having additional Linux distros is recommended, but is not a pre-req. I've split the Install section into 2: the basic install which is all you need for docker to work on Windows; and a separate section on enabling it for user Linux distros since that's optional (but recommended)
added a note describing that the built-in distros docker-desktop and docker-desktop-data are implementation details and not suitable for general use.
re-ordered the page slightly so now it's: why do I want this, the pre-reqs, download link, install steps and then best-practices. Previously the best-practices were before the download which was (IMHO) too early, we'd like to help the user get installed first + not make it look too complicated
removed references to a very old Docker Desktop <IP_ADDRESS> (but the link was to latest, which is fine)
fixed a reference to "running natively without emulation" to "run without having to manage Virtual Machines" <- before WSL 2 the state of the art was to run Hyper-V VMs yourself; with WSL 2 there is a VM which Windows manages automatically

Related issues (optional)

@aevesdocker Coud you PTAL?


How to use apollo client on the server? How to deal with explicit whatwg-fetch require?

I was reading over #645. The issue is discussing how to appropriately change createNetworkInterface so that it works, out of the box, on node.js. The issue being that the networkInterface.ts file has a hard dependency on the browser-only whatwg-fetch.
Because that file still depends on that module, how have folks been doing server rendering so far? I'm trying to determine the best way to approach this.
We cannot simply include our own fetch implementation, because networkInterface.ts will always depend on whatwg-fetch. Are folks using webpack to resolve this to perhaps node-fetch on their server build? Is there a third party network interface that somebody has provided that uses a universal fetch module, instead?
What are the options? Thanks.

What's the problem you are experiencing? Does simply also importing node-fetch not work? That's what we do in our SSR example as far as I know.

Hmm. I think I see why this would work, actually. It looks like whatwg-fetch doesn't do anything if a global fetch already exists. So, importing node-fetch before-hand should fix the fetch is undefined issue with just whatwg-fetch.
I'll try that!

Yeah I think the polyfill situation is quite confusing, we're thinking of possibly removing all the polyfills for 1.0 and asking people to import the ones they want. On the other hand, it's nice that things "just work" on the client.

@stubailo It's just a bit unintuitive in node, because you don't typically deal with globals. So seeing a require("whatwg-fetch") doesn't immedietly convey that if a global fetch already exists then that require basically does nothing. In the browser though that is a bit more intuitive.
After realizing this, I think the way it currently is is actually quite nice. The client will work in the browser out of the box, which is likely to cover most people's initial experiences with the apollo client. If we need (or want) to bring our own global fetch, which we will need to in a node environment, then we are currently free to choose any of the available libs that we like. It's the most flexible of both worlds, imo.
An additional note in the docs about how whatwg-fetch works might make this clearer. Perhaps on the server rendering section somewhere.
In my case, I just made an incorrect assumption about how whatwg-fetch worked. If I had just imported my own fetch polyfill without thinking, it'd have worked. shrug

Yeah, it's a general issue with polyfills - they change something about the environment rather than actually exporting a function that is used.


Add ignored_models as config option

This makes it easier for the IDE to refactor those classes when needed. And it makes it easier to add multiple models with long namespaces.

Hey @mfn, any idea when you can check this one? Thanks!

@pataar looks good to me!
Personally would be great to have a test. Right now that area if "ignore classes" has none at all. Could be a good opportunity to start them with this…

@mfn I added a test :)

@pataar Nice :-)
From my side very much appreciated!
@barryvdh LGTM!

Thanks for checking and merging!


Dockerize gh-openapi-docs

For those working in non-ci environments (i.e. local dev), it will be helpful to have gh-openapi-docs as a docker image/app so that developers don't have to configure node and npm. Also, a dockerized app will be helpful when the ci environment isn't node + npm based for whatever reason.
@briandoconnor

This should also involve changes to the CI so that when we do releases, the app is released to:

Github releases
NPM
Dockerhub (under ga4gh namespace)


Isolating forces to a subset of nodes?

E.g., http://bl.ocks.org/mbostock/b1f0ee970299756bc12d60aedf53c13b
It works with some forces, but not d3.forceCollide and not d3.forceManyBody because these rely on node.index. We should probably rewrite the forces so that they can be bound to a subset of nodes.

Specifically, they should not assume that nodes[i].index === i. For example, in d3.forceCollide, you’d probably need to replace
if (data.index > i) {

with
if (data.index > node.index) {

And initialize the radii a bit differently:
var i, n = nodes.length, node;
radii = new Array(n);
for (i = 0; i < n; ++i) node = nodes[i], radii[node.index] = +radius(node, i, nodes);

Note that this means that radii would be a sparse array, which could be inefficient if you have a lot of forces and a lot of nodes. An alternative would be to have a second index that maps from node.index to an index in a dense radii array that is the same size as nodes. But that feels like it would be slower in the more common case where the force is operating on all the simulation’s nodes.

/cc @esjewett

Looks like d3.forceLink is still broken because count[i] uses a mix of local index and node.index.

I should mention there’s little practical reason to isolate nodes on d3.forceLink since you can already isolate it by links… but at any rate, I’ve fixed it.


Admin Theme - Spacing between fieldsets

Many pages are almost touching:

I haven't thoroughly tested the PR fix, I've just added a 20px margin on the bottom to fieldset. It seems to space things out nicely and it blends nicely with the some of the markup which uses fieldset class="form-group" (does the same so the margins just match with or without).
Please keep an eye out for any display glitches this fix might cause.


[FEATURE] Account Lock Handler using function library

Is your feature request related to a problem? Please describe.
More customizable account lock logic using the functional libraries. Currently, we need to add java code Extention to customize the account lock behaviour.
Describe the solution you would prefer
We use our function library, and make a predefined function library "AccountLockHandler". Then with a new Java extension can we execute that function?
This way, we can give flexibility to the identity developer to develop their own Account lock logic.
Additional context
This is the next level use cases we planned for the functional library. But It could be great if we divide the functions library into two with this feature to avoid confusion. One set of functions for the adaptive functions and other for the server function.
Also, we need to decide on how much we are going to allow to be controlled in the function library. We can allow all the logic to the function library because of the account lock implementation based on the claim values. Or we can allow only the decision logic for the account lock to the function and maintain the claim update in the java.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Renaming the site_name parameter

Describe the solution you'd like

The name site_name is not representative of the different sections of a config file. It seems to represent alternate reddit sites.
I propose renaming site_name to something more descriptive, like section_name, or config_section_name, although the second one is a bit wordy.

Assuming you mean this.
As covered in documentation of praw.ini, the file allows you to actually configure PRAW to connect to some other instance of Reddit (such as if someone ran the archived open-source version) or access it through a different URL. While this use-case may not be common, it means that the site_name parameter can indeed be used to select an "alternate reddit site."
ConfigParser uses the name section, which may be more appropriate in general than site_name, especially considering that praw.ini files are, for the most part, used for configuring authentication information.
On balance, however, I think that the impact of the breaking change of renaming an argument in the initializer of the main class of this entire project is not worth the benefit of having a slightly nicer name.

@bboe Can I get your opinion on this? I think we can introduce the change in PRAW 8.0, as this release already has way too many breaking changes.

I'm okay with this change assuming there is a deprecation period first.

I'll introduce the deprecation period in 7.0, and remove in 8.0.


Messages:   chopping off text while justifying, not using full screen space, FIX

Got sent a 6 digit pass code from Amazon.  Only the last 3 digits could be read.
Would take a screenshot but as soon as disconnect gadgetbrudge the bangle says no more messages.
I will try a photo next time.

OK this is a bit more complicated.  There is a general issue with justifying the text into lines.  Here are a couple of examples. Apologies about the poor quality of the photo's.  1) In the first example the bulk of the text is split onto the first line but then the start and end of the first line are clipped off the end.    This example was created using the Android GadgetBridge debug facility to send a message.  2) in the second example I got an email pop up.  The text is rendered only using the inner half of the screen across 4 lines.

In the 2nd screenshow above the text is:
"Testing and the beanstalk the same time and hear the tragic news"
What is seen is:
"ting and the beanstalk the same t
and hear the tragic news"

ok - worked out a fix.  We need to set the font to the font that will be used to display the body of the text before calling g.wrapString();
g.setFont(fontMedium);
lines = g.wrapString(msg.body, g.getWidth()-10);

Great - thanks for sorting this! I must not have seen it because I only tested when the title was long so the title font was small


AVD Alerts Bug: Deployment Script Fails on Host Pool using Private Link

My customer receives an "Authorization Failure" since their host pool is not publicly accessible and hidden behind the private link service.
This solution will most likely need to deploy a VM in the VNET / Subnet containing the endpoint for the host pool to collect the required data, instead of using a deployment script.

Great point as this will impact the upcoming Private Link options for Host Pools.  This sounds like we may need to request the PG to provide an option for deployment scripts to include network settings for the container and/or possibly utilize a Server OS or alternate VM to run the script from a trusted VNet/subnet.  Additional testing and plans to add this coming.

Waiting to confirm but should be fixed with v2.1.0.


Add "send signal" button to debug toolbar

I would like for there to be standardised support for simulating (for example) pressing CTRLC to programs running in the debugger.  I appreciate that...

CTRLC is probably bound to a clipboard copy action
the implementation of CTRLC is OS-specifiic (SIGINT vs GenerateConsoleCtrlEvent)
integration with the Debug Console is probably language-specific (I am assuming)

I don't know how feasible this is (and maybe overthinking it) but, if it is feasible, a potentially-reasonable approach might be to offer a split-button in the Debug toolbar (i.e. the one that comes up when debugging, with the Play, Pause, Step, Stop, etc. buttons), that provides a drop-down of valid signals (for the OS); and sends whatever message/event trigger exists to the debugger, so that the language provider can do the last-hop (e.g. sending POSIX SIGINT, or calling Win32 GenerateConsoleCtrlEvent).
I do have a short-term workaround -- at least, one that works when I am writing Go code on my Linux machine (for example): I can run pkill -INT __debug_bin in the Terminal view (since debugging go programs are typically compiled to a __debug_bin for running).  However, I can't do the same when I am on my Windows machine (e.g. taskkill /im __debug_bin) because it requires taskkill /f, which is a "harder" kill than CTRLC seems to be.  I also don't expect all languages use __debug_bin as their debug build target, so there would need to be a way for those providers to supply the right image name (or PID, dwProcessGroupId, etc.).
Standardising a button in the UI might eventually allow for the best all-round user experience, and would at least offer a jump-off point for implementers (rather than them all coming up with their own approaches).

VS Code debuggers already support to send CTRL to debuggees.
If a debug extension has opted into the Terminate request, VS Code will send a Terminate to the debug adapter if the "Stop" is executed. Debug extension are expected to implement the Terminate request by sending a SIGINT to the debuggee which gives it a chance to clean up and terminate properly. If the debuggee doesn't react on SIGINT by terminate itself, executing "Stop" another time will terminate the debuggee forcefully.
VS Code's builtin JavaScript debugger supports this behavior (besides others).

@weinand - thanks for looking, but I wonder if this has been closed a little too quickly.  This wasn't a bug or problem with a cause, but a feature request I wanted for VSCode (I did use the Feature Request template, but it might not be clear enough).
From what you are saying, I now understand that the Stop button triggers a Terminate request, and that the debug implementers can subscribe to receive this request, so as to perform cleanup before ending the debug session.  That they are cleaning up their debugger, without necessarily forwarding the SIGINT onto my program, may indeed be construed as a bug/problem in their implementation.
However, what I am asking is for a standardised way to inform the debug implementation of arbitrary, platform-independent signals (including SIGINT), e.g. a Signal request, which the debug implementers can also opt into, with the intention of simulating the receipt of these signals during a debug session without stopping that debug session.  Sending CTRLC is only an example (albeit a tangible one), there are many other events that might be of interest to a program, that are also interesting to the debugger implementation, and this would allow us to differentiate between the two.
A use case is for those of us who want to debug our own programs which themselves handle these signals.  Using my own experiences with the Go provider as an example, pressing Stop terminates the debug session.  Any breakpoints placed in my Go code during or after the signal, ok := <- signals line in my code are never reached, because the Go provider has torn down the debug session already.  I appreciate that this specific example might be an issue with the Go provider's current implementation of the Terminate handler, and realise that doing the right thing with regards to a new Signal event is also the responsibility of the Go language implementer.
(I could also see use case for sending Windows messages, such as WM_SETTINGCHANGE, without having to actually alter one's system settings, for example.)
My feature request is to standardise an interface for those signals (both API and UI), so one can go to the language providers and ask them to implement the Signal event for their debugger.
(Unless, of course, it is trivial for a language provider to add their own button to the debug toolbar, and handle it by sending SIGINT without terminating the debugger...?)

It seems I was not successful in bringing the idea of the Terminate request across:
The sole purpose of the Terminate request is to send whatever is necessary to the debuggee (the program being debugged) so that it can do what it needs to do. This might include to shut down itself (the debuggee) gracefully. That's the reason why the request is call "terminate". But the debuggee could do something else (and not shut down itself).
The purpose of the Terminate request is not to cleanup the debugger or terminate the debug session. The debug session is only terminated if the debuggee decides to "exit" (for whatever reason, including receipt of the Terminate request).
So Terminate is basically an abstraction on top of the "SIGINT" signal (or the corresponding Windows equivalent). We have to use an abstraction because "signals" and "processes" are not something the VS Code debugger knows about. So VS Code cannot provide a UI to send arbitrary signals to processes because it knows neither.
If you need a mechanism to send arbitrary signals to Go processes, then the Go extension can provide the UI for it. On the level of Go you know that there processes.


Created arrow tool

Working on a project right now that uses react-sketch but I needed an arrow tool. Wrote one into the library, thought it would be good to send as a pull request as I'm sure others might find it handy as well! The tool starts as a line and then generates the head after the mouse button is released. Added it to the example demo if you want to have a play around with it.

Just modified the tool to show the arrowhead when dragging, which is a little more intuitive.


Add decadal temp/precip charts that display historical range alongside projected means using new taspr endpoint

Closes #19.
Closes #52.
Closes #68.
Closes #77.
This PR replaces the previous (hidden) iteration of the temp/precip charts. The new charts show the historical data as a box plot, and decadal projected data as single points. A season selector radio button menu has also been implemented above the charts.
Test this PR against the iem_taspr_2km branch of the data-api. These charts use data from the new taspr endpoint, which provides data from CRU TS 4.0 from 1950-2009 as the historical baseline instead of CRU TS 3.1 data from 1910-2009. Some historical values differ considerably vs. the previous historical baseline, with affects many of the difference calculations throughout the report. Compare the before & after differences to the Fairbanks report for example.
JavaScript code has also been added to combine and average decades 2040-2069 and 2070-2099 for use with the temp/precip tables. These combined decade values had been provided through the API's iem endpoint previously, but adding client code to do this allows us to keep the new taspr API endpoint clean and application agnostic, so it seems reasonable to do these calculations in the web app itself.

This PR is in a good state to be merged. The remaining issues from the checklist above have been captured as GitHub issues.


cmd/bosun: add complete influx cred config, docs: update docs to reflect new config

Adds configuration so that you can connect to InfluxDB with TLS and/or a username and password.

LGTM.
Compiled an ran it locally with no changes to bosun/influxdb settings and it still works as expected. Changed /etc/opt/influxdb/influxdb.conf to use auth-enabled = true under the http section, used /opt/influxdb/influx to create a user for bosun, and added the following settings to the bosun config file
[root@gbcentos7 influxdb]# head /home/gbray/go/src/bosun.org/cmd/bosun/gbcentos7.conf
tsdbHost = gbcentos7:4242
influxHost = gbcentos7:8086
influxUsername = bosun
influxPassword = bosun
graphiteHost = gbcentos7:81
smtpHost = gbcentos7:25
emailFrom = bosun@localhost
httpListen = :80
timeAndDate = 202,75,179,136
stateFile = /home/gbray/go/src/bosun.org/cmd/bosun.state

After restarting bosun and influxdb the influx("opentsdb",'''SELECT value from "os.mem.percent_free" group by host''',"5m","") expression still works as expected.


Re-add AutoMerge

In the dependabot preview there was an option to automatically merge the pr, why has this option been removed?

Closing as a dupe of #1973, which has the information you seek.


PaperPatch blocks building up

Describe the bug, provide any errors
PaperPatch blocks building up. It messes when someone is building a bridge too. It works better when class looks like this, but I'm sure it can be done better: https://pastebin.com/raw/8Qu7u4UG
How can we reproduce it?
Start building up or making a bridge while shifting on 1.12 for example.
Expected behaviour
Building up and making a bridge should work perfect.
Screenshots
ViaVersion Dump:
https://pastebin.com/raw/FcyAMvaK
Additional server info
BungeeCord

@MylesIsCool how to edit paper source code to fix that?

@MylesIsCool how to edit paper source code to fix that?

You'd need to apply that patch, on the specific way to do it you'd have to find that out yourself (mainly because I'm not versed with modifying paper / porting patches)


Docs: Order of elements

Amazing module!
With some things I wonder what order is correct or if it matters at all. Could you add this informations to the docs maybe?

<Tailwind> goes around <Html> or inside?
<Preview> should be placed within <Html> or outside or doesnt it matter at all?

tailwind has to be inside of the Html component
preview should be inside of html as well

the order doesnt really matter in most cases, but to build an email template, you must follow these rules, as shown in these examples https://demo.react.email/preview/notifications/vercel-invite-user?view=source
html the parent wrapper, then content goes inside it


Update README.md

Added the requirement and instructions for installing node as well
This solves #146

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

can you also specify node version has to be larger or equal to 18.15.0?


Add String to boundariesElement prop allowed types

Hi there! This is just a simple fix for #79. Popper.js allows either a string or an element for this. Please let me know if this PR needs anything else.

Looks like this has also been raised in #121.

Thanks! :+1:


Impl Parser for more types in arrow_array::types

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The Parser has been impled for these arrow_array::types:
https://docs.rs/arrow-cast/33.0.0/arrow_cast/parse/trait.Parser.html#foreign-impls
Maybe we could impl Parser for more types, eg Decimal128 and Decimal256 and so on.
Uniformly resolving the type interface can reduce much code.
Describe the solution you'd like

Impl Parser for the types in https://docs.rs/arrow-array/33.0.0/arrow_array/types/index.html
Describe alternatives you've considered

This may be required to add more methods to Parser.
For example, to impl Parser for Decinal we should add this:
pub trait Parser: ArrowPrimitiveType {
    fn parse(string: &str) -> Option<Self::Native>;

    fn parse_formatted(string: &str, _format: &str) -> Option<Self::Native> {
        Self::parse(string)
    }

    /// add for Parse Decimal
    fn parse_with_parameter(string: &str, _precision: u8, _scale: i8) -> Option<Self::Native> {
        Self::parse(string)
    }
}

Or consider making the parse function receive arbitrary arguments so that it can only need itself by Parser?
Additional context

I think the parsing code would benefit from a more holistic rework, perhaps using #3647 as inspiration, I can add it to my list to write up a proper ticket for this


Weld Constraint Specified with Sites Not Working in MJX

Intro
Hi!
I am a PhD student at UC Berkeley, I use MuJoCo for my research on humanoid whole-body control.
My setup
Mujoco 3.2.4, MJX 3.2.3, Python 3.10, Ubuntu 22.04
What's happening? What did you expect?
Weld equality in Mujoco can be specified with either body1 and body2 or site1 and site2. However, specifying with site is not working in MJX.
Steps for reproduction

Load the model below.
Run the model with Mujoco python3 -m mujoco.viewer --mjcf=test.xml. Drag around the cube and the sphere will follow.
Run the model with MJX mjx-viewer  --mjcf=test.xml. The sphere falls to the ground although constrained by the weld joint.
Comment out the weld constraint specified with site and enable the weld constraint specified with body. Now it works properly in MJX.

Minimal model for reproduction
<mujoco model="test">
  <statistic center="0 0 1" extent="1.8"/>

  <option iterations="2" ls_iterations="5" gravity="0.0 0.0 -9.81">
    <flag eulerdamp="disable" />
  </option>

  <visual>
    <headlight diffuse="0.6 0.6 0.6" ambient="0.3 0.3 0.3" specular="0 0 0"/>
    <rgba haze="0.15 0.25 0.35 1"/>
    <global azimuth="160" elevation="-20"/>
  </visual>

  <asset>
    <texture type="skybox" builtin="gradient" rgb1="0.3 0.5 0.7" rgb2="0 0 0" width="512" height="3072"/>
    <texture type="2d" name="groundplane" builtin="checker" mark="edge" rgb1="0.2 0.3 0.4" rgb2="0.1 0.2 0.3"
      markrgb="0.8 0.8 0.8" width="300" height="300"/>
    <material name="groundplane" texture="groundplane" texuniform="true" texrepeat="5 5" reflectance="0.2"/>
  </asset>

  <worldbody>
    <!-- Lighting and ground plane -->
    <light pos="0 0 3.5" dir="0 0 -1" directional="true"/>
    <geom name="floor" size="0 0 0.05" type="plane" material="groundplane"/>

    <body name="cube1" pos="0 0 1">
      <!-- Joints allowing movement in x, y and rotation around z -->
      <joint name="cube1_x" type="slide" axis="1 0 0" limited="false"/>
      <joint name="cube1_y" type="slide" axis="0 1 0" limited="false"/>
      <joint name="cube1_rot" type="hinge" axis="0 0 1" limited="false"/>
      <inertial pos="0 0 0" quat="1 0 0 0" mass="1" diaginertia="1 1 1"/>
      <geom name="cube1_geom" type="box" size="0.1 0.1 0.1" contype="0" conaffinity="0" rgba="0.9 0.9 0.9 0.5"/>
      <site name="cube1_site" pos="0 0 0"/>
    </body>

    <body name="sphere1" pos="0 0 1">
      <geom name="sphere1_geom" type="sphere" size="0.05" contype="0" conaffinity="1" rgba="0.9 0.0 0.0 0.5"/>
      <inertial pos="0 0 0" quat="1 0 0 0" mass="1" diaginertia="1 1 1"/>
      <site name="sphere1_site" pos="0 0 0"/>
      <freejoint/>
    </body>
  </worldbody>

  <!-- weld with body works but weld with site fails -->
  <equality>
    <weld torquescale="1" solref="0.1 1" solimp="0.1 0.1 0.1" site1="cube1_site" site2="sphere1_site"/>
    <!-- <weld torquescale="1" solref="0.1 1" solimp="0.1 0.1 0.1" body1="cube1" body2="sphere1"/> -->
  </equality>

</mujoco>

Code required for reproduction
No response
Confirmations

[X] I searched the latest documentation thoroughly before posting.
[X] I searched previous Issues and Discussions, I am certain this has not been raised before.

Please try MJX version 3.2.4 for this feature.

Thanks! works now in 3.2.4.


Foxiy/evaluating methods

Added function for evaluating how good we can extract table from video or
image

Added function for evaluating how good are our compare functions

toolkit.py - Added pHash comparison of images if similarity is under
some threshold it writes into metadata that we should make
slide in near vicinity of this frame

@Foxiy One interesting metric I miss here is accuracy. Would it be possible to add it? Otherwise it looks good from high level perspective.