OOM playing some HLS VOD videos, and LoadControl receiving bufferedDurationUs  = 0 allways

Version
Media3 1.1.1
More version details
No response
Devices that reproduce the issue
In all devices tested:

Wed HDX2 Camera.
One Plus 9 Pro.
Pixel 4.

Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Yes
Reproduction steps

Start playing a URL that had a master like the one attached in details.
Wait few seconds.
FAILURE: You can see the memory usage being increased a lot. And some messages about GC and "Target buffer size reached with less than 500ms of buffered media data." Eventually, it will show OOM messages as well.
Note: in shouldContinueLoading() method of DefaultLoadControl is arriving bufferedDurationUs as 0, and no matter the result this function passes memory usage continue growing.

Expected result
The playback continues without taking all the heap size and without OOM messages.
Actual result
The playback continues but it takes the full heap size and in the logcat you can se a lot of messages appearing like this sample:
2023-11-15 13:08:08.626  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.636  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.647  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.651  4890-4901  ote.airplaydem          com.demo.demoexo          I  Clamp target GC heap from 535MB to 512MB
2023-11-15 13:08:08.658  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.667  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.677  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.687  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.691  4890-4901  ote.airplaydem          com.demo.demoexo          I  Clamp target GC heap from 535MB to 512MB
2023-11-15 13:08:08.697  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.708  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.718  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.728  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.737  4890-4901  ote.airplaydem          com.demo.demoexo          I  Clamp target GC heap from 535MB to 512MB
2023-11-15 13:08:08.739  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.749  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.759  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.769  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.779  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.787  4890-4901  ote.airplaydem          com.demo.demoexo          I  Clamp target GC heap from 535MB to 512MB
2023-11-15 13:08:08.789  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.799  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.809  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.819  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.829  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.830  4890-4901  ote.airplaydem          com.demo.demoexo          I  Clamp target GC heap from 535MB to 512MB
2023-11-15 13:08:08.840  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.850  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.860  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.871  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.879  4890-4901  ote.airplaydem          com.demo.demoexo          I  Clamp target GC heap from 535MB to 512MB
2023-11-15 13:08:08.880  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.891  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.900  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.911  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.
2023-11-15 13:08:08.921  4890-5395  DefaultLoadControl      com.demo.demoexo          W  Target buffer size reached with less than 500ms of buffered media data.

Media
This is a sample of master.m3u8 that's reproducing when the issue happens and the chunk list of the both media includes in master.
master.m3u8.txt
mediadata.m3u8.234.txt
mediadata.m3u8.312.txt
Bug Report

[ ] You will email the zip file produced by adb bugreport to<EMAIL_ADDRESS>after filing this issue.

Checked that it still happens on 1.2.0 recently released version

This is a sample dump from video and audio tracks that these type of HLS VOD videos has: https://file.io/EHFIVNrJmcdg
I can see this on format, at createExtractor():

Video: Format(0, null, application/x-mpegURL, null, avc1.64002A,mp4a.40.2, 7970206, null, [1920, 1080, 60.0, null], [-1, -1])
Audio: Format(234:Default, Default, application/x-mpegURL, audio/mp4a-latm, mp4a.40.2, -1, null, [-1, -1, -1.0, null], [-1, -1])

It may be related to #2055 of Exoplayer as per chunk size.. The problem is that the chunks are created by youtube and I've not control over its size..

The problem was the links for the chunks, are badly composed and it ends having all of them pointing to the full video.. creating the issue...


fix REPL crash involving pattern bindings to expressions with closures

Problem
When you have a pattern binding expression in the REPL that binds a tuple to an expression involving a closure (see tests in this PR for examples), you get this assertion failure:
swift-ide-test: /usr/local/google/home/marcrasi/swift-base-master/swift/lib/Sema/TypeCheckConstraints.cpp:1342: bool (anonymous namespace)::PreCheckExpression::walkToClosureExprPre(swift::ClosureExpr *): Assertion `(closure->getParent() == DC || closure->getParent()->isChildContextOf(DC)) && "Decl context isn't correct"' failed.

Explanation
The REPL rewrites the pattern binding. The rewrite introduces a new PatternBindingInitializer DeclContext that contains the initializer expression, but the rewrite does not update the closures in the initializer expression to set their parents to the new DeclContext.
This PR's solution
Update the closures in the initializer expression to set their parents to the new DeclContext.

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 6be272e38acc60e2599e6451e299009334ff8198

@swift-ci please smoke test

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 6be272e38acc60e2599e6451e299009334ff8198

Build failed
Swift Test Linux Platform
Git Sha - 6be272e38acc60e2599e6451e299009334ff8198

@swift-ci please test windows platform

@swift-ci please test Windows platform

@swift-ci please test Windows platform

https://dev.azure.com/compnerd/swift-build/_build/results?buildId=25719&view=results

Looks like it passed on windows. Yay!

@DougGregor you touched the failing assertion recently (79c57067020d7dcadcf4daf8b7c76d2ab9e136b0) (though your change isn't what introduced this failure), so maybe you know enough about this to review or suggest someone who does?

Can one of the admins verify this patch?

In general, if the REPL is doing something it is probably wrong for the rest of the compiler to be doing it...
I think we should fix the REPL checker's contextualization of these closures. If we can wipe that code out, or at least get it to use a more modern solution like ContextualizeClosures or RecontextualizeClosures (of course we have two of everything ™) it'll make for a much cleaner world.

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

How to change the base branch: (Link)
More detail about the branch update: (Link)


rustc 1.14.0 complains about "#![feature(path)]" error[E0554]: #[feature] may not be used on the stable release channel

I'm trying to package rust-pkg-config (ha!) for the GNU Guix distribution but I get the following error message (using rustc 1.14.0):
error[E0554]: #[feature] may not be used on the stable release channel
What should I do?

Seems odd! This library doesn't use any features, though, so you may have been using an ancient historical version.

It was 0.3.1.

Ah ok, in that case if you update it should fix this issue

Seems that it depends on lazy_static, which depends on spin. spin then fails.
6 | #![cfg_attr(feature = "asm", feature(asm))]
  |                              ^^^^^^^^^^^^

error[E0554]: #[feature] may not be used on the stable release channel
 --> src/lib.rs:7:42
  |
7 | #![cfg_attr(feature = "core_intrinsics", feature(core_intrinsics))]
  |                                          ^^^^^^^^^^^^^^^^^^^^^^^^

error[E0554]: #[feature] may not be used on the stable release channel
 --> src/lib.rs:8:35
  |
8 | #![cfg_attr(feature = "const_fn", feature(const_fn))]
  |                                   ^^^^^^^^^^^^^^^^^

Some other crate is likely enabling the relevant feature in the lazy-static crate, which causes all crates to end up using it.

The lazy_static chroot contains the following crates: lazy_static.
Network access is disabled.
Running cargo build then says that.
It seems that lazy_static has provisions for just using std::sync::Once if nightly and not spin_no_std. However, (1) it doesn't use that and (2) we have a non-nightly rustc (1.14.0) and the module std::sync::Once already exists. Is lazy_static already in rustc, too?


Upgrade to latest Node.js LTS

v8 will end its maintenance phase at the end of 2019, we should upgrade to v10 or v12.

Travis build still fails on weacast-arome but this is because is still points to an old version of weacast-arpege, once an upgraded version will be released this should be fine.


[SPARK-15863][SQL][DOC] Initial SQL programming guide update for Spark 2.0

What changes were proposed in this pull request?
Initial SQL programming guide update for Spark 2.0. Contents like 1.6 to 2.0 migration guide are still incomplete.
We may also want to add more examples for Scala/Java Dataset typed transformations.
How was this patch tested?
N/A

Test build #60277 has started for PR 13592 at commit 92f3f11.

Test build #60277 has finished for PR 13592 at commit 92f3f11.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60277/
Test PASSed.

Merged build finished. Test PASSed.

Test build #60309 has started for PR 13592 at commit 819e109.

Test build #60309 has finished for PR 13592 at commit 819e109.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60309/
Test PASSed.

Test build #60637 has started for PR 13592 at commit 200a68c.

Test build #60637 has finished for PR 13592 at commit 200a68c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60637/
Test PASSed.

Test build #60664 has started for PR 13592 at commit 4b3c4d3.

Test build #60664 has finished for PR 13592 at commit 4b3c4d3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60664/
Test PASSed.

Merged build finished. Test PASSed.

Test build #60698 has started for PR 13592 at commit f413cbb.

Test build #60698 has finished for PR 13592 at commit f413cbb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60698/
Test PASSed.

Merged build finished. Test PASSed.

Thanks everyone for the review!

@liancheng Is it worth adding  two parameters spark.sql.files.maxPartitionBytes and spark.sql.files.openCostInBytes in Other Configuration Options? They are kinds of internal parameters though, it seems they are useful for the users that would like to control #partitions. https://issues.apache.org/jira/browse/SPARK-15894

Thanks! Let's get it in first and then we can revise it.

@felixcheung I merged this one since I think it is better to make changes in parallel using this version as the foundation. Can you help on revising the R related doc? Thanks!

@felixcheung Thanks for the review and your work on PR #13751! Was traveling during the weekend. Let's address these comments in follow-up PRs.

@maropu Sorry for the late reply. Yea, adding description to these two options makes sense. Would you like to open a PR for this? Thanks!

@liancheng okay, I'll do that.


Xcode 10 warnings: "Messaging unqualified id"

I have XCDYouTubeKit embedded as a static library in my workspace and I'm getting on Xcode 10.0 several warnings of "Messaging unqualified id".
Anyone else encountered this?


Problem with volumes(longhorn) results in a never ending deployment

Rancher versions:
rancher/server or rancher/rancher:v2.0.2
rancher/agent or rancher/rancher-agent:v2.0.2
Docker version: (docker version,docker info preferred)
Client:
Version:	17.12.1-ce
API version:	1.35
Go version:	go1.10.1
Git commit:	7390fc6
Built:	Wed Apr 18 01:23:11 2018
OS/Arch:	linux/amd64
Server:
Engine:
Version:	17.12.1-ce
API version:	1.35 (minimum version 1.12)
Go version:	go1.10.1
Git commit:	7390fc6
Built:	Wed Feb 28 17:46:05 2018
OS/Arch:	linux/amd64
Experimental:	false
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
Ubuntu 18.04 LTS
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
Custom Cluster with rke
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single node rancher, 3 node cluster
Steps to Reproduce:
See https://github.com/rancher/longhorn/issues/85
Results:
The result is a never ending deployment, e.g.:
./kubectl -n wordpress get pod
NAME                                         READY     STATUS              RESTARTS   AGE
wordpress-mariadb-c8fd6b65d-mls8l      1/1       Running             0          1d
wordpress-wordpress-7568bbd7b4-cvnn2   1/1       Running             0          1d
wordpress-wordpress-867b64bdfd-nb4pc   0/1       ContainerCreating   0          4m

As you see, ther're 2 deployments, where only one is configured:
./kubectl get deployment -n wordpress
NAME                        DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE
wordpress-mariadb     1         1         1            1           3d
wordpress-wordpress   1         2         1            1           3d

@dnauck It's due to wordpress chart is a deployment rather than a statefulset.
Adding a sidecar will cause kubernetes to perform rolling upgrade for the deployment. But since Longhorn is RWO (read-write-once) storage system, the persistent volume cannot be mounted to another node. So the new wordpress pod failed to start, stopped the rolling upgrade process.
If we're using statefulset for wordpress, this can be avoided.
Also, if the pod launched with the sidecar, this can be avoided as well.

Please try https://github.com/rancher/rancher/issues/13944#issuecomment-398543354


Add support  in Get-WinEvent -FilterHashtable

Now Get-WinEvent -FilterHashtable support only Select for query.
Although Windows Event Log supports a subset of XPath 1.0 including Suppress.
An example of such a query:

I see three ways to add new functionality:

Add new parameter FilterHashtableSuppress or SuppressFilterHashtable.
Use prefix for standard keys: SUPId, SUPLevel, SUPUserID, SUPStartTime, SUPEndTime, SUPData, SUPNamedKey. Ex.:
Get-WinEvent -FilterHashtable @{Logname="Application";SUPId=1001}

3.Use special 'SuppressHashFilter' property in hash table.
Ex.:
Get-WinEvent -FilterHashtable @{Logname="Application";Id=1001;SuppressHashFilter=@{Id=1002}}

@PowerShellTeam Please assign me. I started working on the fix.


Mobile client cannot log in via google

Google complains that embedded browsers (web-view) aren't allowed. I don't know if this is fixable, but it is an issue nonetheless.
Tried with chat.zulip.org

Closing, thanks @oktayaa!


chore(deps): upgrade runtime dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-runtime-dependencies-k8s-26-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2818

Questions ?
Please refer to the Backport tool documentation


GS Toast Widget Error

GS Toast has an error where it shows blank toast, related to accent variant.
Platform: Mac OS

Resolved.


Memory profile

What does this PR do?
Fixes #60.
Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)

[ ] N/A

[x] Did you write any new necessary tests?

[ ] N/A

[ ] Did you make sure to update the docs?

[ ] N/A

[x] Did you update the changelog?

[ ] N/A

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (fc409a2) 91.71% compared to head (94bcdab) 91.89%.
 Consider uploading reports for the commit a4cc64c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   91.71%   91.89%   +0.17%
==========================================
  Files          33       35       +2
  Lines        2716     2776      +60
==========================================
+ Hits         2491     2551      +60
  Misses        225      225

Files
Coverage Δ

hta/memory_analysis.py
100.00% <100.00%> (ø)

tests/test_memory_analysis.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I'll update the documentation on RTD in a separate PR.


upport log_max_age

LogMaxAge is the maximum # of days (exclusive) to retain old files based on the timestamp encoded in their filename.
log_max_age <= 0 means delete immediately, otherwise it retains the files that are created within logMaxAge days.

@thrawn01 @klizhentas @k-pom @anton-efimenko @pirogoeth
anyone maintain this repo? looks like the CI has very old version for GO, which makes the checks fails.

@7ing Thanks for the Pull Request!
In your pull request, remove the old golang versions from travis.yml
Then we can go from there.

@thrawn01 thanks for your reply. travis tries to install github.com/axw/gocov/gocov, but it does exist any more, can I remove those steps as well?

Yes, remove all the following
install:
 - export PATH=$HOME/gopath/bin:$PATH
 - go get -v github.com/axw/gocov
 - go install github.com/axw/gocov/gocov
 - go get -v github.com/golang/glog
 - go get -v launchpad.net/gocheck
 - go get -v github.com/mailgun/glogutils

and replace with
install:
  - go get -t .

go get -t . will retrieve all the dependencies needed by the code

@thrawn01 seems the test requires gocov
gocov test -exclude-goroot | gocov report /home/travis/build.sh: line 57: gocov: command not found /home/travis/build.sh: line 57: gocov: command not found

just remove
  - gocov test -exclude-goroot | gocov report

from travis for now. We can always setup coveralls.io later if we want

@thrawn01 sure it works. Thanks for your quick response on this PR.

any updates on this ?


Feature Request: Enable to customize what to show under "INFO" tab of SARIF Results

With feature request that I'm going to explain, we'd like to achieve improved development process as below (continuous learning and improvement of coding skill).
Execute SAST -> Learn vulnerability found by SAST results -> Improve developer's skill -> Code -> (Back to Execute SAST)
Now, we have a modified SARIF file generated by Secure Code Warriror's plugin (BTW, Secure Code Warrior is learning platform that helps developer to learn secure coding). Inside "runs" -> "tool" -> "driver" -> "rules" -> "help" section of the SARIF, it provides learning guide that allows developer to learn security vulnerability with associated video and learning challenge.
So, my request is :
Could you please, add feature to SARIF Viewer to enable customizing what information to show under "INFO" tab of SARIF Results?
Specifically, we'd like information inside the "rules" -> "help" (please, see below for detail) of SARIF to be shown in the "INFO" section of SARIF Results.
Please, also see an image for the details.
With such feature gets inplemented in SARIF Viewer, our development process should be improved.
So, we hope this feature to be implemented.
"help": {
    "text": "機密情報のリークを防ぐため、例外メッセージを出力に渡してはならない [CWE.200.PEO]\n\nBuild your secure coding skills and defend your code:\n\n[CWE 200] Exposure of Sensitive Information to an Unauthorized Actor [What is this? (2min video)](https://media.securecodewarrior.com/v2/module_57_sensitive_data_exposure.mp4)\n\nThe product exposes sensitive information to an actor that is not explicitly authorized to have access to that information. [Try this challenge in Secure Code Warrior](https://portal.securecodewarrior.com/?utm_source=partner-integration:github-sarif-action#/contextual-microlearning/web/infoexposure/sensitiveinfo)",
    "markdown": "## Build your secure coding skills and defend your code\n\n#### [CWE 200] Exposure of Sensitive Information to an Unauthorized Actor *[What is this? (2min video)](https://media.securecodewarrior.com/v2/module_57_sensitive_data_exposure.mp4)*\n\n* The product exposes sensitive information to an actor that is not explicitly authorized to have access to that information. [Try this challenge in Secure Code Warrior](https://portal.securecodewarrior.com/?utm_source=partner-integration:github-sarif-action#/contextual-microlearning/web/infoexposure/sensitiveinfo)"
},

Please, let me know if you have any questions or concerns.

BTW, we can see information inside the "rules" -> "help" on GitHub.


Add new EVM chains

Add support for new EVM chains, need to wait for services PR to be merged to re-generate proto stubs

@jamie-notifi Looks like injective login is working with this PR. However, the Metamask sign is still not available.


After parse, default human readable print

I really wanted to use this to unify all addresses in a table that have been entered all kinds of ways, to one default way of entering the address, e.g. the ZIP4 format the USPS uses:
123 HAPPY ST NW
WASHINGTON DC 20002-4414

without this, i have to figure out a way to use the dict elements to recontruct an address from the parts..? How can I do this

Let's continue the conversation at #83.


Fix/tool addons

fixes: https://github.com/storybooks/storybook/issues/5416
I removed the need for tool addons to find the iframe, instead they can inject global styles, hwihc is marginally better then setting inline styles.
Long term i want to add a addon-type to wrap the preview component, so this can be done very cleanly.
@Ailrun care to review?

Weird the image tests work on my machine..

darnit

@tmeasday I improved to code, thanks!


Feature Request: PWA

Thank you for the awesome repo, I have been working hard to make this setup for 2 days now, dunno why the idea of searching for a ready setup did not come to mind. Really Thank you 😄
I think adding PWA would make it more awesome, even if as an option.

You should check Nuxt.js. It has support for PAW by default. I've used it with Laravel and works very well.


feat: support GitHub CLI terminal app, aliases and functions

:tada: This PR is included in version 2.12.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Need the Ability to Update the Item of an Order

As a User
I need the ordered to list be editable
So that costumers can modify their previous ordered products and quantity
Details and Assumptions

We will use RESTful APIs
add auth(customer ID), provided order ID

Acceptance Criteria
When I modify the quantity from 1 to 2
The price adjusts, but the order index stays the same
Given the selected product ID with its price, and the previous quality
When the Customer wants to edit the quality
Then the order quality of this order is updated

Got it, thanks for the suggestion!


docs: update the README.md

Codecov Report

Merging #4 (8d8fbaa) into master (1f97b70) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   38.31%   38.31%
=======================================
  Files           1        1
  Lines         214      214
=======================================
  Hits           82       82
  Misses        116      116
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f97b70...8d8fbaa. Read the comment docs.


Function type hints and format code

Currently I have added the type hints and docstrings to functions only, because most of the variables are of type str. Once we have more contributions and tests in place, we can gradually start using actual Date, URL, etc. objects instead of using all strings.
Please add the hacktoberfest label to this PR.

Will merge and mark as hacktoberfest! Thank you!


Track response redirect history.

How can I implement this method from python with Alamofire response: http://docs.python-requests.org/en/master/user/quickstart/#redirection-and-history
In python it look's like:  r1.history[0].headers  - headers of first request in redirects stack

@flypaper0 This isn't currently built into Alamofire or the underlying NSURLSession classes. What is your use case here? We would need a fairly convincing reason to add such a feature when NSURLSession doesn't already have it, especially when the use case would be so rare (more requests are never redirected). In the meantime, you can track this information yourself by providing the appropriate closure to your Manager's delegate. taskWillPerformHTTPRedirection is called whenever a redirect is performed.

Thanks @jshier.
I'm going to close this issue out @flypaper0. If you have additional questions, feel free to ask.
Cheers. 🍻


Use CMake, update README and fix some bugs

Use CMake to auto generate Makefile
Add cross compile tutorial in README
fix some bugs, like unknown type name 'u_char' in some compiling environments

Thanks a ton.


order-in-models + services?

The changes to order-in-models rule seem to want services injected in models to appear at the bottom of the model. This seems like a strange departure since other ordering rules want services to be at the top. Also the example does not show a way to customize where services should appear like in the order-in-controllers rule so I'm not sure if that's even an option or not.

Hey @bdmac, thanks for pointing this.
Indeed we might want to add this in one of next PRs.
For now you can customize this rule like this:
ember/order-in-models: [2, {
  order: [
    'service',
    'attribute',
    'relationship',
    'single-line-function',
    'multi-line-function',
  ]
}]

You can find list of all detectable things here: https://github.com/netguru/eslint-plugin-ember/blob/master/lib/utils/property-order.js#L10
I hope this solves your problem.

It will indeed. I just wasn't clear if those detections were applicable in all contexts or if they were somehow specific to each type. E.g. it wasn't clear I could detect services in models.

Okay, then I think we should update documentation to be more specific about this :)


Widen peer dependency range to include React 17

Describe the bug
Could this be widened to ^16.13.1 || ^17.0.0?
Current values in package.json:
"peerDependencies": {
"react": "^16.13.1",
"react-dom": "^16.13.1"
}
Purpose of proposed feature:
Allows apps using React 17 to also use react-chrono without peer dependency warnings.

peer dependencies updated with 1.11.0.


Manipulate examples

It would be great if the user could manipulate example, before these are added to the spec.
The rationale is that in staging (or production!) mode, the examples that get accumulated might be too big, or too sensitive or otherwise useless and there is no standard way for the library to deal with such issues.
This can be achieved by passing a manipulateExample callback option on init - for example this would trim large arrays, keeping only the first item:
expressOasGenerator.init(expressApp, null, {
  manipulateExample: (example, path, method, statusCode, anythingElseHere?) => {
      if (_.isArray(example) {      // trim large example array
          example = [ example[0] ];
          if (example[0].secretCompanyKey)
              example[0].secretCompanyKey = 'SOME_SECRET_KEY;
      }
      return example;
  }
)})

Was waiting this feature request since published the very first version 😄
I think there is a better to modify spec. I will provide ability to pass JSON patch  as a second parameter.

Hi Matvey - with all due respect, JSON patch looks like a great & standard solution when modifying remote objects & using alien languages to JSON, but it's nowhere near as flexible compared to how you can manipulate a referenced object in JS...
As John Carmack said Sometimes, the elegant implementation is just a function.  Not a method.  Not a class.  Not a framework.  Just a function  and let the user do whatever they want with it :-)

Thanks for patience Angelos, now you can manipulate the spec.
Example is available in test

To start using this functionality switch to 0.1.22

Thanks Mavey - using this method I am afraid we'll only get a chance to manipulate the initial spec, instead of the time an example is collected.
If you see my example above, the use case is to manipulate an example (trim large arrays, or hide tokens etc), everytime an example is received.

 Fixing.

Now it should work. Check version 0.1.23

or even 0.1.24

Hi Matvey - that's a static manipulation of an existing spec, only when in its initial loading.
The way I am proposing is to manipulate it as it builds up, example by example.
The use case is very large examples we are receiving at runtime that we wish to trim, as and when these arrive.


9.private-descriptor-template

Create private and public descriptors using descriptor templates

great. i have one more pr after this one gets merged

@geigerzaehler242 can you rebase to pick up the latest changes? I'll merge this after.

Nah don't close the PR! You can just rebase and force-push. Let us know if you need pointers to do that, happy to help.


Releasing 1.4.2

No worries, it is an expense that can go into my research funding :-)
Better having more than less.
On Tue, Oct 12, 2021 at 12:48 PM Arun Kannawadi @.***>
wrote:

Yes, I exhausted my allowance this month in one weekend of repeated
testing. With changes I have planned for v1.5, there should be fewer API
calls required. And I manually cancel the automated workflow if the changes
are trivial. If you find yourself not needing more than 1000 calls, please
downgrade to the free plan after a month or so.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/scholarly-python-package/scholarly/pull/341#issuecomment-941189155,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABFH4OQQCZPCCG6OPPX3X3UGRRF3ANCNFSM5F265TXQ
.

--
Panos Ipeirotis
Professor of Data Science and Information Systems
George A. Kellner Faculty Fellow
Stern School of Business, New York University
http://www.ipeirotis.com


Frontend code style check failed

One recent CI failed: #143
Expected Behavior
All code check CI shoud pass.
Current Behavior
One CI failed, some code styles don't meet standards.
Possible Solution
Unnecessary curly braces found here. Should be a easy fix.
Steps to Reproduce

Run make check locally and code style check will fail.

I will work on this. I tried to run make check and got this error message. Do you know how to resolve this? Thanks.

The make check script uses a python tool tox and it seems your machine doesn't have it installed.
Please follow this page, install the tox on your machine and try again.

Thanks! I have resolved this issue. But there is another issue.
I have installed the bzip2 on my WSL, but it still got this error.

This is not related to the WSL since it's running in a docker container. Each container has a separate environment and that's different from your host machine. So installing bzip2 on your own WSL won't solve the issue
In the past CIs, the error wasn't found because it seems not to affect the final result. For example in Github Action #140, it showed the same error but the whole CI still passed.
Regarding the solution, the issue is sourced from the node image used for a style check. It seems the node image we are using now has some internal issues.
I made an experiment here by upgrading node version to node:14.17 and no such error anymore.  Currently node:12.6.0-slim was used for code sytle checking and node:14.17 was for the dashboard production. So I suggest that we can upgrade code check image to 14.17 in order to match the production and to avoid such issues.
My experiment commits: https://github.com/xichen1/cello/pull/3/files
What do you think? @yeasy @fengyangsy @zhuyuanmao

This is not related to the WSL since it's running in a docker container. Each container has a separate environment and that's different from your host machine. So installing bzip2 on your own WSL won't solve the issue
In the past CIs, the error wasn't found because it seems not to affect the final result. For example in Github Action #140, it showed the same error but the whole CI still passed.
Regarding the solution, the issue is sourced from the node image used for a style check. It seems the node image we are using now has some internal issues. I made an experiment here by upgrading node version to node:14.17 and no such error anymore(related CI). Currently node:12.6.0-slim was used for code sytle checking and node:14.17 was for the dashboard production. So I suggest that we can upgrade code check image to 14.17 in order to match the production and to avoid such issues.
What do you think? @yeasy @fengyangsy @zhuyuanmao

+1 for using 14.17 instead

+1!

Fixed in #538


Sample code CI jobs are failing on ImportError: cannot import name 'resolve_types' when invoking Airflow

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2400
Originally created by @DouweM on 2020-10-29 23:48:40

Examples:

https://gitlab.com/meltano/meltano/-/jobs/820336670
https://gitlab.com/meltano/meltano/-/jobs/820336678

Started happening on https://gitlab.com/meltano/meltano/-/commit/58c7c7614f49bf64e4ad7ad188a10a791166c580, which doesn't touch any code (just docs), so it's likely an issue with some dependency that was updated somewhere.
Result of meltano invoke airflow version after meltano add orchestrator airflow:
  File "/builds/meltano/meltano/meltano-projects/my-meltano-project/.meltano/orchestrators/airflow/venv/bin/airflow", line 26, in <module>
    from airflow.bin.cli import CLIFactory
  File "/builds/meltano/meltano/meltano-projects/my-meltano-project/.meltano/orchestrators/airflow/venv/lib/python3.6/site-packages/airflow/bin/cli.py", line 94, in <module>
    api_module = import_module(conf.get('cli', 'api_client'))  # type: Any
  File "/usr/local/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "/builds/meltano/meltano/meltano-projects/my-meltano-project/.meltano/orchestrators/airflow/venv/lib/python3.6/site-packages/airflow/api/client/local_client.py", line 24, in <module>
    from airflow.api.common.experimental import delete_dag
  File "/builds/meltano/meltano/meltano-projects/my-meltano-project/.meltano/orchestrators/airflow/venv/lib/python3.6/site-packages/airflow/api/common/experimental/delete_dag.py", line 26, in <module>
    from airflow.models.serialized_dag import SerializedDagModel
  File "/builds/meltano/meltano/meltano-projects/my-meltano-project/.meltano/orchestrators/airflow/venv/lib/python3.6/site-packages/airflow/models/serialized_dag.py", line 35, in <module>
    from airflow.serialization.serialized_objects import SerializedDAG
  File "/builds/meltano/meltano/meltano-projects/my-meltano-project/.meltano/orchestrators/airflow/venv/lib/python3.6/site-packages/airflow/serialization/serialized_objects.py", line 28, in <module>
    import cattr
  File "/builds/meltano/meltano/meltano-projects/my-meltano-project/.meltano/orchestrators/airflow/venv/lib/python3.6/site-packages/cattr/__init__.py", line 1, in <module>
    from .converters import Converter, GenConverter, UnstructureStrategy
  File "/builds/meltano/meltano/meltano-projects/my-meltano-project/.meltano/orchestrators/airflow/venv/lib/python3.6/site-packages/cattr/converters.py", line 16, in <module>
    from attr import fields, resolve_types
ImportError: cannot import name 'resolve_types'

View 9 previous comments from the original issue on GitLab


Add Model support for mzXML, sequences, and method files

FEATURE REQUEST
Inspiration
In our TraceBase presentation to the Rabinowitz lab, Josh said he would like to be able to get from peak data/groups to the original sequence, and expressed a concern that it seems limiting (to accomplish that) since we don't store mzXML files (or their data).
Description
Add models and model fields to support mzXML files and their sequence (from a "method" file).
Alternatives
There has been lots of meeting discussions on this, which many proposals and docs.  (Please link all relevant documentation in the comments below, if any are missing).
Dependencies
This issue cannot be started until the completion of the following issue(s):

All PRs associated with issue #580

Comment
TBD

ISSUE OWNER SECTION
Assumptions

List of assumptions that the code will not explicitly address/check
E.g. We will assume input is correct (explaining why there is no validation)

Requirements

[ ] 1. List of numbered conditions to be met for the feature
[ ] 2. E.g. Every column/row must display a value, i.e. cannot be empty
[ ] 3. Numbers for reference & checkboxes for progress tracking

Limitations

A list of things this work will specifically not do
E.g. This feature will only handle the most frequent use case X

Affected Components
A tentative list of anticipated repository items that will be changed, labeled
with "add", "delete", or "change".  One item per line.  (Mostly, this will be a
list of files.)

change: File path or DB table ...
add: Environment variable or server setting
delete: External executable or cron job

DESIGN
Interface Change description
Describe changes to usage. E.g. GUI/command-line changes
Code Change Description
Describe code changes planned for the feature. (Pseudocode encouraged)
Tests

[ ] 1. A description of at least one test for each requirement above.
[ ] 2. E.g. Test for req 2 that there's an exception when display value is ''
[ ] 3. Numbers for reference & checkboxes for progress tracking

Please  review new model design and my notes  (part 6, slides 22-26 ) in uploaded file with prefix 20230327.

Please review new model design and my notes (part 6, slides 22-26 ) in uploaded file with prefix 20230327.

@fkang-pu - I apologize.  What I intended for this issue was just to distill the model changes we all agreed on in the meetings.  However, my description in the issue was too broad.  I just edited it to apply only to the model changes.  Could you make a small design (either in a file or by filling out the issue owner section in the issue above) that contains only the elements of the schema that we came to consensus on in the meetings?
This would consist solely of changed tables and fields.
And, you can reference your larger scope powerpoint files and all our other files in the issue, e.g. in the comment section where it currently says "TBD".
Your documents have been very helpful thus far and should lead to multiple small issues, this being one of them.

Also, slides 22-26 seem to still include elements that we agreed needed to be removed in the last meeting, so when fleshing out the issue owner section, updates from the last meeting should be included.

Regarding requirements,

this is the first I have heard of Req.#3 which seems out of scope given most of our discussions?  Are we proposing to have runs/scans without an associated peakgroupsets/accucor/isocorr?  [e.g. our entire system was initiated/focused on loading/analyzing that file]
requirement 4.2 also seems to run counter to our model sample.name being unique

I had a discussion with John about model changes yesterday afternoon. John prefers to make minimum changes to MSRun (e.g. link method file directly from ArchFile to MSRun). I like his suggestions. After reviewing the requirements proposed by Lance and Rob's design descriptions, I created a new ER diagram (part 7, slide 27) in uploaded file with prefix 20230329. Hopefully it will help us to speed up discussions this afternoon and come up with a final design.

First of all - excellent!  Thanks for the thorough review!  I think this demonstrates the value of documenting and reviewing, not only the requirements, but the design as well.  Not everyone is at every meeting and me all have our own interpretations.

Regarding requirements,

this is the first I have heard of Req. 3

You are correct.  When I sat down to formalize requirements, my touchstone was what Josh was getting at in our meeting where we presented version 2, and when I typed it up:

Be able to obtain data from unanalyzed peaks (e.g. from mzXML files) for inclusion in a new El-Maven/AccuCor/IsoCorr analysis

...it occurred to me that unanalyzed/unpicked peaks could come from not only the current used mzXML files in any of a number of accucor/isocorr files, it could come from mzXML files that were not included ion the run.  And that triggered a number of other thoughts which I alluded to in the review of Lance's milestone doc.  You can see my comment by looking at the comment history of the doc, but to make searching for it unnecessary, it says:

But I also assumed that we would just be providing the method file from which they could obtain the sequence, as opposed to saving the sequence of samples in the database, which is what I'm inferring you're saying here...? Does that mean we may store samples from the sequence that didn't have any peaks analyzed/saved?

It's somewhat of an indirect reference to requirement no. 3, but Lance indicated that we shouldn't have that as a requirement (in the implied context of the milestones), but he did seem open to including finer-grained requirements in the review discussion here, which is why I retained this requirement.

which seems out of scope given most of our discussions?

I think that excluding this requirement could bite us later when Josh wants to find the mzXML file referred to in the sequence in the method file that was totally unanalyzed.  While I'd agree that it may not affect the model implementation we've discussed - it could, depending on how it's implemented in associated code updates that support the new model.  For example, if Josh wants to be able to find these excluded mzXML files, but our implementation requires (to load a sample) that it has an MSRun child and that requires a scan group and a peakgroup to exist, it would mean a refactor.  That refactor would be unnecessary if we account for this possibility.
What made me think of this was the cold exposure validation.  Michael had accidentally included 4 accucor files that he had intended to exclude (so they weren't in the sample sheet).  It immediately reminded me, when I wrote these requirements of Josh's guiding feedback that he wanted to be able to obtain unanalyzed data.  The mzXML files that went into those accucor files represented (by definition) unanalyzed data.  They would show up in the sequence, which they would be able to find by downloading the method file, and go to find the mzXML file in tracebase, and if we don't include them, they won't be there.
So including this requirement would prevent us from making a mistake that might make including them more difficult than it would need to be if we'd kept it in mind during this effort.

Are we proposing to have runs/scans without an associated peakgroupsets/accucor/isocorr?  [e.g. our entire system was initiated/focused on loading/analyzing that file]

That is my suggestion, yes, in order to satisfy the ultimate goal that started this refactor: the ability to retrieve unanalyzed data from mzXML files.  This requirement seems right in line with that goal.

requirement 4.2 also seems to run counter to our model sample.name being unique

I would argue that it is in lock step with the goal.  Here's my argument:

mzXML files will (and do) have name collisions (we fix the samples by adding a prefix)
We have no control over mzXML file names on the originating system
Renaming files that may exist in a lab notebook or exist as copies on the originating filesystem under a different name would disrupt the ability to cross-reference what we have with external sources
We have the sha to fall back on for unique identification of files

We could rename mzXML files in TraceBase, but I would say that doing so is unnecessary (c.i.p.: the sha) and disruptive (breaks external data associations, c.i.p. lab notebooks and the originating file system).
In fact, I think we have all sorts of integrity issues in TraceBase right now with duplicate samples with different names.  In fact, I think we should not require sample names to be unique and instead create sample accession numbers using a study prefix and a number, but that is definitely out of scope here.  My point is, we shouldn't be uniquely identifying mzXML files by their non-unique names.

Closing this issue, and replacing with the mzXML Data Storage milestone.


[JOSS review] -  documentation enhancements

Since you are using the README as the documentation and per the following response on the JOSS review:

The reason I added the Jupyter notebooks to this directory is that they technically show the functionality aside from the command line. So I thought that should serve the purpose of testing as well. If I must add the unittest I will but If the notebooks suffice that would be my preference.

I would encourage you to add a link to the Notebook on the README, many people use these as documentation/ways to get started and I think these notebooks do provide a good overview of the package

Just noticed this is done and I missed them completely, apologies


Set updatedAt value for newly created documents

What happened:
When creating a new document through the dashboard example, the updatedAt value is not displaying correctly in the document list. (Ref: https://github.com/yorkie-team/dashboard/issues/99)
What you expected to happen:
When a document is first created, the updatedAt should be set to the same value as createdAt.
Reasons for this approach:

Initial state indication: It clearly shows that the record has not been modified since its creation.
Data consistency: All records will have an updatedAt value from the moment of creation.

How to reproduce it (as minimally and precisely as possible):

Navigate to the dashboard
Create a new document using the provided example

Check the document list

Observe that the updatedAt value is not correctly set

Anything else we need to know?:
Environment:

Operating system:
Browser and version:
Yorkie version (use yorkie version): 0.4.30
Yorkie JS SDK version: 0.4.28

Hello! I've identified an issue that needs fixing:
While working on this pull request, I realized that updated_at is only being updated when there's an operation in Change. This explains why updatedAt isn't set when a document is created.
I apologize for my mistake and will fix it immediately.

@window9u There's no need to be sorry. It seems natural that bugs are created due to changes. I'll wait for your PR.


Retrieve Sleep data using Health Platform

Hi team,
I would like to retrieve sleep session data from Health Platform. However, it always returns null. Could you please assist me on how to retrieve the sleep data ?
Note: it is a standalone app
Device: Samsung Watch 4

What sort of sleep data are you referring to? Are you looking to subscribe to the asleep / awake events?

I want to get the total amount of sleep time that has been recorded. From the Health Platform API docs, it does provide retrieving sleep stage from IntervalData DataType.SleepStageDataType. However, the total is always returning null


Issue with expo-linear-gradient

When I use the "className" prop of Nativewind on "LinearGradient" component, it doesn't work in iOS simulator, only in Android emulator. But If I use "style" prop instead of "className", it works on both simulators
Code:
import { Slot } from "expo-router";
import "../../global.css";
import { View } from "react-native";
import { LinearGradient } from "expo-linear-gradient";

const Root = (): JSX.Element => {
  return (
    <>
      <View className="flex-1">
      <LinearGradient
          start={{ x: 0, y: 1 }}
          end={{ x: 1, y: 0 }}
          colors={["#00d976", "#00a55a"]}
          className="absolute h-full top-0 right-0 left-0 bottom-0"
          // style={{
          //   position: "absolute",
          //   height: "100%",
          //   top: 0,
          //   right: 0,
          //   left: 0
          // }}
        />
        <Slot />
      </View>
    </>
  );
}

export default Root;

I think the reason is because the properties of LinearGradient are as follows:
export type LinearGradientProps = ViewProps & {
colors: string[];
locations?: number[] | null;
start?: LinearGradientPoint | null;
end?: LinearGradientPoint | null;
};
And ViewProps only accepts "style" prop, but then why on Android does it work with "className"?

 Thanks @bailletced

Have you tried with cssInterop? https://www.nativewind.dev/v4/api/css-interop
cssInterop(LinearGradient, { className: 'style' })

It works! Thanks, @bailletced


Fixed invalid use of env params on Travis

Replaced dictionaries with lists on travis config as the former are
considered invalid syntax.
While invalid travis does parse them but not without side-effects, like
seeing this on ENV section of the Travis jobs:
One of the secure variables in your .travis.yml has an invalid format.

One of the secure variables in your .travis.yml has an invalid format.

Where's the error?

Where's the error?

Take a look at https://github.com/ansible/molecule/pull/2180/checks?check_run_id=182919773 on the ENV column in travis results table.
If you google for that specific error you will find numerous bugs and also PRs that were fixing it, like https://github.com/nodejs/docker-node/pull/949/files
For example vscode is even failing to lint the file because if this, as travis.yml schema requires list of strings.


Fix Email Validations

Description
Have the client and the server use the same, simple, email validation rather than the complex one on the server that doesn't even match .mil domains.
Code Review Verification Steps

[ ] All tests pass.
[ ] Code follows the guidelines for Logging
[ ] The requirements listed in
Querying the Database Safely
have been satisfied.
[ ] Any migrations/schema changes also update the diagram in docs/schema/dp3.sqs
[ ] There are no aXe warnings for UI.
[ ] This works in IE.
Any new client dependencies (Google Analytics, hosted libraries, CDNs, etc) have been:

[ ] Communicated to @willowbl00
[ ] Added to the list of network dependencies

[ ] Request review from a member of a different team.
[ ] (TRIAL) Have the Pivotal acceptance criteria been met for this change?

References

Pivotal story for this change

I don't think we can make swagger lint error on email, but I can try and dry up the regex.


⚠ Bofrost.at has degraded performance

In 5e1b303, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1071 ms

Resolved: Bofrost.at performance has improved in 42eedd1 after 16 minutes.


Sitting model position

I noticed, through a mod that allows you to sit, but also sitting on minecarts or boats, I noticed that the position of the body model is positioned a lot behind what appears in the 3rd person view, which, for example, in the minecart the legs come out almost halfway, but in the first person view (with the mod active), the feet barely come out.
I don't know if this bug/graphical issue is so serious but if the mod owner can do something about it, it would be nice.

That's actually a feature, the body is offsetted behind the camera a little because otherwise if you look down you would just look at your neck. You can change the offset in the settings.

If it still feels wrong after changing the settings of the normal offset I could also look into adding config options for custom sitting offsets, but I can't guarantee that it works 100% with other mods that via some way allow you to sit.

just do it


Error while executing FormAction

I am facing this error when I try to execute my ActionForm
This is my error message:
ERROR    rasa_sdk.endpoint  - Exception on /webhook [POST]
Traceback (most recent call last):
File "/home/vphrase/Desktop/chatbot/chat_bot/lib/python3.6/site-packages/flask/app.py", line 2446, in wsgi_app
response = self.full_dispatch_request()
File "/home/vphrase/Desktop/chatbot/chat_bot/lib/python3.6/site-packages/flask/app.py", line 1951, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/vphrase/Desktop/chatbot/chat_bot/lib/python3.6/site-packages/flask_cors/extension.py", line 161, in wrapped_function
return cors_after_request(app.make_response(f(*args, **kwargs)))
File "/home/vphrase/Desktop/chatbot/chat_bot/lib/python3.6/site-packages/flask/app.py", line 1820, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/home/vphrase/Desktop/chatbot/chat_bot/lib/python3.6/site-packages/flask/_compat.py", line 39, in reraise
raise value
File "/home/vphrase/Desktop/chatbot/chat_bot/lib/python3.6/site-packages/flask/app.py", line 1949, in full_dispatch_request
rv = self.dispatch_request()
File "/home/vphrase/Desktop/chatbot/chat_bot/lib/python3.6/site-packages/flask/app.py", line 1935, in dispatch_request
return self.view_functionsrule.endpoint
File "/home/vphrase/Desktop/chatbot/chat_bot/lib/python3.6/site-packages/flask_cors/decorator.py", line 128, in wrapped_function
resp = make_response(f(*args, **kwargs))
File "/home/vphrase/Desktop/chatbot/chat_bot/lib/python3.6/site-packages/rasa_sdk/endpoint.py", line 59, in webhook
response = executor.run(action_call)
File "/home/vphrase/Desktop/chatbot/chat_bot/lib/python3.6/site-packages/rasa_sdk/executor.py", line 245, in run
events = action(dispatcher, tracker, domain)
File "/home/vphrase/Desktop/chatbot/chat_bot/lib/python3.6/site-packages/rasa_sdk/forms.py", line 528, in run
events = self._activate_if_required(dispatcher, tracker, domain)
File "/home/vphrase/Desktop/chatbot/chat_bot/lib/python3.6/site-packages/rasa_sdk/forms.py", line 474, in _activate_if_required
for slot_name in self.required_slots(tracker):

TypeError: required_slots() takes 1 positional argument but 2 were given

My Custom FormAction:
`class ExplorazorForm(FormAction):
     def name(self):
          return 'explorazor_form'

     def required_slots(tracker):
	"""A list of required slots that the form has to fill"""
	if tracker.latest_message['intent'].get('name') == "get_email":
		return ['email', 'target_col', 'dimension']
	else:
		return ['target_col', 'dimension']

     def submit(self, dispatcher: CollectingDispatcher, tracker: Tracker, domain: Dict[Text, Any]) -> List[Dict]:
	"""Define what the form has to do after all required slots are filled"""
	# utter submit template
	dispatcher.utter_template("utter_submit", tracker)
	return []

`
Please help me out here.

required_slots should be a @staticmethod.


coral-hive and coral-trino: Parse and unparse "INTERVAL '3' DAY"

This allows coral to support queries like CAST('2021-08-31' AS DATE) + INTERVAL '3' DAY

Thanks @uzshao for this patch. Could you please add description and rebase latest master so that we can run regression tests? Thanks.

@funcheetah Added description and rebased on master

Thanks. Started integration tests.

@wmoustafa and @ljfgem   This patch is complete now with added tests that covers negative cases, DAY TO SECOND, YEAR TO MONTH cases.  I also added support for unparsing in coral-spark.


get() and all() on excel::load not getting data

I tried using the excel::load('file path',function($reader){
print_r($reader->get()->toArray()); - can't retrieve anything
print_r($reader->all()->toArray());  - can't retrieve anything
});
but it return a blank page.
here is the link for sample excel file - (http://demo.worklude.com/samp_file_upload.xlsx)

found a solution

what your solution? i have same problem

Excel is a class with a capital E


Query validation for "in" where filter

If user enters a blank list or one that contains different types of values a panic ends the node process.
Include query validation allowing filter generation to fail and report back the error to the client instead of panicking.
Also check to see if list is empty, index access currently panics if empty.

Obsoleted by #230, which is a superset of this issue.


Allow access to WorkspaceDocument anywhere in View code

Description

Modified the WorkspaceDocument to be an EnvironmentObject for both sidebars and the main content, to allow any View in the window to access the document.
Moved @Published variables from WorkspaceDocument to AuroraDataStorage class
Removed SharedObjects class (functionality now moved to AuroraDataStorage)

This PR allows the WorkspaceDocument to be accessed from ANYWHERE in the AuroraEditor window. This should make it easier to implement an ability for extensions and the command palette to send commands to UI elements that would otherwise be inaccessible due to SwiftUI hierarchies.
Related Issue

#284

Checklist

[x] Get rid of redundant WorkspaceDocument references
[x] I read and understood the contributing guide as well as the code of conduct
[x] My changes generate no new warnings
[x] My code builds and runs on my machine
[x] I documented my code
[ ] Review requested

Screenshots
redundant, no functionality changed.

Change of plan, using WorkspaceDocument instead of AuroraEditorWindowController

I have heavily modified almost all views containing WorkspaceDocument. A notable side effect of using EnvironmentObject is that the value is not actually available on init, and therefore its best to do anything using the workspace inside of a .onAppear instead of within the init function. From my checks, no references to WorkspaceDocument are made within init functions of views to avoid this issue, however I may have missed some.

I'm going to test the broadcast system and then mark this PR as ready

[ ] Implement broadcast system
[ ] Ensure that Views can receive the broadcast
[ ] Ensure that View Controllers can receive the broadcast


Update FacebookAuthProvider.java

Updated permission for facebook logInWithReadPermissions to include email.
The email permission is included for iOS FirebaseUI but not in Android FirebaseUI.

I signed it!

I signed it!

@clive107 this PR is quite old and is targeting an old version of FirebaseUI.  Additionally the new version already has the feature you're trying to implement here.
Going to close this as a cleanup, thank you for taking the time to contribute!


Error ./start.ps1 'Starting Backend'

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ X ] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

from root folder Run azd up
cd app
./start.ps1

Any log messages given by the failure

Starting backend
./backend_env/scripts/python.exe
Usage: python -m quart run [OPTIONS]
Try 'python -m quart run --help' for help.
Error: While importing 'main', an ImportError was raised:
Traceback (most recent call last):
File "C:\Users\XXX\OpenaiChatProj\MarketplaceGPT\app\backend\backend_env\Lib\site-packages\quart\cli.py", line 175, in locate_app
module = import_module(module_name)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.1520.0_x64__qbz5n2kfra8p0\Lib\importlib_init_.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "", line 1204, in gcd_import
File "", line 1176, in find_and_load
File "", line 1147, in find_and_load_unlocked
File "", line 690, in load_unlocked
File "", line 940, in exec_module
File "", line 241, in call_with_frames_removed
File "C:\Users\XXX\OpenaiChatProj\MarketplaceGPT\app\backend\main.py", line 1, in
from app import create_app
File "C:\Users\XXX\OpenaiChatProj\MarketplaceGPT\app\backend\app.py", line 30, in
from approaches.readdecomposeask import ReadDecomposeAsk
File "C:\Users\XXX\OpenaiChatProj\MarketplaceGPT\app\backend\approaches\readdecomposeask.py", line 7, in
from langchain.agents import AgentExecutor, Tool
File "C:\Users\XXX\OpenaiChatProj\MarketplaceGPT\app\backend\backend_env\Lib\site-packages\langchain_init.py", line 6, in
from langchain.agents import MRKLChain, ReActChain, SelfAskWithSearchChain
File "C:\Users\XXX\OpenaiChatProj\MarketplaceGPT\app\backend\backend_env\Lib\site-packages\langchain\agents_init.py", line 2, in
from langchain.agents.agent import (
File "C:\Users\XXX\OpenaiChatProj\MarketplaceGPT\app\backend\backend_env\Lib\site-packages\langchain\agents\agent.py", line 16, in
from langchain.agents.tools import InvalidTool
File "C:\Users\XXX\OpenaiChatProj\MarketplaceGPT\app\backend\backend_env\Lib\site-packages\langchain\agents\tools.py", line 8, in
from langchain.tools.base import BaseTool, Tool, tool
File "C:\Users\XXX\OpenaiChatProj\MarketplaceGPT\app\backend\backend_env\Lib\site-packages\langchain\tools_init.py", line 60, in
from langchain.tools.powerbi.tool import (
File "C:\Users\XXX\OpenaiChatProj\MarketplaceGPT\app\backend\backend_env\Lib\site-packages\langchain\tools\powerbi\tool.py", line 12, in
from langchain.chains.llm import LLMChain
File "C:\Users\XXX\OpenaiChatProj\MarketplaceGPT\app\backend\backend_env\Lib\site-packages\langchain\chains_init.py", line 40, in
from langchain.chains.llm_math.base import LLMMathChain
File "C:\Users\XXX\OpenaiChatProj\MarketplaceGPT\app\backend\backend_env\Lib\site-packages\langchain\chains\llm_math\base.py", line 9, in
import numexpr
File "C:\Users\XXX\OpenaiChatProj\MarketplaceGPT\app\backend\backend_env\Lib\site-packages\numexpr_init.py", line 24, in
from numexpr.interpreter import MAX_THREADS, use_vml, BLOCK_SIZE1
ImportError: DLL load failed while importing interpreter: The specified module could not be found.

Expected/desired behavior

Local App starts, site should be navigable through localhost IP url and port

OS and Version?

Windows 11 pro

azd version?

azd v1.3.0

Versions

of this code? this was a fresh pull of this repo on 2023-09-21 at ~9 AM pacific

Mention any other details that might be useful

Python 3.11
Node v18.17.1
Not sure if this is a Langchain problem during the creation of the Python backend environment for running locally and, if so, how to amend the code to fix it. Tried wiping out the .env and starting again declaring the variables, running azd up. azd up worked successfully and the remote site in Azure actually works as expected every time. frontend build also appears to be successful in the log but no way to verify after this error while starting backend.

Thanks! We'll be in touch soon.

Hm, well, you could remove langchain and the langchain-dependent code, since the two primary approaches linked from the website do not use langchain.
That'd require:

removing langchain from https://github.com/Azure-Samples/azure-search-openai-demo/blob/main/app/backend/requirements.txt
deleting approaches/readdecomposeask.py and approaches/readretrieveread.py
removing references to those approaches in app.py https://github.com/Azure-Samples/azure-search-openai-demo/blob/f3cc2ad9c7de12aaa575cd5c4252efe1eaa400bd/app/backend/app.py#L30

You could also use GitHub Codespaces to develop, which shouldn't have an issue installing langchain. You can also try searching on the web or langchain issue tracker to see if other Windows users have had that error.

This is no longer an issue as the app code doesn't require langchain any more.


Possible to use without groups?

Hi
Great library, came here after becoming immensely frustrated with the Spatie experience.
Is it possible to use this library without groups?
We already have groups (of other models) which belong to our teams, so extending this libraries Team is problematic.
Thank you

Hi @PerryRylance!
Yes, you can use your own model.  You can try to change default Jurager\Teams\Models\Team::class model in config/teams.php in models.team to point your actual model. Then copy to you model all methods from package's Jurager\Teams\Models\Team::class model, also change the foreign_keys.team_id to fit you "Team" model primary key.

Relation from User to Team is implemented in HasTeams trait, you can see here the logic for accessing Team from User
    /**
     * Get all the teams the user belongs to.
     *
     * @return BelongsToMany
     */
    public function teams(): BelongsToMany
    {
        return $this->belongsToMany(Teams::$teamModel, Teams::$membershipModel)
            ->withPivot('role_id')
            ->withTimestamps()
            ->as('membership');
    }

You also need to do the same with the Membership model, because it is used to indicate that the user is in the team, unless of course you already have your own mechanism, otherwise leave it as it is


Rancher Support

I have attempted to deploy Zeebe Full onto Rancher (v2.2.X) running version 1.16.3 of kubernetes.
The deployment instantly fails with the following error message:
Failed to install app zeebe-full. Error: validation failed: unable to recognize "": no matches for kind "Deployment" in version "extensions/v1beta1"
Do you have any ideas on where to progress from here?

@Lamby123 there seems to be some issues with 1.16 based on the GKV of some of the kubernetes resources. There is another issue about that.. I would rename this issue to kubernetes 1.16 instead of rancher.. I am sure that Rancher has nothing to do with the problem.

@Lamby123 I am closing this issue as this is a duplicate of: https://github.com/zeebe-io/zeebe-helm/issues/6


Proposal: Add explicit typing to sourceParams

The idea here would be enforce more rigor when it comes to source params. The proposal here would require devs to implement a params function that conforms to the annotated types when they build their Source class.
The downside, I am not sure we can define the function for users, however, at the very least, most can just implement with something that returns an empty object.
I don't know much about how deno libraries are managed, so not sure if there are some tests I need to run these against or whatever. Ultimately I don't actually care too much if this PR is rejected because there might be a better way to do this, but figure I would get the discussion started here.

@amadeus Well, I need to test it to keep compatibility.

You need to fix failed CI in the first.

If you change the source interface, you need to change the filter interface.

You need to fix failed CI in the first.

If you change the source interface, you need to change the filter interface.

And the documentation must be changed for ddc-source-attribute-params and ddc-filter-attribute-params.

I was not aware how to run tests locally, but based on this, I can see the commands and work through this!

Please execute make lint and make test in the repository.

btw, just a bit busy with work at the moment, I still plan to work on this, but probs not until the weekend

OK.

Ping.  How progress?

Sorry, life has been quite busy for me the last week or so, gonna close this until I have time to better look into it!

Oh, I think the feature is useful.
I will take a look.

The feature is already implemented.


s3: add explicit, working CSP policy in index.html, workaround for safari

Daniel is working on updating our CSP to add the data directive, which will allow apps like turf to work. This new policy breaks our image uploads due to a bug in safari. The workaround for us, that allows Daniel to update the CSP on hosting, is to apply the old hosting CSP policy to our app directly in the index.html.

Testing this with Daniel rn.

@dosullivan do you have any update? Could you guys test this?

@latter-bolden will. get this up on a moon for testing

@dosullivan you can sync from ~dozped-mogtec, both %groups and %talk have the CSP changes on there

@dosullivan confirmed this PR in tandem with the hosting side change fix things for their use case. I also added support here for blob and data URLs for images & fonts.
We should talk through security implications together before we merge this.

Label: Do not merge can be removed once @latter-bolden 's concern is addressed

May fix https://linear.app/tlon/issue/LAND-1336
(test)


Fix a bug in commit 5bb1e70, issue #137: generate a new random endpoint also when returning to homepage from endpoint page, i.e. without reloading the page.

#137

Hei @SaraKuitunen :)
Could you give a bit more context on this one?
For example, could you describe what is the current behevior (with steps to reproduce the bug) and what is your expected behevior.
Thanks!

Hei,
Sure! Random endpoints are only generated when the page is loaded/ reloaded (sending HTTPS request). A new random endpoint is not generated if user goes from randomly generated endpoint page back to home page by going back to the previous page and then tries to generate another random endpoint. Expected behaviour is that the button to generate random endpoint always generates a new endpoint, also when the button is clicked on already visited homepage to which user has returned.
Hope this made is clearer! :)


fix(abigen): resolve output struct types correctly

Motivation
Closes #1509

Solution
resolve output types correctly when we expand the function output params

PR Checklist

[x] Added Tests
[ ] Added Documentation
[ ] Updated the changelog

nice thank you!


Dashboard: My Stories; A11y, Search Component cannot be focused

Bug Description
The search component is unable to be focused on the dashboard, my stories view.
Expected Behaviour

Steps to Reproduce

Screenshots

Additional Context

Plugin Version:
Operating System:
Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Verified in QA


Extend python test coverage

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Looks nice so far

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.17%. Comparing base (e97a536) to head (b53403a).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #17   +/-   ##
========================================
  Coverage    55.17%   55.17%
========================================
  Files           79       79
  Lines         4176     4176
  Branches       461      461
========================================
  Hits          2304     2304
  Misses        1872     1872

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Some extra comments, that you may do or I will once I get a chance (today/tomorrow)


Break after upgrade 0.9.1 -> 0.9.2

After upgrade 0.9.1 -> 0.9.2 this code:
this.on('fetched:collection', function(collection) {
    return collection.map(function(model) {
      return dbDateTime.afterFetch(model);
    });
  });

log error:
TypeError: collection.map is not a function

+1
In 0.9.2 something's broken in the events system. In our case we have the event fetched being called when doing a fetchAll(). This is causing major breaks on code as we rely on an instance of model being returned.
Code sample:
// Controller
Quotation.forge().where({order_id: this.id, voided: false}).fetchAll();
// Model
this.on('fetched', function(model, attrs, options){
  var promises = [
    model.extendWithValidateQuotationLink(),
    model.extendWithQuotationTotal()
  ];
  return Promise.all(promises);
});

As stated, in 0.9.2 the event fetched is being fired.

Also got bitten by this bug. I have a fetched:collection listener, but it is being called when I do Model.fetch() and my code is expecting a collection not a model.

I did some digging and I found the culprit. When you refactored the events code to use Lodash's word function, it started splitting events with colons into multiple events: https://github.com/tgriesser/bookshelf/compare/0.9.1...0.9.2#diff-c874145af93ab1534cfa36243da25a76R111
> _.words('fetched:collection')
["fetched", "collection"]

Okay, sorry, my bad. words is not the right function to be using here! Should be an easy fix if anybody is interested in supplying a PR.

Just gotta supply the old regex for the words function, I think that should do the trick.

@rhys-vdw Thanks for the quick fix release! :palm_tree:


Use variadic templates for rpc serialization

Replaces variable argument lists in serialization with variadic templates.

The main benefit of doing this is that the hard coded schema for requests and responses in NetworkMessage.cc is no longer needed.
requests/responses are now parsed in the same manner.

FWIW the point of the message format table is to have a single place that documents what the message formats are. If you drop this in favor of encoding and decoding in the wrapper functions, that can work but I'd argue that it makes the protocol more brittle and less explicit. Using variadic templates, it is possible to silently change the wire protocol by changing the type of an output variable, which is a bit worrying.

@jpeach the current logic does the decoding in the wrapper function. If you look at TSControlMain.cc, each of the callback functions specifies its own parameters to parse, it does not look at the schema defined in NetworkMessage.cc. So the format is only actually specified when serializing and not when deserializing.
Can the formatting just be documented somewhere and have some sort of static_assert to check that the correct parameters are there at compile time?

If you look at TSControlMain.cc, each of the callback functions specifies its own parameters to
parse, it does not look at the schema defined in NetworkMessage.cc.

It specifies the output parameters, but the actual format is looked up from the optype by the GETCMD macro. It's a bit unfortunate that this isn't type-safe at compile time.

Variadic templates provide the type safety that means if these two disagree the internal logic can
detect that and provide a detailed diagnostic of the form "receiver passed an int reference for
argument 3, but the message arrived with a string in that position".

The protocol never passes types so you can't find errors like this. If there is a mismatch the most likely result is garbage or memory corruption (which isn't really any different to how it behaves today).

@jpeach I talked with @SolidWallOfCode. Going to close this PR for now and add in type info as part of the protocol. So, at runtime, it will be able to tell if the correct parameters are being passed.

On Apr 16, 2018, at 2:49 PM, Alan Wang<EMAIL_ADDRESS>wrote:
@jpeach I talked with @SolidWallOfCode. Going to close this PR for now and add in type info as part of the protocol. So, at runtime, it will be able to tell if the correct parameters are being passed.

One thing that we always wanted to do was to make this protocol an external API rather than an internal implementation detail. Nowadays I would expose a gRPC API and let people build their own management applications if they want.
J

@jpeach I'm working on that right now :) I was attempting to break it up into incremental commits so that it could actually be reviewed. maybe I jumped the gun on this PR.


Update previewer using latest response code

Summary
As titled
Screenshot
https://github.com/user-attachments/assets/2a39280e-8088-40d4-9945-47dd9f0aacce
Checklist

[x] My code follows ESLint rules and passes all tests.
[x] I have updated the documentation accordingly.

Awesome! Would the code section in previewer be formatted?

Yes. The code in the previewer section will be formatted but not for the one in the chat. @ZhuoyangM will fix that.


ombi.jasonernst.com ipv6 failing

couldn't reach via att cell network, only wifi which uses ipv4

see: https://github.com/nginx-proxy/nginx-proxy/issues/1419
and https://github.com/robbertkl/docker-ipv6nat

fixed as of: https://github.com/compscidr/iac/commit/8c5265ec469f038ade2bf3987a21ff735cc24ea8


Upgraded to version 1.56.0... Issues with terminal/Powershell

VS Code Version: 1.56.0
OS Version: Windows 10 Version 20H2 Build 19042.928

Steps to Reproduce:

Start VSCode

Does this issue occur when all extensions are disabled?: Yes
ISSUE:
I used to depend on the below settings.json settings:
"terminal.integrated.shell.windows": "C:\\WINDOWS\\System32\\wsl.exe",
"terminal.integrated.shell.windows": "C:\\Program Files\\Git\\bin\\bash.exe",
"terminal.integrated.shell.windows": "C:\\WINDOWS\\System32\\WindowsPowerShell\\v1.0\\powershell.exe",
"terminal.integrated.shellArgs.windows": [
    "-NoLogo",
    "-ExecutionPolicy",
    "Bypass"
],
"powershell.integratedConsole.suppressStartupBanner": true

Now, I get 3 warning messages for the above settings:
This is deprecated, use `#terminal.integrated.defaultProfile.windows#` instead
This is deprecated, use `#terminal.integrated.defaultProfile.windows#` instead
This is deprecated, use `#terminal.integrated.defaultProfile.windows#` instead

When I go to use terminal.integrated.defaultProfile.windows in my settings, VScode doesn't seem to recognize that setting. It looks like it hasn't been implemented yet.
With some trial and error, the settings below seem to be valid. However, I'm not even sure they're an equivalent replacement for the depreciated settings above.  I was completely guessing; and, probably have several mistakes.  I also added cmd.exe:
"terminal.integrated.profiles.windows": {
    "PowerShell": {
        "path": [
            "${env:windir}\\Sysnative\\WindowsPowerShell\\v1.0\\powershell.exe",
            "${env:windir}\\System32\\WindowsPowerShell\\v1.0\\powershell.exe"
        ],
        "source": "PowerShell",
        "icon": "terminal-powershell",
        "args": [
            "-NoLogo",
            "-ExecutionPolicy",
            "Bypass"
        ]
    },
    "Command Prompt": {
        "path": [
            "${env:windir}\\Sysnative\\cmd.exe",
            "${env:windir}\\System32\\cmd.exe"
        ],
        "icon": "terminal-cmd"
    },
    "Git Bash": {
        "path": [
            "C:\\Program Files\\Git\\bin\\bash.exe",
        ],
        "source": "Git Bash",
        "icon": "terminal-bash"
    },
    "WSL": {
        "path": [
            "C:\\WINDOWS\\System32\\wsl.exe",
        ],
        "source": "wsl",
        "icon": "terminal-wsl"
    }
},
"powershell.integratedConsole.suppressStartupBanner": true,

Unfortunately, the -NoLogo argument above is completely ignored.  Also, "powershell.integratedConsole.suppressStartupBanner": true is ignored as well.  So, when PowerShell starts up in the terminal, I get:
Windows PowerShell
Copyright (C) Microsoft Corporation. All rights reserved.

Try the new cross-platform PowerShell https://aka.ms/pscore6

Loading personal and system profiles took 681ms.

Adding "CLS" to my $profile is a pretty lame solution. I'm looking for the right way to suppress the banner/logo above same as before.
Could someone please tell me how to configure VSCode 1.56.0 to behave just like before?  Please correct any mistakes I may have in my proposed new settings.  Also, I wasn't sure what to put for the wsl icon.  I used, "icon": "terminal-wsl".  However, I was completely guessing.
Lastly, how to I force VSCode to only use PowerShell Integrated Console or powershell?  (see below screenshot).  It seems like the terminal randomly opens one or the other or both.   I used to never have this issue in previous versions of VScode.  I just want the same powershell to open up consistently each time I start a new terminal session.

Thank you guys for all your hard work!

"terminal.integrated.shellArgs.windows" seems to be deprecated and is suggesting to use #terminal.integrated.defaultProfile.windows# instead, however if I set the execution policy there, then it gives me "Incorrect type. Expected one of string, null."
Also it seems to ignore terminal.integrated.profiles.windows.Powershell.args. The whole deprecation message leaves it unclear how to get to the same result as it was in previous versions.

@krisavi Thank you for confirming.  I'm guessing the only way to suppress the PowerShell logo/banner is to use previous versions of VSCode.
I also noticed that this new version of VSCode loads a powershell tab in addition to the PowerShell Integrated Console tab (see below screenshot).  I only want the PowerShell Integrated Console to load on startup:

I'm running VSCode on Windows 10.  I'm guessing that VSCode is also loading the PowerShell that came builtin with Windows 10 in addition to the Integrated PowerShell Console.  I'm just not sure how to prevent that from happening.  Is there a setting that prevents the second PowerShell tab from opening?
Thank you for your time.

However, There is a separate powershell tab that also gets loaded on VSCode startup which DOES show the logo/banner (see below screenshot).

This works for me:
"terminal.integrated.profiles.windows": {
  "PowerShell": {
    "source": "PowerShell",
    "icon": "terminal-powershell",
    "args": ["-NoLogo"]
  }
}

What I think you're seeing is https://github.com/microsoft/vscode/issues/123188

With some trial and error, the settings below seem to be valid. However, I'm not even sure they're an equivalent replacement for the depreciated settings above. I was completely guessing; and, probably have several mistakes. I also added cmd.exe:

The settings.json editor won't get that much better than it is, but we want to add an actual settings UI editor for these settings: https://github.com/microsoft/vscode/issues/123169
Here are some comments on your settings:

You don't need path when you have a source, the purpose of source is to let VS Code handle fetching the path when resolving defaults is complicated.

There is no WSL source, WSL profiles are dynamic and automatically get added when you have "terminal.integrated.useWslProfiles": true set. This is because we want to automatically pick up newly installed distros and automatically remove uninstalled ones
path can be a string if you want: "path": "${env:windir}\\System32\\cmd.exe"

The whole deprecation message leaves it unclear how to get to the same result as it was in previous versions.

Good point, this is being improved in https://github.com/microsoft/vscode/pull/123174

Lastly, how to I force VSCode to only use PowerShell Integrated Console or powershell? (see below screenshot). It seems like the terminal randomly opens one or the other or both. I used to never have this issue in previous versions of VScode. I just want the same powershell to open up consistently each time I start a new terminal session.

VS Code will always restore the default shell if the terminal is opened on start up. The PS integrated console does something similar and it doesn't have the capability to prevent the start up, it could kill other terminals on startup though that would be a bit dangerous.

Also, I wasn't sure what to put for the wsl icon. I used, "icon": "terminal-wsl". However, I was completely guessing.

icon is actually optional, it can be whatever you want. Intellisense for this was deferred to https://github.com/microsoft/vscode/issues/122473 but the easiest way to do this now is to run the change icon command and find the icon ID you like:

Hope that was helpful, I think everything here is covered in other issues.

@Tyriar Wow.  Thank you so much for taking the time to answer all my questions!  I really appreciate it.
Below, are the settings I ended up with per your suggestions.  However, unfortunately, every time I start VSCode with the terminal open, the terminal will randomly display the PowerShell logo/banner.. and, other times it won't display it on startup.  It's hit or miss.  However, at least now only 1 PowerShell tab opens when VSCode starts up.  I'm guessing it's because the default shell getting loaded randomly.
I didn't have this behavior before in previous versions of VSCode on the same PC.  Is there any way to force the Terminal to NOT display the banner consistently?  It's quite annoying; especially, when it wasn't doing this in previous versions on the same PC.  I'm very motivated to prevent this from happening.
    "powershell.integratedConsole.showOnStartup": true,
    "terminal.integrated.useWslProfiles": true,
    "terminal.integrated.tabs.enabled": true,
    "terminal.integrated.defaultProfile.windows": "PowerShell",
    "terminal.integrated.profiles.windows": {
        "PowerShell": {
            "source": "PowerShell",
            "icon": "terminal-powershell",
            "args": ["-NoLogo"]
        },
        "Command Prompt": {
            "path": "${env:windir}\\System32\\cmd.exe",
            "icon": "terminal-cmd"
        },
        "Git Bash": {
            "source": "Git Bash",
            "icon": "terminal-bash"
        },
        "WSL": {
            "path": "C:\\WINDOWS\\System32\\wsl.exe",
            "icon": "terminal-wsl"
        }
    },
    "powershell.integratedConsole.suppressStartupBanner": true,
    "files.defaultLanguage": "powershell",

@mkanet the startup thing is a bug, we should fix it soon in Insiders but I don't think it meets the bad to go into a recovery build for stable #123188
Another perk with the profiles is you can leave out the default ones all together if you don't change them, so I think you could just have this for the same effect:
"PowerShell": {
	"source": "PowerShell",
	"icon": "terminal-powershell",
	"args": ["-NoLogo"]
},
"WSL": {
	"path": "C:\\WINDOWS\\System32\\wsl.exe",
	"icon": "terminal-wsl"
}

Thank you for explaining.  I think I'll just revert to the previous version of VSCode until there's a non-Insiders build with the fix.

@mkanet I think removing "terminal.integrated.defaultProfile.windows": "PowerShell" and avoiding switch default profile will basically give you the previous version's behavior.

@Tyriar unfortunately it didn't seem to make any difference.  Actually, now the terminal consistently shows the banner\logo on startup every time  "args": ["-NoLogo"]  and "powershell.integratedConsole.suppressStartupBanner": true are completely ignored.  It seems to consistently load the default shell.
If I get lucky enough where `PowerShell Integrated Console" starts up, there is no banner\logo.

@mkanet the terminal that gets restored will use your default shell, when you do not have defaultProfile set, it will use shell and shellArgs. So you're probably missing:
"terminal.integrated.shellArgs.windows": ["-NoLogo"]

@Tyriar Yes, that's the setting I used to use before upgrading to version 1.56.0 (when the terminal worked correctly).  If I try to use that setting now, I get the message:
This is deprecated, use #terminal.integrated.defaultProfile.windows# instead sigh
I just want to make sure I understand what's causing the banner to always show.  Is it because of https://github.com/microsoft/vscode/issues/123188?  Or, is there something I can fix in my settings now?

The message is a warning to indicate to move towards defaultProfile, but it'll be several months at least before we remove it.

I'm not sure what's wrong.  I'm still seeing the banner/logo every time I start VSCode.  Below, are all my current settings related to the terminal.  I'm not sure what else to try.  I've never had such bad luck with VSCode before.
    "terminal.integrated.useWslProfiles": true,
    "terminal.integrated.tabs.enabled": true,
    "terminal.integrated.shellArgs.windows": [
        "-NoLogo"
    ],
    // "terminal.integrated.defaultProfile.windows": "PowerShell",
    "terminal.integrated.profiles.windows": {
        "PowerShell": {
            "source": "PowerShell",
            "icon": "terminal-powershell",
            "args": ["-NoLogo"]
        },
        "WSL": {
            "path": "C:\\WINDOWS\\System32\\wsl.exe",
            "icon": "terminal-wsl"
        }
    },
    "powershell.integratedConsole.showOnStartup": true,
    "powershell.integratedConsole.suppressStartupBanner": true,

Yeah, this bug is awful. The only solution for me is to disable updates with "update.mode": "none", and then revert to previous version by downloading and installing from the website , at least for the time being! Given how many issues there are, I don't even know where to complain about it, issue  #123188 seems to be less people there.


Unable to use sedona.global.charset in ShapefileReader

Expected behavior
ShapefileReader.readToGeometryRDD(sedona_context, shp_file) should use the sedona.global.charset configuration property set in the spark session when reading shapefiles containing non-ASCII characters.
E.g. A shapefile containing an attribute value "Ariñiz/Aríñez" should appear in a dataframe as "Ariñiz/Aríñez".
Actual behavior
ShapefileReader.readToGeometryRDD(sedona_context, shp_file) is not using the charset configuration property set in the spark context.
E.g. A shapefile containing an attribute value "Ariñiz/Aríñez" appears in a dataframe as "AriÃ±iz/ArÃÃ±ez" instead.
Steps to reproduce the problem
from pyspark.conf import SparkConf
from pyspark.sql import SparkSession
from sedona.core.formatMapper.shapefileParser import ShapefileReader
from sedona.spark import SedonaContext
from sedona.utils.adapter import Adapter

conf = SparkConf()
conf.set("sedona.global.charset", "utf8")
spark = SparkSession.builder.config(conf=conf).getOrCreate()

sedona = SedonaContext.create(spark)
sedona_context = sedona.sparkContext

shp_file = '[aws s3 path to shapefile]'
shp_rdd = ShapefileReader.readToGeometryRDD(sedona_context, shp_file)
shp_df = Adapter.toDf(shp_rdd, sedona)

I can confirm that ("sedona.global.charset", "utf8") appears in the configuration settings by using:
print(sedona_context.getConf().getAll())

I also tried setting the charset property after creating the sedona context as follows (although this appears to be an older solution):
sedona_context.setSystemProperty("sedona.global.charset", "utf8")

Please confirm how to set this configuration property correctly.
Settings
Sedona version = 1.5.1
Apache Spark version = 3.3.0
API type = Python
Python version = 3.10
Environment = AWS Glue 4.0 using sedona-spark-shaded-3.0_2.12-1.5.1.jar and geotools-wrapper-1.5.1-28.2.jar

@adamaps If you are running Sedona in a cluster mode, this needs to be set via spark.executorEnv.[EnvironmentVariableName]: https://spark.apache.org/docs/latest/configuration.html
In your case, you might want to try this:
spark.executorEnv.sedona.global.charset utf8

Thank you for the quick response, @jiayuasu !
I tested the following in client mode before creating the Sedona SparkSession/SparkContext (via a local Docker container):
conf = SparkConf()
conf.set("sedona.global.charset", "utf8")  # I have other conf settings not shown here
spark = SparkSession.builder.config(conf=conf).getOrCreate()
sedona = SedonaContext.create(spark)

And I tested both of the following in cluster mode after creating the Sedona SparkSession/SparkContext (via AWS Glue):
spark.conf.set("spark.executorEnv.sedona.global.charset","utf8")
sedona.conf.set("spark.executorEnv.sedona.global.charset","utf8")

Unfortunately I still see the same issue in both cases.
Are you able to replicate (or reject) the issue using the attached shapefile sample?
shapefile_sample.zip

sedona.global.charset has to be set as a Java system property. You can try setting the following spark configurations:
spark.driver.extraJavaOptions  -Dsedona.global.charset=utf8
spark.executor.extraJavaOptions  -Dsedona.global.charset=utf8

The dataframe loaded from the sample shapefile:
+--------------------+--------------------+--------------------+--------------------+
|            geometry|                  ID|                Name|          Name_ASCII|
+--------------------+--------------------+--------------------+--------------------+
|MULTIPOLYGON (((-...|01015               |Ariñiz/Aríñez    ...|Ariniz/Arinez    ...|
+--------------------+--------------------+--------------------+--------------------+

Thank you, @Kontinuation! 🎉
I can confirm that setting the following configuration parameter in PySpark worked for my local setup. And thanks @jiayuasu for updating the docs.
conf.set("spark.driver.extraJavaOptions", "-Dsedona.global.charset=utf8")

Running on AWS/Glue is still causing issues, but this seems specific to our setup.


Timeline for Pydantic V2

(This issue exists to track progress towards Pydantic V2)
See, this blog post for details on the plan for V2.
See, this project for details on outstanding tasks.
I had originally said I would have pydantic V2 completed by the end of this year (2022), sadly that hasn't happened. I'm sorry about any inconvenience this has caused, I've tried very hard to get the release ready but a number of factors outside the project plan have delayed things 🙏 .
My aim now is to have V2 released in Q1 2023.
Thank you for your patience.

Hi,
I'd like to add https://github.com/pydantic/pydantic/issues/4617 to the TODO.
Having a powerful Config.extra would allow dealing with objects with additionalProperties|patternProperties mixed with properties, currently this is __root__ cannot be mixed with other fields, a real improvement.

Just an update that we're aiming for an alpha release of Pydantic V2 by the end of March.
We're deferring the following until after the alpha release:

documentation of V2 (I have some exciting news on documentation coming soon)
the hypothesis plugin
any compatibility shims for V1
V2 auto-migration tool, see #5013

First alpha is out 🚀
See this blog post for more information.

Second alpha came out last week (sorry I didn't comment here).
Plan is to get to a feature freeze on the next couple of weeks, then we'll release one or more betas and solicit testing, but the API shouldn't change.

V2 beta and feature freeze is very close, see #5919.