anat affine appears off for ds000114 between data and fmriprep output

any reason why the T1 brainmask output from fmriprep has different affines from original T1 of the dataset? is this because of the conform step?
$ mri_info ../sub-01/anat/sub-01_t1w_brainmask.nii.gz
Volume information for ../sub-01/anat/sub-01_t1w_brainmask.nii.gz
          type: nii
    dimensions: 256 x 156 x 256
   voxel sizes: 1.000000, 1.299473, 1.000000
          type: FLOAT (3)
           fov: 256.000
           dof: 0
        xstart: -128.0, xend: 128.0
        ystart: -101.4, yend: 101.4
        zstart: -128.0, zend: 128.0
            TR: 0.00 msec, TE: 0.00 msec, TI: 0.00 msec, flip angle: 0.00 degrees
       nframes: 1
       PhEncDir: UNKNOWN
       FieldStrength: 0.000000
ras xform present
    xform info: x_r =   0.9992, y_r =  -0.0393, z_r =   0.0096, c_r =    -2.1763
              : x_a =   0.0395, y_a =   0.9989, z_a =  -0.0269, c_a =    22.5293
              : x_s =  -0.0085, y_s =   0.0272, z_s =   0.9996, c_s =    -8.5970
Orientation   : RAS
Primary Slice Direction: axial

voxel to ras transform:
                0.9992  -0.0510   0.0096  -127.3170
                0.0395   1.2980  -0.0269   -80.3350
               -0.0085   0.0354   0.9996  -138.2132
                0.0000   0.0000   0.0000     1.0000

voxel-to-ras determinant 1.29947

ras to voxel transform:
                0.9992   0.0395  -0.0085   129.2109
               -0.0302   0.7687   0.0209    60.7968
                0.0096  -0.0269   0.9996   137.2195
                0.0000   0.0000   0.0000     1.0000

$ mri_info ../../../sub-01/ses-test/anat/sub-01_ses-test_T1w.nii.gz
Volume information for ../../../sub-01/ses-test/anat/sub-01_ses-test_T1w.nii.gz
          type: nii
    dimensions: 256 x 156 x 256
   voxel sizes: 1.000000, 1.299376, 1.000000
          type: FLOAT (3)
           fov: 256.000
           dof: 0
        xstart: -128.0, xend: 128.0
        ystart: -101.4, yend: 101.4
        zstart: -128.0, zend: 128.0
            TR: 9.67 msec, TE: 0.00 msec, TI: 0.00 msec, flip angle: 0.00 degrees
       nframes: 1
       PhEncDir: UNKNOWN
       FieldStrength: 0.000000
ras xform present
    xform info: x_r =   0.9991, y_r =  -0.0397, z_r =   0.0125, c_r =     0.1996
              : x_a =   0.0408, y_a =   0.9943, z_a =  -0.0981, c_a =    20.3043
              : x_s =  -0.0085, y_s =   0.0985, z_s =   0.9951, c_s =   -41.2883
Orientation   : RAS
Primary Slice Direction: axial

voxel to ras transform:
                0.9991  -0.0516   0.0125  -125.2639
                0.0408   1.2920  -0.0981   -73.1330
               -0.0085   0.1280   0.9951  -177.5543
                0.0000   0.0000   0.0000     1.0000

voxel-to-ras determinant 1.29938

ras to voxel transform:
                0.9991   0.0408  -0.0085   126.6200
               -0.0306   0.7652   0.0758    65.5996
                0.0125  -0.0981   0.9951   171.0755
                0.0000   0.0000   0.0000     1.0000

To clarify, the conform step only modifies the affine if there are multiple images with different dimensions/zooms. This is a necessary precondition to merging, and the only way to avoid it is to have two images in the same space, or remove one of the T1w images before running FMRIPREP.
If it would be useful to have the transform matrix from the inputs T1w images to the T1w_preproc image, it looks like the transform for the conform step is just:
transform_affine = np.dot(linalg.inv(T1w.affine), T1w_preproc.target_affine)

mri_robust_template can be made to output the transforms for the final merge step, which can be combined with the conform transforms to get the total transform.

@satra it seems that the conform step is unavoidable in multi T1w. Is there a need for providing affine matrices going from original to conformed images?

@chrisfilo - perhaps fmriprep should be just annotated to indicate that T1_preproc and any of the raw T1s are not in alignment.  i'm ok with not needing them.

I believe this is only the case when there are multiple T1w images. The reports should provide this information now.

Tagged this with documentation. I think a comprehensive review of the docs would be good, to make sure concepts like this are clear without too much digging.

As usual, @satra foresaw back on July 30 that we would find that many tools mess up with affines on October 8 and reported it here.
Now, acknowledging that wrong affines were the source of #710 and #708 I think we can close this issue. #743 should fix this.
However, since this is a really delicate issue, I'll make sure we double check on all affines we produce in #745 and we add the appropriate documentation.

Just a quick point: This is about the T1w affines changing, not the alignment issues we've just been dealing with. #726 is a response to that, but we hadn't settled on an ultimate solution there.

https://github.com/poldracklab/niworkflows/pull/202#discussion_r143377806
I think this falls in category 1: when we are "moving" within the same space (in this case, identity transform), the output should have the same affine as the input (even if it is originally wrong).
We probably want to make these policies very clear in the documentation, following what you were suggesting since the beginning.

I might be misunderstanding the point you're making, but it sounds like you're saying the transform from input T1w images to the final T1w image should be the identity and that Satra was reporting an error. We can't always stay in the same space with multiple T1w images. If they're differently shaped or at all misaligned, constructing the template requires reslicing, rigid motion, or both.

Oh right, this issue really popped up because we had several T1w images. You are right: this problem would not be covered by those two categories. I'll add this as a 3rd category.


Deprecate the "operationName" property and move to "kind"

Resolves #1005
Summary
It's currently tricky to differentiate between the urql-specific Operation.operationName property, and the more general OperationDefinitionNode.name.value property. This PR deprecates the "operationName" property in favor of "kind", issues a warning the first time the deprecated property is accessed, and updates all exchanges.
Set of changes

Added packages/core/src/utils/deprecation.ts - a utility for issuing deprecation warnings only once.
Added packages/core/src/utils/operation.ts with makeOperation - a utility for creating Operation objects with a getter/setter for the operationName property that issues a deprecation warning.
Updated packages/core/src/client.ts to use makeOperation and move property references from "operationName" to "kind".
Updated the core cache, dedup, fallback, fetch, ssr, and subscription exchanges to move references from "operationName" to "kind".
Updated references in the exchanges packages.

Let's figure out when we want to release this 🤔 I don't expect anyone to have any major issues with this change, since it won't be breaking unless someone does something absolutely weird, but it's worth double checking.

Update: I loaded the sandbox as a quick smoke test and it all seems to work fine but it is triggering the warning, which is odd. https://codesandbox.io/s/urql-issue-template-client-forked-nsrde


Fixes Ansible Vagrant for CoreOS

Previously, Vagrant would not properly set the box download
url:
kube-node-1: Downloading: https://storage.googleapis.com/
.release.core-os.net/amd64-usr//coreos_production_vagrant.json
An error occurred while downloading the remote file. The error
message, if any, is reproduced below. Please fix this error and
try again.
The requested URL returned error: 400 Bad Request
This commit properly sets the coreos update_channel
and image_version variables.

cc @rutsky @stephenrlouie

Looks like images were cached on my machine.
LGTM, thanks @danehans!


Update tc_gen_codechef.py

Solved a small compilation error
Checklist:

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] Have you successfully ran tests with your changes locally?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?

Issues Solved
Fixes #{Issue Number}

There is an option to close PR.
USE THAT.


[WIP] Fix mozilla/thimble.mozilla.org#889: Remove root folder thimble-project if exists

The user is now able to export and import a zipped project without creating redundant folders (As first described here: mozilla/thimble.mozilla.org#889).
Because ArchiveUtils.js is being changed by @humphd, I've added the [WIP] in the title. Once his PR lands, I'll make the necessary changes 👍

I did a rebase on my code and I've added the changes you asked for. Going to file a new issue for the string you asked.

@simon66 you still finishing this?

I'm finishing this in https://github.com/mozilla/brackets/pull/789


Handle installation when subscription expired

Check system registration and subscription status
Remove repositories and install unrestricted repo
packages if subscription is not active

Code independent comment because I think there is some confusion. Process steps in pseudo code:

check registration status (SUSEConnect -s)
if registered and active

check_has_services (not part of the "check registration status" implementation)
if no services

restore services

nothing to do
check has public cloud module

if has public cloud module -> nothing to do
else enable the public cloud module

else

setup unrestricted repo


Fix typo in rule 'id' field

GitLeaks v8.19.x validates that rule IDs are not blank or null. (IDs are necessary for certain logic.)
Per https://github.com/gitleaks/gitleaks/issues/1507, this change has unintentionally caused some failures for people using your Azure DevOps extension due to a typo in the config.

Hi @rgmz thank you for the PR. I've merged it with my working branch and also updated the gitleaks config file. The error is fixed now. Thank you for sorting this out. I will close the PR since I've merged it with my working branch.
Still, I want to get rid of the customised toml file for the credscan replacement

Still, I want to get rid of the customised toml file for the credscan replacement

IMO most of these could be moved into the core GitLeaks config, however, each rule needs keywords + some tests cases (ideally).
I could look at them if I have free time but I don't have good test cases.

Hi, @JoostVoskuil. Thanks for your work! Should I reinstall extension, or clear some folders, or whatever as I still has this error:
Querying Gitleaks Latest Release GitHub Page.
The latest version of the tool is available in the toolcache. Version is 8.19.2
Found tool in cache: gitleaks 8.19.2 x64
C:\agent\_work\_tool\gitleaks\8.19.2\x64\gitleaks.exe detect --config=C:\agent\_work\_tasks\Gitleaks_11bd67d8-bfe7-497b-967d-e800eb673119\2.9.0\configs\GitleaksUdmCombo.toml --source=C:\agent\_work\4\s "--log-opts=0b3d30e42eea0823efde705f2aa09371614fe285^! 8c36b3057cdc27890be057d5f8492b61ff548798" --redact --report-format=sarif --report-path=C:\agent\_work\_temp\gitleaks-report-275f1d19-1bd8-5591-b06b-07d489ea915a.sarif --verbose --exit-code=99

    ○
    │╲
    │ ○
    ○ ░
    ░    gitleaks

3:00PM FTL Failed to load config error="rule |id| is missing or empty, regex: (?i)(?:AccessToken|pat|token).*?[':=\"][a-z0-9/+]{70}==(?:'|\"|\\s|[\\r?\\n]+)"

This is private agent that is not recycled after each build.

What version of the task do you see? It should be 2.10.*

No, it's 2.9.0. How to update?

@FixRM can you start a new pipeline run? So no rerun of a stage or job

New version was downloaded, thank you

New version was downloaded, thank you

Great to hear. When you re-run your job/stage the jobs are executed with the exact same task versions and variables. That is the reason it didn't work.


Handle no matching dimension found for volume billing

Add a new NoMatchingVolumeDimensionError that will be raised if no matching dimension is found by get_volume_dimensions(). This is a subclass of the CSPBillingAdapterException.
Add support for catching the CSPBillingAdapterException in the main() routine.
Add a "broken" config, config_broken_dimensions.yaml, in tests/data that is used by the new test_get_volume_dimensions_invalid() test to validate that no matching volume dimension issues are being handled appropriately.
Remove a debug print() that should have been removed previously.
Fix copy-n-paste error in comment in test_main()

@smarlowucf I'm happy to change the exception names, string format, etc, if desired.


VSCode tooltips interfere with new_window_takes_over_fullscreen

Hyprland Version
Hyprland, built from branch  at commit 5b8cfdf2efc44106b61e60c642fd964823fd89f3  ().
Bug or Regression?
Bug
Description
Setting misc:new_window_takes_over_fullscreen = [1|2] leads to weird behaviour when fullscreening VSCode.
Any tooltip (e.g. hovering over a filename in the Explorer sidebar either makes the tooltip fullscreen (for misc:new_window_takes_over_fullscreen = 1) or un-fullscreens vscode (for misc:new_window_takes_over_fullscreen = 2).
IMO tooltips should be excluded/ ignored by this setting.
How to reproduce

Switch VSCode to fullscreen
Click on the Explorer view icon
Hover mouse over any filename and wait for tooltip to pop-up

Crash reports, logs, images, videos
No response

is it running under native wayland?

According to hyprctl clients it's using xwayland

don't forget xwayland is compatibility layer
vscode can be run in native wayland mode
https://wiki.hyprland.org/Getting-Started/Master-Tutorial/#force-apps-to-use-wayland
(it will probably crash due to https://github.com/microsoft/vscode/issues/184124 but you can get around it)

I think I fixed that in -git like 2 days ago

I think I fixed that in -git like 2 days ago

I wasnt able to pin-point the exact commit, which one is it?
Sadly testing against commit ab5497a triggers https://github.com/wez/wezterm/issues/4483 for me, creating a bigger issue than I had before.

don't use wezterm then, use a better terminal, problem solved


feat: in app messaging notification

Description of changes

in app messaging feature
-- adds a new channel for in app messaging
-- changes the place for pinpoint resource to always stay in the analytics category
-- ensures auth and analytics are added as a pre-requirement for the notifications channels
-- notification channels re-use the pinpoint resource from the analytics category

Description of how you validated changes

manual tests
cloud-e2e pass
e2e tests and unit test added for in-app-messaging channel

Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #11067 (50fa878) into dev (e4593c4) will decrease coverage by 0.75%.
The diff coverage is 39.17%.

@@            Coverage Diff             @@
##              dev   #11067      +/-   ##
==========================================
- Coverage   49.63%   48.88%   -0.76%
==========================================
  Files         666      681      +15
  Lines       31910    33067    +1157
  Branches     6496     6766     +270
==========================================
+ Hits        15840    16164     +324
- Misses      14590    15420     +830
- Partials     1480     1483       +3

Impacted Files
Coverage Δ

...s/amplify-cli-core/src/errors/amplify-exception.ts
80.00% <ø> (ø)

packages/amplify-category-auth/src/index.js
16.27% <14.28%> (-0.05%)
:arrow_down:

...fy-category-notifications/src/multi-env-manager.ts
10.62% <15.38%> (ø)

...egory-notifications/src/multi-env-manager-utils.ts
16.12% <16.12%> (ø)

...otifications/src/notifications-amplify-meta-api.ts
16.66% <16.66%> (ø)

...fy-category-notifications/src/notifications-api.ts
19.29% <19.29%> (ø)

.../amplify-category-notifications/src/auth-helper.ts
21.83% <20.00%> (ø)

...notifications/src/notifications-backend-cfg-api.ts
20.00% <20.00%> (ø)

...y-provider-awscloudformation/src/push-resources.ts
19.58% <20.00%> (+<0.01%)
:arrow_up:

...lify-category-notifications/src/pinpoint-helper.ts
19.09% <22.22%> (ø)

... and 27 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

going to address the remaining nits as part of the analytics migration PR: https://github.com/aws-amplify/amplify-cli/pull/11158


wierd classification score

When iterating over array of images and classifying each one i get prediction scores like:
[
  { class: 'apple', score: 1 },
  { class: 'banana', score: 5.249882195634825e-10 }
]

is this a know issue?
can provide full code if needed

Hey @newusernamenewusername11,
Thank you very much for reporting this, but this is not exactly an issue :)
Regular numbers in JavaScript are stored in 64-bit format IEEE-754, also known as “double precision floating point numbers”.
In your case "5.249882195634825e-10" is something like: 0.000000000524988219563482516605290584266185760498046875000...0
you can check it in your web console with: Number("5.249882195634825e-10").toFixed(100)
We should return the exact score and this way you can do whatever you need with it.
Hope this will help you!
Any other feedback will be much appreciated! :)


AQL: DATE_TIMEZONE(S)

Scope & Purpose
New features for #12646
Need to generate dropdowns for all timezones - current server timezone for sensible default.

Added DATE_TIMEZONE - returns server timezone
Added DATA_TIMEZONES - returns all timezones
updated tzdata to 2020f
removed obsolete tzdata files
updated windowsZones.xml

[ ] :hankey: Bugfix (requires CHANGELOG entry)
[x] :pizza: New feature (requires CHANGELOG entry, feature documentation and release notes)
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification
[ ] :book: CHANGELOG entry made

TBD:

Naming of the functions:

Although not accepting date values I prefixed them with DATE_ prefix to categorize the together with the other timezone features
Alternative suggestions: TIMEZONE_CURRENT(), TZ_CURRENT(), TIMEZONE_LIST(), TZ_LIST()

Better tests

DATE_TIMEZONE() - can't know server timezone?
DATE_TIMETONES() - atleast contain Berlin / NewYork / Shanghai?

Backports:

[ ] No backports required
[ ] Backports required for: (Please specify versions and link PRs)

Related Information

[ ] Docs PR:
[ ] Enterprise PR:
[ ] GitHub issue / Jira ticket number:
[ ] Design document:

Testing & Verification

[ ] This change is a trivial rework / code cleanup without any test coverage.
[x] The behavior in this PR was manually tested
[ ] This change is already covered by existing tests, such as (please describe tests).
[x] This PR adds tests that were used to verify all changes:

[ ] Added new C++ Unit tests
[x] Added new integration tests (e.g. in shell_server / shell_server_aql)
[ ] Added new resilience tests (only if the feature is impacted by failovers)

[ ] There are tests in an external testing repository:
[ ] I ensured this code runs with ASan / TSan or other static verification tools

Documentation

All new features should be accompanied by corresponding documentation.
Bugs and features should furthermore be documented in the CHANGELOG so that
support, end users, and other developers have a concise overview.

[ ] Added entry to Release Notes
[ ] Added a new section in the Manual
[ ] Added a new section in the HTTP API
[ ] Added Swagger examples for the HTTP API
[x] Updated license information in LICENSES-OTHER-COMPONENTS.md for 3rd party libraries

I'll write the docs once this is approved
External contributors / CLA Note
CLA see #12646

Quick question:
Looking at https://en.wikipedia.org/wiki/List_of_tz_database_time_zones would you expect DATE_TIMEZONES() to:

return all canonical timezones
return all canonical, aliases and deprecated timezones
just include a parameter to choose - note deprecated canonicals can be filtered easily - deprecated aliases cannot

I'm happy with just the canonical ones, exluding deprecated (with the "/" filter), however others might need all aliases
for (auto& zone : db.zones) {
  // filter deprecated zones
  if (zone.name().find("/") == std::string::npos) {
    continue;
  }
  result->add(VPackValue(zone.name()));
}

// include aliases
for (auto& link : db.links) {
  result->add(VPackValue(link.name()));
}

Quick question:
Looking at https://en.wikipedia.org/wiki/List_of_tz_database_time_zones would you expect DATE_TIMEZONES() to:

return all canonical timezones
return all canonical, aliases and deprecated timezones
just include a parameter to choose - note deprecated canonicals can be filtered easily - deprecated aliases cannot

I'm happy with just the canonical ones, exluding deprecated (with the "/" filter), however others might need all aliases
for (auto& zone : db.zones) {
  // filter deprecated zones
  if (zone.name().find("/") == std::string::npos) {
    continue;
  }
  result->add(VPackValue(zone.name()));
}

// include aliases
for (auto& link : db.links) {
  result->add(VPackValue(link.name()));
}

Thanks for all the work so far!
I moved this into a different PR so we can run the changes in our CI:
https://github.com/arangodb/arangodb/pull/13320
I preserved all your original commits, fixed a remaining issue with jslint and fixed a few whitespace inconsistencies in the tests. The tests already worked locally, so I am positive our Jenkins will also like it.

Thanks for all the work so far!
I moved this into a different PR so we can run the changes in our CI:
https://github.com/arangodb/arangodb/pull/13320
I preserved all your original commits, fixed a remaining issue with jslint and fixed a few whitespace inconsistencies in the tests. The tests already worked locally, so I am positive our Jenkins will also like it.

k thanks,
couldn't get tests to run with WSL2 nor allow-external-process-control true

k thanks,
couldn't get tests to run with WSL2 nor allow-external-process-control true

Closing in favor of https://github.com/arangodb/arangodb/pull/13320
Many thanks again!

Closing in favor of https://github.com/arangodb/arangodb/pull/13320
Many thanks again!

hm, I'm seeing this error while running it inside a docker container on ARM:
    [FAILED]  tests/js/server/aql/aql-functions-date.js

      "testDateTimeZone" failed: Error: at assertion #1: assertEqual: (Etc/UTC) is not equal to (UTC)
(Error
    at assertEqual (/home/ec2-user/arangodb/js/common/modules/jsunity/jsunity.js:108:19)
    at Object.testDateTimeZone (tests/js/server/aql/aql-functions-date.js:2475:9)

its probably part of the functionality added by this PR?
    // //////////////////////////////////////////////////////////////////////////////
    // / @brief test date_timezone
    // //////////////////////////////////////////////////////////////////////////////

    testDateTimeZone: function () {
      let systemtz = null;
      let res = getQueryResults("RETURN DATE_TIMEZONE()", {})[0];

      try {
        systemtz = Intl.DateTimeFormat().resolvedOptions().timeZone;
      } catch (err) {
      }

      if (systemtz) {
        assertEqual(systemtz, res);
      } else {
        assertNotNull(res);
      }
    },

can you have a look @coronabytes whether you can make sure the test also passes under these conditions?

hm, I'm seeing this error while running it inside a docker container on ARM:
    [FAILED]  tests/js/server/aql/aql-functions-date.js

      "testDateTimeZone" failed: Error: at assertion #1: assertEqual: (Etc/UTC) is not equal to (UTC)
(Error
    at assertEqual (/home/ec2-user/arangodb/js/common/modules/jsunity/jsunity.js:108:19)
    at Object.testDateTimeZone (tests/js/server/aql/aql-functions-date.js:2475:9)

its probably part of the functionality added by this PR?
    // //////////////////////////////////////////////////////////////////////////////
    // / @brief test date_timezone
    // //////////////////////////////////////////////////////////////////////////////

    testDateTimeZone: function () {
      let systemtz = null;
      let res = getQueryResults("RETURN DATE_TIMEZONE()", {})[0];

      try {
        systemtz = Intl.DateTimeFormat().resolvedOptions().timeZone;
      } catch (err) {
      }

      if (systemtz) {
        assertEqual(systemtz, res);
      } else {
        assertNotNull(res);
      }
    },

can you have a look @coronabytes whether you can make sure the test also passes under these conditions?

well the test is quite hacky, since we don't have the exact same way on getting the system timezone, but the only way to fix this reasonably is.
if (systemtz === "UTC") {
 systemtz = "Etc/UTC"
}

well the test is quite hacky, since we don't have the exact same way on getting the system timezone, but the only way to fix this reasonably is.
if (systemtz === "UTC") {
 systemtz = "Etc/UTC"
}

yes, these were GCC-buildroots.
Can you create a PR with this workaround? Which is the modern one? Etc/ ?

yes, these were GCC-buildroots.
Can you create a PR with this workaround? Which is the modern one? Etc/ ?

@dothebart
done #13393,
Etc/UTC is the canonical one, thus prefered.
Now when testing on really old systems with legacy os timezone, like SystemV this will still fail
only option then is to just check if result is not NULL...
and only test that the function does not crash

@dothebart
done #13393,
Etc/UTC is the canonical one, thus prefered.
Now when testing on really old systems with legacy os timezone, like SystemV this will still fail
only option then is to just check if result is not NULL...
and only test that the function does not crash


Pdf signatures

Hi,
I have a signed PDF which renders perfectly on IOS, but on Android the signature fields are not visible.
Please help, BR

same issue

any idea?

This issue has been fixed on nbrg_pdf_viewer_flutter


A way to attach a data attribute to circles that can be extracted on click

Is there a way to do this?
My second request would be for a way to vertically stack multiple events that occur on the same day.  Great library though :)

I want to show a custom modal upon a click event on a timeline event.


It'll be 2022 soon

The solutions i saw on SO were pretty sketchy, like a dynamic SVG or something.

I wonder if shields.io has something for this, we've already accepted it into the fold..


Logs have only sourcetype of pan:log

We have integrated Pan sources with Splunk via syslog-ng. Until 01/11/24 the sourcetypes the parsing into sourcetypes  pan:traffic, pan:threat, pan:system, pan:config was working fine. But, later all logs are found under pan_log.

Version of add-on on Indexer used: 7.0.4

Was anything changed on the syslog-ng side? Could you please provide a sample of the logs before and after. Please don't include any sensitive data.


A question about using this with WebGL2 and TWGL

Hello, first of all thank you very much for your work. I was looking for a not too complicated atmosphere for my thesis project, and although I watched Sebastian Lague's video, I did not really have time to port his C# implementation to JS and WebGL2. Thank you for doing this.
Now, I am having some issues adapting your work into my project, and I was wondering whether you might have some quick ideas of what could be wrong by looking at the parameters I use and some screenshots. I should say that my project doesn't use an engine like Babylon, only WebGL2 and TWGL, which is a small helper that shortens some WebGL2 boilerplate code. I therefore create a depth texture after rendering the model onto a framebuffer and give that to your shader.
The relevant parameters I'm using are:
atmosphereRadius: 84.78635437881874
planetRadius: 83.47610319076715
falloffFactor     : 1
sunIntensity      : 15
scatteringStrength: 1
densityModifier   : 1
redWaveLength     : 700
greenWaveLength   : 530
blueWaveLength    : 440
planetPosition:

0: 9.588249999999999
1: 46.7641
2: -83.47610319076715
cameraFar: 100
cameraNear: 0.0001
textureSampler: colorTexture,
depthSampler: depthTexture,

The planet position is calculated with real life Earth sizes mapped to the coordinate system of the world model. I have a small region of the earth as model at approx coordinates (9.5, 46.7, 0) so I thought to form the atmosphere underneath it by placing the planetPosition at those coordinates - planetRadius (at scale of the world model coordinates). These are some pictures of the result:

Thank you in advance for your time and any help you can give me :)

Hey there! Thanks for using this project ;)
I think you are having an issue with the depth texture. My shader assumes it has been linearized, but without an engine you are probably using the non-linear depth.
In that cas you would have to do some changes to get the proper world position of each of your pixels by creating the clip space position with the uv and depth information and use the inverse projection and view matrices to find the world position.
The other solution is of course to linearize the depth texture, but that seems more work (Babylon is doing it for me here)

Thank you for the blazingly fast reply. This one liner by chatgpt to linearize each depth sample indeed made the atmosphere look much better with the same parameters: (2.0 * cameraNear * cameraFar) / (cameraFar + cameraNear - z_depth * (cameraFar - cameraNear))

I suppose I just have to find the right parameterization now to make it look as close to reality as possible. Thank you very much!

I checked as well, and your formula is correct given that you remapped the texture depth (between 0 and 1) to WebGL NDC depth (between -1 and 1)

Thank you so much!
On Tuesday, July 23rd, 2024 at 19:04, Barthélemy Paléologue @.***> wrote:

I checked as well, and your formula is correct given that you remapped the texture depth (between 0 and 1) to WebGL NDC depth (between -1 and 1)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.Message ID: @.***>


windows release shortcut icon is too small

run hover build windows-msi --docker
install
the shortcut icon look blurred

i see the command is
/bin/bash -c convert -resize x16 build/assets/icon.png build/assets/icon.ico && wixl -v ......
is it too small of x16

You are using an old version of hover. Please update and then the icon has the same size as your png in the assets.


[IMPROVE] Custom 'Guest' Avatar setting

This is likely a change that needs to happen in the RC core, in which case please use the develop_livechat branch for widechat
Currently when unregistered guests start to chat, they are assigned a name 'guest-1234' and their icon shows up as 'G'.
Add a setting to livechat where we can set a guest's default icon

@dlassalle Currently the guest avatar are not in sync, the avatar on RC is based on username, while the avatar on livechat is based on name(if name is null then username), how should be the behaviour of custom guest avatar be like, in that case.


Fix SYCL math builtin ambiguity

Existing Sample Changes
Description
SYCL math builtins may cause ambiguity issues with std versions of the same builtins if it is not qualified by its namespace. This commit addresses this issue in select samples.
External Dependencies
None
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Implement fixes for ONSAM Jiras

How Has This Been Tested?
As specified in the sample directories.

[X] Command Line
[ ] oneapi-cli
[ ] Visual Studio
[ ] Eclipse IDE
[ ] VSCode
[ ] When compiling the compliler flag "-Wall -Wformat-security -Werror=format-security" was used

@steffenlarsen Can you submit this to the development branch?

@jimmytwei - Sure! See https://github.com/oneapi-src/oneAPI-samples/pull/2290.


Crash of numpy in ubuntu

Description
What steps will reproduce the problem?

Importing an image
Running a convolution

What is the expected output? What do you see instead?
Please provide any additional information below
File "/home/vangjush/.local/lib/python2.7/site-packages/spyder/plugins/ipythonconsole.py", line 906, in
clear_variables))
File "/home/vangjush/.local/lib/python2.7/site-packages/spyder/plugins/ipythonconsole.py", line 948, in execute_code
sw.sig_prompt_ready.disconnect()
TypeError: disconnect() failed between 'sig_prompt_ready' and all its connections
Version and main components

Spyder Version: 3.2.4
Python Version: 2.7.14
Qt Versions: 5.9.1, PyQt5 5.7 on Linux

Dependencies
pyflakes >=0.5.0  :  1.6.0 (OK)
pycodestyle >=2.3 :  2.3.1 (OK)
pygments >=2.0    :  2.2.0 (OK)
pandas >=0.13.1   :  0.20.3 (OK)
numpy >=1.7       :  1.13.3 (OK)
sphinx >=0.6.6    :  1.6.5 (OK)
rope >=0.9.4      :  0.10.7 (OK)
jedi >=0.9.0      :  0.11.0 (OK)
psutil >=0.3      :  5.4.0 (OK)
nbconvert >=4.0   :  5.3.1 (OK)
sympy >=0.7.3     :  1.1.1 (OK)
cython >=0.21     :  None (NOK)
qtconsole >=4.2.0 :  4.3.1 (OK)
IPython >=4.0;<6.0:  5.5.0 (OK)
pylint >=0.25     :  1.7.4 (OK)

It's the same error as the one you just reported. Please don't open more error about it.
Until we fix, you can avoid using dedicated consoles or downgrade to Spyder 3.2.3.


[BUG] Unable to use Weave with a Genie server

description
I'm trying to run this weave example on a Genie.jl server. However, it seems to block for some reason and not progress at all after a point. I can't even seem to Ctrl+C/Ctrl+D quit the process either.
htop tells me that the julia process is still using my system resources though.
I also seem to be able to run the weave example normally from a REPL. Could someone help me figure out what's going on here and how I could fix this?
versions

using InteractiveUtils; versioninfo():

Julia Version 1.7.0-beta4
Commit d0c90f37ba (2021-08-24 12:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
  CPU: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, skylake)

using Pkg; Pkg.status():

julia> using Pkg; Pkg.status()
  [717857b8] DSP v0.7.3
  [c43c736e] Genie v3.0.0
  [cd3eb016] HTTP v0.9.14
  [1dea7af3] OrdinaryDiffEq v5.55.1
  [91a5bcdd] Plots v1.22.1
  [44d3d7a6] Weave v0.10.10
  [9a3f8284] Random
  [8dfed614] Test

minimum reproducible steps

Download the Weave example (name it, say, x.jmd)
Create an environment with Genie, Weave and HTTP added as dependencies.
Run -

using Weave
using Genie, Genie.Router, Genie.Renderer.Json, Genie.Requests
using HTTP

route("/weave") do
    weave("x.jmd"; out_path=:pwd)
    return
end

Genie.startup(async = false)

Open up your browser and go to localhost:8080
Keep an eye on the Genie server running, to see the block and non-responsiveness happen in real-time.

I opened this as a separate issue because I didn't know if there were any issues with running Weave on a Genie server.
Related #310, #436.


[FHG-5615] Accepted connection requests

Should this PR go into a release-kpi-report-connection-requests-accepted release branch instead?


Replace winston logger

Replace winston logger 3.0-rc as it's unstable.　https://github.com/bitrinjani/r2/issues/14#issuecomment-353502767
Candidate:

pino https://github.com/pinojs/pino
bunyan https://github.com/trentm/node-bunyan
npmlog https://github.com/npm/npmlog

https://github.com/bitrinjani/r2/pull/20


Adding a 'how to use' section to README.md

This PR adds a "how to use" section to the top-level README, such that people know how to work with ifs-reader/dump-decls.
Signed-off-by: Andrew V. Jones<EMAIL_ADDRESS>

I've just realised that this needs to be updated to use moo.ifc.d.json, because I wrote this using #9, which is slightly more flexible.


Add instructions for installing with deb-get

Summary
Add instructions for installing mattermost desktop (on Ubuntu or Debian based distros) with deb-get, a package manager similar to Winget on Windows. Deb-get installs the official Mattermost Desktop deb from Github releases, and allows for updating it using the "deb-get update" command.
This PR is part of a mini-hacktoberfest event put on by the deb-get team

Hello @kd2flz,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

Thank you, @kd2flz! Please let us know once you've signed the CLA so we can review your PR. :)

/check-cla

@kd2flz Thank you so much for developing good documentation for the deb-get package manager. Because deb-get isn't officially supported, we won't be able to move forward with your PR.
However, I strongly encourage you to post these great details in the Mattermost User Forum that will reach a broad audience.


eachlineV omits final line

test.txt:
hello
my
name is
bob

test.jl:
using ViewReader

@info "eachlineV:"
for line in eachlineV("test.txt")
    @show line
end

@info "eachline:"
for line in eachline("test.txt")
    @show line
end

REPL:
julia> include("test.jl")
[ Info: eachlineV:
line = "hello"
line = "my"
line = "name is"
[ Info: eachline:
line = "hello"
line = "my"
line = "name is"
line = "bob"

julia> versioninfo()
Julia Version 1.10.0
Commit 3120989f39b (2023-12-25 18:01 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 16 × AMD Ryzen 9 5900HS with Radeon Graphics
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
  Threads: 1 on 16 virtual cores

I can't replicate this on Julia 1.10 either.
[ Info: eachlineV:
line = "hello"
line = "my"
line = "name is"
line = "bob"

[ Info: eachline:
line = "hello"
line = "my"
line = "name is"
line = "bob"

On my machine
Julia Version 1.10.0
Commit 3120989f39b (2023-12-25 18:01 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 8 × 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, tigerlake)
  Threads: 1 on 8 virtual cores

Hi @rickbeeloo, thanks for looking into this. The problem happened across multiple files (all files as far as I could tell, but I didn’t check diligently). I’ll poke around and see if I can find any exceptions on this or my other computer.

Is it possible your test file had a trailing newline? If I put a trailing newline in, all the lines get parsed fine.

It indeed is because there is no trailing newline.
The fix is quite easy, still return the slice of the buffer if there are non zero bytes after the last returned line.
Has been 9 months since I wrote a Julia script so gonna do my best :)


Make the version compatible with Ren'Py 7.4.0 backward compatible with Ren'Py 7.3.5

Closing as backward compatibility is unlikely. Ren'Py 7.3.5 exits with the following error, which is related to Ren'Py's build issues:
Could not find platform independent libraries <prefix>
Could not find platform dependent libraries <exec_prefix>
Consider setting $PYTHONHOME to <prefix>[:<exec_prefix>]
ImportError: No module named site

Closing as backward compatibility is unlikely. Ren'Py 7.3.5 exits with the following error, which is related to Ren'Py's build issues:
Could not find platform independent libraries <prefix>
Could not find platform dependent libraries <exec_prefix>
Consider setting $PYTHONHOME to <prefix>[:<exec_prefix>]
ImportError: No module named site


Release azure-cli-consumption 0.1.2

This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines

[ ] The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

[ ] Each command and parameter has a meaningful description.
[ ] Each new command has a test.

(see Authoring Command Modules)

Reviewers, please verify the following for this PR:

[ ] The PR title has format Release <component-name> <version>.
[ ] setup.py has been modified with the same version as in the PR title.
[ ] HISTORY.rst has been modified with appropriate release notes.
[ ] If releasing azure-cli or azure-cli-core, __version__ defined in __init__.py should also be modified to match.

Started releasing azure-cli-consumption 0.1.2...

Release of 'azure-cli-consumption' with version '0.1.2' successful. View at https://pypi.python.org/pypi/azure-cli-consumption/0.1.2.

GitHub release created. https://github.com/Azure/azure-cli/releases.

Codecov Report

Merging #3812 into master will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3812      +/-   ##
==========================================
+ Coverage   70.75%   70.91%   +0.16%
==========================================
  Files         424      424
  Lines       26895    26895
  Branches     4094     4094
==========================================
+ Hits        19029    19073      +44
+ Misses       6621     6578      -43
+ Partials     1245     1244       -1

Impacted Files
Coverage Δ

src/azure-cli-core/azure/cli/core/prompting.py
19.27% <0%> (ø)
:arrow_up:

...ice/azure/cli/command_modules/appservice/custom.py
73.46% <0%> (+0.24%)
:arrow_up:

...zure-cli-vm/azure/cli/command_modules/vm/custom.py
77.01% <0%> (+0.31%)
:arrow_up:

...ource/azure/cli/command_modules/resource/custom.py
62.41% <0%> (+0.33%)
:arrow_up:

...cli-vm/azure/cli/command_modules/vm/_validators.py
75.59% <0%> (+0.33%)
:arrow_up:

...azure-cli-core/azure/cli/core/commands/__init__.py
69.79% <0%> (+0.44%)
:arrow_up:

.../azure/cli/command_modules/vm/_template_builder.py
85.78% <0%> (+0.49%)
:arrow_up:

...zure-cli-sf/azure/cli/command_modules/sf/custom.py
40.53% <0%> (+0.72%)
:arrow_up:

...re-cli-acr/azure/cli/command_modules/acr/_utils.py
82.82% <0%> (+1.01%)
:arrow_up:

...ure-cli-testsdk/azure/cli/testsdk/vcr_test_base.py
70.08% <0%> (+1.17%)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 460a9f4...09e0d44. Read the comment docs.


errors: captures error message fields in struct

closes Issue #44

Codecov Report
Base: 91.66% // Head: 91.66% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (be93380) compared to base (2dc9222).
Patch coverage: 96.96% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   91.66%   91.66%   -0.01%
==========================================
  Files          10       10
  Lines        2545     2542       -3
==========================================
- Hits         2333     2330       -3
  Misses        164      164
  Partials       48       48

Impacted Files
Coverage Δ

output.go
0.00% <0.00%> (ø)

errors.go
85.29% <100.00%> (+0.21%)
:arrow_up:

extension.go
14.81% <100.00%> (ø)

schema.go
98.69% <100.00%> (-0.01%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@santhosh-tekuri : What is need to land this diff? I can help.


[React v15] Accessing PropTypes via the main React package is deprecated

After upgrading to react 15.5.4 I'm getting these warnings in the browser console:

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.
warning.js:36 Warning: react-crouton: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.

hmm, i'll do an update to fix it.  But it should be fine with v15, since it will be remove from v16

1.0.0 is released to support `prop-types', closed.
Thank @larsmaultsby


bindings/python: Test failed for Fatal Python error: PyGILState_Release

https://github.com/apache/incubator-opendal/actions/runs/4480668361/jobs/7876306343
Took 0m0.004s
Fatal Python error: PyGILState_Release: thread state 0x7f44d4003280 must be current when releasing
Python runtime state: finalizing (tstate=0x00007f44db970258)

Thread 0x00007f44db0dbb80 (most recent call first):
  <no Python frame>
/home/runner/work/_temp/c6261849-b280-[41](https://github.com/apache/incubator-opendal/actions/runs/4480668361/jobs/7876306343#step:6:42)08-a933-ef0fdcb21[42](https://github.com/apache/incubator-opendal/actions/runs/4480668361/jobs/7876306343#step:6:43)4.sh: line 1:  7154 Aborted                 (core dumped) python -m behave tests

I'll have to reproduce it locally first.

Unable to reproduce it on Ubuntu 22.04 with while true; do .venv/bin/python -m behave tests || exit 1; done running for half an hour...

Does this relate to our python binding's workflow?
Seems we are not using the venv for testing.
https://github.com/apache/incubator-opendal/blob/cc8e489e76f5047b1df7e3c1240bb61ab4541caf/.github/workflows/bindings_python.yml#L42-L58

Venv just isolates packages, at runtime it's mostly the same.

The fatal error occurs when the Python interpreter was shutting down, so it maybe related to GC or even not our issue. (CPython can and does have bugs, lol)

The fatal error occurs when the Python interpreter was shutting down, so it maybe related to GC or even not our issue. (CPython can and does have bugs, lol)

Thank you for investigating. Let's close this issue until we have more information.

Another coredump:
Fatal Python error: PyGILState_Release: thread state 0x7f4b780034f0 must be current when releasing
Python runtime state: finalizing (tstate=0x00007f4b80445258)

Thread 0x00007f4b7fbb0c40 (most recent call first):
  <no Python frame>
/home/runner/work/_temp/b31de088-9046-45a5-8b43-b0427d1f2[38](https://github.com/apache/incubator-opendal/actions/runs/4587412840/jobs/8100898542#step:6:39)c.sh: line 1:  7117 Aborted                 (core dumped) python -m behave tests

https://github.com/apache/incubator-opendal/actions/runs/4587412840/jobs/8100898542


"utils2" is needed as an import but is not provided

Hello,
We are trying to test your model but can't because the import "utils2" is not provided. It is used e.g. in interactive_generation.py, line 22: from utils2 import model_utils, processor

@swidi thanks for the catch! It should be data_utils instead. I fixed some minor bugs as well, so please pull again.


check perf not work with ETCDCTL_ENDPOINTS

I set env ETCDCTL_ENDPOINTS, and when etcdctl perf check, I get
2017-10-09 10:43:35.347500 W | pkg/flags: recognized environment variable ETCDCTL_ENDPOINTS, but unused: shadowed by corresponding flag
2017-10-09 10:43:35.649254 W | pkg/flags: recognized environment variable ETCDCTL_ENDPOINTS, but unused: shadowed by corresponding flag
2017-10-09 10:43:35.955276 W | pkg/flags: recognized environment variable ETCDCTL_ENDPOINTS, but unused: shadowed by corresponding flag
2017-10-09 10:43:36.208232 W | pkg/flags: recognized environment variable ETCDCTL_ENDPOINTS, but unused: shadowed by corresponding flag
......

repeatly.
And this unset ETCDCTL_ENDPOINTS &&  etcdctl check perf --endpoints  example.com... works normally.

I set env ETCDCTL_ENDPOINTS, and when etcdctl perf check, I get

What's your full perf command to reproduce this?

etcdctl --user name:pwd

the command line outputs exactly what it does. both env and flag are set, and flag overwrites evn.

@xiang90 what flag do you mean?
With env ETCDCTL_ENDPOINTS set and command etcdctl --user name:pwd perf check executed, could you tell me what flag about endpoint is set?

@zyf0330 can you provide the full command the evn you provided to etcdctl? what is the version of etcdctl?

Env ETCDCTL_ENDPOINTS  set and command etcdctl --user name:pwd perf check are exactly full.
Etcdctl version I will append tomorrow.

if you do that, then etcdctl should call into version v2. why it calls into v3? there might be other stuff missing. we need your full configuration to reproduce.

I forgot, I also set env of version into 3.

@zyf0330 ok. cool. please provide use the version tomorrow. thank you.

It is 4afb99ffc

I can reproduce with master
ETCDCTL_ENDPOINTS=localhost:2381 ETCDCTL_API=3 etcdctl check perf --load=l
2017-10-10 19:24:28.176298 W | pkg/flags: recognized environment variable ETCDCTL_ENDPOINTS, but unused: shadowed by corresponding flag
2017-10-10 19:24:29.182844 W | pkg/flags: recognized environment variable ETCDCTL_ENDPOINTS, but unused: shadowed by corresponding flag


typescript-compatibility plugin is incompatible with operationResultSuffix config of main typescript plugin

Describe the bug
If you use the config option operationResultSuffix, typescript-compatibility will still reference types that do not have that provided suffix, thus referencing types that don't exist. For example, if you specify Result as the suffix, you'll get types generated like:
type GetFooQueryResult = { ... } // from typescript plugin
type GetFooName = GetFooQuery["name"] // from typescript-compatibility

To Reproduce
Steps to reproduce the behavior:

Specify any suffix for operationResultSuffix
Include the typescript-compatibility plugin

Expected behavior
The types generated by typescript-compatibility should include the suffix:
type GetFooName = GetFooQueryResult["name"]

Environment:

OS: Mac 11.4
@graphql-codegen/core: 1.17.0
@graphql-codegen/typescript: 1.23.0
@graphql-codegen/typescript-compatibility: 2.1.5
NodeJS: 14.16.1

Additional context

Hi @ericbiewener !
typescript-compatibility was intended for migration between v0 and v1 of codegen (~3 years ago).
We've just released v2 and this plugin is no longer maintained or actively developed.
I recommend to migrate to the new versions of codegen.


Adding Contribution guidelines and Security policy

Contribution: contains detailed description for making contributions to Yoma
Security: contains description for submitting reports about security bugs

@cameronolivier Yes he has. We discussed the outline of these documents.


licenses/ web page fails with 500 error

Accessing the licenses/ web page fails with a "500" error

yes noticed this few hrs ago
is it license/?
should it be changed to licenses/ ?
and individual license with licenses/<license-name>/ ?
changing from
https://github.com/nexB/scancode.io/blob/16644a60c6dbe81fa078fc6941fbd8be817fe935/scancodeio/urls.py#L53
to
path('licenses/', include(licenses.urls)),

works

PR?

@lf32 a better solution is to simply remove the "license_app" namespace during the registration at https://github.com/nexB/scancode.io/blob/main/scancodeio/urls.py#L53
Also, you new TestCase does not follow existing naming convention for tests:
Suggestions:

get_licenses_test -> test_license_list_view
get_license_details_test -> test_license_details_view

Lastly, the code is not properly formatted, make sure to run make valid before committing changes.


upup: Discover metadata on GCE instance

We simply weren't mapping it before, which was causing spurious changes.

cc @mikedanese


Plugin init

This PR introduces a few refactors to the Plugin and ModelSpec APIs:

Plugins are now required to have a 0-arg constructor, and are initialized via an init() method. A plugin that does not want to handle a particular model spec can return false from the init method, and it will be discarded. This replaces hasChangesForModelSpec() makes it easier/safer for a plugin to initialize its internal state outside of its constructor, and then only if it wants to.
Plugin itself is now an interface, with AbstractPlugin provided as a stub class to extend. This is intended to mirror how the Processor/AbstractProcessor API is designed.
ModelSpec and its associated subclasses are now constructed via a factory instead of directly (making their constructors hidden). Some business logic has been moved from the ModelSpec constructor into an initialize() method, which is called by the factory. This will make it easier to write better tests for model specs someday.
will/did naming scheme in plugin has been reverted to the old before/after naming scheme.

LGTM


Godot 3.5.2 skeleton crashes on 64bit but not 32 bit

Godot version
3.5.2.stable
System information
Window 10, family Intel, gles 2
Issue description
I have a character model I made in blender that gets exported to dae/escn/gltf2/fbx. When I open it in 64 bit it crashes Godot, but on ,32 bit it opens with 1 fps. On web version it runs fine. The character has a rigitfy skeleton with a simple model.
Steps to reproduce
Add a blender rigitfy skeleton only to Godot in 64bit in gles 2 or 32 bit
Minimal reproduction project
No files

@DennesTejada Please upload a minimal reproduction project to make this easier to troubleshoot.

[Crash]Skeleton.zip
here you go!

The archive seems to be corrupt (at least it won't open on my linux).

Same here, won't open

This one opens, thanks

The DAE seems to load fine.
The FBX isn't importing correctly, you can see this when you delete the .import folder which forces a reimport.
If you look in the output:
 modules/fbx/scu/../editor_scene_importer_fbx.cpp:172 - We don't officially support Blender FBX animations yet, due to issues with upstream Blender,
so please wait for us to work around remaining issues. We will continue to import the file but it may be broken.
For minimal breakage, please export FBX from Blender with -Z forward, and Y up.

and lots of:
 modules/fbx/scu/../editor_scene_importer_fbx.cpp:507 - [doc] Serious: maximum bone influences is 8 in this branch.
 modules/fbx/scu/../editor_scene_importer_fbx.cpp:507 - [doc] Serious: maximum bone influences is 8 in this branch.
 modules/fbx/scu/../editor_scene_importer_fbx.cpp:507 - [doc] Serious: maximum bone influences is 8 in this branch.
 modules/fbx/scu/../editor_scene_importer_fbx.cpp:507 - [doc] Serious: maximum bone influences is 8 in this branch.
 modules/fbx/scu/../editor_scene_importer_fbx.cpp:507 - [doc] Serious: maximum bone influences is 8 in this branch.
 modules/fbx/scu/../editor_scene_importer_fbx.cpp:507 - [doc] Serious: maximum bone influences is 8 in this branch.

So it looks like animation / rigged models is not supported in FBX in 3.x.

well it still crashes for me. Not sure why but thanks


bot.on without the slash

when i try to catch messages without the / like  bot.on('button',  (And not bot.on('/button'))   i don't catch it, does it only work with slashes or i'm missing something?
also on buttons on all the examples the buttons start with a slash probably for that same reason but it makes it look quite bad is there a way to drop the slashes?

ok got it if you do  /button/  it works (as expression)  but without the quotes


Link to API documentation in Readme is broken

Hi,
if I click on the link to the API documentation in the Readme, I end up in a Page Not Found
I think that is not intentional :)

Hi @johannes-vogel ,
thanks for the heads up;)
I fixed it.
Best regards,
Junjie


How to modify the ChatPromptTemplate used to make the graph extraction?

This prompt template is somehow sent through to OpenAI but there's no trace of it within the codebase, therefore making it impossible to modify the system and human message.
The only place where it appears is inside the .ipynb files of the experiments folder, but the get_extraction_chain function is also not imported into the code.
I want to make the prompt more specific, because the results I am getting at the moment are non-satisfactory.
I found that in the project's history, this prompt was available for anyone to modify, why change that ?
link
Anybody could help me out?
Knowledge Graph Instructions for GPT-4
          ## 1.
          Try to capture as much information from the text as possible without sacrificing accuracy. Do not add any information that is not explicitly mentioned in the text.
          - **Nodes** represent entities and concepts.
          - The aim is to achieve simplicity and clarity in the knowledge graph, making it
          accessible for a vast audience.
          ## 2. Labeling Nodes
          - **Consistency**: Ensure you use available types for node labels.
          Ensure you use basic or elementary types for node labels.
          - For example, when you identify an entity representing a person, always label it as **'person'**. Avoid using more specific terms like 'mathematician' or 'scientist'.- **Node IDs**: Never utilize integers as node IDs. Node IDs should be names or human-readable identifiers found in the text.
          - **Relationships** represent connections between entities or concepts.
          Ensure consistency and generality in relationship types when constructing knowledge graphs. Instead of using specific and momentary types such as 'BECAME_PROFESSOR', use more general and timeless relationship types like 'PROFESSOR'. Make sure to use general and timeless relationship types!
          ## 3. Coreference Resolution
          - **Maintain Entity Consistency**: When extracting entities, it's vital to ensure consistency.
          If an entity, such as "John Doe", is mentioned multiple times in the text but is referred to by different names or pronouns (e.g., "Joe", "he"),always use the most complete identifier for that entity throughout the knowledge graph. In this example, use "John Doe" as the entity ID.
          Remember, the knowledge graph should be coherent and easily understandable, so maintaining consistency in entity references is crucial.
          ## 4. Strict Compliance
          Adhere to the rules strictly. Non-compliance will result in termination.

@praveshkumar1988
@jexp @kartikpersistent

It seems you guys have uploaded these prompt templates on a GCS bucket but why do so?
Is there any documentation you can provide on how to set-up our own GCS bucket so that it works seamlessly with the Graph Builder?
BUCKET_UPLOAD = 'llm-graph-builder-upload'
BUCKET_FAILED_FILE = 'llm-graph-builder-failed'
PROJECT_ID = 'llm-experiments-387609'

Hi @aadnts please make sure to keep GCS_FILE_CACHE env variable to false if you want to process files locally

Hi @kartikpersistent, thank you for your answer!
I really appreciate you taking these few seconds to give me an answer....
I don't want to process files locally, I want to use chat-gpt-4o-mini (which I've already added as an option).
What I want, is to change the ChatPromptTemplate for it to include relationship constraints, which will definitely help me get drastically better results.
However, you guys decided that the prompt used to extract the graph should not be in the codebase right? To prevent others from modifying it? Why?
Nevermind, that's ok with me, but could you at least give me a hint on how to set-up my own GCS bucket with my prompts and stuff? Otherwise, this is pretty limitating....
@praveshkumar1988
@jexp @nielsdejong

Ex:
BUCKET_UPLOAD = 'llm-graph-builder-upload'
BUCKET_FAILED_FILE = 'llm-graph-builder-failed'
PROJECT_ID = 'llm-experiments-387609'
Hi @aadnts update these values with your gcs creds
BUCKET_UPLOAD="Your Bucket name for storing the uploaded files"
BUCKET_FAILED_FILE ="Your Bucket name for storing the failed files"
PROJECT_ID ="Your project ID"
Install the gcloud cli
Run the gcloud auth application-default login  command
Then you are good to go to test the app with your own gcs configuration

Hi @kartikpersistent, thank you for your answer!
It seems I haven't expressed myself correctly, as you haven't addressed the central topic of my issue.
I only have one single question : how can I change the prompt template which is sent to the LLM in order to extract the graph ?
Please find below the prompt I am referring to, which is sent to ChatGPT everytime I generate a graph from my local files (and that I would like to modify) :
1.
      Try to capture as much information from the text as possible without sacrificing accuracy. Do not add any information that is not explicitly mentioned in the text.
      - **Nodes** represent entities and concepts.
      - The aim is to achieve simplicity and clarity in the knowledge graph, making it
      accessible for a vast audience.
      ## 2. Labeling Nodes
      - **Consistency**: Ensure you use available types for node labels.
      Ensure you use basic or elementary types for node labels.
      - For example, when you identify an entity representing a person, always label it as **'person'**. Avoid using more specific terms like 'mathematician' or 'scientist'.- **Node IDs**: Never utilize integers as node IDs. Node IDs should be names or human-readable identifiers found in the text.
      - **Relationships** represent connections between entities or concepts.
      Ensure consistency and generality in relationship types when constructing knowledge graphs. Instead of using specific and momentary types such as 'BECAME_PROFESSOR', use more general and timeless relationship types like 'PROFESSOR'. Make sure to use general and timeless relationship types!
      ## 3. Coreference Resolution
      - **Maintain Entity Consistency**: When extracting entities, it's vital to ensure consistency.
      If an entity, such as "John Doe", is mentioned multiple times in the text but is referred to by different names or pronouns (e.g., "Joe", "he"),always use the most complete identifier for that entity throughout the knowledge graph. In this example, use "John Doe" as the entity ID.
      Remember, the knowledge graph should be coherent and easily understandable, so maintaining consistency in entity references is crucial.
      ## 4. Strict Compliance
      Adhere to the rules strictly. Non-compliance will result in termination.

It is coming from the neo4j library we can't change that

@aashipandya can answer this query in detail

Thank you for your answer @kartikpersistent
It used to be in the codebase link , why remove it though?
Is there really no way around that ? @aashipandya
This is a critical component of the entire pipeline, for instance, I'm planning to add a relationship constraints builder (c.f. ontology constraints) on the graph enhancement feature, which would enable users to define which entities can be the subject/object of a specific relationship.
This would drastically increase the quality of the graph generated by the LLM, as per my prior testing.
Without the possibility to alter the prompt, this LLM Graph Builder solution loses so much of its potential, especially considering it aims to be open-source right?
Please help me out.
@praveshkumar1988
@jexp @nielsdejong
@karanchellani

Dear @aashipandya !
Thank you so much for your response, this makes it all so much clearer.
I am really grateful for this reply, you have made my day!
Amazing props to you and the team 💯


add "Obtain backtrace of complex error scenarios" example

Issue #216

Hello @budziq
Here is my attempt to show a "complex" backtrace with a relatively short code. Let me know if it is a good candidate for this issue.

Thanks @budziq for your review. I am on a weekend, I expect to correct the PR beginning of the week.

I updated the PR following most of your comments. Still open to discussion:

usage of ok_or and chain_err
usage of from_path

CI is happy :-)
One question left on my side: https://github.com/rust-lang-nursery/rust-cookbook/pull/325#discussion_r146101680, and waiting for your suggestions, if you have any.

read_rgb_from_csv was moved to from_reader.
I noticed removing process::exit(1) make the CI happy, but when I click on the play button, the program output is empty (error backtrace is not displayed, but it is rendered as text just below the code snippet). Looks like the error output is redirected somewhere else. Should we keep this behavior or add a no_run instead?

Stderr is printed only if playground returns process failure
Let's keep the example runnable and possibly submit a bug report to mdbook (we can also modify it lolly in cookbook but I'd prefer to to avoid it)

Alright @budziq. In that case, the PR looks fine on my side. I will raise an issue to mdbook. Should I cc you?

Thanks @ludwigpacifici!
Yep, please cc me on mdbook issue. I'll ad it to my ever expanding todo list ;).

or better yet please create the issue in cookbook for now untill we come up with reasonable solution to propose.

Thanks for your time @budziq
I will put it on the ever expanding list of the rust-cookbook :-)


Fix reachability analysis for 'assert x is T' assertion type predicates

Fixes #38699.

Closing in favor of #38710.


Update error code constants

Codecov Report

Merging #665 (cb62ef0) into v1 (f1983fb) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##               v1     #665      +/-   ##
==========================================
+ Coverage   77.39%   77.56%   +0.16%
==========================================
  Files         100      100
  Lines        4690     4724      +34
==========================================
+ Hits         3630     3664      +34
  Misses       1060     1060

Flag
Coverage Δ

unittests
77.56% <100.00%> (+0.16%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

wechatpy/constants.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1983fb...cb62ef0. Read the comment docs.

LGTM

@LKI Can this PR be merged into master branch?

@tssujt done


error when trying to display the number of visit in a partial in backend

in my model fields.yaml I have:
_total_visit:
            label: "Total visit"
            type: partial
            path: ~/plugins/author/xcv/models/lesson/_total_visit.htm

in the partial _total_visit.htm I have
<?= $model->visit(); ?>

error thrown:
Object of class CWTeam\OctoVisit\PendingVisit could not be converted to string

Please update the documentation then to indicate this is a collection. Maybe rename it to visitors() to be more clear?

thanks for the update


pull request for e2e test at 12/18/2016 13:45:20

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


More symbols/object elements to add to the page (arrows, etc.)

Add more symbols/objects to elements panel such as arrows.

This is something I was looking for as well when I was creating a story.


Add Sent2VecVectorizer transform

Contains doc2vec PR, as soon as it merges the commits will be removed

Codecov Report

Merging #57 into master will decrease coverage by 0.80%.
The diff coverage is 64.10%.

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   75.84%   75.04%   -0.81%
==========================================
  Files          33       34       +1
  Lines        1217     1234      +17
==========================================
+ Hits          923      926       +3
- Misses        294      308      +14

Impacted Files
Coverage Δ

wellcomeml/ml/sent2vec_vectorizer.py
0.00% <0.00%> (ø)

wellcomeml/ml/bert_vectorizer.py
100.00% <100.00%> (ø)

wellcomeml/utils.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8485d5...059a88b. Read the comment docs.

 Add Sent2Vec and BioSent2Vec model to WellcomeML


Copyright issue

You are directly using https://github.com/google/intermock (even code sample from it), but no any mention about this. Not nice.

Sorry, I will indicate the source  https://github.com/google/intermock.If needed I will unpublish this plugin based on your reply.
------------------ 原始邮件 ------------------
发件人:                                                                                "981377660LMT/vscode-plugin"                                                                                @.>;
发送时间: 2021年7月21日(星期三) 下午4:33
@.>;
@.***>;
主题: [981377660LMT/vscode-plugin] Copyright issue (#1)
You are directly using https://github.com/google/intermock (even code sample from it), but no any mention about this. Not nice.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Feature/dan review suggestions

General thoughts
This looks good to me, it's simple enough to actually be quick but also a fun flow that also demonstrates Snowpark functionality.
A few notes:

For a lab environment, in my experience it's important to be very clear around initial setup and credentials, so I've added a bit more detail in those sections (I also took a few extra screenshots but would consider that optional - maybe for a HOL setting we could add them). In particular, the variable format of the account identifier can cause confusion.
I also added some notes on production usage around credentials (using Secrets Manager or equivalent rather than hardcoding) and roles (not using ACCOUNTADMIN, although it may be the easiest option in a lab environment).
I like that this lab runs entirely in Studio - no jumping back and forth between tools makes it viable even for very short lab sessions.

Suggested changes:
0_setup

I get the ominous red warning below after connecting and writing data to Snowflake - however commands still work:

/opt/conda/lib/python3.8/site-packages/cryptography/hazmat/backends/openssl/x509.py:14: CryptographyDeprecationWarning: This version of cryptography contains a temporary pyOpenSSL fallback path. Upgrade pyOpenSSL now.
  warnings.warn(

1_prepare_build_deploy_model
Start

[ ] connection_parameters should have a warehouse defaulting to HOL_WH created in 0, optionally also a database HOL_DB
[ ]   - The session.table commands in _prepare_build_deploy_model.ipynb currently point to the wrong location: MFR.PUBLIC should be HOL_DB.PUBLIC (or could remove DB if setting via the above)
[ ]   hum_udi_tf should point to table CITY_UDF rather than HUMIDITY_UDI which doesn’t exist - possibly need to rename this variable to reflect that?

Look at each of the dataframes

[ ] - maintenance_hum_df needs MFR -> HOL_DB or remove (set via connection)

✅ Build model that predicts machine failure (no issues - I’m doing ML!!! 🤖)
✅ Variable Importance
Deploy Model to Snowflake

[ ] Error on first cell: No such file or directory: 'mfr_model/model.pkl' -> I needed to manually create folder mfr_model, I suggest adding this to the repo or outputting instead to model.pkl (top level directory)
[ ] A couple of MFR references should change to HOL_DB or remove
[ ] Unclear what database / schema should be used for the connection - I suggest reusing the same connection from above and just adding "schema": "PUBLIC" so the participant doesn’t have to enter these details three times during the lab

Opened against base rather than Matt's fork - closing this.


Feature/move nodes on canvas

semantic-release should now publish to npm
storybook should now be deployed to gh-pages on new version release

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


ApiResponseCallAdapterFactory is missing in 2.0.4

2.0.4
Android 12
Can't import ApiResponseCallAdapterFactory
import com.skydoves.sandwich.adapters.ApiResponseCallAdapterFactory
...
.addCallAdapterFactory(ApiResponseCallAdapterFactory.create())

Hey @wennaspeedy, since version 2.0.0, Sandwich has been separated into multiple packages to support KMP. So you should make sure you're importing a sandwich-retrofit package, not a sandwich package.
https://skydoves.github.io/sandwich/retrofit/

I am sorry. I miss that. I migrated from 1.3.9.


Migration path from bower /

I am trying to come up with a migration path for a large AngularJS code base shared between many different applications. Application developers are consuming modules from this shared library by injecting them manually in <script> tags.
I want to clean that mess up & introduce ES6 Modules & SystemJS. However, I cannot change all the existing applications at once and need to find a migration path allowing me to use ES6 modules (imports/exports) while still exporting the modules in the old self-executing format.
For that, I created the following script listing of the dependencies of a module & adding them to the meta build: false config. However, when executing these SFX bundles SystemJS complains that the dependencies are not available.
Is there a way to flag a dependency as global so that SystemJS just ignores it? And is there a better way to do what I am trying to achieve, as SFX bundles add a non-significant overhead (400B -> 11K)?
import glob from 'glob';
import path from 'path';
import Builder from 'systemjs-builder';

const builder = new Builder();

builder.loadConfig('./config.js').then(() => {
  // get the modules list
  return new Promise((resolve, reject) => {
    glob('src/**/!(*.spec|*.mock).js', (err, files) => {
      if (err) reject(err); else resolve(files);
    });
  });
}).then((files) => {
  // create standalone self-executable System modules
  return Promise.all(files.map(file => {
    // module name, e.g. 'lg-validation/validation'
    const module = path.relative(path.join(__dirname, 'src'),  file.slice(0, -3));
    // module dest, e.g. 'dist/lg-validation/validation.js'
    const dest = path.join('dist', module + '.js');
    // gets the module deps first
    return builder.buildSFX(module).then(output => {
      // filter out the deps
      const deps = output.modules.filter(dep => {
        return dep !== module;
      });
      // build the arithmetic string
      let meta = {};
      deps.map(dep => {
        meta[dep] = { build: false };
      });
      // build the module without any deps
      // TODO: we shouldn't need to instantiate a new builder here
      const builder = new Builder();
      return builder.loadConfig('./config.js').then(() => {
        return builder.buildSFX(module, dest, {config:{meta}});
      });
    }).then(() => {
      console.log(`created bundle ${module} in ${dest}`);
    });
  }));
}).then(() => {
  console.log('done');
}).catch(err => {
  console.log(err);
});

SFX modules with unbuilt dependencies is a workflow that will be possible in future but isn't currently. See https://github.com/systemjs/builder#adapter-modules for an approach that can be used here.
If you're interested in contributing to or sponsoring development on the SFX dependencies feature I'm always happy to discuss too.

Thanks, that's exactly what I ended up doing by using setting map config pointing the dependencies to adapter modules in the build script above.


Cryotherapy Analysis

Dataset:

Cryotherapy is a treatment where your healthcare provider applies extreme cold to freeze and destroy abnormal tissue. To create this severe cold, your provider will use a substance like liquid nitrogen or argon gas.
Cryotherapy can be used to treat a variety of skin conditions and some cancers, including prostate and liver cancer. This therapy can treat tissue externally (on the skin) and internally (inside the body).

Dataset:
https://www.kaggle.com/mmkvarma/cryotherapy-analysis

I can do this if you can explain the approach on how to do it

Hi, I am GSSoC'22 contributor ,I have worked with ML models before.
I can do the following
1.do data Analysis & preprocessing if need it .
2.check relation between features to drop unnecessary features.
3.Train the model using different algorithms with hyperparameter Tuning.
4.Evaluate model performance.

Hi, i am GSSoC'22 contributor and i would like to work on this issue if not assigned yet.
I have been worked on similar projects.

/assign


Add a builder for ServerListener

Discord thread: https://discord.com/channels/1087271586832318494/1087272728177942629/1129037723643166792
It would be nice to add builder methods for ServerListener.
final var executor = Executors.newSingleThreadExecutor();
var listener =
  ServerListener
    .builder()
   .whenStopping((s) -> {
     executor.shutdown();
   })
  .build();

Server
  .builder()
  .serverListener(listener);

In addition to the builder methods, we can add some useful factory methods that perform a specific actions when a server is started or stopped.
public interface ServerListener {

  static ServerListener wrap(Executor executor) { ... }

}

@jmadureira suggested all ideas and I just rewrote them.

I realized that we already have ShutdownSupport that stops an executor when a server stops.
https://github.com/line/armeria/blob/669f525ec1e05d8e3b3b0aa724b070fc6350bb1f/core/src/main/java/com/linecorp/armeria/server/ShutdownSupport.java#L38-L38
It may be better to sharpen ShutdownSupport API and make it a public API.

public interface EventListener {
  EventListener withExecutor(Executor executor);
}

public interface ServerListener extends EventListener { ... }

public interface SomeOtherListener extends EventListener { ... }

@ikhoon
Hi! If I understand the issue and Discord conversation correctly, It seems to be suggesting creating a ServerListener to gracefully stop the ExecutorService running in the background in response to the shutdown of the Armeria server.
However, it seems that we can handle this using the whenStopping method, as written in the issue. Could you explain what the required "builder method" is?
I understand the need for the factory method (ShutdownSupport#of). So, is it just a matter of creating an appropriate factory method?

Could you explain what the required "builder method" is?

Good question. Sometimes, builder methods with fluent chaining might be convinient to implement users’ business logic. Additionally, builder pattern could avoid breaking changes when a new method is added the interface. It could happen in an unstable API or major upgrade.

So, is it just a matter of creating an appropriate factory method? Or, are there any missing features in the whenStopping method?

No, we won’t fix or add a new feature to whenStopping. The aim of this issue is to add some utility class and builder method to easily close some tasks or objects when a server stops.

Thank you! May I handle this issue?

Yes, please!

@ikhoon Thanks! I'm trying to sharpen ShutdownSupport API now. Below is the current code of method.
static ShutdownSupport of(ScheduledExecutorService executor) {
    requireNonNull(executor, "executor");
    return () -> {
        // omitted some parts
        e.shutdown();

        // omitted some parts
        while (!e.isTerminated()) {
            try {
                e.awaitTermination(1, TimeUnit.HOURS);
            } catch (InterruptedException ignore) {
                interrupted = true;
            }
        }
        // omitted some parts
        return UnmodifiableFuture.completedFuture(null);
    };
}

I have omitted some parts of the code. The method returns () -> CompletableFuture<void>. The returned function appears to execute asynchronously, but in reality, it synchronously waits for the executor to finish and then returns the final effect. Therefore, when implementing ServerListener using this approach, the server synchronously waits for the executor to complete.
Depending on the user's requirements, there may be a need to adjust this behavior. Is it appropriate for the Armeria server to synchronously wait for the external executor's termination? Or, should we provide users the both synchronous and asynchronous methods for waiting?

The returned function appears to execute asynchronously, but in reality, it synchronously waits for the executor to finish and then returns the final effect.

It is a good question. CompletableFuture may provide parallel execution for closing tasks. It would make a server stop quickly. But that said, I am also unsure it is pratically useful in the real world.
I think it would not be difficult to convert from synchronous to asynchronous. Let's implement a synchronous version and listen to other fork's opinions in the review process.


Enum-based constants can be used as computed property names more than once

TypeScript Version:  4.0.3

Search Terms: enum, 2300, computed property name, duplicate identifier, duplicates, twice
Expected behavior:
Compile-time error. It shouldn't matter if the constant is provided inline or pulled from an enum — a duplicate is still a duplicate. Enum values are known in compile-time, so it's possible to reject duplicate values.
Actual behavior:
The Duplicate identifier '80'.ts(2300) error is suppressed when enums are used.

Related Issues:
#6864 looks similar, but that one is concerned with values within the enum that defines them. I'm talking about using enum values inside an object literal.
Code
enum Port {
  HTTP = 80
}

const good = {
  80: '😇',
  80: '😇', // Error, as expected: Duplicate identifier '80'.ts(2300)
}

const alsoGood = {
  [80]: '😇',
  [80]: '😇', // Error, as expected: Duplicate identifier '80'.ts(2300)
};

const bad = {
  [Port.HTTP]: '😩',
  [Port.HTTP]: '😩' // No error
}

Output
"use strict";
var Port;
(function (Port) {
    Port[Port["HTTP"] = 80] = "HTTP";
})(Port || (Port = {}));
const good = {
    80: '😇',
    80: '😇',
};
const alsoGood = {
    [80]: '😇',
    [80]: '😇',
};
const bad = {
    [Port.HTTP]: '😩',
    [Port.HTTP]: '😩' // No error
};

Compiler Options
{
  "compilerOptions": {
    "noImplicitAny": true,
    "strictNullChecks": true,
    "strictFunctionTypes": true,
    "strictPropertyInitialization": true,
    "strictBindCallApply": true,
    "noImplicitThis": true,
    "noImplicitReturns": true,
    "alwaysStrict": true,
    "esModuleInterop": true,
    "declaration": true,
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "moduleResolution": 2,
    "target": "ES2017",
    "jsx": "React",
    "module": "ESNext"
  }
}

Playground Link: Provided
This made me waste a fair amount of time debugging. The bug was caused by one enum value overriding the other like this:
enum TextData {
  CSV,
}

enum BinaryData {
  MPM,
  STL
}

const documents = {
  [TextData.CSV]: false,
  [BinaryData.MPM]: true,
  [BinaryData.STL]: false,
}

if (documents[TextData.CSV]) {
  console.log('Oups! I didn’t expect this to be executed')
}

Duplicate of #25758 and not specific to enums.


Dark Theme Visibility Issues

[ ] Input text box does not follow dark theme
[ ] Edit Properties button does not follow dark theme
[ ] Map Point Tool button does not follow dark theme
[ ] Output table borders do not follow dark theme (actual text in table seems to)
[ ] List does not follow dark theme
[ ] Copy button does not follow dark theme
[ ] Copy All button does not follow dark theme
[ ] Clear All button does not follow dark theme
[ ] Import button does not follow dark theme
[ ] Export button does not follow dark theme
[ ] Edit Properties dialog does not follow dark theme
[ ] Add dialog does not follow dark theme

issues #369 and #370  were entered as Version-Next, I feel that we should fix those before release. This issue I think can be pushed to Version-After Next, given our current timeline.

Changing the title of this issue from:
Dark Theme support for issues related to non ArcGIS Pro WPF controls
To :
Add new Output Coordinate Window does not support dark theme

Being that this is a duplicate issue of #464 I am changing this issue to just focus on the window for new output coordinate.

@dfoll @ACueva @lfunkhouser wanted to make sure everyone sees this change.

This has been addressed and verified.


Tabs: use enums instead of arrays

Commit 37dda260f7138a67178acff20bdcb13384b8835a implements passing the active tab to the frontend. It enumerates the existing tabs in the controller via an array:
var (
	subNavs = []string{"description", "contributors", "publications"}
)

A more idiomatic way of doing this is in Go is using an (emulated) Enum structure: https://threedots.tech/post/safer-enums-in-go/
Which translates to:
type Tab struct {
    label string
}

const {
    Description Tab{"description"}
    Contributors Tab{"contributors"}
    Publications Tab{"publications}
}

func (tab t) String() string {
    return t.label
}

func FromString(t string) (Tab, error) {
    switch s {
    case Description.label:
        return Description, nil
    }
    return errors.New("Unknown tab.")
}

if t, err := fromString(activeSubNav); err != nil {
    activeSubNav = Description
}

render.Render(w, "dataset/show_description", YieldShowDescription{
Context: ctx,
ActiveSubNave: activeSubNav,
...
}

It's possible to pass an arbitrary value referring to a non-existent tab via the "show" URL query parameter. Regardless of the implementation, a check is required.
The Three Dots article makes the argument for Enums + structs as it encapsulates the check as well as the enumeration in one spot in the codebase. The rest of the code isn't aware of tabs. Per the article: there's little benefit in creating a Tab type which is an alias to string. The use of a struct allows for relying on Go's static typing to perform the check.
While promoted as an idiomatic way of approaching a check against a list of constant values, the use of a slice works here as well. There's marginal to no benefit of one approach over the other, in terms of upkeep / maintenance / reducing risks of introducing bugs, if the check is only performed in one or two spots.

@mietcls This was a discussion about an implementation detail. It doesn't have any hard functional repercussions (bugs, etc.) So, closing this one.


License?

I don't see a license file, and searching for the string "Copyright" doesn't seem to turn up anything. What license is this repo under?

It's MIT.

Fantastic, thanks!


Rework EmphasisPlugin and ItalicsPlugin

Pull Request Template
Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.
Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.
Before opening a pull request, please ensure:

[x] You have followed our contributing guidelines
[x] double-check your branch is based on develop and targets develop
[x] Pull request has tests
[x] Code is well-commented, linted and follows project conventions
[ ] Documentation is updated (if necessary)
[x] Description explains the issue/use-case resolved
[x] I did not commit files that are excluded in the .gitignore file (Happens if you stage files with Android Studio)

Description
We can use MarkwonEditorUtils to find substrings at which *text*, **text**, and __text__ is used.
Motivation and Context
See description.
How Has This Been Tested?
Ran tests.
Screenshots (if appropriate):
n/a
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Thank you @luk1337 nice find with MarkwonEditorUtils 💯

Closes: #2


⚠ Feedaty widget has degraded performance

In 0acb764, Feedaty widget (https://widget.feedaty.com/public/js/feedaty.js?merchant=10213975&style_ver=2021&data-sku=36263) experienced degraded performance:

HTTP code: 200
Response time: 4186 ms

Resolved: Feedaty widget performance has improved in 41a81c1 after 14 minutes.


show SubscriptionPeriod on PurchaseButton

storeKit Product has column SubscriptionPeriod, can be used on PurchaseButton.
now:

expect:

notice: apple web docs is wrong. https://developer.apple.com/documentation/storekit/skproductsubscriptionperiod/2936876-numberofunits
subscription.subscription?.subscriptionPeriod.numberOfUnits

Value of type 'Product.SubscriptionPeriod' has no member 'numberOfUnits'

should use:
subscription.subscription?.subscriptionPeriod.value

PurchaseButton(purchaseState: $purchaseState, productId: productId, price: subscription.displayPrice + " / " + period)

self.period = subscription.subscription?.subscriptionPeriod.unit.localizedDescription ?? ""
                    let periodValue = subscription.subscription?.subscriptionPeriod.value ?? 1
                    if periodValue != 1 {
                        // TODO Month to Months
                        self.period = String(periodValue) + " " + self.period
                    }

Excellent suggestion! It looks much better when the period is shown on the button. I'll implement your idea as a configurable option (so as not to break exisiting code)


[question] missing github.com/docker/libnetwork package in vendor

Issue Description
pull latest code, make install and fail
Describe what happened:
➜  pouch git:(master) make install
GOOS=linux go build -o pouchd
network/types/network.go:3:8: no Go files in /root/go/src/github.com/docker/libnetwork
daemon/mgr/network.go:17:2: cannot find package "github.com/docker/libnetwork/config" in any of:
        /root/go/src/github.com/alibaba/pouch/vendor/github.com/docker/libnetwork/config (vendor tree)
        /usr/local/go/src/github.com/docker/libnetwork/config (from $GOROOT)
        /root/go/src/github.com/docker/libnetwork/config (from $GOPATH)
        /root/go/src/github.com/docker/libnetwork/Godeps/_workspace/src/github.com/docker/libnetwork/config
network/bridge/bridge.go:11:2: cannot find package "github.com/docker/libnetwork/drivers/bridge" in any of:
        /root/go/src/github.com/alibaba/pouch/vendor/github.com/docker/libnetwork/drivers/bridge (vendor tree)
        /usr/local/go/src/github.com/docker/libnetwork/drivers/bridge (from $GOROOT)
        /root/go/src/github.com/docker/libnetwork/drivers/bridge (from $GOPATH)
        /root/go/src/github.com/docker/libnetwork/Godeps/_workspace/src/github.com/docker/libnetwork/drivers/bridge
daemon/mgr/network.go:18:2: cannot find package "github.com/docker/libnetwork/netlabel" in any of:
        /root/go/src/github.com/alibaba/pouch/vendor/github.com/docker/libnetwork/netlabel (vendor tree)
        /usr/local/go/src/github.com/docker/libnetwork/netlabel (from $GOROOT)
        /root/go/src/github.com/docker/libnetwork/netlabel (from $GOPATH)
        /root/go/src/github.com/docker/libnetwork/Godeps/_workspace/src/github.com/docker/libnetwork/netlabel
daemon/mgr/network.go:19:2: cannot find package "github.com/docker/libnetwork/options" in any of:
        /root/go/src/github.com/alibaba/pouch/vendor/github.com/docker/libnetwork/options (vendor tree)
        /usr/local/go/src/github.com/docker/libnetwork/options (from $GOROOT)
        /root/go/src/github.com/docker/libnetwork/options (from $GOPATH)
        /root/go/src/github.com/docker/libnetwork/Godeps/_workspace/src/github.com/docker/libnetwork/options
network/bridge/bridge.go:13:2: cannot find package "github.com/vishvananda/netlink" in any of:
        /root/go/src/github.com/alibaba/pouch/vendor/github.com/vishvananda/netlink (vendor tree)
        /usr/local/go/src/github.com/vishvananda/netlink (from $GOROOT)
        /root/go/src/github.com/vishvananda/netlink (from $GOPATH)
        /root/go/src/github.com/docker/libnetwork/Godeps/_workspace/src/github.com/vishvananda/netlink
Makefile:27: recipe for target 'server' failed
make: *** [server] Error 1
➜  pouch git:(master) git log --pretty=oneline | head -n 1
053ae8c19715fa3a3c5a6f55b99081c5fde08a7e Merge pull request #411 from Letty5411/test

Describe what you expected to happen:
it seems that we miss the github.com/docker/libnetwork package in vendor
How to reproduce it (as minimally and precisely as possible):
pull code and make install
Anything else we need to know?:
ping @rudyfly and @allencloud
Environment:

pouch version (use pouch version):
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

I have ran into the same issue, and I think it is because the commit https://github.com/alibaba/pouch/pull/311.
/cc @rudyfly
Could you confirm this ASAP? Otherwise, we will consider to revert the change you made.


You know what would be awesome?  A man page, that's what.

Or maybe even a perldoc, just to mess with folks.

Or maybe even a perldoc, just to mess with folks.


Response headers, status code, and error handling

Proposed handler fixes and error handling improvements for #315
The general idea is to render component into a buffer before writing it to response, so that in the event of error, error handler can write its own response with correct status code and headers. The buffer is obtained with GetBuffer() and component should be able to use it directly as if it obtained buffer on its own.
Additionally, handler now sets headers to header map before writing response code, and does not write response code when calling error handler so that it can set its own headers and response code.

Thanks for that, much appreciated! I'm prepping for a release, just want to do some work on https://github.com/a-h/templ/issues/249, a bit more testing, and I'll push it.

Thank you! Yes, i did have a feeling that wasn't an idiomatic thing in go 🙂


MutationObserver

I'm replacing parts of "composite component" by AngularJS, for this I am trying to use AngualarFaces, but I get the following message:
angular.js.xhtml?ln=AngularJS:11699 TypeError: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'.
    at TypeError (native)
    at link (http://<IP_ADDRESS>:8080/Sisconweb/javax.faces.resource/angularfaces-directives.js.xhtml?ln=AngularFaces:51:18)
    at http://<IP_ADDRESS>:8080/Sisconweb/javax.faces.resource/angular.js.xhtml?ln=AngularJS:8284:44
    at invokeLinkFn (http://<IP_ADDRESS>:8080/Sisconweb/javax.faces.resource/angular.js.xhtml?ln=AngularJS:8290:9)
    at nodeLinkFn (http://<IP_ADDRESS>:8080/Sisconweb/javax.faces.resource/angular.js.xhtml?ln=AngularJS:7800:11)
    at compositeLinkFn (http://<IP_ADDRESS>:8080/Sisconweb/javax.faces.resource/angular.js.xhtml?ln=AngularJS:7149:13)
    at compositeLinkFn (http://<IP_ADDRESS>:8080/Sisconweb/javax.faces.resource/angular.js.xhtml?ln=AngularJS:7152:13)
    at compositeLinkFn (http://<IP_ADDRESS>:8080/Sisconweb/javax.faces.resource/angular.js.xhtml?ln=AngularJS:7152:13)
    at compositeLinkFn (http://<IP_ADDRESS>:8080/Sisconweb/javax.faces.resource/angular.js.xhtml?ln=AngularJS:7152:13)
    at compositeLinkFn (http://<IP_ADDRESS>:8080/Sisconweb/javax.faces.resource/angular.js.xhtml?ln=AngularJS:7152:13) <puimessage field="form:tabView:emailFirma" for="emailFirma" class="ng-isolate-scope">

Probably it's a good idea to switch off the automatic generation of labels and - possibly - even FacesMessages for your component. AngularFaces tries to guess what might be a good label for your component, but since it doesn't know your component's internal structure, it fails.
BTW: that's just guesswork. It's hard to say for sure with so little information.
Please report back if my hint solved your problem, so I can close the issue.

I'm sorry not to have answered before.
But the problem was incompatibility between my AngularJS modules and angular.js contained in AngularFaces. I did not know AngularFaces carried his own "angular.js". I decided then recompile AngularFaces (2.1.12-snapshot) and the problem was solved.
Thank you. You can close the post.