Provisionning: attach new disks before starting a VM

Author Name: EOLE Team (EOLE Team)
Original Redmine Issue: 4246, https://dev.opennebula.org/issues/4246
Original Date: 2015-12-15

Hello,
With ONE 4.14.2, in the cloud and users views, we can resize the disk declared in the template during startup but we can not declare a new disk.
Is it possible to make the @Disks@ more like the @Network@(1) with a button @Add another Disk@?
We should have a template option to lock the addition of new disks and maybe another one to manage the existing declared disks, for example:

@SUNSTONE_DISK_SELECT@ permit to do whatever we want with disks
@SUNSTONE_DISK_ADD@ permit to add new disks, which could be removed too, this option locks the disks declared in the template.

Another option is to have a single option, @SUNSTONE_DISK_SELECT@, with more than boolean value :

@NO@ disks are locked
@YES@ do what ever you want with disks
@ADD@ disks declared in the template are locked, but user can manage more disks.

This will be very useful for us, we mostly non persistent VMs, we have base templates with the OS and need to make some tests with different configuration of disks (several HDs, CDROMs).
Today, we need a template per combination of additional disks, so we restrict to the installation CDROM of the installed OS.
(1) note that @Disks@ is always plural but @Network@ is singular

When testing this, consider " inside string fields.


[JOSS] General explanation of reduce/preserve

Re JOSS review openjournals/joss-reviews#6889
One of the most powerful features of scores is its flexible handling of multidimensional arrays, e.g., through the inclusion of "reduce" and "preserve" options for many (most?) of the supplied metrics. However, I think the correct usage of these options could be confusing to a new user, especially one who isn't already family with the concept of "reduce" in a more general programming context. The docstrings help with this a little but may still confuse some users since they also assume familiarity with the term "reduce".
To address this, I would advocate including a section on the documentation that describes "reduce/preserve" in general terms to a naive audience. This could take the form of a tutorial that explores how the options could be used in different multi-dim scenarios, or simply a text/diagrammatic explanation along the lines of
"Most of the metrics in scores are designed to compare groups of numbers. Sometimes it is useful to consider all the numbers in a multi-dim array as belonging so one group. Other times it is useful to group along a subset of dimensions and then apply the metric repeatedly across the non-grouped dimensions..." etc...

Thanks for this feedback. Most of the current notebooks are very much 'per score' rather than 'per concept'. It will take some time, but I'll happily create a tutorial which specifically addresses the purpose and use of reduce/preserve. The MAE and RMSE tutorials do demonstrate this briefly, but I agree some more explanation would be useful for many.

I would like to clarify my earlier comments. I think such a notebook could be of particular value for those outside or new to the field, which is what I meant when I said "more explanation would be useful for many". As such, down the road, I do intend to add a new tutorial specifically about these concepts.  In the meantime, there are some examples in the existing tutorials.
I think the main audience for scores will already be familiar with the general concept of dimensionality reduction, and be fairly comfortable using the preserve/reduce functionality.


Bug: Email Authentication Failure Due to Trailing Space in Input

When a user enters their email and password in the login text fields, and unintentionally adds a space at the end of the email, the space is erroneously included in the email input. Consequently, this leads to an email mismatch during authentication, resulting in login failures.
Expected Behavior
The system should recognize and trim any trailing spaces in the email input to ensure accurate authentication.
https://github.com/zulip/zulip-flutter/assets/97253470/28cc536d-2da7-418a-8d3a-161c7c2fd9a6

Thanks for the report! I agree this would be good to fix.

hi @gnprice can I Solve this Issue?

@Narasimha677 The issue is already assigned to @Mehul-Kumar-27, and he has a PR for it that's near completion. So I don't think this is a useful one for another contributor to try to pick up.

@gnprice Thanks for the Response


Incorrect justify-content autoprefixing in Safari

Environment
styled-components 5.3.6
Reproduction
tested on Safari 15.x.x
https://codesandbox.io/s/red-tree-2ljps0?file=/src/App.js
Expected Behavior
my code
 display: flex;
 justify-content: end;

styled-components turned it into this
display: flex;
-webkit-box-pack: end;
-webkit-justify-content: end;
-ms-flex-pack: end;
justify-content: end;

The correct styling should have been:
-webkit-justify-content: flex-end;
-webkit-align-items: flex-end;

the problem is first found on issues #626, but now it's still missing the correct -webkit autoprefixed styles.
Expected Behavior
Stylis autoprefixer should apply the correct -webkit autoprefixed styles

Please check out v6 beta, v5 uses an older version of stylis which is no longer maintained


gltfpack: Significant UV distortion for models with high tiling factors

I think I'm seeing a similar issue in v0.13 of gltfpack. Testing against the model here: https://sketchfab.com/3d-models/melodia-city-hotel-a2fb8e4065ce470296d6d801daa37f18, with only default gltfpack options used:

before
after

annotated diff:

^Much of that diff is in reflections, which probably relates to merging meshes with transparency, and that seems fine. But the highlighted areas on the side of the building and the palm trees in front of the building show noticeable UV shifts that might suggest an issue:

FWIW all of the issues here are due to UV errors - running gltfpack with -vt 16 (using all 16 bits for texture coordinate storage) fixes the windows and almost fixes the trees, although there's still some UV distortion noticeable.
The major issue here is that right now gltfpack doesn't use a per-material / per-texture UV quantization grid, which is necessary to decouple quantization of tree textures vs quantization of other textures for buildings. Once that is fixed, more changes might be necessary to get decent quality with default settings - I'll take a look at all of this soon-ish.

Hi. I am compressing a obj file to gltf using meshoptimizer and the results are great. But facing one issue is that I have lost all the UV information in the compressed model. I am using the following command to compression:


Exit to the proper page when transitioning

cc @marcaaron
Details

As Marc suggested, subscribing to updates in the betas again ensures that componentDidMount runs.
Fixed Issues

$ https://github.com/Expensify/Expensify/issues/201705
Tests

Open an incognito window (so that there are no cookies or local data) and go to expensify.com.dev.
Sign in to expensify.com.dev as a brand new userA with an @gmail.com email address.
Click to open the second inbox task that says "Would you like to get started with our free plan?".
Click get started.
Verify and note that userA is now logged into NewDot.
Close the tab, go back to expensify.com.dev and go to Settings>Policies>Group.
Refresh the page.
Click on the workspace policy
Verify that a new tab opens in new.expensify with the workspace settings open

[ ] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[x] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. “toggleReport” and not “onIconClick”)
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct english, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct english and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY
[ ] I verified any variables that can be defined as constants (ie. in CONST.js) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] Any internal methods are bound to “this” properly so there are no scoping issues
[ ] Any internal methods bound to “this” are necessary to be bound
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function
(i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

PR Reviewer Checklist

[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. “toggleReport” and not “onIconClick”).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct english, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct english and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY
[ ] I verified any variables that can be defined as constants (ie. in CONST.js) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] Any internal methods are bound to “this” properly so there are no scoping issues
[ ] Any internal methods bound to “this” are necessary to be bound
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function
(i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

QA Steps

Same as tests but on staging.

[ ] Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Any ideas on what else we can do?

I think we could move everything into componentDidMount. If we don't need to sign out or sign in they we can exit to the route. What are all the cases where we use the transition?
    componentDidMount() {
        const accountID = parseInt(lodashGet(this.props.route.params, 'accountID', ''), 10);
        const email = lodashGet(this.props.route.params, 'email', '');
        const shortLivedToken = lodashGet(this.props.route.params, 'shortLivedToken', '');

        const isUserSignedIn = this.props.session && this.props.session.authToken;
        if (!isUserSignedIn) {
            Session.signInWithShortLivedToken(accountID, email, shortLivedToken);
            return;
        }
        if (this.signOutIfNeeded(email)) {
            return;
        }

        // exitTo is URI encoded because it could contain a variable number of slashes (i.e. "workspace/new" vs "workspace/<ID>/card")
        const exitTo = decodeURIComponent(lodashGet(this.props.route.params, 'exitTo', ''));
        if (exitTo === ROUTES.WORKSPACE_NEW) {
            // New workspace creation is handled in AuthScreens, not in its own screen
            return;
        }

        // In order to navigate to a modal, we first have to dismiss the current modal. But there is no current
        // modal you say? I know, it confuses me too. Without dismissing the current modal, if the user cancels out
        // of the workspace modal, then they will be routed back to
        // /transition/<accountID>/<email>/<authToken>/workspace/<policyID>/card and we don't want that. We want them to go back to `/`
        // and by calling dismissModal(), the /transition/... route is removed from history so the user will get taken to `/`
        // if they cancel out of the new workspace modal.
        Navigation.dismissModal();
        Navigation.navigate(exitTo);
    }

Yeah that looks like it would work to me.

To see all the cases where we use the transition we have to look at Web-Expensify and I think Mobile-Expensify as well:
https://github.com/Expensify/Web-Expensify/blob/541404094f189a4df9599daf5b481be547d7b6f6/homepage/js/signin.jsx#L1396-L1399
https://github.com/Expensify/Web-Expensify/blob/541404094f189a4df9599daf5b481be547d7b6f6/site/lib/policyUtils.js#L198-L227
https://github.com/Expensify/Mobile-Expensify/blob/542884e1afa0fb66ba4a048941768b817b212721/app/libs/policy-manager.js#L383-L411
Maybe others....

🚀 Cherry-picked to staging by @marcaaron in version: 1.1.44-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@neil-marcellini We could not test in Desktop app, Android and iOS. Web is a pass. In mWeb we are redirected app for step 6.
https://user-images.githubusercontent.com/43996225/159084142-75bd5e91-2838-4e55-82ef-d942eb1fffdf.MP4


Mimic React.js behaviour for capture event handlers

Here is my proposal how it could look to make it work in the same way as in React.js.
Pros:

Works as React event handlers
Possibility of more detailed control over multiple handlers

so I no longer need two components for two different handlers

Cons:

Breaking change

If we don't want to introduce a breaking change, capture prop can remain there, although the API shouldn't provide two ways to do the same thing.
Closes #9

Perfect, then it's done from my side.

@jaroslav-kubicek Thanks!


Having issues styling addon's sidebar TreeStyleTabs

I am trying to restore styling I had for a sidebar for an extension called TreestyleTabs but having difficulty figuring it out.
This is what my sidebar looked before:

And this is what my sidebar looks like now:

I'm trying to restore the sidebar's black background, tab borders, and some text styling so that there is more contrast and the indentation between parent and child tabs, and tab groups, is more visible. Right now it is very hard to see things because of how similarly they are styled.
I tried using the rules given in TST's wiki to style the tabs from within TST preferences but I think shadowfox userChrome.css and userContent.css were overriding them.
/* Change styling of pending (unloaded) tabs */
.tab.discarded {
  opacity: 0.9;
}

.tab.discarded .label {
  color: darkgray;
}

I also found another example with the contrast I want:

I tried using some of the rules provided there inside TST preferences but, again, shadowfox seems to be overriding them.

I'm not entirely sure what the difference is and where to edit, after trying to check the diff between old and new userChrome.css and userContent.css so I am lost. I have linked the files in gist below:
Details:

Firefox 64
Ubuntu 14.04
Treestyletabs Addon
Current Full userChrome.css and userContent.css (my modifications are at bottom of each file, if any)
Old userChrome.css and userContent.css with correct contrast (my modifications are at bottom of each file, if any)

I could just restore the old files and forget about it but I would be missing out on the new updated styling Shadowfox gives and any bugfixes etc. Is it possible to restore my old styling?

ShadowFox has styling for TST included in the repo:
https://github.com/overdodactyl/ShadowFox/blob/master/css/userContent-files/webextension-tweaks/tree_style_tab.css
When using the installer, if you check the "auto generate UUIDs" box, styling for all available extensions is activated.
If you want to exclude the styling for an extension, you can delete the entry from the file internal_UUIDs.txt and re-run the updater (without the "auto generate UUIDs" box clicked):
https://github.com/overdodactyl/ShadowFox/wiki/Customization
If you want to keep most of the styling, but override some of the options, you can add custom styling to the userContent_customization.css file and re-run the updater.
For example,
@-moz-document url-prefix("moz-extension://YOUR_TST_INTERNAL_UUID/") {
  #background,
  #background::after,
  #tabbar {
    background: black !important
  }
}

Hope this helps!


closes #126 Upgrade to telebot v3

Codecov Report

Merging #129 (4e144aa) into main (058ea11) will decrease coverage by 1.11%.
The diff coverage is 85.36%.

:exclamation: Current head 4e144aa differs from pull request most recent head f7bc6fb. Consider uploading reports for the commit f7bc6fb to get more accurate results

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   99.43%   98.32%   -1.12%
==========================================
  Files          10       10
  Lines         530      536       +6
==========================================
  Hits          527      527
- Misses          2        6       +4
- Partials        1        3       +2

Impacted Files
Coverage Δ

internal/bot/bot.go
100.00% <ø> (ø)

internal/telegram/client.go
96.73% <81.25%> (-3.27%)
:arrow_down:

internal/bot/handlers.go
94.11% <83.33%> (-5.89%)
:arrow_down:

internal/bot/filters.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 058ea11...f7bc6fb. Read the comment docs.


Allow pgp/inline with sign-only again

While making sign-only a mode of its own I disabled clearsign, to avoid having two "modes" at the same time. Clearsign is a legitimate use case though, so this patch readds it.
I'm not super happy with the icon as it is now, but then again both sign-only and pgp/inline are out of most users' way so far that I don't really care... :)
Fixes #1974.
\ edit
Screenshot for reference:

We support pgp/inline and pgp/mime as encodings, however before this patch pgp/inline wasn't available for sign-only.

Oh I didn't realise that that we'd ever stopped supporting reading any PGP-based mail, merely sending it.

I was indeed talking about sending :)

So why are we supporting INLINE sign only sending when we don't support MIME sign only sending. (I thought this was the question I asked above).

So why are we supporting INLINE sign only sending when we don't
support MIME sign only sending. (I thought this was the question I
asked above).

It’s supported but walled behind an option in crypto settings, right?
But as I understand it, this option only makes it work with PGP/MIME,
not with inline, which this PR intend to fix.


Add pulsar-manager to helm chart

Signed-off-by: xiaolong.ran<EMAIL_ADDRESS>Modifications

Add pulsar-manager to helm chart
Replace pulsar-dashboard with pulsar-manager

Currently, we can deprecate pulsar-dashboard, In later versions, we can use pulsar-manager replace pulsar-dashboard.

@sijie @jiazhai PTAL, thanks.

run java8 tests

run java8 tests


pipenv auto-completion will fail when the path including spaces.

Hi,
I put the following code into my .bashrc,
eval "$(/home/werner/.pyenv/shims/pipenv --completion)"
But, it seems the completion will fail when the project's path including spaces.
Any hints for this issue?

Try  putting '' backslash before the space(s)

Nimish Verma<EMAIL_ADDRESS>于2019年10月5日周六 下午11:51写道：

Try putting '' backslash before the space(s)

Can this be dealed from within the pipenv itself's code?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pypa/pipenv/issues/3965?email_source=notifications&email_token=ACVDTDQSE4EZ5XBNT67XK3TQNCZWZA5CNFSM4I3MWKD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEANVIMY#issuecomment-538661939,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACVDTDXDXNSQD3I4UJEDLODQNCZWZANCNFSM4I3MWKDQ
.

--
Hongsheng Zhao<EMAIL_ADDRESS>Institute of Semiconductors, Chinese Academy of Sciences
GnuPG DSA: 0xD108493

Backslashes before spaces is a pretty common bash pattern, so I don't think we need to detail this within pipenv's code.


[System Classnames]: Allow control of vertical-align in tachyons

I'm not sure if this package is only supporting the props that styled-system supports. If that's the case, feel free to close this.
However, i've been using this along with your macro-components package, and i've tried modifying more props that this package doesn't offer.
This PR allows for changing vertical-align as a prop when using tachyons:
/**
v-base
v-top
v-mid
v-btm
*/

<div v={"-top"} />

(I did check the tests incase one needed adding)

Codecov Report

Merging #163 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #163   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           5      5
  Lines         203    203
=====================================
  Hits          203    203

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e634e3...009dde3. Read the comment docs.

Thanks for this, looks great!


Unable push image to dockerhub

docker push hike/statsd
The push refers to a repository [hike/statsd] (len: 2)
Sending image list
FATA[0060]

docker version
Client version: 1.5.0
Client API version: 1.17
Go version (client): go1.4.1
Git commit (client): a8a31ef
OS/Arch (client): linux/amd64
Server version: 1.5.0
Server API version: 1.17
Go version (server): go1.4.1
Git commit (server): a8a31ef

docker info
Containers: 187
Images: 451
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 825
Execution Driver: native-0.2
Kernel Version: 3.13.0-39-generic
Operating System: Ubuntu 14.04.1 LTS
CPUs: 4
Total Memory: 14.69 GiB
Name: ip-10-0-1-22
ID: S4UN:3TJQ:KWV7:6Q7N:7PIW:2K5N:5NVZ:PNQU:EWPH:MK4P:S6YP:TV2G
Username: hike
Registry: [https://index.docker.io/v1/]
WARNING: No swap limit support

uname -a
Linux ip-10-0-1-22 3.13.0-39-generic #66-Ubuntu SMP Tue Oct 28 13:30:27 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux

I am able to build image from Dockerfile successfully using  docker build -t "hike/statsd" . but unable to push it dockerhub. I am also able to login successfully.

@BlackRider97 can you provide your docker daemon logs? (preferably in docker mode).
Thanks.

Closing since there was never any extra details provided, also this  is reported against a very old version.
Happy to help if you are stilling seeing this and can provide more details, just let us know here.
Thanks!


Popup calendar has extra days in it

Cancelling my question below, as I discovered that this issue was specific to my specific implementation and was able to solve the issue, so no bug to report here. :)
Hello there,
I am running into an issue whereby the calendar that pops up upon me clicking on the input field has the beginning of the following month inserted into the calendar along with the last day of the following month. The bug only occurs for the current month, and when I navigate to the following month, the calendar displays correctly.
I know that's confusing, so you can check out the attached screenshot to see what I mean.

Unfortunately, since I am working in a very large codebase with many files possibly affecting the datepicker part of the application, I am not able to put together an online example, however, here is how I am calling it:
<input type="text" name="{{'date' + exceptionHour.$originalIndex}}"     ng-model="exceptionHour.date"      moment-picker="exceptionHour.date"      format="YYYY-MM-DD"     start-view="month"     max-view="month"     ng-required="exceptionHour"     ng-model-options="{timezone: 'UTC'}"     ng-resource="exceptionHour"     lo-hour-exception-overlap     items="hours.$exceptions">
Has anyone run into this issue before?
Thanks!

Hi @dorono, sorry for looking this so far. I'm happy to see you've solved your issue! :)


isDisplayZoomed always returns true

Summary

Version
10.4.0 - 10.11.0

Affected OS
iOS

OS Version
16.6

Current behavior
Logging the result value from the function isDisplayZoomed on an iOS device always results in the value true.
Logging the result value on a simulator always results in false. This is because there is no display zoom support on the simulator.
I believe the value should change if you adjust the Display Zoom found in the settings Display & Brightness -> Display Zoom and switch between Default and Larger Text
Expected behavior
Display Zoom with value Default:
Result value from isDisplayZoomed on an iOS device should be false.
Display Zoom with value Larger Text:
Result value from isDisplayZoomed on an iOS device should be true
Needed for
This feature is useful to detect if the user is zooming their screen. If the function works correctly, we can optimize the UI for the user.

Hi guys,
Got the same issue on simulator with latest version.
It works great on iPhone 15 Pro Max, isDisplayZoomed() currently returns the good value.
Although, on iPhone 13 mini, isDisplayZoomed() always returns true.
Is there a fix somewhere about this?
Thanks!

Sounds like you've got the hardware available that would allow for inspection and a PR - we could merge a fix easily

My bad, its on simulator, i dont have these devices but its doing that only with this one iPhone 13 mini 17.2


feat(avm): generic bytecode deserialization

Resolves #4304

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit a6179bdb and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,636
180,516
720,036

l1_rollup_calldata_gas
222,444
871,104
3,465,516

l1_rollup_execution_gas
314,931
988,844
3,685,173

l2_block_processing_time_in_ms
1,153
4,343
17,155

note_successful_decrypting_time_in_ms
296 (-1%)
956 (-1%)
3,588

note_trial_decrypting_time_in_ms
106 (-3%)
87.8 (-11%)
145

l2_block_building_time_in_ms
17,878 (-1%)
70,660
283,738

l2_block_rollup_simulation_time_in_ms
13,063
51,614
207,688

l2_block_public_tx_process_time_in_ms
4,787 (-2%)
18,965
75,789

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
13,883 (+1%)
26,302

note_history_successful_decrypting_time_in_ms
2,371
4,600

note_history_trial_decrypting_time_in_ms
104 (+3%)
233 (+7%)

node_database_size_in_bytes
17,293,392
32,989,264

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
309
44,512
26,225

private-kernel-ordering
198 (-1%)
44,545
16,625

base-rollup
1,404
129,002
881

root-rollup
82.3
4,088
677

private-kernel-inner
444
71,703
26,225

public-kernel-private-input
247
32,647
26,225

public-kernel-non-first-iteration
246
32,689
26,225

merge-rollup
7.62
2,608
881

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
17,271
40,063

Transaction processing duration by data writes.

Metric
0 new commitments
1 new commitments

tx_pxe_processing_time_ms
555
1,320

Metric
0 public data writes
1 public data writes

tx_sequencer_processing_time_ms
0.483 (-5%)
591


database content under version control

Hello,
Is it possible in abapgit to put the content of a database under version control?
I have done some tests with different branches, adding and deleting columns and changing the values of the rows.
But switching from a branch with more columns to a branch with fewer columns causes value loss in the additional column in my tests when I commit some changes to the table and return to the branch with more columns.
Is there a way to handle the change of the table structure and table values to the corresponding structure?
Regards,
cpoliwoda

Only development objects are currently serialized, but this would be a very useful addition and has been discussed before. See
#3441, #3763

Hello, FreHu,
Thanks for the answer with the links. I did not find the issues when I searched for the topic.
I am curious if the feature will make it on the implementation list.
Regards,
cpoliwoda


Use mm/s

Use mm/s instead of steps/s
Allows for the counterpart to use SI units instead of steps.
Counterpart of https://github.com/BlueAndi/RadonUlzer/pull/146
Closes #114

Would have been a good oportunity to introduce a user type for speed, something like typedef uint32_t velocity_t.

The change has influence on the PIDs, I only saw one change there. What about calculations at all?

I tested the simulation and this was the only change required for the stability of the platoon

I tested the simulation and this was the only change required for the stability of the platoon

A stability issue means there is a bug or bad parameters. There is no influence just by unit change on stability. ;-)
Anyway you can merge, but the stability issue might still be included and just damped.

Not even an issue when the maximum value possible changes? Then you may be right, and there may still be an issue

Not even an issue when the maximum value possible changes?

No, there is always a max. speed by electronic + mechanic. Every higher value is limited on RU side. Seems for me the problem is on DCS side, that it assumes the higher speed will work, but it doesn't.


 Please pick me apart and tell me everything that is wrong with it (if you have the time).  Did it because of this tweet: https://twitter.com/kiwicopple/status/1664377669935349760 if you need context.
Not sure if it will work but I think it will make it easier

was not on purpose to mark it ready

ok gonna try my best

So I have done some different but I definetely reached my newbie limits. Have spend like 4 hours on it together but I learnt so much so thank you for it! The new one is probably also very very wrong so you can ignore it, but at least I tried. I have school holidays so I am gonna spend some time learning to code with this so that I can finally someday really contribute to it. Should I close this pr?

Hey @Zanyar261 , thanks again for your contribution! I think we will close this in favor of merging https://github.com/jerryjliu/llama_index/pull/4759.
Please do contribute in the future!


Response ETag Header

Summary
What: HTTP responses should send the ETag response header for improved caching. See https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/ETag for more info.
Why: Improve caching.
Acceptance Criteria

The ETag should be present in response headers.
@Lonniebiz points out a potential performance issue. Testing/benchmarking must be included for this feature. See his comment below for more information.

Example Pseudo Code (for implementation)
response.headers.set("ETag", getHeader_eTag());

@diveDylan, closing this since we already have an etag midldeware assigned to you in this repo


Adding the Program.cs file to each module was the issue.

Title: Added Extra API Layer for Better Organization
issue: https://github.com/meysamhadeli/booking-modular-monolith/issues/2
Description:
Added Program.cs to each module and implemented an extra API layer for better organization and maintainability. Also we could have achieved this with a single API layer, but this approach provides a clearer separation of concerns and easier integration with related libraries. I'm open to feedback and discussion on this change, and would appreciate any suggestions on how to improve the design.

Title: Added Extra API Layer for Better Organization
Description: Added Program.cs to each module and implemented an extra API layer for better organization and maintainability. Also we could have achieved this with a single API layer, but this approach provides a clearer separation of concerns and easier integration with related libraries. I'm open to feedback and discussion on this change, and would appreciate any suggestions on how to improve the design.

Hi, Thanks for contribution :)
My goal is having 1 API Layer. And each module have own separate Program.cs. and with this approach each module with using Program.cs can host itself and we don't need to have separate API layer for each module and we need 1 API layer for coordination all of the module and having multiple API leads us to having separated microservices not modular monolith.

I deleted the extra API layer that I had added to each module before, and I added a Program.cs to each module (related class library). Now, each module can be hosted and executed independently.
However, I don't fully understand why we should add Program.cs to a class library (each module) if it cannot be hosted and run on its own. Wouldn't it be more efficient to keep an extra layer, such as a console application or API, that can be executed or hosted directly and reference the related class library? Am I right or wrong in my understanding?

I deleted the extra API layer that I had added to each module before, and I added a Program.cs to each module (related class library). Now, each module can be hosted and executed independently.
However, I don't fully understand why we should add Program.cs to a class library (each module) if it cannot be hosted and run on its own. Wouldn't it be more efficient to keep an extra layer, such as a console application or API, that can be executed or hosted directly and reference the related class library? Am I right or wrong in my understanding?

If we have a separate Api for each module it provides complexity and we don't need it and we just need a simple Program.cs class for running independently each module. (it's also not very force, but it easier to have each module rune separately. But in the end modular monolith we have to one deployment).


code

Looks good. When do you plan to release the training code, pretrained models, etc. ?

Since we lose the access to this github account, please check the codes here, thank you!
https://github.com/pengkang2018/AttentionalTextMaating

Since we lose the access to this github account, please check the codes here, thank you!
https://github.com/pengkang2018/AttentionalTextMaating


All tracks should display Fri/Sat/Sun, but on days that those tracks dont have sessions an "no sessions on this day" is displayed

e.g. for the Saturday sessions, I added fields above each "Sat" for Friday 13 and added "no sessions on this day" in the topic field.

fixed


pytorch implementation

I'm wondering if you also have a PyTorch implementation of the BERT4REC available. Thank you very much!

good question

good question


Running WDA on multiple devices simultaneously using --port

Run in terminal
fbsimctl $device_id launch_xctest ~/....../WebDriverAgentRunner-Runner.app/PlugIns/WebDriverAgentRunner.xctest ~/....../WebDriverAgentRunner-Runner.app --port 8101 -- listen

wda launched, but the port is still 8100.
Is this a bug on fbsimctl?

it's not implemented

I added it, it should work fine now, with port and with any other parameters.


Bring AMDGPU memory model related bits in sync with phabricator reviews

Summary of changes:

Keyword for synchronization scope changed: synchscope -> syncscope
Syncscope argument size changed: 32 bits -> 8 bits
Minor improvements

Phabricator reviews:

https://reviews.llvm.org/D21723
https://reviews.llvm.org/D24577
https://reviews.llvm.org/D24623

I think this looks OK, just make sure to run make check before you merge.

Thanks for taking a look. I tend to run make check before posting reviews :)


[otp_ctrl] add script to use present crypto C lib in python

This PR tries to reuse present crypto C lib in python by:

Write a crypto_present.c function and compile it input a
crypto_present.so library.
In otp_ctrl/util folder, add a crytpo_present.py script to load c
library and use it for 31 round of python calculation.

The crytpo_present.py script includes an encrypt and a decrypt function.
Both functions' inputs are 128 bits key and 64 bits data. Both outputs
are 64bit in hex form
Signed-off-by: Cindy Chen<EMAIL_ADDRESS>

@msfschaffner when you have time, could you take a look and see if this is something you are looking for? I check the script output with RTL and SV, the output should be correct.

Thanks Michael for the suggestions. I just used gcc -o crypto_present.so -shared -fPIC -O2 crypto_present.c to generate the .so library. Would be nice to generate it on-the-fly!
By adding a MakeFile, do you mean a .mk file with this build command, or a shell-script that we can add it to a .mk file later?

Yes exactly. It's a simple command, but better document how it's built now since this is always annoying to dig out at a later stage.
I would recommend to add a simple Makefile alongside the source. You could make .mk file out of it, but typically if there are no other makefiles in that folder, naming it Makefile will make it the default in that folder such that you can just type make to build the default target.

As discussed offline with @sriyerg, we've decided to go with a standard Python library to implement this function (see #5007).
Nevertheless, thanks for the effort you put into this, @cindychip!

As discussed offline with @sriyerg, we've decided to go with a standard Python library to implement this function (see #5007).
Nevertheless, thanks for the effort you put into this, @cindychip!


Historical Data Entry Changes

#284
Some minor fixes/changes to the Historical Data Entry page:

Changed the Success message
Changed the Confirmation Modal message to match the Success message
Fixed date input field allowing 6 digits input for year
Changed the Total Price column in the Historical Data Entry table to Dollar per Credit
Fixed Credits From not being disabled in Edit Mode

 Historical Data Entry | Adjustments to the historical data entry form / page |1| [v0.2.0]


calebromadan token contribution

Why:

What's being changed:

Check off the following:

[x] All of the tests are passing.
[x] I have reviewed my changes in staging.
[ ] For content changes, I have reviewed the localization checklist
[ ] For content changes, I have reviewed the Content style guide for GitHub Docs.

Like my big brother just told me earlier this week,"No excuses"!.


proposal: Add an white list of users

I would like to do the following:
When the PR's author is a maintainer, it's assigned to the author.
When the PR's author is a community member, I assign it to a maintainer that will help with the review process.
The idea would be to add a white list (containing maintainers' username) such that assigning maintainer PR to themself is automatic, but community members are not.
This would allow to search in PRs "assigned to nobody" and see if their is some PR opened by the community with no one assigned to it.

What happens currently when it's a community member? I'd think it wouldn't be possible to assign a PR to someone who isn't a contributor. Does the action just error?


Create async test helpers for frost-select

PROBLEM: When a frost-select component is rendered it is not immediately available in the DOM in order to perform find(hook('facets-name')).find('svg').click() or similar.
PROBLEM: When items are being rendered in a frost-select that are being loaded from an async data call there is (can be) a delay in their rendering. In an acceptance test this delay causes problems because when attempting to interact with these items they are not yet rendered and the test will fail.
SOLUTIONS:

An async test helper should be created and exported as part of of this repo that will resolve its promise

when the control is available in the DOM.
when all of the items have been retrieved and are available in the DOM.

Regarding, "when all of the items have been retrieved and are available in the DOM", how would the test helper know that?  I however do agree interacting with the select in tests is still sub-par, given you have to call .trigger('mousedown') instead of .click() to open it.

The dumb renderer may need to be made a little smarter so that it's aware of how many items it is rendering and then notify when it is complete.  didInsertElement() is called from the inside-out so it would be pretty easy to track this.  The async helper can then tie into this state.
Some very rough pseudo-code to illustrate:

// application template

{{frost-select
  data=model
  isRendered=(action ???)
}}

// frost-select component

{
  hasEverythingBeenRendered: false,

  howManyHaveBeenInserted: 0

  actions: {
    wasInserted() {
      howManyHaveBeenInserted++
    }
  }

  didInsertElement() {
    if (data.count === howManyHaveBeenInserted) {
      this.get('isRendered')()
    }
  }
}

// frost-select template

{{#each option as |option|}}
  {{frost-select-option
    option=option
    onDidInsert=(action 'wasInserted')
  }}
}}

// frost-select-option component

{
  didInsertElement() {
    this.get('onDidInsert')()
  }
}

The select is aware of how many items it is rendering in the sense it can look at the length of the data. It doesn't try and predict how many items it may be rendering at some point in the future (such as when the consumer is feeding it API driven data). Of course in that case it'd be hard to know that length until after the data is fetched, at which point you'd be rendering it anyways.

There are certainly some logistics and architecture that need to be thought about but the initial two problems I listed are ones that are currently being encountered due to rendering delays.  I want to make sure that even if this conversation has arrived at a coding solution that it remains recognized that a solution is needed, even if it's a rethink of how to approach this problem in an acceptance test.

While I'm not sure it quite does whatever it is you are looking for I added two new test helpers in this pull request and an example to make it a little easier to work with the select in tests.

The diff below resulted in this issue no longer being applicable.  I suspect (but have not yet confirmed) that the async helpers have a "wait until the DOM has been rendered" sort of approach because all the that changed below was instead of calling a few synchronous calls they were changed to async ones.  But they both both begin immediately with searching the DOM for an element and not following any other event.
Now that I'm thinking about it some more (and still have not confirmed) the async helpers likely are scheduled to run after render.
       it('selecting an item updates query parameters', function () {
-        // @todo Refactor after https://github.com/ciena-frost/ember-frost-core/issues/385 is resolved
-        $hook('search-input').click()
-        $hook('search-input').click()
-        $hook('search-input').click()
-        $hook('search-input').click()
-        $hook('search-input').click()
-
-        find(hook('facets-name')).find('svg').click()
-
-        // @todo Refactor after https://github.com/ciena-frost/ember-frost-core/issues/385 is resolved
-        $hook('search-input').click()
-        $hook('search-input').click()
-        $hook('search-input').click()
-        $hook('search-input').click()
-        $hook('search-input').click()
-
-        $hook('facets-name-item', {label: 'TestNode13'}).trigger('mousedown')
+        click(hook('facets-name') + ' > svg')
+        triggerEvent(
+          hook('facets-name-item', {label: 'TestNode13'}),
+          'mousedown'
+        )


feat: implement Spatial API

Summary:
This PR is still WIP

Try to cross-reference the WebXR/OpenXR API to see if we can find a middle ground between them and visionOS specifics. It would be nice to be able to use this API across XR devices.

@matthargett Looks like equivalent for WebXR is navigator.xr.requestSession() we can rename the API to XR and methods to:

Spatial.openImmersiveSpace(ID) -> XR.requestSession(ID)
Spatial.dismissImersiveSpace() -> XR.endSession()

WebXR returns session object and it ends the session by calling .end() on this object. I think the closest we can get is XR.endSession()


Swift 3: Date unconditionallyBridgeFromObjectiveC exception

I am using Genome to parse server response to CoreData entity. Exception is thrown when non-optional Date field is parsed:
libswiftFoundation.dylib`static Foundation.Date._unconditionallyBridgeFromObjectiveC (Swift.Optional<__ObjC.NSDate>) -> Foundation.Date:
extension BaseNote {
    @NSManaged var date: Date
    @NSManaged var text: String?
}

override func sequence(_ map: Map) throws {
//...
    try date <~> map["date"]
        .transformFromNode {
            return Date(timeIntervalSince1970: $0)
        }
        .transformToNode { return $0.timeIntervalSince1970 }
}

Note that the problem disappears if I use NSDate in NSManagedObject subclass or make the field optional (Date?). It worked fine before migration to Swift 3.
Please correct me if I'm doing it wrong.

@alexburtnik not sure here, it sounds like something under the hood in Swift. If using NSDate solves the problem, I'd opt for that, but maybe there's some way to create NSDate and then convert it to the newer Date

Closing this for workaround until someone comes back w/ the issue still in 8.1

Not sure if this is the same issue but I ran into something similar when using moc.object(with: NSManagedObjectID) where the objectID was a temp id. The solution was to simply save the context before grabbing the objectID and passing it along.

New objects inserted into a managed object context are assigned a temporary ID which is replaced with a permanent one once the object gets saved to a persistent store.

Like @loganwright said this is indeed something happening under the hood related to swift and core data I left an answer on stackOverflow covering how I solved this issue here.
In short is due to core data and the default behaviour of NSFetchRequest it has a property called returnsObjectsAsFaults that defaults to true and basically what it does is that it doesn't retrieve the actual NSManagedObject fully, but instead tries to fetch its properties when they are accessed.
Picture this scenario:
Thread 1

 - [step 1] let values = Fetch [NSManagedObject]

 - [step 3] let values[0].someDate // here app will crash

Since returnsObjectsAsFaults is true [by default] someDate property was not fetched until you tried to access it.
Thread 2

 - [step 2] update coreData - hence removing objects fetched on Thread 1 - step 1

Solution: if you do need all your properties from the beginning from your NSManagedObject make sure to set on your fetchRequest:
let request = NSFetchRequest<T>(entityName: "someEntity")
...
request.returnsObjectsAsFaults = false


⚠ Bofrost.de has degraded performance

In fcf0a7f, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1376 ms

Resolved: Bofrost.de performance has improved in 58bfc8f after 6 minutes.


Responses mixed up when using proxy, streams and cURL

Q
A

Bug?
yes

New Feature?
no

Version
6.3

Actual Behavior
We are using Guzzle in production to call dozens of different domains from a queue.
Our setup uses:

One Guzzle client
cURL (PHP 5.6.30 on Ubuntu)
an HTTP proxy to proxy HTTP and HTTPS traffic
Streams (specifically: LimitStream), as we limit the amount of bytes from responses we are interested in. We use streams only on a part of the requests.

We don't use any async features.
We've observed that the response retrieved from Guzzle in some cases contains many actual HTTP responses from different requests.

Expected Behavior
We expect Guzzle not to mix up responses.
Steps to Reproduce
We can't really reproduce it locally, so we expect that it has some high concurrency component.
I am sorry I don't have any actual steps to reproduce, but I can provide more information if you let me know what you need.
We had been using a pure cURL solution without reusing cURL handles before, which worked perfectly.
Possible Solutions
We are thinking there might be a problem with reusing cURL handles combined with using streams. I guess streaming from cURL is accomplished by using a write callback so maybe there is a lack of cleanup there?

Thanks for reporting this issue and being the first filling out the questionnaire 😉
Can you give me a dummy example of your code (without sensitive data of course) so that I can (at least try to) reproduce the exact same problem?
Nevertheless I will check the cleanup stuff.

This should be about it.
<?php

$guzzle_config = [
    \GuzzleHttp\RequestOptions::DECODE_CONTENT => 'deflate, gzip',
    \GuzzleHttp\RequestOptions::HEADERS        => [
        'User-Agent' => 'My Custom User Agent',
    ],
];

$guzzle_config[\GuzzleHttp\RequestOptions::PROXY] = [
    'http'  => "tcp://{$this->http_proxy_config->proxy_host}:{$this->http_proxy_config->proxy_port}",
    'https' => "tcp://{$this->http_proxy_config->proxy_host}:{$this->http_proxy_config->proxy_port}",
];

$client = new \GuzzleHttp\Client($guzzle_config);

while ($request = get_request_from_queue()) {

    /*
     * We use streams when we want to limit the body, so not on every request but on ±50%.
     */
    $needs_stream = mt_rand(0, 1);

    $options = [];
    $options[\GuzzleHttp\RequestOptions::STREAM] = $needs_stream;

    try {
        $response = $client->send(
            $request,
            $options
        );
    } catch (\GuzzleHttp\Exception\RequestException $e) {
        $response = $e->getResponse();
    } catch (\GuzzleHttp\Exception\GuzzleException $e) {
    }

    if ($needs_stream) {
        $body_stream = $response->getBody();
        $response_to_handle = (new \GuzzleHttp\Psr7\LimitStream($body_stream, 8192))->getContents();
    } else {
        $response_to_handle = $response->getContents();
    }
    // Further handle response
}

Thanks, I will try to give it a shot soon.

@willemstuursma, have you tried setting CURLOPT_FRESH_CONNECT to true? It disables connection caching in cURL and might help to get rid of such strange things...

We haven't tried that yet, actually we want to re-use connections. Will give it a try.

@willemstuursma, understand that. It's more for debugging: if works, then we know that the problem is in connections reusing.
Also a question: do you use secure (HTTPS) connections?

Also a question: do you use secure (HTTPS) connections?

We are using a mix, 80% HTTPS.

Then maybe this note will help a bit. Anyway, looking forward to updates.


v3: added ref type to the Link component

closes #341

Keep in mind, Link can wrap custom components as well:
<Link>
  <MyCustomLinkComponent />
</Link>

A ref to MyCustomLinkComponent isn't always HTMLAnchorElement.


Illinois

I think I've got Tennessee in a good spot now.  I'll take this one.

I think I've got Tennessee in a good spot now.  I'll take this one.


subject state attribute suggestions

I would like to propose two suggestions for "Attributes" in "Subject state":

drug infusion (should represent recordings taken during the infusion of a drug).
drug treatment (should represent recordings taken while the drug has developed its final "stable" dose).

Thanks for the suggestions. To me, at least the second suggestion sound reasonable. The name would need to be different - something along the lines of "drug treated", "dosed" or "drugged" to be consistent with the naming of other subjectAttributes.
Could you give a rough description of the use case? "drug infusion" is an activity/process, so my first intuition would be to capture it as a protocol/protocolExecution where an undrugged subjectState is linked as input and the drugged subjectState as output. If the subject has been recorded in parallel, then the protocolExecution should reflect that and the recording file could be an additional output next to the drugged subjectState.
In short:
subjectState[undrugged] <--input-- protocolExecution[drug infusion + parallel recording] --output--> subjectState[drugged] + file[recorded data during drug infusion]
The drugged subjectState could then be the input to another protocolExecution for the recording of the "stable" state.
@lzehl what do you think?

@lzehl could you please give some feedback so that we can conclude on a solution for @AnnaHilverling.

@AnnaHilverling thanks for raising this issue. @UlrikeS91 thanks for pushing me to provide feedback :smile:
Adding the terms "untreated" and "drugged" as attributes for subjects should solve case to differentiate between undrugged and fully drugged subject states.
The other case is indeed an interesting problem, since a recording happening while a subject is in the process of being drugged.
@AnnaHilverling I would solve this the following way (without the need of defining protocol executions for now):
subject:

state 1: untreated
state 2: drugged; additional remarks "start of drug administration period"
state 3: drugged; additional remarks "stable drug level period" (maybe you can even state the relative time to state 2)

@UlrikeS91 that would mean we need to add "drugged" and "untreated" to the SubjectAttributes.

@lzehl and @UlrikeS91 thank you for bringing this topic up again :)
I will add this information to additional remarks. As soon as 'untreated' and 'drugged' are available, I will attach these attributes as well.

solved with #175


Redirects & Routes broken in latest release

It appears that version 1.2.1 introduced a bug in \Grav\Common\Pages\Pages https://github.com/getgrav/grav/blob/develop/system/src/Grav/Common/Page/Pages.php#L399
$route = $config->get("site.routes.{$route}"); overrides the $route with null which is passed to the $source_url variable that can't be matched.

Argghhh.. Good catch. This slipped through when i reviewed the PR. Can you please test my fix (linked above)

Looks good to me, successfully tested on my site.  thanks for the quick patch.


Remove unused non-FOSS dependency

See #912

That library was introduced in
https://github.com/xbmc/Kore/pull/839/commits/ddb05f2b85a4eac04d14452efd57d5a3abf32782
Because Google's documentation regarding dynamic shortcuts recommends it:
https://developer.android.com/develop/ui/views/launch/shortcuts/creating-shortcuts
On a more detailed read, it seems that it is only necessary for pushing shortcuts to things like Google Assistant, and the goal was to have dynamic shortcuts available on the launcher, which is possible without the library, so i agree with the removal.


Rebase xsmm to main

Ref to take a look on changes, prepared by xsmm team.

cc @ienkovich, @minjang


Add normal to V9 service meta query

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
[X] Update the CHANGES log.

FYI @Fine0830 This should fix the missing normal status and missing catalog.

FYI @mrproliu We added a new field in listService response in the protocol level.
https://github.com/apache/skywalking/pull/8463/commits/a7dd48c09c39b5b9095c91978a602e2fb23686fc
We need a CLI update.


Carthage Suppot

Can you make this support carthage as well? Thanks

Hi @toftof ,
I never use carthage before,  but sure let me try to make it happen.
Thanks!

perfect and thanks!


Provide better (more) maps

What is the user problem or growth opportunity you want to see solved?
as user of OSM mapnik and mapy.cz I found used map too much googlish (only streets and rivers, missing many ponds, forests, landmarks etc). It should be fine if I can select between more maps (see c-geo app for geocaching)

WMF Map, mapy.cz, openstreetmap.org
Find cross in the middle of field.
https://commons.wikimedia.org/wiki/File:3xDoudleby.jpg
How do you know that this problem exists today? Why is this important?
No response
Who will benefit from it?
No response
Anything else you would like to add?
No response

We changed maps providers, is it better now?

No, there are still only WMF maps, minor roads between fields are hard to recognize, landmarks are misssing, public buildings are not recognizeable

We use WMF maps. Does anyone know whether WMF offer different map styles, rather than just one? If not, the issue probably needs to be raised on Wikimedia's phabricator.

https://phabricator.wikimedia.org/T280460


Monaco hc themes do not follow Windows High Contrast theme colors

monaco-editor version: 0.8.3
Browser: Edge
OS: Windows 10
During Accessibility testing of our product, we’ve gotten a few bugs that assert that Monaco should follow the Windows High Contrast themes when those are selected rather than overriding it with colors for language syntax highlighting and diffs, as is currently done by the hc-black Monaco theme.
I understand that there are technical reasons for supporting the rich user interface that requires setting -ms-high-contrast-adjust to none so that the simplified Windows High Contrast styling can be overridden, but there are also visual design decisions such as maintaining colored syntax highlighting rather than using only white text on a black background (or black on white) as specified by the Windows HC themes.
I understand that the current styling is "As Designed" and I personally don't disagree with it.  I would hate to lose syntax highlighting myself, but I can see the point that we're not following the intent of simplified, high contrast black/white coloring for those visually impaired users who may need it.
Should you decide to try to follow the minimal Windows High Contrast theme colors (for Edge/IE), there are a few resources out there where this is discussed including the limited support for it, a more positive how to use it (including system colors that give the selected HC theme colors), and a JSFiddle that shows all the system color styles.  For example, text color is windowText, selected text has a highlight background, and the background color is window.
If everything in its current state is by design and won't change, then we may at least workaround the syntax highlighting question by creating our own theme(s) that defines everything as black or white (while still providing other language features - not just plain text).  But in any case, it would be good to make any official plans for Monaco publicly visible here for anyone else with the same question.  Thanks.

Here is Visual Studio Community 2015 for reference:

Thank you @jayspadie for the pointers to articles. Here is the editor now on master with the vs theme under Windows High Contrast Black for example:

So going forward there will be two (complementary) options for integrators:

do nothing, keep the editor on the vs theme, and on Edge we will now honour it's high contrast settings.
detect when the browser goes into HC mode (or have a user setting) and use hc-black as the editor theme. This should be used for e.g. Chrome

Sounds/Looks great!  Thanks @alexandrudima .  Nicely done.


GPU monitoring not working (for p3 instances)

After applying PR #4, GPU monitoring data is still not coming through in Grafana. I have a multi-queue ParallelCluster 2.10.0 setup with the following to enable monitoring:
post_install = https://raw.githubusercontent.com/amilsted/aws-parallelcluster-monitoring/main/post-install.sh
post_install_args = https://github.com/amilsted/aws-parallelcluster-monitoring/tarball/main,aws-parallelcluster-monitoring,install-monitoring.sh
additional_iam_policies = arn:aws:iam::aws:policy/CloudWatchFullAccess,arn:aws:iam::aws:policy/AWSPriceListServiceFullAccess,arn:aws:iam::aws:policy/AmazonSSMFullAccess,arn:aws:iam::aws:policy/AWSCloudFormationReadOnlyAccess
tags = {"Grafana" : "true"}

It should be fixed now. Please give it a try.
Thanks

It should be fixed now. Please give it a try.
Thanks

Thanks @nicolaven, it's working now!

Thanks @nicolaven, it's working now!


Add your stakes panel to overview screen

😓 forgot to open this PR.

refs #172

Took over and rebased


Server hangs with no responsewhen running gemma

serve dead, how i to check the problem ,where is logs

Hi @songsh cluld you provide logs and if possible, à script to replicate the issue.
If tou can verify Tagg tou are using the last version of Ollama, it would be great. If Yon can share the configuration of your computer (memory, OS) it could help reproduction the issue or help give explainations.

how to find logs?

how to find logs?

journalctl -u ollama.service
I hope it will help.

Hi there, would it be possible to share the logs? They can be found here: https://github.com/ollama/ollama/blob/main/docs/troubleshooting.md#how-to-troubleshoot-issues

sorry,  i find logs too much,  do not find the dead reason, when i meeting next , i will post it.

Thanks!

Fwiw this happens with llama3 and llava as well.
My temporary/hacky work around on OSX until this is resolved.
1.) Add a timeout handler
2.) On timeout, call:
 async function restartOllama() {
     console.log("RESTARTING", "OLLAMA");
     await exec('pkill -9 "Ollama"');
     await sleep(2_000);
     await exec("open -n /Applications/Ollama.app");
     await sleep(5_000);
     console.log("RESTARTED", "OLLAMA");
 }

If you're still having problems, please share your server log so we can analyze it.  It would also be good to upgrade to the latest release first.


Upload images directly from camera

Description of your request
When trying to upload an image for a plant, I would like to directly upload from camera. I am mostly using this app from mobile and having to take the photo separately and then uploading is more work, than it needs to be.

Describe the solution you'd like
The following code section forms the file dialog:
https://github.com/felixjulianheitmann/hortusfox-web/blob/61bfb1dfd449707ba9c4911c7a0a82abdfb1641e/app/views/layout.php#L545
Updating this with the accept="image/*" attribute will trigger mobile devices to display a prompt where you can select between a file picker/media selector and the camera.
On desktop it usually just opens the file picker.
Additional context

This is what it looks like on my phone, after the change.
I have the changes available in a fork which I used for testing.
https://github.com/felixjulianheitmann/hortusfox-web/tree/camera-upload-picker

Hi, thank you for that report. I'll check that out. There are some various locations where this needs to be updated.


Implement the FIDO AppID extension

This patch implements the appid extension behavior as described in
section 10.1 of the webauthn specification. See
https://www.w3.org/TR/webauthn/#sctn-appid-extension for details.
Namely, this will use the appid as presented in the extensions.appid
field for the ClientData.origin value, rather than the rpId. The
justification for this change is due to compatibility issues with
existing sites which use backward-compatible challenges even if the
authenticator device was never registered as a U2F key. This change has
been tested against Duo security for security keys enrolled with and
without U2F support.
This also modifies the ClientDataJSON generation algorithm to use
separators ':', and ',', without whitespace, to satisfy the requirements
of section <IP_ADDRESS> of the spec (Limited Verification Algorithm), which
states that the expected JSON structure should not have spaces. See
https://www.w3.org/TR/webauthn/#clientdatajson-verification for further
reading. In making this change, I have also used an OrderedDict for the
call to ClientData.build as that guarantees ordering even in versions of
python where this was not intially guaranteed for the standard dict.

Thank you! I'd like to better understand some of these changes: Can you describe the use case being solved by this PR? Is the Fido2Client being used with credentials shared between a browser (where the legacy U2F credentials would have previously been created)? Eg. as some alternative client to using a browser?
Development of this library is happening on the next branch, so please rebase and target this PR for merge into next.
That branch currently supports Python 3.6 and up, and guaranteed ordering of dict keys was added from 3.7. However, since 3.6 is now EOL I think it would be more appropriate for us to drop support for it before the next release, removing the need for OrderedDict.
It's not entirely clear to me that origin should be set differently in the AppId extension case. I'm not seeing anything in the specification that supports this, but maybe I'm missing it. I would think that the origin should remain as passed to the constructor of the Fido2Client class, regardless of if the AppId extension is used or not.

Thanks and I'll rebase onto next and open a new PR. As for the use case, we have a CLI tool that does an SSO login using Duo for the second factor. I had some trouble with Duo Security's challenges as passed by their web service and the only way I could make it work was to change the origin in the ClientData. Changing the rp_id returns an invalid CBOR error, and this is the only way it validates the signature with duo. It's entirely possible I'm missing something else but I couldn't get a U2FClient to work either.
Here's an excerpt of the request(s) and response(s) from duo using the browser (yk, solo) and using alohomora (solohomora). IIRC the solohomora one was not validating.
I'll test a bit with the next branch before I reopen the PR to see if this is really necessary.


Could not find install_carla.sh as manual described in “https://github.com/commaai/openpilot/wiki/CARLA”

Describe the bug
During trying simulate openpilot in PC,  during environment prepare phase could not find install_carla.sh as manual described in “https://github.com/commaai/openpilot/wiki/CARLA”, the whole description section was following:
"
Install openpilot and carla
sudo apt install git
git clone https://github.com/commaai/openpilot.git
cd openpilot/tools/sim
./install_carla.sh
"
So if any info about this issue would be appreciated, thanks a lot!
OS Version
Ubuntu20.04 LTS
openpilot version or commit
No response
Additional info
Manual link:
https://github.com/commaai/openpilot/wiki/CARLA

The wiki page is outdated. The updated instructions are here: https://github.com/commaai/openpilot/blob/master/tools/sim/README.md
I'll update the wiki to point to the readme

OK， Great， very appreciate for your feedback!  : )

OK， Great， very appreciate for your feedback! :


Can't build with Caddy 2.5.2 anymore

go: github.com/caddyserver/transform-encoder@upgrade (v0.0.0-20221013162838-30fca5bfeaa3) requires<EMAIL_ADDRESS>not<EMAIL_ADDRESS>
I build it with xcaddy:
FROM caddy:2.5.2-builder-alpine AS builder

RUN xcaddy build \
    --with github.com/greenpau/caddy-trace \
    --with github.com/ueffel/caddy-basic-auth-filter \
    --with<EMAIL_ADDRESS>\
    --with github.com/caddyserver/transform-encoder

FROM caddy:2.5.2-alpine
COPY --from=builder /usr/bin/caddy /usr/bin/caddy

How to build it against Caddy 2.5.2? I need Caddy 2.5.2 for troubleshooting. Thanks.

--with github.com/caddyserver/transform-encoder@7c3c86b7c749

... was the solution.


Fix issue with the select dropdown on the compliance check page

Description
closes #3425
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
[x] Code is clear and sufficiently documented
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[x] ~End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )~

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

Processing this pull request

Merged into branches iso5, master in ac2dc9ad3629a70562f148a16a75b0501fa6ee38


x/sys/unix: consolidate duplicate information

In the current golang.org/x/sys/unix package, there is a lot of duplication, especially in the GNU/Linux files.  We currently support 13 different GOARCH values, and more are possible.  If I diff, say, zerrors_linux_amd64.go and zerrors_linux_mips.go, I see that a bit more than 500 lines are different, but the files are just over 3000 lines long.  That suggests that we are repeating 2500 lines of information 13 times.
This doesn't really matter all that much, but it does make the package somewhat larger than necessary and makes it slightly harder to review CLs.  Since we generate the information automatically anyhow, I propose that we add another step: run a merge step on all the files for a given GOOS.  For all constants, types, and functions that are defined precisely identically for each GOARCH, move them into a single unified file named simply zerrors_linux.go.  Similarly for zsyscall, zsysnum, and ztypes, of course.  It should be straightforward to write the merge program based using go/ast.  It doesn't have to be smart: just merge definitions that are exactly identical.  If in the future the values are different on some specific GOARCH, the automatic generation should automatically leave the definitions back in the GOARCH-specific files.
CC @tklauser @paulzhol @mdlayher @josephlr

This sounds like a very good idea to me!
While adding this post-processing step using go/ast we could also port the regexp-based post-processing steps in mkpost.go to use go/ast (as has been proposed multiple times in CL reviews already).

Hello,
I am having a "go" at this, since I have been using the go/ast recently and would like to finally contribute to the project.
I have a few questions as I have started looking into this.

You suggest using .go as the file name holding the factored out consts/types/funcs but there already are such files (e.g. syscall_linux.go exists as well as syscall_linux.go). Or should only the z.go files be considered?

Is preserving the blocks of consts important or could they be all merged?
Merging them make the implementation (much?) easier.

Thanks.

We should only be looking at merging information in the generated files, whose names all start with 'z'.  The merged file names should also start with 'z'.  We currently have 13 files zerrors_linux_GOARCH.go.  I'm suggesting that the common aspects be merged into zerrors_linux.go.
We shouldn't touch the non-generated files, at least not with an automated process.
In the generated files it is not important to preserve blocks of constants.

I just sent CL 221318 which merges duplicate code for linux files. To make validation easier, please see https://gist.github.com/jupj/639b5cda305d251161fec2304c27c9b9 for a script, and my results, for comparing the changes in the generated files with the merged files.


Changed the default value

This PR fixes #59952

The documents for this may need a change as well

@najmieh Could you provide some context here? The issue you linked appears to be something in VS Code - this repo is for Azure Data Studio which, while a fork of VS Code, is a separate product and typically changes here don't flow back to VS Code. Did you mean to make the change in their repo instead?

I only could find within this file, The relevant default value for this 	"workbench.tips.enabled": false
I make the necessary changes in other file. Please tell me how to do that.

The VS Code file is here : https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/watermark/browser/watermark.ts#L213
I'm going to close this since I don't currently see us taking this change without more context, if you think this belongs in this repo please add a description of the change and why you're making it in the description of the PR so we can accurately review it.

Ok, thank you for the feedback.


OpenSSL::ParseC: recognise inline function bodies

Function bodies in headers weren't a thing when OpenSSL::ParseC was
created, at least not as clearly as they are nowadays.  This module
must evolve to recognise them (and promptly ignore them).

The problem was detected in #12860

Something's still not quite right, I get weird errors...  but that's because the Makefile has all generated headers twice when building in the source directory.  I'm fixing that.

Ping!

AppVeyor failure seems unrelated.

Merged
fc661b50dfedfed1b067782665e0452ed964c22c OpenSSL::ParseC: recognise inline function bodies
5d942028845b69d761116bb6dfdbee6e095c0d17 Configurations/unix-Makefile.tmpl: Don't specify headers twice


Cannot compile (can't find project)

I can't find the intermediate/projectfiles folder.
So I can't build.

nvm, figured it out


Azure Spatial Anchors demo app is not working on HoloLens 2 Emulator

Hello,
i tried to do the "Azure Spatial Anchors" tutorial and test it on the HoloLens 2 Emulator but it does not work.
I always get the error that the "SpatialAnchorManager is improperly configured" because somehow the spatial perception access is not granted.
The Spatial Perception Capability is activated in the Unity Project and it is also set in the generated Package.appxmanifest file of the Visual Studio solution.
Can you please help me how to solve this?
Or is it generally not possible to test this on the HoloLens 2 Emulator?
Regards
Flo

Dokumentdetails
⚠ Bearbeiten Sie diesen Abschnitt nicht. Er ist für die Verknüpfung von docs.microsoft.com zum GitHub-Artikel erforderlich.

ID: 97b7f65b-2300-1e88-3072-5ecc28e5a8e5
Version Independent ID: 2089610b-9581-ea9b-11c5-7be97e53c584
Content: Tutorials zu Azure Spatial Anchors: 2 Erste Schritte mit Azure Spatial Anchors - Mixed Reality
Content Source: mixed-reality-docs/mr-dev-docs/develop/unity/tutorials/mr-learning-asa-02.md
Product: mixed-reality
Technology: mr-dev
GitHub Login: @jessemcculloch
Microsoft Alias: jemccull

Hi @Flozilla2018 - this is more of a support question. Please submit a ticket here (https://sitehelp.microsoft.com/).

Hi @Flozilla2018 - this is more of a support question. Please submit a ticket here (https://sitehelp.microsoft.com/).


Add links to vulnerability info to results table

I can't figure out how to do it in Bootstrap, but it would be nice to see a link to the vulnerability advisory in the results table.

Hi @tjarrettveracode ! Thank you for checking this out! The change is not hard, I created an example of how to do it here: https://github.com/relaxnow/veracode-container-security-display/pull/2 .
That said, I'd like to understand more about how this helps you triage vulnerabilities.
It is my experience that links in these types of overviews draw the eye and the mouse cursor but do nothing to actually help triage vulnerabilities.
The link is available in the detail view you get when you click the row, it also give you the details and more information.
In working with customers to triage vulnerabilities I find the description and other URLs very helpful.
Could you say more about the workflow of using the links to triage vulnerabilities?

What it would look like:


Unsupported Image type

Hi I was following your tutorial and I passed a pytorch Tensor as a image file in the data loader, but I got the following error:
Process Process-1:
Traceback (most recent call last):
  File "/home/qblocks/instance6/mohit/anaconda3/envs/ffcv/lib/python3.9/multiprocessing/process.py", line 315, in _bootstrap
    self.run()
  File "/home/qblocks/instance6/mohit/anaconda3/envs/ffcv/lib/python3.9/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/home/qblocks/instance6/mohit/anaconda3/envs/ffcv/lib/python3.9/site-packages/ffcv/writer.py", line 112, in worker_job_indexed_dataset
    handle_sample(sample, dest_ix, field_names, metadata, allocator, fields)
  File "/home/qblocks/instance6/mohit/anaconda3/envs/ffcv/lib/python3.9/site-packages/ffcv/writer.py", line 50, in handle_sample
    field.encode(destination, field_value, allocator.malloc)
  File "/home/qblocks/instance6/mohit/anaconda3/envs/ffcv/lib/python3.9/site-packages/ffcv/fields/rgb_image.py", line 325, in encode
    raise TypeError(f"Unsupported image type {type(image)}")
TypeError: Unsupported image type <class 'str'>

Here is my code snippet :
    tr_dataset_func = datasets.COCO('train',args)
    vl_dataset_func = datasets.COCO('train',args)

    train_write_path = "/home/qblocks/instance6/shashank/Development/Watermark_removal/DBWR/DBWR_ffcv/ffcv_data/train/train.beton"
    val_write_path = "/home/qblocks/instance6/shashank/Development/Watermark_removal/DBWR/DBWR_ffcv/ffcv_data/val/val.beton"

    train_writer = DatasetWriter(train_write_path, {"image": RGBImageField(),
                    "target": RGBImageField(),
                    }, num_workers=1)

    val_writer = DatasetWriter(val_write_path, {"image": RGBImageField(),
                    "target": RGBImageField(),
                    }, num_workers=1)

    train_writer.from_indexed_dataset(tr_dataset_func)
    val_writer.from_indexed_dataset(vl_dataset_func)

Here is my return dict from my dataset class :

        return {
                "image": img_wm_t,
                "target": img_t,
                }

where both img_wm_t and img_t are pytorch tensors.
Also what Field should I use if i want to return string path from my Dataset class ??

Hi @shashankvasisht ! I'm not too familiar with the torchvision COCO dataset, do you think you could print the output of print(tr_dataset_func[0]), and also paste in what args is?
As for strings, here is a minimal example:
import numpy as np
from uuid import uuid4
from ffcv.writer import DatasetWriter
from ffcv.fields import NDArrayField
from ffcv.loader import Loader, OrderOption
from ffcv.fields.decoders import NDArrayDecoder
from tempfile import NamedTemporaryFile

MAX_STRING_SIZE = 100

class CaptionDataset:
    def __init__(self, N):
        self.captions = [str(uuid4())[:np.random.randint(50)] for _ in range(N)]

    def __getitem__(self, idx):
        padded_caption = (self.captions[idx] + (" " * MAX_STRING_SIZE))[:MAX_STRING_SIZE]
        return (np.frombuffer(padded_caption.encode('ascii'), dtype='uint8'),)

    def __len__(self):
        return len(self.captions)

dataset = CaptionDataset(100)

with NamedTemporaryFile() as handle:
    writer = DatasetWriter(handle.name, {
        'label': NDArrayField(np.dtype('uint8'), (MAX_STRING_SIZE,))
    }, num_workers=1)

    writer.from_indexed_dataset(dataset)

    loader = Loader(handle.name,
                batch_size=10,
                num_workers=2,
                order=OrderOption.RANDOM,
                pipelines={
                    'label': [NDArrayDecoder()]
                })

    for x, in loader:
        for cap in x:
            print(cap.tobytes().decode('ascii').strip())

Hopefully this was helpful to you @shashankvasisht. If you have more questions feel free to reopen. I'll close in the meantime

Attaching a minimal example of encoding a dataset of strings with FFCV. Please correct me if there is a nicer way to implement this. Note, the data items must be tuples. Also, Loader seems to automatically pad, so no need to pad manually as shown above.
import numpy as np

from ffcv.writer import DatasetWriter
from ffcv.fields import BytesField
from ffcv.loader import Loader

ENC = "utf-8"
DATA_PATH = "data.beton"

def encode(s: str):
    return np.frombuffer(s.encode(ENC), dtype="uint8")

data = [(encode("hello"),), (encode("world!!"),), (encode("how is life"),)]

writer = DatasetWriter(DATA_PATH, {"text": BytesField()})
writer.from_indexed_dataset(data)

loader = Loader(DATA_PATH, batch_size=1)

for item in loader:
    print("raw out\t", item)
    print("decoded\t", item[0].numpy().tobytes().decode(ENC))

Prints
raw out  (tensor([[104, 101, 108, 108, 111,   0,   0,   0,   0,   0,   0]], dtype=torch.uint8),)
decoded  hello
raw out  (tensor([[119, 111, 114, 108, 100,  33,  33,   0,   0,   0,   0]], dtype=torch.uint8),)
decoded  world!!
raw out  (tensor([[104, 111, 119,  32, 105, 115,  32, 108, 105, 102, 101]], dtype=torch.uint8),)
decoded  how is life

This is how to achieve the same with JSONField.
import numpy as np

from ffcv.writer import DatasetWriter
from ffcv.fields import JSONField
from ffcv.loader import Loader

ENC = "utf-8"
DATA_PATH = "data.beton"

def encode(s: str):
    return np.frombuffer(s.encode(ENC), dtype="uint8")

data = [("hello",), ("world",), ("how is life",)]

writer = DatasetWriter(DATA_PATH, {"text": JSONField()})
writer.from_indexed_dataset(data)

loader = Loader(DATA_PATH, batch_size=1)

for item in loader:
    print("raw out\t", item)
    print("decoded\n", JSONField.unpack(item[0])[0])

@axkoenig I tried to use your script regarding a text dataset. However I seem to non-deterministicly fail decoding. I used the exact same code except for masking the CUDA_VISIBLE_DEVICES, as I have a CUDA device I wish not to use.
The decoding fails at a different point each time I execute it.
Examples:
raw out  (tensor([[104, 101, 108, 108, 111,   0,   0,   0, 113,   0,   0]],
       dtype=torch.uint8),)
decoded  helloq
raw out  (tensor([[119, 111, 114, 108, 100,  33,  33, 216,   7,   0,   0]],
       dtype=torch.uint8),)
Traceback (most recent call last):
  File "test.py", line 27, in <module>
    print("decoded\t", item[0].numpy().tobytes().decode(ENC))
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xd8 in position 7: invalid continuation byte

raw out  (tensor([[104, 101, 108, 108, 111, 127,   0,   0,  64, 172,  52]],
       dtype=torch.uint8),)
Traceback (most recent call last):
  File "test.py", line 27, in <module>
    print("decoded\t", item[0].numpy().tobytes().decode(ENC))
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xac in position 9: invalid start byte

@GuillaumeLeclerc Are you aware of any changes to the library that could cause the different behavior? Or is it likely to be a setup issue?

I am also struggling with this original issue and it seems it was not really answered. For some reason I keep getting this "TypeError: Unsupported image type <class 'str'>" error despite me only saving images. Can anybody help me with this?


Spinner causes tilt of the entire aircraft

Spinner causes tilt on 100% symmetrical planes. If u place left-rotating spinner aka propeller, the plane ll tilt right. And the same with right-rotating spinner. It causes left tilt. It makes planes uncontrollable sometimes. I can send video/photo bug capture via discord if is necessary.

thats not a tournament bug, thats vs2
solution:
make two propellers in front of each other, one of them rotates the other direction
issue closed

Thank you so much!

It's kinda realistic.


Reminder (low priority!): update vite config

We currently get a different behavior when running
npm run dev

or
npm run build
node build

where the first one may lead to WebSocket errors. Let's update the vite config, to fix it. Refs (thanks @mfranzon):

https://vitejs.dev/config/server-options.html#server-hmr
https://github.com/sveltejs/kit/issues/844

Closing as obsolete.


Function names can cause infinite recursion

Describe the bug

Most robots generate a function like main() or run() in their code generation regardless of blocks used
The problem is these names are possible custom function names which will then cause infinite recursion in languages like python and errors in languages like java
e.g. you make a function named main() and use it in a robot using python your program would now look like this:
EV3 example:

In python inside run() the last main method would be used which is the normal main method which would then call run which would then call main again causing an infinite loop and the custom function to be ignored
To Reproduce
Steps to reproduce the behavior:

create a program that uses a function called main() or run() in any robot generating these functions
try the generated function structure in an online compiler or the actual robot
See error

Expected behavior

the automaticcaly generated function names should either be called _run and _main
or functions should not be able to be named main or run

Additional context

in java programs the name main is fine due to overloading and it beeing impossible for a user to create a method void main (String[] args) however run() beeing used twice would not compile
this does not happen for calliope functions will automatically be named main2

It is recommended to fix this first in blockly. There we have for each programming language a list of illegal names.

solved


fix: 19920 image opens always with loading spinner

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/19920
PROPOSAL: https://github.com/Expensify/App/issues/19920#issuecomment-1576553796
Tests

Open the App
Login with any account
Go to any chat
Send a jpg image
Open the image you just sent in the preview
Verify jpg image opens the first time with the loading spinner, but the next times without it

[x] Verify that no errors appear in the JS console

Offline tests

same as above
QA Steps

Open the App
Login with any account
Go to any chat
Send a jpg image
Open the image you just sent in the preview
Verify jpg image opens the first time with the loading spinner, but the next times without it

Note When opening the images on Android native, the previews keep loading forever, this issue will be fixed after the PR is merged, so we can ignore testing on Android native

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/113963320/2b99948a-d014-48bf-b9fa-5436b113fc5a

Mobile Web - Chrome

https://github.com/Expensify/App/assets/113963320/b8e7c449-6edc-4fae-bb73-77cc14d0a2cf

Mobile Web - Safari

https://github.com/Expensify/App/assets/113963320/d3906930-f345-4d1e-a1f2-e668484fd1f3

Desktop

https://github.com/Expensify/App/assets/113963320/09bc5510-739e-4848-bcbf-8dc221dc35a3

iOS

https://github.com/Expensify/App/assets/113963320/9353f5ff-2eaf-435e-9020-a9371cd6dc88

Android

https://github.com/Expensify/App/assets/113963320/ff669356-7d6a-4afe-8e4a-604914660956

Is this ready for review?

Also please add a note for the QA team that the android test here is broken and can be skipped

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.28-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
failure ❌

🕸 web 🕸
failure ❌

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅