[SPARK-13474][PROJECT INFRA] Update packaging scripts to push artifacts to home.apache.org

Due to the people.apache.org -> home.apache.org migration, we need to update our packaging scripts to publish artifacts to the new server. Because the new server only supports sftp instead of ssh, we need to update the scripts to use lftp instead of ssh + rsync.

Test build #51897 has started for PR 11350 at commit 19d6e22.

Test build #51900 has started for PR 11350 at commit e43f7ac.

Test build #51897 has finished for PR 11350 at commit 19d6e22.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51897/
Test FAILed.

Merged build finished. Test FAILed.

Test build #51900 has finished for PR 11350 at commit e43f7ac.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51900/
Test FAILed.

Test build #2580 has started for PR 11350 at commit e43f7ac.

Argh, looks like I need to fix some LFTP problems. Hold off on merge or review for now.

Test build #51914 has started for PR 11350 at commit 1bb9e02.

Test build #2580 has finished for PR 11350 at commit e43f7ac.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #51914 has finished for PR 11350 at commit 1bb9e02.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51914/
Test PASSed.

+1

Test build #51983 has started for PR 11350 at commit 52fedd0.

Test build #51986 has started for PR 11350 at commit fc80ac7.

Test build #51988 has started for PR 11350 at commit 1aed97e.

Test build #51983 has finished for PR 11350 at commit 52fedd0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51983/
Test FAILed.

Test build #51995 has started for PR 11350 at commit fde8346.

Test build #51986 has finished for PR 11350 at commit fc80ac7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51986/
Test FAILed.

Test build #51998 has started for PR 11350 at commit 9ef4561.

Test build #51988 has finished for PR 11350 at commit 1aed97e.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51988/
Test FAILed.

Test build #52004 has started for PR 11350 at commit 36c3466.

Test build #51995 has finished for PR 11350 at commit fde8346.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51995/
Test PASSed.

This is now working for package snapshots; will test for doc snapshots soon. See https://home.apache.org/~pwendell/spark-nightly/spark-master-bin/ for what the results look like.

Test build #51998 has finished for PR 11350 at commit 9ef4561.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51998/
Test PASSed.

Test build #52004 has finished for PR 11350 at commit 36c3466.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52004/
Test PASSed.

Test build #52020 has started for PR 11350 at commit e448ae6.

Test build #52024 has started for PR 11350 at commit dd2766a.

Test build #52020 has finished for PR 11350 at commit e448ae6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52020/
Test PASSed.

Merged build finished. Test PASSed.

Woohoo! Doc publishing seems to be working now (albeit slowly), so this should be ready for a final sign-off and merge.

Test build #52024 has finished for PR 11350 at commit dd2766a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52024/
Test PASSed.

Ping @marmbrus for sign-off, since this impacts your 1.6.1 RC. I'll backport this change to branch-1.6 so you can cut that branch.

LGTM.  Thanks for doing this!

I'm going to merge this into master and branch-1.6 so that I can begin packaging a 1.6.1 release candidate.


Add url parameter to Reddit.info

Per Reddit's API documentation, the /api/info endpoint can take a url parameter. The result is a listing of link submissions to that URL. For example, the following yields a listing of links to https://www.youtube.com:
https://www.reddit.com/api/info?url=https://www.youtube.com/
Currently, Reddit.info provides support for the /api/info endpoint, but it only supports the id parameter. It would be nice to have the url parameter as an option as well.

I'd love to take a stab at implementing this.

@darthkedrik awesome! Let us know if you have any questions. Please review: https://praw.readthedocs.io/en/latest/package_info/contributing.html

Will do.
A quick question for you, what do you think would be a more user friendly approach: allowing users to send a list that contains either fullnames or urls, or allowing users to send the function to lists separated into urls and fullnames? My thoughts were towards the first, but I also thought the second could be better for clarity's sake.

I think you're right about clarity, especially since the parameter is already called fullnames. Additionally, I think the implementation will be simpler if the API parameter is identified explicitly by the user, rather than implicitly by the value of the argument.
As a side note, the endpoint doesn't accept a list, just a single URL. If there's a comma in the URL, then it's treated as part of the URL.

To summarize, let's leave fullnames as is, and add another url keyword. These should be mutually exclusive (if I understand correctly), please use a similar approach as is done here:
https://github.com/praw-dev/praw/blob/dfc0eafc2aa84eaf5874952e7d96869c28d62285/praw/models/reddit/subreddit.py#L468
The mutual exclusivity should be tested in a unit test as it does not require network connectivity.
Thanks @darthkedrik!

@darthkedrik any progress on this issue, or an estimate on when you'll have time to work on it?

@bboe Sorry for the late response, I was on vacation for most of this last week. I'm finishing up with this issue, just implementing some tests and it should be good to go.

Awesome. And no worries about the delay, I merely wanted to try to get a status update. Thanks!

@bboe just a quick update for you, I've got it all working and made a new cassette. I've updated the changelog and everything, so I should be all set to open a pull request tonight after work. Now when I pass the optional url parameter I get a list of submissions for that URL.
Should we include somewhere in the documentation a brief warning that the url is taken literally? As is, if you enter "youtube" "youtube.com" and "https://www.youtube.com" you will get a different set of submissions for each one, as reddit treats each as a separate url.

Should we include somewhere in the documentation a brief warning...

That sounds like an excellent idea. Yes, please do that.


Blocking/delaying Windows feature updates?

Can this program be used to block or delay Windows feature updates? If not, could this functionality be added?

The most promising policy setting would be "Select when Preview Builds and Feature Updates are received" (Microsoft.Policies.WindowsUpdate:DeferFeatureUpdates). You could probably use that to defer receiving feature updates for a month at a time. I have not tested this on Home editions, however,


working-groups/buildpacks: Add private repos, remove one

Add 2 buildpacks team private repos
~Remove buildpackapplifecycle which should be part of Platform/Diego area~
Move buildpackapplifecycle to Platform/Diego area

cc @brayanhenao @ryanmoran @dmikusa-pivotal @pivotal-david-osullivan

@arjun024 can you update this PR to add cloudfoundry/buildpackapplifecycle to the ARP charter?
That way we can sort this out in a single PR.

@Gerg Done


Application windows do not dock, primarily when run as Administrator

Microsoft PowerToys version
0.74.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
FancyZones Editor
Steps to reproduce

Open a new Windows command prompt window as Administrator
Press Shift and attempt to drag/dock the window

Other windows that do not dock (even if you don't run as administrator):

Task Manager
Progress Telerik Fiddler Classic

✔ Expected Behavior
Zones to appear and able to dock the window in one of the zones
❌ Actual Behavior
No zones appear.
Note:
When dragging non-Administrator windows, the zones still appear.
Tested with the following applications:

Windows Command Prompt
VS Code
Notepad
Notepad++
Fiddler
GitHub Desktop
PostMan
PowerShell
Chrome
Edge
Firefox
Zoom

When starting the following apps as Administrator:

Chrome
Edge
Firefox
Zoom
they still docked (but their title bar did not show being run as administrator).

Other Software
Edition: Windows 11 Enterprise
Version: 21H2
OS build: 22000.2295

Hi @kevin-mcdowell-docusign, please ensure that PowerToys is running with administrator privileges as well. FancyZones requires this for snapping windows of elevated apps into zones.
Most likely, browsers are not running elevated, so that you're able to snap them to zones.
Please let me know if it helps.
/needinfo

Ahhh, it was set to run in Administrator mode, but it hadn't been restarted in Administrator mode.  thanks

Good to close


no such file or directory on symbolic link

Hi,
Having multiple environments deployed on AWS, we created symbolic links between the files defining common ressources needed in our environment and specific ones, which give the following files hierarchy:
├── common
│   └── common_ressource.tf
├── preprod
│   ├── dedicated_ressource.tf
│   └── common_ressource.tf -> ../common/common_ressource.tf

Running TFsec locally in my preprod folder doesn't raise any error but running the PR commenter action does:
+ TFSEC_VERSION=latest
+ '[' latest '!=' latest ']'
++ wget -q https://api.github.com/repos/aquasecurity/tfsec/releases/latest -O -
++ grep -o -E 'https://.+?tfsec-linux-amd64'
++ head -n1
+ wget -O - -q https://github.com/aquasecurity/tfsec/releases/download/v1.4.2/tfsec-linux-amd64
+ install tfsec /usr/local/bin/
+ COMMENTER_VERSION=latest
+ '[' latest '!=' latest ']'
++ grep -o -E 'https://.+?commenter-linux-amd64'
++ wget -q https://api.github.com/repos/aquasecurity/tfsec-pr-commenter-action/releases/latest -O -
+ wget -O - -q https://github.com/aquasecurity/tfsec-pr-commenter-action/releases/download/v1.0.5/commenter-linux-amd64
+ install commenter /usr/local/bin/
+ '[' -n /github/workspace ']'
+ cd /github/workspace
+ '[' -n '' ']'
+ tfsec --out=results.json --format=json --soft-fail terraform/preprod
WARNING: A tfvars file was found but not automatically used. Did you mean to specify the --tfvars-file flag?
Scan error: open /github/workspace/terraform/preprod/common_ressource.tf: no such file or directory
+ commenter
Starting the github commenter...
The commenter failed with the following error:
failed to load results. open results.json: no such file or directory

My github workflow is written as follows:
name: tfsec-pr-commenter
on:
  pull_request:
jobs:
  tfsec:
    name: tfsec PR commenter
    runs-on: ubuntu-latest

    steps:
      - name: Clone repo
        uses: actions/checkout@master
      - name: tfsec
        uses<EMAIL_ADDRESS>        with:
          github_token: ${{ github.token }}
          working_directory: terraform/preprod

Note that setting working_directory on terraform/common works perfecly.

Hello @owenrumney setting the tfsec_version worked for me, thanks !

Thanks - so if you move to v1.1.0 of the action you'll get symlink support without the need for overriding the tfsec version

This continuous to be an issue in our environment.
`TFSEC_VERSION=latest
17

'[' latest '!=' latest ']'
18
++ wget -q https://api.github.com/repos/aquasecurity/tfsec/releases/latest -O -
19
++ grep -o -E 'https://.+?tfsec-linux-amd64'
20
++ head -n1
21
wget -O - -q ''
22
wget: bad address ''
23
install tfsec /usr/local/bin/
24
COMMENTER_VERSION=latest
25
'[' latest '!=' latest ']'
26
++ grep -o -E 'https://.+?commenter-linux-amd64'
27
++ wget -q https://api.github.com/repos/aquasecurity/tfsec-pr-commenter-action/releases/latest -O -
28
wget -O - -q https://github.com/aquasecurity/tfsec-pr-commenter-action/releases/download/v1.2.0/commenter-linux-amd64
29
install commenter /usr/local/bin/
30
'[' -n /github/workspace ']'
31
cd /github/workspace
32
'[' -n '' ']'
33
tfsec --out=results.json --format=json --soft-fail .
34
commenter
35
Starting the github commenter...
36
The commenter failed with the following error:
37
failed to load results. open results.json: no such file or directory`

Continuous to be an issue.


Change Select Flexible instead of Select Row

https://codelabs.developers.google.com/codelabs/flutter#4
Add a responsive Send button Section
Wrap the TextField inside a Flexible
Wrong: 1. Select Row
Right: 1. Select Flexible

isn't it textfield instead of row?

@cmoulicms
There's similar issue reported a while back which has been transferred to Flutter's website github repo. I'd suggest you to follow-up there for updates and any questions.
Closing from here. If you disagree, write in comments and I'll reopen it.


ReselectTools.registerSelectors() fails if the given object has a null value property

Hi !
I was starting to use the tool, and followed the setup code like this
in my storeCreator.js (setups the store)
import * as selectors from 'selectors/selectors'

ReselectTools.getStateWith(() => store.getState())
ReselectTools.registerSelectors(selectors)

And I was getting this exception

My selectors file seems a regular file
export { selectedObject, selectedObjects } from './objects'
export { vmLoading, vmLoaded, tasksComply } from './project'

I started to inspect the "selectors" object (from import * as selectors) and noticed that it has a couple of extra fields set by babel or whatever the underlying impl of the es modules creates.
And seems like one of those fields was null and made the library break.
I solved it by filtering some properties like this
    const distilledSelectors = Object.keys(selectors).reduce((acc, k) => {
      const v = selectors[k]
      if (v) acc[k] = v
      return acc
    }, {})
    ReselectTools.registerSelectors(distilledSelectors)

But maybe it would be great if the library already fixes this by checking for "selector" to be truthy.
Thanks !

Moving all extension issues into the main repo, per #24


Produce binaries for all supported platforms.

This should let customers avoid needing to build vcpkg on all platforms, and let us assume more recent compilers.
(Microsoft internal links to demo builds:

Test signed: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=5332523
Real signed: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=5332524
)

Other changes and notes herein:

Use a dash to denote arm64 vcpkg binaries rather than a dot since we already shipped the name vcpkg-macos.
Linux "signing" produces a separate PGP signature file which for some reason doesn't exist for test signing, so the extra .sig is expected only there.
I still need to test the whole matrix of Linuxes with this.
Adds native macos arm64 bits.
Adds macos limiter to 10.13 now that we no longer use std::filesystem.
Adds a button to control test signing vs. real signing; test signing is much faster but won't run without jumping through hoops on the target machine to install normally untrusted root certs.
The Windows job we previously used only to sign the mac binaries has been merged with the Windows job that does builds to reduce the number of reimages we trigger in the build lab.
Our special machines, a Red Hat Enterprise Linux 7 box with our dependencies and a recent Ubuntu box with Docker, are controlled using "1ES Managed Images", an internal-only VM management solution where patches are handled centrally for us. (We would love to use that system for everything in vcpkg but outside of signed builds believe that people being able to replicate how our test machines are set up is important enough to not use internal-only systems there)

Testing results:

Alpline 3.11 runs the muslc binary correctly but fails because:

we are broken without VCPKG_FORCE_SYSTEM_BINARIES=1 on non-glibc systems
we detect an invalid x64-linux-musl triplet
we require cmake 3.21 but this Alpine only has 3.15.5

Alpine 3.12 ditto
Alpine 3.13 ditto
Alpine 3.14 ditto
RHEL/CentOS 7 runs the glibc binary OK but fails because we can't acquire a recent enough git (require 2.7.4 but <IP_ADDRESS> is installed)
RHEL/CentOS 8 works
Debian 9 works (and did not work before since we used to depend on filesystem)
Debian 10 works
SUSE 15.3 works
Ubuntu 16.04 works (and did not work before since we used to depend on filesystem)
Ubuntu 18.04 works (I assume all later ones will work)

MacOS works (and did not before because we weren't notarizing)

bion@Billys-MacBook-Pro vcpkg % lipo -archs ./vcpkg
x86_64 arm64


Add ConnectTimeout value

To accomodate for rapid fail scenarios, added ConnectTimeout
configuration value

@amirhalatzi thank you for the PR. I have used this code as a starting point for #245.


Use getRowId instead of index to support the cases where id is not index

          Should we use `getRowId` here instead of `index` to cover the cases where id is not index?

I haven't tested it, but there seem to be 2 issues:

If getRowId is provided, users expect an id-to-data object, but they get an index-to-data which might not be useful.
In case of server side pagination (with manualPagination: true), there can be collisions when constructing selectedRowData as indexes are repeated in every page.

Originally posted by @K-Markopoulos in https://github.com/carbon-design-system/ibm-products/pull/3828#discussion_r1400562984

@K-Markopoulos Thank you for this suggestion! We’ve got a few people on holiday at the moment but we will triage and add to a future sprint at sometime after the holidays. Feel free to contribute a PR for fastest response though. We appreciate your suggestions in #3818^1 and in the PR.


Project Euler 015

euler015

iter :- TLE
new approach:
see closely how the previous approach did not work
new fix:
kindly see code.

iter2 :- TLE
new fix:
store the values in a set.

iter3, iter4, iter5 :- TLE for all except test case 0

euler015

iter6, iter7, iter8 :- TLE
new fix: local set

euler015

iter9 :- TLE 7, 8, 9, 10
fix: see over range of values of MAP_LIMIT.

euler015

iter10 :- same as (9)
fix: hard code some

iter11 :- TLE 5, 7, 8, 9, 10
fix:
put MAP_LIMIT 10000

iter12 :- TLE 7, 8, 9, 10
fix:
take string instead of pair separated by a space


Add setup.py to package the whole project

An (optional) setup.py file should be added to the template in order to be able to create a distribution of the whole Django project. This would allow it to do the deployment using Platter.

Bitbucket: https://bitbucket.org/transcode/transcode-django-project/issue/20
Originally reported by: Markus Zapke-Gründemann
Originally created at: 2015-02-16T22:14:59.000

From Markus Zapke-Gründemann on 2015-02-19 02:33:17+00:00
Furthermore extras_require could be used to replace the requirements files.

From Rene Muhl on 2015-02-26 16:53:58+00:00
I started a branch.


Slow json loading under pypy

For large chunks of JSON data, the following snippet (in e.g. any post request) is very slow under pypy:
request.get_json()

in fact it's 4x slower than doing
import json
json.loads(request.get_data())

Expected behaviour
I would expect using the default get_json to be the happy path and be as fast as the in-built json.loads.
Underlying cause
I tracked this down to the use of the custom JSONDecoder class here: https://github.com/pallets/flask/blob/main/src/flask/json/init.py#L53
Essentially pypy has a fast-path for the default json.loads - and if you use a hand-rolled decoder class you don't get to use that fast path.
Note that the JSONDecoder class does nothing except add some docstrings, but it's very hard for pypy to know that without some horrible introspection of the decoder class every time you call json.loads.
Possible fix
Only set a custom cls= in flask.json.load(s) if something other than the default is set on app.json_decoder.
Environment:

Python version: pypy3.7
Flask version: 2.0.2

Seems like this should be reported to PyPy.

Sorry I was such a pill.
-------- Original Message --------
On 20 Nov 2021, 16:41, Oliver Margetts < @.> wrote:
For large chunks of JSON data, the following snippet (in e.g. any post request) is very slow under pypy:
request.get_json()
in fact it's 4x slower than doing
json.loads(request.get_data())
Expected behaviour
I would expect using the default get_json to be the happy path and be as fast as the in-built json.loads.
Underlying cause
I tracked this down to the use of the custom JSONDecoder class here: [https://github.com](https://github.com/pallets/flask/blob/main/src/flask/json/init.py#L53
Essentially pypy has a fast-path for the default json.loads - and if you use a hand-rolled decoder class you don't get to use that fast path.
Note that the JSONDecoder class does nothing except add some docstrings, but it's very hard for pypy to know that without some horrible introspection of the decoder class every time you call json.loads.
Possible fix
Only set a custom cls= in flask.json.load(s) if something other than the default is set on app.json_decoder.
Environment:
Python version: pypy3.7
Flask version: 2.0.2
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android. ￼
[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "[https://github.com](https://github.com/pallets/flask/issues/4349", "url": "[https://github.com](https://github.com/pallets/flask/issues/4349", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

I reached out to them on irc - the consensus is that this is "hard to fix".
I opened the issue here, because what could be handled as an if statement
within Flask is a complex inspection of the subclass within PyPy, or a
rewrite of their JSON module.
On Sat, 20 Nov 2021 at 15:13, David Lord @.***> wrote:

Seems like this should be reported to PyPy.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pallets/flask/issues/4349#issuecomment-974663553, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACT2HYZG7VF5FMMKCDKE2OLUM63JDANCNFSM5IOAZ6NA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Z-index issues in latest IE (coverflow view)

Hi, I have an issue with wrong z-indexes being applied to my slides in coverflow view in latest IE11.  They don't appear to be calculated correctly as slides to the right of the centred element overlap other slides. This doesn't happen in any other browsers (tested on Chrome, Firefox and Edge).
Here's my configuration:
var swiper = new Swiper('.swiper-container', {     nextButton: '.swiper-button-next',     prevButton: '.swiper-button-prev',     pagination: '.swiper-pagination',     effect: 'coverflow',     centeredSlides: true,     slidesPerView: 2,     mousewheelControl: true,     mousewheelInvert: true,     keyboardControl: true,     spaceBetween: -500,     coverflow: {       rotate: 0,       stretch: 0,       depth: 600,       modifier: 1,       slideShadows: false     }   });
I've also prepared a quick demo: https://jsfiddle.net/LsKs/kqg02gjg/2/.
Chrome:

IE11:

Issue is closed because of outdated/irrelevant/not actual/needed more information/inactivity.
If this issue is still actual and reproducible for latest version of Swiper, please create new issue and fill the issue template correctly:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with issue


pybitmessage: 0.4.4 -> 0.6.2

Motivation for this change
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

It seems kinda strange to me to have pybitmessage in instant-messengers (since it is not meant to be used that way, but rather asynchronously), I think it would fit better in p2p.  Should I change that too?

Oh, forgot to mention:  I only built this on 451478c14fea52402efcb718b1c6992b8554909b and 32bit, since I don't have a 64bit machine at hand and it wants to recompile systemd etc. on master.

ping me when its done and I'll merge

Patching the source to hardcode paths to libraries has preference over
setting LD_LIBRARY_PATH.

I did actually try that first, but gave up after some frustration because
I didn't manage to get it working.  If you think it is important enough
for you (or anyone else who wants to spend their time doing that) to
try it yourself, look at src/depends.py (function check_openssl)
and src/pyelliptic/openssl.py.
@FRidh I think it's done :)

It would help if you show what you tried.

It would help if you show what you tried.

Won't waste any more time on this, sry.  I tried fiddling with the files
I listed above, but I didn't get to any satisfactory (intermediate)
results, so there's nothing to show.  (I don't even remember what I did,
just that I was frustrated enough to search for alternatives.) If you
think this is important enough, try it yourself.

@FRidh Sorry for the rough tone I used in my replies. I got fairly emotional (but I'm not sure how much my replies are showing that) given I didn't agree that the changes you requested would be useful. Now that I know (https://github.com/NixOS/nixpkgs/pull/28824/commits/e9203772f2e19e9abad52297d5a6cd3aaa1c89b5) how easy it would've been (which I kinda assumed), I think your "nitpicking" wasn't that bad. Thanks for your work as a maintainer!


feat: support reading Substrait plans with Window Functions

The changes in this PR allows substrait-java to read in Substrait plans containing window functions (the existing machinary only allowed for generating these plans).
Various roundtrip tests are included in WindowFunctionTests. These tests helped my identify some bugs in the existing code to convert POJO window bounds to PROTO window bounds. I've simplified the handling of these as well.

@jinfengni , can you please review?

Note: this work depends on the refactor in https://github.com/substrait-io/substrait-java/pull/164

PR to add this behaviour to the spec is https://github.com/substrait-io/substrait/pull/540


FlyoutShowMode.TransientWithDismissOnPointerMoveAway not working

Describe the bug
Set Flyout.ShowMode = FlyoutShowMode.TransientWithDismissOnPointerMoveAway would not close the flyout even the mouse moves away
Steps to reproduce the bug
PointerPoint Point = <Your Mouse Point>;

Your_Flyout.ShowAt(Your_Element, new FlyoutShowOptions
{
    Position = new Point(Point.Position.X, Point.Position.Y),
    ShowMode = FlyoutShowMode.TransientWithDismissOnPointerMoveAway,
    Placement = FlyoutPlacementMode.BottomEdgeAlignedLeft,
})

Expected behavior
FlyoutShowMode.TransientWithDismissOnPointerMoveAway works in WinUI2 but failed in WinUI3.
Screenshots

NuGet package version
Windows App SDK 1.4.0: 1.4.230822000
Packaging type
Packaged (MSIX)
Windows version
Windows 11 version 22H2 (22621, 2022 Update)
IDE
Visual Studio 2022
Additional context
No response

Any news on this? I can confirm that this issue is still present in Windows App SDK v 1.4.231219. I might add the following: The dismissal on pointer move away seems to work the first time the flyout is shown (programmatically). On subsequent shows of the flyout, one has to tap outside to dismiss it.

@BendicoE Still exists in Windows App SDK v1.5.0
@bpulliam @duncanmacmichael Could please share any news about this bug? 6 months pass seems you guys even not take a look at this issue.

@BendicoE Thanks for that comment about this only working the first time! The problem was the flyout code forgot to clear variable on close. This resulted in the flyout thinking when it was next shown that it didn't need to re-register an event listener to watch for pointer movement.
The fix is now in for 1.6.

@codendone I think it's a simple fix and should be included in the next 1.5.X rather than wait for a long time until 1.6


Losing Bootstrap styling in production build

Describe the bug
When running npm run build and deploying my react project to netlify, the netlify version of my website loses some of the bootstrap styling...  here is an image of my localhosted version:
http://i.imgur.com/gZoqkY1.png
and here is the link for the netlify version:
https://ncnews-timdowd.netlify.com/
I have ensured to add the relevant stylesheet link in the index.html and added the relevant import into index.js as instructed in the react-bootstrap, bootstrap and CRA documentation, not really sure what is going wrong.  I have found that if I remove the line:
import 'bootstrap/dist/css/bootstrap.css'
from my index.js and run locally I get the exact same problem in my local version as I have in my netlify version, so its definitely something to do with that bootstrap stylesheet not making it to deployment...
To Reproduce
Steps to reproduce the behavior:

Go to https://github.com/timothydowd/FE-NC-News

Click on 'clone repo'

In bash run:
git clone https://github.com/timothydowd/FE-NC-News.git

Then cd into the repo:
cd FE2-NC-News/front-end-nc-news/

Install dependencies
npm install

Run the "start" script to start the application running locally
npm start
Your browser should now be running the front end on a localhost
To stop running the server use ctrl + c

To make your own build..

Npm run build
Log into netlify and drag and drop build folder into netlify's 'sites' tab, this will deploy the site for you.

Environment

Operating System: ubuntu
Browser, Version:  Chrome 74.0.3729.131
React-Bootstrap Version: 1.0.0-beta.8

What is happening
I just tested your application. Bootstrap looks fine. The problem is with your card-** and card** styles priority.
In your case, what is happening is that, in the development, the styles have following priority:
.cardHeader { /* styles for cardHeader */ }
.card-header { /* styles for card-header */ }

Because they both have same level on selection, the bellow one wins. While in production mode
.card-header { /* styles for card-header */ }
.cardHeader { /* styles for cardHeader */ }

So the .cardHeader wins and you get a really big margin around your header.
Why is this happening
In the development mode, react-create-app has different setup for styles loading then in production to make the developer experience better while developing your app. In development, styles are only fetch when you make a request for them. There are other issue which are creating this behaviour.

You are importing App.css in many files. You only have to import it once.
You are including bootstrap in 3 places

in index.html
in index.js
in Nav.jsx

Solution
First, remove all the import for App.css other then from App.jsx. Include bootstrap once (preferably in index.js) BEFORE all your local styles and you will get your development and production build matching.
Why BEFORE ?  That's because, all your vendor css (node_modules) stuff is bundled in a separate css file then your application styles. So if we don't put the vendor css before all of our styles, we may get different UI in development and in production. Because, in the development environment, CRA preserves the order of styles while loading (in this case, application styles first and vendor styles later) but in production, the vendor styles loaded first and application styles later. For example
/* App.css */
body { background: orangered; }

/* Bootstrap.css */
body { background: silver; }

// Loading the application styles before vendor styles
import "./App.css"
import "bootstrap/bootstrap.css"

In development, body element will have background of silver (CRA preserves the order) while in production, body will have a background of orangered (vendor gets least priority).
I hope this helps.

@sudkumar
Thank you very much for your in depth response it is very much appreciated.
I have followed your steps and made the amendments and pushed them to my 'fix-netlify' branch.  After re building and deploying to netlify I unfortunately still get the same result...  Did you try deployment on your side to get it work?
Your time is very much appreciated.

I testing it by building it locally and testing with a local running server. Basically, your netlify result is the final result for your applications styles https://ncnews-timdowd.netlify.com/. We resolved the issues that styles were different on development and on production servers.
if you want your results to match http://i.imgur.com/gZoqkY1.png, you will need to update your App.css file. Basically  you will need to remove cardHeader and cardTitle styles from App.css styles.

@sudkumar
Thank you very much, you solved my problem!


[SD-1502] Fix Timeout exception in ControlServiceSpec

Current coverage is 78.85%

Merging #1118 into master will decrease coverage by -0.01% as of 4344c2b

@@            master   #1118   diff @@
======================================
  Files          171     171
  Stmts         9609    9609
  Branches       319     319
  Methods          0       0
======================================
- Hit           7578    7577     -1
  Partial          0       0
- Missed        2031    2032     +1

Review entire Coverage Diff as of 4344c2b

Powered by Codecov. Updated on successful CI builds.

It seems concerning that 30s isn't sufficient. Any hint as to why it isn't?

@drostron No idea. I don't know if you followed the slack discussion Friday afternoon. But I tried running the tests on my machine and artificially constraining the thread count to two like it should be on Travis and the tests still took 2s to run. I can't think of anything else but Travis vms being really slow. But it is odd because I don't think Travis is that much slower then my machine for the rest of the build. Maybe they have some kind of security code around opening ports or something that makes such an operation drastically slower, that could make sense since we open more than one in rapid fire succession.

Could the port be taken by another test? I'm able to get a timeout exception locally when that's the case. Utilizing anyAvailablePorts might hold promise.

@drostron to the rescue!
That actually makes seems like a rather plausible explanation. Let me investigate.

If that's it, maybe use ExclusiveExecution?

@mossprescott I will look into it, but at this point I am thinking there may be a better solution, i.e being smarter about choosing ports, rather than throttling the build with ExclusiveExecution

This looks like it might have worked since we did not encounter a build failure. Will change the message in the changelog and see if it still passes the builds reliably.

Nevermind, it didn't work.

@drostron Do you think this is good to go if this last build passes?

👍🏾

Closed via merge script.


[2pt]  Display joined missions in My profile - Filters

Render a list of all joined missions (use filter()) on the "My profile" page.

https://github.com/RiyaBulia12/Space-Hub/pull/28


itemReplacementDirectoryName has forgotten the closing bracket when attempt is greater than 0

Description
itemReplacementDirectoryName has forgotten the closing bracket when attempt is greater than 0. It is a local function in FileManager.url(for:in:appropriateFor:create:).
https://github.com/swiftlang/swift-corelibs-foundation/blob/7b5cd129810bccb24a066498814637cb90a7b3cf/Sources/Foundation/FileManager.swift#L154
Steps to reproduce
$ rmdir /tmp/TemporaryItems/*
$ swift repl
Welcome to Swift version 6.0.1 (swift-6.0.1-RELEASE).

Environment
$ swift --version
Swift version 6.0.1 (swift-6.0.1-RELEASE)
Target: aarch64-unknown-linux-gnu
$ uname -a
Linux Raspberry-beetle 6.6.51-v8-16k+ swiftlang/swift-corelibs-foundation#1796 SMP PREEMPT Fri Sep 13 14:39:41 BST 2024 aarch64 GNU/Linux

Is being worked on in https://github.com/swiftlang/swift-corelibs-foundation/pull/5093


Content does not order chronologically

Describe the bug
Content (notes, articles, and case studies) does not order by date. It's currently ordered by the filename.
For instance

markdown-1.md
markdown-2.md

markdown-1 will come first because it comes first in the file system. Ideally, this should be sorted by date of publishing instead.
To Reproduce
Steps to reproduce the behavior:

Add a new file named markdown-3.md to notes.
Make the slug exactly the title (markdown-3.md).
Start the app and go to /notes.
Despite the date specified in the metadata, the order is still determined by the order of the file in the file system.

Expected behavior
The newly added content should show at the topmost position because the date is more recent.

Fixed this issue in this commit


Improving import Boolean-Data from CSV

I try to perform a data import from a csv file into an existing H2-table.
Unfortunately, columns with type boolean cannot imported correctly, if the value is 1 (=true) or 0 (=false).
Dbeaver-Version: 5.3.4

It's common problem of import and DB design, not only in dbeaver. For example https://github.com/ibarwick/firebird_fdw/issues/9
In the CSV you can not declare type of data, your DB must allow {0|1} as boolean. Dbaever can't help, but it's DB's rules.


error occurs with webpack.optimize.UglifyJsPlugin

ERROR in bundle.js from UglifyJs
SyntaxError: Unexpected token: name (WebAudioScheduler) [bundle.js:21953,7]

This should be fixed now


ld: library not found for -lFBSDKCoreKit

When I compile with XCode 7.3.1 I get the following error:
ld: warning: directory not found for option '-L/Users/Dave/Library/Developer/Xcode/DerivedData/Build/Products/Debug-iphoneos/FBSDKCoreKit'
ld: warning: directory not found for option '-L/Users/Dave/Library/Developer/Xcode/DerivedData/Build/Products/Debug-iphoneos/FBSDKLoginKit'
ld: library not found for -lFBSDKCoreKit
Using Cocoapods 1.0.1with this podfile
source 'https://github.com/CocoaPods/Specs.git'
platform :ios, '7.0'
target 'myapp' do
pod 'Google-Mobile-Ads-SDK'
pod 'Google/Analytics'
pod 'Firebase'
pod 'Firebase/Auth'
pod 'FirebaseUI', '~> 0.4'
end
Using a pod update:
pod update
Update all pods
Re-creating CocoaPods due to major version update.
Updating local specs repositories
Analyzing dependencies
Downloading dependencies
Installing Bolts (1.7.0)
Installing FBSDKCoreKit (4.13.1)
Installing FBSDKLoginKit (4.13.1)
Installing Firebase (3.3.0)
Installing FirebaseAnalytics (3.2.1)
Installing FirebaseAuth (3.0.3)
Installing FirebaseDatabase (3.0.2)
Installing FirebaseInstanceID (1.0.7)
Installing FirebaseUI (0.4.0)
Installing Google (3.0.3)
Installing Google-Mobile-Ads-SDK (7.8.1)
Installing GoogleAnalytics (3.14.0)
Installing GoogleAppUtilities (1.1.1)
Installing GoogleAuthUtilities (2.0.1)
Installing GoogleInterchangeUtilities (1.2.1)
Installing GoogleNetworkingUtilities (1.2.1)
Installing GoogleParsingUtilities (1.1.1)
Installing GoogleSignIn (4.0.0)
Installing GoogleSymbolUtilities (1.1.1)
Installing GoogleUtilities (1.3.1)
Generating Pods project
Integrating client project
Sending stats
Pod installation complete! There are 5 dependencies from the Podfile and 20
total pods installed.
[!] Unable to read the license file /Users/Dave/Documents/KSS/myapp/Pods/FirebaseUI/LICENSE for the spec FirebaseUI (0.4.0)
[!] Unable to read the license file /Users/Dave/Documents/KSS/myapp/Pods/FirebaseUI/LICENSE for the spec FirebaseUI (0.4.0)

Strange--it looks like you're getting FBSDKCoreKit downloaded, but for some reason your project can't link the framework. Are you using Swift by chance?

No - Objective-C.

Things should definitely work in Objective-C.  Maybe Facebook only supports iOS 8 and above because they went to dynamic frameworks in CocoaPods (pure wild speculation). If you target 8+ and use use_frameworks! in the podfile does it work?

Thanks for the follow up.  I could not figure out / tinker with this problem so I created a whole new project, copied all my code and image assets to the new project, created new podfile and it is working.  So it appears as though it was some setting in the project that was creating the problem.  Unfortunately I don’t have the time to understand specifically what the problem is.  I need to move on at this point.

On Jul 12, 2016, at 5:01 AM, Michael McDonald<EMAIL_ADDRESS>wrote:
Things should definitely work in Objective-C.  Maybe Facebook only supports iOS 8 and above because they went to dynamic frameworks in CocoaPods (pure wild speculation). If you target 8+ and use use_frameworks! in the podfile does it work?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/firebase/FirebaseUI-iOS/issues/76#issuecomment-231994781, or mute the thread https://github.com/notifications/unsubscribe/AI8vASnvDRhWMpmSwx18IVi-zX5YIbwMks5qU2YOgaJpZM4JDbtx.

I usually run pod deintegrate, clean, and re-build--but if some random xcconfig was broken then that's usually a good plan :)
Glad you got it working again!


fix(compiler-dom): should bail when node uses html directives.

fix: #5439

v-html with constant value is stringifiable, we just didn't implement the logic for it. See https://github.com/vuejs/core/commit/6283b2ec413b78fe88775d249d3598cdce977b7a


stream-settings: Add support for subscribing all members of a user groups to stream.

Fixes: #15186.
It adds support for user group pills to subscribe user groups to stream.
This completes and extends work done by @ryanreh99 in pr #16517
Testing plan:
Manually in dev server.
Adding/modifying node tests to cover new changes.
GIFs or screenshots:

Checking the working of copy paste

@timabbott
Thanks for merging this.
I went through the points about cleanup you suggested, but I am not clear about the third point. does that mean that on pasting a comma separated email addresses, input field should not automatically create pills for valid addresses but show them in typeahead?
I'll start working on other two points for now.


[HOLD #38702] Update avatars depending on the number of requestors on the report

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

*Version Number: v1.4.70-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL: N/A
Issue reported by: @shawnborton
Slack conversation: N/A discussion here
Coming from this issue. Align our icon usage (and ensure that the icon and personal details are loading correctly) for the report preview, report, and transaction thread.
Action Performed:
1:1 IOU with requests from a single user

Create a chat with another user
Make one (or multiple) money requests to the user from your current account

1:1 IOU with requests from both users

Create a chat with another user
Request money from them
Have them request money from you

Workspace chat

Log into an Expensify account
Create a new workspace
Navigate to the workspace chat and make one (or multiple) money request

Expected Result:
1:1 IOU with requests from a single user

We use a single-user avatar for the report preview on the chat, the report header, and the transaction thread header

1:1 IOU with requests from multiple user

We use a dual-diagonal-user avatar for the report preview on the chat, the report header, and the transaction thread header

Workspace Chat

We use a large-user-small-workspace avatar for the report preview on the chat, the report header, and the transaction thread header

Actual Result:
1:1 IOU with requests from a single user and 1:1 IOU with requests from multiple user

We occasionally show default avatars without personal details for the report preview. When personal details do load, we display the diagonal-dual-user avatar.

For the report itself, we display either the diagonal-dual-user or single-user avatar on the report level depending on whether or not the expense has multiple expenses or only one expense.

Workspace Chat

We occasionally show default avatars without personal details for the report preview. When personal details do load, we display the diagonal-dual-user avatar.

For the report itself, we correctly display the large-user-small-workspace avatar

Workaround:
N/A this doesn't impact the ability to use the app
Platforms:
Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Still holding

And vip-split is paused so I'm gonna close this until we refocus on it.


App Service logs cannot be output to a Storage Account in a different region.

There is a public documentation that suggests that App Service logs can be output to a Storage Account in a different region than the App Service.
However, when choosing where to output App Service logs from Azure Portal, we cannot select a Storage Account in a different region, nor can we configure it from the Azure CLI.
I know it is recommended to use diagnostic settings instead of App Service logs, but please correct the public documentation.
https://learn.microsoft.com/en-us/azure/app-service/troubleshoot-diagnostic-logs#networking-considerations

The Azure Storage account is in a different Azure region from the App Service app.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bfc316af-0d30-b449-a04f-3019b7a16bc1
Version Independent ID: 01c4c435-fda9-374a-70b3-f1d7f13c7651
Content: Enable diagnostics logging - Azure App Service
Content Source: articles/app-service/troubleshoot-diagnostic-logs.md
Service: app-service
GitHub Login: @msangapu-msft
Microsoft Alias: msangapu

@tatsuyaHello
Thanks for your feedback! We will investigate and update as appropriate.

Refer to merged and linked PR above for fixes to remove references for storage being in different region.

#sign-off


vue create fails with TypeError

Using the vue cli to create a vue 2/3 project fails to complete.
Version
4.5.3
Environment info
  System:
    OS: macOS High Sierra 10.13.6
    CPU: (8) x64 Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz
  Binaries:
    Node: 12.15.0 - ~/.sdkman/candidates/java/current/languages/js/bin/node
    Yarn: Not Found
    npm: 6.13.4 - ~/.sdkman/candidates/java/current/languages/js/bin/npm
  Browsers:
    Chrome: 84.0.4147.105
    Edge: Not Found
    Firefox: Not Found
    Safari: 12.1.2
  npmGlobalPackages:
    @vue/cli: 4.5.3

Steps to reproduce
Make sure you have GraalVM 20.1.0 installed and afterwards ran npm install -g @vue/cli after that.
Next run 'vue create .'
What is expected?
A bootstrapped project.
What is actually happening?
You get a TypeError: Cannot read property '1' of null on line 455 of GeneratorAPI.js

The issue seems to be with the following method:
function extractCallDir () {
  // extract api.render() callsite file location using error stack
  const obj = {}
  Error.captureStackTrace(obj)
  const callSite = obj.stack.split('\n')[3]
  const fileName = callSite.match(/\s\((.*):\d :\d \)$/)[1]
  return path.dirname(fileName)
}

This function uses the non-standard V8 API Error.captureStackTrace and relies on V8's internal stack trace format, so it's very likely to break when executed by GraalVM.
I haven't used GraalVM so I don't know how to fix it. Any help would be appreciated.

I was not able to reproduce this problem on Linux (using this docker image as a starting point).  Could it be a macOs + GraalVM issue?
Vue Environment Info:
  System:
    OS: Linux 5.4 Debian GNU/Linux 9 (stretch) 9 (stretch)
    CPU: (4) x64 Intel(R) Core(TM) i5-6600 CPU @ 3.30GHz
  Binaries:
    Node: 12.15.0 - /opt/graalvm-ce-java11-20.1.0/bin/node
    Yarn: Not Found
    npm: 6.13.4 - /opt/graalvm-ce-java11-20.1.0/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: Not Found
  npmGlobalPackages:
    @vue/cli: 4.5.9

node --version:graalvm
GraalVM CE Native Polyglot Engine Version 20.1.0
Java Version 11.0.7
Java VM Version GraalVM 20.1.0 Java 11 CE
GraalVM Home /opt/graalvm-ce-java11-20.1.0
  Installed Languages:
    JavaScript version 20.1.0
    LLVM       version 20.1.0
  Installed Tools:
    Agent Script            version 0.6
    Code Coverage           version 0.1.0
    CPU Sampler             version 0.4.0
    CPU Tracer              version 0.3.0
    Heap Allocation Monitor version 0.1.0
    Insight                 version 0.6
    Chrome Inspector        version 0.1
    Language Server         version 0.1
    Memory Tracer           version 0.2

I also tried GraalVM with Java 8 but same result.

I was not able to reproduce this problem on Linux (using this docker image as a starting point).  Could it be a macOs + GraalVM issue?
Vue Environment Info:
  System:
    OS: Linux 5.4 Debian GNU/Linux 9 (stretch) 9 (stretch)
    CPU: (4) x64 Intel(R) Core(TM) i5-6600 CPU @ 3.30GHz
  Binaries:
    Node: 12.15.0 - /opt/graalvm-ce-java11-20.1.0/bin/node
    Yarn: Not Found
    npm: 6.13.4 - /opt/graalvm-ce-java11-20.1.0/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: Not Found
  npmGlobalPackages:
    @vue/cli: 4.5.9

node --version:graalvm
GraalVM CE Native Polyglot Engine Version 20.1.0
Java Version 11.0.7
Java VM Version GraalVM 20.1.0 Java 11 CE
GraalVM Home /opt/graalvm-ce-java11-20.1.0
  Installed Languages:
    JavaScript version 20.1.0
    LLVM       version 20.1.0
  Installed Tools:
    Agent Script            version 0.6
    Code Coverage           version 0.1.0
    CPU Sampler             version 0.4.0
    CPU Tracer              version 0.3.0
    Heap Allocation Monitor version 0.1.0
    Insight                 version 0.6
    Chrome Inspector        version 0.1
    Language Server         version 0.1
    Memory Tracer           version 0.2

I also tried GraalVM with Java 8 but same result.

Issue doesn't occur any more in newest version. Closing the issue.


Gitea service uses wrong config file

Describe the bug
The service tries to find the config in the nix store (/nix/store/hfpbw4ylk29bm0fqf7nbw6alwmy2z216-gitea-1.16.9/bin/custom/conf/app.ini), but it actually exists in /var/lib/gitea/custom/conf/app.ini
Steps To Reproduce
Steps to reproduce the behavior:

Enable gitea service

services.gitea = {
  enable = true;
};

Check gitea.service unit status

Expected behavior
Use the correct config file.
Additional context
The error can be corrected by adding the -c flag, in all gitea commands.
❯ gitea -h
..skipped..
DEFAULT CONFIGURATION:
     CustomPath:  /nix/store/hfpbw4ylk29bm0fqf7nbw6alwmy2z216-gitea-1.16.9/bin/custom
     CustomConf:  /nix/store/hfpbw4ylk29bm0fqf7nbw6alwmy2z216-gitea-1.16.9/bin/custom/conf/app.ini
     AppPath:     /nix/store/hfpbw4ylk29bm0fqf7nbw6alwmy2z216-gitea-1.16.9/bin/gitea
     AppWorkPath: /nix/store/hfpbw4ylk29bm0fqf7nbw6alwmy2z216-gitea-1.16.9/bin

Notify maintainers
@aanderse @pennae @Izorkin @dasJ @etu
Metadata
❯ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.59, NixOS, 22.05 (Quokka), 22.05.20220814.8791216`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.8.1`
 - channels(root): `"nixos-22.05"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

I tried to run it on another machine - everything works there. Closing.

https://github.com/NixOS/nixpkgs/issues/94751 - not the same case?

#94751 - not the same case?

No, in this case gitea did not start at all.


en: add OpenAPI docs

First-time contributors' checklist

[x] I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added, or deleted? (Required)

Which DM version(s) do your changes apply to? (Required)

[x] master (the latest development version)
[ ] v2.0 (TiDB DM 2.0 versions)
[ ] v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

This PR is translated from: https://github.com/pingcap/docs-dm/pull/812
Other reference link(s):

Do your changes match any of the following descriptions?

[ ] Delete files
[ ] Change aliases
[ ] Need modification after applied to another branch
[ ] Might cause conflicts after applied to another branch

LGTM

/hold

/remove-status LGT1
/status LGT2

/merge


Master p10

Fix spelling mistakes

This change went in a long time ago, I guess the auto-close didn't work.
commit 865288f3640e5e37340844e1cb37f9bfc0ce6c3b
Author: dongshijiang<EMAIL_ADDRESS>Date:   Wed Jul 14 16:00:59 2021 +0800
Update vfs_main.C

Fix spelling mistakes

Resolves #198
Change-Id: I862ad97885540b6d06fd6f68ceb232782e57fc1c


Kitty documentation improvements

A list of minor improvements to make to the Kitty documentation on lionsos.org.

Need to talk about hardware setup for UART more with pictures - when we're doing development on the fully assembled Kitty this would be really useful as we always forget what cables go where.
Need to talk about font generation and picture generation. Need to mention picture is expected to be on NFS server, somehwere.
Need to split running section into QEMU vs hardware. (e.g QEMU uses serial input for card taps instead of an actual I2C device).
Need to talk about how server is cycling through possible responses with https://github.com/au-ts/lionsos/pull/108.
Update picture of Kitty - some UI changes have been made recently and we should take the picture in better lighting!

Made https://github.com/au-ts/lionsos_docs/issues/10 instead.


Elementum 0.53 loads the buffer but does not start the video (amlogic s905x)

It was a problem with advancedsettings.


cache registry downloaded

motivation: better performance when using registry
cached:

introduce RegistryDownloadsManager which manages the downloads across the local and cache
integrate RegistryDownloadsManager into Workspace, which now uses it to download from registry instead of the registry client directly
update workspace delegate to handle callback from registry downloads, and propogate them to workspace delegates
improve / generalize the workspace fetching delegate methods such that they are appropriate to both repositories and registry downloads
deprecate --enable-repositories-cache/--enable-disable-cache in favor of --enable-dependencies-cache/--disable-dependencies-cache
fix several download and unzip edge cases which came to bear now that a cache is in place
add and adjust tests

@swift-ci please smoke test

@swift-ci please smoke test


feat: Execution workflow for APA-Scan

Fixes #26
Checklist

[ ] I have performed a self-review of my own code
[ ] My code follows the templates/style guidelines of the repository
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have tested my code

NB: This workflow has already had reviews on the 2 different joint pull requests. Check them out for complete set of comments
1 - https://github.com/iRNA-COSI/APAeval/pull/98
2 - https://github.com/iRNA-COSI/APAeval/pull/87
Have moved to separate branches as requested to make it easier to review each method.
Won't copy all comments, but major changes are needed. I will return this to in-progress until I make the suggested major changes.

[ ] Make Euan's code-base changes on a fork of main repo. Pull request/issue for author's to comment on main issue
[ ] Dockerfile for workflow
[ ] configuration.ini to be made run-specific in main output results directory, not overwritten with each run.
[ ] Trim down comments in Snakefile
[ ] Clarify changes made to code base in README (and lack of 3'end-seq integration)

Splitting up required tasks into 'workflow-related' and 'code-related', so people with no Snakemake experience can still help out with the workflow!
Code related:

[ ] Make a fork of main repo. Add Euan's fixes/changes to code-base, submit pull request/issue to main repo for author comments
[ ] Dockerfile for APAScan dependencies (and use fork)

Workflow related:

[ ] Make configuation.ini in main output directory (i.e. it is run-specific)

Docs related:

[ ] Trim down comments in main Snakefile. Move some to main README.
[ ] Explain code base changes in main README. Clarify that workflow cannot integrate 3'-end seq data.

If you want to help out, drop a comment here saying what you'll work on and assign yourself to the workflow :)

Even with larger test files I am still struggling with empty output files. Before this gets lost from my head and notes, want to note here a number of bugs/niggles that are causing me problems. I'm not convinced the code in the Github repo as of the latest commit (or even previous commits) is fully functional.
Since @EuancRNA worked on this workflow during the hackathon, there have been a number of changes to the code base. In the hope that these changes may have fixed the bugs Euan reported I opted to work with later code. This appears to have as many problems as before.
Mixed space and tabs in indentation
Minor gripe but this makes it a pain to add debugging print statements...
Input BAM files & annotation files must have a 'chr' chromosome name prefix
In lines 59-61 of APA-Scan.py, a list of chromosome names is extracted from the reference annotation. Line 60 assumes the 'chrom' column is stored as a string datatype, but this is not guaranteed if chromosome names don't have the 'chr' prefix (I came across this problem with our 'noChr' test files). It would be safer to ensure the input files have the 'chr' prefix (which would be the case if we use Gencode annotations).
If we wanted to modify, you can ensure the 'chrom' column is stored as a string datatype by modifying line 59 to:
df = pd.read_csv(inp_annotation, delimiter='\t', dtype={'chrom': str})
Transcript IDs are hardcoded to start with an 'NM_' or 'NR_' prefix
This occurs twice in the methods.py - 1, 2. If we want to use Gencode transcript annotations, we will have to pass a modified GTF where we manually add these prefixes to transcript IDs. The workflow should also check that the annotation file contains transcript IDs with these prefixes in the expected column (otherwise will get empty output).
Inconsistent extraction of columns by index from input coverage and reference annotation files
This appears to be systematic and does not reflect the files input to or produced by APA-Scan. Many of these issues appear to stem from a commit in July 2021.
Wrong column index when extracting genome coordinate from coverage files
APA-Scan produces coverage files that look like below:
$ head test_500_APA_Scan_results/control/siControl_1/chr10.txt
chr10    7725986    1
chr10    7725987    1
chr10    7725988    1
chr10    7725989    1
chr10    7725990    1
chr10    7725991    1
chr10    7725992    1
chr10    7725993    1
chr10    7725994    1
chr10    7725995    1

In a commit from July 2020, methods.py is updated to extract the first column value for each row to store as 'position_row'. This results in the error message below. Judging from the variable name & operation performed it is likely this should be the coordinate in the 2nd column:
Traceback (most recent call last):
  File "APA-Scan.py", line 84, in <module>
    methods.with_PAS_signal(chromosomes, input1_dir, input2_dir, s1_namelist, s2_namelist, g1_name, g2_name, output_dir, result_filename)
  File "/home/sam/GitHubRepos/APAeval/execution_workflows/APA-Scan/methods.py", line 740, in with_PAS_signal
    bam_list, position_row = read_bamfiles(input1_dir, sample1, chrom)
  File "/home/sam/GitHubRepos/APAeval/execution_workflows/APA-Scan/methods.py", line 99, in read_bamfiles
    position_row = [int(bam_list[i][0]) for i in range(len(bam_list))]
  File "/home/sam/GitHubRepos/APAeval/execution_workflows/APA-Scan/methods.py", line 99, in <listcomp>
    position_row = [int(bam_list[i][0]) for i in range(len(bam_list))]
ValueError: invalid literal for int() with base 10: 'chr11'

Changing bam_list[i][0] back to bam_list[i][1] should fix the error...
Wrong column index when extracting coverage value/count from coverage files
In the same commit, the countCoverage function is updated to extract read depth from the 2nd column, where previously it extracted from the 3rd column. In line with the example coverage files displayed above this should be extracting from the 3rd column, otherwise it is taking the genome coordinate as the coverage...
Wrong column index when checking for valid transcript ID prefixes
The reference annotation looks like this (1st row is header, 2nd is a data row)
bin	name	chrom	strand	txStart	txEnd	cdsStart	cdsEnd	exonCount	exonStarts	exonEnds	score	name2	cdsStartStat	cdsEndStat	exonFrames
0 NM_ENSMUST00000193812.1 chr1 + 3073252 3074322 3074322 3074322 1 3073252, 3074322, 0 ENSMUSG00000102693.1 none none -1,

The reference annotation above was generated using the execution workflow. It is identical to the format described in the documentation and example Refseq annotation downloaded from the UCSC Genome Browser below (aside from first column name '#bin' vs 'bin'):
#bin	name	chrom	strand	txStart	txEnd	cdsStart	cdsEnd	exonCount	exonStarts	exonEnds	score	name2	cdsStartStat	cdsEndStat	exonFrames
0	NM_001291928.1	chr1	-	134199214	134234856	134202950	134234733<PHONE_NUMBER>,134234662,	134203590,134234856,	0	Adora1	cmpl	cmpl	2,0,
0	NM_001008533.3	chr1	-	134199214	134235457	134202950	134234355<PHONE_NUMBER>,134234014,	134203590,134235457,	0	Adora1	cmpl	cmpl	2,0,

If you checked the code linked above in previous section, you may have already spotted that the tx_id prefix check is operating on the 'chrom' column and not the 'name' column. Lines 353-356 illustrate this. 'rowsOfChr' is generated by checking whether 3rd field is current chromosome. The same field is then used to check if the transcript ID has the correct prefix (copied below):
for (geneId, strand) in geneList:
    rowsOfChr = df.loc[(df[2] == chrom) & (df[12] == geneId)]
    targetList = []
    for row in rowsOfChr.itertuples():
        if str(row[2].strip()).startswith('NM_') or str(row[2].strip()).startswith('NR_'):
            #etc etc

If row[2] is replaced with row[1] this should operate on the correct column.
Again note that this also occurs a 2nd time at lines 632-635
All column indexes are +1 from actual columns when extracting transcript model info from annotation
Similar to transcript ID checking above, extracting transcript model information from the reference annotation file is all one-off in terms of respective column. Lines 636-644 illustrate this. For example, 'exonCount' is extracted as row[9]. It is the 9th column in the annotation files (see above examples), but Python indexing starts at 0 so therow[8] corresponds to the 9th column
I'm currently running APA-Scan with a larger subset of the test data (the P19 '500 genes' subset on the Google Drive). At the time of commenting this has been running for ~3.5 hours...


Avoid "obsolete" warnings when referenced by other obsolete objects

Title
Throw "obsolete" warnings only if the object is referenced from non obsolete code.
Description
This ist not a suggestion for a new rule but request to change behaviour of an existing rule.
Scenario:
You set a page and corresponding table to "obsolete".
This generates a warning (AL0432) , if you try to reference the page in your code.
This is intended and ok.
But as you cannot delete the page immediately it still resides in your code and unavoidable references a table which is also set to obsolete.
This may generate a lot of warnings, even if you don't use this page and table anymore.
You cannot create extensions containing some obsolete objects without warnings!
Reason for the rule
To avoid too much warnings from code which is effectivly not in use it should be possible to suppress such warnings where not needed.
Bad code sample
Example of what bad code the rule should (NOT) catch:
page 12345 "MyPage"
{
Caption = 'Tooltip Fields';
PageType = ListPart;
UsageCategory = None;
SourceTable = "MyTable";  // This generates an unneccessary warning
                          // if MyTable is also set to "obsolete", but I can't remove this reference here
                          // without destroying the functionality (which may still be used by an other extension).

ObsoleteState = Pending;
ObsoleteReason = 'Deprecated';

....

}
Good code sample
Example of what code should look like:
No changes in code needed, but obsolete warning should be suppressed if the calling object is already obsolete.
That means throw this warning only, if an obsolete object is referenced by a not obsolete object.
Good and bad practices for fixing the rule
Remarks
This is just to suppress needless warnings which make it difficult to notice other more important warnings.

This looks like a duplicate of #5936

Sorry, I did'nt find this entry. It seems to be exactly the same problem.
I will close this issue.


linux_zen: 5.14.15-zen1 -> 5.15-zen1

Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

5.15.1 is out
diff --git a/pkgs/os-specific/linux/kernel/linux-zen.nix b/pkgs/os-specific/linux/kernel/linux-zen.nix
index 3d4629bfdfb..73bc0bbbb8a 100644
--- a/pkgs/os-specific/linux/kernel/linux-zen.nix
+++ b/pkgs/os-specific/linux/kernel/linux-zen.nix
@@ -2,7 +2,7 @@

 let
   # having the full version string here makes it easier to update
-  modDirVersion = "5.15-zen1";
+  modDirVersion = "5.15.1-zen1";
   parts = lib.splitString "-" modDirVersion;
   version = lib.elemAt parts 0;
   suffix = lib.elemAt parts 1;
@@ -19,7 +19,7 @@ buildLinux (args // {
     owner = "zen-kernel";
     repo = "zen-kernel";
     rev = "v${modDirVersion}";
-    sha256 = "sha256-CFJ9JOngUgQoKT2gPBOR9kHD9uYjsWndZIG1H0ziFec=";
+    sha256 = "sha256-mDAwsqLR55WFaPKO1SXZuxeuaFzprMY4ryeEUdCqKGU=";
   };

   structuredExtraConfig = with lib.kernel; {


oadp-1.2: Moving kopia logging to remove kopia from indirect dependency in vele…

…ro plugins
when running go mod why -m github.com/kopia/kopia in velero-plugins prior to this change you will see following
❯ go mod why -m github.com/kopia/kopia
github.com/konveyor/openshift-velero-plugin/velero-plugins
github.com/vmware-tanzu/velero/pkg/plugin/framework
github.com/vmware-tanzu/velero/pkg/util/logging
github.com/kopia/kopia/repo/logging

after
❯ go mod why -m github.com/kopia/kopia
(main module does not need module github.com/kopia/kopia)

Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:

[ ] Accepted the DCO. Commits without the DCO will delay acceptance.
[ ] Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
[ ] Updated the corresponding documentation in site/content/docs/main.

replaces https://github.com/openshift/velero/pull/277
cherry-picks https://github.com/vmware-tanzu/velero/pull/6484

/hold for 1.2.2

/hold

/retest

/hold cancel
1.2.2 dev is on!


LevenshteinMatcher calculates distance not relevance

Hi, it seems that the levenshtein method in LevenshteinMatcher calculates distance not relevance.
For example, given two strings, the score returned by levenshtein is zero when they are the same.

You're very right. It was only experimental and never really supported though, so It's highly unlikely this will be changed.


WIP: rpc: add input confirmations to getrawtransaction

Reopened to apply to 0.12.1-bitcore branch at https://github.com/bitpay/bitcoin/pull/20


vscode logo rarely visible with dark color themes

VSCode Version: 1.6.0
OS Version: Windows 10

Light theme:

Dark theme:

What about using an SVG instead of an image for the logo and just use the default text color (with an little transparency) for the fill color of the SVG logo? Then it would be visible in all themes.

Closing "as designed". We also changed the logo in the meantime.


Persistent hyperdb in browser

I've been trying to get a persistent hyperdb to work in my browser for the past 2 days.
The problem is that hyperdb expects random-access-storage based storage as its backend, and the only existing implementation that works in the browser is random-access-memory, which is volatile. This would mean that everytime my browser tab is reloaded it will lose its content and when it connects to peers it will need to be reauthorized.
I've tried frankensteining together level-browserify and random-access-memory, but this is very error prone. Is there a backend for hyperdb that supports persistent browser storage? or maybe another way of preserving the key and replaying changes without breaking the database?

Did you ever get this to work, @peacememories ?

I can’t quite remember (I never did finish that project) but I think I had success with random-access-idb

@eklem you can try random-access-web as well: https://github.com/random-access-storage/random-access-web

Thanks @joehand!


test test_ivfflat_wide_matrix failed in CI

A test test_ivfflat_wide_matrix added by https://github.com/NVIDIA/spark-rapids-ml/pull/691 failed in CI:

[2024-07-25T05:29:20.685Z] =========================== short test summary info ============================

[2024-07-25T05:29:20.685Z] FAILED tests/test_approximate_nearest_neighbors.py::test_ivfflat_wide_matrix[float32-(4000, 3000)-combo0] - assert 0.05323904405853512 == 0.053238988191376575 ± 5.3e-08

[2024-07-25T05:29:20.685Z]

[2024-07-25T05:29:20.685Z]   comparison failed

[2024-07-25T05:29:20.685Z]   Obtained: 0.05323904405853512

[2024-07-25T05:29:20.685Z]   Expected: 0.053238988191376575 ± 5.3e-08

[2024-07-25T05:29:20.685Z] FAILED tests/test_approximate_nearest_neighbors.py::test_ivfflat_wide_matrix[float32-(4000, 3000)-combo1] - assert 0.2333125547209036 == 0.23331224220430977 ± 2.3e-07

[2024-07-25T05:29:20.685Z]

[2024-07-25T05:29:20.685Z]   comparison failed

[2024-07-25T05:29:20.685Z]   Obtained: 0.2333125547209036

[2024-07-25T05:29:20.685Z]   Expected: 0.23331224220430977 ± 2.3e-07

[2024-07-25T05:29:20.686Z] FAILED tests/test_approximate_nearest_neighbors.py::test_ivfflat_wide_matrix[float32-(4000, 3000)-combo2] - assert 0.9490436035531464 == 0.9490454080897135 ± 9.5e-07

[2024-07-25T05:29:20.686Z]

[2024-07-25T05:29:20.686Z]   comparison failed

[2024-07-25T05:29:20.686Z]   Obtained: 0.9490436035531464

[2024-07-25T05:29:20.686Z]   Expected: 0.9490454080897135 ± 9.5e-07

[2024-07-25T05:29:20.686Z] ========== 3 failed, 732 passed, 9616 warnings in 8707.87s (2:25:07) ===========

Fixed by https://github.com/NVIDIA/spark-rapids-ml/pull/698


Added tests

Codecov Report

Merging #17 into master will increase coverage by 2.51%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #17      +/-   ##
============================================
+ Coverage     90.46%   92.97%   +2.51%
============================================
  Files            27       17      -10
  Lines           304      185     -119
  Branches         21       16       -5
============================================
- Hits            275      172     -103
+ Misses           18        8      -10
+ Partials         11        5       -6

Impacted Files
Coverage Δ
Complexity Δ

...com/inna/shpota/company/entity/EmployeeChange.java

...c/main/java/com/inna/shpota/company/WebConfig.java

...om/inna/shpota/company/service/ProjectService.java

.../shpota/company/controller/EmployeeController.java

...na/shpota/company/CompanyStructureApplication.java

.../java/com/inna/shpota/company/entity/Employee.java

...a/shpota/company/controller/ProjectController.java

...n/java/com/inna/shpota/company/entity/Project.java

...m/inna/shpota/company/service/EmployeeService.java

...va/com/inna/shpota/company/entity/ProjectName.java

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae0c46b...03ff0c5. Read the comment docs.


Improve "Pull Request" page by explaining the usage of GitHub Actions and TravisCI

I am unable to build the site though:
$ hugo version
Hugo Static Site Generator v0.80.0/extended linux/amd64 BuildDate: 2021-02-09T18:47:48Z (ubuntu 0.80.0-6)
$ hugo
Total in 1 ms
Error: add site dependencies: create deps: 1 error(s) decoding:

* 'Goldmark.Parser.Attribute' expected type 'bool', got unconvertible type 'map[string]interface {}'

The problem with the build was that Ubuntu's version is too old (0.80.0).
I've installed manually 0.95.0 and everything is OK!

sorry for the late, thank you @martin-g ! merged

Thank you, @ulysses-you !


[multistage][test] add multi-server, multi-segment test

Codecov Report

Merging #9943 (7c3d43f) into master (2253bd7) will decrease coverage by 33.14%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #9943       +/-   ##
=============================================
- Coverage     70.38%   37.24%   -33.15%
+ Complexity     5070      200     -4870
=============================================
  Files          1987     1987
  Lines        106767   106767
  Branches      16205    16205
=============================================
- Hits          75152    39766    -35386
- Misses        26363    63684    +37321
+ Partials       5252     3317     -1935

Flag
Coverage Δ

integration1
25.14% <ø> (-0.11%)
:arrow_down:

integration2
24.47% <ø> (-0.03%)
:arrow_down:

unittests1
?

unittests2
15.83% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...in/java/org/apache/pinot/spi/utils/BytesUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/spi/trace/BaseRecording.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/spi/trace/NoOpRecording.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ava/org/apache/pinot/spi/config/table/FSTType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ava/org/apache/pinot/spi/config/user/RoleType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ava/org/apache/pinot/spi/data/MetricFieldSpec.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ava/org/apache/pinot/spi/stream/StreamMessage.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/common/tier/TierFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...a/org/apache/pinot/spi/config/table/TableType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../org/apache/pinot/spi/data/DimensionFieldSpec.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 1033 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add support for adding handlers at arbitrary pipeline locations

Motivation:
Currently we only supporting adding channel handlers at the front
or the end of the pipeline. This is potentially a bit frustrating:
it becomes impossible to insert handlers relative to a specific
point in the pipeline, which limits users ability to code generic
pipeline modification operations.
Modifications:
Added two new methods to ChannelPipeline, specifically
add(handler:before:) and add(handler:after:). Also performed a
substantial internal refactoring of the ChannelPipeline handler
adding code to ensure that all operations go through the same
logical path, redefining add(handler:first:) in terms of adding
either before tail or after head.
Result:
Users will be able to insert channel handlers at any point in a
ChannelPipeline, so long as they are able to point at a handler
already in that pipeline.

Ok, feedback addressed.

Thanks @Lukasa


Add a setting to reveal a opened file in any window if opening from outside VS Code

VSCode Version: 1.5.1
OS Version: OSX 10.11.6

Sorry for the strange title description there. I'm pretty crap at that :)
Not sure if this is a VSCode plugin issue or with Code itself...
In Split-View, if I have an error in the file in, say, the left view, and the last view I was in was the right one, when I click on the error in the Unity console, the same file will open up in a new tab in the right view, rather than selecting the same opened tab.
Steps to Reproduce:

Use Code in Split View.
Open a file (C# Monobehaviour) in the left view (file1.cs), and another in the second view (file2.cs).
Create an error in file1.cs, and save. Then switch to file2.cs in the right view.
Jump into Unity, and click on the error message in the console.

You'll now see file1.cs open another tab in the right view. Not sure if this is by design, but it would be good to have the option of just selecting the already opened tab.
To illustrate what I mean...

@tnaseem Is this a regression? i.e. Was this the same in 1.4.0 or happens only in 1.5.1?
What extensions do you have installed?

Ah Sorry, I should have said. It's always been there.
List of installed extensions...

This might be caused by the Debugger for Unity extension. I am not familiar with the extension. Can you share a screenshot of the console from where you click on the error message?
Is this console the same as the Debug console or a separate one?

@tnaseem it is our design principle that we open editors in the group that is currently focussed, though we have a few places where we actually favour an already opened editor.
Where are you clicking to open the error? Is it an output channel? The debug console? Or the problems view?

It happens with and without the Unity Debugger extension (Just tried it now), and happens when I double click the error in the Unity console window.
Actually, the Unity console window is just a red herring. I just tried opening the same file from Finder (with another view in focus) and rather than just going to the existing tab in the other view, it opens another tab in the currently selected view.
Compare this with SublimeText which always works as expected (focusing on the existing tab), which is just seems more intuitive.
So, if this is by design, it'd be great to have this as an option to just reuse the same tab.
I actually thought this setting would solve my problems:
	// When enabled, will open files in a new window instead of reusing an existing instance.
	"window.openInNewWindow": false,

But alas, no :)

@tnaseem to rephrase this is about opening files from outside VS Code into VS Code and you would like to have an option that if any opened VS Code window has the file open in an tab you want this window to become active and that tab to be revealed? Yes?

Yes. Exactly.
I originally thought it was a problem between Unity and VS Code, but since I've been playing around with it now, I realise I could have rephrased my question better in the original post :)

This feature request will not be considered in the next 6-12 months roadmap and as such will be closed to keep the number of issues we have to maintain actionable. Thanks for understanding and happy coding!


test

test

works

@TechStudent11 Thanks for making the issue, I tried to same on my alt, but as I said my account is flagged so it didn't work.. So ig only requirement for it to work, is not to have a account flagged, which more than half of the users don't have...

@TechStudent10 you got the achievement coz of this issue lol


chore: configurable skew

Fixes: #506
Added log_level to supress the error message (message is supressed as default) and an enable flag for the feature as a whole.
Also fixed version check to apply also for when client is a lower version than the server

:tada: This PR is included in version 1.4.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


BugFix Add http prefix when it's not set in hosts properties.

Proposed changes
Issue Number: close #17722
Problem summary
Add http prefix when it's not set in hosts properties.


Adds autoReplyBroadcast and askChangeTopicBroadcast types [pr]

What's this PR do?
A first stab at splitting out our broadcast Contentful content type into separate content types taking on 2 of them. We'll pass these Contentful ID to a POST /messages?origin=broadcast request as the broadcastId -- but Conversations will also save the ID as the conversation topic.  These content types contain a broadcast field that references  message entries, which we use to send a broadcast message -- but also contain additional fields to return as templates for when the user's topic is set to one of these broadcast types.
autoReplyBroadcast
Deprecates use of the survey_response topic broadcasts we currently send.
Fields:

name - text field
broadcast -the outbound message to send, limited to message entries
autoReply - auto reply message to send, also limited to message entries

askChangeTopicBroadcast
Deprecates use of the askSignup campaign broadcasts we currently send.
Fields:

name
topic - This is the topic we'll change the conversation to if the user says yes to the broadcast
broadcast - This is the outbound message that will be sent to user, asking them if they'd like to change current topic to this one. If topic is associated with a campaign, this will create a signup
declinedChangeTopic - Sent if user says no while in this broadcast topic
invalidChangeTopicResponse - Sent if user replies with neither yes or no while in this broadcast topic
autoReply - Auto reply sent after user has declined, and is now stuck in this topic (until they send a keyword or command to break out)

API changes
These types are available via the GET /broadcasts resource. A GET /broadcasts response has 2 new properties added:

type - Corresponds to the broadcast content type. Can be either broadcast or now autoReplyBroadcast

templates - object property.  Legacy broadcasts will have an empty object, but if the type is autoReplyBroadcast, the templates contain a single autoReply property.

This content type is a bit of a hybrid of both broadcast and topic, as it contains the outbound broadcast, but also contains replies for after the broadcast -- which is why it's being exposed as  aGET /topics/:id, and to get things working in Gambit Conversations by making the following changes:

If the broadcastId sent to a POST /messages?origin=broadcast request is an autoReplyBroadcast, send the broadcast message and set the conversation.topic to the broadcastId sent.

If a POST /messages?origin=member message is received for a user with an autoReplyBroadcast topic - send them the autoReply template.

As a sanity check while developing this, I thought a GET /contentfulEntries/:id endpoint would be useful - as it eliminates the guesswork of knowing which resource we're mapping a given ID to (and for an autoReplyBroadcast, it can show up as both ( which could be confusing 😕 ❓ I've taken a stab at updating the topics documentation accordingly).
How should this be reviewed?
I've created a sample autoPostBroadcast - 4nwTwvXmfuuYAGYgusGyyW, and will be opening up a Conversations PR to test against it.

Verify that the GET /broadcasts response looks as expected for existing broadcasts, but also contains a templates object when type is set to `autoReplyBroadcast

Verify the GET /contentfulEntries/:id works as expected

Any background context you want to provide?
It'd likely make sense to return these new content types in the GET /topics index response as well -- but it felt like more changes than necessary at the moment, and possibly confusing. Once we start adding many broadcast entries - our cached list of topics we use for sake of finding topics by campaign quickly would turn ugly. That code in generally is ugly and should be refactored to make separate Contentful calls to filter by campaign (either by adding custom query parameters, passing query params directly to Contentful, or potentially thinking GraphQL to DRY systems)
Relevant tickets
https://www.pivotaltracker.com/n/projects/2092729
Checklist

[x] Documentation added for new features/changed endpoints.
[x] Tested on staging.

I've pushed up a commit that adds an additional  askChangeTopicBroadcast type of broadcast, and updated the PR description accordingly. This broadcast type hasn't been implemented in Conversations at all, so should not affect testing on https://github.com/DoSomething/gambit-conversations/pull/373. Going to push this branch to staging to test.


[BUG] Could not load Jobs - spigot 1.18.1

*Detailed description of the issue:
Could not load Jobs after installing latest spigot server version.
####################
PASTE ERROR HERE
####################
 - https://pastebin.com/tXZQeq9A

**Jobs version: <IP_ADDRESS>**

**Server Type (Spigot): 3375-Spigot-8965a50-319ca70 (MC: 1.18.1) (Implementing API version 1.18.1-R0.1-SNAPSHOT)**
**These releases work around a security issue in log4j2, the logging library used by Minecraft.**

**Server Version (using `/ver`):**

**Relevant plugins:
 - CMILib
 - other**

https://pastebin.com/PC3Bu3kf

Unfortunately i have encountered the same issue. I just found out that deleting the exampleconfig works as workaround. Would you like to upload your example config file as I deleted mine. It might help to figure out if the issue is in the data being written by the plugin or the way CMIlib handles the file.
https://pastebin.com/PzYQb8zG

Fixed with latest CMILib update


Multi week support

Added capability to dynamically display multiple weeks while FSCalendarScopeWeek is selected.
Updated ‘calendar scope example’ to demonstrate this capability.

Hi @badrinarayanv , I would like to take a deeper look at this PR, but can you submit this into the develop branch?


Etcd Load Generator

Generates load for etcd standalone instance.

Generates load for etcd standalone instance.

Hi, I have written this etcd load generator in golang.
@xiang90 can you please take a look

@xiang90 , I have written this etcd load generator. Can you please take a look

egy új felhasználói megpróbál a nyitjára, ?

Ping?

Thank you for sending a patch for this tool. I think it is useful to have benchmarking for etcd but there would need to be substantial changes to merge this.

The code doesn't follow Go coding practices and the entire patch needs to be ran through go fmt. I will point out a couple of places the code can be improved but I don't have time do a full review. I would suggest that you spend some time reading the etcd code base or the Go standard library to learn a bit more about Go coding style as a next step.

etcd performance characteristics are quite different on multi-machine, why can't this be multi-machine?

pmap is a Linux only utility and we have people using etcd on different platforms, perhaps we should make this a separate project for etcd-linux-bench?

I hope that all makes sense and we are interested in perf tools for etcd overall; we just want to make sure code we merge is stuff we can maintain and have others hack on over time.

@hroyrh Please check out https://github.com/coreos/etcd/blob/master/hack/benchmark/bench.sh.
We already have v2 benchmarks with load generator.

I am closing this due to low activity.


MAS allows only read-only access to files

We submitted our app using SFBAudioEngine to the app store and got rejected because we were opening the files with read/write access instead of read-only. I poked around a bit and saw that you sent this pull request to the TagLib repo:
https://github.com/taglib/taglib/pull/3
Are these changes included in the taglib.framework included in the Frameworks.zip file? And do the other frameworks used for reading metadata (e.g. mp4v2) open files as read/write or read-only? I think its strictly the metadata reading that's opening files as read/write. I thought it might've been audio playback as well, but I saw that FileInputSource already opens files as read-only so I don't think that could be it.

As you probably noticed that TagLib pull request is from 9 months ago, so if you are using any commit of SFBAudioEngine after https://github.com/sbooth/SFBAudioEngine/commit/5ab9aeeedfa5ffe950bdb4e25b3d9949b23eac93 along with the updated Frameworks.zip then all files will be opened readonly, for metadata reading and playback.

Thanks for the info. Apple still insists that I was writing to files inside the iTunes Music folder so I decided to run the initial import (where all the metadata is imported) with fs_usage running. I found something pretty peculiar. It seems that out of ~500 audio files, 5 or 6 were opened with write access for reading the metadata:
20:55:27  open              unes/iTunes Media/Music/Linkin Park/Minutes To Midnight/Shadow Of The Day.mp3    0.000039 W Sonora

Any idea why this might be?

Alright, I'm reading the output correctly now and fs_usage shows that all of the files that are being opened for metadata reading are being opened with rw access:
...
21:09:52.986655  open              F=9        (RW____)  /Users/Indragie/Music/iTunes/iTunes Media/Music/Skillet/Awake/04 Awake And Alive.mp3
21:09:53.151253  open              F=10       (RW____)  /Users/Indragie/Music/iTunes/iTunes Media/Music/Skillet/Awake/01 Hero.mp3
21:09:53.569870  open              F=10       (RW____)  /Users/Indragie/Music/iTunes/iTunes Media/Music/Halestorm/Halestorm/04 Innocence.mp3
...

This output is strictly from the initial import and the only time those files are accessed during the import are to read their metadata.

Found the issue. Sorry for the inconvenience. I was creating security scoped bookmarks for each of those files and forgot to specify the "NSURLBookmarkCreationSecurityScopeAllowOnlyReadAccess" option when creating them.


Error "The keyword 'await' is reserved" is ambiguous

As a newbie to async/await syntax I made a rookie mistake and forgot to mark the first function I wrote as async, whilst still trying to use await inside it. The error "The keyword 'await' is reserved" doesn't indicate what the problem is and, to me, suggested the parser was configured to use the wrong ES version. An error like "Can not use keyword 'await' outside async functions" or similar would be clearer.

Want to submit a pull request?

@marijnh Submitted a PR above :)


Added cgid capture to stirling with minimal testing

Summary: Added Capturing of Cgroup ids to the ebpf probes in the socket tracer. This includes modifications to data structures for communicating that information to userspace and other data tables. It also includes some minimal testing for ensuring that cgroup ids are captured correctly. The reason for this change is given in the design document for the solution to this issue: in short it is the first step in using cgids rather than pids to associate a particular piece of communication data with the correct pod.
Test Plan: Added Cgroup id capture checks to existing socket_tracer tests.
Kind: Feature expansion
Signed-off-as: AdityaAtulTewari<EMAIL_ADDRESS>

@pixie-io/maintainers in the meantime would we be able to let the CI jobs run? @AdityaAtulTewari is interested in seeing if there are any failures to address.

We had previously discussed writing a trace bpf test that would exhibit this short lived process behavior. I think it's important to develop that before we make the change to store the cgroup ids (this PR). Essentially my thoughts are that we would take your containerized application from this branch, create a new trace bpf test with it and then follow it up with this change to verify it results in the records we expect.

This change does not fix the race condition, it just exposes the cgroup id so that a future pr can. The changes are broken up this way as it allows me to break apart the solution to this problem into easier to design pieces. I'm happy to add that test to the change in progress that fixes the issue. However I don't think it is appropriate here because it will still fail.

cc @etep since I believe you are interested in reviewing this as well.


File creation/deletion triggers rebuild even if the file is ignored

At least on the Windows 10 machine I'm currently working on, the creation and deletion of vim swap files causes rebuilds, even though the files are ignored. It seems that the change on the directory (which is not ignored) is responsible for this:
*** Ignoring "\\\\?\\C:\\Users\\bstei\\src\\klm\\src\\.responses.rs.swp": matched ignore filter
*** Ignoring "\\\\?\\C:\\Users\\bstei\\src\\klm\\src\\.responses.rs.swp": matched ignore filter
*** Paths updated: [PathOp { path: "\\\\?\\C:\\Users\\bstei\\src\\klm\\src", op: Some(WRITE), cookie: None }]
[Running 'cargo run']

I don't recall seeing this on Linux, but I don't have access to a machine to test this on right now.

Hmm. I'm wondering for a good way of how that could be fixed, without (or with minimum) side effects:

Ignoring writes for folders, may mean that adding a folder doesn't trigger.
Ignoring writes for folders if no non-ignored file changes were seen previously in it... still has some edge cases, but is much harder to implement (need to keep complex state while watching).

Ignoring writes for folders, may mean that adding a folder doesn't trigger.

Looking at a debug trace, at least on Windows it seems that there's a dedicated type for creation/removal of a directory.
I'm seeing
*** Paths updated: [PathOp { path: "\\\\?\\C:\\Users\\bstei\\src\\klm\\bla", op: Some(CREATE), cookie: None }]

and
*** Paths updated: [PathOp { path: "\\\\?\\C:\\Users\\bstei\\src\\klm\\bla", op: Some(REMOVE), cookie: None }]

while the problematic event had a Some(WRITE) value for op. In which casses is a write event on a directory actually interesting?

Good point.

I'm running a build.rs script that compresses folders in the project folder and writes the output folders to the .ignore file to prevent cargo watch from restarting when these files/folders get written. I have had a lot of issues with getting the .ignore to work properly, but it seems that I can get it working if I cargo run at least one time before running cargo watch to create the .ignore file. This isn't ideal; I'm wondering if it is possible to make cargo watch reload the .ignore file when the process restarts?

It's possible, but do you mind opening a separate feature request (on watchexec) so that gets tracked separately?

Sure thing. I didn't know if I should start a new issue since this is essentially the same problem.

I'm also getting this for sqlite .db-journal files, which are created and quickly destroyed. Their creation modifies the directory that they're in (which is not excluded from the watch), causing rebuilds on every write operation.
((Thanks for the tool, it's been very nice.))

A workaround is to put them in a folder (eg localdbs/dev.db) and ignore the localdbs folder.

Closing in favour of upstream issue: https://github.com/watchexec/watchexec/issues/183.


Adding doc on how to set Azure CNI versions

These were added in ACS-Engine 0.25 but not documented.
@jackfrancis can you review since you touched the URLs last in #4097?

/assign @jackfrancis

/assign jackfrancis
Does this look ok now?

/lgtm