"grunt test" isn't working

Hi guys,
I'm trying to develop some new features on SIP.js using TDD, but I'm failing to run the unit tests.
When I run:
$ grunt test --verbose

This is what I get:
Initializing
Command-line options: --verbose

Reading "Gruntfile.js" Gruntfile...OK

Registering Gruntfile tasks.
Reading package.json...OK
Parsing package.json...OK
Initializing config...OK

Registering "grunt-browserify" local Npm module tasks.
Reading /home/bagostini/research/SIP.js/node_modules/grunt-browserify/package.json...OK
Parsing /home/bagostini/research/SIP.js/node_modules/grunt-browserify/package.json...OK
Loading "browserify.js" tasks...OK
+ browserify

Registering "grunt-contrib-copy" local Npm module tasks.
Reading /home/bagostini/research/SIP.js/node_modules/grunt-contrib-copy/package.json...OK
Parsing /home/bagostini/research/SIP.js/node_modules/grunt-contrib-copy/package.json...OK
Loading "copy.js" tasks...OK
+ copy

Registering "grunt-contrib-uglify" local Npm module tasks.
Reading /home/bagostini/research/SIP.js/node_modules/grunt-contrib-uglify/package.json...OK
Parsing /home/bagostini/research/SIP.js/node_modules/grunt-contrib-uglify/package.json...OK
Loading "uglify.js" tasks...OK
+ uglify

Registering "grunt-contrib-jshint" local Npm module tasks.
Reading /home/bagostini/research/SIP.js/node_modules/grunt-contrib-jshint/package.json...OK
Parsing /home/bagostini/research/SIP.js/node_modules/grunt-contrib-jshint/package.json...OK
Loading "jshint.js" tasks...OK
+ jshint

Registering "grunt-contrib-jasmine" local Npm module tasks.
Reading /home/bagostini/research/SIP.js/node_modules/grunt-contrib-jasmine/package.json...OK
Parsing /home/bagostini/research/SIP.js/node_modules/grunt-contrib-jasmine/package.json...OK
Loading "jasmine.js" tasks...OK
+ jasmine

Registering "grunt-peg" local Npm module tasks.
Reading /home/bagostini/research/SIP.js/node_modules/grunt-peg/package.json...OK
Parsing /home/bagostini/research/SIP.js/node_modules/grunt-peg/package.json...OK
Loading "peg.js" tasks...OK
+ peg

Registering "grunt-trimtrailingspaces" local Npm module tasks.

Any ideas of what I'm doing wrong? :/
Additional Details

I followed the description from file BUILDING.md.

Installed jasmine, grunt, phantomjs globally, and all the another dependencies using $ npm install.

Node version is v4.2.6.

Npm version is 3.5.2.

I'm using Ubuntu 16.04 LTS.

$ grunt devel works, but doesn't generate the file sip-devel.js, as specified by the doc.

I've create the file sip-devel.js copying it from sip-0.7.5.js, as required by the doc. No success.

I have also tried to run the tests manually using $ jasmine, but got no success as well.

Hi Bruno,
Can you try running open _SpecRunner.html? I am not able to recreate your issue, but the problem seems to be with phantom.
James

Hi James!
Thanks for the attention. =]
I ran google-chrome _SpecRunner.html and got this (logged in the browser):
http://pastebin.com/Q8UNavf3
Additional Details
The first time I installed phantomjs, I had used the command $ sudo apt-get install -y phantomjs.
This was the result:
[14:25:21] bagostini@bagostini-OptiPlex-7010:~/research/SIP.js $ grunt test
Running "jasmine:components" (jasmine) task
Testing jasmine specs via PhantomJS

Fatal error: spawn /usr/local/lib/node_modules/phantomjs/lib/phantom/bin/phantomjs ENOENT

After that, I downloaded the tar properly copying the binary to that location. In this scenario, tests got stuck.
I also tried to install it using $ sudo npm install -g phantomjs. Tests got stuck as well.
I've also tested it on a Debian GNU/Linux 8.5 (jessie), just in case, and got the same results.


onPress not working for children

I have the following code:
<SelectableText selectable={true} menuItems={["Add to note", "Comment"]} onSelection={(props) => {                 console.log(props)                 alert(props.eventType + ": " + props.content)               }}               style={{margin: 20}}               appendToChildren={                 <Text>                   Hello <Text onPress={() => alert('Hello World')} style={{fontWeight: 'bold'}}>World</Text>                 </Text>               }             />

and it outputs the text correctly, however, the onPress of Text component (on word: "World") does not work. If I were to have same "Hello World" Text Component outside of SelectableTextComponent, the onPress works fine.

the same issue, maybe edit RNSelectableText flies can be solved

I'm trying to do something similar. I think it's related to SelectableText essentially being a TextInput under the hood.  The same thing happens if you simply do:
<TextInput>
  <Text onPress={() => console.log('hello')}>Some text</Text>
</TextInput>

I can't even get it to work with a trivial example like that. Would be happy if anyone had thoughts!

This appears to be a duplicate of https://github.com/Astrocoders/react-native-selectable-text/issues/47
In that issue, they point out the issue is only affecting iOS. I was able to confirm that I'm only seeing the issue on iOS, not Android.
@georgelima I vote we close this issue to keep the discussion in #47

This appears to be a duplicate of https://github.com/Astrocoders/react-native-selectable-text/issues/47
In that issue, they point out the issue is only affecting iOS. I was able to confirm that I'm only seeing the issue on iOS, not Android.
@georgelima I vote we close this issue to keep the discussion in #47


claming pixel

Checklist

[ ] I ran npm test locally and it passed without errors.

[x] I only edited the _data/pixels.json file.

[x] I entered the username in the pixels.json that I'm also using to create this pull request.
[x] I acknowledge that all my contributions will be made under the project's license.

so I've tried to run the project but did not work, got this message:'eleventy' não é reconhecido como um comando interno
ou externo, um programa operável ou um arquivo em lotes.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: eleventy --serve
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
I gonna upload the debug log


No Output Directory named "public" found after the Build completed.

First thanks for your time!
this project is very interesting...
I am getting the following error when trying to deploy
S:O Ubuntu 18.04
node version  12.18.03
steps
git clone <this repo>
 npm install  instead of npm install --save @saeris/apollo-server-vercel graphql <- not working for me
npm start
No Output Directory named "public" found after the Build completed.
maybe this error is caused by a error configuration in the vercel.json file...
thanks

Hey I think you're mixing up (this repo) and doing npm install or yarn add is the same thing.
Just copy the example from the docs on a fresh npm init. / create-next-app and do yarn add /or npm install --save @saeris/apollo-server-vercel graphql

I can see how the docs for this repo may be confusing (there isn't very clear separation between usage and how to contribute). Next week I'll give them an update so it's more clear how you would use this library for new + existing apps. I didn't add them up front since quite honestly I'm new to Next/Vercel myself.
As @agustif suggested, you can create a new Next app and add an API route as described in their documentation or you can deploy serverless functions to Vercel without using Next by following this guide. Once you have a new/existing project, that's when you would add this as a dependency and start building out your graphql server.
You would only clone this repo if you wanted to contribute to development of this library.

Added to the documentation. Hopefully it'll make it clearer how to get started!


upgrade pip before installing ansible

When building on a new machine (no cached docker images), building the ansibleRunner failed with the error:
> Task :tools:ansibleRunner:distDocker
Wed Sep 26 17:00:49 EDT 2018: Executing 'docker build -t ansible-runner /Users/dgrove/code/openwhisk/openwhisk/tools/ansibleRunner'

Collecting jinja2 (from ansible==2.5.2)
  Downloading https://files.pythonhosted.org/packages/7f/ff/ae64bacdfc95f27a016a7bed8e8686763ba4d277a78ca76f32659220a731/Jinja2-2.10-py2.py3-none-any.whl (126kB)
Collecting PyYAML (from ansible==2.5.2)
  Downloading https://files.pythonhosted.org/packages/9e/a3/1d13970c3f36777c583f136c136f804d70f500168edc1edea6daa7200769/PyYAML-3.13.tar.gz (270kB)
Collecting paramiko (from ansible==2.5.2)
  Downloading https://files.pythonhosted.org/packages/cf/ae/94e70d49044ccc234bfdba20114fa947d7ba6eb68a2e452d89b920e62227/paramiko-2.4.2-py2.py3-none-any.whl (193kB)
Collecting cryptography (from ansible==2.5.2)
  Downloading https://files.pythonhosted.org/packages/22/21/233e38f74188db94e8451ef6385754a98f3cad9b59bedf3a8e8b14988be4/cryptography-2.3.1.tar.gz (449kB)
Requirement already satisfied: setuptools in /usr/lib/python2.7/site-packages (from ansible==2.5.2) (40.4.3)
Collecting MarkupSafe>=0.23 (from jinja2->ansible==2.5.2)
  Downloading https://files.pythonhosted.org/packages/4d/de/32d741db316d8fdb7680822dd37001ef7a448255de9699ab4bfcbdf4172b/MarkupSafe-1.0.tar.gz
Collecting pyasn1>=0.1.7 (from paramiko->ansible==2.5.2)
  Downloading https://files.pythonhosted.org/packages/d1/a1/7790cc85db38daa874f6a2e6308131b9953feb1367f2ae2d1123bb93a9f5/pyasn1-0.4.4-py2.py3-none-any.whl (72kB)
Collecting bcrypt>=3.1.3 (from paramiko->ansible==2.5.2)
  Downloading https://files.pythonhosted.org/packages/f3/ec/bb6b384b5134fd881b91b6aa3a88ccddaad0103857760711a5ab8c799358/bcrypt-3.1.4.tar.gz (42kB)
Collecting pynacl>=1.0.1 (from paramiko->ansible==2.5.2)
  Downloading https://files.pythonhosted.org/packages/61/ab/2ac6dea8489fa713e2b4c6c5b549cc962dd4a842b5998d9e80cf8440b7cd/PyNaCl-1.3.0.tar.gz (3.4MB)
  Could not find a version that satisfies the requirement cffi>=1.4.1 (from versions: )
No matching distribution found for cffi>=1.4.1
You are using pip version 10.0.1, however version 18.0 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
The command '/bin/sh -c pip install ansible==2.5.2' returned a non-zero code: 1

As suggested, adding pip install --upgrade pip allowed the docker build to complete successfully.

I'm having this problem with my new machine.
LGTM  👍


mwc-checkbox: normalise tests

This is just normalising the tests and adding a few assertions to match with what i did last time i reworked all the tests (added a "factory" kind of pattern).

FYI i ran tests on master too and got the same test failure so not too sure whats up.

Heya, James, this looks generally good; there seems to be a CI failure in one test but I'm rerunning the job. Next I'm going to run it through internal coverage tests to give it a final check.

If this tests fails again, try rebasing onto master?

Seems like the same failure. Can you please give it a quick
git checkout master && git pull && git checkout checkbox-tests && git rebase master

have rebased it now 👍  ill see if CI fails and try debug it a bit if it does. weirdly i was getting the same failure on my master branch so im hoping it just fixes itself tbh 🙈

good news! it now passes on master locally but not on my branch. so ill try debug it a bit
very weird since that test hasn't changed, the only change is that it uses a fixture now rather than createElement 🤔
i wonder if before this test passed because of timings... we are now waiting longer maybe so update has run and set the animation class. im not entirely sure

sorry this slipped through; I'll be able to take a closer look soon

No rush I'll see if I can get chance to debug it too 👍 thanks for taking time to look

Dan wrote this test and I think it just may have bugs. I think it's trying to do the following:
test('does not animate after being hidden', async () => {
      element.checked = true;
+     const animatedElement = element.shadowRoot!.querySelector('.mdc-checkbox__background')!;
+     await new Promise((resolve) => {
+       animatedElement.addEventListener('animationend', resolve);
+     });
+     await element.updateComplete;
      element.style.display = 'hidden';
      await rafPromise();
      element.style.display = '';
      await rafPromise();
      assert.equal(internals.animationClass, '');
    });

Write that into the test (but formatted) and that should fix the issue. I'll bring it up with him when Dan is back from vacation next week.

i made the change and the tests pass for me now... but i have no idea still what that test is trying to test 😂

I vaguely remember internally we were having an issue where on page load or when going from hidden to not hidden, the initial "check" animation would play every time. I think this was what it was testing in particular because it was added with the @transitionend callback

FF failure. Rerunning to se if flake


SQS retry delay

Type: Issue
Component:
SQS
Describe the bug
I'm trying to implement a SQS listener that is processing a message with 4 retries if the message fails 5 times it gets moved to a DLQ. It's easy to set up and I got the whole flow working.
However if there is an issue processing the message I want to delay the retry (and only the retry - not the original message) for a couple of minutes.
I tried quite a few of things:

wrote code to catch the error and creating a new message with a delay - that works, but I lose the ability to automatically move it to the DLQ because a new message resets the delivery counter.
created a retry queue with a delay on the queue - I created 2 listeners and have the retry queue set up as the DLQ for the original queue with a count of 1, so if the message fails it gets moved over to the retry queue, but the delay is not working, it processes the message right away/
created a retry queue with a delay on the queue - and programmatically send the message from the first queue to the retry queue - that worked for the 1st message, but all the retries are ignoring the delay set up on the queue

I'm out of ideas what to do ... I can't put my finger on where the problem is. Is this a spring-cloud-aws issue on how it deals with retries? Is that an AWS SQS issue?
I don't think this is an unreasonable scenario, I want to delay the retries of the processing of a message, because I might have some environment issues that might be resolved if I wait a few minutes. There has to be an easy way to do this without re-implementing the retry and DLQ functionality.
Any ideas on how to solve or debug this?

Hey @schlumpfling42, thanks for bringing this up.
The usual strategy to achieve this behavior is to set a visibilityTimeout to e.g. 5 minutes.
This way if message processing fails the message will remain invisible for the remaining time after the error, and will be processed again after that.
With this you can use all SQS goodies such as redriving the message to a DLQ after retries are exhausted.
How does that sound?

@tomazfernandes I have the visibility time set to 3 minutes, so that has no impact on when the messages are picked up with or without an error. As far as I understand this only has an impact if the consumer doesn't respond.

@tomazfernandes I tested this out with a lambda and the lambda does honor the visibility timeout, most likely because it does not communicate with the queue on error. So that would work for me. How do I prevent the message being put back onto the queue/released when there is an Error? Can I actively take control of that?

@tomazfernandes Ahhh darn it ... I just found the problem. So it is working as designed and the visibility timeout is the way to go. One has just to be sure to not overwrite that timeout in the code. I found that I have set a different timeout in my configuration when setting up the SimpleMessageListenerContainerFactory and that overrides whatever is set in the queue!


Remove hidden and off-canvas paths from SVG

Many icons has off-canvas and hidden paths. Those shapes are parts of unused drafts that often double or triple icon size.
This PR fixes those icons. Resulting icons are visually identical to original icons, but without hidden and off-canvas paths.
See https://github.com/googlei18n/noto-emoji/issues/142

@cyberalien Thank you! Could you perhaps share your process so we can integrate it in the build process? I take it you pulled them through something like svgo?

Thanks for the PR. These SVG files are generated from internal source artwork files, so we have backported these fixes there. We'll re-export as SVG and updated the repo soon!


Feature request: save images as PNG or TIF files

This would be helpful in enabling text to be extracted from the images.  Thanks.

PySceneDetect v0.5-beta allows support for saving images as PNG files via the save-images --png/-p command, e.g.:
scenedetect --input some_video.mp4 detect-content save-images --png --compression 9

You can grab a copy of v0.5-beta from the Releases page if you would like to try the new version or provide some feedback.  The official release of PySceneDetect v0.5 should be out sometime later this month.
Thank you for your submission, and for helping make PySceneDetect even better 👍

Hi Brandon
Many thanks for including saving PNG files in the new release.
The only problem with the new release v5 beta 1 is that  I get ‘frame_skip must be 0 when using a StatsManager ‘  with -fs 5.  I’m using detect-content and –d 4.   I can’t send a log file as I get a permissions error which I can’t resolve!   I’m using the beta release on Win !0 with Python 3.6 installed.   Is there a work-around to disable the StatsManager as I don’t need to use it and thus avoid getting the error message?
Thanks
Michael
From: Brandon Castellano<EMAIL_ADDRESS>Sent: 01 August 2018 21:29
To: Breakthrough/PySceneDetect
Cc: agricolan; Author
Subject: Re: [Breakthrough/PySceneDetect] Feature request: save images as PNG or TIF files (#51)
PySceneDetect v0.5-beta allows support for saving images as PNG files via the save-images --png/-p command, e.g.:
scenedetect --input some_video.mp4 detect-content save-images --png --compression 9
You can grab a copy of v0.5-beta from the Releases page if you would like to try the new version or provide some feedback. The official release of PySceneDetect v0.5 should be out sometime later this month.
Thank you for your submission, and for helping make PySceneDetect even better 👍
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Breakthrough/PySceneDetect/issues/51#issuecomment-409711227 , or mute the thread https://github.com/notifications/unsubscribe-auth/ALGyG1utKBwdwDccBHqcfMK8K0QgoiBdks5uMg9wgaJpZM4SIds_ .Image removed by sender.

Hi @agricolan;
Sorry about that, and thank you for helping test the beta version.
You can try setting line 97 in scenedetect/cli/context.py to:
self.stats_manager = None
And see if that solves the issue (haven't tested this yet, but it should resolve the issue). I will try to push a fix for this sometime this weekend and update the beta release (will keep you posted).
Thank you for the bug report, much appreciated!

Version 0.5 has now been released!  You can grab it off of pip (Windows installer coming soon).  All issues described in this thread have been fixed; closing issue.


Language detection

Creating this PR just as a sketch. After some discussions with team mates from Zurich here are some thoughts:

It defeats the purpose to have this functionality in an extension, since nobody will discover the extension and this functionality should help new users.

Here's the things which I think we need to do in order to have this in the core:

[ ] We need to convert the model to the tensorflow-js model and not have a node dependency. We need to do this so we can run in the browser. Without this, even for VS Code desktop we would have to run the classification in the shared process, since we are moving towards node free renderers, and putting additional work in the shared process is not good.
[ ] We should look into reducing the size of the model so we do not increase the install size too much. @TylerLeonhardt I think you already started looking into this
[ ] I believe this work is best suited for a new service in VS Code, for example ILanguageDetectionService, I created a skeleton for this and I can look into this further to have it integrated on the vscode side @isidorn
[ ] Figure out how often to call the service (after n characters) and what is the confidence we should use
[ ] We need to measure time performance for loading the model and classification
[ ] We need to measure memory footprint of model loading

If we get the above working in a good way then we need to:

[ ] Look into supporting JSON, xml and other not supported languages
[ ] Try to improve corner case classification - like JS/TS confusion

If all of this proves to be too much overhead we can look into some simpler heuristic to detect a language and not use machine learning.
@TylerLeonhardt let me know what you think, and feel free to add your name to some of the items you are interested in and also feel free to add items I might have forgot.
fixes https://github.com/microsoft/vscode/issues/118455

Closing this in favor of https://github.com/microsoft/vscode/pull/128708


renovatebot(deps): update dependency gradle to v5

This PR contains the following updates:

Package
Type
Update
Change

gradle (source)
gradle-wrapper
major
2.0.0 -> 5.6.4

Release Notes

gradle/gradle
v5.6.4
Compare Source
This bug-fix release contains all changes from 5.6.1 through 5.6.3 as well as:

Can't configure kotlinOptions after upgrade to gradle 5.6.3 using kotlin-dsl #11083
Slow localhost look-up on macOS #11134

We recommend that you use Gradle 5.6.4 over any other 5.6.x release.
Upgrade Instructions
Switch your build to use Gradle 5.6.4 by updating your wrapper properties:
./gradlew wrapper --gradle-version=5.6.4
Standalone downloads are available at https://gradle.org/install.
Reporting Problems
If you find a problem with Gradle, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v5.6.3
Compare Source
This bug-fix release contains all changes from 5.6.1 and 5.6.2 as well as:

Let Kotlin DSL gracefully handle lambdas registered as extensions (5.6.3) #11014
Gradle Module Metadata compatibility for unique snapshots #11050
maven-publish publishes jars with wrong extension for known jar packagings like 'ejb' in 5.6 #10555
Regression in 5.5 when using dependency constraints for non-jar dependencies without a POM #10948
resolution failure when dependency locks and kotlin-dsl plugin are present #10697
Non-Kotlin extensions crash the build when using Kotlin DSL + Kotlin plugins #10729
Sporadic build failures with build-scan due to an overlapping ID assignment #10286
Prevent StackOverflowException caused by excessive 'or' via PatternMatcher #10330

We recommend that you use Gradle 5.6.3 over any other 5.6.x release.
Upgrade Instructions
Switch your build to use Gradle 5.6.3 by updating your wrapper properties:
./gradlew wrapper --gradle-version=5.6.3
Standalone downloads are available at https://gradle.org/install.
Reporting Problems
If you find a problem with Gradle, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v5.6.2
Compare Source
This bug-fix release contains changes to Gradle 5.6.1:

Duplicate entry in generated .classpath file in Gradle >= 5.6 (#10393)
Memory leak when using tasks that use Worker API and process isolation (#10411)

We recommend that you use Gradle 5.6.2 over 5.6.1.
Upgrade Instructions
Switch your build to use Gradle 5.6.2 by updating your wrapper properties:
./gradlew wrapper --gradle-version=5.6.2
Standalone downloads are available at https://gradle.org/install.
Reporting Problems
If you find a problem with Gradle, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v5.6.1
Compare Source
This bug-fix release contains changes to Gradle 5.6:

Unable to publish artifacts with custom classifier/extension from java project with Gradle 5.6 (#10287)
Regression in 5.6 signArchives (Duplicate key) (#10302)
Regression setting version for ArchiveTasks in 5.6 (#10311)
A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleKotlinCompilerWork (#10317)
DirectoryFileTree breaks SourceTask since 5.6 (#10322)
Regression: Unable to pass java.util.Properties object using Worker API in Gradle 5.6 (#10323)
Unable to publish multiple publications with same coordinates (#10333)
Gradle 5.6 - Resolving resources from buildSrc or plugins (#10347)

We recommend that you use Gradle 5.6.1 over 5.6.
Upgrade Instructions
Switch your build to use Gradle 5.6.1 by updating your wrapper properties:
./gradlew wrapper --gradle-version=5.6.1
Standalone downloads are available at https://gradle.org/install.
Reporting Problems
If you find a problem with Gradle, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v5.6.0
Compare Source
The Gradle team is excited to announce Gradle 5.6.
This release also contains an important security fix affecting some users.
This is the final minor release for Gradle 5.x. Read the release notes
We would like to thank the following community contributors to this release of Gradle:

Louis CAD,
Roberto Perez Alcolea,
Dan Sănduleac,
Andrew K.,
Noa Resare,
Juan Martín Sotuyo Dodero,
Semyon Levin,
wreulicke,
John Rodriguez,
mig4,
Evgeny Mandrikov,
Bjørn Mølgård Vester,
Simon Legner,
Sebastian Schuberth,
Ian Kerins,
Ivo Anjo,
Stefan M.,
Nickolay Chameev,
Dominik Giger,
Stephan Windmüller,
Zemian Deng,
Robin Verduijn,
Sandu Turcan,
Emmanuel Guérin,
Nikita Skvortsov,
and Christian Fränkel.
Upgrade Instructions
Switch your build to use Gradle 5.6 by updating your wrapper properties:
./gradlew wrapper --gradle-version=5.6
Standalone downloads are available at gradle.org/releases.
Reporting Problems
If you find a problem with Gradle, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v5.5.1
Compare Source
This bug-fix release contains three changes to Gradle 5.5:

Combination of errorprone-gradle-plugin and options.fork = true causes Java compilation to fail in Gradle 5.5 #9897
Using dependency declaration gradleKotlinDsl() fails with 5.5 #9919
Chain of transitives aligned by same platform can lead to broken resolution #9882

We recommend that you use Gradle 5.5.1 over 5.5.
Upgrade Instructions
Switch your build to use Gradle 5.5.1 by updating your wrapper properties:
./gradlew wrapper --gradle-version=5.5.1
Standalone downloads are available at https://gradle.org/install.
Reporting Problems
If you find a problem with Gradle, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v5.5.0
Compare Source
The Gradle team is excited to announce Gradle 5.5.
Read the release notes
We would like to thank the following community contributors to this release of Gradle:
Martin d'Anjou,
Ben Asher,
Mike Kobit,
Erhard Pointl,
Sebastian Schuberth,
Evgeny Mandrikov,
Stefan M.,
Igor Melnichenko,
Björn Kautler,
Roberto Perez Alcolea and
Christian Fränkel.
Upgrade Instructions
Switch your build to use Gradle 5.5 by updating your wrapper properties:
./gradlew wrapper --gradle-version=5.5
Standalone downloads are available at gradle.org/releases.
Reporting Problems
If you find a problem with Gradle, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v5.4.1
Compare Source
This bug-fix release contains two changes to Gradle 5.4:

Fix inconsistent classpath ordering when dependencies have lots of excludes - #9197
Kotlin DSL IDEA script editor can't find JDK classes with Gradle 5.4 if Gradle JVM != Project SDK - #9195

We recommend that you use Gradle 5.4.1 over 5.4.
Upgrade Instructions
Switch your build to use Gradle 5.4.1 by updating your wrapper properties:
./gradlew wrapper --gradle-version=5.4.1
Standalone downloads are available at https://gradle.org/install.
Reporting Problems
If you find a problem with Gradle, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v5.4.0
Compare Source
The Gradle team is excited to announce Gradle 5.4.
Read the release notes
We would like to thank the following community contributors to this release of Gradle:
Ian Kerins,
Roberto Perez Alcolea,
Rodolfo Forte,
gla3dr,
and Stefan M..
Upgrade Instructions
Switch your build to use Gradle 5.4 by updating your wrapper properties:
./gradlew wrapper --gradle-version=5.4
Standalone downloads are available at gradle.org/releases.
Reporting Problems
If you find a problem with Gradle, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v5.3.1
Compare Source
This bug-fix release contains several changes to Gradle 5.3, notably:

Unable to use java-platform and maven-publish in multi-project: #8845
Unexpected exception when adding a plugin on buildSrc compile classpath: gradle/kotlin-dsl#1363

We recommend that you use Gradle 5.3.1 over 5.3.
Upgrade Instructions
Switch your build to use Gradle 5.3.1 by updating your wrapper properties:
./gradlew wrapper --gradle-version=5.3.1
Standalone downloads are available at https://gradle.org/install.
Reporting Problems
If you find a problem with Gradle, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v5.3.0
Compare Source
The Gradle team is excited to announce Gradle 5.3.
This release features support for publishing and consuming Gradle Module Metadata, feature variants or "optional dependencies", type-safe accessors in Kotlin precompiled script plugins, and more.
Read the Gradle 5.x upgrade guide to learn about breaking changes and considerations for upgrading from Gradle 5.0. If upgrading from Gradle 4.x, please read upgrading from Gradle 4.x to 5.0 first.
We would like to thank the following community contributors to this release of Gradle: Stefan M., Evgeny Mandrikov, Simon Legner, Raman Gupta, Florian Dreier, Kenzie Togami, Ricardo Pereira, Thad House, Joe Kutner, and Josh Soref.
Upgrade Instructions
Switch your build to use Gradle 5.3 by updating your wrapper properties:
./gradlew wrapper --gradle-version=5.3
Standalone downloads are available at gradle.org/releases.
Reporting Problems
If you find a problem with Gradle, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v5.2.1
Compare Source
This bug-fix release contains several changes to Gradle 5.2, notably:

Checkstyle issues with a single source file: #8394
BOM support conflicts: #8420

We recommend that you use Gradle 5.2.1 over 5.2.
Upgrade Instructions
Switch your build to use Gradle 5.2.1 by updating your wrapper properties:
./gradlew wrapper --gradle-version=5.2.1
Standalone downloads are available at https://gradle.org/install.
Reporting Problems
If you find a problem with Gradle, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v5.2.0
Compare Source
The Gradle team is excited to announce Gradle 5.2.
This release features a new Java Platform plugin, improved C++ plugins, new C++ project types for gradle init, service injection into plugins and project extensions, Kotlin DSL 1.1.3 and more.
Read the Gradle 5.x upgrade guide to learn about breaking changes and considerations for upgrading from Gradle 5.0. If upgrading from Gradle 4.x, please read upgrading from Gradle 4.x to 5.0 first. Users upgrading from 5.1 should not have to worry about breaking changes.
Upgrade Instructions
Switch your build to use Gradle 5.2 by updating your wrapper properties:
./gradlew wrapper --gradle-version=5.2
Standalone downloads are available at gradle.org/releases.
Reporting Problems
If you find a problem with this release, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v5.1.1
Compare Source
This bug-fix release contains several changes to Gradle 5.1, notably:

A daemon memory leak affecting all projects #8142
Incremental Java compilation #8194
A fix to Gradle's generated Javadoc in 5.1 #8183

We recommend that you use Gradle 5.1.1 over 5.1.
Upgrade Instructions
Switch your build to use Gradle 5.1.1 by updating your wrapper properties:
./gradlew wrapper --gradle-version=5.1.1
Standalone downloads are available at https://gradle.org/install.
Reporting Problems
If you find a problem with Gradle, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v5.1.0
Compare Source
The Gradle team is excited to announce Gradle 5.1.
This release features repository to dependency matching, production-ready configuration avoidance APIs, Gradle Kotlin DSL 1.1, and more.
Read the Gradle 5.x upgrade guide to learn about breaking changes and considerations for upgrading from Gradle 5.0.
If upgrading from Gradle 4.x, please read upgrading from Gradle 4.x to 5.0 first.
We would like to thank the following community contributors to this release of Gradle:
Mike Kobit,
Kent Fletcher,
Niklas Grebe,
Jonathan Leitschuh,
Sebastian Schuberth,
Dan Sănduleac,
Olivier Voortman,
Alex Saveau,
and Till Krullmann.
See the full set of release notes.
Upgrade Instructions
Switch your build to use Gradle 5.1 by updating your wrapper properties:
./gradlew wrapper --gradle-version=5.1

Standalone downloads are available at gradle.org/releases.
Reporting Problems
If you find a problem with Gradle 5.1, please file a bug on GitHub Issues adhering to our issue guidelines.  If you're not sure you're encountering a bug, please use the forum.
We hope you will build happiness with Gradle 5.1, and we look forward to your feedback via Twitter or on GitHub.
v5.0.0
Compare Source
The Gradle team is excited to announce Gradle 5.0.
This release features a production-ready Kotlin DSL, dependency version alignment (similar to and usable with Maven BOMs), task timeouts, Java 11 support, and more.
These release notes list what's new since Gradle 4.10. You can review the highlights since Gradle 4.0 here.
Read the Gradle 5.0 upgrade guide to learn about breaking changes and considerations for upgrading from Gradle 4.x.
We would like to thank the following community contributors to this release of Gradle: Jean-Baptiste Nizet, Jonathan Leitschuh, Ben McCann, Björn Kautler, Georg Friedrich, Stefan M.,  Xiang Li,  Theodore Ni, James Justinic, Mike Kobit, Alex Saveau, Kevin Macksamie, Cliffred van Velzen, Artem Zinnatullin, Jakub Strzyżewski, Martin Dünkelmann, Thad House, Dan Sanduleac, Felipe Lima, and thc202.

Kotlin DSL 1.0
First and foremost, Gradle Kotlin DSL is now production-ready with it's 1.0 release! Authoring your build logic using Kotlin provides significant additional editing assistance in IDEs, including: improved completion, error highlighting, and refactoring tools. Please read our Gradle Kotlin DSL Primer and follow our migrating build logic from Groovy to Kotlin guide if you're interested. If you prefer the flexibility and dynamic features of Groovy, that's totally okay — the Groovy DSL will not be deprecated.

Dependency version alignment
This version of Gradle introduces dependency version alignment.  This allows different modules belonging to the same logical group (platform) to have identical versions in a dependency graph.  Maven BOMs can be imported to define platforms as well.
dependencies {
    // import a BOM. The versions used in this file will override any other version found in the graph
    implementation(enforcedPlatform("org.springframework.boot:spring-boot-dependencies:1.5.8.RELEASE"))

     // define dependencies without versions
    implementation("com.google.code.gson:gson")
    implementation("dom4j:dom4j")

     // this version will be overriden by the one found in the BOM
    implementation("org.codehaus.groovy:groovy:1.8.6")
}

More details about BOM import can be found in this section of the userguide.
Gradle build initialization features
gradle init functionality has been upgraded in this release: is now optionally interactive, includes new kotlin-library and kotlin-application project types, provides options for configuring project and package names, and more.

Searchable documentation
Search for Gradle Docs is back.  The kind folks at Algolia kindly host an index used to allow you to search the user manual and DSL reference.

Gradle API Javadocs now take advantage of Javadoc built-in autocomplete, making it easier to find classes and methods you're interested in.

Task timeouts
You can now specify a timeout duration for a task, after which it will be interrupted.  Read more about task timeouts in the docs.
HTTP retries during dependency resolution
When Gradle attempts to connect to a remote repository via HTTP, if it fails, Gradle will retry before blacklisting the repository.
No extra configuration is needed. See the section on HTTP retries for more information.
Performance features
Gradle can now be started as a low-prority process. This ensures that other applications like your IDE or browser stay responsive, even while a very demanding build is running.
When using @OutputFiles or @OutputDirectories with an Iterable type, Gradle used to disable caching for the task.  This is no longer the case, and using such properties doesn't prevent the task from being cached.  The only remaining reason to disable caching for the task is if the output contains file trees.
The JaCoCo plugin plugin now works seamlessly with the build cache.  When applying the plugin with no extra configuration, the test task stays cacheable and parallel test execution can be used.

Java 11 runtime support
Java enthusiasts will be happy to read that this release supports running Gradle builds with JDK 11.
Plugin authoring features
This release introduces useful changes for plugin and custom task authors, including an API for creating SourceDirectorySets, improvements to the Provider API, and improved build cache compatibility.
Gradle Native features
The Gradle Native project continues to improve and evolve the native ecosystem support for Gradle.
Upgrade Instructions
Switch your build to use Gradle 5.0 by updating your wrapper properties:
./gradlew wrapper --gradle-version=5.0

Standalone downloads are available at gradle.org/release-candidate.
Reporting Problems
If you find a problem with Gradle 5.0, please file a bug on GitHub Issues adhering to our issue guidelines.  If you're not sure you're encountering a bug, please use the forum.
We hope you will build happiness with Gradle 5.0, and we look forward to your feedback via Twitter or on GitHub.
v4.10.3
Compare Source
This bug-fix release contains 3 changes to Gradle 4.10.2:

#7510
#6849
#7014

It also incorporates all fixes to 4.10.1 and 4.10.2.
We recommend that you use Gradle 4.10.3 over 4.10, 4.10.1 and 4.10.2.
Upgrade Instructions
Switch your build to use Gradle 4.10.3 by updating your wrapper properties:
./gradlew wrapper --gradle-version=4.10.3
Standalone downloads are available at https://gradle.org/install.
Reporting Problems
If you find a problem with Gradle 4.10.3, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v4.10.2
Compare Source
This bug-fix release contains 3 changes to Gradle 4.10.1:

Dependent module Scala compilation in test context fails for 4.10.1 #6735
Gradle fails to resolve project dependencies against Scala projects #6750
Candidate set provided to AttributeDisambiguationRule contains null entry #6747

We recommend that you use Gradle 4.10.2 over 4.10.1 or 4.10.
Upgrade Instructions
Switch your build to use Gradle 4.10.2 by updating your wrapper properties:
./gradlew wrapper --gradle-version=4.10.2
Standalone downloads are available at https://gradle.org/install.
Reporting Problems
If you find a problem with Gradle 4.10.2, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v4.10.1
Compare Source
This bug-fix release addresses 6 regressions in Gradle 4.10:

#6656: FileTreeElement.getPath() returns absolute system dependent filepath.
#6592: Up-to-date checks for missing files can be incorrect
#6612: Gradle fails when no incremental compile snapshot data available.
#6582: Gradle 4.10 incorrect ordering between dependencies of dependent tasks.
#6558: tasks.withType(ScalaCompile::class.java).configureEach fails on multi-project builds.
#6653: Double deprecation message when using publishing plugin.

In addition, the Gradle Kotlin DSL has been updated to 1.0 RC6, see the release notes for the list of included fixes.
Upgrade Instructions
Switch your build to use Gradle 4.10.1 by updating your wrapper properties:
./gradlew wrapper --gradle-version=4.10.1
Standalone downloads are available at https://gradle.org/install.
Reporting Problems
If you find a problem with Gradle 4.10.1, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v4.10.0
Compare Source
The Gradle team is pleased to announce Gradle 4.10. This is a big release.
First and foremost, this release of Gradle features an improved incremental Java compiler, now enabled by default.
This will result in significantly reduced Java compilation time in subsequent builds when outputs are not up-to-date or resolved from the build cache.
Chances are caches in those .gradle/ directories have accumulated a few (or a few dozen) gigabytes over time.
If so, you'll be relieved to know that Gradle will now periodically clean up unused /caches under GRADLE_USER_HOME and project root directories.
A moment you have anticipated is nearly here, as the Kotlin DSL reaches version 1.0 RC3.
Configuration avoidance, buildSrc refactoring propagation to the IDE, and lots of DSL polish make this the release to try.
Gradle Kotlin DSL 1.0 will ship with the next version of Gradle, 5.0.
Read this blog post for guidance on trying the Kotlin DSL and submitting feedback.
You can now use SNAPSHOT plugin versions with the plugins {} and pluginManagement {} blocks.
This is especially good news for Kotlin DSL users, who will get code assistance and auto-completion for these SNAPSHOT plugins.
Special thanks to Sébastien Deleuze for contributing.
Last but not least, included builds can now be nested.
This makes some common workflows more convenient, such as working on multiple source repositories at the same time to implement a cross-cutting feature.
We hope you will build happiness with Gradle 4.10, and we look forward to your feedback via Twitter or on GitHub.
Upgrade Instructions
Switch your build to use Gradle 4.10 quickly by updating your wrapper properties:
./gradlew wrapper --gradle-version=4.10

Standalone downloads are available at gradle.org/install.
v4.9.0
Compare Source
The Gradle team is pleased to announce Gradle 4.9.
First, publishing tools get some more love: projects that publish auxiliary publications (e.g. test fixtures) through maven-publish and ivy-publish can now be depended upon by other projects in the same build. There is also a new Publishing Overview chapter in the user manual and updates throughout the documentation regarding publishing artifacts using Maven and Ivy.
In addition to lazy tasks use, Kotlin DSL build scripts are evaluated faster with version 0.18.4, included in this version of Gradle. IntelliJ IDEA and Android Studio user experience is also improved.
See details in the Kotlin DSL v0.18.x release notes.
You can now pass arguments to JavaExec tasks directly from the command-line using --args:
❯ gradle run --args 'foo --bar'

No more need to hard-code arguments in your build scripts. Consult the documentation for the Application Plugin for more information.
Last but not least, this version of Gradle has an improved dependency insight report. Read the details further on.
We hope you will build happiness with Gradle 4.9, and we look forward to your feedback via Twitter or on GitHub.
Upgrade Instructions
Switch your build to use Gradle 4.9 quickly by updating your wrapper properties:
./gradlew wrapper --gradle-version=4.9
Standalone downloads are available at gradle.org/install.
v4.8.1
Compare Source
This bug-fix release addresses 6 regressions in Gradle 4.8:

#5740: Maven Central dropped support for older TLS implementations. This makes the dependency resolution fail if the Gradle build runs on JDK 7.
#5701: Gradle 4.8 broke compatibility with the artifactory and bintray publishing plugins.
#5708: Gradle 4.8 sometimes fails with ConcurrentModificationException when project.tasks.withType() is used.
#5729: The dependency resolution engine sometimes fails with "Unexpected parent dependency" message, which became more apparent in Gradle 4.8.
#5722: Gradle 4.8 broke the ability of the SourceSet to override the compile tasks' destination directory.
#5692: Gradle 4.8 doesn't consider versions equal when using dependencySubstitution and failOnVersionConflict.

Upgrade Instructions
Switch your build to use Gradle 4.8.1 by updating your wrapper properties:
./gradlew wrapper --gradle-version=4.8.1
Standalone downloads are available at https://gradle.org/install.
Reporting Problems
If you find a problem with Gradle 4.8.1, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v4.8.0
Compare Source
The Gradle team is pleased to announce Gradle 4.8.
First and foremost, this release of Gradle features dependency locking: a mechanism for locking dependency versions which allows builds to become reproducible in the face of dynamic versions or version ranges.
Read the user manual chapter on dependency locking to learn how to take advantage of this exciting new feature.
The publishing plugins get some highly-anticipated improvements in this release:

The Signing Plugin now supports signing all artifacts of a publication.
The Maven Publish Plugin now provides a dedicated, type-safe DSL to customize the POM generated as part of a Maven publication.
The Ivy Publish Plugin now provides a dedicated, type-safe DSL to customize the Ivy module descriptor generated as part of an Ivy publication.
Configuration-wide dependency excludes are now published

The maven-publish and ivy-publish plugins are now considered stable and use of the maven plugin is discouraged as it will eventually be deprecated — please migrate.
User experience for incremental annotation processing is improved.
Compilation will no longer fail when a processor does something that Gradle detects will not work incrementally.
Unused non-incremental processors no longer prevent incremental compilation.
Finally, annotation processors are now able to decide dynamically if they are incremental or not.
This allows processors with extension mechanisms to check extensions for incrementality before enabling incremental annotation processing.
New native plugins continue to improve with better control over system include path for native compilation and other improvements.
Gradle 4.8 includes Kotlin DSL 0.17.5, bringing the latest Kotlin 1.2.41 release and many improvements to the user experience including location aware runtime error reporting, convenient configuration of nested extensions, faster and leaner configuration time, and TestKit support.
At the same time the IntelliJ IDEA Kotlin Plugin fixed many long standing build script editing related issues.
See details and examples in the Kotlin DSL v0.17 release notes.
We hope you build happiness with Gradle 4.8, and we look forward to your feedback via Twitter or on GitHub.
Upgrade instructions
Switch your build to use Gradle 4.8 quickly by updating your wrapper properties:
gradle wrapper --gradle-version=4.8

Standalone downloads are available at gradle.org/releases.
Reporting Problems
If you find a problem with Gradle 4.8, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v4.7.0
Compare Source
The Gradle team is pleased to announce Gradle 4.7.
First and foremost, Gradle's incremental Java compiler can now run annotation processing incrementally. No user-facing configuration is necessary, but processor authors need to opt-in. We request annotation processor authors read the documentation for this feature and contact the Gradle team via the forum for assistance.
Java enthusiasts will be happy to read that this release supports running Gradle builds with JDK 10.
Gradle log output is now grouped by task for non-interactive executions, making interleaved logs a thing of the past on CI. It also enables build scan plugin v1.13 to show logs per task:

Moving on to other areas of user experience: running tests is further improved as failed tests now run first. Together with the --fail-fast option it provides the quickest possible feedback loop.
This release introduces an incubating new capability for Kotlin DSL users: precompiled script plugins. This means that you can create a Kotlin DSL script within a regular Kotlin source set and get the benefits of binary plugins. For example, src/main/kotlin/nyan.gradle.kts could be used as plugins { id("nyan") }.
Kotlin DSL v0.16 also includes Kotlin 1.2.31, a more consistent API, better IDE support, and more. See details and examples in the Kotlin DSL v0.16 release notes.
We hope you will build happiness with Gradle 4.7, and we look forward to your feedback via Twitter or on GitHub.
Upgrade Instructions
Switch your build to use Gradle 4.7 quickly by updating your wrapper properties:
gradle wrapper --gradle-version=4.7
Standalone downloads are available at gradle.org/releases.
Reporting Problems
If you find a problem with Gradle 4.7, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v4.6.0
Compare Source
The Gradle team is pleased to announce Gradle 4.6.
First and foremost, this release of Gradle includes built-in support for JUnit Platform and the JUnit Jupiter/Vintage Engine, also known as JUnit 5 support.
You can use the new filtering and engines functionality in JUnit 5 using the examples provided below and in the documentation.
Thank you to the JUnit team for helping to achieve JUnit Platform support, and a special thank you to Andrew Oberstar for extraordinary contributions toward this effort.
Also regarding testing, you can now improve your testing feedback loop when running JVM-based tests using the new fail-fast option for Test tasks, which stops the build immediately after the first test failure.
// Example JUnit 5 and fail-fast test configuration
test {
    useJUnitPlatform {
        excludeTags 'slow'
        includeEngines 'junit-jupiter', 'junit-vintage'
    }

    failFast = true
}

Moving on to dependency management improvements: you can now declare dependency constraints for transitive dependencies and avoid problems caused by oft-hidden upstream dependency changes.
This release also features enhanced Maven dependency compatibility: support for importing BOMs, optional dependencies, and compile/runtime separation when consuming POMs.
For now you must enable these features by adding enableFeaturePreview('IMPROVED_POM_SUPPORT') to your settings.gradle file, as they break backward compatibility in some cases.
This version of Gradle also comes with a couple especially useful new APIs for task development. You can now declare custom command-line flags for your custom tasks, for example: gradle myCustomTask --myfoo=bar. In addition, tasks that extend Test, JavaExec or Exec can declare rich arguments for invoking the underlying executable. This allows for better modeling of tools like annotation processors.
Speaking of annotation processors, it is now more convenient to declare dependencies that are annotation processors through the new annotationProcessor dependency configuration. Using a separate dependency configuration for annotation processors is a best practice for improving performance.
Kotlin DSL v0.15.6 is included in this release of Gradle, and features  initialization scripts support, nicer script compilation error reporting, performance improvements, and better IntelliJ IDEA integration. Details are available in the linked release notes.
We hope you will build happiness with Gradle 4.6, and we look forward to your feedback via Twitter or on GitHub.
Upgrade Instructions
Switch your build to use Gradle 4.6 quickly by updating your wrapper properties:
gradle wrapper --gradle-version=4.6
Standalone downloads are available at gradle.org/releases.
Reporting Problems
If you find a problem with Gradle 4.6, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v4.5.1
Compare Source
This bug-fix release addresses 3 regressions in Gradle 4.5.
Changes in dependency management caused a regression in 4.5 where in some rare cases a dependency could be imported into a different scope than the one declared.
Starting in 4.5, the build cache configuration is shared between builds part of a composite build. NullPointerException could be observed if the parent build finished before the different composites. This lifecycle issue has now been resolved.
A regression in Eclipse project generation caused a sub-project to be added as a dependency to itself, resulting in an error when opening the project in Eclipse.
For the full list of fixed issues, see the 4.5.1 GitHub milestone.
Upgrade Instructions
Switch your build to use Gradle 4.5.1 by updating your wrapper properties:
./gradlew wrapper --gradle-version=4.5.1
Standalone downloads are available at https://gradle.org/install.
Reporting Problems
If you find a problem with Gradle 4.5.1, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v4.5.0
Compare Source
The Gradle team is pleased to announce Gradle 4.5.
First and foremost, this release of Gradle features improvements to the build cache:

Caching for C and C++ compilation is now stable.
The ANTLR plugin now takes advantage of the build cache.
A couple of rough edges to build cache behavior have been polished, read more in the detailed release notes.

In addition to cacheability improvements for native development, incremental compilation for C/C++ does finer-grained analysis of dependencies between source files and header files, which will result in fewer files compiled and a higher cache hit-rate. Read details about C and C++ compilation improvements here.
Now on to performance improvements everyone can enjoy: less memory consumption and faster up-to-date behavior. Gradle 4.5 features much more memory-efficient incremental compilation. Combined with less file canonicalization, faster task selection, and faster variant-aware dependency resolution, this results in up to 30% faster up-to-date checking. The improvement will be especially pronounced for projects with a large number of constants, as is typical in Android projects. For example, here are 2 snapshots comparing cross-build caches.
The 1st one from Gradle 4.4 using 440MB:

This 2nd snapshot from Gradle 4.5 using 280MB:

Next up, you can finally sign artifacts using gnupg-agent. Special thanks to Christoph Böhme for contributing this highly-anticipated feature.
Documentation has been upgraded in this release, with use-case oriented examples for several highly trafficked pages, improved navigation, and a more pleasant experience in many ways. Read details about the improvements, or just start with the new docs home page.
Individual deprecation warnings are no longer displayed in console output by default, as many users often cannot take action on deprecation warnings from third party plugins. You can now control the verbosity of logging deprecation warnings.
Last but not least, 2 Kotlin DSL updates:

You can now generate Gradle Kotlin DSL scripts using gradle init --dsl kotlin.
Kotlin DSL v0.14 is included in this release of Gradle. It features code navigation to Gradle sources in IDEs with the Gradle binary distribution (not just -all anymore), embedded Kotlin upgraded to 1.2.0 and more.

We hope you will build happiness with Gradle 4.5, and we look forward to your feedback via Twitter or on GitHub.
Upgrade Instructions
Switch your build to use Gradle 4.5 quickly by updating your wrapper properties:
./gradlew wrapper --gradle-version=4.5
Standalone downloads are available at https://gradle.org/install.
Reporting Problems
If you find a problem with Gradle 4.5, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v4.4.1
Compare Source
This bug-fix release addresses 3 regressions in Gradle 4.4.
We started shipping JGit <IP_ADDRESS>7081-r in Gradle 4.4.  Some of the non-shaded JGit resources leaked into the gradleApi() dependency and caused problems in some builds.  We now shade all of JGit's resources.
Some builds using Kotlin DSL had problems applying the build-scan plugin in Gradle 4.4. We've updated to kotlin-dsl 0.13.2.
Gradle 4.4 contained changes to internal APIs that broke the popular Nebula dependency lock plugin. This release restores binary compatibility for that plugin. Internal APIs are subject to change, although we try to be mindful of the impact of every change in each Gradle release. If particular internal APIs are useful, please open an issue describing your use case, so we can judge where our public APIs are lacking.
For the full list of fixed issues, see the 4.4.1 GitHub milestone.
Upgrade Instructions
Switch your build to use Gradle 4.4.1 by updating your wrapper properties:
./gradlew wrapper --gradle-version=4.4.1
Standalone downloads are available at https://gradle.org/install.
Reporting Problems
If you find a problem with Gradle 4.4.1, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.
v4.4.0
Compare Source
The Gradle team is pleased to announce Gradle 4.4.
First and foremost, this release of Gradle features some exciting improvements for IDE users:

[Visual Studio 2017 i

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 5.x releases. However, if you upgrade to 5.x manually then Renovate will then reenable updates for minor and patch updates automatically.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.


gitignore for www directory or build to dist

When starting the app via nx serve, stencil compiles the app to /apps/my-app/www. It would be great if the workspace is
a) either configured to put those build files into /dist
b) or adds a .gitignore file to ignore the www directory
I'm not sure if the Stencil API allows a).
Steps for Reproduction
create-nx-workspace my-workspace
npm install @nxext/stencil --save
nx g @nxext/stencil:app my-app
git add .
git commit -m "initial commit"
npm start my-app

Thanks a lot, btw, for creating this project!

Hey,
the www is something the stencil compiler does by default. You can try to configure the output target in your `stencil.config.ts. That's nothing I'm doing and I'd like to stick with the default/stencil configuration here.

With actual versions the builder target is in dist. Is this okay and serves your needs?
I think I misunderstood something last comment I did

Hi,
sorry, that I didn't respond to your last post yet. I put my Stencil project aside to work on other things.
I'm not sure what you mean by "actual versions"?
When following the steps of my origin post, after running the app for the first time, you end up with 44 untracked files in your repository:

As these are build artefacts, they should either be generated in the /dist directory or at least be ignored via .gitignore.
Of course, it's easy to do the latter manually, but it would be a nice improvement if @nxext/stencil generated a .gitignore file automatically when generating a new app via nx g @nxext/stencil:app.

What version are you using? My confusion comes from, the build process builds per default into dist/apps/<appname> since a few versions.
$ nx run stencil-pwa:build
[50:14.5]  @stencil/core v1.14.0 🏒
[50:16.6]  build, app, prod mode, started ...
[50:16.6]  transpile started ...
[50:17.6]  transpile finished in 960 ms
[50:17.6]  copy started ...
[50:17.6]  generate lazy started ...
[50:19.5]  copy finished (1243 files) in 1.93 s
[50:40.4]  generate lazy finished in 22.78 s
[50:40.4]  build finished in 23.81 s

$ ls dist/apps/stencil-pwa/www
assets           build            host.config.json index.html       manifest.json

🤔 Weird, running the same command (nx run my-app:build), a dist/apps/my-app directory is created, however it is empty. In addition, apps/my-app/www is also created and it contains all the files as in your example.
Here's the repository I used for my test:
https://github.com/luchsamapparat/nx-workspace-stencil
@nrwl/workspace - 9.5.1
@nxext/stencil - 0.1.3
@stencil/core - ^1.14.0

Is the repo public? I can't reach it

Sorry, I accidentally made it private. Should be accessible now

Hey, I tried your repo and can't reproduce the issue. Works as expected building into dist. WHat OS do you use? Windows? Mac? Linux? Mayve a platform problem

There's a new release. I hope it works for you :-)

The latest release of @nxext/stencil indeed fixes the issue 🥳


Add the Google Webmaster Tools verification code for better monitoring

What problem does the pull request solve?
Issue raised this morning where a broken set of pages were on live. These were reported by an external party. Adding in the meta tag in the head to verify the site. We can then setup email alerts using Webmaster Tools to notify us when we have errors on the live site.
How has this been tested?
Simple meta tag addition to the head element. Change will have no effect on site functionality.
What type of change is it?

New feature (non-breaking change which adds functionality)

Has the documentation been updated?
No documentation change required. Comment in code explaining the additions meaning.

@Nooshu do we need to do the same for the prototype kit?

@joelanman yes good idea. I will set it up for elements, then do the same for the prototype kit too.


Move endpoints in README to separate page

Detailed Description / Context
At the moment, the README is cluttered with the exhaustive list of endpoints
Possible Implementation
If a user/contributor wants to check these, they can click through a clear link to see them, otherwise the rest of the README sections can remain un-dwarfed and easy to navigate!

Hello, I have fixed this issue and created a pull request.

Thanks @yousefsawy


Send ack_message to WAL slot after every commit

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#105  👈
#104
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @acco and the rest of your teammates on  Graphite


BIGTOP-2932: Patch to compile with openssl 1.1 (HADOOP-14597)

Could you please close it since BIGTOP-2932 is committed ?
Thanks you very much
Olaf


Update step count when steps are dynamically rendered

Fixes #135
At the moment the active step is changed to the last one and a warning is logged if activeStep >= newStepCount.
There's no detection for if a "lower" or the currently rendered step is removed, if that happens the new step at the activeStep index is rendered/etc. I think that would require a unique identifier for each step instead of an index. Maybe that's something to consider?
I don't think there are any unexpected side effects. All the tests pass at least. Should be backwards compatible since it's functionally identical if the children never change.
(I noticed there's already a branch for this but there's no commits on it.)

Thanks for your work, I'll take a look as soon as possible

Already resolved, see https://github.com/devrnt/react-use-wizard/issues/135


Add support contact details

What are you changing in this pull request and why?
Add support contact details related to partner and customer inquiries regarding the dbt Semantic Layer

hey @rl-dbt - i've made some small tweaks and corrected the email since<EMAIL_ADDRESS>isn't the right one. approved and feel free to merge


Loop over raw_precompile items instead of taking the first one by default

[ ] I have added or updated the specs.
[x] I have verified that the specs pass on my computer.
[x] I have not attempted to bump, or alter versions.
[ ] This is a documentation change.
[x] This is a source change.

Description
When trying to set a regexp in raw_precompile only the first matching item is copied to assets folder.
Example
_config.yml :
assets:
  precompile: []
  raw_precompile:
    - "*featured.jpg"

_assets directory structure (before server run):

_assets/

img/

image1-featured.jpg
image2-featured.jpg
image3-featured.jpg

Generated assets directory (after server run):

assets/

image1-featured.jpg

image2-featured.jpg and image3-featured.jpg are missing.
Solution
Loop over matching pattern and copy each one to the destination.

Please squash if you would like me to review. Thanks!

Done.

Thanks :heart:

You're welcome 😄


Add attr_accessor to skip counts after create

I have a counter which gets triggered a lot on create (+-100 per second) which causes some performance issues.
I wanted to disable counter_culture on create and manually fix the count at a later stage.
I saw this issue: https://github.com/magnusvk/counter_culture/issues/299, but decided to implement it in a different way.
Please let me know if you are willing to add this to the gem. If so I can also update the readme.

Two thoughts in response here:

Why just the after_create call? Isn't this a more general issue that might also apply for updates? If we were to include this in the gem, I would probably want to allow disabling count updates completely.
Why is this a flag on the instance level? Wouldn't it be more convenient to just wrap a whole block of code and say "don't update any counts on the model SomeModel in this block?"

Two thoughts in response here:

Why just the after_create call? Isn't this a more general issue that might also apply for updates? If we were to include this in the gem, I would probably want to allow disabling count updates completely.
Why is this a flag on the instance level? Wouldn't it be more convenient to just wrap a whole block of code and say "don't update any counts on the model SomeModel in this block?"

Closing this for lack of response. Happy to re-evaluate with more discussion.


🐛 Bug Report: Authentication Errors get Swallowed

📜 Description
If an error occurs during sign in (such as the below screenshot), the details of the error get swallowed - with nothing showing up on the client, nor in the server side logs

👍 Expected behavior
I expected to see a more detailed error in the backend server side logs (e.g. a stack trace).
👎 Actual Behavior with Screenshots
No Logs
👟 Reproduction steps
Repro steps are tricky as it depends on causing an error in your auth provider.  #23032 has one such example
📃 Provide the context for the Bug.
From some debugging, it seems like https://github.com/backstage/backstage/blob/c1742c625484a73f24d86d761cba3544e29bffcd/plugins/auth-node/src/oauth/createOAuthRouteHandlers.ts#L246 is the catch block where the error gets swallowed.  This probably needs to log the error to a logger.
🖥 Your Environment
yarn run v1.22.21
$ /home/alex/PlatformEngineering.Backstage/node_modules/.bin/backstage-cli info
OS:   Linux <IP_ADDRESS>-microsoft-standard-WSL2 - linux/x64
node: v20.10.0
yarn: 1.22.21
cli:  0.25.0 (installed)
backstage:  1.21.1

Dependencies:
  @backstage/app-defaults                                          1.4.6
  @backstage/backend-app-api                                       0.5.10, 0.5.9
  @backstage/backend-common                                        0.20.0, 0.20.1
  @backstage/backend-defaults                                      0.2.8
  @backstage/backend-dev-utils                                     0.1.2, 0.1.3
  @backstage/backend-openapi-utils                                 0.1.1
  @backstage/backend-plugin-api                                    0.6.8, 0.6.9
  @backstage/backend-tasks                                         0.5.13, 0.5.14
  @backstage/backend-test-utils                                    0.2.9
  @backstage/catalog-client                                        1.5.1, 1.5.2
  @backstage/catalog-model                                         1.4.3
  @backstage/cli-common                                            0.1.13
  @backstage/cli-node                                              0.2.1, 0.2.2
  @backstage/cli                                                   0.25.0
  @backstage/config-loader                                         1.6.0, 1.6.1
  @backstage/config                                                1.1.1
  @backstage/core-app-api                                          1.11.2
  @backstage/core-compat-api                                       0.1.0
  @backstage/core-components                                       0.13.9
  @backstage/core-plugin-api                                       1.8.1
  @backstage/e2e-test-utils                                        0.1.0
  @backstage/errors                                                1.2.3
  @backstage/eslint-plugin                                         0.1.4
  @backstage/frontend-plugin-api                                   0.4.0
  @backstage/integration-aws-node                                  0.1.8
  @backstage/integration-react                                     1.1.22
  @backstage/integration                                           1.8.0
  @backstage/plugin-api-docs                                       0.10.2
  @backstage/plugin-app-backend                                    0.3.56
  @backstage/plugin-app-node                                       0.1.8
  @backstage/plugin-auth-backend-module-atlassian-provider         0.1.0
  @backstage/plugin-auth-backend-module-gcp-iap-provider           0.2.2
  @backstage/plugin-auth-backend-module-github-provider            0.1.5
  @backstage/plugin-auth-backend-module-gitlab-provider            0.1.5
  @backstage/plugin-auth-backend-module-google-provider            0.1.5
  @backstage/plugin-auth-backend-module-microsoft-provider         0.1.3
  @backstage/plugin-auth-backend-module-oauth2-provider            0.1.5
  @backstage/plugin-auth-backend-module-oauth2-proxy-provider      0.1.0
  @backstage/plugin-auth-backend-module-okta-provider              0.0.1
  @backstage/plugin-auth-backend                                   0.20.2
  @backstage/plugin-auth-node                                      0.4.2, 0.4.3
  @backstage/plugin-azure-devops-backend                           0.5.0
  @backstage/plugin-azure-devops-common                            0.3.2
  @backstage/plugin-azure-devops                                   0.3.10
  @backstage/plugin-catalog-backend-module-azure                   0.1.27
  @backstage/plugin-catalog-backend-module-msgraph                 0.5.15
  @backstage/plugin-catalog-backend-module-scaffolder-entity-model 0.1.5
  @backstage/plugin-catalog-backend                                1.16.0
  @backstage/plugin-catalog-common                                 1.0.19
  @backstage/plugin-catalog-graph                                  0.3.2
  @backstage/plugin-catalog-node                                   1.6.0
  @backstage/plugin-catalog-react                                  1.9.2
  @backstage/plugin-catalog                                        1.16.0
  @backstage/plugin-entity-validation                              0.1.13
  @backstage/plugin-events-node                                    0.2.17
  @backstage/plugin-explore-backend                                0.0.18
  @backstage/plugin-explore-common                                 0.0.2
  @backstage/plugin-explore-react                                  0.0.34
  @backstage/plugin-explore                                        0.4.14
  @backstage/plugin-github-actions                                 0.6.9
  @backstage/plugin-home-react                                     0.1.6
  @backstage/plugin-home                                           0.6.0
  @backstage/plugin-kubernetes-backend                             0.14.0
  @backstage/plugin-kubernetes-common                              0.7.2
  @backstage/plugin-kubernetes-node                                0.1.2
  @backstage/plugin-kubernetes-react                               0.2.0
  @backstage/plugin-kubernetes                                     0.11.3
  @backstage/plugin-org                                            0.6.18
  @backstage/plugin-permission-common                              0.7.11, 0.7.12
  @backstage/plugin-permission-node                                0.7.19, 0.7.20
  @backstage/plugin-permission-react                               0.4.18
  @backstage/plugin-proxy-backend                                  0.4.6
  @backstage/plugin-scaffolder-backend-module-azure                0.1.0
  @backstage/plugin-scaffolder-backend-module-bitbucket            0.1.0
  @backstage/plugin-scaffolder-backend-module-gerrit               0.1.0
  @backstage/plugin-scaffolder-backend-module-github               0.1.0
  @backstage/plugin-scaffolder-backend-module-gitlab               0.2.11
  @backstage/plugin-scaffolder-backend                             1.19.2
  @backstage/plugin-scaffolder-common                              1.4.4
  @backstage/plugin-scaffolder-node                                0.2.9
  @backstage/plugin-scaffolder-react                               1.7.0
  @backstage/plugin-scaffolder                                     1.17.0
  @backstage/plugin-search-backend-module-catalog                  0.1.12
  @backstage/plugin-search-backend-module-explore                  0.1.13
  @backstage/plugin-search-backend-module-pg                       0.5.17
  @backstage/plugin-search-backend-module-techdocs                 0.1.12
  @backstage/plugin-search-backend-node                            1.2.12, 1.2.13
  @backstage/plugin-search-backend                                 1.4.8
  @backstage/plugin-search-common                                  1.2.10, 1.2.9
  @backstage/plugin-search-react                                   1.7.4
  @backstage/plugin-search                                         1.4.4
  @backstage/plugin-tech-radar                                     0.6.11
  @backstage/plugin-techdocs-backend                               1.9.1
  @backstage/plugin-techdocs-module-addons-contrib                 1.1.3
  @backstage/plugin-techdocs-node                                  1.11.0
  @backstage/plugin-techdocs-react                                 1.1.14
  @backstage/plugin-techdocs                                       1.9.2
  @backstage/plugin-user-settings                                  0.7.14
  @backstage/release-manifests                                     0.0.11
  @backstage/test-utils                                            1.4.6
  @backstage/theme                                                 0.5.0
  @backstage/types                                                 1.1.1
  @backstage/version-bridge                                        1.0.7
Done in 0.46s.

👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

I think it would make sense to have more verbose logging in the backend here, but still avoid sending any detailed information to the frontend. Tbh I find that even what we're sending here is potentially a bit much.

Another issue where lack of logging is hurting debuggability: https://github.com/backstage/backstage/issues/24387

Sorry, looks like I forgot to follow up here.  I had a quick look at making a PR for this a couple of months ago, but couldn't find a way work out a way to flow the logger down to the createOAuthRouteHandler.ts without making breaking API changes - particularly with how oauth was plumbed through to both new and old backend system.  I'm not hugely familiar with how the new backend system works so it's very possible I was missing something simple.

@afscrome yep createOAuthRouteHandlers is prolly the best place to add this logging. To avoid a breaking change we can add logger as an optional dependency in the options and only log if its available. Might be that it's fine to ship as a breaking change too though tbh, if we can be sure that the impact will be minimal. I'm not even sure we need to export the createOAuthRouteHandlers at all.
The wiring happens here: https://github.com/backstage/backstage/blob/d3265deba86e8e6dbe653c645a3a98632d5133f0/plugins/auth-node/src/oauth/createOAuthProviderFactory.ts#L51
At this point we can access the logger from ctx.logger, so there won't actually be any breaking change in modules etc.


⚠ Samsung has degraded performance

In c749fb4, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 3258 ms

Resolved: Samsung performance has improved in 64157e3.


Unit Test Failure in Flutter Master: "foundation" Test Case

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Install Android Studio Giraffe | Version 2022.3.1 Patch 4.

Clone the Flutter packages repository: git clone https://github.com/flutter/flutter

3 . Use the Pixel 7 API 34 emulator.

Run the following commands in the console:
cd flutter
cd packages/flutter && flutter test test/foundation >> flutter-foundationM-logs.txt

Expected results
Successful execution of all tests.
Actual results
The "foundation" test case fails.
flutter version: 3.17.0-10.0.pre.42
Code sample
Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
00:07 +211 -1: /Users/josefinadiz/Desktop/frame/flutter/packages/flutter/test/foundation/isolates_test.dart: compute() closes all ports with valid message [E]

  Expected: <0>

    Actual: <254>

  package:matcher                                     expect

  package:flutter_test/src/widget_tester.dart 458:18  expect

  test/foundation/isolates_test.dart 98:3             expectFileSuccessfullyCompletes

flutter-foundationM-logs.txt
Flutter Doctor output
Doctor output
Flutter Doctor Output:

 [✓] Flutter (Channel master, 3.17.0-10.0.pre.42, on macOS 14.0 23A344 darwin-arm64, locale en-US)
    • Flutter version 3.17.0-10.0.pre.42 on channel master at /Users/josefinadiz/Desktop/flutter/flutter
    • Upstream repository [GitHub - flutter/flutter: Flutter makes it easy and fast to build beautiful apps for mobile and beyond](https://github.com/flutter/flutter.git)
    • Framework revision e9de448420 (19 hours ago), 2023-11-17 02:08:13 +0100
    • Engine revision 5064aeff00
    • Dart version 3.3.0 (build 3.3.0-143.0.dev)
    • DevTools version 2.30.0-dev.4

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/josefinadiz/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 [Flutter - IntelliJ IDEs Plugin | Marketplace](https://plugins.jetbrains.com/plugin/9212-flutter)
    • Dart plugin can be installed from:
      🔨 [Dart - IntelliJ IDEs Plugin | Marketplace](https://plugins.jetbrains.com/plugin/6351-dart)
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] VS Code (version 1.84.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.76.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 14.0 23A344 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 119.0.6045.159

[✓] Network resources
    • All expected network resources are available.

Step 2 incorrectly referenced the wrong repo; fixed and re-routing to framework team since these are framework tests.

With the information provided, I cannot reproduce this. The tests run fine on my machine and CI is also green. Was this a one-off flake or does it fail on subsequent runs as well?

Hi @goderbauer, we attempted to reproduce this issue again but is no longer happening, at least with the latest version of master and with stable. I believe it is safe to close, we will re-open it if we happen to run into it again.


failed to resolve: could not find dxdup in source

I'm on Arch Linux with Rust nightly (2024-07-13). I run just run and I get this:
   --> src/main.rs:130:30
    |
130 |             Box::new(source::dxdup::DisplayDuplicator::new()?);
    |                              ^^^^^ could not find `dxdup` in `source`
    |
note: found an item that was configured out
   --> src/source/mod.rs:5:9
    |
5   | pub mod dxdup;
    |         ^^^^^
    = note: the item is gated behind the `windows` feature

Is this currently expected?

I will look into this tonight!
Broadcasting only works on Windows today, but playback is portable. Thanks for trying and filing :)


Add an --api flag to generate project without view layer

Looks sensible. But I'm wondering if it's worth it to go a step further: Instead of having an --api flag that changes the generated project from web-only to api-only, having two flags that allow you to pick if you want the web and the api parts individually. Those could be something like --api and --no-web and you could have just api, just web, or both, choosing neither would error out with a helpful message.
I think that would nicely showcase router sections and separating things in the Raxx context.
Do you think that would be worth the work? Do you see anything that would make this hard to do?

I didn't really think about doing it that way. I was trying to optimise for the API only approach, I want to write an article about building API's.
It don't see any reason why it couldn't be done. There is a few things that might make it more work.
i.e. if you have both is the api namespaced under /api and not if only --api is chosen. Also you have the chose of splitting at the router level or alternatively starting two ace services on different ports one web one api

The reason why I'm suggesting that is because I feel like it would hit a very common use-case, where you want to make an API with a simple javascript-driven interface for it. I feel like it would make Raxx an even better platform for quickly build ing tech demos, for example.
With the "api or website" approach, if I was to make such a project, I'd probably have raxx_kit generate a website template for me (since it requires more work to set up on your own) and make the api part myself.

i.e. if you have both is the api namespaced under /api and not if only --api is chosen.

I think having those always namespaced wouldn't be the worst thing.

Also you have the chose of splitting at the router level or alternatively starting two ace services on different ports one web one api

I see what you mean. I think having one service on the same port would be easier to wrap one's head around, showcase sections and splitting stuff on the router level, and not make it seem like you need to work on two separate ports if you want to have a website and an api.
I don't know if you feel like that's idiomatic enough but I think both the service (What is now Demo.API or Demo.Web) and the router could both have consistent names outside of the namespaces, just inside lib/demo. You could argue that each of the "contexts" should have their own router the top-level one should just dispatch to, but it feels like kind of an advanced move and is something that's very easy to move to on your own if you do want to do it - for the freshly generated project I think one router with sections is plenty good.
Sorry if I'm more opinionated about it than I need to be, I'm just trying to put myself in the shoes of a potential user (which I think I will be soon, with some of my Hoplon experiments).

Sorry if I'm more opinionated about it than I need to be, I'm just trying to put myself in the shoes of a potential user (which I think I will be soon, with some of my Hoplon experiments).

No it all makes sense.
Though I'm wondering would you have one router. in which case it needs to live outside the API or WWW namespace?
Mulling, though I am tempted to release as is and open an issue to be able to use both at the same time. That would be useful for what I am playing with now and make the path forward clear

Though I'm wondering would you have one router. in which case it needs to live outside the API or WWW namespace?

Yes, that was my suggestion, for the ease of development of raxx_kit and the ease of onboarding to the new project, even if things are not as separated as they could have otherwise been. I like it as a compromise.
I'm definitely ok with releasing this as is, it just seemed like the amount of change to get there directly wasn't too much and changing the semantics of new flags so frequently wasn't necessary.

Decided to release as is, note on flag semantics I think that actually releasing as is and then upgrading can be done without any change to semantics.
If no flag given, it's equivalent to using --www (not that we have that option yet)
Using --api stays as it is.
In a follow up version it should be possible to use --www --api and get both parts of the scaffolding


Version requirement for Whoops as proposed in official docs.

Thanks for the PR @sdebacker :+1:

Thanks for the quick merge.


Change the rabit tracker config accordingly

To fix https://github.com/dmlc/xgboost/issues/9145

Should be to fix: https://github.com/dmlc/xgboost/issues/9145 instead of  https://github.com/NVIDIA/spark-rapids-ml/pull/263?

TEST PASS on NGC, +1


clockSkewInSec and loadDiscoveryDocumentAndLogin

Describe the bug
The default for angular-oauth2-oidc is a clock skew of 10 Minutes. I read all the other issues regarding clock skew and understand that this property is set to allow a user with an incorrect local clock to still use the token.
But the current implementation also uses hasValidAccessToken in loadDiscoveryAndLogin which means this function returns true even so I don't have a valid access token. If I then call eg. loadUserProfile I get an error because my access token is invalid.
I have setup the automatic token refresh but this only is trying to get a new access token after the previous call failed.
If I set the clockSkewInSec to 0 everything works but clients with a incorrectly clock could have problems.
Stackblitz example
none
Expected behavior
loadDiscoveryAndLogin refreshes the token before returning "authenticated"
Desktop (please complete the following information):

macOSX
Chrome
Version 119.0.6045.105

In 2022 the creator added the decreaseExpirationBySec property specifically to solve this problem (clockSkewInSec set to a number less than or equal to 0 and still taking into account possible incorrect client clock).
The whole discussion took place in issue #1135. More specifically, he proposes the change in this comment and says that it is implemented in this one.


This is for fixing the #185 in regards to the gitcoin bounty

fixes: https://github.com/tellor-io/telliot/issues/185
When changing from fmt.Pr and Logrus to the go-kit logger i tried to follow the flow (with minimal code change), in terms of editing comments and making code changes.
There was one fmt.Pr i did not change, it was in the cmd/telliot/cmd.go Run function (i think), because it seemed to actually want to print info about the programs version.
Also by the end of this i had an extra file, that i have no idea if it actually is part of the project, it seemed to appear after i pulled some changes to make sure my code was auto mergable.
I did not remove it (even tho i cant find it in your repo), because when i realised it seemed entierly new i had already editeded its fmt.Pr* and did not have the heart to potentially discard my extra work. File in question pkg/db/localDataProxy.go

Pull Request Test Coverage Report for Build 537212142

166 of 442 (37.56%)  changed or added relevant lines in 34 files are covered.
12 unchanged lines in 6 files lost coverage.
Overall coverage increased (+0.5%) to 38.692%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/ops/TxnSubmitter.go
0
1
0.0%

pkg/tracker/gas.go
2
3
66.67%

pkg/dataServer/dataServer.go
3
5
60.0%

pkg/ops/dataServerOps.go
11
13
84.62%

pkg/pow/miningGroup.go
13
16
81.25%

pkg/tracker/runner.go
3
6
50.0%

pkg/tracker/disputeChecker.go
8
12
66.67%

pkg/tracker/valueGenerators.go
8
12
66.67%

pkg/tracker/ampl.go
6
11
54.55%

pkg/tracker/psrs.go
9
14
64.29%

Files with Coverage Reduction
New Missed Lines
%

pkg/ops/miningManager.go
1
0%

pkg/ops/transferOps.go
1
0%

pkg/db/proxy.go
2
47.08%

pkg/ops/disputeOps.go
2
0%

pkg/rpc/mock.go
2
0%

pkg/tracker/psrs.go
4
83.22%

Totals

Change from base Build 534879226:
0.5%

Covered Lines:
1526

Relevant Lines:
3944

💛  - Coveralls


nsc-events-nextjs-fixing-responsive-UI-01

Resolves user story #413  and issue #414
This PR fixes the styling of the web application so it shows the hamburger menu when the window is shrunk to a smaller size. It also addresses the UI issue where contents in the screen were being cropped out by making the application responsive to changes in window size

Hi @Robel-003, the code looks good but I am wondering why didn't I see the update for the nav bar?

@heosman to speed this up for Monday do you want us to merge this to main and then you can apply your changes?
Or if you're around today @Robel-003 could you implement @heosman's idea and then let me know so I can review it and be at least one of the approvals for it? Just think this would be great to include in the demo tomorrow!

@heosman to speed this up for Monday do you want us to merge this to main and then you can apply your changes?
Or if you're around today @Robel-003 could you implement @heosman's idea and then let me know so I can review it and be the other approving review for this? Just think this would be great to include in the demo tomorrow!

@brinkbrink It'd be great if the changes to the hamburger nav bar in this PR could be merged but I'm not sure about the other changes as of right now, because it would change the appearance of the pages drastically. Of course if @Robel-003 has already been working on the changes I suggested, and would be able to have it ready to be merged before tomorrow, then it's not a problem.


Order change in "config" section to improve clarity ("code" at the end)

I moved the OSX/Linux checking "code" to the end of the configuration section; these are somewhat less likely to be changed than the other defaults.  I actually didn't notice the comments indicating the beginning and end of the config section for a bit; this change would have helped me ;) - another pull request coming shortly.

Hey Jomo! I actually meant for these to be separate pull requests, but didn't remember to branch - oops!  Feel free to cherry pick, or if you'd like me to split these off and re-request, I'll gladly do so.

You can just remove the commits from this branch:
git reset --hard 7f88ccad918144ad66bdbef3988bb4a32ade847e
git push -f


[New Snap] Sui by Solflare

Checklist
All items in the list below needs to be satisfied.

[ ] Is the Snap repository publicly accessible and linked in this ticket?
[x] Is the Snap distributed on npm and linked in this ticket? https://www.npmjs.com/package/@elli-wallet/sui-snap
[x] Has an audit been performed and the audit report attached or linked in this issue? https://github.com/MetaMask/snaps-registry/issues/114#issuecomment-1710931431
[x] Is a complete list of discovered vulnerabilities from the audit documented in this issue? https://github.com/MetaMask/snaps-registry/issues/114#issuecomment-1710935851
[ ] For vulnerabilities that have been deemed necessary to be addressed, are the links to the fixes attached to this issue?
[ ] For vulnerabilities that have been deemed not necessary to be addressed, is a reason for each of them documented in this issue?
[x] The corresponding pull request in this repo has been merged. https://github.com/MetaMask/snaps-registry/pull/76

https___s3-us-west-2.amazonaws.com_secure.notion-static.com_756f8728-8620-4dae-931c-f2d77192a530_solflare-wallet-snaps-audit-2023-08.pdf

Discovered vulnerabilities:

Dapp
May
Force
a
Sign
Approval
Dialog
Without
Showing
the
Message
to
Be
Signed
CtrlChar/Markdown
Injection in
renderSignTransaction, renderSignAllTransactions
Insufficient
Input
Validation
deriveKeyPair()
Dapp
May
Suppress
User Conirmation
on
Request
to Extract
Pubkey;
May
Extract
Any Net‐Key
Production
Builds
Allow Development
and
Localhost Origins;
Snap
Does
Not
Enforce Transport
Security
Misleading
HTML
Entity
and Function
Name getPrivkey
Use
of
Outdated snap.config.json Instead
of
snap.config.js
Inconsistent
or
Blank
Fields
in
package.json
Consider
Using @metamask/detect‐provider
Consider
Prefixing
RPC
Calls With
solana_* ,
 sui_* ,
aptos_*
Consider
Moving
to TypeScript

The following findings apply to the combined 3 snaps:

sollare‑snap@792fcb2a253c572677271044ece061daae81ce41
sui‑snap@39740383fd11174a406a1a27e15c92f277d00779
aptos‑snap@36145bb8f4963eb02cff26a549ac348a34d8cb3

List of findings:
4.1 Dapp May Force a Sign Approval Dialog Without Showing the Message to Be Signed Major
Fixed in: https://github.com/solflare-wallet/sui-snap/commit/d28c4e3bd1f33fb6d38da28f62ff965e27aa9b17
4.2 CtrlChar/Markdown Injection in renderSignTransaction , renderSignAllTransactions Major
See above commit
4.3 Insufficient Input Validation deriveKeyPair() Medium
Fixed in https://github.com/solflare-wallet/sui-snap/commit/6996b9552105c0f5532891d65912e2845753d233
4.4 Dapp May Suppress User Confirmation on Request to Extract Pubkey; May Extract Any Net‑Key Medium
This is intentional by design.
4.5 Production Builds Allow Development and Localhost Origins; Snap Does Not Enforce Transport Security Medium
Since the Snap now requires confirmation for any signing, the risk of this issue is lower.
The rest of the issues cited in the audit report are minor and not required to be fixed.

4.6 Misleading HTML Entity and Function Name getPrivkey
4.7 Use of Outdated snap.config.json Instead of snap.config.js
4.8 Inconsistent or Blank Fields in package.json
4.9 Consider Using @metamask/detect‑provider
4.10 Consider Preixing RPC Calls With solana_* , sui_* , aptos_*
4.11 Consider Moving to TypeScript

Repository: https://github.com/solflare-wallet/sui-snap


Add documentation to dataflowlib

dataflowlib was missing a package doc and so was the Execute method, setting off my linter.
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.