Updating Selection from Another View

How I can updated selected State if I'm navigating to view (presented TabBar), but not from TabBar, like from button inside of another  view, or using NavigationLink in another view.
Thank you
View with TabBar
struct GeneralView View {

    enum Item: Int, Tabbable {
        case home = 0
        case letters
        case heritage
        case bookmarks
        case third

        var icon: String {
            switch self {
                case .letters: return "textformat"
                case .heritage: return "command"
                case .home: return "house.fill"
                case .third: return "quote.bubble"
                case .bookmarks: return "bookmark.fill"

            }
        }

        var title: String {
            switch self {
                case .letters: return "Letters"
                case .heritage: return "Heritage"
                case .home: return "Arageel"
                case .third: return "Third"
                case .bookmarks: return "Bookmarks"

            }
        }
    }

    @State private var selection: Item = .home
    @State private var visibility: TabBarVisibility = .visible

    var body: some View {

        TabBar(selection: $selection, visibility: $visibility) {
            LettersGridView()
                .tabItem(for: Item.letters)

            HeritageZineHomeView()
                .environmentObject(RSSReader())
                .tabItem(for: Item.heritage)
            HomeView()
                .tabItem(for: Item.home)
            PBHomeView()
                .tabItem(for: Item.third)

            PBHomeView()
                .tabItem(for: Item.bookmarks)
        }
        .tabBar(style: CustomTabBarStyle())
        .tabItem(style: CustomTabItemStyle())
        .ignoresSafeArea(.all)
    }
}

Another View
    var stickyHeaderView: some View {
        HStack {
            Text("Heritage").modifier(MainStoryTitle(color: "BlackDark"))
            Spacer()
            NavigationLink (
                destination:
                    HeritageHomeView()
            ) {
                Image(systemName: "arrow.up.forward")
                    .foregroundColor(Color("Orange"))
            }
        }
        .padding(.horizontal, 30)

    }

Use a @Binding var selection: Item in Another View and pass it $selection. This will allow you to update the state.

Reci

Use a @Binding var selection: Item in Another View and pass it $selection. This will allow you to update the state.

Receiving error
Type 'Binding<Item>' has no member 'home'


update readme

With pull requests:

Open your pull request against main
Your pull request should have no more than two commits, if not you should squash them.
You should pass all tests by go test -v ./... at the project root path in local.
It should pass all tests in the available continuous integration systems such as GitHub Actions.
You should add/modify tests to cover your proposed code changes.
If your pull request contains a new feature, please document it on the README.

Codecov Report

Merging #106 (98c6b52) into main (d68065c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   24.05%   24.05%
=======================================
  Files          15       15
  Lines         636      636
=======================================
  Hits          153      153
  Misses        467      467
  Partials       16       16

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


update hydra parser

the hydra, john, and john show parser need to be updated to make them compatible again.

the hydra parser has been updated

the John the Ripper parser has been updated with commit 7c7c31e

updated john show parser with commit 2166535

all parsers updated


Fixing clang compiler warnings.

Just a few small changes to silence warnings when compiling in Xcode 7.3.1 (llvm 7.3.0).
Note that I'm also using the freetype2 font support, hence the additional #ifdef to silence unused function warnings.

Thanks for the fixes!

Thanks for accepting them :-)


Support variable intersections

I just want to mention one more example here, which requires Union and Intersection, which is when the number of things intersected is variable. This can happen when TypeVarTuple are involved, and it kind of implies that a speccing of empty unions and empty intersections is necessary. (See https://github.com/python/typing/issues/1362)
from typing import TypeVarTuple, Union

items = TypeVarTuple("items")
protocols = TypeVarTuple("protocols")   # something like tuple[type[Protocol], ...]

def pick_random_element(tup: tuple[*items]) -> Union[*items]: ...
    """Return random element form a tuple."""
    # if tuple is empty, raises an exception ⟺ return `Never`.

def create_intersection_protocol(tuple: tuple[*protocols]) -> type[Intersection[*Protocols]]: ...
    """Creates the intersection of pairwise disjoint protocol classes."""
    # if intersection is empty, returns a protocol that matches with any class.

EMPTY_TUPLE = ()
pick_random_element(EMPTY_TUPLE)  # should reveal as `Never`.
create_intersection_protocol(EMPTY_TUPLE)  # should reveal as `object`!?

Note that bounds are (not yet) supperted by TypeVarTuple, so the latter cannot be hinted properly right now.
Originally posted by @randolf-scholz in https://github.com/CarliJoy/intersection_examples/issues/12#issuecomment-1665869505

(My mistake in creating this issue.)


[PDI-19980] Added sorting and default buttons to File Open/Save

:white_check_mark: Build finished in 12m 54s
Build command:
mvn clean verify -B -e -Daudit -amd -pl \
plugins/file-open-save-new/core

:ok_hand: All tests passed!
Tests run: 38, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message


[BEAM-11833] Fix reported watermark after restriction split in UnboundedSourceAsSDFRestrictionTracker

The watemark reported by reader in trySplit needs to be stored and reported after call to trySplit.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @lukecwik

Hi Jan,
From your changes it seems like you want to have EmptyUnboundedSource.EmptyUnboundedReader reports last watermark instead of BoundedWindow.TIMESTAMP_MAX_VALUE. But it's intended to have EmptyUnboundedSource.EmptyUnboundedReader to report BoundedWindow.TIMESTAMP_MAX_VALUE as watermark to mark current restriction has finished processing and should not hold watermark back.
I checked discussion thread: https://lists.apache.org/thread.html/r3873ed7e3927c6fc81f6793af779e28cea9bc8f674ec89a7709bde31%40<user.beam.apache.org>  and in your last comment you are saying that The problem is that under heavy load (i.e. when the UnboundedReader reads data without ever returning false in response to advance()) the watermark is not progressed correctly.. Would you like to elaborate more on the relationship between this comment and this PR?

Hi Jan,
You are right that that UnboundedSourceAsSDFWrapperDoFn doesn't update watermark correctly while tryClaim() is called. I think we should fix UnboundedSourceAsSDFWrapperDoFn instead of EmptyUnboundedSource.EmptyUnboundedReader. Here is my one line fix which does the same thing as yours: https://github.com/apache/beam/pull/14020. I really like your test so would you like to consider patching my fix into your PR?

Hi Boyuan,
I think that it is incorrect to call tracker.currentRestriction().getWatermark() when tryClaim returns false. The returned value of BoundedWindow.TIMESTAMP_MAX_VALUE seems not to be the actual watermark. Why would we want to feed this value into the watermark estimator?
Regarding the hold - if we set the hold to TIMESTAMP_MAX_VALUE after restriction split, that could cause the output watermark to skip past the watermark of the residual restriction (watermark of the remaining data in the reader), which seems incorrect. That could cause emitting late data even though the reader's watermark is correct. Am I missing something?

Hi Boyuan,
I think that it is incorrect to call tracker.currentRestriction().getWatermark() when tryClaim returns false. The returned value of BoundedWindow.TIMESTAMP_MAX_VALUE seems not to be the actual watermark. Why would we want to feed this value into the watermark estimator?
Regarding the hold - if we set the hold to TIMESTAMP_MAX_VALUE after restriction split, that could cause the output watermark to skip past the watermark of the residual restriction (watermark of the remaining data in the reader), which seems incorrect. That could cause emitting late data even though the reader's watermark is correct. Am I missing something?

The reason why we want call watermarkEstimator.setWatermark(currentRestriction.getWatermark()); when tryClaim() returns false is for tracking watermark when returning ProcessContinuation.resume(). It could happen when there is no output records from reader and we want to read again later.

The reason why we want to call watermarkEstimator.setWatermark(currentRestriction.getWatermark()); when tryClaim() returns false is for tracking watermark when returning ProcessContinuation.resume(). It could happen when there is no output records from reader and we want to read again later.

That seems incorrect. When tryClaim returns false, it is part of the contract to return ProcessContinuation.done():
https://github.com/apache/beam/blob/aaad864c9acb22e35050f974a7ac74fb7638f085/runners/core-java/src/main/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvoker.java#L221
When the reader returns false() we do not fail clam, instead we go though out[0] == null in processElement.
I think there should be no reason to enforce:
a) returning ProcessContinuation.done(), and
b) manually setting the watermark to BoundedWindow.TIMESTAMP_MAX_VALUE
because, that seems redundant.
You are right, that the watermark is read before call to trySplit (I overlooked that), that probably means, we must set watermark both before and after the tryClaim loop.

Commit https://github.com/apache/beam/pull/14013/commits/000726ebfae521c8078c0ed2fb7c2945412ca735 should fix for that

Run Java PreCommit

The reason why we want to call watermarkEstimator.setWatermark(currentRestriction.getWatermark()); when tryClaim() returns false is for tracking watermark when returning ProcessContinuation.resume(). It could happen when there is no output records from reader and we want to read again later.

That seems incorrect. When tryClaim returns false, it is part of the contract to return ProcessContinuation.done():
https://github.com/apache/beam/blob/aaad864c9acb22e35050f974a7ac74fb7638f085/runners/core-java/src/main/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvoker.java#L221
When the reader returns false() we do not fail clam, instead we go though out[0] == null in processElement.
I think there should be no reason to enforce:
a) returning ProcessContinuation.done(), and
b) manually setting the watermark to BoundedWindow.TIMESTAMP_MAX_VALUE
because, that seems redundant.
Thanks, Jan! I think the unbounded wrapper does some hacks there but I'll double check. It would be great if we could change the implementation into a better one.

You are right, that the watermark is read before call to trySplit (I overlooked that), that probably means, we must set watermark both before and after the tryClaim loop.
I'm afraid that setting watermark both before and after the tryClaim loop is still not enough. For most cases, every time tryClaim is called and there is one output record, the watermark should advance. If we only set watermark outside of tryClaim loop, we will still hold back the watermark somehow.

cc: @y1chi fyi

I'm afraid that setting watermark both before and after the tryClaim loop is still not enough. For most cases, every time tryClaim is called and there is one output record, the watermark should advance. If we only set watermark outside of tryClaim loop, we will still hold back the watermark somehow.

Alright, that is true. I'd suggest we add watermark into the UnboundedSourceValue, I'd prefer to avoid materializing the currentRestriction() in the tryClaim loop. WDYT?

I'm afraid that setting watermark both before and after the tryClaim loop is still not enough. For most cases, every time tryClaim is called and there is one output record, the watermark should advance. If we only set watermark outside of tryClaim loop, we will still hold back the watermark somehow.

Alright, that is true. I'd suggest we add watermark into the UnboundedSourceValue, I'd prefer to avoid materializing the currentRestriction() in the tryClaim loop. WDYT?

That sounds good to me. Would you like to make the change in this PR together? Meanwhile I'll double check the implementation to ensure we don't introduce additional bugs.

Yes, I'll do the change.

@boyuanzz I have adjust the PR.

@boyuanzz I have adjusted the PR.

Thanks for the quick fix! I'll take a look later today.

I read through this PR and it is annoying that we expose an implementation detail about trySplit needing to have the watermark updated before trySplit happens. This is likely to happen in user's SplittableDoFn implementations that they need to be aware that the watermark needs to be constantly updated.
I have a minor code layout improvement in https://github.com/apache/beam/pull/15022


No such file or directory verbs.txt

Hey
bundle exec rubocop -D -E --format=html -o tmp/rubocop.html --format=progress app/ lib/
No such file or directory @ rb_sysopen - /usr/local/bundle/ruby/3.2.0/gems/rubocop-obsession-0.1.5/lib/rubocop/cop/mixin/files/verbs.txt
/usr/local/bundle/ruby/3.2.0/gems/rubocop-obsession-0.1.5/lib/rubocop/cop/mixin/helpers.rb:6:in `read'
/usr/local/bundle/ruby/3.2.0/gems/rubocop-obsession-0.1.5/lib/rubocop/cop/mixin/helpers.rb:6:in `<module:Helpers>'
/usr/local/bundle/ruby/3.2.0/gems/rubocop-obsession-0.1.5/lib/rubocop/cop/mixin/helpers.rb:5:in `<module:Cop>'

Would you mind sharing the output of bundle env?

Hey
this issue occurs on our CI (gitlab)
here is bundle env
$ bundle env
## Environment
Bundler       2.4.10
  Platforms   ruby, x86_64-linux
Ruby          3.2.6p2[34](https://REDACTED) (2024-10-30 revision 63aeb018eb1cc0f7b00f955980711fd1bd94af7f) [x86_64-linux]
  Full Path   /usr/local/bin/ruby
  Config Dir  /usr/local/etc
RubyGems      3.4.19
  Gem Home    /usr/local/bundle
  Gem Path    /home/REDACTED/.local/share/gem/ruby/3.2.0:/usr/local/lib/ruby/gems/3.2.0:/usr/local/bundle
  User Home   /home/REDACTED
  User Path   /home/REDACTED/.local/share/gem/ruby/3.2.0
  Bin Dir     /usr/local/bundle/bin
Tools
  Git         2.30.2
  RVM         not installed
  rbenv       not installed
  chruby      not installed
## Bundler Build Metadata
Built At          2023-03-27
Git SHA           7ffdec80d0
Released Version  true

Bundler settings
app_config
  Set via BUNDLE_APP_CONFIG: "/usr/local/bundle"
gemfile
  Set via BUNDLE_GEMFILE: "/REDACTED/Gemfile"
jobs
  Set for your local app (/usr/local/bundle/config): 16
path
  Set via BUNDLE_PATH: "/usr/local/bundle"
silence_root_warning
  Set via BUNDLE_SILENCE_ROOT_WARNING: true
system
  Set for your local app (/usr/local/bundle/config): "true"
without
  Set for your local app (/usr/local/bundle/config): [:development, :guard]

Gemfile
Gemfile
source 'https://rubygems.org'/
gem 'rails', '~> 7'
....

Thanks, I'm guessing this is the bundle env info for your CI env, not your local right? This way I can try to repro closest to the CI setup.

right, this output from CI, yes

I wasn't able to repro (see details below) but maybe we can work around the issue. Maybe loading a file in a constant is not very kosher, so I made this branch https://github.com/jeromedalbert/rubocop-obsession/tree/verbs-tentative-fix that lazy loads the verbs in file https://github.com/jeromedalbert/rubocop-obsession/commit/79be20092796ba0a7c0f93a81fc102438b9f587a.
@slayer Could you:

Try this branch on your CI with something like this:
gem 'rubocop-obsession',
    require: false,
    github: 'jeromedalbert/rubocop-obsession',
    branch: 'verbs-tentative-fix'

If it still doesn't work and you get the same error, could you continue using that branch and disable cops that check verbs in your .rubocop.yml like so:
Obsession/Rails/ServiceName:
  Enabled: false
Obsession/Graphql/MutationName:
  Enabled: false

Hopefully 1 just works, otherwise you could do 2 which wouldn't be ideal but at least you'd be able to use the other cops like `MethodOrder` and the like.

---

Non-repro details:

I spun up a Docker container with a similar setup as your `bundle env`, with a 7.2 Rails app with Ruby 3.2.6 and Bundler 2.4.10. Then I ran `bundle exec rubocop -D -E --format=html -o tmp/rubocop.html --format=progress app/ lib/`, with or without `RAILS_ENV=test` and `CI=true` (which eager loads the app in default Rails setups):

- I was not able to repro inside the container
- In the container, doing `cat /usr/local/bundle/ruby/3.2.0/gems/rubocop-obsession-0.1.5/lib/rubocop/cop/mixin/files/verbs.txt` displays the file content for me, so that file exists

Otherwise the only thing left this point would be for you to make a [minimal example app](https://www.codetriage.com/example_app#how-to-make-an-example-app) that would reproduce the problem, although it would be hard for you to do since it would probably work for you on your local and not in production. And even then I might still not repro because your CI maybe does things differently.

Wondering if your CI somehow deletes txt files when installing gems, although that seems unlikely.

it turned out that this was exactly the reason.
the piece from our Dockerfile:
  bundle install -j 16 && \
    ( cd ${BUNDLE_PATH} && \
      find . -name *.so | xargs strip && \
      find . -regex ".*\.\(gem\|h\|c\|o\|a\|md\|txt\|rdoc\|o\|pdf\)" | xargs rm && \
      find . -type d -a -regex "^.*/\(tmp\|docs\|benchmark\|spec\|samples\)$" | egrep -v "(rack/test|http/features)" | xargs rm -rf && \
      find . -type d -a -regex "^.*/\(FEATURES\|.travis.yml\)$" | xargs rm -rf )

sorry

Ok, the best fix is to change your CI, as it is not uncommon for gems to store data in txt files, for example PublicSuffix does it too: https://github.com/weppos/publicsuffix-ruby/blob/c84facf1d4a1dc5fff8a30447edf5242d6a6c903/data/list.txt.
On my end I released version 0.1.9 which lazy-loads the verbs file, because it it looked like best practice anyways.


Remove Jetty from azure-data-sdk-parent POM

As part of the POM restructuring work I found that we were running the jetty:run-forked goal against the azure-data-sdk-parent POM file to spin up a HTTP endpoint for recording playback. This worked because azure-data-sdk-parent lists all the modules for track one so it scoops up all the playback recordings for track one (currently only KeyVault, EventGrid and Batch have jetty-hosted recordings).
The Jetty step is quite flakey in our pipelines and generally we want our parents not to be used for any kind of aggregation. So in order to resolve this I want to remove all the Jetty dependencies & configuration from the azure-data-sdk-parent and put it just in the libraries that use it. Then attach the Jetty start-up and shutdown to lifecycle events for just those specific modules.
This issue tracks that work.
By doing this we'll be able to move forward with the second phase of POM restructuring.

This PR will solve this issue: https://github.com/Azure/azure-sdk-for-java/pull/9660


Movement system refactor

To make walking/movement look natural and not weird as it does now:
Pathfinding logic from https://github.com/Mrnice98/Companion-Pets-Plugin/blob/master/src/main/java/com/example/PathingLogic.java
Change our moveTo method to be like the one in this plugin too^
Ensure wanderingcitizens cannot walk through/on obstacles

would love to see animation smoothing and more natural movement as well.


adds hadUpdateAttempt flag to models

This PR adds hadUpdateAttempt to models which is useful when user updates the model but the model is not dirty.
The provided tests should explain the idea and show the difference done with this simple change.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


ng new create project in different path in OSX

Please provide us with the following information:

OS?  Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
OSX

Versions. Please run ng --version. If there's nothing outputted, please run
in a Terminal: node --version and paste the result here:

angular-cli: 0.0.39
node: 5.1.0
os: darwin x64

Repro steps. Was this an app that wasn't created using the CLI? What change did you
do on your code? etc.

hello , ng new dont generate in the same folder in same folder its generate it on my home user directory
so i am in this path :
/Users/alawialbaiti/projects/
and type : ng new myapp
i found the project generated in this place :
/Users/alawialbaiti/myapp

The log given by the failure. Normally this include a stack trace and some
more information.
none

Mention any other details that might be useful.

Thanks! We'll be in touch soon.

@tmleeek perhaps you could try once more creating a new project under the /Users/alawialbaiti/projects/ directory. I just tried to reproduce the issue you've described and was unsuccessful. I must mention that I ran npm install -g angular-cli first to get a fresh install.
My versions are listed here:
angular-cli: 1.0.0-beta.12-1
node: 4.4.5
os: darwin x64

I have done install -g with SUDO , i have try now to recreate the project but the problem still exist even that i am in other folder
Alawis-MacBook-Pro:Desktop alawialbiti$ cd demo
Alawis-MacBook-Pro:demo alawialbiti$ ls
1.mp4	2.mp4	3.mp4
Alawis-MacBook-Pro:demo alawialbiti$ ng new HelloWorld
Could not start watchman; falling back to NodeWatcher for file system events.
Visit http://ember-cli.com/user-guide/#watchman for more info.
Directory 'HelloWorld' already exists.
Alawis-MacBook-Pro:demo alawialbiti$ mkdir hope
Alawis-MacBook-Pro:demo alawialbiti$ ls
1.mp4	2.mp4	3.mp4	hope
Alawis-MacBook-Pro:demo alawialbiti$

Can you run ls on your Desktop and paste the results here? I've been working with the latest build all evening and have not had any directory issues.

sure
Alawis-MacBook-Pro:Desktop alawialbiti$ ls
56923 Yoga.pdf alawi test demo ionic-1.3.1
Alawis-MacBook-Pro:Desktop alawialbiti$
On Thu, Sep 15, 2016 at 7:48 AM, Jason Hodges<EMAIL_ADDRESS>wrote:

Can you run ls on your Desktop and paste the results here? I've been
working with the latest build all evening and have not had any directory
issues.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/angular/angular-cli/issues/2120#issuecomment-247233965,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AByrMP0WuMdc8n2YNwqrP61eBJqhlfn8ks5qqM4igaJpZM4J9VU5
.

Try running npm install -g angular-cli without using sudo
After that is complete, if you don't receive errors during the install, paste your versions here once more.
Also, what version of OSX are you running?

i tried without sudo but its full of errors
i use OSX 10.11.6 (15G1004)
On Thu, Sep 15, 2016 at 8:22 AM, Jason Hodges<EMAIL_ADDRESS>wrote:

Try running npm install -g angular-cli without using sudo
After that is complete, if you don't receive errors during the install,
paste your versions here once more.
Also, what version of OSX are you running?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/angular/angular-cli/issues/2120#issuecomment-247237507,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AByrMPWKD6hV7bGx8QhtKixv6i0d5DLGks5qqNX8gaJpZM4J9VU5
.

i forget to attach image of installing without sudo with npm log

npm-debug.txt

i want just to inform me that i have installed the lateset angular-cli and
angular 2 and still keep getting the same problem ..
On Thu, Sep 15, 2016 at 8:31 AM, علوي<EMAIL_ADDRESS>wrote:

i tried without sudo but its full of errors
i use OSX 10.11.6 (15G1004)
On Thu, Sep 15, 2016 at 8:22 AM, Jason Hodges<EMAIL_ADDRESS>wrote:

Try running npm install -g angular-cli without using sudo
After that is complete, if you don't receive errors during the install,
paste your versions here once more.
Also, what version of OSX are you running?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/angular/angular-cli/issues/2120#issuecomment-247237507,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AByrMPWKD6hV7bGx8QhtKixv6i0d5DLGks5qqNX8gaJpZM4J9VU5
.

I think your issue is a dupe of https://github.com/angular/angular-cli/issues/1133, can you check that solution?

wow thats really was the solution thanks @filipesilva
i was not know this could happen from package.json file .


Fix dependency tree of gradle outputs

should fix class not found issue during the build

Codecov Report

Merging #21513 into master will decrease coverage by 4.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21513      +/-   ##
==========================================
- Coverage   19.17%   14.72%   -4.46%
==========================================
  Files          56       51       -5
  Lines        1528     1399     -129
  Branches      233      214      -19
==========================================
- Hits          293      206      -87
+ Misses       1219     1177      -42
  Partials       16       16

Impacted Files
Coverage Δ

composer/packages/tracing/src/ToolBar.tsx

composer/packages/tracing/src/TraceList.tsx

composer/packages/tracing/src/DetailView.tsx

composer/packages/tracing/src/TraceLogs.tsx

composer/packages/tracing/src/index.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f621ee...553e4a2. Read the comment docs.


modify ci

Codecov Report

Merging #62 (2185bdd) into master (b03aecb) will decrease coverage by 1.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   91.36%   89.86%   -1.50%
==========================================
  Files          13       13
  Lines         498      602     +104
==========================================
+ Hits          455      541      +86
- Misses         22       40      +18
  Partials       21       21

Impacted Files
Coverage Δ

tree_mkdir.go
63.63% <0.00%> (-6.74%)
:arrow_down:

tree_handler.go
70.00% <0.00%> (-5.00%)
:arrow_down:

node_generate.go
90.32% <0.00%> (-1.99%)
:arrow_down:

node_generate_strategy.go
89.83% <0.00%> (-1.84%)
:arrow_down:

tree_handler_programmable.go
85.48% <0.00%> (-1.76%)
:arrow_down:

tree_spread.go
87.40% <0.00%> (-1.49%)
:arrow_down:

config.go
92.53% <0.00%> (-0.32%)
:arrow_down:

node.go
100.00% <0.00%> (ø)

tree.go
100.00% <0.00%> (ø)

counter.go
100.00% <0.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b03aecb...2185bdd. Read the comment docs.


Duplicate code in ConvHipImplicitGemmWrwV4R4Xdlops::IsApplicable

Duplicate code
Originally posted by @atamazov in https://github.com/ROCmSoftwarePlatform/MIOpen/pull/553#r750235273

@atamazov @junliume Fixed in https://github.com/ROCmSoftwarePlatform/MIOpen/pull/1811


Revert with automatically generated message is treated as a fix

I'd say it's alright – if it's reverted, then it's like it never existed, so there is nothing to fix
The old app worked the same way


Is there a way to make Composable view always above the SwingPanel?

Is there a way to make Composable view always above the SwingPanel? I'm working on a 3D application which using Swing Canvas to draw the 3D, but all the Composable view is covered by the Swing Canvas.

@llhbadboy I'm tracking the progress regarding this feature (have added a similar issue). As I understand it will be implemented in the 1.1.0 milestone (ongoing).

@yaroslavkulinich Thanks for telling me that.
And do you know when the 1.1.0 milestone will be released？

It's not fixed in the 1.1.0 release.

Have you checked swing tutorials? I guess they cover most of the use cases

@llhbadboy
It was fixed in 1.1.0.
Check Swing Interop tutorial.

@yaroslavkulinich @akurasov
Thank you, guys.
But I think the tutorial just let me not use the SwingPanel at this situation. My case is using Tooltips, and it cut off by the SwingPanel.
Quote the Swing Interop tutorial:
Below you can find several cases where the use of SwingPanel is justified:
there are no popups, tooltips, context menus, etc. in your application. or they are not used inside your SwingPanel
in your application, the SwingPanel will always be in the same position. This will reduce the risk of glitches and artifacts when changing the position of the Swing component (this condition is not mandatory and you need to test each such case separately)

@llhbadboy it is restriction of the architecture and it doesn't seem feasible to change. At least I don't see how. If, looking at explanation, you have any ideas, please share them.

+1, is there any workaround for this right now? I've tried to put a DropdownMenu within a ComposePanel within a SwingPanel and it doesn't work.

Fixed in https://github.com/JetBrains/compose-multiplatform-core/pull/915 (under the flag).
Please note that drawing above GPU views has a bit more limitations because it requires blending on OS side that might not be supported in some cases

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Final updates

Codecov Report

Merging #218 (6909910) into master (cadd29e) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #218      +/-   ##
============================================
+ Coverage     79.13%   79.19%   +0.06%
  Complexity      974      974
============================================
  Files           132      132
  Lines          2885     2894       +9
  Branches        360      360
============================================
+ Hits           2283     2292       +9
  Misses          531      531
  Partials         71       71

Impacted Files
Coverage Δ

...ava/seedu/address/logic/commands/ClearCommand.java
100.00% <ø> (ø)

...dress/model/tag/TagsContainsKeywordsPredicate.java
100.00% <ø> (ø)

...dress/logic/parser/FilterCurrModCommandParser.java
100.00% <100.00%> (ø)

...dress/logic/parser/FilterPlanModCommandParser.java
100.00% <100.00%> (ø)

...dress/logic/parser/FilterPrevModCommandParser.java
100.00% <100.00%> (ø)

...model/module/CurrModContainsKeywordsPredicate.java
100.00% <100.00%> (ø)

...model/module/PlanModContainsKeywordsPredicate.java
100.00% <100.00%> (ø)

...model/module/PrevModContainsKeywordsPredicate.java
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[FLINK-10377] Remove precondition in TwoPhaseCommitSinkFunction.notif…

…yCheckpointComplete
What is the purpose of the change
The precondition checkState(pendingTransactionIterator.hasNext(), "checkpoint completed, but no transaction pending"); in TwoPhaseCommitSinkFunction.notifyCheckpointComplete() seems too strict, because checkpoints can overtake checkpoints and will fail the precondition. In this case the commit was already performed by the first notification and subsumes the late checkpoint. I think the check can be removed.
Brief change log
Removed the precondition without replacements and created a test case for ou-of-order notification.
Verifying this change
TwoPhaseCommitSinkFunctionTest#testSubsumedNotificationOfPreviousCheckpoint
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

CC @pnowojski

Travis passed except of an unrelated python failure. Merging.


Adding ALENextError which would ignore warnings

Would it be possible to append a command ALENextError which would do just as ALENext but ignoring warnings.
I think it can be really interesting when editing big old file from someone else with a lot of bad style practices.
For exemple I have some python files thousands lines longs, full of bad spaces and visual indentations that make flake8 crying. I have ~500 warnings for only 4 errors (which are just variable not use probably) and I do not want to fix every style problem but I would like to fix these errors but it is pretty hard to find them here.
By the way I think if you had to fix an old file you would always start fixing errors before warnings.

I decided to give it a try. It works fine though I have to write tests I guess.


Resizing with useResizeColumns can trigger sorting when use with useSortBy

Describe the bug (required)
Mouse events on resize objects propagate upwards to the containing elements, meaning they can trigger sort events also attached to header cells.
Provide an example via Codesandbox! (required)
https://codesandbox.io/s/amazing-dream-x4iyw
Steps To Reproduce (required)
Steps to reproduce the behavior:

Resize "First Name" column.
note the column sorting changes

Expected behavior (Recommended)
mouseDown events captured in the resize object props should call stopPropagation so the sorting (and other) props can be attached to the resize parent elements without triggered on resize.

@krashdifferent The getResizerProps() prop getter only returns onMouseDown and onTouchStart. To fix this issue, an onClick would also have to stop the propagation (I know that that's what you probably meant by saying 'mousDown events', just wanted to clarify).

Does anyone know a workaround for this? :)

i moved out the resizer out of the cell as a quick fix.  https://codesandbox.io/s/brave-sanne-6o1mg

Another simple work around, add an onClick handler to the resizer that calls stopPropagation:

Or even: Place the sortBy props on the text, not the entire cell.

I submitted a fix for this here. https://github.com/TanStack/table/pull/4494

Another simple work around, add an onClick handler to the resizer that calls stopPropagation:

I don't think this will work since the event is coming from the document when the resizer is released so it hits the th element before it reaches the resizer.


Snapshot test fails after upgrading to Node 6.5.0

Do you want to request a feature or report a bug?
Bug report
What is the current behavior?
After upgrading to Node 6.5.0 I started facing issues with anonymous function value
    - Snapshot
    + Received

      <div
        aria-label="Title"
        className="grommetux-box grommetux-box--direction-row grommetux-box--align-center grommetux-box--pad-none grommetux-box--clickable grommetux-title grommetux-title--responsive grommetux-title--interactive"
        id={undefined}
    -   onClick={[Function anonymous]}
    +   onClick={[Function mockConstructor]}
        role="link"
        style={Object {}}
        tabIndex={0}>
        <span>
          Testing
        </span>
      </div>

What is the expected behavior?
I'm not sure what the expected behavior should be. I could easily run jest -u but I don't think that's the fix here.
I believe that the snapshot value should be less sensitive to Function types, maybe something like this is sufficient:
onClick={[Function]}

but I've seen cases with bound and the actual function name, which I'm not sure that it should be removed.
onMouseMove={[Function bound _onMouseMove]}

what node version did you upgrade from?

From 6.1.0

Yes this is expected. Node 6.5 and its v8 version are smarter at detecting function names.
For example:
const obj = {
  apple: () => {}
};

obj.apple.name might be apple. Update your snapshots and you are good to go!
In the future, updates to node or Jest may require you to update your snapshots. This is expected.

Well, what about all other developers using other versions of Node?
Their snapshots will fail, and I can't just ask them to update to the latest Node.
It would be great if Jest would be more agnostic to this, right? I may be missing something here.

I can update my code to avoid using anonymous functions, but this feels like limiting to me.

Yeah I'd recommend explicitly giving these functions a name. Unfortunately I don't have a good answer for this – we'd like the function names to be in the snapshot because it could be an unexpected change.
I understand that this is unfortunate but I believe these changes are happening rarely enough on the engine level that it isn't gonna be a huge issue going forward. Node 6 is going to be an LTS release soon and it can be made a minimum requirement.

I'm fine with that. thanks for following up

Actually the anonymous is returned by jest.fn(), this is my declaration:
const onAnchorClick = jest.fn();
Any idea how to avoid this issue given that declaration?

This is how I did it:
const onAnchorClick = () => {};
jest.fn(onAnchorClick);

it would be nice if jest.fn can detect function names by the variable declaration.


Add Azure OpenAI structured outputs support

As mentioned in https://github.com/langchain4j/langchain4j/pull/1982#issuecomment-2553095472
I added a complete test, maybe it's a bit too much, then I like to have this as some kind of example on how to use the code.

I have also added supportedCapabilities, users might want to set it to be able to use structured outputs with Azure chat models in AI Service


disable power key

I'm not a programmer and I know nothing about programming. All I want is to disable the damn Macbook power button. Can anyone help me create a rule so I can import it? It is so frustrating that I cannot create a rule locally.

Nope, you can't. The Power button coupled tightly with the hardware and cannot be remapped.


arangodb windows service

i use ArangoDB 2.8 and installed in windows server 2008 its worked well but suddenly the arangodb windows service is Stopped . i don't now what is the problem but its a big problem because the all the client side is crashed
please help me Necessary

Hi Mohamed, did you try to start arangod.exe from a command prompt to see what is in the output? Often this will give you a hint of what is wrong.

@AmmarMohamed : is there anything obvious in the ArangoDB server's logfiles?

Hi @AmmarMohamed,
If the log doesn't contain any information, and restarting reproduces the issue could you send us a coredump?
Heres how to create it on windows:
https://github.com/arangodb/arangodb/blob/devel/README_maintainers.md#windows-debugging
Any particular reasons why you didn't follow to later ArangoDB reasons?

@AmmarMohamed any news on this issue? or can we close this?


chore: @typescript-eslint/explicit-module-boundary-types

Description
This fixes warnings of the @typescript-eslint/explicit-module-boundary-types rule that would be automatically enabled by using plugin:@typescript-eslint/recommended
Additional context
The first commit can easily be reviewed by someone from the team
It only explicitly set module boundary types for returning functions
The other three commits should get a look from @yyx990803! I explicitly split this PR into several commits, so a review can made a bit more easily
Maybe he has some ideas to improve these types
Why defining explicit-module-boundary-types and why it is recommended?

Explicit types for function return values and arguments makes it clear to any calling code what is the module boundary's input and output.

Or in my words: if there is e.g. an update in a typed dependency, you can easily find that there is a breaking change and fix it at compile time
Also for such a huge repo like vite, this is very recommended, cause contributors might change and e.g. return null somewhere in a function without checking upper functions that uses the function
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/explicit-module-boundary-types.md

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

I reverted 780af706514361af0dc73623d1a76524fa0a7284 because it starts to make too much trouble
Still, @yyx990803 should take a look to tackle it in the future

Damnd, this didn't worked 😖


Feature Request: Single Subscription for Small-Enterprise model

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description
Is your feature request related to a problem?
Yes.

Describe the solution you'd like
We have many customers who want the 'small enterprise' model whereby the Management, Connectivity and Identity subscription are all in one. This includes our small/mid-market customers.
Their I.T. is simply not that distributed or separated enough to warrant splitting this function up into three separate Subscriptions.
This is currently possible when using the Azure Landing Zone Accelerator Wizard. Under 'Azure Core Setup' you can select either 'Dedicated (recommended)' or 'Single'.
Please see here for more information: https://github.com/Azure/Enterprise-Scale/blob/main/docs/reference/treyresearch/README.md

Additional context
I've tried to find a decent way to do this with the Enterprise Scale Terraform Module. Hoping you have better insight and skills :-)

Hi @richardf5. This is interesting timing. Checkout this post from @jtracey93: https://www.linkedin.com/feed/update/urn:li:activity:7188826781729087488?updateEntityUrn=urn%3Ali%3Afs_feedUpdate%3A(V2%2Curn%3Ali%3Aactivity%3A7188826781729087488)
As it stands, we do support a single subscription. Just supply to same subscription id to all 3 subscription variables. But we may remove that option at a later date per the survey results that Jack posted.

Afternoon. Thank you for that! - I voted no for the simple reason that the three-subscription model is too complex for small I.T. teams. They don't tend to split these functions when it comes to responsibility.

As it stands, we do support a single subscription. Just supply to same subscription id to all 3 subscription variables. But we may remove that option at a later date per the survey results that Jack posted.

I did try that, but I ended up still with the three Management Groups and associated policy. The last Management Group contained my single subscription, but it:

Still had the Identity Management Group name.
Still had distributed policy across the three Management Groups.

Ideally, I'd like a Single Management Group called 'Platform' with all associated policy (that makes sense).
Thank you for all the work on this. It's a brilliant initiative.


Support dynamic spreads.

Especially when working with React passing dynamic props is desired, which is quite different from tink.Anon.merge that underpins hxx spreads. Syntax would be {...untyped <expr>}. Have to figure out what exactly to do regarding type checking. Probably should support a way to disallow it for specific tags (e.g. coconut views).

How about (top-down) typing the attributes without the dynamic spread first. Then just reuse that type for the post-spread object?
function dynamicSpread<T>(staticAttrs:T, dynamicAttrs:Any):T;


using fsdp2 wrapper Flux(text to image) model , gradient  is inconsistent with fsdp1

i use register_full_backward_hook print grad when backward like this way:
def print_grad_hook(name):
    def hook(module, grad_input, grad_output):
        print(f"Layer Name: {name},Grad input: {grad_input},Grad output: {grad_output}")
    return hook
for name, layer in model.named_children():
    layer.register_full_backward_hook(print_grad_hook(name))

but i discover last layer's grad is inconsistent between fsdp1 and fsdp2.（'Grad output ' is consistent）
fsdp1 grad:
Layer Name: proj_out,Grad input: (tensor([[[-1.4901e-08,  2.2445e-07,  5.4250e-08,   ...,  3.7812e-07,
           4.0606e-07, -3.8184e-07]]], device='cuda:0'),),Grad output: (tensor([[[-2.3991e-06,  2.3693e-06,  1.3947e-05,  ...,
           4.0233e-07,  8.0466e-07]]], device='cuda:0', dtype=torch.bfloat16),)

fsdp2 grad:
Layer Name: proj_out,Grad input: (tensor([[[-0.0000e+00,  2.3842e-07,  5.9605e-08,  ...,  8.9407e-07,
           4.1723e-07, -3.5763e-07]]], device='cuda:0'),),Grad output: (tensor([[[-2.3991e-06,  2.3693e-06,  1.3947e-05,  ...,
           4.0233e-07,  8.0466e-07]]], device='cuda:0', dtype=torch.bfloat16),)

Below is my code to wrapper flux model，Currently I'm not using compile and activation checkpointing
for layer_id, transformer_block in model.transformer_blocks.named_children():
        if pp_enabled:
            # For PP, do not reshard after forward to avoid per-microbatch
            # all-gathers, which can be expensive and non-overlapped
            reshard_after_forward = False
        else:
            # As an optimization, do not reshard after forward for the last
            # transformer block since FSDP would prefetch it immediately
            reshard_after_forward = True
        fully_shard(
            transformer_block,
            **fsdp_config,
            reshard_after_forward=reshard_after_forward,
        )
    for layer_id, transformer_block in model.single_transformer_blocks.named_children():
        if pp_enabled:
            # For PP, do not reshard after forward to avoid per-microbatch
            # all-gathers, which can be expensive and non-overlapped
            reshard_after_forward = False
        else:
            # As an optimization, do not reshard after forward for the last
            # transformer block since FSDP would prefetch it immediately
            reshard_after_forward = int(layer_id) < len(model.single_transformer_blocks) - 1
        fully_shard(
            transformer_block,
            **fsdp_config,
            reshard_after_forward=reshard_after_forward,
        )
    fully_shard(model, **fsdp_config, reshard_after_forward=not pp_enabled)

can you  give some advice，thanks

Hello, we tried to solve the issue.
This is what we did:
Update the apply_fsdp function to handle the last layer differently, ensuring consistent gradient behavior between FSDP1 and FSDP2.
You can review changes in this commit: https://github.com/kkpo4553/pytorch-torchtitan-734/commit/4c3e50d73b1a28c29258b5350f0e481ad84736de.

[!CAUTION]
Disclaimer: The concept of solution was created by AI and you should never copy paste this code before you check the correctness of generated code. Solution might not be complete, you should use this code as an inspiration only.

If you no longer want Latta AI to attempt solving issues on your repository, you can block this account.

Are you wrapping FSDP1 and FSDP2 in the exactly same way, and is there any parameter sharing for that last layer?

Are you wrapping FSDP1 and FSDP2 in the exactly same way, and is there any parameter sharing for that last layer?
yes，i am wrapping FSDP1 and FSDP2 in same way and not parameter sharing.
In fsdp2, there seems to be a vanishing gradient problem.（fsdp1.grad:left   fsdp2:right）

Are you wrapping FSDP1 and FSDP2 in the exactly same way, and is there any parameter sharing for that last layer?

yes，i am wrapping FSDP1 and FSDP2 in same way and not parameter sharing.
In fsdp2, there seems to be a vanishing gradient problem.（fsdp1.grad:left fsdp2:right）

Are you wrapping FSDP1 and FSDP2 in the exactly same way, and is there any parameter sharing for that last layer?

yes，i am wrapping FSDP1 and FSDP2 in same way and not parameter sharing.
In fsdp2, there seems to be a vanishing gradient problem.（fsdp1.grad:left fsdp2:right）

@yanmj0601 Do you have any repro for this that we can look into?

@yanmj0601 Do you have any repro for this that we can look into?

Thank you, this problem has been solved, mainly due to the conflict between mixed precision of fsdp2 and torch.amp.autocast. But I encountered another problem. During the process of aligning the accuracy, I found that when fsdp1 and fsdp2 called torch.nn.LayerNorm, fsdp1 return value is fp32 precision, but fsdp2 return value is fp16 precision. Where can I configure the return accuracy of layernorm in fsdp2?

@yanmj0601 Are you sure you are wrapping FSDP1 and FSDP2 in the same way then? FSDP1 does not have any mechanism to make layer norm return fp32. Perhaps, you are wrapping layer norms separately and using a different mixed precision config for it?
I need to clarify which of the following you want (possibly more than one):

Cast layer norm input from bf16 to fp32
Cast layer norm weight from bf16 to fp32
All-gather layer norm weight directly in fp32 (avoiding any cast from bf16 to fp32)
Cast layer norm output from bf16 to fp32

Depending on where the layer norms are in your in model, I would say that 4 may not make sense. For example, if you have layer norm before a linear and that linear runs in bf16, then you may as well return the layer norm in bf16 since it will need to be cast to bf16 for the linear anyway.
If you want 1 and 3, then you can apply fully_shard to the layer norm modules separately first, e.g. like here (except this example is for batch norm)::
https://github.com/pytorch/pytorch/blob/ea0f60ecfabe0501485015841c4176d5a09c8247/test/distributed/_composable/fsdp/test_fully_shard_mixed_precision.py#L543-L549
FSDP2's MixedPrecisionPolicy supports an optional output_dtype that you can use to cast your layer norm output back to bf16 if needed.

@yanmj0601 Are you sure you are wrapping FSDP1 and FSDP2 in the same way then? FSDP1 does not have any mechanism to make layer norm return fp32. Perhaps, you are wrapping layer norms separately and using a different mixed precision config for it?
I need to clarify which of the following you want (possibly more than one):

Cast layer norm input from bf16 to fp32
Cast layer norm weight from bf16 to fp32
All-gather layer norm weight directly in fp32 (avoiding any cast from bf16 to fp32)
Cast layer norm output from bf16 to fp32

Depending on where the layer norms are in your in model, I would say that 4 may not make sense. For example, if you have layer norm before a linear and that linear runs in bf16, then you may as well return the layer norm in bf16 since it will need to be cast to bf16 for the linear anyway.
If you want 1 and 3, then you can apply fully_shard to the layer norm modules separately first, e.g. like here (except this example is for batch norm)::
https://github.com/pytorch/pytorch/blob/ea0f60ecfabe0501485015841c4176d5a09c8247/test/distributed/_composable/fsdp/test_fully_shard_mixed_precision.py#L543-L549
FSDP2's MixedPrecisionPolicy supports an optional output_dtype that you can use to cast your layer norm output back to bf16 if needed.

@yanmj0601 Are you sure you are wrapping FSDP1 and FSDP2 in the same way then? FSDP1 does not have any mechanism to make layer norm return fp32. Perhaps, you are wrapping layer norms separately and using a different mixed precision config for it?
I need to clarify which of the following you want (possibly more than one):

Cast layer norm input from bf16 to fp32
Cast layer norm weight from bf16 to fp32
All-gather layer norm weight directly in fp32 (avoiding any cast from bf16 to fp32)
Cast layer norm output from bf16 to fp32

Depending on where the layer norms are in your in model, I would say that 4 may not make sense. For example, if you have layer norm before a linear and that linear runs in bf16, then you may as well return the layer norm in bf16 since it will need to be cast to bf16 for the linear anyway.
If you want 1 and 3, then you can apply fully_shard to the layer norm modules separately first, e.g. like here (except this example is for batch norm<EMAIL_ADDRESS>FSDP2's MixedPrecisionPolicy supports an optional output_dtype that you can use to cast your layer norm output back to bf16 if needed.

FSDP1 returns fp32 probably because my model training is in the autocast context, but the FSDP2 in the autocast context  will have the above vanishing gradient problem. I haven't found the specific reason for this phenomenon yet. thanks for your reply, I will try this method first

One more question, do you recommend using FSDP2 with mixed precision and autocast context?


GitHub-1956 - Incorrect definition of EBITDA

Description
Modified the definition of EBITDA to better reflect its common interpretation per SME
Fixes: #1956
Checklist:

[x] I'm familiar with the FIBO developer quide. My contribution meets all the requirements described there.
[x] My contribution follows the principles of best practices for FIBO.
[x] My changes have been reconciled with latest master and no merge conflicts remain.
[x] This PR is related to exactly one issue. The issue is referenced by using a GitHub keyword such as "fixes", "closes", or "resolves".
[x] Hygiene tests have been applied by a PR with "(WIP)" in title.
[x] The issue has been tested locally using a reasoner (for ontology changes).

I think "measure of cash flow" is a bit vague. I suggest (helped by ChatGPT) "a financial metric that calculates a company's operational profitability by excluding non-operating expenses and non-cash charges."

The generally accepted accounting definition (GAAP does not have one, but I have an SME who knows), is that it is either a measure or estimate of cash flow, NOT a financial metric. And it is not always calculated the same way, and it is not considered usable for some reporting, such as to various government entities because it can be manipulated. The definition I've used is adapted from Barrons and Bruce's input.

Agreed
John
@.*** @.***>  | O:<PHONE_NUMBER>| M:<PHONE_NUMBER>
From: Elisa Kendall @.>
Sent: Wednesday, December 20, 2023 12:03 PM
To: edmcouncil/fibo @.>
Cc: John Gemski @.>; Review requested @.>
Subject: Re: [edmcouncil/fibo] GitHub-1956 - Incorrect definition of EBITDA (PR #1985)
I think "measure of cash flow" is a bit vague. I suggest (helped by ChatGPT) "a financial metric that calculates a company's operational profitability by excluding non-operating expenses and non-cash charges."
The generally accepted accounting definition (GAAP does not have one, but I have an SME who knows), is that it is either a measure or estimate of cash flow, NOT a financial metric. And it is not always calculated the same way, and it is not considered usable for some reporting, such as to various government entities because it can be manipulated. The definition I've used is adapted from Barrons and Bruce's input.
—
Reply to this email directly, view it on GitHub https://github.com/edmcouncil/fibo/pull/1985#issuecomment-1864830646 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNGJ24FYFXM32TPUKEJVW3YKMK4ZAVCNFSM6AAAAABA4KYEYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRUHAZTANRUGY .
You are receiving this because your review was requested.  https://github.com/notifications/beacon/ACNGJ25WFUV3G5WRPPIHJDTYKMK4ZA5CNFSM6AAAAABA4KYEYOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTPE4HLM.gif Message ID: @.*** @.***> >

I'm not fixated on measure vs metric, but I do think it's important to talk about a measure of profit as opposed to cashflow. You can earn a profit based on receivables (included in EBIDTA) but that does not mean you have the cash coming in!
"Cash flow, on the other hand, is a measure of the actual cash coming in and going out of the business. It reflects the company's ability to generate cash, which is crucial for meeting its short-term obligations and funding its operations. Unlike EBITDA, cash flow accounts for the actual timing of when revenues are received and expenses are paid. It includes changes in working capital and therefore is a direct indicator of a company's liquidity.
In essence, while EBITDA provides a view of a company's operational profitability by removing certain accounting and financial factors, cash flow directly measures the company's ability to generate and use cash. They serve different, but complementary, purposes in financial analysis."


CommandLineParser: implement freetext/separator

When a program has many options/modes, it would be nice to be able to format help message with separators, comments etc.

implemented in ddutils-1.1.1


Qualify agent images in DS and deployment for cattle-*-agent pods

cri-o doesn't support unqualified images by default, this fixes the problem for cattle-*-agent pods.
Fixes https://github.com/rancher/rancher/issues/27754

bump

Wouldnt this break air gapped installs with private registries?


Update test card number in doc blocks to new one

This updates the credit card number used in tests based on the value in the new docs.
https://developer.paypal.com/docs/classic/payflow/integration-guide/#paypal-credit-card-numbers-for-testing

@delatbabel as soon as PR 14 merges I'll rebase these two (15 & 16) on master and all tests will pass.

@delatbabel updated. Not sure how to ping you in a more direct fashion. :)


Single TQDM bar in multi-proc map

Use the "shard generator approach with periodic progress updates" (used in save_to_disk and multi-proc load_dataset) in Dataset.map to enable having a single TQDM progress bar in the multi-proc mode.
Closes https://github.com/huggingface/datasets/issues/771, closes https://github.com/huggingface/datasets/issues/3177
TODO: cleaner refactor of the _map_single decorators for generators now that they also have to know how to wrap generator functions

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Omg I love this ! cc @TevenLeScao @thomasw21 this will save your terminals from infinite streams of progress bars


Option to set --extra-arg

I'm running into an issue where I'm getting an irrelevant warning on my source code that happens when a define is not set.
This is a check to prevent inclusion of certain headers without the define.
When compiling, the correct cpp files have the define but clang-tidy will not have them when analyzing the header itself.
The solution to this is adding --extra-arg=-DMY_DEFINE to the command line.
In clang-tidy 17, you can set this in the config with ExtraArgs but I'm currently on 15.
Either way, I don't see such an option in clang-tidy-review
Note that multiple --extra-arg can be set one after the other.

Sounds good. Not sure I'll have much time to implement this myself for awhile, but PRs always welcome!


Inspect element doesn't focus the inspected element

When you right click on element in the web page and click inspect element it opes the Inspector but it doesn't focus the element that you clicked on like it does on FB2

This needs to be fixed on the platform, please create a new report in Bugzilla if this is still a problem
https://bugzilla.mozilla.org/
Honza


results for each domain

Thanks for your impressive work. Could you provide your detailed results of MIRO+SWAD (Using RegNetY-16GF backbone with SWAG pre-training) for each domain on the 5 datasets? Thank you very much.

Hope this help.

Thanks again!

Thanks for the nice work!
Sorry to bother you again. Could you please provide the detailed results of MIRO (Using VIT-B pre-trained by CLIP) for each domain on all the datasets?
Thank you very much.


[BUG] INDEX.html that is front-page path variables changed so page not loading properly

What would you like to share?
The main page index.html is not opening as expected as shown in below SS .This was because of change in path of different imports such as imported images or css files

Wanna Work upon[y/n] ??
yes

@Sidhuavneet

when hover a card and screen is scroll down see the above image as result, and fix this.
thank you

can i work on this issue,please assign it to me.

You could do it.
but now position is static for that header menu.
You could change it to `position: sticky' but not 'position: absolute' ok.
Use z-index if you need check the website before starting.

@CodeTorso  Sir Please Ellaborate What Is Expected To Does Please

Stay here for 2 mins

So when this issue was created that scrollbar was set to have position absolute
now after one of my PR the position is back to static

So the issue of courses cards appearing over navigation tab is solved.

You could however use 'position: sticky;' with the navbar and z-index: 1 to make the nav bar again scroll with scrollbar

but that top .contribution-request div seems to have some problem. Use LLM tools like ChatGPT to solve that.

@CodeTorso  Got it  Thanks !!!
Going To Solve contribution-request div seems to have some problem this issue.

Sir is a respectful thing. I have not done anything like that neither I am older than you. So just call hey friend or something.

Closing issue since first issue is solved


Adds test for negated content and absent buffer

Ticket
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/2224
Requires next version of https://github.com/OISF/suricata/pull/9944
#1503 with more rules/keywords

Replaced by #1518


Look for 'compact' in 'utils'

Looks like an instance of changing compact to utils.compact was missed in #16

:+1:


Cursor added while hovering on the movies

#114
Issue Number
fixes #114

Describe the changes you've made

Changed id web series from id = "Web Series" to id. = "WebSeries" in index.html.
Added cursor = pointer while hovering on the images in static/style.css.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Additional context (OPTIONAL)
Add any other context or screenshots about the feature request here.
Test plan (OPTIONAL)
A good test plan should give instructions that someone else can easily follow.
How someone can test your code?
Checklist

[ ] I have added my name in the contributors list at the end of README.md file.
[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.
[X] The title of my pull request is a short description of the requested changes.
[X] Open Source Program names(LetsGrowMore)

@JatanDudeja not working on kids and tv page.

Okay I will check again do the necessary changes if required.

Please add this I will make another PR for these two pages.

Please add this if possible. I will make another PR for these two pages.

Okk


No icons & broken FileChooserDialog

Creating a directory FileChooserDialog looks like this by default on OSX:

The icons are all broken and the open/cancel buttons are missing. Maybe there is something extra you need to do to set up the theme, but I didn't see it mentioned anywhere in the tutorial and this is quite a bad out-of-the-box experience. :-/

You seem to be using OSX. I think the problem is simply that GTK doesn't embed its icons (it does now but in a recent version). Windows has the same issue. I don't really know how to fix it though (except by providing the icons yourself).
An idea maybe @sdroege @EPashkin ?

Ah, the icons seem to be in /usr/local/Cellar/gtk+3/3.24.8/share/icons. Presumably I need to call GtkIconThemeExt::append_search_path() (set_search_path() doesn't seem to be exposed for some reason).
I tried this in my startup signal handler:
IconTheme::get_default().unwrap().append_search_path("/usr/local/Cellar/gtk+3/3.24.8/share");

Also share/icons and share/icons/hicolor, but none had any effect.

Ah, the icons seem to be in /usr/local/Cellar/gtk+3/3.24.8/share/icons.

Actually scratch that, there are only a couple of random demo app icons in there. Where are the icons supposed to be?

What tutorial were you referring to btw? It'd be interesting to add those dependencies into it.

@Timmmm I don't have a Mac to test this, could you try with:
brew install adwaita-icon-theme

@GuillaumeGomez I would add them here - where it says brew install gtk+3, change it to brew install gtk+3 gnome-icon-theme.
@fengalin Installing gnome-icon-theme installs adwaita-icon-theme as a dependency.
I suspect the missing icons are related to the fact that on Gnome the buttons are in the title bar (as discussed here). I'm not sure how to change that setting though, given that we're not using gsettings.

Well it can't be the DialogsUseHeader setting because
gtk::Settings::get_default().expect("Couldn't get settings").set_property_gtk_dialogs_use_header(false);

Has no effect, and setting it to true makes it look a bit different (but still no ok/cancel buttons).

Best to discuss this at https://discourse.gnome.org as this is a general GTK problem and unrelated to the bindings.


Move cli.py to src level

I think it ought to be possible to move the cli.py file into the src package as long as you adjust the entrypoint and any other path  behaviors like imports, just to keep it nice and bundled together

Oh actually, that's right - never mind about src, but I'd put it in the demo folder since it's very specific to that
Maybe rename to cli_demo.py for clarity?
The actual location of the demo folder is good; reminiscent of a 'testing' folder which ought to live outside the main package to demonstration absolute imports


How could I get the AmazonLite key-word lib?

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.
How could I get the AmazonLite key-word lib?
Briefly summarize your issue:
We want to get amazon lite key-word lib instead of sensory.
What is the expected behavior?
We want to get amazon lite key-word lib instead of sensory.
What behavior are you observing?
We want to get amazon lite key-word lib instead of sensory.
Provide the steps to reproduce the issue, if applicable:
We want to get amazon lite key-word lib instead of sensory.
Tell us about your environment:
linux-buildroot
What version of the AVS Device SDK are you using?
  <1.6.0>

Tell us what hardware you're using:

[ ] Desktop / Laptop
[ ] Raspberry Pi
[x] Other - tell us more:

Tell us about your OS (Type & version):

[x] Linux
[ ] MacOS
[ ] Raspbian Stretch
[ ] Raspbian Jessy
[ ] Other - tell us more:

Contact us privately here.
Thanks,
Sanjay


FR: configure which characters to use as "icons" for weather

Not all fonts have the characters you are using, I get squares and arrows.

Hey @nkh,
Yes, it's true that not all fonts support the used characters.
It was tried to mention at several places that a dependency to use wthrr are fonts the that add support for the characters.
E.g.

https://github.com/ttytm/wthrr-the-weathercrab#installation
https://github.com/ttytm/wthrr-the-weathercrab/blob/main/INSTALL.md#requirements

Most terminal fonts have patched "nerd variants", for this please refer to the install instructions above.
A PR that makes icons configurable or adds fallbacks if the installation instructions were not followed is welcome, but I do not plan to work on it from my end.


Fix #4: predict-eth2.md: do simple model-based prediction

Fixes # 4 .
Changes proposed in this PR:

Fixes #4: Changes the demo ML model for a basic linear model

Jaime, in your PRs, please

make the title have the # and name of issue you're fixing
make the description have the # of the issue you're fixing

E.g. for this issue:

title: "Fix #4: predict-eth2.md: do simple model-based prediction"
description: "Fix #4: "

Hi @jfdelgad , given the changes to the structure of the READMEs, this PR will need to get changed heavily, such that it's one of the examples.

Hi @jfdelgad , given the changes to the structure of the READMEs, this PR will need to get changed heavily, such that it's one of the examples.

This has been addressed, i added you as reviewer of the example. I am closing this pull request.


Remote DC replication Failover

This is the final patch in the series to enable remote DC replication
failover. If a node figures a remote node is marked as DOWN, it tries to
failover to another node. This does not failover those requests which
were already queued on the connection and could not be forwarded due to
network issues, but only those that arrived after the remote peer was
marked as DOWN.

Overal LGTM


Remove newlines from base64digest

We very often want a SHA512 hash to be single-lined.
Also adds docs to OpenSSL::DigestBase

We very often want a SHA512 hash to be single-lined.

Why do you want that?

Why do you want that?

Because we usually want a SHA512 hash, not having lines breaks inside this very hash.
For example, yarn.lock, APKBUILD, or even the sha512sum command.
What's the use case of having a multi-line hash?!

I never see the need of multi-line hash, anywhere, at least for SHA* and MD5

@yxhuvud This only changes the Digest classes, not the Base64 implementation itself.

@yxhuvud Ok, but real world put the base64 string on a singe-line. It should be at least the default, because the most widespread.
If people really want multi-line, we may add a boolean argument then.

@yxhuvud Ok, but real world applications put the base64 string on a singe-line. It should be at least the default, because the most widespread.
If people really want multi-line, we may add a boolean argument then.
Another option is to remove this method, it may be fine to use Base64.strict_encode digest - more flexible and no confusion possible (no questions about strict or not).

For Digest purposes, strict_encode seems like the correct representation.

Any update, should we add an argument strict : Bool = true?


Update validations.py file Closes: #1

Fixes #1

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

@googlebot I signed it!


[JAST USA] Exception parsing API results

Extension name
JAST USA
Bug Description
Failed to import games from plugin: JAST USA
Newtonsoft.Json.JsonSerializationException: Error converting value "/api/v2/contexts/Result" to type 'JastUsaLibrary.Models.Context'. Path '@context', line 1, position 41. ---> System.ArgumentException: Could not cast or convert from System.String to JastUsaLibrary.Models.Context

Seems like an API change?
To Reproduce
Attempt to update JAST library.
Logs
API response has been edited to only show the first product result for brevity.
31-08 17:32:32.393|ERROR|MainViewModelBase:Failed to import games from plugin: JAST USA
Newtonsoft.Json.JsonSerializationException: Error converting value "/api/v2/contexts/Result" to type 'JastUsaLibrary.Models.Context'. Path '@context', line 1, position 41. ---> System.ArgumentException: Could not cast or convert from System.String to JastUsaLibrary.Models.Context.
   at Newtonsoft.Json.Utilities.ConvertUtils.EnsureTypeAssignable(Object value, Type initialType, Type targetType)
   at Newtonsoft.Json.Utilities.ConvertUtils.ConvertOrCast(Object initialValue, CultureInfo culture, Type targetType)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.EnsureType(JsonReader reader, Object value, CultureInfo culture, JsonContract contract, Type targetType)
   --- End of inner exception stack trace ---
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.EnsureType(JsonReader reader, Object value, CultureInfo culture, JsonContract contract, Type targetType)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.SetPropertyValue(JsonProperty property, JsonConverter propertyConverter, JsonContainerContract containerContract, JsonProperty containerProperty, JsonReader reader, Object target)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
   at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
   at Newtonsoft.Json.JsonConvert.DeserializeObject(String value, Type type, JsonSerializerSettings settings)
   at Newtonsoft.Json.JsonConvert.DeserializeObject[T](String value, JsonSerializerSettings settings)
   at Playnite.Common.Serialization.FromJson[T](String json) in C:\projects\playnite\source\Playnite\Common\Serialization.cs:line 336
   at Playnite.Common.DataSerializer.FromJson[T](String json) in C:\projects\playnite\source\Playnite\Common\Serialization.cs:line 80
   at Playnite.SDK.Data.Serialization.FromJson[T](String json) in C:\projects\playnite\source\PlayniteSDK\Data\DataSerialization.cs:line 406
   at JastUsaLibrary.Services.JastUsaAccountClient.GetGames(AuthenticationToken authenticationToken) in C:\Users\Brandon\source\repos\PlayniteScriptExtensions\source\Library\JastUsaLibrary\Services\JastUsaAccountClient.cs:line 232
   at JastUsaLibrary.JastUsaLibrary.GetGames(LibraryGetGamesArgs args) in C:\Users\Brandon\source\repos\PlayniteScriptExtensions\source\Library\JastUsaLibrary\JastUsaLibrary.cs:line 84
   at Playnite.Database.GameDatabase.ImportGames(LibraryPlugin library, CancellationToken cancelToken, PlaytimeImportMode playtimeImportMode) in C:\projects\playnite\source\Playnite\Database\GameDatabase.cs:line 1223
   at Playnite.ViewModels.MainViewModelBase.ImportLibraryGames(LibraryPlugin plugin, CancellationToken token) in C:\projects\playnite\source\Playnite\ViewModels\MainViewModelBase.cs:line 506```

### Screenshots

_No response_

Fixed in v1.11. There were many changes that needed to be made but unfortunately I don't have games on JAST USA, I only used the free items available on the store like demos and patches to develop and test and while I made sure everything worked correctly there's the chance that there could be an issue with people with larger libraries. Please update and test if it's working correctly, it it works fine let me know to close the issue.
Tagging @Seany1990 as well.

It is working for me. Thank you for fixing the bug

Looks good to me. thank you. You can  go ahead and close the issue.

Thanks for checking.


Update framework version

Update framework version

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/839663123

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/839663123
Status: success


PartitionWizard

Hi,
It could be also cool to support PartitionWizard.
It could help.
http://labalec.fr/erwan/?p=388
Thanks,

Added per your request:
https://github.com/antonym/netboot.xyz/pull/12

Thanks a lot!


Timeout per command. Cleanup dangling images.

Added hacky cleanup for dangling images https://github.com/moby/moby/issues/37311

This change is

Codecov Report

Merging #244 into master will decrease coverage by 0.61%.
The diff coverage is 7.2%.

@@             Coverage Diff              @@
##             master     #244      +/-   ##
============================================
- Coverage     20.44%   19.83%   -0.62%
- Complexity      245      247       +2
============================================
  Files            72       71       -1
  Lines          2895     2975      +80
  Branches        261      281      +20
============================================
- Hits            592      590       -2
- Misses         2240     2324      +84
+ Partials         63       61       -2

Impacted Files
Coverage Δ
Complexity Δ

...ain/java/com/github/kostyasha/yad/DockerCloud.java
11.89% <ø> (ø)
9 <0> (ø)
:arrow_down:

...github/kostyasha/yad/DockerSimpleBuildWrapper.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...thub/kostyasha/yad/steps/DockerBuildImageStep.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...va/com/github/kostyasha/yad/DockerSlaveConfig.java
67.24% <ø> (ø)
17 <0> (ø)
:arrow_down:

...om/github/kostyasha/yad/steps/DockerShellStep.java
1.21% <ø> (ø)
0 <0> (ø)
:arrow_down:

...yad/launcher/DockerComputerSingleJNLPLauncher.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...ha/yad/steps/DockerImageComboStepFileCallable.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...b/kostyasha/yad/commons/cmds/DockerBuildImage.java
2.06% <0%> (-0.07%)
0 <0> (ø)

...thub/kostyasha/yad/steps/DockerImageComboStep.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...b/kostyasha/yad/commons/DockerCreateContainer.java
45.28% <0%> (-0.52%)
64 <0> (ø)

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d07aa96...7997a36. Read the comment docs.

maybe it's last RC :D


[No QA] Add separate assertions for deploy comments, fix bug

Details
This fixes an edge case that is causing duplicate deploy comments, such as here.
Fixed Issues
$ n/a
Tests
Added new assertions to automated unit test.
QA Steps
I've updated the QA steps of https://github.com/Expensify/App/pull/6906 to cover this change.

🚀 Deployed to staging by @Jag96 in version: 1.1.28-1 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @Jag96 in version: 1.1.29-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Single item mode is not working properly with horizontal scroll

Selecting tag item causes an exception in case Tags widget builds with horizontalScroll: true and ItemTags - with singleItem: true.
I'm very new in flutter, but I've made a small investigation.
It looks like, that in case horizontal scrolling with no symmetry the default ListView widget is used for building tag items list. If singleItem mode is true, selecting of tag item causes an exception, because of not all ListView items was builded and we are not be able to "disativate" each item in ItemTagsState._singleItem()
As I said, I'm new with flutter. I think, I get a reason of that bug (hope I get it right :smile: ), but I have no idea how to fix it in a proper way.
Steps to reproduce:

run example app
enable horizontal scroll and single item checkboxes
switch to "Demo 2" tab and move back to "Demo 1"
try to select tag item with pre-selected options in step two

Stack trace:
════════ Exception caught by gesture ═══════════════════════════════════════════════════════════════
The following NoSuchMethodError was thrown while handling a gesture:
The getter 'active' was called on null.
Receiver: null
Tried calling: active

When the exception was thrown, this was the stack:
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:51:5)
#1      _ItemTagsState._singleItem.<anonymous closure> (package:flutter_tags/src/item_tags.dart:442:27)
#2      WhereIterator.moveNext (dart:_internal/iterable.dart:442:13)
#3      WhereIterator.moveNext (dart:_internal/iterable.dart:441:22)
#4      Iterable.forEach (dart:core/iterable.dart:283:23)
...
Handler: "onTap"
Recognizer: TapGestureRecognizer#e7b35
  debugOwner: GestureDetector
  state: ready
  won arena
  finalPosition: Offset(203.6, 240.7)
  finalLocalPosition: Offset(66.6, 26.0)
  button: 1
  sent tap down
════════════════════════════════════════════════════════════════════════════════════════════════════

hi @omnifer, could you post the code? you must also indicate the version with flutter doctor

Hi, @Dn-a
I've made a sample app and pushed code here, you can clone and run it.
Also the bug exists in example app from this repository. You can reproduce it with steps I wrote above.
flutter doctor -v
[✓] Flutter (Channel stable, 1.22.3, on Linux, locale en_US.UTF-8)
    • Flutter version 1.22.3
    • Framework revision 8874f21e79 (13 days ago), 2020-10-29 14:14:35 -0700
    • Engine revision a1440ca392
    • Dart version 2.10.3

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /home/alexander/Android/Sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /usr/bin/java
    • Java version OpenJDK Runtime Environment 18.9 (build 11.0.9+11)
    • All Android licenses accepted.

@omnifer yes it's a bug and I will fix it in the next release asap.
thanks.

new release 0.4.9+1


Replace deprecated DnsValidatedCertificate

This PR replaces deprecated DnsValidatedCertificate with recommended Certificate.
Certificate doesn't do DNS validation against the specified Route 53 hosted zone automatically, hence certificate is validated explicitly.

Looks good to me. The explicit validation makes sense, too, given the new behaviour. What do you think @rieckpil?

Thnks for the contribution @BranislavBeno - changes look great!


Trouble trying to use blueprints

Hi there, sorry I'm struggling with how to use with blueprints in the following context, any help would be great. I don't know how to successfully use the decorator within the blueprint. Thanks
init.py
Other imports....
from app.webapp import server_bp
from flask_sitemapper import Sitemapper

sitemapper = Sitemapper()

def create_app():
    server = Flask(__name__)
    server.config.from_object(BaseConfig)
    register_dashapps(server)
    register_blueprints(server)

    sitemapper.init_app(server)

    return server

def register_blueprints(server):
    server.register_blueprint(server_bp)

webapp.py
server_bp = Blueprint("main", __name__)

@server_bp.route("/")
def index():
    if BaseConfig.DEMO_TOKEN:
        return redirect("/sales")
    etc

Hi, thanks for opening the issue - I will improve the documentation on this
The way I would usually do this is to set up the extensions in a separate extensions.py file. For your project this might look like this:
.
└── app/
    ├── __init__.py
    ├── extensions.py
    └── webapp.py

extensions.py
from flask_sitemapper import Sitemapper

sitemapper = Sitemapper()

# you could also set up other extensions e.g. sqlalchemy in this file

__init__.py
# other imports....
from app.webapp import server_bp
from app.extensions import sitemapper # import from extensions file

def create_app():
    server = Flask(__name__)
    server.config.from_object(BaseConfig)
    register_dashapps(server)
    register_blueprints(server)

    sitemapper.init_app(server) # initialise after registering all blueprints

    return server

def register_blueprints(server):
    server.register_blueprint(server_bp)

webapp.py
from app.extensions import sitemapper # import from extensions file
server_bp = Blueprint("main", __name__)

@sitemapper.include(lastmod="2023-03-21") # add this route to the sitemap with desired args
@server_bp.route("/")
def index():
    if BaseConfig.DEMO_TOKEN:
        return redirect("/sales")
    # etc

Let me know how it goes and thanks for using the extension :)

That seems to have worked perfectly now. Thanks for the clarification and the extension!


fix(root): update ACR docs to ITIC versions

Update to the ACR documents (including EN301) to use the public versions, not ours with the cover pages.
334

Summary of the changes
Updating the ACR documents to use the ITIC versions not our modified ones.
Related issue
Bug 334
Checklist

[X] I have manually accessibility tested any changes, if relevant.
[X] I have raised this pull request against the develop branch

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Challenge 12 - Slomo - cannot reenter instantly after beeing killed

I played Challenge 12 and got killed.
I cannot reenter the game by hitting Return, except the game shows the killscreen with countdown of 10 to throw you back in.

Tried to replicate this but was able to respawn pressing Enter, was platform are you using? Did you compile from source or use the precompiled actions? Which version?

I use the automated builds under win11 Radeon Pro 560.
I think it was this one:
https://github.com/fgsfdsfgs/perfect_dark/actions/runs/6060999132

Tried this again with that build but I get the same result as the original game, being able to respawn as soon as the 10 appears. Was there anything that happened prior to dying that might've caused it? Are you able to replicate it?
https://github.com/fgsfdsfgs/perfect_dark/assets/16583255/46e1bedc-14f4-488f-8e02-ebcd5872d1aa

Oh, it is normal that i have to wait until the 10 is shown? I thought i can respawn instantly and skip the death animation.
If that‘s the normal behavior, this issue can be closed.


Error messages are not human-readable

Error messages are not written out in a human-readable form:

This is not related to Linter-julia. The problem is Lint.jl which is an old linter.
https://github.com/tonyhffong/Lint.jl/issues/266


[BUG] Fleet not coming back after reboot

Describe the bug
When rebooting the VM that the Fleet container is running on, the Fleet server isn't coming back online. It is unclear what the actual problem is right now.
./elastic-container.sh status
NAME                IMAGE                                                 COMMAND                  SERVICE             CREATED             STATUS                    PORTS
ecp-elasticsearch   docker.elastic.co/elasticsearch/elasticsearch:8.7.0   "/bin/tini -- /usr/l…"   elasticsearch       3 days ago          Up 17 minutes (healthy)   <IP_ADDRESS>:9200->9200/tcp, 9300/tcp
ecp-fleet-server    docker.elastic.co/beats/elastic-agent:8.7.0           "/usr/bin/tini -- /u…"   fleet-server        3 days ago          Up 17 minutes             <IP_ADDRESS>:8220->8220/tcp
ecp-kibana          docker.elastic.co/kibana/kibana:8.7.0                 "/bin/tini -- /usr/l…"   kibana              3 days ago          Up 17 minutes (healthy)   <IP_ADDRESS>:5601->5601/tcp

curl -vvv -k https://localhost:8220
*   Trying <IP_ADDRESS>:8220...
* Connected to localhost (<IP_ADDRESS>) port 8220 (#0)
* ALPN: offers h2
* ALPN: offers http/1.1
* [CONN-0-0][CF-SSL] (304) (OUT), TLS handshake, Client hello (1):
* LibreSSL SSL_connect: SSL_ERROR_SYSCALL in connection to localhost:8220
* Closing connection 0
curl: (35) LibreSSL SSL_connect: SSL_ERROR_SYSCALL in connection to localhost:8220

To Reproduce
Steps to reproduce the behavior:

Deploy the ECP with ./elastic-container.sh start
Once completed, reboot the VM that the containers are running on
Restart the ECP containers with ./elastic-container restart
Fleet is unavailable in Kibana and the error above is present

Expected behavior
Fleet should be operational after a reboot.
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS] macOS Ventura 13.3, also reported on Ubuntu
Browser [e.g. chrome, safari]: Chrome, but error is also evident with cURL, so not a browser issue
Version [e.g. 22]: 8.7.0

Additional context
Going to try an downgrade to 8.6 and then 8.5 to see if this is an 8.7 thing or something else.

I think the issue may be if you reboot the host VM without stopping the containers, something is happening with TLS.
Test:

Installed using version 8.6.2 (likely the same result for 8.7.0 based on reporting)
Ran ./elastic-container.sh start, verified everything worked
Ran ./elastic-container.sh stop, rebooted the host
When the host came back up, ran ./elastic-container.sh start, verified everything worked
Rebooted the host without running ./elastic-container.sh stop first
Fleet server has the TLS errors

As a workaround, you can run ./elastic-container.sh stop before rebooting the host that is running the stack.
We're working on a better solution, but this workaround should help while we work this out.

I rolled back to #16 for 8.6.0 and got the same issue there as well.
ubuntu@elk:~$ docker ps
CONTAINER ID   IMAGE                                                 COMMAND                  CREATED        STATUS                   PORTS                                                 NAMES
42827144627a   docker.elastic.co/beats/elastic-agent:8.6.0           "/usr/bin/tini -- /u…"   17 hours ago   Up 7 minutes             <IP_ADDRESS>:8220->8220/tcp, :::8220->8220/tcp             ecp-fleet-server
2e6a2519746a   docker.elastic.co/kibana/kibana:8.6.0                 "/bin/tini -- /usr/l…"   17 hours ago   Up 6 minutes (healthy)   <IP_ADDRESS>:5601->5601/tcp, :::5601->5601/tcp             ecp-kibana
aadcb438ea15   docker.elastic.co/elasticsearch/elasticsearch:8.6.0   "/bin/tini -- /usr/l…"   17 hours ago   Up 7 minutes (healthy)   <IP_ADDRESS>:9200->9200/tcp, :::9200->9200/tcp, 9300/tcp   ecp-elasticsearch

ubuntu@elk:~$ curl -vvv -k https://localhost:8220
*   Trying <IP_ADDRESS>:8220...
* TCP_NODELAY set
* Connected to localhost (<IP_ADDRESS>) port 8220 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*   CAfile: /etc/ssl/certs/ca-certificates.crt
  CApath: /etc/ssl/certs
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to localhost:8220
* Closing connection 0
curl: (35) OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to localhost:8220

Commit 7f61c3a for 8.5.0 seems to work fine.

Thanks for testing the other versions and raising this issue, Rasta.
Our suspicion is that there is a state file somewhere that isn't being gracefully managed when you reboot the host without stopping the stack first.
We're unsure if this is an ECP issue or an issue with the Fleet container.
Next steps will be to spin up an Elastic Stack using the default config from Elastic, test the scenarios, and either make an adjustment to how the state file is managed (if that's the case) or file a bug with the Fleet team.
We'll try to do these tests this weekend. Until then, while not ideal, if you run the stop command before rebooting, that seems to prevent this issue.

This is possibly an upstream issue. It has been recreated and being tracked.
https://github.com/elastic/fleet-server/issues/2431

Looks like this will be fixed in 8.9.
https://github.com/elastic/fleet-server/issues/2431#issuecomment-1625339517

Awesome.  I'm happy to close this issue if you are?

I'd like to keep it open so I remember to test and bump to 8.9 😅

Verified with 8.9.0 in the project that the Fleet server comes back online. Bumping version in main.