Move "es Lint" to different step and add go lint on logger module

@gadotroee we should consider doing the same in mizu-ent


Forbidden error in yurt-controller-manager

I saw permission forbidden error in kube-system/yurt-controller-manager:
E0615 08:50:17.179354       1 leaderelection.go:306] error retrieving resource lock kube-system/yurt-controller-manager: leases.coordination.k8s.io "yurt-controller-manager" is forbidden: User "system:serviceaccount:kube-system:default" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kube-system"

BTW, I test yurtctl on my kubeadm env with k8s version v1.17.3, I think you can add the version to pkg/yurtctl/util/kubernetes/util.go, 👍

@vincent-pli
maybe rbac setting step is missed, you can exec the following command to add permission for yurt-controller-manager.
kubectl create clusterrolebinding add-on-cluster-admin --clusterrole=cluster-admin --serviceaccount=kube-system:default
@charleszheng44 maybe we need to add rabc setting in yurtctl

@rambohe-ch
It's exactly what I did, I mean we need add the RBAC to the guide.

@vincent-pli good to know yurtctl works to 1.17.

@charleszheng44
I made the cluster with kubeadm manually.
root@nisuses1:~/tekton# kubectl auth can-i get lease --as=system:serviceaccount:kube-system:default -n kube-system
no

@vincent-pli Thanks for letting me know. I will make the yurtctl to add the permission to the serviceaccount:kube-system:default, if it is not granted.

@charleszheng44 thanks


Add CRC validation on pinot-minion to drop duplicate tasks

BaseSingleSegmentConversionExecutor tasks follow the pattern of:

download segment
processing segment
upload the new segment

It will be helpful to check segment CRC first before starting a SegmentConversion task. Without this logic, minion will start the task blindly and fail when uploading segment, which will make minion do unnecessary works and increase the waiting time of other tasks.

close this as the PR has been merged.


project doesn't work properly

this project does a capture screen but it shows them (many capture screens) on a surfaceview.
the question is can I get this screenshot and save ot as a png ?
I need only one screenshot

!!!!!!!!!!!!!!! I wait for response


Value binning for reference mapping.

Hi there,
I have a question. I can see value binning is consistently used for fine-tuning tasks (and rational for this is written in the paper), however, I don't see value binning on input data in reference mapping tutorial. I will really appreciate more insight into it.
Sincerely,
Manoj

Hi, thank you for the question and yes, the binning is consistently used for most of the tasks. For the reference mapping tutorial, the binning is conducted in a more efficient way in the data collator. Specifically, you can find this new implementation in the embed_data function in cell_emb.py. The call is around these lines https://github.com/bowang-lab/scGPT/blob/418b0f623fb1f17641a12c9e50f72f4419311745/scgpt/tasks/cell_emb.py#L96-L105


PutPageFromURL - Source Content Validation Bad Repro

API change check
API changes are not detected in this pull request.


process.stdout

Would be great to have it implemented.
Many packages would run simply by having process.stdout.write() (I'm using browserify).

Will not implement because of the added complexity to this module. This module is loaded by default in many cases and I don't want to bloat the size.


Detect a single object on screen and display an alarm

The idea would be for the user to select an object in question, such as a motorcycle, and every time the system detects that object, it would display an alarm warning that there is that object on the screen!

Hi, I gave you some inputs here: https://github.com/opendatacam/opendatacam/issues/141


unable to connect to mysql

Here is the output, condensed
TASK: [geerlingguy.mysql | Set ownership on slow query log file (if configured).] ***
ok: [drupaldev]

TASK: [geerlingguy.mysql | Ensure MySQL is started and enabled on boot.] ******
ok: [drupaldev]

TASK: [geerlingguy.mysql | Get list of hosts for the root user.] **************
failed: [drupaldev] => {"changed": false, "cmd": ["mysql", "-NBe", "SELECT Host FROM mysql.user WHERE User = \"root\" ORDER BY (Host=\"localhost\") ASC"], "delta": "0:00:00.004397", "end": "2015-06-26 19:59:47.682232", "rc": 1, "start": "2015-06-26 19:59:47.677835", "stdout_lines": [], "warnings": []}
stderr: ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2)

FATAL: all hosts have already failed -- aborting

PLAY RECAP ********************************************************************
           to retry, use: --limit @/Users/fanderson/playbook.retry

drupaldev                  : ok=34   changed=0    unreachable=0    failed=1

Ansible failed to complete successfully. Any error output should be
visible above. Please fix these errors and try again.

I attempted to log into the server with vagrant ssh and it didn't allow me to access mysql from the command line there either. Same error.
Running vagrant provision after the initial failure gave the same result.

After reading that thread, the common link to the problems seems to be installing ansible via homebrew vs installing via pip.
I uninstalled with homebrew, installed pip, installed ansible <IP_ADDRESS> as stated above and everything when through just fine.
Thanks for this insanely useful tool.

@frob - No problem! And hopefully homebrew will get 1.9.2 very soon after it's released, so this problem will go away once and for all :)


Revert "Recursive inorder traversal of binary search tree in javascript"

Reverts TesseractCoding/NeoAlgo#4468
I forgot to notice that you have used a library from npm here and it is not recommended to use npm packages in a JS script without making it a NodeJS Project. So, the solution for this would be for you to not use npm package and use readline link which is available in the nodejs itself.

@aaadddiii kindly look into it and do the needful and raise a pr again. Sorry for not looking at it earlier.


fix(chartutil): Ensure ReadValues doesn't return a nil map

closes #912
Not sure if this is necessary anymore @technosophos, as you mentioned in #912, but it seems safer to me nonetheless.

Manually tested, and verified that this does indeed close #912.


Updates to Steering Committee membership

Removes Erik as he's now a maintainer
Adds github handles / company links for existing SC members
Adds Ian Arsenault as the newest SC member! (see #37 )

Oops, I didn’t mean to merge this!! I though /lgtm was just going to mark this PR as reviewed as requested by Ash. How can I fix this?

I think in this case it's fine that it merged! We can look into the config in https://github.com/cert-manager/testing for this repo maybe down the road, but that's a discussion for elsewhere.
Thanks for the review Maël, welcome Ian!


[Bug]: 4.0.0-rc.1 builds empty pages—assets are empty/served as documents

Steps to reproduce
So far, I've been unable to create a minimal test reproduction, but the issue is affecting a site I currently use with netlify. I would have reported in the discussion but the conversation has been locked.
The issue is essentially that every page renders without almost any markup, and no styles or js. The pages exist, but they are empty.
I believe this is because all of the generated assets are empty. When I inspect the document <head> I can see that all of the included js assets are served as empty document files. (I would expect them to be served as script files, and to not be empty).
I've inspected the function logs but these are entirely empty as well.
For now I'm continuing to use 4.0.0-beta.4, which was the last working v4 for me.
Thanks!
A link to a reproduction repository
No response
Plugin version
4.0.0-rc.1
More information about your build

[ ] I am building using the CLI
[X] I am building using file-based configuration (netlify.toml)

What OS are you using?
Mac OS
Your netlify.toml file

`netlify.toml`
[build]
publish = ".next"

[[plugins]]
package = "@netlify/plugin-nextjs"

Relevant log output (or link to your logs)

Build logs
# Paste logs here

Same issue with 4.0.0-rc.2.
All the JS and CSS files—which are served from cloudfront.net—are empty.

Hey.  Could you share a link to the deploy preview?

 This is a fairly standard nextjs build I think. 10 or so screens, typescript, one use of getStaticProps and getStaticPaths.
When I inspect the <head> of the problematic build, I see stuff like this:
<script defer="" src="https://[RANDOM_HASH].cloudfront.net/js/[RANDOM_HASH]/assets/js/site.js"></script>

There are several of these files, both JS and CSS.
This seems notably different from my working build, which does not contain any absolute src urls. In the working build, the asset files are all relatively referenced, with paths like /_next/static/
I'm not able to share the deploy preview publicly unfortunately. I've been trying to recreate a minimal test reproduction, but so far no luck.

Do you have any special build plugins installed, or anything in the next.config.js that would do this? This certainly isn't anythign this plugin should be doing.

Yes, a few build plugins. The next.config.js essentially looks like this:
const { createVanillaExtractPlugin } = require("@vanilla-extract/next-plugin");
const withPWA = require("next-pwa");
const withVanillaExtract = createVanillaExtractPlugin();

/** @type {import('next').NextConfig} */
const moduleExports = {
  reactStrictMode: true,
  images: {
    domains: ["foo.example.com"],
  },
  pwa: {
    dest: "public",
  },
};

let config = withVanillaExtract(moduleExports);

if (process.env.NODE_ENV === "production") {
  config = withPWA(config);
}

if (process.env.ANALYZE === "true") {
  const withBundleAnalyzer = require("@next/bundle-analyzer")({
    enabled: true,
  });
  config = withBundleAnalyzer(config);
}

module.exports = config;

But I've also tried this exact config ☝ and it seems to work fine.

Which if any Netlify build plugins do ytou have enabled, apart from the Essential Next.js plugin?

Essential Next.js is the only one. My netlify.toml looks like this:
[build]
publish = ".next"

[[plugins]]
package = "@netlify/plugin-nextjs"

But I've also tried this exact config ☝ and it seems to work fine.

I don't follow. Are you saying that you have other sites with the same config which work fine?

I don't follow. Are you saying that you have other sites with the same config which work fine?

I have a test site where I've been trying to reproduce the issue so that I can share it (so far I can't reproduce the problem, though). The next.config.js file looks like this:
const { createVanillaExtractPlugin } = require("@vanilla-extract/next-plugin");
const withPWA = require("next-pwa");
const withVanillaExtract = createVanillaExtractPlugin();

/** @type {import('next').NextConfig} */
const moduleExports = {
  reactStrictMode: true,
  images: {
    domains: ["foo.example.com"],
  },
  pwa: {
    dest: "public",
  },
};

let config = withVanillaExtract(moduleExports);

if (process.env.NODE_ENV === "production") {
  config = withPWA(config);
}

if (process.env.ANALYZE === "true") {
  const withBundleAnalyzer = require("@next/bundle-analyzer")({
    enabled: true,
  });
  config = withBundleAnalyzer(config);
}

module.exports = config;

This config is not exactly the same as the config of the failing site, but it's essentially identical. I've just changed the image domains.

Another noteworthy thing I've just discovered: nested/dynamic pages seems to load their assets correctly.
So:
/foo/[bar].tsx
/baz/[qux].tsx

✅ Loads assets correctly from /_next/static
/
/about/index.tsx

❌ Loads assets from https://[RANDOM_HASH].cloudfront.net/js/[RANDOM_HASH]/assets/js/site.js

Thanks for the details. I need to talk to some of my colleagues about this. It's not somethign I've seen before, so I don't know what coudl be causing it. I'll get back to you when I have more info.

I disabled asset optimization and it started working. Looks quite similar to this issue https://answers.netlify.com/t/problem-with-assets-optimization-setting-in-netlify/2277

Worth noting that, at least for 4.0.0-beta.4, with asset optimization enabled, everything seems to be working fine.

Great! I think we should say that asset optimization shouldn't be used with Next.js, as it already compresses its assets. In beta 4 it probably didn;t actually optimise them, because they were served via the function. In later versions we've become more efficient at offloading static files to the CDN to improve performance.
I'm going to close this, as it seems the original problem is fixed. I'll look into how we should best handle conflicts like this.


Bitcoin support address

Just a much easier and hackier way to deal with online donation.

Thanks, other friend also told me something about bitcoin donation, I'm just too lazy to add this. I'll spend some time on bitcoin topic soon.


GitHub info

we do have GitHub repo info in each of the docs but we don't have a more visible information that it can be found in the docs page).

@vietj Can you elaborate?

@vietj Can you elaborate?

I can't remember what it was, I'll reopen with more details if I do recall

I can't remember what it was, I'll reopen with more details if I do recall


Training progress slow

Hi shrubb, I tried running the default code on 2 RTX3080 GPUs with default settings to train from scratch with data/splits/train.csv as the identites, but the training time is taking very long (at least 7.04 seconds per iteration, so 1 epoch takes at least 24 hours).
I tried changing num_workers to 0, pin_memory in the dataloader to True and decreasing batch size but it still faces the same issue.
Would like to enquire if theres any way to speed up training process?
Thanks

Hi, 7 seconds per iteration is definitely too much. I had at least 10× less on two P40.So looks like it's something specific to your setup, not sure what exactly... You can use Python's drop-in profiler with num_workers=0 (normally it should be >0) to examine what's taking so much time.


Platform is Identified as Unknown Command

Platform is Identified as Unknown Command

THE PLATFORM COMMAND IN THE HELP SECTION IS INCORRECT
The help section mentions a command 'platform'. This is incorrect. The actual command is 'platforms'. Will fix the help.json file ASAP.

Fixed in the v2.1.1 release


Unable to install via BRAT on Obsidian Mobile

I was trying to install this on my iPad via BRAT but it shows this error:

Look at the top right corner

Try adding it without the .git at the end, like https://github.com/Zachatoo/obsidian-css-editor
See relevant BRAT documentation here.


Removing patch dependencies scope restriction to release branch only

Issue #, if available:
Description of changes:

[x]  Includes maven cache in prbuild to make subsequent pr builds faster.
[x]  Updates patch workflows and scripts so that they are not scoped to only release branches.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
Attention: 102 lines in your changes are missing coverage. Please review.

Comparison is base (09e6487) 85.71% compared to head (a92fb45) 50.73%.
Report is 184 commits behind head on main.

Files
Patch %
Lines

...ent/providers/AwsAppSignalsCustomizerProvider.java
24.00%
35 Missing and 3 partials :warning:

...gent/providers/AwsSpanMetricsProcessorBuilder.java
0.00%
20 Missing :warning:

...ders/AttributePropagatingSpanProcessorBuilder.java
0.00%
16 Missing :warning:

...viders/AwsMetricAttributesSpanExporterBuilder.java
0.00%
11 Missing :warning:

...try/javaagent/providers/AwsSpanProcessingUtil.java
90.16%
1 Missing and 5 partials :warning:

...vaagent/providers/AwsMetricAttributeGenerator.java
96.89%
2 Missing and 3 partials :warning:

...y/javaagent/providers/AwsSpanMetricsProcessor.java
91.48%
0 Missing and 4 partials :warning:

...t/providers/AttributePropagatingSpanProcessor.java
94.59%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@              Coverage Diff              @@
##               main     #670       +/-   ##
=============================================
- Coverage     85.71%   50.73%   -34.99%
- Complexity       19      264      +245
=============================================
  Files             3       39       +36
  Lines            49     1301     +1252
  Branches          5      141      +136
=============================================
+ Hits             42      660      +618
- Misses            3      609      +606
- Partials          4       32       +28

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update index.md

Popular emacs distro, with a great community!

@Emiller88 Thanks for your contribution. I noticed you removed the PR template information. I am going to close the PR for now. Feel free to re-open it

@damaneice I've fixed the PR to have the template information.


init: ported Get_Last_{Character,Unicode} primitive function

Since a number of level 1 Hestia libraries use string functions, we have to port its primitive ones into HestiaKERNEL library package. Hence, let's do this.
This patch ports Get_Last_{Char,Unicode} primitive function into HestiaKERNEL library in init/ directory.

merge first since production is unaffected.


Some updates for programming_guide.md

Some updates for the section "Program Skeleton" of programming_guide.md

Most of this is good, but in parts, it confuses the DataSet and DataStream API. The DataSet API has no functionality to write to sockets.

ok, update the sockets part.

This looks good, will merge this!

I merged this in 3c1b5f0e7f28d18868e941712d2ca42b140ef3a0 , but forgot the closing message.
Can you manually close this pull request?
Thank you!

ok, done!


Quick-Delete value

It might be useful if a user could quick-delete a cell-value by pressing del or backspace. The former could delete+autocommit the value whereas the later deletes the value and starts the edit-mode. Just as Excel does.

Added to feature list for next version

I studied this item. I understand your reqest as follows. If I start typing with Delete key, the value of the focused cell is deleted. Backspace is reserved for browsing back. However with Delete key this should be possible.

This is included in v0.5.6


Update New-SPSecureStoreServiceApplicationProxy.md

Updated example.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-server/New-SPSecureStoreServiceApplicationProxy.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


build.py no longer functioning with python 2.x

Attempting to run "build.py local" on python 2.7.6 resulted in a failure:
Traceback (most recent call last):
File "./build.py", line 239, in
f.write(time.strftime('%Y-%m-%d %H:%M:%S UTC', utcTime))
TypeError: must be unicode, not str
Same error didn't occur when running manually via python3.

Sounds like a feature, not a bug. :-)

On Oct 13, 2016, at 1:10 PM, microchip<EMAIL_ADDRESS>wrote:
Attempting to run "build.py local" on python 2.7.6 resulted in a failure:
Traceback (most recent call last):
File "./build.py", line 239, in
f.write(time.strftime('%Y-%m-%d %H:%M:%S UTC', utcTime))
TypeError: must be unicode, not str
Same error didn't occur when running manually via python3.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/iitc-project/ingress-intel-total-conversion/issues/1140, or mute the thread https://github.com/notifications/unsubscribe-auth/AFF6kfW9FN-fs5GogxzMBvk4NyIP3s5Vks5qzpA3gaJpZM4KWUA_.

I wouldn't report it but for the readme that says "To build the browser scripts from source you will need Python (either a late version 2.x, or 3.0+). It should build correctly on Linux and Windows (and, probably, Macs, FreeBSD, etc)" ;-)

@microchip I've made a little workaround here. Hope it will help you.

Just to add a data point, the build.py script still works fine for me with Python 2.7.11 on OSX El Capitan 10.11.6.

There was a fix in 0afa46a18cb796e11d92fafa0a71f8d9b65d34fb, which is why it started working again. I'm not sure I like the fix overmuch, but it's still a fix :-)


_flutterTextureId = [registry registerTexture:self]; always returns 0 on iOS

Hi,
after having gotten FlutterWebGL running on Mac now I tried it on iOS which is basically the same code than on MacOS.
Unfortunately when I try to register the Texture I always get back a zero. And even more unfortunately there isn't any debug or NSLog output so that I have no idea what the problem is.
I tried it with current master, which emitted a lot of DebugOutout in Xcode about shaderMain() not found in dylib,
and with the currently stable
[✓] Flutter (Channel stable, 2.0.2, on macOS 11.2.1 20D74 darwin-arm, locale de-DE)
you can try it yourself. you find the registerTexture call here
https://github.com/FlutterGL/flutter_web_gl/blob/f490f8973d765c047f345f8e8988fac433b36f18/ios/Classes/FlutterWebGlPlugin.m#L106
on the branch https://github.com/FlutterGL/flutter_web_gl/tree/register_texture_returns_0_on_iOS
I was testing it on an iPhone 6

0 looks like a valid texture ID on iOS. Are you running into issues compositing this texture in a scene?

Yeah, I don't get anything displayed

OK, after a break I got back to that one and actually 0 is indeed a valid Texture ID but I shot myself in the foot on the Flutter side where I had a check if the ID was already initialized and as all other OSs used values != 0 I had used 0 to mark not initialized.
Which means that https://github.com/FlutterGL/flutter_web_gl now works on Windows, Android, MacOS and iOS.


Hi, I trained on a new coco-like dataset with 7 classes but detection were all wrong

I try to detection trafficlights and trafficsigns, I only using coco config and it's labeling format just like coco, but after training the detection were all wrong.
the location loss around 3.8x, any insights on what's going wrong?
(training on coco actually works and get a very impressive results)

Hello Jinfagang, There could be many reasons for this. The loc loss is pretty large, so I guess the problem is with the bounding box regression. It might be helpful to check some places:

In layers/modules/multibox_loss.py, check that the size of pos after pos = conf_t > 0 is reasonable. It is the number of positive instances and shouldn't be zero or too large.
If the input image size is not 512 or 300, then you may need to modify the config file
In preproc (data/data_augment.py ), There is a normalization process for the boxes, make sure that you get the right shapes here. They shouldn't be too small (<0.01)

@PingoLH Thanks so much for advise. I will have an investigate .

Hi @jinfagang,
Do you have solution for training object detection? I also have same problem?


6782: Button overflow contained to max 100%

additionally, outcommented instructions on how button styling can be increased for Webkit & IE9
See http://open.silverstripe.org/ticket/6782

Thanks for documenting the work in progress as well, good stuff. I'm still hoping to switch to "proper" jQuery UI buttons which don't have this problem as the icon is contained in a separate DOM node which can be floated/cropped - see http://jsfiddle.net/D7mk5/


Unsupported config option for services service: 'metrics'

I am getting this:
$ docker-compose up -d
Unsupported config option for services service: 'metrics'
** running docker version
Server Version: 17.09.1-ce
** docker-compose -version
docker-compose version: 1.4.0

@Aman-Osman-Bose Apologies for this taking so long. I updated the stack today with all the latest components. It should be good to go. Let me know if you have any further issues.


undeclared inclusion(s) for stdlib

Error message on bazel 3.1.0 macosx
 undeclared inclusion(s) in rule '//:libaco':
this rule is missing dependency declarations for the following files included by 'aco.c':  '/private/var/tmp/_bazel_rockwood/220a37e812aa346f6c09d820eb20adae/external/llvm_toolchain/lib64/clang/11.0.2/include/stdint.h'
'/private/var/tmp/_bazel_rockwood/220a37e812aa346f6c09d820eb20adae/external/llvm_toolchain/lib64/clang/11.0.2/include/limits.h'

Those files exist? I'm using absolute_paths = True is there a reason this is happening?

The error message you are getting is because something is missing in the declared builtin include paths. I think we need to add a lib64 directory in addition to the lib directory in these two places:
https://github.com/grailbio/bazel-toolchain/blob/f2d0aeca399e70297414341d228c7be460b4d6a0/toolchain/cc_toolchain_config.bzl.tpl#L504
https://github.com/grailbio/bazel-toolchain/blob/f2d0aeca399e70297414341d228c7be460b4d6a0/toolchain/cc_toolchain_config.bzl.tpl#L514
This could be independent of whether you are using absolute paths or not.
If you are familiar with how to test changes to external repos, can you test it and see if it resolves your problems? I am afraid I am not able to reproduce your issue easily.
As an aside, do you find the absolute paths feature useful? It has been a while since the feature was originally introduced, and there have been improvements in bazel sandbox since, so I was thinking of removing the feature.

@siddharthab Thanks for the speedy reply! I actually only use the absolute paths because without it https://github.com/bazelbuild/rules_foreign_cc/ does not work (I think it runs stuff from a different directory so the paths are incorrect).
Let me add in those patches and test

@siddharthab your suggestion to add lib64 worked! 🎊

Awesome! Can you send a PR?

I have pushed a new tag (0.5.6) which has this fix.


help delphi code

how to put the text that is inside the fr3 file, directly in the delphi code by parameter, so as not to run the risk of deleting the .fr3 file from the project.
frxReport.LoadFromFile(ExtractFilePath(Application.ExeName) +
'\Relatorio\Cadastro\Relatorio_Clientes_Geral.fr3');
frxPDFExport1.FileName := 'Relatorio_Clientes_Geral.PDF';
frxPDFExport1.DefaultPath := ExtractFilePath(Application.ExeName) + '\Temp';
frxPDFExport1.ShowDialog := false;
frxPDFExport1.ShowProgress := false;
frxPDFExport1.OverwritePrompt := false;
frxReport.PrepareReport(true);
frxReport.Export(frxPDFExport1);

Hello @thiagoamaralcaragua !
Here we only answer issue on FastReport Open Source.
But most likely this section of the documentation will help you:
https://www.fast-report.com/public_download/docs/FRVCL/online/en/ProgrammerManual/en-US/Working_with_TfrxReport_component/Creating_a_report_form_from_code.html


fix(openchallenges): set specific div height for 404 page

Fixes #2346
Changelog

set min-height as 100% the viewport's height minus the navbar height
remove unneeded scss definition

Preview

@tschaffter does the 404 page look better on your end with this new parameter?

Another option is to remove the footer altogether from the 404 page (notice the lack of a scroll bar):

See https://github.com/Sage-Bionetworks/sage-monorepo/issues/2346#issuecomment-1806549572

This proposal should already address what you had noted, e.g.
The container starts after the navbar:

The .err-code is well below the navbar:

OK. I have added some padding so that the text is also within the main container:


Can't bypass OpenAI urls

I got modelz running (haven't gotten openmodelz running yet) but it looks like "import openai" poisons something, not sure what, and complain that "any" is not the password, as well as endpoints have changed. Inevitably I'm rediscovering the wheel here and it's already been discussed, perhaps project abandoned, but I thought I should ask as I cannot find the "truth" in reasonable time. Also, has modelz been kinda superseded by some other project?

Hi we do not have the bandwidth to maintain it. Maybe you could take a look at vLLM?

@gaocegege Btw, are you still operating modelz.ai? :)
(When I try to sign up for the hosted LLM, I get timeout.)
If not, do you know a comparable service (private LLM in the cloud with OpenAI compatible embedding API)?

@Boscop Sorry for that. We do not support modelz.ai now. You could have a look at lepton.ai, modal.com, replicate.com


Seed sample users with items in cart to database

💁♂ Problem/Context
Empty database does not allow for complete testing of features.

📖 User Story
As an engineer, I want to have sample customer data so I can test/confirm the UI/UX experience.

🎨 Design
Check wireframe for changes. Below is initial snapshot
https://app.diagrams.net/?src=about#G18skzGTnMW46ACUcShg6LN74jTAucZ8u9

🉑 Acceptance Criteria
Create 3 users, 2 who have products in their cart:

User table

3 unique users created

Carts Table

2 entries w/ associated userID from User Table

1 cart per user

Carts_Products tables

2 tables w/ associated cartID from Carts Table

each Carts_Products table will have 1-5 products in the cart

Products table

products in the 2 carts will have association to Carts_Products page

same product in multiple carts

How do we incorporate tags?

🙅♂ Out of scope
What is not part of the scope? Explicitly mention it

🙈 User Roles
How will it work with different user roles/permissions? (if applicable)

💵 Pricing
What plan will this be available on? (Plan 1, Plan 2 etc.)

🎯 Measuring Success
How do we know we are successful? Do we need new events to track or update existing ones?

🛳 Release Strategy
Are we doing A/B testing? Are we releasing it internally? Are we going straight to General Availability?

❓Other Questions to think about
Do we have experience with this? How it will work with Feature XYZ? Does it our onboarding experience? How long will it take us?

Link to feature: https://shopperettes.productboard.com/feature-board/planning/features/18249153


Send GPS as part of feedback

Provide opt in to send GPS data on feedback form.
Shouldn't change the form functionality.

This issue has been moved to our internal feature request board for further discussion and will be re-opened should it become active in the development pipeline.


App crash on Vault creation

[ ] And also the app crashed on Normal Vault creation

https://github.com/bithyve/bitcoin-keeper/assets/107177634/5f0ef817-7b1b-47d5-95a1-27d84a4e08f5

Not able to reproduce

Completed


[Service Manual] Accessibility and Privacy Statement

Both are currently missing and need to be added to the Service Manual.
Accessibility statement potentially blocked until next DAC assessment (date pending)
Adding to this repo for visibility

Relevant trello tickets:
https://trello.com/c/buoRldNb/593-epic-service-manual-footer-pages - Epic
https://trello.com/c/pBO6pnP0/596-service-manual-accessibility-statement
https://trello.com/c/SJJVW6P5/598-service-manual-terms-and-conditions
https://trello.com/c/vbGrhSZ1/597-service-manual-data-protection

Accessibility statement ticket https://github.com/orgs/ONSdigital/projects/21/views/1?pane=issue&itemId=32860220

Privacy policy needs to go on

Set up meeting with Oscar/Dina(?)/Precious
Check legal contact


bump version for release

bump version for release 0.1.2
cc: @lantiga

If you are skipping making dev release (which is probably not necessary), than this looks good to me :)


Add IRC backend

Add irc utils module
Implement the irc send_message api
Update the config file with irc part
Update the helm chart with irc config

This resolves https://github.com/waynesun09/notify-service/issues/3

@abraverm could you help check?
Thanks

For the error handling, I expect the connection error to be raised and expose to client when send message fail. But as I just checked, with recent update put the connection into future task, the exception did not return to the api call, which I need fix.
The IRC_TARGET could be a user name or a channel name start with '#', I will add comment on that.
SSL is not an issue in my current test, the irc client_aio module did not expose the ssl and ipv6 options though the AioFactory supposed to support them now. So for the ssl and ipv6 connection I will raise a new issue.
The accessMode update is not related to irc, I should have put it in another commit.

What if a user doesn't specify IRC_TARGET?

IRC_TARGET default to None in settings, and the send_message function accept user specify target as option, if user did not specify target it will fallback to default setting, and if default is also None it will raise exception.
Currently the target is a required option in the send_message api, but it's possible for a service to have the target pre-configured.

I would recommend to catch all exceptions, but that is out of scope for this PR.

Updated with caught the connection exception and return to client.


AUTHORS and LICENSE

AUTHORS and LICENSE should have the extension .md or .txt otherwise they are not correctly rendered on GitHub

see #5

Nice one! Merged and closing


Doesn't run in release mode

Video player doesn't seem to work in release mode. Everything works fine in debug mode. I thought this was a bug in our code but when I tried to run the sample app (ChillPlayer) in release mode it kept crashing with the System.PlatformNotSupportedException.
Any ideas on how to fix this?
Thanks

Any update on this?

@adamfisher I found that running UWP with flag "Compile with .NET Native tool chain" for release mode makes the player not work. Having this unchecked the player will work fine. Usually we want this flag checked for UWP release in order to improve performance. The question now is, why does the player not with with native?

@adamfisher I narrowed it down to needing to add the library or assembly with namespace and child elements to the Default.rd.xml file located int he properties folder in the UWP project. Cant figure out the correct format to that, but once thats right it should run with that flag on.


Cant use datatables with webpack BowerWebpackPlugin #513

bower.json has a wildcard character in 'main' section for images: "media/images/*.png".
this leads to the following error:
ERROR in DataTables (bower component)
Module not found: Error: Cannot resolve 'file' or 'directory' ./media/images/*.png in bower_components\DataTables
@ DataTables (bower component) 3:0-31
According to bower specification its not allowed to use a wildcard characters in main sections, instead files should be listed manually

Thanks for flagging this up. Are you able to point me to the browser spec for where it says it doesn't work with wildcards? All I could find doesn't appear to mention it one way or the other.
Not an issue to change it, I'm just curious! I'll merge this into the src repo shortly.

agree, bower spec doesn't say much about using globs. ive found this thread https://github.com/bower/bower.json-spec/issues/30
as far as i can see, having all images listed will make it easier to integrate datatables with gulp/wiredep/webpack

Interesting discussion there. Thanks for the link! For sake of greater compatibility I think it is probably worth just removing the glob.

I've updated my template bower.json file and merged the change with this repo now.
I've also removed the back_* and forward_* images as they haven't been used since v1.9.x. I just forgot to remove them before!
Thanks for bringing this up!


track Swift version used to compile Realm Swift

This will give us a better idea of when it's reasonable to drop older Swift versions. /cc @tgoyne @bdash

cocoapods-setup doesn't call set-swift-version because we'd gone with the explicit separate branches for swift versions with CP, so the file never gets created.

cocoapods-setup doesn't call set-swift-version because we'd gone with the explicit separate branches for swift versions with CP, so the file never gets created.

Right. I suppose we could write the file based on the user's value of xcrun swift --version at cocoapods-setup time, although that will only get updated at each pod install. If https://github.com/apple/swift-evolution/pull/69 lands in Swift 2.2, then this won't be too problematic.
Can you think of a better way to do this? I wouldn't go so far as installing a build phase to update the file in cocoapods-setup.

@tgoyne @bdash CocoaPods fix in place.

:+1:


Deploy PHI deidentifier in Sage Data Hosting Site

Depends on

#45
#37
https://github.com/nlpsandbox/phi-deidentifier/pull/64

Notes:

This app should be deployed on an isolated EC2 that can not interact with the benchmarking infrastructure.
Place a load balancer in front and setup HTTPS

The app is now up and running: https://phi-deidentifier.sagesandbox.org/


PLAT-10885: removed legacy folder from 2.0 branch

Ticket
PLAT-10885
Description
Removed legacy folder form 2.0 branch as legacy SDK in master branch
Checklist

[x] Referenced a ticket in the PR title and in the corresponding section
[x] Filled properly the description and dependencies, if any
[N/A] Unit tests updated or added
[N/A] Docstrings added or updated
[N/A] Updated the documentation in docs folder

Does it make sense for later to have 2.0 in master and legacy in a separate branch, to be consistent with BDK Java?

Yes indeed but I'd prefer to wait until the repo is moved to FINOS before making the change.

Does it make sense for later to have 2.0 in master and legacy in a separate branch, to be consistent with BDK Java?

Yes indeed but I'd prefer to wait until the repo is moved to FINOS before making the change.

Yes we will do that once we release the GA version


[SPARK-5188][BUILD] make-distribution.sh should support curl, not only wget to get Tachyon

When we use make-distribution.sh with --with-tachyon option, Tachyon will be downloaded by wget command but some systems don't have wget by default (MacOS X doesn't have).
Other scripts like build/mvn, build/sbt support not only wget but also curl so make-distribution.sh should support curl too.

Test build #25349 has started for   PR 3988 at commit 83b49b5.

This patch merges cleanly.

Test build #25349 has finished for   PR 3988 at commit 83b49b5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25349/
Test PASSed.

@nchammas Thanks for your advise. I modified to use command command.

Test build #25824 has started for   PR 3988 at commit 1e4c7e0.

This patch merges cleanly.

Test build #25824 has finished for   PR 3988 at commit 1e4c7e0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25824/
Test PASSed.

Test build #25828 has started for   PR 3988 at commit 2db9fbf.

This patch merges cleanly.

LGTM.
@sarutak Did you test this on OS X?

Test build #25828 has finished for   PR 3988 at commit 2db9fbf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25828/
Test PASSed.

@nchammas I confirmed all my changes work but there is another problem in build/mvn, which is not related to my changes. It's a blocker so I separated the PR #4124 to fix the issue.

LGTM pending a minor comment regarding style.

Test build #25841 has started for   PR 3988 at commit a3e908b.

This patch merges cleanly.

Test build #25841 has finished for   PR 3988 at commit a3e908b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25841/
Test PASSed.

Test build #25851 has started for   PR 3988 at commit 7cc8255.

This patch merges cleanly.

Test build #25851 has finished for   PR 3988 at commit 7cc8255.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25851/
Test PASSed.

Test build #25990 has started for   PR 3988 at commit e24e01b.

This patch merges cleanly.

Test build #25990 has finished for   PR 3988 at commit e24e01b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25990/
Test FAILed.

retest this please.

Test build #25994 has started for   PR 3988 at commit e24e01b.

This patch merges cleanly.

Test build #25994 has finished for   PR 3988 at commit e24e01b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25994/
Test FAILed.

retest this please.

Test build #26001 has started for   PR 3988 at commit e24e01b.

This patch merges cleanly.

Test build #26001 has finished for   PR 3988 at commit e24e01b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26001/
Test PASSed.

@sarutak can you bring this up to date?

Test build #26130 has started for   PR 3988 at commit 010e884.

This patch merges cleanly.

Test build #26130 has finished for   PR 3988 at commit 010e884.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26130/
Test PASSed.

It's now up-to-date.

Test build #26205 has started for   PR 3988 at commit 0f546e0.

This patch merges cleanly.

Test build #26205 has finished for   PR 3988 at commit 0f546e0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26205/
Test PASSed.


Agent label

https://github.com/rancher/rancher/issues/12691

Any chance we can see this hit master, for selfish reasons this solves a lot of our problems and is greatly anticipated. A round of applause will be heard throughout the office when this one gets merged.

@steveishorse this will be in our next release. (v2.0.3)


fix: font regression in SQL Lab

SUMMARY

In SQL Lab we wrap the error message in a <MonospaceDiv> to show the error messages with a monospaced font. But this is being dropped if there's a custom error component registered for the error.
I fixed it by passing the monospaced error (subtitle) to the custom error component.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@betodealmeida I think there's also some styling issues when reloading the page. Do you want to add that in this PR too or keep it separate?

I manually tested and it looks good.


Cron job for every 2 minutes.

How can I run a Cron job for every 2 minutes.

*/2 * * * *

Hi,
node-cron is using synchronous or asynchronous ?

Thanq for your support @klinquist klln


FlutterView in a fragment needs to render before fragment transition begins

If an entry/exit animation is assigned to a fragment containing FlutterView, the contents do not show until the animation is complete, leading to a abrupt transition from a black view -> content.
Since it is very common for fragments to perform enter and exit animations, we need to figure out how we can make this transition work. We have an internal example that reproduces this issue within the android_flutter sample app.

I'm not sure how those points relate back to this issue?
Nearly every Android app that partially integrates Flutter will use Fragments, and those Fragments will have some kind of transition.  And I mentioned IO because the trend is only moving more towards Fragment navigation, not away.
If the FlutterView displays visual artifacts simply because its Fragment is moving around the screen, I think that is completely unacceptable and a huge problem.  I'm actually surprised that this isn't a ship blocker for almost everyone right now.  Am I missing something here?  Did I misunderstand this issue?

I opened this issue because I wanted to explore what we intend to support w.r.t. Fragments. However, now I realize that isn't very useful since we will be imagining use cases. It would be better to handle this on a case-by-case basis. I will edit this issue (because it is now linked from a couple of documents) to make it about the specific case I have observed with a client hackathon.

cc @mravn-google to check if this has been resolved already

It has not been resolved. The Flutter module template does away with the black background by making the Flutter view transparent until the first frame is produced by the Dart side. But more work is needed to play nicely with fragment transitions. I have yet to fully understand how they work (e.g. how/when they interact with the view of an incoming fragment).
I'll un-assign myself as I do not have time for this atm.

@mehmetf do you still have the specific use-cases for this ticket that you mentioned in your last comment?

I can observe this with the internal add2app sample. Ping me so I can show you how to build and test it out.

I created a demo of fragment transitions using the new embedding and shared with @mehmetf. The new embedding, when using a TextureView animates FlutterFragments as expected. Therefore, I'm closing this issue.


The client does not remember the password on a rehosted game

Is your feature request related to a problem? Please describe.
I don't know whether it is a bug.
Currently, when you rehost a game that originally had a password set, the rehosted game does not retain that password.
Describe the solution you'd like
I'd like the client to remember that there was a password set.
Describe alternatives you've considered
The workaround is of course to exit and host the game from scratch.

This would be a nice added feature to save us hosts some effort :-).

I think it is a bug lemme check

oh you mean rehost like clicking the rehost button hmm

Definetly is a bug there is logic for it

Sadly I have no FA installed yo I can not check what the casue is

@1-alex98 its definitely possible to rehost but the password is not cached in anyway from what I can tell

I was just saying there is code to do that so it is a bug

I can reproduce it when clicking rehost button but not on the create game dialog ;)


huge numbers for duckType

Describe the bug
some duckTypes of the messages are not normal in version 3. Some values we received are 162, 98, 210, 6.
To reproduce
the data is shown from Owl_HQ
Expected behavior
the duckTypes should be 2 for MamaDucks and 1 for PapaDuck.
Screenshots

Stale issue, hasn't been observed in v4


LinkAssemblies task failed unexpectedly issue

Hi,
I have been googling around with the issue for quite some time but no success.
The current error says:
Severity	Code	Description	Project	File	Line	Suppression State
Error		The "LinkAssemblies" task failed unexpectedly.
Mono.Linker.MarkException: Error processing method: 'System.Linq.ParallelQuery`1 System.Linq.ParallelQuery::Cast()' in assembly: 'System.Core.dll' ---> Mono.Cecil.ResolutionException: Failed to resolve System.Void System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverageAttribute::.ctor()
at Mono.Linker.Steps.MarkStep.HandleUnresolvedMethod(MethodReference reference)
at Mono.Linker.Steps.MarkStep.MarkMethod(MethodReference reference)
at Mono.Linker.Steps.MarkStep.MarkCustomAttribute(CustomAttribute ca)
at Mono.Linker.Steps.MarkStep.MarkCustomAttributes(ICustomAttributeProvider provider)
at Mono.Linker.Steps.MarkStep.ProcessMethod(MethodDefinition method)
at Mono.Linker.Steps.MarkStep.ProcessQueue()
--- End of inner exception stack trace ---
at Mono.Linker.Steps.MarkStep.ProcessQueue()
at Mono.Linker.Steps.MarkStep.ProcessEntireQueue()
at Mono.Linker.Steps.MarkStep.Process()
at Mono.Linker.Steps.MarkStep.Process(LinkContext context)
at Mono.Linker.Pipeline.Process(LinkContext context)
at MonoDroid.Tuner.Linker.Process(LinkerOptions options, ILogger logger, LinkContext& context)
at Xamarin.Android.Tasks.LinkAssemblies.Execute(DirectoryAssemblyResolver res)
at Xamarin.Android.Tasks.LinkAssemblies.Execute()
at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
at Microsoft.Build.BackEnd.TaskBuilder.d__26.MoveNext()
OS: Windows Server 2012 R2
VS Version:

Android Version:

@anobik: You are getting this error in Visual Studio. This is not related to VSTS tasks or the Hosted build VMs. Please search for resolution in https://bugzilla.xamarin.com/ or https://forums.xamarin.com/categories/visual-studio
Thanks,
Madhuri

@madhurig  I'll be sharing error screen shots from VSTS task / hosted build also. Please reopen the issue.
Both of the places issue is coming.
Thanks,
Anobik

@anobik: If the build is failing on your developer machine, there is a configuration issue or bug in your project. We wouldn't expect it to work in VSTS builds. Did you try turning off linking in your project?

@madhurig
The screen shot is from VS in build machine running in Windows server 2012. There's no issue with Dev box. Also we need to link the sdk so cannot turn linking off.
Please suggest.

@madhurig
Also if you can advice. Should I add a new issue referring to this issue since this is closed ?

@anobik : You can use this issue if VSTS build continues to fail after your local build works.

@madhurig
Please let me know all the details required.
My local build works fine. The only difference is in dot net framework version.
If you need I'll provide a screen shot of the same.
Build machine : 4.6.2
Local machine: 4.7

This is the information we request on new issues:
Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Environment

Server - VSTS or TFS on-premises?

If using TFS on-premises, provide the version:

If using VSTS, provide the account name, team project name, build definition name/build number:

Agent - Hosted or Private:

If using Hosted agent, provide agent queue name:

If using private agent, provide the OS of the machine running the agent and the agent version:

Issue Description
[Include task name(s), screenshots and any other relevant details]
Error logs
[Insert error from the logs here]

Give me some time. Will revert back with all possible details.

We are using a private agent running on Windows Server 2012.
Here's a screenshot

Following is the build definition, copied directly from batch file
"C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/MSBuild/15.0/Bin/MSBuild.exe" /t:restore "Android.sln"
"C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/MSBuild/15.0/Bin/MSBuild.exe" /nologo Android.sln" /p:SkipInvalidConfigurations=true   /p:VisualStudioVersion=15.0 /p:Configuration="ObRelease" /p:Platform="Any CPU"  /p:GenerateProjectSpecificOutputFolder=False
I have put to build would attach the log once finished.

Here's the build log
1_Build.txt

@anobik : Your logs looks very different from current VSTS build logs. Please provide this additional information about your environment.

Server - Are you using VSTS or TFS? If you are using VSTS, what account/teamproject/build definition? If using TFS, what version of TFS?

Agent: You said you are using a private agent on Windows Sever 2012. What is the agent version?
You can get full build logs from your build and send them to us.

Are you using the Xamarin Android task? It looks like you have some script that invokes VSBuild.

If you run these commands from a command line manually on the private agent machine, do they succeed or fail? If they fail, there is some dependency not installed on your private agent. You will need to investigate the missing dependency and install it. Make sure you have latest updates of VS and Xamarin.
C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/MSBuild/15.0/Bin/MSBuild.exe" /t:restore "Android.sln"
"C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/MSBuild/15.0/Bin/MSBuild.exe" /nologo Android.sln" /p:SkipInvalidConfigurations=true /p:VisualStudioVersion=15.0 /p:Configuration="ObRelease" /p:Platform="Any CPU" /p:GenerateProjectSpecificOutputFolder=False
Thanks,
Madhuri

@anobik: The error seems to suggest you don't have some Android SDK version you are targeting from the project installed on your build server or you are not targeting the right version of Java.
Are you using the Xamarin Android task? There is an option on the Xamarin Android task to target Java 8.
Based on the logs you are not using VSTS and are on a very old version of the agent. Can you try upgrading your agent to a newer version to get better logging.
Thanks,
Madhuri

Yes we are using xamarin Android task. For upgrading i need to check with some other people. Meanwhile I'll try checking all the Android platforms in the project and the server.

Have run into another problem, it shows javac.exe error cannot find symbol

1_Build.txt
Heres the new Log.

Current TFS ersion
Microsoft Visual Studio Team Foundation Server
Version 14.102.25423.0
© Microsoft Corporation. All rights reserved.

It looks like you are using TFS 2015 Update 3 and trying to build a Xamarin Android app in Visual Studio 2017. I am not sure what the javac error is but new versions of Xamarin require using Java 8. Please ensure you have Java 8 installed and if you have multiple Java versions installed on the agent, you can pass an additional msbuild argument to the Xamarin Android task to pick the right version of Java.
/p:JavaSdkDirectory=<Java8_SDK_DIR>

@anobik : Have you resolved your issue? As far as I can tell, it is a dependency installation issue on your build server.

Closing since we are pretty sure this is a dependency installation issue on the build server and the thread has not had updates in a month.

@anobik: I am sorry none of the suggestions helped. For further support on xamarin toolset reach out at https://forums.xamarin.com/ or open bugs on https://bugzilla.xamarin.com/.
Thanks,
Madhuri


[DEMO - DO NOT MERGE] Safari fix test

Tested successfully here. Fixed by https://github.com/microbit-foundation/micropython-microbit-v2-simulator/pull/99 in the simulator repo.


Fix open3d install when cache folder name contains space

Fixes the issue of pip_install splitting up input wheel path at spaces.
See https://discourse.slicer.org/t/installing-open3d-is-giving-an-error/17978/10?u=lassoan

Awesome, thank you Andras


Makefile and protobuf tweaks

fix broken make protobufs
gogo customname some fields to be more idiomatic in their Golang form
revisit gogo nullable for fields that reference enum types. document current thinking
compare against latest Mesos 1.0.x tree for differences -- none found!

Coverage decreased (-0.2%) to 36.559% when pulling 47a79617bd954e3b360bea1015c6292f2cc1aee5 on jdef_fix_make_protobufs into 42e45a820ca7a7953c34c62c9b29b545e2275b0b on master.

fun failure w/ golang-tip:
13.83s$ make install
go install github.com/mesos/mesos-go/api/v1/cmd/example-executor github.com/mesos/mesos-go/api/v1/cmd/example-scheduler
# github.com/mesos/mesos-go/api/v1/lib/httpcli/httpsched
api/v1/lib/httpcli/httpsched/state.go:73:19: internal compiler error: cannot inline function containing closure:
.   CLOSURE l(44) ff(1) tc(1) httpsched.maybeLogged.func1 FUNC-func(*http.Request) (*http.Response, error)

I'd really like to clean up that module anyway. Funny that golang has a problem with it


Race condition in sending code - delivering truncated messages

I have a fairly simple application that does the following:
pub := misc.NanomsgPub(nanomsgOutAddr)

var tmpBuffer [4096 + 16]byte
for {
		n, addr, err := udp.ReadFromUDP(buf)
		data := buf[:n]

			t := tmpBuffer[:]
			copy(t, data)
			data = t[:len(data)]

		err = pub.Send(data)
}

Where the nanomsgpub is:
func NanomsgPub(nanomsgOutAddr string) mangos.Socket {
	pub, err := mangospub.NewSocket()
	if err != nil {
		fmt.Fprintf(os.Stderr, "[!] nanomsg.NewSubSocket() %v\n", err.Error())
		os.Exit(3)
	}

	pub.SetOption(mangos.OptionWriteQLen, 2048)
	pub.SetOption(mangos.OptionReadQLen, 2048)
	pub.SetOption(mangos.OptionNoDelay, false)

	if strings.HasPrefix(nanomsgOutAddr, "ipc:///") {
		// ignore error
		os.Remove(nanomsgOutAddr[6:])
	}

	fmt.Fprintf(os.Stderr, "[+] Publishing to nanomsg SUB on %q\n", nanomsgOutAddr)
	pub.AddTransport(ipc.NewTransport())
	pub.AddTransport(tcp.NewTransport())
	if err := pub.Listen(nanomsgOutAddr); err != nil {
		fmt.Fprintf(os.Stderr, "[!] nanomsg.Listen(%q) %v\n", nanomsgOutAddr, err.Error())
		os.Exit(3)
	}
	return pub
}

Sadly, when reading messages from the ipc endpoint, many are:

truncated
have additional data dangling

This goes away when I switch to go-nanomsg library. I suspect mangos doesn't copy the data from the given buffer when I do "send", and I overwrite the data soon on next loop iteration. Also, the application is pretty high volume (tens of thousands messages a second)

Sounds ugly.  I'll have a look.  Does this happen if you switch to TCP?  Are both sender and receiver mangos?  Does it make a difference which one you change?  What are the message sizes?
Sent from my iPhone

On Jul 17, 2015, at 7:59 AM, Marek<EMAIL_ADDRESS>wrote:
I have a fairly simple application that does the following:
pub := misc.NanomsgPub(nanomsgOutAddr)
var tmpBuffer [4096 + 16]byte
for {
n, addr, err := udp.ReadFromUDP(buf)
data := buf[:n]
        t := tmpBuffer[:]
        copy(t, data)
        data = t[:len(data)]

    err = pub.Send(data)

}
Where the nanomsgpub is:
func NanomsgPub(nanomsgOutAddr string) mangos.Socket {
pub, err := mangospub.NewSocket()
if err != nil {
fmt.Fprintf(os.Stderr, "[!] nanomsg.NewSubSocket() %v\n", err.Error())
os.Exit(3)
}
pub.SetOption(mangos.OptionWriteQLen, 2048)
pub.SetOption(mangos.OptionReadQLen, 2048)
pub.SetOption(mangos.OptionNoDelay, false)

if strings.HasPrefix(nanomsgOutAddr, "ipc:///") {
    // ignore error
    os.Remove(nanomsgOutAddr[6:])
}

fmt.Fprintf(os.Stderr, "[+] Publishing to nanomsg SUB on %q\n", nanomsgOutAddr)
pub.AddTransport(ipc.NewTransport())
pub.AddTransport(tcp.NewTransport())
if err := pub.Listen(nanomsgOutAddr); err != nil {
    fmt.Fprintf(os.Stderr, "[!] nanomsg.Listen(%q) %v\n", nanomsgOutAddr, err.Error())
    os.Exit(3)
}
return pub

}
Sadly, when reading messages from the ipc endpoint, many are:
truncated
have additional data dangling
This goes away when I switch to go-nanomsg library. I suspect mangos doesn't copy the data from the given buffer when I do "send", and I overwrite the data soon on next loop iteration. Also, the application is pretty high volume (tens of thousands messages a second)
—
Reply to this email directly or view it on GitHub.

On Jul 17, 2015, at 8:06 AM, Garrett D'Amore<EMAIL_ADDRESS>wrote:
Sounds ugly.  I'll have a look.  Does this happen if you switch to TCP?  Are both sender and receiver mangos?  Does it make a difference which one you change?  What are the message sizes?

While the symptoms you describe would be explained by your hypothesis, I just checked the code and I don’t think that’s the case.  The send routine is pretty darn simple, and it does perform a data copy into a separate Message.  I also run this code with the test suite with the race checker turned on, and believe me, when I’ve had races, it does an excellent job of finding and reporting them.  Here’s the Send routine:
func (s *Socket) Send(b []byte, flags int) (int, error) {
    if flags != 0 {
            return -1, errNoFlag
    }

    m := mangos.NewMessage(len(b))
    m.Body = append(m.Body, b...)

    // Legacy nanomsg uses the opposite semantic for negative and
    // zero values than mangos.  A bit unfortunate.
    switch {
    case s.sto > 0:
            s.sock.SetOption(mangos.OptionSendDeadline, s.sto)
    case s.sto == 0:
            s.sock.SetOption(mangos.OptionSendDeadline, -1)
    case s.sto < 0:
            s.sock.SetOption(mangos.OptionSendDeadline, 0)
    }

    return len(b), s.sock.SendMsg(m)

}
Btw, all the finagling you’re doing with temp buffers is unnecessary.  You can just do:
err = pub.Send(buf[:n])
I think that would be easier to reason about than the copies you’re making into additional scratch buffers, etc.  It would also be faster.  I’m assuming that you are doing these in a single threaded loop as you’ve described, and there isn’t some level of async going on that you’ve not included.  The difference in indentation level makes me wonder what code you’ve removed.
While I’m not saying that mangos doesn’t have a bug here (it may well have), it would be good to know that our test case is minimally complex so that we fully exonerate it and lay the blame squarely on mangos.
- Garrett

Sent from my iPhone
On Jul 17, 2015, at 7:59 AM, Marek<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:

I have a fairly simple application that does the following:
pub := misc.NanomsgPub(nanomsgOutAddr)
var tmpBuffer [4096 + 16]byte
for {
n, addr, err := udp.ReadFromUDP(buf)
data := buf[:n]
        t := tmpBuffer[:]
        copy(t, data)
        data = t[:len(data)]

    err = pub.Send(data)

}
Where the nanomsgpub is:
func NanomsgPub(nanomsgOutAddr string) mangos.Socket {
pub, err := mangospub.NewSocket()
if err != nil {
fmt.Fprintf(os.Stderr, "[!] nanomsg.NewSubSocket() %v\n", err.Error())
os.Exit(3)
}
pub.SetOption(mangos.OptionWriteQLen, 2048)
pub.SetOption(mangos.OptionReadQLen, 2048)
pub.SetOption(mangos.OptionNoDelay, false)

if strings.HasPrefix(nanomsgOutAddr, "ipc:///") {
    // ignore error
    os.Remove(nanomsgOutAddr[6:])
}

fmt.Fprintf(os.Stderr, "[+] Publishing to nanomsg SUB on %q\n", nanomsgOutAddr)
pub.AddTransport(ipc.NewTransport())
pub.AddTransport(tcp.NewTransport())
if err := pub.Listen(nanomsgOutAddr); err != nil {
    fmt.Fprintf(os.Stderr, "[!] nanomsg.Listen(%q) %v\n", nanomsgOutAddr, err.Error())
    os.Exit(3)
}
return pub

}
Sadly, when reading messages from the ipc endpoint, many are:
truncated
have additional data dangling
This goes away when I switch to go-nanomsg library. I suspect mangos doesn't copy the data from the given buffer when I do "send", and I overwrite the data soon on next loop iteration. Also, the application is pretty high volume (tens of thousands messages a second)
—
Reply to this email directly or view it on GitHub https://github.com/gdamore/mangos/issues/139.

https://gist.github.com/majek/5ad981a6f647719a9749
marek@ubuntu-saucy:~/cloudflare/gatewatcher$ ./a
[+] Publishing to nanomsg SUB on "ipc:///tmp/xx"
[+] Receiving from nanomsg PUB on "ipc:///tmp/xx"
data=116 len=33
data=116 len=15
data=116 len=199
data=116 len=187
data=116 len=129
data=116 len=134
data=116 len=57
data=116 len=172
data=116 len=72
data=116 len=164

Your gist was very helpful.  I will investigate and be back in touch soon.  Btw what platform and go version are you using?  I don't think it's tied to that but in case I have trouble reproducing knowing where you hit it might help.

Ok, so I've found the bug.  It wasn't in compat, it was in the simplistic Send()/Recv() interfaces.  Note that I pretty much never use those interfaces as they are suboptimal from a performance standpoint (extra data copies).  I've got a fix, writing a formal test case for it, and will integrate the fix shortly.

awesome. thanks


Feature Request: protocol polymorphism with the same variable name

Effectively the problem is, if I have a concrete type backed by multiple protocols, I want to be able to inherit sub-definitions of that protocol down the tree.
In a tree [A] -- [B] -- [C]
If node A defines:
// weaver: userManager = UserManager <- UserStateProviding & UserStateManaging
// weaver: userManager.scope = .transient
// weaver: userManager.builder = UserManager.make

and node B defines:
// weaver: userManager <- UserStateProviding

and node C defines:
// weaver: userManager <- UserStateManaging

Then the compiler will complain that the types do not match.

Addressed in #121


Also respect "exotic" node address types when auto-approving kubelet server CSRs

How to categorize this PR?

/area usability
/kind bug
What this PR does / why we need it:
The CertificateSigningRequests created by kubelets for their server certificates are now also auto-approved when their Node object contains addresses of type InternalDNS, ExternalDNS, or ExternalIP.
Which issue(s) this PR fixes:
Introduced with #6784
Release note:

The `CertificateSigningRequest`s created by `kubelet`s for their server certificates are now also auto-approved when their `Node` object contains addresses of type `InternalDNS`, `ExternalDNS`, or `ExternalIP`.

/cherry-pick release-v1.58

/cherry-pick release-v1.59

/kind regression

cc @acumino as release responsible - once this is cherry-picked we should provide some hotfix releases


Fix deploy to gh-pages

This PR changes a bit how the rendered API blueprint is deployed to Github Pages. The default mechanism is this: travis will checkout gh-pages branch and then copy all the content from the folder selected in .travis.yml to the root folder. This will overwrite all previous files - the 'keep_history' flag means that a normal push will be performed, instead of a 'push force', which will rewrite commit history. As we want all the rendered API blueprints, this is not we are looking for.
This PR implements such deployment in a way that we can still retrieve the previous rendered versions of API blueprints - so that we can point to them from readthedocs documentation.

There are problems still.


Implementing auto indent formatting rule

Fixes Issue

Closes #20
Description

Remove Dummy formater
Add Auto indent formater as discussed in #20

Check List (Check all the applicable boxes)

[x] I understand that my contributions needs to pass the checks.
[x] If I created new functions / methods, I documented them and add type hints.
[x] If I modified already existing code, I updated the documentation accordingly.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Example of auto indent:

Note to reviewers

Thanks for the contribution @ldevillez!


Implement pagination improvements(# 9102)

In response to issue #9102 :

Inline JavaScript in https://github.com/wagtail/wagtail/blob/main/docs/_templates/search.html has been moved to separate external JS file
onclick events has been replaced with addEventListener events
Now one button per page is displayed, Page 2 of 7, along with a previous and a Next button

Adding another PR with resolved lint errors

@akshay-gupta7 you can push your changes to the existing branch akshay-gupta7:pagination-update and this PR should pick up the changes without the need to open a new PR

@zerolab , thank you for the suggestion.
However, I have already opened a fresh PR. Let me if I should close the new one and reopen this PR.

No need, it is done now. but do keep that in mind for the future.

Definitely, shall keep this in mind @zerolab.


[AMD-AIE] Add a pass to tile and fuse TileInterface ops using scf.forall

-- This commit adds the initial effort for tiling + fusing TileInterface ops using scf.forall by creating a new pass --iree-amdaie-tile-and-fuse.
-- It creates a new concise transform dialect script and adds a --iree-amdaie-tile-and-fuse test case to demo the generalised feature.
Co-authored-by: Nirvedh Meshram<EMAIL_ADDRESS>Co-authored-by: Abhishek Varma<EMAIL_ADDRESS>

I haven't compared this to the original pad transform dialect script. Could you summarize what has been changed?

Sure, the change is only the first level of tiling and fusing where the tile_size=8x8.
In the new transform dialect script we were able to get rid of these exact lines and in turn depend on the C++ pass.

@MaheshRavishankar  Is there a reason bufferization done in the transform dialect (matmul_fill_spec_pad.mlir)? Can it be done as a separate pass in Passes.cpp?


Error while updating property 'textAlign' in shadow node of type: RCTVirtualText

Description
This issue tracked by Sentry and it's happened only few times, but will be good if it's possible to fix.

As you can see it's crashed because textAlign property is not correct. But I don't have property 'start' in my code.
React Native version:
0.62.2

impossible to solve without reproducible example

Hi, i got the same issue. I think this issue occurred because of trying to render html through web view. You can read the full explanation here

Yes, I found problem. There was HTML code with css style { text-align: start }.

Hi! I have the same problem. Is there any solution? My app crashing because of this.
Thanks!


Increment Version

@JuliaRegistrator register() ACTRModels v0.6.2

Registration pull request created: JuliaRegistries/General/27199
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.6.2 -m "<description of version>" f745cc2cf10561c6a8dda93a73419b0abb7519b1
git push origin v0.6.2

Registration pull request created: JuliaRegistries/General/27199
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.6.2 -m "<description of version>" f745cc2cf10561c6a8dda93a73419b0abb7519b1
git push origin v0.6.2


Question about upstreams

Hello, Sorry for the simple question, but I didn't found something related with this.
I know that you can define some upstreams with different context (/App1, /App2) in order to create some routing logic, but I have some problems with this configuration.
When I use the following configuration in the upstreams.
 upstreams = [
     "http://server1/App1",
     "http://server2/App2" ]

Routing is working but the context "/Appx" is also sent to the server, can I avoid this? I mean... using the configuration that I posted but when an user call oauth2_proxy with App1 context, the "ProxyPass" request go for http://server1/ instead of http://server1/App1.

The primary options you have are to a) use subdomains so you have app1.domain.com and app2.domain.com and set your cookie_domain to .domain.com so they can share authentication, or b) set your upstream as an intermediate nginx endpoint and configure request/response url rewriting there.

@jehiah thanks for the answer.
With the option a) you mean have something like this?
 upstreams = [
     "http://app1.company.com",
     "http://app2.company.com" ]

If you mean that I've already tried ir and the application returns the following trace.
panic: http: multiple registrations for /

goroutine 1 [running]:
net/http.(*ServeMux).Handle(0xc20800b020, 0x7c4810, 0x1, 0x7fd79a471568, 0xc20801ee60)
	/usr/local/Cellar/go/1.4.2/libexec/src/net/http/server.go:1557 +0x244
main.NewOauthProxy(0xc20800cd80, 0xc20801eca0, 0x1)
	/Users/jehiah/projects/tmp_build/src/github.com/bitly/oauth2_proxy/oauthproxy.go:98 +0x3d3
main.main()
	/Users/jehiah/projects/tmp_build/src/github.com/bitly/oauth2_proxy/main.go:92 +0x14c7

goroutine 2 [runnable]:
runtime.forcegchelper()
	/usr/local/Cellar/go/1.4.2/libexec/src/runtime/proc.go:90
runtime.goexit()
	/usr/local/Cellar/go/1.4.2/libexec/src/runtime/asm_amd64.s:2232 +0x1

goroutine 3 [runnable]:
runtime.bgsweep()
	/usr/local/Cellar/go/1.4.2/libexec/src/runtime/mgc0.go:82
runtime.goexit()
	/usr/local/Cellar/go/1.4.2/libexec/src/runtime/asm_amd64.s:2232 +0x1

goroutine 4 [runnable]:
runtime.runfinq()
	/usr/local/Cellar/go/1.4.2/libexec/src/runtime/malloc.go:712
runtime.goexit()
	/usr/local/Cellar/go/1.4.2/libexec/src/runtime/asm_amd64.s:2232 +0x1

I understand is normal behaviour the application doesn't allow two routing paths pointing to "/"
Probably for now I will use multiple instances of oauth2_proxy for each application on my internal network. Again thanks for all.

For a one-cookie-multiple-domain example, check out the 18F/hub SSO configuration, inspired by #12. It is a little subtle, but very effective. The one thing the README doesn't get into is the individual location definitions; you can see those in the 18F/hub nging vhost configs.

The implementation that I've done is fine for now, thanks for the help to everyone!


Integrating the tracking of open events on the Android side of the example.

Checklist

[X] I have read the contributing guidelines
[X] This issue hasn't been addressed in an existing issue or pull request

Description
The documentation for integrating the tracking of open events is not clear, as native Kotlin projects and React Native have different architectures.

Proposed Solution
I'm writing to ask for further explanation in the documentation, along with a demonstration on the Android side of the example.

Alternatives Considered
No response
Additional Context
No response

Hi, the short answer is that on both platforms we require you to write native code to handle push opens because notification opens are handled very differently by platform. That is why we link to our native SDKs' documentation.
For Android that will mean handling an intent from the main activity. I will work on an example app update for the android side to demonstrate, but wanted to answer you sooner than later.

Hmm which version of the RN SDK? And I bet you're initializing from typescript code?

Can you see error output in logcat? This is probably a timing issue of invoking Klaviyo prior to initializing, going to have to think about how we can work around that.

@evan-masseau yes, I'm initializing the SDK on the React Native side. Do you still need the logs?

@youcefswoo I can probably get started with this much detail. Thank you for all your contributions, I'll update as soon as I can!

@evan-masseau I switched the initialization of the SDK on the native side to make the tap on notifications work. So, it's not a bug, but I believe it would be beneficial for the SDK to offer a way to perform tracking on the React Native side as well.

Fully agree, my first goal will be to enable the open tracking on Android without requiring you to also move your initialization logic. Tracking opens for both platforms from react native code is a harder lift, so I'm going to consider that a separate goal.

With our latest release, 0.4.2, the timing issue related to tracking an opened push event and initializing Klaviyo SDK from react native code should now be resolved. We now hold that event in memory until Klaviyo gets initialized to work around this platform/timing limitation. Thanks for bearing with us, we'll continue to consider options for tracking this event from react native code, however as I mentioned before doing that in a cross-platform way is going to be tricky.

@evan-masseau I switched the initialization of the SDK on the native side to make the tap on notifications work. So, it's not a bug, but I believe it would be beneficial for the SDK to offer a way to perform tracking on the React Native side as well.

Fully agree, my first goal will be to enable the open tracking on Android without requiring you to also move your initialization logic. Tracking opens for both platforms from react native code is a harder lift, so I'm going to consider that a separate goal.

hi @evan-masseau , any news regarding offering open tracking capabilities on RN? I am currently working on an expo app and doing this from a managed expo isnt the most trivial i would say.

Hi @evan-masseau is there any further update on this? this would be great if we could get access to this within RN


extension testing doesn't work on Linux

With vscode version 1.1.32 it doesn't work. see
$ npm test --silent
### VS Code Extension Test Run ###
Current working directory: /home/travis/build/matepek/vscode-catch2-test-adapter
Downloading VS Code into "/home/travis/build/matepek/vscode-catch2-test-adapter/.vscode-test/stable
Downloading VS Code 1.32.3
Downloaded VS Code 1.32.3
Running extension tests: /home/travis/build/matepek/vscode-catch2-test-adapter/.vscode-test/vscode-1.32.3/VSCode-linux-x64/code /home/travis/build/matepek/vscode-catch2-test-adapter/out/test --extensionDevelopmentPath=/home/travis/build/matepek/vscode-catch2-test-adapter --extensionTestsPath=/home/travis/build/matepek/vscode-catch2-test-adapter/out/test --locale=en
Failed to execute tests: Error: spawn /home/travis/build/matepek/vscode-catch2-test-adapter/.vscode-test/vscode-1.32.3/VSCode-linux-x64/code ENOENT

I changed the version to 1.1.30. IT works again. see
diff

I have the same problem, and 1.1.31 works forks for me.

@octref can you follow up?

I think I'm experiencing the same thing.
My testing on Travis CI has stopped working for Linux builds but is still fine for MacOS.  My Windows Appveyor builds are fine also.
Running extension tests: /home/travis/build/lingua-pupuli/puppet-vscode/.vscode-test/vscode-1.32.3/VSCode-linux-x64/code /home/travis/build/lingua-pupuli/puppet-vscode/out/test --extensionDevelopmentPath=/home/travis/build/lingua-pupuli/puppet-vscode --extensionTestsPath=/home/travis/build/lingua-pupuli/puppet-vscode/out/test --locale=en
Failed to execute tests: Error: spawn /home/travis/build/lingua-pupuli/puppet-vscode/.vscode-test/vscode-1.32.3/VSCode-linux-x64/code ENOENT
Tests exited with code: -2
The command "npm test --silent" exited with 1.

https://travis-ci.com/lingua-pupuli/puppet-vscode/jobs/186261001
Travis CI doesn't mention any recent major changes in it's builder changelog at https://docs.travis-ci.com/user/build-environment-updates/

Initially I though it was because Travis is using an older version on Nodejs

Now using node v8.11.3 (npm v5.6.0)

However both the MacOS and Linux builds are the same.

Oh I have a suspicion of what it is.... Just testing it out now.  I think there's an extra directory in the downloaded path ...

Hrmm... well that's weird.  I added some ls commands to see what was on disk in the Travis builder and apparently .vscode-test is empty.
### VS Code Extension Test Run ###
Current working directory: /home/travis/build/lingua-pupuli/puppet-vscode
Downloading VS Code into "/home/travis/build/lingua-pupuli/puppet-vscode/.vscode-test/stable
Downloading VS Code 1.32.3
Downloaded VS Code 1.32.3
Running extension tests: /home/travis/build/lingua-pupuli/puppet-vscode/.vscode-test/vscode-1.32.3/VSCode-linux-x64/code /home/travis/build/lingua-pupuli/puppet-vscode/out/test --extensionDevelopmentPath=/home/travis/build/lingua-pupuli/puppet-vscode --extensionTestsPath=/home/travis/build/lingua-pupuli/puppet-vscode/out/test --locale=en
Failed to execute tests: Error: spawn /home/travis/build/lingua-pupuli/puppet-vscode/.vscode-test/vscode-1.32.3/VSCode-linux-x64/code ENOENT
Tests exited with code: -2
The command "npm test --silent" exited with 1.
0.00s$ ls -al .vscode-test
total 8
drwxrwxr-x  2 travis travis 4096 Mar 21 07:49 .
drwxrwxr-x 15 travis travis 4096 Mar 21 07:49 ..
The command "ls -al .vscode-test" exited with 0.
0.00s$ ls -al .vscode-test/vscode-1.32.3/VSCode-linux-x64
ls: cannot access .vscode-test/vscode-1.32.3/VSCode-linux-x64: No such file or directory
The command "ls -al .vscode-test/vscode-1.32.3/VSCode-linux-x64" exited with 2.

Okay...so some initial digging.

The https://github.com/Microsoft/vscode-extension-vscode repo which holds that npm module has changed it's tagging system from 1.1.30 to v.1.1.32 which may be coincidental.

The release dates for vscode on npmjs shows that 1.1.31 and 1.1.32 shortly thereafter were only a day ago so that explains why things have suddenly gone bad.  1.1.30 was a month ago.
A quick look at the diff between the two....
https://github.com/Microsoft/vscode-extension-vscode/compare/1.1.30...v1.1.32
Shows some major work on the bin/test file shows that the functionality seems to have moved to a vscode-test module (https://www.npmjs.com/package/vscode-test) which is VERY new (7 days ago)
Interestingly is this line: https://github.com/Microsoft/vscode-extension-vscode/compare/1.1.30...v1.1.32#diff-f900621cc6a1719b5473baf0191f297bR12
It says that the testing should be in the stable folder which clearly doesn't exist in my example above.  It did exist on my Ubuntu 18.04 desktop though
Given the following log from a job
Downloading VS Code into "/home/travis/build/lingua-pupuli/puppet-vscode/.vscode-test/stable
Downloading VS Code 1.32.3
Downloaded VS Code 1.32.3

My hunch is that unzipVSCode (https://github.com/Microsoft/vscode-test/blob/master/lib/download.ts#L127) is failing silently.

My bad, I just realized, fs.mkdirSync is not available in Node < 10.
So this line was failing: https://github.com/Microsoft/vscode-test/blob/master/lib/download.ts#L40

One more note. I tried to use the CODE_VERSION environment variable feature and noticed that if I change the version and I did run it with a different version before it won’t download the new version, it will just use the already downloaded one. I didn’t expect this behaviour.

@matepek That'll be handled with https://github.com/Microsoft/vscode-extension-vscode/pull/155.
I'll try to keep existing env variables working, but they are implicit and I think it's better to move to https://github.com/microsoft/vscode-test in the long term.

@octref oh i see, it is new..

This should be working again in<EMAIL_ADDRESS>
https://travis-ci.org/octref/hellotest/builds/509629532
https://github.com/octref/hellotest

Also I restored support for CODE_VERSION in 1.33.


[Estimote] Update the Android binding to 1.0.3

Fixing the sample so that it compiles
Mostly namespace changes with a few class name changes
Removing the Permissions file from the binding project
as I believe that we now merge the AndroidManifest from the
aar file

[ ] I need to update the icon in the nuspec
[ ] We audit TP license and packaging


Add pending tests for changing inherited type in sealed trait children.

IncHandler now understands scalac options.
Add pending tests for changing inherited type in sealed trait children.
This was found during #267 and is a problem also there.

Property `scalac.options` in incOptions.properties is now passed as options to scalac (value is splitted using ` +` regexp). added to commit message. Is anything more required?

Thanks!
No, don't think so. Let's wait for another signoff.

Ping @eed3si9n | @dwijnand.


Stack name renamed without "-" in 2.9.0

On Docker Swarm Engine : 20.10.8
Portainer-ce Version : 2.9.0
When i create new stack with portainer interface :
Stacks => + Add Stack
If stack's name contains "-" (ex: my-nice-stack) when i "deploy the stack", the stack's name does'nt contains "-" (ex: mynicestack).
Thanks

That was changed to avoid other issues: https://github.com/portainer/portainer/issues/5153
Basically because of compose limitations: https://github.com/portainer/portainer/issues/5620#issuecomment-922592187

I think the issue was "over-fixed" unfortunately. The regex used in PR #5236 is:
regexp.MustCompile("[^a-z0-9]+")

Which eliminates anything but [a-z0-9], not just capital letters or spaces as stated by the PR's title.
Dashes - and underscores _ are perfectly valid characters that we also commonly use in our stack names to visually "group" them by scope. They should not be removed by Portainer, specially not silently on deploy.

Yes, I think that "-" and "_" are valid and usefull for visibility.
In my case, i have 33 containers with names like ems-moodle-lyon more readable than emsmoodlelyon.

From Docker Compose:
re.sub(r'[^a-zA-Z0-9]', '', project)

https://github.com/docker/compose/pull/211/files#

Removing the dash is quite detrimental to cross swarm host name requests. It's quite a non-backwards compatible breaking change.

I've done some playing with this.
Docker Standalone:
This is working fine:
docker-compose -p "kebab-stack" up
docker-compose -p "snake_stack" up
This however is not allowed:
docker-compose -p "space stack" up
docker-compose -p "test~stack" up
docker-compose -p "test#stack" up
Swarm
This is working fine:
docker stack deploy --compose-file docker-compose.yml "kebab-stack"
docker stack deploy --compose-file docker-compose.yml "snake_stack"
This however is not allowed:
docker stack deploy --compose-file docker-compose.yml "space stack"
docker stack deploy --compose-file docker-compose.yml "test~stack"
docker stack deploy --compose-file docker-compose.yml "test#stack"
docker stack deploy --compose-file docker-compose.yml "test.stack"

Thanks @huib-portainer for looking into this and confirming that indeed was not operating correctly.
However I still think Portainer should not silently normalize-and-deploy. This is a classic input validation scenario where the user should be told that her stack name does not comply with Docker's accepted names and try again, and not deploy the stack.
I can foresee users getting angry (me included) at not noticing that their stacks are silently being renamed and not knowing why. Is very bad user experience :(

@huib-portainer see #5797 for another user being confused by Portainer silently normalizing names instead of erroring out with an explanation.

Yes we're currently working on it.

Thanks!
Much appreciated. We are looking forward to the next version of Portainer with this fixed. The 2.9 series seem promising !

You can give it a try by using the image portainerci/portainer:develop.
Please let us know how that's working for you.
Note that this is a development build and should not be used in a production environment.


mpl2: fix SASoftMacro result update

After merging #4272, for some designs, the bundled io clusters were still being displayed in a weird location in debug mode after we ran SA for specifically placing children clusters of the root.
I realized then that when incorporating the SASoftMacro results for the root cluster, we were cheating the fixed_ flag that we set to true when setting a cluster as an IO Cluster. This was being done by changing the SoftMacro pointer address directly and, this way, bypassing the flag.
I'm running Secure-CI on this.
Also doing some tiny refactoring/cleaning.

Secure-CI passed.


Add Vedant Pople profile to LinkFree

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

package-lock.json file removed as instructed.

LGTM 👍 but remove the package-lock.json file from the commit :)

Note to the Reviewer: @Shivansh-yadav13 Please don't suggest people to "remove the package-lock.json file from commit", because the way you say, people take it wrong and delete the file from their fork!
You can say like @Panquesito7 said to "Revert the changes from the Package-lock.json File!!" 🙂

package-lock.json file removed as instructed.

Unfortunately, you have deleted the package-lock.json file, you have to just revert the changes from it!
Now just copy the content from the main Package-lock.json, and add it to your fork to avoid the conflicts with the main branch!!
Let us know if you need any help.

LGTM +1 but remove the package-lock.json file from the commit :)

Note to the Reviewer: @Shivansh-yadav13 Please don't suggest people to "remove the package-lock.json file from commit", because the way you say, people take it wrong and delete the file from their fork!
You can say like @Panquesito7 said to "Revert the changes from the Package-lock.json File!!" slightly_smiling_face

Really sorry for that 😅

package-lock.json file removed as instructed.

@vedantpople4 Unfortunately, you have deleted the package-lock.json file, you have to just revert the changes from it!
Now just copy the content from the main Package-lock.json, and add it to your fork to avoid the conflicts with the main branch!! Let us know if you need any help.

The file has been added as instructed. No conflicts with the main branch !

You need to copy the package-lock file from the Eddiehub repo, and paste it into your package-lock file. Check that the version in your file is the same as the version in Eddiehub then push the changes. There should only be 1 file in this pull request if you do it correctly.
__
  Summary: :hammer_and_wrench: This code needs a fix

Even in the latest commit, only the data folder was committed but still it shows that 2 files have been changed


Fix for #91

I'm now pretty comfortable that this fixes #91. I've added some test cases which fail before the fix and pass after the fix. There's commentary in the code around the fix; it should be removed once the fix is approved.
I also ran into a test failure I can't explain and I believe is unrelated to this path fix, but it needs a review to know for sure:
    //TODO: THIS TEST FAILS FOR UNKNOWN REASONS! IT PRODUCES THIS:
    //background-image: url('../assets/image1?4eee70fda47d1478.4eee70fda47d1478.jpg');
    //test.ok(srcset.match(/assets\/css-image1.[a-z0-9]{16}\.jpg/), 'testing the replacement of an image when css in a different subdir than asset');

Ben, I've merged all the recent master commits into this fork and removed all conflicts. It's ready for review & merge now. If there are problems, please let me know. - Mike

Hi Mike,
Thanks for the PR and keeping it up to date as I keep changing things (sorry). There's a few things that worry me so I will leave comments next to the sections of code instead of here.

I've taken the above and fixed the tests in the comment above. You can find it at #108. If you are happy with it, I can get it merged and close this one.


Fix the link to the v3 migration guide

R: @petele

:+1:

FYI—This change had previously been deployed, and this commit was just to get GitHub in-sync with what's live on the website.


Update get-live-response-result.md

Fixed inconsistent quotes in the document
Fixes https://github.com/MicrosoftDocs/microsoft-365-docs/issues/11891

@JohanFreelancer9 Please copy review

@tiburd Please merge this PR. Thanks