Delete API server & load balancer in AWS

Our primary DNS hasn’t been pointing at the API server for several days with no incident, so it’s about time to actually delete those resources.
This is a big one, and it’s the end of the day Friday. This one also involves a lot of cross-dependencies, so has a higher likelihood that normal for messy or broken applies. Leaving this in the queue for Monday.

Current plan: I’ll do this Monday, and wait until the second half of the week (Thursday?) to land #942 and delete the database. Then clean up the networks and logs and whatnot the week after, just before the end of the month.


angular_components updated to angular 4.0.0-alpha+2

@kwalrath @filiph - as agreed in another thread, I've also marked the older Pirate (plain and ng) codelabs as deprecated in the README file.

The apps from master are now hosted at: http://dart-lang.github.io/one-hour-codelab/3/
The apps from this PR are hosted at: http://dart-lang.github.io/one-hour-codelab/4/

The code update was mostly automatic using gulp tasks from webdev.
The deployment was semi-automated.

@kwalrath, @filiph: the sources for our active codelabs are spread out in different repos. Since most of the codelabs in this repo are being marked as deprecated or in need of updates, why don't we just move the Lottery codelab into webdev under examples?  We could then reuse the infrastructure for auto-code-excerpt-updates, testing, and deployment?

@chalin SGTM!

SGTM2!

@kwalrath, @filiph - the README update is now in #45. I'll move the rest of this PR (the 4.x update of the codelab) into a separate PR targeting a 4-dev branch (which I'll create shortly). That is what we're doing for the AngularDart doc example repo.

A clarification: I'm delaying the full migration of the angular_component sources by just a bit while I do tooling updates. In the meantime, I would still like to update the codelab prose and have links to running versions of the labs. That is why we'll continue to use this repo for a little while longer.


Deprecate setMinimumSessionInterval

Deprecate FIRAnalyticsConfiguration setMinimumSessionInterval due to sessions being started immediately.
This is being sent early for review, but will not be merged until the feature is rolled out.

This can be merged now. The (internal) API review is at: go/scion-m43-api-review.


[SPARK-28938][K8S] Move to supported OpenJDK docker image for Kubernetes

What changes were proposed in this pull request?

The current docker image used by Kubernetes is openjdk:8-alpine. It was not supported and  was removed with the commit https://github.com/docker-library/openjdk/commit/3eb0351b208d739fac35345c85e3c6237c2114ec#diff-f95ffa3d1377774732c33f7b8368e099.
This PR proposes to move to a supported docker image.
Why are the changes needed?

I think there are at least two reasons:

According to the commit, Alpine/musl is not officially supported by the OpenJDK project.
As no more OpenJDK 8 Alpine images, new JDK updates including security fixes
, are not applied to it. See below:

docker run -it --rm openjdk:8-alpine java -version
openjdk version "1.8.0_212"
OpenJDK Runtime Environment (IcedTea 3.12.0) (Alpine 8.212.04-r0)
OpenJDK 64-Bit Server VM (build 25.212-b04, mixed mode)

docker run -it --rm openjdk:8-jdk-slim java -version
openjdk version "1.8.0_222"
OpenJDK Runtime Environment (build 1.8.0_222-b10)
OpenJDK 64-Bit Server VM (build 25.222-b10, mixed mode)

Does this PR introduce any user-facing change?

Yes. This changes the base docker image of Spark.
How was this patch tested?

Existing tests.

Test build #111823 has started for PR 26037 at commit bf33383.

Test build #111823 has finished for PR 26037 at commit bf33383.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111823/
Test PASSed.

Thank you for making a PR, @viirya . K8s Integration test seems to be not triggered here. Did you test the K8s IT locally?

Retest this please.

Test build #111824 has started for PR 26037 at commit bf33383.

Hmm, I was thinking to run the integration test on Jenkins. At least I remember I saw it in previous PRs.

Yes. It's weird to me, too.

I checked the Jenkins. And, found that it's running here.

https://amplab.cs.berkeley.edu/jenkins/view/spark k8s builds/job/SparkPullRequestBuilder-K8s/16803/console

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/16803/

oh, thanks. @dongjoon-hyun. Seems Jenkins also posted the comment of Kubernetes integration test too.

Let's see the result~ 😄

Test build #111824 has finished for PR 26037 at commit bf33383.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/16803/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16803/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111824/
Test PASSed.

Could you check the K8s IT failure?

There is R/Dockerfile, @viirya .

@dongjoon-hyun Thanks. Updated Python and R Docker files. Let's see K8s IT result with latest change. If it has failure, I will change to a local environment which can run K8s IT. (current local env cannot)

Test build #111825 has started for PR 26037 at commit 9fa5c1e.

Test build #111825 has finished for PR 26037 at commit 9fa5c1e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111825/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16804/
Test FAILed.

About R (Please see pandoc error in Jenkins log. It might be irrelevant to this one.), I think it is happened before K8s IT stuff, according to the log.
There is another ongoing K8s IT build. Let's see the latest result and do necessary change if it needs.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/16805/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/16805/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16805/
Test FAILed.

And yes, ensurepip is a problem.

Test build #111833 has started for PR 26037 at commit 83584ed.

Test build #111833 has finished for PR 26037 at commit 83584ed.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111833/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/16812/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/16812/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16812/
Test PASSed.

Could you make a backport to branch-2.4, @viirya ?

ok.
On Mon, Oct 7, 2019, 08:56 Dongjoon Hyun<EMAIL_ADDRESS>wrote:

Could you make a backport to branch-2.4, @viirya
https://github.com/viirya ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/spark/pull/26037?email_source=notifications&email_token=AAAQZ52XPIWPJ6TPYVM764LQNNL2HA5CNFSM4I55M4MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAQ3UEA#issuecomment-539081232,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAQZ573BCRVUH3E4J3R2HTQNNL2HANCNFSM4I55M4MA
.


Implement equals for the ImmutableMetadata object

Context
When working with an ImmutableMetadata it is hard to write tests because we cannot compare a FlagEvaluationDetails anymore.
String flagKey = "bool_targeting_match";
FlagEvaluationDetails expected = FlagEvaluationDetails.builder()
        .reason(Reason.ERROR.toString())
        .value(false)
        .errorCode(ErrorCode.GENERAL)
        .errorMessage("impossible to contact GO Feature Flag relay proxy instance")
        .flagMetadata(ImmutableMetadata.builder().build())
        .build();
FlagEvaluationDetails<Boolean> got = goffClient.getBooleanDetails(flagKey, false, defaultEvaluationContext);
assertEquals(expected, got);

The JUNIT method assertEquals is comparing the reference of the object.
Expected behavior
We should be able to use assertEquals for the whole FlagEvaluationDetails object.
For this we should probably implement the equals() method in the ImmutableMetadata object.

💯

Should we consider other types that could benefit from this as well?. I don't think it's needed for EvaluationContext types, but I think it would be useful for Structure.

Yes this is probably something we should look at.
I haven't seen other problem for now but I haven't test with Structure I will check it

@toddbaert I've looked at Structure and it works already because we have the annotation in the ImmutableStructure.
I think we are good now, except if we want to introduce it for the EvaluationContext too.
https://github.com/open-feature/java-sdk/blob/ef199b94fd8ecd866893168f06717c1de2ee2fda/src/main/java/dev/openfeature/sdk/ImmutableStructure.java#L19

@toddbaert I've looked at Structure and it works already because we have the annotation in the ImmutableStructure.
I think we are good now, except if we want to introduce it for the EvaluationContext too.
https://github.com/open-feature/java-sdk/blob/ef199b94fd8ecd866893168f06717c1de2ee2fda/src/main/java/dev/openfeature/sdk/ImmutableStructure.java#L19

Thanks @thomaspoignant !
I could see some use-cases for hasing/comparing EvaluationContext, but I think they are limited. The one that comes to mind immediately is for comparing it in a provider, for some kind of caching, maybe. I'll think about it more but we can always address it in a new issue.


Add Array/Object support for elasticsearch connector via _meta field mapping

Quoting this thread from @martint on the slack Channel:
One of the limitations of the current [elasticsearch connector] implementation is that it doesn't support the ARRAY type. The underlying problem is that Elasticsearch itself does not have a way to describe such a concept. Fields in a document can be scalar values or arrays implicitly, depending on whether they have one or more values assigned.
Clearly, we could model everything as arrays, but that would make the connector unusable.
Fortunately, Elasticsearch supports per-index (i.e., table) application-specific metadata. My idea is to exploit that feature to allow users/admins to specify which columns or fields should be treated as arrays.
There are a couple of possible approaches for this:

If the table has arrays, require the user to declare the schema of the table explicitly (vs letting the connector figure it out automatically). The downside of this approach is that it can be painful to have to describe the entire schema of a table just because one field somewhere is an array. To make this concrete, consider the following document:

{
  "a" : {
      "b": {
          "x" : 1,
          "y" : ["hello", "world"]
      }
  },
  "c" : {
      "d": "foo",
      "e": "bar",
      "f": [
         { "g" : [10, 20], "h": 100 },
         { "g" : [30, 40], "h": 200 }
      ]
  }
}

There are only a handful of fields (a.b.y, c.f and c.f.g) that contain arrays. Requiring the user to declare the schema explicitly means they'd have to supply the following:
row(a row(b row(x bigint, y array(varchar))), c row(d varchar, e varchar, f array(row(g array(bigint), h bigint))))
Seems cumbersome, error prone and unnecessary.
2. An alternative would be for users pinpoint the fields that should be interpreted as arrays by providing their full path. The connector will take care of inferring the rest of the schema from the metadata exposed by ES. For the example above, they'd just need to say:
a.b.y, c.f, c.f.g
I'm leaning towards option 2. Thoughts? Any other possibilities I'm missing?

@martint it sounds like you may have already started some work on this issue, is that true? Otherwise I'd be glad to start working on it.

I haven't started working on it, so feel free to tackle it.

@dain you made a few comments about encoding of the field.

One alternative would be to model this as field metadata, so you would have a.b.c::isArray=true, and then have a bag of these
dain  3 months ago
or have properties like field.a.b.c={ "isarray"=true, "comment"="stuff")
dain  3 months ago
IMO option 2 is the way to go… then we talk about encodings
dain  3 months ago
I think I like my first encoding better, because it makes alter table coment property much easier
dain  3 months ago
we have some naming convention like p.field.[a.b.c].propertyName=value

I'm not exactly following or know the standard encodings that is used in the project but I'll propose my idea and if it's not the standard then could you point me to an example in the code that does something close? Is this on the right track?
Say we have a document like this:
{
  "a" : {
      "b": {
          "x" : 1,
          "y" : ["hello", "world"]
      }
  },
  "c" : {
      "d": "foo",
      "e": "bar",
      "f": [
         { "g" : [10, 20], "h": 100 },
         { "g" : [30, 40], "h": 200 }
      ]
  }
}

We might have some the following properties with a nested "prest_meta" object that I can traverse while parsing the mapping and building the IndexMetadata bean.
{
  "test_index": {
    "mappings": {
      "test_type": {
        "_meta": {
          "presto_meta": {
            "a": {
              "b": {
                "y": {
                  "isArray": true
                }
              }
            },
            "c":{
              "f":{
                "g":{
                  "isArray": true
                },
                "isArray": true
              }
            }
          }
        },
        "properties":{
          "a": {
            "type": "object",
            "properties": {
              "b": {
                "type": "object",
                "properties": {
                  "y": {
                    "type": "integer",
                  },
                  "y": {
                    "type": "keyword",
                  }
                }
              }
            }
          },
          "c": {
            "type": "object",
            "properties": {
              "d": {
                "type": "keyword",
              },
              "e": {
                "type": "keyword",
              },
              "f": {
                "type": "object",
                "properties": {
                  "g": {
                    "type": "integer",
                  },
                  "h": {
                    "type": "integer",
                  }
                }
              }
            }
          }
        }
      }
    }
  }
}

Side note: I believe that the field type in the mapping is optional and it defaults to object, (e.g. "type": "object" is optional) and it looks like that case isn't handled in the code but I could be wrong. I'll try to test this afternoon.

Something else we may need to consider is how this would work with an alias that pointed to multiple indices.

Hi @brianolsen87 , I just share you my thinking, because I'm facing the issue the pull request #2478 solve and was thinking to implement before I find it and because the introduction ask for eventual method to infer if a field is an array or not.
It is clear that presto will not be able to support what is describe in elastic documentation here https://www.elastic.co/guide/en/elasticsearch/reference/current/array.html since a field cannot be an array of primitive type or a primitive type.
So we have to consider that the property "isArray" of a specific field is static across the index to be compatible with presto. In this case, the combination of a sample doc extracted from a search query and the mapping will contain the same information as the combination of mapping and presto_meta in many(most?) cases without any user configuration.
Maybe using a document as a fallback (optional) method when presto_meta is not populated to infer if a field is an array will satisfy most of users and will ease the connector usage or maybe the presto_meta field can be generated by a procedure using an index name and an(optional) doc _id.
Many thanks !

maybe the presto_meta field can be generated by a procedure using an index name and an(optional) doc _id.

That's a great idea. We could add a procedure that given an index name, fetches a sample of documents, tries to infer which fields are arrays and generates the corresponding _meta entries for them. Let's do that as a separate task, though. I filed https://github.com/prestosql/presto/issues/2508.

Hi, this is how i created the index and mapping. And inserted two records. I want to fetch these records from presto command line. How can i do that? And also , do i need to create one xxx.json file to provide any metadata information ?

Hi @MT2017081
No need for an extra file, the mappings PUT statement is where you will need to add a small bit of metadata about where the arrays in your schema are actually located. We search in the mapping's _meta.presto. location to infer which fields should be treated like arrays see the Array Types section here. The example my not be super clear but you need to align the property nesting under _meta.presto with the same nesting structure of you array fields under properties. So when you add your mapping you would need to do this.
PUT developer
{
    "_meta": {
        "presto":{
            "skills":{
                "isArray":true
            }
        }
    }
}

This can be added in a separate curl call or with your original put mapping statement.
PUT developer
{
   "_meta":{
      "presto":{
         "skills":{
            "isArray":true
         }
      }
   },
   "mappings":{
      "developer":{
         "properties":{
            "name":{
               "type":"text"
            },
            "skills":{
               "type":"object",
               "properties":{
                  "language":{
                     "type":"keyword"
                  },
                  "level":{
                     "type":"keyword"
                  }
               }
            }
         }
      }
   }
}

Hi @MT2017081
No need for an extra file, the mappings PUT statement is where you will need to add a small bit of metadata about where the arrays in your schema are actually located. We search in the mapping's _meta.presto. location to infer which fields should be treated like arrays see the Array Types section here. The example my not be super clear but you need to align the property nesting under _meta.presto with the same nesting structure of you array fields under properties. So when you add your mapping you would need to do this.
PUT developer
{
    "_meta": {
        "presto":{
            "skills":{
                "isArray":true
            }
        }
    }
}

This can be added in a separate curl call or with your original put mapping statement.
PUT developer
{
   "_meta":{
      "presto":{
         "skills":{
            "isArray":true
         }
      }
   },
   "mappings":{
      "developer":{
         "properties":{
            "name":{
               "type":"text"
            },
            "skills":{
               "type":"object",
               "properties":{
                  "language":{
                     "type":"keyword"
                  },
                  "level":{
                     "type":"keyword"
                  }
               }
            }
         }
      }
   }
}

If you have more questions i'm on the slack group. Feel free to tag me for elasticsearch presto related questions and i'll do my best to answer them.

Thanks @brianolsen87  for the help.


Support additional phantom parameters

Added support for the following phantom parameters
Ref: https://github.com/jhead/phantom
Options:
-6	Optional: Enables IPv6 support on port 19133 (experimental)
-bind string
Optional: IP address to listen on. Defaults to all interfaces. (default "<IP_ADDRESS>")
-bind_port int
Optional: Port to listen on. Defaults to 0, which selects a random port.
Note that phantom always binds to port 19132 as well, so both ports need to be open.
-debug
Optional: Enables debug logging
-remove_ports
Optional: Forces ports to be excluded from pong packets (experimental)
-server string
Required: Bedrock/MCPE server IP address and port (ex: <IP_ADDRESS>:19132)
-timeout int
Optional: Seconds to wait before cleaning up a disconnected client (default 60)

hi flaminggenius. I'd like to work on this item as part of #hacktoberfest. Would you please assign it to me?

done @pdelco

hi flaminggenius, would you mind including a label for hacktoberfest-accepted? thanks!

no problem @pdelco


Could not load the "sharp" module using the linux-x64 runtime

I get the following error.

Hi @awolad-atlasprimer - the issue is probably related to your configuration. Make sure you use the latest build version. I tested it again with a NodeJS20 runtime without problems.
Attached my testing code:
sharp-heif-test.zip


Add Support for ACM-hosted SSL Certificates

Hooray! API Gateway now supports ACM SSL! Announcement: https://aws.amazon.com/about-aws/whats-new/2017/03/amazon-api-gateway-integrates-with-aws-certificate-manager-acm/
We should add these as an option.
The question is, how much should be automatic, and how much should be manual? Should Zappa simply reference an ACM certificate ARN, or should Zappa actually create the certificate?
Unfortunately, it can't be fully automatic, as ACM requires email rather than domain-based domain name verification, even if your domain is hosted on Amazon already. Therefore, it may be simplest to simply reference the ARN.
This ticket also does not mean that we will be dropping support for Let's Encrypt.
Related docs:
http://docs.aws.amazon.com/apigateway/latest/developerguide/how-to-custom-domains.html
http://boto3.readthedocs.io/en/latest/reference/services/apigateway.html?highlight=Api gateway
Interestingly, it says this:
The reference to an AWS-managed certificate. AWS Certificate Manager is the only supported source.

Which may mean that they have simply broken our existing code with no warning, I'm not sure yet. Either way, thanks Jeff.

Zappa should at least be able to just reference an ACM certificate ARN.  Maybe with an 'auto' setting or something that does generation of it for you.  'auto' would handle simple one-domain-one-cert cases, but complex ones - like maybe a bunch of sites that all use a wildcard cert or something - would need the ability to just supply an ARN.

Hoping to investigate some of this today.

This is now available in version 0.39.0, which lets you supply a certificate_arn setting.

@Miserlou I tried it with Singapore region acw ssl but its raising an issue  Traceback (most recent call last):   File "/Volumes/Seagate/workspace/homejoy/env/lib/python2.7/site-packages/zappa/cli.py", line 2142, in handle     sys.exit(cli.handle())   File "/Volumes/Seagate/workspace/homejoy/env/lib/python2.7/site-packages/zappa/cli.py", line 414, in handle     self.dispatch_command(self.command, environment)   File "/Volumes/Seagate/workspace/homejoy/env/lib/python2.7/site-packages/zappa/cli.py", line 502, in dispatch_command     manual=self.vargs['manual']   File "/Volumes/Seagate/workspace/homejoy/env/lib/python2.7/site-packages/zappa/cli.py", line 1456, in certify     self.api_stage   File "/Volumes/Seagate/workspace/homejoy/env/lib/python2.7/site-packages/zappa/zappa.py", line 1413, in create_domain_name     certificateArn=certificate_arn   File "/Volumes/Seagate/workspace/homejoy/env/lib/python2.7/site-packages/botocore/client.py", line 253, in _api_call     return self._make_api_call(operation_name, kwargs)   File "/Volumes/Seagate/workspace/homejoy/env/lib/python2.7/site-packages/botocore/client.py", line 543, in _make_api_call     raise error_class(parsed_response, operation_name) BadRequestException: An error occurred (BadRequestException) when calling the CreateDomainName operation: Invalid certificate ARN: arn:aws:acm:ap-southeast-1:042373950390:certificate/50886336-b65b-4147-89e8-625f4edfa842. Certificate must be in 'us-east-1'..
Is there any way to mention the region for it.
Thanks,
Abdul Wahid

What should I do as I have all my aws services using Singapore region and I need to have  certificate_arn because Let's Encrypt is raising an issue ( as mentioned here https://github.com/Miserlou/Zappa/issues/590 ) of permission denied because of auto renewal is not updating the certificate which I set 15 days and its problematic as I am moving towards production environment by next week. Can you suggest me some recommendation so that this kind of issue can be avoided after successful deployment for production.

First can you check if you can put the certificate in us-east-1 but use it
in singapore? That might work since CF distributions are global
On Wed, Mar 15, 2017 at 4:23 PM, Abdul Wahid<EMAIL_ADDRESS>wrote:

What should I do as I have all my aws services using Singapore region and
I need to have certificate_arn because Let's Encrypt is raising an issue
( as mentioned here #590 https://github.com/Miserlou/Zappa/issues/590 )
of permission denied because of auto renewal is not updating the
certificate which I set 15 days and its problematic as I am moving towards
production environment by next week. Can you suggest me some recommendation
so that this kind of issue can be avoided after successful deployment for
production.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Miserlou/Zappa/issues/710#issuecomment-286867102, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAIi08fFe_mb-MUGQyMSJfN-p3zO5umqks5rmEimgaJpZM4MY2NO
.

I got it working as I followed the error message and removed the domain from cloudfront and remove the subdomain from route 53 then once its create a ACM custom domain then I revert back my settings in couldFront and Route 53, Now I have ACM custom domain. Thanks @Miserlou


Parent with position: fixed

When I use Viewer for images inside fixed-position block, it opens inside this block, not fillings all browser window. Fullscreen mode also do not work at this situation.

Looks like it's connected with placement of Viewer container. And then parent have overflow:hidden.
Is it possible to have option to create Viewer container inside  tag?

I will improve this later, thanks~

In modal mode, the viewer will be appended to body now.


Comment extraction doesnt seem to work...?

Is it just me or doesnt the comment extraction work with the new version? With the old version I think there was enableCommentsExtraction. With the new version there is no such method and the extraction also doesn't happen automatically it seems. I use this code for testing:
$translations=Translations::create();
$phpScanner=new PhpScanner($translations);
$php=<<<PHP
<?php
//I love comment extraction
echo gettext('hello world');
PHP;
$phpScanner->scanString($php,"hello.php");
print_r($translations);
exit;

$translation->extractedComments seems to be empty.
This feature was very useful for parsing the PHP compiled from Twig template files, because the compiled PHP code included the original line number in the Twig file so you get a kind of source-map feature where you can see where the real line of the respective translation was...

Ok, seems like the functions with echo are not extracted, so:
//This does not work
echo gettext('hello world');

//This works
gettext('hello world');

I'm fixing it

@rgpublic I made a commit to extract the comments of functions after echo, print and return. Could you please test it before release a new version?

@oscarotero Hm. It doesnt seem to work yet for me. Even without the patch and without that "echo" it doesnt extract anything. I'm using this code:
$translations=Translations::create();
$phpScanner=new PhpScanner($translations);
$php=<<<PHP
<?php
//I love comment extraction
gettext('hello world');
PHP;
$phpScanner->scanString($php,"hello.php");
print_r($translations);
exit;

Does exactly that code work for you?

Are you using the dev-master version? (the patch is not released yet).
I'm using this code for tests and it works fine: https://github.com/php-gettext/PHP-Scanner/blob/master/tests/assets/functions.php

Yes, I did. Hm. I think the difference is that you are using directly PhpFunctionsScanner and I use PhpScanner. With low-level PhpFunctionsScanner it seems to work,yes. But I don't want to just scan for functions. I want to turn these parsed code/functions into full-fledged Translation objects! If I understand correctly, this is exactly what PhpScanner (in contrast to PhpFunctionsScanner) is good for - inside the methods gettext() and finally saveTranslation(). But these comments never seem to end up in ParsedFunction or in the final Translation object... But perhaps I'm just to dumb to use it. Good very well be. Please tell me what I'm doing wrong :-)

Ok, you're right. Extracted comments weren't saved. I've fixed it. To test it, you need to install the dev-master version of gettext/gettext and gettext/php-scanner, because I had to modify both packages.
Let me know if it works fine now.

Fixed in v1.1.1

Sorry. For the delay and bothering you again, but it still doesn't seem to work properly when the t() call is nested inside some other call like:
<?php
    // line 17
    echo renderVar(t("Ausgezeichnet"));

If I try to extract that with:
$scanner->extractCommentsStartingWith("line ");
it doesnt seem to work. Without the renderVar() call it works. Unfortunately I cannot influence this as this is how the Twig templates look when they are compiled to PHP.
This used to work with 4.x, though. Might be due to the new parsing method which (apart from this problem) I think was generally a really great idea. It's much better to rely on nikic/php-parser instead of trying to do all the work yourself.

Ok,

Finally coming back to this issue. Yes, I can confirm that your change fixes this. Unfortunately I found that it doesn't really help me in all cases, because sometimes when Twig templates are compiled, the comment with the line isn't the immediately preceding statement :-(
For example this Twig code:
{{ something_else() }} {{ "Example"| t}}

is basically compiled into:
// line 17
echo something_else();
echo renderVar(t("Example"));

The "line 17" isn't picked up anymore by GetText 5.x. It used to work with 4.x, so for me this is a regression, but I could of course understand if you don't want to support that in the new version. Sigh.

A more straightforward case that also doesn't seem to work is a comment around a gettext block being assigned to a variable. Such as:
//Translators: testing please  $gettext_string = gettext('Bar Foo');

FYI, there's a work in progress repository to implement a scanner for twig templates, using the twig AST, instead the compiled php code: https://github.com/php-gettext/Twig-Scanner
Any help is welcome.


PlayerVars option "start" must be integer number

This is maybe more a documentation issue, because the limitation might be stemming from the underlying IFrame player.
When using the usePlayer constructor with the composition API, as documented here: https://vue-youtube.github.io/docs/usage/composable#configuration, the start value MUST be an integer (whole) number.
If fractions are used (e.g. value 500.1), the value is not applied and the video starts from the beginning.
The solution for this issue might be to document this limitation in the appropriate place, maybe with some simplified example code.
A working example:
const {
    onReady,
    onStateChange,
    onError,
    // togglePlay,
    // toggleMute,
    // toggleLoop,
    instance,
} = usePlayer(videoId, youtubePlayerElement, {
    /** See https://developers.google.com/youtube/player_parameters#Parameters */
    playerVars: {
        autoplay: 0,
        disablekb: 1 /* replayer handles keyboard events on it's own*/,
        enablejsapi: 1,
        color: 'white',
        controls: 1,
        // Setting the playlist to the one video enables looping the single video itself
        // See https://stackoverflow.com/a/25781957/79485
        playlist: videoId.value,
        start: 500, // startPosition, MUST be an integer number,
        rel: 0,
    },
    cookie: true,
});

The playerVars.start field is typed via TS as number. This is sadly a short-coming in TS/JS. It doesn't allow specifying which kind of number, like int or float.
I will move this issue to the https://github.com/vue-youtube/docs repo add will add more documentation for this.


Ensure that following deployment steps for build intelligent apps works without any error

The Readme file for the Build intelligent apps scenario provides instructions on how to deploy the scenario at a high level. Some steps might be missing. Follow the instructions and make updates to the deployment instructions as you go. Also provide more details about which environment variables need to be updated in the config map and provide screenshots of the app working. Make changes to the bicep and k8s files as well as required. Create a new branch out of the opernai-embeddings branch: https://github.com/Azure/AKS-Landing-Zone-Accelerator/tree/openai-embeddings/Scenarios/AKS-OpenAI-CogServe-Redis-Embeddings
Acceptance criteria:

Instructions and other files within the "AKS-OpenAI-CogServe-Redis-Embeddings" folder updated so that a user can successfully deploy the scenario
PR submitted to the opernai-embeddings branch

#79

#79

completed by @lenisha


Ruff does not report the assignment-from-no-return error

I was expecting ruff to report an error similar to Pylint's assignment-from-no-return (E1111) for the following code, however, I get no errors.
def print_sorted_list() -> None:
    """Print a sorted list."""
    sorted_list = [1, 2, 3].sort() # `list.sort()` is an in-place function and doesn't return anything.
    print(sorted_list)

The command I invoked:
ruff /path/to/file.py

The current Ruff settings (any relevant sections from your pyproject.toml).
[tool.ruff]
select = [
    "C4",
    "E",
    "F",
    "W",
    "B",
    "I",
    "G",
    "RUF",
    "UP",
    "ISC",
    "PERF",
    "PL",
]

The current Ruff version (ruff --version):
ruff 0.1.11

The error I get by running Pylint v3.0.3:
E1111: Assigning result of a function call, where the function has no return (assignment-from-no-return)

I don't think that Pylint rule hasn't been implemented yet. You can view the progress of which Pylint rules have been implemented here: #970.

Thanks for the reference. Closing this issue as a duplicate of https://github.com/astral-sh/ruff/issues/970.


Added example of ping to Toast

Replaces the ping -t of the cmd days to use the Toaster as notification.

Thanks!


Improve configure_file and add rapidcheck, json, yaml-cpp [BUILD-411]

This PR improves behavior of the configure_file function.
In the improvement I added #cmakedefine01 which is used e.g. here
I also fixed the issue with identical substring as one of the string e.g.:
#cmakedefine01 ABC
#cmakedefine01 ABC_STRING

In the example above, ABC would be changed in both cases. That's why I added a newline \n in one of the matches.
I also had to add a match with a space in order to cover this case:
#cmakedefine ABC @ABC@

PR also adds support for the following third_party library:

rapidcheck
nlohmann/json
yaml-cpp

PR tested here:
https://github.com/swift-nav/starling/pull/7124
https://github.com/swift-nav/starling-core/pull/100

I extracted configure_file to another function in order to define rule in as easier way.
https://github.com/swift-nav/starling/pull/7124/files#diff-6eb3c92823224db3748c0f7201f8c0495d8f736d806eb304f14273981b2d7ccb


failed reponse for 'ts.parseJsonConfigFileContent()'

I do this.

then it fail to reponse...
on my mbp with node v8.11.1.
I install node by nvm, and I reinstall node again and again,but no useful.

However, I can use this command on my linux system.

But when I use single folder likets.parseJsonConfigFileContent({}, ts.sys,'/Users',{ target: 1, jsx: 1 },'/Users'), the linux will not be reponse as same as mbp.

When I move the folder to other directory(like /test/), it will run quickly.Is there cached ? I had remove the cache in ~/Library/.

Orz....
My home path is /Users/maple/
I move the project to /Users/maple/projects/${project}, it run.

git clone https://github.com/umijs/umi-dva-user-dashboard.git // an object use ts
sudo mv umi-dva-user-dashboard /Users
cd /Users && npm install && npm start

I do this in two ubuntu system, and they are fail to reponse both.

Looks like directoryOfCombinedPath resolves /Users/maple/ to /Users, then matchFileNames will search the whole /Users dir.

Because of awesome-typescript-loader pass pwd as configFileName to parseJsonConfigFileContent. So if you put project under / or /Users, build will hang forever.

Not sure it's bug of TypeScript or awesome-typescript-loader.
cc @s-panferov

Hopefully this got figured out since we can't really do much with screenshots of API invocations.


Add files via upload

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


HTML validity and accessibility issues

I can spot some issues regarding the validity of HTML (like putting div inside span, or form inside h1) and also there is room for adding aria-* for better accessibility.
Are you planning on a new design? If that's the case there will be huge changes on the markup I assume. That's why I am hesitating to fix the markup and accessibility cause that would cause HTML markup changes too.
What do you suggest? I can also contribute to implementing the new design and do the validity/accessibility stuff along the way.

Thanks for spotting! Implemented some fixes for the HTML validation issues and added a module to ensure it doesn't happen again: https://github.com/danielroe/page-speed.dev/commit/28f1715669dcce509b56b243ec21d2f4b81b2935.
A new design might well be on the cards ...


Animation on close not properly triggered with delay

Summary:
Steps to reproduce:

Open the codesandbox
Close the modal by clicking the background
See no animation when closing

Also when I do this in my app and record it, you see that it adds the class but not for the delay (400ms) specified as it does with the after open

Expected behavior:
Should add a delay to the actual unmounting (working) and add the class on the beginning of the delay for animation. Currently it waits for the delay, adds the class and directly unmounts

In case somebody else having the same issue this might help.


python312Packages.boltons: 24.0.0 -> 24.1.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.boltons is: Constructs, recipes, and snippets extending the Python standard library
meta.homepage for python312Packages.boltons is: https://github.com/mahmoud/boltons
meta.changelog for python312Packages.boltons is: https://github.com/mahmoud/boltons/blob/24.1.0/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 24.1.0 with grep in /nix/store/sv109jrzlm4ng3skih49qm35g3jcvg8y-python3.12-boltons-24.1.0
found 24.1.0 in filename of file in /nix/store/sv109jrzlm4ng3skih49qm35g3jcvg8y-python3.12-boltons-24.1.0

Rebuild report (if merged into master) (click to expand)

27 total rebuild path(s)

27 package rebuild(s)

First fifty rebuilds by attrpath

dinghy
eliot-tree
ghdorker
python311Packages.boltons
python311Packages.cltk
python311Packages.conda
python311Packages.conda-libmamba-solver
python311Packages.dinghy
python311Packages.eliot
python311Packages.face
python311Packages.glom
python311Packages.k-diffusion
python311Packages.torchsde
python312Packages.boltons
python312Packages.conda
python312Packages.conda-libmamba-solver
python312Packages.dinghy
python312Packages.eliot
python312Packages.face
python312Packages.glom
python312Packages.k-diffusion
python312Packages.torchsde
route-detect
semgrep
tahoe-lafs
tts

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/sv109jrzlm4ng3skih49qm35g3jcvg8y-python3.12-boltons-24.1.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.boltons https://github.com/r-ryantm/nixpkgs/archive/87dfb08e6686cc9dcef13f4583825f0c4ff5fb4a.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/87dfb08e6686cc9dcef13f4583825f0c4ff5fb4a#python312Packages.boltons

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/sv109jrzlm4ng3skih49qm35g3jcvg8y-python3.12-boltons-24.1.0
ls -la /nix/store/sv109jrzlm4ng3skih49qm35g3jcvg8y-python3.12-boltons-24.1.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:fast_forward: 2 packages marked as broken and skipped:

tts
tts.dist

:x: 18 packages failed to build:

python311Packages.cltk
python311Packages.cltk.dist
python311Packages.conda
python311Packages.conda-libmamba-solver
python311Packages.conda-libmamba-solver.dist
python311Packages.conda.dist
python311Packages.k-diffusion
python311Packages.k-diffusion.dist
python312Packages.conda
python312Packages.conda-libmamba-solver
python312Packages.conda-libmamba-solver.dist
python312Packages.conda.dist
python312Packages.k-diffusion
python312Packages.k-diffusion.dist
tahoe-lafs
tahoe-lafs.dist
tahoe-lafs.doc
tahoe-lafs.info

:white_check_mark: 32 packages built:

dinghy (python312Packages.dinghy)
dinghy.dist (python312Packages.dinghy.dist)
eliot-tree
eliot-tree.dist
ghdorker
ghdorker.dist
python311Packages.boltons
python311Packages.boltons.dist
python311Packages.dinghy
python311Packages.dinghy.dist
python311Packages.eliot
python311Packages.eliot.dist
python311Packages.face
python311Packages.face.dist
python311Packages.glom
python311Packages.glom.dist
python311Packages.torchsde
python311Packages.torchsde.dist
python312Packages.boltons
python312Packages.boltons.dist
python312Packages.eliot
python312Packages.eliot.dist
python312Packages.face
python312Packages.face.dist
python312Packages.glom
python312Packages.glom.dist
python312Packages.torchsde
python312Packages.torchsde.dist
route-detect
route-detect.dist
semgrep
semgrep.dist

Maintainer pings
cc @Twey for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 353260

x86_64-linux

:fast_forward: 1 package marked as broken and skipped:

tts

:x: 7 packages failed to build:

python311Packages.conda
python311Packages.conda-libmamba-solver
python312Packages.conda
python312Packages.conda-libmamba-solver
tahoe-lafs
tahoe-lafs.doc
tahoe-lafs.info

:white_check_mark: 19 packages built:

dinghy (python312Packages.dinghy)
eliot-tree
ghdorker
python311Packages.boltons
python311Packages.cltk
python311Packages.dinghy
python311Packages.eliot
python311Packages.face
python311Packages.glom
python311Packages.k-diffusion
python311Packages.torchsde
python312Packages.boltons
python312Packages.eliot
python312Packages.face
python312Packages.glom
python312Packages.k-diffusion
python312Packages.torchsde
route-detect
semgrep

aarch64-linux

:fast_forward: 1 package marked as broken and skipped:

tts

:x: 7 packages failed to build:

python311Packages.conda
python311Packages.conda-libmamba-solver
python312Packages.conda
python312Packages.conda-libmamba-solver
tahoe-lafs
tahoe-lafs.doc
tahoe-lafs.info

:white_check_mark: 19 packages built:

dinghy (python312Packages.dinghy)
eliot-tree
ghdorker
python311Packages.boltons
python311Packages.cltk
python311Packages.dinghy
python311Packages.eliot
python311Packages.face
python311Packages.glom
python311Packages.k-diffusion
python311Packages.torchsde
python312Packages.boltons
python312Packages.eliot
python312Packages.face
python312Packages.glom
python312Packages.k-diffusion
python312Packages.torchsde
route-detect
semgrep

x86_64-darwin

:x: 4 packages failed to build:

python311Packages.conda
python311Packages.conda-libmamba-solver
python312Packages.conda
python312Packages.conda-libmamba-solver

:white_check_mark: 19 packages built:

dinghy (python312Packages.dinghy)
eliot-tree
ghdorker
python311Packages.boltons
python311Packages.cltk
python311Packages.dinghy
python311Packages.eliot
python311Packages.face
python311Packages.glom
python311Packages.k-diffusion
python311Packages.torchsde
python312Packages.boltons
python312Packages.eliot
python312Packages.face
python312Packages.glom
python312Packages.k-diffusion
python312Packages.torchsde
route-detect
semgrep

aarch64-darwin

:fast_forward: 4 packages marked as broken and skipped:

python311Packages.cltk
python311Packages.k-diffusion
python312Packages.k-diffusion
tts

:x: 4 packages failed to build:

python311Packages.conda
python311Packages.conda-libmamba-solver
python312Packages.conda
python312Packages.conda-libmamba-solver

:white_check_mark: 16 packages built:

dinghy (python312Packages.dinghy)
eliot-tree
ghdorker
python311Packages.boltons
python311Packages.dinghy
python311Packages.eliot
python311Packages.face
python311Packages.glom
python311Packages.torchsde
python312Packages.boltons
python312Packages.eliot
python312Packages.face
python312Packages.glom
python312Packages.torchsde
route-detect
semgrep


Feature/transform iso code

Made some small changes to variable names after looking at it again this morning in addition to adding to the logs.

Added instructions to the README. Open to any feedback. Also updated the return value from the functions - realized they were originally returning the full country object, adjusted so it only returns the ISO3.


i18n Occitan

I copied pasted the .po file from weblate hoping it works this way.

The up to date file from which to translate is this one: https://github.com/pytition/Pytition/blob/master/pytition/locale/oc/LC_MESSAGES/django.po
Is this the one you took?

J'ai rien pris :)

Maybe you can have a look with @ButterFlyOfFire why the PO file on github and the one you sent in the Pull Request are not synchronised?

Hi, I'll check that.

@Quenty31 Do you want to merge this Pull Request? Or to wait for the translations to be 100% complete before merging?

Oui, si ça fonctionne je suis d’accord pour que ça soit déjà intégré :)

Alright, looks good to me!
Merging...
Thanks a lot :)

Many thanks! Looking forward to see it in action!
Still working on the rest of the translation.

It is now possible to see this translation online on the demo website: https://pytitiondemo.sionneau.net/
Thanks a lot!

79% now ;) I'll open another PR, I have to tune it a bit ^^

@Quenty31 Thanks :)


Added Swahili Locale

Can you rebase to latest develop -- we moved locales to src/locale. Also you'd need to add tests:  https://github.com/moment/moment/blob/develop/CONTRIBUTING.md#very-important-notes

I tried this http://stackoverflow.com/questions/6102297/how-do-i-clean-up-my-github-fork-so-i-can-make-clean-pull-requests , I think I messed up :disappointed:

Closed in favor of #2545


NCTL: sync nctl config.tomls with changes from PR1877

Changes:

Syncs NCTL tests with changes introduced in https://github.com/casper-network/casper-node/pull/1877

bors r+


Python bindings

Please find here some python bindings to protox:
https://github.com/tardyp/protoxy
This is really just a thin wrapper over protox, adapting to the protobuf official python library.
I earlier suggested they are maintained inside your tree.
The main advantage I see to that is that the package is run automatically when tag is pushed to protox.
The CI part is already well supported by maturin (https://github.com/PyO3/maturin), and automatically generates the packages (wheels) for all combination of pythonversion/supported architecture.
This issue to discuss how to make sure we deploy a new version of protoxy whenever a new version of protox is out.

I'd prefer to keep this repo purely Rust code, to make maintenance simpler. I wonder if perhaps something like Dependabot could be set up to automatically create PRs on protoxy when a new version of protox is published?


fix checksum mismatch with trailing slash

With ansible 2.3 ims-dump fails with
"checksum mismatch" because
the destination is a directory,
but has no trailing slash.
This is fixed in ansible 2.4
in a way that still fails,
but changes the error message.
So we just add the trailing slash.

the upstream issus is documented here:
https://github.com/ansible/ansible/issues/27312
With the fix it works fine for me (ansible <IP_ADDRESS>), but it would be good if somebody else can test it again (with a version that also worked without the fix).

Thanks.  Have replicated that this fixes the issue on Ansible <IP_ADDRESS>.


Error in fetching topics and datatypes

Hello!
I get the following error when connected to the rosbridge_server:

I'm using ROS Noetic (1.15.14)
Thank you!

I'd recommend trying Foxglove Studio: https://foxglove.dev/docs/studio/connection/ros1#live-connection


Is this allowed if I use custom image!

I am using custom image (sysprep of 2019 datacenter) and I can see "Login with Azure AD" is greyed out.
Will this work only for Marketplace images?

The documentation says to use a Marketplace image so that seems to be the supported method, though I've checked with the product team to see if there is any support for custom images and will let you know their response. https://docs.microsoft.com/en-us/azure/active-directory/devices/howto-vm-sign-in-azure-ad-windows
If you would like to request this ability for custom images you can do so in the newly revised Ideas forum. https://feedback.azure.com/
If you have further questions feel free to reach out on Microsoft Q&A. https://docs.microsoft.com/answers/topics/azure-active-directory.html

Hi @MarileeTurscak-MSFT,
Thanks for your response.
You are spot on, the document I was referring to is https://docs.microsoft.com/en-us/azure/active-directory/devices/howto-vm-sign-in-azure-ad-windows
Please keep me updated if you hear anything from Product team, really appreciate that!


stat: Adds support to read a filename redirected to stdin

Explanation:
touch f && stat - < f creates an empty file and stat after seeing - tries to find the file which is being redirected to stdin and prints details for that file.
Solution:
On detecting -, canonicalize /dev/stdin which will point to the file which is being redirected to stdin
NOTE stat doesn't read the content of the file, and this can be verified
Fixes #3241

Could you please add a test to make sure we don't regress?
thanks

Hi,
It's not possible to add test cases for this at the moment because when I attach a file handle to process's stdin for redirection in std::process::Command or UCommand, rust will instead attach a pipe. std::fs::canonicalize is failing to resolve /dev/stdin when it points to a linux pipe at the moment.
Reference: rust-lang/rust#95239

Thanks!


:fire: Remove unnecessary text slice

Unnecessary since in #76, text is already returned through the detectors API. We do not have to re-index to re-calculate the text
Related to: #96

We can keep the sliced_codepoints function around for later. Might become handy in some aggregation processing


Use std::string for registered_method

Pointed out in review of #22674 - we should use std::string instead of strdup now that we can.

I knew that I'd forget it if I left it hanging.

No slowdown; prelim QPS #s suggest 3% improvement but that may just be noise.


Search query gets rendered as HTML

Gitea version (or commit ref): 1.4.0+rc1
Operating system: Ubuntu Server 16.04
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[x] No, because repo indexer is disabled
[ ] Not relevant

Description
When I enter a HTML tag into the repository search, the query gets rendered as HTML. But it is sort of escaped because only h1, b, i etc. are rendered but without parameters like onload.
Screenshots
Search-Query:

Search-Query:

Search-Query: Hello
World

This might be also security relevant because attackers could send links containing a message for example to send credentials to the attacker.

FYI, while this is certainly a bug (good catch @JonasFranzDEV), I don't believe XSS is a concern because the search query was previously piped through Str2Html (which sanitizes unsafe HTML)

@ethantkoenig You're right. It is not a real XSS but it could be used to show the user a big text for example saying to send there password to an email.


Add ignore conditions to dependabot docker updates

Dependabot is currently suggesting upgrades that can not be auto upgraded, including major versions to operating system and updates to CUDA versions.
Restrict docker file updates to patch by ignoring semvar major and minor updates
For reference:
https://github.com/tensorflow/tensorflow/pull/70377#pullrequestreview-2142011405
https://github.com/tensorflow/tensorflow/pull/70379#pullrequestreview-2142011234

Docs on this restriction:
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#specifying-dependencies-and-versions-to-ignore


New Task: Add Drug-Drug Interaction Data

I will work on TWOsides drug-drug interaction database from here

Great work! Next time try to refer to the main source if from TDC include tdc link. If from awesome-chem try to refer that it from awesome-chem..etc.
Because if it didn't found in either you can add it to our list awesome-chem.
Raise up...!


Performance regression tests

A first draft was introduced a little while ago but it still needs to be updated to the latest version and expan ded.


Setup API maintenance s3 bucket

The bucket contains a down.json which will be returned when the API is in maintenance mode

https://s3.console.aws.amazon.com/s3/buckets/api.maintenance.chainsfr.com/?region=us-east-1


terminado: init at 0.5

Terminado is a dependency for IPython 3.2 Notebook. This PR also includes a dependency of terminado.
Tested locally using nox-review wip. Cancelled the PyPy test.

No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.
The build has been terminated

during pypy build

Built locally thanks.


C#: grpc_csharp_ext.dll not found using dotnet cli

Using grpc 0.15.0 on Windows, and dotnet cli 1.0.0-preview2-003121.
This is about as minimal a repro as I can get:
project.json:
{
  "buildOptions": { "emitEntryPoint": true },
  "dependencies": { "Grpc.Core": "0.15.0" },
  "frameworks": { "net45": {} }
}

Program.cs:
public class Program
{
    public static void Main(string[] args)
    {
        var channel = new Grpc.Core.Channel("<IP_ADDRESS>:50052", Grpc.Core.ChannelCredentials.Insecure);
    }
}

Error:
Unhandled Exception: System.IO.FileNotFoundException: Error loading native library. Not found in any of the possible locations c:\Users\jon\Test\Projects\grpctest\bin\Debug\net45\win7-x64\nativelibs\windows_x64\grpc_csharp_ext.dll
   at Grpc.Core.Internal.UnmanagedLibrary.FirstValidLibraryPath(String[] libraryPathAlternatives)
   at Grpc.Core.Internal.UnmanagedLibrary..ctor(String[] libraryPathAlternatives)
   at Grpc.Core.Internal.NativeExtension.Load()
   at Grpc.Core.Internal.NativeExtension..ctor()
   at Grpc.Core.Internal.NativeExtension.Get()
   at Grpc.Core.GrpcEnvironment.GrpcNativeInit()
   at Grpc.Core.GrpcEnvironment..ctor()
   at Grpc.Core.GrpcEnvironment.AddRef()
   at Grpc.Core.Channel..ctor(String target, ChannelCredentials credentials, IEnumerable`1 options)
   at Program.Main(String[] args) in c:\Users\jon\Test\Projects\grpctest\Program.cs:line 5

I've been experimenting with this a bit.
I've created a new package Grpc.Native (just locally) with a nuspec file containing this:
  <files>
    <file src="windows-x86\grpc_csharp_ext.dll" target="/runtimes/win-x86/native/grpc_csharp_ext.x86.dll" />
    <file src="windows-x64\grpc_csharp_ext.dll" target="/runtimes/win-x64/native/grpc_csharp_ext.amd64.dll" />
    <file src="linux-x86\libgrpc_csharp_ext.so" target="/runtimes/linux-x86/native/libgrpc_csharp_ext.x86.so" />
    <file src="linux-x64\libgrpc_csharp_ext.so" target="/runtimes/linux-x64/native/libgrpc_csharp_ext.amd64.so" />
    <file src="macosx-x86\libgrpc_csharp_ext.dylib" target="/runtimes/macosx-x86/native/libgrpc_csharp_ext.x86.dylib" />
    <file src="macosx-x64\libgrpc_csharp_ext.dylib" target="/runtimes/macosx-x64/native/libgrpc_csharp_ext.x64.dylib" />
  </files>

This was inspired by the layout of Microsoft.DiaSymReader.Native, although that has a second copy of each file in /runtimes/win/native - it's not clear to me why there have to be two copies.
At that point, if project.json in the client project is changed to have this frameworks element:
  "frameworks": {
    "net45": {
      "dependencies": {
        "Microsoft.NETCore.Platforms": "1.0.1"
      }
    }
  }

(and depending on Grpc.Native of course) then we end up with grpc_csharp_ext.amd64.dll with a plain dotnet build, and the x86 dll if I specifically build the x86 runtime version.
The dependency on Microsoft.NETCore.Platforms is required - without that, the library doesn't get copied.
That still doesn't work with the current release of gRPC as it's expecting it to be in subdirectories, but it's a start.
I'd strongly suggest that we at least have some way of specifying the library to use at execution time - there's a TODO in NativeExtension.Load for this. (Even just an environment variable would be a good start.)

Thanks for looking into this, Jon!
It's an interesting problem, because if we want gRPC to work well with both old-style .csproj files and dotnet CLI, we basically need to support two ways of resolving native dependencies - dotnet CLI has its own builtin way (currently not supported by gRPC, but things are only broken for net45 projects). The old .csproj style projects don't have support for native dependencies at all (and that's why gRPC comes with its own custom way to load the native extension).
The only thing we really need to do is to make sure that the native libraries get copied to the output directory when build by dotnet CLI - after that, the gRPC's native extension loading code can be easily adjusted to load the library from a known location relative to the Grpc.Core.dll assembly (the code should already support looking for the native libraries in multiple locations - https://github.com/grpc/grpc/blob/e705dc44a1d850457f700a66089ef9fcd463178b/src/csharp/Grpc.Core/Internal/NativeExtension.cs#L114)
Ad using Microsoft.NETCore.Platforms:  requiring the user to depend on it is still a bit of a workaround but it's probably acceptable (considering this is only to fix dotnet CLI targeting net45 use case). I am wondering what is the magic part of Microsoft.NETCore.Platforms that enables the copying of libraries to the output directory - as that is the only piece we need to complete the puzzle.

Yes, I don't know exactly how Microsoft.NETCore.Platforms works - it does seem to be the magic bit though. I quite like the naming scheme used by Microsoft.DiaSymReader.Native, with different filenames for different architectures so it would be possible to just xcopy a single directory and have that work on multiple platforms, if necessary.
How many more prereleases are likely for gRPC? I was wondering about at what stage it would be reasonable to drop DNX support (which is the third variant, and currently works). If there are still a couple more releases, we could add support for dotnet cli in the next release but keep DNX, and then remove DNX before the final release.

I tried to use the techniques you suggested and was somewhat successful: https://github.com/grpc/grpc/pull/7295


Need to press Command+S twice to save a file.

VSCode Version: Version 1.5.3 (1.5.3)
OS Version: OS X EI Capitan, Version 10.11.6

Steps to Reproduce:

File->Open Select any project folder, in my case the project was an ionic hybrid app.
Make any changes on a file and try to save.

Note: I had installed a lot of 'Extensions'.

I wonder if this issue is being caused by an installed extension. Can you try to run VS Code without extensions? From the command line, execute: code --disable-extensions and try your steps again to see if it reproduces. If you see it is an issue with the extension, please file it against the extension repository itself.

It's working fine without extensions.

Is there any way or techniques to find out which extension are actually malfunctioned.

Currently not, sorry.
Reading your description it seems that the issue originates from an extension and not VS Code itself. Thereby I will close this issue and kindly ask you to report this issue against the extension repository.
Most extensions are on GitHub as well so it should be easy to file it against the extension. If you open an extension on the market place, click on the Support link to find out more.

Thanks again for your feedback!

Thanks for the support.
On 28-Sep-2016 2:49 PM, "Benjamin Pasero"<EMAIL_ADDRESS>wrote:

Closed #12755 https://github.com/Microsoft/vscode/issues/12755.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/12755#event-805149199, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGqQyr0XUJl1-CPpIdyjaujV8kWYOwvCks5qujEigaJpZM4KHoDR
.

@mablejohn I had the same issue and could narrow it down to the extension JS-CSS-HTML Formatter. Do you have the same extension installed? If yes, then can you uninstall and check if you still see the issue?
I have logged https://github.com/Lonefy/vscode-JS-CSS-HTML-formatter/issues/28 in the extension's repo

@ramya-rao-a yes, i had installed the same extension you mentioned. Now it is working fine after uninstall it.
Thank you


Create a /gallery page for people to see pictures of our events!

What's your idea?
Create a separate page (acmcsuf.com/gallery) to display a group of photos that the board can upload to.

TODO: Add a transition to make the images fade into place so that the images have time to load.


feat: InAppLocalhostServer decode assets url when loading them

Connection with issue(s)
Closes #1656

Testing and Review Notes
Run the app and access localhost:8080/page 1.html in the webview. It will load up with its contents now.

Screenshots or Videos

To Do

[x] double check the original issue to confirm it is fully satisfied
[x] add testing notes and screenshots in PR description to help guide reviewers
[ ] request the "UX" team perform a design review (if/when applicable)

@all-contributors please add @Nirajn2311 for code


Button not working when added after install

I used the command to install
$ grafana-cli --pluginUrl https://github.com/cloudspout/cloudspout-button-panel/releases/download/7.0.2/cloudspout-button-panel.zip \
  plugins install cloudspout-button-panel

But when i try to use the plugin i have this error:

What's going on?

Can you post your Grafana (server) version please?

The issue should be fixed with the new release 7.0.5 of the plugin.
It is in review to be added to the Grafana web installer: https://github.com/grafana/grafana-plugin-repository/pull/756
Until then, a manual install via the CLI is already possible:
$ grafana-cli --pluginUrl https://github.com/cloudspout/cloudspout-button-panel/releases/download/7.0.5/cloudspout-button-panel.zip \
  plugins install cloudspout-button-panel


Plotting is ignoring x and y limits for Japan model

Both celeri.plot_input_summary and celeri.plot_estimation_summary are not respecting the lon_range and lat_range tuples that are passed to them.  I've verified that they are being passed correctly and have the right values when xlim and ylim are called.  Somehow this is ignored for the Japan model but still followed for the Western North America model.

However, this works fine from within celeri_direct_dense_japan.ipynb with:
lon_range=(130.0, 145.0)
lat_range=(30.0, 50.0)
for i in range(len(segment)):
    if segment.dip[i] == 90.0:
        plt.plot(
            [segment.lon1[i], segment.lon2[i]],
            [segment.lat1[i], segment.lat2[i]],
            "-k",
            linewidth=0.5,
        )
    else:
        plt.plot(
            [segment.lon1[i], segment.lon2[i]],
            [segment.lat1[i], segment.lat2[i]],
            "-r",
            linewidth=0.5,
        )
plt.xlim([lon_range[0], lon_range[1]])
plt.ylim([lat_range[0], lat_range[1]])
plt.gca().set_aspect("equal", adjustable="box")


[BUG]: Release asset version doesn't match version number.

In raising this issue I confirm that

[X] I have fully completed the issue template
[X] I have searched open and closed issues for duplicates
[X] I have read the Contribution Guidelines
[X] I have read the Code of Conduct
[X] I have read the Documentation

Describe the bug
The release asset for the v4.1.0 release has a package version that doesn't match (4.0.0 instead of 4.1.0) as expected.

Steps to reproduce the behavior

Download the .tar.gz file from the 4.1.0 release and extract.
Inspect the pyproject.toml file.

Expected behavior
I would expect the versions to match.
Looks like the version was updated in this commit but that happened after the 4.1.0 release. I wonder if the ordering of operations for a release might need some adjustment.
This mismatch also caused me some confusion when looking at the "about" page:

Screenshots
No response
System Information

Arch Linux X86_64
Installed via the streamdeck-ui AUR package. (I confirmed that the sha512sum matches the .tar.gz from the GitHub release page.)

Stream Deck Version
N/A

The build / release process is still flaky and being fine-tuned ...
That is just a "cosmetic" issue .. the code released is actually the one for 4.1.0.
that was fixed here: https://github.com/streamdeck-linux-gui/streamdeck-linux-gui/commit/aa790f8aaad5aaaffbbdebf3d6dac844b3b7f995


HBASE-22482 Fix tag Warnings in TestPartitionedMobCompactor

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
27
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
251
master passed

+1
compile
53
master passed

+1
checkstyle
69
master passed

+1
shadedjars
261
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
168
master passed

+1
javadoc
33
master passed

_ Patch Compile Tests _

+1
mvninstall
255
the patch passed

+1
compile
64
the patch passed

+1
javac
64
the patch passed

+1
checkstyle
105
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
408
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1584
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.

+1
findbugs
210
the patch passed

+1
javadoc
30
the patch passed

_ Other Tests _

+1
unit
7968
hbase-server in the patch passed.

+1
asflicense
31
The patch does not generate ASF License warnings.

11942

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-255/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/255

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 1f7d92ce287a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 73267d9ab1

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-255/2/testReport/

Max. process+thread count
5247 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-255/2/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
171
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
262
master passed

+1
compile
53
master passed

+1
checkstyle
75
master passed

+1
shadedjars
308
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
252
master passed

+1
javadoc
34
master passed

_ Patch Compile Tests _

+1
mvninstall
254
the patch passed

+1
compile
51
the patch passed

+1
javac
51
the patch passed

+1
checkstyle
68
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
262
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1010
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.

+1
findbugs
207
the patch passed

+1
javadoc
32
the patch passed

_ Other Tests _

-1
unit
17076
hbase-server in the patch failed.

+1
asflicense
21
The patch does not generate ASF License warnings.

20492

Reason
Tests

Failed junit tests
hadoop.hbase.quotas.TestQuotaAdmin

hadoop.hbase.client.TestMobSnapshotCloneIndependence

hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL

hadoop.hbase.client.TestFromClientSide

hadoop.hbase.client.TestFromClientSide3

hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory

hadoop.hbase.util.TestFromClientSide3WoUnsafe

hadoop.hbase.client.TestAsyncTableAdminApi3

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-255/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/255

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 4d6e81b36475 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 73267d9ab1

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-255/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-255/1/testReport/

Max. process+thread count
5304 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-255/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
26
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
237
master passed

+1
compile
53
master passed

+1
checkstyle
68
master passed

+1
shadedjars
264
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
201
master passed

+1
javadoc
33
master passed

_ Patch Compile Tests _

+1
mvninstall
238
the patch passed

+1
compile
54
the patch passed

+1
javac
54
the patch passed

+1
checkstyle
65
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
264
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
728
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
202
the patch passed

+1
javadoc
33
the patch passed

_ Other Tests _

+1
unit
8712
hbase-server in the patch passed.

+1
asflicense
39
The patch does not generate ASF License warnings.

11532

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-255/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/255

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 5fa6447fe4c1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 302a9ce056

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-255/3/testReport/

Max. process+thread count
4767 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-255/3/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.


containment prop doesn't seem to work with position absolute frame

I'm trying to do an infinite scrolling pagination with the code below. I have a leftPanel component which is within a dashboard layout, so I thought by setting the containment will be fine. The problem is the onChange method called during the first render, I wonder what's wrong.

import { Component, PropTypes } from 'react'

// helpers
import { isEmpty, map, isEqual } from 'lodash'
import { routeUrl } from '~/utils/stringHelper'

// components
import { Link } from 'react-router'
import EmptyState from '~/components/common/EmptyState'
import Loading from '~/components/common/Loading'
import VisibilitySensor from 'react-visibility-sensor'

//styles
import './index.less'

class LeftPanel extends Component {

	constructor() {
		super()
		this.state = {
			page: 1,
			noMore: false
		}
	}

	componentWillReceiveProps(nextProps) {
		if(isEmpty(nextProps.conversations)){
			this.setState({ page: 1 })
		}
	}

	componentDidMount() {

	    this.container = document.getElementById('subjects-container')
	}

	componentWillUnmount() {
	}

	handleLoaderInview = () => {

		console.log('call') // triggered on the first time although the loader is not visible

		if(this.props.conversations.length !== this.props.conversationsTotal) {
			this.setState({
				page: this.state.page + 1
			}, () => {
				console.log('fetchConversations')
				this.props.fetchConversations(this.state.page)
			})
		}else{
			this.setState({
				noMore: true
			})
		}
	}

	render() {
		const { openArchive } = this.props

	    return(

	        		{(!this.props.isLoading && isEmpty(this.props.conversations)) && <EmptyState style={{marginTop:'40px'}} message={Lang.get('inbox.conversations.emptystate')} />}
					{!isEmpty(this.props.conversations) &&
		        		map(this.props.conversations, (conversation, index) => (
							<Subject
								className={this.props.selectedConversationId === conversation.id ? 'active': '' }
								key={index}
								index={index}
								conversation={conversation}
								getConversationMsg={this.props.getConversationMsg}
							/>
						))
	        		}

        			<VisibilitySensor scrollCheck={true} active={!this.state.noMore && this.props.conversations.length !== this.props.conversationsTotal} containment={this.container} onChange={this.handleLoaderInview} >
						<Loading className="loading-sm" />
        			</VisibilitySensor>

	        	{openArchive && <Archive {...this.props} />}

	    )
	}
}

export default LeftPanel

Will the css cause an issue here?
.leftPanel .subjects-wrap {
    width: 100%;
    height: calc(100% - 60px);
    overflow-y: auto;
    position: relative;
}

@eldyvoon Hey! Don't know if you found anything out (it's been a while) but just recently ran into something similar. I think its to do with how containment was implemented
https://github.com/joshwnj/react-visibility-sensor/blob/70fb76e0ecf1cd3c19fbd136b668e6b3990e610c/visibility-sensor.js#L236
It's based off the boundingclientRect direction properties, which actually changes as you scroll and what not, but I'm thinking it should probably be using the height/width properties similar to how the default state(no containment) was implemented? Will submit a PR and see if that works better for people

Also have this issue. Wont detect an element with position: relative;


Create udlanet

Im an student at Universidad de las americas, im learning python very interested in your ide.
thanks

@nerub Flagging as inactive.


Add viewer_url for webknossos multi-channel image

https://webknossos.org/datasets/308ffc5547d41748/multi-channel_idr0101/view?token=7_8Gd4gVytrTVU89c5vCag

As discussed - can remove webknosses issue for pixel size since this seems to be fixed: https://github.com/scalableminds/webknossos/issues/6577

@jburel - Looking good?


React Native support (closes #28)

But I was able to get this going. Import using
import styled from 'styled-components/native'

This explodes horribly if you call it from your browser but I have no idea how to provide a better error message.
Tested (manually) that props, theming, and overriding using normal RN styles all work. Given these components:
const Container = styled.View`
  flex: 1;
  justify-content: center;
  align-items: center;
  background-color: papayawhip;
  ${ props => props.theme.update({
    fg: 'palevioletred'
  })}
`
const Welcome = styled.Text`
  font-size: 20;
  text-align: center;
  margin: 10;
  color: tomato;
`
const Instructions = styled.Text`
  text-align: center;
  color: ${ props => props.theme.fg };
  margin-bottom: 5;
  ${ props => props.underlined && 'text-decoration-line: underline' }
`
const styles = StyleSheet.create({
  overrides: {
    fontWeight: 'bold'
  }
})

All the "Components" that React Native exports are aliased on styled.X (styled.WebView, styled.Image etc). I have no idea whether all of them accept styles but the error messaging is pretty good if you get it wrong.
When you render using this component:
class NewNative extends Component {
  render() {
    return (
      <Container>
        <Welcome>
          Welcome to React Native!
        </Welcome>
        <Instructions style={styles.overrides}>
          To get started, edit index.ios.js
        </Instructions>
        <Instructions>
          Press Cmd+R to reload,{'\n'}
          Cmd+D or shake for dev menu
        </Instructions>
        <Instructions underlined>
          This should be underlined
        </Instructions>
      </Container>
    );
  }
}

The output is 😗 👌

We're going to need some help from someone who knows their way around RN to make this really good but at least we've proven that it does work.

This is so epic, holy cow


Adapt to Coyl\Git method names

setting the git binary does not work because of the method naming changes in this commit: https://github.com/coyl/git/commit/c8548afd9d948c214a39e752b2710ab64a63ce87

Seconded. I've just made the same changes on my site.


Destroying Navigation Controller

The AlertView is somehow breaking the Navigation sequence, here's a simple case:
NavigationController > ViewController > UITableViewController > Click Cell > Show JSSAlertView > Close JSSAlertView > Hit Back > nothing is done, navigation breaks.
Any idea why this is happening ?

i am also having same problem,

Does this PR solve it? https://github.com/stakes/JSSAlertView/pull/19

Tested, and it seems it is working.


feat(chromium): roll Chromium to r661432

This roll includes:

https://crrev.com/661411 - Update V8 to version 7.6.215.

The new V8 has an updated inspector-protocol dependency that correctly
parses UTF-8 strings
Fixes #4443.

Closing this - we'll need to pick the https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1621848 as well


UI Step 2 - Issue no. 10

@FIN-casey
A "Class" column should be inserted in the table, between the "Background Functional Group" column and the "Species" column.
As discussed on August, 22nd 2016:
If the user populates the “Class” column, then the “Species” column will be automatically populated. The list of species in the “Species” column will come with the possibility to collapse that list.
The first species to appear in the “Species” column should ideally be those for which we have the largest amount of data. (This specific comment is related to #59 ).
The way the classes should be displayed in the "Class" column is explained in the first comment of #67. Please ignore the following comments of #67 that pertain to information buttons; I am going to create a new issue that focuses on the information buttons of UI Step 2.
Please let me know if something is not clear here and/or if you need any additional information.
Many thanks for everything.

@FIN-casey @FIN-JBarile Do you think that it would be doable to address this issue by February, 12th? Many thanks.

@agruss2  @FIN-JBarile
Hi, I included the "Class" column in the table in Step2. It is auto populated based from the Species. The "Class" will have value if the user added a species in the functional group.
The addition of "Class" by the user is not yet implemented. It will be implemented once we have the API that provides a list of species for a given class (referred to #59).

@FIN-casey @FIN-JBarile This is excellent, many thanks!
I think that we have reached our goal in that we now have a "Class" column in the table provided in Step 2. Therefore, I think that we could close the present issue. Do you think we could close the present issue or not?

@FIN-casey @FIN-JBarile I think that this issue can now be closed; I am therefore closing it today.

Hi @agruss2 , there are some implementations left in this issue. These are the implementation of collapse in the species list, and the addition of Class(species will be automatically populated) by the user.
What do you think of reopening this issue?

@FIN-casey You are right; I am going to reopen the present issue. Many thanks

Hi The function of adding Class by the user is now implemented. The ordering of the species is by Data richness but only when Country+SubCountry+FAO combination or Ecosystem was selected by the user in Step1.  When adding class and the user selected Country+FAO combination, the species is not sorted based on data richness, because of the issue I mentioned in #106 regarding large file size.
The list of species is only up to 100, and the species are automatically checked.

Hi The ability to add a class is now implemented. The user can add a class by cllicking the pencil icon on the Class column. The species column is automatically populated and automatically checked. The addition of species uses the API https://github.com/jhpoelen/fb-osmose-bridge/issues/59.

@FIN-casey @FIN-JBarile Thanks a lot for this.
I think that we should reduce the maximum number of species provided for each class. 100 is too much to my mind; providing so many species by class to the user will overwhelm them.
What should be the best maximum number of species to provide for each class, according to you? I was thinking that a maximum of 20 species would be reasonable. However, if I missed something and, for any particular reason, you think that the best maximum number of species to provide for each class should be higher, please explain this to me.

@FIN-JBarile @FIN-casey This comment is similar to the last comment I made in #59
I just made another query for the Gulf of Mexico using the UI.
The list of species provided for each functional group is way too long, and overwhelming.
Here is what I suggest: we provide a maximum of 20 species per functional group. Otherwise, we will get on the user's nerves.
Could you please implement this?
Many thanks

I put a limit on the number of species per functional group to 20 species. Please verify.

When adding a class, the number of species to be included will be the difference of the maximum species which is 20 and the current species count, so that the total number of species will not exceed to 20.
For example, when the user selects Gulf of Mexico. There is fishbathydemersallg functional group that has 2 species. When the user adds a class in that functional group, the maximum number of species to be included is 18. However when the user tries to add a class/species and that functional group has already 20 species, the UI will return an alert of "Can't add species! The maximum number of species per functional group has been reached.".

@FIN-casey Many thanks for having implemented this, this is very great!
I just ran a test for the Gulf of Mexico to check if a maximum of 20 species per functional group yields satisfying results.
This test revealed the absence of a key species (Gag (Mycteroperca microlepis)) in the table provided in Step 2.
Therefore, could you please increase the maximum number of species per functional group to 30; and let me know when this is implemented? I will then run a new test to see if the new list of species provided to the user in Step 2 is more satisfying and will keep you posted.

@agruss2 The maximum number of species per functional group is now 30. Please verify. Thanks.

@FIN-casey This is perfect, many thanks!
I just ran a test for the Gulf of Mexico to check if a maximum of 30 species per functional group yields satisfying results; and the results are satisfying. In particular, Gag (Mycteroperca microlepis) is now included in the table provided in Step 2.
I can therefore close the present issue now.


Fix #137 - Getting rootViewController on iOS

Fix getting the rootViewController on iOS in complex situations.

@cla-bot check

@cla-bot check


Google font imports blocking UI on air gapped environments

Feature Request
Would it be possible to get rid of font import from Google:
@import url(https://fonts.googleapis.com/css?family=Roboto:400,700,500,300);
@import url(https://fonts.googleapis.com/css?family=Roboto+Mono:400,700,500,300);
The problem is, for browsers on air-gapped environments without proxy, fonts fail to import when viewing Jenkins pages and intermittently break/slow down Jenkins UI.
It would be great if they could be included in the theme and served by Jenkins.
Thanks,
Michal

This is tricky because the URLs in the imports use the user-agent header to generate dynamic CSS files for each browser. I will have to have a look if there is a widely supported format that can be used (not sure if woff, woff2 or tff would be best)

Perhaps use the self-hosted Google fonts variant?
https://blog.logrocket.com/self-hosted-fonts-vs-google-fonts-api/

Hi, any updates? China ban google, So...

I have tested the master branch on an instance without internet connection and thus affected by this issue: Fonts and long loading times are gone :+1:.


Create docker inventory group

Create an inventory group for hosts which docker is installed on so the docker related vars are not in group_vars/all.yml

Resolved in #4


feat: try to improve explain result

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Partially implemented my proposal in https://github.com/risingwavelabs/risingwave/issues/4455#issuecomment-1415272437 and https://github.com/risingwavelabs/risingwave/issues/4455#issuecomment-1415315657.
I found that it's difficult to assign a global sequence number to each expression because the Field names are derived in a bottom-up style. So this PR just allocates the number in each Project. In most cases, there are only a few expressions (excluding InputRef) so there won't be many conflicts.
See src/frontend/src/optimizer/plan_node/generic/project.rs for the code changes.
Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features).
[ ] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
[ ] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

[ ] My PR DOES NOT contain user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

What about just using $1 $2, given the fact that we are not using such form at present. I guess the semantics are exact the same as $expr1 expr2

I found that it's difficult to assign a global sequence number to each expression because the Field names are derived in a bottom-up style.
I think we can use a variable ExprDisplayId to assign a global sequence number. ExprDisplayId can be stored in OptimizerContext. Pass it to the project display method if we need.

I found that it's difficult to assign a global sequence number to each expression because the Field names are derived in a bottom-up style.

I think we can use a variable ExprDisplayId to assign a global sequence number. ExprDisplayId can be stored in OptimizerContext. Pass it to the project display method if we need.

Do you mean to pass an ID allocator when calling Display::fmt()? This needs to refactor the code to get rid of the Display trait; otherwise, the signature of Display::fmt() can't be modified.
Or, do you mean to pass an ID allocator when building & optimizing the plan tree? Technically that's possible with the help of OptimizerContext, but I just found it too dirty so I gave up after a few attempts. Because Projects are built in many places and I don't want to mess up these just to pass OptimizerContext.

What about just using $1 $2, given the fact that we are not using such form at present. I guess the semantics are exact the same as $expr1 expr2.

Would $1, $2 mislead you to think that number refers to the i-th output of its child operator?
I am okay with both. Actually I tried $1 at first time and then changed it to $expr1. Also I've added <expr> as $exprX for every $exprX to clarify the meaning to users.

What about just using $1 $2, given the fact that we are not using such form at present. I guess the semantics are exact the same as $expr1 expr2.

Would $1, $2 mislead you to think that number refers to the i-th output of its child operator?
I am okay with both. Actually I tried $1 at first time and then changed it to $expr1. Also I've added <expr> as $exprX for every $exprX to clarify the meaning to users.

I'm OK with $1 since you've already added as $x. Anyway, both LGTM!

Greate thanks to @chenzl25 for updating the PR to fully implemented the initial idea. The PR description has been updated.

I have checked some plan tests and found that we miss handling the StreamProject and Literal expression. I handled it by the way.


Sqoosh removes all EXIF information

Describe the bug
Uploading a JPG file containing EXIF information (e.g. Drone image) and compressing to the same file format (i.e. JPG) using Sqoosh (on both MozJPEG or Browser JPEG compression) removes all EXIF information.
To Reproduce
Steps to reproduce the behavior:

Have a drone JPG image containing EXIF data
Using Sqoosh, convert it to MozJPG or Browser JPG
Save/download
See that EXIF data is now gone

Expected behavior
EXIF data should remain
Version:

OS w/ version: Mac OS X Mojave 10.14.2 (18C54)
Browser w/ version Chrome Version 73.0.3683.103 (Official Build) (64-bit)

Is your issue related to the quality of image compression?
Please attach original and output images (you can drag & drop to attach).

Original image

Output image from Squoosh

This is deliberate right now. Squoosh is about making images as small as they can be, so non-visual data is discarded.
We might consider adding options for this in future, but it isn't our priority right now.

I too recommend(@chaostimothy) this feature for not removing EXIF data.  Technically, it may be a simple option or flag to decide whether to keep or delete EXIF data.  At least please keep the basic(may take < 200 bytes) EXIF data like dates, geolocation, camera name/type etc, because these are used by mobile devices and apps to create photo albums, location-based collection, maps and more.
I hope you @jakearchibald consider these and take an extra step to offer this essential feature as well.

If it's as simple as you say it is then please submit a PR.

@jakearchibald , I mean, from website/UI, we need a single input(checkbox[name=deleteExif]), Exif[true/false], and in the backend, we need to read this single parameter and decide to delete exif data, maybe, if(deleteExif) { deleteExifData() }
It is about adding basic and more value for this product.  I would try sending a PR.

Not all input/output configurations support exif, so I don't think it's as simple as you think (where would this option go?). But, I'll happily review any PR you submit.

Just to note, there is already the "compressor specific settings" under the quality slider.
With such things as mozJPEG saying "show advanced settings", and WebP having additionally "Presenter transparent data".
That seems like it would be the place to put it. If the compressor allows Exif, it goes there, if it doesn't, then there is no option.

I´m also missing an option to keep EXIF-data. Any plans to add that important feature for copyright issues?

Closing this issue for now.
With V2 release and libSquoosh release, we've been consistent with removing EXIF data, and I'd say no-EXIF output is the direction we chose for this project.

I've been using Squoosh for some time, compressing lots of jpegs with EXIF (never really checked whether it's still there), but now knowing that EXIF is purposefully still removed without an option to enable it I'm kind of disappointed. Gonna have to use XnView converter...


fix(ast, ast_codegen): use generate_derive instead of visitable for generating span derives.

follow-up to #4735
I was accidentally using the old code to filter the viable target types to derive. It means before this PR we were still using the #[ast(visit)] for this purpose.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#4747  👈
#4744
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on  Graphite

CI got stuck again. Have force pushed the branch with no changes just to unstick it. @rzvxa FYI. I don't know if this is Graphite playing up again, but same thing happened on the "cursed" stack of last night too.


"Organizations using Johnny-Five" => "Organizations & Projects using Johnny-Five"

Since this entire technical niche is so young, there really aren't many "organizations" (in the traditional sense) that are using Johnny-Five. There are plenty of projects using Johnny-Five and that will be more exciting to see listed.

@rwaldron Related to https://github.com/rwaldron/johnny-five/issues/697 perhaps? Could be auto-generated.

Similar and likely derived from this: https://github.com/rwaldron/johnny-five/search?utf8=✓&q=johnny-five to start


Taping on arrows after swiping.

When click on arrows after swipe slider is jumping over several slides.

Resolved