Air Purifier not supported?

What issue do you have? Please be as thorough and explicit as possible.
Air purifiers reported as not supported during start.  Both model H7122 and H7121.  Supported devices indicates both are supported.  Change log also indicates on/off support for these models.  Does Bluetooth need to be enalbe for these devices?
Details of your setup.

Do you use (1) Homebridge UI-X (2) Homebridge CLI or (3) HOOBS?
I use (1) Homebirdge UI-X

Which version of Homebridge/HOOBS do you have?
 Please also mention your version of Node.js/NPM if known.
MACOS; NPM 8.0.0; Node 14.15.4

Which version of this plugin (homebridge-govee) do you have? Has the issue started since upgrading from a previous version?
homebridge-govee v4.18.0

Which Govee devices do you have that are causing issues? Please include product models if applicable.
H7122 and H7121 - reported in logs as not supported?

Please paste any relevant logs below.

[12/6/2021, 10:24:38 AM] [Govee] Disabling BLE client as no enabled devices configured.
[12/6/2021, 10:24:38 AM] [Govee] [LR Air] is not currently supported, do create a Github issue with the following info:
{"device":"25:F7:D4:AD:FC:05:62:12","deviceName":"LR Air","model":"H7122","httpInfo":{"groupId":0,"device":"25:F7:D4:AD:FC:05:62:12","sku":"H7122","spec":"","versionHard":"1.02.00","versionSoft":"1.00.07","deviceName":"LR Air","deviceExt":{"deviceSettings":"{"wifiName":"*****","address":"D4:AD:FC:05:62:13","bleName":"ihoment_H7122_6213","topic":"GD/c559905a5b4719e5805cce7f6b424668","wifiMac":"D4:AD:FC:05:62:12","pactType":1,"pactCode":1,"wifiSoftVersion":"1.00.07","wifiHardVersion":"1.02.00","ic":0,"secretCode":"NFJTAgIBA1Y=","filterExpireOnOff":1,"sku":"H7122","device":"25:F7:D4:AD:FC:05:62:12","deviceName":"LR Air","versionHard":"1.02.00","versionSoft":"1.00.07"}","lastDeviceData":"{"online":false}","extResources":"{"skuUrl":"https://d1f2504ijhdyjw.cloudfront.net/sku-img/cff9b6cc1a82569bca75e4f4cc659466-add_list_type_device_7122.png\",\"headOnImg\":\"\",\"headOffImg\":\"\",\"ext\":\"\",\"ic\":0}"},"pactType":1,"pactCode":1,"goodsType":79},"isAPIDevice":false}
[12/6/2021, 10:24:38 AM] [Govee] [LR Corner Lamp] initialising with options {"adaptiveLightingShift":0,"brightnessStep":1,"disableAWS":"no","enableBT":"no","logging":"standard"}.
[12/6/2021, 10:24:38 AM] [Govee] [LR Corner Lamp] initialised with id [69:DD:D5:31:30:30:3E:7E].
[12/6/2021, 10:24:38 AM] [Govee] [BR AirPurifier] is not currently supported, do create a Github issue with the following info:
{"device":"7E:67:9C:04:A0:95:33:FF","deviceName":"BR AirPurifier","model":"H7121","httpInfo":{"groupId":0,"device":"7E:67:9C:04:A0:95:33:FF","sku":"H7121","spec":"","versionHard":"1.02.00","versionSoft":"1.00.20","deviceName":"BR AirPurifier","deviceExt":{"deviceSettings":"{"wifiName":"****","address":"9C:04:A0:95:34:00","bleName":"ihoment_H7121_3400","topic":"GD/a26ee8be3dd817aee920f4e1ba884941","wifiMac":"9C:04:A0:95:33:FF","pactType":1,"pactCode":1,"wifiSoftVersion":"1.00.20","wifiHardVersion":"1.02.00","ic":0,"secretCode":"OAhRWANRD1E=","filterExpireOnOff":1,"sku":"H7121","device":"7E:67:9C:04:A0:95:33:FF","deviceName":"BR AirPurifier","versionHard":"1.02.00","versionSoft":"1.00.20"}","lastDeviceData":"{"online":false}","extResources":"{"skuUrl":"https://d1f2504ijhdyjw.cloudfront.net/sku-img/96e6e357d8b360781c9c4564469c4c4a-add_list_type_device_7121.png\",\"headOnImg\":\"\",\"headOffImg\":\"\",\"ext\":\"\",\"ic\":0}"},"pactType":1,"pactCode":1,"goodsType":72},"isAPIDevice":false}

Hi @Jayva2002
Please update to the beta version of the plugin. I’ve gotten a bit ahead of myself with updating the wiki before releasing the new version of the plugin!

Thanks.  That was quick!  Happy Holidays

On Dec 6, 2021, at 10:45 AM, Ben @.***> wrote:
Hi @Jayva2002 https://github.com/Jayva2002
Please update to the beta version of the plugin. I’ve gotten a bit ahead of myself with updating the wiki before releasing the new version of the plugin!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/bwp91/homebridge-govee/issues/154#issuecomment-986898711, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHMPBFXZZ7QLV6W4577KPVLUPTLB3ANCNFSM5JO576QA.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Sure, what ever you need.  I really only need the on/off functions, as I just like to turn everything off when I leave the house.  I am not that tech savoy, but happy to help support a developer anyway I can.
-Jay

On Dec 6, 2021, at 10:46 AM, Ben @.***> wrote:
Currently only on/off is supported. You’re the first person I know with the purifier.
If you’re happy to work with me I can try to implement other features of the purifier,
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/bwp91/homebridge-govee/issues/154#issuecomment-986899803, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHMPBFTITIRA3KSSKIGK2NTUPTLGHANCNFSM5JO576QA.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Could we message on discord? I find it a lot easier and simpler on there
https://discord.gg/cMGhNtZ3tW


Add testing for Mac Catalyst using Cocoapods

This PR adds some tests to the build script which allows us to verify the installation of Realm via Cocoapods on a Mac Catalyst target. A new folder called catalyst has been added under the examples/installation directory which holds the Swift & Obj-c test projects.
The Jenkinsfile explicitly declares the builds because if we are to just tack on "catalyst" to:
for (def platform in ["osx", "ios", "watchos"]) {
      def platformName = platformNames[platform]
      for (def test in ["dynamic", "cocoapods", "carthage"]) {
        parallelBuilds["Installation - ${platformName} Swift ${test}"] = installationTest(platform, test, 'swift')
      }
    }

It would mean that this PR would also need to add test projects for both dynamic and carthage. Which of course can be done but I'll leave that open to discussion.

Some of the licenses need updated dates, otherwise LGTM.


Transactions

Hello there.
session and transaction objects are linked. Is possible known from session object the transaction associated and is it active. And from transaction object the session owner.
Fix 1.

Sorry, I don't understand what is the goal of this PR. Could you please explain whether this is fixing a problem or adding a new feature? If the former, what is the problem exactly, i.e. how can it be reproduced? If the latter, what is the feature for?


#11 Doesn't work

I merged #11 but it doesn't work.  I'll get rid of the automatic node builder in my next PR

@dionjwa - let me know if there's anything I can do on this right now, I'll close if you're all set for now


Make middleware usage independent from load order

Problem:
Right now all middlewares are registered in the same order as the mixins are loaded.
This prevents users from overriding the order without losing the benefit of presets.
It is also not possible for a user to remove a middleware.
Solution (proposal):
Define a registerMiddleware(s) hook (strategy: sequence) that collects all middlewares from all mixins first and in another step read the config for the set of middlewares that is desired. This would also allow a user to ignore/remove a middleware later on.
This requires that all mixins name their middlewares.
Example:
Mixin:
registerMiddlewares() {
  return {
    'my-middleware': (app) => (req, res, next) => {
      ...
    },
  }
}

Config:
{
  middlewares: [
    'my-middleware',
  ],
}

P.S.: Yes, middlewares is a word 😄

I think I see your point, but (as mentioned IRL), I am afraid I am not quite convinced we need to change as much in @untool/express as you propose. Why can we not just add one or two hooks (e.g. optimizeServer) and rely on express' middleware chaining, e.g.:
const cookieParser = require('cookie-parser');
const bodyParser = require('body-parser');

module.exports = {
  initializeServer(app) {
    app.use(cookieParser(), bodyParser(), (req, res, next) => {
      console.log(req);
      next();
    });
    return app;
  }
}

That would, to my mind, mean we have two sorting dimensions (preset/mixin order and hook calling order) plus manual middleware sorting. Combined with a nice organisation of mixins/middlewares into packages we ought to be able to tackle all middleware registration requirements I personally can think of... We should probably make sure we expose all mixins/middlewares consumers might want to reshuffle in our downstream (ahem, hops) packages.
Of course, we cannot enable mixins to get rid of middlewares registered by other mixins, but I am not even sure we should support that - Express.js itself does not as far as I can tell.
@jhiode are there any specific use-cases that we really cannot support with what we have and cannot easily add..? Please excuse me if I am being thick, here. 😉

@dmbch +1 for keeping it as simple as possible and not adding another sorting dimension if we can avoid it.
The app.use approach looks fine, although I can imagine issues arising once the same middleware is used by multiple mixins.
This might not be much of a problem for middlewares such as cookie-parser where the only downside is a tiny performance penalty. However, there are also middlewares that take care of logging or authentication, where multiple execution could lead to unwanted results.
That being said, I'm not entirely sure how often that will actually occur with those middlewares, but I still wanted to voice that concern.

@robin-drexler I do see your point wrt logging/error handling - that is why I am proposing an ‘override’able ‘finalizeServer’ hook.
Other than that, I would like to push the issue downstream, i.e. where requirements are less cloudy and can be addressed in a more specific manner.
With regards to a custom middlewares, we could just build them in a way that makes them run only once..:
‘’’javascript
(req, res, next) => {
if ('user' in res.locals) return next();
// do the usual auth dance
}
‘’’
As you already said, this approach will not help us with external middlewares, but I am sure we can come up with something...

Having thought about this a bit more - and having been pointed to what others are doing by @ZauberNerd, what do you think of a single hook working essentially like this:
const configureExpress = (app, middlewares, phases) => {
  app.use((req, res, next) => next());

  middlewares.intial = (req, res, next) => next();

  middlewareOrder.unshift('preinitial');
  middlewares.preintial = (req, res, next) => next();

  return app;
};

We could start by having the same phases Strongloop has and add other phases on the fly. So, the middlewares object would look something like this:
{
  initial: [],
  session: [],
  auth: [],
  parse: [],
  routes: [],
  files: [], // contains static and webpack dev middlewares
  universal: [], // contains the transpiled React middleware
  final: []
}

I am convinced we would go further down this nice rabbit hole if we try moving things like middleware order into config, so I would really like to keep this things runtime-y. What do you think?

I don't think we need that many phases right now because untool itself doesn't use that many.
I'd propose something like:

initial (for bootstrapping things)
parse (for cookie/body parser)
routes? (do we have "routes" as such? or is it all handled in the universal react middleware)
files (for static file serving)
universal (for our react render middleware)
final (for error handling and such)

Also: The code snippet above doesn't make sense with what you wrote - could you take another look and edit it please?

@ZauberNerd PTAL


Fix debug assertion in create_labels

What
glam on debug now notices that what we have here is a perspective transform. We actually don't quite care about the perspective divide here, but this fixes the issue and still has the correct label ordering (just to be sure I checked with the spiral of labels generated by the old test_api script)

Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested the web demo (if applicable):

Using examples from latest main build: rerun.io/viewer
Using full set of examples from nightly build: rerun.io/viewer

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!
[x] If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

PR Build Summary
Recent benchmark results
Wasm size tracking

To run all checks from main, comment on the PR with @rerun-bot full-check.

I need this, merging without review because it's so trivial


⚠ Bofrost.be has degraded performance

In b94c82b, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1970 ms

Resolved: Bofrost.be performance has improved in aeb35c2.


add optional step.

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Preview environment: https://hdh.pr.harness.io/pr-934

Preview environment: https://hdh.pr.harness.io/null


feat: use of conventient errors for sec errors as well. Also fixed recordErr.

Use convenient errors inside security handlers as well.
This way we can format security responses without modifying error handler which seems a bit better I think. But this can be a breaking change, because if someone is using convenient errors now, they will get 500 error or what they mapped their default response.
If you think I should put this under a new flag, please let me know (or any other suggestion)
Also:
Using convenient errors recordErr was called everytime. It shouldn't be called for non 500 status codes. I've updated this in the second commit.

Wops, forgot to regenerate code after the second commit.


Dependency issues

Hey, recently I've been getting circular dependencies with Rust and anything that depends on LLVM+CMake.
Trying to remove Rust:
ERROR Circular dependency detected llvm <> cmake
Trying to install Rust:
-> rust Checking if package installable
rust
ERROR rust Package not installable, missing 1 package(s)

Trying to remove anything depending on LLVM+CMake:
ERROR Circular dependency detected llvm <> cmake
To get rid of these issues I have to manually edit the depends file in /var/db/kiss/installed/PACKAGE.
The LLVM+CMake issue is because LLVM depends on CMake at build time and CMake depends on LLVM.
This is probably caused by updates to the dependency resolving/fixing.

Since C++ packages automatically depend on LLVM (I'm sure this issue applies to kiss-llvm too) We either need to

Build cmake statically, or
Add all C++ libraries to the exemptions, ala libc, or
Don't count makedepends when detecting circular dependencies

cc: @dylanaraps

Let's do 2. Send me a list
Can't do 3 as circular dependencies == infinite recursion regardless.
1 is just a band-aid until the next package comes along...

The deps should be libc++.so*, libc++abi.so*, and libunwind.so* for LLVM. The GCC equivalents should be libstdc++.so* and libgcc_s.so*.

Done, thanks. https://github.com/kisslinux/kiss/commit/d0228beccf4b5e1b45754151091968bd002c04d7

A new package manager release has been made.

Closing issue. The next build of CMake shouldn't depend on LLVM anymore. However I'll need clarification since @f1nniboy also mentioned Rust:
Does this mean Rust somehow depends on itself?

The depends fixer checks against the current package's manifest (and skips files owned by itself). However, it resolves the library path before the check. Maybe something in your rust package is linked using a relative path (or something)? I can maybe check both resolved and unresolved path in the package manager. Just need to confirm what exactly happened first.

I'm not really sure, I think I'll try to reproduce the possible problem on 29 July, the release date for Rust 1.54.0.

An easy way to try and reproduce right now is to make a dummy rust package, give it<EMAIL_ADDRESS>in sources and have the build file contain cp -rf etc usr "$1". This will make the depends fixer operate on the files (as if you just built rust). Sadly, I cannot reproduce the issue though this may be related: libstd-36b4f48bc15e1a2e.so.

Here's the unresolved list:
/lib/libstd-36b4f48bc15e1a2e.so
/lib/libLLVM-12.so
/lib/libstd-36b4f48bc15e1a2e.so
/lib/libstd-36b4f48bc15e1a2e.so
/lib/libLLVM-12.so
/lib/libtest-5579125dea6f5038.so
/lib/librustc_driver-16def416b0ee71bc.so
/lib/libstd-36b4f48bc15e1a2e.so
/lib/librustc_driver-16def416b0ee71bc.so
/lib/libstd-36b4f48bc15e1a2e.so
/lib/librustc_driver-16def416b0ee71bc.so
/lib/libstd-36b4f48bc15e1a2e.so
/lib/libz.so.1
/lib/libssl.so.1.1
/lib/libcrypto.so.1.1
/lib/librustc_driver-16def416b0ee71bc.so
/lib/libstd-36b4f48bc15e1a2e.so
/lib/libz.so.1
/lib/libssl.so.1.1
/lib/libcrypto.so.1.1

And the resolved list:
/usr/lib/libstd-36b4f48bc15e1a2e.so
/usr/lib/libLLVM-12.so
/usr/lib/libstd-36b4f48bc15e1a2e.so
/usr/lib/libstd-36b4f48bc15e1a2e.so
/usr/lib/libLLVM-12.so
/usr/lib/libtest-5579125dea6f5038.so
/usr/lib/librustc_driver-16def416b0ee71bc.so
/usr/lib/libstd-36b4f48bc15e1a2e.so
/usr/lib/librustc_driver-16def416b0ee71bc.so
/usr/lib/libstd-36b4f48bc15e1a2e.so
/usr/lib/librustc_driver-16def416b0ee71bc.so
/usr/lib/libstd-36b4f48bc15e1a2e.so
/usr/lib/libz.so.1
/usr/lib/libssl.so.1.1
/usr/lib/libcrypto.so.1.1
/usr/lib/librustc_driver-16def416b0ee71bc.so
/usr/lib/libstd-36b4f48bc15e1a2e.so
/usr/lib/libz.so.1
/usr/lib/libssl.so.1.1
/usr/lib/libcrypto.so.1.1

Semi related: https://github.com/kisslinux/kiss/commit/e0afa0c2fbcfd71a76cd42293f21d39a2c7fae9c
Here's the new output:
/usr/lib/libstd-36b4f48bc15e1a2e.so
/usr/lib/libLLVM-12.so
/usr/lib/libtest-5579125dea6f5038.so
/usr/lib/librustc_driver-16def416b0ee71bc.so
/usr/lib/libz.so.1
/usr/lib/libssl.so.1.1
/usr/lib/libcrypto.so.1.1

Nope. Even after 5.5.22 I can't reproduce it using your methods for Wyverkiss' Rust tarball.

Yes, you may need to rebuild CMake.


fix: open directory on edit

What it fixes?

It failed to open directory yesterday. But I cannot reproduce it now.
Sorry for wasting your time.

No worries, if you happen to figure out how to reproduce it, pls let me know.

It should be my problem. I tried it on an empty config vim, it works.


Why  the Train.py-Line#140 [contents]'s parameter is mels?

Thx, I'm reading your code。And, in the demo of some examples, why is the voice fuzzy。

Hi,
There are several reasons.

The learning step may be insufficient. This repository is a personal project and there is a limit of the resources I have. The quality may improve if further steps are trained.

There was a problem with the vocoder. I used a vocoder that was in progress as a personal project  for demo, but there was a critical bug in the vocoder code at the time. Currently, the bug has been resolved, but it is difficult to re-train SpeechSplit with different hyper parameters due to the accumulated training queue. It is on the to-do list.

There may be some bugs in this SpeechSplit code. Even though I have debugged a few times, this code may also contain bugs. If you find that there is any problem while reading the code, why not post it as an issue? It's a great help to me. :)

Thanks,
Heejo


issue a warning or error on constructing Axis with duplicate symbols

Currently, constructing an Axis from a Tuple of symbols silently ignores duplicate symbols and only records position of the last occurrence:
julia> Axis((:a,:a))
Axis(a = 2,)

What is the reason for this behavior?
My use case is attaching positions to an existing Vector: ComponentVector([1,2],Axis((:a,:a)))
I would expect at least a warning here.

Thanks for the issue! Fixed in v0.11.17


Google home pool or pool light devices fail periodically

Seems very strange but I can reliably recreate an error only when the device has one of these names.  The error comes from google home/nest device when I ask it to turn on or off "sorry something went wrong and I'm unable to control your home device".  Sometimes I will get lucky and it will work but more often than not it gives me this error.  If I change the name without the word 'pool' it works fine every time.

The service passes the name field directly to the service when the device is created or edited, then all the name matching is done on the Google Assistant side of things and the service gets passed an numerical id when the device is activated.
So unfortunately there is nothing I can do from my side to influence things.
My only suggestion is to make sure the lights are in a room called something like "Pool House" and then they should respond to things like "Turn on the Pool House lights" no matter what the device is called (assuming they have the light trait)

Very strange.  When I try that e.g. name 'light' and location 'pool' it also fails.  As soo as the word pool is deleted or changed it works

One work around which is silly is that I can say "turn off the light in the pool" then it works.  But flip it and say "turn off the pool light" and I get that error.

All I can suggest is you raise this with Google (if you can find a way to raise a bug)


proxyconnect tcp: dial tcp <IP_ADDRESS>:8889: connect: connection refused

when I  try to download video from bilibili.com, I get this error, and I have closed my proxy utilities.

As you can see from the error message, your proxy is not closed.
So this is a network issue, not software related, I will close this issue


Bug in populate_casgenes.py

The way I was splitting the query into start and end is not working in every case: I got this error when I started running it on more data:
invalid literal for int() with base 10: '>150056'

The queries are like 384792..387492 or complement(384792..387492), but it looks like that might not be all of them.

How do you get the input data? Since it doesn't appear to create it / download it itself and there are no gbfiles yet.

Here's what a problem area looks like on the input gb files:

     gene            complement(1004056..>1004415)
                     /locus_tag="AD871_RS05350"
                     /old_locus_tag="AD871_05350"
                     /pseudo
     CDS             complement(1004056..>1004415)
                     /locus_tag="AD871_RS05350"
                     /old_locus_tag="AD871_05350"
                     /inference="EXISTENCE: similar to AA
                     sequence:RefSeq:WP_000534415.1"
                     /note="incomplete; partial in the middle of a contig;
                     missing start; Derived by automated computational analysis
                     using gene prediction method: Protein Homology."
                     /pseudo
                     /codon_start=1
                     /transl_table=11
                     /product="integrase"

And in the HMMER output files that this script is parsing:
mkCas0115            -          complement(1004056..>1004415) -             0.0025   11.3   0.0    0.0038   10.7   0.0   1.3   1   0   0   1   1   1   1 -

So these are incomplete genes that run off the start or end of a contig. I think we can skip them.


Update README.md to match project

#43

Codecov Report
Base: 72.15% // Head: 72.15% // No change to project coverage :thumbsup:

Coverage data is based on head (3e18a6c) compared to base (a74ed70).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #50   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


fix: klog verbose update

Reason for Change:

Update klog.InfoS to klog.V(5).InfoS
Update makefile target make image as it's no longer available to $(MAKE) container-all push-manifest

Requirements

[x] squashed commits
[x] included documentation
[x] added unit tests and e2e tests (if applicable).

Issue Fixed: #649

Does this change contain code from or inspired by another project?

[ ] Yes
[x] No

If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers:

Codecov Report

Merging #730 (a79945b) into master (26c6319) will not change coverage.
The diff coverage is 66.66%.


mac: add some consistency to setting the XXX_final output length.

The various MACs were all over the place with respects to what they did with the output length in the final call.  Now they all unconditionally set the output length and the EVP layer handles the possibility of a NULL pointer.
The variations were first noted in #12425.

Not sure why there are two Travis entries again.  The builds are successful excepting that it is waiting on an S390 to become available.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged to master.  Thanks.


[DEP]: Add websockets >=12.0 support

Feature request
There are quite a few packages that are using the newer versions of websocket which makes supabase-py  un-usable for a lot of projects where websockets are used.
Describe the solution you'd like
An upgrade of the dependencies to support websockets >= 12.0. This dependency restrictions is from the realtime package, which depends on (>=11.0,<12.0).
This can also be solved by updating the realtime-py package, which included support for websockets >=12.0, < 13.0
Describe alternatives you've considered
Firebase

@silentworks

Version 2.4.1 was just released which should resolve this issue https://pypi.org/project/supabase/2.4.1/.


Package not yet promoted

I've been using your metadata loader and it's a joy. Thank you for your efforts. The ease of use compared to the other available one is night and day.
Now, I would like to install it into Prod, but I can't. You haven't promoted the package. Is this intentional because you don't yet feel confident about it, or is this just an oversight?

@torynet that was a mistake. I just promoted the latest package, you should be able to install it ;)


Switch to es2018 output for Typescript

Allows for native spread syntax in output
Also bump to latest Typescript/tslint release

The typescript compiler can strip comments entirely.  Seems excessive.
Here's something that does light minimization and removes the comments from the output and puts them in a separate file.  I made sure that sourcemaps are preserved and the output actually has newlines...
const TerserPlugin = require('terser-webpack-plugin');

const lib = './shells/lib';

module.exports = {
  mode: 'none',
  optimization: {
    minimize: true,
    minimizer: [
      new TerserPlugin({
        cache: true,
        extractComments: 'all',
        parallel: true,
        sourceMap: true,
        terserOptions: {
          ecma: 8,
          compress: false,
          mangle: false,
          module: true,
          output: {
            semicolons: false
          }
        }
    })
   ]
  },
  devtool: 'source-map',
....

Updating package-lock.json now...  Anyone want to review?


Adding information about flow campaign

I would like to add this campaign for flow stuff in mattermost-redux (I have to create the Help wanted ticket yet) but must be more or less easy to do with the excel already created.

@jespino Made some tweaks to text - one note is that I'm not able to access the spreadsheet (https://docs.google.com/spreadsheets/d/10FmRm5TgpsDIkpvqX1emwVYe33-NQShy4I7LZSZbkPA/edit#gid=0), so we want to make it public before merging this PR.

Thanks @amyblais Now is shared properly :)


Add support of custom IP and port setup of TCP listener and REST server in PuppetDriver

It's needed to be hosted not only on localhost

Was implemented in c7ddcf43f0c52e64a35273010301934ce6d7cbb3
TCP listener start listening all interfaces constant port 6111 => new TcpListener(IPAddress.Any, 6111);
To extend REST server url that is responsible for communication with Puppetry.Puppeteer, you can start PuppetDriver with custom commandline arguments:
--port 6111 => setting custom port for rest server
--baseurl http://<IP_ADDRESS> => setting custom base url for rest server
UseUrls($"{baseUrl}:{port}/")


xScheduledTask: Remove unused non-mandatory parameters from Get-TargetResource

This issue was raised in error.


6504f / Mike Rmaily / https://github.com/MikeRmaily

Repondre a l' inviation de la team github https://github.com/orgs/projets2017cl/teams/nfp103/


boost::filesystem::complete failed on boost 1.86+ in IO.cpp

 		#if BOOST_VERSION >= 105000
 				throw runtime_error(string("Cannot open file ") + boost::filesystem::complete(fullPath).generic_string());

complete method has been remove in boost 1.86
	const string& ext(boost::filesystem::extension(path));
extendsion method also change to path class

This issue duplicates #574 and will be fixed in the 1.4.4 release.

Hi, the issue with boost is resolved in the latest release. You can find it here


Set dependent-sum lower bound in plutus-core.cabal

Here's my take: https://github.com/input-output-hk/plutus/pull/5233


Make it work with multiple sites

This was merged in #12 but removed in commit
5f77835ff27cfc836bada2bfe999876b76ff43fb
This commit reintroduce the change needed to make it work

@oligot sorry, this one slipped through the cracks

@oligot Bold question; maybe you could add a unit test, so this doesn't happen again?

@peteruithoven I was just looking at it. I need to mock Socket.io and System.js-maybe tomorrow evening.

Then you might find the following experiment interesting:
https://github.com/peteruithoven/mocking


Use of the SP500 data

Hi, thanks for your sharing.
I experimented with your sp500 data from the last repository, but in the "data = self.process_finedata(data=data)" have an error.

Could you please help me?

ValueError: [Train, fine market] | ref date number: 1052, extract date number: 1047
missing dates in ref: {Timestamp('2014-07-02 00:00:00'), Timestamp('2014-07-01 00:00:00'), Timestamp('2014-07-08 00:00:00'), Timestamp('2014-07-07 00:00:00'), Timestamp('2014-07-03 00:00:00')}
missing dates in extraction: set()

The error shows that the trading dates of market data do not match that of stock data. From your provide information, please try to set the start date of training to be one month after the start date of the dataset, which depends on the historical window size of the financial indicators defined in the config.py for calculating the available features (The dates that do not have enough historical data to calculate the features will be removed, so that's why the dates from 2014-07-01 to 2014-07-08 are filtered). In your case, you may try to set the start date of training on or after 2014-08-01 00:00:00. Thank you for your kind attention!


chore: bdd-sbrp-import-1586229528 to 0.0.1

chore: Promote bdd-sbrp-import-1586229528 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


net: hostname: trigger an event when the hostname changes

This PR adds two commits:

Add new network event that is triggered when the hostname changes
Add new test case for ensuring that it works properly

@jukkar thanks for reminding me about this enhancements, I will update it.


"Raw" return type nits

While creating the draft refactoring PR, I noticed that for some types, the raw return type isn't handled how I would expect.
Specifically, I would expect a "raw" return type to do two things:

Set the Content-Type header to application/octet-stream (for arbitrary binary data) or image/png (for a png image), etc. This allows browsers to properly handle the result based on content-type.
To return the raw bytes as raw bytes, not as the base64-encoded version as it currently does.

This is blocking deploying of this to make automatic downloads of on the fly converted files.
Thanks!

I believe the 'raw' type should now have just raw bytes instead of base 64 encoded bytes. Not sure why I encoded them in the first place but they are fixed now. If you could give me an example of how you want me to set the content headers so I can make sure I get it right that would be great.

Great! You basically need to return a custom FileResponse and specify the appropriate media type. Which media type depends on which routine -- for returning a zip response, the media type should be application/zip; for returning an image, image/png, etc. See common MIME types here: https://developer.mozilla.org/en-US/docs/Web/HTTP/MIME_types/Common_types

Added streaming response with MIME types. I think I did it right but if you could double check for me that would be great.


CI: The connection to the server k8s1:9443 was refused

https://jenkins.cilium.io/job/Cilium-PR-K8s-1.16-kernel-4.9/3057/testReport/junit/Suite-k8s-1/16/K8sKafkaPolicyTest_Kafka_Policy_Tests_KafkaPolicies/
04124162_K8sKafkaPolicyTest_Kafka_Policy_Tests_KafkaPolicies.zip
The test K8sKafkaPolicyTest Kafka Policy Tests KafkaPolicies failed with error:
Failed to produce to outpost on topic empire-announce
Expected
    <*errors.errorString | 0xc0014bc4d0>: {
        s: "ExecKafkaPodCmd: command 'kubectl exec -n default empire-outpost-8888-568db885cc-pgwtf -- sh -c \"echo 'Vader Booed at Empire Karaoke Party' | ./kafka-produce.sh --topic empire-announce\"' failed Exitcode: 1 \nErr: exit status 1\nStdout:\n \t \nStderr:\n \t The connection to the server k8s1:9443 was refused - did you specify the right host or port?\n\t \n",
    }
to be nil

Probably worth noting that the previous test running was a host firewall one. So this could be some weird infrastructure flake or a flake in the host firewall test that then prevents access to the host. In both cases, it doesn't seem likely to be related to the Kafka test.

If you link to this, please include a sysdump and link to the Jenkins run :pray:

Hit this in https://jenkins.cilium.io/job/Cilium-PR-K8s-1.23-kernel-4.9/434/ on the v1.13 branch on https://github.com/cilium/cilium/pull/23528. Host firewall was not running before, it seems.
I've attached the sysdump, it doesn't seem complete however, since (I assume) the K8s connection is down
754e8d39_K8sAgentIstioTest_Istio_Bookinfo_Demo_Tests_bookinfo_inter-service_connectivity.zip
test_results_Cilium-PR-K8s-1.23-kernel-4.9_434_BDD-Test-PR.zip


Customizing the color of a raised button is way too complex

This is more a rant than a real issue really.
I used to have 4 colors for raised buttons: default - gray, primary - blue, secondary - green, contrast - red
Due to the recent change to the palette that removed the contrast color from I embarked into the task of making an additional custom red button and this is what I ended up with:
import Button, { ButtonClassKey, ButtonProps } from 'material-ui/Button';
import { fade } from 'material-ui/styles/colorManipulator';
import withStyles, { WithStyles } from 'material-ui/styles/withStyles';
import * as React from 'react';
import { errorColor, getContrastText, muiThemeNext } from '../../themes/muiThemeNext';

const styles = {
  raisedPrimary: {
    color: getContrastText(errorColor[600]),
    backgroundColor: errorColor[600],
    '&:hover': {
      backgroundColor: errorColor[800],
      // Reset on mouse devices
      '@media (hover: none)': {
        backgroundColor: errorColor[600],
      },
    },
  },

  flatPrimary: {
    color: errorColor.A400,
    '&:hover': {
      backgroundColor: fade(errorColor.A400, 0.12),
    },
  },
};

class DangerButtonWithStyles extends React.Component<ButtonProps & WithStyles<ButtonClassKey>> {
  render() {
    const classes = {
      ...this.props.classes,
      raisedPrimary: this.props.disabled ? undefined : this.props.classes.raisedPrimary,
      flatPrimary: this.props.disabled ? undefined : this.props.classes.flatPrimary,
    };

    return (
      <Button
        {...this.props}
        classes={classes}
        color="primary"
      />
    );
  }
}

export const DangerButton = withStyles(styles)(DangerButtonWithStyles) as React.ComponentType<ButtonProps>;

My first rant is about having to opt-in and out of classes depending on if the button is disabled or not.
If I don't do this then, since the generated classes have more priority than the default ones then the disabled styles are never applied.
Wouldn't it make more sense to make a deep merge of the current theme classes (including overrides) with the custom ones and then create class names based on that merge so that disabled overrides are not lost?
The second rant is about how overly complex this all seems. Couldn't there be something like this instead?
<Button
  colorOverrides={{
    label:"blue", // label color for both raised and flat buttons
    background: "red" // background color for raised and flat buttons
    hoverBackground: "yellow" // background color on hover for raised and flat buttons
    disabledLabel: "blue" // label color for both raised and flat buttons when disabled
    disabledBackground: "red" // background color when disabled for raised and flat buttons
    ripple: "tomato" // ripple color?
  }}
> hi </Button>

each of those properties would default to undefined, meaning no customization applied and therefore the API is backwards compatible
There's not so much of a problem with IconButton for example, since you can just use something like
export class DangerIconButton extends React.Component<IconButtonProps> {
  render() {
    return (
      <IconButton
        {...this.props}
        color="inherit"
        style={{
          color: this.props.disabled ? undefined : errorColor.A400,
          ...this.props.style
        }}
      />
    );
  }
}

still though it is funny how you have to be careful with not setting the color when disabled, so there could be something like icon, disabledIcon and ripple inside colorOverrides
And same thing about checkbox, etc.
Just my two cents 😄

How come this is closed? There is still no way to change the color and this does not work:
const customTheme = outerTheme => ({
  ...outerTheme,
  palette: {
    ...outerTheme.palette,
    primary: red,
  },
});

Error: index.js:2178 Warning: Material-UI: missing color argument in fade(undefined, 0.12).

@joesanta555 I have added 2 examples in the docs: https://github.com/mui-org/material-ui/blob/faf1ead52970e2b1d4adafed8dc69aaa625c5763/docs/src/pages/demos/buttons/CustomizedButtons.js

Thank you. I read the closed issues before and could not find the 2 examples.
Finally a nice way of doing it 🎉 🎈
Thank you again for this

This is why I think the JSS/CSS-Modules solution is way overboard. I understand why you did it, but there are a lot of cases where it adds way more overhead than it is worth. Honestly, I would love to be able to disable it altogether.
This problem is losing me and my clients money as we speak...

My ultimate dream would be to use css-modules with some theming solution like react-toolbox did. For modern browsers we could use CSS variables which would allow even nested theme support. Material-ui is my favourite ui framework by far, but nothing can beat css modules re performance and productivity. However, I am glad u picked JSS from css-in-js solutions, but missing css-modules anyway :) I know I can still use css-modules, but global Mui component theming must be done with JSS, plus I need to define some vars like colors etc in my css files, instead of importing those from default theme object

@robbyemmert why dont u like css-modules? :)

Honestly, I would love to be able to disable it altogether.

@robbyemmert From an architectural point of view, it should be possible to disable it and extract global CSS. But it would require a bit of effort. What's your issue? Have you seen https://material-ui.com/guides/interoperability/ or https://material-ui.com/customization/themes/#customizing-all-instances-of-a-component-type?
@klis87 We are looking into CSS variables support in #12827. We gonna try to follow the community with what's the most popular styling solution.

@oliviertassinari that's fantastic news, can't wait for this!

I agree that changing button colors is too complex. I want to avoid nesting themes due to performance issues so I've made this custom button component, but I'm not sure if this would have even worse performance issues. I'd love some feedback on it.
It works fine and allows me to set any color for any button variants (i.e. either primaryLight, primary, primaryDark, secondaryLight, secondary, secondaryDark or any html color, such as #ff00ff for either outlined, text or contained buttons). I can also override the font color of the button if needed, and the hover no longer depends on what theme.palette.[primary/secondary].dark is - it's calculated using fade or darken instead.
Here's the code:
// ./Button/useColor.ts

import { useTheme } from "@material-ui/core/styles";

const useColor: UseColor = variant => {
  const theme = useTheme();

  switch (variant) {
    case "primaryLight": {
      return theme.palette.primary.light;
    }
    case "primary": {
      return theme.palette.primary.main;
    }
    case "primaryDark": {
      return theme.palette.primary.dark;
    }
    case "secondaryLight": {
      return theme.palette.secondary.light;
    }
    case "secondary": {
      return theme.palette.secondary.main;
    }
    case "secondaryDark": {
      return theme.palette.secondary.dark;
    }
    case "default":
    case "inherit": {
      return undefined;
    }
    default: {
      return variant;
    }
  }
};

export default useColor;

interface UseColor {
  (variant?: string): string | undefined;
}

// ./Button/index.tsx

import React, { FC } from "react";
import { fade, darken } from "@material-ui/core/styles/colorManipulator";
import MuiButton, {
  ButtonProps as MuiButtonProps
} from "@material-ui/core/Button";
import { makeStyles } from "@material-ui/core/styles";
import useColor from "./useColor";

const useStyles = makeStyles(theme => ({
  textPrimary: (props: StylesProps) => {
    if (props.bgColor) {
      const color = props.fontColor || props.bgColor;
      return {
        color,
        "&:hover": {
          backgroundColor: fade(
            props.bgColor,
            theme.palette.action.hoverOpacity
          )
        }
      };
    }
    return {};
  },
  containedPrimary: (props: StylesProps) => {
    if (props.bgColor) {
      const color =
        props.fontColor || theme.palette.getContrastText(props.bgColor);
      return {
        color,
        backgroundColor: props.bgColor,
        "&:hover": {
          backgroundColor: darken(props.bgColor, 0.25),
          // Reset on touch devices, it doesn't add specificity
          "@media (hover: none)": {
            backgroundColor: "transparent"
          }
        }
      };
    }
    return {};
  },
  outlinedPrimary: (props: StylesProps) => {
    if (props.bgColor) {
      const color = props.fontColor || props.bgColor;
      return {
        color,
        border: `1px solid ${fade(color, 0.5)}`,
        "&:hover": {
          backgroundColor: fade(
            props.bgColor,
            theme.palette.action.hoverOpacity
          ),
          border: `1px solid ${color}`
        }
      };
    }
    return {};
  }
}));

const Button: FC<ButtonProps> = ({
  children,
  color = "default",
  fontColor,
  ...props
}) => {
  const { variant } = props;
  const bgColor = useColor(color);
  const classes = useStyles({ bgColor, fontColor });

  let btnClasses: Record<string, string> | undefined;
  let btnColor: MuiButtonProps["color"];
  if (color !== "default" && color !== "inherit") {
    btnColor = "primary";
    switch (variant) {
      case "contained": {
        btnClasses = { containedPrimary: classes.containedPrimary };
        break;
      }
      case "outlined": {
        btnClasses = { outlinedPrimary: classes.outlinedPrimary };
        break;
      }
      case "text":
      case undefined: {
        btnClasses = { textPrimary: classes.textPrimary };
        break;
      }
      default:
        break;
    }
  } else {
    btnColor = color;
  }

  return (
    <MuiButton {...props} classes={btnClasses} color={btnColor}>
      {children}
    </MuiButton>
  );
};

export default Button;

export interface ButtonProps extends Omit<MuiButtonProps, "color"> {
  readonly color?: string;
  readonly fontColor?: string;
}

interface StylesProps {
  readonly bgColor: string | undefined;
  readonly fontColor: string | undefined;
}

I want to avoid nesting themes due to performance issues so I've made this custom button component, but I'm not sure if this would have even worse performance issues. I'd love some feedback on it.

Do you have an example that we could profile? I'm not aware of noticeable performance implications when nesting themes.


Sonic Adventure 2 (Steam) Crashing

Describe the bug

A clear and concise description of what the bug is.
White screen when booting up Sonic Adventure 2
Which Remix version (include branch and commit info for dxvk and bridge if not a stable build)
0.1.1
Which GPU
RTX 2060 12GB
Which GPU driver version
531.68
Which game build (and whether it is from Steam/GOG/Other)
Steam
Attach logs!
NvRemixBridge.log
NvRemixBridge.log
d3d9.log
d3d9.log
The game specific log will be named gamename_d3d9.log
sonic2app_d3d9.log

To Reproduce
Steps to reproduce the behavior:

Extract .zip from releases into game folder with exe
Crash
Expected behavior
A clear and concise description of what you expected to happen.
Run the game with RTX Remix
Screenshots
If applicable, add screenshots to help explain your problem.

Hello! Will you please test this on the latest release and let us know if the issue persists? Thank you!

The menu appears and the game is playable, you do have to enable v-sync or else the game is sped up, but apart from being able to ignore a texture in the game setup menu, RTX remix seems to do nothing
Logs:
sonic2app_d3d9.log
d3d9_01.log
NvRemixBridge_01.log

Thank you for confirming that the crashing is fixed. Will you please open a new ticket for the issue with the Remix menu? That way we can investigate and track it separately. Thanks!

👍


endSendingPlayMessages being called twice on dealloc

Is it intentional to call endSendingPlayMessages twice on dealloc here and here?

I don't believe it's intentional, although the second time it's called it should be a no-op.


A Spanish Version

A Spanish Version of the _data/data.yaml file

I am working on it

Fantastic work. The only issue is that I wouldn't be able to double check your work because I don't know how to speak/ read in Spanish.  Maybe one of your friends can chime in too?

@alanfriedman as we can see here he has created a separate data.yaml for the spanish version. Should it be incorporated into one for maintenance and for ease of pulling the data or keep those two files separate?
@jesusmtzarvizu if you do find any duplicates/ spelling errors in the English version please feel free to let me know. It'll make our job much easier.

We should definitely keep them separate, using a naming convention like data-es_ES.yml. My first thought is checking a locale query param in the URL and choosing the data file based off that (http://trumptracker.github.io?locale=es_ES => data-es_ES.yml)

Seems reasonable - maintenance will suck when adding new policies though.

We can use automated translation (Google translate, etc) until someone has time to do it manually.

If we make a spanish translation, a translation for every language should be allowed. But is it actually that useful?

Only implementing an English and Spanish version because they're the two most spoken languages in the US.

I think it's definitely useful. We can start with Spanish and if someone wants to submit a new language they just add a new data.yml file.

I think we should indeed draw the line at English and Spanish, because if a new policy is added, we have to update every language file otherwise it will be outdated.

Sounds good

Puedo hablar español. What's the status on translations @jesusmtzarvizu ?

I am Sorry I was enrolled on a Big project and my time is limited now so I didnt translate it.

@iProdigy any chance you can work on this?

It would be my pleasure @VirenMohindra.
In a week my schedule will be more free to allow me to begin translating. I also want to note that while I am not a native speaker of Spanish, I am fluent with five years of experience...

Sounds good, thank you!
If you do find any repetitions in the English version of the data.yaml please feel free to make PR's to join them!

I would like to help out with this. I also have a non-technical Spanish speaking friend that is willing to help out with translations.

@myyk perfect! Please feel free to perform any PR's


gi is a reserved alias in PowerShell

In PowerShell gi is the alias for get-item if someone was to use your PowerShell command they would find that it would not work as expected.  I would suggest changing the name to something else.  Such as gitignore or giti.  If PS naming standards are to be followed I'd suggest Get-GitIgnore (even though that doesn't exactly roll off the tongue).

Changed this command to gig and updated documentation.


Could not find com.google.android.gms:play-services-ads-lite:12.0.1

> > A problem occurred configuring project ':react-native-admob'.
>       > Could not resolve all dependencies for configuration ':react-native-admob:_debugPublishCopy'.
>          > Could not find com.google.android.gms:play-services-ads-lite:12.0.1.
>            Searched in the following locations:

I get an error, com.google.android.gms: play-services-ads-lite: 12.0.1.
help.

Hi, mine too is experiencing the same error...

I have the same issue just happened yesterday. Looks like some one answer in https://stackoverflow.com/questions/50786718/could-not-find-com-google-android-gmsplay-services-ads-lite12-0-1
Not sure it will work or not.

Showw !!
Really is this, I made the change in the file android/build.gradle and worked.
buildscript {
repositories {
maven { url "https://maven.google.com" }
    jcenter()
...
 ...
allprojects {
 repositories {
   mavenLocal()
   maven { url "https://maven.google.com" }
     jcenter()
     ...
 ...

@lhonay I'm glad you solved your problem, but my problem is not resolved.

I solve the problem too just like @Ihonay.
Here is my build.gradle
// Top-level build file where you can add configuration options common to all sub-projects/modules.

buildscript {
    repositories {
        maven { url "https://maven.google.com" }
        jcenter()
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:2.2.3'

        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files
    }
}

allprojects {
    repositories {
        mavenLocal()
        maven { url "https://maven.google.com" }
        jcenter()
        maven {
            // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
            url "$rootDir/../node_modules/react-native/android"
        }
    }
}

Hope it can helps.


Classic report cards style adds extra space when defining apex URL

When you define the card button as standard apex link instead of using sql query link, it adds some white extra space.

This brings me another concern, which is that we shouldn't have link substitution strings altogether.

Instead we should use APEX built-in link feature in the column attribute.
I will push this back to a further release, but thanks for bringing it to my attention.

Yes, I think that simplest solution would be that, as the apex way covers this already.


Enhance/force numeric data in audio objects

Which issue(s) are closed by this pull request?
Closes #431, requires #436 (merged) and #453 (merged)
Changes proposed in this pull request:

add tests for type and values of input data in _Audio class
apply tests in __init__ and time/freq setters of all audio classes
adapt old tests
add new tests

I did not find a way to check for boolean data, because it is converted to float when calling np.atleast_2d(data). Any ideas?

It is just for Signal, not for FrequencyData right?

Jein. Numeric data types are enforced for all audio objects, i.e., you can not store arrays of string in TimeData.time but numeric values are enforced only for Signal, i.e., you can store NaN's in TimeData.time and FrequencyData.freq but not in Signal.time or Signal.freq.


Docs: Backfill all Storefront components documentation

First task: Add Overview and Usage to all docs
Second: Add any missing info
Third: Re-org sidebar
Fourth: Make a template markdown file for future components

:tada: This issue has been resolved in version 0.12.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Added test for MySQL long strings

For some reasons, nanodbc does not properly bind and retrieve long strings from/to MySQL (MariaDB). It cuts this strings to first 128 bytes. blob_test() does not cover this bug.

The test is failing on both, Linux (Travis CI job 629.3) and Windows (AppVeyor job 1.0.303)

Yes, I will try to bring fix for nanodbc (not for test) this week.

All tests passed successfully.

I'm travelling until the 13th of Nov, without laptop so can't really review
it. But, if all the current tests pass and the fix is covered with a test
too, sounds good to me.
When I'm back, I'll continue with bind functions refactoring. So better if
we merge pending PRs since the refactoring may be a bit intrusive.
On 6 Nov 2016 00:12, "Amy Troschinetz"<EMAIL_ADDRESS>wrote:

@lexicalunit approved this pull request.
LGTM! @mloskot https://github.com/mloskot, your thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lexicalunit/nanodbc/pull/212#pullrequestreview-7323392,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAE7ZWblWoay2abwna52PxbChYQnIB1xks5q7Q1zgaJpZM4KLdjZ
.


Reader role can't view functions within a function app

This document doesn't mention it, but users with reader level access also can't see the functions within a function app.  In left navigation, you see:
Functions (No access)
Proxies (No access)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8b3ea2e8-963b-cc01-3d5c-4fecd6a3cec1
Version Independent ID: 198149eb-9b33-ec3f-527f-ae64fb96d65c
Content: Troubleshoot role-based access control Azure RBAC | Microsoft Docs
Content Source: articles/active-directory/role-based-access-control-troubleshooting.md
Service: active-directory
GitHub Login: @rolyon
Microsoft Alias: rolyon

Thanks for your feedback. We will investigate update as appropriate.

@danmyhre Please note that your observation is correct. However, as a reader level permission, you are restricted to check inside a related function implementation in function app. However, you can go to Platform Features tab and navigate to All Settings to check out all setting related to Function App (similar to web app), though as expected reader permission limits you to modify any setting.

@MohitGargMSFT thank you for confirming.  Would be great to add this to the page.  Thanks!

@danmyhre Sure, I am assigning this to author to take a look at it and update as appropriate.

Thanks, I'll take a look.
#in-process

I incorporated MohitGargMSFT research and added a section in the Troubleshooting article for Azure Functions. Let me know if this does not address.
https://docs.microsoft.com/en-us/azure/active-directory/role-based-access-control-troubleshooting#azure-functions
thanks
#please-close

I stumbled upon this issue while trying to create a custom RBAC role in Azure. I'd like to create a role that has reader actions but also has access to whatever actions are needed to view the functions within a function app as well as the monitoring subsection of the interface. The idea is to create a role for a class of operator users which might need the ability to view recent executions and confirm a given function isn't experiencing any issues, but without the ability to make any changes to the function. It looks though like requests that power the functions user interface point to the functions site itself rather than the Azure api. Is there any way to delegate read-only this access to this information based on an Azure RBAC role? Is there a more preferable way?


Incorrect Pagination Behavior on Changing Items Per Page

Pagination - (22 results) I set the pagination to display 10 results per page. Then, I navigate to the second page. After that, I change the pagination to show 25 results per page. Instead of displaying all 22 results, it shows 'No Items.

Resolved in PR: Fix/Incorrect-Pagination-Per-Page

This was fixed in v1.1.21


bugfix Delta Green by ArcDream V2.03

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[ ] The pull request makes changes to files in only one sub-folder.
[ ] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[ ] I have followed the Character Sheets Standards when building this sheet.

[x] I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

It was a small fix that affected a minority of existing sheets.
The data of  art, craft, pilot, science, military_science has been moved to the new
art_1, craft_1, pilot_1,science_1, and military_science_1.
Recovered the adaptation information from sheet version 1.7 (helplessness_1/2/3 moved to the helplessness value 0/1/2 and violence_1/2/3 moved to the violence value 0/1/2)
File changed: deltagreen.html and sheetworkers_versioning.js

Character Sheet Info Roll20 Internal Use only.


fix: fix minor codestyle issue in loader.php to make easy-coding-stan…

Issue
There was one nasty CS issue that popped up in every PR I tried to create the last few weeks.
Solution
Run CS:fix and make the code style gods happy.

coverage: 87.937%. remained the same
when pulling 2e2e2782ac7b67a0e08dd6a6cb7ddbf8d8482be4 on 2.x-fix-minor-lint-issue
into 15fdc38307b593847ad0e7ef6e9b07cd0438295a on 2.x.


nvidia_x11: 510.47.03 → 510.54

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This version bump appears to fix power management (i.e. suspend) on Wayland, at leat for my system. I doubt enabling it by default is a good idea yet, but it might be soon; suspending a Gnome session on Wayland without having power management enabled, terminally corrupts the display server state.

That's nice to know regardless. I have suffered that suspend/resume issue before.


feat(headless/commerce): temporarily fetch and apply redirection triggers from /search endpoint for standalone search box controller

https://coveord.atlassian.net/browse/CAPI-865

This branch is a total mess; I'll cherry pick the right commits and open a new PR


Use  write in stop and persist

Description of new feature, or changes

I noticed that the method Halo._write is used everywhere, except in Halo._stop_and_persist, where the string is written directly to the _stream.
In pytest the output is captured and the stream gets closed after the test, so this fix was critical for me.
Checklist

[x] Your branch is up-to-date with the base branch
[x] You've included at least one test if this is a new feature
[x] All tests are passing

Related Issues and Discussions

People to notify

Pull Request Test Coverage Report for Build 407

1 of 2 (50.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.019%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

halo/halo.py
1
2
50.0%

Totals

Change from base Build 406:
0.0%

Covered Lines:
306

Relevant Lines:
330

💛  - Coveralls

@ushpizin Thanks for working on this. LGTM! Can you bump the version as well before I merge this?

Sure 👍


Remove unused var

The variable safe_method_name was assigned but never used.
Given the number of times we use this, I think this is a useful enough change, so I bumped the VERSION to 1.0.2.

👍

:goat: nice catch.


Add profile name validation and unit tests

Give a more descriptive error message if the profile name provided is invalid:
RuntimeError
------------
Invalid profile name 'mylinux'. Must contain /, e.g. 'john/ssh'

Adds unit tests for this case, but also for correct profile names

@andy-dufour raising the bar with the tests :)

Thanks @alexpop


SideMenu fills whole screen if i use "storyboard.instantiateViewController"

New Issue Checklist

I have read the guidelines for contributing and I understand:

[x] My issue is happening in the latest version of SideMenu.
[x] My issue was not solved in the README.
[x] My issue can not be answered on stackoverflow.com.
[x] My issue is not a request for new functionality that I am unwilling to build and contribute with a pull request.
[ ] My issue is reproducible in the demo project.

Issue Description

Please reproduce the issue with the demo project.

Hello, i hope u are doing well
Thanks for reply
Okay. I will reproduce the issue with demo project and screenshots.
On Wed, Oct 3, 2018 at 9:32 PM Jon Kent<EMAIL_ADDRESS>wrote:

Closed #410 https://github.com/jonkykong/SideMenu/issues/410.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jonkykong/SideMenu/issues/410#event-1882827751, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Am40tJtGui8lgJsw7_B1sMY5vk9ma5DEks5uhRC8gaJpZM4XDwjC
.


Support rendering variable attachment points

Examples of what these look like:

Note that the coordinate generation still won't do anything sensible with these (the examples are all read in from mol blocks), that's one for another day (and another PR)

Note that the supposed test failures here are an artifact of the switchover from old-style to new-style azure pipelines integration


[Snyk] Security upgrade python from 3.9-slim to 3.13-slim

Snyk has created this PR to fix 4 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):

cmd/suggestion/optuna/v1beta1/Dockerfile

We recommend upgrading to python:3.13-slim, as this image has only 37 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Integer Overflow or Wraparound SNYK-DEBIAN12-ZLIB-6008963
  500

Improper Verification of Cryptographic Signature SNYK-DEBIAN12-APT-1541449
  150

Improper Verification of Cryptographic Signature SNYK-DEBIAN12-APT-1541449
  150

Improper Input Validation SNYK-DEBIAN12-COREUTILS-1543939
  150

Race Condition SNYK-DEBIAN12-COREUTILS-1543947
  150

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Improper Input Validation

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 72.974%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
3116

Relevant Lines:
4270

💛  - Coveralls


Are there any docs for imgui-rs?

Hey there, are there any docs for imgui-rs?

You can find the doc for imgui-rs 0.8.0 on docs.rs or compile it yourself.


fixed by setting id to both identity attribute and display attribute

I have tested these changes and  issue has been resoved.


Reduced Docker image size: removed pip cache

Proposed changes:

Use --no-cache-dir in pip install to reduce image size
Managed to reduce more than 100Mb in local tests

Status (please check what you already did):

[x] made PR ready for code review
[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Turkish Translation

Hello,
I translated all of 12factor's document to Turkish.

Wonderful - thank you!


CI is non-deterministic

Category
Other
Describe the feature you'd like to request
CI is non-deterministic. This failure: https://github.com/cedar-policy/cedar/actions/runs/7464644346/job/20312068201?pr=576 is the same issue Victor noticed here: https://github.com/cedar-policy/cedar-java/pull/72/files#r1437156141 and only sometimes occurs (PR that doesn't catch issue: https://github.com/cedar-policy/cedar/actions/runs/7465002067/job/20313236263?pr=577)
We want property testing to "eventually" catch errors, but this shouldn't come at the cost of non-deterministic CI. Ideally we make this deterministic and run property testing nightly or some similar solution.
Describe alternatives you've considered

Status quo.

Run property tests long enough that we convince ourselves future failures happen less than 1% of the time (or whatever bound we choose) .

Additional context
No response
Is this something that you'd be interested in working on?

[X] 👋 I may be able to implement this feature request
[ ] ⚠ This feature might incur a breaking change

CI seems to stabilize. Close it for now.


Expose computed margins

Could provide more detail than you can get from the exposed scales, e.g. when there’s faceting or insets.
Related:

https://github.com/observablehq/plot/issues/1192

This could be as simple as setting figure.dimensions = dimensions (though we might want to have a function here instead, and maybe be defensive about mutations by returning a copy of the dimensions object).


"Add watch expression" command

The most we are currently doing is to copy the expression+casting to the clipboard, which the user can then paste into the Watch window.
Ideally, this command would simply add a new watch.

This is now tracked in https://github.com/zspitz/Periscope/issues/2.


How to handle twilio in background mode, when my initial page is not calling screen

I want a help in how can we handle twilio in background or kill mode. I am usinga view controller for calling which is not the initial view controller for app. But I want to handle callkit in case of background or kill mode. Please let me know how can we do the same.
Urgent help required for this

Hi @deftsoftiphone
As the sample code we provided in the quickstart, the most important thing of handling PushKit notification is to always have the PkPushRegistry object initialized at the very beginning of the app, for example the AppDelegate. As long as the PushKit/CallKit policy is complied, the rest is up to your application UI/UX design.


Better Luncher for Genshin

Epic Games is releasing in June 9, but I prefer yours cuz it has a better download performance.

No such plans, sorry. Also there's nothing special to the download code and unpacking even takes longer than the official, so it may just be a placebo. Appreciate the thought though.


schedule: add IsFeatureSupported in Cluster Interface

Signed-off-by: Zheng Xiangsheng<EMAIL_ADDRESS>
What problem does this PR solve?

schedule: add IsFeatureSupported in Cluster Interface
add JointConsensus  Feature type

What is changed and how it works?

mv version.go to versioninfo package

Check List

Tests

Unit test

Release note

I think IsFeatureSupported and IsCompatible should merge into one function.
Consider this case: A feature is introduced by 5.1.1, after all tikv upgrade to 5.1.1, the feature is enabled. Then another 5.1.0 tikv starts to join the cluster. Since PD use IsCompatible to check, the TiKV will join successfully.

/run-all-tests

/merge


Bloxstrap installer bug

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] My answer given in the checkbox above is a lie.

What problem did you encounter?
So I recently factory reset my pc. When I first got my pc there was a bug with Roblox that would automatically close the installer after being ran. So I resorted to Bloxstrap's force installation which worked. But ever since I factory reset my pc Bloxstrap has been having the same issue Roblox had (closing the installer after being ran). I went to the discord server for help but I did not get the bug fixed there.
The file I want to attach is to big for github. The file I will attach is me running Bloxstrap as an admin (recommended from the discord server). The file that is too big is the whole process of me installing Bloxstrap.
https://github.com/user-attachments/assets/5c8eea54-340f-4f28-8e3e-ece76ad09e94

[!IMPORTANT]
Issue resolved on Discord (post)


Fix crash when reimporting with Skeleton3D selected.

Closes https://github.com/godotengine/godot/issues/74059

Thanks!


Fixing ACM validation by iterating over SANs and creating route53

Summary | Résumé
The route53 records in the acm validation config were only creating the first entry. If there are SANs, they validation records were not being created, and thus cert validation was failing. This change adds all records.
Test instructions | Instructions pour tester la modification
terragrunt apply in staging.

So I guess this LGTM but what do I know 😬  I see you've just added Pat which I was going to suggest might be a good idea!

So I guess this LGTM but what do I know 😬 I see you've just added Pat which I was going to suggest might be a good idea!

The good news is that if this doesn't work, it's a very smooth roll back, which is the next step if this doesn't go


Differentiating Actions for getPhoneContacts Method in Call Transfers

Hello,
During an ongoing call, there are two options for transferring the call:
Transfer to an agent via the Add Caller button
Transfer to a queue via the Blind Transfer button.
Both of these actions trigger the getPhoneContacts method. However, there is currently no way to determine which action triggered the method call. This distinction is necessary because I need to display the list of available queues for the blind transfer option and the list of available agents for the add caller option.
The getPhoneContacts method already includes an argument for filters. Would it be possible to pass information about the triggering action (either Add Caller or Blind Transfer) to this method? This enhancement will allow for appropriate filtering and display of the contact lists based on the action taken by the user.
Thank you.

I'm interested in this feature as well. We have permissions that limit who/what an agent can transfer to based on the transfer type. Right now we have to still show all the potential transfer options and fail the transfer if they attempt to pick an agent or queue they cannot transfer to. It's not an ideal use experience.


Error during installation of required python packages - Uninstall pip-23.1 [Errno 1] Operation not permitted

Deployment Method

[ ] Installer
[ ] Docker Development
[x] Docker Production
[ ] Bare metal Development
[ ] Bare metal Production
[ ] Digital Ocean image
[ ] Other (please provide a link Steps to Reproduce

Describe the problem*
At task "Installing required python packages from 'requirements.txt'" i get an error message.
Is it the PIP installed on the host system (RaspberryPi) or already in some container? I tried reinstalling and updating the systems python and PIP without any success.
Steps to Reproduce

download the .env, docker-compose.yml and nginx.prod.conf to raspberry pi
create /mnt/usbhdd/inventree-data
add /mnt/usbhdd/inventree-data path to .env file
add dbuser and dbpasswrd
execute docker compose run inventree-server invoke update

# InvenTree environment variables for a postgresql production setup

# Location of persistent database data (stored external to the docker containers)
# Note: You *must* un-comment this line, and point it to a path on your local machine

# e.g. Linux
INVENTREE_EXT_VOLUME=/mnt/usbhdd/inventree-data

# e.g. Windows (docker desktop)
#INVENTREE_EXT_VOLUME=c:/Users/me/inventree-data

# Default web port for the InvenTree server
INVENTREE_WEB_PORT=1337

# Ensure debug is false for a production setup
INVENTREE_DEBUG=False
INVENTREE_LOG_LEVEL=WARNING

# InvenTree admin account details
# Un-comment (and complete) these lines to auto-create an admin acount
#INVENTREE_ADMIN_USER=
#INVENTREE_ADMIN_PASSWORD=
#INVENTREE_ADMIN_EMAIL=

# Database configuration options
# Note: The example setup is for a PostgreSQL database
INVENTREE_DB_ENGINE=postgresql
INVENTREE_DB_NAME=inventree
INVENTREE_DB_HOST=inventree-db
INVENTREE_DB_PORT=5432

# Database credentials - These must be configured before running
# Uncomment the lines below, and change from the default values!
INVENTREE_DB_USER=knochi
INVENTREE_DB_PASSWORD=1234

# Redis cache setup (disabled by default)
# Un-comment the following lines to enable Redis cache
# Note that you will also have to run docker-compose with the --profile redis command
# Refer to settings.py for other cache options
#INVENTREE_CACHE_HOST=inventree-cache
#INVENTREE_CACHE_PORT=6379

# Options for gunicorn server
INVENTREE_GUNICORN_TIMEOUT=30

# Enable custom plugins?
INVENTREE_PLUGINS_ENABLED=False

# Image tag that should be used
INVENTREE_TAG=stable

COMPOSE_PROJECT_NAME=inventree-production

Relevant log output
pi@raspberrypi:~/InvenTreeDocker $ docker compose run inventree-server invoke update
[+] Running 1/0
 ✔ Container inventree-db  Running                                                                                0.0s
Loading config file : /home/inventree/data/config.yaml
Installing required python packages from 'requirements.txt'
Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple
Requirement already satisfied: pip in /usr/local/lib/python3.9/site-packages (23.1)
Collecting pip
  Downloading https://www.piwheels.org/simple/pip/pip-23.1.2-py3-none-any.whl (2.1 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.1/2.1 MB 897.0 kB/s eta 0:00:00
Installing collected packages: pip
  Attempting uninstall: pip
    Found existing installation: pip 23.1
    Uninstalling pip-23.1:
ERROR: Could not install packages due to an OSError: [('/usr/local/lib/python3.9/site-packages/pip-23.1.dist-info/entry_points.txt', '/usr/local/lib/python3.9/site-packages/~ip-23.1.dist-info/entry_points.txt', '[Errno 1] Operation not permitted'), ('/usr/local/lib/python3.9/site-packages/pip-23.1.dist-info/AUTHORS.txt', '/usr/local/lib/python3.9/site-packages/~ip-23.1.dist-info/AUTHORS.txt', '[Errno 1] Operation not permitted'), ('/usr/local/lib/python3.9/site-packages/pip-23.1.dist-info/REQUESTED', '/usr/local/lib/python3.9/site-packages/~ip-23.1.dist-info/REQUESTED', '[Errno 1] Operation not permitted'), ('/usr/local/lib/python3.9/site-packages/pip-23.1.dist-info/WHEEL', '/usr/local/lib/python3.9/site-packages/~ip-23.1.dist-info/WHEEL', '[Errno 1] Operation not permitted'), ('/usr/local/lib/python3.9/site-packages/pip-23.1.dist-info/INSTALLER', '/usr/local/lib/python3.9/site-packages/~ip-23.1.dist-info/INSTALLER', '[Errno 1] Operation not permitted'), ('/usr/local/lib/python3.9/site-packages/pip-23.1.dist-info/LICENSE.txt', '/usr/local/lib/python3.9/site-packages/~ip-23.1.dist-info/LICENSE.txt', '[Errno 1] Operation not permitted'), ('/usr/local/lib/python3.9/site-packages/pip-23.1.dist-info/METADATA', '/usr/local/lib/python3.9/site-packages/~ip-23.1.dist-info/METADATA', '[Errno 1] Operation not permitted'), ('/usr/local/lib/python3.9/site-packages/pip-23.1.dist-info/top_level.txt', '/usr/local/lib/python3.9/site-packages/~ip-23.1.dist-info/top_level.txt', '[Errno 1] Operation not permitted'), ('/usr/local/lib/python3.9/site-packages/pip-23.1.dist-info/RECORD', '/usr/local/lib/python3.9/site-packages/~ip-23.1.dist-info/RECORD', '[Errno 1] Operation not permitted'), ('/usr/local/lib/python3.9/site-packages/pip-23.1.dist-info/', '/usr/local/lib/python3.9/site-packages/~ip-23.1.dist-info', '[Errno 1] Operation not permitted')]

@Knochi did you use default settings or is the container running non-privileged? Could be that.

Default mode

@Knochi could this be related - https://stackoverflow.com/questions/70195968/dockerfile-raspberry-pi-python-pip-install-permissionerror-errno-1-operation - ?

Thanks, I will give that a try.

Gave up on this.


Caching does not begin from the current frame when refreshing cache.

On long movies or long .otio edits, with a cache setting set to Gigabytes (ie. a long ReadAhead / ReadBehind), when refreshing the cache by calling:
    io::Options options = player->getIOOptions();
    options["refresh"] = randomString();
    player->setIOOptions(options);

The caching does not begin from the current frame but begins from the beginning of the movie / edit, making it slow to interact with.

I thought I fixed this a couple of weeks ago, are you seeing it with the latest code?

No. I just added that to force the IOOptions to be different.  I assumed you might have been doing a compare of, as usual:
Player::setIOOptions(const io::Options& value)
{
if (p.ioOptions == value)
return;
...etc...
}
If it is not needed, let me know.

And yes, I am seeing that in current branch, when I call the refresh_cache_cb() in my code.

I added the refresh() as I was getting the IOOptions from the player.  So, that for example, the OpenEXR "Layer" option is not changed.  I saw that you were doing:
player->setIOOptions({});
But that would reset the OpenEXR layer selection.

I checked in a change so the player now requests the current video frame first when caching, this should hopefully make skipping frames more interactive. I would also recommend not setting the cache read behind too high, it's just meant to keep a few frames for stepping back and forth.
Instead of setting the I/O options you can also use timeline::Player::clearCache() to clear the cache.

Thanks.  I think the main culprit was the ReadBehind.  Once I left it at 0.4secs without trying to increase it due to the memory setting, the workflow became interactive.


Can't get it to work

Trying to use it for a conntection to a solar inverter.
My command line:
./tcp-multiplexer server -p modbus -v -t <ip solar inverter>:<port solar inverter> -l 65008
Trying to connect to the server with a Windows client called QModMaster (https://sourceforge.net/projects/qmodmaster/files/). Connection seems to be successful as I can see both from the Windows Client and the output on the server.
Then I try to read a holding register. This is what I get on the server:
DEBU[2024-05-28T20:09:16Z]/home/runner/work/tcp-multiplexer/tcp-multiplexer/pkg/multiplexer/multiplexer.go:131 github.com/ingmarstein/tcp-multiplexer/pkg/multiplexer.(*Multiplexer).handleConnection() Message from client...
%s([]uint8) (len=12 cap=16) {
 00000000  00 01 00 00 00 06 01 03  90 8c 00 02              |............|
}

But the windows clent says: "Read data failed. System exception [Unknown error]". Sometimes the error is "Read data failed. Error: timeout".
If I connect directly to the inverter after stopping the tcp-multiplexer, I can see real data in the windows client. Any idea whats wrong here?

The command line looks good and the request from the client reaches tcp-multiplexer. The request data appears to be a valid modbus message, too.
Could you paste the remaining log? Anything about the connection from the multiplexer to the inverter?

This is all I got. First the server CLI:
./tcp-multiplexer server -p modbus -v -t <IP_ADDRESS>:502 -l 65008
INFO[2024-05-30T14:10:00Z]/home/runner/work/tcp-multiplexer/tcp-multiplexer/pkg/multiplexer/multiplexer.go:90 github.com/ingmarstein/tcp-multiplexer/pkg/multiplexer.(*Multiplexer).Start() #1: <IP_ADDRESS>:56065 <-> <IP_ADDRESS>:65008
INFO[2024-05-30T14:10:00Z]/home/runner/work/tcp-multiplexer/tcp-multiplexer/pkg/multiplexer/multiplexer.go:185 github.com/ingmarstein/tcp-multiplexer/pkg/multiplexer.(*Multiplexer).targetConnLoop() Connected clients: 1
DEBU[2024-05-30T14:10:09Z]/home/runner/work/tcp-multiplexer/tcp-multiplexer/pkg/multiplexer/multiplexer.go:131 github.com/ingmarstein/tcp-multiplexer/pkg/multiplexer.(*Multiplexer).handleConnection() Message from client...
%s([]uint8) (len=12 cap=16) {
 00000000  00 01 00 00 00 06 01 03  90 8b 00 02              |............|
}
INFO[2024-05-30T14:10:09Z]/home/runner/work/tcp-multiplexer/tcp-multiplexer/pkg/multiplexer/multiplexer.go:163 github.com/ingmarstein/tcp-multiplexer/pkg/multiplexer.(*Multiplexer).createTargetConn() creating target connection
INFO[2024-05-30T14:10:09Z]/home/runner/work/tcp-multiplexer/tcp-multiplexer/pkg/multiplexer/multiplexer.go:172 github.com/ingmarstein/tcp-multiplexer/pkg/multiplexer.(*Multiplexer).createTargetConn() new target connection: <IP_ADDRESS>:34342 <-> <IP_ADDRESS>:502

<IP_ADDRESS> is the solar inverter, <IP_ADDRESS> is the Windows client, <IP_ADDRESS> the server running the tcp-mulitplexer.
Screenshot from the Windows Client:

At this point, tcp-multiplexer has successfully established a TCP connection to <IP_ADDRESS>:502, but then seems to be hanging either when writing the client request to the inverter or when reading the response. If you're running the latest version, you should be getting timeouts after 60 seconds.
Did you check network connectivity between <IP_ADDRESS> and <IP_ADDRESS>?
Can you provide the raw response corresponding to the 00 01 00 00 00 06 01 03  90 8c 00 02 request?

Did you get it to work eventually?

@rucksman if you'd like, you could give v1.0.7 with --delay 2 a try (see #10).

Thanks for working on this issue, but unfortunaly it did not help in my case. I used --delay 2s (it only worked with the "s", without there was an error).
Exact same parameters as in the opening post. I did let qModMaster do 20 packets with a scan rate of 10000ms, und there were only 2 successful packets out ouf these 20: 18:47:42:246 and 18:49:22:315
[TCP]>Tx > 18:47:02:182 - 00  01  00  00  00  06  01  03  75  76  00  02
Sys > 18:47:02:687 - Error : Timeout
[TCP]>Tx > 18:47:12:176 - 00  02  00  00  00  06  01  03  75  76  00  02
[TCP]>Rx > 18:47:12:176 - 00  01  00  00  00  07  01  03  04  01  AA  00  02
Sys > 18:47:12:679 - Error : Invalid data
[TCP]>Tx > 18:47:22:186 - 00  03  00  00  00  06  01  03  75  76  00  02
[TCP]>Rx > 18:47:22:186 - 00  02  00  00  00  07  01  03  04  01  AA  00  02
Sys > 18:47:22:695 - Error : Invalid data
[TCP]>Tx > 18:47:32:183 - 00  04  00  00  00  06  01  03  75  76  00  02
[TCP]>Rx > 18:47:32:183 - 00  03  00  00  00  07  01  03  04  01  AA  00  02
Sys > 18:47:32:694 - Error : Invalid data
[TCP]>Tx > 18:47:42:186 - 00  05  00  00  00  06  01  03  75  76  00  02
[TCP]>Rx > 18:47:42:246 - 00  05  00  00  00  07  01  03  04  01  AA  00  02
[TCP]>Tx > 18:47:52:185 - 00  06  00  00  00  06  01  03  75  76  00  02
Sys > 18:47:52:691 - Error : Timeout
[TCP]>Tx > 18:48:02:185 - 00  07  00  00  00  06  01  03  75  76  00  02
[TCP]>Rx > 18:48:02:185 - 00  06  00  00  00  07  01  03  04  01  AA  00  02
Sys > 18:48:02:690 - Error : Invalid data
[TCP]>Tx > 18:48:12:195 - 00  08  00  00  00  06  01  03  75  76  00  02
[TCP]>Rx > 18:48:12:195 - 00  07  00  00  00  07  01  03  04  01  AA  00  02
Sys > 18:48:12:700 - Error : Invalid data
[TCP]>Tx > 18:48:22:209 - 00  09  00  00  00  06  01  03  75  76  00  02
[TCP]>Rx > 18:48:22:209 - 00  08  00  00  00  07  01  03  04  01  AA  00  02
Sys > 18:48:22:718 - Error : Invalid data
[TCP]>Tx > 18:48:32:209 - 00  0A  00  00  00  06  01  03  75  76  00  02
[TCP]>Rx > 18:48:32:209 - 00  09  00  00  00  07  01  03  04  01  AA  00  02
Sys > 18:48:32:719 - Error : Invalid data
[TCP]>Tx > 18:48:42:229 - 00  0B  00  00  00  06  01  03  75  76  00  02
[TCP]>Rx > 18:48:42:229 - 00  0A  00  00  00  07  01  03  04  01  AA  00  02
Sys > 18:48:42:740 - Error : Invalid data
[TCP]>Tx > 18:48:52:227 - 00  0C  00  00  00  06  01  03  75  76  00  02
[TCP]>Rx > 18:48:52:227 - 00  0B  00  00  00  07  01  03  04  01  AA  00  02
Sys > 18:48:52:738 - Error : Invalid data
[TCP]>Tx > 18:49:02:238 - 00  0D  00  00  00  06  01  03  75  76  00  02
Sys > 18:49:02:738 - Error : Timeout
[TCP]>Tx > 18:49:12:232 - 00  0E  00  00  00  06  01  03  75  76  00  02
[TCP]>Rx > 18:49:12:232 - 00  0D  00  00  00  07  01  03  04  01  AA  00  02
Sys > 18:49:12:743 - Error : Invalid data
[TCP]>Tx > 18:49:22:235 - 00  0F  00  00  00  06  01  03  75  76  00  02
[TCP]>Rx > 18:49:22:315 - 00  0F  00  00  00  07  01  03  04  01  AA  00  02
[TCP]>Tx > 18:49:32:234 - 00  10  00  00  00  06  01  03  75  76  00  02
Sys > 18:49:32:741 - Error : Timeout
[TCP]>Tx > 18:49:42:237 - 00  11  00  00  00  06  01  03  75  76  00  02
[TCP]>Rx > 18:49:42:237 - 00  10  00  00  00  07  01  03  04  01  AA  00  02
Sys > 18:49:42:743 - Error : Invalid data
[TCP]>Tx > 18:49:52:230 - 00  12  00  00  00  06  01  03  75  76  00  02
Sys > 18:49:52:731 - Error : Timeout
[TCP]>Tx > 18:50:02:234 - 00  13  00  00  00  06  01  03  75  76  00  02
[TCP]>Rx > 18:50:02:234 - 00  12  00  00  00  07  01  03  04  01  AA  00  02
Sys > 18:50:02:744 - Error : Invalid data
[TCP]>Tx > 18:50:12:236 - 00  14  00  00  00  06  01  03  75  76  00  02
[TCP]>Rx > 18:50:12:236 - 00  13  00  00  00  07  01  03  04  01  AA  00  02
Sys > 18:50:12:743 - Error : Invalid data


:bug: fix nuclei import, #8920

See linked issue.

Could you review this @cneill, @Maffooch and @mtesauro ?


[fix] logging docu: splunk config and indentation of example code

The splunk configuration was wrong as splunkHec starts with lower s.
Also fields are hec_host and hec_port.
When contributing to docs, please don't update the content in the v2.x folder.
It's better to update the versioned docs, for example, the v2.5 or v2.6 docs.
This content in v2.x was separated into versioned documentation during the v2.5.8
release. The content relevant to Rancher versions before v2.5 went into the v2.0-v2.4
folder, while the content related to Rancher v2.5 went into the v2.5 folder.
We are trying to get the 2.x content to be removed from Google search results. The only
reason we haven't deleted it is because Google search results would lead to 404
errors if we deleted it.

The doc on the banzai side is autogenerated vi acode and looks like the mistake started from there.

Ahh ok so I close this PR and make changes there!?

Let's merge this PR and keep Rancher docs accurate.
Sure, you can submit a PR in logging operator upstream too.

Yeah I also fixed it upstream:

https://github.com/banzaicloud/logging-operator-docs/pull/80
https://github.com/banzaicloud/logging-operator/pull/805

Thanks @papanito
Was there any reason not to change splunkHec (starting with small "s" instead of caps) in the upstream?

Nope I guess I missed that. Will fix it...

@catherineluse anything missing?
Btw. I assume now that you have 2.6 doxu it should also go there?

@papanito Yes, if it's valid for Rancher 2.6 it should go in the 2.6 directory.

I will create a separate PR for 2.6.x but I guess would not hurt to also update 2.5.x docu ;-)

Merging and will use https://github.com/rancher/docs/issues/3520 for tracking of the 2.6 port

Thanks @btat


Minor modification to the AggregateGroupRenderer summary implementation

Complements datavisyn/tdp_core#378
Prerequisites:

[x] Branch is up-to-date with the branch to be merged with, i.e. develop
[x] Build is successful
[x] Code is cleaned up and formatted
[x] Tested with Firefox ESR, latest Firefox, latest Chrome, Edge 18

Summary
When collapsing/uncollapsing all groups in the AggregateGroupColumn we fire the event
ADataProvider.EVENT_GROUP_AGGREGATION_CHANGED and pass all groups to the callback.
In order to be able to track the aggregation state in tdp_core we need to know which groups were collapsed/expanded before the event was triggered.
With this PR instead of passing all groups to the event callback, we only pass the groups that have an opposite aggregation state to the one being currently triggered.

why not doing this filter check directly in the ADataProvider? This would also cover cases where the aggregateAll method is directly called

@sgratzl Good point! Could you please modify the implementation?


Build on Mac M1

I cannot manage to build crystalline master (ff6a712947a9f1aa1eed90478d5d23942585c4be) on arm64 for LLVM 15 using Homebrew and Crystal from asdf.
I tried the following:
shards build crystalline --release --no-debug --progress -Dpreview_mt

which returns an error;
Dependencies are satisfied
Building: crystalline
Error target crystalline failed to compile:
Undefined symbols for architecture arm64:
  "llvm::EnableABIBreakingChecks", referenced from:
      llvm::VerifyEnableABIBreakingChecks in llvm_ext.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Error: execution of command failed with exit status 1: cc "${@}" -o /Users/josua/p/crystalline/bin/crystalline  -rdynamic -L/Users/josua/.asdf/installs/crystal/1.8.1/embedded/lib -L/opt/homebrew/Cellar/libyaml/0.2.5/lib -lyaml /Users/josua/.asdf/installs/crystal/1.8.1/src/llvm/ext/llvm_ext.o<EMAIL_ADDRESS>--libs --system-libs --ldflags 2> /dev/null` -lstdc++ -lpcre2-8 -lgc -L/opt/homebrew/Cellar/libevent/2.1.12/lib -levent_pthreads -levent -L/opt/homebrew/Cellar/libevent/2.1.12/lib -levent -liconv

Hey @schmijos,
This seems unrelated to crystalline. The lvm_ext.o object file ships with the crystal install and for some reason it seems to be have been compiled for the x64 arch when installing from asdf.
I have no issues compiling with the latest crystal version installed with brew on my m2 pro macbook.
crystalline on  master is  v0.9.0 via 🔮 v1.8.2  
env LLVM_CONFIG=/opt/homebrew/opt/llvm@15/bin/llvm-config shards build crystalline --release --no-debug --progress -Dpreview_mt
Dependencies are satisfied
Building: crystalline

crystalline on  master is  v0.9.0 via 🔮 v1.8.2 took 3m51s  
arch
arm64

Thank you for the hint. I actually checked this already and thought that my file should be able to support both architectures. Is that assumption wrong?
➜  ~ file /Users/josua/.asdf/installs/crystal/1.8.1/src/llvm/ext/llvm_ext.o
/Users/josua/.asdf/installs/crystal/1.8.1/src/llvm/ext/llvm_ext.o: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit object x86_64] [arm64:Mach-O 64-bit object arm64]
/Users/josua/.asdf/installs/crystal/1.8.1/src/llvm/ext/llvm_ext.o (for architecture x86_64):	Mach-O 64-bit object x86_64
/Users/josua/.asdf/installs/crystal/1.8.1/src/llvm/ext/llvm_ext.o (for architecture arm64):	Mach-O 64-bit object arm64