invalid numeric argument '/Wno-cpp'

After I run setup.py I encounter this:
cl : Command line error D8021 : invalid numeric argument '/Wno-cpp'
error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\BIN\\x86_amd64\\cl.exe' failed with exit status 2
I have all C++  tools installed and have updated my pip and setuptools.
python 3.5.2
Anaconda 64 bit

See #9  . They will not provide windows support for some reason

anyone knows how to solve this problem?

After tons of digging I've found a way to make it work:
Steps

First go to cocoapi\PythonAPI\setup.py and change line 14 from:
extra_compile_args=['-Wno-cpp', '-Wno-unused-function', '-std=c99'],
to
extra_compile_args={'gcc': ['/Qstd=c99']},
as pointed out in this issue: https://github.com/CharlesShang/FastMaskRCNN/issues/173

And then try to run make from cocoapi\PythonAPI\pycocotools again.

If you get C1083: Cannot open include file: 'vcruntime.h': No such file or directory go to your C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build directory and run the following script from https://stackoverflow.com/questions/42757497/python-installation-compilation-errors
pushd "C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Auxiliary\Build\"
cmd /c "vcvars64.bat&set" |
foreach {
if ($_ -match "=") {
$v = $_.split("="); set-item -force -path "ENV:\$($v[0])"  -value "$($v[1])"
}
}
popd
Write-Host "`nVisual Studio 2017 Command Prompt variables set." -ForegroundColor Yellow

Then cd back to your cocoapi\PythonAPI\pycocotools and run make. It worked for me at this point :)

@TonyNgo1 THANK YOU! <

https://github.com/philferriere/cocoapi
cocoapi with windows support

@TonyNgo1
oops...
after step1,i get different error:
Traceback (most recent call last):   File "setup.py", line 23, in <module>     cythonize(ext_modules)   File "C:\Anaconda3\envs\caffe_env\lib\distutils\core.py", line 151, in setup     dist.run_commands()   File "C:\Anaconda3\envs\caffe_env\lib\distutils\dist.py", line 953, in run_commands     self.run_command(cmd)   File "C:\Anaconda3\envs\caffe_env\lib\distutils\dist.py", line 972, in run_command     cmd_obj.run()   File "C:\Anaconda3\envs\caffe_env\lib\distutils\command\build_ext.py", line 340, in run     self.build_extensions()   File "C:\Anaconda3\envs\caffe_env\lib\distutils\command\build_ext.py", line 449, in build_extensions     self.build_extension(ext)   File "C:\Anaconda3\envs\caffe_env\lib\distutils\command\build_ext.py", line 499, in build_extension     depends=ext.depends)   File "C:\Anaconda3\envs\caffe_env\lib\distutils\msvc9compiler.py", line 547, in compile     extra_postargs) TypeError: can only concatenate list (not "dict") to list make: *** [Makefile:3: all] Error 1

@LongruiDong Unfortunately that's the same thing I have and it works on my machine. I was also able to compile it by removing the line completely ie:
ext_modules = [
    Extension(
        'pycocotools._mask',
        sources=['../common/maskApi.c', 'pycocotools/_mask.pyx'],
        include_dirs = [np.get_include(), '../common'],
    )
]

So you could try that too. I assume the system determines how to compile if extra_compile_args is not set so you may get something different.

I made a repo to support To support Windows x64 build with Microsoft Visual C++ 9.0 standalone: Visual C++ Compiler for Python 2.7:
https://github.com/neoglez/cocoapi

After tons of digging I've found a way to make it work:
Steps

First go to cocoapi\PythonAPI\setup.py and change line 14 from:
extra_compile_args=['-Wno-cpp', '-Wno-unused-function', '-std=c99'],
to
extra_compile_args={'gcc': ['/Qstd=c99']},
as pointed out in this issue: CharlesShang/FastMaskRCNN#173
And then try to run make from cocoapi\PythonAPI\pycocotools again.
If you get C1083: Cannot open include file: 'vcruntime.h': No such file or directory go to your C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build directory and run the following script from https://stackoverflow.com/questions/42757497/python-installation-compilation-errorspushd "C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Auxiliary\Build\"
cmd /c "vcvars64.bat&set" |
foreach {
if ($_ -match "=") {
$v = $_.split("="); set-item -force -path "ENV:\$($v[0])"  -value "$($v[1])"
}
}
popd
Write-Host "`nVisual Studio 2017 Command Prompt variables set." -ForegroundColor Yellow

Then cd back to your cocoapi\PythonAPI\pycocotools and run make. It worked for me at this point :)

Sorry, I got an error like this:
c1 fatal error c1083 cannot open source file pycocotools /_ mask c ': no such file or directory
It's similar to yours, but I don't know how to solve it.

@TonyNgo1 Sorry, I got an error like this:
c1 fatal error c1083 cannot open source file pycocotools /_ mask c ': no such file or directory
It's similar to yours, but I don't know how to solve it.

pip install git+https://github.com/philferriere/cocoapi.git#subdirectory=PythonAPI

Try replacing extra_compile_args=['-Wno-cpp', '-Wno-unused-function', '-std=c99'] with extra_compile_args={'gcc': ['/Qstd=c99']} in coco/pycocotools/setup.py.
And then run python setup.py install again

After tons of digging I've found a way to make it work:
Steps

First go to cocoapi\PythonAPI\setup.py and change line 14 from:
extra_compile_args=['-Wno-cpp', '-Wno-unused-function', '-std=c99'],
to
extra_compile_args={'gcc': ['/Qstd=c99']},
as pointed out in this issue: CharlesShang/FastMaskRCNN#173

And then try to run make from cocoapi\PythonAPI\pycocotools again.

If you get C1083: Cannot open include file: 'vcruntime.h': No such file or directory go to your C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build directory and run the following script from https://stackoverflow.com/questions/42757497/python-installation-compilation-errors
pushd "C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Auxiliary\Build\"
cmd /c "vcvars64.bat&set" |
foreach {
if ($_ -match "=") {
$v = $_.split("="); set-item -force -path "ENV:\$($v[0])"  -value "$($v[1])"
}
}
popd
Write-Host "`nVisual Studio 2017 Command Prompt variables set." -ForegroundColor Yellow

Then cd back to your cocoapi\PythonAPI\pycocotools and run make. It worked for me at this point :)

It works man, thanks!

Hey guys! Here's how I fixed it-

First go to cocoapi\PythonAPI\setup.py and change line 14 from:
extra_compile_args=['-Wno-cpp', '-Wno-unused-function', '-std=c99'],
to
extra_compile_args={'gcc': ['/Qstd=c99']},

From terminal run - python setup.py install

Now from your root folder, try to install again.

Thanks to the above guys for help!

I am working in COLAB and when I start training this show-up, Please Help.
WARNING:tensorflow:From object_detection/model_main.py:109: The name tf.app.run is deprecated. Please use tf.compat.v1.app.run instead.
WARNING:tensorflow:From /gdrive/My Drive/object_detection/models/research/object_detection/utils/config_util.py:102: The name tf.gfile.GFile is deprecated. Please use tf.io.gfile.GFile instead.
W0404 19:26:53.064985<PHONE_NUMBER>51680 module_wrapper.py:139] From /gdrive/My Drive/object_detection/models/research/object_detection/utils/config_util.py:102: The name tf.gfile.GFile is deprecated. Please use tf.io.gfile.GFile instead.
Traceback (most recent call last):
File "object_detection/model_main.py", line 109, in
tf.app.run()
File "/tensorflow-1.15.2/python3.6/tensorflow_core/python/platform/app.py", line 40, in run
_run(main=main, argv=argv, flags_parser=_parse_flags_tolerate_undef)
File "/usr/local/lib/python3.6/dist-packages/absl/app.py", line 299, in run
_run_main(main, args)
File "/usr/local/lib/python3.6/dist-packages/absl/app.py", line 250, in _run_main
sys.exit(main(argv))
File "object_detection/model_main.py", line 71, in main
FLAGS.sample_1_of_n_eval_on_train_examples))
File "/gdrive/My Drive/object_detection/models/research/object_detection/model_lib.py", line 617, in create_estimator_and_inputs
pipeline_config_path, config_override=config_override)
File "/gdrive/My Drive/object_detection/models/research/object_detection/utils/config_util.py", line 104, in get_configs_from_pipeline_file
text_format.Merge(proto_str, pipeline_config)
File "/usr/local/lib/python3.6/dist-packages/google/protobuf/text_format.py", line 693, in Merge
allow_unknown_field=allow_unknown_field)
File "/usr/local/lib/python3.6/dist-packages/google/protobuf/text_format.py", line 760, in MergeLines
return parser.MergeLines(lines, message)
File "/usr/local/lib/python3.6/dist-packages/google/protobuf/text_format.py", line 785, in MergeLines
self._ParseOrMerge(lines, message)
File "/usr/local/lib/python3.6/dist-packages/google/protobuf/text_format.py", line 807, in _ParseOrMerge
self._MergeField(tokenizer, message)
File "/usr/local/lib/python3.6/dist-packages/google/protobuf/text_format.py", line 932, in _MergeField
merger(tokenizer, message, field)
File "/usr/local/lib/python3.6/dist-packages/google/protobuf/text_format.py", line 1006, in _MergeMessageField
self._MergeField(tokenizer, sub_message)
File "/usr/local/lib/python3.6/dist-packages/google/protobuf/text_format.py", line 875, in _MergeField
name = tokenizer.ConsumeIdentifierOrNumber()
File "/usr/local/lib/python3.6/dist-packages/google/protobuf/text_format.py", line 1343, in ConsumeIdentifierOrNumber
raise self.ParseError('Expected identifier or number, got %s.' % result)
google.protobuf.text_format.ParseError: 159:49 : '  fine_tune_checkpoint: "fine_tune_checkpoint: "/gdrive/My Drive/object_detection/models/research/pretrained_model/model.ckpt"': Expected identifier or number, got /.

Solved.
pip install git+https://github.com/philferriere/cocoapi.git#subdirectory=PythonAPI

Any chance original author can update for pycocotools 2.0.1?

Issue Resolved:
Open Anaconda-Prompt3:
Write: pip install pycocotools-windows
Python 3.7.6
Anaconda3 (64-bit)

None of them worked for me. After setting this:
set PATH=%PATH%;%SystemRoot%\system32;%SystemRoot%;%SystemRoot%\System32\Wbem;
in my conda environment, then I could install coco-api


Roll Flutter Engine from e612c3d75676 to a41c6ece2776 (1 revision)

https://github.com/flutter/engine/compare/e612c3d75676...a41c6ece2776
2022-11-28<EMAIL_ADDRESS>Ignore keydown event for tab during IME composition (flutter/engine#37753)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Support monpreds

When using propositions of the form monPred I PROP, starting the proof mode with iStartProof PROP (i.e. starting a proof with the underlying PROP as the type of propositions) names are not carried properly into the proofmode. The test in this MR probably shows the issue.
Intuitively the solution is to add an instance for MakeMonPredAt. But since named isn't sealed this doesn't work. Instead this MR adds a hint to the type class search that seems to work well 🙂

Thanks for reviewing and merging 😊

Yeah, thanks for contributing! I never would have figured out on my own that the library doesn't work with monPred but it definitely should.


Merge main into f/pf5-upgrade

Follow up to #2149

@jenny-s51 you failed TS, we should fix these before overriding the failure in the integration tests for the PF5 branch.
Error: src/pages/projects/components/SearchField.tsx(32,11): error TS2769: No overload matches this call.
  Overload 1 of 2, '(props: (SelectProps & OUIAProps) | Readonly<SelectProps & OUIAProps>): Select', gave the following error.
    Type '{ children: Element[]; toggleId: string; removeFindDomNode: true; isOpen: boolean; onToggle: () => void; selections: SearchType; onSelect: (e: MouseEvent<Element, MouseEvent> | ChangeEvent<...>, key: string | SelectOptionObject) => void; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Select> & Pick<Readonly<SelectProps & OUIAProps>, "onToggle"> & InexactPartial<...> & InexactPartial<...>'.
      Property 'removeFindDomNode' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Select> & Pick<Readonly<SelectProps & OUIAProps>, "onToggle"> & InexactPartial<...> & InexactPartial<...>'.
  Overload 2 of 2, '(props: SelectProps & OUIAProps, context: any): Select', gave the following error.
    Type '{ children: Element[]; toggleId: string; removeFindDomNode: true; isOpen: boolean; onToggle: () => void; selections: SearchType; onSelect: (e: MouseEvent<Element, MouseEvent> | ChangeEvent<...>, key: string | SelectOptionObject) => void; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Select> & Pick<Readonly<SelectProps & OUIAProps>, "onToggle"> & InexactPartial<...> & InexactPartial<...>'.
      Property 'removeFindDomNode' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Select> & Pick<Readonly<SelectProps & OUIAProps>, "onToggle"> & InexactPartial<...> & InexactPartial<...>'.
ERROR: "test:type-check" exited with 2.
ERROR: "test:frontend" exited with 1.
Error: Process completed with exit code 1.

Looks like DeployModelModelKServe is failing... probably with the latest changes merged to main. We will address this in the f/pf5-upgrade to main effort.
/override "Tests (18.x)"
/approve
/lgtm
Lets get this into the branch so we can wrap up PF5 upgrade.


How to set-cookie in edge function

https://github.com/supabase/functions-relay/blob/d6dba0efc708e495a5c2463e569c36415b676501/src/index.ts#L50
I don't know any other details about cookie implementation in edge system but it's seems all filtered from here, so how to set cookie in edge function?

This has been disabled for security reasons. Since functions across all our customers are under the same subdomain, allowing setting cookies between them could be dangerous. Our domains are under the public suffix list, but we wanted to err on the side of caution.
Can you send the cookie via a different header and having client side JS set the cookie instead?

Since functions across all our customers are under the same subdomain, allowing setting cookies between them could be dangerous

it make sense, I close this issue


Output for sub-commands should be formatted nicely

Right now, the built-in help looks very confusing, compared to the output from the Node.js-based Azure xPlat CLI

Cheers,
Trevor Sullivan
Microsoft MVP: Cloud & Data Center Management
https://trevorsullivan.net
https://twitter.com/pcgeek86

This is known issue. @johanste. i agree this is confusing by comparing with the node version, which outputs sub-commands. The error here is not suggestive for the next steps people should take.

same issue with #574, i am closing this one


fix: fix recent incompatibility when using reanimated

Often times this library is used next to reanimated.
In this case the worklets are transpiled by the reanimated babel plugin.
The reanimated babel plugin uses initData.sourceMap instead of RNWC current initData.__sourceMap.
This has gone unnoticed so far, cause we never checked for that property.
In this PR, which was recently merged

https://github.com/margelo/react-native-worklets-core/pull/188

a check was introduced, that checks if the provided function is a worklet:
https://github.com/margelo/react-native-worklets-core/blob/c495c52df85ec627c6c4d98aa785d20590322e80/src/hooks/useWorklet.ts#L6-L9
In this function we check for the __sourceMap identifier, which won't be present when we run with reanimated.
The solution to this seems to be to use the same identifier name as in reanimated.
Without this change we will see this error with a stack where everything is a valid worklet:

aking the liberty of asking, roughly when will this be updated Submitted？


feat: function key support

This update adds support for the function keys, such as F12. Thanks to @mrusme for the request.

Thank you Sir!


websocket: close 1006 again

connection to WhatsApp servers failed: websocket: close 1006 (abnormal closure): unexpected EOFkeepAlive failed: connection timed
go wac.keepAlive(20000, 90000) -> go wac.keepAlive(20000, 60000)
not work.

i have same issue after running up to 6 hours

Yes, it need to has a schedule job to check the connection  status.

Same Issue
error caught in handler: connection to WhatsApp servers failed: websocket: close 1006 (abnormal closure): unexpected EOF

me too

try to reconnect when error


Unexclude gc/metaspace/TestCapacityUntilGCWrapAround.java on JDK8

Failure of gc/metaspace/TestCapacityUntilGCWrapAround.java on windows x86 has been fixed by JDK-8226236 backport:
https://github.com/openjdk/jdk8u-dev/pull/192

Verify in https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/6542

@smlambert I think TARGET supposed to be hotspot_custom rather than jdk_custom

Yep thanks @zzambers, it was late and I was sleeping through the launch of these... relaunch here: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/6544

Note:
Was tested on win64 should have been win32. When testing other PR I have noticed that test is still failing on win32:
https://ci.adoptopenjdk.net/job/Grinder/6603/
When checked logs, current nightly build does not yet contain JDK-8226236:
SOURCE=".:git:444ca765c8cc+"
https://github.com/adoptium/jdk8u/tree/444ca765c8cc
Should get fixed in upcoming nightly build.


Hook up the assignment page to the proper endpoints.

All of the stand-in data from the prototype should come from backend endpoints.

I still need the scores and feedback endpoints but I'm waiting on the backend for those. Merged for now.


Latest Valheim Broke JudesEquipment

The following error occurs when attempting to load into a world with JudesEquipment enabled.
[Error  : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
(wrapper dynamic-method) FejdStartup.DMD<FejdStartup::OnWorldStart>(FejdStartup)
UnityEngine.Events.InvokableCall.Invoke () (at <80fe1a4e36fe44618284312cb721a597>:0)
UnityEngine.Events.UnityEvent.Invoke () (at <80fe1a4e36fe44618284312cb721a597>:0)
UnityEngine.UI.Button.Press () (at <e97aac8d17514bea83fadfd039e9187a>:0)
UnityEngine.UI.Button.OnPointerClick (UnityEngine.EventSystems.PointerEventData eventData) (at <e97aac8d17514bea83fadfd039e9187a>:0)
UnityEngine.EventSystems.ExecuteEvents.Execute (UnityEngine.EventSystems.IPointerClickHandler handler, UnityEngine.EventSystems.BaseEventData eventData) (at <e97aac8d17514bea83fadfd039e9187a>:0)
UnityEngine.EventSystems.ExecuteEvents.Execute[T] (UnityEngine.GameObject target, UnityEngine.EventSystems.BaseEventData eventData, UnityEngine.EventSystems.ExecuteEvents+EventFunction`1[T1] functor) (at <e97aac8d17514bea83fadfd039e9187a>:0)
UnityEngine.EventSystems.EventSystem:Update()

This only started with the latest Valheim patch.

should be fixed with latest release

Thank you kindly!


format the header of files

This PR sorts the ordering of headers, use correct "header" or <header>, and correct the definition of header.

Add hip/hip_runtime.h into hip/base/config.hip.hpp as its main include to ensure it is in front of hip/device_functions.h mentioned in #412
use IncludeBlocks: Regroup (need clang-format 6) to sort the header except the main include
add config (dev_tools/scripts/config) to set the rules how to find the corresponding main include
if there are something like comment of #if block before #include, the script will give alarm "sorting is maybe not correct"
Also alarm if there are multiple matches the main include.

Also mention this in #389 , but remove many if-else and unclear regex (which is almost handled by config)

6 parts for reviews

config/scripts review
core changes review
cuda changes review
hip changes review
include/ginkgo/core changes review
omp changes review
referece changes review

Also, the following is the alarm of script
(base) mike:ginkgo$ find core -type f -not -name "*.txt" -exec  dev_tools/scripts/format_header.sh {} \;
(base) mike:ginkgo$ find cuda -type f -not -name "*.txt" -exec  dev_tools/scripts/format_header.sh {} \;
(base) mike:ginkgo$ find hip -type f -not -name "*.txt" -exec  dev_tools/scripts/format_header.sh {} \;
(base) mike:ginkgo$ find include/ginkgo/core -type f -not -name "*.txt" -exec  dev_tools/scripts/format_header.sh {} \;
ALARM include/ginkgo/core/base/name_demangling.hpp may not be sorted correctly
(base) mike:ginkgo$ find omp -type f -not -name "*.txt" -exec  dev_tools/scripts/format_header.sh {} \;
(base) mike:ginkgo$ find reference -type f -not -name "*.txt" -exec  dev_tools/scripts/format_header.sh {} \;

In name_demangling.hpp, it contains #if block before other #include
However, if #if block is in the end, it will not give an alarm like reference/test/stop/combined.cpp and reference/test/stop/time.cpp

@upsj How do you think about combining prefix_sum.hip.hpp and prefix_sum.hip.cpp into prefix_sum_kernels.hip.cpp?

the interface is already defined in core/components/prefix_sum.hpp
It will be the same as the others like matrix and solver (with kernels suffix and the main header in core)

@upsj How do you think about combining prefix_sum.hip.hpp and prefix_sum.hip.cpp into prefix_sum_kernels.hip.cpp?
1. the interface is already defined in core/components/prefix_sum.hpp

2. It will be the same as the others like matrix and solver (with kernels suffix and the main header in core)

My answer to that would probably be "yes and/or unsure": At the moment, prefix_sum.hip.hpp only contains things that are used in prefix_sum.hip.cpp. For ParILUT however, I need a "wide" prefix sum kernel that is quite specific to the selection implementation and uses device functions I also put into prefix_sum.hip.hpp (or more specifically, prefix_sum.hpp.inc). So what do you think makes more sense:

Leave header and source separated, but rename the source to _kernels?
Combine header and source and later on also add the wide_prefix_sum to this file, even though it is only used by ParILUT?

It is updated.
add target format_header and format_header_all in CMake
format_header only process the changed files of branch
format_header process all code files.
They ignore build, examples, third_party, ginkgo.hpp
add // force-top: on and // force-top: off to keep some headers in the top (also before the main header).
I change the warning condition. If there are comments or #if block before codes, it gives warning.
The following is warning
Warning benchmark/utils/formats.hpp: sorting maybe is not correct
Warning core/base/extended_float.hpp: sorting maybe is not correct
Warning core/device_hooks/common_kernels.inc.cpp: sorting maybe is not correct
Warning include/ginkgo/core/base/abstract_factory.hpp: sorting maybe is not correct
Warning include/ginkgo/core/base/name_demangling.hpp: sorting maybe is not correct
Warning include/ginkgo/core/base/types.hpp: sorting maybe is not correct
Warning include/ginkgo/core/base/utils.hpp: sorting maybe is not correct
Warning reference/test/stop/combined.cpp: sorting maybe is not correct
Warning reference/test/stop/time.cpp: sorting maybe is not correct

Just a question, is this a blocking change ? I see that if GINKGO_DEVEL_TOOLS is on, then the format_header script is called. Currently, the user needs to call make  format_header_all to format the files. Do we want to do something similar as for make format ? Or is the way it is now, enough ?

@pratikvn No, it is not a blocking changes now.
Currently, I would prefer to leave it as an option.
we can try it for a while. If everything is expected, we can also add it like git-cmake-format.


chore: rename arguments to PiTensorProduct induction principles

This looks much nicer in the induction tactic than C1 and Cp, as
induction a using PiTensorProduct.induction_on with
| smul_tprod r a => sorry
| add x y hx hy => sorry

Thanks!
bors d+

bors merge


Undefined name: import shutil for line 60

Hey @cclauss - thanks for opening this PR! I believe we use shutil in that file to remove temporary directories that are created in the integration tests.
Can you tell me more about why you've submitted this PR?

That code currently throws a NameError because shutil is an undefined name in this context.  Since that code is wrapped in a bare exception the NameError is silently swallowed which makes this block of code is a no-op.

ha, yes! Very sorry - i thought you were removing this line, not adding it..... that should teach me to review PRs before I've finished my coffee 🤦♂
Sure, this LGTM, let's merge it :)


Dtc critical task work

Description
A collection of smaller critical and some non-critical tasking. Below is a list of the tasking addressed in this PR
Critical-3: The Camera step speed is currently set to 10hz, this should be set to a 20 hz.
Critical-12: Add RADAR sensor to robots
CompReq-4: The Windows Setup Bat file for CARLA should have a few things changed, like the UE build removed and the Content pull removed.
ToDo
Add the following tasks to this PR
Critical-6: The simulation isn't closing when the mission completes. Quit Game is getting used but it isn't fully closing the package.
CompReq-16: Add a maximum time for the simulation to execute and have it close when that time completes.
Verification
Run a mission and ensure the tasks above are working. Also, need to run setup script for windows and test if it is working still.
Dependencies
carla: https://github.com/DarpaTriageChallenge/carla/pull/6

Tasks completed:
Critical-3: The Camera step speed is currently set to 10hz, this should be set to a 20 hz.
Critical-12: Add RADAR sensor to robots
CompReq-4: The Windows Setup Bat file for CARLA should have a few things changed, like the UE build removed and the Content pull removed.
Todo:
Critical-6: The simulation isn't closing when the mission completes. Quit Game is getting used but it isn't fully closing the package.
CompReq-16: Add a maximum time for the simulation to execute and have it close when that time completes.


[iOS] Some weird animation happening on inputs and buttons when switching screens

Description
When switching between screens using simple unmount/mount logic like this:
      {activeTab === 1 && <TabOne />}
      {activeTab === 2 && <TabTwo />}

it seems like React Native is trying to "reuse" some inputs or components in some way.
Result: This causes strange animations or transitions between screens (and screen components like TextView or Button)
Steps to reproduce

Run the provided example code (Expo Snack)
Click between "TAB ONE" and "TAB TWO"

React Native Version
0.76.3
Affected Platforms
Runtime - iOS
Areas
Fabric - The New Renderer
Output of npx react-native info
I'm not entirely sure how to run this `npx react-native info ` on expo snack so I downloaded .zip from expo snack and run this command...

System:
  OS: macOS 15.1.1
  CPU: (12) arm64 Apple M4 Pro
  Memory: 131.67 MB / 24.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 20.16.0
    path: ~/.nvm/versions/node/v20.16.0/bin/node
  Yarn: Not Found
  npm:
    version: 10.8.1
    path: ~/.nvm/versions/node/v20.16.0/bin/npm
  Watchman:
    version: 2<IP_ADDRESS>
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.16.2
    path: /opt/homebrew/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 24.1
      - iOS 18.1
      - macOS 15.1
      - tvOS 18.1
      - visionOS 2.1
      - watchOS 11.1
  Android SDK: Not Found
IDEs:
  Android Studio: 2024.2 AI-242.23339.11.2421.12550806
  Xcode:
    version: 16.1/16B40
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.13
    path: /usr/bin/javac
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli":
    installed: 15.1.2
    wanted: latest
  react:
    installed: 18.3.1
    wanted: 18.3.1
  react-native:
    installed: 0.76.3
    wanted: 0.76.3
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

Stacktrace or Logs
No errors in the console

Reproducer
https://snack.expo.dev/@mbackonja/animation-issue
Screenshots and Videos
https://github.com/user-attachments/assets/195804c8-e187-4221-9df2-3ae8f9838e9e

This is probably due to view recycling. The system will try to recycle the text inputs instead of creating new ones.
Also, I can't reproduce it using the Snack and a real device.
As a test, can you try to assign different key to all the inputs?


Dev1

Clearly went nuts with Benchmarking various ways to do this.

Changes Unknown when pulling 00e3783a111396b2edaed94dbc599000c244023a on dev1 into ** on master**.

Changes Unknown when pulling 00e3783a111396b2edaed94dbc599000c244023a on dev1 into ** on master**.

Changes Unknown when pulling 00e3783a111396b2edaed94dbc599000c244023a on dev1 into ** on master**.


add documentation for new DCO requirements

What type of PR is this?

/kind documentation

What does this PR do / why we need it:
Now that DCO checks are enabled, this will add documentation about it as requested by Red Hat Legal team.
Which issue(s) this PR fixes:
https://issues.redhat.com/browse/GITOPS-2122

@reginapizza you enabled the DCO app for the entire redhat-developer org, but this is not necessary, as the DCO strategy we're following, as documented in this very PR, is implicit DCO, (CoreOS style).

By contributing to this project you agree to the Developer Certificate of
Origin (DCO)

Therefore it's no longer required to sign-off commits.
I will disable the DCO app

sorry about that Fred, I'll make sure it's only our repositories that have it enabled. Thank you!

@reginapizza no you don't need the DCO app anymore after this PR is merged, since you're making contributions implicitly according to this project's DCO

... unless other repos have not yet moved to implicit DCO, then yes they can still use the DCO app

@fbricon ah understood, thank you!

/lgtm
/approve

/test v4.9-e2e


Add monthly limit per member on virtual cards

This feature allows adding a monthlyLimitPerMember to a virtual card instead of defining only an amount.
Example:
Organization OpenCollective creates a virtual card with a monthlyLimitPerMember of U$ 50 and an expiryDate of 6 months from now. It's going to generate a Payment Method service opencollective and type virtualcard and initialBalance of U$ 300( monthlyLimitPerMember, U$ 50, times the months that the virtual card will be valid, in this case 6)
PS: If an amount AND a monthlyLimitPerMember are defined, the amount will be ignored and will be replaced by monthlyLimitPerMember with the field expiryDate(See example above).
fixes https://github.com/opencollective/opencollective/issues/1328

Coverage increased (+0.04%) to 70.986% when pulling 0d8ccb4f11415e429baa8ac9190b40084a9d3cdc on feat/1328-add-monthly-limit-virtual-cards into 32d323d273f65d72b04c7e1a5abe5ab236bbf7c9 on master.


Implement Async Azure Operators

Please look at docs to see if there are other operators we should make Async (Principle - Only create Async operators for the “sync-version” of operators that do some level of polling; take more than a few seconds to complete) for the Azure Provider.

ADLSListOperator
AzureDataLakeStorageDeleteOperator
AzureDataLakeStorageListOperator
AzureDataExplorerQueryOperator
AzureBatchOperator
AzureContainerInstancesOperator
AzureCosmosInsertDocumentOperator
WasbDeleteBlobOperator

Acceptance Criteria:

Unit Tests coverage in the PR (80% Code Coverage -- We will need to add CodeCov separately to measure code cov) with all of them passing
Example DAG using the async Operator that can be used to run Integration tests that are parametrized via Environment variables. Example - https://github.com/apache/airflow/blob/8a03a505e1df0f9de276038c5509135ac569a667/airflow/providers/google/cloud/example_dags/example_bigquery_to_gcs.py#L33-L35
Add proper docstrings for each of the methods and functions including Example DAG on how it should be used (populate
Exception Handling in case of errors
Improve the OSS Docs to make sure it covers the following:
Has an example DAG for the sync version
How to add a connection via Environment Variable & explain each of the fields. Example - https://airflow.apache.org/docs/apache-airflow-providers-postgres/stable/connections/postgres.html
How to use Guide for the Operator - example: https://airflow.apache.org/docs/apache-airflow-providers-postgres/stable/operators/postgres_operator_howto_guide.html

I have separated out the following operators from this issue:

https://github.com/astronomer/astronomer-providers/issues/186


Preprocessing crashes

My simple MPI hello world program with AllReduce works. But the following run doesn't work. Is it because MPI_THREAD_SERIALIZED?
$ mpirun -n 2 ./pagerank ../../inputs/soc-LiveJournal1.txt.bsnap 4847571 1
thread support level provided by MPI: MPI_THREAD_SERIALIZED
|V| = 4847571, |E| = 68475391
|V'_0| = 1261568 |E^dense_0| = 43518651
|V'_1| = 3586003 |E^dense_1| = 24956740
|V'_0_0| = 1261568 |E^dense_0_0| = 43518651
|V'_1_0| = 3586003 |E^dense_1_0| = 24956740
[yuxing-desk:01757] *** Process received signal ***
[yuxing-desk:01757] Signal: Segmentation fault (11)
[yuxing-desk:01757] Signal code: Address not mapped (1)
[yuxing-desk:01757] Failing at address: 0x14ec650
[yuxing-desk:01757] [ 0] /lib/x86_64-linux-gnu/libpthread.so.0(+0x11390)[0x7ff406b0d390]
[yuxing-desk:01757] [ 1] /usr/lib/openmpi/lib/openmpi/mca_pml_ob1.so(mca_pml_ob1_recv_request_progress_frag+0x59)[0x7ff3f98dbc19]
[yuxing-desk:01757] [ 2] /usr/lib/openmpi/lib/openmpi/mca_btl_vader.so(mca_btl_vader_poll_handle_frag+0x93)[0x7ff3fa344813]
[yuxing-desk:01757] [ 3] /usr/lib/openmpi/lib/openmpi/mca_btl_vader.so(+0x3abe)[0x7ff3fa344abe]
[yuxing-desk:01757] [ 4] /usr/lib/libopen-pal.so.13(opal_progress+0x4a)[0x7ff40602d1ea]
[yuxing-desk:01757] [ 5] /usr/lib/openmpi/lib/openmpi/mca_pml_ob1.so(mca_pml_ob1_send+0x4c5)[0x7ff3f98d5745]
[yuxing-desk:01757] [ 6] /usr/lib/libmpi.so.12(PMPI_Send+0x14b)[0x7ff40753ccdb]
[yuxing-desk:01757] [ 7] ./pagerank[0x4151dd]
[yuxing-desk:01757] [ 8] ./pagerank[0x409db3]
[yuxing-desk:01757] [ 9] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0)[0x7ff406752830]
[yuxing-desk:01757] [10] ./pagerank[0x409f79]
[yuxing-desk:01757] *** End of error message ***
--------------------------------------------------------------------------
mpirun noticed that process rank 1 with PID 1757 on node yuxing-desk exited on signal 11 (Segmentation fault).
--------------------------------------------------------------------------

Yes MPI_THREAD_MULTIPLE is required.


Eclipse Neon 1a showing errors for lombok annotation for version 1.16.12

Hi Team
I am currently using eclispe neon 1a build 4.6.1. I installed lobok.jar version 1.16.12 into my eclipse following the steps as mentioned in the link https://projectlombok.org/download.html. Also I added lombok jars version 1.16.12 as maven dependencies in my project. Now when I See my entity class annotations for @Data eclispe shows error. And when I try to correct it by suing eclipse ctrl-space intellisense it shows some error popup. (shared as screenshot). It takes very long for the auto-completion box to come up. Still it doesnot show lombok as a suggestion. However when I change my maven dependencies to version 1.16.10 the error vanishes. Please help in this regard.

I cannot reproduce your problem.
Eclipse IDE for Java Developers

Version: Neon.1a Release (4.6.1)
Build id: 20161007-1200

Closed due to no feedback from the reporter.


Refactor code in order to strip queryparams from path in pact output …

…and get them handled separately
Currently query params are treated as part of path in pact output. It makes difficult or impossible to use tools like @pactflow/swagger-mock-validator because path (with queryParams) are not found in openapi spec.
References

TODO

Submitter checklist

[ ] Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
[x] The PR request is well described and justified, including the body and the references
[x] The PR title represents the desired changelog entry
[x] The repository's code style is followed (see the contributing guide)
[x] Test coverage that demonstrates that the change works as expected
[ ] For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

Thanks!


Can we run flutter driver tests on BrowserStack or Saucelabs?

This seems to be a very old issue and was left untracked. But to answer the question, flutter driver doesn't explicitly run on BrowserStack or Saucelabs, as it requires some kind of instrumentation tests using native app.
Moreover, integration_test is now recommended way to write automated / integrations tests for flutter app which supports running them on Firebase Test Lab.
I am going ahead and closing this as stale issue.  For more reference on it, check this issue: https://github.com/flutter/flutter/issues/7087


Parallel Options: MaxDegreeOfParallelism?

Hello,
First thanks for that great library, it fits very well!
Do you think we can have in the future a way to control the max threads running concurrently?
I don't know if it should work, but I have tried using the attribute below and it didn't work for me:
[assembly: CollectionBehavior(MaxParallelThreads = n)]
Best,

I think you can use the configuration provided by xUnit. You can create a file named xunit.runner.json with the following content:
{
  "$schema": "https://xunit.net/schema/current/xunit.runner.schema.json",
  "maxParallelThreads": 10
}

Documentation: https://xunit.net/docs/configuration-files

Hello @meziantou , thanks for your quickly reply.
Unfortunately, I tried that too and it didn't work for me.
I was checking the documentation you sent me and I see that the "default behaviour" for the maxParallelThreads in version 2.4.3 (which I am currently using) would be to use the number of my logical processors, that currently are 16. But even that does not seem to be happening if you check the image below I can count at least more than 20 running together.

What is strange is that I have tried with your sample of unit tests and the json configuration file, in the same class, and with this sample it seems to work perfectly:
    [Theory]
    [InlineData(0), InlineData(1), InlineData(2)]
    public void Test3(int value) => Thread.Sleep(2000);

Maybe my tests are heavy and its taking time to update in the UI that they have finished besides limiting the threads.
But anyway it should be something specific here, we can close the issue in my perspective.


thinkpad/x1-extreme/gen3: add module

Description of changes
Add module for Lenovo Thinkpad X1 Extreme (Gen 3).
Gen 2 and Gen 4 were already there.
One thing that was new compared to either is a kernel parameter for the psmouse module which fixes clicking with the clickpad. The solution is described here: https://discourse.nixos.org/t/touchpad-click-not-working/12276
Things done

[X] Tested the changes in your own NixOS Configuration
[x] Tested the changes end-to-end by using your fork of nixos-hardware and
importing it via <nixos-hardware> or Flake input

Please also add this to the README and flake.nix

Done

@mergify queue


FunctionNode automatic fallback of array attributes in forward

In ChainerX FunctionNode fallback, type mismatch will happen if the function assigns an array as its attribute.
This PR implements automatic conversion of such attributes.

jenkins, test this please.

test_gaussian.py seems to be failing due to device mismatch. Could you fix it?

I assume PReLU and Gaussian are just two examples but that there are many other functions that can make use of this fix. I personally think it's worth considering a separate interface in the future for assigning/retrieving ndarrays inside FunctionNodes, rather than directly calling {set,get}attr.

Jenkins CI test (for commit d836bc8125f2d672e347aa2237a7c3b4cf99ccfa, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

I guess test failures should be fixed by #5777.

jenkins, test this please.

Jenkins CI test (for commit 1b5542c44da876c94fad172b8e6af0c6750c8148, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Could you check the ChainerX CI failures?

Rebased and fixed.

jenkins, test this please.

Jenkins CI test (for commit ba2686ce8c89bac3a9d8b3d7544ff843da74cc73, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Sorry just added a single last comment.

PTAL

jenkins, test this please.

Jenkins CI test (for commit 668b38b55e719b4450f4f862f1fa3c05be6c2d2b, target branch master) succeeded!

LGTM. The AppVeyor failure seems unrelated.


Suggestion: v-link change to link with optional bind- or := to use an expression

The majority use case for using v-link is with a literal, don't want to wrap all of their values in quotes
Also .="" literally looks like a typo

So with the latest discussion for the new binding syntax, we are moving away from un-prefixed custom attributes. The new literal syntax is v-link#="/a/b/c".


Improve doc of sum

This is PR for improving docs of functions/links. Related issue: #2182
Modified functions/links:

chainer/functions/math/sum.py

Could you review this? (In travis CI, it seems that one test not relavant to this PR is failing.)

jenkins, test this please

LGTM!
Thank you for your contribution!


[FLOC-4422] send and recieve diffs

Only send diffs of state and configuration to the nodes connected to the control node.
Note to the reviewer: Let me know if you see a good way to add a bit of additional test coverage. I might try to add a bit more myself, I'd like to test a bit more end-to-end.
Maybe I'll try using coverage to assist where I need to add tests...

Note to the reviewer: I will be adding tests that validate the error path in the agent as per coverage reports.

Tests added. Still not perfect test coverage, but when combined with the acceptance tests, probably sufficient coverage.

The jenkins test failure (above) seems to be significant and I was able to reproduce the error after 6 test runs:
PASSED (successes=1)
Test Pass 6
flocker.control.test.test_generations
  GenerationTrackerTests
    test_cache_runout ...                                                [FAIL]

===============================================================================
[FAIL]
Traceback (most recent call last):
Failure: testtools.testresult.real._StringException: Empty attachments:
  twisted-eliot-log
  twisted-log

Traceback (most recent call last):
  File "/home/richard/projects/HybridLogic/flocker/flocker/control/test/test_generations.py", line 85, in test_cache_runout
    Is(None)
  File "/home/richard/.virtualenvs/4422/lib/python2.7/site-packages/testtools/testcase.py", line 498, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: is not:
reference = None
actual    = Diff(changes=ObjectPVector([_Set(path=ObjectPVector(['nodes', UUID('a245b12c-12d1-6b35-a89e-785a0553ba63'), 'applications', u'd7c44aa0-9727-253c-5a46-841e399d9188']), value=Application(memory_limit=None, name=u'd7c44aa0-9727-253c-5a46-841e399d9188', links=LinkPSet([]), environment=pmap({}), command_line=None, image=DockerImage(tag=u'528eccf0-6257-4a93-3013-8d4a93d1cab2', repository=u'cea96d5e-d686-468e-9e12-92384d78c1a8'), restart_policy=RestartNever(), volume=None, running=True, ports=PortPSet([Port(internal_port=8005, external_port=8006), Port(internal_port=8000, external_port=8001), Port(internal_port=8002, external_port=8003), Port(internal_port=8003, external_port=8004), Port(internal_port=8006, external_port=8007), Port(internal_port=8004, external_port=8005), Port(internal_port=8001, external_port=8002), Port(internal_port=8007, external_port=8008)]), cpu_shares=None)), _Remove(item=u'eae3eeed-2e4f-1ddd-3d18-44e448030c69', path=ObjectPVector(['nodes', UUID('a245b12c-12d1-6b35-a89e-785a0553ba63'), 'applications'])), _Remove(item=u'd7c44aa0-9727-253c-5a46-841e399d9188', path=ObjectPVector(['nodes', UUID('a245b12c-12d1-6b35-a89e-785a0553ba63'), 'applications'])), _Set(path=ObjectPVector(['nodes', UUID('a245b12c-12d1-6b35-a89e-785a0553ba63'), 'applications', u'da29ed7d-a610-e28a-cb9d-25266c2c26eb']), value=Application(memory_limit=None, name=u'da29ed7d-a610-e28a-cb9d-25266c2c26eb', links=LinkPSet([]), environment=pmap({}), command_line=None, image=DockerImage(tag=u'8b982b4a-acfa-bd83-bedf-d1164866e638', repository=u'f3259b29-8450-f8fa-fc73-6269da8827ce'), restart_policy=RestartNever(), volume=None, running=True, ports=PortPSet([Port(internal_port=8003, external_port=8004), Port(internal_port=8002, external_port=8003), Port(internal_port=8001, external_port=8002), Port(internal_port=8000, external_port=8001)]), cpu_shares=None)), _Set(path=ObjectPVector(['nodes', UUID('a245b12c-12d1-6b35-a89e-785a0553ba63'), 'applications', u'57b1e1dd-7880-3976-f2c3-98a06fb49518']), value=Application(memory_limit=None, name=u'57b1e1dd-7880-3976-f2c3-98a06fb49518', links=LinkPSet([]), environment=pmap({}), command_line=None, image=DockerImage(tag=u'8e09b7e9-27d7-ea78-bc05-ad8aba633ba5', repository=u'edcef5a2-3916-9016-d9e6-1937b9b11a84'), restart_policy=RestartNever(), volume=None, running=True, ports=PortPSet([Port(internal_port=8002, external_port=8003), Port(internal_port=8001, external_port=8002), Port(internal_port=8000, external_port=8001)]), cpu_shares=None))]))

flocker.control.test.test_generations.GenerationTrackerTests.test_cache_runout
-------------------------------------------------------------------------------
Ran 1 tests in 0.021s

FAILED (failures=1)

Thanks @sarum90
This all looks good to me.
The test failure seems to be caused by related_deployments_strategy sometimes returning duplicate deployments. I'll fix that.
And a few typos which I'll fix before merging.


missing mail_from option

Would you accept a PR about this?

Absolutely would 💖
You might need to update the .travis.yml for the build to go though. this one should be more up todate.


[$500] Room - No Join button in thread header for thread with no reply

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR https://github.com/Expensify/App/pull/33791
Action Performed:

Go to workspace chat
Send a message
Right click on the message > Unsubscribe from thread
Right click on the message > Reply in thread

Expected Result:
There is a Join button on the right of the header
Actual Result:
There is no Join button on the header
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/e707276d-a2da-4881-bc44-a296e2912467
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e0087435438fe2da
Upwork Job ID:<PHONE_NUMBER>612663296
Last Price Increase: 2024-01-05

Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
When showing the "Join" button, we check the thread to be not empty:
https://github.com/Expensify/App/blob/fb0b1d1c27a3341d49dabdb4cd7975cc4f5c8873/src/pages/home/HeaderView.js#L156-L158
What changes do you think we should make in order to solve the problem?
Remove the !isEmptyChat check:
const canJoinOrLeave = isChatThread || isUserCreatedPolicyRoom || canLeaveRoom;

What alternative solutions did you explore? (Optional)

@srikarparsi could you please share why you decided to hide the "Join" button on the empty threads here?

Proposal
Please re-state the problem that we are trying to solve in this issue.
Room - No Join button in thread header for thread with no reply
What is the root cause of that problem?
The !isEmptyChat condition in this line
What changes do you think we should make in order to solve the problem?
We can delete the check !isEmptyChat but  to avoid from any regress I suggest to leave the !isEmptyChat and  change  like below
isChatThread || ( !isChatThread && !isEmptyChat) || isUserCreatedPolicyRoom || canLeaveRoom;
What alternative solutions did you explore? (Optional)
N/A

Proposal
Please re-state the problem that we are trying to solve in this issue.
Room - No Join button in thread header for thread with no reply
What is the root cause of that problem?
When we reply in the same thread and we are unsubscribed we do not take into consideration if the parent's response is empty to show the join button.
What changes do you think we should make in order to solve the problem?
We should take into consideration if the parent message is empty or not to show the join button:
const isParentEmpty = !props.parentReport.lastMessageText && !props.report.lastMessageTranslationKey;
.
.
.
 const canJoinOrLeave = (isChatThread && (!isEmptyChat || !isParentEmpty)) || isUserCreatedPolicyRoom || canLeaveRoom;

Result:
https://github.com/Expensify/App/assets/5216036/16a0418d-0a63-4803-acec-231444af4476

Does Join button need to have Subscribe to thread functionality?

.

@srikarparsi could you please share why you decided to hide the "Join" button on the empty threads here?

I believe it was because of the words "join" and "leave" since joining and leaving a nonexistent thread didn't make much sense at the time. Subscribe and unsubscribing made more sense in that context. But I believe we're changing the language across the menus to be "join" and "leave." So it would make sense to be able to "join" a nonexistent thread.

So it would make sense to be able to "join" a nonexistent thread now.

Cool, thank you for an expanded explanation 👍

Proposal
Please re-state the problem that we are trying to solve in this issue.
From workspace chat, after sending the message if the chat message is unsubscribed the join button is not displayed in top corner.
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
Two issues preventing the join button from getting displayed.
First issue,
The canJoinorLeave const is checking for whether the chat is empty !isEmptyChat. The !isEmptyChat check needs to be removed.
const canJoinOrLeave = isChatThread || isUserCreatedPolicyRoom || canLeaveRoom;
https://github.com/Expensify/App/blob/fb0b1d1c27a3341d49dabdb4cd7975cc4f5c8873/src/pages/home/HeaderView.js#L156
Second issue,
When the chat message is subscribed the props.report.notificationPreference is set to CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS, the below only allows joining room for when the props.report.notificationPreference is set to CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN
https://github.com/Expensify/App/blob/fb0b1d1c27a3341d49dabdb4cd7975cc4f5c8873/src/pages/home/HeaderView.js#L157
When the user first types the message in workspace chat and if the thread is subscribed, and the user replies the thread the report notificationPreference is initially set to hidden but after the report is loaded because the thread was subscribed the props.report.notificationPreference is set to CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS. Which cause the join button to be displayed momentarily and then because the thread was subscribed, the join button is hidden. In order to get reliable data need to add check for !props.report.isOptimisticReport
const canJoin = canJoinOrLeave && !isWhisperAction && !props.report.isOptimisticReport && props.report.notificationPreference === CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN;
What alternative solutions did you explore? (Optional)

Proposal
Updated proposal https://github.com/Expensify/App/issues/34054#issuecomment-1879125994 to cover the optimistic button flickering.
@srikarparsi was there any specific reason to create the thread with notification: hidden, considering the API response replaces it with Always right after?

In the ContextMenuActions.js, when subscribeToThread or unsubscribeFromThread, if isActionCreator is false, childReportNotificationPreference is set to "CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN" as opposed to what @paultsimura was hoping for "CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS"
https://github.com/Expensify/App/blob/596e56bd7cf3273ae79ad1e8737395dfa36914b1/src/pages/home/report/ContextMenu/ContextMenuActions.js#L175
The childReportNotificationPreference is set to ALWAYS when the comment is created by workspace admin or when isActionCreator is true, but when isActionCreator is false or when other members are invited to the workspace to chat, childReportNotificationPreference is set to HIDDEN. I was not reliably able to get the join button to show during testing.
@Ollyws The more reliable approach would be to check the flag props.report.isOptimisticReport and then get the value of props.report.notificationPreference after the report is loaded as opposed to relying on hardcoded constant. Definitely more than one reason as to why not to rely on hardcoded constants that might change.

In the ContextMenuActions.js, when subscribeToThread or unsubscribeFromThread, if isActionCreator is false, childReportNotificationPreference is set to "CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN" as opposed to what @paultsimura was hoping for "CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS"
App/src/pages/home/report/ContextMenu/ContextMenuActions.js
Line 175 in 596e56b
childReportNotificationPreference = isActionCreator ? CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS : CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN;
The childReportNotificationPreference is set to ALWAYS when the comment is created by workspace admin or when isActionCreator is true, but when isActionCreator is false or when other members are invited to the workspace to chat, childReportNotificationPreference is set to HIDDEN. I was not reliably able to get the join button to show during testing.
@Ollyws The more reliable approach would be to check the flag props.report.isOptimisticReport and then get the value of props.report.notificationPreference after the report is loaded as opposed to relying on hardcoded constant. Definitely more than one reason as to why not to rely on hardcoded constants that might change.

@Ollyws Proposal is ready for review.

Hey @Ollyws, can you please take a look at these proposals whenever you get a chance? This proposal looks mostly good to me since it uses the same logic as the context menu actions.
I'm not sure if we need to check for other cases for when the notification preference is set to always, such as when the workspace admin comments as brought up here, because then the thread will no longer have no replies right?
If the proposal looks good and there are only a few minor changes, I think we should be able to get this done by Wednesday or Thursday?

@Ollyws The hardcoded approach has only handled one report for buildOptimisticChatReport. The notification preference conditions needs to be handled for buildOptimisticIOUReport, buildOptimisticExpenseReport and buildTransactionThread. The hardcoded approach would require further testing for the following reports and if left untested would possibly lead to regressions later on.
buildOptimisticIOUReport
https://github.com/Expensify/App/blob/596e56bd7cf3273ae79ad1e8737395dfa36914b1/src/libs/ReportUtils.ts#L2570
buildOptimisticExpenseReport
https://github.com/Expensify/App/blob/596e56bd7cf3273ae79ad1e8737395dfa36914b1/src/libs/ReportUtils.ts#L2570
buildTransactionThread
https://github.com/Expensify/App/blob/596e56bd7cf3273ae79ad1e8737395dfa36914b1/src/libs/ReportUtils.ts#L3341
The default values have been set to Hidden and probably have valid reasons to be set to hidden. The default values of notification preference passed when building reports do not matter and should not need to be changed.
I suggest not to make any changes to the default value of notification preference when building the report and that this is making the issue overly complicated.

Thanks. The PR is ready for review: https://github.com/Expensify/App/pull/34376

@paultsimura - you're all paid - @Ollyws , I'll release payment once the BZ checklist is complete!

Awesome, thanks @Ollyws! I need you to accept the offer though before I pay
https://www.upwork.com/nx/wm/offer/28093246


Asynchronous branch

Are you planning to create an async branch with aiohttp or httpx?

Well, the module is based on bs4 which is currently only sync. There are other scrappers like souppy which can imitate async behaviour but they might not be that useful.


Cannot read properties of null

I was very excited to discover your plugin, it plays into what I was hoping to do in my journals soon.  I gave it a quick try but I'm getting an error.
I have the plugin configured:

I have a note in "_Resources/Ingredients" called "Progresso Creamy Roasted Chicken and Wild Rice.md" that has properties with values as you've described:

In a journal, I have the following to designate eating 524 grams (1 can) of this soup:
```foodiary
Progresso Creamy Roasted Chicken and Wild Rice 524
```

The result that is displayed is:

Am I doing something wrong?

Hello! I've just tried to reproduce the problem but got no success. Can you have a look at the demo repo below I just made?
https://github.com/vkostyanetsky/ObsidianFoodiary/tree/main/sampleNullBug
It shows no error so far, but I probably miss some details.

Welp, forget what I said above, seems like I've just reproduced this one. On my way to fix :)

Fixed. Can you please upgrade the plugin to 1.2.2 and tell me if is fine now?

Thanks for getting back to me. No luck.  I now get "Failed to render a food diary:  type of "calories" property in "Zucchini.md" is not number.  Zucchini.md is the last ingredient file in that folder, and it doesn't have any values in the properties yet (I'm working on getting those all populated.  Seems it didn't find a match for the soup file that was there?  Not sure why else it would look at the zucchini file.  If I move the soup ingredient file to a different folder where all the ingredients do have the values populated (I'm working on a script to get a pile of USDA ingredient based files), I get the same "Failed to render a food diary: Cannot read properties of undefined (reading 'forEach')" error as before the update.  Note that I did update the properties to type 'number' (as you can see from the clip above they were 'Text' before) but the change hasn't made a difference.

I now get "Failed to render a food diary: type of "calories" property in "Zucchini.md" is not number. Zucchini.md is the last ingredient file in that folder, and it doesn't have any values in the properties yet (I'm working on getting those all populated.

I've just changed the behavior: if a product property doesn't contain a number, it means that the property value is 0. In addition, it sends a message to Obsidian console. It should handle the issue, I guess.
In addition, I slightly changed the line that causes forEach issue (should patch the seconds issue you mentioned).
Upgrade to 1.2.3 and tell me how it feel, please.

There is examples in demo vault on which I tested the patches above:

A product file with no properties filled  (Zucchini.md)
A product file with empty aliases property

In case if error still persists, tell me if files in your vault differs from those.

Working!  I updated the plugin and it's working in my vault now. It nicely gives a big red error when it can't find a product. When it finds all of them it puts them in a table and shows the totals, as it should. Nice work!  Beware, I have a lot of ideas on where this could go, and I'm working on a 'food database' that will make a nice companion for the plugin...

Sounds great! Let me know if you need something.


[nrfconnect] Enabled factory data protection against writing in internal memory

Problem
Factory data flash partition should be protected from write by firmware and OTA DFU.
This partition can be replaced only via a programmer.
Change overview
Added Fprotect hardware flash protection driver to protect factory data partition against write.
Testing
Tested on nRF52DK

Fast tracking platform updates


add pymol scripts to repo

Description
It would be nice to at least somewhat automate the process of generating nice docking visuals from our results. Hopefully wee can write everything in a way that would make it potentially reusable between different sub-projects.
TODO

[x] decide what we want to be able to visualize
[x] decide if it's worth making progress on this or if we should wait to be able to upload this to Fragalysis instead

What our resulting scripts should have

[x] common viewing angle for active site

did a good rough draft of this in #83


Reports are not being generated

This code never writes reports with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>gulp.task('spec', ['lint'], function(callback) {
  gulp.src(lib)
    .pipe(istanbul({
      includeUntested: true
    }))
    .pipe(istanbul.hookRequire())
    .on('finish', function() {
      gulp.src(test)
        .pipe(mocha({
          reporter: process.env.TRAVIS ? 'spec' : 'nyan'
        }))
        .pipe(istanbul.writeReports({
          reporters: ['text', 'text-summary']
        }))
        .on('end', function() {
          var errOrNull = null;
          var coverage = istanbul.summarizeCoverage();
          var incomplete = Object.keys(coverage).filter(function(key) {
            return coverage[key].pct !== 100;
          });
          if (incomplete.length > 0) {
            errOrNull = new Error(
              'Incomplete coverage for ' + incomplete.join(', '));
          }
          callback(errOrNull);
        });
    });
});

Same issue here; except, I'm using the isparta instrumenter like so:
		.pipe(istanbul({
			instrumenter: isparta.Instrumenter,
			includeUntested: true,
			babel: { stage: 0 }
		}))

@jedmao Is your code published somewhere? This snippet doesn't really help.

Also, are you sure Mocha specs are passing and not throwing?
Here's an example gulpfile I know is working https://github.com/yeoman/generator/blob/master/gulpfile.js

Thanks @SBoudrias. I'll use that code as a reference and try to publish something tonight that you can look at in its entirety, if it's still not working.
Also, yes, my Mocha tests are all passing.

To be clear, I have no issues with gulp-istanbul on my other projects. It was only when I tried to start using Babel and the isparta instrumenter that this happened.

For node-asana we discovered that a test was failing, causing the reports to never be created. Once we fixed that, everything starts to work again.

Same issue for me. Here is my setup
/*
 * Instrument files using istanbul and isparta
 */
gulp.task('coverage:instrument', function() {
  return gulp.src(SRC_FILES)
    .pipe(istanbul({
      instrumenter: isparta.Instrumenter, // Use the isparta instrumenter (code coverage for ES6)
      // Istanbul configuration (see https://github.com/SBoudrias/gulp-istanbul#istanbulopt)
      includeUntested: true
    }))
    .pipe(istanbul.hookRequire()); // Force `require` to return covered files
});

/*
 * Write coverage reports after test success
 */
gulp.task('coverage:report', function(done) {
  return gulp.src(SRC_FILES, {read: false})
    .pipe(istanbul.writeReports({
      // Istanbul configuration (see https://github.com/SBoudrias/gulp-istanbul#istanbulwritereportsopt)
      dir: './quality/coverageUI',
      reporters: ['html'],
      reportOpts: { dir: './quality/coverageUI' },
      coverageVariable: 'someVariable'
    }));
});

/**
 * Run unit tests
 */
gulp.task('test', function() {
  global.__app = __dirname + '/app/';
  return gulp.src(TEST_FILES, {read: false})
    .pipe(mocha({
      require: ["./testingUI/jsdomSetup"] // Prepare environement for React/JSX testing
    }));
});

/**
 * Run unit tests with code coverage
 */
gulp.task('test:coverage', function(done) {
  runSequence('coverage:instrument', 'test', 'coverage:report', done);
});
```

Disregard the above comment, the coverage variables were different

Haven't heard anything new about this for a while. I'll assume user errors given most people seems to be able to use gulp-istanbul without issues.


Vue DevTools keep showing me it's version 1.0.26

I'm using vue with Laravel 5.3, and here is my packages file :

After install using Yarn or NPM, the DevTools keep showing my that I'm using version 1.0.26:

Please open issue at the vue-devtools repo instead. Also try console.log(Vue.version) in your code to ensure you are indeed using the right version.


Travis script req'd?

Right now, http://activity-list-editor.openactive.io/en/openactive_concepts.jsonld needs to be copied to
https://www.openactive.io/activity-list/activity-list.jsonld. A Travis script in https://github.com/openactive/activity-list seems like an obvious solution.
But is this the best architecture?

Implemented as described and as a daily cron job.


tensorflow/tensorflow:2.1.1-gpu has python3 instead of python2

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):  N/A
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
TensorFlow installed from (source or binary): N/A
TensorFlow version (use command below): v2.1.0-33-g3ffdb91 2.1.1
Python version: See details
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version: N/A
GPU model and memory: N/A

Describe the current behavior
Docker image tensorflow/tensorflow:2.1.1-gpu contains python3.6.9
Describe the expected behavior
Docker image tensorflow/tensorflow:2.1.1-gpu contains python2.7.17 as is expected for docker images <= 2.1 https://hub.docker.com/r/tensorflow/tensorflow/
Standalone code to reproduce the issue
$docker run tensorflow/tensorflow:2.1.1-gpu python --version
Python 3.6.9
Other info / logs Include any logs or source code that would be helpful to
Note:  tensorflow/tensorflow:2.1.0-gpu contains python2
$docker run tensorflow/tensorflow:2.1.0-gpu python --version
Python 2.7.17

This is working as intended

Versioned images <= 1.15.0 (1.x) and <= 2.1.0 (2.x) have Python 3 (3.5 for Ubuntu 16-based images; 3.6 for Ubuntu 18-based images) in images tagged "-py3" and Python 2.7 in images without "py" in the tag. All newer images are Python 3 only. Tags containing -py3 are deprecated.

Version 2.1.1 is not smaller than 2.1.0.
Any patch release after January 2020 will be only Python3, regardless if the original final release included python 2 support.


[feature request] Implement Windows .bat Launcher for Devika

Feature Description
I am suggesting the creation of a Windows batch file (.bat) launcher to facilitate an easier start-up process for Devika on Windows operating systems. This launcher would enable users to start Devika with just a double click, bypassing the need for command-line interactions or manual configuration.
Rationale
Many users and contributors of Devika may be operating on Windows. Providing a .bat launcher could significantly simplify the initial setup and daily usage for this large user base. This addition aims to lower the technical barrier to entry, making Devika more accessible to a broader range of users and developers, especially those less familiar with command-line operations.
Proposed Solution
The proposed solution involves developing a .bat file that automates the setup and launch process for Devika on Windows systems. This script should handle tasks like setting up the correct environment variables, activating any necessary virtual environments, and launching the Devika software. The objective is to streamline the user's start-up process to a single action.
Additional Context
Improving user experience by simplifying the start-up process can lead to increased adoption and a more vibrant community around Devika. A .bat launcher is a standard practice in many open-source projects targeting Windows users, contributing significantly to user retention and satisfaction.
I hope this feature will be considered for future updates, and I am open to contributing to its implementation or testing.
Thank you for considering this request.

There cannot be a simple BAT installation for Windows users because BUN (JS front end) is not compatible with Windows. Devika can only currently be run on Linux, Mac and WSL (Windows Subsystem for Linux).
I suppose it's possible that you could switch out the front end with something like Node, but that would take some effort.

if you tested and it work perfectly and you may create a PR for this.

currently, there is no plan for this so closing it.


Allow playbooks to run against CentOS stream 9

Feature Request or Enhancement
The playbook explicitly prevents runs against CentOS Stream 9, however, it does work.
Summary of Request
Remove constraint on CentOS Stream 9
Describe alternatives you've considered
Suggested Code
Adding a CentOS.yaml var file, with the corresponding data, and removing the check that purposely excludes CentOS Stream 9, allows the playbook to harden the machine, and gets pretty good results with the default settings.
'The post remediation results are: Count: 613, Failed: 47, Duration: 30.235s.'

diff --git a/tasks/main.yml b/tasks/main.yml
index 2bb0f3f..2be091c 100644
--- a/tasks/main.yml
+++ b/tasks/main.yml
@@ -3,7 +3,7 @@

 - name: Check OS version and family
   ansible.builtin.assert:
-      that: (ansible_distribution != 'CentOS' and ansible_os_family == 'RedHat' or ansible_os_family == "Rocky") and ansible_distributi
on_major_version is version_compare('9', '==')
+      that: (ansible_os_family == 'RedHat' or ansible_os_family == "Rocky") and ansible_distribution_major_version is version_compare('9', '==')
       fail_msg: "This role can only be run against Supported OSs. {{ ansible_distribution }} {{ ansible_distribution_major_version }} is not supported."
       success_msg: "This role is running against a supported OS {{ ansible_distribution }} {{ ansible_distribution_major_version }}"
   when:
diff --git a/tasks/section_1/cis_1.2.x.yml b/tasks/section_1/cis_1.2.x.yml
index 2501732..ec62357 100644
--- a/tasks/section_1/cis_1.2.x.yml
+++ b/tasks/section_1/cis_1.2.x.yml
@@ -25,7 +25,8 @@
       - rhel9cis_rule_1_2_1
       - ansible_distribution == "RedHat" or
         ansible_distribution == "Rocky" or
-        ansible_distribution == "AlmaLinux"
+        ansible_distribution == "AlmaLinux" or
+        ansible_distribution == "CentOS"
   tags:
       - level1-server
       - level1-workstation

And then,
$ cat vars/CentOS.yml

os_gpg_key_pubkey_name: centos-gpg-keys
os_gpg_key_pubkey_content<EMAIL_ADDRESS>9.0"

The ansible facts for CentOS Stream 9 looks like this:
"ansible_distribution": "CentOS",
"ansible_distribution_major_version": "9",
"ansible_distribution_release": "Stream",
"ansible_distribution_version": "9",
"ansible_os_family": "RedHat"

Is there any reason to prevent the run on CentOS Stream 9? I understand that Lockdown company may want to limit what they want to officially support, but as an Open Source project it appears rather an artificial constraint.

hi @carofe82
Thank you for raising this issue and the recent PR. It is from feedback that we can improve this content.
We have looked at supporting stream on others OSs, we have found that stream is slightly more bleeding edge and may contain different packages and configuration options to the more mainline versions. Meaning in some cases we would end up managing specific setting in some cases that may only work with CentOS stream.
If a client was to request this we would probably add it as they do purchase the privilege in some cases.
If we were to allow Centos to be run and incorporate the settings you have suggested we would be expected (despite stating otherwise) to provide updates for the issues that may arise purely for the one OS.
I will raise this discussion and see the general consensus from the rest of the team.
We will get back to you as soon as we have discussed this.
Once again many thanks for raising this.
uk-bolly

Thank you @uk-bolly  for looking into this.

hi @carlosrodfern
This should now work and is currently in the devel branch, I have added the centos key you have provided and although added CentOS remains unsupported for those reasons above.
You can turn off the OS check by changing the variable
os_check: false

This will skip the OS check but should still incorporate the CentOS variables you have provided.
Thank you again for taking the time to raise.
uk-bolly

@uk-bolly , I just finished testing it. It works well, as expected. Thank you!

@uk-bolly , the Readme.md has a typo, though. It says check_os but it is os_check.

This issue is solved. Closing.


write metadata artist to ? maybe encoding error

Describe the bug
command
./ffmpeg -i 002.mp3 -c copy -metadata:s:a title="暧昧" -metadata:s:a album="菲主打" -metadata artist="王菲" tmp-3.mp3

this command works well with ffmpeg binary from ffmpeg.org, but get result like this with ffmpeg.wasm
  Metadata:
    title           : 暧昧
    album           : 菲主打
    artist          : ??

any mp3 file can reproduce

only artist not work

https://en.wikipedia.org/wiki/ID3#ID3v2 says ID3v2.4 support UTF-8


Add dump_cache() & restore_cache() to CI_DB_query_builder

Add dump_cache() & restore_cache() to CI_DB_query_builder to enable temporary QB cache save.
Usage:
Before flush:
    $qb_cache = $this->db->dump_cache();

Then, fell free to flush your cache:
    $this->db->flush_cache();

You do not have to flush the cache, you can also append some other conditions, and then restore with the save cache.
And after you make some other get (SELECT) calls then restore from your saved QB cache:
    $this->db->restore_cache($qb_cache);

And then, you can continue with other get (SELECT) calls with previously cached criteria.
That's all this done.

I don't mind the idea in general, but there's a technical detail that makes it a no-go ... the qb_* properties are internal and meant to be inaccessible from userspace.
This proposal doesn't just make them accessible (we've rejected this in the past for people who just want to read them), it makes them writable. And that in turn means we can never assume they're not in a broken state.

What if I cache it with a "tag", then restore it with the tag?

Don't know what you mean by that, but no - the cache in question is a horrible feature to begin with. I'd rather remove it than expand on it.


tunnel_route: Support local inbound and proxy protocol ports

This patch adds the ability to specify that ATS connect to the tunnel_route host using the port that was either:

The destination port on the client-side (inbound) connection that instigated the tunnel_route. This is specified as {inbound_local_port} for the tunnel_route host port target.
The destination port specified via the inbound Proxy Protocol string that instigated the tunnel_route. This is specified as {proxy_protocol_port} for the tunnel_route host port target.

Marking this as a draft while this is reviewed in the dev mailing list.

[approve ci autest]

[approve ci autest]


Problem with repeated use of waypointFollower behavior

Hi,
In "FollowLeadingVehicleWithObstacle" class, the WaypointFollower atomic behavior is used in two instances for same actor which causes the problem of vehicle looping back

stop_near_intersection.add_child(WaypointFollower(self.other_actors[0], 35))
stop_near_intersection.add_child(InTriggerDistanceToNextIntersection(self.other_actors[0], 20))
driving_to_next_intersection.add_child(WaypointFollower(self.other_actors[0], self._first_actor_speed))
driving_to_next_intersection.add_child(InTriggerDistanceToVehicle(self.other_actors[1],
self.other_actors[0], 15))

Hi,
I tried to correct this by making minor changes in WaypointFollower behavior.

I commented the setup function code and updated the waypoint list at the first update tick to get the latest waypoint list at current vehicle position.

Hi @deepakreddy63 ,
I am also facing the same issue, you problem has been solved?

@deepakreddy63 @krdindorkar19 I just created a PR and a fix/waypointFollower branch. Please give it a try and let me know if it fixes the described issues.

@fabianoboril Yes, it has been solved. Thank you !

@deepakreddy63 Your changes should not change the behavior,

@fabianoboril  Yes, it works. Thanks !


Any chance to porting it to Godot 4.1?

Godot 4.1 was lanched these days, I downloaded this awesome addon but it doesn't seem it work at this environment. Any chances for it to work on godot 4.1 ?

works for me? although some stuff is broken, not sure if it worked before.

I downloaded the addon from marketplace and it doesn't work. Should I do something or it is supposed to worked right after install?

It just worked for me! instantly, no restart or anything. You have to enable the plug in project settings, maybe that's the issue.

That was exactly the issue, my bad!


Fix #338, introduce command for creating factories

So far it does not support --model argument; just a stub
Path is not configurable since there are already some places (service provider stub), where /Database/factories path is hard-coded, thus possible BC.

Made new issue for content that was here.

Hold on with this PR, I will update test same as policy one :)

Thanks!


Ctypes to cffi

This PR is meant as a comparison to #8 and show the differences between using CFFI and Ctypes for the rust c ffi.
Updated C FFI to use the cffi module instead of ctypes

Added build script in datajoint-core-ffi-c to run cbindgen and generate header file
Updated python to use cffi library instead of ctypes library
Python connection module uses the header file generated for cdef

This means it needs to use void pointers for the structs
Python no longer needs to declare argument and return types for each rust method

Which do you suggest we use after doing both?

Which do you suggest we use after doing both?

After our Friday meeting, and working out some of the issues with the CFFI method, I'm liking the CFFI method. Simplifying the client code by automatically generating the headers is a pretty good benefit.


Wiki or Mod Support?

Does this support modded items/blocks as well?

There's no wiki, the mod pretty much explains itself. Everyone that I've had try it out, was able to work it out. And I'm not sure which part you're referring to with mod support. In terms of recipes yes, in terms of generally yes. The only possible issue is with some mods and their autocrafting systems. Possibly giving ways around to bypass some of the crafting restrictions. AE is fine, because you have to craft the patterns for them manually anyways. And I'll combat, those as reports come in :P. And if you mean working with mod machines, and their recipes. That would be a lot of work, I would have to ASM a check in to every single mod out there. Mods don't naturally go, can this player craft this. I might do that eventually, but it'll still be an annoyance.

right on, best of luck to you m8.. Im gonna give it a shot in my next mudpack version.

What about utilizing permissions to prevent interaction with certain mod items. This could give you a workaround until a better solution comes along.  Here is an example from Forge Essentials of some permission nodes that might be able to utilize to limit player actions as an example.
fe.protection.interact.tile.ToolForge                                                # INTERACT Tool Forge
fe.protection.interact.tile.ToolStation                                              # INTERACT tile.ToolStation.name
fe.protection.interact.tile.TravellersGear.armorstand                                # INTERACT Armor Stand
fe.protection.interact.tile.WorkbenchPlus                                            # INTERACT WorkbenchPlus
fe.protection.interact.tile.WrathCage                                                # INTERACT Wrath Cage
fe.protection.interact.tile.accumulationTable                                        # INTERACT Accumulation Table

fe.protection.interact.tile.appliedenergistics2.BlockCraftingMonitor                 # INTERACT Crafting Monitor
fe.protection.interact.tile.appliedenergistics2.BlockCraftingStorage                 # INTERACT 1k Crafting Storage
fe.protection.interact.tile.appliedenergistics2.BlockCraftingUnit                    # INTERACT Crafting Unit

fe.protection.inventory.Chisel                                                       # INVENTORY Chisel
fe.protection.inventory.exnihilo.crook                                               # INVENTORY Crook

I'd rather add support for things, than go 'you cannot use this block'. I already do stuff with ae and tinkers.


Throw if features array is empty and moved checks to the top.

Coverage decreased (-0.002%) to 82.004% when pulling 422ebc59c32c059d3cd2768934eae49ce0957cdf on ens-carlos:master into 69dc7009743f844962a6e3c68c2f74278b783c55 on Ensembl:master.

Coverage decreased (-0.002%) to 82.004% when pulling 34931829ea2c73098c1e34d6bab476255e554343 on ens-carlos:master into 69dc7009743f844962a6e3c68c2f74278b783c55 on Ensembl:master.

Is there somewhere upstream that needs further error checking? ie. how did the situation of an empty set of features transpire?
And is there a regression test that can be added to the test suite to check that an error is properly thrown when the features array is empty.
Thanks.

Probably yes there could be another check upstream but I think it's worth adding that check rather than assuming the array won't be empty just before trying to access the first feature in the array later on within the same sub. I think it is a change in line with the current check of ARRAY type.
Sorry I haven't looked into the tests in detail. Could you point me to the file where the ARRAY type exception is checked so I can add a similar test?
Cheers.

@ens-carlos have a look here:
https://github.com/Ensembl/ensembl/blob/release/90/modules/t/transcriptSupportingFeatureAdaptor.t#L42

Can you pass the align type so that it doesn't issue a warning which the test doesn't expect? it is failing otherwise.
thanks

Coverage increased (+0.004%) to 82.011% when pulling 03b183adc0f6ee8bdfe03c7128c47301802d3e6b on ens-carlos:master into 69dc7009743f844962a6e3c68c2f74278b783c55 on Ensembl:master.

Great, thanks, finally it can go in! :+1:

Thank you!


Question of "LiteFileStream Dispose"

https://github.com/mbdavid/LiteDB/blob/373c5e56cca061af4fd9362ad92f728f889f7bfe/LiteDB/Storage/LiteFileStream.cs#L82-L105
Should not you change it like this?
    #region Dispose

    ~LiteFileStream()
    {
        Dispose(false);
    }

    protected override void Dispose(bool disposing)
    {
        base.Dispose(disposing);

        if (disposing)
        {
            if (this.CanWrite)
            {
                this.Flush();
            }
        }
    }

    #endregion

Hi! With the objective of organizing our issues, we are closing old unsolved issues. Please check the latest version of LiteDB and open a new issue if your problem/question/suggestion still applies. Thanks!


Understanding resolution and simplification

Hi there,
I have a tileset built from geojson containing the coastline of the world. I've created this tileset with the following parameters, which works great:
tippecanoe -P -z11 --drop-smallest-as-needed -o output.mbtiles ...

What I would like to do is create a second tileset, but one that:
1- only has zoom 6
2- has the same level of detail at zoom 6, that the original tileset has at zoom 10
This second set (unlike the first) is not intended to be rendered. It is intended to be queried programatically, where the client needs to get the features at the resolution akin to zoom10 of the first dataset, but we do not want the client to make hundreds of requests (at zoom10). Instead we want the client to make a single request to one tile at zoom 6 to get all the features...
To produce this, I've tried the following:
tippecanoe \
  --read-parallel \
  --minimum-zoom=6 \
  --maximum-zoom=6 \
  --no-line-simplification \
  --no-tiny-polygon-reduction \
  --no-feature-limit \
  --no-tile-size-limit \
  --full-detail=16 \
  --output=output.mbtiles ...

I appreciate the tiles will be massive in this tileset, but that's ok. However, the features do not come out at the same detail as the original tileset at zoom 10. Here is an example screenshot (blue is the zoom10 of the original tileset, and red is the same feature at zoom6 in the second tileset).

I might end up doing this trick at zoom 8 or something where the tile mb size doesn't get too crazy, but this is a theoretical question more than anything else. How would I produce a tileset that has it's zoom 6 at the same resolution as the original zoom 10?
Is that possible with tippecanoe?

Zoom levels and "detail" levels refer to the same increment, so, as you say, if you had been using the default detail of 12, and want to match the detail of zoom 10 at zoom 6, you want to use detail 12+10-6=16.
I don't have your data set, but as a test I'm going to try Pacifica, CA, since I know it fits in a z10 tile. https://www2.census.gov/geo/tiger/TIGER2010/PLACE/2010/tl_2010_06_place10.zip
➤ ogr2ogr -f GeoJSON tl_2010_06_place10.shp.json tl_2010_06_place10.shp
➤ grep '"Pacifica"' tl_2010_06_place10.shp.json | tippecanoe -z11 --no-line-simplification -f -o pacifica-11.mbtiles
➤ grep '"Pacifica"' tl_2010_06_place10.shp.json | tippecanoe -z6 -Z6 --no-line-simplification --full-detail=16 -f -o pacifica-6.mbtiles
➤ diff -u <(tippecanoe-decode -z10 -Z10 pacifica-11.mbtiles | jsoncat) <(tippecanoe-decode pacifica-6.mbtiles | jsoncat) | less -S

(using jsoncat from https://github.com/ericfischer/json-pull for diffing convenience).
And you are right, they do not come out exactly the same: the version that was tiled to z11 has one node that the z6 version does not, so there is a loss of precision somewhere in the process that I should figure out.
But other than that they are the same, nothing like the stairstep geometry that you are seeing. What are you rendering your tiles with? Is there something that is downsampling the tile resolution as it gets data out of the tile, rather than respecting the full tile precision?

I was just using mapbox to render it - so nothing should be down sampling anything...
I did notice you dont use some of the other arguments I was using (like --no-tiny-polygon-reduction), so let me try just using what you did and see what that gets me

Can you try rendering the two tilesets you got using mapbox? Maybe it does actually have some other bug that causes it to not handle the non default tile resolution?

The Mapbox error is because you used --no-tile-size-limit to turn off the 500K limit on tile sizes.

Yeah, but I want to not drop anything, so i have to use that no tile size limit (right?)

Right, yes, if you don't use it, your alternatives are either to drop some features or to lower the detail, neither of which will help with this case. But unfortunately it does limit the possibilities for using Mapbox to visualize what's in the tiles.

No worries - maptiler works fine for this case...
I will probably do this at z8 in any case, (z6 really results in massive tiles)... but it was a good exercise, and thanks for the explanation.
(assuming you'll look in to that disappearing feature ;-))

The one-node discrepancy seems to be introduced during the call into Wagyu to clean the polygon geometries. It must have some sensitivity to the exact coordinates of the polygon, since what is being passed in has the same relative coordinates in either case but is relative to a different origin.


Add new greek dictionary.

The aosp was removed because it had many wrong words.

Hi, is this 4MB limit fixed?
It's a problem for many dictionaries (I can't find the issues that mentioned it)
From my side it prevented me from using the keyboard.
In any case, if you can, please increase the limit to cover big dictionaries.


Add Credentional Persistance for Authenticated Users

Add Credentional Persistance for Authenticated Users

https://github.com/anasmohammed361/zenith-mails/commit/c812eb3792cf806e04601a2670b5c501e3cbf7ae


Q: currentWork1

Need to split this question in two. One should ask if the person provide help or expertise. The second question should ask if she work in a larger group to provide this help or expertise
"Do you work within a group that provides software development help or expertise to researchers from across your organisation?"
Y/N/NA

Splitted the question in two: currentWork1 and currentWork2 with condition for the latter
currentWork1: Do you provide help and expertise in software development to researchers from across your organisation?
currentWork2: Are you working in a larger group/organisation to provide this help/expertise?


Feature Request: Deathmatch

Love the idea of this web panel, was hoping you could look at implementing Deathmatch to the Gamemodes. Great work!

Hey!
Apologies but I won't be able to take up new features on this project as I'm working on a different plugin called MatchZy (https://github.com/shobhit-pathak/MatchZy). If you want a pug/practice/scrim/match plugin, you can check that out :D
Thanks!


chore(main): release 0.2.3

:robot: I have created a release beep boop
0.2.3 (2024-10-02)
Features

improve user profile placeholder in nav (#55) (a48e1ab)

Bug Fixes

fix frontend handling undefined flow url (#52) (73a835f)
fix gradual memory leak / perf issue with cytoscape (#56) (703417d)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/kurtosis-tech/kardinal-kontrol/releases/tag/0.2.3 :sunflower:


[fix] Fetching multiple documents from a view with include_docs=true fails

When trying to fetch multiple documents from a view with
{ keys: [array, of, keys], include_docs:true }

the "include_docs" option was ignored by the database. Fetching single documents worked fine.
The current code submitted all options as params of the post request, but the documentation here:
https://wiki.apache.org/couchdb/HTTP_Bulk_Document_API suggests only the keys should be submitted as part of the post request, and the other options should be tacked onto the url get-style.

This is a dupe of #108 (which is a dupe of #43)

Yup, you're right. I don't know how I missed that, sorry, I'm kinda new to open source on github. This was my first pull request.

Good to see it :) Sorry for the bluntness, was just a quick check to see if my request had gone through and thought I'd let you know.


Forbid unsafe code

textwrap does not seem to use unsafe code, which is very good :)
To prevent this from ever happening, add following line to the top:
#![forbid(unsafe_code)]

of https://github.com/mgeisler/textwrap/blob/master/src/lib.rs
This will make the package green in
https://github.com/rust-secure-code/cargo-geiger

Hey @ralpha, I'm actually considering introducing a function that will use a bit of unsafe code to cheaply wrap a string inplace (as discussed in #166. Such a line would then need to go.
If a dependency has both safe and unsafe functions, can cargo geiger then tell me if I only call code in the safe subset of my dependencies? Or is a dependency flagged as "safe" or "unsafe" as a whole?

cargo geiger will tell you how many unsafe code is in the repo and how many is called. Currently this is how it is shown in my dependencies: (I use textwrap because of clap)
Functions  Expressions  Impls  Traits  Methods  Dependency
0/0        0/0          0/0    0/0     0/0      ?      │   ├── textwrap 0.11.0
0/0        0/0          0/0    0/0     0/0      ?      │   │   └── unicode-width 0.1.8

Here you can see a dependencies with unsafe code:
1/1        16/28        0/0    0/0     0/2      !  │   │   ├── log 0.4.11

It tells me:
Metric output format: x/y
x = unsafe code used by the build
y = total unsafe code found in the crate
Note that you have to be sure you NEED to use unsafe!
Looking at the issue it looks like this can be done using safe code and there is not a need for unsafe here.
I'm not familiar with the code-base but this is my guess.
If you have questions open an issue here: https://github.com/rust-secure-code/safety-dance/
Someone might be able to help you not needing unsafe code.
If you REALLY need unsafe but only in some cases you could add it under a feature flag, so it is opt-in.
Some more info about unsafe in general: https://www.youtube.com/watch?v=QAz-maaH0KM
If you do at unsafe code, please add a fuzzer too to check the unsafe code and write some tests for it. This makes sure you don't introduce memory bugs (now or in the future).

Hi @ralpha okay, thanks for the link to the Rust Safety Dance, looks like a very useful resource!
I've added the attribute and will definitely be careful if I ever add some unsafe code.


Do we need to install tslint globally?

Great plugin; using it now.
I'm wondering if we need to install tslint globally, as it says in the docs. I often install it on a per-project basis and don't want to maintain a global copy.
I think I can configure the path to the executable, but I'm still new to the Sublime Text ecosystem so I was having some problems with that, or I'm misunderstanding something. Would you happen to know if this is possible?
Secondly, would it make sense to for the plugin to prefer ./node_modules/.bin/tslint, and use only the global executable if that fails?

Actually it should work with local install too. Try it.

Thanks for the reply.
What's the best way to configure this?
SublimeLinter: user shell: /bin/bash
SublimeLinter: computed PATH using /bin/bash:
/Applications/Sublime Text.app/Contents/MacOS/${project}/node_modules/.bin
/Library/Frameworks/Python.framework/Versions/3.5/bin
/usr/local/bin
/usr/local/sbin
/usr/bin
/bin
/usr/sbin
/sbin
/Library/Frameworks/Python.framework/Versions/3.5/bin

SublimeLinter: WARNING: tslint deactivated, cannot locate 'tslint'

I used this approach in SublimeLinter.sublime-settings:
...
"paths": {
    "*": [],
    "linux": [],
    "osx": [
        "~/code/private/node/node_modules/.bin"
    ],
    "windows": []
},
...


Export (Reports, Notifications Integration (API) Incidents

Dear support team,
Version: 4.1.24-1
I would like to report an issue I am experiencing while trying to download all incidents using the API with cURL.
When making the request to retrieve the incidents, I am encountering difficulties in receiving all the registered information, including tags and other relevant details.
Having complete access to the incidents is crucial for my work, as I need to properly analyze and process this data.
I would appreciate it if you could investigate this issue and provide guidance on how I can obtain all incidents with all the relevant information using the API and cURL or any other suitable method.
curl.exe -H 'Authorization: Bearer [API_KEY_GERADA]' 'http://<IP_ADDRESS>:8767/api/case?range=all' > c:/temp/incidents.json
Additionally, I would appreciate support with other matters such as integration with Office or even alert notifications.
I am available to provide further details or additional information if needed.
Thank you in advance for your attention and support.

Please reach out to the support team via<EMAIL_ADDRESS>Closing this issue as it is not related to the library itself.