Suggest to loosen the dependency on databases

Hi, your project icosa-api(commit id: 38396adceea252c0bc4fc4d97a17b2eb852028fb) requires "databases==0.4.1" in its dependency. After analyzing the source code, we found that the following versions of databases can also be suitable, i.e., databases 0.4.0, 0.4.2, 0.4.3, 0.5.0, 0.5.1, 0.5.2, 0.5.3, 0.5.4, 0.5.5, since all functions that you directly (1 APIs: databases.core.Database.init) or indirectly (propagate to 3 databases's internal APIs and 3 outsider APIs) used from the package have not been changed in these versions, thus not affecting your usage.
Therefore, we believe that it is quite safe to loose your dependency on databases from "databases==0.4.1" to "databases>=0.4.0,<=0.5.5". This will improve the applicability of icosa-api and reduce the possibility of any further dependency conflict with other projects.
May I pull a request to further loosen the dependency on databases?
By the way, could you please tell us whether such an automatic tool for dependency analysis may be potentially helpful for maintaining dependencies easier during your development?

Hello, we don't deem this important right now, if we were to add dependency checks, we would use a tool such as dependabot in future. Please don't run this bot on this repository in future.
Best of luck with writing the tool though!


⚠ Fortnite has degraded performance

In 268f40b, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1613 ms

Resolved: Fortnite performance has improved in 7d54960.


Optional fixed height scrolling for lists and details

Here is a simple example: http://jsfiddle.net/johnshew/kndfj3r5/

Done.  Test18 a concise summary of the approach.


Update 22-generate-parentheses.cpp

File(s) Modified: 0022-generate-parentheses.cpp
Language(s) Used: C++
Submission URL: _https://leetcode.com/problems/generate-parentheses/submissions/923295858/_

Notes
The generate parentheses problem is grouped under the stack category on the Roadmap. However, the given solution to the problem uses a recursion approach, which is only covered further down the Roadmap in the Backtracking section. I have added an efficient, succinct stack solution to this problem to better illustrate the use of stack data structure. I believe this change is necessary for learners following the learning Roadmap.
Important
Please make sure the file name is lowercase and a duplicate file does not already exist before merging.

@Steven-Yiran Thanks for your contribution 👍


[R-package] [docs] fix warnings in pkgdown site  building

This PR fixes the warnings from the last outstanding item in this comment: https://github.com/microsoft/LightGBM/issues/1143#issuecomment-526936690
Warning message:
Topics missing from index:
* lgb_shared_params
* lightgbm

To confirm, I ran:
Rscript build_r.R
cd lightgbm_r
Rscript -e "pkgdown::build_site(install = FALSE)"

re-using this branch from #3072 since it's already enabled on readthedocs.

oh @StrikerRUS was fix/remove-devtools already disabled at readthedocs? Do you mind re-enabling it?

@jameslamb

oh @StrikerRUS was fix/remove-devtools already disabled at readthedocs? Do you mind re-enabling it?

Yeah, I removed the branch and disabled RTD builds right after merging previous PR. Sorry! Just enabled builds again.

All recent macOS R-package builds at Travis are stuck at
* checking whether package ‘lightgbm’ can be installed ...

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Hope it is temporary problem...

@jameslamb

oh @StrikerRUS was fix/remove-devtools already disabled at readthedocs? Do you mind re-enabling it?

Yeah, I removed the branch and disabled RTD builds right after merging previous PR. Sorry! Just enabled builds again.

no problem! I should have asked you to keep them.

All recent macOS R-package builds at Travis are stuck at
* checking whether package ‘lightgbm’ can be installed ...

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Hope it is temporary problem...

:grimacing: I just tried rebuilding, let's see

I should have asked you to keep them.

OK!

😬 I just tried rebuilding, let's see

Already tried 3 times with master... 😢

:grimacing: Travis status looks fine, no ongoing incidents... https://www.traviscistatus.com/

Just added https://github.com/microsoft/LightGBM/pull/3086/commits/89c6b3c55cc5e887b896e98ead7844d4d29d0109 to see if we can get better logs and identify what is breaking in the Mac R environment on Travis. I'll revert that commit before we merge this, just using it for investigation.

Just added 89c6b3c to see if we can get better logs and identify what is breaking in the Mac R environment on Travis.

... and it just passed all checks! 😄
I guess building without logs is just near 10mins.
Probably we need some dummy output to prevent Travis from terminating our build:
https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received
https://github.com/travis-ci/travis-ci/issues/4190#issuecomment-353342526

WOW! I wonder if this is somehow related to how we switched all print() to message() in install.libs.R?

I think it was the print() to message() change in #2965  . Looks like print() prints to stdout and message() to stderr:

I documented the issue with timeouts in #3091, and just added a PR for it in #3092

Great investigation!
Can we get back to print() for the sake of speed?

Great investigation!
Can we get back to print() for the sake of speed?

Sorry, I wasn't clear....I  don't think our Mac builds are slower now because of message(). I was thinking that since message() prints to stderr, maybe changing print() to message() increased the likelihood that we'd go 10 minutes with no new stdout.
I think that we should:

keep message() in install.libs.R, agreeing with @Laurae2 that it's the more appropriate choices for package installation messages
separately investigate  why the Mac builds for the r-package have gotten so much slower in the last few days

I just rebased to master to get the fix from #3092 . Assuming this builds successfully, I'll merge it and then work on replacing build_r_site.R per https://github.com/Microsoft/LightGBM/issues/1143#issuecomment-629490569


Confusing error with nonliteral explicit discriminant

https://github.com/maciejhirsz/logos/blob/ea0a3a7c2798144887243f1c535f332682091255/logos-derive/src/lib.rs#L67-L75
If a user sets a discriminant to a nonliteral expression such as u16::MAX, this fails with "attempt to add with overflow," which is far from indicative of the actual issue.
Instead of .unwrap_or(usize::max_value()), we should match the attempted evaluation, and in the case of an expression we cannot evaluate, emit a descriptive error that we don't support nonliteral explicit discriminants.

Side note: I think this handling is incorrect. IIUC, Token::SIZE should always be one larger than the largest discriminant. This is, however, demonstrably false:
enum Token {
    #[error]
    Error = 100,
    A, // = 101
    B, // = 102
}

fn main() {
    dbg!(Token::SIZE);
    dbg!(Token::B as usize);
}

gives Token::SIZE = 101 and Token::B as usize = 102.
The simple fix here is tracking the "implicit discriminant" and checking that, rather than only the explicit discriminant.
However, it seems that lookup! is now completely unused by logos's internals. As such, I think the better recommendation is to remove lookup! and Logos::SIZE, and suggest users of lookup! use a crate such as enum-map instead.

Good find!

Good find!


The modify interaction should not add and remove a vertex on a single click

When using the modify interaction, a pointerdown event results in a vertex being added to a geometry.  A singleclick results in a vertex being deleted from a geometry.  So when a user clicks on a segment of a line or polygon, we first add and then remove a vertex.  This means the geometry revision is incremented twice, and anybody interested in monitoring whether geometries are being revised will be mislead.
If we want to keep the same behavior (no point added for click), we could wait until a move event to insert the vertex.  If we want to change the behavior so that a point is added for a click, we may have to track the sequence of events and modify the delete condition so we don't delete on pointerdown, pointerup, singleclick (with no other events in the sequence).

I think this one was fixed with #3635


gremlin-console: init at 3.3.3

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: gremlin-console
Partial log (click to expand)
Cannot nix-instantiate `gremlin-console' because:
error: while evaluating the attribute 'installPhase' of the derivation 'gremlin-console-3.3.3' at /var/lib/gc-of-borg/nix-test-rs-32/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-32/pkgs/stdenv/generic/make-derivation.nix:177:11:
while evaluating the attribute 'buildInputs' of the derivation 'openjdk-8u181b13' at /var/lib/gc-of-borg/nix-test-rs-32/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-32/pkgs/stdenv/generic/make-derivation.nix:177:11:
while evaluating the attribute 'buildCommand' of the derivation 'openjdk-bootstrap' at /var/lib/gc-of-borg/nix-test-rs-32/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-32/pkgs/stdenv/generic/make-derivation.nix:177:11:
No bootstrap for system

Success on x86_64-darwin (full log)
Attempted: gremlin-console
Partial log (click to expand)
no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/c6fpkdswdnqwafdvl7ylp3g73vrd82a5-gremlin-console-3.3.3/bin
patching script interpreter paths in /nix/store/c6fpkdswdnqwafdvl7ylp3g73vrd82a5-gremlin-console-3.3.3
/nix/store/c6fpkdswdnqwafdvl7ylp3g73vrd82a5-gremlin-console-3.3.3/opt/bin/gremlin-console: interpreter directive changed from "/bin/bash" to "/nix/store/z2pc6bbx9d1mwwahnds31a7nlvjbi9zr-bash-4.4-p23/bin/bash"
/nix/store/c6fpkdswdnqwafdvl7ylp3g73vrd82a5-gremlin-console-3.3.3

Success on x86_64-linux (full log)
Attempted: gremlin-console
Partial log (click to expand)
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/njzr4v2slr9a23cf2990p939k9q5x21m-gremlin-console-3.3.3
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/njzr4v2slr9a23cf2990p939k9q5x21m-gremlin-console-3.3.3/bin
patching script interpreter paths in /nix/store/njzr4v2slr9a23cf2990p939k9q5x21m-gremlin-console-3.3.3
/nix/store/njzr4v2slr9a23cf2990p939k9q5x21m-gremlin-console-3.3.3/opt/bin/gremlin-console: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/njzr4v2slr9a23cf2990p939k9q5x21m-gremlin-console-3.3.3...
/nix/store/njzr4v2slr9a23cf2990p939k9q5x21m-gremlin-console-3.3.3

@samueldr I updated the PR with the 3.4.4 release.
@GrahamcOfBorg build gremlin

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: gremlin
Partial log (click to expand)
Cannot nix-instantiate `gremlin' because:
error: attribute 'gremlin' in selection path 'gremlin' not found

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: gremlin
Partial log (click to expand)
Cannot nix-instantiate `gremlin' because:
error: attribute 'gremlin' in selection path 'gremlin' not found

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: gremlin-console
Partial log (click to expand)
Cannot nix-instantiate `gremlin-console' because:
error: while evaluating the attribute 'installPhase' of the derivation 'gremlin-console-3.3.4' at /var/lib/gc-of-borg/nix-test-rs-13/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-13/pkgs/stdenv/generic/make-derivation.nix:180:11:
while evaluating the attribute 'buildInputs' of the derivation 'openjdk-8u181b13' at /var/lib/gc-of-borg/nix-test-rs-13/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-13/pkgs/stdenv/generic/make-derivation.nix:180:11:
while evaluating the attribute 'buildCommand' of the derivation 'openjdk-bootstrap' at /var/lib/gc-of-borg/nix-test-rs-13/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-13/pkgs/stdenv/generic/make-derivation.nix:180:11:
No bootstrap jdk for system aarch64-linux

No attempt on x86_64-linux (full log)
The following builds were skipped because they don't evaluate on x86_64-linux: gremlin
Partial log (click to expand)
Cannot nix-instantiate `gremlin' because:
error: attribute 'gremlin' in selection path 'gremlin' not found

Success on x86_64-darwin (full log)
Attempted: gremlin-console
Partial log (click to expand)
no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/j9p9gcb1v2qlakxcmx4j1s9m5zf8yyk8-gremlin-console-3.3.4/bin
patching script interpreter paths in /nix/store/j9p9gcb1v2qlakxcmx4j1s9m5zf8yyk8-gremlin-console-3.3.4
/nix/store/j9p9gcb1v2qlakxcmx4j1s9m5zf8yyk8-gremlin-console-3.3.4/opt/bin/gremlin-console: interpreter directive changed from "/bin/bash" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/bash"
/nix/store/j9p9gcb1v2qlakxcmx4j1s9m5zf8yyk8-gremlin-console-3.3.4

Success on x86_64-linux (full log)
Attempted: gremlin-console
Partial log (click to expand)
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hxw8hbsic19bw3n67ak27sc1cl2xbavs-gremlin-console-3.3.4
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hxw8hbsic19bw3n67ak27sc1cl2xbavs-gremlin-console-3.3.4/bin
patching script interpreter paths in /nix/store/hxw8hbsic19bw3n67ak27sc1cl2xbavs-gremlin-console-3.3.4
/nix/store/hxw8hbsic19bw3n67ak27sc1cl2xbavs-gremlin-console-3.3.4/opt/bin/gremlin-console: interpreter directive changed from "/bin/bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/hxw8hbsic19bw3n67ak27sc1cl2xbavs-gremlin-console-3.3.4...
/nix/store/hxw8hbsic19bw3n67ak27sc1cl2xbavs-gremlin-console-3.3.4

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: gremlin-console
Partial log (click to expand)
Cannot nix-instantiate `gremlin-console' because:
error: while evaluating the attribute 'installPhase' of the derivation 'gremlin-console-3.3.4' at /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/pkgs/stdenv/generic/make-derivation.nix:180:11:
while evaluating the attribute 'buildInputs' of the derivation 'openjdk-8u181b13' at /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/pkgs/stdenv/generic/make-derivation.nix:180:11:
while evaluating the attribute 'buildCommand' of the derivation 'openjdk-bootstrap' at /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/pkgs/stdenv/generic/make-derivation.nix:180:11:
No bootstrap jdk for system aarch64-linux

Success on x86_64-darwin (full log)
Attempted: gremlin-console
Partial log (click to expand)
no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/j9p9gcb1v2qlakxcmx4j1s9m5zf8yyk8-gremlin-console-3.3.4/bin
patching script interpreter paths in /nix/store/j9p9gcb1v2qlakxcmx4j1s9m5zf8yyk8-gremlin-console-3.3.4
/nix/store/j9p9gcb1v2qlakxcmx4j1s9m5zf8yyk8-gremlin-console-3.3.4/opt/bin/gremlin-console: interpreter directive changed from "/bin/bash" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/bash"
/nix/store/j9p9gcb1v2qlakxcmx4j1s9m5zf8yyk8-gremlin-console-3.3.4

Success on x86_64-linux (full log)
Attempted: gremlin-console
Partial log (click to expand)
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hxw8hbsic19bw3n67ak27sc1cl2xbavs-gremlin-console-3.3.4
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hxw8hbsic19bw3n67ak27sc1cl2xbavs-gremlin-console-3.3.4/bin
patching script interpreter paths in /nix/store/hxw8hbsic19bw3n67ak27sc1cl2xbavs-gremlin-console-3.3.4
/nix/store/hxw8hbsic19bw3n67ak27sc1cl2xbavs-gremlin-console-3.3.4/opt/bin/gremlin-console: interpreter directive changed from "/bin/bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/hxw8hbsic19bw3n67ak27sc1cl2xbavs-gremlin-console-3.3.4...
/nix/store/hxw8hbsic19bw3n67ak27sc1cl2xbavs-gremlin-console-3.3.4


Command-line overrides and "install --copy" with rsync

Fixes #6 and #7

@marcello3d @mblakele

Would be nice to see something in the readme about how to use the new feature. I'm a little confused about the difference between copy/fastcopy in config, and --copy

Might be worth mentioning that you can testing this with pip install git+https://github.com/vivlabs/instaclone.git@fee5e53. I've done that on my laptop.


Addressed contrast ratio

This fixes :

[WPF Gallery->Samples->User Dashboard]: Color contrast ratio of text under selected username is 4.409:1 which is less than the required ratio of 4.5:1.
[WPF Gallery->Samples->Icons]: Color contrast ratio of text under icons is 3.179:1 which is less than the required ratio of 4.5:1.

Microsoft Reviewers: Open in CodeFlow

LGTM


Migrate runtime views to new perspective layout

Depends on https://github.com/kiegroup/appformer/pull/175

@nmirasch @bsremac please have a look.

@cristianonicolai I have been having problems building jbpm-wb since last Friday. The failure happens while compiling the last module - jbpm-wb-showcase. This is just one of many errors I see in the console:
[ERROR] Errors in 'jar:file:/home/bsremac/.m2/repository/org/kie/workbench/forms/kie-wb-common-forms-editor-client/7.7.0-SNAPSHOT/kie-wb-common-forms-editor-client-7.7.0-SNAPSHOT-sources.jar!/org/kie/workbench/common/forms/editor/client/editor/FormEditorPresenter.java'
[INFO]          [ERROR] Line 275: versionRecordManager cannot be resolved
[INFO]          [ERROR] Line 436: versionRecordManager cannot be resolved
[INFO]          [ERROR] Line 450: notification cannot be resolved
[INFO]          [ERROR] Line 285: The method isDirty(int) is undefined for the type FormEditorPresenter
[INFO]          [ERROR] Line 254: menus cannot be resolved to a variable
...

I don't know how to get pass this problem. I have gone as far as cleaning my entire local maven repo and then again pulling all dependencies and building appformer locally due to dependency on kiegroup/appformer#175.
I can successfully build kie-wb-common project, but even with all of this in place, I'm still getting the errors.
All of this made me think that certain group of .jars we depend on is really corrupted, but then you would have the same problem too and you obviously don't.

@bsremac I got the same issue this morning. I had to rebase my changes in https://github.com/kiegroup/appformer/pull/175 to make it work again. You will have to checkout the latest version from that PR locally and rebuild for it to work.

@cristianonicolai There's no harm in approving certain things twice, even when done by mistake :)


Update dependencies

Coverage remained the same at 91.628% when pulling b87a079aa5f191532cd43fcb89bedc598fe50b08 on rel_branch into 26656047d7e4f4682df25d80417c91f785a899cd on master.


[GOBBLIN-1300] Rethrow exceptions when storing job status in state store

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1300

Description

[x] Here are some details about my PR, including screenshots (if applicable):
Exceptions from parsing the message should be caught, but not exceptions when storing job status in state store.

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
trivial

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@sv2000 please review


Result under multiprocessing is flaky

I found the result returned by the timezone_at method is flaky when running under multiprocessing environment. By flaky, I mean it will return different results from one run to another. I have stripped down my code to following test case to help you reproduce the problem.
import multiprocessing
from timezonefinder import TimezoneFinder

lat_lngs = [
    (-39.88267, 6.58189),
    (-41.68253, 2.39381),
    (-41.59774, 1.59106),
    (-39.75798, 0.58502),
    (-40.3352, 0.73756),
    (-41.7354, 7.75914),
    (-41.42347, 1.64142),
    (-43.66458, 9.14061),
    (-39.50622, 3.43441),
]

tf = TimezoneFinder()

def get_timezone_one(row):
    lat, lng = row
    return tf.timezone_at(lat=lat, lng=lng)

def run(lat_lngs):
    pool = multiprocessing.Pool(processes=2)
    return pool.map(get_timezone_one, lat_lngs)

def test_timezonefinder(assert_df_equal, test_data_folder):
    for i in range(50):
        res1 = run(lat_lngs)
        res2 = run(lat_lngs)
        assert res1 == res2

Just use pytest to run the test case. It will have high probablity to fail. More specifically, most of the time, the run() function will return [None, None, None, None, None, None, None, None, None], but sometimes it will return [None, None, None, None, None, None, None, None, 'Africa/Ndjamena'] or other different values.
My environment:

Ubuntu 18.04
Python 3.7.3
timezonefinder=4.4.0
numba==0.49.1.  I had suspected whether it is caused by numba, but after removing the numba pkg from my python environment the problem persits.

Interesting. This behavior is unexpected, since the code should be deterministic. I will look into it as soon as possible. Thanks for pointing this out.

I guess multiprocessing.Pool does require the code to be thread safe, but parallel timezone queries (with a single TimezoneFinder instance) are not thread safe.
This is because a single TimezoneFinder instance keeps binary files open to consequtively read from them.
In order to achieve correct parallelism please create separate TimezoneFinder instances for every process.
Please reopen this issue if this is not the solution to the problem.


WordPress plugin page says the plugin is only compatible up to 3.6.1

Hello,
I would like to get started using this plugin, but our lead developer is nervous about the inactivity on the WP plugin page over the last year and a half.  Can you explain your current approach to supporting this plugin?  Do you simply prefer that everyone just ignore the download available on https://wordpress.org/plugins/schema-creator/ and use whatever you have as the latest on GitHub?  If so,  up to what version of WP is this plugin really compatible?
Thank you!

Your developer is right that we haven't shipped any changes to the plugin repository in a while, but the plugin is still in active development. We are aiming to get a 1.1.0 release together in the near term. When that version is finalized, it will be posted to the official plugin repository.
The plugin has been tested against WordPress 4.1.1 (latest public release) and we aren't aware of any breaking changes specific to newer versions of WordPress.

We've shipped version 1.1.1 with some minor updates. Thanks for reaching out.
https://wordpress.org/plugins/schema-creator/changelog/

Thanks very much!
On Wed, Apr 8, 2015 at 11:51 PM, Stephen Yeargin<EMAIL_ADDRESS>wrote:

Closed #122 https://github.com/raventools/schema-creator/issues/122.
—
Reply to this email directly or view it on GitHub
https://github.com/raventools/schema-creator/issues/122#event-276884007.


img2img.py: error: ambiguous option: --strength could match --strength_in, --strength_out

As described in the title. When I try to run the demo script in the README, I encounter this error.

This part of the README is apparantly outdated, thanks for bringing this to our attention. Please use strength_in and strength_out (for separate noising levels for inner and outer regions accordingly), or just erase the flag if you wish to use the default. We'll fix this in the README instructions.


Option to Store Computed Colors on nodes and links

Elevator Pitch

Like with NodeSelection and LinkSelection, add an option to ContinuousColor and OrdinalColor to store the value in a column.

Motivation

We want to be able to color links based on the color of their source or target, but when the nodes are colored using ContinuousColor, it is not possible to reference a node's color.
This is motivated from the concept of groups in a graph, where we not only want to color the nodes based on their group assignment, but also the links that connect between two nodes in the same group.

Design Ideas

Add a column_name trait to ContinuousColor and OrdinalColor and store the computed color under that name,
As with NodeSelection and LinkSelection, the default_value = None and in which case, nothing is stored.
We may want to check that the user does not specify __indexColor as that seems to be a reserved property in forcegraph.

Fixed by #125


Reserved path characters removed from filenames

Addresses CIMPL-870, replacing reserved path characters with - to prevent unsavory file writing behavior. This PR adds this behavior to makeNameSushiSafe which previously just removed whitespace from entity names, and renames the function to sanitizeName.

This looks like it affects the actual resource names, not just the filenames. In other words, if a profile is named My/Profile in the original FHIR source, then this will produce FSH that names the profile My-Profile instead. This would negatively impact the round-trip (since it changes the actual name in the definition).
We usually try to keep the round-trip intact, when possible. Would it be possible to sanitize only the filename when we write it out? In other words, the FHIR definition name should stay the same (/ and all), but when we write out the file to disk, we would replace the bad chars in the file name with -. This way we're addressing the problem (preventing unintended path traversal) without affecting the FHIR definitions.

That was my mistake! I've updated this to only affect filenames, and leave the actual resources alone.

In the interest of getting a release out today, I will merge this with 1 1/2 reviews.  @jafeltra was able to briefly review the code -- and although she did not spend as much time as she normally would, everything "seemed reasonable".  I think that plus my more thorough review is sufficient for this PR.


Running async actions on captured synchronization context

Runnng Polly inside MS Orleans grain is not possible, since Orleans uses custom TaskScheduler and due to automatically added ConfigureAwait(false) action escapes it and runs on different thread, thus breaking single-threaded guarantee provided by Orleans.
Is that possible to add an overload for RetryAsync\WaitRetryAsync that will allow to control that behavior?
P.S. I'll be happy to send a PR but I have no idea what feature/project type my VS15 installation is missing, that I cannot load Polly.Shared projects. It tell me that The imported project "C:\Program Files (x86)\MSBuild\Microsoft\WindowsXaml\v14.0\8.1\Microsoft.Windows.UI.Xaml.CSharp.targets" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.  C:\Program Files (x86)\MSBuild\Microsoft\WindowsXaml\v14.0\Microsoft.Windows.UI.Xaml.CSharp.targets :worried:
Is that ExpressionDesigner that need to be installed?

Great catch - I'd never had figure this out in our project :-)

I've figured out that I don't have Windows Phone SDK installed. Done that.
@michael-wolfenden will you accept PR that fixes aforementioned problems? We can discuss api changes before I even try or I can proceed with PR, so there will be something eligible for further discussion?
Sketching that, I think it could be implemented without any breaking changes.

Sure thing @yevhen, send through the pull request and I'll check it out


Tempo destination is not working due to Parsing Error with Appended Port 4317

Describe the bug
When creating the Tempo destination backend.ns.svc.cluster.local:8888/tempo/api/push in Odigos, it incorrectly appends :4317 to the endpoint. This results in the endpoint being formatted as backend.ns.svc.cluster.local:8888/tempo/api/push:4317
To Reproduce
Open Odigos UI, add a Tempo destination.  Add application to source and wait for data to be sent to Tempo endpoint.  We got error from Odigos  Gateway
Expected behavior
Expected Odigos to honor the Tempo endpoint destination as configured.
Additional context
Odigos version: 1.0.107
EKS version: 1.25
The culprit seems to be in this section ot tempo.go
			"endpoint": fmt.Sprintf("%s:4317", url),
			"tls": GenericMap{
				"insecure": true,
			},

It seems to be hardcoded to force 4317 port.  It TrimSuffix and then readded it back.

@jlimai Thank you for reporting this issue and sharing the steps to reproduce it. We'll make sure to keep you updated on our progress and let you know once the fix is deployed.
We appreciate your patience and support in helping us improve Odigos!


Installation directions not working on NixOS 23.05.2613.011567f35433

I'm following the "NixOS module" installation directions in the README. In particular, I have
imports = [
  (fetchTarball "https://github.com/msteen/nixos-vscode-server/tarball/master")
];

services.vscode-server.enable = true;

in my /etc/nixos/configuration.nix and have run sudo nixes-rebuild switch.
But then:
$ systemctl --user enable auto-fix-vscode-server.service
Failed to enable unit: Unit file auto-fix-vscode-server.service does not exist.

Why is this command failing? How can I enable the service?

You should try disabling it first:
systemctl --user disable auto-fix-vscode-server.service
And then you should be able to start / stop / enable it again hopefully. Some weird cache or other mechanism that causes did. As far as I know it is a general issue and not particular to this project.
If that fails you can try:
ln -sfT /run/current-system/etc/systemd/user/auto-fix-vscode-server.service ~/.config/systemd/user/auto-fix-vscode-server.service
I have a version of this project where I have the service enabled for all users by default, but that still has some bugs that I haven't gotten around to fixing yet.

Thanks for your response @msteen !
Disabling didn't seem to work for me:
❯ systemctl --user disable auto-fix-vscode-server.service
Failed to disable unit: Unit file auto-fix-vscode-server.service does not exist.

But linking, enabling, and starting did:
ln -sfT /run/current-system/etc/systemd/user/auto-fix-vscode-server.service ~/.config/systemd/user/auto-fix-vscode-server.service
systemctl --user enable auto-fix-vscode-server.service
systemctl --user start auto-fix-vscode-server.service

Thanks again @msteen ! This module is a life saver!


curl request on containerd socket  not working

Description
I want to get the info of the crictl inspect <container_id > command using the curl request over the contaienrd socket .
In cri-o , we can run the following curl command to get the same data over curl socket:
curl --unix-socket /var/run/crio/crio.sock http://localhost/containers/<container_id>
I am trying to do the same on containerd . crictl inspect <container_id > command is also working and giving the information for the container . But when I try to get the info from curl command getting  following error :
curl --unix-socket /run/containerd/containerd.sock  http://localhost/containers/<container_id>
curl: (7) Couldn't connect to server

Can you guys let me know how can I achieve  the same on containerd ?
Steps to reproduce the issue
run following command on the worker node
curl --unix-socket /run/containerd/containerd.sock  http://localhost/containers/<container_id>
Describe the results you received and expected
Should get the information same as crictl inspect with curl --unix-socket /run/containerd/containerd.sock  http://localhost/containers/<container_id>  , but getting following error:
curl: (7) Couldn't connect to server
What version of containerd are you using?
containerd --version containerd github.com/containerd/containerd v1.6.6 10c12954828e7c7c9b6e0ea9b0c02b01407d3ae1 v1.6.6 10c12954828e7c7c9b6e0ea9b0c02b01407d3ae1
Any other relevant information
No response
Show configuration if it is related to CRI plugin.
No response

The cri-o project created a simple HTTP API that is not part of the CRI API definition (which is only accessible via gRPC as a protocol). I don't know of any other runtimes that support the cri-o HTTP API, and they themselves mention in the README for the project that it is not stable nor should it be used in production, unless that is an old comment?
More details in the cri-o README: https://github.com/cri-o/cri-o#the-http-status-api
Given this is specific to cri-o, there won't be any expectation that containerd would ever add this feature; you can continue to use any client that supports the CRI or the containerd service gRPC API to talk to containerd.

Hi @estesp , Thanks for answering my query.
Can you please point out towards the gRPC APIs in contaienrd which I can use to the the info about the containers based on the container_id .


New action request: peter-evans/create-pull-request

Action name
uses: peter-evans/create-pull-request
Reasons
peter-evans/create-pull-request

Intended usage
peter-evans/create-pull-request

I have checked the internal marketplace for similar actions and couldn't find one that works for us.

[X] I have checked the internal marketplace first

:robot: Found these results:

Check
Results
Links

CodeQL on the forked repo
:white_check_mark:
CodeQL run

Security scan:

Check
Result

No Dependabot configuration found
⛔

No CodeQL Init found
⛔

No CodeQL Analyze found
⛔

:robot: Found these results:

Check
Results
Links

CodeQL on the forked repo
:x:
CodeQL run

Security scan:

Check
Result

No Dependabot configuration found
⛔

No CodeQL Init found
⛔

No CodeQL Analyze found
⛔

:robot: Check completed with result: ✅
Found 0 Dependabot security vulnerabilities:
0 where high and 0 where moderate.
Use this link to verify the alerts.


Also generate normalized XML

In order to increase the test coverage also generate the normalized version
of XML output.

I pushed a new version

Hello
We can definetly handle this as a new issue.
I want to point out what I have seen, and what my opinions are.
I didn't notice this until I rebased my work onto your PR and ran the tests.
There is some file that gives some output
When looking at the tests of this PR, https://github.com/rscada/libmbus/pull/168/checks?check_run_id=816071416
Lines 12-14 of the step "generate test frames" is new.
There is no indication what file is causing this. (The level above probably just ignores it.)
mbus_vif_unit_normalize: Unknown VIF 0x07B
mbus_vib_unit_normalize: Error mbus_vif_unit_normalize
mbus_parse_variable_record: problem with mbus_vib_unit_normalize

Locally, I added this command echo "*** "$hexfile at the loop at the end of generate-xml.sh.
It indicated:
*** test/test-frames/sen_pollutherm.hex
Looking at the diff, indicates that datarecord with id=2 is completly empty in the normalized file.
The contents in the record with id=9, is how the normalized xml should look?
diff -u sen_pollutherm.xml  sen_pollutherm.norm.xml | less
     <DataRecord id="1">
         <Function>Instantaneous value</Function>
         <StorageNumber>0</StorageNumber>
-        <Unit>Volume (1e-2  m^3)</Unit>
-        <Value>799892</Value>
+        <Unit>m^3</Unit>
+        <Quantity>Volume</Quantity>
+        <Value>7998.920000</Value>
     </DataRecord>

     <DataRecord id="2">
-        <Function>Instantaneous value</Function>
-        <StorageNumber>0</StorageNumber>
-        <Unit>Unknown (VIF=0x7B)</Unit>
-        <Value>302</Value>
     </DataRecord>
...
     <DataRecord id="9">
         <Function>More records follow</Function>
+        <StorageNumber>0</StorageNumber>
+        <Unit></Unit>
+        <Quantity></Quantity>
         <Value></Value>
     </DataRecord>

I would suggest two actions from this.

Perhaps avoid checking in sen_pollutherm.norm.xml until this has been solved.
Implement some way that the error messages could say what file caused the problem. Either by setting the name of the
file as a global variable, or that this problem results in an exitcode of -1 in mbus_parse_hex.
Fix this particular VIF if it exists in the standard.


feat(font): add Hack-ZeroSlash

This PR adds the Hack-ZeroSlash to the repo.

Hi @huyenltnguyen, thanks for the PR!
I'm not sure if I should approve this due to the relative obscurity of this font with only 2 stars on GitHub. I'd be more willing to accept a PR from the official Hack font instead since it is the more popular option. Thoughts?

npm error 400 Bad Request - PUT https://registry.npmjs.org/@fontsource%2Fhack-zeroslash - That word is not allowed. Please contact support at https://npmjs.com/support if you believe you received this in error.

We may need to wait a little for this package to be published. I'll get NPM support to allowlist this package since it contains the word hack.

Hi @huyenltnguyen, it seems NPM cannot help with this one particular blocked word. They said that they'll maybe consider removing this word from the blocklist in the future, but it won't be changing now.
Do you have any alternative suggestions for the name, or do you believe we should revert this PR since it can be a little confusing to change the name of the package and breaks all consistency we have kept so far.
We can technically change the NPM package name through the id and still keep the same public facing name.


Incorrect selection change event kind when clicking on any text

Does this issue occur when all extensions are disabled?: Yes

Version: 1.63.2 (user setup)
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 6.1.7601
Steps to Reproduce:
Create an extension to log selection change events:
import * as vscode from 'vscode';

export function activate(context: vscode.ExtensionContext): void {
    context.subscriptions.push(
        vscode.window.onDidChangeTextEditorSelection(function(e) {
            console.log('Selection changed:', e.kind);
        })
    );
}

Click with the mouse in any position, and then click somewhere in another position. The selection change event that gets logged is of kind 3 (Command), but I would expect it to be of kind 2 (Mouse).
See screencast:

I'm not seeing this in latest Insiders, can you confirm if you can reproduce with all other extensions disabled?

I created a new extension, and only it is included.
I attach it here
test.zip
.

In version 1.65, added new bug e.kind may be undefined when toggle tabs with files.


Added support for 'ALTER TABLE CHANGE COLUMN'

Added support for 'ALTER TABLE CHANGE COLUMN oldName newName columnDefinition'.
Please see https://dev.mysql.com/doc/refman/8.0/en/alter-table.html for reference.
I was not really sure how to modify the AlterStatement class. I found introducing these two new fields was the easiest solution, but I am open to suggestions should there be a better way of doing it.
Also, this is my first time writing anything in JavaCC, so if I've made some obvious mistakes or bad practises, I would gladly take feedback.
This should fix #380 and parts of #571

Could you write tests using assertSqlCanBeParsedAndDeparsed as well. The deparser should be able to completely reconstruct the source SQL.

Oh, yes, sorry. I had them as test earlier but apparently managed to remove them along the way. I added the requested tests back in.

The reduction on coverage or the coverage value itself seems to be some kind of black magic to me as well. Sometimes the increase or decrease has no clear source.


E-M should support caching H3 support

we don't have a knob for saving the alternate service protocols cache in the k-v store

cc @RyanTheOptimist @abeyad


Initial beta of the User Brushes feature.

This is the initial v0.1 of the User Brushes feature.
Documentation can be found in Docs/UserBrushes.md .
Currently unimplemented features:

Saving brushes to local Brushes library.
Overriding brush audio.

awesome! This ends the part where I can be helpful, but at least everything built and it caught something :-)

Is there any value in merging this or should we close it and wait to finish the work on the UI in https://github.com/IxxyXR/open-brush/tree/features/brush-editing ?

Would it at least lay the groundwork to allow the more experimental users to get creating and sharing, could even be making brushes for the users who don't want to get into the weeds on the command line or experimental UI branch yet? If so I think it may be useful to add that base support in.

Would it at least lay the groundwork to allow the more experimental users to get creating and sharing, could even be making brushes for the users who don't want to get into the weeds on the command line or experimental UI branch yet?

But the same argument works for the branch with the UI.
Maybe we merge that but hide the UI behind a flag? Tim's functionality is all there.

Maybe we merge that but hide the UI behind a flag? Tim's functionality is all there.

Labs panel to access perhaps? May as well use it if we have it!

Closing this in favour of https://docs.openbrush.app/alternate-and-experimental-builds/experimental-builds/brush-editing
Although that still needs a lot of work, I think we need to release user brushes with some kind of in-app UI.
Feel free to reopen if you disagree.


Store split manifest metadata within bundle file footer

With the introduction of bundle files, storing a split manifest as a separate JSON file within a bundle makes little sense. Instead, the bundle footer seems like a natural candidate for hosting a split's metadata (serialized protobuf?).

Manifest seems to be used only when removing the files currently, and that doesn't make sense anymore with a single file bundle.
So there would be no usage left, which would make it odd to carry it in the footer all the time.
Conceptually we could allow to add files to the bundle footer, so that we could put small files there and read them all in a single read.

The main idea behind the manifest was to be able to completely recover a metastore from the raw data on object storage (except for split state). This also allows batch jobs performed with compute engines such as Presto or Spark to process splits (merge, delete) with fewer accesses to the metastore. Those are very desirable capabilities.

There is a dependency conflict currently. To open a BundleStorage we use the offset information stored in the metastore, to know where the footer is located.
Generally this is also possible without that information, but we would need to extend the storage api to return files sizes. This would require then 2 storage calls, one to get the footer size (last 8bytes) and one to get the the footer itself.

I think @guilload would like to make sure we can extra the information from the split file without querying the metastore, provided we have access to the entire file.
I think you  already append a footer length to the bundle file. Can we make sure we have the API to open and read the bundle?

@PSeitz can you check that we have an api for that?

With https://github.com/quickwit-inc/quickwit/issues/625 and https://github.com/quickwit-inc/quickwit/pull/570, getting stats and extraction of a split is possible without the metastore

I'm going to reopen the issue because inspect split and extract split only partially solve the issue. Metadata such as the number of docs in the split, tags, time ranges are still missing.


[Performance]: Results from the vLLM Blog article "How Speculative Decoding Boosts vLLM Performance by up to 2.8x" are unreproducible

Proposal to improve performance
No response
Report of performance regression
We attempted to reproduce the results from the vLLM Blog article "How Speculative Decoding Boosts vLLM Performance by up to 2.8x". However, we were unable to achieve the performance levels reported in the article. The experimental setup we used is detailed below:

vLLM version: 0.6.3
Device: 4 x H100 PCIe
Target Model: meta-llama/Meta-Llama-3-70B-Instruct with TP=4
Draft Model: turboderp/Qwama-0.5B-Instruct with TP=1
Dataset: anon8231489123/ShareGPT_Vicuna_unfiltered
QPS: 1
Num Speculative Tokens: 4

Since the article did not specify the maximum batch size, we experimented with various batch sizes to align with the conditions implied in the blog. The results are summarized in the table below:

NUM_REQUESTS
BATCH_SIZE
latency
output_token_throughput
total_token_throughput
sequence_throughput
p99_ttft_ms
mean_tpot_ms
mean_e2e_ms

32
1
379.36
16.39
42.82
0.08
342058.66
59.24
192514.28

32
1
269.17
23.1
60.35
0.12
231910.81
48.47
132276.49

128
4
466.57
55.38
133.21
0.27
301887.07
68.16
158126.15

128
4
448.78
57.58
138.49
0.28
289373.59
71.17
151403.83

128
8
306.15
84.4
203.01
0.41
142675.01
85.46
80552.87

128
8
301.58
85.68
206.09
0.42
149036.84
94.52
83421.69

128
16
209.41
123.39
296.79
0.6
44303.73
103.11
37825.59

128
16
198.52
130.16
313.07
0.63
38716.87
107.46
33761.1

512
256
554.79
182.35
398.75
0.9
1598.33
127.45
25150.41

512
256
541.01
187
408.91
0.92
1659.16
117.04
20934.63

While our results generally indicate improved performance using speculative decoding for the ShareGPT dataset, we observed a maximum speedup of 1.4x with a batch size of 1. In contrast, the end-to-end (E2E) latency was significantly different. Even at a maximum batch size of 256, the average E2E latency exceeded 20 seconds, whereas the article reported an average of only 1–2 seconds.
Therefore, we kindly request that the vLLM team provide more detailed information regarding the experimental setup described in the blog, including specifics on the maximum batch size, input and output lengths of the dataset, number of requests, and CPU configuration. This information would greatly enhance the reliability of vLLM performance results and offer valuable insights to other users.
Thank you for your assistance.
Misc discussion on performance
No response
Your current environment (if you think it is necessary)
vLLM version: 0.6.3
PyTorch version: 2.4.0+cu121
OS: Ubuntu 20.04.6 LTS (x86_64)
Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] nvidia-cublas-cu12==<IP_ADDRESS>
[pip3] nvidia-cuda-cupti-cu12==12.1.105
[pip3] nvidia-cuda-nvrtc-cu12==12.1.105
[pip3] nvidia-cuda-runtime-cu12==12.1.105
[pip3] nvidia-cudnn-cu12==<IP_ADDRESS>
[pip3] nvidia-cufft-cu12==<IP_ADDRESS>
[pip3] nvidia-curand-cu12==<IP_ADDRESS>
[pip3] nvidia-cusolver-cu12==<IP_ADDRESS>
[pip3] nvidia-cusparse-cu12==<IP_ADDRESS>
[pip3] nvidia-ml-py==12.560.30
[pip3] nvidia-nccl-cu12==2.20.5
[pip3] nvidia-nvjitlink-cu12==12.6.77
[pip3] nvidia-nvtx-cu12==12.1.105
[pip3] pyzmq==26.2.0
[pip3] torch==2.4.0
[pip3] torchvision==0.19.0
[pip3] transformers==4.46.2
[pip3] triton==3.0.0
[conda] numpy                     1.26.4                   pypi_0    pypi
[conda] nvidia-cublas-cu12        <IP_ADDRESS>                 pypi_0    pypi
[conda] nvidia-cuda-cupti-cu12    12.1.105                 pypi_0    pypi
[conda] nvidia-cuda-nvrtc-cu12    12.1.105                 pypi_0    pypi
[conda] nvidia-cuda-runtime-cu12  12.1.105                 pypi_0    pypi
[conda] nvidia-cudnn-cu12         <IP_ADDRESS>                 pypi_0    pypi
[conda] nvidia-cufft-cu12         <IP_ADDRESS>                pypi_0    pypi
[conda] nvidia-curand-cu12        <IP_ADDRESS>               pypi_0    pypi
[conda] nvidia-cusolver-cu12      <IP_ADDRESS>               pypi_0    pypi
[conda] nvidia-cusparse-cu12      <IP_ADDRESS>               pypi_0    pypi
[conda] nvidia-ml-py              12.560.30                pypi_0    pypi
[conda] nvidia-nccl-cu12          2.20.5                   pypi_0    pypi
[conda] nvidia-nvjitlink-cu12     12.6.77                  pypi_0    pypi
[conda] nvidia-nvtx-cu12          12.1.105                 pypi_0    pypi
[conda] pyzmq                     26.2.0                   pypi_0    pypi
[conda] torch                     2.4.0                    pypi_0    pypi
[conda] torchvision               0.19.0                   pypi_0    pypi
[conda] transformers              4.46.2                   pypi_0    pypi
[conda] triton                    3.0.0                    pypi_0    pypi
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

@LiuXiaoxuanPKU could you help with this?


Add verify pipeline

Description
Add a verify pipeline so we get automated tests on each PR
The second commit fixes all the style issues that chefstyle caught.
Related Issue
N/A
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] All commits have been signed-off for the Developer Certificate of Origin.

Some conflicts to get resolved but this looks solid. Thanks!


cmd/go: go help environment doesn't include GOGC

What version of Go are you using (go version)?

$ go version
go version go1.20.3 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/Will/Library/Caches/go-build"
GOENV="/Users/Will/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/Will/Library/Application Support/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/Will/Library/Application Support/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.20.3/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.20.3/libexec/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.20.3"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="cc"
CXX="c++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/bx/qk0phsxd265fqj512dnnpg080000gn/T/go-build2450415031=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
go help environment
What did you expect to see?
Explanation of GOGC, or a reference to where to get more info about it.
What did you see instead?
No mention of GOGC.

go help environment is for the config of the go tool, not running programs compiled from go, which is what GOGC is.


Customize models

I'm trying to customize django-plans models so that I can add support for vouchers through a dedicated Voucher model. But I don't want to include these into your project repo since it's too particular to this project in question.
More precisely, I'm trying to customize the behavior of the Order.total method, so that it can take into account associated vouchers through a foreign key.
To do that I've an idea on how to change current models layout that won't introduce backward compatibilities, like using abstract models for instance.
For example it would look like this :
plans/abstract_models.py
from django.db import models

class AbstractOrder(models.Model):
    STATUS=Enumeration([
        (1, 'NEW', pgettext_lazy(u'Order status', u'new')),
    ...

    class Meta:
        abstract = True

plans/models.py
from abstract_models import AbstractOrder

class Order(AbstractOrder):
    pass

And then simply replace all references to the Order model by
from django.db.models import get_model

Order = get_model('plans', 'order')

Then in my own project, if I create an app plans in my django project I will be able to override the Order model and the original plans app would reference the so called customized model.
myproject/apps/plans/models.py
from plans.abstract_models import AbstractOrder

class Order(AbstractOrder):
    discount_amount = models.DecimalField(_('discount amount'), max_digits=7, decimal_places=2)

    def total(self):
        amount = self.amount - self.discount_amount
        if self.tax is not None:
            return (amount * (self.tax + 100) / 100).quantize(Decimal('1.00'))
        else:
            return amount

Or maybe you have another way ?

@dulacp Making it more flexible in this sense is good idea.
Although I like this one too

What would you say if we could just add as many as needed signal hooks that would enable to do some extra logic for total() method like order_pre_total_calculation and order_post_total_calculation signals? Additional data for an order could be still kept in OneToOne models like OrderDiscount.

@dulacp where did you get with this implementation in your app since this pull request didn't get merged ?

@Alir3z4, I ended up rewriting a custom solution from scratch, which was better for billing because we had a very special business need.
I'm closing this one, since it's been 4 years ^^

@dulacp Yeah, thanks for the update.


Minor fixes

Description

Minor change into the codebase to use predefined string constant. Fix for build with Maven 3.9+ by removing of the duplicate version properties in the sample deployment project.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] Feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change
[ ] Chore (non-breaking change which doesn't affect codebase;
test, version modification, documentation, etc.)

Checklist

[x] Code contributed by me aligns with current project license: Apache 2.0
[x] Pull Request contains a description of the changes
[x] Pull Request does not include fixes for multiple issues/topics
[x] Code is self-descriptive and/or documented
[ ] I have implemented unit tests to cover my changes
[ ] I tested my code in OpenShift

/ok-to-test

Thanks @jstourac - changes LGTM, merging!


Links from Javadoc search feature are always broken

As of Java 10, documentation generated by Javadoc has a built-in search feature, which is really exciting. In our case, though, it's always producing broken links. Here's one example:
http://relayrides.github.io/pushy/apidocs/0.13/undefined/com/turo/pushy/apns/ApnsClient.html

Notice that undefined has managed to sneak in between 0.13 and com.
The correct link is:
http://relayrides.github.io/pushy/apidocs/0.13/com/turo/pushy/apns/ApnsClient.html

I've published a fresh copy of the docs with an un-hosed search function. Sorry for the trouble, folks.


Check if DisplayConfig is null to avoid NullReferenceException

In some cases the DisplayConfig variable can be null, resulting to a crash of the HMD.

Thanks!


Implementing the oauth2-tdameritrade Library in CodeIgniter 3

Hello,
I attempted to include the LupeCode/oauth2-tdameritrade library into my CI3 Infrastructure in order for my users to access their TD Ameritrade Accounts and Transactions (not to place orders or trades via my platform), and I'm currently getting the following error:
Message: Class 'LupeCode\OAuth2\Client\Provider\TDAmeritrade' not found
I have completed the following steps so far:

Installed via Composer
Copied the code exactly how you have posted

And I currently receiving the error listed above.
If there any additional assistance that you may be able to provide in order to resolve this issue so I can move forward with integrating the code into my infrastructure?

I noticed that the readme had the wrong composer command. I thought I had updated it when I forked the base library from PHP League. I have corrected that now.
composer require lupecode/oauth2-tdameritrade

That should work for you.


Consolidate app config

PR Overview

This PR improves the app config:

the config now exports the env environment for other components to reference.
Note that I didn't pull src/lib/split-config.js into src/config.js as I'm unsure if there's any further split-specific code that needs to go in there. If not, it's a good candidate to consolidate into the main config.js.

[minor] Removed the activeClassName from a few  elements.  elements cannot have such an attribute.

Status
Should be ready for review, but I'm doing one more pass as I have a nagging feeling I missed out on a few env-reliant code that could be consolidated.

PR Update

The project-links file has now also been consolidated into the app config.

Status

Ready for review.

This PR looks good and appears to clean up the code a good bit. I'm seeing the error below, but it also appears with how the app was set up beforehand. I'm going to merge this PR as is and open an issue with the error statement below to revisit later in an attempt to improve app performance.


Fix address for Long Beach Farmers Market

The address on this location includes a tip for finding the market…
https://foodoasis.la/farmers-market/long-beach-downtown-cfm/
Let‘s move that information to the description area, after the data. Here‘s an example…
https://github.com/foodoasisla/site/blob/master/_locations/everytable-downtown-la.md
You can edit the Long Beach Farmers Market page here…
https://github.com/foodoasisla/site/blob/master/_farmers-market/long-beach-downtown-cfm.md

Here you go
https://github.com/foodoasisla/site/commit/1b5b7183f4727a137c83c1bb9ceb006bafc8ae19

Nice, Tamura! 💯
That update is live…
https://foodoasis.la/farmers-market/long-beach-downtown-cfm/


Can not use for CN.

Hi Mate,
I am glad to find this project.
In China, the Audi platform is different for EU, USA, CA.
I found the API information as follows:
const AUDI_SERVER_API = {
login: 'https://audi2c.faw-vw.com/capi/v1/user/login',
token: 'https://mbboauth-1d.prd.cn.vwg-connect.cn/mbbcoauth/mobile/oauth2/v1/token',
mine: 'https://audi2c.faw-vw.com/capi/v1/user/mine',
mal1aVehiclesStatus: vin => https://mal-1a.prd.cn.vwg-connect.cn/api/bs/vsr/v1/vehicles/${vin}/status,
mal1aVehiclesPosition: vin => https://mal-1a.prd.cn.vwg-connect.cn/api/bs/cf/v1/vehicles/${vin}/position,
mal3aVehiclesStatus: vin => https://mal-3a.prd.cn.dp.vwg-connect.cn/api/bs/vsr/v1/vehicles/${vin}/status,
mal3aVehiclesPosition: vin => https://mal-3a.prd.cn.dp.vwg-connect.cn/api/bs/cf/v1/vehicles/${vin}/position,
vehicleServer: (appKey, nonce, sign, signt) => https://audioneapp.faw-vw.com:443/v2/audi-vehicle-server/public/vehicleServer/queryDefaultVehicleDetails?appkey=${appKey}&nonce=${nonce}&sign=${sign}&signt=${signt}
}
Is this can add to the audi_services.py to support CN users?
Thanks again for your porject.

Wanted to confirm if this is added you can test?


[Feature Request] Spectrum Display

Hi,
Can a tab be added to the app to display a spectrum?
Below is a proof of principal I hacked together and plotted out.  Its nothing more than a sweep in 1 MHz increments.  I believe this will be a useful, light weight way for quickly checking channels and any VTx overlap.
Cheers
Jye
void loop() {

  for (int i=5650; i <= 5950; i++){
    frequency = setModuleFrequency(i);
    rssi = getFilteredRSSI();
    Serial.print(frequency);
    Serial.print("\t");
    Serial.print(rssi);
    Serial.println("");
  }

  while(1) { }

}

Hi,
It would be also pretty nice to make this plot for every receiver. It maybe would help to spot differences between the receiver, and thereby spot which rx is best for which channel.
best regards
Florian


storing username in database

why
we want the ability to specify the user name on signup.
Issue
#40
changes done

Added optional input username field on signup page
Storing username in the database if the username is provided

testing
npm run serve
verification of fix:

Nice job! Thank you. Few comments:
We need also to specify username in user route (GeekScore-2/routes/api/users.js) and Monguse model (GeekScore-2/models/user.js) in order to store it on database.
I understand possible confusion cause so far it's two databases (firebase and mongo). It's temporary solution before migration to own authentication service


fix: [M3-7565] - Fix Radio size prop not affecting the radio button's dimensions

Description 📝
We realized this issue while working on the Radio storybook: changing the size prop of the radio did not actually affect the radio's appearance.
I noticed the size of the radio buttons was always 25px - which was coming from the width and height set in radio.svg and radioRadioed.svg. The font-size being set had no effect on the radio's dimensions.
Changes  🔄

Passed height and width to RadioIconRadioed and RadioIcon based on the size prop's value
Updated expected sizes in pixels per @gitkcosby's suggestion - 16px for small and 20px for medium.

Target release date 🗓
NA
Preview 📷
How to test 🧪
Reproduction steps

Set the size prop to "small" and then "medium" of any radio button. Inspect on the browser - you should see 25px for both cases

Verification steps

Pull the PR, Set the size prop to "small" and then "medium" of any radio button. Inspect on the browser. Small radios should have a width of 16px and medium 20px.
NOTE: It's possible that updating the medium radio size to 20px could cause alignment issues on pages where radios are used. We'll need to test this

As an Author I have considered 🤔
Check all that apply

[ ] 👀 Doing a self review
[ ] ❔ Our contribution guidelines
[ ] 🤏 Splitting feature into small PRs
[x] ➕ Adding a changeset
[ ] 🧪 Providing/Improving test coverage
[ ] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[ ] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿  Providing accessibility support

The ticket mentions removing the hardcoded size from the theme file and fixing any regressions... are we still planning to do that? (cc @coliu-akamai)

I agree with @hkhalil-akamai we need to remove this: https://github.com/linode/manager/blob/develop/packages/ui/src/foundations/themes/light.ts#L1152-L1158 ultimately, but that will require some additional QA work in places we use icons


Disabling keyboard suggestions on Android

I noticed that when the keyboard suggestion shows up, the entire screen jitters for about 100ms. Is there any way to disable keyboard suggestions?

I temporarily disabled keyboard suggestions from my device to see if they were the only peoblem to the jitterish app behaviors. It turns out there are problems with transitions and scrolls as well. Please check out the following two videos:
Running on iOS: http://youtu.be/dxfhS0C6hpo3
Running on Android: https://youtu.be/u0ebeev2fcE3
Do you have any insight for me?

@woniesong92 hey In android keyboard is pushing the view up by default or you have done any changes to make it work? Can you help here #307


script to clean images in a folder (varona project)

Dirty code, but because the script is so small. Iterate over all images in a folder and save desired ones with "s" key

Changes done!

LGTM!

@betegon , when you are ok with a pull request, remember to give your approval for the merge


Binding identifier should care about await/yield context

Bug Report

🔎 Search Terms
parsing, await, yield

🕗 Version & Regression Information

This changed between versions 3.9.7 and now

⏯ Playground Link

Playground
💻 Code

async function foo () {
  var await = 1; // should be an error, but not
}

async function bar () {
  let await = 2; // error
}

function * foo1() {
  var yield = 1; // should be an error, but not
}

function * bar1() {
  let yield = 2; // error
}

🙁 Actual behavior
BindingIdentifier in await/yield with var keyword does not throw errors.

🙂 Expected behavior
It should.

Related:

https://github.com/microsoft/TypeScript/pull/43370#issuecomment-855389589
https://github.com/microsoft/TypeScript/pull/39216 (/cc: @rbuckton )

The problem is that let await errors are issued in the parser and var await errors are issued in the binder. Syntax errors block reporting of semantic errors.
The parse errors for let await are horrible, so the right fix is to allow it in the parser and issue the same grammar error as for var await in the binder.
Note that this will make the error disappear in plain JS files for now. I hope to fix that soon.

Note that this will make the error disappear in plain JS files for now. I hope to fix that soon.

Sorry, I'm not 100% sure what your means. Does plain JS files means js files we emitted?

Sorry, it's a new term. 'plain JS file' means a JS file that is part of a compilation, but is not reporting semantic errors. That is, checkJS is not turned on OR explicitly off, and the file doesn't have // @ts-check or // @ts-no-check in it. Plain JS files report syntax errors but not semantic errors, so moving a parser error to a grammar error makes it disappear. However, I'm planning to turn on grammar errors for plain JS files in the next release.


GNSS doesn't work with LilyGO TTGO T-Beam

Hi, I'm trying to port LilyGO TTGO T-Beam to zephyr. I'm using the 3.7.0 release and the process is almost done. But the GPS module, a NEO-6m, isn't working with the gnss sample. My steps until now are:
First, I configured the UART pins to be coincident with T-Beam pinout, with RX on GPIO34 and TX on GPIO12, on pinctrl.dtsi:
uart1_default: uart1_default {
		group1 {
			pinmux = <UART0_TX_GPIO12>;
			output-high;
		};
		group2 {
			pinmux = <UART0_RX_GPIO34>;
			bias-pull-up;
		};
	};

Second, I seted UART on dts, defining NEO-6m like a generic module:
&uart1 {
	status = "okay";
	current-speed = <9600>;
	pinctrl-0 = <&uart1_default>;
	pinctrl-names = "default";
	gnssdev: gnss-nmea-generic {
    	    	compatible = "gnss-nmea-generic";
	};
};

And, of course, included gnssdev in aliases:
aliases {
		led0 = &led_io4;
		uart-0 = &uart0;
		i2c-0 = &i2c0;
		watchdog0 = &wdt0;
		lora0 = &lora0;
		gnss = &gnssdev;
		sw0 = &button_io38;
	};

The main.c code and prj.conf are the same of the sample. It builds and runs with no problems, but it doesn't return any data from GPS.
I know it isn't a hardware problem, because I have a functional arduino code.
Maybe i configured it wrong, or NEO-6m isn't compatible with gnss driver, but i don't know  how to check this.
How to proceed?

Why are you using UART0_... in the pinctrl definition? Looks like this is where your problem might be :)

Also, you need to set the status of your GNSS node and UART node to "okay" :) status = "okay";

Also, you need to set the status of your GNSS node and UART node to "okay" :) status = "okay";

Doesn't status default to okay? 🤔 I agree it can be helpful to be explicit but in this case I don't think it's strictly needed?

It seems the macros with STATUS_OKAY do treat missing status as okay :) I just looked at the base.yaml binding :) maybe we should set the default there?

It seems the macros with STATUS_OKAY do treat missing status as okay :) I just looked at the base.yaml binding :) maybe we should set the default there?

DT spec says that it's perfectly fine to omit the property altogether, in which case it's treated as if the node is status="okay". Maybe setting a default would make sense (and would have the merit of making all the statuses explicitly show up in the generated zephyr.dts?), but this doesn't change the fact that the "treat missing as okay" behaviour always applies, even for bindings that doesn't extend base.yaml

Depending on which version of T-Beam you have, there is also a power management chip (AXP192 or AXP2101) that you need to instruct to switch on the power supply to the GPS (also LoRa if you're using that).
Zephyr appears to have a driver for the AXP192 (drivers/regulator/regulator_axp192.c), but not the AXP2101.

Hi guys, thanks for responses.
@kartben

Why are you using UART0_... in the pinctrl definition? Looks like this is where your problem might be and you should replace with UART1_... :)

It's my fault, I've tried various combinations, and ended with UART0. But, you are correct. Now, pinctrl.dtsi looks like:
uart1_default: uart1_default {
		group1 {
			pinmux = <UART1_TX_GPIO12>;
			output-high;
		};
		group2 {
			pinmux = <UART1_RX_GPIO34>;
			bias-pull-up;
		};
	};

@bjarki-andreasen

Also, you need to set the status of your GNSS node and UART node to "okay" :) status = "okay";

I've added your suggestion and dts looks like:

&uart1 {
	status = "okay";
	current-speed = <9600>;
	pinctrl-0 = <&uart1_default>;
	pinctrl-names = "default";
	gnssdev: gnss-nmea-generic {
		status = "okay";
    	    	compatible = "gnss-nmea-generic";
	};
};

But i have the same results, compiles, run and no data.
@ASerbinski

Depending on which version of T-Beam you have, there is also a power management chip (AXP192 or AXP2101) that you need to instruct to switch on the power supply to the GPS (also LoRa if you're using that).
Zephyr appears to have a driver for the AXP192 (drivers/regulator/regulator_axp192.c), but not the AXP2101.

I'm using T-Beam v1.1, and it uses the AXP192. At first, i thinked AXP192 doesn't  make difference because the arduino code dosen't manipulate anything from AXP192.  And GPS LED (see the schematic image) is blinking with the zephyr code runs.

But, after searching a lot i found in the lilygo website, a QRcode to a AXP192 configuration (yes, lilygo dosen't help with clear documentation). And, now, I have a north to follow and configure AXP192. I will try this tomorrow and bring news.
Again, thanks for the help @kartben, @bjarki-andreasen and @ASerbinski .

Great catch, @ASerbinski regarding the AXP192
@jagra26 check out how the couple of M5Stack boards in boards/M5Stack configure it, it shouldn't be too hard :) You might need to tweak init level to make sure AXP192 driver kicks in before GNSS driver
Btw, converting this to a discussion as there is a very good chance that there is no bug :)


symlink

It would be awesome if this script would creat a system link.
So you would not have to search for the script

You mean an alias? If so, I appreciate the idea but it is unnecessarily intrusive and most users wouldn't use it.


Date picker enhancement to accept any format

Submission reviewed by MoAB Aug 15. https://app.clickup.com/t/86858ewpx
More information needed.

Overall suggestion is to revisit date picker for better Figma component controls as well as matching web functionality with Figma component functionality.

@msankaran0712 to check if this is a bug.

It is a enhancement and not a bug

Maha to transfer the issue to web cpomponents

Closing the issue as nothing to do in Figma and web components has a separate issue https://github.com/trimble-oss/modus-web-components/issues/1709
cc
@soniakaukonen


Emoji Cheatsheet not working with facebook on Firefox 43.0.3

emoticons are not working on facebook at all when you wanna add them to a post, they are okay with comments but not when you type or add a description to a shared a post

It is the same, here, on Github:
Emoji from https://fr.piliapp.com/facebook-symbols/ : ⤵
Emoji from Firefox Addon : ⤵ (but works on Twitter)
I guess it is coded differently...


Bug: Alphabetical sorting does not happen on lowercased version of the string

See

Thanks, good point!


Increase visual contrast between admin_level=4 and admin_level=2 boundaries

Style change requested
Currently, it can be difficult (for my old eyes) to quickly distinguish between countries (admin_level=2) and states (admin_level=4). See this example here of the Confederate States:
browser z=4 - some contrast, but could be clearer:

browser z=6 - whoa... almost completely lost:

Please don't spend a ton of time on this, per our discussion at our carto meeting, and pending #701

from call
https://www.openhistoricalmap.org/#map=6/49.139/13.821&layers=O&date=1851-01-03&daterange=1800-01-01,2023-12-31

Review Schweiz as an example. Disappearing in terrain a lil bit

using centroids points can consider also label hierarchy and changing things maybe based on area or somethin gsomething . Area has been generated for centroids data

Initial iteration comparisons in adjustments - I will tweak a little more. old country lines / labels:

new:

Upping the contrast in color, width, darkness, saturation combos is tricky as in water areas, the boundaries become severely contrasted. So, it will help a lot when we no longer have maritime boundaries.
Actually now that I thought about this, perhaps it is best to pause the iterating here until maritime boundaries can be removed.

Whoa! My apologies - not sure how I missed this.
I like the new approach, but I'm wondering if we could de-emphasize the 2nd level boundaries (or maybe, both) even further. This map I came across for another purpose has a very stark contrast that I thought was interesting:

And, also agree that we may want to wait to combine with the removal of the maritime boundaries.

The above map looks to be intentionally emphasizing the symbology points and city labels
Good point - I was so focused on the nice contrast between country and state boundaries I didn't think about that a lot. I also think I was ignoring the red clusters, because we obviously don't have those.

My question: Would OHM users want them to be de-emphasized a lot?
My response: what do you :) want the map to look like at this zoom level? What would you be psyched to show off?

My take?

Clearer country borders
More subdued state borders and labels
Crisp major cities representing top 20ish MSAs

demo style

Adjusted country and state boundary colors
Adjusted country and state boundary widths --> the width is especially supporting differentiation
Adjusted state name color to better aesthetically match new state boundary color
Don't have state boundaries or names coming in until z5, helps to reduce visual "clutter"

meeting notes
bring state boundaries in at 5 rather than 6

Spain: increase visual contrast for states, at mid-level z


Design and Final Planning

Just talked with our contacts over at Erwin Penland, they anticipate having a design to us next week (8/18). I think if we can get that design integrated in to the front end prior to a meetup on 8/25, we could do some QA final tweaking and potentially be ready to submit to the app store for a planned mid-Sept launch.
Thoughts?

It sounds like the design is for the iOS app?  I'd like to take a look as well for anything to possibly incorporate into the web app.

Yes, both iOS and Webapp, with a consistent styling on the Marketing page.
On Tue, Aug 11, 2015 at 10:26 AM, John Mark Smotherman <
<EMAIL_ADDRESS>wrote:

It sounds like the design is for the iOS app? I'd like to take a look as
well for anything to possibly incorporate into the web app.
—
Reply to this email directly or view it on GitHub
https://github.com/codeforgreenville/trolley-tracker/issues/47#issuecomment-129903566
.

@Linktheoriginal Where do we want to host the web app post-launch? Is that going to be on the Azure server or should we move? Just want to make sure we are ready. You've probably thought about it I may have just missed it.

I'm planning on supporting what I have right now on webfactional - we've discussed moving it, and what would be involved there, but I think that decision needs to wait depending on the amount of load we see.  Also, to my knowledge, the current production is walling info systems, not the azure servers (depending on what you mean).

Thanks for the insight. I meant walling server. Maybe a we could run
loader.io against it to see what happens, not sure if we would be able to
pass location data though to it to simulate.
On Aug 21, 2015 4:48 AM, "John Mark Smotherman"<EMAIL_ADDRESS>wrote:

I'm planning on supporting what I have right now on webfactional - we've
discussed moving it, and what would be involved there, but I think that
decision needs to wait depending on the amount of load we see. Also, to my
knowledge, the current production is walling info systems, not the azure
servers (depending on what you mean).
—
Reply to this email directly or view it on GitHub
https://github.com/codeforgreenville/trolley-tracker/issues/47#issuecomment-133334353
.

If we have one of our domains that we can give to Greenlink to post as a QR code decal on signs, that domain could redirect to webfactional.   It could stay there or change later if we wish.

EP design comps https://drive.google.com/drive/folders/0B1Wxj_5D6dLNfnFEeXo3a3pFVl9VVmxmWWpaNElCaXJrUXhxNi0ycVdOb3Y2SzRrWExFRTA


How to securely store sessions

I'm building a service which uses multiple instagram accounts, the current behavior is :

the user give it's insta credentials
the server logs in with it and store the session unencrypted in Redis, the password is not saved
if a session become invalid, the password is asked to the user again

Is there a more secure way to do it ?
Essentially storing sessions is bad so I know it will never be perfect but I wondered if there was a way to mitigate the risk.

Had the same problem. I think encrypting it is the only solution for now.
Also, how long are sessions valid for?

No idea how long the sessions are valid for, and if there is a way to refresh it to extend this duration, I would love to know it too.
How would you encrypt it ? With a key stored in a .env ?
If so, if the storage used for sessions (Redis for me) is compromised, the .env would likely be compromised too, wouldn't it ?

@micodeyt as library accepts unencrypted login details this is not library related issue. You are able to get state, cookies, login and store it as you want, with any encryption you can imagine.
Feel free to tell us if this is library related thing and I misunderstood you.


Align Pathplanner and field centric swerve, round 2

Description
Revisit #38. After asking around, the correct way to do this is to invert the joysticks AND always run a pathplanner auto first before entering teleop (run practice mode). Pathplanner will automatically fix the heading for you which will make the joystick directions correct.
Note: When dying on the field and reconnecting, the heading will need to be reset by some other means.

Pathplanner has been implemented and is being used now.


Update to 0.5.0: upgrade grpcio-tools and protobuf

@greschd - you opened the PR, so you won't be able to review and approve it but can you review my changes whenever you get the chance?


Fix broken link about Starter Kits

As you know, there is Starter Kits in Documentation like below but it links to Page Not Found.

I think you probably intended to link to this page(below), but the exact same page no longer exists in React docs.

I found a page that gave a similar introduction, and changed the link to it : Recommended Toolchains

The page covers a lot including Neutrino, Parcel and Razzle, so I believe it will be a good alternative.
Closes #143

Perfect 👍 thanks


BUG: linprog integrality only accepts list, not array

Describe your issue.
linprog(integrality=None) is documented as integrality : 1-D array, optional but it only accepts listlike and not array due to a conditional in argument checking.
The code uses a plain truthiness check if integrality that works well with lists but not ndarrays:
if integrality and not meth == "highs":

This causes an exception ValueError: The truth value of ... when using linprog integrality with an array.
Reproducing Code Example
Borrowed and adapted from #11854 thanks :)
from scipy.optimize import linprog
import numpy as np

c = np.array([-29.0, -45.0, 0.0, 0.0])
A_ub = np.array([[1.0, -1.0, -3.0, 0.0],
                 [-2.0, 3.0, 7.0, -3.0]])
b_ub = np.array([[5.0],
                 [-10.0]])
A_eq = np.array([[2.0, 8.0, 1.0, 0.0],
                 [4.0, 4.0, 0.0, 1.0]])
b_eq = np.array([[60.0],
                 [60.0]])
bounds = [(0, None)]
result = linprog(c, A_ub=A_ub, b_ub=b_ub, A_eq=A_eq, b_eq=b_eq, bounds = bounds, integrality=np.ones_like(c))

Error message
~/.local/lib/python3.8/site-packages/scipy/optimize/_linprog.py in linprog(c, A_ub, b_ub, A_eq, b_eq, bounds, method, callback, options, x0, integrality)
    582         warn(warning_message, OptimizeWarning)
    583
--> 584     if integrality and not meth == "highs":
    585         integrality = None
    586         warning_message = ("Only `method='highs'` supports integer "

ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

SciPy/NumPy/Python version information
1.9.0rc2 1.22.4 sys.version_info(major=3, minor=8, micro=10, releaselevel='final', serial=0)

Thanks, I'll fix that today.


Integrated directly into wd

Hi,
Ive been working on getting this functionality into wd.
This issue is just an fyi: https://github.com/mfaerevaag/wd/pull/120/

Good to know, thanks for your contributions and credits 🙂


fix(environments-modal): increase the size of the environment modal

Closes #6939

While you're at it, can you also check #6943