Undeclared dependencies in runtime_dependencies

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Fixes https://github.com/Homebrew/brew/issues/2173.
I've just noticed #3785. That probably interplays with this change in some way, but I haven't had a chance to have a proper look at it yet.

This PR does not save the undeclared ones to the INSTALL_RECEIPT.json and so unsafe removal of opportunistically linked deps is still allowed.

This PR does not save the undeclared ones to the INSTALL_RECEIPT.json and so unsafe removal of opportunistically linked deps is still allowed.

Ah, I'd assumed Tab.create would pick them up, but it doesn't because the formula doesn't get linked into opt until after the tab is created. We can work around that by falling back to the formula's prefix if it isn't optlinked.

how is this not also a problem for Linux?

It is a problem on Linux, but we don't have a LinkageChecker there

brew linkage also doesn't work on Linux

Oh joy

I think there was a WIP implementation for Linuxbrew at some point, but not sure what happened to it.

brew linkage works on Linuxbrew.

@sjackman any chance of getting it upstreamed in the near future for this PR?

Done! I'm that good. (It works already too.) =p
$ brew linkage hello
System libraries:
  /lib/x86_64-linux-gnu/libc.so.6

@alyssais What's the latest here?

Oh, I see. os/mac/linkage_checker is used on Linux even though it's in os/mac? I'll update the PR accordingly.

@alyssais Also, have you determined what impact this has on brew deps? Note that https://github.com/Homebrew/brew/pull/3785 was merged.

Oh, I see. os/mac/linkage_checker is used on Linux even though it's in os/mac? I'll update the PR accordingly.

Hmm, how sketchy. I'll submit a PR to move linkage_checker to generic.

PR https://github.com/Homebrew/brew/pull/3852 moves linkage_checker.rb to generic.

Also, have you determined what impact this has on brew deps?

AFAICT brew deps doesn't call runtime_dependencies, so it should have no impact.

Note that #3785 was merged.

#3785 will stop indirect dependencies suddenly showing up as runtime dependencies, which would have happened otherwise, I think.

SystemStackError

yikes

This PR will be affected by https://github.com/Homebrew/brew/pull/3979 (which I think should probably go in first).

@alyssais What's the latest here? Thanks!

@ilovezfs Mind kicking this around a bit and seeing if it does what you expect/want before I merge? Thanks ❤

It seems to work.
iMac-TMP:freeciv joe$ diff before after
1c1
< {"homebrew_version":"1.6.2-14-g29f7d3d"
---
> {"homebrew_version":"1.6.2-29-g8035afc"
12c12
< "time":1524657205
---
> "time":1524657606
14c14
< "HEAD":"29f7d3d7ef5b2b939021ac247ef042228b8cc8a2"
---
> "HEAD":"8035afcc36ac45ebd127f670b13ab32414c310fa"
73c73,75
< "version":"2.24.32"}]
---
> "version":"2.24.32"}
> {"full_name":"xz"
> "version":"5.2.3"}]

for freeciv opportunistically linked to xz.
Do you want to bump any sort of INSTALL_RECEIPT version here since it changes the meaning/reliability of that data?

It seems to work.

🎉

Do you want to bump any sort of INSTALL_RECEIPT version here since it changes the meaning/reliability of that data?

I reckon we can leave it as-is because this is "value add" rather than "broken without".

Thanks @alyssais!

Thanks @alyssais and @MikeMcQuaid!

This PR broke upgrades when there are formulae with the same name in two different taps even if the formula dependency is fully qualified. https://github.com/Homebrew/brew/commit/8386e6a8c18f5dee30f17386cab652b653b1b860 is the breaking commit.
iMac-TMP:Homebrew joe$ git rev-parse @
27ec9dae5fa4c2c5b19f8bfafaefbdbb3e9a9c8c
iMac-TMP:Homebrew joe$ brew upgrade
==> Upgrading 2 outdated packages, with result:
pothosware/pothos/pothoscomms 0.2.2 -> 0.3.1, pothosware/pothos/pothosplotters 0.3.1 -> 0.4.1
Error: Formulae found in multiple taps:
       * dholm/sdr/spuce
       * pothosware/pothos/spuce

Please use the fully-qualified name e.g. dholm/sdr/spuce to refer the formula.
iMac-TMP:Homebrew joe$

with debug
==> Upgrading 2 outdated packages, with result:
pothosware/pothos/pothoscomms 0.2.2 -> 0.3.1, pothosware/pothos/pothosplotters 0.3.1 -> 0.4.1
Error: Formulae found in multiple taps:
       * dholm/sdr/spuce
       * pothosware/pothos/spuce

Please use the fully-qualified name e.g. dholm/sdr/spuce to refer the formula.
/usr/local/Homebrew/Library/Homebrew/formulary.rb:377:in `loader_for'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:280:in `factory'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1444:in `[]'
/usr/local/Homebrew/Library/Homebrew/linkage_checker.rb:141:in `block in check_undeclared_deps'
/usr/local/Homebrew/Library/Homebrew/linkage_checker.rb:139:in `reject'
/usr/local/Homebrew/Library/Homebrew/linkage_checker.rb:139:in `check_undeclared_deps'
/usr/local/Homebrew/Library/Homebrew/linkage_checker.rb:104:in `check_dylibs'
/usr/local/Homebrew/Library/Homebrew/linkage_checker.rb:19:in `initialize'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1530:in `new'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1530:in `undeclared_runtime_dependencies'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1511:in `runtime_dependencies'
/usr/local/Homebrew/Library/Homebrew/formula_installer.rb:424:in `runtime_requirements'
/usr/local/Homebrew/Library/Homebrew/formula_installer.rb:437:in `expand_requirements'
/usr/local/Homebrew/Library/Homebrew/formula_installer.rb:381:in `compute_dependencies'
/usr/local/Homebrew/Library/Homebrew/formula_installer.rb:136:in `verify_deps_exist'
/usr/local/Homebrew/Library/Homebrew/formula_installer.rb:129:in `prelude'
/usr/local/Homebrew/Library/Homebrew/cmd/upgrade.rb:139:in `upgrade_formula'
/usr/local/Homebrew/Library/Homebrew/cmd/upgrade.rb:95:in `block in upgrade'
/usr/local/Homebrew/Library/Homebrew/cmd/upgrade.rb:92:in `each'
/usr/local/Homebrew/Library/Homebrew/cmd/upgrade.rb:92:in `upgrade'
/usr/local/Homebrew/Library/Homebrew/brew.rb:101:in `<main>'


operator/ingress: Default GCP to LoadBalancer

Use LoadBalancerService as the default endpoint publishing strategy type on GCP.

operator/v1/types_ingress.go (IngressControllerSpec): Document that the default endpoint publishing strategy type on GCP is LoadBalancerService.
operator/v1/zz_generated.swagger_doc_generated.go: Regenerate.

/lgtm

cc @smarterclayton for approval

/hold

We're missing 4.1 branches, holding merges temporarily.

/hold cancel

@knobunc can you tag this one in?

/approve
/lgtm


Simulating arrow keys with shortcut without layers

I want alt+jikl to simulate arrow keys. I don't want to use a layer toggle for this, because that will make my alt key no longer function as alt which I use for other shortcuts on my system like alt+tab for window switching and many more. I also do not want to use two different keys or have tap vs hold behavior on alt.
Does KMonad provide a way to make shortcuts like alt+j trigger arbitrary key simulation like alt+j = left? keyd apparently provides this functionality but I'd prefer to only use kmonad.

No without layers this isn't possible, since combos (#157) are not implemented
What you could do instead is a layers.
Depending on what exactly you want there are different options:

If you want the alt key only pressed when you press other keys you would need a full layer with the around alt ...
If you want alt to be always pressed, you can have
(around alt (layer-toggle ...)) and the nextmlayerwcould be full of fallthrough except for the arrow part
If you want to release alt when pressing the arrow keys you can do the same but with an (tap-macro-release (release-only alt) lft (press-only alt)) though this results in wierd behavior when pressing multiple "arrow keys".
In the last two options you would have a layer full of _
you could with the next nelease use a named source block to only remap the jikl on your new layer and possibly make it more readable

Yes, it is. I don't think there is a better solution currently available to you than prefixxing every button with A- in a new layer.

This?
  toggle-alt-layer (around lalt (layer-toggle my-layer))

No this would be the second solution.
I was meaning something more like this:
(defsrc
  q w e r t y
  j i k l
  alt spc
)
(deflayer default
  q w e r t y
  j i k l
  (layer-toggle with-alt) spc
)
(deflayer with-alt
  A-q A-w A-e A-r A-t A-y
  left down up right A-spc
)

A bit verbose but the best solution currently possible

This?
  toggle-alt-layer (around lalt (layer-toggle my-layer))

No this would be the second solution.
I was meaning something more like this:
(defsrc
  q w e r t y
  j i k l
  alt spc
)
(deflayer default
  q w e r t y
  j i k l
  (layer-toggle with-alt) spc
)
(deflayer with-alt
  A-q A-w A-e A-r A-t A-y
  left down up right A-spc
)

A bit verbose but the best solution currently possible.

After having reread your question I think you would have a bit of difficulty with alt+tab.
Switching to the second or third last active window requires mulitple taps of tab while alt is being held.
This is probably possible with a hacky solution for switching, press-only and release-only


Refractor v1 vs. v2 endpoint unit tests in kserve/test/test_server.py

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes https://github.com/kserve/kserve/issues/3137
Type of changes
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

[ ] Test A

[ ] Test B

Logs

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

[x] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[x] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

To separate out the v1 and v2 endpoint unit tests in the provided test_server.py file, i make following changes to the original file:

Organize the Tests by Protocol Version:

Create two new test classes, one for v1 and one for v2.
Move the relevant test methods from the existing classes to these new classes.

Update the Test Names:

Ensure that the test method names clearly indicate whether they are for v1 or v2.

/assign @tessapham @alexagriffith


AssertionError: your model failed to follow instructions and make API calls. please try a better model or do some better prompt engineering

Using example:
AssertionError: your model failed to follow instructions and make API calls. please try a better model or do some better prompt
engineering

I have met the same problem

I have met the same problem, has anyone solved it?

有人解决这个问题嘛？

First try of the code base today, having the same problem.

How to solve this problem?


Add support for leading radio buttons

One line

Two lines

Three lines

Codecov Report
Patch and project coverage have no change.

Comparison is base (b9eab07) 93.50% compared to head (4279911) 93.50%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #18   +/-   ##
========================================
  Coverage    93.50%   93.50%
========================================
  Files            2        2
  Lines           77       77
  Branches        11       11
========================================
  Hits            72       72
  Misses           3        3
  Partials         2        2

Flag
Coverage Δ

unittests
93.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


add output_only option to Artifact base class

Add output_only flag to Artifact base class to allow power users to create their own artifact handler to save experimentation outputs in their format of choice.
Example use case:

save Plotly output as a PNG instead of a Plotly object. These outputs are not meant to be read back into Python in its original form.

Main file changes:

base.py: add output_only class attribute
experiment.py & project.py: Add warnings if artifact class is output only
conftest.py: dummy class for testing

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 98.71795% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.88%. Comparing base (129641f) to head (99e404b).
Report is 3 commits behind head on develop.

Files
Patch %
Lines

lazyscribe/experiment.py
85.71%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #55      +/-   ##
===========================================
+ Coverage    96.74%   96.88%   +0.13%
===========================================
  Files           19       20       +1
  Lines         1045     1123      +78
===========================================
+ Hits          1011     1088      +77
- Misses          34       35       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add jest. Expose rebuildSwiper instance method.

So the main thing I needed was a way to manually trigger a swiper rebuild. So I added an instance method called rebuildSwiper which will destroy and create swiper. I refactored two places that were doing this to call this single new method.
I need access to this because I'm finding the rebuildOnUpdate and shouldSwiperUpdate props to be a bit limited for my use case. I need to be able to change the slidesPerView only when a device orientation event happens. So the children are not changing, only that single prop.
While I was at it I figured it would be good to have a test and realized no test runner was set up so I did that too :)
Also btw whenever I've tried turning on rebuildOnUpdate, the component becomes very buggy. I've not explored it more but I know it's related to that rebuildOnUpdate prop. I feel like in the future we could expose more fine-grained control on when the swiper should update, so instead of passing true/false for the rebuildOnUpdate and shouldSwiperUpdate you could pass a function that accepted prev/next props and returns a boolean. Future PR maybe :)

I just realized I didn't commit the build files... I'm not sure if I should have or how you handle those?

Hi @timkindberg , thanks for your commit. Please also commit the build file too.

Ok done!

When will this change be released?


[Bug]: Blocking a person doesn't block their comments.

What happened?
I'm aware of blocking people via the "hide content from this user" and also by manually putting their name into my filters in my settings. However, it doesn't block any of their comments in discussions. This feels like a bug to me because typically if someone blocks someone, they don't want to see them at all.
Steps to reproduce the problem

Block any user.
Check a discussion thread in which they've posted.

What should have happened?
User should be blocked from my view sitewide, even in discussions and comments.
What platforms do you use to access the site?
Windows, Android
What browsers do you use to access the site?
Mozilla Firefox, Google Chrome, Microsoft Edge
Additional information, context and logs
Chrome on mobile, Firefox on my netbook, Edge on my desktop due to Firefox not working on my desktop for some reason (as in my bug report 485)

We actually don't support this right now, but it makes sense. We'll get this added

Ok, this has been added. It'll go out in the next release 👍


Difference between Ireland and United Kingdom

The map is currently considering Ireland as UK. Teach the map to separate them.

Duplicate. GitHub bug.


Fix multiple usability issues in the texture region editor

Fixes https://github.com/godotengine/godot/issues/75291. Fixes https://github.com/godotengine/godot/issues/80403 (a duplicate, actually). Fixes https://github.com/godotengine/godot/issues/75989 (at least, I can't reproduce it with the PR applied).
Changes include:

Correctly display atlas textures when they are used by other supported objects (like nodes or styleboxes). We used to draw everything through a CanvasTexture, but it can't handle custom drawing logic of textures that it holds, such as AtlasTexture. So I reworked it to avoid relying on the CanvasTexture.

Make region handles easier to interact with when editing NinePatchRect and StyleBoxTexture, which also have bars to adjust margins. We used to check handles last, which means bars would steal clicks. Since bars are normally long and can be clicked in plenty of places, and handles are small and located in precise positions, I switched it so handles are checked first.

While testing I've noticed that a few things weren't properly initialized or restored. To name a couple, the default snap mode from the editor settings wasn't correctly applied, and the panning offset wouldn't completely update when opening the dialog.

Various code quality changes. Moved all property initializations into the header. Removed unused methods, changed access modifiers of some remaining. Renamed everything. Extracted a few bits of logic into dedicated methods and unified how those are used. And other such changes.

Add a check to AtlasTexture::get_image() to avoid bliting with invalid size values. It spammed a lot in the editor when using the region editor otherwise.

Apparently, you can use Godot's nose to create a nice ninepatch:

Not sure if anything/what needs to be done about this.

I can revert some changes, because that's on me. I unified some of that logic that used to treat these as special cases (or rather other empty regions as special cases). I think, though, that it's more intuitive for an empty region to equal the whole image. At least it is more user friendly when opening the region editor, in my mind.
But I guess there is a different between an empty region and and empty region with a "use region" toggle. So I dunno. We can keep it as is and see if there are complaints after the change, I guess.

Thanks!

Help. please"
Is there a way I can dock the Region Editor?

I´m foloing a tutorial and its reali anoying that I can't dock the editor as it is in the video and I have to open and close it every time I change the timeline for each region edit.

@ramireshimself You cannot dock it, no. It used to be a contextual editor on the bottom panel, but this was changed in Godot 4.

Thanks for the awenser. So there is no simmilar way to do like before? I have to do it one by one, closing, keyfaming and opening again, and edit, etc, etc?

You can input the value in the inspector.

thnks, I´ll try.


Completed first task.

I have installed networkx on computer and created this PR to the main repository.

thanks!

@MridulS
I'm facing some issues while installing package - gdal, pygraphviz.
Can you help me with this ?

They are optional packages, not strictly required to work with networkx.


fix: add 10% buffer for vSphere disks

This PR is a bit of a hack, but it resolves the following issue encountered when migrating vSphere disks to PortWorx filesystem-type PVCs.
I0714 17:00:41.240629       1 data-processor.go:282] New phase: Resize
W0714 17:00:41.248185       1 data-processor.go:361] Available space less than requested size, resizing image to available space<PHONE_NUMBER>2.
I0714 17:00:41.248213       1 data-processor.go:369] Calculated new size is < than current size, not resizing: requested size<PHONE_NUMBER>2, virtual size:<PHONE_NUMBER>0.
I0714 17:00:41.248223       1 data-processor.go:288] Validating image
E0714 17:00:41.254396       1 data-processor.go:278] Virtual image size<PHONE_NUMBER>0 is larger than the reported available storage<PHONE_NUMBER>6. A larger PVC is required.
Unable to resize disk image to requested size
kubevirt.io/containerized-data-importer/pkg/importer.(*DataProcessor).initDefaultPhases.func7
    pkg/importer/data-processor.go:249
kubevirt.io/containerized-data-importer/pkg/importer.(*DataProcessor).ProcessDataWithPause
    pkg/importer/data-processor.go:275
kubevirt.io/containerized-data-importer/pkg/importer.(*DataProcessor).ProcessData
    pkg/importer/data-processor.go:184
main.handleImport
    cmd/cdi-importer/importer.go:174
main.main
    cmd/cdi-importer/importer.go:140
runtime.main
    GOROOT/src/runtime/proc.go:250
runtime.goexit
    GOROOT/src/runtime/asm_amd64.s:1571
E0714 17:00:41.254455       1 importer.go:177] Virtual image size<PHONE_NUMBER>0 is larger than the reported available storage<PHONE_NUMBER>6. A larger PVC is required.
Unable to resize disk image to requested size
kubevirt.io/containerized-data-importer/pkg/importer.(*DataProcessor).initDefaultPhases.func7
    pkg/importer/data-processor.go:249
kubevirt.io/containerized-data-importer/pkg/importer.(*DataProcessor).ProcessDataWithPause
    pkg/importer/data-processor.go:275
kubevirt.io/containerized-data-importer/pkg/importer.(*DataProcessor).ProcessData
    pkg/importer/data-processor.go:184
main.handleImport
    cmd/cdi-importer/importer.go:174
main.main
    cmd/cdi-importer/importer.go:140
runtime.main
    GOROOT/src/runtime/proc.go:250
runtime.goexit
    GOROOT/src/runtime/asm_amd64.s:1571

Thanks for the PR, the change itself is something we do ourselves where we don't use DataVolumes, but in this case (@ahadas please correct me if I'm wrong), the way to go would be to increase the filesystemOverhead[1] in CDI's config
[1] https://github.com/kubevirt/containerized-data-importer/blob/5eb46223f6192f83085bbfa858a149f017c14663/doc/cdi-config.md#options-1

Thanks for the PR, the change itself is something we do ourselves where we don't use DataVolumes, but in this case (@ahadas please correct me if I'm wrong), the way to go would be to increase the filesystemOverhead[1] in CDI's config

I see. Thanks @bennyz! I wasn't aware of that toggle in the CDI config. Will close the PR.

@TylerGillson can you please elaborate on why CDI is used in your migration?
in what we believe should be the common case of cold migration to the cluster that forklift runs on (i.e., local cluster) we don't use CDI for the data transfer.
in warm migrations and migrations to a different cluster than the one forklift runs on (i.e., remote cluster), CDI is still used for the data transfer - and they have not been upgraded to the latest version of virt-v2v.
the reason I'm asking is because we consider deprecating warm migrations from OpenStack, and change cold migrations to remote clusters to work like migrations to a local cluster - and if you're using one of these, we're interested in why you chose it rather than cold migration to the local cluster

@ahadas currently we are performing a cold migration from vSphere to a K8s cluster where Forklift is running. However, we are interested in exploring a use case whereby Forklift is installed in an ephemeral kind cluster and orchestrates the migration of VMs from vSphere to remote target K8s cluster(s).
But to be honest, I thought that using CDI was required. After re-reading the Forklift docs it is still not clear to me how to accomplish what you've described. What modifications would be required to the following example migration manifests to bypass CDI?
apiVersion: forklift.konveyor.io/v1beta1
kind: Migration
metadata:
  name: migration-99331-migration
  namespace: konveyor-forklift
spec:
  plan:
    name: migration-99331-mig-plan
    namespace: konveyor-forklift
---
apiVersion: forklift.konveyor.io/v1beta1
kind: Plan
metadata:
  name: migration-99331-mig-plan
  namespace: konveyor-forklift
spec:
  warm: false
  provider:
    source:
      name: migration-99331-vmware-provider
      namespace: konveyor-forklift
    destination:
      name: migration-99331-generick8s-provider
      namespace: konveyor-forklift
  map:
    network:
      name: migration-99331-network-map
      namespace: konveyor-forklift
    storage:
      name: migration-99331-storage-map
      namespace: konveyor-forklift
  targetNamespace: migration-99331
  vms:
    - id: {{ vmId }}
---
apiVersion: forklift.konveyor.io/v1beta1
kind: Provider
metadata:
  name: migration-99331-vmware-provider
  namespace: konveyor-forklift
spec:
  type: vsphere
  settings:
    vddkInitImage: gcr.io/spectro-images-public/vddk:v8.0.1
  secret:
    name: migration-99331-vmware-secret
    namespace: konveyor-forklift
  url: {{ vSphereUrl }}
---
apiVersion: v1
kind: Secret
metadata:
  name: migration-99331-vmware-secret
  namespace: konveyor-forklift
  labels:
    createdForProviderType: vsphere
type: Opaque
stringData:
  user: {{ vSphereUsername }}
  password: {{ vSpherePassword }}
  thumbprint: {{ vSphereThumbprint }}
  insecureSkipVerify: "true"
---
apiVersion: forklift.konveyor.io/v1beta1
kind: Provider
metadata:
  name: migration-99331-generick8s-provider
  namespace: konveyor-forklift
spec:
  type: openshift
  secret:
    name: migration-99331-generick8s-secret
    namespace: konveyor-forklift
  url: {{ apiServerUrl }}
---
apiVersion: v1
kind: Secret
metadata:
  name: migration-99331-generick8s-secret
  namespace: konveyor-forklift
  labels:
    createdForProviderType: openshift
type: Opaque
stringData:
  token: {{ token }}
---
apiVersion: forklift.konveyor.io/v1beta1
kind: Host
metadata:
  name: migration-99331-host-74
  namespace: konveyor-forklift
spec:
  secret:
    name: host-secret-migration-99331-host-74
    namespace: konveyor-forklift
  provider:
    namespace: konveyor-forklift
    name: migration-99331-vmware-provider
  id: {{ hostId }}
  ipAddress: {{ hostIp }}
---
apiVersion: v1
kind: Secret
metadata:
  name: host-secret-migration-99331-host-74
  namespace: konveyor-forklift
type: Opaque
stringData:
  user: {{ esxiUsername }}
  password: {{ esxiPassword }}
  thumbprint: "{{ esxiThumbprint }}"
---
apiVersion: forklift.konveyor.io/v1beta1
kind: NetworkMap
metadata:
  name: migration-99331-network-map
  namespace: konveyor-forklift
spec:
  map:
    - destination:
        name: migration-99331
        namespace: migration-99331
        type: pod
      source:
        id: {{ networkId }}
        name: {{ networkName }}
  provider:
    source:
      name: migration-99331-vmware-provider
      namespace: konveyor-forklift
    destination:
      name: migration-99331-generick8s-provider
      namespace: konveyor-forklift
---
apiVersion: forklift.konveyor.io/v1beta1
kind: StorageMap
metadata:
  name: migration-99331-storage-map
  namespace: konveyor-forklift
spec:
  map:
    - destination:
        storageClass: spectro-storage-class
        accessMode: ReadWriteOnce
      source:
        id: {{ datastoreId }}
  provider:
    source:
      name: migration-99331-vmware-provider
      namespace: konveyor-forklift
    destination:
      name: migration-99331-generick8s-provider
      namespace: konveyor-forklift

@TylerGillson ack, so you want a tiny, possibly temporary, kind-cluster that would orchestrate migrations to several remote clusters and by that to avoid deploying Forklift on every target cluster, right?
and let me elaborate on what I wrote before:
we use CDI for two purposes: (1) allocate volumes; (2) transfer data
before Forklift 2.4, CDI was always used for both purposes - it allocated the volumes and then transferred the data from the source system using the importer pod
as from Forklift 2.4, CDI only allocates the volumes during cold-migrations from vSphere to the same cluster that Forklift runs on. you don't need to do anything to get this - every cold-migration to the local cluster executes a volume-populator rather than CDI for transferring the data.
the resources you shared seems to include a plan to a remote cluster, not the cluster that Forklift runs on, right? in that case, Forklift 2.4 still uses CDI also for the data transfer. There's an ongoing work to change this.
does it make more sense now?

@ahadas yes, that is exactly the use case we are exploring. And thank you for the clarification around Forklift's usage of CDI.
However, my question (possibly a stupid one :)) is: how would I modify the resources I provided to migrate from vSphere to the same cluster Forklift is running on? (Thus avoiding the use of CDI, as you described).

However, my question (possibly a stupid one :)) is: how would I modify the resources I provided to migrate from vSphere to the same cluster Forklift is running on? (Thus avoiding the use of CDI, as you described).

I see, there are two options:

to install KubeVirt/OpenShift Virtualization on the local cluster (you need it anyway but in this case it should be the first step); then the Forklift operator would add a new 'host' provider in the namespace that Forklift is deployed on (konveyor-forklift by default); and then you can reference that provider:

apiVersion: forklift.konveyor.io/v1beta1
kind: Plan
metadata:
  name: migration-99331-mig-plan
  namespace: konveyor-forklift
spec:
  warm: false
  provider:
    source:
      name: migration-99331-vmware-provider
      namespace: konveyor-forklift
    destination:
      name: host
      namespace: konveyor-forklift
  map:
    network:
      name: migration-99331-network-map
      namespace: konveyor-forklift
    storage:
      name: migration-99331-storage-map
      namespace: konveyor-forklift
  targetNamespace: migration-99331
  vms:
    - id: {{ vmId }}

to create a provider that corresponds to the local cluster and refer to it in the plan:

apiVersion: forklift.konveyor.io/v1beta1
kind: Provider
metadata:
  name: migration-99331-generick8s-provider
  namespace: konveyor-forklift
spec:
  type: openshift

note that the provider would be 'Ready' only when KubeVirt/OpenShift Virtualization is installed on the cluster

Thanks @ahadas. I saw that default provider but just didn't put two & two together. Makes perfect sense now!


libxo output breaks if buffer exceeds 8kb

While converting the FreeBSD procstat utility to libxo, I noticed that if the output exceeds 8kb, and stdout is a file or a pipe, the content is truncated.
to reproduce, run some command that produces more than 8192 bytes of data via libxo, and redirect stdout to a file, or pipe it to less or similar. The output will be truncated.

I could be wrong, but it looks like the problem is caused by the call to xo_buf_has_room() not considering some part of the pretty printing:
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8154, len: 12
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8166, len: 1
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8167, len: 5
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8172, len: 2
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8174, len: 1
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8175, len: 5
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8212, len: 12
ALLAN: Expanded buffer
ALLAN: xo_buf_has_room: xb_size: 16384, curp: 8224, len: 1
ALLAN: xo_buf_has_room: xb_size: 16384, curp: 8225, len: 4
It doesn't appear to expand the buffer until the cur pointer has passed the end of the buffer.

Could you please retry with the current code?  I fixed an embarrassingly bad issue in xo_vsnprintf:

if (rc > xbp->xb_size) {

if (rc >= left) {

in commit 1f66642ec5f9a4ba42e04aa93c7902317cf54425 that’s part of libxo-0.3.3.  IIRC the fix is in 0.3.2 also.
But I’m fairly confident this was the issue you are seeing.
Thanks,
Phil

On May 4, 2015, at 12:40 AM, Allan Jude<EMAIL_ADDRESS>wrote:
I could be wrong, but it looks like the problem is caused by the call to xo_buf_has_room() not considering some part of the pretty printing:
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8154, len: 12
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8166, len: 1
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8167, len: 5
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8172, len: 2
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8174, len: 1
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8175, len: 5
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8212, len: 12
ALLAN: Expanded buffer
ALLAN: xo_buf_has_room: xb_size: 16384, curp: 8224, len: 1
ALLAN: xo_buf_has_room: xb_size: 16384, curp: 8225, len: 4
It doesn't appear to expand the buffer until the cur pointer has passed the end of the buffer.
—
Reply to this email directly or view it on GitHub https://github.com/Juniper/libxo/issues/37#issuecomment-98587108.

I have 0.3.2 with that fix.
The issue seems to be that the exact same bug exists in:
xo_printf_v()
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8166, len: 1
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8167, len: 5
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8172, len: 2
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8174, len: 1
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8175, len: 5
ALLAN: xo_printf_v: wrote 12 of 12 bytes
ALLAN: xo_printf_v: wrote 20 of 0 bytes
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8212, len: 12
ALLAN: Expanding Buffer
ALLAN: xo_buf_has_room: xb_size: 16384, curp: 8224, len: 1
ALLAN: xo_buf_has_room: xb_size: 16384, curp: 8225, len: 4

Fixed in 0.3.4


Restrict search to a specific country

Allow choosing a country for search:
Search country: France, Germany, India, World
If no result is found, add a link to search in the whole world.

Idea is good and it is great that it is open Source. I really wish to give 5 Stars for all great work but search is really bad. This requires a better search enginee. I am searching something results are mostly in french. I understand that creator is french but this is too much. When i search for eggs, it should return english results. Not french.
Hi XXX,
Thank you very much for your feedback. 🙂
We're going to rework search as soon as we can to make it more relevant. Currently, it searches for the whole world, but we want to let your restrict your search to a given country, and have the option to expand to world if no result is found.```

Pierre - on behalf of the other volunteers.

@teolemon I'll be working on this.


Shut down GPIO threads nicely

The motion sensor queue doesn't shut down properly at script end at the
moment and prevents the interpreter shutting down. This is because it's
a non-daemon thread so __del__ never gets run and so on.
This is a bit of a major PR - I can split it up if you want. Firstly it
makes a common base class called GPIODevice for both InputDevice and
OutputDevice. This just takes care of the read-only pin stuff. Next it
makes a GPIOThread class that ensures its a daemon thread, and which
also ensures proper cleanup on shutdown.
Finally, it fixes MotionSensor to use the new GPIOThread class
(tested this time! Works nicely) and adds the blink method to the
LED class (which also works nicely this time).

Oops, forgot to remove the redundant pin definition from InputDevice....


Changed style of BazaarOverviewCard

Hey, I just made a Pull Request!
I've made a few style changes to 'BazaarOverviewCard' to work better with different column width.
Changes:

'BazaarOverviewCard' now always use full card height
'BazaarOverviewCard' takes in the optional parameter 'fullWidth' so it can adjust to a parent grid column width of 12. Removed parameter 'limit'.
Removed fixed width from 'BazaarOverviewCard'
Fixed problem with link to Bazaar not working

:heavy_check_mark: Checklist

[X] A changeset describing the change and affected packages. (more info)
[X] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[X] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

Thank you for contributing during Hacktoberfest 🍂! You can claim the Backstage Hacktoberfest Holopin at https://bck.st/hacktoberfest-holopin 🙌🏻

Thank you for contributing during Hacktoberfest 🍂! You can claim the Backstage Hacktoberfest Holopin at https://bck.st/hacktoberfest-holopin 🙌🏻


Failed to build OmniSharp.Abstractions

@troydai Following our comments at https://github.com/dotnet/cli/issues/1618#issuecomment-191970379
I don't have the DNX_UNSTABLE_FEED set on my Win10 laptop. It fully restores, but I ran into this (twice) attempting to build ...

[EDIT] Should I attempt to strip the dnx451 framework out of the project.json files and attempt a build on dnxcore50 or netstandardapp1.5?

Thanks for reporting this, @GuardRex . You don't need to remove the framework. Everything is supposed to work right away.
I won't be able to repo this failure. But there are a few things you can begin with to solve this issue.

I suspect some cached old packages is misleading the restoring. Can you try clean the cached packages? Remove following folders: %userprofile%\.nuget\package and %localappdata%\NuGet\v3-cache.
If it still repos. Please enter the folder and OmniSharp.Abstractions and execute dotnet build the full build output should give us more clues.

It was a fresh install of dotnet cli, VS Code, and DNVM/DNX on the laptop. Although, idk if the NuGet cache folder may have had packages prior to these installs.
I ran dotnet build from the folder, and it came out ...

@troydai It seems to like dnxcore50 (and I forgot for a sec about the -f switch, but know now) ...

I'm going to proceed with an attempt to build the whole thing for dnxcore50 and report back.

@troydai Doesn't look like it worked out. A few warnings thrown for dep conflicts. There is an error in the OmniSharp Log in VS Code ...

For me the original error popped up from a lack of .NET 4.5.1 Reference Assemblies on my system. One recommended solution was to install VS. I found an alternate hack, by installing: https://www.microsoft.com/en-us/download/details.aspx?id=49978 and creating a copy for 4.5.1 of the folder "C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework.NETFramework\v4.6.1".

@hal-ler Excellent point. This laptop does not have those ref assemblies and that probably explains it.
Is the OmniSharp startup error "The project system 'DotNetProjectSystem' threw exception during initialization." of any concern?
When compiling for v4.5.1 without the ref assemblies, is the prior exception behavior "by-design" for a missing .NET 4.5.x framework?

I have only started playing around with the code recently, so take whatever I say with a grain of salt.
I was able to replicate your exception by convincing VS Code that a particular folder is a .NET Core project without a project.json residing within it. Omnisharp then tried to associate the folder with a workspace, but failed.
In my case the flame is on, but there is no IntelliSense, only editor suggestion for text (try to type "Console." and all the options should pop up). I suggest looking at your project.json file to see what is causing the issue.

You are correct: The methods are not appearing with Intellisense. I thought it was working b/c when I opened a couple of code files, I wasn't getting bad ref indicators (squiggles) under method names. It's not performing look-ups, so it is not working.

@GuardRex
I actually don't have a Windows environment without .NET installed. So I didn't test this Environment, my bad. In that case, yes the build failure is due to missing .NET 4.5.1 references. The solution @hal-ler gave will fix this.
On Mac and Linux this problem is solved by setting an environment variable: https://github.com/OmniSharp/omnisharp-roslyn/issues/412.
For the other issue, The project system 'DotNetProjectSystem' threw exception during initialization. means the project system can't be initialized correctly. Again this is due to the missing of .NET 4.5.1 reference assemblies on you machine. If your project target dnx451 or net451 framework, the DotNetProjectSystem will try to resolve the framework references.
On this note, I think a better error message as well as a choice to ignore entire target framework is a better user experience: https://github.com/OmniSharp/omnisharp-vscode/issues/39

@troydai
I see. I don't explicitly want to ref net451 (all of my apps are of the Core CLR variety), but I'm still having to use imports for unsupported packages ...
"netstandardapp1.5": {
    "imports": [ "dnxcore50", "portable-net45+win8" ]
}

Thanks @troydai and @hal-ler. I'm not sure I'll go to the trouble of installing .NET 4.5.1 or not. I might just rough it out for a few more weeks in hopes that VS Code gets baked-in goodness soon.

@troydai @hal-ler ... yes ... @hal-ler ... thank you much ... your workaround worked for me. I installed the .NET Framework from https://www.microsoft.com/en-us/download/details.aspx?id=49978
I copied the folder ...
C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.6.1`

to a folder called ...
C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5.1`

The ./build.ps1 script ran to completion ...

My apps targeting netstandardapp1.5 (with the usual imports) are getting intellisence with the VS Code workspace setting ...
"csharp.omnisharp": "C:\\omnisharp-roslyn-dev\\artifacts\\publish\\OmniSharp\\dnxcore50\\
OmniSharp.exe"

I'm good. Thanks again to both of you for your help. I plan to stop pulling down DNX runtimes now, so let me know if that's going to be a problem.


Required fields

General details

[x] title
[ ] description
[ ] startYear
[ ] endYear
[ ] link
[ ] implementingOrganization
[ ] fundingOrganisation
[ ] actualBudget
[ ] xy
[ ] projectManagerName
[ ] projectManagerOrganization
[ ] projectManagerPosition
[ ] projectManagerEmail
[ ] projectManagerTelephone
[ ] projectManagerMobile
[ ] cityOrTown
[ ] estimatedBudget
[x] interventionType
[ ] implementationStatus
[ ] fundingType
[x] province
[ ] districtMunicipality
[ ] localMunicipality

Mitigation details

[x] hostSector
[ ] hostSubSectorPrimary
[ ] hostSubSectorSecondary
[ ] mitigationType
[ ] mitigationSubType
[ ] mitigationProgramme
[ ] nationalPolicy
[ ] otherNationalPolicy
[ ] regionalPolicy
[ ] otherRegionalPolicy
[ ] primaryIntendedOutcome
[ ] fileUploads
[ ] coBenefitEnvironmental
[ ] coBenefitEnvironmentalDescription
[ ] coBenefitSocial
[ ] coBenefitSocialDescription
[ ] coBenefitEconomic
[ ] coBenefitEconomicDescription
[ ] carbonCredit
[ ] carbonCreditStandard
[ ] carbonCreditCdmExecutiveStatus
[ ] carbonCreditCdmMethodology
[ ] carbonCreditVoluntaryOrganization
[ ] carbonCreditVoluntaryMethodology
[ ] carbonCreditCdmProjectNumber

Adaptation details

[x] adaptationSector
[ ] otherAdaptationSector
[ ] nationalPolicy
[ ] otherNationalPolicy
[ ] regionalPolicy
[ ] otherRegionalPolicy
[ ] target
[ ] otherTarget
[ ] hazard
[ ] otherHazard
[ ] fileUploads
[ ] observedClimateChangeImpacts
[ ] addressedClimateChangeImpact
[ ] responseImpact

Fields are largely not required as there is a process for validating submissions (by and admin/dffe member). In this case, forcing required fields just makes the form harder to use


Prevent copying an empty line by accident

Fixes #55243

cc @rebornix

Is this setting configurable?  I preferred the old behavior, copy whatever line I press 'Ctrl +c'  on regardless of it's content.
This PR assumes a user didn't want to copy a blank line which I usually do.
It seems the real fix is to copy whatever line the user used the keyboard shortcut on and recommend clipboard managers if you copy something that you didn't intend.

FYI, I opened #69903 for this.  Ctrl + C (or similar keyboard mappings on other editors like notepad++ or even online editors - like firebase rules editor) make no assumption on intention.  Ctrl + C just copies the line.
I'm not opposed to inference, but in this case, it seems like it should be configurable and not assumed that copy of a blank line was in error. :smile:

I do not think this is a mistake, on the contrary I think he can improve my efficiency, please return to the original.


Dev

@mdo about the last patch, we could go with what I've done, or we could specify the bundle. The current way might result in slimmer CSS, but it has the downside that it's not flexible.
Do note that I didn't update starter.css after npm run css-purge because it appears we don't automatically call the script. So, purgecss is basically unused.

This worked for me before when I tested it, but I'm running into issues with sirv-cli now as I'm making lots of changes to CSS that is no longer being reflected. Switching back to serve seems solve them.

Let's revert it if it worked good for you, sure :)


channel bind failed: Allocation Mismatch

I believe this to be the culprit behind the issue seen in Slack thread:
https://firezonehq.slack.com/archives/C07312PRYE4/p1723474901081049
It appears that a number of Relays are experiencing this issue. Link to Relay logs:
https://drive.google.com/file/d/1H2KefSZw5WzFpDs6Hk9VXwMwwAr6i8Jq/view?usp=sharing

Should these channel bind warnings be error instead?

Well, it is hard to say in isolation (from the relay's perspective) whether that is an actual error. I guess we could upgrade them to errors. There is no case where we expect to receive an Allocation Mismatch when binding a new channel.
The actual cause is likely on the connlib-side though.

It appears that a number of Relays are experiencing this issue. Link to Relay logs:
drive.google.com/file/d/1H2KefSZw5WzFpDs6Hk9VXwMwwAr6i8Jq/view?usp=sharing

Are these the only logs? No INFOs around that?

Fixed in #6277.


Integration Test - Release - 2019/03/08 17:28:47

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

@PRMergerTest2 : Thanks for your contribution! The author, @v-caxian, has been notified to review your proposed change.


Incorrect Default Database for YugabyteDB Connection

System information:

Mac OS
DBeaver v7.1.2

Connection specification:

YugabyteDB
Postgres JDBC Driver

Describe the problem you're observing:
When creating a new YugabyteDB connection, the default database is being populated as postgres instead of yugabyte.
In the file org.jkiss.dbeaver.ext.postgresql/plugin.xml, entry is made to use yugabyte as the default database however when creating a new YugabyteDB connection postgres is being populated by default which is incorrect.
<extension point="org.jkiss.dbeaver.postgresql.serverType">
        .....
        <serverType id="yugabytedb" name="YugabyteDB" class="org.jkiss.dbeaver.ext.postgresql.model.impls.PostgreServerYugabyteDB" logo="icons/yugabyte_logo.png" defaultDatbase="yugabyte" defaultUser="yugabyte" customURL="true"/>
    </extension>

Steps to reproduce, if exist:

Create a new Database connection
Select YugabyteDB
Database field will be populated with postgres

Include any warning/errors/backtraces from the logs

Thank you for the bug report.

verified


[Feature]: Operator can push apps with larger resource requirements by default

Blockers/Dependencies
No response
Background
As a platform operator
I want app developers to be able to push apps with larger resource requirements by default
So that I do not have to configure the platform to handle apps that push successfully on cf for vms
Acceptance Criteria
GIVEN a default installation of korifi
WHEN I push an app with staging resource requirements like the java spring app
THEN I the push succeeds
Dev Notes
We recently added some configuration around app resource limits that caused app pushes to start failing due to low default values. Instead, limits in cf for vms were enforced at the space and org level with quotas, so we would like to instead use something like a kubernetes resource request to implement the appropriate behavior. At the very least, we may just roll back the limit configuration to unblock app pushes.
See related #2663 and #2673. Also see related slack thread:  https://cloudfoundry.slack.com/archives/C0297673ASK/p1689178733777159.
### Tasks
- [ ] Update kpack buildworkload controller to only set resource requests with current configuration
- [ ] Update internal configmap fields names
- [ ] Update default values of staging resource requests to either higher numbers or remove them outright

This change resulted in some korifi builds not being able to be scheduled, because  resource requests default to the value of resource limits and it seems that 1G memory request is too big for our clusters. We have therefore reduced the test parallelism a bit to fix CI. Can you please revert this commit once you have a proper fix for this problem. Thanks!

Now that the fix is merged into main, reverting the node configuration and re-flying the pipeline.


init outputTimestamp

one character does not get updated at release time

@ppalaga any feedback on this PR ?

@ppalaga any feedback on this PR ?

Thanks for the headsup, I commented inline.

@hboutemy Can you rebase?

given ppalaga changed the value and we upgraded the release plugin in #10572, this PR is now obsolete: I'm closing it, job done


the hyper link has no effect about “Transaction initialization”

when we click the hyperlink about "Transaction initialization" in the document BoAT_Overall_Design_en (https://github.com/aitos-io/BoAT-X-Framework/blob/release-v2.2.0/docs/en-us/BoAT_Overall_Design_en.md)，there has no any response.

Same issue with #703


Implement googlepay button

This PR implements the following:

Displays the googlepay button for stg/prod to get payment data from the Google Pay API
Calls the convert token endpoint in wallets-api
Adds a 'tokens' option to the POST payments page

Note: this is only initial implementation of the google pay button - there are some hard coded values in the googlePay lib in this PR that will be removed/moved to SSM in subsequent PRs
Sandbox/Smokebox:

Stg/Prod:

Do you mind linking the story in the PR title? Thanks!

This is public repo, no internal info gets associated with this repo


Remove diff files

In MerginProject method get_push_changes() check for zero size diff files and removes them.
In MerginClient  method push_project() clean any existing diff files when the method ends.

The clean in push_project_finalize() should also happen in cases when errors are raised, right? So that the diff files removed in any case.

Fixes #47


EASY: tag-register all raw matrices

This is just like #4101 but for add_matrix
See 79d91811fda816d116d150840fad647eda50c37e for an example.

Hey, I would like to work on this, but I am new here, so I might ask a lot of questions

Is this right?
For example: shogun/src/shogun/distance/AttenuatedEuclideanDistance.cpp
this code below needs to be changed:
`void CAttenuatedEuclideanDistance::init()
{
disable_sqrt=false;
m_parameters->add(&disable_sqrt, "disable_sqrt", "If sqrt shall not be applied.");

}`
Into this :
`void CAttenuatedEuclideanDistance::init()
{
disable_sqrt=false;
watch_param("disable_sqrt", &disable_sqrt);

}`


Revised find operations for #2857

Creating as draft request so we can debate the naming, endpoints, etc if desired...

Interface definition, including new search objects and operators
New findEntities method and REST endpoints
Initial implementation of findEntities for in-memory repository

Still todo:

[x] Implementation of new findRelationships method and REST endpoints
[x] Initial implementation of findRelationships for in-memory repository
[x] Unit tests (is there something already there I should extend?)
[x] Inclusion of the method as a new profile in the CTS (probably as a separate issue and PR: see #2895 )

Also discussed:

I have purposely not extended the InstanceElementHeader class in the new beans (other than the top-level request bean), because this would force us to need to explicitly provide the "class" property in many places within the payload, and I believe this is redundant (and overly complicates the request) -- therefore I've gone directly for Serializable in the new beans. (Confirmed on Thursday call that this is acceptable as we do not anticipate subclassing these sub-beans, as they are only used by this search interface and if they were to be subclassed then we would invalidate the backwards compatibility of the interface.)

Merging into master for 1.8, as discussed on Tuesday call...


Can't run mriqc group analysis on a subset of the sample (separate echos)

What happened?
I have multiecho data and I have ran mriqc on the participant level for all participants for each echo separately using bids-filter-file. Now I want to run a group analysis for each echo separately as I don't want all echos in the same group report. I have specified that in the bids-filter-file and when I run the code it identifies it as a filter and later on in the config file in logs it also only selects the first echo as intended. However, the generated reports are of all echos together.
What command did you use?
docker run -it --rm -v <bids_root_dir>:/data:ro -v <output_dir>:/out \
-v <bids-filter-file_dir>:<bids-filter-file_dir> \
nipreps/mriqc:24.0.2 /data /out group \
--task-id nf \
--bids-filter-file <dir> \
--verbose-reports \
--no-sub \
-w <output_dir>/group/echo1

What version of the software are you running?
24.1.0 and in the latest try 24.0.2 (see above) although it still shows 24.1.0. in logs
How are you running this software?
Docker
Is your data BIDS valid?
Yes
Are you reusing any previously computed results?
No
Please copy and paste any relevant log output.
No response
Additional information / screenshots
No response

I may be wrong but I think bids-filter are not yet supported at the group level, no?
Or more specifically you can pass a bids filter file but it won't affect the output.

Yeah, that seems to be the case since it recognizes the filter file but it doesn't get used. I ended up having to separate the different echos into different folders in order to get separate group reports.

If I'm reading the code correctly, the bids filter would need to be applied in this step, where the json's are collected to construct a TSV:
https://github.com/nipreps/mriqc/blob/d7f9c89a227f8a4c2e7f721f405efa4f47cb6fde/mriqc/utils/misc.py#L199
Does that seem correct to folks more familiar with MRIQC?


Request to https

Hello,
I'm using event_sync mod_event_sync_component.lua. For the api_prefix, it's configured with plain http. I've tried https but it didn't work. For ex: https://my.api.server/api
I think the main reason here is line 24 net.httpdoesn't support https.
Probably you can change to  local https = require 'ssl.https'
Reference https://stackoverflow.com/a/8289116/4318331

@emrahcom @shawnchin how do you think?

How does it fail when you configure api_prefix to point to an HTTPS uri?
As far as I can tell, the plugin uses net.http from prosody which appears to support https (https://github.com/bjc/prosody/blob/af11afa9c6f3766068d2aa369a7f4c15cbbf1d9a/net/http.lua#L21) and not socket.http referenced in the stackoverflow post.

@shawnchin I can see API response code 0
Nov 03 02:51:35 bosh642ff9b9-59ee-497d-a3b8-c3fbabf6b725	info	Authenticated as<EMAIL_ADDRESS>Nov 03 02:51:42 event_sync.mydomain.com:event_sync_component	info	Start tracking occupants for<EMAIL_ADDRESS>Nov 03 02:51:42 event_sync.mydomain.com:event_sync_component	info	New occupant - {"occupant_jid":"h23xbt7ayzd50bqw@mydomain.com/6tjaLMe7","joined_at":1635882702}
Nov 03 02:51:42 event_sync.mydomain.com:event_sync_component	warn	API Response code 0. Will retry after 3s
Nov 03 02:51:42 event_sync.mydomain.com:event_sync_component	warn	API Response code 0. Will retry after 3s
Nov 03 02:51:46 event_sync.mydomain.com:event_sync_component	warn	API Response code 0. Will retry after 3s
Nov 03 02:51:54 event_sync.mydomain.com:event_sync_component	info	Occupant left - {"joined_at":1635882702,"occupant_jid":"h23xbt7ayzd50bqw@mydomain.com/6tjaLMe7","left_at":1635882714}
Nov 03 02:51:54 speakerstats.mydomain.com:speakerstats_component	warn	A module has been configured that triggers external events.
Nov 03 02:51:54 speakerstats.mydomain.com:speakerstats_component	warn	Implement this lib to trigger external events.
Nov 03 02:51:54 event_sync.mydomain.com:event_sync_component	info	Room destroyed -<EMAIL_ADDRESS>Nov 03 02:51:54 bosh642ff9b9-59ee-497d-a3b8-c3fbabf6b725	info	BOSH client disconnected: session close
Nov 03 02:51:54 event_sync.mydomain.com:event_sync_component	warn	API Response code 0. Will retry after 3s
Nov 03 02:51:54 event_sync.mydomain.com:event_sync_component	warn	API Response code 0. Will retry after 3s
Nov 03 02:51:57 event_sync.mydomain.com:event_sync_component	warn	API Response code 0. Will retry after 3s

My configuration
Component "event_sync.mydomain.com" "event_sync_component"
    muc_component = "conference.mydomain.com"
    api_prefix = "https://manage.emso.vn/api/man/v1/jitsimeet"
    --retry_count = 5
    api_retry_delay = 3

I've tried curl from Jitsi server and it connects normally

@shawnchin I can see API Response code 0
Nov 03 02:51:35 bosh642ff9b9-59ee-497d-a3b8-c3fbabf6b725	info	Authenticated as<EMAIL_ADDRESS>Nov 03 02:51:42 event_sync.mydomain.com:event_sync_component	info	Start tracking occupants for<EMAIL_ADDRESS>Nov 03 02:51:42 event_sync.mydomain.com:event_sync_component	info	New occupant - {"occupant_jid":"h23xbt7ayzd50bqw@mydomain.com/6tjaLMe7","joined_at":1635882702}
Nov 03 02:51:42 event_sync.mydomain.com:event_sync_component	warn	API Response code 0. Will retry after 3s
Nov 03 02:51:42 event_sync.mydomain.com:event_sync_component	warn	API Response code 0. Will retry after 3s
Nov 03 02:51:46 event_sync.mydomain.com:event_sync_component	warn	API Response code 0. Will retry after 3s
Nov 03 02:51:54 event_sync.mydomain.com:event_sync_component	info	Occupant left - {"joined_at":1635882702,"occupant_jid":"h23xbt7ayzd50bqw@mydomain.com/6tjaLMe7","left_at":1635882714}
Nov 03 02:51:54 speakerstats.mydomain.com:speakerstats_component	warn	A module has been configured that triggers external events.
Nov 03 02:51:54 speakerstats.mydomain.com:speakerstats_component	warn	Implement this lib to trigger external events.
Nov 03 02:51:54 event_sync.mydomain.com:event_sync_component	info	Room destroyed -<EMAIL_ADDRESS>Nov 03 02:51:54 bosh642ff9b9-59ee-497d-a3b8-c3fbabf6b725	info	BOSH client disconnected: session close
Nov 03 02:51:54 event_sync.mydomain.com:event_sync_component	warn	API Response code 0. Will retry after 3s
Nov 03 02:51:54 event_sync.mydomain.com:event_sync_component	warn	API Response code 0. Will retry after 3s
Nov 03 02:51:57 event_sync.mydomain.com:event_sync_component	warn	API Response code 0. Will retry after 3s

My configuration
Component "event_sync.mydomain.com" "event_sync_component"
    muc_component = "conference.mydomain.com"
    api_prefix = "https://sub.mydomain.com/api/jitsimeet"
    --retry_count = 5
    api_retry_delay = 3

I've tried curl from Jitsi server to the sub.domain.com and it connects normally.
What did I do wrong?

I can see the response_body is certificate-verify-failed. I think this the main reason to request to https. But I don't know which certificate, from api_prefix or current Jitsi server?
I've tried command update-ca-certificates -f but it doesn't work

That certainly smells like an issue related to [LetsEncrypt DST Root CA X3 expiration](DST Root CA X3 Expiration).
Your server certificate is valid, but the lua code is still using old list of CAs to verify certs, and that probably still contains "DST Root CA X3" entry which is now expired.
What OS are you on?  If Ubuntu/Debian, perhaps try upgrading ca-certificates and libssl packages?

Btw, I've just tested the module by point api_prefix to a https://webhook.site address and the payload is sent as expected.
Which means net.http should handle HTTPS and you should be good to go once the CA certificates issue is sorted out.

@shawnchin I'm using Debian 10 buster. Following Certificate Compatibility it still support right?
I've tried update openssl
root@jitsimeet:/etc/prosody# apt-get install openssl
Reading package lists... Done
Building dependency tree
Reading state information... Done
openssl is already the newest version (1.1.1d-0+deb10u7).
0 upgraded, 0 newly installed, 0 to remove and 15 not upgraded.

Set !mozilla/DST_Root_CA_X3.crt in /etc/ca-certificates.conf
And run update-ca-certificates -f
But the problem's still there. What do you think in this case?

The related package is ca-certificates
On 11/3/21, Tung Hoang Manh @.***> wrote:

@shawnchin I'm using Debian 10 buster. Following Certificate
Compatibility it
still support right?
I've tried update openssl
***@***.***:/etc/prosody# apt-get install openssl
Reading package lists... Done
Building dependency tree
Reading state information... Done
openssl is already the newest version (1.1.1d-0+deb10u7).
0 upgraded, 0 newly installed, 0 to remove and 15 not upgraded.

Set !mozilla/DST_Root_CA_X3.crt in /etc/ca-certificates.conf
And run update-ca-certificates -f
But the problem's still there. What do you think in this case?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi-contrib/prosody-plugins/issues/5#issuecomment-958807068

@emrahcom could you give more detail? Like I said I updated the certificates but it still didn't work

Like I said I updated the certificates

When you said you updated, did you mean this?
apt-get update
apt-get install --upgrade ca-certificates

Not sure what else to add I'm afraid. Works on ubuntu hosts that I've tested and I don't currently have immediate access to Debian to test.
Have you tried pointing the plugin to a different HTTPS endpoint (e.g. visit https://webhook.site and get a unique test url) just to quickly work out if the issues is indeed with CA Certificates on host or a legit cert issue on your server?
Also, perhaps check that you have not overriden ssl capath in prosody? AFAIK it is possible to configure prosody to use a different trusted cert store, but no idea if this impacts net.http calls.

@shawnchin you're right, the main reason is because of server of api_prefix, not the net.http
Thank you very much! @shawnchin @emrahcom

@coffeduong hello. Did you fix your problem with https in api_prefix? Got the same problem. wget request from prosody container to event routes works (server is in another container), but requests from event_sync component returns code 0 with "connection refused" response body.

Sorry @denis-ionov , when I worked on this issue, only God & I understand what it did. Now, only God knows 😭
Just kidding, it will take time for me to check the old project again.

There should be no issues with HTTPS in api_prefix.
The one common issue we see when someone has issues (but curl/wget works) is when they rely on /etc/hosts for resolving hostnames. AFAIK the IP resolver behind net.http does not use /etc/hosts and so you need to make sure the hostname you specify is resolvable via DNS (or where possible/practical, fallback to using IP in api_prefix).

@coffeduong @shawnchin thanks for replies. @shawnchin setting up container ip instead of host at api_prefix makes it work. Thanks again!

@shawnchin @emrahcom Sorry for opening the thread again, but If we have to use the domain name instead of the IP address, how can we solve it?


promptForChanges should flush stdin before printing the prompt and Scanln

During a long operation, it's possible that the user presses some keys accidentally.
If promptForChanges doesn't flush the stdin buffers before printing the prompt
and Scanln, it's quite possible that it reads the inputs before the user has even
see the prompt and abort/proceed incorrectly, which is quite frustrating.
should also audit the code for similar problems.

Thank you @minux for pointing this out, I agree. I shall jump on this when I get home in about two hours or so.

@minux sorry for the late reply. I actually worked on patching this up but realized that Golang at least from my experimentation doesn't expose methods for draining stdin unbuffered. The methods I could find were buffered so wouldn't cover the case before someone hit enter. I tried different forms and hacks then thought of doing it the C-style with select's FD_ISSET with a timeout or even getc with an fd that was dup'd using O_NONBLOCK, but I figured this is way too much hackery yet I could ask you a Golang core developer for help on how you solve. If you can would you mind helping out with this or giving some hints?
Thank you.

There is no portable way to do this.
On Linux, you can use golang.org/x/sys/unix package to do
that. For example.
unix.Syscall(unix.SYS_IOCTL, 0, unix.TCFLSH, 0)
to do that.
(The first 0 is the file descriptor for stdin, assuming it's a tty.)
The problem is, however, even on Unix, the constant is not
consistently named.
You can use cgo for this task, which will be portable across
unix (I don't think windows allow you input when the program
is not asking for input, so we don't need to consider windows)
Or we can just use a real terminal handling package.
A some demo (for unix only):
package main
/*
#include <termios.h>
#include <unistd.h>
void flushtty() {
tcflush(0, TCIFLUSH);
}
*/
import "C"
import (
"fmt"
"time"
"golang.org/x/sys/unix"
)
func main() {
fmt.Println("long operation...")
time.Sleep(5 * time.Second)
fmt.Print("Y/N? ")
if false {
unix.Syscall(unix.SYS_IOCTL, 0, unix.TCFLSH, 0) // linux only
} else {
C.flushtty()
}
var s string
fmt.Scanln(&s)
fmt.Printf("%q\n", s)
}

Aha nice. Thank you! I had also considered the termios solution and I have done such in C but never brought that idea over to Go.
We aren't worrying too much about Windows, this project is mainly for the *NIXes at least for now.
If you'd like to submit this in a PR, that'd be appreciated plus it gives you the contributor credit for the solution. If not, I understand how busy you are :)
Otherwise the branch that I started for this is at https://github.com/odeke-em/drive/tree/flush-stdin-before-prompt, and the first cut at it was at https://github.com/odeke-em/drive/commit/dfb410958cb17ffff879869018cfee9dabab9ffc

I'm happy to send a PR. do you like the cgo version?

Cool, thanks. Yes in deed, I like the cgo version and it will do the job.

Actually would you mind instead switching this to the real terminal handling version since this should also work for OSX?

Am off to bed as it is past midnight here but I'll catch you in a bit.

The cgo version is tested on Linux/Darwin/NetBSD and Solaris.

Oh okay, for sure go ahead.

Thanks for working on this @minux

I don't know why this is "closed". This is still an issue in Go 1.5.1. Will it be fixed in 1.5.2?

@akevinbailey What is the issue that you think should be fixed in Go?


Two digits issue on recover wallet and receive tx page disabled bump fee

Receive tx page cant bump fee now, fixed a two digit number size on recover wallet

Thanks for the PR @yshwanth !
Taking a look!

LGTM!


remove release infos for consolidation

This PR updates the Release Information (release-information.md) in Pulldown Menu “Versions” with the intention to eliminate duplicate information in various areas.
It thereby fixes the Issue #572
See:

https://github.com/eclipse-tractusx/tractus-x-release/pull/26
https://github.com/eclipse-tractusx/sig-release/pull/662

Hi @Siegfriedk,
I re-ran the dash workflow, since it failed because of. a ClearlyDefined request error.
It is still failing and this time with an actually out of date file. Maybe rebasing or re-generating the DEPENDENCIES file resolves it

Hi @Siegfriedk,
I re-ran the dash workflow, since it failed because of. a ClearlyDefined request error. It is still failing and this time with an actually out of date file. Maybe rebasing or re-generating the DEPENDENCIES file resolves it

rebased, its green now :)


remove strict pinning

Is the strict pinning really needed? This makes it very hard to build dependent packages.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Refactor page_params language data into clean data structures

We currently have the following fields in page_params (quoting zerver/lib/home.py):
        default_language_name=get_language_name(register_ret["default_language"]),
        language_list_dbl_col=get_language_list_for_templates(register_ret["default_language"]),
        language_list=get_language_list(),

which exist to drive the piece of our settings UI that's for choosing a language. There's also default_language, which comes straight from register_ret, and is the language identifier that the frontend i18n code actually uses for translations.
We'd like to expose that information in the API, so that mobile and terminal and other clients can use it. The existing fields are tangled up with UI decisions, so the main work we need in order to do that is to refactor them into clean reusable data structures, and move the UI logic to the frontend code.
That can look like:

Remove default_language_name; the UI can get that information from default_language plus language_list.

Probably one step here is that the frontend should convert language_list into a Map so that it can efficiently look things up by the language identifier/code.

Remove language_list_dbl_col; it's basically a rendering of the data in language_list into a form that corresponds to the specific UI in our language-setting modal. Instead, the UI code in the frontend should do that computation.

After that's done, we'll also want to do some renaming (default_language should definitely have a different name), and take a close look at what's inside language_list and possibly adjust that format as well. But the above steps should cover the substantive refactoring that we need here.

@zulipbot claim

The UI code really should use CSS columns instead of doing all the table layout with array operations.


Prioritize blocked task messaging over idle tasks

Problem
Unified scheduler is slow. ;)
Summary of Changes
Add very primitive (under 100 loc pr) yet effective adaptive behavioral heuristic (i.e. no constant knob) at the scheduler layer to complement SchedulingStateMachine's buffer bloat ignorance.
EDIT: phew just wrote the commentary. the irony is that the accompanied unit test took longer time to write than the actual code changes. Moreover the commented monologue prose took even longer time to write than the unit test.. lol
Perf numbers
at least ~5% consistent perf improvement is observed
(see https://github.com/solana-labs/solana/pull/35286#user-content-steps if you want to reproduce the results)
before (just after #129 is merged):
ledger processed in 21 seconds, 954 ms
ledger processed in 21 seconds, 643 ms
ledger processed in 21 seconds, 895 ms

after:
ledger processed in 20 seconds, 264 ms
ledger processed in 19 seconds, 983 ms
ledger processed in 20 seconds, 16 ms

context: extracted from https://github.com/anza-xyz/agave/pull/593

Codecov Report
Attention: Patch coverage is 90.47619% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.8%. Comparing base (c207274) to head (3d1be8d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #627     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%
=========================================
  Files         851      851
  Lines      230236   230246     +10
=========================================
- Hits       188535   188521     -14
- Misses      41701    41725     +24

see above comment about potential issue with chained channels and the idle task senders

I'm really to grateful for you to catch the issue.. Still ci is pending, but i think i've fixed it...

Hey was reviewing this again, and had some concerns about the ChainedChannel design in general. After digging, I do think the impl is working now, but I think the way it's written are a bit confusing. The big select! makes things seem potentially racy since there's, at least to me, an implicit assumption that any of the branches could happen whenever. Then the danger comes when we have an OpenSubchannel. Logically, this should be the "event" that kicks off the rest of the process until we are finished.
I think making the order of things more explicit can help clarify the code, wdyt?
Something like:
loop {
    let NewTaskPayload::OpenSubchannel(new_context) = new_task_receiver.recv() else {
		// handle logical error.
	};

	loop {
		// your select! loop here, but with the OpenSubChannel stuff being removed.
	}
}

This code makes it more clear we expect to open a subchannel, loop until we are finished, then eventually open another new one.
It makes it easier to reason about, since we do not expect a new subchannel to be opened when we have any outstanding tasks.

Hey was reviewing this again

thanks as always for taking a deep look.

After digging, I do think the impl is working now, but I think the way it's written are a bit confusing. The big select! makes things seem potentially racy since there's, at least to me, an implicit assumption that any of the branches could happen whenever. Then the danger comes when we have an OpenSubchannel. Logically, this should be the "event" that kicks off the rest of the process until we are finished.

Good point. This understanding is correct.

Something like:
...
This code makes it more clear we expect to open a subchannel, loop until we are finished, then eventually open another new one. It makes it easier to reason about, since we do not expect a new subchannel to be opened when we have any outstanding tasks.

done: 69049385b0c3a4636b2003244ce1afff92ad627e
I think this incurs additional recv per session. but i think this is a good compromise to improve readability.

I think this incurs additional recv per session. but i think this is a good compromise to improve readability.

Not sure I understand where the additional recv per session is happening, could you give an example? I thought this would just be moving the initial recv, which is effectively assumed to be a opensubchannel, but not causing an additional one.

I think this incurs additional recv per session. but i think this is a good compromise to improve readability.

Not sure I understand where the additional recv per session is happening, could you give an example? I thought this would just be moving the initial recv, which is effectively assumed to be a opensubchannel, but not causing an additional one.

yeah, that's correct. i was wrong... Actually, this commit results in fewer try_recv operation inside select!, actually. That's because the conceptual initial recv is only operating with the new_task_receiver, ignoring others.


Switching to different networks bug in Wallet component

Fix switching to different networks bug in AssetSelector.jsx file for the wallet component.
nativeBalance.balance alone sometimes returns an undefined value, which crashes the page. I added a condition to return a 0 instead.

The page needs to be refreshed after switching unfortunately, it looks the problem is coming from the Chains.jsx file. The chainId becomes null, however successfully switches once the page refreshes.


Issue with animation_frame in line plot

I tried to animate a line plot with animation_frame but it did not work. The resulting animation shows no data and the x-axis gets messed up:

Do I do something wrong?
I use Python 3.7.3.

If you map both x and animation_frame to "time" you will never see any lines, because you need at least two points per line per frame :)

Hi Nicolas, thanks - of course. All clear now. I better close this quick ;-). Thank you a lot for the excellent work.


When you modify the bootstrap-core package, the reference class appears: NoClassDefFoundError

When you modify the bootstrap-core package, the reference class appears: NoClassDefFoundError

@maojunling
Please share more detail information about the modification, such as

reason
which lines ? (before/after)
...

I want to use the RestTemplate in DefaultProfilerConfig. The compilation is fine and I find NoClassDefFoundError at run time.
I tried to bind a reference to ConfigModule, and the same error was reported.
`ProfilerConfig profilerConfig = agentOption.getProfilerConfig();
bind(ProfilerConfig.class).toInstance(profilerConfig);
    bind(ClientHttpRequestFactory.class).toInstance(profilerConfig.simpleClientHttpRequestFactory());
    bind(RestTemplate.class).toInstance(profilerConfig.restTemplate());

    bind(TransportModule.class).toInstance(profilerConfig.getTransportModule());
    bindConstants(profilerConfig);`

This issue requires a deep understanding of class loading.
I recommend learning about Class loading and ClassLoader in Java


Specific coupon applied full discount instead of fixed amount

Bug report
Title
Specific coupon applied full discount instead of fixed amount
Issue Description
Specific coupon applied full discount instead of fixed amount
Preconditions
Please provide as detailed information about your environment as possible.
1. latest master pull

Steps to reproduce
It is important to provide a set of clear steps to reproduce this bug.If relevant please include code samples.
1. create a promotion with a specific coupon name
2. add action only.. fixed amount on the whole cart = $50, free_shipping = yes
3. try to apply this coupon...

Expected result
Only get $50 discount
Actual result
Only get the full discount(all item free)

@otheriz
first thing we have disabled free shipping field for action type fixed amount to whole cart - https://prnt.sc/uenwgc
so mentioned steps to reproduce cant be possible

@bhanu-webkul ,
but if we set the free shipping field to "yes" it still gets the free shipping..why disabled it btw?
this is my setting https://prnt.sc/ueoiif
this is the result http://prnt.sc/ueojy7
My CartRule.php already the same like
https://github.com/bagisto/bagisto/blob/master/packages/Webkul/CartRule/src/Helpers/CartRule.php

free shipping field is disabled because, fixed amount to whole cart gets applied over grand total which includes everything.
As per your setting you have given discount 200, is it in USD or in which currency, if not USD could you please attach screenshot of exchange rate.

It's AED(United Arab Emirates dirham)..i don't have any exchange rate..

My currency only AED

My .Env and config Currency already AED too..

@otheriz
I have checked in master , its working fine
this is my setting - https://prnt.sc/ufbmuy
this is the result- https://prnt.sc/ufbq1b

@bhanu-webkul ,
The condition is all null right ??
can you tell me what is the files that affect this coupon think ?

working in both case, with and without condition

I get the problem but not knowing yet how to fix it..
Do you tried it with multiple items ?
somehow this lines
https://github.com/bagisto/bagisto/blob/master/packages/Webkul/CartRule/src/Helpers/CartRule.php#L277
is triggered as much as the items of the cart..
that's why if i put 200, and on cart have 5 items...it will be multiplied to 200x5 = 1000 discount

@otheriz
duplicate cart rule issue has been fixed as mention here https://github.com/bagisto/bagisto/issues/4392
So closing this right now, feel free to reopen if you're still having the same issue.


RUM docs

Go through all the issues to find out what things users are stumbling on
Create a 'recipes' page, and update the troubleshooting page
Better styling for the API docs

Better use this too https://github.com/jenniferlynparsons/awesome-writing

examples would be amazing. I want to know how to fully utilize this! very useful so far.


[DatePicker] Setting value shows the wrong day

If you set the value of DatePicker with the content of: new Date('2017-11-13') for example, it will display the day before. Proof: https://codesandbox.io/s/vq6wmp7r5l

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

To display the same day as in the Date object argument.
Current Behavior

https://codesandbox.io/s/vq6wmp7r5l
Steps to Reproduce (for bugs)

1.Import DatePicker
2.Hardcode the date in the set value
3.watch it display the day before
Context

Trying to display the date
Your Environment

non relevant.

Tech
Version

Material-UI
latest

React
latest

browser
firefox 57 - 64bits

I suspected that this had to do with time zones and a quick change to @betoharres example appears to confirm this. If you change the date value to something like: "2017-11-27T16:28:16.020Z" (which includes time zone information) then the date correctly initializes. Forked sandbox example - https://codesandbox.io/s/88n966km1l

Thanks for the feedback, I'm going to check the example now +1

@johnsouth thanks for the tip! It solves the "problem". Have a nice day 🍻

I have spent many long nights fighting date strings! My SOP is to store and manipulate all dates using UTC - https://en.wikipedia.org/wiki/Coordinated_Universal_Time
At this point I typically just use something like https://momentjs.com/timezone/ for all of my dates. Glad I was able to help!


@effect/rpc.
You know, I actually liked Effect, but after seeing the rpc syntax - I was just shocked. Trpc is not quite perfectly compatible with Effect and in some moments. I was really excited when I saw that there was a @effect/rpc package, but after seeing the syntax I saw, my desire dropped to zero to use it and I'm not surprised that this package has 1.5k downloads and they're all dropping.
With my whole dislike for java - Spring and nest.js are still ok compared to this syntax.
At first I was just killed by the syntax of error generation, but I put up with it, with this TaggerError through classes, yes also that it does not allow to extend already existing errors, which are already in the libraries of various, but this:
For each request to generate its own class, to write 3 times the same thing. Also to call a query, to create an instance of class 🤮🤮🤮🤮

So much of this syntax is unreadable that I didn't even realize what was going on here at all at first. Forget about this extends syntax in classes everywhere, otherwise nobody will really use it. When the whole js community is striving more towards a functional syntax like the world in general, in the form of abandoning monoliths in java, converting from java to kotlin, React from classes to functions, you decide to add classes where you just don't need to.
I don't understand how after the wonderful pipe function and such a linear functional syntax the desire to create this in such a way was born....

@MrOxMasTer - we certainly appreciate the feedback. We also acknowledge that there is a bit of verbosity when defining the domain model for your RPCs. However, we don't really believe that utilizing a class-based approach for domain modeling results in non functional code. In addition, you are free to use either the Effect.gen-based generator syntax or the pipe-based syntax - we expose both to allow developers the choice of writing code in the way that they prefer.
We also do have several good reasons we have leaned into a class-based route for domain modeling in Effect.
Some of the benefits of using classes for domain models include:

Having a single, opaque identifier to represent both the type and the piece of data
Allows access to both:

the static side of the class (i.e. for constructors as well as representing the schema)
the instance side of the class for exposing getters and helper methods

Allows the class itself to be safely serializable/deserializable since the class instance is also a schema

All the above being said, the @effect/rpc package is still very much considered "unstable" as we are still iterating on it.
If you have any additional feedback, please feel free to share it here. We take all feedback we receive from users into consideration when designing our APIs.

Some of the benefits of using classes for domain models include:

Having a single, opaque identifier to represent both the type and the piece of data
Allows access to both:

the static side of the class (i.e. for constructors as well as representing the schema)
the instance side of the class for exposing getters and helper methods

Allows the class itself to be safely serializable/deserializable since the class instance is also a schema

It looks like a boilerplate of code and constructors in your classes, nothing is literally being used out of all those benefits (except under the hood only), only it makes DX terrible:

I think schemes for failure and success, you can write without classes, and this boilerplate of code trash:

it's already unpleasant
Why couldn't syntax like this be done?:
const procedure = Effect.procedure(<inputSchema>, <outputSchema>, () => {...})

as in trpc, it's clear that you were inspired by this library:
well, or this syntax?:
const req = Request.base(<inputSchema>, <outSchema>, () => {...})

very hard to see anything positive come out of this way of discussing the argument. Feel free to open more actionable feedback issues taking into account basic rules of respect.


Automated PR labeling

Objective

Currently only issues automatically have labels assigned to them on creation.
The enables pull requests to have the same functionality and currently only adds the needs-triage label to all PRs.

Solution

Integrate actions/labeler@v2 into the github workflows to automatically tag PRs.
Add a label-config.yml file that specifies how PRs should be labeled.

 :(

A workaround would be to have a workflow run on a schedule (every 10 minutes?) and tag every PR without tags but that would be one ugly workaround...

This article has a good overview of "pull_request_target" security: https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
Seems like this is in-line with those use cases.

bors r+


JSON.stringify missing for body?

I am getting the impression I am the first person other than you to use this package :) This is good because now we are in the same boat ;)
I was having some trouble POSTing and PUTing, and I found the cause to be the request body not being stringified. The example on the fetch readme (find "Post JSON") shows this:
fetch('/users', {
  method: 'post',
  headers: {
    'Accept': 'application/json',
    'Content-Type': 'application/json'
  },
  body: JSON.stringify({
    name: 'Hubot',
    login: 'hubot',
  })
})

Perhaps wrap JSON.stringify(body) on this line? https://github.com/agraboso/redux-api-middleware/blob/master/src/index.js#L41

You're right! In fact, after reading the fetch specification, I think it'd be better to allow [CALL_API].body to be of any type, remarking that it should be a valid body according to the fetch specification. You can then JSON.stringify the body yourself.


Potluck flavours should clean /var/cache/pkg and /var/db/freebsd-update

I noticed after building a potluck flavour (in this example mariadb), that it keeps packages in /var/cache/pkg after installation. It also keeps /var/db/freebsd-update, in case the pot fbsd-update flavour was run.

Example from mariadb on 14.1-RELEASE:
# zfs list zroot/pot/jails/mariadb/m
NAME                        USED  AVAIL     REFER  MOUNTPOINT
zroot/pot/jails/mariadb/m   619M  5.54G     1.49G  /opt/pot/jails/mariadb/m
# rm -rf /opt/pot/jails/mariadb/m/var/cache/pkg/*
# zfs list zroot/pot/jails/mariadb/m
NAME                        USED  AVAIL     REFER  MOUNTPOINT
zroot/pot/jails/mariadb/m   476M  5.68G     1.34G  /opt/pot/jails/mariadb/m

freebsd-update is a bit more complicated, as in my example I inherited it from freebsd-potluck:
# rm -rf /opt/pot/jails/mariadb/m/var/db/freebsd-update
# zfs list zroot/pot/jails/mariadb/m
NAME                        USED  AVAIL     REFER  MOUNTPOINT
zroot/pot/jails/mariadb/m   476M  5.68G     1.01G  /opt/pot/jails/mariadb/m

As you can see, even though the usage won't go down, REFER went down by over 300MB (so the freebsd base image would shrink by that amount).

this is done for most of potluck flavours


formulary_spec: update API tests to avoid mocking

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Stop mocking the formulary loader method. We just need to set the environment variable so that it knows to load things from the API.
Fix spec that doesn't work with the CoreTap.formula_names. That method assumes that we always have a valid ruby_source_path in the API JSON even though that was optional for a while after launching the API if my memory serves me. It's probably fine to assume this should always be set though and I changed it to use Hash#fetch to give use better error messages if something goes wrong in the future.
Remove unnecessary allow(x).to receive(y).and_call_original in tap spec.
Extracted from https://github.com/Homebrew/brew/pull/16460#discussion_r1451389544

That method assumes that we always have a valid ruby_source_path in the API JSON even though that was optional for a while after launching the API if my memory serves me. It's probably fine to assume this should always be set though and I changed it to use Hash#fetch to give use better error messages if something goes wrong in the future.

Yeah was likely the cause of https://github.com/orgs/Homebrew/discussions/4701 and https://github.com/orgs/Homebrew/discussions/4750, but it's been like that for a while now

If we wanted to be really cautious, we could just skip any values that don't have this anymore but I assume the time to do that has passed.

The fix would be more defaulting to something like new_formula_path but yeah this isn't going to be a concern once we drop v2 anyway.

Thanks @apainintheneck!


rule app: link to ATT&CK tactic

when a rule has a reference to an ATT&CK tactic, we should make the link clickable, to the relevant page on the ATT&CK website.


[#44] [iOS] [Integrate] As a user, I can start my survey

Close #44

What happened 👀

Add logic to SurveyDetailViewModel in the shared module
Add a wrapper SurveyDetailCombineViewModel for SurveyDetailViewModel in iOS module.
Update the logic to add an accessibility identifier for view.
Add UT and UI test.

Insight 📝
Integrate Survey detail screen to display survey's title, description and background image.
Proof Of Work 📹
https://github.com/nimblehq/avishek-phong-kmm-ic/assets/22606906/39840fe6-9488-495f-b6b6-b3cce0ef4659

I think we have some commits from another PR. Would you rebase this one with develop once?


Fail build on warnings

This PR prepares time for SpineEventEngine/config#122.
It makes sure that the build yields no warnings.

@armioll, PTAL.


respect user-provided multiple regexes for allowUnmocked and match

Fixes https://github.com/node-nock/nock/issues/835
This was an issue for me as I'm hardly using hardcoded strings due to dynamic hosts and urls, so regex matching is preferable.
Happy to write regression tests for this if it is expected behavior. (Looking at the docs, myself and others seem to think this should work out of the box)

Coverage decreased (-0.05%) to 92.605% when pulling a937c71ac95e4b5d6fd6ac6c926f09f54c09b4da on cmswalker:835-RegExp-Inconsistencies into 8da9ee0d96dba9e6e6b541196e17d5739918e2b6 on node-nock:master.

Coverage decreased (-0.05%) to 92.605% when pulling a937c71ac95e4b5d6fd6ac6c926f09f54c09b4da on cmswalker:835-RegExp-Inconsistencies into 8da9ee0d96dba9e6e6b541196e17d5739918e2b6 on node-nock:master.

Coverage decreased (-0.05%) to 92.605% when pulling a937c71ac95e4b5d6fd6ac6c926f09f54c09b4da on cmswalker:835-RegExp-Inconsistencies into 8da9ee0d96dba9e6e6b541196e17d5739918e2b6 on node-nock:master.

Will do asap

@gr2m please see new PR https://github.com/node-nock/nock/pull/973

done via https://github.com/node-nock/nock/pull/973


Domino API in XPINC

I am trying to use the domino api (and the last version of extension library too) in a XPINC application, and when I try to run and test the application in one of my clients I get an error that the application is not able to load the library.
I my developer pc all works as expected but in the client pc does not work. I read the chapter in the extension library book in wich details how to make a widget in order to install the library in the clients, but all the procedures detailed in the book did not work.
It is a way on how can install the libraries in the clients? can I make a manual copy of these libraries?
Thanks.

Hrm, diagnosing problems with policies are always tricky, but I can say that the policy+widgets route has indeed worked for me in the past, as described here: https://www-01.ibm.com/support/knowledgecenter/#!/SSKTMJ_9.0.1/admin/inst_deployingclientpluginswithwidgetsandthewidgetcat_c.dita https://www-01.ibm.com/support/knowledgecenter/#!/SSKTMJ_9.0.1/admin/inst_deployingclientpluginswithwidgetsandthewidgetcat_c.dita . I suspect that the trouble you’re having is somewhere in that setup.

On Oct 22, 2015, at 10:40 AM, Luis<EMAIL_ADDRESS>wrote:
I am trying to use the domino api (and the last version of extension library too) in a XPINC application, and when I try to run and test the application in one of my clients I get an error that the application is not able to load the library.
I my developer pc all works as expected but in the client pc does not work. I read the chapter in the extension library book in wich details how to make a widget in order to install the library in the clients, but all the procedures detailed in the book did not work.
It is a way on how can install the libraries in the clients? can I make a manual copy of these libraries?
Thanks.
—
Reply to this email directly or view it on GitHub https://github.com/OpenNTF/org.openntf.domino/issues/139.

Also, on the relevant PC, check Help > Support > View Log and Help > Support > View Trace. The Notes Client itself writes a lot of information there, so there is likely to be quite a number of log entries, even if Notes has only recently been started. If there are any ODA-related messages logged there, can you please add them to the issue - they may help identify where the problem lies.

Hello again, thanks you bouth for your responses and sorry for the delay in my response. The installation plugin is woriking now, but I have to wait to the my admin it sector for recreate the policy and the widget and try again from the scratch follow de advice of mr. Gallagher.
We recreate the widget and the policy but nothing happens. In the lotus client progress bar onldy show "Widget Provisioning" but nothing else happens. In the Help -> Support -> View Trace, there was nothing realted with ODA or Extension Library.
So, in the end we check the client configuration (in the Online Location, Online -> Edit Locations -> Online) and found that in the Server Section was missing the name of the domain server in some of the textbox available there. We complete the textobox with the name of our server, restart the cliente and the plugin work as expected. The library is installed and work in the client.
Thanks you very much for your support!!


How to add schema files to container

Hey,
I'm trying to emulate a windows AD => LDAP setup, and in the process I have obtained the schema files for windows items.
However, getting them added to the schema is causing me some troubles. Any chance on providing a quick instruction on how to accomplish this?

Hi,
Well it is hard to help if I do not know what's the problem.
You can make a look on the existing object's setup and try to clone them.
Best Regards,
David.


zodios plugin and exactOptionalPropertyTypes

What version of kubb is running?
v2.23.2
What platform is your computer?
Windows
What version of external packages are you using(@tanstack-query, MSW, React, Vue, ...)
@zodios/core
What steps can reproduce the bug?
tsconfig.json:
 "exactOptionalPropertyTypes": true,

Typescript failure
$ npx tsc -p tsconfig.json

How often does this bug happen?
None
What is the expected behavior?
The zodios API file should generate valid typescript for strict modes as the zod plugin does.
Swagger/OpenAPI file?
No response
Additional information
The zodios code generator has a mismatch for the description type in the endpoints:
Generated:
description?: string | undefined;

Expected:
description?: string;

From typescript and kubb generated Zodios:
node_modules/@zodios/core/lib/index.d.ts:394:124 - error TS2344: Type '[...T, { name: Name; type: "Header"; description?: string | undefined; schema: Schema; }]' does not satisfy the constraint 'ZodiosEndpointParameter[]'.
  Type 'T[number] | { name: Name; type: "Header"; description?: string | undefined; schema: Schema; }' is not assignable to type 'ZodiosEndpointParameter' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
    Type '{ name: Name; type: "Header"; description?: string | undefined; schema: Schema; }' is not assignable to type 'ZodiosEndpointParameter' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
      Types of property 'description' are incompatible.
        Type 'string | undefined' is not assignable to type 'string'.
          Type 'undefined' is not assignable to type 'string'.

From zodios
export type ZodiosEndpointParameter<T = unknown> = {
  /**
   * name of the parameter
   */
  name: string;
  /**
   * optional description of the parameter
   */
  description?: string;
  /**
   * type of the parameter: Query, Body, Header, Path
   */
  type: "Query" | "Body" | "Header" | "Path";
  /**
   * zod schema of the parameter
   * you can use zod `transform` to transform the value of the parameter before sending it to the server
   */
  schema: z.ZodType<T>;
};

Closing this as this is a zodios type bug, not an issue in Kubb.


[FEAT] Clear Errors in State

:bulb: Feature request
Feature Name

Clear Errors in State
The Desired Behavior

I would like a way to clear the errors in the various feature areas of Daffodil.
Your Use Case

As an app dev, I would like to be able to dispatch an action that will clear the errors in a particular feature area's state.

@griest024 please attach the tickets that are blocking once created.

blocked by #2660 and #2659