Minor changes (typos, keep up with rust stable)

Nothing big here: Just changes I did locally while skimming through the code: std::process::exit is stable now and one or two typos. Feel free to ignore if not useful.
Looks like a nice job btw :+1:.

Coverage remained the same at 99.632% when pulling 2328bf948f497d8bee0b1886a103e5afcf4cd03e on Liamsi:master into 3767677b9d5efe1f7c7ba9e9aca5ef783bd5cc35 on freedomofpress:master.

Great @Liamsi. Thanks for the quick code skim.
Since you worked on some of the cothority JVSS code, did you look at the interpolation code an Gf implementation? Thoughts on that?

Hi FredericJacobs,
no, I didn’t really have a detailed look into the GF generation, nor at the interpolation implementation. Like with the rest of the code I just skimmed through it: I found the way to write the generated code into a rust file (and include it) confusing on first sight but clever (maybe a test that asserts the expected table could help here, might also be exaggerated).
Anyways, I scanned through it more thoroughly: the generated file (nothinghardcoded.rs) looks fine (the log[0]=0 made me think there must be sth. wrong but the log function looks correct; returns None in this case). What I didn’t understand: why to generate inv: it is never used (I just removed it locally and everything works as before). I would not generate it, if there are no plans to ever use it (can send you a PR for that later).  The lagrange interpolation looks correct (and exactly like the non-optimized version in the wikipedia article). As it is always only called with zero as a 2nd parameter, one could simplify the interpolation  further by removing it (see here: https://github.com/Liamsi/RustySecrets/commit/c84666aaec3173b4d56bd51fd71dba0393c77ab9)
I wouldn’t trust my opinion (only): My contribution to the cothoritiy’s JVSS code was merely to make it race condition free. The JVSS protocol was recently rewritten by @Daeinar, while @nikkolasg wrote most of it, and he also wrote parts of underlying crypto in dedis’ crypto library necessary for JVSS (so maybe he has more to say). But I would guess that that there are still some levels of abstraction which were already covered by the crypto lib (written by several people at yale and @bford). So I’m sure we didn’t need to take care with the field generation ourselves.
Again: Well done! Was fun reading (and writing) some Rust code again :-)

Hi again, I'm not sure anymore the gf256 generation/implementation works as it should. I wrote two small tests that checks against the multiplication in GF(2^8) examples here: http://www.site.uottawa.ca/~chouinar/Handout_CSI4138_AES_2002.pdf and they fail. If you have some time I can come by (probably I got sth wrong and the code is fine).

Good idea, I'll add some Gf(2^8) external test vectors and see if those work.

Good idea, I'll add some Gf(2^8) external test vectors and see if those work.

My tests failed because I used the examples from vanilla AES (which uses a different polynomial; not 0x11D). I sent you a PR (#6) for the other changes (minor simplifications) I did.


class name not compatible with emmet

The Sublime Text plugin called Emmet allows you to write html in short form and then to expand it into full form using the Tab key. For example:
div.col-md-12

becomes

after pressing the Tab key for completion

This is not possible with Skeleton as spaces between class words are not supported, meaning the whole thing must be typed out manually.
This is more of a feature request that a bug

in Emmet, div.twelve.columns will expand to

Agreed, I was coming at this from the point of view of someone who is used to the bootstrap column definitions and is used to typing them in. In the future there may be competing skeleton packages, it might make adoption of this package easier if it seemed like a mini version of bootstrap or some other popular framework rather that introducing a new set of class names into the mix with people who are already accustomed to bootstrap/foundation/semantic-ui class naming conventions?


Install Instructions Should Give Some Indication of the Size/Time of the Install Process

The installation section gives no indication of the size or length of time required to install the tool. Specifically, the install involves a download of a large file which takes a long time, especially with a slow internet connection. Furthermore, I am installing on Windows using NPM, but NPM compounds the problem by not giving me any progress information for the download. It is therefore hard to determine whether the download is just taking a long time or whether it has crashed/locked up. A warning of the large file size and/or approximate download time would alleviate this problem.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b2646ad4-34b7-fc5e-dcc9-d53a061df394
Version Independent ID: bbff4fda-24e4-2b62-24b9-94cda5f53bed
Content: Work with Azure Functions Core Tools
Content Source: articles/azure-functions/functions-run-local.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@bogan You should be able to see some progress like this but I do understand the concern.

Note that the npm package is just a simple post install script that fetches a specific release of functions core tools.
I believe a note mentioning this near the npm install command should be helpful.

@bogan Just following up here... Hope my previous comment helps.
We are assigning this issue to the content author to review and update accordingly.


tabs jumping

Hey guys,
Not sure why this is happening by during the debugging process - often and intermittendly the tabs located at the bottom of my screen will move to the top of my screen. Any idea how I can fix this?
Btw, thanks for an awesome product.
Thanks

My rightmost tab also gets focus periodically, I have no chance to examine code while the debugger is active.

@martomo ping. This is a serious issue, the editor becomes unusable, when debugging is started.

I've found that this can be replicated by following these steps:

Start a debugging session
Change the height of the debugging window (either larger or smaller)
Perform a Step Into / Out / Over (using their hotkeys or from the menu)
Boom, the Xdebug tabs appears in the main window.

same here

What @andrewholgate  describes happens to me too alöl the time. I was hoping this was solved with the last update. :/


prompt_toolkit 0.53 is also fine

Fixes package build for Ubuntu trusty

Pushed some commits to support all prompt_toolkit versions >= 0.53


[Feature request] Run scenarios in a feature by mentioning line numbers

Proposal
Ability to run scenarios by mentioning feature_path:line_number. This is a pretty common usecase in Cucumber.Js and would be very useful to have this feature.
Config should accept list of scenarios like this -
"gherkin": {
  "features": [
    "./features/home.feature:12",
    "./features/home.feature:41",
    "./features/search.feature:23",
  ],
  ...
}

@DavertMik I'm happy to raise a PR if you're cool with introducing this feature. WDYT?

@VaasRamsay if you are still here PR is still appreciated
however, I better close this issue to not have it stuck


This pull request fixes issue #1063

Thank's for the PR, but would this not now allow anyone to generate a session cookie given prior knowledge of the username?  Perhaps taking the hash of the UserModel object would provide sufficient entropy.

Perhaps the UserModel object without its password, @paulsputer ?

I don't think the presence of the password will make it less secure; SHA1 is an avalanching hash.  I do think the hash of the UserModel is an improvement.

Are you guys suggesting something like?
user.cookie = StringUtils.getSHA1(String.valueOf(user.hashCode()));

Given that User.hashCode() hashes only the username it will have the same session hijacking security issue.  Hashing other attributes of the UserModel would help minimize this risk.  However, we must then consider the side effects.  i.e. hashing permissions would cause session refresh on permission changes.
It's also worth considering the statistics here.  Hashkiller has only 44E+9 of the possible 1.46E+48  hashes yet if we're only hashing usernames there will be far fewer permutations given assumptions about username construction and depending on configuration, usernames may be visible anyway.  So there are many easier ways to get in.  Also you may like to check out the RPC to make sure that's not allowing information leakage which could such aid attacks. ;)
Probably the most appropriate solution would be to generate a collection of random bytes and use that.   It could be useful to allow the UserModel to generate it's cookie to avoid replication of the generation logic.

However, we must then consider the side effects. i.e. hashing permissions would cause session refresh on permission changes.

True, but actually that would be a good thing because permission changes should invalidate the existing cookie and create a new one.
Since the cookie is stored on the server, it doesn't need to contain any information, it could be completely random, isn't it? I don't see the cookie getting reconstructed anywhere on the server.

Gitblit uses server-side sessions.  The cookie is used to identify an account, but nothing more.  I'm pretty sure that permissions are updated on each incoming request so if an admin changes them, the user should immediately see those changes without a logout/login cycle.

I also have an interest in tightening security for Gitblit, so I would advocate for an change of cookie creation. Can we close this PR in favour of #1116 which uses only a random value?
I could also offer a new PR with the added change that it uses SecureRandom from Bouncy Castle, plus setting a secure cookie if only HTTPS is used. The latter may have to be an option for weird forwarding cases, do you think?

Closing this pull request in favour of new pull request #1116 which uses a pure random cookie.


Make command available

How to make this command available in command line?

Make sure ~/.cabal/bin is in your path


URL at the top of page does not work (https://www.explore.ms/)

HI Microsoft.
This URL isn't working.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 611ff5f6-f273-bf7c-d959-83cd4f07168e
Version Independent ID: f1d1ea8e-b66b-0c73-5375-6e38ef8aca2b
Content: Azure EA agreements and amendments
Content Source: articles/cost-management-billing/manage/ea-portal-agreements.md
Service: cost-management-billing
GitHub Login: @bandersmsft
Microsoft Alias: banders

@kknight-valorem Thanks for bringing this to our attention. We are actively investigating and will get back to you soon.

@bandersmsft FYI.

@kknight-valorem Thanks, Ken for pointing out this issue. We've updated the article to remove the link with https://github.com/MicrosoftDocs/azure-docs-pr/pull/124850.
#please-close


No error message on singular glob path

I'm on version 4 and yet get no notification when there is no corresponding file for a singular glob pattern.

Example repo?

Confirmed:
var gulp = require('gulp');

gulp.task('default', function () {
	return gulp.src('somefile.txt')
		.pipe(gulp.dest('someotherfile.txt'));
});

Doesn't throw an error.

Also, I think it should show some warning where there is no corresponding file for a plural pattern. It's rare that the developer specify a pattern without any corresponding files. A warning had no deleterious effect but can save huge debugging time.

I just installed latest gulp 4.0 (both globally and locally) and I get the singular glob error as expected:
Error: File not found with singular glob

My gulp versions:
gulp-testing$ gulp -v
[16:48:03] CLI version 0.4.0
[16:48:03] Local version 4.0.0-alpha.1

And the repo to check it out yourself.

Your repo is working fine for me and throwing the error as expected

@vbud The repo returns a not clear error:
D:\lab\gulp\gulp-testing>gulp test
[07:01:12] Using gulpfile D:\lab\gulp\gulp-testing\gulpfile.js
[07:01:12] Starting 'test'...
[07:01:12] 'test' errored after 21 ms
[07:01:12] Error: File not found with singular glob
    at Glob.<anonymous> (D:\lab\gulp\gulp-testing\node_modules\gulp\node_modules\vinyl-fs\node_modules\glob-stream\index.js:34:30)
    at Glob.emit (events.js:95:17)
    at Glob._finish (D:\lab\gulp\gulp-testing\node_modules\gulp\node_modules\vinyl-fs\node_modules\glob-stream\node_modules\glob\glob.js:172:8)
    at done (D:\lab\gulp\gulp-testing\node_modules\gulp\node_modules\vinyl-fs\node_modules\glob-stream\node_modules\glob\glob.js:159:12)
    at Glob._processSimple2 (D:\lab\gulp\gulp-testing\node_modules\gulp\node_modules\vinyl-fs\node_modules\glob-stream\node_modules\glob\glob.js:652:12)
    at D:\lab\gulp\gulp-testing\node_modules\gulp\node_modules\vinyl-fs\node_modules\glob-stream\node_modules\glob\glob.js:640:10
    at Glob._stat2 (D:\lab\gulp\gulp-testing\node_modules\gulp\node_modules\vinyl-fs\node_modules\glob-stream\node_modules\glob\glob.js:736:12)
    at lstatcb_ (D:\lab\gulp\gulp-testing\node_modules\gulp\node_modules\vinyl-fs\node_modules\glob-stream\node_modules\glob\glob.js:728:12)
    at RES (D:\lab\gulp\gulp-testing\node_modules\gulp\node_modules\vinyl-fs\node_modules\glob-stream\node_modules\glob\node_modules\inflight\inflight.js:23:
    at f (D:\lab\gulp\gulp-testing\node_modules\gulp\node_modules\vinyl-fs\node_modules\glob-stream\node_modules\glob\node_modules\once\once.js:17:25)

It does not say which file is not found.

@salarmehr I agree, these error messages could be much more helpful.
It would be helpful to see the glob string for debugging purposes.

Oddly, when I copy exactly same file to my current project and run gulp test it does not return any error.
D:\www\project>gulp test
[07:27:22] Using gulpfile D:\project\gulpfile-.js
[07:27:22] Starting 'test'...
[07:27:22] Finished 'test' after 17 ms

Have you done an npm update in that project to get the latest state of the gulp 4.0 branch?

doning npm update now I see the Error: File not found with singular glob  error.  However it stops gulp in my main project. I don't know which  file is missing ◕︵◕

@salarmehr There is actually a change for that in https://github.com/gulpjs/glob-stream/commit/7da2da06ee6b10cc941f4167c45216d4358baf15 but it hasn't been versioned and released yet.  I am not sure if we can safely bump a patch version due to some other commits.


Can't completing the checkout without additional payment action for digital product

What I'm trying to achieve
Create and complete the checkout without additional payment action for a digital product.
Steps to reproduce the problem
Use: $DOMAIN/graphql/

Creating a checkout session

mutation {
    checkoutCreate(
      input: {
        channel: "vn",
        email<EMAIL_ADDRESS>        lines: [{ quantity: 1, variantId: "UHJvZHVjdFZhcmlhbnQ6Ng==" }]
        billingAddress: {
          firstName: "My first name"
          lastName: "My last name"
          streetAddress1: "12 Quang Trung, Gò vấp"
          city: "Hồ Chí Minh"
          country: VN
        }
      }
    ) {
      checkout {
        id
        token
        totalPrice {
          gross {
            amount
            currency
          }
        }
        isShippingRequired
        shippingMethods {
          id
          name
          active
          message
        }
        availableCollectionPoints {
          id
          name
          clickAndCollectOption
        }
        availablePaymentGateways {
          id
          name
          config {
            field
            value
          }
        }
      }
      errors {
        field
        code
      }
    }
  }

Completing the checkout without additional payment action

  mutation {
    checkoutComplete(
      token: "5a10a4eb-573d-4db3-93dc-e222c1a7e95a"
    ) {
      order {
        id
        status
      }
      errors {
        field
        message
      }
    }
  }

Response

{
  "data": {
    "checkoutComplete": {
      "order": null,
      "errors": [
        {
          "field": null,
          "message": "Provided payment methods can not cover the checkout's total amount"
        }
      ]
    }
  },
  "extensions": {
    "cost": {
      "requestedQueryCost": 0,
      "maximumAvailable": 50000
    }
  }
}

What I expected to happen
completing checkout and creating a new order from this checkout.
System information
Saleor version:

[ ] dev (current main)
[x] 3.5.0-a
[ ] 3.0
[ ] 2.11
[ ] 2.10

Saleor configuration:

[x] replica

Operating system:

[ ] Windows
[x] Linux
[ ] MacOS
[ ] Other

Product information

[x] Digital

Pricing:

Channel Name
Selling Price
Cost price

VN
140000
0

Inventory:

SKU
Variant currently in preorder
Track Inventory

pro
false
false

Warehouse Name
Allocated
Quantity

Global
0
0

I am currently using https://docs.saleor.io/docs/3.x/developer/checkout#creating-order-from-checkout to instead

@nnthuan we recommend using these two mutations for payments
https://docs.saleor.io/docs/3.x/developer/checkout#creating-order-from-checkout
https://docs.saleor.io/docs/3.x/developer/api-reference/objects/transaction-create
We are going to release payments guide soon, meantime you can use this payment app for reference https://github.com/saleor/saleor-checkout/tree/2ac594d88092951051212911b6c5ce3f2376674d/apps/checkout-app/pages/api/webhooks

@timuric Thanks for your support.


feat(TypeScript): enable 'strictNullChecks' option

Pros

This would make our code base more solidly, more clearly to decrease a bug.
This option enables full control-flow basis analysis of tsc.

This option is introduced from tsc 2.0.

Cons

We may need change a public signatures as breaking change.

cc: @david-driscoll @kwonoj

I'm absolutely for this in theory--huge advocate for non-nullable types. I'm mostly worried about consumers of RxJS who don't have strictNullChecks enabled. Presumably they will still be able to pass null against our TS definitions right? i.e. this is mostly for our internal sake?
Off hand I can't think of any signatures we would want to accept null as valid. We sometimes call having no scheduler the "null scheduler" but this is really a misnomer IMO and I'd like to stop doing that. Can anyone think of any?

Presumably they will still be able to pass null against our TS definitions right? i.e. this is mostly for our internal sake?

: I expect same behavior. this option's affecting compile time behavior, I don't think it can control consumer's compile time options.

Off hand I can't think of any signatures we would want to accept null as valid.

: Maybe someone might use null where undefined as valid value as well?

@jayphelps

I'm absolutely for this in theory--huge advocate for non-nullable types. I'm mostly worried about consumers of RxJS who don't have strictNullChecks enabled. Presumably they will still be able to pass null against our TS definitions right? i.e. this is mostly for our internal sake?

Yes. I think this would be a internal sake basically if we don't change public interface signatures.
After we enables strictNullChecks, it would be a problem if the consumer of RxJS compiles their codes & rxjs's raw TypeScript code without strictNullChecks.

But I think this is very very rare case. Almost (maybe ~99.9%) consumers uses only rxjs via npm with bundled d.ts.

In the following case,

It would not be a compile error if the consumer disable strictNullChecks.
It would be a compile error if the consumer enable strictNullChecks.

Thus I think that there would not be a problem if we don't change public interface.
// bar.d.ts
export function bar(a: number): void;

// consumer's code
import {bar} from 'bar';

bar(1);
bar(null); // compile error with `strictNullChecks`
bar(undefined); // compile error with `strictNullChecks`


fix: added error handling for validate command

Description

Added a trycatch block for validate which does not exit the process instead logs a general message for checking the invalid file.

Related issue(s)

Resolves #591

@chinma-yyy you have some lint issues.

Done

Fixed due to #616


'internal error: entered unreachable code: Cannot flatten a dynamic array' when adding if

Aim
Sometimes adding some if statements leads to more checks needed on notes or it fails compiling with:
'internal error: entered unreachable code: Cannot flatten a dynamic array'.
This is fixed by utilizing the Aztec note ONLY inside an if statement that checks that the note exists:
Works:
    let options = NoteGetterOptions::new().select(1, from.address).set_limit(1);
    let note = stored_set.get_notes(options)[0];
    if (note .is_some()) {
        stored_set.remove(note.unwrap_unchecked());
    }

Doesn't work:
    let options = NoteGetterOptions::new().select(1, from.address).set_limit(1);
    let note = stored_set.get_notes(options)[0];
    assert(note.is_some());
    stored_set.remove(note.unwrap_unchecked());

Expected Behavior
Asserting that the note exists should be the same as using it inside an if statement.
Even if the note is not asserted, the error should be more expressive into what the actual issue is.
Bug
Code:
https://github.com/drgorillamd/aztec-big-gist/tree/feat/array-in-struct/src
Error:
'internal error: entered unreachable code: Cannot flatten a dynamic array'
This bug only happens when adding if statements. In the code sent, removing the if from the start of the function makes the contract compile:
        if (from.address != context.msg_sender()) { // commenting out this fixes compilation
            assert_current_call_valid_authwit(&mut context, from);
        }

To Reproduce
Repo with the reproduction: https://github.com/drgorillamd/aztec-big-gist/tree/feat/array-in-struct/src
Installation Method
None
Nargo Version
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response

Would you be able to provide a smaller more up-to-date example? We recently had a fix that I think is related to this issue but the project is using compiler version 0.18.0 and old versions of aztec-nr so it is difficult to reproduce.

@drgorillamd Thank you for the update! I'm assuming you are using 0.24.0 of aztec-packages. The recent fix has not yet been released but it is on master. I can successfully compile the supplied contract with the fix on master. Going to close this issue as it has been fixed but please do re-open it if after the release you are still running into issues.


Added support for passing in --no-autodetect to sauce connect proxy

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.cahrens seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add version in operator status

Signed-off-by: Jian Qiu<EMAIL_ADDRESS>

/assign @yue9944882

@qiujian16 is this for the print column? i guess the new clusteradm get hub-info command is sufficient for printing the version?

also for the upgrade case, that we can know the previous version.

also for the upgrade case, that we can know the previous version.

@qiujian16 will this work for vendor customized version? e.g. conventionally we extend a platform version suffix after the semver vX.Y.Z.vendor.1

I think we would read version in version.go. So yes if the customized version is added in ldflag.


Missing extension marker bit for non-member types in UPER.

I’ve have a problem that the UPER encoder and decoder neither consume nor insert the extension bit for data types with no members except the extension marker.
MyModule DEFINITIONS AUTOMATIC TAGS ::=
BEGIN
MyType ::= SEQUENCE {
        ...
}
END

I haven’t tested the behavior for any of the other decoders.

Please review the above patch, as I don't know if my solution to add extensions-only sequence types are water proof.


You must specify a value in the directive. - is it possible to be able to pass empty v-permission ?

I have a situation that I need to pass empty permission
but I keep getting the console.error You must specify a value in the directive.
so is this a must or this would be just a warning and is there a way to make the warning disappear ?
thanks

it's just a warning, not an error. You can use v-permission with an empty value.


Hamburger Menu on Docs Page Not collapsing

Describe the bug
Hamburger Menu on Docs Page does not collapse.
To Reproduce
Steps to reproduce the behaviour:

Go to 'https://appsody.dev/docs'
Open Hamburger menu
Click any link
Open Hamburger menu again
Close Hamburger menu
See the error

Expected behavior
Hamburger menu should close when the toggle button is clicked.
Actual behaviour
Hamburger menu does not close when the toggle button is clicked.

This issue is with React-Bootstrap which we are using. https://github.com/react-bootstrap/react-bootstrap/issues/541
I think we can write our own javaScript to solve this issue.

This issue will be fixed by https://github.com/appsody/website/issues/335


Gradle fails catastrophically on multi-release jars with unsupported Java versions

Expected Behavior
When Gradle encounters a multi-release jar (https://openjdk.org/jeps/238) with a Java version under META-INF that is not recognized by that version of Gradle, Gradle should just ignore the unrecognized version and continue working.
Current Behavior
After upgrading jackson-core to 2.15.0, Gradle 7.4.2 failed with these errors:
Failed to create Jar file /home/jenkins/workspace/ourProject/.gradle/caches/jars-9/bc33e077f18aab4d8905d3690c9e67e4/jackson-core-2.15.0.jar.
16:31:39  Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 63
Because the failure was complete, we couldn't use Gradle to try to debug the problem. For example, ./gradlew dependencies failed with the same "Failed to create Jar file" error.
Context (optional)
No response
Steps to Reproduce
Create a project with a dependency on jackson-core 2.15.0 and Gradle 7.4.2, then try to run ./gradlew dependencies.
Gradle version
7.4.2
Build scan URL (optional)
No response
Your Environment (optional)
No response

Sorry that you're having trouble with Gradle!
We appreciate the effort that went into filing this issue, but we must ask for more information.
As stated in our issue template, a minimal reproducible example is a must for us to be able to track down and fix your problem efficiently. Our available resources are severely limited, and we must be sure we are looking at the exact problem you are facing.
If we have a reproducer, we may be able also to suggest workarounds or ways to avoid the problem.
The ideal way to provide a reproducer is to leverage our reproducer template. You can also use Gradle Project Replicator to reproduce the structure of your project.
This issue will be closed after 7 days unless you provide more information.

Please provide details about the environment you experience this problem in, especially the Java version you use to run Gradle (and possibly any toolchain versions you use). We suspect your problem to be not completely generic, hence asking for a concrete reproducer.


Whether the Grid component can support a state with no selected items.

Add an autoSelect property to control this, or allow the selectedItemId to be empty so that the Grid can have no selected items.
Because when developers use the onSelectionChange event to do something, the presence of the default selected item makes it necessary for the user to click on another Grid.
Describe the feature and the current behavior/state.
Grid component must currently have a current selected item.
Who will benefit from this feature?
Everyone.

the presence of the default selected item makes it necessary for the user to click on another Grid.

I don't really understand what you mean by this - but it's unlikely that we are going to make the Grid have no selected item. It's necessary to navigate with the keyboard which is the preferred method to interact with Raycast


[FEATURE] Add depandabot

Description
"Integrating Dependabot into our open-source project will automate dependency updates, ensuring we stay up-to-date with the latest security patches and feature enhancements."
"By leveraging Dependabot's automated pull requests for dependency updates, we can reduce the burden on maintainers and foster a more secure and stable codebase."
"Adding Dependabot as a dependency management tool will demonstrate our commitment to maintaining a healthy ecosystem, allowing contributors to focus on higher-value tasks while keeping our project dependencies secure and reliable."
Screenshots

Additional information
No response

Are you a GSSOC'23 participant?

yes


Fix uptime not being checked for known neutral/avoid representatives

includes uptime discrepancy corrections (when weekly uptime is out of date with daily uptime, or rep is up but weekly uptime is 0%)
includes temporary switch from weekly to monthly uptime (until issues are resolved)

includes temporary switch from weekly to monthly uptime

I think monthly would be generally better imo because a rep may be down for a few days e.g. if hardware blasted or whatever, which takes time to fix


Custom picker: Show differently pictures that are currently being uploaded

Description (required)
Fixes #5277
What changes did you make and why?
Tests performed (required)
Tested {build variant, e.g. ProdDebug} on {name of device or emulator} with API level {API level}.

I keep getting this crash with this branch:
https://github.com/commons-app/apps-android-commons/assets/99590/d1058889-7352-4e5f-b31d-fea5922fd778
STACK_TRACE=java.lang.IllegalStateException: Cannot access database on the main thread since it may potentially lock the UI for a long period of time.
at androidx.room.RoomDatabase.assertNotMainThread(RoomDatabase.kt:435)
at androidx.room.RoomDatabase.query(RoomDatabase.kt:476)
at androidx.room.util.DBUtil.query(DBUtil.kt:75)
at fr.free.nrw.commons.contributions.ContributionDao_Impl$7.call(ContributionDao_Impl.java:1467)
at fr.free.nrw.commons.contributions.ContributionDao_Impl$7.call(ContributionDao_Impl.java:1464)
at androidx.room.RxRoom$5.subscribe(RxRoom.java:232)
at io.reactivex.internal.operators.single.SingleCreate.subscribeActual(SingleCreate.java:39)
at io.reactivex.Single.subscribe(Single.java:3603)
at io.reactivex.Single.blockingGet(Single.java:2834)
at fr.free.nrw.commons.customselector.ui.selector.ImageFragment.handleResult(ImageFragment.kt:272)
at fr.free.nrw.commons.customselector.ui.selector.ImageFragment.onCreateView$lambda$1(ImageFragment.kt:203)
at fr.free.nrw.commons.customselector.ui.selector.ImageFragment.$r8$lambda$S7kzNRAlIUqfrtaQwFc4UhtsOKM(Unknown Source:0)
at fr.free.nrw.commons.customselector.ui.selector.ImageFragment$$ExternalSyntheticLambda0.onChanged(Unknown Source:4)
at androidx.lifecycle.LiveData.considerNotify(LiveData.java:133)
at androidx.lifecycle.LiveData.dispatchingValue(LiveData.java:151)
at androidx.lifecycle.LiveData.setValue(LiveData.java:309)
at androidx.lifecycle.MutableLiveData.setValue(MutableLiveData.java:50)
at androidx.lifecycle.LiveData$1.run(LiveData.java:93)
at android.os.Handler.handleCallback(Handler.java:959)
at android.os.Handler.dispatchMessage(Handler.java:100)
at android.os.Looper.loopOnce(Looper.java:232)
at android.os.Looper.loop(Looper.java:317)
at android.app.ActivityThread.main(ActivityThread.java:8501)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:878)

Sure

@nicolas-raoul I Fixed the crash,  Please Review

@nicolas-raoul did that Fail while the custom Image Picker?

@nicolas-raoul Fixed it to handle all cases, Please Review

@nicolas-raoul Please Review and Let me know if these changes works as Intended, thanks

Ah sorry it was my mistake, I can see the white arrows now :-)

I also see unnecessary arrows on pics that I uploaded several days ago. Any idea why?

@nicolas-raoul Thanks for spotting the issue, fixed it in the latest commit, please review, thanks

The arrows disappear when disabling then enabling "Show already actioned pictures".
By the way, if not difficult: Ideally pictures that are being uploaded should be hidden when "Show already actioned pictures" is disabled. That would allow the user to focus on pictures that need to be uploaded from now. 🙂 That can be a different GitHub issue.
https://github.com/commons-app/apps-android-commons/assets/99590/3bc55b44-9df7-4850-a4f4-1c8a452a3c86

By the way, if not difficult: Ideally pictures that are being uploaded should be hidden when "Show already actioned pictures" is disabled. That would allow the user to focus on pictures that need to be uploaded from now. 🙂 That can be a different GitHub issue.

@nicolas-raoul
That's a great idea, I think I can fix that in this PR only (no need for a new Issue), that would save quite some time and will also make reviewing easier.

@nicolas-raoul I have completed following in above commits:

Fixed this Issue

The arrows disappear when disabling then enabling "Show already actioned pictures".

Added this Functionality

Ideally pictures that are being uploaded should be hidden when "Show already actioned pictures" is disabled.

Please Review and Merge, Thanks


Please share an example which talks about overriding secureString parameters such as Azure SQL DB connection strings.

How do we override secureString parameters such as connection String?

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 126c00f8-e9d2-4af1-65b1-67a1e5516197
Version Independent ID: 30660b73-1e11-3e1f-f2c8-1daa094a410a
Content: Automated publishing for continuous integration and delivery - Azure Data Factory
Content Source: articles/data-factory/continuous-integration-deployment-improvements.md
Service: data-factory
Sub-service: ci-cd
GitHub Login: @nabhishek
Microsoft Alias: abnarain

@preethamrajk  Thanks for the question! We are investigating and will update you shortly.

Hello  @preethamrajk
You can override in the below way or the recommended approach would be to use the key vault.

Thanks Vijay. I'm using managed identity so there's no need to pass the connectionString as a secret (or via KV). But when I tried to override with clear text, I had gotten an error. (I don't have the error now, sorry) I think this is because of the arm template default parameterization which requires any connectionString to be a secureString. Please correct me if I'm wrong.Can you pls confirm that the process you showed in the video below allows the publish of the arm template (with connection string overriden in clear text) to other ADF instances?Also, I'm using the ADFUtilities npm tool to generate the arm template so that I can use both extract and deploy using a yaml based pipeline.Thanks,PreethamOn 10 Sep 2021 3:13 pm, Svijay-msft @.***> wrote:
Hello  @preethamrajk
You can override in the below way or the recommended approach would be to use the key vault.
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

If possible, you could share the error. Also, if you need further assistance could you please create a support ticket for this issue. So that support engineer can take a deeper look into this to help.
Please Note, GitHub forum is specifically for logging document feedbacks or doc issues.
How to create support request: https://docs.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request


Summary info not show correctly

Maybe it's caused by scan API change

Fixed with : https://github.com/Charlie85270/conflux-pos-pools/commit/c19d73f8e79f48550268b9cfd014970b742ffda7


Support CMake/Make in addition to Bazel

I get the following error when I run the example of the readme.md:
$ go run main.go
# github.com/irfansharif/solver/internal
wrapper.cc:355:10: fatal error: ortools/base/basictypes.h: No such file or directory
 #include "ortools/base/basictypes.h"
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Are you using bazel for your build? For now this library comes with the caveat that you need to use bazel (though PRs to make it work with make/etc. are welcome, just not something I'll get to until a month or two). https://github.com/irfansharif/allocator/tree/210808.debuggability is an example of a package that uses this library if you want pointers on how.

Can you please give an example/advice how to build a project with this library as a dependency?
(with the included top Makefile a project like the following main.go is not working)
package main

import (
	"github.com/irfansharif/solver"
	"log"
)

func main() {
	model := solver.NewModel("test")

	var numVals int64 = 3
	x := model.NewIntVar(0, numVals-1, "x")
	y := model.NewIntVar(0, numVals-1, "y")
	z := model.NewIntVar(0, numVals-1, "z")

	ct := solver.NewAllDifferentConstraint(x, y, z)
	model.AddConstraints(ct)

	result := model.Solve()
	log.Printf("optimal result: %v", result.Optimal())
	log.Printf("x: %v, y: %v, z: %v", result.Value(x), result.Value(y), result.Value(z))
}

https://github.com/irfansharif/allocator is one example (https://github.com/smcheema/allocator is a fork using a more recent version of this library).

Thank you very much.

I agree with @RobinKamps , it would be most welcomed to have something simpler for compiling with dependencies.
Go is the promise is a simple toolchain and I feel like "pre go" times with bazel & makefile & long compile time.

Ok, I understand. I surmise this is the kind of work they have done with the sqlite3 wrap. Thks for your answer.


runplus - Add lock indicator to karvonen screen

To do this cleanly I did refactor the karvonen code into a library. @thyttan Do you have an opinion on changing to a library and requiring it?

Don't believe I have any objections against switching to require. IIrc you guided me to the current solution🙂

I took it for a run the other day also - worked well!


feature/213 move pyblish to tools

What's new
Current pyblish-lite fork moved to pype/tools and renamed to pyblish_pype.
Required repos:

pype
pype-config
pype-setup

How to test:
1.) Pull branches feature/213_move_pyblish_to_tools on required repos.
2.) Remove pyblish-lite from ~/pype-setup/repos/.
3.) Run any host as usually and run publish.
Changes connected to this change:

removed pyblish-lite from deploy in pype-setup
changed PYBLISH_GUI to pyblish_pype
added pype/tools to PYTHONPATH in global.json
enivornment PYBLISH_LITE_ALWAYS_EXEC renamed to PYBLISH_GUI_ALWAYS_EXEC

resolves https://github.com/pypeclub/pype/issues/213

works fine. but can we please fix the hound errors?
@mkolar should be done


Sometimes it finishes. Sometimes not.

I was able to get one video to go all the way through the pipe and output successful video results.  Since then I get this error on every other video I try.  All my clips are shot with the same camera and are roughly 4 seconds long.  Any advice would be appreciated.
"Elapsed time: 16.860 [minutes]
2020-08-26 19:16:37,511 - INFO - #models = 0
Traceback (most recent call last):
File "main.py", line 13, in
dp.process(params)
File "/content/consistent_depth/process.py", line 117, in process
return self.pipeline(params)
File "/content/consistent_depth/process.py", line 62, in pipeline
valid_frames = calibrate_scale(self.video, self.out_dir, frame_range, params)
File "/content/consistent_depth/scale_calibration.py", line 184, in calibrate_scale
video.path, colmap.sparse_dir(colmap_dir, 0)
File "/content/consistent_depth/scale_calibration.py", line 74, in make_camera_params_from_colmap
cameras, images, points3D = load_colmap.read_model(path=sparse_dir, ext=".bin")
File "/content/consistent_depth/third_party/colmap/scripts/python/read_write_model.py", line 416, in read_model
cameras = read_cameras_binary(os.path.join(path, "cameras" + ext))
File "/content/consistent_depth/third_party/colmap/scripts/python/read_write_model.py", line 135, in read_cameras_binary
with open(path_to_model_file, "rb") as fid:
FileNotFoundError: [Errno 2] No such file or directory: 'results/GH017205/colmap_dense/sparse/0/cameras.bin'
Done. Your results are saved at /content/consistent_depth/.
Video results are at /content/consistent_depth/results/GH017205/R_hierarchical2_mc/videos/.
Disparity maps are at /content/consistent_depth/results/GH017205/R_hierarchical2_mc/B0.1_R1.0_PL1-0_LR0.0004_BS4_Oadam/depth"

Hi,
#models=0 means that COLMAP fails to register any model. Typically, COLMAP can fail when the sequence doesn't have enough baseline between views, scenes is too dynamic or lack features. You may also consider pre-calibrate your camera intrinsics to facilitate camera registration.


Add Nitrokey identifiers to relevant (Ubuntu) Snaps' udev rules

We should make sure (and test) that firefox/chromium/... snap users are able to use Nitrokeys out-of-the-box or at least have the required configs (or whatever needed) available.
potential template for this: https://support.nitrokey.com/t/nitrokey-fido2-and-fido-u2f-dont-work-on-ubuntu/3957/8 - essentially every devices seems to need a "registration" using the snap-device-helper.
For the Chromium Snap I found: https://bugs.launchpad.net/snapd/+bug/1940467 - and for me this reads like this should "just work" by now, but we've received reports that (specifically for the nkpk) there is need to add the line (pattern) from above to /etc/udev/rules.d/70-snap.firefox.rules - we should verify that it works and maybe document what to do if not...
snapd seems to know us as u2f-device

I think I registered our VID/PID in some snap repository in the very early phase.  I’ll try to find out where.

https://github.com/canonical/snapd/pull/10937


Add documentation for splitscreen on consoles

Marking as a draft until the Geyser PR is merged (https://github.com/GeyserMC/Geyser/pull/3109) just in case any changes occur, mark it as ready once it's up to date 😄


Klarna On Site Messaging badge not rendered sometimes

Is your feature request related to a problem? Please describe.
Hello, I'm following this documentation:
https://docs.klarna.com/conversion-boosters/on-site-messaging/integrate-on-site-messaging/on-site-messaging-for-mobile/on-site-messaging-for-android/
to integrate the On Site Messaging to my app for android, for IOS it works fine. But for android some badge is not render.
When badges is not rendered I got next error in Android Studio Logcat:
ConfigManager: Failed to apply config overrides, exception: Attempt to invoke virtual method 'com.klarna.mobile.sdk.core.io.configuration.model.config.ConfigOverrides com.klarna.mobile.sdk.core.io.configuration.model.config.ConfigOverrides.getApplicableOverrides(java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, com.klarna.mobile.sdk.core.Integration)' on a null object reference

I've tried different SDK versions (2.4.1, 2.6.19, 2.6.22), and problem is reproducible for each.
Describe the solution you'd like
How to solve this, not digging in SDK implementation
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
I'm using it in my react native app, through the bridge.
Thank You

Had an additional debug session and found next issue in network activity:
"stack-trace": "com.klarna.mobile.sdk.core.natives.network.interceptors.SDKHttpHeaderInterceptor.intercept(SDKHttpHeaderInterceptor.kt:7)\nokhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)\nokhttp3.internal.connection.RealCall.getResponseWithInterceptorChain$okhttp(RealCall.kt:201)\nokhttp3.internal.connection.RealCall.execute(RealCall.kt:154)\ncom.klarna.mobile.sdk.core.analytics.AnalyticLogger.c(AnalyticLogger.kt:270)\ncom.klarna.mobile.sdk.core.analytics.AnalyticLogger.b(AnalyticLogger.kt:23)\ncom.klarna.mobile.sdk.core.analytics.AnalyticLogger.b(AnalyticLogger.kt:1)\ncom.klarna.mobile.sdk.core.analytics.AnalyticLogger$logEvent$1.invokeSuspend(AnalyticLogger.kt:17)\nkotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)\nkotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)\nkotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:115)\nkotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:103)\nkotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:584)\nkotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:793)\nkotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:697)\nkotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:684)\n",

Thanks for reporting this issue. In order to make the investigation easier please answer the following questions:

What value you set for KlarnaOSMView.environment? Are you setting it to DEMO?
You mentioned that the badge SOMETIMES does not display. Are you switching between different environments like DEMO, PLAYGROUND, etc.?


Display actual BPM

Need to display actual BPM of tracks.

Wow! just build master branch! Can you, please, publish latest master to chrome store?

It is in the process of being published and waiting for approval.


[GIF Search] Can't paste in to Messages

Extension – GIF Search
Author: @josephschmitt
Description
When pasting the gif in messages, it doesn't display properly.
Steps To Reproduce

Search then copy gif
Paste in to messages.

The current behavior
Shows this:

The expected behavior
Should show this:

Raycast version
Version: 1.35.2
I thought it may be related to 1436, but I don't receive any errors.
I also tested by going in to Preview and creating a new document from the clipboard and that worked fine:

Hmm, that's a weird one. I'm just using AppleScript to copy the downloaded file to your clipboard. @thomaspaulmann any ideas?

FWIW, I was just able to paste into Messages ok...

I just tried a few more gifs to see if it could be image dependent and had the same result still.
macOS 11.6.5 (20G527)
I confirmed with a few friends that they are being received the same way as I see them too.

If I instead open the URL, then copy the gif in Safari, it pastes in to Messages fine.
I use a clipboard manager (Pastebot) - I tried disabling that too, still same issue.
I closed/reopened Messages, no luck.

Is the Raycast clipboard manager on? Maybe it's conflicting?

Raycast clipboard history is disabled.
Pasting in to Slack and this comment works fine.

Weird. Wonder if it's a bug in Messages in macOS 11.

Seems to work fine on macOS 12 ... I tend to wait a few point releases before upgrading haha.


Remove false entries (actual typos) from spell checking allow lists (OSOE-470)

For example, just at the beginning of allow.txt (https://github.com/Lombiq/GitHub-Actions/blob/dev/.github/actions/spelling/allow.txt) there are multiple such entries: Driectory, Drvier, Hidiging. Further review needed to weed out all of them.
Jira issue

I have a hunch these are for typos we don't control and thus can't fix.

Not at all, these specific examples are in our own code and easy to fix.

Then strange.

Is there a way to see all repositories where GHA is used as a submodule? Just to know which solutions need to be looked at and updated.
If this is only concerning allow lists, that means only looking at the allow.txt and expect.txt files?

This most possibly covers OSOCE only, so if you remove an expected typo and fix the typo in the code in one of the submodules there, that should be enough. If you check out the Git history (blame) you'll also see for which issue some expected typo was added, which will hint at where else the typo might be present (if not OSOCE).
Yes.

You can use the GH advanced search to find the occurrences of this word within the Lombiq organization, e.g., org:Lombiq Driectory: https://github.com/search?q=org%3ALombiq+Driectory&type=code

Hidiging

Preganante?

Hidi gang Hidi gang Hidi gang Hidi gang

Autherization, ConfigureMockAutherizationService — these are found in the Finitive solution. Should I A) only remove them from the allow lists or B) also remove from the Finitive code?

Fixed in #141


[TS migration] Migrate 'getPlaidLinkTokenParameters' lib to TypeScript

Details

Migrate 'getPlaidLinkTokenParameters' lib to TypeScript
Fixed Issues

$ https://github.com/Expensify/App/issues/24858
PROPOSAL: N/A
Tests

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/23176449/f6fdcf24-5bf4-4587-a45f-3d8353b8dc93

Mobile Web - Chrome

https://github.com/Expensify/App/assets/23176449/ebcf1ea3-e6fd-4ab7-bd26-44d6a256adc4

Mobile Web - Safari

https://github.com/Expensify/App/assets/23176449/31a7752d-3a8f-4a50-b103-1fcb06320625

Desktop

https://github.com/Expensify/App/assets/23176449/dc83bd9d-4246-49ea-9aec-8964dc6c4c24

iOS

https://github.com/Expensify/App/assets/23176449/c82ad092-ace9-419d-9c4e-aca17ffa9ded

Android

https://github.com/Expensify/App/assets/23176449/a65b4ef8-55a3-4627-be91-ddec45d5035f

I have read the CLA Document and I hereby sign the CLA

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/41169160/d1404ae9-2de1-4961-93ce-ba3a40aaa826

Mobile Web - Chrome

https://github.com/Expensify/App/assets/41169160/bb203f70-2378-4186-8d1a-de5e00aeb7ce

Mobile Web - Safari

https://github.com/Expensify/App/assets/41169160/4ceab729-1fa0-4087-aa34-1eae7994799c

Desktop

https://github.com/Expensify/App/assets/41169160/3193ad2e-df94-40e0-a2a2-2d143376d2ed

iOS

https://github.com/Expensify/App/assets/41169160/a97d3352-18fe-4484-8b7b-0358939ae151

Android

https://github.com/Expensify/App/assets/41169160/743e0291-8e3c-426e-a3e7-5bb9a0584aa0

Thank you @VickyStash for the cleanup on the var names

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/cead22 in version: 1.3.75-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/cead22 in version: 1.3.76-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Include theme / SEO

I just wanted to have the logo of BHNT show up when posting e.g. to reddit. Therefore I had to include the theme (to modify a bit) and add the jekyll-seo-tag. Now we have some stuff like meta property="og:image" content in there and thinks should look nicer when posting a BHNT link somewhere ;-)
Visually there should be no change - just have some more stuff in the <head> section now - might also help that we can remove meetup as the first hit for this website..

Nice!


Update comparison.rst

One point about NGINX is incorrect, specifically:
"Advanced load balancing. Though nginx plus (the paid server) supports some advanced load balancing features such as out of band health checking, even that version does not have the advanced service discovery and asynchronous DNS resolution features that Envoy does."
NGINX has an asynchronous DNS resolver, and NGINX Plus uses this in a range of service discovery scenarios:
Background:
https://www.nginx.com/products/on-the-fly-reconfiguration/
https://www.nginx.com/blog/microservices-reference-architecture-part-3the-fabricmodel/
https://www.nginx.com/blog/dns-service-discovery-nginx-plus/
Consul implementation:
https://www.nginx.com/blog/service-discovery-with-nginx-plus-and-consul/
https://www.nginx.com/blog/service-discovery-nginx-plus-srv-records-consul-dns/
etcd implementation:
https://www.nginx.com/blog/service-discovery-nginx-plus-etcd/
Zookeeper implementation:
https://www.nginx.com/blog/service-discovery-nginx-plus-zookeeper/
I've just stumbled across envoy, and it looks very impressive.  I'm very happy to help explain further or collaborate on this project if appropriate.  Please reach out to<EMAIL_ADDRESS>- thank you

@ogarrett apologies for the incorrect documentation. We will get it fixed. However, I do want to clarify that these are features available in the paid version vs. freely available. I will do a PR and tag you for approval.
Thanks,
Matt

closing in favor of https://github.com/lyft/envoy/pull/73


Add support for 1.19.1

Currently, the latest version of the mod crashes when starting the 1.19.1 server.

In order to debug this we'll need your log from when this happens, as it works fine in testing

Given that there has been no activity on this issue in over 1.5 months, I'll go ahead and close it


Incorrectly localized the plural of "x month(s) ago"

Issue is caused by this line of code
https://github.com/microsoft/pxt/blob/0ead5a7b9a312e1bf3466bb08cf9e2e5c73d2a33/pxtlib/util.ts#L793
This issue exists in at least three languages (portuguese, french, and spanish) and is persisted in all our targets
Currently we get this in es-mx:

Correct translation would look like this:
Singular

Plural

Crowdin string is here.
https://crowdin.com/translate/kindscript/32/en-esmx#52850

Is the fix changing the strings in the crowdin?


Update team

Story
As a team maker
I want to update my team
So that it reflects our new name / logo
Acceptance Criteria

[ ] If I am a creator of a team then when on the team profile I should be able to see an addtional button to "Edit Team" (sketch 1)
[ ] This button should take me to the Create Team screen with the fields prepopulated and the titles tweaked to indicate you are editing
[ ] When the user presses Save Changes at the botton an updateReferralSet transaction should be sent to my wallet and I should be able to approve
[ ] When I click confirm the transaction is sent to the network and I get a toast to acknowledge its success or failure

Tasks

[ ] Explore and sketch
[ ] Team and stakeholder review
[ ] Visual Design
[ ] Team review
[ ] Etc.

Sketch
Sketch 1

Sketch 2

Additional details / background info

I remember we said previously that it was odd that you stay on the update form.
Preferably it would take you straight back to the team profile imho....

Or it is acceptable to put a button here after you have saved that gives you the abiliy to go back to team profile


add support for pooling file generation from multiple library plates

Sequencing runs from multiple projects are becoming more commonplace. Combining prep data_frames and calculating normalized pooling volumes from combined project sequencing runs is straightforward, but the current pooling file generation codebase doesn't support overlap on Well_ID from two different prep plates when generating a pooling file. This needs to be fixed.

@RodolfoSalido can you say more about this, or maybe provide a link to the part of the code that needs to be enhanced?

Sorrry, I thought I had replied to this. Basically, the current scheme for generating a an echo pooling picklist relies on a 2D array of pooling volumes formatted to resemble the coordinates of the plate being pooled. However, if we are pooling from multiple plates, the function doesn't support generating a pooling picklist that pools the same well from two different plates. Here's the function that I'm referencing.
https://github.com/biocore/metagenomics_pooling_notebook/blob/c0f9818bdc2405e43abe5f7daca4ba276c22e262/metapool/metapool.py#L946
I already have a fix in mind for this and I'm working on implementing it. The idea is to take a pandas dataframe as input and format an echo pooling picklist that allows pooling from multiple source plates.


The module "background-volume" is using the old flat core compatibility fields which are deprecated in favor of the new "compatibility" object

i got this warning after installing this module
thanks

Fixed with Release 1.6.0


Add concurrency to CI

This PR adds concurrency to the Github workflows to automatically cancel current in-progress workflow runs when new commits are added.
The definition ${{ github.workflow }} makes it so that only this workflow is cancelled instead of a widespread cancelling of workflows.
The definition group: ${{ github.event.pull_request.number || github.ref }} targets workflows within the same PR, branch, or tag.

This repository is being deprecated (its contents will now live in the main repo in https://github.com/risc0/risc0/tree/main/examples), any GitHub workflow upgrades should happen in the main repo instead.


[docs] Updates on the CSS injection guide

This PR updates the interoperability guide and migration regarding the instruction on the CSS injection.

Should we have a section for styled components too?

Makes sense, let me add it


Windows

currently fails to build
error[E0433]: failed to resolve: maybe a missing crate `sys`?
  --> C:\Users\Steven\.cargo\registry\src\github.com-1ecc6299db9ec823\termion-1.5.6\src\lib.rs:24:9
   |
24 | pub use sys::size::terminal_size;
   |         ^^^ maybe a missing crate `sys`?
   |
   = help: consider adding `extern crate sys` to use the `sys` crate

Thanks for your comment, I will try to fix the bug!


STORM-1511 min/max operations support on a trident stream.

This is a cherrypick from 2.0 to 1.x-branch of https://github.com/apache/storm/pull/1086.


Export configuration information in shell launched by Atmos

what

Export Atmos Terraform configuration information in shell launched by Atmos

why

When Atmos launches a shell, it configures the shell for Terraform to reference a certain component and stack. The configuration is such that Terraform commands will work with a specific component and stack when run from a specific directory, and that informations is output to the user, but it has not been available in the environment for scripts or other automation to reference. By exposing that information in the environment, tools (e.g. the command prompt) can notify the user of the invisible state information and also warn the user if they are executing commands from the wrong directory and help them get back to the right one, among other possibilities.

Summary by CodeRabbit

New Features

Enhanced Terraform command functionality with additional environment variables for improved configuration.

Documentation

Added comments to clarify the use of custom shell prompts within the Geodesic environment.

We should also update the docs to describe this functionality.
The best I can think of is adding it here, in a new section.
Ideally we should document all environment variables that we set.
https://atmos.tools/cli/configuration/#environment-variables

We should also update the docs to describe this functionality.
The best I can think of is adding it here, in a new section.
Ideally we should document all environment variables that we set.
https://atmos.tools/cli/configuration/#environment-variables

@osterman documentation added

@coderabbitai Please create a GitHub issue to track the implementation of Geodesic shell detection


fix package vulnerabilities

Update packages to resolve vulnerabilities.

dotnet list package --vulnerable --include-transitive comes back with no vulnerabilities.


Table of source locations for Docker images

This is the cleaned up version of our fixes for pr832.
/assign @sarahmaddox @carmine

This change is

/lgtm

/ok-to-test
Preview: https://deploy-preview-925--competent-brattain-de2d6d.netlify.com/docs/reference/images/

Thanks!
/lgtm
/approve

Addresses part of issue https://github.com/kubeflow/website/issues/832


Support Warp

Warp is a pretty fantastic Rust-based terminal: https://www.warp.dev/
Unfortunately, newsh does not work with it when trying to open panes or tabs. New windows of the default macOS Terminal app open up instead.

@sunnysingh thanks for opening this issue. Opened an issue to see if warp team is willing to provide an API to support this.


added location to status indicator and zone script

On zone enter in hifi, will update the user's location in the database and display in the html readouts.

@zfox23 the whitespace is intentional from Alan's design pass. If he needs it changed, I will absolutely update!


add custom labels for deployment

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
35

Relevant Lines:
35

💛  - Coveralls


Removes -Zunstable-options for rustdoc testing

As far as I understand, this flag isn't needed anymore, since --edition is stable on beta.
I ran in to this when running cargo +beta test --doc --verbose on my crate, which errors with:
     Running `rustdoc -Zunstable-options --edition=2018 [omitted...]`
error: the option `Z` is only accepted on the nightly compiler

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matklad (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

 Warning

Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.30.0. Please double check that you specified the right target!

I don't know if it's appropriate to base this against 1.30.0 - this code seems to exist in master too, but it would be nice for it to land in 1.30 (if I understand the releases correctly, maybe I'm totally wrong).

This looks great, thanks!
And yeah, mind sending an update to the master branch as well?
@bors: r+

:pushpin: Commit 52a72e5ce8871f65cfd28b6278d171911be4f5f0 has been approved by alexcrichton

:hourglass: Testing commit 52a72e5ce8871f65cfd28b6278d171911be4f5f0 with merge c2cfb720191912f7bb647c7a11ab96488f1e7b02...

Adds #6063 for master

:broken_heart: Test failed - status-travis

@bors: r+

:pushpin: Commit b3eb747fa81401ea4a5bbb3254376ad900577659 has been approved by alexcrichton

:hourglass: Testing commit b3eb747fa81401ea4a5bbb3254376ad900577659 with merge 2131e5a253a5490c0ec478c9940193a48eff664c...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 2131e5a253a5490c0ec478c9940193a48eff664c to rust-1.30.0...


fix: tests tablespaces file from the RunAsUser spec from container

Since the user may be changed by a SecurityContext, we detect if there's a user set and we compare against it, otherwise, we use the default UID for the postgres user to compare with.

/ok-to-merge

https://github.com/EnterpriseDB/cloudnative-pg/actions/runs/7621829224/job/20758921421


Latest master is not published

Hello,
Could you publish the latest nuget version, otherwise it is not possible to use the library with Android 12
Best Regards

Duplicate


Create decapod-migrations container

This PR removes decapod-migration script execution from decapod-api container. This is done because automatic execution of migration scripts may cause a lot of errors and this makes update really complex.
To execute migrations, there is new image called migrate.sh which runs decapod-migration within required container network.
Also, now all containers run commands through dockerize.

Current coverage is 85.78% (diff: 100%)

Merging #83 into master will not change coverage

@@             master        #83   diff @@
==========================================
  Files            58         58
  Lines          3756       3756
  Methods           0          0
  Messages          0          0
  Branches        346        346
==========================================
  Hits           3222       3222
+ Misses          448        446     -2
- Partials         86         88     +2

Powered by Codecov. Last update 6716e17...9076332


Add a TargetKind for annotations on imports, exports, and part directives.

This might be blocked on changing TargetKind into a class with static constants instead of an enum as discussed in #49796
The recommended pattern for using @GenerateNiceMocks from package:mockito is to annotate the import of the generated file. This is a pattern we are likely to repeat into other packages.
It would be great if we can statically require the annotation on an import or export. I think it could be fine to have a single TargetKind.directive, but it may be more useful to split it up into imports, exports, and parts.

If you did a bit mask you could do something cute like:
static const anyDirective = TargetKind.importDirective | TargetKind.exportDirective | ...


migrate from failure to anyhow

I would love to get rid of some failure/anyhow compatibility code in docs.rs, and failure is unmaintained anyways.

btw, the test failures are odd, if feels like these are not related to my change, but I don't know rustwide well enough to be sure.
If the tests need fixing I'll dig into it.

@pietroalbini only pinging you because I heard you're still the main maintainer?
I'm happy to rework this PR to use more specific error types (for example with thiserror), if that is what you prefer.
My motivation is mostly to get rid of the ugly failure-to-anyhow conversion code in docs.rs.


Add keyboard mode flag to support both: "on-demand" & "exclusive" GTK layer-shell modes

Change

Add a -k flag to set the GTK layer shell keyboard focus mode

Modes supported are:

exclusive / e (Default)
on-demand / o

Note: none mode does not seem to make sense for this app, because it disables keyboard input completely.

Rationale / Background:
gtk-layer-shell, and Wayland now supports an "On Demand" mode via zwlr_layer_surface_v1::keyboard_interactivity v4 for keyboard focus.  The demo app also supports this mode and works well to demonstrate the new zwlr_layer_surface_v1::keyboard_interactivity v4 wayland protocol for the on-demand keyboard focus mode.
Note that for this to behave differently, it requires a newer version of sway than is currently released on most Linux distros, but it will not break anything given the backwards-compatible behavior being exclusive by default. (e.g. without this change: swaywm/sway@913a7679 / swaywm/sway#7587 ... and with on-demand mode set, it still behaves as if exclusive mode was set)
The following PRs have made it into wl-protocols, wlroots, & gtk-layer-shell:

swaywm/wlr-protocols#100
swaywm/wlroots#2555
wmww/gtk-layer-shell#105

Note: there is also one for wayfire: WayfireWM/wayfire#962
Testing the gtk-layer-shell demo program on Sway 1.8.1 behaves the same. For example: When setting the "On Demand" keyboard mode (--keyboard o) and either "Top" or "Overlay" layers (--layer t or --layer o).
When on these layers, it's impossible to get keyboard focus off of the demo program window without first setting keyboard setting back to "None".  While not ideal from a UI/UX perspective, nor from an app developer perspective, it doesn't hurt to have this option in client programs to enable the feature when sway or other window managers adopt the zwlr_layer_surface_v1::keyboard_interactivity v4 protocol.
More information can be found in: swaywm/sway#7499.

If the exclusive mode is default, wouldn't it be enough to add a boolean argument for the on demand mode?

If the exclusive mode is default, wouldn't it be enough to add a boolean argument for the on demand mode?

Yes, now that I think about it again this makes more sense.  The reason I went down the path of using a string flag was to support all the enum types supported by GTK layer shell, which included the none type at first.
After testing this out, I realized that none keyboard mode did not make sense from a UI/UX perspective for this app... so I changed it by removing that option and leaving the other two.
Now it can be represented by a simple binary on/off for on-demand vs exclusive modes (unless they add more modes in the future).

Sorry for delay. I was busy at other projects.
After some deliberation: I think we should just use LAYER_SHELL_KEYBOARD_MODE_ON_DEMAND in main.go line 389, w/o multiplying arguments. I'll check how it behaves tonight.

On sway 1.8.1 setting keyboard mode layershell.LAYER_SHELL_KEYBOARD_MODE_ON_DEMAND seems to change nothing. On Hyprland for some reason it behaves perfectly well in both ON_DEMAND and EXCLUSIVE mode. I failed installing the current development version of sway, so dunno how it's going to behave there. I suppose that just changing to ON_DEMAND mode should be safe.

Sorry for delay. I was busy at other projects.
After some deliberation: I think we should just use LAYER_SHELL_KEYBOARD_MODE_ON_DEMAND in main.go line 389, w/o multiplying arguments. I'll check how it behaves tonight.

I'd caution against making it the default unless also the app will grab focus on opening.  In my testing, I could trigger nwg-wrapper with hotkey and had to explicitly focus the app first by moving the mouse.  Without a focus event, it detracts from keyboard power-users... who are probably the demographic that window managers like Sway & i3wm appeal to.
I've tested on the following versions of sway:

1.9-dev-dc634c4a:  Pre-release build from git sources.

This includes the patch to enable the On-Demand mode.
Behavior:

Keyboard focus is able to follow mouse movement non-exclusively
Use cases enabled:

Opening nwg-drawer on a separate monitor / output, moving mouse to the second display to multi-task / copy text to clipboard / etc...  Then coming back to nwg-drawer window and pasting in text, opening an app, etc...
(I tested this via HEADLESS-1 output + wayvnc too!)
GTK Inspector workflow (for theming, GTK debug, etc...)

Enable GTK Inspector:
gsettings set org.gtk.Settings.Debug enable-inspector-keybinding true

Open nwg-drawer on a separate output (e.g. HEADLESS-1 or another display)

If using HEADLESS-1, run wayvnc, connect to it with a VNC Client (e.g. Remmina)

Press the keyboard shortcut to launch GTK Inspector: Ctrl+Shift+d

Move window to another output, make them floating so you can use GTK Inspector while viewing nwg-wrapper in the VNC window.

Now keyboard focus follows your mouse, and GTK Inspector is actually usable!  (Note: This was not possible before on sway v1.8.1 with Exclusive keyboard mode)

1.8.1-1: Manjaro / Arch stable package release

This does not yet include the patch to enable On-Demand mode.
Therefore, both Exclusive & On-Demand behave the same
Behavior: Exclusive mode is the only behavior, no matter the setting.
Focus is placed on nwg-wrapper however it is launched (hotkey, rofi, mouse click on .desktop, etc...)
Focus does not follow the mouse.  It's locked exclusively to the window.
Focus initialized on nwg-wrapper window.  This makes keyboard power-users happy!  Also good UI/UX for ease of use in general.

On sway 1.8.1 setting keyboard mode layershell.LAYER_SHELL_KEYBOARD_MODE_ON_DEMAND seems to change nothing.

This was my experience too during testing.  It's because the only mode supported for that version was LAYER_SHELL_KEYBOARD_MODE_EXCLUSIVE.  New behavior depends on the following change:

swaywm/sway#7587

On Hyprland for some reason it behaves perfectly well in both ON_DEMAND and EXCLUSIVE mode.

Sounds like it supports the zwlr_layer_surface_v1::keyboard_interactivity v4 protocol too! :tada:

I failed installing the current development version of sway, so dunno how it's going to behave there. I suppose that just changing to ON_DEMAND mode should be safe.

If you'd like to test... I built pre-release Arch packages from the PKGBUILDs on Manjaro.  Attaching the .pkg.tar.xz files here...
sway-pre-release-packages.tar.gz

Alright then. I'll merge it after #96. Sorry for prioritizing my own PR, which is younger, but your PR introduces less changes (in case  of conflicts).

Alright then. I'll merge it after #96. Sorry for prioritizing my own PR, which is younger, but your PR introduces less changes (in case of conflicts).

No problem, you can prioritize however makes sense... it's your project after all :wink:
FYI: I just uploaded both of the pre-release versions that I was testing to the Releases page @ gitlab.archlinux.org/trinitronx/nwg-drawer-git.
I think the one for nwg-drawer-git that I included in the sway-pre-release-packages.tar.gz above is the older version with flag.String implementation.  The newer one with flag.Bool is: 0.3.8.r20_pre.git.4724b52b0da.
The other updated dependencies for sway 1.9-dev-dc634c4a are still in sway-pre-release-packages.tar.gz

This update is simple enough to need no special testing, for which I have too little time by the way. I'm sure you tested it well enough. I'm a bit in hurry to finish what I'm working on before my holiday starts. :tada: As a hobbyist programmer, I have up to 4 hours a day (night!) for coding.


libredwg: 0.12 -> 0.12.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/LibreDWG/libredwg/releases.
meta.description for libredwg is: "Free implementation of the DWG file format"
meta.homepage for libredwg is: "https://savannah.gnu.org/projects/libredwg/"
meta.changelog for libredwg is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
/nix/store/jghazhmhxif0jyxylcmj9yy61m7kbi57-libredwg-0.12.4/bin/dwgrewrite passed the binary check.
/nix/store/jghazhmhxif0jyxylcmj9yy61m7kbi57-libredwg-0.12.4/bin/dwg2SVG passed the binary check.
/nix/store/jghazhmhxif0jyxylcmj9yy61m7kbi57-libredwg-0.12.4/bin/dwg2dxf passed the binary check.
/nix/store/jghazhmhxif0jyxylcmj9yy61m7kbi57-libredwg-0.12.4/bin/dwgread passed the binary check.
/nix/store/jghazhmhxif0jyxylcmj9yy61m7kbi57-libredwg-0.12.4/bin/dwgfilter passed the binary check.
/nix/store/jghazhmhxif0jyxylcmj9yy61m7kbi57-libredwg-0.12.4/bin/dxf2dwg passed the binary check.
/nix/store/jghazhmhxif0jyxylcmj9yy61m7kbi57-libredwg-0.12.4/bin/dwglayers passed the binary check.
/nix/store/jghazhmhxif0jyxylcmj9yy61m7kbi57-libredwg-0.12.4/bin/dwgbmp passed the binary check.
/nix/store/jghazhmhxif0jyxylcmj9yy61m7kbi57-libredwg-0.12.4/bin/dwgadd passed the binary check.
/nix/store/jghazhmhxif0jyxylcmj9yy61m7kbi57-libredwg-0.12.4/bin/dwgwrite passed the binary check.
/nix/store/jghazhmhxif0jyxylcmj9yy61m7kbi57-libredwg-0.12.4/bin/dxfwrite passed the binary check.
/nix/store/jghazhmhxif0jyxylcmj9yy61m7kbi57-libredwg-0.12.4/bin/dwggrep passed the binary check.
12 of 12 passed binary check by having a zero exit code.
11 of 12 passed binary check by having the new version present in output.
found 0.12.4 with grep in /nix/store/jghazhmhxif0jyxylcmj9yy61m7kbi57-libredwg-0.12.4
found 0.12.4 in filename of file in /nix/store/jghazhmhxif0jyxylcmj9yy61m7kbi57-libredwg-0.12.4

Rebuild report (if merged into master) (click to expand)

7 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
3 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
freecad
libredwg
python38Packages.libredwg
python39Packages.libredwg

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jghazhmhxif0jyxylcmj9yy61m7kbi57-libredwg-0.12.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libredwg https://github.com/r-ryantm/nixpkgs/archive/aadd8bb24deb7c9127b47615140024572d3837b6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jghazhmhxif0jyxylcmj9yy61m7kbi57-libredwg-0.12.4
ls -la /nix/store/jghazhmhxif0jyxylcmj9yy61m7kbi57-libredwg-0.12.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages built:

freecad
libredwg
python38Packages.libredwg
python39Packages.libredwg

Maintainer pings
cc @thorstenweber83 for testing.

@ofborg build libredwg


audio files

hello haslinger,
can i call the audio files from another server?, to use another location as file storage

Yes, with the download_url variable in _config.yml:
# needed, if and only if audio files are hosted in a different location
download_url: http://my.cdn.com/path/to/episodes/

thanks, also how can I change the colour on the top menu bar?, it's currently green

Have a look at _sass/_overrides.scss in your project: You will find the changes necessary for the six colors used in the navbar in comments.

thanks, I was able to do it, can I also change the color of the subscribe button?, is that done in another file?


This is throwing 5xx

Earlier it was working perfectly fine, i have been using this for quite long, but today it started throwing 5XX for me, any help will be appreciated.
Cannot retrieve speedtest configuration
ERROR: HTTP Error 500: Service Unavailable```

I had that issues too, but now it works again.

Let me check now...

Now It is working, thanks for letting me know @ploedman

Yeah, not really anything I can do here. speedtest.net is ran by Ookla, and this project isn't. If their service gives a 500, it's likely just some transient issue on their side.

Yes, may be possible, any how thaks.


[RoosterTeeth] Fixed downloading of FIRST only videos + Gets biggest thumbnail.

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[ ] I am the original author of this code and I am willing to release it under Unlicense
[x] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)
Merged code from two previous commits into youtube-dl. So already covered by Unlicense. See below for sources

What is the purpose of your pull request?

[x] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Merged auth code from @ddmgy old pull request #16105 and updated video downloader code from @remitamine c72dc20 to get FIRST only videos to download. Also merged thumbnail code from @ddmgy to get highest resolution thumbnails. I've tested it with several FIRST only videos and it seems to work with all of them. Please let me know if you find any that don't work and I'll look into it.
Should Fix Issue #16094

Can confirm that this works. @remitamine I can give you login information for you to test prior to merging.
PS D:\Repositories\youtube-dl> python test/test_download.py TestDownload.test_RoosterTeeth
test_RoosterTeeth (__main__.TestDownload): ... [RoosterTeeth] million-dollars-but-season-2-million-dollars-but-the-game-announcement: Downloading video JSON metadata
[RoosterTeeth] million-dollars-but-season-2-million-dollars-but-the-game-announcement: Downloading m3u8 information
[RoosterTeeth] million-dollars-but-season-2-million-dollars-but-the-game-announcement: Downloading episode JSON metadata
[info] Writing video description metadata as JSON to: test_RoosterTeeth_9156.info.json
[debug] Invoking downloader on 'https://rtv2-roosterteeth.akamaized.net/uploads/videos/ad777f87-9c5d-485b-a484-76c8eca54ff6/NewHLS-1080P.m3u8'
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 15
[download] Destination: test_RoosterTeeth_9156.mp4
[download] 100% of 10.00KiB in 00:00
ok

----------------------------------------------------------------------
Ran 1 test in 1.592s


SPARK-18809: KCL version to 1.6.2 on master

What changes were proposed in this pull request?
Upgrading KCL version from 1.6.1 to 1.6.2.  Without this upgrade, Spark cannot consume
from a stream that includes aggregated records.
This change was already commited against an older version of Spark.  We need to
apply the same thing to master.
How was this patch tested?
Manual testing using dump.py:
https://gist.github.com/boneill42/020dde814346c6b4ad0ba28406c3ea10
Please review http://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

Test build #3485 has started for PR 16236 at commit af24ef3.

Test build #3492 has started for PR 16236 at commit af24ef3.

Test build #3492 has finished for PR 16236 at commit af24ef3.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Merged to master


Remove gene symbol and insert Locus Tag in field 4

sigK

Change pipe-delimited field 4 to ALWAYS be locus tag, and NEVER gene symbol. Currently, the gene symbol is reported if there is a gene symbol, else the locus tag is reported.
Particularly when lines with multiple annotations are split on to separate row, this makes it impossible to cross reference the gene symbol to the strand information. In this case, I don't know what gene symbol sig K is.
"Coding SNP at 1431118 > C functional=NULL_NULL_NULL locus_tag=CD630_12310-CD630_12300 Strand Information: CD630_12310=-/CD630_12300=-/;C|missense_variant|MODERATE|CD630_12310|c.119A>G|p.Asn40Ser|119/1518|40/505|null or hypothetical protein,sigK|putative site-specific recombinase,Sigma K,;C|intron_variant|MODIFIER|sigK|c.391-1437A>G||||null or hypothetical protein,sigK|putative site-specific recombinase,Sigma K,;"
Also, sometimes the annotation is in pipe-delimited field 4 instead of locus tag or gene symbol
"Non-Coding SNP at 5393980 > T functional=NULL_NULL_NULL locus_tag=KPNIH1_26385 Strand Information: KPNIH1_26385=-;T|intergenic_region|MODIFIER|KPNIH1_26385-null or hypothetical protein|n.5393980A>T||||null or hypothetical protein|hypothetical protein;"

Remove gene symbol and insert Locus Tag.
Originally posted by @alipirani88 in https://github.com/alipirani88/variant_calling_pipeline/issues/15#issuecomment-540116128

@sthiede do you remember which matrix was this. I wanted to test the fixes.

i think this is the path to the C. diff matrix:
'/nfs/esnitkin/Project_Cdiff/Sequence_data/Project_propensity_score_match/consensus/2019_04_12_11_45_07_core_results/data_matrix/matrices/SNP_matrix_code.csv'


🐛 bug: timeout streaming error when used with LocalAI

Description
Encountered "timeout streaming" when configured to point to LocalAI.  Error is shown below.  Works fine when configured to point to OpenAI.
{
"caller": "app/plugin_api.go:1003",
"error": "timeout streaming",
"level": "error",
"msg": "Streaming result to post failed",
"plugin_id": "mattermost-ai",
"timestamp": "2024-05-04 05:45:23.445 Z"
}
Steps to reproduce
Run Mattermost using Azure Container Instance.  Image used is mattermost/mattermost-preview.
Mattermost server version is 9.7.3.
AI Copilot version is 0.6.3.
Run LocalAI using Azure Container Instance.  Image used is localai/localai:latest-aio-cpu.
Able to get chat response from LocalAI using Postman with the following API Post call.
http://xx.xx.xx.xx:8080/v1/chat/completions

{
  "model": "gpt-4",
   "messages": [
    {
        "role": "user",
        "content": "How are you?"
    }
    ]
}

I encountered the same issue with ollama as well. I think it's because the default value for StreamTimeoutSecond is too short. Is it possible to configure this value?
https://github.com/mattermost/mattermost-plugin-ai/blob/2d13eb69da506ca83e1845bc6f309fc2b42b86f6/server/ai/openai/openai.go#L51

Me too.
How exactly do we solve this?
I know I'm lengthening that time, but each version has a different source, so I don't know what to change. I'm using the latest version of 0.8.

I refer to the configuration file of this plugin, there is a parameter to configure the streaming timeout in seconds.
StreamingTimeoutSeconds int    json:"streamingTimeoutSeconds"
https://github.com/mattermost/mattermost-plugin-ai/blob/master/server/ai/configuration.go
After you have enabled this plugin in MatterMost, open up MatterMost configuration file (config.json) and look for the section belonging to this plugin.  It should look something like this.
"service":{
"apiKey":  ,
"apiURL":  ,
"defaultModel":  ,
"id":  ,
"orgId":  ,
"password":  ,
"tokenLimit":  ,
"type":  ,
"username":
}
Append "streamingTimeoutSeconds":  xxx, to "service" object, save and restart MatterMost service.  The timeout should be extended to the value configured in the MatterMost config file.
Would be much easier if this field is made configurable in the UI.

There is a UI configuration for this in the latest versions. I think this can be closed?
@lhchew please reopen if the timeout configuration is not enough to fix this.