[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/client-writers
/assign knative-sandbox/client-writers
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping k8s.io/cli-runtime 6987411...3a76515:
  > 3a76515 Update dependencies to v0.21.4 tag
  > 30c0385 Merge pull request # 103319 from jpbetz/fix-102749-1.21
  > 1cb4b28 Bump SMD to v4.1.2 to pick up # 102749 fix
  > 0f1f581 sync: remove Godeps/
  > 26ed6ab Merge pull request # 102196 from kolyshkin/automated-cherry-pick-of-# 102147-upstream-release-1.21
  > c822c35 vendor: bump runc to rc95
  > 89856ac sync: update go.mod
  > 10ad15c Merge pull request # 101177 from KnVerey/automated-cherry-pick-of-# 101120-upstream-release-1.21
  > c911bee Upgrade kustomize-in-kubectl to v4.1.2
  > 7eb4209 sync: update go.mod
  > 754d2cb Prevent nil-pointer exception when constructing PrinterFlags
  > 2ae662a Merge pull request # 100156 from ehashman/issue-100155
  > d16fab2 Bump klog to 2.8.0, fixing nil panics in KObj
  > b38acd2 Merge pull request # 99759 from jpbetz/apply-extract
  > 184d177 Bump SMD to v4.1.0
  > 13fcfe0 Merge pull request # 98946 from monopole/upgradeKustomize
  > 475a91e until stable: pin-dependency, update-vendor, update-bazel, lint-dep
  > ee5f40f Manually update kustomize attachment points.
  > 5bc5373 Delete staging/src/k8s.io/cli-runtime/pkg/kustomize
  > 0d4cd42 Merge pull request # 99423 from soltysh/cronjob_controller
  > 56fe8e9 Merge pull request # 99817 from liggitt/zero-value
  > 73fb497 Generated changes
  > b150ffa Merge pull request # 98749 from pandaamanda/kubectl_patch_error
  > 65067b1 Update k8s.io/kube-openapi
  > 58ece87 Merge pull request # 98194 from julianvmodesto/dry-run-openapi
  > fc708e8 fix kubectl patch command error message
  > f536d1e Merge pull request # 98952 from seans3/kubectl-commands-in-headers
  > bd30b15 Cache the OpenAPI schema for server-side dry-run.
  > 032576f Kubectl command headers in requests: KEP 859
  > 396a7ac Merge pull request # 98572 from justaugustus/go116
  > dee4de8 Fixup golang.org/x/term staticcheck warnings
  > 79e0cb6 [go1.16] bump golang.org/x/... dependencies
  > 4479c17 generated: Run hack/lint-dependencies.sh and hack/update-vendor.sh
  > 0d4a0ed [go1.16] go.mod: update to go1.16
  > f36b02a Merge pull request # 99561 from BenTheElder/remove-bazel
  > 3c27837 hack/update-bazel.sh
  > 5dae1b2 Merge pull request # 99105 from sftim/20210215_improve_secret_api_notes
  > afbbc93 Merge pull request # 99014 from apelisse/update-smd
  > 83b525e Update generated code
  > b93df22 Merge pull request # 96878 from knight42/feat/kubectl-strip-managed-fields
  > b0db02e Update sigs.k8s.io/structured-merge-diff to v4.0.3
  > 5090645 feat(kubectl): add flag --show-managed-fields to kubectl-get
  > 8572436 Merge pull request # 98790 from jkh52/master
  > cc003fd Bump konnectivity-client to v0.0.15
  > 984374f Merge pull request # 98477 from palnabarun/update-gogo/protobuf
  > 1cac5e2 Merge pull request # 98488 from pohly/klog-2.5.0
  > 342f0e1 update gogo/protobuf to v1.3.2
  > 4a1e813 Merge pull request # 98565 from adisky/move-spdystream
  > a7b87f9 logging: support call depth via logr, structured logging
  > 891cc21 Update dependency docker/spdystream to moby/spdystream
  > 3659b98 Merge pull request # 98003 from lauchokyip/fixlint2
  > c17cca0 Merge pull request # 97841 from feranwq/patch-92402-2
  > 8bbf887 Fix golint errors for k8s.io/cli-runtime/pkg/genericclioptions/
  > 1af699d fix vendor/k8s.io/cli-runtime/pkg/printers staticcheck
  > 9547a43 Merge pull request # 97171 from deads2k/deprecate-psp
  > 9507288 Merge pull request # 97033 from patrickshan/pshan/bump/Azure/go-autorest/autorest
  > fa2ac05 generated
  > 2e4b259 Merge pull request # 96763 from soltysh/discovery_burst
  > 3826eb3 update dependencies
  > 3be6e6b cli-runtime: expose option to set discovery burst
  > bb33401 Merge pull request # 96317 from Jefftree/test-ssa
  > c477d0c Update kube-openapi
bumping k8s.io/client-go 435503c...a2642ab:
  > a2642ab Update dependencies to v0.21.4 tag
  > ccdebc2 Merge pull request # 103614 from dprotaso/automated-cherry-pick-of-# 102928-upstream-release-1.21
  > fefd2ad Merge pull request # 103319 from jpbetz/fix-102749-1.21
  > 46c1ad3 Simplify use of the fake dynamic client
  > 5823455 Bump SMD to v4.1.2 to pick up # 102749 fix
  > 3c428df Merge pull request # 102800 from pohly/automated-cherry-pick-of-# 102788-upstream-release-1.21
  > fe825e6 client-go: reduce log level of reflector again
  > 6277e97 sync: remove Godeps/
  > b63b1ba Merge pull request # 102587 from saschagrunert/release-1.21
  > c18505f Revert "Cleanup portforward streams after their usage"
  > ffd8cfc Merge pull request # 102196 from kolyshkin/automated-cherry-pick-of-# 102147-upstream-release-1.21
  > a802afb vendor: bump runc to rc95
  > c04de52 Merge pull request # 100951 from saschagrunert/automated-cherry-pick-of-# 99839-upstream-release-1.21
  > 322fe85 Cleanup portforward streams after their usage
  > 0f9967b sync: update go.mod
  > 307e3a3 Merge pull request # 100718 from dims/automated-cherry-pick-of-# 100606-# 100660-upstream-release-1.21-take-2
  > a124236 Common auth plugins should always be available
  > ac49e87 providerless tag for client-go auth plugins
  > 6be0785 Merge pull request # 100156 from ehashman/issue-100155
  > 5f0702f Merge pull request # 99375 from ehashman/probe-kep-2238
  > e5c17fc Bump klog to 2.8.0, fixing nil panics in KObj
  > 2407de6 Generated changes for probe terminationGracePeriodSeconds
  > a5722b4 Merge pull request # 99759 from jpbetz/apply-extract
  > 476d5f9 Generated apply configurations
  > 9e34778 Add extract apply function generation
  > 982571f Bump SMD to v4.1.0
  > d6fad70 Merge pull request # 99643 from pohly/generic-ephemeral-volume-beta
  > 6085ad0 Merge pull request # 99290 from mortent/PromotePDBsToGA
  > 37e7f4a generic ephemeral volume: generate code
  > 814c68c Merge pull request # 99522 from robscott/topology-hints
  > fa732dd generated
  > 67d8c55 Merge pull request # 99495 from wojtek-t/cleanup_describe_8
  > 9c78771 Adding Hints to EndpointSlice API
  > 62b9b26 Promote PDBs to GA
  > db49dde Merge pull request # 98973 from YoyinZyc/add_context_outside_apiserver
  > 4c5ab17 Add sig-instrumentation approvers to events libraries OWNERS
  > 57d5462 Merge pull request # 98946 from monopole/upgradeKustomize
  > 6a42ca3 add context to restclient metrics
  > 1ae4d69 until stable: pin-dependency, update-vendor, update-bazel, lint-dep
  > c277935 Merge pull request # 98727 from adtac/suspend
  > aa6ddc8 Merge pull request # 99641 from pohly/storage-capacity-beta
  > 5ca42da batch: add suspended job
  > 9f9bfd9 CSIStorageCapacity: generated files for beta
  > 7fc57bb Merge pull request # 96600 from maplain/internal-traffic-policy
  > 9baafcd Implements Service Internal Traffic Policy
  > fa8f4cc Merge pull request # 99214 from jpbetz/apply-client-go-builders2-typedclient
  > b4932b5 Merge pull request # 99907 from liggitt/cache-test-timeout
  > a793842 Generate typed clients with Apply support
  > 8df02b3 Merge pull request # 99662 from swetharepakula/eps-ga-api-changes
  > 21ee617 Add test timeout to mutation detector test
  > d2a6442 Merge pull request # 99275 from hbagdi/feat/ingress-class-namespaced-params
  > 2eb8aff Graduate EndpointSlice API to GA
  > 9db6403 Add namespace scoped ParametersReference to IngressClass
  > 75a1e7f Merge pull request # 99423 from soltysh/cronjob_controller
  > 1745c9f Merge pull request # 99817 from liggitt/zero-value
  > 627c12d Generated changes
  > fcacc4b Merge pull request # 98277 from XudongLiuHarold/add-loadbalancerclass-field
  > d21dde2 Update k8s.io/kube-openapi
  > 4f21285 Merge pull request # 98127 from mortent/AddConditionsToPDBs
  > 3285000 Add LoadBalancerClass field in service
  > da66d1b generated
  > 503eb33 Merge pull request # 99782 from liggitt/race-tests
  > ec8fb02 Merge pull request # 99012 from jpbetz/apply-client-go-builders2
  > 0693903 Fix or remove tests that don't work in race mode
  > f146f0f generate applied configurations
  > 9409f57 Merge pull request # 99741 from liggitt/client-go-install
  > a71c2f1 Merge pull request # 98892 from ankeesler/exec-plugin-metrics
  > e0f03ac Update client-go install instructions
  > a5abe9c Merge pull request # 937 from liggitt/update-readme
  > 8aa3e0f exec credential provider: add rest_client_exec_plugin_call_total metric
  > 1cfb136 Merge pull request # 99654 from ankeesler/exec-plugin-interactive-fix
  > 2dec69c Update readme installation instructions
  > 149c501 exec credential provider: use stdin to detect user interaction
  > a337294 Merge pull request # 98572 from justaugustus/go116
  > b13f594 Fixup golang.org/x/term staticcheck warnings
  > 768a62f [go1.16] bump golang.org/x/... dependencies
  > 0ea7217 generated: Run hack/lint-dependencies.sh and hack/update-vendor.sh
  > 36b22fd [go1.16] go.mod: update to go1.16
  > fcbadc8 Merge pull request # 99561 from BenTheElder/remove-bazel
  > 13e6cd3 hack/update-bazel.sh
  > 6a25187 Merge pull request # 99324 from zshihang/master
  > c3c3d40 Merge pull request # 99377 from liggitt/version-sha
  > 3d6ec32 reset token if got Unauthorized in KCM
  > 8f8241f Merge pull request # 99195 from pacoxu/structurelog/watch-retry-timeout-1
  > 1a6e902 Switch gitVersion format to non-abbreviated hash
  > 12449b5 Merge pull request # 99193 from zhijianli88/subresource
  > 06efd86 Migrate client-go retry-watcher to structured logging
  > fa31d62 Merge pull request # 99111 from databus23/patch-5
  > bb1d67d request.go: correct subresource referencing
  > 21dd7ea Merge pull request # 99079 from tkashem/throttle-message
  > a125444 Return error when persister fails to modify config
  > 10def0e Merge pull request # 99063 from ZxYuan/patch-1
  > d1fdbcd client-go: add more context to request throttle message
  > 7279fc6 Merge pull request # 96987 from soltysh/drop_batch-alpha
  > a9fe1e1 Fix typo in client-go/rest/client.go
  > df50762 Merge pull request # 99014 from apelisse/update-smd
  > 6167582 Generated changes
  > 39da007 Merge pull request # 99110 from nikhita/clean-up-owners-jan-2021
  > 508a193 Update sigs.k8s.io/structured-merge-diff to v4.0.3
  > d6cefbd Drop batch/v2alpha1 API
  > 1d0cb03 *: remove nikhiljindal from OWNERS
  > e8ab252 *: remove madhusudancs from reviewers
  > 4c4207a *: move gmarek to emeritus_approvers
  > 20732a1 Merge pull request # 98889 from jkaniuk/leaderelection-simplify
  > 0eaf14c Simplify leader election code
  > 1006137 Merge pull request # 98790 from jkh52/master
  > bf60d3f Bump konnectivity-client to v0.0.15
  > 93ce971 Merge pull request # 98671 from liggitt/kubeconfig-env
  > 3c12da5 Merge pull request # 98324 from atosatto/export-debug-roundripper
  > b620e82 Isolate TestModifyContext from $KUBECONFIG
  > 3147a30 Merge pull request # 98477 from palnabarun/update-gogo/protobuf
  > ef84e47 Re-run gofmt against staging/src/k8s.io/client-go/transport/
  > ab82d40 Merge pull request # 98488 from pohly/klog-2.5.0
  > 2861152 update gogo/protobuf to v1.3.2
  > e87f4d8 Remove unexpected updates to go.mod and go.sum
  > c8e0107 Merge pull request # 98565 from adisky/move-spdystream
  > 362c485 logging: support call depth via logr, structured logging
  > 9d369ea Update bazel BUILD file
  > b8b770f Update dependency docker/spdystream to moby/spdystream
  > 84db31c Address golint warnings
  > 6329432 Merge pull request # 98496 from lavalamp/connrotation
  > 8d3dc9e Run gofmt against staging/src/k8s.io/client-go/transport/round_trippers_test.go
  > b72204b Merge pull request # 95664 from DirectXMan12/bug/non-racy-recorder-shutdown
  > 5985bbb Fix unbounded connection creation & 50s of delay
  > 2bce173 Run gofmt against staging/src/k8s.io/client-go/transport/round_trippers.go
  > fc034b4 Merge pull request # 96552 from pandaamanda/klog_fmt
  > 726d27f Don't record events in goroutines
  > 5c01a03 client-go: export NewDebuggingRoundTripper function and DebugLevel
  > 537eda7 Merge pull request # 98058 from jprzychodzen/le-comment
  > d7ba1f2 use klog.Info and klog.Warning when had no format
  > 25e8b5f Merge pull request # 97083 from knight42/feat/enable-spdy-ping
  > eae461d [Leader election] Add documentation to function
  > 479dd01 feat: enable SPDY pings on connections
  > 623741e Merge pull request # 97909 from adamzhoul/fix-chan-bug
  > 2192138 Merge pull request # 97095 from sabbox/fix-panic-azure-oidc-auth-plugins
  > 5c32e97 fix replyChan block
  > b804f9f add noop persister to plugin loader
  > f80da32 Merge pull request # 97255 from chotiwat/patch-1
  > 224c1c6 Merge pull request # 97857 from liggitt/exec-auth-reuse-dialer
  > a35bc8f Fix stale object causing a panic on DELETE event
  > 9761a13 Merge pull request # 96906 from Rajalakshmi-Girish/issue-96853
  > 0c5bab6 Track opened connections with a single tracker per authenticator
  > 0d3f257 Merge pull request # 907 from munnerz/patch-1
  > cb8d3d1 fixes the unit tests to be more tolerant with error messages
  > e9d996d Merge pull request # 97326 from victor-timofei/deltafifo-doc
  > efbc708 README: add 1.20 in compatibility matrix
  > 0964d4b Merge pull request # 97033 from patrickshan/pshan/bump/Azure/go-autorest/autorest
  > 53a09c7 Update the wording of the DeltaFIFO
  > cc9d424 Merge pull request # 96883 from pacoxu/fix/96862
  > 2b31242 Merge pull request # 94813 from dramich/nometrics
  > 01fbb1d Bump github.com/Azure/go-autorest/autorest to v0.11.12
  > 710a222 Move Delta definitions to the top
  > 77dfe4d Merge pull request # 92138 from ash2k/ash2k/client-cleanups
  > 8031d76 fix index test: multi index check for empty list
  > f39ca99 Don't start goroutine for noMetrics
  > 09cf714 Update DeltaFIFO Documentation
  > 62f63bb Merge pull request # 96837 from adamzhoul/master
  > 29b0745 Check errors of the Close call
  > 04adad4 fix spdy stream, conn deadlock.
  > 6cc3981 Make inClusterConfigProvider thread safe
  > e24efdc Merge pull request # 96797 from jqmichael/initialCountLength
  > 6d09f8e Stop using mergo.MergeWithOverwrite
  > 50c0861 Merge pull request # 96643 from bboreham/lose-timestamp
  > 1d17529 Fixed a harmless bug where initialPopulationCount should be based on the key length not list size in DeltaFIFO#Replace()
  > 277eea6 Cleanup currentMigrationRules
  > 5d2c89d Remove unused argument from generateEvent
bumping knative.dev/client 28a340c...817068b:
  > 817068b Remove replace of go-openapi/spec from go.mod (# 1443)
  > 7e90dca Tekton - use ClusterRoleBinding v1 (# 1440)
  > c717a3f upgrade to latest dependencies (# 1434)
  > a2d6111 Update community files (# 1437)
  > 95193bd TestServiceExport works with images specified by digest (# 1435)
  > 5fc49f7 Update actions (# 1436)
  > e570844 Update community files (# 1432)
  > 7e49547 upgrade to latest dependencies (# 1431)
  > 4a0ac33 fix kn trigger list command to show correct v1/service sink output (# 1428)
  > 0026939 Update code-of-conduct, readme and contrib files (# 1429)
  > 2e71451 Fix release script to published darwin/arm64 bits (# 1427)
  > d0dc966 Update community files (# 1426)
  > 035150e update versions to 0.25 (# 1425)
  > 9f30eba upgrade to latest dependencies (# 1424)
bumping knative.dev/hack e28525d...815cd31:
  > 815cd31 Stop performing pre-releases (# 77)
bumping knative.dev/pkg 21eb4c1...bb433c9:
  > bb433c9 Add tests for retriable errors to the spoof client (# 2277)
  > b09fa45 Declare `DefaultErrorRetryChecker` as `ErrorRetryChecker` type (# 2276)
  > dec98b4 fix a small lint warning (# 2270)
  > fbe9e7e Widen the error checker interface to allow response error checking (# 2253)
  > 7a61343 only test downstream tekton with HEAD (# 2271)
  > c69aba0 Deduplicate Check and Poll functions on the spoof client (# 2264)
  > b721b0b fix check calls being unreliable (# 2250)
  > d60f1a4 Avoid double-resyncs without leader election. (# 2252)
  > 0482448 allow unknown metadata fields (# 2249)
  > f39ea04 Add eventing-redis to downstream test (# 2247)
  > 82f3a9f Add triggers to the downstream test (# 2236)
  > e957ee5 Drop several deprecated APIs. (# 2228)
  > 2bd91f7 Bump K8s dependencies to 1.21.4 (# 2242)
  > 4472e04 Bump golangci-lint timeout to 10m for github actions (# 2241)
  > fac4920 Update assorted dependencies (# 2240)
  > 263ce40 Add chains to the downstream test (# 2237)
  > ddd97e9 Remove obsolete verbose log message for pre-release (# 2235)
  > a7f5b39 Addressable resolver now accepts custom resolvers (# 2195)
  > 2b66fdd Update community files (# 2239)
  > 51f5642 Update actions (# 2238)
  > 46a3611 Add Tekton downstream test (# 2233)
  > a70bb26 Add length limit for the generated names used in tests (# 2217)
  > a4ed097 Update version check comment (# 2234)
  > a94f5f0 Trim the space in configmap/registriesSkippingTagResolving's url. (# 2231)
  > 12d915e Update prometheus dep to 0.30.0 (# 2227)
  > 3bed4dc Make the configmap update logging Debugf (# 2226)
  > 44fffc8 This implements the EventExpansion needed to emit K8s events. (# 2224)
  > 6ef763d Remove long deprecated NewImplWithStats (# 2223)
  > 9c7fd8e Introduce `NewContext`, deprecate `NewImplFull`. (# 2222)
  > 766b8f7 Have the addressable resolver take a tracker. (# 2220)
  > 9b9bc2a Run codegen (# 2221)
  > 52d2a0d Deprecate ReadOnlyFinalizer interface over OnDeletionInterface (# 2212)
  > 44fc074 Update community files (# 2219)
  > bda81c0 upgrade to latest dependencies (# 2218)
  > 7b5ecbc Sketch out an alternate way of injecting clients/informers (# 2210)
  > 8c88fa2 Revert "Remove the unused file (# 1935)" (# 2213)
  > 50410e0 Use consistent case for "Deprecated" comments (# 2216)
  > 35bcd16 Drop redundant pointers and decoders (# 2211)
  > bf176d5 Sink two codegen passes below loop. (# 2209)
  > 2c8a7b6 Update community files (# 2208)
  > 23b0147 Update actions (# 2206)
bumping k8s.io/api 6f23172...3fcac9f:
  > 3fcac9f Update dependencies to v0.21.4 tag
  > e718350 Merge pull request # 103319 from jpbetz/fix-102749-1.21
  > aa60858 Bump SMD to v4.1.2 to pick up # 102749 fix
  > 0d3282d sync: remove Godeps/
  > b962205 Merge pull request # 102196 from kolyshkin/automated-cherry-pick-of-# 102147-upstream-release-1.21
  > 6601f0c vendor: bump runc to rc95
  > e379db4 Merge pull request # 101053 from robscott/automated-cherry-pick-of-# 100728-release-1.21
  > 48ab514 Updating Topology Aware Hints to support "Auto" value for annotation
  > b422b2e sync: update go.mod
  > 1f635bf Mark v1beta1 EndpointSlice deprecated in favor of v1
  > fd88418 Merge pull request # 100188 from alculquicondor/job-api-fixes
  > 51a1c55 Merge pull request # 100156 from ehashman/issue-100155
  > 862c319 Only default Job fields when feature gates are enabled
  > ec4ebef Merge pull request # 99375 from ehashman/probe-kep-2238
  > d35369e Bump klog to 2.8.0, fixing nil panics in KObj
  > 8b5303f Merge pull request # 99298 from zshihang/csi
  > 06f27fd Generated changes for probe terminationGracePeriodSeconds
  > edd3ec9 Merge pull request # 100147 from alculquicondor/indexed-annotation
  > aecea00 graduate CSIServiceAccountToken to beta
  > b4ebda3 Add terminationGracePeriodSeconds to Probe API
  > 937dc44 Merge pull request # 99759 from jpbetz/apply-extract
  > 5079330 Rename job completion index annotation to not contain alpha
  > f714d15 Bump SMD to v4.1.0
  > c0951d6 Merge pull request # 99643 from pohly/generic-ephemeral-volume-beta
  > 8814a7d Merge pull request # 99975 from robscott/endpoints-over-capacity
  > e5d78e7 testdata: drop the alpha EphemeralVolumeSource.ReadOnly field
  > f1e2e30 Merge pull request # 99290 from mortent/PromotePDBsToGA
  > 5d9669f Adding new EndpointsOverCapacity annotation for Endpoints controller
  > 1e0f065 generic ephemeral volume: generate code
  > 93f222f Merge pull request # 99522 from robscott/topology-hints
  > 7749c3d generated
  > 99bd953 generic ephemeral volumes: drop ReadOnly field
  > a61f0c6 Merge pull request # 98946 from monopole/upgradeKustomize
  > 212bbe4 Adding Hints to EndpointSlice API
  > 167e928 Promote PDBs to GA
  > efdf974 generic ephemeral volumes: promote to beta
  > fadfa4e Add default namespace labels to all namespaces for selectors (# 96968)
  > 4c06238 until stable: pin-dependency, update-vendor, update-bazel, lint-dep
  > e466978 Merge pull request # 98727 from adtac/suspend
  > 1fcb2aa Merge pull request # 99641 from pohly/storage-capacity-beta
  > 6feceee batch: add suspended job
  > c8b7374 CSIStorageCapacity: add +featureGate=CSIStorageCapacity
  > 2f7785f CSIStorageCapacity: generated files for beta
  > cb683dc CSIStorageCapacity: add MaximumVolumeSize to v1beta1 API
  > 32e8852 CSIStorageCapacity: mark v1alpha1 as deprecated
  > e5a9d01 CSIStorageCapacity: promote API to beta
  > 63be2e3 Merge pull request # 96600 from maplain/internal-traffic-policy
  > ea13d29 Merge pull request # 99871 from liggitt/compatibility-tests
  > 73d9a7d Update generated files
  > 1f1764b Update discovery compatibility data for v1
  > 6fe5bea Implements Service Internal Traffic Policy
  > 6432c75 Add discovery and flowcontrol compatibility API data
  > 8e35c50 Merge pull request # 99662 from swetharepakula/eps-ga-api-changes
  > 3a11614 Merge pull request # 99275 from hbagdi/feat/ingress-class-namespaced-params
  > 1442f42 Graduate EndpointSlice API to GA
  > dd8d676 Add namespace scoped ParametersReference to IngressClass
  > d04530e Merge pull request # 97216 from joejulian/docs_missing_quotes
  > 2e93611 Merge pull request # 99423 from soltysh/cronjob_controller
  > 7eb8b95 generated content
  > 3687c90 Merge pull request # 99817 from liggitt/zero-value
  > a2c0f4b Generated changes
  > d107683 Re-clarify NetworkPolicy policyTypes in docs
  > 264a74a Merge pull request # 98277 from XudongLiuHarold/add-loadbalancerclass-field
  > 1e9b09f Update k8s.io/kube-openapi
  > 9e34104 Deprecate batch/v1beta1 CronJob & CronJobList in 1.21, with removal still 1.25
  > 85a11c3 Merge pull request # 98127 from mortent/AddConditionsToPDBs
  > 2e5a20d Add LoadBalancerClass field in service
  > ca413d2 Promote CronJobs to batch/v1
  > 9841b19 generated
  > 4047479 Introduce .status.lastSuccessfulTime field for CronJob
  > 521a376 Add conditions to PDB status
  > a57dfb5 Update batch API to get rid of API violations
  > 1f71974 Merge pull request # 99681 from shiyajuan123/master
  > 0d975ab Merge pull request # 98582 from ahg-g/ahg-scope
  > ddb02f4 add descriptions to these event/types.go files
  > 92fdaf9 Add CrossNamespacePodAffinity quota scope and PodAffinityTerm.NamespaceSelector APIs, and CrossNamespacePodAffinity quota scope implementation.
  > c218b22 Merge pull request # 99414 from Jiawei0227/type
  > c4b1941 Merge pull request # 98441 from alculquicondor/array-job-api
  > 9ea52fd Update inline volume spec comments
  > 6773eb3 Add Job.spec.completionMode and Job.status.completedIndexes
  > 9a813ed Merge pull request # 98572 from justaugustus/go116
  > bbb8038 [go1.16] bump golang.org/x/... dependencies
  > bbeeb22 generated: Run hack/lint-dependencies.sh and hack/update-vendor.sh
  > a60c82b [go1.16] go.mod: update to go1.16
  > cab5316 Merge pull request # 99163 from ahg-g/ahg-pod-deletion
  > 7f6f023 Implement pod deletion cost
  > b852e50 Merge pull request # 99561 from BenTheElder/remove-bazel
  > 2c17abb hack/update-bazel.sh
  > 6c086a5 Merge pull request # 97099 from pacoxu/fix/96986
  > 65a259a Merge pull request # 90105 from xiaoanyunfei/cleanup/pkg_apis_core
  > 595a48a move default container annotation to kubectl pkg
  > 9dd0c8b Scheduler: remove pkg/apis/core/field_constants.go
  > 1ad1003 feature: use default container annotation for logs and exec
  > 498bb3d Rename labelNodeRoleExcludeBalancer to labelNodeExcludeBalancers (# 97767)
  > f666922 Merge pull request # 99105 from sftim/20210215_improve_secret_api_notes
  > 8e2decd Merge pull request # 96987 from soltysh/drop_batch-alpha
  > 09cfcd0 Update generated code
  > bed38c9 Merge pull request # 99014 from apelisse/update-smd
  > 38d3b32 Generated changes
  > 4a935f5 Revise wording for Secret stringData
  > 3632e28 Merge pull request # 99110 from nikhita/clean-up-owners-jan-2021
  > 8a25276 Update sigs.k8s.io/structured-merge-diff to v4.0.3
  > 92cf842 Drop batch/v2alpha1 API
  > 71251ee *: remove nikhiljindal from OWNERS
  > 0ce5dc2 *: remove mbohlool from reviewers
  > 2a912cc *: remove madhusudancs from reviewers
  > b580185 *: remove jianhuiz from reviewers
  > 48bd838 Merge pull request # 98790 from jkh52/master
  > 89fe579 Bump konnectivity-client to v0.0.15
  > 9e1a49d Merge pull request # 96911 from munnerz/fix-typo-admission-chain
  > 9f65ac4 Merge pull request # 98477 from palnabarun/update-gogo/protobuf
  > 0cef08a generated files
  > ac3757b Add EndPort to Network Policy - Alpha (# 97058)
  > 772b5cb update gogo/protobuf to v1.3.2
  > a554b54 Fix doc comment typo on validating & mutating webhook resources
  > c6cc3d9 Merge pull request # 98488 from pohly/klog-2.5.0
  > 4af41fa Merge pull request # 98576 from kevindelgado/ssa
  > 0502a85 logging: support call depth via logr, structured logging
  > cfb031d Merge pull request # 98565 from adisky/move-spdystream
  > 1bd5594 Declare TCP default for service port protocol
  > 117f629 Update dependency docker/spdystream to moby/spdystream
  > 9b864a5 Merge pull request # 98363 from cpanato/go1157
  > 40d1940 [go1.15] updatestaging pb.go files using the hack scripts
  > 0d6bea2 Merge pull request # 92065 from pohly/podinfo-doc-fix
  > c873f2e Merge pull request # 97880 from justinsb/spelling
  > 482a958 storage: document csi.storage.k8s.io/ephemeral also for internal type
  > ecbefa1 Merge pull request # 97896 from brpratt/fix-external-name-doc
  > a949695 Fix spelling typos: scheduable -> schedulable
  > e31c03e Merge pull request # 96698 from wawa0210/fix-96697
  > d3515d5 add missing ExternalName to doc
  > cb95709 Merge pull request # 97971 from liggitt/testdata
  > f3893b1 Update help document address
  > 791492e Add API testdata population instructions
  > 1198ffc Merge pull request # 97761 from liggitt/1.20-testdata
  > 4e9f5db Merge pull request # 97615 from wojtek-t/immutable_secrets_ga
  > 0d2c654 Remove 1.18.0 API test data
  > 47952fe Merge pull request # 97379 from kebe7jun/fix/token-request-proto-name
  > d6680e1 Autogenerated
  > 9494b83 Add 1.20 API test data
  > 9ab310c Merge pull request # 97466 from geegeea/lint-kubelet
  > 5ba49fe Fix BoundObjectRef APIVersion proto name
  > 1a38d5b Promote Immutable Secrets/ConfigMaps feature to GA
  > 9c6b1a9 Merge pull request # 97171 from deads2k/deprecate-psp
  > 596c2df Fix golint issues in api/admission and api/admissionregistration
  > 3dc59fa Merge pull request # 97359 from Cweiping/fix/fix_typo_error
  > 0824739 generated
  > fedd331 Merge pull request # 96375 from smarterclayton/daemonset_surge
  > e639e1a fix typo err
  > 99409d9 deprecate PSP in 1.21, but leave removal at 1.25
  > dfa980b generated: Changes for DaemonSet max surge
  > 7655e01 api: Add DaemonSet MaxSurge
  > fcac651 Merge pull request # 96736 from andrewsykim/deprecate-topology-keys
  > d10e393 Merge pull request # 96311 from thockin/kep-1659-topology-labels
  > ed61c3e core/v1: deprecate Service topologyKeys
  > e2b10e1 Merge pull request # 93549 from Dean-Coakley/fix-res-quota-comments
  > 2271b8b Clean up comments around old topology labels
  > 72d4ae9 Fix incomplete ResourceQuota comments
bumping k8s.io/apimachinery c278689...f916759:
  > f916759 Merge pull request # 103319 from jpbetz/fix-102749-1.21
  > 12b6a22 Bump SMD to v4.1.2 to pick up # 102749 fix
  > 41e4141 sync: remove Godeps/
  > 235edae Merge pull request # 102587 from saschagrunert/release-1.21
  > a4090fc Revert "Cleanup portforward streams after their usage"
  > 1a7b32c Merge pull request # 102196 from kolyshkin/automated-cherry-pick-of-# 102147-upstream-release-1.21
  > 2c210a7 vendor: bump runc to rc95
  > 7559d78 Merge pull request # 100951 from saschagrunert/automated-cherry-pick-of-# 99839-upstream-release-1.21
  > be0c813 Merge pull request # 101325 from joelsmith/automated-cherry-pick-of-# 101306-upstream-release-1.21
  > c422483 Cleanup portforward streams after their usage
  > 59d900d Additional CVE-2021-3121 fix
  > e337f44 Bump klog to 2.8.0, fixing nil panics in KObj
  > ae8b5f5 Merge pull request # 99759 from jpbetz/apply-extract
  > 0dd2dd9 Add extract apply function generation
  > 0335ad3 Bump SMD to v4.1.0
  > 1f1bc58 Merge pull request # 99951 from deads2k/fix-decodableversions
  > 98d3ae9 Merge pull request # 98841 from caesarxuchao/fix-98479
  > a13af10 provide directly decodable versions for storageversion API
  > 79c4f87 Merge pull request # 98946 from monopole/upgradeKustomize
  > 1174cb8 make proxy Transport return metav1.Status error
  > 1f7ce2b until stable: pin-dependency, update-vendor, update-bazel, lint-dep
  > 8e4c0a5 Merge pull request # 98653 from mandelsoft/stream
  > 543ebb5 Merge pull request # 99214 from jpbetz/apply-client-go-builders2-typedclient
  > 963dac0 simplier fix + test for race condition
  > a5a2acc Merge pull request # 98074 from kwiesmueller/admission-reset-managedFields
  > 9794359 Add Apply functions to client-gen
  > 193cd4a add comment describing the race condition + TODO for appropriate test
  > 283a326 Merge pull request # 99817 from liggitt/zero-value
  > 19eb396 fix validation test
  > e51562e fix sync problem in streamwatcher
  > cda259e Update k8s.io/kube-openapi
  > 8dcbc56 remove apiVersion check from managedFields validation
  > 569bd20 Merge pull request # 99755 from lala123912/out_of_range
  > 7de09c3 fix validation tests
  > f0c829d fix RemoveStatusCondition（）  cap out of range
  > 1c6b148 update licenses and bazel
  > 0869820 Merge pull request # 98595 from SergeyKanzhelev/nodelifecycleSchedulerUnitTestsSpeedUp
  > 96b0ee0 consolidate managedFields validation
  > 4f70757 sped up scheduler tests by using fake clock
  > 317ebe7 Merge pull request # 98572 from justaugustus/go116
  > ed96c1e [go1.16] bump golang.org/x/... dependencies
  > 89aa0e9 generated: Run hack/lint-dependencies.sh and hack/update-vendor.sh
  > f246562 [go1.16] go.mod: update to go1.16
  > 603e046 Merge pull request # 99561 from BenTheElder/remove-bazel
  > 193bda8 hack/update-bazel.sh
  > 17b79e7 Merge pull request # 97385 from FabianKramm/fix-http2-proxy
  > 44b9a37 Merge pull request # 90105 from xiaoanyunfei/cleanup/pkg_apis_core
  > 5a3ff4c override request host for kubectl proxy
  > c3f3e5b Scheduler: remove pkg/apis/core/field_constants.go
  > 6d2f20b Merge pull request # 99083 from gavinfish/requirement-equal
  > 527a61b Merge pull request # 99014 from apelisse/update-smd
  > 823fec8 Add equal func for Requirement struct
  > 9cd3dcb Merge pull request # 99110 from nikhita/clean-up-owners-jan-2021
  > 7faacc3 Update sigs.k8s.io/structured-merge-diff to v4.0.3
  > 2cc50c7 *: remove nikhiljindal from OWNERS
  > 53fe198 *: remove mbohlool from reviewers
  > c340b76 *: remove madhusudancs from reviewers
  > 37cce14 *: remove jianhuiz from reviewers
  > d6b6643 *: move gmarek to emeritus_approvers
  > c93b0f8 Merge pull request # 98790 from jkh52/master
  > 7fbabcb Bump konnectivity-client to v0.0.15
  > 9e39a13 Merge pull request # 98477 from palnabarun/update-gogo/protobuf
  > f0392a0 Merge pull request # 98616 from smarterclayton/recognizer_buffer
  > 9812d82 update gogo/protobuf to v1.3.2
  > 783dd7d serializer: Recognizer interface should take a buffer
  > 28da342 Merge pull request # 98488 from pohly/klog-2.5.0
  > d656fe5 Merge pull request # 98565 from adisky/move-spdystream
  > 6495214 logging: support call depth via logr, structured logging
  > cbf4d8f Update dependency docker/spdystream to moby/spdystream
  > 87c8a96 Merge pull request # 98363 from cpanato/go1157
  > 4a7d8d5 [go1.15] updatestaging pb.go files using the hack scripts
  > ee96543 Merge pull request # 98312 from deads2k/finish-export-option-removal
  > ab111ff generated
  > 33e8773 remove ExportOptions
  > 234faef finish removal of exportoptions
  > 460d109 Merge pull request # 95664 from DirectXMan12/bug/non-racy-recorder-shutdown
  > 0e9f9cf Merge pull request # 96552 from pandaamanda/klog_fmt
  > 322dfb4 Don't record events in goroutines
  > af2ce7e Merge pull request # 97552 from aanm/pr/replace/buffer/with/strings
  > 8c0a4ea use klog.Info and klog.Warning when had no format
  > 4f50573 Merge pull request # 97990 from AlexanderYastrebov/offset-97651
  > d7e94ae pkg/labels: replace bytes.Buffer with strings.Builder
  > 2ab0da8 Uses offset instead of line number in JSONSyntaxError
  > 825faf0 pkg/util/net: replace bytes.Buffer with strings.Builder
  > 53a9c91 Merge pull request # 97538 from lingsamuel/requirement-return-field-error
  > 1d8c923 Merge pull request # 97891 from thinpark/apimachinery.clean
  > 10e20f4 make labels.NewRequirement returns aggregated field.ErrorList, make nodeaffinity parsing function use it
  > 8834a19 [k8s.io/apimachinery/pkg/test]: cleanup commented code
  > 6c16abd Merge pull request # 94396 from habibrosyad/patch-92402-10
  > 9d4f7cb Merge pull request # 97540 from chymy/just-comments
  > 25bfe1d fix vendor/k8s.io/apimachinery/pkg/runtime staticcheck
  > 0ca7b34 Merge pull request # 97590 from heqg/typo-expected-03
  > 67bb4d2 Fix on comments
  > 9363a52 Fix typo in staging/src/.../wait_test.go
  > 15c5dba Merge pull request # 96974 from WangXiangUSTC/master
  > 8f01ffc Merge pull request # 95790 from aojea/loopnet
  > df4ce5a Update selector.go
  > 02953c0 get ips from loopback interfaces
  > 51a2756 autodetect global addresses on loopback interfaces

/lgtm
/approve


CMake tools should use build environment in debug and launch

Brief Issue Summary
When using multi-config generators, there are some values that depend on the build configuration. For example, path to dlls based on the build configuration. Currently, it appears that CMake tools only sets variables from the configure preset.
CMake Tools Diagnostics
{
  "os": "win32",
  "vscodeVersion": "1.74.0",
  "cmtVersion": "1.13.28",
  "configurations": [
    {
      "folder": "c:\\Users\\calebmagiya\\Documents\\projects\\practice\\cpp\\sample",
      "cmakeVersion": "3.24.2",
      "configured": true,
      "generator": "Ninja",
      "usesPresets": true,
      "compilers": {
        "CXX": "C:/msys64/ucrt64/bin/gcc.exe"
      }
    }
  ],
  "cpptoolsIntegration": {
    "isReady": true,
    "hasCodeModel": true,
    "activeBuildType": "Release",
    "buildTypesSeen": [
      "Release"
    ],
    "requests": [
      "file:///c%3A/Users/calebmagiya/Documents/projects/practice/cpp/sample/main.cpp"
    ],
    "responses": [
      {
        "uri": "file:///c%3A/Users/calebmagiya/Documents/projects/practice/cpp/sample/main.cpp",
        "configuration": {
          "includePath": [],
          "defines": [],
          "compilerPath": "c:/msys64/ucrt64/bin/gcc.exe",
          "compilerArgs": [],
          "compilerFragments": []
        }
      }
    ],
    "partialMatches": [],
    "targetCount": 1,
    "executablesCount": 1,
    "librariesCount": 0,
    "targets": [
      {
        "name": "sample",
        "type": "EXECUTABLE"
      }
    ]
  },
  "settings": [
    {
      "communicationMode": "automatic",
      "useCMakePresets": "auto",
      "configureOnOpen": false
    }
  ]
}

Debug Log
[extension] [2571] cmake.launchTarget started
[main] The folder containing the CMake cache is missing. The cache will be regenerated.
[main] Configuring folder: sample
[main] Saving open files before configure/build
[driver] Start configure
[driver] Running pre-configure checks and steps
[cmakefileapi-driver] Configuring using preset
[cmakefileapi-driver] Invoking CMake C:\Program Files\CMake\bin\cmake.EXE with arguments ["-SC:/Users/calebmagiya/Documents/projects/practice/cpp/sample","-BC:/Users/calebmagiya/Documents/projects/practice/cpp/sample/build/default","-G","Visual Studio 17 2022"]
[proc] Executing command: "C:\Program Files\CMake\bin\cmake.EXE" -SC:/Users/calebmagiya/Documents/projects/practice/cpp/sample -BC:/Users/calebmagiya/Documents/projects/practice/cpp/sample/build/default -G "Visual Studio 17 2022"
[proc]   with environment: {"ALLUSERSPROFILE":"C:\\ProgramData","ANDROID_SDK_ROOT":"C:\\dev\\android-sdk","APPDATA":"C:\\Users\\calebmagiya\\AppData\\Roaming","ChocolateyInstall":"C:\\ProgramData\\chocolatey","ChocolateyLastPathUpdate":"133108474694752903","ChocolateyToolsLocation":"C:\\tools","CommonProgramFiles":"C:\\Program Files\\Common Files","CommonProgramFiles(x86)":"C:\\Program Files (x86)\\Common Files","CommonProgramW6432":"C:\\Program Files\\Common Files","COMPUTERNAME":"LAPTOP-FTLGGKLC","ComSpec":"C:\\WINDOWS\\system32\\cmd.exe","CONAN_USER_HOME_SHORT":"C:\\dev\\.conan","DriverData":"C:\\Windows\\System32\\Drivers\\DriverData","ELECTRON_RUN_AS_NODE":"1","GOPATH":"C:\\Users\\calebmagiya\\go","HOMEDRIVE":"C:","HOMEPATH":"\\Users\\calebmagiya","JAVA_HOME":"C:\\Program Files\\Microsoft\\jdk-<IP_ADDRESS>-hotspot\\","LOCALAPPDATA":"C:\\Users\\calebmagiya\\AppData\\Local","LOGONSERVER":"\\\\LAPTOP-FTLGGKLC","MSYS_ROOT":"C:\\msys64","NEXTHINK":"C:\\Program Files\\Nexthink\\Collector","NUMBER_OF_PROCESSORS":"8","OneDrive":"C:\\Users\\calebmagiya\\OneDrive - Microsoft","OneDriveCommercial":"C:\\Users\\calebmagiya\\OneDrive - Microsoft","ORIGINAL_XDG_CURRENT_DESKTOP":"undefined","OS":"Windows_NT","Path":"C:\\Program Files\\Microsoft\\jdk-<IP_ADDRESS>-hotspot\\bin;C:\\Program Files (x86)\\Microsoft SDKs\\Azure\\CLI2\\wbin;C:\\WINDOWS\\system32;C:\\WINDOWS;C:\\WINDOWS\\System32\\Wbem;C:\\WINDOWS\\System32\\WindowsPowerShell\\v1.0\\;C:\\WINDOWS\\System32\\OpenSSH\\;C:\\Program Files\\dotnet\\;C:\\ProgramData\\chocolatey\\bin;C:\\Program Files (x86)\\MSBuild\\14.0\\Bin;C:\\Program Files\\Microsoft SQL Server\\130\\Tools\\Binn\\;C:\\Program Files\\Microsoft SQL Server\\150\\Tools\\Binn\\;C:\\Program Files\\Go\\bin;C:\\Program Files (x86)\\Gpg4win\\..\\GnuPG\\bin;C:\\Program Files\\Git\\cmd;C:\\Program Files\\CMake\\bin;C:\\Strawberry\\c\\bin;C:\\Strawberry\\perl\\site\\bin;C:\\Strawberry\\perl\\bin;C:\\dev\\android-sdk\\platform-tools;C:\\dev\\flutter\\bin;;C:\\Program Files\\Docker\\Docker\\resources\\bin;C:\\Users\\calebmagiya\\.cargo\\bin;C:\\Users\\calebmagiya\\AppData\\Local\\Programs\\Python\\Python310\\Scripts\\;C:\\Users\\calebmagiya\\AppData\\Local\\Programs\\Python\\Python310\\;C:\\Users\\calebmagiya\\AppData\\Local\\Microsoft\\WindowsApps;C:\\Users\\calebmagiya\\AppData\\Local\\Programs\\Fiddler;C:\\Users\\calebmagiya\\go\\bin;C:\\Users\\calebmagiya\\AppData\\Local\\Programs\\Microsoft VS Code\\bin;C:\\Users\\calebmagiya\\AppData\\Local\\JetBrains\\Toolbox\\scripts;C:\\Users\\calebmagiya\\.dotnet\\tools;C:\\Users\\calebmagiya\\AppData\\Local\\Microsoft\\WindowsApps;C:\\Users\\calebmagiya\\AppData\\Local\\nvs\\default;C:\\Users\\calebmagiya\\AppData\\Local\\nvs\\;C:\\Users\\calebmagiya\\AppData\\Local\\Programs\\oh-my-posh\\bin;C:\\Program Files (x86)\\Dr. Memory\\bin\\;","PATHEXT":".COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC","POSH_THEMES_PATH":"C:\\Users\\calebmagiya\\AppData\\Local\\Programs\\oh-my-posh\\themes","PROCESSOR_ARCHITECTURE":"AMD64","PROCESSOR_IDENTIFIER":"Intel64 Family 6 Model 142 Stepping 12, GenuineIntel","PROCESSOR_LEVEL":"6","PROCESSOR_REVISION":"8e0c","ProgramData":"C:\\ProgramData","ProgramFiles":"C:\\Program Files","ProgramFiles(x86)":"C:\\Program Files (x86)","ProgramW6432":"C:\\Program Files","PSModulePath":"C:\\Program Files\\WindowsPowerShell\\Modules;C:\\WINDOWS\\system32\\WindowsPowerShell\\v1.0\\Modules;C:\\Program Files (x86)\\Microsoft Azure Information Protection\\Powershell","PUBLIC":"C:\\Users\\Public","SESSIONNAME":"Console","SystemDrive":"C:","SystemRoot":"C:\\WINDOWS","TEMP":"C:\\Users\\CALEBM~1\\AppData\\Local\\Temp","TMP":"C:\\Users\\CALEBM~1\\AppData\\Local\\Temp","UATDATA":"C:\\Windows\\CCM\\UATData\\D9F8C395-CAB8-491d-B8AC-179A1FE1BE77","USERDNSDOMAIN":"africa.corp.microsoft.com","USERDOMAIN":"AFRICA","USERDOMAIN_ROAMINGPROFILE":"AFRICA","USERNAME":"calebmagiya","USERPROFILE":"C:\\Users\\calebmagiya","VCPKG_DOWNLOADS":"C:\\Users\\calebmagiya\\.vcpkg\\downloads","VS140COMNTOOLS":"C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\Common7\\Tools\\","VSCODE_AMD_ENTRYPOINT":"vs/workbench/api/node/extensionHostProcess","VSCODE_CODE_CACHE_PATH":"C:\\Users\\calebmagiya\\AppData\\Roaming\\Code\\CachedData\\5235c6bb189b60b01b1f49062f4ffa42384f8c91","VSCODE_CWD":"C:\\Users\\calebmagiya\\AppData\\Local\\Programs\\Microsoft VS Code","VSCODE_HANDLES_UNCAUGHT_ERRORS":"true","VSCODE_IPC_HOOK":"\\\\.\\pipe\\0d6ec62be47c6423f149c98e814ac9cf-1.74.0-main-sock","VSCODE_NLS_CONFIG":"{\"locale\":\"en-ke\",\"availableLanguages\":{},\"_languagePackSupport\":true}","VSCODE_PID":"14448","windir":"C:\\WINDOWS","ZES_ENABLE_SYSMAN":"1","TEST_VAR1":"Config var"}
[cmake] -- The CXX compiler identification is MSVC 19.34.31935.0
[cmake] -- Detecting CXX compiler ABI info
[cmake] -- Detecting CXX compiler ABI info - done
[cmake] -- Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.34.31933/bin/Hostx64/x64/cl.exe - skipped
[cmake] -- Detecting CXX compile features
[cmake] -- Detecting CXX compile features - done
[cmake] -- Configuring done
[cmake] -- Generating done
[cmake] -- Build files have been written to: C:/Users/calebmagiya/Documents/projects/practice/cpp/sample/build/default
[cmakefileapi-parser] Read reply folder: C:\Users\calebmagiya\Documents\projects\practice\cpp\sample\build\default\.cmake\api\v1\reply
[cmakefileapi-parser] Found index files: ["cache-v2-45376e1e0fd1190b10b9.json","cmakeFiles-v1-7ca12174dc0c5d54b42e.json","codemodel-v2-0668e7144e2332ce5b21.json","directory-.-Debug-d0094a50bb2071803777.json","directory-.-MinSizeRel-d0094a50bb2071803777.json","directory-.-Release-d0094a50bb2071803777.json","directory-.-RelWithDebInfo-d0094a50bb2071803777.json","index-2022-12-13T20-43-00-0500.json","target-ALL_BUILD-Debug-6a5e4fc7328d1ff4ece1.json","target-ALL_BUILD-MinSizeRel-6a5e4fc7328d1ff4ece1.json","target-ALL_BUILD-Release-6a5e4fc7328d1ff4ece1.json","target-ALL_BUILD-RelWithDebInfo-6a5e4fc7328d1ff4ece1.json","target-sample-Debug-073621441fabf1c9d320.json","target-sample-MinSizeRel-f38e922b10f896d45542.json","target-sample-Release-53fd8d283487667dd6ce.json","target-sample-RelWithDebInfo-78aa17bef0bbc316cef9.json","target-ZERO_CHECK-Debug-c6c67c2d4186596012ec.json","target-ZERO_CHECK-MinSizeRel-c6c67c2d4186596012ec.json","target-ZERO_CHECK-Release-c6c67c2d4186596012ec.json","target-ZERO_CHECK-RelWithDebInfo-c6c67c2d4186596012ec.json","toolchains-v1-777a92ef48bc79263443.json"]
[cache] Reading CMake cache file C:/Users/calebmagiya/Documents/projects/practice/cpp/sample/build/default/CMakeCache.txt
[cache] Parsing CMake cache string
[main] Building folder: sample sample
[main] Saving open files before configure/build
[build] Starting build
[driver] Start build sample
[proc] Executing command: "C:\Program Files\CMake\bin\cmake.EXE" --build C:/Users/calebmagiya/Documents/projects/practice/cpp/sample/build/default --config Debug --target sample
[proc]   with environment: {"ALLUSERSPROFILE":"C:\\ProgramData","ANDROID_SDK_ROOT":"C:\\dev\\android-sdk","APPDATA":"C:\\Users\\calebmagiya\\AppData\\Roaming","ChocolateyInstall":"C:\\ProgramData\\chocolatey","ChocolateyLastPathUpdate":"133108474694752903","ChocolateyToolsLocation":"C:\\tools","CommonProgramFiles":"C:\\Program Files\\Common Files","CommonProgramFiles(x86)":"C:\\Program Files (x86)\\Common Files","CommonProgramW6432":"C:\\Program Files\\Common Files","COMPUTERNAME":"LAPTOP-FTLGGKLC","ComSpec":"C:\\WINDOWS\\system32\\cmd.exe","CONAN_USER_HOME_SHORT":"C:\\dev\\.conan","DriverData":"C:\\Windows\\System32\\Drivers\\DriverData","ELECTRON_RUN_AS_NODE":"1","GOPATH":"C:\\Users\\calebmagiya\\go","HOMEDRIVE":"C:","HOMEPATH":"\\Users\\calebmagiya","JAVA_HOME":"C:\\Program Files\\Microsoft\\jdk-<IP_ADDRESS>-hotspot\\","LOCALAPPDATA":"C:\\Users\\calebmagiya\\AppData\\Local","LOGONSERVER":"\\\\LAPTOP-FTLGGKLC","MSYS_ROOT":"C:\\msys64","NEXTHINK":"C:\\Program Files\\Nexthink\\Collector","NUMBER_OF_PROCESSORS":"8","OneDrive":"C:\\Users\\calebmagiya\\OneDrive - Microsoft","OneDriveCommercial":"C:\\Users\\calebmagiya\\OneDrive - Microsoft","ORIGINAL_XDG_CURRENT_DESKTOP":"undefined","OS":"Windows_NT","Path":"C:\\Program Files\\Microsoft\\jdk-<IP_ADDRESS>-hotspot\\bin;C:\\Program Files (x86)\\Microsoft SDKs\\Azure\\CLI2\\wbin;C:\\WINDOWS\\system32;C:\\WINDOWS;C:\\WINDOWS\\System32\\Wbem;C:\\WINDOWS\\System32\\WindowsPowerShell\\v1.0\\;C:\\WINDOWS\\System32\\OpenSSH\\;C:\\Program Files\\dotnet\\;C:\\ProgramData\\chocolatey\\bin;C:\\Program Files (x86)\\MSBuild\\14.0\\Bin;C:\\Program Files\\Microsoft SQL Server\\130\\Tools\\Binn\\;C:\\Program Files\\Microsoft SQL Server\\150\\Tools\\Binn\\;C:\\Program Files\\Go\\bin;C:\\Program Files (x86)\\Gpg4win\\..\\GnuPG\\bin;C:\\Program Files\\Git\\cmd;C:\\Program Files\\CMake\\bin;C:\\Strawberry\\c\\bin;C:\\Strawberry\\perl\\site\\bin;C:\\Strawberry\\perl\\bin;C:\\dev\\android-sdk\\platform-tools;C:\\dev\\flutter\\bin;;C:\\Program Files\\Docker\\Docker\\resources\\bin;C:\\Users\\calebmagiya\\.cargo\\bin;C:\\Users\\calebmagiya\\AppData\\Local\\Programs\\Python\\Python310\\Scripts\\;C:\\Users\\calebmagiya\\AppData\\Local\\Programs\\Python\\Python310\\;C:\\Users\\calebmagiya\\AppData\\Local\\Microsoft\\WindowsApps;C:\\Users\\calebmagiya\\AppData\\Local\\Programs\\Fiddler;C:\\Users\\calebmagiya\\go\\bin;C:\\Users\\calebmagiya\\AppData\\Local\\Programs\\Microsoft VS Code\\bin;C:\\Users\\calebmagiya\\AppData\\Local\\JetBrains\\Toolbox\\scripts;C:\\Users\\calebmagiya\\.dotnet\\tools;C:\\Users\\calebmagiya\\AppData\\Local\\Microsoft\\WindowsApps;C:\\Users\\calebmagiya\\AppData\\Local\\nvs\\default;C:\\Users\\calebmagiya\\AppData\\Local\\nvs\\;C:\\Users\\calebmagiya\\AppData\\Local\\Programs\\oh-my-posh\\bin;C:\\Program Files (x86)\\Dr. Memory\\bin\\;","PATHEXT":".COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC","POSH_THEMES_PATH":"C:\\Users\\calebmagiya\\AppData\\Local\\Programs\\oh-my-posh\\themes","PROCESSOR_ARCHITECTURE":"AMD64","PROCESSOR_IDENTIFIER":"Intel64 Family 6 Model 142 Stepping 12, GenuineIntel","PROCESSOR_LEVEL":"6","PROCESSOR_REVISION":"8e0c","ProgramData":"C:\\ProgramData","ProgramFiles":"C:\\Program Files","ProgramFiles(x86)":"C:\\Program Files (x86)","ProgramW6432":"C:\\Program Files","PSModulePath":"C:\\Program Files\\WindowsPowerShell\\Modules;C:\\WINDOWS\\system32\\WindowsPowerShell\\v1.0\\Modules;C:\\Program Files (x86)\\Microsoft Azure Information Protection\\Powershell","PUBLIC":"C:\\Users\\Public","SESSIONNAME":"Console","SystemDrive":"C:","SystemRoot":"C:\\WINDOWS","TEMP":"C:\\Users\\CALEBM~1\\AppData\\Local\\Temp","TMP":"C:\\Users\\CALEBM~1\\AppData\\Local\\Temp","UATDATA":"C:\\Windows\\CCM\\UATData\\D9F8C395-CAB8-491d-B8AC-179A1FE1BE77","USERDNSDOMAIN":"africa.corp.microsoft.com","USERDOMAIN":"AFRICA","USERDOMAIN_ROAMINGPROFILE":"AFRICA","USERNAME":"calebmagiya","USERPROFILE":"C:\\Users\\calebmagiya","VCPKG_DOWNLOADS":"C:\\Users\\calebmagiya\\.vcpkg\\downloads","VS140COMNTOOLS":"C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\Common7\\Tools\\","VSCODE_AMD_ENTRYPOINT":"vs/workbench/api/node/extensionHostProcess","VSCODE_CODE_CACHE_PATH":"C:\\Users\\calebmagiya\\AppData\\Roaming\\Code\\CachedData\\5235c6bb189b60b01b1f49062f4ffa42384f8c91","VSCODE_CWD":"C:\\Users\\calebmagiya\\AppData\\Local\\Programs\\Microsoft VS Code","VSCODE_HANDLES_UNCAUGHT_ERRORS":"true","VSCODE_IPC_HOOK":"\\\\.\\pipe\\0d6ec62be47c6423f149c98e814ac9cf-1.74.0-main-sock","VSCODE_NLS_CONFIG":"{\"locale\":\"en-ke\",\"availableLanguages\":{},\"_languagePackSupport\":true}","VSCODE_PID":"14448","windir":"C:\\WINDOWS","ZES_ENABLE_SYSMAN":"1","TEST_VAR1":"Config var","TEST_VAR2":"Debug var"}
[build] MSBuild version 17.4.0+18d5aef85 for .NET Framework
[build]   Checking Build System
[build]   Building Custom Rule C:/Users/calebmagiya/Documents/projects/practice/cpp/sample/CMakeLists.txt
[build]   main.cpp
[build]   sample.vcxproj -> C:\Users\calebmagiya\Documents\projects\practice\cpp\sample\build\default\Debug\sample.exe
[cmakefileapi-parser] Read reply folder: C:\Users\calebmagiya\Documents\projects\practice\cpp\sample\build\default\.cmake\api\v1\reply
[cmakefileapi-parser] Found index files: ["cache-v2-45376e1e0fd1190b10b9.json","cmakeFiles-v1-7ca12174dc0c5d54b42e.json","codemodel-v2-0668e7144e2332ce5b21.json","directory-.-Debug-d0094a50bb2071803777.json","directory-.-MinSizeRel-d0094a50bb2071803777.json","directory-.-Release-d0094a50bb2071803777.json","directory-.-RelWithDebInfo-d0094a50bb2071803777.json","index-2022-12-13T20-43-00-0500.json","target-ALL_BUILD-Debug-6a5e4fc7328d1ff4ece1.json","target-ALL_BUILD-MinSizeRel-6a5e4fc7328d1ff4ece1.json","target-ALL_BUILD-Release-6a5e4fc7328d1ff4ece1.json","target-ALL_BUILD-RelWithDebInfo-6a5e4fc7328d1ff4ece1.json","target-sample-Debug-073621441fabf1c9d320.json","target-sample-MinSizeRel-f38e922b10f896d45542.json","target-sample-Release-53fd8d283487667dd6ce.json","target-sample-RelWithDebInfo-78aa17bef0bbc316cef9.json","target-ZERO_CHECK-Debug-c6c67c2d4186596012ec.json","target-ZERO_CHECK-MinSizeRel-c6c67c2d4186596012ec.json","target-ZERO_CHECK-Release-c6c67c2d4186596012ec.json","target-ZERO_CHECK-RelWithDebInfo-c6c67c2d4186596012ec.json","toolchains-v1-777a92ef48bc79263443.json"]
[build] Build finished with exit code 0
[cache] Reading CMake cache file C:/Users/calebmagiya/Documents/projects/practice/cpp/sample/build/default/CMakeCache.txt
[cache] Parsing CMake cache string
[extension] [2571] cmake.launchTarget finished (returned {"name":"CMake/Launch - sample","processId":{},"creationOptions":{"name":"CMake/Launch - sample","env":{"ALLUSERSPROFILE":"C:\\ProgramData","ANDROID_SDK_ROOT":"C:\\dev\\android-sdk","APPDATA":"C:\\Users\\calebmagiya\\AppData\\Roaming","ChocolateyInstall":"C:\\ProgramData\\chocolatey","ChocolateyLastPathUpdate":"133108474694752903","ChocolateyToolsLocation":"C:\\tools","CommonProgramFiles":"C:\\Program Files\\Common Files","CommonProgramFiles(x86)":"C:\\Program Files (x86)\\Common Files","CommonProgramW6432":"C:\\Program Files\\Common Files","COMPUTERNAME":"LAPTOP-FTLGGKLC","ComSpec":"C:\\WINDOWS\\system32\\cmd.exe","CONAN_USER_HOME_SHORT":"C:\\dev\\.conan","DriverData":"C:\\Windows\\System32\\Drivers\\DriverData","ELECTRON_RUN_AS_NODE":"1","GOPATH":"C:\\Users\\calebmagiya\\go","HOMEDRIVE":"C:","HOMEPATH":"\\Users\\calebmagiya","JAVA_HOME":"C:\\Program Files\\Microsoft\\jdk-<IP_ADDRESS>-hotspot\\","LOCALAPPDATA":"C:\\Users\\calebmagiya\\AppData\\Local","LOGONSERVER":"\\\\LAPTOP-FTLGGKLC","MSYS_ROOT":"C:\\msys64","NEXTHINK":"C:\\Program Files\\Nexthink\\Collector","NUMBER_OF_PROCESSORS":"8","OneDrive":"C:\\Users\\calebmagiya\\OneDrive - Microsoft","OneDriveCommercial":"C:\\Users\\calebmagiya\\OneDrive - Microsoft","ORIGINAL_XDG_CURRENT_DESKTOP":"undefined","OS":"Windows_NT","Path":"C:\\Program Files\\Microsoft\\jdk-<IP_ADDRESS>-hotspot\\bin;C:\\Program Files (x86)\\Microsoft SDKs\\Azure\\CLI2\\wbin;C:\\WINDOWS\\system32;C:\\WINDOWS;C:\\WINDOWS\\System32\\Wbem;C:\\WINDOWS\\System32\\WindowsPowerShell\\v1.0\\;C:\\WINDOWS\\System32\\OpenSSH\\;C:\\Program Files\\dotnet\\;C:\\ProgramData\\chocolatey\\bin;C:\\Program Files (x86)\\MSBuild\\14.0\\Bin;C:\\Program Files\\Microsoft SQL Server\\130\\Tools\\Binn\\;C:\\Program Files\\Microsoft SQL Server\\150\\Tools\\Binn\\;C:\\Program Files\\Go\\bin;C:\\Program Files (x86)\\Gpg4win\\..\\GnuPG\\bin;C:\\Program Files\\Git\\cmd;C:\\Program Files\\CMake\\bin;C:\\Strawberry\\c\\bin;C:\\Strawberry\\perl\\site\\bin;C:\\Strawberry\\perl\\bin;C:\\dev\\android-sdk\\platform-tools;C:\\dev\\flutter\\bin;;C:\\Program Files\\Docker\\Docker\\resources\\bin;C:\\Users\\calebmagiya\\.cargo\\bin;C:\\Users\\calebmagiya\\AppData\\Local\\Programs\\Python\\Python310\\Scripts\\;C:\\Users\\calebmagiya\\AppData\\Local\\Programs\\Python\\Python310\\;C:\\Users\\calebmagiya\\AppData\\Local\\Microsoft\\WindowsApps;C:\\Users\\calebmagiya\\AppData\\Local\\Programs\\Fiddler;C:\\Users\\calebmagiya\\go\\bin;C:\\Users\\calebmagiya\\AppData\\Local\\Programs\\Microsoft VS Code\\bin;C:\\Users\\calebmagiya\\AppData\\Local\\JetBrains\\Toolbox\\scripts;C:\\Users\\calebmagiya\\.dotnet\\tools;C:\\Users\\calebmagiya\\AppData\\Local\\Microsoft\\WindowsApps;C:\\Users\\calebmagiya\\AppData\\Local\\nvs\\default;C:\\Users\\calebmagiya\\AppData\\Local\\nvs\\;C:\\Users\\calebmagiya\\AppData\\Local\\Programs\\oh-my-posh\\bin;C:\\Program Files (x86)\\Dr. Memory\\bin\\;","PATHEXT":".COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC","POSH_THEMES_PATH":"C:\\Users\\calebmagiya\\AppData\\Local\\Programs\\oh-my-posh\\themes","PROCESSOR_ARCHITECTURE":"AMD64","PROCESSOR_IDENTIFIER":"Intel64 Family 6 Model 142 Stepping 12, GenuineIntel","PROCESSOR_LEVEL":"6","PROCESSOR_REVISION":"8e0c","ProgramData":"C:\\ProgramData","ProgramFiles":"C:\\Program Files","ProgramFiles(x86)":"C:\\Program Files (x86)","ProgramW6432":"C:\\Program Files","PSModulePath":"C:\\Program Files\\WindowsPowerShell\\Modules;C:\\WINDOWS\\system32\\WindowsPowerShell\\v1.0\\Modules;C:\\Program Files (x86)\\Microsoft Azure Information Protection\\Powershell","PUBLIC":"C:\\Users\\Public","SESSIONNAME":"Console","SystemDrive":"C:","SystemRoot":"C:\\WINDOWS","TEMP":"C:\\Users\\CALEBM~1\\AppData\\Local\\Temp","TMP":"C:\\Users\\CALEBM~1\\AppData\\Local\\Temp","UATDATA":"C:\\Windows\\CCM\\UATData\\D9F8C395-CAB8-491d-B8AC-179A1FE1BE77","USERDNSDOMAIN":"africa.corp.microsoft.com","USERDOMAIN":"AFRICA","USERDOMAIN_ROAMINGPROFILE":"AFRICA","USERNAME":"calebmagiya","USERPROFILE":"C:\\Users\\calebmagiya","VCPKG_DOWNLOADS":"C:\\Users\\calebmagiya\\.vcpkg\\downloads","VS140COMNTOOLS":"C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\Common7\\Tools\\","VSCODE_AMD_ENTRYPOINT":"vs/workbench/api/node/extensionHostProcess","VSCODE_CODE_CACHE_PATH":"C:\\Users\\calebmagiya\\AppData\\Roaming\\Code\\CachedData\\5235c6bb189b60b01b1f49062f4ffa42384f8c91","VSCODE_CWD":"C:\\Users\\calebmagiya\\AppData\\Local\\Programs\\Microsoft VS Code","VSCODE_HANDLES_UNCAUGHT_ERRORS":"true","VSCODE_IPC_HOOK":"\\\\.\\pipe\\0d6ec62be47c6423f149c98e814ac9cf-1.74.0-main-sock","VSCODE_NLS_CONFIG":"{\"locale\":\"en-ke\",\"availableLanguages\":{},\"_languagePackSupport\":true}","VSCODE_PID":"14448","windir":"C:\\WINDOWS","ZES_ENABLE_SYSMAN":"1","TEST_VAR1":"Config var","_CMAKE_TOOLS_LAUNCH_TERMINAL_TARGET_NAME":"sample","_CMAKE_TOOLS_LAUNCH_TERMINAL_PATH":"C:\\Users\\calebmagiya\\AppData\\Local\\Microsoft\\WindowsApps\\Microsoft.PowerShell_8wekyb3d8bbwe\\pwsh.exe"},"cwd":"C:\\Users\\calebmagiya\\Documents\\projects\\practice\\cpp\\sample\\build\\default\\Debug"},"state":{"isInteractedWith":true},"dimensions":{"columns":165,"rows":18},"isPatched":true})

Additional Information
CMakePresets.json
{
    "version": 3,
    "configurePresets": [
        {
            "name": "default",
            "generator": "Visual Studio 17 2022",
            "binaryDir": "${sourceDir}/build/${presetName}",
            "environment": {
                "TEST_VAR1": "Config var"
            }
        }
    ],
    "buildPresets": [
        {
            "name": "default-debug",
            "configurePreset": "default",
            "configuration": "Debug",
            "environment": {
                "TEST_VAR2": "Debug var"
            }
        }
    ]
}

main.cpp
#include <cstdlib>
#include <iostream>

int main() {
  auto var1 = std::getenv("TEST_VAR1");
  auto var2 = std::getenv("TEST_VAR2");
  std::cout << "TEST_VAR1: " << (var1 ? var1 : "NULL") << '\n';
  std::cout << "TEST_VAR2: " << (var2 ? var2 : "NULL") << '\n';
  return 0;
}

Expected output
TEST_VAR1: Config var
TEST_VAR2: Debug var

Actual output
TEST_VAR1: Config var
TEST_VAR2: NULL

Neither of these variables should be there, It looks like we are sending the config variables for launch.

Well, the scenario is a little messy.  What we're trying to emulate in the extension is how a user might normally run cmake in a terminal.  With Kits, we configure the environment using VS Code settings and those follow you throughout your session (configure/build/debug/launch) because in Kits mode we treat your session kind of like a terminal session where once the environment is applied, it sticks around.
When presets came along, we reused this concept of "configure environment" and added the environment from the configurePreset to it out of convenience.  This results in doing the correct thing for cmake commands because the presets instruct us what to do with those environment variables.  But this breaks down during debug/launch which are not cmake commands.  When you use CMake with presets in a terminal, it is not required to configure the terminal environment beforehand. You can put the environment variables in the presets instead.  This does not modify your terminal session.  Our extension does effectively modify your "session" though.  The configure environment variables are currently leaking into the environment for debug/launch.
At the end of the day we have to guess which is potentially less confusing to users, whether to treat the presets "session" as a session containing the full environment for cmake configuration (which is what we currently do), or whether it should act as a clean environment and not "leak" the configurePreset environment into it.

If the environment variables aren't set by the extension, then it means users have to use a launch.json file to run a CMake target with the correct variables in multi-config generators.
As it is right now, I can get the application to run with environment variables from presets if I use a single configuration generator. When using a multi-config generator however, I can't set a variable that is configuration dependent (Debug vs Release) unless I duplicate the configure preset.
This isn't a blocker anymore since issue #2894 was fixed. But it would be nice if the extension supported this scenario without needing a launch.json

I think that I stumbled into a variant of this issue: the PATH variable, among others, gets leaked in the debug/launch terminals (but not in the "standard" vscode terminal - Ctrl-J).
If you depend on your global PATH env variable you can get misleading errors only when running/debugging inside VSCode (e.g. the search path for dlls is different).
I opened a SO question https://stackoverflow.com/q/75736796/2564990 describing the issue I'm encountering.
Is this the case? If yes can I overwrite the PATH variable again after it gets modified by the extension?


Shayan/feq 1614/replace hooks with usehooks ts

changes:

installed usehooks-ts
removed useEventListener, useIsomorphicLayoutEffect , useOnClickOutside  and useMediaQuery
removed useOnClickOutside from export list since it can be installed from usehooks-ts directly

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.6%) to 44.006%

Totals

Change from base Build<PHONE_NUMBER>:
0.6%

Covered Lines:
134

Relevant Lines:
302

💛  - Coveralls


[DDSDotcomShellContainer navigation links]: Navigation displays default

Description
When setting custom navLinks, the masthead still shows the default values
Component(s) impacted
DDSDotcomShellContainer
Stackblitz example: https://stackblitz.com/edit/github-setaig?file=src%2Findex.js
Browser
Chrome
Carbon for IBM.com version
v1.34.0
Severity
Severity 1 = The design is broken in a critical way that blocks users from completing tasks or damages the brand. Affects major functionality, no workaround.
Application/website
ideas.ibm.com
Package
@carbon/ibmdotcom-web-components
CodeSandbox example
https://stackblitz.com/edit/github-setaig?file=src%2Findex.js
Steps to reproduce the issue (if applicable)
Create a blank component
Set custom navLinks values
In some cases, the links are loaded as default, in other cases when the page is refreshed they change to the default
Release date (if applicable)
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate issues

@kshah11 Custom navigation links should be passed to masthead and not dotcom-shell. We'll double-check the documentation to make sure this is clear.
https://stackblitz.com/edit/github-setaig-zvbu7h

@kennylam thanks!
I seem to be getting a tsx error when trying to replicate the above, are you able to help with this?
TS2769: No overload matches this call.   Overload 1 of 2, '(props: ComponentProps | Readonly<ComponentProps>): DDSMastheadComposite', gave the following error.     Type '{ title: string; titleEnglish: string; url: string; }[]' is not assignable to type 'string'.   Overload 2 of 2, '(props: ComponentProps, context: any): DDSMastheadComposite', gave the following error.     Type '{ title: string; titleEnglish: string; url: string; }[]' is not assignable to type 'string'.


Low level system access

Raising this as a place holder as it might be covered by:
3.9 - Does this specification allow an origin access to aspects of a user’s local computing environment?
As use high performance timing, low level memory and CPU access poses it's own risks it might be worth mentioning as part of this questions notes.

Good point - this should at least be called out.

The UDP specification mentioned in this call for review is a good example of something like this:
http://www.w3.org/blog/news/archives/4746?pk_campaign=feed&pk_kwd=call-for-review-proposal-to-relicense-unfinished-sysapps-specification-tcp-and-udp-socket-api
The specification itself has a TODO issue for security considerations.


HBASE-23272 Fix link in Developer guide to "code review checklist"

I assume the Hadoop project moved their wiki around a bit.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

:green_heart:
mvninstall
5m 31s
master passed

:blue_heart:
refguide
6m  5s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

:green_heart:
mvninstall
4m 58s
the patch passed

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:blue_heart:
refguide
5m 34s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

:green_heart:
asflicense
0m 19s
The patch does not generate ASF License warnings.

24m 12s

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-805/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/805

Optional Tests
dupname asflicense refguide

uname
Linux 192ee7f3ca6e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-805/out/precommit/personality/provided.sh

git revision
master / f58bd4a7ac

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-805/1/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-805/1/artifact/out/patch-site/book.html

Max. process+thread count
96 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-805/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.


Update api server dependency

PR builder: https://github.com/wso2/product-is/actions/runs/359564875

Change is added from https://github.com/wso2/identity-rest-dispatcher/pull/295


New padding-right for the docs' left navigation

Browsing the docset, I noticed in the user guide that the left navigation links were too close
to the right edge of the menu.

I fixed this. I tested this a bit, I hope not to introduce graphic regressions.

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:dottorblaster/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

This will update the existing PR, so you do not need to open a new one.

LGTM - @fredlf @jamtur01 @spf13 @moxiegirl

LGTM


Output of decoder 2 *z_dim

Hi,
Could you please explain why the encoders output is z_dim * 2 and not just z_dim.
Thanks for the very clean repo.

for mean and logvar


DWpose fails to load

DWpose fails to load since the last update. I'm running in a docker container with python: 3.9.5 and torch: 1.13.0+rocm5.2 if that makes a difference.
Here's the log:
Full error log from comfyui_controlnet_aux:
Traceback (most recent call last):
  File "/sd/ComfyUI/custom_nodes/comfyui_controlnet_aux/__init__.py", line 32, in load_nodes
    module = importlib.import_module(
  File "/usr/lib/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 855, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "/sd/ComfyUI/custom_nodes/comfyui_controlnet_aux/node_wrappers/dwpose.py", line 5, in <module>
    from controlnet_aux.dwpose import DwposeDetector, AnimalposeDetector
  File "/sd/ComfyUI/custom_nodes/comfyui_controlnet_aux/src/controlnet_aux/dwpose/__init__.py", line 23, in <module>
    from .wholebody import Wholebody
  File "/sd/ComfyUI/custom_nodes/comfyui_controlnet_aux/src/controlnet_aux/dwpose/wholebody.py", line 35
    match self.det_model_type:
          ^
SyntaxError: invalid syntax

[comfyui_controlnet_aux] | INFO -> Some nodes failed to load:
	Failed to import module dwpose because SyntaxError: invalid syntax

@49RpK5dY I thought everyone have moved out to python 3.10

Thanks for the quick fix. There is pretty much a single docker image that works with my gpu based on ubuntu20.04 and it has python 3.9.5.


Error: [tsserver 2304] [E] Cannot find name 'connect'.

I'm not sure what your documentation means by "await connect(port,host)"
Here's my code:
import net from 'net';
import {PromiseSocket, TimeoutError} from "promise-socket";

interface HostConfig {
  host:string;
  timeout?:number;
}

export async function isPortReachable(port:number, config:HostConfig = {host:'',timeout:1000}):Promise<boolean> {
	if (config.host == '') {
		throw new Error(`Specify a host to find out if port ${port} is reachable.`);
	}

  const socket:net.Socket = new net.Socket();
  const promiseSocket = new PromiseSocket(socket);

  try {
    await connect(port, config.host);
  } catch (e) {
    if(e instanceof TimeoutError) {
      console.log(`Connection ${config.host}:${port} is not reachable.`);
      return false;
    }
    throw e;
  }

}

This gives:
Error: [tsserver 2304] [E] Cannot find name 'connect'.

If your documentation meant
await socket.connect(port,host)

I get:
[tsserver 80007] [I] 'await' has no effect on the type of this expression.

... which means socket.connect is not an async function, which makes sense because it's not using your library at all at that point.
What am I missing? What does await connect(...) mean?

Not sure this is still helpful, but it should be:
promiseSocket.connect(...)

Thanks! This was very helpful!

Closing because sgiacomel provided clarification.


no glow effect

I enabled everything according to the steps and it does not work

I have the same issue. When I install the original Synthwave'84 it works without any issue. But for some  reason Dark Synthwave doesn't.

I am having the same issue.

same issue

Hey y'all, I combined this with the latest Synthwave and the glow effect is working. Feel free to test it out: https://marketplace.visualstudio.com/items?itemName=SammyKumar.synthwave-dark-vscode

didn't work for me, I am using MacBook pro M2 pro

wfm on Linux but changing the brightness setting (and reactivating Neon Dreams and restarting) has no visible effect.  I wonder also how we could add glow to more of the colors?


update: Translation of Chinese web and value files

web file
value file

May I ask you a question ? Purely out of curiosity and technical discussion : How did you get my Steam account?
When my PR is completed, my Steam account has an additional badge.This makes me curious. My GitHub account and Steam account are theoretically unrelated, right?
So how can you accurately send it to my Steam?  ( •̀ .̫ •́ )✧

And  build is fail, According to the screenshot, because of the translation branch, its line of text is restored to English.
However, I really do not know what the situation is: I translated the documents, from the documents, everything is in accordance with the regulations. So, I don't know why merge is automatically replaced with English. Therefore, I need your help to check this problem.

In the meantime, I've translated thousands of lines. But according to GitHub, I only contributed one line of content. That's obviously not normal. Can I ask what's going on?

looks like you accidentally deleted part of the English line, so the script thinks the English string changed and resets the string.
I sent the medal to the Steam account that asked about translating the game on the forum after manually checking that it was probably the same person.


fix: do release

:tada: This PR is included in version 1.1.1 :tada:
The release is available on:

GitHub release
v1.1.1

Your semantic-release bot :package::rocket:


CIF Database access and other minor changes

Looks for database in local ~/.larch directory (cif_amcsd.db) before using smaller database in compiled code.
CIF from database searchable/plottable in viewer.
Moves results from database search to more logical panel
Removed some commented out code no longer needed.
Global value for default energy defined.

Additionally:

finished functions for saving 1D data from HDF5 map file or from diFFit1D viewing panel
fixed bug which occurred when calculating just one wedge
corrected start/end angle calculations for each wedge.


Add discord identity and validation

User Story
As user I want to set my discord account as network identity and validate it so that everyone recognizes me as a legit user.
Acceptance Criteria

setting discord ID as one of the identity fields is possible
1.1 the new field must be available also after chain resets or starting a chain initially
setting the discord ID should store the discordID raw onchain and triggers a discord bot sending a message to user
the user answers with his wallet ID in discord
the discord bot sends this message back to the chain and gets validated
4.1 if the wallet ID doesnt match the bot responds with an error
4.2 if the identity is valid the discord bot answers positive and closes the chat.
new identity field is exposed in the graph
user can see in polkadot.js the validation status which also is exposed to the graph.

Additional Information
sequence diagram draft:

https://www.figma.com/file/HcL8A8F5jUBOL9WtFRhwVV/Identity?node-id=404%3A162

How to test

enter your discord ID into the new filed in polkadot.js app --> accounts --> set idenity
submit
wait for the discord bot to popup in your discord
answer the bot with your wallet ID
see that you got validated for discord in your polkadot.js ui

After some investigation and testing, found out we already have bot logic to verify account.
This logic works but it should be triggered manually by sending message in discord.
Bot checks specified address, queries its identity from the chain and validates discord field in identity to match discord user id (numerical value). If those match, bot adds role to discord user, marking him as verified.
However no on-chain actions are performed (no registrar judgements given).

yes, wasn't this known before? we had this mechanism in place for beta I


no original sound quality and cover art

hi the original sound quality is missing
it suppose to be like in the studio with the artist all this sounds like poor quality FLAC and it would be nice if the cover art is 1500x1500 PNG and i wish the HIFI mode was uncompressed FLAC with true gapless and the master should sound like the original
studio tracks with full rang sound with true gapless uncompressed wav or FLAC with or without MQA encoded please fix this issue.

 Maybe you should go rip your own music.

it can only achieve the current sound quality


Add implementation of 'bcrypt' (for password hashing)

This could (perhaps) be based on https://bcrypt.codeplex.com/
Also, see http://stackoverflow.com/questions/481160/is-bcrypt-a-good-hashing-algorithm-to-use-in-c-where-can-i-find-it - particularly http://stackoverflow.com/a/6228051

Following a read of that SO answer and some research of my own, I will close this issue.  I will use PBKDF2 instead of bCrypt.


Failing connections after multiple requests

I have an ASP.NET Core Web application using EF Core 2.0. When performing a bunch of requests that retrieve data from the database, EF Core throws an error after approx. 100 requests. The database is an Azure SQL database and firewall settings are correct. Retrieving data works 80-90% of the times.
This issue has occurred on MacOS and Linux, we did not see it on Windows yet. It happens both on my development machine (Mac) as well as online (Linux). Since our production services are running in Docker, this creates a problem for us.
This is the stack trace of the error:
fail: Microsoft.EntityFrameworkCore.Database.Connection[20004]
      An error occurred using the connection to database 'databasename' on server 'azure-database'.
System.Data.SqlClient.SqlException (0x80131904): A network-related or instance-specific error occurred while establishing a connection to SQL Server. The server was not found or was not accessible. Verify that the instance name is correct and that SQL Server is configured to allow remote connections. (provider: TCP Provider, error: 40 - Could not open a connection to SQL Server)
   at System.Data.SqlClient.SqlInternalConnectionTds..ctor(DbConnectionPoolIdentity identity, SqlConnectionString connectionOptions, Object providerInfo, Boolean redirectedUserInstance, SqlConnectionString userConnectionOptions, SessionData reconnectSessionData, Boolean applyTransientFaultHandling)
   at System.Data.SqlClient.SqlConnectionFactory.CreateConnection(DbConnectionOptions options, DbConnectionPoolKey poolKey, Object poolGroupProviderInfo, DbConnectionPool pool, DbConnection owningConnection, DbConnectionOptions userOptions)
   at System.Data.ProviderBase.DbConnectionFactory.CreatePooledConnection(DbConnectionPool pool, DbConnection owningObject, DbConnectionOptions options, DbConnectionPoolKey poolKey, DbConnectionOptions userOptions)
   at System.Data.ProviderBase.DbConnectionPool.CreateObject(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection)
   at System.Data.ProviderBase.DbConnectionPool.UserCreateRequest(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection)
   at System.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, UInt32 waitForMultipleObjectsTimeout, Boolean allowCreate, Boolean onlyOneCheckConnection, DbConnectionOptions userOptions, DbConnectionInternal& connection)
   at System.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal& connection)
   at System.Data.ProviderBase.DbConnectionFactory.TryGetConnection(DbConnection owningConnection, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal oldConnection, DbConnectionInternal& connection)
   at System.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions)
   at System.Data.ProviderBase.DbConnectionClosed.TryOpenConnection(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions)
   at System.Data.SqlClient.SqlConnection.TryOpen(TaskCompletionSource`1 retry)
   at System.Data.SqlClient.SqlConnection.Open()
   at Microsoft.EntityFrameworkCore.Storage.RelationalConnection.Open(Boolean errorsExpected)
ClientConnectionId:00000000-0000-0000-0000-000000000000

After a couple of these exceptions, the application crashes with the following error:
dotnet(66933,0x700003cf5000) malloc: *** error for object 0x7fd47fac86d0: pointer being freed was not allocated
*** set a breakpoint in malloc_error_break to debug

The queries that are being performed before the error occurs look like this:
Microsoft.EntityFrameworkCore.Database.Command:Information: Executed DbCommand (27ms) [Parameters=[@___teamId_0='XXX' , @__p_1='X', @__p_2='X'], CommandType='Text', CommandTimeout='30']
SELECT [e.ProjectMembers].[Id], [e.ProjectMembers].[CreatedBy], [e.ProjectMembers].[CreatedOn], [e.ProjectMembers].[DeletedBy], [e.ProjectMembers].[DeletedOn], [e.ProjectMembers].[IsResponsible], [e.ProjectMembers].[ProjectId], [e.ProjectMembers].[ProjectRoleId], [e.ProjectMembers].[TeamId], [e.ProjectMembers].[UpdatedBy], [e.ProjectMembers].[UpdatedOn], [e.ProjectMembers].[UserId]
FROM [projects].[ProjectMembers] AS [e.ProjectMembers]
INNER JOIN (
    SELECT DISTINCT [t1].*
    FROM (
        SELECT [e1].[Id]
        FROM [projects].[Projects] AS [e1]
        LEFT JOIN [projects].[ProjectTypes] AS [e.ProjectType1] ON [e1].[ProjectTypeId] = [e.ProjectType1].[Id]
        LEFT JOIN [projects].[ProjectTypes] AS [e.SalesType1] ON [e1].[SalesTypeId] = [e.SalesType1].[Id]
        LEFT JOIN [projects].[ProjectStatuses] AS [e.ProjectStatus1] ON [e1].[ProjectStatusId] = [e.ProjectStatus1].[Id]
        WHERE ([e1].[TeamId] = @___teamId_0) AND [e1].[DeletedOn] IS NULL
        ORDER BY [e1].[Id]
        OFFSET @__p_1 ROWS FETCH NEXT @__p_2 ROWS ONLY
    ) AS [t1]
) AS [t2] ON [e.ProjectMembers].[ProjectId] = [t2].[Id]
ORDER BY [t2].[Id]

Steps to reproduce
We use the new Context Pooling like this:
services.AddDbContextPool<TDbContext>(
                options => options.UseSqlServer(connectionString,
                    sqlOptions =>
                    {
                        sqlOptions.EnableRetryOnFailure(maxRetryCount: 5,
                        maxRetryDelay: TimeSpan.FromSeconds(3),
                        errorNumbersToAdd: null);
                    })
                    .EnableSensitiveDataLogging()
                );

The connection string looks like this (everything else is default):
Data Source=azure-database;Initial Catalog=databasename;Integrated Security=False;User ID=XXX;Password=XXX

Further technical details
EF Core version: 2.0.0
Database Provider: Microsoft.EntityFrameworkCore.SqlServer, Azure SQL
Operating system: MacOS
IDE: VS Code 1.18.1

This looks like an issue with SQLClient (or below) so moved to https://github.com/dotnet/corefx/issues/25761


support wasm and async

This is a bit of a WIP PR, and I'm a Rust newbie so sorry for any obvious
mistakes. With these changes I was able to successfully symbolicate a crash in
the browser using a "FetchSymbolSupplier" to fetch symbols from a
CORS-supporting symbol server (see code below).
There are two main changes here:

Elide non-wasm-compatible code using #[cfg(not(target_arch = "wasm32"))].
The only place this is necessary is for usages of the memmap crate.
Make SymbolSupplier async, to support using fetch() in the browser.

Of these, the second change is far more invasive. I'd happily change the
approach if there were a less invasive way to allow fetching symbols in the
browser--for example, there might be a way to have a "cooperative" scheduler
for fetching symbols that allowed all the rust code to be synchronous, e.g. by
returning something like Err(MissingSymbolFile(debug_id = ..., name = ...))
when a symbol file is missing, so that then the "driver" can go fetch that
symbol asynchronously, and once that's done, retry processing with that symbol
file being synchronously available, and possibly receiving another "symbol file
missing" error & repeating the process.
Is this a change that would potentially be considered mergeable? Either in part
or in whole?
/// An implementation of `SymbolSupplier` that loads Breakpad text-format symbols from HTTP
/// URLs over fetch().
pub struct FetchSymbolSupplier {
    /// URLs to search for symbols.
    urls: Vec<String>,
}

impl FetchSymbolSupplier {
    pub fn new(
        urls: Vec<String>,
    ) -> FetchSymbolSupplier {
        let urls = urls
            .into_iter()
            .map(|mut u| {
                if !u.ends_with('/') {
                    u.push('/');
                }
                u
            })
            .collect();
        FetchSymbolSupplier {
            urls,
        }
    }
}

async fn fetch_symbol_file(
    base_url: &str,
    rel_path: &str,
) -> Result<Vec<u8>, Error> {
    let url = base_url.to_owned() + rel_path;
    let mut opts = RequestInit::new();
    opts.method("GET");
    opts.mode(RequestMode::Cors);
    opts.cache(RequestCache::ForceCache);

    let request = Request::new_with_str_and_init(&url, &opts).unwrap();

    let window = web_sys::window().unwrap();
    let resp_value = JsFuture::from(window.fetch_with_request(&request)).await.map_err(|_| Error::IoError)?;

    assert!(resp_value.is_instance_of::<Response>());
    let resp: Response = resp_value.dyn_into().unwrap();

    let buf = JsFuture::from(resp.array_buffer().unwrap()).await.unwrap();

    let typebuf = js_sys::Uint8Array::new(&buf);
    let mut body = vec![0; typebuf.length() as usize];
    typebuf.copy_to(&mut body[..]);
    Ok(body.to_vec())
}

#[async_trait(?Send)]
impl SymbolSupplier for FetchSymbolSupplier {
    async fn locate_symbols(&self, module: &dyn Module) -> SymbolResult {
        log("here");
        // Check local paths first.
        if let Some(rel_path) = relative_symbol_path(module, "sym") {
            for ref url in self.urls.iter() {
                if let Ok(buf) =
                    fetch_symbol_file(url, &rel_path).await
                {
                    return SymbolFile::from_bytes(&buf)
                        .map(SymbolResult::Ok)
                        .unwrap_or_else(SymbolResult::LoadError);
                }
            }
        }
        SymbolResult::NotFound
    }
}

Oh wow! So anything involving breakpad_symbols is a bit of a dead end, because I'm hoping to do #159 some time this month, and that will result in all of breakpad_symbols being deprecated (and deleted?).
I'm less certain on the async stuff. Could you elaborate a bit more on the need for an async API in the browser? What are you trying to build?
Hey @jan-auer and @swatinem -- is symbolic like, at all compatible with being compiled to wasm and used in the browser?

@Gankra ah, cool, thanks for the heads up :)
The main reason we need an async API for fetching symbols in the browser is because it's not possible to do anything synchronous involving the network in the browser. The only available networking APIs are asynchronous, and webassembly is not currently "pausable" without arcane voodoo like https://github.com/WebAssembly/binaryen/blob/main/src/passes/Asyncify.cpp. I'm not aware of systems which make use of this sort of thing in Rust to "fake" the asynchronous parts, but maybe they exist?

Sorry I mean like, what are you trying to build? Is this for some particular product? A hobby project? (Trying to figure out how much energy I can justify putting into getting this to work -- it would help if y'all were committing to some ongoing maintenance of this feature.)

My goal is to build a tool for easy symbolication of Electron's crash dumps, allowing the user to drag a crash dump into a web page and get a symbolicated crash.
I support Electron as part of my full-time work, and this would fall under that category, so I'm happy to contribute some ongoing energy to maintaining this as long as Electron remains my full-time job. However, as mentioned, I'm far from a Rust expert, so my assistance might not always be terribly useful 😅

Oh wow! Ok. Uhh gonna ping my manager (Mozilla) about this since this seems like a fruitful collaboration.

You may also be interested in the profiler-get-symbols project, which only handles symbolication but not unwinding / minidump parsing. It is designed for situations where you have build artifacts from the to-be-symbolicated binary stored on your local machine. It does not communicate with a symbol server.

@mstange I specifically want to fetch symbols from a symbol server, so unfortunately that's not terribly useful to me.

Ok so currently this is a bit of a difficult thing to review/merge for a few reasons:

Someone needs to write a test harness that will compile this to wasm and run it under wasmtime so that it doesn't break
All the code this touches is being heavily rewritten

Most notably breakpad-symbols will ideally be replaced with symbolic, which is a much bigger thing with much more complex of a design and actual downstream users that will presumably make an async-ification a large project.

I don't think I have the time to spare this month ensuring this works / doesn't break / makes sense

My main question is: what's your timeline like for this crashreporting project?
Is this something you need to get done this week? Something you expect to take a year? Short-term I think you'll just need to fork us. Long-term we could probably help get this done in collaboration with the symbolic folks.

It's not urgent. Probably the best thing to do for now is to keep wasm in mind as you do the symbolic rewrite / other rewrites, so hopefully it doesn't get significantly harder to do this in future. I'm OK with closing out this PR for now and trying again once the rewrites land.

SGTM


Data List

For those times where you have a field text, and you want to have suggestions but you are not limited by those suggestions, it's still free text, I have not found a way to create a datalist with this Library, or did I read the documentation way too swiftly?

Sorry for not coming back to you sooner — would you mind posting your working solution here so I can maybe add a note in the Wiki for others that wish to do the same ?
Thanks !

Hi, sure, I just realized the site 404'd.
I just added this line after calling the library
  JSONForm.fieldTypes.datalist={inputfield:true,fieldtemplate:true,template:"<input list=\"<%= id %>-list\" id=\"<%= id %>\" name=\"<%= node.name %>\" class='form-control<%= (fieldHtmlClass ? \" \" + fieldHtmlClass : \"\") %>'<%= (node.schemaElement && node.schemaElement.disabled? \" disabled\" : \"\")%><%= (node.schemaElement && node.schemaElement.required ? \" required='required'\" : \"\") %>/><datalist id=\"<%= id %>-list\"> <% _.each(node.options, function(key, val) { if(key instanceof Object) {  %> <option value=\"<%= key.value %>\"><%= key.title %></option> <% } else { %><option value=\"<%= key %>\"><%= key %></option> <% }}); %> </datalist>"};

and I put "type":"datalist" on the keys where I want to use them.

Thanks !


Port hover documentation

Note: The "Reveal Children on Hover" example is not displaying correctly. I copied and pasted the example from the current docs. Does it need to be changed in some manner for this version?

Thanks!

The "Reveal Children on Hover" example is not displaying correctly. I copied and pasted the example from the current docs. Does it need to be changed in some manner for this version?

Looks like there's a typo in the original docs html so this new version of docs won't render it correctly. I'll get a fix in for that shortly!


We may need to separate "subscriptions/search" into two separate endpoints?

Currently "subscriptions/search" endpoint supports both search by user id and reverse lookup for label conditions. Both dont sit together. So we may need to separate them into two

subscriptions/search
-subscriptions/reverse-lookup

I have created a new endpoint - "subscriptions/match". This will return all the subscription whose conditional expression matches the given input labels.


orientation issue

The top of the SVG I am converting is oriented just west of north. When converted with svg2geojson it scales and centers the image correctly but it ends up rotated and mirrored. The bounding rect of my SVG ends up oriented perfectly north-south / east-west in the geojson.
test.svg.txt
test.geojson.txt

Confirmed. When I wrote this I knew that I was making an assumption that SVG Y axis was aligned with north up. This is what the cryptic  second bullet point in the TODO section of the readme refers to.
How important is this to you? Would entering four registration points work for you?

I was able to get what I needed by hacking in my own converter. Not a rush, but for my use case the best solution is using my own coordinate converter. If there was a way to pass that in I would be golden. Thanks!

To be clear, the sort of converter you're taking about is supplying a custom function that is supplied an SVG coordinate pair, and you return a GPS long/lat pair? That's a moderately simple change that is be happy to add as an option on the library side. I'll also consider if there's a reasonable way to make that happen using the command-line converter.

I am having similar issues regarding orientation. Can you guide as to what I can do solve this or some example of convertor that solves this?

@Aditya-Sh Can you please be very clear about what your situation is? I'd be happy to help with a solution, but I want to ensure that I'm satisfying the need correctly.

Hello, the problem I am facing is my svg is not oriented properly when converted to geojson.

As you see in the image, i want top of my svg to be parallel with 'CARR ST' on map. Am I not providing proper geo tags or something else is wrong?

Thanks for the details. You're not doing anything wrong. I just have not implemented any feature to allow rotation. Which of the following options would you prefer?

Specify an angle to rotate north along with your two corners.

Use three corners to represent a rotated rectangle.

Use four corners to represent arbitrary points on the map. This might also be used to stretch or skew the map in addition to rotating it, but (if I do the math right) should work without skew if your SVG and GPS coordinates are consistent.

BTW, after I made my graphics I realize that they don't really match your specific situation, since you actually want your buildings to rotate counter-clockwise, and the graphics for 1 and 2 would end up rotating the other way.

Hi  Phrogz,
Aditya and I are looking at this issue together and I was thinking which option is better to handle any common projection we use for conversion.
I think if first option can be easily achieved if we provide additional info like rotation point and angle of rotation to existing inputs for conversion. But I don't know how it will work for different
projections.
If above is not a feasible or complex solution than option 3 is better solution.


Enable Lua filter

Currently contour deploys three Envoy http filters to each configured listener. The list doesn't seem to be extensible or definable. Is deploying additional user-configured filters a supported feature?

If this feature isn't available is there prior art to accomplishing this? I'm specifically looking into adding Lua filters for each listeners.

Thank you for your question. In general we prefer too choose reasonable defaults, or enable requested features without an option to turn them off. Making things configurable means we have to be able to support, both in slack, issues, and our commercial support offerings, people wanting to change those configurations. This has a cost for our support staff and a cost for the development team to handle escalations.
Specifically adding support for Lua means we would commit to helping people debug their Lua scripts embedded in Envoy. To not do so, to enable the feature but say we can't help you use it is not an option for us -- once we sell a support contract, our customers are not interested in nit picking over which features are supported or not.
So, the short answer is its unlikely that we'll add general Lua support to Contour. Can I turn the question around and ask you what is the problem you are trying to solve, perhaps there is a way to solve it without having to open the can of worms that is Lua embedded inside Envoy.

So one option I would like to propose here @davecheney is that perhaps there is a core library/api that configures envoy using primitives of some sort, which then ingress/ingress-route utilize to fulfill their apis. This way you sort of get the best of both worlds, advanced users can configure however they like using the primitives, and simple use cases can leverage the basic apis. WDYT?

@pbarker without knowing the problems the @A-And is facing I'm wary about proposing any solution. As I said above

Can I turn the question around and ask you what is the problem you are trying to solve, perhaps there is a way to solve it without having to open the can of worms that is Lua embedded inside Envoy.

@pbarker its unlikely we'll enable the lua filter in envoy because there is no way to make it safe to use in a multi tenant environment--its too easy to lock up the LUA event loop and block other traffic.
If you want to use envoy as a host for some lua routing logic you may be better served deploying envoy directly and using a static configuration (not Contour's dynamic configuration) to handle traffic for your application. If that sounds interesting we can work together on this out of band.

The decision is we will not enable the lua filter in Contour deployed Envoys because it is reasonable to audit the lua code that someone may inject into Envoy via Contour making the Lua filter unsuitable for use in a multi tenant environment.