centerSlice throws exception when scaling down

This seems closely related to https://github.com/flutter/flutter/issues/20013, but I'm not sure whether it is the same issue.
I have two images that are being used as resolution-aware assets: the "main" asset is 68x46, and the 3.0x pixel ratio version is 208x142. If I use the asset in an Image widget with no centerSlice it works fine -- the 3.0x version is rendered at the same size as the lower-res main image as expected. I can set the width and height properties and they work as well.
Next, if I include only the main asset and give it a centerSlice and set the size of the Image to 100x46 everything still works okay, the centerSlice is applied properly, and everything looks good.
However, as soon as I add the 3.0x version, Flutter fails an assertion and throws an error about the BoxFit being wrong (even though it isn't) and says to create an issue here.
It seems the problem is something to do with the centerSlice processing not handling the scaling correctly. The only way I can make the error go away is to set the height and width of the Image to something that is equal to or greater than the actual size of the 3.0x image. Of course, that is not an actual solution because then the image renders at that larger size instead of what it should be.
Logs
I/flutter (10662): ══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
I/flutter (10662): The following assertion was thrown during paint():
I/flutter (10662): centerSlice was used with a BoxFit that does not guarantee that the image is fully
visible.
I/flutter (10662): 'package:flutter/src/painting/decoration_image.dart': Failed assertion: line 406 pos 12: 'sourceSize
I/flutter (10662): == inputSize'
I/flutter (10662):
I/flutter (10662): Either the assertion indicates an error in the framework itself, or we should provide substantially
I/flutter (10662): more information in this error message to help you determine and fix the underlying cause.

I/flutter (10662): ════════════════════════════════════════════════════════════════════════════════════════════════════

No issues found! (ran in 21.0s)

[√] Flutter (Channel beta, v1.1.8, on Microsoft Windows [Version 10.0.17763.55], locale en-US)
    • Flutter version 1.1.8 at C:\Users\Caleb\flutter
    • Framework revision 985ccb6d14 (5 weeks ago), 2019-01-08 13:45:55 -0800
    • Engine revision 7112b72cc2
    • Dart version 2.1.1 (build 2.1.1-dev.0.1 ec86471ccc)

[!] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at C:\Users\Caleb\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
    X Android license status unknown.

[√] Android Studio (version 3.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 32.0.1
    • Dart plugin version 182.5124
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[√] VS Code (version 1.31.0)
    • VS Code at C:\Users\Caleb\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 2.22.3

[√] Connected device (1 available)
    • Pixel 2 XL • 709KPNY0046767 • android-arm64 • Android 9 (API 28)

! Doctor found issues in 1 category.

To investigate we would need a minimal runnable reproduction
ideally published as a GitHub repo.

@zoechi Sure. I didn't have time to put one together last night, but here you go: https://github.com/Herohtar/center_slice
I've included a screenshot of the main window and the exception thrown by Flutter. Note that the exception can be made to go away by setting the height to something that is very close to the actual height of the higher-res image (in this case, setting it to 79 or higher works); however, that makes it impossible to use resolution-aware images with centerSlice in cases where the desired dimensions are less than the auto-selected image.

I/flutter ( 7544): ══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
I/flutter ( 7544): The following assertion was thrown during paint():
I/flutter ( 7544): centerSlice was used with a BoxFit that does not guarantee that the image is fully
visible.
I/flutter ( 7544): 'package:flutter/src/painting/decoration_image.dart': Failed assertion: line 406 pos 12: 'sourceSize
I/flutter ( 7544): == inputSize'
I/flutter ( 7544):
I/flutter ( 7544): Either the assertion indicates an error in the framework itself, or we should provide substantially
I/flutter ( 7544): more information in this error message to help you determine and fix the underlying cause.
I/flutter ( 7544): In either case, please report this assertion by filing a bug on GitHub:
I/flutter ( 7544):   https://github.com/flutter/flutter/issues/new?template=BUG.md
I/flutter ( 7544):
I/flutter ( 7544): When the exception was thrown, this was the stack:
I/flutter ( 7544): #2      paintImage (package:flutter/src/painting/decoration_image.dart:406:12)
I/flutter ( 7544): #3      RenderImage.paint (package:flutter/src/rendering/image.dart:357:5)
I/flutter ( 7544): #4      RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2094:7)
I/flutter ( 7544): #5      PaintingContext.paintChild (package:flutter/src/rendering/object.dart:173:13)
I/flutter ( 7544): #6      _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.paint (package:flutter/src/rendering/proxy_box.dart:122:15)
I/flutter ( 7544): #7      RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2094:7)
I/flutter ( 7544): #8      PaintingContext.paintChild (package:flutter/src/rendering/object.dart:173:13)
I/flutter ( 7544): #9      _RenderFlex&RenderBox&ContainerRenderObjectMixin&RenderBoxContainerDefaultsMixin.defaultPaint (package:flutter/src/rendering/box.dart:2273:15)
I/flutter ( 7544): #10     PaintingContext.pushClipRect.<anonymous closure> (package:flutter/src/rendering/object.dart:396:83)
I/flutter ( 7544): #11     ClipContext._clipAndPaint (package:flutter/src/painting/clip.dart:29:12)
I/flutter ( 7544): #12     ClipContext.clipRectAndPaint (package:flutter/src/painting/clip.dart:57:5)
I/flutter ( 7544): #13     PaintingContext.pushClipRect (package:flutter/src/rendering/object.dart:396:7)
I/flutter ( 7544): #14     RenderFlex.paint (package:flutter/src/rendering/flex.dart:940:13)
I/flutter ( 7544): #15     RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2094:7)
I/flutter ( 7544): #16     PaintingContext.paintChild (package:flutter/src/rendering/object.dart:173:13)
I/flutter ( 7544): #17     RenderShiftedBox.paint (package:flutter/src/rendering/shifted_box.dart:70:15)
I/flutter ( 7544): #18     RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2094:7)
I/flutter ( 7544): #19     PaintingContext.paintChild (package:flutter/src/rendering/object.dart:173:13)
I/flutter ( 7544): #20     _RenderCustomMultiChildLayoutBox&RenderBox&ContainerRenderObjectMixin&RenderBoxContainerDefaultsMixin.defaultPaint (package:flutter/src/rendering/box.dart:2273:15)
I/flutter ( 7544): #21     RenderCustomMultiChildLayoutBox.paint (package:flutter/src/rendering/custom_layout.dart:361:5)
I/flutter ( 7544): #22     RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2094:7)
I/flutter ( 7544): #23     PaintingContext.paintChild (package:flutter/src/rendering/object.dart:173:13)
I/flutter ( 7544): #24     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.paint (package:flutter/src/rendering/proxy_box.dart:122:15)
I/flutter ( 7544): #25     _RenderInkFeatures.paint (package:flutter/src/material/material.dart:491:11)
I/flutter ( 7544): #26     RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2094:7)
I/flutter ( 7544): #27     PaintingContext.paintChild (package:flutter/src/rendering/object.dart:173:13)
I/flutter ( 7544): #28     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.paint (package:flutter/src/rendering/proxy_box.dart:122:15)
I/flutter ( 7544): #29     PaintingContext.pushLayer (package:flutter/src/rendering/object.dart:370:12)
I/flutter ( 7544): #30     RenderPhysicalModel.paint (package:flutter/src/rendering/proxy_box.dart:1704:17)
I/flutter ( 7544): #31     RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2094:7)
I/flutter ( 7544): #32     PaintingContext.paintChild (package:flutter/src/rendering/object.dart:173:13)
I/flutter ( 7544): #33     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.paint (package:flutter/src/rendering/proxy_box.dart:122:15)
I/flutter ( 7544): #34     RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2094:7)
I/flutter ( 7544): #35     PaintingContext.paintChild (package:flutter/src/rendering/object.dart:173:13)
I/flutter ( 7544): #36     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.paint (package:flutter/src/rendering/proxy_box.dart:122:15)
I/flutter ( 7544): #37     RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2094:7)
I/flutter ( 7544): #38     PaintingContext._repaintCompositedChild (package:flutter/src/rendering/object.dart:128:11)
I/flutter ( 7544): #39     PaintingContext.repaintCompositedChild (package:flutter/src/rendering/object.dart:96:5)
I/flutter ( 7544): #40     PipelineOwner.flushPaint (package:flutter/src/rendering/object.dart:855:29)I/flutter ( 7544): #41     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding.drawFrame (package:flutter/src/rendering/binding.dart:283:19)
I/flutter ( 7544): #42     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding&WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:686:13)
I/flutter ( 7544): #43     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:219:5)
I/flutter ( 7544): #44     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:990:15)
I/flutter ( 7544): #45     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:930:9)
I/flutter ( 7544): #46     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:842:5)
I/flutter ( 7544): #47     _invoke (dart:ui/hooks.dart:159:13)
I/flutter ( 7544): #48     _drawFrame (dart:ui/hooks.dart:148:3)
I/flutter ( 7544): (elided 2 frames from class _AssertionError)
I/flutter ( 7544):
I/flutter ( 7544): The following RenderObject was being processed when the exception was fired:
I/flutter ( 7544):   RenderImage#460e1 relayoutBoundary=up4
I/flutter ( 7544):   creator: RawImage ← Semantics ← Image ← Column ← Center ← MediaQuery ←
I/flutter ( 7544):   LayoutId-[<_ScaffoldSlot.body>] ← CustomMultiChildLayout ← AnimatedBuilder ← DefaultTextStyle ←
I/flutter ( 7544):   AnimatedDefaultTextStyle ← _InkFeatures-[GlobalKey#7871d ink renderer] ← ⋯
I/flutter ( 7544):   parentData: <none> (can use size)
I/flutter ( 7544):   constraints: BoxConstraints(0.0<=w<=411.4, 0.0<=h<=Infinity)
I/flutter ( 7544):   size: Size(300.0, 60.0)
I/flutter ( 7544):   image: [80×80]
I/flutter ( 7544):   width: 300.0
I/flutter ( 7544):   height: 60.0
I/flutter ( 7544):   scale: 2.0
I/flutter ( 7544):   fit: fill
I/flutter ( 7544):   alignment: center
I/flutter ( 7544):   centerSlice: Rect.fromLTRB(19.0, 19.0, 21.0, 21.0)
I/flutter ( 7544):   invertColors: false
I/flutter ( 7544):   filterQuality: low
I/flutter ( 7544): This RenderObject has no descendants.
I/flutter ( 7544): ════════════════════════════════════════════════════════════════════════════════════════════════════

After looking into this a bit more, it seems this isn't really about resolution-aware images at all. The problem is that Flutter throws an error if either the destination height or width are less than the corresponding dimension in the source image and the centerSlice is proportionately small. For example, with the 40x40 source image, if I try to use centerSlice: Rect.fromLTRB(19, 19, 21, 21) with height: 30 it will fail. Alternatively, centerSlice: Rect.fromLTRB(5, 5, 35, 35) works fine with the same height (30).
I believe the root of the problem is within this section of the image drawing function: https://github.com/flutter/flutter/blob/7aeb539da9faa7dfb95c2459cdfb2ee5d48b1ba4/packages/flutter/lib/src/painting/decoration_image.dart#L385-L407
Specifically, when centerSlice defines a very small center rectangle it will result in a large sliceBorder. Then, when any part of the outputSize is smaller than the inputSize, the following outputSize -= sliceBorder will result in some negative values, which are then fed into applyBoxFit, which immediately spits out all zeros for both source and destination. Obviously, since zero doesn't match the initial input size, the assert fails.
This problem seems to come from the (mistaken) idea that the corners of centerSlice'd images are never scaled, as the comments state that the corner pieces are drawn without scaling; however, the documentation for the underlying drawImageNine function indicates that scaling down is a potential valid behavior:

Corners are unmodified or scaled down proportionately if their sides are larger than dst. center and four sides are scaled to fit remaining space, if any.

I'm not entirely certain how this needs to be modified, but it seems it needs to allow for scaling down when using centerSlice, and also will need to take the scale into account so that resolution-aware images are handled properly, as I believe there is still an issue with that.

I found the problem too; As you said, centerSlice's unit is 'px', but outputSize's unit is 'dp'; My advice is to  re-calculate the centerSlice according to 'scale', and pass new value of centerSlice to canvas;

Or can we just remove such codes:
if (centerSlice != null) {
sliceBorder = Offset(
centerSlice.left + inputSize.width - centerSlice.right,
centerSlice.top + inputSize.height - centerSlice.bottom,
);
outputSize -= sliceBorder;
inputSize -= sliceBorder;
}
As mentioned in the issue:
https://github.com/flutter/flutter/issues/20013
I also made the same test, if sliceBorder related codes were removed, all works fine

Furthermore, On line: 393
https://github.com/flutter/flutter/blob/beta/packages/flutter/lib/src/painting/decoration_image.dart
outputSize was reduced by sliceBorder;
but on line :402 , outputSize was restored again, with nothing changed
After 'applyBoxFit(fit, inputSize / scale, outputSize)' , destinationSize == outputSize and sourceSize == inputSize because 'fit == BoxFit.fill'
After line 407,  destinationSize was restored to 'rect.size' again (line: 385)
So I think, line 393, 394, 402,403, 406 are useless, and we should remove all of them;
Forget about my poor English  :)

/cc @dnfield FYI for image related stuff.

Although Skia isn't documented this way, the Flutter API is: https://api.flutter.dev/flutter/dart-ui/Canvas/drawImageNine.html
That said, the Flutter API here is really just a thin wrapper around Skia - perhaps the Skia API has changed over time since the Flutter API was written, or perhaps this was just a mistake from the start.  We should probably update the engine docs on this though.

@dnfield Which way do you mean when you say "Skia isn't documented this way"?
The Flutter API simply states that the corners are not scaled at all, and doesn't mention what happens if you scale up vs down. Whereas the Skia documentation clearly defines the behavior:

If the dst is >= the image size, then...

The 4 corners are not stretched at all.
The sides are stretched in only one axis.
The center is stretched in both axes. Else, for each axis where dst < image,
The corners shrink proportionally
The sides (along the shrink axis) and center are not drawn

Skia's drawImageNine is not documented this way, but Flutter's API says:

The four regions in the corners are drawn, without scaling, in the four corners of the destination rectangle described by dst.

Which is similar to the way Android documents this behavior.
I'm not opposed to fixing this if it's possible, and I'm also not opposed to updating the Flutter documentation to match the Skia documentation.
I started poking at this at one point but have been too caught up in other tasks.  I will get back to it eventually if no one else does.

I guess I'm confused about where else drawImageNine is documented besides the Flutter API and Skia API. How/where does Android document it?

Hmm.  I was sure I had found android docs that read like this, but now I cannot :)  I think the Flutter docs are just wrong.

Hi @Herohtar
testing the code below with the latest master
code
import 'package:flutter/material.dart';
import 'dart:ui';

void main() => runApp(
      const MyApp(
        key: Key('app'),
      ),
    );

class MyApp extends StatelessWidget {
  const MyApp({Key key}) : super(key: key);

  @override
  Widget build(BuildContext context) => MaterialApp(
        home: const MyHomePage(
          key: Key('home'),
        ),
      );
}

class MyHomePage extends StatelessWidget {
  const MyHomePage({Key key}) : super(key: key);

  static const String _url =
      'https://i.ytimg.com/vi/HjZxyTJzvYg/maxresdefault.jpg';

  @override
  Widget build(BuildContext context) => Material(
        child: Center(
            child: Image.network(
          _url,
          centerSlice: Rect.fromLTWH(15.5, 15.5, 1, 1),
          scale: window.devicePixelRatio,
        )),
      );
}

logs

doctor
[✓] Flutter (Channel master, 1.21.0-6.0.pre.90, on Mac OS X 10.15.5 19F101, locale en-GB)
    • Flutter version 1.21.0-6.0.pre.90 at /Users/nevercode/development/flutter_master
    • Framework revision 531ee9452a (4 hours ago), 2020-07-29 02:26:03 -0400
    • Engine revision 1ba310017c
    • Dart version 2.10.0 (build 2.10.0-1.0.dev 24c7666def)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/nevercode/Library/Android/sdk
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.2

[✓] Connected device (4 available)
    • Pixel 3a (mobile) • 965AY0WP5C • android-arm64  • Android 10 (API 29)
    • macOS (desktop)   • macos      • darwin-x64     • Mac OS X 10.15.5 19F101
    • Web Server (web)  • web-server • web-javascript • Flutter Tools
    • Chrome (web)      • chrome     • web-javascript • Google Chrome 84.0.4147.105

• No issues found!

the issue still occurs
Thank you

This issue is replicable using latest stable and master versions.

 updated runnable code sample

import 'package:flutter/material.dart';
import 'dart:ui';

void main() => runApp(
  const MyApp(
    key: Key('app'),
  ),
);

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) => MaterialApp(
    home: const MyHomePage(
      key: Key('home'),
    ),
  );
}

class MyHomePage extends StatelessWidget {
  const MyHomePage({Key? key}) : super(key: key);

  static const String _url =
      'https://i.ytimg.com/vi/HjZxyTJzvYg/maxresdefault.jpg';

  @override
  Widget build(BuildContext context) => Material(
    child: Center(
      child: Image.network(
        _url,
        centerSlice: Rect.fromLTWH(15.5, 15.5, 1, 1),
        scale: window.devicePixelRatio,
      ),
    ),
  );
}

 stable, master flutter doctor -v

[✓] Flutter (Channel stable, 3.3.5, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.3.5 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d9111f6402 (10 hours ago), 2022-10-19 12:27:13 -0700
    • Engine revision 3ad69d7be3
    • Dart version 2.18.2
    • DevTools version 2.15.0

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 3.5.0-6.0.pre.48, on macOS 12.2.1 21D62 darwin-x64,
    locale en-GB)
    • Flutter version 3.5.0-6.0.pre.48 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5a7224d14a (7 hours ago), 2022-10-17 12:25:57 +0800
    • Engine revision 59dea4cddd
    • Dart version 2.19.0 (build 2.19.0-312.0.dev)
    • DevTools version 2.18.0

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

 error log

======== Exception caught by rendering library =====================================================
The following assertion was thrown during paint():
centerSlice was used with a BoxFit that does not guarantee that the image is fully visible.
'package:flutter/src/painting/decoration_image.dart':
Failed assertion: line 535 pos 12: 'sourceSize == inputSize'

Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
  https://github.com/flutter/flutter/issues/new?template=2_bug.md

The relevant error-causing widget was:
  Image Image:file:///Users/dhs/Documents/NCFlutter/test_app/lib/main.dart:30:20
When the exception was thrown, this was the stack:
#2      paintImage (package:flutter/src/painting/decoration_image.dart:535:12)
#3      RenderImage.paint (package:flutter/src/rendering/image.dart:446:5)
#4      RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2796:7)
#5      PaintingContext.paintChild (package:flutter/src/rendering/object.dart:239:13)
#6      RenderProxyBoxMixin.paint (package:flutter/src/rendering/proxy_box.dart:144:15)
#7      RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2796:7)
#8      PaintingContext.paintChild (package:flutter/src/rendering/object.dart:239:13)
#9      RenderShiftedBox.paint (package:flutter/src/rendering/shifted_box.dart:84:15)
#10     RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2796:7)
#11     PaintingContext.paintChild (package:flutter/src/rendering/object.dart:239:13)
#12     RenderProxyBoxMixin.paint (package:flutter/src/rendering/proxy_box.dart:144:15)
#13     _RenderInkFeatures.paint (package:flutter/src/material/material.dart:609:11)
#14     RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2796:7)
#15     PaintingContext.paintChild (package:flutter/src/rendering/object.dart:239:13)
#16     RenderProxyBoxMixin.paint (package:flutter/src/rendering/proxy_box.dart:144:15)
#17     RenderPhysicalModel.paint.<anonymous closure> (package:flutter/src/rendering/proxy_box.dart:2098:15)
#18     PaintingContext.pushClipRRect (package:flutter/src/rendering/object.dart:550:14)
#19     RenderPhysicalModel.paint (package:flutter/src/rendering/proxy_box.dart:2085:21)
#20     RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2796:7)
#21     PaintingContext.paintChild (package:flutter/src/rendering/object.dart:239:13)
#22     RenderProxyBoxMixin.paint (package:flutter/src/rendering/proxy_box.dart:144:15)
#23     RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2796:7)
#24     PaintingContext.paintChild (package:flutter/src/rendering/object.dart:239:13)
#25     RenderProxyBoxMixin.paint (package:flutter/src/rendering/proxy_box.dart:144:15)
#26     RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2796:7)
#27     PaintingContext._repaintCompositedChild (package:flutter/src/rendering/object.dart:155:11)
#28     PaintingContext.repaintCompositedChild (package:flutter/src/rendering/object.dart:98:5)
#29     PipelineOwner.flushPaint (package:flutter/src/rendering/object.dart:1116:31)
#30     RendererBinding.drawFrame (package:flutter/src/rendering/binding.dart:515:19)
#31     WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:884:13)
#32     RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:378:5)
#33     SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1175:15)
#34     SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1104:9)
#35     SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:1015:5)
#36     _invoke (dart:ui/hooks.dart:148:13)
#37     PlatformDispatcher._drawFrame (dart:ui/platform_dispatcher.dart:318:5)
#38     _drawFrame (dart:ui/hooks.dart:115:31)
(elided 2 frames from class _AssertionError)
The following RenderObject was being processed when the exception was fired: RenderImage#5a41a relayoutBoundary=up2
...  parentData: <none> (can use size)
...  constraints: BoxConstraints(0.0<=w<=390.0, 0.0<=h<=844.0)
...  size: Size(390.0, 219.4)
...  image: [1280×720]
...  scale: 3.0
...  alignment: Alignment.center
...  centerSlice: Rect.fromLTRB(15.5, 15.5, 16.5, 16.5)
...  invertColors: false
...  filterQuality: low
RenderObject: RenderImage#5a41a relayoutBoundary=up2
  parentData: <none> (can use size)
  constraints: BoxConstraints(0.0<=w<=390.0, 0.0<=h<=844.0)
  size: Size(390.0, 219.4)
  image: [1280×720]
  scale: 3.0
  alignment: Alignment.center
  centerSlice: Rect.fromLTRB(15.5, 15.5, 16.5, 16.5)
  invertColors: false
  filterQuality: low
====================================================================================================

This problem is still present in Flutter 3.7.1.
I causes me some headaches, as I want to have a high resolution image to cover the entire screen, thus needing to be scaled down for small screens.
I tried the suggestion from @welstone to remove everything related to sliceBorder in the source code for DecorationImage and it seems to work perfectly fine. I'm not sure what purpose that part of the code fills. Are there any reasons for not incorporating this change into the master branch?

This issue still exists in Flutter 3.10.5. . In our case we saw that the assertion error is caused by rounding differences. The assertion (decoration_image.dart line 755) compares two doubles, that can be different due to the rounding differences. When commenting out the assertion, the centerSlice works fine.


Standards document

What looks like what.
This is always in bold
etc.

The word awk is always type as Awk and is in bold
Unless it's being used as an example.


China Server New Critical error Info

As shown in the figure, there is an error after CE injection on the left, and an error after forced injection on the right.
They have one thing in common, the KERNEL32 API address cannot be found
I think this is the most critical issue
Error Api: KERNEL32!InitOnceComplete

I think that's not the problem, if you get the message Injected successfully when you inject the DLL into the game with the cheat's own injector, the problem has nothing to do with it.
now i will teach you a method that requires no experience and knowledge. As we know, C++ codes work in a certain order, so you can find the error using MessageBox.

If you don't get the message I found the client when you inject the cheat, now you know where the problem is :)
Now suppose the cheat has successfully hooked the game. So let's say we see the hook message.

then the cheat will continue to work with the init_imgui() method, here the SkinDatabase::load() method will work, if there is no error it will exit there and switch to Hooks::init(). This way you can locate the error.
all you have to do is add a MessageBox to all the code blocks until you see the menu, if the game doesn't show you the message you typed into the MessageBox() then the problem is there.

我认为这不是问题，如果您在使用作弊者自己的注入器将DLL注入游戏时收到Injected successfully的消息，则问题与此无关。
现在我将教你一个不需要经验和知识的方法。众所周知，C++ 代码按一定顺序运行，因此您可以使用 MessageBox 查找错误。

如果您在注入作弊时没有收到 I found the client 的消息，那么现在您知道问题出在哪里了 :) 现在假设作弊成功地吸引了游戏。所以假设我们看到了钩子消息。

然后作弊将继续使用 init_imgui() 方法，这里 SkinDatabase::load() 方法将起作用，如果没有错误它将退出那里并切换到 Hooks::init()。这样您就可以定位错误。
您所要做的就是在所有代码块中添加一个 MessageBox，直到您看到菜单，如果游戏没有向您显示您在 MessageBox() 中键入的消息，那么问题就在那里。

游戏加载到:  Memory::Search(false);崩溃

The problem is definitely in the signatures. Dump League of Legends.exe using the tutorial below and send it to me.
Tutorial on how to dump the game
I will reverse the exe you sent when I am empty after posting

I found the signatures except SwapChain, but I couldn't find SwapChain, I don't know why riot packed it.

ManagerTemplate_AIHero_: A1 ? ? ? ? 8B 54 24 14 53
Riot_Renderer_MaterialRegistry_GetSingletonPtr: E8 ? ? ? ? FF 75 38
If you replace the signatures in the cheat with the ones above and start the game in legacy DX9 mode, the cheat should work.

I changed the configuration to use DX9, but the above settings still don’t work @R3nzTheCodeGOD

I will re-upload a game dump later, so please take a look @R3nzTheCodeGOD

Try this version I compiled by making the game DX9. If no other build is broken it should work.
Download
if it still doesn't work keep debugging

It is now working properly, thanks for your help.

It is now working properly @R3nzTheCodeGOD

Thank you @R3nzTheCodeGOD @MyBin97

Excuse me, is there any difference between it and the code of the main branch? @R3nzTheCodeGOD

Source Code


Text change in Assisted vault flow

"Add your key to the wallet"

Text Updated in the file
File:
https://www.figma.com/design/m5eMFTKD391AiJAXaEzgxB/Bitcoin-Keeper?node-id=1464-5766&t=buf0s8aYaZQKNuQv-1
S.s.:

Closing as outdated, we will reopen as needed when resuming work on assisted vault


iOS 13 iPad device detection issue

Tested on an iPad Air (newest generation) in Feb 2021.
With the Google Chrome browser: the iPad detect works as expected. Good.
With the Safari browser: the iPad detect does NOT work as expected. It returns "false."
Unfortunately, after reviewing the user agent string and other meta-data, it looks like Apple has decided to notify web publishers that the iPad should be treated like a desktop/laptop Mac computer. The user agent string looks just like a desktop Mac computer string.
Apple removed the "ipad" and "mobile" tokens. This means that there is nothing unique in the user agent string that we can latch onto to distinguish an iPad from a desktop/laptop computer.
This appears to be working "as design" by Apple. Sorry!


display images linked in markdown of jdocs

Search Terms
https://github.com/Microsoft/TypeScript/issues?utf8=✓&q=is%3Aissue+images+markdown
Suggestion
display images if they are linked in markdown inside jsdoc comments
Use Cases
viewing images in inline documentation
Examples
/** this is how it works ![Image of Yaktocat](https://octodex.github.com/images/yaktocat.png)
 */
class MyClass {
}

Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript / JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. new expression-level syntax)

😕

updated


Add the title of the story as an attribute

The wrapper fails to fetch the title of the story in the object it creates.

The schema can be found here

@pennacap bumping


MSAL retry policy

Core Library
MSAL Node (@azure/msal-node)
Wrapper Library
Not Applicable
Public or Confidential Client?
Confidential
Description
What is the guidance on retry policy for MSAL node?
Source
Internal (Microsoft)

Please see the .NET guidance here: https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/wiki/Retry-Policy

@bgavrilMS does msal-node implement the "retryOnceOn5xx" policy?

@aleknik - no, it does not. The retryOnceOn5xx seems to be implemented only in MSAL .NET and in hindsight it was a bad decision, because it interferes with retry policies set by others.

Ok, so the recommendation is for clients to implement their own retry logic. I see .NET has a handy IsRetryable property on exception objects. Is this property present in JS exceptions and if not is there a plan to support it?

@aleknik - no, but @Robbie-Microsoft is looking into it. Let me try to spec this a bit (in the description).

Aside: @EmLauber @jasonnutter - do you know if claim challenges are extracted as part of UiRequiredError or ServerError? I did not see them anywhere in the code. Can MSAL.js handle claim challenges from ESTS?

Aside: @EmLauber Emily Lauber FTE @jasonnutter Jason Nutter FTE - do you know if claim challenges are extracted as part of UiRequiredError or ServerError? I did not see them anywhere in the code. Can MSAL.js handle claim challenges from ESTS?

Don't believe so, no.


Cannot move card to an empty column

Create a column A and a column B. Add a card to column A. Try to drag-n-drop the card from column A to column B. You will be unsuccessful unless the column B has any cards.

@yasaricli, Why did you re-open this? It seems fixed.


chore: Reusable button component, styles refactor

Description

The demo above is not included in the PR, use the code in the collapsed section to play with it locally
return (

Demo

        <Button>Primary</Button>
        <Button>
          <MagnifyingGlassIcon />
          Primary with Icon
        </Button>
        <Button>
          <MagnifyingGlassIcon />
          Primary with two icons <CircleXMarkIcon />
        </Button>
        <Button disabled>
          <MagnifyingGlassIcon />
          Primary Disabled
        </Button>

        <Button variant="secondary">Secondary</Button>
        <Button variant="secondary">
          <MagnifyingGlassIcon />
          Secondary with Icon
        </Button>
        <Button variant="secondary">
          <MagnifyingGlassIcon />
          Secondary with two icons <CircleXMarkIcon />
        </Button>
        <Button variant="secondary" disabled>
          <MagnifyingGlassIcon />
          Secondary Disabled
        </Button>

        <Button variant="tertiary">Tertiary</Button>
        <Button variant="tertiary">
          <MagnifyingGlassIcon />
          Tertiary with Icon
        </Button>
        <Button variant="tertiary">
          <MagnifyingGlassIcon />
          Tertiary with two icons <CircleXMarkIcon />
        </Button>
        <Button variant="tertiary" disabled>
          <MagnifyingGlassIcon />
          Tertiary Disabled
        </Button>

        <Button size="small">Primary Small</Button>
        <Button variant="secondary" size="small">
          Secondary Small
        </Button>
        <Button variant="tertiary" size="small">
          Tertiary Small
        </Button>
        <Button size="small" disabled>
          Primary Small disabled
        </Button>

  );

This PR adds a reusable Button component. The goal here is to unify the button styles so that they adhere to BC gov's design system This, in turn, allows us to avoid situations like this across the code:

This PR is best reviewed by commit. The commit that adds the new component is here: 1971fa1f33cb18534943eab6cec60ae661369f1a
The rest of the commits focus on reusing the new component in various places of the app:

SiteDetails, Summary, FolioContent
CustomButtons
Folio
Actions
Actions, NavigationPills
Participant
Notations
Documents
AssociatedSites
LandUses
Disclosure
Search, Columns, Filters

NOTE 1
There are a lot of changes and I'm 100% certain that I missed something. If you see some buttons that don't use the new component, let me know, or better yet - make a PR to fix it.
NOTE 2
This new component is better than copying the same styles over and over again, but in its current state it does not have complete parity with the design system linked above. For example, I did not add the "large" size (because it's not used anywhere yet), and I did not add the "icon" variant (because the PR is huge already without it)

Thanks for the PR!
Deployments, as required, will be available below:

Backend
Frontend

Please create PRs in draft mode.  Mark as ready to enable:

Analysis Workflow

After merge, new images are deployed in:

Merge Workflow

Overall PR looks good. Its just that variant is missing at many places so pls double check if thats intentional or not.

@nupurdixit13 We talked about this in private, posting here for posterity.
The missing variants are intentional. The default variant is set to "primary", no need to pass that prop again.


Use latest sbt-osgi

Resolves: https://github.com/apache/incubator-pekko/issues/757 . See https://github.com/sbt/sbt-osgi/issues/102#issuecomment-1882811884 . I have tested that this works with pekko-http using
sbt -Dpekko.build.pekko.version=1.1.0-M0-SNAPSHOT "++ 2.12.18" Test/compile
sbt -Dpekko.http.parallelExecution=false -Dpekko.test.timefactor=2 -Dpekko.build.pekko.version=1.1.0-M0-SNAPSHOT "++ 2.12.18" mimaReportBinaryIssues test

where 1.1.0-M0-SNAPSHOT is a version I manually set for this PR.

Ill go ahead and merge this so we can iron out any regressions

I can confirm that this is working correctly, the latest pekko-http nightly builds passed without issues (see https://github.com/apache/incubator-pekko-http/actions/runs/7469468687)


Add Trino v360  support

hi everyone,I didn't find Trino in version 2.1.0

Hi, will this be part of the upcoming 2.2.0 release?

Hi ThoSap, I see that this is still in review stage and won't be possible to include in the release.

Looking at the past release cycle, does that mean we have to wait another year for Trino support?

+1 Look forward to merging ranger-rino plugin feat.

+1 Ranger is the only thing that currently prevents us from migrating to Trino.

@ThoSap @rgelsi We shall plan doing a minor release may be in 3 months which can include Ranger-3182.
Please comment on the jira and lets work on it to bring it to closure.


Hospital Corpsman spawnpoint

Done in https://github.com/CM-14/CM-14/commit/5ff54f115ff6f702962acd7586e4a8aadcfe1bc8


[PE-D] Adding new lesson for student after marking as paid does not change payment status

A current student with 2 lessons, Alex Yeoh, who has already paid for 2 lessons, when adding a new lesson, the payment status is still the same, when it might be different (student can sign up for a new class and hasn't paid for that month)

Labels: severity.Low type.FeatureFlaw
original: cedricongjh/ped#9

To resolve by removing payment feature


ever version after this version has garbled image

I was trying out the most recent version of freshplayer,
I noticed every version after this version has garbled image
async_network: include host and port in warnings' text
Everything after this gives a garbled image

working OK now, thanks.


Serverside Crash

I posted this issue on the minecraft forums thread, I'm posting it here too for organization reasons:
Crashlog: http://pastebin.com/ANww3hQe, modlist is in the log I'm not sure what's causing the crash. I have personally modified Elements of Power to fix an issue the developer missed but it shouldn't have affected anything.

Fixed as of .86b, thanks for the report 👍


False positive on CPY006 for simple COPY command

False positive on CPY006 for simple COPY command.

Yeah, the most basic test case is missing, adding it and fixing this bug...


Modern JavaScript and supported browsers in samples

@anurse RE: Extending the recent issue and PR about modern JS and IE11. (https://github.com/aspnet/Docs/issues/5945)
Take a look at chat.js and es5-chat.js at https://github.com/rachelappel/SignalRChat/tree/master/SignalRChat/wwwroot/js
I would like to use chat.js with the comments in it, and add es5-chat.s alongside it to the samples.  I ran my sample that I use for the doc through Babel and copied the output to es5-chat.js.
Even if we don't use es5-chat (it is for reader convenience), I believe at least moving the message about ES5/IE11 to the chat file will be better received as comment form in code than a note in the doc.
Because:
-When people stumble on the sample straight from a search engine they will know what's going on without having to dig up the actual doc too.
-All the docs so far use the same code sample (trying to keep it consistent), and therefore this message should be somewhere available across the other docs that use this sample. So why not add it to the sample itself? The comments can simply be added to the doc by showing the extra lines in the code snippets/samples, and then it works like an include file, but it now can be expressed in both docs and code or just code when we want.
Thoughts?

Looks ok to me


supported clients?

outlook?
gmail?
ios?
etc...
thanks!

Hello @kukac7
Yes you're right, it should be added on the Readme !

@iRyusa :bow:

As @lohek mentioned to me, you can find it there: https://mjml.io/faq#email-clients :+1:  if this is ok, you can close the issue :)

Hello, were this information removed from the FAQs?


Add mswjs topic

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

MSW is a very useful library for development and testing of many JS/TS projects with almost 1M weekly downloads on npm, using a more robust mechanism compared to previous approaches (it's intercepting native network requests instead of mocking fetch), embracing web standards and promoting better development practices, deserving a prominent place on GitHub.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Thank you for the PR, however, according to our contribution guidelines:

We are likely to consider suggestions to curate a topic or collection that is valuable to GitHub's community. Valuable topics, for example, include those that are already widely used by repositories and could benefit from the addition of important information. When suggesting content, please consider how to make your contribution broadly useful and relevant to others, rather than serving a specific use case.

This topic is only used on 20 repositories, therefore it does not qualify as "widely used".

Perhaps you could lobby for those projects to add the topic to their repository? Typically topics have 100s of repositories using the topic name.
I encourage you to circle back with us if the topic adoption goes well and we can revisit adding mswjs to the curated list.
Thanks!

the contribution guidelines say for example, include those that are already widely used and the link points to https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/classifying-your-repository-with-topics that does not mention anything about what is the acceptable limit
you somehow treat that vague statement as a qualification criteria, but I am very confused as to what is the actual qualification criteria
please don't encourage me when you don't mean it - I tried to help a project I love and you ruined my day by having your stupid secret criteria, I would suggest to write your criteria directly to the contribution guidelines so that other participants have better information before you ruin their excitement too
good luck with all the good activities GitHub is doing and I hope topics will become a more pleasant experience for other people in the future

you somehow treat that vague statement as a qualification criteria, but I am very confused as to what is the actual qualification criteria

@Aprillion We do not have a specific number and, even if we did, we would be unlikely to publish it to discourage gaming.

please don't encourage me when you don't mean it - I tried to help a project I love and you ruined my day by having your stupid secret criteria, I would suggest to write your criteria directly to the contribution guidelines so that other participants have better information before you ruin their excitement too

We do mean it. I'm sorry that this has not been the outcome you were wanting or expecting.
In future please adjust your language here, "stupid secret criteria" does not match the respectful tone that @kenyonj has used in this PR.

good luck with all the good activities GitHub is doing and I hope topics will become a more pleasant experience for other people in the future

Thanks for the kind words!


AdoptAWidget: SliverWithKeepAliveWidget

AdoptAWidget: SliverWithKeepAliveWidget
Added Reference in See Also Section.
This pull request is:

[  ] A code sample
[x] More references
[  ] More explanation

closes #69470

It also seems like the customer-testing check is failing for reasons unrelated to your PR: https://github.com/flutter/flutter/pull/69508/checks?check_run_id=1337637044
Could you try rebasing your branch with master and see if this resolved the problem?

Closing this in favor of https://github.com/flutter/flutter/pull/69523, which has been rebased with upstream master.


Fix export-cluster-logs command filter option

Description of changes
Fix the filter option of export-cluster-logs, the problem is that input type of filters is not consistent in class ClusterLogsFiltersParser and class ExportClusterLogsFiltersParser
Before the fix, the error message is:
pcluster export-cluster-logs -n slurm-memory --bucket test-bucket --filters "Name=node-type,Values=HeadNode"
ERROR: Unable to export cluster's logs.
Unexpected error when exporting cluster's logs: Invalid filters Name=node-type,Values=HeadNode. They must be in the form Name=...,Values=...
Tests

Add unit test
Manually test

References

Link to related PRs in other packages (i.e. cookbook, node).
Link to documentation useful to understand the changes.

Checklist

[ ] Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
[ ] Check all commits' messages are clear, describing what and why vs how.
[ ] Make sure to have added unit tests or integration tests to cover the new/modified code.
[ ] Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Should we add (or update) the integration tests to include exercising the happy path for filtering?

Should we add (or update) the integration tests to include exercising the happy path for filtering?

Good idea, integration test added


pull request for e2e test at 11/30/2016 12:56:04

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Require a filename for cloud merge and cloud read subcommands

Previously, if no filename was specified, we read from STDIN. This could
create some confusion if the filename wasn't specified by mistake
resulting in the command hanging forever waiting for STDIN to supply the
ip ranges. Now, we require that a filename of "-" be specified if the
user intends for the ip ranges to be read from STDIN. If the user
actually wants to read the ranges from a file named "-" (which seems
unlikely), they can specify the file as "./-".

bors r+


Depend on @solid/oidc-rp, not @trust/oidc-rp

Following up on https://github.com/linkeddata/rdflib.js/issues/314

Oops sorry, committed a change to README that I didn't mean to.  Will remove it if you don't like it.


Use k8s API aggregation layer

There are still some usages of rancher/wrangler that can be removed since we now use kubebuilder.

👍 on switching to the K8s API aggregation. It would be nice to decouple slightly from Rancher core. It could give us more flexibility for use cases where you may want to federate APIs across different clusters.

not planned


Go CSV Markers to populate specDescriptors for "owned" CRDs from another module

Feature Request
A way to generate specDescriptors and statusDescriptors to CSV from CRD defined in _types.go in external module (ie. different go.mod) using markers
Describe the problem you need a feature to resolve.
We oadp-operator deploy CRDs that are not from the same Go module github.com/vmware-tanzu/velero/. Our go module is github.com/openshift/oadp-operator
This means we are not able to add operator-sdk Go tags to the _types.go since the github.com/vmware-tanzu/velero/ project is not operator-sdk specific.

I have an issue when ...
make bundle does not have a way to populate specDescriptors into CSV from out of module CRD. Defining specDescriptors manually also gets overwritten if I'm not mistaken.
Usecase
So we can specify which x-descriptors applies to each field to customize the UI for a field in externally and non operator-sdk specific defined _types.go
https://github.com/openshift/console/blob/master/frontend/packages/operator-lifecycle-manager/src/components/descriptors/reference/reference.md

Describe the solution you'd like.
A way to store define/generate specDescriptors into CSV dynamically from out of module _types.go or CRD. Perhaps by defining imported_types.go like following
// file: imported_types.go
package v1alpha1

import velerov1 "github.com/vmware-tanzu/velero/pkg/apis/velero/v1"

// To generate CSV this CRD
// spec:
//   apiservicedefinitions: {}
//   customresourcedefinitions:
//     owned:
//     - description: Backup is a Velero resource that respresents the capture of Kubernetes
//         cluster state at a point in time (API objects and associated volume state).
//       displayName: Backup
//       kind: Backup
//       name: backups.velero.io
//       statusDescriptors:
//       - description: CompletionTimestamp records the time a backup was completed.
//           Completion time is recorded even on failed backups. Completion time is recorded
//           before uploading the backup object. The server's time is used for CompletionTimestamps.
//         displayName: CompletionTimestamp
//         path: completionTimestamp

//+operator-sdk:csv:customresourcedefinitions:externalModule=true,displayName="Backup",kind=Backup,name=backupstoragelocations.velero.io
// Backup is a Velero resource that respresents the capture of Kubernetes cluster state at a point in time (API objects and associated volume state).
type importVeleroBackup velerov1.Backup

//+operator-sdk:csv:customresourcedefinitions:externalModule=true,displayName="CompletionTimestamp",path=backupstoragelocations.velero.io/completionTimestamp
// CompletionTimestamp records the time a backup was completed.
// Completion time is recorded even on failed backups. Completion time is recorded
// before uploading the backup object. The server's time is used for CompletionTimestamps.
type CompletionTimestamp *metav1.Time `json:"completionTimestamp,omitempty"`

/language go

Defining specDescriptors manually also gets overwritten if I'm not mistaken.

At a minimum, if this is the case, I would consider it a bug. Would you mind building a reproducer and filing a bug issue for that?

I can amend to testdata dir perhaps

Defining specDescriptors manually also gets overwritten if I'm not mistaken

@kaovilai Are you modifying the descriptions inside the bundle itself, or inside the config/ dir (where CRD bases are present). The bundle gets overwritten, unless it is explicitly set to false through the make bundle command.
The issue with having markers on importVeleroBackup type, is that the descriptions would not be propagated to any specific type fields which velerov1.Backup would have, as there is no way for operator-sdk to know it. Additionally, the process of wrapping the Backup API with importValeroBackup seems confusing - looks like you are trying to use the same definition, but define a separate API for your operator.

Inside config without getting overwritten by manifests generation

as there is no way for operator-sdk to know it.

currently. I think you can make it possible for operator-sdk to get that info from somewhere.

In addition to a completely out of module CRDs, our structs also inherit some fields imported from other modules..
Would be great to be able to set x-descriptors for otherField.nestedField.nestedField in below example.
import "github.com/someotherthing/apis/v1"
struct MyOwnKind type {
    ourField string
    otherField v1.something
}

I am proposing new flags to indicate external module
//+operator-sdk:csv:customresourcedefinitions:externalModule=true

You can also add flag for creating relationship between them to link them together.

currently. I think you can make it possible for operator-sdk to get that info from somewhere.

How would operator-sdk know which field on that struct the marker is applied to? markers in go generally speaking have to be on the field that is to be marked, not some other random/nested field.
Since the dependent module is open source, can't the descriptors be added there? or in a fork? That seems like the most logical way to go.

Since the dependent module is open source

ok even if we were able to add markers to x_types.go in other module, I doubt that the markers would have any effect on the CSV of this module since the only thing we're doing is copying over the CRD, not the .go files.

since the only thing we're doing is copying over the CRD, not the .go files.

To be clear, you do not reference the dependent operator in your go.mod file? In your code sample above, it seemed that you had a code dependency on the dependent project, which I would think would be the ideal way to go.

We have a code dependency in our struct and is in go.mod, worse case we can do anonymous import
but I wonder for the cases where some other operator is a workload installer and installs CRD created from project outside the operator module.

We have a code dependency in our struct and is in go.mod, worse case we can do anonymous import but I wonder for the cases where some other operator is a workload installer and installs CRD created from project outside the operator module.

This seems like a really strange use-case for an operator to me. OLM's job is to install operators and manage the CRD life-cycle, it seems less then ideal to have an operator install another operator and manage the dependent CRD's. OLM provides a dependency.yaml for this very purpose.

an operator install another workload that did not design with operator-sdk or OLM in mind.

Sounds like you're suggesting to create minimal velero operator that oadp-operator can then depend on.
It's a very hackish approach as the repo upstream is not in a kubebuilder/v3 structure and will probably involve copying CRDs around into config/ etc.

/remove-lifecycle stale

/remove-lifecycle stale


An Error blocks building step. But does not block Watch step.

Description
Running with watch parameter gives some errors but generates my files. But running with build parameter does not work as expected.
Expected behavior
I was only expecting the generating my public folder. Althougth watch parameter (also with --production generates succesfully.
Actual behavior
See https://github.com/guneysus/experiments/commit/51a36691feb0d565454d3cca8880af3ee5ce639f or experiments-51a3669.zip
Running with watch gave some errors but compile and bundles my javascripts and generates public folder.
> brunch watch --server

30 Apr 21:58:07 - warn: config.modules.babel: perhaps you meant wrapper
30 Apr 21:58:08 - info: application started on http://localhost:3333/
30 Apr 21:58:08 - error: watch package.json ENOSPC
Stack trace was suppressed. Run with `LOGGY_STACKS=true` to see the trace.
30 Apr 21:58:08 - error: watch brunch-config.coffee ENOSPC
Stack trace was suppressed. Run with `LOGGY_STACKS=true` to see the trace.
30 Apr 21:58:13 - error: watch app/assets ENOSPC
Stack trace was suppressed. Run with `LOGGY_STACKS=true` to see the trace.
30 Apr 21:58:13 - error: watch app/app.js ENOSPC
Stack trace was suppressed. Run with `LOGGY_STACKS=true` to see the trace.
30 Apr 21:58:13 - error: watch app/initialize.js ENOSPC
Stack trace was suppressed. Run with `LOGGY_STACKS=true` to see the trace.
30 Apr 21:58:13 - info: compiling
30 Apr 21:58:13 - error: watch app/assets/two-way ENOSPC
Stack trace was suppressed. Run with `LOGGY_STACKS=true` to see the trace.
30 Apr 21:58:13 - error: watch app/assets/favicon.ico ENOSPC
Stack trace was suppressed. Run with `LOGGY_STACKS=true` to see the trace.
30 Apr 21:58:13 - error: watch app/assets/index.html ENOSPC
Stack trace was suppressed. Run with `LOGGY_STACKS=true` to see the trace.
30 Apr 21:58:13 - error: watch app/assets/two-way/index.html ENOSPC
Stack trace was suppressed. Run with `LOGGY_STACKS=true` to see the trace.
30 Apr 21:58:13 - info: compiled 3 files into 2 files, copied 3 in 6.8 sec

But running with only build fails and does not touch public folder
> brunch build --production

30 Apr 21:59:51 - warn: config.modules.babel: perhaps you meant wrapper
30 Apr 21:59:52 - error: watch package.json ENOSPC
Stack trace was suppressed. Run with `LOGGY_STACKS=true` to see the trace.
30 Apr 21:59:52 - warn: Nothing to compile. Most likely you don't have any source files yet, in which case, go ahead and create some! Otherwise, you probably don't have any plugin handling your source files. (For plain javascript, that would be "javascript-brunch")

npm ERR! Linux 3.19.0-32-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "run" "prod"
npm ERR! node v4.4.3
npm ERR! npm  v2.15.1
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>prod: `brunch build --production`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>prod script 'brunch build --production'.
npm ERR! This is most likely a problem with the your-app package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     brunch build --production
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs your-app
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls your-app
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/ahmed/workspace/repos/experiments/npm-debug.log

Environment

Brunch: 2.7.4
Node: v4.4.3
NPM: 2.15.1
Operating system: Linux-3.19.0-32-generic-x86_64-with-LinuxMint-17.3-rosa

package.json contents
{
  "name": "your-app",
  "description": "Description",
  "author": "Your Name",
  "version": "0.0.1",
  "repository": {
    "type": "git",
    "url": ""
  },
  "scripts": {
    "start": "brunch watch --server",
    "prod": "brunch build --production"
  },
  "dependencies": {},
  "devDependencies": {
    "auto-reload-brunch": "^2.0.0",
    "babel-brunch": "~6.0.0",
    "babel-preset-es2015": "~6.3.13",
    "brunch": "^2.4.0",
    "clean-css-brunch": "^2.0.0",
    "css-brunch": "^2.0.0",
    "javascript-brunch": "^2.0.0",
    "uglify-js-brunch": "^2.0.0"
  }
}

brunch config contents
exports.config =
  files:
    javascripts:
      joinTo:
          'javascripts/vendor.js': /^(?!app)/
          'javascripts/app.js': /^app/
    stylesheets:
      joinTo:
        'stylesheets/app.css': /^(app|vendor)/
        'test/stylesheets/test.css': /^test/
      order:
        before: ['vendor/styles/normalize-1.0.1.css']
        after: ['vendor/styles/helpers.css']

  modules:
    babel:
      presets: ['es2015']

  # Every setting is optional.
  plugins:
    autoReload:
      enabled:
        css: on
        js: on
        assets: off
      port: [1234, 2345, 3456]
      delay: 200 if require('os').platform() is 'win32'

Other useful files, when present (log, bower.json etc.)

Debug log for LOGGY_STACKS=true brunch build --debug

Sat, 30 Apr 2016 22:08:17 GMT brunch:config Trying to load brunch-config
30 Apr 22:08:17 - warn: config.modules.babel: perhaps you meant wrapper
Sat, 30 Apr 2016 22:08:18 GMT brunch:plugins Loaded plugins: auto-reload-brunch, babel-brunch, css-brunch, javascript-brunch
30 Apr 22:08:18 - error: watch package.json ENOSPC
  at exports._errnoException (util.js:870:11)
  at FSWatcher.start (fs.js:1234:19)
  at Object.fs.watch (fs.js:1262:11)
  at createFsWatchInstance (/home/ahmed/workspace/repos/experiments/node_modules/brunch/node_modules/chokidar/lib/nodefs-handler.js:37:15)
  at setFsWatchListener (/home/ahmed/workspace/repos/experiments/node_modules/brunch/node_modules/chokidar/lib/nodefs-handler.js:74:15)
  at FSWatcher.NodeFsHandler._watchWithNodeFs (/home/ahmed/workspace/repos/experiments/node_modules/brunch/node_modules/chokidar/lib/nodefs-handler.js:228:14)
  at FSWatcher.NodeFsHandler._handleFile (/home/ahmed/workspace/repos/experiments/node_modules/brunch/node_modules/chokidar/lib/nodefs-handler.js:255:21)
  at FSWatcher.<anonymous> (/home/ahmed/workspace/repos/experiments/node_modules/brunch/node_modules/chokidar/lib/nodefs-handler.js:473:21)
  at FSReqWrap.oncomplete (fs.js:82:15)

30 Apr 22:08:18 - warn: Nothing to compile. Most likely you don't have any source files yet, in which case, go ahead and create some! Otherwise, you probably don't have any plugin handling your source files. (For plain javascript, that would be "javascript-brunch")

@goshakkk

The ENOSPC error means there is no free space on your drive. I've just cloned the repo you provided and checked out to the commit you specified. Both watch and build worked properly:
experiments-iss1327(51a3669...)$ brunch b --production
04 May 10:44:52 - warn: config.modules.babel: perhaps you meant wrapper
04 May 10:44:53 - info: compiled 2 files into app.js, copied 3 in 1.9 sec
experiments-iss1327(51a3669...)$ brunch w -s
04 May 10:46:42 - warn: config.modules.babel: perhaps you meant wrapper
04 May 10:46:43 - info: application started on http://localhost:3333/
04 May 10:46:43 - info: compiled 3 files into 2 files, copied 3 in 2.4 sec

(Btw, totally unrelated, but the babel plugin config should go under config.plugins.babel, not config.modules.babel — in general, all plugin configs live at config.plugins.xxx. modules is only used for these — https://github.com/brunch/brunch/blob/master/docs/config.md#modules)

@guneysus ping?

Where in the world do you set this LOGGY_STACKS=true parameter?


Onlyoffice-mysql-server continuous restart

I have reinstalled the OS multiple times now, with no change in behavior.
I am using the docker-compose method.
The Mysql 5.7 server can’t open the error log at /var/log/mysql/error.log, which causes the mysql server to shutdown, and the container to restart. Upon restarting, the same issue.
I first encountered this issue on my working, running onlyoffice instance, after running ‘docker-compose down; docker-compose pull; docker-compose up -d’
During the pull, only the MySQL server was updated. This was about 2 weeks ago.
I will attach the relevant logs in a moment.

onlyoffice-mysql-server-logs.txt

Having similar issue when use the docker-compose method to install.
2022-08-01 11:46:33+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 5.7.39-1.el7 started.
2022-08-01 11:46:33+00:00 [Note] [Entrypoint]: Switching to dedicated user 'mysql'
2022-08-01 11:46:33+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 5.7.39-1.el7 started.
2022-08-01 11:46:33+00:00 [Note] [Entrypoint]: Initializing database files
2022-08-01T11:46:33.430499Z 0 [Warning] TIMESTAMP with implicit DEFAULT value is deprecated. Please use --explicit_defaults_for_timestamp server option (see documentation for more details).
2022-08-01T11:46:33.430533Z 0 [Warning] 'NO_AUTO_CREATE_USER' sql mode was not set.
2022-08-01T11:46:33.431769Z 0 [ERROR] Could not open file '/var/log/mysql/error.log' for error logging: No such file or directory
2022-08-01T11:46:33.431865Z 0 [ERROR] Aborting

Update: I exported the docker file system and examined it. The entire /var/log/mysql folder is not present. I tried creating it, and then importing the resulting file structure, but no difference in behavior was observed.

Changing the docker-compose line to use mysql 5.7.36 instead of just 5.7 seems to fix the issue. Note that this is on a fresh install.

I haven’t yet created a sign-in, or gone through the web-setup procedure. I’m just going by the logs, and because docker-compose ps shows everything is up.

Hello @aaronouthier yes, we have a problem with docker-compose method (Bug 58366 in our private bugtracker). We will fix it soon.
For now i can recommend you use our installation scripts:
Workspace - https://download.onlyoffice.com/install/enterprise-install.sh

I much prefer the simplicity of Docker-Compose, thank you. I will wait until it is fixed.

Hello, any update on this, or ETA on a resolution using Docker-Compose?

Fixed by https://github.com/ONLYOFFICE/Docker-CommunityServer/commit/d56461d082fafd401b15d3aebfb28bd4211042a1

problem still resumes.

I can confirm this. Began anew when reverting back to mysql 5. It was fixed when moving to mysql 8, however that introduced a different problem there.

my solution was:
Adding a volume for log folder like this;
version: '3'
services:
  onlyoffice-mysql-server:
    container_name: onlyoffice-mysql-server
    image: mysql:5.7
    environment:
     - MYSQL_ROOT_PASSWORD=deleted
    networks:
     - onlyoffice
    stdin_open: true
    tty: true
    restart: always
    volumes:
     - ./config/mysql/conf.d:/etc/mysql/conf.d
     - ./config/mysql/docker-entrypoint-initdb.d:/docker-entrypoint-initdb.d
     - ./korkmaz_mysql_data:/var/lib/mysql
     - ./korkmaz_mysql_log:/var/log/mysql

and then 999 id as owner;


Use Python libraries over wget to download files

In
https://github.com/cyrraz/plothist/blob/06b24cdbf4676efe914ec514be720635e942a2eb/src/plothist/scripts/install_latin_modern_fonts.py#L24-L26
and
https://github.com/cyrraz/plothist/blob/06b24cdbf4676efe914ec514be720635e942a2eb/src/plothist/scripts/make_examples.py#L121-L128
wget is called as a subprocess to download files. Instead of requiring an outside utility, it would be nicer to use a Python standard library like urllib or an external library like requests. While wget is abundantly used, it is preferable to have all dependencies clearly specified at install time such that installing in a Linux container environment isn't a suprise or trial-and-error situation.

Same goes for unzip
https://github.com/cyrraz/plothist/blob/06b24cdbf4676efe914ec514be720635e942a2eb/src/plothist/scripts/install_latin_modern_fonts.py#L170-L180

We got the recommendation to put the fonts (along with our fake dataset) in a separate package as mplhep does with mplhep-data. For now, I replaced wget and unzip with the python version in https://github.com/cyrraz/plothist/pull/176.

Thank you. The fix is merged and a new patch release (1.2.6) was published on PyPI.


Add comments to each function.

Add comments to describe the wroking of each function.
Fix a minor issue regarding storing the data in localstorage in frontend.
Make few minor CSS changes.

Thanks @tuxology for the review.


Feature Request : Work with React Native to convert iOS to windows

If your not familiar with React Native,  its a fully native iOS application that is coded in mainly javascript.  React Native is obj-c that crosses that native/javascript barrier to render the actual platform control.
https://code.facebook.com/posts/1014532261909640/react-native-bringing-modern-web-techniques-to-mobile/
"we run it in an embedded instance of JavaScriptCore inside our apps and render to higher-level platform-specific components."
If this bridge worked with react native, there'd finally be ONE framework that developers could build against to make fully native (using each specific platform controls) across Android, iOS, and windows.  The approach is even better than xamarin, where RN has cross platform invisible layout controls that you can use.  E.g. it's flexbox serves as a grid layout for android, and iOS.
I've tried the vsimporter on a blank RN app, and making the VS solution was successful.  BUT as you can guess, just compiling didn't work.  Many dependencies weren't resolved, likely b/c RN libraries are being referenced that aren't installed on the windows side.  As far as i know there isn't an existing way of installing RN iOS libraries onto windows, b/c the existing installations are for Mac.
Here's an IPA of a blank RN iOS app. https://onedrive.live.com/redir?resid=B019B8B558409E86!187122&authkey=!ANLoc2m4VZ0N0Kk&ithint=file%2Cipa
Let me know if I can be of any help.
-Quincy Mitchell
@quincymitch

Also see issues from last year:  #44, #118

I keep getting the same error

If you are using react native, your best bet really is to use the react native support for UWP instead of using the winobjc project.  Please see this blog for details.

Agreed.


eval_metrics print fixed

the eval metric print was irregular when there was more than one comparison set

@trivialfis Can you help me to know what is going wrong with my modification ?

Not sure yet.  Restarted Jenkins a few times.  @hcho3 Could you please help taking a look at mgpu test?

@Cyprien-Ricque  @hcho3 Thanks.


screen annotation not working with record

I am using -r parameter for recording in ubuntu. I am using gnome tweak tool draw on you desktop for drawing. But draw is not visible in recording. Also mouse pointer not showing. Using version 1.10

This is expected, the video is recorded on the device. You can even record without opening a window.

Also see https://github.com/Genymobile/scrcpy/issues/689#issuecomment-518016863.


Update macOS-Development-Setup.rst paths for pip

pygraphviz installation fails with missing header files error. graphviz library's include and lib folders path references added to pip command.

No response in a long time, so I'm going to close this one out.  Please feel free to reopen if you think this is the right thing.


Google authentication doesn't work

For some unknown reason the authentication using the GoogleConsumer class doesn't work.

It should be something related to the Google key, this might not be a bug but just a configuration problem.


Titanium Proxy with windows service

Hello,
I am using Titanium Proxy with windows service and I have added  Google URL in "IncludedRegexList".
My windows service starts automatically on machine start. However for around 10 mins into machine start, all Google URLs are throwing exception in Handle client method.

"Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host."

Because of this I am not able to browse any of the google URLs for 10 minutes after machine start, Meanwhile, other URLs are working fine during this 10 min period after machine start. After 10 mins, the google urls also start working.
I couldn't understand why it is throwing exception for sometime after machine start.
Please help to find the solution.

I noticed that there is a lock on which the request for google are getting stuck in CertificateManager
Function :   internal X509Certificate2 CreateCertificate(string certificateName, bool isRootCertificate)
//has lock
 lock (string.Intern(certificateName))

After checking other thread, I found that there is one thread which is stuck on
typeSignerCertificate.InvokeMember("Initialize", BindingFlags.InvokeMethod, null, signerCertificate, typeValue);

in WinCertificateMaker class under function:

X509Certificate2 MakeCertificate(bool isRoot, string subject, string fullSubject,
            int privateKeyLength, string hashAlg, DateTime validFrom, DateTime validTo,
            X509Certificate2 signingCertificate)

any idea why this happens only at start of machine?

@honfika @justcoding121 I am still not able to figure why these scenario happens. Can I have your thoughts on this please.

typeSignerCertificate.InvokeMember("Initialize", BindingFlags.InvokeMethod, null, signerCertificate, typeValue);
Taking too much time to Initialize cert.

@honfika  @justcoding121 I am continuously facing the same issue on some of the machines, is there any workaround for this.

You can use BouncyCastle as certificate engine instead, since the code you posted above is from WinCertificateMaker.
https://justcoding121.github.io/Titanium-Web-Proxy/docs/api/Titanium.Web.Proxy.Network.CertificateManager.html#Titanium_Web_Proxy_Network_CertificateManager_CertificateEngine


merkle: add blake2b

Adds the us blake2b package

Merged in https://github.com/SiaFoundation/core/commit/17613a9a4a3cbc03df21a5d74ea1c64e162d2356


[Feature] Support '--sort-by' for search

I think these would be awesome! :)
--sort-by-date
--sort-by-name
--sort-by-extension
--sort-by-publisher
Thanks!

libgen-cli does already have the (--extension|-e) flag, and the search command is already filtering by name due to its nature. Are you referring to sorting the results of a search query alphabetically?
However, the filtering by date and publisher would be great additions; I can get working on those once I resolve some of the mirror issues I'm currently facing!

Actually, what I meant by sorting is that each flag should take ASC and DSC options in order to sort of them. I forgot to add this information. :)

That makes sense! I can look into making this an addition!

The publisher flag will be added as of https://github.com/ciehanski/libgen-cli/pull/41. Still working on a good sort feature.

Hi @Dentrax, this has been merged into master from PR https://github.com/ciehanski/libgen-cli/pull/85 @ commit f94543d. Examples of how to utilize the command are listed in the PR's description. Feel free to update libgen-cli by running:
$ go install github.com/ciehanski/libgen-cli@latest

This update will require go 1.20. Let me know if you have any issues.

Even I forgot the existence of this issue. :D
Thank you @ciehanski!

@ciehanski the merged changes are not included in the latest release. Consider a new release?


smartcard redirection not automatically activated if enforced by server

Description
The attempt to connect to a Windows (10 or 11) PC fails due to an unknown device ID 0xffffffff if the computer is in a domain.
To Reproduce
Executing xfreerdp /cert:ignore /d:HQ /u:XXXXXXXXXX /v:YYYYYYYYYYYYY
results in (trace - log see attached file):
Password:
[11:40:30:471] [8149:00001fd6] [ERROR][com.winpr.sspi.Kerberos] - [kerberos_AcquireCredentialsHandleA]: krb5glue_get_init_creds (Cannot find KDC for realm "HQ" [-1765328230])
[11:40:30:475] [8149:00001fd6] [ERROR][com.winpr.sspi.Kerberos] - [kerberos_AcquireCredentialsHandleA]: krb5glue_get_init_creds (Cannot find KDC for realm "HQ" [-1765328230])
[11:40:30:512] [8149:00001fd6] [WARN][com.freerdp.core.connection] - [rdp_client_connect_auto_detect]: expected messageChannelId=1008, got 1003
[11:40:30:512] [8149:00001fd6] [WARN][com.freerdp.core.license] - [license_read_binary_blob_data]: license binary blob::type BB_ERROR_BLOB, length=0, skipping.
[11:40:30:578] [8149:00001fd6] [WARN][com.freerdp.core.connection] - [rdp_client_connect_auto_detect]: expected messageChannelId=1008, got 1003
[11:40:30:648] [8149:00001fd6] [INFO][com.freerdp.gdi] - [gdi_init_ex]: Local framebuffer format  PIXEL_FORMAT_BGRX32
[11:40:30:649] [8149:00001fd6] [INFO][com.freerdp.gdi] - [gdi_init_ex]: Remote framebuffer format PIXEL_FORMAT_BGRA32
[11:40:30:670] [8149:00001fd6] [INFO][com.freerdp.channels.rdpsnd.client] - [rdpsnd_load_device_plugin]: [static] Loaded fake backend for rdpsnd
[11:40:30:670] [8149:00001fd6] [INFO][com.freerdp.channels.drdynvc.client] - [dvcman_load_addin]: Loading Dynamic Virtual Channel ainput
[11:40:30:670] [8149:00001fd6] [INFO][com.freerdp.channels.drdynvc.client] - [dvcman_load_addin]: Loading Dynamic Virtual Channel rdpgfx
[11:40:30:670] [8149:00001fd6] [INFO][com.freerdp.channels.drdynvc.client] - [dvcman_load_addin]: Loading Dynamic Virtual Channel rdpsnd
[11:40:30:936] [8149:00001fe4] [INFO][com.freerdp.channels.rdpsnd.client] - [rdpsnd_load_device_plugin]: [dynamic] Loaded fake backend for rdpsnd
[11:40:31:244] [8149:00001fe1] [WARN][com.freerdp.channels.rdpdr.client] - [devman_get_device_by_id]: could not find device ID 0xffffffff
[11:40:31:244] [8149:00001fe1] [ERROR][com.freerdp.channels.rdpdr.client] - [rdpdr_process_irp]: irp_new failed with 55!
[11:40:31:244] [8149:00001fe1] [ERROR][com.freerdp.channels.rdpdr.client] - [rdpdr_process_receive]: rdpdr_process_irp failed with error 55
[11:40:31:245] [8149:00001fe1] [ERROR][com.freerdp.channels.rdpdr.client] - [rdpdr_virtual_channel_client_thread]: rdpdr_process_receive failed with error 55!
[11:40:31:245] [8149:00001fd6] [ERROR][com.freerdp.core] - [checkChannelErrorEvent]: rdpdr_virtual_channel_client_thread reported an error. Error was 55
[11:40:31:246] [8149:00001fd6] [ERROR][com.freerdp.core] - [freerdp_check_event_handles]: checkChannelErrorEvent() failed - 0
[11:40:31:246] [8149:00001fd6] [INFO][com.freerdp.client.common] - [client_auto_reconnect_ex]: Network disconnect!
[11:40:31:246] [8149:00001fd6] [ERROR][com.freerdp.client.x11] - [xf_client_thread]: Failed to check FreeRDP file descriptor
[11:40:31:285] [8149:00001fd5] [ERROR][com.freerdp.core] - [freerdp_abort_connect_context]: ERRCONNECT_CONNECT_CANCELLED [0x0002000B]

Expected behavior
A freerdp session-window to be shown.
Application details

FreeRDP version (xfreerdp /version → This is FreeRDP version 3.9.0 (n/a)); But I also had the same problem with all other 3.x versions
Command line used: xfreerdp /cert:ignore /d:HQ /u:XXXXXXXXXX /v:YYYYYYYYYYYYY
Output of xfreerdp /buildconfig:

This is FreeRDP version 3.9.0 (n/a)
Build configuration: BUILD_TESTING=OFF WINPR_HAVE_AIO_H=1 WINPR_HAVE_EXECINFO_BACKTRACE=1 WINPR_HAVE_EXECINFO_BACKTRACE_SYMBOLS=1 WINPR_HAVE_EXECINFO_BACKTRACE_SYMBOLS_FD=1 WINPR_HAVE_EXECINFO_HEADER=1 WINPR_HAVE_FCNTL_H=1 WINPR_HAVE_GETLOGIN_R=1 WINPR_HAVE_GETPWUID_R=1 WINPR_HAVE_INTTYPES_H=1 WINPR_HAVE_POLL_H=1 WINPR_HAVE_PTHREAD_MUTEX_TIMEDLOCK_LIB=1 WINPR_HAVE_PTHREAD_MUTEX_TIMEDLOCK_LIBS= WINPR_HAVE_PTHREAD_MUTEX_TIMEDLOCK_SYMBOL=1 WINPR_HAVE_STDBOOL_H=1 WINPR_HAVE_STDINT_H=1 WINPR_HAVE_STRERROR_R=1 WINPR_HAVE_STRNDUP=1 WINPR_HAVE_SYSLOG_H=1 WINPR_HAVE_SYS_EVENTFD_H=1 WINPR_HAVE_SYS_FILIO_H= WINPR_HAVE_SYS_SELECT_H=1 WINPR_HAVE_SYS_SOCKIO_H= WINPR_HAVE_SYS_TIMERFD_H=1 WINPR_HAVE_TM_GMTOFF=1 WINPR_HAVE_UNISTD_H=1 WINPR_HAVE_UNWIND_H=1 WITH_AAD=ON WITH_ABSOLUTE_PLUGIN_LOAD_PATHS=ON WITH_ADD_PLUGIN_TO_RPATH=OFF WITH_ALSA=ON WITH_AVX2=ON WITH_AVX2_AVAILABLE=1 WITH_BINARY_VERSIONING=OFF WITH_CAIRO=ON WITH_CCACHE=ON WITH_CHANNELS=ON WITH_CJSON_REQUIRED=OFF WITH_CLANG_FORMAT=ON WITH_CLIENT=ON WITH_CLIENT_AVAILABLE=1 WITH_CLIENT_CHANNELS=ON WITH_CLIENT_CHANNELS_AVAILABLE=1 WITH_CLIENT_COMMON=ON WITH_CLIENT_INTERFACE=OFF WITH_CLIENT_SDL=ON WITH_CLIENT_SDL2=ON WITH_CLIENT_SDL3=OFF WITH_CLIENT_SDL_AVAILABLE=1 WITH_CLIENT_SDL_VERSIONED=OFF WITH_CUPS=ON WITH_DEBUG_ALL=OFF WITH_DEBUG_CAPABILITIES=OFF WITH_DEBUG_CERTIFICATE=OFF WITH_DEBUG_CHANNELS=OFF WITH_DEBUG_CLIPRDR=OFF WITH_DEBUG_CODECS=OFF WITH_DEBUG_DVC=OFF WITH_DEBUG_EVENTS=OFF WITH_DEBUG_KBD=OFF WITH_DEBUG_LICENSE=OFF WITH_DEBUG_MUTEX=OFF WITH_DEBUG_NEGO=OFF WITH_DEBUG_NLA=OFF WITH_DEBUG_NTLM=OFF WITH_DEBUG_RAIL=OFF WITH_DEBUG_RDP=OFF WITH_DEBUG_RDPDR=OFF WITH_DEBUG_RDPEI=OFF WITH_DEBUG_RDPGFX=OFF WITH_DEBUG_REDIR=OFF WITH_DEBUG_RFX=OFF WITH_DEBUG_RINGBUFFER=OFF WITH_DEBUG_SCARD=OFF WITH_DEBUG_SCHANNEL=OFF WITH_DEBUG_SDL_EVENTS=OFF WITH_DEBUG_SDL_KBD_EVENTS=OFF WITH_DEBUG_SND=OFF WITH_DEBUG_SVC=OFF WITH_DEBUG_SYMBOLS=OFF WITH_DEBUG_THREADS=OFF WITH_DEBUG_TIMEZONE=OFF WITH_DEBUG_TRANSPORT=OFF WITH_DEBUG_TSG=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_TSMF_AVAILABLE=0 WITH_DEBUG_URBDRC=OFF WITH_DEBUG_WND=OFF WITH_DEBUG_X11=OFF WITH_DEBUG_X11_LOCAL_MOVESIZE=OFF WITH_DEBUG_XV=OFF WITH_DOCUMENTATION=OFF WITH_DSP_EXPERIMENTAL=OFF WITH_DSP_FFMPEG=OFF WITH_DSP_FFMPEG=OFF WITH_DSP_FFMPEG_AVAILABLE=0 WITH_EVENTFD_READ_WRITE=1 WITH_FAAC=OFF WITH_FAAD2=OFF WITH_FDK_AAC=ON WITH_FFMPEG=OFF WITH_FREERDP_DEPRECATED=OFF WITH_FREERDP_DEPRECATED_COMMANDLINE=OFF WITH_FULL_CONFIG_PATH=OFF WITH_FUSE=ON WITH_GFX_FRAME_DUMP=OFF WITH_GFX_H264=ON WITH_GPROF=OFF WITH_GSM=ON WITH_INTERNAL_MD4=OFF WITH_INTERNAL_MD5=OFF WITH_INTERNAL_RC4=OFF WITH_IPP=OFF WITH_JPEG=ON WITH_JSONC_REQUIRED=ON WITH_JSON_DISABLED=OFF WITH_KEYBOARD_LAYOUT_FROM_FILE=ON WITH_KRB5=ON WITH_KRB5_NO_NTLM_FALLBACK=OFF WITH_LAME=ON WITH_LIBRARY_VERSIONING=ON WITH_LIBRESSL=OFF WITH_LODEPNG=OFF WITH_MACAUDIO=OFF WITH_MACAUDIO_AVAILABLE=0 WITH_MANPAGES=ON WITH_MBEDTLS=OFF WITH_NATIVE_SSPI=OFF WITH_NEON=OFF WITH_OPENCL=OFF WITH_OPENH264=TRUE WITH_OPENH264=TRUE WITH_OPENH264_LOADING=OFF WITH_OPENSSL=ON WITH_OPUS=ON WITH_OSS=ON WITH_PCSC=ON WITH_PKCS11=ON WITH_PLATFORM_SERVER=ON WITH_POLL=ON WITH_PROFILER=OFF WITH_PROXY=ON WITH_PROXY_APP=ON WITH_PROXY_EMULATE_SMARTCARD=OFF WITH_PROXY_MODULES=ON WITH_PULSE=ON WITH_RDTK=ON WITH_SAMPLE=OFF WITH_SANITIZE_ADDRESS=OFF WITH_SANITIZE_ADDRESS_AVAILABLE=1 WITH_SANITIZE_MEMORY=OFF WITH_SANITIZE_MEMORY_AVAILABLE=1 WITH_SANITIZE_THREAD=OFF WITH_SANITIZE_THREAD_AVAILABLE=1 WITH_SDL_IMAGE_DIALOGS=OFF WITH_SDL_LINK_SHARED=ON WITH_SERVER=ON WITH_SERVER_CHANNELS=ON WITH_SERVER_INTERFACE=ON WITH_SHADOW=ON WITH_SHADOW_MAC=ON WITH_SHADOW_X11=ON WITH_SMARTCARD_EMULATE=ON WITH_SMARTCARD_INSPECT=OFF WITH_SMARTCARD_PCSC=ON WITH_SOXR=ON WITH_SSE2=ON WITH_SWSCALE=OFF WITH_SYSTEMD=ON WITH_THIRD_PARTY=OFF WITH_TIMEZONE_COMPILED=OFF WITH_TIMEZONE_FROM_FILE=ON WITH_TIMEZONE_ICU=OFF WITH_UNICODE_BUILTIN=OFF WITH_URIPARSER=ON WITH_VAAPI=OFF WITH_VAAPI=OFF WITH_VAAPI_AVAILABLE=0 WITH_VALGRIND_MEMCHECK=OFF WITH_VALGRIND_MEMCHECK_AVAILABLE=1 WITH_VERBOSE_WINPR_ASSERT=ON WITH_VIDEO_FFMPEG=OFF WITH_VIDEO_FFMPEG=OFF WITH_VIDEO_FFMPEG_AVAILABLE=0 WITH_WAYLAND=ON WITH_WEBVIEW=OFF WITH_WINPR_DEPRECATED=OFF WITH_WINPR_JSON=ON WITH_WINPR_TOOLS=ON WITH_WIN_CONSOLE=ON WITH_X11=ON WITH_XCURSOR=ON WITH_XEXT=ON WITH_XFIXES=ON WITH_XI=ON WITH_XINERAMA=ON WITH_XKBFILE=ON WITH_XRANDR=ON WITH_XRENDER=ON WITH_XTEST=ON WITH_XV=ON WITH_ZLIB=ON
Build type:          Release
CFLAGS:              -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wno-error=incompatible-pointer-types -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fPIC -Wall -fvisibility=hidden -Wimplicit-function-declaration -Wredundant-decls -g -fno-omit-frame-pointer
Compiler:            GNU, 14.2.1
Target architecture: x64
Keyboard Shortcuts:
	<Right CTRL>
		releases keyboard and mouse grab
	<CTRL>+<ALT>+<Return>
		toggles fullscreen state of the application
	<CTRL>+<ALT>+c
		toggles remote control in a remote assistance session
	<CTRL>+<ALT>+m
		minimizes the application
	Action Script
		Executes a predefined script on key press.
		Should the script not exist it is ignored.
		Scripts can be provided at the default location ~/.config/freerdp/action.sh or as command line argument /action:script:<path>
		The script will receive the current key combination as argument.
		The output of the script is parsed for 'key-local' which tells that the script used the key combination, otherwise the combination is forwarded to the remote.

OS version connecting to (server side): Windows 10 Business 22H2
log output from a run with /log-level:trace 2>&1 | tee xfreerdp_trace.log:
xfreerdp_trace.log

Environment:

OS: Linux
Version/Distribution: Fedora Linux 41 (Workstation Edition); but same Problem since Version 39
Architecture: x86_64

Note
Same error reported in merge [channels,settings] add a setting to ignore invalid devices #8911: https://github.com/FreeRDP/FreeRDP/pull/8911#issuecomment-2441918384
The error also occurs if you use a local user account on the target machine.

Hmm, could you add /smartcard for a test?
This looks like the server ignores that the client does not announce device redirection

Also a full log with /log-level:debug could help

Thank you very much for looking into this!
Some points:

Great, brilliant: adding /smartcard fixed the problem!
I had added a trace log to the issue - is that enough or should I attach another log file with /smartcard option. If yes - debug or trace level ?
For me, this /smartcard work-around is perfectly adequate 😊

@gbhauck no, I know what is going on now, so should be easy to fix.


Add test for including all provider configuration files in given directory

This PR adds a test for .include directive that includes all provider configuration files from a given directory. The test aims to check that providers are successfully loaded when the provider section for the provider is part of the included configuration files. The details are discussed in #22148.
Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

I am not sure whether we need this as this obviously should work if loading of providers by config files work (tested elsewhere) and loading of configs from an include dir works (which is also tested already). But I assume it does not hurt to have this.

I didn't find tests of include directory so @xhanulik added them explicitly

I didn't find tests of include directory so @xhanulik added them explicitly

huh... includes.cnf contains .include conf-includes and conf-includes is a directory containing two config files. The test (even before this addition) checks that both are included.

And also we test that the same section in several files is successfully combined

This pull request is ready to merge

Merged to the master branch. Thank you for your contribution.


Range Fields

In Python 3 a range(0,10,3) creates a range object rather than a list. We can make use of this to display a range-specific UI element such as slider.
This will require additions to clinto to detect and pass the object type and parameters somehow.
https://github.com/wooey/clinto/issues/3

Moving to the Wooey repo.


Update modal

Add style to modal. Add condition in getPokemon function and optional function call based on arguments passed to getPokemon

awesome progress!


zqd migrate command

Add zqd migrate command for migrate old zqd spaces to zed lake pools. This is
a hidden command meant to be used specifically in the Brim desktop app for
migrating old zqd spaces, this is not meant for general consumption.
Closes #58

I tested this out using Brimcap commit 9f2b61a from this branch and it seems to work as intended.
To test, I started out with GA Brim v0.24.0 and loaded it up with several Spaces, a few of which were based on pcaps and a couple based on Zeek logs. The following video shows a baseline where I show the "Whole Space" histogram of each Space and extract the packets for a particular flow from each of the pcap-based ones.
https://user-images.githubusercontent.com/5934157/116826352-6d057000-ab48-11eb-83c9-75b39c7e7716.mp4
At this point I installed the nightly build https://storage.googleapis.com/brimsec-releases/brim/v0.25.0-prerelease-09efdcd9.0/macos/Brim-0.25.0-prerelease-09efdcd9.0.dmg, simulating what would happen when we release GA v0.25.0 and the user is auto-updated to the new release.
Then in the next video, I execute the migration command. As shown, the output provides a summary as it migrates each Space and whether or not it contains a pcap. These progress updates can all be helpfully shared with the user in the app as a progress report.
$ brimcap migrate -zqd="$HOME/Library/Application Support/Brim/data/spaces" -root="$HOME/Library/Application Support/Brim/data/brimcap-root"

https://user-images.githubusercontent.com/5934157/116826802-b656bf00-ab4a-11eb-9378-aac26dba605b.mp4
As expected, the new version has no knowledge of Spaces. We plan to eventually add a modal that will inform the user of what to expect in the new experience, as well as the Space-migration-specific guidance described in https://github.com/brimdata/brim/issues/1567. For now, however, we see the app no longer shows anything in the area that formerly showed Spaces.
I've been accustomed to selecting View > Reload from the pull-down menu in Brim when updating data in Pools, since the app isn't yet notified when what's stored in the backend has changed. However, in this case that was not enough, since as I learned separately from looking in DevTools and ultimately examining the contents of the appState.json, there's currently still state about Spaces lingering in the appState.json post-upgrade. I expect this is something that will be addressed as part of https://github.com/brimdata/brim/issues/1567. For now I just did a more aggressive Window > Reset State which has the impact of clearing out the appState.json and starting over with just the contents of the data/ directory, which in this case is our migrated Pool data and corresponding Brimcap root.
As the video shows, at that point I'm able to click through each Pool and see that each histogram is drawn similarly to how it was before.
For each uid I'd targeted previously when they were Spaces, you can see i was able to successfully extract the flow and open it in Wireshark.
I'll also pass along the observation that after the migration was complete, there's still a data/spaces/ directory left behind, with the only contents being the single file zqd.json:
$ cat zqd.json
{"version":6,"space_rows":[]}

That seems like a reasonable representation of what would be left behind after removing all Spaces, but considering the new version of the app is expected to lack any knowledge of what this directory is used for, we might want to think about the migration script or the app removing it completely when it reaches this state.


question

can you give me your QQ? I have some questions to ask you about autonomous driving in carla.

why you have two carla's version in base_config.py
egg_config = {...}

why you have two carla's version in base_config.py egg_config = {...}

你好，请问你成功运行了他这个程序吗？我没法成功的运行他这个程序，出现了这个报错。请问你是怎么复现的呢？


Authentication services

Current coverage is 78.36% (diff: 53.33%)

Merging #52 into master will increase coverage by 2.06%

@@             master        #52   diff @@
==========================================
  Files            29         27     -2
  Lines           325        319     -6
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            248        250     +2
+ Misses           77         69     -8
  Partials          0          0

Powered by Codecov. Last update 36e81c5...93d508c


Progress Indicator Style/Color Updates

The Progress Indicator needs to be updated to fix the following issues:

The blue Tooltip should always use regular Tooltip text (i.e. no bold, no italic)
The blue Tooltip should always be blue even if an error occurs on a step
The error icon (red triangle) needs to be updated to the new error icon (red ban sign) - this might automatically change when we update to Summer ’18 (SLDS 2.6.0)

** Note: If an error occurs a second error icon should be placed to the left of the buttons (e.g. Cancel, Save) and the Error Popover should appear indicating there are errors. These additional items are NOT part of this component. This note was included for visibility purposes. **


Create frontend API call functions

Description
API calls are made from many different areas of the app, and many are repeated. We need a set of functions which does all the API call logic, so the pages can just call these functions rather than implementing its own logic.
Acceptance Criteria

[ ] All user APIs are functional
[ ] All Person APIs are functional
[ ] All Encounter APIs are functional
[ ] All API calls have error handling logic
[ ] Functions are tested.

Implementation details

n/a
Testing notes

n/a

lgtm 😎


Update lazytox.py

Breaking Change:

Description:
Related issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for configuration.yaml (if applicable):

Checklist:

[ ] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[ ] There is no commented out code in this PR.
[ ] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @vitoriasviana,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Hacktoberfest spam PR. Marking invalid and closing.


Incorrect behavior when setter and static method has the same name

In specification 10.7:

It is a static warning if a class C declares a static method named n and has
a setter named n =.

But this code
void main() {
  new Foo();
}

class Foo {
  Foo() {
    bar(42);
  }

  void set bar(int value) {
    print("setter");
  }

  static void bar(int value) {
    print("static");
  }
}

causes no warnings, even in strict mode, and prints static. But dart2js fails with error Duplicate definition of 'bar'.

Analyzer now reports:

Class 'Foo' can't define static member 'bar' and have instance member 'Foo.bar' with the same name.