Botskiy

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 83b07a9e-5e16-32ed-265e-32a32998ce37
Version Independent ID: 09008259-4b53-2925-9679-ecad59cefe41
Content: Tutorial - Customize Microsoft Entra attribute mappings in Application Provisioning - Microsoft Entra ID
Content Source: docs/identity/app-provisioning/customize-application-attributes.md
Service: entra-id
Sub-service: app-provisioning
GitHub Login: @kenwith
Microsoft Alias: kenwith

#please-close

@romankulkovsf
We are going to close this thread if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.

Hey
On Mon, May 13, 2024 at 9:23 PM TBalaji-MSFT @.***>
wrote:

@romankulkovsf https://github.com/romankulkovsf
We are going to close this thread if there are any further questions
regarding the documentation, please tag me in your reply and we will be
happy to continue the conversation.
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/entra-docs/issues/801#issuecomment-2109254396,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BFQ6X44XWTD7JFN764BQKE3ZCGGS3AVCNFSM6AAAAABHVA6EJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBZGI2TIMZZGY
.
You are receiving this because you were mentioned.Message ID:
@.***>


Feat/devtools

Integration with Redux Dev Tools in progress 🦖

Codecov Report

Merging #9 (f89835e) into main (e336884) will decrease coverage by 36.85%.
The diff coverage is 11.57%.

@@             Coverage Diff             @@
##             main       #9       +/-   ##
===========================================
- Coverage   98.46%   61.60%   -36.86%
===========================================
  Files           4        5        +1
  Lines         130      224       +94
  Branches       28       63       +35
===========================================
+ Hits          128      138       +10
- Misses          2       86       +84

Impacted Files
Coverage Δ

src/devtools.ts
10.63% <10.63%> (ø)

src/state.ts
97.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e336884...f89835e. Read the comment docs.


Update README

Currently what we have is still the Nx generated readme. It should be replaced with a more useful one.
Development setup, testing, what we have currently, how it is structured, visions, etc.

 Update README to be more accurate

https://github.com/ducktordanny/opres.help/pull/61


Match Arduino & Raspberry Pi Code Samples

Simplified the Arduino code sample
Updated the Raspberry Pi code sample to match the Arduino code sample

Any update?


Use top level await in Sandcastle

This  updates Sandcastle code to use top-level await syntax by making window.startup and async function. That function is now awaited and wrapped with a catch, and any errors are logged in the console.
As a result of this, this PR also removes any blocks with the (async () => { ... })(); pattern.
This DOES NOT account for a final pass on how we are handling async code in Sandcastle examples before we publish changes discussed in https://github.com/CesiumGS/cesium/pull/11059. This is an update that mainly simplifies syntax some existing examples.

Thanks @ggetz, this is a big cleanup for the Sandcastles that await something, and a minimal change for Sandcastles without async code. I confirmed that links to local Sandcastles developed before this PR will still work.
One question about the pattern at the end of the gallery Sandcastles: Some of them end with this pattern, like AmbientOcclusion.html:
        //Sandcastle_End
        Sandcastle.finishedLoading();
      };
      if (typeof Cesium !== "undefined") {
        window.startupCalled = true;
        try {
          window.startup(Cesium);
        } catch (error) {
          console.error(error);
        }
      }

Others end like this (3D Tiles Next S2 Globe.html):
      if (typeof Cesium !== "undefined") {
        window.startupCalled = true;
        window.startup(Cesium).catch((error) => {
          "use strict";
          console.error(error);
        });
        Sandcastle.finishedLoading();
      }

I think this is neater than the try...catch block, but:

I don't think the "use strict" is needed?
Do we always want the Sandcastle.finishedLoading() inside the if block?

A few I3S-related Sandcastles don't have any .finishedLoading call.

Thanks for pointing that out. These should use the startup().catch pattern. The try/catch pattern would need another higher level async function and an addition await keyword. The mis-match is due to and incomplete find/replace which  I've updated. I've also update the I3S Sandcastles.

I don't think the "use strict" is needed?
eslint is calling for it, I believe it's there for the same reason as the "use strict"; as the first line of the startup function.

Do we always want the Sandcastle.finishedLoading() inside the if block?
I suppose it doesn't have to be. I was thinking if we do have a long-running await in the Sandcastle code, we probably might want to show the loading overlay until the startup function is complete rather than just called. You can see the viewer once created even if additional async code is running. However, it should be consistant in all the Sandcastles either way.

Looks good, merging now!


Vanilla Text Classification

What does this PR do?

Vanilla text classification example without transformers. Using AG_News dataset
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Hello @nahidgrid! Thanks for opening this PR.

In the file pl_examples/basic_examples/text_classification.py:

Line 29:19: W291 trailing whitespace
Line 32:1: E302 expected 2 blank lines, found 0
Line 51:5: E303 too many blank lines (2)
Line 53:23: E231 missing whitespace after ','
Line 58:10: E231 missing whitespace after ','
Line 58:17: E231 missing whitespace after ','
Line 59:23: E231 missing whitespace after ','
Line 64:10: E231 missing whitespace after ','
Line 64:17: E231 missing whitespace after ','
Line 65:23: E231 missing whitespace after ','
Line 80:1: E303 too many blank lines (3)
Line 81:9: E117 over-indented
Line 88:1: E302 expected 2 blank lines, found 1
Line 96:5: E265 block comment should start with '# '
Line 124:5: E265 block comment should start with '# '
Line 136:10: W292 no newline at end of file

Do see the Hitchhiker's guide to code style


AK to CCS merge for 03 june 2019

There was a version bump in AK to 2.7.0-SNAPSHOT. The merge needed to be applied manually.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Created by mistake, closing it.


Route model binding->missing method not working as expected

Hi,
So I came across this issue and posted it on laracasts forums.
I'm creating an app with Inertia and vuejs.
So I have a resource controller and the route for it is as following
Route::apiResource('course-info-sections', CourseInfoSectionController::class)
        ->parameters([
            "course-info-sections" => "section"
        ])
        ->missing(function ()
        {
            return redirect()->back()->withErrors([
                "Section Not Found"
            ]);
        });

in Vue (manually supplying an invalid ID)
const deleteSection = function () {
  router.delete(route("course-info-sections.destroy", "20"), {
    onSuccess: () => (deleteModalOpen.value = false),
    onError: (e) => toast.error(e[0]),
  });
};

the route for delete and update have a URL parameter section
the route works perfectly when supplied with the proper ID, but when I manually supply a wrong ID (one that doesn't exist in the DB). it would show me a 404 page (which is the expected behaviour), I searched the docs and found the "missing" method and applied it as above, but now instead of redirecting it back I get an error
The course-info-sections method is not supported for route PATCH. Supported methods: GET, HEAD, POST.
I tried to dd("Not Found") in the closure of the missing method, and that works.

Long story short, the workaround found by Sinnbeck was to change the order of middleware in Kernel.php, I did that and the problem is solved
here is his reply
Got it working :D

It depends on the order of your middleware in your Kernel.php. The inertia middleware MUST come before the SubstituteBindings

This doc says to put it last, but that means it wont work with this. https://inertiajs.com/server-side-setup#middleware

I cannot guarantee that it does not give other issues

he mentions that he's unsure if changing the order could break other functionalities, as inertia docs asks to put the inertia middleware at the very end.
here is a link to the entire thread
Unsure if this is a bug or the docs need to be updated (i.e. inertia middleware doesn't need to be at the very end).

Hey there,
We're closing this issue because it's inactive, already solved, old or not relevant anymore. Feel to open up a new issue if you're still experiencing this problem.


Out of stock itemid bugfix

This pull request has been merged with another pull request. It is included in #35


Syntax error displayed

v2.56.2
?- op(1,xfx,'').
   true.
?- [user].
''(.\\,//.).

?- X''Y, Z=X+Y.
   X = .\\, Y = //., Z = .\\ +//. . % unexpected
?- Z = .\\ +//. .
Error: syntax error, near '+//.', operator expected, user:1

?- Z = .\\ + //. .
   Z = .\\ + //. . % expected
?-

?- X''Y, Z=X+Y.
   X = .\\, Y = //., Z = .\\ + //. .

?- X''Y, Z=X''Y.
   X = .\\, Y = //., Z = .\\  ''  //. .  % Interesting, 2 more spaces added.

% Scryer does remove spaces in this case.
%  X = .\\, Y = //., Z = .\\''//.. % (Hint .. has been reported #2555)

Double spacing.


Range based for loop

Description
Documentation
Domain
C/CPP
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign


Deploy your app for free 🚀

Hey @Alexandre Monteiro, I'm reaching out because I took a look at your project on GitHub (monteiro-alexandre/pet-feeder-web) and decided to reach out to see if you'd be interested in free hosting. I'm the owner of DeeloCloud, a serverless dev platform that allows you to easily deploy frontend and backend apps in minutes. It's built for developers, it's super easy to use, and you won't have to manage servers - which means you can focus on building!

Here's how it works in a few steps:

After signing up at https://www.deelo.cloud:

1.) Select the repo and branch where your app lives. In this case, it would be monteiro-alexandre/pet-feeder-web.
2.) Select the runtime template of the app you wish to deploy.
3.) Hit deploy. 🚀
4.) In a few minutes your app will be live.
5.) Each time you push code to your branch, your app will pick up the changes and re-deploy.
And boom, just like that you got yourself free hosting!

Would this be something that would be useful to you? Let me know
Happy coding,
Davaughn White
<EMAIL_ADDRESS>DeeloCloud

Wrong Alexandre….
Please check the user first.
On Sun, Jan 2, 2022, at 8:13 PM, davaughncodes wrote:

Hey @alexandre https://github.com/alexandre Monteiro, I'm reaching out because I took a look at your project on GitHub (monteiro-alexandre/pet-feeder-web) and decided to reach out to see if you'd be interested in free hosting. I'm the owner of DeeloCloud, a serverless dev platform that allows you to easily deploy frontend and backend apps in minutes. It's built for developers, it's super easy to use, and you won't have to manage servers - which means you can focus on building!
Here's how it works in a few steps:
After signing up at  https://www.deelo.cloud/https://www.deelo.cloud:
1.) Select the repo and branch where your app lives. In this case, it would be monteiro-alexandre/pet-feeder-web.
2.) Select the runtime template of the app you wish to deploy.
3.) Hit deploy. 🚀
4.) In a few minutes your app will be live.
5.) Each time you push code to your branch, your app will pick up the changes and re-deploy.
And boom, just like that you got yourself free hosting!
Would this be something that would be useful to you? Let me know
Happy coding,
Davaughn White
@.***
DeeloCloud https://www.deelo.cloud/
—
Reply to this email directly, view it on GitHub https://github.com/monteiro-alexandre/pet-feeder-web/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABICNOYAV6TTPXMVV6WN3SDUUDL2FANCNFSM5LEFSIBA.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>


Spellcheck notebooks

Description
Many of our notebooks have typos in them. It'd be good to at least do a manual pass to check them before 1.0, and even check them automatically.

@timpitman had the idea that we could potentially use the nbsphinx/HTML conversion to do the checking here. If that doesn't work, another way would be to convert them to markdown with nbconvert and then use a markdown spell checker.

May create too much fixing work for 1.0
User noticed typos and submitted PR.
Filed a follow up issue about other potential PRs.
Good opportunity to get people contributing!


Make HEAD reference a branch by drawing an arrow

It would be useful for "HEAD" to draw a arrow to the branch it is referencing.
This would make

a bit more clearer.
Maybe related to https://github.com/git-school/visualizing-git/issues/1

Relatedly, note that after git branch newbranch, the HEAD box is in between the two branches, but after git checkout, the HEAD box is back to the bottom of the stack. So the HEAD relative position in the stack of pointers does not seem to indicate anything relevant. If this is intended, then it would be better to make HEAD always at the bottom.


npm packages that are known to work

These are npm packages that are known to work in Azle.

bs58

ripemd160

uuid
import { v4 as uuidv4 } from 'uuid';

This works if you manually add something like this code:
globalThis.crypto = {
    getRandomValues: () => {
        let array = new Uint8Array(32);

        for (let i = 0; i < array.length; i++) {
            array[i] = Math.floor(Math.random() * 256);
        }

        return array;
    }
};

We'll work on providing this under-the-hood.

hex-array

sha3
import { Keccak } from "sha3";

works fine with default encoding

sha3
import { Keccak } from "sha3";

works fine with default encoding


Zuul  doesn't pass client certificate for 2 way ssl  backend calls

We cant store keystore into java cacerts file. Instead we have separate keystore /truststore jks files using which we tried to create a ssl context and set it on http client bean for zuul application. It worked but gives performance issues - high response time in highly concurrent environment.  Any other alternative to tackle this ?

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.


Failed to create models in the cloud: Modelgen job creation failed

Before opening, please confirm:

[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
No response
Region
ap-northeast-1
Environment name
dev
Amplify CLI Version
No response
If applicable, what version of Node.js are you using?
5.1.2
What operating system are you using?
mac 11.5
Browser type?
chrome
Describe the bug
If i use amplify/backend/api/<api name>/schema.graphql file it successfully deploy model on admin
if I move schema.graphql file amplify/backend/api/<api name>/schema/ActionType.graphql it fails with Failed to create models in the cloud: Modelgen job creation failed
similar issue: https://github.com/aws-amplify/amplify-adminui/issues/64
Expected behavior
create cloud model on split graphql
Reproduction steps

create amplify api
try amplify/backend/api/<api name>/schema.graphql
try amplify/backend/api/<api name>/schema/ActionType.graphql with same content

Additional information
No response

Hey @matart15 :wave: thanks for raising this! A few questions to better understand the issue:

are you able to run amplify codegen models?
do you have DataStore enabled?

Yes everything was working except Admin UI data modeling.

amplify codegen models generated.
appSync queries and mutations were generated
I data and content menu on this image displays nothing.

Hey @matart15 thank you for the details. I am also seeing this issue on amplify push if I use the schema/ directory with DataStore enabled, which also results in an empty "Data" and "Content" pages in AdminUI.
Error I'm receiving on push, though push is successful:
Failed to create models in the cloud: Modelgen job creation failed

Marking this as a bug


Fix/address addl rules fps

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:
Address several sources of FPs, primarily from GKE environments.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Address several sources of FPs, primarily from GKE environments.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign mstemm
You can assign the PR to them by writing /assign @mstemm in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

rules/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

24c44cf Fix typo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign kaizhe
You can assign the PR to them by writing /assign @kaizhe in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

rules/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign mstemm
You can assign the PR to them by writing /assign @mstemm in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

0be529f Squash w/ Update Package Repository

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fntlnz check out the last commit, it changes the trace files that get downloaded by the tests to have versioning now. I think this is a clean way to handle changes in trace files, as I needed for this PR.
We can also put the trace files in git somewhere but some of them are pretty big.

LGTM label has been added.  Git tree hash: 6aec83d5541d70a81b870b6ffc0e0f87792e044d

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Kaizhe
To complete the pull request process, please assign mstemm
You can assign the PR to them by writing /assign @mstemm in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.26.0

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leogr
You can assign the PR to them by writing /assign @leogr in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

39b97fb Squash w/ package commit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leogr
You can assign the PR to them by writing /assign @leogr in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: e97492b11997ab0473c3a175601c2480c3802be7

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Kaizhe, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mstemm how are the integration tests file generated? Now that they are versioned I would like to understand how we can get them to a shape where everyone can read a document on how to add new ones.


Detect usages of methods.include? and suggest respond_to? instead

Is your feature request related to a problem? Please describe.
We've found some instances of bad performance related to calling include? directly over the result of Kernel#methods. This can be answered more efficiently by calling Object#respond_to?.
Here's a benchmark for the difference in my system. dummies is an array of 1000 empty structs, while methods is an array of 1000 randomly generated symbols 5 lowercase letter characters in length.
Benchmark.bm do |x|
  x.report { dummies.map { |dummy| dummy.methods.include?(methods.sample) } }
  x.report { dummies.map { |dummy| dummy.respond_to?(methods.sample, false) } }
  x.report { set = Set.new(dummies.first.methods); dummies.map { |dummy| set.include?(methods.sample) } }
end

       user     system      total        real
   0.009405   0.001026   0.010431 (  0.011214)
   0.000393   0.000872   0.001265 (  0.001265)
   0.000134   0.000169   0.000303 (  0.000303)

The difference between calling methods.include? and using respond_to? accounts for a full order of magnitude in real time. Similarly, it's shown that if you are repeatedly checking for different methods over the same class, creating and querying a set with the result of methods will provide an additional performance boost.
For the reasons stated above, I think it'd be useful to detect cases where this happens and provide a warning to programmers.
Describe the solution you'd like
A rubocop cop that detects methods.include?(:x) and public_methods.include?(:x) and suggests respond_to?(:x, true) and respond_to?(:x, false) respectively.
Describe alternatives you've considered
I cannot think of alternative solutions besides not doing this.
Additional context
The system where I run the benchmark was a MacBook Pro with the Apple M2 chip and 16 GB of RAM memory. The Ruby version was Ruby 3.3.3.

This makes sense to me. I recently saw a PR in rails about the same thing with instance methods.
The same thing can also apply for constants => const_defined?, class_variables => class_variable_defined?, *class_methods => class_method_defined?, though I have neither tested performance nor checked if there are subtle differences between these versions.
It would be nice if this can also regognize [foo.methods + foo.private_methods].include? => foo.method_defined? || foo.private_method_defined? but for a first implementation not necessary.


cdc print unexpected logs

What did you do?
1、create bdr cluster
2、create changefeed
3、restart downstream
What did you expect to see?
No response
What did you see instead?
the up stream print log which was not unexpected
[2024/05/02 09:57:33.821 +08:00] [ERROR] [config.go:210] ["The TiDB source ID should never be set to 0. Please report it as a bug. The default value will be used: 1."] [default=0]
Versions of the cluster
./cdc version
Release Version: v8.1.0
Git Commit Hash: 38eb040812f817df410abe870952629df60fd01f
Git Branch: HEAD
UTC Build Time: 2024-04-30 06:27:14
Go Version: go version go1.21.4 linux/amd64
Failpoint Build: false
2024-05-02T07:06:00.351+0800
current status of DM cluster (execute query-status <task-name> in dmctl)
No response

/remove-area dm
/area ticdc
/assign asddongmen

This issue will not cause any actual error; it's just an annoying log.


Enable feedback, add search keywords, typo fix

Docs Build status updates of commit cc9f032:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

TerminalDocs/cascadia-code.md
:white_check_mark:Succeeded
View

TerminalDocs/docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Data grid] Review code that is already available

### Tasks
- [x] reorganising storybook (put everything on draft)
- [ ] writing unit tests

### Write tests for files
- [x] column-group
- [x] column
- [x] filter-column
- [x] filter
- [x] grid
- [x] sort-column
- [x] sorter
- [ ] view-model

@jpzwarte could you please review this one?


Update update-demo example to use kubectl

gce-e2e passing with changes. Will need to hold off merging until a release is cut that includes latest additions to kubectl, otherwise the update test will be broken for gke-e2e. #2575

@jlowdermilk is there someone you have in mind to review who knows this issue well?

cc @zmerlynn, @mbforbes

I went ahead and updated the update.sh e2e test to use kubectl as well, and verified it works (with gce provider).

LGTM

Handful of little nits, but looking good, Jeff. Thank you for doing this!

PTAL. I'd like to get this merged (once I can get a non-flaky travis run) now that kubectl 0.9 is in the latest cloudsdk.

LGTM pending travis/squash. Thanks Jeff!

Zach's looking and will do the LGTM label honors

LGTM but I'll let @mbforbes merge

Travis kicked. Please squash.


KAFKA-16352: Txn may get get stuck in PrepareCommit or PrepareAbort s…

…tate
Now the removal of entries from the transactionsWithPendingMarkers map checks the value and all pending marker operations keep the value along with the operation state.  This way, the pending marker operation can only delete the state it created and wouldn't accidentally delete the state from a different epoch (which could lead to "stuck" transactions).
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

LogDirFailureTest > testIOExceptionDuringLogRoll(String) > testIOExceptionDuringLogRoll(String).quorum=kraft is failing locally, will investigate.
ReplicaManagerTest -- all tests passed locally.

LogDirFailureTest > testIOExceptionDuringLogRoll(String) has been failing for a while -- there are some issues I tried to tackle with respect to it, but we ran into some issues.  See https://github.com/apache/kafka/pull/15354

@artemlivshits it may be worth checking if the test is failing on trunk as well. If so we can renew the JIRA to fix it 😅

LogDirFailureTest passed locally as well (probably just a flake) and it doesn't seem to use any of the code that I touched, so unrelated.

I ran "until failure" on trunk and it took about 30 runs to fail.

I am seeing it fail more often on your branch (for a few runs), but after merging with trunk, it seemed better. I will go ahead and merge.


thread 'when::tests::on_vec' panicked at 'leaks detected', crates/verona-rt/src/scheduler.rs:54:17

On d5639994f6dd6af210d366a7ed6ca2ff841f2b72
while cargo t --lib -p verona-rt ; do :; done

will eventually fail with:
    Finished test [unoptimized + debuginfo] target(s) in 0.00s
     Running unittests src/lib.rs (target/debug/deps/verona_rt-d9aca5cc7dcb1261)

running 17 tests
test cown::tests::actualcown_constats_right ... ok
test scheduler::tests::panic_safe ... ignored, https://github.com/aDotInTheVoid/boxcars/issues/4
test cown::tests::clone_minimal ... ok
test when::tests::double_aquire - should panic ... ok
test cown::tests::dtor ... FAILED
test cown::tests::dtor_clone ... ok
test cown::tests::leak_detector_new ... ok
test cown::tests::new ... ok
test cown::tests::new_minimal ... ok
test cown::tests::read_modify_write ... ok
test cown::tests::write_stress ... ok
test scheduler::tests::basic_run ... ok
test when::tests::basic ... ok
test when::tests::when_two ... ok
test when::tests::on_vec ... ok
test scheduler::tests::run_from_multi_threads ... ok
test cown::tests::clone_notnull ... ok

failures:

---- cown::tests::dtor stdout ----
thread 'cown::tests::dtor' panicked at 'leaks detected', crates/verona-rt/src/scheduler.rs:54:17

failures:
    cown::tests::dtor

test result: FAILED. 15 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.61s

error: test failed, to rerun pass `-p verona-rt --lib`

Reduced:
while cargo t --  when::tests::double_aquire  scheduler::tests::run_from_multi_threads; do :; done

It's not about the thread exiting while panicing:
use verona_rt::scheduler::with_leak_detector;

fn generate_work() {
    std::thread::scope(|s| {
        for _ in 0..10 {
            s.spawn(|| {
                for _ in 0..100 {
                    with_leak_detector(|| {});
                }
            });
        }
    });
}

fn panic_with_sched() {
    let msg = std::panic::catch_unwind(|| with_leak_detector(|| panic!("welp")))
        .unwrap_err()
        .downcast::<&str>()
        .unwrap();
    assert_eq!(&**msg, "welp");
}

#[test]
fn main() {
    for _ in 0..20 {
        let a = std::thread::spawn(generate_work);
        let b = std::thread::spawn(panic_with_sched);

        a.join().unwrap();
        b.join().unwrap()
    }
}


want add some function to list the dirs

once i get a file with name .
it returns not exist.
i checked a long time,but don't know why.
at last, i see something in your source.
the root path must start with /...

added a comment...


Mention Channel Glitch

I have a little problem when mention channel the # over the text, like this :

idk it just me or not, but it's a bit annoying

Its an issue with Revert Rebrand, Ducko is aware of it and will fix it when he's free

Refresh, might be fixed.

thanks, problem fixed


[vNext] Fixing List dividers: last cell with children shows an additional divider

Platforms Impacted

[x] iOS
[ ] macOS

Description of changes
The last cell in a nested list showed double dividers which did not align with the intended appearance. This fix gets rid of the extra divider in the List.
Verification

Pull request checklist
This PR has considered:

[ ] Light and Dark appearances
[ ] VoiceOver and Keyboard Accessibility
[ ] Internationalization and Right to Left layouts
[ ] Different resolutions (1x, 2x, 3x)
[ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)

Microsoft Reviewers: Open in CodeFlow

can you also make sure all your pr description and screenshots are updated appropriately based on the template?


Configure release to BinTray and release it

https://bintray.com/beta/#/cognifide/maven-public/gradle-htl-plugin?tab=overview

Release v1, but it still have some concerns, I need to fix them and release new version


Custom form partials

If we have partial with partial name = class name, use it to display this class data.
Goals:

low costs of adding custom form display
no need to write services to receive data?
minimal js requirements

Ideas?
@ssarkisy

I like it.
On Wed, Jan 25, 2017 at 3:37 PM, Eduard<EMAIL_ADDRESS>wrote:

If we have partial with partial name = class name, use it to display this
class data.
Goals:

low costs of adding custom form display
no need to write services to receive data?
minimal js requirements

Ideas?
@ssarkisy https://github.com/ssarkisy
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/intersystems-ru/RESTFormsUI/issues/22, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ACpyP5BBhGDz0NdhhTeLUu4YpTwcEai0ks5rV0IKgaJpZM4Ltb7N
.


Introspection page links to two apps but the links are incorrect

They should link to the app home page and not to the app raw KRL code.

Fixed by this commit


Fix broken unit tests

I'm not sure why, but a number of the unit tests have broken since the last release:
https://ci.appveyor.com/project/PlagueHO/xstorage/build/<IP_ADDRESS>
It appears that a recent pester (4.0.2) change has broken these. Pester version 3.4.6 works correctly. It appears to be a pester bug that prevents Get-Volume from being mocked in two successive Context blocks. Only the first Mock works. The second Mock does not mock the call and so the underlying cmdlet is called instead.

I believe this may be caused by an issue in Pester and have logged it:
https://github.com/pester/Pester/issues/697

I've submitted a change to force the old version of pester to be used in AppVeyor. I'll leave this issue open until Pester 4.0.2 bugs are fixed. Once that is done I'll submit another PR to allow the new version of Pester to be used.


Multiple pick up sounds trigger unexpectedly

Discovered in https://github.com/phetsims/faradays-electromagnetic-lab/issues/103, we found that when keyboard dragging an item such as the Projectile Data Lab stopwatch or the Faradays Electromagnetic Lab field meter node, there is a sound when you press an arrow key, indicating the pick up.  When you release the key there is a drop sound.  That is all working well.
But if you press multiple keys, for instance, to move something at a diagonal, there is an unexpected sound effect. For instance:

Tab to select the Field Meter Node in screen 1 of FEL.
Press the right arrow to start dragging to the right
While dragging to the right, tap the down arrow repeatedly.

The effect is that you will hear multiple pickup sounds even though the tool is already picked up.
Likewise, if you hold down the right arrow and press the left arrow, the object will stop moving and you will hear another "pick up" sound.
I reached out to @jessegreenberg and he said this was unexpected and should be addressed. He indicated the problem may lie in this code:
https://github.com/phetsims/scenery/blob/a4abda75b38bf3a44a690223224af9de84d67cbc/js/listeners/KeyboardDragListener.ts#L322-L342
This means the "drag started" sequence is getting called more than once, which may be causing other side effects.  @jessegreenberg can you please review and advise?

This was fixed during #1570, the start callback only calls at the start of the operation instead of every key press. Closing.


pass subscription filepath to use when writing files

@maroux tested this and it works but want to see what you think of it before changing the tests here


Sample use

Is there any sample code for using the reader to create a filled DataTable ?
Something analogous to
using (var dataAdapter = new SqlDataAdapter(queryString, sqlConnStr)) {     var dataTable = new DataTable();     dataAdapter.FillSchema(dataTable, SchemaType.Mapped); }

The CSV reader implements IDataReader, so you can simply call table.Load(reader).

Hi Sébastien :
Thanks for the reply.  I have tried as you suggested.  The following code
does not error or throw exceptions, however the DataTable has no rows in it.
        filename = "SampleAnalysis.csv";
        DataTable csvData = new DataTable();
        DelimitedRecordReader reader = new DelimitedRecordReader(new

StreamReader(filename));
csvData.Load(reader);
Can you make a suggestion on how to proceed or learn more about data table
load ?
Regards
Richard
On Sat, Feb 18, 2017 at 12:58 PM, Sébastien Lorion<EMAIL_ADDRESS>
wrote:

The CSV reader implements IDataReader, so you can simply call
table.Load(reader).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/slorion/nlight/issues/12#issuecomment-280863088, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADltl6nk50cUfZvZ8JbdeJwu5F-WHPiOks5rdzFRgaJpZM4MFMIc
.

It looks like the internal behavior of the DataTable.Load function has changed at some point. It is calling IDataReader.FieldCount before calling IDataReader.GetSchemaTable and if the field count is 0, it will not get the schema. One quick workaround is to call reader.ReadColumnHeaders() before calling table.Load(reader).


Consumer don't inherit the stub config in the provider

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Environment

Dubbo version: 3.2.3
Operating System version: Win11
Java version: 1.8

Steps to reproduce this issue
Provider service config stub="true". Consumer don't inherit the stub config, and must manually set up the stub="true" config.

stub config is design for consumer and not support configure in the provider side.

@AlbumenJ Okay, thank you for your reply.


Spark Job Never Terminates

We're running a simple Spark job to fetch some docs with a given query and get a count. We're using Spark with Kubernetes mode, pointing to the Kubernetes master, and have confirmed a simple WordCount program (not with SolrCloud) works.
We can see our answer printed, but the following log line repeats at the end:
2018-11-28 17:11:06 DEBUG ClientCnxn:717 - Got ping response for sessionid: 0x16756a7c6de0017 after 1ms
Relevant code in the driver:
    val conf = new SparkConf().setAppName("Solr Spark Driver")
    val sc = new SparkContext(conf)

    val args = new SolrConf(argv)

    val searchTerm = args.search().toString
    log.info("Search Term: " + searchTerm)

    val searchField = args.field().toString
    log.info("Search Field: " + searchField)

    val collectionUrls = args.collection()
    log.info("Collection URL: " + collectionUrls)

    val index = args.index()
    log.info("Index Name: " + index)

    val debug = args.debug()
    log.info("Debug: " + debug)

    // query Solr
    log.info("Querying Solr")
    val queryResult = SolrQuery.queryRDD(searchField, searchTerm, index, sc)
    log.info("Num docs: " + queryResult.count)

and the queryRDD helper:
  // Points to Zookeeper with SolrCloud
  def queryRDD(searchField: String, searchTerm: String, index: String, sc: SparkContext) = {
    val solr = new SelectSolrRDD("<IP_ADDRESS>:32181", index, sc)
    val result = solr.query(searchField + ":" + searchTerm)
    result
  }

Any ideas why the job never terminates? Do we need to close some resources in spark-solr?

Here's a minimal example that produces the correct output, but doesn't terminate.
val conf = new SparkConf().setAppName(getClass.getSimpleName)
val sc = new SparkContext(conf)

val rdd = new SelectSolrRDD(args.solr(), args.index(), sc)
  .rows(args.rows())
  .query(args.field() + ":" + args.term())
  .foreach(println)

If I remove the rows, query, and foreach the program still doesn't terminate.

@kiranchitturi That seems to do the trick - though I don't need to do that for normal Spark applications. Should the docs be updated?


tinyssh: 20220311 -> 20220801

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/janmojzis/tinyssh/releases.
meta.description for tinyssh is: "minimalistic SSH server"
meta.homepage for tinyssh is: "https://tinyssh.org"
meta.changelog for tinyssh is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 20220801 in filename of file in /nix/store/bry8m6qs7d6f6wkkccv12z92nchag4ks-tinyssh-20220801

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
tinyssh

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/bry8m6qs7d6f6wkkccv12z92nchag4ks-tinyssh-20220801 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A tinyssh https://github.com/r-ryantm/nixpkgs/archive/20be65cf54c1d0a99820fc7faa3fc2479b09df08.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/bry8m6qs7d6f6wkkccv12z92nchag4ks-tinyssh-20220801
ls -la /nix/store/bry8m6qs7d6f6wkkccv12z92nchag4ks-tinyssh-20220801/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

tinyssh

Maintainer pings
cc @KAction for testing.

nixpkg-review successfully build the package
1 package built:
tinyssh

running it also worked. LGTM


Add user to group chat

I'd like to ask for creation of the feature to enable users to add other people to the group call. Or, at least, allow developers to add a custom buttom in the interface so we can program this feature ourselves.

Work has begun for public preview introducing the chat composite into ui library.
For progress you can check the native repos
Android: https://github.com/Azure/communication-ui-library-android/tree/develop/azure-communication-ui/chat
iOS: https://github.com/Azure/communication-ui-library-ios/tree/develop/AzureCommunicationUI/sdk/AzureCommunicationUIChat


iss-407 FieldTypeConversionUtils add long #407

PR Branch
#ADD LINK TO THE PR BRANCH
Motivation and Context
I need it for the project I’m working on.
Checklist:

[x] Unit tests added

[ ] Integration tests added

[ ] Test names are meaningful

[x] Feature manually tested

[ ] Branch build passed

[ ] No 'package.*' in the imports

[ ] Relevant Wiki page updated with clear instruction for the end user

[ ] Not applicable. This was only a refactor change, no functional or behaviour changes were introduced

[ ] Http test added to http-testing module(if applicable) ?

[ ] Not applicable. The changes did not affect HTTP automation flow

[ ] Kafka test added to kafka-testing module(if applicable) ?

[ ] Not applicable. The changes did not affect Kafka automation flow

@authorjapps here it’s with some tests

Build https://travis-ci.org/github/authorjapps/zerocode/builds/698878181

Solves #407


Touchable area of context menu is too small on Android

RN 0.74.1
Content of context menu is highlighted with orange.

On Android it tappable only on the top border (1-3px) of orange area. On iOS everything is fine. Any idea how to make all children content of ContextMenu tappable?
return (
    <View style={classes.root}>
      <BottomSheet bottomSheetModalRef={bottomSheetModalRef} />
      <ContextMenu
        style={{ backgroundColor: 'orange' }}
        width={24}
        height={24}
        onLongPress={() => null}
        dropdownMenuMode={true}
        actions={[
          { title: i18n.t('translate_to'), icon: icons.language },
          { title: i18n.t('report_content_issue'), icon: icons.report, destructive: true },
        ]}
        onPress={(e) => {
          console.warn('ContextMenu tapped');
        }}
      >
        <View style={classes.touchable}>
          <MenuCircleIcon />
        </View>
      </ContextMenu>
    </View>
  );

Seems like it related to the RN issue like this https://github.com/entria/react-native-view-overflow/issues/32
same issue was discussed there: https://github.com/facebook/react-native/pull/26374
I was able to find a workaround by expanding parent area and use positioning to put it to the required place.

Still get another issue. On Android it renders outside of visible area.

@mpiannucci have you experienced such behaviour before?


add shortcode for training page

this PR https://github.com/kubernetes/website/pull/24014

review page
https://deploy-preview-24875--kubernetes-io-master-staging.netlify.app/training/
/assign @tengqm

I don't see any difference after updating, it seems to be a frame update, right?

@howieyuen
Hello, there will be no difference, just replaced the iframe with a short code, and the page shows that everything works, as here
https://github.com/kubernetes/website/pull/24014

/lgtm


Unable to set ClientSideComponentId for LinkTitle Field in Contacts List (Template 105)

Category

[x] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
A developer can set ClientSideComponentId for LinkTitle field in Contacts list in the same way as for other types of lists (like Custom Lists).
Observed Behavior
ClientSideComponentId is not set neither from REST API (including PnP JS and PnP PowerShell), nor from CSOM/JSOM.
No error is thrown, the values just ignored.
Steps to Reproduce
POST /sites/TestSite/_api/web/lists/getByTitle('Contacts')/fields('82642ec8-ef9b-478f-acf9-31f7d45fbc31')

{"ClientSideComponentId":"bcd1d42b-8935-4436-9d9d-56c6618e1958"}

Same request for Custom List (template 100) works, as well as for other fields.

This is by design.


onChange is not working

onChange is not working how to get input values

onChange is working here. Can you provide a code example and explain what you're trying to achieve so you can receive the help you need?

onchange is not working with formik


Stream connections do not close when an error occurs during reading

Environment
Knex version: 2.1.0, probably others
Database + version: PostgreSQL 13.7, SQLite3, probably others
OS: Mac, Alpine Linux, probably others
Node version: 14, probably others
The Bug
I'm using the Knex streams API and consuming a query stream with an async iterator, and my own async iteration code sometimes throws an error. When this happens, I would expect that stream's database connection to be automatically destroyed, but it's actually being left open and never cleaned up. When I later try to manually call await knex.destroy() in clean-up code, the promise never resolves, and it hangs forever. When I connect to the database manually through another client, I can see that the query is still executing.
My understanding is that, for general async iterators created from a stream, an error thrown in the iteration should propagate  to the source Readable stream, which can then close the stream and perform any required clean-up. So I think it makes sense for Knex to be responsible for handling the clean-up of the connection, and not the consuming code.
Code reproducing the error
var knex = require('knex')({
  client: 'pg',
  connection: 'postgres://testuser:knextest@localhost:25432/knex_test',
});

// Alternatively, the same issue occurs with SQLite3
// var knex = require('knex')({
//   client: 'sqlite3',
//   connection: { filename: ':memory:' },
// });

async function main() {
  const stream = knex.raw('VALUES (1),(2),(3)').stream();

  try {
    for await (const x of stream) {
      throw new Error('boom');
    }
  } catch (e) {
    console.error(e);
  }

  console.log('Destroying connection...');
  // The following promise never resolves
  await knex.destroy();
  // The following code never gets executed
  console.log('Connection destroyed');
}

main();

Potential Fix
I've written up some code that I think will fix the issue, and have a PR ready. I think the issue is:

The client.releaseConnection method is not being called. I think this should always be called once the stream has closed.
The Transform stream object returned by the .stream() call has an overridden destroy method, which is not propagating errors back and closing the source stream. This method should not be overridden; a PR has been opened here removing this. (More discussion here).

Released in 2.2.0


error_status_hint = 400 even when we are the client

import h11
conn = h11.Connection(our_role=h11.CLIENT)
conn.send(h11.Request(method='GET', target='/', headers=[('Host', 'foo')]))
conn.send(h11.EndOfMessage())
conn.receive_data(b'')
try:
    conn.next_event()
except h11.RemoteProtocolError as exc:
    print(exc.error_status_hint)

This prints:
400

The error_status_hint might make sense when our_role=h11.CLIENT insofar as a server may be acting as a gateway. In that case, it may be more useful to have this hint set to 502 (Bad Gateway). Or perhaps removed altogether, so that (presumably) the server’s default 5xx kicks in — but this would be a breaking API change.

Breaking changes are possible -- see #17. (It sounds like you might want to subscribe to #17 in any case.)
I'm a little unclear on how you're imagining this being used; can you elaborate? I guess the way I was conceptualizing it was, we give as precise a code as we can to describe what the error was, and then it's up to you what to do with this information. (If you're a client, probably not much.)
LocalProtocolErrors also have the hint, which is even more useless. I guess it means something like "if I had allowed you to send this (and that actually were possible), and the peer was a server at a point in the state machine where they send back an error status, then this is the one they would send"?
Which reminds me that there's also the case where we are in server mode, and get a nice error_status_hint but then can't do anything with it because we're not in a state where we can legally send a response. Maybe this is fine, but worth mentioning I guess.
We can't really change how LocalProtocolErrors work because at the point where they're generated we don't necessarily have access to connection state information (e.g. they can be raised by event object constructors). For RemoteProtocolErrors there is a single point where they're constructed and it does have access to connection state information. But I don't have a clear concept of what the goal would be?

I'm a little unclear on how you're imagining this being used; can you elaborate?

In the (toy) app that I’m building with h11, I have a catch-all error handler modeled after your Curio example. And then inside the actual request handler I sometimes operate a gateway: I open a socket to an upstream server and forward the request to it using h11. Now, if the upstream server misbehaves, I get a RemoteProtocolError, but my gateway code doesn’t do any error handling, so it bubbles up to the catch-all, which ends up sending 400 where really 502 or 500 is called for.
Of course, I can easily catch RemoteProtocolError in the gateway code and raise some other exception in its place. So, probably a wacky idea.


[FIX] Fix the chunked processing with async workflow

@leske42 yo check the last commit, if the post body still processing we need to make sure the EPOLLOUT is on, to trigger the process flow again


Repo is missing a license

What's the license of this code?
I'd suggested MIT like Bitcoin or GPL-3.0 like Stacks.

Ok will talk with the team to update this

We will proceed with the MIT license

License Added

Great! Thank you!


Incorrect SSZ encoding for SignedBuilderBid

Hello, I noticed a difference between mev-boost & this package when SSZ encoding a SignedBuilderBid object. In the output below, Bid1 is the SSZ that mev-boost generates & Bid2 is the SSZ that this package generates. Near the beginning, there's a missing chunk of 32 bytes (spoiler, this is the value field).
signing_test.go:160: Bid1: 0x540000000000000000000000000000000000000000000000000000000000000000000000b5246e299aeb782fbc7c91b41b3284245b1ed5206134b0028b81dfb974e5900616c67847c2354479934fc4bb75519ee10544e2170998060d9560fdbf8f263a08c0a209211569a0560138522b84805abc0000000000000000000000000000000000000000cded53d652660a91bfe6f5dfb017204a4cdd1598a07116b2cdea1586d603d01c56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b42100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000d60955dc7f0cc7bf28d7e6c6f4859081f3a6df5ef4f70e05d70d8282bac20c6c4fa70e000000000080c3c901000000000000000000000000d051ed6200000000180200000700000000000000000000000000000000000000000000000000000000000000ea33078b00e6b2926f45ed6d3190a3a6ada75cee342f600cf22fa02a9a2edcb77ffe241ea60187fdb0187bfa22de35d1f9bed7ab061d9401fd47e34a54fbede1466c617368626f747320666c617368626c6f636b
signing_test.go:166: Bid2: 0x54000000b5246e299aeb782fbc7c91b41b3284245b1ed5206134b0028b81dfb974e5900616c67847c2354479934fc4bb75519ee10544e2170998060d9560fdbf8f263a08c0a209211569a0560138522b84805abc0000000000000000000000000000000000000000cded53d652660a91bfe6f5dfb017204a4cdd1598a07116b2cdea1586d603d01c56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b42100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000d60955dc7f0cc7bf28d7e6c6f4859081f3a6df5ef4f70e05d70d8282bac20c6c4fa70e000000000080c3c901000000000000000000000000d051ed6200000000180200000700000000000000000000000000000000000000000000000000000000000000ea33078b00e6b2926f45ed6d3190a3a6ada75cee342f600cf22fa02a9a2edcb77ffe241ea60187fdb0187bfa22de35d1f9bed7ab061d9401fd47e34a54fbede1466c617368626f747320666c617368626c6f636b
signing_test.go:167: Value: []

Code used to generate this
bidStr := `{"message":{"header":{"parent_hash":"0x0544e2170998060d9560fdbf8f263a08c0a209211569a0560138522b84805abc","fee_recipient":"0x0000000000000000000000000000000000000000","state_root":"0xcded53d652660a91bfe6f5dfb017204a4cdd1598a07116b2cdea1586d603d01c","receipts_root":"0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421","logs_bloom":"0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","prev_randao":"0xd60955dc7f0cc7bf28d7e6c6f4859081f3a6df5ef4f70e05d70d8282bac20c6c","block_number":"960335","gas_limit":"30000000","gas_used":"0","timestamp":"1659720144","extra_data":"0x466c617368626f747320666c617368626c6f636b","base_fee_per_gas":"7","block_hash":"0xea33078b00e6b2926f45ed6d3190a3a6ada75cee342f600cf22fa02a9a2edcb7","transactions_root":"0x7ffe241ea60187fdb0187bfa22de35d1f9bed7ab061d9401fd47e34a54fbede1"},"value":"0","pubkey":"0xb5246e299aeb782fbc7c91b41b3284245b1ed5206134b0028b81dfb974e5900616c67847c2354479934fc4bb75519ee1"},"signature":"0xa775df980d589a87b234cf36b94fbcd40540ab1dffb752a013c02f636d85db60023f7e9d883de8cfdbfd94e0e3b598c01429fee50a5cb8d9fce50557baec2e9f81268f14f4f044b44b1238b7945201f036036d1a25d60e681f3737d4ef3b54b6"}`

// Decode with mev-boost types.
bid1 := new(types.SignedBuilderBid)
require.NoError(t, utils.DecodeJSON(strings.NewReader(bidStr), bid1))
bid1Ssz, err := bid1.Message.MarshalSSZ()
require.NoError(t, err)
t.Log("Bid1:", hexutil.Encode(bid1Ssz))

// Decode with attestant types.
bid2 := new(bellatrix_api.SignedBuilderBid)
require.NoError(t, utils.DecodeJSON(strings.NewReader(bidStr), bid2))
bid2Ssz, err := bid2.Message.MarshalSSZ()
require.NoError(t, err)
t.Log("Bid2:", hexutil.Encode(bid2Ssz))
t.Log("Value:", bid2.Message.Value.Bytes())

The problem is with the Value field, which is a uint256.Int type:
https://github.com/attestantio/go-builder-client/blob/fe1a8d4e7677d47e00e8fe61a752548e45585498/api/bellatrix/builderbid.go#L34
In Holiman's uint256 package, the Bytes method unintuitively returns the minimal number bytes, instead of 32 bytes like one might expect. This confuses fastssz which uses this method:
https://github.com/attestantio/go-builder-client/blob/fe1a8d4e7677d47e00e8fe61a752548e45585498/api/bellatrix/builderbid_encoding.go#L28-L33
It should have generated something like this:
--- a/api/bellatrix/builderbid_encoding.go
+++ b/api/bellatrix/builderbid_encoding.go
@@ -26,11 +26,11 @@ func (b *BuilderBid) MarshalSSZTo(buf []byte) (dst []byte, err error) {
        offset += b.Header.SizeSSZ()

        // Field (1) 'Value'
-       value := b.Value.Bytes()
+       value := b.Value.Bytes32()
        for i, j := 0, len(value)-1; i < j; i, j = i+1, j-1 {
                value[i], value[j] = value[j], value[i]
        }
-       dst = append(dst, value...)
+       dst = append(dst, value[:]...)

        // Field (2) 'Pubkey'
        dst = append(dst, b.Pubkey[:]...)

Because this is generated code, I'm not entirely sure what the proper solution should be. I don't believe we can hint to fastssz about which method to use there. A possible option is to wrap the uint256.Int method and override the Bytes method. Or create your own basic uint256 class, like mev-boost does.

Also worth mentioning, this applies to a few other places too:
https://github.com/attestantio/go-builder-client/blob/fe1a8d4e7677d47e00e8fe61a752548e45585498/api/bellatrix/builderbid_encoding.go#L117-L122
https://github.com/attestantio/go-builder-client/blob/fe1a8d4e7677d47e00e8fe61a752548e45585498/api/capella/builderbid_ssz.go#L29-L34
https://github.com/attestantio/go-builder-client/blob/fe1a8d4e7677d47e00e8fe61a752548e45585498/api/capella/builderbid_ssz.go#L118-L123
https://github.com/attestantio/go-builder-client/blob/fe1a8d4e7677d47e00e8fe61a752548e45585498/api/v1/bidtrace_encoding.go#L44-L49
https://github.com/attestantio/go-builder-client/blob/fe1a8d4e7677d47e00e8fe61a752548e45585498/api/v1/bidtrace_encoding.go#L136-L141

If I'm reading this correctly, should uint256 always be a 64-byte value, and if is it an issue to address in fastssz?  Or is there any situation where uint256.Bytes() would be a valid encoding?

According to the SSZ spec, a uint256 value should always encoded as a 32-byte value. And yeah, I think it should be fixed in fastssz if possible. I'm not certain, but I believe uint256.Bytes() is valid for something, but not SSZ.

Or is there any situation where uint256.Bytes() would be a valid encoding?

Sorry, I misunderstood your question. Yes, it would be valid when the lowest (little-endian) byte is non-zero.

Yeah sorry the question wasn't very precise; I was wondering if there was any situation where an output with fewer than 32 bytes would be valid SSZ, but I suspect not.

That's a great find, thanks @jtraglia! 🕵
How do we proceed from here?

@mcdee I'm having trouble generating BuilderBid with sszgen. How was this done?
jtraglia at desktop in ~/Projects/attestantio/go-builder-client/api/bellatrix (master●)
$ go generate
...
[ERR]: failed to encode BuilderBid: could not find struct with name 'Int'
generate.go:18: running "sszgen": exit status 1

With ../../../../holiman/uint256 added to the list of includes, it has this error:
jtraglia at desktop in ~/Projects/attestantio/go-builder-client/api/bellatrix (master●)
$ go generate
...
[ERR]: failed to encode BuilderBid: failed to encode Int: unexpected mismatch between ssz-size and array fixed size, name=Int, ssz-size=32, fixed=4
generate.go:18: running "sszgen": exit status 1

Are the SSZ encoded versions in use today?
If so, if someone can supply both correct and incorrect encodings for a SignedBuilderBid I can take a look at fixing this in a two-step process as follows:

change decoding to use either format
change encoding to use correct format (i.e. fixed 32-byte size for uint256)

Otherwise, I can just change encoding and decoding to use the correct format.

well, both the relay and mev-boost and the builder uses<EMAIL_ADDRESS>so all of them use the incorrect encoding. for SignedBuilderBid and BidTrace.
I think the best way forward will be to simply fix everything that uses uint256.Int.

I think the best way forward will be to simply fix everything that uses uint256.Int.

I can do that, but that will create an incompatibility between versions.  If you are comfortable with builders and relays being able to upgrade in lock-step then I can go ahead with this as the fix.

Okay, so I have some really good news. The hash tree root is different ONLY when the message.value is zero. For non-zero values, even though the SSZ is incorrect, the HTR value is correct. And because the relays reject zero-value bids, this should never happen in practice. So it should be safe to fix & update mev-boost, mev-boost-relay, and builders. This explains why everything's working fine right now, because otherwise I'd expect there to be signature disagreements.

Sounds like a simple fix should do the job, then.  Please could someone supply me with a few correctly-encoded objects so that I can add them to the tests?

@karalabe didn't you already solve this, back when you noticed the same problem in the 4844-implementation?
cc @MariusVanderWijden

Yeah, so one part of the solution was to add the ssz interfaces to uint256:
https://github.com/holiman/uint256/pull/126/files
Another part was to properly invoke the interface, IIRC some other change was made to the ssz-library to accommodate this.

This issue should be addressed in #10, @jtraglia @metachris please could you take a look at this and see if you're happy with it?
The PR is quite large because of other changes in the go-eth2-client repo, but the main files to look at are:

api/bellatrix/builderbid_encoding.go
api/capella/builderbid_ssz.go
api/v1/bidtrace_encoding.go

@mcdee might have been better to use the ssz marshalling methods, MarshalSSZTo, instead of using b.Value.Bytes32() and for-looping the endian-ness thingy
https://github.com/holiman/uint256/pull/126/files#diff-4caa05d97eba477e577a7721860f68293d7371001a42747af73e647b581a5e9bR470
https://github.com/attestantio/go-builder-client/pull/10/files#diff-0b7d53e341f9d6f752684cd80200ceafb2143527ce57365c62442f499aae8cf1R119
So instead of
	value := b.Value.Bytes32()
	for i, j := 0, 31; i < j; i, j = i+1, j-1 {
		value[i], value[j] = value[j], value[i]
	}
	hh.PutBytes(value[:])

You could have done
	value, err := b.Value.MarshalSSZ()
	// perhaps handle error
	hh.PutBytes(value[:])


Display relative paths

Maybe not a good idea since cwd might change during execution etc - but it clearly helps for bt to see the source/app itself.
Ref: https://github.com/antocuni/pdb/pull/236

Back to https://github.com/pdbpp/pdbpp/pull/236.


Migrate to pytest

As discussed previously, this replaces nose test runner with pytest.
This way there is a uniform toolset for python and python-base.

This is a fix for #167.

/lgtm
This lgtm to me.
Although, nosetests is still being used in the main repo to provide access to the code coverage reports of the base repo. This could also be switched to pytest as well -https://github.com/codecov/example-python

/lgtm
/approve


[5.7] Simplify conditions

replace (new static)->newQuery() to static::query() in Eloquent Model

I already sent in a PR for this to master to prevent breaking things if people overwrote the static query method: https://github.com/laravel/framework/pull/26569

oh, sorry. Should we revert this from the 5.7?
Also on this PR onWriteConnection was changes (you not send this to the master)

@TBlindaruk IMO think it's best if we revert this yeah. About onWriteConnection: I think I just looked over it :)


Add GraphQL mutation to create QR code

As specified in the trello ticket linked below, this PR implements the createQrCode mutation.
If the boxLabelIdentifier argument is not null, the QR code is associated with an existing box.
Question: can there be a scenario when the boxLabelIdentifier is passed in but no corresponding box exists? In that case the QR code creation would fail because peewee can't find the box for the specified identifier.

@pylipp I believe the data input should be validated in the backend, so, even though this can be prevented on the front-end by only passing valid box identifier to this mutation, it would be necessary to validate the input or fulfill the request with a partial response that contains the errors.


Possible WebIDL violation?

The spec says:

Set media session’s current media session type to the corresponding media session type of media session category. If no corresponding media session type can be found for the provided media session category or media session category is empty, then set media session’s current media session type to "content".

Won't WebIDL have thrown because the media session is not one of MediaSessionKind? Also, why don't you just default kind to "content" in the WebIDL constructor? Then you are assured the media session category is content when no argument is given (and you don't need the redundant prose).

I fixed the constructor bit in https://github.com/whatwg/mediasession/commit/7bd3065436df4e3c5e76e744d89cb264fcb10756 and will remove the extra prose now.


Fix resolution of wind streams and vectors

The wind streams and wind vectors use lower resolution grids for plotting, as plotting every gridpoint results in a mess. Currently this is done in a very non-systematic way, and this should be changed to use  proper regridding with the same density for all plots (e.g. 2 grid points per degree of latitude/longitude.

No longer relevant to latest implementation of FOREST.


Improve readme, add screenshots and application examples

Application examples:

FIR vs. nonlinear filters, when to use (plot each to compare)
Using sigmoid function to scale output of FIR

README.md installation instructions at "Option 1: HACS" lacks sensor configuration.
Maybe it could be:

Option 1
Option 2
Common for both options: Sensor installation

README.md installation instructions at "Option 1: HACS" lacks sensor configuration. Maybe it could be:
* Option 1

* Option 2

* Common for both options: Sensor installation

@drogfild do you mean that after using HACS, installation should proceed from what is currently Option 2 point 4, modifying config.yaml?
@robsonke kindly added HACS support, but I don't use HACS so I'm not quite up to date what exactly it does and doesn't do.

It's nothing special, it's just an automated way of checking out git repos of plugins and keeping them up to date in case you release a new version.

Ok, modified README, does it make sense now?

Thanks for the addon. I have some feature request for the documention after using nordpool_diff two weeks.

The output is most suitable for fine-tuning continuously adjustable things (thermostats), or it can be thresholded to control binary things that can be switched on/off anytime, such as water heaters.

It has been nice if you could publish example automation for how to use the different sensors for adjusting termostats for heating floor and heating pump.

I use now a threshold sensor "binary_sensor.dyr_strom" with the "sensor.nordpool_diff_triangle_10" which are on if the value is above 0 and off when the value is below 0. I use the threshold sensor in a automation for heat or cool the heating cables or heat pump. Sometimes the sensor is off to long when the price is high in the daytime. How can I adjust the time the sensor is off?
`alias: Thermostat bad1etg
description: ""
trigger:

platform: state
entity_id:

group.somebody_home
binary_sensor.billig_strom
schedule.thermostat_schedule
binary_sensor.regulator_padrag_under_3
condition: []
action:

if:

condition: state
entity_id: group.somebody_home
state: home
condition: state
entity_id: binary_sensor.dyr_strom
state: "off"
condition: state
entity_id: schedule.thermostat_schedule
state: "on"
condition: state
entity_id: binary_sensor.regulator_padrag_under_3
state: "off"
then:
service: climate.set_temperature
data:
temperature: 23
hvac_mode: heat
target:
entity_id: climate.varmekabel_bad1etg
else:
service: climate.set_temperature
data:
temperature: 20
hvac_mode: heat
target:
entity_id: climate.varmekabel_bad1etg
mode: single
`

You're welcome @overas !
Thresholding at 0 is reasonable way to control binary things. However, as written in README,

there are no guarantees about how many hours per day the output will stay above some threshold, even if typical price variations may make the output typically behave this or that way most of the time.

Setting the threshold to lower (slightly negative) value, or trying out rank or interval filters may help a bit, but so far there's no perfect way to work around

Sometimes the sensor is off to long when the price is high in the daytime.

because the output is just price_of_electricity(t) fed through a linear filter. So price_of_electricity directly affects the output, and it can vary in arbitrary ways even though it often follows more or less similar shape over 24h.
BTW if you try thresholding the linear filters at nonzero boundary, it's a good idea to use some form of normalize.
Personally I'm using nordpool_diff to control target temperature of an air heat pump and I think it works very well there. I'll publish an example of that automation soon when I have time. Meanwhile, I'm using settings

- platform: nordpool_diff
  filter_length: 15
  filter_type: triangle
  normalize: max_min_sqrt_max


No Decoding of Http2PingFrame / Http2GoAwayFrame

We are seeing logs such as
Discarded inbound message DefaultHttp2GoAwayFrame(errorCode=0, content=UnpooledSlicedByteBuf(ridx: 8, widx: 15, cap: 15/15, unwrapped: PooledUnsafeDirectByteBuf(ridx: 24, widx: 41, cap: 63)), extraStreamIds=0, lastStreamId=771) that reached at the tail of the pipeline. Please check your pipeline configuration.
Discarded inbound message DefaultHttp2SettingsFrame[...]
Discarded inbound message DefaultHttp2PingFrame[...]

Using the client like this
NettyClientBuilder[F].withHttp2.resource

@sam0jones0 try this branch and see if this works better for you: https://github.com/http4s/http4s-netty/pull/721


Create jobs that backup to Azure blob

Are there options or parameters that can be set in MaintenanceSolution.sql that will cause the jobs to be created to backup to Azure blob storage?

MaintenanceSolution.sql does not have options to create jobs to backup to Azure Blob Storage. You will have to create the jobs or modify the existing jobs.
The jobs that comes with MaintenanceSolution.sql are just to make it easy to get started. They don't support all the options in the stored procedures.


remove podspec target checks

since CocoaPods 0.39.0 is the minimum CocoaPods version required, these are guaranteed to be present.
watchos was added in 0.38.0 and tvos was added in 0.39.0
/cc @mrackwitz

:+1: That's been overdue. I wanted to tackle that since a while. 😁


dotnet on ARM32 and ARM64

The dotnet conda-forge packages do not currently support ARM32 and ARM64. Binaries are available from Microsoft to support these architectures. It would be helpful to IoT applications if these architectures were included in conda-forge.

There's osx_arm64 for macOS with ARM64 and aarch64 for Linux with ARM64, but I haven't come across any such tags for Windows with ARM64 or ARM32. Does anyone know what they are or if they exist?

The Linux ones should be fairly easy to package. 👍🏼

Oh sorry I was referring to ARM64 Linux, which would be aarch64. Having the armhf package would also be helpful, although I guess conda-forge doesn't officially support it.
The Windows ARM64 is here: https://dotnet.microsoft.com/download/dotnet/thank-you/sdk-5.0.202-windows-arm64-installer
I don't have an ARM64 Windows device so I can't test it.

I gave it a shot in those PRs. I skipped the lttng-ust dependency for aarch64, which I don't know if appropriate, but it does look like dotnet gives signs of life without it. If that doesn't work, we may need to find a way to get the lttng-ust packaged for aarch64.

Merged those two PRs but let us know if you run into trouble regarding lttng-ust. I don't have an ARM64 Linux machine to test it out.

I will try it on a raspi 4 today.

I tested some basic programs on a raspi 4 and they seem to work fine. I'll let you know if I run in to any errors in the future.


Time constants

Constants to avoid code comments like
private static long TIMEOUT = 10000l; // 10s

Why not use TimeUnit from java.util.concurrent? http://docs.oracle.com/javase/6/docs/api/java/util/concurrent/TimeUnit.html


coverages with OGR datasoure and where clause for text columns

If, according to Documentation, a source is limited to an OGR datasource including a where clause/SQL statement referring to a non-integer column (text/varchar), mapproxy fails.
Context

Mapproxy supports

Any polygon datasource that is supported by OGR (e.g. Shapefile, GeoJSON, PostGIS).
Restrict which polygons should be loaded from the datasource. Either a simple where statement (e.g. 'CNTRY_NAME="Germany"') or a full select statement.

Since GDAL 2.0 strict SQL 92 rules (SQL quoting) are in force http://www.gdal.org/ogr_sql.html#ogr_sql_quot

String literals (constants) must be surrounded with single-quote characters. e.g. WHERE a_field = 'a_value'. Identifiers (column names and tables names) can be used unquoted if they don't contain special characters or are not a SQL reserved keyword. Otherwise they must be surrounded with double-quote characters. e.g. WHERE "from" = 5.

This means the now only two valid options to pass are

WHERE a_field = 'a_value'

WHERE "a_field" = 'a_value'

whilst the whole where clause or sql statement must be quoted as well (both in .yaml config or if used on the command line e.g. mapproxy-util export --coverage ...)
Expected Behavior

to work again like when using ogrinfo or ogr2ogr on the CLI with -where or -sql option
Actual Behavior

Mapproxy fails with:

Traceback (most recent call last):
File "/home/mapproxy/venv/bin/mapproxy-util", line 11, in
sys.exit(main())
File "/home/mapproxy/venv/lib/python3.5/site-packages/mapproxy/script/util.py", line 387, in main
commands[command]'func'
File "/home/mapproxy/venv/lib/python3.5/site-packages/mapproxy/script/export.py", line 274, in export_command
base_path=os.getcwd())
File "/home/mapproxy/venv/lib/python3.5/site-packages/mapproxy/config/coverage.py", line 96, in load_coverage
geom = load_datasource(datasource, where)
File "/home/mapproxy/venv/lib/python3.5/site-packages/mapproxy/util/geom.py", line 74, in load_datasource
return load_ogr_datasource(datasource, where=where)
File "/home/mapproxy/venv/lib/python3.5/site-packages/mapproxy/util/geom.py", line 103, in load_ogr_datasource
raise CoverageReadError(ex)
mapproxy.util.geom.CoverageReadError: b'"name" not recognised as an available field.'

or

mapproxy.util.geom.CoverageReadError: b'Type mismatch or improper type of arguments to = operator.'

Possible Fix

adopt the parameter passing into OGR in mapproxy.util.ogr
https://github.com/mapproxy/mapproxy/blob/668b6202d89ac8315c79b2606a458ee3a77c35c2/mapproxy/util/ogr.py#L106
until here, a correct quoted "where parameter" is still correct quoted when passed into OGR_DS_ExecuteSQL()

print(where)
"select * from OGRGeoJSON where CNTRY_NAME = 'Germany'"

print(where.encode('utf-8'))
b"select * from OGRGeoJSON where CNTRY_NAME = 'Germany'"

Steps to Reproduce

I did not try with OSGEO OGR, only with LIBOGR (GDAL/OGR package)
if where parameter is used with numeric field (e.g. 'where id = 137') it works as expected
.yaml config with coverage and where clause
it doesn't matter how the quoting is set or if it's a complete sql statement
or
on the CLI e.g. (it doesn't matter how the quoting is set or if it's a complete sql statement)

mapproxy-util export -f test.yaml --source test_basemap_cache --levels 1..5 --grid mygrid --dest cache_data/test_cache --type mapproxy --coverage coverage/test_bugreport.geojson --where 'CNTRY_NAME = Germany' --srs 3857
mapproxy-util export -f test.yaml --source test_basemap_cache --levels 1..12 --grid mygrid --dest cache_data/test_cache --type mapproxy --coverage coverage/test_bugreport.geojson --where 'CNTRY_NAME = "Germany"' --srs 3857
mapproxy-util export -f test.yaml --source test_basemap_cache --levels 1..12 --grid mygrid --dest cache_data/test_cache --type mapproxy --coverage coverage/test_bugreport.geojson --where "CNTRY_NAME = Germany" --srs 3857
mapproxy-util export -f test.yaml --source test_basemap_cache --levels 1..12 --grid mygrid --dest cache_data/test_cache --type mapproxy --coverage coverage/test_bugreport.geojson --where ""CNTRY_NAME" = 'Germany'" --srs 3857
mapproxy-util export -f test.yaml --source test_basemap_cache --levels 1..12 --grid mygrid --dest cache_data/test_cache --type mapproxy --coverage coverage/test_bugreport.geojson --where "CNTRY_NAME = 'Germany'" --srs 3857
mapproxy-util export -f test.yaml --source test_basemap_cache --levels 1..12 --grid mygrid --dest cache_data/test_cache --type mapproxy --coverage coverage/test_bugreport.geojson --where 'CNTRY_NAME = 'Germany'' --srs 3857
mapproxy-util export -f test.yaml --source test_basemap_cache --levels 1..12 --grid mygrid --dest cache_data/test_cache --type mapproxy --coverage coverage/test_bugreport.geojson --where 'CNTRY_NAME = 'Germany'' --srs 3857

Context

Your Environment

Version used: Mapproxy 1.11.0
Environment name and version (e.g. Python 2.7.5 with mod_wsgi 4.5.9): Python 3.5.3
Operating System and version: Debian 9.4
*GDAL/OGR: 2.1.2 (Debian Package)

I was able to reproduce this, but I was also able to fix this by quoting strings with single-quotes.
I've updated the tests and examples in the documentation.


Publish artifacts

Publish Artifacts
This PR is a one-stop shop for publishing binaries and archives. Adoption is simple:

merge this PR
push a tag:

git tag -a -m "Publish build artifacts" v0.4.0
git push --tags

TL;DR
This PR adds popular tool GoReleaser and GitHub actions to automatically publish unwrapped binaries, .tar.gz archives, and checksums for MacOS and Linux to GitHub releases whenever a tag is pushed. Example output is visible in the fork's releases page.
Targets
I added targets for both plain binaries and archives. The plain binaries themselves clock in at ~2MB, so there's not much value to the compression of the archives, but the archives also send along the license and README. Checksums for everything are included.
Tech Choices
This PR adopts some very common and popular technology for this project.
GoReleaser
goreleaser is a very popular and extensible tool for automating release cycles. It is itself a CLI binary, but here we use its GitHub action (Docker container) to make the process as automated as possible. Currently, we define two targets -- vanilla binaries and tar.gzs of a directory containing the license, README, and binary.
Flexibility

Here we target GOOSs linux and darwin, but if Windows support were later added to reflex, goreleaser would support that as well.
goreleaser supports automating releases to package managers like brew and snap (with additional customization of course)

GitHub Actions
GitHub Actions is the most accessible CI/CD platform for a GitHub repository, as with this project.
GitHub Releases
Again, GitHub releases are the most accessible place to store your build artifacts when you've got a GitHub repository. Speaking as a GitHub user, I suspect it's the first place most people look for downloads.
Related issues:

https://github.com/cespare/reflex/issues/31
https://github.com/cespare/reflex/pull/69
https://github.com/cespare/reflex/pull/67

@cespare please let me know if there's anything I can do to help get this in place. Tried to make it as simple as possible, and this would be a real boon to my team and others, I'm sure. (and thanks for the great tool!)

ping @cespare :) Feel also free to add co-maintainers to help you offload some work. We did this for https://github.com/git-chglog/git-chglog as well.

I went a more minimal route in c98fd61ee5cf44a5988cc0394b600fd515474164.


Add pyproject.toml file

Motivation
Modernize packaging, continues https://github.com/DataDog/integrations-core/pull/11233
Additional Notes
The setup.py file will be removed when we drop Python 2 since new-style editable installations require versions of pip that are Python 3-only

Need to resolve conflicts, should rebase from master


Debug Backplane Updates

[ ] Add LED for fake radio module.

Duplicate issue. Closing in favor of #23.


[$500] - MEDIUM - Workspace switcher - WS switcher resets to Expensify when creating a room under the same WS

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.45-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to staging.new.expensify.com
Open workspace switcher
Select a workspace
Go to FAB > Start chat > Room
Create a room under the same workspace in Step 2

Expected Result:
The workspace switcher should be preserved when the room is created since it is under the same workspace
Actual Result:
The workspace switcher resets to Expensify
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/e488a90c-0963-444f-8a8f-7d611f06248b
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01432a2ba6b78d56dc
Upwork Job ID:<PHONE_NUMBER>802258432
Last Price Increase: 2024-03-11
Automatic offers:

DylanDylann | Contributor | 0

@bfitzexpensify  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
WS switcher resets to Expensify when creating a room under the same WS
What is the root cause of that problem?
We are not properly redirect the user here:
https://github.com/Expensify/App/blob/d482a25fc9e9f37990c27c1d5906227eb6204cf2/src/libs/actions/Report.ts#L1830
What changes do you think we should make in order to solve the problem?
Change
https://github.com/Expensify/App/blob/d482a25fc9e9f37990c27c1d5906227eb6204cf2/src/libs/actions/Report.ts#L1830
To
    Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(policyReport.reportID));

What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
MEDIUM - Workspace switcher - WS switcher resets to Expensify when creating a room under the same WS
What is the root cause of that problem?
The already working logic of redirecting it to the correct route is not working as report we have created optimistically is not ready and report is empty object here
https://github.com/Expensify/App/blob/22cb01c968a53407f7a9d864bfba30f41366f6a0/src/libs/Navigation/Navigation.ts#L60-L61
What changes do you think we should make in order to solve the problem?

To deal with this kind of situation for future too we should start accepting the report on dismissModal and we will pass the optimistically created report here
https://github.com/Expensify/App/blob/22cb01c968a53407f7a9d864bfba30f41366f6a0/src/libs/actions/Report.ts#L1845-L1846
We can do that either by converting the reportID parameter into reportOrID and checking inside the function that if it is string it the reportID and we will fetch the report as we are already doing now
We are already using this logic as in here for e.g.
https://github.com/Expensify/App/blob/22cb01c968a53407f7a9d864bfba30f41366f6a0/src/libs/ReportUtils.ts#L627-L628
What alternative solutions did you explore? (Optional)

Proposal Updated
add alternative proposal

Proposals ready for review when you get a moment @alitoshmatov - thank you!

Bump @alitoshmatov

Bumped in Slack

@FitseTLT Currently, we use
https://github.com/Expensify/App/blob/8461d2b19df509277f0a7cccf65c9d8dcfb768f7/src/libs/ReportUtils.ts#L535-L540
I don't see how your solution is different from what we are doing now
@wildan-m maybe using the navigate function will resolve this problem. But I am not sure other behavior of the navigate function will be the same as the dismissModal function

@gijoe0295

Use dismissModalWithReport here to make sure the report is not empty.

You mean that we will use optimistic report data, right?

@DylanDylann any feedback with my alternative proposal?

@DylanDylann What should be the expected behavior if a room is created from another active workspace or when no specific workspace is selected? Should it reset to the room's selected workspace or keep the active workspace selected by the workspace switcher?

@bfitzexpensify Could you help to verify the expected in this case

What should be the expected behavior if a room is created from another active workspace

I would expect this to go back to Expensify (as it does today)

or when no specific workspace is selected?

As in, it's just on Expensify? I would expect it stays on Expensify and doesn't switch
I think there's only the one specific case we're targeting here, which is when the room created matches the active workspace, in which case we shouldn't switch. In any mismatching scenario, we will go back to Expensify

@gijoe0295's proposal looks good to me.
We also do the same thing here
https://github.com/Expensify/App/blob/da7697734c1f759786eba0a643a062b4e39a47ad/src/libs/actions/IOU.ts#L2364
🎀 👀 🎀 C+ reviewed

Makes sense to me, let's move forward with @gijoe0295's proposal.

Proposal
Please re-state the problem that we are trying to solve in this issue.

WS switcher resets to Expensify when creating a room under the same WS

What is the root cause of that problem?

In here, we call dismissModal with report is empty, that leads to shouldOpenAllWorkspace in here return true

What changes do you think we should make in order to solve the problem?

We need to make sure the report in here is always fetched before calling originalDismissModalWithReport.
We can do it by creating a isReadyPromise in ReportUtils like the one below:

let waitingReportID: string = ''
let resolveIsReadyPromise: (args?: unknown[]) => void;
let isReadyPromise =(reportID: string)=> new Promise((resolve) => {
    waitingReportID = reportID
    resolveIsReadyPromise = resolve;
});

function checkRequiredData() {
    const targetReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${waitingReportID}`] ?? {};
    if(targetReport?.reportID){
        resolveIsReadyPromise();
    }

}
Onyx.connect({
    key: ONYXKEYS.COLLECTION.REPORT,
    waitForCollectionCallback: true,
    callback: (value) => {
        allReports = value
        checkRequiredData()
    },
});

Then update:
https://github.com/Expensify/App/blob/d482a25fc9e9f37990c27c1d5906227eb6204cf2/src/libs/Navigation/Navigation.ts#L60-L61
to:

    ReportUtils.isReadyPromise(reportID).then(()=>{
        const report = getReport(reportID);
        originalDismissModalWithReport({reportID, ...report}, ref);
    })

What alternative solutions did you explore? (Optional)

NA

Sorry for my late. But the dismissModal function is used in a lot of cases in our app so I think we should fix in all cases rather than special case. We you help check my proposal above @DylanDylann  @robertjchen

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal

Open workspace switcher
Select a workspace
Press FAB > Start chat > Room
Create a room under the same workspace in Step 2
Verify app does not switch to Expensify and navigates to the room

Do we agree 👍 or 👎

Payments complete, regression test proposed in https://github.com/Expensify/Expensify/issues/381542, we're all done here - thanks everyone!


[system-probe] Add static binary inspection to create lookup tables for crypto/tls.(*Conn).{Read,Write,Close}

What does this PR do?
This PR builds on the work done in #10039 to add another set of lookup tables that are generated ahead-of-time from a suite of Go versions/architectures-- this time, to contain information about the layout of structs and function arguments/return values that is useful to trace TLS traffic running through the standard library. Doing so requires knowledge about:

The position of arguments from each of crypto/tls.(*Conn).Read, crypto/tls.(*Conn).Write, andcrypto/tls.(*Conn).Close
The layout of structs needed to extract the socket file descriptor from a crypto/tls.(*Conn) value (there are a handful of around 5 pointer/struct embeds that each need to have offsets)

The rest of the information needed to attach probes is able to be determined at runtime, even if the debug/ELF symbols have been stripped from a binary (as opposed to the above two sets of data), so some of it was excluded from this PR (namely, static interface-table entries and runtime.g pointer location information), and is instead in #10161.
Motivation
Tracing Go HTTPS traffic using eBPF.

#10161

Additional Notes
I'm not sure whether the changes I made to generate_tools.go are appropriate.
Possible Drawbacks / Trade-offs
The lookup table generation for the binary-inspected data is only run on minor-version bumps (and the latest beta/RC version), so in the unlikely case that the language introduces changes on a revision-level version bump, those changes won't be detected by this implementation.
Describe how to test/QA your changes
Running inv -e system-probe.generate-lookup-tables should run the loookup table generation logic using go generate .... The output file will be at pkg/network/http/gotls/lookup/luts.go, and should be the same as the one currently in the PR.
Reviewer's Checklist

[x] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[x] The appropriate team/.. label has been applied, if known.
[x] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[x] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[x] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[x] If applicable, the need-change/operator and need-change/helm labels have been applied.
[x] If applicable, the config template has been updated.

opened a new PR after rebasing, closing this one.


CMSIS-NN: Incorrect flags for non-DSP/MVE processors (convolution op only)

@tensorflow/micro
System information

Host OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
TensorFlow installed from (source or binary): Source
Tensorflow version (commit SHA if source): 5a16264ba6f12883726d12d484d4cd61405ddab7
Target platform (e.g. Arm Mbed OS, Arduino Nano 33 etc.): Arm internal testing using models for Cortex-M3

Describe the problem
CalculateOpData() in cmsis-nn/conv.cc is inside a '#if defined(__ARM_FEATURE_DSP) || defined(__ARM_FEATURE_MVE)' flag which is not set for a Cortex-M3 or similar that do not have DSP or MVE extensions. This results in uninitialized quantization parameters being passed on to the convolution API in the Eval() procedure. This could result in an assert in debug builds or atleast an incorrect output from convolution.
Please provide the exact sequence of commands/steps when you ran into the problem
Just a visual code check.

We'll have a look at this issue.


UI issues under Benefits section, boxes are not equal sizes

Describe the bug
Small UI issue, under the Benefits section, the box for Personalized Reading Experience appears larger than the rest.
To Reproduce
Steps to reproduce the behavior:

Go home page
Click on 'Benefits'
Minimize screen width until Benefits section is 2 columns
See error

Expected behavior
All boxes would ideally be the same size for best UI/aesthetic
Screenshots

Desktop (please complete the following information):

Windows 11
Browser:chrome
Version 124.0.6367.119

I would like to be assigned this issue to contribute to GSSOC'24. I can fix this issue

Assigned!


NPE when moreChildren.getChildrenIds() returns no IDs

On CommentNode a NPE occurs when running loadFully, where isThreadContinuation() does moreChildren.getChildrenIds() when there are no IDs. This happens both on isThreadContinuation as well in getMoreComments in this snippet, if you fix the former:
    List<String> moreIds = moreChildren.getChildrenIds();
    StringBuilder ids = new StringBuilder(moreIds.get(0));

I can't tell what is going wrong API wise or if this is just a bug.
I tried to fix it in master, but I can't get the tests to run (gradlew test fails with a NPE on getScopes while I entered a credentials.json file, only not sure what to enter as url). I tried to add an extra expression checking if moreChildren.getChildrenIds().size() > 0.

Can you provide a stacktrace and the code being executed?