[BugFix] Followers could not update statistics immediately after the statistics rebuild

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #9840
Problem Summary(Required) ：

Checklist:

[x] I have added test cases for my bug fix or my new feature
[x] I have added user document for my new feature or new function

[FE PR Coverage Check]
:disappointed: fail : 12 / 34 (35.29%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/statistic/StatisticExecutor.java
0
1
00.00%
[287]

:large_blue_circle:
com/starrocks/statistic/StatisticsMetaManager.java
0
1
00.00%
[212]

:large_blue_circle:
com/starrocks/persist/EditLog.java
0
2
00.00%
[803, 816]

:large_blue_circle:
com/starrocks/statistic/AnalyzeManager.java
0
17
00.00%
[142, 143, 144, 146, 147, 148, 150, 151, 173, 174, 175, 177, 178, 179, 181, 182, 183]

:large_blue_circle:
com/starrocks/sql/ast/ShowBasicStatsMetaStmt.java
8
9
88.89%
[54]

:large_blue_circle:
com/starrocks/statistic/BasicStatsMeta.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/ShowAnalyzeStatusStmt.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/statistic/StatisticsCollectJobFactory.java
1
1
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 14 / 46 (30.43%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/statistic/StatisticExecutor.java
0
1
00.00%
[287]

:large_blue_circle:
com/starrocks/statistic/StatisticsMetaManager.java
0
1
00.00%
[212]

:large_blue_circle:
com/starrocks/persist/EditLog.java
0
2
00.00%
[803, 816]

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/CachedStatisticStorage.java
0
4
00.00%
[116, 117, 166, 167]

:large_blue_circle:
com/starrocks/statistic/AnalyzeManager.java
0
23
00.00%
[143, 144, 145, 147, 148, 149, 151, 152, 174, 175, 176, 178, 179, 180, 182, 183, 184, 300, 301, 302, 303, 304, 305]

:large_blue_circle:
com/starrocks/sql/ast/ShowBasicStatsMetaStmt.java
9
10
90.00%
[55]

:large_blue_circle:
com/starrocks/statistic/BasicStatsMeta.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/ShowAnalyzeStatusStmt.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/statistic/StatisticsCollectJobFactory.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/load/OlapDeleteJob.java
1
1
100.00%
[]

run starrocks_be_build

run starrocks_be_build

run starrocks_fe_unittest

Could you plz explain why we could not update statistics immediately after the statistics rebuild?

Could you plz explain why we could not update statistics immediately after the statistics rebuild?

specific reproduction conditions

Run the analyze statement on the follower, the command will be forwarded to the master
Collect statistical information on the master, and delete the local cache after the master collects successfully
The follower runs the query statement of the related table, because the local cache is not cleared, continue to use the local cache

run starrocks_fe_unittest

run starrocks_fe_unittest

run starrocks_fe_unittest

[FE PR Coverage Check]
:disappointed: fail : 14 / 45 (31.11%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/statistic/StatisticExecutor.java
0
1
00.00%
[287]

:large_blue_circle:
com/starrocks/statistic/StatisticsMetaManager.java
0
1
00.00%
[212]

:large_blue_circle:
com/starrocks/persist/EditLog.java
0
2
00.00%
[803, 816]

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/CachedStatisticStorage.java
0
3
00.00%
[116, 117, 166]

:large_blue_circle:
com/starrocks/statistic/AnalyzeManager.java
0
23
00.00%
[143, 144, 145, 147, 148, 149, 151, 152, 174, 175, 176, 178, 179, 180, 182, 183, 184, 300, 301, 302, 303, 304, 305]

:large_blue_circle:
com/starrocks/sql/ast/ShowBasicStatsMetaStmt.java
9
10
90.00%
[55]

:large_blue_circle:
com/starrocks/statistic/BasicStatsMeta.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/ShowAnalyzeStatusStmt.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/statistic/StatisticsCollectJobFactory.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/load/OlapDeleteJob.java
1
1
100.00%
[]

run starrocks_admit_test


Bulk Modify Assignments

As a bootcamp teacher, I need to be able to update assignments' descriptions and due dates in bulk. An email should go out to affected participants.
Terms:
Action Item: This is the description/title record. It does not have due dates and is not attached to any users.
Assignment: This is the record when an action item is attached to a user. It holds the due date. Due dates can be different for the same action item, if each user has their due dates set differently in their assignment.
View 1
/assignments/bulk-modify
Table of all created action items. These are unique action items created, they may or may not be "common", and they may have may have been assigned to multiple cohorts over time, if the same action item was assigned over many cohorts. They will originally be sorted by date modified, but you can also sort by name, date modified, category. You can also filter by category.

Action Item
Date Modified
Category

HW 2
10/12/20
Education

HW 1
10/10/20
Education

Create budget
10/9/20
Finances

Click a row, that will bring up a confirmation modal that says "do you want to modify this assignment?". Click no, go back to table. Click yes, it will go to view 2.
View 2
/assignments/bulk-modify/{action-item-id}
The assignment title and description will be at the top. the description can be collapsible.
There will be a table of all users that have been assigned the action item (all "assignments"). It will have all users that have ever been assigned the selected action item, sorted by Assigned Date. You can also sort by due date.

User
Assigned Date
Due Date
Completed

[ ]
User 1
10/12/20
10/15/20
yes

[ ]
User 2
10/12/20
10/15/20
no

[ ]
User 3
10/12/20
10/15/20
no

[ ]
User A
10/9/19
10/19/19
yes

[ ]
User B
10/9/19
10/19/19
yes

[ ]
User C
10/9/19
10/19/19
yes

Admin will select the users for which they want to modify this assignment, then click the Modify button. This will bring up either a modal or a page - view 3.
View 3
/assignments/bulk-modify/{action-item-id} - same component/view
Will have editable title / description box / due date. It will also confirm that this will change assignments for the users selected.
There will be some type of warning that changing the action item contents, ie title/description, will update for all assignments that use this action item, even if you didn't select that user. The users for which assignments were not changed will not be notified.
Click modify button - takes to either a completion screen or the dashboard. There is some confirmation that assignments were successfully edited (toast, etc)

On click of modify in view 3, three things happen:

The selected action item is updated with title/description
Due date update for every user's assignment
Emails sent to every user whose assignment was updated.


Update README to reflect changes

Describe the main changes. Update the code samples and namespaces.

Done.


vulnerable interceptor

Coverage decreased (-2.3%) to 52.494% when pulling a5ba107637b31839cc5e1d19ba5037899f238539 on wy65701436:vul-interceptor into 551e0fe9c10586e0e6a25924f53090702b944b9d on vmware:master.

Coverage decreased (-7.5%) to 47.245% when pulling f4b7cff14b97841fcd820163847c21a08398a8e7 on wy65701436:vul-interceptor into 551e0fe9c10586e0e6a25924f53090702b944b9d on vmware:master.

Coverage decreased (-3.0%) to 51.774% when pulling d6d00261f3cbe5f6418e2294d73d83d6debd385d on wy65701436:vul-interceptor into 551e0fe9c10586e0e6a25924f53090702b944b9d on vmware:master.

Coverage decreased (-3.0%) to 51.774% when pulling 64138b6bdb4d066934364e7efbcbc67c706d9466 on wy65701436:vul-interceptor into 551e0fe9c10586e0e6a25924f53090702b944b9d on vmware:master.

Coverage decreased (-2.06%) to 51.541% when pulling<PHONE_NUMBER>7f565e6ada346703cf5d4245b4a1b0 on wy65701436:vul-interceptor into 73c44723f5b1a08da50c111caee1a010869e2ae5 on vmware:master.

Coverage increased (+0.01%) to 53.618% when pulling b2b66ee81b3ccc005b534f6aeca49807c2b566ec on wy65701436:vul-interceptor into a64926231d075918b07a703ee1cacc6eebd56b12 on vmware:master.

Coverage increased (+0.007%) to 53.224% when pulling c6a8e4076b657d62d49a64af1c4b250f656e058f on wy65701436:vul-interceptor into b79b80c6ee9e96b040be3088d99507791e8eb8be on vmware:master.


Add instructions for alternative long-lived Heroku API key

Add a note pointing out how to get a long-lived authorisation token, instead of a token that will expire in one year.
Fix #22

Thanks!


APEXMALHAR-2422 During recovery don't relay on the size returned by the API

…t to work.
@otterc , @tushargosavi please review.

@PramodSSImmaneni @tweise please review. Changed the unit test to be compatible with the Hadoop filesystem API as well. Allows to run the unit test on HDFS in future.

Can you summarize on the JIRA what testing was done?

I have listed the tests done to verify this fix on the jira.

@sandeshh can you run a quick rebase, I will merge it then.

@tweise rebase done.


fix: ng g application with yarn 1

Proposed change
Today, with yarn 1
yarn create @o3r my-workspace
cd my-workspace
yarn ng g application my-app

we get:
✔ Packages installed successfully.
error Running this command will add the dependency to the workspace root rather than the workspace itself, which might not be what you want - if you really meant it, make it explicit by running this command again with the -W flag (or --ignore-workspace-root-check).
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
✖ Package install failed, see above.
The Schematic workflow failed. See above.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

missing a pipeline based on yarn 1 to test the content of this :S.

missing a pipeline based on yarn 1 to test the content of this :S.

We are far from having a working CI for end-to-end test with yarn 1. That is the goal of https://github.com/AmadeusITGroup/otter/pull/1230
The goal of this PR is to allow users at least to be able to generate a first application within a monorepo while using yarn 1.


RevEng: Sqlite: Indexes for PK are scaffolded wrongly

For SQLite, we are scaffolding indexes which are defined on PK properties. If there is no unique keyword in index then we scaffold unique=false for index. According to #700 , key's uniqueness will be based on the underlying index object. This causes bug if the PK is used as FK for relationship. Effectively making FK non-unique even though its unique.

Created a task to look at the all-up design around indexes (and listed this as an item that needs attention).

Included fix in #3714


feat: add isRestart for environment

Description
The upside of this approach is that we can do the same thing for configureServer hook.

See https://github.com/vitejs/vite/issues/18264#issuecomment-2399092729


Add Dashboard/Usage API

Feature Request
Is your feature request related to a problem? Please describe.

OpenAI Dashboard uses the same endpoint that prompting and can be easily used to display all information about current usage and billing. This API seems to not be documented Eg:
https://api.openai.com/dashboard/billing/usage?end_date=2023-05-01&start_date=2023-04-01

/dashboard requires different authentication
/v1 but undocumented method work with API keys
Describe the solution you'd like

Information about billing and other dashboard information could be fetched using the same package
Describe alternatives you've considered

PR or writing extending the OpenAI-DotNet functionality to reuse auth keys
Additional context

Other endpoints that could prove useful
https://api.openai.com/v1/usage?date=2023-04-07
https://api.openai.com/v1/organizations/org-XXX/users

https://api.openai.com/dashboard/billing/usage?end_date=2023-05-01&start_date=2023-04-01
https://api.openai.com/dashboard/billing/credit_grants
https://api.openai.com/dashboard/billing/subscription
https://api.openai.com/dashboard/organizations/org-XXX/features
https://api.openai.com/dashboard/user/api_keys

Is this endpoint undocumented?

See: https://community.openai.com/t/how-to-track-individual-usage/15935/16

I believe /dashboard is only if you're logged into the website with their OAuth provider.

I'm going to close this as I would only like to support officially recognized endpoints.


Fix the README path to 00_QuickStart.ipynb notebook.

There was a CI issue - but I'm going to override and merge this since it's not a code change


Fix: Wrapped Aliased Type Resolution

This fixes https://github.com/GraphQLSwift/Graphiti/issues/41
This added a collection of all SwiftTypes and their aliased GraphQL names to TypeProvider. These names are collected before any GraphQL types are created, and are used when resolving TypeReferences, so out-of-order references to aliased types are no longer mis-addressed.
To do so, we had to add a setGraphQLName function to the Component class, and implementations for all GraphQL Type components (Enum, Input, Interface, Scalar, Schema, Type, and Union). Schema construction now goes through all components to collect names prior to building up the GraphQL schema objects.

Hey @paulofaria, you mind giving this one a quick review?

Got this error message when trying to merge.

@paulofaria Woah, weird. It let me merge it fine...


Yaw Airspeed Scaler Different from Pitch and Roll

According to this controller document, all three of the attitude controllers should apply quadratic IAS scaling to the P gain, and linear TAS scaling to the FF gain.
This is reflected in both ecl_roll_controller.cpp and ecl_pitch_controller.cpp:
/* Apply PI rate controller and store non-limited output */
        _last_output = _bodyrate_setpoint * _k_ff * ctl_data.scaler +
_rate_error * _k_p * ctl_data.scaler * ctl_data.scaler
+ _integrator; //scaler is proportional to 1/airspeed

But not in ecl_yaw_controller.cpp:
        /* Apply PI rate controller and store non-limited output */
        _last_output = (_bodyrate_setpoint * _k_ff + _rate_error * _k_p + _integrator) * ctl_data.scaler *
ctl_data.scaler; //scaler is proportional to 1/airspeed

Is this a bug?

@supergra Yes, it is a mistake, I remember fixing that about a year ago on a private fork but I forgot to upstream the fix :|
And the second mistake is that we scale both feedforward and the controller with IAS (ctl_data.scaler = 1/IAS). That is tracked in https://github.com/PX4/Firmware/issues/11975 but I'm waiting for the new "airspeed module" to make the change.

@bresch Is there any obstacle to upstreaming your fix for the first bug (the yaw being different)? We were considering making the change locally, but I'm curious if you are holding off because it might introduce unexpected behavior.
The second bug is likely a minor impact for most low altitude work we do, so not as concerned about that one.

Thanks @bresch, I will make a pull request. Suggest transferring this issue to Firmware, since fw_att_control was moved there. (I don't think I can do that myself.)

@supergra thanks a lot! I'll move the issue and review your PR asap.


"Output Coordinate System: Value is required" error

Current Behavior
When you try run the following tools, this error is given after you click OK, before the tool even tries to run, so something is causing this in validation.

[ ] Find Local Peaks
[ ] Highest Points
[ ] Lowest Points

Possible Solution
Not sure exactly which tool in the model is causing this, so I do not have a good suggestion to fix this, however if it helps at all, if you go to the Environment Settings in the tool diaglog and set the Output Coordinate System to use the same as you elevation layer, it no longer does this. In this case I am using the packaged sample data, so the elevation layer I am using is "ElevationUTM_Zone10" - WGS_1984_UTM_Zone_10N

not sure if this is happening in Pro as well, i'm currently testing the Desktop toolset

update... not seeing this in Pro 1.2 or 1.3

did not observer this in desktop 10.3.1, will continue to update this comment and wait to close until  all certification testing has been done


yarn test:unit failing on windows when all packages included

I can run the tests successfully when the packages are limited to 'packages/material-ui/**/*.test.js' 'packages/material-ui-utils/**/*.test.js' 'packages/material-ui-styles/**/*.test.js', but when using 'packages/**/*.test.js' 'docs/**/*.test.js' as currently specified in package.json I get the following output:
 ..........!!!!!.....!.

at which point it hangs forever (or at least way beyond my patience threshold) while continuing to use significant CPU and memory resources. I'm assuming that this behavior is not seen by the Material-UI team members and I suspect that none of you do the bulk of your work on Windows, so my guess is that it's some problem with the tests in non-core packages on Windows.

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

Should be able to run full set of unit tests successfully.
Current Behavior 😯

Several tests error and then it hangs indefinitely after output of ..........!!!!!.....!.
Steps to Reproduce 🕹

I've reproduced this on two different Windows machines (one Windows 7 the other Windows 10). In both cases I'm using git bash shell (MINGW64 -- bash shell installed as part of Windows Git installation) for executing yarn scripts. I used yarn 1.13.0 on Windows 10 and yarn 1.12.0 on the Windows 7 machine. Both behaved the same and both can successfully execute the tests in the core packages listed at the top (the packages that the test:coverage task was limited to until recently).
Context 🔦

I can continue my work just executing the more limited set of packages, but I would like to determine if this is specific to Windows or some other environment configuration that I could more easily change; and for my own sanity it would be nice to know if someone else can replicate what I'm seeing.
Your Environment 🌎

Tech
Version

Material-UI
next

OS
Windows 7 or 10

yarn
1.12 or 1.13

Could you run it with --bail or find out otherwise what tests are failing?

Ahh another windows buddy! Yeah, I’ve had this intermittently but it disappears before I get to debug it.

Here's the first failure:
  1) @material-ui/codemod
       v0.15.0
         import-path
           convert path as needed:

      The transformed version should be correct
      + expected - actual

      -import FlatButton from 'material-ui/src/FlatButton';
      -import RaisedButton from 'material-ui/RaisedButton';
      -import SvgIcon from 'material-ui/SvgIcon';
      -import Colors from 'material-ui/styles/colors';
      +import FlatButton from 'material-ui/src/FlatButton';
      +import RaisedButton from 'material-ui/RaisedButton';
      +import SvgIcon from 'material-ui/SvgIcon';
      +import Colors from 'material-ui/styles/colors';
       import NavigationExpandMoreIcon from 'material-ui/svg-icons/navigation/expand-more';

      at Context.strictEqual (packages\material-ui-codemod\src\v0.15.0/import-path.test.js:26:16)

I just added the following to the test:
        for (var i = 0; i < expected.length; i++)
        {
            if (expected[i] !== actual[i]) {
              console.log("first difference", i, expected.charCodeAt(i), actual.charCodeAt(i));
              break;
            }
        }

Unsurprisingly, the output was first difference 52 10 13. So there are carriage returns in actual, but not in expected.
@joshwooding currently I have Git configured to NOT transform line feeds at all (core.autocrlf=input), so it is leaving everything as LF. Do you have yours set to "true"?

If I switch autocrlf from input to true (and then delete the contents of my working directory and recreate it via git reset --hard). I get some different failures: !!..................!. but it still hangs at the same point. The first failure in this case is
  !

  0 passing (1s)
  1 failing

  1) unwrapCreateStylesPlugin fixtures
       static:

      AssertionError [ERR_ASSERTION]: actual output does not match output.js
      + expected - actual

      -import { withStyles } from '@material-ui/core/styles';
      +import { withStyles } from '@material-ui/core/styles';
       const styles = {};

      at Context.<anonymous> (node_modules\babel-plugin-tester\dist\index.js:282:24)

I have autocrlf set to true

Thanks @joshwooding. That's helpful to know. I'll switch mine to true even though that doesn't seem to be sufficient -- presumably there is some other important difference between our environments. Please let me know once you've updated your next branch and successfully run yarn test:unit. I can eventually troubleshoot further, but I first want to know that I'm starting with something that has worked for another Windows user before I look into other settings that may be important.

@ryancogswell I've just rebased off of the latest next branch and I'm getting the same issue 😅

Related Issue over at babel-plugin-tester https://github.com/babel-utils/babel-plugin-tester/issues/22

@joshwooding Well, selfishly, I'm really glad that you're also seeing the issue and it isn't some oddity with my environment.
I've tried going back to earlier versions. In some earlier versions, the first two errors go away, but it still hangs at the same point and I still get the error two tests before the one that hangs. yarn test:unit works fine for me for v3.5.0 and earlier but then it is limited to the material-ui package (somewhere between 3.5 and 3.6 it was changed to do all packages).

I remember that I suggested

*.js text eol=lf

as well a while back. Plenty of code relies on the line feed type. It shouldn't cause any issues since most editors recognize the linefeed automatically.
Could you create PR with this change so what windows users can create a separate copy that only clones that branch? Hopefully these errors disappear with that change.

@eps1lon Are you suggesting *.js text eol=lf as a Git configuration or somewhere else? If you're just referring to a Git change, I don't think this will do the trick. I initially had my Git configured with autocrlf=input which leaves all the linefeeds as-is (no carriage returns). I believe the errors in that case are caused by some of the JavaScript libraries honoring the system line separator when creating the "actual" results (so including carriage returns on Windows), but then comparing that to "expected" results read from the file system that just have linefeeds.

I meant in our .gitattributes. But we can't do that since react-docgen uses the linefeed from the OS, right. Might be that other tools use \n by default. I guess we can't make it right and need to wait for fixes in those external dependencies?


PWA (Progressive Web App) with WorkBox Support

I'm looking for guidance on this more than trying to report a bug or request a feature. We've built a PWA that uses WorkBox which handles the offline support.
import React from 'react';
// import { SafeAreaView, StyleSheet } from 'react-native';
import WebView from 'react-native-webview';

const App = () => (
    <WebView
        source={{ uri: 'http://localhost:5000' }}
        contentInsetAdjustmentBehavior='automatic'
    />
);

export default App;

When using the code above if my localhost:5000 is running, we are golden. When the local servers is ended; on Chrome browser the site works with its offline support but ReactNative application produces an error (see below).

Are there any polyfills that could help with this, is this mainly a limitation to the WebView. It seems cache is supported by default, what is the expectation?
The main goal is to leverage our PWA and get it on the APP store we do want to introduce some push notifications for iOS as well.

@magbicaleman I'm also interested in this functionality, it would be awesome if you could update here if you figure out how to implement this.

@timothyfbowen as of right now we decided not to put any effort into solving this. If we do I'll add to this issue.

@timothyfbowen we got published on the app store with just a Webview, using this webview.

Is it possible to open the application from an offline state (ie Flight mode on) with this approach? In iOS when I try to re-open my application after a "hard close" seems the webview is not loading all static resources

@sgimeno if I'm not mistaken, I think this is a limitation on the iOS's webview component, in which it does not offer service worker support.
http://openradar.appspot.com/51092505
In iOS 13, it seems like they added service worker support, but I have not experimented with this myself, I don't know if this component needs to be updated, or if it's just out of the box with iOS 13.
https://love2dev.com/blog/apple-ships-service-workers/

Has anyone testet if in iOS 13 Service Worker and react-native-webview are compatible?

As far as I can tell, it's not compatible.
This fairly old stackoverflow answer says "Service Workers in WKWebView now require an entitlement: com.apple.developer.WebKit.ServiceWorkers" which apple doesn't appear to offer.
And the even older  webkit blog post has this clarification:

Update: A previous version of this post stated the Service Worker API is available in all applications using WKWebView. At this time it is only available in Safari, applications that use SFSafariViewController, and web applications saved to your home screen.

And a quick test with this page fails:

<WebView
  style={{
    flex: 1,
    width: deviceWidth,
    height: deviceHeight
  }}
  source={{
    uri:
      "https://jakearchibald.github.io/isserviceworkerready/demos/navigator.serviceWorker/"
  }}
/>

Am I missing something? Anyone have any ideas? Or even more recent confirmation about the entitlement thing?

I believe it would be helpful to keep this issue open as as far as I know
it hasn't been resolved yet.  I believe this is an Apple SDK issue or I
would try to submit a PR to fix it.
On Fri, Feb 28, 2020 at 7:09 PM github-actions[bot] <
<EMAIL_ADDRESS>wrote:

Hello 👋, this issue has been opened for more than 2 months with no
activity on it. If the issue is still here, please keep in mind that we
need community support and help to fix it! Just comment something like still
searching for solutions and if you found one, please open a pull
request! You have 7 days until this gets closed automatically
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/react-native-community/react-native-webview/issues/869?email_source=notifications&email_token=AADC5R57GSDEQ6WGV2ZOFM3RFBI4NA5CNFSM4IXFA6R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENKTHSA#issuecomment-592786376,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADC5R5P5VDCZJIJQDZL43DRFBI4NANCNFSM4IXFA6RQ
.

👎

Offline Support is Critical
PWA platform investments are accelerating faster than any other development methodology and relying upon Service Workers is unviable for native backward compatibility. Mobile OS penetration rates w/o Service Workers are still too high for a number of years to come.
What about downloading a zip of PWA and serving it natively (localhost) on the device as a fallback? I recall doing something like this long ago with Cordova.
Would there be a way to provide a "bridge" directly into WebView that wouldn't require a localhost server?
Ideas welcome.

@n8sabes Thanks
This hack didn't even occur to me. Very clever ❤
Combined with https://github.com/futurepress/react-native-static-server
This might actually work

@olso Were you able to get this working? How did you download the PWA to storage?

Hello
Does anybody have any news about the offline mode?

Maybe, it'll be helpful.
So, on iOS 14+, wkwebiew has service workers and cache API
To support Android and iOS, you need:

your website should be https
setup the cache and limitsNavigationsToAppBoundDomains props:
<WebView
....
cacheEnabled={true}
cacheMode={isInternetReachable ? 'LOAD_DEFAULT' : 'LOAD_CACHE_ONLY'}
limitsNavigationsToAppBoundDomains={true}
...
/>
in Xcode, Info.plist file, add:
WKAppBoundDomains

your-website.com

Implement the service worker, caching logic, etc.
Test on Android and iOS
Enjoy :)

Maybe, it'll be helpful. So, on iOS 14+, wkwebiew has service workers and cache API To support Android and iOS, you need:

your website should be https
setup the cache and limitsNavigationsToAppBoundDomains props:
<WebView .... cacheEnabled={true} cacheMode={isInternetReachable ? 'LOAD_DEFAULT' : 'LOAD_CACHE_ONLY'} limitsNavigationsToAppBoundDomains={true} ... />
in Xcode, Info.plist file, add:
<key>WKAppBoundDomains</key> <array> <string>your-website.com</string> </array>
Implement the service worker, caching logic, etc.
Test on Android and iOS
Enjoy :)

The above works great except.... now JavaScript injection are blocked.
Any idea how to get JavaScript injection working again after updating the info.plist?
https://github.com/ionic-team/capacitor/issues/4721#issuecomment-873183407
"Adding WKAppBoundDomains key blocks JavaScript injection and other WKWebView features unless limitsNavigationsToAppBoundDomains is set to true (which is not possible at the moment, will be after the linked PR gets merged).
Without the JavaScript injection, native plugins don't work and the web version is used instead.
More information about App Bound Domains and how they affect the WKWebView can be found here"

@kitolog, @tholmgren how to implement the service worker, caching logic, etc. Can you provide an example code? Thanks


stm32h5xx_ll_i3c.c doesn't compile when both USE_HAL_DRIVER and USE_FULL_LL_DRIVER are defined

Describe the set-up

The board: Nucleo-H503RB
Compiler: arm-gnu-toolchain-13.3.rel1-x86_64-arm-none-eabi

Describe the bug (skip if none)
When both USE_HAL_DRIVER and USE_FULL_LL_DRIVER are defined, stm32h5xx_ll_i3c.c doesn't compile.
The produced error is as follows:
In file included from Inc/stm32h5xx_hal_conf.h:344,
from Inc/stm32h5xx_hal.h:29,
from Device/ST/STM32H5xx/Include/stm32h5xx.h:230,
from Inc/stm32h5xx_ll_i3c.h:28,
from Src/stm32h5xx_ll_i3c.c:27:
Inc/stm32h5xx_hal_i3c.h:50:3: error: unknown type name 'LL_I3C_CtrlBusConfTypeDef'
50 |   LL_I3C_CtrlBusConfTypeDef CtrlBusCharacteristic; /!< Specifies the I3C controller bus characteristic configuration
|   ^~~~~~~~~~~~~~~~~~~~~~~~~
Inc/stm32h5xx_hal_i3c.h:53:3: error: unknown type name 'LL_I3C_TgtBusConfTypeDef'
53 |   LL_I3C_TgtBusConfTypeDef  TgtBusCharacteristic;  /!< Specifies the I3C target bus characteristic configuration
|   ^~~~~~~~~~~~~~~~~~~~~~~~
Inc/stm32h5xx_hal_i3c.h:1137:62: error: unknown type name 'LL_I3C_CtrlBusConfTypeDef'
1137 |                                                        const LL_I3C_CtrlBusConfTypeDef *pConfig);
|                                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
Inc/stm32h5xx_hal_i3c.h:1139:61: error: unknown type name 'LL_I3C_TgtBusConfTypeDef'
1139 |                                                       const LL_I3C_TgtBusConfTypeDef *pConfig);
|                                                             ^~~~~~~~~~~~~~~~~~~~~~~~
How to reproduce the bug
Here's the full compilation command I use for your convenience:
~/arm-gnu-toolchain-13.3.rel1-x86_64-arm-none-eabi/bin/arm-none-eabi-gcc Src/stm32h5xx_ll_i3c.c -o object.o --specs=nosys.specs -std=c17 -mcpu=cortex-m33 -isystem Inc -isystem Inc/Legacy -isystem Include -isystem Device/ST/STM32H5xx/Include -DUSE_FULL_LL_DRIVER -DSTM32H503xx
I implemented stubs for system calls, and added to the include path, in addition to the HAL, the include folders of CMSIS-Core and of the STM32H5xx device.
In addition, I defined USE_HAL_DRIVER in stm32h5xx.h.
Additional context
After some investigation, it looks to be a problem with recursive includes.
stm32h5xx_ll_i3c.c ->(includes) stm32h5xx_ll_i3c.h -> stm32h5xx.h -> stm32h5xx_hal.h -> stm32h5xx_hal_conf.h -> stm32h5xx_hal_i3c.h -> stm32h5xx_ll_i3c.h.
The nested stm32h5xx_ll_i3c.h include is then guarded from being included a second time, while the earlier included stm32h5xx_ll_i3c.h has included stm32h5xx.h before defining the needed  types. Therefore, the including stm32h5xx_hal_i3c.h has unknown type names.

Hi @Aric5301,
Thank you for this report. Issue confirmed. We'll dig deeper into it and get back to you as soon as we get a better insight .
With regards,

Hi @Aric5301,
I hope you are fine. Looks like there is a misuse of the I3C drivers. For a particular peripheral, I3C in our case, whether we use the LL driver or the HAL, but not both at the same time.
In your case, I have understood that you are using the LL I3C driver. Hence, in your stm32h5xx_hal_conf.h, the line below should be commented.
https://github.com/STMicroelectronics/stm32h5xx_hal_driver/blob/7e8c7d8e91c15321864f513f8458ce7f6555eb4e/Inc/stm32h5xx_hal_conf_template.h#L60
I hope this makes things clearer. Please allow me to close this issue.
With regards,

Hey @ALABSTM, thanks for the reply!
I would like to raise another point. It's not the first STM32 HAL that I'm working with, and for previous HALs I've always used either LL or HAL for each peripheral, but never have I had a problem of compiling what I don't use. I've always compiled the entire library.
To my understanding, that what you are telling here is that if I would like to use the HAL I3C driver I can't compile the LL file.
This is of course acceptable, but it's the first time that I encounter something like that.
Perhaps it should explicitly say somewhere in the manual that for each peripheral that I use, I should either compile the LL and disable the peripheral in ..._hal_conf.h file (and not compile the HAL file?), or enable the HAL, compile it, and not compile the LL. As, again, this unable-to-even-compile behavior is different from what I've encountered up until today.
Thank you!


DEBUG: Starting new HTTPS connection (1): xxxx%0a%0aport%20=%2080%0a%0adisable_tls%20=%20false%0a%0avalidate_tls_certs%20=%20false:443

Hi,
It is not clear to me why the netbox is being accessed with https .. Please suggest
I am running on Ubuntu 18 & (v2.9.3)
./netbox-sync.py -n -l DEBUG3
2020-11-22 00:29:33,378 - INFO: Starting NetBox Sync
2020-11-22 00:29:33,379 - DEBUG: Using config file: /opt/netbox-sync/settings.ini
2020-11-22 00:29:33,379 - DEBUG: Config: netbox.api_token = JDA***
2020-11-22 00:29:33,379 - DEBUG: Config: netbox.host_fqdn = xxxx

port = 80

disable_tls = false

validate_tls_certs = false
2020-11-22 00:29:33,379 - DEBUG: Config: netbox.port = None
2020-11-22 00:29:33,379 - DEBUG: Config: netbox.disable_tls = False
2020-11-22 00:29:33,379 - DEBUG: Config: netbox.validate_tls_certs = True
2020-11-22 00:29:33,379 - DEBUG: Config: netbox.prune_enabled = False
2020-11-22 00:29:33,379 - DEBUG: Config: netbox.prune_delay_in_days = 30
2020-11-22 00:29:33,379 - DEBUG: Config: netbox.default_netbox_result_limit = 200
2020-11-22 00:29:33,379 - DEBUG: Config: netbox.timeout = 30
2020-11-22 00:29:33,379 - DEBUG: Config: netbox.max_retry_attempts = 4
2020-11-22 00:29:33,379 - DEBUG: Config: netbox.use_caching = True
2020-11-22 00:29:33,379 - WARNING: Log level is set to DEBUG3, Request logs will only be printed to console
2020-11-22 00:29:33,379 - DEBUG: Created new requests Session for NetBox.
2020-11-22 00:29:33,381 - DEBUG: Starting new HTTPS connection (1): xxxx%0a%0aport%20=%2080%0a%0adisable_tls%20=%20false%0a%0avalidate_tls_certs%20=%20false:443
encoding with 'idna' codec failed (UnicodeError: label too long)

BTW i get same error with
port = 80
disable_tls = true
validate_tls_certs = false

Hi,
The issue are the line endings in your config file. Have a look and make sure they are unix line endings \n. This mostly happens if you use a file transfer client to copy the file.

e a file transfer client to copy the file.

I did not do xfr
Let me double check if any hidden extra char, i used vi ..

i issue was spaces .. removed
now in dry more i see
2020-11-22 00:49:05,437 - DEBUG: Starting new HTTPS connection (1): xxx:80
Still says HTTPS.. not sure if that issue
the line next to that says
HTTPSConnectionPool(host='xxx', port=80): Max retries exceeded with url: /api/ (Caused by SSLError(SSLError(1, '[SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:852)'),))

ok finally i changed , disable_tls  & worked
Thanks  @bb-Ricardo

I wonder. Someone else had the same issue.
You edited the file with vi and changed the values and saved it?
It could be that the example file hase the wrong line endings.

Eg
Define the port your NetBox instance is listening on. If "disable_tls" is
set to "true" this option might be set to 80
port = 443
port = 80
Weather TLS encryption is enabled or disabled.
#disable_tls = false
disable_tls = true
Enforces TLS certificate validation. If this system doesn't trust the NetBox
web server certificate then this option needs to be changed
validate_tls_certs = false
#######################################
If above u save as
validate_tls_certs = false
( above has space to start with )
Vs
validate_tls_certs = false
#######################################
So that extra space created issue
It was not issue with vi editor, it did not liked space

Expect more from me here :) ... as i plan to explore the tool more , thanks @bb-Ricardo

BTW your doc Please add section like , what vcenter-netbox-sync had , unless there is not a reason  ?
#######################################
Cron Job
The following job runs every 4 hours at minute 15. The full paths to python and the script are provided so that the virtual environment instance and packages are used.
vCenter to NetBox Sync
15 */4 * * * /opt/vcenter-netbox-sync/bin/python /opt/vcenter-netbox-sync/run.py >/dev/null 2>&1

Hi,
fixed/changed the config file issue
Will also add the info about the cron job.


metaphone and min_prefix_len

Hi,
why doesn't work morphology = metaphone together with min_prefix_len?
In my case I want to match falanges to phalanges but also phalange. There must be a solution for this.
Thanks!!

Closing this for the same reason as #886 - but as always, keen to hear of any solutions :)


vladikoff-archon-xxxxxx disapears when I reload

When I "load unpacked extension..." in Version 39.0.2163.3 of canary it works fine, but as soon as I reload it disappears.

Mac OS X 10.9.3

what is the solution? i have same issue


[BUG] Latex suite causes the canvas cards to be misty on source view mode.

Description
It seems that Latex Suite will cause the canvas card’s content to be misty on source view mode.
In past versions, it only happened in selecting condition, but now it has become worse
I have tried to restart the software, open safe-mode and close it, and close all other plugins.
To Reproduce
https://github.com/artisticat1/obsidian-latex-suite/assets/73453314/54d97c77-5aa3-49b0-ae2b-533a88a70e86
https://github.com/artisticat1/obsidian-latex-suite/assets/73453314/7a4374e5-3f56-4a53-944e-b89f15773707
typing in canvas's card, it will reappear

Window 10
Obsidian v1.4.12

I'm having this same issue. It's quite weird.
https://github.com/artisticat1/obsidian-latex-suite/assets/68677082/375dca78-82b1-4397-99e2-add713e8f738

I can't reproduce this. Does the issue occur if you disable all features in the plugin settings?

I can't reproduce this. Does the issue occur if you disable all features in the plugin settings?

Well, it seems doesn't happen in MacOS, only happens on WindowsOS. I have tried to disable all features in the plugin settings. but it doesn't change anything.

I have been encountering a peculiar blurring issue with the Latex Suite plugin on Obsidian, specifically affecting the canvas cards. The blurring manifests whenever a card contains either a Latex equation or a list with more than two items. I have documented this issue through several screenshots.
Here are the detailed observations and circumstances under which the blurring occurs:

Latex Equations and List Items:

The blurring is triggered when a card has a Latex equation or a list with more than two items.
Notably, if the first item of a list is selected and being edited, the blurring does not occur. However, from the second item onwards, the blurring is present.

Editing and Viewing Modes:

The blurring is present in both editing mode (under the aforementioned circumstances) and viewing mode (if the card contains a Latex equation or a list).

Settings and Restart Attempts:

I tried to resolve the issue by toggling various settings on and off, including disabling and re-enabling the extension, coupled with restarting Obsidian. Unfortunately, these actions did not ameliorate the blurring issue.

I have captured screenshots illustrating the blurring issue, which can be provided for further analysis.

all LatexSuite settings disabled   still blurry

blurry editing equation

blurry editing list

clear - extension disabled

Unselected Card and blurry

I find a way to solve this problem.

Open ".obsidian\plugins\obsidian-latex-suite"
find "styles.css"
comment out .snippets-editor-wrapper .cm-editor, .cm-scroller { border-radius: 4px; }   to /* .snippets-editor-wrapper .cm-editor, .cm-scroller { border-radius: 4px; } */

It works in
obsidian v1.3.7 , Latex suite 1.74/1.8.8

Open ".obsidian\plugins\obsidian-latex-suite"
find "styles.css"
comment out .snippets-editor-wrapper .cm-editor, .cm-scroller { border-radius: 4px; }   to /* .snippets-editor-wrapper .cm-editor, .cm-scroller { border-radius: 4px; } */

Can confirm this works! Happy days!

I find a way to solve this problem.

Open ".obsidian\plugins\obsidian-latex-suite"
find "styles.css"
comment out .snippets-editor-wrapper .cm-editor, .cm-scroller { border-radius: 4px; }   to /* .snippets-editor-wrapper .cm-editor, .cm-scroller { border-radius: 4px; } */

It works in obsidian v1.3.7 , Latex suite 1.74/1.8.8

Thank you for the fix! I've included it in 1.8.9.


Bug: (sort-imports) If there are comments above the import statement, automatic fixing will disrupt the layout.

Describe the bug
If there are comments above the import statement, automatic fixing will disrupt the layout.
Code example
eslint.config.js:
import ESlintPluginPerfectionist from 'eslint-plugin-perfectionist'

export default [
  {
    files: ['**/*.js', '**/*.cjs', '**/*.mjs', '**/*.jsx'],
    ignores: ['**/*.min.*', '**/dist/**', '**/build/**', '**/node_modules/**', '**/.*/**'],
    languageOptions: {
      parserOptions: {
        ecmaFeatures: {
          jsx: true
        },
        ecmaVersion: 'latest',
        sourceType: 'module'
      }
    },
    plugins: {
      'perfectionist': ESlintPluginPerfectionist
    },
    rules: {
      ...ESlintPluginPerfectionist.configs['recommended-natural'].rules
    },
  }
]

index.js:
// test
// test
import b from 'b.js'
import a from 'a.js'

result:
// test
import a from 'a.js'
// test
import b from 'b.js'

expected result:
// test
// test
import a from 'a.js'
import b from 'b.js'

ESLint version
v8.45.0
ESLint Plugin Perfectionist version
v1.5.1
Additional comments
No response
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

This is done intentionally so that comments on the code are preserved.
Input:
// my module b
import b from 'b.js'
// my module a
import a from 'a.js'

Output:
// my module a
import a from 'a.js'
// my module b
import b from 'b.js'

Do you have any idea how I can figure out if this is an import comment or a comment that doesn't apply to it?

@azat-io Thank you for your explanation. It seems there isn't a definitive way to distinguish them, although it can be done by using single-line comments or multi-line comments. However, everyone has different writing habits.


Opusfile as array

Hi Zuzu-Typ,
This contribution adds a method as_array() to OpusFile.  It converts the buffer into a NumPy array (without copying the data).  NumPy is only imported if the method is called, and so NumPy remains optional for the rest of PyOgg.  OpusFile.as_array() would have been helpful for issue #19.
Cheers,
Matthew

Thanks for your contribution (:


Nitro should edit the machine’s hosts file too

Currently it’s not possible to send HTTP requests to Nitro sites, from within the Nitro machine.
Steps to reproduce:

Create a site with a craft.test host name, and put a test.txt file within it
Run nitro ssh
Within Nitro, run curl http://craft.test/test.txt

Expected result:
The contents of the text file would be output
Actual result
You get the following error:
curl: (6) Could not resolve host: craft3.test

This is because the /etc/hosts file within the VM doesn’t keep a record of craft.test.

Whoops, dupe of #150.


Setting colors for individual LEDs on Pixel Kit

In both implementations for "streaming frame" (python and nodejs), what the communitysdk does is to encode and send a list of 128 color values: One for each LED.
This list is a one dimensional representation of a two dimensional matrix of LEDs so to set the color of an LED by the x and y coordinate we need to convert a pair of coordinates (x, y) into an index in the unidimensional list.
The math is not complicated, for example if you want to set this color to red (#ff0000) all you have to do is to set a value in the frame array:
index = (x * 16) + y
frame[index] = '#ff0000'
# stream frame here

It would be great to have a method inside the communitysdk to solve this issue and/or an example on how to do this calculation.

Have started work on this, it is working with example included.
Going to write the unit tests, would love some feedback.
Can see changes to retailpixel.py → here


ACS Docs Quickstart - fix inconsistencies between .NET/Python examples and Java/js and output sample

@beltr0n : Thanks for your contribution! The author(s) have been notified to review your proposed change.

the sample output was not matching what .NET/Python examples would output
changed the Java example to print out the expiry time to make it inline with .NET/Python
minor text change to js example to be inline with .NET/Python

#sign-off

@beltr0n: I'm sorry - only the author of this article, @tomaschladek, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

Thank you for improving the doc.

#sign-off


US 05.02.01

As a doer, I want to grant or deny another doer permission to follow all my habits.

Other doer need permission to view my list


not closing after opening once in game

After opening menu when in game using "F2" or whatever is set the menu wont close causing me to f8 quit out.

Use mouse and click "X".

As @XvenDeR mentioned above, you can also hit "Escape" and it will close the menu as well. Closing this as it isn't an issue.


Destination gas fee selector confusing when bridging to/from ETH-native chains

Problem
Destination gas fee selector is giving the user the option to use "aETH" or "ETH" in an ETH<->ETH transaction (see img) to pay for gas. This isn't necessary since it's the same to pay in ETH from "sent asset" or from "wallet gas" on ETH-native chains ARB, OP and Mainnet.
Impact
Users may find it confusing, since they may think one of the options means they can pay the fee on the destination chain, or some other alternative. 👉 Happened to a friend of mine.
Proposed Solution
Only showing one option: "ETH". 👉 With no selector.
Acceptance Criteria
From an end user perspective, the below criteria must be met to consider this done:

[ ] I can understand in which asset i'm going to pay for the destination gas fee.

Closing in favor of the #4093


chore(TX-1116): update inline links

The type of this PR is: Chore

This PR solves TX-1116
Description
This PR updates our inline links to use the Palette Link component which has recently been updated with the link styles in the design system.
Because we don’t want to replace all links and only inline text style links, I did not replace RouterLink and a tags if the link was acting as an image or button.
I've also replaced the deprecated noUnderline with textDecoration="none" in RouterLinks whenever I saw them.

Yeah, I'm not so sure this would work as expected. I'm expecting all the instances of RouterLink to no longer client-side navigate here.

@dzucconi Hmm I've been testing to see if they are client-side navigating by changing the background color in dev tools and seeing if color persists when navigating, and it does, so I assumed these were working. However, I now realize that may not be the best way to test this. What would you recommend?

Maybe it is working then! @damassi I seem to remember something about the framework auto-detecting normal links. Do we even need to be using RouterLink?

Yup, we check for links within things like html, etc, via this bit of code, which I adapted from a Gatsby plugin.
Note that this was meant to just be used as a migration step, and that we should always be using RouterLink. Something like interceptLinks is brittle and while it works, we should stick to generally-accepted framework patterns (aka Next).

In that case I'd suggesting wrapping RouterLink in a new component (ummmm LinkRouterLink 😭? ), then @ts-ignore the inevitable type error on the to prop.

Haha please no LinkRouterLink in 81 files. Can we discuss this in #practice-web channel?


Can you make this feature: when I press Windows + E, this files open instead of Windows Explorer

It is already possible, look in the FAQ/documentation section. Personally, I just went with the modifying registry with the script given in Option 2.
https://files-community.github.io/docs/#/articles/configure-win-e


Switch to miniforge

Related to #49 and recent developments concerning Anaconda's Terms of Service.

macos with arm currently fails due to neurotic with a PackagesNotFoundError:
=== Creating latest neuro-conda environment
DEBUG: Copied local repository version of latest environment file to /Users/runner/.local/downloads/neuro-conda-latest.yml
Channels:
 - conda-forge
Platform: osx-arm64
Collecting package metadata (repodata.json): ...working... done
Solving environment: ...working... failed

PackagesNotFoundError: The following packages are not available from current channels:

  - neurotic=1.5*

@pantaray, when you have a minute, could you figure out why this is now happening? Has the macos-latest GitHub runner changed architecture?

@pantaray, nevermind, I'm merging this for now, as it works on Linux and Windows. Creating a separate issue for macOS.


Update Git Fork and Clone

These are simple last-minute modifications, mostly just links to definitions for when people get confused about new words or concepts being introduced without definitions.
I kept the line-wrapping the same for ease of GitHub diffing.

Cherry picked a subset of these commits into local branch.  Closing this PR.


A proposal on matching layout for lessons 16 to 29

Context
Programmer Dvorak change ' with ; position, and vice-versa

This PR will integrate
This is a humble proposal to match lessons in order to follow the expected order.
Affected lessons:

Thank you for this change. I'm not sure if it's OK to change the original Dan Woods' lessons since I was permitted to use the lessons from here http://gigliwood.com/abcd/lessons/ but was not permitted to alter the lessons. I know that Dvorak and Programmer Dvorak don't 100% match, but I think it has to be left as is for now.

Thank you for this change. I'm not sure if it's OK to change the original Dan Woods' lessons since I was permitted to use the lessons from here http://gigliwood.com/abcd/lessons/ but was not permitted to alter the lessons. I know that Dvorak and Programmer Dvorak don't 100% match, but I think it has to be left as is for now.

Got it, np


double-beep: Watch naturalvoodoospellhealer(?:@gmail.com)?

double-beep requests the watch of the watch_keyword naturalvoodoospellhealer(?:@gmail\.com)?. See the MS search here and the Stack Exchange search here.

naturalvoodoospellhealer(?:@gmail\.com)? has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ


Amazon-AWS-EC2 - Snapshots2

Added delete snapshot op.
Signed-off-by: Mihail-Cristian Tusa<EMAIL_ADDRESS>

@gituser173 Please review!


Iso 2022 jp - implement charset codec

With help from @kuroda and @mikel, I have implemented the CharsetCodec which @jeremy suggested in the original PR (https://github.com/mikel/mail/pull/534).
I have simply moved things around - it should work exactly the same as the original iso-2022-jp branch AFAIK.

Hey @yujiyokoo, @kuroda and @mikel 👋 One of our users over at https://github.com/zammad/zammad stumbled across this issue earlier this year and now one of our paying customers is affected as well. Therefore this topic gets a certain priority and we were wondering what we can contribute to enable this great gem to support Iso 2022 jp mails. Could you please give us a short update on the current state of this PR - which seems to be staled for nearly 6 years by now. We'd like to pick things up and get this merged into the latest version. Looking forward do hear from you. Bests, Thorsten

@thorsteneckel
The mail-iso-2022-jp is a hacked version of another gem that was maintained on https://github.com/ma2shita/mail_ja.
I managed to make this gem work, but I did not have a solid understanding of the internal structure.
So I couldn't answer the question from @jeremy.
I think it is very difficult to save this six year old PR.

Yeah I think @kuroda is right. It's very hard to save such an old PR.
Back then, I tried working on this for a while, and was intending to do more work on it but unfortunately other things got prioritised over it and I didn't know a lot about the internals of this either :(


Fixed detection of multiple consecutive CSS URLs without quotes

Encountered a bug where if CSS URLs do not use quotes and there's more to match on the current line, the absolute URL might include some CSS code.
Fixed the regex to account for this case, and added testcase.

LGTM! Also have tested the new regexp in a relative large style sheet to confirm there is no performance issue, good job!


Allow baseUrl to be set dynamically

As a developer I'd like to be able to dynamically point the client's baseUrl at a previously unspecified url. This is useful because many CI/CD pipelines dynamically generates urls and it would be useful to dynamically set the url without re-generating the client code.
I could see this done as an environment variable that sets the baseUrl, and some switch in the command to insert the environment variable.
Example:
npx swagger-typescript-api --dynamic-url

public baseUrl: string = process.env.CLIENT_BASE_URL;

Hello @kerly !
Thanks for issue
You can use custom templates for this feature
Just replace this template's line to what's you need:
https://github.com/acacode/swagger-typescript-api/blob/master/src/templates/defaults/http-client.mustache#L37
public baseUrl: string = "{{apiConfig.baseUrl}}";

Hello @kerly !
Thanks for issue
You can use custom templates for this feature
Just replace this template's line to what's you need:
https://github.com/acacode/swagger-typescript-api/blob/master/src/templates/defaults/http-client.mustache#L37
public baseUrl: string = "{{apiConfig.baseUrl}}";

For me, overwriting this entire template for a single change seems like a hassle. I too, would prefer a command line option.


Gui Issues

I updated to version v0.8.2-17bed524-win-x64 and the gui itself is no longer working correctly. when i roll back to the previous version it will work fine. i have used firefox and opera and both show the same issue.

Gui issues resolved with update v0.8.2-714f68a8-win-x64


Inefficient bytecode for constructor-less ES6 child classes

Refs: https://github.com/quickjs-ng/quickjs/issues/750
Ex.
class Foo extends Bar { /* no construct() */ }

Emits:
        /* super */
        emit_op(s, OP_scope_get_var);
        emit_atom(s, JS_ATOM_this_active_func);
        emit_u16(s, 0);

        emit_op(s, OP_get_super);

        emit_op(s, OP_scope_get_var);
        emit_atom(s, JS_ATOM_new_target);
        emit_u16(s, 0);

        emit_op(s, OP_array_from);
        emit_u16(s, 0);
        emit_op(s, OP_push_i32);
        emit_u32(s, 0);

        /* arguments */
        emit_op(s, OP_scope_get_var);
        emit_atom(s, JS_ATOM_arguments);
        emit_u16(s, 0);

        emit_op(s, OP_append);
        /* drop the index */
        emit_op(s, OP_drop);

        emit_op(s, OP_apply);
        emit_u16(s, 1);
        /* set the 'this' value */
        emit_op(s, OP_dup);
        emit_op(s, OP_scope_put_var_init);
        emit_atom(s, JS_ATOM_this);
        emit_u16(s, 0);
        emit_class_field_init(s);

https://github.com/quickjs-ng/quickjs/blob/4b9d0ebdba3ace6b7f6de21c3e3806ab4055bd7e/quickjs.c#L21898-L21938
Pretty bulky and inefficient (splatting arguments, doing js_function_apply, etc.) Probably better handled through a dedicated opcode.
Affects WBT benchmarks like babylon that create tons of such objects.

Hum, how come has_super doesn't work there? Then it would skip a bunch of that, wouldn't it?
Also, looks like this was changed in https://github.com/quickjs-ng/quickjs/commit/a8a5ecb0953d766fb5835421fecedecebb898c28 any chance it was made somehow worse?

how come has_super doesn't work there?

It does - :arrow_up: is the bytecode for when has_super == true.

looks like this was changed in https://github.com/quickjs-ng/quickjs/commit/a8a5ecb0953d766fb5835421fecedecebb898c28 any chance it was made somehow worse?

With 20/20 hindsight it would've probably been better to add and emit a specialized opcode but :shrug:, Divy's commit at least improved spec conformance.

Ah hold on. You mean all of that happens even when there is no constructor which calls super?!

Yep, that's right. It essentially synthesizes a constructor because of this:
class A { constructor(x) { print(x) } }
class B extends A { /* no constructor */ }
new B(42) // prints 42


Issue setting strict CSP in production

Describe the bug
I am having the same issue as here, but the solution  isn't working for me.
I'm using Electron + Vite and am trying to set a strict CSP (one with no unsafe-inline). Since I am using Electron and am not fetching my resources from a server, the nonce specified for cspNonce is generated right above the config. I then just use a plugin to inject the nonce into the index.html. This works fine in dev when the entire process is ran every time I run the app, but in production the process is only ran when packaging the app and never again. This is problematic as the nonce will no longer be regenerated, defeating the whole purpose. It would be nice if a strict CSP was supported without having to use a nonce.
// electron.vite.config.ts
let nonce = crypto.randomBytes(16).toString('base64');

const transformHtmlPlugin = data => ({
	name: 'transform-html',
	transformIndexHtml: {
		transform(html)
		{
			return html.replace(
				/<%=\s*(\w+)\s*%>/gi,
				(match, p1) => data[p1] || ''
			);
		}
	}
});

export default defineConfig({
	renderer: {
		plugins: [
			transformHtmlPlugin({ nonce: nonce })
		],
		html: {
			cspNonce: nonce
		},
	},
})

// index.html
<meta http-equiv="Content-Security-Policy" content="default-src 'self'; style-src 'nonce-<%= nonce %>'" />

Reproduction
https://github.com/TylerWanta/vite-csp-issue
Steps to reproduce
This will be an issue with any vite build with a strict CSP and no cspNonce  specified.
Clone the repo provided
cd vite-csp-issue
npm run dev
You can see the issue in the console but clicking CTRL + Shift + i
System Info
System:
    OS: Windows 11 10.0.22631
    CPU: (32) x64 13th Gen Intel(R) Core(TM) i9-13900KF
    Memory: 18.28 GB / 31.85 GB
  Binaries:
    Node: 21.5.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.2.4 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Chromium (123.0.2420.97)
    Internet Explorer: 11.0.22621.1
  npmPackages:
    @vitejs/plugin-vue: ^4.3.1 => 4.6.2
    vite: ^5.2.11 => 5.2.11

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

The added meta tag does not seem to take effect. You should add nonce-xxxx to the original meta tag.

@btea  I'm not entirely sure I follow but I think the main issue will still remain, after packaging the app the nonce will no longer be regenerated.

I'm not sure about other issues either. My current solution to the error problem is to do the following:

@btea My issue isn't getting the nonce to work, I already have that working. My issue is that using a nonce seems to be the only supported way of using a strict Content Security Policy with Vite. This won't work for me because after I package my app with electron, the nonce won't be regenerated anymore. Having a static nonce in my index.html defeats the whole purpose of a nonce.

Oh, sorry, it seems that I misunderstand what you mean. 🤦♂

@TylerWanta Hey! I have been working on a vite plugin to solve this specific problem. The issue is the nonce strategy doesn't support SPA's - what we need is hashes. Here is the plugin - its still pre 1.0 but I have written up some extensive documentation for the plugin as well as this specific problem.
Try it out and let me know what you think! All feedback is welcome

Hello @RockiRider  does it support nonce? I do have the same problem with @TylerWanta I need to generate nonce for every reload of an app because it only happens when build

Hello @RockiRider does it support nonce? I do have the same problem with @TylerWanta I need to generate nonce for every reload of an app because it only happens when build

Nope it doesn't support nonce's purely because Single Page Applications typically don't run on a server and hence don't support nonce's.
If you want nonce support you need a server. I have written up a small guide to help developers out that are running:

Running a server
Using a meta framework (Multi Page Application's)
Desire nonce functionality


Support for Bitpay/BIP70 payment protocol

Was trying to copy paste payment protocol request from eGifter who was using Bitpay payment protocol like bitcoincash:?r=https://bitpay.com/i/XXXXXXxxxxxxxXXXXXxxxxx into the "send" field, nothing happened; since Electrum does support the BIP70 protocol, is this expected to be added on Electron-cash desktop/android as well?
Android 3.1.5 doesn't do anything, neither does desktop linux ver. 3.1.2 (Fedora package).

Never mind, seems like a duplicate of #581 .

Reopening as I tried on Bitpay again (3.1.5 post #581 ):
I tried paying a Bitpay invoice and got:
pay_script() takes 2 positional arguments but 3 was given popup, the tx was broadcasted anyway - on the invoice page it returned
This invoice received a payment from a wallet that does not support payment protocol
I'm not sure what was wrong, currently getting Bitpay to either confirm payment or refund me.

@kyuupichan I tested the latest githead against Bitpay invoice, can confirm it now works. Thanks for the hard work, can't wait for release (and hopefully Fedora repo).

That's good, thanks for letting us know.

My payment was rejected by Bitpay. I built from latest HEAD
"This invoice received a payment from a wallet that does not support payment protocol."
Transaction was broadcasted, waiting on refund.
electrum-<IP_ADDRESS>-g44498be.exe

Probably related to building for Windows. I ran straight from ./electron-cash from the Linux command line (Fedora 27) and it was fine. @fyookball probably knows better?

I had the same problem using 3.1.6 on Android today. The payment was suddenly expired once the transaction was sent.
I used the demo page from Bitpay to support the EFF. ( https://bitpay.com/demos )

After a couple of hours, the invoices show as confirmed.
I opened a ticket for one of the payments and see what will happen.


Unexpected package creation during export data loading

With go1.19 ent generate give the following error
Unexpected package creation during export data loading
it seems to be related to entgo.io/contrib

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
ent schema with entgo.io/contrib init will cause it to fail the command > go generate ./ent/

Expected Behavior 🤔
command > go generate ./ent/
must execure without error

Steps to Reproduce 🕹
Try this
package schema

import (
	"entgo.io/contrib/entgql"
	"entgo.io/ent"
	"entgo.io/ent/schema/field"
)

// User holds the schema definition for the User entity.
type User struct {
	ent.Schema
}

// Fields of the User.
func (User) Fields() []ent.Field {
	return []ent.Field{
		field.String("username").
			Unique().
			NotEmpty().
			MaxLen(50),
		field.String("email").
			NotEmpty().
			Unique().
			Annotations(
				entgql.OrderField("EMAIL"),
			),
	}
}

Steps:

init a entity User
Copy above code to it
Try executing > go generate ./ent/

Your Environment 🌎

Tech
Version

Go
1.19

Ent
0.11.1

Database
MySQL

Driver
https://github.com/go-sql-driver/mysql

Quick update:
I tried coping source code of contrib/entgql package to my project local folder made chnages for path and removed most of things but just the just a annotations.go file. I furthre stripped it and having least code with only  2 imports "encoding/json" & "entgo.io/ent/entc/gen"
the moment I remove "entgo.io/ent/entc/gen"  issue goes away & comand >  go genererate ./ent
works.

I guess that might be related to package "golang.org/x/tools/go/packages" used in /entc/entc.go file

OK, seems like solution may be just to upgrade the package "golang.org/x/tools"

Fixed with #2832
Thanks for reporting this 🙏


create getExperimentalTorsions() function

Currently the only way to figure out which bonds are being matched to which experimental torsion is by turning on verbose mode and parsing the log. This is unsatisfactory
This PR adds an API function to return information about which bonds match experimental torsions and which torsion they match.

@sriniker this is the last of the current set of confgen changes. This one adds functionality to retrieve the list of experimental torsions (and their parameters) which are identified for a molecule.


Add support for trilulilu.ro:audio tracks

Please try to add support for audio tracks on trilulilu,.ro
Audio category url on trilulilu.ro is http://www.trilulilu.ro/?mimetype=audio#ref=mimetype_filter_audio
Example of audio only url from trilulilu.ro: http://www.trilulilu.ro/muzica-rock/freddie-mercury-the-great-pretender-1#ref=home
youtube-dl output with --verbose parameter:
D:\Tools>youtube-dl.exe --ve
rbose http://www.trilulilu.ro/muzica-rock/freddie-mercury-the-great-pretender-1#
ref=home
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--verbose', 'http://www.trilulilu.ro/muzica-rock/fr
eddie-mercury-the-great-pretender-1#ref=home']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2014.10.30
[debug] Python version 2.7.8 - Windows-8-6.2.9200
[debug] exe versions: ffmpeg N-66521-
[debug] Proxy map: {}
[generic] freddie-mercury-the-great-pretender-1#ref=home: Requesting header
WARNING: Falling back on generic information extractor.
[generic] freddie-mercury-the-great-pretender-1#ref=home: Downloading webpage
[generic] freddie-mercury-the-great-pretender-1#ref=home: Extracting information
ERROR: Unsupported URL: http://www.trilulilu.ro/muzica-rock/freddie-mercury-the-
great-pretender-1#ref=home; please report this issue on https://yt-dl.org/bug .
Be sure to call youtube-dl with the --verbose flag and include its complete outp
ut. Make sure you are using the latest version; type  youtube-dl -U  to update.
Traceback (most recent call last):
File "youtube_dl\extractor\generic.pyo", line 581, in _real_extract
File "youtube_dl\utils.pyo", line 1629, in parse_xml
File "xml\etree\ElementTree.pyo", line 1300, in XML
File "xml\etree\ElementTree.pyo", line 1642, in feed
File "xml\etree\ElementTree.pyo", line 1506, in _raiseerror
ParseError: syntax error: line 1, column 0
Traceback (most recent call last):
File "youtube_dl\YoutubeDL.pyo", line 533, in extract_info
File "youtube_dl\extractor\common.pyo", line 198, in extract
File "youtube_dl\extractor\generic.pyo", line 962, in _real_extract
ExtractorError: Unsupported URL: http://www.trilulilu.ro/muzica-rock/freddie-mer
cury-the-great-pretender-1#ref=home; please report this issue on https://yt-dl.o
rg/bug . Be sure to call youtube-dl with the --verbose flag and include its comp
lete output. Make sure you are using the latest version; type  youtube-dl -U  to
update.

I've looked into it, in order to get the sig part for the audio downloads, we would need to construct/parse an AMF request/response.

@naglis If you need a starting point, I have a partially implemented AMF 0 reader:
import io

from youtube_dl.utils import struct_unpack

class AmfReader(io.BytesIO):

    # Utility functions for reading numbers and strings
    def read_unsigned_long_long(self):
        return struct_unpack('!Q', self.read(8))[0]

    def read_double(self):
        return struct_unpack('!d', self.read(8))[0]

    def read_unsigned_int(self):
        return struct_unpack('!I', self.read(4))[0]

    def read_unsigned_short(self):
        return struct_unpack('!H', self.read(2))[0]

    def read_unsigned_char(self):
        return struct_unpack('!B', self.read(1))[0]

    def read_amf_string(self):
        length = self.read_unsigned_short()
        return self.read(length)

    def read_amf_value(self):
        value_type = self.read_unsigned_char()
        if value_type == 0:  # Double
            return self.read_double()
        if value_type == 2:  # DataString
            return self.read_amf_string()
        elif value_type == 3:  # DataObject
            data_object = {}
            while True:
                marker = tuple(map(lambda _: self.read_unsigned_char(), range(3)))
                if marker == (0, 0, 9):
                    break
                self.seek(-3, io.SEEK_CUR)
                name = self.read_amf_string()
                data = self.read_amf_value()
                data_object[name] = data
            return data_object
        else:
            raise NotImplementedError('Unsupported type %s' % value_type)

# From https://en.wikipedia.org/wiki/Action_Message_Format#AMF0
r = ' 03 00 04 6e 61 6d 65 02 00 04 4d 69 6b 65 00 03 61 67 65 00 40 3e 00 00 00 00 00 00 00 05 61 6c 69 61 73 02 00 04 4d 69 6b 65 00 00 09'

b = eval('b"""' + r.replace(' ', '\\x') + '"""')
reader = AmfReader(b)
print(reader.read_amf_value())

Thanks @jaimeMF, I will definitely check it out.

Hi,
This issue has been solved.Try the following command :
youtube-dl.exe --verbose -x --audio-format mp3 http://www.trilulilu.ro/the-blizzard-yuri-kane-everything-about-you-ft-rel#
Please make sure ffmpeg is install on your system. If not please follow the instructions given here


Make the Vertex AI embedding model adapt automatically the number of batch calls to make

With this change, the batching of embedding calls will be done automatically, adjusting the number of text segments to calculate embeddings for, according to the max number of tokens per batch call (up to 20k) and the max number text segments per batch call (up to 250).
There are 2 new methods in the builder to specify the max number of tokens and max number of text segments per call, as sometimes, the calculation of tokens seems to not be correctly returned by the underlying model (with textembedding-gecko@001 it's fine, but textembedding-gecko@003 seems to calculate 5-10% less tokens on a per segment basis, than it returns for the overall call)

PR updated with your review comments.
Thanks for the advice!

@glaforge just in case, this can be merged. The 2 minor thingies can be addressed afterwards.

I messed up a bit with Git, but I've renamed the getTokensCounts() method, but as you said, it's not an estimate, so I went with calculateTokensCounts().
And I've added positivity checks for the 2 max params.


fixed playht3.0 cannot be played if credential is cached

@davehorton this tested and it's working pls merge  and update fs package


refactor: use new enum constants from Models repo

Minor change to depend on new constants.

:tada: This PR is included in version 0.401.1 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


NgramModel fix: 3rd time's the charm

Summary
This is a continuation of work started in #800. This time I'm focusing just on finalizing the fix for #367 as well as making a first pass at #396.
Relevant Audience
Input from @stevenbird @rmalouf @bcroy @dan-blanchard @afourney @alvations would be most appreciated!
Outstanding issues

SimpleGoodTuring still doesn't work, I haven't had time to test anything other than Laplace and Lidstone, really.
pickling works, but NgramModel lacks reasonable comparison methods, so doctests for pickling will have to wait till that's fixed.

There's still some interfacing issues:
from nltk.model import NgramModel
from nltk.corpus import brown

lm = NgramModel(3, brown.words(categories='news'))

[out]:
Traceback (most recent call last):
  File "/home/alvas/git/nltk/test_model.py", line 4, in <module>
    lm = NgramModel(3, brown.words(categories='news'))
  File "/home/alvas/git/nltk/nltk/model/ngram.py", line 113, in __init__
    *estimator_args,
NameError: global name 'estimator_args' is not defined

@alvations fixed, thanks!

Sorry for jumping on this so late.  Are there plans to add alternatives to Katz backoff (interpolation methods)?  I'd like to add a cached language model built on NgramModel, but it'd be nice if there were different techniques available for use.
The distinction between a few of the ProbDist classes and language models is very fuzzy to me.  For example, KneserNeyProbDist already takes in a frequency distribution of trigrams and computes lower-order language models for estimation.  KneserNeyProbDist could easily be modified to start with any order ngrams, instead of just trigrams.  Witten-Bell can also be interpolated with lower order models.

Yea, when I added the KneserNey class there were a) issues with the NgramModel and b) what you pointed about about the distinction being unclear (even then).
I'm at a conference right now, but once I'm back, I'd want to refactor KN to work with any ngram model.
Adding interpolation as an alternative to Katz would also be cool!

Thanks @Copper-Head.  If you're busy, I'd be happy to look into refactoring KN as well :)

Honestly, I think I'd rather you tackle interpolation backoff in NgramModel while I deal with KN.

Gotcha, sure thing.

@Copper-Head , was browsing the ngram.py more thoroughly, this looks to be a very expensive line: https://github.com/Copper-Head/nltk/blob/model/nltk/model/ngram.py#L112
@jjonsafari, is there another way to learn the backoffs that doesn't run through the whole corpus for each order of ngram?

@alvations , you only need to run through the corpus once.  You can build up counts of all n-gram orders at the same time. As you're doing that you should also increment global count-of-counts for use in determining the G-T expected counts (alpha).  Depending on how you structure your n-gram counts, it can also be easy to determine your discount parameters (d) for Katz backoff.  Conceptually it's easy to traverse a compressed trie (or some other tree-like structure) to determine one discount parameter at a time.  Other ways are probably faster but less perspicuous (like traversing a hash table in one go and updating the various discount parameters piecemeal).

I've tried out with brown.sents() instead of brown.words() after finding out the bug/feature from the docstring. And now, this is a strange behavior.
from nltk.corpus import brown
from nltk.model import NgramModel

lm = NgramModel(3, brown.sents(categories='news'))
print(lm)

for i in lm:
    print(i)

[out]:
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>
<LidstoneProbDist based on 0 samples>

@alvations, I can't replicate the above, because of an earlier problem:
>>> lm = NgramModel(3, brown.sents(categories='news'))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/sb/git/nltk/nltk/model/ngram.py", line 107, in __init__
    cfd[context][token] += 1
TypeError: 'int' object is not subscriptable

@stevenbird, we've sort of fixed that at PyCon by introducing __iter__ in NgramModel class, i think @Copper-Head should commit that and some small fixes soon

@Copper-Head Sorry to revive an old thread, but you mentioned at the top that you got pickling to work? How?  The ProbDists aren't pickleable as far as I can tell.

@ELind77 We're actually reworking the model to the point where the pickling discussion is more or less a moot point.
If you have time though, feel free to check out #1342 and #1351 for recent developments. Feedback is most welcome :)


Header images displaying cache image only

hey
i love your work and i love this project..
but i am getting an issue..
i am loading a header image from Url
like this
case 0:
return HeaderDesign.fromColorResAndUrl( return HeaderDesign.fromColorResAndUrl(
R.color.colorPrimary,
"http://www.example.com/downloads/1");
i have renamed my image to like "1".
and like i put a image of a "cat" first on the server and then i changed the image with a "dog" picture but the name of the image is same..
but after that the header is displaying the "cat" image only..
it is not displaying the latest one which is a "dog" picture

Experiencing same problem, what can we do about it ?


[unrelated] Gentoo gentoo-check-unstable-keywords

Sorry to open this here, I saw no other way to reach you.
Some time ago you had a script "gentoo-check-unstable-keywords" in your "gentoo-scripts" repo, but the repo isn't available anymore and I cannot find an archive of it.
Do you by chance still have the script? Could you provide me with a copy?

Sorry but I can't find a copy of those scripts either. I uploaded those scripts at the request of a friend and didn't suppose anybody else used them.
I didn't have much insight into how to manage a gentoo configuration though so I don't think it's much of a loss. Best of luck!

Ah, that's unfortunate. I suppose I'll have to rewrite it.
Thanks


Cut Release 0.7.3

@brendandburns @filbranden

LGTM

I have to cherry-pick commit 239f25c30a6c1730e21851e61975a00a9985ec7a which removes poddex dependency to fix the travis.

Can you reorder it so that you cherry-pick it before 0.7.3 ?
You can use git rebase -i to reorder your commits...

Done with reordering.

Looks good. Feel free to go ahead and merge it.


Improve plugin setup guide to suggest installing the latest supported Nx version

Improve the plugin setup instructions to suggest installing with the latest Nx major version supported by this plugin (as suggested in #61).

Fixed by #84


Code | Alphabetic Pattern 97

@aryashah2k kindly assign this one to me.

@aryashah2k kindly assign this one to me.


KAFKA-7981: Add fetcher and log cleaner thread count metrics

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

retest this please

retest this please

don't fail this time please
(does this work? :) )

@viktorsomogyi do you mind rebasing this PR when you get the chance?
I'm eager to get this merged in :)

@stanislavkozlovski thanks for pinging, rebased it.
@hachikuji would you please also review this?

@ijuma would you please review this?

@omkreddy would you please review this?

@viktorsomogyi Seems one of the new tests (kafka.log.LogCleanerIntegrationTest.testIsThreadFailed) is failing.


Reported memory usage doubled on minikube with Docker driver

Describe the bug
The memory reported by Lens for pods or namespaces (and maybe nodes as well) is double the actual value on minikube with the docker driver.
I didn't examine Lens source, but issue 5660 mentions that these values come from the CAdvisor container_memory_working_set_bytes metric. It looks like CAdvisor metrics are duplicated when using the Docker driver.
For example: http://prometheus.minikube.test/api/v1/query?query=container_memory_working_set_bytes{pod%3D%22promtail-minikube-p568t%22} returns:
{
  "status": "success",
  "data": {
    "resultType": "vector",
    "result": [
      {
        "metric": {
          "__name__": "container_memory_working_set_bytes",
          "container": "POD",
          "id": "/docker/85b8af02515cb3e49ca58e7f9d5f59e038a1cb400bec20870842393ee6fe39c4/kubepods/besteffort/podb8b24008-42a6-4456-9cbd-002f0399b169/e9083fade7222b6a3fdd744bbd65af0192143ca825605572180d8490565d7313",
          "image": "k8s.gcr.io/pause:3.6",
          "instance": "minikube",
          "job": "kubernetes-nodes-cadvisor",
          "name": "k8s_POD_promtail-minikube-p568t_minikube-shared_b8b24008-42a6-4456-9cbd-002f0399b169_2",
          "namespace": "minikube-shared",
          "pod": "promtail-minikube-p568t"
        },
        "value": [
<PHONE_NUMBER>.559,
          "344064"
        ]
      },
      {
        "metric": {
          "__name__": "container_memory_working_set_bytes",
          "container": "POD",
          "id": "/kubepods/besteffort/podb8b24008-42a6-4456-9cbd-002f0399b169/e9083fade7222b6a3fdd744bbd65af0192143ca825605572180d8490565d7313",
          "image": "k8s.gcr.io/pause:3.6",
          "instance": "minikube",
          "job": "kubernetes-nodes-cadvisor",
          "name": "k8s_POD_promtail-minikube-p568t_minikube-shared_b8b24008-42a6-4456-9cbd-002f0399b169_2",
          "namespace": "minikube-shared",
          "pod": "promtail-minikube-p568t"
        },
        "value": [
<PHONE_NUMBER>.559,
          "344064"
        ]
      },
      {
        "metric": {
          "__name__": "container_memory_working_set_bytes",
          "container": "promtail",
          "id": "/docker/85b8af02515cb3e49ca58e7f9d5f59e038a1cb400bec20870842393ee6fe39c4/kubepods/besteffort/podb8b24008-42a6-4456-9cbd-002f0399b169/bcea5ce36f51412aec7df474c621ef957517f9ec2dcb6723c433fc1128fa5c03",
          "image": "sha256:297a6d3c3fa22e3ff144be351c67b135e7bc43cc126fab504b2e8d932d32d523",
          "instance": "minikube",
          "job": "kubernetes-nodes-cadvisor",
          "name": "k8s_promtail_promtail-minikube-p568t_minikube-shared_b8b24008-42a6-4456-9cbd-002f0399b169_2",
          "namespace": "minikube-shared",
          "pod": "promtail-minikube-p568t"
        },
        "value": [
<PHONE_NUMBER>.559,
          "88150016"
        ]
      },
      {
        "metric": {
          "__name__": "container_memory_working_set_bytes",
          "container": "promtail",
          "id": "/kubepods/besteffort/podb8b24008-42a6-4456-9cbd-002f0399b169/bcea5ce36f51412aec7df474c621ef957517f9ec2dcb6723c433fc1128fa5c03",
          "image": "sha256:297a6d3c3fa22e3ff144be351c67b135e7bc43cc126fab504b2e8d932d32d523",
          "instance": "minikube",
          "job": "kubernetes-nodes-cadvisor",
          "name": "k8s_promtail_promtail-minikube-p568t_minikube-shared_b8b24008-42a6-4456-9cbd-002f0399b169_2",
          "namespace": "minikube-shared",
          "pod": "promtail-minikube-p568t"
        },
        "value": [
<PHONE_NUMBER>.559,
          "88305664"
        ]
      },
      {
        "metric": {
          "__name__": "container_memory_working_set_bytes",
          "id": "/kubepods/besteffort/podb8b24008-42a6-4456-9cbd-002f0399b169",
          "instance": "minikube",
          "job": "kubernetes-nodes-cadvisor",
          "namespace": "minikube-shared",
          "pod": "promtail-minikube-p568t"
        },
        "value": [
<PHONE_NUMBER>.559,
          "88580096"
        ]
      }
    ]
  }
}

Note that the memory reported in entry 1 equals entry 2, and that entry 3 is very similar to entry 4.
In our Grafana dashboards, we use an additional filter id=~"/kubepods.+" for this case.
To Reproduce
Steps to reproduce the behavior:

Start minikube with Docker driver, eg: minikube start --vm-driver=docker --cni=calico --kubernetes-version=1.23.10
Install any pod.
Look at memory of that pod in Lens, it will be double of what is reported by helm top pod <podname>

Expected behavior
I expect Lens to report correct memory usage.
Screenshots

Environment (please complete the following information):

Lens Version: Lens-6.0.1-latest.20220810.2
OS: Ubuntu 20.04.5 LTS
Installation method (e.g. snap or AppImage in Linux): Installed the .deb package from https://k8slens.dev/

same doubling in EKS (docker://20.10.17)

same doubling on AWS EKS with containerd

I think that the issue with the query from here:
https://github.com/lensapp/lens/blob/fef94430649885d5368c2a41353012294c6f746b/packages/core/src/main/prometheus/operator-provider.injectable.ts.ts#L80
When you query container_memory_working_set_bytes{pod=~"$POD", namespace="default"} you'll get actually nContainers + 1 metrics. Each metric for container will have corresponding container label and one extra metric with container="" which seems to show the usage for entire pod:

So the query in operator-provider.injectable.ts.ts should be:
sum(container_memory_working_set_bytes{pod=~"${opts.pods}", namespace="${opts.namespace}", container!=""}) by (${opts.selector})

The problem also occurs with Kubernetes clusters from AKS or on-premises, both on the latest Lens version - 2023.4.141316 and also on the latest OpenLens version 6.4.15.
Instead I tried yesterday on an older version of Lens - 5.3.4-latest.20220120.1 and there are no duplicated metrics.

A similar problem actually exists with CPU metrics.
tell me if there is an announcement when the problem will be fixed?

Yesterday I noticed the same behavior on several of my clusters.
I'm using OpenLens 6.4.15 and my clusters are all on AKS spanning from versions 1.21 to 1.26 and all of them had the same issue: Pod memory usage was double the actual container usage (or the usage I got when trying kubectl top).
My colleague had an older version of regular Lens (I believe it was from 2022 but can't remember the number exactly) and he didn't have this issue.
I'm subscribing to this issue to keep an eye out for any fixes.

seeing this too on k2s v1.27.4 clusters  😕

This might be valid for some prometheus setup, but in our case it shows double CPU on pod view.
https://github.com/lensapp/lens/blob/f1a960fd785b62a118acd8b1525d879f39917e21/packages/technical-features/prometheus/src/operator-provider.injectable.ts.ts#L83

Same here - k3s running on Ubuntu 22.10 with prometheus-community/kube-prometheus-stack Helm chart


Nocturnal Display has collision

The crown floating over the characters head has collision and very frequently interrupts jumps and jump pad usage.

Should be fixed in 1.1.2


Create a Social Sharing Image for the site/project

https://github.com/ardalis/Specification/settings

Social preview
Upload an image to customize your repository’s social media preview.
Images should be at least 640×320px (1280×640px for best display).


Add sortby dropdown in Query Loader

Summary

Add sortby dropdown in Query Loader
How did you test this change?

[ ] Test(s) added
[x] Manual testing (please provide screenshots/recordings)
[ ] No testing (please provide an explanation)

https://github.com/finos/legend-studio/assets/73408381/ad8901dc-3b5a-46e9-b961-8c6a7d6f8932

Looks good to me.
@YannanGao-gs please let me know the order of merging things.
probably should wait until engine changes are release ?


Align help message with default values

When looking at the help message for the collector, some flag descriptions are a bit confusing:
--admin.http.host-port string                    The host:port (e.g. <IP_ADDRESS>:5555 or :5555) for the admin server, including health check, /metrics, etc. (default ":14269")

--collector.http-server.host-port string         The host:port (e.g. <IP_ADDRESS>:9411 or :9411) of the collector's HTTP server (default ":14268")

--collector.zipkin.host-port string              The host:port (e.g. <IP_ADDRESS>:5555 or :5555) of the collector's Zipkin server (default ":0")

I would expect to see something like this:
--admin.http.host-port string                    The host:port (e.g. <IP_ADDRESS>:14269 or :14269) for the admin server, including health check, /metrics, etc. (default ":14269")

--collector.http-server.host-port string         The host:port (e.g. <IP_ADDRESS>:14268 or :14268) of the collector's HTTP server (default ":14268")

--collector.zipkin.host-port string              The host:port (e.g. <IP_ADDRESS>:9411 or :9411) of the collector's Zipkin server (default ":0")

This might also be happening with other ports.

As part of hacktoberfest I found your issue with issuehub and would like to send a PR for this. Please feel free to assign this issue to me.

Assigned!


[Question] New Discord rate limiting

I have been an avid user of this script for a while now. It's great and does everything I need.
I ran it for the first time in a while today and found I am being rate limited to at minimum 6000ms per deletion by Discord.
Is this a new problem? It practically breaks the script as it takes hours to delete a few hundred messages.

Duplicate of #118.


Unable to upload app to app store: Info.plist key 'BGTaskSchedulerPermittedIdentifiers' must contain a list of identifiers ...

After building and sending to the app store the build is rejected because of:
App Store Connect Operation Error: ERROR ITMS-90771: "Missing Info.plist value. The Info.plist key 'BGTaskSchedulerPermittedIdentifiers' must contain a list of identifiers used to submit and handle tasks when 'UIBackgroundModes' has a value of 'processing'. For more information, refer to the Information Property List Key Reference at https://developer.apple.com/library/ios/documentation/General/Reference/InfoPlistKeyReference/Introduction/Introduction.html."
What are the identifiers that need to be supplied for this plist array?

I got the same error

Hi @scofield-hello, I just added the following to the runner info.plist and it went away:
<key>BGTaskSchedulerPermittedIdentifiers</key>
	<array>
		<string>com.your.app.identifier</string>
	</array>

it works for me, thanks !

@jayant1441 thank you for your comments - please open a separate ticket for any iOS issues (please also test using the latest beta). We do appreciate a PR rgd. missing documentation. 👍


FIX: Revise debug/sloppy operations of the coeff2epi workflow

The sloppy option was misused for debugging (also because the name was misused).
This PR makes a better use of debug/sloppy boolean arguments.

If backported, #288 should also be included.


Revert "(maint) Bump to ezbake 1.8.7"

This reverts commit 61d0a969db7be8e9a5fe39da404580de518583d6.

Test PASSed


Release to GitHub Workflow

Add workflow to release to GitHub
Build Workflow
Inputs
sha: commit to release - should already have changelog and version bump complete. Pass from release prep workflow.
version number: of release (ie 1.2.3rc1)
changelog_path: path to the changelog for this release. Generated in release prep workflow.
file_uploads: list of files expected as the release artifacts
Outputs
tag: the tag we just released
Workflow Steps

Depends on Build Job
Check if version & commit is already released to Github.  Check if there's a release for this version with another commit or if this commit has a different release associated with it.
If release already exists, skip the rest of this workflow
Release to GitHub

Testing
Will need a previous step that uploads the artifacts to then do a release.  Could run this again to ensure everything was released?
Open Questions

How to send in a list of files as input?

Resolved by contractor work


Fix mechanism to download Maven on the fly (MacOS)

I tried to run https://github.com/wetneb/OpenRefine/tree/4682-commons-upload to test uploading to Wikimedia Commons, but OpenRefine refused to start.
Current Results
See log below
Expected Behavior
Maven is downloaded and I can run OpenRefine
Terminal log
Sandras-MacBook-Air:~ fokky$ /Users/fokky/Documents/GitHub/OpenRefine/upload-test/refine ; exit;
Using refine.ini for configuration
-------------------------------------------------------------------------------------------------
You have 173M of free memory.
Your current configuration is set to use 1024M of memory.
OpenRefine can run better when given more memory. Read our FAQ on how to allocate more memory here:
https://docs.openrefine.org/manual/installing#increasing-memory-allocation
-------------------------------------------------------------------------------------------------
ls: server/target/lib: No such file or directory
\nCould not find Maven locally, starting download for Maven ...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (60) SSL certificate problem: certificate has expired
More details here: https://curl.haxx.se/docs/sslcerts.html

curl performs SSL certificate verification by default, using a "bundle"
 of Certificate Authority (CA) public keys (CA certs). If the default
 bundle file isn't adequate, you can specify an alternate file
 using the --cacert option.
If this HTTPS server uses a certificate signed by a CA represented in
 the bundle, the certificate verification probably failed due to a
 problem with the certificate (it might be expired, or the name might
 not match the domain name in the URL).
If you'd like to turn off curl's verification of the certificate, use
 the -k (or --insecure) option.
HTTPS-proxy has similar options --proxy-cacert and --proxy-insecure.
/Users/fokky/Documents/GitHub/OpenRefine/upload-test/refine: line 236: exit: Error while downloading https://dlcdn.apache.org/maven/maven-3/3.8.5/binaries/apache-maven-3.8.5-bin.tar.gz: numeric argument required
logout
Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.

[Process completed]

Versions

Operating System: MacOS 10.13.6
Browser Version: Chrome 101.0.4951.64 (Official Build) (x86_64)
JRE or JDK Version:
OpenRefine: testing https://github.com/wetneb/OpenRefine/tree/4682-commons-upload

Duplicate of #5484.


remove instance params for write request

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.