[UWP] Allow to filter unhandled exceptions

Describe the solution you'd like
Right now AppCenterSDK will send to dashboard any unhandled exception, which was thrown in application.
For my needs, I want something to filter exceptions:
bool FilterException(Exception exception, bool isUnhandled)

Or I see better way with Crashes.SendingErrorReport event which have SendingErrorReportEventArgs arguments and it could be updated with one new field
public class SendingErrorReportEventArgs : ErrorReportEventArgs
{
    public bool Cancel { get; set; }
}

Error will be ignored by SDK, if it was handled with setting Cancel to 'true'.

Thanks for the feedback! What kind of exceptions are you looking to filter out?
We have a SDK method that might work for you: https://docs.microsoft.com/en-us/appcenter/sdk/crashes/uwp#should-the-crash-be-processed
Or you can use our search functionality: https://docs.microsoft.com/en-us/appcenter/diagnostics/search

@winnie
Thanks, I didn't found that filter before, my bad.
But still it isn't really suitable for my cases, because it doesn't contains Exception information - it has only Stacktrace, which isn't really friendly.
But anyway, it should be enough.


Unable to Rollup Count of Attachments

I have seen that a lot of people have been able to rollup count of attachments, but I can't seem to get it to work. The calculation occurs, but I get 0 even though I have files attached to my parent record. Anyone have insight on this?
Here is my rollup:

I found the answer. Looks like this can't happen in realtime and has to be scheduled, which doesn't meet my needs.


Permit logged-in user to change password directly

I am trying to give my users the option to change their password as they login.  I don't use any email authentication and this user community really wouldn't want to depend upon email.  I just want to allow them to change the password.
Currently, on the login screen if they click "change password" I offer two new fields including new password and password confirmation.  If they fill them in and they are equal, I attempt to change_password!.  That method was not available to me so I updated my initializer to include:
Rails.application.config.sorcery.submodules = [:reset_password]
However, that throws the error that I must configure a mailer, so I seem to be going down the wrong path. Is this even possible using Sorcery 0.9.0?

Hi @TechRsch
reset_password submodule is not for changing password while being logged in, it's for resetting password when user forgets it.
What you need is just add controller action which calls code like this:
if params[:password] == params[:password_confirmation]
  user.update(password: password) # password will be encrypted automatically
else
  flash[:error] = 'passwords don't match'
  render 'new'
end

Works wonderfully.  Thanks.


navigator: reset cruise speed when out of mission

This reset the cruise speed which can be set by mission items/waypoints
to set a custom speed. Once, switched out of mission, it makes sense to
use the speed set by the param again.
FYI @LorenzMeier as discussed.
Tested in SITL.

Looks good to me.


Does this have caching enabled?

Not out of the box, no. A cache driver wrapper would be a useful feature.
If you use the database driver, I think this should work:
Settings::setConstraint(function($query) {
    $query->remember(10);
});

thanks!


deprecate [leanpub] badges

Resolves #4457

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @calebcartwright!

  Generated by :no_entry_sign: dangerJS against 9a0ac3ec82a0d03e11f864fe456ddd9499ee4b38


testing: prow/gpu-operator: use JOB_NAME to distinguish test bundles and images

/hold

/test gpu-operator-e2e

/test gpu-operator-e2e
On Fri, Nov 26, 2021 at 11:14 AM openshift-ci[bot] @.***>
wrote:

@kpouget https://github.com/kpouget: The following test failed, say
/retest to rerun all failed tests or /retest-required to rerun all
mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/gpu-operator-e2e 02e51fa
https://github.com/openshift-psap/ci-artifacts/commit/02e51fab85891219f7c8c40638fc63ae90518971
link
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift-psap_ci-artifacts/290/pull-ci-openshift-psap-ci-artifacts-master-gpu-operator-e2e/1464161654299168768
true /test gpu-operator-e2e
Full PR test history
https://prow.ci.openshift.org/pr-history?org=openshift-psap&repo=ci-artifacts&pr=290.
Your PR dashboard
https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:kpouget.
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openshift-psap/ci-artifacts/pull/290#issuecomment-979849695,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABZVQIVTN5ABVUIYDJJAHWLUN5MWRANCNFSM5I2GHXLA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

/lgtm

thanks @omertuc, PR is doing what I expected:
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift-psap_ci-artifacts/290/pull-ci-openshift-psap-ci-artifacts-master-gpu-operator-e2e/1464180231500730368/artifacts/gpu-operator-e2e/presubmit-master/artifacts/001__gpu_operator__deploy_from_bundle/_ansible.cmd

deploy_bundle_image=quay.io/openshift-psap/ci-artifacts:operator_bundle_gpu-operator-ci-image-pull-ci-openshift-psap-ci-artifacts-master-gpu-operator-e2e

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift-psap_ci-artifacts/290/pull-ci-openshift-psap-ci-artifacts-master-gpu-operator-e2e/1464180231500730368/artifacts/gpu-operator-e2e/presubmit-master/artifacts/001__gpu_operator__deploy_from_bundle/_ansible.log

operator-sdk run bundle --timeout=5m -n nvidia-gpu-operator --install-mode OwnNamespace quay.io/openshift-psap/ci-artifacts:operator_bundle_gpu-operator-ci-image-pull-ci-openshift-psap-ci-artifacts-master-gpu-operator-e2e

so nightly tests should not override each other's images
PR tests will still all use the same name though, but customizing it (eg with the PR ID) would always create new tags on quay.io and never delete them. Let's avoid that.

/approve


$1000 DOLLARS LOST DUE TO WALLET BUG!!!

What happened: When my defichain wallet was syncing it came up with an error as defichain wallet uses like 40gb of space on my laptop????, however after the error it still allowed me to create the wallet, me arogantly and not good with tech, creates a wallet then purchases some dfi (saw julian video and was sold). Then i wait for the dfi... 30... 45... 60 minutes then i refresh the wallet which btw on the left bottom it said syncronized at 6800 blocks when i believe it was meant to be 7500?. then it pops up with a red message saying error 500 or something along those lines. I then close the app and re open it only for it to not load and just show the defichain logo. I then reinstalled and since have not been able to get in. This is very stressful as I recently lost my job due to covid-19 so i put 1/4 of my savings in this so it is a pretty huge blow for my prehaps one I will not recover from.
What you expected to happen: I expected to recieve my dfi In my newly created wallet.
How to reproduce it (as minimally and precisely as possible):
If this means fix the issue then I would like a defichain developer to look into the wallet and check the transaction and then i could send them proof of the easycrypto order i filed as well as time stamps of installation dates to confirm that it was me who created the wallet and brought the dfi. then they could get a seed phrase for the wallet and give me that, then i would be able to get into my wallet.
What are your environment parameters?

DeFi Wallet Version: 2.3.3
Operating System (OS): Windows 10

Anything else we need to know?: idk if relevant but I have a youtube channel called "Pete Invests" just to confirm who I am and that I'm involved with crypto in positive ways.
 unfortunatly I lost them

Address: rGWRBZWBXioSFSA9WAWxR59ahWfRgAkkDK
TXID: 6DB6FB370BF4CF0A74E7C25974A6EFC85FD390A5298EDDC62F9EB9A6CA201D63

address: da4QbJxpcYMAjXuQCnPniTeFrRrcAQ6YwA

Hi @peteinvests , v2.3.3 is out. Please read through the release notes before updating. If you have not sync to 100%, there was a node issue on 05/04/2021 that may have cause the network error, everything is back online now, you may try the following:
Option 1 — Reset & Reindex (sync from 0%)

Settings > Reset & Reindex

Option 2 — Snapshot (sync from 90%+)

Settings > Reset & Reindex
Wait for app to start syncing
Ensure you’ve at least 27GB of extra space
Click on i located at bottom-left corner of app screen
Download Snapshot

Please do not delete anything you're unfamiliar with, do you have your wallet.dat?
Windows —
 C:\Users\<username>\AppData\Roaming\DeFi Blockchain\wallets\wallet.dat
Please keep the wallet.dat & your passphrase safe.


mode for updating a single (sub-)album

As background, I'm investigating speedups such that I can run sigal in an interactive mode whenever updates are made to a large gallery, instead of as a background task every hour.  Currently, running sigal takes several minutes, a large portion of which is reading and writing files that have not changed.
Since I know beforehand which files have changed (usually a single file or directory), it would be significantly faster to only process that one album and ignore all others.  Something like the inverse of the ignore_directories setting, except keeping the existing output for everything that is ignored.
Before trying to implement something like this myself, do you have any thoughts or preferences?

Yes indeed, something like ignore_dirs in the collection phase should be doable.


Export image as LUT code missing

Hello! Thanks for making this app open source. One thing I couldn't find as I scanned through the source code is Save LUTs image functionality. Can you update the repo with the relevant code or share it in a gist? Thanks :)

Sorry for the late reponse.
I hope you found a way by yourself.
There are no tricks here. If you want to export Lut. just replace your origin image with nature lut

Thanks for your reply @j1mmyto9
Am not sure what do you mean by just replace your origin image with nature lut!
Just to reiterate what am saying is that: Say I open any image in this app, then I play around with the colour settings and change a bunch of values. Now in the export section, I want to export only the “lut” of the image which has the colour modifications, not export the modified image itself. See this link for more context.
I believe this functionality is missing from the source code in this repo but it’s there in the app on the App Store. Can you please point me towards the “Save LUTs image” source code in this repo or share example code in a gist?
Thanks!

I'm also interested in the "Save LUT's image" function.
@latesh Did you create it?

Only recently I saw Brightroom… And now I see your project @j1mmyto9
I have no words for how great you did — thanks for the work you've done 👍
I would like to try all the functionality in action. Please update the repository to the latest version 🥺

Update


Adapt package publishing for new repo layout

This is required due to the new go mod module layout

//cc @EvanBoyle


refactor: async/await

refactor

Codecov Report

Merging #137 into master will decrease coverage by 0.58%.
The diff coverage is 96.93%.

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
- Coverage   97.80%   97.22%   -0.59%
==========================================
  Files           7        7
  Lines         228      216      -12
  Branches       68       66       -2
==========================================
- Hits          223      210      -13
- Misses          5        6       +1

Impacted Files
Coverage Δ

src/imagemin-loader.js
92.00% <90.00%> (-4.30%)
:arrow_down:

src/ImageminPlugin.js
94.44% <96.87%> (ø)

src/minify.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 148fecf...d2da986. Read the comment docs.


1.0.0 RC

Pulls in #119 and #116 .
We should update the README, write up a list of breaking changes and set a release date.

Acknowledged, but not tested.


Add SQLAlchemy clean-up workaround

This adds a clean-up function for sqlalchemy that seems prudent. That said, I cannot vouch for its value, as I added this while debugging some issues with sessions being reused in async tests. I was still seeing sqlalchemy complaining about deleting sessions that weren't closed, so its not clear to me, yet, what is happening there.
I don't think there is any harm in having this.

A quick test reveals that this may be a performance penalty, so maybe there's a better way to go about this.


Python way of loading model

What is the python code for loading the model?
For reference , what is the way to load a JSON model file in python?

The Python code is here: https://github.com/tensorflow/magenta/tree/master/magenta/models/sketch_rnn

@adarob : the question is how to load JSON model in python.
Javascript code :
'''
var model_data = Parsed_JSON_file_of_pretrained_weights();
var model = new SketchRNN(model_data); // this creates your model using the pre-trained weights inside model_data
'''
In the python code , the pre-trained-models are not in JSON format.
Actually, I want to use pre-trained model for chair in python code and the chair model is in JSON format.

I don't think you can load a JSON model in Python. @hardmaru is there a chair model for Python?

I found the answer for the other way round, i.e, converting a python model into JSON file, recording it for future reference.
https://github.com/tensorflow/tfjs-converter
https://github.com/tensorflow/magenta-demos/issues/33


Allow some kind of SocketFactory

In my game I use an implementation of Reliable UDP as an own Socket- / Sockerserver implementation. I'd really love to use this implementation as the underlaying protocol for kryonet. For that I would need some kind of SocketFactory I can handover. As far I can see, that's not possible for now.

I'd really love to see this too. Also to set options like tcpNodelay.


Not working from the AUR build

Arch/Xorg/Gnome 43.3
I left a comment on the AUR one week ago:
$ wl-screenrec
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: NoCompositor', src/main.rs:999:45
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This is only for wlroots based compositors (sway etc)


spider_home

Your checklist for this pull request
Author name
Usermaatre Setepenre

About your game
this game is about a spider that wanna go to his home but he have obstacles along the way and the gravity is a issue, so you have to be patience and wait for the right time and take him home!
How do you play your game?
press WASD for move and press J for restart the level. and avoid the bombs otherwise level will restart
Code

[YES] The game was made using the Sprig editor.
[YES] The game is placed in the in the /games directory.
[YES] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[YES] The game runs without errors.
[YES] The name of the file/game contains only alphanumeric characters, -s, or _s.
[YES] The game name is not the same as the others from gallery

Image (If an image is used)

[YES] The image is in the /games/img directory.
[YES] The name of the image matches the name of your file.

Thanks for your PR!

i increased the delay to 1 sec. so player have more time 🖤

i saw in Arduino forums about you guys 🖤
and thank you 🖤

Oh nice! Just out of curiosity, do you have the link?

yeaah,
i dont have a link but i can show you snap of the post that i took when i saw that 🖤

Nice! Thanks for sharing:)


[Vue warn]: existing instance property "classes" will be overwritten by a computed property with the same name.  (found in component )

vue 2.1.8
element-ui  1.0.9

fixed via https://github.com/ElemeFE/element/pull/2047


PR 2634 CI - Fix the tool_choice format for named choice by adapting OpenAIs scheme

This PR re opens #2634 to run CI

@linusbierhoff thank you for the contribution! 🙏 I've opened this PR to run CI, and add some other tool calling improvements along with your changes.
This PR now removes the old ToolType in favor of a more simple ChatCompletionToolChoiceOption. This new struct includes the addition of TypedChoice and correctly allows a user to specify the following tools as strings or as an object. Additionally this PR includes support for the required tool_choice, which forces the model to use one of the user provided tools. Lastly the new struct also improves the openapi spec and makes the tool choice a oneOf which improves the spec readability

required is that an OpenAI spec ?
Can you point to the original references for the things we're adding.
Also dropping the old code is a pretty bad breaking change, it should be in big bold red !.
Why are we dropping support for the old way, if it was there, is it documented anywhere ? Should we update the old doc ?
This PR is also seriously lacking integration tests for all of these. The deserialization tests are nice, but not enough.

required is that an OpenAI spec ?

yea required is supported by OpenAI, see docs here: https://platform.openai.com/docs/guides/function-calling/configuring-function-calling-behavior-using-the-tool_choice-parameter. Note** OpenAI added this parameter after TGI's initial tool implementation (hence why it was missing), additionally prior to https://github.com/huggingface/text-generation-inference/pull/2614 auto and required had the same functionality in TGI, however now its more pressing/great to have the api's aligned.

Also dropping the old code is a pretty bad breaking change, it should be in big bold red !.

yea regarding the removed code - as the original PR noted, the function tool choice was expecting the incorrect format. I believe I confused some of the function calling formats and ended up adding one that was not aligned with any major LLM api.
regarding flagging the breaking changes, would it be best to include the old API but throw a helpful error if it is used? Currently I've removed the path in favor of the corrected one.

Why are we dropping support for the old way, if it was there, is it documented anywhere ? Should we update the old doc ?

we're dropping support since it was incorrectly implemented, we do not have documentation specific to this tool choice, however I'm going to push another commit with updated docs for the supported tool choice types

This PR is also seriously lacking integration tests for all of these. The deserialization tests are nice, but not enough.

just added a test for required and one for a function object in test_tools_llama.py

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

merging optimistically as CI is green and issues have been resolved. Also mentioned in the internal #text-generation-inference Slack channel.
Will watch for any regressions and revert if needed


Use a single web socket connection for all graphql subscriptions

Description
Meshery UI was using different websocket connections for each graphql subscription which is not effective since it will have to establish a websocket connection every time it has to subscribe to an event.
This pr changes that behaviour so that it now creates a single websocket connection and uses it for all graphql subscriptions.
This PR fixes #3782
Signed commits

[x] Yes, I signed my commits.

Codecov Report

Merging #3819 (53f646f) into master (705fc47) will decrease coverage by 7.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3819      +/-   ##
==========================================
- Coverage   21.57%   14.04%   -7.53%
==========================================
  Files          51       51
  Lines        4228     4228
==========================================
- Hits          912      594     -318
- Misses       3066     3482     +416
+ Partials      250      152      -98

Flag
Coverage Δ

gointegrationtests
?

unittests
14.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/system/status.go
0.00% <0.00%> (-62.83%)
:arrow_down:

mesheryctl/internal/cli/root/system/start.go
1.11% <0.00%> (-52.97%)
:arrow_down:

mesheryctl/internal/cli/root/system/stop.go
0.90% <0.00%> (-39.10%)
:arrow_down:

mesheryctl/internal/cli/root/system/check.go
1.39% <0.00%> (-22.38%)
:arrow_down:

mesheryctl/internal/cli/root/system/logs.go
0.00% <0.00%> (-21.60%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8061685...53f646f. Read the comment docs.


Add icon for Benny & Co.

Description

Add icon for Benny & Co. (https://play.google.com/store/apps/details?id=com.bennyco.app&hl=fr_CA&gl=US)
Icons addition information

Icons added

Benny & Co. (com.bennyco.app)

Contributor's checklist

[x] I have followed the Lawnicons Guidelines
[x] I have ensured that Lawnicons builds correctly
[x] I am willing to make changes to my icons if someone suggests changes

Most likely, this PR will have to be recreated. If you do this, you can use this icon.


📖 [Story] Windows Support

TL;DR
First iteration of Windows support task tracking
Tasks
### Tasks
- [ ] https://github.com/pytorch/TensorRT/issues/2371
- [ ] https://github.com/pytorch/TensorRT/issues/2247
- [ ] https://github.com/pytorch/TensorRT/issues/2489

I have managed to built the C++ and Python API with Bazel on Windows. While the torch_tensorrt package can be imported successfully and the _C extension does get loaded, the inference still has problems.
Firstly, I tried to run the below script using ir="ts" and it actually worked.
import torch
import torch_tensorrt

class MyModule(torch.nn.Module):
    def __init__(self):
        super().__init__()
        self.m = torch.nn.LeakyReLU()

    def forward(self, x):
        return self.m(x)

model = MyModule().eval().cuda()
inputs = [torch.randn((1, 3, 8, 8), dtype=torch.float, device="cuda")]

optimized_model = torch_tensorrt.compile(
    model,
    ir="ts",
    inputs=inputs,
    enabled_precisions={torch.float},
    debug=True,
    min_block_size=1,
)

print(optimized_model(*inputs))
torch._dynamo.reset()

Then, I ran the above script again with ir="dynamo" but it silently crashed without any message after the TRT engine had been built. I also tried adding output_format="fx" but no avail. At this point I have no clue what's the culprit.
The changes I have done are at https://github.com/HolyWu/TensorRT/commit/741ec5b6b4163f5f85fa25ffc06a101079ab0a47.
Here is the Python wheel if anyone wants to try it.
torch_tensorrt-2.3.0.dev0+afd5abebb-cp311-cp311-win_amd64.zip

I think I have found the culprit of the crash. The crash upon inference is caused by the call to torch.ops.tensorrt.execute_engine in the forward function of TorchTensorRTModule. It seems that the tensorrt.cp311-win_amd64.pyd extension in Windows TensorRT 8.6.1 has weird bug with torch.ops. Building torch_tensorrt with TensorRT <IP_ADDRESS> libraries and installing <IP_ADDRESS> (or <IP_ADDRESS>) Python package eliminates the crash. Now the above script can successfully output the inference result from ir="dynamo", albeit there are a lot of Could not register plugin creator messages in the beginning and I don't know why.
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::BatchedNMSDynamic_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::BatchedNMS_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::BatchTilePlugin_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::Clip_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::CoordConvAC version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::CropAndResizeDynamic version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::CropAndResize version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::DecodeBbox3DPlugin version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::DetectionLayer_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::EfficientNMS_Explicit_TF_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::EfficientNMS_Implicit_TF_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::EfficientNMS_ONNX_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::EfficientNMS_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::FlattenConcat_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::GenerateDetection_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::GridAnchor_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::GridAnchorRect_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::InstanceNormalization_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::InstanceNormalization_TRT version 2
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::LReLU_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::ModulatedDeformConv2d version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::MultilevelCropAndResize_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::MultilevelProposeROI_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::MultiscaleDeformableAttnPlugin_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::NMSDynamic_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::NMS_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::Normalize_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::PillarScatterPlugin version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::PriorBox_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::ProposalDynamic version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::ProposalLayer_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::Proposal version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::PyramidROIAlign_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::Region_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::Reorg_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::ResizeNearest_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::ROIAlign_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::RPROI_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::ScatterND version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::SpecialSlice_TRT version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::Split version 1
[03/02/2024-16:57:02] [TRT] [E] Could not register plugin creator -  ::VoxelGeneratorPlugin version 1
DEBUG:torch_tensorrt.dynamo._compiler:Input graph: graph():
    %arg0_1 : [num_users=3] = placeholder[target=arg0_1]
    %gt : [num_users=1] = call_function[target=torch.ops.aten.gt.Scalar](args = (%arg0_1, 0), kwargs = {})
    %mul : [num_users=1] = call_function[target=torch.ops.aten.mul.Tensor](args = (%arg0_1, 0.01), kwargs = {})
    %where : [num_users=1] = call_function[target=torch.ops.aten.where.self](args = (%gt, %arg0_1, %mul), kwargs = {})
    return (where,)
DEBUG:torch_tensorrt.dynamo.lowering.passes.constant_folding:Graph after constant folding:
graph():
    %arg0_1 : [num_users=3] = placeholder[target=arg0_1]
    %gt : [num_users=1] = call_function[target=torch.ops.aten.gt.Scalar](args = (%arg0_1, 0), kwargs = {})
    %mul : [num_users=1] = call_function[target=torch.ops.aten.mul.Tensor](args = (%arg0_1, 0.01), kwargs = {})
    %where : [num_users=1] = call_function[target=torch.ops.aten.where.self](args = (%gt, %arg0_1, %mul), kwargs = {})
    return (where,)
DEBUG:torch_tensorrt.dynamo._compiler:Lowered Input graph: graph():
    %arg0_1 : [num_users=3] = placeholder[target=arg0_1]
    %gt : [num_users=1] = call_function[target=torch.ops.aten.gt.Scalar](args = (%arg0_1, 0), kwargs = {})
    %mul : [num_users=1] = call_function[target=torch.ops.aten.mul.Tensor](args = (%arg0_1, 0.01), kwargs = {})
    %where : [num_users=1] = call_function[target=torch.ops.aten.where.self](args = (%gt, %arg0_1, %mul), kwargs = {})
    return (where,)
INFO:torch_tensorrt.dynamo._compiler:Compilation Settings: CompilationSettings(precision=torch.float32, debug=True, workspace_size=0, min_block_size=1, torch_executed_ops=set(), pass_through_build_failures=False, max_aux_streams=None, version_compatible=False, optimization_level=None, use_python_runtime=False, truncate_long_and_double=False, use_fast_partitioner=True, enable_experimental_decompositions=False, device=Device(type=DeviceType.GPU, gpu_id=0), require_full_compilation=False, disable_tf32=False, sparse_weights=False, refit=False, engine_capability=<EngineCapability.DEFAULT: 0>, num_avg_timing_iters=1, dla_sram_size=1048576, dla_local_dram_size=1073741824, dla_global_dram_size=536870912, dryrun=False, hardware_compatible=False, output_format='exported_program')

DEBUG:torch_tensorrt.dynamo.partitioning._global_partitioner:
Supported Nodes:
- torch.ops.aten.gt.Scalar + Operator Count: 1
- torch.ops.aten.mul.Tensor + Operator Count: 1
- torch.ops.aten.where.self + Operator Count: 1

DEBUG:torch_tensorrt.dynamo.partitioning._global_partitioner:
All Nodes Supported

DEBUG:torch_tensorrt.dynamo._compiler:Detected support for 3 operators out of 3 in subgraph.
DEBUG:torch_tensorrt.dynamo.partitioning._adjacency_partitioner:
Number of TensorRT-Accelerated Engines Generated: 1
DEBUG:torch_tensorrt.dynamo.partitioning._adjacency_partitioner:
Supported Nodes:
- torch.ops.aten.gt.Scalar + Operator Count: 1
- torch.ops.aten.mul.Tensor + Operator Count: 1
- torch.ops.aten.where.self + Operator Count: 1

DEBUG:torch_tensorrt.dynamo.partitioning._adjacency_partitioner:
All Nodes Supported

DEBUG:torch_tensorrt.dynamo._compiler:Submodule name: _run_on_acc_0
 Input shapes: [(1, 3, 8, 8)]
 graph():
    %arg0_1 : [num_users=3] = placeholder[target=arg0_1]
    %gt : [num_users=1] = call_function[target=torch.ops.aten.gt.Scalar](args = (%arg0_1, 0), kwargs = {})
    %mul : [num_users=1] = call_function[target=torch.ops.aten.mul.Tensor](args = (%arg0_1, 0.01), kwargs = {})
    %where : [num_users=1] = call_function[target=torch.ops.aten.where.self](args = (%gt, %arg0_1, %mul), kwargs = {})
    return where
[03/02/2024-16:57:03] [TRT] [I] [MemUsageChange] Init CUDA: CPU +4, GPU +0, now: CPU 13133, GPU 1009 (MiB)
[03/02/2024-16:57:03] [TRT] [V] Trying to load shared library nvinfer_builder_resource.dll
[03/02/2024-16:57:03] [TRT] [V] Loaded shared library nvinfer_builder_resource.dll
[03/02/2024-16:57:05] [TRT] [I] [MemUsageChange] Init builder kernel library: CPU +2731, GPU +310, now: CPU 16133, GPU 1319 (MiB)
[03/02/2024-16:57:05] [TRT] [V] CUDA lazy loading is enabled.
DEBUG:torch_tensorrt.dynamo.conversion.converter_utils:Node meta name arg0_1
DEBUG:torch_tensorrt.dynamo.conversion.converter_utils:Node meta name /m/gt
DEBUG:torch_tensorrt.dynamo.conversion.converter_utils:Node meta name /m/mul
DEBUG:torch_tensorrt.dynamo.conversion.converter_utils:Node meta name /m/where
DEBUG:torch_tensorrt.dynamo.conversion.converter_utils:Node meta name output
INFO:torch_tensorrt.dynamo.conversion._TRTInterpreter:TRT INetwork construction elapsed time: 0:00:00.001948
[03/02/2024-16:57:05] [TRT] [V] Original: 7 layers
[03/02/2024-16:57:05] [TRT] [V] After dead-layer removal: 7 layers
[03/02/2024-16:57:05] [TRT] [V] Graph construction completed in 0.0003945 seconds.
[03/02/2024-16:57:05] [TRT] [V] Running: ConstShuffleFusion on /m/gt_rhs
[03/02/2024-16:57:05] [TRT] [V] ConstShuffleFusion: Fusing /m/gt_rhs with /m/gt_rhs_broadcast
[03/02/2024-16:57:05] [TRT] [V] Running: ConstShuffleFusion on /m/mul_rhs
[03/02/2024-16:57:05] [TRT] [V] ConstShuffleFusion: Fusing /m/mul_rhs with /m/mul_rhs_broadcast
[03/02/2024-16:57:05] [TRT] [V] After Myelin optimization: 1 layers
[03/02/2024-16:57:05] [TRT] [V] Applying ScaleNodes fusions.
[03/02/2024-16:57:05] [TRT] [V] After scale fusion: 1 layers
[03/02/2024-16:57:05] [TRT] [V] After dupe layer removal: 1 layers
[03/02/2024-16:57:05] [TRT] [V] After final dead-layer removal: 1 layers
[03/02/2024-16:57:05] [TRT] [V] After tensor merging: 1 layers
[03/02/2024-16:57:05] [TRT] [V] After vertical fusions: 1 layers
[03/02/2024-16:57:05] [TRT] [V] After dupe layer removal: 1 layers
[03/02/2024-16:57:05] [TRT] [V] After final dead-layer removal: 1 layers
[03/02/2024-16:57:05] [TRT] [V] After tensor merging: 1 layers
[03/02/2024-16:57:05] [TRT] [V] After slice removal: 1 layers
[03/02/2024-16:57:05] [TRT] [V] After concat removal: 1 layers
[03/02/2024-16:57:05] [TRT] [V] Trying to split Reshape and strided tensor
[03/02/2024-16:57:05] [TRT] [V] Graph optimization time: 0.0003457 seconds.
[03/02/2024-16:57:05] [TRT] [V] Building graph using backend strategy 2
[03/02/2024-16:57:05] [TRT] [I] Global timing cache in use. Profiling results in this builder pass will be stored.
[03/02/2024-16:57:05] [TRT] [V] Constructing optimization profile number 0 [1/1].
[03/02/2024-16:57:05] [TRT] [V] Applying generic optimizations to the graph for inference.
[03/02/2024-16:57:05] [TRT] [V] Reserving memory for host IO tensors. Host: 0 bytes
[03/02/2024-16:57:05] [TRT] [V] =============== Computing costs for {ForeignNode[/m/gt_rhs + /m/gt_rhs_broadcast...[SELECT]-[aten_ops.where.self]-[/m/where_select]]}
[03/02/2024-16:57:05] [TRT] [V] *************** Autotuning format combination: Float(192,64,8,1) -> Float(192,64,8,1) ***************
[03/02/2024-16:57:05] [TRT] [V] --------------- Timing Runner: {ForeignNode[/m/gt_rhs + /m/gt_rhs_broadcast...[SELECT]-[aten_ops.where.self]-[/m/where_select]]} (Myelin[0x80000023])
[03/02/2024-16:57:05] [TRT] [V] [MemUsageChange] Subgraph create: CPU +0, GPU +0, now: CPU 16136, GPU 1319 (MiB)
[03/02/2024-16:57:05] [TRT] [V]  (foreignNode) Set user's cuda kernel library
[03/02/2024-16:57:05] [TRT] [V] Subgraph compilation completed in 0.141 seconds.
[03/02/2024-16:57:05] [TRT] [V] [MemUsageChange] Subgraph compilation: CPU +58, GPU +0, now: CPU 16194, GPU 1319 (MiB)
[03/02/2024-16:57:05] [TRT] [V] [runner] Allocating resources for 1 graphs.
[03/02/2024-16:57:05] [TRT] [V] Tactic: 0x0000000000000000 Time: 0.0064407
[03/02/2024-16:57:05] [TRT] [V] {ForeignNode[/m/gt_rhs + /m/gt_rhs_broadcast...[SELECT]-[aten_ops.where.self]-[/m/where_select]]} (Myelin[0x80000023]) profiling completed in 0.149506 seconds. Fastest Tactic: 0x0000000000000000 Time: 0.0064407
[03/02/2024-16:57:05] [TRT] [V] >>>>>>>>>>>>>>> Chose Runner Type: Myelin Tactic: 0x0000000000000000
[03/02/2024-16:57:05] [TRT] [V] =============== Computing reformatting costs for available format set
[03/02/2024-16:57:05] [TRT] [V] =============== Computing reformatting costs for available format set
[03/02/2024-16:57:05] [TRT] [V] Formats and tactics selection completed in 0.150114 seconds.
[03/02/2024-16:57:05] [TRT] [V] After reformat layers: 1 layers
[03/02/2024-16:57:05] [TRT] [V] Total number of blocks in pre-optimized block assignment: 1
[03/02/2024-16:57:05] [TRT] [I] Detected 1 inputs and 1 output network tensors.
[03/02/2024-16:57:05] [TRT] [V] Layer: {ForeignNode[/m/gt_rhs + /m/gt_rhs_broadcast...[SELECT]-[aten_ops.where.self]-[/m/where_select]]} Host Persistent: 32 Device Persistent: 0 Scratch Memory: 0
[03/02/2024-16:57:05] [TRT] [V] Skipped printing memory information for 0 layers with 0 memory size i.e. Host Persistent + Device Persistent + Scratch Memory == 0.
[03/02/2024-16:57:05] [TRT] [I] Total Host Persistent Memory: 32
[03/02/2024-16:57:05] [TRT] [I] Total Device Persistent Memory: 0
[03/02/2024-16:57:05] [TRT] [I] Total Scratch Memory: 0
[03/02/2024-16:57:05] [TRT] [V] Total number of blocks in optimized block assignment: 0
[03/02/2024-16:57:05] [TRT] [I] Total Activation Memory: 0
[03/02/2024-16:57:05] [TRT] [I] Total Weights Memory: 0
[03/02/2024-16:57:05] [TRT] [V] Total number of generated kernels selected for the engine: 0
[03/02/2024-16:57:05] [TRT] [V] Disabling unused tactic source: EDGE_MASK_CONVOLUTIONS
[03/02/2024-16:57:05] [TRT] [V] Disabling unused tactic source: JIT_CONVOLUTIONS
[03/02/2024-16:57:05] [TRT] [I] Engine generation completed in 0.152196 seconds.
[03/02/2024-16:57:05] [TRT] [V] Engine Layer Information:
Layer(Myelin): {ForeignNode[/m/gt_rhs + /m/gt_rhs_broadcast...[SELECT]-[aten_ops.where.self]-[/m/where_select]]}, Tactic: 0x0000000000000000, arg0_1 (Float[1,3,8,8]) -> output0 (Float[1,3,8,8])
[03/02/2024-16:57:05] [TRT] [I] [MemUsageStats] Peak memory usage of TRT CPU/GPU memory allocators: CPU 0 MiB, GPU 1 MiB
[03/02/2024-16:57:05] [TRT] [I] [MemUsageChange] TensorRT-managed allocation in building engine: CPU +0, GPU +0, now: CPU 0, GPU 0 (MiB)
[03/02/2024-16:57:05] [TRT] [V] Serializing timing cache. UUID = GPU-84374c83-93ab-0394-cd0d-66acc087082d, commit ID = d6cbd29d5253f99c
[03/02/2024-16:57:05] [TRT] [I] Serialized 52 bytes of code generator cache.
[03/02/2024-16:57:05] [TRT] [I] Serialized 8113 bytes of compilation cache.
[03/02/2024-16:57:05] [TRT] [I] Serialized 0 timing cache entries
INFO:torch_tensorrt.dynamo.conversion._TRTInterpreter:Build TRT engine elapsed time: 0:00:00.153897
INFO:torch_tensorrt.dynamo.conversion._TRTInterpreter:TRT Engine uses: 0 bytes of Memory
[03/02/2024-16:57:05] [TRT] [V] Adding 1 engine(s) to plan file.
DEBUG:torch_tensorrt.dynamo._DryRunTracker:
++++++++++++++++++++++++++++++++++++++++++++++++++ Dry-Run Results for Graph ++++++++++++++++++++++++++++++++++++++++++++++++++

The graph consists of 3 Total Operators, of which 3 operators are supported, 100.0% coverage

Compiled with: CompilationSettings(precision=torch.float32, debug=True, workspace_size=0, min_block_size=1, torch_executed_ops=set(), pass_through_build_failures=False, max_aux_streams=None, version_compatible=False, optimization_level=None, use_python_runtime=False, truncate_long_and_double=False, use_fast_partitioner=True, enable_experimental_decompositions=False, device=Device(type=DeviceType.GPU, gpu_id=0), require_full_compilation=False, disable_tf32=False, sparse_weights=False, refit=False, engine_capability=<EngineCapability.DEFAULT: 0>, num_avg_timing_iters=1, dla_sram_size=1048576, dla_local_dram_size=1073741824, dla_global_dram_size=536870912, dryrun=False, hardware_compatible=False, output_format='exported_program')

  Graph Structure:

   Inputs: List[Tensor: (1, 3, 8, 8)@float32]
    ...
    TRT Engine #1 - Submodule name: _run_on_acc_0
     Engine Inputs: List[Tensor: (1, 3, 8, 8)@float32]
     Number of Operators in Engine: 3
     Engine Outputs: Tensor: (1, 3, 8, 8)@float32
    ...
   Outputs: List[Tensor: (1, 3, 8, 8)@float32]

  ------------------------- Aggregate Stats -------------------------

   Average Number of Operators per TRT Engine: 3.0
   Most Operators in a TRT Engine: 3

  ********** Recommendations **********

   - For minimal graph segmentation, select min_block_size=3 which would generate 1 TRT engine(s)
   - The current level of graph segmentation is equivalent to selecting min_block_size=3 which generates 1 TRT engine(s)
WARNING: [Torch-TensorRT] - Using default stream in enqueue()/enqueueV2()/enqueueV3() may lead to performance issues due to additional cudaDeviceSynchronize() calls by TensorRT to ensure correct synchronizations. Please use non-default stream instead.
C:\Python311\Lib\site-packages\torch\export\exported_program.py:740: UserWarning: Unable to execute the generated python source code from the graph. The graph module will no longer be directly callable, but you can still run the ExportedProgram, and if needed, you can run the graph module eagerly using torch.fx.Interpreter.
  warnings.warn(
(tensor([[[[ 6.2006e-01, -2.9064e-04,  9.8226e-01, -3.8333e-03, -2.1618e-02,
           -1.5738e-02,  2.6443e-01, -1.4374e-02],
          [-1.2791e-02, -1.1879e-02,  4.7439e-01,  6.9313e-01, -1.0766e-02,
            1.3728e+00,  8.3758e-01,  7.4307e-01],
          [-3.5098e-03,  4.5662e-01, -1.6441e-03, -1.5583e-02, -1.3701e-02,
            5.3097e-01, -3.2285e-03, -3.3189e-03],
          [-7.4308e-03, -1.6767e-02,  2.5757e-02,  4.5823e-01,  5.1807e-01,
            1.8787e-01, -1.3362e-02,  6.9791e-01],
          [-2.1611e-02,  1.0629e+00, -2.0338e-02, -1.7173e-03, -3.2053e-03,
            6.8387e-01, -1.0706e-02, -1.0811e-02],
          [-4.3017e-04,  1.4976e+00,  5.9703e-02, -7.9594e-03,  5.5089e-01,
           -8.1892e-03,  2.8588e-01, -1.5868e-02],
          [ 4.8508e-01,  1.1271e+00,  1.7785e+00, -7.4616e-03, -4.5771e-03,
           -1.4308e-02, -4.0018e-03,  3.5549e-01],
          [-5.8241e-03, -3.8064e-03, -5.9313e-04, -1.2990e-02,  3.8060e-01,
            6.4228e-03, -8.0151e-03, -1.0297e-03]],

         [[-7.0621e-03, -2.4972e-02,  2.4519e+00, -1.6451e-04,  4.1318e-01,
           -1.5970e-03,  1.8320e+00, -1.6313e-03],
          [-1.6109e-03,  2.8662e-01,  1.7991e+00, -2.8926e-04, -4.4925e-03,
            1.9756e+00, -1.4357e-03, -2.6023e-02],
          [-1.0665e-02, -1.0338e-03, -8.8272e-03,  1.4398e-01, -4.2988e-03,
           -8.1295e-03,  4.7497e-01, -6.1760e-03],
          [ 4.0540e-01, -1.6224e-02, -6.9385e-04,  6.9263e-01, -1.7464e-03,
            2.4541e-01, -1.2534e-02,  1.0720e+00],
          [-1.0139e-03, -1.1172e-02,  6.7257e-01, -3.4479e-03,  1.3535e+00,
            6.0280e-01, -1.0561e-02,  1.7536e-01],
          [ 2.7637e-01, -6.3729e-03, -4.7551e-03,  9.1582e-02,  5.9293e-01,
           -3.4702e-03, -4.8539e-03,  7.7745e-01],
          [ 4.6169e-01,  1.1525e+00,  4.7898e-02,  5.5210e-01,  6.2328e-01,
            4.1276e-01,  5.5681e-01, -8.6993e-03],
          [-9.9063e-03, -5.2969e-03, -2.0014e-02, -1.3458e-02,  9.3519e-01,
            1.8661e+00,  8.6441e-02, -9.3390e-03]],

         [[ 6.8911e-01, -1.4560e-02,  8.1485e-01,  9.2810e-02, -5.7742e-04,
           -2.2630e-02, -5.7046e-03, -9.1001e-03],
          [-9.7138e-03,  1.0972e+00, -3.4715e-03, -3.4034e-03, -9.6438e-03,
           -4.8049e-04,  1.0703e+00, -1.5452e-02],
          [-9.4251e-03, -1.3537e-03, -1.6299e-02, -9.5506e-03, -5.3317e-04,
           -7.3883e-03,  4.1210e-03, -6.1995e-03],
          [ 3.0561e-02, -7.9463e-03,  5.3772e-01,  1.0653e+00,  1.6256e+00,
            6.9731e-01,  6.4045e-02,  1.5135e+00],
          [ 1.7414e+00,  8.4223e-01,  2.9087e-02,  1.7046e-02,  6.8737e-01,
            2.9057e-01, -1.3581e-03, -1.9831e-02],
          [ 3.6773e-01,  8.3533e-01,  6.4043e-03, -5.6911e-03,  1.5034e-01,
            1.0129e+00,  1.6859e-01,  2.0443e+00],
          [-1.6103e-02,  1.7941e+00,  6.6912e-01, -3.1686e-04,  8.3015e-01,
           -5.2209e-03, -5.9463e-03,  1.7722e+00],
          [-3.0500e-03, -3.5577e-03, -7.3850e-03,  3.5458e-02,  4.7506e-01,
            1.0233e+00,  8.1644e-01, -1.4635e-02]]]], device='cuda:0'),)

Here is the Python wheel built with TensorRT <IP_ADDRESS>.
torch_tensorrt-2.3.0.dev0+741ec5b6b-cp311-cp311-win_amd64.zip

@HolyWu - thank you very much for this information - this is very helpful. I will take a look at your branch as well


Cleanup of workgroups data

We need to clean up and reboot the workgroups. Since subworkgroups were an informal concept that is not reflected in our bylaws/charter, let's skip them (SystemVerilog, RISC-V DV) for now so that they don't clutter up the WG list page. We could reboot them as e.g. SIGs. The meetings of the Subgroups could be listed in the metadata of their parent group.
We should also remove groups that are currently not meeting (Cores, Interconnects) to also reflect the state of affairs better, as well as describe new ones, such as Caliptra.
This data should be presented in the form of MD files with YAML frontmatter. The YAML will be used to render "standard" stuff like WG name, leader, mailing list or meetings (probably should be a list in case a WG has more meetings re: different matters) - and the MD will contain a broader WG description to be pasted as-is. Of course this is just my idea, I welcome criticism especially if trying to implement things this way results in something that's bonkers.
So we need to have:

Chisel
F4PGA
Tools
Caliptra
Analog
Rocket (does this operately from Chisel? need to figure out)

This was done as part of !101


[docs-infra] Move Ads component to TypeScript

Moving all Ads related files to TS before moving them in @mui/docs

Can we revert this?

Yep, that's what I meant with https://github.com/mui/material-ui/pull/42842#discussion_r1677499461. Didn't know Next.js warned on this. Nice feature 🚀 .


Update README.md

let's write that with this plugin you can specify md files as well as regular files in pytest arguments.


Missing +1 in the index return for ITEMS_RollMagicAffixesNew

Also missing a +1.. Otherwise randint < 0 may never succeed and you can end up with an item without affixes.

Good catch thanks! I checked other functions quickly and it seems to be the only place with this issue.


Registry system for MDAEngines and MDAWriters

Problem
Currently there is no way for a GUI to know what MDAEngines (and in the future MDAWriters are installed. This makes it tricky for napari-micromanager to be able to offer a list of writers or engines to be selected by the user.
Potential solution
pymmcore-plus should provide a way for other code to get a list of all valid  MDAEngines (or writers) that are available in the current environment. Something like:
def get_available_engines() -> list["some way to import the engine"]

I think that entry_points are the right way to accomplish this?

How many MDA engines do we imagine existing?  An entry point certainly would be one way to accomplish this, but i feel like this was largely added as a hook specifically for pycromanager.  Are we expected this to be something that lots of people want to hook into?  If so, I think whether that's a good idea to begin with is worth discussion.  At first blush, I'd prefer a more configurable run_mda method, before leaping straight to plugins (which can quickly disperse useful functionality across an ecosystem without a huge amount of benefit)

An entry point certainly would be one way to accomplish this, but i feel like this was largely added as a hook specifically for pycromanager

Oh interesting. I actually considered the primary value of the swappable engines to be supporting extensions on top of the default mda-engine. For example when you want to implement custom behaviors like software autofocus, or in my case controlling non-MM devices. Right now I launch everything from a script so I can set this up, but we're trending towards having less technical users use raman-mda-engine so in an ideal world  they wouldn't have to open up a python interpreter but could just launch napari and be able to select our custom engine (or writers) from there.
That said configuring engines is a bit niche and I was actually writing this mostly with an eye towards a future MDAWriter. We should provide sensible default writers here, but at some point someone will also create custom writers for their own usecases and it would be nice if napari-micro had a way to discover them and offer to select them in a gui element.

what I don't love about fully swapping out the engine with a single run method is that it puts way too much on the engine.  For example, your raman engine also has to emit events in just the right places or it will not truly be "swappable".  In other words run_mda is too complex of a protocol to make for a good plugin.  If it was just two engines (us and perhaps pycromanager) then it's easy to communicate and test... but entry points open it up to anyone.
If we want this to be truly pluggable, I think we need to tighten it up significantly, where the plugin just has to do things like prep_hardware, or acquire, or, indeed, write_image.


Separate and make optional KenLM components

Separates KenLM-related components of Flashlight Text into a separate library: libflashlight-text-kenlm. This library is built when FL_TEXT_USE_KENLM is enabled. In particular, with a shared lib configuration, no KenLM symbols are bundled into libflashlight-text-kenlm.
When building Python bindings, Flashlight Text tries to find kenlm installed via pip (vis-a-vis pip install git@https://github.com/kpu/kenlm). This PR adds machinery to download KenLM headers when building wheels from source but still links to the kenlm installed via pip. This enables dynamically loading a KenLM built from pip by a consuming C++ library from FL Text.
Some other details/changes:

Don't install KenLM headers if not building with it in FL Text.
Adds a new flashlight_lib_text_decoder_kenlm pybind extension.
Moves decoder.py into decoder/__init__.py
The KenLM class in Python bindings now lives in flashlight.lib.text.decoder.kenlm rather than just in decoder.
Since the KenLM installed when building from source with C++/CMake also contains libkenlm_utils (which doesn't exist in the pip installed version), KENLM_DISABLE_UTILS_SEARCH disables searching in Findkenlm for libkenlm_utils since those symbols are all bundled into libkenlm.
If KenLM isn't installed when it should be (or Flashlight Text wheels built without KenLM are used to try to import), things fail with clear telemetry telling the user what's up/how to install KenLM

NB: as above, the import path for KenLM support has changed. It's now:
from flashlight.lib.text.decoder.kenlm import KenLM
# was previously:
from flashlight.lib.text.decoder import KenLM

In order for this to work fully on macOS, https://github.com/kpu/kenlm/pull/413 needs to be merged in because FL Text needs to link at build time with a KenLM dylib and at runtime with the same dylib per portable rpath. Linking with a macOS so bundle at runtime sadly won't work because of how flashlight-text-kenlm was linked.
Test plan: CI, cibuildwheel and local wheel tests across macOS and Linux.
Checklist

[x] Test coverage
[ ] Tests pass
[x] Code formatted
[x] Rebased on latest matter
[x] Code documented

no KenLM symbols are bundled into libflashlight-text-kenlm.

In KenLM.cpp, I see lm::ngram::State and lm::ngram::State are used, so don't they show up as undefined symbols?


Deployment cluster detailed log optimization

The detailed logs of the deployment cluster are too delicate and contain too much useless information.

/kind feature

the log is useful when create cluster fail


Metal is broken again

revert commandbuffer broke metal on real devices (but not on CI due to its metal being software emulated)

before commandbuffer there were LoadOps.SYNC, after commandbuffer it did syncs but revert commandbuffer didn't added syncs back which seems fine for other devices but not for metal where transfers has to be manually synced


Enable gracefull shutdown of node instead of panicing

We shouldn't have panics in production code. We should log the error and return the error.
What would be the risk of continuing to cycle in this loop of getting this error here?
Or we should have some way of gracefully shutting down to avoid data corruption from panics.

Originally posted by @MSevey in https://github.com/rollkit/rollkit/pull/1568#discussion_r1513022360

Hi @tzdybal , can I work on this issue?

I am thinking of lifting the error to top level and handling it there
func (pb *PendingBlocks) getPendingBlocks(ctx context.Context) ([]*types.Block, error, error) {
	lastSubmitted := pb.lastSubmittedHeight.Load()
	height := pb.store.Height()

	if lastSubmitted == height {
		return nil, nil, nil
	}
	if lastSubmitted > height {
		return nil, nil, fmt.Errorf("height of last block submitted to DA (%d) is greater than height of last block (%d)",
		lastSubmitted, height)
	}
	// rest of the code

and the caller would be something like this
blocks, err, haltingErr := m.pendingBlocks.getPendingBlocks(ctx)
if that looks a bit weird, I can try defining a custom error to differentiate between to them.
Or please do let me know if there is any other way, I will look into it @tzdybal .

thanks for reply @tzdybal. that makes sense.
indeed, aside from error handling, a lot of cleanups need to be added to free the memory. If there is a bit more context on this issue, I would love to contribute, Thanks!

Needs investigating: If a panic occurs, how problematic would be to restart? Prioritize based on that. More problematic -> higher priority

Related: https://github.com/rollkit/rollkit/issues/477


Use f_bavail instead of f_bfree to avoid counting 5% reserved space on ext filesystems

Node apps are (hopefully always) run as non-root, so ignoring space reserved for root, like df does, would be preferable.

If you wanna submit a PR I'll happily merge it!

See #6


Update CI Workflows to also test Xcode 14.3.1

I noticed that the CI checks only ran on Xcode 12 and 13 using macOS 11 so thought that it might be good to update this to have a sense-check using Xcode 14 as well.

Thanks for the review @yonaskolb.. I just fixed the build error after i renamed a file in the last commit 🤦


Support env struct tag configs

[x] Env seperator on slices
[x] Slices without a custom env separator
[x] Env prefix for nested structs
[x] Nested structs without an env prefix
[x] Env defaults
[x] Generated value for non-defaults
[x] Skip env expand as its being moved and tbh I don't see myself using it

Fixed in #9


HTML lang is always en regardless of the language section

The editor is always specifying head>lang=en regardless of the language section. This means that Chrome/Edge suggest the user to translate the editor - with terrible consequences.

@abchatra we should this thix.


I don't want a server to be able to select another starboard channel

Hello, I want a server to be able to select only one starboard channel, I used a code like this to do this:
if (
  this.client.starboardsManager.starboards.find(
    s => s.guildID === message.guild.id
  )
) {
  return message.channel.send(
    "<:kirmizitik:802551922783158303> Bu sunucunun zaten starboard kanalını ayarlı, lütfen yeni bir starboard kanalı seçmek için `?starboard-kapat <starboard kanalı>` komutuyla önceden ayarlanmış starboard kanalını devre dışı bırakın!"
  );
}

But that didn't work, so I changed the s.guildID === message.guild.id partition to s.guildID === message.guild.id && s.options.emoji === "⭐", but this time I ran into this error:

How can I solve this?

Here you go :
if(client.starboardsManager.starboards.find(s => s.guildID === message.guild.id)) {
        return message.channel.send('There is already a starboard on this server!');
    }

Can you show your console ?

There is nothing on the console

Mmh that's weird. Can you simply eval this.client.starboardsManager ?

this.client.starboardsManager.starboards:

Mmh everything should work normally then. Do you still have the same error?

Oh yes the problem is fixed, thank you

No problems haha


Bug: m4a files can't be played from the preview pane

Description
m4a files can't play in detail and preview pane. click on play button doing nothing.
Also click on detail tab in properties page make app crash.
Steps To Reproduce

click on m4a file
click on play button in the detail pane

for detail crash:

click on m4a file
click on properties icon on top of pane
click on detail tab
crash!!!

Requirements

e.g. Fix crash that occurs when...
fix crash that occurs when click on properties detail tab
fix bug that m4a files can't be playing in the detail and preview pane

Files Version
<IP_ADDRESS>
Windows Version
10.0.22635.2700
Log File
debug.log

Thanks for the report, I've added this to the project board.

@hishitetsu can you check if it's visible in the preview pane?

This report in AppCenter might be related https://appcenter.ms/orgs/FilesApp/apps/Files/crashes/errors/1720556795u/overview

It is displayed like this.

I don't know why the playback button doesn't show up, but I have found the cause of the crash and will fix it.

@mehrdel2002-hub is this still an issue in v3.0.3?

I have noticed that the controls may or may not show up depending on the environment. It shows up on a Windows 11 23H2 physical machine, but not on a 22H2 VM.

That's strange, it should work across all platforms. We can work around this by removing the custom media preview and just relying on the shell, but unless you enable the classic Windows Media Player, the shell doesn't have any media preview by default.

@mehrdel2002-hub Is this still an issue in the preview version? https://files.community/download/preview


[EN] Feedback for: DevTools - Feature suggestion

Hey @Google,
thanks for building such great tools! I enjoy them every day.
InYou allow go to line numbers by:

Press Ctrl+G
Insert a line number:#LineNumber

What about allowing people to jump directly to functions what line number they ever have:

Press Ctrl+G
Insert part of function name the function name starts with
Instead of search that just jumps to where it is called or defined, this could jump directly to the definition
This would be great when you have single files locally but a merged JS library at the browser
It should support the following patterns:

function #NameOfFunc (…
#NameOfFunc: funtion(
var #NameOfFunc = function(

This seems to be a bug with the DevTools themselves, not the documentation. Please file the bug at https://crbug.com/new instead.


Show which player moves next

At this moment, the players can't know who plays next.
So it would be quite useful if somewhere on the screen shows who plays next.

Please assign this problem

Sure :thumbsup:

Check out my PR

I have also created a PR. Please have a look. Using Cursor indicator.

I would like to add this feature.

Show which player moves next #8

Show which player moves next


4 testing needed

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Added displayname to returned component

Makes things a little better.

FYI the first commit in #19 (6ab88907ad3a83fa29e2ed03578bcefb0842d479) tests the current version of element – you should merge that into this branch and test for this change if possible.

:shipit:


xplat: build-time fixes and enabling runtime features

xplat: library visibility changes [/cc nodejs-chakracore]
osx: enable temp disabled profiling/tracking features
osx: make 10.9 default minimum target [/cc nodejs-chakracore]
xplat: do not static link to libstdc++ (shared)

removed libstdc++ update from the PR but somehow unable to edit merge description..

@dotnet-bot test OSX osx_osx_test_static

:shipit:

@jianchun Thanks for the review!


How to reload static assets in dev mode?

Since Dropwizard supports AssetsBundles, I thought that maybe this would be a quick way to test out them fancy JS frontends (Backbone, Ember, etc.) by throwing them up on src/main/resources/assets and trying to serve from there.  However, I quickly realized that Dropwizard either doesn't reload any of the resources it gets, or I'm missing something on configuring it to reload static assets.
If I were using the Maven Jetty plugin, I'd throw something in the config to use a custom webdefault.xml file as described here for us lowly Windows users: http://docs.codehaus.org/display/JETTY/Files+locked+on+Windows
Is this something I can do in Dropwizard, or is this too far out of scope for the tool?

OK. It is 2015 today. Any solution for this? Every time compiling when changing code in views is really killing time.

I do this by using grunt and a few grunt tasks (grunt-watch, grunt-clean and grunt-copy) to update my assets files in the build directory.
when you have grunt-watch running  all you have to do is make the changes to you assets files and then grunt will replace the files in your build directory so you can just refresh your webpage and get the changes.
I know this isnt a solution to the issue but its a decent work around :)

Here's a solution on DW 0.7.1:

do not use the AssetBundle as you don't have access to all the details (don't worry it's a very tiny Bundle)
Add the AssetsServlet directly from the run method of your Application class
configure the mapping
add the desired initParameter (http://www.eclipse.org/jetty/documentation/current/troubleshooting-locked-files-on-windows.html)
maybe add some way to enable/disbla this, as it's usefull in dev mode, but not in production

Dynamic dynamic = environment.admin().addServlet("assets", new AssetServlet("/website", "/admin-site/", "index.html", Charsets.UTF_8));
dynamic.addMapping("/admin-site/*");
if(devMode){
    dynamic.setInitParameter("useFileMappedBuffer", "false");
}

For Eclipse is good to use Filesync plugin, as it explained here http://www.onehippo.org/library/development/use-filesync-eclipse-plugin-for-faster-turn-around.html

Dynamic dynamic = environment.admin().addServlet("assets", new AssetServlet("/website", "/admin-site/", "index.html", Charsets.UTF_8));
dynamic.addMapping("/admin-site/*");
if(devMode){
    dynamic.setInitParameter("useFileMappedBuffer", "false");
}

Works for me in DW 0.9.
I use this and set my js build tool to copy the bundles into ./target/classes/assets/

Should we always default this parameter to false or make AssetBundle be configurable?

I think it's good for production use, but very annoying for developing with.
Not sure if it should be configurable or not, but maybe DW could use an overall devmode? This has probably been discussed before though.
On the other hand it is part of dropwizard-assets, so it could be fine to add it to AssetBundle?
I'm guess it is something everyone using assets in dropwizard has to deal with.


merging latest Develop branch after fixing vulnerabilities

merging latest Develop branch after fixing vulnerabilities

Please consult https://github.com/IBM/ansible-lifecycle-driver/blob/master/CONTRIBUTING.md
All PRs must be reviewed before merging.
Merging to master should only been done when a release is to be made.


Save export with same filename and location as original.

Save the export file name with the same name as the file.
Save the export in the same folder location as the original file.
Only the extension would be different (.txt, .nfo, etc).

We do that with e.g. BWF MetaEdit, it makes sense to do that with MediaInfo too.
When we have a bit of free time...

Made a PR for this. It'll reduce the amount of clicks and typing required for my use case of export.


Provided Chinese Translations

Translations for Simplified Chinese have been added.

For the standard we are using, please rename the file to ZH.json.
Thanks!

I'll merge and edit it myself, thanks!

excellent


Moonolith-based general interpolation between different meshes [moonolith-dev]

Interface between MFEM and the new Moonolith.
Volume transfer of discrete fields between arbitrarily distributed unstructured finite element meshes.
Superseeds #151.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#315
@zulianp
@tzanio
@vladotomov + @v-dobrev + @bslazarov + @YohannDudouit
10/24/20
⌛due 06/30/21
⌛due 07/07/21

@zulianp will revive and prepare this branch for review.

Can you merge master in this branch and resolve the conflicts?
Once the Travis and Appveyor tests pass, mark the PR with the ready-for-review label.

Make sure you pull master. I do see the conflicts when I do the merge manually...

I see, my luck as always I merged just before it was updated.

LGTM

Hi everyone! Sorry for taking so long. After I came back from deployment it took me a while to get over a large amount of work. I have tried to address all comments and improved the code.
Cheers

Welcome back Patrick!
We will get back to this after the mfem-4.3 release.

Please resolve conflicts.

Hello, Thanks for the feedback, I have addressed all comments. Please let me know if anything else is required.
Cheers

I have addressed most comments with the exception of the parallel RT-FE transfer (see https://github.com/mfem/mfem/pull/315#discussion_r681619773). The main use of this library is with the L2_FECollection, but it would be nice if we could make it work in parallel also for the RT_FECollection. Worst case it can be limited to serial runs for the time being with a failure.

Thanks, I enjoyed the process. We can have eventually a chat about more generalized integration. I will be writing a proposal in September for FSI algorithms, maybe I can fit something in there at least at the algorithmic level, which can then be adapted to MFEM.

@rw-anderson and @v-dobrev -- will you like to review this?

@rw-anderson and @v-dobrev -- will you like to review this?

We do need 1 more review. I'll need more time to review the PR.

Thanks @YohannDudouit for your review, I addressed all comments and applied all the suggested changes :-)

ping: @YohannDudouit

@zulianp  My legendary cmake skills have hit again, I did:
git clone https://bitbucket.org/zulianp/moonolith.git
cd moonolith
mkdir build
cd build
cmake ..

and I get the following error:
 ~/Projects/moonolith/build/> cmake ..
CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

-- The C compiler identification is AppleClang <IP_ADDRESS>00033
-- The CXX compiler identification is AppleClang <IP_ADDRESS>00033
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- [Status] MOONOLITH_ROOT_PATH: /Users/dudouit1/Projects/moonolith/src
-- Found Doxygen: /usr/local/bin/doxygen (found version "1.9.3") found components: doxygen missing components: dot
CMake Error at cmake/FindNETCDF.cmake:176 (else):
  Flow control statements are not properly nested.
Call Stack (most recent call first):
  src/io/CMakeLists.txt:27 (find_package)

CMake Warning at src/io/CMakeLists.txt:27 (find_package):
  By not providing "FindNETCDF.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "NETCDF", but
  CMake did not find one.

  Could not find a package configuration file provided by "NETCDF" with any
  of the following names:

    NETCDFConfig.cmake
    netcdf-config.cmake

  Add the installation prefix of "NETCDF" to CMAKE_PREFIX_PATH or set
  "NETCDF_DIR" to a directory containing one of the above files.  If "NETCDF"
  provides a separate development package or SDK, be sure it has been
  installed.

-- Configuring incomplete, errors occurred!

Do you know if the problem is on my side or on your side?

@YohannDudouit Use this code repository instead https://bitbucket.org/zulianp/par_moonolith :-)

@zulianp Am I doing something wrong?
 ~/Projects/mfem/> make pdebug MFEM_USE_MOONOLITH=YES MOONOLITH_PATH=.. -j16
config/defaults.mk:373: /config/moonolith-config.makefile: No such file or directory
make: *** No rule to make target `/config/moonolith-config.makefile'.  Stop.

@zulianp Am I doing something wrong?
 ~/Projects/mfem/> make pdebug MFEM_USE_MOONOLITH=YES MOONOLITH_PATH=.. -j16
config/defaults.mk:373: /config/moonolith-config.makefile: No such file or directory
make: *** No rule to make target `/config/moonolith-config.makefile'.  Stop.

@YohannDudouit
There is a section dedicated to Makefile users here
https://bitbucket.org/zulianp/par_moonolith/src/master/
In short: use make install_all for installing also the moonolith-config.makefile.
Then set the to the directory where you installed the library
MOONOLITH_DIR instead of MOONOLITH_PATH

@zulianp Do you think you can do something about these warnings?
In file included from fem/moonolith/parallel/pmortarassembler.cpp:22:
/usr/local/include/moonolith_redistribute.hpp:140:27: warning: unused variable 'n_incoming' [-Wunused-variable]
            const Integer n_incoming = comm_.i_send_recv_all(send_buffers, recv_buffers, comm_tag);
                          ^
fem/moonolith/parallel/pmortarassembler.cpp:413:13: warning: unused variable 'elem' [-Wunused-variable]
      auto &elem = *space.GetFE(k);
            ^
fem/moonolith/parallel/pmortarassembler.cpp:554:18: warning: unused variable 'global_id' [-Wunused-variable]
      int index, global_id;
                 ^
fem/moonolith/parallel/pmortarassembler.cpp:797:8: warning: unused variable 'skip_zeros' [-Wunused-variable]
   int skip_zeros = 1;
       ^
fem/moonolith/parallel/pmortarassembler.cpp:824:19: warning: unused variable 'src_mesh' [-Wunused-variable]
      const auto &src_mesh = *src.GetMesh();
                  ^
fem/moonolith/parallel/pmortarassembler.cpp:983:20: note: in instantiation of function template specialization 'mfem::Assemble<2>' requested here
      return mfem::Assemble<2>(comm, impl_->source, impl_->destination,
                   ^
fem/moonolith/parallel/pmortarassembler.cpp:825:19: warning: unused variable 'dest_mesh' [-Wunused-variable]
      const auto &dest_mesh = *dest.GetMesh();
                  ^
fem/moonolith/parallel/pmortarassembler.cpp:824:19: warning: unused variable 'src_mesh' [-Wunused-variable]
      const auto &src_mesh = *src.GetMesh();
                  ^
fem/moonolith/parallel/pmortarassembler.cpp:990:20: note: in instantiation of function template specialization 'mfem::Assemble<3>' requested here
      return mfem::Assemble<3>(comm, impl_->source, impl_->destination,
                   ^
fem/moonolith/parallel/pmortarassembler.cpp:825:19: warning: unused variable 'dest_mesh' [-Wunused-variable]
      const auto &dest_mesh = *dest.GetMesh();
                  ^
8 warnings generated.

@zulianp This looks suspicious to me, is it expected?

@zulianp Increasing the destination order makes it worse it seems:

:

@zulianp This looks suspicious to me, is it expected?

@YohannDudouit The elements of the mesh are not affine, maybe that is the reason.  But in principle, it is not supposed to happen. Can you give me the unstructured mesh?

@zulianp There is extra meshes in the mfem/data, here is the unstructured mesh: https://github.com/mfem/data/blob/master/gmsh/v22/unstructured_quad.v22.msh

@YohannDudouit  It will take some time to figure out why these examples are not working (several versions ago... I am sure I did not encounter such issues even for examples like these, so I might have broken something).

@YohannDudouit  the issue is resolved, now it should be more robust for these kinds of examples

@zulianp It looks like there still are problems when increasing the destination order:

@zulianp You missed a warning:
/usr/local/include/moonolith_redistribute.hpp:140:27: warning: unused variable 'n_incoming' [-Wunused-variable]
            const Integer n_incoming = comm_.i_send_recv_all(send_buffers, recv_buffers, comm_tag);
                          ^
1 warning generated.

Fixed it on the moonolith repository

@zulianp It looks like there still are problems when increasing the destination order:

@zulianp It looks like there still are problems when increasing the destination order:

Ouch. It seems that the problem is not the mesh though but higher order. I tried also the standard quad mesh I get the same problem. I will take me some time to guess what went wrong with the changes.

@YohannDudouit it was good that you tried with that mesh, now everything is definitely better. Here is a summary of the changes

Variational transfer extended to non-affine elements with linear faces.

When performing quadrature on elements with nonlinear transformation, small local numerical errors create unwanted mass contributions in the coupling operator. The problem is typically removed if also the mass matrix uses the same quadrature points.

More control over the number of iterations of mass matrix inversion.
Fixed quadrature order, which for non-simplicial elements would be underestimated in certain cases.

Works up to destination order 8:

@zulianp I think I found a last bug in ex2p in 3D:

@zulianp The error seems very localized:

@YohannDudouit , That looks like a tough mesh :-). But a very good robustness test. I will work on it in the next few weeks

@zulianp I saw you pushed some commits? Is it good now?

@YohannDudouit, Yes.  I believe this example you ran, is the limit case for my code.  As you can see in the picture, it is able to handle it now. But other variants of this technique might be required in the future in order to graciously handle such non-standard scenarios. I extended the documentation to include these limitations.

I

Thanks @zulianp for adding this!

Thank you for taking the time for reviewing :-)

Merged in next for testing...

@zulianp -- I made a few small adjustments in https://github.com/mfem/mfem/pull/315/commits/b71568dac9d941a22e5b6ce11801c4c03351475e, can you take a look and check you are OK with them?
Also -- any chance we can remove the fem/moonolith/parallel directory and just have the pmortarassembler files in fem/moonolith?

Thank you @zulianp. If all nightly tests pass, I will merge it tomorrow.

Thanks to you @tzanio.  :-)

Thanks! It was my pleasure, I enjoyed the process and learned much.  :-)
I am available for advertising and understanding if and what eventual extensions might be interesting or useful to a wider audience.


v0.0.3 to v1.0.0

Description

Closes: #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
PR review checkboxes:
I have...

[ ] added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] included the correct type prefix in the PR title
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link in the PR description to the relevant issue or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all required CI checks have passed

Code maintenance:
I have...

[ ] written unit and integration tests
[ ] added relevant godoc and code comments.
[ ] updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed all author checklist items have been addressed
[ ] confirmed that this PR does not change production code

Codecov Report

Merging #71 (90ea944) into release/v1.0.0 (fde9fb6) will increase coverage by 60.47%.
The diff coverage is 38.88%.

@@                 Coverage Diff                 @@
##           release/v1.0.0      #71       +/-   ##
===================================================
+ Coverage           20.58%   81.06%   +60.47%
===================================================
  Files                 174      127       -47
  Lines               31981     7244    -24737
===================================================
- Hits                 6584     5872      -712
+ Misses              25226     1231    -23995
+ Partials              171      141       -30

Impacted Files
Coverage Δ

app/export.go
13.19% <0.00%> (ø)

app/forks.go
0.00% <0.00%> (ø)

app/sigverify.go
78.94% <ø> (ø)

types/utils.go
80.00% <ø> (ø)

x/feesplit/types/codec.go
100.00% <ø> (ø)

app/app.go
84.88% <35.48%> (-0.17%)
:arrow_down:

x/feesplit/types/msg.go
100.00% <100.00%> (ø)

app/test_helpers.go

cmd/pointd/init.go

cmd/pointd/migrate.go

... and 44 more


Consider tagging a new release

Hey, I'm trying to build for the Omega2 Onion computer, and thus need commit 37ebe0bfb0eb56e777e0903bd2260b4c13cab323. Would it be possible to tag a new release so that I would get the updated version? Thanks! ☺

Sure thing, done now!


fix: use default branch when openedx.org/release annotation is empty

The bug is hard to detect.
The tool shows the correct count of repos to be cut but the result list lacks repos with null values in openedx.org/release annotation.
Find commits  : 100%|█████████████████████████| 45/45 [00:33<00:00,  1.36it/s]

Without the fix (41):
openedx/aspects-dbt
openedx/course-discovery
openedx/credentials
openedx/cs_comments_service
openedx/docs.openedx.org
openedx/ecommerce-worker
openedx/ecommerce
openedx/edx-documentation
openedx/edx-notes-api
openedx/edx-platform
openedx/enterprise-access
openedx/enterprise-catalog
openedx/enterprise-subsidy
openedx/event-bus-redis
openedx/frontend-app-account
openedx/frontend-app-authn
openedx/frontend-app-communications
openedx/frontend-app-course-authoring
openedx/frontend-app-discussions
openedx/frontend-app-ecommerce
openedx/frontend-app-gradebook
openedx/frontend-app-learner-dashboard
openedx/frontend-app-learner-record
openedx/frontend-app-learning
openedx/frontend-app-ora-grading
openedx/frontend-app-ora
openedx/frontend-app-payment
openedx/frontend-app-profile
openedx/frontend-app-publisher
openedx/frontend-app-support-tools
openedx/frontend-plugin-framework
openedx/license-manager
openedx/openedx-app-android
openedx/openedx-app-ios
openedx/openedx-demo-course
openedx/openedx-test-course
openedx/platform-plugin-aspects
openedx/testeng-ci
openedx/tutor-contrib-aspects
openedx/xblock-skill-tagging
openedx/xqueue

With fix (45):
openedx/aspects-dbt
openedx/axim-engineering
openedx/course-discovery
openedx/credentials
openedx/cs_comments_service
openedx/docs.openedx.org
openedx/ecommerce-worker
openedx/ecommerce
openedx/edx-documentation
openedx/edx-lint
openedx/edx-notes-api
openedx/edx-platform
openedx/enterprise-access
openedx/enterprise-catalog
openedx/enterprise-subsidy
openedx/event-bus-redis
openedx/frontend-app-account
openedx/frontend-app-authn
openedx/frontend-app-communications
openedx/frontend-app-course-authoring
openedx/frontend-app-discussions
openedx/frontend-app-ecommerce
openedx/frontend-app-gradebook
openedx/frontend-app-learner-dashboard
openedx/frontend-app-learner-record
openedx/frontend-app-learning
openedx/frontend-app-ora-grading
openedx/frontend-app-ora
openedx/frontend-app-payment
openedx/frontend-app-profile
openedx/frontend-app-publisher
openedx/frontend-app-support-tools
openedx/frontend-plugin-framework
openedx/frontend-template-application
openedx/license-manager
openedx/openedx-app-android
openedx/openedx-app-ios
openedx/openedx-demo-course
openedx/openedx-test-course
openedx/platform-plugin-aspects
openedx/repo-tools
openedx/testeng-ci
openedx/tutor-contrib-aspects
openedx/xblock-skill-tagging
openedx/xqueue

Thanks for the pull request, @cmltaWt0! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.

@kdmccormick @feanil
This is a proposed change to use default branch  when we have a null values in openedx.org/release annotation.

Closing the PR as we decided that the current behaviour is desired.

@cmltaWt0 Even though your pull request wasn’t merged, please take a moment  to answer a two question survey so we can improve your experience in the future.


add map pan-to transitions on marker click so center on selected marker

Testing to see if tests will run when the branch is on the upstream repo instead of forked
Description
This was pretty easy! Hooks + ReactMapGL FTW. I ended up being able to have it animate to a selected marker way easier than I thought.
NB: Will need to merge changes from #13 after that is merged. Figured I'd want you to check it out one more time after pushing more changes (albeit minor ones!)
Closes #9

I regression tested the preview build, and this works well. I'm not as experienced with hooks as @gavinsharp, so I asked him to take a look. I think the suggestion to use useEffect makes sense, but I also don't think we need to block merging this change if you don't have time to make that fix yourself.


Update and rewrite JSDoc reference

New tags @override, @implements, @author.
New features in @template.
Improved support for @template in classes and types.
Divide into more categories (types, classes, documentation, other)
Clearer wording and formatting in many places.
A few corrections.

I love it, it's a super solid improvment


[E2B-464] JS SDK - Reject promises the correct way

Describe the bug
We're returning string in some places instead of Error.
E2B-464

Solved by 3d33cba2


What is the flutter alternate for Android's WebView.settings.domStorageEnabled ?

I'm not familiar with that API. However, you can expose anything you need to through a plugin.


WOWZA video stream rotated

I am creating the session with these configuration.
mSession = SessionBuilder.getInstance()
.setCallback(this)
.setSurfaceView(mSurfaceView)
.setPreviewOrientation(90)
.setContext(getApplicationContext())
.setAudioEncoder(SessionBuilder.AUDIO_NONE)
.setAudioQuality(new AudioQuality(16000, 32000))
.setVideoEncoder(SessionBuilder.VIDEO_H264)
.setVideoQuality(new VideoQuality(640,480,30,500000))
.build();
I can see the preview properly but in the browser its rotated. How can set the proper orientation

Depends on the device.
For example nexus 6 with 5.1 has a known issue on the front cam being upside down:
http://forum.xda-developers.com/nexus-6/help/facing-camera-upside-inverted-t2953530

I am also getting the rotated stream on wowza .I have adjusted the orientation by detecting the display rotation on the device ,preview is correct on device but its giving rotated  wowza stream.Any one having any clue?

Most devices that I tested against (30+) do not present this issue.
For anyone that has this issue, please post device name and android OS so that others can plan around faulty devices.

Moto G with Lolipop OS is one of such device.


Symbol builder fails to import global data

If you set "AutoImportSymbols = true" for an underlying PRIVATE PDB with global data, any of the global data is not imported correctly because the importer does not handle the "DataIsGlobal" data kind.

This should be fixed after PR #92


update unit testing

-hpe() unit testing is unclear and possibly not stable
-double check the hpb() unit tests

-updated hpe() unit testing to help the p argument not crash things
-hpb() now also has tests that the relevant parameters are plausible for the supplied data
-likely not the final update for unit testing / argument parsing


Notifications does not work on windows 7

According to electron documentation Notification api does not work on Windows7, it has to use Tray baloon api.
Is it possible to implement baloon notifications ? It would most propably require work also on standard website.

@alkuzad As of now only native notifications works in our app. I think we could implement balloon notifications for Windows7.

@alkuzad we could use node-notifier.

@akashnimare but as current code relies on the web code it is not doable right ? The web code should then use wrapper over Notification create to send event so electron can catch it.

If native notifications works on win7 then we could easily wrap it around electron.

Windows 8.1 - also no desktop notifications for new messages. Only audible.

Here are the few things we need to work on -

Make the native notifications clickable on linux + windows
Add windows 7 + 8 support

I'm waiting and waiting... ;)
I've just made a major upgrade do 1.5.1 and sadly some features (like administration, settings and stream settings) don't work in native Windows client (also message textarea became very small).
I regularly check the electron version, but lack of desktop notofication (on W7 and W8 - most computer in our organization) is really a major drawback :/

Yeah that seems pretty poor; @akashnimare how hard would it be to make this work on W7/W8?

@timabbott it's hard since Electron does not support desktop notifications on windows 7. I guess we have to wait until they fix this issue. @mgrabow1 @alkuzad you can also track it here -
https://github.com/electron/electron/issues/262
https://github.com/electron/electron/issues/8384

I regularly check the electron version, but lack of desktop notifications (on W7 and W8 - most computers in our organization) is really a major drawback :/

@mgrabow1 sorry for not working on this feature. Our primary focus is to make a stable windows app first with some basic features (spellchecker, auto-updates, signed app etc) and then implement desktop notifications(w7/w8), multiple login server etc. Now that we have a stable release v0.5.8, we could look into this feature.
I don't think electron will fix this issue in near future so we gotta implement this on our own. node-notifier and electron-toaster are two possible alternatives which we could use.

Yeah, I agree that it's unlikely Electron will fix this soon.  As a stopgap if those libraries are hard to setup, we could at least make sure the browser-style web notifications work on those platforms.

Thanks for your replies. Some people in my organization (including myself) started using web-based client (for now), but some sceptics are hard to convince that our great IM-replacement doesn't notfiy about new messages ;)
A follow up question - is this notification thing also connected to not changing zulip-electron tray icon after receiving messages? The native client's icon "blinks" with the number of unread messages. Will zulip-electron do that after resolving this issue? (IMHO it would be enough for some time - to me it's more important to know that anone wrote anything than to get rich notifications :)

@akashnimare made comment here: https://github.com/electron/electron/issues/262#issuecomment-280297669

@alkuzad cool. I think electron-toaster + electron-notification-shim could resolve this issue.
Last time I checked electron-notification-shim, it used to create double notifications. I'll have to figure out how to delete the native notifications first and then implement notifications using this module 😅

We switched to Rocket.Chat

Just curious, any particular reason for switching?

@akashnimare I personally like zulip more as it has a lot cleaner interface, more compact which is better for bigger companies. But RC is easy to setup with ready docker containers where Zulip warns everywhere that stepping outside Vagrant (which is dead cause real working VM managers costs lots of money and docker works on every modern linux for free) will be painful.
Stepping outside Ubuntu is painful too (i.e Centos instructions doesn't mention installing redis first, when Ubuntu ones does).
So this is why we have one blessed config that goes around teams that "just works", no one managed to install Zulip without it.
Also being able to just ctrl+c, ctrl+v screenshot is a big deal, with zulip I had to go via disk always.
@akashnimare I personally like zulip more as it has a lot cleaner interface, more compact which is better for bigger companies. But RC is easy to setup with ready docker containers where Zulip warns everywhere that stepping outside Vagrant (which is dead cause real working VM managers costs lots of money and docker works on every modern linux for free) will be painful.
Stepping outside Ubuntu is painful too (i.e Centos instructions doesn't mention installing redis first, when Ubuntu ones does).
So this is why we have one blessed config that goes around teams that "just works", no one managed to install Zulip without it.
Also being able to just ctrl+c, ctrl+v screenshot is a big deal, with zulip I had to go via disk always.

@alkuzad thanks, we'll take a note on this. cc @timabbott @showell

is this notification thing also connected to not changing zulip-electron tray icon after receiving messages?

@mgrabow1 could you please open a new issue for this? Unread counts support is added in OSX only.

As of now, Electron does not support it but I think there might be other ways to achieve the same.

@akashnimare sure, no problem.
Reported as #110

Windows 7 notification will be implemented once this PR gets merged
https://github.com/electron/brightray/pull/279 🙇

Windows 7 desktop notification support has been added and will be pushed in next release. Thanks, @alkuzad, @mgrabow1.