Strange scrolling behavior - all content of the FloatingPanel is scrolling

Introduction
First of all, thank you for your library - it's a huge work that deserves respect 💪🏻
I will be glad if you help me figure out the problem ❤
📓 Description
During the migration from v1.x to v2.8.2 I've found a strange behavior.
When I scroll through the tableView, which is in the FloatingPanel's content VC, the elements not related to the tableView are scrolled too and its animation differs from the contents of the tableView.

[!NOTE]
An interesting thing: if you set the absoluteInset to not to unequal to zero, then everything works fine.

[!NOTE]
If you scroll the FloatingPanel when the move animation has not ended, then the same behavior. But even it breaks the solution with absoluteInset > 0.

ℹ Expected behavior

The tableView’s content (scroll view) scrolls
Header (not subview of the table view) doesn’t scroll

⚠ Actual behavior

The tableView’s content (scroll view) scrolls
Header (not subview of the table view) scrolls

🧑🏻💻 Steps to reproduce
I've created the simple app for testing, which includes:

The RootViewController.

Code of the RootViewController

class RootViewController: UIViewController {

    override func viewDidLoad() {
        super.viewDidLoad()
    }
}

The EmbeddedViewController which stored in the RootViewController and have all constraints as zero to safeArea.
It also stores the FloatingPanelController.

Code of the EmbeddedViewController

class EmbeddedViewController: UIViewController {

    private var floatingPanelController: TestFloatingPanelController!

    override func viewDidLoad() {
        super.viewDidLoad()

        view.backgroundColor = .purple

        floatingPanelController = MyFloatingPanelController()

        floatingPanelController.addPanel(toParent: self)
    }
}

The MyFloatingPanelController which implements the FloatingPanelController. With basic realization.

Code of the MyFloatingPanelController

private enum Constants {

    enum PositionInset {

        static let full: CGFloat = 0
        static let tip: CGFloat = 53
    }
}

final class MyFloatingPanelController: FloatingPanelController {

    let contentVC: PanelContentViewController

    init() {
        self.contentVC = PanelContentViewController()
        super.init(delegate: nil)
        delegate = self
        setUpPanel()
    }

    required init?(coder aDecoder: NSCoder) {
        fatalError("init(coder:) has not been implemented")
    }

    private func setUpPanel() {
        contentMode = .fitToBounds
        self.set(contentViewController: contentVC)
        self.track(scrollView: contentVC.tableView)
    }
}

extension MyFloatingPanelController: FloatingPanelControllerDelegate {

    func floatingPanel(
        _ vc: FloatingPanelController,
        layoutFor newCollection: UITraitCollection
    ) -> FloatingPanelLayout {
        return MyPanelLayout()
    }
}

final class MyPanelLayout: FloatingPanelLayout {

    var position: FloatingPanelPosition {
        return .bottom
    }

    var initialState: FloatingPanelState {
        return .tip
    }

    var anchors: [FloatingPanelState: FloatingPanelLayoutAnchoring] {
        return [
            .full: FloatingPanelLayoutAnchor(
                absoluteInset: Constants.PositionInset.full,
                edge: .top,
                referenceGuide: .safeArea),
            .tip: FloatingPanelLayoutAnchor(
                absoluteInset: Constants.PositionInset.tip,
                edge: .bottom,
                referenceGuide: .safeArea)
        ]
    }
}

The PanelContentViewController with basic tableView and header arranged by StackView.

Code of the PanelContentViewController

class PanelContentViewController: UIViewController {

    let tableView: UITableView = {
        let tableView = UITableView()
        tableView.backgroundColor = .yellow
        tableView.translatesAutoresizingMaskIntoConstraints = false
        return tableView
    }()

    private let headerLabel: UILabel = {
        let label = UILabel()
        label.text = "Table Header"
        label.textAlignment = .center
        label.backgroundColor = .lightGray
        label.translatesAutoresizingMaskIntoConstraints = false
        return label
    }()

    private let data = [
        "Item 1",
        "Item 2",
        "Item 3",
        "Item 4",
        "Item 5",
        "Item 6",
        "Item 7",
        "Item 8",
        "Item 9",
        "Item 10",
        "Item 11",
        "Item 12",
        "Item 12",
        "Item 12",
        "Item 12",
        "Item 12",
        "Item 12",
        "Item 12",
        "Item 12",
        "Item 12",
        "Item 12"
    ]

    override func viewDidLoad() {
        super.viewDidLoad()

        view.backgroundColor = .green

        tableView.delegate = self
        tableView.dataSource = self
        tableView.register(UITableViewCell.self, forCellReuseIdentifier: "cell")

        let stackView = UIStackView(arrangedSubviews: [headerLabel, tableView])
        stackView.axis = .vertical
        stackView.spacing = 8
        stackView.translatesAutoresizingMaskIntoConstraints = false

        view.addSubview(stackView)

        NSLayoutConstraint.activate([
            stackView.topAnchor.constraint(equalTo: view.topAnchor),
            stackView.leadingAnchor.constraint(equalTo: view.leadingAnchor),
            stackView.trailingAnchor.constraint(equalTo: view.trailingAnchor),
            stackView.bottomAnchor.constraint(equalTo: view.bottomAnchor)
        ])

        headerLabel.heightAnchor.constraint(equalToConstant: 60).isActive = true
    }
}

extension PanelContentViewController: UITableViewDelegate, UITableViewDataSource {

    func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
        return data.count
    }

    func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
        let cell = tableView.dequeueReusableCell(withIdentifier: "cell", for: indexPath)
        cell.textLabel?.text = data[indexPath.row]
        return cell
    }

    func tableView(_ tableView: UITableView, heightForRowAt indexPath: IndexPath) -> CGFloat {
        return UITableView.automaticDimension
    }
}

🧑🏻💻 Source code
You can test this app manually:
With version 2.8.2
TestFloatingPanel.zip
With version 1.7.6
TestFloatingPanel.zip
❓How do you display panel(s)?

Add as child view controllers

❓ How many panels do you displays?

1

Screenshots

Now (v2.8.2)
Was (v1.7.6)

🧰 Environment
🔢 Library version
⛏ Installation methods

Swift Package Manager

[!NOTE]
Also checked when adding locally

📱 iOS version(s)

iOS 15.0-17.4

💻 Xcode version(s)

Xcode 15.2-15.3

Thank you for your report and comment :) I'll check this with the attached source code.

@JelliedFish
Thanks to your report, I could fix it. The fix has been merged into the master branch already. I'm going to release it in version 2.8.4.
Additionally, I found the problem in TestFloatingPanel is that the animation around .tip state is choppy. I’ve also encountered this same issue before, but it was not on the library side. This can be fixed with the following patch to change the AutoLayout priority. Thanks.
diff --git a/TestFloatingPanel/PanelContentViewController.swift b/TestFloatingPanel/PanelContentViewController.swift
index b218448..ec56cf4 100644
--- a/TestFloatingPanel/PanelContentViewController.swift
+++ b/TestFloatingPanel/PanelContentViewController.swift
@@ -73,8 +73,9 @@ class PanelContentViewController: UIViewController {
             stackView.bottomAnchor.constraint(equalTo: view.bottomAnchor)
         ])

-        headerLabel.heightAnchor.constraint(equalToConstant: 60).isActive = true
-
+        let const = headerLabel.heightAnchor.constraint(equalToConstant: 60)
+        const.priority = .defaultLow
+        const.isActive = true
     }
 }

@scenee
Thank you very much for the reply ! Your decision helped a lot and fixed previous problem ! 😎

[!NOTE]
Also thank u very much for helping with the "animation around .tip state" ❤

I wanted to close the bug, but decided to wait for the updated version to be tested ⏳
However, over time, I noticed a new bug, bro  ☹
It's not as explicit as the last one and It's not so easy to reproduce. But users of our app noticed it 👀
I began to study and was able to reproduce it in the same test app.
ℹ Expected behavior

The tableView’s content (scroll view) scrolls
Header (not subview of the table view) doesn’t scroll

⚠ Actual behavior

The tableView’s content (scroll view) scrolls
Header (not subview of the table view) scrolls

[!Important]
I will be able to reproduce the error only if the number of items in the table did not exceed the screen size. But maybe it doesn't matter.

🧑🏻💻 Steps to reproduce
I've updated a bit the testing app from the PR description.
I've added the TopViewController. The EmbeddedViewController also stores the Floating Panel. The application has only changed by:

Added extra VC
All tableView objects on the screen

You can install it manually from here: TestFloatingPanel.zip

[!Tip]
To reproduce this error, I advise you to scroll the entire Floating Panel up and when it is at the top try to scroll up again. Sometimes it goes behind the screen.

❓How do you display panel(s)?

Add as child view controllers

❓ How many panels do you displays?

1

Screenshots

OK (v2.8.5)
Not OK (v2.8.5)

🧰 Environment
🔢 Library version
2.8.5
⛏ Installation methods

Swift Package Manager

[!NOTE]
Also checked when adding locally

📱 iOS version(s)

iOS 15.0-17.4

💻 Xcode version(s)

Xcode 15.2-15.4

Thank you for your patience. I'll take a look for the new issue later.

I've created a patch, #652 for the 2nd issue.


Refactor GtGemStoneSession code sync management

Move code sync management to a separate object in GtGemStoneSession.

GtGemStoneSessionCodeSync now holds the code sync state for the session.
See https://github.com/feenkcom/gt4gemstone/commit/bd42d5eca3411754d322489f79dd3eef29b22c6a


pug script block syntax issue

VSCode Version: 1.13.1
OS Version: Debian 9

Steps to Reproduce:

Reproduces without extensions: Yes

Please file this in the appropriate extension repository.
https://marketplace.visualstudio.com/search?term=pug&target=VSCode&category=All categories&sortBy=Relevance

the pug extension is builtin extension,
I can't find in
https://marketplace.visualstudio.com/search?term=pug&target=VSCode&category=All categories&sortBy=Relevance


Predefine errors returned by the library code

In order to avoid code like:
strings.Contains(err.Error(), "Registration key is already in use")
every error returned by the library should be predefined as var, see for example https://golang.org/pkg/net/http/#pkg-variables

ACME spec has lots of errors, many more than net/http.
What if we had something like this instead:
type Error struct {
  Code string
  Message string
}

func (e *Error) Error() string { ... }

And, of course, we can expose all error codes ACME defines as constants.
Otherwise, I don't mind creating error vars either.
Let me check the spec to verify how many errors there are exactly...

If we can't get all as consts (ideal) then we can instead have "kinds" of errors that are reasonable for clients to act upon https://letsencrypt.github.io/acme-spec/#rfc.section.5.4
Where do you see more errors defined than net/http ?

Wait, I didn't realize we already have goacme.Error type!
Anyway, coming back to the errors, given that error table posted in the spec, how would this acme client identify Registration key is already in use? It's not in the table.

Yes, I do agree the protocol is a bit broken here. Maybe there is some HTTP code in that case that let us derive this situation.
I agree that to start with this different problems: https://github.com/letsencrypt/boulder/blob/master/probs/probs.go
when we look at the usage: https://github.com/letsencrypt/boulder/blob/master/wfe/web-front-end.go#L492
if I would be able to say goacme.IsConflict(err) then it would be enough in context of new-reg to render registration key already in use flow. I am not entirely sure if what I proposed is the right method (golang wise) for distinguishing between errors.

Right. I see, they're actually checking account existence by making additional round trip before new-reg. If feels like a caller of client.Register would be a better fit for this additional functionality, wouldn't you agree?
The reason I haven't predefined the errors is because they have two fields: type and detail. The type is predefined in that table you linked to, but detail is not, so it can't be a constant.
Of course, we could predefine those errors nonetheless and use that same table to populate the detail field, but then callers of the client will loose real error response messages from a CA server.
Anyway, I have an idea. Let me create a pull request to show what I mean.

Fixed by #21


[FEP] Upgrade to FEP plugins

Try out the new plugins system for Personalization/Experimentation. It should streamline the authoring experience a bit and fasten things up by removing the dependency on manifest files. It should hopefully allow our project to start running experimentations on top of personalizations.
Resolves: https://jira.corp.adobe.com/browse/MWPW-147091
Test URLs:

Before: https://stage--express--adobecom.hlx.page/drafts/jingle/plugins
After: https://fep-plugins--express--adobecom.hlx.page/drafts/jingle/plugins

as we decide to move to MEP rather than FEPv2, this PR can be closed


Add a cli parameter to -validate a Caddyfile. Issue #1328

This seems to be a straightforward implementation of #1328 .
I created a new flag -validate which will simply exit after the Caddyfile is parsed.
If Caddyfile is valid will log

[INFO] Caddyfile Valid

otherwise if Caddyfile is not valid the system will output an error as usual.
Questions?

Should a value other than 0 be returned from
os.Exit(0);

if the caddyfile is not valid?

Also validate will output even if -log is not present.   I assume this is the desired behaviour.

I couldn't see any tests for flags, so I didn't add one.

Also, to address some of your questions, here's my take on -validate:

If the Caddyfile is "valid", exit code 0 and don't print anything. (I am not sure how useful logging an info message would be, either. Let's not do that unless we get specific requests with good reasons for it.)

If the Caddyfile is not valid, exit code 1 with the error message.

Don't worry about flags for now.

@mholt I have this working now in a different manner.
However there is a difficulty in that caddy.executeDirectives will attempt to retrieve TLS certs via acme if required.  I don't think this is expected with the  -validate flag.
Do you have a suggestion for how to avoid this?

@mholt executeDirectives seems to be very abstract and runs through all directives executing them.  I am unsure if there is a straightforward way to prevent the tls code from being run.

Maybe we can extract some of executeDirectives out into a separate function -- the inside loop over the server blocks -- and then skip the part that does the directive callbacks. We could pass another argument to executeDirectives so that if it's false, it doesn't execute the callbacks.
Would that work?

I'll take a look and see if that does the trick

This seems to work well.  I have done some basic testing by creating various server blocks and creating errors and seems to all be reported the same way with -validate and without.
ValidateAndExecuteDirectives is a new function that is exported.  I have added the justValidate parameter to the executeDirectives function.  I will add a PR to caddyserver.com repo with update to documentation

Added PR for caddyserver.com update https://github.com/caddyserver/caddyserver.com/pull/103

Thanks so much!


Import Failed while installing through manager

I apologize in advance for my lack of computer knowledge (especially linux, which I am new to).
I was trying to install ComfyUI-3D-Pack through comfyui manager, but I have been getting errors and was not able to.
I am not sure if any of the setup I have is causing the problem, especially since I installed my version of ComfyUI through Pinokio on Linux Mint 21.3 (which I believe is Ubuntu 22.04.3).
I am using Nvidia RTX4080 with Intel CPU.
I would highly appretiate it if someone could guide me through resolving the situation.
The following is the terminal log on bootup:
<<PINOKIO SHELL>>eval "$(conda shell.bash hook)" && conda deactivate && conda deactivate && conda deactivate && conda activate base && source /home/sephia/pinokio/api/comfyui.git/app/env/bin/activate /home/sephia/pinokio/api/comfyui.git/app/env && python main.py --disable-xformers
[START] Security scan
[DONE] Security scan
## ComfyUI-Manager: installing dependencies done.
** ComfyUI startup time: 2024-07-23 22:17:34.343217
** Platform: Linux
** Python version: 3.10.14 | packaged by conda-forge | (main, Mar 20 2024, 12:45:18) [GCC 12.3.0]
** Python executable: /home/sephia/pinokio/api/comfyui.git/app/env/bin/python
** ComfyUI Path: /home/sephia/pinokio/api/comfyui.git/app
** Log path: /home/sephia/pinokio/api/comfyui.git/app/comfyui.log

Prestartup times for custom nodes:
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/rgthree-comfy
   0.4 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/ComfyUI-Manager

Total VRAM 16071 MB, total RAM 31863 MB
pytorch version: 2.3.0+cu121
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 4080 : cudaMallocAsync
Using pytorch cross attention
[Prompt Server] web root: /home/sephia/pinokio/api/comfyui.git/app/web
Workspace manager - Openning file hash dict
🦄🦄Loading: Workspace Manager (V2.1.0)
[comfyui_controlnet_aux] | INFO -> Using ckpts path: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/comfyui_controlnet_aux/ckpts
[comfyui_controlnet_aux] | INFO -> Using symlinks: False
[comfyui_controlnet_aux] | INFO -> Using ort providers: ['CUDAExecutionProvider', 'DirectMLExecutionProvider', 'OpenVINOExecutionProvider', 'ROCMExecutionProvider', 'CPUExecutionProvider', 'CoreMLExecutionProvider']
/home/sephia/pinokio/api/comfyui.git/app/custom_nodes/comfyui_controlnet_aux/node_wrappers/dwpose.py:26: UserWarning: DWPose: Onnxruntime not found or doesn't come with acceleration providers, switch to OpenCV with CPU device. DWPose might run very slowly
  warnings.warn("DWPose: Onnxruntime not found or doesn't come with acceleration providers, switch to OpenCV with CPU device. DWPose might run very slowly")

[rgthree] Loaded 40 fantastic nodes.
[rgthree] Will use rgthree's optimized recursive execution.

Warn!: xFormers is available (Attention)
Warn!: /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/utils/cpp_extension.py:1967: UserWarning: TORCH_CUDA_ARCH_LIST is not set, all archs for visible cards are included for compilation.
If this is not desired, please set os.environ['TORCH_CUDA_ARCH_LIST'].
  warnings.warn(

Warn!: Traceback (most recent call last):
  File "/home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/utils/cpp_extension.py", line 2107, in _run_ninja_build
    subprocess.run(
  File "/home/sephia/pinokio/bin/miniconda/lib/python3.10/subprocess.py", line 526, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['ninja', '-v']' returned non-zero exit status 1.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/sephia/pinokio/api/comfyui.git/app/nodes.py", line 1931, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/sephia/pinokio/api/comfyui.git/app/custom_nodes/ComfyUI-3D-Pack/__init__.py", line 47, in <module>
    module = importlib.import_module(f".{nodes_filename}", package=__name__)
  File "/home/sephia/pinokio/bin/miniconda/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/sephia/pinokio/api/comfyui.git/app/custom_nodes/ComfyUI-3D-Pack/nodes.py", line 78, in <module>
    from Unique3D.scripts.project_mesh import multiview_color_projection, get_cameras_list
  File "/home/sephia/pinokio/api/comfyui.git/app/custom_nodes/ComfyUI-3D-Pack/Gen_3D_Modules/Unique3D/scripts/project_mesh.py", line 98, in <module>
    pix2faces_renderer = Pix2FacesRenderer()
  File "/home/sephia/pinokio/api/comfyui.git/app/custom_nodes/ComfyUI-3D-Pack/Gen_3D_Modules/Unique3D/scripts/project_mesh.py", line 70, in __init__
    self._glctx = dr.RasterizeGLContext(output_db=False, device=device)
  File "/home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/torch/ops.py", line 221, in __init__
    self.cpp_wrapper = _get_plugin(gl=True).RasterizeGLStateWrapper(output_db, mode == 'automatic', cuda_device_idx)
  File "/home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/torch/ops.py", line 118, in _get_plugin
    torch.utils.cpp_extension.load(name=plugin_name, sources=source_paths, extra_cflags=opts, extra_cuda_cflags=opts+['-lineinfo'], extra_ldflags=ldflags, with_cuda=True, verbose=False)
  File "/home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/utils/cpp_extension.py", line 1309, in load
    return _jit_compile(
  File "/home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/utils/cpp_extension.py", line 1719, in _jit_compile
    _write_ninja_file_and_build_library(
  File "/home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/utils/cpp_extension.py", line 1832, in _write_ninja_file_and_build_library
    _run_ninja_build(
  File "/home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/utils/cpp_extension.py", line 2123, in _run_ninja_build
    raise RuntimeError(message) from e
RuntimeError: Error building extension 'nvdiffrast_plugin_gl': [1/4] c++ -MMD -MF glutil.o.d -DTORCH_EXTENSION_NAME=nvdiffrast_plugin_gl -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1011\" -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/torch/csrc/api/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/TH -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/THC -isystem /home/sephia/pinokio/bin/miniconda/include -isystem /home/sephia/pinokio/bin/miniconda/include/python3.10 -D_GLIBCXX_USE_CXX11_ABI=0 -fPIC -std=c++17 -DNVDR_TORCH -c /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/common/glutil.cpp -o glutil.o
FAILED: glutil.o
c++ -MMD -MF glutil.o.d -DTORCH_EXTENSION_NAME=nvdiffrast_plugin_gl -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1011\" -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/torch/csrc/api/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/TH -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/THC -isystem /home/sephia/pinokio/bin/miniconda/include -isystem /home/sephia/pinokio/bin/miniconda/include/python3.10 -D_GLIBCXX_USE_CXX11_ABI=0 -fPIC -std=c++17 -DNVDR_TORCH -c /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/common/glutil.cpp -o glutil.o
In file included from /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/common/glutil.cpp:14:
/home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/common/glutil.h:36:10: fatal error: EGL/egl.h: No such file or directory
   36 | #include <EGL/egl.h>
      |          ^~~~~~~~~~~
compilation terminated.
[2/4] c++ -MMD -MF rasterize_gl.o.d -DTORCH_EXTENSION_NAME=nvdiffrast_plugin_gl -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1011\" -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/torch/csrc/api/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/TH -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/THC -isystem /home/sephia/pinokio/bin/miniconda/include -isystem /home/sephia/pinokio/bin/miniconda/include/python3.10 -D_GLIBCXX_USE_CXX11_ABI=0 -fPIC -std=c++17 -DNVDR_TORCH -c /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/common/rasterize_gl.cpp -o rasterize_gl.o
FAILED: rasterize_gl.o
c++ -MMD -MF rasterize_gl.o.d -DTORCH_EXTENSION_NAME=nvdiffrast_plugin_gl -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1011\" -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/torch/csrc/api/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/TH -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/THC -isystem /home/sephia/pinokio/bin/miniconda/include -isystem /home/sephia/pinokio/bin/miniconda/include/python3.10 -D_GLIBCXX_USE_CXX11_ABI=0 -fPIC -std=c++17 -DNVDR_TORCH -c /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/common/rasterize_gl.cpp -o rasterize_gl.o
In file included from /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/common/rasterize_gl.h:16,
                 from /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/common/rasterize_gl.cpp:9:
/home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/common/glutil.h:36:10: fatal error: EGL/egl.h: No such file or directory
   36 | #include <EGL/egl.h>
      |          ^~~~~~~~~~~
compilation terminated.
[3/4] c++ -MMD -MF torch_rasterize_gl.o.d -DTORCH_EXTENSION_NAME=nvdiffrast_plugin_gl -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1011\" -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/torch/csrc/api/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/TH -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/THC -isystem /home/sephia/pinokio/bin/miniconda/include -isystem /home/sephia/pinokio/bin/miniconda/include/python3.10 -D_GLIBCXX_USE_CXX11_ABI=0 -fPIC -std=c++17 -DNVDR_TORCH -c /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/torch/torch_rasterize_gl.cpp -o torch_rasterize_gl.o
FAILED: torch_rasterize_gl.o
c++ -MMD -MF torch_rasterize_gl.o.d -DTORCH_EXTENSION_NAME=nvdiffrast_plugin_gl -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1011\" -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/torch/csrc/api/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/TH -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/THC -isystem /home/sephia/pinokio/bin/miniconda/include -isystem /home/sephia/pinokio/bin/miniconda/include/python3.10 -D_GLIBCXX_USE_CXX11_ABI=0 -fPIC -std=c++17 -DNVDR_TORCH -c /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/torch/torch_rasterize_gl.cpp -o torch_rasterize_gl.o
In file included from /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/torch/../common/rasterize_gl.h:16,
                 from /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/torch/torch_rasterize_gl.cpp:12:
/home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/torch/../common/glutil.h:36:10: fatal error: EGL/egl.h: No such file or directory
   36 | #include <EGL/egl.h>
      |          ^~~~~~~~~~~
compilation terminated.
ninja: build stopped: subcommand failed.

Warn!: Cannot import /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/ComfyUI-3D-Pack module for custom nodes: Error building extension 'nvdiffrast_plugin_gl': [1/4] c++ -MMD -MF glutil.o.d -DTORCH_EXTENSION_NAME=nvdiffrast_plugin_gl -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1011\" -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/torch/csrc/api/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/TH -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/THC -isystem /home/sephia/pinokio/bin/miniconda/include -isystem /home/sephia/pinokio/bin/miniconda/include/python3.10 -D_GLIBCXX_USE_CXX11_ABI=0 -fPIC -std=c++17 -DNVDR_TORCH -c /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/common/glutil.cpp -o glutil.o
FAILED: glutil.o
c++ -MMD -MF glutil.o.d -DTORCH_EXTENSION_NAME=nvdiffrast_plugin_gl -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1011\" -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/torch/csrc/api/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/TH -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/THC -isystem /home/sephia/pinokio/bin/miniconda/include -isystem /home/sephia/pinokio/bin/miniconda/include/python3.10 -D_GLIBCXX_USE_CXX11_ABI=0 -fPIC -std=c++17 -DNVDR_TORCH -c /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/common/glutil.cpp -o glutil.o
In file included from /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/common/glutil.cpp:14:
/home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/common/glutil.h:36:10: fatal error: EGL/egl.h: No such file or directory
   36 | #include <EGL/egl.h>
      |          ^~~~~~~~~~~
compilation terminated.
[2/4] c++ -MMD -MF rasterize_gl.o.d -DTORCH_EXTENSION_NAME=nvdiffrast_plugin_gl -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1011\" -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/torch/csrc/api/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/TH -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/THC -isystem /home/sephia/pinokio/bin/miniconda/include -isystem /home/sephia/pinokio/bin/miniconda/include/python3.10 -D_GLIBCXX_USE_CXX11_ABI=0 -fPIC -std=c++17 -DNVDR_TORCH -c /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/common/rasterize_gl.cpp -o rasterize_gl.o
FAILED: rasterize_gl.o
c++ -MMD -MF rasterize_gl.o.d -DTORCH_EXTENSION_NAME=nvdiffrast_plugin_gl -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1011\" -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/torch/csrc/api/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/TH -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/THC -isystem /home/sephia/pinokio/bin/miniconda/include -isystem /home/sephia/pinokio/bin/miniconda/include/python3.10 -D_GLIBCXX_USE_CXX11_ABI=0 -fPIC -std=c++17 -DNVDR_TORCH -c /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/common/rasterize_gl.cpp -o rasterize_gl.o
In file included from /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/common/rasterize_gl.h:16,
                 from /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/common/rasterize_gl.cpp:9:
/home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/common/glutil.h:36:10: fatal error: EGL/egl.h: No such file or directory
   36 | #include <EGL/egl.h>
      |          ^~~~~~~~~~~
compilation terminated.
[3/4] c++ -MMD -MF torch_rasterize_gl.o.d -DTORCH_EXTENSION_NAME=nvdiffrast_plugin_gl -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1011\" -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/torch/csrc/api/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/TH -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/THC -isystem /home/sephia/pinokio/bin/miniconda/include -isystem /home/sephia/pinokio/bin/miniconda/include/python3.10 -D_GLIBCXX_USE_CXX11_ABI=0 -fPIC -std=c++17 -DNVDR_TORCH -c /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/torch/torch_rasterize_gl.cpp -o torch_rasterize_gl.o
FAILED: torch_rasterize_gl.o
c++ -MMD -MF torch_rasterize_gl.o.d -DTORCH_EXTENSION_NAME=nvdiffrast_plugin_gl -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1011\" -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/torch/csrc/api/include -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/TH -isystem /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/torch/include/THC -isystem /home/sephia/pinokio/bin/miniconda/include -isystem /home/sephia/pinokio/bin/miniconda/include/python3.10 -D_GLIBCXX_USE_CXX11_ABI=0 -fPIC -std=c++17 -DNVDR_TORCH -c /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/torch/torch_rasterize_gl.cpp -o torch_rasterize_gl.o
In file included from /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/torch/../common/rasterize_gl.h:16,
                 from /home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/torch/torch_rasterize_gl.cpp:12:
/home/sephia/pinokio/api/comfyui.git/app/env/lib/python3.10/site-packages/nvdiffrast/torch/../common/glutil.h:36:10: fatal error: EGL/egl.h: No such file or directory
   36 | #include <EGL/egl.h>
      |          ^~~~~~~~~~~
compilation terminated.
ninja: build stopped: subcommand failed.

WAS Node Suite: OpenCV Python FFMPEG support is enabled
WAS Node Suite Warning: `ffmpeg_bin_path` is not set in `/home/sephia/pinokio/api/comfyui.git/app/custom_nodes/was-node-suite-comfyui/was_suite_config.json` config file. Will attempt to use system ffmpeg binaries if available.
WAS Node Suite: Finished. Loaded 217 nodes successfully.

        "Art is the most powerful tool we have to connect with the world and express our individuality." - Unknown

Total VRAM 16071 MB, total RAM 31863 MB
pytorch version: 2.3.0+cu121
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 4080 : cudaMallocAsync
[Allor]: 0 nodes were overridden.
[Allor]: 12 modules were enabled.
[Allor]: 98 nodes were loaded.
[Crystools INFO] Crystools version: 1.15.0
[Crystools INFO] CPU: 13th Gen Intel(R) Core(TM) i7-13700K - Arch: x86_64 - OS: Linux 5.15.0-116-generic
[Crystools INFO] Pynvml (Nvidia) initialized.
[Crystools INFO] GPU/s:
[Crystools INFO] 0) NVIDIA GeForce RTX 4080
[Crystools INFO] NVIDIA Driver: 535.183.01
### Loading: ComfyUI-Impact-Pack (V5.18.13)
### Loading: ComfyUI-Impact-Pack (Subpack: V0.6)
[Impact Pack] Wildcards loading done.
### Loading: ComfyUI-Manager (V2.48.1)
### ComfyUI Revision: 2393 [0a4c49c5] | Released on '2024-07-23'
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/alter-list.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/model-list.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/github-stats.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/extension-node-map.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json
Efficiency Nodes: Attempting to add Control Net options to the 'HiRes-Fix Script' Node (comfyui_controlnet_aux add-on)...Success!
Efficiency Nodes Warning: Failed to import python package 'simpleeval'; related nodes disabled.

[comfy_mtb] | INFO -> loaded 75 nodes successfuly
[comfy_mtb] | INFO -> Some nodes (5) could not be loaded. This can be ignored, but go to http://<IP_ADDRESS>:8188/mtb if you want more information.

Import times for custom nodes:
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/websocket_image_save.py
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/gcLatentTunnel.py
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/ComfyUI-FBCNN
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/comfyui-yanc
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/masquerade-nodes-comfyui
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/ComfyUI_IPAdapter_plus
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/ComfyUI-Video-Matting
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/Comfyui_joytag
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/ComfyUI-Kolors-MZ
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/ComfyUI_UltimateSDUpscale
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/comfyui-browser
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/Derfuu_ComfyUI_ModdedNodes
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/comfyui-workspace-manager
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/ComfyUI-Allor
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/Comfy_KepListStuff
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/ComfyUI-BrushNet
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/rgthree-comfy
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/efficiency-nodes-comfyui
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/comfyui_tag_fillter
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/ComfyUI-KJNodes
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/comfy_mtb
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/ComfyUI-VideoHelperSuite
   0.0 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/ComfyUI-Manager
   0.1 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/ComfyUI-Impact-Pack
   0.2 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/comfyui_controlnet_aux
   0.4 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/was-node-suite-comfyui
   0.7 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/ComfyUI-Inspyrenet-Rembg
   1.8 seconds (IMPORT FAILED): /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/ComfyUI-3D-Pack
   2.2 seconds: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/ComfyUI-Crystools

Starting server

To see the GUI go to: http://<IP_ADDRESS>:8188
FETCH DATA from: /home/sephia/pinokio/api/comfyui.git/app/custom_nodes/ComfyUI-Manager/extension-node-map.json [DONE]

Hi @manassm
Seems you are missing some CPP header files in your system, you can check Dockerfile to see which library you are missing, but first and formost, make sure you have gcc g++ installed
sudo apt update
sudo apt install gcc g++

Thank you for the help. After a long trial and error, it seems like I made some progress, although I came across with bunch of new issues.
I will explain what I did to resolve it (partially) here for future reference to ask how to resolve the subsequent ones.
0. I am on Linux Mint 22 Cinnamon, and I installed ComfyUI through Pinokio frontend.

First, I installed miniconda (using this link: https://docs.anaconda.com/miniconda/miniconda-install/)
I went to the miniconda3 folder and ran this command: source bin/activate
Then I ran this command: eval "$(conda shell.bash hook)" && conda deactivate && conda deactivate && conda deactivate && conda activate base && source /home//pinokio/api/comfyui.git/app/env/bin/activate /home//pinokio/api/comfyui.git/app/env
(Not sure if it's relevant but) I updated pip using: pip install --upgrade pip
Then I ran: sudo apt update
sudo apt install gcc g++
I did: sudo apt update
sudo apt install mesa-common-dev libegl1-mesa-dev
I deleted and re-installed the 3D-pack extension through comfy manager.

Now I don't have 3D-pack nodes marked red anymore, which I guess means there were some progress.
However, I have new set of problems regarding SF3D and UI, which I will mention on the separate discussion post.
Thank you for help.

6. sudo apt install mesa-common-dev libegl1-mesa-dev

The same issue.It works for me.


Update hip_faq.md, hip_terms2.md and hip_pporting_guide.md

Update HIP document for ROCM v3.5 release

This change has been merged into amd-master-next.

Closing all existing pull requests that do not target the develop branch. In case this pull request is still valid, please rebase your changes against develop branch and resubmit.


Update juliet server settings

Updating the client settings after doing some measurements and advice from @marc-casperlabs .
The rationale is:

we've measured the average round-trip time for sending a juliet request and receiving a response from the sidecar, which averaged around 5ms and varied between 2-10ms
we've measured the average time spent in the code that deals with storage (run_query) and it was about 0.6ms
if we want to saturate the time spent running queries, we'd need to permit at least 4 concurrent requests on average ((average_roundtrip - average_run_query) / 2 / average_run_query), and in the worst case scenario (10ms time and lack of parallelism) we have (10 - 0.6) / 2 / 0.6 which is 8 concurrent requests and we've rounded it up to 10 to create some leeway
the buffer size was set based on the request limit to allow for a backlog size of double the requests we can handle concurrently

We didn't discuss max_request_size_bytes, and max_response_size_bytes, might be worth tackling that as well

bors r+


Sql variant

Opening pull request for code review and testing .

Codecov Report

Merging #356 into dev will increase coverage by 0.54%.
The diff coverage is 40.28%.

@@             Coverage Diff             @@
##                dev    #356      +/-   ##
===========================================
+ Coverage     37.36%   37.9%   +0.54%
- Complexity     1703    1764      +61
===========================================
  Files           103     104       +1
  Lines         23692   24408     +716
  Branches       3885    3982      +97
===========================================
+ Hits           8853    9253     +400
- Misses        13267   13554     +287
- Partials       1572    1601      +29

Flag
Coverage Δ
Complexity Δ

#JDBC41
37.79% <40.28%> (+0.55%)
1757 <24> (+60)
:arrow_up:

#JDBC42
37.88% <40.28%> (+0.65%)
1762 <24> (+67)
:arrow_up:

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/microsoft/sql/Types.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...c/main/java/com/microsoft/sqlserver/jdbc/Util.java
45.39% <ø> (-0.71%)
61 <0> (-1)

...om/microsoft/sqlserver/jdbc/SQLServerResource.java
100% <ø> (ø)
4 <0> (ø)
:arrow_down:

...rc/main/java/com/microsoft/sqlserver/jdbc/TVP.java
44.81% <ø> (ø)
26 <0> (ø)
:arrow_down:

...ava/com/microsoft/sqlserver/jdbc/SQLCollation.java
92.04% <0%> (-0.45%)
12 <0> (ø)

...oft/sqlserver/jdbc/SQLServerSymmetricKeyCache.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...om/microsoft/sqlserver/jdbc/SQLServerMetaData.java
24% <0%> (-0.49%)
0 <0> (ø)

...oft/sqlserver/jdbc/SQLServerResultSetMetaData.java
41.66% <100%> (+0.82%)
24 <0> (+1)
:arrow_up:

...n/java/com/microsoft/sqlserver/jdbc/Parameter.java
33.47% <100%> (+2.09%)
38 <0> (+1)
:arrow_up:

...main/java/com/microsoft/sqlserver/jdbc/Column.java
34.75% <100%> (+1.63%)
34 <2> (+2)
:arrow_up:

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f3c271...cbb8594. Read the comment docs.

Closing this as opened a new one #387


error: linking with rust-lld failed: exit status: 1

I've been working on an ESP32C3 project for teaching purposes these days, driving a MAX7219. I managed to run the program successfully using Wokwi, and the results met my expectations. However, just now when I attempted to modify the program, I encountered a linker error: error: linking with rust-lld failed: exit status: 1.
error: linking with `rust-lld` failed: exit status: 1
  |
  = note: LC_ALL="C" PATH="/home/nan/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/bin:/home/nan/.rustup/toolchains/esp/xtensa-esp-elf/esp-13.2.0_20230928/xtensa-esp-elf/bin:/home/nan/Starry/x86_64-linux-musl-cross/bin:/home/nan/Starry/aarch64-linux-musl-cross/bin:/home/nan/Starry/riscv64-linux-musl-cross/bin:/home/nan/.cargo/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin" VSLANG="1033" "rust-lld" "-flavor" "gnu" "/tmp/rustcnrep65/symbols.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.1jlkzn7ldh32op3.rcgu.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.2buw4crwvhq9nje6.rcgu.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.2lvsvku8426n8fkq.rcgu.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.3cazoqijbyyh7m1i.rcgu.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.3fikxqg8j34xg7i4.rcgu.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.3i5ne9msdh035vki.rcgu.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.3o0y1i8lgd9w1os8.rcgu.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.3ohjnaaw2jhwbx2v.rcgu.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.3slows7puwyt360c.rcgu.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.3vczdnivqqn8bmqv.rcgu.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.3xzpxbr1gxcwuks4.rcgu.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.42wn8eibedqufsxc.rcgu.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.4751i3j46tbyniw5.rcgu.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.4aqa4x352zd9rt1z.rcgu.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.4qupddirgv0lwawo.rcgu.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.4u2fir9efcclqquk.rcgu.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.527fxn0jedf7ono0.rcgu.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.54nouu3kw86jxhnr.rcgu.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.573d4m7y62wpqlel.rcgu.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.6yqsjy6b30ri4vi.rcgu.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.x0h1apogz4lo1xp.rcgu.o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f.zdvluocqsd8d0qz.rcgu.o" "--as-needed" "-L" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps" "-L" "/home/nan/esp-study/target/debug/deps" "-L" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/build/esp-hal-b2bea4621f73b22d/out" "-L" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/build/esp32c3-e185d939e62653d3/out" "-L" "/home/nan/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/riscv32imc-unknown-none-elf/lib" "-Bstatic" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libmax7219-d32051cd9fa12466.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libesp_hal-cc4745234f6086e0.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/librand_core-759f53f680e7464e.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libbitflags-b10e8058817ed062.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libbitfield-eeae49c20f7738f5.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libcfg_if-0dbae98eb2aa6e24.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libesp32c3-57e592ee9212a381.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libvcell-1c4f3eb103f227cb.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libportable_atomic-3ee2983e1d05f192.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libstrum-cbf0d07b6e4a3fab.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libfugit-21ffff1860147e3f.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libgcd-2ae162781653645a.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libembedded_hal-53ae3d2cb8bee00d.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libvoid-ad5182a311850cc4.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libnb-fe67a401971e3abf.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libnb-bb93a6e811eb6679.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libembedded_dma-9585bb5c603a961e.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libstable_deref_trait-8e55a709cd7907ac.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libesp_riscv_rt-183612c35851051b.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libriscv-72bc46641a858912.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libembedded_hal-f04415965d023a61.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libesp_backtrace-cab5dc244eda877d.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libesp_println-c98ccc1faf9a5674.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libcritical_section-e6b7939fd72ac6c2.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/liblog-32c7cb5225574b8d.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/librustc_std_workspace_core-3b893f6d5c5d9c8f.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libcore-771dcf38f1798d00.rlib" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/libcompiler_builtins-8a94013e0e3f4d32.rlib" "-Bdynamic" "-z" "noexecstack" "-L" "/home/nan/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/riscv32imc-unknown-none-elf/lib" "-o" "/home/nan/esp-study/target/riscv32imc-unknown-none-elf/debug/deps/esp_study-043a6560309d231f" "--gc-sections" "-Tlinkall.x" "-Trom_functions.x"
  = note: rust-lld: error: cannot find linker script rom_functions.x

error: could not compile `esp-study` (bin "esp-study") due to 1 previous error

I'm quite confident that this issue stems from an upstream library. After googling, I noticed discussions happening here, but strangely, some suggest a connection between this error and the cortex-m runtime library. This is odd because in theory, ESP32 shouldn't have any association with such issues.
I've uploaded my code here. About two days ago, compiling was fine. So, it's highly likely not related to my code itself.
If it is inappropriate to raise this question here, please let me know, and I will go to the appropriate place.
Thanks for your work.🤎

Seems that removing https://github.com/nan-mu/rust-lld-error/blob/58fce0e13888001a4de7f10f798c68a1187cd8a2/.cargo/config.toml#L12-L13 will resolve the issues.
That line should only be needed for esp-wifi - the linkall.x script includes the ROM functions used by esp-hal already

Thanks a lot, it works in my environment. Unfortunately there is nothing that can be done about this in wokwi, they may not be able to edit the file.

Unfortunately there is nothing that can be done about this in wokwi, they may be not allow user to able to edit the file.

Yes, as you mention, there is no current way of editing this file in Wokwi browser version. You can still simulate your project using Wokwi VS Code extension.


DisplayName

The description on the parameter -DisplayName in https://docs.microsoft.com/en-us/powershell/module/teams/new-teamchannel?view=teams-ps is showing the invalid characters | ' " as a bullet-point. I suspect what you meant was to list the dash as an invalid character but accidentally had it interpreted by your markdown engine as a list item.

@officedocsbot assign @yogkumgit

@kenwith Please merge this PR #4287

@dariomws306  Thank you very much for the contribution and updating the documentation with PR. @Embury1 Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


configured navigation bar

@alap2607 - Please show a different background color on nav-items when user hovers on them. Use the same color you are using for dropdown arrow active state. It should be applied to both nav items and dropdown items.


Supporting webpack

In order to be a webpack-discoverable module, we need to remove the .js suffix in the package.json main attribute. This allows webpack to correctly look for my-module.android.js or my-module.ios.js.
Details here:
http://docs.nativescript.org/angular/tooling/bundling-with-webpack.html#referencing-platform-specific-modules-from-packagejson

Thanks @ignaciolarranaga
Added in 0.1.1.

@ignaciolarranaga I am sorry, this is now fixed in 0.1.2.

np, thanks for the comment.


windows 2016 detected as Windows 2008r2

Description

On AWS cloud EC2 instance Windows server 2016 is detected as Windows 2008r2, and while bootstrapping it always download the old version 13.x of the chef-client not the latest which is 14.x.
Chef Version

14.7.17
Platform Version

Red Hat Enterprise Linux Server release 7.6 (Maipo)
Replication Case

try to bootstrap windows server 2016 on AWS EC2 and the Chef server is running on RHEL.
Client Output

 Detected Windows Version 10.0 Build 14393
 Warning: Unknown version of Windows, assuming default of Windows 2008r2

 C:\Users\Administrator>goto architecture_select

 C:\Users\Administrator>IF "AMD64" == "x86" IF not defined PROCESSOR_ARCHITEW6432

 C:\Users\Administrator>goto install
 Checking for existing downloaded package at "C:\Users\ADMINI~1\AppData\Local\Temp\chef-client-latest.msi"
 No existing downloaded packages to delete.
 Attempting to download client package using PowerShell if available...
 powershell.exe -ExecutionPolicy Unrestricted -InputFormat None -NoProfile -NonInteractive -File  C:\chef\wget.ps1 "https://www.chef.io/chef/download?p=windows&pv=2008r2&m=x86_64&DownloadContext=PowerShell&v=13" "C:\Users\ADMINI~1\AppData\Local\Temp\chef-client-latest.msi"
 Rendering "C:\Users\ADMINI~1\AppData\Local\Temp\bootstrap-28496-1544770336.bat" chunk 7
 Rendering "C:\Users\ADMINI~1\AppData\Local\Temp\bootstrap-28496-1544770336.bat" chunk 8
 Download via PowerShell succeeded.
 Installing downloaded client package...
[chef_version](https://user-images.githubusercontent.com/22068654/49995350-e4ef9180-ffb1-11e8-9f73-0320bc492690.PNG)

Stacktrace

Please can you provide more detail here on the bootstrap command that was issued at the command line via knife? Thanks.

Update:- problem seems to be in the image as it was customised image. Fixed after some OS update. Thank you.
Can we close the ticket?

Update:- problem seems to be in the image as it was customised image. Fixed after some OS update. Thank you.
Can we close the ticket?


CHORE - Removal of link URL when content is also displayed

Problem
Link URLS should not be displayed if there is content that will be rendered in that chat message
Solution

Removal of logic within the rendering of the message
Addition of two function/methods to handle the link recognition
Return now checks for content before displaying (or not displaying) the message

LGTM!


Add the missing usart interrupts for the stm32f401.

Fiddling around with the USARTs on the stm32f401 i was noticing the interrupts was missing. I'm not sure this is the right way to add them, and the other MCUs in the family are probably missing them as well. But this seems to work for this MCU at least.
The information from the stm32fxx-hal[1] could probably be used to add the right USARTs to the right device.
[1] https://github.com/stm32-rs/stm32f4xx-hal/blob/master/src/serial.rs

Thanks, and sorry it's taken so long to merge!

Thanks!


Linux?

Version for ubuntu to run on OS instead of browser?

i'm web developer so no native versions will be published
imo js with web workers is fast enough, 90% of code of this project's generator is simply calling sodium and 10% is if() calls and recursion

I published CLI which is about 30% faster than browser
https://github.com/VityaSchel/session-id-generator/releases

thx very much 👍


AR Filing Corrections - for review by team

A Request came in via BC Registries Engagement mailbox asking the following:

If I make a mistake on my AR filing - can I submit a correction via Form 47?
If I submit a form 47 does the $20 fee apply

Summary of Policy Response:
All filings must have the ability for a correction
The $20 Fee must apply to all correction requests
The correction must be indicated as part of the filing ledger
Policy:

From a policy perspective, my interpretation of the legislation is that yes this would require a form 47 and the legislated fee of $20 to be paid. Please note there is indeed a legislated fee in the BCA for filing any record for which there is no fee indicated in the schedule (line 15). This “catchall” fee is captured in the various acts we administer, sometimes with a differing dollar amount depending on the act. It is exceedingly rare that we will file anything without payment of a legislated fee – even a court order filed on a company requires the $20 fee to be paid.
The annual report is required under section 51 of the BCA. The section states that the annual report is to be filed “in the form established by the registrar”. Changing this form to include more information, such as the AGM information, is, in my interpretation, in line with this description. The annual report is then filed onto the ledger of the company. I presume that the outputs would reflect the new AGM information we are requiring, but could someone please confirm that for me?
Section 414 deals with corrections in any register kept by the registrar. This section requires that the registrar “is satisfied that an error or omission exists and as to the true facts that ought to have been incorporated into the register”. The correction must be shown in the ledger as a correction with the date and time of the correction noted. This has always been done by a form 47 filing which takes information from the applicant to support the registrar making the correction. Filing a form 47 would require the legislated fee in the schedule. Following this well-established corrections flow will be important especially if there are outputs that demonstrate incorrect information about the AGM date.
An additional word of caution – section 414 has long standing policies around the correction of information due to its wide interpretation applications to every registry we administer. Without consistent policy we have always run the risk of confusing the public around which corrections can be made, how they are made, and the resulting documents that may arise out of a correction. Any changes to policies around corrections should be carefully considered, perhaps with legal counsel weighing in.
This is my interpretation of the legislation, and you may wish to seek legal advice on this matter. Elizabeth, please let me know if you’d like me to draft something up.

@nsmenon8890 - can you please take a look at this tix and advise what is needed? Thank you

@Maribeth-Wilson @nsmenon8890 this is an old ticket. Kaine stated we would not collect a fee for Officer Corrections for the AR Filing


[New API] : Creating API using Json-server and testing in Angular application

Brief Description 🤓
I want to build an API which will take one json any json file containing any kind of data inside that and it will give you the API with all the request methods for all of those object you specify in the datasource file and will give you the interface to interact with it and perform all types of requests 🚀
I will test it with Angular application by having dependency injection of that API and calling that as well !
Hoping for some good contribution in API Verse 😃 !
How will you develop it?🤩
I have just created a simple API using json-server entity and I am testing that using dependency injection in Angular by using some services !
You can have all kind of request through the API !
The way to create an API is pretty simple by using npm module json-server 😃
Deployment
No
Select the open source program you are contributing to
hacktoberfest-23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINES of this project.

Greetings @kunjgit🎀 ! , We are excited to have you dive into another issue with us!🚀
Your involvement in our project has been invaluable, and we're confident that your skills and insights will help us conquer this challenge😇.  Use command /gdsc to self assign the issue.  This issue represents an exciting opportunity for us to improve and enhance our project, and we are thrilled to have you on board.
We request you to follow CONTRIBUTING GUIDELINES.
Looking for your PR soon!
In case of any issues, you can contact us on Discord.❣

/gdsc

Hey @kunjgit ! I wanted to inform you that we have closed issue.Thank you for your understanding, and we look forward to your continued engagement with our repository🤗.
In case of any issues, you can contact us on Discord.
Thank you! ❣
Happy Coding! ✨
Will See you soon❣


set verify-ssl to false make uv not work at all

Steps to Reproduce

set [[tool.rye.sources]] field in pyproject.toml, and set verify-ssl to false  (https://rye.astral.sh/guide/sources/#ssltls-verification)
run rye sync or force sync

Expected Result
just a normal sync
Actual Result
> rye sync
Reusing already existing virtualenv
Generating production lockfile: /workspaces/<my-project>/requirements.lock
error: pip-compile's `--trusted-host` is unsupported (uv always requires HTTPS)
error: could not write production lockfile for project

Caused by:
    Failed to run uv compile /tmp/.tmp1vvaVC/requirements.txt. uv exited with status: exit status: 2

> rye sync --no-lock
Reusing already existing virtualenv
Installing dependencies
error: pip-sync's `--trusted-host` is unsupported (uv always requires HTTPS)
error: Installation of dependencies failed in venv at /workspaces/<my-project>/.venv. uv exited with status: exit status: 2

Version Info
rye 0.38.0
commit: 0.38.0 (3e3c8540f 2024-08-02)
platform: linux (x86_64)
self-python<EMAIL_ADDRESS>symlink support: true
uv enabled: true

Stacktrace
No response

There's an upstream issue tracking Uv support for something that fulfills this need, here: https://github.com/astral-sh/uv/issues/1339


Labels for mysql-nodes service

We are trying to use prometheus-operator to scrape mysql metrics for myql instances. Prometheus operator uses a custom resource called ServiceMonitor to link application metrics to a prometheus instance. It identifies the applications to scrape by using label selectors like a service object.
To discover mysql instances with prometheus operator, the nodes service need to have labels on it. Can the operator apply some labels like app=mysql-operator and mysql_cluster=<cluster_name>? That should be sufficient.

Hi @smanpathak! In the latest version of the operator(v0.3.1), it adds labels on services.
This is the list of labels on all cluster objects:
		"mysql.presslabs.org/cluster": <cluster name>,
		"app.kubernetes.io/name":       "mysql",
		"app.kubernetes.io/instance":   <cluster name>,
		"app.kubernetes.io/version":    <mysql version>,
		"app.kubernetes.io/component":  "database",
		"app.kubernetes.io/managed-by": "mysql.presslabs.org",

We can backport this feature in version 0.2.x, if you need it.

@AMecea v0.3.1 should work for us.
Thanks,


Switch CMake defaults towards making life easy for customers

Some of the defaults in our CMake files are not appropriate for customers. For example:

[x] Compiling with -Wall and -Werror is good for us, but just creates noise for customers using a newer (or simply different) compiler than the ones we use.
[ ] Enabling the tests is not useful for most customers. It is our job to run the tests, not theirs.
[ ] Enabling the examples is (probably) a good default for customers because there is a good chance they will want to run them.  It is a bad default for package maintainers.

Still have a couple things to improve.

Strike 1. Let's review next time.


readme updates to clarify options and how to pass props

I was stumbling around trying to figure out how to pass props to a component in a Route, and finally found some helpful comments in issues and PRs, so I made some minor readme changes to make that more explicit for the next person to see.
I like this project, I will likely contribute more later as I use it more extensively.

Thanks!


Is it necessary to use _ prefixes for private methods now that CI uses php5?

Exactly just that.  I understand we needed it for php4 backwards compat, but if a method is declared private in php5 you can't access it via the url.

I personally think it's better to keep with the underscore convention, as it immediately identifies a private function in a way that a "private" keyword does not.

I agree. Not necessary, but a nice convention to have.

I agree as well.  I've always used them for my projects, even before CI.  The question came up in the forums so I thought I'd see what what others thought.
Minimally, I don't think the check for the underscore is needed for classes or methods, though, as it's not really doing anything anymore since we are using PHP5 public/private methods now... except wasting a few extra cpu cycles and contributing to bloat (although small).

How about the actual logic to check for the underscore be removed and users who still prefer to use it can still use it but it would mainly just be an "aesthetic thing"

@CroNiX There is no argument to be made for bloat. If you added an underscore to every function name and call in a program, you'd have a very difficult time benchmarking the difference.
Anyway, the style guide says use underscores, so unless Ellis Lab okays it, underscores are staying.
https://github.com/EllisLab/CodeIgniter/blob/develop/user_guide_src/source/general/styleguide.rst#private-methods-and-variables

@m0nd I don't see why that's a good idea. The logic is only in the Controllers, and (as far as I know), underscores are easier (and thus better performing) to check than visibility for determining where a function can be used as a route or not.

Its better performing to use a manual check for an underscore than using PHPs built in (and automatic) checking?  Its doing it anyway, on every request.  And I don't think you got what I was saying.  m0nd did.  That is the bloat I'm referring to.  Useless code, not the presence of extra underscores.

I don't see anything in the PHP manual about call_user_func and call_user_func_array caring about whether a method is public or private. Since that's how controller functions are called, I'm failing to see how there's any automatic checking.

private function index2()
{
echo 'private index2() accessed';
}
Does this not trigger a 404 for you?

IMO, that's a legacy CI feature (described as such in the user guide).
There are indeed checks to ensure that a private and/or protected method is not called, but using the underscore (apart from the coding style guidelines) allows that to happen before the class itself is instantiated.
This could actually save a lot more overhead in those cases and also avoids calling the class constructor.


Use strongly-typed key paths internally

Fixes #20
I've done this, by declaring protocol where Self is constrained to CALayer, and implementing animate method with Self as KeyPath parameter. Works for base CALayer and its descendants.

IssueHunt Summary

Referenced issues
This pull request has been submitted to:

#20: Use strongly-typed KeyPath in CALayer#animate()

IssueHunt has been backed by the following sponsors. Become a sponsor

This is great. Thank you 🙌


Set up repository

This PR performs the initial repository set-up:

Gradle wrapper;
basic Gradle scripts are created;
CI configuration files;
Git configuration files;
IDEA configuration files.

@armiol, PTAL.


Beacons are sent only sporadically on OnePlus 6, Android 10

Because the app doesnt provide any feedback or stats about beacons sent/received, i used "BeaconScope" on an other device to check if the app works.
Describe the bug
In our household we have two main phones: an iphone and my android phone (OnePlus 6. Android 10). When i opened up "BeaconScope" on a third device to check if both phones advertise themselves correctly, i could only see the iPhone, sending out beacons with a 1 Hz rate.
After turning the androids bluetooth off and on again the phone appeared, i could see it with BeaconScope but only for 1 or 2 packets. Then it disappears while the iPhone still works fine. Every once in a while (30s up to 5 min interval) it appears again, sends out 2 or 3 packets and disappears again.
Even after turning energy-saving off for the app, it still does not work correctly.
Expected behaviour
I expect the app to send out beacons in a fixed interval, e.g. 1 Hz.
Technical details
First screenshot: both phones are discovered

Second screenshot, 8 seconds later: only the iphone is still sending beacons

Additional context
This issue kind of relates to https://github.com/corona-warn-app/cwa-wishlist/issues/5 because stats about beacons sent or received/stored in DB could show that somethings might be wrong here.

Internal Tracking ID: EXPOSUREAPP-1933

I gave it a quick smoke-test: two devices (OnePlus 5T with Android 10 and Motorola G2 with Android 6) next to each other and at the same very short distance to sensitive Bluetooth antenna (10 cm). Frequency is the same, but indeed OnePlus seems to be transmitting beacons with much weaker signal strength, corresponding to measured distance (if we translate it with proper equation) couple of times greater than for Motorola beacons. Maybe this is a factor why you don't see as frequent beacons from OnePlus device. But don't take my word for it - I'm also listening to music over Bluetooth on OnePlus so these are not laboratory conditions (although quite real-life).

Maybe this is a factor why you don't see as frequent beacons from OnePlus device

Although these results are interesting (weaker signal, but still frequent), in my test scenario the iPhone was placed 4 meters away (as seen in the screenshot), but the Oneplus was placed next to the test phone (sometimes the distance is displayed correctly with 0,1m, sometimes not (2m)).

That's interesting, perhaps there is some hardware issue with OnePlus 6 (I wonder if it differs much in terms of hardware from OnePlus 5T). Can just confirm that when placed far away from receiver in the second room, and with all applications closed the results from OnePlus 5T and Motorola seem to be consistent:

I’d like to add to this that the app shows conflicting information on my Oneplus 6 also on Android 10, Oxygen OS v10.3.4
As you can see in this picture:

The top bar shows that I have tracing enabled, but the card below it says it is not. If I click on „einschalten“ this does not change. I have also set the app to „not optimized“ in battery settings.

Hey @florianwgnr,
Did the bug eventually disappear for you?
Regards,
CH

Corona-Warn-App Open Source Team

Hey @florianwgnr,
Did the bug eventually disappear for you?

I just checked it again and yes, beacons are now sent regularly. Thanks!

@florianwgnr Thanks for checking. One bug less to worry about :)

Corona-Warn-App Open Source Team


Add new command of "calculate" and "purchase"

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[ ] I adhere to the Command Guidelines.

@Juliehzl please take a look.

Hi team,
All comments have been addressed. Can we merge this PR?

Because you parameters are duplicated for two commands. I will prefer that you abstract then using CLIArgumentType. In this way, you don't need to specify them in _help.py file.

Hi @Juliehzl, please take another look if available.

LGTM in general and leave some comments.

Hello @Juliehzl. Not sure what LGTM means.
I have resolved all the new comments. if nothing else, could you please approve the PR.


Couldnt able to install in my ubuntu docker container

When I do ./build.sh
At the end of installation I am getting the following error:
`
App -> /home/project/omnisharp-roslyn/test-assets/test-projects/ProjectWithMultiTFMLib/App/bin/Debug/netcoreapp2.1/App.dll
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:01.11
Restoring and building: ExternAlias...
Microsoft (R) Build Engine version 16.3.0+0f4c62fea for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.
Restore completed in 32.15 ms for /home/project/omnisharp-roslyn/test-assets/test-projects/ExternAlias/ExternAlias.App/ExternAlias.App.csproj.
Restore completed in 32.16 ms for /home/project/omnisharp-roslyn/test-assets/test-projects/ExternAlias/ExternAlias.App2/ExternAlias.App2.csproj.
Restore completed in 0.61 ms for /home/project/omnisharp-roslyn/test-assets/test-projects/ExternAlias/ExternAlias.Lib/ExternAlias.Lib.csproj.
/home/project/omnisharp-roslyn/.dotnet/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "ExternAlias.Lib". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/home/project/omnisharp-roslyn/test-assets/test-projects/ExternAlias/ExternAlias.App/ExternAlias.App.csproj]
ExternAlias.Lib -> /home/project/omnisharp-roslyn/test-assets/test-projects/ExternAlias/ExternAlias.Lib/bin/Debug/netstandard2.0/ExternAlias.Lib.dll
ExternAlias.App2 -> /home/project/omnisharp-roslyn/test-assets/test-projects/ExternAlias/ExternAlias.App2/bin/Debug/netcoreapp2.1/ExternAlias.App2.dll
Program.cs(1,14): error CS0430: The extern alias 'abc' was not specified in a /reference option [/home/project/omnisharp-roslyn/test-assets/test-projects/ExternAlias/ExternAlias.App/ExternAlias.App.csproj]
Build FAILED.
/home/project/omnisharp-roslyn/.dotnet/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "ExternAlias.Lib". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/home/project/omnisharp-roslyn/test-assets/test-projects/ExternAlias/ExternAlias.App/ExternAlias.App.csproj]
Program.cs(1,14): error CS0430: The extern alias 'abc' was not specified in a /reference option [/home/project/omnisharp-roslyn/test-assets/test-projects/ExternAlias/ExternAlias.App/ExternAlias.App.csproj]
1 Warning(s)
1 Error(s)
Time Elapsed 00:00:01.68
An error occurred when executing task 'PrepareTestAssets:CommonTestAssets'.

Teardown
Shutting down MSBuild server...
Shutting down VB/C# compiler server...
Shutting down Razor build server (process 912)...
VB/C# compiler server shut down successfully.
Razor build server (process 912) failed to shut down: The shutdown command failed: It was not possible to find any compatible framework version
The specified framework 'Microsoft.NETCore.App', version '3.1.2' was not found.

The following frameworks were found:
3.0.0 at [/home/project/omnisharp-roslyn/.dotnet/shared/Microsoft.NETCore.App]
You can resolve the problem by installing the specified framework and/or SDK.
The .NET Core frameworks can be found at:
https://aka.ms/dotnet-download

MSBuild server shut down successfully.
Error: One or more errors occurred. (.NET Core CLI: Process returned an error (exit code 1).)
.NET Core CLI: Process returned an error (exit code 1).`
Docker Ubuntu Version: 18.04
.Net core SDK version 3.1.102
.Net core runtime version 3.1.2

this test is flaky. Does it fail all the time, or did it just fail once?

Thanks @filipw.
Now I'm running into the GitVersion problem mentioned in https://github.com/OmniSharp/omnisharp-roslyn/issues/1891

Fixed in https://github.com/OmniSharp/omnisharp-roslyn/pull/2030