feat: [#294] Validator cant check the param of url

Closes #
📑 Description

✅ Checks

[x] My pull request adheres to the code style of this project
[x] My code requires changes to the documentation
[x] I have updated the documentation as required
[x] All the tests have passed

ℹ Additional Information

Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.

Files
Coverage Δ

context_request.go
63.17% <69.23%> (+0.37%)
:arrow_up:

:loudspeaker: Thoughts on this report? Let us know!.


🎨 isort / sort imports

using admin privileges to merge this => 4 files changes by isort are not part of other PRs.


Suggest npm module name in commonjs require

VSCode Version: 1.0.0
OS Version: Linux 3.19.0-58-generic #64~14.04.1-Ubuntu SMP Fri Mar 18 19:05:43 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

Steps to Reproduce:

Create a new Node.js project
npm install express
Create an index.js
Type let e = require(' and hit <ctrl><space>

It would be nice if VS Code would now suggest express and any other npm module being installed but VS Code first only shows Loading... and after a few moments it shows no suggestions.
It also doesn't suggest the default Node modules like path or fs even if the node typings are installed.

Dups https://github.com/Microsoft/TypeScript/issues/188


Failed to generate a valid skeleton for 'base'

Windows 7 x64, IDEA 2017.2.1, R 3.4.1.
Failed to generate a valid skeleton for 'base'. Please file a ticket under https://github.com/holgerbrandl/r4intellij/issues
java.lang.Throwable
	at com.intellij.openapi.diagnostic.Logger.error(Logger.java:132)
	at com.r4intellij.packages.RSkeletonGenerator.lambda$updateSkeletons$1(RSkeletonGenerator.java:248)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)

Running skeletonize_package.R against base works fine and results in a base.skeleton.R, which though gets rejected by the plugin, even after it is renamed, and the plugin just indexes base again on startup, and fails, deleting the custom skeleton.

Some users suggested that this may be related to the used version of R

I can confirm changing from R 3.4.1 to 3.3.3 also fixed this issue for me.

@holgerbrandl, I switched to R 3.3.1 as you suggested in #118. I now get the following error:
Failed to generate a valid skeleton for 'base'.helperOutputNull=false

I have the same issue, with all R versions I've tried (so far R 3.4.1, 3.3.3 and 3.2.5, x64 in all cases). Windows 10, IntelliJ 2017.2.4 and Pycharm 2017.1.3.

Windows 7 x64, IDEA 2017.1, R 3.3.2. Same issue.

I got the same issue:
Failed to generate a valid skeleton for 'base'.helperOutputNull=false skeletonFile_exists=false isComplete=false isCurrentSkelVersion=false OS=Windows 10 10.0  Please file a ticket under https://github.com/holgerbrandl/r4intellij/issues java.lang.Throwable 	at com.intellij.openapi.diagnostic.Logger.error(Logger.java:132) 	at com.r4intellij.packages.RSkeletonGenerator.lambda$updateSkeletons$1(RSkeletonGenerator.java:256) 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 	at java.util.concurrent.FutureTask.run(FutureTask.java:266) 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) 	at java.lang.Thread.run(Thread.java:745)
Any idea how to solve it? The other packages goes well.... so its a pitty

Had the problem with R-3.4.3, Windows 10 in PyCharm (several last versions).
Deleted R and made clean installation of last R version (R-3.5.1) to the folder, which name does not have any white-space or "dash" or "dot" symbols (C:\R351\ instead of C:\Program Files\R\R-3.4.3), and the problem was resolved (no idea, though, whether changing path helped).

Thanks @borisevichdi for the pointer. So maybe it's the whitespaces in the path which cause all this confusion?


Add Plugin to Measurement Section

I added a plug in to the measurement section.  https://github.com/NLTGit/Leaflet.LinearMeasurement  Let me know what additional steps are required for this to go live.  Feedback on the tool is encouraged and welcome!

Looks good!! :+1:


Replit audio error

Problem:
When using the audio module from this package, a FileNotFoundError occurs
Code sample:
from replit import audio

x = audio.play_file("flashback.mp3")
print(x)

Error:

See #219. We removed our custom in-repl audio in favor of guiding users towards more standard, better supported tooling (see pulsectl on pypi, as well as this blog post on using "system audio").


Dev grad3

Still ongoing.

"Bug" found: Uncatched exception after throwing std::string

NEW BUG: VRHFIN may not exist in OUTCAR ; parseElems() may fail.

No ideas about how to resolve the conflicting files....


rm the dependency of Rasters.jl

Hi @rafaqz, Just let you know that the dependency of Rasters.jl has been removed from Terra.jl.

The simplest Cartesian coordinate system, WGS84 projection, meets all my needs. Rasters.jl and GeoArrays.jl are too heavy for me.
Every research project I undertake relies on geoprocessing functions. If my package is not published, using it requires including a long Manifest.toml file in the repository, which is cumbersome.
This is why I persist in developing my own package. I need a package to hold my personal geoprocessing functions and keep my repository clean.
It is just for my personal use, not robbing your reputation.


DBZ-8371 bump protobuf dependencies to avoid vulnerability

The current version of the protobuf libraries (3.25.2) is affected by SNYK-JAVA-COMGOOGLEPROTOBUF-8055227.
The recommended fix is to upgrade to 3.25.5, which should be safe as it's just a patch fix.

@enzo-cappa Applied, thanks for reporting!


Generate mnk for resnet50 and conv nets in general

Hello - could you please let me know how do you generate the mnk file for a conv net like resnet50? I couldnt find and script to generate mnk values for convolution parameters.
Basically in convolution, input, output as well as filters have 4 dimensions. How do i convert it to mnk ?

Hello, @aakash-sharma ,
Thanks for your question. In ASTRA-sim 1.0, there is indeed a script for the workload generator that allows you to create workloads with arbitrary M, N, K dimensions for convolutional networks like ResNet50.
However, we highly recommend using ASTRA-sim 2.0, which offers enhanced features such as remote memory API and hierarchical network modeling, and also includes several bug fixes. While ASTRA-sim 2.0 does not have a direct script for M, N, K generation, it allows for more flexible and descriptive workload definitions which can aid in setting up your convolutional network simulations more effectively.
Please let us know if you encounter any issues or have questions about defining workloads in ASTRA-sim 2.0, and we will be glad to assist you.


[Bug] Mismatched matrix shapes in input_projs from GSNodeEncoderInputLayer.forward

I run into this error when using the latest version of graphstorm 9f5218320fc49a2d30a6dab6475ed69810e5fbd7, on a link prediction task with RGCN with frozen LMs:
INFO:torch.distributed.distributed_c10d:Added key: store_based_barrier_key:1 to store for rank: 0
INFO:torch.distributed.distributed_c10d:Rank 0: Completed store-based barrier for key:store_based_barrier_key:1 with 1 nodes.
INFO:root:part 0, train: 851263, val: 106407, test: 106412
Some weights of RobertaModel were not initialized from the model checkpoint at DeepChem/ChemBERTa-77M-MLM and are newly initialized: ['roberta.pooler.dense.weight', 'roberta.pooler.dense.bias']
You should probably TRAIN this model on a down-stream task to be able to use it for predictions and inference.
INFO:root:yaml_paths: frozen_lm_rgcn_lp.yaml
INFO:root:_node_lm_configs: [{'lm_type': 'bert', 'model_name': 'Rostlab/prot_bert', 'gradient_checkpoint': True, 'node_types': ['protein']}, {'lm_type': 'roberta', 'model_name': 'DeepChem/ChemBERTa-77M-MLM', 'gradient_checkpoint': True, 'node_types': ['drug']}, {'lm_type': 'bert', 'model_name': 'microsoft/BiomedNLP-PubMedBERT-base-uncased-abstract-fulltext', 'gradient_checkpoint': True, 'node_types': ['disease', 'function', 'sideeffect']}]
INFO:root:_backend: nccl
INFO:root:_verbose: False
INFO:root:_save_perf_results_path: /industry-gml-benchmarks/ogbl-biokg/dataset/ogbl_biokg/biokg_graph_tasks/1_ppi/frozen_lm_rgcn_lp_model
INFO:root:_model_encoder_type: rgcn
INFO:root:_use_self_loop: False
INFO:root:_lm_train_nodes: 0
INFO:root:_lm_infer_batch_size: 32
INFO:root:_freeze_lm_encoder_epochs: 0
INFO:root:_hidden_size: 128
INFO:root:_use_mini_batch_infer: True
INFO:root:_num_layers: 2
INFO:root:_dropout: 0.0
INFO:root:_lr: 0.001
INFO:root:_num_epochs: 3
INFO:root:_batch_size: 128
INFO:root:_eval_batch_size: 1024
INFO:root:_wd_l2norm: 0
INFO:root:_fanout: 5,5
INFO:root:_eval_fanout: 20,20
INFO:root:_no_validation: False
INFO:root:_eval_frequency: 500
INFO:root:_restore_model_path: None
INFO:root:_save_model_path: /industry-gml-benchmarks/ogbl-biokg/dataset/ogbl_biokg/biokg_graph_tasks/1_ppi/frozen_lm_rgcn_lp_model
INFO:root:_save_embed_path: None
INFO:root:_num_negative_edges: 4
INFO:root:_num_negative_edges_eval: 100
INFO:root:_train_negative_sampler: joint
INFO:root:_eval_etype: ['protein,protein-protein_activation,protein', 'protein,protein-protein_binding,protein', 'protein,protein-protein_catalysis,protein', 'protein,protein-protein_expression,protein', 'protein,protein-protein_inhibition,protein', 'protein,protein-protein_ptmod,protein', 'protein,protein-protein_reaction,protein']
INFO:root:_train_etype: ['protein,protein-protein_activation,protein', 'protein,protein-protein_binding,protein', 'protein,protein-protein_catalysis,protein', 'protein,protein-protein_expression,protein', 'protein,protein-protein_inhibition,protein', 'protein,protein-protein_ptmod,protein', 'protein,protein-protein_reaction,protein']
INFO:root:_exclude_training_targets: False
INFO:root:_reverse_edge_types_map: []
INFO:root:_task_type: link_prediction
INFO:root:_logging_level: info
INFO:root:_profile_path: None
INFO:root:_construct_feat_ntype: None
INFO:root:_ip_config: /industry-gml-benchmarks/ogbl-biokg/ip_list.txt
INFO:root:_part_config: /industry-gml-benchmarks/ogbl-biokg/dataset/ogbl_biokg/biokg_graph_tasks/1_ppi/biokg.json
INFO:root:local_rank: 0
INFO:root:Computing bert embedding on node protein takes 258.952 seconds
INFO:root:Computing bert embedding on node drug takes 4.230 seconds
INFO:root:Computing bert embedding on node disease takes 39.415 seconds
INFO:root:Computing bert embedding on node function takes 166.670 seconds
INFO:root:Computing bert embedding on node sideeffect takes 36.788 seconds
/usr/local/lib/python3.8/dist-packages/torch/nn/parallel/distributed.py:1772: UserWarning: You passed find_unused_parameters=true to DistributedDataParallel, `_set_static_graph` will detect unused parameters automatically, so you do not need to set find_unused_parameters=true, just be sure these unused parameters will not change during training loop while calling `_set_static_graph`.
  warnings.warn(
Traceback (most recent call last):
  File "/develop/graphstorm/python/graphstorm/run/gsgnn_lp/gsgnn_lp.py", line 217, in <module>
    main(args)
  File "/develop/graphstorm/python/graphstorm/run/gsgnn_lp/gsgnn_lp.py", line 180, in main
    trainer.fit(train_loader=dataloader, val_loader=val_dataloader,
  File "/develop/graphstorm/python/graphstorm/trainer/lp_trainer.py", line 191, in fit
    loss = model(blocks, pos_graph, neg_graph,
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1194, in _call_impl
    return forward_call(*input, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/parallel/distributed.py", line 1040, in forward
    output = self._run_ddp_forward(*inputs, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/parallel/distributed.py", line 1000, in _run_ddp_forward
    return module_to_run(*inputs[0], **kwargs[0])
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1194, in _call_impl
    return forward_call(*input, **kwargs)
  File "/develop/graphstorm/python/graphstorm/model/lp_gnn.py", line 95, in forward
    encode_embs = self.compute_embed_step(blocks, node_feats, input_nodes)
  File "/develop/graphstorm/python/graphstorm/model/gnn.py", line 782, in compute_embed_step
    embs = self.node_input_encoder(input_feats, input_nodes)
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1194, in _call_impl
    return forward_call(*input, **kwargs)
  File "/develop/graphstorm/python/graphstorm/model/lm_embed.py", line 704, in forward
    return super(GSLMNodeEncoderInputLayer, self).forward(input_feats, input_nodes)
  File "/develop/graphstorm/python/graphstorm/model/embed.py", line 295, in forward
    emb = input_feats[ntype].float() @ self.input_projs[ntype]
RuntimeError: mat1 and mat2 shapes cannot be multiplied (2227x768 and 1024x128)

However, the task can be completed without this encountering error when using v0.1.2 version.

Can you try v0.2?

Got the same error.

I think I found the root cause. The adjust_feat_size used to be determined by individual LMs in v0.1.2.
In v0.2, the feat_size property only use the first lm model's feat_size as the collection of LM's feat_size. https://github.com/awslabs/graphstorm/blob/9f5218320fc49a2d30a6dab6475ed69810e5fbd7/python/graphstorm/model/lm_embed.py#L194C1-L201C18
This exclude the cases where multiple LMs with different feat_size's.

Can we close this issue?


Add 'continue-on-error: true' to 'jf audit' step

This way we can capture the .txt output file into an artifact attached to the build.  Or push the text output into a PR, or whatever else we decide to do.

That's a nice feature


Strip the pathPrefix from basic proxy requests

Addresses issues that were brought up in #393

Adds secure: false back in
Drops ignorePath: true which strips the entire path of the request. Replaced it with a default proxyReq event listener that just strips the pathPrefix off the path.

proxy: {
  "/storybook": "http://localhost:3000"
}

This will result in the URL going from http://localhost:8080/storybook/static/js/bundle.js -> http://localhost:3000/static/js/bundle.js which, I believe, was the intention of that config entry.
For the advanced configs, I'm going to leave it as whatever you configure is what you get.
@FredKSchott
/cc @fcamblor

Yup, that makes sense and matches what the http-proxy docs say about it

Hi,
@stramel Great to see how this feature is improving thanks to your recent PRs.
Anyway, I'm not 100% sure that stripping the requestPath is enough. In my testing there are some inconsitencies you may have a look at.
In case the js app makes this call fetch('/api/status')  this is what happens in different config scenarios:
  "proxy": {

    "/api": "http://localhost:5000",
// -> prefix removed, target localhost:5000 receives /status

    "/api": "http://localhost:5000/some/other/path",
// -> request prefix removed but target path is not considered at all, maybe a bug
// -> target localhost:5000 still receives   /status,

    "/api": {
      "target": "http://localhost:5000"
    } ,
// -> no prefix stripping takes place and target receives full url   /api/status

    "/api": {
      "target": "http://localhost:5000/api"
    }
// -> no prefix stripping takes place and target path is considered
// -> target receives this  /api/api/status

  }

I would check these individual cases if the intention is, for the most basic proxy configuration, to strip the prefix path from the request and add the path from the target.  Would also weigh the upgrade case from the developers perspective when he want's to change a string configuration to a full options config. Ideally he would be able to migrate a simple config from "string" to { "target":  "string" } without breaking anything.
Thanks!!
Germán

@germanftorres

@stramel Great to see how this feature is improving thanks to your recent PRs.

Thanks! 😄
As of now, I have been working to make the basic setup function similarly to how the proxy in the scripts section worked.
So going through your examples
fetch('/api/status')
"proxy": {

    "/api": "http://localhost:5000",
	// -> prefix removed, target localhost:5000 receives /status
	// EXPECTED: /api/status -> http://localhost:500/status

    "/api": "http://localhost:5000/some/other/path",
	// -> request prefix removed but target path is not considered at all, maybe a bug
	// -> target localhost:5000 still receives   /status,
	// EXPECTED: /api/status -> http://localhost:500/some/other/path/status

    "/api": {
      "target": "http://localhost:5000"
    },
	// -> no prefix stripping takes place and target receives full url /api/status
	// EXPECTED: /api/status -> http://localhost:500/api/status

    "/api": {
      "target": "http://localhost:5000/api"
    }
	// -> no prefix stripping takes place and target path is considered
	// -> target receives this  /api/api/status
	// EXPECTED: /api/status -> http://localhost:500/api/api/status

  }

Once you eject to an object config, we are deferring everything to you. It's pretty simple to do the proxy as you can see in this PR. Just add:
"proxy": {
  "/api": {
    "target": "http://localhost:5000",
	"on": {
	  "proxyReq": (proxyReq, req) => proxyReq.path = req.url.replace('/api')
	}
  },
}

I suppose we probably could add that rewrite to all requests by default and require users to prepend the /api if they don't want us to remove it?
It looks like the second example isn't working properly, I can look into that.

Ideally he would be able to migrate a simple config from "string" to { "target": "string" } without breaking anything.

I will have to defer to @FredKSchott on this.

Yup, thanks for the summary @stramel, that all looks right.
I'm +1 for not doing too much magic in the object use-case, I feel like it will confuse as many people as it would help (harder to trust the http-proxy README docs).


Pinocchio::log6 question

Hi, I would like to know which way is used to express the rotation in function pinocchio:: log6 , is it quaternion?

The log6 operation takes as input a placement SE3 and outputs a Motion, is it answering your question?

thanks for your reply, i have understood.

@jcarpent thanks for your reply, i have understood.


revise make example

manuscript.pdf: data/ìris_prepped manuscript.Rmd
     Rscript -e 'rmarkdown::render("manuscript.Rmd")'
data/ìris_prepped: R/prepare_data.R data/iris.csv
     Rscript -e 'source("R/prepare_data.R")'

Shouldn't it be data/ìris_prepped.csv instead of data/ìris_prepped?
Should we include:
all: manuscript.pdf
@brandmaier

cross ref #21

yes and yes

Closed by d75eb76.


Cloud Connectivity Service Provisioning

Description
Changes proposed in this pull request:

Extension of control plane provisioning to include Connectivity Service from service catalog.
Refactoring of ems provisioning.

Related issue(s)

/retest

/test pre-master-control-plane-gke-integration pre-master-control-plane-integration

/test pre-master-control-plane-gke-integration


Subscription is lost after ~1.5 days

For some reason seems like subscription gets cancelled after ~1.5 days instead of 7. Need to double-check and debug

@okainov  out of curiosity, how do you know that subscriptions are getting cancelled?

I add subscription for myself and then check logs =) That's why I have Kibana dashboard.

Cool, thanks for letting me know. Could you help me set this up as well? I would like to work more on this project.

Here are some of my logs last days. We can see, it's just lost after several hours
I'll try to update README with some of ELK setup steps, but also you should be able to see normal print logs if you have it running somewhere on your server

He-he, seems like it's because of Heroku's "cycling". And since it happens in a random timeframe and not displayed in the log, that's why it was so complicated to find out.
Yet another reason to finally migrate to the separated server, also will help in #14


disk create: fix a bug that source detection is not accurate

Fix #6180

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

View a preview at https://prompt.ws/r/Azure/azure-cli/6220
This is an experimental preview for @microsoft users.


Logo too big when make app window smaller

When resize the app window smaller than full size (or even smaller monitors) the KS logo is too big and overlaps the main section.

The image size is set to 200 in external/tab_Background.R

Solved with Erik's v<IP_ADDRESS>43 edits.

Looks like I only did the fix for the tab ("background")  in the Black bar at the top.
Still have the issue for the other 3 tabs (Prepare Data, Calculate MMI, and Troubleshooting).

Resolved in v<IP_ADDRESS>63


add networkx graph visualization

Maybe accessible from a line magic like the following:
%safety show_graph

Added basic graph visualization, but still need further improvement.

Able to show stale nodes as red now. Will close this issue for now. Maybe can add in more feature like positioning in the future.


New filters for get_message_log_entries

added filter options to get_message_log_entries function as noted in issues #363 and #342
Using the new level parameter, you can filter the log query to Error, Warning, Info, Debug, or Unkown. The msg_contains parameter allows you to filter by substring.

closing, will submit new pull with a few edits


[Bug]  related to question #38

Describe the bug
Failed to excecute install_dev_db.sh
Your Server Environment

OS Name and Version
Garuda linux

pull request merged - closing this issue.


Deployment fixes

coverage: 92.823% (+0.001%) from 92.822%
when pulling 346daa4e7f8b421aa9cc44747632fb53bb33736c on antgonza:deployment-fixes
into 0387611c89459a99e45b9e0327b7e739ab3649b6 on qiita-spots:dev.

coverage: 92.822%. remained the same
when pulling 5886d11a18a40eec241878472343f52499bee4ad on antgonza:deployment-fixes
into 0387611c89459a99e45b9e0327b7e739ab3649b6 on qiita-spots:dev.

coverage: 92.832% (+0.01%) from 92.822%
when pulling c29bb0648d21f6241fcf225c5ab9b1ef056654e8 on antgonza:deployment-fixes
into 0387611c89459a99e45b9e0327b7e739ab3649b6 on qiita-spots:dev.


Crossplat MSBuild and glob expansion

When MSBuild expands globs, it currently

uses the file system's path separator to stitch together path fragments that are coming from the recursive directory walk
uses the original string values for the path fragments already provided by the user

On windows there is the following behaviour:
** expands to a\b\c\foo.cs
a/** expands to a/b\c\foo.cs
a\** expands to a\b\c\foo.cs
However, on crossplat msbuild we should choose whether to keep the current behaviour or change to some other things:

impose a standard slash indifferent of the OS: a/** expands to either a\b\c\foo.cs or to a/b/c/foo.cs (depending on which slash we choose as the standard one).

Pros:

Project files are crossplatform. The user knows what slashes MSBuild uses so it can directly use them in conditions and such
If we use \ as the standard, legacy project files won't break

Cons:

Task consuming the paths may break if they are using slash agnostic System.IO libraries

use the OS specific slashes

Pros

Task consuming the paths won't break if they are using slash agnostic System.IO libraries

Cons

Project files are not crossplatform. If the user has conditions based on paths, conditions might now evaluate differently on windows vs !windows
Follows from the previous one: legacy project files are not crossplat if the user has conditions based on paths

My two cents: this shouldn't matter, if \ and / are treated as the same character in string comparisons.
You should thus use \ in all project files, and when using glob expansion, it won't really matter what the result is, because / and \ will be treated interchangeably.

Another question: what about the '?' wildcard? On Windows, '?' is an invalid filename character, but not on *nix/macOS.

You have to escape ? with %3F to have it treated as a literal.

Would be great if there was a standardised path seperator when writing paths to project files. For projects with collaborators on multiple platforms, adding and removing an item from the project shouldn't cause a path to be changed within the project file, from previoulsy using '/' to using '' etc - as this will then show as a change, when really nothing has changed.

We have chosen to keep the current behavior. At this point, changing this would be a big breaking change for what does not look like a fantastic improvement.


Adjusting environmental lighting

Hi, thank you for your work on this nice package.
Loaded .gltf models tend to look too bright and with washed-out colors. Is there a way to tune the environmental lighting to increase/reduce intensity, change color temperature and other properties?

Hi,
Im happy to know this package is helpful for you.
Currently package won't support light controlling feature.
Maybe I can make it work in future.


fix(treelist) Upgrading angular-tree-component to 3.2.4

This update takes advantage of Angular 4.
Note that there is a PR for fabric8-ui as well:
https://github.com/fabric8io/fabric8-planner/pull/1505

There were the following issues with your Pull Request

Commit: 5d8ce2065c552107d2eeae230da1a4304be2d5f9
Commits must be in the following format: %{type}(%{scope}): %{description}
Your subject line is longer than 50 characters

Guidelines are available at https://github.com/fabric8io/fabric8-ui

This message was auto-generated by https://gitcop.com

There were the following issues with your Pull Request

Commit: 147dc7246bb7bbc3816858ed206afc0ccc054f10
Your subject line is longer than 50 characters

Guidelines are available at https://github.com/fabric8io/fabric8-ui

This message was auto-generated by https://gitcop.com


Location permissions

Hello!
I was wondering why we need the location permission for this package. From the documentation
<key>NSLocationWhenInUseUsageDescription</key>
<string>Location access is required in order to accept payments.</string>

If we use the package for tap to pay, and create a location on the backend and only use the id of it on the mobile app, is there any other reason for the location permission?
It also seems that if we select "Allow Once" for location, the SDK will error out. I will investigate this a bit more to see why, but do you guys have any ideas on this?
Thank you!

is there any other reason for the location permission?

👋 hi, yes the Terminal SDK internally collects and reports the current location from the device when processPayment is called. This is independent of the Stripe location object id passed in when connecting to the reader and is a requirement for processing payments with the SDK.

Ok, thanks! I will close this issue, it's all I wanted to know :)
Regarding this

It also seems that if we select "Allow Once" for location, the SDK will error out. I will investigate this a bit more to see why, but do you guys have any ideas on this?

It turned out to be a different problem


Karathuru project - Fixes needed before closing

LEFT TO CLEAN
1. RWAtcher

The SFT

2. Launchad SFT to be updated.

The SFT

3. Karathuru Project page  to be updated.

The info (# Shares = 367,909.87)
The SFT

4. The Due Diligence.
Please update the due diligence, with the latest version attached (which has the right numbers)
Karathuru Project - Due Diligence - 05_05_2024.pdf
And please use the very same link: https://carbonable.github.io/projects/karathuru/Due_diligence_-_Karathuru.pdf
5. Website to be updated
B2B
Remove bandeau
B2C
Remove bandeau
Here:
SOLD OUT

Here:
Change “Our next project” by “Our last project”

Here:
In the picture:
367,909.87 Shares
SOLD OUT
DISCOVER PROJECT
Under the picture:
368 K Shares

If quick and dirty is needed here is the png for the SFT

@Khyati729 do you know if there is work remaining on this ticket?

@Khyati729 do you know if there is work remaining on this ticket?


A command to turn off the rtsp stream

I've created a shell command in HASS to turn on the stream.
shell_command:
  camera_on: 'videop2proxy --ip 192.168.x.xx --token xxxxxxxxxxxxxxxxxxxxxxxxxxxx --rtsp 8554'

And have this in configuration:
camera:
  - platform: ffmpeg
    input: -rtsp_transport tcp -i rtsp://192.168.xx.xx:8554/

But I wouldn't want to run the camera constantly. Is there a way to turn off the stream?

Currently I am using these two commands to turn the feed on an off by setting the camera to sleep mode:
miiocli device --ip 192.168.xx.xx --token xxxxxxxxxxxxxxxxxxxxxxxxx raw_command set_video '["off"]'
miiocli device --ip 192.168.xx.xx --token xxxxxxxxxxxxxxxxxxxxxxxxx raw_command set_video '["on"]'


freshen up the mono optimization text

Dan, I think this is ready to be tested on the live server.

Merged manually. Thanks, @bruceravel!


Add column-reverse support

This PR address the issue #21

Discussed and decided the open issue should not be resolved because the current implementation prevents misuse of .aw-reverse in the grid.


Preparing for release 2.1.2

Coverage remained the same at 81.996% when pulling aafa40ea88f6e4ea53ed9e623d92ed4266a54310 on 2.1.2 into 3d3abe223034be3d0f5af230d9f1da3c408d9866 on master.

Coverage remained the same at 81.996% when pulling aafa40ea88f6e4ea53ed9e623d92ed4266a54310 on 2.1.2 into 3d3abe223034be3d0f5af230d9f1da3c408d9866 on master.

Coverage remained the same at 81.996% when pulling 8e5033750e8b605c74aeba0691f3659a81ca0ea8 on 2.1.2 into 3d3abe223034be3d0f5af230d9f1da3c408d9866 on master.

Coverage remained the same at 81.996% when pulling 8e5033750e8b605c74aeba0691f3659a81ca0ea8 on 2.1.2 into 3d3abe223034be3d0f5af230d9f1da3c408d9866 on master.


[Tizen 4.0] Apps cannot launch

Apps cannot be started on a Tizen 4.0 device/emulator (regardless of the build mode or app type) after Flutter 2.0 update. Wanchao has initially reported this issue by testing on a Tizen 4.0 watch emulator (with a plugin sample) and the issue has been confirmed to be applicable for any Tizen 4.0 device and any app.
Launching lib/main.dart on Tizen TM1 in debug mode...
The Platform profile is used for signing.
Building a Tizen application in debug mode...                      25.3s
✓ Built build/tizen/com.example.csharp-1.0.0.tpk (22.7MB).
Installing build/tizen/com.example.csharp-1.0.0.tpk...             23.3s
I/ConsoleMessage(30212): FlutterApplication.cs: OnCreate(54) > switches: --enable-dart-profiling --enable-checked-mode
W/ConsoleMessage(30212): ../../../../flutter/shell/platform/tizen/tizen_renderer.cc: OnProcResolver(204) > Could not resolve: glGetStringi
W/ConsoleMessage(30212): ../../../../flutter/shell/platform/tizen/tizen_renderer.cc: OnProcResolver(204) > Could not resolve: glGetStringi
E/ConsoleMessage(30212): ../../../../flutter/shell/platform/tizen/flutter_tizen.cc: FlutterDesktopRegistrarGetTextureRegistrar(221) > Tizen DesktopTexture support is not implemented yet.
Activating Dart DevTools...                                         3.4s

lldb showed a similar stack trace to #58, so this might be a freetype-related issue again.
(lldb) Process 29028 stopped
* thread #14: tid = 1407, 0xb5c48049 libfreetype.so.6, name = 'io.flutter.ui', stop reason = signal SIGSEGV: invalid address (fault address: 0x755770fd)
    frame #0: 0xb5c48049 libfreetype.so.6
->  0xb5c48049: fnstcw -0x406d0f4b(%edi)
    0xb5c4804f: movb   $-0x70, %ch
    0xb5c48051: sbbl   %eax, %eax
    0xb5c48053: movb   $0x0, %ch

Reverting some skia commits temporarily fixed the problem.

https://github.com/google/skia/commit/2c73fc43a36e1a786985d40f27cba39b8187fa68
https://github.com/google/skia/commit/541601602ee94b1fbf04d9b2fe0661951960f97c

#58 is basically the same issue (libfreetype.so is loaded before the app code is run) so let's continue the discussion there.


EPIC: Introspection command

The introspection command is the component that turns a database introspection result into a Prisma schema. This gets implemented by our Freelancer Arve.
Work packages are:

[x] build the command driven by Unit Tests based on the idea to simply invert the behavior of the DatabaseSchemaCalculator in the migration engine.
[x] build a binary that takes a Prisma connection url and introspects the database. The result is printed to stdout. This allows to try out the introspection internally.
[ ] create integration tests to test complex schemas in an end to end fashion. Foundation for those tests can either be our collection of database schema examples or the tests in the typescript version of this command.

We need the following commands/rpcs from the introspection engine, which are right now exposed by our TypeScript package prisma-db-introspection:

introspect - passing in a connection string, getting back a datamodel
listSchemas - when having Postgres, we need to be able to list the schemas for a database. Optimally in mysql we could also list the databases, when the rights allow it, it's optional though, as we can work around that in the init flow, where we use it as of now.
getDatabaseMetadata - Returns sizeInBytes and countOfTables of a concrete database (or schema in Postgres)

The RPC API for the introspection-engine is implemented now. The names of the RPCs are introspect, listDatabases and getDatabaseMetadata. All rpcs take exactly one parameter. Here is an example of one RPC:
{"id":1,"jsonrpc":"2.0","method":"introspect","params":[{"url":"file:/.../prisma/dev.db"}]}

Please note that the params are wrapped in array here. I tried out a new approach to define rpcs which is more ergonomic for us but requires this array.

Internal note: dropping, waiting for @do4gr to be back 🙌


third_party/repo.bzl file silently failed to apply patch

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution: Linux Ubuntu 16.04:
~Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:~
TensorFlow installed from (source or binary): source
TensorFlow version: master branch
Python version: 3
~Installed using virtualenv? pip? conda?:~
Bazel version (if compiling from source): 0.24.1
GCC/Compiler version (if compiling from source): 5.4.0
~CUDA/cuDNN version:~
~GPU model and memory:~

Describe the problem
git apply -v in bazel scripts sliently failed to apply a patch. This cause tensorflow build to fail in an unexpected way.
The reason why git apply -v silently failed is due to git apply does not work from within the local checkout of an unrelated git repository. In my setup, my home directory is a git directory used to sync up local development configuration files, and tensorflow build directory is under my home directory. This makes all tensorflow directories within the local checkout of a git directory (other than the one for project the patch is made for). Thus, at build time, the _apply_patch() subroutine will silently fail to apply any patch.
To fix, I will use the same patch command under either windows/linux to use the actual patch -p1 command rather than git apply, ie, use this line only. I didn't submit a PR because I'm not aware of why applying the patch need to branch on different OSes. If there is not a good reason to use git apply, I'd suggest to always use patch -p1 instead.
Provide the exact sequence of commands / steps that you executed before running into the problem

Place tensorflow root directory into a/any git directory
Compile tensorflow
Tensorflow compilation failed due to related patch not applied.

~Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.~

Just to verify did you get chance to follow instructions from TensorFlow website .Please, let us know. Thanks

@ravikyram Yes I do. Since official documentation never mentioned that it cannot be built from an existing git directory, it should not silently failing.

I don't think this is a Tensorflow issue, seems to be caused by your special environment settings.
Git inside git is quite a no-no, to be honest, unless you're working with git submodules.

@mihaimaruseac While I agree it is very configuration related, what's the point of using different ways of apply patch on different OSes (knowing such a pitfall exists in git apply)?
BTW, at the point when git apply silently fails, it is not in the

Git inside git

situation. It is in one level of git directory. It is due to bazel generated folders (symlink to /root/.cache) in a different git directory from where it is generated (TF).

The windows special casing was added in 87f2f24f957abb76ad80e16b26b7221ddd277752 Before that change, all code used git apply, since 8ec93550847eaf9289ff33403bb19fa78c097334 which changed from patch -p1 to git apply because patch -p1 on CentOS doesn't support renaming of files.
Adding interested parties

Sorry that this is causing trouble for you, and thanks Mihai for digging out the history and explaining the reason for the change. This was the best I could come up with to work around the limitations of patch on CentOS. Maybe there is a better way?

@mihaimaruseac @chsigg Thanks for explaining. Good to know the background knowledge on issue under CentOS. Given what the issue it is, I'd say the safest way to run git apply is to run it under the system root / where it is least likely to have git enabled (indicated by second point under this answer).
I'm glad I'm able to figure it out, because it has choked me periodically for a while. But now I wouldn't mind if you guys leave the code as is, as it is caused by deficiencies of tooling in different platforms. Anyways I have automated my environment to get rid of git wrapping around bazel's generated files.

The patch command is always a headache on Windows because it's not a native tool. Looks like it is also a problem for Centos due to old versions.
Bazel is implementing a native patch in Java, we'll expose an API repository_ctx.patch to allow users do patch in repository rules. It supports the most common features of patch command line tools (renaming, adding, deleting files), but will be more strict on the patch file content. This is still an ongoing work: https://github.com/bazelbuild/bazel/issues/8316.

@jerryyin  let me know if we can close this issue since it looks to be fixed. Thanks!

@ravikyram I knew the fix from beginning, but I would leave it open until the bazel implementation from @meteorcloudy is ready and replaced the logic here.

I am +1 on leaving open until Bazel version is in production


SEGV in async gRPC call

What version of gRPC and what language are you using?
1.24.x, C++
What operating system (Linux, Windows,...) and version?
Linux, Yocto Dunfell on Raspberry Pi 4.
What runtime / compiler are you using (e.g. python version or version of gcc)
GCC 9.3.0
What did you do?
I have simple service client running on Yocto. At some point I decided to try compile my app with -fsanitizer=address and I got SEGV report on a call.
What did you expect to see?
Application should have worked normally (or at least crash somewhere else under sanitizer environment).
What did you see instead?
Jan 14 02:37:17 raspberrypi4 XXX[1145]: AddressSanitizer:DEADLYSIGNAL
Jan 14 02:37:17 raspberrypi4 XXX[1145]: =================================================================
Jan 14 02:37:17 raspberrypi4 XXX[1145]: ==1145==ERROR: AddressSanitizer: SEGV on unknown address 0x0d518b1f (pc 0x006da62c bp 0x00000004 sp 0xb02f9538 T1)
Jan 14 02:37:17 raspberrypi4 XXX[1145]: ==1145==The signal is caused by a READ memory access.
Jan 14 02:37:18 raspberrypi4 XXX[1145]:     #0 0x6da628 in std::char_traits<char>::assign(char&, char const&) /opt/poky/3.1.3/sysroots/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/usr/include/c++/9.3.0/bits/char_traits.h:300
Jan 14 02:37:18 raspberrypi4 XXX[1145]:     #1 0x6da628 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_S_copy(char*, char const*, unsigned int) /opt/poky/3.1.3/sysroots/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/usr/include/c++/9.3.0/bits/basic_string.h:349
Jan 14 02:37:18 raspberrypi4 XXX[1145]:     #2 0x6da628 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_S_copy_chars(char*, char*, char*) /opt/poky/3.1.3/sysroots/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/usr/include/c++/9.3.0/bits/basic_string.h:393
Jan 14 02:37:18 raspberrypi4 XXX[1145]:     #3 0x6da628 in void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>(char*, char*, std::forward_iterator_tag) /opt/poky/3.1.3/sysroots/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/usr/include/c++/9.3.0/bits/basic_string.tcc:225
Jan 14 02:37:18 raspberrypi4 XXX[1145]:     #4 0xb61c2ab0 in grpc_impl::Channel::CreateCallInternal(grpc::internal::RpcMethod const&, grpc_impl::ClientContext*, grpc_impl::CompletionQueue*, unsigned int) (/usr/lib/libgrpc++.so.1+0x2bab0)
Jan 14 02:37:18 raspberrypi4 XXX[1145]:     #5 0xb61c2e2e in grpc_impl::Channel::CreateCall(grpc::internal::RpcMethod const&, grpc_impl::ClientContext*, grpc_impl::CompletionQueue*) (/usr/lib/libgrpc++.so.1+0x2be2e)
Jan 14 02:37:18 raspberrypi4 XXX[1145]:     #6 0x9add54 in grpc_impl::ClientAsyncResponseReader<xxxprotocol::Empty>* grpc_impl::internal::ClientAsyncResponseReaderFactory<xxxprotocol::Empty>::Create<xxxprotocol::TouchDataMsg>(grpc::ChannelInterface*, grpc_impl::CompletionQueue*, grpc::internal::RpcMethod const&, grpc_impl::ClientContext*, xxxprotocol::TouchDataMsg const&, bool) /opt/poky/3.1.3/sysroots/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/usr/include/grpcpp/impl/codegen/async_unary_call_impl.h:84
Jan 14 02:37:18 raspberrypi4 XXX[1145]:     #7 0x85f3f8 in xxxprotocol::SensorsService::Stub::AsyncSendTouchDataRaw(grpc_impl::ClientContext*, xxxprotocol::TouchDataMsg const&, grpc_impl::CompletionQueue*) /home/devel/xxx/build/service.grpc.pb.cc:122
Jan 14 02:37:18 raspberrypi4 XXX[1145]:     #8 0x7ded86 in xxxprotocol::SensorsService::Stub::AsyncSendTouchData(grpc_impl::ClientContext*, xxxprotocol::TouchDataMsg const&, grpc_impl::CompletionQueue*) /home/devel/xxx/build/service.grpc.pb.h:153
Jan 14 02:37:18 raspberrypi4 XXX[1145]:     #9 0x7ded86 in SensorsClient::SendTouch(unsigned int, float, float, xxxprotocol::TouchDataMsg_State) /home/devel/xxx/src/SensorsClient.cpp:69
Jan 14 02:37:18 raspberrypi4 XXX[1145]:     #10 0x7a1f3a in XXProtocol::handleInputChannelInputEvent(DataConstBuffer const&) /home/devel/xxx/src/protocol.cpp:655
Jan 14 02:37:18 raspberrypi4 XXX[1145]:     #11 0x7a6c2e in XXProtocol::handleInputChannelMessage(std::shared_ptr<Message> const&) /home/devel/xxx/src/protocol.cpp:672
Jan 14 02:37:18 raspberrypi4 XXX[1145]:     #12 0x7b2cbc in XXProtocol::receiveMessage() /home/devel/xxx/src/protocol.cpp:814
Jan 14 02:37:18 raspberrypi4 XXX[1145]:     #13 0x6f954c in MainThread::run() /home/devel/xxx/src/MainThread.cpp:21
Jan 14 02:37:18 raspberrypi4 XXX[1145]:     #14 0xb5d9c5fc  (/usr/lib/libQt5Core.so.5+0x955fc)
Jan 14 02:37:18 raspberrypi4 XXX[1145]:     #15 0xb69d244a  (/usr/lib/libasan.so.5+0x3044a)
Jan 14 02:37:18 raspberrypi4 XXX[1145]: AddressSanitizer can not provide additional info.
Jan 14 02:37:18 raspberrypi4 XXX[1145]: SUMMARY: AddressSanitizer: SEGV /opt/poky/3.1.3/sysroots/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/usr/include/c++/9.3.0/bits/char_traits.h:300 in std::char_traits<char>::assign(char&, char const&)
Jan 14 02:37:18 raspberrypi4 XXX[1145]: Thread T1 (MainThread) created by T0 here:
Jan 14 02:37:18 raspberrypi4 XXX[1145]:     #0 0xb69d24a4 in pthread_create (/usr/lib/libasan.so.5+0x304a4)

Anything else we should know about your project / environment?
Channel stub uses grpc::InsecureChannelCredentials(), which lead to empty host address in CreateCustomChannelImpl. Hope it helps.

I ran into a SIGSEGV as well in ClientAsyncResponseReaderFactory::Create, but with a different stack trace.
GRPC version: 1.30.1, C++
Compiler: gcc version 7.5.0
*** Signal 11 (SIGSEGV) (0x0) received by PID 41 (pthread TID 0x7fb67f259700) (linux TID 189) (code: address not mapped
    @ 00007fb6ea4968b3 folly::symbolizer::(anonymous namespace)::signalHandler(int, siginfo_t*, void*)
                       /src/folly/folly/experimental/symbolizer/SignalHandler.cpp:431
    @ 00007fb6e76a697f (unknown)
    @ 00007fb6ec6e71b7 je_arena_dalloc_promoted
                       /src/jemalloc/include/jemalloc/internal/extent_inlines.h:261
                       -> /src/jemalloc/src/arena.c
    @ 00007fb6ec6d9138 je_free_default
                       /src/jemalloc/include/jemalloc/internal/arena_inlines_b.h:300
                       -> /src/jemalloc/src/jemalloc.c
    @ 00007fb6e305d4c8 grpc_impl::ClientAsyncResponseReader<rockset::Schedule2Response>* grpc_impl::internal::ClientAsyncResponseReaderFactory<rockset::Schedule2Response>::Create<rockset::Schedule2Request>(grpc::ChannelInterface*, grpc_impl::CompletionQueue*, grpc::internal::RpcMethod const&, grpc_impl::ClientContext*, rockset::Schedule2Request const&, bool)
                       /usr/local/include/grpcpp/impl/codegen/async_unary_call_impl.h:83

Would you provide a small repro?


adding radius to the parameters of function nearest

This PR adds to the function nearest the parameter radius which is used when calling internally to nearest_step.
Tests are also modified accordingly.

You have a point:
The new knn is equivalent to within when num >= n, where n is the number of elements in the kdtree. Let me check if the algorithm are equally efficient. If that is the case, within may be deprecated.

After reviewing the implementations, both methods are almost equivalent.
I suggest maybe to rename the "new unified" method to "query", for example:
pub fn query<F>(
        &self,
        point: &[A],
        num: usize,
        radius: A,
        distance: &F,
    )

if num = self.size --> within and
if radius = infinity --> nearest
What do you think?

Yeah we should unify the two existing methods
Shall we keep the nearest name and deprecate within as the returned result are ordered by distance - query seems too generic to indicate that?

That is OK. To deprecate within, should I use #[deprecated] macro?

don't feel it's necessary but up to you

I think now it is ready for merging


xlogy grad wrong at 0

MWE:
module MWE

using LogExpFunctions: xlogy
using FiniteDifferences
using Enzyme

# function xlogy(x::Number, y::Number)
#     result = x * log(y)
#     return iszero(x) && !isnan(y) ? zero(result) : result
# end

f(x) = xlogy(x[1], 23.0)

x = [0.0]

finitediff = FiniteDifferences.grad(central_fdm(5, 1), f, x)[1]
grad_forward = Enzyme.gradient(Enzyme.Forward, f, x)
grad_reverse = Enzyme.gradient(Enzyme.Reverse, f, x)
@show finitediff
@show grad_forward
@show grad_reverse

end

Commented out is the actual body of xlogy.
Output:
finitediff = [3.1354942159291497]
grad_forward = (0.0,)
grad_reverse = [0.0]

The iszero(x) throws things off. E.g. ForwardDiff.jl and ReverseDiff.jl deal with this by depending on DiffRules.jl, which defines a rule here: https://github.com/JuliaDiff/DiffRules.jl/blob/8842177391b07dcd8234ac7612b9ca8ca72d28e0/src/rules.jl#L305
Could Enzyme do the same?

Completed here: https://github.com/EnzymeAD/Enzyme.jl/pull/1615


KAFKA-5311: Support ExtendedDeserializer in Kafka Streams.

The contribution is my original work and that I license the work to the project under the project's open source license.

with the refactor moving the methods to the serializers, i note you updated client Fetcher, can the client KafkaProducer, and MockProducer be updated also.

@subnova thanks, LGTM now.

This PR is still lacking some unit test for headers.

Meta question: why is this PR not opened against trunk ?

We need a new PR against trunk (ideally with the requested unit tests) very soon for it to have a chance of being included in <IP_ADDRESS>.

Please see #3199 for new PR against trunk.

Please close this PR since the other one was merged.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5382/
Test PASSed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5397/
Test PASSed (JDK 7 and Scala 2.11).


Update dependencies and make pysqlite3-binary optional

Updating langchain and openai to the latest versions.
Make pysqlite3-binary optional because it has binaries only for Linux, it can be installed with poetry install -E pysqlite3-binary

Looks good to me. Just checking - have you tested this branch with the olas agent?

Looks good to me. Just checking - have you tested this branch with the olas agent?

I used this with both olas and evo agents in your benchmarks.
Or do you mean if I tried it in Olas mech? If so, I didn't 🤔 But as long as we don't bump up version there, it should use the old code, right?

I used this with both olas and evo agents in your benchmarks.

Yeah that's all I meant!


Update README.md

Reversed the link and text

Dang, I totally missed this PR. We've since updated the readme, but thanks for the contribution anyway! :)

No worries I liked the framework.!


Add Hindi translation

Change proposed in this pull request

Translate the basic strings to Hindi

close: #229

Thank you for your contribution

Codecov Report

Merging #253 (2e16bfc) into master (abdb9fd) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #253   +/-   ##
======================================
  Coverage    8.25%   8.25%
======================================
  Files           3       3
  Lines         642     642
  Branches       99      99
======================================
  Hits           53      53
  Misses        589     589

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Added code for contributions section

[ ] This fix resolves #481
[ ] The changes follow the contributing guidelines
[ ] I have verified the fix works and introduces no further errors
I have added code for fetching but homepage.tsx is not able to import the data from index.astro file please have a look at it

@jdwilkin4 I wrote the code as you mentioned and it was working fine then I started working on the layout but then out of nowhere, this error popped out. Please help and check it

@aksy2512
As for your error message, it is not showing up on my end.
It looks like maybe you had a an array called data2 but then removed it.
Maybe you can try stopping and restarting the server to see if the error goes away.
You could also reach out to the This Dot Labs community on discord and see if someone spots something that I missed to cause this error

@jdwilkin4  Thanks for the reply, The error was resolved after restarting the server. Can u please give me an idea about where can I add the style in the contributor-banner.css.ts file since no visible effect is seen in the page if I am adding some code

since no visible effect is seen on the page

If you edit any of the values for the properties, you will see the changes in the contributor banner.
For example, if you edit the value for the gridTemplateColumns in the contributorBannerStyle to something like this gridTemplateColumns:"2fr", then you will see the change in your browser.
gridTemplateColumns:"2fr" won't get you the style you are looking for, but if you keep playing around with it as well as the others, then you will be able to reproduce the design we are looking for.

@jdwilkin4 I played around with it but wasn't able to change the relative positions of the images of the contributors in grid form. Can you please help me?

In order to help you, I need to see your code.
Please push up your latest changes

I have added some code in the contributor-banner-style.css
The grid is formed as shown below, the issue was that the position of the images wasn't able to change

@jdwilkin4 I wrote the code as you suggested to me. Please have a look and inform me if any change is required

If you feel like your PR is ready for review, you should bring it out of draft status and mark it ready for review 👍

@jdwilkin4 Can you assign me some more issues like this?

I would suggest looking through the open issues that aren't assigned to team members and see if there are any issues that you are interested in. Then you can reply back on the open issue and asked to be assigned.


Remove lit tests that just check round-tripping

All of these should be covered by assertParse tests.

@swift-ci Please test


E/Z and CIS/TRANS stereo bonds are incorrectly matched

Example:
from rdkit import Chem

mol = Chem.MolFromSmiles(r'C/C=C/C')

query = Chem.MolFromSmiles(r'C/C=C/C')
bond = query.GetBondWithIdx(1)
bond.SetStereoAtoms(0, 3)
bond.SetStereo(Chem.BondStereo.STEREOTRANS)

assert mol.HasSubstructMatch(query, useChirality=True)
-----
<ipython-input-2-63fb196a0558> in <module>()
      9 bond.SetStereo(Chem.BondStereo.STEREOTRANS)
     10
---> 11 assert mol.HasSubstructMatch(query, useChirality=True)

AssertionError:

This happens because of stereo labels are matched like this:
https://github.com/rdkit/rdkit/blob/cb64898b3d0725624138f4fcf99c9a277e89010a/Code/GraphMol/Substruct/SubstructMatch.cpp#L190-L194

@ricrogz : I'm not sure whether or not this particular bug fits within the scope of the work done for this PR:
In [2]: m = Chem.MolFromSmiles('C/C=C(/C)O')

In [3]: ps = Chem.SubstructMatchParameters()

In [4]: ps.useChirality = True

In [9]: m.GetSubstructMatch(Chem.MolFromSmarts(r'C/C=C/*'),ps)
Out[9]: (0, 1, 2, 3)

In [10]: m.GetSubstructMatch(Chem.MolFromSmarts(r'C/C=C\*'),ps)
Out[10]: (0, 1, 2, 3)

It's awesome that this works:

ps.useChirality = True

@ricrogz : I'm not sure whether or not this particular bug fits within the scope of the work done for this PR:

Speaking from the top of my mind, I think the 'problem' there is that MolFromSmarts() does not assign bond stereo labels, and that Substructure Matching does not consider bond directions.
So, you call AssignStereochemistry() or manually add the labels, then it works.
I'd say that is a different PR (like 'assign stereo bond labels to mols parsed from SMARTS'), one which I already have up my sleeve :)

Actually, that PR I have in mind reuses/moves around a couple of thins I added in #2553, so I was waiting for that to go in before I opened a new PR moving the stuff.

I'd say that is a different PR (like 'assign stereo bond labels to mols parsed from SMARTS'), one which I already have up my sleeve :)

Yep, that's a better solution.


Add snippet page is also not responsive on mobile.

          Hey @notsoocool, I observed add snippet page is also not responsive on mobile.

Can I work on that under this issue or raise separate issue.

Originally posted by @ZayedShahcode in https://github.com/notsoocool/codecache/issues/39#issuecomment-2395452518

@ZayedShahcode need you comment here to assign you the issue and further closeit

Ok sure.


where to start?

Hi, is there a guide to using this part of the code? I don't know which code to start with. I want to build a unisensory model that is similar to this paper (''Causal inference accounts for heading perception in the presence of object motion''). But I have lost my way in calculating the posterior probability and the model structure......
Thanks!

Hi yvesyyh - the code for the log-likelihoods is in the visvest-causinf/VestBMS_ModelWork/private/ folder. Specifically, unisensory models for left/right decisions are represented by this function: https://github.com/lacerbi/visvest-causinf/blob/master/VestBMS_ModelWork/private/VestBMS_UnimodalLeftRightDatalike.m
(but there is not much model structure for unisensory part).
I am only vaguely familiar with the paper you mention, so perhaps you could email Kalpana Dokka (first author of that study, and my co-author in this one); she might be able to answer specific questions or even provide code specifically for that paper.

Thank you so much!
At 2020-03-21 19:51:19, "Luigi Acerbi"<EMAIL_ADDRESS>wrote:
Hi yvesyyh - the code for the log-likelihoods is in the visvest-causinf/VestBMS_ModelWork/private/ folder. Specifically, unisensory models for left/right decisions are represented by this function: https://github.com/lacerbi/visvest-causinf/blob/master/VestBMS_ModelWork/private/VestBMS_UnimodalLeftRightDatalike.m
(but there is not much model structure for unisensory part).
I am only vaguely familiar with the paper you mention, so perhaps you could email Kalpana Dokka (first author of that study, and my co-author in this one); she might be able to answer specific questions or even provide code specifically for that paper.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Coverage tweaks.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
see 11 files with indirect coverage changes


Revamp admin module

Thoughts:

[x] 1. Remove clauses for new laws but mantain backwards compatibility for laws that are using it.
[x] 2. As we are removing clauses, improve the text truncation strategy on proposal-article view.
[ ] 3. Add sort & search to laws list (client side, no big deal).
[ ] 4. Add delete button on laws list.
[ ] 5. Remove admin sidebar (as we know it).
[x] 6. Replace checkboxes with toggle.
[ ] 7. Revamp link list like

:+1:
I think 4. should have a confirmation dialog as the one you see when attempting to delete an existing law inside the composer, or like what you see when removing a comment/reply.
How will you address tag management if you do 5.? Maybe I would remove the "Create" options and add a notiveable button on top of the "List" view, so you can tap there and just spin up the composer.

How will you address tag management if you do 5.? Maybe I would remove the "Create" options and add a notiveable button on top of the "List" view, so you can tap there and just spin up the composer.

I didn't think it enough yet. I agree with having an "Add" button on top of the lists, but I don't know yet how to switch between lists (maybe tabs?).

No tabs please

I was thinking in remove permanently the list/create page of tags and list and create a tag directly from the law new/edit form.

@jfresco,
I thought clauses could be a usefull tool to enable collaboration in creating new laws. The DOS use model I had in mind would allow people to propose different clauses for discussion and voting. Ideally there would be a possibility to vote on each clause individually which is not supported by DOS at the moment. Then based on the voting results some of the clauses would make it into the law and some would be rejected.
Why do you want to remove clauses?

@tarasdudar Because we are implementing a rich text widget. Our intention is to encourage admin users to write the topic text in a unique place. You can still add clauses separating it by titles; also, you'll be able to nest clauses. Side comments will still work with this approach, so eventually will not be impossible to implement some feature at clause level.


Push mechanism to wait for priority execution down into diagnostics calculation.

Push mechanism to wait for priority execution down into diagnostics calculation.

Sounds like this approach won't work


Is Zeroshot evaluation on validation or test datasets

I want to ask which dataset used for Zeroshot evaluation for (MSVD, MSRVTT, TGIF), Is it the validation dataset or the test dataset

Hi @KerolosAtef ,
Thank you for your interest in our work. We use the validation set for MSVD and MSRVTT and the test set for TGIF. A copy of the annotation files have been attached in the links.
Thank you.


New Private field issues

I'm not sure if it's a regression and what would be its reason, but most of the time nowadays adding private fields fails as they are not rewritten correctly in every places. Example bellow.
Added
private CameraState _lastCamState;
One of the correctly rewritten part I believe
FastScriptReload.Scripts.Runtime.TemporaryNewFieldValues.ResolvePatchedObject<Indus.Client.Cameras.CinemachineBodyCollider__Patched_>(this)._lastCamState = state;
Some other places not rewritten
 Gizmos.DrawWireSphere(_lastCamState.FinalPosition, BodyRadius);
It is the NewFieldsRewriter job to perform the rewrite now not sure why it skip some cases.

So it seems this is the workaround for now
var myLocalNewField = _instanceNewField; // <= this gets correctly rewritten
myLocalNewField.DoesWhatYouWant();


want the datasets

Hi, I want to follow this work, can you send me the complete source code plus datasets to me?Thanks!

me too

me too

me too, may I ask whether you had got the dadasets? @ZihaoZheng98 @edwhelloworld @seanPudding

Can you tell me where I can get these datasets?

The text portion of the img-txt classification dataset and the NER dataset can be found in the references, and the image portion of the img-txt classification dataset in the:
https://www.dropbox.com/s/olkxuw8b9cy9i0q/Twitter_images.zip?dl=0
snap dataset：
https://urldefense.proofpoint.com/v2/url?u=https-3A__www.dropbox.com_s_pd1vakhl4hiyfe8_Twitter-5Fdatasets.tar.gz-3Fdl-3D0&d=DwMFAg&c=ncDTmphkJTvjIDPh0hpF_w&r=jrqKEl_yfpiP73TVOogW5A&m=gaZNWv7ktw8EF12vizEnHweCj-YguMeibD2-UdZaeYw&s=xBYDATNakNStRh5Wabn-RswsbUDvsoB3hUafPyGNKD8&e=
Some pre-processing of the dataset is required to make the code work correctly

Thank you for your work!
I am trying to repeat your paper and need to use TRC dataset. You have kindly provide its images from https://www.dropbox.com/s/olkxuw8b9cy9i0q/Twitter_images.zip?dl=0
And I get text from the .csv file in this project https://github.com/danielpreotiuc/text-image-relationship.
But they seem to not match. Can you give me a hand?
Thank you again!

The text portion of the img-txt classification dataset and the NER dataset can be found in the references, and the image portion of the img-txt classification dataset in the: https://www.dropbox.com/s/olkxuw8b9cy9i0q/Twitter_images.zip?dl=0 snap dataset： https://urldefense.proofpoint.com/v2/url?u=https-3A__www.dropbox.com_s_pd1vakhl4hiyfe8_Twitter-5Fdatasets.tar.gz-3Fdl-3D0&d=DwMFAg&c=ncDTmphkJTvjIDPh0hpF_w&r=jrqKEl_yfpiP73TVOogW5A&m=gaZNWv7ktw8EF12vizEnHweCj-YguMeibD2-UdZaeYw&s=xBYDATNakNStRh5Wabn-RswsbUDvsoB3hUafPyGNKD8&e= Some pre-processing of the dataset is required to make the code work correctly

This link has no Snap dataset "https://urldefense.proofpoint.com/v2/url?u=https-3A__www.dropbox.com_s_pd1vakhl4hiyfe8_Twitter-5Fdatasets.tar.gz-3Fdl-3D0&d=DwMFAg&c=ncDTmphkJTvjIDPh0hpF_w&r=jrqKEl_yfpiP73TVOogW5A&m=gaZNWv7ktw8EF12vizEnHweCj-YguMeibD2-UdZaeYw&s=xBYDATNakNStRh5Wabn-RswsbUDvsoB3hUafPyGNKD8&e=". Could you provide a new link? Thank you very much!

感谢您的工作！ 我正在尝试重复您的论文，需要使用 TRC 数据集。您好心地从https://www.dropbox.com/s/olkxuw8b9cy9i0q/Twitter_images.zip?dl=0提供了其图像，我从该项目https://github.com/danielpreotiuc/text-image-relationship 中的 .csv 文件中获取了文本。 但它们似乎不匹配。您能帮我一下吗？ 再次感谢您！

The same question, how did you solve it? thank you


chore: release 2.0.0

:robot: I have created a release *beep* *boop*
2.0.0 (2020-05-19)
⚠ BREAKING CHANGES

dropp support for custom promises (#970)
convert to typescript (#923)
deps: update dependency @google-cloud/projectify to v2 (#929)

Bug Fixes

docs: link to correct gaxOptions docs (#999) (312e318)
regen protos and tests, formatting (#991) (e350b97)
remove eslint, update gax, fix generated protos, run the generator (#955) (544a061)
remove unused dependencies (#998) (7b242a3)
close: ensure in-flight messages are drained (#952) (93a2bd7)
deps: update dependency @google-cloud/paginator to v3 (#931) (b621854)
deps: update dependency @google-cloud/precise-date to v2 (#934) (72b8d78)
deps: update dependency @google-cloud/projectify to v2 (#929) (45d9880)
deps: update dependency @google-cloud/promisify to v2 (#928) (3819877)
deps: update dependency google-auth-library to v6 (#935) (73fc887)

Build System

convert to typescript (#923) (2fc68ba)

Miscellaneous Chores

dropp support for custom promises (#970) (df462d3)

This PR was generated with Release Please.

Because I haven't gotten my release-please changes merged yet, this one has to be done by me running my updated version locally. I want to get that in soon, but for now I'll probably need to get someone else to review since it looks like it is my PR.

The changelog is busted on this, probably because of my earlier testing shenanigans. I'm going to just close this and re-open a new one.


Dep init failed

The latest istio source tree
dep init
Importing configuration from glide. These are only initial constraints, and are further refined during the solve process.
Importing configuration from glide. These are only initial constraints, and are further refined during the solve process.
....
init failed: unable to solve the dependency graph: Solving failure: package k8s.io/apimachinery/pkg/apis/meta/v1/unstructured/unstructuredscheme does not exist within project k8s.io/apimachinery

We recently moved to using go modules, I think we don't support/use dep anymore

Yes, we can no longer support dep since we moved to go modules, and the two don't agree on dependency resolution.


Trim down forest_ipld in preparation for removal

Summary of changes
Changes introduced in this pull request:

Remove our custom ipld! macro.
Remove Path and PathSegment.
Move testing functions out of the ipld_blockstore crate.

Reference issue to close (if applicable)

Closes #1692
Other information and links

Too much tree traversal here to wrap my head around it. Do the current tests cover all of the modified code?

They do not. Added a few more tests. A lot more could be done here.


GCC 8.1 missing for C

GCC 8.1 is available for C++ and Assembly; however, it is missing for C.

Hi! Thanks for reporting this! It's true that we're missing GCC 8.1 due to a typo in our config. I'll fix it right now
:)

Confirmed, it is there. Astonishingly quick resolution, thanks a lot! :)


wireguard: Add support for managed K8s

This adds support for Wireguard on Cilium installations that use a IPAM mode which does not use a per-node pod CIDR range, namely most managed Kubernetes setups. I have tested this code manually with the connectivity check on AKS. The default node images on GKE and EKS do not have a recent enough kernel version to support Wireguard out of the box unfortunately. Nothing about this PR is cloud-vendor specific, so that should not be a blocker.
See the commit message for the implementation details.
Reviewer Note: This PR is a successor of #15514 which GitHub does not allow me to reopen or edit because it's base-branch has been deleted. Links to some previous discussions/comments:

Why watch the IPCache and not CEPs?
How to test on EKS

test-me-please

test-me-please

Forgot to update the unit tests when I removed the node IPs from the allowedIP list. Rerunning CI again.

test-me-please

Travis CI failed with:
#7 25.17       gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -DTHREAD_STACK_SIZE=0x100000 -fPIC -I/usr/local/include/python3.7m -c /tmp/pip-install-ekmpejo_/cython_7be74ff484644e10a7893304a8a5500f/Cython/Plex/Scanners.c -o build/temp.linux-x86_64-3.7/tmp/pip-install-ekmpejo_/cython_7be74ff484644e10a7893304a8a5500f/Cython/Plex/Scanners.o

#7 25.17       unable to execute 'gcc': No such file or directory

#7 25.17       error: command 'gcc' failed with exit status 1

#7 25.17       ----------------------------------------

#7 25.17   ERROR: Command errored out with exit status 1: /usr/local/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-ekmpejo_/cython_7be74ff484644e10a7893304a8a5500f/setup.py'"'"'; __file__='"'"'/tmp/pip-install-ekmpejo_/cython_7be74ff484644e10a7893304a8a5500f/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-5xmun0nr/install-record.txt --single-version-externally-managed --prefix /tmp/pip-build-env-51lpzc1k/overlay --compile --install-headers /tmp/pip-build-env-51lpzc1k/overlay/include/python3.7m/Cython Check the logs for full command output.

#7 25.17   ----------------------------------------

#7 25.17 WARNING: Discarding https://files.pythonhosted.org/packages/b5/fd/15638de2da0a5aa91c095718444624aa565f766fc178249ca6faa372f71a/PyYAML-5.4.tar.gz#sha256=3c49e39ac034fd64fd576d63bb4db53cda89b362768a67f07749d55f128ac18a (from https://pypi.org/simple/pyyaml/) (requires-python:>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*, !=3.5.*). Command errored out with exit status 1: /usr/local/bin/python /usr/local/lib/python3.7/site-packages/pip install --ignore-installed --no-user --prefix /tmp/pip-build-env-51lpzc1k/overlay --no-warn-script-location --no-binary :none: --only-binary :none: -i https://pypi.org/simple -- setuptools wheel Cython Check the logs for full command output.

#7 25.17 ERROR: Could not find a version that satisfies the requirement PyYAML==5.4

#7 25.17 ERROR: No matching distribution found for PyYAML==5.4

The CI is currently broken due to https://github.com/cilium/cilium/pull/15705.

restart-runtime

Forgot to mention the runtime had the same issue as Travis CI.

test-me-please

CI has passed. Addressed the critical review from @aanm and @brb. Marking as ready-to-merge.


Clarification on AstraZeneca PheWAS Data in Gene Burden Evidence Source

As a developer
I want detailed documentation or clarification on how the AstraZeneca PheWAS data was integrated into the Gene Burden evidence source
because there is a significant discrepancy in the number of unique target IDs (genes) between the AstraZeneca PheWAS raw data and the Open Targets Gene Burden dataset, which affects the comprehensiveness of the analyses.
Background
The Open Targets platform integrates gene burden data from various sources, including the AstraZeneca PheWAS data, under the Gene Burden evidence source. However, when downloading the raw data, I found a much smaller number of genes in the Open Targets dataset (~800 unique target IDs) compared to the AstraZeneca PheWAS raw data. It is unclear what processing or filtering was applied during integration, and the lack of detailed documentation makes it difficult to interpret this discrepancy.
I need clarification on the following:

What filtering or selection criteria were applied to the AstraZeneca PheWAS data when integrating it into Gene Burden?
Were any thresholds (e.g., variant frequency, statistical significance) used that may have reduced the number of genes included?
Is there any documentation on the specific steps taken to curate this data source?

Tasks

[ ] Update the documentation to provide clear details on the integration process for AstraZeneca PheWAS data in Gene Burden.
[ ] Confirm whether thresholds or filters were applied, and if so, make these clear in the Gene Burden source documentation.
[ ] Ensure the number of genes in the Gene Burden dataset reflects the scope of the AstraZeneca PheWAS study or explain any necessary reductions.

Acceptance Tests
How do we know the task is complete?

When I visit the documentation on the Gene Burden evidence source, I see a detailed explanation of the AstraZeneca PheWAS data integration.
The number of genes reported in the Gene Burden dataset aligns with the filtering/selection criteria, or there is a clear justification for any differences.
Any thresholds (variant frequency, significance, etc.) used during data processing are documented and easy to access.

Hi @nickzren, the discrepancy you're seeing between the AZ PheWAS raw data and our Gene Burden dataset is due to a couple of key filters applied during the integration:

A p-value threshold of 1e-7, which reduces the number of included associations. This threshold is extracted from their manuscript.
A specific set of burden methods, as described in the METHOD_DESC section of the code, that takes into consideration the variants considered in the analysis.

This is all available in the module that converts this data into target/disease evidence (https://github.com/opentargets/evidence_datasource_parsers/blob/master/modules/AzGeneBurden.py#L92)
While the documentation doesn’t reflect every filtering step, I agree that specifying p-value thresholds across all sources would be helpful, and we’ll work on that. For more detailed questions like this, our community forum is a great place to connect with others working on similar topics.
I hope that is helpful!

Very helpful, thank you @ireneisdoomed

Glad to see this resolved. @ireneisdoomed, please feel free to add any additional actions in new tickets.


Sample code for inserting charts into spreadsheet is not working

It edits the file and when I open the file it shows

The sample code(for C#) was provided here :- https://docs.microsoft.com/en-us/office/open-xml/how-to-insert-a-chart-into-a-spreadsheet

@Rohan-git-hub, can you provide the version of the Open XML SDK that you're targeting?

Just FYI, I tested the sample code with the latest SDK from github and with V2.5 and they both had that same behavior. We will have to create a new sample to demonstrate how to add the chart as it looks like this hasn't worked for a long time.

@tomjebo I am using Open XML SDK version 2.9.1

Hi @tomjebo any update on this and can you please share an alternate resource for the same.

I'm running into the same issue. Is there any update or workaround or other resource on the internet that explains it correctly?

I've managed to get the C# sample code working, simply by replacing the link in the C# example
graphicFrame.Append(new Graphic(new GraphicData(new ChartReference()            { Id = drawingsPart.GetIdOfPart(chartPart) })
        { Uri = "https://schemas.openxmlformats.org/drawingml/2006/chart" }));

with
graphicFrame.Append(new Graphic(new GraphicData(new ChartReference()            { Id = drawingsPart.GetIdOfPart(chartPart) })
        { Uri = "http://schemas.openxmlformats.org/drawingml/2006/chart" }));

Hopefully this helps.

@archerofthemark Thanks for letting us know!

closed by

#296


Fixed issue #2 updated UI

@pvgupta24 @mishal23 Please find attached the screenshots of the updated UI. The design is now responsive and the captions no longer overflow.

Great work @malikshubham827 :+1:

Good work @malikshubham827


Client Creation Tests for Blob Clients

[ ] The purpose of this PR is explained in this or a referenced issue.
[ ] The PR does not update generated files.

These files are managed by the codegen framework at Azure/autorest.go.

[ ] Tests are included and/or updated for code changes.
[ ] Updates to module CHANGELOG.md are included.
[ ] MIT license headers are included in each file.

/azp run go - azblob

LGTM.
You can also add tests for NewClientWithNoCredential if it's not already there.


[Task]: Incorporate standard libraries to support type-reference type

Description
$subject
Runtime issue for the effort on https://github.com/ballerina-platform/ballerina-standard-library/issues/3517
Describe your task(s)
No response
Related area
-> Runtime
Related issue(s) (optional)
#36855
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

blocked on #38306

The progress of this task can be tracked in the doc
https://docs.google.com/spreadsheets/d/1_LcB807WqZufmtvowgoDHZ4sqWOk-FqylughQv4w16w/edit?usp=sharing

[x] level 1 - constraint, io, xmldata modulesfixed
[x] level 2 - serdes module fixed
[x] level 3 - file, FTP, mime, TCP, UDP modules fixed
[ ] level 4
[ ] level 5
[ ] level 6
[ ] level 7
[ ] extended libraries


Slave not downloading new zonefile upon update

Version: unbound-1.9.6 from OpenSuSE Tumbleweed
I think this is a documentation issue and/or a feature request.  The
symptom is, I have a master, two slaves, and leaf nodes, all running
unbound.  The slaves fail to download new zonefiles upon updates.  The
auth-zone section on the slaves, after (successful) workarounds, goes
like this:
auth-zone:
name: "cft.ca.us."
master: <IP_ADDRESS>
url: "http://<IP_ADDRESS>/unbound-master/cft.zone"
zonefile: "/var/lib/unbound/slave/cft.zone"
Workaround #1: By reading the source code I discovered that unbound (as
a slave) can make AXFR/IXFR queries to retrieve a zone but (as master)
cannot respond to them.  This corresponds to my experience when I had
Bind running on the master.  Doing the URL thing got the zonefiles
coming in.  I wish the documentation had been a little clearer on this
point.  And I'd like to up-vote the feature request to add AXFR/IXFR
responses, so unbound can be a complete DNS server solution.
Workaround #2: One of the DNSSEC tutorials had a great photo of a
chicken looking at an egg.  Initially my URL was
"https://jacinth.cft.ca.us:1447/unbound-master/cft.zone".  But the 'A'
and AAAA records for Jacinth are in the zonefile that unbound is trying
to download.  Thus the download didn't happen.  I realized that
Jacinth's webserver is restricted to the internal net and VPNs, so I
could just switch to http://IPADDR/.  Now it's downloading.  I think
it would be helpful to warn users in the man page about this chicken
and egg issue.
How about a feature request: make a generic pair of commands:
local-data-hint: "name TTL type value" and hint-file: "zonefile-name".
This would have the same effect as root-hints, and in fact could replace
that command (except for the backward compatibility issue), but it could
be used in any context, specifically auth-zone: (and forward-zone:?)
Then the hostname in the url: and other parameters could be given
alphabetically, making the config file more rmaintainable.

Thank you for the description on making this work.
I had not realized that we need warnings to avoid circular lookup dependencies on the name used to look up the data.  Using a plain IP address is the best solution.  It is better than the hint solution you suggest.  (And also what we suggest users of NSD, our authoritative DNS server, to use for configuration.)  Otherwise you end up relying on the DNS infrastructure to be up in order to make the DNS infrastructure work, but with a plain IP address this dependency is not there, and thus, in the network, the services can come on-line independent of the other parts.
AXFR/IXFR service would be a nice feature, but I'll close this as a documentation bugreport.  If you really need it, we have NSD, a server that does authoritative only service.  And it provides AXFR (but not IXFR) service for zones.  And also sends NOTIFY messages to downstream servers so that they fetch the data.
By the way, unbound is capable of receiving NOTIFY messages to make it fetch from the url (or from the master) if you want that. It can be triggered by shell script with something like eg. dig +opcode=notify or ldns-notify, or with notify: or also-notify configuration statements.
Best regards, Wouter

On 2020-01-06 07:44, Wouter Wijngaards wrote:

If you really need it, we have NSD, a server
that does authoritative only service.  And it provides AXFR (but not
IXFR) service for zones.  And also sends NOTIFY messages to downstream
servers so that they fetch the data.

Thanks for your suggestions.  NSD looks very cool.  I'm impressed that
it's been adopted by several root and TLD servers, and with your
detailed audit of differences from Bind-9.  However I still need a
recursive and validating local server on the master site, so I think
I'll stick with Unbound with HTTP (URL) distribution of the updated zone
files, and ldns-notify.
I can see that the goals for Unbound and NSD are very different.
However, it's remotely possible that the internal data storage trees
might be sufficiently similar that the AXFR/IXFR code from NSD could be
extracted into a shared library and used also in Unbound.  Also, while
generating a AXFR response is simple but prolix, if you have thousands
or millions of zones in your TLD server, the IXFR would be a whole lot
less resource-intensive for the recipient.  It might be worthwhile to
implement IXFR just to help out the TLD deployments.
Also my "enterprise" is very small, but the possiblity of using Unbound
on the master site (as well as the slaves and the leaf nodes) with
traditional propagation by AXFR/IXFR, would really attract IT managers
to adopt Unbound throughout the enterprise.

Using a plain IP
address is the best solution.  It is better than the hint solution you
suggest.  (snip)   Otherwise you end up relying
on the DNS infrastructure to be up in order to make the DNS
infrastructure work,

Here's a problem: Suppose I use TLS in the URL with an IP; how do I
specify the target's name for Server Name Indication?  (Or is the #name
suffix for that purpose rather than for recognizing the peer?)  I don't
actually need TLS because the whole data path is under my control and
the payload is public record anyway, but that's not true for everyone.
I assume that with a hint, the various records (A, AAAA, NS) stay in the
cache and the server is allowed to use them, but as soon as DNS
infrastructure is alive enough to answer a query successfully, the hint
is overwritten with the answer.  With a hint the configuration or
included file has to be kept up to date with the referent's IP, but only
in one record, and the FQDN can then be used freely in multiple
configuration parameters.
--
James F. Carter   Email<EMAIL_ADDRESS>Web: http://www.math.ucla.edu/~jimc (q.v. for PGP key)

Hi @jimc-leones I didn't read your entire post (tldr;) but i noticed this part

However I still need a recursive and validating local server on the master site

How you been looking at www.powerdns.com by @ahupowerdns @habbie ?
PS: Sorry for mentions competitors from a different repo/project, but the end result should be the measurement tools, In the same manor that I recommends Unbound despite i use the recursor myself :smile:


feat: error state for homepage timeline

Trello Ticket 238:

Implement error state for homepage timeline

 Error states for homepage timeline


Bad news

cc @therealprof
I think I made regression with FR field.
Now there is no access to field enums to compare they manually. It's my mistake. Big mistake.
It doesn't break most of code, but it's regression.
I think we should revert #343.
Alternative is to add values method to reader.

Well, the release is out. But I'm not even sure that was intentional that one could do that. Do you see any usecase for that?


Be able to reorganize categories

For example, in the sidebar of Pikachu and other templates, I would like Certifications to be right under Email Address, with Skills and Hobbies being at the bottom. I'm not sure of how to move entire sidebar sections, though.

You can use the Layout section on the right sidebar to move sections across or within blocks. For what you are asking, all you need to do is drag and drop the Certifications to the top of Block 1 and Skills and Hobbies can go right under that. Here are a few screenshots that might help:


No HDD available space check

If it's still time for the 1.0 release, that would be nice to add a check of the available space on the HDD before starting to download the blockchain.
I found out after 120Gb of download that I had plugged the wrong HDD and that obviously that wouldn't be enough for a >250gb blockchain =)
I know, all blame is on me, but still, that would be nice!

Thanks for sharing your experience. I added a small HDD size check for version 1.0 release.

Great!


Character switch bug

Describe your bug here.
when i use character switch event (at 00:49 into the song) even if i put GF, Dad or Bf: it only changes BF
but when i use the event in any other part of the song it works normally
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
Yes, pretty much just added two custom events

Value 1:
0: bf
1: dad
2: gf
Value 2:
(Character name

Value 1: 0: bf 1: dad 2: gf
Value 2: (Character name

thanks


[Feature] Implement GSAM optimizer

Problem (Why?)
Implement a new optimizer, GSAM.
Solution (What/How?)

[x] implement GSAM optimizer
[x] implement rho scheduler

Other changes (bug fixes, small refactors)
nope
Notes
version to v2.2.0

Codecov Report

Merging #94 (4f1681c) into main (c3138f5) will decrease coverage by 1.05%.
The diff coverage is 79.28%.

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   97.66%   96.62%   -1.05%
==========================================
  Files          34       37       +3
  Lines        2403     2520     +117
==========================================
+ Hits         2347     2435      +88
- Misses         56       85      +29

Impacted Files
Coverage Δ

pytorch_optimizer/lr_scheduler/proportion.py
21.73% <21.73%> (ø)

pytorch_optimizer/optimizer/utils.py
88.18% <25.00%> (-7.74%)
:arrow_down:

pytorch_optimizer/base/scheduler.py
96.00% <96.00%> (ø)

pytorch_optimizer/__init__.py
100.00% <100.00%> (ø)

pytorch_optimizer/base/exception.py
100.00% <100.00%> (ø)

pytorch_optimizer/base/optimizer.py
97.43% <100.00%> (ø)

pytorch_optimizer/lr_scheduler/linear_warmup.py
100.00% <100.00%> (ø)

pytorch_optimizer/optimizer/adabelief.py
97.29% <100.00%> (ø)

pytorch_optimizer/optimizer/adabound.py
100.00% <100.00%> (ø)

pytorch_optimizer/optimizer/adai.py
100.00% <100.00%> (ø)

... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add mapMaybe and mapMaybeWithKey (issue #59)

They share the implementation with filter and filterWithKey, without affecting their structure reuse.
This fixes issue #59.

Merged, thanks!


WarcReader/GunzipChannel to check ByteBuffer in constructor

The classes WarcReader and GunzipChannel both have a public constructor taking a ByteBuffer as argument. It's silently assumed that the ByteBuffer

is backed by an array
is already in read mode (.flip() called)
(WarcReader only) the buffer's byte order is big-endian - otherwise the detection of the gzip magic fails

The constructors should put the buffers into correct state (if possible) or throw immediately throw an IllegalArgumentException. Alternatively, the constructors taking "external" could be removed or made non-public.

Unit tests are partially implemented (see 00effbd). However, I would like to discuss the expected behavior first. Comments welcome!

Ah, yeah. The buffer handling is one aspect of the design I've never been totally confident of. What I was originally trying to aim for was minimizing the amount of buffers and data copies. Passing in a (potentially pre-populated) buffer was meant as an alternative to using some sort of PushbackInputStream. Just using it internally and not exposing it would indeed be one option or perhaps just documenting it as some sort of 'advanced' API that is only meant to be used in special cases.

is backed by an array

For Java 11+ I was hoping to eliminate this requirement as there's now an Inflater.inflate(ByteBuffer). But yes I guess it makes sense to check this early and throw an exception so it's clearer which buffer is the one to blame.

is already in read mode (.flip() called)

Is it actually possible to detect that?

the buffer's byte order is big-endian - otherwise the detection of the gzip magic fails

Ah, of course. It hadn't occurred to me at all that someone would pass in a little-endian buffer. I guess it makes sense to set it. Or actually.. maybe we should save the current endianess and set it back after reading the gzip header? That way if the caller plans to reuse the buffer afterwards for something else they aren't surprised its been changed on them.

Passing in a (potentially pre-populated) buffer was meant as an alternative to using some sort of PushbackInputStream.

Indeed, that could be the base for a couple of use cases when records can be selected by looking just into the header without actually parsing the entire record. I'll add a unit test for a pre-populated buffer.

Inflater.inflate(ByteBuffer)

Same problem, throws an exception if the buffer is read-only.

is already in read mode (.flip() called)

Is it actually possible to detect that?

No, there is no notion of "state" in the Buffer interface, the user must take care that .flip(), .compact() etc. are called appropriately. The problem with a buffer in "write mode" is that buffer get methods will read the data between position and limit (uninitialized, garbage or zeros). Calling .flip() twice will set position and limit to 0 which discards all buffered data. Hence, this would violate the use case of pre-populated buffers. In short, the user must call .flip() before passing the buffer to the constructor.
I'll open a PR soon to address the various cases best as possible.


debug

Coverage increased (+0.04%) to 55.796% when pulling 41fb9e01bb26f8ffd67a3f0c392af4bde6bd363a on debug-travis-failures into e1dfdb8047d7f63555481cb28a1b7cc027c9a8a7 on master.

Coverage increased (+0.04%) to 55.796% when pulling 41fb9e01bb26f8ffd67a3f0c392af4bde6bd363a on debug-travis-failures into e1dfdb8047d7f63555481cb28a1b7cc027c9a8a7 on master.

Coverage decreased (-0.01%) to 55.744% when pulling 1cbc2d3c576da2f4ef5c75c28ee8ee58005e0d02 on debug-travis-failures into e1dfdb8047d7f63555481cb28a1b7cc027c9a8a7 on master.


Fixed Reviews Card CSS tearing and enhanced font visibility for Rating font

Closes #6

[x] Adjusted the components in the review card to fit in the box and not tear out of the background
[x] Updated the font css for the review us and rating font

@Fulzelejayesh please check out the changes and Merge the PR if possible. If there's any problem with my PR do tell me so, I'll update that.

Looks good enough to me @PratyayDhond.


Fix https://github.com/dmwm/WMCore/issues/10745

@vkuznet Valentin, I just tested your code interactively and it will not fix the problem. See:
In [1]: value = "alan\r\nmalta"
In [2]: isinstance(value, str)
Out[2]: True
In [3]: if isinstance(value, str):
   ...:     value = bytes(value, 'utf-8')

In [4]: value
Out[4]: b'alan\r\nmalta'
In [5]: header = value.split('\r\n')
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-5-9324d14aaf57> in <module>
----> 1 header = value.split('\r\n')

TypeError: a bytes-like object is required, not 'str'

So, you convert the input value to py3 bytes type, but then you try to parse it with a py3 string.
Maybe what would need to be fixed is '\r\n' to b'\r\n', or an improved version of that.

@amaltaro you're right and I forgot to pass the byte string. Now the PR is updated.

Since I had to debug this code in a test agent, here is an implementation that seems to resolve this issue:
        headers = self._response_header.getvalue()
        if isinstance(headers, bytes):
            headers = headers.decode("utf-8")
        for header in headers.split('\r\n'):

and failures inside the client now result in something like:
RestClient.ErrorHandling.RestClientExceptions.HTTPError: HTTP Error 400: Bad Request

Valentin, if you agree, can you please update this PR with the code provided above? Thanks

Thanks, Valentin. It looks good to me.
@yuyiguo Yuyi, would you be able to run some extra tests/checks with this patch, and if you are happy, merge and release a new version of the python3 dbs3-client?

@amaltaro
We are in the middle of transferring DBS Client and PyCurl client into two different repositories PyCurlClient  and DBSClient  that are move out of DBS repo.  These new repos are python 3 and fully tested. The code you have is here in the new repo:
https://github.com/dmwm/PycurlClient/blob/main/src/python/RestClient/RequestHandling/HTTPResponse.py#L13 .
However, my summer student did not have the time to make the library working with CMS's special voms . I am going to work on this myself.  If it is possible that you could wait for the new code?

This is the code that should be looking/loading the user certificate: https://github.com/dmwm/PycurlClient/blob/main/src/python/RestClient/AuthHandling/X509Auth.py#L39
Maybe it's just a matter of exporting X509_USER_PROXY before importing dbsApi.

A different issue. The cert was found and put there were errors to use them . We had briefly discussed during Neil's final presentation.

@amaltaro , done, please review again.

Thanks, Valentin. These changes look good to me!
It just occurred to me that we actually need these changes to be done against the branch py3-4-wm. We could either create another PR pointing against that specific branch, or edit this PR and see whether we can successfully point it to py3-4-wm branch. @vkuznet would you be able to do so?
@yuyiguo if you are back from vacation today, is there any chance that you could merge it and cut a new tag (e.g. 3.16.2001)? With that, we could build a clean RPM. Otherwise, I will try applying a patch at the spec file and keep the same version (but it's somehow ugly).

@yuyiguo thanks for looking into this.
I'm planning to release a final stable WMAgent release before the day is over tomorrow/Tuesday, and even though this fix is not critical, I think it would be an advantage to have this in and avoid unnecessary tracebacks in our logs.
So, if it's not too much extra effort, I would suggest to proceed with this bugfix (actually the one made against branch py3-4-wm) and cut a new tag. Then tomorrow I can make a cmsdist PR and build the new dbs3-client/dbs3-pycurl-client tag together with a new version of WMAgent, to be used in production.
I'm not aware of any other issues, so I think it would be the last client issue to be dealt with from this repository ;)

#695 merged.

Given that these changes are not required to the master branch (required changes were already merged in the python3 py3-4-wm branch), and that it looks like DBSClient and PycurlClient repositories already have these fixes in, shall we close this PR?


refactor(media): now gallery view for all images of post list sorted by added time

this PR resolves #57

:tada: This PR is included in version 1.0.0-dev.4 :tada:
The release is available on:

v1.0.0-dev.4
GitHub release
v1.0.0-dev.4

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

v1.1.0
GitHub release
v1.1.0

Your semantic-release bot :package::rocket: