[BUG] - Unable to install in Rocky Linux 9, failed dependencies: libcrypto.so.10()(64bit)

Description
With the provided script the installation fails due to a dependency error.
Execute the installation script: curl --proto '=https' --tlsv1.2 -sSLf "https://git.io/JBhDb" | sh Say yes to root access and put your password, then the error occurs.
Expected behaviour
termscp gets installed correctly on the system.
Environment

OS: GNU/Linux Rocky Linux 9
Architecture x64
termscp version 0.9.0

Log
`Termscp configuration

Platform:      linux
Arch:          x86_64
? Install termscp 0.9.0? [y/N] y
Detected rpm on your system
Installing termscp via RPM package
Downloaded rpm package to /tmp/tmp.hHwDD33kDi.rpm
! Root permissions are required to install termscp…
Installing termscp as root, please wait…
error: Failed dependencies:
libcrypto.so.10()(64bit) is needed by termscp-0.9.0-1.el7.x86_64
libcrypto.so.10(OPENSSL_1.0.1_EC)(64bit) is needed by termscp-0.9.0-1.el7.x86_64
libcrypto.so.10(OPENSSL_1.0.2)(64bit) is needed by termscp-0.9.0-1.el7.x86_64
libcrypto.so.10(libcrypto.so.10)(64bit) is needed by termscp-0.9.0-1.el7.x86_64
libssl.so.10()(64bit) is needed by termscp-0.9.0-1.el7.x86_64
libssl.so.10(libssl.so.10)(64bit) is needed by termscp-0.9.0-1.el7.x86_64
`

Additional information
In Rocky Linux 9 the only version available for openssl and compat-openssl is 11, and I think termscp requires openssl 10.

Duped of #124


Move doc "Onboard DPG in SDK Automation Pipeline" to Wiki

move doc https://aka.ms/onboard-dpg-in-sdk-automation to wiki https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/10/Welcome-Service-Partners!

doc link: https://aka.ms/onboard-dpg-in-sdk-automation


Unable to download updates using linux gui client on steam deck oled 512gb

rusty-psn_2024-08-05_18-40-09.log
Also unable to download stuff off nopaystation because of a name resolution failure. Might be connected. Suddenly couldnt download anything on rust psn and nopaystation.

ConnectError("dns error", Custom { kind: Uncategorized, error: "failed to lookup address information: Temporary failure in name resolution" }

DNS issue on your side, or your DNS provider's. Also, please don't bring up piracy sites - it's unrelated to my tool and I'd really rather not have that here.


[RDBMS] Added support for minimal tls version and deny public access

This PR add an ability to provide the --minimal-tls-version and --public-network-access properties for create and update server
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

@yonzhan , @Juliehzl  and @haroldrandom could you guys help include this in S167 https://github.com/Azure/azure-cli/milestone/84

add to S167

/azp run


logo added to station

added logo to topbar and sidebar

@stuartish I had these same build errors on this branch https://github.com/revelrylabs/station-yart5/pull/1, which I was told was actually safe to merge. So... I'm gonna merge this?


responsive

May I know how to make these slider captcha is responsive for any device size ? Thank you a lot

hi. use media query


Integrate with Pod security

What this PR does / why we need it:
Pod Security Standards shows Kubevirt still can't run as a restricted workload. Clusters enforcing restricted policy are not able to run VMs without manual adjustments of namespaces. There is also an issue with our upgrade path to the cluster that starts to enforce the policy.
This PR enables opt-in to an automatic escalation of namespaces where VMs run. This should be used only with additional security in place or after auditing of RBAC for Kubevirt access(ability to create VM/VMI or higher abstractions).
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
Kubevirt is able to run with restricted Pod Security Standard enabled with an automatic escalation of namespace privileges.

/test pull-kubevirt-e2e-k8s-1.24-psa-sig-compute
/test pull-kubevirt-e2e-k8s-1.24-psa-sig-storage

/test pull-kubevirt-e2e-k8s-1.24-psa-sig-compute
/test pull-kubevirt-e2e-k8s-1.24-psa-sig-storage

/test pull-kubevirt-e2e-k8s-1.24-psa-sig-compute
/test pull-kubevirt-e2e-k8s-1.24-psa-sig-storage

/approve

/retest
/test pull-kubevirt-e2e-k8s-1.24-psa-sig-compute
/test pull-kubevirt-e2e-k8s-1.24-psa-sig-storage

/cc

@xpivarc it seems unit tests are failing to compile, can you take a look?

@jean-edouard @acardace There was cycle dependency. It should be good now

/lgtm

@acardace I just made Bazel happy

/retest

/lgtm

/test pull-kubevirt-e2e-kind-1.22-sriov-nonroot

/test pull-kubevirt-verify-go-mod

/cherry-pick release-0.49
/cherry-pick release-0.44


support python3 import in agent.py

import udf_pb2
breaks in python3, so can we use the explicit relative path
import .udf_pb2
I'm assuming that python3 is intended to be supported, of course.

that's wrong.
from . import udf_pb2
is correct for py3. But i'm getting the idea that this is intended to support py2, so am closing the issue at least for now.


command not found: otpauth

Hi, thanks for this package
I extracted the contents to a folder, ran the command go get github.com/dim13/otpauth but then when I try to run the command below otpauth I get the error command not found: otpauth
I installed golang using brew, on mac.

Go installs compiled binaries into its own bin directory (usually ~/go/bin). A convenient way to make them accessible is to add
export PATH=$PATH:$(go env GOPATH)/bin

to your ~/.profile (or .bashrc or .zshrc) file.
See also https://golang.org/doc/gopath_code.html#GOPATH

Aha, perfect that solves it! Thank you.

I'm glad I could help you. Closing issue then.


Myo.js had an error with the socket

Hello
I struggled quite a bit with connecting to Myo from node.js. No matter what, I got the error message Myo.js had an error with the socket. Myo Connect might not be running. If it is, double check the API version.Myo.js had an error with the socket. Myo Connect might not be running. If it is, double check the API version..
After a while, I tried removing the "app id" in my.connect("my-app-id"), and suddenly it worked. Turns out it crashes if you have less than 3 dot-separated words in your app id (i.e. "my.app.id"). This might be common sense, I don't know, but I can't see any mention of it in the documentation. Also, the error message is not very helpful. I debugged it a bit (add console.log(arguments) between line 20 and 21 in myo.js), and it seems the websocket started by Myo Connect returns 400 if you have less than 3 dot-separated words in your app id.

I have been using the Android SDK for Myo. The corresponding init method in the Android SDK says,
applicationIdentifier : must follow a reverse domain name format (ex. com.domainname.appname). Application identifiers can be formed from the set of alphanumeric ASCII characters (a-z, A-Z, 0-9). The hyphen (-) and underscore (_) characters are permitted if they are not adjacent to a period (.) character (i.e. not at the start or end of each segment), but are not permitted in the top-level domain. Application identifiers must have three or more segments. For example, if a company's domain is example.com and the application is named hello-world, one could use "com.example.hello-world" as a valid application identifier. Application identifiers must not be longer than 255 characters. applicationIdentifier can be an empty string.
https://developer.thalmic.com/docs/api_reference/android/classcom_1_1thalmic_1_1myo_1_1_hub.html#a91352ca197594c1cd447755d83d0b4e1


Idempotent Kafka secret creation in e2e tests

Fixes #

Proposed Changes

Idempotent Kafka secret creation in e2e tests

Release Note

Docs

/cherrypick release-1.8

/cherrypick release-1.7

/cherrypick release-1.6

/hold
Need https://github.com/knative-sandbox/eventing-kafka/pull/1278 first

/retest

/close
Can't merge


Adding Power Assertion Rendering

Adding a basic power assertion capability.
This PR introduces 2 new classes that represent parts of an assertion expression - Expression and Op.
Assertion expressions like my_var.my_field == my_var_2 will be AST transformed to a structure made out of these 2 classes, where my_var is an Expression and == is an Op.
Also in this PR is the PowerAssertions class that will then render the transformed expressions to something like:
my_var.my_field == my_var_2
|      |        |  |
|      |        |  {'bob': 'mcbob'}
|      2        false
{'moo': 'bob'}

@yuvadm For some reason this won't let me add you as a review but would love your comments


Free hand drawing not working

See this (http://www.c-ev.com/osdragon/ZoomToCoordsAndMarkup.html) test page.

That's a known issue---  It's because there's a bug in the javascript because of a missing library.  I will push the additional files and let you know when it works again.


Unable to modify breadcrumbs from registerCallback

Hey Team BugsnagPHP,
I'm currently unable to modify breadcrumbs.
We send a lot of breadcrumbs, but they contain sensitive data.
To sanatize them is hard to detect and replace, so we only want them sanatized on sending errors and not while adding breadcrumbs.
Could we get access to breadcrumbs?
E.g. a getBreadcrumbs with assosiative array's
I can make a proposal implementation, but first I want to hear what you think about this idea.
kind regards
Tim

@MakerTim Hi! We've faced a similar situation in different projects and agree that sanitizing data within breadcrumbs is a bit tricky with the current implementation. It would be nice to see an easier way to do it in this package directly, in the meantime here is the code we are using to do so.
It's a little "magic" as we are using a closure that we bind to the report instance to modify the value of its $breadcrumbs property but it works 😄
// Our own sanitizer service
$sanitizer = $this->sensitiveDataSanitizer;

// Call registerCallback on Client
$bugsnag->registerCallback(static function (Report $report) use ($sanitizer): void {
    // First we sanitise the metadata of the report itself
    $report->setMetaData($sanitizer->sanitize($report->getMetaData()), false);

    // Fetch breadcrumbs from report array representation
    $breadcrumbs = $report->toArray()['breadcrumbs'] ?? [];
    $redactedBreadcrumbs = [];

    // Build our own breadcrumbs array with sanitized data
    foreach ($breadcrumbs as $breadcrumb) {
        if (isset($breadcrumb['metaData'])) {
            $breadcrumb['metaData'] = $sanitizer->sanitize($breadcrumb['metaData']);
        }

        $redactedBreadcrumbs[] = $breadcrumb;
    }

    // Override the value of $breadcrumbs property on report using bound closure
    (function ($property, $value): void {
        $this->{$property} = $value;
    })->call($report, 'breadcrumbs', $redactedBreadcrumbs);
});

Going to close this out as there are a couple of workaround options suggested above.


[JS Master] update current masters list

I presented on my project this morning. Now I want to make my name available to mentor others on their projects.
See: https://docs.google.com/spreadsheets/d/12t2vEf-jQuEyX3SPgkZbIN5oPoVpcXExcBLEz9hs7yo/edit#gid=0&range=N50
I did not see anyone else listed as a master, which shocks me - otherwise I would have added them to the list too.

Congratulations. The first official JS Master in the V2 skills program!


Missing Parameters

__init__() missing 1 required positional argument: 'secret' . It seems secret is needed when passing parameters for Client. I added this and i get an wrong status code: 404 when i try to test publish

@mcroni hello, which version are you using? Since we don't have any word secret in codebase. I suppose you are using Cent v2 which is old version that works with Centrifugo v1. For actual Centrifugo v2 you should use latest Cent library version

@FZambia thanks for this,  i did a pip install --upgrade and it works good


Lasso highlights

Reference Issue
Implements Christian Feldman's suggestion of lasso highlighting in drawings. Discussion #4607.
Many apologies to him for the 2 year wait, which is rather longer than I promised.
What does this implement/fix? Explain your changes.
In Python, use it:
d.drawOptions().multiColourHighlightStyle = Draw.MultiColourHighlightStyle.Lasso
d.DrawMoleculeWithHighlights(mol, label, acols, bcols, h_rads, h_lw_mult, -1)

It only works with the multi-coloured highlighting version of the drawing code.

The original, default highlighting mode is
d.drawOptions().multiColourHighlightStyle = Draw.MultiColourHighlightStyle.CircleAndLine

Any other comments?
The changes look a bit intimidating because I have made DrawMolMCH a virtual base class and added two new concrete classes, DrawMolMCHCircleAndLine and DrawMolMCHLasso.  The former is the original, as shown in the 3rd image, the latter produced the first 2 images.
Christian's original Python implementation had more control over the sizes of the lassos, including the relative sizes of the atoms and bonds, but I have just hard-coded it as shown.  We already have an awful lot of draw options, and I was reluctant to add more than the bare minimum.
Hopefully Christian will consider it worth the wait!

Let me be the first to say, sweet!

@DavidACosgrove the test failures here are real.

Yeah, working on it at the moment.  It's a read off the end of a vector,
and I got away with it when I tested it locally.
On Wed, Aug 23, 2023 at 5:36 AM Greg Landrum @.***>
wrote:

@DavidACosgrove https://github.com/DavidACosgrove the test failures
here are real.
—
Reply to this email directly, view it on GitHub
https://github.com/rdkit/rdkit/pull/6653#issuecomment-1689268147, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACGF2FU76TF3O2JTBZNPRMDXWWCGFANCNFSM6AAAAAA3YS6HYY
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
David Cosgrove
Freelance computational chemistry and chemoinformatics developer
http://cozchemix.co.uk

Out of curiosity, how does this interact with atom and bond labels?

Out of curiosity, how does this interact with atom and bond labels?

The placement of atom and bond notes such as the indices ignores the highlights.  That's long-standing.  So the labels go on top of any highlights that are there.  Otherwise they got pushed too far away from the things they were labelling.

Out of curiosity, how does this interact with atom and bond labels?

The placement of atom and bond notes such as the indices ignores the highlights. That's long-standing. So the labels go on top of any highlights that are there. Otherwise they got pushed too far away from the things they were labelling.

Ah, I just looked at the test output and realized that there's already a test for this. Excellent!

Problem noticed while doing some testing of my own.
Adding this bit of code to the bottom of your tests in catch_tests.cpp throws an invariant assertion:
#if 1
  {
    auto m = R"CTAB(
     RDKit          2D

  0  0  0  0  0  0  0  0  0  0999 V3000
M  V30 BEGIN CTAB
M  V30 COUNTS 19 19 0 0 0
M  V30 BEGIN ATOM
M  V30 1 C 2.745421 0.232979 0.000000 0
M  V30 2 O 1.879821 -0.268021 0.000000 0
M  V30 3 C 1.013221 0.231179 0.000000 0
M  V30 4 O 1.012421 1.231179 0.000000 0
M  V30 5 C 0.147621 -0.269821 0.000000 0
M  V30 6 C -0.110179 -1.236021 0.000000 0
M  V30 7 O 0.390821 -2.101621 0.000000 0
M  V30 8 C 1.390821 -2.100621 0.000000 0
M  V30 9 F 1.889821 -1.234221 0.000000 0
M  V30 10 Cl 1.891621 -2.966221 0.000000 0
M  V30 11 C -1.076379 -0.978021 0.000000 0
M  V30 12 C -1.941979 -1.479021 0.000000 0
M  V30 13 N -2.807579 -1.980021 0.000000 0
M  V30 14 C -0.818579 -0.011821 0.000000 0
M  V30 15 O -1.319379 0.853779 0.000000 0
M  V30 16 N -0.820379 1.720379 0.000000 0
M  V30 17 N -1.321379 2.585779 0.000000 0
M  V30 18 C -0.822379 3.452379 0.000000 0
M  V30 19 N -1.323379 4.317779 0.000000 0 CHG=1 VAL=4
M  V30 END ATOM
M  V30 BEGIN BOND
M  V30 1 1 1 2
M  V30 2 1 2 3
M  V30 3 1 3 4 CFG=3
M  V30 4 1 3 5
M  V30 5 2 5 6
M  V30 6 1 6 7
M  V30 7 1 7 8
M  V30 8 1 8 9 CFG=3
M  V30 9 1 8 10
M  V30 10 1 6 11
M  V30 11 1 11 12
M  V30 12 3 12 13
M  V30 13 2 11 14
M  V30 14 1 14 15
M  V30 15 1 15 16
M  V30 16 1 16 17
M  V30 17 1 17 18
M  V30 18 1 18 19
M  V30 19 1 14 5
M  V30 END BOND
M  V30 END CTAB
M  END)CTAB"_ctab;
    REQUIRE(m);
    std::vector<std::string> smarts = {"CONN", "N#CC~CO", "C=CON", "CONNCN"};
    std::vector<DrawColour> colours = {
        DrawColour(1.0, 0.0, 0.0), DrawColour(0.0, 1.0, 0.0),
        DrawColour(0.0, 0.0, 1.0), DrawColour(1.0, 0.55, 0.0)};
    std::map<int, std::vector<DrawColour>> ha_map;
    std::map<int, std::vector<DrawColour>> hb_map;
    for (size_t i = 0; i < smarts.size(); ++i) {
      std::vector<int> hit_atoms = get_all_hit_atoms(*m, smarts[i]);
      update_colour_map(hit_atoms, colours[i], ha_map);
    }
    std::map<int, double> h_rads;
    for (auto [idx, val] : ha_map) {
      h_rads[idx] = 0.4;
    }
    MolDraw2DSVG drawer(500, 500);
    drawer.drawOptions().fillHighlights = false;

    drawer.drawOptions().multiColourHighlightStyle =
        RDKit::MultiColourHighlightStyle::LASSO;
    drawer.drawMoleculeWithHighlights(*m, "Lasso 8", ha_map, hb_map, h_rads,
                                      h_lw_mult);
    drawer.finishDrawing();
    std::string text = drawer.getDrawingText();
    std::ofstream outs(baseName + "8.svg");
    outs << text;
    outs.flush();
    outs.close();
    check_file_hash(baseName + "8.svg");
  }
#endif

getting rid of the lines which update h_rads makes the problem go away.
I noticed this from Python, but figured that adding it to the C++ tests makes it easier to track down

Running this Python script (adapted from your testing code) results in an output with messed up line ordering in one part of the image:

import sys
from rdkit import Chem
from rdkit.Chem import Draw
from rdkit.Chem.Draw import rdMolDraw2D
from rdkit.Chem import rdDepictor

COLS = [(1.0, 0.0, 0.0), (0.0, 1.0, 0.0), (0.0, 0.0, 1.0), (1.0, 0.55, 0.0)]
def get_hit_atoms_and_bonds(mol, smt):
  alist = []
  blist = []
  q = Chem.MolFromSmarts(smt)
  for match in mol.GetSubstructMatches(q):
    alist.extend(match)

  for ha1 in alist:
    for ha2 in alist:
      if ha1 > ha2:
        b = mol.GetBondBetweenAtoms(ha1, ha2)
        if b:
          blist.append(b.GetIdx())

  return alist, blist

def add_colours_to_map(els, cols, col_num):
  for el in els:
    if el not in cols:
      cols[el] = []
    if COLS[col_num] not in cols[el]:
      cols[el].append(COLS[col_num])

def do_a_picture(smi, smarts, label, lasso=None):

  rdDepictor.SetPreferCoordGen(True)
  mol = Chem.MolFromSmiles(smi)
  mol = Draw.PrepareMolForDrawing(mol)

  acols = {}
  bcols = {}
  h_rads = {}
  h_lw_mult = {}

  for i, smt in enumerate(smarts):
    alist, blist = get_hit_atoms_and_bonds(mol, smt)
#     h_rads[alist[0]] = 0.4
    h_lw_mult[blist[0]] = 2
    col = i % 4
    add_colours_to_map(alist, acols, col)
    add_colours_to_map(blist, bcols, col)
  d = rdMolDraw2D.MolDraw2DSVG(500, 500)
  d.drawOptions().fillHighlights = False
  if lasso is not None:
    if lasso == "Direct":
      d.drawOptions().multiColourHighlightStyle = Draw.MultiColourHighlightStyle.Lasso
    elif lasso == "ViaJSON":
      print('json lasso')
      Draw.UpdateDrawerParamsFromJSON(d, '{"multiColourHighlightStyle": "Lasso"}')
  d.DrawMoleculeWithHighlights(mol, label, acols, bcols, h_rads, h_lw_mult, -1)

  d.FinishDrawing()
  return d.GetDrawingText()

smi = 'CO[C@@H](O)C1=C(O[C@H](F)Cl)C(C#N)=C1ONNC[NH3+]'
smarts = ['CONN', 'N#CC~CO', 'C=CON', 'CONNCN']
txt = do_a_picture(smi, smarts, 'pyTest2', lasso='Direct')
print(txt)

Running this Python script (adapted from your testing code) results in an output with messed up line ordering in one part of the image (along the C-O bond in the middle of the molecule):
My quick attempt to reproduce this in C++ failed...
import sys
from rdkit import Chem
from rdkit.Chem import Draw
from rdkit.Chem.Draw import rdMolDraw2D
from rdkit.Chem import rdDepictor

COLS = [(1.0, 0.0, 0.0), (0.0, 1.0, 0.0), (0.0, 0.0, 1.0), (1.0, 0.55, 0.0)]
def get_hit_atoms_and_bonds(mol, smt):
  alist = []
  blist = []
  q = Chem.MolFromSmarts(smt)
  for match in mol.GetSubstructMatches(q):
    alist.extend(match)

  for ha1 in alist:
    for ha2 in alist:
      if ha1 > ha2:
        b = mol.GetBondBetweenAtoms(ha1, ha2)
        if b:
          blist.append(b.GetIdx())

  return alist, blist

def add_colours_to_map(els, cols, col_num):
  for el in els:
    if el not in cols:
      cols[el] = []
    if COLS[col_num] not in cols[el]:
      cols[el].append(COLS[col_num])

def do_a_picture(smi, smarts, label, lasso=None):

  rdDepictor.SetPreferCoordGen(True)
  mol = Chem.MolFromSmiles(smi)
  mol = Draw.PrepareMolForDrawing(mol)

  acols = {}
  bcols = {}
  h_rads = {}
  h_lw_mult = {}

  for i, smt in enumerate(smarts):
    alist, blist = get_hit_atoms_and_bonds(mol, smt)
#     h_rads[alist[0]] = 0.4
    h_lw_mult[blist[0]] = 2
    col = i % 4
    add_colours_to_map(alist, acols, col)
    add_colours_to_map(blist, bcols, col)
  d = rdMolDraw2D.MolDraw2DSVG(500, 500)
  d.drawOptions().fillHighlights = False
  if lasso is not None:
    if lasso == "Direct":
      d.drawOptions().multiColourHighlightStyle = Draw.MultiColourHighlightStyle.Lasso
    elif lasso == "ViaJSON":
      print('json lasso')
      Draw.UpdateDrawerParamsFromJSON(d, '{"multiColourHighlightStyle": "Lasso"}')
  d.DrawMoleculeWithHighlights(mol, label, acols, bcols, h_rads, h_lw_mult, -1)

  d.FinishDrawing()
  return d.GetDrawingText()

smi = 'CO[C@@H](O)C1=C(O[C@H](F)Cl)C(C#N)=C1ONNC[NH3+]'
smarts = ['CONN', 'N#CC~CO', 'C=CON', 'CONNCN']
txt = do_a_picture(smi, smarts, 'pyTest2', lasso='Direct')
print(txt)

I think the cause of this is that the atoms are drawn in a different order to the order that the colours are given in the colour maps, and that's to do with making sure that a lasso that doesn't overlap with any other is drawn at a small radius.  For example, in the first image at the top, the orange cyclobutyl group would have the largest lasso without this.  The orders of the bond colours stay in the original order, and I can't see how to keep the 2 in sync.
I am currently considering the cowardly way out and ignoring the bond colours, making the whole lasso the colour of the atom.  Does it make sense to have the lasso in multiple colours?  I struggle to think of a use case.  If there is such a requirement for an image with different coloured bonds and atoms, then the original CircleAndLine highlighting style is still available.  If anyone ever comes up with a use case for multiple colours in a single lasso, we/I can see what can be done.

I am currently considering the cowardly way out and ignoring the bond colours, making the whole lasso the colour of the atom.  Does it make sense to have the lasso in multiple colours?  I struggle to think of a use case.  If there is such a requirement for an image with different coloured bonds and atoms, then the original CircleAndLine highlighting style is still available.  If anyone ever comes up with a use case for multiple colours in a single lasso, we/I can see what can be done.

I don't see any reason to have a multi-colored lasso.

It’ll certainly make things simpler. I’ll sort it out in the next day or so and make it clear in the docstring that the bond highlight map will be ignored. I think different radii for the highlights will be very odd as well, though being able to set a different value for the set would be beneficial.

hopefully I didn't break anything when fixing that merge conflict; let's see what the CI says

I’ll take a look later this morning.

I’ll take a look later this morning.

hopefully my merge went ok and you won't need to do anything

I’ll take a look later this morning.

hopefully my merge went ok and you won't need to do anything

I, of course, messed that up. I should know better than to use the web editor.
I'll fix it for real

The py311 CI build failure here seems to be due to yet another configuration change on the backend system, it has nothing to do with this PR.
I'm going to go ahead and merge this.

@c-feldmann here's a quick reminder to please create a feature request for this so that we can make sure you get credit as a contributor in the release notes.

Created the feature request #6747.
Thanks again for taking me up as contributor.


feat: 10/16/23 Marketplace apps

Description 📝
Adds Main Concept and SimpleX partner apps
Changes  🔄
update oneclickapps.ts
update stackscriptutils.ts

@tbaka Do we have smaller svg files? Current ones are 200+ lines which is pretty big

howdy y'all, i'm catching up here.
@hana-linode main concept can't provide a smaller svg until early next week, so I'm putting in an art ticket. What size should the images be?

howdy y'all, i'm catching up here. @hana-linode main concept can't provide a smaller svg until early next week, so I'm putting in an art ticket. What size should the images be?

Hi @tbaka, Hana is out this week but I believe she was referring to the length of the files.
As an example of an existing OCA: https://github.com/linode/manager/blob/develop/packages/manager/public/assets/superinsight.svg?short_path=ad1fe4a -- it is a 1-line file, whereas https://github.com/linode/manager/blob/231d1648c2aea92f56a202658f4a94daa4ae01af/packages/manager/public/assets/mc2goP2acv.svg?short_path=48748cd from this PR for example is almost 300 lines

Main concepts will be changing the names of their apps


Does pg-osc is able to insert millions of rows to an existing table?

I have a CSV file with millions of rows which I need to add them into a table. Either by truncate and load or directly load .
Can I do it using pg-osc? If yes, how can I?

pg-osc doesn't support that feature. The description of tools capabilities are in the readme: https://github.com/shayonj/pg-osc
Please feel free to re-open the issue with any feature requests, bugs or questions. Thanks!

Note : pg osc can replicate any tables of any size but not load data into a non existing table from a source like cav


CriticalSection should not be Send or Sync

Allowing the CriticalSection to be both Send and Sync allows multiple threads to gain access to a resource by sharing it between threads. For example with std this could be done without any unsafe code:
use std::{cell::Cell, thread};
use critical_section::{CriticalSection, Mutex};

static LIST: Mutex<Cell<Vec<i32>>> = Mutex::new(Cell::new(Vec::new()));

fn push_to_list(cs: CriticalSection, iter: impl IntoIterator<Item = i32>) {
    for item in iter {
        let mut list = LIST.borrow(cs).take();
        list.push(item);
        LIST.borrow(cs).set(list);
        thread::yield_now();
    }
}

fn main() {
    critical_section::with(|cs| thread::scope(|scope| {
        scope.spawn(|| {
            push_to_list(cs, 0..100);
        });
        push_to_list(cs, 100..200);
    }));

    critical_section::with(|cs| {
        println!("{:?}", LIST.borrow(cs).take());
    });
}

This causes undefined behaviour and often crashes:
csbug(12007,0x16b3cb000) malloc: *** error for object 0x11f606290: pointer being realloc'd was not allocated
csbug(12007,0x16b3cb000) malloc: *** set a breakpoint in malloc_error_break to debug
fish: Job 1, 'cargo run' terminated by signal SIGABRT (Abort)

This was discussed briefly in chat, it seems like we should ensure that the CS tokens are !Send and !Sync.
This could likely be done in a 1.2 release (and yank older versions), as it is a fix for soundness, and any uses like this would be unsound.


Add new edge.Config field InsecureSkipVerify to bindings

Package edge have new config field InsecureSkipVerify we need to expose it in uplink-c bindings.
Acceptance Criteria:

extend C.EdgeConfig with InsecureSkipVerify, name should be converted to c binding style

https://review.dev.storj.io/c/storj/uplink-c/+/9129


Striked text is missing during pdf stich

Describe the bug in current situation
When we do pdf stitching, the strikeout text in the original docx  is missing
Link bug to the User Story
Impact of this bug
Describe the impact, i.e. what the impact is, and number of users impacted.
Chance of Occurring (high/medium/low/very low)
Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?
Test env
This is for request test.foirequests.gov.bc.ca/foi/ministryreview/2331/ministryrequest/2439
Steps to Reproduce
Steps to reproduce the behavior:

Go to records tab and upload any docx file with strikeout text
Try this sample  'Test Other file Embeds.msg' from test package. It has a file named "Policy Summary .docx"
Try to download the Harms
See error
Strikeout text is missing on the consolidated pdf

Actual/ observed behaviour/ results
Expected behaviour
A clear and concise description of what you expected to happen. Use the gherking language.
Screenshots/ Visual Reference/ Source
If applicable, add screenshots to help explain your problem. You an use screengrab.

After conversion, strikeout text is missing on the consolidated one

Tables are overlapping each other during word doc conversion. Please check that issue as well. This is for request https://test.foirequests.gov.bc.ca/foi/foirequests/2335/ministryrequest/2443.

Tables are overlapping each other during word doc conversion. Please check that issue as well. This is for request https://test.foirequests.gov.bc.ca/foi/foirequests/2335/ministryrequest/2443.

>
This issue is fixed. But during conversion the striked text is still missing.  Discussed with @divyav-aot @KyEggleston @liseandtea  and @divyav-aot mentioned we need to investigate this issue and may be fix later

The normal strikethrough is working as expected. The issue is with revision tracking.  The markups are not preserving after the conversion.

As discussed in the standup, this issue has been fixed. Below is the sample screenshot for the same. (deletions will be shows as balloon. Insertions will show in blue color underlined text. tracking of formatting is not captured as discussed)

It is working as expected, so closing


[FEATURE] Proxy checker retries

Hello,
wanted to ask is there an option to retry the proxies when I use the checker option?

Thanks for raising this!
The --max-retries option is now a general option in v0.19.0. It works for both proxy checker and proxy IP rotator server.
Bump with mubeng --update.


Needed a web application or an android application that uses the staircase sequence to generate easy to remember passwords.

Now this is something that is a very useful piece of application that can be built.
I have the initial logic ready.
Feel free to edit it or bring in your new logic.
Our easy to remember password generator will first ask the user to input his favourite phrase or favourite one-liner.
Like the user can give : I love Github.
Now what our application will do is take the first word and count the number of alphabets. Here that is 1.
Then it will count the number of alphabets in the last word. Here it is 6.
After this it will form a staircase number which in this case is 1376.
Now 1367 will be converted to !#^&.
How will that happen?
Press shift and then type 1367.
After that following our application will concatenate the initials of the string, the number and the symbols.
Thus the final password will become: IlG1367!#^&.
Now it looks pretty random but easy to remember.
Excited? Cool. Waiting for you codes.

maybe i can do an android apps there.. maybe tell me more about detail.. is it just converting sentence to final password?


use bigger maxIdleFreePageCount in thread page allocator

and fix an issue in asmjs to not use temp page allocator

@dotnet-bot test OSX static_osx_osx_release please

@dotnet-bot test OSX static_osx_osx_test please


Decode HINT as NOP

The core fetched an compressed instruction like below.
From a downstream bug report:
core   0: 0xffffffff8000f2ec (0x00009056) add     zero, zero, s5
0x9056 is correctly decoded as HINT instruction by spike, but ibex decode it as illegal C.EBREAK instruction:
https://github.com/lowRISC/stwg-base/blob/master/hw/vendor/lowrisc_ibex/rtl/ibex_compressed_decoder.sv#L215
              if (instr_i[11:7] == 5'b0) begin
                // c.ebreak -> ebreak
                instr_o = {32'h00_10_00_73};
                if (instr_i[6:2] != 5'b0) illegal_instr_o = 1'b1;

This code first checks if instr[11:7] is zero to determine if it's c.ebreak instruction, then check instr[6:2] to see if it's illegal. However, when instr[6:2] == 0 and instr_i[11:7] != 0, it should be treated as HINT instruction rather than illegal instruction.

If rs1/rd is equal to zero, then the processor should call an EBREAK instruction. I think it is spike that is decoding incorrectly here as it is bits [11:7] that take priority over bits [6:2]. I think the decoder is working correctly here.

I had a closer look at the spec and I'm pretty confident that bits [6:2] must be handled with priority. I've opened PR #48 with an implementation.

Yeah, looking at it again you're right. Your PR seems like it would correct the issue properly.


Fix tests on master.

It seems some test results are different when I run them locally, perhaps because of different versions of GHC? This PR is to check that.

Pre-submit checklist:

Branch

[ ] Tests are provided (if possible)
[ ] Commit sequence broadly makes sense
[ ] Key commits have useful messages
[ ] Changelog fragments have been written (if appropriate)
[ ] Relevant tickets are mentioned in commit messages
[ ] Formatting, PNG optimization, etc. are updated

PR

[ ] (For external contributions) Corresponding issue exists and is linked in the description
[ ] Targeting master unless this is a cherry-pick backport
[ ] Self-reviewed the diff
[ ] Useful pull request description
[ ] Reviewer requested

OK yeah confirmed the CI with GHC 9.2 give different results than my local shell.

actually I was using the primary shell (9.2)! I'm still not sure why I'm getting different results locally.


Add Bitstreams and Files for the 4GB Version of the MLNX Innova 2 Flex

There exist a 4GB version of the Innova 2 Flex with MT40A512M16 DDR4 ICs.
So there should be Bitstreams, Documentation and Project files provided.

[ ] Document the difference of the physical board.
[ ] Add Technical documentation.
[ ] Provide pin mappings
[ ] Adapt the Projects TCL scripts to take a 4GB model into account.
[ ] Add Bitstreams for the 4GB Model

Ideally, Nvidia/Mellanox would provide better support for their product.
My board is labeled MNV303212A-ADLT Rev:A3 and seems to work with the Constraints File released by Nvidia.
I am aware of the 4GB Models with MT40A512M16 DDR4 ICs (D9TBK FBGA Code) as I spotted the MNV303212A-ADIT for sale on eBay. Note the AD I T versus AD L T. It does not show up in searches of the Nvidia Networking Forum.
I can add a variant of the project's TCL file and bitstreams for the 4GB model but do not feel comfortable including untested designs in the repository.
If you or anyone who comes across this issue has one of these 4GB models and is willing to help with testing, please join this comment thread.
It would be useful to have information on your setup:

what your Innova-2 board is labeled (MNV303212A_????, Rev:??) and the DDR4 IC's FBGA Code (D9???)
whether you have a 1.8V JTAG Adapter
If your board is the 8GB model with MT40A1G16 DDR4 ICs (D9WFR FBGA Code)

results when running the innova2_xcku15p_ddr4_bram_gpio project
results when running the innova2_ddr4_8bit_byte-lane-0 bitstream
Hardware Manager results when running the ddr4_0_ex bitstream with 1.8V JTAG connected

I have added a test project for the MNV303212A-ADIT. I recompiled the DDR4 8Bit Byte-Lane-0 test project for the MT40A512M16LY-075 which I believe to be closest to the MT40A512M16JY-083E:B with D9TBK FBGA Code. Unfortunately, Micron does not provide a datasheet for the MT40A512M16JY-083E:B which complicates the matter.


Proposal: @ToString(delegateSuper=[true/false]) - add an attribute saying: "delegate to superClass toString() only".

Consider the following case in Vanilla Java:

abstract class Expression {
}

abstract class BinaryExpression extends Expression {
  Expression left;
  String op;
  Expression right;

  public String toString() {
    return left + " " + op + " " + right;
  }
}

class Mulitplication extends BinaryExpression {
  Mulitplication() {
    this.op = "*";
  }
}

class Number extends Expression {
  double value;

  Number(double value) {
    this.value = value;
  }

  public String toString() {
    return value;
  }
}

class Main {

  public static void main() {
    Expression exp = new Multiplication(new Number(10), new Number(20));
    System.out.println(exp);
  }
}

This should print:
10 * 20

Now with Lombok:
...
@ToString // or @Data or @Value
class Mulitplication extends BinaryExpression
...
@Data
class Number extends Expression
...

This time it would print something like:
Multiplication[]

The reason this doesn't work as expected is:
@ToString on Multiplication has no indicator of delegating to superClass.
Of course, I could, simply, remove @ToString to leave it work the ordinary Java way.
But that's impossible, for example, if I decide to use @Data or @Value annotation...
Of course, I could specify @Getter @Setter @EqualsAndHashCode WITHOUT @ToString - but that's much more writing and maintenance to do than just specifying something like:
@ToString(delegateSuper = true)
Note: there's no problem with Number's @ToString/@Data/@Value - as it's implemented in the class itself, preventing Lombok from generating toString().
Note: @ToString(callSuper=true) on Multiplication, in this case, doesn't help, but worsens the matter.
Cos' its purpose it to add super's printout to child's toString().
Something like that would be printed:
Multiplication[super=10 * 20]

Writing public String toString() {return super.toString();} is probably less effort than this. We don't add options like this lightly. Adding them lightly means @ToString ends up having 58 different parameters and we don't think that's a good idea.

OK. I hope it will be reconsidered in the future.


While running the clip_guided notebook in CPU mode I get: "RuntimeError - Expected tensor for argument #1 'indices' to have scalar type Long; but got torch.FloatTensor instead"

When I run clip_guided notebook in CPU mode, I get the following error at the "Sample from the base model" cell:
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
~\AppData\Local\Temp/ipykernel_9272/4093479580.py in <module>
     20 # Sample from the base model.
     21 model.del_cache()
---> 22 samples = diffusion.p_sample_loop(
     23     model,
     24     (batch_size, 3, options["image_size"], options["image_size"]),

c:\users\alf\downloads\glide-text2im\glide_text2im\gaussian_diffusion.py in p_sample_loop(self, model, shape, noise, clip_denoised, denoised_fn, cond_fn, model_kwargs, device, progress)
    387         """
    388         final = None
--> 389         for sample in self.p_sample_loop_progressive(
    390             model,
    391             shape,

c:\users\alf\downloads\glide-text2im\glide_text2im\gaussian_diffusion.py in p_sample_loop_progressive(self, model, shape, noise, clip_denoised, denoised_fn, cond_fn, model_kwargs, device, progress)
    439             t = th.tensor([i] * shape[0], device=device)
    440             with th.no_grad():
--> 441                 out = self.p_sample(
    442                     model,
    443                     img,

c:\users\alf\downloads\glide-text2im\glide_text2im\gaussian_diffusion.py in p_sample(self, model, x, t, clip_denoised, denoised_fn, cond_fn, model_kwargs)
    351         )  # no noise when t == 0
    352         if cond_fn is not None:
--> 353             out["mean"] = self.condition_mean(cond_fn, out, x, t, model_kwargs=model_kwargs)
    354         sample = out["mean"] + nonzero_mask * th.exp(0.5 * out["log_variance"]) * noise
    355         return {"sample": sample, "pred_xstart": out["pred_xstart"]}

c:\users\alf\downloads\glide-text2im\glide_text2im\respace.py in condition_mean(self, cond_fn, *args, **kwargs)
     95
     96     def condition_mean(self, cond_fn, *args, **kwargs):
---> 97         return super().condition_mean(self._wrap_model(cond_fn), *args, **kwargs)
     98
     99     def condition_score(self, cond_fn, *args, **kwargs):

c:\users\alf\downloads\glide-text2im\glide_text2im\gaussian_diffusion.py in condition_mean(self, cond_fn, p_mean_var, x, t, model_kwargs)
    287         This uses the conditioning strategy from Sohl-Dickstein et al. (2015).
    288         """
--> 289         gradient = cond_fn(x, t, **model_kwargs)
    290         new_mean = p_mean_var["mean"].float() + p_mean_var["variance"] * gradient.float()
    291         return new_mean

c:\users\alf\downloads\glide-text2im\glide_text2im\respace.py in __call__(self, x, ts, **kwargs)
    122         new_ts_2 = map_tensor[ts.ceil().long()]
    123         new_ts = th.lerp(new_ts_1, new_ts_2, frac)
--> 124         return self.model(x, new_ts, **kwargs)

c:\users\alf\downloads\glide-text2im\glide_text2im\clip\model_creation.py in cond_fn(x, t, grad_scale, **kwargs)
     57             with torch.enable_grad():
     58                 x_var = x.detach().requires_grad_(True)
---> 59                 z_i = self.image_embeddings(x_var, t)
     60                 loss = torch.exp(self.logit_scale) * (z_t * z_i).sum()
     61                 grad = torch.autograd.grad(loss, x_var)[0].detach()

c:\users\alf\downloads\glide-text2im\glide_text2im\clip\model_creation.py in image_embeddings(self, images, t)
     47
     48     def image_embeddings(self, images: torch.Tensor, t: torch.Tensor) -> torch.Tensor:
---> 49         z_i = self.image_encoder((images + 1) * 127.5, t)
     50         return z_i / (torch.linalg.norm(z_i, dim=-1, keepdim=True) + 1e-12)
     51

~\.conda\envs\glide-text2im\lib\site-packages\torch\nn\modules\module.py in _call_impl(self, *input, **kwargs)
    725             result = self._slow_forward(*input, **kwargs)
    726         else:
--> 727             result = self.forward(*input, **kwargs)
    728         for hook in itertools.chain(
    729                 _global_forward_hooks.values(),

c:\users\alf\downloads\glide-text2im\glide_text2im\clip\encoders.py in forward(self, image, timesteps, return_probe_features)
    483     ) -> torch.Tensor:
    484         n_batch = image.shape[0]
--> 485         h = self.blocks["input"](image, t=timesteps)
    486
    487         for i in range(self.n_xf_blocks):

~\.conda\envs\glide-text2im\lib\site-packages\torch\nn\modules\module.py in _call_impl(self, *input, **kwargs)
    725             result = self._slow_forward(*input, **kwargs)
    726         else:
--> 727             result = self.forward(*input, **kwargs)
    728         for hook in itertools.chain(
    729                 _global_forward_hooks.values(),

c:\users\alf\downloads\glide-text2im\glide_text2im\clip\encoders.py in forward(self, x, t)
    124             self.pred_state[None, None].expand(x.shape[0], -1, -1)
    125             if self.n_timestep == 0
--> 126             else F.embedding(cast(torch.Tensor, t), self.w_t)[:, None]
    127         )
    128         x = torch.cat((sot, x), dim=1) + self.w_pos[None]

~\.conda\envs\glide-text2im\lib\site-packages\torch\nn\functional.py in embedding(input, weight, padding_idx, max_norm, norm_type, scale_grad_by_freq, sparse)
   1850         # remove once script supports set_grad_enabled
   1851         _no_grad_embedding_renorm_(weight, input, max_norm, norm_type)
-> 1852     return torch.embedding(weight, input, padding_idx, scale_grad_by_freq, sparse)
   1853
   1854

RuntimeError: Expected tensor for argument #1 'indices' to have scalar type Long; but got torch.FloatTensor instead (while checking arguments for embedding)

Can anyone help?
Thanks!

Not sure what is happening here, but you should try to aim for a GPU if possible.
See the comment in the notebook:
# This notebook supports both CPU and GPU.
# On CPU, generating one sample may take on the order of 20 minutes.
# On a GPU, it should be under a minute.

I know, but my current GPU doesn't have enough VRAM... that's why I was running in CPU mode.
In my case I'm getting a new GPU soon, but think it would still be cool if this could still work on CPU...

Yes, sure. In the meantime, try to use a free GPU on Google Colab.

@woctezuma I finally got hold of a new GPU with 6 GB VRAM... so I am now running again the clip_guided notebook in GPU mode, but I am seeing exactly the same error I documented above...

Hmmm... Then there must be a mismatch between versions of some of the packages, or an issue with Windows.
I see lots of results on Google with the error message, e.g.

https://github.com/tugstugi/pytorch-dc-tts/issues/3#issuecomment-480398439

Thanks! I saw them already but I don't have the necessary ML & rel. libs knowledge to properly make use of them...
I also already tried kind of blindly playing with those types and their conversion, but without success...
Honestly, I see it very hard I can come up with something useful just by myself... 🤷♂

It could be just a simple change of this line:
https://github.com/openai/glide-text2im/blob/9cc8e563851bd38f5ddb3e305127192cb0f02f5c/glide_text2im/clip/encoders.py#L123-L127

Ok, now this is getting really weird... hold on, let me explain...
The notebook cell that used to error now executes just fine. But now there is another problem, which is: the notebook generates completely black images.
Not a big deal you would say, right? Probably just a little thing to be tweaked here and there, right?
Except this is now the third ML project in a row that in my case is only generating completely black images.
Look at the two recent issue reports I've opened:

https://github.com/lucidrains/big-sleep/issues/129
https://github.com/crowsonkb/v-diffusion-pytorch/issues/15

And now Glide-text2im is adding up to them...
If you look at the reports above, you will see that in order to fix it, I've tried multiple things which didn't work, including, for both projects:

installing previous pytorch version with conda install pytorch torchvision torchaudio cudatoolkit=10.2 -c pytorch
removing the project's conda environment completely and recreating it anew
uninstalling nvidia drivers and performing a new clean driver install (I tried both Nvidia Studio drivers and Nvidia Game Ready drivers)
uninstalling and reinstalling Conda completely

Also, as I said in one of those report above, I'm getting a little worried that there might be something wrong with my new recently bought gpu (PNY Nvidia GTX 1660 TI 6 Gb)... and so I would need to find out asap in order to return the product, if necessary...

But a proof of what, exactly, in this case? I have no idea! 😓
Anyway since we are here I would like to officially invite you to join this absurd mistery hunt... ;) I hope you will be in for it :)


fix: proxy deploy with storage

Closes #3236

Release notes
In this release, we:

Fixed contracts containing storage deployed with a proxy via fuels deploy

Summary
When a contract with storage is deployed via proxy, the proxy must be aware of the target contracts storage slots.
Checklist

[x] All changes are covered by tests (or not applicable)
[x] All changes are documented (or not applicable)
[x] I reviewed the entire PR myself (preferably, on GH UI)
[x] I described all Breaking Changes (or there's none)

@petertonysmith94 as mentioned in the conversations, we do not handle custom storage slots in fuels deploy, same as forc deploy. This should be implemented manually.
This PR ensures the storage for the target contract is initialised on the proxy contract. IMO a test for the function using storage on the target contract suffices.


Test device reset

According to reset script, its using vendor partition. In our case, this is essentially empty, just with empty folder /sdk in it.
Could be related to absence of /opt in the port, as it was removed from config/sparse. Not sure whether it needs to be really addressed or can be left as it is.

Seems to work as expected. closing


activiti工作流引擎中支持使用seata吗？

Why you need it?
Is your feature request related to a problem? Please describe in details
如题，需要基于activiti封装流程相关接口，对接分布式事务，目前没有成功。
How it could be?
A clear and concise description of what you want to happen. You can explain more about input of the feature, and output of it.
Other related information
Add any other context or screenshots about the feature request here.

AT, TCC, and XA are synchronous transactions that are not suitable for integration with Activiti. However, it is possible to consider using the Saga pattern as an alternative to Activiti.

Please provide your use cases and describe problems you encountered in detail.

请问这个问题解决了吗  activiti支持seata AT模式吗


[youtube] approximate description metadata

Description of your pull request and other information
I have started to develop a separate search interface for YouTube on VRChat powered by yt-dlp, while the base features work, we wish to replicate parts of the existing Youtube search UI while still maintaining low latency searches (AKA using --flat-playlist), while that does give what we need to make it work, there are two things missing at the moment:

Descriptions, the same that appear in the website's search results.
Video timestamps, the same that appear in the website's search results.

This PR implements both:

An youtubetab:approximate_description option is added, akin to youtubetab:approximate_date, which extracts as much description as possible from detailedMetadataSnippets.
Adding a separate query for time_text, publishedTimeText.simpleText, which lets the JSON given by yt-dlp to contain something that isn't null.

So, yt-dlp 'ytsearch1:test' --dump-json --flat-playlist --extractor-args "youtubetab:approximate_date;approximate_description" would give more data than what is currently provided without extractor args.
This is related to https://github.com/yt-dlp/yt-dlp/issues/6717#issuecomment-1498603054, an open question of this PR would be if approximate_metadata would be more useful. I'm of the opinion that the user should choose which parts of the video should be approximated, and which are exact.
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

Note: The youtube tests were failing before this PR's changes (on master branch). The set of failing tests did not change with this PR.

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Fix or improvement to an extractor (Make sure to add/update tests)

I had to edit the info_dict's 'ext' requirement so that 'ext': None can work as a valid test case (as that's what you get from a flat playlist)

[ ] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Copilot Summary

🤖 Generated by Copilot at edd3dab
Summary
:recycle::sparkles::bug:

Improve YouTube metadata extraction and simplify test code. Add approximate_description feature and time_text bugfix to yt_dlp/extractor/youtube.py, and use in operator for 'ext' key check in test/test_download.py.

Sing, O Muse, of the skillful coder who refined the code
Of the extractor, that cunning tool that plucks from YouTube
The precious metadata and descriptions of the videos,
Like Hermes stealing Apollo's cattle in the ancient days.

Walkthrough

Add feature to extract approximate description from metadata snippets when regular description is missing (link). This feature is controlled by a new argument 'approximate_description' for the YoutubeBaseInfoExtractor class in yt_dlp/extractor/youtube.py.

I would be open to combining the timestamp and description args into approximate_metadata extractor arg. @pukkandan what do you think?

Agreed


RejectingCredentialRequester.

Description of the issue
Followed all config according to documantation.
PS5 is discovered, show the state, but nothing else is working. I cannot even turn on or off ps5.

Mqtt pass and npsso are change to random letters. real npsso I have already obtained.
host: <IP_ADDRESS>
port: "1883"
user: mqtt_user
pass: sjdhfjsfhs8dfsd9fjisfdjs8u

username: Mr_Ruben
npsso: 1p4asdasdadsjMjQvoD5OGMSRscrCNHaTXoITD4NTwQ5sjndfjkshfjkshdfjn88sud87ds98sdujsdn
preffered_ps5: BC33295A4A66

Addon version
1.3.1
Platform
Home Assistant 2023.10.3
Supervisor 2023.10.0
Operating System 11.0
Logs of the issue (if applicable)
Starting PS5-MQTT...
2023-10-20T03:09:26.401Z @ha:ps5:mqtt MQTT Message received ps5-mqtt/BC33295A4A66
2023-10-20T03:09:26.421Z @ha:ps5:webserver Server listening on PORT: 63206
2023-10-20T03:09:29.420Z @ha:ps5:mqtt MQTT Message received ps5-mqtt/BC33295A4A66
2023-10-20T03:09:59.556Z @ha:ps5:mqtt MQTT Message received ps5-mqtt/BC33295A4A66/set/power
2023-10-20T03:09:59.962Z @ha:ps5:error Error: Not authenticated
at RejectingCredentialRequester. (/usr/local/lib/node_modules/playactor/dist/credentials/rejecting-requester.js:24:19)
at Generator.next ()
at /usr/local/lib/node_modules/playactor/dist/credentials/rejecting-requester.js:8:71
at new Promise ()
at __awaiter (/usr/local/lib/node_modules/playactor/dist/credentials/rejecting-requester.js:4:12)
at RejectingCredentialRequester.requestForDevice (/usr/local/lib/node_modules/playactor/dist/credentials/rejecting-requester.js:23:16)
at CredentialManager. (/usr/local/lib/node_modules/playactor/dist/credentials.js:32:54)
at Generator.next ()
at fulfilled (/usr/local/lib/node_modules/playactor/dist/credentials.js:5:58)
2023-10-20T03:10:14.562Z @ha:ps5:checkDevicesState Resume polling

It seems step 6 was either not performed or failed. Please try performing it (again).
(The npsso is used to track online activity, not controlling the device.)


Add https port to the service

When we configure https in helm, it is not configured in the service, requiring a patch manually. This proposal comes so that when we configure HTTPS, it will be configured in the service.

@cla-bot check


BUG 2311885: rbd: fail DisableVolumeReplication() if image is not mirror disabled

This commit modifies DisableVolumeReplication() to fail if the image is not in mirror disabled state
Signed-off-by: Rakshith R<EMAIL_ADDRESS>(cherry picked from commit 61c23dd4d2e07fb2f8b2a019c931c799a3aea025)

Describe what this PR does
Provide some context for the reviewer
Is there anything that requires special attention
Do you have any questions?
Is the change backward compatible?
Are there concerns around backward compatibility?
Provide any external context for the change, if any.
For example:

Kubernetes links that explain why the change is required
CSI spec related changes/catch-up that necessitates this patch
golang related practices that necessitates this change

Related issues
Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.
Fixes: #issue_number
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow
guidelines in the developer
guide.
[ ] Reviewed the developer guide on Submitting a Pull
Request
[ ] Pending release
notes
updated with breaking and/or notable changes for the next major release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.

Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

/retest ci/centos/<job-name>: retest the <job-name> after unrelated
failure (please report the failure too!)

/lgtm
/approve
Please run /bugzilla refresh once we get the required ack's


ValueError: Dataloader returned 0 length. Please make sure that it returns at least 1 batch

I am trying to train a model on my dataset (which consists of my images and masks),
but I encountered the following error:
ValueError: Dataloader returned 0 length. Please make sure that it returns at least 1 batch.
I added a LOGGER in the train_dataloader method located in saicinpainting>training>trainers>base.py, but it didn't work.
The LOGGER in the 'val_dataloader' is working successfully.
What can I do?

@HappyYuji It might be an internal error indicating that image or masks are missing in the directory specified. Try to carefully repeat the exact steps defined in the readme file.

@amangupta2303 Thank you for your interest. However, I followed the 'Create your data' step exactly as instructed. I can see the LOGGER INFO displaying the path to the 'val' directory I specified accurately, and I have placed both the image and the mask in the directory (image.png, image_mask.png........)

@HappyYuji Maybe then you should once check your config.yaml to verify if your paths are correct or not. Just like the below image reference.

@amangupta2303 It was not config.yaml problem. I placed the images directly under the "val" folder with names like "val/image1.png," "val/image1_mask.png," "val/image2.png," "val/image2_mask.png," and so on. However, I resolved it by creating additional subfolders under "val," such as "val/random_medium/image1.png," and so on. The "ValueError: Dataloader returned 0 length" error is no longer occurring. Thank you!

@HappyYuji  Hello, I have placed both the images and masks for training and testing in the same folder (image1.jpg, image1_mask001.jpg........ And by creating other subfolders under "val", but the problem still appears, do you need to change the program? Looking forward to your reply, I wish you a happy life and all the best!


Require callers to explicitly opt out of signature checks

Previously the ManifestVerifier was nullable and had a default
value of null. Code that had signature checks disabled didn't
look insecure.
With this change callers must explicitly opt-out of signature
checks by passing ManifestVerifier.NO_SIGNATURE_CHECKS.

looks good! 🚀


lock/unlock safely, in push and pull

@rultor release, tag is 0.25.2

@rultor release, tag is 0.25.2

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.25.2

@yegor256 Done! FYI, the full log is here (took me 10min)


Making weather card responsive

fixes #7
I made weather card responsive  appropriate size on all screen sizes. Attaching screenshots for your reference @NoahCardoz

a

hey @NoahCardoza other podmates have reviewed my code. it looks good, if it seems good to you, could you please merge this PR?

Sure thing, I didn't know it was ready since it was still marked as a draft PR.
All looks good!

Actually, after marking the PR ready to merge it found some conflicts. Can you take a look at those?

@NoahCardoza  I have resolved conflicts by new branch resolved-conflicts/issue-7 and updated pull request. if everything seems good to you, can you please merge to main branch?


Feat/fix indexer doc store initialize

Fix the test failure in db3.js: example
   ● Console

    console.log
      RpcError: fail%20to%20read%20store%20for%20error%20collection%20with%20name%20col%20does%20not%20exist
          at /Users/chenjing/work/dbpunk/db3.js/node_modules/@protobuf-ts/grpcweb-transport/build/commonjs/grpc-web-transport.js:132:23
          at processTicksAndRejections (node:internal/process/task_queues:95:5) {
        code: 'INTERNAL',
        meta: {
          'access-control-allow-origin': '*',
          'content-length': '0',
          date: 'Fri, 16 Jun 2023 02:52:49 GMT',
          vary: 'origin, access-control-request-method, access-control-request-headers'
        },
        methodName: 'RunQuery',
        serviceName: 'db3_indexer_proto.IndexerNode'
      }

      at Object.log (tests/client_v2.test.ts:147:21)

  ● test db3.js client module › test query document

Changes

Init/Create dir for indexer_doc_db
clean up indexer_doc_db and indexer_meta_db when start

PR-Codex overview
This PR adds new databases and improves existing ones in the codebase, specifically adding mutation, document and state databases. It also improves error handling and logging.
Detailed summary

Added tools/mutation_db, tools/doc_db, and tools/state_db
Improved error handling and logging
Modified src/storage/src/doc_store.rs

Added file system module
Improved new function to return a Result
Improved create_database function to return a Result

Modified src/storage/src/db_store_v2.rs

Improved new function to return a Result

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Before fix

After fix

Codecov Report

Merging #490 (d8b5d31) into main (8659233) will decrease coverage by 0.02%.
The diff coverage is 53.33%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
- Coverage   64.02%   64.00%   -0.02%
==========================================
  Files          57       57
  Lines       12409    12419      +10
==========================================
+ Hits         7945     7949       +4
- Misses       4464     4470       +6

Flag
Coverage Δ

rust
64.00% <53.33%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/storage/src/db_store_v2.rs
65.21% <0.00%> (ø)

src/storage/src/doc_store.rs
67.15% <57.14%> (-0.82%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[BEAM-199] Update DisplayData APIs to make overrides more understandable

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @bjchambers
This PR is rather lengthy as it updates all DisplayData consumers. I recommend starting with the following:

DisplayDataTest#testTypicalUsage
Simplified DisplayData.Builder#add APIs
New DisplayData#item factory methods

I've addressed all feedback so far. Please take another look. @bjchambers

A few nits, then LGTM.

I've addressed all feedback so far. Please take another look. @bjchambers

LGTM

Backport: https://github.com/GoogleCloudPlatform/DataflowJavaSDK/pull/230


Untar re-exec error: exit status 1: output: unexpected EOF when "input/output error" on one file

If for some reason there is a input/output error on one of the files in a subdirectory of the place where one is building the docker image, doker build fails with a untar exit error message :
$ docker -D build .
Sending build context to Docker daemon 141.8 kB
Sending build context to Docker daemon
Error response from daemon: Untar re-exec error: exit status 1: output: unexpected EOF
$ docker -D build  .
DEBU[0000] Can't add file .hg/store/undo to tar: open .hg/store/undo: input/output error
[snip]
DEBU[0000] Can't add file Dockerfile to tar: archive/tar: missed writing 8192 bytes
[snip]
DEBU[0000] Can't close tar writer: archive/tar: missed writing 8192 bytes
Sending build context to Docker daemon 141.8 kB
Sending build context to Docker daemon
Error response from daemon: Untar re-exec error: exit status 1: output: unexpected EOF
$ docker --version
Docker version 1.7.1, build 786b29d

removing that IO error file solves the problem.
Maybe docker could ignore those files, or have a better error message.

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
 I'm wondering if the EOF error  is related to https://github.com/docker/docker/pull/15040

@thaJeztah is 1.8.1 distributed for ubuntu ? I seem to only get 1.7.1 at this point

@arthurlogilab 1.8.1 is distributed for ubuntu. Are you perhaps running Ubuntu 14.10? Ubuntu 14.10 is marked End-Of-Life by Ubuntu (see http://fridge.ubuntu.com/2015/07/23/ubuntu-14-10-utopic-unicorn-end-of-life-reached-on-july-23-2015/), and no longer supported. We no longer publish Docker for Ubuntu 14.10. So if you're running on 14.10, you should either upgrade to 15.04 or a long-term-support version (currently 14.04 LTS)

@thaJeztah am running vivid with get.docker.io repositories

@arthurlogilab ah! there are new APT and YUM repositories now, providing dynamically linked binaries (which solves a number of other issues as well). Check this blog-post for more information;
https://blog.docker.com/2015/07/new-apt-and-yum-repos/

I'm willing to try and reproduce but I don't know how to create a file that then doesn't exist and generates a IO error.

Seen on OS X against a docker-machine image:
Client:
 Version:      1.8.2
 API version:  1.20
 Go version:   go1.5.1
 Git commit:   0a8c2e3
 Built:        Fri Sep 11 01:46:35 UTC 2015
 OS/Arch:      darwin/amd64

Server:
 Version:      1.8.1
 API version:  1.20
 Go version:   go1.4.2
 Git commit:   d12ea79
 Built:        Thu Aug 13 02:49:29 UTC 2015
 OS/Arch:      linux/amd64

We were able to consistently reproduce this issue from within a Gradle Exec task. Eventually we found the issue to be a build context that included way too much (complete project source root directory). After changing the docker build context to an empty folder containing just the required assets and Dockerfile this issue was resolved.

If anybody comes across this, check your permissions and file owners! I fixed this error by setting the file owner to the one in the docker group.

Same here with
Client:
 Version:      1.9.1
 API version:  1.21
 Go version:   go1.4.3
 Git commit:   a34a1d5
 Built:        Fri Nov 20 17:56:04 UTC 2015
 OS/Arch:      darwin/amd64

Server:
 Version:      1.9.1
 API version:  1.21
 Go version:   go1.4.3
 Git commit:   a34a1d5
 Built:        Fri Nov 20 17:56:04 UTC 2015
 OS/Arch:      linux/amd64

I think it is because of the massive image stack. But I do not know why there are so many  when I build my images:
hhvm-composer            1.0                 31ee79f0a048        5 days ago          510.8 MB
<none>                   <none>              e11eb622bc71        5 days ago          510.8 MB
<none>                   <none>              2a2210677fff        5 days ago          510.8 MB
<none>                   <none>              1dc4cd0e8111        5 days ago          510.8 MB
<none>                   <none>              e20cfb489538        5 days ago          505.3 MB
<none>                   <none>              7947b296dcec        5 days ago          434.9 MB
<none>                   <none>              11bf6d97745c        5 days ago          433.3 MB
<none>                   <none>              ab0d6b4f6b2c        5 days ago          433.3 MB
debian                   jessie              140f9bdfeb97        12 days ago         125.1 MB
<none>                   <none>              523ef1d23f22        12 days ago         125.1 MB
hhvm                     1.0                 654f25e607db        3 months ago        433.3 MB
<none>                   <none>              78713e7f8ae5        3 months ago        433.3 MB
<none>                   <none>              3f05566268ae        3 months ago        433.3 MB
<none>                   <none>              62de98ab8f73        3 months ago        433.3 MB
<none>                   <none>              701b7d366dd8        3 months ago        433.3 MB
<none>                   <none>              c148bbc8dcf1        3 months ago        433.3 MB
<none>                   <none>              046b34d2f4d3        3 months ago        433.3 MB
<none>                   <none>              9176faf97599        3 months ago        126.4 MB
<none>                   <none>              3488622e840e        3 months ago        126.8 MB
<none>                   <none>              b2c8ddc41aad        3 months ago        126.4 MB
<none>                   <none>              55b6f523d380        3 months ago        126.4 MB
<none>                   <none>              688eb55989b5        3 months ago        126.8 MB
<none>                   <none>              8680728a3ea9        3 months ago        125.2 MB
<none>                   <none>              4989ae106bc1        3 months ago        126.4 MB
<none>                   <none>              30d885a6eab2        3 months ago        125.2 MB
<none>                   <none>              3d88cbf54477        3 months ago        125.2 MB
<none>                   <none>              7a42f1433a16        3 months ago        125.2 MB
nginx                    1.9.3               15fcaea98dd6        6 months ago        132.9 MB
<none>                   <none>              3b5c3f4c3b70        6 months ago        132.9 MB
<none>                   <none>              abc4a80afc71        6 months ago        132.9 MB
<none>                   <none>              bcbceb1f0c8c        6 months ago        132.9 MB
<none>                   <none>              9f15c123dc17        6 months ago        132.9 MB
<none>                   <none>              422936fdc3f7        6 months ago        132.9 MB
<none>                   <none>              97baf3700101        6 months ago        125.2 MB
<none>                   <none>              de2107968419        6 months ago        125.2 MB
<none>                   <none>              38e2388127fa        6 months ago        125.2 MB
<none>                   <none>              0e11c180ca22        6 months ago        125.2 MB
<none>                   <none>              8b5de14bc579        6 months ago        125.2 MB
<none>                   <none>              3d7d0c417e1d        6 months ago        125.2 MB

@bdart all those <none> <none> images are the intermediate images that make up an image, e.g. all the images below nginx 1.9.3 are the "layers" that form nginx:1.9.3

I got this error. I was using docker-compose. My normal cycle of use was:

docker-compose build
docker-compose up

docker-compose down

In this process the number of dangling (:) images  was growing dramatically until It ran out of space.

This issue is over two years old, and there's no consistent way to reproduce this; for that reason I'll close this issue. If you're having this issue, and have a way to reproduce, please open a new issue instead.


Example configuration file

Currently there is no example configuration file. This isn't ideal, especially since the configuration options are not documented (I had to search through the code just to make sure I remembered everything).

We need an example configuration file, called config.yaml, probably under a folder (maybe example).
config.yaml should contain the following:

discordToken: <discord bot token goes here> #the discord bot account token from the discord developer portal
owner: <bot owner id goes here> #the id of the discord user who should have admin permissions for this bot
probability: 1000 #the number of messages (on average) that should pass between each bot reply

Taking this myself since I have nothing better to do.


Create backend functionality / API calls to obtain data for recent activity column

QA: Recent Activity Column shows up as blank.

Issue was fixed so closed again

QA: LGTM


[TS Migration] migrate PopoverWithoutOverlay.js to TypeScript

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/25051
PROPOSAL: N/A
Tests

Log into the app (web or desktop, make sure the window is big)
Navigate to any chat
Test the popover that appears when you click on the + button (to add an attachment, task etc.)
Make sure the popover works as expected

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

Same as Tests section above

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos
This component is only rendered on big screens, so it doesn't exist on mobile devices

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/44364829/c82ddb05-e6da-4242-89f3-9654eea5dcd2

MacOS: Desktop
https://github.com/Expensify/App/assets/44364829/91b19893-4c23-4d50-93d3-c8da2b958a7c

@fabioh8010 PR updated!

@mountiny could you help with assigning this to a reviewer? 😄

Interested in reviewing this

Please complete missing checklist items

The author checklist is failing due to missed checkboxes, but I can't add it since I'm not the author...

I have updated the checklist @situchan can you please proceed with the review? Seems like there is something odd with this one and its not worth digging into now

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Not affected. Though tested on iOS for safety

Android: mWeb Chrome
Not affected. Though tested on mSafari for safety

iOS: Native
https://github.com/Expensify/App/assets/108292595/db5e41d0-3e1f-402a-9e17-56677a394c9c

iOS: mWeb Safari
https://github.com/Expensify/App/assets/108292595/58328d47-4b06-4223-be81-4d653157e1b2

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/108292595/62522b03-76b8-4a1d-8862-7fa7a69b87c4

MacOS: Desktop
https://github.com/Expensify/App/assets/108292595/ea4b1cf2-53bd-4a48-aa42-1e61ef11bf26

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.18-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Periodic appears in many websites

Platform
Which platform does the bug apply to?

WebExtension (Google Chrome, Mozilla Firefox)

Describe the bug
Well, I don't think that Google, GitHub, my website, and many others use Periodic on their site.
To Reproduce
Steps to reproduce the behavior:

Go to Google, GitHub, and other websites
Wait for a second
See Periodic appears in the extension.

Thanks for reporting the issue. Create a PR for the fix.


updated configure.ac to include ignore statements for -Wno-implicit-f…

…allthrough, -Wno-deprecated-copy, -Wunused-variable. See https://github.com/dogecoin/dogecoin/issues/1912#issuecomment-903152862 .
Added the ignore statements to avoid annoying compiler warnings at compile time. Although does not eliminate all warnings at runtime, it certainly removes the annoying ones.
See discussion: Compiler warnings when building Dogecoin. #1912 https://github.com/dogecoin/dogecoin/issues/1912

I've tested locally, and this removes a lot of warnings.
:+1: from me that this does what it says.

The unused variable I think should stay. We should remove variables that are declared and not used. I haven't encountered an scenario where there is a reason not do so.

Makes sense to keep the unused variable warning. I've tested locally with that line removed from this PR, and the result still look good to me.

So... is the conclusion on this that we're trying to address the issues rather than suppress?

I'd prefer this issue be merged into dogecoin, as I opened the issue and think it's correct.
I did lodge the issue AFTER considering both tiny format changes & removing code (ie delete), so you know what I think.

There are so many deprecated copy warnings in Qt code that I'm in favor of suppressing at least that warning. We've addressed enough of the issues in Dogecoin code and vendored code that we get value out of the other warnings.
It'd be nice to be able to enable this warning for builds without Qt, but that's beyond what I want to do with autotools at the moment.

@CosmoRied @patricklodder @chromatic What is the consensus? What is the work to be done?

Consensus is that dogecoin rules, noisy compiler warnings suck! Ticket remains open to help other developers address warnings generated by doge code.

@CosmoRied currently I see these warnings:

On any gcc - supermajority: we should fix this, it's actually a proper warning
On gcc 12 - it basically tells us that predictor.h sucks. a million times. this should be fixed because our version of predictor.h really does suck

Do you see anything else worthy of addressing?


twisterd doesn't respond

Since I updated from 0.9.31 to 0.9.34, twister starts to us 100% CPU immediately and doesn't respond.
After killing the process, a process named bitcoin-shutoff is left over with the same properties.
Commit @7458d091664bb488dab3eac22966f176ed5d7640 doesn't change this and the behaviour is also the same with 0.9.33.

Do you have any hint from debug.log?
Please try the following:

run twisterd so it goes 100%
take note of twisterd's pid using pidof twisterd
ask it to exit with twisterd stop
open gdb with twisterd executable attaching to the process gdb ./twisterd xxx
where xxx is the number you've got from pidof
type thread apply all bt and paste here the result.

since twisterd will be shutting down, we should have only a few threads left and it will hopefully get easy to pinpoint where the 100% is.

btw, what you described is the same i've seen after 0.9.33 corrupted my peers.dat.
unfortunately i couldn't really reproduce it later to try the https://github.com/miguelfreitas/twister-core/commit/7458d091664bb488dab3eac22966f176ed5d7640 fix because it somehow decided to erase the file and start it all over again.

The output from gdb is:
(gdb) thread apply all bt
Thread 3 (Thread 0x7f24dde0a700 (LWP 18761)):
#0  0x00007f24e283159c in __lll_lock_wait () from /lib64/libpthread.so.0
#1  0x00007f24e282b952 in pthread_mutex_lock () from /lib64/libpthread.so.0
#2  0x00000000006d4b05 in lock (this=)
at /usr/include/boost/thread/pthread/recursive_mutex.hpp:110
#3  lock (this=) at src/sync.h:64
#4  lock (this=0x7f24dde09cc0) at /usr/include/boost/thread/lock_types.hpp:346
#5  Enter (pszName=, pszFile=,
nLine=, this=0x7f24dde09cc0) at src/sync.h:112
#6  CMutexLock<AnnotatedMixinboost::recursive_mutex >::CMutexLock (
this=0x7f24dde09cc0, mutexIn=..., pszName=,
pszFile=, nLine=, fTry=)
at src/sync.h:133
#7  0x000000000071c67a in CAddrMan::Add (this=this@entry=0xc17100 ,
vAddr=std::vector of length 0, capacity 0, source=...,
nTimePenalty=nTimePenalty@entry=0) at src/addrman.h:432
#8  0x0000000000739cac in _ThreadDNSAddressSeed (strDNS=)
at src/net.cpp:1256
#9  0x000000000073becb in TraceThread<void (*)()> (name=0x8b5ec7 "dnsseed",
func=0x739e10 <ThreadDNSAddressSeed()>) at src/util.h:574
#10 0x00007f24e3fbb32a in ?? () from /usr/lib64/libboost_thread.so.1.56.0
#11 0x00007f24e2829334 in start_thread () from /lib64/libpthread.so.0
---Type  to continue, or q  to quit---
#12 0x00007f24e1d4d1bd in clone () from /lib64/libc.so.6
Thread 2 (Thread 0x7f24d7fff700 (LWP 18764)):
#0  CAddrInfo::GetChance (this=this@entry=0x502c598, nNow=)
at src/addrman.cpp:75
#1  0x00000000006ca417 in CAddrMan::Select_ (
this=this@entry=0xc17100 , nUnkBias=nUnkBias@entry=10)
at src/addrman.cpp:417
#2  0x0000000000737f11 in Select (nUnkBias=10, this=0xc17100 )
at src/addrman.h:473
#3  ThreadOpenConnections () at src/net.cpp:1384
#4  0x000000000073becb in TraceThread<void (*)()> (name=0x8e2128 "opencon",
func=0x7379e0 <ThreadOpenConnections()>) at src/util.h:574
#5  0x00007f24e3fbb32a in ?? () from /usr/lib64/libboost_thread.so.1.56.0
#6  0x00007f24e2829334 in start_thread () from /lib64/libpthread.so.0
#7  0x00007f24e1d4d1bd in clone () from /lib64/libc.so.6
Thread 1 (Thread 0x7f24e4a45740 (LWP 18757)):
#0  0x00007f24e283159c in __lll_lock_wait () from /lib64/libpthread.so.0
#1  0x00007f24e282b952 in pthread_mutex_lock () from /lib64/libpthread.so.0
#2  0x00000000006d4b05 in lock (this=)
at /usr/include/boost/thread/pthread/recursive_mutex.hpp:110
#3  lock (this=) at src/sync.h:64
---Type  to continue, or q  to quit---
#4  lock (this=0x7ffe9cd3bd50) at /usr/include/boost/thread/lock_types.hpp:346
#5  Enter (pszName=, pszFile=,
nLine=, this=0x7ffe9cd3bd50) at src/sync.h:112
#6  CMutexLock<AnnotatedMixinboost::recursive_mutex >::CMutexLock (
this=0x7ffe9cd3bd50, mutexIn=..., pszName=,
pszFile=, nLine=, fTry=)
at src/sync.h:133
#7  0x00000000006d711c in CAddrMan::Serialize (
this=this@entry=0xc17100 , s=..., nType=2,
nVersion=) at src/addrman.h:249
#8  0x00000000006d1627 in Serialize<CDataStream, CAddrMan> (
nVersion=, nType=, a=..., os=...)
at src/serialize.h:434
#9  operator<<  (obj=..., this=0x7ffe9cd3bec0)
at src/serialize.h:1075
#10 CAddrDB::Write (this=this@entry=0x7ffe9cd3bf30, addr=...) at src/db.cpp:507
#11 0x0000000000734fd6 in DumpAddresses () at src/net.cpp:1293
#12 0x0000000000735125 in StopNode () at src/net.cpp:2068
#13 0x00000000006d8db2 in Shutdown () at src/init.cpp:126
#14 0x00000000006f49ee in AppInit (argc=argc@entry=4,
argv=argv@entry=0x7ffe9cd3c458) at src/bitcoind.cpp:121
#15 0x0000000000421101 in main (argc=4, argv=0x7ffe9cd3c458)
at src/bitcoind.cpp:139
And this is the end from debug.log after killing all processes:
$ tail -n100 ~/.twister/debug.log
adding torrent for [vegos,tracker]
00:00:12.424: e82189: fastresume data accepted
00:00:12.424: e82189: set_state() 3
00:00:12.424: e82189: start_announcing(), paused
00:00:12.425: adding magnet link with resume data
00:00:12.425: found metadata in resume data
00:00:12.425: info-hash matched
00:00:12.425: a14927: creating torrent: vegos
00:00:12.425: a14927: starting torrent
00:00:12.425: a14927: fastresume data accepted
wait-extip thread exit
00:00:12.425: a14927: set_state() 3
00:00:12.425: a14927: start_announcing(), paused
00:00:13.368: : set_external_address(<IP_ADDRESS>, 8, <IP_ADDRESS>)
ThreadRPCServer method=stop
saving resume data
maintain-dht-nodes thread exit
dumpaddr thread stop
hashtags-aging thread exit
waiting for resume data [27]
addcon thread interrupt
msghand thread interrupt
net thread interrupt
session-alerts thread exit
saving session state
node dht: saving storage... (storage_table.size = 12607)
00:00:14.179:  aborting all torrents (27)
00:00:14.179: 0395a5: ABORTING TORRENT
00:00:14.179: 057d87: ABORTING TORRENT
00:00:14.179: 0776c2: ABORTING TORRENT
00:00:14.179: 21eb55: ABORTING TORRENT
00:00:14.179: 26415f: ABORTING TORRENT
00:00:14.179: 3008a2: ABORTING TORRENT
00:00:14.179: 417741: ABORTING TORRENT
00:00:14.179: 428826: ABORTING TORRENT
00:00:14.179: 53ca96: ABORTING TORRENT
00:00:14.179: 5cebb4: ABORTING TORRENT
00:00:14.179: 5fa786: ABORTING TORRENT
00:00:14.179: 71257a: ABORTING TORRENT
00:00:14.179: 7b370b: ABORTING TORRENT
00:00:14.179: 8940fe: ABORTING TORRENT
00:00:14.179: a1176a: ABORTING TORRENT
00:00:14.179: a14927: ABORTING TORRENT
00:00:14.179: a59f1b: ABORTING TORRENT
00:00:14.179: aaa0e5: ABORTING TORRENT
00:00:14.179: b33aaa: ABORTING TORRENT
00:00:14.179: b6e2c6: ABORTING TORRENT
00:00:14.179: c7f27a: ABORTING TORRENT
00:00:14.179: d3c6ee: ABORTING TORRENT
00:00:14.179: d3ec7b: ABORTING TORRENT
00:00:14.179: d3f079: ABORTING TORRENT
00:00:14.179: d9854b: ABORTING TORRENT
00:00:14.179: e82189: ABORTING TORRENT
00:00:14.179: ee5997: ABORTING TORRENT
00:00:14.179:  aborting all tracker requests
00:00:14.179:  sending event=stopped to trackers
00:00:14.179:  aborting all connections (0)
00:00:14.179:  connection queue: 0
00:00:14.179:  connection queue: 0
00:00:14.179:  shutting down connection queue
00:00:15.410:  locking mutex
00:00:15.410:  cleaning up torrents
00:00:15.410: ee5997: DESTRUCTING TORRENT
00:00:15.410: e82189: DESTRUCTING TORRENT
00:00:15.410: d9854b: DESTRUCTING TORRENT
00:00:15.410: d3f079: DESTRUCTING TORRENT
00:00:15.410: d3ec7b: DESTRUCTING TORRENT
00:00:15.410: d3c6ee: DESTRUCTING TORRENT
00:00:15.410: c7f27a: DESTRUCTING TORRENT
00:00:15.410: b6e2c6: DESTRUCTING TORRENT
00:00:15.410: b33aaa: DESTRUCTING TORRENT
00:00:15.410: aaa0e5: DESTRUCTING TORRENT
00:00:15.410: a59f1b: DESTRUCTING TORRENT
00:00:15.410: a14927: DESTRUCTING TORRENT
00:00:15.410: a1176a: DESTRUCTING TORRENT
00:00:15.410: 8940fe: DESTRUCTING TORRENT
00:00:15.410: 7b370b: DESTRUCTING TORRENT
00:00:15.410: 71257a: DESTRUCTING TORRENT
00:00:15.410: 5fa786: DESTRUCTING TORRENT
00:00:15.410: 5cebb4: DESTRUCTING TORRENT
00:00:15.410: 53ca96: DESTRUCTING TORRENT
00:00:15.410: 428826: DESTRUCTING TORRENT
00:00:15.410: 417741: DESTRUCTING TORRENT
00:00:15.410: 3008a2: DESTRUCTING TORRENT
00:00:15.410: 26415f: DESTRUCTING TORRENT
00:00:15.410: 21eb55: DESTRUCTING TORRENT
00:00:15.410: 0776c2: DESTRUCTING TORRENT
00:00:15.410: 057d87: DESTRUCTING TORRENT
00:00:15.410: 0395a5: DESTRUCTING TORRENT
saving user_data (followers and DMs)...
libtorrent + dht stopped
Flush(false)
twisterwallet.dat refcount=0
twisterwallet.dat checkpoint
twisterwallet.dat detach
twisterwallet.dat closed
DBFlush(false) ended             155ms
StopNode()
Let me know if you need something else.

heck. it seems a similar problem to what i've seen yesterday...
i'd suggest two things:

sending me your ~/.twister/peers.dat so i can try to reproduce.
reduce the number of retries in addrman.cpp:408 from 10000 to something like 100.

After changing retries to 50, twister runs with heigh CPU usage for some seconds and then fails with:
twisterd: src/addrman.cpp:117: void CAddrMan::SwapRandom(unsigned int, unsigned int): Assertion `mapInfo.count(nId2) == 1' failed.
I will send you my peers.dat via mail (hope I have found the correct address...)

Thanks! I've received the email (didn't tried to open it yet), but don't worry: peers.dat is not sensitive information.
In the meantime (while i should try reproducing and fixing the inconsistency) i'd suggest you just to erase your peers.dat and let twisterd recreate it.


Reword some configuration properties

I used LLM to reword some properties, but a review from a native english speaker would be welcomed.

@gnodet on a side note: what are you using for these changes? In the previous doc work (for components and EIPs) I have used Grazie Pro plugin for IntelliJ and it is very competent at finding typos and grammar issues.