Code works in Jupyter but not in VS Code

Issue Type: Bug
Try to run in VS Code then copy and paste into Jupyter-Lab and try agin. It runs in jupyter-Lab. VS Code tells me the extension variable is not defined on line-16 where I do define it:
for extension[i] in extensions:
extentions is a list with a list within it (one to start with.
extensions = [ [hpp, h] ]
Here is the full source code:
filenames = ["program.c", "studio.hpp", "a.out", "math.hpp", "hpp.out"]
# Generate newfilenames as a list containing the new filenames
# using as many lines of code as your chosen method requires
newfilenames = []
extensions = [["hpp", "h"]]

def new_filenames(filenames):
    count = len(filenames) - 1
    for filename in filenames:
        period = "."
        if period in filename:
            index = filename.find(period)
            partioned = filename.partition(period)
            i = len(extensions) - 1
            for extension[i] in extensions:
                if partioned[2] == extension[i][0]:
                    filename = partioned[0] + partioned[1] + extension[i][1]
                    print("Filename changed: ", filename)

                i += 1
        newfilenames.append(filename)
        count += 1

new_filenames(filenames)
print(filenames)
print(newfilenames)

Output in Jupyter-Lab
Filename changed:  studio.h
Filename changed:  math.h
['program.c', 'studio.hpp', 'a.out', 'math.hpp', 'hpp.out']
['program.c', 'studio.h', 'a.out', 'math.h', 'hpp.out']
VS Code version: Code 1.63.2 (899d46d82c4c95423fb7e10e68eba52050e30ba3, 2021-12-15T09:39:46.686Z)
OS version: Linux x64 5.13.0-27-generic
Restricted Mode: No

System Info

Item
Value

CPUs
AMD Ryzen Threadripper 3970X 32-Core Processor (64 x 2200)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
125.65GB (1.39GB free)

Process Argv
--no-sandbox --unity-launch --crash-reporter-id deb6f0e3-7519-4d91-a772-c67bb3e2b6ee

Screen Reader
no

VM
0%

DESKTOP_SESSION
plasma

XDG_CURRENT_DESKTOP
KDE

XDG_SESSION_DESKTOP
KDE

XDG_SESSION_TYPE
x11

Extensions (97)

Extension
Author (truncated)
Version

rainbow-brackets
2gu
0.0.6

string-converter
ada
0.1.2

armview
ben
0.4.5

vscode-intelephense-client
bme
1.8.0

doxdocgen
csc
1.3.2

python-snippets
cst
0.1.1

vscode-markdownlint
Dav
0.45.0

vscode-eslint
dba
2.2.2

docs-markdown
doc
0.2.100

python-preview
don
0.0.4

vscode-firefox-debug
fir
2.9.6

vscode-textile-preview
Geh
1.3.13

vscode-pull-request-github
Git
0.34.3

go
gol
0.30.0

cloudcode
goo
1.17.0

terraform
has
2.19.0

prettier-eslint-typescript
hb4
1.0.5

vscode-test-explorer
hbe
2.21.1

badges
idl
1.1.0

textile
idl
0.2.0

composer
ika
0.7.1

phpcs
ika
1.0.5

r
Iku
2.3.6

sandbox
jcc
1.0.1

better-cpp-syntax
jef
1.15.10

kite
kit
0.147.0

restructuredtext
lex
168.0.0

vscode-python-test-adapter
lit
0.7.0

rainbow-csv
mec
2.0.0

file-downloader
min
1.0.11

mindaro
min
1.0.120210803

mongodb-vscode
mon
0.8.0

vscode-autoprefixer
mrm
3.0.1

azure-pipelines
ms-
1.195.0

vscode-azureappservice
ms-
0.23.0

vscode-azurefunctions
ms-
1.6.0

vscode-azureresourcegroups
ms-
0.4.0

vscode-azurestorage
ms-
0.12.1

vscode-azurevirtualmachines
ms-
0.4.1

vscode-bicep
ms-
0.4.1124

vscode-cosmosdb
ms-
0.18.1

vscode-docker
ms-
1.19.0

csharp
ms-
1.24.0

vscode-dotnet-runtime
ms-
1.5.0

vscode-edge-devtools
ms-
1.4.2

vscode-kubernetes-tools
ms-
1.3.6

data-workspace-vscode
ms-
0.1.1

mssql
ms-
1.12.0

sql-database-projects-vscode
ms-
0.14.1

python
ms-
2021.12.1559732655

vscode-pylance
ms-
2022.1.3

jupyter
ms-
2021.11.1001550889

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.4

vscode-ai
ms-
0.6.27

vscode-ai-remote
ms-
0.6.0

remote-containers
ms-
0.209.6

remote-ssh
ms-
0.70.0

remote-ssh-edit
ms-
0.70.0

remote-wsl
ms-
0.63.13

vscode-remote-extensionpack
ms-
0.21.0

azure-account
ms-
0.9.11

azurecli
ms-
0.5.0

cmake-tools
ms-
1.9.2

cpptools
ms-
1.7.1

cpptools-extension-pack
ms-
1.1.0

js-debug-nightly
ms-
2022.1.2317

mono-debug
ms-
0.16.2

test-adapter-converter
ms-
0.1.5

vscode-node-azure-pack
ms-
0.2.1

vscode-typescript-next
ms-
4.6.20220124

vsliveshare
ms-
1.0.5273

vsliveshare-audio
ms-
0.1.91

azurerm-vscode-tools
msa
0.15.5

debugger-for-chrome
msj
4.13.0

debugger-for-edge
msj
1.0.15

vscode-react-native
msj
1.9.0

autodocstring
njp
0.5.4

vetur
oct
0.35.0

indent-rainbow
ode
8.2.2

r-debugger
RDe
0.4.7

ruby
reb
0.28.1

vscode-yaml
red
1.3.0

python-template-snippets
Ric
1.2.0

shebang-snippets
rpi
0.1.4

snyk-vulnerability-scanner
sny
1.2.7

vscode-vuln-cost
sny
1.7.1

rewrap
stk
1.16.0

umlet
the
1.0.4

html-preview-vscode
tht
0.2.5

cmake
twx
0.0.17

msft-todo-unofficial
tyl
0.0.15

vscodeintellicode
Vis
1.2.16

jinja
who
0.0.8

vscode-ruby
win
0.28.0

JavaScriptSnippets
xab
1.8.0

php-debug
xde
1.23.0

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392cf:30425750
pythontb:30283811
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dsc:30424895
pythonvs932:30410667
wslgetstartedc:30426334
vscop804cf:30404767
vscop940:30404999
vsclayoutctrt:30425946
vsrem710cf:30416617
vsbas813:30426126
vsic-wlc-tsjs:30426436

This doesn't work for me in jupyter either. I get this in jupyter?

The syntax you have on line 16 is unfamiliar to me. Is that 2.7 syntax? That might explain why this works on your jupyter (assuming your kernel is 2.7)

This code seems to do what you showed as the expected output:
filenames = ["program.c", "studio.hpp", "a.out", "math.hpp", "hpp.out"]
# Generate newfilenames as a list containing the new filenames
# using as many lines of code as your chosen method requires
newfilenames = []
extensions = [["hpp", "h"]]

def new_filenames(filenames):
    count = len(filenames) - 1
    for filename in filenames:
        period = "."
        if period in filename:
            index = filename.find(period)
            partioned = filename.partition(period)
            for extension_list in extensions:
                if partioned[2] == extension_list[0]:
                    filename = partioned[0] + partioned[1] + extension_list[1]
                    print("Filename changed: ", filename)
        newfilenames.append(filename)
        count += 1

new_filenames(filenames)
print(filenames)
print(newfilenames)

This also works:
extension = [0] # Variable has to be defined here
filenames = ["program.c", "studio.hpp", "a.out", "math.hpp", "hpp.out"]
# Generate newfilenames as a list containing the new filenames
# using as many lines of code as your chosen method requires
newfilenames = []
extensions = [["hpp", "h"]]

def new_filenames(filenames):
    count = len(filenames) - 1
    for filename in filenames:
        period = "."
        if period in filename:
            index = filename.find(period)
            partioned = filename.partition(period)
            i = len(extensions) - 1
            for extension[i] in extensions:
                if partioned[2] == extension[i][0]:
                    filename = partioned[0] + partioned[1] + extension[i][1]
                    print("Filename changed: ", filename)

                i += 1
        newfilenames.append(filename)
        count += 1

new_filenames(filenames)
print(filenames)
print(newfilenames)

Perhaps when you ran this in juptyer you had already defined extension?


Can't upload post image with link at 1.0 later.

In the 1.0 version later, I can't upload post image with link, I don't want use image from Unsplash.

Closing as a duplicate of #8032, #8653, #8838, and #9156.

thx！


Added bridging_anaphora_resolution task

Added bridging anaphora resolution task, based on the ACL20 paper: Bridging Anaphora Resolution as Question Answering

@googlebot I signed it!

Close this pull request as I openned another one and fixed the CLA issues there.


[FLINK-34407][Connectors/Kinesis] Fix unstable test

Purpose of the change
Tests that use FakeKinesisFanOutBehavioursFactory occasionally run into issue while creating mock for Kinesis shard subscription:
java.lang.ClassCastException: org.mockito.codegen.Subscription$MockitoMock$1959866534 cannot be cast to org.reactivestreams.Subscription

This failure leads to TimeoutException in FanOutShardSubscriber, resulting in workflow timing out due to continuous retries.
Using fake subscription implementation instead of Mockito mock to resolve this issue.
Verifying this change
This change is already covered by existing tests and can be verified by running project build in Github Actions.
Significant changes

[ ] Dependencies have been added or upgraded
[ ] Public API has been changed (Public API is any class annotated with @Public(Evolving))
[ ] Serializers have been changed
[ ] New feature has been introduced

LGTM thanks @z3d1k


Missing argument "/" in sample

In the "First Session" portion of the "Preparing disk for import job" section, the WAImportExport syntax definition doesn't include a "/" before the Dataset: argument.
WAImportExport.exe PrepImport /j: /id: [/logdir:] [/sk:] [/silentmode] [/InitialDriveSet:<driveset.csv>] DataSet:<dataset.csv>
should be
WAImportExport.exe PrepImport /j: /id: [/logdir:] [/sk:] [/silentmode] [/InitialDriveSet:<driveset.csv>] /DataSet:<dataset.csv>

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 43569122-48bc-8375-75ca-7a183cb9aca1
Version Independent ID: b43579f9-d87c-a2db-8394-03cb88d5f388
Content: Preparing hard drives for an Azure Import/Export import job
Content Source: articles/storage/common/storage-import-export-tool-preparing-hard-drives-import.md
Service: storage
GitHub Login: @muralikk
Microsoft Alias: muralikk

@eajhnsn1 Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.


Open in background hotkey should only activate if cursor is at end of line

VSCode Version: 1.7

The right arrow key used to open the selected quick open item in the background should only dispatch if the cursor was at the end of the line and not used with another modifier e.g. option or command/ctrl.
When navigating up/down through the list, the cursor should be placed to the end of the line.  This behavior is similar to ST.
/cc @bpasero
Feel free to assign to me and comment regarding your feelings on the UX.

@wprater would it not make more sense to ask the user to hold a modifier key before opening a file in the background? the user might quickly arrow to the right and would not expect any editor to open.

yeah, I think that is a valid approach as well.  I was going with what ST had modeled.  We cannot use the cmd or option modifiers as they are used to jump word boundaries.  ST uses the end of line technique to prevent this, perhaps?
I have another idea for UX: when you first pull up the quick open widget, can we have no items selected until one hits down or starts to type?

Maybe we just do it if you press Alt key while using the arrow keys. It is less discoverable though.
No, we cannot change the auto selection, if we did, you would always have to arrow down after searching, that is very awful UX.

@wprater pushed a change to behave like Sublime, maybe you give it a swirl.

No, we cannot change the auto selection, if we did, you would always have to arrow down after searching, that is very awful UX.

the idea would be upon typing the first entry could be auto-selected.  if none were found, nothing would be selected.  you can still use the down arrow to navigate.

@wprater pushed a change to behave like Sublime, maybe you give it a swirl.

made a comment on your commit.

@bpasero is this feature documented anywhere? I only just discovered it from this.

@Tyriar here is a PR, if that's helpful to you
https://github.com/Microsoft/vscode/pull/13925


Insert support.html into app.html template during build

Hm, perhaps we should do a support.css as well. I foresee that being useful.


Bump the charts version and add new charts

Signed-off-by: aisuko<EMAIL_ADDRESS>Description
This PR fixes #
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

Looks good. I suppose we'll want to time this update with the other PR merging in the layer5io/meshery repo, if we can.

Looks good. I suppose we'll want to time this update with the other PR merging in the layer5io/meshery repo, if we can.

Yep, Good idea.


Set a default value for the vscode host parameter

🔗 Fixes

fix #408
fix #737
fix #503
fix #750

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Fixes a bug in #763 - when the host parameter is not specified, the MS Code Server and MS Code CLI won't start (empty parameter is unrecognized). This change defaults the host to <IP_ADDRESS>.

@antfu heads up - I found a bug in my changes, the ms-code-server and ms-code-cli options weren't working if a host wasn't specified. This sets a default value for the host (<IP_ADDRESS>)


Memory leak on rotation

I have added this library to my app. I notice that, whenever I rotate the app (destroy/create), the memory used increases and is not freed. I have used the memory tracker, and it points to the Drawable in createCircleDrawable function - every time I rotate, this is called and there are a bunch of byte[] allocated on the heap, which are apparently not freed.

I have used MAT (http://android-developers.blogspot.com/2011/03/memory-analysis-for-android.html) with sample app and I do not see any leaked objects after rotation. Have you triggered the GC manually before fetching the heap dump?

Yes, I have triggered a GC after rotating, the free memory does not increase. Appears to be very easy to see on Android Studio's memory tracker.
Please see this screen capture: https://www.dropbox.com/s/rj3iplz91ck64r6/Selection_003.png?dl=0


Adds style closet layout styles and adjustments

Summary

This begins the shift to fully integrate style closet. I started structuring the stylesheets according to components and pages.

There are a few non-SUIT compliant style choices so as not to break the current view in a few pages that haven't been redesigned, and that were simply style-closeted over. I'd like feedback on how to proceed with those, but am also happy to leave them in until the next final style-transformation PR at which point they could be yanked.

There are a few lingering bootstrap references that relate to flashes and form errors that will remain until the next pr, at which point bootstrap will be removed and those references will be deleted. The reason is primarily due to the icons bootstrap gives us, and I didn't want to overwhelm this PR with a new font in addition to the layout changes.

In doing this work I had to adjust a few siteprism pages. I imagine when our input helpers are included and bootstrap is deprecated a lot of these spec pages can be reworked to be more flexible and not so class-name-dependent. But that's for another day.

Here's a gif to show how it looks with these layout styles added.
/domain @Betterment/test_track_core

/domain @Betterment/scss-squad

<< domain tafn, I'll leave this mostly up to the scss squad

bump

domain lgtm

<< domain tafn

bump @chrislopresto

domain lgtm


[bug] appending to zarr in object store  fails

I've been trying out the http_xarray_zarr pipeline we recently added to this repository. I think I've run into a bug (or invalid assumption) related to rapid appending to Zarr object stores. Here's a simple example:
import xarray as xr

from zarr.storage import MemoryStore
import gcsfs

fs = gcsfs.GCSFileSystem()

ds = xr.tutorial.load_dataset('rasm')

# create two MutableMapping stores
stores = [
    ('memory', MemoryStore()),
    ('gc', fs.get_mapper('carbonplan-scratch/test.zarr', create=True))
]

# write one year of data at a time to each store.
for name, store in stores:
    for i, (year, part) in enumerate(ds.groupby('time.year')):
        if i > 0:
            append_dim = 'time'
            mode = 'a'
        else:
            append_dim = None
            mode = 'w'
        part.to_zarr(store, append_dim=append_dim, mode=mode)

# check that the two stores are round-trip-copies of the original
for name, store in stores:
    actual = xr.open_zarr(store)
    try:
        xr.testing.assert_equal(actual, ds)
    except AssertionError:
        print(name, 'failed!')
        raise

This raises for the gcs store...
gc failed!
---------------------------------------------------------------------------
AssertionError                            Traceback (most recent call last)
<ipython-input-4-0491bf399a91> in <module>
      2     actual = xr.open_zarr(store)
      3     try:
----> 4         xr.testing.assert_equal(actual, ds)
      5     except AssertionError:
      6         print(name, 'failed!')

    [... skipping hidden 1 frame]

AssertionError: Left and right Dataset objects are not equal
Differing dimensions:
    (time: 4, x: 275, y: 205) != (time: 36, x: 275, y: 205)
Differing coordinates:
L * time     (time) object 1980-09-16 12:00:00 ... 1980-12-17 00:00:00
R * time     (time) object 1980-09-16 12:00:00 ... 1983-08-17 00:00:00
Differing data variables:
L   Tair     (time, y, x) float64 dask.array<chunksize=(2, 103, 275), meta=np.ndarray>
R   Tair     (time, y, x) float64 nan nan nan nan nan ... 29.8 28.66 28.19 28.21

You'll note the dimensions in the two datasets differ along the time axis (4 vs 36). I first noticed this behavior when using the above mentioned Prefect.Flow to build a zarr store incrementally in GCS. I'm leaning toward this being an issue with object store or file system mapper consistency  but I'm not sure how to diagnose that exactly. I'm hoping @rabernat or @martindurant can provide some guidance here.

I do see the same thing, even if adding .invalidate_cache() and sleep between iterations. Although files are being added to the time coordinate, "/time/.zarray' retains a shape of (4, ). Note that GCS supports "generations" of the contents of a given key, i.e., even if you don't want to keep previous values, it's possible that previous version of a file persist for a while after update. Perhaps a zarr-specific mapper like https://github.com/zarr-developers/zarr-python/pull/546 should ensure that the mapper caches known .z* keys in memory and not rely on the backend?

I would say this bug is consistent with my experience, but I was never able to nail down the problem precisely.
I also have a counter-example in which append did work with gcsfs: https://github.com/pangeo-forge/pangeo-smithy/blob/0c31241198db764ffc3b2979ecd2413b26cba5ad/pipeline.py

I found this doc useful when exploring if this could be a consistency issue: https://cloud.google.com/storage/docs/consistency
tldr; gcs lists read-after-write under strongly consistent operations.

Am I correct in thinking that the main problem is the .zarray file update? If so, one way forward would be to bypass xarray / zarr and just write a script that sequentially updates a json file in gcs. If that still breaks, try taking gcsfs out of the picture

I have been trying to update a key in-place, and I find that the immediate read-after-write consistency is not the case - you can get previous value(s) back from either the public HTTP link or the www.googleapis.com/download/storage endpoint for a long time. I even found things like
In [51]: gcs.pipe('mdtemp/zmetadata', b'hel')
https://www.googleapis.com/upload/storage/v1/b/mdtemp/o None b'--==0==\nContent-Type: application/json; charset=UTF-8\n\n{"name": "zmetadata"}\n--==0==\nContent-Type: application/octet-stream\n\nhel\n--==0==--' {'Content-Type': 'multipart/related; boundary="==0=="', 'User-Agent': 'python-gcsfs/0.6.2+11.gae121f7.dirty', 'authorization': 'Bearer ya29.a0AfH6SMCe3eZ3hH1xsiUIBT7N197IsVVcZVILovxl6eeFK3fPvkwzxAu587e0K5SmWBfZvvoZUG_zujnWfnOZhzwJSyHYmhiuG-sOiQx7YLHxiVJKvnMUe66761x3-Jk3DnHiydyBu3NqOevxwAzJYzwB7xMtfQ1OUkuyLQ'} {'uploadType': 'multipart'}

In [52]: requests.get("https://storage.googleapis.com/mdtemp/zmetadata").content
Out[52]: b'hello'

In [53]: requests.get("https://storage.googleapis.com/mdtemp/zmetadata").content
Out[53]: b'hello2'

In [54]: requests.get("https://storage.googleapis.com/mdtemp/zmetadata").content
Out[54]: b'hello'

(i.e., never the most recent value, and not even consistent, and this remained true for minutes later, even though the bytes count in the storage console updated)
One possible mitigation could be: when uploading the file, the API returns the generation ID, which should be unique. One can request contents by specific generation ID and/or can specify that an update should only happen on a generation-specific precondition. How to code this into gcsfs??

It is also true that the directory listing can become out of date, which would give your the wrong file-size when opening a file, but this is not an issue when you want to read the whole file (which the zarr case)

This is resolved by #27, which no longer uses appending.

This is resolved by #27, which no longer uses appending.


IllegalDataValue while reading holding registers on loop

Hello, I've succesfully connected a to a real device and I'm able to read a value as soon as the device connects, the problem is that if a surround the readHoldingRegister in a loop, it only reads the value the first time and catches an exception of IllegalDataValue the next one.
Here' the code of my client
`modbus.tcp.connect(port, address, { debug: 'device-1' }, (err, connection) => {
if (err){
console.log(err);
}
else{
console.log('Device connected');
var buffer;
var hex = ''
for (let i=0; i<5; i++){
  connection.readHoldingRegisters({ address: 50526, quantity: 2, extra: { unitId: 1, retry:   1000, retries: 3 }}, (err, res) =>{
    if (err != null){
      throw err;
    }
    else{
      buffer = res.response.data;
      hex = buffer[1].toString('hex');
      console.log(hex);
    }
  });
}`

I don't know if it's because my response is wrong, here's the code for the server:
`modbus.tcp.server({ debug: 'server' }, (connection) => {
connection.on("read-holding-registers", function (req, reply) {
console.log(req);
console.log('OK');
return reply(null, [ Buffer.from([ 0x00, req.request.address ]) ]);
});
}).listen(502, () => {
console.log('Listening');
}); `

Fixed it, the server didn't respond properly


Debug slow load time on deploy dashboard

Seems load takes >5 seconds so it's missing the first fetch

issue with api not frontend, closing this issue.


SFDX-CLI : Unable to pull profiles from scratch org

While running sfdx force:source:pull from my scratch org I get the the following error if there are any changes to the default profiles or there is a custom profile that has been created in the org :

ERROR:  Metadata API received improper input. Please ensure file name and capitalization is correct. Load of metadata from db failed for metadata of type:Profile and file name:sys admin.

I was able to temporarily resolve this issue by removing the spaces from the profile names.

Edit and save on all the profiles that the problem occurs (without changing anything) also works :)


Lua-Resty-Redis-Cluster: ERR Protocol error: invalid bulk length

Hi @thibaultcha ,
nginx version: openresty/<IP_ADDRESS>
built by gcc 9.3.0 (Ubuntu 9.3.0-10ubuntu2)
built with OpenSSL 1.1.0k  28 May 2019
lua-resty-core: 0.1.18
OS: Linux ea01851460a5 4.19.76-linuxkit #1 SMP Tue May 26 11:42:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
In order to implement rate-limiting, I have to use Redis-cluster in the body_by_lua_block phase.
I have changed the following Redis library file locally to use lua-resty-socket instead of ngx.socket.tcp
https://github.com/openresty/lua-resty-redis/blob/master/lib/resty/redis.lua#L8
https://github.com/iresty/lua-resty-redis-cluster/blob/devel/lib/rediscluster.lua#L2
I'm getting the following error in the logs, so not able to increment the Redis counter.
2020/06/08 22:47:24 [error] 7#7: *9 [lua] resty-rediscluster.lua:162: fetch_slots(): failed to fetch slots: ERR Protocol error: invalid bulk length while sending to client,

Please let me know, how to proceed with this, thanks.

Hi,
This error isn't reported by this library, but by lua-resty-redis-cluster (see https://github.com/iresty/lua-resty-redis-cluster/blob/devel/lib/rediscluster.lua#L162). Most likely, your code isn't using the library properly. In any case, this has nothing to do with this library.
Also, you should not use this library in phases like body_filter_by_lua or header_filter_by_lua, since the underlying luasocket implementation will block the NGINX event pool which will result in incredibly low performance (most likely unusable in production). You must find another way.


container image for 0.0.45 not available

The chart for the release 0.0.45 uses the following container image: gcr.io/jx-labs-infra/jx-pipelines-visualizer:0.0.45 - which isn't available:
Failed to pull image "gcr.io/jx-labs-infra/jx-pipelines-visualizer:0.0.45": rpc error: code = Unknown desc = Error response from daemon: pull access denied for gcr.io/jx-labs-infra/jx-pipelines-visualizer, repository does not exist or may require 'docker login': denied: Permission denied for "0.0.45" from request "/v2/jx-labs-infra/jx-pipelines-visualizer/manifests/0.0.45".

I tried switching back to the repository used by older version: gcr.io/jenkinsxio/jx-pipelines-visualizer but then got:
Failed to pull image "gcr.io/jenkinsxio/jx-pipelines-visualizer:0.0.45": rpc error: code = Unknown desc = Error response from daemon: manifest for gcr.io/jenkinsxio/jx-pipelines-visualizer:0.0.45 not found: manifest unknown: Failed to fetch "0.0.45" from request "/v2/jenkinsxio/jx-pipelines-visualizer/manifests/0.0.45".

Note that gcr.io/jenkinsxio/jx-pipelines-visualizer:0.0.44 (previous release) is working fine
@jstrachan can you please have a look? thanks!

fixed in 0.0.47


Upload HG_OOSTENDE gps data to Movebank

year
records
birds
wc -l on file
movebank_numbers

2013
113816
5
113816
113816: ok

2014
404405
17
404405
404405: ok

2015
850640
22
850640
850640: ok

2016
4303218
31
4303218
4303218: ok

2017
2731329
38
2731329
2731329: ok

2018
2432294
32
2432294
2432294: ok

There are no outliers. Total number of records 10,835,702

All GPS data is now uploaded correctly.


Convention: Decide on a convention for marking ID and foreign key ID fields

The proto files define messages with ID fields required by the database. These are then sometimes used as foreign keys in other message types. We also have other ID fields, such as GitHub's RepositoryID which can be confused with the database internal ID for the Repository message type, when used as a foreign key.
Some ideas for a convention to distinguish these ID fields:

Foreign keys for the database could be prefixed with fk or db.
Remote/external IDs related to GitHub could be prefixed with scm.

Examples:

dbRepositoryID
scmRepositoryID

It looks like there is significantly more use of database foreign key IDs than external IDs. Thus, it might be reasonable to adopt the convention that all fields that end with <MessageType>ID represents a database foreign key, whereas requiring that all other fields that represents an external ID of some sort be prefixed with e.g., scm<Name>ID.

We use remoteID in RemoteIdentity, which corresponds to the user's GitHub ID. If we go for the scm<Name>ID variant, we should rename this field using the convention we decide to be consistent.

Closing as superseded by #945


Disallow mouse click entering the insert mode

Is it possible to let mouse click select blocks instead of entering the insert/edit mode immediately?

This can not be done by plugins, should be done by Logseq Team.


Use DecapCMS for most of the website content

Following up on https://github.com/numerique-gouv/lasuite-landingpage/pull/39.
The idea here is to use DecapCMS for service landing pages, for the homepage, for the "communs" page, and for basic content pages like legal or privacy pages.
The PR is a bit much I'm so sorry. DecapCMS required a bit more work than expected, especially to make Preview components work correctly in this Next environment. There are a bit of trickeries here and there so that CSS files are handled correctly, so that image dimensions are defined, and other things. I'm happy to discuss this live if you prefer @lebaudantoine, no need to spend time on your own on this very boilerplaty-thing.
New things since last PR:

commited the actual content (it was a mistake to ignore them in the last PR…)
replaced hard-coded stuff from index/communs/legal/suivi/accessibilite pages with CMS content. Some content is still hard-coded and has not been replaced because it was a bit more time consuming to migrate them and I feel they are not the most important stuff, we could deal with that if needed
the cms code is now easier to deal with in case we have more content types. The most time consuming thing is to build the decapcms json config for a content type

@todo : i18n!

Made the iframe work and updated the docs to be more explicit.
Your preview panel CSS issue on the homepage testimonies is weird, you shouldn't have it… If you can try again if the up-to-date branch that would be helpful!
Thanks @lebaudantoine

Merged the i18n related branch in this before merging for production too. When we have at least the homepage translated we can enable i18n on the frontend by uncommenting locales in the nextjs config.


finalhandler: cannot read property 'headersSent' of undefined

I keep getting this error and I have no clue on how to solve it.
Using the latest Express version.
/home/sentinel/Gitlab/stormcms-engine-v2/node_modules/finalhandler/index.js:239
[1]   return typeof res.headersSent !== 'boolean'
[1]                     ^
[1]
[1] TypeError: Cannot read property 'headersSent' of undefined
[1]     at headersSent (/home/sentinel/Gitlab/stormcms-engine-v2/node_modules/finalhandler/index.js:239:21)
[1]     at /home/sentinel/Gitlab/stormcms-engine-v2/node_modules/finalhandler/index.js:92:17
[1]     at /home/sentinel/Gitlab/stormcms-engine-v2/node_modules/express/lib/router/index.js:635:15
[1]     at next (/home/sentinel/Gitlab/stormcms-engine-v2/node_modules/express/lib/router/index.js:210:14)
[1]     at Function.handle (/home/sentinel/Gitlab/stormcms-engine-v2/node_modules/express/lib/router/index.js:174:3)
[1]     at Function.handle (/home/sentinel/Gitlab/stormcms-engine-v2/node_modules/express/lib/application.js:174:10)
[1]     at app (/home/sentinel/Gitlab/stormcms-engine-v2/node_modules/express/lib/express.js:39:9)
[1]     at Object.<anonymous> (/home/sentinel/Gitlab/stormcms-engine-v2/src/server.js:104:1)
[1]     at Module._compile (module.js:635:30)
[1]     at loader (/home/sentinel/Gitlab/stormcms-engine-v2/node_modules/babel-register/lib/node.js:144:5)
[1]     at Object.require.extensions.(anonymous function) [as .js] (/home/sentinel/Gitlab/stormcms-engine-v2/node_modules/babel-register/lib/node.js:154:7)
[1]     at Module.load (module.js:554:32)
[1]     at tryModuleLoad (module.js:497:12)
[1]     at Module._load (module.js:489:3)
[1]     at Function.module._load (/home/sentinel/Gitlab/stormcms-engine-v2/node_modules/piping/lib/piping.js:218:16)
[1]     at Module.require (module.js:579:17)

Very strange indeed, really have no idea off hand what the cause would be. Would it be possible to share all the following so I can debug through the issue?

Version of Node.js
Complete server code that can reproduce the issue. Doesn't have to be your real code, just keep removing parts and validate the error still happens.
Instructions for how to run the provided code and reproduce the issue.

Thanks! If you're not able to provide something there, let me know how you think I can help track down the issue and I'll do my best :+1:

@dougwilson I figured it out and it wasn't a problem with Express, but an issue with my coding.
Because I don't use semicolons this error occurred:
app.use(...)

(async () => {

})()

The code gets read as the app.use(fn) returns a fn, that the async fn will init, so what I did was adding a semicolon before the async fn so the code would look like this:
app.use(...)

;(async () => {

})()

Thanks @marcus-sa this just helped me out

@Talkense no problem, them small buggers gets me everytime

@marcus-sa  Hey that is the same problem i am getting and having no idea to resolve i saw your answer but my code is very simple
app.js
`//============Route Fils==============//
var express=require("express");
var bodyParser=require("body-parser");
var methodOverride=require("method-override");
var http=require("http");
var pg = require('pg');
var path=require('path');
//=======================Includind the Node Js Files for Routes
var question=require('./NodeJs/question');
var answer=require('./NodeJs/answer');
var routes=require('./NodeJs/index.js');
//==========================Express Application==================//
var app=express();
app.set("view engine", "ejs");
// app.use(express.favicon());
app.use(bodyParser.urlencoded({
extended: true
}));
app.use(bodyParser.json());
//app.use(express.methodOverride());
app.use(express.static(path.join(__dirname, 'public')));
//===========Using Router===========//
app.use('/',routes);
//app.use(routes);
//==========calling the NodeJs File on the Route
app.use('/question',question);
app.all('/*',function(req,res,next){
  res.send("Server Started");

});
module.exports=app;
`

Just had the same error, and it was a sneak semicolon indeed, thank you

thanks


VirsuTotal Detection

VirusTotal shows this cautions. Is it normal?

Couple hundred thousand of installations tend to disagree, called a "false positive".

I'm just a nervous person, I hope it wasn't disturbing. Thanks for your response.

I'm not easy to disturb 😜


Version requirement for Fivetran dbt transformations

I'm trying to run this package on Fivetrans's Transformations and found this mismatch between versions.
Running with dbt=0.17.0
Encountered an error:
Runtime Error
  Failed to read package at /tmp/dbt_1402129320177353472/dbt_modules/mailchimp: Runtime Error
    This version of dbt is not supported with the 'mailchimp' package.
      Installed version of dbt: =0.17.0
      Required version of dbt for 'mailchimp': ['>=0.16.0', '<0.17.0']
    Check the requirements for the 'mailchimp' package, or run dbt again with --no-version-check

@mmaia-yuca thank you for raising this issue.  I've pushed a new release of this package (version 0.2.0) which is compatible with the most recent version of dbt and with Fivetran Transformations.


Signed-off-by: Cezar Tigaret<EMAIL_ADDRESS>

typo in axionrawio (formagt -> format

@ctigaret, is there a reason you closed this? It is a typo in the rawio.


Update website configurations

It looks like you are attempting to push a change to the part repository, for help with deploying please start a new thread in the discussions.


Deep press non 3d touch devices.

When using deep_press on non 3d touch devices it will hang/bug very often. Any way to disable this for non-3d touch devices without the need of duplicating code?

When you say non-3d touch do you mean like an android phone or a PC? Or both?

I also mean my older iPad Air. But yeah mostly Android users seem to have problems with it. I do not use an Android device so I can’t test it for you. However many people have downloaded my config and the Android users of them say it does not work.

This is fixed in the latest release. deep-press is now disabled by default on unsupported devices, but can be turned on if one desires


Update bless_client.py to be a little more flexible

Closing #8, as I've migrated the work to our company account and added a bit more. It feels like these are beneficial to the user community at large, but I could be wrong.

Allow bless_client.py to use ~/.aws/credentials.
Use LogType=None because the logs generally live in another account.
Support specification of multiple bastion ips and include the bastion ips in the source-address Critical Options

Original context from #8 for the first two items:
"As it stands, the recommendation to contain all BLESS items in a completely isolated account is one that I think is very reasonable. After setting that up and granting the appropriate cross-account perms to invoke the lambda, I ran into this issue. https://forums.aws.amazon.com/thread.jspa?messageID=715494
Because of that, I couldn't get it to work until I disabled the LogType='Tail' arg from the lambda handler invocation. I toyed w/ the idea of adding yet another param to bless_client.py, but I didn't think it warranted that. If there's a better way to get the logline of your request, let me know."
RE: specifying multiple bastion ips and including them in the source-address of the cert.

My guess is, most people will utilize multiple bastion hosts for failover/redundancy
To facilitate using the bastions via an ssh config ProxyCommand, the same cert needs to allow ssh access to the bastion from the user's source ip, as well as the second hop from the bastion to the target host.

I had considered supporting multiple source IPs, but we hadn't come across a use case for it, so initially I left it out.
However, you can already specify a CIDR block, so I don't have any objections to adding multiple explicit source IPs to the request.
I don't normally SSH with ProxyCommand, but in testing I've not seen any issues with ProxyCommand through a bastion if the certificate only contains the bastion's IP as the source IP.  I could see it being a problem if you were trying to use the cert to AuthN to both the bastion and an instance.
Is your use case for adding multiple IPs that you're issuing certificates to a developer directly, who then runs something like ssh bastion.example.com and you don't know which bastion IP they'll resolve?
Additionally are you trying to use that certificate to AuthN to a bastion (with a dev source IP) and then want to re-use that same cert to AuthN to an instance, with the same public key that was used to AuthN to the bastion?  What about the valid_principal in that case?
Our intent was that a user would connect to one bastion in the HA group, and then that single bastion would obtain a certificate for use to connecting to one instance as one user.  This allows for multiple bastion hosts, but a certificate is only good from a particular bastion for that particular request.  We don't put the certificates on developer machines.  Partly because we don't want developers needing AWS credentials on their machines to invoke the lambda function.

It sounds like our use case lands outside of your original intention for the workflow.

We're using multiple bastions, with dns health checks to ensure that bastion.example.com will resolve to a healthy bastion.
For us, developers have a basic set of creds with mostly Describe* type IAM privileges and we've added the priv to invoke our bless lambda. From there, the expectation is that, with a properly configured ~/.ssh/config with the CIDR blocks of our various VPCs, a developer does the following:

Invoke the lambda and pass the ips of all of our bastions, as well as their own source ip
Use that cert + their id_rsa key to ssh something-other-than-the-bastion.example.com and have the ProxyCommand in the ssh config connect to that host, via the bastion proxy, using the same short-lived cert.

So, the real root of adding multiple IPs is that we are using the same cert to gain access to proxy via the bastion, as well as hitting our target instance on the backend. It's not specifically tied to the HA bastion, since we could just resolve our HA dns, and use that for proxying (although, it would probably take a couple minutes of creativity to make the ssh config proxy command respect that resolved bastion IP I just suggested...maybe env vars or rely on DNS ttl)
As far as valid_principal, we're using a common user on the instances, and it's consistent across our bastions and backend instances.

I've not forgotten about this request.  I think we can tweak how your use case fits into the BLESS code.  You are not alone in wanting to issue certificates directly to end users.  I should be able to expand on this PR in August, and we can pull it in then.

Resolved in https://github.com/Netflix/bless/pull/38


fix: corrected minor typo in variables.tf

Also ran make docker_generate_docs to update the README

Hi @tpryan - The same tflint errors that are blocking merging of this PR appear to have been fixed by @bharathkkb in a different PR (https://github.com/GoogleCloudPlatform/terraform-google-three-tier-web-app/commit/fde60533788a72048306198e33029fc673957053). I'm guessing that re-running the failed check on that other PR will unblock this PR as well. WDYT?

Hi @tpryan - The same tflint errors that are blocking merging of this PR appear to have been fixed by @bharathkkb in a different PR (fde6053). I'm guessing that re-running the failed check on that other PR will unblock this PR as well. WDYT?

Hi @kumar-dhanagopal, thanks for the contribution.  It does note appears that commit was merged into the main branch, however this open PR appears to address them:  https://github.com/GoogleCloudPlatform/terraform-google-three-tier-web-app/pull/15


Validate PolicyGroup members name

Is your feature request related to a problem?
Policy group members will be bound to functions with the same name when evaluating a CEL expression. Therefore, policy member's names should follow the same validation rules as CEL names.
Solution you'd like
Add a validation step to validate policy member names.
Alternatives you've considered
No response
Anything else?
No response

@jvanz this could be helpful: https://github.com/kubewarden/cel-policy/pull/83#discussion_r1751393241

@jvanz this could be helpful: kubewarden/cel-policy#83 (comment)

Thanks! I was reading the code. It's a good starting point. However, I think we cannot use that regex because it's meant to escape the CEL expressions, not to check if it's a valid identifier. For example, that regex is used to identify the dot in expressions like a.b. Therefore, if we use it, we will allow policy names with dots, which is not supported. Consequently, I've written another regex based on the policy definition. Additionally, I've decided to use a set to store the keywords reserved by the CEL policy because it matches the policy syntax.


Is gxargparse installed or not?

I make a virtualenv, clone the repo, run python setup.py install and it seems to terminate successfully, but when I try the test script, it fails, and I'm not quite sure why.
Finished processing dependencies for gxargparse==0.2.5
(venv) computer:gxargparse Alex$ gxargparse_check_path
gxargparse not installed

Any ideas?

Try:
python setup.py develop

it's a bit finicky about installation method (and really shouldn't be installed anywhere outside of local venvs).
That said, it should pip install gxargparse properly, i.e. from pypi.

works.


Use FileFormat-based data source instead of HadoopRDD for reads

This patch refactors this library's read path to use a Spark 2.0's FileFormat-based data source to read unloaded Redshift output from S3. This approach has a few advantages over using our existing HadoopRDD-based approach:

It will benefit from performance improvements in FileScanRDD and HadoopFsRelation, including automatic coalescing.
We don't have to create a separate RDD per partition and union them together, making the RDD DAG smaller.

The bulk of the diff are helper classes copied from Spark and spark-avro and inlined here for API compatibility / stability purposes. Some of the new classes implemented here are likely to become incompatible with new releases of Spark, but note that spark-avro itself relies on similar unstable / experimental APIs and thus this library is already vulnerable to changes to those APIs (in other words, this change is not making our compatibility story significantly worse).

Current coverage is 88.25% (diff: 89.70%)

Merging #289 into master will decrease coverage by 0.35%

@@             master       #289   diff @@
==========================================
  Files            12         15     +3
  Lines           702        732    +30
  Methods         568        591    +23
  Messages          0          0
  Branches        134        141     +7
==========================================
+ Hits            622        646    +24
- Misses           80         86     +6
  Partials          0          0

Powered by Codecov. Last update 6cc49da...8a4e94f

LGTM!

Great, merging to master!


Log rotation - new tests + validations

Add a Rotate operation to the resilience test harness
Add an inotify-based validation that watches for log rotation (note that it is making assumptions about the file chunk naming scheme being <app name>-<worker name>-<chunk id>.evlog)
Add a test with log rotation followed by crash-recovery using multi_partition_detector
Fix the @printf in recovery/backend.pony  that wasn't including the log file path. It now includes it (the format string was missing a %s).

The tests pass locally.
closes #2881

@nisanharamati The integration tests are failing because the inotify module is not available.


enable sourcelink

This enables Source Link information on all compatible projects in the repository. Should it only happen for projects under Source instead?
The Source Link documentation recommends separating the PDBs into symbol packages instead of packaging them in the main nupkg files. That can probably be done in NightlyBuilder by passing an additional parameter to nuget pack and changing the PDB type if you want it.
Related to #746

I haven't found the time to look into the details SourceLink myself, can you briefly elaborate on what exactly the build props file in this PR does and how it works? Especially since Duality uses hand-edited .nuspec files for its packages that exist outside the msbuild toolchain, I'd like to double-check with you that this works as intended.

This enables Source Link information on all compatible projects in the repository. Should it only happen for projects under Source instead?

Doesn't hurt to have it in all projects I think.

Directory.build.props will be implicitly imported I believe. Still not sure how that will work with custom nuspec files though. @mdonoughe did you test this?

When MSBuild builds a project it searches up the directory tree looking for a Directory.Build.props file and a Directory.Build.targets file. The Directory.Build.targets file is added to the beginning of the project, and the Directory.Build.targets file is added to the end.
If I delete all the .cs files in my work area and then launch the program in the debugger I am prompted about downloading the files via Source Link.

Source Link information is saved into the PDB so it will work as long as the user has or can get the PDBs. The handcrafted nuspec files are distributing the PDBs in the nupkg so the user should already have the PDB and it should just work. Normally now you would create separate symbol packages, but it's not required.

Great, thanks for the explanation and testing 👍 I'll just go ahead and merge this right away.


chore: reduce imports in ZMod.Basic

While at it, document the lemmas that were moved, and two similar lemmas in ZMod.Basic.

The extra import Mathlib.RingTheory.ZMod import in Mathlib/Data/ZMod/Quotient.lean and Mathlib/NumberTheory/Padics/RingHoms.lean is probably not too bad (shake didn't speak yet, so perhaps that is even superfluous).

Commenting to avoid duplicate work: I'm trying to pick this up.

This is almost ready: there is one build error to fix in Data/Zmod/Quotient.

@Ruben-VandeVelde I'd declare this done (modulo further build errors, but I cannot imagine those). Feel free to take a look.

bors merge

@Ruben-VandeVelde This builds again :-)

bors merge


[hotfix] [SHARE] Prevents the footer from popping back up again as the query changes

Purpose
When using SHARE, if you hide the footer by clicking it or performing a query, and then search with an empty bar, and then search with a real query again, the footer will be visible at the same time as the search bar. This looks really weird. Also, the webkit columns don't display properly on chrome and safari.
Changes
Hide the footer on query, and make the columns behave as they should.

Good to go from my end. :japanese_ogre:


update to Aliases to include v0.21+ update

One piece of the puzzle, incorporating content from the migration guide back into its place in the docs.

ack, the example in the current docs site is actually pretty non-standard/advanced. Lets just update the code snippet and not document the old one. I've made this change in #145 so that this PR should be safe to close

These aliases work in 0.23

Right, they work, it's just a complex example to use to explain how tsconfig aliases work for the first time. Not at all opposed to this as an advanced pattern to document to users who are looking for custom opinionated aliases!


replaying request to a protected resource after (re)authorization

@jakefeasel - I provided some descriptive content to the change and made some other minor changes to the README. Please see if you have any further comments, thanks!


[bluez-qt] Check count before removing devices from model

On some devices AdapterRemoved may be invoked even if no
devices have been created. As a result base class asserts
on trying to remove non-existing rows from model.

Thanks for the comments. Good questions, those apparently haven't been a problem so far for the devices we've been working with. Those improvements should be handled via a separate commit/PR, point of this commit was to fix the asserting without refactoring too much.

As mentioned by Slava there's duplication in the code, would want to see the lines in defaultAdapterChanged() and adapterRemoved() be replaced by a function call and have the removal code in one place only.
But if you want to do only a fix here and style improvements later that's fine.

Wasn't going to touch old design too much since it was pretty much working otherwise, but I agree on the comments. PR updated, please have a look (tested on HWs).

LGTM except for unnecessary blocking D-Bus call in adapterRemoved but in practice it's not an issue for us because we only have one adapter which never gets removed. There are other blocking calls in this code which do get called but that's out of scope of this pull request.

Thanks for the inspection. If this is the case, could someone merge & tag when you have time?


Fix typo

You're welcome @mairaw. I'm glad to see people still recognise me after a long time of no contributions :)


Warning with dependency six

When I run my application, with django 1.9.5, show this warning:
.../lib/python3.4/site-packages/six.py:808: RemovedInDjango110Warning: SubfieldBase has been deprecated. Use Field.from_db_value instead.
return meta(name, bases, d)

I believe it has been fixed already. However it may have not been reflected to pip repository yet. Try downloading directly from git. pip install git+https://github.com/omab/python-social-auth.git

One question, when will reflected in pip repository?. Any idea?.
Thanks!

Should come soon if not there already.

@hellvix thanks!

pypi not updated yet? Still seeing version 1.10.0 from pip.


How to make a multiple lines row?

I tried to align my articles on a simple grid.
The html:

1

2

3

4

5

The scss:

@import "neat";

section {
  @include outer-container;
  article { @include span-columns(3); }
}

The CodePen example.
As you can see, the fourth and fifth articles are sent to the next row.
When the fifth article is commented, the fourth article correctly remains on the first row.
How can I get rows of four articles?
Question on stackoverflow

I have to remove the right margin of the last item of a row. I can use omega() for this purpose:
section {
  @include outer-container;
  article {
    @include span-columns(3);
    @include omega(4n);
  }
}

Working CodePen


cohere[patch]: backward-compatible pydantic v2 changes

Hey @ccurme thanks for the PR! May I check why we wanna skip on failure for these checks?

Setting skip_on_failure=True helps to avoid running the root validator when it's not necessary due to previous field-level validation errors (it won't suppress those errors though).

Setting skip_on_failure=True helps to avoid running the root validator when it's not necessary due to previous field-level validation errors (it won't suppress those errors though).


creation log

render doesnt support docker compose
render doesnt support creating a database

therefore we MUST specify DBNAME same as POSTGRES_USER name per our own setup script
however, render always appends a suffix to the database name and therefore auto-setup.sh cannot connect to the database

examples for illustration

therefore we must drop out of using auto-setup.sh.

i vendored the auto-setup.sh and am now succesfully running custom-auto-setup.sh to get around the DB_NAME issue. however, now i am running into an issue where pq: relation "schema_version" does not exist. trying to debug.

i got this far but ended up with some shell script issue i cant figure out


How can I remove a node pool from a k8s cluster?

Is this a request for help?:
yes
Is this an ISSUE or FEATURE REQUEST? (choose one):
issue
What version of acs-engine?:
v0.12.5

Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)
Kubernetes 1.8.4
What happened:
I attempted a few ways to remove an agent pool from a running k8s cluster through acs-engine/ARM utilities.  Each method I tried failed.
What you expected to happen:
Not really sure.  I was hoping to find a process for removing an agent pool.
How to reproduce it (as minimally and precisely as possible):
Method 1:
Run acs-engine.exe generate with 2 agent pools; run az group deployment ...
Manually remove all references from apimodel.json regarding agentpool1 (leave references to agentpool2 in place)
Run asc-engine generate against _output\foo\apimodel.json; verify all references to agentpool1 were removed from all *.json files
Run az group deployment ...
I received...  "message": "Changing property 'osDisk.vhd.uri' is not allowed." error during ARM provisioning.
Method 2:
Run acs-engine.exe generate with 2 agent pools; run az group deployment ...
Run acs-engine.exe scale with --new-node-count = 0
Run az group deployment ...
acs-engine told me "FATA[0000] --new-node-count must be specified"
Anything else we need to know:

I have a use case where this capability would be appreciated.
Thanks for sharing your test methods..I was about to try those.

Hello, I have the same issue, we are going to use different agent pools for different apps, and if we remove app, agent pool must be removed also.
Is there any ETA for this issue?

I found this in the docs recently: docs/kubernetes-day2-operations.md
There is a section for how to remove node pools, which is labeled tested. It recommends draining the nodes first, which wasn't mentioned in @bq1756 's methods. Maybe someone can give it a test?

@ewok2030 it may work because of you manually remove nodes from kub cluster and manually remove them from Azure portal.
But I did not find any ways to remove agent pools using acs-engine automatically.


Module name error when calling app.stop()

Spectron Version: 3.8.0
Electron Version: 2.0.0
Operating System (Platform and Version): macOS High Sierra, version: 10.13.4
Last known working Electron version: ~

Expected Behavior
Calls to app.stop() should cleanly stop our application during long test runs.
Actual behavior
We see a module error in the after block of our test runs. The app never stops and the mocha runner hangs indefinitely. Our code is similar to the electron-api-demos teardown.
  after(() => {
    if (app && app.isRunning()) {
      return app.stop();
    }
  });

To Reproduce
Run a test that has the browser waiting on a condition that takes a long time. Like below:
const Application = require('spectron').Application;
const electron = require('electron');
const path = require('path');

const chai = require('chai');
const chaiAsPromised = require('chai-as-promised');

chai.should();
chai.use(chaiAsPromised);

describe('app', () => {

  let app;

  before(() => {
    app = new Application({
      path: electron,
      args: [
        path.join(__dirname, '..'),
      ],
      waitTimeout: 50000,
    });
    chaiAsPromised.transferPromiseness = app.transferPromiseness;
    return app.start();
  });

  after(() => {
    if (app && app.isRunning()) {
      return app.stop();
    }
  });

  it('launches app with a loading page', () => {
    return app.client.pause(30000).then(function () {
      return (3).should.equal(3)
    })

  }).timeout(90000);
});

Screenshots
If applicable, add screenshots to help explain your problem.

Additional Information
When the wait isn't long, the test work fine.
@tisvictress
@joaopapereira

Developer error.


[CI/CD] Update publishing to PyPI w/ tokenless

Here's the up-to-date guide: https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/.
Also, separate building from publishing due to security considerations.

thanks!

@MarcoGorelli any feedback on trusted publishing? Was it well-explained?

yup, thanks!


Created recipe editing functionality

Added functionality to edit recipes, based off of my recipe creation PR.

A user may only edit a recipe that they had created
A user may access the edit feature for their recipe from its view_recipe page
Must be merged after #100
Closes #106

Recipe before editing:

Recipe being edited:

Recipe after edit:

Hi @efraimvis please resolve conflicts

Hi @efraimvis please resolve conflicts

Done.

Squash commit please

Introduced a new, functioning, "Edit Recipe" button to allow users to edit their recipes from their view_recipe page.

I think it would be nicer if the edit button will be placed above the date.

As I've been told before by our mentors, good tests don't need to be explained by comments.
Rather than that, everything looks good.

As I've been told before by our mentors, good tests don't need to be explained by comments. Rather than that, everything looks good.

+1

As I've been told before by our mentors, good tests don't need to be explained by comments. Rather than that, everything looks good.

+1

Does that mean I should remove the comments from the tests?

Does that mean I should remove the comments from the tests?

I think so, your code should be clear enough to understand without comments

Does that mean I should remove the comments from the tests?

I think so, your code should be clear enough to understand without comments

I see. The test are quite minimal, so It's quite clear what everything does. I removed the comments.

I see there's been an approval. I'm squashing commits 👍

@natifridman @liornoy Squashed commits.


Add search_lowercase

Summary:
Adds a function for searching for concepts without regard to case, i.e NOT Avaiable == Not available == not available. Returns prefLabel and altLabel in correct case.
Related issue:
https://github.com/metno/py-mmd-tools/pull/246 and other py-mmd-tools lookups in controlled vocabularies.
Suggested reviewer(s): @mortenwh
Reviewer checklist:

[ ] The headers of all files contain a reference to the repository license
[ ] 100% test coverage of new code - meaning:

[ ] The overall test coverage increased or remained the same as before
[ ] Every function is accompanied with a test suite
[ ] Tests are both positive (testing that the function work as intended with valid data) and negative (testing that the function behaves as expected with invalid data, e.g., that correct exceptions are thrown)
[ ] Functions with optional arguments have separate tests for all options

[ ] Examples are supported by doctests
[ ] All tests are passing
[ ] All names (e.g., files, classes, functions, variables) are explicit
[ ] Documentation (as docstrings) is complete and understandable

The checklist is based on the S-ENDA conventions and definition of done (see General Conventions). The above points are not necessarily relevant to all contributions. In that case, please add a short explanation to help the reviewer.

@mortenwh Need to edit this repo so 3.6 is not a required check.


fix(openapi): Fix dynamic schema params being duplicated

In #1721, we had prevented OpenAPI parameters from executing the code path which populated all parameters that had values in the step definition, even if they were dynamic. However, in #2184, this code path was reactivated.
Now, parameters with a dynamic schema that have an existing value are populated twice: once using the value, which has a complete reference key (e.g., body/body/recipient/to), and once from the manifest, which has a dynamic schema reference key (e.g., body/body/recipient). This results in two objects being shown in the parameter list.

This fix addresses the issue so that if a parameter has a dynamic schema, we do not statically populate it in the parameters list.

Is this an issue only with aliasing parameter or any operation. Have we made sure this does not break any LA scenarios? @rllyy97


FFmpeg: Manage objects by C++11 smart pointers.

AVFormatContext: https://github.com/k2-fsa/sherpa-ncnn/pull/179/commits/0d1b9e48b05a4ee47e5574e8c6e7510450bcf831
AVCodecContext: https://github.com/k2-fsa/sherpa-ncnn/pull/179/commits/4a6b4e472035aae4c3bb7858686e2a7b0bc09c9b
AVFilterGraph: https://github.com/k2-fsa/sherpa-ncnn/pull/179/commits/c7d7baba0d63713f45e66f256fb98aa52c9758e0
AVFilterInOut: https://github.com/k2-fsa/sherpa-ncnn/pull/179/commits/5a127eefed019f5c5ed8b17bdc1b5da7ef895e3f
AVPacket or AVFrame: https://github.com/k2-fsa/sherpa-ncnn/pull/179/commits/5bd97814ffc2c8bff6378985efd399017a89a953
Unref packet and frame: https://github.com/k2-fsa/sherpa-ncnn/pull/179/commits/2660ee72dcfb3b8d8d648c3457a140969ba86c71

There are still several places that cause memory leak, though there are not introduced by this pull-request.
1
https://github.com/k2-fsa/sherpa-ncnn/blob/957e85d1e8a83f3a89a0b1238b68e2e0def81167/ffmpeg-examples/sherpa-ncnn-ffmpeg.cc#L679
The document says

On success, the returned packet is reference-counted (pkt->buf is set) and valid indefinitely. The packet must be freed with av_packet_unref() when it is no longer needed.

However, av_packet_unref is called only at the end of the while loop
https://github.com/k2-fsa/sherpa-ncnn/blob/957e85d1e8a83f3a89a0b1238b68e2e0def81167/ffmpeg-examples/sherpa-ncnn-ffmpeg.cc#L750
but there are lot of places that can break out early in the loop.
2
https://github.com/k2-fsa/sherpa-ncnn/blob/957e85d1e8a83f3a89a0b1238b68e2e0def81167/ffmpeg-examples/sherpa-ncnn-ffmpeg.cc#L711
https://github.com/k2-fsa/sherpa-ncnn/blob/957e85d1e8a83f3a89a0b1238b68e2e0def81167/ffmpeg-examples/sherpa-ncnn-ffmpeg.cc#L746
Maybe we need to create C++ classes to release resources.

Fixed by using unique_ptr to unref packet and frame.

Thanks!


Unable to use pip

Could someone please fix the requirements.txt in the pip package. It takes too long to install via pip and mostly crashes pip while installing.

Hi
We're trying to resolve some dependency issues before floating the new version. Meanwhile, you could install it from source using the dev branch.

me too, use pip take  too long time

Hi, new version of imagededup should work fine. Please try it out.


Breaking change after updating from 5.17 to 5.18

Bug description
After updating from 5.17 to 5.18 i notice i can no more run npx prisma migrate deploy inside my docker image
I have an error: Error: Can't write to /home/node/node_modules/@prisma/engines please make sure you install "prisma" with the right permissions.
Look like the command is now doing changes inside node_modules, but for security purpose we can't allow our runtime user to write inside node_modules
I feed like this is an unexpected behavior and should not append
DEBUG=*
prisma:engines binaries to download libquery-engine, schema-engine +113ms
prisma:get-platform Found distro info:
{
  "targetDistro": "musl",
  "familyDistro": "alpine",
  "originalDistro": "alpine"
} +3ms
prisma:get-platform Don't know any platform-specific paths for "alpine" on arm64 (aarch64) +0ms
prisma:get-platform Falling back to "ldconfig" and other generic paths +0ms
prisma:get-platform Found libssl.so file using "ldconfig" or other generic paths: libssl.so.3 +4ms
prisma:get-platform The parsed libssl version is: 3.0.x +0ms
prisma:fetch-engine:cache-dir The following error is being caught and just there for debugging: +1ms
prisma:fetch-engine:cache-dir {
  "errno": -2,
  "code": "ENOENT",
  "syscall": "mkdir",
  "path": "/home/node/.cache"
} +0ms
prisma:fetch-engine:download file<EMAIL_ADDRESS>exists but its version is libquery-engine  and we expect 4c784e32044a8a016d99474bd02a3b6123742169 +6ms
prisma:fetch-engine:cache-dir The following error is being caught and just there for debugging: +1ms
prisma:fetch-engine:cache-dir {
  "errno": -2,
  "code": "ENOENT",
  "syscall": "mkdir",
  "path": "/home/node/.cache"
} +0ms
prisma:fetch-engine:download file<EMAIL_ADDRESS>exists but its version is schema-engine-cli  and we expect 4c784e32044a8a016d99474bd02a3b6123742169 +6ms
prisma:fetch-engine:download https://binaries.prisma.sh/all_commits/4c784e32044a8a016d99474bd02a3b6123742169/linux-musl-arm64-openssl-3.0.x/libquery_engine.so.node.gz will be downloaded to<EMAIL_ADDRESS>+0ms
prisma:fetch-engine:download https://binaries.prisma.sh/all_commits/4c784e32044a8a016d99474bd02a3b6123742169/linux-musl-arm64-openssl-3.0.x/schema-engine.gz will be downloaded to<EMAIL_ADDRESS>+0ms
Error: Error: Can't write to /home/node/node_modules/@prisma/engines please make sure you install "prisma" with the right permissions.
    at downloadBinary (/home/node/node_modules/@prisma/fetch-engine/dist/chunk-IDYGZR4L.js:2330:13)
    at /home/node/node_modules/@prisma/fetch-engine/dist/chunk-IDYGZR4L.js:2159:14
    at Array.map (<anonymous>)
    at download (/home/node/node_modules/@prisma/fetch-engine/dist/chunk-IDYGZR4L.js:2151:41)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async ensureBinariesExist (/home/node/node_modules/@prisma/engines/dist/index.js:74:3)
    at async Ra.parse (/home/node/node_modules/prisma/build/index.js:1276:835)
    at async lPt (/home/node/node_modules/prisma/build/index.js:1999:1678)

How to reproduce
Here is a simple repo to reproduce:
https://github.com/rchoffar/prisma-breaking-repro
docker build . -t prisma-repro
docker run prisma-repro

Change version to 5.17 to see there is no issue
Expected behavior
I expect the command npx prisma migrate deploy to not try to write inside node_modules and expect npx prisma generate or npm installl to install all deps
Prisma information
generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

Environment & setup

Alpine 3.20
PostgreSQL
22.3

Prisma Version
5.18

Have the same, when trying this command from github actions to custom next.js image
Run docker compose exec -T nextjs npx prisma migrate deploy
  docker compose exec -T nextjs npx prisma migrate deploy
  shell: /usr/bin/bash -e {0}
Error: Can't write to /app/node_modules/@prisma/engines please make sure you install "prisma" with the right permissions.
Error: Process completed with exit code 1.


Creating AGAS module

moving primary_namespace implementation to new module
separate performance counters (moved to performance_counter module)
moving more files into component_base module
create new module: naming

A general problem that still needs to be resolved is that async_distributed depends on AGAS (needs to do address resolution), but AGAS depends on async_distributed. Currently this is not detected as the dependency goes through the files that have not been modularized yet.

@msimberg could you help shedding some light on the failing CSCS builders? What's special for the ones that produce the compilation errors?


Fixed #24922 -- Added system check for templates setting

If 'loaders' is present in the TEMPLATES options together with
APP_DIRS set to True, the template engine raises an exception. This
conflict is detected by the system check templates.E001

merged in eaf4d8c0d85056c3481986fe092d5a8786bc4f26, thanks!


🚸 Improve accessibility

🤖 Generated by Copilot at 3ec2d68
Summary
🎨🧩📜

This pull request adds a new accessibility category to the customization settings of the app, allowing users to toggle some features that may affect their experience. It introduces a new component AccessibilitySettings and a new type AccessibilitySettings to handle the logic and data of the accessibility options.

We are the ones who defy the norm
We customize our app with our own form
We switch off the pulse and replace the dots
We are the AccessibilitySettings of the gods

Walkthrough

Add a new component AccessibilitySettings that renders a form with accessibility options (link)
Import IconAccessible from @tabler/icons-react and AccessibilitySettings from src/components/Settings/Customization/Accessibility/AccessibilitySettings.tsx into CustomizationAccordeon (link, link)
Append a new accordion item with id accessibility, image IconAccessible, and content AccessibilitySettings to the customization categories in CustomizationAccordeon (link)
Define a new type AccessibilitySettings with two boolean properties and add it as a property of CustomizationSettingsType in src/types/settings.ts (link)

Can this issue be reviewed?

No, translations are still missing.
I wanted to wait for the review from the user, since I am not colorblind.
However, I'm pretty sure that it's okay. I'll add the translations and mark it ready asap.

@manuel-rw make sure to rebase on dev to get my new ping code, your PR has became incompatible with it

My changes do work now, but it seems that there is a problem with previous commits.
We should not throw a TRPC error, when the ping is not successful.
Instead, we should send this in the data.


Add PULL_REQUEST_TEMPLATE

Adds a PR template to enforce consistency in PR descriptions.

I've canceled the travis build; no code changes here.


move repo to senecajs org

once we are happy with quality
/cc @geek

touch this

@rjrodger I think we are good to move this in. We are using it on a number of projects and I want to make sure the quality and visibility is where it needs to be.

Closed as happening when the Golden Circle org changes happen.


Device Dump - Arlec PC191HA Series 2 with BK7231N

Purchased a four-pack PC191HA Series 2 from Bunnings Australia in July 2024. Date code 0424. All of them are not exploitable.
I have dismantled one and found a CB2S module was used.
Note that I have also purchased a single-pack PC191HA Series 2 at around the same time and it was exploitable. Date code is 0224 and the chip is bk7231t.
pc191ha2_flash.dmp
pc191ha2_rom.dmp

For reference, this is Firmware 1.1.17, which is of course on the known patched list.
I'm assuming the purpose of this issue is just informational, there is nothing actionable to be done, so it will be closed/archived.

I just got a PC191HA Series 3 of these devices also from Bunnings Aus. Dec 2024,
Firmware version: 1.1.17
Date code: 0724
I have not opened it up yet to see the module/chip.

ah.. saw another report with firmware 1.1.8 working so its  the luck of the draw with Series 2


HIP 77: Launch Parameters for Solana Migration

HIP 77: Launch Parameters for Solana Migration

Author: @ChewingGlass,@abhay
Start Date: 2023-02-20
Category: Infrastructure
Original HIP PR: #570
Tracking Issue: #573

Summary
In the course of the migration to the Solana blockchain and prior to the finality date of
2023-03-27, several parameters need to be finalized by the community. This includes everything from
governance settings, circuit breaker settings, and the number of decimals in our tokens to prevent
overflow.
The largest change proposed here is to change MOBILE and IOT tokens from 8 decimals to 6 decimals.
Solana uses the u64 data type to represent token supply, and given the hundreds of billions of
tokens in MOBILE and IOT, with 8 decimals, this would cause an overflow.
The second largest change is the formation of a multisig to govern the helium programs and
parameters. Currently, changes to the blockchain are governed by a master key that flips a chainvar
after validators have upgraded. On Solana, programs are upgradeable by an updated authority.
Motivation
HIP-70 proposed a move to Solana to scale the helium network. Now that the implementation of this
The HIP is well underway, we should finalize the settings for when we move to the Solana network. While
most of these settings can be changed, it is important we reach consensus before flipping the
switch.
Rendered View
https://github.com/helium/HIP/blob/main/0077-solana-parameters.md

@abhay @ChewingGlass - I know you both have mentioned this HIP needs revisions. If this needs to be voted on before the migration, can you add any revisions before Tuesday EOD?
Is there anything the community can support with edits, questions, etc?

There are new updates to HIP 77 based on community & foundation feedback. Please review the HIP in full and reference PR #578

HIP 77 was approved by the community on 11th April 2023 with a passing rate of 98.53%
https://www.heliumvote.com/146pksPcH7C3Wz8hN5NxL544k1VVq6Z4W2iB14e1yJ1HFJ3Wtf3


sample-operator

Thanks submitting your Operator. Please check below list before you create your Pull Request.

Flat operator directory structure is obsolete from 23-rd of October 2019, only nested directory structure will be accepted.

Updates to existing Operators

[✓ ] Is your new CSV pointing to the previous version with the replaces property?
[ ✓] Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
[✓ ] Have you tested an update to your Operator when deployed via OLM?
[ ✓] Is your submission signed?

Your submission should not

[ ✓] Modify more than one operator
[ ✓] Modify an Operator you don't own
[✓ ] Rename an operator - please remove and add with a different name instead
[✓ ] Submit operators to both upstream-community-operators and community-operators at once
[v ] Modify any files outside the above mentioned folders
[✓ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ✓] Description about the managed Application and where to find more information
[✓ ] Features and capabilities of your Operator and how to use it
[✓ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[✓ ] Human readable name and 1-liner description about your Operator
[✓ ] Valid category name1
[✓ ] One of the pre-defined capability levels2
[✓ ] Links to the maintainer, source code and documentation
[✓ ] Example templates for all Custom Resource Definitions intended to be used
[✓ ] A quadratic logo

Remember that you can preview your CSV here.
--
Signed-off-by:  dinesh janepella<EMAIL_ADDRESS>memcached-operator.zip

@janepelladinesh, thank you, but something went wrong. Your PR request contains 700 commits from huge amount of contributors and 2000 files. Please check contribution guidelines. You need to commit just CSV and CRD yaml files for one specific operator. Then feel free to open a new PR.


⚠ Bofrost.be has degraded performance

In b0ce675, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 7551 ms

Resolved: Bofrost.be performance has improved in 42c0b56 after 6 minutes.


Calendar month view renders empty.

Why does the calendar view on month return empty... I don't see any guides that actually work on the repo or site. Is the a SIMPLE way to get a month view calendar working...
Week and Day views work fine. Month view shows only the header... I have tried passing in scheduled events from varied days throughout the month. I know it's not the events because they show on the week and day views...
Inside of a vue app...
template >>

script >>
import Calendar from 'tui-calendar';
export default {
    data() {
        let today = new Date();
        let yesterday = new Date(today);
        let nesterday = new Date(today);
        let chesterday = new Date(today);
        let festerday = new Date(today);
        yesterday.setDate(today.getDate() + 1);
        nesterday.setDate(yesterday.getDate() + 5);
        chesterday.setDate(yesterday.getDate() - 13);
        festerday.setDate(yesterday.getDate() - 15);

        return {
            options: {

            },
            schedules: [
                {
                    id: 1,
                    calendarId: "1",
                    title: "A schedule",
                    category: "time",
                    dueDateClass: "",
                    start: yesterday,
                    end: today
                },
                {
                    id: 2,
                    calendarId: "1",
                    title: "A schedule",
                    category: "time",
                    dueDateClass: "",
                    start: yesterday,
                    end: nesterday
                },
                {
                    id: 3,
                    calendarId: "1",
                    title: "A schedule",
                    category: "time",
                    dueDateClass: "",
                    start: chesterday,
                    end: festerday
                },
            ]
        }
    },
    mounted () {

        var calendar = new Calendar('#calendar', this.options);
        calendar.createSchedules(this.schedules)
    },

Another example using Codepen: https://codepen.io/DanielTate/pen/Qxypoe?editors=1010

@DanielTate You probably missed css unit px of #container.

@dongsik-yoo This is not what is going wrong. Check the codepen. it's still not working. If you could link me a simple working example...

Yes, I checked it worked.


Feature request: Always return list of items

for example, when using the Orders.list_order_items method, it is always necessary to do
isinstance(order_items.parsed.OrderItems.OrderItem, list)
This is repetition on a grand scale, so could possibly do we fixing in the module.
It may not be sensible to make this happen for ALL parts of the module as it could cause problems. Possibly just in select 'pinch points'

This is now covered in develop branch, to be released on master in 1.0 release.


What about the gaussians that are switched off in the end?

Dear author, thank you for your excellent job.
What is the proportion of the type of gaussians that are finally switched off(opacity=0)? And will it be a redundant thing to predict a gaussian for each pixel?

Yes, it's possible that some of them are redundant. There are quite a few that are fully switched off, maybe as many as half but that's just a rough estimate.


Update input_param_scalar_0_gas_600.csv

Hey Thomasz! I can not accept these fixes cause test vectors are generated using this script that removes all the existing data and I want to keep it stateless for now.


chore: build with registry as cache

updates docker-build.sh to use the image registry as a cache
updates make commands to no longer explicitly set platform (but optionally can be assigned via env var)

Testing
Previous CI docker-test run time: 32m
New CI docker-test run time: 7m20s

Run make docker-build and note that most of steps will say CACHED.
Run make docker-build on amd vs arm and use docker inspect image unstructured-api:dev | grep Architecture and note that the respective image for your platform was built

updates make commands to no longer explicitly set platform (but optionally can be assigned via env var)

seems like this is something to promote to pipeline-template and extend to other pipeline- repos.
A couple of nits, otherwise awesome improvement on CI! 🙌

updates make commands to no longer explicitly set platform (but optionally can be assigned via env var)

seems like this is something to promote to pipeline-template and extend to other pipeline- repos.

yep, will do!


Improve branch management

As an experiment, I set the develop branch to protected, and added  requirements for merging braches into it.   They're the same ones we should already be using in principle.  :)  If it works as I expect, Github will now require that a branch:

is up to date with develop
has passed the Travis CI checks

It'll also prevent accidental force-pushing into the develop branch.  I didn't protect the master or testing branches, because we could conceivably want to force push into those to fix mistakes.
I opened this issue to track any suggestions or problems this causes!
@craftyjs/contributors

👍

This is good, except for the inconvenience I encountered now:
If I want to merge in someone's changes into develop, I can't because they are not up to date with develop. I am unable to update that person's branch to newest develop revision from GitHub's interface.
So, in order to merge in those changes, the author of those changes needs to click on update branch himself, or I need to pull his changes to my local git repo and push from there. It's a bit cumbersome.

@mucaho  Those seem like valid points.  It's probably not worth mandating the up-to-date checks if that's causing problems with accepting PRs; we haven't had a lot of issues with conflicts happening in Crafty.
I left develop protected, but turned off the requirement for status checks to pass -- I believe that this will let you make regular pushes to develop, and will only prevent force pushes.
Hopefully github will improve the ergonomics of the status check feature in the future, and we can make use of it.  (I think it was added extremely recently.)

There's a new "Require pull request reviews before merging" option available on protected branches, but I think that in practice that might just be annoying.
For now we'll just leave it as is, but as always, I'm open to suggestions here.


Component Search Close Pane On Selection

Like the title says, just closes the pane when a component is selected so a user can interact with it immediately.

👍🏼


[LCAP-3694] On Demand break "leaking"

Jira: https://staff.loc.gov/tasks/browse/LCAP-3694
insertDefaultValuesComponent had the line userValue['somting'] = {'@guid':'00000','hppts:sfsdfgfdsg.com':['helllerrlooo']} that seems to have been causing the issue. I assume it was a test value used during dev that got left behind?
I've only commented it out in case it's useful for something.

Fixed separately.


Feat/validators monitoring

This PR adds a validators monitoring features.
An actor will poll a cosmos node and send messages to a discord channel when its status changed :

when status changes (bonded to or from unbonded / bonding)
when a validator is jailed or get out of jail

Codecov Report

Merging #84 (7713e27) into main (5a6cc4b) will increase coverage by 17.90%.
The diff coverage is 63.24%.

@@            Coverage Diff             @@
##            main      #84       +/-   ##
==========================================
+ Coverage   1.54%   19.45%   +17.90%
==========================================
  Files         32       39        +7
  Lines        905     1275      +370
==========================================
+ Hits          14      248      +234
- Misses       891     1027      +136

Impacted Files
Coverage Δ

src/cli/commands/start.rs
0.90% <0.00%> (-0.07%)
:arrow_down:

src/cli/config.rs
0.00% <0.00%> (ø)

...rc/cosmos/client/handlers/get_validators_status.rs
0.00% <0.00%> (ø)

src/cosmos/client/mod.rs
0.00% <0.00%> (ø)

src/cosmos/validators/actor.rs
0.00% <0.00%> (ø)

src/cosmos/validators/discord_message.rs
0.00% <0.00%> (ø)

src/cosmos/validators/handlers/get_new_state.rs
0.00% <0.00%> (ø)

src/cosmos/validators/handlers/update_state.rs
0.00% <0.00%> (ø)

src/cosmos/validators/discord_msg_util.rs
99.31% <99.31%> (ø)

src/cosmos/validators/mod.rs
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@amimart up


Saving model and loading model on a separate session gives wrong predictions

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: No
TensorFlow installed from (source or binary): using pip install tensorflow-gpu
TensorFlow version (use command below):1.12.0
Python version: 3.6.3
Bazel version (if compiling from source): -
GCC/Compiler version (if compiling from source): -
CUDA/cuDNN version: 9
GPU model and memory: GeForce 940MX
Exact command to reproduce: As described below

Describe the problem
As soon as training is finished, generating predictions on the testing dataset gives an accuracy > 70.
Then I save the model using model.save(...) method.
When Trying to load the model in a separate session, the predictions are around 20s.
I can confirm that i'm using the same testing dataset and same preprocessing steps that I've done when predicting after training.
To get over with the doubt on the different tokenizers, I've saved the tokenizer to a tokenizer.pickle file which will be loaded before conducting texts_to_sequences and pad_sequences on the testing text data (this didn't make any difference).
I've tried compiling the model after loading before making predictions, this didn't work as well.
Source code / logs
model.save('model.h5') #for saving the model

#Predicting after saving on a different session
trained_model = load_model('model.h5') #for loading the model in a different session.
# load tokenizer
tokenizer = Tokenizer()
with open('trained_model/tokenizer.pickle', 'rb') as handle:
  tokenizer = pickle.load(handle)
test_revs = pd.read_csv('test_dataset.csv')
test_revs.loc[:, 'rating'] = test_revs['rating'].apply(points_to_class) #converting decimal ratings to integer classes
actual_texts = test_revs['text']
actual_ratings = test_revs['rating']
final_Y_test = to_categorical(actual_ratings, 5)
actual_text_tokens = add_doc_to_vocab(actual_texts.tolist()) # preprocessing method
sequences_test = tokenizer.texts_to_sequences(actual_text_tokens)
X_test = pad_sequences(sequences_test, maxlen=1939, padding='post')
# Predictions
pred_test = trained_model.predict(X_test)
pred_test = [np.argmax(x) for x in pred_test]
# Actual
true_test = final_Y_test
true_test = [np.argmax(x) for x in true_test]
# Find accuracies
accuracy = accuracy_score(true_test, pred_test)
print("The total accuracy is : ", accuracy)
I'm new to TensorFlow, if anyone has any suggestions, please raise, cheers !

@AchiraFernando It is strange. The saved model should give same performance as original.
Could you please check the tutorial listed here on saving and restoring models. Please let me know how it progresses. Thanks!

@jvishnuvardhan Thanks for checking!
I think I found the issue.
The model saving and loading works alright as expected.
But the problem is with the tokenizing of the text data and converting the labels to categorical.

I'm using the same tokenizer instance from the training setup works, but I’ve tried using pickle to save the tokenizer instance but that didn’t do any change. Code is as below for saving and loading. Or do you have any suggestions for saving the tokenizer ?

# saving
with open(‘tokenizer.pickle’, ‘wb’) as handle:
pickle.dump(tokenizer_train, handle, protocol=pickle.HIGHEST_PROTOCOL)

# load tokenizer
tokenizer = Tokenizer()
with open(‘tokenizer.pickle’, ‘rb’) as handle:
tokenizer = pickle.load(handle)

I’m using to_categorical to convert the labels (0 to 5) to one hot vectors. I’m using the below piece of code in the training session and testing session. But when testing, doing this gives me false accuracy but using the already converted values from the training session gives me the correct accuracy. Do you think we need to save this by any means as well ?

test_revs = pd.read_csv(‘hotel_reviews_test.csv’) # fetching the reviews from csv to a dataframe

test_revs.loc[:, ‘rating’] = test_revs[‘rating’].apply(points_to_class)

Y_test = to_categorical(test_revs[‘rating’], 5) # converting to one hot vectors with 5 as number of classes

Closing this out since I understand it to be resolved, but please let me know if I'm mistaken.Thanks!


Missing colors in android pie easter egg

Some colors don't have these in easter eggs pie

The colors are random. No color is missing. It's just luck