'Donut' geometries missing the holes

I've found that the geometries that come through GeoJSON.js seem to be missing any holes - any ideas on how to fix this? When I load the json data up in QGIS it displays fine there, so I know it's not the data. I did see a javascript implementation of a JSON > Google Maps feature elsewhere that supposedly takes into consideration polygons with internal rings like this, but unfortunately my JS knowledge is not sufficient to debug that particular implementation or factor it into your code. It's here if you'd like to take a look:
http://friism.com/drawing-geojson-based-polygons-on-google-maps/comment-page-1#comment-1651

Some of the other issues already take a look at this. Have you pulled recently? The index actually has an example of a polygon with an interior ring. If you give me some example GeoJSON that doesn't work I can try to fix it.

Here is one of the specific polygons I am having the issue with, and I am using the latest revision of GeoJSON.js...
var polydata =
{
        "type":"FeatureCollection",
        "features":[
            { "type":"Feature", "id":8,
                "properties":{
                    "AREA":46147406.683990,
                    "PERIMETER":41165.214250,
                    "PD_ID":831478,
                    "PD_NUM":9,
                    "PD_NBR_SFX":"0",
                    "PD_TYPE":"N",
                    "ADV_POLL":"600",
                    "ED_ID":1351,
                    "FED_NUM":35012,
                    "A_UPDT_DTE":"2006\/10\/30",
                    "G_UPDT_DTE":"2003\/08\/27",
                    "EMRP_NAME":"9",
                    "OBJECTID":1448411,
                    "SHAPE_AREA":46147406.233300,
                    "SHAPE_LEN":41165.214292
                },
                "geometry":{
                    "type":"Polygon",
                    "coordinates":[
                        [
                            [ -76.165286, 45.479514 ],
                            [ -76.140095, 45.457437 ],
                            [ -76.162348, 45.444872 ],
                            [ -76.168656, 45.441087 ],
                            [ -76.201963, 45.420225 ],
                            [ -76.213668, 45.429276 ],
                            [ -76.214261, 45.429917 ],
                            [ -76.227477, 45.440383 ],
                            [ -76.263056, 45.467983 ],
                            [ -76.245084, 45.468609 ],
                            [ -76.240206, 45.471202 ],
                            [ -76.238518, 45.475254 ],
                            [ -76.233483, 45.507829 ],
                            [ -76.227816, 45.511836 ],
                            [ -76.212117, 45.516230 ],
                            [ -76.191776, 45.501540 ],
                            [ -76.174016, 45.486911 ],
                            [ -76.165286, 45.479514 ]
                        ],

                        [
                            [ -76.227618, 45.489247 ],
                            [ -76.232113, 45.486983 ],
                            [ -76.232151, 45.486379 ],
                            [ -76.231812, 45.485106 ],
                            [ -76.230698, 45.483236 ],
                            [ -76.225664, 45.477365 ],
                            [ -76.223568, 45.475174 ],
                            [ -76.202829, 45.458815 ],
                            [ -76.200229, 45.458822 ],
                            [ -76.199069, 45.459164 ],
                            [ -76.188361, 45.465784 ],
                            [ -76.204505, 45.479018 ],
                            [ -76.215555, 45.488534 ],
                            [ -76.220249, 45.492175 ],
                            [ -76.221154, 45.493315 ],
                            [ -76.226310, 45.490189 ],
                            [ -76.226543, 45.489754 ],
                            [ -76.227618, 45.489247 ]
                        ]
            ] } }

        ]
    };

I tried the example Polygon/Hole and it most certainly does work, and I also enclosed it in a feature collection and had no issues either. I'm making the assumption that the data I am using is correctly formatted as it does appear correctly when I open the GeoJSON file directly in QGIS, but it could just be that QGIS is handling an issue in the data that I am unaware of.

Maybe I am missing the point but when I use your GeoJSON example it seems to work fine. This is what I get and it looks like its correct. http://i1160.photobucket.com/albums/q483/gmccrackin/ScreenShot2012-03-09at21048PM.png

It seems it's me that's missing the point, as I grabbed the latest GeoJSON.js and you're correct it works fine... I'm not sure how I ended up with an older version as I only downloaded it a few days back and the last edit from the history seems to be 17 days ago. Regardless, thanks for your time - and sorry if I wasted it!

no problem dude. Im just glade it wasn't faulty.

Thanks for picking up my slack @gmccrackin. Glad you're all fixed up @blitzd.


Update FALSEHOODS.md

Adding additional falsehoods. Feel free to take them or leave them, but I have encountered programmers that believe them.

I signed it!

Thanks so much for your contribution!!


Non-generic OS path detection.

Code
The error is introduced in the make() call by get_template()
from os.path import join

class ModelFactory:
    def __init__(self, environment, flavor, fieldfactory):
        self.environment = environment
        self.flavor = flavor
        self.fieldfactory = fieldfactory

    def make(self, database, schema, name, fields=[], constraints=dict()):
        # get the template by flavor...
        template = self.environment.get_template(join(self.flavor,'create.j2'))

        # map a serialized format onto the fields...
        fields = map(lambda x: self.fieldfactory.make(x), fields)

        # build the table.
        return Model(template, database, schema, name, fields, constraints)

The environment uses a FileSystemLoader on os.path.join(os.path.dirname(file), 'templates') in my settings file.
Expected Behavior
This snippet should detect the template 'mssql\create.j2' in Windows.
Actual Behavior
Running list_templates() on the environment detects 'mssql/create.j2' like a unix path, but raises a TemplateNotFoundError for 'mssql\create.j2'. When I change my code to below, it detects the template:
        template = self.environment.get_template(self.flavor+'/create.j2')

It seems strange not to support generic OS functionality, and seems like FileSystemLoader normalizes all environments down to a list of Unix paths. Consider extending to build OS-specific paths.
Traceback
Traceback (most recent call last):
  File ".\main.py", line 47, in <module>
    main()
  File ".\main.py", line 34, in __call__
    item[1], item[2], item[3], fields=columns
  File "C:\workspace\python\projects\metamigrate\models.py", line 21, in make
    template = self.environment.get_template(join(self.flavor,'create.j2'))
  File "C:\workspace\python\envs\scipy\lib\site-packages\jinja2\environment.py", line 830, in get_template
    return self._load_template(name, self.make_globals(globals))
  File "C:\workspace\python\envs\scipy\lib\site-packages\jinja2\environment.py", line 804, in _load_template
    template = self.loader.load(self, name, globals)
  File "C:\workspace\python\envs\scipy\lib\site-packages\jinja2\loaders.py", line 113, in load
    source, filename, uptodate = self.get_source(environment, name)
  File "C:\workspace\python\envs\scipy\lib\site-packages\jinja2\loaders.py", line 168, in get_source
    pieces = split_template_path(template)
  File "C:\workspace\python\envs\scipy\lib\site-packages\jinja2\loaders.py", line 31, in split_template_path
    raise TemplateNotFound(template)
jinja2.exceptions.TemplateNotFound: mssql\create.j2

Environment

Python version: 3.6.3
Jinja version: 2.10

Template paths are not filesystem paths. They just happen to behave like that when using the filesystem loader.
As a more general note, Python supports / as a separator on Windows, so there's usually no reason to use Windows path separators.


get_number: missing newline

Using just <Enter> with the following command list (call inputlist([1,2,3]) | call inputlist([4,5,6])) shows:
1
2
3
Type number and <Enter> or click with mouse (empty cancels): 4
5
6
Type number and <Enter> or click with mouse (empty cancels):

It would be better if there was an implicit newline when just "" is used, and also with selecting a number:
1
2
3
Type number and <Enter> or click with mouse (empty cancels): 1
4
5
6
Type number and <Enter> or click with mouse (empty cancels):

(I've noticed this with ultisnips which spawns several calls to inputlist() after each other - certainly a misfeature, but it would be nice to have newlines there inbetween then)

Fixed via https://github.com/vim/vim/commit/8c96af9c05bfcac2d5ae081e098d4863db561511 (https://github.com/vim/vim/pull/4973#issuecomment-541940087).


address on 'update my profile' not validating

Current Behavior
you can update an address to say whatever you want, it doesn't validate
Desired Behavior

address validate like on the signup data form

Steps to Replicate

go to user/XXX/edit and update the address
put in something that doesn't make sense

Relevant Screenshots + Links
no errors on user/edit

errors on signup data form

This probably has something to do with the fact that field_address is treated different than the signup data form here

@chloealee i also noticed the address is probably not validating when admins change the page at http://dev.dosomething.org:8888/us/user/10/edit because it's checking for user/id/edit without the us prefix
since we are only validating us address we can probably update that line

I forgot that the info form recently added address #6027, so it's probably as simple as adding validation to it.
cc @katiecrane

Oooo whoops yeah I just had it updating the values and didn't do anything special to validate it it looks like. Sorry!

@angaither on my local when I go to edit, it doesn't have the country code - http://dev.dosomething.org:8888/user/1704953/edit but still allows it to save.
Also, should I be adding this validation again in dosomething_user.module even though it's already here (where you noted above)?

this form needs to have validation added
the country code only gets set locally if you manually set fastly headers

ah, thanks for clarifying, @angaither !


Refactor Twitter NRTS package to use Jetty servlets

The current implementation of TweetSearcherServer parses raw HTTP requests.
We should use a proper servlet container like Jetty:
http://www.eclipse.org/jetty/
Example of embedded servlet:
http://www.eclipse.org/jetty/documentation/9.1.4.v20140401/embedded-examples.html#embedded-minimal-servlet

The refactoring part was pulled as a request.
However, for one thing, the original implementation of TweetSearcherServer used thread pool mechanism. Once we switch to Jetty servlet, thread pool mechanism would be unnecessary? Since some of the discussion about Jetty servlet suggests it handles incoming requests in multithread implicitly.
https://dev.eclipse.org/mhonarc/lists/jetty-dev/msg01212.html
"what your running into is that once a request enters into the servlet api, it has a thread allocated to it for its lifetime in the servlet-api prior to servlet 3.0 where the concept of async was supported.  continuations is a mechanism that allows for a similar mechanic on jetty in servlet 2.5 and yes, jetty is multithreaded."

Commented on pull request.
Yes, I believe Jetty handles async requests behind the scenes.

Merged. commit 89a7daab03b360104c44e4fbf123162fce945efe


VERSION vs INSTALL tags backwards?

Maybe my understanding is wrong, but it seems THIS_APP_VERSION and THIS_APP_INSTALL are backwards. The VERSION tag is using package lastUpdateTime... shouldn't it be using package versionCode? Install is date oriented, while version is build number instead.

I believe it should work how it is (but maybe my understanding is also wrong).
THIS_APP_INSTALL just checks for any presence of the tag - so since the app was installed and Once started tracking the tag, no need to check the timestamps against anything.
I think the reason I chose to use lastUpdateTime (it's been a few years...) is that I can easily compare that datetime against the datetime when the tag was last seen, lastUpdate time covers app updates so if a tag's timestamp is greater than that, you know it's been done since the last app version (which might be the same as install). versionCode would also work, but I'd need to store which versionCode the tags were mark done against, in addition to the timestamp (as that's needed for the 'in the last 5 min' functionality).


Implementing the API-boilerplate using Tokens Issue- Best Practice

Currently using this template on my webAPI, have created a UI call from MVC on a different project.
Every time I call the API using Httpclient, I constantly generate new tokens and add on the authorization headers for the request to go through.
Is this the best practice or there should be another way I should re-use the tokens when not yet expired? Is there any impact when I constantly generate the token on each request?

Kind Regards

Can you check HttpClientFactory please

@cetindogu  not sure if I get you right please. Kindly elaborate

You would need to store the generated token somewhere on the client side, like local storage or sessions. Every new HTTP request should first check the local storage for a token. If found, use it, else redirect to login page which then posts to the /token endpoint. Or better, you can make use of refresh token endpoint.

@cetindogu not sure if I get you right please. Kindly elaborate

Read "Named clients" section Use it declere your named client in program.cs or startup.cs with your token then you can use it until the token expire.
https://docs.microsoft.com/en-us/aspnet/core/fundamentals/http-requests?view=aspnetcore-6.0

Thank you @iammukeshm. Well noted.

@cetindogu not sure if I get you right please. Kindly elaborate

Read "Named clients" section Use it declere your named client in program.cs or startup.cs with your token then you can use it until the token expire.
https://docs.microsoft.com/en-us/aspnet/core/fundamentals/http-requests?view=aspnetcore-6.0

Thanks for this. Appreciated.
Well understood now.


Fix: 500 when submitting incomplete person match form

The report email came during the night: incomplete form submitted to find a matching person didn't work correctly (caused server 500 error).
The error was: form variable was unbound in the local scope (which was a result of wrong steps order in the person matching logic).

:+1: to merge - what was the user action that produced the incomplete form?

User entered text "ingi" into the autocomplete field and pressed [enter]. This caused the form to not find anyone and later, in the maze of logical conditions in the code, form variable was never assigned (because in original code it was assigned after the statement that was causing an exception).


Added the ability to recreate the PS stream

This is a pull request for #2503.
Changes
Recreate the  PS stream if necessary during saveAs.
Description

To avoid affecting the existing behavior, I make sure that the additionally implemented codes will not be executed unless parse is executed and saveAs is called.
Some implementations were not derived purely from the Type 1 standards, but were based on AFDKO, so there may be some bias.
In addition, the Type 1 fonts available were limited for me, so the verifications by me are also limited.

Looks ok to me. @anthrotype, what do you think? Given the small audience this will have, I'm tempted to just merge and not worry too much about further fine tuning the code.

Sounds good to me, thanks!


Only Java 12 supported?

Describe what happened:
Attempting to use this library from a Java 8 JDK results in the following:
java.lang.UnsupportedClassVersionError: com/datadoghq/sketch/ddsketch/DDSketch has been compiled by a more recent version of the Java Runtime (class file version 56.0), this version of the Java Runtime only recognizes class file versions up to 52.0
  java.lang.ClassLoader.defineClass1(Native Method)
  java.lang.ClassLoader.defineClass(ClassLoader.java:763)
  java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
  java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
...

Describe what you expected:
For the library to work on many versions of Java, or for the README to explicitly state the version requirements.
👋 Thanks for creating and sharing this library. Perhaps it needs a newer version of Java, if that's the case, could it be stated in the README?
Cheers!

It doesn't seem like its needed.  I adjusted the version requirements in the gradle build and it compiled fine in Java 11.  I didn't try Java 8.  At least 11 would be better since its a long term supported release.


Add a maximum page number

Due to the nature of the distributed index, it becomes increasingly difficult to fetch results as the page number grows.
Probably for this reason, Google seems to limit queries to 300-400 results. Also, there's a good argument that nobody may be willing to go much further.
With the current default of 25 results per page, should we add a maximum page number of 20 ?

Good argument that nobody may be willing to go much further.

I think adding maximum page number to 20 makes more sense.

Google has a max of 300-400 results because of the way they do queries: each shard only returns a couple of candidate answers. All web-scale indexes are done that way, with lots of shards. Only a few % of searches go to the 2nd page, although I think 80% of people doing searches occasionally go to the 2nd page. The faction of non-robots that go to deep pages is vanishingly small. I don't think there's any reason to go beyond 50 results, especially if you think your robot defenses are weak.


confused by the file input format

maybe i dont understand the input format, could you please provide some explanation.
Also, i noticed that some mistakes, like
In [28]: in run.ipynb
import torch
from utils import set_seed, set_plt_style

set_seed(42)
set_plt_style()
device = torch.device("cuda" if torch.cuda.is_available else "cpu")
the torch.cuda.ia_available dont have shoule be torch.cuda.ia_available()

and in models.py
the transformers methods import should be:
from transformers import (     DistilBertConfig,     DistilBertModel,     LongformerConfig,     LongformerForSequenceClassification, )

Hello @richards12306 , thank you for filing an issue!

torch.cuda.is_available
Thanks for pointing this out, I'll make sure to fix it.

from transformers import ...
Admittedly I left some work unfinished, and there are mistakes and missing parts, especially for the transformers bit. I realized that applying transformer models to a new domain (i.e. non-NLP) would require me to train these models from scratch, which I wasn't able to do at the time due to lack of compute resources. I don't plan on doing this any time soon, so for now, I'll leave it as a to-do and remove relevant unfinished code snippets.

Input format
The relevant code is here. The code reads file binaries directly. In my own experiments, I had two directories in data/benign and data/malware, which contained being and malicious PPE files (i.e. files with .exe or .dll extensions). But really, any file that can be read as binary should be fine.

Let me know if you have any more issues or comments. Thanks again.

Hello
What dataset did you use to train and produce your result? Or where can you collect benign and malware sets? If you created your own dataset, did you make a file to keep a ground-truth label of each file?
Thanks

Hello
What dataset did you use to train and produce your result? Or where can you collect benign and malware sets? If you created your own dataset, did you make a file to keep a ground-truth label of each file?
Thanks

you can use the VirusSign,VirusShare. you just need to send a confirm email to them.

Okay, thank for your help. But Virusshare or VirusSign has only malware. How about benign samples? I think it is quite tricky to have thousands of benign samples.

Thanks for the input @richards12306, I also obtained samples from VirusShare (I looked into VirusSign and it seems similar).
As for benign samples, there are many websites that allow you to download .dll files.  I also obtained some clean samples manually from a fresh Windows install on VMware.

@jaketae thank you so much for your help.  your code is so handful. Let me try it!


do not run CI on draft PRs

@BalzaniEdoardo thoughts on only having the CI run for PRs that are not draft
I canceled most of my CI runs while doing the latest PR, but I think it is nice not to worry about it. Also, you only get a certain number of free CI minutes per month.

I thought at some point I disabled the ci for drafts. I totally agree it would not run

Just as a note, I'm not sure we do have a limit on the number of free CI minutes per month: "GitHub Actions usage is free for standard GitHub-hosted runners in public repositories, and for self-hosted runners. For private repositories, each GitHub account receives a certain amount of free minutes and storage for use with GitHub-hosted runners, depending on the account's plan." (source).
There is a limit on the total execution time of each job and total concurrent jobs, but I don't think we're anywhere near those limits.
Not a bad idea to disable them for drafts anyway, but wanted to clarify (this has come up for our other packages as well).

I just brought it up because Kushal and I are paying for additional minutes every month because our CI takes so long to run, so we try to make sure that the CI is not run until code is actually ready for review :)


Remove defaults

Removes settings that are the default in the google base style

@davetcoleman Maybe there was a reason why these are defined even if it is the default?

I've adapted clang-format's rules for several different code repos, each with slightly different code rules. Having them all explicitly listed makes it faster to tweak the settings that need tweaking.
I agree that reducing the settings might make it cleaner, but I'm not sure changing this, at this point, is worth the potential issues it might possibly cause...


Cleanup NetBeans license header for module api.annotations.common

Review and cleanup the license header in api.annotations.common
Oracle donated NetBeans to the Apache Software Foundation.
Your task now is to replace the old license header that has Oracle (and/or Sun Microsystems
and/or NetBeans) in it with the standard Apache Software Foundation license header.
For an empty file that supports headers you must add the Apache license header.
Note that you have to use the proper license header for Java, .properties or HTML files.
Look at the nearby files for templates and copy-paste the license header.
When done commit the changes with a commit message that starts with first line
"[NETBEANS-54] Module Review " and a message body describing your review.
See a longer explanation about what we are doing here: https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review
Please announce in a comment when you have started work.
Files that need to be looked at in api.annotations.common:
api.annotations.common/apichanges.xml

Already have PR in apache.


Subtitles support.

Hi,
i want to buy this plugin but i want to know if supports the subtitles.
Thanks a lot.

It should be possible but will require creating a Xamarin Forms custom renderer to extend VideoPlayerRenderer in your platform specific-project to expose the functionality you desire. Under the hood, this component is just using Android's MediaPlayer and iOS's AVPlayerViewController which are the stock/default video UI controls of each platform.

Thank you!


Form Validation Using JQuery

Issue : https://github.com/surajondev/JavaScript/issues/54
I have submitted this Pull Request as my 4th and last Pull Request to Hacktoberfest 2023
This a Front-End Form Validation Register Page using :

Javascript
JQuery
HTML
CSS

Thanks for the PR.


Text underline in linked list items only appears under entire text block (Figma)

When a list item in Figma is intended to function as a link, the underline appears only beneath the entire text block rather than under each line individually. This becomes problematic for multi-line text, as the underline does not align with each individual line, potentially affecting readability and visual clarity.
Expected Behavior
Each line within a multi-line list item should have its own underline to indicate the link, maintaining consistent visual cues across all lines of the list item.
Steps to Reproduce

Use the ErrorSummary component in figma which has a list with links
Observe that the underline only appears under the whole block of text rather than each line individually.

Impact
This affects readability and the user’s ability to recognize the item as a link, particularly in lists with longer descriptions that span multiple lines.
Suggested Solution
Consider an approach that allows individual line underlining within multi-line list items to enhance link visibility and accessibility.

We should consider to change the Link component to use underline instead of separate line.


I'm unable to register mi API key

I installed intheam via pip and typed intheam setup. I tried to input my key by hand, and pasting; including my username and without it, with no success. Here is the error:
INFO:requests.packages.urllib3.connectionpool:Starting new HTTPS connection (1):     inthe.am
ERROR:taskwarrior_inthe_am.cmdline:The supplied API key is invalid

I get the same error, on Arch Linux.

I have the same issue.
Taskwarror version 2.4.4, openSUSE 13.2.

Running Arch Linux too and I get the exact same error. Double checked the api key and it's correct.

Same error on ArchLinux.

Same on Windows with Python 3.7 in both Cygwin and CMD.

[SOLUTION]
keyring del taskwarrior_inthe.am api_v2_key


Error when runnign tests with python3.5 on Travis

https://travis-ci.org/LD250/jenkins-cli-python/jobs/231733557

pkg_resources.VersionConflict: (pbr 1.10.0 (/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages), Requirement.parse('pbr>=2.0.0'))

Is this still a problem? I just ran a travis test with this file:
$ cat .travis.yml
language: "python"
python:
    - "2.7"
    - "3.4"
    - "3.5"
    - "3.6"
install:
    - pip install flake8 mock==2.0.0
script:
    - flake8
    - python setup.py test

and the job passed just fine. I'll follow up with a PR


Incorrect tokenizing

Found a bug where the string bredcp is tokenized as
Token { ty: Ident, source: "br", range: 0..2 }
Token { ty: Ident, source: "bredcp", range: 0..6 }

Instead of
Token {
    ty: TokenType::Ident,
    source: "bredcp",
    range: (0, 6)
}

The ident token is here, and it's extra confusing because I don't have any tokens that are remotely close to br, plus the fact that it's being somehow retokenized (As indicated by the ranges of the tokens makes this even stranger.
I also made a test case that exemplifies this error. I do have a small iterator adapter wrapped around logos, but this shouldn't have any effect as all it does is filter out unused tokens

It seems this also happens with the input breuyue, is there something inside my regexes that I'm missing?

If this is happening on 0.10 then this is likely same issue as #88. I'm doing a full rewrite of the derive macro right now (#94), which should solve these, amongst other things.

@Kixiron I've just released 0.10.0-rc3 on crates.io, could you update and check if the issue persists?

I switched versions and have been greeted with 48 of these:
error[E0308]: mismatched types
 --> crates\crunch-parser\src\token.rs:6:10
  |
6 | #[derive(Logos, Debug, PartialEq, Eq, Clone, Copy, Hash)]
  |          ^^^^^ expected fn item, found a different fn item
  |
  = note: expected fn item `for<'r> fn(&'r mut logos::lexer::Lexer<token::TokenType, _>) {<token::TokenType as logos::Logos>::lexicon::_handle_0_newline::<'_, _>}`
             found fn item `for<'r> fn(&'r mut logos::lexer::Lexer<token::TokenType, _>) {<token::TokenType as logos::Logos>::lexicon::_error::<'_, _>}`

Oh, I'm so sorry, I didn't bump the dependency in logos itself and I kept testing it with separate imports.

It fixed the problem this issue is about, but it caused a regression to one of my previously found bugs in logos
    #[test]
    fn keyword_led_ident() {
        let mut exposed_function = TokenStream::new("exposed_function", true).into_iter();

        assert_eq!(
            exposed_function.next(),
            Some(Token {
                ty: TokenType::Ident,
                source: "exposed_function",
                range: (0, 16)
            })
        );
        assert_eq!(exposed_function.next(), None);
    }

---- token::tests::keyword_led_ident stdout ----
thread 'token::tests::keyword_led_ident' panicked at 'assertion failed: `(left == right)`
  left: `Some(Token { ty: Exposed, source: "exposed", range: 0..7 })`,
 right: `Some(Token { ty: Ident, source: "exposed_function", range: 0..16 })`', crates\crunch-parser\src\token.rs:492:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

A-ha, gotcha. I narrowed it down to the interaction of these 3:
    #[token = "else"]
    Else,
    #[regex = "[^ \t\n\r\"\'!@#$%\\^&*()-+=,.<>/?;:\\[\\]{}\\\\|`~]+"]
    Ident,
    #[token = "exposed"]
    Exposed,

What happens is, combining else with exposed produces a fork, and it seems the loop doesn't propagate correctly in all branches. That should be a pretty narrow problem to track.
I can run tests on crunch myself, are all the ones with #[ignore] Logos related?

Running tests is a little finicky, as I'm in the midst of a total rewrite, you have to cd into crates/crunch-parser before it'll work. As for ignored tests, as of now I don't have any, you may be on the wrong branch. My current development is on the dev branch, with logos residing here. The test that's currently failing is here

And thank you so much for the hard work, logos is a fantastic crate and your work is very much appreciated!

Well, I went to bed, but then I figured out how to solve this while I was trying to fall asleep :man_shrugging:.


Fix scroll layout for iPad in settings->about

Description:
UIScrollView in Settings->about section is wrong in iPad with landscape orientation.
Steps to test this PR:

In iPad, go to about section from settings.
Change orientation to landscape.
Move scroll to bottom position.

Hi @ArtCC - it wasn't quite right, I made a little change to make the width of the text work on iPad and iPhone, but that is available in https://github.com/duckduckgo/iOS/pull/378 so I'm closing this one out.  Thanks for your contribution!


Update contact form

📝 Changed routes:

/contact-us

(view full size)

Commit afa736e16ca0b76ce32d0b46421f1db98e4042ab (https://thirdweb-c94bg1j3d.thirdweb-preview.com).


Preference to automatically advance to next letter

There's now a setting, but this could be better:

Skip revealed letters;
Select next cell relative to tapped cell


updates to latest eksd (#2706)

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


Show div on button press

Brief Description of Fix
Shows the div only on verify button press
Linked Issue
Closes #58

!bounty 40


Plain authorization support

Describe your changes
Add support for plain authorization & fix minor issue with requirements on Windows.
Internal Jira ticket number or external issue link
Issue #140
Testing procedure/screenshots(if appropriate):
Tested connection to Impala server using plain authorization, which worked. I can provide screenshots upon request.
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have formatted my added/modified code to follow pep-8 standards
[x] I have checked suggestions from python linter to make sure code is of good quality.

Can you attach some screenshots showing a successful dbt debug connection.

@TapasSenapati Sure! I blotted out some potentially sensitive user info, but here it is:


Pick from the Onboarding playlist of the Mob Mentality Show

https://www.youtube.com/playlist?list=PLGME-VQ8iegj9rLxgKnMlmv0lgF97Jofc

Researching
Teams might or might not be ok in reading docs as a mob vs researching on their own laptop. Find what works for you,
Efficiency
The pressure of delivery: rhythm doesn't lead to big breaks, more relaxed approach, social aspect of getting to know people.
Mob size: if I am not contributing or learning, than I go to another mob. But larger mobs solve more difficult problems, correlation between size and difficult.
Exploration of a new complex task: actually really good for mobbing to avoid the silo of being the one familiar with Zenodo/DataCite
Common report: doubleing the output after losing two engineers and working as a mob. People underestimate the time it takes to share context, and to coordinate asynchronously.
Model behavior
Show people that you make lots of small mistakes all the time, and that it is ok.


awesomewm: Setting to specify the prefix of the battery current and full charge path

In my case, the battery charge paths where named "charge_now" and "charge_full" rather than "energy_now" and "energy_full". This change enables the user to set their own prefix if it is needed.

I agree completely that making it not require a setting is better. This commit matches more or less directly the way it is being done in the C code. Should I try to reduce code duplication while still having the same behavior or do you prefer it to be similar the the way it is done in C?

I agree completely that making it not require a setting is better. This commit matches more or less directly the way it is being done in the C code. Should I try to reduce code duplication while still having the same behavior or do you prefer it to be similar the the way it is done in C?

Feel free to write it not idiomatically, Lua is certainly not C

Feel free to write it not idiomatically, Lua is certainly not C

:+1:

:+1:


add failing test for live read streams

when setting live: true, the stream closes after the last
element.
expected behaviour: stream stays open

Thanks. Let me ponder on this for a bit wheather live streams belong here or in a user land module.


Bad performance under load

Hello. We started to use zabbix-module-sockets-1.1.0-1.x86_64.rpm and hit following problem. When OS has a lot of sockets, /proc/net/tcp read becomes too slow. zabbix-agents use 100% cpu and become unreachable. Thus we get holes in all graphs from high loaded host instead of stats while we  get load spike.

What do you think about some internal caching implementation of /proc/net/ files inside zabbix-module-sockets ?

How frequently are you sampling the data? It looks very granular. The recommended granularity for Zabbix is typically 60-300 seconds. There is (in most cases) very little benefit and a high cost to < 60s sampling intervals.
It also looks like you are experiencing a transient spike in TCP sockets that might correlate to a load increase and Zabbix having less scheduled time on-CPU.
This module has not been profiled or optimized because the intention is that it takes only a small fraction of compute time, due to the wider Zabbix monitoring intervals.
If you'd like it optimized to run at this granularity, can you please provide some profile data under load, so I can where the code is spending most of its time in your case? The linux perf profile tool is a great option.


Vendor Extensions in Operations

All requests to the API I am developing require an HTTP header value to be set as part of the request. As a result, all "try it out" calls fall from the Swagger UI as they do not contain the header.
I have tried adding the header via an IOperationFilter as such:
public class VendorExtensionFilter : IOperationFilter
{
    public void Apply(Operation operation, SchemaRegistry schemaRegistry, ApiDescription apiDescription)
    {
        operation.vendorExtensions.Add("x-api-required-header-key", "test-value");
    }
}

...but I'm not sure of a couple of things:

Is this the intended use?
Does the Swagger UI support testing with this scenario?
Is there an alternate approach to supplying the header to test invoking the operation?

Thanks for any help/guidance.

If I understand you're requirement correctly, I don't think you need a vendor extension because Swagger already has properties for describing "header" parameters for an operation:
public class CustomHeaderFilter : IOperationFilter
{
        if (operation.parameters == null)
            operation.parameters = new List<Parameter>();

        operation.parameters.Add(new Parameter
            {
                @in = "header",
                name = "X-CustomHeader",
                type = "string",
                @default = "foobar"
            });
    }
}


Add core and alloc over std Lints

Objective

Fixes #6370
Closes #6581

Solution

Added the following lints to the workspace:

std_instead_of_core
std_instead_of_alloc
alloc_instead_of_core

Used cargo +nightly fmt with item level use formatting to split all use statements into single items.
Used cargo clippy --workspace --all-targets --all-features --fix --allow-dirty to attempt to resolve the new linting issues, and intervened where the lint was unable to resolve the issue automatically (usually due to needing an extern crate alloc; statement in a crate root).
Manually removed certain uses of std where negative feature gating prevented --all-features from finding the offending uses.
Used cargo +nightly fmt with crate level use formatting to re-merge all use statements matching Bevy's previous styling.
Manually fixed cases where the fmt tool could not re-merge use statements due to conditional compilation attributes.

Testing

Ran CI locally

Notes

This is a massive change to try and push through, which is why I've outlined the semi-automatic steps I used to create this PR, in case this fails and someone else tries again in the future.
Making this change has no impact on user code, but does mean Bevy contributors will be warned to use core and alloc instead of std where possible.
This lint is a critical first step towards investigating no_std options for Bevy.

I think we should do this. This is easy to enforce and for contributors to adapt to, and the auto-fix is particularly nice. Import consistency is a nice side benefit too.
I'm not convinced that Bevy will ever be able to be fully no-std, but doing this now will make supporting weird platforms (notably consoles) in the future much easier and give us a better sense of how far away we are, what changes we need upstream and what parts of the standard library the teams will need to reimplement for their platform.

I'm OK with doing this internally, but I don't think examples should be changed. They should still use std

I've switched the examples back to using std instead of core or alloc, and added the appropriate #![expect(...)] attributes to relevant examples so they still pass CI. I would like to just have separate lints for the examples, but I couldn't see a quick way to implement it.

To avoid changes to the examples, I've had to duplicate the workspace lints in the root Cargo.toml, as there is currently no way to override workspace lints within a particular member (see rust-lang/cargo#13157 for details). Examples are no unchanged beyond their use statements being re-merged by cargo +nightly fmt as described in this PR description.

@bushrat011899 Ping me when merge conflicts are resolved and I'll get this in ASAP.

Thank you to everyone involved with the authoring or reviewing of this PR! This work is relatively important and needs release notes! Head over to https://github.com/bevyengine/bevy-website/issues/1698 if you'd like to help out.


Active participation in guides

I can currently participate in translations for the guides.
As has already been said here, that's where to start.

Thanks Ushieru


[Feature] Add DiffUtil support

Add DiffUtil support which will allow the ability to dispatch updates to a sectioned list.
<EMAIL_ADDRESS>

I personally use SortedList(https://developer.android.com/reference/android/support/v7/util/SortedList) in my SectioningAdapter (one for each section)

Old issue but I didn't use this before so maybe this is helpful for others that are searching in 2019. Workaround in Kotlin:
class ListAdapter(
	private val items: List<ListObject>
) : RecyclerView.Adapter<RecyclerView.ViewHolder>(), StickyHeaders {

	private var stickyHeadersObserver: RecyclerView.AdapterDataObserver? = null

	override fun registerAdapterDataObserver(observer: RecyclerView.AdapterDataObserver) {
		super.registerAdapterDataObserver(observer)
		if (observer::class.java.enclosingClass == StickyHeadersLinearLayoutManager::class.java) {
			stickyHeadersObserver = observer
		}
	}

	override fun unregisterAdapterDataObserver(observer: RecyclerView.AdapterDataObserver) {
		super.unregisterAdapterDataObserver(observer)
		if (observer == stickyHeadersObserver) {
			stickyHeadersObserver = null
		}
	}

	fun updateItems(newItems: List<ListObject>) {
		// Create a DiffUtil.DiffResult and dispatch it
		getListDiff(items, newItems).dispatchUpdatesTo(this)
		this.items= newItems
		stickyHeadersObserver?.onChanged()
	}
}

Basically you can catch the observer and then call onchanged yourself after setting the new items. Because the observer class is a private inner class of StickyHeadersLinearLayoutManager, we check if the enclosing class is that one and therefore we know we have the correct observer. This is made with version 1.0.1.


Automated Unit Tests Execution

As a developer,
I want automated unit tests to be executed upon every code commit,
So that I can ensure code quality and prevent regressions.
Details and Assumptions
Unit tests should be automatically triggered.
Acceptance Criteria
Given a codebase with automated unit tests,
When the CD pipeline is triggered,
Then the pipeline executes automated unit tests as part of the build process.
Then the pipeline fails the build if any unit tests fail.

Duplicate of #42


Fix #20

See also: https://github.com/ggandor/leap.nvim/commit/2a23eb1c2d34cddafe8fb188c5d38d506f3864a5

Also fix https://github.com/ggandor/leap.nvim/issues/106

I missed this, thanks very much!

No problem, thanks for the awesome plugin!


2 factor authentication using certificates?

Is it possible to use 2-factor authentication using public/private certificates with this library? This library is used in some webdav client projects, and I'm working to get 2FA support in those.
Essentially, this article on using Curl to connect to a WebDAV drive using 2FA certificates describes the functionality:
https://www.qed42.com/blog/using-curl-webdav-two-factor-authentication
Is this possible with this library? If not, what would it take to make it happen?

Some more info about this, you can see that the request.js library has support for 2 factor auth using certs + passphrase here:
https://github.com/request/request#tlsssl-protocol
This is essentially what I'm trying to see if node-fetch would be able to support.

Sorry for the late reply, you can definitely set many of these in a http.Agent instance and pass it to node-fetch, see options:
https://github.com/bitinn/node-fetch#options
And if you can do it in plain nodejs https and you can probably do it with node-fetch + http.Agent.
https://engineering.circle.com/https-authorized-certs-with-node-js-315e548354a2


Extract durations from the trained model

Hi, I tried to train this model/repo on AWS, and on the third step (Extract durations from the trained model - creates alignments.txt file in the LJSpeech-1.1 folder) I got this error. May you help me, please?
I used: AWS image Deep Learning AMI (Ubuntu 18.04) Version 36.0
ubuntu@ip-172-31-68-24:~/speedyspeech$ python code/extract_durations.py logs/2020-11-17T10-20-06-/events.out.tfevents.1605608406.ip-172-31-68-24.3394.0 code/datasets/data/LJSpeech-1.1     --durations_filename my_durations.txt
Model sent to cuda
Traceback (most recent call last):
  File "code/extract_durations.py", line 161, in <module>
    m = DurationExtractor().load(args.checkpoint)
  File "/home/ubuntu/speedyspeech/code/duration_extractor.py", line 233, in load
    checkpoint = torch.load(checkpoint)
  File "/home/ubuntu/anaconda3/lib/python3.7/site-packages/torch/serialization.py", line 593, in load
    return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args)
  File "/home/ubuntu/anaconda3/lib/python3.7/site-packages/torch/serialization.py", line 763, in _legacy_load
    magic_number = pickle_module.load(f, **pickle_load_args)
_pickle.UnpicklingError: invalid load key, '\x18'.

Also, I had this error during installation requirement file, and I removed this line "pkg-resources==0.0.0"
ERROR: Could not find a version that satisfies the requirement pkg-resources==0.                                                      0.0 (from -r requirements.txt (line 34)) (from versions: none)
ERROR: No matching distribution found for pkg-resources==0.0.0 (from -r requirem                                                      ents.txt (line 34))

Also, I had this error during the installation requirement file, and I removed this line "pkg-resources==0.0.0"
Is it ok?
ERROR: Could not find a version that satisfies the requirement pkg-resources==0.0.0 (from -r requirements.txt (line 34)) (from versions: none)
ERROR: No matching distribution found for pkg-resources==0.0.0 (from -r requirements.txt (line 34))

SOLVED with:
 pip freeze | grep -v "pkg-resources" > requirements.txt

Hi, good catch with the requirements file bug. The pkg-resources is an ubuntu bug. I will remove the dependency soon.
Did you use your own data for your experiments? It seems like you are trying to load a file with nonstandard text encoding.

Hi, good catch with the requirements file bug. The pkg-resources is an ubuntu bug. I will remove the dependency soon.
Did you use your own data for your experiments? It seems like you are trying to load a file with nonstandard text encoding.

Thx for the response.
I used everything listed in the Training steps, from downloading LJSpeech-1.1 to this step where I had an error. I followed your repo instructions.

Is this your checkpoint for the duration predictor?: logs/2020-11-17T10-20-06-/events.out.tfevents.1605608406.ip-172-31-68-24.3394.0. What format is it? It seems like a tensorboard log and not like a model checkpoint

Is this your checkpoint for the duration predictor?: logs/2020-11-17T10-20-06-/events.out.tfevents.1605608406.ip-172-31-68-24.3394.0. What format is it? It seems like a tensorboard log and not like a model checkpoint

Yes, it is. I got it after I run a step before
python code/duration_extractor.py  with 5 epochs

I think the file you are using is a tensorboard log file. The checkpoints created by duration predictor have the following format:
{log_dir}/{time.strftime("%Y-%m-%d")}checkpoint_step{step}.pth'

For example logs/2020-11-17checkpoint_step1000.pth should be a valid checkpoint. Try to take a look if there is a *.pth file in your logs directory.
`
You can check for yourself in the code.

Unfortunately, I don't have that file with the extension .pth in my logs directory. I didn't change anything into your code. Do you know what could be a problem?

Ok this could be the problem. You trained the model for 5 epochs, right? First of all, this will definitely be not enough. Secondly, the chekcpointing happens every 10 epochs as can be seen here. So in your case, no checkpoint was saved. Train for the default number of epochs to get some results :). Let me know if this helps

Closing for inactivity. Feel free to re-open


Regression: Clicking sidebar items does not toggle properly on 1.54

VS Code Version:  1.54.0 (insiders)
OS Version: Windows 10

Steps to Reproduce:

Open a project (im using https://github.com/boa-dev/boa) with 1.54 and click on a folder in the side bar view
Clicking the side-chevron works ok , but anywhere else along that line only opens the folder on the 5th or 6th click
Open the same project with 1.53.1
Clicking anywhere along the line works

1.54:
It's hard to see in the gif but im clicking multiple times on the line

1.53

Does this issue occur when all extensions are disabled?: Yes

Probably caused by #115873. Next Insiders should switch the default for the new workbench.tree.expandMode setting so it works the same as 1.53 unless you explicitly set that to the other value. Meanwhile you can use the setting to reinstate 1.53 behaviour.
cc @joaomoreno


Split large lineages?

For example, there are some documented polymorphisms within B.1:
require(jsonlite)
lineages <- read_json("~/git/covizu/working/by_lineage.json")

temp <- lapply(lineages[["B.1"]], function(x) {
  sapply(x$diffs, function(y) paste(y, collapse="|"))
  })

foo <- table(unlist(temp))
foo <- sort(foo, decreasing=T)
> foo[1:10]

~|14407|T  ~|3036|T ~|23402|G   ~|240|T ~|25562|T  ~|1058|T ~|20267|G
    40083     39376     38809     38178     23189     18577      2824
~|15323|T  ~|2415|T ~|18876|T
     2572      2452      2114

Note Python indexing, so have to increment coordinates by 1.  25563T has been mentioned in a number of papers, as has been 1059T.

Note that the first four entries are the defining mutations for this lineage.
Also, the next two mutations are strongly linked:
> x <- sapply(temp, function(z) is.element("~|25562|T", z))
> y <- sapply(temp, function(z) is.element("~|1058|T", z))
> table(x,y)
       y
x       FALSE  TRUE
  FALSE 16671   547
  TRUE   5159 18030

This issue might be addressed by the latest Pangolin release:
https://github.com/cov-lineages/pangoLEARN/releases/tag/2020-11-30


Integrate Environment information to log messages

Current Implementation
Each log message contains the hostname of the worker node. Ops team also need the name of the environment (e.g. PROD, TEST, ...)
Suggested Enhancement
Add environments name to each log message
timestamp="2020...", host="hostabc", env="PROD"

At the moment we do not know the name of the environment variable, so this issue is on hold

Wont fix, due to low priority.


Socialite with Facebook expiresIn become null

Hello,
I noticed that if I use userFromToken() method from Socialite, the expiresIn become null, but have a value with user() method.
Trying with :
$user1 = Socialite::driver('facebook')->user();
$user2 = Socialite::driver('facebook')->userFromToken($user1->token);
dd($user1->expiresIn, $user2->expiresIn);

Will show 5162187 and null. ( the code is an example and has no interest in production ^^ )
It's the only difference between $user1 and $user2.
Is it normal ? Or does it mean that with the second method, the token has no expiration ?
Thanks !
Versions : Laravel 5.6.17 and Socialite 3.0.9

Wrong repo 🙂

Since it is impossible to add an issue in https://github.com/laravel/socialite
I thought it was the good place, any idea ?

Yeah, for general questions and support go here:

https://laracasts.com/discuss
https://laravel.io/forum


Stop decoding HTML entities when serializing HTML

Wes helped get an option to stop decoding HTML entities merged into parse5, so we can either wait for the impending release or install the specific version from git.

Why do you think the parser needs updated? What's your test case for that?


Is it possible to visualize any hyperparameter optimization run as a "sweep"?[Q]

I'm looking into w&b but already use optuna as my go-to hyperparam optimization library.
Is it possible to log an optuna (or any other library for that matter) search run as a sweep?

Hey @jonzarecki , you want to collect runs made with optuna under a single sweep, without actually creating runs with the wandb sweep, is that right?
If that's the case, then you could do something like this:

Log the runs as usual, just add a tag, or a group for them, so you could easily filter and select these runs later.
In the project page, you can create/seed a new sweep from these runs. Here's the documentation for more details.

Please let me know if that's not what you meant.

Yeah, seems like this is it.
Thanks! 👍


[license] Apply results of Apache Rat check

Also fix a few README formatting issues.
    mvn org.apache.rat:apache-rat-plugin:0.11:check -D rat.numUnapprovedLicenses=5000

This needs to be cherry-picked into 0.5.0 (see #456)

+1

+1


Added rotation feature to the lmeter

Pull request that follows https://github.com/littlevgl/lvgl/issues/1262
It adds a "rotation" feature to the line meter.
Should I also update some documentation? If so, where?

Looks good!
Only one minor thing. Can you change the word "rotation" to "angle". Just to use the same wording in the library.

Should I also update some documentation? If so, where?

Thanks, but I'll add it when v6.1 is released.

Thank you!


upgrade prometheus_client to 0.6.0

What does this PR do?
the upgrade to prometheus_client 0.6.0 breaks so many tests in https://github.com/DataDog/integrations-core/pull/3275 .
this current PR tries to investigate and adapt our code so we can upgrade prometheus_client from 0.3.0 to 0.6.0
More context:
The reason behind tests failure is this commit https://github.com/prometheus/client_python/commit/a4dd93bcc6a0422e10cfa585048d1813909c6786 it makes counter metric name not have _total internally. released since 0.4.0 https://github.com/prometheus/client_python/pull/300 , we rely on the function text_fd_to_metric_families (changed in 0.4.0) in our openmetrics logic which is used by multiple integrations
Motivation
same motivation as https://github.com/DataDog/integrations-core/pull/3275

Superseded by https://github.com/DataDog/integrations-core/pull/3443


test: test for empty dns/eve formats

Test that when dns/eve "formats" is empty, it uses the default of all.
Bug: https://redmine.openinfosecfoundation.org/issues/6420

Merged in #1448, thanks!


nuttx: Open mouse/touch/keyboard options can be configured

Open mouse/touch/keyboard options can be configured

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.liuhongchao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Not use preview, the aspect ratio of stream will be broken.

Describe the bug
Thanks for your excellent work.
I have some case where rtmp streaming breaks the aspect ratio and size using the sample RotationActivity.

Case 1: As in the pure sample code (see Screenshots case1)

The entire image is displayed with a black border and is displayed small.

Case2: surfaceView does not display Preview. (see Screenshots case2)

The aspect ratio seems to be broken.

Case3: Show Preview in surfaceView + use CameraHelper.getCameraOrientation for rotate in prepareVideo

Correct size and aspect ratio

To Reproduce
Verified environment

Commit: 784c86220e076e49944ae5a53136eca245b42317
Device: Pixel 7 (Android13)
Server: mediamtx (running windows 11)
Viewer: ffplay

Case1: (broken size..?)
1. checkout 784c86220e076e49944ae5a53136eca245b42317
2. build (e.g. ./gradlew assembleDebug)
3. click Rotation(include filters)
4. input stream url (e.g. rtmp://xxx.yyy.zzz.aaa:port/test)
5. see case1 (e.g. ffplay rtmp://localhost:port/test)

Case2: (broken aspect ratio)
1. checkout 784c86220e076e49944ae5a53136eca245b42317
2. comment out

* CameraFragment.kt

    // surfaceView.holder.addCallback(object: SurfaceHolder.Callback {
    //   override fun surfaceCreated(holder: SurfaceHolder) {
    //     if (!genericStream.isOnPreview) genericStream.startPreview(surfaceView)
    //   }
    //   override fun surfaceChanged(holder: SurfaceHolder, format: Int, width: Int, height: Int) {
    //     genericStream.getGlInterface().setPreviewResolution(width, height)
    //   }
    //   override fun surfaceDestroyed(holder: SurfaceHolder) {
    //     if (genericStream.isOnPreview) genericStream.stopPreview()
    //   }
    // })

3. build (e.g. ./gradlew assembleDebug)
4. click Rotation(include filters)
5. input stream url (e.g. rtmp://xxx.yyy.zzz.aaa:port/test)
6. see case2 (e.g. ffplay rtmp://localhost:port/test)

Case3: (No problem)
1. checkout 784c86220e076e49944ae5a53136eca245b42317
2. replace rotate.

* CameraFragment.kt

   private fun prepare() {
     val prepared = try {
-      genericStream.prepareVideo(width, height, vBitrate, rotation = rotation) &&
+      genericStream.prepareVideo(width, height, vBitrate, rotation = CameraHelper.getCameraOrientation(activity)) &&

3. build (e.g. ./gradlew assembleDebug)
4. click Rotation(include filters)
5. input stream url (e.g. rtmp://xxx.yyy.zzz.aaa:port/test)
6. see case3 (e.g. ffplay rtmp://localhost:port/test)

Expected behavior

Reproduce with RtmpCamera2 instead of GenericStream.
Does not reproduce with RtmpCamera2 of v2.2.7.
I think it occurred somewhere between v2.2.7 and v2.4.3.

Screenshots

Case 1: As in the pure sample code

Case2: surfaceView does not display Preview.

Case3: Show Preview in surfaceView + use CameraHelper.getCameraOrientation for rotate in prepareVideo

Smartphone (please complete the following information):

Library version [v2.4.3 or commit: 784c86220e076e49944ae5a53136eca245b42317]
Device: [Pixel 7]
OS: [Android13]
Media server [MediaMTX v1.2.0]
Class used [GenericStream or RtmpCamera2]

Additional context

Hello,
This should be fixed here:
https://github.com/pedroSG94/RootEncoder/commit/e716ae1a9be2cbe800a0e7911223a68e87678cab
I think tested all cases but let me know if I missed something. I will upload the next version with the fixes soon

Hello,
I immediately checked the operation and confirmed that there were no problems in case 1 and case 2.
In case 1, CameraFragment's private var rotation is 0 by default,
so, I think sample codes assume landscape orientation.
I think it would be easier to use the sample by determining whether it is portrait or landscape when initializing the Fragment and setting it as the initial value.
and In case2,
after rewriting private var rotation = 90,
I commented out surfaceView.holder.addCallback and confirmed that it was streamed by Fit.
Thank you for your quick response.

Hello,

I think it would be easier to use the sample by determining whether it is portrait or landscape when initializing the Fragment and setting it as the initial value.

Yes, this is an option but I think it is more confuse because the user can open in landscape, rotate to portrait and then start stream. The orientation will be horizontal in this case but If I open in Portrait and start stream the orientation is vertical and this could be confuse to understand.
I did it always horizontal and you can change it in the menu to vertical, this way it is easy to understand that you will stream horizontal until you change it in the menu.
I will keep the current way for this reason.
The error seem fixed. I will close the issue as completed but you can reopen it if you need or open other issue.
Thank you for the report


git reflog would benefit from including the branch names on entries

Take the current output of git reflog:

Notice that some of the reflog entries show branches that they are on. This would be beneficial to pass through in ugit, both as a property on the reflog entries, as well as formatted to show similar to native git.

Note: The coloring shown here is some done by WindTerm, and some by git itself. I think the colors are helpful, but not needed as part of an initial implementation.

@corbob this one will be a good bit trickier than the others (surprisingly)
git reflog maps down to
git log -g --abbrev-commit --pretty=oneline
Which comes back with branch information when pretty-printed, but not when assigned to a string.
This will take some more digging.

Which comes back with branch information when pretty-printed, but not when assigned to a string.

That's caused by the implicit --decorate=auto argument. Log.Decorate
Working args
note: I'm using git.exe so that I don't have to unload ugit. Select-Object and assigning to string were both triggering auto, so I used both in some areas.
$color = @('--color=always', '--decorate=full')
git.exe log -g @color --abbrev-commit --pretty=oneline | select -first 10
git.exe reflog @color | select -first 10

reproduction
# full color invoke
git.exe log --color=always --decorate=auto --abbrev-commit --oneline | select -first 10

# now only partial color, the hash, is preserved
git.exe log --color=always --decorate=auto --abbrev-commit --oneline

( [string[]]$render = ... ) | select -first 10


Diana's Solution

completeness: 5
comfort: 3
It took me a while to understand what exactly I needed for some of the functions, but it got easier once it started to come together

:+1:


Resolve promise when canceled.

Using it in a try catch block causes code clutter.

Can you update README too? Thanks!

very nice & important feature! thanks @kadirgun. will it be merged soon @wobsoriano?


Update Composer dependencies (2021-01-27-00-09)

Visual regression test passed!
View the visual regression test report

Visual regression test passed!
View the visual regression test report


Update Document for Deployment of CockroachDB

while Deploying CockroachDB with OpenEBS struck in the following step
Testing your Database Using the built-in SQL Client
Where should run the following Basic CockroachDB SQL statements
> CREATE DATABASE bank;

> CREATE TABLE bank.accounts (id INT PRIMARY KEY, balance DECIMAL);

> INSERT INTO bank.accounts VALUES (1, 1000.50);

> SELECT * FROM bank.accounts;

The document asks to launch an interactive cockroachdb instance & invoke the sql client (sql --insecure)
Using the built-in SQL Client
Launch a temporary interactive pod and start the built-in SQL client inside it:
ubuntu@kubemaster:~kubectl run cockroachdb -it --image=cockroachdb/cockroach --rm --restart=Never -- sql --insecure --host=cockroachdb-public
Run some basic CockroachDB SQL statements:
> CREATE DATABASE bank;

> CREATE TABLE bank.accounts (id INT PRIMARY KEY, balance DECIMAL);

> INSERT INTO bank.accounts VALUES (1, 1000.50);

> SELECT * FROM bank.accounts;

+----+---------+
| id | balance |
+----+---------+
|  1 |  1000.5 |
+----+---------+
(1 row)
Exit the SQL shell:
>\q

This doesn't need any update IMO. Please let us know if you feel otherwise.


Height of adapter items not correct

Library Version v1.1.8
Affected Device(s) Redmi Note 5 Pro with Android 9.0

Describe the Bug:
The wrap_content of app:spinner_popup_height doesn't work properly when the item count of the list is changed. It takes the height of the smallest last used item list.
When there is a list of let's say 5 items, all the 5 items are displayed properly and then I update the list and also set the powerspinner and adpter agin and then the list has 10 items, only 5 items are shown while rest 5 are scrollable. Even in it the scroll bars are not visible.
Expected Behavior:
The wrap_content of the app:spinner_popup_height should change according to the size of the list and not the size of the previous smallest list.

In my case, one of the item's text was a little long, it appeared in one line in the item, but when you choose it, it appeared in 2 lines in the spinner display.
Then again you click on the spinner, the text flows out of the popup.
Deal breaker for me.

@shivamsoods @ubarua123 any solution for this?

#92


[WIP] Feature/buisness type database changes

SUMMARY

Our users are leveraging Superset to explore and visualize network security logs. These logs often contain IP, port, hostname, and/or protocol fields, among others. While such fields might be stored as simple INTEGERS or VARCHARS in the backend database, these fields also have a “business” type which, if leveraged, can provide additional context and improve the user experience.
The following code changes are the first steps towards adding these types currently they are simply added text fields
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Closing in favor of #18794


Shaped 2.2.13 - merge conflicts resolved

FYI in case anyone else comes across the same issue: the merge issue was due patreon being added to the sheet.json

Thanks for fixing the merge conflict for me!

When you merged it deleted your sheet.json instructions. I went ahead and added them back from a previous commit.

Hey Phil, it was purposeful that the old change log was removed.

Oh, okay. Then it just needs "instructions": "". The json was breaking because it was "instructions": , . I'll go ahead and remove the text though.

Oh, I think there was a misunderstanding. I wasn't talking about the change log, I was talking about the "instructions" property in the sheet.json. After the last commit it was:
"instructions": ,
which is not a proper JSON. Did you mean to delete the text from there, or was that a mistake?

My mistake. It should read: "This sheet is designed for use with D&D 5th edition. It has been designed to match the layout of the D&D 5e Character Sheet."
So without the wiki link.
Thanks! Sorry for the trouble.

That's what I thought, and have changed it to, and it's no trouble at all. It was right around where I'm assuming the merge conflict was (because I added the patreon link), so I figure that was the cause. Everything should be correct now. Thanks for all your work on this sheet.

Thanks again Phil


adding voice control for whatsapp

This would be a added feature in WhatsApp bot Where in the user could speak up the message which is to be sent to the target.

Please provide details on what you are planning to work /improve

Done.
Kindly have a look

Done with description
Kindly have a look

Done with description.
Kindly have a look

Please issue a PR

Okay will do that

Done the task #47

PLease add a readme file to explain the code and how to use it thanks . Please leave a like :)

The usage is same as already mentioned in README Just it has additional requirements which I have already attached and Yeah I will add its functionality into README
Thank you

Awesome

Done the required stuff. Have a look and kindly suggest changes if any.
Thank you

waiting for the bot to scan it .fix issues if any

Okay

The program is working fine in my machine so I guess no issues.

Awesome . Will review once I get some time

Sure.
By that time can you add a Hacktoberfest accepted label on the PR if you feel its legit

Sure, No hurry
Thank you


Refer to updated lib by crigges

Add this link to the readme please.
https://github.com/Crigges/JMPQ-v3

You want to add a "Credits" section to the Readme file? Just do it :)

huh? No, I just think that v3 should be used instead because it fixes a few issues with this version, or am I wrong? this repo is linked in a few threads and also comes at the top of google results.
Just an idea


feat: draft autowidget

Related to #28
Experiment with AutoWidget helper to make writing widgets for parameters a bit easier.
The AutoWidget class creates a composite widget from a constructor and a range of argument widgets.
The resulting widget is a simple form that produces a value of the constructor type.

Not sure how far we can get with this approach or a similar one, but to avoid having to create lots of very similar widgets for different workflow parameters it would be nice to automate what we can

but to avoid having to create lots of very similar widgets for different workflow parameters

Can you clarify your concern? I didn't think there would be too many different widgets.

There's some bookkeeping involved in making a widget that creates a composite value from a number of underlying basic widgets. It's good if we can avoid repeating it unnecessarily.
In particular, the AutoWidget let's you observe the composite value, and it's updated when any of the underlying values change. That didn't happen in the old widget implementations. That makes it easier to compose widgets together.
There are other ways to achieve that, not sure if this is the best, but I found it to work quite well so far.

There's some bookkeeping involved in making a widget that creates a composite value from a number of underlying basic widgets. It's good if we can avoid repeating it unnecessarily.
In particular, the AutoWidget let's you observe the composite value, and it's updated when any of the underlying values change. That didn't happen in the old widget implementations. That makes it easier to compose widgets together.
There are other ways to achieve that, not sure if this is the best, but I found it to work quite well so far.

I didn't think there would be too many different widgets.

Not necessarily too many, I agree. I thought there would be more than there seems to be. It might be easier to just keep the widget implementations separate

If I understood correctly during the standup we will not pursue this for now, may be revisited later?


⚠ SolarIn has degraded performance

In 5ac6166, SolarIn ($SOLARIN_URL) experienced degraded performance:

HTTP code: 200
Response time: 1152 ms

Resolved: SolarIn performance has improved in 8f846b2 after 14 minutes.


Add 'move' event doc in ScriptComponent.

There is no description of 'move' event at API Reference.
So add 'move' event doc in ScriptComponent.

Hey @daredevildave and @vkalpias - was this ever intended to be a public event? Is there a valid use case for regular devs?

FYI
ScriptComponent move method is public.
https://developer.playcanvas.com/en/api/pc.ScriptComponent.html#move


fix deserialize of int types

Remove the type matching object and fix one memory leak
Add support for different int types
I also add support for null objects and beefy fixed a bug for setting nulls.
https://github.com/beefytech/Beef/issues/376
I removed the type matching because maybe you don't need every filed in a JSON object or vice versa

Can you elaborate on the removal of the AreTypeMatching and AreBaseTypeMatching methods call ? What those methods do is checking that every public field of an object are inside the json string that is parsed. So if a json object has more key/values than the object it tries to deserialize into those extra key/values would not be seen by those methods since the check is performed against the object's fields.
If however you want a specific field to be ignored by the serialization and deserialization process, you can annotate it with the [IgnoreSerialize]
For the support of different integer types, the JSONObject class only works with int so when you use the add method with bigger types or positive only types, loss of information may occur. The way I see it there's no way to differentiate a float from an int in json. "1" could very well be extracted as an int or float and it is to the discretion of the implementation to decide the behavior.
You can also see in the branch issue-4-deserialize-primitive-type some fixes for the deserialization of primitive types as well as fixes of memory leaks and string allocations.

Maybe for number types, we have to keep them as String and then parse them in deserialize process based on user types.

Yeah and we could also extend keeping all the values as string (except for objects and arrays). This would allow the removal of the JSON_LITERAL type as well (I was not really fond of this solution when I wrote it).
But it would also mean that we need to convert every primitive types into string when adding them to JSONObject or JSONArray. I can begin working toward that implementation.
In the meantime, I can merge your PR, but there will be an issue where if you provide a json which has less field than the object you are trying to deserialize into, the deserialize process will return an error, because the underlying JSONObject doesn't contains the key related to your field.
Then I can look at the new proposed implementation inside the issue-4-deserialize-primitive-type branch.

I have implemented all the changes we discussed in the issue-4-deserialize-primitive-type branch. I have yet to test for all the primitive types and there are some cases where the behavior related to the loss of information (e.g: trying to deserialize a value bigger than the target type) might be different than normal casting. This is due to how I found out how to casting via reflection. The way I do it might not be the best.
In any case, it should now be able to handle most of the use cases. If you want to try on your side, feel free to do it.
P.S.: There are still memory leaks due to the allocation of strings when setting field's that are String. I'm working on it as well.


Remove uncalled bets from the pot

Right now when a player bets, it is added to the pot immediately. If all players fold, the winning player gets their bet back in the pot, but the player wins $x message is misleading, since the amount they won should not include the uncalled bet. E.g.,

Is this really bad?
I think pokerstars (and other big, for real-money pokersites) does this as well.


cut a new release?

many features/code has been merged into master, any plan to cut a new release?

See #329.


Unexpected assignments before expected in runtime.

In order to ensure unexpected assignments are processed correctly, they need to come before the expected required ones.

Change was checked-in.


Fix typo and change import order

Changes

In my last PR, @vdemeester commented that I should move the corev1 import to the bottom of the import list to match the current convention. The PR was merged before I could make that change, though. This addresses that, and also corrects a minor typo I thought I would include. Thanks!
These are the criteria that every PR should meet, please check them off as you
review them:

[x] Includes tests (if functionality changed/added)
[x] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

See the contribution guide
for more details.
Release Notes

/lgtm


refactor: Misc tidyup of SMS implementation

This PR improves test coverage of the SMS API and deprecates classes intended for removal.

Codecov Report

Merging #513 (a4c6e5a) into main (730a1a4) will increase coverage by 0.53%.
The diff coverage is 96.55%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #513      +/-   ##
============================================
+ Coverage     95.29%   95.82%   +0.53%
- Complexity     2933     2955      +22
============================================
  Files           428      428
  Lines          6976     6977       +1
  Branches        403      403
============================================
+ Hits           6648     6686      +38
+ Misses          198      165      -33
+ Partials        130      126       -4

Files
Coverage Δ

...m/vonage/client/auth/hashutils/AbstractHasher.java
83.33% <ø> (ø)

...om/vonage/client/auth/hashutils/HmacMd5Hasher.java
85.71% <ø> (ø)

...m/vonage/client/auth/hashutils/HmacSha1Hasher.java
85.71% <ø> (ø)

...vonage/client/auth/hashutils/HmacSha256Hasher.java
85.71% <ø> (ø)

...vonage/client/auth/hashutils/HmacSha512Hasher.java
85.71% <ø> (ø)

...va/com/vonage/client/auth/hashutils/Md5Hasher.java
100.00% <ø> (ø)

...n/java/com/vonage/client/incoming/NotifyEvent.java
100.00% <ø> (ø)

src/main/java/com/vonage/client/sms/HexUtil.java
91.89% <100.00%> (-2.71%)
:arrow_down:

...main/java/com/vonage/client/sms/MessageStatus.java
100.00% <ø> (ø)

...a/com/vonage/client/sms/SmsSubmissionResponse.java
100.00% <100.00%> (ø)

... and 7 more


Unable to load locally located adapter

The code makes a forced call to HF.
        if SUPPORTS_LLAMA32:
            # New transformers need to check manually.
            files = HfFileSystem(token = token).glob(os.path.join(model_name, "*.json"))
            files = (os.path.split(x)[-1] for x in files)
            if sum(x == "adapter_config.json" or x == "config.json" for x in files) >= 2:
                both_exist = True
            pass
        pass

If the adapter is not in the HF repository, this will result in an error.

@yurkoff-mv Did you update Unsloth to the latest version?
https://github.com/unslothai/unsloth/commit/79a2112ca4a775ce0b3cb75f5074136cb54ea6df

Updated, saw the changes, everything worked!
Thank you very much!


Push state strategy

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

21 of 33 (63.64%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-6.4%) to 88.699%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/notification-center/micro-lc-notification-center.lib.ts
6
18
33.33%

Totals

Change from base Build<PHONE_NUMBER>:
-6.4%

Covered Lines:
196

Relevant Lines:
212

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

21 of 33 (63.64%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-6.4%) to 88.699%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/notification-center/micro-lc-notification-center.lib.ts
6
18
33.33%

Totals

Change from base Build<PHONE_NUMBER>:
-6.4%

Covered Lines:
196

Relevant Lines:
212

💛  - Coveralls


1.01 a11y

Thanks for contributing to react-virtualized!
Before submitting a pull request, please complete the following checklist:

[ ] The existing test suites (npm test) all pass
[ ] For any new features or bug fixes, both positive and negative test cases have been added
[ ] For any new features, documentation has been added
[ ] For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
[ ] Format your code with prettier (yarn run prettier).
[ ] Run the Flow typechecks (yarn run typecheck).

Here is a short checklist of additional things to keep in mind before submitting:

Please make sure your pull request description makes it very clear what you're trying to accomplish. If it's a bug fix, please also provide a failing test case (if possible). In either case, please add additional unit test coverage for your changes. :)
Be sure you have notifications setup so that you'll see my code review responses. (I may ask you to make some adjustments before merging.)

hi! can you document what changes you are trying to make?
and also please revert the changes to .gitignore

@wuweiweiwu I think this is related to https://github.com/bvaughn/react-virtualized/issues/1604

@wuweiweiwu I think this change is related to https://github.com/bvaughn/react-virtualized/issues/1604 where we're looking for more customization in the role prop for the Table component. Maybe @adirhaz1z can confirm?


Lag whilst using a VPN

Whilst I'm connected to a VPN the main feed as well as individual comments take much longer to load, despite them loading instantly if I browse using the website or Hacki instead.
https://news.ycombinator.com/item?id=31549238 this page for instance took 10 seconds to load all the comments, during which time the comments can't be browsed at all, in contrast to instant loading on the two aforementioned alternatives.

Hmm. The Hacker News API works by individually requesting every item. This introduces a lot of parallel requests. If I had to guess, I'd say not all VPNs appreciate this many simultaneous requests. Some requests taking longer than others is mostly fine for the main page, but comment threads can be an issue because comments are only rendered if all of the comments above them have been retrieved. This can create a bottleneck where almost the entire page is waiting for a delayed comment request at the top of the page.
If this is indeed the problem, I'd need to reconsider the current tree traversal implementation.

I'm interested in hearing if there's any significant difference in the just released version v1.18.1. Loading the comment tree still occurs by requesting individual items, but two changes might influence the results:

Comments can be rendered out-of-order. So one slow request should not hold up the rest.
A maximum of 8 parallel requests are executed to retrieve the comment tree. This value works well for me, but is not set in stone and could be adjusted if it benefits users.

Thanks, will check it out when it's available on F-Droid.

Closing this because there have not been recent reports stating that this is a current issue.


bump(root|sdk|examples): upgrade dependencies

Changes

Upgrade dependencies
Fix the code styling of the examples
Fix Spore/Cluster codec relevant types and tests

Lumos has just released a new version, v0.21.1, which addresses an issue where users were unable to send transactions in browser environments. The Spore SDK was not using an affected version, so our previous releases remain fine. However, as a precautionary measure, I have also upgraded Lumos in this pull request to prevent the issue.


Log Cc and Bcc addresses when pretending to mail

Log Cc and Bcc addresses when pretending to mail.
'Pretending' to send mail messages now accurately logs the actual behaviour of a sent message.
Use case: Where the behaviour of emails is examined through logging and
where one is interested in the Cc and Bcc recipients.

Mail "pretend" is deprecated as of 5.1 and has been removed in 5.2. For this reason, we're not accepting changes to it. It's been replaced by the log driver, since 4.2.


Upgrade pkg library to 0.0.7

Description of changes:
Upgrade the pkg library for the code generator from 0.0.6 to 0.0.7
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/retest


How to make one not display as prime

One displays as prime.

this only happens with very small numbers


ember deploy  never creates new revision after the first one

I have the latest ember-cli-deploy (0.4.1)
First time I run "ember deploy"  everything works, revision is created .. all fine.
When I run  "ember deploy" again  everything works, assets are sent, new index file is put on redis, but there is never a new revision number, just an "Upload failed!" message when "Trying to upload dist/index.html...
Oddly, the new index.html actually uploaded ( put into the redis key for the first ( and only revision ) ) .. so technically everything works, except that I am always publishing live every time, since there is never a new revision created.
Puzzling.
Anyone else get this behavior?

Interesting.
I was digging into the source, and it looks like the new revision is based on the latest git revision ..
ok .. that makes sense ..


ftdidb_lock while trying to remotely connect to hw_server

I followed the instructions and it appears I can connect to the pi from a remote XSDB section. The session connects without reporting any error. However, when I try to list targets to a known working Xilinx eval board I get the following error:
ftdidb_lock failed: FTDMGR wasnt properly initialized
I get the same message with a digilent HS3 usb jtag adapter and a Xilinx Platform 2 USB cable. I will experiment and see if I can get it working. I'm using a Raspberry pi model 3B+ on buster 64 bit, kernel 5.15.32-v8+
To reproduce -
xsct
connect -url <piaddress>:3121
targets
ftdidb_lock failed: FTDMGR wasnt properly initialized

Quick aside this may be missing from the instructions as well otherwise the docker containers won't start in usermode
sudo chmod 666 /var/run/docker.sock

For the root access, I had other issues following the instructions from docker, but that's probably due to my limited docker experience, we can table that one for now.
However, I did have better success using the 2020.1 version after a few tries. I think it came down to a version mismatch. I was trying to connect from a 2020.2 xsct session to the 2021 docker container. After downgrading to the prepackaged 2020.1, I was able to download a bitstream and even get a litex UART output!!!! This is amazing! Good bye smart lynq!

I did try a few other things in between however, one thing was including the udev rule from digilent for the hs3 and I don't know if that made a difference or not. I will have to package up my own following more instructions and get this auto starting on the pi. WooHOO!

Good to hear that it works for you now :) I will close the issue then.


fix the wrapping directive causing some tests to fail

Description
fix the wrapping directive error currently in a few of the tests

Calling Error() is unnecessary. Fmt is smart enough to call it inside.


Policy on ES7 (such as async)?

We are currently using babel's fork of acorn just to have async support. I'd much prefer to use official acorn if possible. Was curious if adding async is a possibility (guarded by ecmaVersion: 7 or some other option)?

It's totally possible. I believe the best would be to implement those things as plugins for now until syntax is more shaped, and then bring those plugins into the core. Given that they are already implemented in Babel's fork, it should be pretty easy to extract them outside.

Although as far as I see, async advanced to stage 2, so I think we can implement it here.

The Bable implementation of async functions uses a lookahead. In order to properly abstract the lookahead the entire parser was abstracted out into a separate state that can be rolled back. The changes involved in doing so were quite intrusive so you will be unable to exact it without a lot of hassle.

I'd continue using babel's parser, but it was from the start littered with "not meant for public use" warnings, and now seems to be completely unreachable as a separate package (ever since the move to have a custom parser?)

@tolmasky https://github.com/babel/babel/tree/master/packages/babylon

@sebmck a bit off topic for this bug so apologies, but should I treat babylon as public (unlike acorn-babel), and will it support util/walk like acorn-babel did, or should I be looking for a different way to traverse

@tolmasky Yeah off-topic for this issue tracker, feel free to ask on the Babel Slack though. Thanks!

+1 - is async/await support on anyone's todo list, or should I have a hack myself?

Not on current TODO, but you can totally send PRs.

I've added the key bits as a plugin at https://github.com/MatAtBread/nodent/blob/acorn/parser.js
The parser is NOT compliant with ESTree's spec - it requires some additional transforms to (in particular) add the .async property to FunctionDeclaration and FunctionExpression, and 'await' is currently a UnaryExpression with the operator set to 'await'. However, implementing the parse in this way, followed by a tree-walk that patches up the tree to be ESTree compliant wouldn't be a big job.
For my project, given the ESTree stuff is 'experimental' the internal representation of async (an operator for FunctionDeclaration/FunctionExpression, but .async for async member functions) and await is sufficient. The fact that I can plug them in at all to acorn is great :)
FYI, the project itself is moving from UglifyJS to acorn, and it implements async & await using syntax transformation (as well as generators) as it executes much faster

Finally published this cleanly: https://github.com/MatAtBread/acorn-es7-plugin

@matAtWork Did you handle async (x,y) => x + y vs var res = async(x, y); ?

Not really..., on the basis that if you set ecmaVersion to 7 the latter is no longer valid as 'async' is a keyword, so no identifier should be called 'async' in exactly the same way as 'typeof' or 'delete' as local identifiers are problematic. References such as var res = obj.async(x,y) should be fine tho.
The implementation is a bit simplistic (it pretends 'async' and 'await' are both unary prefix operators before patching up the tree), but I needed it to work quickly. Happy to have a PR if I don't get around to fixing it in time :)

..actually, looking at it, the fix is probably not too hard, it parses as 'UnaryExpression  (SequenceExpression)' and I can patch up the in the same way as I do for the other cases. I'll take a look later and re-publish

....nah, too simple. I'll give it some thought!

@matAtWork yep, it's not simple at all :)
yield is similar to the situation of await, and it is not fixed yet (see #227). I just fixed let as an identifier (#317), and, for the lack of better words, is a pain in the butt. Supporting yield doesn't look any simpler than let.

Esprima and Shift had to use a flag in the main parser state object to know whether yield is allowed in this specific context or not. await can probably be processed the same way.

Actually, I can get them all to work reasonably easily, except for the first case(!)
q = async();    // FAIL!!
q = async () => x+1;
q = async(x);
q = async (x) => x+1;
q = async(x,y);
q = async (x,y) => x+y;

I've not posted the fix for the other cases, but as long as there's a space between the async and arrow function the others work OK. I'll have another go at it when my wife and kids stop asking what's for supper

Well, space is definitely insignificant. That's why @sebmck's babylon used look-ahead for implementing this and other features :)

@matAtWork have you tried these :)
var async = 0
let async
async = 0
for (async in obj) {}
var b = async => console.log(async)
function async () {}

I believe they are all valid expressions under the async function draft.

I'm surprised that the use of a keyword/reserved word as an identifier is permitted (which seems to be the source of most of these ambiguities), but given the prevalence of the async(!) library, it makes some sense. Do you know why it's permitted for async but not typedef, function or while? Right now, the plugin will fail on most of these - both 'async' and 'await' are treated as keywords and so can't be identifiers.
The current implementation is simplistic - I had a need to meet and found a short-cut to doing it without getting too deep into the tokenizer. Guess I'll have to find the time to tighten it up a bit. The good news is it works pretty well if you don't have identifiers called async or await

They're called contextual keywords and are used commonly enough as identifiers that you can't make them keywords without breaking the web.
On Fri, Oct 2, 2015 at 10:49 PM, Matt W<EMAIL_ADDRESS>wrote:

I'm surprised that the use of a keyword/reserved word as an identifier is permitted (which seems to be the source of most of these ambiguities), but given the prevalence of the async(!) library, it makes some sense. Do you know why it's permitted for async but not typedef, function or while? Right now, the plugin will fail on most of these - both 'async' and 'await' are treated as keywords and so can't be identifiers.
The current implementation is simplistic - I had a need to meet and found a short-cut to doing it without getting too deep into the tokenizer. Guess I'll have to find the time to tighten it up a bit. The good news is it works pretty well if you don't have identifiers called async or await
Reply to this email directly or view it on GitHub:
https://github.com/marijnh/acorn/issues/309#issuecomment-145163064

Yeah.....I'm trying to go through the details of http://tc39.github.io/ecmascript-asyncawait/#sec-modified-abstract-ops now. Definitely on the edge of my comfort zone. I appreciate the feedback tho! Do I get from TimothyGu earlier than esprima have solved this already?

@matAtWork, they solved the problem of yield, which has similar semantics as await.

Also I would focus more on https://tc39.github.io/ecmascript-asyncawait/#modified-productions, which contains context-free grammar applicable to a parser like acorn.

I'm guessing my current approach won't work - I can improve compliance of some simple cases, but in general it won't work (since an Identifier can appear legitimately in many places), and I'll need to dig into the code at a lower level than the plugins seem to permit......so for now I'll treat it as ES6.9 (7.0 - identifiers async & await). I'll update the README with the extra restriction and hopefully it'll work for some people.

Ok, so I have pretty much got both async and await working as contextual keywords, but have one remaining issue which appears to be a 'spec' issue: how do I await on an async function returned by await?
// Return an async function asynchronously
async function x(n) {
	return async function xxx(m) { return n+m }
}

async function test() {
	var r = await x("a") ;
	console.log(r) ;	    // [Function: xxx] - correct
	console.log(await r("b")) ;	// "ab" - correct
	console.log(await (await x("c"))("d")) ;	// [ReferenceError: await is not defined] - fail! await() looks like a call
	console.log(await await x("e")("f")) ;	// Fail! x("e")("f") binds to second await and fails (not a Promise)
}

test().then(console.log.bind(console),console.error.bind(console)) ;

cc @bterlson

Asked and answered at https://github.com/tc39/ecmascript-asyncawait/issues/67. Thanks to @sebmck and @bterlson

For those following this thread, I've implemented the contextualisation of async and await and pushed to https://github.com/MatAtBread/acorn-es7-plugin. It works correctly with all the examples @TimothyGu posted earlier and bunch of other cases I came up with. Feedback appreciated.

There's no line terminator allowed after async:
async
function foo() {}

is just an ExpressionStatement followed by a FunctionDeclaration. You also naively assume that a function expression inside of an expression statement is a function declaration. This is not always the case:
(async function foo() {}); // i am an expression not a declaration

You also allow a function declaration without a binding identifier:
async function () {}

And due to the incorrect expression -> declaration parsing the following valid syntax is disallowed:
async function foo () {}
(foo)

You wont be able to get the correct grammar with just overloading Acorn methods via a plugin and you're going to need to use a lookahead.

I know you probably think I'm crazy doing this in a plugin, but I'm learning useful stuff and enjoying it - so thanks for the input.

Hopefully it's much closer to the spec now, and as well as being useful to me, it might be of use to other people playing with ES7 and Acorn.
If you find any more, let me know.

BTW, it is using lookahead - it creates a subParser from the passed parser and extends raise() to check if the source after the 'async' is an expression without consuming it in the 'main' parser. There's a couple of cheesy regexps as well to see if a statement begins with 'async' without entering the expression parser.


Is support of BLAS in scope?

In my ideal world, there would be a BLAS  package that can run in Web Assembly in browsers, so that interacting with special data types is encapsulated and as a programmer I can just use BLAS level 2 and 3 and know the that the optimal performance of the machine will happen.
Is that in scope of this project group? If not, what would be required for that and which parts are in scope of this project group and which are outside of its scope?

The simd methods provided will likely cover about as much as f32/f64 cover in terms of trig and utilities. Additional content would probably be better suited for an external crate built on top of core::simd.

I think it would be a good idea to keep BLAS explicitly out of scope.

(To be clear, I think you should be able to build competitive BLAS using these components, but this should probably be focused on being smaller)


Will the error catched in handleRedirectPromise method contain user privacy data?

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.14.2
Wrapper Library
Not Applicable
Wrapper Library Version
None
Description
Since we have a requirement to log all error info into our telemetry for debugging. I searched the web, I cannot find clearly explanations what kind of error will be throw from handleRedirectPromise. If the error contains customer user privacy data, we're not allowed to log it into our telemetry.
I did some investigation. I am wondering if the error catched in handleRedirectPromise just the errors defined in BrowserAuthErrorMessage, the list like below:

Really appreciated for your help~
MSAL Configuration
No response
Relevant Code Snippets
No response
Identity Provider
Azure AD / MSA
Source
Internal (Microsoft)

Hi @Chun817, Yes the errors thrown for handleRedirectPromise are only the errors in BrowserAuthErrorMessage that pertain to the flow.

Hi @Chun817, Yes the errors thrown for handleRedirectPromise are only the errors in BrowserAuthErrorMessage that pertain to the flow.

Thanks for your response. Will the errors in BrowserAuthErrorMessage contains any customer privacy data? like user id, client id and etc.

Will the errors in BrowserAuthErrorMessage contains any customer privacy data? like user id, client id and etc.

No, customer privacy data like user id, client id and the like are not included in the errors.


feat: ngrx 8 refactor

What:

Issue number: https://github.com/tomastrajan/angular-ngrx-material-starter/issues/472
Integrated the new features of Ngrx 7 into the examples folder. Effects, reducers as well as actions were refactored to accommodate for the new changes.

Codecov Report

Merging #477 into master will decrease coverage by 0.46%.
The diff coverage is 89.74%.

@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
- Coverage   73.43%   72.96%   -0.47%
==========================================
  Files          64       64
  Lines         576      566      -10
  Branches       42       36       -6
==========================================
- Hits          423      413      -10
  Misses        143      143
  Partials       10       10

Impacted Files
Coverage Δ

...eatures/examples/crud/components/crud.component.ts
32.14% <0%> (ø)
:arrow_up:

...er/src/app/features/examples/crud/books.actions.ts
100% <100%> (ø)
:arrow_up:

...ter/src/app/features/examples/form/form.reducer.ts
100% <100%> (ø)
:arrow_up:

...er/src/app/features/examples/crud/books.effects.ts
100% <100%> (ø)
:arrow_up:

...ures/examples/stock-market/stock-market.reducer.ts
100% <100%> (ø)
:arrow_up:

...ket/components/stock-market-container.component.ts
100% <100%> (ø)
:arrow_up:

...er/src/app/features/examples/crud/books.reducer.ts
100% <100%> (ø)
:arrow_up:

...ures/examples/stock-market/stock-market.actions.ts
100% <100%> (ø)
:arrow_up:

...ter/src/app/features/examples/form/form.effects.ts
100% <100%> (ø)
:arrow_up:

...ter/src/app/features/examples/form/form.actions.ts
100% <100%> (ø)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5edcb3...54272f8. Read the comment docs.

Wow ! Thanks for epic PR @abedzantout  !