node.isExpanded state might not be correct just after firing treeModel.collapseAll()

Hi @adamkleingit ,
I found this issue with following steps:
Step 1. Make sure all the tree nodes expanded
Step 2. In a component method

call treeModel.collapseAll() to collapse all the nodes
for a certain node path, which is more than 2 level deeper, check the node state, I found the node state in the first two levels are correct, but those in deeper levels will still be in expanded state.

code snippet:
      tree.treeModel.collapseAll();

      focusedNode.path.forEach( (id) => {
        let node = tree.treeModel.getNodeById(id);
        if (node) {
          console.log(node.isExpanded);
          node.expand();
        } else {
          console.log("no node found!");
        }

My dev environment:
@angular/cli: 1.3.2
node: 6.10.2
os: darwin x64
@angular/animations: 4.3.6
@angular/cdk: 2.0.0-beta.8
@angular/common: 4.3.6
@angular/compiler: 4.3.6
@angular/core: 4.3.6
@angular/forms: 4.3.6

@angular/http: 4.3.6
@angular/material: 2.0.0-beta.8
@angular/platform-browser: 4.3.6
@angular/platform-browser-dynamic: 4.3.6
@angular/router: 4.3.6
@angular/cli: 1.3.2
@angular/compiler-cli: 4.3.6
@angular/language-service: 4.3.6

and I am using Chrome.

My temporary solution is:
      setTimeout(()=> node.expand(), 100);

Hi,
I couldn't reproduce. Can you reproduce here and reopen:
https://plnkr.co/edit/u5fMmaM14rJ0aqG3k240?p=preview


Change RSA key input to file upload

This pull request changes the RSA key input into a file upload.  I'm not sure I'm doing things the proper way, so any feedback is appreciated!

@dclarizio @martinpovolny @h-kataria Please review.

@tzumainn  Please rebase.
@dclarizio @martinpovolny @h-kataria Please review.

@tzumainn Please rebase.
@dclarizio @martinpovolny @h-kataria Please review.

rebased

@tzumainn Can we have someone with access to valid creds for a RHOS system verify your branch, perhaps @Ladas?  Also, could you please add some before and after screen shots to the initial comment, that will help us understand the changes and make sure they look good.  Thx, Dan

@Ladas, I think you're the only one I know right now with the proper setup; would you be able to verify this patch?  Thanks!

@tzumainn actually mine works like from 70% this week :-) @mcornea has valid setup afaik, I will start to use install script written by him. Marius, could you test it?

@tzumainn @Ladas what is the status of this PR?

@tzumainn @Ladas marking as WIP until this is ready for final review.

@tzumainn @chessbyte This PR is required for CFME QE automation to run against Openstack Infra because I haven't found any way how to pass newlines to an input using selenium. Native selenium or using JS tricks to set the value, everything seems to ruin the key and then the actions dependent on the SSH key do not work.

@mfalesni this PR is marked as WIP and is not mergeable.  Are you asking for review in this state?

Not review, but revisit by the dev, if possible. We haven't discovered this before because OS Infra was tested mostly manually.

Apologies for the long delay on this item; it turned out that I don't quite have a the javascript know-how for this.  We finally have a dedicated GUI dev - let me see if he has time to finish this feature.

@mfalesni it should work for you when you replace the /n with /s, the current code works with that, cause the browser is replacing all /n with spaces

@Ladas I cannot find any \s character, only that it is a regexp class. Anyway. I tried to retrieve the .value in browser where I discovered that the newline was converted to a character with code 32 (space), which I then tried from inside python (s.replace("\n", chr(32))), I tried it both using selenium and javascript to set the value but it the JS variant made the key disappear, there was only the beginning line and ending line and done through selenium it stripped all the newlines/spaces. Looks like it gets stripped either in browser somehow or directly in selenium ...

@mfalesni hm that sucks, though it's weird that it strips spaces, it's a valid character to put there.
So I guess we will need to wait for this patch to land. :-)

@Ladas Yes, it seems some part of the chain between python and the browser itself tries to be smarter than needed. Awaiting the patch :)

This issue is blocking our test automation for Openstack Infra and Google Compute Engine at the moment. We will probably need help from you guys on this one - is there any chance this PR could make it into 5.6? Otherwise we gotta find a workaround... @chessbyte @dclarizio

@slucidi would you be able to take a look at this?

@Ladas you were running into some issues with your previous testing, are we good to merge this now, can you verify?

@tzumainn please rebase/repush

@h-kataria I don't think my code was done in an optimal way, I'd prefer to have a UI dev like @mansam take a look to see if the PR should be changed.

@h-kataria it's so long I don't remember anymore :-)

BZ here: https://bugzilla.redhat.com/show_bug.cgi?id=1326585

Please try to update this on both osp infra and gce cloud providers as both need it.


Use method as cache key prefix for non-GET requests

The response for a HEAD request shouldn't be served in response to a GET request.
In practise, HEAD responses contain http.noBody values, which return 0, io.EOF if you try to read them. Prior to this change, that's what happened if you hit a server with a HEAD request and then GET the same URI.
Rather than prefix all keys, I've only added prefixing to non-GET requests. As well as saving the cost of a string concatenation, it ensures existing disk caches can upgrade without completely invalidating.

@gregjones @shurcooL do you have any time to review this?

I've taken the liberty of applying those minor test improvement suggestions; please let me know if you disagree with them.

I agree with your changes @shurcooL. Consistency is good. I also didn't know GitHub allowed the addition of commits to someone else's PR; TIL.
Regarding consistency, I used the http package's method constants http.MethodGet and http.MethodHead, which ignores the library's precedent of using plain quoted strings. The reasoning is more typo elimination (e.g. http.MethodHaed will fail more emphatically) than optimisation. I'm happy either way, but it's worth noting.
Thanks for your time reviewing the PR. I'll try to keep the test style more consistent in the next one.

I also didn't know GitHub allowed the addition of commits to someone else's PR; TIL.

It's a new feature from last year, see https://github.com/blog/2247-improving-collaboration-with-forks. Maintainers can only edit your PR if you have the "Allow edits from maintainers" checkbox checked.

I used the http package's method constants http.MethodGet and http.MethodHead, which ignores the library's precedent of using plain quoted strings. The reasoning is more typo elimination (e.g. http.MethodHaed will fail more emphatically) than optimisation. I'm happy either way, but it's worth noting.

That's completely okay. I prefer using the named consts too, but I'm okay with either.

@shurcooL gotcha. Anything stopping us from merging?

I'll give @gregjones a day or two to see if he has any other comments. After that, I can merge.

Thank you @hx again for this valuable fix, and for your patience with us getting to this PR.


Detail display "Host Location" is not displayed correctly. The last character of the address is also missing.

Under "Nodes" it is displayed correctly.

TD5VJN2M5RHPWMQSZGH6SRAJQHAWPEZT6T5CM6I

Thanks for reporting the issue. Fixed


Could not open tunnel:  Invalid subdomain.

Following the instructions at https://github.com/probot/probot/blob/f0b3f4993faa706d7eed67de2aa621e594021538/docs/development.md for setting up a local probot server.
$ npm start

> electron-probot@ start /Users/z/git/electron-probot
> probot run ./index.js

Yay, the plugin was loaded!
05:28:15.679Z DEBUG PRobot: Loaded plugin: ./index.js
Could not open tunnel:  Invalid subdomain. Subdomains must be lowercase and between 4 and 63 alphanumeric characters.

Without looking at probot's code, my guess was that the subdomain creation was based on the name value in package.json, but changing it to an alphanumeric string and running npm start did not change the outcome.
$ cat package.json
{
  "name": "electron-probot",
  "private": true,
  "description": "A helpful robot for the electron org",
  "author": "zeke",
  "license": "MIT",
  "repository": "https://github.com/electron/electron-probot",
  "scripts": {
    "start": "probot run ./index.js",
    "test": "mocha && xo --extend probot"
  },
  "dependencies": {
    "probot": "^0.7.2"
  },
  "devDependencies": {
    "eslint-config-probot": ">=0.1.0",
    "expect": "^1.20.2",
    "localtunnel": "^1.8.2",
    "mocha": "^3.2.0",
    "xo": "^0.18.0"
  },
  "engines": {
    "node": ">= 7.7.0",
    "npm": ">= 4.0.0"
  }
}

Just found these lines in probot's .env.example:
# Subdomain to use for localtunnel server. Defaults to your local username.
# SUBDOMAIN=

My local username is z, which is too short.
But this did the trick:
$ SUBDOMAIN=zeketown npm start

> electron-probot@ start /Users/z/git/electron-probot
> probot run ./index.js

Yay, the plugin was loaded!
05:41:20.176Z DEBUG PRobot: Loaded plugin: ./index.js
Listening on https://zeketown.localtunnel.me

I started off using the plugin-template repo, which currently does not include the SUBDOMAIN entry.

@bkeepers you should update the docs on https://probot.github.io/docs/development/ to explain that we need to enter a subdomain in the .env file before running npm start

Ah no it's just that my username is "Olivier" and localtunnel only works with lower case, maybe you could use "toLowerCase()` before using it?

Just a note that this happened to me too. Maybe printing the used subdomain (like the username used) would help figuring the problem.

@luebken printing the subdomain is a great idea. That's a fairly simple change (compared to the rest of what we've talked about here and in #280), but with a great benefit. We'd love it if you made that PR @luebken, if you have the time!

@JasonEtco Sure. The original message comes from libtunnel. So if we want to fix it here we need to touch [lib/tunnel.js]. Here is a first shot: https://github.com/luebken/probot/pull/1/files
Is there a guide on how to setup local development? A git clone && npm install && npm start throws me an error:
> node ./bin/probot run

fs.js:948
  binding.lstat(pathModule._makeLong(path));
          ^

Error: ENOENT: no such file or directory, lstat '/Users/mdl/workspace/git-hub-lib/luebken/probot/bin/probot'


[NWPS-1725] Build to render chosen root taxonomy categories on publication pages

Build to render only root categories of the chosen publication type, healthcare topic and profession taxonomy values on publication pages (collection, landing and single) using __with_ancestors suffixed taxonomy property derived by brXM out-of-the-box. This has been implemented on the following sections of the publication pages:

Publication info box on the publication landing & single page.
Filters/facets of the publication collection page.

Manual task:
The hippofacnav:facets property of publicationfacets node for each channel should be updated to contain __with_ancestors suffixed taxonomy fields.
Example:
/content/documents/lks/publicationfacets:
  jcr:primaryType: hippofacnav:facetnavigation
  hippo:docbase: 7a39b705-1cac-4076-bc99-726dd5be84e8
  hippofacnav:facets: ['hee:globalTaxonomyPublicationType__with_ancestors', 'hee:globalTaxonomyHealthcareTopics__with_ancestors',
    'hee:globalTaxonomyProfessions__with_ancestors']
  hippofacnav:filters: ['jcr:primaryType=hee:publicationLandingPage']

@FranciscoRuizHEE - Converting to draft as per the latest comment on the ticket from Kat and blocked by NWPS-1730, thanks


Question for coco2014 and coco2017

In this link， 2014 train images, 2014 val images is needed. However, in 4M Image Text Pairs, coco2017 is needed.Which is exactly needed?

We are using 2014 train for 4m image text pairs, and exclude the coco2014 validation images for segmentation training.


Cannot perform send keys action

appium v1.22.3
I use inspect tool to locate a text field and want to send the text by sending keys action. Error msg is

and I always met error "Interactions are not available for this element"

可以通过xcui文档中提供的执行脚本的方式，实现点击之后，再输入字符，针对任意控件都能生效，本人有开源了一个基本封装库，在https://github.com/zhouxihong1/mac_automation.git；欢迎交流

It is impossible to advice anything on this issue without detailed server logs and environment infos.


Correction for raw affiliation Ecole Nationale Supérieure de Chimie de Rennes, University of Rennes, CNRS, ISCR—UMR6226, 35000 Rennes, France

Correction needed for raw affiliation Ecole Nationale Supérieure de Chimie de Rennes, University of Rennes, CNRS, ISCR—UMR6226, 35000 Rennes, France
raw_affiliation_name: Ecole Nationale Supérieure de Chimie de Rennes, University of Rennes, CNRS, ISCR—UMR6226, 35000 Rennes, France
new_rors: 01h0ffh48;015m7wh34;02feahw73;00adwkx90
previous_rors: 01h0ffh48;015m7wh34;02feahw73
works_examples: W4318203846
contact: f3be67953d2d4bba047f962a5ef0d35b:9314070960b8a8e364fc7559c6f1302b @ univ-rennes.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


142_HITNET model conversion to edgetpu

Issue Type
Support
OS
Ubuntu
OS architecture
x86_64
Programming Language
Python
Framework
TensorFlowLite
Description
I have a problem converting the HITNET model to edgeTPU in particular when converting the saved_model to full_integer_quant. I have already seen that it is not by default converted and I don't know if it is something that definitely can't be done.
I tested eth3d, flyingthings finalpass xl, and middlebury d400.
Thanks in advance
Relevant Log Output
Start conversion process from saved_model to tflite ======================================
Before changing the input shape Tensor("input:0", shape=(None, None, None, 2), dtype=float32)
After  changing the input shape Tensor("input:0", shape=(1, 120, 160, 2), dtype=float32)
numpy dataset load started ==========================================================
numpy dataset load complete!
Full Integer Quantization started ===================================================
WARNING:absl:Please consider providing the trackable_obj argument in the from_concrete_functions. Providing without the trackable_obj argument is deprecated and it will use the deprecated conversion path.
Estimated count of arithmetic ops: 3.500 G  ops, equivalently 1.750 G  MACs
INFO: Created TensorFlow Lite delegate for select TF ops.
INFO: TfLiteFlexDelegate delegate: 20 nodes delegated out of 774 nodes with 10 partitions.

ERROR: operands could not be broadcast together with shapes (1,120,160,2) (3,)
Traceback (most recent call last):
  File "/usr/local/bin/saved_model_to_tflite", line 278, in convert
    tflite_model = converter.convert()
  File "/usr/local/lib/python3.8/dist-packages/tensorflow/lite/python/lite.py", line 1714, in convert
    return super(TFLiteConverterV2, self).convert()
  File "/usr/local/lib/python3.8/dist-packages/tensorflow/lite/python/lite.py", line 803, in wrapper
    return self._convert_and_export_metrics(convert_func, *args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/tensorflow/lite/python/lite.py", line 789, in _convert_and_export_metrics
    result = convert_func(self, *args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/tensorflow/lite/python/lite.py", line 1383, in convert
    return super(TFLiteFrozenGraphConverterV2,
  File "/usr/local/lib/python3.8/dist-packages/tensorflow/lite/python/lite.py", line 1009, in convert
    return self._optimize_tflite_model(
  File "/usr/local/lib/python3.8/dist-packages/tensorflow/lite/python/convert_phase.py", line 216, in wrapper
    raise error from None  # Re-throws the exception.
  File "/usr/local/lib/python3.8/dist-packages/tensorflow/lite/python/convert_phase.py", line 206, in wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/tensorflow/lite/python/lite.py", line 749, in _optimize_tflite_model
    model = self._quantize(
  File "/usr/local/lib/python3.8/dist-packages/tensorflow/lite/python/lite.py", line 555, in _quantize
    calibrated = calibrate_quantize.calibrate(
  File "/usr/local/lib/python3.8/dist-packages/tensorflow/lite/python/convert_phase.py", line 216, in wrapper
    raise error from None  # Re-throws the exception.
  File "/usr/local/lib/python3.8/dist-packages/tensorflow/lite/python/convert_phase.py", line 206, in wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/tensorflow/lite/python/optimize/calibrator.py", line 224, in calibrate
    self._feed_tensors(dataset_gen, resize_input=True)
  File "/usr/local/lib/python3.8/dist-packages/tensorflow/lite/python/optimize/calibrator.py", line 93, in _feed_tensors
    for sample in dataset_gen():
  File "/usr/local/bin/saved_model_to_tflite", line 238, in representative_dataset_gen
    tmp_image = eval(string_formulas_for_normalization) # Default: (data - [127.5,127.5,127.5]) / [127.5,127.5,127.5]
  File "<string>", line 1, in <module>
ValueError: operands could not be broadcast together with shapes (1,120,160,2) (3,)
EdgeTPU convertion started ==========================================================
ERROR:
Traceback (most recent call last):
  File "/usr/local/bin/saved_model_to_tflite", line 291, in convert
    result = subprocess.check_output(
  File "/usr/lib/python3.8/subprocess.py", line 415, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/lib/python3.8/subprocess.py", line 516, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['edgetpu_compiler', '-o', 'eth3d/saved_model_120x160', '-sad', '-t', '3600', '-n', '1', 'eth3d/saved_model_120x160/model_full_integer_quant.tflite']' returned non-zero exit status 1.
--------------------------------------------------------------------------------
Please install edgetpu_compiler according to the following website.
https://coral.ai/docs/edgetpu/compiler/#system-requirements
All the conversion process is finished! =============================================

URL or source code for simple inference testing code
No response

First, the conversion command you ran is wrong. You are trying to do a 3-channel normalization, and it looks like the image in the calibration dataset has 3 channels. The input is expected to be two channels.
tmp_image = eval(string_formulas_for_normalization) # Default: (data - [127.5,127.5,127.5]) / [127.5,127.5,127.5]
↓
ValueError: operands could not be broadcast together with shapes (1,120,160,2) (3,)

Secondly, even if the calibration is done correctly, the conversion to EdgeTPU is not possible at this time. Before converting to TPU, there are two types of operations that are not supported by TensorFlow Lite. These are StridedSlice in 6D and Transpose in 7D.

I have asked the TensorFlow team to see if they can solve this problem for me. However, I think they are very busy and it will be many years before they will heed my wishes.
https://github.com/tensorflow/tensorflow/issues/53702

Thank you very much for your answer, we will wait for the TensorFlow team then.
Congratulations for your work.


hardhat-zksync-verify  How to verify open source upgradable contracts

Hi @contractsolidity, you can use our hardhat-zksync-upgradable plugin to verify upgradable smart contracts.
Find more details on how to run the verification process in the official documentation.


Async call ACSK part2

related to #300
Online check of the signatures that has been validated offline

We can make optimization: do not return "signed_content" from ds.api, and handle this content on il directly, no reason load network with this content from ds to il

Also, we can  not link declaration_request id | legal_entity id | .. id | with check because on step check signed content we do not have this id, and we can avoid linking id of OCSP check with signed content on il, we can only store retrieved content from signed content in case provider response sign is not valid

[ ] On dev environment we could sign off DS, in that case if we send request with real DS we should get 422 error and not 501.

{
    "meta": {
        "url": "http://api-svc.il/api/legal_entities",
        "type": "object",
        "request_id": "5386d3e9-0d55-41ba-bb61-f06ec599f5d1#10795",
        "code": 501
    },
    "error": {
        "type": "internal_error"
    }
}

[ ] can't reproduce offline checking of digital signature using lists of the revoked certificates, with email notification


Update version dependency/README.md

Expected Behavior
To import CookieService
Actual Behavior
Cannot find DOCUMENT from angular/common
Steps to Reproduce the Problem
Take the specific Angular version: < 4.3.0
Specifications

Version: 4.2.5
Browser: -
...

You should update your version dependency/README.md, import DOCUMENT from angular/common works only with Angular version >= 4.3.0

Sorry for the late response and thank you for opening this issue.
According to the Git tags of the angular repository @angular/common exports DOCUMENT since 4.2 (Github)
We have updated the README and package.json accordingly.


Improve datastore unit testing by creating fake persistent datastores

Change the way that the datastore unit tests are written to use a fake persistent datastores that can be instrumented to return success or failure. This will make it easier to test error paths in datastore.

More detail:
Current controller test implementation uses sleeps for synchronization, because it uses the real controller datastore which does asynchronous writes to the sql backing store.  It is asynchronous by design.
For our tests though we want to know that a specific action has occurred before we carry on to a next action.  Since there's no synchronous success/failure return by design from the sql data store, the tests can't know today that a first action is done before a next.
Refactoring to a datastore interface means we can implement a fake datastore, instead of the sql one, for test purposes.  For its implementation we'd get either synchronous changes to data with function return meaning the data was definitely stored, or keep asynchronous return but add a channel by which the implementation can indicate to the asynchronous function caller that the work is done, or it would only serve pre-canned static data.  Then when a test sub-point B needs the data from test sub-point A, we know that data is present and B will deterministically be able to successfully run.
Then we can remove the sleeps from the controller test cases, and do some go-race checking also.


Set local-path to default storageclass failed, no error message from ui

Setup

Rancher version: v2.6.3 v2.6.4
Browser type & version: chrome 100.0.4896.127(arm64)

Describe the bug

Set local-path to default storageclass failed, no error message from ui
To Reproduce

Install https://github.com/rancher/local-path-provisioner
Click on the left menu Storage -> storageclasses, go to the storageClasses  page
Click on the name (local-path) link to go to the detail page
Click on the left menu Storage -> storageclasses, go back to the storageClasses page
Click on the local-path drop-down menu Set as Default

Result
The request reports error 422, but the UI shows that it is set to default

Expected Result

local-path storage class Set as default storage class
Screenshots

@nwmac able to repro based on the steps provided. From the list page, if you don't go into the detail view, the Set as Default works correctly. But if you click on the detail for the local-path and go back one page, you get the 422. An "unprocessible entity" message appears.
This points to something going on tied to local-path. This is similar to a problem we have with resizing volume claim whereby we're saving the whole object when we should be patching the annotation to indicate that it's a default or not. This is handled by the storageclass, which is being fussy by not allowing you to change a property.

Test Environment:
Rancher version: v2.6-head
Rancher cluster type: HA
Docker version: 20.10
Browser: Chrome Build 102.0.5005.61

Testing:
Tested this issue with the following steps:

Install https://github.com/rancher/local-path-provisioner
Click on the left menu Storage -> storageclasses, go to the storageClasses page
Click on the name (local-path) link to go to the detail page
Click on the left menu Storage -> storageclasses, go back to the storageClasses page
Click on the local-path drop-down menu Set as Default

Result - Pass
UI shows that local-path storage class is set as Default and the request is also successful


[Migrate actions] Create version bump action

Description
As a maintainer, I need to perform a version bump when I publish a release. This should make the change in GitHub for me, and not require that I commit and push the change.
### Acceptance criteria
- [ ] I can call this action to bump the version on the active branch
- [ ] I can provide any version input that `hatch version <version>` can take in, including specific versions (e.g. `1.8.0b3`) or version types (e.g. `alpha`, `minor,rc`)
- [ ] I can provide a working directory so that I can use this for mono-repos, e.g. to bump the version of `dbt-tests-adapter` in the `dbt-adapters` repo

Impact to other teams
This impacts Adapters and Core since they are the primary consumers of these actions.
Proposals

named hatch/version/bump
inputs version, working-directory
log an error if version is less than the existing version (hatch throws an error for this

We have a PR with these contents already.


BUG: UnicodeDecodeError caused by xinference/model/llm/llm_family.json

Describe the bug
Windows cmd runned xinference found Error: "UnicodeDecodeError: 'gbk' codec can't decode byte 0xae in position 8905: illegal multibyte sequence"
To Reproduce
To help us to reproduce this bug, please provide information below:

python version: 3.10
xinference version: v0.1.0

Expected behavior
Edit the file: xinference/model/llm/init.py
Line number: 129
Add arg encoding: open(json_path, encoding='utf-8')

Thanks for reporting this issue! This problem will be fixed in the next release.
Stay tuned!


update(ci): add 0.38.1 and 0.38.2 as supported versions

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

What this PR does / why we need it:
as per title
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incertum, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [LucaGuerra,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 745826fd20816d705926799ce606b2a7686a5567


No Matching Manifest

Please fill out all the sections below for bug issues, otherwise it'll be closed as it won't be actionable for us to address.
Describe the bug
When trying to pull a Windows Server Core LTSC 2022 image, it fails with the error message:
no matching manifest for linux/amd64 in the manifest list entries

To Reproduce

Start up Docker Desktop. If you don't have it installed, download it here.
In a PowerShell window, run the following command:

docker pull mcr.microsoft.com/windows/servercore:ltsc2022

You should see the error message after running the command.

Expected behavior
We would expect the pull to be successful and to start seeing Docker download the image. There should be no error message.
Configuration:

Edition: Windows 11
Base Image: Windows Server Core LTSC 2022
Container Engine: Docker
Container Engine Version: 24.0.2 (cb74dfc)

Background:
This error occurs when there is a mismatch between the Container Image OS and the platform OS. We are trying to pull a Windows image, however, it's saying it cannot find a "manifest for linux/amd64". This message arises when the Docker platform is set to "Linux containers" while trying to pull a Windows image.
Solution:
If Docker Desktop is running, switch the platform to use "Windows containers" by right-clicking the little docker icon (black whale) in the system tray. To confirm that you have switched (there can be a 30s delay), right-click again on the icon and if you see the option "Switch to Linux containers" you know that it's now using Windows containers. Try to pull the image again and it should succeed.

This is not a solution. When selecting any of the container platforms, Windows or Linux, the same error still occurs, even after restarting Docker Desktop services after switching.
And this applies not only to one version of LT SC 2022, it applies to any version. In general, no image can be downloaded, we get an error on any of the images:
docker: no matching manifest for linux/amd64 in the manifest list entries.


Can I display a banner in sleep mode?

react-native:  0.41.2,
react-native-fcm: 6.0.3
android
Is it possible to show a banner in sleep mode?
I'm using custom_notification so I can see the banner when my app is running in the background. But in sleep mode I can't see a banner (but I can hear a notification sound). There were some posts that seemed to imply that this isn't something that's supported but I wasn't 100% sure. So I just want to ask if this is possible using just this library.

Do you know how to do it with native code? An example will be helpful since I don't know android notification feature much.

Hi, we had trouble with this too.
Check the notification settings of your android device, some custom androids deactivate this by default. For example, on xiaomi devices you have to activate notifications on the lock screen explicitly in your device settings.
Then it works with the custom_notification feature as well. (newest rn and rn-fcm version)

Thanks for the clarification. I will close this for now


Add CMake build file

Add CMake build file to support Linux/Mac/Windows build. This CMake file needs to support system/submodule lz4 and submodule re2, as qgrep uses prefilter class from re2 and thus system-provided re2 won't work.

System re2 doesn't expose prefilter class. So only system LZ4 is used.

Add a CMakeLists.txt: the reason of using CMake is that rpm spec can easily do %cmake, %cmake_build, and %cmake_install. Less code on that side.

I have tested the CMakeLists.txt on Windows 10 (VS 2015), Fedora (x86_64 locally, and aarch64 on COPR build system), Mac (x86_64), and OpenSUSE Leap 15.2 (Raspberry Pi 4, aarch64)

Need CMake >= 3.13 for tuning linking options. So right now, EPEL 8 is not able to use this CMakeLists.txt file, but CentOS Stream can.

For the RPM spec, I temporarily use my fork's URL to enable tag v1.3. I will update the RPM spec file after official v1.3 is released.
Thanks!

Thanks!


update npm packages to latest

@larshp Do you mind, if we merge the latest version to see whether it fixes the validation in PR https://github.com/SAP/abap-file-formats/pull/471

no, go for it


dhcpcd crashes

figure out why and see if it matters.

fixed in v0.9.2 - by avoiding the issue - calling dhcpcd --release <dev> on the same device more than once, while hammering the service with other requests made it unhappy


Support for hash params

Would be nice to manipulate hash params without having to download another library.

Would be nice to manipulate hash params without having to download another library.

Well, isn't that just location.hash = "some-hash" and var someHash = location.hash.substring(1)?

Why do you need this lib in the first place? location.search = someString works just like you suggest for location.hash. :trollface:

location.search = someString works just like you suggest for location.hash

location.search = someString reloads the whole page while location.hash doesn't.
But if you need specific helper functions like Url.hash = function () { return location.hash.substring(1); } and so on, feel free to specify that.

What I mean is an ability to manipulate individual hash entries as opposed to overwriting the whole hash. I. e. updateSearchParam and queryString counterparts.

@lolmaus Is there a specific use case? Maybe an example would be useful. :thought_balloon:

@lolmaus In 2.0.0 I added the hash method which sets/gets the hash (without the # character). :ship: 2.0.0 :tada:

Setting the whole hash can be achieved via window.location.hash, it makes little sense to replicate it in a library.
The idea is to be able to get/set hash key/value pairs individually.

@lolmaus Well, like I mentioned before, we accept contributions. Just feel free to raise a good pull request and we will take care of it. :sparkle:


Evaluation.explore should support notebook target

Hi @znation: writing.

Note: this issue is about making the interactive web-based UI from Evaluation.explore show up inline in the notebook while remaining interactive.
Challenges here include: getting that UI to work over http (#2241 is a prerequisite for this), and making sure the front-end UI doesn't impact the broader page when embedded in a notebook cell.


generate_alexnet dumped

test_net.AddGradientOperators(first=2) goes wrong, first id not recognized.
When I change 'first' to 'skip', I get segmentation fault. It breaks in AddGradientOperators
for forward_op, current_fwd_metadata in zip(operators[::-1], fwd_metadata[::-1]):
13th iteration.

(should be fixed in the most recent version)


Update jumpbox_setup.sh

Fixes:
➜  Vault git:(homelab) vault kv put -mount=seclab test_kv seclab_ssh_key=$(cat ~/.ssh/id_rsa.pub)
Failed to parse K=V data: invalid key/value pair "<user>@homelab-jumpbox": format must be key=value

Fixex #22

Fixed in c5a4fe75a1c56df068d4de653711fb1497ecf7dd


Time picker

Date picker is awesome, when are we getting time picker?!

+1

How do you use the datepicker ? I am using a jquery datepicker but I would like to use the one in material ?
Thanks

flatpickr has material theme https://chmln.github.io/flatpickr/themes/

@chromafunk documentation for material datepicker : http://daemonite.github.io/material/docs/4.0/material/pickers/

@hamidabdulmalik Hi, this plugin has time picker: https://djibe.github.io/material/docs/4.5/plugins/picker-flatpickr/


[libpulse-binding] how to manage mainloop in callbacks

Hey, thanks for creating this higher-level abstraction for pulse!
How would you recommend managing mainloop when I'm dealing with callbacks?
For example:
let mainloop: Rc<RefCell<Mainloop>> = ...
let context = Rc<RefCell<Context>> = ...

let op = {
    let mainloop = mainloop.clone();
    context.borrow().introspect().get_server_info(move |info| {
        let op = context.borrow().introspect().get_sink_info_by_name(&info.default_sink_name.unwrap(), move |_| {
            println!("neat");
        });
        # loop
        #     mainloop.iterate
        #     break if op.get_state() == Done
        #
    })
}

# loop
#     mainloop.iterate => at this point, callback is called
#     break if op.get_state() == Done
#

I'm running into an issue where mainloop is in use when my callback is called. So, when I need to wait for my nested operation (get_sink_info_by_name(...)), I can't borrow mainloop to iterate, since it's already in use.
How would you recommend handling this?

One approach is to not manually wait on each operation, but rather to just run the mainloop and "let fly", e.g.:
let mut mainloop = Mainloop::new().unwrap();
let context = Rc::new(RefCell::new(context));
let introspector = context.borrow().introspect();
{
    let context = context.clone();
    introspector.get_server_info(move |info| {
        context.borrow().introspect().get_sink_info_by_name(
            &info.default_sink_name.clone().unwrap(),
            move |list_result| {
                if let ListResult::Item(sink_info) = list_result {
                    dbg!(sink_info);
                }
            });
    });
}
mainloop.run().unwrap();

I can only respond to this very briefly.
The major issue that I see with the original example code, from a quick look at it, is that you seem to be following a flawed concept of mainloop execution.
You have created a callback which, as you correctly point out, is executed by the mainloop iteration done at the bottom. However, you also are trying to perform an operation relating to mainloop execution within the callback itself, which goes against the concepts of using the mainloop. I.e. you are trying to force a mainloop iteration, from within the execution of a mainloop iteration itself.
While recursive function calling may be a perfectly legitimate programming concept, you just can't do that here (afaik).

True, I suppose my approach required that operations could be run sequentially
|-----------------mainloop--------------|
|------------------|   |----------------|
    operation 1            operation 2
 (get server info)      (get sink info)

Though, in actuality, if my callback is triggering the next operation, then there's some overlap:
|-----------------mainloop--------------|
|-----------------------|
    operation 1      |------------------|
 (get server info)        operation 2
                        (get sink info)

Interesting! Thanks for the insight :smile:


Jumping to fragments does not work in a good way in Browser.application

For a Browser.application the docs recommend to handle UrlRequest like this
case msg of
    ClickedLink urlRequest ->
      case urlRequest of
        Internal url -> ( model, Nav.pushUrl model.key (Url.toString url))
        External url -> ( model, Nav.load url )

However, this won't do anything with links like the following Jump (to jump to ) since they will count as Internal UrlRequests.
It is possible to jump to fragments using Nav.load but the suggested code above will only change the url with Nav.pushUrl.
Notes:
There are a couple of cases to consider, links like:

#myAnchor or /samePage#myAnchor
Links pointing to anchors on the same page can be used to safely jump to the anchor immediately using the browsers default behavior, because the page is already rendered.
/newPageAnchor#anchorOnDifferentPage
However when navigating to an new page an anchor on a new page, SPAs behave differently than server rendered pages. The url changes first and only after some async data is loading the page containing the anchor is actually rendered. Only once the page is rendered it is possible to jump to the anchor. This case introduces a time gap between clicking the link and being able to navigate to the anchor.

It would be nice to have a solution for the first case that is close to browser behavior, but the preventDefault on every link seems to make it tough right now.
The second case (navigating to a new page) doesn't seem to be elm specific but a general SPA "problem". Other frameworks and routers have similar issues https://github.com/rafrex/react-router-hash-link/tree/react-router-v2/3#react-router-hash-link-scroll and seem to use some kind of polling of the DOM to check if the anchor has been rendered.

** Update **
After giving this a lot of thought, I would like to suggest to add an additional check in the vdom to prevent the default only when this is also true:
domNode.getAttribute('href')[0] !== '#'

This will preserve regular browser behavior for links which just reference an anchor and won't send the msg to the Browser.application. This will take care of the most common case for using anchor (go to anchor on same route). Of course there are also other cases like going to a new page with an anchor but those will need to be handled anyway in SPAs and the jump to the anchor needs to be delayed until the anchor is rendered.
** end **

By setting target "_self" on links, Browser.application seems to ignore them for navigation. So, that's a simple workaround which also works for mailto: and 'tel:` links!

Yup, it's this line for reference https://github.com/elm/browser/blob/master/src/Elm/Kernel/Browser.js#L157


Need to have navbar removed during initial release

Problem
Initial Release Should not Contain apply button so users aren't inclined to test the application system before configs are tested.
Solution
What I/we did to solve this problem

Removing it temporarily

Change Summary:

Updating Navbar Props

Dev-Ops
If you added an ENV variable, please check off that you've updated the following

[ ] Key & Sample value to .env & sample.env
[ ] GCP Secret Manager (Both development and production)
[ ] Github Secrets (Added a development and production variable)
[ ] Github Workflows .github/workflows/dev.yml & .github/workflows/prod.yml
[ ] webpack-config.js

Images/Important Notes (optional):

Insert any notes/issues, dependencies added or removed, or images

I don't think it's necessary but should we also comment out the /portal route?

I want to do 1 test submission with the production configs without having users navigating to that route.


Translational.MassWithStopAndFriction

Reported by AHaumer on 19 Nov 2007 09:37 UTC
Translational.Components.MassWithStopAndFriction (former Translational.Stop) is unphysical since velocity is re-initialized when the mass hits the stop but no force  is calculated:
m . der(v)
A stop can't be modeled this way, a solution might be using a non-linear spring when the mass is near the stop. This doesn't matter in MSL <= 2.2.2 since no support is present (Translational.support was introduced in MSL 3.0).
Recommendation: define Stop / MassWithStopAndFriction as obsolete; model a proper stop.

Migrated-From: https://trac.modelica.org/Modelica/ticket/20

Modified by dietmarw on 19 Nov 2007 10:43 UTC

Comment by AHaumer on 19 Nov 2007 18:21 UTC
fixed by e987e1cc73ffeee303a75d4501aa66a4ca79b9a4, 59e9b2c650a4bcf051d8d000389020c76cfb2927:
MassWithStopAndFriction moved to Grounded;
PartialFrictionWithStop moved into (encapsulated) MassWithStopAndFrcition;
so the old model (as well as the partial) is available but without support
until a sound implementation of a hard stop has been modeled.


Training on Docbank and the MAX_BOXES_NUM variable

Thanks for providing the code to your wonderful paper. As I am digging through and trying to understand whats going on under the hood I ran into something that I do not understand.
Clarification on the variable MAX_BOXES_NUM - in the documentation, this is listed as an optional field to change. When you look at the docbank boxes, some of them are north of 1000 for a single document. Does this mean if you leave this variable at the default 70, the model will only use the first 70 boxes and ignore the rest? Trying to up this number anywhere close to say 1000 it just eats up the vram and the training crashes. Any clarification on this variable and how it affects training/inference would be greatly appreciated.
Thanks!

@sariabod, did you clarify your questions on MAX_BOXES_NUM? If so, can you share it?

@victor-ab Digging through the code, from what I could gather, they sort the boxes then truncate anything over MAX_BOXES_NUM (if you have more entries then this number).  I had to do some preprocessing of the data since after ocr some of the documents would have over 1000 elements. Being able to strip out things you know are not needed helped bring the documents down to a manageable level.

@victor-ab Digging through the code, from what I could gather, they sort the boxes then truncate anything over MAX_BOXES_NUM (if you have more entries then this number).  I had to do some preprocessing of the data since after ocr some of the documents would have over 1000 elements. Being able to strip out things you know are not needed helped bring the documents down to a manageable level.


execution order with multiple node_modules/tape installations

tape's execution order gets confused when multiple tape installations exist.
For example, given multiple tape installations like this:
root
   node_modules/tape
   a/test.js
   a/node_modules/tape
   b/test.js
   b/node_modules/tape

The tests in a and b won't wait for each other to complete, even if they're running in the same node process i.e. the following will run tests in parallel:
tape a/test.js b/test.js

This is immediately evident by the printing of multiple TAP version 13 strings when trying to run both tests:
> tape a/test.js b/test.js

TAP version 13
# a
TAP version 13
# b
...

Here's a an executable example that demonstrates the problem by having some shared global state between the tests:
https://github.com/timoxley/test-tape-multiple-instances
Not sure if it's possible to solve this cleanly, would need a globally accessible flag or interference/monkeypatching of require; both options are pretty gross.

In my case, the nested tape installation was an accident, and due to some interaction between concurrently executing tests, things were passing when they shouldn't and I hadn't noticed for a long time.

@timoxley is this a monorepo/multi-package scenario? typically i've seen test scripts that cd into each package and run npm test for that. if not, why the nested node_modules?

@ljharb yep, monorepo. Problem with cd into each package is that it takes significantly longer because it needs to pay a heavy startup cost many times

Given that each test file is requiring tape, and the node require algorithm is working properly here, I don't really think there's a good solution :-/
Perhaps you could cd $root/node_modules/tape && npm link && cd $root/$eachProject && npm link tape as part of your pre-test process?

I don't really think there's a good solution

@ljharb agreed, though my concern here is that it's relatively easy to accidentally end up with inaccurate test reporting, in a way that's particularly hard to even notice. I think that's the worst-case scenario for any test runner. Not really tape's fault, unfortunately node's module system doesn't have any simple facility to detect or handle this scenario.

I think it's worth noting though that this is in the unlikely scenario where you've got a monorepo, but you aren't running sub-package tests independently.

This seems answered.


ordered_cache_behavior issue with dissimilar behaviors

When I try to plan/apply the following behaviors list, terraform (0.12.30) complains that all items in the list must be of the same type.
Error: The given value is not suitable for child module variable "ordered_cache_behavior" defined at .terraform/modules/totara_cdn/variables.tf:130,1-34: all list elements must have the same type.
ordered_cache_behavior = [
    {
      path_pattern           = "/cdn/*"
      target_origin_id       = "s3"
      viewer_protocol_policy = "allow-all"

      allowed_methods = ["GET", "HEAD", "OPTIONS", "PUT", "POST", "PATCH", "DELETE"]
      headers = ["Access-Control-Request-Headers", "Access-Control-Request-Method", "Origin"]
      trusted_signers = ["self"]
    },
    {
      path_pattern = "lib/requirejs.php*"
      target_origin_id = "alb"
      viewer_protocol_policy = "allow-all"

      allowed_methods = ["GET", "HEAD"]
      headers = ["Host"]
      query_string = true
    },
]

I can get it to accept the second item, only if all keys are present:
    query_string = false
    },
    {
      path_pattern = "lib/requirejs.php*"
      target_origin_id = "alb"
      viewer_protocol_policy = "allow-all"

      allowed_methods = ["GET", "HEAD"]
      headers = ["Host"]
      trusted_signers = []
      query_string = true
    },

Is this expected? Or is there a better workaround?

This looks like a bug that should be fixed in the module if you or anyone else have time.

This looks like a bug that should be fixed in the module if you or anyone else have time.

Ah great! I wasn't going insane, I'm afraid I don't know enough TF to fix it, otherwise I would have ;)

Ah great! I wasn't going insane, I'm afraid I don't know enough TF to fix it, otherwise I would have ;)

Terraform expects all elements within a list to be of the same type; that is, both objects must have the same keys present.
Reference

Terraform expects all elements within a list to be of the same type; that is, both objects must have the same keys present.
Reference

So it could be ok for TF 0.14, with optional args. enabled.
"
From Terraform v0.14 there is experimental support for marking particular attributes as optional in an object type constraint.
To mark an attribute as optional, use the additional optional(...) modifier around its type declaration
"
So sounds like no way round it for now, not without losing ordering.

So it could be ok for TF 0.14, with optional args. enabled.
"
From Terraform v0.14 there is experimental support for marking particular attributes as optional in an object type constraint.
To mark an attribute as optional, use the additional optional(...) modifier around its type declaration
"
So sounds like no way round it for now, not without losing ordering.

Just ran into this as well. It seems that the optional experiment mentioned above might be a solution. Is this something that the module is willing to support (i.e. an experiments section) ?

We can only use Terraform 0.13 features in these modules because of the wide range of users/versions. In 90% of cases, there is no need to use even those, and we can use features of 0.12.
This issue is just a bug. PR is welcome.

v1.9.0 has been just released.


Kernel Picker - Native Notebooks

Kernel Picker Artifact:
Design/Location:

Kernel picker to be moved to status bar in bottom left.
Python Interpreter to be hidden for notebooks.
Kernel picker and connection string to the right of it.

Experience:

Kernel picker will be generated in status bar per notebook.

Local: (local white connected icon)

Remote:

If custom display string available, display (remote: custom string white connected icon)
https://github.com/microsoft/vscode-python/issues/12988
If no custom display available, display (remote white connected icon)
When hovering over the remote string, hover tip to display full url.

Clicking the kernel picker will result in quick pick menu options.
When new option selected, kernel picker to update.

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer, @joyceerhl

Duplicate of #254

Duplicate of #254


Bug title

Which version of the app?
WinUI 3 Gallery
Description
When previewing scrollbar options, scrollabar with title after sliding it up and down leaves the title box stuck on top, floating over everything if you change category or look at different previews.
Also, upon clicking on "Settings" button down there, app crashes.
Screenshots
No response
Windows version
Windows 10 22H2 (19045)
Additional context
No response

Can you elaborate more on the repro steps. What ScrollBar are you talking about? Is it a specific page.

I mean exactly this (please see the screenshot attached):
[image: image.png]
Upon some scrolling on the touchpad (Surface Pro 5, latest Win 10) the
annotation either stops working (showing) at all or the "label" gets stuck
all the way on top of everything for whole duration of using the app.
I hope this helps. And also shows another bug, annotation does not change
properly, on "gold" i see "azure".
On Thu, 21 Mar 2024 at 19:30, Karen @.***> wrote:

Can you elaborate more on the repro steps. What ScrollBar are you talking
about? Is it a specific page.
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/WinUI-Gallery/issues/1505#issuecomment-2013244633,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC5LOK4HFUHTFHA6WUPOCJLYZMRMRAVCNFSM6AAAAABE2LAYH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJTGI2DINRTGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Repro:

Open Annotated Scrollbar page
Click on the scrollbar; a (sort of) tooltip shows
Scroll the list via scrollwheel or touch (-screen or -pad)
Tooltip doesn't change a thing

Tooltip seems to be linked to the mouse pointer specifically (?)


问题1

请问 imagenet-vgg-m-2048-cut.mat在哪里下载？

wget http://www.vlfeat.org/matconvnet/models/imagenet-vgg-m-2048.mat.
mv  imagenet-vgg-m-2048.mat imagenet-vgg-m-2048-cut.mat

I can download the  imagenet-vgg-m-2048.mat from the matconvnet/model , but  I don't know where to find the imagenet-vgg-m-2048-cut.mat  file ?   what does the 'mv'  means ?   it's move?

change the name of the models.

run demo_CFWCF.m    the result shown below the picture.

is ~/bash_profile in the readme.md a file?

@iou1992  please complie the matconvnet corectly http://www.vlfeat.org/matconvnet/install/!

thank you very much.
run mex -setup  vl_compilenn  No problem appears.
but run demo_CFWCF.m the result shown below the picture.

@iou1992  You need to compile in gpu option

i choose to complie in cpu option . all the problem has solved. thank you

the result did not show the process of tracking.


[Feature] support \N as null element in array

Fixes #issue
create table tbl_array (col_int int not null, col_array array<int>)  distributed by hash(col_int) properties("replication_num"="1");

We could use \N to represent NULL value in stream load.
curl --location-trusted -u root:  -H "format: csv" -H "column_separator:\t" -H "strict_mode: true" -d '1\t\N' -XPUT http://<IP_ADDRESS>:18040/api/db0/tbl_array/_stream_load -v

+---------+-----------+
| col_int | col_array |
+---------+-----------+
|       1 | NULL      |
+---------+-----------+

This PR adds the support using \N to represent NULL element in array.
curl --location-trusted -u root:  -H "format: csv" -H "column_separator:\t" -H "strict_mode: true" -d '1\t[1,2,\N]' -XPUT http://<IP_ADDRESS>:18040/api/db0/tbl_array/_stream_load -v

+---------+-----------+
| col_int | col_array |
+---------+-----------+
|       1 | [1,2,null]|
+---------+-----------+

What type of PR is this:

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)


Change custom System data from TensorBlock to TensorMap

This allows for more kinds of data to be stored.
Contributor (creator of pull-request) checklist

[x] Tests updated (for new features and bugfixes)?
[x] Documentation updated (for new features)?
[ ] ~Issue referenced (for PRs that solve an issue)?~

Reviewer checklist

[x] CHANGELOG updated with public API or any other important changes?

This is a prerequisite for #682, and we need to do the change ASAP for #797


Fix for HABTM associations when updated within 1 transaction

When updating 2 models with a HABTM association, and using
accepts_nested_attributes_for, the association was using the
version ID instead of the transaction ID to reference the change.
This was braking the association logic and preventing proper
reification.

This looks good, thanks Sam. Please add a changelog entry.

Thanks, Sam! Merged offline as 4ad6254b742c535a133687d03ec74abbf44b6a1f with tiny fix to changelog.


Refactoring Square.tsx, Fixed selected square problem

After adding last commits from @xbaran4 (Logo). The game is not rendering right. Before this it was all working.
fixes#14

I think the problem is with new classes in Game.css. Could you look into it @xbaran4 ?

I think the problem is with new classes in Game.css. Could you look into it @xbaran4 ?

Nevermind I found the problem. I must have missed the class while rebasing master...
God I should go to sleep...


get rid of class hierarchy for record store.

The general idea was that the base class BaseRecordStore is stateless and does disk writes. Subclasses can use in-memory data structures to speed up the read needed to calculate the writes. The in-memory structures can be naive (e.g., a HashMap) or more sophisticated (e.g., TreeMaps to fast-find free space and to look headers).
Since the extension point was to be the in-memory caching or indexing that might itself spill to disk (e.g., use a MapDB navigable map) we should collapse the class hierarchy and someone to pass in a custom map.

I have flattened the class hierarchy will leave out customising the map as we are trying to keep things simple.


Line number is not printed in plugin 'Search in project' for Sublime Text 2

Not sure what happens here, but the line number is not part of the output from ag when Sublime Text 2's plugin 'Search in project' is running it.
The same happens when running it "manually" through Sublime Text's console, that is, by using Python's subprocess.Popen(...) in the console. The output from this is:
<filename>:<line>

If I try to include the --column option, this is the output:
<filename>:<column>:<line>

#943
It's been almost 6 years, I wish we could get this fixed...


Locale switching

This updates #288 with support for switching between available translations.
Notable changes:

List available translations in the footer of the site
Auto-redirect to locale preferred by your browser settings if a translation is available
Sets a cookie to remember the preferred locale and redirect to url for that locale

FYI @webknjaz @lijiangsheng1 @nandomoreirame

Merging into i18n, but there will still be time to review before it lands in gh-pages

Awesome ^^


Lane change module development plan

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I've agreed with the maintainers that I can plan this task.

Description
Lane change module has features to plan lane changing to arrive goal.
The features implemented in the current lane change module are following:

Driving lane planning

To arrive goal, it plans when and where to change lanes
The module also has a feature to change lanes by a request from operators

Safety check
Blinker control
Path generation (now improving)
Aborting lane change (now improving)

To make it more efficient and safer, some issues remain:

Improving path planning

Path planning more like a real driver to improve feeling of riding

Improving aborting lane change

To abort more safely, improving aborting behavior planning is required

Planning with obstacle avoidance
Dynamic route planning

For example, detour if lane change is not possible due to traffic jams
Common issue with mission planner

Interactions with other cars

For example, get in a car platoon in a traffic jam
Indication of intention by blinker

Perform multiple lanes lane change efficiently.

Currently, multiple lanes lane change is performed by separating the behavior into several single lane changes.

Topic hz is currently an issue for lane change module.

It will be nice if we can reduce the time on the collision assessment.

Purpose
For more efficient and safer lane changes, the remained issues should be resolved.
Possible approaches
We are currently working on the following issues:

Improving path planning

Planning including acceleration during lane change
Consideration of curvature according to vehicle speed

Improving aborting lane change

Scenario enumeration
Reconsider criteria for returning current lane or entering target lane

Planning with obstacle avoidance

Cooperating with avoidance module in behavior path planner

Definition of done
Resolve remained issues.

Recent updates.
Path generation

https://github.com/autowarefoundation/autoware.universe/pull/3756
https://github.com/autowarefoundation/autoware.universe/pull/4033
https://github.com/autowarefoundation/autoware.universe/pull/3991
https://github.com/autowarefoundation/autoware.universe/pull/3965
https://github.com/autowarefoundation/autoware.universe/pull/3924
https://github.com/autowarefoundation/autoware.universe/pull/3762
https://github.com/autowarefoundation/autoware.universe/pull/3750
https://github.com/autowarefoundation/autoware.universe/pull/3705

Safety check

https://github.com/autowarefoundation/autoware.universe/pull/4105
https://github.com/autowarefoundation/autoware.universe/pull/4172
https://github.com/autowarefoundation/autoware.universe/pull/2704
https://github.com/autowarefoundation/autoware.universe/pull/2704

Lane change cancel framework

https://github.com/autowarefoundation/autoware.universe/pull/3566
https://github.com/autowarefoundation/autoware.universe/pull/4080
https://github.com/autowarefoundation/autoware.universe/pull/4083

Turn signal

https://github.com/autowarefoundation/autoware.universe/pull/4115
https://github.com/autowarefoundation/autoware.universe/pull/3983

@TakaHoribe @shmpwk
All the linked PRs seemed to be merged. Is this issue ready to be closed?

@mitsudome-r Thank you for your comment. Yes, recently all lane change task has been completed. It would be nice if we could show the result of this development.
@rej55 Can we close this issue? Is ok, please summarize the current status (what we can/cannot do) in this issue.

Lane change development results
Completed items
Improving path planning

Planning including acceleration during lane change
Consideration of curvature according to vehicle speed

Improving aborting lane change

Scenario enumeration
Reconsider criteria for returning current lane or entering target lane

Planning with obstacle avoidance

Cooperating with avoidance module in behavior path planner

Improving safety check

Filtering objects to exclude unrelated objects

Not completed items
Blinker control for driver to driver interaction
Aborting path generation

Asymmetric path generation

Path generation without PathShifter

Some improvements

Path planning at terminal of lane
Stabilize safety check functions

Refactoring


Introduce CI tools

Poetry (dependency management)
PyTest (unit testing)
Ruff (linting, formatting)
Pre-commit hooks (git workflow)
MyPy (linting, static type checking)
GitHub Actions (CI)
Fire (Cli Helper)
Poe (Task Runner)
Pydantic (Data model consistency)
Pydantic Settings (data models from configuration files)
FastAPI ([REST] API toolkit)

missing:

client http library: request or aiohttp (sync vs async)

QA und GEN können via poetry/poe standalone gestartet werden, wenn alles richtig konfigueriert ist.
poetry poe frontend qa
poetry poe frontend gen

Die ganze LLM Logik habe ich aus den streamlit-Klassen heraus in das "Direct-Interface" geschoben.

Ich habe jetzt auch noch qa_service so angepasst, dass man Dokumente hochladen kann.

@Ashtonville, @Depo14: I need (would like to have :)) the approval of at least one person to go ahead. So is there more to do here or do you have further questions?

@Ashtonville, @Depo14: I need (would like to have :)) the approval of at least one person to go ahead. So is there more to do here or do you have further questions?

We have both problems to start the new version. So we are not be able to check if anything is alright.
We have the problem to delete the old package under 3.10 because we switch to 3.11.
Also we have the problem that python can't find the module team_read altough it is a folder.

Did you check the Dev.md for info about how to use poetry and poe?

@Depo14, please let me know if you face further issues. I don't want to merge broken or incomplete code.

@Depo14, please let me know if you face further issues. I don't want to merge broken or incomplete code.

If I now upload a file, this error message appears after a short time:
PermissionError: [Errno 13] Permission denied: mylocalpath\\Llama-2-Open-Source-LLM-CPU-Inference\\tmpin2g2ecltxt The above exception was the direct cause of the following exception: RuntimeError: Error loading mylocalpath\\Llama-2-Open-Source-LLM-CPU-Inference\\tmpin2g2ecltxt
it seems to lie in the function
documents = loader.load() in qa_service add_file

Okay, I have an idea why this is the case.
Currently, the 'uploaded' content is saved into a temp file (located at the current directory) and then loaded with the appropriate loader. Windows is more picky when it comes to access already opened files. Closing the temp file will usually delete it. If I keep the temp file I need to manually delete it after the loading which makes stuff more complicated. I haven't found a way to use the loaders with in-memory files but I guess I will check again.

poetry now installs the cpu version of torch by default unless for macos since there is none to be found in the torch repo. I also reproduced the bug and it should be fixed now

I added tests for gen now. I will go ahead and merge this now. if you have problems please open a new issue.


In the keyboard_input_events example, does the EventReader<KeyboardInput> need to be mut since we're only reading from it?

https://github.com/bevyengine/bevy/blob/8ba9571eedada4f3ff43cdf1402670b7fe7c280d/examples/input/keyboard_input_events.rs#L13

keyboard_input_events.iter() requires &mut self.
I believe this is because events track when they are read to ensure the same event is never read twice.

Makes sense. Thanks for the quick answer!
Closing.


Additional features for DoA Duping widget

Some more features that would be useful:
-allow to set the range for which Duping mobs are shown in the list
-Additional Counters for Souls/Other Mobs in Custom Range & Compass Range
Unrelated to the widget but another really nice feature would be changing the appearance of mobs on the minimap when they use Call to the Torment.

it'd be handy if you could have their health bars change colour when they're below 50%, and/or round down the displayed percentage, so you can clearly see if a mob is at 49.9% or 50.1%

is there any logic to the order that mobs appear in the list? it's quite awkward to click on them when new spawns can appear halfway up the list, pushing down all the ones below it

Should be ordered by health


Players cant see the needed cost in chat post "Too Expensive"

I'm having an issue where I as an operator can see the too expensive cost in chat, but when players try they cannot. I'm assuming I may need to give my players the anvil.use permission, but I also don't want them to be able to just open an anvil without having one. Any way to fix this?

The steps are to an item that is too expensive and not have enough xp to add what you are trying to add to it, it doesn't show up in chat how much you need. I am on the latest version- 1.4.0, the server is running Paper for 1.19.4.
Also found another thing where players couldn't use formatting codes in the anvil, just color. For example bold - &l.
Had one of my players help me test, they could only see the cost once I gave them the "anvil.*" permission. I had given them all the listed permissions before I did that and they couldn't. Naturally I don't want them to have ALL the permissions, just the ones for virtual anvil, color, formatting, and seeing the too expensive cost. Are there some secret permissions?

I could not find the bug. Please post the detailed steps or a screenshot/video if possible. Regarding the permissions, they seem to work fine as well...


Add Random_String Implementation

Add Random_String Implementation

Hi @jamesptruitt can you please add:

an example
run FMT (or use pre-commit from the rover ;))
and we should be good to go!

Hello @arnaudlh,
Added the example and formatted the the files


new DropoutAllchannels operator

Like Dropout operator, but drops / keeps entire pixels from image or image-like input records (such as the output of 2D convolution)
Retrying this as a new pull request (See #1490 ) . Last time, Travis seems to have picked up an outdated version of one file..

@antinucleon can you review this?

Backward doesn't seem correct. Could you add a test case?

You're right, I should have checked the Backward implementation. This variant should be correct now, I also changed the spelling of DropoutAllchannels to DropoutAllChannels

This pull request is probably ready to merge. Can somebody review this ? :) Thanks

close this for now as it is likely can be implemented together with #2511

Any update on this? Has this dropallchannels operator been one of the official operators? I did not find it in the document.


2 DAO on-boarding flow maps

(CONFIRM WITH UX HOLON @Tyler @Gantz.Design @Dan.Mercurius)

DELIVERABLE UPDATE
It is estimated that this deliverable is currently 70% complete.
Since the initial proposal, this deliverable has been identified as involving two components:

Discord Community (Short-to-Midterm) - A UX onboarding process for new Discord members which has been managed by the Marketing Holon, and
DAO Community (Mid-to-Long-term) – An engagement pathway for members entering a structured DAO that includes a functioning voting mechanism and tokenomics model.

DISCORD COMMUNITY (Present-to-Short-term)
The onboarding process for Discord members is through Discord invitation links available via the NFT-DAO proposal pages on Project Catalyst (IdeaScale), the NFT-DAO webpage and member invitations through social media. New DAO members are directed to the Discord #welcome page which includes links to an Airtable to support lite KYC onboarding. The #intro channel supports newcomers to and connect with potential collaborators, identify interest areas, and potential holon memberships (team building).
DAO COMMUNITY (Mid-to-Long-term)
May include a mandatory sign-up/registration that instantly qualifies as a KYC for the BOXCAR (if new members opt into the DAO). A profile/account can be set-up. For voting purposes, members can only register one wallet to vote at a time, and only registered (Tier 4) members can vote on special polls while anyone can vote on general polls. Onboarding funnels for a DAO roll-out are shown in the Tokenomics Framework here: https://github.com/NFT-DAO/Governance-HOLON/issues/19
The final stage of this deliverable will require completion of a DAO onboarding flowchart, expertise review and sign-off by core contributors.
NOTE: This work has currently been achieved while awaiting the release of $19,893 allocated by the NFT-DAO to the Governance Holon to achieve project deliverables. See fund allocations here: https://cardano.ideascale.com/a/dtd/Comprehensive-NFT-Framework-Collab/334521-48088


Gdx.input.justTouched() not working correctly on iOS

Hi, using Gdx.input.justTouched() on iOS will recognize only the first touch, all other touchs (second finger & co.) will not be recognized.
An example:
for(int i = 0; i < 5; i++) {
    if(Gdx.input.isTouched(i)) {
        // This is recognized correctly for all the fingers
        if(Gdx.input.justTouched()) {
            // This is true only with the first finger, if i am keep touching the screen with the first finger and i touch antoher point of the screen with another finger is not recognized
        }
    }
}

On Android is working correctly for all the touch/fingers.

https://github.com/libgdx/libgdx/blob/master/backends/gdx-backend-robovm/src/com/badlogic/gdx/backends/iosrobovm/IOSInput.java#L616 looks like the culprit but I can't test on IOS at the moment, someone else will have to!

Any news?

@Tom-Ski Would it be out of place to ask how to test that change? As I also need to solve this issue.

Downloading libgdx source, making the change to the line linked (should be >= 1), testing brismas code.

Fixed.

I've got a bug with Gdx.input.justTouched in iOS version of my game. See the video here:
https://www.youtube.com/watch?v=RdAs05TIw1U
Android and Desktop versions works fine. iOS version works on some devices. But not on my device. Sometimes it's triggered sometime not. The touchscreen is good I've checked it by other app. No problem with it.
Gdx.input.getX(), Gdx.input.getY() always return correct values, But Gdx.input.justTouched() don't triggered and wherefore I miss the touches.
Seems like IF statement in this line : https://github.com/libgdx/libgdx/blob/master/backends/gdx-backend-robovm/src/com/badlogic/gdx/backends/iosrobovm/IOSInput.java#L621 is absolutely wrong. justTouched flag must be set to ON on every BEGAN event phase. There is no reason to check numTouched. numTouched seems like a completely superfluous in this place. Android version set justTouched to true at touchDown event. iOS must to do the same. Without additional rule.
I fixed this bug by re-writing the code to use my custom InputProcessor and just set my local m_justTouched variable to true in touchDown() method. At the end of Game.render() I set m_justTouched to false. And now instead of using Gdx.input.justTouched() I use my m_justTouched check.  Now all works fine.
So, I think it will be useful to inform you about this problem so that you remove this unnecessary IF check.


Redirect not working as expected

A customer reported:
Going to https://api.dartlang.org/apidocs/channels/stable/dartdoc-viewer/dart:core.List does not redirect to https://api.dartlang.org/1.12.0/dart-core/List-class.html as we would expect.
The customer arrived at the link because that's how Chrome was auto-completing "dart list api" for him.
Actual: goes to the index of the docs.

cc @keertip

Also doesn't redirect /dart_math.html, which Google has a top link.

We should also consider redirecting /stable/dart-async to /stable/dart-math/dart-math-library.html

CL https://codereview.chromium.org/1323233002/

site updated. Please file more bugs if you see a redirect that should be working, but is not.


Can it run on multi-GPU?

Thanks for your contributions. I would like to know whether it can be deployed on multi-GPU to allow the use of more VRAM?

@dvmazur @lavawolfiee Can you please kindly address this question? I'd be happy to do this myself if it's not already possible, which I don't think it is, if you could point me to where I'd need to make changes.

Hi!
Sorry for the long reply.
Running the model on multi-GPU is not currently supported. Currently, all active experts are sent to cuda:0. You can send an expert to a different GPU by simply specifying a different device while initializing MixtralExpertWrapper.
Keep I'm mind that you would need to ballance the number of active experts between your GPUs. This logic could be added to the ExpertCache class.

By the way, one of our quantization setups compressed the model to 17Gb. This would fit into the VRAM of two T4 GPUs, which you can get for free on Kaggle.
Have you looked into running a quantized version (possibly ours) of the model using tensor_parallel?

May I ask which quantization setup allowed compression down to 17Gb, or if you could point me to a file that contains that setup please?

It's the 4-bit attention and 2-bit expert setup from our tech-report. I suppose the weights can be found here. Let's summon @lavawolfiee just in case I'm mistaken.

the model seems to only occupy ~11Gb on a single GPU without an OOM error, but then at inference there's no utilization of the GPU cores throughout (though the VRAM is occupied) until the kernel crashes

Could you provide a bit more detail? I'll look into it as soon as I have the time to.

It's the 4-bit attention and 2-bit expert setup from our tech-report. I suppose the weights can be found here.

Yes, you're right

May I ask which quantization setup allowed compression down to 17Gb, or if you could point me to a file that contains that setup please?

It's the 4-bit attention and 2-bit expert setup from our tech-report. I suppose the weights can be found here. Let's summon @lavawolfiee just in case I'm mistaken.

This seems to be the same setup I have used in the code I provided, which occupies ~11Gb VRAM and ~23Gb of CPU RAM and then crashes the kernel at inference.

the model seems to only occupy ~11Gb on a single GPU without an OOM error, but then at inference there's no utilization of the GPU cores throughout (though the VRAM is occupied) until the kernel crashes

Could you provide a bit more detail? I'll look into it as soon as I have the time to.

Absolutely, what information are you looking for?

Absolutely, what information are you looking for?

A stacktrace would be helpful.


Cannot use docker socket in a container

Describe the bug
I want to use Host Docker socket in Container.
$ docker run --rm -it -v $HOME/.orbstack/run/docker.sock:/var/run/docker.sock docker info

I'm sot sure if it is possible to use host docker socket in container, is there any suggestion?
To Reproduce

Check Host Docker health:

(host) $ docker info
Client:
 Version:    27.3.1
 Context:    orbstack
 Debug Mode: false
 Plugins:
  buildx: Docker Buildx (Docker Inc.)
    Version:  v0.18.0
    Path:     /Users/chivincent/.docker/cli-plugins/docker-buildx
  compose: Docker Compose (Docker Inc.)
    Version:  v2.29.7
    Path:     /Users/chivincent/.docker/cli-plugins/docker-compose

Server:
 Containers: 5
  Running: 0
  Paused: 0
  Stopped: 5
 Images: 9
 Server Version: 27.3.1
 Storage Driver: overlay2
  Backing Filesystem: btrfs
  Supports d_type: true
  Using metacopy: false
  Native Overlay Diff: true
  userxattr: false
 Logging Driver: json-file
 Cgroup Driver: cgroupfs
 Cgroup Version: 2
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local splunk syslog
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: 207ad711eabd375a01713109a8a197d197ff6542
 runc version: d7735e388ef5eecbd60d93bfbe5afe0f3fbc8a6b
 init version: de40ad0
 Security Options:
  seccomp
   Profile: builtin
  cgroupns
 Kernel Version: 6.11.9-orbstack-00279-g4cf512143f2e
 Operating System: OrbStack
 OSType: linux
 Architecture: aarch64
 CPUs: 10
 Total Memory: 7.81GiB
 Name: orbstack
 ID: 76028f10-b583-4953-9ea8-e6c65a25c109
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 Experimental: false
 Insecure Registries:
  <IP_ADDRESS>/8
 Live Restore Enabled: false
 Product License: Community Engine
 Default Address Pools:
   Base: <IP_ADDRESS>/24, Size: 24

Boot a Docker Container

(host) $ docker run --rm -it -v $HOME/.orbstack/run/docker.sock:/var/run/docker.sock docker info
Client:
 Version:    27.3.1
 Context:    default
 Debug Mode: false
 Plugins:
  buildx: Docker Buildx (Docker Inc.)
    Version:  v0.18.0
    Path:     /usr/local/libexec/docker/cli-plugins/docker-buildx
  compose: Docker Compose (Docker Inc.)
    Version:  v2.30.3
    Path:     /usr/local/libexec/docker/cli-plugins/docker-compose

Server:
ERROR: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
errors pretty printing info

Expected behavior
The /var/run/docker.sock should be connectable in container.
Diagnostic report (REQUIRED)
No response
Screenshots and additional context (optional)
No response

Fixed in the next version, so your original command should work as well.

Released in v1.9.0.


Update the stage number of decorator proposal

Thanks - dupe of #2348

Thanks - dupe of #2348

My pleasure

Thanks - dupe of #2348

It's pending on what in this https://github.com/microsoft/TypeScript-Website/pull/2348

See: https://github.com/microsoft/TypeScript-Website/pull/2348#issuecomment-1552220140


Exception: incorrect compressed length: 1913

Common issues before reporting
Have you modified the save files
If you have, please ensure that the JSON files are valid.
Have you tried the latest release
Please download the palworld-save-tools-windows.zip file from releases in case it's been fixed.
Describe the bug
A clear and concise description of what the bug is.
Checking if Python is installed as python3
D:\Python310\python3.exe
C:\Users\timot\AppData\Local\Microsoft\WindowsApps\python3.exe
Found Python at python3
Python version:
Python 3.10.8
Converting H:\Pal\Saved\F4DEA5DF13C5415AB200CC02F68CA7D5\WorldOption.sav to JSON, saving to H:\Pal\Saved\F4DEA5DF13C5415AB200CC02F68CA7D5\WorldOption.sav.json
Decompressing sav file
Traceback (most recent call last):
  File "H:\Pal\palworld-save-tools-windows-v0.20.0\convert.py", line 160, in <module>
    main()
  File "H:\Pal\palworld-save-tools-windows-v0.20.0\convert.py", line 71, in main
    convert_sav_to_json(
  File "H:\Pal\palworld-save-tools-windows-v0.20.0\convert.py", line 105, in convert_sav_to_json
    raw_gvas, _ = decompress_sav_to_gvas(data)
  File "H:\Pal\palworld-save-tools-windows-v0.20.0\palworld_save_tools\palsav.py", line 33, in decompress_sav_to_gvas
    raise Exception(f"incorrect compressed length: {compressed_len},{len(data)}")
Exception: incorrect compressed length: 1913,1926

Copy of .sav or .sav.json files
If possible, attach the .sav or .sav.json file. Add to a zip file to compress it down from gigabytes down to megabytes to make it manageable.
WorldOption.zip

Hello, Having the same issue but with the Player File I am trying to convert. It is coming from a dedicated server. I have tried to convert the other characters on the account and the same issue. I am able to covert the Level,  and other level sav in that directory.  Just having the issue with any of the player sav files.
<--------
Decompressing sav file
Traceback (most recent call last):
File "D:\Install Games\PalWorld\Pal_SaveGameData_test\palworld-save-tools-windows-v0.22.0\convert.py", line 160, in
main()
File "D:\Install Games\PalWorld\Pal_SaveGameData_test\palworld-save-tools-windows-v0.22.0\convert.py", line 71, in main
convert_sav_to_json(
File "D:\Install Games\PalWorld\Pal_SaveGameData_test\palworld-save-tools-windows-v0.22.0\convert.py", line 105, in convert_sav_to_json
raw_gvas, _ = decompress_sav_to_gvas(data)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\Install Games\PalWorld\Pal_SaveGameData_test\palworld-save-tools-windows-v0.22.0\palworld_save_tools\palsav.py", line 40, in decompress_sav_to_gvas
raise Exception(f"incorrect compressed length: {compressed_len}")
Exception: incorrect compressed length: 13906
--------->


Change chalk into devDependencies

Hi.
I saw a plan to publish to npm.(#41) It's great plan! !
I saw package.json.
I think that chalk should be included in devDependencies, not dependencies.
Because chalk is not a part of water.css, it is a library for development.
When installing with npm command, chalk will also be installed in node_modules.

Good catch! :shipit:

Great catch @kimulaco, you were absolutely right. Thanks for the contribution!


Take Into Account Special Characters when creating SSM parameters

Environment information
System:
    OS: macOS 14.1.1
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
    Memory: 340.21 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.18.2 - ~/.nvm/versions/node/v18.18.2/bin/node
    Yarn: Not Found
    npm: 10.2.1 - ~/.nvm/versions/node/v18.18.2/bin/npm
    pnpm: 8.12.1 - /usr/local/bin/pnpm
    bun: Not Found
    Watchman: Not Found
  npmPackages:
    @aws-amplify/backend: ^0.6.0 => 0.6.0
    @aws-amplify/backend-cli: ^0.9.2 => 0.9.2
    aws-amplify: ^6.0.8 => 6.0.8
    aws-cdk: Not Found
    aws-cdk-lib: Not Found
    typescript: ^5.3.3 => 5.3.3

Description
Currently if my package name happens to have a special character, sandbox fails with the error
ValidationException

The parameter doesn't meet the parameter name requirements ... It must use only letters, numbers, or the following symbols: . (period), - (hyphen), _ (underscore). Special characters are not allowed.

In the case you have a reason to name you package with @ (for example in a monorepo setup), the sandbox deploy fails as it seems to depend on using the package name to set the SSM params.

Looks like we need to do the same sanitization of project name for constructing parameter paths that we use for stack naming. Thanks for reporting, marking as a bug.


Add sessions recording support

We have discussed two approaches here.

Use the integrated recording feature in Janus, which produces one .mjr per each audio and video stream. We could use then the streaming plugin to recreate the meeting in a similar way to what is done in this demo (code available) https://janus.conf.meetecho.com/recordplaytest.html We would probably need to store some additional data (like the list of participants) in order to be able to recreate the session effectively. Data channels would be most likely lost, since I don't think they are currently recorded by Janus. The good part is that the recording could be "interactive", i.e. allowing selection of the participant to highlight in each moment, browser resizing, layout rearranging and so on.

Connect to the room with a "ghost" participant that will run a browser and simply record what is rendered in the browser. It needs almost no special support server-side and everything will be recorded (including chat messages). But the result would not be so flexible.

can we use this for recording of webrtc streams ? http://lynckia.com/licode/

We can already record the audio and video streams separately server side with janus. That's trivial. What we want is to reproduce a full meeting "like if you were there", with all the participants, the chat and all that.
We already considered Licode as a replacement for janus in the server part. But we discarded it. I don't remember the details of the decision, but I think it has to do with the fact that it was hard to install and configure, with a lot of nasty dependencies like Java.
Still, having an "external" tool based on licode (not installed in the Jangouts server) would be acceptable.

Just to add some information about how challenging the option (1) can become, although it's the preferred one by @imobach and myself.
https://groups.google.com/forum/#!searchin/meetecho-janus/ancor/meetecho-janus/pB0EK0zVix0/bNDp-zun0rEJ  Beware this is an old conversation and things could have changed meanwhile in the Janus world (although I don't expect that).

@ancorgs The information that data channels are not supported seems to be outdated. There is a demo which demonstrates data channel processing.

Of course data channels are supported. We use them extensively in Jangouts.
What is not supported is server-side recording of the data channels. Only
video and audio can be recorded and eventually played back.
El 22/03/2016 17:25, "Andrej Sabnew"<EMAIL_ADDRESS>escribió:

@ancorgs https://github.com/ancorgs The information that data channels
are not supported seems to be outdated. There is a demo
https://janus.conf.meetecho.com/echotest.html which demonstrates data
channel processing.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/jangouts/jangouts/issues/34#issuecomment-199917344

@sandr3j Actually it was me who contributed the data-channels support to the videoroom plugin by copy&paste&adapt from the echo-test plugin
https://github.com/meetecho/janus-gateway/pull/82
The fact that it's supported in videoroom and echo test plugins does not imply:
a) that it's supported in the streaming plugin (which we will most likely use for playback)
b) that is properly recorded server-side
So be open to the possibility of having to closely collaborate with janus developers (that are really helpful and nice) or even create a pull request for it (something nice to include in your proposal, btw).

@sandr3j Never mind. I have just read the draft of your proposal and I see you have already considered all the implications, including contributions to janus and much more. Feel free to ignore my last comments :wink:

Maybe interesting for our purposes https://groups.google.com/d/msg/meetecho-janus/xuwhOHxYUxI/MNu7NNAfBgAJ


[CSL-90] Consider using different implementation of FTS

@gromak
From slack: http://i.imgur.com/1LQuk5N.png

@georgeee
This balances data structure (see screenshot) might be useful in different parts of system, e.g. client code.
Also, if we introduce Chepurnoy trees over account-balance mapping within CSL-45 or it's successors, it should probably be used here.
Let's return to the task after CSL-45 is done.

@shersh
CSL-45 is done. We can return to this task and discuss it.

@gromak
My understanding of CSL-45 is that it's not related, because we CT will store utxo, not balances. Correct me if I am wrong.

@gromak
As a result of CSL-265 we decided to store all balances in RocksDB, so we will implement FTS by iterating through balances, not Utxo. However, it still makes sense to consider using different implementation of FTS. For example, it may be bad to iterate through all balances (which are stored in RocksDB). Alternatively we can, for example, use B-tree.

@gromak
This issue doesn't make sense anymore. Currently we are using alternative approach with balances already.


Use annotation on CORS-enabled routes

I think it would be nice to be able to add an annotation to a route for which you want to enable CORS.

/**
* @Route("/your/cors/enable/route")
* @Method("POST")
* @Cors()
*/
public function login()
{
    return new Response("...");
}

You could optionally provide a key of a configuration, if you don't want to use the default values. e.g. @Cors("api")
In this way, you are far more flexibel in configuration (you loose al the pattern matching stuff) and it makes cors enabling more verbose.
Any thoughts?

+1

+1

:+1:

Yes

Sounds good yes I agree, but I am not sure if or when I'll have time to work on it so if any of you feels like sending a PR please do :)

+1

Closing as it seems nobody had any interest in pushing this further.


Handle ServerTimeouts while connecting to a thrift service

This update wraps the ThriftConnectionPool._acquire() call within a
try/finally block to ensure that the connection slot is returned to the
pool in case a ServerTimeout is raised.

👓 @spladug @diffyqgirl


add --color  flag to control color mode

Sometimes you want different behaviour than the auto detection. This flag supports the same options as ripgrep.
TTY detection is also move to stdout rather than stderr as colored output is written to stdout, not stderr.

I've also snuck in a commit improve (in my opinion) the error message when you forget the argument for --duration.


Removing GitHub Jobs and adding DevITjobs instead

GitHub jobs does not exist anymore: https://github.blog/changelog/2021-04-19-deprecation-notice-github-jobs-site

@bgoonz, would you mind merging it? :)


Customize MIME types

An email came in today about serving .swf files (old tech, but still used apparently). By default, Caddy serves binary files as, well, binary (application/octet-stream) which triggers a download. But in this case, the user wanted the browser to show the file, not download it to the user's Download folder. The Content-Type needed to be "application/x-shockwave-flash".
This was able to be achieved with the header directive but that assumes all the Flash content is in its own folder. Perhaps a mime or filetype directive is in order:
mime .swf application/x-shockwave-flash

Or multiple:
mime {
    .swf application/x-shockwave-flash
    # more here...
}

This would simply change the Content-Type header based on file extension rather than path.

mime sounds better.
I can work on this (provided someone hasn't started already) and I want to assume this is gonna be part of caddy core.

Yes, setting the proper Content-Type is a pretty important job of a server. I agree it'll be part of core.


Better support for flexible Azure handler signatures

Apparently Azure cannot discover the parameter types if the user handler extends AzureSpringBootRequestHandler and doesn't wrap the handleRequest() method, e.g.
public class FooHandler extends AzureSpringBootRequestHandler<Foo, Bar> {

	public Bar execute(Foo foo, ExecutionContext context) {
		return handleRequest(foo, context);
	}

}

It still works for me using the code above. Look at the sample in the project. If you are looking at master you will need snapshots.

Thanks, I found my problem. It was all about the pom.xml

I'll close it given quite a few improvement to  adapters in general as well as Azure specifically.
Please raise a new issue to address whatever may be missing now


Rename the Executable to nativelink

We need to rename the executable as the project has evolved far beyond content addressable storage.

#573


Transaction is expired

Hello,
I encountered an error like this:'CheckTx returned code 2 Transaction is expired  7e818cec09ba98ab4888de13d995307bdfd3261c86493e28e7634b15d9023a1b  9909343' when I used the demo which is called 'Building a Transaction' in the README.md.And I tried to set the expired field very large,but it didn't work. Isn't this sdk a newest version?

Thanks for submitting the issue, it's fixed, it was sending the data wrong to the endpoint


Allow parameter references

Allow reusable parameters using refs, as specified in https://github.com/OAI/OpenAPI-Specification/blob/master/fixtures/v2.0/json/resources/reusableParameters.json

@GuilhemN Can you take a look at this? The only problem I found so far is that the Parameters collection insists on using / as the unique identifier. That resolves to "/" for parameters that are references.

Thank you @sandermarechal!


TicketDataFormat and dependency injection

I notice with asp.net identity, you are forced to create the custom TicketDataFormat during ConfigureServices() like so:
  services.AddIdentity<User, SecurityRole>((a) =>
            {
                a.Password.RequiredLength = 8;
                a.Password.RequireNonAlphanumeric = false;
                a.Cookies.ApplicationCookie.Events = new CustomCookieAuthenticationEvents();
                a.Cookies.ApplicationCookie.TicketDataFormat = new SomeCustomFormat()

If SomeCustomFormat requires services such as a Logger or IHttpContectAccessor for example, how can we get them injected?
This differs from the CookieMiddleware which lets you do this when AppBuilder is available:

            Func<IHttpContextAccessor> httpContextAccessor = applicationBuilder.ApplicationServices.GetRequiredService<IHttpContextAccessor>;
            Func<ILogger<SomeCustomFormat>> loggerFactory = applicationBuilder.ApplicationServices.GetRequiredService<ILogger<SomeCustomFormat>>;

var customFormat = new CustomFormat(httpContextAccessor, loggerFactory);

 var cookieOptions = new CookieAuthenticationOptions()
            {
                LoginPath = loginPath,
                AccessDeniedPath = accessDeniedPath,
                AutomaticChallenge = true,
                AutomaticAuthenticate = true,
                AuthenticationScheme = "SomeAuthenticationScheme",
                TicketDataFormat = customFormat,
                CookieName = cookieName,
                ExpireTimeSpan = TimeSpan.FromMinutes(120)
            };

So how do we go about creating custom TicketDataFormat that has dependencies?

So underneath the covers, UseIdentity ends just doing:
            var options = app.ApplicationServices.GetRequiredService<IOptions<IdentityOptions>>().Value;
            app.UseCookieAuthentication(options.Cookies.ExternalCookie);
            app.UseCookieAuthentication(options.Cookies.TwoFactorRememberMeCookie);
            app.UseCookieAuthentication(options.Cookies.TwoFactorUserIdCookie);
            app.UseCookieAuthentication(options.Cookies.ApplicationCookie);

You can remove the UseIdentity call and configure the TicketDataFormat explicitly instead which should work.


Add H3 adapter

Resolves #623
Usage:
import { createApp, createRouter } from 'h3';
import { createBullBoard } from '@bull-board/api';
import { H3Adapter } from '@bull-board/h3';

const serverAdapter = new H3Adapter();
serverAdapter.setBasePath('/ui');

createBullBoard({
  queues: [...],
  serverAdapter,
});

export const app = createApp();

// your app router
const router = createRouter();
router.use(...)

app.use(router);

// Add the bullboard handlers
app.use(serverAdapter.registerHandlers());

@felixmosh I would consider this complete, let me know if there are any other changes needed.

@genu Are you able to spin-up an example repository with this? I'm trying to test this by copying the libs over to my repo here -> https://github.com/AidanHibbard/bull-board-h3-test/
But I'm running into errors when I try to set up the route following your example...
There's a good chance I'm missing something.

@genu Are you able to spin-up an example repository with this? I'm trying to test this by copying the libs over to my repo here -> https://github.com/AidanHibbard/bull-board-h3-test/
But I'm running into errors when I try to set up the route following your example...
There's a good chance I'm missing something.

The example that I provided in this PR is for h3. In your repository, you're trying to applying it in a Nuxt context.
Because Nuxt hijacks the routing, you can't really use the example I provided as is.
For nuxt, you have to

Define your route path as:

@genu That worked swimmingly, thanks

Excellent! 😎

Thank you for you contribution 🙏🏽

Released in v5.13.0 🎊

@AidanHibbard If you are using nuxt, I've created a module that abstracts a lot of what this adapter is doing.
Have a look at: https://github.com/genu/nuxt-concierge

@genu This looks great! Looks pretty similar to the module @productdevbook wrote for Pergel.