Added the Russian translation of README.md

We don't have localized version of README or any documentation, i appreciate the effort, but why do you feel this is needed? Is it useful enough to justify having to maintain multiple versions of the documentation in the future? Keep it mind that having multiple versions means they need to be updated together, so if someone updates the english version, and we have 50 languages to update, then we need potentially 50 contributors to contribute a corresponding update to their version.

@leader2one We really do appreciate the contribution, and would love to see you contributing again in the future. As @tshirtman  pointed out though, a Russian translation is not a realistic goal at this point. Please don't be discouraged, but perhaps look at other ways to contribute? Fixing reported bugs? Tutorials? Adding tests?
Thanks again. Remember, closing this does not does not belittle your effort, it's just something we cannot use :-)


test: Remove deprecated SSM alias from E2E tests

Fixes #N/A
Description

Include changes of this PR https://github.com/aws/karpenter-provider-aws/pull/5460
This should fix drift and expiration test for release-v0.33.2 branch
This will prevent future failure for the release process

How was this change tested?

N/A

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 82.45%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
4914

Relevant Lines:
5960

💛  - Coveralls


iOS: Click to copy

I was evaluating ntfy as a short of clipboard-sharing / link-sharing mechanism between my Linux devices and my iPhone. Everything was going well until I hit the wall of not being able to copy the notification text on my iPhone.

I am so sorry about this. I really want to work on this and it should be easy, but it wasn't simple to do when I released the initial version of the app. I will eventually get to it, but right now I have some personal things that take priority.
Try tapping the text and see if it copied it. I mayy have left the "copy text" feature in there without giving any visual indication that it actually copied it. iOS doesn't have "Toast" messages like Android. I'm not 100% sure if I left the code for that in the app though.

Tapping the text does indeed copy it.

Just had a check -- can confirm, it's copying, just not showing popup message the same way Android app shows the toast. It's a bit confusing, but it's nice to know copying silently works via this issue :)

I am so sorry about this. I really want to work on this and it should be easy, but it wasn't simple to do when I released the initial version of the app. I will eventually get to it, but right now I have some personal things that take priority.
Try tapping the text and see if it copied it. I mayy have left the "copy text" feature in there without giving any visual indication that it actually copied it. iOS doesn't have "Toast" messages like Android. I'm not 100% sure if I left the code for that in the app though.

Can confirm silent copy works on my iPhone 12 Pro Max, iOS 14.4.1.
But the copy is not consistent sometimes doesn't work, will be better if some copy indicator (toaster) will show if possible. Thanks.

Would be great if one could also copy the topic name (I checked if a [long] tap copied it but no luck..)

I've been using the IOS PWA app which works really well.  However the same 'click to copy' behavior does not exist.
Would it be difficult to add a 'copy' button to each notification that can trigger a copy to clipboard?


When changing GIFs, the animation stops working

Hello,
I stumbled upon a strange problem in my program. This function is called once one of the turtle's properties change (it changes direction etc.). I upload the GIF  image into the turtle.Body (Body is a public Image defined in class Turtle). at the beginning of the game and animation works just fine. However, when the function attempt to change the GIF image, the animation stops working, even though I'm using the same procedure to set the GIF image. If I try to change the GIF image of an Image defined in XAML, it, for some bizarre reason, works.
I tried using the other library of yours, XamlAnimatedGif,
AnimationBehavior.SetSourceUri(turtle.Body, gifSourceTurtle);
but it unfortunately didn't work either.
Any help is appreciated! :)
private void UpdateImages()
{
    if (turtle.IsMoving && turtle.IsDirectionForward)
    {
        gifSourceTurtle = new Uri(PATH_DIRECTION_FORWARD, UriKind.Relative);
        gifSourceDirection = new Uri(PATH_DIRECTION_BACKWARDS, UriKind.Relative);
    }
    else if (turtle.IsMoving && !turtle.IsDirectionForward)
    {
        gifSourceTurtle = new Uri(PATH_DIRECTION_BACKWARDS, UriKind.Relative);
        gifSourceDirection = new Uri(PATH_DIRECTION_FORWARD, UriKind.Relative);
    }
    else if (!turtle.IsMoving && turtle.IsDirectionForward)
    {
        gifSourceTurtle = new Uri(PATH_DIRECTION_FORWARD_STOPPED, UriKind.Relative);
    }
    else if (!turtle.IsMoving && !turtle.IsDirectionForward)
    {
        gifSourceTurtle = new Uri(PATH_DIRECTION_BACKWARDS_STOPPED, UriKind.Relative);
    }

    bitmapBody = new BitmapImage();
    bitmapBody.BeginInit();
    bitmapBody.UriSource = gifSourceTurtle;
    bitmapBody.EndInit();

    ImageBehavior.SetAnimatedSource(turtle.Body, bitmapBody);

    if (gifSourceDirection != null)
    {
        bitmapBody = new BitmapImage();
        bitmapBody.BeginInit();
        bitmapBody.UriSource = gifSourceDirection;
        bitmapBody.EndInit();

        ImageBehavior.SetAnimatedSource(imgDirection, bitmapBody);
    }
}

I tried using the other library of yours, XamlAnimatedGif,
AnimationBehavior.SetSourceUri(turtle.Body, gifSourceTurtle);
but it unfortunately didn't work either.

XamlAnimatedGif takes a URI, not a BitmapSource.

Hi @ondrejsvorc,
Sorry you're having trouble. Not sure what could be causing this... it should work fine.
Is the ImageBehavior.AutoStart property set to true?

Well, I tried the following: ImageBehavior.SetAutoStart(turtle.Body, true); and it didn't make it work.

I tried using the other library of yours, XamlAnimatedGif,
AnimationBehavior.SetSourceUri(turtle.Body, gifSourceTurtle);
but it unfortunately didn't work either.

XamlAnimatedGif takes a URI, not a BitmapSource.

Yeah, thanks. I mistyped there. However, it doesn't make a difference. The problem still lasts.

Well, I tried the following: ImageBehavior.SetAutoStart(turtle.Body, true); and it didn't make it work.

It's set to true by default, but I wonder if maybe you had disabled it
Anyway, in order to help you, I'm going to need to see more of your code. Are you able to share your project? If not, could you try to create a simple repro that you could share?

Well, I tried the following: ImageBehavior.SetAutoStart(turtle.Body, true); and it didn't make it work.

It's set to true by default, but I wonder if maybe you had disabled it
Anyway, in order to help you, I'm going to need to see more of your code. Are you able to share your project? If not, could you try to create a simple repro that you could share?

Sure. There you have it all https://github.com/ondrejsvorc/TurtleWalk

Hi @ondrejsvorc,
Thanks for the repro! But I'm not sure what I'm supposed to do to reproduce the problem. It seems the only thing I can do is launch level 1, where I see the turtle cross the screen but I can't do anything. The UpdateImages method is never executed.
How should I reproduce the problem?

You have to click on the images in the top right corner. One of them changes direction of the turtle and the other one stops or starts her movement. Once you do so, one their Click methods is executed - at the end of the method there is UpdateImages() being called. I hope it helps!

Strange... on the PC where I first tried it, the control buttons didn't show up. Neither did the language switch buttons, so the app was in Czech. I just tried on another PC, and now I see those buttons.
I was able to reproduce the issue, however I don't really understand what's going on... The problem is related to the fact that you're using relative URIs for your images. This causes the animation loading to be deferred, and it should be retried when the base URI is known, but for some reason, that doesn't happen.
So, I don't know the exact cause, but there's an easy fix: use absolute URIs.
i.e. instead of
./Resources/Images/Turtle/turtle_direction_forward.gif

use
pack://application:,,,/Resources/Images/Turtle/turtle_direction_forward.gif

(and remove UriKind.Relative when you create the Uri instances)

Hello,
I've been thinking a bit and I came to realise I use margins in XAML to position its content. Hence everyone sees my game wrongly on smaller monitors. I'm aware it is a bad practise and I will replace it, probably by Grid.RowDefinitions and Grid.ColumnDefinitions.
Thanks a lot for solving the problem. I really do appreciate your time!
Have a nice rest of your day!

You're welcome. Good luck with your project!


CoffeeScript to TypeScript

:+1: :clap: :tada: :birthday: :gift: and a shitton of other emoticons!
Awesome work @david-driscoll !
This week and next week I do not have the bandwidth to give this PR the love it deserves but suffice to say this is f'ing awesome! :smile:
@ctolkien @stephen-james you have time to review this?
@david-driscoll we invited you to the atom-contributors group so you have direct push access to this repos, look in your email.  I'm slammed at work as well at the moment (and stricken with man-flu) but will see when I can give it a spin...
:clap:

I figure this will take a little bit to bake.  I'll try to watch for any other changes and keep the branch updated with any other fixes.

@david-driscoll  - if you have a chance, can you look at migrating the (recently merged) linter.coffee - https://github.com/OmniSharp/omnisharp-atom/blob/master/lib/omnisharp-atom/linter.coffee
Then we can hopefully draw a line in the sand to get this in.

I'll look at merging it in and updating anything new too.
I'm currently just trying to finish getting the atom typescript definitions up to date... it's helping solve some of the last few deprecations as well.

Unless anyone can find other reasons, I propose we look at getting this merged.
Thing is, we don't have to have everything in typescript or coffeescript. We can mix and match both together in our package.

Yah the earlier we get this in, the better (stop people doing work in 2 langs). I've a PR outstanding on @david-driscoll 's repo which should bring things more or less up to date with master.

As per the conversation on jabbr with @ctolkien, so let's keep a record of this...

Let's release a new copy of omnisharp-atom (so people who are relying on that have a new version) as is prior to merging.
Merge this PR.

Keep in mind that 0.2.1 uses omnisharp-server, while the current master (and potential 0.2.2) has switched over to omnisharp-roslyn. We'll also need to update the various build script that attempts to build omnisharp-server.

ping @Mpdreamz  for your input here.

OMNISHARP ROSLYN!!! :small_blue_diamond:

Agreed. I'd love to get a release out soon, so TS can get merged and we can get back to adding features. It'd be nice to both be on Roslyn and have TS completed.

@ctolkien updated!


WIP: Fix broken engine brakes xarray.open_dataset

Currently, a broken engines brakes xarray.open_dataset. I have added a try except to avoid this problem.
Old behaviuor:
>>> ds = xr.open_dataset('example.nc')
Traceback (most recent call last):

  File "/usr/local/Caskroom/miniconda/base/envs/xarray/lib/python3.8/site-packages/IPython/core/interactiveshell.py", line 3331, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)

  File "<ipython-input-3-0c694cae8262>", line 1, in <module>
    arr = xr.open_dataset("example.nc")

  File "/Users/barghini/devel/xarray/xarray/backends/api.py", line 495, in open_dataset
    backend = plugins.get_backend(engine)

  File "/Users/barghini/devel/xarray/xarray/backends/plugins.py", line 115, in get_backend
    engines = list_engines()

  File "/Users/barghini/devel/xarray/xarray/backends/plugins.py", line 97, in list_engines
    return build_engines(pkg_entrypoints)

  File "/Users/barghini/devel/xarray/xarray/backends/plugins.py", line 84, in build_engines
    external_backend_entrypoints = backends_dict_from_pkg(pkg_entrypoints)

  File "/Users/barghini/devel/xarray/xarray/backends/plugins.py", line 58, in backends_dict_from_pkg
    backend = pkg_ep.load()

  File "/usr/local/Caskroom/miniconda/base/envs/xarray/lib/python3.8/site-packages/pkg_resources/__init__.py", line 2450, in load
    return self.resolve()

  File "/usr/local/Caskroom/miniconda/base/envs/xarray/lib/python3.8/site-packages/pkg_resources/__init__.py", line 2456, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)

  File "/Users/barghini/devel/xarray-sentinel/xarray_sentinel/sentinel1.py", line 13
    ERROR
            ^
SyntaxError: invalid syntax

New behaviour:
>>> ds = xr.open_dataset('example.nc')
/Users/barghini/devel/xarray/xarray/backends/plugins.py:61: RuntimeWarning: Engine sentinel-1 loading failed:
name 'ERROR' is not defined
  warnings.warn(f"Engine {name} loading failed:\n{ex}", RuntimeWarning)

[x] Tests added
[x] Passes pre-commit run --all-files

This VERY important to merge!

thanks!


Remove semantic-release from CI

I'd like to propose that we disable semantic-release when a PR is merged, and experiment for a while with continuing to use it manually.
We've been using semantic release for about 6 weeks now, and I feel like it has had a detrimental effect on the pace of the project. I know I've found the barrage of GreenKeeper updates on other repositories every time we merge a PR to be annoying, which causes me to hesitate before merging simple PRs. I've been noticing other people hesitant to make changes, or deciding against making changes, because it will bump the major version number.
Long term, I think I'd rather switch to something like https://github.com/johnbillion/probot-semver, where PRs are added to milestones for the appropriate next version and each release is thoughtful and intentional.
FYI @gr2m @johnbillion

I've been noticing other people hesitant to make changes, or deciding against making changes, because it will bump the major version number.

What’s the alternative? Release a version with breaking changes without bumping the major version number?

I know I've found the barrage of GreenKeeper updates on other repositories every time we merge a PR to be annoying

That should only happen if you merge a pull request that releases a breaking version, unless people pin the probot version in their project’s package.json, which they shouldn’t

Accumulate several breaking changes, then release.

There is no reason not to do that with semantic-release, I do it all the time. It might go hand-in-hand with a milestone-based system like https://github.com/johnbillion/probot-semver seems to support.
Here is an example: https://github.com/octokit/node-github/pull/629

@bkeepers you should also remove the semantic-release stuff in package.json 📦

I was thinking we'd leave that for now and I'd just manually run npm run semantic-release locally whenever we were ready to push out a release.  So we'll still use the commit message format, but hopefully have a little more control over what gets pushed and when.

What’s the alternative? Release a version with breaking changes without bumping the major version number?

As @j-f1 said, accumulate changes, and do releases on regular/predictable intervals. Logical version numbers is a feature of an open source project, IMHO. Semver is part of that, but I also think there's an art to grouping features together into a release, and I don't think merging a single PR is the right level of granularity.

There is no reason not to do that with semantic-release, I do it all the time.…Here is an example: octokit/node-github#629

That definitely seems like a workable approach. My only concern is that it requires you to change how PRs are managed on a project, either by leaving all PRs open until the milestone is ready to be shipped, or merge them into a different branch that doesn't get merged back into master until the release.
I'm open to experimenting with that, but it's not rally a priority for me right now.


Roll engine 81dffd1241e6..7ca44d339b64 (5 commits)

https://github.com/flutter/engine/compare/81dffd1241e6...7ca44d339b64
git log 81dffd1241e6..7ca44d339b64 --first-parent --oneline
2020-02-04<EMAIL_ADDRESS>Kill the test harness if any test exceeds a timeout. (flutter/engine#16349)
2020-02-04<EMAIL_ADDRESS>Refactor of Vulkan GPUSurface code (flutter/engine#16224)
2020-02-04<EMAIL_ADDRESS>Fix runtime type errors when running with canvaskit (flutter/engine#16312)
2020-02-04<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from 6h3IH... to Ke00Y... (flutter/engine#16360)
2020-02-04<EMAIL_ADDRESS>Roll src/third_party/dart c8ed304e979a..3414b5167554 (52 commits) (flutter/engine#16362)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Commit queue failed; closing this roll.


Add Tomcat 10 (alpha)

See https://tomcat.apache.org/tomcat-10.0-doc/index.html, https://tomcat.apache.org/download-10.cgi, https://tomcat.apache.org/whichversion.html ("Supported Java Versions" is "8 and later").

For some reason, it appears that apache-tomcat-10.0.0-M4.tar.gz.asc doesn't exist?? :disappointed:
(It's linked from https://tomcat.apache.org/download-10.cgi to https://downloads.apache.org/tomcat/tomcat-10/v10.0.0-M4/bin/apache-tomcat-10.0.0-M4.tar.gz.asc but the latter is a 404.)

Fixed<EMAIL_ADDRESS>Restarted builds (and already have some that are green). :+1:


Bug with user disallowing permission

I have 2 permissions set up:
Camera and Notifications.
Camera has permissions. Notifications does not yet.
The screen is presented. Say the user clicks on notifications button and rejects permissions.
Say next time, the screen is again presented. The user clicks on notifications button and alert is shown. The user clicks to go to settings.
If the user now disables camera permission and then returns to app, the app crashes.

Dupe #160 ?

I really need to add this to the readme!
This is normal system behavior. If you toggle permissions from the settings screen, apps that have been approved or denied for this permission will be killed by the OS.

New item in "Known bugs" and maybe add it to the issue template

There seems to be some inconsistencies:
I had denied camera in the past.
When the popup comes up, I get taken the Settings. I allow Camera and go back to app.
The app doesn't crash - BUT it doesn't detect that camera is now allowed.
Even if I close popup and open it up again (NB: the app is never terminated), the popup still thinks Camera is denied.
When I check settings app, Camera is definitely allowed.
If I restart the app, it correctly recognises that Camera is allowed.
I'm using iOS 9

Have you printed the return values ? Might be an issue related to the UI instead

Printed them out from callback:
[Camera Unauthorized, Notifications Unauthorized]
I checked Settings app again - Camera definitely allowed
And also app didn't crash when it got sent back.

Try returning the raw value then: AVCaptureDevice.authorizationStatusForMediaType(AVMediaTypeVideo)

By the way, it worked perfectly with Notifications permissions being allowed from settings app and the returning to App.
I think it only crashes if permissions that app already had are denied from permissions app. That also makes more sense from a design perspective.

AVCaptureDevice.authorizationStatusForMediaType(AVMediaTypeVideo) returns denied despite settings app showing Authorized.
So it's not the fault of PermissionScope. Perhaps AVCaptureDevice.authorizationStatusForMediaType(AVMediaTypeVideo) is not the best function to call to test camera permissions?

AVCaptureDevice.authorizationStatusForMediaType() is the recommended way as far as I remember

I double checked it. It is the recommended way - it seems to not get changed immediately for the app. Bug with Apple.
Either way, the readme's known bugs section should be changed to reflect that app only crashes when a user reduces the permissions of app from what it already had.

Here's a twist:
All statements above were from tests on a iPhone 6 running iOS 9.
The app doesn't crash when the permissions scope is increased.
I tested on iPad running iOS8.3. The app crashes when any permissions are changed, even if permissions are unambiguously expanded.


Disable mapMode2D scroll and rotate at the same time?

In 2D, you can set the map mode either to infinite horizontal scrolling, or to rotate:
https://cesium.com/docs/cesiumjs-ref-doc/MapMode2D.html
Is there are a reason these aren't two boolean options instead of exclusive enums? My use case is that I want to disable both, but I also can see wanting to enable both.

Rotation can be enabled/disabled independently already:
scene.screenSpaceCameraController.enableRotate = false;

It would probably be less confusing to have the enum be INFINITE_SCROLL and something other than rotate, because it's really an option that's more INFINITE_SCROLL or not


Update azure-sql-iaas-vs-paas-what-is-overview.md

That survey link has expired.

@ronazi : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

#sign-off


Ruleset and VNet limits

I'm a bit confused on how many forwarding rules are supported.
This page says you can have up to 1,000 rules per ruleset: https://learn.microsoft.com/en-us/azure/dns/dns-private-resolver-overview#dns-forwarding-rulesets
However the limits state that you can only have 25 rules per ruleset, and 2 rulesets per endpoint: https://learn.microsoft.com/en-us/azure/dns/dns-faq#what-are-the-usage-limits-for-azure-dns-
Also, if you can only link up to 10 VNets per ruleset (including the hub in a hub/spoke topology), what is the recommended pattern for scaling this beyond 9 spokes?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b624746d-cab5-19da-f8f4-f467fb860a9e
Version Independent ID: b96e524d-80d2-b615-5216-43b911162b33
Content: Azure DNS Private Resolver endpoints and rulesets
Content Source: articles/dns/private-resolver-endpoints-rulesets.md
Service: dns
GitHub Login: @greg-lindsay
Microsoft Alias: greglin

@timwebster9 ,
Thank you for the feedback, the document has been updated with the correct limit.
The team currently working on increasing the limits to mitigate any scaling issue.
Hope this helps! Please tag me in your response if you have any additional questions. Thank you!


When I use Xcode 13.2.1 to build for iOS 12.x, will crash every time

How frequently does the bug occur?
All the time
Description
When I use Xcode 13.2.1 to build for iOS 12.x, will crash every time, but iOS 13.x and later is ok.
pod 'Realm',                                      '~> 10.21.0'
pod 'RealmSwift',                                 '~> 10.21.0'
Stacktrace & log output
dyld`__abort_with_payload:
    0x1094842e0 <+0>:  mov    x16, #0x209
    0x1094842e4 <+4>:  svc    #0x80
->  0x1094842e8 <+8>:  b.lo   0x109484300               ; <+32>
    0x1094842ec <+12>: stp    x29, x30, [sp, #-0x10]!
    0x1094842f0 <+16>: mov    x29, sp
    0x1094842f4 <+20>: bl     0x10948371c               ; cerror_nocancel
    0x1094842f8 <+24>: mov    sp, x29
    0x1094842fc <+28>: ldp    x29, x30, [sp], #0x10
    0x109484300 <+32>: ret

Can you reproduce the bug?
Yes, always
Reproduction Steps
No response
Version
10.21.0
What SDK flavour are you using?
Local Database only
Are you using encryption?
No, not using encryption
Platform OS and version(s)
iOS  12.x
Build environment
Xcode version: Xcode 13.2.1

This is a bug in Xcode 13.2.1's concurrency back-deployment which is fixed in 13.3. Until 13.3 is officially released, you need to use 13.1 to support iOS 12.

This is a bug in Xcode 13.2.1's concurrency back-deployment which is fixed in 13.3. Until 13.3 is officially released, you need to use 13.1 to support iOS 12.

I struggle in realm database and i tried this. And it works for me. Thanks for saving my life. :)


margins for menu items adjusted

Signed-off-by: Ayush<EMAIL_ADDRESS>Description
Margins for the navigation menu items were not applied properly so made things asymmetrical.
This PR fixes #3260
Notes for Reviewers
https://user-images.githubusercontent.com/59086855/123086917-999b8100-d441-11eb-9524-229a46a681f2.mov
Signed commits

[X] Yes, I signed my commits.

@leecalcote 👀


Handle advanced rest routes for collection in resource

Handle new routes for updating a collection within a resource:

Find an item within the collection:
[GET] /:id/:collection
--> service.findInCollection(id, collection, params, cb)

Get an item of the collection
[GET] /:id/:collection/:documentId
--> service.getInCollection(id, collection, documentId, params, cb)

Add an item to the collection
[POST] /:id/:collection
--> service.addToCollection(id, collection, data, params, cb)

Remove an item from the collection
[DELETE] /:id/:collection/:documentId
--> service.removeFromCollection(id, collection, documentId, params, cb)

Linked with these PRs:

feathers: https://github.com/feathersjs/feathers/pull/141
feathers-commons: https://github.com/feathersjs/feathers-commons/pull/2

@ebourmalo I'm going to close this PR. I haven't forgotten about our discussion though. Still trying to work out associations but doing it right is actually trickier (and the database adapters needed some work really badly).


Issue with popup modal on IOS

This is a (multiple allowed):

[x] bug

Framework7 Version: 1.5.2.

Platform and Target: PHONEGAP IOS.

What you did
Testing popup with ios - vue - framework 7 on iphone se
Expected Behavior
Expected the modal to fill the screen
Actual Behavior
The popup modal is not filling the screen
the issue is illustrated in this video https://youtu.be/R6MmXfgh4tQ?t=26m12s

Can anyone confirm? I see the video is by @valnub

Yes :)
I don't remember every detail of that code but I think it was something with the popup modal defined as a direct child of div#app https://github.com/valnub/Twitvue04/blob/master/src/home.vue
Maybe the popup needs to be defined somewhere within a view or page?

Not being familiar with vue i wouldn't know.
@nolimits4web any thoughts?

We can close it. Just keep correct layout structure and it should be fine


Underscore in source file name prevents task from executing

This code failing (file styles.css doesn't appear in target url.):
gulp.task('scss', function() {
    gulp.src('./sources/scss/_styles.scss')
        .pipe(sass({
            outputStyle: 'compressed'
        }))
        .pipe(gulp.dest('./dev-build'));
});

Content of the _styles.scss is valid.

Well it's a problem because of some packages think different (i.e. https://github.com/twbs/bootstrap-sass).
An option maybe?

@kuraga bootstrap-sass works fine if you just import the path without including the leading underscore (e.g. "@import 'bootstrap/theme';" will import ./bootstrap/_theme.scss. This is actually a part of the sass spec: http://sass-lang.com/documentation/file.SASS_REFERENCE.html#partials

@dlmanning yes, but if the main file name starts with underscore?

@kuraga @import 'bootstap'; will import ./_bootstrap.scss. If we're talking about your main file, don't do that.

Yeah, nice idea! Thanks!

Maybe there should be a warning or info flag on these files so when all your files begin with underscore because they are partials and you forget to import them, you'll know.


SyntaxError CSS file

Summary
Hello all, I was hoping somebody could let me know what I'm doing wrong here. I keep getting a syntax error on CSS files. We're using Stryker version 0.14.1. We are also using react/redux with the mocha test framework. We are not using webpack. I'm unsure if it is some configuration error, version issue, or something completely different. The error is as follows:
[2018-07-26 13:02:05.874] [ERROR] InitialTestExecutor - One or more tests resulted in an error:
SyntaxError: Unexpected token .
C:\code_base\poi\node_modules\form\lib\util\block.css:1
(function (exports, require, module, __filename, __dirname) { .a-form-v3-10-0-block {
Stryker config

module.exports = function(config){
  config.set({
   files: [
        "src/**/*.js",
        "test/**/*.js"
    ],
    mutate:[
      "src/pages/poi/*.js"
    ],
    testRunner: "mocha",
    mutator: "javascript",
    transpilers: ["babel"],
    reporter: ["html", "clear-text", "progress"],
    testFramework: "mocha",
    coverageAnalysis: "off",
    babelrcFile: ".babelrc"
  });
}

Stryker environment

+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
Your Environment

software
version(s)

node
6.1.0

npm
3.8.6

Operating System
Windows 7 Enterprise

Thanks for reporting this issue. I see that you have both a webpack configuration and a Babel configuration. You normally won't need webpack when using mocha as a test runner. What does your babelrc and npm test command look like?

@nicojs the post was edited after placing it. The webpack config is now gone and the post mentions they don't use webpack. (I was about to ask the same question)

Sorry about the mistake in the config file, I did edit it right after I noticed it. Here is my babelrc and npm test command.
babelrc
{
  "env": {
    "test": {
      "plugins": [
        [
          "istanbul",
          {
            "exclude": [
              "src/main.js",
              "src/redux/configureStore.js"
            ],
            "include": [
              "src/"
            ]
          }
        ]
      ]
    }
  },
  "ignore": ["dist/", "coverage/"],
  "presets": ["env", "stage-2", "react"]

npm test command
"test": "cross-env NODE_ENV=test mocha "./test/**/*-tests.js"",

As a check, could you upgrade the Stryker dependencies to their latest versions? If you use Git for this project, you may be able to remove the files property from the config as well.

Sorry for taking so long to reply. I was able to update Stryker to the latest version, but may have to wait till Monday till the other dependencies can be updated. I tried running with just the updated Stryker and got this error:
module.js:440
throw err;
^
Error: Cannot find module 'stryker-api/logging'
at Function.Module._resolveFilename (module.js:438:15)
at Function.Module._load (module.js:386:25)
at Module.require (module.js:466:17)
at require (internal/module.js:20:19)
at Object. (C:\code_base\pc-property-renters-proof-of-insurance\node_modules\stryker\src\config\ConfigReader.js:5:17)
at Module._compile (module.js:541:32)
at Object.Module._extensions..js (module.js:550:10)
at Module.load (module.js:456:32)
at tryModuleLoad (module.js:415:12)
at Function.Module._load (module.js:407:3)
Trying to delete the old conf file and running init again also results in the same error. I'm thinking I'll have to update stryker-api at least before I can do anything more.

Yeah, we've recently revamped the logging so you'll have to update all Stryker dependencies (including the plugins such as stryker-mocha-runner).
Don't worry about taking a while to respond. We're here to help you and if you need some time that's perfectly fine. We also don't have time to reply or fix things right away :)

I installed the upgraded dependencies this morning and reran the init command. The only thing the setup asked me was what type of reporters I wanted and the package manager I was using. The config file had a few labels with nothing filled in so I filled it in. I'm still receiving an error:
08:01:56 (13016) ERROR TestRunnerChildProcessAdapter Child process exited with non-zero exit code 1. Last 10 message from the child process were:
08:01:56 (13016) ERROR InitialTestExecutor One or more tests resulted in an error:
SyntaxError: Unexpected token .
C:\code_base\poi.stryker-tmp\sandbox5164784\src\pages\poi-trap\poi-trap.css:10
.trap-section-container
^
SyntaxError: Unexpected token .
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:511:25)
at Object.Module._extensions..js (module.js:550:10)
at Module.load (module.js:456:32)
at tryModuleLoad (module.js:415:12)
at Function.Module._load (module.js:407:3)
at Module.require (module.js:466:17)
at require (internal/module.js:20:19)
at Object. (C:\code_base\poi.stryker-tmp\sandbox5164784\src\pages\poi-trap\poi-trap.js:13:1)
at Module._compile (module.js:541:32)
08:01:56 (13016) ERROR StrykerCli an error occurred Error: Something went wrong in the initial test run
at InitialTestExecutor.validateResult (C:\code_base\poi\node_modules\stryker\src\process\InitialTestExecutor.js:129:15)
at InitialTestExecutor. (C:\code_base\poi\node_modules\stryker\src\process\InitialTestExecutor.js:45:30)
at step (C:\code_base\poi\node_modules\stryker\node_modules\tslib\tslib.js:133:27)
at Object.next (C:\code_base\poi\node_modules\stryker\node_modules\tslib\tslib.js:114:57)
at fulfilled (C:\code_base\poi\node_modules\stryker\node_modules\tslib\tslib.js:104:62)
at process._tickCallback (internal/process/next_tick.js:103:7)
Stryker config

module.exports = function(config){
  config.set({
   mutate: [
        "src/pages/poi-email/*.js"
    ],
    testRunner: "mocha",
    mutator: "javascript",
    transpilers: ["babel"],
    reporter: ["clear-text", "progress"],
    packageManager: "npm",
    coverageAnalysis: "off",
    babelrcFile: ".babelrc"
  });
}

Stryker environment

+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

I tried the configuration @nicojs suggested but I get a syntax error on the import. This happens when we don't include the babel transpiler. We do have a mocha.opts file in which our mocha-hook.js file is required. babel-register is required in the hook.js file, which should also disable our css imports. Could there be an issue where the mocha.opts file is not being used correctly?

Could there be an issue where the mocha.opts file is not being used correctly?

Yes, this is most definitely it. It is not used by default. Mocha has no clean way of providing the mocha.opts file, instead we had to recreate the functionality. See https://github.com/stryker-mutator/stryker/tree/master/packages/stryker-mocha-runner#configuring
I our implementation doesn't support local requires. Could you try this:
module.exports = function(config){
  config.set({
    mutate:[
      "src/pages/poi/*.js"
    ],
    testRunner: "mocha",
    testFramework: "mocha",
    mutator: "javascript",
    reporter: ["html", "clear-text", "progress"],
    coverageAnalysis: "off",
    mochaOptions: {
      files: [ './test/**/*-tests.js' ],
      opts: 'mocha.opts',
      require: [require.resolve('./mocha-hook.js']
    }
  });
}

That should do the trick.

Alright, I think we're almost there. I am getting a different error:
11:17:04 (7868) ERROR TestRunnerChildProcessAdapter Child process exited with non-zero exit code 1. Last 10 message from the child process were:
11:17:04 (7868) ERROR InitialTestExecutor One or more tests resulted in an error:
TypeError: (0 , _mocha.describe) is not a function
TypeError: (0 , _mocha.describe) is not a function
I am using chai, enzyme, and sinon along with mocha if that makes a difference. I also need to add our dom.js file to the require tag under mochaOptions, but I'm unsure of the usage 'require.resolve'. Will I just need to add another require to the array and put in the corresponding path or does resolve take multiple strings as arguments?

Unfortunately, adding the dom.js file to the require.resolve didn't have any impact. I'm still receiving the error of mocha.describe not being a function.

Unfortunately adding the dom.js didn't resolve any issues. I'm still getting the same error for mocha.describe.

Yes, they should make sure describe is on the global scope.
Hmm ok, time to pull out the big guns. Could you open up /node_modules/stryker-mocha-runner/src/MochaTestRunner.js and replace the additionalRequires function? Should be on line 109 to 113. Replace it with this:
MochaTestRunner.prototype.additionalRequires = function () {
        var _this = this;
        if (this.mochaRunnerOptions.require) {
            var stuffToRequire = this.mochaRunnerOptions.require
                .map(function (theModule) { return theModule.startsWith('.') ? path.resolve(theModule) : theModule; });
            stuffToRequire.forEach(function (theModule) { return _this.log.info("Importing " + theModule); });
            stuffToRequire
                .forEach(LibWrapper_1.default.require);
        }
        else {
            this.log.info('Nothing to require');
        }
    };

That should make local requires possible (and add some logging).
If you now remove the entire require from your stryker.conf.js file (but leave the mochaOptions.opts key in there), that would make sure that you're requiring the local sandboxed files. That might do the trick.
If that doesn't work, would you mind creating a small reproduction repository? The smaller the better. If we could take a look, I'm sure we could figure it out.

I'll see to creating a small repository that reproduces the problem (today). Unfortunately the replacement of the function did not help, I'm still getting the same error. I also added the ui tag and gave it 'bdd', but that didn't seem to help either.
I also wanted some clarification on location of the config file. The readme says that it is expected to be the current working directory, but then goes on to say:
"As you can see, the config file is not a simple JSON file. It should be a node module."
I have my config file in the root directory, just want to make sure this isn't an issue.

I have my config file in the root directory, just want to make sure this isn't an issue.

No, no issue there.

I'll see to creating a small repository that reproduces the problem (today

Awesome! I'm sure we'll be able to fix this issue once we can reproduce it 👍

So I figured out what was causing describe not be recognized as a function. I got the idea here. I simply had to remove my import statement for mocha and it started working. The weird thing is when I tried to reproduce the error on my computer with the import statements it would still work and give me no error. It may be some anomaly with the environment, there's a lot of code and environment setup that was done by other people. Thanks so much to everyone for your help.

I would like to keep this issue open. I want to fix 3 things:

[ ] use your mocha.opts file by default (if exists)
[ ] Make sure relative imports when using --require (same as mocha does it)
[ ] Make sure const { describe } = require('mocha'); works as well.

@nicojs Shall we create an issue for the problems you mention?

I was thinking to use this issue for them. Doesn't matter really.

Working on it


Darknet: conv_lstm inference

This is conv_lstm layer: AlexeyAB/darknet#3114
The layers after conv_lstm layer can not be drawn normally. Please try below: yolo_v3_tiny_lstm.cfg.txt

yolo_v3_tiny_lstm.zip


what does the path point at

https://jintian93.github.io/post/assets/1568259158377.png
I have hugo project which local render normal but pushed to git then image can not found. What this path point to in local file folder?

https://github.com/jintian93/jintian93.github.io/tree/master/assets

I do have this file but can not render, how???

Please use https://discourse.gohugo.io/ for questions/troubleshooting. Also see  Hugo Documentation.


Semyon1104/feature2 openCV

Closes #8, #9

please resolve conflicts

Please add readme in separate PR


Broken links

Description:

Broken links in the following [1].

[1] - https://apim.docs.wso2.com/en/4.0.0-dev/deploy-and-publish/deploy-on-gateway/api-gateway/message-mediation/adding-dynamic-endpoints/
Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

The links on this page are now working in the latest GA version.
Thanks for reporting.


Blog App: validations and model specs

Added validations for User and Post model
Added unit test for all models

fixed the link to issues page in  readme


chore: light node clearing on restart only

Since clearing light node data while running the node resulted in node getting out of sync, this is now only done on restarting the node.

prnet cleaned-up successfully


Once a dataset is SUMSARIZED, user can browse the machine-labeled data through the website

First version of this implemented in #37
Adds a Results tab that shows which points were labelled as "cooking".


Provide a "real" Solr Plugin Directory

Rafal did a great write up on the new Solr Plugin system and how to provide a plugin directory: https://sematext.com/blog/solr-plugins-system/

Setup repo.solr.cool
Add linked plugins if still available
Provide docs how to use in Solr 8.4+

If you were able to get this rolling, I'd be happy to contribute towards updating various plugins to work with the new Solr Plugin stuff!

💯 for this.  Was just thinking how it would be nice if somebody took some of the Sematext "plugins" and, if they still make sense for Solr 8.x+, turn them into proper Solr plugins.  I was just looking at solr.cool and realized that, while it's nice to have a nice place for various plugins, there are too many plugins with build errors.

I wonder if a pivot to solr.cool being specifically for Solr 8+ plugins?   Instead of a collection of random projects?  Or, maybe just put a tag that "plugin_compatible"...?

I like things how things are starting here ;-)
As solr.cool is just a catalogue of plugins, I wanted to check out, if I could generate some kind of meta catalogue for plugins without actually hosting (a.k.a downloading) them. I quickly implemented a local version of Rafals repo and hook it up to a Solr. And it works!
So my idea is that we build a repo.solr.cool that is directly usable from within Solr. As the second step, we generate the solr.cool website from the repository.json metadata of the repo.solr.cool website.
More random ideas:

We do not host the binaries, we just link to them on Maven Central. We have to sign them though.
What's the best way to check, collect and sign binaries. It is certainly doable with a Maven POM, but how can we keep it maintainable?
A lot of the plugins listed on solr.cool are vanished or seem fairly unmaintained. We should keep them listed for reference (as there seems to be no other place)

I'll hack more if this together and think about some kind of automation over the next days.

@tboeghk count me in. I can help with updating some of the extensions and turning them into something usable for the Solr plugins mechanism.

I hacked things pretty rough in https://github.com/solr-extensions/repo.solr.cool.
Major point missing here are

verify the integrity of the downloaded jar
actually working plugins ;-)
CI/CD pipeline to build and test PRs
a simple test whether the listed plugins are installable and removable from a running Solr instance.

I'll add some docs within the next days

@tboeghk Related to your earlier comment: artefacts on Maven Central are already signed. Do we need an additional signature for plugins?

Very exciting.  Having some examples and a central website will encourage folks to embrace this!

Awesome @tboeghk 👍

@tboeghk Related to your earlier comment: artefacts on Maven Central are already signed. Do we need an additional signature for plugins?

Yes, we need to sign artifacts with the repo distribution key. But I‘ll add signature verification for maven central artifacts later!

This is really awesome!  I'd like to see the Solr Ref Guide and information from Solr project committers (e.g. me) pimping solr.cool as much as possible as the go-to place to find 3rd party Solr plugins.  It seems the repo.solr.cool spot is a great start but not ready to share widely.  When it is ready, please share that status here.  Also please share feedback to the Solr project to help make the package management system better as you see issues.
BTW I've noticed mixed/jumbled language around referring to the new system.  Solr's "Package Manager" or "Package management system" are both good ways to refer to it.  It doesn't manage plugins themselves, it manages packages (of plugins).  And although "plugin" and "extension" are probably synonyms, let's please just refer to them as "plugins".

Do you plan to only list things that are plugging into solr, or also "related tools" like https://plugins.gradle.org/plugin/com.needhamsoftware.solr-gradle

We have a list of utilities under https://solr.cool/#utilities, so I don't see why this couldn't be added.   The value in http://solr.cool goes up the more projects are included!

@gus-asf we definitely will! Can you open a separate issue and/or PR?

In a first step I implemented a test harness and added the thymeleaf templating package as test bed in #34


Bring in Reactome SARS-CoV-2 pathway

Name of the dataset
Reactome SARS-CoV-2
Mapping or relevant fields
Minimal: gene product to pathway
Future: GO-CAM granular representation
see also
https://github.com/geneontology/go-site/issues/1431

See also this Noctua model:
http://noctua.geneontology.org/editor/graph/gomodel:5e72450500004019
Possibly should be a separate ticket


nomination-pools: Consider allowing partial unbonding

In the current design a delegator cannot unbond a sub portion of their stake; instead they must unbond all their stake at once. This was chosen for implementation simplicity. Instead we shoud allow a delagator to only unbond sub portion of their funds, thus giving users more flexibility.  We could use a bounded btreeset to track the eras they are unbonding in and make sure to destroy the delegator when they withdraw unbonded and the btreeset is empty.
It will probably keep things simpler if the pool's creator still had to unbond all funds at once. This is ok because they can only unbond once the pool is in a destroying state and no other delegators remain.
We should still maintain the invariant that a delegator can only be a member of one pool at a time.
Should wait until https://github.com/paritytech/substrate/pull/10694 is merged to start working on this.

Closed by https://github.com/paritytech/substrate/pull/11212


chore(package): update nyc to version 11.0.0

Codecov Report

Merging #107 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #107   +/-   ##
======================================
  Coverage    87.4%   87.4%
======================================
  Files          16      16
  Lines         127     127
======================================
  Hits          111     111
  Misses         16      16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba9f00e...e5b8d1d. Read the comment docs.

Coverage remained the same at 87.402% when pulling e5b8d1d088b76fc60a8fbb873832292417b51a07 on greenkeeper/nyc-11.0.0 into ba9f00ebdb1a32e8f122d4702fbeda8a447a4b09 on master.


"Get.currentRoute" return null and  "Get.isDialogOpen"  always false

I just try to print "Get.currentRoute" or  "Get.isDialogOpen"
Its not work when I use the Getx example "example_nav2" with v4.6.5
I have no idea and I used 1 day try to find out the problem....
Only "Get.rootDelegate.history.last.location" can be print the current page but "Get.isDialogOpen" still not work
Please help....many thanks

Are you using navigator 2?

Are you using navigator 2?

Yes sir.


JsonParseFailure||Reason: Number of Characters in message field

I am facing jsonparsefailure because of character limit in json filter .Please help me with that
Logstash Version: 7.6.2

Possibly the same as 42.


Ticket #28622: Allow password reset token to expire in under a day

can set PASSWORD_RESET_TIMEOUT using seconds, so it can be expired within a day.
changing making token to use seconds instead of days.
It should be backward compatible, because PASSWORD_RESET_TIMEOUT_DAYS can still be used. Old tokens generated should be checked without problems.

@timgraham Hi Tim, can you take some time to review this PR?

I haven't reviewed in detail but at first glance, documentation changes are needed.

Would really appreciate it if this could be added.

It would be helpful if this was made available.

Closing due to inactivity.


Todo app doesn't build.

Fresh folder, clone repo from Master or Dev.  Get errors about 'not suitable method to override'.  I've looked through code in both branches to see if there is a version I should be using, but can't see the 'DisposeAsync' anywhere on TodoAppComponent.
I copied the dependency projects locally, instead of using packages (to change version) and this doesn't work, so it looks like there is a mismatch with the checked in code and your code locally.
If you can provide the correct steps to get the Todo app running, that would be great.

oh will check and updated. thanks for reporting.

able to build Todo samples in master branch without modification.
if you are using dependency projects, please switch to develop branch on dependency project. also .NET 5.0.0 rc2 required.

Hmm, that's odd.  I am using Rc2 and tried to build the samples (which failed) before I tried referencing the dependencies as projects.  I'll give it another go.

you should know, that I get this error when cloning.

I tried many times to clone, but ended up using the download link instead.

Just giving you process feedback...  I download the repo as a ZIP and unpack in new folder.  I try build and it errors, saying the projects dependencies don't exist.

This is understandable, so I clone the repos into the relative folders.  So it looks like this:

But the build still fails because it can't ind the project files.  This is due to them being in a sub-folder of 'src'.
e.g.  C:\projects\blazor\skclusive\Skclusive.Mobx.Component\src\Component (note the last 'component').
So, I edit the csproj file to add these missing folders.  Rebuilding gives and error saying the project information cannot be found, so I do a dotnet restore from CLI.  Then I build each dep project separately.
DomHelpers and DevTools result in error:
The command "npm run build" exited with code 1.
But the DLLs are created anyway, so I retry the build of TodoApp.Client.  This proceeds further than last time, but I get the error:
'TodoAppComponent.DisposeAsync()': no suitable method found to override	TodoApp.Client	C:\projects\blazor\skclusive\Skclusive.Blazor.Samples-master\Skclusive.Blazor.TodoApp\TodoApp.Client\Components\App\TodoApp.cs
So, perhaps something in the NPM build step is causing this?  Any suggestions?

thanks for the details. will follow the above steps and try to reproduce.

reproduced. sorry. i should not noticed it. fixed and pushed it in master.
need to check why git clone also fails. might be the repo has commit logs which are quite heavy.
you can either download the master repo to get the fix or just uncomment the package references and comment the project references as in this commit.
https://github.com/skclusive/Skclusive.Blazor.Samples/commit/0650bdbf0913622ce128acd5a08d0945f994f0bb

Thank you!  I'll take a look.

Yep, that's working fine for me now, just unzipped into folder, opened solution and ran fine.  Thanks for sorting it out 👍


Not enough resource to deploy testnet vdc after payment

same as issue #2342

same as issue #2342

duplicate https://github.com/threefoldtech/js-sdk/issues/2342

duplicate https://github.com/threefoldtech/js-sdk/issues/2342


ValueError During Training Process

Dear sir,
First, I have to say that I really appreciate that you publish the code in this repo. What an amazing implementation!
However, I've just tried to train the given dataset followed by your tutorial and it seemed to work well until I saw the error:

I realized that final batch is really important for tasks related to the used custom dataset ! I think the error comes from the process of final batch.
Please give me feedback on this, and hopefully you will update the code 😄

Hi there,
Thank you very much for noticing the issue.
As you pointed out, the error is raised by the batch normalization layer when the input batch only has 1 example. To fix the issue, you can try to either change the batch size (in the parameters.yml file) so that len(dataset) % batch_size != 1 (where % means modulo) or you can add drop_last=True in the Dataloader creation phase.
Would you mind trying these solutions out and letting me know if they actually fix the issue? If they do, you can also file a PR or I can commit the changes, as you wish.
Thanks,
Alessio.

Fixed in b07e3074e79ea8c1129fb0adb8315e06bb4943ea, closing the issue.


Cannot add private key or login via CLI

I use GPGTools on Mac OS X 10.10, and have a local keyring. My keypair has subkeys, 1 each for encrypting, signing, and authenticating, but the primary private key has been removed for security reasons.
I generally don't have issues with using a keypair that is set up this way with subkeys.
So on the Keybase website, I had no problem updating my public key, but I get this error when I try to add my private key:
Error: no private key material found after merge

I also cannot log in via the command line client with keybase login:
$ keybase login
Your keybase username or email address: smt
▶ ERROR Bad key found: no private key material or GPGKey

These errors are very similar. Is the inability to use a keypair with no primary private key a known limitation of the OpenPGP lib(s) used by Keybase?
I haven't tried with my master keypair (and don't intend to), so I am not sure if this is even the issue, but it does seem related to some library not being able to detect the private key.

I may be having this problem as well.  With 1.0.15, I'm unable to keybase pgp sign anything.


feat: update relative date

What type of PR is this? (check all applicable)

[x] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Description

This PR fixes the Avatar relative date on the PostList and PostGrid.
Related Tickets & Documents
Please use this format link issue numbers: Fixes #174
https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[] 🙅 no, because they aren't needed
[x] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?
https://c.tenor.com/CW3dv0a1Hf4AAAAC/mission-complete-spongebob.gif

I'm going to remove the word at from this PR and a few other things.


Repo sync for protected CLA branch

The pull request is created from main637946245381658703sync_temp to main to fix git push error for protected CLA branch

@huypub : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Why "my" ? The selector of your component should have prefix "my"

Hello,
the coding style says to use a prefix, but this prefix must not be "my".
How can I get rid of this warning ?
thank you

Sorry, I need to add proper documentation for this in the README but seems like I never find the time.
in tslint.json there is an entry for the prefix. You can either remove it or change the my for your own prefix. I highly recommend you on using a prefix, so change it for the one of your choice.

don't be sorry :)
thanks a lot... I was looking for "my".. I don't know how I haven't found it...


Nimble component for Blazor's InputFile component

😯 Problem to Solve
In the Licensing Modernization project, we have a requirement where user needs to browse for a file and select it, for us to process it. Currently we are using Blazor's InputFile component to achieve this. This is how it looks like currently (the one highlighted in red below):

We're trying to style it to make it look like this (the one highlighted in red below). This is the wire-frame which we got from our UX:

We have a temporary solution for styling it like that for now.
💁 Proposed Solution
It would be nice if there is a nimble component for this InputFile component, which already applies all the desired styling suggested by UX, so that we can directly use it, instead of trying to style it ourselves.

For completeness, another possible workaround is to use a nimble-button for styling and then hook it up to JS code that shows the file dialog when the button is clicked. This Stack Overflow post shows ideas for that.
For now, thanks for adding this to our backlog. Since you have a workaround we may not push this too high up our priority list right now, but feel free to reach out if you think it has higher urgency or if you hear of additional use cases.

Another use case for a file upload component came up in the SLE Web App Hosting feature. The current proposal is to create an app-specific Angular component.


Why red Output instead of error?

If container creation (or any other docker daemon process) fails, the error will be red written in the console (See here and here). in this case the powershell thinks everything done fine.
Why not use write-error?
If the command ~does~ doesn't fail with write-error or throw its very hard or impossible to use in larger automations.

I think your does in the second sentence should be doesn't.
It is on my list to go though the containerhelper and fix this, this is wrong.

I would be very happy to have this in the next release. Can i support you with a PR or did you already started?

PR is welcome

<IP_ADDRESS> is released


Based on @viorik observations in #252

Separates biases from normalization, initializes beta's to zero and gammas to 0.1.

@lakehanne Your PR was broken. I fixed it here : https://github.com/Element-Research/rnn/commit/fb6aaea2efb6b9ddc9449779d72318460fcc613d

Cheers!

Is noBias a Torch method?
I had errors when implementing your fix:
...NT/ogunmolu/torch/install/share/lua/5.1/rnn/FastLSTM.lua:116: attempt to call method 'noBias' (a nil value)
stack traceback:
	...NT/ogunmolu/torch/install/share/lua/5.1/rnn/FastLSTM.lua:116: in function 'buildModel'
	...al/ANT/ogunmolu/torch/install/share/lua/5.1/rnn/LSTM.lua:20: in function '__init'
	...NT/ogunmolu/torch/install/share/lua/5.1/rnn/FastLSTM.lua:14: in function '__init'
	.../ANT/ogunmolu/torch/install/share/lua/5.1/torch/init.lua:91: in function <.../ANT/ogunmolu/torch/install/share/lua/5.1/torch/init.lua:87>

You should probably update the nn package.

@lakehanne Yup. https://github.com/torch/nn/blob/master/Linear.lua#L15


Update vulnerable Rubocop once update available (CVE-2017-8418)

There is a security alert for rubocop; details below.  It's a /tmp vulnerability; "Malicious local users could exploit this to tamper with cache files belonging to other users."
Nobody should have untrusted (other) local users on the machines with direct commit rights anyway, so I'm documenting that as a constraint in security.md, and we'll update when an update is available.  So this should not affect us.
Here are the details:
 Gems_big Alerts for rubocop
Security alert open on May 29, 2017 08:39
CVE-2017-8418 - Insecure use of /tmp
RuboCop uses /tmp to store cache files insecurely.
Malicious local users could exploit this to tamper with cache files belonging to other users.

    Fixed versions: 0.49.1
    Identifier: CVE-2017-8418
    Solution: There is no solution for this vulnerability at the moment.
    Credit: Jakub Wilk
    Sources: https://github.com/bbatsov/rubocop/issues/4336
    https://github.com/bbatsov/rubocop/commit/dcb258fabd5f2624c1ea0e1634763094590c09d7

We're also waiting for a new RuboCop to fix this non-security issue: https://github.com/bbatsov/rubocop/issues/4412#issuecomment-304562922

Jason - thanks. Now if we could only get the mail gem to work that quickly.


Support for 16 bit activations in ExpandDims operation.

The task is to add support for 16-bit activations and 8-bit weights in ExpandDims operation. Currently, only float32 and int8_t types are supported:
https://github.com/tensorflow/tflite-micro/blob/8e22946b3faa51564df5dd9194f7540b2694892c/tensorflow/lite/micro/kernels/expand_dims.cc#L127C1-L134C13

Hi @miaout17, can you please take a look? Thanks.

Hi @robertkamara,
It looks like this issue appears to have been resolved since PR #2589 was already merged into TFLite-micro repo.
Thank You


registry: debugTransport should print with testing.T.Log

It should not print to STDOUT so that it only prints the debugTransport
output if there was an error in one of the registry tests.
Signed-off-by: Tibor Vass<EMAIL_ADDRESS>Ping @crosbymichael @jfrazelle

LGTM!

LGTM ;)

LGTM merging


Delete moviefile not movie

Description

The del_movie_file function was deleting the movie not the moviefile
Related issues

Motivation and Context

fix bug
How has this been tested

Types of changes

[ ] Docs change / refactoring.
[x] Non-breaking change (fix or feature that wouldn't cause existing functionality to change/break).
[ ] Breaking change (fix or feature that would cause existing functionality to change/break).

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes don't generate new warnings.
[x] I have read the CONTRIBUTING document.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests pass.

@marksie1988 this PR seems mergeable to me.


Fixed typo (ERROR: The Compose file './docker-compose.yml' is invalid because:)

Before PR
es-django-example git:(master) docker-compose up -d
ERROR: The Compose file './docker-compose.yml' is invalid because:
services.elasticsearch.deploy.resources value Additional properties are not allowed ('ulimits' was unexpected)

After PR works great
WARNING: Some services (elasticsearch) use the 'deploy' key, which will be ignored. Compose does not support 'deploy' configuration - use `docker stack deploy` to deploy to a swarm.
Pulling elasticsearch (elasticsearch:5.4)...
5.4: Pulling from library/elasticsearch

@HonzaKral Please review.

@andriisoldatenko +1 thanks for catching that.


Cache the path object for faster pathfinding

Motivation and Context
Make geodesic distance computation faster by caching the habitat-sim path object on the episode.  Caching this path object gives two improvements, 1) no more need to convert List[List[float]] to a 2D numpy array all the time (which is slow!) and 2) goes with https://github.com/facebookresearch/habitat-sim/pull/555 to enable caching of the shortest path finding setup, which can end up being the bottleneck in a lot of cases.
How Has This Been Tested
Existing tests still pass.
Types of changes

New feature (non-breaking change which adds functionality)

CC: @shivanshpatel35 @msavva

Added a check to see if we actually need to recompute the distance to goals, this gives another nice speedup.

I am seeing ~100FPS on my test setup (up from the 25 FPS earlier today) using the latest iteration of this + the latest iteration of https://github.com/facebookresearch/habitat-sim/pull/555


Windows Fatal Exception when running detection demo

Platform is Windows 10.
Using the provided weight, the conversion to TF works perfectly. But when I run the demo on the provided image file, I get the following error:
(gpu) E:\python\tensor>python detect.py --weights ./checkpoints/yolov4-416 --size 416 --model yolov4 --image ./data/kite.jpg
2020-12-26 05:40:42.534777: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudart64_110.dll
2020-12-26 05:40:45.224379: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library nvcuda.dll
2020-12-26 05:40:45.264766: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1760] Found device 0 with properties:
pciBusID: 0000:03:00.0 name: GeForce GTX 1080 Ti computeCapability: 6.1
coreClock: 1.582GHz coreCount: 28 deviceMemorySize: 11.00GiB deviceMemoryBandwidth: 451.17GiB/s
2020-12-26 05:40:45.280503: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudart64_110.dll
2020-12-26 05:40:45.345176: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cublas64_11.dll
2020-12-26 05:40:45.359300: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cublasLt64_11.dll
2020-12-26 05:40:45.412544: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cufft64_10.dll
2020-12-26 05:40:45.435323: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library curand64_10.dll
2020-12-26 05:40:45.469101: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cusolver64_10.dll
2020-12-26 05:40:45.481619: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cusparse64_11.dll
2020-12-26 05:40:45.491012: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudnn64_8.dll
2020-12-26 05:40:45.499793: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1902] Adding visible gpu devices: 0
2020-12-26 05:40:45.566337: I tensorflow/core/platform/cpu_feature_guard.cc:142] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2020-12-26 05:40:45.584430: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1760] Found device 0 with properties:
pciBusID: 0000:03:00.0 name: GeForce GTX 1080 Ti computeCapability: 6.1
coreClock: 1.582GHz coreCount: 28 deviceMemorySize: 11.00GiB deviceMemoryBandwidth: 451.17GiB/s
2020-12-26 05:40:45.599543: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudart64_110.dll
2020-12-26 05:40:45.607441: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cublas64_11.dll
2020-12-26 05:40:45.615144: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cublasLt64_11.dll
2020-12-26 05:40:45.622870: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cufft64_10.dll
2020-12-26 05:40:45.630659: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library curand64_10.dll
2020-12-26 05:40:45.638028: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cusolver64_10.dll
2020-12-26 05:40:45.645754: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cusparse64_11.dll
2020-12-26 05:40:45.653531: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudnn64_8.dll
2020-12-26 05:40:45.661461: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1902] Adding visible gpu devices: 0
2020-12-26 05:40:46.284301: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1300] Device interconnect StreamExecutor with strength 1 edge matrix:
2020-12-26 05:40:46.299399: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1306]      0
2020-12-26 05:40:46.309381: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1319] 0:   N
2020-12-26 05:40:46.315671: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1446] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 8732 MB memory) -> physical GPU (device: 0, name: GeForce GTX 1080 Ti, pci bus id: 0000:03:00.0, compute capability: 6.1)
2020-12-26 05:40:46.454255: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1760] Found device 0 with properties:
pciBusID: 0000:03:00.0 name: GeForce GTX 1080 Ti computeCapability: 6.1
coreClock: 1.582GHz coreCount: 28 deviceMemorySize: 11.00GiB deviceMemoryBandwidth: 451.17GiB/s
2020-12-26 05:40:46.482323: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudart64_110.dll
2020-12-26 05:40:46.494545: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cublas64_11.dll
2020-12-26 05:40:46.504209: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cublasLt64_11.dll
2020-12-26 05:40:46.515880: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cufft64_10.dll
2020-12-26 05:40:46.524911: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library curand64_10.dll
2020-12-26 05:40:46.533753: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cusolver64_10.dll
2020-12-26 05:40:46.545948: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cusparse64_11.dll
2020-12-26 05:40:46.555066: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudnn64_8.dll
2020-12-26 05:40:46.563351: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1902] Adding visible gpu devices: 0
2020-12-26 05:40:46.569493: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1300] Device interconnect StreamExecutor with strength 1 edge matrix:
2020-12-26 05:40:46.577876: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1306]      0
2020-12-26 05:40:46.582431: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1319] 0:   N
2020-12-26 05:40:46.587762: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1446] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 8732 MB memory) -> physical GPU (device: 0, name: GeForce GTX 1080 Ti, pci bus id: 0000:03:00.0, compute capability: 6.1)
2020-12-26 05:41:39.007450: I tensorflow/compiler/mlir/mlir_graph_optimization_pass.cc:127] None of the MLIR optimization passes are enabled (registered 2)
2020-12-26 05:41:40.185961: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudnn64_8.dll
2020-12-26 05:41:40.585076: I tensorflow/stream_executor/cuda/cuda_dnn.cc:334] Loaded cuDNN version 8005
2020-12-26 05:41:41.238752: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cublas64_11.dll
2020-12-26 05:41:41.685357: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cublasLt64_11.dll
Windows fatal exception: stack overflow
Thread 0x00005430 (most recent call first):
File "E:\anaconda3\envs\gpu\lib\site-packages\tensorflow\python\eager\execute.py", line 59 in quick_execute
File "E:\anaconda3\envs\gpu\lib\site-packages\tensorflow\python\eager\function.py", line 556 in call
File "E:\anaconda3\envs\gpu\lib\site-packages\tensorflow\python\eager\function.py", line 1947 in _call_flat
File "E:\anaconda3\envs\gpu\lib\site-packages\tensorflow\python\saved_model\load.py", line 115 in _call_flat
File "E:\anaconda3\envs\gpu\lib\site-packages\tensorflow\python\eager\function.py", line 1765 in _call_with_flat_signature
File "E:\anaconda3\envs\gpu\lib\site-packages\tensorflow\python\eager\function.py", line 1711 in _call_impl
File "E:\anaconda3\envs\gpu\lib\site-packages\tensorflow\python\eager\function.py", line 1698 in call
File "detect.py", line 66 in main
File "E:\anaconda3\envs\gpu\lib\site-packages\absl\app.py", line 251 in _run_main
File "E:\anaconda3\envs\gpu\lib\site-packages\absl\app.py", line 303 in run
File "detect.py", line 90 in
It seems like tensorflow is initializing multiples times throughout the process. Is that normal?

same issue did you solve it?


Encapsulate the caching function

The nested for loop that controls the caching is duplicated in both the informer and estimator stages. We should extract it into a distinct class method.
Original PR comment here: https://github.com/LSSTDESC/rail_deepdisc/pull/15#discussion_r1416643077

This hasn't been completed, but it's not applicable to this package. It's actually mean to be in rail_deepdisc. That being said, this level of code duplication is probably fine. If it were being duplicated 3 or more times, I would start to worry, but twice is ok.


Regression in 3.6.1: wsrun clean executes nothing

I have a repo with a top-level package.json that looks similar to this:
{
  "name": "my-repo",
  "private": true,
  "workspaces": {
    "packages": [
      "backend/*",
      "common/*",
      "frontend/*"
    ]
  }
}

In 3.5.0, wsrun clean would appropriately execute on all workspaces within backend, common, and frontend.
In 3.6.1, wsrun clean does not execute a single command.
I suspect the issue is with https://github.com/whoeverest/wsrun/commit/a3503be5140b1455577b9c933c1f03f50608ee60, as the globs default to ['*'] when it should instead probably default to whatever workspaces within the top-level package.json specifies.

Looks like this affected namespaced packages. Should be fixed with 3.6.2


SortCommand.java: fix typo

Coverage remained the same at 92.415% when pulling 8bf558cc8b754a7a5ccd8e7ecdf58737144bb0b7 on khooroko:Fix_Sort_Command_Typo into 196c3f9386e7a7ff990c08de60d23c84b893d023 on CS2103AUG2017-T17-B1:master.


support conan v2 in test package

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (989c83a) compared to base (96286a2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines           13        13
=========================================
  Hits            13        13

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Confusion about interpretation of results

Hi Ying,
Could I ask if there might be a possibility to write a document explaining the results in the future? I ran the example you provided, but I’m having trouble understanding the resulting files.
Best,
Yu

Hi Yu,
Thanks for your suggestion. Could you specify which part is not clear? It is a gtf format and I would assume user needs to read the manuscript for further understanding.
Best,
Ying

Hi Ying,
Following up this question, I had trouble understanding the gtf file as well. When running the test example, I got an empty gtf file with the following:
## date: 2024-03-06
## gene (copy num = 0): HLA-A,HLA-B,HLA-C,HLA-DMA,HLA-DMB,HLA-DOA,HLA-DOB,HLA-DPA1,HLA-DPA2,HLA-DPB1,HLA-DPB2,HLA-DQA1,HLA-DQA2,HLA-DQB1,HLA-DQB2,HLA-DRA,HLA-DRB1,HLA-DRB2,HLA-DRB3,HLA-DRB4,HLA-DRB5,HLA-DRB6,HLA-DRB7,HLA-DRB8,HLA-DRB9,HLA-E,HLA-F,HLA-G,HLA-HFE,HLA-H,HLA-J,HLA-K,HLA-L,HLA-N,HLA-P,HLA-S,HLA-T,HLA-U,HLA-V,HLA-W,HLA-Y,KIR2DL1,KIR2DL2,KIR2DL3,KIR2DL4,KIR2DL5A,KIR2DL5B,KIR2DP1,KIR2DS1,KIR2DS2,KIR2DS3,KIR2DS4,KIR2DS5,KIR3DL1,KIR3DL2,KIR3DL3,KIR3DP1,KIR3DS1,MICA,MICB,TAP1,TAP2,C4A,C4B,C4X```

I have the same thing when running my own sample. Why the program provide empty output? Is there any suggestions for this?

Thanks,

Hang

Any screen output?

Here it is:

Hi, I am also having trouble interpreting the output gtf. For our study we need the HLA allele calls, but not the detailed annotation information. How do I find the HLA allele calls in the output gtf files?
Thank you for your help.
Dottie

Hi Ying,
Thank you for the help! My confusion is that for some loci, there appear to be more than 2 allele calls. For instance, I filtered the gtf file for all the lines containing 'consensus "HLA-A..."'. It looks like there are >2 calls. Am I looking at the correct place? Which 2 alleles should I select?
Best
Dottie

It is weird, what is your input? does it include multiple individuals?
You may also need to look at the contig names at the first column.


Anchor event listener not recording few transactions

Hi,
I am listening to an event emitted from my program using @coral-xyz/anchor library but it is not recording all the transactions on mainnet. I am using quicknode pro RPC URL for establishing the websocket connection to listen to these events on my program. What could be the reason here?

See https://github.com/coral-xyz/anchor/issues/1613 for more info on why this happens.
event-cpi feature fixes this issue but it's not as ergonomic to use e.g. not as easy to subscribe. See usage example here.


Output Bed file description

Dear Team,
Spectre produces bed file as an output. I used spectre for one sample. Output bed file contains 6 columns. What is 6th column? What is the interpretation, when value in 6th column is 0.0?

Hi  @reshu23
The 6th column of the BED file is the median coverage of the CNV.
If it is 0.0 it would be DEL with a copy number of 0 (CN0), indicating a complete miss of information in that region.
Best,
Philippe

Thank you.


'IdleNotificationDeadline' is deprecated: Use MemoryPressureNotification()

Getting the following warning with Node.js 20.x:
../node_modules/nan/nan.h:686:39: warning: 'IdleNotificationDeadline' is deprecated: Use MemoryPressureNotification() to influence the GC schedule. [-Wdeprecated-declarations]
    return v8::Isolate::GetCurrent()->IdleNotificationDeadline(
...

This method will be deprecated soon.
https://chromium.googlesource.com/v8/v8/+/refs/heads/main/include/v8-isolate.h#1295

While nan's IdleNotification could be changed to use MemoryPressureNotification with newer versions of v8, e.g.
#if defined(V8_MAJOR_VERSION) && (V8_MAJOR_VERSION > 11 ||                      \
  (V8_MAJOR_VERSION == 11 && defined(V8_MINOR_VERSION) && V8_MINOR_VERSION >= 3))
  inline bool IdleNotification(int idle_time_in_ms) {
    v8::Isolate::GetCurrent()->MemoryPressureNotification(v8::MemoryPressureLevel::kModerate);
    return true;
  }

It seems to make more sense to deprecate nan's IdleNotification, and perhaps introduce a new shim for MemoryPressureNotification to the nan API.

Perhaps. Do you have any more details on what the difference is?
On November 2, 2023 6:18:18 PM GMT+01:00, "Vladimir Vrzić" @.***> wrote:

While nan's IdleNotification could be changed to use MemoryPressureNotification with newer versions of v8, e.g.
#if defined(V8_MAJOR_VERSION) && (V8_MAJOR_VERSION > 11 ||                      \
 (V8_MAJOR_VERSION == 11 && defined(V8_MINOR_VERSION) && V8_MINOR_VERSION >= 3))
 inline bool IdleNotification(int idle_time_in_ms) {
   v8::Isolate::GetCurrent()->MemoryPressureNotification(v8::MemoryPressureLevel::kModerate);
   return true;
 }

It seems to make more sense to deprecate nan's IdleNotification, and perhaps introduce a new shim for MemoryPressureNotification to the nan API.

From reading the v8 API docs, while they both IdleNotificationDeadline and MemoryPressureNotification boil down to embedder asking v8 to run GC, the semantics are different.
Concretely the idea behind IdleNotification was for the embedder to notify the engine when they are idle, in order to minimize the chance of GC cycles interrupting actual work. And they would pass an amount of time, a "deadline" for the engine to try and do as much work as possible, and engine would return true if no more GC can be done at that point in time.
On the other hand, the idea behind MemoryPressureNotification is for the embedder to notify the engine that they are running out of memory. Not necessarily when the embedder is idle, this can be called from a separate thread while the isolate is running JS code. The signature is also different, there is no deadline parameter, and no value is returned.
So, while similar, the end user of the API (developer)  would likely not just simply replace calls to IdleNotificationDeadline with calls to MemoryPressureNotification without making other changes to their code.


Glossary items are unstyled

It would be nice if glossary items like in https://www.attrs.org/en/latest/glossary.html could by styled. E.g. bold would be great:

Fixed in 5caf736fcde24257460e652a4117f9057a80bbf2. :)


Add CPack

Add cpack support so that we can support bundling the application into a distributable which:

Can be published into a GitHub Release
Can be published into an App Store release (eventually)

GitHub releases would be a good first step into keeping track of the progress the repository has made. We could release every time there has been considerable bug fixes or a new sample has released

It looks like we did publish some package a few years ago: https://github.com/orgs/KhronosGroup/packages?repo_name=Vulkan-Samples
Maybe we want to disable this for now, as it's pretty outdated

@tomadamatkinson, are we OK closing this now or is there more to do?