File Manager Detail View

In version 9 we're adding a new detail page to the file manager. Here's how it works.

This is a new single page + single page controller found at /dashboard/files/details. It takes a file ID as its parameter, which gets passed into the view($fID = null) method, which populates the object.
This is a standard single page. It is not a fancy javascript application. It doesn't really have much to do with the existing file manager search javascript.
This doesn't really impact the modal file manager. To get to this page, you left click/regular mouse click/tap on a row in the file manager. (Note: the advanced items in the file manager menu are still available by clicking on the ellipses menu icon in the row, see other comps.) This is the behavior when you're browsing the file manager in the Dashboard. When you're in the page selecting you're still in choose mode (although I would expect that the menu icon in the page still works and could take you to the detail page view.) The detail page view here does not work from within the page. Need to access it? It takes you into the Dashboard.
If there's something in this comp you don't understand, or it implies functionality that you don't understand or we don't do, just skip it.

Important
Before you work on this, make sure you read the following two articles about working UI pull requests for concrete5 version 9:
concrete5 Bedrock: A Foundation for concrete5 and concrete5 Themes
https://documentation.concrete5.org/developers/appendix/concrete5-bedrock-a-foundation-for-concrete5-and-concrete5-themes
Submitting User Interface Pull Requests for concrete5 Version 9
https://documentation.concrete5.org/tutorials/submitting-user-interface-pull-requests-for-concrete5-version-9

Hows this going to work with the modal file-manager? i.e Choose file dialogs / also what are our menu options going to be like for those dialogs.
Also is the file manager itself changing layout

@deek87 I've updated the ticket a little bit with some answers. The detail view is just a standard single page. It's not accessible from the frontend. The file manager is changing layout...you can see how search UI updates are changing from within a separate ticket in this project.

What should happen when clicking the buttons?

Preview

Swap: should we open the standard file picker (the one provided by the OS)?
Edit: we should open the image editor, right?

Attributes

Edit: open an "Edit attributes" dialog?

Statistics

More: open a new dialog or append next downloads directly to the list above?

Storage Location

Edit: open the existing "Storage Locations" dialog?

Great questions.
Picking Swap should open the replace dialog that we have. Not the file picker, but the replace dialog that lets you upload a replacement.
Edit should open the edit view if the file type supports it (which is really just images)
Edit attributes should open an edit attributes dialog with attributes showing up in the list similar to the attributes panel for a page. It should not use the x-editable inline editing of attributes that we have in the version 8 and below because we're phasing that out as its always been buggy and it doesn't work well with bootstrap 4.
Let's make statics a new dialog and storage locations open up the dialog as well.

In the comp, the help text under the File Usage part of the Statistics section is wrong (it's For debugging only, this is the complete URL to the source file. which is the same as the help text under the File in OS part of the Storage section).

Yeah, that looks like a mistake in the comp to me.

Should I write something else instead?

I don't think you need to, let's just not have help text there for now.

The layout of the items in the Attributes section is very different from the one of the Statistics and Storage sections.
What about using the same for both? I'd prefer the one of the Statistics/Storage sections.

That's fine – we do still want the values to float to the right of the labels like they do in the comp – but if you're objection is that they indent more than the other sections, I agree, I think they should look the same indentation-wise. Using standard bootstrap column classes here and using the same classes throughout all the sections might enough.

So, if I understand correctly, we should make all the 3 sections having the standard 2-column bootstrap layout? If so, should the labels be aligned on the left or (like the comp) on the right?

I think there are enough differences between the sections that I don't want them to all just be treated the same. Let's try and match the comp as much as possible. If you don't want to have that large indented area in the attributes section that's fine, but we do want to have the labels floating right in the attributes section and them not floating in the others.


Upgrade to firebase functions 1.0

The Migration Guide can be found here

Running into issues here and awaiting feedback from the firebase team: https://github.com/firebase/firebase-functions/issues/228

#789 is now updated to resolve this.


Allows you to limit downloads

As requested by a recent issue, this adds and option to limit the max number of images to download if it's passed as a parameter to the parse function

As requested by a recent issue, this adds and option to limit the max number of images to download if it's passed as a parameter to the parse function

Thank you for the contribution. I've approved it.


Add topic toggle to side bar

Add ON/OFF topic toggles.  By default (configurable), first 3 topics will be toggled ON.
As a user
I want to be able to toggle topics on and off
so that I only see topics that I am interested in.

Done 419e99c


MRTK_DefaultPointerLine material is behind ui.

Overview
Is there a reason why the pointer line has different material than the cursor?

Changes
Changed to same shader as used by the default cursor material (with unity 2018.2.17f1)

@wassx Unfortunately, it looks like the MRTK Standard Shader isn't compatible with Unity's LineRenderers, since the pointer gradient and colors are no longer showing up after this PR:

Expected
Actual

I may have to revert this change, but I'm looking into a solution for you.


feat: support solara server by getting the kernel id from solara.

Current dependencies on/for this PR:

master

PR #5

PR #6

PR #7   👈

This comment was auto-generated by Graphite.


Odds and ends

@abiogenesis-now This looks really good. I just noticed a few more small details.

This change is

Thank you for the fixes @steveperry-53 ! I'll make sure not to overcapitalize headers from here on out.
/lgtm


[Feature] nconf-redis

Hi @ewr, StreamMachine seems like a great project. Thank you for all your work on this! I'm setting it up to try transitioning the LPFM I work with to use SM for our internet broadcasts.
I'm wondering why not use nconf throughout the project with nconf-redis to persist the configuration.
It seems like it'd make the configuration more consistent throughout the project and enable starting with a redis-backed configuration directly rather than the steps described in the 'Ubuntu Installation' wiki page.
I'd be happy to spend some time working on this if it's a direction you'd like to take.
Also, I've built a docker environment that will run a master-slave configuration of StreamMachine with redis-backed storage and an additional liquidsoap container that streams to SM. Still has a few kinks, hence raised the issue above, but I'll put that up as soon as there's a readme. Shouldn't be hard to add in ElasticSearch as an additional service once the base configurations are smoothed out.

In case you're interested, I put up the docker configuration here:
http://git.gabeos.cc/gabeos/docker-liquidsoap-streammachine

Thanks for this, i'm working on a similar project for community radio, will share anything useful I have as well. I wonder if this repo is actively maintained anymore? Not much interaction from the members of late...

I'm not sure -- I imagine its still running in prod for them, and just isn't getting much attn because it already works and is integrated. I'm actually about to put it up in prod for us, so if there are any updates on my gitlab repo it'll be because i found a bug or something :)
If you're interested in documentation on how we put it into prod, I'll probably write it up to have internal documentation and can add it to the repo or post it elsewhere. Just lmk.
Sorry for my repo being down -- have been doing some updates over the past few weeks. It should be there for you now if you want to check it out.


I need to change the chat theme for android.

As it is not supported yet.

added  inside strings.xml

working perfect now

Thanks for sharing @sayancitytech, glad to know it worked for you.
Perhaps we need to update the docs to mention explicitly that the options can be set directly on the Android level. Closing the issue for now


Error compiling with latest snapshot

Hello, I'm using the latest swift snapshot downloaded from swift.org. I've created a new app with vapor's CLI, but when trying to compile the app with vapor build, I receive the following output:
[hello-world (master)]$ vapor build
Cloning https://github.com/qutheory/vapor.git
Resolved version: 0.8.2
Cloning https://github.com/open-swift/S4.git
Resolved version: 0.6.1
Cloning https://github.com/open-swift/C7.git
Resolved version: 0.7.1
Cloning https://github.com/Zewo/String.git
Resolved version: 0.7.1
Cloning https://github.com/qutheory/pure-json.git
Resolved version: 2.0.0
Cloning https://github.com/ketzusaka/Hummingbird.git
Resolved version: 1.7.0
Cloning https://github.com/ketzusaka/Strand.git
Resolved version: 1.2.3
Cloning https://github.com/CryptoKitten/HMAC.git
Resolved version: 0.7.0
Cloning https://github.com/CryptoKitten/CryptoEssentials.git
Resolved version: 0.7.0
Cloning https://github.com/CryptoKitten/SHA2.git
Resolved version: 0.7.0
Cloning https://github.com/Zewo/MediaType.git
Resolved version: 0.6.0
Cloning https://github.com/Zewo/StructuredData.git
Resolved version: 0.7.1
Compile Swift Module 'C7' (21 sources)
Compile Swift Module 'String' (1 sources)
Compile Swift Module 'PureJson' (5 sources)
Compile Swift Module 'Strand' (1 sources)
Compile Swift Module 'CryptoEssentials' (14 sources)
/Users/xcadaverx/Desktop/dev/Swift Projects/vapor-helloworld/hello-world/Packages/Strand-1.2.3/Sources/Strand.swift:55:53: error: cannot convert value of type '(arg: UnsafeMutablePointer<Void>!) -> UnsafeMutablePointer<Void>!' to expected argument type '(@convention(c) (UnsafeMutablePointer<Void>?) -> UnsafeMutablePointer<Void>?)!'
                guard pthread_create(&pthread, nil, runner, pointer) == 0 else {
                                                    ^~~~~~
/Users/xcadaverx/Desktop/dev/Swift Projects/vapor-helloworld/hello-world/Packages/PureJson-2.0.0/Source/JsonParser.swift:391:49: warning: single argument function types require parentheses
    func prefixUntil(_ stopCondition: @noescape Generator.Element -> Bool) -> Array<Generator.Element> {
                                                ^~~~~~~~~~~~~~~~~
                                                (                )
<unknown>:0: error: build had 1 command failures
error: exit(1): /Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2016-05-09-a.xctoolchain/usr/bin/swift-build-tool -f /Users/xcadaverx/Desktop/dev/Swift\ Projects/vapor-helloworld/hello-world/.build/debug.yaml

Make sure you are running Apple Swift version 3.0.
Vapor only supports the latest snapshot.
Run swift --version to check your version.

Error: Could not build project.
[hello-world (master)]$ swift --version
Apple Swift version 3.0-dev (LLVM dffa09ffd8, Clang 9f0d189820, Swift 1c720b8f84)
Target: x86_64-apple-macosx10.9
[hello-world (master)]$

Vapor still uses 05-03-a. You can check the .swift-version to be sure.
05-09-a support is being delayed because of a bug with the compiler and one of our dependencies.


Where to go to learn...

I have to admit, as a Systems Admin I have been VBScript'ing for many years, but I am just starting to learn VB.net. I am in the process of creating an application for managing Microsoft's Hyper-V. If anybody has used 5Nine Manager before, it is essentially like that, but the idea is to be more "Enterprise" than their solution (picture VCenter for VMware).
I have a pretty good product going so far, but I need a way to view the virtual machine consoles. FreeRDP seems to be the way to go (5Nine uses it for their console access), but I know ZERO about programming in C.
I do not expect anybody here to create a build for me, but I would like to know, where should I go to get started with learning it? I essentially would like to embed a borderless, no title bar, FreeRDP into a WinForm, but I do not know where to begin. Trying to launch a prebuilt FreeRDP and setting the parent to the form is not working.
Any resources or documents you could point me to would be much appreciated.

Closing as off topic (and already answered)

Unfortunately, it looks like all those samples have been removed. This sounds like a good idea, and thank you for pointing it out, but I cannot find anything with working links.
I also found these:
https://blogs.msdn.microsoft.com/taylorb/2010/06/01/writing-your-own-vmconnect-appweb-interface-for-vm-console-access-to-hyper-v-vms/
https://blogs.msdn.microsoft.com/virtual_pc_guy/2010/02/03/hyper-v-activex-rdp-control/
But again, the code.msdn.microsoft.com links are all broken. :-(

The codeproject link I provided still works (I just tried it). There should be enough info in there to get you started.
There's also these (code availability verified)
https://github.com/raddeus/RDP_Connection_Manager/tree/master/RDPManager
https://code.msdn.microsoft.com/CCS-LABS-Remote-Desktop-dd1f1cdf/sourcecode?fileId=74600&pathId=513223851

I may just be stuck with a large learning curve, because every sample I can actually find will not build on .NET 4.0 or higher (my project is on .NET 4.6). I also found this:
"Unfortunately, there are no plans to release the RDP Active-X control again." - DDTK_Support_Team
https://social.technet.microsoft.com/Forums/office/en-US/41da3097-94b5-4014-8ece-8f1589bdb4e7/where-to-download-hyperv-rdp-activex-control-?forum=winserverhyperv
It looks like this may be a dead-end.

Here is an active C# project that is still using that control... https://github.com/terminals-Origin/Terminals
...so it seems to be technically possible, but you're going to have to do the work to understand how to add and use the control to your own project rather than just compiling someone else's code.

Thank you for all the assistance, byteboon, but it appears the answer was built into FreeRDP this whole time. I cannot seem to get the FreeRDP window to launch in a different size (I have tried "... /w:1024 /h:768" and "... /size:1024x768"), and it launches the same size every time no matter what. This sent me to the Wiki to ensure I had the syntax correct, I still can't size the window, but low and behold, I find...
/parent-window:
This works perfectly!
Dim proc As New Process
Dim startInfo As New StartInfo With {
.FileName = """" & appPath & "\console\wfreerdp.exe""",
.Arguments = "/parent-window:" & Form1.Panel1.Handle.ToString() & " /u:UserName /p:........"
}
proc = Process.Start(startInfo)
I am having an issue setting keyboard focus to the FreeRDP window as a child now, but I have successfully docked it in my WinForm. That's what I needed! 👍


Roadmap: chess.js 1.0.0

After 13 years of pre-1.0.0 development .... it's time.
This is a working document to track planned features/changes and their statuses for version 1.0.0.  Please comment if there's something you'd like to see included or changed. I appreciate and value your feedback.  Check back frequently for updates.
I'll push a basic typescript implementation to dev branch to use as starting point.
Please wait for the dev branch before submitting PR's.
dev branch is now active
Proposed 1.0.0 Changes

[ ] Code

[x] Rewrite library in typescript
[x] Use camelcase for API and everything else

[x] enforce with eslint rule

[x] Use exceptions in error states instead of returning null. This will allow the library to provide more detailed error messages for common issues (e.g. bad moves, bad FEN, bad PGN).  The functions that throw exceptions are listed in the API Changes section.

  The phrase sloppy is kind of passive aggressive, so maybe use the terms permissive and strict.

[X] load in permissive mode (the default mode) should let the user load FEN without supplying castling rights, ep square, and move numbers (e.g. chess.load(rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR w))
[x] load and loadPgn should allow an option to use the strict parser

[ ] moves() should work even if there are no kings on the board.
[x] Only set the en passant square when the opponent can legally make an en passant move. (see #294)
[x] Add a 'lan' (better name or is this ok??) property for long algebraic notation (see #259)
[x] Improve FEN validation.  It should detect common hand-entered such as missing kings and incorrect castling rights.
[ ] Use fast-check for property-based testing

[ ] Docs

[ ] create a chess.js logo (maybe this is something the community can vote on??)
[ ] Move documentation to chessjs.org
[ ] Add an FAQ section to answer common questions

[ ] Other

[ ] Github issue template ensuring the reporter know the rules of chess before filing a bug  (en passant gets flagged as a bug a few times a year)
[ ] Prefer stackoverflow for chess.js usage questions, github issues for bugs

API Changes

[x] game_over -> isGameOver
[x] in_check -> isCheck
[x] in_checkmate -> isCheckmate
[x] in_draw -> isDraw
[x] is_stalemate -> isStalemate
[x] in_threefold_repetition -> isThreefoldRepetition
[x] insufficient_material -> isInsufficientMaterial
[x] load_pgn -> loadPgn
[x] set_comment -> setComment
[x] get_comment -> getComment
[x] get_comments -> getComments
[x] delete_comment -> deleteComment
[x] delete_comments -> deleteComments
[x] validate_fen -> validateFen
[x] The following functions should throw exceptions in the event of an error

[x] Chess constructor
[x] load
[x] loadPgn
[x] move

Questions

Should acronyms be capitalized in function names (e.g. loadPgn vs loadPGN)?  Consider the impact this could have on the .fen() and .pgn() functions. I'm leaning towards no, but it's up for discussion. Decided not to capitalize acronyns.
Should we adopt the chess.js TypeScript definitions from DefinitelyTyped as a basis for our types?

Future Changes beyond 1.0.0

use piece lists for increased move generation performance
use a parser generator to parse PGN
add support for RAV (recursive annotation variations)
add support for null moves
chess960 support

Issues for First Time Contributors

add a default separator='\n' parameter to the ascii() function

Hey @jhlywa ,
Great to see this is back in development!! Have been using the stable package for our project...
Had a request... Is it possible to add variations support...? Or Is it something that you're planning to add...? Like in @aaronfi 's project chess-es6

The variation code will most likely come later in version 2.0.0 (I refer to it above as RAV - Recursive Annotation Variation). The PGN loading code needs to be rewritten from the ground up.  It's currently a set of hand crafted rules that are a little tedious to maintain and follow. A better approach would be to include the PGN grammar and then use a parser generator to generate the parsing code.  Once this is done, dding support for variations should be significantly easier.

Hey @jhlywa,
Had a doubt... How would you go about with creating the PEG file / Grammar file? Will you be creating one from scratch or referring to an existing one like, PGNViewer...? Looking into the PGN Grammar right now..

Just began using this repo, but this is exciting! I'll happily make some contributions once the FIX_ME branch is live.

@coffeeDev98 I'd be interesting in creating the grammar from scratch. I think it would give us a better understanding of how the  PGN parser works, and frankly, I think it would be easier than maintaining the existing regexes.

Hi all, I just pushed the new dev branch this morning.  I manually copied over all of the tests from the 0.13.2 tag and added a few extras where necessary.  However, there does seems to be a discrepancy in the number of tests cases jest is running in 0.13.2 (339 test cases) and dev (237 cases).  We should investigate this.

I shall do a deep dive of the code before contributing... Any advice on the same...? I'm new to contributions on github... 😅

@jhlywa, did you ever resolve the test issue? I don't see as big of a discrepancy between v013.2 and dev as you state:
Andrews-MacBook-Pro:chess.js andrew$ git checkout v0.13.2; npm test 2>&1 | grep "Tests:"
HEAD is now at 426e7ed 0.13.2
Tests:       338 passed, 338 total
Andrews-MacBook-Pro:chess.js andrew$ git checkout master; npm test 2>&1 | grep "Tests:"
Previous HEAD position was 426e7ed 0.13.2
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
Tests:       339 passed, 339 total

Hi @DevAndrewGeorge. No, I haven't been able to account for the discrepancy in tests cases.  I did omit a few cases that I though were redundant on the dev branch, and also refactored a few others. I expected to be within 10-20 tests cases of v0.13.2, but running your snippet on dev shows we're missing about 100 cases.  (BTW - I think you ran on the wrong branch, be sure you're on dev  when generating a test count)
$ git checkout dev && npm test 2>&1 | grep "Tests:"
Tests:       237 passed, 237 total

Ah, good catch. The main source of your discrepancy is that the validate_fen.test.ts file ran all cases in a single test. See #333 where I've "fixed" this in by running each case individually.

@jhlywa Would it be possible to request an alpha NPM release of this? I'm using this for a side project, so I don't mind if things aren't 100% right now, but I would like to use this project in CI, and it's a bit tricky right now with the current flow of manually building the package.

Also, if there's a major version bump coming anyway, can I suggest the accessor functions that take no arguments be converted to properties? For example:
fen() {
   .
}

Could become:
get fen() {
  ...
}

Another request:
For the history function, it would be really handy if each value in history included the fen at that point in the time.

Improve FEN validation. It should detect common hand-entered such as missing kings and incorrect castling rights.

If missing kings is considered invalid, extra kings should also be considered invalid.  kkkkkkkk/8/8/8/8/8/8/KKKKKKKK w KQkq - 0 1 is an example board discussed in issue #289

Wicked stuff! Using Chess.js in our Chess engine! Gave the package credit for move generation and game state detection on the website and the in the docs :)

Never capitalize abbv, they tend to mess with other things.

Hi all. The latest beta has been pushed to NPM. I have one more planned code change (adding a before and after FEN field to to verbose history output). Here are the release notes:
https://github.com/jhlywa/chess.js/releases/tag/v1.0.0-beta.0

There's a packaging issue with the beta:
npm ERR! command failed
npm ERR! command sh -c -- npm run build
npm ERR! ><EMAIL_ADDRESS>build
npm ERR! > tsc --build
npm ERR! sh: tsc: command not found

It looks like the module ships with the typescript code (src/chess.ts) as well as the JS code (dist/chess.js and types file) but also has a postinstall step that runs tsc.  Since main points to the JS file in the dist folder, is that post-install step necessary?

@SheetJSDev Doh! Thanks for the feedback. A fix tagged 1.0.0-beta.1 has been published.

Hi all. The latest beta has been pushed to NPM. I have one more planned code change (adding a before and after FEN field to to verbose history output). Here are the release notes:
https://github.com/jhlywa/chess.js/releases/tag/v1.0.0-beta.0

This change would be really nice, having before and after fen :)

@qwerty084 before and after have been added to the Move object returned by .move(), .undo,  .moves(), and .history(). The two latter methods need to be called with { verbose: true } to return Move[].
It's been pushed to npm as 1.0.0-beta.4

🥺 waiting for chess 960 support https://github.com/jhlywa/chess.js/issues/122

I am interested in the support for null moves and I have already made some thoughts how to implement such a feature to this package. Before I provide a pull request, have there been any thoughts on the SAN of a null move. There is no standard SAN representation for a null move. I would suggest "--" but there are others (see e.g. https://chess.stackexchange.com/questions/14072/san-for-nullmove )

Hi @ppeloton. The lack of a standard is why we traditionally didn't support null moves. However, with switch to the permissive SAN parser, I think it's time we add it. I think it's reasonable to start with "--" as the SAN representation of a null move.

looking forward 960 support!


Add cinematic transition

Like hesitate, but goes to 16:9 in the middle

@keyframes wipe-cinematic-out {
  0% {
    clip-path: inset(0 0 0 0);
  }
  30%, 70% {
    clip-path: inset(10% 0 10% 0);
  }
  100% {
    clip-path: inset(100% 0 100% 0);
  }
}

@keyframes wipe-cinematic-in {
  0% {
    clip-path: inset(100% 0 100% 0);
  }
  30%, 70% {
    clip-path: inset(10% 0 10% 0);
  }
  100% {
    clip-path: inset(0 0 0 0);
  }
}

looks like it's just 2 new css custom props and then the work to teach all the parts of this build system to include the files

live https://www.transition.style/#out:wipe:cinematic


Invalid token while using Inception

Hello,
Often times when I run reinforcement learning with the Inception module enabled I get the following error:
Traceback (most recent call last):
  File "/home/jovyan/cristian/REINVENT4/reinvent/Reinvent.py", line 312, in <module>
    main()
  File "/home/jovyan/cristian/REINVENT4/reinvent/Reinvent.py", line 292, in main
    runner(input_config, actual_device, tb_logdir, responder_config)
  File "//home/jovyan/cristian/REINVENT4/reinvent/runmodes/RL/run_staged_learning.py", line 377, in run_staged_learning
    terminate = optimize(package.terminator)
  File "//home/jovyan/cristian/REINVENT4/reinvent/runmodes/RL/learning.py", line 143, in optimize
    agent_lls, prior_lls, augmented_nll, loss = self.update(results)
  File "//home/jovyan/cristian/REINVENT4/reinvent/runmodes/RL/reinvent.py", line 29, in update
    return self.reward_nlls(
  File "//home/jovyan/cristian/REINVENT4/reinvent/runmodes/RL/reward.py", line 157, in __call__
    loss = inception_filter(
  File "//home/jovyan/cristian/REINVENT4/reinvent/runmodes/RL/memories/inception.py", line 219, in inception_filter
    agent_lls = -agent.likelihood_smiles(inception_smilies)
  File "//home/jovyan/cristian/REINVENT4/reinvent/models/model_factory/reinvent_adapter.py", line 17, in likelihood_smiles
    return self.model.likelihood_smiles(smiles)
  File "//home/jovyan/cristian/REINVENT4/reinvent/models/reinvent/models/model.py", line 264, in likelihood_smiles
    encoded = [self.vocabulary.encode(token) for token in tokens]
  File "//home/jovyan/cristian/REINVENT4/reinvent/models/reinvent/models/model.py", line 264, in <listcomp>
    encoded = [self.vocabulary.encode(token) for token in tokens]
  File "//home/jovyan/cristian/REINVENT4/reinvent/models/reinvent/models/vocabulary.py", line 60, in encode
    vocab_index[i] = self._tokens[token]
KeyError: '%11'

Another token for which I often get this error is [SH].
I was wondering about any possible solutions to this error and why REINVENT ends up generating smiles strings with tokens outside of the original vocabulary. Thank you in advance!

Hello Hanes,
Thank you for the quick response!
I don't give any input smiles to REINVENT. I searched for the %11 token in the staged_learning.csv file and I found it in the following SMILES:
98.6043,96.0853,-50.0053,0.3600000,CN(C)CCOc1ccc(-c2ccc(Cc3ccc4cc(C5CCCCN5C(=O)c5cc(-c6nccs6)ccc5-c5cc(C(=O)O)c(-c6cc(-c7nc(N8CCc9cccc(C(=O)N=c%10[nH]c%11ccccc%11s%10)c9C8)ccc7-c7nc(O)cn7CCO)on6)c(C(F)(F)F)c5)ccn34)cc2)cn1,O=C(N=c1[nH]c2ccccc2s1)c1cccc2c1CN(c1ccc(-c3ncc[nH]3)c(-c3cc(-c4ccc(-c5ccc(-c6nccs6)cc5C(=O)N5CCCCC5c5ccn6c(Cc7ccc(-c8cccnc8)cc7)ccc6c5)cc4)no3)n1)CC2,0.3600000,0.3600,55
It has a good score relative to the other generated compunds so it probably ended up being stored and then sampled from Inception.
I attached some files that might come in handy if you want to look further into this issue. Feel free to reach out if you need anything else!
_staged_learning.json
staged_learning_1.csv
z_default_run.log
Best,
Cristian

That's a rather unusal setup.  You have a batch size of 550 plus 50 from the replay memory.  It is more typical to run with a number around 100.  The batch size will have an influence on the SGD, potentially rather strong.  I also note that from your log file the total score is very low and the number of valid SMILES drop rather quickly to below 50%.  Given that also your molecule size increases by quite a bit, you must have a rather unusual scoring component or, potentially, a faulty one.

Thank you for the feedback! I really appreciate it.
I have been using the DRD2 binding site oracle from TD Commons for the scoring.
Setting unique_sequences = false makes the score increase considerably while the number of valid SMILES stays above 95% during the whole training and the fraction of duplicates hovers around 1%. The molecule size still increases slightly though.
It is interesting that changing only this setting made such a big difference. Are there any potential shortcoming to doing it?

Hi,
what unique_sequences  does is to supress sampled duplicate sequences.  A sequence is an integer array that is translated to "tokens" which are then interpreted as SMILES.  So, this is a mechanism to filter out duplicate molecules.  However, the same molecule may have different SMILES/sequences, i.e. different ordering of atoms and nesting of branches, esp. because nowadays our priors are trained on randomized SMILES.  I do not really know why we have this functiontality, maybe it was an early form of deduplication that may have worked at that time.  We only keep it for backward compatibility.  It is clear that this will result in incomplete duplicate filtering.
Sequence duplicates are entirely removed meaning that no down-stream code will be aware of this fact.  This is important, however, for the diversity filter (DF) you are using.  The DF takes explicitly account of duplicates.  First, it looks at duplicate molecules (the SMILES have been canonicalized at this step such that the SMILES is unique to a molecule) and scores every further occurence of the SMILES as zero.  Second, the augmented "NLL" is a sum of the prior NLL and the scaled scores.  The score will only be non-zero for the first time a SMILES is encountered but will be zero for every further occurence.  However, the prior NLL for this SMILESS will keep its value.  So, it makes a difference if and how duplicates are handled.
We have seen rather pathological cases likes yours although not with your setup and not in connection with unique SMILES.  So, thank you for reporting this.
Hope that helps,
Hannes.

Thank you!


Circle disappears on zoom

Issue description
The circle defined in the map disappears when I zoom in or out of the map.
Steps to reproduce and a minimal demo of the problem
See the example here:
https://plnkr.co/edit/mP7WYdjDChilWx59Jdth?p=preview
What steps should we try in your demo to see the problem?
Current behavior
Circle disappears.
Expected/desired behavior
Circle should stay visible.
angular2 & angular-google-maps version
agm/core 1.0.0-beta.1
Other information

The only workaround I've found is to manually reset the visible flag on (zoomChange).
https://plnkr.co/edit/GPceXFHwXIIzWcUIwgN3

+1 just want to add that it kinda reappears when dragged a wee bit when editable.


GPII-2958: Helm chart for preferences service

This is not ready to be merged yet.
While this works correctly with manual install – there are couple open issues:

Chart dependencies and install order
Rolling deployments and app version updates

LGTM!

LGTM! This is a nice step forward for gpii-infra.


Added initial i18n implementation for Signup-form

🤖 Generated by Copilot at 95ee3cb
This pull request updates the translation files for the Ghost signup-form feature. It also adds initial signup-form.json files for different languages.

You'll also need to append to https://github.com/TryGhost/Ghost/blob/09ded37d9163dcb9ad29e364b596f6da4d462fbd/ghost/i18n/package.json#L18-L20 for everything to work properly. Once you've added the new command, you can run yarn translate from ghost/i18n and it should populate all the signup-form.json files with the extracted keys


⚠ ClamAV has degraded performance

In c67c6e8, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 90 ms

Resolved: ClamAV performance has improved in dd3f2ec after 5 minutes.


jx-go-http to 0.0.1

Promote jx-go-http to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cassianobein: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

promotion-build
7dc26a6acbb7ce182948bffc427b2ea06b614293
link
/test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Row dropdown works + added Delete by row selection option

Tested on basic-example.html

This PR is empty?


Fix use of Backward on macOS

🦟 Bug fix
Summary
SDFormat CI (eg. https://build.osrfoundation.org/job/sdformat-ci-sdformat10-homebrew-amd64/48/) is failing on macOS because ign fails to find libignition-tools-backward. The problem is that $<TARGET_FILE> yields the full path of the library in the build
directory, which will likely not be available in binary distributions of ign-tools. This instead uses the install path of the library.
Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

I think we should consider doing that here and adding a test that invokes ign

I've added tests that use cmake to invoke ign, but I don't know how to tell Jenkins about the test results. Do you have any recommendations? The other option is to add gtest and call the tests from an executable built with gtest.


add section on operation protection

Describe the method of authorizing certain scripts for vendor's own automation only.

Dropping the idea as impractial.


CheapThreads.jl will be renamed Polyester.jl

https://github.com/JuliaRegistries/General/pull/37172
The name change should happen by Monday. Not sure if CompatHelper will catch this.
All you should have to do is replace CheapThreads with Polyester. It's simply been renamed.

Thank you for the information, I'll change it by then.

CheapThreads is now replaced in v0.4.1.


Investigate Windows Functional Jupyter failures

  1) DataScience LiveShare tests
Export from guest:
     AssertionError [ERR_ASSERTION]: Uri not returned from export
at Context.test (out\test\datascience\liveshare.functional.test.js:263:16)

  2) DataScience Native Editor
Editor tests
Failure:
     Error: Waiting for finished_rendering_cells timed out
at Timeout.setTimeout (out\test\datascience\testHelpers.js:39:28)

Seem to both be showing up across Windows 3.5 -> 3.7 in recent runs.

My mistake. Dupe of #8483
https://github.com/microsoft/vscode-python/issues/8483


feat: add option not to render span in message

User story:
As a user I want the log messages to show up as I log them without modification
As a user I want to use third-party JSON parsers to look for exact log messages
Desired results
sample code
tracing::info!(message = "My custom message")

output
{"v":0,"name":"MY_APP","msg":"My custom message","level":30,"hostname":"my_hostname","pid":1,"time":"2022-09-23T21:15:28.304173938Z","target":"my_app","line":51,"file":"src/main.rs"}

Other changes

refactor: replaced usages of "message" with constant MESSAGE_KEY
refactor: followed clippy suggestion to use and_then rather than flatten

Closing notes

Later (perhaps at 0.4.0) we may want to consider transitioning to a builder pattern for specifying more advanced options (Of course retaining a simple new function to construct using default options).
Did you want me to run cargo-fmt?

I am not interested in adding further customisation knobs to this formatting layer beyond the ones that are strictly necessary, I am sorry.

Understandable, I'll use a different key besides message.


DWC I3C master

This introduces a basic API for DesignWare I3C master controller.
This is developed using emulation platform.
Here are a few things that I have tested :
Broadcast RSTDAA works.
Broadcast ENTDAA works.
GETBCR/GETDCR works.
Able to get chip ID from the I3C slave devices.
Dynamic Address assignment tested.
I3C Private R/W working.
I3C CCC Commands works.
I3C SDR and HDR-DDR mode works.
Following things are to be done:
I3C Hot-Join
I3C HDR other modes
I2C Legacy Device Support
Broadcast SETDASA
I3C slave mode support

would be nice to have this also associated with a platform so we can at least build the code.

This has been tested in internal emulation environment, as of now we do not have plan to upstream this platform.

in

would be nice to have this also associated with a platform so we can at least build the code.

This has been tested in internal emulation environment, as of now we do not have plan to upstream this platform.

@dcpleung @XenuIsWatching I have addressed the review comments and updated the patches please review.

"you might be able to use i3c_device_basic_info_get for all this. This MAX_DATA_SPEED_LIM could be something to be considered added to that function"
"I'd also expect a GETHDRCAP to be added as well since DDR support is coming with this and for that bit to be checked when attempting a DDR operation"

Let me check and test this, will get back with updated patch set for same.

Hey @shashankprashar sorry this PR didn't get in, but now that we have an i3c API in the tree, maybe you could submit your DW driver using the new API?


ValueError: loaded state dict contains a parameter group that doesn't match the size of optimizer's group

Hi, author. Thank you for your great work first. I try to render horns' pictures by using the pretrained-model on generalization dataset. But  when I run the render.py with parameters "--config configs/gnt_llff.txt --eval_dataset llff_render --eval_scenes horns --expname gnt_horns --chunk_size 500 --N_samples 192", it return "ValueError: loaded state dict contains a parameter group that doesn't match the size of optimizer's group"
Traceback (most recent call last):
File "/home/zheshi/Documents/GNT/render.py", line 191, in
render(args)
File "/home/zheshi/.local/lib/python3.8/site-packages/torch/autograd/grad_mode.py", line 28, in decorate_context
return func(*args, **kwargs)
File "/home/zheshi/Documents/GNT/render.py", line 66, in render
model = GNTModel(
File "/home/zheshi/Documents/GNT/gnt/model.py", line 76, in init
self.start_step = self.load_from_ckpt(
File "/home/zheshi/Documents/GNT/gnt/model.py", line 161, in load_from_ckpt
self.load_model(fpath, load_opt, load_scheduler)
File "/home/zheshi/Documents/GNT/gnt/model.py", line 127, in load_model
self.optimizer.load_state_dict(to_load["optimizer"])
File "/home/zheshi/.local/lib/python3.8/site-packages/torch/optim/optimizer.py", line 146, in load_state_dict
raise ValueError("loaded state dict contains a parameter group "
ValueError: loaded state dict contains a parameter group that doesn't match the size of optimizer's group
Can you help me with this problem? Thanks in advance.

Hi @ds22058, thank you for your interest in our work! and apologies for the delay in our response.
The released checkpoints were trained from a private codebase, which I cleaned for public release. During the cleaning, I renamed a layer for better readability but this led to a naming mismatch with the checkpoints. I have fixed this and can confirm that it works from my end. Please let me know in case you run into further trouble!
Thanks

Thank you for your reply and I have already solved this issue

Hi, I met another trouble when I try to render on my own dataset with angle ranged from 0 to 180. It could output result but the depth was abnormal when it came to the angle near 90.

Just like it was magnified when angle came to 90 and when it went close to 0 and 180 it became normal. I modified the dataset's angel from 0 to 60 and it worked.

I modified the 'depth_range' in the llff_render.py and the coefficient is 'depth_range[0] * 1.8, depth_range[1] * 1.0', the result's depth seemed to be normal but the render quality became worse.

I tried to retrained the model with the modified coefficient in depth_range but didn't work. I really want to know how can I solve this issue. Thanks in advance!


Add bottom-left placement

How should I interpret bottom-left?

As in: what's the difference with other placements?

It puts the popover in the bottom-left of the parent. If you use bottom, it’s centered in the parent (width wise) and if you use left, it’s off to the left. In my application, I’ve got a table and I want the popup to be below the line when clicked, but I want it on the left side of the screen - not in the middle (which would happen with bottom) as the popup might be wide…
The picture shows this (hopefully)…
(and thanks for the nice directive by the way - this should be a standard feature)

The picture didn't come through off the email...

Makes sense. Could you fix the build failures? Looks good to merge then.

Thanks - will do (probably a little later).

Released to NPM as<EMAIL_ADDRESS>Thanks a lot!


ngclient rollback improvements

Fixes #1498
Improve rollback protection in ngclient
Spec does not explicitly say so but the intent is that "local" timestamp and snapshot metadata can be trusted for rollback checks of new versions of the same metadata even if the local metadata is expired. This is similar to root (but in that case the intent is explicitly explained in the spec).
Likewise intent is that "local" snapshot can be trusted for rollback checks of new versions of the snapshot even if local snapshot does not match the meta version in current timestamp.
Implement the above by moving the expiry and meta version checks to the "next" metadata update: check timestamp expiry just before snapshot is updated, and check snapshot expiry and meta version just before targets is updated. This means that when e.g. a second timestamp (that was downloaded from remote) is loaded, the current (first) timestamp is used for rollback checks even if it is expired -- but when snapshot is loaded the expiry of the current, final timestamp is checked.
Some additional details -- note especially the two divergences from the spec letter (but IMO not intent):

the expiry/meta checks are now done every time the "next" metadata updates: e.g. snapshot expiry and meta version are checked every time a targets metadata is updated -- it would be fine to do it only once (when initial "targets" is first updated) but this is simple to implement and the cost is likely minimal
metadata does get written to disk before we know if it fulfills the "complete" requirements for expiry and meta version: this is not what the spec says but seems correct to me as the data is "trusted" (signed by threshold of correct keys) and spec documents similar process for root. Even if the final metadata really is expired and the update fails, if the remote later starts serving non-expired metadata, the client will succeed in a later update (and will correctly use the earlier expired metadata for rollback checks!)
As Martin points out in comments, the "next" metadata may in some cases be downloaded before the final checks are done (so a snapshot file may be downloaded, but not parsed, before final timestamp expiry is checked): this does not have security implications but is not the order spec demands
This does not solve the issue with snapshot hashes/length in timestamp meta: it seems to require TrustedMetadataSet API change so I left it in separate issue: #1523

[x] The code follows the Code Style Guidelines
[x] Tests have been added for the bug fix or new feature

I'm pretty happy with the result. One disadvantage is that a call to update_snapshot() can lead to "Timestamp is expired" error: that is a bit surprising but it is documented and I think beats the alternative (requiring the caller to explicitly decide when root/timestamp/snapshot is "final" and should be checked for expiry etc)

Sorry, I accidentally edited your comment while trying to answer it: I tried to revert but github does not make it easy.

Likewise intent is that "local" snapshot can be trusted for rollback checks of new versions of the snapshot even if local snapshot does not match the meta version in the current timestamp.

That is true because timestamp could have been updated and as a consequence its timestamp.meta["snapshot"].version could be bumped right?

yes, in fact that's required: if you update snapshot the only way to make that snapshot part of the repo for the clients is to publish a new timestamp with updated meta.

By checking only the last timestamp/snapshot for expiration isn't there a risk of an attacker sending an intermediate expired version of timestamp/snapshot?

for both of these only two versions are potentially loaded:

local version may be loaded (but a local version is not required to exist)
the remote version may be loaded (spec includes always downloading both timestamp and snapshot but especially for snapshot that seems like a specification bug: local version may be the exact version we need, there's no need to load in that case)

One of these is the final version that ends up getting expiry checked -- and in any case even if a buggy client somehow loaded more expired snapshots during the process that would be fine: no security issues that I can see.

What I liked in the initial implementation was that it closely mapped to the client workflow defined in the specification and now some steps are swapped: for example step 5.5.6 will happen between steps 5.6.1 and 5.6.2.

This is a good point! the expiry (and meta version) checks currently jump over two spec items:

writing local metadata to disk (this I covered in my PR cover letter)
downloading "next" metadata (5.6.1 in your example)

I believe the first jump is correct and this seems to be what legacy updater does as well. The second item is an implementation detail and could be avoided by having snapshot_is_final() type API... but I dislike that because it requires more work from the caller.

I am even wondering won't it be better if we fix the problem in the specification first and then work on this pr?

I don't really want to wait for the spec:

ngclient is currently lacking a feature that legacy updater has (the rollback protection) and I consider that a bug
the spec changes are likely to be nontrivial: I think it requires defining how local metadata is loaded as well as this tricky interaction between expiry / meta version and rollback checks
we keep finding new things (or at least I do!) by implementing this: I believe the spec tasks are getting better defined because this PR is progressing

Spec does not explicitly say so but the intent is that "local" timestamp and snapshot metadata can be trusted for rollback checks of new versions of the same metadata even if the local metadata is expired.

The above sounds so logical and I am wondering how we haven't thought about it before.

This is a combo of two things:

spec is almost completely silent on when and how to load local metadata (it just expects there to be "trusted metadata" already at some point in the workflow without explaining where it came from)
it's  hard to figure out which of the rollback protections are actually in use in legacy updater: in any case they load all local metadata in the beginning, and only unload if keys are rotated -- this let's the implementation just forget about issues like "is our currently loaded snapshot actually the snapshot that our new timestamp considers correct", it just assumes this potential problem will be fixed sometime later in the process.

By checking only the last timestamp/snapshot for expiration isn't there a risk of an attacker sending an intermediate expired version of timestamp/snapshot?

for both of these only two versions are potentially loaded:

local version may be loaded (but a local version is not required to exist)
the remote version may be loaded (spec includes always downloading both timestamp and snapshot but especially for snapshot that seems like a specification bug: local version may be the exact version we need, there's no need to load in that case)

One of these is the final version that ends up getting expiry checked -- and in any case even if a buggy client somehow loaded more expired snapshots during the process that would be fine: no security issues that I can see.

I think I understand what you mean.
Even if a user is fed by an attacker with expired timestamp/snapshot data when calling update_timestamp/update_snapshot that won't be a security concern, because the next time when update_snapshot (for timestamp)  or update_targets (for snapshot) is called an expiry check will be done.

I am even wondering won't it be better if we fix the problem in the specification first and then work on this pr?

I don't really want to wait for the spec:

ngclient is currently lacking a feature that legacy updater has (the rollback protection) and I consider that a bug

Do the legacy updater checks this? From your next comment:

it's hard to figure out which of the rollback protections are actually in use in legacy updater (I'm unsure about the expiry cases for local metadata): in any case they load all local metadata in the beginning, and only unload if keys are rotated -- this let's the implementation just forget about issues like "is our currently loaded snapshot actually the snapshot that our new timestamp considers correct", it just assumes this potential problem will be fixed sometime later in the process.

seems like the old updater doesn't take care of this case.

the spec changes are likely to be nontrivial: I think it requires defining how local metadata is loaded as well as this tricky interaction between expiry / meta version and rollback checks
we keep finding new things (or at least I do!) by implementing this: I believe the spec tasks are getting better defined because this PR is progressing

I agree that this pr helps to define what should be changed in the spec.
I am just worried that this moves steps from the update process which is basically the heart of TUF and I don't want us to be in a situation when we are not following the spec update process for a while.
Let's at least make sure we have an issue and discussion going at the spec repo and we are moving in that direction, can we?

seems like the old updater doesn't take care of this case.

I did not say this. I said it's hard to figure if it does the checks in all cases (because the checks are done in places that are rather unobvious at least to me -- it's difficult to be sure that all possible scenarios are actually covered... but they may well be).
The legacy updater definitely has rollback protections in place that ngclient does not have, this is not in question.

I am just worried that this moves steps from the update process which is basically the heart of TUF and I don't want us to be in a situation when we are not following the spec update process for a while.
Let's at least make sure we have an issue and discussion going at the spec repo and we are moving in that direction, can we?

This should cover it maybe https://github.com/theupdateframework/specification/issues/179
I think fixing the spec might be complex enough (difficult to get right, and also difficult to negotiate WRT existing implementation decisions) that I don't like to just wait for the spec to be updated... we should do our best effort to implement what we think is the spec intent.

I am just worried that this moves steps from the update process which is basically the heart of TUF and I don't want us to be in a situation when we are not following the spec update process for a while.
Let's at least make sure we have an issue and discussion going at the spec repo and we are moving in that direction, can we?

This should cover it maybe theupdateframework/specification#179

Yes, it does.

I think fixing the spec might be complex enough (difficult to get right, and also difficult to negotiate WRT existing implementation decisions) that I don't like to just wait for the spec to be updated... we should do our best effort to implement what we think is the spec intent.

Now that at least we have documented what you have found in the spec repo and hopefully discussion can start I agree that it
makes sense to do what we believe it's right from a security standpoint and document it well (as I think you did).

metadata does get written to disk before we know if it fulfills the "complete" requirements for expiry and meta version: this is not what the spec says but seems correct to me as the data is "trusted" (signed by threshold of correct keys) and spec documents similar process for root. Even if the final metadata really is expired and the update fails, if the remote later starts serving non-expired metadata, the client will succeed in a later update (and will correctly use the earlier expired metadata for rollback checks!)

Agree, this seems OK. The well-defined process for root is because we explicitly download intermediate versions we expect to be expired, whereas for the other top-level files we do not. There have been some preliminary efforts to define how to load existing downloaded metadata for rollback protection here https://github.com/theupdateframework/taps/pull/128, but I think the size of the spec change is a blocker. I really want to find time to work on https://github.com/theupdateframework/specification/issues/121

Thank you, let's see how this works out!


one driver error in china  business account

i use rclone authorize "onedrive", and change https://login.microsoftonline.cn to https://login.partner.microsoftonline.cn
`
https://login.partner.microsoftonline.cn/common/oauth2/authorize?access_type=offline&client_id=52857fec-4bc2-483f-9f1b-5fe28e97532c&redirect_uri=http%3A%2F%2Flocalhost%3A53682%2F&resource=https%3A%2F%2Fapi.office.com%2Fdiscovery%2F&response_type=code&state=f2afd001507a071e79df76bae0691fc5
`
but show error
AADSTS70001: Application with identifier '52857fec-4bc2-483f-9f1b-5fe28e97532c' was not found in the directory 2f4cdd30-8012-4252-ae54-c5a5854df1be

Hi, according to https://docs.microsoft.com/en-us/previous-versions/office/office-365-api/api/o365-china-endpoints, the legacy API will not work well with O365 by 21Vianet. Could you please have a try with the new Graph API? You can find rclone with support for that here. Thanks!

The graph support has now been merged to the latest beta - can you try that?


Non pooled mode

Problem
Right now there is no way of telling Prisma to not spin up a connection pool even if the connection limit is set to 1.

Suggested solution
Allow a non pooled mode, either by a connection string flag or by not spinning a pool if connection limit is set to 1

Alternatives
None. There is no way to disable pooling right now.

Additional context
https://github.com/prisma/prisma/issues/2564#issuecomment-709511061

Using ?connection_limit=1 will suffice for now. Having connection pool with single connection is almost equivalent to no pool.


BigCache crashes with following error

What is the issue you are having?
panic: runtime error: slice bounds out of range [:203144864] with capacity 7808000
goroutine 89 [running]:
github.com/allegro/bigcache/v3/queue.(*BytesQueue).peek(0xc001552128, 0x12f99c, 0xc30c8f5ffe, 0x2d3, 0x14e402, 0x2, 0x0, 0x0)
/go-thirdparty/thirdparty/pkg/mod/github.com/allegro/bigcache/v3@v3.0.0/queue/bytes_queue.go:242 +0x185
github.com/allegro/bigcache/v3/queue.(*BytesQueue).Peek(...)
/go-thirdparty/thirdparty/pkg/mod/github.com/allegro/bigcache/v3@v3.0.0/queue/bytes_queue.go:186
github.com/allegro/bigcache/v3.(*cacheShard).set(0xc001552120, 0xc087b2a000, 0x67, 0x2c31d6b943f135f4, 0xc039fee780, 0x25c, 0x280, 0xc2f0b2c980, 0xc039fee780)
/go-thirdparty/thirdparty/pkg/mod/github.com/allegro/bigcache/v3@v3.0.0/shard.go:131 +0xdc
github.com/allegro/bigcache/v3.(*BigCache).Set(0xc000abe8f0, 0xc087b2a000, 0x67, 0xc039fee780, 0x25c, 0x280, 0x0, 0x8)
/go-thirdparty/thirdparty/pkg/mod/github.com/allegro/bigcache/v3@v3.0.0/bigcache.go:133 +0xae
What is BigCache doing that it shouldn't?
it should not be crashing
Minimal, Complete, and Verifiable Example
When asking a question about a problem caused by your code, you will get much better answers if you provide code we can use to reproduce the problem. That code should be...

...Minimal – Use as little code as possible that still produces the same problem
...Complete – Provide all parts needed to reproduce the problem
...Verifiable – Test the code you're about to provide to make sure it reproduces the problem

For more information on how to provide an MCVE, please see the Stack Overflow documentation.
Environment:

Version (git sha or release):
OS (e.g. from /etc/os-release or winver.exe):
go version:  go1.15.3 linux/amd64

Bigcache version?

"github.com/allegro/bigcache/v3"


FR: Add palette button only to specified fields

Just wondering if you have plans to allow the button to be applied to only specified bard fields. I'd rather not give the option on all of my bard fields.
Great work also. Thank you!

Thank you for the suggestion.
I'll definitely look into it!

It seems I have some free time now, so I can look into it.
Have you seen any plugins that can be applied only to specific bard fields?
If yes, then please link me to them so I can see how they did it and solve the issue faster 🚀

I'm afraid not. I'm really only getting into Statamic lately. Will post if I find something useful.

Hi. As soon as tiptap 2 gets added to statamic, I'm pulling this branch to master & launching a new version.
It should also fix this issue.
https://github.com/xndbogdan/statamic-bard-text-color/tree/feature/update-tiptap

I wanted to fix it earlier so I released v2.3.
Please update the dependency.
You should now be able to disable this field.

Thank you. I will try this again in the future.


add emoji_InputFormatter support our developer use emoji #

When the input box supports emoticons, when we have text and emoticons in the input box at the same time, there will be abnormal text length and cursor. For example, maxLength = 15, when there is an emoticon in the input box, the length of the text in the input box can reach 16, and then the cursor will automatically move one bit.
中文描述：
输入框支持表情时候，当我们输入框中同时存在文字与表情符号时候，会出现文字长度与光标异常。例如，maxLength= 15，当输入框中有表情符号时候，输入框的文案长度可以达到16，然后光标会自动迁移一位。

We will handle this issue by migrating to package:character, which will give us the correct length for emoji characters.


documentation does not include server 2022

looks like documentation does not reference support for server 2022 but i can find the files present for all versions listed in the documentation and server 2022
https://www.microsoft.com/en-us/download/details.aspx?id=57159

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 61bb35a5-e2f3-1ce8-1d6e-a926374de6c8
Version Independent ID: e4b3065a-5351-26ef-cdbb-ef2eaea3f301
Content: Deploy Azure File Sync
Content Source: articles/storage/file-sync/file-sync-deployment-guide.md
Service: storage
Sub-service: files
GitHub Login: @roygara
Microsoft Alias: rogarana

@MrDean0  Thanks for the question! We are investigating and will update you shortly.

@MrDean0 Firstly, apologies for the delay in responding here
Information is already been updated, please to this article for more information https://docs.microsoft.com/en-us/azure/storage/files/storage-how-to-use-files-windows

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


A few minor changes

If you want me to implement other functionalities in your code please contact me via e-mail<EMAIL_ADDRESS>or write comments here. I will gladly contribute to the Open Source project written in Rust.

Hi @pmalek-sumo,
So, by default, all logging is disabled except for the error level. Surely, we can set the default level of logging (in the case when there is no environmental variable present) in our code.
TO BE DELETED:
from receiver-mock/main.rs
env_logger::init();
TO BE INSERTED:
use env_logger::Env;
env_logger::Builder::from_env(Env::default().default_filter_or("warn")).init();
^
|
|
set desired "default" log level, to be used if env var is not present
I can implement it in the code. What do you think about it?
What's more, if you would like to have better human-readable log you might want to use pretty_env_logger

Hi Team,
Do you have any updates on that?
Regards,
Wojtek

Hi @pmalek-sumo,
So, by default, all logging is disabled except for the error level. Surely, we can set the default level of logging (in the case when there is no environmental variable present) in our code.
TO BE DELETED: from receiver-mock/main.rs env_logger::init();
TO BE INSERTED: use env_logger::Env;
env_logger::Builder::from_env(Env::default().default_filter_or("warn")).init();
set desired "default" log level, to be used if env var is not present (as "warn" in the example above)
I can implement it in the code. What do you think about it? What's more, if you would like to have a better human-readable log you might want to use pretty_env_logger

Setting this by default to info sounds good to me! We'd like to retain as much as possible from the already existing behavior.

If you need further help with your Rust codebase please contact me. As I see no significant interest (no review since a few months) in this PR I am closing it.

If you need further help with your Rust codebase please contact me. As I see no significant interest (no review since a few months) in this PR I am closing it.

Sorry for not getting back to you sooner on this. 😓
We'd very much welcome PR and some of the ideas proposed in this one seem to be nice additions to receiver-mock.
If you'd still be interested in contributing I'd suggest to submit smaller PRs contributing 1 particular improvement that we can then review and merge. How does that sound?


API endpoints should set CORS headers and respond to OPTIONS requests

Apologies if this is the wrong place to report this sort of feature request. Please let me know if I should file this elsewhere.
It would be very useful if the API endpoints supported CORS, as this would allow data to be easily consumed by client-side web applications.
As things currently stand attempting to use an XMLHttpRequest requires adding the api-key header which (at least in Chome) triggers an a pre-flight OPTIONS request. This returns a 404 status, and does not contain an Access-Control-Allow-Origin header, which blocks further requests from being made.
Here's the chrome console when this occurs:

Here's an example OPTIONS request which fails:
$ curl "https://api.msrc.microsoft.com/Updates?api-version=2016-08-01" -H 'api-key: xxxx' -X OPTIONS
{ "statusCode": 404, "message": "Resource not found" }

It would be great if you would consider adding support for this.

Feature requests for the API its self can be posted in the technet forums, found here: https://social.technet.microsoft.com/Forums/security/en-us/home?forum=securityupdateguide


Lancer 2.0 Support

The 2.0 release of the system changes that paths for data on actors. Configurations will need to be updated to support these changes.
Notably:

Machine mind is gone and there is no mm object anymore
Within foundry, Document#data#data has been moved to Document#system. The rest of Document#data has been moved into the top level of Documents
The forked version of bar brawl will need to be updated to support v11, or configs will need to be updated to use unpatched bar brawl.

CC: https://github.com/Eranziel/foundryvtt-lancer/issues/604

I've re-added the shim for v11 and updated the README to reflect this.
Should we separate v10 and v11 into separate sections?

Maybe make a tag for v10 and link the tag from the readme for people still on v10?

For now i've split them into different directories for v10/v11 and have them in different headers, which should be good enough given the low # of configurations.


Update zh/docs/concepts/services-networking/dns-pod-service.md#pods

Synchronize pods section for zh/docs/concepts/services-networking/dns-pod-service.md with en version.
Also fixes #14800

/assign @tengqm

/lgtm

/lgtm

/approve


Update guess, display description

added guess feature
added button that displays the description table

status: no guess / edit guess

status: guess submitted

when description list button is clicked:


How to get user

How can i get the authicated user dict with the token pair.

Check this out @thedatamineio : https://django-rest-framework-simplejwt.readthedocs.io/en/latest/rest_framework_simplejwt.html#rest_framework_simplejwt.authentication.JWTAuthentication.get_user
Although it shouldn't be necessary to do that if you're using DRF and follow the normal set up in which you just do request.user.
@davesque It might still be useful to have half the documentation in the README since most people don't really like going to the actual docs -- honestly it includes me (laziness).


student

We have written the needed data into your clipboard because it was too large to send. Please paste.
keyboard jumping to end

/needsMoreInfo


fix(ngOptions): correctly watch displayed value for changes

ngOptions does not update the displayed value properly if the property being used as the label changes when not using the "select as" or "track by" syntax, i.e <select ng-options="value.label for value in array"></select> will not update if array[0].label is changed but <select ng-options="value.label as value.label for value in array></select> will correctly update.
The bug is demonstrated here: https://jsfiddle.net/76qrsctv/17/
The proposed change fixes this issue.

I signed it!

Thanks for highlighting this issue. We needed to provide a unit test too.


Bug when using an HTTPS Proxy and disabling proxy certificate verification

I tried to configure okhttp (v 4.10.0) to make a GET request to an url through an https proxy that use a self-signed certificate.
I saw these issues: https://github.com/square/okhttp/issues/6561 and https://github.com/square/okhttp/issues/3787 that are quite similar exept that they do not address the case where you want to disable the certificate verification during the SSL handshake with the https proxy (because in my case, the proxy is using a self-signed certificate, that may change quite frequently. So requiering to have it downloaded in a client keystore is not a practical option).
Here is the code that I currently have (which is basically the same as the one from @lpuglia in https://github.com/square/okhttp/issues/6561 with just a TrustManager that will accept all server's certificates added)  :
String desturl = "https://api64.ipify.org/?format=json"; //"https://myip.com" //"http://neverssl.com" //"http://silverfinebeautifulsecret.neverssl.com/online/"

OkHttpClient.Builder clientb = new OkHttpClient.Builder().proxy(new java.net.Proxy(java.net.Proxy.Type.HTTP, new InetSocketAddress("shoutouttomyex.icu", 443))) ;

// Create a trust manager that does not validate certificate chains
final TrustManager[] trustAllCerts = new TrustManager[] { new X509TrustManager() {
     @Override public void checkClientTrusted(java.security.cert.X509Certificate[] chain, String authType) throws CertificateException { System.out.println("checkClientTrusted"); return;}
     @Override public void checkServerTrusted(java.security.cert.X509Certificate[] chain, String authType) throws CertificateException { System.out.println("checkServerTrusted"); return;}
     @Override public java.security.cert.X509Certificate[] getAcceptedIssuers() { System.out.println("getAcceptedIssuers");  return new java.security.cert.X509Certificate[]{}; }
} };

final SSLContext sslContext = SSLContext.getInstance("SSL");
sslContext.init(null, trustAllCerts, new java.security.SecureRandom());
final SSLSocketFactory sslSocketFactory = sslContext.getSocketFactory();

clientb.socketFactory(new DelegatingSocketFactory(sslSocketFactory));
clientb.hostnameVerifier(new HostnameVerifier() {
     @Override public boolean verify(String hostname, SSLSession session) { System.out.println("Verify "+hostname); return true; }
});

okhttp3.Request.Builder rbuilder = new Request.Builder().url(desturl).get();

Response response = clientb.build().newCall(rbuilder.build()).execute();
System.out.println("Answer: "+response.body().string());

(Note: I don't need any Authenticator as my https proxy is an opened proxy to which you can connect without any username and password)
the problem is that when requesting an https url with this code, I systematically get an answer with a 404 error. Here is the output that I have:
checkServerTrusted
getAcceptedIssuers
java.io.IOException: Unexpected response code for CONNECT: 404
	at okhttp3@4.10.0/okhttp3.internal.connection.RealConnection.createTunnel(RealConnection.kt:483)
	at okhttp3@4.10.0/okhttp3.internal.connection.RealConnection.connectTunnel(RealConnection.kt:262)
	at okhttp3@4.10.0/okhttp3.internal.connection.RealConnection.connect(RealConnection.kt:201)
	at okhttp3@4.10.0/okhttp3.internal.connection.ExchangeFinder.findConnection(ExchangeFinder.kt:226)
	at okhttp3@4.10.0/okhttp3.internal.connection.ExchangeFinder.findHealthyConnection(ExchangeFinder.kt:106)
	at okhttp3@4.10.0/okhttp3.internal.connection.ExchangeFinder.find(ExchangeFinder.kt:74)
	at okhttp3@4.10.0/okhttp3.internal.connection.RealCall.initExchange$okhttp(RealCall.kt:255)
	at okhttp3@4.10.0/okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.kt:32)
	at okhttp3@4.10.0/okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
	at okhttp3@4.10.0/okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.kt:95)
	at okhttp3@4.10.0/okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
	at okhttp3@4.10.0/okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.kt:83)
	at okhttp3@4.10.0/okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
	at okhttp3@4.10.0/okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.kt:76)
	at okhttp3@4.10.0/okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
	at okhttp3@4.10.0/okhttp3.internal.connection.RealCall.getResponseWithInterceptorChain$okhttp(RealCall.kt:201)
	at okhttp3@4.10.0/okhttp3.internal.connection.RealCall.execute(RealCall.kt:154)

and if I request an http url (like http://silverfinebeautifulsecret.neverssl.com/online/) I don't have any error but I get an empty answer (which is also a bug as I should receive the page body). Here is the output with an http destination url:
checkServerTrusted
getAcceptedIssuers
Answer:

The same chain of request (requesting an url through my https proxy with proxy's certificate verification disabled) is working just fine with curl.
Here is the output that I get with this curl command : curl -x https://shoutouttomyex.icu:443 https://api64.ipify.org/?format=json --proxy-insecure -v :
*   Trying <IP_ADDRESS>:443...
* Connected to shoutouttomyex.icu (<IP_ADDRESS>) port 443 (#0)
* ALPN: offers http/1.1
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
* TLSv1.3 (IN), TLS handshake, Certificate (11):
* TLSv1.3 (IN), TLS handshake, CERT verify (15):
* TLSv1.3 (IN), TLS handshake, Finished (20):
* TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
* TLSv1.3 (OUT), TLS handshake, Finished (20):
* SSL connection using TLSv1.3 / TLS_AES_256_GCM_SHA384
* ALPN: server accepted http/1.1
* Proxy certificate:
*  subject: CN=shoutouttomyex.icu
*  start date: Mar 21 03:28:06 2023 GMT
*  expire date: Jun 19 03:28:05 2023 GMT
*  issuer: OU=generated by Avast Antivirus for SSL/TLS scanning; O=Avast Web/Mail Shield; CN=Avast Web/Mail Shield Root
*  SSL certificate verify result: unable to get local issuer certificate (20), continuing anyway.
* allocate connect buffer
* Establish HTTP proxy tunnel to api64.ipify.org:443
> CONNECT api64.ipify.org:443 HTTP/1.1
> Host: api64.ipify.org:443
> User-Agent: curl/8.0.1
> Proxy-Connection: Keep-Alive
>
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
< HTTP/1.0 200 OK
< X-RS: rs71
<
* CONNECT phase completed
* CONNECT tunnel established, response 200
* ALPN: offers h2,http/1.1
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
*  CAfile: C:\Development\utils\curl-8.0.1_4-win64-mingw\bin\curl-ca-bundle.crt
*  CApath: none
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
* TLSv1.3 (IN), TLS handshake, Certificate (11):
* TLSv1.3 (IN), TLS handshake, CERT verify (15):
* TLSv1.3 (IN), TLS handshake, Finished (20):
* TLSv1.3 (OUT), TLS handshake, Finished (20):
* SSL connection using TLSv1.3 / TLS_AES_128_GCM_SHA256
* ALPN: server accepted h2
* Server certificate:
*  subject: CN=*.ipify.org
*  start date: Feb  7 00:00:00 2023 GMT
*  expire date: Feb 18 23:59:59 2024 GMT
*  subjectAltName: host "api64.ipify.org" matched cert's "*.ipify.org"
*  issuer: C=GB; ST=Greater Manchester; L=Salford; O=Sectigo Limited; CN=Sectigo RSA Domain Validation Secure Server CA
*  SSL certificate verify ok.
* using HTTP/2
* h2h3 [:method: GET]
* h2h3 [:path: /?format=json]
* h2h3 [:scheme: https]
* h2h3 [:authority: api64.ipify.org]
* h2h3 [user-agent: curl/8.0.1]
* h2h3 [accept: */*]
* Using Stream ID: 1 (easy handle 0x2bbe2549f10)
> GET /?format=json HTTP/2
> Host: api64.ipify.org
> user-agent: curl/8.0.1
> accept: */*
>
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
< HTTP/2 200
< content-type: application/json
< date: Mon, 27 Mar 2023 20:52:58 GMT
< vary: Origin
< content-length: 21
<
{"ip":"<IP_ADDRESS>"}* Connection #0 to host shoutouttomyex.icu left intact

@ramsestom apologies for the delay, interesting problem.
This seems to be an SNI related issue.  Change the following
  clientb.socketFactory(object : DelegatingSocketFactory(sslSocketFactory) {
    override fun configureSocket(socket: Socket): Socket {
      val sslSocket = socket as SSLSocket

      val parameters = sslSocket.sslParameters
      val sni = parameters.serverNames
      parameters.serverNames = mutableListOf<SNIServerName>(SNIHostName("shoutouttomyex.icu"))
      sslSocket.sslParameters = parameters

      return socket
    }
  })


Inconsistent FNR behavior with and without hyphen argument

Running
#!/usr/bin/env bash
gawk 'END { print "FNR with gawk:", FNR }' <<<"$(printf "1\n2\n3\n")"
gawk 'END { print "FNR with gawk -:", FNR }' - <<<"$(printf "1\n2\n3\n")"
goawk 'END { print "FNR with goawk:", FNR }' <<<"$(printf "1\n2\n3\n")"
goawk 'END { print "FNR with goawk -:", FNR }' - <<<"$(printf "1\n2\n3\n")"

results in
FNR with gawk: 3
FNR with gawk -: 3
FNR with goawk: 3
FNR with goawk -: 0

In other words, when the input argument is -, goawk inconsistently (and probably incorrectly) sets FNR to 0 in the END pattern.

Fixed on master. Thanks for the report!

@paulapatience Good to hear, thanks! Let me know when you've released prmindent, and I'll add it to my list of programs I can test GoAWK with.

Voilà: https://git.sr.ht/~paulapatience/prmindent.
A few caveats, though. There are no tests yet; I intend to add an organized test suite, but for now I've been testing the script by formatting a configuration file I created specifically for this purpose each time I make changes. Also, the script's hashbang line uses the -Wexec option of mawk and gawk. With goawk you need to run the script as goawk -f prmindent -- [ARG ...]. (This is all described in the documentation.) I'm actually going to presently open an issue requesting the -Wexec option be added to goawk; it is practical when writing Awk scripts that should look like regular command-line utilities.


Fetch ALL pictures in an album

Default GET only returns first 20 pictures.
This adds a loop to get 20 at a time until all are downloaded.

Thanks for reporting this bug, I'm going to fix this a slightly different way, to unify how pagination is done across all api calls.

Thanks for the contribution, I've rebased and merged this patch onto master. The wider refactor was taking too long.


ignore global flagfile

A lot of dreamview interactions cause changes in modules/common/data/global_flagfile.txt. It's hard to keep track of manual software changes and GUI default changes. This PR is meant to reduce those.
This PR was tested with
docker/scripts/dev_start.sh
docker/scripts/dev_into.sh
./apollo.sh build_opt
rm -r data/log
bootstrap.sh
ls data/log

Everything builds and the log files are in the right location.
Note that running docker/scripts/dev_start.sh is necessary when running with this change.

It's confusing to mix parameters with UI state. gflags already has default values. There is not need to duplicate defaults in this file. Specific parameters can be put in other files.

It makes a lot of sense. Thank you for the great suggestion!
As of now we still rely on it for some cross-module configuration and testing. Please leave it for a while and we'll try to resolve. Thanks!

I thought modules/common/data/global_flagfile.txt could be replaced, by the default values in gflag's DEFINE macro.
If you want to keep it for cross-module configuration, you can do modules/module_name/conf/module_name.conf -> modules/common/data/global_flagfile.txt -> modules/common/data/hmi.txt. Each arrow represents setting the --flagfile gflag similar to how each module conf file does it currently. Then, modules/common/data/global_flagfile.txt could be tracked by git and modules/common/data/hmi.txt could be ignored.

After some investigation I think that we have to keep it for a while due to some daily workflow, cloud jobs as well as release mechanism. It will be on my schedule to do deep clean on this.
Thank you for the heads up :)


Change StreamFilterCallbacks::tracingConfig() to return a pointer

Rather than a reference.
So that callers would know whether tracing is configured or not and then
they can check its value before trying to dereference an invalid reference, thus
avoiding a crash.
Fixes #13164.
Signed-off-by: Jonh Wendell<EMAIL_ADDRESS>
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

Could you also check that internal consumers of calls like https://github.com/envoyproxy/envoy/pull/13734/files#diff-7cfd594a6eff3119b0382311e215145da49b9c2e5e776e83453c44dfcf2b6be3R1548 (like this one: https://github.com/envoyproxy/envoy/blob/master/source/common/tracing/http_tracer_impl.cc#L155) have nullptr checks? Probably worth adding a test for these too.

I think we need tests that verify that ConnectionManagerImpl::ActiveStream can appropriately deal with nullptr config. Could you also double-check that the callers of the methods in ConnectionManagerImpl::ActiveStream that rely on non-null tracing config perform a nullptr check?


JS functionality

I need to bug test my script to ensure functionality prior to deployment

Over the course of a couple updates, I managed to get the application's JS working without bugs.


Doesn't work on (some installs of) OSX

Some OSX machines have case-insensitive filesystems (as, apparently, mine does). Since both e.g. third_party/gflags/{BUILD,build} exist, git gets terribly confused.
Suggestion - rename the folder to something else :)

I just ran into this as well.


AWS Profile in kubeconfig template

I'm submitting a

[x] feature request

For my current delivery, the customer has credentials with multiple profiles and not only needs to specify different profiles per cluster, but has no default profile.
It would be great if the kubeconfig.tpl could be modified:
...
users:
- name: aws
  user:
    exec:
      apiVersion: client.authentication.k8s.io/v1alpha1
      command: heptio-authenticator-aws
      args:
        - "token"
        - "-i"
        - "${cluster_name}"
      env:
        - name: AWS_PROFILE
          value: ${aws_profile}

where the default Terraform value to populate the template would be default to ensure no regression.
I wanted to start a discussion before a PR to ensure best path forward on this. Thanks!

Hi @mschuchard
This sounds good but I think this is a duplicate request. We just started discussing a similar (if not the same) issue here a day ago. Let me know if your use case can be accommodated by implementing what's proposed there.

I do not see any mention of implementing AWS profiles into the kubeconfig in that issue. Version 1.1.0 is currently failing for the customer because EKS cannot be reached due to the kubeconfig not using the correct AWs profile since that is not customizable in this module.
Having separate kubeconfigs is fine, but in reality people are going to be merging their kubeconfigs and then differentiating between them via context.

I submitted PR #49 which provides the ability to specify a generic map of environment variables to be appended to the kubeconfig.

This is addressed having just merged #49 . Closing this up.


docs: stone prover trace docs - layout plain

Add docs for the trace configuration used in the Stone prover
Add representation of the trace built in the stone prover in csv format, for a simple fibonacci program.

Codecov Report

Merging #658 (cb025af) into main (cffa505) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #658   +/-   ##
=======================================
  Coverage   97.08%   97.08%
=======================================
  Files         118      118
  Lines       28346    28346
=======================================
  Hits        27519    27519
  Misses        827      827

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Maybe we should add this to the main docs


Default to unit sphere behaviour in constructor

The constructor of SphericalVoronoi allows to pass center and radius of the sphere as optional arguments. While not passing a center defaults to the origin, not passing a radius defaults to a radius estimation. Since this is inconsistent and might cause quite some computation in the constructor, I would suggest to remove the estimation and make the constructor default to the unit sphere completely. We could still add helper functions to estimate center and radius if we want to.

So, the user would have to convert to unit sphere coordinates beforehand? If we go that route, I think it would at least be sensible to ensure that the area calculations can be adjusted to return values for a specific radius. I think that is already the case anyway, as r^2 is in the spherical polygon surface area calculation.
It is maybe a little awkward that an end user would have to project their coordinates back to the appropriate radius after using the code though, but placing the burden of this projection / conversion on our code is probably asking for trouble.
Should there also be some kind of check to ensure that the input data in on the unit sphere?

No, the user would not have to convert beforehand. If the user does not specify a radius and center, the constructor will assume the unit sphere. If the user specifies radius and center, everything will work fine on the specified sphere. The only situation where one would have to do something manually would be if one wants to calculate the Voronoi diagram of points on a sphere with unknown center and radius. This is probably not realistic?

Ok, and if the user fails to provide radius and / or center arguments will the code be able to detect that there is a problem if the data is not on the unit sphere, or will we have to settle for a cryptic exception somewhere in the control flow?
Since the generators may not be distributed evenly on the sphere, it would be non-trivial to determine the actual center of the sphere (since it would not be the centroid of the points if they are biased to one hemisphere, etc.). One could check the diameter of the input sphere by determining the maximum Euclidean chord length from a distance matrix of all generators, but that would also be pretty expensive just for checking input.


Giving constant tensor as layer input still requires the Model's callable to fill those inputs as if they were placeholders.

Please make sure that the boxes below are checked before you submit your issue.
If your issue is an implementation question, please ask your question on StackOverflow or on the Keras Slack channel instead of opening a GitHub issue.
Thank you!

[o ] Check that you are up-to-date with the master branch of Keras. You can update with:
pip install git+git://github.com/keras-team/keras.git --upgrade --no-deps

[o ] Check that your version of TensorFlow is up-to-date. The installation instructions can be found here.

[ o] Provide a link to a GitHub Gist of a Python script that can reproduce your issue (or just copy the script here if it is short).

I want to have a "state" variable which will store states for some recurrent connection. My plan is to have a Variable keep that state. By digging around, I found that I can define an Input() layer with the "tensor" argument specified. My problem is that when I build my Model and call the model on the inputs via its callable (to connect it to other layers or models), it is still requiring I add an input for that Variable that is already defined. I've read that Keras puts Placeholders for Input() layers, but does not if the "tensor" argument for the Input layers is specified which makes a lot of sense. So why is it still expecting I fill that Placeholder when I use its callable?
Can this be a problem with the constructor of the Model() class not setting the call()/call() function's required arguments correctly (the number of parameters should equal the number of Input() layers MINUS the Input(tensor=x) layers who already have a tensor defined)?
The following is not the actual original code, but it shows the problem and it can run on its own.
import numpy as np
import keras.backend as K

from keras.layers import Input, Activation, Add, GaussianNoise
from keras.models import Sequential, Model

random_tensor = K.random_normal(shape=(8, 3), seed=42)
x = Input(shape=(784,))
eps = Input(tensor=K.random_normal(shape=(K.shape(x)[0], 3), seed=42))
m = Model([x, eps], eps)

m.predict(np.ones((8, 784))) #Succeeds. The predict, evaluate and fit functions are fine and recognizes that one input (eps) is already defined at construction time so it is ok with running with only one argument

m(x) #fails with error: " Layer model_6 expects 2 inputs, but it received 1 input tensors. Input received: [<tf.Tensor 'input_2:0' shape=(?, 784) dtype=float32>]" Which is strange because eps is an Input() layer that already has a tensor value and shouldn't need an explicit input.

m([x, eps]) #succeeds, returns a Keras layer ready to connect to other layers

#source http://louistiao.me/notes/keras-constant-input-layers-with-fixed-source-of-stochasticity/

In addition to that, if you save the model and reload it with keras.models.load_model, when you try model.predict(np.ones((8, 784))), the prediction doesn't work anymore.

How can I warp the Keras layer using TimeDistributed?

Hell o
I suffer from a similar issue I have this model:
inputs = Input(shape=( img_width, img_height))
inpFloat = Input(shape =(1,1))
in0= Lambda(lambda x: inpFloat*x)(inputs)
model =Model([inputs, inpFloat],in0)

with the values
img_height = 1025
img_width = 150
When I do the following :
xx = np.random.rand(1, 150, 1025)
y1=np.array([2.0])
y1 =np.expand_dims(y1,axis=1)
y1 = np.expand_dims(y1, axis=2)
print(model.predict([xx,y1]))

It works ok .  But when I add
model.Save()   . I get the error:
File "C:\Natan\anaconda3\lib\site-packages\keras\engine\network.py", line 1090, in save
save_model(self, filepath, overwrite, include_optimizer)
File "C:\Natan\anaconda3\lib\site-packages\keras\engine\saving.py", line 382, in save_model
_serialize_model(model, f, include_optimizer)
File "C:\Natan\anaconda3\lib\site-packages\keras\engine\saving.py", line 83, in _serialize_model
model_config['config'] = model.get_config()
File "C:\Natan\anaconda3\lib\site-packages\keras\engine\network.py", line 931, in get_config
return copy.deepcopy(config)
File "C:\Natan\anaconda3\lib\copy.py", line 150, in deepcopy
y = copier(x, memo)
File "C:\Natan\anaconda3\lib\copy.py", line 240, in _deepcopy_dict
y[deepcopy(key, memo)] = deepcopy(value, memo)
File "C:\Natan\anaconda3\lib\copy.py", line 150, in deepcopy
y = copier(x, memo)
File "C:\Natan\anaconda3\lib\copy.py", line 215, in _deepcopy_list
append(deepcopy(a, memo))
File "C:\Natan\anaconda3\lib\copy.py", line 150, in deepcopy
y = copier(x, memo)
File "C:\Natan\anaconda3\lib\copy.py", line 240, in _deepcopy_dict
y[deepcopy(key, memo)] = deepcopy(value, memo)
File "C:\Natan\anaconda3\lib\copy.py", line 150, in deepcopy
y = copier(x, memo)
File "C:\Natan\anaconda3\lib\copy.py", line 240, in _deepcopy_dict
y[deepcopy(key, memo)] = deepcopy(value, memo)
File "C:\Natan\anaconda3\lib\copy.py", line 150, in deepcopy
y = copier(x, memo)
File "C:\Natan\anaconda3\lib\copy.py", line 220, in _deepcopy_tuple
y = [deepcopy(a, memo) for a in x]
File "C:\Natan\anaconda3\lib\copy.py", line 220, in
y = [deepcopy(a, memo) for a in x]
File "C:\Natan\anaconda3\lib\copy.py", line 150, in deepcopy
y = copier(x, memo)
File "C:\Natan\anaconda3\lib\copy.py", line 220, in _deepcopy_tuple
y = [deepcopy(a, memo) for a in x]
File "C:\Natan\anaconda3\lib\copy.py", line 220, in
y = [deepcopy(a, memo) for a in x]
File "C:\Natan\anaconda3\lib\copy.py", line 180, in deepcopy
y = _reconstruct(x, memo, *rv)
File "C:\Natan\anaconda3\lib\copy.py", line 280, in _reconstruct
state = deepcopy(state, memo)
File "C:\Natan\anaconda3\lib\copy.py", line 150, in deepcopy
y = copier(x, memo)
File "C:\Natan\anaconda3\lib\copy.py", line 240, in _deepcopy_dict
y[deepcopy(key, memo)] = deepcopy(value, memo)
File "C:\Natan\anaconda3\lib\copy.py", line 180, in deepcopy
y = _reconstruct(x, memo, *rv)
File "C:\Natan\anaconda3\lib\copy.py", line 280, in _reconstruct
state = deepcopy(state, memo)
File "C:\Natan\anaconda3\lib\copy.py", line 150, in deepcopy
y = copier(x, memo)
File "C:\Natan\anaconda3\lib\copy.py", line 240, in _deepcopy_dict
y[deepcopy(key, memo)] = deepcopy(value, memo)
File "C:\Natan\anaconda3\lib\copy.py", line 180, in deepcopy
y = _reconstruct(x, memo, *rv)
File "C:\Natan\anaconda3\lib\copy.py", line 280, in _reconstruct
state = deepcopy(state, memo)
File "C:\Natan\anaconda3\lib\copy.py", line 150, in deepcopy
y = copier(x, memo)
File "C:\Natan\anaconda3\lib\copy.py", line 240, in _deepcopy_dict
y[deepcopy(key, memo)] = deepcopy(value, memo)
File "C:\Natan\anaconda3\lib\copy.py", line 169, in deepcopy
rv = reductor(4)
TypeError: can't pickle _thread.RLock objects
I am using Python3.7 anaconda  . Thanks


Add Test Connection button to the settings page.

Feels more natural then the Load Devices button on the devices tab to test the connection.

Added in version <IP_ADDRESS>


No CSS on a clean install; CSS seems to be served with HTML headers

Issue Type

Bug Report / Support Request

Your Environment
Vagrant 2.1.5
VirtualBox 5.2.18r124319
ansible 2.6.5
  config file = None
  configured module search path = [u'/Users/webadmin/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/Cellar/ansible/2.6.5/libexec/lib/python2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.15 (default, Oct  2 2018, 11:42:04) [GCC 4.2.1 Compatible Apple LLVM 10.0.0 (clang-1<IP_ADDRESS>)]

Your OS

macOS (10.4)

Summary

The dashboard loaded fine, so I assumed my vagrant up was successful! But the Drupal installation itself has no CSS.
The error in Chrome's web dev tools:
"Refused to apply style from 'http://drupalvm.test/?0' because its MIME type ('text/html') is not a supported stylesheet MIME type, and strict MIME checking is enabled."
Googling a little suggests Apache's serving CSS with HTML headers; is this something that needs to be fixed in the Ansible provisioning script? If I fix this within the VM, am I right in assuming that any new VMs built with this script would have the same error?
Thanks,
Dave.

I've never seen this happen... does it also happen in FireFox, Safari, Edge, etc.? If it's only Chrome, maybe it's a chrome rendering bug?
Also, http://drupalvm.test/?0 seems like a very weird URL for a stylesheet. Is there something in your Drupal theme or a module that might be causing invalid URLs to be used for stylesheets? In Drupal stylesheets are generated and output with .css extensions which would then be correctly interpreted/served by Apache or Nginx. If you load any URL which hits Drupal, like http://drupalvm.test/?0, then it would serve an HTML page, maybe a 404 (try loading http://drupalvm.test/?0 to see what it outputs).

This is a clean install from Drupal-VM; no modules / themes / customizations have been added yet. I spun up the VM for the first time, the dashboard looked like it loaded correctly, but the site itself loads no CSS.
Checked in Firefox, and it loads no CSS.
http://drupalvm.test/?0 loads the same homepage with no CSS.
I'm assuming the ?0 is from the CSS / JS aggregation system?

Oh, hmm. In config/performance:
"External resources can be optimized automatically, which can reduce both the size and number of requests made to your website. Set up the public files directory to make these optimizations available."
Both of these are checked, and I can't uncheck them:
"Aggregate CSS files
Aggregate JavaScript files"
Hmm. Is something about the VM setup not setting up the public files directory correctly? Does Drupal think it's in the wrong place, or does it have the wrong perms, etc?

I wonder if it's a filesystem issue or something like that.
Do you have anything at all in a config.yml or local.config.yml? And is this just a plain Drupal VM instance? I just downloaded the project, 4.9.1 release and master, and ran vagrant up in the Drupal VM directory, and in both cases the CSS is loading fine in Drupal.
If you go to Drupal's admin status report page, does it have any warnings, e.g. it can't write to the public files directory or something like that?

The same thing happens for me on Debian sid with Drupal VM master, Vagrant 2.2.0, Ansible 2.7.0, and VirtualBox 5.2.20. If I use Drupal VM 4.9.1, the Drupal site comes up just fine with all CSS present and available.
One interesting thing to note is that with 4.9.1, the stylesheet links actually have a full path (sans hostname) rather than just referring to http://drupalvm.test/?0.

@bccox - So are you saying that Drupal VM master is failing, but if you use 4.9.1, it works?

This happened to me too. I noticed the vagrant user and group owned the files directory so the www-data user couldn't write files. I fixed it with:
sudo chown vagrant:www-data files -R
This is with a fresh install of ubuntu1804.

I'm having these same issues except the solution @pmagunia and @grantpestka propose are not working... Drupal VM master, Vagrant 2.2.14, and VirtualBox 6.1.16.


Issues when interpolating images or videos shot from different view angles

Hi all,
I have the following question.
I'm trying to interpolate between two images or a video where each frame is taken from a different view angle (for example, spheric videos). Is it possible to do this with the help of RIFE?
If I run inference_img.py in the default mode, the interpolated img1.png is received with high visual artifacts (attached).
In short, what should I do to interpolate such images? For example, I can change my source to add more view angles, or should I look for different algorithms, or maybe I need to retrain RIFE for spheric videos or images or change a parameter in inference_img.py or inference_video.py?
I appreciate any help you can provide.

Hi, view interpolation is not a situation we currently cover, but I have done some work on it.
I have two suggestions:

Use a SLAM-related dataset to finetune the model, such as TartanAir.
Add some image translation augmentation during training to force the model to understand camera motion.

Hi @hzwer, Thanks a lot for the tip!
Do you think interpolation with RIFE can give us a better result than if we first run colmap and then run one of the view synthesis methods (for example, using nerf_pl or instant-ngp)? I already tried to make a 3D model from our images using instant-ngp, it works very fast, but we are not satisfied with the visual result.
As for your work in the field of view interpolation, is it possible to see at least partial results of your research somewhere?

What I envision is to try a nerf-like method to get coarse results first, and then use a RIFE-like method to transfer textures, since RIFE doesn't directly model view changes.
I think IBRNet (https://ibrnet.github.io/) is a good solution right now. Our method is not yet public, sorry.