How to connect using PEM file

Package works fine. What about sftp connection using .pem/ppk from windows?

It works well on my Windows laptop. I'll paste my config file here for your reference.
{
    "protocol": "sftp",
    "host": "ec2-xxxxx.compute.amazonaws.com",
    "port": 22,
    "user": "ec2-user",
    "pass": "",
    "promptForPass": false,
    "remote": "/home/ec2-user/git",
    "agent": "pageant",
    "privatekey": "C:/Program Files Green/YourKey.pem",  //Using '/' is fine
    "passphrase": "",
    "hosthash": "sha1",
    "ignorehost": true,
    "connTimeout": 10000,
    "keepalive": 58,
    "watch":[]  //Caution: the sample config file they provide has value in this field. Make sure to clear it or you will get an weird error.
}

This is saved in D:\git\.ftpconfig in my computer, and I set ~/git as the root directory on remote machine. Every time I just open Atom in D:\git and connect my server. Some temp files will be downloaded in the local machine. The folders are named git on both sides so that it's more convenient.

Gonna close this, if you still having any issues leave a comment and I'll re open it.


[FEATURE] Test deleting the cluster

Is your feature request related to a problem? Please describe.
Test and make sure that a cluster can be completely deleted by deleting the CloudFormation stack.
Document the process and any manual steps, if any.
A CustomResource has already been configured that runs an SSM command on all instances in the VPC that runs the DeconfigureClusterCommand before the file systems are deleted.
This is done so that the instances aren't hung when the mounted file system is deleted.
Need to test this and make sure that it's working.
The test would be to not run the DeconfigureClusterCommand  command on a submitter instance and delete the stack and verify that the command was run automatically.

I deleted a cluster and the deletion failed because the FSxZ volume couldn't be deleted automatically.


Fixed #6340 -- Reorder models to support dumpdata

Fixes #6340

@heppstux can you add a changelog entry, you'd have to add first add 3.5.3 (unreleased) and then put it under that.

@czpython, changelog is updated.

Thanks!

I just retested this patch, loading a fixture generated using
./manage.py dumpdata --natural-foreign cms > fixture.json
./manage.py loaddata fixture.json

However, it still doesn't work. Reason is, that cms.signals.page.pre_save_page() is invoked for each cms.Page instance while loading the fixture. At that time, the table for cms.TreeNode is not filled yet, hence accessing page_instance.node raises a ObjectDoesNotExist exception.


Question: Steps required to support Float32

I see in various places issues using Float32 (i.e. https://discourse.julialang.org/t/issue-with-float32-precision-in-turing-model-sampling/108160) with the problem being that areas of the code hard code Float64.
I've looked but can't see an issue for this. Is there one? If not what work would need to be done to make this possible and could it be itemised to make it easier to chunk out into small parts?
In principle this seems like something that could be tackled by newer contributors and so making that easy seems like it would worth the effort? That being said I have no idea and it could be far more complicated.

Update: I just did a quick scan across the ecosystem in the TuringLang org and I see a couple of issues/PRs attacking this (https://github.com/TuringLang/Bijectors.jl/issues/266) so maybe I am just looking in the wrong place?

I don't think there is a unifying issue unfortunately, but we can make this the one:)
It is definitively possible to achieve. For example, it's already possible to evaluate a model using, say, Float32 if one is willing to do some work.
But it requires quite some effort to make consistent across code-bases to the point where it's easy to just run the full inference procedure using Float32.
There are a few aspects to this:

[ ] The user needs to write evertyhing in a way that's compatible with whatever type we want. Specifically, that means something like @model demo(::Type{T}=Float64) where T and make sure that all the numbers inside of the model are of type T, e.g. call zeros(T, n) and so on.
[ ] We need to enable ways of specifying that Turing.jl should use some time T everywhere internally, e.g. through either the sampler or the sample method itself.
[ ] We need to replace all constructions of VarInfo (used internally in Turing.jl to keep track of realizations) with a corresponding one that takes the desired type into account.


rust: fix inconsistent result ordering

(supersedes #278)
In the search method, we're using a HashMap as a "queue" but HashMaps don't
maintain ordering. So we sometimes see results returned in different order.
Since we're traversing the tree breadth first, we don't need a sorting data
structure - we can just add things to the back of a proper queue and pull from
the front. That is enough to ensure we're always getting the lowest index.
In the streamSearch method we were using a BinaryHeap which sorts based on index.
This behaved correctly, in that results were always in the correct order, but
it is unnecessarily slow/complicated.
In the HTTPSearch we were already using a VecDeque, so no changes there.
Related discussion occurred in #277, #274

Seems sensible. Not sure why CircleCI is unhappy.

Just to maybe make things easy, I'm going to close this PR and open a new one to see if it makes circle CI happy.

Drat. CI is still angry.

Do you wan to try this @bjornharrtell?
https://support.circleci.com/hc/en-us/articles/12504745606171-Why-am-I-seeing-the-Could-not-find-a-usable-config-yml-you-may-have-revoked-the-CircleCI-OAuth-app-message
(Admittedly it's strange that it was working so recently... but I guess that's what happens when things break...)

But is it not more likely your connection to CircleCI since it's your branch?

"CircleCI will use the author's credentials in order to fetch the config.yml file"

I've invited you to the org.

Oh perhaps! I didn't realize I needed to make an account on some other service for CI to run.

Sorry to be a pain, but I can't give circleci read/write access to all my repositories just to get this CI green.
If you'd like to copy these changes into a branch in this repository and open the PR yourself maybe things would run?

Understandably. :) I'll just merge, this looks fine to me.


[cli] Unable to import rke config when creating cluster

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):
Create rke configuration file
cat << EOF > cluster-template.yml
rancher_kubernetes_engine_config:
  addon_job_timeout: 50
EOF

Create cluster using rke config file
rancher cluster create --rke-config cluster-template.yml testcluster

Export configuration settings to verify if addon_job_timeout uses a custom value
rancher cluster export testcluster | grep addon

Result:
The cluster is created with default values. Ignores settings in rke config file
$ rancher cluster export testcluser | grep addon
      addonJobTimeout: 45

Expected Result:
The cluster is created with settings from the rke config file.
Other details that may be helpful:
cli version v2.4.11
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.5.7
Installation option (single install/HA): single

Because you are provisioning the cluster from the Rancher-CLI, the rancher_kubernetes_engine_config isn't necessary.  The Rancher-CLI tool will be expecting a "pure" RKE config file, without the additional nesting.
Doing something like below should achieve what you want:
cat << EOF > cluster-template.yml
addon_job_timeout: 50
EOF

Thanks @capta1nk1rk that did the trick. The cluster now recognizes the modified settings.
I think your note would be beneficial in the docs here
https://www.rancher.co.jp/docs/rancher/v2.x/en/cluster-provisioning/rke-clusters/options/
Or possibly here as well
https://rancher.com/docs/rancher/v2.x/en/cli/


listener: refactor active tcp socket and active tcp listener

Commit Message:
#16763 is adding an internal listener. The internal listener is not driven by event dispatcher.
However, it shares the common functionalities of structuring the ownership of connections with the tcp listener.
This PR extracts the common functions so the extracted can be directed used by internal listener.
Additional Description:
Risk Level: LOW
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

/wait

Please look at open comments and let me know when this is ready for another round of review.

@antoniovicente Could you take a look? The commits are ready now

gentle ping @antoniovicente @mattklein123

I wasn't tracking the back and forth with @antoniovicente (who is out on vacation right now IIRC), but it's very difficult for me to tell what has changed in this PR. Can you possibly just do the pure code moves in one PR and then the changes in another? For example you can move all the active TCP socket code first, etc.

This PR doesn't add any functionality...
It is code move, with extra split of ActiveTcpListener which handles active sockets and active connections.
Now an ActiveTcpListener has 3 parts:

as the owner of active sockets
as the owner of active connection collection
create/destroy a single connection.

[3] is mainly to be extended to support the internal connection/listener in #16763 so that [1] and [2] can be reused.
Should I execute another split avoid the class hierarchy change [1][2][3]?

Yeah I understand it's just hard to track what is changing. My preference would be to wait until next week to see if @antoniovicente can finish this review. If that is not possible, would it be possible to just split again where you do the pure moves first (I think ActiveTcpSocket into its own file, etc.) and then the rest of it?

Sure. I can split so that I can get something pushed. Another split shouldn't be terrible for Antonio if that split is not helpful...

This PR is ready to be reviewed again: It turns to be a create a thin reused layer OwnedActiveStreamListenerBase
With this base class, ActiveConnection can be reused by both internal and tcp listener. And the error prone shared connection handling block are moved to here.

@mattklein123 The entire PR is almost move only.
I create a PR as your requested anyway: https://github.com/envoyproxy/envoy/pull/17551


Display and add to bash history full command after execution?

Is there a way to display and add to bash history full command with variables after execution?
regards

Yes: https://github.com/denisidoro/navi/blob/master/docs/installation.md#installing-the-shell-widget

Thx i missed it
Is there a way to run bash widget with custom options for example --path?
Run multiple widgets with --paths and different shortcut Ctrl+N Ctrl+P etc.
regards

Not out-of-the-box, no. What you can do is run navi widget bash just to get its output, copy it, edit it accordingly and paste in your .bashrc file


Added Everest Fiat in and Fiat out NPM Package

Added the Everest Network Ltd. Fiat in and Fiat out NPM package to the Bancor fiat providers widget.

I will open a new pull request with the correct image encoding. Thank you.


Error querying the blockchain

I open my particl (android) and go to my BTC  its says:  Error querying the blockchain. I refresh but still an error.
Last to receive  data 12 day ago.
What's wrong with your app?
Pls Fix ASAP.

Dublicate

How this issue closed and nobody answered???


[WIP] Don't suggest names for errors in normal IDE usage

[ ] Get the code fix working (no symboluses)
[ ] Consider that this is gonna be kind of expensive to get all symbols and maybe there should be a different approach
[ ] Maybe do it differently i dunno

#6044

After thinking about this a bit more, I think we just have to disable to code fix by default. It's still going to be expensive and depending on how the user mouses over things in the editor will still use lots of CPU and memory.
I don't feel too bad about disabling it entirely, since code fixes are so rarely invoked by users in general.
The real solution here is to have a separate, tree-like structure the IDE builds up and maintains as new identifiers show up, like how Roslyn does it.


Add backport setups as we now have 1.x branch.

Signed-off-by: Peter Zhu<EMAIL_ADDRESS>Description
Add backport setups as we now have 1.x branch.
Since 2.0.0 is coming I would keep main as 2.x.x and create a new branch 1.x.
The 1.x branch will serve as the active branch for 1.3.x and others in 1.x.
If anyone pushing code that runs on both 1.x and main, they can just open PR to main then add the tag backport 1.x to the PR and the workflow will automatically create backport PR.
If the code is specific to main branch and 2.x.x then they can ignore adding the tag.
Thanks.
Issues Resolved
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Close this for now as I think back and probably better let users switch versions directly instead of maintaining a second branch.


Change v1.5.9 to v1.5.10

Rationale
during the v1.5.10 release, I hadn't noticed that the grep regex matching the word didn't update v1.5.9 to v1.5.10.  Since, I updated our docs to include a grep regex pattern that would match this.  Used it to create the changes in this pr.
Changes

change "v1.5.9" to "v1.5.10" which was not changed during the release due to not matching the regex.

Checklist

[x] This PR maintains parity between Docker Compose and Helm

Testing
unit tests pass for compose and helm pass.
1.5.9 no longer exists in the repo:
[fiftyone-teams-app-deploy]$ grep -r '1\.5\.9' . --exclude-dir=.git

and 1.5.10 does:
[fiftyone-teams-app-deploy]$ grep -r '1\.5\.10' . --exclude-dir=.git
./docker/README.md:    image: voxel51/fiftyone-app-torch:v1.5.10
./docker/README.md:1. [Upgrade to FiftyOne Teams version 1.5.10](#deploying-fiftyone-teams)
./docker/README.md:You will not be able to connect to a FiftyOne Teams 1.5.10
./docker/README.md:1. [Upgrade to FiftyOne Teams version 1.5.10](#deploying-fiftyone-teams)
./docker/common-services.yaml:    image: voxel51/fiftyone-teams-api:v1.5.10
./docker/common-services.yaml:    image: voxel51/fiftyone-teams-app:v1.5.10
./docker/common-services.yaml:    image: voxel51/fiftyone-app:v1.5.10
./docker/common-services.yaml:    image: voxel51/fiftyone-app:v1.5.10
./tests/unit/compose/docker-compose_test.go:			"voxel51/fiftyone-teams-api:v1.5.10",
./tests/unit/compose/docker-compose_test.go:			"voxel51/fiftyone-teams-app:v1.5.10",
./tests/unit/compose/docker-compose_test.go:			"voxel51/fiftyone-app:v1.5.10",
./tests/unit/compose/docker-compose_test.go:			"voxel51/fiftyone-app:v1.5.10",
./helm/gke-example/values.yaml:#     # FIFTYONE_DATABASE_ADMIN is set to `false` by default for v1.5.10 installs
./helm/fiftyone-teams-app/Chart.yaml:version: 1.5.10
./helm/fiftyone-teams-app/Chart.yaml:appVersion: "v1.5.10"
./helm/fiftyone-teams-app/README.md.gotmpl:1. [Upgrade to FiftyOne Teams version 1.5.10](#launch-fiftyone-teams)
./helm/fiftyone-teams-app/README.md.gotmpl:You will not be able to connect to a FiftyOne Teams 1.5.10
./helm/fiftyone-teams-app/README.md.gotmpl:1. [Upgrade to FiftyOne Teams version 1.5.10](#launch-fiftyone-teams)
./helm/fiftyone-teams-app/README.md:![Version: 1.5.10](https://img.shields.io/badge/Version-1.5.10-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v1.5.10](https://img.shields.io/badge/AppVersion-v1.5.10-informational?style=flat-square)
./helm/fiftyone-teams-app/README.md:1. [Upgrade to FiftyOne Teams version 1.5.10](#launch-fiftyone-teams)
./helm/fiftyone-teams-app/README.md:You will not be able to connect to a FiftyOne Teams 1.5.10
./helm/fiftyone-teams-app/README.md:1. [Upgrade to FiftyOne Teams version 1.5.10](#launch-fiftyone-teams)

And thankfully, this didn't trigger another helm chart release (and that there were no chart changes) yay!


Fix .NET 4.0 Trace Tests

#1236 disables these tests because trace parsing on newer operating systems doesn't work on traces captured on Windows 7.  This manifests as a missing EventTrace event, which is required for PerfView to properly view the trace.

Closing as this is a bug in the OS and I'm not worried about being able to open traces on Win10 that were captured on Win7.


Pulling desync reduction and sanity

About the PR
see changelog, fixes #5139
Changelog
:cl:

tweak: Pulling to a specific location now pushes the player doing the pulling
tweak: Pulled object rotation snaps cleanly to (grid-relative) angles so pianos don't get stuck as often
fix: Moved more pulling code server-side to prevent desyncs

Just realized a possible bug in regards to moving/spinning objects, will fix, hold on

Dealt with via more EntityCoordinates

how does this work with high ping? since seems like its predicting less in an effort to avoid desyncs

The stuff for which prediction has been removed are solely state changes that either weren't actually being predicted anyway for various reasons or shouldn't be predicted because the client may mispredict it and end up desynced.

desyncs only last until a new state comes in half ping anyway, and stopping pulling feels really bad at the moment and should be predicted someday

I'll remove the commit that rearranges things, but I don't think it's a good idea.

Um, might want to re-review soonish, people are pulling air canisters, pAIs, whatever objects they can find around.


Dropdowns initialized using javascript (without data-bs-toggle) are shown on click to the button but cannot be hidden.

Dropdowns initialized using javascript can be shown by clicking to the button but re-clicking doesn't hide the dropdown. The button doesn't have "data-bs-toggle" attribute.
https://codepen.io/hsyndrsn/pen/oNYGVvo
Operating System: Pardus 19.4-1 Gnome
Browser: Chrome 88.0.4324.182

data-bs-toggle="dropdown" still required
Regardless of whether you call your dropdown via JavaScript or instead use the data-api, data-bs-toggle="dropdown" is always required to be present on the dropdown’s trigger element.

https://getbootstrap.com/docs/5.0/components/dropdowns/#via-javascript
Because there are some events attached by data-bs-toggle="dropdown" selector.

Right, @rohit2sharma95 so this is a non-issue? if so feel free to close.

The requirement of this selector can be omitted in the future though.


Remove non-spec response_type param from /oauth/token endpoint

Hey team. Work in this PR addresses the following issues:
#810 response_type param should not be required with /oauth/token
#777 id_token refresh working for k8s
#809 UAA returns id_token from /oauth/token to clients that the UAA grants openid scope without requiring response_type=id_token param
I also updated docs in c1b7d5b and removed this parameter from tests where it no longer has any effects (8585edd, 762f4bb) . /oauth/authorize usages of response_type param were not changed.
I have not done my own testing/acceptance with kubernetes yet, but all tests are passing locally and I am able to get id_tokens during refresh flow using the client we are using in PKS:
uaac token client get admin -s adminsecret
uaac client add pks_cluster_client --authorized_grant_types password --secret "" --scope openid,roles
uaac token owner get pks_cluster_client marissa -s "" -p koala
uaac context # see the id_token. Grab the refresh token, put it in a variable called REFRESH_TOKEN.
curl -X POST http://localhost:8080/uaa/oauth/token -d"grant_type=refresh_token&client_id=pks_cluster_client&client_secret=&refresh_token=$REFRESH_TOKEN"

Is there anything you want changed or reworked in this PR? From Tracker is appears you have concerns about /oauth/authorize but I believe these changes stand on their own. @DennisDenuto

@jhamon we initially added a task list containing acceptance criteria from GH issues:  [#810, #777, #809] and the tracker story https://www.pivotaltracker.com/story/show/160260269
However https://www.pivotaltracker.com/story/show/160260269 has been split out to remove any reference to /authorize (We have updated the task list)
After further analysis on the change made to the TokenMvcMockTests.java, we believe that some of these test are mis-configured.
e.g. https://github.com/cloudfoundry/uaa/blob/4d9e0108e367c80238dd5cf595660cb14325d29c/uaa/src/test/java/org/cloudfoundry/identity/uaa/mock/token/TokenMvcMockTests.java#L3279-L3287 provides correct credentials, except expects a 401. The reason being that it is missing the Content-Type header.
With [this commit](See https://github.com/cloudfoundry/uaa/commit/ce652a3c482d11626a1af57a1bdd2dd6ba3d2d3e
) (that tries to fix the test config) The change in this PR does return a 401 is credentials are invalid - which we believe is the correct behavior.
fyi: We are in the process of backfilling some tests before merging in this change.

Thanks @DennisDenuto :partyparrot:

Thanks @jhamon && @pgoodwin for the PR!


add starterProject fields

What does this PR do?
adds starterProject field
What issues does this PR fix or reference?
https://github.com/devfile/kubernetes-api/issues/42
Is your PR tested? Consider putting some instruction how to test your changes

This is my first time contributing to this repo.
@davidfestal Please, let me know if there is something more that I need to do in this PR.

In the future, could you please separate out the auto-generated files into a separate commit to ease review?

👍 Sure. I will make sure to do that.

I'm reviewing it.


translation_missing" title="translation missing: en.spree.you_must_enter_value_for_rating

Rating You Must Enter Value For Rating
I am constantly getting this issue Even I added "you_must_enter_value_for_rating" in my locale file
Am I doing something wrong?

I am getting same issue.
can any one help me to resolve this?

The fix in pull request#187 should fix this issue.


fix: Ensure redirect to login when using empty auth token

Related to https://github.com/argoproj/argo/pull/4412
Signed-off-by: Simon Behar<EMAIL_ADDRESS>Checklist:

[ ] My organization is added to USERS.md.

Back-ported to 2.12


While executing data driven tcs in testng-xml generated it shows one set of tcs in ignored

QAF Version : 3.0.0

Note: only the latest version is supported
While executing data driven tcs it executes the test case for 2 set of data and shows proper result in dasboard.htm
But while generating result in "testng.xml" it shows .
Its counting one set as ignored even though it has executed for the given set.

Steps To Reproduce
1.Execute data driven tcs for `api`
2.Check testng-xml generated

Expected behavior : It executes the data driven BDD for 2 set o data properly while testng-xml report is generated it should not count ignored=1
It should be :
Actual behavior :
It counts one set of tcs in ignored in testng-xml.
Is the issue reproducible on runner?

[x] QAS
[ ] Maven
[ ] Gradle
[x] Ant
[ ] Eclipse

Test case sample

[23-04 17:37] Bincy Babu

@key:home.get
Scenario: Field level Validations for ImageLinkList Container
Given user sets the url 'home.get'
Then user validates the api status code '200' and status 'OK'
Then user validates response has jsonpath '$..version'
api-request.xml
<root>
    <home>
            <get>
                <endPoint>${intermiles.endpoint.home}</endPoint>
                <baseUrl>${intermiles.api.baseurl}</baseUrl>
                <method>GET</method>
            </get>
            <get>
                <endPoint>${intermiles.endpoint.home1}</endPoint>
                <baseUrl>${intermiles.api.baseurl}</baseUrl>
                <method>GET</method>
            </get>
    </home>
<root>

uat.properties:
intermiles.api.baseurl=https://uatresources.******.com
intermiles.endpoint.home=/iwov-resources/caas/json/Mobile/home.json
intermiles.endpoint.home1=/iwov-resources/caas/json/Mobile/400/home.json

You didn't provided step implantation and execution configuration used. Will you please  share the test case (as small as possible) which reproduces the issue?
Below worked fine for me:
@key:home.get
Scenario: Field level Validations for ImageLinkList Container
	Given COMMENT: '${endPoint}'


WIP: Modal DismissIntent/Action shortcut

Description
Currently there is no support for dismissing modal routes with the keyboard (usually with the 'escape' shortcut key). This PR adds a new DismissIntent and corresponding DismissAction as well as hooking these up for the escape key for all modal routes (drawers, popups, dialogs, etc).
Related Issues
Tests
TBD
Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x]I signed the [CLA].
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them?

[x] No, no existing tests failed, so this is not a breaking change.

This looks pretty good. We'll need to make sure that it is the right thing for the web, but otherwise I think all platforms use escape in this way.

This looks pretty good. We'll need to make sure that it is the right thing for the web, but otherwise I think all platforms use escape in this way.

Yeah, from a cursory look of a few webapps, it appears that escape to dismiss popups is pretty common.
I'll go ahead and flush this out with docs and tests to get this ready for review. Any thoughts about putting this on the _ModalScope? It seemed like the best place to me, but I am not that familiar with the route code.


Add useTitleTemplate hook

Implements a new hook: useTitleTemplate which can be used to format the output of useTitle. The %s part of the template will be replaced with title.
Usage
useTitleTemplate('%s | Site');
useTitle('hooked-head')

// title will be: "hooked-head | Site"

This is looking great, could you also add an entry to the README? Awesome work already, thanks!

If you fee llike this is ready, feel free to put it in ready for review :) I'd gladly get this in and publish it

@JoviDeCroock Thanks for your kind words :1st_place_medal: I think this is ready for a review now.
What I'm still thinking about:

useTitle and useTitleTemplate are almost similar. The only difference is the key, so these two hooks could share the same code.
does it make sense, to cover the case that useTitleTemplate is used after useTitle? And if: could this work with the current implementation?
should we create a setDocumentTitle function which wraps the repeating document.title calls in the dispatcher?

useTitle and useTitleTemplate are almost similar. The only difference is the key, so these two hooks could share the same code.
Could probably be covered as an option so useTitle can be a template or a title

does it make sense, to cover the case that useTitleTemplate is used after useTitle? And if: could this work with the current implementation?
This is covered by the dispatcher already

should we create a setDocumentTitle function which wraps the repeating document.title calls in the dispatcher?
I could be misunderstanding this but this is already the job of the dispatcher


Added C++ and Console Functions to get Vertical Sync status.

Added C++ getVerticalSync() functions
Added getVerticalSync Console function

Didn't have to recreate the pull request, any changes you make to your source branch shows up here automatically by the way. Unfortunately there's some funny business going on with the braces in platformVideo_ScriptBinding.h file changes. ;)

I know I didn't have to go through such lengths but Everything got messed up with SourceTree so I decided to fix my Whitespaces problem once and for all (so easy once you know how!!!) and make it cleaner.
Fixed the braces.


net/http: HTTP/2 connections incorrectly marked as "reused"

The Transport retry loop checks to see if a request was sent on a fresh connection or a reused one (persistConn.shouldRetryRequest). Requests sent on a fresh connection are not retried, to avoid looping forever if the server is hanging up on the request for some reason.
Connections are marked as reused when added to the idle conn pool (Transport.tryPutIdleConn).
HTTP/2 connections are added to the idle conn pool as soon as they're made, since the connection can be reused for additional HTTP/2 requests while the first is in flight.
Thus, we incorrectly retry requests to an HTTP/2 server that hangs up without giving a response (say, because we sent a malformed request), because HTTP/2 connections are always marked as "reused".

...also, the HTTP/2 side has its own competing retry loop which doesn't apply the "don't retry if the first request on a connection fails" heuristic, so fixing this only on the net/http side is insufficient.

As i known, this issue will affect go1.22 and go1.21. why not backport this to these old version? thanks.


How to position the Speeddial button?

In the developer console I managed to position the button by changing the styles of the container but from what I can see there is no support for changing the styles of the container without changing the react-mui-speeddial code. Is there any way to do what I want currently? If not I can open a PR to add support for a style attribute to style the container if you are interested.

You can do that with style now. Published as 0.0.6

Okay, thanks


Get token error

You have to run the program in the same directory. If you have downloaded it to Music/SMD/smd, run it in Music/SMD/smd, not in  Music/New.


when compiling with CRTCPPMOD the pre and post commands are spawned in separate jobs and do not affect the compile

In scripts/launch the pre and postcmd are executed in their own jobs, so they don't have any effect the compile execution
to do this right we need to spawn a a single job (maybe using bash -c ) to run all three commands pre, compiler, post in a single 'cl' generated job that is DIFFERENT from the PASE shell because CRTCPPMOD can't be run in a PASE shell becuase it will turn around and invoke a PASE job for the shared C++ front end

Maybe we can try running the job in launch using cl -K and getting that joblog


Added additional positioning properties to Popup and ContextMenu.

What does the pull request do?
Adds the following positioning properties to Popup:

PlacementAnchor
PlacementGravity
PlacementRect
PlacementConstraintAdjustment

Adds the new properties to ContextMenu, along with the following which were previously present on Popup but not ContextMenu:

PlacementMode
PlacementTarget
HorizontalOffset
VerticalOffset

These properties are passed to the inner Popup to position the context menu popup.

yolo merging this


Nearest Cells Filter to show values

Showing min and max values of the histogram (x axis)

+Rename filter into: Cell Intensity Histogram. The term nearest cells fits no nearly all filters.

Updating img:


Using volume to persist db data

The motivation here is to make it easier to make it safer to persist the db data in case of accidental deletion of the db container or in case of upgrades:
https://docs.docker.com/compose/compose-file/#volumes-volume-driver
The change will be in docker-compose.yml
# ...
  postgres:
    image: postgres:9.5
    volumes:
      - pgvolume:/var/lib/postgresql/data #using the declared volume
    environment:
      - POSTGRES_USER=postgres
      - POSTGRES_PASSWORD=postgres
# ...
# before the end of file:
volumes:
  pgvolume:  #declare a volume named pgvolume

I forget why we did not do this to begin with. Should be fine, may need to add a test to make sure the volume gets cleaned up.

may need to add a test to make sure the volume gets cleaned up.

It depends on what you mean by "gets cleaned up" and the circumstances around that. Can you elaborate more when it should do?

The clean up would just be when running the https://github.com/CachetHQ/Docker/blob/master/test/test.full.bats tests, so that the php artisan cachet:seed test actually does something.

I believe this one should work:
 docker-compose run --rm postgres


Ruby sometimes classes give NoSuchMethodError

Hey,
Great project! I've been playing around with this. I've found an error in the ruby plugin classes that are trying to use properties/methods on the SkillSet class.
For example, when trying to hit a dummy once, everything works as expected. However, after a few times, hitting the dummy again will result in the SkillSet.skill method not being defined / accessable by JRuby and JRuby therefore throws a NoSuchMethodError on the game pulse.
Found also occuring when:

using the level command
trying to use the magic spellbook

Anyone else have this, or is my there something wrong with my config..
Edit: Here is the stack trace
SEVERE: Uncaught exception thrown while handling message: org.apollo.game.message.impl.CommandMessage@290e5589
org.jruby.exceptions.RaiseException: (NoMethodError) undefined method `experience_for_level' for Java::OrgApolloGameModelEntity::SkillSet:Class
	at org.jruby.RubyBasicObject.method_missing(org/jruby/RubyBasicObject.java:1592)
	at RUBY.block in (root)(/Users/hidde/IdeaProjects/apollo/./data/plugins/cmd/skill/skill.rb:23)
	at org.jruby.RubyProc.call(org/jruby/RubyProc.java:318)
	at RUBY.execute(/Users/hidde/IdeaProjects/apollo/./data/plugins/bootstrap.rb:55)

Thanks

Still not working after #309 . Could it be the JRuby version?

This is strange... does this error occur in a fresh clone (i.e. in a copy of apollo that you haven't made any changes to)?

I'll retry that, I have only changed the updateRequired method to always return true, because my client wouldnt let me log in. I'll get back to you in a few hours.

Clean clone gives a 'GC overhead limit exceeded' at the CollisionUpdate (due to my 377 cache). Increasing the memory limit to 2048M makes it work.
However, the error persists. Could it be a cache issue?

@hlycklama your client wouldn't let you log in?  Also, when do you see the GC overhead limit exceeded message.  At boot up?

Yes, the client would get an 'Update available' message from the server, after comparing versions of the cache, even though the server is using the same one as the client.  I'm using some 'clean' 377 client and cache from the web
What client are you using? Is there some reference version I can use?
Also, not sure if you need this, but the GC stacktrace:
Jan 02, 2017 9:44:33 PM org.apollo.Server <init> INFO: Starting Apollo... Jan 02, 2017 9:44:33 PM org.apollo.Server init INFO: Initialized Release 377. Jan 02, 2017 9:44:34 PM org.apollo.ServiceManager startAll INFO: Starting services... Jan 02, 2017 9:45:25 PM org.apollo.Server main SEVERE: Error whilst starting server. java.lang.OutOfMemoryError: GC overhead limit exceeded 	at java.util.HashMap.newNode(HashMap.java:1742) 	at java.util.HashMap.putVal(HashMap.java:630) 	at java.util.HashMap.put(HashMap.java:611) 	at java.util.HashSet.add(HashSet.java:219) 	at com.google.common.collect.AbstractMapBasedMultimap.put(AbstractMapBasedMultimap.java:196) 	at com.google.common.collect.AbstractSetMultimap.put(AbstractSetMultimap.java:128) 	at org.apollo.game.model.area.collision.CollisionUpdate$Builder.lambda$tile$0(CollisionUpdate.java:130) 	at org.apollo.game.model.area.collision.CollisionUpdate$Builder$$Lambda$25/905544614.accept(Unknown Source) 	at java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948) 	at java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:580) 	at org.apollo.game.model.area.collision.CollisionUpdate$Builder.tile(CollisionUpdate.java:130) 	at org.apollo.game.model.area.collision.CollisionManager.build(CollisionManager.java:77) 	at org.apollo.game.model.World.init(World.java:241) 	at org.apollo.Server.init(Server.java:158) 	at org.apollo.Server.main(Server.java:53)

Looks like as of jruby 9000 static methods can't be accessed using the Javabean aliasing magic (no object.x -> object.getX).


[5.6] Redirect with input when sending reset links fails

When send reset links fails the user was redirected back to the form but the input old email value was not populated.

Populating with incorrect input seems counterintuitive. 🤷🏼♂

@devcircus It gives the user a chance to check what the incorrect input was. "What do you mean my email doesn't exist? Oh I misplaced the @ symbol, fair enough."

👍🏻 good point


Add a weight system to order items on the same branch

It would be great to add an optional weight for the items of the menu. This weight would be used when rendering the menu to order the items located in the same level of the tree.
I know that at the moment if I want an item at the end of the list I have to add it last. But it would simplify a lot of logic in the code if we could use a weight system.
ie. you want to display 5 menu items depending of the user role:
without weight system:
$root->addChild('menu.item1', array('route' => '_my_route1'));
$root->addChild('menu.item2', array('route' => '_my_route2'));

if ($security->isGranted('ROLE_A')) {
   $root->addChild('menu.item3', array('route' => '_my_route3'));
}

$root->addChild('menu.item4', array('route' => '_my_route4'));

if ($security->isGranted('ROLE_A')) {
    $root->addChild('menu.item5', array('route' => '_my_route5'));
}

with a weight system:

$root->addChild('menu.item1', array('route' => '_my_route1', 'weight' => 0));
$root->addChild('menu.item2', array('route' => '_my_route2', 'weight' => 10));
$root->addChild('menu.item4', array('route' => '_my_route4', 'weight' => 20));

if ($security->isGranted('ROLE_A')) {
   $root->addChild('menu.item3', array('route' => '_my_route3', 'weight' => 15));
   $root->addChild('menu.item5', array('route' => '_my_route5', 'weight' => 25));
}

I had a look to the options and could not find it so I guess it's not been implemented for now but I'll be happy to know that I'm wrong :)
Cheers,
Maxime

Hi all! Any news on the issue?

SOLUTION
$item->reorderChildren([
    'child_name_1',
    'child_name_2',
    'child_name_3',
    'child_name_4',
]);

save my life man... I was looking for this for the last 4 years...

@Maxwell2022 I found that method occasionally) Array items are names you give to the menu's children.


[task-rts]  delete cron api

Hey team! Please add your planning poker estimate with Zenhub @nsarupr @srix


Update NodeLink3D.js to Version 1.2.0 with New Features and Improvements

This pull request updates the NodeLink3D.js library to version 1.2.0, incorporating a range of new features, performance enhancements, and user experience improvements. The changes include significant updates to visualization, interactivity, and functionality.
Key Updates:

Interactive Node Highlighting and Hover Effects: Nodes now enlarge on hover, enhancing visual feedback.
Dynamic Color Mapping: Nodes' colors now reflect their degree, with nodes having a degree greater than 5 highlighted in red.
Enhanced Camera Controls: Added zoom and pan functionality, with configurable sensitivity and radius limits.
Collision Detection: Integrated forceCollide() to prevent node overlap and ensure readability.
Node Label Visibility: Labels are now visible on hover for better node identification.
Gravity Simulation: Added custom gravity to pull nodes toward the graph's center, improving layout stability.
Physics-Based Force Adjustments: Fine-tuned link and charge strengths for smoother node interactions.
Node Filtering (Future-Ready): Foundation laid for future node filtering based on properties.
Graph Export Functionality: Users can now export the network's state as a JSON file.

Improvements:

Camera Behavior Enhancements: Introduced bouncing and auto-rotation for a better interactive experience.

Node Scaling Animation: Smoother scaling animations on hover.

Performance Optimization: Enhanced dataset handling using forceManyBody().

FAQs:

Node Filtering: Currently under development; future updates will support filtering nodes by various attributes.
Camera Customization: Zoom and pan sensitivity, along with camera radius limits, are configurable.
Collision Detection: Utilizes forceCollide() to prevent node overlap.
Export Format: Graph state is exported as a JSON file.

What's Next:

Need to Complete Node Filtering Functionality
Add Support for Advanced Graph Layouts
Real-Time Data Updates

Please review these changes and merge them to integrate the latest updates into the main branch.

Thank you for these contributions! Please give me a few days to review and test the changes before merging. In the meantime have you sent a completed version of the contributor license agreement (CLA) to<EMAIL_ADDRESS>If not please do so, I can not merge until I have confirmation from the JPMC open source team.

Yes David, I sent it the day I started working on our project. But I
haven't received any confirmation mail regarding it from JPMC.
Regards,
Don Brightson
On Tue, 17 Sept 2024, 00:55 David Saffo, @.***> wrote:

Thank you for these contributions! Please give me a few days to review and
test the changes before merging. In the meantime have you sent a completed
version of the contributor license agreement (CLA) to
@.***? If not please do so, I can not merge until I
have confirmation from the JPMC open source team.
—
Reply to this email directly, view it on GitHub
https://github.com/jpmorganchase/anu/pull/48#issuecomment-2353737650,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVIMP7WTEREPWDNMAS6GWSDZW4WA3AVCNFSM6AAAAABOGRNCIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJTG4ZTONRVGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thank you for these contributions! Please give me a few days to review and test the changes before merging. In the meantime have you sent a completed version of the contributor license agreement (CLA) to<EMAIL_ADDRESS>If not please do so, I can not merge until I have confirmation from the JPMC open source team.

Hi, can I know when you'll go through the changes and accept this pull request?


Error when using with Windows, "Python not found"

I'm trying to use Sublime 4 with Python 3.9.1 and this plugin. When I try to launch using this plugin using a simple project I get an error that says:
 Python was not found. Run without arguments to install from the Microsoft store.
Python is in my path and I only have one Python version installed on my system. I can run Python just fine from a command line and it works.

I'm going to close this issue. I did some Googling and found that there were app aliases set in Windows that were causing the problem. Here is a StackOverflow thread:
https://stackoverflow.com/questions/58754860/cmd-opens-window-store-when-i-type-python

I'm going to close this issue. I did some Googling and found that there were app aliases set in Windows that were causing the problem. Here is a StackOverflow thread:
https://stackoverflow.com/questions/58754860/cmd-opens-window-store-when-i-type-python


Get rid of TypeVars

Fixes # (provide issue number if applicable)
Fix #1483
References

https://github.com/praw-dev/praw/issues/1330#issuecomment-623347312

Per https://praw.slack.com/archives/CRZ00QLC9/p1588649050296900, this PR will be done in an alternate method.


Can't write to Blob

I tried this, and no container is created, not even when the container exists, nothing happens.
LOGGING = {
    'version': 1,
    'formatters': {
        'simple': {
            'format': '%(asctime)s %(message)s',
        },
        'verbose': {
            'format': '%(asctime)s %(levelname)s %(hostname)s %(process)d %(message)s',
        }
    },
    'handlers': {
        'file': {
            'account_name': 'myaccountname',
            'account_key': 'myaccountkey',
            'protocol': 'https',
            'level': 'DEBUG',
            'class': 'azure_storage_logging.handlers.BlobStorageTimedRotatingFileHandler',
            'formatter': 'verbose',
            'filename': 'example.log',
            'when': 'D',
            'interval': 1,
            'container': 'logs-%(hostname)s',
            'zip_compression': False,
        }
    },
    'root': {
        'handlers': ['file'],
        'level': 'DEBUG',
    }
}

import logging
from logging.config import dictConfig
# from azure_storage_logging.handlers import BlobStorageTimedRotatingFileHandler

try:
    dictConfig(LOGGING)
except:
    print 'Error Loading Config'
else: print 'Config Loaded'
```

It does create a local file example.log instead of on the cloud storage

The handler tries to store a log file in a blob container when the log file is outdated, and the handler creates the container at the same time if it doesn't exist in your storage.
The handler also evaluates if the log file should be rolled over or not when logging is performed, so add some logging to the file at the last of your example like the following and run it once.
logging.getLogger('root').info('test message')

And then run the example again after 24 hours or more (because the interval is set to 1 day in the example), and the container will be created in your storage and the outdated log file will be stored in the container.

Ok, i misunderstood and thought the file would be created instantly, and not only when the log file is outdated. You can close the issue sorry.


Dump each goroutine stack as a separate log message

This changes the stack dumping code so that we split the giant string
containing every goroutine's stack and log each stack as a separate log
message. This makes the output easier to parse, and especially helps in
cases where the log output is sent through a system with a log message
size limit, such as Windows's ETW.
Signed-off-by: Kevin Parsons<EMAIL_ADDRESS>

LGTM

My only issue with this (and I understand you need some solution because of content length) is that there are tools which can consume Golang stack traces and a simple cut and paste or pipe into those tools was possible in today's model.
Also, once you split the log entries, it's quite possible that other goroutines can insert log entries while you are parsing and logging these entries. Not the end of the world, but again, could make using/re-assembling this information trickier with this change.

@estesp Good point, I wasn't aware there was tooling that relied on parsing all the stacks in one big blob. Do you think these mean we should avoid this change?
We could try to make a change in our logrus->ETW hook so it would split up the events there instead, but it seems non-trivial how to split up structured events into multiple pieces, so this seemed easier to handle at the source of the event data.
Right now we are stuck in a state where ETW frequently drops the containerd stack event, since the max size is 64KB, and containerd frequently has a large number of goroutines.

There are tools like https://github.com/linuxerwang/goroutine-inspect.
Assembling the original stack dump from this split one could be possible by adding a unique ID (UUID) on each line and having the number of the total lines on the beginning of the split one.
Alternatively we can make this as a configuration option.

Closing due to inactivity, feel free to re-open the pull request anytime if you continue working on this.


[FLINK-18759][tests] Add readme.md for TPC-DS tools

What is the purpose of the change

This pull request adding readme.md for TPC-DS tools to help user understand the test better.

Brief change log

Add readme.md in tpcds-tool
Minor cleanup in tpcds-tool/data_generator.sh

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): ( no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

cc @godfreyhe could you help review this pr?


Invalid method-object reference in example/rest_03_stock_querying.py in "get_conid with too many conids" commented out code.

https://github.com/Voyz/ibind/blob/49ab5b0da6bc6f7168cad6ef1034f0d30c671f7b/examples/rest_03_stock_querying.py#L58
example:
conids = c.get_conids('AAPL', default_filtering=False).data
#### get_conid with too many conids ####
Traceback (most recent call last):
  File "/home/ibind/examples/rest_03_stock_querying.py", line 58, in <module>
    conids = c.get_conids('AAPL', default_filtering=False).data
             ^
NameError: name 'c' is not defined

should be:
conids = client.stock_conid_by_symbol('AAPL', default_filtering=False).data
#### get_conid with too many conids ####
Traceback (most recent call last):
  File "/home/ibind/examples/rest_03_stock_querying.py", line 58, in <module>
    conids = client.stock_conid_by_symbol('AAPL', default_filtering=False).data
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ibeam/ibeam_3.12_venv/lib/python3.12/site-packages/ibind/support/py_utils.py", line 51, in ensure_list_args_wrapper
    return func(*args_list, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ibeam/ibeam_3.12_venv/lib/python3.12/site-packages/ibind/client/ibkr_client_mixins/contract_mixin.py", line 302, in stock_conid_by_symbol
    raise RuntimeError(
RuntimeError: Filtering stock "AAPL" returned 3 instruments and 3 contracts using following query: AAPL.
Please use filters to ensure that only one instrument and one contract per symbol is selected in order to avoid conid ambiguity.
Be aware that contracts are filtered as {"isUS": True} by default. Set default_filtering=False to prevent this default filtering or specify custom filters. See inline documentation for more details.
Instruments returned:
<redacted>

Hey @GonzRon well spotted! Thanks! I've pushed out the fix 👍


Add Fetch Jobs of a Flow API call

Add the Fetch Jobs of a Flow API call, as documented in the Azkaban project
For a given project and a flow id, this API call fetches all the jobs that belong to this flow. It also returns the corresponding graph structure of those jobs.

On it


New rule/array constraints

PR summary
Adds a new rule to enforce constraints are set on array schemas. This is to enforce the related guidance in the API Handbook and resolves #458.
One consideration is that the constraints are only required for request schemas and just recommended for response schemas. We could potentially only validate request schemas but the "SHOULD" in the handbook for response schemas seems enough motivation to me to add the warning. Happy to entertain other opinions on this. It is the kind of rule that may start adding lots of warnings in user's API Definitions.
PR Checklist
General checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)
[x] Dependencies have been updated as needed
[x] .secrets.baseline updated as needed?

Checklist for adding a new validation rule:

[x] Added new validation rule definition (packages/ruleset/src/rules/*.js, index.js)
[x] If necessary, added new validation rule implementation (packages/ruleset/src/functions/*.js, updated index.js)
[x] Added new rule to default configuration (packages/ruleset/src/ibm-oas.js)
[x] Added tests for new rule (packages/ruleset/test/*.test.js)
[x] Added docs for new rule (docs/ibm-cloud-rules.md)

Checklist for removing an old validation rule:

[ ] Removed old rule implementation (packages/validator/src/plugins/validation/*.js)
[ ] Removed or adjusted testcases (packages/validator/test)
[ ] Updated default configuration to deprecate old rule (packages/validator/src/.defaultsForValidator.js)
[ ] Removed docs of old rule (docs/ibm-legacy-rules.md)

:tada: This PR is included in version 0.82.0 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


Update Blog “time-of-a-square”

Automatically generated by Netlify CMS

👷 Deploy Preview for famous-kulfi-ae21db processing.

Name
Link

🔨 Latest commit
7c9b1f7365d3b9084f40e059e28cbea4d9752158

🔍 Latest deploy log
https://app.netlify.com/sites/famous-kulfi-ae21db/deploys/658412b6e45e5300084b7b61


Remove non-FIPS ciphers from defaults

Issue: https://github.com/open-cluster-management/backlog/issues/12787
Only define FIPS-compliant ciphers by default so no changes are
necessary to be FIPS compliant.
Signed-off-by: Jakob Gray<EMAIL_ADDRESS>

/unhold


decodeURI

i get this error when i try to get the tokens??
if(xs && xs.indexOf('%')) xs = decodeURIComponent(xs);
                               ^

URIError: URI malformed

I made it use decode because lots of users don't decode their cookies before use and reporting problems because of this.
https://github.com/pulviscriptor/agario-client/blob/master/account.js#L50
If you really need % symbol (which i think you don't and you have some problem somewhere setting xs to some wrong value) you can encode your cookies https://developer.mozilla.org/ru/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent

Using Regular Expression (in my next PR), we can try to find out if using decodeURIComponent is really necessary.
var find_hex = /\%[0-9A-F]{2}/i;
...
if(xs && xs.match(find_hex)) xs = decodeURIComponent(xs);

Updated NPM package to 1.3.7 with DRSDavidSoft's fix.


Mouse wheel scrolling invertion

Description of the new feature / enhancement
Some people just like to scroll in a "natural" direction using their mouse scroll wheel - like using a touch pad.
Since windows doesn't seem to be able to provide such a small feature I'd like to request to implement this in PowerToys.
Scenario when this would be used?
Would be used EVERYWHERE as this is an essential individual way of using a mouse / scroll wheel.
Supporting information
No response

Thanks for your message. This is a Duplicate of another issue: /dup #6434


New maintainer for Flask-Uploads

Details here: https://github.com/mitsuhiko/flask/pull/1493#issuecomment-123928860

@mitsuhiko @DasIch can this get merged?

I'm going to update it to point at @maxcountryman's repo for now, since he controls the name.  Hopefully he can get your work merged in. 29feb640d0002913a0a8168c785d98f69e512968

No problem, thanks for updating @davidism.
It's still nuts to me how @maxcountryman went about this--took over a repo after the owner said he was handing it to someone else, even though he'd had zero commits on the project, and then refuses to interact with the community discussion of the handover.


Custom cursor reverts to system cursor in fullscreen on macOS

Godot version
4.0.2 stable
System information
macOS 13.3.1, any renderer, Apple M1 Pro GPU
Issue description
When a custom cursor is used in a project and the project is run in fullscreen (no matter if it started in fullscreen or started as windowed and was then switched to fullscreen by the user), the cursor will revert to the system cursor when it is within the window. However, it will appear in a very small area right above and below the game area, where there are black bars since the screen doesn't have the same dimensions as the default scene. When the custom cursor image is changed to another resource with code, the cursor will properly appear again, only to disappear again when it is moved beyond the game area. This bug only appears in fullscreen and is not reproducible on Windows.

Windowed
Fullscreen

https://user-images.githubusercontent.com/64259275/231850009-ef643f31-caa4-4e35-8738-e5ae42e30338.mov
https://user-images.githubusercontent.com/64259275/231850133-7b4ada15-f480-48d0-aceb-05dafd8fa6ab.mov

Steps to reproduce

On a (Apple silicon?) macOS device, open a new project and create a new scene
Set display/mouse_cursor/custom_image in the project settings to another image. Alternatively this can also be done via code with Input.set_custom_mouse_cursor().
Set display/window/size/mode to fullscreen or exclusive fullscreen.
Run the current scene
Move the mouse from outside the game area into the game area (as displayed in the videos in the issue description)

Minimal reproduction project
Minimal reproduction project

Yeah this issue still occurs


potential test issues

motivated by the failure of recent dastard to work with autotune, I looked at the tests here to see if I could identify any red flags. I believe we're currently using the pebbe zmq, so I focused on that test.
This sets the sender high water mark to 1.1 million, when you will send exactly 1 million packets only. That differs from real usage in that we can never have the hwm be above our total number of packets.
https://github.com/joefowler/golang-zmq-comparison/blob/f5f61c55e1c6fa473efcc0323ca49bfd975714d3/pebbe_test.go#L68
Here we see the payload is always "Rhubarb", much smaller than the typical tdm payload for autotune of 10k samples
https://github.com/joefowler/golang-zmq-comparison/blob/f5f61c55e1c6fa473efcc0323ca49bfd975714d3/pebbe_test.go#L87
Further, you start from a synchronized point... eg no messages in the queue, get all subscribers connected, then send all messages. In real usage we start with the publisher having already sent enough messages to fill the hwm many times.
Finally, the sender and reciever are using the same package, I suspect the packages is mostly tested against itself. Perhaps there is variation in behavior from package to package that causes issues?
I don't have any proposed actions currently, just wanted to document some differences.

These are fair points. Do you propose that we design more realistic tests and try them?
That's reasonable, but I am not sure we can realistically choose any of the other 3 packages. The one we used to use seems like to get further and further behind the current and future releases of the underlying czmq library. And the other two are nowhere near complete enough or fast enough to suit our high-performance needs.

Incidentally, my handwritten notes from Sept 20, 2022 show that I never observed a single message when using the current pebbe/zmq4 package in these tests. By contrast, the package zeromq/goczmq (our previous choice) dropped 1%-4% of all packets. (I said to you on Slack that they both dropped a small fraction of packets, but in fact I see that the new library didn't actually drop any at all.)
Okay, I admit there are weaknesses in the tests, as this issue raises. But I still stand by our choice of the pebbe module.

I could imagine repeating all these tests with a receiver written in python and a payload closer to what is used for autotune, but I'm not super enthusiastic about doing so. Maybe a better approach would be to test against dastard and write a "packet drop detector" in various zmq receiving languages, and see if we can find a config where we observe no packet drops over some period of time from the way dastard actually sends packets. Maybe that could guide a re-write of the autotune acquisition code that gets all packets. It's so hard to figure out where a problem is with zmq.
It was clear at the EBIT that we would benefit from being on a modern version of dastard, eg the ability to turn off triggering on a channel would have been useful.


Migrate article: Static IP addresses

Migrate the content from this article to fit the documentation portal format https://help.aiven.io/en/articles/5538233
(Assign this issue to yourself before you start, and remember to mention the issue number when you open your pull request)

https://developer.aiven.io/docs/platform/concepts/static-ips.html
https://developer.aiven.io/docs/platform/howto/static-ip-addresses.html
Solved already.


change the path 'https://huggingface.co/models'

How do I change the path 'https://huggingface.co/models' to:' https://huggingface.co '？

Thank you for your interest in our work.
Are you having problems downloading the model from huggingface? I can upload the required pre-trained model to the cloud storage

Thanks for your reply, I have downloaded the model and solved the problem; In addition, can models trained in their own domain produce multi-class images like coco? (Forgive me if my question is silly, but I'm an expert at this.)

That's a good question. We trained a model from scratch on the bdd dataset, the model can control the generated images with multiple classes like the coco dataset.
However, we found for multiple classes, additionally encoding the classes using the clip text encoding can achieve better control. To make the CLIP text encoder compatible with our domain encoder, it requires some modifications to attention.py.

Thanks for your reply, so what can i do concretely to generate images with multiple of our domain?

Well, it's a little bit complicated. Specifically, you first need to train ldm normally. After training, modify the cldm config file to define the CLIP text encoder as an additional conditional encoder.
Then modify ldm/models/diffusion/ddpm.py accordingly to handle the additional input. Finally, add an attention layer after self.attn2 of CrossAttention in ldm/modules/attention.py to integrate the class conditioninto the diffusion model through this attention layer.
In addition, you also need to refer to utils/coco_dataset.py to modify utils/wheat_dataset.py to read the classes correctly.

Ok, I will try to do this as much as possible. In addition, why do I get an error after running train_wheate.py: "FileNotFoundError: [Errno 2] No such file or directory: 'models/control-wheat-ldm.ckpt'", the resume_path should not affect the running of the program.
Thanks again for taking the time to answer me!

If you are training VAE or LDM, set resume_path = None. If you are training CLDM, resume_path is required.

Thank you for your patience to explain, can it be multi-card training, if I can do what I should do.

yes, you just need to modify trainer = pl.Trainer() in train_wheat.py
For example, if you wanna use 4 gpus, you can set like this:
trainer = pl.Trainer(accelerator='ddp', gpus=4, precision=32, callbacks=[logger, checkpoint_callback], accumulate_grad_batches=accumulate_grad_batches, max_steps=max_steps)

Well, it's a little bit complicated. Specifically, you first need to train ldm normally. After training, modify the cldm config file to define the CLIP text encoder as an additional conditional encoder. Then modify ldm/models/diffusion/ddpm.py accordingly to handle the additional input. Finally, add an attention layer after self.attn2 of CrossAttention in ldm/modules/attention.py to integrate the class conditioninto the diffusion model through this attention layer. You also need to put the parameters of the new attention layer into the optimizer of cldm/cldm.py In addition, you also need to refer to utils/coco_dataset.py to modify utils/wheat_dataset.py to read the classes correctly.

ok. Thank you. In addition, can you tell me more details on this issue? I want to try to generate multi-category pictures in agriculture in the future.

The content above describes the specific files and specific places that need modifications. It's difficult for me to further describe the specific codes using only words. After understanding the structure of the ldm repository, it should be relatively easy to make modifications based on the above content.
This repository is the simple implementation of our arxiv-version paper, which may change a lot after peer review. So currently I don't have plan to clean up and refine the code for public until the paper is finalised.

Ok, thank you, your reply has been very helpful to me! Thanks again for your patience.


deps: update babel-preset-lux to version 2.0.0

Current coverage is 90.02% (diff: 100%)

No coverage report found for master at ac08ca4.

Powered by Codecov. Last update ac08ca4...3f70ef0


ci: exclude pip-compile'd files from renovate

Fixes #46
Proof of Concept: https://github.com/JonasPammer/cookiecutter-pypackage/pull/116

worked!


Don't load images that's display: none;

Hi, thanks for an great plugin.
Im having two divs that I use data-bgset on, and on mobile I only show one of them. However both of the images loads when I only have one of them to display: block; in css. The other one is display: none;

This is strange. Because that is the normal behavior. Can you create a testcase?

My bad, I had another image tag under. We can close this


Try deleting machine pool user data file from S3 when pruning an old launch template version, add S3 storage tests

Towards https://github.com/giantswarm/roadmap/issues/3442 and https://github.com/giantswarm/giantswarm/issues/31105
This is hopefully the last PR in the S3 series 😆 (first one was https://github.com/giantswarm/cluster-api-provider-aws/pull/592). I've added tests which will make it easier to upstream all this. And the controller now keeps only the S3 objects for launch template versions that still exist (typically 2-3 versions since the others are pruned on reconciliation).

Oops, the tests still conflict with each other because multiple tests run on the same envtest instance + namespace. I'll fix that, but you can already start reviewing.


Spread Sheet Abstraction in TensorBoard

Spreadsheet abstraction is more convenient and familiar. Is it possible to add flow based Spreadsheet like modelling capabilities:

http://www.ankhor.com/
https://www.dadisp.com/
http://matrex.sourceforge.net/
https://www.quantrix.com/en/

Here the inputs and outputs on each node in the Dataflow Graph are abstracted as cells to which you can link and perform computations which forms a sub graph but which is rendered as a spreadsheet.

Also make TensorBoard an embeddable UI editor which you can use in parts of other Web UIs.

Do you think at something related to FBP?

It has some resemblance. In CS there is hardly anything new but just old wine in new bottles.
Some other similar projects:

http://noflojs.org/
http://www.pothosware.com/
http://orcc.sourceforge.net/
etc.

But in this case I am looking for something in the like of Flow Sheets (http://www.ankhor.com/).

Noflo was analyzed by the same author at http://www.jpaulmorrison.com/fbp/noflo.html

OK

This is out of scope for tensorboard, which is a visualization platform rather than a graph generation platform.  A separate project building on tensorflow might be interesting, though!


Fixed typo in README : aws-secrets-manager-agent to aws_secretsmanager_agent

Description of changes:
The binary file that's generated under target folder after cargo build --release is wrong mentioned as aws-secrets-manager-agent in the README file. I was able verify that it should actually be aws_secretsmanager_agent.
Verification
➜  aws-secretsmanager-agent git:(main) ls target/release/
aws_secretsmanager_agent    build  examples     libaws_secretsmanager_caching.d
aws_secretsmanager_agent.d  deps   incremental  libaws_secretsmanager_caching.rlib

➜  aws-secretsmanager-agent git:(main) ls target/x86_64-unknown-linux-gnu/release/
aws_secretsmanager_agent    build  examples     libaws_secretsmanager_caching.d
aws_secretsmanager_agent.d  deps   incremental  libaws_secretsmanager_caching.rlib

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.57%. Comparing base (d753a25) to head (b0818f0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   70.59%   70.57%   -0.03%
==========================================
  Files          15       15
  Lines        2850     2848       -2
  Branches        9        9
==========================================
- Hits         2012     2010       -2
  Misses        838      838

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add support to MSSQL

I hope this can be useful to the project.
Let me know if I need to fix anything!

Can you add some workflows

I'm sorry I don't know what else I have to do... it's my first time with workflows and I don't really know what I'm doing.
In addition to this, the mssql docker image is one of the most difficult since it does not have the possibility to create a database at boot time like all the others except with an additional procedure.


fix currency selector going behind "preorder" banner

thanks for this lovely extension, here's a small fix for the currency selector having a weird interaction with the banner elements (for preorders)

Wow, thanks so much! I'll merge now, but will have to bump version to get released to web stores


sys/linux: add descriptions to test bpf_lsm module

Add a new pseudo-syscall syz_btf_id_by_name to translate a hook name into btf_id.
Add syz_btf_id_by_name to supported syscalls list.
Add descriptions to load and attach bpf programs onto lsm hooks.
Add descriptions to construct a simple test bpf program.

Most of the relevant APIs are in /include/uapi/linux/bpf.c (git, bootlin) and /include/uapi/linux/btf.c (git, bootlin).
Some context:

BPF programs are programs in a special byte-code format that can be accept by Linux kernel and run on various hook.
The user can use bpf(BPF_PROG_LOAD, ...) to load a bpf program and bpf(BPF_RAW_TRACEPOINT_OPEN, ...) to attach the program onto a lsm hook.
The attaching lsm look is determine by attach_btf_id, and one is able to translate a hook name into ID by looking up in /sys/kernel/btf/vmlinux.
The format of sys/kernel/btf/vmlinux is documented in /include/uapi/linux/btf.c.

Currently syz-env make test failed due to the following error:
--- FAIL: TestGenerate (7.42s)
    --- FAIL: TestGenerate/linux/386 (1.06s)
        csource_test.go:66: seed=1595642834780028916
        --- FAIL: TestGenerate/linux/386/23 (0.25s)

...
                <stdin>: In function 'syz_btf_id_by_name':
                <stdin>:330:8: error: 'BTF_KIND_FUNC_PROTO' undeclared (first use in this function); did you mean 'BTF_KIND_UNION'?
                <stdin>:330:8: note: each undeclared identifier is reported only once for each function it appears in
                <stdin>:331:18: error: invalid application of 'sizeof' to incomplete type 'struct btf_param'
                <stdin>:333:8: error: 'BTF_KIND_VAR' undeclared (first use in this function); did you mean 'BTF_KIND_PTR'?
                <stdin>:334:18: error: invalid application of 'sizeof' to incomplete type 'struct btf_var'
                <stdin>:336:8: error: 'BTF_KIND_DATASEC' undeclared (first use in this function); did you mean 'BTF_KIND_PTR'?
                <stdin>:337:18: error: invalid application of 'sizeof' to incomplete type 'struct btf_var_secinfo'

I suspect the reason is that syz-env is using an older linux version (so only a portion of BTF_* is not found). How should I fix this problem?

Currently syz-env make test failed due to the following error:
--- FAIL: TestGenerate (7.42s)
    --- FAIL: TestGenerate/linux/386 (1.06s)
        csource_test.go:66: seed=1595642834780028916
        --- FAIL: TestGenerate/linux/386/23 (0.25s)

...
                <stdin>: In function 'syz_btf_id_by_name':
                <stdin>:330:8: error: 'BTF_KIND_FUNC_PROTO' undeclared (first use in this function); did you mean 'BTF_KIND_UNION'?
                <stdin>:330:8: note: each undeclared identifier is reported only once for each function it appears in
                <stdin>:331:18: error: invalid application of 'sizeof' to incomplete type 'struct btf_param'
                <stdin>:333:8: error: 'BTF_KIND_VAR' undeclared (first use in this function); did you mean 'BTF_KIND_PTR'?
                <stdin>:334:18: error: invalid application of 'sizeof' to incomplete type 'struct btf_var'
                <stdin>:336:8: error: 'BTF_KIND_DATASEC' undeclared (first use in this function); did you mean 'BTF_KIND_PTR'?
                <stdin>:337:18: error: invalid application of 'sizeof' to incomplete type 'struct btf_var_secinfo'

I suspect the reason is that syz-env is using an older linux version (so only a portion of BTF_* is not found). How should I fix this problem?

https://github.com/google/syzkaller/blob/master/docs/pseudo_syscalls.md
should answer your question (search for "headers for recently added kernel subsystems").

Yes, malloc is not OK and don't use FILE*.
mmap'ing something at a fixed address is minimal disturbance to the kernel behavior. We could mmap the file as well rather than read it in, should also make the code simpler.
I think we could choose some fixed unused address, mmap the file there with MAP_FIXED, if the mmap fails because something is already mapped, assume another syscall has already mapped it, so just use it.

I think we could choose some fixed unused address, mmap the file there with MAP_FIXED, if the mmap fails because something is already mapped, assume another syscall has already mapped it, so just use it.

It seems like it is not possible to mmap the file /sys/kernel/btf/vmlinux (see here). The last time I tried to mmap it, it failed with ENODEV.
Is using mmap with MAP_FIXED | MAP_ANONYMOUS allowed?

I think we could choose some fixed unused address, mmap the file there with MAP_FIXED, if the mmap fails because something is already mapped, assume another syscall has already mapped it, so just use it.

It seems like it is not possible to mmap the file /sys/kernel/btf/vmlinux (see here). The last time I tried to mmap it, it failed with ENODEV.

Yikes!
It's even stored in a continuous region of memory in the kernel already :(

Is using mmap with MAP_FIXED | MAP_ANONYMOUS to dynamically obtain memory allowed?

Let's say, yes. There are no strict rules. We are just trying to disturb execution as less as possible and make things as deterministic as possible.

Is using mmap with MAP_FIXED | MAP_ANONYMOUS to dynamically obtain memory allowed?

Let's say, yes. There are no strict rules. We are just trying to disturb execution as less as possible and make things as deterministic as possible.

Should we be careful to not do a MAP_FIXED over an existing mapping?  Maybe use MAP_FIXED_NOREPLACE instead?

What will be the best way to obtain a fixed address that is portable to different architecture? I am looking at virtual memory mappings on different architecture, but not sure if I am on the right direction.

What will be the best way to obtain a fixed address that is portable to different architecture? I am looking at virtual memory mappings on different architecture, but not sure if I am on the right direction.

Check that it does not overlap with any existing mapping. Works for 32-bits. Not too low, not too high (kernel tends to map something there). I would probably take address close to our data region (mapped in os_init), but not adjacent to it.

Fix the problems above and convert the draft into a normal pull request.
@jedav @morehouse @dvyukov
I will squash the commits once it is approved.

The only problem I am facing is that when I run the test syz-runtest -vv 5 -debug -config config.json -tests btf_id, it shows the following error:
btf_id /thr C                         : FAIL: run 0: wrong call 1 result 22, want 0
        ### start
        ### call=1 errno=22
        ### call=2 errno=9
        ### call=3 errno=9
        ### call=4 errno=9
        ### call=6 errno=22
        ### call=7 errno=9
        ### call=8 errno=9
        ### call=9 errno=9
        ### call=0 errno=0
        ### call=5 errno=0

where the content of btf_id is
r0 = syz_btf_id_by_name(&AUTO='bpf_lsm_path_mkdir\x00')
r1 = bpf$BPF_LSM_PROG_LOAD(0x5, &AUTO=@test0={0x1d, 0x2, &AUTO={{0xb7, 0x0, 0x0, 0x0, 0x0}, {0x95, 0x0, 0x0, 0x0, 0x0}}, &AUTO='GPL\x00', 0x0, 0x0, 0x0, 0x0, 0x0, 'test\x00', 0x0, 0x1b, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, r0, 0x0}, 0x78)
r2 = bpf$BPF_LSM_RAW_TRACEPOINT_OPEN(0x11, &AUTO={0x0, r1}, 0x10)
close(r2)
close(r1)
r3 = syz_btf_id_by_name(&AUTO='bpf_lsm_path_mkdir\x00')
r4 = bpf$BPF_LSM_PROG_LOAD(0x5, &AUTO=@test0={0x1d, 0x2, &AUTO={{0xb7, 0x0, 0x0, 0x0, 0x0}, {0x95, 0x0, 0x0, 0x0, 0x0}}, &AUTO='GPL\x00', 0x0, 0x0, 0x0, 0x0, 0x0, 'test\x00', 0x0, 0x1b, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, r3, 0x0}, 0x78)
r5 = bpf$BPF_LSM_RAW_TRACEPOINT_OPEN(0x11, &AUTO={0x0, r4}, 0x10)
close(r5)
close(r4)

So it seems like call 1 (r1 = bpf$BPF_LSM_PROG_LOAD) is completed before call 0 (r0 = syz_btf_id_by_name). I don't quite understand how this can happen because r0 is used as an argument in call `.

The only problem I am facing is that when I run the test syz-runtest -vv 5 -debug -config config.json -tests btf_id, it shows the following error:
btf_id /thr C                         : FAIL: run 0: wrong call 1 result 22, want 0
        ### start
        ### call=1 errno=22
        ### call=2 errno=9
        ### call=3 errno=9
        ### call=4 errno=9
        ### call=6 errno=22
        ### call=7 errno=9
        ### call=8 errno=9
        ### call=9 errno=9
        ### call=0 errno=0
        ### call=5 errno=0

where the content of btf_id is
r0 = syz_btf_id_by_name(&AUTO='bpf_lsm_path_mkdir\x00')
r1 = bpf$BPF_LSM_PROG_LOAD(0x5, &AUTO=@test0={0x1d, 0x2, &AUTO={{0xb7, 0x0, 0x0, 0x0, 0x0}, {0x95, 0x0, 0x0, 0x0, 0x0}}, &AUTO='GPL\x00', 0x0, 0x0, 0x0, 0x0, 0x0, 'test\x00', 0x0, 0x1b, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, r0, 0x0}, 0x78)
r2 = bpf$BPF_LSM_RAW_TRACEPOINT_OPEN(0x11, &AUTO={0x0, r1}, 0x10)
close(r2)
close(r1)
r3 = syz_btf_id_by_name(&AUTO='bpf_lsm_path_mkdir\x00')
r4 = bpf$BPF_LSM_PROG_LOAD(0x5, &AUTO=@test0={0x1d, 0x2, &AUTO={{0xb7, 0x0, 0x0, 0x0, 0x0}, {0x95, 0x0, 0x0, 0x0, 0x0}}, &AUTO='GPL\x00', 0x0, 0x0, 0x0, 0x0, 0x0, 'test\x00', 0x0, 0x1b, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, r3, 0x0}, 0x78)
r5 = bpf$BPF_LSM_RAW_TRACEPOINT_OPEN(0x11, &AUTO={0x0, r4}, 0x10)
close(r5)
close(r4)

So it seems like call 1 (r1 = bpf$BPF_LSM_PROG_LOAD) is completed before call 0 (r0 = syz_btf_id_by_name). I don't quite understand how this can happen because r0 is used as an argument in call `.

syz_btf_id_by_name is probably too slow.
executor has 45 ms timeout for execution of syscalls:
https://github.com/google/syzkaller/blob/master/executor/executor.cc#L731
If a syscall does not finish within that timeout the next syscalls is kicked off. That's probably what you are seeing.
Check out the timeout syscall attribute:
$ grep "(timeout" sys/linux/*.txt

After increasing the time limit, the problem with syz-runtest is now:
btf_id namespace                      : FAIL: run 0: wrong call 1 result 1, want 0
btf_id namespace/cover                : FAIL: run 0: call 0 is not executed
btf_id namespace C                    : FAIL: run 0: wrong call 1 result 1, want 0

I think I need to change pkg/host/syscalls_linux.go by allowing syz_btf_id_by_name only when onlySandboxNone(). Is this correct?

After increasing the time limit, the problem with syz-runtest is now:
btf_id namespace                      : FAIL: run 0: wrong call 1 result 1, want 0
btf_id namespace/cover                : FAIL: run 0: call 0 is not executed
btf_id namespace C                    : FAIL: run 0: wrong call 1 result 1, want 0

I think I need to change pkg/host/syscalls_linux.go by allowing syz_btf_id_by_name only when onlySandboxNone(). Is this correct?

If it requires CAP_ADMIN, then yes.

I am waiting for #2005 to be merged so I can run make presubmit. I also need to change that part of the file.

#2005 is merged now. Please rebase.

When I run syz-runtest -config config.json -tests btf_id the test failed with:
btf_id none/cover                     : FAIL: run 0: call 3: no cover
btf_id none/repeat/cover              : FAIL: run 1: call 3: no cover
btf_id none/thr/repeat/cover          : FAIL: run 1: call 3: no cover

Call 3 is the second call to the psuedo-syscall syz_btf_id_by_name. It is not getting coverage because syz_btf_id_by_name does not read vmlinux in second and later calls. Thus, it should be normal for this call to not get any coverage. Wonder what I should do here.

Also, is it important to pass all the test in syz-runtest? I ask @necipfazil before and he advised me to use syz-execprog to do the testing instead.
By the way, syz-runtest do not work for now:
2020/08/05 17:59:25 io_uring: unknown comment "Create an io_uring instance"

It seems like there need to be an extra blank line before each syscall, or the parser will assume the comment is the expected errno.
I could submit a quick fix if this should be done.

And also, I can not pass the make presubmit check now because there are a lot of commit messages that does not follow the format:
##[error]Wrong commit subject format: 'Revert "dashboard/config: select KCSAN_VERBOSE in KCSAN config"'. Please use 'main/affected/package: short change description'. See docs/contributing.md for details.
##[error]Wrong commit subject format: 'Revert "dashboard/config: disable PARAVIRT_DEBUG with KCSAN"'. Please use 'main/affected/package: short change description'. See docs/contributing.md for details.
##[error]Wrong commit subject format: 'Revert "executor: enable extra coverage on OpenBSD"'. Please use 'main/affected/package: short change description'. See docs/contributing.md for details.
##[error]Wrong commit subject format: 'dashboard/app: Receive Recipients from API'. Please use 'main/affected/package: short change description'. See docs/contributing.md for details.

Not sure what to do now.

Also, is it important to pass all the test in syz-runtest? I ask @necipfazil before and he advised me to use syz-execprog to do the testing instead.

Yes, syz-runtest should pass.
syz-execprog is handy for initial development b/c you can do iterations faster, while syz-runtest takes some time.
But syz-execprog tests literally nothing, it is happy with any outcome, it also does not test multiple execution modes, sandboxes, C reproducers, etc. While syz-runtest tests all that.
Eventually we will enable syz-runtest on CI, it's just tricky b/c it needs working kernel+vm.
Re syz_btf_id_by_name and "no coverage", I think we should just special-case syz_btf_id_by_name in pkg/runtest for now. It's intentional that it does not get coverage. And since it's first such syscall, I don't think it makes sense to implement something more fundamental right now.

The change itself looks good to me.
Please rebase to HEAD so that CI passes, squash commits and fix pkg/runtest, and we are ready for merge.

I fixed the problem and now it passes CI checks.
Please let me know if there are any problem. Thank you very much.

Perfect!
I am eager to see syzbot reaction :)


Create: Improve API for columns

Python-style field names (ie. field_name instead of fieldName)
Allow implicit values for simple usage (allow ['foo', 'bar'] and assume same alias and data type as text)

I'm going to hold off on this, not sure it's necessary and doesn't add a lot of value


Allow inspecting groupshared memory in D3D11 shader debugging

Description
I don't know whether this is implemented already and I just don't know how to use it or a genuine bug, so it's more of a question-bug.
The first issue is seeing values such as vThreadID or vThreadGroupID in the compute shader debugger. I think other semantics aren't easily visible either (i.e. the instance id) although from context are more easily deducible. Hovering on top of the name or seeing it in Variables (or both) would be very useful.
The other issue is also related to data visibility, and it's seeing groupshared memory as a compute shader runs. I understand that maybe the contents of memory from the full run can't be inspected (as in, it wouldn't show things like race conditions, etc.) but at least the value that the current thread is writing would be quite useful. Perhaps it would appear in the variables window as well like the registers or in the Constants && Resources.
One other question that is related is how to use the Watch window. Is there a way to add anything other than registers? For instance, adding e.g. g0[10] for the groupshared memory to be able to observe how that particular entry evolves?
Environment

RenderDoc build: 1.0
Operating System: Windows 7
API: D3D11

About vThreadID and friends, those weren't omitted for any good reason. I had skipped them since I'd thought of them as constants - e.g. in compute shaders you choose which group and thread to debug. I realise that's not very useful though, so I think the recent revamp to allow HLSL debugging should now display them properly, although I think I might still have a bug or two in that area.
With groupshared memory it's more tricky. To clarify; the compute debugging in RenderDoc is currently limited to running a single thread at once, so groupshared memory is simulated internally but it's kind of trivial because there aren't any reads/writes from other threads. In most cases that means debugging shaders that use groupshared will rapidly turn into nonsense. You can use the 'run to load/sample/gather' button which will also pick up loads from groupshared, but it'll only have the correct value if no other thread was expected to write to it.
Displaying the contents in the UI is the challenge. The debugging works by running the full simulation and snapshotting the state at each step. That's not too bad if you're only talking about a dozen or so registers, but if you include up to 32kb of groupshared then it gets exponentially worse.
Changing to a more iterative approach where simulation only happens as needed would solve that, but then you have issues with performance when running over again repeating work. If you cache to solve that, you start going back into the same problem. It also becomes harder to support stepping backwards which I think is a very useful feature especially for shaders.
I think probably the best solution is to instead store each step as a delta (either a two-way delta or with regular snapshots to allow rewind) since each individual step doesn't change much. That's going to need a very different representation though. Since I'm hoping to look at Vulkan shader debugging later in the year, I'll need to refactor a lot of this code anyway to support both and it would make sense to re-examine this at that time. For the moment though I think groupshared is probably going to remain opaque.

I see you've addressed the thread id/group quite quickly so thanks for that!
Regarding the groupshared thanks for the explanation, I can better understand now how it can be quite tricky to implement for the entire shader run in the current implementation. Hopefully when you get to getting Vulkan debugging done it can be piggybacked on that task.

Oh groupshared, how I long for thee.
The doctor of rendering I beseech.

Even being able to edit registers and the groupshared memory manually to simulate some shader state would be extremely useful tbh, irregardless of more complex solutions.

Editing registers and groupshared memory would be much more work on top of everything mentioned above and opens a lot of other UI pains: if you step forward, edit a value, then step back past where you edited and run again - does it use the edited value or the actual value? It's a sort of microcosm of the kind of semantic difficulties for state editing.
You can hack in groupshared contents if you know what they should be. In D3D11DebugManager::CreateShaderGlobalState each groupshared declaration creates a memory buffer that's initially empty:
https://github.com/baldurk/renderdoc/blob/c9c51b5a3eb16c8fe07234fe7feedc58b6153bc1/renderdoc/driver/d3d11/d3d11_shaderdebug.cpp#L600-L615
You could fill that with data at the start if you know what it should be for other threads maybe. Or else you can poke into it in the main loop of D3D11Replay::DebugThread if you know which step or instruction you want to have the results appear:
https://github.com/baldurk/renderdoc/blob/c9c51b5a3eb16c8fe07234fe7feedc58b6153bc1/renderdoc/driver/d3d11/d3d11_shaderdebug.cpp#L2354-L2374

Oh, that is pretty sweet!
With editing I meant directly modifying the one and only state of the shader simulator, so I wouldn't expect the shader to behave as expected if I started rewinding it etc. This could easily be indicated by marking the shader state as dirty as soon as you elect to edit, disabling the backwards button for example. It would be super powerful and simple way to do more creative debugging, especially with groupshared stuff.
I will most definitely look into D3D11DebugManager::CreateShaderGlobalState though, thanks for the tip!!

With groupshared memory it's more tricky. To clarify; the compute debugging in RenderDoc is currently limited to running a single thread at once

Does the same apply to pixel shaders?
Thinking of derivative instructions, visualizing the value of a variable across invocations etc.


Roadmap: Terminology Improvements

I think one of the great improvements that DSPy has made was going from the term "Teleprompter" to "Optimizer."
That change made what DSPy was doing much clearer.  That terminology change made DSPy more accessible to developers coming from different programming traditions and languages.
In that spirit, let's take a hard look at changing some other terms in DSPy.
To get the conversation started let's talk about clean, self-explanatory, easy new names for:
(The not clear at all set, for sure we can do better)
COPRO
MIPRO
forward
predict
OPTUNA
(The maybe unclear set, maybe we can do better)
signature
ReAct

Personally, I love inside jokes, puns, and clever names.  And it will pains me to see some of that going away.  For a broader audience, we must get boring.
This is what ChatGPT suggests...

MIPRO (Focused on Minibatch and Prompt Optimization)
BatchPromptOptimizer
PromptBatcher
MiniBatchPrompter
IterativePromptTuner
BatchwisePromptGen
PromptCycleOptimizer
PromptMinibatcher
BatchTunedPrompter
PromptSeriesOptimizer
StepwisePromptGen
COPRO (Generalized Comprehensive Prompt Optimization)
ComprehensivePromptOptimizer
PromptSynthesisEngine
HolisticPromptRefiner
CompletePromptTuner
FullCyclePrompter
IntegratedPromptOptimizer
SignaturePromptCompiler
PromptFullOptimizer
BroadPromptSynthesis
UnifiedPromptOptimizer

I don't like any of those.  We might have to use human brains.


Regression because of new format for sources

The web editor does not work anymore, because we changed the JSON format for sources. @StareInTheAir, could you please take a look at this?

Fixed with b6940df4fcc6baa09d79d6d473efd9452cdee6b9.


Add documentation on how to add new APIs

The README has a small mention at the bottom about generating Rust code from botocore, but if all the Rust code is generated, it's not clear why this hasn't been done for all the APIs defined in botocore. What's the intended process for getting the APIs for other AWS services into Rusoto through codegen?

Great question!
Short version: there are about four different styles of AWS API interaction and the current botocore parser handles one.  https://github.com/DualSpark/rusoto/pull/90 is where I'm attempting to get it working for the S3 API style.
Once the Python code generation is up to snuff it should be easy to knock out the rest, and it's just waiting for someone to drag it across the finish line.

I'm interested in helping if there is any part of it that can be broken off and handled simultaneously. I'm working on a CLI written in Rust that needs to use the Key Management Service API and figured rather than throwing together something in Hyper inside my own program, I should be helping add those APIs to rusoto.

Would a walkthrough of how the SQS code was generated and put into the project help?

Yeah, that'd be great.

Are the (currently two) generated Rust files in the codegen directory intended to replace the ones in the src directory once codegen for everything is working? I can't tell if the stuff in the codegen directory is a work in progress or if it's actually used in the crate somehow now.

Can you give that pull request a look over?  I'm hoping https://github.com/DualSpark/rusoto/blob/feature-codegen-walkthrough/codegen/CODEGEN.md answers your questions.  If not please let me know.

@adimarco is progressing on the Dynamo service, I'm hoping to get him to review this as well.

Didn't get to that PR in time, but a couple things I'd add:

Where does the JSON file with the service definition come from in the first place? Are they being copied directly out of the botocore repository? How do the JSON files in the codegen directory of this repository stay in sync with the definitions in botocore?
What are the "different types of API styles" alluded to? It'd be useful to either enumerate them or to explain how you can tell which "style" is used for a particular service definition. Does this just refer to the value of the top-level "version" key in the service definitions in botocore's repository? Which styles are currently supported?

I wasn't clear on just wanting a review of that PR from Anthony.  We're still working towards improving the documentation.

JSON definitions come from the botocore repo, under the botocore/data directory.  For now each service has its definition file copied over by hand and then follows the documentation created in PR #108 .

I'm actually not 100% clear on this myself: most of the info is from talking to AWS employees at their Birds of a Feather for SDKs at reInvent.  I was highly encouraged to generate code from the above API definitions and was told there are four different styles.  As an example of different styles, the SQS interaction requires XML based payloads and responses whereas S3 uses request and response headers for most interaction.

Right now the XML based interactions are the ones that work with our codegen tooling.  Adding more services has been slow for me because my Python-fu is weak and the most useful services are usually the most complex (eg: S3).
I'll be sure to add the answers to your questions to the documentation that was started in the above PR.
Thanks for sticking with us on this.  I want to reduce friction for others contributing to our project so more people can find it useful.

Thanks for the clarification! It might be a good idea to add botocore as a Git submodule and using the service definitions from the repository directly. That way you can keep track of exactly which versions of the service files were used to generate the corresponding Rust code. Manually copying the files into this repository's codegen directory doesn't seem like an approach that will be maintainable long term.
As far as I understand, the service definitions are the only part of botocore that's needed by this project, so maybe the Python-based botocore parser can be converted to one written in Rust. I might be way off base on that — I'm only marginally familiar with botocore's constructs after looking through it for a few minutes.

I'll look into git submodules, haven't had the need for those before.
When Anthony and I last looked into Rust based code generation, it wasn't yet up to snuff.  Perhaps it's been improved since we last checked.

@jimmycuadra after https://github.com/DualSpark/rusoto/pull/113 is there still work to be done on this?

No, I have enough information to continue from here. Thanks for being so responsive on this!

For reference, I think the "API styles" are denoted for each service in metadata.protocol. The current styles are:

json
query
rest-json
rest-xml

S3 uses "query" and SQS uses "rest-xml."

Oooooh good catch.  Thanks :)

Oh my, I feel very silly for missing that.  Thanks for the info!


Don't shrink the payload_ buffer

In the handle remaining length function, the size of the payload_ vector is changed on every incoming packet.
            payload_.resize(remaining_length_);
            if (remaining_length_ == 0) {
                handle_payload(func);
                return;
            }

Allocating new space like this is expensive.
Instead, we should only change the size of the buffer if more room is needed.
E.g.
if(payload_.size() < remaining_length_){ payload_.resize(remaining_length_);
Then, anywhere payload_ is used, we also use remaining_length_ to indicate how many bytes in payload_ are actually part of the current packet.
This way, we don't allocate memory for every packet. We only allocate memory when the newly received packet is larger than the buffer.

I don't think so.
See http://www.cplusplus.com/reference/vector/vector/resize/

Iterator validity
In case the container shrinks, all iterators, pointers and references to elements that have not been removed remain valid after the resize and refer to the same elements they were referring to before the call.
If the container expands, the end iterator is invalidated and, if it has to reallocate storage, all iterators, pointers and references related to this container are also invalidated.

That means memory reallocation doesn't happen at the shrink case.
I wrote checking code.
https://wandbox.org/permlink/Z9UGkb2H9wEEemps

Ah, you're right. It's already doing the behavior that I described.
We should document that this is what's happening in the code.


Make mill-build folder opt in via import $mill.build

Fixes https://github.com/com-lihaoyi/mill/issues/2461
For now it remains hard-coded as mill-build/, for simplicity. Given the mill- prefix, it's unlikely to collide with user-defined folders. Making it configurable would open another can of worms where the import $mill.foo can now collide with an object foo, which is very unintuitive.
For now, we just parse the script files one additional time in MillBuildBootstrap.scala. This is a bit wasteful, but is probably fast enough for now, and we're already pretty sloppy parsing everything twice in MillBuildRootModule#scriptSources and MillBuildRootModule#parseBuildFiles, so parsing things three times isn't the end of the world. We can look into optimizing it in future if necessary

Seems the integration tests need to be tweaked abit since we're no longer unconditionally going through all levels of meta-builds.