RFC: Option to use fixed test database name

Problem

Tests are slow. Part of the problem is that a non-trivial database needs to be created at the beginning of a test run.
Sometimes, bugs in tests will leave tmpdb running around.

Recommendation

If the SS_TEST_DATABASE_NAME env var / define is set, then:
This database name is used in place of the auto-generated tmpdb name
This database is truncated, rather than deleted, at the end of the test execution
Similar behaviour is available via SS_CHOOSE_TEST_DATABASE_NAME (The database name becomes "tmpdb_" . $folderName)
We apply this to both 3 and 4

Anyone using this setting would need to take steps to avoid running multiple test runs on the database concurrently. This is a rare situation, so I think that's okay.

This sounds like a reasonable idea for sure. I'd like to see some properly mocked unit tests being written/migrated to in the near future though, with the intention of moving fixtured SapphireTests that can't be fully mocked into an "integration test" suite (because that's what they really are). The higher level problem is that our unit tests aren't really unit tests, but I'm totally on board with speeding them up if possible in the meantime

I'd like to see some properly mocked unit tests being written/migrated to in the near future though, with the intention of moving fixtured SapphireTests that can't be fully mocked into an "integration test" suite.

I can't see how this would be feasible without dropping the Active Record pattern in favour of something like a Data Mapper / Content Repository pattern. I can't see this magnitude of change being solely justified by test speed, and so we'd need to what major benefits this would provide and how it fits into our long-term plans.

https://github.com/silverstripe/silverstripe-framework/issues/7902 would help - we could then keep fixtures the way they are but remove DB dependencies (in theory)


[Bug] Season 2/Level 5 - Minor Omissions in the Hint and Solution

Summary
There are two minor problems as explained in the next section.
How to reproduce
In the hint-1.txtthere are two examples given as follows:
Example 1:
$ var s = { toString: function() { alert('Exploit 1'); } };
$ CryptoAPI.sha1.hash(s)

Example 2:
$ var s = { toString: function() { alert('Exploit 1'); } };
$ CryptoAPI.sha1.hash("abc")

Nonetheless, the second example doesn't demonstrate anything and should be removed.
In solution.js the line 62 should be changed from:
if ((i & 63) == 63) CryptoAPI.sha1._round(H, w);

to:
if ((i & 63) == 63) internalRound(H, w);

This is explained in the text of the solution, but the code base is not synced with that description.

Fixed, thank you!


add logo and align to mockup

Views where the logo was set:
Project list view

Edit project view

Project results view

Looks good, @AndreeaDora!


Handle available section transitions

Ignore fade transitions between non full height sections.

Disable fade transitions in edit form if adjacent sections are not
full height.

REDMINE-17338

Coverage remained the same at 99.208% when pulling 144437f9445c801c4ebcaa5623668975751272a0 on tf:edit-transtions into 6329cf329b7ea3b32e739ec4c59629dd5ba9e92b on codevise:master.


Add ability to configure GOEXPERIMENT for builds

It'd be great to be able to set things like loopvar in the future using this!

(adding self approval given the LGTM)


NXP mw320 first commit to matter test_event_6.lts

Problem
NXP MW320 wifi support for matter test_event_6.lts branch
Change overview
All MW320 matter sources
Testing
Using test event 6 chip tool to do the follow command:
Bypass pairing
./chip-tool pairing bypass "IPv6 address" 5540
Read MW320 led status
./chip-tool onoff read on-off 1
Turn on MW320 led
./chip-tool onoff on 1
Turn off MW320 led
./chip-tool onoff off 1

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Jason Lan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@JasonLan0223  - please run the restyler: copy from #15130 or run ./scripts/helpers/restyle-diff.sh or run something like (while adjusting for the right docker socket path):
docker run --interactive --rm                                   \
   --env HOST_DIRECTORY="$PWD"                                  \
   --env UNRESTRICTED=1                                         \
   --volume "$PWD":/code                                        \
   --volume /tmp:/tmp                                           \
   --volume "$XDG_RUNTIME_DIR/docker.sock":/var/run/docker.sock \
   --entrypoint restyle-path                                    \
   docker.io/restyled/restyler:edge                             \
   $(git diff --ignore-submodules --name-only "master" | tr "\n" " ")

Also please adjust the summary - right now it contains just the template and it is wrong.

@andy31415  Thank you for your suggestion. We have run restyle-diff.sh and push some files modification. Is it still problem for "Restyled by gn"? Do you have any suggestion for it? Thank you for your help again.

We close it and using PR14826


Remove migration FF check for public pages

With the migration done™, we should incrementally remove the FF check from certain places, and just leave the regular condition.

Acceptance 🔶

✅  Public pages are shown correctly
🔴  From the public table view, the CREATE MAP button throws an error

To reproduce the issue:

Login as user A and go to the public profile of a user B
Click on the datasets tab
Click on a dataset
You'll end up on a page like this -> https://{username}.carto-staging.com/tables/{datasetname}/public
Click on CREATE MAP
The error below is shown:

I'm unsure this is related to the dashboard migration... if it's unrelated, please create an issue to solve this specific case.
Thanks!

Can't really reproduce this behaviour on staging, since the create map button takes you to carto.com. This hasn't been changed on the migration.


AttributeError: 'ShaderNodeTree' object has no attribute 'outputs'

Describe the bug
When trying to export the poly haven Hidden Alley scene from blender 4.2 I get the error:
File "C:\Program Files\Blender Foundation\Blender 4.2\4.2\scripts\addons_core\io_scene_gltf2\blender\exp\material\gltf2_blender_search_node_tree.py", line 904, in check_if_is_linked_to_active_output
    sockets = group_path[-1].outputs
              ^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'ShaderNodeTree' object has no attribute 'outputs'

To Reproduce
Steps to reproduce the behavior

Download the blend file from https://blog.polyhaven.com/hidden-alley/
Export as gltf
See error in console

Expected behavior
For the exporter to not crash.
.blend file
https://dl.polyhaven.org/file/ph-assets/Scenes/hidden_alley.zip
Version

OS: Windows 10
Blender Version 4.2

Confirmed.
Node tree Mesh with issue : Floor_main

Here is in attachment the minimal file that show the issue (well, the original file was 1.4 Go .... !)
Looks like maybe an issue in Blender file itself, as if you enter node group, remove the BSDF/BSDF link, and add it again : No more crash...
minimal_bug_shader.blend.zip
Investigation in progress

Investigation progress:
We have an issue on our code, when a socket is linked to 2 output socket of an output group
Unplug/plug again solve the issue because it changes the link order of the socket, and now the "correct" socket goes first, before the second one


Sprint 2 unit tests

Added unit tests to increase code coverage.
Wrote getter and setter unit tests for:

account_manager.dart
login_manager.dart
note_content.dart

Codecov Report
Patch coverage: 100.00% and project coverage change: +11.13 :tada:

Comparison is base (7e184d1) 8.90% compared to head (8a15351) 20.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##            main      #25       +/-   ##
==========================================
+ Coverage   8.90%   20.04%   +11.13%
==========================================
  Files         11       11
  Lines        483      484        +1
==========================================
+ Hits          43       97       +54
+ Misses       440      387       -53

Impacted Files
Coverage Δ

lib/screens/authentication/login_manager.dart
57.89% <100.00%> (+57.89%)
:arrow_up:

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Force Merged because of time constraints


Framer Theme component not working as expected to style components in Preview

[X] The issue is present in the latest release.
[X] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
In Framer, when using the Material-UI package,  a user can connect the Theme component to Frames in order to change global styles (primary, secondary, etc). If the user adjusts the default them, connects to a frame with material-ui components, we can see the styles get applied. However, when viewing the prototype Preview, the styles shown are the default styles.
Video of issue: https://www.loom.com/share/fc68dbd7f6ab413ba9f05c265046329e
Expected Behavior 🤔
The components in the Preview window should also get the Theme set styles applied to those components.
Steps to Reproduce 🕹
Steps:

Open a new Framer Project
Install the Material-UI package
Create a frame and add some Material-UI components (ex. Button)
Add the Material-UI "Theme" component
Adjust the theme styles (ex. Change Primary and Secondary colors)
Connect the Theme component to the Frame
We'll now see the Frame components use the newly set Theme styles
Press the PLAY button to preview the prototype
The Prototype will still be using the default theme styles instead of the newly set ones.

Framer example: https://framer.com/share/ciYO2UzaBpAbuQmkHjp5
Context 🔦
Attempting to create a Framer prototype using Material-UI components that are themed. This prevents the prototypes from sharing project styles and affects the end result when demoing for stakeholders as it can appear raw or unfinished. Also, it's difficult to communicate specific styles to developers when the theme settings don't get applied to all components.
Your Environment 🌎
Mac/Chrome. Using web version of Framer.

It looks like you might previewing the content frame? You'll need to preview theme frame, otherwise the theme doesn't get applied. I think previewing below the below the theme might have worked in an earlier (not 100% sure...)

Closing since no reproduction was provided.


[labs/eleventy-plugin-lit] Support passing data as properties

This is possibly better suited to its own issue, but: what about giving the components access to the 11ty data cascade? Is that already supported, or else would you consider it covered by this feature?

Since posting this, I have managed to pipe 11ty data into a Lit component such that the plugin can render a static template.

@cdata got code you can show us? cc @zeroedin

@bennypowers for passing 11ty data into components? I followed the recommenation the docs. At template render time, I serialized data to JSON and set it as an attribute value, for example with Nunjucks:
<my-component prop="{{data.foobar | dump}}"></my-component>

It's more of a pattern than an implementation. And, it comes with a caveat that every component that uses it has a gigantic JSON value in its attributes. This balloons the size of the generated output really quickly unless you are careful about what data you pass into components.
I should be clear and say that my original thought ("what about giving the components access to the 11ty data cascade") is not the same as what I'm describing here. If components had access to the data cascade, it would be like there is a singleton model in global scope that every component could read from at any time (whether configured as properties / attributes or not). It's unhygienic / yucky but it's coherent with all the other template strategies under 11ty.

@cdata do I understand you correctly: that if an existing component takes scalar attributes, that you can of them directly, but if serializable objects are passed to components that otherwise do not accept them, a wrapper component is required?
In other words, there is currently no way to pass "dot-syntax" properties to components that don't internally implement some special json-parsing logic, or some equivalent?

@bennypowers I don't know if I understand your question correctly. But, you can certainly modify the data in your template language before passing it in so that it is formatted the way the component expects. I do this to some extent and do not need any wrappers just to pass data as expected.
The constraint is that the data must be serialized to JSON and passed as an attribute value. Most Lit components can handle this, but not all web components (but then, I don't think the static rendering even works for vanilla WCs).
A lot of the data I'm working with is lists of non-trivial models - anyone using 11ty collections is probably in a similar boat - and this is results in a lot of large attribute values, even if you format the data to look the way you want it to.


Add intersphinx for docs linking.

NOTE: Has #1035 as base.

@tseaver Rebased

I still don't see a point to the pythonlocal mapping:  no Python programmer is going to need to look any of those values up.

It's nice to add the links. Somehow it feels inconsistent to link to some objects and not to others.
I'm not sure who it hurts.

@tseaver It turns out I just wasn't using the right refs (e.g. using :class: when I needed to be used :data:). There is no need for the pythonlocal rule. I rebased and got rid of it and also added an intersphinx rule for httplib2 (I found it yesterday).

Great!  LGTM


Add a helm chart

Add a helm chart for vault-operator just like https://github.com/coreos/prometheus-operator/tree/master/helm/prometheus-operator. The prometheus one was of great help.

https://github.com/kubernetes/charts/pull/5574


dataFrom key rewrite

relates to: #915
when using dataFrom users may want to rewrite the key so that it is easier for them to consume the secrets.
We have three cases to consider:

dataFrom.extract
dataFrom.find with name/regexp
dataFrom.find with tags

As outlined in the above mentioned issue: it would be quite convenient to have regexp capture groups. However, we still need to address the other two use cases.
Out of scope:

we also need a way to template keys in target.template.data[$key]

Throwing ideas here:
One possible way is to have a map in the form of:
spec:
  dataFrom:
    convert:
      -  origin: my-known-data-from-key
         target: my-new-data-from-key
      ...

Examples:
spec:
  dataFrom:
    convert:
      -  origin: ^dev-(.*)-(.*)$
         target: $1-new-rewrite-$2
      ...

behavior would be: before applying conversionStrategy, apply conversion marked in convert (this could be used as inputs for the template operation if we apply it before here

Just FYI I put some more details on workarounds and a suggested solution in #1067.

I would really appreciate it if this feature is worked upon soonish.
It will help in seamless migration from deprecated external-kubernetes-secrets to the new one.

I came here from issue #915. I would also like to see this. It is currently stopping migration from the old external-kubernetes-secrets.


Implement MS.AAD.6.1v1 check user password expiration

🗣 Description

Import AAD settings from Get-MgBetaDomain in ExportAADProvider.psm1,
Write unit tests to indicate correct and incorrect values in AADConfig_06_test.rego, write functional tests in aad.testplan.yaml
Implement MS.AAD.6.1v1 policy in AADconfig.rego.

💭 Motivation and context

MS.AAD.6.1v1 was marked as not implementable, but it can now be checked with Get-MgDomain.
This resolves #398
🧪 Testing

From the Testing directory, run .\RunUnitTests.ps1 -p aad -c 6
To run functional tests, setup $TestContainers array, setup $PesterConfig to filter based on MS.AAD.6.1v1 tag, then run the following:
$Config = New-PesterConfiguration -Hashtable $PesterConfig
Invoke-Pester -Configuration $Config
Run the tool against commercial, gcc, and gcchigh environments

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All future TODOs are captured in issues, which are referenced
in code comments.
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[x] Tests have been added and/or modified to cover the changes in this PR.
[x] All new and existing tests pass.

Updates include new rego unit tests and test run on G5 test tenant worked as expected.
Do not see any functional test to exercise this option. Is it possible to create and add one so it is included in automated functional testing as well?
See other suggested changes below.

Functional test harness updated for MS.AAD.6.1v1


Docs review

Here are some preliminary edits.  I jumped ahead and started going through the programming section.  I tested everything and played around with the examples significantly and tried to break stuff.
I think its worth going through my edits when you have time, feel free to merge etc or even take over the PR and edit on top (just let me know if you do that so I don't have conflicts!)

argghh didn't mean to checkin those other files

I had to stop short when I got to this section:
The side-by-side view of both embedded and separate both look the same here, so not sure what you were trying to show:

Thanks for this -- looking through now!
For the last screenshot, the members are different:

It's a lot to have to diff in a side-by-side, so maybe just showing e.g. auto_separate.members could get the point across?

These changes look great! Do you mind if we merge, and then open a new PR if you are wanting to do more on the programming sections? (No worries if not, but your work building out the programming sections looks super useful for getting people into the nuts and bolts).
Since this PR contains changes across a range of documentation pages (including much needed spelling fixes 😅), I want to make sure to merge right away


Adds 'invited friend during onboarding' tracking event

We had a generic tracking event, need a specific one for onboarding
CC @Justin-Holmes

:metal:


require vault only when needed

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 2 (0.0%)  changed or added relevant lines in 1 file are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 10.612%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

testutil/vault.go
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

deps/bin.go
5
6.13%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
222

Relevant Lines:
2092

💛  - Coveralls


🐛 add TestController as first param to percySnapshot types

as per the readme
resolves #108

Woop! Thanks for the PR fixing this


1430: Show extend card notification only if the card is valid

Short description
Just noticed a small issue:
After a user extends the card and activates the new one, the extend card notification is still displayed for the old (revoked) card, and this can be confusing.
Proposed changes
Change the condition to display the notification: if the card is valid (instead of not expired) and extendable
Side effects
Couldn’t think of any
Testing
If needed, please refer to the detailed testing instructions from here:
https://github.com/digitalfabrik/entitlementcard/pull/1772
Once the extendable card has been created:

click ‘Pass verlängern’ in the app notification
submit the form
activate the new card
check that the extend card notification is not displayed anymore

Resolved issues
Follow up for #1430

Should the user be able to extend an expired card?

Should the user be able to extend an expired card?

Yes, under "Weitere Aktionen" --> KonlenzPass beantragen oder verlängern

I see. It's maybe a bit weird that the "notification" for extension is no longer shown once the card is expired (I think this is the app's behavior with and without your PR).
Feel free to merge, though.

@michael-markl when the card has expired, the message about the card extension is displayed below the card


breakShape() - remove parts created with invalid object box .

See commit comment for details.

Please follow the coding style guidelines. We don't use Java style for readability reasons.

Looks pretty good. As @dottools said, we format the brackets and stuff differently, so if you can just tweak it to adhere to the style guide there, this should be pretty fast to test and roll in.


Write unit tests for each method.

Methods:

compile
process
list_parameters
output
execute

Dear GeekCom,
I tried running the script and got below error....
Fatal error: Uncaught exception 'Exception' with message 'Your report has an error and couldn 't be processed!\ Try to output the command using the function output(); and run it manually in the console.' in /Applications/XAMPP/xamppfiles/htdocs/jasper/vendor/geekcom/phpjasper/src/JasperPHP/JasperPHP.php:205 Stack trace: #0 /Applications/XAMPP/xamppfiles/htdocs/jasper/index.php(10): JasperPHP\JasperPHP->execute() #1 {main} thrown in /Applications/XAMPP/xamppfiles/htdocs/jasper/vendor/geekcom/phpjasper/src/JasperPHP/JasperPHP.php on line 205
/bin/jasperstarter command complies .jrxml to .jasper from command line but not from php's exec().
Any directions would be much appreciated. I am testing on mac.
Below in exec()
./jasperstarter compile "/Applications/XAMPP/xamppfiles/htdocs/jasper/vendor/geekcom/phpjasper/examples/hello_world.jrxml"
Thank you.


Add vertical text centering methods

add tex gyre heros for ascender testing
add new centering modes
add centering mode tests
use em_center and em_top for tick label defaults

Description
I tried to change the default font to TeX Gyre Heros (a free Helvetica / Arial clone that is
also used by ProPlot, for example) which I think looks more clean and professional than Dejavu Sans.
I noticed that the y tick labels were off center, and investigation showed that this is because
TeX Gyre Heros has a large ascender value. When text is centered from descender to ascender,
it looks like it's too low. Therefore this PR adds different centering modes. The vertical align modes are now:

center: From lowest decender to highest ascender
em_center: From lowest baseline to highest em (height of M character)
ex_center: From lowest baseline to highest ex (height of x character)
baseline: At lowest baseline
bottom: At lowest descender
top: At highest ascender
em_top: At highest em (height of M character)

Type of change

New feature

Checklist

[ ] Added an entry in NEWS.md (for new features and breaking changes)
[ ] Added or changed relevant sections in the documentation
[ ] Added unit tests for new algorithms, conversion methods, etc.
[ ] Added reference image tests for new plotting functions, recipes, visual options, etc.

Closing for now in favor of https://github.com/JuliaPlots/Makie.jl/pull/1897.
There may still be useful changes in here, but since it's heavily conflicting right now, we likely will need to start anew anyways.


Super BUG - The validate load in data all the validation existing for a specific field

@joecorcoran
I am attaching an image because is more easy to look than write:

This is a sign_in form (field request are email and password), as you can see in the image the gem load in data-validable all another bunch of validation that are not present in my form.
The most evident is the confirmation password, I have that validation in my user model, but i have for a sign_up form, in another page. Why the validator load also this? actually it loads all the possible validation present in the model for a specific field.
How this is possible?
I really don't understand it.
Any thoughts, words or ideas would be more than appreciated.
Best
Dinuz

Don't validate the password on your sign in page then...? Judge doesn't do any validation by default, you must be both using Judge::FormBuilder and also calling some JS to run the validations on that page. You can validate inputs one by one, if you want to validate some fields but not the password.

Don't validate the password on your sign in page then...? Judge doesn't do any validation by default, you must be both using Judge::FormBuilder and also calling some JS to run the validations on that page. You can validate inputs one by one, if you want to validate some fields but not the password.

Dear Joe,
I don't understand. Please correct me if I am wrong.
Supposedly I should use validate on the input field(from a rails point of view), to tell to judge which field I want to validate. Then judge automatically would put that specific validations(the validations active for the field), in a data-validate tag, and that is used by judge(js in this case), to run the client side validations for that field.
In other words, if for example I have a form with an email, and in my model I have presence and format validations, adding the validate true to the field, should bring judge to create a data-validate with just presence and format. Instead what happens is that judge create the data-validate with all the validations existing for a field email, also if these validations are in different models.
Looks like judge doesn't distinguish between email of model A and email of model B, but instead put all the email validations(a+b).
Obviously judge doesn't perform any validations, if after adding the data-validate I don't call some js to run them.
The problem that I see, is not related with the js call, but instead I think, it is related with the way in which the data-validate is built!
If you look into the image that I previously attached, you see in the data field multiple repetition of the same validation, and that should be wrong!
What do you think?
Sent from my iPhone

On Jan 1, 2015, at 11:42 AM, Joe Corcoran<EMAIL_ADDRESS>wrote:
Don't validate the password on your sign in page then...? Judge doesn't do any validation by default, you must be both using Judge::FormBuilder and also calling some JS to run the validations on that page. You can validate inputs one by one, if you want to validate some fields but not the password.
—
Reply to this email directly or view it on GitHub.

Dear Joe,
I don't understand. Please correct me if I am wrong.
Supposedly I should use validate on the input field(from a rails point of view), to tell to judge which field I want to validate. Then judge automatically would put that specific validations(the validations active for the field), in a data-validate tag, and that is used by judge(js in this case), to run the client side validations for that field.
In other words, if for example I have a form with an email, and in my model I have presence and format validations, adding the validate true to the field, should bring judge to create a data-validate with just presence and format. Instead what happens is that judge create the data-validate with all the validations existing for a field email, also if these validations are in different models.
Looks like judge doesn't distinguish between email of model A and email of model B, but instead put all the email validations(a+b).
Obviously judge doesn't perform any validations, if after adding the data-validate I don't call some js to run them.
The problem that I see, is not related with the js call, but instead I think, it is related with the way in which the data-validate is built!
If you look into the image that I previously attached, you see in the data field multiple repetition of the same validation, and that should be wrong!
What do you think?
Sent from my iPhone

On Jan 1, 2015, at 11:42 AM, Joe Corcoran<EMAIL_ADDRESS>wrote:
Don't validate the password on your sign in page then...? Judge doesn't do any validation by default, you must be both using Judge::FormBuilder and also calling some JS to run the validations on that page. You can validate inputs one by one, if you want to validate some fields but not the password.
—
Reply to this email directly or view it on GitHub.

What does your User model look like? I see three validators in the password field data attribute: presence, kind and confirmation.

What does your User model look like? I see three validators in the password field data attribute: presence, kind and confirmation.

Exactly Joe...you see 3 validators, but actually they should be just 2!
This is a sign in form, and there is not a password confirmation field.
The password confirmation field exist on the signup form where you choose a password and confirm it.
The user model obviously is the same(if can help refer to a devise user model), but the validators the you want to run are different on the sign in and sign up form.
What I see it's happening(and maybe this is related to the way in which judge build up the data-validator tag), if we refer to the password attribute, is that judge is not able to distinguish between the presence or absence of a specific field, and instead it loads any validators that is set on the attribute.
I mean, if my form doesn't have a password confirmation field, i don't want see a confirmation validator in the data-validator attribute.
Moreover the thing get super frustrating when a same attribute is used on multiple models. If we refer for example to the email attribute, in my case it is part of the user model, and is also part of a beta invite model. Here if I put a validator for the email in the beta invite model, and put other completely different validators on the email in the user model, when I use judge on the form(eg the sign in form for the user again), judge create a data-validator attribute for the email, that include also the validator of the email in the beta invite model. This in my opinion is really wrong! I mean doesn't make any sense at all. In a user model form, I shouldn't have any validators of the beta invite model, also if the email attribute is present in the two models. They are two different models, and they have two different purpose and logic. Judge clearly is not able to recognize this difference, and treat the email attribute as one(mixing together validators of different models)
Please let me understand what really is not so clear here?

Exactly Joe...you see 3 validators, but actually they should be just 2!
This is a sign in form, and there is not a password confirmation field.
The password confirmation field exist on the signup form where you choose a password and confirm it.
The user model obviously is the same(if can help refer to a devise user model), but the validators the you want to run are different on the sign in and sign up form.
What I see it's happening(and maybe this is related to the way in which judge build up the data-validator tag), if we refer to the password attribute, is that judge is not able to distinguish between the presence or absence of a specific field, and instead it loads any validators that is set on the attribute.
I mean, if my form doesn't have a password confirmation field, i don't want see a confirmation validator in the data-validator attribute.
Moreover the thing get super frustrating when a same attribute is used on multiple models. If we refer for example to the email attribute, in my case it is part of the user model, and is also part of a beta invite model. Here if I put a validator for the email in the beta invite model, and put other completely different validators on the email in the user model, when I use judge on the form(eg the sign in form for the user again), judge create a data-validator attribute for the email, that include also the validator of the email in the beta invite model. This in my opinion is really wrong! I mean doesn't make any sense at all. In a user model form, I shouldn't have any validators of the beta invite model, also if the email attribute is present in the two models. They are two different models, and they have two different purpose and logic. Judge clearly is not able to recognize this difference, and treat the email attribute as one(mixing together validators of different models)
Please let me understand what really is not so clear here?

Okay, the sign in form: I can sort of see why it might be annoying that things break without the presence of the confirmation input. At the same time – why validate a password field on a sign in form? The user is either going to enter their own password correctly or not, I don't see the value in giving them hints about length and presence. On a sign up form, sure, but when logging in? What's the point? Maybe a way of specifying which validators you care about would be useful in the general case. Something like
judge.validate(element, ['presence', 'length'], {
  valid: function() {},
  invalid: function() {}
});

might be good, but aside from that, I'm struggling to see how Judge is supposed to know the specifics of your UX requirements.
The multiple models thing sounds a bit worrying. I suspect it's something specific to your app, but I'd love to see a minimal reproduction of the problem in the form of a new Rails app, so we can talk about it more.

Okay, the sign in form: I can sort of see why it might be annoying that things break without the presence of the confirmation input. At the same time – why validate a password field on a sign in form? The user is either going to enter their own password correctly or not, I don't see the value in giving them hints about length and presence. On a sign up form, sure, but when logging in? What's the point? Maybe a way of specifying which validators you care about would be useful in the general case. Something like
judge.validate(element, ['presence', 'length'], {
  valid: function() {},
  invalid: function() {}
});

might be good, but aside from that, I'm struggling to see how Judge is supposed to know the specifics of your UX requirements.
The multiple models thing sounds a bit worrying. I suspect it's something specific to your app, but I'd love to see a minimal reproduction of the problem in the form of a new Rails app, so we can talk about it more.

I agree with you! The sign in form was just an example, and probably not the best one. But have the ability to specify which validators you care about I believe is a real great thing.
The multiple models thing instead is kind of scary, and as I said before tomorrow I will build up a base rails app, just for testing purposes.
In the meantime I can assure you is not related with my specific app(the way in which it is build is really basic, there are not crazy things around...it's just a devise model and another basic beta model). But let's see how it behaves with a real basic app(I will just bootstrap it and auto generate with rails, without any front end stuff, except the js call to judge).
Note(I mentioned it on the other post about the new judge release), this mixing models stuff become more nasty if I use a custom validator that use a call to the judge controller(I mean if the validator is an ajax one).
Joe don't get me wrong, I really want that judge works in the right way, simply because I think is the best implementation of a client side validator, and it is very light and compact. If we can tweak a bit judge to perform its task in a better way I will be very happy, and your gem definitely will be the best gem for this type of thing.
Sent from my iPhone

On Jan 1, 2015, at 5:59 PM, Joe Corcoran<EMAIL_ADDRESS>wrote:
Okay, the sign in form: I can sort of see why it might be annoying that things break without the presence of the confirmation input. At the same time – why validate a password field on a sign in form? The user is either going to enter their own password correctly or not, I don't see the value in giving them hints about length and presence. On a sign up form, sure, but when logging in? What's the point? Maybe a way of specifying which validators you care about would be useful in the general case. Something like
judge.validate(element, ['presence', 'length'], {
valid: function() {},
invalid: function() {}
});
might be good, but aside from that, I'm struggling to see how Judge is supposed to know the specifics of your UX requirements.
The multiple models thing sounds a bit worrying. I suspect it's something specific to your app, but I'd love to see a minimal reproduction of the problem in the form of a new Rails app, so we can talk about it more.
—
Reply to this email directly or view it on GitHub.

I agree with you! The sign in form was just an example, and probably not the best one. But have the ability to specify which validators you care about I believe is a real great thing.
The multiple models thing instead is kind of scary, and as I said before tomorrow I will build up a base rails app, just for testing purposes.
In the meantime I can assure you is not related with my specific app(the way in which it is build is really basic, there are not crazy things around...it's just a devise model and another basic beta model). But let's see how it behaves with a real basic app(I will just bootstrap it and auto generate with rails, without any front end stuff, except the js call to judge).
Note(I mentioned it on the other post about the new judge release), this mixing models stuff become more nasty if I use a custom validator that use a call to the judge controller(I mean if the validator is an ajax one).
Joe don't get me wrong, I really want that judge works in the right way, simply because I think is the best implementation of a client side validator, and it is very light and compact. If we can tweak a bit judge to perform its task in a better way I will be very happy, and your gem definitely will be the best gem for this type of thing.
Sent from my iPhone

On Jan 1, 2015, at 5:59 PM, Joe Corcoran<EMAIL_ADDRESS>wrote:
Okay, the sign in form: I can sort of see why it might be annoying that things break without the presence of the confirmation input. At the same time – why validate a password field on a sign in form? The user is either going to enter their own password correctly or not, I don't see the value in giving them hints about length and presence. On a sign up form, sure, but when logging in? What's the point? Maybe a way of specifying which validators you care about would be useful in the general case. Something like
judge.validate(element, ['presence', 'length'], {
valid: function() {},
invalid: function() {}
});
might be good, but aside from that, I'm struggling to see how Judge is supposed to know the specifics of your UX requirements.
The multiple models thing sounds a bit worrying. I suspect it's something specific to your app, but I'd love to see a minimal reproduction of the problem in the form of a new Rails app, so we can talk about it more.
—
Reply to this email directly or view it on GitHub.

Probably the less intrusive way to specify which validators someone cares about, should be done on the rails side(instead of just validate, we could add the functionality there - eg skip something, I believe the old client-side-validations gem has something similar). This will be more robust than doing the same thing in js(I mean I prefer having my data-validate attribute be changed on server side), for the simple reason that this will give me control directly on the form(while I put down the html of the form), and will allow me to use a generic call in js for every form.
Sent from my iPhone

On Jan 1, 2015, at 5:59 PM, Joe Corcoran<EMAIL_ADDRESS>wrote:
Okay, the sign in form: I can sort of see why it might be annoying that things break without the presence of the confirmation input. At the same time – why validate a password field on a sign in form? The user is either going to enter their own password correctly or not, I don't see the value in giving them hints about length and presence. On a sign up form, sure, but when logging in? What's the point? Maybe a way of specifying which validators you care about would be useful in the general case. Something like
judge.validate(element, ['presence', 'length'], {
valid: function() {},
invalid: function() {}
});
might be good, but aside from that, I'm struggling to see how Judge is supposed to know the specifics of your UX requirements.
The multiple models thing sounds a bit worrying. I suspect it's something specific to your app, but I'd love to see a minimal reproduction of the problem in the form of a new Rails app, so we can talk about it more.
—
Reply to this email directly or view it on GitHub.

Probably the less intrusive way to specify which validators someone cares about, should be done on the rails side(instead of just validate, we could add the functionality there - eg skip something, I believe the old client-side-validations gem has something similar). This will be more robust than doing the same thing in js(I mean I prefer having my data-validate attribute be changed on server side), for the simple reason that this will give me control directly on the form(while I put down the html of the form), and will allow me to use a generic call in js for every form.
Sent from my iPhone

On Jan 1, 2015, at 5:59 PM, Joe Corcoran<EMAIL_ADDRESS>wrote:
Okay, the sign in form: I can sort of see why it might be annoying that things break without the presence of the confirmation input. At the same time – why validate a password field on a sign in form? The user is either going to enter their own password correctly or not, I don't see the value in giving them hints about length and presence. On a sign up form, sure, but when logging in? What's the point? Maybe a way of specifying which validators you care about would be useful in the general case. Something like
judge.validate(element, ['presence', 'length'], {
valid: function() {},
invalid: function() {}
});
might be good, but aside from that, I'm struggling to see how Judge is supposed to know the specifics of your UX requirements.
The multiple models thing sounds a bit worrying. I suspect it's something specific to your app, but I'd love to see a minimal reproduction of the problem in the form of a new Rails app, so we can talk about it more.
—
Reply to this email directly or view it on GitHub.

Ok @joecorcoran I set up the basic app, and I put in https://github.com/Dinuz/JudgeTest  it's a public repository that you can access without any problem.
All the issue that I talked about are replicated in the repository.
The basic app has a devise user model (the root page is the signin), and has another model called invite request with its own controller (the only actions are new and create).
In the lib folder there are two files (one is a jquery plugin to run judge on form, and the other is just an extension for judge - a custom validator ajax style).
Looking forward to hearing from you....
I also saw you request for help (maintainers), and I will be happy to help out, but I should probably understand better the logic of your code (some sort of explanation would be great).
Best
Dinuz

@joecorcoran Did you see the repository?

Saw it, thanks! Haven't had much time this weekend though, will take a
proper look as soon as I can.
On 3 January 2015 at 16:33, Massimiliano<EMAIL_ADDRESS>wrote:

@joecorcoran https://github.com/joecorcoran Did you see the repository?
—
Reply to this email directly or view it on GitHub
https://github.com/joecorcoran/judge/issues/45#issuecomment-68598410.

Joe, I just want to point out(and maybe this is not the case), but rails with the version 4 changed completely how json is handled. Could be this an issue?

@Dinuz I reported the confirmation issue as well and recently submitted a PR (https://github.com/joecorcoran/judge/pull/55) to move confirmation validation to the confirmation field. This should resolve one of your issues here.
I'm having a harder time understanding your multiple models issue. I looked at your repo and noticed validations for :email on both models are very similar. What specific part of data-validate on the sign in form do you feel is getting polluted by InviteRequest?
thanks

Closing this – it's been open for a long time with no activity.


Allow control over disk image location

Please browse the existing issues and filter by 'enhancement' to make sure this has not already been suggested!
First of all, thanks for making this app! Having a virtualized linux on ARM architecture is very helpful for my work.
But I would have liked to be able to customize the location of the disk image files, for at least two reasons:

Be able to cleanup orphaned files. The Library folder tends to accumulate a lot of waste on a Mac that has been running for years. This is not so much of a problem for most data, but when having disk image files at > 20Gb it does become a problem.
Easy exclusion from backup software. I really don't want these files to be backed up, neither to my on-site time machine, nor my secondary cloud base backup solution.

I would kinda argue, that virtual disks is for virtualization software a bit like document files for a word processor, the user should have full control over their location.
Also, finding the files is not easy, I couldn't find anywhere in the app, that actually displays the file location. It took a google search to learn where they are located, so I could add the backup exclusions.

This would also be a very useful improvement for users who might need to run VMs off of an external disk. (Users of 256GB machines who have external disks mounted, etc).

This is a limitation of the app sandbox. You can manually move the .utm bundles to another location and they should automatically get updated as shortcuts.


Partial file list

I dumped a list of file paths. It will be much more useful to you than having it sitting in my computer.
ff16_paths.txt
I dumped them via strings -n 6 0000.pac | grep -E '^[a-z][a-z]+/[a-zA-Z0-9]+' and strings -n 6 ffxvi_demo.exe | grep -E '^[a-z][a-z]+/[a-zA-Z0-9]+' and then cleaned up the output.
Some paths have sprintf formatting stuff like %04u or %s. I purposely left them in the list in case we want to brute-force them. Unfortunately the hashing algorithm doesn't play nice with bruteforcing as there are plenty of collisions happening.

File names are included in the packed files (surprisingly).

Oh that's really good lol . I was not yet able to extract any of the files that has the 0x201 or 0x301 storage type, and using your tool on Linux doesn't currently work, so I did not know. That's actually good news then!


Initial support for NuttX

Define the essential types that for NuttX OS.
NuttX has beed added to Rust by https://github.com/rust-lang/rust/pull/127755, this patch is try to introduce basic libc support for NuttX, see the discussion in NuttX community:
https://github.com/apache/nuttx/issues/12960
https://github.com/apache/nuttx/pull/13245

:umbrella: The latest upstream changes (presumably #3866) made this pull request unmergeable. Please resolve the merge conflicts.

I didn't read through everything thoroughly but since this is a tier3 target and you are the maintainer, I'll take your word for it :). Based on your links it seems like the exact API may need some development, but you can update as needed.
@rustbot label +stable-nominated


The property 'Visual' was not found in type 'ContentPage'.

Followed the docs on adding Visual to my Xamarin.Forms Project. Despite adding the Xamarin.Forms.Material Visual nuget package and initializing the material renderer for the Android Project, the "Visual" Property is unavailable from the ContentPage.  Im using Xamarin.Forms version <IP_ADDRESS>8062 and Xamarin.Forms.Visual.Material with the same version and Visual Studio 2019 version 16.2.4.

HI @johnfredrick
Visual has been part of Xamarin.Forms since Xamarin.Forms 3.6, and the Visual property is available without adding additional NuGet packages.
It's most likely that this is a Visual Studio issue, that will go away with some combination of relaunch, ensuring all projects are using the same NuGet packages, and deleting the bin/obj directories for each project.
If in doubt, you can also try the sample that the Visual doc links to.


Fix scala_deps_direct and scala_deps_used

Fix: #249

Looks great! I'll approve once builds pass

It has passed.


Time tracking overview panel false positives for birdhouses and crops

False "Ready" positives for:

"Empty" birdhouses
"Done" crops with "Weeds"

This was intentional. It shows "Ready" as long as there is no patch that is still growing or bird house that is still catching (i.e. "Ready" in this case means that you're ready to make a [patch type] run / bird house run).

If we change this we should also change it in the non overview tabs.

I see, well as it shows "Ready" for both empty patches and birdhouses and trees that are done growing, its really misleading.

Well, they are ready/done because they will not be changing in the future. For farming I tried to keep the number of special cases to a minimum, so weeds are not treated differently than any other crop, with the exception of autoweed.

Yeah I sort of understand why is it like it is now. But it is problem for overview panel because having no difference between you having stuff ready to be harvested and empty spots ready to be planted. It would be fine if you would always use all farming spots in each panel, but that is rarely the case, so you can be just stuck with perma "Ready" state if you e.g do just mahogany trees but not regular trees.


react native updated to<EMAIL_ADDRESS>

Flow got updated and it broke CI

@facebook-github-bot shipit

opportunistically landing to get master green again


Update README.md

License badge
Badge about downloads per months
Installation Section

License badge
Badge about downloads per months
Installation Section

Thanks for contributing!


Spell text by pressing tab using JAWS on windows or screen reader on MAC

Does this test for accessibility to spell text out loud by pressing tab using JAWS on windows or screen reader on MAC ???
Feature Request :
Also can you add support for multiple URL

Koa11y is built on top of Pa11y, which is built on top of HTML_CodeSniffer.

http://squizlabs.github.io/HTML_CodeSniffer/

The results that Koa11y outputs are currently limited to what is supported in those other two technologies.

Multiple URLs wouldn't be all that hard. I'd need to think about how best to implement that from a UX perspective. Currently the report's filename is based on the URL by default, but allows you to change it. I have a few ideas, but will need to give it more thought before diving in.

Closing this issue as it has answered the original question the feature request has had it's own issue created.


Support for additional missing TLDs (.gt, .my, .za, .ch)

Describe the bug
Please add support for .gt, .my, .za and .ch TLDs.
To Reproduce
Steps to reproduce the behavior:
import whois
domain = whois.query('edu.gt')
print(domain.__dict__)

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.10/site-packages/whois/__init__.py", line 250, in query
    tld, dl = fromDomainStringToTld(domain, internationalized, verbose)
  File "/usr/local/lib/python3.10/site-packages/whois/__init__.py", line 109, in fromDomainStringToTld
    tld: str = filterTldToSupportedPattern(domain, d, verbose)
  File "/usr/local/lib/python3.10/site-packages/whois/_0_init_tld.py", line 50, in filterTldToSupportedPattern
    raise UnknownTld(msg)
whois.exceptions.UnknownTld: The TLD gt is currently not supported by this package. Use validTlds() to see what toplevel domains are supported.

Expected behavior
Return the expected dictionary.
Desktop (please complete the following information):

OS: macOS 12.6.3
Python 3.10.9

note that this library depends on the output of the cli whois tool,
if that tool gives no output there is no alternative for us but to give up,
if you have working examples using the cli whois command we can use,
that would be very helpful
.gt
as you can see from https://www.iana.org/domains/root/db/gt.html
the gt domain has no whois servers that the cli whois program can use
currently we can only add this tld as privateRef (as it returns no useful information)
whois meta.gt
[Querying http://www.gt/cgi-bin/whois.cgi]
404 Not Found
__________________________________________________________________
                            nginx/1.20.1

.my
whois.mynic.my never anwers any request i tested with hence it is  presnt in the tld list as privateReg meaning it never anweres with anything useful
.za
we currently have za as:
ZZ["za"] = {
"extend": "com",
}
ZZ["web.za"] = {"extend": "za", "_server": "web-whois.registry.net.za"}
ZZ["org.za"] = {"extend": "za", "_server": "org-whois.registry.net.za"}
ZZ["net.za"] = {"extend": "za", "_server": "net-whois.registry.net.za"}
ZZ["co.za"] = {"extend": "za", "_server": "coza-whois.registry.net.za"}
.ch
and ch as
ZZ["ch"] = {"extend": "_privateReg"}
as it never answeres with anything useful
whois -h whois.nic.ch nic.ch
[Querying whois.nic.ch]
[whois.nic.ch]
Requests of this client are not permitted. Please use https://www.nic.ch/whois/ for queries.
whois -h whois.nic.ch meta.ch
[Querying whois.nic.ch]
[whois.nic.ch]
Requests of this client are not permitted. Please use https://www.nic.ch/whois/ for queries.

gt has been added as privateRegistry

Yes the mac version is notoriously different unfortunarely.
On Wed, Mar 8, 2023, 17:07 Rick Torres Jr. @.***> wrote:

My mistake. Thank you for clarifying. You are indeed correct. It seems
like the macOS (GNU) version of whois has much less support for
non-traditional TLDs versus Debian's whois (5.5.15) which is what caused
the majority of the problems.
macOS (GNU)
$ whois cleversafe.co.za
% IANA WHOIS server
% for more information on IANA, visit http://www.iana.org
% This query returned 1 object
refer:
domain:       ZA
organisation: ZA Domain Name Authority
address:      44 Grand Central Blvd
address:      Sanofi House
address:      Halfway house
address:      Midrand Gauteng 1685
address:      South Africa
contact:      administrative
name:         Chairperson
organisation: ZA Domain Name Authority
address:      44 Grand Central Blvd
address:      Sanofi House
address:      Halfway house
address:      Midrand Gauteng 1685
address:      South Africa
phone:        +27 (0)10 020 3910
fax-no:       +27 (0)10 020 3919
e-mail:       @.***
contact:      technical
name:         Technical Committee
organisation: ZA Domain Name Authority
address:      44 Grand Central Blvd
address:      Sanofi House
address:      Halfway house
address:      Midrand Gauteng 1685
address:      South Africa
phone:        +27 (0)10 020 3910
fax-no:       +27 (0)10 020 3919
e-mail:       @.***
nserver:      NSZA.IS.CO.ZA <IP_ADDRESS>
nserver:      ZA-NS.ANYCAST.PCH.NET 2001:500:14:6055:ad:0:0:1 <IP_ADDRESS>
nserver:      ZA1.DNSNODE.NET <IP_ADDRESS> 2001:67c:1010:19:0:0:0:53
ds-rdata:     45749 8 2 3e2b0b7e6063ca11400fa4b54d8a530888234cd0eb3b5fbf820c0750784da84e
whois:
status:       ACTIVE
remarks:      Registration information: http://www.zadna.org.za/
created:      1990-11-07
changed:      2020-01-15
source:       IANA
Debian
$whois cleversafe.co.za
whois cleversafe.co.za
Domain Name: cleversafe.co.za
Registry Domain ID: dom_1X740--1
Registrar WHOIS Server:
Registrar URL: https://www.cscglobal.com/cscglobal/home/
Updated Date: 2022-06-11T07:12:21Z
Creation Date: 2009-06-15T12:33:52Z
Registry Expiry Date: 2023-06-15T12:33:52Z
Registrar Registration Expiration Date: 2023-06-15T12:33:52Z
Registrar: CSC Corporate Domains Inc
Registrar IANA ID: 299
Registrar Abuse Contact Email: @.***
Registrar Abuse Contact Phone: +44.077510055
Reseller:
Domain Status: ok https://icann.org/epp#ok
Registry Registrant ID: REDACTED
Registrant Name: REDACTED
Registrant Organization:
Registrant Street: REDACTED
Registrant City: REDACTED
Registrant State/Province: REDACTED
Registrant Postal Code: REDACTED
Registrant Country: US
Registrant Phone: REDACTED
Registrant Phone Ext: REDACTED
Registrant Fax: REDACTED
Registrant Fax Ext: REDACTED
Registrant Email: Please query the RDDS service of the Registrar of Record identified in this output for information on how to contact the Registrant, Admin or Tech contacts of the domain name.
Registry Admin ID: REDACTED
Admin Name: REDACTED
Admin Organization: REDACTED
Admin Street: REDACTED
Admin City: REDACTED
Admin State/Province: REDACTED
Admin Postal Code: REDACTED
Admin Country: REDACTED
Admin Phone: REDACTED
Admin Phone Ext: REDACTED
Admin Fax: REDACTED
Admin Fax Ext: REDACTED
Admin Email: Please query the RDDS service of the Registrar of Record identified in this output for information on how to contact the Registrant, Admin or Tech contacts of the domain name.
Registry Tech ID: REDACTED
Tech Name: REDACTED
Tech Organization: REDACTED
Tech Street: REDACTED
Tech City: REDACTED
Tech State/Province: REDACTED
Tech Postal Code: REDACTED
Tech Country: REDACTED
Tech Phone: REDACTED
Tech Phone Ext: REDACTED
Tech Fax: REDACTED
Tech Fax Ext: REDACTED
Tech Email: Please query the RDDS service of the Registrar of Record identified in this output for information on how to contact the Registrant, Admin or Tech contacts of the domain name.
Registry Billing ID: REDACTED
Billing Name: REDACTED
Billing Organization: REDACTED
Billing Street: REDACTED
Billing City: REDACTED
Billing State/Province: REDACTED
Billing Postal Code: REDACTED
Billing Country: REDACTED
Billing Phone: REDACTED
Billing Phone Ext: REDACTED
Billing Fax: REDACTED
Billing Fax Ext: REDACTED
Billing Email: Please query the RDDS service of the Registrar of Record identified in this output for information on how to contact the Registrant, Admin or Tech contacts of the domain name.
Name Server: ns1.cleversafe.com
Name Server: ns3.cleversafe.com
DNSSEC: unsigned
URL of the ICANN Whois Inaccuracy Complaint Form: https://www.icann.org/wicf/

Last update of WHOIS database: 2023-03-08T15:51:51Z <<<

For more information on Whois status codes, please visit https://icann.org/epp
--
For more information on Whois status codes, please visit https://icann.org/epp
ZARC Complaint/s Procedure and Form: https://registry.net.za/content.php?gen=1&contentid=226
The use of this Whois facility is subject to the following terms and
conditions. https://registry.net.za/whois_terms
Copyright (c) ZARC 2023
—
Reply to this email directly, view it on GitHub
https://github.com/DannyCork/python-whois/issues/288#issuecomment-1460422638,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACU73CXMYP7OTHXPGCGFBMLW3CVDPANCNFSM6AAAAAAVRVU754
.
You are receiving this because you commented.Message ID:
@.***>


fix: handling of trailing slash in localePath

Respect "router.trailingSlash" option when using "localePath" with
an absolute path as an argument. The trailing slash is not normalized
according to that option (true: add trailing slash,
false or undefined: remove trailing slash). That excludes the root path
which always includes trailing slash.
An extra fix for #717

To go forward with this, I need to figure out if this change makes sense.
Since I have problems making tests work with a simple HTTP server, it might also be a problem for production servers like Apache or nginx.
The problem is when Nuxt generates such directory structure:
| - da/
| - da/foo.html
| - da.html
| - index.html

This can happen with those options set:
  router: {
    trailingSlash: false
  },
  generate: {
    subFolders: false,
  },

Then, supposedly, http://localhost/da should load the root da.html file and http://localhost/foo.html should load the da/foo.html file but at least the simple server would fail here as it would see the directory and since directory does not contain index.html, it would return 404.


email header 'sender' support

just support for 'sender' header, witch allows using on-behalf sender

Thank you for the pull request. I've merged it into master and released a updated nuget package (0.6.4).


[Bug]: Dependency issues when first debug for 03.ai-concepts/c.actionMapping-lightBot

Language
Javascript/Typescript
Version
latest
Description
When following the Teams AI library quick start guide running the 03.ai-concepts/c.actionMapping-lightBot sample for the first time in Debug the provisioning script fails with a dependency issue.
Lifecycle stage: deploy(2 step(s) in total). The following actions will be executed:
(1/2) Action cli/runNpmCommand(install dependencies): running npm command.
(2/2) Action file/createOrUpdateEnvironmentFile: Create or update variables to environment file.

[2024-07-15T22:11:00.449Z] [Info] - Executing lifecycle deploy
[2024-07-15T22:11:01.557Z] [Warning] -  [script stderr] npm
[2024-07-15T22:11:01.558Z] [Warning] -  [script stderr]  ERR! code ERESOLVE

[2024-07-15T22:11:01.559Z] [Warning] -  [script stderr] npm
[2024-07-15T22:11:01.559Z] [Warning] -  [script stderr] ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR!
[2024-07-15T22:11:01.559Z] [Warning] -  [script stderr]  Found<EMAIL_ADDRESS>npm ERR! node_modules/openai
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@microsoft/teams-ai
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/openai
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@microsoft/teams-ai
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! C:\Users\benja\AppData\Local\npm-cache\_logs\2024-07-15T22_11_00_943Z-eresolve-report.txt

[2024-07-15T22:11:01.560Z] [Warning] -  [script stderr]

[2024-07-15T22:11:01.560Z] [Warning] -  [script stderr] npm ERR! A complete log of this run can be found in: C:\Users\benja\AppData\Local\npm-cache\_logs\2024-07-15T22_11_00_943Z-debug-0.log

[2024-07-15T22:11:01.571Z] [Error] - Failed to Execute lifecycle deploy due to failed action: {"name":"install dependencies","uses":"cli/runNpmCommand"}. ScriptExecutionError:Unable to execute script action.. Env output: {}
[2024-07-15T22:11:01.572Z] [Info] - Execution summary:

Summary:
(×) Error: Lifecycle stage deploy failed.
  (×) Error: cli/runNpmCommand(install dependencies) failed.
    (×) Error: Unable to execute script action.
  (!) Warning: file/createOrUpdateEnvironmentFile was not executed.

Reproduction Steps
1. Clone the repo
2. yarn install and yarn build in the .\js folder
3. F5 in the c.actionMapping-lightBot folder

can you try deleting any lock files like yarn.lock or package.lock and try to run npm install again?

just pushed a fix for this here https://github.com/microsoft/teams-ai/pull/1855


Run stress tests without rowid

Run stress tests without rowid. According to the documentation this has some benefits. Your blog posts state that rowid was harming concurrency.
https://univalence.me/posts/mvsqlite-bench-20220930
https://www.sqlite.org/withoutrowid.html

Didn't seem to be a problem.


[bug]: 4.0.0rc6 - Configuration fails with "ModuleNotFoundError: No module named 'invokeai.frontend.install.invokeai_configure'"

Is there an existing issue for this problem?

[X] I have searched the existing issues

Operating system
Linux
GPU vendor
Nvidia (CUDA)
GPU model
RTX 3060 Max-Q
GPU VRAM
6GB
Version number
4.0.0rc6
Browser
Firefox
Python dependencies
No response
What happened
I try to select manual configuration and the error "ModuleNotFoundError: No module named 'invokeai.frontend.install.invokeai_configure'" is thrown
What you expected to happen
Configuration is successful
How to reproduce the problem
Run 4.0.0rc6 installer and select manual configuration
Additional context
No response
Discord username
No response

There is no configuration script in v4. Please review the release notes for RC6, which have links to documentation: https://github.com/invoke-ai/InvokeAI/releases/tag/v4.0.0rc6
To fix your launcher (which erroneously attempts to load the non-existent configure script), download the latest installer from the linked release and use it to install. You won't lose any data, but it should update the old launcher script. The new one only has 4 options.

Oh sorry, I didn't see that note, thanks :)

No worries :)

I have the same issue trying to install 4.2.0 on mac. I get to the step where it asks automatic or manual, I select automatic then I get the error:
Choose <a>utomatic or <m>anual configuration [a/m] (a): a
Traceback (most recent call last):
  File "/Users/sergei.issaev/Downloads/InvokeAI-Installer/./lib/main.py", line 52, in <module>
    inst.install(**args.__dict__)
  File "/Users/sergei.issaev/Downloads/InvokeAI-Installer/lib/installer.py", line 153, in install
    self.instance.configure()
  File "/Users/sergei.issaev/Downloads/InvokeAI-Installer/lib/installer.py", line 271, in configure
    from invokeai.frontend.install.invokeai_configure import invokeai_configure
ModuleNotFoundError: No module named 'invokeai.frontend.install.invokeai_configure'

@sergeiissaev Please carefully read and follow the Installation and Updating instructions on the release page.


Can I limit the number of searching regions ?

Hi, @AlpacaDB.
Can I limit the number of searching regions ?
I just want to searching only 100 regions.
Is that possible ?
Thanks.

the param scale may be help,increase it and regions may be lesser


:sparkles: CombinedStatus Calculation (part 2)

Summary
This PR outlines the design for the implementation of the calculation of CombinedStatus objects.
The PR introduces new components that maintain the resolutions of combined-statuses, by maintaining a resolution entry per each of the latter (in the new CombinedStatusResolver), in which information from StatusCollectors and the evaluation of WorkStatuses are kept up to date.
The code is incomplete, and has TODOs that should cover finishing the maintenance of CombinedStatus objects without error propagation.
Note that the outlined design attempts to find balance between over-optimizing (in my opinion there is none), and the efficiency required due to the highly distributed nature of the feature while respecting eventual consistency and multiple information update sources.
Related issue(s)

#2141

I think that the overall strategy for this implementation should be documented somewhere. I had to read too much detailed code to get the big picture.
I think that the big picture could be simpler and better regarding what gets queued and worked on asynchronously. Remember that the reason that a controller does not do all its work in the informer event handlers is that they need to complete quickly. Since a binding.Resolution is already being updated in a worker goroutine, its event handlers do not have such urgency. The design would be simpler if the status combination data structure were more thoroughly updated in the binding.Resolution event handlers (callbacks). I think that there is one good use for queuing, which is to batch re-evaluation of the aggregations.
The status controller maintains materialized views of the rows to be aggregated. Any update to such a materialized view causes a call to DelayingInterface.AddAfter with the ID of a CombinedStatus object to be re-evaluated at a later time. Using a delay means that quickly-spaced materialized view updates cause only one re-evaluation of the aggregation. Each materialized view is specific to the spec of one StatusCollector, and re-created whenever that spec changes. In brief, the data structures involved look like the following.
CollectorSpecs: collector_name -> StatusCollectorSpec
CSRs: binding_id -> wload_obj_id -> CSR
CSR: collector_name -> SCData
SCData: wec_id -> EvaldRow // but for rows that pass the filter
SCData holds the materialized view for one (CombinedStatus, StatusCollector) pair.
EvaldRow is another name for what the current PR draft calls workStatusData, except no need for the filterEval bool field because it can only be true in a row that actually appears in the data structure.
Any change to a relevant input causes immediate updating of this data structure, yielding a set of CombinedStatus object IDs to enqueue for eventual re-evaluation. Evaluating such a CombinedStatus object ID is done by iterating over the relevant StatusCollector objects and, for each one, evaluating the aggregation of the corresponding materialized view. Once that is done for all the relevant StatusCollectors, the new value of the CombinedStatus object is written out.

Maintaining materialized views saves computation at the expense of memory. It is going to be very profligate in memory usage. Ultimately we have to shard anyway. It may be better to spend less on memory and more on computation. Following is an outline that spends less memory.
In this design, the status combination data structure does not maintain the results of Expression evaluation. Note that the informer on WorkStatus objects is already holding the latest rev of each in memory. The status combination data structure holds pointers to those objects, indexed by the needs of status combination. Upon a relevant change in inputs, a reference to a CombinedStatus object is enqueued (with DelayingInterface.AddAfter) for eventual re-evaluation. Such evaluation applies the relevant StatusCollector specs to the indexed WorkStatus objects. In brief, the data structure looks like the following.
CollectorSpecs: collector_name -> StatusCollectorSpec
CSIs: binding_id -> wload_obj_id -> CSI
CSI: struct {
reported: wec_id -> *WorkStatus
}

Both of the above designs continue to eschew the designed type checking. To recover that would involve introducing an intermediate layer of data structure per GVR and also per (GVR, StatusCollector). I think this would amount to replacing those foo -> wload_obj_id -> bar with foo -> GVR -> rsc_data; type rsc_data = struct {bars map[NamespacedName]bar; collectors map[string]digestedCollector} and holding the results of type checking in digestedCollector.

@MikeSpreitzer thank you for reviewing, I have partially addressed comments (comments on CEL later).
On your proposals, I think the first is pretty close to what is intended. The reason I chose to spend memory rather than computation is because I assumed that triggering a fleet of evaluations per individual change is costly.
I think we can later optimize the management of stored information, I prefer this over the alternative.

The latest force-push squashes a few commits that address the recent batch of comments and further development.

The latest force-push squashes the last batch of code into one commit.

/lgtm
/approve


Local root server for offline/online operations (Arra Networks)

[x] Create root server / docker container that can act offline for local atServers but also relay connections to the Internet root server when available.
[x] Develop demonstration of working configuration
[x] Document - Solution
[x] Document - Code
[ ] Create auto build for most OS's
[ ] Create Unit Tests
[ ] End to End tests

MVP now opensource in the foundation repo

Burnt down to 3sp

Demo for Arra this week.. TO get feedback


Update SortFilter.csproj

As it stands when opening this project an error about not being able to find the entry point occurs. The fix is to change it from Application Definition to Page and back again, These are the resulting changes in the .csproj file
Microsoft Reviewers: Open in CodeFlow

Hey @noonand,
I tried this out, but I am not facing any error. I can build and run the app without making any changes to .csproj file.
Can you elaborate your scenario ?

In that case, I am going ahead and closing this PR. Thanks @noonand for the quick response. Feel free to start another conversation if you find something wrong about it.


doppelgreener: Watch i-fax.ru

doppelgreener requests the watch of the watch_keyword i-fax.ru. See the Metasmoke search here

!!/approve


Update README.md in order to update seq install command

Running helm install seq results in the following error:  "Error: failed to download "seq" (hint: running helm repo update may help)"
Must add  the word stable in front.

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] DCO signed
[ ] Chart Version bumped
[ ] Variables are documented in the README.md

Please sign off the commit and bump the chart version.


Cleanup: Continue on error removing keg

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

Fixes #2355

Broken test seems like it's a connection issue. Not sure if this will work for me or if it's locked to maintainers, but here goes nothing:
@BrewTestBot test this please

Thanks @ilovezfs

yw

A couple of quick questions:
Do you prefer commits to be rebased prior to merge?
Is there a style guide that you have a use in this project. I'm fairly new to ruby (though not software development).
It might be best to update https://github.com/Homebrew/brew/blob/master/CONTRIBUTING.md with the answers to these questions as it would help others, instead of just me.

One more question. This class only has class methods, should it be a module? Some of the ruby style guides I'm reading suggest this approach, others do not.

Do you prefer commits to be rebased prior to merge?

We don't mind either way on Homebrew/brew as we use merge commits anyway.

Is your preferred style guide the github one?

Yeh although our Rubocop does most of the enforcing too.

It might be best to update https://github.com/Homebrew/brew/blob/master/CONTRIBUTING.md with the answers to these questions as it would help others, instead of just me.

We generally rely on tooling and CI rather than documentation as it's easier to keep up to date.

This class only has class methods, should it be a module?

Yeh, that may make sense and could use module_function on it. Feel free to add to this PR?

@joshka Travis CI got upset. Can you force push here to kick it off again? Thanks!

I wasn't sure if there was an easy way to force push without making a change, so instead I squashed the commits and rewrote the commit messages. I made no other changes other than this.

Great work here (again) @joshka!


[Question] Cannot find the model library that corresponds to vicuna-v1-7b-q3f16_0

❓ General Questions

I followed the instructions from https://mlc.ai/mlc-llm/ and when I run
mlc_chat_cli --model vicuna-v1-7b-q3f16_0 --device cuda
I get the following error:
Use MLC config: "/home/user/dist/prebuilt/mlc-chat-vicuna-v1-7b-q3f16_0/mlc-chat-config.json"
Use model weights: "/home/user/dist/prebuilt/mlc-chat-vicuna-v1-7b-q3f16_0/ndarray-cache.json"
[11:37:45] /usr/share/miniconda/envs/mlc-llm-build/conda-bld/mlc-chat-cli-nightly-package_1695704758095/work/cpp/cli_main.cc:378: Cannot find the model library that corresponds to `vicuna-v1-7b-q3f16_0`.
We searched over the following possible paths:
- vicuna-v1-7b-q3f16_0
- dist/prebuilt/lib
- dist/vicuna-v1-7b-q3f16_0
- dist/prebuilt/vicuna-v1-7b-q3f16_0
Stack trace:
  [bt] (0) /home/user/miniconda3/envs/mlc-chat-venv/bin/../lib/libtvm_runtime.so(tvm::runtime::Backtrace[abi:cxx11]()+0x27) [0x2aaaab615a47]
  [bt] (1) mlc_chat_cli(+0xd8b8) [0x5555555618b8]
  [bt] (2) mlc_chat_cli(+0x197c9) [0x55555556d7c9]
  [bt] (3) mlc_chat_cli(+0x19d04) [0x55555556dd04]
  [bt] (4) mlc_chat_cli(+0x7cbc) [0x55555555bcbc]
  [bt] (5) /lib64/libc.so.6(__libc_start_main+0xf5) [0x2aaaaba22555]
  [bt] (6) mlc_chat_cli(+0x8035) [0x55555555c035]

Any idea how I can load the model with cuda?
Using:

CUDA Version: 11.4
5 V100s

Was hit by the same thing yesterday, but for OpenCL as I was testing things.
If I'm right to assume, this repo: https://github.com/mlc-ai/binary-mlc-llm-libs contains the library files. And from looks of it, it's missing CUDA (and OpenCL) device target for vicuna model.
If Vulkan isn't an option, try building your own model (it's easy with the docs instructions) or trying another one perhaps?

@DatCaptainHorse got it, thanks for the reply.
Do you know where I can find the documentation to build your own model?

@arif599 Here you go! https://mlc.ai/mlc-llm/docs/compilation/compile_models.html

Hi @arif599,  I have met the same problem on NVIDIA RTX 4090. I tried both to build my own model and download the *.so from https://github.com/mlc-ai/binary-mlc-llm-libs, but I still got the same error. If you have solved the error, could you please tell me how did you fix it? Thank you!

q3f16_0  is now only used for iOS, feel free to check out the latest instructions as well as https://mlc.ai/mlc-llm/docs/compilation/compile_models.html


Git - Odd behaviour reverting git ranges in Working Tree mode

Version 1.66.2
Windows 10
All Extensions disabled
In a git repo try reverting a range with multiple changes in file:

Ranges outside of selected range are modified usually with making copies of function calls, repetitive else statements or repetitive brackets that were not previously there. In this example its adding two function calls with an alternating  tab order.

This is somewhat difficult to reproduce as it happens in only  certain situations that I have not been able to determine is the qualifying condition. I have attached two files before.c and after.c If you commit before.c in a new git repo, then paste after.c after the initial commit. Try and revert the range of the last few lines and you will see the bug occur locally.
EDIT: It appears to have to do with the previous range of changes having whitespace before the function call that was not previously there....
before.c
`
LOCATION_SCREEN_FUNCTIONS
void CustomerScreenRatingUnitsNextScreen(void)
{
if(input->RatingId == 2)
{
CustomerScreenSetInstance(23);
CustomerScreenActivate(D4D_FALSE);
}
else
{
if(input->RatingId <= 52)
{
CustomerScreenEscape();
}
}
}
void CustomerScreenRatingUnitsPreviousScreen(void)
{
//DO NOT SAVE SELECTION
CustomerScreenEscape();
}
#ifdef CONFIG_AUTOTEST
void CustomerScreenRatingUnitsScreenData(json_t* Autotest)
{
AppListSelectScreenSerializeScreenData(Autotest);
}
#endif
asdf
`
after.c
`
LOCATION_SCREEN_FUNCTIONS
void CustomerScreenRatingUnitsNextScreen(void)
{
if(input->RatingId == 2)
{
CustomerScreenSetInstance(23);
CustomerScreenActivate(D4D_FALSE);
}
else
{
if(input->RatingId <= 52)
{
CustomerScreenEscape();
}
}
}
LOCATION_SCREEN_FUNCTIONS
void CustomerScreenRatingUnitsNextScreen(void)
{
if(input->RatingId == 2)
{
CustomerScreenSetInstance(23);
CustomerScreenActivate(D4D_FALSE);
}
else
{
if(input->RatingId <= 52)
{
CustomerScreenEscape();
}
}
}
void CustomerScreenRatingUnitsPreviousScreen(void)
{
//DO NOT SAVE SELECTION
CustomerScreenEscape();
}
#ifdef CONFIG_AUTOTEST
void CustomerScreenRatingUnitsScreenData(json_t* Autotest)
{
AppListSelectScreenSerializeScreenData(Autotest);
}
#endif
`

Apologies for not getting back to you on this until now. In recent days I have pushed some changes that address some of the issues with the "stage/unstage/revert selected ranges" commands. I would really appreciate if you could try the latest VS Code Insiders release (version information below) and would let me know if that resolves the problem. In case you are still able to reproduce the issues I would really appreciate if you could:

See if you are able to reproduce in a simple repository which you could share
Share a recording (https://gifcap.dev) assuming that you are able to consistently reproduce the issue
Let me know if you are invoking the command from a text editor or a diff editor
If you are using a diff editor see if you can reproduce the problem when using the "Revert Selection" command available in the editor gutter.

Version: 1.97.0-insider
Commit: cf2ebd91b8e42e3bc5ab0e85e3323c886a977ffe
Date: 2024-12-18T06:50:13.779Z
Electron: 32.2.6
ElectronBuildId: 10629634
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Darwin arm64 24.2.0


Project governance: Fix voting rule

Which issue(s) this PR fixes:
Fixes #4151
What this PR does / why we need it:
The more contributors there are, the harder it will be to satisfy the current condition (2/3 majority organization vote).
Therefore, this updates the conditions based on the discussion in

#4151

These new conditions refer to Apache Voting Process:

https://www.apache.org/foundation/voting#apache-voting-process

Docs Changes:
Not needed.
Release Note:
Not needed.
Voting:
I would like to propose taking a vote on this fix according to our current governance policy.
The voting rule for this change is not specified, but how about  2/3 organization's votes are sufficient for approval, as usual?
The total number of organizations is 8 and we need at least 6 votes to satisfy the majority of 2/3.

Organizations

@sonots (ZOZO)
@cosmo0920, @edsiper (Calyptia)
@toru-takahashi (Treasure Data)
@ashie, @kenhys, @daipom (ClearCode)

Individual developers

@okkez
@repeatedly
@tagomoris
@fujimotos

Thanks for the reviews!
Now I would like to propose taking a vote on this fix according to our current governance policy.
The voting rule for this change is not specified, but how about  2/3 organization's votes are sufficient for approval, as usual?

I'm still unsure what type of problems will be picked for voting. But "at least 2 weeks" should be shorter than my expectation.
For example, If someone proposed an idea to release Fluentd 2.0 in mid-December, it could get low intention from members in 2 weeks.

@tagomoris Thanks for your feedback!

I'm still unsure what type of problems will be picked for voting.

Same as before on this.

"at least 2 weeks" should be shorter than my expectation.
For example, If someone proposed an idea to release Fluentd 2.0 in mid-December, it could get low intention from members in 2 weeks.

As you say, the appropriate period should vary depending on the topic.
Basically, we will decide on an appropriate period for the topic.
The reason I am suggesting 2 weeks is that this is the minimum period.
This is designed to prevent people from completing their votes too quickly (no time for saying "Wait!").
This doesn't say a decision should be made in two weeks.

For example, If someone proposed an idea to release Fluentd 2.0 in mid-December, it could get low intention from members in 2 weeks.

IMHO we won't start voting until the discussion is over (as we are doing in this PR).
In your example, we never start voting until we get opinions of when Fluentd 2.0 should be released from the each active developers.
Still do you think 2 weeks is too short? If so, how long do you think it's appropriate?

IMHO we won't start voting until the discussion is over (as we are doing in this PR).

I have the same assumption.

If you all have the same assumption (voting will start when ...), the voting rule should contain it.

If you all have the same assumption (voting will start when ...), the voting rule should contain it.

I see, thanks! We'll consider to add such sentence.

@tagomoris Thanks for your review!
How about this? (Line breaks are temporarily inserted for readability.)
 ## Voting

 The Fluentd project employs "organization voting" and "Vetoes" to ensure no single organization can dominate the project.

 For formal votes, a specific statement of what is being voted on should be added to the relevant GitHub issue or PR.
+The start of voting must be clearly declared.
 Maintainers should indicate their yes/no vote on that issue or PR, and after a suitable period of time,
 the votes will be tallied and the outcome noted.

 All the following conditions must be satisfied to approve the formal votes.

 - No effective objection ballot: See Vetoes, below.
 - At least effective __2-organization__ affirmative vote: See Organization Vote, below.
 - At least effective __3-maintainers__ affirmative vote.
 - At least __2-week__ for voting.

+Please note that __2-week__ is merely the minimum period to ensure time for all organizations to say,
+"Wait! We need more discussion!".
+We should have enough period to discuss and vote depending on a topic. We should discuss enough on a topic
+before starting voting.
+

@daipom Not bad, but it doesn't look like the definition of a rule.
I would add items to the list, for example:
  - No effective objection ballot: See Vetoes, below.
  - At least effective __2-organization__ affirmative vote: See Organization Vote, below.
  - At least effective __3-maintainers__ affirmative vote.
+ - An explicitly declared beginning of the term of voting.
  - At least __2-week__ for voting.

+Voting period should begin at a time when all discussion members agree that there are no more points to be discussed. And voting should have a longer period for the decisions with larger impacts.

Hmm, I think the list consists of the conditions to approve the proposal.
It seems to me that An explicitly declared beginning of the term of voting. is a voting procedure, not a condition.
So, I feel something strange adding it to this list.
What do you all think? I would like to hear a wide range of opinions.

It seems to me that An explicitly declared beginning of the term of voting. is a voting procedure, not a condition.

I feel same thing a bit but not so negative for including this.
Because the next item is also about voting procedure:
  - At least __2-week__ for voting.

It seems to me that An explicitly declared beginning of the term of voting. is a voting procedure, not a condition.

I feel same thing a bit but not so negative for including this. Because the next item is also about voting procedure:
  - At least __2-week__ for voting.

Certainly, we can assume this is also about the voting procedure.
(I think it can also be viewed as a condition that must be satisfied by elapsed time during voting, though)
Sorry, my explanation may be inaccurate.
Perhaps the point I felt strange with was the following.
If An explicitly declared beginning of the term of voting.  were not satisfied in advance, the voting would not have begun in the first place.
It seems I was thinking of conditions as conditions that had to be satisfied after starting voting.
I don't think there is any necessity for that (my concept of the list).
I want to prioritize a form that many people will find easy to understand.

Given the points discussed so far, how about rewriting the entire chapter like this?
## Voting

The Fluentd project employs "organization voting" and "Vetoes" to ensure no single organization can dominate the project.

For formal votes, we follow these steps.

1. Have enough period to discuss the topic so that all discussion members agree that there are no more points to be discussed.
2. Add a specific statement of what is being voted on to the relevant GitHub issue or PR.
3. Declare the start of voting.
4. Maintainers indicate their yes/no vote on that issue or PR.
5. Tally the votes and note the outcome after a suitable period.

All the following conditions must be satisfied for the vote to be approved.

- No effective objection ballot: See Vetoes, below.
- At least effective __2-organization__ affirmative vote: See Organization Vote, below.
- At least effective __3-maintainers__ affirmative vote.
- At least __2-week__ for voting.

Please note that __2-week__ is merely the minimum period to ensure time for all organizations to say, "Wait! We need more discussion!".
The more significant the decision's impact is, the longer the period should be.

https://github.com/fluent/fluentd/pull/4160#issuecomment-1553988066
Slightly modified.

I have updated the content of the "Voting" section to https://github.com/fluent/fluentd/pull/4160#issuecomment-1553988066.

@cosmo0920 @tagomoris Could you please confirm the updated contents?


Fix failing 64-bit MSVC AppVeyor build

Addresses #519.
I used the same work around I previously made to get around the rust-rosetta crate failing builds with a 64-bit MSVC configuration.
Recent AppVeyor build failures would've been due to e0e6e54, which adds testing for the coverage crate to the builds.

Coverage decreased (-0.004%) to 59.79% when pulling f8675e8f4cdb8f0e002592094a9bd216df6588aa on miqid:fix/appveyor-coverage-x64 into efe5c72fd0c58c726a9427ca2254a7d12d22f863 on Hoverbear:master.

Thanks for this. Do we want to try enabling the build for 32-bit MSVC in this PR as well? I think rust-crypto might build successfully now.

@euclio, no problem!
I assume you meant the 64-bit GNU Rust flavour for Windows? I was actually thinking of yanking the 32-bit MSVC configuration, because then we'd be left with 64-bit MSVC and 32-bit GNU, which at least touches on both platforms available and the compiler tool chains used. I guess this is really a choice of patience for how it takes to check pull requests.
I did try the 64-bit GNU configuration for AppVeyor, but it's still broken due to some dependencies failing to compile.
Is the coverage failure alright there?

Yep, you're right. No problem with the coverage failure. I'll go ahead and merge. Can you open a separate issue with the description of the failure so we can track it?

@miqid Thanks so much for putting all this work into our Windows compat. :) It's really appreciated.


Maybe, try auto compilation

I'm not sure this will be so awesome as all that, but can at least look at it.

Has been tried, let's see what happens.


Fix underflow in socketAddr::address

With a regression test for issue #1403.
Fixes  #1403

I don't think the solutions differ all that much. Upside to this change is that it keeps the underlying data untouched. Downside is we need to ensure check this run every access, but the same is true for std's check in from_raw.


feat: make upload testable (#494)

1. Description

1.1. Checklist

[ ] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[ ] I have read the Contributor Guide and followed the process outlined for submitting PRs.
[ ] I have updated/added tests for ALL new/updated/fixed functionality.
[ ] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[ ] I have updated/added relevant examples in examples.

1.2. Breaking Change

[ ] Yes, this is a breaking change.
[ ] No, this is not a breaking change.

1.3. Related Issues

Codecov Report

Merging #566 (0d56349) into main (648a561) will increase coverage by 22.03%.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##             main     #566       +/-   ##
===========================================
+ Coverage   64.54%   86.58%   +22.03%
===========================================
  Files         214       10      -204
  Lines        2062      231     -1831
===========================================
- Hits         1331      200     -1131
+ Misses        731       31      -700

see 204 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


act: 0.2.15 -> 0.2.16

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/nektos/act/releases.
meta.description for act is: "Run your GitHub Actions locally"
meta.homepage for act is: "https://github.com/nektos/act"
meta.changelog for act is: "https://github.com/nektos/act/releases/tag/v0.2.16"
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.2.16 with grep in /nix/store/dbfip55m15p3a50vwba56rsanrk0d01h-act-0.2.16

directory tree listing: https://gist.github.com/e0c55e86a72e8db145b948add4adf5c7

du listing: https://gist.github.com/7911c892e1483852297e58d2fa7737ca

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
act

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/dbfip55m15p3a50vwba56rsanrk0d01h-act-0.2.16 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A act https://github.com/r-ryantm/nixpkgs/archive/d379080aa7e02fbdc8be54619a8bbc2a098f2e12.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/dbfip55m15p3a50vwba56rsanrk0d01h-act-0.2.16
ls -la /nix/store/dbfip55m15p3a50vwba56rsanrk0d01h-act-0.2.16/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

act

Maintainer pings
cc @filalex77 @kalbasit for testing.

Result of nixpkgs-review pr 100830 1

1 package built:
- act


How to change selected day in MonthView?

The selected day is always the current day. How can I select (mark) a day by tapping it?

I came up with the following solution:
MonthView(
  cellBuilder: (date, events, isToday, isInMonth) {
    return FilledCell(
      date: date,
      shouldHighlight:
          DateFormat('yyyy-MM-dd').format(date) == DateFormat('yyyy-MM-dd').format(_calendarSelectedDay),  // _calendarSelectedDay is a class variable: DateTime calendarSelectedDay = DateTime.now();
      backgroundColor: isInMonth ? Colors.white : Colors.grey.shade200,
      events: events,
    );
  },
  onCellTap: (events, date) => {
    setState(() {
      calendarSelectedDay = date;
    })
  },
),

Not sure how efficient this is, I'm new to flutter


Open Maps Workbench with basic map

The default layer should be Base Map with OpenSearch Raster Map using road_map.
Make maps_explorer_dashboards independent from maps_legacy.

Done.


"Input type uint16 is not supported" error on sam.generate

thank you for the great work. I am trying to segment RGB from S2_SR. Downloaded tif file:
geemap.ee_export_image(image.select(['B4', 'B3', 'B2']), filename='sr2.tif', scale=10, region=aoi)
added it to map by
m.add_raster(image, layer_name='Images')
and it works fine, tif exists and shows up.
at the stage of
sam.generate(image, mask)
gives me:

TypeError: Input type uint16 is not supported

Yes, SAM only supports uint8 data type. You can convert tye uint16 to uint8 by dividing 65536. In the next samgeo release, I can add the automatic conversion if needed.

If you use geemap.ee_to_geotiff, it will download the map tiles as uint8
https://geemap.org/notebooks/134_ee_to_geotiff/

thanks. For some reasons:

AttributeError: module 'geemap' has no attribute 'ee_to_geotiff'

geemap.update_package()

Thank you.


Evaluation example on the KITTI benchmark

When I try to run the evaluation example for the KITTI benchmark the training procedure starts. Shouldn't this start only the evaluation? It could be that I'm missing something out...
Note: I'm running the code in google colab.

Btw, I added the few lines in the runner.py script, as you suggested in a previous issue, on how to save the dense_points.

Thank you in advance!

Hi, @blukaz , you can run the evaluation code by simply adding a line --test. The current code you are runing is to finetune a pre-train model (on the PCN) to the PCNCars and prepare to test it on the KITTI

Thanks! I got it now... Btw I've wrongly put the code for saving the point in the run_net module, that's why I wasn't getting the points saved when running the evaluation code

In fact, during the evaluation of KITTI, the code will save the dense point cloud as a numpy array to args.experiment_path/vis_result.

Close it since no response. Feel free to re-open it if problems still exist


force-shading source

Hi,
Even after doing mvn package -Dshade-sources to generate the source, I am unable to get the source for force-shading dependency
https://mvnrepository.com/artifact/org.apache.flink/force-shading/1.11.2
Could you help get the source for this ? We need this for Open source clearance purposes.
Regards,
Swapnil

I think the problem is that force-shading does not contain any sources. If you look at the project, then you see that it only contains the pom.xml.

Could you please let me know the purpose of these dependencies ? These are flagged by the open source clearance team, do we need to even include these dependencies in the list to get it cleared ?

The purpose of this dependency is to trigger the execution of Maven's shade plugin that generates the dependency reduced pom file and replaces the scala suffix variable with the proper value. In that sense, I believe that you don't have to clear this dependency.


Redirect to referral path on Login, if it exists

Issue Resolved

Fixes #997

@kylemh I went ahead and took a crack at this, it looks like React Router supports some of what we want to do with little extra work added. Just passing along the pathname of the referring page (the page we were attempting to reach) to the Login component when we first redirect to it, then after logging in is complete, we can redirect back to that pathname.
If you want to hold off on this until New React App is out, that's fine too.