endpoint_list should return an empty list when tagIds is an empty list

when searching for endpoints by tag with an empty tag list (/api/endpoints?tagIds=[]), I think the reasonable result is no endpoint.
The current result is the full list of available endpoints

Well I think that this request would translate to "I want to list all the endpoints without tags" instead.

Well I think that this request would translate to "I want to list all the endpoints without tags" instead.

but then I wouldn't provide the tag ids parameter.

Does this have an impact on the UX/UI for the Edge compute features?
When creating a dynamic group, the endpoint list is dynamically generated by the tags list, so if not tag is listed, you see the full endpoints list. However, we can just not search in this case

but then I wouldn't provide the tag ids parameter.

True, then IMO it make no sense to keep this feature request. It's not really a bug, rather an API design side effect.
We should update the UX of the Edge compute feature to support this design instead of changing the API.


Pilot coverage for unit tests

Discussion: #396
Add job(s) to CI to collect coverage metrics on the unit tests (i.e. tests ran by cargo test in the workspace with no external setup) of all workspace crates that currently exhibit such tests. To get good results, it's suggested to use the cargo-llvm-cov tools.
Goals:

Collect line and region coverage.
Upload results to analyze, preferably using a code-browsing service like codecov.io.

Stretch goals:

Get differential reports and notes on coverage degradation.

Non-goals:

Reach any particular coverage target in process of resolving this issue.

Sounds good! Because the extent to which this does not include e2e tests is dependent on #393, I will simply regard everything run with cargo test currently as valid.

You might have to list specific crates for cargo test. I think currently the workspace also wants to run e2e tests by default, but feel free to feature-gate that.


Multigrid Issue

It looks like we got some compatibility issues with Notifys last commit when utilizing multigrid in nvim GUIs(tested with neovide and nvui).


Support to reference shared and dedicated volumes in terraform plugin

This is related to issue #561.
We are looking to define a manager instance that has BOTH a shared volume (shared with all other managers) and a dedicated volume. How should the volumes be defined and then referenced in the instance definition? Should the volumes be defined in separate files and then referenced (via something like an Attachment) in a flavor plugin?
Any direction would be appreciated!

I personally think Attachment in the SPI still needs better definition and work -- in particular because it reaches outside the boundaries of a group.   So for now, I am inclined to exploit existing primitives to support these requirements as a short-term approach.
What I mean here is that for dedicated volumes -- at least with the terraform plugin -- we can allow the resource definition to be a part of the resource spec for the instance.  Using the scope field, we should be able to designate lifecycle-specific handling of these resources.
Now a globally shared resource is a little harder, because it doesn't make a lot of sense to have its declaration as a part of the instances and their resources (@dedicated or @default)...  Ideally it's best of have a completely separate terraform plugin configuration, as a stand-alone instance plugin, for provisioning just that resource.  To illustrate my point, consider the example below.  Note that there are two sections -- one for the group and one for an instance which just provisions globally referenced resources.
- Plugin: instance-terraform-global-resources # made up name
   Properties:
           # Here we have the specs for the global resources
- Plugin: group
  Properties:
    ID: {{ $groupName }}
    Properties:
      Allocation:
        Size: {{ $size }}
      Flavor:
        Plugin: flavor-vanilla
        Properties:
          Init:
            - apt-get update -y
            - apt-get install wget curl
            - wget -qO- https://get.docker.com | sh
          Tags:
            project: {{ $project }}
      Instance:
        Plugin: instance-terraform
        Properties:
           # Here we have the specs for the instance and its dedicated / default volumes

The spec here makes more sense as global resources are separate from instance dedicated/ default resources.   However, this means that we need to support mixed typed plugin configurations in the array, because up until now, the entire input is assumed to be an array of Group specs.   There are already plans to support this and introduce dependency ordering so that we can provision the global, required resources before we start with the group instances.
What do you think?  Does this seem reasonable to you?

Yes, this makes sense; once #561 is done then we'll be writing out the "global" resources on the Provision of every group member; however, the spec for these resources should not change.
Let's wait and see where #561 lands and then re-visit this.
Thanks @chungers!

Fixed via #https://github.com/docker/infrakit/pull/681


Add All Souls Day to Lithuania

refs #
Sorry, I'm not a python guy, so just adding this via GH UI :)

hey! don't worry, using Github UI is not a crime ;o)
Although you miss a few steps before it being perfectly valid (add tests, changelog, etc). If you're definitely not a Python guy, I could take over your PR (with all credits due)...
Although, if it's possible, could you give me a link/hint on how/why this day has been added to the Lithuania calendar? Is it just for this year, or starting of this year, or since forever?

mmmm as I can see it was decided in 2019: https://www.lrt.lt/en/news-in-english/19/1089741/lithuania-makes-all-souls-day-a-public-holiday
so the question becomes: did November 2nd 2019 a holiday, or will it start in 2020?

It will start in 2020 :)

hey! don't worry, using Github UI is not a crime ;o)
Although you miss a few steps before it being perfectly valid (add tests, changelog, etc). If you're definitely not a Python guy, I could take over your PR (with all credits due)...
Although, if it's possible, could you give me a link/hint on how/why this day has been added to the Lithuania calendar? Is it just for this year, or starting of this year, or since forever?

I'm fine if you will take it over ;)

great! Will work on it ASAP!

Version 10.1.0 with Lithuania's fix is now available:

https://github.com/peopledoc/workalendar/releases/tag/10.1.0
https://pypi.org/project/workalendar/10.1.0/

Happy upgrading!


Rework Forex to use QuoteBars instead of TradeBars.

Forex is currently using TradeBars for its modeling. This works OK for brokerages/assets with tight spreads and fees like EURUSD-fxcm; but other spread based brokerages appear to have 0-fees as the tradebar hides the spread.
We need to rework the fx source data from ticks -> quotebars. This will require a fair bit of work:

Update the source data.
Update the fill modeling to use the spreads.
Update the event handlers we call in the QCAlgorithm.

For backwards compatibility we should also trigger tradebar events. Thankfully in this case the tradebar was fictional anyway so could be built from the midpoint of quote bar OHLC spreads and everything should work almost identically as before.
Indicators using the TradeBars would also need the midpoint hack above. How would we do indicators on QuoteBars cleanly? (Ideally implemented only once somewhere?)
We'll need some way of deprecating the tradebar-fx data; perhaps sending a warning when using OnData(TradeBars data) when user requested fx data. Can we detect when an algorithm has overridden the OnData(TradeBars)? We should also suggest the new event handler pattern with the warning.
OnData(Slice) would be the v3.0 method; or OnData(QuoteBars) would be v2.0 handler.

Work completed by @andrewhart098 in various commits.


Playlists.Get API should allow specifying fields, not force fields to empty list

See #470 and the fix in d73c87440038c463427e173265a36b0a839b769d
As far as I can tell you cannot actually set the Fields property as it's read only.  So it gets forced to an empty list and you get very little back.
I'm trying to update Lidarr to use 6.x but this is currently blocking for me.  Thanks in advance (and apologies if I'm doing something silly)!

The field is readonly, but you can still add fields with model.Fields.Add(...)
Although we may want to change the type to List, which would also allow to do AddRange(otherList)

Although having said that, that's only 4 calls, could be worse.  Thanks again.

In reference to #739, currently I think this setup means everything will be empty unless you explicitly ask for it.  I think it might be more sensible to find a way to not pass through fields unless it's got something in it.  If a user wants everything and has to manually enumerate all the possible fields that's pretty clunky.

I just tested this with the following call, and all fields are populated:
Paging<SimplePlaylist> playlists = await spotify.Playlists.CurrentUsers();
Debug.WriteLine(playlists.Items[0].Name);

Ah I hadn't spotted the #739 was using CurrentUsers.  That one sends a PlaylistCurrentUsers reques that doesn't let you set fields https://github.com/JohnnyCrazy/SpotifyAPI-NET/blob/b400d63087ce0eb78cd73b59a16cfd3fbf4f5907/SpotifyAPI.Web/Models/Request/PlaylistCurrentUsersRequest.cs
I think my concern above would still apply on the Playlists.Get methods, which will default to an empty field list I think.

Haha sorry, I think I must have some other bug in Lidarr causing me grief.  Sorry again for the noise, let me dig into it my side.
PS great work on the library, and (coming from 4.x) it does seem like a big improvement even if I have some wrinkles to work out 😁

No worries, feel free to ask more in a seperate discussion if stuff comes up :)


Update ko_KR.trn

@Nerocat Good hotsan.
To Merger: t477 have typo please fix it before merging.

Sorry, but I can't understand Korean...
Maybe @Nerocat can fix this before we merge?
Or you, @OniOniOn- can correct it after the merge (and we re-merge then)?


rate-limiting-file-schema adds CrudApiPlugin schema

The rate-limiting-file-schema snippet adds schema for the CrudApiPlugin

Good catch, I noticed that this was fixed in #36 so closing as resolved 👍


Update rapidcheck to 2021-12-20.

It updates rapidcheck to 2021-12-20.

What does your PR fix?
Fixes an issue I noted in my previous pull request.

Which triplets are supported/not supported? Have you updated the CI baseline?
Nothing should change, except this new supports using the package compiled with MSVC in Clang.

Does your PR follow the maintainer guide?
Yes.

Yes.

@Som1Lse ,Thanks for your pr, if this pr is ready for review, please let me know.

@JonLiu1993 Yeah, I was waiting for the checks to pass.

Thanks for the update!


Unable to use mongokitten with vapor

I was trying to use MongoKitten in my vapor project:
.Package(url: "https://github.com/OpenKitten/MongoKitten.git", majorVersion: 3)
On running vapor xcode I can see a folder for mongokitten in Packages folder, but it seems the generated xcode project is unable to locate the source files for MongoKitten. Also I notice that in Packages folder, the entry for mongokitten is like mongokitten.git whereas for all other modules it is like module-version. When I tried swift package fetch with just MongoKitten as dependency I am getting the following output:
Cloning https://github.com/OpenKitten/MongoKitten.git Illegal instruction: 4
I am running Swift 3 on Xcode 8.

You can find a simple example here using vapor and Mongokitten.
Do you have some code to share ?

I tried on the vapor template for new project itself. There was no other dependency in the Package.swift file, except for vapor and mongokitten. I also tried the example provided. Running vapor xcode command does not generate a xcode project file. I can see the dependencies downloaded to Package folder, but I think there is some issue there. Without MongoKitten dependency the packages come in folders with name like Vapor-1.3.0, but with MongoKitten it is vapor.git. Could this be the reason for xcode file not being generated?

The illegal instruction is triggered, for some reason. This results in the .git folders not being renamed.
Could you try running swift package generate-xcodeproj? vapor xcode wraps around that function but might add some other stages as well.

Tried that too. Same output. On running swift build command, this is the output I got:
Cloning https://github.com/vapor/mongo-provider.git
HEAD is now at 55b961b Merge pull request #3 from honghaoz/master
Resolved version: 1.1.0
Cloning https://github.com/vapor/mongo-driver.git
HEAD is now at e26a3f1 Merge pull request #30 from vapor/fluent-1.3
Resolved version: 1.0.9
Cloning https://github.com/OpenKitten/MongoKitten.git
Illegal instruction: 4
Running swift package --version gives me this:
Apple Swift Package Manager - Swift 3.0.0 (swiftpm-19)

I don't know why it would matter, but could you try updating to Swift 3.0.1 or 3.0.2? An error like that seems to me like a bug in SPM which is part of Swift. Updating may solve that.

Downloaded Swift 3.0.2 toolchain and used it to fetch dependencies. That seemed to have fixed the issue. As you mentioned, could be something wrong with SPM.
Thanks for your support.


Option to render learned geometry in video rollouts

Note
Creating this PR initially as a comparison from ebianchi/dair_pll -> learned_geom_in_rollouts to ebianchi/dair_pll -> export_friction since these changes rely on the PR with changes in export_friction.  When PR #5 is accepted and merged, the intent is for this PR to be compared with DAIRLab/dair_pll -> main.
Contents
The main aim of this PR is to add in the ability to choose whether rollout videos render the predicted trajectories with the original geometry or with the current learned geometry.  This decision can be toggled via the flag update_geometry_in_videos in the configuration class SupervisedLearningExperimentConfig.
Tangential to this main aim, the following other minor changes are also incorporated:

Some hard-coded file/directory locations (a remnant of PR #3 ) are now implemented in a slightly less hacky way.  This change is included in this PR because this added functionality requires exporting an updated URDF for every toss video generated.  The exported URDF file path from this PR is created in a similar way as the exported video gif file from the prior PR, so it made sense to handle both in a consistent way.
The color of the true system in the rollout videos is now slightly more transparent.  This helped see both the ground truth and the learned system trajectories especially when the learned system geometry is much smaller than the ground truth geometry.
The example script examples/contactnets_simple.py features setting update_geometry_in_videos = True so reviewers can demo this PR feature.

Examples
The following two gifs are of the same ground truth trajectory (in red) with different predicted trajectories (in blue) as the experiment updates the believed object properties.  The geometric updates can be observed in these toss videos.

Closing this PR on this fork and re-creating it on the main DAIRLab/dair_pll repository since cannot change base branch of a PR across forks.


[Bug Report] el-table set highlight-current-row style problem

Element UI version
1.2.8
OS/Browsers version
win10 / chrome 56
Vue version
2.2.6
Reproduction Link
https://jsfiddle.net/n3cn6aqL/
Steps to reproduce
一个表格设置了highlight-current-row和fixed="right", 一个表格设置highlight-current-row
What is Expected?
两个表格的最右边border都显示
What is actually happening?
设置了fixed="right"列的表格的右border消失了

Boiled-down reproduction: https://jsfiddle.net/n3cn6aqL/1/ (two tables and highlight-current-row were irrelevant)
The right border shows up when moving the fixed-right table 1px to the left:

Still, this shouldn't happen since the absolutely positioned child is normally contained inside the relatively positioned parent's padding-box.

测试了最新的 2.1.0 ，已经无法重现：https://jsfiddle.net/n3cn6aqL/2/


Create Divi Extension Issues

Problem Description

1.Please below  the screenshot

i am facing this issues 😔😔

it says it cant find python2.7, did you install it?


style: format code

format the code to meet the pub point 140/140 on pub.dev.

Thank you for your contribution!


⚠ Palworld Tunnel (Connection URL) has degraded performance

In 736495a, Palworld Tunnel (Connection URL) ($PG_PANEL/tstat.txt) experienced degraded performance:

HTTP code: 200
Response time: 32 ms

Resolved: Palworld Tunnel (Connection URL) performance has improved in c5ca0c3 after 1 hour, 2 minutes.


User Story: CAS admin able to sort Operation registration requests

Description:
As a CAS admin, I want to see a list of organization registration requests so that I can approve or deny them
Acceptance Criteria:
Given
When
Then
Development Checklist:

[ ] Checklist item
[ ] Checklist item
[ ] Checklist item
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

·Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:

This is about Operation registration approval. No overlap with #25, but could potentially be overlap with #97.
Sorting would be by Operator, Operation, date submitted, approval status, etc - i.e. sorting within the columns.

Yes, likely overlap with #25. This is sorting by things like first name, last name, operator, etc. - i.e. the column headers.

We're building a component in #26 that does sorting, so if we use that when building the organization page, this ticket may not be necessary

Reiterated during refinement today: May be covered by material UI components since it covers sorting.


License correct?

License is MIT on CF but CC0 in this repo. Which is correct?

MIT is correct, I just updated the repo!


Nested docstring lists

Fixes boto/boto3#310
There were three issues at play:

We were completely disabling newlines when going through lists
Nested lists need to be indented, but the top level list should not be.
The doc strings contain, in some cases, several spaces between the start of an li and the first instance of text. This causes all sorts of problems in rst.

To make things easier, I separated this PR into three commits, one for each of the items above. Item 3 is the trickiest customer, and required a significant change.
Basically, we need to have full context of the lists before we write them so that we can remove vestigial spaces. What I have done here is change the DocStringParser so that it writes to a tree, and then flushes it all out at close. This allows us to do inspections before anything is written.
We could, alternatively, pull in beautifulsoup to generate this tree for us. The advantage would be that it is far more robust, but at the cost of a large dependency that may take more time than our specialized need requires.
Another potential option is to modify ReSTStyle such that it generates a string that is then output to rst, allowing us to apply transformations after generation but before writing. Since this affects more than just doc strings, however, it could result in massive strings being buffered into memory. While we can't be sure of the size of doc strings, they aren't usually more than a few paragraphs.
cc @jamesls @rayluo @kyleknap

It looks good. I like this approach more than modifying the Style classes as the changes are only isolated to how we parse the html docstrings that we receive, which ensures we do not mess up any of the hand generated documentation. I did have a few comments and questions.

Changes:

Moved write into feed
Reset the tree instead of dropping it on close
Removed unnecessary _lstrip function.

Thanks! :ship:


Fixed getting started link in README

Was pointing to a broken page originally...

We're updating the website, so some of the links may have changed. Thanks!

@tjwebb this was updated to point to the new one, yeah.

@SkylerRogers thanks!


fixed issue 4391 by updating idle_wires() in dagcircuit

…over a error in text drawer

Summary
Fixes #4391
Details and comments
Wires that were seen as "idle" were categorized solely based on their length (length was 2) so barriers made wires not idle. This PR fixes that issue by categorizing idle wires as wires who's lengths - the number of barriers is equal to 2.
This fixed the issue with the drawer with the output = 'mpl' but brought up a ValueError when the display was ASCII based. Interestingly enough, if the error was suppressed (using try except) the draw method worked perfectly. This suppression didn't affect any other code as it was specific to the drawing of barriers so it was kept.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I am checking the tasks that my code failed in and it is saying that the only error is a "style and lint" error on line 961 in visualization and  another on line 613 in dagcircuit (whitespace error). However, I did not edit any of these two code sections so I am confused on what the error was on my part. This is my first time contributing to anything on github so I'm sorry if I did something wrong.

1ucian0, thank you for this review. This was my first contribution so I am kind of a noob but now that you have shown me some of my mistakes, I will gladly keep these suggestions in mind for future contributions

@metacubestormerxii12 @1ucian0 do you think we can address the review comments and get this merged?
i would like to include it in the upcoming patch release

Let's wait for @metacubestormerxii12 until tomorrow. Otherwise, I'll hijack the PR so we can do it in time for the release.

My bad guys, I've had some last minute school work to complete

Uh I don't  know why but these checks have been taking hours.

One more request: can we also add instructions that are called "delay" to the idle list? This is to make this a bit future proof as these instructions are being added soon.

I am getting a style/lint error when I say     if barrier_is_idle:
It is outputting error R0123 which is a literal comparison error. However, this is only supposed to apply to non-boolean literal comparisons. Don't know why this error is beign caused but I will work around it

@metacubestormerxii12 I jump in to solve the sytle issues. Contact me on slack or gitter if you prefer to coordinate more synchronously.

One more request: can we also add instructions that are called "delay" to the idle list? This is to make this a bit future proof as these instructions are being added soon.

Let's leave this for a follow up PR. Specially if we backport this one, smaller is better.

I also added a test. This should be good to go. Thanks a lot @metacubestormerxii12 for the contribution and sorry we rush you! Hope to see you around for more coding!

One more request: can we also add instructions that are called "delay" to the idle list? This is to make this a bit future proof as these instructions are being added soon.

Let's leave this for a follow up PR. Specially if we backport this one, smaller is better.

Hmm... considering this, I changed barrier_is_idle=bool for ignore=list(<gate name>) in d5f720d19a1b57ae6cd2cc6d0ccd0c993718a778 to allow a more generic API.

Thank you so much 1ucian0. What is your slack?
and by the way, what did you mean by  "I jump in to solve the sytle issues"?

Thank you so much 1ucian0. What is your slack?

I'm @luciano in qiskit.slack.com

and by the way, what did you mean by "I jump in to solve the sytle issues"?

Oh,. I mean, the lint issue. https://github.com/Qiskit/qiskit-terra/pull/4481/commits/4bf7dc69df7be3a0de33c643770c88254b1ce058


Status Method for Basics 2-8

All basic levels in #238 (bar one) use the same or similar status messages to communicate information about commits in the level.
The status method should be worked on before any of the levels so all levels can use it.
Can configure

Show "Exists" vs Content
Show branch
Show working directory and staging area or not
Potentially more

"Initial commit":
 sahan.txt: Exists
 File 2: Doesn't exist

"Hello world commit" (master):
 sahan.txt: "Hola mundo"
 ben.txt: "Wiggle my toes"

@benthayer Bidoof


chore: make construct hub pretty(ier)

Enable prettier

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

✨

closing this in favor of https://github.com/cdklabs/construct-hub/pull/878


opentoonz: Fix and 1.5 -> 1.7

Description of changes
Fix and bring opentoonz current.

Fix build after https://github.com/nixos/nixpkgs/pull/108496
Changelogs:

https://github.com/opentoonz/opentoonz/releases/tag/v1.6.0
https://github.com/opentoonz/opentoonz/releases/tag/v1.7.0
https://github.com/opentoonz/opentoonz/releases/tag/v1.7.1

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

✔ builds on x86_64 linux when merged into current master, nearly 5 months later


Remove cri-tools on upgrade

cri-tools-1.18 is well installed for new clusters, but
it's incorrectly not removed during the first upgrade for the
caasp 4 to 5 migration.
This should fix it.

ship it !

Needs backporting.


CP-967 Release wGulp 0.8.5

PRs contained in this release:
https://github.com/Workiva/wGulp/pull/158
https://github.com/Workiva/wGulp/pull/161
Diff Between Last Tag and Proposed Release: https://github.com/Workiva/wGulp/compare/0.8.4...Release_0.8.5

+1

CI fail

@trentgrover-wf passing CI

+1

+1

QA Resource Approval: +1

[ ] Dev +1's only needed for Release ticket

Ready for merge and tag.

rosie


Engine V2 build chery-picks

issue_link
https://github.com/flutter/flutter/issues/126296
Commit Hash
fc56c86741c84ff839c11c2788e0f72b7515fdd7, 9420c500a9e58bf60f7af3c54e8639f2320a7882, d9184ce4ffa03a17146bf899532ed02d004f4814,  48536677f7e4765ae5d464a9db5c3020f329fdee, 8eb58b753eafb4610a0927e9b21f288f212a383a, b649d58312ded377ed02d70173c6cb6a85b0fea8, 9322c14c1d59a3c957f34f3f25c9f15b3c5a3016, ee65be7d8fb1345b3eff3505a9e7c8dc66a2f2f7, 59c316ef41c45f2593909ec01032cf0d581922a0, cd989fbc80bf29c295568a5f2c6c00f9f0519b59
Target
beta
pr_link
https://github.com/flutter/engine/pull/41833
Impacted Users
release engineering team
Impact Description
this is a rollout of new builds to align them with the release workflows.
Workaround
N/A
Risk
low
Test Coverage
yes
Validation Steps
Builds tests from the release candidate branches.

In the request you list 10 SHAs, but in the CP PR you link a single commit. Should the rest be CP'd into that PR as well, or do you plan to send more PRs?

That's correct these are the first 3:

https://github.com/flutter/engine/pull/41833
https://github.com/flutter/engine/pull/41841
https://github.com/flutter/engine/pull/41842

Seems like I'll need to send them in batches as some of them depend on each other.

Here is another one:
Here is another one: https://github.com/flutter/engine/pull/41844/files.

I'm marking this as approved. Once we have the new beta ready, we can include this in the first hotfix.

https://github.com/flutter/engine/pull/41914

https://github.com/flutter/engine/pull/41917

https://github.com/flutter/engine/pull/41918

https://github.com/flutter/engine/pull/41921

https://github.com/flutter/engine/pull/41923

https://github.com/flutter/engine/pull/41925

https://flutter-review.googlesource.com/c/recipes/+/44260

https://flutter-review.googlesource.com/c/recipes/+/44261
https://flutter-review.googlesource.com/c/recipes/+/44262
https://flutter-review.googlesource.com/c/recipes/+/44263
https://flutter-review.googlesource.com/c/recipes/+/44221

One more cp for commit fa117aad283ba930a7a79b472843b19e52f543bd is required. I'll send a PR for it in a few mins.

https://flutter-review.googlesource.com/c/recipes/+/44460
https://github.com/flutter/flutter/pull/126598

A few more required CPs:
https://github.com/flutter/engine/commit/0df6740f4ac49d2cb202a4a179facc0dd3e6706b
https://github.com/flutter/engine/commit/46544b1b5c05911ad2ee4edbcb4a197b70d19fec
https://github.com/flutter/engine/commit/9ee91b8bdd1de9db86c3dcfeb463e82ce2bfa1f4
https://github.com/flutter/engine/commit/995cdaaf9e15e5ea308864b9541a674ed6322906
https://github.com/flutter/engine/commit/b2497815adf80a26b67bf2cfd08ad0addad82410
https://github.com/flutter/engine/commit/3b9ff4118eac467d7896a144fb53d2b6006fc4bc

https://github.com/flutter/engine/pull/42005

https://github.com/flutter/engine/pull/42006
https://github.com/flutter/engine/pull/42007
https://github.com/flutter/engine/pull/42008
https://github.com/flutter/engine/pull/42009

https://github.com/flutter/engine/pull/42059

https://github.com/flutter/engine/pull/42067

https://github.com/flutter/engine/pull/42083
https://github.com/flutter/flutter/pull/126973
https://flutter-review.googlesource.com/c/recipes/+/44608

https://flutter-review.googlesource.com/c/recipes/+/44762
https://flutter-review.googlesource.com/c/recipes/+/44724

https://flutter-review.googlesource.com/c/recipes/+/44728


Add Bot API. Register basic bots.

Adds #373
There is a number of other bots in the library (for example MCTS), but they are more complicated to construct from default params, so I left out their registration at the moment.
I reused the GameParameter from games for bots. As pointed out in #335 , it's not a great name, and I think we should rename it to something like Parameter or TypedParameter, and alias it back for backwards compatibility.

Hi @michalsustr
very interesting idea of adding a central bot registry! Considering the bots I've worked with I'd like to propose a slight change in structure and check what you think:
Most of the bots (external to openspiel)  I work with actually take at least a Game (and player_id) in their constructor (and in openspiel at least StatefulRandomBot and MCTSBot also do this) which would be hard to fit into the current code.
So I would propose to augment the 'load_bot' arguments at with a Game& (and maybe player_id) argument:
std::unique_ptr LoadBot(const std::string& bot_name,
const Game& game,
const player_id,
const GameParameters& params)
and also to move the CanPlayGame() method from the Bot to it's factory. So instead of a factory just being a function
returning a bot, I'd make it a class e.g. like:
class BotFactory {
public:
virtual bool CanPlayGame(const Game& game);
virtual std::unique_ptr Create(const Game& game, int player_id, const GameParameters& bot_params);
}
which would also allow to implement BotsThatCanPlayGame without having to work with a 'throwaway_bot'.
Could this work for the usecases you had in mind?

Yes definitely! I will update the PR.

Sorry, I noticed the requested change only now.


Material UI components position and size move/change from default

Bug, feature request, or proposal:
Modal Material UI components position and size moves/changes from default depending on last action they were used in.
What is the expected behavior?
Material UI components size and position should not change depending on last action where material UI component was used in.
What is the current behavior?
Modal Material UI components position and size moves/changes from default depending on last action they were used in.
What are the steps to reproduce?
Providing a StackBlitz reproduction is the best way to share your issue.
StackBlitz starter: https://goo.gl/wwnhMV
I don't have a stackBlitz but I'll see if I can create a basic one later.
Steps
Create a modal material dialog. Set a unique width and height for dialog on one page. Then navigate to another page and set the width and height differently for dialog on that page. Then go back to original page and modal dialog is now the previous width and height and not the original width and height for that modal material dialog.
Create a snackbar that appears from the bottom of the page. Navigate to another page that also uses a snackbar. Show snackbar on second page after hiding a big element, so that the snackbar accidentally moves up across the page. Then go back to original page, the snackbar is shown in the center/pushed up in the same position as the previous page even though it should appear from the bottom on this page (as there is no hidden big element).
What is the use-case or motivation for changing an existing behavior?
Behavior should be consistent across pages and for each individual page. Currently, the modal components change based on last time they were on the page.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular Material 5.2.1
Is there anything else we should know?

Thanks for the detailed issue. Providing a StackBlitz that demonstrates the problem would really help, do you mind creating one? Thanks!

Closing the issue since it's been a while and there's no example. It can be reopened if we get more info.


API for adding problem to problem sets

Cannot find API to add problem to problem sets

will be added in #56


Enabling/Disabling Kserve breaks modelmesh reconciliation in RHODS 2.4

/kind bug
What steps did you take and what happened:
After Enabling/Disabling Kserve, modelmesh will be unable to reconcile through the DSC because of an error caused by the inferenceservice CRD
Component reconciliation failed:
        CustomResourceDefinition.apiextensions.k8s.io
        "inferenceservices.serving.kserve.io" is invalid:
        [spec.conversion.strategy: Required value,
        spec.conversion.webhookClientConfig: Forbidden: should not be set when
        strategy is not set to Webhook]

Deleting the MutatingWebHook does not seem to fix this, however if one manually edits the YAML of the InferenceService CRD to remove the spec.conversion block it appears to be fixed and modelmesh can then reconcile again.
However this probably breaks Kserve (if enabled/reenabled later on)
What did you expect to happen:
What's the InferenceService yaml:
[To help us debug please run kubectl get isvc $name -n $namespace -oyaml and paste the output]
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:

Istio Version:
Knative Version:
KServe Version:
Kubeflow version:
Open Data Hub version:
Deployment Environment:[cloud (aws|gcp|ibm|azure), on prem, edge ]
OpenShift version: (use kubectl version):
OS (e.g. from /etc/os-release):

related PR: https://github.com/opendatahub-io/kserve/pull/120. Unsure if that one covers the issue here.

Closing as resolved, since I'm no longer observing this issue in 2.5.

Closing as resolved, since I'm no longer observing this issue in 2.5.

@israel-hdez Reconciliation seems to be fixed, however the overall issue is still present and tracked here: RHOAIENG-908


How we can use indexes for the return Navigate.To(By));

Hi,
I've bumped into some problems that I cannot solve by myself.
Is there a way how I can use this expression:
return Find.Elements(By.CssSelector(SomeSelector)).ElementAt(0).Click();

for my interaction method throughout the pages:
        public GeneraPage GoToSomePage(string testLink)
        {
            return Navigate.To<GeneraPage >(By.CssSelector(SelectorCss + testLink+ "']"));
        }

I mean that I need to chose an element by index (because there are two or more elements on the page and I don't have a unique one) and go to an appropriate page. I know that there is no possibility to write like that:
       public GeneralPage GoToSomePage(string testLink)
       {
           return Navigate.To<GeneraPage >(By.CssSelector(SelectorCss + testLink+ "']")).ElementAt(0);
       }

How to rewrite this method properly?
Thanks a lot for suggestions!

Can you append :nth-child(0) to the css selector?

Yes, you are right, it is one way how to do it, thanks. Actually, I managed to find a unique selector for my element.
But anyway, I guess, there is not possibility to rewrite method "GoToSomePage" using .ElementAt(0) in that construction? (return Navigate.To(By.CssSelector(SelectorCss + testLink+ "']")).ElementAt(0);)

Yeah - I don't think so. You need to pass a By expression to NAvigate.To that will return a single item.


IEEE 488.2-2004:8.4.1

When I send two or more query commands in a single packet like this:
*OPC?;SYST:ERR?
my Agilent 34401A returns all responses in the single line separated by semicolon:
1;0, "No error"
It is possible to implement this in scpi-parser? Currently command responses are separated by a new line.

I will look at this. It will be nice feature.
Nevertheless, I think that standard forbids this at all but I must investigate it little bit.

According to the standard, it is possible to call multiple Queries at once.
Multiple responses from one command should be separated by "," which is already done.
Multiple responses should be separated by  - ";" - this will be implemented.

Great fix, thank you!


Plugin error from gemelli:    "['sample-id'] not found in axis"

Hi,
Please ignore if is not easy to follow as this is my first issue on this forum.
Files used for this analysis
Archive.zip
I am performing 16s rRNA analysis through qiime2. I want to study the longitudinal distribution of features over the period of sample collection (sampling-day). In my metadata file, I have 'sample-id' as first column however
when I run the following command for gemelli analysis
qiime gemelli ctf --i-table lab_wise_analysis/bacteriology/bacteriology_table.qza --m-sample-metadata-file lab_wise_analysis/bacteriology/metadata_bacteriology.tsv --m-feature-metadata-file taxonomy.qza --p-state-column sampling-day --p-individual-id-column sample-id --output-dir lab_wise_analysis/bacteriology/CTF-results-GEMELLI
it gives me following error:
Plugin error from gemelli:
"['sample-id'] not found in axis"
Debug info has been saved to /var/folders/31/7jhpcwd91kq6rmrbrjdqtvm40000gn/T/qiime2-q2cli-err-3f1eij0c.log
When I view the debug info, it says
_Traceback (most recent call last):
File "/Users/pridelab/opt/miniconda3/envs/qiime2-2021.4/lib/python3.8/site-packages/q2cli/commands.py", line 329, in call
results = action(**arguments)
File "", line 2, in ctf
File "/Users/pridelab/opt/miniconda3/envs/qiime2-2021.4/lib/python3.8/site-packages/qiime2/sdk/action.py", line 244, in bound_callable
outputs = self.callable_executor(scope, callable_args,
File "/Users/pridelab/opt/miniconda3/envs/qiime2-2021.4/lib/python3.8/site-packages/qiime2/sdk/action.py", line 390, in callable_executor
output_views = self._callable(**view_args)
File "/Users/pridelab/opt/miniconda3/envs/qiime2-2021.4/lib/python3.8/site-packages/gemelli/ctf.py", line 30, in ctf
state_ordn, ord_res, dists, straj, ftraj = ctf_helper(table,
File "/Users/pridelab/opt/miniconda3/envs/qiime2-2021.4/lib/python3.8/site-packages/gemelli/ctf.py", line 71, in ctf_helper
all_sample_metadata = sample_metadata.drop(keep_cols, axis=1)
File "/Users/pridelab/opt/miniconda3/envs/qiime2-2021.4/lib/python3.8/site-packages/pandas/core/frame.py", line 4308, in drop
return super().drop(
File "/Users/pridelab/opt/miniconda3/envs/qiime2-2021.4/lib/python3.8/site-packages/pandas/core/generic.py", line 4153, in drop
obj = obj._drop_axis(labels, axis, level=level, errors=errors)
File "/Users/pridelab/opt/miniconda3/envs/qiime2-2021.4/lib/python3.8/site-packages/pandas/core/generic.py", line 4188, in _drop_axis
new_axis = axis.drop(labels, errors=errors)
File "/Users/pridelab/opt/miniconda3/envs/qiime2-2021.4/lib/python3.8/site-packages/pandas/core/indexes/base.py", line 5591, in drop
raise KeyError(f"{labels[mask]} not found in axis")

KeyError: "['sample-id'] not found in axis"_
Could someone please help as I am a beginner in this field.
Thank you

Thank you so much @ElDeveloper for responding so quickly to my issue. I used lab-location as the  --p-individual-id-column and it fixed the issue. I did not added an additional column such as individual-id and it still worked.
Regarding, GEMELLI suitability for my dataset, I have multiple samples collected from each sampling site: bench, floor and sink over a period of time (day/dates). That's the reason I wanted to study the microbial diversity over the period of sampling dates/day using a longitudinal analysis tool such as Gemelli .
As I have mentioned above, I am new to this field and still trying to learn things so might be completely wrong on this.
Thank you,
Govind

Hi Govind, if lab-location worked, then I think you should be good to go! Your setup makes a lot of sense. Closing this issue for now.


[Improvement][server] need to support two parameters related to task

Describe the question
When I'm using the shell task ,I need the instance id of task and the absolute path of task.
What are the current deficiencies and the benefits of improvement
Which version of DolphinScheduler:
-[dev]
Describe alternatives you've considered

+1
good idea


Updated composer.json to allow usage with symfony 3.x

Thanks @LeeSaferite! Merged and tagged v1.2.0


[AutoPR] cognitiveservices/data-plane/ImageSearch

Created to accumulate context: cognitiveservices/data-plane/ImageSearch

(message created by the CI based on PR content)


chore(main): release 1.0.0

:robot: I have created a release beep boop
1.0.0 (2024-03-05)
Features

ci: add a release-please gh action (#2) (b25181b)
ci: add linter for PR title validation (#1) (c877d2b)

Bug Fixes

update the message (#5) (48f3465)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/jbdoumenjou/poc-changelog/releases/tag/v1.0.0 :sunflower:


out of date doc for DataSetIterator @ idosi.com?

joachimdb 21:03
Quick question: anything up with DataSetIterator in nd4j? I find the doc at http://idosi.com/javadoc/DL4J/org/nd4j/linalg/dataset/api/iterator/DataSetIterator.html, but not at http://nd4j.org/apidocs/org/nd4j/linalg/dataset/api/iterator/DataSetIterator.html
agibsonccc 21:04
@joachimdb please use nd4j.org
the idosi stuff is out of date
thanks for flagging that
mind filing an issue?

The link changed:
http://nd4j.org/doc/org/nd4j/linalg/dataset/api/iterator/DataSetIterator.html


Exceptions From Workers Get Reported As Toasts

Current Implementation
Currently, the app opens a Toast, if any worker encounters an exception of any type. This can be an issue if the app is in the background, and a worker gets into an error state. Then the user gets a Toast message, possibly completely out of context due to currently being in another app. Example:
https://github.com/corona-warn-app/cwa-app-android/blob/43412bdabe128dc674ec8a9ef8baa80d37292a3a/Corona-Warn-App/src/main/java/de/rki/coronawarnapp/worker/DiagnosisKeyRetrievalPeriodicWorker.kt#L37
In addition to that, a technical message is shown, as the Throwable localizedmessage is used for the text.
Suggested Enhancement
If the user really needs to have information about these kind of errors, the user should get a notification with a human readable error text. This could be implemented by making use of the enum class ExceptionCategory, which is already in place. In our eyes it would only make sense to notify the user, if the user can change the situation to the good.
Expected Benefits
The user does not get disturbed during the usage of the mobile phone, especially when working in other apps. Also the user could decide if the error needs attention from the users side.
Best Regards
Robert Jakobs & Tim Brüggenthies (@timbrueggenthies)

Dear @Magoli1 ,
thank you for mentioning this!
At the moment, we do not have a finalized concept regarding error handling how, and which kind of messages will be displayed to the user. As soon as this is settled, we will include proper messaging and replace toasts when appropriate!
I will pin this issue as others might stumble across the error handling concept in its current state as well, it will be closed once we have it resolved. We will also add it to the list of known issues.
Thank you and best,
Marc

So coming back to the issue - as we now have error handling with proper dialogs in place I am closing this for now.
If you find any inconsistencies or have other sugggestions regarding error handling in general, please let us know :)
Thanks and best,
Marc


Remote Inspector doesn't populate certain node types in double precision build

Godot version
master v4.0.alpha.custom_build (f21a62b62)
System information
Windows 10
Issue description
When the engine is built with double precision (float = "64"), certain nodes will stop working with the remote inspector. Selecting these nodes in the remote scene tree will not populate the inspector, nor will the inspector be cleared if it was already populated by another node's properties.
Here is a non-exhaustive list of node types that are affected:
Node2D
Node3D
Control
SkeletonIK3D
CanvasLayer

Not all node types are affected by the issue. Some continue to work properly with the inspector, such as the base Node class, Timer, and WorldEnvironment.
Video example:
All node types seem to work fine with the remote inspector when the engine is built with single precision floats.
Steps to reproduce

Build the engine with the build option float = "64"
Create a new project.
Add any of the affected node types to the scene tree.
Play the scene and try to select any of the affected nodes.

Minimal reproduction project
Remote Inspector Double Precision Bug.zip

cc @aaronfranke


let engine own SessionHandler to get rid of server [skip ci]

Android, iOS and Web cannot use the C-S architecture as-is. The core part of server is SessionHandler. Let MozcEngine own it so server is not needed.
mozc_client is a simplified version of client/client, which keeps all APIs used by fcitx and discards those not used.
mozc_connection is not needed as well.

Please create a shim layer and make it a compile time switch.


Add docstrings for exported functions

Also move out of the eval loop some CatArray methods, as it's more
logical that way and we need to add the docstring only once.
I wouldn't mind a review, especially from a native speaker.
Cc: @alyst

Current coverage is 83.14% (diff: 100%)

Merging #27 into master will increase coverage by 0.24%

@@             master        #27   diff @@
==========================================
  Files             7          7
  Lines           351        356     +5
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            291        296     +5
  Misses           60         60
  Partials          0          0

Powered by Codecov. Last update cecdfb5...80fcc8e


Avoid IFileService cyclic dependencies

There is IConfigurationService.acquireFileService() and IThemeService.acquireFileService() which hides the fact that we have cyclic service dependencies that we should avoid
//cc @aeschli

This happened.

Sorry, only the file service is now created early on, but the configuration service still needs to adopt that.


Emit extensions with fatalError'ing static properties

Since https://github.com/tristanlabelle/swift-winrt/commit/eb9f8a78e2ca7285b60b4f270ac9b2f3c501eeab , properties are defined as extensions in terms of their getter/setters, but this is currently only the case for instance properties.

Fixed as of https://github.com/tristanlabelle/swift-winrt/commit/77fc77d6ea834e3dd732ab3a9ffb63b16722e8a3


shimv2: support runtime config path via annotation

So that user can have per pod runtime config which is easier
to manage in some cases.
Fixes: #2332

/test

@grahamwhaley yes, let me try to fix the doc as well.

@grahamwhaley fyi, https://github.com/kata-containers/documentation/pull/576

/test

@jodh-intel CI added.


Documentation

@xoofx, thanks for this incredible library.
I'm using it in one of my own projects, and I noticed that you've been intending to write full documentation but life and other projects keep getting in the way.
Is this something you want help with?  I'm currently motivated to try to understand the library for my own use and writing documentation is something I don't mind doing.  I'd be happy to start laying out some of the documentation (especially on the parser side) if you'd be available to review it and answer some general questions about how the library is laid out as they come up.
I'm also not offended if this is something you'd prefer to do yourself.

Here's an example of one of my own projects from a few years ago that keeps getting buried under other priorities if you want to see an example of my writing:
https://github.com/mattj23/InteractiveReadLine

Is this something you want help with?

Definitely! 🙂
You can create markdown files under a root doc folder. I plan to push a website at some point with them that will integrate also a generated API Reference. So it's very welcome.


Compile errors

I followed your tutorial and added swifter xcode project to my project, but I am getting 151 compilation errors saying - swift compilation error in the SwifteriOS xcode project.
I also tried to build swifteriOS project as it is and get the same compile errors.

Here's the current link to add a custom app scheme to an iOS app in an app in Xcode
https://developer.apple.com/documentation/uikit/inter-process_communication/allowing_apps_and_websites_to_link_to_your_content/defining_a_custom_url_scheme_for_your_app
For the iOS target, go to "Info" tab and then "URL Types" section.


Vertical divider appears to be rendering incorrectly in Chrome

See documentation
https://react.semantic-ui.com/elements/divider#divider-example-vertical

Dupe, this is an issue Semantic UI and Chrome.  There is a deep-seated history. See #1544 for more info and workaround.

Thanks @levithomason

Sure thing!


polygon interpolation

Is there a beta build for using polygon interpolation? If yes, can anyone tell how to use it?

Similar request: https://github.com/opencv/cvat/issues/824

@vishal-wiai , currently we have a concept/prototype and verified that it works but need to invest time to release. Thus you cannot find the feature in a release.


Store the function call with the function response

With OpenAI, when functions are called, there is a response for each function call. We store these as messages in the conversation.messages history. When we do this, one thing that is tricky about parsing the response is knowing which function this response is from.
OpenAI gives us back a tool_call_id so if you look at the preceding message in the conversation history you can use this to match it up and see which tool/function that was. But this is a little tricky within the context of a single message.
So, this PR improves matters by populating the content_tool_calls attribute on response messages.
To summarize:

OpenAI gives us back a tool_calls JSON block which indicates what tools it wants to call. This is an array since it can be multiple calls.
We call those tools and create! a new message for each response from the tool calls, and we now populate the tool_calls attribute for each of these responses so that it's easy to see what call this is a response to.

Thoughts on why this PR is causing the system test failure on main?
bin/rails test test/system/conversations/messages/images_test.rb:88

@drnic It's actually not that PR, I did a bunch of git reverts and re-applying and I narrowed it down to a different PR that @jlvallelonga was working on #532. I'm going to start a discussion on that one.


Is it possible to create a helix? 🧬 (modeling screws)

For modeling threads, it would be great to ‘rsweep’ the thread profile (trapezoidal or V shaped) in such a way that it rotates multiple times and gains height, then combine that with a cylinder to form a screw.

Is a helical rsweep possible today in truck? If not so, may I kindly ask a feature request?

Well, we have a plan, but we are still struggling with it. In the end, we have to make a decision somewhere.
Implementing a spiral structure with NURBS results in an approximation, so we should create a specific structure for spiral, but it cannot be directly output that structure to STEP.

Understood, thank you for the reply!
I wonder if a naive implementation could be a specific structure which, as the u/v parameter along the spiral increases, the returned curve/vector (in ‘ParametricCurve’ methods) translates proportionally in the direction of the spiral. I do not understand all of the traits to know where this won’t work however.


feat(postman): support generating Postman collections with many nested levels

:tada: This PR is included in version 1.7.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


ESP32-S3 Code and Data Relocation Support

Describe the bug
The code and data relocation feature (https://docs.zephyrproject.org/latest/kernel/code-relocation.html ) does not work for ESP32-S3 (and likely other Xtensa ESP chips) due to the default.ld segment names including an underscore ('_') and the lack of including linker_relocate.ld in the default.ld as is done for riscv, cortex_m, and cortex_a architectures.
For example, trying this on ESP32-S3:
prj.conf
CONFIG_CODE_DATA_RELOCATION=y
CMakeLists.txt
zephyr_code_relocate(LIBRARY drivers__sensor LOCATION ext_ram_seg)
Doing a build results in the error:
Memory region:  ext_ram_seg|COPY
Traceback (most recent call last):
  File "/zephyrproject/zephyr/scripts/build/gen_relocate_app.py", line 614, in <module>
    main()
  File "/zephyrproject/zephyr/scripts/build/gen_relocate_app.py", line 594, in main
    sections_by_category = assign_to_correct_mem_region(memory_type, full_list_of_sections)
  File "/zephyrproject/zephyr/scripts/build/gen_relocate_app.py", line 284, in assign_to_correct_mem_region
    mpu_align[memory_region] = int(align_size)
ValueError: invalid literal for int() with base 10: 'ram_seg|COPY'
ninja: build stopped: subcommand failed.

The root cause is that the tool has a naming convention of using an underscore '_' to separate the segment name from one or more section names.
https://docs.zephyrproject.org/latest/kernel/code-relocation.html
As a work-around, the relocation can be done manually by adding an extra linker descriptor file:
CMakeLists.txt
zephyr_linker_sources(SECTIONS custom-sections.ld)
custom-sections.ld
SECTION_DATA_PROLOGUE(_CUSTOM_SECTION_NAME2,,)
{
	. = ALIGN(4);
	__custom_section_start = .;
	KEEP(*(".custom_section.*"));
	__custom_section_end = ALIGN(4);
} GROUP_DATA_LINK_IN(RAMABLE_REGION, ROMABLE_REGION)

One user posted this workaround in Discord:  https://discord.com/channels/720317445772017664/883444902971727882/1173967050805346384
Impact
Failure of the code and data relocation support requiring work-arounds.

The cleanup bot strikes again.  It would be good to get this cleaned up and into the v3.7 release, although it is lower priority than other Espressif tasks at the moment.

Retested with 3.6.99 and this is still an issue.

The external RAM (SPIRAM) is also currently broken and is being tracked as https://github.com/zephyrproject-rtos/zephyr/issues/74284

re-opened as per @EricNRS request

@sylvioalves - any chance we can get this issue resolved in the current cleanup efforts?

Commenting to keep this issue open.

Easy there stalebot, perfection takes time.  Let's keep this issue open.


Release 2022.11.XX

@bendnorman @cmgosnell Your two small PRs: #2079 & #2091 seem like they could conceivably be merged in here before the release... do we want to risk that? Or not?

Okay I've merged in @bendnorman's logging standardization, and am holding off on the 860m for the moment. Was thinking I would kick off the nightly build job.


Boundaries

@navjotk. @mlange05 , @ggorman
Gerard told me you wanted some insight on the boundaries for higher order stencils. The way it is currently implemented in the notebook is the easiest possible (even if slightly more expensive than complex ones).
The idea is, if you have a stencil of order n (n+1 ponts) you add n/2 ghost nodes after your boundary that you never update, it is just there to let you compute your stencil at the limit of the domain.
This is why for my second order implementation, the loops in space go from 1 to nx-2, nodes 0 and nx-1 are just there to make the computation easy.
I hope it helped, let me know if you find it a bit obscure

Hi @mloubout , could you provide an example for how the code would change for a higher order stencil? This would help remove some of our doubts regarding the boundary conditions and make the code more general.

Hi @navjotk
For a stencil of ordre 4 ([x-2h x-h x x+h x+2h])
for i in range(1,nx-1)
......
becomes
for i in range(2,nx-2)
......
and same for y
PS : you can change xmin = -1000 - 12*hstep if you want to keep the number of points in the absorbing layer the same


UTC_OFFSET_FORMAT: use const blocks around function calls

Implicit promotion (where &expr terms implicitly create a new constant with value expr and a borrow with lifetime 'static to such a constant) has a long and troubled history. Right now we are in a state that's at least reasonably well-behaved, but it does make for some rather strange behaviors, as is tracked in https://github.com/rust-lang/rust/issues/124328. I wanted to do a crater experiment to see just how much code out there relies on this, by making rustc do longer do promotion of function calls, and it turns out not even cargo builds any more then. :joy:
The crate that failed to build is time. So I wonder if it would be okay to patch time to make it work under this more strict, more sane promotion regime. The main point in the new regime is to use explicit const { ... } blocks to make things into constants, instead of doing that implicitly.
Landing this will raise the MSRV to 1.79. I realize it's too early to do that under your MSRV policy. 1.81 will be released tomorrow so then it would be covered by the policy, but I'm also completely fine with delaying this until later.  I'm in no rush here. :)

Strange, when I format this file I get a diff in unrelated parts of the file... I'll have to manually only format the part that I changed then.

Also to be clear, this code will not be rejected on the current edition ever. If we do any kind of change here, it will be over an edition. But it would still be interesting to know just how wide-spread this pattern is -- last time we tried this, several years ago, it was only 2 or 3  crates that were affected.

Would the same behavior result if using separate const items rather than inline const? That would avoid the need for an MSRV bump (which would actually need to wait another 12 weeks as it's an internal change).

Strange, when I format this file I get a diff in unrelated parts of the file... I'll have to manually only format the part that I changed then.

Try cargo +nightly fmt — a number of options are used that aren't stable, and that may be the cause of that.

Also to be clear, this code will not be rejected on the current edition ever. If we do any kind of change here, it will be over an edition. But it would still be interesting to know just how wide-spread this pattern is -- last time we tried this, several years ago, it was only 2 or 3 crates that were affected.

As the primary intent here is to get a crater run, is it possible to apply a patch (in Cargo.toml) to cargo? It seems like that would solve the issue without a release. Given RustConf prep, I probably won't get around to a release for at least another week.

Would the same behavior result if using separate const items rather than inline const? That would avoid the need for an MSRV bump (which would actually need to wait another 12 weeks as it's an internal change).

Ah I see. Yes using const items is also possible, just a bit less nice.

As the primary intent here is to get a crater run, is it possible to apply a patch (in Cargo.toml) to cargo?

Cargo is a submodule, so it can't be easily patched from the rustc repo. Also that crater run would then show tons of failures from time-rs failing.
As I said I am in no rush here, waiting a few weeks is fine.

Ah I see. Yes using const items is also possible, just a bit less nice.

Let's do that for the time being. It would avoid the MSRV update and having to wait another 12 weeks to be permitted to do it (per policy). Feel free to include a TODO saying to use inline const once able.

Cargo is a submodule, so it can't be easily patched from the rustc repo. Also that crater run would then show tons of failures from time-rs failing.

I considered the latter but am not familiar with the inner workings of crater.

As I said I am in no rush here, waiting a few weeks is fine.

Sounds good. With the requested update, I might be able to get it out this weekend (or Monday) depending on if I have time to review the changes since the most recent release.

Done :)

Thanks!


✨ add BMI calculator

Description
Add BMI Calculator
Fixes #5
Replace issue_no with the issue number which is fixed in this PR
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have created a helpful and easy to understand README.md
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

Mention Screenshot of output in README

Mention Screenshot of output in README

In the Main repo readme or specific project's readme?

I have updated the app and built it using React and Tailwindcss now. I've added the screenshot in the main 'Bundli-Frontend' Readme and have created a Readme for the project itself.

@shvam0000 Resolve Conflict

@shvam0000 Resolve Conflict

Done, please check once


Httptools a new Httpparser with Uvloop

this is not an Issue but rather a request for  Httptools support with Uvloop.
Uvloop is in 0.13.dev0, I ran a simple bench on it and its way faster then gevent.
will httptools with uvloop and asyncio be integrated into bottle python3+?

HttpTools+Uvloop+Wsgi #940

Your performance benefits should be mostly attributes to httptools, since the gevent server adapter is written in python and httptools is a C extension. Did you compare it to uWSGI?
A solid WSGI adapter for asyncio based event loops would be nice, and httptools is a great library to speed up raw HTTP parsing performance, but please note that this stack won't solve the 10K problem (which is the main benefit of gevent, by the way). WSGI was designed as a synchronous protocol. Reading from enciron['wsgi.input'] is expected to block and there is no standard way around that. WSGI does not know about coroutines and has no way to yield and wait for events from an event loop.  So sum it up: WSGI is thread-bound. 10K clients require 10K threads. This does not mix well with the single-thread never-block approach of asyncio.

@defnull  Apologies for the late reply, so i did a test against Uwsgi and the httptools intergration was still faster by upto 5-15% gain on static content . However when testing it against a DB backend (RethinkDB) HttpTools Integration seems to fail miserably while UWSGI becomes much faster. Not sure why this happens tho.


germplasm.collection should be an array, not a single value

a germplams can belong to several collecitons


Discord Webhook Response - 400

Attempted Debugging

[X] I have read the debugging page

Searched GitHub Issues

[X] I have searched GitHub for the issue.

Describe the Scenario
Would like some help determining why my Discord webhook for Bookstack is 400'ing from the endpoint. As far as I know my Docker-Compose.yml of the Bookstack container is not experiencing any connection issues.
Exact BookStack Version
BookStack v22.06.2
Log Content
No response
PHP Version
No response
Hosting Environment
Ubuntu 22.04 Jammy Jellyfish, installed with Docker version 20.10.17, build 100c701 and docker-compose version 1.29.2, build unknown.

Hi @mpadvisory, Are you posting to the slack compatible webhook endpoint?

Hi @mpadvisory, Are you posting to the slack compatible webhook endpoint?

I have copied the Discord API webhook endpoint, hopefully it is the correct one. For example, the last webhook attempted was: https://discord.com/api/webhooks/1001121069937201202/lfnXAd1JlIscyerDlV_NpiBgRZJm_fK-ItmApJRbogATDrBhqY_oqYhNIdJD3v82K4fY

@mpadvisory Try adding /slack to the end of that.

@mpadvisory Try adding /slack to the end of that.

That worked! Thank you ssddanbrown!


Ocean Protocol's LegalTech Bounty

Ocean Protocol's LegalTech Bounty
Reward - 18,000 OCEAN tokens (approx. 1000 EUR)
Goal
Extend the potential of the Web3 w.r.t legal data implementations or legal compliance using Ocean Protocol
Bounty Basics
Objective of the bounty:
Successful implementation of Ocean Protocol for a legal-data marketplace or tool to support legally-compliant engagement with Ocean data marketplaces. "Legal data" is defined as any data relevant to the legal industry, including the court system, law firms, contextual data that informs legal decisions, and more.
Duration of the bounty:
The bounty kicked off during Berlin LegalTech Conference 2020, 28 February, and runs for one month. Submissions will close 28 March, 2020.
Bounty Payout:
This bounty is for the equivalent of 18,000 OCEAN tokens
How to Submit
Submit your project's github link in Gitcoin. Your project README should have -

"Ocean Protocol's LegalTech Bounty Submission"
project name and information of team members
Summary explaining
(1) what your project does
(2) how you built it
(3) how to run the POC
(4) what parts of the Ocean tech stack you used
(5) what programming languages and tools you used
(6) why your submission addresses the prompt

Intro
Ocean Protocol is an open source project built to empower the Web 3 Data Economy, the ecosystem of data providers, contributors, processors, vendors and purchasers that extract, access, aggregate and distribute data while deriving value from it.
Ocean is looking to incentives the creation of an ecosystem of decentralised data exchanges (e.g. data marketplaces) that provide a point of discoverability and comparison for data, along with indicators of quality and scope to enable broad access to data that would otherwise prove difficult to publish or consume.
Where Data Marketplaces intersect with Legal Tech
As we explore these data marketplace implementations two points of intersection with the Legal Tech sphere emerge:
• Marketplaces for legal industry data
• Tools for legally compliant operations of data marketplaces
What type of LegalTech implementations and integrations could you build?
For inspiration consider:

looking at how Ocean could work in an Ethereum #DeFi context to create legally-compliant stablecoins, debt, insurance against collateralised datasets etc.

linking Ocean Protocol users to an identity service such as Uport, Estonia E-residency and social media

creating a simple flow for legally-compliant data asset licensing

creating a GDPR-compliant interface for accessing and sharing data assets

creating data wallet (holding users data endpoints) to hold data relevant to legal research and decision-making, such as court decisions, contextual data and raw materials

interface to empower data commons, incorporating data from sources like "legal aid organizations, courts, legal technology companies, and others to enable research and development that promotes access to justice" (see The Key Models for a Legal Data Commons)

marketplaces for data related to the legal industry and its processes such as law firm management and hiring, case management and practitioner qualifications

Again, these are just examples so let your imagination be as wide as an ocean and show us what you got!
Submission Requirements
To qualify for prizes and challenge rewards, participants must abide by all of the rules and minimum submission requirements:

Your submission must demonstrate a successful use of Ocean Protocol.

Ocean Protocol team must be able to view your submission and run the code.

Your submission should have a working code and not just concept

Examples and reference projects
Docs: Quickstart
Docs: Set Up a Marketplace
Tutorial: Ocean React App
Our recent Data Economy Challenge Submissions
Seen this problem before?
Any help solving this is welcome. Feel free to leave any comments and help someone else to solve it. We might airdrop tokens to someone even if not directly completing bounty.
Things to know
The bounty lifecycle process including payout will be managed using Gitcoin
Questions and Help
Non-technical Questions
Reach out to us<EMAIL_ADDRESS>for all your non-tech related queries including questions about this bounty and submissions.
Technical Questions
For discussion about technical questions, we recommend to join also our Gitter channel where our tech community and core developers are available to answer your tech related questions.
Help with OCEAN tokens
In order to see the OCEAN balance in your wallet you'll need to reference the related token contract with address 0x985dd3d42de1e256d09e1c10f112bccb8015ad41. If you use a Metamask plugin you'll find the the exact steps here.

@innoprenuer just to confirm, is it mandatory to wait till the 28th of March, to make a submission or I can do it as soon as I finish working on this issue?

@mul1sh as discussed earlier, you can submit as soon as you want to as long as it fulfils submission criteria and bounty objective.

Please Note - Winner will be decided after the submission deadline has passed. Only best submission (if many) wins the bounty.

@innoprenuer ok thanks got it

@innoprenuer Sorry I had to take down my submission because of a tough UI bug which i'm currently working on. Is it possible to give me till latest Thursday to fix this and then I'll have it back up and running for you to test?

I'll continue fine tuning my solution for this bounty as agreed @innoprenuer till I get it done in less than a week 🙂

@innoprenuer, this task seems to be for one person. Make it open if you need more people to work on it. Thanks

Hi @iamonuwa thanks for your interest for this bounty. But this bounty is expired. We do have another active bounty with higher reward and almost a month to submit. Please check out - https://explorer.bounties.network/bounty/3941


chore(DIA-629): retire AREnableNewTermsAndConditions for real

This PR resolves DIA-629
Description

This PR removes AREnableNewTermsAndConditions for real.
It also suppresses some ESLint errors in the bidding registration test suite.

PR Checklist

[ ] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Deprecated AREnableNewTermsAndConditions feature flag

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Dev changes (Deprecated AREnableNewTermsAndConditions feature flag - iskounen)

  Generated by :no_entry_sign: dangerJS against 5fe6610b2721f45904c5663976f95b56374dea1a


⚠ Bofrost.de has degraded performance

In 93f39a4, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1590 ms

Resolved: Bofrost.de performance has improved in 718aa87.


Fix #83 | Add a sample GitHub Workflow section to docs.

Fixes #83, unless I understood the intention of the issue creator wrong. :)

Nevermind, I guess they mean that there should be repository for a custom Github Action :D
I misunderstood their intention @rikatz

I mean we could make a custom Github Action and upload that to the marketplace, so that ppl can directly use the tool in their Github Workflow, but I guess this also is enough for others to write their workflows.

Great :) I’ll take a look into this tomorrow. I’m not sure how to write GH Action and put in Marketplace (I know how to use them :P) but that’s a nice idea.

@ig0rsky sorry for being late into this, I'm with some parallel activities consuming all my spare time. Will take a look into the PR ASAP :)

@ig0rsky Thank you very much for the contribution!
I've left another review, about using the latest version instead of a pinned one.
It works like a charm, I've made some tests here: https://github.com/rikatz/pug-tests/runs/1018853600?check_suite_focus=true
I would create an entire section about GH Actions, as in my example I'm not a Helm user but still could use it with some small modifications :)
Again, thank you very much again

Oh and I wont take as much time again to review, was on a rush this last month in the job. So don't worry, this will get merged fast now :)

@ig0rsky made just a small comment, it seems that the url to download the binary is missing a part :)

Thinking about merging this and correcting the typo in master :D

@ig0rsky friendly ping :D

sry mate, forgot to fix the typo :D

LGTM
Thank you very much.


Solutions to exercise 3.13/14 missing.

The solution to Exercise 3.13/14 is missing, which I find quite important since this is also a nice recap of chapter 2.7.

I would love to use this for my final project, which is offering solutions to exercise 3.13/14! I was wondering if this would still be helpful and if you would consider accepting a pull request?

Yes, please that would be terrific!!!

Well, I think this will help. I found my solution but I'm not sure whether my answer is right.
https://www.khanacademy.org/science/physics/forces-newtons-laws/normal-contact-force/v/more-on-normal-force-shoe-on-wall

It will be still very nice if the Exercise will come in the The Nature of Code repository :panda_face:


[Bug] Random predictions pattern after multiple zero-shot predictions

If running multiple times Novae in zero-shot mode, the hierarchical clustering is not updated, and then the predictions look chaotic.

This is fixed and will be in the next release, i.e. novae==0.2.2


Panic in jdevelop/gpio

Hello,
Sorry for opening issue here, but it's related to jdevelop/gpio fork where I can't open one.
Sometimes gpio lib is panicking due to null in watchEventCallbacks while using rf522:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x5e815528]

goroutine 56 [running]:
github.com/jdevelop/gpio.setupEpoll.func1()
        /go/pkg/mod/github.com/jdevelop/gpio@v0.0.0-20180116031910-0e2cc992019a/gpio_linux.go:81 +0x13c
created by github.com/jdevelop/gpio.setupEpoll
        /go/pkg/mod/github.com/jdevelop/gpio@v0.0.0-20180116031910-0e2cc992019a/gpio_linux.go:67 +0x5c

I would assume that's because Wait was called meanwhile and IrqPin.EndWatch triggers deletion from the map. Maybe it makes sense to mutex it?

Yep, just got another one with more context
fatal error: concurrent map read and map write

goroutine 45 [running]:
runtime.throw(0x5e99decd, 0x21)
        /usr/local/go/src/runtime/panic.go:608 +0x64 fp=0x185f6a0 sp=0x185f68c pc=0x5e8c8220
runtime.mapaccess2_fast32(0x5e9f7f10, 0x157a200, 0xb, 0x10, 0xffffffff)
        /usr/local/go/src/runtime/map_fast32.go:61 +0x1b4 fp=0x185f6b0 sp=0x185f6a0 pc=0x5e8ab310
github.com/jdevelop/gpio.setupEpoll.func1()
        /go/pkg/mod/github.com/jdevelop/gpio@v0.0.0-20180116031910-0e2cc992019a/gpio_linux.go:80 +0x128 fp=0x185f7ec sp=0x185f6b0 pc=0x5e98e514
runtime.goexit()
        /usr/local/go/src/runtime/asm_arm.s:867 +0x4 fp=0x185f7ec sp=0x185f7ec pc=0x23fbc0
created by github.com/jdevelop/gpio.setupEpoll
        /go/pkg/mod/github.com/jdevelop/gpio@v0.0.0-20180116031910-0e2cc992019a/gpio_linux.go:67 +0x5c

I would rather suggest to give it a try for periph
It does work fine with Raspberry Pi Zero / Zero W and has more robust support for IRQ events.


Fix tests

Hi @dschaller
Here are some changes which should help get the tests to pass on your PR that's here: https://github.com/saltstack/salt/pull/30979
If you merge this into your branch then it should automatically update your SaltStack PR and then I can get it merged over there. Thanks!

@cachedout thanks for this! I'll merge it in now. :D


[SelectUnstyled] Export additional types to make customization easier

Improved types of SelectUnstyled, MultiSelectUnstyled and their related hooks and dependencies (button and listbox):

Exported types for ownerState
Exported types for get*Props functions returned from hooks
Exported types of props accepted by each slot component
Renamed *Props.ts files to *.types.ts as they contain much more than just props.

Closes #30870
I'm going to go through all other remaining components in separate PRs.

The PR touches more components than the SelectUnstyled, should we change the title?


Float issue

I got an issue for the file pgsql_big_dedupe_example.py. Line 117, it says "'float' object cannot be interpreted as an integer".
More details :
File "", line 1, in
dedupe.Dedupe(fields, num_cores=4)
File "/Applications/anaconda/lib/python3.5/site-packages/dedupe/api.py", line 181, in init
super(DedupeMatching, self).init(*args, **kwargs)
File "/Applications/anaconda/lib/python3.5/site-packages/dedupe/api.py", line 627, in init
self.data_model = datamodel.DataModel(variable_definition)
File "/Applications/anaconda/lib/python3.5/site-packages/dedupe/datamodel.py", line 23, in init
primary_fields, variables = typifyFields(fields)
File "/Applications/anaconda/lib/python3.5/site-packages/dedupe/datamodel.py", line 158, in typifyFields
field_object = field_class(definition)
File "/Applications/anaconda/lib/python3.5/site-packages/dedupe/variables/categorical_type.py", line 23, in init
self.comparator = CategoricalComparator(categories)
File "/Applications/anaconda/lib/python3.5/site-packages/categorical/categorical.py", line 20, in init
response = responseVector(i, vector_length)
File "/Applications/anaconda/lib/python3.5/site-packages/categorical/categorical.py", line 44, in responseVector
response = numpy.zeros(vector_length)

I just pushed a new version of dedupe to pypi, download it and this should fix your problem. https://pypi.python.org/pypi/dedupe

You also need to upgrade https://pypi.python.org/pypi/categorical-distance


Organizations Admin page action buttons don't follow layout of rest of site

On the Organizations Admin page, the edit button is on the far right of the grid while the rest of the site has an action button as the first column with the edit buttons in it.

I can take this one


Do not raise

Motivation
See the screenshot:

When calling page.current_path it raises a UnhandledAlertError. There is nowhere the spinach handles the exceptions so the hooks broke and no report is written into XML file (when using jUnit report formatter). That means the result report will say no failures. It makes debug very hard

I went back and forth to think should I handle from spinach or from this gem. I could handle it from spinach, however spinach has no context on how to handle the exceptions. In this gem there is not a very good way to take screenshots when current_path raises so I can accept in this situation no screenshot is taken.
Please let me know your thoughts, thanks you

@mattheworiordan Thanks for the comments. They are all good advice. I made the first commit 5b5f44d to address all your comments. Then I went ahead and made another commit 5f450cfc066e91ca1e774c16e5eb2c4598862950 to print a warning message when page.current_path is empty.
When I am at it, I made the third commit 131977f8bda35932f049602c59407927a0c06157 to print out warning if save_html and save_screenshot raise. And when save_html fails I allow save_screenshot to continue so that we may have one output anyway.
Please let me know your thoughts. I am totally fine if you don't like the latest 2 commits.
Thanks!

Thanks @ywen, small bit of feedback on 5f450cf though

@mattheworiordan The 2 new comments you have are linked: to be able to print out only one warning message. I used the block approach. When the page.current_path raises the block is not called at all so no warning message is printed within those.
I add one more commit to add one more test to describe this.
Thanks!

Thanks @ywen, good to merge :)

@mattheworiordan Thank you for quick response! If it is convenient would you please release a new version, or you would like to wait a little longer since you just did one 4 days ago? Thanks again.

v1.0.17 is now released

Thank you!


⚠ Bofrost.be has degraded performance

In 4bbd36c, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1626 ms

Resolved: Bofrost.be performance has improved in fb6ddb9 after 9 minutes.


Allow for Isotope filters to be applied as links

Feature Request
Is your feature request related to a problem? Please describe.
Right now it's not possible to share a link to a page using the portfolio widget with a filter already applied.
Describe the solution you'd like
Allow for Isotope filters to be applied as links, as documented here.
Describe alternatives you've considered
None.
Additional context
There's an example here.

Just found this code that could be re-used for this: https://github.com/wowchemy/wowchemy-hugo-modules/blob/master/wowchemy/assets/js/wowchemy.js#L167

Should this issue be labeled as Good First Issue?
We are doing research about how to help newcomers onboarding in an open source project and how to accelerate the issue resolving process.
We have developed a tool to automatically label the Good First Issue (GFI), i.e., the issue which is good for newcomers.
We first extract 72 features from different dimensions of issue reports, such as readability, semantic meaning, associated code snippets, etc, and experimentally investigate to what extent these features correlate with GFI. Results turn out that a large portion of these features do have a medium to large correlation with GFI.
We then build a machine learning model based on these features to predict GFI. The experiments on a dataset of 12k issues from Github show that 0.90 AUC can be achieved.
Our tool shows that this issue has a very large possibility to be a GFI.
Could you please tell us whether it should be labeled as a GFI?
And if you have any comments or suggestions with this tool, could you please tell us?
Thank you so much.

Still interested in this

I'm still interested in this but have not enough knowledge to properly implement it. I will try to take a deeper look at it.

I'm still interested in this but have not enough knowledge to properly implement it. I will try to take a deeper look at it.

Still interested.

Still interested


chore: bdd-nh-1585746186 to 0.0.1

chore: Promote bdd-nh-1585746186 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[DISCUSSION] EOL of 4.0.x early 2018 ?

I would like to propose that we declare netty 4.0.x as EOL at the beginning of the second quarter of 2018. This will also give users a bit of time to migrate to 4.1.
The main reason for this is that I think people should just upgrade to 4.1 as everything that is in 4.0 is also in 4.1 + a lot of improvements and new features.
Any thoughts on this ?

@trustin @carl-mastrangelo @ejona86 @Scottmitch @johnou @jasontedor @jasontedor @mosesn @doom369 @johnou @NiteshKant @cconroy @fenik17 @ldaley @olim7t @olix0r @vietj @smaldini @slandelle @trustin

@zsxwing

Thanks for the heads up! We are on the 4.1.x series so this does not impact us.

We are also on the 4.1.x version, so no problem for us.

All green on my side :)

All green on my side :)

+1

@tjake also ping

we're on 4.1.x too.

+1
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=icon
Virus-free.
www.avast.com
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=link
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
On Fri, Nov 24, 2017 at 2:23 PM, Moses Nakamura<EMAIL_ADDRESS>wrote:

we're on 4.1.x too.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/netty/netty/issues/7439#issuecomment-346902088, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAErroS3oMznvE_Pevnjkz1GcKpq4WNGks5s50HwgaJpZM4QqF9z
.

--
Stéphane

+1

Cheers for the heads up! We are on 4.1.x too.

:+1:

Yes, also links from http://netty.io/wiki/index.html to http://netty.io/4.1/xref/io/netty/example/spdy/server/package-summary.html should be removed or io.netty.example.spdy.server should be changed to io.netty.example.http2.server (web browser support for spdy was removed 1.5 years ago)

@jasobrown

Apache Cassandra's next major release is already on 4.1, so all good on that front. Thanks for checking in on us!

@mrniko

@kuujo

I do agree and also want to note migration to 4.1 doesn't take much time.

+1

we don't need releases of Netty 4.0.x anymore , thanks for caring !

@normanmaurer we're still on 4.0 but since 4.1 is also jdk 6 compat I don't see any reason why we can't upgrade.

Also @jroper as I think you may use it for play still.

👍 we're moving to 4.1 in our next major release.

We are on 4.1

:+1: That'll be ~2 years after the release of 4.1.

Play is on Netty 4.1, thumbs up from me.

I don't see any objections. Sounds like most are already running 4.1, or is at least not opposed to upgrading to 4.0.
@trustin - Any objection?

@rkapsi

@jchambers ^^

No objections. 👍

Seems legit. We've fielded support requests on a few occasions where somebody had a dependency conflict between 4.0 and 4.1 (we use the latter), so I'll go beyond "no objection" and say I'm actually looking forward to this ;)

Same, no objections.

@normanmaurer I tried to upgrade Netty for Spark in https://github.com/apache/spark/pull/19829. However, one of Spark dependencies, Apache Arrow, is depending on Netty 4.0.x API: io/netty/util/collection/IntObjectMap$Entry. I created a ticket for Apache Arrow and will push them to upgrade ASAP: https://issues.apache.org/jira/browse/ARROW-1864. As we need to wait for Arrow community, I think we probably cannot make it happen in the next Spark release (it's happening in December).
If we miss the December train, we probably will not release any version for a long time. Could you please defer the deprecation till end of 2018 so that we have enough time to deliver it a Spark with Netty 4.1.x before 4.0.x EOF?

@zsxwing let me see what exactly is the problem... and come back to you.

@normanmaurer I saw io/netty/util/collection/IntObjectMap$Entry was renamed to io/netty/util/collection/IntObjectMap$PrimitiveEntry  in 4.1.x.

@zsxwing ouch you are right... And I can not fix this without introduce another issue for current 4.1 users.

@zsxwing if you're not releasing a new version, won't it be OK to not be on the latest netty version?

@zsxwing if you're not releasing a new version, won't it be OK to not be on the latest netty version?

@mosesn Yeah. However, if there is any serious security issue in Netty, Spark still needs to make a new release. In this case, we hope we can get a new 4.0.x release. In general, we just need security fixes and don't need any new features or small bug fixes right now.

@zsxwing What if Spark isn't alone in the classloader and your users also use any of the libraries mentioned in this thread, which will soon require Netty 4.1? If you become the minority, you'll have to provide a version with shaded/translated Netty binaries.

@zsxwing also I think it should be kind of trivial to upgrade Avro to 4.1.

@normanmaurer, you can add @Deprecated interface Entry extends PrimitiveEntry {} and then make the internal implementation implement Entry. I only see Entry being returned, never provided, so that can be safe.

@ejona86 I think this will not work as we return Iterator while in 4.0 we returned Iterator.

@zsxwing maybe this can be a good opportunity to start releasing spark more frequently?  I don't think it's fair to ask the netty project to delay for an entire year because your release cadence is annual.
If you really can't change your release frequency, I think you should be prepared to publish your own 4.0.x release if there's a security update you need.

@mosesn we actually do frequent maintenance releases to deliver bug fixes. But since upgrading Netty from 4.0.x to 4.1.x is an incompatible change, we must do it in a feature release which has half a year release cycle.
Anyway, I'm pushing Arrow to upgrade Netty now. Can we defer the decision for one month? We may be able to upgrade Netty and catch the next Spark release.

+1

@normanmaurer +1 from my side. Spark has updated to 4.1.x!

+1 Xitrum updated Netty to 4.1.x 2 years ago

FYI 4.0 is EOL. The previous release was the "last" release see http://netty.io/news/2018/01/22/4-0-55-Final-4-1-20-Final.html

Hi Team,
I am working with Apache Drill Project. Till now we have been using Netty 4.0.48.Final. And, now while upgrading Netty from 4.0.x.Final to 4.1.x.Final below error is coming while running the project.
Error - Details: java.lang.AbstractMethodError: io.netty.buffer.ByteBuf.touch(Ljava/lang/Object;)Lio/netty/buffer/ByteBuf;
Can someone suggest the possible changes/changelist in Netty 4.1.x that is causing above error.
Thanks & Regards,
Alka

@alkakumari42 are you sure you not bring in another version of netty ? This looks like a version mismatch honestly.

@normanmaurer Thanks for replying. I don't think I am using 2 different versions of Netty together. If you don't mind have a look of the jars that I am actually using in my classpath. Maybe there is some jar that also need up-gradation with Netty.
antlr-runtime-3.5.2.jar
commons-lang3-3.3.2.jar
commons-logging-1.2.jar
commons-codec-1.10.jar
protobuf-java-3.6.1.jar
jackson-annotations-2.10.1.jar
jackson-core-2.10.1.jar
jackson-databind-2.10.1.jar
jackson-core-asl-1.9.13.jar
jackson-mapper-asl-1.9.13.jar
javassist-3.24.0-GA.jar
joda-time-2.9.9.jar
log4j-1.2.17.jar
metrics-core-4.0.2.jar
metrics-jvm-4.0.2.jar
reflections-0.9.10.jar
slf4j-api-1.7.25.jar
config-1.2.1.jar
zookeeper-3.4.11.jar
hadoop-common-3.2.1.jar
hadoop-auth-3.2.1.jar
drill-common-1.17.0.jar
drill-hive-exec-shaded-1.17.0.jar
drill-java-exec-1.17.0.jar
drill-logical-1.17.0.jar
drill-memory-base-1.17.0.jar
drill-protocol-1.17.0.jar
drill-rpc-1.17.0.jar
vector-1.17.0.jar
drill-shaded-guava-23.0.jar
junit-4.12.jar
hppc-0.7.1.jar
commons-collections-3.2.2.jar
commons-configuration-1.6.jar
metrics-jmx-4.0.2.jar
commons-configuration2-2.1.1.jar
stax2-api-3.1.4.jar
woodstox-core-5.0.3.jar
guava-29.0-jre.jar
curator-client-4.3.0.jar
curator-framework-4.3.0.jar
curator-recipes-4.3.0.jar
curator-x-discovery-4.3.0.jar
netty-transport-4.1.50.Final.jar
netty-resolver-4.1.50.Final.jar (Not required with 4.0.48.Final)
netty-handler-4.1.50.Final.jar
netty-common-4.1.50.Final.jar
netty-codec-4.1.50.Final.jar
netty-buffer-4.1.50.Final.jar

@alkakumari42 this looks ok... as long as none of the jar's include netty itself in the jar. Can you please open a new issue and add the full error stack etc there ?

@normanmaurer Actually there is 2 aspect of this issue.
1.) That I have discussed earlier - Here I build Apache Drill opensource project with Netty 4.0.48.Final but, using 4.1.x.Final in my classpath.
(Only below error is coming - No stackTrace)
Error Details : org.apache.drill.exec.rpc.RpcException: java.lang.AbstractMethodError: io.netty.buffer.ByteBuf.touch(Ljava/lang/Object;)Lio/netty/buffer/ByteBuf;
2.)Second case,  Before doing MVN build for Apache Drill opensource I am changing the Netty version from 4.0.48.Final to 4.1.50.Final.
Build is failing saying - (
..\MapWithOrdinal.java:[132,104] error: wrong number of type arguments; required 2
..\MapWithOrdinal.java:[134,41] error: wrong number of type arguments; required 2
And, error is coming in below method (At IntObjectMap.Entry)
(https://github.com/apache/drill/blob/1.13.0/common/src/main/java/org/apache/drill/common/collections/MapWithOrdinal.java)
@Override     public Collection<V> values() {       return Lists.newArrayList(Iterables.transform(secondary.entries(), new Function<IntObjectMap.Entry<V>, V>() {         @Override         public V apply(IntObjectMap.Entry<V> entry) {           return Preconditions.checkNotNull(entry).value();         }       }));     }
And, this build is working with 4.0.48.Final Netty but, failing with 4.1.x.Final Netty. That's why I am bringing this issue as well before raising any issue in netty.

@alkakumari42 ah yeah... Unfortunally we did break the IntObjectMap API (and missed it) which means you will need to adjust the code to match the new signature.

Hi @normanmaurer , Could you share the changelist no for the same?
I got IntObjectMap.java in 4.0 but, the same is not implemented in 4.1. Instead it's implemented as template.
It will be great if you could share the issue no.

Hi @normanmaurer , Could you share the changelist no for the same?
I got IntObjectMap.java in 4.0 but, the same is not implemented in 4.1. Instead it's implemented as template.
It will be great if you could share the issue no.

https://github.com/netty/netty/pull/3576/files
It's generated when you run the compile mojo (generate-sources).


jib-maven-plugin should be marked as threadsafe

Maven complains when using the jib-maven-plugin with multiple threads (mvn -T2).
[WARNING] *****************************************************************
[WARNING] * Your build is requesting parallel execution, but project      *
[WARNING] * contains the following plugin(s) that have goals not marked   *
[WARNING] * as @threadSafe to support parallel building.                  *
[WARNING] * While this /may/ work fine, please look for plugin updates    *
[WARNING] * and/or request plugins be made thread-safe.                   *
[WARNING] * If reporting an issue, report it against the plugin in        *
[WARNING] * question, not against maven-core                              *
[WARNING] *****************************************************************

Our Maven goals should be marked as threadsafe=true.

Although jib is thread-safe, it should be smarter.
Jib doesn't currently lock the base image cache when downloading a base image, but instead downloads into a temporary directory and then attempts to moves the downloaded image into place.  There is no locking to block other threads.  So a Maven project with N modules that build images using the same base image (like gcr.io/distroless/java) may result in N simultaneous pulls of the same image.  Maybe we should provide a component to centralize downloading images?