App crashes when trying to change a title in favourites

add clip to favourites
select 'Edit Title'
Result: the app crashes (see the report in attachment)
The issue can't be reproduced in 100% of cases but I get it around 2 times out of 5 tries.

Clipdinger-782-debug-23-05-2016-21-52-29.zip

I think I found the bug. It crashes if there isn't a favourite selected, when the "Edit title" is invoked. That shouldn't be easily possible, because you do that from a context menu on that favourite... I could emulate with sending the message via "hey".
Until I've fixed the bug, try to make sure you have a favourite selected when editing its title... :)
Thanks!

Fixed with 4088d455115ed84dfd89ee8699e27b6374af689a.


[WIP] Add data from API to About modal

Adds data from API to About modal. Thanks @himdel for crash course in SSUI :)
Works with https://github.com/ManageIQ/manageiq-ui-self_service/pull/119
@AparnaKarve please have a look, thanks :)

@ZitaNemeckova This looks really great for the first pass 👍
Like we discussed earlier, we preferably -
a)  do not want to reference  ng-controller in the html
b) do not want to use$scope in the controller code.
So how about we add a few more commits in this PR to achieve that? 😄
/cc @himdel

@ZitaNemeckova Great progress!
The last 2 commits are exactly what I was looking for.
I'm more or less OK with the implementation so far, but maybe we should strive for consistency now.
... and by that I mean if you look at other components that act as directives/controllers in client/app/components, you'll see that they -
a) do not make the .controller() call
b) only make the .directive() call
c) They have 2 main ngInject-able functions one for the directive code and the other for the controller code
Can you add a commit that will do the above?
Thanks.

Check list items in https://github.com/ManageIQ/manageiq-ui-self_service/pull/119 need to be addressed as well.

@ZitaNemeckova ping

@miq-bot remove_label wip
@AparnaKarve please review :)

@AllenBW thanks for review it was really helpful :) All your comments should be addressed.

@ZitaNemeckova looks like also a conflict and a code climate problem.

Nice job @ZitaNemeckova !!!

@chriskacerguis Thank you :)

Euwe Backport conflict:
$ git cherry-pick -e -x -m 1 66af10e
error: could not apply 66af10e... Merge pull request #127 from ZitaNemeckova/about_modal
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

$ git status
On branch euwe
Your branch is up-to-date with 'upstream/euwe'.
You are currently cherry-picking commit 66af10e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:

	new file:   client/app/components/about-modal/about-modal.controller.js
	new file:   client/app/components/about-modal/about-modal.html
	modified:   client/app/layouts/_application.sass
	modified:   client/app/layouts/application.html
	modified:   client/app/services/language.service.js
	new file:   client/app/services/server-info.service.js
	modified:   client/app/states/login/login.state.js
	new file:   client/assets/images/bg-modal-about-pf.png
	modified:   client/index.html

Unmerged paths:
  (use "git add <file>..." to mark resolution)

	both modified:   client/app/config/authorization.config.js

$ git diff

diff --cc client/app/config/authorization.config.js
index d14a88c,9f0ad21..0000000
--- a/client/app/config/authorization.config.js
+++ b/client/app/config/authorization.config.js
@@@ -57,10 -57,10 +57,17 @@@
    }

    /** @ngInject */
++<<<<<<< HEAD
 +  function init($rootScope, $state, Session, $sessionStorage, logger, Language) {
 +    $rootScope.$on('$stateChangeStart', changeStart);
 +    $rootScope.$on('$stateChangeError', changeError);
 +    $rootScope.$on('$stateChangeSuccess', changeSuccess);
++=======
+   function init($rootScope, $state, Session, $sessionStorage, logger, Language, ServerInfo) {
+     var unregisterStart = $rootScope.$on('$stateChangeStart', changeStart);
+     var unregisterError = $rootScope.$on('$stateChangeError', changeError);
+     var unregisterSuccess = $rootScope.$on('$stateChangeSuccess', changeSuccess);
++>>>>>>> 66af10e... Merge pull request #127 from ZitaNemeckova/about_modal

      function changeStart(event, toState, toParams, fromState, fromParams) {
        if (toState.data && !toState.data.requireUser) {

@ZitaNemeckova @chriskacerguis Please resolve git conflict locally, make PR against euwe branch and assign that PR to me.

Oh hai, i can get on this @ZitaNemeckova @chriskacerguis

Backported to Euwe via https://github.com/ManageIQ/manageiq-ui-self_service/pull/205


training model request

Hi, we are taking some experiments in different text guided image manipulation models. To be fair, could you provide your fine-tuned training model checkpoint file?

Hi @laxyon, you can access the pre-trained weights in https://www.dropbox.com/sh/zr3i7k6xz0z435r/AABHfV5BN5Uz8sIXZuqspHZua?dl=0

thank you so much


How can I extract color of the typography in component?

Our Heading component contains typography inside it, and the color of the typography is being changed directly, rather than through the component's own props.
So, I want to extract the color value of the typography. How can I do that?

component structure

typography in component

Code Connect CLI version: 1.1.2

Operating system: Mac OS 13.5.2

Hey @jongjunpark, right now this is not possible, you can only access components props and text content. I'll raise this for discussion with the team as I can see there are cases like yours where direct access to design props might be useful.

Adding in here, this would be useful for getting the color for icons.


report: Genome download overview table header is wrongly formated

The Genome download overview table in the report has a problem with the header line. The information is correct but the column labels are shifted to the right by one. This should be fixed.

Should be resolved


Closable issues

https://github.com/nficano/pytube/issues/564 -- I believe this issue should be closed because it's a user-implementation issue that probably stemmed from the pytube/pytube3 thing. Original reporter didn't provide additional details, and other folks in the thread were mostly able to fix their issues.
KeyError 'cipher' issues that got resolved:
https://github.com/nficano/pytube/issues/641
https://github.com/nficano/pytube/issues/642
https://github.com/nficano/pytube/issues/652
https://github.com/nficano/pytube/issues/661
Fixed in pytube3:
https://github.com/nficano/pytube/issues/446
cc: @RONNCC
(also, if you see this first, please take a peek in the PRs, I've got 2 ready to be merged)

@tfdahlin  thanks!

closed issues
merged one pr,  commented on the other

@RONNCC responded to your comment in that other PR

Oh, another issue that can be closed:
https://github.com/nficano/pytube/issues/777

done @tfdahlin


Alma staging reindex log with many invalid locations

sample from the log:
It might be comparing them to an old location list.
Look into the traject log to identify where it is coming from.
2021-03-26T14:17:35+00:00 ERROR<PHONE_NUMBER>313506421 - Invalid Location Code: rare$ex
2021-03-26T14:17:35+00:00 ERROR<PHONE_NUMBER>103506421 - Missing holdings
2021-03-26T14:17:35+00:00 ERROR<PHONE_NUMBER>303506421 - Missing holdings
2021-03-26T14:17:35+00:00 ERROR<PHONE_NUMBER>103506421 - Invalid Location Code: rare$ex
2021-03-26T14:17:35+00:00 ERROR<PHONE_NUMBER>303506421 - Invalid Location Code: rare$w
2021-03-26T14:17:35+00:00 ERROR<PHONE_NUMBER>653506421 - Missing holdings
2021-03-26T14:17:35+00:00 ERROR<PHONE_NUMBER>773506421 - Missing holdings
2021-03-26T14:17:35+00:00 ERROR<PHONE_NUMBER>653506421 - Invalid Location Code: annex$princeton
2021-03-26T14:17:35+00:00 ERROR<PHONE_NUMBER>773506421 - Invalid Location Code: rare$w
2021-03-26T14:17:35+00:00 ERROR<PHONE_NUMBER>963506421 - Missing holdings
2021-03-26T14:17:35+00:00 ERROR<PHONE_NUMBER>883506421 - Missing holdings
2021-03-26T14:17:35+00:00 ERROR<PHONE_NUMBER>963506421 - Invalid Location Code: rare$gax
2021-03-26T14:17:35+00:00 ERROR<PHONE_NUMBER>883506421 - Invalid Location Code: annex$princeton
2021-03-26T14:17:35+00:00 ERROR<PHONE_NUMBER>903506421 - Missing holdings
2021-03-26T14:17:35+00:00 ERROR<PHONE_NUMBER>073506421 - Missing holdings
2021-03-26T14:17:35+00:00 ERROR<PHONE_NUMBER>903506421 - Invalid Location Code: rare$exl
2021-03-26T14:17:35+00:00 ERROR<PHONE_NUMBER>073506421 - Invalid Location Code: rare$ex

Looked into the indexed records and cancelled the reindex. There is no Library facet and no locations are inxded.

For some reason the holding_library.rb file didn't have the new recap codes from Alma.I deployed again the code and the file is there.

When I deployed the code today, after I cancelled the index, I noticed that it will not create the holding_library.rb.
I'm creating it now by running the generate_from_templates in the console however I'm opening a new issue so that we have it copied from the template when we deploy the code.

When I ran the full reindex the record does not have the holdings1_disply field.
If I enter the rails console and index the same mms_id from there the record will have the holdings1_display.
example is this record https://catalog-alma-qa.princeton.edu/catalog/9928789773506421/
I will into this more on Monday.

This was also part of #1173

There are invalid locations and it is part of the Alma cleanup. @mzelesky and @kevinreiss are aware of the data.
The index is running successfully with the update of https://github.com/pulibrary/bibdata/pull/1192.


[Windows] Install Docker-wincred

Description
It is official docker helper provided by docker team: https://github.com/docker/docker-credential-helpers
Currently, we install this tool in provisioner. This PR moves this logic to image generation code.


[8.x] Rerun a migration that has no references

When running a migration that requires a reference table but does not find it in another table it will cause an error, even though the referenced migration file actually exists but has not been migrated before because by default migrations are sorted by migration file name.
So I created a list of migrations that failed to reference and then rerun it once after all the tables have been migrated.
If the reference assumption is really not found, then throws an Exception.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

Hi @taylorotwell
Errors in the order of the linked migration of tables are sometimes unavoidable.
for example: Laravel executes sequentially according to the timestamp date:

2021_04_16_205610_foo_need_bar.php

Schema::create('foo', function (Blueprint $table){
    $table->id();
    $table->foreignId('bar_id')->constrained('bar');
});

2021_04_16_205611_bar_need_baz.php

Schema::create('bar', function (Blueprint $table){
    $table->id();
    $table->foreignId('baz_id')->constrained('baz');
});

2021_04_16_205612_baz.php

Schema::create('baz', function (Blueprint $table){
    $table->id();
});

The arrangement above will cause an error, and will have to rename it by changing the date timestamp in order to fix this problem.
to be like this
2021_04_16_205610_baz.php
2021_04_16_205611_bar_need_baz.php
2021_04_16_205612_foo_need_bar.php
I had to change manually the timestamps of the two migration files in sequence to fix the "Failed to open the referenced table" error.

The concept in this PR is to skip migrations that do not find their reference table and then re-run it after all migrations have been executed.

migrating      : 2021_04_16_205612_foo_need_bar.php (skip, table bar not found)
migrating      : 2021_04_16_205611_bar_need_baz.php (skip, table baz not found)
migrating      : 2021_04_16_205610_baz.php
migrated       : 2021_04_16_205610_baz.php
re-migrating  : 2021_04_16_205612_foo_need_bar.php (skip, the table bar is still not found)
re-migrating  : 2021_04_16_205611_bar_need_baz.php
migrated       : 2021_04_16_205611_bar_need_baz.php (The baz table was created in step 4)
re-migrating  : 2021_04_16_205612_foo_need_bar.php
migrated       : 2021_04_16_205612_foo_need_bar.php (The baz table was created in step 7)

And the parameter --retry (default: 3x) is the maximum number of iterations of migration execution that do not find the reference table. If after reaching the maximum number and still not finding a reference, the QueryException Failed to open the referenced table will occur as usual without this PR.


fix some installation errors

had to add this 2 commands to make it work with the 1rst method (installing using conda)

sudo apt-get install build-essential
otherwise i get an error when running the requirement.txt
and
python3 -m nltk.downloader all
to fix the nltk path when running the run.py file.

@mahdimor  Thank you for the comments and feedback! I will add that to README


Outline none for Firefox

I'm usually on Chrome so I didn't noticed this last week however I was testing this out in FF and noticed outlines in <a> tags. I usually get rid of them with the style below. Just a suggestion. Awesome tool kit though.
a { outline: none; } /* Removes Firefox imposed outline */

As long as :focus and/or :active is set on elements, removing the outline shouldn't be a problem, but I agree this should be left to individual users of bootstrap to override.


Request bundle: pg

NPM package name
pg
Version
latest
External that exclude from bundle, separated by comma (for example "pg-native,pg-android")
pg-native
Bundler
esbuild
Bundle options

[X] minify

Package pg@latest has been released
Bundle size: 107 kB

Package pg@latest has been released
Bundle size: 107 kB

Hi
Thanks for create issue for Autobundle
Your request is processing, please rechecking this issue after 30 seconds.
Request detail:
{
    "packageName": "pg",
    "version": "latest",
    "external": "pg-native",
    "package": "pg@latest",
    "engine": "esbuild",
    "minify": true
}

Hi
Thanks for create issue for Autobundle
Your request is processing, please rechecking this issue after 30 seconds.
Request detail:
{
    "packageName": "pg",
    "version": "latest",
    "external": "pg-native",
    "package": "pg@latest",
    "engine": "esbuild",
    "minify": true
}

The execution failed, please check logs for more details
https://github.com/clgtIO/autobundle/actions/runs/1349708545
cc @ducan-ne

Hi
Thanks for create issue for Autobundle
Your request is processing, please rechecking this issue after 30 seconds.
Request detail:
{
    "packageName": "pg",
    "version": "latest",
    "external": "pg-native",
    "package": "pg@latest",
    "engine": "esbuild",
    "minify": true
}

The execution failed, please check logs for more details
https://github.com/clgtIO/autobundle/actions/runs/1349718166
cc @ducan-ne

The execution failed, please check logs for more details
https://github.com/clgtIO/autobundle/actions/runs/1349720299
cc @ducan-ne

The execution failed, please check logs for more details
https://github.com/clgtIO/autobundle/actions/runs/1349727202
cc @ducan-ne

The execution failed, please check logs for more details
https://github.com/clgtIO/autobundle/actions/runs/1349735832
cc @ducan-ne

The execution failed, please check logs for more details
https://github.com/clgtIO/autobundle/actions/runs/1349735832
cc @ducan-ne

Hi
Thanks for create issue for Autobundle
Your request is processing, please rechecking this issue after 30 seconds.
Request detail:
{
    "packageName": "pg",
    "version": "latest",
    "external": "pg-native",
    "package": "pg@latest",
    "engine": "esbuild",
    "minify": true
}

Package pg@latest has been released
Bundle size: 107 kB

The execution failed, please check logs for more details
https://github.com/clgtIO/autobundle/actions/runs/1349773744
cc @ducan-ne


[Feature Request] Add cli option to open Reader for a local file

Like this:
manga-tui read horimiya-jp-ch1.cbz

I mainly want this because Mangadex doesnt have japanese raws. Wouldnt it be cool?

I just saw the issue #13. Sorry about that. If one day another manga source that have japanese is added, that would be really awesome.
Cheers.


Create a more interactive and clean CLI

Rationale:
The current CLI can be described as a vertical scrolling log where the bottom line is interactive and allows for command inputs that get displayed in the log. While it gives a quick historical overview, it is not suited for interactive inspection of data such as Blocks and Transactions.
Event logging is interlaced with command history and can clutter the view. Error messages can even disrupt the proper representation of the statusbar (see below). In short, there is enough room for improvement

Goal:
Create a clean interactive CLI. The mitmproxy CLI is a great example how interactive and clean a console application can be. It uses the urwid library for the heavy lifting (beware it has a steep learning curve).
CLI wishes:

Allow for interactive block / transaction inspection.
A minimal example of how that could look can be see here
Work on all platforms (Windows/Linux/OSX). The Windows requirement can be the usage of Cygwin or a proper capable terminal.
Separate log messages from command and block history (e.g. see how mitxproxy has a splitpane capability)
Have plugin based command support (see the related issue: Refactor prompt commands to be plugin based)

I gave a moment of thought about how we could group commands.
quit
help

show
- block {index/hash} (tx)
- header {index/hash}
- tx {hash}
- mem # returns memory in use and number of buffers
- nodes # returns connected peers
- state
- notifications {block_number or address}
- account {address} # returns account state
- asset
-- {assetId} # returns asset state
-- search {query} <- not ideal. open for ideas how to structure otherwise.
- contract
-- {contract hash} # returns contract state
-- search {query}

config
- debug {on/off}
- sc-events {on/off}
- maxpeers {num_peers}
- node-requests {reqsize} {queuesize}
- node-requests {slow/normal/fast}
- compiler-nep8 {on/off}

wallet
- create
- open
- close
- {verbose}
- claim (max_coins_to_claim)
- migrate
- rebuild {start block}
- create_addr {number of addresses <= 3}
- delete_addr {addr}
- delete_token {token_contract_hash}
- alias {addr} {title}
- tkn_send {token symbol} {address_from} {address to} {amount}
- tkn_send_from {token symbol} {address_from} {address to} {amount}
- tkn_approve {token symbol} {address_from} {address to} {amount}
- tkn_allowance {token symbol} {address_from} {address to}
- tkn_mint {token symbol} {mint_to_addr} (--attach-neo={amount}, --attach-gas={amount})
- tkn_register {addr} ({addr}...) (--from-addr={addr})
- tkn_history {token symbol}
- unspent (neo/gas)
- split {addr} {asset} {unspent index} {divide into number of vins}
- send {assetId or name} {address} {amount} (--from-addr={addr}) (--fee={priority_fee})
- sendmany {number of outgoing tx} (--change-addr={addr}) (--from-addr={addr}) (--fee={priority_fee})
- sign {transaction in JSON format}

# idea move the following also under the `wallet` group and rename them to `import_wif`, `import_nep2` etc?
import wif {wif}
import nep2 {nep2_encrypted_key}
import multisig_addr {pubkey in wallet} {minimum # of signatures required} {signing pubkey 1} {signing pubkey 2}...
import watch_addr {address}
import token {token_contract_hash}
import contract_addr {contract_hash} {pubkey}
export wif {address}
export nep2 {address}

#need a good group command name for development related activities>
build {path/to/file.py} (test {params} {returntype} {needs_storage} {needs_dynamic_invoke} {is_payable} [{test_params} or --i]) --no-parse-addr (parse address strings to script hash bytearray)
load_run {path/to/file.avm} (test {params} {returntype} {needs_storage} {needs_dynamic_invoke} {is_payable} [{test_params} or --i]) --no-parse-addr (parse address strings to script hash bytearray)
testinvoke {contract hash} [{params} or --i] (--attach-neo={amount}, --attach-gas={amount}) (--from-addr={addr}) --no-parse-addr (parse address strings to script hash bytearray)
debugstorage {on/off/reset}
import contract {path/to/file.avm} {params} {returntype} {needs_storage} {needs_dynamic_invoke} {is_payable}

It's a first idea. I'm open to input, changes. The above would give a base help output of
config
help
show
wallet
quit
// and one yet unnamed for development commands

So do you know if we can achieve the "goal" with all the described wishes using the current prompt_toolkit package? Changing it might require a substantial amount of work.
Aside of the PR #623 for the plugin based approach, is there any work done on this matter? I might try to help here.

I don't know if prompt_toolkit would be capable. I just know that urwid is, as that's what mitmproxy uses and we could peek a bit there how they solve issues. I really think their UI looks nice and a lot of windows they use could be applicable for here.
The thing that bothers me with prompt-toolkitis that their 2.x version has some "double enter" bug when trying to run it under PyCharm. So I can't debug the cli using my IDE anymore and they've given 0 response or directions when reaching out.

Aside of the PR #623 for the plugin based approach, is there any work done on this matter? I might try to help here.

The only related work that has been done is #623 as far as I know. That is on going in the sense that the framework is there and we're now porting old commands over. If you'd like to investigate if prompt-toolkit is capable I would be open to it


DataArray computations should handle missing values correctly

Maybe I'm just missing something ... but shouldn't
xray.DataArray(np.asarray([1., np.nan]), coords=[[1, 2]], dims=["X"]).mean()

return 1 instead of nan?  Or how is calculations with missing values supposed to work?
I'm running xray 0.3.0.

Note: this is fixed in the newly released v0.4.


smtp.PlainAuth susceptible to man-in-the-middle password harvesting [Go 1.8]

For obvious reasons, it’s a bad idea to send passwords over plaintext network connections.
RFC 4954 requires that, during SMTP, the PLAIN auth scheme must only be used on network connections secured with TLS. The original implementation of smtp.PlainAuth in Go 1.0 enforced this requirement, and it was documented to do so.
In 2013, issue #5184 was filed objecting to the TLS requirement, despite the fact that it is spelled out clearly in RFC 4954. The only possibly legitimate use case raised was using PLAIN auth for connections to localhost, and the suggested fix was to let the server decide: if it advertises that PLAIN auth is OK, believe it. That approach was adopted in CL 8279043 and released in Go 1.1.
Unfortunately, this is exactly wrong. The whole point of the TLS requirement is to make sure not to send the password to the wrong server or to a man-in-the-middle. Instead of implementing this rule, CL 8279043 blindly trusts the server, so that if a man-in-the-middle says "it's OK, you can send me your password," PlainAuth does. And the documentation was not updated to reflect any of this.
The result is that if you set up a man-in-the-middle SMTP server that doesn’t advertise STARTTLS and does advertise that PLAIN auth is OK, the smtp.PlainAuth implementation would send the username and password.
The fix is to restore the original TLS requirement. As a nod to the localhost use case, we then carve out a documented exception for connections made to localhost (defined as “localhost”, “<IP_ADDRESS>”, or “::1”).
Fixed in Go 1.8.4 by CL 68023 (4be3fc33ef51).
Fixed in Go 1.9.1 by CL 68210 (39dd6f614474).
Thanks to Stevie Johnstone for reporting this problem.
Update: This has been assigned CVE-2017-15042.

Update: This has been assigned CVE-2017-15041. (Also added to top comment.)

@rsc your comment says CVE-2017-15041 but the top comment says CVE-2017-15042

@rsc Is there a way to mark SMTP over SSL connections as permitting auth without going through STARTTLS? (connection established using tls.DialWithDialer).

Update to my own question in case other folks happen across this: https://github.com/golang/go/issues/22166#issuecomment-334820611 notes that the issue with SMTP+SSL will be fixed in Go 1.10.

@KilledKenny, 15042 is correct, sigh. Thanks. (Just double-checked the assignment mail I received: 15041 is the cmd/go bug. I just got the copy+paste wrong in one of the two places on this bug.) I've updated the "Update:" comment.

Go1.9.2  works fine.


add uint64 and uint to pointer pkg

What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds support for interacting with 32 and 64bit unsigned ints in the pointer package.
We wanted to standardize on the pointer package but found that it was lacking unsigned int support which is commonly used in k8s and applications interacting with k8s.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
I'm not 100% sure if it makes sense to add the back-compatibility pieces which I copied from the existing Intand Int64 implementations. If not I can back them out and just leave the new pieces.
Release note:

I'd sort of expect all these things to now be defined by golang since I'm assuming they can be implemented with generics?

I'd sort of expect all these things to now be defined by golang since I'm assuming they can be implemented with generics?

Hi @apelisse, thanks for the reply!
I had seen that there have been some PRs already that attempted to introduce generics to the pointer package PR but it seems like there were some blockers with the requirements for using go 1.18. Is that still the case? If so, I'm wondering what to do in the meantime for those of us who may also have the same concerns?
The use case I'm trying to address is to provide coverage in the pointer package for Uint64 as we are trying to use it with some CRD code that uses it for things like versions and timestamps.
I do understand that an obvious+easy answer is for users to BYO functionality, which is what we already do, and so this PR is more of a "nice to have" vs a necessity.
Thoughts?
Thanks!
~Kyle

I guess I don't see any problem with this PR being merged in the mean time.
Where do you need this code? Or is it strictly hypothetical?

Cool.
I ran into this while doing some code cleanup on hashicorp/consul-k8s where we've to date just been rolling our own version of the pointer pkg for interacting with CR specs in our CRD controllers. Right now if I could get this merged then I could fully move over to pointer.

Hi @apelisse - sorry for the ping here, but I just wanted to double-check if there were any additional changes you might see needed for this PR while it's fresh in my mind. Cheers.

Sorry, I missed your reply.
/lgtm
/approve


[QUESTION] TR-Support?

Is it possible to use the Tool with the Tournament Realm? I see that everything instead of "Replay" connects to the TR (even Farsight does connect) but inGame nothing happens.

Yes, the tool also works in the Tournament Realm. if Replay does not connect it should not hinder any of the in-game features, since they don't rely on the replay connection.
Did you check your config file for the TR itself that replay is enabled?

Closing after inactivity.


Encoding error when running on windows

Happens when trying to save the first post (tweet in this case):
---------

Generated Tweet

"Creativity is intelligence having fun." - Albert Einstein 🚀💡 Show us your creative side! What's that one project you've been passionately working on this week? Share your journey &
let's fuel each other's creative engines! 🎨🖌 #CreativityChallenge #InspireToCreate 🌟

---------

Traceback (most recent call last):
  File "C:\Users\fxxho\Desktop\HeadlineGPT\dev\agent\main.py", line 72, in <module>
    main()
  File "C:\Users\fxxho\Desktop\HeadlineGPT\dev\agent\main.py", line 48, in main
    posts_prompt_expansion, mode).generate_tweet()
  File "C:\Users\fxxho\Desktop\HeadlineGPT\dev\agent\generators\tweet_generator.py", line 29, in generate_tweet
    add_item_to_file(Files.twitter_results, tweet)
  File "C:\Users\fxxho\Desktop\HeadlineGPT\dev\agent\utils.py", line 59, in add_item_to_file
    write_to_file(
  File "C:\Users\fxxho\Desktop\HeadlineGPT\dev\agent\utils.py", line 21, in write_to_file
    f.write(content + "\n")
  File "C:\Users\fxxho\AppData\Local\Programs\Python\Python310\lib\encodings\cp1250.py", line 19, in encode
    return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode characters in position 64-65: character maps to <undefined>

Once this gets merged your problem should be fixed or you can grab my copy.


Adding a retry to account for timeout errors when pulling container images

While doing container certification tests for container images stored in an artifactory repository - I've seen timeout errors when podman tries to pull the images.
The same container check executes successfully on a retry. Hence, I think we should add a retry option to account for these errors.

Closing this PR as per my discussion with @tkrishtop.
Will open the issue with preflight.


llama is not installed

2024-12-19 17:38:30.048 | WARNING  | rdagent.oai.llm_utils::48 - llama is not installed.
I follow the document and it shows it is not installed? how to solve it?

Hi,
Thank you for your feedback. This warning message will not cause any errors because llama will only be activated when you set the use_llama environment variable.
Additionally, we have created a PR #509  to prevent the warning from appearing when llama is not in use.


Failed pipeline keeps being shown as running

Component
web-ui
Describe the bug
When a pipeline fails, it properly reports to fail to GitHub, but the Woodpecker WebUI still shows the pipeline as running.
System Info
{"source":"https://github.com/woodpecker-ci/woodpecker","version":"next-37146058"}

My agents are running the same version.

# docker-compose.yml
version: '3'

services:
  woodpecker-server:
    image: woodpeckerci/woodpecker-server:next
    ports:
      - 80:80
      - 443:443
      - 9000:9000
    volumes:
      - woodpecker-server-data:/var/lib/woodpecker/
    environment:
      - WOODPECKER_OPEN=true
      - WOODPECKER_HOST=https://ci.moto9000.moe
      - WOODPECKER_LETS_ENCRYPT=true
      - WOODPECKER_GITHUB=true
      - WOODPECKER_GITHUB_CLIENT=REDACTED
      - WOODPECKER_GITHUB_SECRET=REDACTED
      - WOODPECKER_AGENT_SECRET=REDACTED
      - WOODPECKER_ADMIN=REDACTED
      - WOODPECKER_REPO_OWNERS=REDACTED,REDACTED

volumes:
  woodpecker-server-data:

Additional context
`ci.moto9000.moe` has an AAAA record, but IPv6 is not configured on Docker.

For some reason I cannot upload anything:
https://data.moto9000.moe/m/2022-07-31_23.30.25_ci.moto9000.moe_d0c217bc1720.png

Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

Even if you reload the page?

Yes

build_status in builds is running.
The build_error column is empty on all builds as well. (Even though no build has ever succeeded on this instance.)
build_status says killed on all other builds. I assume this specifies that I killed them and that the status for failing is different.

For reference, this is using the standard settings (SQLite inside Docker)

It has already occured over 4 times. For me it happens every time I run a build and it fails.

Well I do see a lot of errors but nothing that seems related.
I will turn on debug logging and trigger the issue again.

Here you go: https://paste.ubuntu.com/p/rrhJZVhtJH/
If you don't see anything in there, I guess I can make it fail sooner and change the loglevel to trace.

Hmm. I actually tried running with trace, but it doesn't find the config file in my repository anymore. Even manually specifying it doesn't work anymore. I tried going back to debug log level again but still nothing.
Any chance that the next branch got broken in the last three days?

this is a posible glitch where if you have a running agent and just kill it, the agent can never report back that the step did fail and so it wont get updated ...
hotfix for UI -> hit cancle button, now it's cancled
long term fix is the "agent heartbeat" and similar functions ...

might be fixed at #3151

the other mentioned issue is now tracked at:  #3157


Links to function line numbers

When you click the link to a function, it is 10 lines off from the location within the source file.

I'm unlikely to fix this at this point. If you want to take a crack, PR's
welcome.
On Mon, Feb 6, 2017 at 6:36 AM, jmassara<EMAIL_ADDRESS>wrote:

When you click the link to a function, it is 10 lines off from the
location within the source file.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/davecheney/godoc2md/issues/11, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAcAzeGiqFsP-3sLuaLUgAU4tDOHRC6ks5rZiS2gaJpZM4L3mSo
.

@jmassara Seems the problem is related to godoc.
https://github.com/golang/tools/blob/master/godoc/godoc.go#L549
For some reason it always subtracts 10 from the line number.
The good news, godoc provides a way to override that by providing your own function to the Presentation that can be used to return a different representation. Presentation.URLForSrcPos which is of type func(src string, line, low, high int) string


Using [NotNull] and 'nameof' operator

\cc @HaoK

Nice, fixes https://github.com/aspnet/Identity/issues/155

We wanted to automatically generate the checks using Roslyn but AFAIK that is still at the prototype phase so I wouldn't get rid of the actual checks for now.
cc @AndriySvyryd @davidfowl

@divega But there are some cases such as checking with String.IsNullOrEmpty() or typo inside the exceptions literal may difficult little bit to discover, I already did a check in all the repos last month to make a fix, also I'm doing another check from yesterday, I hope you take this in mind during the merge to avoid such things in the future ..

FYI I did the same fix in almost the repos - please i hope someone merge these changes ..

@HaoK can you merge this

/cc @Eilon

@Eilon I didn't have a chance to sync up with you about this. My take is that we want to take the addition of the attribute and the nameof() usage for sure, but that we shouldn't remove the actual checks, at least not yet. What do you think?

I think most repos don't bother with still having an exception, with the expectation of NotNull being implemented. I think the few cases where they're left is where perhaps some tests or whatever already assume the check will be there and we don't want to modify the tests.

In that case, @HaoK please finish reviewing and merge it.

Lets wait til NotNull runtime actually works and then I will merge

Curious: Why is this PR blocked? It wouldn't be blocked in most aspnet repos.

@HaoK and I had a chat and his judgment is that he doesn't want to remove the tests that check that the API throws when null are passed at this time. He wants to wait for [NotNull] rewriter to be fully implemented. FWIW, we are also keeping the checks in EF, at least for now, but that didn't have an influence.

FYI that tests fails in this PR https://github.com/aspnet/FileSystem/pull/109

Turns out we need to keep the null checking, can you revert the changes that remove the tests and then I can merge the nameof + [NotNull] changes

@HaoK FYI we're most likely going to drop [NotNull] and use manual null checks the Old School way.

Yeah Identity never removed them thankfully :)  So revert everything except the nameof changes then for this PR

@HaoK should I rebase and remove them changes in tests only

@Eilon I am not sure we should drop the attributes. Should we discuss this offline?

@divega Oh sorry the attributes we might want to stay in projects where we want to continue using them, but we'll still need to add explicit null checks and throws.

Thanks. For the time being the main advantage of the attributes is for Resharper users working with the codebase. I will discuss it with @HaoK although he isn't the only stakeholder :smile:

I don't have a strong opinion either way on the attributes. Especially if someone else is adding them :). I just don't want to remove them or add them if they aren't there already is my general rule of thumb now if they don't do anything

Then let's leave the attributes in place for now. They don't affect anything at runtime but can be still useful when working on the codebase.
BTW we can get rid of them when we get non-nullable reference type support in the language :smile:

Doh' @HaoK clarified that we currently don't have the attributes in our codebase, so we agreed we don't need to add them. Sorry I didn't take the time to look.

Don't worry @HaoK I will take care about these, but i'm facing some issues to run dnx test locally so I will let you know when i finish .. thanks

It takes time to figure out which of [NotNull] that doesn't let the tests run successfully, specifically if you have an issue to run dnx test locally :smile:
@HaoK can you review and merge if everything is fine

Remove all of the not null attributes and usings and if it compiles that should be sufficient
On Sep 11, 2015, at 4:11 PM, Hisham Bin Ateya <notifications<EMAIL_ADDRESS>wrote:
It takes time to figure out which of [NotNull] that doesn't let the tests run successfully, specifically if you have an issue to run dnx test locally [:smile:]
@HaoKhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FHaoK&data=01|01|haok%40microsoft.com|c18e488447844eb161ee08d2bafe5cce|72f988bf86f141af91ab2d7cd011db47|1&sdata=yLaO3YGELQB2bM1DsgNC6yIsZyzb7R4oYzNLCTcI%2BJY%3D can you review and merge if everything is fine

Reply to this email directly or view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faspnet%2FIdentity%2Fpull%2F485%23issuecomment-139684104&data=01|01|haok%40microsoft.com|c18e488447844eb161ee08d2bafe5cce|72f988bf86f141af91ab2d7cd011db47|1&sdata=AjN9IVckQ%2F86UABA6oPq6ta5IGYmeI7yXyIObrp7GkQ%3D.

Unfortunately i'm facing issues with dnx commands in my end :(

@HaoK  Shall I revert the ```NotNull`` changes while @pranavkm take the initiative to execute NotNull -> Throw ArgumentNullException script to almost the aspnet repos

@hishamco might be useful since the checks will get moved to the top of the method with my script (versus after the ThrowIfDisposed that it does now). Just seems like needless diffs.

So shall I revert NotNull changes?

Yeah the only changes that we need in this PR are the nameof updates, NotNull and any other checks should be reverted

Ok @HaoK

@HaoK the PR has been updated

:shipit:

Just I figure out there's a typo here https://github.com/aspnet/Identity/pull/485/files#diff-5fad47ab1c97fb22b91f704b2e78a262R982 , I updated the PR while @HaoK is already merge. Seem he fix it.
Thanks @HaoK


Infer_shape in custom operator

I try to implement a customOp using python, if anyone knows how to implement the infer_shape(self,in_shape) function if the out_shape is independent of in_shape but depended on in_data?
For example, if you want to implement a customOp like mx.symbol.arange, and the out_shape is only related with input data.
Thanks.

@abuzn did you means your customOp's shape may be change every batch since it relates to the input data. Or you means the customOp's shape is relates to the attribute parameter like arange?

@Ldpe2G I mean  customOp's shape changed every batch since it relates to the input data. Is it possible in mxnet?

@abuzn shape change every is possible in mxnet, but your case is special because the out shape of the customOp is related to the inData which is not known in the inferShape but only known in the forward pass.
I am not sure whether this is possible in mxnet.
@piiswrong

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!

Is there a solution of this issue??

try using the gluon api


Kotlin Result seems to behave weirdly when trying to be returned with Mockito

I am facing an issue when trying to use the Kotlin Result in my project. I am trying to mock the return value as shown here:
`when`(useCase.getA()).thenReturn(Result.success(ObjectA("testName")))

The exception when trying to use that returned Result is this one: java.lang.ClassCastException: kotlin.Result cannot be cast to ObjectA
An interesting thing I found when debugging is that if I check the returned value of that useCase.getA() function, it returns an object with description Success(Success(ObjectA(name=testName))). A regular Result returns this description Success(ObjectA(name=name)). I guess that's the reason it's failing, it seems there is like a nested Result object, so I am assuming there is something wrong with Mockito when handling the Kotlin Result class.
This is a gist  I created to test it. There are two tests, one with the Kotlin Result and another one with a quick Result implementation (OwnResult) to check there is not something wrong I am doing myself.
I am using Mockito 3.3.3 on an Android project with Java 8.

Sorry, I wanted to ask this in the mockito library, not in the mockito-kotlin, just an error.

@adrianhescalante Result-class is an inline class. Mockito doesn't know how to handle this. Take a look at #309 and #363.

Thank you, @bohsen, good to know. What alternative would you use to handle results? Maybe Either?

@adrianhescalante I've used this a lot.

Thanks, it looks good!


Mac OS support

Thanks for your great work, @thetechnick.
Is it possible also providing artifacts for mac os?

Hi @perunb,
sure, no big deal.
I have no Mac OS machine, so here is a cross compile of the current v1.3.0.
If you can confirm it is working I will add a mac os version for all future releases.
hcloud-ansible_v0.3.1_darwin_amd64.zip

Works like a charm! :)
Thanks for your fast reply


[Feature] Support stretching height when color image does not repeat

What problem does this feature solve?
Example
What does the proposed API look like?
{
      color: {
        image: getLineChartAreaStripeImgEl(options.value),
        repeat: 'repeat-x',
        stretch: 'stretch-y' // 'stretch-x', 'stretch-y', 'no-stretch'
      },
}

But areaStyle.color (from your Example) does not support images...?!?

But areaStyle.color (from your Example) does not support images...?!?

Yes, I'm not sure if it's the documentation or the type.
In the TS type, this configuration is of type ColorString, or string.

type ZCOLOR, and can be displayed in the playground

Having a 'Z' in front of 'color' just disables the color attribute because 'zcolor' is invalid. Please provide relevant Example code.

areaStyle.color, which is configured as a picture, is used in the examples mentioned above.

The problem is with your SVG image. If SVG image is correctly set, areaStyle shows OK.
📌 please close issue if problem solved.


The AUTOUPDATETIME does not go through the driver.Valuer during an UPDATE SET or ON CONFLICT statement

GORM Playground Link

https://github.com/go-gorm/playground/pull/490
Description
The goal is to change the time.Time to another object. It works great during the Create scenario, but during a Save, I would expect the object to flow properly down the SQL handler and call the driver.Valuer. But in this case, I can't make it keep the correct type.
In the playground I made it fail by looking at the type. But basically it failed during the SET, but would fail in a ON CONCLICT as well.
For instance this:
https://github.com/go-gorm/gorm/blob/ea8509b77704b152380f8097c59e5ae3b57428bb/callbacks/create.go#L307-L317
Is a different path taken during the Create
https://github.com/go-gorm/gorm/blob/ea8509b77704b152380f8097c59e5ae3b57428bb/schema/field.go#L890
Then in the driver callValuerValue, the correct Value would be called.

We don't know the actual type, if the GormDataType you specify is not in our enum, we can only default to a certain precision.
https://github.com/go-gorm/gorm/blob/master/schema/field.go#L275
https://github.com/go-gorm/gorm/blob/master/schema/field.go#L298


add syntax wishlist

one stop shopping for how the TSQL API can benefit from being standardized

@NandanHegde15 can you please add any info you think might be relevant?


integrate JinaChat

Integration with https://chat.jina.ai/api. It is OpenAI compatible API.

nice! if jina plans to stay in sync with openai chat api we could probably simplify this by inheriting from ChatOpenAI directly and overwriting some of the credential keys

@dev2049, thanks for looking it up so quickly.
Inheriting was also on my mind, but some properties and options aren't supported by JinaChat. API request payload and response schema is similar but not 1 to 1.
At the moment, JinaChat does not have any "model" parameter and does not support "n" options or "functions", no proxy etc.

Hi @dev2049, I've added a documentation notebook and fixed the lint error.
Could you please take another look at it? Thank you very much.

thanks @delgermurun!!


Password-protected / nonpublic notebook publishing

Currently, the 'Publish' feature can only publish notebooks publically. It would be extremely useful to have the option for password-protection or a user-based ACL system on published notebooks.

agreed, it's on the agenda.  in the meantime, if you use "unlisted" then it's fairly secret, people will only know about it if you give them the URL, which is impossible to guess.

This should be in the FAQ.

Cool. Thanks for the quick response!
It looks like this page should be updated as well. By the way, Google Drive integration would solve this problem, actually, because it's sharing features have a rich permissions/invite system.

https://github.com/twosigma/beaker-notebook-www/commit/4a0bbef85b08457852bf2bbfa9628eae23cfcc51


Why is there no Dutch available in the locale settings?

I am trying to switch to Dutch as the main language on iNaturalist.com. However, there is no Dutch locale.

@andrawaag - because the site / app has not yet been translated into Dutch.
If you wish to see Dutch common names, you can go to your Account Settings and set the "Prioritize common names used in this place" to the Netherlands.

FWIW, Dutch seems to be 38% translated on the website according to https://translatewiki.net/w/i.php?title=Special:MessageGroupStats&language=nl&group=out-inaturalist&showMessage. I can't remember what TW's threshold is before they start sending us the file, but I suspect it's something like 80%. If you want to see Dutch as a language option on iNat, you can help by adding translations on translatewiki.

I think the percentage is way lower. Estonian was usable on the site already with under 50 percent translated (or maybe 50).


Where is the "hand_present" now?

It worked well in the old version when I used
        processor.addPacketCallback(                 OUTPUT_HAND_PRESENCE_STREAM_NAME,                 (packet) -> {                     handPresence = PacketGetter.getBool(packet);                     if (!handPresence) {                         Log.d(TAG, "[TS:" + packet.getTimestamp() + "] Hand presence is false, no hands detected.");                     }                 });
but now it reports an error:
com.google.mediapipe.framework.MediaPipeException: unknown: ; Input Stream "hand_presence" for node with sorted index 1 does not have a corresponding output stream.
Then I looked at the code in the file "hand_tracking_mobile.pbtxt".
# Detects/tracks hand landmarks. node {   calculator: "HandLandmarkTrackingGpu"   input_stream: "IMAGE:throttled_input_video"   input_side_packet: "NUM_HANDS:num_hands"   output_stream: "LANDMARKS:hand_landmarks"   output_stream: "HANDEDNESS:handedness"   output_stream: "PALM_DETECTIONS:palm_detections"   output_stream: "HAND_ROIS_FROM_LANDMARKS:hand_rects_from_landmarks"   output_stream: "HAND_ROIS_FROM_PALM_DETECTIONS:hand_rects_from_palm_detections" }
Found that it seem there is no "hand_present" any more. So now how can I keep using this FLAG?
Thanks for your help.

I have the same problem ，and I hope  help.I guess we used the latest version in 12 . 2020（December）.The official guidance document has not been updated。If anyone has solved the problem, please contact me and let me know. Thank you。my<EMAIL_ADDRESS>

Hi, please see https://google.github.io/mediapipe/solutions/hands#output about the latest updates to the hand tracking API outputs.

Hi, please see https://google.github.io/mediapipe/solutions/hands#output about the latest updates to the hand tracking API outputs.

Hi @youto614 @DandyLorenz since this issue has been inactive, we will close it. Please feel free to reopen if you have further questions. Thank you!


server features

Hi, found this great package that wraps the entire gitlab api for node - https://github.com/node-gitlab/node-gitlab. Which api requests we plan to support?
For start:
*. Get / Create/ Edit/ Close - Issues by project.
*. Get / Create/ Edit/ Delete - Projects.
*. Get / Create / Delete - Users.
*. Get/ Create/ Delete - Labels.
Anything Else:question:

:+1:

Awesome.
We also need to support sprints (GitLab Milestones), and perhaps branches. That's all I recall at the moment.

No problems :+1:

Added Login and Logout.
Should we think about permissions for the first release?

It's possible, but I don't know how immediately necessary. I'd say we postpone it for a while.
In any case, the GitLab API allows you to get the permissions easily (GET /projects/:id/members/:user_id returns an object containing access_level), and from here it seems node-gitlab should support it as well.

@udidoron read my mind.
Login and Logout are just saving an encrypted version of the private_token we need to pass to GitLab for every request. GitLab got not oAuth for now :cry:


perf: Slightly optimise object interner for larger codebase

We have a larger codebase of TypeSpec (total. 17K lines formatted) and found that emitting part is very slow than the compile part, taking 15 seconds avg. on my M3 Pro machine.
After enabling --cpu-prof option of Node.js, I found that intern function is taking larger part of the framegraph. As the JSDoc says, it's not well optimised yet.
This pull request is maybe the first try of the optimisation and slightly improves the execution time of the emitting part. It lowed the execution time from 15 seconds to 6 seconds.
Profiling comparison
← after, before →

Hey cool, the bottleneck got hit 😁 How hard was the facepalm when you saw the comment?
This is a good simple approach. There are likely more optimal approaches that would be more work (e.g. I had considered sorting keys and then storing the known keys and values in a trie, which I think is effectively what the records and tuples polyfill does). But I don't think this can hurt to improve for now since it seems to help your perf significantly.


Update 0x500565E098d98A273224eC8Fb33d98dC8946F8B9.json

Fixes #4158

Hi, thank you.
We've fixed the CI autocheck issue. And you need to re-pr so that will be ok. This one should be closed.


fix typo in query examples

Fixes code to match the query shown in the docs below:
select "persons".* from "persons"
where ("age" < 40 or "age" > 60)
and "firstName" = 'Jennifer'
order by "lastName" asc

Coverage remained the same at 97.061% when pulling 955d53602c3722beb42e488c8a56bc4ddef9892d on jure:patch-1 into ae9cfd5b0576e43c79baa0f107962aa1acd3df32 on Vincit:master.

Thanks


Need more clarification about network requirement

Hi
This doc mentions as follows.

Cloud Backup for Virtual Machines requires outbound internet access from your Azure VMware Solution SDDC. For more information, see Internet connectivity design considerations.

But network administrator who manages Azure Firewall, NVA, on-premise Network can't allow outbound internet access based on this sentence Because this sentence doesn't specify the following information.

Source IP range
Destination FQDN
Service

I would appreciate if you could add the detailed information about network requirement.
Best regards.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 760aa784-5e0f-7425-862a-63d6a1a4a881
Version Independent ID: 7108747c-957a-2ff2-7a4f-2cba6a75eb37
Content: Back up Azure NetApp Files datastores and VMs using Cloud Backup (preview) - Azure VMware Solution
Content Source: articles/azure-vmware/backup-azure-netapp-files-datastores-vms.md
Service: azure-vmware
GitHub Login: @jjaygbay1
Microsoft Alias: jacobjaygbay

@kongou-ae
Thanks for your feedback! We will investigate and update as appropriate.

@seanluce
Could you please review add comments on this, update as appropriate.

@kongou-ae
Thank you for bringing this to our attention.
I've delegated this to content author @seanluce, who will review it and offer their insightful opinions.

The topic has been updated. #please-close


Add documentation for readonly catalog

This change contains documentation for the readonly configuration of the catalog introduced in #5034.
This is part of the #3348 feature request.
Let me know if anything is unclear or need additional explanations.
Signed-off-by: Crevil<EMAIL_ADDRESS>:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Markdown fails with vale complaining about the added Johan Haals in OWNERS.md 🤔

@Crevil aw, it snuck in while Vale was temporarily disabled on master. I created #5147 to fix it.

Great @timbonicus . I'll rebase this branch when the PR has been merged 🙏

Now!

Updated 🎉

Hmm. Now it complains about all the names in OWNERS. The update fixed it locally though 🤔

@Crevil sorry about that, updated the local script but CI runs a bit differently with the GitHub action under .github/workflows/docs-quality-checker.yml. Should instead be fixed by #5148.

Looks like it working now. 🎉 Thanks @timbonicus


hover dlc/platforms

Is your feature request related to a problem? Please describe.
would be pretty neat if when you hovered over a game it showed dlc art or an alternate cover, (would maybe have to mark a game as has playable dlc considering some games only have cosmetic dlc) or other games with the same name, allowing multiple platforms' versions to be availiable in clear at once, instead of needing to add several and look through the library to find all of them if you sort your library by platform.
Describe the solution you'd like
this would preferably be togglable but wouldn't be bad if it wasn't
Additional context
mouse off (dlc)
mouse on (dlc)
mouse off (platforms)
mouse on (platforms)
also sorry if I came off as narcissistic or entitled or anything

hey there! so from what i understand, you're talking about two different features,

the dlc for a game is viewable when hovering on its cover image

regarding that, im already planning to include a feature in the upcoming release where, upon hovering to the right side of the game popup, playable dlc which you have added will be shown in cards like this

from what you have described, i understand that you want the dlc to be shown right when you hover over a game's cover image in the main page, which could look pretty good. something like this maybe?

or are you talking about an interaction where, by default the game card has a single cover, but on hover, it'll cycle through the cover images of its dlc's as well?

both approaches are possible, so let me know which one you'd prefer to be in the app, if you'd prefer to have both options available or if you meant something else entirely.

the different platforms that you have a game on, are mentioned on hover

from what i understand about this, you basically want to see the different platforms on which you have the game purchased when you hover over its cover image. i felt like there's a better to do that compared to obfuscating the cover art with logos and so i came up with this:

this row of logos could easily be customized to only show up on hover or show up by default.
let me know what you think of all of this! please do excuse me for the rough designs as i made them up pretty haphazardly

to be honest all of those look really good! I personally would prefer the first one but putting both in as a togglable option would probably be the way to go. if you want I can make custom logos to match the clear aesthetic for the console logos, since imo the regular logos look a bit out of place with the current gui.

sounds good! i'll make sure to implement all this in a future update, and make sure to provide an option to make the dlc view options togglable. and yep! if you're able to create custom logos for all the consoles in the style of clear, it would be absolutely amazing! feel free to create and upload those logos here and i'll add those in accordingly for the next update. i can always fallback to the original logo if you're not able to do certain ones


chore: remove job artifact tests

Description

What does the PR do? Include a concise description of the PR contents.
Assuming the lack of support i think it is probably safe to remove these tests.

[x] I updated CHANGELOG.unreleased.md, or it's not applicable

Testing
How was this PR tested?

Afuera!


[FLINK-24347][connectors/kafka] Keep idle source readers if paralleli…

…sm is higher than partitions in KafkaSource
Unchanged backport of #17327

Manually merged in a595fbbfe0087181f1b92d2d991a885911f290a2


[Question] Lag between current offset and log end offset

Is the lag between current offset and log end offset expected as a result of https://github.com/EnMasseProject/amqp-kafka-bridge/issues/23
E.g. Before creating a bridge receiver, the offset state on a topic is -
current offset = 24
log end offset = 24
After connecting to bridge, when a new message is consumed from topic and successfully delivered, the offset state is -
current offset = 24
log end offset = 25

Hi,
can you explain me better your scenario and a way to reproduce it. I'd like to dig into it better.
When you say "a new message is consumed from topic" are you talking to consume it using an AMQP receiver attached to the bridge or a native Kafka receiver attached directly to the topic ?

Hi,
When I say "a new message is consumed", it is consumed using an AMQP receiver attached to the bridge.
Today, I ran two scenarios with newly created kafka topics. Below are steps to reproduce it.
Scenario 1 (Consume message using AMQP receiver attached to the bridge) -

Create a new topic with name "topic_bridge"
bin/kafka-topics.sh --create --zookeeper localhost:2181 --replication-factor 1 --partitions 1 --topic topic_bridge

Start the bridge
java -jar target/amqp-kafka-bridge-1.0-SNAPSHOT.jar

In enmasse.kafka.bridge.example.BridgeReceiver.java, update the topic and consumer group name -
TOPIC = topic_bridge
GROUP_ID_PREFIX = topic_bridge_consumer_group_1

Run BridgeReceiver.java
output says "Connected as vert.x-f4189ddf-70b5-4dc5-b43c-2a7c1d6fb59b"

Check initial state of offset in topic
./bin/kafka-consumer-groups.sh --new-consumer --bootstrap-server localhost:9092 --describe --group topic_bridge_consumer_group_1

output > PARTITION = 0, CURRENT-OFFSET = unknown, LOG-END-OFFSET = 0, LAG = unknown

Start a producer and add a message
bin/kafka-console-producer.sh --broker-list localhost:9092 --topic topic_bridge
message 1

Check state of offset
./bin/kafka-consumer-groups.sh --new-consumer --bootstrap-server localhost:9092 --describe --group topic_bridge_consumer_group_1

output > PARTITION = 0, CURRENT-OFFSET = 0, LOG-END-OFFSET = 1, LAG = 1
In this scenario, every time Bridge receiver is re-started after step 6, the last message is re-delivered.
Even when more messages are produced and then consumed by amqp bridge receiver, the LAG is always equal to 1.
Scenario 2 (Consume message using a kafka consumer directly listening to topic e.g. kafka-console-consumer.sh)

Create a new topic with name "topic_test_consumer"
bin/kafka-topics.sh --create --zookeeper localhost:2181 --replication-factor 1 --partitions 1 --topic topic_test_consumer

Start a consumer
bin/kafka-console-consumer.sh --bootstrap-server localhost:9092 --topic topic_test_consumer --from-beginning --consumer.config config/consumer_1.properties

Check initial state of offset in topic
./bin/kafka-consumer-groups.sh --new-consumer --bootstrap-server localhost:9092 --describe --group topic_test_consumer_group_1

output > PARTITION = 0, CURRENT-OFFSET = 0, LOG-END-OFFSET = 0, LAG = 0

Start a producer and add a message
bin/kafka-console-producer.sh --broker-list localhost:9092 --topic topic_test_consumer
message 1

Check offset
./bin/kafka-consumer-groups.sh --new-consumer --bootstrap-server localhost:9092 --describe --group topic_test_consumer_group_1

output > PARTITION = 0, CURRENT-OFFSET = 1, LOG-END-OFFSET = 1, LAG = 0
If we look at initial value of current-offset in both scenarios - It is "unknown" in scenario 1 and 0 in scenario 2
So, I was wondering if the lag in scenario 1 is due to the offsets being managed / committed by the bridge.

In the scenario 1, attaching an AMQP receiver just creates a native Kafka consumer on the topic so it should fall into the scenario 2. I'll dig into it and come back to you, thanks for reporting !

@pinkyrathore I can reproduce the issue and it seems to be related to the "auto commit" that is DISABLED and not configurable in the bridge but is ENABLED by default in the kafka-console-consumer.
The bridge needs "auto commit" DISABLED because the offset needs to be committed only when the AMQP receiver settles the message as well. Having "auto commit" DISABLED starts in the situation of current offset is unknown (so lag is as well). Have you tried with a simple application using the native Kafka client with "auto commit" DISABLED ?

@pinkyrathore the AMQP receiver connects using the AT_LEAST_ONCE QoS level as default and it means that the Kafka consumer part in the bridge executes a call to commitSync with the "current offset" of the consumed message. It's wrong because it should be "current offset" + 1 avoiding on restart to have the receiver getting always last message. If you try to use the AMQP receiver with AT_MOST_ONCE QoS level (this.receivers[i].setQoS(ProtonQoS.AT_MOST_ONCE); to add just before the this.receivers[i].handler ....) you can see that after consuming the message the LAG is 0 (even if the starting situation is "unknown" but as I said it seems to depend on using the auto commit DISABLED). In this case the LAG is 0 because the Kafka consumer part in the bridge use the commitSync() method (with no offsets as parameters) and it seems that this method set the offset to the right value internallu "current offset" + 1.
Does it make sense to you ?
I have to fix committing offset adding the + 1 as well as explained in the Kafka API documentation :

Note: The committed offset should always be the offset of the next message that your application will read. Thus, when calling commitSync(offsets) you should add one to the offset of the last message processed.

@ppatierno yes, this makes sense. Thanks for looking into this.

I'm going to close this on behalf of 2d5ba0799b7dee27c35999707240d5ae25e3c79f


DA-18 Running code on headless (no display integrated) server

Current code imports mayavi in pv_rcnn_ssl.py and roi_head_template.py to visualize the boxes at different stages.
https://github.com/fnozarian/OpenPCDet/blob/9173644af32cab4fc31df024a14e79f3c7bcc1b0/pcdet/models/detectors/pv_rcnn_ssl.py#L17-L18
Running the same code on the cluster would fail, since we do not have the display support on that server. Following is a workaround in order to import mayavi based on the presence of display during runtime and avoid code failure.
if os.name == 'posix' and "DISPLAY" not in os.environ:
    headless_server = True
else:
    headless_server = False
    import mayavi.mlab as mlab
    from visual_utils import visualize_utils as V

@shashankag14 thanks! Could you please fix and merge it?


Large Files

Is posible to convert 10MB file or Larger?
Im try to convert 10MB zip file (around 60MB) unzip
waiting about one hours, still no result or error

a 10MB zip file shouldn't take that long you are probably missing an error, this library uses promise and if you don't explicitly catch the error it can get lost, see this article

after use .catch
i got this message
"coordinates must be finite numbers"
do you know?
note:
i also upload zip file to http://leaflet.calvinmetcalf.com/#3/32.69/10.55
and it work

"coordinates must be finite numbers"

probably an issue with the reprojecting of the data would be my guess, it is weird that it works on leaflet.calvinmetcalf considering it uses this library under the hood

Thank you...


⚠ Bofrost.at has degraded performance

In f4462c9, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1838 ms

Resolved: Bofrost.at performance has improved in a09b3da.


Packages cpprestsdk and azure-storage-cpp fail to build

Both these packages ( cpprestsdk:x64-windows and azure-storage-cpp:x64-windows ) are failing to build due to what appears to be broken boost dependencies.
error MSB3030: Could not copy the file "2_9.dll" because it was not found.
error MSB3030: Could not copy the file "stem-vc140-mt-1_62.dll" because it was not found.

I have the latest version of boost  (  1.62-9 ) and I previously had both packages successfully built before.

The file names I see above seem a bit broken.
stem-vc140-mt-1_62.dll is probably boost_system-vc140-mt-1_62.dll (could also be boost_filesystem-vc140-mt-1_62.dll)
The 2_9.dll is probably cpprest_2_9.dll.
So, it is looking for the filenames with the first 8 chars chopped off.

I just built cpprestsdk:x64-windows and it works. Might be worth trying this once more to see if you consistently get this error.
What is your locale?

Still failing with the same error. My locale is English(US). Platform Windows 7.
I guess I may have to re-build everything.

Please let me know if rebuilding fixed the issue. I looked for cases where vcpkg might be doing some chopping but didn't see anything out of place.

Rebuilding fixed the issue.


Use winappdriver instead of AutoIT.

Can we use winappdriver to handle the Windows popup while automating web applications using selenium Webdriver .Please suggest.

Have you tried it, what kind of pops are these.

Yes I have tried it , but i am not able to create a new session for windows popup.
For example - If you want to upload a file,using AutoIT you just need to call exe file generated by the AutoIt.
I am trying to automate the part of AutoIT using winappdriver.

You can use the below code to achieve that:
DesiredCapabilities desktopCapabilities = new DesiredCapabilities();
desktopCapabilities.SetCapability("app","Root");
desktopSession = new WindowsDriver(new Uri(WindowsApplicationDriverUrl), desktopCapabilities);
Assert.IsNotNull(desktopSession);
var ShellWindow = desktopSession.FindElementByClassName("XXXXXX");
var ShellTopLevelWindowHandle = ShellWindow.GetAttribute("NativeWindowHandle");
ShellTopLevelWindowHandle = (int.Parse(ShellTopLevelWindowHandle)).ToString("x");
DesiredCapabilities appcapabilities = new DesiredCapabilities();
appcapabilities.SetCapability("appTopLevelWindow", ShellTopLevelWindowHandle);
session = new WindowsDriver(new Uri(WindowsApplicationDriverUrl),appcapabilities);

Hi ,
It's working for me , Thank you.


Update the title of the Basic List without virtualization section of the BasicList demo page

The current title of this section is too long and not appropriate:

This title should be changed to No virtualization.
The demo file name is BitBasicListDemo.razor in the Bit.BlazorUI.Demo.Client.Core project.

Hey @msynk can you please assign me this issue want to work on it.

not relevant anymore!


[Chore]: Optimise container registry cleanup

Background
Deleting package and droplet images takes around 45 mins each morning. We list all images and delete them individually.
In the new AWS terraform cluster setup, we include the ECR repositories in the terraform config. This means they get torn down with the cluster. A flag in the repository definition forces deletion of all images at the same time. This approach would be ideal for GCP too.
Action to take
Modify the GCP terraform to include the package, kpack-builder and droplet repositories, with a force-delete option (which hopefully exists for GAR).
Remove the script in CI which iterates through the images and deletes them.
Impact
Cluster recreate completes in ~20 mins rather than 1 hr.
Dev Notes
Have we got a build-up of images in the acceptance repositories that need cleaning up?

We have fixed the GCP clean-up by removing the top-level repository rather than deleting images individually.
ECR doesn't give us a top-level repository to delete, so we have to iterate over all repositories with a given prefix and delete them individually. On 10th Jan, this took 11 minutes to delete repositories created by PRs and main merges the day before (periodics are not scheduled on EKS). Some simple parallelisation could help here.


IGNITE-19642 CatalogService should use HybridClock to register new Catalog version

https://issues.apache.org/jira/browse/IGNITE-19642

@rpuch , could you please review the PR.

Sure, I'll do it tomorrow


show segments for table x is failing if  the table does not exists

#501 has already solved this problem.

closing duplicate of #501


Implement flip and rot90

This PR implements cupy.flip and cupy.rot90 functions. Since numpy.flip is new feature of NumPy v1.12, the test code expect to run with NumPy v1.12 or later.

Thank you for your PR! I would like to read this one.

Thank you for your reviews. I have fixed them.

Thank you! Then I would like to merge.


[SIG-scale] Add density performance tests to evaluate the Kubevirt control plane

What this PR does / why we need it:
This PR adds support for performance tests to be the basis of both performance and scalability tests.
More specifically, It enables the creation of density tests to run (e.g., scheduling in parallel 100, 200 ... 600 VMs), measuring the VM's creation time (from submission to Running Phase) and failing when the time is higher than a given threshold.
For further analysis, the VMI's phase transition latency, the VMI resource usage, and the Kubevirt control plane resource usage are also collected and logged into a file. Note that, resource usage is only collected when Prometheus is available.
The test configuration is defined in a YAML file so that it can be easily adapted to different environments. For rate control during the creation process, it is possible to define a step function or use a Poisson process with a given arrival rate.
The density test is inspired by the Kubernetes density test. Even though  Kubernetes has a new repository for perf tests, the ginkgo-based tests are a good source of reference.
why we need it:
We would like to integrate those tests into our CI/CD system to facilitate the evaluation of the Kubevirt control plane. The motivation of such evaluation is because code changes may affect system scalability and performance. Then, with a set of performance and scalability tests, we may identify possible performance regression in the KubeVirt control plane between PRs and new Releases.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
The thresholds now are pessimistic since my environment has nested virtualization and I could not measure "realistic" latencies yet. I will need to adapt it accordingly...
Release note:

/retest

cc @davidvossel @rmohr

cc @nelsonspbr @ezrasilvera

It seems that we all agreed to approve this PR.
/approve

Sorry, I sent the approve message in the wrong PR....

cc @fabiand @dhiller @jean-edouard @fgimenez @vladikr @omeryahud

@marceloamaral Might need to add a release note, even if it is just NONE, to allow this to be merged in the future.

@marceloamaral I saw you linked a doc above (here). Is it a direct result of the implementation you are proposing in this PR? I think it is a great set of initial results and I think we could easily expand it to many more VMs by simply adding a few more nodes. I can help you with that if you need.

@nelsonspbr yes, this document shows an example of the outputs of the test in this PR

https://github.com/kubevirt/kubevirt/issues/5878

What would you think about leaving the density test pretty much as you have it, but abstracting away the logic that is meansuring performance into a standalone tool, perhaps called performance-profiler which could live in the kubevirt/kubevirt repo in tools/performance-profiler/performance-profiler.go
The performance-profiler would discover the control plane and VMIs as they are introduced, then profile their performance until the process receives some sort of stop signal.

@davidvossel I think it make sense, let's discuss more about the design...
In this case, the performance-profiler would be a binary that we start independently from the test....
I don't want to make it too complex, but it might become.... and maybe takes time to implement....
Any way, let's list what the performance-profiler should have for the density test standpoint:

[ ] watch for VMs, might be an operator then....wdyt?
[ ] track the VM phases independently from Prometheus...(maybe not since we have the histograms now)
[ ] store the VM's information, VM phases and VM pod resource usage. We can extend the metrics later as needed...
[ ] an API to expose the results, start, stop the collection, etc...
[ ] reports results to stdout and optionally into a file

@marceloamaral WRT the failing pull-kubevirt-checkunassigned-tests we need to add [sig-performance] to https://github.com/kubevirt/kubevirt/blob/main/hack/check-unassigned-tests.sh#L4

@rthallisey @rmohr and @vossel I updated the PR as we discussed last time.
The PR was simplified, and all the metric collection part from Prometheus was removed. The flexible configuration from a YAML was also removed. As we agreed, I kept only the functional test.
Could you please review this PR?

@rthallisey I updated the test accordingly to your comments.
@rmohr I am not sure if we need to identify the test in Prometheus since the Prow job will do that.
Regarding collecting the data, I am using the same timestamps as the prometheus metrics are using. It must not be different...
Only with the VMI creation time, we can set the test thresholds...

@rmohr I am not sure if we need to identify the test in Prometheus since the Prow job will do that.

For a single test it is not relevant. I was more thinking about other tests too, so that we can clearly see results per test.

Regarding collecting the data, I am using the same timestamps as the prometheus metrics are using. It must not be different...
Only with the VMI creation time, we can set the test thresholds...

Well, you are watching. They are probably similar. I would prefer to stick with prometheus. If possible, anything which we need to see issues in our cluster for scale testing would be great to have available and as the primary source also in production.

Well, you are watching. They are probably similar if there are no errors, but not the same. I would prefer to stick with prometheus. If possible, anything which we need to see issues in our cluster for scale testing would be great to have available and as the primary source also in production.

And I am fine with creating a freamework and all, and also doing some measurements outside of prometheus in general, but let's really start with a useful bare minimum.

It was closed by mistake

/reopen

/retest

/retest

All the tests on SRIOV lane were skipped
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/5835/pull-kubevirt-e2e-kind-1.19-sriov/1415867369615527936

Hey @marceloamaral @rmohr, all tests on SRIOV lane were skipped
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/5835/pull-kubevirt-e2e-kind-1.19-sriov/1415867369615527936

@marceloamaral apologies for the confusion. This PR was reverted because of CI impact. Would you be able to re-submit this PR with the problem corrected?
We apologize for the inconvenience. This certainly is an exceptional case.


feature #184

Pull Request Test Coverage Report for Build 125912934

48 of 51 (94.12%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 88.818%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sly/parser/generator/ExpressionRulesGenerator.cs
48
51
94.12%

Totals

Change from base Build 116562257:
0.08%

Covered Lines:
3846

Relevant Lines:
4279

💛  - Coveralls


Folders are not created with docker-compose

Describe the Bug
I´ve mounted a folder inside my docker-compose file but folders like /gamefiles or /backups are not created when starting the server or after shutting it down.
Your Runtime Command or Docker Compose File
version: '3'
services:
    satisfactory-server:
        container_name: 'satisfactory-server'
        hostname: 'satisfactory-server'
        image: 'wolveix/satisfactory-server:latest'
        ports:
            - '7777:7777/udp'
            - '15000:15000/udp'
            - '15777:15777/udp'
        volumes:
            - /root/docker/satisfactory_compose/config:/config'
        environment:
            - MAXPLAYERS=4
            - PGID=1000
            - PUID=1000
            - STEAMBETA=true
        restart: unless-stopped

Hey! Could you upload your runtime log, please? Additionally, please provide your system specs per the bug report issue template.

Hey, thanks for the quick reply!
Actually I got it running after all. I was missing a single quote at the beginning of the volume declaration.
Cheers.


family with man woman girl and boy together their shortname conversion is splitting into family with man woman girl shortname combination  and boy shortname separately

shortnames are as folows :family_mwg:  and  :boy:

Mind sending a code sample to reproduce?

👨👩👧👦

String unicode = "\uD83D\uDC68\u200D\uD83D\uDC69\u200D\uD83D\uDC67\u200D\uD83D\uDC66";
System.out.println(EmojiParser.parseToAliases(unicode));

prints :family_man_woman_girl::boy:, looks like the family man+woman+girl+boy combination simply wasn't added
$  grep family_man_woman emojis.json
      "family_man_woman_boy"
      "family_man_woman_girl"
      "family_man_woman_boy_boy"
      "family_man_woman_girl_girl"


unable to get: xxxxxx because of unknown namespace for the cache

配置了钉钉的告警，钉钉收不到信息，notification-manager-deployment 下的 notification-manager 容器报错：
level=error ts=2021-01-24T21:55:30.068356677+08:00 caller=config.go:503 msg="Failed to list rolebinding" err="unable to get: kube-ops because of unknown namespace for the cache"

level=error ts=2021-01-24T21:55:30.068424402+08:00 caller=config.go:549 msg="Unable to find tenantID" err="unable to get: kube-ops because of unknown namespace for the cache"

/assign @wanjunlei

/assign @wanjunlei

@wanjunlei Pls help to find out what's wrong

@wanjunlei Pls help to find out what's wrong

Have you configured this field? If configured, you can delete this field and try again

Have you configured this field? If configured, you can delete this field and try again

删除后可以了

删除后可以了


Adding HTTP API metrics

Description
Add Prometheus HTTP metrics for the HTTP endpoints, about reached endpoint, status codes and response times
Fixes CCXDEV-2219
Type of change

New feature (non-breaking change which adds functionality)

Testing steps
Regular CI

Codecov Report

Merging #86 into master will decrease coverage by 1.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   43.32%   42.09%   -1.23%
==========================================
  Files          12       11       -1
  Lines         891      867      -24
==========================================
- Hits          386      365      -21
+ Misses        464      462       -2
+ Partials       41       40       -1

Impacted Files
Coverage Δ

server/server.go
47.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f3ca8a...f8e09ab. Read the comment docs.


"FATA [0000] permission denied" error on redhat 8

Environmental Info:
K3s Version: v1.26.0+k3s1
Node(s) CPU architecture, OS, and Version:
Linux hostgamma 4.18.0-425.13.1.el8_7.x86_64 #1 SMP Thu Feb 2 13:01:45 EST 2023 x86_64 x86_64 x86_64 GNU/Linux
Cluster Configuration:
2 servers 2 agents
I'm trying to run k3s on redhat 8 server and i see this FATA [0000] permission denied whenever i try to run k3s server
But k3s command works and shows the help window.
Steps To Reproduce:

Installed K3s:
prefer-bundled-bin: true
k3s_use_unsupported_config: true

Expected behavior:
Run k3s server
Actual behavior:
Throws FATA [0000] permission denied
Additional context / logs:
I can't get any logs other than this

How did you install k3s?
Are you running it as root?
What is k3s_use_unsupported_config and where did you get it from?
Why are you using the 1.26.0? There are much newer patch releases available on that minor.

I'm using pyratlab/k3s ansible role , It works on other servers.
yes , running it as root with sudoers
It's a variable for pyratlabs/k3s and we're facing few issues earlier in other server so , we use this variable to resolve it
I'll try newer version and get back

I suggest you strace the command and figure out what it's trying to do that is getting a permission denied error. There's not enough context here to figure out what it's doing. Is this maybe a selinux problem?

I tried the newer version :  v1.27.1+k3s1 , Now it throws me this error message : k3s-server executable file not found in $path.
I have disabled the selinux for testing this.

is something preventing it from extracting the binaries to /var/lib/k3s/data/<RELEASE-HASH>, or running executables out of that directory? Do you have /var mounted readonly or noexec? You should have:
(python310) brandond@seago:~$ ls -la /var/lib/rancher/k3s/data/current/bin/k3s*
-rwxr-xr-x 1 root root 136943800 Apr 19 12:36 /var/lib/rancher/k3s/data/current/bin/k3s
lrwxrwxrwx 1 root root         3 Apr 19 17:00 /var/lib/rancher/k3s/data/current/bin/k3s-agent -> k3s
lrwxrwxrwx 1 root root         3 Apr 19 17:00 /var/lib/rancher/k3s/data/current/bin/k3s-certificate -> k3s
lrwxrwxrwx 1 root root         3 Apr 19 17:00 /var/lib/rancher/k3s/data/current/bin/k3s-completion -> k3s
lrwxrwxrwx 1 root root         3 Apr 19 17:00 /var/lib/rancher/k3s/data/current/bin/k3s-etcd-snapshot -> k3s
lrwxrwxrwx 1 root root         3 Apr 19 17:00 /var/lib/rancher/k3s/data/current/bin/k3s-secrets-encrypt -> k3s
lrwxrwxrwx 1 root root         3 Apr 19 17:00 /var/lib/rancher/k3s/data/current/bin/k3s-server -> k3s
lrwxrwxrwx 1 root root         3 Apr 19 17:00 /var/lib/rancher/k3s/data/current/bin/k3s-token -> k3s

Yes , /var is mounted as noexec . And this is the strace output for the k3s v1.26.4+k3s1
newfstatat(AT_FDCWD, "/var/lib/rancher/k3s/data/24a53467e274f21ca27cec302d5fbd58e7176daf0a47a2c9ce032ee877e0979a/bin/k3s-server", {st_mode=S_IFREG|0755, st_size=132960592, ...}, 0) = 0
execve("/var/lib/rancher/k3s/data/24a53467e274f21ca27cec302d5fbd58e7176daf0a47a2c9ce032ee877e0979a/bin/k3s-server", ["/usr/local/bin/k3s", "server"], 0xc000198a90 /* 24 vars */) = -1 EACCES (Permission denied)
ioctl(2, TCGETS, {B38400 opost isig icanon echo ...}) = 0
write(2, "\33[31mFATA\33[0m[0000] permission d"..., 66FATA[0000] permission denied
) = 66
exit_group(1)                           = ?
+++ exited with 1 +++

yes , selinux was enabled at the start and disabled it later , then reinstalled the k3s .
Does k3s run executables from /var directory ? then , i can try mounting the /var without noexec or use --data-dir to change it's directory right ?

Does k3s run executables from /var directory?

Yep.

i can try mounting the /var without noexec

This is probably the easiest thing to do. I'm not sure which distros are now coming with /var noexec by default, but k3s will not work when this when using the default data-dir.

or use --data-dir to change it's directory

If you do this, set it in the config.yaml so that you don't have to remember to pass it on the command-line all the time.

Opened a PR to improve the error message.

Thanks man , I'll check this configuration.

Reopening for error message improvement.

This is probably the easiest thing to do. I'm not sure which distros are now coming with /var noexec by default, but k3s will not work with this when using the default data-dir.

It's not a distro default, but rather a condition of the "CIS Red Hat Enterprise Linux 8 Benchmark" system hardening policy, which is not an uncommon policy in environments with regulatory or policy constraints;
The rationale for this particular setting is given in the benchmark as "Since the /var filesystem is only intended for variable files such as logs, set this option to ensure that users cannot run executable binaries from /var.", which is reasonable.
"k3s will not work with this when using the default data-dir", in combination with "Using a custom --data-dir under SELinux is not supported." (from [https://docs.k3s.io/advanced#enabling-selinux-enforcement]) creates a Catch-22 situation for running k3s on SCAP-hardened systems, it seems, as enforcing selinux is also a condition in the aforementioned benchmark;
I'd raise this as a bug.

Validated on  branch with commit  / version
Validated on Master Branch:  2b24c9917cdfec92439ac68dd6706fffe20195a5

k3s version v1.27.1+k3s-2b24c991 (2b24c991)
go version go1.20.3

Environment Details

Infrastructure

[X] Cloud
[ ] Hosted

Node(s) CPU architecture, OS, and Version:

Linux ip-172-31-43-6 5.15.0-1033-aws #37~20.04.1-Ubuntu SMP Fri Mar 17 11:39:30 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
NAME="Ubuntu"
VERSION="20.04.6 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.6 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

Cluster Configuration:

1 server

Config.yaml:

Additional files

write-kubeconfig-mode: 644
token: test
prefer-bundled-bin: true
k3s_use_unsupported_config: true

Testing Steps

Copy config.yaml

$ sudo mkdir -p /etc/rancher/k3s && sudo cp config.yaml /etc/rancher/k3s

Add a tmpfs mount to /var in fstab with noexec
Install k3s: curl https://get.k3s.io | INSTALL_K3S_COMMIT=2b24c9917cdfec92439ac68dd6706fffe20195a5  sh -s - server
Check the logs for the new error msg

Replication Results:

k3s version used for replication:

May 15 22:48:33 ip-172-31-43-6 k3s[18528]: time="2023-05-15T22:48:33Z" level=fatal msg="exec /var/lib/rancher/k3s/data/3a5a046ca7504505788f8ab75ca8189219b088c6700b1e19a7aa5e755eb5bde9/bin/k3s-server failed: permission denied"

Validation Results:

k3s version used for validation:

Replicated on v1.27.1:

May 15 20:21:18 ip-172-31-33-29 k3s[2878]: time="2023-05-15T20:21:18Z" level=fatal msg="exec: \"k3s-server\": executable file not found in $PATH"
May 15 20:21:23 ip-172-31-33-29 k3s[2886]: time="2023-05-15T20:21:23Z" level=fatal msg="exec: \"k3s-server\": executable file not found in $PATH"
May 15 20:21:28 ip-172-31-33-29 k3s[2894]: time="2023-05-15T20:21:28Z" level=fatal msg="exec: \"k3s-server\": executable file not found in $PATH"

Validated the new error message:

May 15 22:48:33 ip-172-31-43-6 k3s[18528]: time="2023-05-15T22:48:33Z" level=fatal msg="exec /var/lib/rancher/k3s/data/3a5a046ca7504505788f8ab75ca8189219b088c6700b1e19a7aa5e755eb5bde9/bin/k3s-server failed: permission denied"


examples/getdevices.rs  now just lists devices

Replaced capture code with a pointer to a "how to".  Reason for not
doing a capture on each device, is because it waits forever on devices
without network traffic.
This change also makes the example competable with the project feature of
"list devices".

CI results

19 cancelled, 10 successful, and 2 failing checks

are better has the

24 cancelled, 3 failing, and 4 successful checks

from previous pull request (#155)
For the clippy complains  there is issue #157 created.

CI results

19 cancelled, 10 successful, and 2 failing checks

are better has the

24 cancelled, 3 failing, and 4 successful checks

from previous pull request (#155)
For the clippy complains  there is issue #157 created.

Looks good to me. I thing the getdevices.rs example is more useful this way.
Can I just ask you to rebase on master which now has the clippy issue fixed so that the CI pipeline can run before it gets merged?

Looks good to me. I thing the getdevices.rs example is more useful this way.
Can I just ask you to rebase on master which now has the clippy issue fixed so that the CI pipeline can run before it gets merged?

On Sun, Jan 24, 2021 at 01:41:52PM -0800, Wojciech Kozlowski wrote:

Can I just ask you to rebase on master which now has the clippy issue
fixed so that the CI pipeline can run before it gets merged?

scheduled

On Sun, Jan 24, 2021 at 01:41:52PM -0800, Wojciech Kozlowski wrote:

Can I just ask you to rebase on master which now has the clippy issue
fixed so that the CI pipeline can run before it gets merged?

scheduled

scheduled

It became #161,  closing this merge request.

scheduled

It became #161,  closing this merge request.


⚡ Add deletion frontend implementation

Change List:

loadComments() will now create a button element when loading a comment. the onclick attribute of this button is a function which will delete the comment which it is attached to, and to then refresh the comments on the page.

Before:

After:

depends on #31 and #33


getInitializationEntries contents causes incorrect Error position

Environment
Both iOS and Android, with or without hermes.
Description
When throwing an error inside a repack app (including the TesterApp) the line + column combination is not matching the actual position in the bundle file, therefore the source map lookup ends up on the wrong file/line. The produced source map itself is correct and maps perfectly if getting the position by inspecting the bundle manually or running the bundle via node.
This seems to be caused by the import of react-native package somehow.
Reproducible Demo
Edit TesterApp/index.js to be:
throw new Error('Lol');

and remove ReactNative.getInitializationEntries spread from webpack.config.js and observe that the line+column thrown in RN are correct. Add back ReactNative.getInitializationEntries and see that it doesn't match anymore.

Hi, after throughout investigation we know that:
without any changes to the webpack config we've got following results:

dev=true,minify=false ->  correct stack trace
dev=true,minify=true -> incorrect stack trace
dev=false, minify=true -> incorrect stack trace

with your changes:

dev=true, minify=false -> correct stack trace
dev=true, minify=true -> correct stack trace (/webpackChunkNamec/) will be removed as well so just keep that in mind and be careful.
dev=false, minify=true -> correct stack trace

Turned out that comments that start with @license and ! like those generated by the webpack :) caused JSC to return wrong column number when Error was thrown. In the dev mode before our index there is a different type of comment and probably that's the reason why it works properly. Surprisingly on Hermes everything should work as suppose to !


Current Version crashes when opens on windows 10

Prerequisites

[Yes ] Did you read FAQ section?
[Yes ] Did you test with the latest releases or commit ?

Description
Been having the problem of getting an error on login first saying that the cookie was expired and then an inability to login, Updated to current version when run it crashed the windows closes before I can read any of the error messages, I did copy files to update the version like I ussually do in that I copied db SQLITE file, config configuration setting file, config.ini BAK File and the sqlite3.dll application extension file over to the new version is there a better way to move to new versions. Tried it with a clean unzip and it works fine so it would have to be some thing about coping over the files from the last version that causes this
Steps to Reproduce
Open the program on a windows 10 computer
Copy files from above over to new version
Program should work
Program crashes seconds after opening after some text is shown in the window
Current and unsure been awhile since I updated

run it from the console/cmd so it wont auto close, also check the log file.
If you running from very old version, maybe you need to update the config.ini manually after 1st run (don't copy the old one).

Maybe it's the same issue with this one?
https://github.com/Nandaka/PixivUtil2/issues/618

Ok so i did a little more testing I was able to login with a clean unzip of the program I had to get the login cookie to do so since it asked for a captcha but it worked also ran it in cmd and got the following took a snip of it attached

ran it in cmd and got the following took a snip of it attached

this from not from the clean unzip, right?

Right it is from the one with the files copied over

Any luck?

nothing to check from my side if running clean zip file is working.


UserId idp may have prefix

The idp field of a UserId should identify the identity provider of the user, but it's unclear from the current documentation of cs3apis whether this should be done with a domain (e.g. 'cernbox.cern.ch') or with an origin (e.g. 'https://cernbox.cern.ch').
Recently, the users.demo.json file in the ocmd example switched from the first to the second format.
In https://github.com/cs3org/cs3apis/pull/159 I proposed to make the second format the prescribed one, but we don't want to make this a breaking change, so reva should start supporting origin-format for userid idp in addition to supporting domain-format as it does currently.
We should to make the provider authorizer interceptor accept both formats, I'll create a PR.

@michielbdejong We want to finalize this (in the context of https://github.com/cs3org/reva/pull/3121).
Can you confirm that the proposed format of the idp field, as origin (eg. https://cernbox.cern.ch) is definite ?

In https://github.com/cs3org/cs3apis/pull/159#discussion_r766662560 @wkloucek proposed a 3rd option, namely a full URL. So the options are:

domain, e.g. "cernbox.cern.ch"
origin, e.g. "https://cernbox.cern.ch"
full URL, e.g. "https://cernbox.cern.ch/some/path"

I'm OK with whatever you prefer!


Consider using Faker

Faker appears to be a superset of the functionality given by names. I think it would be helpful to mention it in the README as a more complete solution to data faking.

Is it still up?

new link: https://faker.readthedocs.io/en/master/


scheduled data load workflows

Current workflows should be fine for replicating to production env.
For testing, lots of options:
a. run same scheduled loads on test as on prod
b. do not run scheduled loads, test on old data
c. run scheduled loads quarterly or similar
d. do not run scheduled loads from sources, replicate from prod on schedule
e. do not run scheduled loads to test, access latest data in prod via fdw
Seems easiest to start with option b, then move to d/e at a later date.
Only caveat is that CABD and PSCIS should be refreshed on test when bcfishpass is run.

With (at least) 4 different databases to replicate to, an intermediate cache of key inputs would reduce load on WFS and make data refreshes generally much faster. BC is now providing an object storage bucket, we could create a workflow/job that dumps these layers to file, to be picked up as needed by scheduled loads to the database:

CABD (not really an issue, but a cache is still more efficient)
PSCIS assessments/confirmations/etc
DRA (pending resolution of #496 , DRA is already available as file)
FTEN roads
FISS observations - or (even better) use the file based bcfishobs output to load to bcfishpass databases

In theory, we could get even more efficient - access models output to file from the BC db could be fed into the CWF dbs rather than re-processing.