Error when running TRTIS-20.01 built from source code--"Intel MKL FATAL ERROR: Cannot load libmkl_intel_thread.so"

I am trying to build TRTIS-20.01 from source code with Caffe backend.
I copied the include files and libraries from container of tensorrtserver:20.01-py3 to a folder called 'libs_and_includes 'outside the container
Then I started to compile TRTIS
mkdir buildcaffe
cd buildcaffe
cmake -DTRTIS_EXTRA_LIB_PATHS="~/libs_and_includes/lib/pytorch" ../build
make -j128 trtis

After successful compilation, I put some library paths to my bashrc
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/home/zhouxuan/libs_and_includes/local/mpi/lib
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/home/zhouxuan/libs_and_includes/usr/lib/x86_64-linux-gnu

After that , I tried to run TRTIS
cd ~/tensorrt-inference-server/buildcaffe/trtis/install/bin
./trtserver --model-repository=/home/zhouxuan/tensorrt-inference-server/docs/examples/model_repository

However, I gave me the error info as:

I0303 22:36:26.672772 41069 model_repository_manager.cc:675] loading: resnet50_netdef:1
I0303 22:36:26.672896 41069 model_repository_manager.cc:675] loading: resnet50_netdef_dyna:1
I0303 22:36:26.919968 41069 netdef_backend.cc:199] Creating instance resnet50_netdef_dyna_0_0_gpu0 on GPU 0 (7.5) using init_model.netdef and model.netdef
[E init_intrinsics_check.cc:43] CPU feature avx is present on your machine, but the Caffe2 binary is not compiled with it. It means you may not get the full speed of your CPU.
[E init_intrinsics_check.cc:43] CPU feature avx2 is present on your machine, but the Caffe2 binary is not compiled with it. It means you may not get the full speed of your CPU.
[E init_intrinsics_check.cc:43] CPU feature fma is present on your machine, but the Caffe2 binary is not compiled with it. It means you may not get the full speed of your CPU.
I0303 22:36:26.921154 41069 netdef_backend.cc:199] Creating instance resnet50_netdef_0_gpu0 on GPU 0 (7.5) using init_model.netdef and model.netdef
Intel MKL FATAL ERROR: Cannot load libmkl_intel_thread.so.

libmkl_intel_thread.so does not exist in the container.
The trtserver can be run in the container without libmkl_intel_thread.so, but cannot be run outside the container. Could u help give me some tips about how to solve it ?
Thx !

I assume you mean Caffe2, TRTIS doesn't support Caffe.
Did you build Caffe2 as described in the build section of the documentation and using a command like what is in Dockerfile?
You can see in the container at /opt/tensorrtserver/lib/pytorch that libmkl_gpu_thread.so is available and used by TRTIS. If you build a version that needs libmkl_intel_thread.so you should be able to get that library from your build and install it in the container.

I look at the Dockerfile and It says that

# Needed by Caffe2 libraries to avoid:
# Intel MKL FATAL ERROR: Cannot load libmkl_intel_thread.so
ENV MKL_THREADING_LAYER GNU

Set that envvar before running TRTIS and it should resolve the load error.

Now I remove this error by adding "export MKL_THREADING_LAYER=GNU
" into ~/.bashrc.
However, when I run the server, after the TRTIS loads the models, It just unload the models without printing any error messages. Could you please help me give some advice about how to solve this situation ?

./trtserver --model-repository=/home/zhouxuan/tensorrt-inference-server/docs/examples/model_repository
I0304 19:47:58.346367 45352 metrics.cc:162] found 2 GPUs supporting NVML metrics
I0304 19:47:58.352033 45352 metrics.cc:171]   GPU 0: GeForce RTX 2080 Ti
I0304 19:47:58.357956 45352 metrics.cc:171]   GPU 1: GeForce RTX 2080 Ti
I0304 19:47:58.358193 45352 server.cc:112] Initializing TensorRT Inference Server
E0304 19:47:58.569984 45352 server.cc:139] failed to enable peer access for some device pairs
E0304 19:47:58.571174 45352 model_repository_manager.cc:1505] unexpected platform type onnxruntime_onnx for densenet_onnx
E0304 19:47:58.571268 45352 model_repository_manager.cc:1505] unexpected platform type tensorflow_graphdef for inception_graphdef
E0304 19:47:58.573709 45352 model_repository_manager.cc:1505] unexpected platform type tensorflow_graphdef for simple
E0304 19:47:58.573783 45352 model_repository_manager.cc:1505] unexpected platform type tensorflow_graphdef for simple_string
I0304 19:47:58.573803 45352 server_status.cc:55] New status tracking for model 'resnet50_netdef'
I0304 19:47:58.573814 45352 server_status.cc:55] New status tracking for model 'resnet50_netdef_dyna'
I0304 19:47:58.573850 45352 model_repository_manager.cc:675] loading: resnet50_netdef:1
I0304 19:47:58.573967 45352 model_repository_manager.cc:675] loading: resnet50_netdef_dyna:1
I0304 19:47:58.700096 45352 netdef_backend.cc:199] Creating instance resnet50_netdef_dyna_0_0_gpu0 on GPU 0 (7.5) using init_model.netdef and model.netdef
[E init_intrinsics_check.cc:43] CPU feature avx is present on your machine, but the Caffe2 binary is not compiled with it. It means you may not get the full speed of your CPU.
[E init_intrinsics_check.cc:43] CPU feature avx2 is present on your machine, but the Caffe2 binary is not compiled with it. It means you may not get the full speed of your CPU.
[E init_intrinsics_check.cc:43] CPU feature fma is present on your machine, but the Caffe2 binary is not compiled with it. It means you may not get the full speed of your CPU.
I0304 19:47:58.701001 45352 netdef_backend.cc:199] Creating instance resnet50_netdef_0_gpu0 on GPU 0 (7.5) using init_model.netdef and model.netdef
I0304 19:48:00.884811 45352 netdef_backend.cc:199] Creating instance resnet50_netdef_0_gpu1 on GPU 1 (7.5) using init_model.netdef and model.netdef
I0304 19:48:00.887470 45352 netdef_backend.cc:199] Creating instance resnet50_netdef_dyna_0_1_gpu0 on GPU 0 (7.5) using init_model.netdef and model.netdef
I0304 19:48:01.922263 45352 model_repository_manager.cc:829] successfully loaded 'resnet50_netdef_dyna' version 1
I0304 19:48:02.716350 45352 model_repository_manager.cc:829] successfully loaded 'resnet50_netdef' version 1
I0304 19:48:02.733159 45352 model_repository_manager.cc:808] successfully unloaded 'resnet50_netdef_dyna' version 1
I0304 19:48:02.746322 45352 model_repository_manager.cc:808] successfully unloaded 'resnet50_netdef' version 1
error: creating server: INTERNAL - failed to load all models

It does give an error, it says "error: creating server: INTERNAL - failed to load all models"
And if you look up in the log at the lines starting with "E" you see errors saying that you are trying to load models with platforms that the server doesn't understand. For example,
E0304 19:47:58.571174 45352 model_repository_manager.cc:1505] unexpected platform type onnxruntime_onnx for densenet_onnx
You can load densenet_onnx unless you have built TRTIS with support for onnx.

 I thought that it will run some of the models under the folder. The truth is that it will run only when all of the models under the folder are runnable.
Now I can successfully run it. Thank you !


go 1.16

chore(deps): build with go 1.16
update CI
update README

Thanks @chenrui333 ! Again, sorry for the delay. If you're interested to make more changes, I'd be happy to add you as a contributor on GitHub?

Thanks @chenrui333 ! Again, sorry for the delay. If you're interested to make more changes, I'd be happy to add you as a contributor on GitHub?

Sorry about the delay, yeah, happy to help with the repo maintenance.

@chenrui333 awesome, thanks! Send you an invite.


[1.9-1.12] Implement OAuth scopes

oauth2 for meower
why?
makes custom clients ask for permission and never touch passwords
scopes
admin - meower admin
meower:status - check server status
meower:write - read and write posts
meower:chat - read and write public chat
meower:privchat - read and write private chat
meower:all - everything meower

Others could use oauth natively, meower-vanilla could implement a form of oauth over CL https://stackoverflow.com/questions/10332182/is-it-possible-to-secure-websocket-apis-with-oauth-2-0

also here are more scopes i forgor:
account:read - read account data
account:readsecure - read secure acccount data
account:write - write account data

ignore all the openly and gamr scopes

ignore all the openly and gamr scopes

RIP openly and gamr

@MikeDev101 I'll update the scopes to make more sense in the context of the current state of the rewrite. Please LMK if I've missed anything or if we should add something

minecraft versioning lmao


Using ElementCompositionPreivew.GetElementVisual immediately after running ConnectedAnimation

I don't think this is a bug per se, however, I'm finding that there isn't an easy way to avoid the problem I've encountered.
I am using a ConnectedAnimation to animate an image and text moving from one page to the next during navigation.  On the detail page, I am creating a "Shy Header" just like in the samples.  The problem is that the image and text in the ConnectedAnimation are in the header I'm configuring to be 'shy'.
When I call ElementCompositionPreivew.GetElementVisual on the image (a Rectangle with ImageBrush), it will completely disappear from the screen.  It is still located in the tree, but you can't see an image anymore.  I'm certain it's conflicting with the still running ConnectedAnimation, but the way I am getting around it is not simple.
First, I had to wait for the Completed event on the ConnectedAnimation.  However, that creates a weird situation where the XAML element isn't rendered properly before I take over the Visual.  My Rectangle needs to have a specific Margin of 10, but in this case, it will have zero margin.
Second, (in addition to the 1st point) I tried to wait for the ImageBrush.ImageOpened event before getting the Visual using ElementCompositionPreivew.GetElementVisual .  However, usually the image has already been opened and the event is never fired.  Sometimes it does, usually it doesn't.
Third, I'm checking the underlying BitmapImage to see if it is already loaded by checking for a non-zero PixelHeight.  If that is the case, I get the Visual.  If not, then I wait for the ImageOpened event first.  This seems to be working, but is a really clumsy workaround.
Basically, I'm wondering if this could be improved somehow.
This is the resulting code:
// animation is the ConnectedAnimation that was just started... this is all in the Page.Loaded event
animation.Completed += (s2, e2) =>
            {
                var imageBrush = (ImageBrush)ImageRectangle.Fill;
                var source = (BitmapImage)imageBrush.ImageSource;
                if (source.PixelHeight > 0)
                {
                    Visual profileVisual = ElementCompositionPreview.GetElementVisual(ImageRectangle);
                    profileVisual.CenterPoint = new Vector3(0f, (float)ImageRectangle.ActualHeight, 0);
                    profileVisual.StartAnimation("Scale.X", iamgeScaleAnimation);
                    profileVisual.StartAnimation("Scale.Y", iamgeScaleAnimation);
                }
                else
                {
                    imageBrush.ImageOpened += (s3, e3) =>
                    {
                        Visual profileVisual = ElementCompositionPreview.GetElementVisual(ImageRectangle);
                        profileVisual.CenterPoint = new Vector3(0f, (float)ImageRectangle.ActualHeight, 0);
                        profileVisual.StartAnimation("Scale.X", iamgeScaleAnimation);
                        profileVisual.StartAnimation("Scale.Y", iamgeScaleAnimation);
                    };
                }
            };

Hmmm... on the phone emulator, this was sort of working. On the PC, in a regular app, it does not work at all.  There's something going on with the timing in that case.
I can't get this to work other than to manually put the Margin back in to the Visual after I pull it out of the XAML element using the Offset property.  I'm going to see if I can make a repro...

I created a reproduction of this issue on my GitHub.
https://github.com/limefrogyank/ConnectedAnimationShyHeaderBug
If you'd rather have it in a zip file, I don't remember how to package it without making it giant...

It seems ConnectionAnimations don't work with XamlLight either.  If I have a XamlLight added to the underlying ListViewItem, I'll crash the entire app when the ConnectionAnimation is started on the new page.

Hi @limefrogyank, as part of connected animation platform uses the backing visual to perform its animation which might be causing issue for your scenario. the thing i will recommend is to wait for connected animations to finish before you request the backing visual to perform further operations.
Let me know if this works for you.

@limefrogyank, the pattern we are using for connected animations is to start the connected animations i.e. ConnectedAnimationService.TryStart(...) when imageOpened event is fired, this helps us to get the correct size and perform animations. if you do that and wait from completion of animation then you should be able to avoid the above situation. I'm closing this issue for now. if you have further questions or concerns then please feel free to reactivate this. Thanks!


Adding Perseo extension

I would like to add the Perseo chrome extension to the list:
https://chromewebstore.google.com/detail/perseo/efbombjppellgioieookoaemjjmeaije

No Privacy policies.


ftr: change header for eclipse movement

[TRACEFOSS-763]

@gregors101 FYI I've just merged notification branch to main, so probably you will need to update some files with new version of header :)

@ds-ext-dskrzypczak I merged now the notification branch

@evia-fbedarf IntelliJ adds a newline at the end of the header file, therefore there is an additional newline at each header? Is this ok, or is this an issue. Maybe you check the branch with your local apple environment ...


Spring FeignClient: Error writing to server with long query string

I have 2 spring boot microservices and i'm trying to make a call from service A to service B using FeignClients. Service A client looks like more or less like this:
`@FeignClient(name = "svcb")
public interface SvcBClient {
@RequestMapping(value = "/svcb", method = RequestMethod.GET)
List<DTO> getCustomFieldsSettings(@RequestParam("ids") List<Integer> ids);

}`
with a corresponding spring controller on the other end in service B.
If the list of Integers that i pass from service A to service B exceeds roughly 2000 ids, i get an error "java.io.Exception Error writing to server".
understandly this can easily be changed to use a POST with a body, but my understanding was that there aren't limits to the size of the query string, technically speaking.
so why the error? i'm seeing the error thrown from here in the com.netflix.client.AbstractLoadBalancerAwareClient. Maybe this is a netflix question?
`public T executeWithLoadBalancer(final S request, final IClientConfig requestConfig) throws ClientException {
RequestSpecificRetryHandler handler = this.getRequestSpecificRetryHandler(request, requestConfig);
LoadBalancerCommand command = LoadBalancerCommand.builder().withLoadBalancerContext(this).withRetryHandler(handler).withLoadBalancerURI(request.getUri()).build();
    try {
        return (IResponse)command.submit(new ServerOperation() {
            public Observable<T> call(Server server) {
                URI finalUri = AbstractLoadBalancerAwareClient.this.reconstructURIWithServer(server, request.getUri());
                ClientRequest requestForServer = request.replaceUri(finalUri);

                try {
                    return Observable.just(AbstractLoadBalancerAwareClient.this.execute(requestForServer, requestConfig));
                } catch (Exception var5) {
                    return Observable.error(var5);
                }
            }
        }).toBlocking().single();
    } catch (Exception var7) {
        Throwable t = var7.getCause();
        if(t instanceof ClientException) {
            throw (ClientException)t;
        } else {
            throw new ClientException(var7);
        }
    }
}

`
Thanks

If there error is coming from a class in Netflix than it sounds like a Netflix issue.  I believe there is a limit to how big a GET request can be.
http://stackoverflow.com/questions/2659952/maximum-length-of-http-get-request

I have 2 spring boot microservices and i'm trying to make a call from service A to service B using FeignClients. Service A client looks like more or less like this:
`@FeignClient(name = "svcb")
public interface SvcBClient {
@RequestMapping(value = "/svcb", method = RequestMethod.GET)
List<DTO> getCustomFieldsSettings(@RequestParam("ids") List<Integer> ids);

}`
with a corresponding spring controller on the other end in service B.
If the list of Integers that i pass from service A to service B exceeds roughly 2000 ids, i get an error "java.io.Exception Error writing to server".
understandly this can easily be changed to use a POST with a body, but my understanding was that there aren't limits to the size of the query string, technically speaking.
so why the error? i'm seeing the error thrown from here in the com.netflix.client.AbstractLoadBalancerAwareClient. Maybe this is a netflix question?
`public T executeWithLoadBalancer(final S request, final IClientConfig requestConfig) throws ClientException {
RequestSpecificRetryHandler handler = this.getRequestSpecificRetryHandler(request, requestConfig);
LoadBalancerCommand command = LoadBalancerCommand.builder().withLoadBalancerContext(this).withRetryHandler(handler).withLoadBalancerURI(request.getUri()).build();
    try {
        return (IResponse)command.submit(new ServerOperation() {
            public Observable<T> call(Server server) {
                URI finalUri = AbstractLoadBalancerAwareClient.this.reconstructURIWithServer(server, request.getUri());
                ClientRequest requestForServer = request.replaceUri(finalUri);

                try {
                    return Observable.just(AbstractLoadBalancerAwareClient.this.execute(requestForServer, requestConfig));
                } catch (Exception var5) {
                    return Observable.error(var5);
                }
            }
        }).toBlocking().single();
    } catch (Exception var7) {
        Throwable t = var7.getCause();
        if(t instanceof ClientException) {
            throw (ClientException)t;
        } else {
            throw new ClientException(var7);
        }
    }
}

`
Thanks

Have you resolved this problem? I need help, thanks!

GET has a maximum limit.

GET has a maximum limit.

Not the reason.We have set "method = RequestMethod.POST".

Then you have a different problem. Please open a new issue if you can provide a project that recreates the problem.


Chat color

Is it able to Change Chat color of an receive Message? E.g. if u are in a Group where all members spam af. youll probably receive a Whisper and youll never see it.. So my suggestion to change receivinig Whispers into another color if possible

Added in 2.17


[opencv] DNN feature not installed in UWP

Is your feature request related to a problem? Please describe.
When targeting UWP, the DNN feature (which is a default feature) is supposedly available but is not actually installed (header/lib is not present). There is no error or warning indicating the feature is not supported . It works fine when targeting regular win x64
Proposed solution
Fix installation of missing features in UWP or mark them unsupported
Describe alternatives you've considered
No response
Additional context

Comparison of x64-uwp vs x64-windows vcpkg_installed include folder after installation

@antoine-fresse, Thanks for posting this issue, opencv is now an empty port, it has been ported to opencv4, please use the command ./vcpkg install opencv4[dnn]:x64-uwp to use.

Hello, I am having the same issue here.
After trying the advised solution by JonLiu, I get the message that opencv4:x64-uwp is already installed but I still don't find any mention of the "dnn" features under the include directory of opencv2. However, he is present under the "buildtrees" folder and there is mention of it in the "download" folder as well.


Pass only ints around for pagination

gets rid of another 10 PHPStan errors
Alternatively if null should stay in the base controller, it could just be coalesced to 0 on use I guess?

tbh this seems reasonable, and I don't mind narrowing the hodgepodge of types that we throw around.


Pen+ 103 degree optimization

got the demo on my testing chromebook running from 5fps to 15fps also got the mast on my main computer running 15 fps from 10 fps on firefox (Firefox has the weakest webgl version.)

I can run pen+ on any chromium browser just fine it just seems firefox struggles.


editorconfig: set insert_final_newline to true

Now, editorconfig automatically inserts a final new line when saving a file.
Related to: https://github.com/joyeecheung/node-core-utils/pull/71/ and https://github.com/joyeecheung/node-core-utils/issues/76

Will let this sit for a few hours and then merge since it's a super minor change.

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #78   +/-   ##
=======================================
  Coverage   95.51%   95.51%
=======================================
  Files          13       13
  Lines         446      446
=======================================
  Hits          426      426
  Misses         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 254462e...ac7c668. Read the comment docs.


Http logging

Changes Unknown when pulling af31b0edf2701420877ed69c5c83ff6b31adb8f0 on http-logging into ** on master**.

:+1:

:tada:

Yay

Without squashing?


fix: share name field between two create kb modal

Description
share name field between two creating kb modal and update text
Task Item
Closes #7197
Closes #7196
Screenshots

Coverage increased (+0.008%) to 50.883% when pulling a132bab63b884630831703120e3471e6fa128faa on createKBModal into 58b442f7dcf478132b825684f9cee9155712c629 on main.


Turborepo support (Currently INIT_CWD workaround required)

When using contentlayer inside turbo repo, the config gives an error for importing contentlayer/source-files
This is the same repository for reproduction of the same: https://github.com/0xdhrv/turborepo-with-contentlayer
And, inside apps/starter

Hi @0xdhrv. Thanks for opening this issue and providing a repro. I've just given it a try and can confirm the problem you're running into. This is currently happening due to a limitation in Turborepo itself (see https://github.com/vercel/turborepo/issues/485).
However, until this is resolved you can workaround the problem by simply adding INIT_CWD=$PWD in front of next build in your package.json like the following:
// apps/starter/package.json
  "scripts": {
     // ...
    "build": "INIT_CWD=$PWD next build",
    // ...
  },

I'm having the same issue with lerna. The INIT_CWD=$PWD trick works, but I'd prefer to avoid it.

Yeah, same here but with Yarn workspaces... discovered the INIT_CWD thing myself before finding this issue. What's the intention behind reading from INIT_CWD when resolving the working directory?
<EMAIL_ADDRESS>

@schickling I think ultimately it makes sense to be available in both places, right? That said, I think I would prefer a CLI argument as I have a build step on CI that invokes contentlayer build directly.
I could probably take a stab at this, although admittedly there's a bit of a learning curve with this codebase on account of Effect-TS (and its lack of documentation 😜).

Here's a bunch of detail around my specific case, just so you have it when considering all the idiosyncrasies of package managers 😅
I am using Yarn 1's workspace command and it seems the issue is that it does set INIT_CWD to the root of the repository in this specific case (even though process.cwd() resolves to the package (workspace) in which the package script is being invoked.
Example
Configuration lives @ ~/my-monorepo/packages/site/contentlayer.config.ts
~/my-monorepo/package.json
{
  "name": "my-monorepo",
  "scripts": {
    "start:site": "yarn workspace @foo/site run start",
    "build:site": "yarn workspace @foo/site run build"
  }
}

~/my-monorepo/packages/site/package.json
{
  "name": "@foo/site",
  "scripts": {
    "start": "next dev",
    "build:site": "contentlayer build"
  }
}

From ~/my-monorepo
yarn start:site

and
yarn build:site

...both fail to find the configuration because INIT_CWD is set to ~/my-monorepo (not ~/my-monorepo/packages/site, which is what process.cwd()` returns).
However — if I invoke yarn workspace @foo/site run build directly from ~/my-monorepo, INIT_CWD is not set, and therefore the configuration is resolved correctly.
I'm hoping to get onto Yarn 2+ soon in this project, and I'm curious if it has different behavior for INIT_CWD in these cases. I'm not sure what the "standard" behavior is supposed to be for INIT_CWD, though. Yarn 1 does seem to always set process.cwd() correctly when scripts are invoked on sub-packages.

Finally, I just want to say nice work so far on contentlayer. I really like the approach y'all are taking and I'm so glad I found it :)

Huh, I guess I missed that CLI flag as I was originally looking for the Next.js case... unfortunately it seems to have issues as well (and from playing around it seems like the path provided is relative to INIT_CWD which kinda brings along the same set of problems?)

Maybe I'm missing something or oversimplifying things but I'm pretty sure most tools just use process.cwd() and "just work" (lots of assumptions there as obviously I haven't looked at how everything works).

@jrolfs would you please mind opening a new issue for this with a reproduction repo? (Ideally also including some snippets how you would like it to work vs how it's currently working.)
(PS: In the upcoming version you'll be able to specify the config path in the Next.js plugin - see #248)

This should be addressed with the 0.2.8 release. 🎉

I am getting this error at build step. I am using next13 and monorepo

This still is a problem in turbo repo. INIT_CWD doesn't work for me either.

I removed this line from my next.config and my turbo repo setup now works for me.
const { withContentlayer } = require('next-contentlayer')
I am using tsup to build my package, but the error was still appearing in my turbo build.
is there any reason I would need withContentLayer in a mono repo? when I build my markdown package I am getting refreshed content on my nextjs app and everything looks ok.


Create _config Migration Function

_configuration + plugin.json -> settings.json
@codedungeon: If we don't have any takers on this one, I can do it.  I have already written a fair amount of conversion code already as I  prepare np.Templating.

I can let NotePlan call a migrate() function upon update or install as a "hook" more or less, so the plugin can react to changes without having to check upon execution. Would this work?

Without sketching out a full design, I can't be certain. But I think it's 98% likely this will work.
Note, though, that the behaviour will be quite different if this is a first install (where there won't be any settings to migrate but will need populating) rather an update (where there is either migration from ConfigV1 to ConfigV2, or a possible update to plugin.settings). So perhaps set up two hooks: populateSettings and migrateSettings?

I'm calling this one complete, as its been a week or more since we did the bulk of the migration testing, and no issues with the migration function have emerged.


conda-recipe should not build .egg

Use python setup.py install --single-version-externally-managed at https://github.com/mapd/pymapd/blob/101f21f34f5beb547db5c7928983e45c8d33d7b7/conda-recipes/pymapd/build.sh#L2

Fixed, thanks.


[Bug]: resizing debugger causes log item to collapse

Is there an existing issue for this?

[X] I have searched the existing issues

Description
I have am sending an array of objects to console.log().
When I expand one of these objects and then adjust the height of the debugger (to get a better view perhaps), my expanded object is getting collapsed.
Steps To Reproduce
https://user-images.githubusercontent.com/94514895/225254158-89ff01bf-8f19-4897-a305-58806d73a1c0.mov
Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Cloud

please tag @appsmithorg/query-js-pod if you wish to contribute a fix

@appsmithorg/query-js-pod , i would like work on this issue.

Hi @rohan-arthur , i have raised a pr on this issue , could you pls assign a reviewer for the same , i would happy to resolve the comments if any.
Thanks in advance.


added configuration for dnsEntries

Description
Changes proposed in this pull request:

moved DNS Entries to an Extension
adjusted the tests
removed old code

Related issue(s)

/retest

/retest

/retest

/test pre-busola-integration-test-k3s-cluster

/retest


I3D accuracy when finetuning on UCF-101 is very low

Hi, I tried to finetune i3d on ucf-101 using pretrained models in checkpoint. But the accuracy after 10 epochs is very low (30%) on validation set. I replaced logits layer of i3d and freeze other layers. Here is my script:
python -u train.py
--dataset ucf101
--model i3d
--video_path $DATASET_ROOT/jpg
--annotation_path $DATASET_ROOT/ucfTrainTestlist/ucf101_02.json
--batch_size 6
--num_classes 400
--finetune_num_classes 101
--spatial_size 224
--sample_duration 64
--learning_rate 1e-2
--save_dir $OUTPUT_DIR
--dropout_keep_prob 0.5
--checkpoint_path checkpoints/I3D/rgb_imagenet.pth
--finetune_prefixes logits
--num_scales 1 \
Can you please give me some advice on finetuning on ucf-101?
Thanks!

What other layers are you freezing? I replaced the logits layer but did not freeze any layers and fine tuning for 10 epochs gives about 90% accuracy on the training set and test set of UCF101_01. I have a similar batch size / learning rate too and I used rgb_imagenet.pth as my checkpoint.


add custom property

Description

Can I add custom property in the notion template, like a Slug or Feature (I don't seem to find the code for these property on repo)
Notion Test Page ID

https://github.com/transitive-bullshit/nextjs-notion-starter-kit/issues/17  If missing some metadata, I often end up with something like this
。

Description
Can I add custom property in the notion template, like a Slug or Feature (I don't seem to find the code for these property on repo)
Notion Test Page ID

Hello, does the project support the function of only the article summary instead of the header image preview? Because I don't want to find a picture for every article

@JIeJaitt
This layout just support three options on notion

@JIeJaitt This layout just support three options on notion

When I choose the third option, he still doesn't show the article summary, but an empty image.

This is a default database gallary view @JIeJaitt

 This is a default database gallary view @JIeJaitt

Hello, it is not convenient to communicate through github, can you provide other contact methods? By the way, which country are you from?


use bibtex in kiloword.py

convert references in mne/datasets/kiloword/kiloword.py to use footcite / footbibliography

this was done in my pull request #9058  addressing issue #8905


Add reverse_port argument to launch files

Fixes #252

I updated the commit to leave out any changes to the README file. Can it be merged like this?

Thanks @darkdragon-001!


[1.5.x][KOGITO-5013] Cherrypick missing changes into RHPAM Kogito operator

Signed-off-by: Karel Suta<EMAIL_ADDRESS>https://issues.redhat.com/browse/KOGITO-5013
Many thanks for submitting your Pull Request :heart:!
Please make sure your PR meets the following requirements:

[x] You have read the contributors' guide
[x] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[x] Pull Request contains a link to the JIRA issue
[x] Pull Request contains a description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[ ] Your feature/bug fix has a unit test that verifies it
[ ] You've tested the new feature/bug fix in an actual OpenShift cluster
[ ] You've added a RELEASE_NOTES.md entry regarding this change

/jenkins test

/jenkins test

/jenkins test

/jenkins test


Update graphiql to 0.7.0

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

closing in favor of https://github.com/caskroom/homebrew-cask/pull/44033


expose task name and id to the running task

We should add some hints to the environment that tasks can use:
_task=foo::bar # in line with what bolt will do
_task_id=xxxxxxx
_task_caller=rip.mcollective

Any others you can think of @cdeering?

No, I think that should cover it.

OK I've added this, I am not going to document it since this is basically building the Puppet Inc spec and they have added the _task to the spec recently, relying on the others will make this a choria forked feature which I am not too keen on
So this will just be a little bit extra I guess, not really great


Mongo DB error

Uncaught Promise Error:
MongoNetworkError: failed to connect to server [localhost:27017] on first connect [MongoNetworkError: connect ECONNREFUSED <IP_ADDRESS>:27017]
at Pool. (/home/ubuntu/karma-simple/node_modules/.registry.npmjs.org/mongodb-core/3.1.5/node_modules/mongodb-core/lib/topologies/server.js:564:11)
at Pool.emit (events.js:182:13)
at Connection. (/home/ubuntu/karma-simple/node_modules/.registry.npmjs.org/mongodb-core/3.1.5/node_modules/mongodb-core/lib/connection/pool.js:317:12)
at Object.onceWrapper (events.js:273:13)
at Connection.emit (events.js:182:13)
at Socket. (/home/ubuntu/karma-simple/node_modules/.registry.npmjs.org/mongodb-core/3.1.5/node_modules/mongodb-core/lib/connection/connection.js:246:50)
at Object.onceWrapper (events.js:273:13)
at Socket.emit (events.js:182:13)
at emitErrorNT (internal/streams/destroy.js:82:8)
at emitErrorAndCloseNT (internal/streams/destroy.js:50:3)
[Thu Nov 29 2018 02:02:05 GMT+0000 (Coordinated Universal Time)] [READY] Connected as Mr. House#4316<PHONE_NUMBER>10744618
[Thu Nov 29 2018 02:02:05 GMT+0000 (Coordinated Universal Time)] Uncaught Promise Error:
Error: Request failed with status code 503
at createError (/home/ubuntu/karma-simple/node_modules/.registry.npmjs.org/axios/0.19.0-beta.1/node_modules/axios/lib/core/createError.js:16:15)
at settle (/home/ubuntu/karma-simple/node_modules/.registry.npmjs.org/axios/0.19.0-beta.1/node_modules/axios/lib/core/settle.js:17:12)
at IncomingMessage.handleStreamEnd (/home/ubuntu/karma-simple/node_modules/.registry.npmjs.org/axios/0.19.0-beta.1/node_modules/axios/lib/adapters/http.js:236:11)
at IncomingMessage.emit (events.js:187:15)
at endReadableNT (_stream_readable.js:1098:12)
at process.internalTickCallback (internal/process/next_tick.js:72:19)
What is going on?

Hi, sorry for the delay. Do you have a running MongoDB instance on localhost?

No I'm running on Atlas
On Sun, Dec 2, 2018, 11:00 PM Shikhir Arora<EMAIL_ADDRESS>wrote:

Hi, sorry for the delay. Do you have a running MongoDB instance on
localhost?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/shikhir-arora/karma-simple/issues/11#issuecomment-443589593,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbFv-n6tBC8VXRIMgrY6Njp4AlJndgQMks5u1K_ygaJpZM4Y4ycQ
.

You need to login to your Atlas portal and get the connection string. It'll look like mongodb+srv://c1hkasia-m0f-g085d.azure.mongodb.net/something and you need to configure a user/password/allow your IP through the config on Atlas's portal.


Add contribution guidelines

Create contribution guidelines that specifies code style, PRs, etc.
Also, create MAINTAINERS file.

@ltcptgeneral please change commit message docs to match.

@ltcptgeneral so the commit message should not be a version number. I should be able to look at the commit and know what happened. Save versioning for PRs.


[Feature] Error Messages

Feature Description
Complete all error messages. Also change the style of them.
Topic will be added to the Documentation (#6)

Just reviewing styles.

[ ] Style Review Completed


otel version bump to v1.0.0-RC1

@qinyuguang I created PR https://github.com/gogf/gf/pull/1316 from your branch, so I close this one.


Execute generated command

Maybe I'm just missing something here, but I can't seem to figure out how to acutally have zsh execute whatever codex comes up with, upon pressing enter, it complains about the # and if I press Ctrl+x again, it just generates more commands.
https://user-images.githubusercontent.com/65448408/139941453-7a4974c5-028c-4cfb-b9f6-4c59be16f42d.mp4

Fancy desktop environment you got there.
set -k should do the trick (https://unix.stackexchange.com/questions/33994/zsh-interpret-ignore-commands-beginning-with-as-comments).
Why is the auto completion shown for you before you hit Ctrl+X? Do you have Github Copilot in the command line?

If You mean the grey-ish text, that is just dumb commands from my history.
It does seem to be working with set -k as an option now though, thanks for the quick reply.


I can't compile scss file, Terminal output "No such file or directory"

Hi guys,  Terminal output "No such file or directory". But  the file is already existing。
The screenshot as follow:

Hope you reply

Hey! I think it has to do with your node or node-sass installation. Have you installed node-sass globally? Can you try to uninstall and reinstall node-sass again?
npm uninstall node-sass -g
npm install node-sass -g

After that you should clear the option [Path to node-sass command](https://github.com/armin-pfaeffle/sass-autocompile#path-to-node-sass-command) in Atom and try to compile a SASS file. I node-sass cannot be found, my packages supports you a fix!

Thanks for you reply! I have set  the option [Path to node-sass command] is "/usr/local/bin"  , The issue has fixed.


Lack of documentation for deepFreezeFn

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[ ] Feature request
[x] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior
Docstring of deepFreezeFn doesn't contain any valuable information - only function definition function customDeepFreeze(state) { return freezedState; }. Should it be like that?

Expected behavior
More explanation of how deepFreezeFn can be used.

Minimal reproduction of the problem with instructions
For bug reports please provide the STEPS TO REPRODUCE and if possible a MINIMAL DEMO of the problem via
https://stackblitz.com or similar (you can use this template as a starting point: https://stackblitz.com/github/NetanelBasal/akita-issue-seed).
What is the motivation / use case for changing the behavior?
Better documentation :)

Environment

Angular version: X.Y.Z

Browser:
- [x] Chrome (desktop) version XX
- [x] Chrome (Android) version XX
- [x] Chrome (iOS) version XX
- [x] Firefox version XX
- [x] Safari (desktop) version XX
- [x] Safari (iOS) version XX
- [x] IE version XX
- [x] Edge version XX

For Tooling issues:
- Node version: XX
- Platform:

Others:

What is missing? You get the state, and you need to return a frozen version of it.


crd资源kind大小写的问题

Kubernetes 资源kind 通常以大写字母开头的驼峰命名规范，目前oda canvas的api和component 均为小写，这样会导致使用golang语言开发是不能直接使用code-generator和反射，这样的导致开发非常不便。 golang语言的规范大写字母命名开头的对象为外部可访问对象，小写字母开头的为同package可以访问对象。
kind is normally the CamelCased singular type. Your resource manifests use this.

You are correct that the Kind should be CamelCase. (The PublishedNotification and SubscribedNotification have already adopted this convention, but the component and api CRDs have not). I assume we change the components and api custom resource definition to:
  names:
    plural: "components"
    singular: "component"
    kind: "Component"

and
  names:
    plural: "apis"
    singular: "api"
    kind: "API"

As this is a breaking change I propose that we use this issue as the opportunity to create formal GitHub releases for the Canvas.
See also #160 (and possibly #161).


Custom Analyzer [search_analyzer] failed to find filter under name [russian_morphology]]

Hello!
I'd love to get this plugin working in our environment as searches become slower and slower every day (we've got almost 30000 tickets today).
Environment:
Redmine version                          2.3.1.stable.11898
Ruby version                             1.9.3 (x86_64-linux)
Rails version                            3.2.13
Environment                              production
Database adapter                         Mysql2
I followed all of the instructions and while running the bundle exec rake redmine_elasticsearch:reindex_all BATCH_SIZE=100 RAILS_ENV=production command it failed to create the index. Any ideas?
Loading Rails environment for Resque
** Invoke redmine_elasticsearch:reindex_all (first_time)
** Invoke redmine_elasticsearch:logged (first_time)
** Invoke environment (first_time)
** Execute environment
Creating scope :system. Overwriting existing method Enumeration.system.
OpenIdAuthentication.store is nil. Using in-memory store.
Creating scope :sorted. Overwriting existing method User.sorted.
** Execute redmine_elasticsearch:logged
** Execute redmine_elasticsearch:reindex_all
Recreate index for all available search types
rake aborted!
Can't create index:
{"error":"IndexCreationException[[redmineapp_production] failed to create index]; nested: IllegalArgumentException[Custom Analyzer [search_analyzer] failed to find filter under name [russian_morphology]]; ","status":400}
/www/production/plugins/redmine_elasticsearch/lib/redmine_elasticsearch/indexer_service.rb:74:in `create_index'
/www/production/plugins/redmine_elasticsearch/lib/redmine_elasticsearch/indexer_service.rb:12:in `recreate_index'
/www/production/plugins/redmine_elasticsearch/lib/redmine_elasticsearch/indexer_service.rb:17:in `reindex_all'
/www/production/plugins/redmine_elasticsearch/lib/tasks/index.rake:18:in `block (2 levels) in <top (required)>'
/usr/local/rvm/gems/ruby-1.9.3-p429/gems/rake-0.9.6/lib/rake/task.rb:228:in `call'
/usr/local/rvm/gems/ruby-1.9.3-p429/gems/rake-0.9.6/lib/rake/task.rb:228:in `block in execute'
/usr/local/rvm/gems/ruby-1.9.3-p429/gems/rake-0.9.6/lib/rake/task.rb:223:in `each'
/usr/local/rvm/gems/ruby-1.9.3-p429/gems/rake-0.9.6/lib/rake/task.rb:223:in `execute'
/usr/local/rvm/gems/ruby-1.9.3-p429/gems/rake-0.9.6/lib/rake/task.rb:166:in `block in invoke_with_call_chain'
/usr/local/rvm/rubies/ruby-1.9.3-p429/lib/ruby/1.9.1/monitor.rb:211:in `mon_synchronize'
/usr/local/rvm/gems/ruby-1.9.3-p429/gems/rake-0.9.6/lib/rake/task.rb:159:in `invoke_with_call_chain'
/usr/local/rvm/gems/ruby-1.9.3-p429/gems/rake-0.9.6/lib/rake/task.rb:152:in `invoke'
/usr/local/rvm/gems/ruby-1.9.3-p429/gems/rake-0.9.6/lib/rake/application.rb:143:in `invoke_task'
/usr/local/rvm/gems/ruby-1.9.3-p429/gems/rake-0.9.6/lib/rake/application.rb:101:in `block (2 levels) in top_level'
/usr/local/rvm/gems/ruby-1.9.3-p429/gems/rake-0.9.6/lib/rake/application.rb:101:in `each'
/usr/local/rvm/gems/ruby-1.9.3-p429/gems/rake-0.9.6/lib/rake/application.rb:101:in `block in top_level'
/usr/local/rvm/gems/ruby-1.9.3-p429/gems/rake-0.9.6/lib/rake/application.rb:110:in `run_with_threads'
/usr/local/rvm/gems/ruby-1.9.3-p429/gems/rake-0.9.6/lib/rake/application.rb:95:in `top_level'
/usr/local/rvm/gems/ruby-1.9.3-p429/gems/rake-0.9.6/lib/rake/application.rb:73:in `block in run'
/usr/local/rvm/gems/ruby-1.9.3-p429/gems/rake-0.9.6/lib/rake/application.rb:160:in `standard_exception_handling'
/usr/local/rvm/gems/ruby-1.9.3-p429/gems/rake-0.9.6/lib/rake/application.rb:70:in `run'
/usr/local/rvm/gems/ruby-1.9.3-p429/gems/rake-0.9.6/bin/rake:37:in `<top (required)>'
/usr/local/rvm/gems/ruby-1.9.3-p429/bin/rake:19:in `load'
/usr/local/rvm/gems/ruby-1.9.3-p429/bin/rake:19:in `<main>'
/usr/local/rvm/gems/ruby-1.9.3-p429/bin/ruby_noexec_wrapper:14:in `eval'
/usr/local/rvm/gems/ruby-1.9.3-p429/bin/ruby_noexec_wrapper:14:in `<main>'
Tasks: TOP => redmine_elasticsearch:reindex_all

Any help would be greatly appreciated!
Thanks,
Will

Hi @wreiske,
Seems that "russian_morphology" plugin for elasticsearch has not installed.
see: https://github.com/Undev/redmine_elasticsearch#install

Ahh, seems as though i needed to restart elastic search for the plugin to take affect (duh!)
Maybe add a note about restarting elastic search before running the migrate command for redmine?
Install elastic search
Install plugins
Start elastic search
When i "installed" elastic search, I started the service before the plugins.
Thanks,
Will

Got everything running and I can see the new search bar on the Project's page... I can not however figure out how to search inside issues, notes, wiki, etc. The search bar at the top of the screen (Default search) doesn't seem to use elastic search.
also, i had to install Redis to get this working, not sure if that was in your documentation anywhere.
-Will


Input widgets for date-times with different levels of granularity

Currently a nice date picker is provided
NMDC will also have times, date-times and partial dates like 2020-02

It was left undocumented, but https://github.com/cidgoh/DataHarmonizer/issues/137 covers a solution for the date component that may work for you? The main thing is that whatever the precision - day or month or year - if it is marked as an ISO date field, it must fill in the extra parts YYYY-MM-DD during validation, so this is a mechanism for passive date normalization where that can be done into ISO 8601 dates; so Im not sure if this fits your case.  The image below shows that date formatting is being normalized row-by-row to the YYYY-01-01 or YYYY-MM-01 or YYYY-MM-DD degree of precision based on other field's " precision" setting.  This approach supports dates destined for database date fields, that need date comparison for order at least, and in a sense matching granularity, e.g. year entries will match perfectly, month ones will too.
Here is the spreadsheet data before it gets opened in DataHarmonizer:

When it is opened in DH, the dates get adjusted to match granularity:

As well if some dates can't be matched to granularity (say month is missing but that's the granularity set) then DH will currently put an __ underscore value, e.g. "month" granularity but given date is a year 2020, then "2020-__-01" so that validation trips and user is drawn to specify the desired granularity.
If you simply name the "date ... unit" field to have a different suffix, like "...  precision", then the whole automatic normalization (to first day of month, or first month) process is skipped:

Code portions of main.js are: line 821 for matching [date field] + [date field unit] case, and line 849 for setDateChange().
I will now add documentation to Wiki about it.

Does that seem workable (given that target dates are often SQL database fields)?  Or should we create a new data type, say "partialDate" that can handle YYYY or YYYY-MM ?

I've seen that NMDC has implemented year-only and year+month only fields, which is the alternate way to approach this.  I'll close this within a few days if no objections.

Yes, we're handling this with regular expressions and can accept the absence of point and click widgets for now. Thanks.


feat: working repo submit button

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[x] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Description

repo submission handler function is added, and tried adding existing repos like freeCodeCamp or opensauced hot repo, but it's getting me back 500 or 404 response.

Sign in.
Click User Emoticon at top right corner, and click submit repo.
Type in repo URL (I tried putting freeCodeCamp's repo & OpenSauced/hot repo)
API call returns an error with 500 or 404 response.

Related Tickets & Documents

Resolves #352
Mobile & Desktop Screenshots/Recordings

updated approach
I took this over #394, and solved the problem of handling error codes. I will work on #404 next to start queueing repos that are not indexed in api.opensauced.pizza.

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[x] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
Work on the #404 and this repo - https://github.com/open-sauced/open-sauced-goals - to make a queue for indexing.
[optional] What gif best describes this PR or how it makes you feel?

@open-sauced/triage this one is ready to QA.


Basisc Groups don't have an each method

The Readme states that...

The same example using a non-owning Group:
var group = reg.group(.{}, .{ Velocity, Position }, .{});
group.each(each);

fn each(e: struct { vel: *Velocity, pos: *Position }) void {
    e.pos.*.x += e.vel.x;
    e.pos.*.y += e.vel.y;
}

zig complains:

error: no member named 'each' in struct '.zig-ecs.ecs.groups.BasicGroup'

After looking for it I only managed to find the method each for OwningGroups.
Not that I know if there should or shouldn't be such method but just wanted to point out that the readme seems(?) wrong.

OwningGroup has the added benefit of contiguous array access for the data while non-owning groups have to go through the SparseSet to get to the data. Implementing each for a non-owning group doesnt really have any advantages so it wasnt added.


fix: import for moment in ActivityTable

SUMMARY
bad import for moment
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #11506 into master will decrease coverage by 11.39%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #11506       +/-   ##
===========================================
- Coverage   66.52%   55.12%   -11.40%
===========================================
  Files         871      410      -461
  Lines       41669    13988    -27681
  Branches     3802     3560      -242
===========================================
- Hits        27719     7711    -20008
+ Misses      13848     6101     -7747
- Partials      102      176       +74

Flag
Coverage Δ

cypress
55.12% <ø> (-0.66%)
:arrow_down:

javascript
?

python
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...-frontend/src/views/CRUD/welcome/ActivityTable.tsx
1.61% <ø> (-44.87%)
:arrow_down:

...uperset-frontend/src/dashboard/util/dnd-reorder.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...rset-frontend/src/dashboard/util/getEmptyLayout.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...et-frontend/src/components/Menu/LanguagePicker.tsx
0.00% <0.00%> (-100.00%)
:arrow_down:

...dashboard/components/resizable/ResizableHandle.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/dashboard/util/getFilterScopeFromNodesTree.js
0.00% <0.00%> (-93.48%)
:arrow_down:

...uperset-frontend/src/utils/getClientErrorObject.ts
0.00% <0.00%> (-89.19%)
:arrow_down:

...ntend/src/views/CRUD/annotation/AnnotationList.tsx
3.57% <0.00%> (-88.74%)
:arrow_down:

...c/explore/components/controls/withVerification.jsx
9.09% <0.00%> (-87.88%)
:arrow_down:

...src/dashboard/components/gridComponents/Header.jsx
10.52% <0.00%> (-86.85%)
:arrow_down:

... and 696 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29554a9...d1ba459. Read the comment docs.


no-unknown-property doesn't prevent use of unknown properties?

Today React gave me an "unknown prop" warning:

In this example, I gave my div element an abc attribute, which is obviously invalid HTML.
I was surprised that my linter didn't pick up on this. Looking at the documentation, the name and description of the no-unknown-property rule lead me to believe that this should be caught, but that doesn't appear to be the case.
So, I suppose this is a feature request: add a rule to catch invalid DOM properties.

Were you using spread props, or was it an explicit prop directly on a DOM element?

It was explicit.

I definitely think no-unknown-property should be erroring out on all the same DOM element props that React 15.3 now does.

Phew. This issue looked like "nice and small", but well, was more detective work than I expected 😅
If anyone has more use cases than <div abc="foo" />, feel free to read through and comment on the PR #3377

That's awesome, thanks @sjarva!


Clicking a menu dropdown item should close it to improve mobile user experience

I think that when you click a menu dropdown item or sub menu dropdown item it should close it, this way it becomes really easy to navigate through menus in a small screen.
I would like to help implement this, any idea where to begin?

Hi @magestican, there’s action: 'hide' property that does exactly this, can you please confirm?

Closing the issue until there’s a reply.


merge from arlac77/template-github,arlac77/template-kronos-module

package.json

chore(package): add ^12.2.0 remove ^12.1.4 (devDependencies.documentation)

:tada: This PR is included in version 2.0.14 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: