Lifecycle : ON_DESTROY & ON_CREATE are called after config_change even when a retained Fragment is used as LifecycleOwner

I came across this unexpected behaviour when using AAC-Lifecycle alpha5, where I am using a retained fragment as a LifecycleOwner and a regular class as LifecycleObserver and upon configuration change (orientation change), my Fragment's onDestroy & onCreate were not called as expected, but my Observer class's onDestroy & onCreate methods were called, which was strange for me.
Is this a bug with AAC-Lifecycle or issue with my implementation or am I missing something here?
Here is the code I used,
    compile "android.arch.lifecycle:runtime:1.0.0-alpha5"
    compile "android.arch.lifecycle:extensions:1.0.0-alpha5"
    annotationProcessor "android.arch.lifecycle:compiler:1.0.0-alpha5"

Activity.kt
class Activity : LifecycleActivity() {

    private val TAG = "Activity"

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContentView(R.layout.activity)
        Log.e(TAG, "OnCreate")

        if (savedInstanceState == null) {
            supportFragmentManager
                    .beginTransaction()
                    .replace(R.id.frame_layout, Fragment())
                    .commit()
        }
    }

    override fun onDestroy() {
        Log.e(TAG, "OnDestroy")
        super.onDestroy()
    }
}

Fragment.kt
class Fragment : LifecycleFragment() {

    private val TAG = "Fragmemt"
    private val observer = Observer()

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        retainInstance = true
        lifecycle.addObserver(observer)
        Log.e(TAG, "OnCreate")
    }

    override fun onCreateView(inflater: LayoutInflater?,
                              container: ViewGroup?,
                              savedInstanceState: Bundle?): View? {
        return inflater?.inflate(R.layout.fragment, container, false)
    }

    override fun onDestroy() {
        Log.e(TAG, "OnDestroy")
        lifecycle.removeObserver(observer)
        super.onDestroy()
    }
}

Observer.kt
class Observer : LifecycleObserver {

    private val TAG = "Observer"

    @OnLifecycleEvent(Lifecycle.Event.ON_CREATE)
    fun onCreate() {
        Log.e(TAG, "onCreate")
    }

    @OnLifecycleEvent(Lifecycle.Event.ON_DESTROY)
    fun onDestroy() {
        Log.e(TAG, "onDestroy")
    }
}

I can't find an obvious answer but before taking a closer look, have you tried alpha8?

I just tried with alpha8, unfortunately it's reproducible with alpha8 as well.
    compile "android.arch.lifecycle:runtime:1.0.0-alpha8"
    compile "android.arch.lifecycle:extensions:1.0.0-alpha8"
    annotationProcessor "android.arch.lifecycle:compiler:1.0.0-alpha8"

E/Activity: OnCreate
E/Fragmemt: OnCreate
E/Observer: onCreate
E/Activity: OnDestroy
E/Observer: onDestroy
E/Activity: OnCreate
E/Observer: onCreate

I think it's the same issue with #47


[ISSUE #5785]Translation controller deploy.md chinese document to english document

Make sure set the target branch to develop
What is the purpose of the change
close #5785
Brief changelog

Translation controller deploy.md chinese document to english document

Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #5786 (266cfdb) into develop (e986534) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #5786      +/-   ##
=============================================
- Coverage      42.40%   42.38%   -0.03%
+ Complexity      8226     8221       -5
=============================================
  Files           1060     1060
  Lines          73347    73347
  Branches        9595     9595
=============================================
- Hits           31105    31089      -16
- Misses         38332    38349      +17
+ Partials        3910     3909       -1

Impacted Files
Coverage Δ

...org/apache/rocketmq/store/ha/WaitNotifyObject.java
80.35% <0.00%> (-5.36%)
:arrow_down:

...e/rocketmq/store/ha/autoswitch/EpochFileCache.java
78.47% <0.00%> (-2.78%)
:arrow_down:

...pache/rocketmq/remoting/common/RemotingHelper.java
15.38% <0.00%> (-2.31%)
:arrow_down:

...a/org/apache/rocketmq/filter/util/BloomFilter.java
60.43% <0.00%> (-2.20%)
:arrow_down:

...he/rocketmq/client/trace/AsyncTraceDispatcher.java
82.21% <0.00%> (-1.45%)
:arrow_down:

.../org/apache/rocketmq/store/index/IndexService.java
59.00% <0.00%> (-1.00%)
:arrow_down:

...mq/store/ha/autoswitch/AutoSwitchHAConnection.java
71.08% <0.00%> (-0.82%)
:arrow_down:

...ent/impl/consumer/DefaultLitePullConsumerImpl.java
69.37% <0.00%> (-0.63%)
:arrow_down:

...a/org/apache/rocketmq/store/StoreStatsService.java
34.53% <0.00%> (-0.56%)
:arrow_down:

...che/rocketmq/acl/plain/PlainPermissionManager.java
78.22% <0.00%> (-0.54%)
:arrow_down:

... and 7 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Reverse string slice goes into infinite loop fix

I bumped into #455 in my own code, but a little investigation showed that a small patch to transcrypt/modules/org/transcrypt/__builtin__.js (viewable as the totality of PR #702) would fix it.  I don't think the patch is outsized for the increase in functionality - negative steps in slices are fairly fundamental.  I also don't understand why #455 was marked 'IS:limitation'.

Thanks for the fix.
I think this should be in the next major version.
Still want to take a good long look at it.
And indeed at least there should be a decent error report.

Will be fixed in v3.9.4

This fix (currently on dev_3.9.4 branch) required a bit more extra logic to cover edge cases, but I feel slicing is a foundational feature of Python and the extra code in the runtime is worth being able to move the behavior closer to that of CPython. I also added validations for invalid slices similar to CPython. The updated code shouldn't slow down slicing much for the more common step==1 use cases.


Update BASE_VERSION to master-2022-07-29T19-01-38

I did verify the old image fails trivy the same as the test logs. In the past I had seen trivy fail in the test resulting in a PR, but not locally. Maybe cut to the downloaded DB?


Unnecessary arg in calculate_winsorised_weight

https://github.com/ONSdigital/monthly-business-survey-results/blob/1719e7090aaeb1ae5f277b27fd44b2d75d5b8346/mbs_results/outlier_detection/calculate_winsorised_weight.py#L14
l_values is not used within the function, it can be removed as a parameter

arguments group, period, aux, predicted_unit_value are unused within the function too


dart:ffi: Support variadic C functions

If "dart:ffi" supported varargs calling conventions in X64/ARM64, developers could use Objective-C libraries by using C functions such as objc_msgSend.
Related issues:

Remaining tasks for dart:ffi for Dart 2.6 #38358

Package cupertino_ffi contains the necessary helpers (NSString, reference counting, etc.) for using any Objective-C library, but inability to call the variadic C function objc_msgSend is a blocker.

@terrier989 note that you can just bind to objc_msgSend multiple times with different signatures (with 0, 1, 2, 3, 4, 5, 6, etc additional parameters). Would not that be good enough as a workaround?

@mraleph
In the X64 variadic convention, register AH (RAX) is used pass an upper bound of XMM register arguments to the callee. In the X64-mac trampoline, the function pointer is stored in RAX. After studying this issue more, it seems that objc_msgSend can be safely used with any RAX.

Cool project @terrier989!
/cc @sjindel-google

It sounds like variadic functions are supported as well as possible, given that Dart does not have variadic functions (except for noSuchMethod).

given that Dart does not have variadic functions

We could support variadic functions with a List as argument in the Dart signature, if we really wanted to, but I'm not sure we should.

given that Dart does not have variadic functions

We could support variadic functions with a List as argument in the Dart signature, if we really wanted to, but I'm not sure we should.

We can't support that actually, because the length of the list and the type of arguments in the list needs to be fixed when we compile the trampolines.

given that Dart does not have variadic functions

We could support variadic functions with a List as argument in the Dart signature, if we really wanted to, but I'm not sure we should.

We can't support that actually, because the length of the list and the type of arguments in the list needs to be fixed when we compile the trampolines.

Couldn't we make a generic trampoline like we had in DBC to accomodate for that? It's just going to be relatively slow...

I don't see need for passing a List. This is a calling convention issue.
In X64, the trampoline used by 'dart:ffi' passes an incorrect integer in AH (8 bits of RAX) to varargs C functions. But it's an implementation detail of objc_msgSend whether the wrong integer in RAX causes problems. It probably doesn't, but a simple way to be sure could be putting some high constant into AH before 'call' instruction.
In ARM64, the standard non-varargs ABI passes the first 8 arguments in registers X0-X7, whereas the standard varargs ABI passes all arguments in the stack. However, it turns out that Apple decided to diverge from the ARM64 standard and if I interpreted the document correctly, it's possible to call a varargs function with an ordinary trampoline.

Fair point @terrier989 - I was under impression that varargs calling convention is the same as non-varargs, which turns out is not the case.

In order to distinguish the varargs calling convention from the non varargs calling convention in dart:ffi, we need to indicate that somewhere.
We have some options of doing this:

We add a NativeVarArgsFunction next to NativeFunction, a shared super type of both and let asFunction and lookupFunction support both.
We add asVarArgFunction and lookupVarArgFunction to indicate it should use the vararg calling convention. This kind of weird, because now the lookup looks up a signature which is not designated as varargs, but then is told to be varargs when doing asFunction after a lookup.
We add an annotation on the signatures in asFunction and lookupFunction. (Has the same issue as above.)

They are all equivalent in the sense that they communicate the same information for the creation of trampolines.
If we think about carrying function pointers around in the program, then option 1 allows us to express which calling convention is used:
Pointer<NativeVarArgsFunction<... Function(...)>> fptr = // ...

(N.b. if there are more calling convention variations we want to take into account at some point, that might influence on how we deal with multiple calling conventions. Would we ever want to support a range of 32-bit calling conventions?)
cc @mkustermann

If variadic C functions is unsupported, could inline function generation be an option?
For example, hidctl_open could be a wrapper for open
#include <fcntl.h>

static inline int hidctl_open (const char *__path, int __oflag) {
    return open(__path, __oflag);
}

Why inline? Wouldn't you want to generate non-inline functions so that you can actually bind to them from Dart?
Depending on how many variadic functions you're looking at, it might be worthwhile to make a PR to package:ffigen to generate wrapper functions automatically.

I'm working on https://github.com/Sunbreak/logic_conf.dart, a re-implementation of https://github.com/libusb/hidapi
The linux implementation use open(__path, __oflag,...) in <fcntl.h>: https://man7.org/linux/man-pages/man2/open.2.html
Is it possible to write the wrap code manually?

For example, hidctl_open could be a wrapper for open static inline int hidctl_open (const char *__path, int __oflag) { ... }

The static makes this function not an exported symbol from the shared library. If this is declared in a .h file it is similar to helper macros which we cannot access from Dart either.

The linux implementation use open(__path, __oflag,...) in <fcntl.h>: https://man7.org/linux/man-pages/man2/open.2.html

Can you just bind to open() via a different signature in Dart (either with 2 or 3 parameters)?
The actually problem here is that open() might return -1 and set errno:
RETURN VALUE
       open(), openat(), and creat() return the new file descriptor (a nonnegative integer), or -1 if an error occurred (in which case, errno is set appropriately).

ERRORS
...
       EINTR  While blocked waiting to complete an open of a slow device (e.g., a FIFO; see fifo(7)), the call was interrupted by a signal handler; see signal(7).

So if EINTR is returned you'd want to retry. But right now there's no way to safely obtain the errno set by this call. I've opened an issue for this a while ago https://github.com/dart-lang/sdk/issues/38832
This applies to most syscalls.

Can you just bind to open() via a different signature in Dart (either with 2 or 3 parameters)?

Could you shed some light on how to bind with 2 or 3 parameters?
Or maybe a plain declaration just works?
final int Function(Pointer<Int8> __path, int __oflag) nativeOpen2 = libfcntl
    .lookup<NativeFunction<Int32 Function(Pointer<Int8>, Int32)>>("open")
    .asFunction();

final int Function(Pointer<Int8> __path, int __oflag, int __ext) nativeOpen3 = libfcntl
    .lookup<NativeFunction<Int32 Function(Pointer<Int8>, Int32, Int32)>>("open")
    .asFunction();

Or maybe a plain declaration just works?

Yes. On ia32/arm/arm64 the varargs calling convention for this signature seems to be the same. Only x64 is slightly problematic because it normally requires eax to contain the number of xmm registers to be passed. Though the open function doesn't get any doubles, so it shouldn't matter what eax contain (see also discussion above in this thread).

Seems to work. Thanks a lot
https://github.com/Sunbreak/logic_conf.dart/blob/a2b18a947fec46859ad09fcd44050a305c14909d/linux/libc.h#L10
// FIMXE https://github.com/dart-lang/sdk/issues/38578
// Need manully change name from `open2` to `open` after `ffigen`
extern int open2 (const char *__file, int __oflag) __nonnull ((1));

https://github.com/Sunbreak/logic_conf.dart/blob/a2b18a947fec46859ad09fcd44050a305c14909d/lib/src/linux/libc.dart#L14-L22
  int open2(
    ffi.Pointer<ffi.Int8> __file,
    int __oflag,
  ) {
    return (_open2 ??= _dylib.lookupFunction<_c_open2, _dart_open2>('open'))(
      __file,
      __oflag,
    );
  }

It looks like culprit is the way how variadic ioctl function is defined in dart https://github.com/timsneath/dart_console/blob/f88ab598bf896878b347013400049d0702eecd0c/lib/src/ffi/unix/ioctl.dart#L35
// int ioctl(int, unsigned long, ...);
typedef IOCtlNative = Int32 Function(Int32, Int64, Pointer<Void>);
typedef IOCtlDart = int Function(int, int, Pointer<Void>);

Such ioctl invocation ends up corrupting vm isolate structure causing a crashes.

Originally posted by @aam in https://github.com/dart-lang/sdk/issues/49460#issuecomment-1189649529

It started to fail on mac arm64 because calling convention on that platform for passing variable args for int ioctl(int fd, unsigned long request, ...); differs from what is expected from Int16 Function(Int16 fd, Int32 cmd, Pointer<WinSize> winsize);: variadic args are expected to be on the stack, but latter puts all three args in the registers.

Linux arm64

[NO ERROR] Dart SDK version: 2.18.0-271.4.beta (beta) (Tue Jul 26 10:14:06 2022 +0200) on "linux_arm64"
[NO ERROR] Dart SDK version: 2.19.0-32.0.dev (dev) (Sun Jul 24 15:18:55 2022 -0700) on "linux_arm64"

macOS arm64

[ERROR] Dart SDK version: 2.19.0-32.0.dev (dev) (Sun Jul 24 15:18:55 2022 -0700) on "macos_arm64"
[NO ERROR] Dart SDK version: 2.18.0-271.4.beta (beta) (Tue Jul 26 10:14:06 2022 +0200) on "macos_arm64"

// int ioctl(int, unsigned long, ...);
import 'dart:ffi';
import 'dart:io';

import 'package:ffi/ffi.dart';

typedef IOCtlNative = Int32 Function(Int32, Int64, Pointer<Void>);
typedef IOCtlDart = int Function(int, int, Pointer<Void>);

final TIOCGWINSZ = Platform.isMacOS ? 0x40087468 : 0x5413;
const STDIN_FILENO = 0;
const STDOUT_FILENO = 1;
const STDERR_FILENO = 2;

// struct winsize {
//      unsigned short  ws_row;         /* rows, in characters */
//      unsigned short  ws_col;         /* columns, in characters */
//      unsigned short  ws_xpixel;      /* horizontal size, pixels */
//      unsigned short  ws_ypixel;      /* vertical size, pixels */
// };
class WinSize extends Struct {
  @Int16()
  external int ws_row;

  @Int16()
  external int ws_col;

  @Int16()
  external int ws_xpixel;

  @Int16()
  external int ws_ypixel;
}

void main() {
  final ioctl = DynamicLibrary.process().lookupFunction<IOCtlNative, IOCtlDart>('ioctl');

  final winSizePointer = calloc<WinSize>();
  final result = ioctl(STDOUT_FILENO, TIOCGWINSZ, winSizePointer.cast());
  print('result is $result');

  final winSize = winSizePointer.ref;
  print('Per ioctl, this console window has ${winSize.ws_col} cols and '
      '${winSize.ws_row} rows.');

  calloc.free(winSizePointer);
}

When doing FFI calls to variadic functions we need a binding for a specific amount of arguments on the Dart side. We need to generate machine code ahead of time for the trampolines.
Moreover, we need a way to signify from which argument the variadic arguments start.
API design 1
We could introduce a marker for native signatures as follows:
/// `int printf(const char *format, ...)` with `int` and `double` as varargs.
typedef NativePrintfIntDouble =
    Int Function(Pointer<Char>, VarArgs<Int>, Double);

The VarArgs NativeType would be defined as:
/// Represents the start of varargs in C.
///
/// The signatures in [NativeFunction] need to specify the exact types used for
/// FFI calls.
///
/// For example take calling `printf` in C.
///
/// ```c
/// int printf(const char *format, ...);
///
/// void call_printf() {
///   int a = 4;
///   double b = 5.5;
///   const char* format = "...";
///   printf(format, a, b);
/// }
/// ```
///
/// To call `printf` directly from Dart with those two argument types, define
/// the native type as follows:
///
/// ```dart
/// /// `int printf(const char *format, ...)` with `int` and `double` as
/// /// varargs.
/// typedef NativePrintfIntDouble =
///     Int Function(Pointer<Char>, VarArgs<Int>, Double);
/// ```
///
/// Note how [VarArgs] signals where the variadic arguments start and the all
/// the arguments passed are covered.
///
/// [VarArgs] is not constructible in the Dart code and serves purely as marker
/// in type signatures.
@Since('2.19')
abstract class VarArgs<T extends NativeType> extends NativeType {}

API design 2
Alternatively, we could add a marker before the first variadic argument rather than "around" it:
/// `int printf(const char *format, ...)` with `int` and `double` as varargs.
typedef NativePrintfIntDouble =
    Int Function(Pointer<Char>, VarArgs, Int, Double);

Pro:

All variadic argument types are treated the same, rather than only wrapping the first.

Con:

The Dart and native signature do not have the same amount of arguments.

@dcharkes Maybe we could consider an alternative design which outlaws direct closure calls and instead relies on static dispatch, e.g.
@FfiNative<IntPtr Function(Pointer<Char>, VarArg)>
external int printf(Pointer<Char> fmt, List<Object> args);

printf("%s %d", [nativeValue1, nativeValue2]);  // ok
printf("%s %d", someArray); // error

If somebody needs closure calls we could provide a helper method in FFI for calling variadic functions:
Pointer<NativeFunction<IntPtr Function(Pointer<Char>, VarArg)>> printfPtr;
callVariadic(printfPtr, ["%s %d", nativeValue1, nativeValue2])

If we go this route then we can use local types to lower the call-site (just like it would be in C).

List<Object> args

I believe this will not work, because we need the native types for the arguments at compile time to generate the correct trampoline. (I don't believe every ABI always uses only stack arguments. Some ABIs use the same registers as for regular arguments.)
So with FfiNatives we would still need:
@FfiNative<Int Function(Pointer<Char>, VarArgs<Int>, Double))>
external int printf(Pointer<Char> fmt, int, double);

@dcharkes Oh right. For integers and doubles we need the right size. Maybe then:
@FfiNative<IntPtr Function(Pointer<Char>, VarArg)>
external int printf<NativeType /* extends Record */>(Pointer<Char> fmt, List<Object> args);

Users are expected to do:
printf<(Int32, Double)>("%d %lf", [a, b])

Maybe we could go further and say that the second argument does not have to be a constant array, but rather a tuple of a compatible Dart type?
printf<(Int32, Double)>("%d %lf", (a, b)); // ok

(int, double) v;
printf<(Int32, Double)>("%d %lf", v); // ok too

@dcharkes Oh right. For integers and doubles we need the right size. Maybe then:
@FfiNative<IntPtr Function(Pointer<Char>, VarArg)>
external int printf<NativeType /* extends Record */>(Pointer<Char> fmt, List<Object> args);

Users are expected to do:
printf<(Int32, Double)>("%d %lf", [a, b])

That could work, records essentially give us a way to specify arbitrary types without a function type. :-)
Based on the ABI logic I've seen, we would still need to compile a trampoline for each different call-site signature. (Which requires some refactoring of the current implementation.)
There are still some downsides though:

Manual type checking between the record and type arguments.
asFunction cannot support this, as we don't know the call sites of where the closure flows through.
a. Wrapping in a closure as you suggested works for native assets, but if someone wants to write actual dynamic code with dlopen on a desktop machine we don't support variadic args at all. (I believe you or @mkustermann  mentioned some time back that keeping DynamicLibrary in dart:ffi instead of complete removing it would be a good thing. If so, we should probably support the same feature set.)
If we have multiple call sites of a variadic argument with the same native types, they need to be repeated every time. (Though with my earlier design having different native types will lead to multiple definitions which will likely be postfixed with the native type.)

Pros:

Single definition. 👌

Maybe we could go further and say that the second argument does not have to be a constant array, but rather a tuple of a compatible Dart type?

I don't understand. The arguments never have to be constants right? Only the type arguments denoting the native types have to be. The example you give is normal tuple syntax right, so they are both an expression not a constant.

I don't understand. The arguments never have to be constants right? Only the type arguments denoting the native types have to be. The example you give is normal tuple syntax right, so they are both an expression not a constant.

Sorry, I've chosen a wrong word. What I meant to say is that for List based APIs we could require that vararg list is a list literal at the call site this would allow us to emit necessary unboxing operations at the call-site itself (essentially inlining the trampoline). This however requires us to know that we are calling a vararg function - hence reliance on FfiNative (declarative) binding.
The record based invocation has more freedom, because we know number and types of arguments from the record type itself. Though to simplify the implementation we probably still want to outlaw indirect calls to vararg functions and instead require people to use a special helper to invoke such functions indirectly.

We can use record types:
/// `int printf(const char *format, ...)` with `int` and `double` as varargs.
typedef NativePrintfIntDouble =
    Int Function(Pointer<Char>, VarArgs<(Int, Double)>);

Blocked by

https://github.com/dart-lang/sdk/issues/49719

Remove support for single positional element records. They don't have any current use and are a syntactic wart. If we later add support for spreading argument lists and single element positional records become useful, we can re-add them then.

https://github.com/dart-lang/language/blob/master/accepted/future-releases/records/records-feature-specification.md
@munificent this forces us to use
class VarArgs<T extends Object> ...

instead of
class VarArgs<T extends Record> ...

Not really a big issue IMO, but it requires some more special casing in the documentation and implementation.

Since records are supported now (if experiments flag is enabled) it seems this issue is unblocked now, right?
One interesting thing to think about is how this would work for bindings generation from .h files: It wouldn't know what specific var-args signature to use when generating method(s) for a vararg method. Either it could generate a lookup of pointer and require users to fp.asFunction or one would need to specify in the configuration.

Since records are supported now (if experiments flag is enabled) it seems this issue is unblocked now, right?

Correct, and I happen to have implemented this over the holidays: https://dart-review.googlesource.com/c/sdk/+/276921
I still need to clean it up and split it up before sending it out for review.

We went back and forth on single-field records. They were removed at one point, but we added them back in and the feature does support them now, along with a Record supertype.

We went back and forth on single-field records. They were removed at one point, but we added them back in and the feature does support them now, along with a Record supertype.

Do we also support unary record types though?
tests/ffi/function_callbacks_varargs_generated_test.dart:109:63: Error: Expected ')' before this.
typedef VariadicAt1Int64x2Type = Int64 Function(Int64, VarArgs<(Int64)>);
                                                              ^

I do not get similar errors for nullary or multi-field records.

Do we also support unary record types though?

Yes. To be consistent with unary record expressions (and to potentially allow parenthesized types if we later get more complex type expressions), we require unary record types to also have a trailing comma:
typedef VariadicAt1Int64x2Type = Int64 Function(Int64, VarArgs<(Int64,)>);

(I don't know if the implementations support it yet, but that's the correct syntax.)


Support JWT custom claims

Proposal
I propose to support custom claims in the generated JWT token.
The user fields to be included as claims could be specified by adding auth:"jwtInclude" (to follow current auth prefix).
This would allow people putting custom information in the token, e.g. when thinking about username, some additional name fields or permissions (I saw you're planning support in the future).
Possible drawbacks
By default - none, if someone uses too many fields then the token will be heavy, but that's up to user of the framework.
Additional information
I think I can handle this contribution if you agree.

Hello and thank you for your proposal! I was planning on adding a auth.GenerateTokenWithClaims() function in the near future, which would let you add custom claims.
Can you elaborate on how you planned on implementing this feature? I think this would be a great addition.
Do you need your JWT in other applications? You probably don't need to add anything else than the ID of the user since the authenticator will fetch the user for you in the database, so I'm not sure a struct tag auth:"jwtInclude" would be really useful (and it would require some reflection).

I was planning on adding a auth.GenerateTokenWithClaims() function in the near future, which would let you add custom claims.
Can you elaborate on how you planned on implementing this feature? I think this would be a great addition.

Adding auth.GenerateTokenWithClaims() would help, my plan was simply not to introduce additional functions, but it actually may be better to do so to not use reflection too much. The idea was to add auth:"jwtInclude" annotation to the fields from the User struct which should be added to the token, then get this values from the user object and simply put them as claims, but as you already said, this would require reflection to get the fields annotations and may slow things down.

Do you need your JWT in other applications? You probably don't need to add anything else than the ID of the user since the authenticator will fetch the user for you in the database, so I'm not sure a struct tag auth:"jwtInclude" would be really useful (and it would require some reflection).

It can be used for e.g. to put user first and last name to the token, so when the user is logged in I can simply look into the token and display his name in the header menu (e.g. avatar button on github, there is Signed in as <nickname> text) without the need to execute a call to /users/me (or some similar route). But it's not critical. The authenticator fetching the user object is really great feature and implementing such /me endpoint is not a big hassle with that.
What I proposed was mainly front-end related to just read the token and not call APIs, may be improvement for some people, but I agree that in this case separate function may be better approach.

I understand your use-case. The best approach would be to implement your own Login handler and use this new GenerateTokenWithClaims() function to add everything you need, instead of using the built-in JWTController. But re-implementing that is quite a bit of work and produces duplicate code.
Maybe we could add some features to the JWTController to make it more flexible. What would you think about something like this?
jwtController := auth.NewJWTController()
jwtController.TokenFunc = func(r *goyave.Request, user interface{}) (string, error) {
    return auth.GenerateTokenWithClaims(jwt.MapClaims{
        "name": user.(*model.User).Name
    })
}

Yeah, I think it's good idea, while leaving the default as it is currently. Then we don't have any breaking changes.

If you are still interested in the implementation of this, please let me know! Any contribution is very much welcome!

Yes, I'm interested ;)


Domain activation is Failed - [BRIEF DESCRIPTION]

App Id: d2ats8z60hszzo
Region: us-east-1
Step: Domain activation
Status: Failed

Note: Do not include information that is sensitive in nature such as your domain name, company etc.

Issue/question
Unable to register sub-domain, DNS provider is Route 53.
Error message
Error message: One or more of the CNAMEs you provided are already associated with a different resource.
Retry
Additional information
There is no sub-domain with that name on route 53

Hi. @hello123456734 ,
As the error indicates, the domain name was already attached as a CNAME in another cloudfront distribution, when the domain activation took place. Did you have this domain attached to another amplify app or directly to CloudFront? If so, you would have to delete the amplify app/ remove it from the CloudFront distribution via the CloudFront Console. Then you can delete and re-add the domain to your app.
Please refer to our documentation here as well https://docs.aws.amazon.com/amplify/latest/userguide/custom-domain-troubleshoot-guide.html#i-get-a-cnamealreadyexistsexception-error

Resolving due to age - re-open if you are still facing the issue!


cron test error -- ./modules/transfer_mmar.ipynb

Describe the bug
logs from https://github.com/Project-MONAI/MONAI/runs/3604008777?check_suite_focus=true
real	0m14.757s
user	0m18.861s
sys	0m12.270s
Running ./modules/transfer_mmar.ipynb
Checking PEP8 compliance...
Running notebook...
Before:
    "max_epochs = 50\n",
After:
    "max_epochs = 1\n",
Before:
    "val_interval = 2\n",
After:
    "val_interval = 1\n",

Executing:   0%|          | 0/30 [00:00<?, ?cell/s]
Executing:   3%|▎         | 1/30 [00:00<00:23,  1.24cell/s]
Executing:  10%|█         | 3/30 [00:04<00:39,  1.47s/cell]
Executing:  13%|█▎        | 4/30 [00:04<00:28,  1.08s/cell]
Executing:  20%|██        | 6/30 [00:06<00:24,  1.03s/cell]
Executing:  37%|███▋      | 11/30 [01:38<03:51, 12.20s/cell]
Executing:  57%|█████▋    | 17/30 [03:49<03:44, 17.24s/cell]
Executing:  70%|███████   | 21/30 [03:55<01:47, 11.96s/cell]
Executing:  87%|████████▋ | 26/30 [03:57<00:30,  7.65s/cell]
Executing:  87%|████████▋ | 26/30 [03:59<00:36,  9.20s/cell]
Traceback (most recent call last):
  File "/opt/conda/bin/papermill", line 8, in <module>
    sys.exit(papermill())
  File "/opt/conda/lib/python3.8/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/opt/conda/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/conda/lib/python3.8/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/click/decorators.py", line 21, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/papermill/cli.py", line 250, in papermill
    execute_notebook(
  File "/opt/conda/lib/python3.8/site-packages/papermill/execute.py", line 122, in execute_notebook
    raise_for_execution_errors(nb, output_path)
  File "/opt/conda/lib/python3.8/site-packages/papermill/execute.py", line 234, in raise_for_execution_errors
    raise error
papermill.exceptions.PapermillExecutionError:
---------------------------------------------------------------------------
Exception encountered at "In [14]":
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
/tmp/ipykernel_76540/512289039.py in <module>
     16     step = 0
     17     set_determinism(seed=42)
---> 18     for batch_data in train_loader:
     19         step += 1
     20         inputs, labels = (

/opt/conda/lib/python3.8/site-packages/torch/utils/data/dataloader.py in __next__(self)
    519             if self._sampler_iter is None:
    520                 self._reset()
--> 521             data = self._next_data()
    522             self._num_yielded += 1
    523             if self._dataset_kind == _DatasetKind.Iterable and \

/opt/conda/lib/python3.8/site-packages/torch/utils/data/dataloader.py in _next_data(self)
   1201             else:
   1202                 del self._task_info[idx]
-> 1203                 return self._process_data(data)
   1204
   1205     def _try_put_index(self):

/opt/conda/lib/python3.8/site-packages/torch/utils/data/dataloader.py in _process_data(self, data)
   1227         self._try_put_index()
   1228         if isinstance(data, ExceptionWrapper):
-> 1229             data.reraise()
   1230         return data
   1231

/opt/conda/lib/python3.8/site-packages/torch/_utils.py in reraise(self)
    429             # instantiate since we don't know how to
    430             raise RuntimeError(msg) from None
--> 431         raise exception
    432
    433

AttributeError: Caught AttributeError in DataLoader worker process 0.
Original Traceback (most recent call last):
  File "/opt/conda/lib/python3.8/site-packages/torch/utils/data/_utils/worker.py", line 287, in _worker_loop
    data = fetcher.fetch(index)
  File "/opt/conda/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 52, in fetch
    return self.collate_fn(data)
  File "/opt/conda/lib/python3.8/site-packages/monai/data/utils.py", line 275, in list_data_collate
    return default_collate(data)
  File "/opt/conda/lib/python3.8/site-packages/torch/utils/data/_utils/collate.py", line 74, in default_collate
    return {key: default_collate([d[key] for d in batch]) for key in elem}
  File "/opt/conda/lib/python3.8/site-packages/torch/utils/data/_utils/collate.py", line 74, in <dictcomp>
    return {key: default_collate([d[key] for d in batch]) for key in elem}
  File "/opt/conda/lib/python3.8/site-packages/torch/utils/data/_utils/collate.py", line 84, in default_collate
    return [default_collate(samples) for samples in transposed]
  File "/opt/conda/lib/python3.8/site-packages/torch/utils/data/_utils/collate.py", line 84, in <listcomp>
    return [default_collate(samples) for samples in transposed]
  File "/opt/conda/lib/python3.8/site-packages/torch/utils/data/_utils/collate.py", line 74, in default_collate
    return {key: default_collate([d[key] for d in batch]) for key in elem}
  File "/opt/conda/lib/python3.8/site-packages/torch/utils/data/_utils/collate.py", line 74, in <dictcomp>
    return {key: default_collate([d[key] for d in batch]) for key in elem}
  File "/opt/conda/lib/python3.8/site-packages/torch/utils/data/_utils/collate.py", line 74, in default_collate
    return {key: default_collate([d[key] for d in batch]) for key in elem}
  File "/opt/conda/lib/python3.8/site-packages/torch/utils/data/_utils/collate.py", line 74, in <dictcomp>
    return {key: default_collate([d[key] for d in batch]) for key in elem}
  File "/opt/conda/lib/python3.8/site-packages/torch/utils/data/_utils/collate.py", line 53, in default_collate
    numel = sum(x.numel() for x in batch)
  File "/opt/conda/lib/python3.8/site-packages/torch/utils/data/_utils/collate.py", line 53, in <genexpr>
    numel = sum(x.numel() for x in batch)
AttributeError: 'numpy.ndarray' object has no attribute 'numel'

this is still an issue


make all pom files consist

Pull Request Test Coverage Report for Build 1012

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 68.94%

Totals

Change from base Build 577:
0.0%

Covered Lines:
11697

Relevant Lines:
16967

💛  - Coveralls


Allow use of custom port value in Alt-Svc header.

Fixes https://github.com/lucas-clemente/quic-go/issues/3262

@googlebot I signed it!


ClassGenerator skips methods which named the same as PHP keywords

For example: php-amqp extension has class \AMQPExchange with method name "declare" that you can't set as lazy service. Proxy bridge will generate wrong code

+1

To me, this doesn't appear to be a solution to your issue. Some thoughts:

This should be handled in Ocramius/ProxyManager instead of re-implementing functionality from that package and trying to merge it into Symfony. I'd suggest a bug report there (assuming my next point doesn't convince you).
That said, I would not consider this a bug. ProxyManager assists in outputting code that is later independently executed by the PHP interpreter. When it creates this code, it should (and currently does) properly align with the language requirements of PHP. As such, ignoring the use of reserved keywords would result in much more devastating problems by creating code that will cause an unrecoverable interpreter error if someone unknowingly uses a reserved keyword for method names or otherwise. Doing as you purpose outright rejects and ignores the language specification (in the case of reserved keywords, defined at http://php.net/manual/en/reserved.keywords.php). I don't know off-hand when the "declare" keyword was reserved, so I assume it is possible you are running a PHP version that doesn't care, but unsupported PHP versions should not be the target.

In my opinion, you should file a request with php-amqplib/php-amqplib for them to properly follow the language specification.

Forgot to mention:
it is unlikely you will get any official response from Symfony core maintainers at this location: you should initiate a conversation on the Symfony project (the symfony/symfony GitHub project). It is my understanding that these repositories serve solely as read-only sub-tree splits and are otherwise not directly tracked, maintained, or committed to.


Can't compile using Clang on Windows

Clang 10.0
Compiling on Windows targeting Windows
After updating from revision 96f9f5c4b970140ab5380fb9886ba787c8698937 to current 3327050ca66ad34426a82c217c2d60ced61526b7
error: no such file or directory: '/clang:-Wall'

C:\PROGRA~1\LLVM\bin\clang.exe -D_GLFW_USE_CONFIG_H -D_UNICODE -ID:/Projects/l2mapconv-public/libs/glfw/include -ID:/Projects/l2mapconv-public/libs/glfw/src -Ilibs/glfw/src -g -Xclang -gcodeview -O0 -D_DEBUG -D_DLL -D_MT -Xclang --dependent-lib=msvcrtd   /clang:-Wall -MD -MT libs/glfw/src/CMakeFiles/glfw.dir/context.c.obj -MF libs\glfw\src\CMakeFiles\glfw.dir\context.c.obj.d -o libs/glfw/src/CMakeFiles/glfw.dir/context.c.obj   -c D:/Projects/l2mapconv-public/libs/glfw/src/context.c

I think issue caused by this commit: https://github.com/glfw/glfw/commit/ac627706ef93362caf08bd3bf249656efd9151e8

I've change the line in src/CMakeLists.txt
if ("${CMAKE_C_SIMULATE_ID}" STREQUAL "MSVC")
to
if ("${CMAKE_C_COMPILER_FRONTEND_VARIANT}" STREQUAL "MSVC")
and it compiles now.
But I not sure if it broke clang-cl support.
Also CMAKE_C_COMPILER_FRONTEND_VARIANT is supported only in CMake 3.15+ (https://gitlab.kitware.com/cmake/cmake/-/merge_requests/3650/diffs)

I've changed the line in src/CMakeLists.txt
if ("${CMAKE_C_SIMULATE_ID}" STREQUAL "MSVC")
to
if ("${CMAKE_C_COMPILER_FRONTEND_VARIANT}" STREQUAL "MSVC")
and it compiles now.
But I'm not sure if it broke the clang-cl support.
Also CMAKE_C_COMPILER_FRONTEND_VARIANT supported only on CMake 3.15+ I think.

Hey all, I've just had this exact same issue. The aforementioned fix works for me as well (change CMAKE_C_SIMULATE_ID to CMAKE_C_COMPILER_FRONTEND_VARIANT)

This should be fixed now with 061a0263a9783c1442ad96a061c717c167ab4a76. Thank you for reporting this!

Thank you for fixing it! 🙌
On 22 Apr 2021, 10:18 PM +0100, Camilla Löwy @.***>, wrote:

This should be fixed now with 061a026. Thank you for reporting this!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.


Create kekfile

@abh80,thx for submitting this PR

@abh80,Please type > ready to merge

ready to merge

ready to merge

ready to merge


param example attribute complex type support?

v5.6.3
I'm trying to get an example to populate from  to swagger UI

/// <summary>
        /// asdfasdf
        /// </summary>
        /// <param name="id" example="1"></param>
        /// <param name="inputData" example="{"myDataId":"1"}"></param>
        /// <returns></returns>
        [HttpPut("{id}")]
        [ProducesResponseType(StatusCodes.Status204NoContent)]
        [ProducesResponseType(StatusCodes.Status404NotFound)]
        [ProducesResponseType(StatusCodes.Status500InternalServerError)]
        public async Task<IActionResult> UpdateData(int id, MyData inputData)

With that encoded JSON it appears in my xmlcomments output file.
<member name="M:Webapi.Controllers.MyDataController.UpdateData(System.Int32,Webapi.Models.MyData)">
            <summary>
            asdfasdf
            </summary>
            <param name="id" example="1"></param>
            <param name="inputData" example="{"myDataId":"1"}"></param>
            <returns></returns>
        </member>

But doesn't appear in Swagger.json

Based on code here:
https://github.com/domaindrivendev/Swashbuckle.AspNetCore/blob/95cb4d370e08e54eb04cf14e7e6388ca974a686e/src/Swashbuckle.AspNetCore.SwaggerGen/XmlComments/XmlCommentsParameterFilter.cs#L79
It does look like it tries to ConvertFromJson
I also tried to define an example at the class level, but that didn't work either

azsdke2e
azsdke2e2
ddcc1

Pinging @domaindrivendev - is there a workaround for this or a release in which you plan on resolving this? @jongio pinged me about this from the SDK team - was wondering if there's a way forward or if this is by design.

So - there's a few things here. Firstly, when providing JSON object/array examples via XML comments you need to use the following sytntax to workaround XML encoding issues:
<!-- for parameters -->
<param name="inputData" example='{ "myDataId": 125 }'></param>

<!-- for properties -->
<example>{ "myDataId": 125 }</example>

However ... I've delved into the code and can see that while this works well for Open API parameter definitions, it is not currently implemented for OpenAPI requestBody definitions - a miss in the original implementation. I think I can add this and get a new release minted fairly quick. As it's so simple, I'm happy to knock it out now. Stay tuned.

Thanks @domaindrivendev! Keep us posted.

@jongio that's all merged in - before I push to the official Nuget feed, could you possibly pull down the 6.1.4 preview from myget.org and ensure the syntax I outlined above now works for your usecase:
https://myget.org/feed/domaindrivendev/package/nuget/Swashbuckle.AspNetCore

Awesome.  Testing now.

Confirmed this works!
Thank you so much for fixing that so quickly.


Can't init Provider in non-Node environment

Hey! We'd like to be able to instantiate AccountClient client-side, but it relies on Provider which in turn requires a Wallet class, which currently relies on the Node-only NodeWallet class.

Is there a recommended way to work around NodeWallet trying to read from the fs, so that we can use it browser-side?
Is supporting client-side usage of Provider on the roadmap?

Provider is an interface now that does not include the NodeWallet in its definition, so you can implement a Non-Node Provider.
In earlier releases, you can construct a Provider object with a non-node wallet


Fix inability to extend private documentation text

[x] Add regression tests for #1318
[x] Fixes #1318

:+1:


say how to remove password from guest user

Staged at https://ci.openmicroscopy.org/job/OMERO-DEV-merge-docs/ws/src/omero/_build/html/sysadmins/server-upgrade.html. Documents https://github.com/openmicroscopy/openmicroscopy/pull/5526.

👍

Looks good 👍

In light of https://github.com/openmicroscopy/www.openmicroscopy.org/pull/144 maybe this should be amended to cover both aspects of the workaround. I'll hold off merging for now.


Symfony7, PHP 8.3

Hello, I am using actively using your bundle in my projects. Currently, I am working with Symfony 7 with PHP 8.3, it seems the bundle is not compatible yet with them, are you going to update it?

hi @jbouzekri, thanks a lot for your answer. It gives an error in the bundle configuration tree. maybe Symfony changed a bit structure of the configs.

@hovorma : can you post the exception please ?

sure, after the "composer require" of your bundle, during cache:clear I get this error

@hovorma  : can you test the branch https://github.com/jbouzekri/PhumborBundle/tree/feat-sf7 ? If it works for you, I will merge it and tag a new release.

Thanks @FabianSchmick
@hovorma : 3.2.0 version released with the #25 MR.


New version: NLPModels v0.9.1

Registering package: NLPModels
Repository: https://github.com/JuliaSmoothOptimizers/NLPModels.jl
Created by: @abelsiqueira
Version: v0.9.1
Commit: f150e5811cbea95d0e52bd04c39cf3e45e079d35
Reviewed by: @abelsiqueira
Reference: https://github.com/JuliaSmoothOptimizers/NLPModels.jl/commit/f150e5811cbea95d0e52bd04c39cf3e45e079d35#commitcomment-36060909

[noblock] Are backward compatibility update discouraged?

It’s allowed. This is a bug in automerge.
@fredrikekre Can you manually merge this?
[noblock]


.dropify().destroy()?

It would be quite handy to destroy dropify.
I have turned dropify on for a specific class (.dropify). If a new element is created with the same class and I call dropify again I will end up with two dropify elements on any objects which already existed.
Would be handy to remove them or at least have a check method? for example, isDropified()?

Thanks for the feedback. :+1: Really good advice, I have to check if it's already "dropified". I'll work on it soon!

Awesome, nice uploader by the way :)

Fixed in #23.


Use Cloudflare CDN for assets

Use Cloudflare for assets after they're deployed to production.

Can't do this until v1.0.0 is deployed.

Not a viable option at the moment. Will reconsider at later date.


[TEXT-181] fix javadocs

as title

Coverage remained the same at 98.672% when pulling 88d6408a765434be3a46418a9fe0c751e49db5b2 on XenoAmess:fix_javadocs into d36a5faf0560fce4f0d23ded7db8c915c68def91 on apache:master.


Pytorch weights

@dougsm
There's something wrong with your saved pytorch model.
It seems that only you can load the file with torch.load().

for example in your weight file, what is the ggcnn_large ?  I think it must be ggcnn2 but when I changed it manually, it turned out another errors etc.
So i think it'd better if you can send me the weights only.

Hi @trungpham2606
Sorry about that. I've uploaded new weights files (both the full pytorch model and the state dicts) and added instructions to the README. Please make sure you pull the newest version of the repo just to make sure the code all matches the weights I just uploaded.

@dougsm
Thank you so much.
Iam gonna test it right now


set swipeThreshold

Hello, I would like to kindly request for the addition of the swipeThreshold property to the react-native-reanimated-carousel component. This will allow us to specify a percentage threshold for horizontal swipe gestures before transitioning to the next slide. Thank you for your attention to this matter.

I found a workaround that you can use, until or if they add it. What you can modify is the "resistance" using a custom animation (look at examples on repository main page), which is a function with the input/argument of the animation value provided by the carousel, by adding or subtracting from it you can increase or decrease the resistance.
Example below will reduce the resistance:
const customAnimation = useCallback((value: number) => {
  'worklet';

  if(value > 0) {
    value = value + 0.15
  } else {
    value  = value - 0.15
  }

  // animation...

  return  // your custom animation...

})

be more clear. Where do you even call this customAnimation? Moreover he is not asking anything related to animation.

A swipeThreshold would really be great

You can try the maxScrollDistancePerSwipe props.
BTW: Can someone improve the documentation here? If It works for this scenario. Thanks!
More details: https://github.com/dohooo/react-native-reanimated-carousel/blob/9f3a3d6be31a251528fce89613b6308c5382fa93/src/components/ScrollViewGesture.tsx#L354


Issue related to toolbar

When i click to fill the background color for cell or row than color are not displaying but coloirng is happening only color is not showing insted its showing blank white space.Refer the schreenshot.

I am not sure if I understood that correctly. Can you kindly rephrase it, please? Can you check for errors in the console?

When i going to fill the color then in toolbar i am click on format_color_fill. Than its showing white space No error is showing in console.Refer the image 1 and 2
1.
2.

It seems something related on your side. Take a look on this one.
https://bossanova.uk/jexcel/v3/examples/spreadsheet-toolbars
Please make sure you are using the most recent version, and all files are included correctly in your side.

It seems something related on your side. Take a look on this one.
https://bossanova.uk/jexcel/v3/examples/spreadsheet-toolbars
Please make sure you are using the most recent version, and all files are included correctly in your side.
I check it is conflicting with my bootstrap.min.css.If i commenting my bootstrap.min.css than color is comming.

I check it's conflicting with my bootstrap.min.js.If i removing the bootstrap.min.js than color is displaying.
Is there any idea to avoid the conflict.


Clarifies language around secrets and the example

Current language around secrets and how to implement them is slightly confusing

Clarifies with a mention of the following snippet in the preceding paragraph so you know what you're about to look at.

Keep a commented list of the secrets used in your code in your wrangler.toml file, like the example under [vars]:

Yes! thanks for bringing this up, it should be [vars] indeed.


[API only, don't merge] API for JSON builder.

Issue #198

I was just about to ask the design of this. What is the size of the buffer passed into az_json_builder_init? Is there a way to estimate it?

@katmsft good question! For now, we will use fixed size. In the future, I would propose to use polymorphic write functions. In this case, one of the write functions can calculate a size. However, if we switch to polymorphic writers, we may no need this and write/stream directly to HTTP buffer.

Ho

@katmsft good question! For now, we will use fixed size. In the future, I would propose to use polymorphic write functions. In this case, one of the write functions can calculate a size. However, if we switch to polymorphic writers, we may no need this and write/stream directly to HTTP buffer.

How large would be the fixed size?
Is there anywhere the polymorphic writers are designed so I can take a peek?


Code review feedback from pipeline_flow changes

    Continue an operation using a new operation.  This means that the new operation

may be say a new worker operation

Refers to: azure-iot-device/azure/iot/device/common/pipeline/pipeline_flow.py:22 in 5b897f5. [](commit_id = 5b897f504af94d792445fab7ec1eeda9153f242a, deletion_comment = False)


Release 0.3.5

@rultor release it; the tag is 0.3.5.

@rultor release it; the tag is 0.3.5.

@rafamizes OK, I will release it now. Please check the progress here

@rultor release it; the tag is 0.3.5.

@rafamizes Done! FYI, the full log is here (took me 2min)


Mouse cursor not updated correctly when selecting nodes by dragging on zoomed out node graph

Discord username
No response
What type of issue is this?
Intermittent – Occurring irregularly
Is this issue blocking you from using Enso?

[ ] Yes, I can't use Enso because of this issue.

Is this a regression?

[ ] Yes, previous version of Enso did not have this issue.

What issue are you facing?
When trying to select nodes while having zoomed out graph for better view, cursor position was not calculated properly with the scale. All mouse movements were proportionally scaled up but the cursor position was in a wrong place - like it was scaled down.
https://user-images.githubusercontent.com/108271897/236217189-fcb151ad-a735-4857-ae7d-3fc01ad6d4c2.mp4
(errors you see to the right are from different bug - were there before this behavior occurred)
Expected behaviour
When zoomed out mouse cursor follows the real mouse position.
How we can reproduce it?
zoom out
select nodes by dragging
Screenshots or screencasts
No response
Enso Version
2023.5.3 nightly
Browser or standalone distribution
Standalone distribution
Browser Version or standalone distribution
standalone
Operating System
Windows
Operating System Version
Win11pro 22H2 22621.1555
Hardware you are using
12th Gen Intel(R) Core(TM) i9-12900HK / RTX3060 Laptop / Nvidia Drivers 531.68

This is the same issue as this one: https://github.com/enso-org/enso/issues/6549

@wdanilo remember to add proper label in such cases

@farmaazon right, thanks!
@xvcgreg I confused this issue with another one, sorry. Reopening.
@MichaelMauderer When you were recently working on selections, did you test them with camera movement? https://github.com/enso-org/enso/pull/6487

@MichaelMauderer When you were recently working on selections, did you test them with camera movement? #6487

I think I panned, but don't quite remember about zooming out. The issue was specified about the bounding box (as is the fix, which only changes the bbox computation), so that seemed less relevant.

I cannot reproduce it on develop. @xvcgreg Can you reproduce it on the newest nightly?

@farmaazon newest nightly is unfortunately unusable for me on this project anymore. I reproduced it several times on Monday with the freshest Nightly from the weekend.

@farmaazon sure, here it is:
Unnamed_5.zip
but last week it was on much earlier stage. You can probably remove the first 2 sections of that setup.

Checked Windows, 2023.2.1-nightly.2023.5.6 package, and the uploaded project, and still could not reproduce it.
Perhaps the cause is somewhat related to the fact, that on video we constantly see (+) icon.

Reading the code, I have the following observations:
The main issue might be not the zoom or some cursor offset, but the fact, that the cursor has wrong style.
While selecting, the cursor style should be a box of appropriate size. But in the video, I see the cursor stuck with + sign style. As the cursor position is in the middle of the selection box, thence the impression of the offset.
However, I still cannot reproduce the styling-cursor problem.

styling cursor is the issue that appears randomly pretty often (multiple times per day) when testing the product

I did the yesterday bookclub without spotting the issue with cursor. I suspect #6540 could fix that. @sylwiabr have you seen the issue recently?

Didin't observe it today/yesterday


rdbg prompt never appears, I can't see what I type (terminal echo) when using bin/dev (Foreman)

Your environment

ruby 3.1.2p20
rdbg 1.5.0
rails 7.0.3
Mac M1 (Apple Silicon)

Describe the bug
I added binding.break to my rails controller, and it breaks as expected. But there is no rdbg prompt, and I can't see what I type in the terminal. And when I do type something, I have to hit enter several times to get a response. And the response is always an error, since it only accepts the first character of what I typed.

Ok, I figured out that this only happens when I'm using bin/dev to run my development server. rails server does not have this problem. So it has something to do with using Foreman to run multiple processes in parallel. Any ideas about how to fix this?

@marshmallowcreme 👋 recently, I came in contact with a Rust-based Foreman cousin: mprocs, which starts described processes and allows you to switch between them, a bit like tmux (or screen). It allows you to interact with the debugger normally (seeing what you wrote).
This may or may not be relevant to your quest.

@olleolleolle Thanks. I tried it out, but was unable to see any echo in the terminal window, and no rdbg prompt. Hitting enter would return nothing.

@marshmallowcreme Thanks for trying it out. Perhaps that ruled out something.

I'm not sure about the architecture of foreman, but there are issue reports.
I want to wait for the person who knows details...

@marshmallowcreme Just to narrow down the cause, do you see a similar issue when using binding.irb?

👋 FWIW I have a similar issue, with a similar machine and Ruby/Rails versions. Neither binding.irb nor debugeer work. Running bin/rails s (i.e. outside of Foreman) allows me to debug.

Can I help provide more info for this somehow?

An alternative is to have debug listen on a port or socket, and then connect a separate debugger process to that port or socket.
You can update your Procfile.dev to do this for you.
bin/rdbg --port 3001 --open --nonstop --command -- bin/rails server

Then just run a debugger process in another window.
bin/rdbg -A 3001

Having debug and foreman work correctly together might be tough as they are possibly both competing for stdin.

I have the same problem, but the debugger just hangs with bin/rails s, no interactive shell starts and I can't Ctrl-C to stop the server.

An alternative is to have debug listen on a port or socket, and then connect a separate debugger process to that port or socket.
You can update your Procfile.dev to do this for you.
bin/rdbg --port 3001 --open --nonstop --command -- bin/rails server

Then just run a debugger process in another window.
bin/rdbg -A 3001

Having debug and foreman work correctly together might be tough as they are possibly both competing for stdin.

@adam12 what is inside bin/rdbg?

what is inside bin/rdbg? Thanks

@elalemanyo It's the debug binstub from bundler. bundler binstubs debug

It is not possible to interact directly with a debug breakpoint (or pry's or byebug's I believe as well) within the foreman process because it is just streaming the output of however many processes you define in your procfile.
You can however, enable remote debugging for debug when you start the rails app, so that you can run your foreman process in one terminal tab/window, and run rdbg -a in a separate terminal tab/window that connects to it.
Here's a blog post with more information: https://dev.to/ayushn21/remote-debugging-in-rails-7-49nh


Blank tiles

Hi
I'm having issues with a number of blank tiles. Sometimes when zooming those tiles get filled in at specific zoom ranges, but most of the time they are blank.
Depending on the map the number of blank tiles ranges between 0 and +-30. For a specific map, the number of blank tiles and the location of the blank tiles are consistent across app restarts.
I'm only using a level count of 1 and no errors are thrown while loading the map and the tiles.
Do you have any idea what could be the cause of this?
Thanks in advance!

Hi,
I tried to reproduce it locally, in a demo with a single level. No blank tiles.
Which version of MapView are you using?

Hi,
I tried to reproduce it locally, in a demo with a single level. No blank tiles.
Which version of MapView are you using?

Hi, at first I was using version 2.1.3. I upgraded to 2.1.4 and the issue remains.
I've created a demo that always reproduces the issue for me with a lot of blank tiles:
https://github.com/uyt95/BlankTilesDemo

Hi, at first I was using version 2.1.3. I upgraded to 2.1.4 and the issue remains.
I've created a demo that always reproduces the issue for me with a lot of blank tiles:
https://github.com/uyt95/BlankTilesDemo

I've tried your demo on my device and on two emulators, and I never saw a blank tile. Nice map BTW.
This is really surprising. Have you reproduced your issue on other devices?

I've tried your demo on my device and on two emulators, and I never saw a blank tile. Nice map BTW.
This is really surprising. Have you reproduced your issue on other devices?

I wasn't able to reproduce it on other devices, but I found the cause.
Xiaomi devices have a bad forced dark mode implementation that sometimes overwrites tiles with a blank tile. To fix this, I added the following to my application style: <item name="android:forceDarkAllowed">false</item>
Thanks for your help!

I wasn't able to reproduce it on other devices, but I found the cause.
Xiaomi devices have a bad forced dark mode implementation that sometimes overwrites tiles with a blank tile. To fix this, I added the following to my application style: <item name="android:forceDarkAllowed">false</item>
Thanks for your help!


⚠ Jenkins Plugins Artifactory has degraded performance

In bd1d4bc, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1413 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 36c22fb after 20 minutes.


pyQt5 is not supported

... hopefully, this is easy once the crash issue has been fixed.
pyFDA should detect at startup whether pyQt5 is available and set a corresponding global flag for doing something like
if PYQT5:      from PyQt5 import QtGui      from PyQt5.QtCore import pyqtSignal  else:      from PyQt4 import QtGui      from PyQt4.QtCore import pyqtSignal
For details see http://pyqt.sourceforge.net/Docs/PyQt5/pyqt4_differences.html

only new-style signal-slot connections have been used so far, so this shouldn't be a problem
"disconnect() takes no arguments and disconnects all connections to the QObject instance" - this could be problematic
"PyQt4’s QtGui module has been split into PyQt5’s QtGui, QtPrintSupport and QtWidgets modules" - this needs to be checked

Implemented in v0.1rc2


Support for defer parsing lambda functions

Fix up the parser to enable the defer parse methods to handle lambda functions. All lambdas are allowed to be deferred, even lambdas with compact parameter lists or function bodies.
Should also allow lambda functions to be redeferred, which is really the main reason to do this work.
One of the related changes is in Parser::Parse. I changed this function to skip calling ParseStmtList in the case where we are defer parsing a single function. In these cases we know that we are going to parse a function so we don't need to start parsing a set of statements, then one statement, then one expression, then one terminal, etc until we finally start parsing the function via ParseFncDecl. Instead we can just jump directly to ParseFncDecl after setting up the correct flags. By doing this, we can avoid reparsing the lambda parameter list (because we never assume it will be an ordinary expression list) which saves us the headache of bookkeeping the block and function ids.
One other change of note is in ScopeInfo::SaveSymbolInfo. We now need to save symbol info for the arguments symbol since a lambda may be deferred in a function and lambdas capture the arguments value from their parent. I suppose we could move the arguments default binding into a regular special symbol at some point in the future.

Thank you, @pleath


Consider to respect scope parameter of Refresh Request to obtain access tokens with narrower scope

For example if we have original access_token with resource owner authorized scopes ["api1", "api2", "offline_access","openid"] we can request refresh with api1 scope only and use obtained token for access api1 resource only.
Also id_token may be omitted in response if scope parameter provided and not contains openid/other identity resource scopes.

Tracked
https://github.com/IdentityServer/IdentityServer4/issues/3519
https://github.com/IdentityServer/IdentityServer4/issues/3520


Can't get limitlessled via git

Hey,
I use the hass.io version 0.72.0 on my raspberry 3 and I have some trouble to get the limitlessled module from the light platform running.
I added according to the limitlessled configuration following example configuration:
light:
  platform: limitlessled
  bridges:
    - host: <IP_ADDRESS>
      groups:
      - number: 1
        name: Bedroom

I restarted the system and the following error messages appear:
18-06-23 07:15:26 INFO (MainThread) [hassio.addons.git] Clone addon https://github.com/home-assistant/home-assistant/blob/master/homeassistant/components/light/limitlessled.py repository
18-06-23 07:15:27 ERROR (MainThread) [hassio.addons.git] Can't clone https://github.com/home-assistant/home-assistant/blob/master/homeassistant/components/light/limitlessled.py repo: Cmd('git') failed due to: exit code(128)
  cmdline: git clone --recursive -v https://github.com/home-assistant/home-assistant/blob/master/homeassistant/components/light/limitlessled.py /data/addons/git/9ba7ee61
  stderr: 'Cloning into '/data/addons/git/9ba7ee61'...
fatal: repository 'https://github.com/home-assistant/home-assistant/blob/master/homeassistant/components/light/limitlessled.py/' not found
'.
18-06-23 07:15:27 ERROR (MainThread) [hassio.addons] Can't load from repository https://github.com/home-assistant/home-assistant/blob/master/homeassistant/components/light/limitlessled.py

The automatically initiate git clone failed.
Did I do something wrong?

There should be no git clone for limitlessled, this seems like a misconfiguration of hassio.addons.git.

I found the issue. I used the hass.io image with an unsupported raspberry pi 3+


etcd-tester: skip compaction after different hash

When hashes don't match, there could be some nodes
falling behind and the compact request can then error
with 'future revision compact'.

/cc @xiang90

Why not quorum/linearized Get before compacting to ensure all members caught up?

@heyitsanthony I think the problem @gyuho is trying to solve here is to not continue to do compaction once the test already failed.

@xiang90 PTAL.
@heyitsanthony Yeah the root cause was the failure before the compaction error. This commit doesn't solve the problem actually. This is more like to produce cleaner logs for debugging so that we don't get duplicate failure logs.
Thanks!

@gyuho CI failed?

@xiang90 I don't think it's related?

https://travis-ci.org/coreos/etcd/jobs/124624880#L1029
https://semaphoreci.com/coreos/etcd/branches/pull-request-5145/builds/4 - https://github.com/coreos/etcd/issues/5147 created an issue

@xiang90 Ping?

lgtm

thanks. will redeploy after I finish up the release.


Warn about long Squash and Merge commit message

When merging pull requests with Squash and Merge button it's possible to write too long header message, resulting trauncated line in commit log.
It would be useful to add a warning, similarly to what GitHub shows for file edit interface

Not sure if the limit should be 50 characters, like github has, or 72, like in commitlint/config-conventional and vscode's git.inputValidation setting.
It may be also useful to add a per-line limit to commit body and add countdown, like in vscode with "git.inputValidation": "always":

Makes sense. PR welcome.

For anyone that wants this, please also send this feature request to GitHub<EMAIL_ADDRESS>

I think the solution should be simpler:

[x] Set the field size to 70 (the actual git limit, afaik)
[x] Set the font to monospace so you can just see how many characters are left
[ ] Limit the input to 70 via maxlength attribute

This is easier to implement. PRs welcome


SAK-46435 Assignment students grade is not visible after it has been released

https://sakaiproject.atlassian.net/browse/SAK-46435

Too late - but I think this will merge too.


logging support

First off kudos for the awesome work, great to see a high performance Python web framework!
I've noticed japronto.Application contains several print statements. It would be nice to replace them with logging calls so it's easier for apps to suppress output or more generally customize how are things being logged.

When I run japronto on my local machine, it outputs the urls that are being accessed e.g.:
<IP_ADDRESS> GET /
<IP_ADDRESS> GET /favicon.ico

However, when I run japronto in a docker container, I don't see these outputs. So I'm trying to figure out what code is responsible for these outputs. Please give me some hints.


allow an optional unique_name instead of a uuid for the module name

Is your feature request related to a problem? Please describe.
the uuid is great for being unique, but for the platform engineer, having objects named pepr-<uuid>-<stuff> is great for knowing what it is, it's especially worst if there are multiple modules deployed.
Describe the solution you'd like
Leave the UUID in as is, allow for another optional parameter called UNIQUE-NAME, that will be used instead of the UUID if it's populated.

I think maybe it would be cleaner to rename the config entry and document better. Right now you can change the value of pepr: uuid in the package.json (a UUID is not actually required). But maybe we change it from uuid -> uniqueID or similar?

You can supply anything in the UUID field in the package.json, this is already a possibility and it is use at your own risk.


Include travis-ci

Since you are using codeship and it works internally for your team, I thought that for the rest of the community it's a nice to have travis-ci as a tool where we can see if to know if everything works in different ruby versions.

closing issue due the lack of response


You exceeded your current quota, please check your plan and billing details

I use an api key under an org that still with 120 USD this month, which should not exceed the limit, but I still received this from the response: OpenAI: You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors. (insufficient_quota)

You have to ask OpenAI about this.
That image is showing that you had a credit of $18 but it expired on April 1st 2023, so you ran out of credits. It has nothing to do with the limit, the credit is the issue.
The link you pasted says:  "429 - You exceeded your current quota, please check your plan and billing details	Cause: You have run out of credits or hit your maximum monthly spend.
Solution: Buy more credits or learn how to increase your limits"


Fix blue glow on input field

Fixed blue glow on input field.

Why the !important?

To prevent other frameworks and default browser behaviours. If you want, in this case, you can omit it.

There's a reason that other frameworks and the browser might change it.

:umbrella: The latest upstream changes (presumably c4e96ea) made this pull request unmergeable. Please resolve the merge conflicts.

Merged by c4e96eab3294115842f5de3e8b737daebd1dc6dc


⚠ PrivateHD has degraded performance

In 86bab84, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 2016 ms

Resolved: PrivateHD performance has improved in e513e93.


0.1.0: Intro DataConnector and DataLoader

Description

Motivation and Context

How has this been tested?

Types of changes

[ ] Maintenance (no change in code, maintain the project's CI, docs, etc.)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.

Most of the content has been completed except for the documentation.
This PR contains the following main elements:

Data Connector and DataLoader implemented
Cacher for DataLoader and CacherManager for extensions
Some chore: docs build test, example...


Fix issue with 'UID' string in Dockerfile used for System Test

Jira issue: https://issues.apache.org/jira/browse/KAFKA-12847
Fixes #12847
Signed-off-by: Abhijit Mane<EMAIL_ADDRESS>Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Closing issue, details in https://issues.apache.org/jira/browse/KAFKA-12847


It looks like rl_run.py is custom for Code Translation, but I want to do a Code Completion task

It looks like rl_run.py is custom for Code Translation, but I want to do a Code Completion task

love from the 100th stars QAQ


GEODE-3955: Add AEQ and Gateway Sender information to 'describe region' output.

I feel like the non-trivial refactoring deserves its own commit, if only for ease of review in this pull request.
My inexperience with Mockito is showing through and I got a little carried away in the RegionDescriptionJUnitTest.  I don't know if the spy on its consumption in DescribeRegionCommand is beyond the scope of a reasonable JUnit and/or if we have (or should have) proper coverage of that in wider-scope tests.  I don't really like how I dug into the command output JSON.  So on the one hand, I don't really like those tests and could see them getting deleted.  But on the other hand, it is more test coverage in the cheap JUnit category.  Thoughts?

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[x] Does gradlew build run cleanly?

[x] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

In your Junit test, looks like you are extending the test to what's done in the DescribeRegionCommand. Let's get together to pair on wring a unit test for the command only.


Fix and re-enable TimingModuleTest

For some reason the transitive dependency isn't picked up in OSS, so make it hard.
@bestander

@facebook-github-bot shipit


libreoffice-fresh: <IP_ADDRESS> -> <IP_ADDRESS>

Motivation for this change
The main motivation was to drop gtk2/qt4 - the updated version was just a side-effect...
Support for both gtk2 and qt4 has been deprecated, so dump that.
Also add support for Qt5 and KDE.
Now, in an ideal world, the following should also happen, but I wanted to get some feedback on this first (and hopefully have this be part of .09):

still hasn't been touched - we should at the very least dump gtk2/qt4 from there as well.
when building the -kde variant, we should not build with gtk3 support at all (assuming that is possible)
the expression for -still and -fresh are almost identical. They should be merged into a single function.

Known issues:

If you build libreoffice-kde and run it with SAL_USE_VCLPLUGIN=gtk3 it works, but the icons are messed up.

Closes #57846
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @7c6f434c

@GrahamcOfBorg build libreoffice-still libreoffice-fresh libreoffice-kde

@GrahamcOfBorg build libreoffice-still libreoffice-fresh libreoffice-kde

Sigh. KDE integration apparently needs quite a bit of care… But oh well, everything is reasonable, it's just the amount of small things.
Re: Still: yes, probably, it would be nice to have the same there.
Re: KDE and GTK3 — our Qt5 depends on GTK3, even just qt5.qtbase. Is there any point to complicate things further if closure won't change?
Re: Still and Fresh — the idea is (or was by now?) to have a clean Fresh expression that changes when upstream changes something; and it doesn't need complicated version conditionals that will be left in place beyond the time of relevance; the Still expression gets overwritten by a copy of Fresh on minor version bumps and then typically only gets patchlevel bumps. But now the rate of upstream buildsystem changes is lower and a unified expression would not be full of kludges.

Re: Still: yes, probably, it would be nice to have the same there.

OK, I'll fix that first then.

Re: KDE and GTK3 — our Qt5 depends on GTK3, even just qt5.qtbase. Is there any point to complicate things further if closure won't change?

No there isn't. I'll clean it up.

Re: Still and Fresh — the idea is (or was by now?) to have a clean Fresh expression

Maybe we do this later?

Yes, I am of course fully OK with Still and Fresh continuing to be two snapshots corresponding to different minor versions.

Also tried to build the -kde variant but it crashes when I do File->Open...: https://gist.github.com/mmilata/c2cd91600b6b415349da7ba85cf6b952

I've tried to unify the -fresh and -still expressions, please let me know what you think: #75850


[Feature Request] Webhook Components: Explicit Development and URL Provision for Enhanced Flow Triggering in Langflow

Reasons for Suggestion
Although Langflow currently features a Wait component in beta, creating a more explicit and dedicated Webhook component would clarify and strengthen the flow's triggering mechanism. By providing a specific URL for webhook triggers, it simplifies external integration and enhances the usability and reliability of automated workflows.
Content of the Proposal
Develop a dedicated Webhook component that allows users to explicitly set up and use webhooks as triggers for flows in Langflow. This component should provide a clear interface for entering a callback URL, and it should handle incoming webhook calls effectively to initiate the corresponding flow.
Technical Considerations

Design and implement a user-friendly interface for setting up the Webhook component with URL configurations.
Ensure robust handling of incoming webhook requests, including authentication and error handling.
Integrate this component seamlessly with other components in Langflow, maintaining the overall performance and security.

Potential Use Cases

Automated Task Initiation: Use Webhook components to automatically start processes in response to external events (e.g., new data entry, external system triggers).
Integration with External Systems: Simplify the integration of Langflow with other platforms, enabling seamless interactions between different systems.

Webhooks are important because they require SSL for secure communication. Langflow's service module needs an inbound/outbound module that can function well in the background. Additionally, I believe encryption through random seed values is necessary.


Upgrade Spotless minor version and reformat

I updated the version and then ran gradlew spotlessApply continously.
I observed https://github.com/pinterest/ktlint/issues/1786, but on second run it's ok.
Spotless upgraded Ktlint from 0.43.0 to 0.48.2 (actually 0.48.1, because can't go to latest), see https://github.com/diffplug/spotless/blob/main/plugin-gradle/CHANGES.md for each bump.
Trailing commas
In Ktlint 0.48.0 the default for trailing commas changed:
https://github.com/pinterest/ktlint/releases/tag/0.48.0
(see 2nd and 3rd points in "Changed" section at the bottom)
Latest version
Can't update straight to latest, and any further updates are blocked on reviewing CI approach (CI matrix -> Gradle task toolchains).

So is this good to go, or need to do something?

It's a global change, so let's wait until tomorrow for comments, but I'm fine with it as is.

This causes "all lines modified in gradlew.bat.
@TWiStErRob , have you done git add --renormalize . when creating the PR?

Hmm, I don't remember doing that.


Document wildcards in attributes.select

Document the feature from PRs https://github.com/grafana/beyla/pull/991 and https://github.com/grafana/beyla/pull/995

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.35%. Comparing base (58de56a) to head (fe745e2).

:exclamation:  There is a different number of reports uploaded between BASE (58de56a) and HEAD (fe745e2). Click for more details.
HEAD has 2 uploads less than BASE

Flag
BASE (58de56a)
HEAD (fe745e2)

k8s-integration-test
1
0

integration-test
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #996       +/-   ##
===========================================
- Coverage   80.75%   66.35%   -14.41%
===========================================
  Files         134      134
  Lines       10721    10721
===========================================
- Hits         8658     7114     -1544
- Misses       1558     3116     +1558
+ Partials      505      491       -14

Flag
Coverage Δ

integration-test
?

k8s-integration-test
?

oats-test
36.41% <ø> (ø)

unittests
50.81% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Can't encode default theme data.

 var encodedTheme = ThemeEncoder.encodeThemeData(ThemeData.light());
 print(encodedTheme);

The above code produces the following exception:
'package:json_theme/src/codec/theme_encoder.dart': Failed assertion: line 3546 pos 12: 'value == null ||
        value is CircleBorder ||
        value is ContinuousRectangleBorder ||
        value is RoundedRectangleBorder': is not true.

Just to confirm, can you add in the information from flutter doctor?

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 1.22.2, on Mac OS X 10.15.7 19H2, locale en-NP)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 12.1)
[✓] Android Studio (version 4.1)
[✓] VS Code (version 1.50.1)
[✓] Connected device (1 available)

• No issues found!

Also, it isn't just with the default themes, the following code also throws the same exception
Map<String, dynamic> themeJson = {};
var theme = ThemeDecoder.decodeThemeData(themeJson);
print(theme);
var encodedTheme = ThemeEncoder.encodeThemeData(theme);
print(encodedTheme);

It successfully decodes the json to a theme, but throws exception on encoding the same theme.
flutter: ThemeData#e9050

════════ Exception caught by gesture ═══════════════════════════════════════════
The following assertion was thrown while handling a gesture:
'package:json_theme/src/codec/theme_encoder.dart': Failed assertion: line 3546 pos 12: 'value == null ||
        value is CircleBorder ||
        value is ContinuousRectangleBorder ||
        value is RoundedRectangleBorder': is not true.

Thanks for the info.  I just published a fix with 1.4.2.  Closing this, please feel free to add a new issue if you encounter any more problems.


Asset linking to Patient (rental in home-based care)

Is your feature request related to a problem? Please describe.
For palliative care, it is important to keep track of the assets that they loan out to patients.
The palliative care organisations usually keep stock of the following assets and loan to it patients as needed.

Water bed
Wheelchairs
Air bed
Walker
Crutches
Adjustable cot
Stool commode
Backrest
Tripod
Water cushion
air cushion
specialised cushion
Electronic wheel chair
Oxygen concentrators
BiPAP
Oxygen cylinders
Foot drop preventive device
CP chair
DVT pump

Describe the solution you'd like
These assets may be registered in the asset module of care and linked to the patients it is loaned to.

[ ] Allow linking of non-ventilator assets to patients. More than one asset may be linked to a patient
[ ] On the asset page, show which patient it is linked to. An asset may be linked to only one patient at a time

Good to have:
Also, enable tracking the movement of assets from one hospital to another. The fields to mark such movement is now hidden on CARE. This will allow org 1 to rent out assets to Org 2 which may be allocated by Org 2 to its patients.
@gigincg Is "Linkage" the right feature for this? It is presently being used to link ventilators to patients.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

assets needs to be linked with the patient. if the patient moves to another facility, after approval, the asset should be able to be moved with the patient. a track of such movement of assets needs to be made in the parent facility. and the borrowed facility also should have the track of assets which are from another facility. a group is working on refining the list  into categories. can start with the above list.


Sync with spack upstream

PR Summary

PR Checklist

[ ] Any changes to code are appropriately documented.
[ ] Code is formatted.
[ ] Install test passes.
[ ] Docs build.

Same as #5 but with updated docs.

Wouldn’t it be better to just drop the spackage here?

Ah, I didn't think of that... that's probably fine too.


Support for debugging lambda expressions

Please support for debugging lambda expressions, eg:
            List<entity> lst = new List<entity>();

            for (int i = 0; i < 10; i++)
            {
                lst.Add(new entity
                {
                    a = i,
                    b = i*10,
                    c = i*100,
                });
            }
            IEnumerable<entity> a = lst.Where(x => x.a > 5);

Current result for value of "a" is : " System.Linq.Enumerable+WhereListIterator`1[ConsoleApplication1.entity]} "

The problem is in the fact that you are trying to get the value of the expression before it has been evaluated. You need to trigger the evaluation and the easiest way to do that is just to call ToArray:
IEnumerable<entity> a =lst.Where(x => x.a > 5).ToArray();

It will work:

However there is a problem with the current implementation as the subitems in the watch view are no reevaluated on the debug step. Thus you will need to delete and reinsert the expression (e.g. 'a') you want to reevaluate.
That's why I marked it as a defect and started working on it.

The problem is in the fact that you are trying to get the value of the expression before it has been evaluated. You need to trigger the evaluation and the easiest way to do that is just to call ToArray

Thanks for reply. I understand about "ToArray"
But i have another question, if you head about it, please write a something...
"How evaluated the lambda expressions in this case without change source code? - like debugger of  Visual Studio"
(Using mdbg_v4...)
Thanks for support...

Evaluating  lambda at runtime is possible even though nit trivial. A discent CLR debugger allows you to do that (e.g. VS). However, with this pp plugin I had to integrate a long abandoned MS debugger mdbg, which is incomplete and was a nightmare to integrate. It just does not expose this functionality at all. It's even worse than that. It's interface had no functionality for evaluating any anything except the fields. I am not kidding, it does not support evaluating object properties.  I had to reverse engineer it and implement properties support but to do anything trickier (like lambdas) in the product that is abandoned by the vendor and has no grip with the open source community... I don't think it is feasible.
That's why I have also ported this plugin to VSCode that has a descent debugger for free. And that debugger can only improve with time.
in addition to that I have placed the "Open in Visual Studio" button in the plugin window toolbar so one can open the script in the VS and use its debugger when the built-in debugger is insufficient.


(maint) Only log warning for ssl-client-cn rejection when not nil

This commit only logs a warning when rejecting a request for a
ssl-client-cn when the ssl-client-cn is present. Prior to this patch
when using token auth in PE PuppetDB, this warning would be printed for
perfectly valid requests.

transient failure

@puppetlabs-jenkins test this please


build: resolve error for toolchain not available

This fixes the following issue in my local setup:
go: downloading go1.22 (darwin/arm64)
go: download go1.22 for darwin/arm64: toolchain not available

See https://github.com/golang/go/issues/65568

This broke gopls for me, is anyone having the same issue?

gopls is working fine for me, when using the version I have installed via nixos's home-manager from nixos 24.05.

Yeah I was using the version on the snap store.
Using PopOS at the moment, wifi drivers on NixOS have been not so fun.
Not sure why but some weird DNS resolving issue on NixOS when on wifi, which is quite bizarre.

Solution is just to install it via go install to grab the latest one.


[Firefox] Set the imageResourcesPath correctly (PR 16153 follow-up)

We missed updating this path in PR #16153, which breaks loading of annotation-icons in the Firefox PDF Viewer.

/botio integrationtest


Enable adoption and versioned model package

Description of changes:

Re-enables versioned model-package as using updated runtime and deploying to canary did not see test failure for versioned model package. Updated runtime fixes issue of multiple reconciliation loops which appears to have caused multiple creations of model-package.
Latest runtime/codegen can now correctly adopt and retrieve status for versioned model-package, thus adoption is now enabled for model-package.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/test sagemaker-kind-e2e


fix for issue #162 - adding pods/log permission to the cluster-operator

cluster-operator can check the logs after the creation of the job

Hi, thanks for submitting a fix for this issue. job and storageosupgrade CRDs are not maintained for now. When they were added in the operator, operator used to have cluster admin role. Later specific permissions were added and cluster admin requirement was removed. Since job and storageosupgrade CRDs weren't maintained or tested, the permissions required for them have not been added in the operator. We will be adding automated tests and maintain those two CRDs in the coming months.
The fix looks good and it'll work when the operator is deployed using the manifest files. But we also support other means of installing the operator, like using OLM (Operator Lifecycle Manager). For that, can you please add the same change in storageos-operators.configmap.yaml and then run make metadata-update to populate the same change in all the various places it's required?
Also, would be great if you could squash all the commits into a single commit.
Thanks for reporting and working on it.


Include user's project in autocomplete and hover result

IMPORTANT: This pull request adds an optional property to the IOracleResult interface.  It also modifies the signature of getOracleResult.
After running elmOracle this will regex parse the files in the user's Elm project and merge them with the Oracle results.  This can be disabled via the extension settings (new settings value elm.userProjectIntellisense added).
elmInfo and elmAutocomplete have been modified to send a new parameter, 'action', to getOracleResult so that (the new module) elmUserProject knows is the user is hovering or trying to get autocomplete information.
elmOracle has been modified to include this new OracleAction interface and to merge its results with the results of elmUserProject.

Thanks a lot, it looks amazing.


don't want to show all type of file formats

I'd like to exclude .str file formats. Is there a chance to do it?

The filter_files script-opt controls this, and it should be set to yes by default. .str files are not one of the default enabled file extensions so they should be hidden.

Unfortunately, it still shows .str files. Are below lines could be like these?
( I only placed these files in proper locations - file-browser.lua and file_browser.conf )
These in file_browser.conf file.
filter_files=yes
extension_blacklist=.str

you don't include the . when listing the file extensions in the blacklist

I still see .str files.
extension_blacklist=str

You'll need to provide a bit more info then, upload a full log produced by the --log-file option

Also upload some screenshots of what's being shown

Where is that log file?

you set the --log-file option in mpv to the filepath of the resulting log file, for example --log-file=~~desktop/log.txt

Nice, I see log file now. There are a lot of personal folder/files and some PC infos. Could you tell me which part of the log reports that I have to provide you, because its huge reports?

Upload the whole thing, I'll know what to look for. Also upload a screenshot of file-browser showing the .str file.

If you must then just do a ctrl+h and remove the personal folders with ~~~

OK, when I will make a time I will jump to other PC to make a log.txt file and will share whole reports here. Because now it will take a lot of time to remove and check carefully before I post it here, good to be make it in other PC share whole thing without removing anything.

Did you actually open file browser and move to the directory containing the files when you made that log? Because I don't see it reflected there

OK, I made a screenshots for you.
https://i.snipboard.io/sm0S3E.jpg

That isn't an 'str' file, it's an 'srt' file. Srt is a valid subtitle extension format, as is txt.

So you need to blacklist 'srt' not 'str'

Dayuum! It was killer of my time. : /
Thank you for mentioned it and for your time.

I'd like to exclude .str file formats. Is there a chance to do it?

Can anyone please tell me how to run this application, Im getting this error :-

└──╼ $lua file-browser.lua
lua: file-browser.lua:11: module 'mp' not found:
	no field package.preload['mp']
	no file '/usr/local/share/lua/5.2/mp.lua'
	no file '/usr/local/share/lua/5.2/mp/init.lua'
	no file '/usr/local/lib/lua/5.2/mp.lua'
	no file '/usr/local/lib/lua/5.2/mp/init.lua'
	no file '/usr/share/lua/5.2/mp.lua'
	no file '/usr/share/lua/5.2/mp/init.lua'
	no file './mp.lua'
	no file '/usr/local/lib/lua/5.2/mp.so'
	no file '/usr/lib/x86_64-linux-gnu/lua/5.2/mp.so'
	no file '/usr/lib/lua/5.2/mp.so'
	no file '/usr/local/lib/lua/5.2/loadall.so'
	no file './mp.so'
stack traceback:
	[C]: in function 'require'
	file-browser.lua:11: in main chunk
	[C]: in ?