Shaders can now have #else ifdef chains

Objective
Currently, shaders may only have syntax such as
#ifdef FOO
// foo code
#else
#ifdef BAR
// bar code
#else
#ifdef BAZ
// baz code
#else
// fallback code
#endif
#endif
#endif

This is hard to read and follow.
Add a way to allow writing #else ifdef DEFINE to reduce the number of scopes introduced and to increase readability.
Solution
Refactor the current preprocessing a bit and add logic to allow #else ifdef DEFINE.
This includes per-scope tracking of whether a branch has been accepted.
Add a few tests for this feature.
With these changes we may now write:
#ifdef FOO
// foo code
#else ifdef BAR
// bar code
#else ifdef BAZ
// baz code
#else
// fallback code
#endif

instead.

Changelog

Add #else ifdef to shader preprocessing.

Trying to puzzle this out threw my head for a spin.
I'm not entirely confident this is free of errors, but the current tests and new ones are passing so the basics should be in place.
I think a follow up PR (or PRs) could add more features:

Allowing #else ifndef in the chains
Allow value operations (==, !=, < etc) in chains too.

@cart do you have any opinion about #else ifdef FOO? It's a departure from C preprocessor #elseif but I always found the discrepancy of #if/#ifdef yet #elseif to be slightly weird, and #elseifdef feels like too much of a mouthful to me.

Hi, @oCaioOliveira and I are getting to know the project now and decided to review this PR to get a better understanding of the code. After doing some research, we found the match constructor, which would be equivalent to the switch in C. Would this not be more appropriate to reduce the number of introduced scopes?

Hi, @oCaioOliveira and I are getting to know the project now and decided to review this PR to get a better understanding of the code. After doing some research, we found the match constructor, which would be equivalent to the switch in C. Would this not be more appropriate to reduce the number of introduced scopes?

I'm not sure I'm following.
The scopes refer to the logical scopes in the parsing of the shader being preprocessed.
For example, given the line #ifdef FOO, a scope is introduced. That scope survives until the paired #endif is encountered.
This PR allows using #else ifdef instead of adding extra #ifdefs, hence reducing the number of needed scopes.
So I'm not sure where match fits in here- I think you are talking about the keyword in Rust? Or do you mean to add it as a keyword in the shader preprocessor? Or using match in the shader preprocessing code as a refactor?

I'm not sure where match fits in here

agreed, i think match/switch/case might be useful for the #if x == 1 ... #else if x == 2 ... #endif type of elsifs, but it doesn't make sense for #else ifdef.
i checked through the scope logic here and it looks good to me.


docs: tweak formatting for run-by section

It looks like we cannot agree on capitalization in this document. Some of the headers "Are Like This" and some others "Are like this". Any guidelines?

I hate News Casing Or Whatever It's Called so I would lean towards the latter. @joshix ?

It is named title casing and is mentioned even in the PR you participated in: https://github.com/coreos/docs/pull/633 (found by looking at @joshix's page).

Doh, right, that's buried in my inbox to go back and look at.

In any event I really don't think title casing makes sense for the examples I adjusted here.

Title Case is the Current CoreOS Convention
...for titles and headings, with exceptions for terms of art like rkt,
etcd & etc.
On Fri, Oct 23, 2015 at 2:54 PM, Krzesimir Nowak<EMAIL_ADDRESS>wrote:

It is named title casing and is mentioned even in the PR you participated
in: coreos/docs#633 https://github.com/coreos/docs/pull/633 (found by
looking at @joshix https://github.com/joshix's page).
—
Reply to this email directly or view it on GitHub
https://github.com/coreos/rkt/pull/1677#issuecomment-150702206.

ugh, it's like reading the new york times
On Fri, Oct 23, 2015 at 2:58 PM, Josh Wood<EMAIL_ADDRESS>wrote:

Title Case is the Current CoreOS Convention
...for titles and headings, with exceptions for terms of art like rkt,
etcd & etc.
On Fri, Oct 23, 2015 at 2:54 PM, Krzesimir Nowak<EMAIL_ADDRESS>
wrote:

It is named title casing and is mentioned even in the PR you participated
in: coreos/docs#633 https://github.com/coreos/docs/pull/633 (found by
looking at @joshix https://github.com/joshix's page).
—
Reply to this email directly or view it on GitHub
https://github.com/coreos/rkt/pull/1677#issuecomment-150702206.

—
Reply to this email directly or view it on GitHub
https://github.com/coreos/rkt/pull/1677#issuecomment-150702745.

NYT. I read that as "Josh, Your Prose is so Elegant and Professional"...
I don't necessarily favor title case every little last everywhere, but we
have a current convention on it in the docs, Rob regularly enforces it, and
I don't have a good enough reason to dismantle that convention.
Also, we are at least leaning toward a convention that says we employ
heading levels semantically, rather than stylistically. So I see what you
were aiming for with level-5 headings on each example, but lacking any h4
or even h3 to contain them, maybe each run example should be an h3
(###) or h4 instead?
On Fri, Oct 23, 2015 at 2:59 PM, Jonathan Boulle<EMAIL_ADDRESS>wrote:

ugh, it's like reading the new york times
On Fri, Oct 23, 2015 at 2:58 PM, Josh Wood<EMAIL_ADDRESS>wrote:

Title Case is the Current CoreOS Convention
...for titles and headings, with exceptions for terms of art like rkt,
etcd & etc.
On Fri, Oct 23, 2015 at 2:54 PM, Krzesimir Nowak <
<EMAIL_ADDRESS>
wrote:

It is named title casing and is mentioned even in the PR you
participated
in: coreos/docs#633 https://github.com/coreos/docs/pull/633 (found
by
looking at @joshix https://github.com/joshix's page).
—
Reply to this email directly or view it on GitHub
https://github.com/coreos/rkt/pull/1677#issuecomment-150702206.

—
Reply to this email directly or view it on GitHub
https://github.com/coreos/rkt/pull/1677#issuecomment-150702745.

—
Reply to this email directly or view it on GitHub
https://github.com/coreos/rkt/pull/1677#issuecomment-150702934.

(Before there were other comments, I was inclined to just merge this, then do a subsequent PR with some polish. Nothing we are talking about actually changes this content's effectiveness as documentation. However, once we were having a discussion I thought we should attach it to the talk around coreos/docs#633 so we can decide some of these things.)

Conceding to https://github.com/coreos/rkt/pull/1677#issuecomment-150703678 in the spirit of moving forward.


Feature/better error fixed cla

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: ganeshrvel:x: Robusta RunnerRobusta Runner seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


cannot uninstall successfully via uninstall.sh

Describe the bug
When I tried to uninstall it via the command line(uninstall.sh), it told me it's successful, but I installed it, and it always showed the error info(you have a ohmyzsh)
To Reproduce

1,open the iterm
2, run the file(uninstall.sh from the tools of OhMyZsh)
3,It told me it's successful
4, I tried to reinstall oh myzsh via install.sh, it shows me the info(Please see the pic)
Expected behavior

Screenshots or recordings

System:

OS: [e.g. macOS]MacOS
Zsh version [e.g. 5.6] the latest one
Terminal emulator [e.g. iTerm2] The latest version

Additional context

Please see the pics about the issue


AutocompleteManager + MessageKit

Hey Nathan,
I've been able to get the AttachmentManager plugin working on MessageKit 1.0 from MessageInputBar 0.2 using example code written in the InputAccessoryBar 2.1, however, I am unable to successfully get AutoCompleteManager working. The problem that I find is that when I enter in the prefix, @, the table appears but is blank.

I thought this was peculiar so I then started to print out the users that were being returned in the
'func autocompleteManager(_ manager: AutocompleteManager, autocompleteSourceFor prefix: String) -> [AutocompleteCompletion] ',
and it seems to be a loop that continues to run while the prefix exists (note the scroll indicator on the right. When I started to take the screenshot, it was in the middle of scroll bar). Note, I do not find this behavior in the InputAccessoryBar project. My guess is that this would explain why the table is not being updated as the values continue to be updated too quickly for the table to register. I thought this had to do with the asynccompletions, so I removed those but to no avail.

Any help in this matter would be appreciated!

Thanks, I introduced this bug when trying to fix another. I'll push a fix soon.
Sent with GitHawk

I appreciate the help Nathan and Steven, and the update of MessageInputBar 0.2.1!
I was able to use the development branch and the MessageInputBar 0.2.1 in order to get a fully working autocomplete and attachment manager built.
I did try with the secret-branch but there was a slight UI issue when you do an @ mention first and then try to add a picture second - it was not showing the tableview in the top stack view as there were layout constraints that broke. Just an FYI of my experience
Again, the help was very much appreciated! Keep up the great work!

How did you make to import AutocompleteManager in a MessageKit project ?
When I import MessageInputBar and MessageKit, Xcode find 2 definition of multiples class because MessageKit use MessageInputBar

@BenBenz you have to be using MessageKit 1.1 which is in pre release on the MessageKit development branch
Sent with GitHawk

@nathantannar4 Thank you


Bootstrapping ?-Prolog

With recent massive fixes, the process of using Trealla to bootstrap ?-Prolog goes well.
Will be busy recently, so I record current status here, anyone interested can pick up and go further.
Clone ?-Prolog code, replace pc with following code (based on all.pl and swi.pl), and then run make:
#!/bin/sh

export COMMAND_ARGUMENTS="$*"

exec tpl -q --consult <<EOF

:- op(400, yfx, '\\\\\\\\').
:- op(1150, fx, determinate).
:- op(1150, fx, mode).

determinate(_).
mode(_).

command_line_arguments(Args) :-
        sys:getenv('COMMAND_ARGUMENTS', ArgumentString),
        sys:split_all(ArgumentString, ' ', Args).

dbreference(_) :- fail.         % sufficient here

enable_trace(_).

current_error_output(S) :- current_output(S).

%% this must produce identical results as hash_name() in pc.h
atom_hash(A, H) :-
        atom_codes(A, AL),
        atom_hash(0, AL, 0, H).
atom_hash(I, AL, H, H) :-
        (I >= 100; AL == []), !.
atom_hash(I, [C|R], H1, H2) :-
        H is (H1 xor ((H1 << 6) + (H1 >> 2) + C)) /\\<PHONE_NUMBER>,
        I2 is I + 1,
        atom_hash(I2, R, H, H2).

skip_shebang :- \\+ peek_char('#').
skip_shebang :- repeat, get0(10).

getenv(Name, Value) :- sys:getenv(Name, Value).

display(X) :- write(X).
display(S, X) :- write(S, X).

name(Atom, List) :- atom_codes(Atom, List).

get0(Code) :- get_code(Code).

memberchk(E, L) :- once(member(E, L)).

put(S, C) :- put_code(S, C).

exists_file(File) :- sys:exists_file(File).

append([], []).
append([List |RestLists], Concatenated) :-
        append(RestLists, RestConcatenated),
        append(List, RestConcatenated, Concatenated).

union([], List, List).
union([X| Rest], List, Unioned) :-
        (
                memberchk(X, List)
        ->
                union(Rest, List, Unioned)
        ;
                union(Rest, List, RestUnioned),
                Unioned = [X| RestUnioned]
        ).

:- include('settings.pl').
:- include('lib/rdtok.pl').
:- include('lib/read.pl').
:- include('support.pl').
:- include('state.pl').
:- include('terms.pl').
:- include('index.pl').
:- include('lib/dcg.pl').
:- include('builtin.pl').
:- include('process.pl').
:- include('compile.pl').
:- include('assemble.pl').
:- include('xref.pl').
:- include('dce.pl').
:- include('main.pl').

show_version_and_exit :- display('<none>\\n'), halt.

EOF

I'll have look. Has been useful to track down bugs, so thanks, much
appreciated.
On 12 Jun 2017 15:47, "Xin Wang"<EMAIL_ADDRESS>wrote:

With recent massive fixes, the process of using Trealla to bootstrap
?-Prolog goes well.
Will be busy recently, so I record current status here, anyone interested
can pick up and go further.
Clone ?-Prolog https://bitbucket.org/bunny351/prolog code, replace pc
with following code (based on all.pl and swi.pl), and then run make:
#!/bin/sh
export COMMAND_ARGUMENTS="$*"
exec tpl -q --consult <<EOF
:- op(400, yfx, '\\\\').
:- op(1150, fx, determinate).
:- op(1150, fx, mode).
determinate().
mode().
command_line_arguments(Args) :-
sys:getenv('COMMAND_ARGUMENTS', ArgumentString),
sys:split_all(ArgumentString, ' ', Args).
dbreference(_) :- fail.         % sufficient here
enable_trace(_).
current_error_output(S) :- current_output(S).
%% this must produce identical results as hash_name() in pc.h
atom_hash(A, H) :-
atom_codes(A, AL),
atom_hash(0, AL, 0, H).
atom_hash(I, AL, H, H) :-
(I >= 100; AL == []), !.
atom_hash(I, [C|R], H1, H2) :-
H is (H1 xor ((H1 << 6) + (H1 >> 2) + C)) /\<PHONE_NUMBER>,
I2 is I + 1,
atom_hash(I2, R, H, H2).
skip_shebang :- \+ peek_char('#').
skip_shebang :- repeat, get0(10).
getenv(Name, Value) :- sys:getenv(Name, Value).
display(X) :- write(X).
display(S, X) :- write(S, X).
name(Atom, List) :- atom_codes(Atom, List).
get0(Code) :- get_code(Code).
memberchk(E, L) :- once(member(E, L)).
put(S, C) :- put_code(S, C).
exists_file(File) :- sys:exists_file(File).
append([], []).
append([List |RestLists], Concatenated) :-
append(RestLists, RestConcatenated),
append(List, RestConcatenated, Concatenated).
union([], List, List).
union([X| Rest], List, Unioned) :-
(
memberchk(X, List)
->
union(Rest, List, Unioned)
;
union(Rest, List, RestUnioned),
Unioned = [X| RestUnioned]
).
:- include('settings.pl').
:- include('lib/rdtok.pl').
:- include('lib/read.pl').
:- include('support.pl').
:- include('state.pl').
:- include('terms.pl').
:- include('index.pl').
:- include('lib/dcg.pl').
:- include('builtin.pl').
:- include('process.pl').
:- include('compile.pl').
:- include('assemble.pl').
:- include('xref.pl').
:- include('dce.pl').
:- include('main.pl').
show_version_and_exit :- display('\n'), halt.
EOF
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/trealla-lang/trealla/issues/161, or mute the thread
https://github.com/notifications/unsubscribe-auth/AVqpEr5xx4zV36b3piGSgXCCMoteQlqrks5sDND_gaJpZM4N2rW0
.

Now an infinate loop is encountered when processing included files:
...
% including settings.pl
% including settings.pl
% including settings.pl
...

I think it is caused by process_input/4 when processing end_of_file token.
In SWI-Prolog, seeing/1 will return a stream object, which remained open. While in Trealla, an atom is returned. If pass result of seeing/1 again to see/1, SWI will continue to read from previous offset, while Trella will return to start of file.

Yes, was just looking and wondering about that.
On Tue, Jun 13, 2017 at 9:34 PM, Xin Wang<EMAIL_ADDRESS>wrote:

Now an infinate loop is encountered when processing included files:
...
% including settings.pl
% including settings.pl
% including settings.pl
...
I think it is caused by process_input/4
https://bitbucket.org/bunny351/prolog/src/11ecf1b6a865e9a0eac9d5a708e4599855bda1c1/process.pl?at=master&fileviewer=file-view-default#process.pl-44:56
when processing end_of_file token.
In SWI-Prolog, seeing/1 will return a stream object, which remained open.
While in Trealla, an atom is returned. If pass result of seeing/1 again
to see/1, SWI will continue to read from previous offset, while Trella
will return to start of file.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/trealla-lang/trealla/issues/161#issuecomment-308088453,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVqpEigKo3fQo4IZJMUt9CShArbFgaKSks5sDnPVgaJpZM4N2rW0
.

That means in 00156.sh seeing can no longer return 'foo.pro' but a stream
reference.
On Tue, Jun 13, 2017 at 9:34 PM, Xin Wang<EMAIL_ADDRESS>wrote:

Now an infinate loop is encountered when processing included files:
...
% including settings.pl
% including settings.pl
% including settings.pl
...
I think it is caused by process_input/4
https://bitbucket.org/bunny351/prolog/src/11ecf1b6a865e9a0eac9d5a708e4599855bda1c1/process.pl?at=master&fileviewer=file-view-default#process.pl-44:56
when processing end_of_file token.
In SWI-Prolog, seeing/1 will return a stream object, which remained open.
While in Trealla, an atom is returned. If pass result of seeing/1 again
to see/1, SWI will continue to read from previous offset, while Trella
will return to start of file.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/trealla-lang/trealla/issues/161#issuecomment-308088453,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVqpEigKo3fQo4IZJMUt9CShArbFgaKSks5sDnPVgaJpZM4N2rW0
.

Now stopped by triggering an assertion error of malloc:
% make >trace.out
tpl: malloc.c:2866: mremap_chunk: Assertion `((size + offset) & (GLRO (dl_pagesize) - 1)) == 0' failed.
make: *** [pc1.c] Aborted (core dumped)

Backtrace:
Core was generated by `tpl -q --consult'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007f6403eff428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
54      ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) bt
#0  0x00007f6403eff428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x00007f6403f0102a in __GI_abort () at abort.c:89
#2  0x00007f6403f472e8 in __malloc_assert (
    assertion=assertion@entry=0x7f640405a280 "((size + offset) & (GLRO (dl_pagesize) - 1)) == 0",
    file=file@entry=0x7f6404056fe5 "malloc.c", line=line@entry=2866,
    function=function@entry=0x7f640405ada0 <__func__.11564> "mremap_chunk") at malloc.c:301
#3  0x00007f6403f475a3 in mremap_chunk (p=p@entry=0x7f6401dc1000, new_size=new_size@entry=33554448) at malloc.c:2866
#4  0x00007f6403f4dbbc in __GI___libc_realloc (oldmem=0x7f6401dc1010, bytes=33554432) at malloc.c:3023
#5  0x0000000000442e93 in grow_environment (q=0x115ba10) at src/jela.c:71
#6  0x0000000000443184 in prepare_frame (q=0x115ba10, frame_size=2) at src/jela.c:122
#7  0x00000000004453ab in match (q=0x115ba10) at src/jela.c:739
#8  0x0000000000444344 in call (q=0x115ba10) at src/jela.c:437
#9  0x00000000004444cd in run_me (q=0x115ba10) at src/jela.c:481
#10 0x0000000000408b53 in query_run (self=0x115ba10) at src/trealla.c:916
#11 0x000000000040a3ac in trealla_run_query (self=0xf3f010, src=0x1150370 "main.") at src/trealla.c:1395
#12 0x0000000000409e61 in trealla_consult_fp (self=0xf3f010, fp=0x7f640428d8e0 <_IO_2_1_stdin_>) at src/trealla.c:1277
#13 0x00000000004052b8 in main (ac=3, av=0x7fff08ead048) at tpl.c:369
(gdb)

Yes, running out of memory.
On Fri, Jun 16, 2017 at 12:54 PM, Xin Wang<EMAIL_ADDRESS>wrote:

Now stopped by triggering an assertion error of malloc:
% make >trace.out
tpl: malloc.c:2866: mremap_chunk: Assertion `((size + offset) & (GLRO (dl_pagesize) - 1)) == 0' failed.
make: *** [pc1.c] Aborted (core dumped)
Backtrace:
Core was generated by `tpl -q --consult'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007f6403eff428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
54      ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) bt
#0  0x00007f6403eff428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x00007f6403f0102a in __GI_abort () at abort.c:89
#2  0x00007f6403f472e8 in __malloc_assert (
assertion=assertion@entry=0x7f640405a280 "((size + offset) & (GLRO (dl_pagesize) - 1)) == 0",
file=file@entry=0x7f6404056fe5 "malloc.c", line=line@entry=2866,
function=function@entry=0x7f640405ada0 <func.11564> "mremap_chunk") at malloc.c:301
#3  0x00007f6403f475a3 in mremap_chunk (p=p@entry=0x7f6401dc1000, new_size=new_size@entry=33554448) at malloc.c:2866
#4  0x00007f6403f4dbbc in __GI___libc_realloc (oldmem=0x7f6401dc1010, bytes=33554432) at malloc.c:3023
#5  0x0000000000442e93 in grow_environment (q=0x115ba10) at src/jela.c:71
#6  0x0000000000443184 in prepare_frame (q=0x115ba10, frame_size=2) at src/jela.c:122
#7  0x00000000004453ab in match (q=0x115ba10) at src/jela.c:739
#8  0x0000000000444344 in call (q=0x115ba10) at src/jela.c:437
#9  0x00000000004444cd in run_me (q=0x115ba10) at src/jela.c:481
#10 0x0000000000408b53 in query_run (self=0x115ba10) at src/trealla.c:916
#11 0x000000000040a3ac in trealla_run_query (self=0xf3f010, src=0x1150370 "main.") at src/trealla.c:1395
#12 0x0000000000409e61 in trealla_consult_fp (self=0xf3f010, fp=0x7f640428d8e0 <IO_2_1_stdin>) at src/trealla.c:1277
#13 0x00000000004052b8 in main (ac=3, av=0x7fff08ead048) at tpl.c:369
(gdb)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/trealla-lang/trealla/issues/161#issuecomment-308919352,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVqpElD-ATmbrBrmdNF0c9Bp7juhUBSeks5sEe5pgaJpZM4N2rW0
.

I tested on a VM and a real machine, both memory are quite sufficient.

Yes, its probably run-away, or not recovering environment space.
On 16 Jun 2017 14:47, "Xin Wang"<EMAIL_ADDRESS>wrote:

I tested on a VM and a real machine, both memory are quite sufficient.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/trealla-lang/trealla/issues/161#issuecomment-308932247,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVqpEt4xDk1-zBiDxXBUKYqvwZM2Tiknks5sEgjRgaJpZM4N2rW0
.

valgrind detect some memory errors related to grow_environment and realloc, which may be useful:
==7983== Invalid read of size 8
==7983==    at 0x414D03: get_env (bifs.h:339)
==7983==    by 0x414D80: get_arg (bifs.h:349)
==7983==    by 0x415B63: copy_term2 (bifs_iso.c:256)
==7983==    by 0x427766: bif_iso_univ (bifs_iso.c:3438)
==7983==    by 0x44432E: call (jela.c:441)
==7983==    by 0x444505: run_me (jela.c:493)
==7983==    by 0x408B92: query_run (trealla.c:916)
==7983==    by 0x40A3EB: trealla_run_query (trealla.c:1395)
==7983==    by 0x409EA0: trealla_consult_fp (trealla.c:1277)
==7983==    by 0x4052F7: main (tpl.c:369)
==7983==  Address 0x91da050 is 16 bytes after a block of size 2,097,152 alloc'd
==7983==    at 0x4C2FD5F: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==7983==    by 0x442EBF: grow_environment (jela.c:79)
==7983==    by 0x4431BC: prepare_frame (jela.c:134)
==7983==    by 0x4453E3: match (jela.c:751)
==7983==    by 0x44437C: call (jela.c:449)
==7983==    by 0x444505: run_me (jela.c:493)
==7983==    by 0x408B92: query_run (trealla.c:916)
==7983==    by 0x40A3EB: trealla_run_query (trealla.c:1395)
==7983==    by 0x409EA0: trealla_consult_fp (trealla.c:1277)
==7983==    by 0x4052F7: main (tpl.c:369)
==7983==
==7983== Invalid read of size 4
==7983==    at 0x414D0F: get_env (bifs.h:339)
==7983==    by 0x414D80: get_arg (bifs.h:349)
==7983==    by 0x415B63: copy_term2 (bifs_iso.c:256)
==7983==    by 0x427766: bif_iso_univ (bifs_iso.c:3438)
==7983==    by 0x44432E: call (jela.c:441)
==7983==    by 0x444505: run_me (jela.c:493)
==7983==    by 0x408B92: query_run (trealla.c:916)
==7983==    by 0x40A3EB: trealla_run_query (trealla.c:1395)
==7983==    by 0x409EA0: trealla_consult_fp (trealla.c:1277)
==7983==    by 0x4052F7: main (tpl.c:369)
==7983==  Address 0x91da058 is 24 bytes after a block of size 2,097,152 in arena "client"
==7983==
==7983== Invalid read of size 8
==7983==    at 0x415913: copy_term2 (bifs_iso.c:216)
==7983==    by 0x415B80: copy_term2 (bifs_iso.c:257)
==7983==    by 0x427766: bif_iso_univ (bifs_iso.c:3438)
==7983==    by 0x44432E: call (jela.c:441)
==7983==    by 0x444505: run_me (jela.c:493)
==7983==    by 0x408B92: query_run (trealla.c:916)
==7983==    by 0x40A3EB: trealla_run_query (trealla.c:1395)
==7983==    by 0x409EA0: trealla_consult_fp (trealla.c:1277)
==7983==    by 0x4052F7: main (tpl.c:369)
==7983==  Address 0x1000000c8434 is not stack'd, malloc'd or (recently) free'd
==7983==
==7983==
==7983== Process terminating with default action of signal 11 (SIGSEGV)
==7983==  Access not within mapped region at address 0x1000000C8434
==7983==    at 0x415913: copy_term2 (bifs_iso.c:216)
==7983==    by 0x415B80: copy_term2 (bifs_iso.c:257)
==7983==    by 0x427766: bif_iso_univ (bifs_iso.c:3438)
==7983==    by 0x44432E: call (jela.c:441)
==7983==    by 0x444505: run_me (jela.c:493)
==7983==    by 0x408B92: query_run (trealla.c:916)
==7983==    by 0x40A3EB: trealla_run_query (trealla.c:1395)
==7983==    by 0x409EA0: trealla_consult_fp (trealla.c:1277)
==7983==    by 0x4052F7: main (tpl.c:369)
==7983==  If you believe this happened as a result of a stack
==7983==  overflow in your program's main thread (unlikely but
==7983==  possible), you can try to increase the size of the
==7983==  main thread stack using the --main-stacksize= flag.
==7983==  The main thread stack size used in this run was 8388608.
==7983==

Seems that bootstrapping ?-Prolog still has a long way to go, and now it becomes harder to spot the problems.
I wll go another way first, using ?-Prolog bulitin test cases (run with ./run-checks), hope that will help.

With the fix of issue #178, now ./pc tests/0001-true.pl failed with a segmentation fault:
Core was generated by `tpl -q --consult'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x0000000000414d66 in get_env (q=0x2640e60, point=4294967295) at src/bifs.h:339
339             return e->term ? e : e - e->binding;
(gdb) bt
#0  0x0000000000414d66 in get_env (q=0x2640e60, point=4294967295) at src/bifs.h:339
#1  0x0000000000414de4 in get_arg (q=0x2640e60, term=0x2640190, frame=4294967295) at src/bifs.h:349
#2  0x0000000000415b5d in copy_term2 (q=0x2640e60, from=0x2640190, clone=1, depth=1) at src/bifs_iso.c:255
#3  0x0000000000415b7a in copy_term2 (q=0x2640e60, from=0x26400f0, clone=1, depth=0) at src/bifs_iso.c:256
#4  0x00000000004294f6 in bif_iso_findall (q=0x2640e60) at src/bifs_iso.c:3787
#5  0x0000000000445791 in call (q=0x2640e60) at src/jela.c:441
#6  0x0000000000445968 in run_me (q=0x2640e60) at src/jela.c:493
#7  0x0000000000408b87 in query_run (self=0x2640e60) at src/trealla.c:912
#8  0x000000000040a3cd in trealla_run_query (self=0x2426010, src=0x2638e30 "main.") at src/trealla.c:1387
#9  0x0000000000409e82 in trealla_consult_fp (self=0x2426010, fp=0x7f1925cd98e0 <_IO_2_1_stdin_>) at src/trealla.c:1271
#10 0x0000000000405310 in main (ac=3, av=0x7ffe5554eb78) at tpl.c:369
(gdb)

I did notice this:
andrew@andrew:~/prolog$ make
./pc -n pc.pl -o pc1.c
% including settings.pl
% including support.pl
ERROR: invalid arithmetic expression:
iota('var'(1),[var('var'(1),'N'),',',var('var'(2),'M'),',','[',var('var'(1),'N'),'|',var('var'(3),'R'),']',')',atom(:-),var('var'(0),'N2'),atom(is),var('var'(1),'N'),atom(+),integer(1),',',atom(iota),'(',var('var'(0),'N2'),',',var('var'(2),'M'),',',var('var'(3),'R'),')'],[[],',',var('var'(2),'M'),',','[',var('var'(1),'N'),'|',var('var'(3),'R'),']',')',atom(:-),var('var'(0),'N2'),atom(is),var('var'(1),'N'),atom(+),integer(1),',',atom(iota),'(',var('var'(0),'N2'),',',var('var'(2),'M'),',',var('var'(3),'R'),')'])
GNUmakefile:48: recipe for target 'pc1.c' failed
make: *** [pc1.c] Error 1
andrew@andrew:~/prolog$
On Sat, Jun 24, 2017 at 7:19 PM, Xin Wang<EMAIL_ADDRESS>wrote:

With the fix of issue #178
https://github.com/trealla-lang/trealla/issues/178, now ./pc tests/
0001-true.pl failed with a segmentation fault:
Core was generated by `tpl -q --consult'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x0000000000414d66 in get_env (q=0x2640e60, point=4294967295) at src/bifs.h:339
339             return e->term ? e : e - e->binding;
(gdb) bt
#0  0x0000000000414d66 in get_env (q=0x2640e60, point=4294967295) at src/bifs.h:339
#1  0x0000000000414de4 in get_arg (q=0x2640e60, term=0x2640190, frame=4294967295) at src/bifs.h:349
#2  0x0000000000415b5d in copy_term2 (q=0x2640e60, from=0x2640190, clone=1, depth=1) at src/bifs_iso.c:255
#3  0x0000000000415b7a in copy_term2 (q=0x2640e60, from=0x26400f0, clone=1, depth=0) at src/bifs_iso.c:256
#4  0x00000000004294f6 in bif_iso_findall (q=0x2640e60) at src/bifs_iso.c:3787
#5  0x0000000000445791 in call (q=0x2640e60) at src/jela.c:441
#6  0x0000000000445968 in run_me (q=0x2640e60) at src/jela.c:493
#7  0x0000000000408b87 in query_run (self=0x2640e60) at src/trealla.c:912
#8  0x000000000040a3cd in trealla_run_query (self=0x2426010, src=0x2638e30 "main.") at src/trealla.c:1387
#9  0x0000000000409e82 in trealla_consult_fp (self=0x2426010, fp=0x7f1925cd98e0 <IO_2_1_stdin>) at src/trealla.c:1271
#10 0x0000000000405310 in main (ac=3, av=0x7ffe5554eb78) at tpl.c:369
(gdb)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/trealla-lang/trealla/issues/161#issuecomment-310827449,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVqpEseumm6QCvEm5Gc_VAIahJCq7zIYks5sHNSngaJpZM4N2rW0
.

Add another test for issue #178, which may be related to segmentation fault error I mentioned.

With recent fix of #178, now pc can compile tests/0001-true.pl file to a .c file now!
Although comparing to output of SWI-Prolog, there are 9 lines missing, so the result is not correct. But anyway, quite exciting.

Yes, this is progress. Many rivers to cross, as the saying goes.
On Sat, Jun 24, 2017 at 10:47 PM, Xin Wang<EMAIL_ADDRESS>wrote:

With recent fix of #178
https://github.com/trealla-lang/trealla/issues/178, now pc can compile
tests/0001-true.pl file to a .c file now!
Although comparing to output of SWI-Prolog, there are 9 lines missing, so
the result is not correct. But anyway, quite exciting.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/trealla-lang/trealla/issues/161#issuecomment-310836601,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVqpEqNCANfGQQCD31VIHf_yHC7F-Kcmks5sHQVagaJpZM4N2rW0
.

The grow_environment related memory error mentioned previously still exists, which can be detected by just modify pc to use valgrind tpl instead of tpl, and then run ./pc tests/0001-true.pl.
Have some time to look into this problem, I found that it may caused by copy_term2 and get_arg, according to the backtrace:
==2073== Invalid read of size 8
==2073==    at 0x414D66: get_env (bifs.h:339)
==2073==    by 0x414DEF: get_arg (bifs.h:352)
==2073==    by 0x415B68: copy_term2 (bifs_iso.c:255)
==2073==    by 0x427E43: bif_iso_univ (bifs_iso.c:3515)
==2073==    by 0x4457A8: call (jela.c:441)
==2073==    by 0x44597F: run_me (jela.c:493)
==2073==    by 0x408B86: query_run (trealla.c:912)
==2073==    by 0x40A3CC: trealla_run_query (trealla.c:1387)
==2073==    by 0x409E81: trealla_consult_fp (trealla.c:1271)
==2073==    by 0x40530F: main (tpl.c:369)
==2073==  Address 0x6acdef0 is 0 bytes after a block of size 32,768 alloc'd
==2073==    at 0x4C2FD5F: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==2073==    by 0x44434D: grow_environment (jela.c:79)
==2073==    by 0x444636: prepare_frame (jela.c:134)
==2073==    by 0x4468DF: match (jela.c:760)
==2073==    by 0x4457F6: call (jela.c:449)
==2073==    by 0x44597F: run_me (jela.c:493)
==2073==    by 0x408B86: query_run (trealla.c:912)
==2073==    by 0x40A3CC: trealla_run_query (trealla.c:1387)
==2073==    by 0x409E81: trealla_consult_fp (trealla.c:1271)
==2073==    by 0x40530F: main (tpl.c:369)

After I apply following change, the problem disappeared, not sure if this change is appropriate, as there are several if-else branches in get_arg, and I can not fully grasp the purpose of the function.
--- a/src/bifs.h
+++ b/src/bifs.h
@@ -341,6 +341,8 @@ inline static env *get_env(tpl_query *q, unsigned point)

 inline static node *get_arg(tpl_query *q, node *term, unsigned frame)
 {
+       const env *e;
+
        if (!is_var(term)) {
                q->latest_context = frame;
                return term;
@@ -349,9 +351,12 @@ inline static node *get_arg(tpl_query *q, node *term, unsigned frame)
        if ((signed)frame == -1)
                return term;

-       const env *e = get_env(q, frame + term->slot);
+       if (frame + term->slot >= q->envs_possible)
+               e = NULL;
+       else
+               e = get_env(q, frame + term->slot);

-       if (e->term != NULL) {
+       if (e != NULL && e->term != NULL) {
                q->latest_context = e->context;
                return e->term;
        }

After #191 fix, pc will go into an infinite loop when compiling tests/0001-true.pl, caused by incorrect =.. unification, I can not extract a simple test case, so just paste a snippet of trace output:
...
Call: (true,(true,main))=..L
Exit: (true,(true,main))=..[',',IGOAL,(PGOAL,GOAL)]
...


Modified StoreQueueCursor to prevent a broker deadlock

Modified StoreQueueCursor to properly implement tryAddMessageLast so that the message lock can be released during a timeout when the temporary store is full.  Updated Queue to call tryAddMessageLast instead of addMessageLast in the cursorAdd method.
This resolves https://issues.apache.org/jira/browse/AMQ-5712

I just updated this request to include a unit test showing the deadlock occurring when the memory store size is larger than the temporary store size.

Closing this as Tim Bish has posted a better version of this patch.


functional-tester: network partition + membership change

5 node at the beginning
remove one member to change it into 4 node cluster
network partition into two groups (2 nodes, other 2 nodes)
add back the removed node to the group with no leader
Wait until that group elects a new leader
remove network partition
ensure the cluster elects only one leader and consistent revision, hash values

Reference:

https://aphyr.com/posts/281-call-me-maybe-carly-rae-jepsen-and-the-perils-of-network-partitions
https://aphyr.com/posts/330-jepsen-rethinkdb-2-2-3-reconfiguration

We do not have to put this into functional tester. Let's make an integration test for this?

@xiang90 Ok, I will write integration tests instead. Thanks.

Closing via https://github.com/coreos/etcd/issues/6140.
network partition tests are enough, because when there's no leader (2 / 2 partition in 4 node cluster), cluster cannot progress anyway.
In addition, now strict-reconfig is set by default.


Revert "build(deps): bump react-router-dom from 6.4.2 to 6.6.1"

Reverts RedHatInsights/image-builder-frontend#892

Would be good to add a test (in a follow-up!) to avoid this (whatever it was) happening again. Also, the PR description should mention that this was a regression, or other details you might know - for posterity.

Ah, good point. I don't think I can easily change the commit message on this PR because it's from dependabot's branch... next time. I'll at least make an issue with the console error messages so we can figure out why this broke stage beta.


Closes: #1

updated validations.py python script
Fixed the behaviour of validate_user function in validations.py
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

@googlebot
I signed it !
Sent from my iPhone

On 23-Mar-2020, at 2:04 AM, googlebot<EMAIL_ADDRESS>wrote:
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ Googlers: Go here for more info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


No onSave event emitter

Awesome code - Reading through the documentation - there doesn't seem to be an output event for when the save button is pressed - should one be added?
In the example they attach the saving technique to the undo event but this probably isnt the best place to do this.

Looking through the code - I can see that the downloadImage() method is called when the save button is pressed - it would be really helpful if there could also be an event emitter attached to this too.

Hi,
Sure, i will add the emitter and add an option flag if you do not want to download the image right away

These changes were added in the newest version (v1.4.1). Please try them out and see if everything is okay so we can close the issue

Perfect - your code is super readable too


Failing integration tests

I'm successfully using Bamboo in my app but I can't get some integration tests to pass. I'm using Phoenix 1.3 with Bamboo from master.
I've tested this in dev and it works fine. I can preview the emails.
Here are my tests:
# test/paper_web/auth/password_reset_controller_test.exs
defmodule PaperWeb.Auth.PasswordResetControllerTest do
  use PaperWeb.ConnCase
  use Bamboo.Test, shared: true

  describe "create password_reset" do
    test "redirects to confirm when data is valid and sends reset email", %{conn: conn} do
      credential = insert!(:credential)
      conn = post conn, auth_password_reset_path(conn, :create),
        password_reset: attrs_for(:password_reset, email: credential.email)

      assert redirected_to(conn) == auth_password_reset_path(conn, :confirm, email: credential.email)

      password_reset =
        PasswordReset
        |> Repo.get_by!(credential_id: credential.id)
        |> Repo.preload(:credential)

      assert_delivered_email PasswordResetMailer.password_reset_email(password_reset)
    end
end

Here is my config:
# paper/config/config.exs
config :paper, Paper.Mailer,
  adapter: Bamboo.LocalAdapter

# lib/paper/mailer.ex
defmodule Paper.Mailer do
  use Bamboo.Mailer, otp_app: :paper
end

# lib/paper_web/mailers/password_reset_mailer.ex
defmodule PaperWeb.PasswordResetMailer do
  use Bamboo.Phoenix, view: PaperWeb.MailerView
  alias Paper.Auth.PasswordReset

  def password_reset_email(%PasswordReset{} = password_reset) do
    base_email()
    |> to(password_reset.email)
    |> subject("Password Reset")
    |> assign(:password_reset, password_reset)
    |> render(:password_reset)
  end

  defp base_email do
    new_email()
    |><EMAIL_ADDRESS>    |> put_layout({PaperWeb.LayoutView, :mailer})
  end
end

Using shared: true makes no difference. I'm getting the following error:
1) test create password_reset redirects to confirm when data is valid (PaperWeb.Auth.PasswordResetControllerTest)
     test/paper_web/controllers/auth/password_reset_controller_test.exs:21
     There were 0 emails delivered to this process.

     If you expected an email to be sent, try these ideas:

     1) Make sure you call deliver_now/1 or deliver_later/1 to deliver the email
     2) Make sure you are using the Bamboo.TestAdapter
     3) Use shared mode with Bamboo.Test. This will allow Bamboo.Test
     to work across processes: use Bamboo.Test, shared: :true
     4) If you are writing an acceptance test through a headless browser, use
     shared mode as described in option 3.

     code: assert_delivered_email PasswordResetMailer.password_reset_email(password_reset)
     stacktrace:
       test/paper_web/controllers/auth/password_reset_controller_test.exs:32: (test)

Ideas?

Hi @abitdodgy
You should call one of deliver_now/1 or deliver_later/1 function.
Your function password_reset_email generated only Bamboo.Email structure with filled details about template, html_body, recipients but not sent it.
If you want send email - you should also add Paper.Mailer.deliver_later() (or of course Paper.Mailer.deliver_now() to password_reset_email or where you want sent it.
Example:
def password_reset_email(%PasswordReset{} = password_reset) do
    base_email()
    |> to(password_reset.email)
    |> subject("Password Reset")
    |> assign(:password_reset, password_reset)
    |> render(:password_reset)
    |> Paper.Mailer.deliver_later()
  end

Also in your config/test.exs file add:
config :paper, Paper.Mailer, adapter: Bamboo.TestAdapter

@bartoszgorka the code in my context was delivering the emails. The problem was the config of the test adapter.
I had config :paper, Paper.Mailer, adapter: Bamboo.LocalAdapter under config.exs but needed to use config :paper, Paper.Mailer, adapter: Bamboo.TestAdapter in test.exs.
Thanks for pointing that out.

An aside, I think it would be worth mentioning this in the docs.


cqlgen - allow for auto-replacing certain patterns in raw cql before parsing

... to allow the remapping of terms which are parsable by the ANTLR3 customized grammar, but which are not allowed for the antlr4 grammar. This includes things like keywords in identifier positions with not quoting.

There is a regex replacer now that works for the corner cases we have found. However, due to UDT recursive types not being supported in the Antlr4 CQL grammar, this is not always enough to make things parsable. The next step will be to update the grammar to support arbitrarily nested types.


added new ClientConfigurationError for invalid authority in request - v3

Throw authority mismatch error in the acquire token silent and native cases if the authority in request does not match environment specified in the account obj or MSAL config.
Cherry-picked from 6002

Codecov Report

Merging #6054 (de9741b) into dev (81d34b4) will decrease coverage by 0.86%.
The diff coverage is 96.63%.

Flag
Coverage Δ

msal-angular
96.73% <96.63%> (+0.22%)
:arrow_up:

msal-browser
?

msal-common
84.44% <ø> (-0.11%)
:arrow_down:

msal-core
?

msal-node
79.98% <ø> (-3.41%)
:arrow_down:

msal-node-extensions
?

msal-react
94.24% <ø> (-0.45%)
:arrow_down:

node-token-validation
?

Impacted Files
Coverage Δ

lib/msal-common/src/account/AuthToken.ts
100.00% <ø> (ø)

lib/msal-common/src/account/CcsCredential.ts
100.00% <ø> (ø)

lib/msal-common/src/account/ClientInfo.ts
100.00% <ø> (ø)

lib/msal-common/src/authority/Authority.ts
90.87% <ø> (+2.98%)
:arrow_up:

lib/msal-common/src/authority/AuthorityFactory.ts
100.00% <ø> (+11.11%)
:arrow_up:

lib/msal-common/src/authority/AuthorityMetadata.ts
100.00% <ø> (ø)

lib/msal-common/src/authority/AuthorityType.ts
100.00% <ø> (ø)

...c/authority/CloudInstanceDiscoveryErrorResponse.ts
100.00% <ø> (ø)

.../msal-common/src/authority/OpenIdConfigResponse.ts
100.00% <ø> (ø)

lib/msal-common/src/authority/ProtocolMode.ts
100.00% <ø> (ø)

... and 25 more

... and 200 files with indirect coverage changes


How Generate the file EDID.bin to other configurations?

I tested the file"edid_auo14.bin" on the orange pi plus 2 with Android running, but didn't work with the LCD (LG LP156WH4);
the LG LCD receives RGB666 format and a different fclk = 70 MHZ .
this is the modeline with the LCD parameters : Modeline "1366x768" 70 1366 1402 1450 1492 768 771 776 782 +hsync +vsync;
how can I generate a file .bin with this parameters or others resolutions by example "1360x768", "1368x768", etc ?
thanks

Then you should create your own EDID file that fits your timings.
Here is datasheet for your LCD:
http://www.yslcd.com.tw/docs/product/LP156WH4-TLA1.pdf
It has full content of EDID (128 bytes) at the end of document, so it is
just copy&paste job for you.
On Fri, Mar 17, 2017 at 5:38 PM, CoffeeColombia<EMAIL_ADDRESS>wrote:

I tested the file"edid_auo14.bin" on the orange pi plus 2 with Android
running, but didn't work with the LCD (LG LP156WH4);
the LG LCD receives RGB666 format and a different fclk = 70 MHZ .
this is the modeline with the LCD parameters : Modeline "1366x768" 70 1366
1402 1450 1492 768 771 776 782 +hsync +vsync;
how can I generate a file .bin with this parameters or others resolutions
by example "1360x768", "1368x768", etc ?
thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ChalkElec/write-edid/issues/2, or mute the thread
https://github.com/notifications/unsubscribe-auth/AB1pmPl7ENiuxcHDgztxAUZcsVxH52Ghks5rmpregaJpZM4Mgq4p
.

Thank's for your support.

We are also facing a similar issue.
We are using AUO G133HAN01.0 (https://www.datadisplay-group.de/fileadmin/pdf/produkte/TFT-Displays/AUO/G133HAN01.0_Datasheet.pdf)
How can I generate the .bin file for AUO G133HAN01.0 display ?


rsa_kmgmt: Return OSSL_PKEY_PARAM_DEFAULT_DIGEST for unrestricted PSS keys

Fixes #13957

@levitte please re-review

@levitte please re-review

This pull request is ready to merge

This pull request is ready to merge

Merged to master. Thank you for the review!

Merged to master. Thank you for the review!


[SPARK-32511][FOLLOW-UP][SQL][R][PYTHON] Add dropFields to SparkR and PySpark

What changes were proposed in this pull request?

This PR adds dropFields method to:

PySpark Column
SparkR Column

Why are the changes needed?

Feature parity.
Does this PR introduce any user-facing change?

Yes, new API.
How was this patch tested?

New unit tests.
Manual verification of examples / doctests.
Manual run of MyPy tests

Test build #129509 has started for PR 29967 at commit a935768.

Test build #129510 has started for PR 29967 at commit 2940776.

Test build #129511 has started for PR 29967 at commit 7c081a0.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34115/

Test build #129509 has finished for PR 29967 at commit a935768.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129509/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34116/

Test build #129510 has finished for PR 29967 at commit 2940776.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129510/
Test PASSed.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34115/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34115/
Test FAILed.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34116/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34116/
Test FAILed.

Test build #129511 has finished for PR 29967 at commit 7c081a0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129511/
Test PASSed.

cc @fqaiser94

Merged to master.

Thanks @HyukjinKwon


Allow draft permit creation for Admins

Description
Allow draft permit creation for Admins.
Features / fixes / updates:

Add draft-permit creation to create permit form
Add HDS icons to buttons
Add support for permit PRELIMINARY-status
Hide ALL-status from permit forms
Fix HDS Notification dialog layout
Update fi/sv/en-translations

Context
PV-895
How Has This Been Tested?
Manually through CreatePermitForm in Admin UI.
Manual Testing Instructions for Reviewers
Test draft / preliminary permit creation from the Admin UI.
Note that this requires also these backend changes: https://github.com/City-of-Helsinki/parking-permits/pull/549
Screenshots

LGTM!


Quest with GPS feature not working correctly

What is your Quests version / build number (do not say "latest")?
(3.7.8-b16)
Describe the problem and how to replicate it. Any console errors to post using Pastebin.com?
NONE
If applicable, can you provide an example quest from quests.yml using Pastebin.com?
https://pastebin.com/fceddDF6
Problem:
The GPS feature for quest stages seemed to have been working fine, as of lately after updating plugins it does not work properly anymore, when picking new quests, the GPS will randomly appear not all the time like it should, also if it does work, when going from one stage to the other it will shut off and stop working, therefore for the next stage, you have to guess where to go, how can I fix this issue?

Thanks for your report. No changes to integration within Quests have been made in recent memory. Have you tried reverting to an older version of GPS? If that resolves the issue, try to figure out which version of GPS created the problem and I'll look into it.

I was using GPS Version 2.13.1 but reverted to 2.11.0 and partially fixed the problem, at least the arrow appears 99% of the time, but I had it set where the arrow would reset no upon the person reaching the destination but updating stages, so if you passed your destination it would not remove the GPS arrow, basically the radius I put to 0.0 but when I do that now, the arrow does not update, I don't think it's much of a problem of GPS but more with the GPS-Quest Integration being outdated, I think, since I am running the latest Quest Version that could cause some problems, but with some tweaks I got it to work at least, not as it used to but at least players don't get lost.

The "Cannot reach destination from here!" error means the destination is either in another world or over 9999 blocks away. You can increase maxDistanceToEntry in GPS's config.yml file to something greater than that, but you may notice decreased performance.
A radius of 0.0 essentially disables arrow updates, so that's expected. I recommend using a value similar to what you're using for most quests' reach-destination radii.
Previously I was compiling GPS-Quests against GPS 2.7.4, but even after upgrading to 2.13.3 I'm not seeing any conflicts. I'm thinking that making the aforementioned adjustments to your settings may resolve the issue. If not, feel free to request re-open.

Usually Quest stages are no more than 100 blocks away from each other in the same world the longest one is 300 blocks not 9999 blocks away as for 0.0 never had a problem the arrow would just change to the next objective once the next stage starts, set it to 2.0 tho, still have the problem works for some quest stages, not all, all my quests are NPC talks, but for some it appears for others says can't reach destination and for others well it doesn't work, and it worked before upgrading the quest version from 3.7.6 to 3.7.8, still cracking my head over it

@PikaMug Don't know if you have been able to read my reply?

@codgamerMC I’ll have to try relocating this at some point. Have you verified the issue persists on the latest Jenkins build?
Sent with GitHawk

No and how do I access it?

@codgamerMC https://ci.codemc.org/job/PikaMug/job/Quests/
Sent with GitHawk

Thanks @PikaMug, I will be sure to check it out and let you know as soon as possible

@PikaMug Updated to 3.8 and For what I see, if GPS destination is reached and next stage is started now it will update but, if radius is set at 2 blocks and player is at 3 blocks then when moving into the next stage the player still does not get an updated Arrow for the next stage which was part of the original problem

Was left to the conclusion that GPS-Quest plugin is outdated and the cause of the problem of GPS arrow not updating in each stage, is it possible to update the plugin so the arrow updates to the next stage, GPS and Quest are both in the latest versions

As I tried to allude to earlier, the radius for Quests and GPS are not intertwined; they are independent of each other. That's not a bug, but rather a limitation of GPS as they don't have an API method to change a destination's radius on-the-fly. All you can do is set the two radii as close to each other as possible. Alternatively, some players have worked around this by forcing the player to do something like stand on a pressure plate in the center to ensure both will be updated.
If GPS ever supplies an API method for its radii, I'll be sure to update GPS-Quests accordingly. Please direct future inquiries about GPS-Quests to it's own issue tracker.


ModuleNotFoundError: No module named 'tokenizers.tokenizers'

When initiating the chatbot following error occurs:
Traceback (most recent call last):
File "C:\Users\yongy\chatrwkv\v2\chat.py", line 125, in
pipeline = PIPELINE(model, f"{current_path}/20B_tokenizer.json")
File "c:\users\yongy\appdata\local\programs\python\python37\lib\site-packages\rwkv\utils.py", line 28, in init
from tokenizers import Tokenizer
File "c:\users\yongy\appdata\local\programs\python\python37\lib\site-packages\tokenizers_init_.py", line 80, in
from .tokenizers import (
ModuleNotFoundError: No module named 'tokenizers.tokenizers'

pip install tokenizers --upgrade

tried that, does not work

pip install tokenizers --upgrade

pip install tokenizers --upgrade

tried that, does not work
pip install tokenizers --upgrade
Requirement already satisfied: tokenizers in c:\users\yongy\appdata\local\programs\python\python37\lib\site-packages (0.13.3)

you have multiple python on your system. check which python you are calling, and install package for it.

and use python 3.10

use python 3.10

Already using python 3.10, has redirected python 3.10 to check packages in the library of python 3.7 for convenience. Issue was the installed tokenizers package was for python 3.7. Reinstalling pacakge for python 3.10 solved the issue. For people encountered the same issue, run following command:
py -3.10 -m pip install tokenizers

use python 3.10

thanks for the hint


grant_type needs further explanation and guides should always include full examples

Please further explain grant_type in this doc: what is it, where do we find it?
It would also be very helpful to provide a fully complete example, including screenshots of the configured App Registration, fields needed for the POST, the sample POST, and the sample Response.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6c30758f-e4a0-9673-b531-5447c0cfee0e
Version Independent ID: 935b5097-6ca8-4a3d-5fca-4b4ac4c27a41
Content: How to use REST APIs for Microsoft Purview Data Planes - Microsoft Purview
Content Source: articles/purview/tutorial-using-rest-apis.md
Service: purview
Sub-service: purview-data-catalog
GitHub Login: @nayenama
Microsoft Alias: nayenama

@KyferEz - The value you will need to pass for the grant_type parameter is "client_credentials".

I'll work on adding a screenshot for the example here!
As a team we're working on better documentation/samples for the REST API in general as well, so keep an eye out for those in the new year.

@KyferEz
Thanks for your feedback! We will investigate and update as appropriate.

@KyferEz - I am adding the following PowerShell example to the documentation to make this clearer.

$tenantID = "12a345bc-67d1-ef89-abcd-efg12345abcde"
$url = "https://login.microsoftonline.com/$tenantID/oauth2/token"
$params = @{ client_id = "a1234bcd-5678-9012-abcd-abcd1234abcd"; client_secret = "abcd~a1234bcd56789012abcdabcd1234abcd"; grant_type = "client_credentials"; resource = ‘https://purview.azure.net’ }
Invoke-WebRequest $url -Method Post -Body $params -UseBasicParsing | ConvertFrom-Json

Replacing the tenantID, client_id, and client_secret values with your own information will return the expected JSON response.

I have also added some screenshots of the app registration and where you can find the client id.
You should see these changes in the document later this evening, or tomorrow at the latest.
Thanks for your feedback!

#please-close


Memory leaks: application memory usage grows until it crashes

Description
The memory usage continuously grows using wfreerdp on WIndows.
As an example after around 30 minutes app occupied ~650MB.
It grows till it reaches 2GB and then crashes (32bit)
To Reproduce
On remote machine run the web browser with video. E.g some YouTube video.
./wfreerdp.exe -u:user -p:pass -w:1800 -h:900 -v:IP
Watch the memory usage of the app
Expected behavior
The growth should stop at around 150MB since there is a pool for frames caching
Screenshots

Application details

FreeRDP version 2.0.0-dev4 (c2e2eb910)
Command: ./wfreerdp.exe -u:user -p:pass -w:1800 -h:900 -v:IP
Connect to  Windows 10
Original log is 540MB. Attaching reduced: RDPreduced.log

Desktop (please complete the following information):

Windows 10
Chrome

@v-odin Does this also happen with /gdi:sw?

@akallabeth, that changed the behavior completely. Now it is something around 80MB.
Are there valuable cons using /gdi:sw?

@akallabeth got it. Many thanks for your help!


Can’t moving focus from an image to an adjacent image using up/down arrow.

Here is a gif for it, the key press sequence is: down, down, up, up.

I think part of the reason is draft-js-focus-plugin:L43..L45, in which the activeBlock is undefined and the condition in if will always be false.
But I suspect by setting the selectionState focus to the block-focus still won't make it focused, because the block-focus doesn't handle the update of the selectionState. Meanwhile I think neither handling the update of selectionState nor setting focus directly from another block-focus would be an easy solution here, what's your idea?
Thanks, and also thanks for your project!

Hi @houkanshan,
Thanks for reporting, I've just pushed a commit and I'll publish and update everything today. The focus stuff is totally complicated, hope iI'll find an easier solution sometime.

The focus stuff is totally complicated

+1
Looking forward to it, thanks!


Bug: data analysis objects not present when compiling for linux

Please tell us what you were doing! You can include code and files by drag and dropping them into the text area.
I compiled this library on linux mint, folowing the library documentation
What was the expected result?
generate all puredata objects and documentation
What was the actual result?
most of it was fine, but I'm missing all the data analysis objects
What operating system were you using?
Linux
Operating system version
mint 21.2
FluCoMa Version
???

I just forgot to read "quickstart guide" sorry


"godot -e" in a project folder opens the project but not the main scene

Same with godot -e -path /path/to/project.

Apparently it was already the case in 1.1, so it's likely not a regression like #2611 was.

To actually load the main scene, the project editor somehow retrieves the path to the resource and adds it to the command line: https://github.com/godotengine/godot/blob/33aa019e4f00b3ac9809c7974c1d660b2f65455f/tools/editor/project_manager.cpp#L627-L630
I'll see if this behaviour could be added directly to the -e | -editor switch.

If the path to the scene is provided in the command line, such scene is opened. Be careful to not override this behavior.

(Sorry, pressed the wrong button).

Ah you're right, I had indeed overlooked that. I'll check my WIP fix :)


Add non-interactive mode

If INSTALLER_FRONTEND=noninteractive is set a failed tasks aborts the installation right away without asking the user if they want to continue.

Thanks guys and congratulations to you @maltoe!  😄

Joining @maltoe congrats! :tada:

:) wow the news is spreading fast :D
thanks guys


dnsx: 1.1.4 -> 1.1.5

Diff: https://github.com/projectdiscovery/dnsx/compare/refs/tags/v1.1.4...v1.1.5
Changelog: https://github.com/projectdiscovery/dnsx/releases/tag/v1.1.5
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 256755 run on x86_64-linux 1

1 package built:

dnsx


update index.html

Description:
This pull request updates the Readme file to enhance the project's readability and provide more comprehensive information about the project's purpose and goals. The changes aim to help new contributors understand the project and how to contribute to it by adding installation instructions, troubleshooting steps, and a step-by-step guide for building and running the project.
Changes Made:
The following changes were made to the Readme file:
Updated the project description to provide a clear and concise explanation of the project's purpose and goals.
Added installation instructions and troubleshooting steps to assist new contributors in getting started with the project quickly.
Included a step-by-step guide for building and running the project, along with guidelines for contributing to the project.
Updated the list of dependencies and requirements to ensure that contributors have all the necessary tools and resources to work on the project.
Added a section on running tests and troubleshooting common issues that may arise during the development process.
Benefits:
The changes to the Readme file, index.html file, and styles.css file offer several benefits to the project, including:
Improved accessibility and ease of use for new contributors, decreasing the learning curve and assisting them in getting up to speed quickly.
Increased clarity and transparency regarding the project's purpose and goals, making it easier for potential users to comprehend the project's value and how it can benefit them.
Improved overall project documentation, making it simpler to maintain and update as the project evolves over time.
Additional Notes:
The pull request has undergone several reviews, and all necessary modifications have been made. The new information has been tested and validated to ensure its accuracy and completeness.
We kindly request that the project maintainers review and merge this pull request as soon as possible since it is a vital update to the project's documentation, assisting new contributors in getting started quickly.

Hello @peteronyam 👋,
This is an additional review as a result of the second opinion request.
Your design looks great and matches the Figma design. But as stated in the project requirements, the design should be responsive. Check out the requirements below:

This is how your design looks in different screen sizes:

Please take a look at this video to have a clear idea about responsive design:
Keep rocking 🚀!


Add class templates

Add page and component class to templates allowing developers to copy class files based on the kind of class needed and quickly add methods and variables for their specific project needs.

Added by pull request #5.


lorri seems to loop forever? - but nix-shell works fine

Sorry it's a proprietary project, so no code sample. :( I also don't know how to create a minimal repro.
This is on the rolling release:
[b@bryan-laptop:~/Projects/dotfiles/nixos/lorri]$ git log --oneline HEAD^..
03f1039 (HEAD, origin/rolling-release) default.nix: use `nativeBuildInputs` for tools

And nix-shell works ok:
$ nix-shell --run 'echo hello world'
hello world

The shell being built comes from haskellPackages.shellFor.
I'm using the user-local socket-activation. When lorri gets activated, it pins a CPU and just sits there saying "Started..."
If I then get cheeky and start a nix shell on the console while lorri is running, lorri crashes with:
Nov 25 17:33:58 bryan-laptop lorri[3129]: lorri: ready
Nov 25 17:34:02 bryan-laptop lorri[3129]: Started
Nov 25 17:35:09 bryan-laptop lorri[3129]: thread '<unnamed>' panicked at 'Unrecoverable error!
Nov 25 17:35:09 bryan-laptop lorri[3129]: Notify(
Nov 25 17:35:09 bryan-laptop lorri[3129]:     Io(
Nov 25 17:35:09 bryan-laptop lorri[3129]:         Os {
Nov 25 17:35:09 bryan-laptop lorri[3129]:             code: 40,
Nov 25 17:35:09 bryan-laptop lorri[3129]:             kind: Other,
Nov 25 17:35:09 bryan-laptop lorri[3129]:             message: "Too many levels of symbolic links"
Nov 25 17:35:09 bryan-laptop lorri[3129]:         }
Nov 25 17:35:09 bryan-laptop lorri[3129]:     )
Nov 25 17:35:09 bryan-laptop lorri[3129]: )', src/build_loop.rs:84:56
Nov 25 17:35:09 bryan-laptop lorri[3129]: stack backtrace:
Nov 25 17:35:09 bryan-laptop lorri[3129]:    0:     0x56413c821c1f - std::sys::unix::backtrace::tracing::imp::unwind_backtrace::hfad0220813d5e5c3
Nov 25 17:35:09 bryan-laptop lorri[3129]:    1:     0x56413c832657 - std::sys_common::backtrace::print::h16017ddc8b354e39
Nov 25 17:35:09 bryan-laptop lorri[3129]:    2:     0x56413c8254c3 - std::panicking::default_hook::{{closure}}::h8b06d3b8a7138cc5
Nov 25 17:35:09 bryan-laptop lorri[3129]:    3:     0x56413c825243 - std::panicking::default_hook::h8cac4830452b35df
Nov 25 17:35:09 bryan-laptop lorri[3129]:    4:     0x56413c825bbf - std::panicking::rust_panic_with_hook::hd32c26e1600a179b
Nov 25 17:35:09 bryan-laptop lorri[3129]:    5:     0x56413c825751 - std::panicking::continue_panic_fmt::h24b78f7279f44cef
Nov 25 17:35:09 bryan-laptop lorri[3129]:    6:     0x56413c82569e - std::panicking::begin_panic_fmt::h98672d172280200e
Nov 25 17:35:09 bryan-laptop lorri[3129]:    7:     0x56413c6aa566 - lorri::build_loop::BuildLoop::forever::h107a54d9d12e731b
Nov 25 17:35:09 bryan-laptop lorri[3129]:    8:     0x56413c6acd73 - std::sys_common::backtrace::__rust_begin_short_backtrace::h6de3911e47385787
Nov 25 17:35:09 bryan-laptop lorri[3129]:    9:     0x56413c6bb9d8 - std::panicking::try::do_call::ha622cd5ff1ae34b0
Nov 25 17:35:09 bryan-laptop lorri[3129]:   10:     0x56413c83d499 - __rust_maybe_catch_panic
Nov 25 17:35:09 bryan-laptop lorri[3129]:   11:     0x56413c6b5a92 - <F as alloc::boxed::FnBox<A>>::call_box::hed14b3946e261b17
Nov 25 17:35:09 bryan-laptop lorri[3129]:   12:     0x56413c8209ed - std::sys_common::thread::start_thread::h09a6bf95952964d1
Nov 25 17:35:09 bryan-laptop lorri[3129]:   13:     0x56413c82b8e5 - std::sys::unix::thread::Thread::new::thread_start::h165ad4e27a9c9315
Nov 25 17:35:09 bryan-laptop lorri[3129]:   14:     0x7f89f991aef6 - start_thread
Nov 25 17:35:09 bryan-laptop lorri[3129]:   15:     0x7f89f963a22e - __GI___clone
Nov 25 17:35:09 bryan-laptop lorri[3129]:   16:                0x0 - <unknown>

I'm using the user-local socket-activation. When lorri gets activated, it pins a CPU and just sits there saying "Started..."

Usually that means it’s building in the background with nix-instantiate or nix-build. If you open up (h)top you should se it in the process list (as subprocess to lorri daemon).
You should try running the daemon in a terminal with lorri -vvv daemon.

I'll try running the daemon with extra verbosity when I get the chance. But should lorri be building so furiously when nix-shell completes immediately?

But should lorri be building so furiously when nix-shell completes immediately?

It should indeed not, but we can only know for sure when we see the verbose output.

I'm also experiencing this issue quite frequently. Even if I let the daemon and all it's nix-instantiate processes running for ours it seems to never finish. Is there anything we can do to help to debug this?
My current workaround is to systemctl --user restart lorri.service (I'm on NixOS) when I spot such activity.

@turboMaCk , can you try stopping the service and then running the daemon directly in another terminal with lorri -vvv daemon? Then we might get some clues.
I plan on doing that myself as soon as I get the chance.

I will try it but it seems to be fixed after service restarts so I think running it as a new process won't guarantee to replicate the issue. BTW I have 2 machines (desktop and laptop) and I've observed this issue on both of the.
I'll get back to this once I have some more data.

I wonder if this may be a duplicate of https://github.com/target/lorri/issues/176

@chreekat does your project import <nixpkgs> or use niv?

@curiousleo It's importing <nixpkgs>.
@Profpatsch , I had a chance to run lorri -vvvv daemon, and it looks like lorri is watching my entire home directory.
[2019-12-02T12:48:51Z DEBUG lorri::nix] "nix-build" "--out-link" "/tmp/.tmpDi0suK/result" "--" "/tmp/.tmpnHIEZW/result"
[2019-12-02T12:49:33Z DEBUG lorri::build_loop] original paths: 2069
[2019-12-02T12:49:33Z DEBUG lorri::build_loop]   -> reduced to: 2
[2019-12-02T12:49:33Z DEBUG lorri::watch] Watching path "/nix/var/nix/profiles/per-user/root"
[2019-12-02T12:49:33Z DEBUG lorri::watch] Watching parent path "/nix/var/nix/profiles/per-user"
[2019-12-02T12:49:33Z DEBUG lorri::watch] Watching path "/nix/var/nix/profiles/per-user/root/channels-52-link"
[2019-12-02T12:49:33Z DEBUG lorri::watch] Watching path "/nix/var/nix/profiles/per-user/root/channels"
[2019-12-02T12:49:33Z DEBUG lorri::watch] Watching path "/home/b"
[2019-12-02T12:49:33Z DEBUG lorri::watch] Watching parent path "/home"
[2019-12-02T12:49:33Z DEBUG lorri::watch] Watching path "/home/b/.gnupg"
[2019-12-02T12:49:33Z DEBUG lorri::watch] Watching path "/home/b/.gnupg/private-keys-v1.d"
[2019-12-02T12:49:33Z DEBUG lorri::watch] Watching path "/home/b/.gnupg/openpgp-revocs.d"
[2019-12-02T12:49:33Z DEBUG lorri::watch] Watching path "/home/b/.gnupg/crls.d"
[2019-12-02T12:49:33Z DEBUG lorri::watch] Watching path "/home/b/.nix-profile"
[2019-12-02T12:49:33Z DEBUG lorri::watch] Watching path "/home/b/.nix-defexpr"
[2019-12-02T12:49:33Z DEBUG lorri::watch] Watching path "/home/b/.nix-defexpr/channels_root"
[2019-12-02T12:49:33Z DEBUG lorri::watch] Watching path "/home/b/.nix-defexpr/channels"
[2019-12-02T12:49:33Z DEBUG lorri::watch] Watching path "/home/b/.dbus"
[2019-12-02T12:49:33Z DEBUG lorri::watch] Watching path "/home/b/.dbus/session-bus"
[2019-12-02T12:49:33Z DEBUG lorri::watch] Watching path "/home/b/.local"
[2019-12-02T12:49:33Z DEBUG lorri::watch] Watching path "/home/b/.local/share"
[2019-12-02T12:49:33Z DEBUG lorri::watch] Watching path "/home/b/.local/share/gegl-0.4"
[2019-12-02T12:49:33Z DEBUG lorri::watch] Watching path "/home/b/.local/share/gegl-0.4/plug-ins"
[2019-12-02T12:49:33Z DEBUG lorri::watch] Watching path "/home/b/.local/share/keybase"

@chreekat does the project use some third-party mechanism for excluding source files, e.g. gitignore.nix? (See https://github.com/target/lorri/issues/211#issuecomment-555026353)

@curiousleo yes! This issue is a duplicate of #211. Thanks for the tip. Closing.


Update dependencies and fix broken code.

Hi @antoniolg .
This PR contains all third-party dependencies updated, and code updated accordingly. See my comments for details.
PD: AlbumsFragmentTest is not passing due to a non-mockable dependency in AlbumsFragment:
recycler = autoFitRecycler().apply(AutofitRecyclerView::style)

Thanks for this!


schema: use Go's embed package instead of esc

Signed-off-by: Stephen Day<EMAIL_ADDRESS>

What horizon do want to maintain here? That's probably a very large question. ;)

@cyphar PTAL

More important than just this PR, would be to have a small policy stating best effort that our go sources are compatible with the past few golang versions.

+100. Rather than waiting for the long tail to be cleaned up, a policy of a 3-4 supported releases sounds good to me. We aren't breaking existing projects since they can continue to use old image-spec tags. And the versions of Go they are running aren't supported by the Go developers.

@sudo-bmitch @vbatts Ok, sounds like we'll hold off on merging this until 1.18 is released.
I've added https://github.com/opencontainers/image-spec/issues/899 to cover the need for supported versions.


Warn developers to not index their sites

The sslip.io service has been abused by scammers and phishers who create sites that masquerade as legitimate sites. For example, https://nf-43-134-66-67.sslip.io/sg masqueraded as Netflix.
To combat this, we've undertaken to block all sites that masquerade as a legitimate sites, but this had the unfortunate consequence of ensnaring a legitimate staging site (th-ab.de).
This commit assists developers by updating the documentation to warn developers not to index their staging site.
[#53]

Looks good for a merge to me!


Corsair M65 Elite no lighting on scroll wheel

Expected behavior:
Scroll wheel should be light up
Actual behavior:
Only Corsair logo has rgb
How often does this problem occur?
This happens everytime (even on different computers)
Please describe the steps to reproduce this issue:
The issue can be reproduced by doing following steps:

What is the version of Aurora you are experiencing this issue with?
My version is 0.6.4b
Does the previous version of Aurora have this issue?
Tried different versions, and this is my new mouse, so...
Please include any logs, screenshots, or files that are related to this issue:

Try selecting Corsair Sabre mouse layout in Aurora

Try selecting Corsair Sabre mouse layout in Aurora

It still the same =(

I also have this issue with the m65 elite. The scroll  can not be controlled by the program at all. The rgb light stays attached to the corsair program.
Non of  the other mouse profiles change this.
It would be good also if  the mouse clicks also triggered the keytouch lights effects in the same way the corsair program does.


Go get - too many errors

Gogs version (or commit ref): https://github.com/gogits/gogs/commit/7e15ff9486cde36b76f3d39b7db23f89278acb7d
Git version: 2.7.4
Go version: go1.7.1 linux/amd64
Operating system: Ubuntu 16.04.1

Description
There's a problem when installing using sources
$ go get -u github.com/gogits/gogs
# github.com/gogits/gogs/models
go/src/github.com/gogits/gogs/models/access.go:84: cannot use x (type *xorm.Engine) as type Engine in argument to accessLevel:
        *xorm.Engine does not implement Engine (wrong type for Where method)
                have Where(interface {}, ...interface {}) *xorm.Session
                want Where(string, ...interface {}) *xorm.Session
go/src/github.com/gogits/gogs/models/access.go:94: cannot use x (type *xorm.Engine) as type Engine in argument to hasAccess:
        *xorm.Engine does not implement Engine (wrong type for Where method)
                have Where(interface {}, ...interface {}) *xorm.Session
                want Where(string, ...interface {}) *xorm.Session
go/src/github.com/gogits/gogs/models/access.go:245: cannot use x (type *xorm.Engine) as type Engine in argument to r.recalculateAccesses:
        *xorm.Engine does not implement Engine (wrong type for Where method)
                have Where(interface {}, ...interface {}) *xorm.Session
                want Where(string, ...interface {}) *xorm.Session
go/src/github.com/gogits/gogs/models/action.go:194: cannot use x (type *xorm.Engine) as type Engine in argument to newRepoAction:
        *xorm.Engine does not implement Engine (wrong type for Where method)
                have Where(interface {}, ...interface {}) *xorm.Session
                want Where(string, ...interface {}) *xorm.Session
go/src/github.com/gogits/gogs/models/action.go:217: cannot use x (type *xorm.Engine) as type Engine in argument to renameRepoAction:
        *xorm.Engine does not implement Engine (wrong type for Where method)
                have Where(interface {}, ...interface {}) *xorm.Session
                want Where(string, ...interface {}) *xorm.Session
go/src/github.com/gogits/gogs/models/action.go:568: cannot use x (type *xorm.Engine) as type Engine in argument to transferRepoAction:
        *xorm.Engine does not implement Engine (wrong type for Where method)
                have Where(interface {}, ...interface {}) *xorm.Session
                want Where(string, ...interface {}) *xorm.Session
go/src/github.com/gogits/gogs/models/action.go:586: cannot use x (type *xorm.Engine) as type Engine in argument to mergePullRequestAction:
        *xorm.Engine does not implement Engine (wrong type for Where method)
                have Where(interface {}, ...interface {}) *xorm.Session
                want Where(string, ...interface {}) *xorm.Session
go/src/github.com/gogits/gogs/models/issue.go:154: cannot use x (type *xorm.Engine) as type Engine in argument to issue.loadAttributes:
        *xorm.Engine does not implement Engine (wrong type for Where method)
                have Where(interface {}, ...interface {}) *xorm.Session
                want Where(string, ...interface {}) *xorm.Session
go/src/github.com/gogits/gogs/models/issue.go:231: cannot use x (type *xorm.Engine) as type Engine in argument to i.hasLabel:
        *xorm.Engine does not implement Engine (wrong type for Where method)
                have Where(interface {}, ...interface {}) *xorm.Session
                want Where(string, ...interface {}) *xorm.Session
go/src/github.com/gogits/gogs/models/issue.go:312: cannot use e (type *xorm.Session) as type Engine in argument to issue.getLabels:
        *xorm.Session does not implement Engine (wrong type for Where method)
                have Where(interface {}, ...interface {}) *xorm.Session
                want Where(string, ...interface {}) *xorm.Session
go/src/github.com/gogits/gogs/models/issue.go:312: too many errors

I have the same question!

I am having the same issue upgrading from source

:+1:

@lenisko you dont have filled all fields on the issue reporting template. What DBMS are you using ? Have you try with a different DBMS ?

Same problem here. Go version is go1.7.1 freebsd/amd64.

Is this due to, xorm making some breaking changes to its API?

Is this due to, xorm making some breaking changes to its API?

Yes, see discussion on Gitter and fix here: https://github.com/gogits/gogs/pull/3685

Cool 👍 !

Fixed by #3685


Use HTTPS

Seems fair enough, although for historical reasons I feel obligated to point out that google redirects all http requests to https anyway, this makes the result possibly quicker and more obvious in the code.


Update FAQs for 1.1.0

Purpose
This PR adds an FAQ to APK 1.1.0 documentation, detailing on how to fix the ensure CRDs are installed first error.

Please provide a detailed issue description, explaining what we are updating here.

Please provide an issue description, explaining what we are updating here.

Fixed.


Changes that make change_version functional

I executed the following tests:
./release-script/for-all-boosters.sh -d change_version
./release-script/for-all-boosters.sh -d change_version -v 1.5.10-7-SNAPSHOT
./release-script/for-all-boosters.sh -d change_version -p
./release-script/for-all-boosters.sh -d change_version -p 1.5.10-14

They all past (except the 3rd one that failed to build the booster since the artifactId for the parent didn't exist)

By the way, change_version -p 1.5.10-14` shouldn't work.

Closing this PR and committing a fix with only eval. Thank you!

Regarding change_version -p 1.5.10-14 I pasted the wrong command :)
I had executed ./release-script/for-all-boosters.sh -d change_version -p -v 1.5.10-14


Power Toys Run Not Working

Microsoft PowerToys version
<IP_ADDRESS>
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
PowerToys Run
Steps to reproduce
Version: <IP_ADDRESS>
OS Version: Microsoft Windows NT 10.0.19045.0
IntPtr Length: 8
x64: True
Date: 2023-02-03 오후 6:26:29
Exception:
System.InvalidOperationException: Dispatcher processing has been suspended, but messages are still being processed.
at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
✔ Expected Behavior
No response
❌ Actual Behavior
No response
Other Software
No response

/dup #18166
Can you please add some details on that original issue? Curious to see if you have adobe reader installed for pdfs and if it's occurring when PowerToys Run is trying to show a pdf file.

For any users that are able to replicate this consistently, can you please update to 0.68.1 and disable thumbnail generation to verify if it fixes the issue? Please let us know on #18166!


Adding tests to increase coverage for stateful expression test

While implementing the "specialised" stateful expression I found test case I didn't cover

Supplied reference doesn't exists in BinaryNode{RefNode, NumNode}
BinaryNode{RefNode,NumNode} value is changed
BinaryNode{RefNode,NumNode} type is changed from float64 to int64
BinaryNode{BinaryNode{RefNode,NumNode}, BinaryNode{RefNode,NumNode}}

I am submitting this as separate PR so the specialised stateful expression won't be big PR

The tests are failing because:
--- FAIL: TestStream_GroupByWhere (0.01s)
	streamer_test.go:3445: digraph TestStream_GroupByWhere {
		srcstream0 -> stream1;
		stream1 -> groupby2;
		stream1 -> where3;
		where3 -> join5;
		groupby2 -> join5;
		join5 -> eval6;
		eval6 -> window7;
		window7 -> mean8;
		mean8 -> http_out9;
		}
	streamer_test.go:3520: unexpected series tags: i: 1
		exp map[host:serverA cpu:cpu1]
		got map[cpu:cpu-total host:serverA]

Which is weird..

@yosiat That test has recently become flaky and needs to be fixed... #474

@nathanielc ok, do you want to rebounce the build or something?

@yosiat  Rebuilding.. is that not something you can do? I am not always sure what others have access to on the project.

@nathanielc where do you see the rebuild button? It would make sense that I won't have access to rebuild

Top right of the CircleCI interface.

@nathanielc I don't have this option


factrix, adscripted (logical-conflict)

This pull request was generated by the 'mq' tool

/trunk merge


[FEATURE] Please, provide a mobile version of menu sidebar

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

This issue will be resolved in #283.


ci: Support semantic release at Github Actions

Fixes #13, fixes #14.
GH_TOKEN needs to be added to Actions secrets.

@xiaobeiswift plz review.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


imglab --split option

Hi,
There's seem to be a change between version v1.6 and v1.7 of imglab regarding the split option

v1.6 : the result 'with' xml file contains only annotation of the passed argument for split
v1.7: the result 'with' xml file contains any annotation as long as they are part of an image that contains the passed argument for split

yes

any way to return to the previous behaviour, it was really usefull to test a algorithm against a single class

When you call load_image_dataset you can tell it to only load only boxes with a particular label (see http://dlib.net/dlib/data_io/load_image_dataset_abstract.h.html#load_image_dataset).  Or you could strip boxes from xml files imglab's --rmlabel command if you wanted to go that way.

i understand but we are using command line for that, and rmlabel would mean that i need to give all the classes i dont want (about a hundred in my case) that i dont want...

Aren't you then using load_image_dataset() to load them?
But in any case, I would be amenable to a pull request that added a --rm-other-labels or some such command to imglab :)
The reason --split is the way it is now is because it makes the transformation invertible and much more useful in the context of the other commands like --add.

ok i ll try a PR
by the way dlib is amazing, if you'd like to see what we built with it i ll be happy to show you

Thanks :)
Sure, what did you guys build?

image detection for shelves products i ll be happy to elaborate on skype


Feature: Token model integration

Closes #152
Description
This pull request introduces a new RequestFee function has been implemented into the BaseContract, which is now invoked during contract creation and reward distribution functions, aligning transaction fee handling with user activities. This is the first test to us testing our token model.
Added

Error types
RequestFee functionality to BaseContract
call requestFee in creation and reward functions

Updated

jest globalSetup script is now .ts
update address constants
Update tests

/release-pr

/release-pr

/release-pr


Change secure endpoint write code to use max_frame_size to control encrypted frame sizes at the sender.

Change secure endpoint write code to use max_frame_size to control encrypted frame sizes at the sender.

Are the test failures unrelated?

Just thinking about this a little more... can we add something to secure_endpoint_test.cc to assert that this is working?

secure_endpoint_test.cc calls grpc_endpoint_tests(...) defined in endpoint_tests.cc. I configured the max_frame_size argument in the grpc_endpoint_write API call made in that file. The tests there basically write some data over one endpoint in a connected endpoint pair and verify that the data read at the other endpoint equals the data that was written

Could we maybe inject an endpoint underneath the secure endpoint and assert the max write size is respected?

Could we maybe inject an endpoint underneath the secure endpoint and assert the max write size is respected?

I added an intercept_endpoint to secure_endpoint_test now. The intercept endpoint will intercept every write, parse the frame size and verify that the protected data size does not exceed max_frame_size. It will then pass the slices down to tcp endpoint.


Use function types and lambda expressions in Kotlin: Android Basics with Compose

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-compose-function-types-and-lambda?authuser=1&continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-2-pathway-1%3Fauthuser%3D1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-function-types-and-lambda#3
In which task and step of the codelab can this issue be found?
Adding the extraTreat function to the trickOrTreat functionn - where is the extraTreat function defined?
Describe the problem
after adding         println(extraTreat(5)) the following is returned
No value passed for parameter 'extraTreat'
No value passed for parameter 'extraTreat'
code is:-
fun main() {
val treatFunction = trickOrTreat(false)
val trickFunction = trickOrTreat(true)
treatFunction()
trickFunction()
}
fun trickOrTreat(isTrick: Boolean, extraTreat: (Int) -> String): () -> Unit{
if (isTrick) {
return trick
} else {
println(extraTreat(5))
return treat
}
}
val trick = {
println("No treats!")
}
val treat: () -> Unit = {
println("Have a treat!")
}
Steps to reproduce?

Go to...
Click on...
See error...

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

Need to complete all of stage before trying to run


Split up "points" and "grade"

I would like to split up "points" and "grade" in the grade.yaml file. I have way too many times changed the wrong number. So far it has not resulted in any bad feedback, but is it only a matter of time before I mess up without noticing.

Would it help to rename grade to points and points to possible-points?

Probably a bit. Not having the strings be the same length would make it easier.
Though I do not understand why the field is even needed since it is also present in the template.


Support unzipping GeoPackage sources at runtime

Extension to #413 which allows us to read GeoPackage sources from ZIP archives.
Testing locally, I was able to use the NaturalEarth data from https://naciscdn.org/naturalearth/packages/natural_earth_vector.gpkg.zip as a direct replacement for addNaturalEarthSource().
We should be able to remove NaturalEarthReader, but since there are several references to natural_earth_vector.sqlite.zip which will break, I've left it as a @Deprecated annotation for now. At the very least I think we'd need to update the planetiler-openmaptiles repo first to keep tests from breaking.

Hey @erik  just checking in on this, were you planning to make more changes?

@msbarry yeah, hopefully will have a chance this upcoming week, holidays have kept me busy. Couple of questions for you in the comments above which might reduce number of review iterations

Hey @msbarry, just making sure this didn't skip through the cracks, any other changes you'd like to see here?

Hey @msbarry, just making sure this didn't slip through the cracks, any other changes you'd like to see here?

Sorry for the delay! Looks good, just have a couple of minor tweaks to the tests, I'll try pushing them then land.
One thing I noticed is that it's 2-3x slower than natural earth reader for the natural earth geopackage file. Not a big deal in the grand scheme of things since it only takes ~30 seconds no matter the size of the extract, I'm just curious if there's any obvious reason for the slowdown...

@msbarry when I was first working on this I believe I noticed that the NaturalEarthReader class wasn't actually reading all of the possible features out of the sqlite DB (maybe due to missing SRIDs?). Unfortunately I don't remember which features weren't loading, but perhaps that could be the cause of the slowdown if they are now being read.

@msbarry when I was first working on this I believe I noticed that the NaturalEarthReader class wasn't actually reading all of the possible features out of the sqlite DB (maybe due to missing SRIDs?). Unfortunately I don't remember which features weren't loading, but perhaps that could be the cause of the slowdown if they are now being read.

OK got it, that makes sense. One other thing is that it now unzips the zip file twice - once to get the count, then again to read the file. Another option would be send the unzipped file to a deterministic location, and keep it around between those.  @bdon  also pointed out that we could keep it around between runs to save from having to unzip it each time.


python311Packages.pontos: 23.7.5 -> 23.7.6

Diff: https://github.com/greenbone/pontos/compare/refs/tags/v23.7.5...v23.7.6
Changelog: https://github.com/greenbone/pontos/releases/tag/v23.7.6
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 242708 run on x86_64-linux 1

14 packages built:

faraday-agent-dispatcher
faraday-agent-dispatcher.dist
gvm-tools (python310Packages.gvm-tools)
gvm-tools.dist (python310Packages.gvm-tools.dist)
python310Packages.pontos
python310Packages.pontos.dist
python310Packages.python-gvm
python310Packages.python-gvm.dist
python311Packages.gvm-tools
python311Packages.gvm-tools.dist
python311Packages.pontos
python311Packages.pontos.dist
python311Packages.python-gvm
python311Packages.python-gvm.dist


The cargo included with 1.61 is smart enough to not care about codegen's dependencies.


outline view should clear previous filters on focus

I constantly use the Outline view, and specifically the keybinding to quickly focus on the outline view. However, the outline view persists the previous filters on focus, which is a really inefficient workflow. Ideally this could be a preference/setting that gets toggled. I would love for every time I hit the keyboard shortcut to focus the outline view and start typing, I'm starting with a fresh input.
For now, I've changed the keybinding I would use to trigger "Outline focus" and bound that to "Go To Symbol" which DOES clear previous input on each re-focus

@jrieken I wouldn't make this a tree thing (ie. make programmatic calls to focus() always clear the filter). Could we have this for Outline?


Hub Site Settings different within a site collection and central admin

Hello,
Is it normal that Hub Site settings are differents within a site collection and the central admin. In a site coll, you can edit de Logo, Name and Site design applied to associated sites. In central admin, you can just edit the name and the people who can associate sites with this hub site. Why can't we have the same options for both menu?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bc4df1d8-955c-63d2-628e-8359391b8710
Version Independent ID: 01326ab6-1270-d096-64e8-eb7d63ea9863
Content: Create a hub site in SharePoint Online
Content Source: SharePoint/SharePointOnline/create-hub-site.md
Service: sharepoint-online
GitHub Login: @kaarins
Microsoft Alias: kaarins

@boby5555 since this is a feature request, you may want to repost this at https://sharepoint.uservoice.com/forums/330318-sharepoint-administration which the SharePoint product group reviews regularly.

@boby5555  - thank you for engaging with the community here for the docs.
As Trevor suggested, I know the product teams are always looking for user feedback and how to make SharePoint better. They keep a close tab on user feedback and it would be awesome if you could add your voice in User Voice https://sharepoint.uservoice.com/.
You might find others have made a similar request that you can add to, or you can open a new one. Let us know here if you do so we can up-vote your request.
Thank you for your contribution to make the docs better! Much appreciated!

@officedocsbot close


Handle unsupported exception gracefully

Currently, when an UnsupportedOperationException is thrown when fetching latest offsets (e.g. in case of Kinesis/Pulsar), we do not update the ingestion delay in ms as well, which we should tbh

Codecov Report
Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (59551e4) to head (84d580c).
Report is 702 commits behind head on master.

Files
Patch %
Lines

...e/data/manager/realtime/IngestionDelayTracker.java
0.00%
2 Missing :warning:

...a/manager/realtime/RealtimeSegmentDataManager.java
0.00%
1 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (84d580c). Click for more details.
HEAD has 43 uploads less than BASE

Flag
BASE (59551e4)
HEAD (84d580c)

integration
7
3

integration2
3
2

temurin
12
3

java-21
7
3

skip-bytebuffers-true
3
2

skip-bytebuffers-false
7
1

unittests
5
0

unittests1
2
0

java-11
5
0

unittests2
3
0

integration1
2
1

custom-integration1
2
0

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #13524       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.75%
+ Complexity      207        6      -201
=============================================
  Files          2436     2482       +46
  Lines        133233   137191     +3958
  Branches      20636    21290      +654
=============================================
- Hits          82274        6    -82268
- Misses        44911   137185    +92274
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
<0.01% <0.00%> (-0.01%)
:arrow_down:

integration1
<0.01% <0.00%> (-0.01%)
:arrow_down:

integration2
0.00% <0.00%> (ø)

java-11
?

java-21
<0.01% <0.00%> (-61.63%)
:arrow_down:

skip-bytebuffers-false
0.00% <0.00%> (-61.75%)
:arrow_down:

skip-bytebuffers-true
<0.01% <0.00%> (-27.73%)
:arrow_down:

temurin
<0.01% <0.00%> (-61.75%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.