Use Rails.application.assets_manifest

First of all, thank you for creating and maintaining the library. We actively use at Shopify ❤
This PR fixes a bug that we recently discovered. We found that with precompiled assets and config.assets.compile = false option in production, Rails.application.assets would always be nil. That makes AssetPipelineLoader simply useless. As soon as we disabled asset compilation in production, premailer broke and styles were no longer inlined.
The proper way to discover assets would be to use Rails.application.assets_manifest. It works both in development (with compile-on-the-fly) and in production (with precompiled assets and the manifest).
@fphilipe let me know what you think about the patch.
cc @rafaelfranca

Thank you for feedback. I updated the PR to use rescue.

First of all, thank you for creating and maintaining the library. We actively use at Shopify ❤

Cool! Happy to know it's serving you guys 😄
I just got back from vacation and saw that you've did quite a bit of work. I'll need to find some time to have a look at all this. But thanks already for your contribution. I'll try to get to it ASAP 😊

Thanks for feedback! I updated the PR.

@fphilipe I rebased it against new master 👌


Performance improvements

#3389

This pull request introduces 15 alerts when merging 764b4f5c0e89d05f681cb0074f88058f942e0cc2 into 6afd878f3bf3b00ffce90ae401183d581639793d - view on LGTM.com
new alerts:

15 for Unused variable, import, function or class

Comment posted by LGTM.com


Slow, laggy and zittery notebooks while scrolling.

Type: Performance Issue
Hello, I am Aparnesh from India. I am using VS Code from almost 7 years and I really loved it for its smoothness and flexibility towards any kind of development or programming.
However, nowadays from a year ago I am using VS Code as my primary editor for notebooks ( I mean ipynb files). And all the projects I am doing on it, as I shifted from Jupyter Lab and Jupyter Notebook.
But, Really I want to tell you guys, I have a laptop with 16GB of RAM AMD Ryzen 5500U processor which is a really good capable processor works fine with Android development, and a NVMe storage of 512GB.
I don't know what is the issue, Is it because of there is no Dedicated big GPU card available in my laptop, however I have a AMD Radeon Graphics with Dedicated 512MB memory and a shared GPU memory of 7GB with RAM.
Or whatever it is, I don't know why My VS Code is laggy with the Jupyter Notebooks while I scrolls down or scrolls up. Perhaps it loads or whatever, when I say laggy it means that while scrolling the cells zitters very fast but there is something which is not looking good and making me feel like I have no processing power.
It is really a humble request to you guys if you can fix it, please consider my problem it is seriously very problematic. Does'nt feel  good.
While in other areas everything good, recently I gone through the may relesase note and found the new feature for remote pc or devices, the terminal scrollbar got new look, the keyboard keybinding setting update everything look good.
I appreciate your hard work, and oviously smart work and your dedication to acheive new updates with the consistancy you guys maintain and always do changes or add features with keeping in mind that a user will get greater experience.
Thanks for all of these guys. Stay Blessed and Do always what you are doing.
VS Code version: Code 1.92.1 (eaa41d57266683296de7d118f574d0c2652e1fc4, 2024-08-07T20:16:39.455Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 5 5500U with Radeon Graphics          (12 x 2096)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabledwebnn: disabled_off

Load (avg)
undefined

Memory (System)
15.35GB (7.97GB free)

Process Argv
C:\Users\Acer\OneDrive\Documents\Aparnesh_Shukla\Personal\Machine_Learning\NumPy.code-workspace --crash-reporter-id db02070a-6dee-43c6-8a7d-f76e6148499c

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
    0	   137	 11780	code main
    0	   146	  3704	   gpu-process
    0	   260	  7676	window [1] (session_16_pandas_series.ipynb - NumPy (Workspace) - Jupyter - Visual Studio Code)
    0	   129	  8404	   window
    0	    28	 10560	   crashpad-handler
    0	    42	 11316	   utility-network-service
    0	   583	 11564	extensionHost [1]
    0	     4	   908	     c:\Users\Acer\OneDrive\Documents\Aparnesh_Shukla\Personal\Machine_Learning\NumPy\venv\Scripts\python.exe c:\Users\Acer\.vscode\extensions\ms-python.isort-2023.10.1\bundled\tool\lsp_server.py
    0	    11	  7176	       C:\WINDOWS\system32\conhost.exe 0x4
    0	    48	  7348	       "C:\Users\Acer\AppData\Local\Programs\Python\Python311\python.exe" c:\Users\Acer\.vscode\extensions\ms-python.isort-2023.10.1\bundled\tool\lsp_server.py
    0	   102	  2956	     electron-nodejs (server.js )
    0	   103	  4900	     "C:\Users\Acer\AppData\Local\Programs\Microsoft VS Code\Code.exe" "c:\Users\Acer\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\markdown-language-features\dist\serverWorkerMain" --node-ipc --clientProcessId=11564
    0	    89	  8284	     electron-nodejs (server.js )
    0	   126	  8820	     electron-nodejs (languageServer.js )
    0	   208	 10196	     electron-nodejs (bundle.js )
    0	     4	 10540	     c:\Users\Acer\OneDrive\Documents\Aparnesh_Shukla\Personal\Machine_Learning\NumPy\venv\Scripts\python.exe c:\Users\Acer\.vscode\extensions\ms-python.black-formatter-2024.2.0\bundled\tool\lsp_server.py --stdio
    0	    11	 14660	       C:\WINDOWS\system32\conhost.exe 0x4
    0	    49	 16600	       "C:\Users\Acer\AppData\Local\Programs\Python\Python311\python.exe" c:\Users\Acer\.vscode\extensions\ms-python.black-formatter-2024.2.0\bundled\tool\lsp_server.py --stdio
    0	     4	 13952	     electron-nodejs (Dx.js )
    0	    65	  2776	       electron-nodejs (Dx.js )
    0	    11	 10980	       C:\WINDOWS\system32\conhost.exe 0x4
    0	    17	 14104	     c:\Users\Acer\AppData\Local\Programs\Python\Python311\python.exe c:\Users\Acer\.vscode\extensions\ms-toolsai.jupyter-2024.4.0-win32-x64\pythonFiles\vscode_datascience_helpers\kernel_interrupt_daemon.py --ppid 11564
    0	    11	  9944	       C:\WINDOWS\system32\conhost.exe 0x4
    0	     4	 16372	     electron-nodejs (wAVSKc.js )
    0	    65	  7164	       electron-nodejs (wAVSKc.js )
    0	    11	 15108	       C:\WINDOWS\system32\conhost.exe 0x4
    1	   106	 11816	window [2] (Issue Reporter)
    0	   116	 15752	ptyHost
    0	     7	  4252	     conpty-agent
    0	    75	  7560	     C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe -noexit -command "try { . \"c:\Users\Acer\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\contrib\terminal\browser\media\shellIntegration.ps1\" } catch {}"
    0	     7	  8320	     conpty-agent
    0	    80	  8380	     C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe -noexit -command "try { . \"c:\Users\Acer\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\contrib\terminal\browser\media\shellIntegration.ps1\" } catch {}"
    0	    81	 11472	     C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe -noexit -command "try { . \"c:\Users\Acer\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\contrib\terminal\browser\media\shellIntegration.ps1\" } catch {}"
    0	     7	 12472	     conpty-agent
    0	    87	 16424	fileWatcher [1]
    0	   100	 17292	   window
    0	   123	 17328	shared-process

Workspace Info
|  Window (session_16_pandas_series.ipynb - NumPy (Workspace) - Jupyter - Visual Studio Code)
|    Folder (NumPy): 16684 files
|      File types: py(5299) pyc(5299) pyi(2098) pyd(150) txt(86) lib(69)
|                  afm(60) c(57) f90(49) h(45)
|      Conf files: package.json(1);

Extensions (61)

Extension
Author (truncated)
Version

better-comments
aar
3.0.2

vscode-django
bat
1.15.0

vscode-tailwindcss
bra
0.12.6

flask-snippets
cst
0.1.3

dart-code
Dar
3.94.0

flutter
Dar
3.94.0

competitive-programming-helper
Div
2024.7.1722430096

es7-react-js-snippets
dsz
4.4.3

gitlens
eam
15.2.3

vsc-material-theme
Equ
34.5.2

vsc-material-theme-icons
equ
3.8.7

prettier-vscode
esb
10.4.0

vscode-firefox-debug
fir
2.9.10

code-runner
for
0.12.2

kotlin
fwc
0.2.35

copilot
Git
1.222.0

copilot-chat
Git
0.18.1

copilot-labs
Git
0.17.1121

heygithub
Git
0.21.1441

vscode-auto-open-markdown-preview
hnw
0.0.4

vscode-ansi
ili
1.1.7

better-cpp-syntax
jef
1.27.1

polacode-2019
jef
0.6.1

MagicPython
mag
1.1.0

Kotlin
mat
1.7.1

vscode-language-babel
mgm
0.0.40

mongodb-vscode
mon
1.7.0

vscode-docker
ms-
1.29.2

vscode-edge-devtools
ms-
2.1.5

black-formatter
ms-
2024.2.0

debugpy
ms-
2024.10.0

isort
ms-
2023.10.1

python
ms-
2024.12.3

vscode-pylance
ms-
2024.8.1

jupyter
ms-
2024.7.0

jupyter-keymap
ms-
1.1.2

jupyter-renderers
ms-
1.0.19

vscode-jupyter-cell-tags
ms-
0.1.9

vscode-jupyter-slideshow
ms-
0.1.6

cmake-tools
ms-
1.18.44

cpptools
ms-
1.21.6

cpptools-extension-pack
ms-
1.3.0

hexeditor
ms-
1.10.0

vscode-speech
ms-
0.10.0

vsliveshare
ms-
1.0.5936

vsliveshare-pack
ms-
0.4.0

material-icon-theme
PKi
5.9.0

java
red
1.33.0

LiveServer
rit
5.7.9

vscode-fileutils
sle
3.10.3

cmake
twx
0.0.17

intellicode-api-usage-examples
Vis
0.2.8

vscodeintellicode
Vis
1.3.1

vscode-gradle
vsc
3.16.4

vscode-java-debug
vsc
0.58.0

vscode-java-dependency
vsc
0.24.0

vscode-java-pack
vsc
0.29.0

vscode-java-test
vsc
0.42.0

vscode-maven
vsc
0.44.0

jinja
who
0.0.8

open-in-external-app
YuT
0.10.0

(7 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vscod805cf:30301675
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
a9j8j154:30646983
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonnoceb:30805159
asynctok:30898717
pythonregdiag2:30936856
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
accentitlementsc:30995553
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
bdiig495:31013172
pythoncenvpt:31062603
a69g1124:31058053
dvdeprecation:31068756
dwnewjupyter:31046869
impr_priority:31102340
nativerepl2:31104044
refactort:31108082
pythonrstrctxt:31112756
wkspc-onlycs-t:31111718

@AparneshShukla can you please help provide a screen recording of what you were seeing to help us troubleshoot? I have a few ideas why it happens but want to gather enough info, thanks in advance!


[Bug]: After returning from Wikidata, searched images ("Nearby") are missing

Summary
If I return to the Commons app after viewing information from Wikidata, for example, not all the images I was looking for ("Nearby") are displayed.
Steps to reproduce

follow the link to Wikidata of a picture you are looking for

https://commons.wikimedia.org/wiki/File:20240901_xl_1613-Commons_App_Screenshot_-_nach_der_Rückkehr_aus_Wikidata_fehlen_gesuchte_Bilder_("In_der_Nähe").png

return to the Common App

all searched images (“nearby”) are no longer displayed

https://commons.wikimedia.org/wiki/File:20240901_xl_1613-Commons_App_Screenshot_-_nach_der_Rückkehr_aus_Wikidata_fehlen_gesuchte_Bilder_("In_der_Nähe")_2.png

Expected behaviour
After returning from Wikidata, all searched images of the last location(!) are displayed
A separate button "Refresh here" (exactly at the point on the map to which I had just zoomed) could solve the problem.
Actual behaviour
If I return to the Commons app after viewing information from Wikidata, for example, not all the images I was looking for ("Nearby") are displayed.
Device name
Google Pixel Pro 7
Android version
14
Commons app version
5.0.2~05ffd123e
Device logs
No response
Screen-shots
See above
Would you like to work on the issue?
None

Hi @OpenGreenStreet ,
Nearby has changed so much since the latest stable release, I doubt the code related to this exists anymore.
Any chance you could try building an APK from the latest source and try it?

Unfortunately not. I am interested in the subject. But I don't have the necessary resources and skills. I would be happy to test it again with the next stable version.
I think that I would have liked something similar via a feature request.
The simplest thing from my user's point of view would be an additional button for updating. In my opinion, this would also be helpful in other situations. StreetComplete offers exactly that via the “download here” function.


benchmark type detection

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
type_index seems to be a hidden gem
@arnej27959 please review

[dynamic_cast] cost is 20.20 ns (true 17.67, false 24.02, baseline  0.65)
  [type_index] cost is  0.27 ns (true  0.95, false  0.88, baseline  0.65)
      [typeid] cost is  0.59 ns (true  0.93, false  1.56, baseline  0.65)
  [dynamic id] cost is  1.43 ns (true  2.26, false  1.89, baseline  0.65)
   [static id] cost is  0.00 ns (true  0.63, false  0.67, baseline  0.65)

@baldersheim @toregge FYI

@vekterli FYI

TIL: std::type_index is a thing!


runtime error starting love2dcs on nonubuntu linux

my hello-world in clojure/love2dCS fails to start on non-ubuntu linux

Here's startup failure https://hatebin.com/qagbuwacqg
And glxinfo https://hatebin.com/wzjfluqicq
my first guess would be mesa library version conflict due to ubuntu package being bit outdated, so when can we expect updated love2dcs package ?
PS also my first guess might be wrong and I'll appreciate any help
Thanks!

I built project_dotnet.dll like in #110 so it starts fine now.


Add S3FileLogger and LocalFileLogger

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)

[x] Did you read the contribution guide?
[x] Did you update the docs? We use Numpy format for all the methods and classes.
[x] Did you write any new necessary tests?
[ ] Did you update the CHANGELOG?

Type of Change

[ ] Examples / docs / tutorials / contributors update
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Improvement (non-breaking change which improves an existing feature)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes
Look #344.
Related Issue
#344.
Closing issues
Closes #344.

Codecov Report

Merging #372 (f7b1dab) into master (aa4dc9e) will decrease coverage by 35.57%.
The diff coverage is 31.50%.

@@             Coverage Diff             @@
##           master     #372       +/-   ##
===========================================
- Coverage   87.47%   51.90%   -35.58%
===========================================
  Files          97       98        +1
  Lines        4736     4876      +140
===========================================
- Hits         4143     2531     -1612
- Misses        593     2345     +1752

Impacted Files
Coverage Δ

etna/loggers/console_logger.py
51.72% <ø> (-37.94%)
:arrow_down:

etna/loggers/file_logger.py
29.92% <29.92%> (ø)

etna/loggers/base.py
68.96% <33.33%> (-25.27%)
:arrow_down:

etna/loggers/__init__.py
100.00% <100.00%> (ø)

etna/loggers/wandb_logger.py
32.92% <100.00%> (+0.74%)
:arrow_up:

etna/commands/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

etna/commands/backtest_command.py
0.00% <0.00%> (-96.43%)
:arrow_down:

etna/commands/forecast_command.py
0.00% <0.00%> (-92.00%)
:arrow_down:

etna/commands/__main__.py
0.00% <0.00%> (-87.50%)
:arrow_down:

etna/commands/resolvers.py
0.00% <0.00%> (-80.00%)
:arrow_down:

... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa4dc9e...f7b1dab. Read the comment docs.


0001: extra info re starting in PB mode

Because PB mode still allows the key-commands/menus/context menus/buttons to do both "new window" and "new private window", and because in this mode the PB mode purple mask icon is never shown, this is not clear. See issue #73

Doesn't need the comma I think but other than that I like it

FYI PK added this note recently: Private browsing breaks Kerberos authentication

PB mode breaks a lot of stuff: btw, OT: did the concurrent profiles wiki - check it out. Will do implementation soon, and revamp readme (hopefully both today) - then it's article time for Martin. I want him to publish the article on Saturday - weekends are good

Ok, cool :)


make afterwalk function prototype consistent with beforewalk

a minor code clean up for afterwalk and beforewalk

CLA is valid!

pls update the dist/ and the following too:
https://github.com/yahoo/context-parser/blob/c98cee96ef538680a604dec3a1e38ce9c4e0649d/tests/unit/run-bug-spec.js#L24-L29

recheck all the code / test cases with afterWalk function signature

can we combine this to pull request #16 ?

this is no longer needed if https://github.com/yahoo/context-parser/pull/16 is merged.

agreed


How to generated the "./zzz_generated/chip-tool/zap-generated/Commands.h"

as can be seen, the "zzz_generated/chip-tool/zap-generated/Commands.h" is generated by zap tool. but the document not say how to generate  and the source files to generate it.

scripts/tools/zap_regen_all.py

thanks


Add Carlini and Wagner audio attack on ASR systems

Description
This PR adds the CarliniWagnerASR attack module. It is implemented as a special case of the ImperceptibleASR, where max_iter_stage_2 is zero by default. Thus skipping the second stage of that attack.
Furthermore, the PR includes some commits from #760 that were not correctly applied during the 1.5 release.
Type of change
Please check all relevant options.

[x] Improvement (non-breaking)
[x] New feature (non-breaking)

Testing
Several tests have been added to the test suite.
Test Configuration:

Fedora 33
Python 3.8.6
ART 1.5.1 development

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

I fully agree with your two comments and I have rebased the PR accordingly :100:


Custom tx: Fetch implementation abi when contract is proxy

What is the feature about
When using the custom tx builder and attempting to interact with a proxied contract the Abi is fetched for the proxy contract.
Rather we should detect that the contract is a proxy and additionally fetch the abi for the proxy's implementation.
The list of requirements

detect that input contract is a proxy via interface
fetch implementation abi
Parse functions from the implementation abi

Designs/sketches
Should largely happen behind the scenes. Show a message that we've detected a proxy and fetched the implementation abi.
This would greatly enhance usability for proxy contracts via the custom transaction builder.

Isn’t that how it already works? If it detects a proxy, it offers to use the implementation ABI.

It has not worked in my testing with the Base (Optimism) Portal contract. I've been needing to add the implementation ABI manually.
https://etherscan.io/address/0x49048044d57e1c92a77f79988d21fa8faf74e97e#writeProxyContract


Fix export of static method call to ClosureExporter

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Fixed issues
#52

What about test?

👍


data.process events are async, so adjust how they are handled

data.process events are async, so adjust how they are handled, as they may occur after the job finishes.

@zachmullen When you get a change, can you review this PR?  Any others you'd like to handle would be appreciated, too.

Thank you.


Build a website around it

Gotta make getting that OAuth much nicer... Damn.

Done. http://twitch.seanodonnell.co.uk


Improve browser support

Ideally, the site should function as expected in the last couple of versions of Chrome, Firefox, Safari and IE11. There are known issues in Safari and IE11 currently.

The genetics portal is now functional in IE11. The issues with mouse interaction on the Gecko plot will be addressed in this issue https://github.com/opentargets/genetics/issues/139


Feature: Store command history into a .ost file and read from it with HISTORY command

The current implementation of the HISTORY command only stores past entries in memory and isn't accessible after the DB session is done.
Need to store command history in a file and read from it. Perhaps this is a good opportunity to store data in a .ost file and read from it :)

After thinking about it more perhaps its not the "safest" thing ti store history on disk....
But if I continue to go through with this idea
All I'd need to do is essentially build another execute command procedure that itself is called inside the main command execution procedure. The second proc will be what takes the ATOM values and executes a very specific procedure that will perform the actions of creating a new record on the "History" cluster as well as setting their value. After one history records value is set another empty one is immediately created. From here the only thing that needs to happen is update the current HISTORY procedure to read from the cluster in that file. One thing to keep in mind is that I'd be essentially giving the command line, and thus OstrichDB explicit command two execute on the backend after the user executes their desired command. This means all the "success or failure" print statements in those respective procedures like OST_CREATE_RECORD OR OST_SET_RECORD would be shown to the user through the UI. This is undesirable so perhaps theres a global flag that can be created to determine whether or not a command thats being executed is a "user entered" command or an "OstrichDB backend command specifically used to create or store history records"

Make it an option via the config file to turn this on or off...ya know for safety

created cluster

Now appending history records to cluster each time a command is entered. Last thing to do would be to now read from the cluster when the user enters the HISROY command


Fix #830: produce no log on the help message

Closes #830.

[ ] ~Tests added for any new code~
[x] Ran make fmt-fix (or had formatting run automatically on all files edited)
[ ] ~Documentation added for any new functionality~
[x] Entry added to UNRELEASED.md for any new functionality

I accidentally forked it off #852, so it should be merge after #852. Both these PRs are small. This should not be a problem.


IRGen: Weak-link references to swift_getExtendedExistentialTypeMetadata() [5.9]

main PR: https://github.com/apple/swift/pull/69459/

Description: The type checker guards certain dynamic uses of constrained existential types SE-0353 behind an availability check, because the runtime entry point to instantiate extended existential metadata is only available on newer OSes. However, even if the metadata instantiation was dynamically unreachable at runtime, we forgot to weak link the symbol. This caused missing symbol errors at runtime.

Scope of the issue: Affects framework authors attempting backward deployment of conditionally-available code that requires extended existential metadata.

Origination: This scenario never worked.

Risk: Very low as this just changes the linkage of a symbol when the deployment target is sufficiently old.

Tested: New test case added.

Reviewed by: @tshortli on main

Radar: rdar://117530421.

@swift-ci Please test

@swift-ci Please test


Suddenly getting this error on loginpass.

Traceback (most recent call last):
web_1       |   File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 2463, in __call__
web_1       |     return self.wsgi_app(environ, start_response)
web_1       |   File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 2449, in wsgi_app
web_1       |     response = self.handle_exception(e)
web_1       |   File "/usr/local/lib/python3.6/site-packages/flask_cors/extension.py", line 161, in wrapped_function
web_1       |     return cors_after_request(app.make_response(f(*args, **kwargs)))
web_1       |   File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1866, in handle_exception
web_1       |     reraise(exc_type, exc_value, tb)
web_1       |   File "/usr/local/lib/python3.6/site-packages/flask/_compat.py", line 39, in reraise
web_1       |     raise value
web_1       |   File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 2446, in wsgi_app
web_1       |     response = self.full_dispatch_request()
web_1       |   File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1951, in full_dispatch_request
web_1       |     rv = self.handle_user_exception(e)
web_1       |   File "/usr/local/lib/python3.6/site-packages/flask_cors/extension.py", line 161, in wrapped_function
web_1       |     return cors_after_request(app.make_response(f(*args, **kwargs)))
web_1       |   File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1820, in handle_user_exception
web_1       |     reraise(exc_type, exc_value, tb)
web_1       |   File "/usr/local/lib/python3.6/site-packages/flask/_compat.py", line 39, in reraise
web_1       |     raise value
web_1       |   File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1949, in full_dispatch_request
web_1       |     rv = self.dispatch_request()
web_1       |   File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1935, in dispatch_request
web_1       |     return self.view_functions[rule.endpoint](**req.view_args)
web_1       |   File "/usr/local/lib/python3.6/site-packages/loginpass/_flask.py", line 47, in auth
web_1       |     token = remote.authorize_access_token()
web_1       |   File "/usr/local/lib/python3.6/site-packages/authlib/flask/client/oauth.py", line 261, in authorize_access_token
web_1       |     token = self.fetch_access_token(redirect_uri, request_token, **params)
web_1       |   File "/usr/local/lib/python3.6/site-packages/authlib/client/oauth_client.py", line 174, in fetch_access_token
web_1       |     token = session.fetch_access_token(token_endpoint, **kwargs)
web_1       |   File "/usr/local/lib/python3.6/site-packages/authlib/client/oauth2_session.py", line 97, in fetch_access_token
web_1       |     return self.fetch_token(url, **kwargs)
web_1       |   File "/usr/local/lib/python3.6/site-packages/authlib/oauth2/client.py", line 167, in fetch_token
web_1       |     headers=headers, **session_kwargs
web_1       |   File "/usr/local/lib/python3.6/site-packages/authlib/oauth2/client.py", line 184, in _fetch_token
web_1       |     return self.parse_response_token(resp.json())
web_1       |   File "/usr/local/lib/python3.6/site-packages/authlib/oauth2/client.py", line 305, in parse_response_token
web_1       |     self.handle_error(error, description)
web_1       |   File "/usr/local/lib/python3.6/site-packages/authlib/client/oauth2_session.py", line 109, in handle_error
web_1       |     raise OAuthError(error_type, error_description)
web_1       | authlib.common.errors.AuthlibBaseError: invalid_request: Missing parameter: redirect_uri

So as I said everything was working and suddenly now I get this error, I am honestly not sure what could be wrong.

Hi, I can confirm an identical error on a starlette's client setup:
config = Config(".env")  # pylint: disable=invalid-name
oauth = OAuth(config)

CONF_URL = 'https://accounts.google.com/.well-known/openid-configuration'
oauth.register(
    name='google',
    server_metadata_url=CONF_URL,
    client_kwargs={
        'scope': 'openid email profile'
    }
)

async def login(request):
    redirect_uri = request.url_for('auth')
    return await oauth.google.authorize_redirect(request, redirect_uri)

async def auth(request):
    logging.critical(request.headers)
    token = await oauth.google.authorize_access_token(request)
    user = await oauth.google.parse_id_token(request, token)
    request.session['user'] = dict(user)
    return RedirectResponse(url='/')

when /auth endpoint is hit, I get this traceback (first line is mine):
[osso] CRITICAL: Headers({'host': '[REDACTED]', 'x-request-id': '299db1f2a6d8f187459083ed590d4adb', 'x-real-ip': '<IP_ADDRESS>', 'x-forwarded-for': '<IP_ADDRESS>', 'x-forwarded-host': '[REDACTED]', 'x-forwarded-port': '443', 'x-forwarded-proto': 'https', 'x-scheme': 'https', 'user-agent': '[REDACTED]', 'accept': 'text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8', 'accept-language': 'en-US,en;q=0.5', 'accept-encoding': 'gzip, deflate, br', 'referer': 'https://accounts.google.com/', 'dnt': '1', 'upgrade-insecure-requests': '1'})
[osso] INFO:     <IP_ADDRESS>:0 - "GET /auth?state=VNyCSjjCXSojWBTqNjsm3XlxBSJEgg&code=4%2FwwEnVamW5jzr4hOz4agsa1kjrKBlCOrMJTdO0pbFM9nq9qDbJ7-riJQ4Sh9TeokDyvz47FnRtY4DQsMMNH3N_II&scope=email+profile+openid+https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fuserinfo.email+https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fuserinfo.profile&authuser=0&prompt=consent HTTP/1.1" 500 Internal Server Error
[osso] ERROR:    Exception in ASGI application
[osso] Traceback (most recent call last):
[osso]   File "/usr/local/lib/python3.7/site-packages/uvicorn/protocols/http/httptools_impl.py", line 385, in run_asgi
[osso]     result = await app(self.scope, self.receive, self.send)
[osso]   File "/usr/local/lib/python3.7/site-packages/uvicorn/middleware/proxy_headers.py", line 45, in __call__
[osso]     return await self.app(scope, receive, send)
[osso]   File "/usr/local/lib/python3.7/site-packages/starlette/applications.py", line 102, in __call__
[osso]     await self.middleware_stack(scope, receive, send)
[osso]   File "/usr/local/lib/python3.7/site-packages/starlette/middleware/errors.py", line 181, in __call__
[osso]     raise exc from None
[osso]   File "/usr/local/lib/python3.7/site-packages/starlette/middleware/errors.py", line 159, in __call__
[osso]     await self.app(scope, receive, _send)
[osso]   File "/usr/local/lib/python3.7/site-packages/starlette_authlib/middleware.py", line 122, in __call__
[osso]     await self.app(scope, receive, send_wrapper)
[osso]   File "/usr/local/lib/python3.7/site-packages/starlette/exceptions.py", line 82, in __call__
[osso]     raise exc from None
[osso]   File "/usr/local/lib/python3.7/site-packages/starlette/exceptions.py", line 71, in __call__
[osso]     await self.app(scope, receive, sender)
[osso]   File "/usr/local/lib/python3.7/site-packages/starlette/routing.py", line 550, in __call__
[osso]     await route.handle(scope, receive, send)
[osso]   File "/usr/local/lib/python3.7/site-packages/starlette/routing.py", line 227, in handle
[osso]     await self.app(scope, receive, send)
[osso]   File "/usr/local/lib/python3.7/site-packages/starlette/routing.py", line 41, in app
[osso]     response = await func(request)
[osso]   File "./osso/app.py", line 79, in auth
[osso]     token = await oauth.google.authorize_access_token(request)
[osso]   File "/usr/local/lib/python3.7/site-packages/authlib/integrations/starlette_client/integration.py", line 58, in authorize_access_token
[osso]     return await self.fetch_access_token(**params)
[osso]   File "/usr/local/lib/python3.7/site-packages/authlib/integrations/base_client/async_app.py", line 105, in fetch_access_token
[osso]     token = await client.fetch_token(token_endpoint, **kwargs)
[osso]   File "/usr/local/lib/python3.7/site-packages/authlib/integrations/httpx_client/oauth2_client.py", line 120, in _fetch_token
[osso]     return self.parse_response_token(resp.json())
[osso]   File "/usr/local/lib/python3.7/site-packages/authlib/oauth2/client.py", line 348, in parse_response_token
[osso]     self.handle_error(error, description)
[osso]   File "/usr/local/lib/python3.7/site-packages/authlib/integrations/httpx_client/oauth2_client.py", line 76, in handle_error
[osso]     raise OAuthError(error_type, error_description)
[osso] authlib.common.errors.AuthlibBaseError: invalid_request: Missing parameter: redirect_uri

@sn10 FYI I've found that Missing parameter: redirect_uri is a response google give back to us, you can read more here https://github.com/lepture/authlib/issues/196 ... I'm trying to dig further on that issue did you had some luck in the meanwhile?
Ciao!

I've found I was setting a wrong session cookie max-age and that was the problem, maybe even yours? ciao

Usually this is caused by your wrong settings on secret_key.


Fix CancelImport request

Description
Currently, the Orchestrator job completes before the processing jobs are completed, it will incorrectly not allow cancel of an import because it thinks the job is done. This is incorrect as the Orchestrator is done but not the child Processing Jobs,.
This PR is fixing this issue, now we check all jobs to check the status of all jobs.
Related issues
Addresses issue #124093
Testing
Added a test to make sure it first returns Accepted status to cancel request, which means the import job has been cancelled, and then make sure we received Conflict status if we have already cancelled the job.
The existing test was making sure that the cancel operation works if all jobs have already completed (with just one patient) it was happening.
FHIR Team Checklist

Update the title of the PR to be succinct and less than 65 characters
Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
[ ] CI is green before merge
Review squash-merge requirements

Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)

I don't think jobs == null condition needs to be checked.

I think it would be easier to use Linq instead of foreach.

/azp run

/azp run


Mismatch between description and code sample - Step 30

https://github.com/SAP-samples/ui5-typescript-walkthrough/blob/834427084f26f51674fd2153d047380d9eaf0b66/steps/30/README.md?plain=1#L226
To access the router instance for our app we first need to cast this.getOwnerComponent()to our component, then we can call the helper method getRouter().
The code sample:
const router = UIComponent.getRouterFor(this);

https://github.com/SAP-samples/ui5-typescript-walkthrough/blob/834427084f26f51674fd2153d047380d9eaf0b66/steps/30/README.md?plain=1#L242
https://github.com/SAP-samples/ui5-typescript-walkthrough/blob/834427084f26f51674fd2153d047380d9eaf0b66/steps/31/README.md?plain=1#L103
The public property formatter was never defined in the previous steps. This must be some remains of previous versions of this tutorial.

@flovogt could you take care of the first issue reported here: Description in step 30 does not match the code sample. Seems that this results from Adds Import of UIComponent for Routing.


Switch to upkie::cpp namespace in C++

@ubgk for your information. The rationale for this is roughly:

Pro:

Documentation is better organized (avoids mixing C++ alongside Python)
Namespaces, includes and file paths all match

Con:

Longer namespace strings

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.568%

Totals

Change from base Build<PHONE_NUMBER>3:
0.0%

Covered Lines:
2507

Relevant Lines:
2799

💛  - Coveralls


give @ornicar write access to the repository

I think given his contributions to the library it is reasonable to give @ornicar a write access to the repository. What do you think @jwage?

Given his fancy for Scala, I don't think @ornicar is interested in merging Doctrine PR's anymore. Feel free to re-open if you have a change of heart :)


Error installing pytorch

I am using jetson nano jetpack 4.6.2 ubuntu 22.04 with the default python 3.6.9. After running cmake ../ and selecting to install pytorch for python 3.6, I was able to successfully import torch but when I try to import torchvision I get an error.
python3
Python 3.6.9 (default, Jun 29 2022, 11:45:57)
[GCC 8.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

import torchvision
Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python3.6/dist-packages/torchvision-0.7.0a0+78ed10c-py3.6-linux-aarch64.egg/torchvision/init.py", line 6, in
from torchvision import datasets
File "/usr/local/lib/python3.6/dist-packages/torchvision-0.7.0a0+78ed10c-py3.6-linux-aarch64.egg/torchvision/datasets/init.py", line 1, in
from .lsun import LSUN, LSUNClass
File "/usr/local/lib/python3.6/dist-packages/torchvision-0.7.0a0+78ed10c-py3.6-linux-aarch64.egg/torchvision/datasets/lsun.py", line 2, in
from PIL import Image
File "", line 971, in _find_and_load
File "", line 955, in _find_and_load_unlocked
File "", line 656, in _load_unlocked
File "", line 626, in _load_backward_compatible
File "/usr/local/lib/python3.6/dist-packages/Pillow-9.2.0-py3.6-linux-aarch64.egg/PIL/Image.py", line 52, in
File "", line 971, in _find_and_load
File "", line 951, in _find_and_load_unlocked
File "", line 894, in _find_spec
File "", line 1157, in find_spec
File "", line 1131, in _get_spec
File "", line 1112, in _legacy_get_spec
File "", line 441, in spec_from_loader
File "", line 544, in spec_from_file_location
File "/usr/local/lib/python3.6/dist-packages/Pillow-9.2.0-py3.6-linux-aarch64.egg/PIL/_deprecate.py", line 1
SyntaxError: future feature annotations is not defined

How do I fix this please?

Hi @changherng, try running pip3 install 'pillow<7'
I can make no guarantees as Ubuntu 22.04 on Nano isn't official JetPack

Hello @dusty-nv ,
I tried it and it works now, thank you very much!


Update README.md

Thank you!
Merged in https://github.com/delight-im/Android-AdvancedWebView/commit/51d1850d119bd73d10b0eda52813b99e3c56cf59 and https://github.com/delight-im/Android-AdvancedWebView/commit/68aa3ca352988c12baeeb0f9bf304576c087690c.


Simulate Eviction API cameCase fix for Spot Virtual Machines and VMSc…

SDK for new API SimulateEviction for Spot Virtual Machines and VMScaleSet VMs.
Updated test results in TestVMOperations_SimulateEviction.json as there was a small change in the exisiting route of the SimulateEviction API from 'SimulateEviction' to 'SimulateEviction'.
Added the major version change as the swagger change for this SDK change had the label potential-sdk-breaking-change by @yungezz

/azp run net - mgmt - ci

ADO didn't report status to Github again.
net - mgmt job: https://dev.azure.com/azure-sdk/public/_build/results?buildId=369126&view=results


Dataspace Authority Self-Description Document

Description
The dataspace authority shall provide a GAIA-X compliant self-description that participants can use for enrollment, i.e. retrieve the endpoint of the registration service for enrollment (see Registration Service Specification).
At this point only a sample self-description needs to be provided with the attributes known at the point of implementation. Enrollment endpoint will be added in subsequent features/stories.
Acceptance Criteria

[ ] A public self-description document is available for the Dataspace Authority (Registration Service)
[ ] The dataspace self-description contains the policies to join the DS (expressed on ODRL, specific protocol to be defined)

Stories

[ ] #19

This feature has been replaced by #36


Updating data model

Updating data model: separating request and response objects, and simplifying both.

PR is reviewed. All changes that have been implemented have been resolved; anything outstanding is remaining (a few comments). Mostly, there are a few things that I have already fixed downstream in the JOOQ branch, so I didn't touch them in this branch. Thanks for the feedback.


Fix unqualified push

Local image with unqualified name had to be fully qualified before a push to default registry.
Moved check for official repository to daemon side because client doesn't know which registry is the default.
Resolves bz#1217987

By the way confirm push to public registry is again in fedora-1.6 branch. Will it stay?
If yes, we should patch it to check user's response in case insensitive way.

I just fixed it.

Somehow I can't see the fix being merged (just on this branch). Can you please re-check?


Added A Few Search, Sort and Traversal Algorithms

Implemented All Types OF Search Sort and Traversal In My Knowledge

Can Anyone Tell What Kind of Checks Have Failed??
Whats the error in the File?

@Luke-Polson @martyanov  What's wrong in my code??

There seem to be many syntax errors introduced with this PR. The files are inconsistent with style and formatting and lack tests. Closing PR.


selecting RegexGroups while 'include' filter is active disables the filter-selection

selecting RegexGroups while 'include' filter is active disables the filter-selection, but does not change the filter to 'token'

Fixed in commit 5f17268f91f686391a334f4a5cd7550bd18db587


Invalid DatalistUrl for longer pages

Hi , while i use different pages to get the datalist , for normal pages with no parameter it works fine
http://localhost:23588/acPlayGroundSchedule/Create
it work like charm

while for the URL
http://localhost:23588/acPlayGroundSchedule/Create/2000
it do not work , and when i inspect the send URL i found it as below
http://localhost:23588/acPlayGroundSchedule/create/AllacTrainers?search=&sort=Name&order=Asc&rows=5&page=0&_=1493066992185
while it should have been as below
http://localhost:23588/acPlayGroundSchedule/AllacTrainers?search=&sort=Name&order=Asc&rows=5&page=0&_=1493066992185
with exact Error below :
GET http://localhost:23588/acPlayGroundSchedule/create/AllacTrainers?search=&sort=Name&order=Asc&rows=5&page=0&_=1493066992185 500 (Internal Server Error)

it seems that the URL only excluded last part of the original URL and then added its data-url
When i changed the URL to be as below it worked again fine
http://localhost:23588/acPlayGroundSchedule/Create?ID=2333
although the first one is the common for MVC
any solution for that ???

Datalist works through ajax, so if you set datalist url to AllacTrainers it will use an ajax call with that url.
By default, ajax tries to make a relative url with AllacTrainers, unless you use /AllacTrainers, meaning start url from the page root.
My recommendation is to always use full url, so that ajax doesn't try to use it as a relative path to action.

again , perfect , thanks for the amazing control , it saved em thousands of hours , thanks


Strafe cancels when executing script but only on one character

I have a strange issue that just started today. While attacking/executing the GS script I use for grinding, it will cancel strafing (basically makes it seem like you let up off of right click.)  I've cleared my WTF and WDB/ADB folders but the issue remained. I tested on my hunter and it doesn't seem to happen there. Anyone know why this might be happening? I've changed the scripts and the issue remains. Even making a very simple single action script triggers the issue. Using a standard macro also works fine.

Disregard this. I found it was actually because I had a trinket that wanted a target,. I didn't know I had to disable that.


build: Update to header 1.3.275

Update known-good
Generate source

CI Vulkan-Tools build queued with queue ID 111700.

CI Vulkan-Tools build # 1349 running.

CI Vulkan-Tools build # 1349 passed.


chore: bdd-nh-1590505248 to 0.0.1

chore: Promote bdd-nh-1590505248 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


KVC.Landscape plugin stopped working

Can you please provide answers to the following questions so I can understand better what is happening:

Why are you reporting this here, and not to KCV.Landscape's developer;
Do I look like KCV.Landscape's developer;
Why should I look into this, considering said KCV.Landscape has not been updated since January, and is probably broken due to KCV's model set changes and API changes?

Many thanks in advance.

Regarding this plug-in, people report it working fine with <IP_ADDRESS>, so it's your local issue I guess…


St3fan st3fan/snapshot derived data

Includes both #3684 and #3633 and some improvements to clearing.

I agree to approve this.


Razor syntax error in template?

I have dotnet version2.1.300-preview2-008533,
When I create a template for blazor, my counters button is
<button onclick="IncrementCounter"
Why is it in every other template I see such as on scotts april 3rd podcast, the function is called like the following
<button @onclick(IncrementCounter) >
I get an error stating onclick cannot be found but this seems to be typical razor syntax?

@OnClick(IncrementCounter) is old syntax.
As the current templates show when you create a new project in VS, you should use
onclick=@IncrementCounter or onclick="@IncrementCounter"

Thanks. Ive been chasing my tail for like an hour..


⚠ Bofrost.be has degraded performance

In 2cf82f7, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1111 ms

Resolved: Bofrost.be performance has improved in 666dbf8.


On Contact Us page:

Font family should be changed to brand fonts
DONE: Change email link on contact page to a "mailto:" link ??

turned into a link but we have no email so placed hashtag instead.
DONE: Background should take up the entire background in mobile view

What fonts should be changed? These are the settings for the contact page
p {
font-size: 50px;
font-style: 'Ubuntu', sans-serif;
}
h1, h2, h3 {
font-style: 'Cabin', sans-serif;
}

Done


Feature request: map with borg chargers for borgs

That would be pretty powerful, and overlap with the GPS module. Charger pinpointer maybe?

sounds nice


[librsvg] Add pkgconfig file

Fixes https://github.com/microsoft/vcpkg/issues/31876

[x] Changes comply with the maintainer guide
[ ] SHA512s are updated for each updated download
[ ] The "supports" clause reflects platforms that may be fixed by this new version
[ ] Any fixed CI baseline entries are removed from that file.
[ ] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Below usage test passed with x64-windows triplet:
find_package(PkgConfig REQUIRED)
pkg_check_modules(librsvg REQUIRED IMPORTED_TARGET librsvg)
target_link_libraries(main PkgConfig::librsvg)

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

Why not use upstream's https://gitlab.gnome.org/GNOME/librsvg/-/blob/2.40.20/librsvg.pc.in directly?

The variables in the upstream librsvg.pc.in file cannot be recognized.

Even if the port uses a vendored build system, shouldn't it keep upstream's chosen names for binaries?
https://learn.microsoft.com/en-us/vcpkg/contributing/maintainer-guide#do-not-rename-binaries-outside-the-names-given-by-upstream

The variables in the upstream librsvg.pc.in file cannot be recognized.

Normally this is resolved by just setting them...

shouldn't it keep upstream's chosen names for binaries? https://learn.microsoft.com/en-us/vcpkg/contributing/maintainer-guide#do-not-rename-binaries-outside-the-names-given-by-upstream

I agree with @dg0yt here, why is renaming the targets necessary?

why is renaming the targets necessary?

According to the contents of the https://gitlab.gnome.org/GNOME/librsvg/-/blob/main/librsvg.pc.in
Libs: -L${libdir} -lrsvg-@RSVG_API_MAJOR_VERSION@ -lm

I see, this is our external build system, not a patch. OK

librsvg contains now Libs: "-L${libdir}" -lrsvg-2 -lm on Windows, which must not happen in any pc file on Windows. Maybe this should be added in vcpkg_fixup_pkgconfig() which will fix it for every pc file.

Maybe -lm should be removed via vcpkg_fixup_pkgconfig() which will fix it for every pc file.

We talked about this today and are a bit to nervous to open versioning cans of worms trying to touch an existing thing that would affect port versions that already exist. And that doesn't mean there will never be a library named m.lib someone might want to use on Windows. In cases where we know this was the intent, one could imagine patching upstream to fix it or using tools like vcpkg_replace_string to deal with it, though the latter might be dangerous hammer with short strings like " -lm" since those can be in directory names or similar too.


Update test.yml

Description by Korbit AI
What change is being made?
Add Python 3.13 to the testing matrix in the GitHub Actions workflow test.yml.
Why are these changes being made?
These changes are made to ensure future compatibility and stability by testing the software against the latest Python version, Python 3.13, while maintaining an exclusion for windows-latest to prevent potential compatibility issues with this version on Windows.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.333%

Totals

Change from base Build<PHONE_NUMBER>8:
0.0%

Covered Lines:
14

Relevant Lines:
15

💛  - Coveralls


Revert "docs: refactor (WIP)"

Reverts aidenybai/million#840

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 25.706%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1257

Relevant Lines:
5082

💛  - Coveralls


Remove unnecessary CHARSET=utf8 COLLATE=utf8_general_ci

from create_table method
Closes #833
These options are unnecessary as Rails AbstractMysqlAdapter does not specify them.
https://github.com/rails/rails/blob/5-1-stable/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb#L362-L364
      def create_table(table_name, **options) #:nodoc:
        super(table_name, options: "ENGINE=InnoDB", **options)
      end

@yahonda I was confused why I could not get 5.0.x tests to pass and wish I knew why I had to add this.  Are you saying 5.1.x works and 5.0.x does not?  I did not try on 5.1.x since adding that "hack".

I did not try Rails 5-0-stable branch yet. Let me test and will update the result.

I have tested with these versions and I do not see regressions due to backporting #850 changes into 50-stable branch.
Tested versions:

Rails 5.0.6
ActiveRecord JDBC adapter 50-stable with properties['trustServerCertificate'] = true to workaround #845

There are no differences ActiveRecord JDBC driver testing rake test_mysql.
Somehow 1 error addressed at 50-stablewith properties['trustServerCertificate'] = true to workaround #845 + backport #850 to50-stable`
but this looks not related with character set, it depends on some test order
50-stable` with properties['trustServerCertificate'] = true to workaround #845
$ rake test_mysql

189 tests, 440 assertions, 0 failures, 0 errors, 2 pendings, 6 omissions, 0 notifications
98.9071% passed

$ bundle exec rake test_jdbcmysql

4832 runs, 13492 assertions, 3 failures, 9 errors, 5 skips

50-stablewith properties['trustServerCertificate'] = true to workaround #845 + backport #850 to50-stable`
$ rake test_mysql

189 tests, 440 assertions, 0 failures, 0 errors, 2 pendings, 6 omissions, 0 notifications
98.9071% passed

$ bundle exec rake test_jdbcmysql

4832 runs, 13494 assertions, 3 failures, 8 errors, 5 skips

1 error addressed at 50-stablewith properties['trustServerCertificate'] = true to workaround #845 + backport #850 to50-stable`, which is not related with this change. Likely due to some test order differences but not sure.

Error:
ActiveRecord::DatabaseTasksUtilsTask#test_raises_an_error_when_called_with_protected_environment:
ActiveRecord::EnvironmentMismatchError: You are attempting to modify a database that was last run in `foofoo` environment.
You are running in `default_env` environment. If you are sure you want to continue, first set the environment using:

        bin/rails db:environment:set

    /home/yahonda/git/rails/activerecord/lib/active_record/tasks/database_tasks.rb:55:in `check_protected_environments!'
    /home/yahonda/git/rails/activerecord/test/cases/tasks/database_tasks_test.rb:35:in `test_raises_an_error_when_called_with_protected_environment'

bin/rails test home/yahonda/git/rails/activerecord/test/cases/tasks/database_tasks_test.rb:28

@yahonda I discovered this by running rake rails:test:mysql and not test_mysql.  I will be moving back to arjdbc this afternoon so I will also try.

I have tested rake rails:test_mysql this pull request with activerecord-jdbc-adapter 50-stable branch.
I have confirmed
Branches tested

50-stable
pr850_50-stable - 50-stable branch and backport #850 https://github.com/yahonda/activerecord-jdbc-adapter/commit/f7f5360bb64d4dca466975aaea50782c45e80d35

rake rails:test_mysql results

50-stable - 4961 runs, 13763 assertions, 7 failures, 4 errors, 5 skips
pr850_50-stable - 4961 runs, 13765 assertions, 5 failures, 4 errors, 5 skips

Two failures fixed by pr850_50-stable as expected. I do not see regressions at pr850_50-stable branch
  5) Failure:
Mysql2ActiveSchemaTest#test_index_in_create [/home/yahonda/git/rails/activerecord/test/cases/adapters/mysql2/active_schema_test.rb:73]:
--- expected
+++ actual
@@ -1 +1 @@
-"CREATE TABLE `people` (SPATIAL INDEX `index_people_on_last_name`  (`last_name`)) ENGINE=InnoDB"
+"CREATE TABLE `people` (SPATIAL INDEX `index_people_on_last_name`  (`last_name`)) ENGINE=InnoDB CHARSET=utf8 COLLATE=utf8_general_ci"

  6) Failure:
Mysql2ActiveSchemaTest#test_indexes_in_create [/home/yahonda/git/rails/activerecord/test/cases/adapters/mysql2/active_schema_test.rb:166]:
--- expected
+++ actual
@@ -1 +1 @@
-"CREATE TEMPORARY TABLE `temp` ( INDEX `index_temp_on_zip`  (`zip`)) ENGINE=InnoDB AS SELECT id, name, zip FROM a_really_complicated_query"
+"CREATE TEMPORARY TABLE `temp` ( INDEX `index_temp_on_zip`  (`zip`)) ENGINE=InnoDB CHARSET=utf8 COLLATE=utf8_general_ci AS SELECT id, name, zip FROM a_really_complicated_query"

Here are details:

* 50-stable
$ rake rails:test_mysql
... snip ...

Finished in 342.704305s, 14.4760 runs/s, 40.1600 assertions/s.

  1) Failure:
AttributeMethodsTest#test_read_attributes_before_type_cast_on_boolean [/home/yahonda/git/rails/activerecord/test/cases/attribute_methods_test.rb:202]:
Expected: "0"
  Actual: 0

  2) Failure:
TransactionIsolationUnsupportedTest#test_setting_the_isolation_level_raises_an_error [/home/yahonda/git/rails/activerecord/test/cases/transaction_isolation_test.rb:11]:
ActiveRecord::TransactionIsolationError expected but nothing was raised.

  3) Error:
RelationTest#test_to_xml:
LoadError: no such file to load -- builder
    org/jruby/RubyKernel.java:955:in `require'
    /home/yahonda/git/rails/activesupport/lib/active_support/dependencies.rb:293:in `block in require'
    /home/yahonda/git/rails/activesupport/lib/active_support/dependencies.rb:259:in `load_dependency'
    /home/yahonda/git/rails/activesupport/lib/active_support/dependencies.rb:293:in `require'
    /home/yahonda/git/rails/activesupport/lib/active_support/builder.rb:2:in `<main>'
    org/jruby/RubyKernel.java:955:in `require'
    /home/yahonda/git/rails/activesupport/lib/active_support/dependencies.rb:293:in `block in require'
    /home/yahonda/git/rails/activesupport/lib/active_support/dependencies.rb:259:in `load_dependency'
    /home/yahonda/git/rails/activesupport/lib/active_support/dependencies.rb:293:in `require'
    /home/yahonda/git/rails/activesupport/lib/active_support/core_ext/array/conversions.rb:1:in `(root)'
    /home/yahonda/git/rails/activesupport/lib/active_support/core_ext/array/conversions.rb:182:in `to_xml'
    /home/yahonda/git/rails/activerecord/lib/active_record/relation/delegation.rb:38:in `block in to_xml'
    /home/yahonda/git/rails/activesupport/lib/active_support/test_case.rb:83:in `assert_nothing_raised'
    /home/yahonda/git/rails/activerecord/test/cases/relations_test.rb:83:in `test_to_xml'

  4) Failure:
HasManyAssociationsTest#test_do_not_call_callbacks_for_delete_all [/home/yahonda/git/rails/activerecord/test/cases/associations/has_many_associations_test.rb:259]:
bulbs should have been deleted using :delete_all strategy.
Expected: 0
  Actual: 1

  5) Failure:
Mysql2ActiveSchemaTest#test_index_in_create [/home/yahonda/git/rails/activerecord/test/cases/adapters/mysql2/active_schema_test.rb:73]:
--- expected
+++ actual
@@ -1 +1 @@
-"CREATE TABLE `people` (SPATIAL INDEX `index_people_on_last_name`  (`last_name`)) ENGINE=InnoDB"
+"CREATE TABLE `people` (SPATIAL INDEX `index_people_on_last_name`  (`last_name`)) ENGINE=InnoDB CHARSET=utf8 COLLATE=utf8_general_ci"

  6) Failure:
Mysql2ActiveSchemaTest#test_indexes_in_create [/home/yahonda/git/rails/activerecord/test/cases/adapters/mysql2/active_schema_test.rb:166]:
--- expected
+++ actual
@@ -1 +1 @@
-"CREATE TEMPORARY TABLE `temp` ( INDEX `index_temp_on_zip`  (`zip`)) ENGINE=InnoDB AS SELECT id, name, zip FROM a_really_complicated_query"
+"CREATE TEMPORARY TABLE `temp` ( INDEX `index_temp_on_zip`  (`zip`)) ENGINE=InnoDB CHARSET=utf8 COLLATE=utf8_general_ci AS SELECT id, name, zip FROM a_really_complicated_query"

  7) Failure:
Mysql2ConnectionTest#test_mysql_connection_collation_is_configured [/home/yahonda/git/rails/activerecord/test/cases/adapters/mysql2/connection_test.rb:104]:
Expected: "utf8_unicode_ci"
  Actual: "utf8_general_ci"

  8) Failure:
Mysql2ConnectionTest#test_bad_connection [/home/yahonda/git/rails/activerecord/test/cases/adapters/mysql2/connection_test.rb:22]:
[ActiveRecord::NoDatabaseError] exception expected, not
Class: <ActiveRecord::JDBCError>
Message: <"com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Unknown database 'inexistent_activerecord_unittest'">
---Backtrace---
arjdbc/jdbc/RubyJdbcConnection.java:424:in `init_connection'
/home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/jdbc/connection.rb:15:in `initialize'
/home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/abstract/core.rb:13:in `initialize'
/home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/abstract/statement_cache.rb:21:in `initialize'
/home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/mysql/adapter.rb:34:in `initialize'
/home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/jdbc/connection_methods.rb:15:in `jdbc_connection'
/home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/mysql/connection_methods.rb:76:in `mysql_connection'
/home/yahonda/git/rails/activerecord/test/cases/adapters/mysql2/connection_test.rb:24:in `block in test_bad_connection'
---------------

  9) Error:
Mysql2StoredProcedureTest#test_multi_results:
NoMethodError: undefined method `rows' for []:Array
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:69:in `select_rows'
    /home/yahonda/git/rails/activerecord/test/cases/adapters/mysql2/sp_test.rb:20:in `test_multi_results'

 10) Error:
Mysql2StoredProcedureTest#test_multi_results_from_find_by_sql:
NoMethodError: undefined method `column_types' for []:Array
    /home/yahonda/git/rails/activerecord/lib/active_record/querying.rb:40:in `find_by_sql'
    /home/yahonda/git/rails/activerecord/test/cases/adapters/mysql2/sp_test.rb:32:in `test_multi_results_from_find_by_sql'

 11) Error:
Mysql2StoredProcedureTest#test_multi_results_from_select_one:
NoMethodError: undefined method `[]' for nil:NilClass
    /home/yahonda/git/rails/activerecord/test/cases/adapters/mysql2/sp_test.rb:27:in `test_multi_results_from_select_one'

4961 runs, 13763 assertions, 7 failures, 4 errors, 5 skips

You have skipped tests. Run with --verbose for details.
rake aborted!
Command failed with status (1)
/home/yahonda/git/activerecord-jdbc-adapter/rakelib/rails.rake:56:in `block in (root)'
/home/yahonda/git/activerecord-jdbc-adapter/rakelib/rails.rake:78:in `env_sh'
/home/yahonda/git/activerecord-jdbc-adapter/rakelib/rails.rake:52:in `block in (root)'
Tasks: TOP => rails:test_mysql
(See full trace by running task with --trace)
$

pr850_50-stable

$ rake rails:test_mysql
... snip ...

Finished in 329.704036s, 15.0468 runs/s, 41.7496 assertions/s.

  1) Failure:
AttributeMethodsTest#test_read_attributes_before_type_cast_on_boolean [/home/yahonda/git/rails/activerecord/test/cases/attribute_methods_test.rb:202]:
Expected: "0"
  Actual: 0

  2) Failure:
TransactionIsolationUnsupportedTest#test_setting_the_isolation_level_raises_an_error [/home/yahonda/git/rails/activerecord/test/cases/transaction_isolation_test.rb:11]:
ActiveRecord::TransactionIsolationError expected but nothing was raised.

  3) Error:
RelationTest#test_to_xml:
LoadError: no such file to load -- builder
    org/jruby/RubyKernel.java:955:in `require'
    /home/yahonda/git/rails/activesupport/lib/active_support/dependencies.rb:293:in `block in require'
    /home/yahonda/git/rails/activesupport/lib/active_support/dependencies.rb:259:in `load_dependency'
    /home/yahonda/git/rails/activesupport/lib/active_support/dependencies.rb:293:in `require'
    /home/yahonda/git/rails/activesupport/lib/active_support/builder.rb:2:in `<main>'
    org/jruby/RubyKernel.java:955:in `require'
    /home/yahonda/git/rails/activesupport/lib/active_support/dependencies.rb:293:in `block in require'
    /home/yahonda/git/rails/activesupport/lib/active_support/dependencies.rb:259:in `load_dependency'
    /home/yahonda/git/rails/activesupport/lib/active_support/dependencies.rb:293:in `require'
    /home/yahonda/git/rails/activesupport/lib/active_support/core_ext/array/conversions.rb:1:in `(root)'
    /home/yahonda/git/rails/activesupport/lib/active_support/core_ext/array/conversions.rb:182:in `to_xml'
    /home/yahonda/git/rails/activerecord/lib/active_record/relation/delegation.rb:38:in `block in to_xml'
    /home/yahonda/git/rails/activesupport/lib/active_support/test_case.rb:83:in `assert_nothing_raised'
    /home/yahonda/git/rails/activerecord/test/cases/relations_test.rb:83:in `test_to_xml'

  4) Failure:
HasManyAssociationsTest#test_do_not_call_callbacks_for_delete_all [/home/yahonda/git/rails/activerecord/test/cases/associations/has_many_associations_test.rb:259]:
bulbs should have been deleted using :delete_all strategy.
Expected: 0
  Actual: 1

  5) Failure:
Mysql2ConnectionTest#test_mysql_connection_collation_is_configured [/home/yahonda/git/rails/activerecord/test/cases/adapters/mysql2/connection_test.rb:104]:
Expected: "utf8_unicode_ci"
  Actual: "utf8_general_ci"

  6) Failure:
Mysql2ConnectionTest#test_bad_connection [/home/yahonda/git/rails/activerecord/test/cases/adapters/mysql2/connection_test.rb:22]:
[ActiveRecord::NoDatabaseError] exception expected, not
Class: <ActiveRecord::JDBCError>
Message: <"com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Unknown database 'inexistent_activerecord_unittest'">
---Backtrace---
arjdbc/jdbc/RubyJdbcConnection.java:424:in `init_connection'
/home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/jdbc/connection.rb:15:in `initialize'
/home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/abstract/core.rb:13:in `initialize'
/home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/abstract/statement_cache.rb:21:in `initialize'
/home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/mysql/adapter.rb:34:in `initialize'
/home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/jdbc/connection_methods.rb:15:in `jdbc_connection'
/home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/mysql/connection_methods.rb:76:in `mysql_connection'
/home/yahonda/git/rails/activerecord/test/cases/adapters/mysql2/connection_test.rb:24:in `block in test_bad_connection'
---------------

  7) Error:
Mysql2StoredProcedureTest#test_multi_results:
NoMethodError: undefined method `rows' for []:Array
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:69:in `select_rows'
    /home/yahonda/git/rails/activerecord/test/cases/adapters/mysql2/sp_test.rb:20:in `test_multi_results'

  8) Error:
Mysql2StoredProcedureTest#test_multi_results_from_find_by_sql:
NoMethodError: undefined method `column_types' for []:Array
    /home/yahonda/git/rails/activerecord/lib/active_record/querying.rb:40:in `find_by_sql'
    /home/yahonda/git/rails/activerecord/test/cases/adapters/mysql2/sp_test.rb:32:in `test_multi_results_from_find_by_sql'

  9) Error:
Mysql2StoredProcedureTest#test_multi_results_from_select_one:
NoMethodError: undefined method `[]' for nil:NilClass
    /home/yahonda/git/rails/activerecord/test/cases/adapters/mysql2/sp_test.rb:27:in `test_multi_results_from_select_one'

4961 runs, 13765 assertions, 5 failures, 4 errors, 5 skips

You have skipped tests. Run with --verbose for details.
rake aborted!
Command failed with status (1)
/home/yahonda/git/activerecord-jdbc-adapter/rakelib/rails.rake:56:in `block in (root)'
/home/yahonda/git/activerecord-jdbc-adapter/rakelib/rails.rake:78:in `env_sh'
/home/yahonda/git/activerecord-jdbc-adapter/rakelib/rails.rake:52:in `block in (root)'
Tasks: TOP => rails:test_mysql
(See full trace by running task with --trace)
$

@yahonda sorry this took so long to merge

No problem. Thanks for merging.


Formating Error

When Formatting a document, it convert {{ count }} to {{ count; }}, which generate an error with vite/vue since it's not the good format

Duplicate of #417


[Input] Swype Dictionary not showing

Swype keyboard does not function correctly. Whenever i focus on textfield swype dictionary bar is not showing up, it doesn't type any letters ( note numbers are fine ) in field unless I press space or enter.
However if i switch to any app, for example google search, i open up my swype keyboard there then swap to the libgdx app I can get it show just one time, however input is still not reflected in textfield.
Phone: Samsung Galaxy S2

This is an absolutely unacceptable answer and completely invalidates libgdx as a serious game engine option.
@badlogic

You resurrect an 8 year old issue and tag me to inform me of your entitlement. Good job, @Emperorlou! I'm sure people love working with you.

This is an absolutely unacceptable answer and completely invalidates libgdx as a serious game engine option.

Says the guy who's using Mozilla Rhino 1.7.8 and Gradle 3.5.1 in production, but not libGDX 🤣 . No no, we really value your opinion, tell us more about how much you use Swype in 2021!

The decision to ignore this issue is why it still exists 8 years later, and
it is delegitimizing libgdx on the mobile platform. A lot of people have
invested a lot of time and effort into this engine and this attitude is
exactly why it can't be taken seriously. Why wouldn't you care enough about
libgdx to give it proper Android input support? Why close this issue when
someone else could have taken it on? I get that you might not have the time
to do it yourself, but by closing the issue you're shutting down a fix for
it. Even worse, you specifically say that it's not going to happen?
In fact people HAVE taken it on and if you do enough Google searching you
can see people have hacked a way through this problem before. The
leadership here is ignoring a glaring issue like this by simply saying "no"
to fixing it. So now every game that uses a keyboard has to be sub par, or
the game dev needs to fix a broken engine - without support from the
leadership of the engine. Of course I should be mad about this. At the very
least keeping the issue up allows the conversation to continue, and not
saying "this is not going to happen" - discouraging people from trying to
submit fixes themselves.
On Mon, Jun 21, 2021, 6:43 AM Mario Zechner @.***>
wrote:

You resurrect an 8 year old issue and tag me to inform me of your
entitlement. Good job, @Emperorlou https://github.com/Emperorlou! I'm
sure people love working with you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/libgdx/libgdx/issues/783#issuecomment-865043806, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACM6HDJ4KX2N5RKH2NEUHTTT46W7ANCNFSM4AINDQKA
.

My LibGDX project isn't on Github.
And not just Swype that's important, but EVERY modern keyboard feature.
On Mon, Jun 21, 2021 at 2:34 PM Tommy Ettinger @.***>
wrote:

This is an absolutely unacceptable answer and completely invalidates
libgdx as a serious game engine option.
Says the guy who's using Mozilla Rhino 1.7.8 and Gradle 3.5.1 in
production, but not libGDX 🤣 . No no, we really value your opinion, tell
us more about how much you use Swype in 2021!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/libgdx/libgdx/issues/783#issuecomment-865360592, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACM6HHX5MW47FTX6PJWZX3TT6V7HANCNFSM4AINDQKA
.

By all means, submit a fix for this issue via a pull request. But you do
not get to dictate how things are run around here. Nor does anyone working
on this owe you a single thing.
As can be seen by you necromancing this issue after 8 years, it was easily
discoverable via a simple search for your specific problem. You could have
decided to ask for re-opening as you'd like to take on the issue since you
have an immediate need for a fix. You could have shown work arounds you
found that could be implemented and discuss the best approach to implement
the fix with maintainers before heading off and sending a PR.
 Because YOU have a booboo in your super important
project! Because YOUR issue is the most important issue in the world and it
is an afront that someone didn't anticipate YOUR need 8 years ago. How dare
those OSS maintainers!
You must not interact often with people, if you think they way you
introduced yourself here will yield a positive outcome.
 Your
entitlement and disrespect is inversely proportional to your contributions
to this community. And sadly, there are more people like you than people
who actually take their time to get to know and participate in the
community surrounding an OSS project.

On Tue, Jun 22, 2021, 00:20 Nikolas @.***> wrote:

The decision to ignore this issue is why it still exists 8 years later, and
it is delegitimizing libgdx on the mobile platform. A lot of people have
invested a lot of time and effort into this engine and this attitude is
exactly why it can't be taken seriously. Why wouldn't you care enough about
libgdx to give it proper Android input support? Why close this issue when
someone else could have taken it on? I get that you might not have the time
to do it yourself, but by closing the issue you're shutting down a fix for
it. Even worse, you specifically say that it's not going to happen?
In fact people HAVE taken it on and if you do enough Google searching you
can see people have hacked a way through this problem before. The
leadership here is ignoring a glaring issue like this by simply saying "no"
to fixing it. So now every game that uses a keyboard has to be sub par, or
the game dev needs to fix a broken engine - without support from the
leadership of the engine. Of course I should be mad about this. At the very
least keeping the issue up allows the conversation to continue, and not
saying "this is not going to happen" - discouraging people from trying to
submit fixes themselves.
On Mon, Jun 21, 2021, 6:43 AM Mario Zechner @.***>
wrote:

You resurrect an 8 year old issue and tag me to inform me of your
entitlement. Good job, @Emperorlou https://github.com/Emperorlou! I'm
sure people love working with you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/libgdx/libgdx/issues/783#issuecomment-865043806, or
unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AACM6HDJ4KX2N5RKH2NEUHTTT46W7ANCNFSM4AINDQKA
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/libgdx/libgdx/issues/783#issuecomment-865382633, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD5QBEY2HQPTD2MDA4AWHTTT63LBANCNFSM4AINDQKA
.

Can I file an issue on your repos to not copy our code and strip the
license header? Surely, such behaviour would mean your project simply can
not be taken seriously. Nobody would want that, right?
https://bitbucket.org/universeprojects/voidspacegraphics/src/master/src/main/java/com/universeprojects/packer/texturepacker/TexturePacker.java
Also, closing an issue written by a man in distress, because he "CAN ONLY
EAT ONE FOOD" by saying "Works as intended" is also not very good form.
That's why nobody can take Initium seriously. I'm also sure there's a
lesson burried in there. Something about teaching a man to become a fish or
something.
https://github.com/Emperorlou/Initium-ODP/issues/846
And by the way, JEP is GPL 2. Initium links to it. Surely, if I post an
issue on your Initium-ODP tracker asking for the closed sources of your
project that you link with this GPL code, I'll get those closed sources, as
the GPL requires, right? Anything else would be unacceptable and lead
people to not take your project (and you) seriously.
https://github.com/Emperorlou/Initium-ODP/blob/master/Initium-Odp/src/org/cheffo/jeplite/JEP.java
On Tue, Jun 22, 2021, 00:43 Mario Zechner @.***> wrote:

By all means, submit a fix for this issue via a pull request. But you do
not get to dictate how things are run around here. Nor does anyone working
on this owe you a single thing.
As can be seen by you necromancing this issue after 8 years, it was easily
discoverable via a simple search for your specific problem. You could have
decided to ask for re-opening as you'd like to take on the issue since you
have an immediate need for a fix. You could have shown work arounds you
found that could be implemented and discuss the best approach to implement
the fix with maintainers before heading off and sending a PR.
 Because YOU have a booboo in your super important
project! Because YOUR issue is the most important issue in the world and it
is an afront that someone didn't anticipate YOUR need 8 years ago. How dare
those OSS maintainers!
You must not interact often with people, if you think they way you
introduced yourself here will yield a positive outcome.
 Your
entitlement and disrespect is inversely proportional to your contributions
to this community. And sadly, there are more people like you than people
who actually take their time to get to know and participate in the
community surrounding an OSS project.

On Tue, Jun 22, 2021, 00:20 Nikolas @.***> wrote:

The decision to ignore this issue is why it still exists 8 years later,
and
it is delegitimizing libgdx on the mobile platform. A lot of people have
invested a lot of time and effort into this engine and this attitude is
exactly why it can't be taken seriously. Why wouldn't you care enough
about
libgdx to give it proper Android input support? Why close this issue when
someone else could have taken it on? I get that you might not have the
time
to do it yourself, but by closing the issue you're shutting down a fix for
it. Even worse, you specifically say that it's not going to happen?
In fact people HAVE taken it on and if you do enough Google searching you
can see people have hacked a way through this problem before. The
leadership here is ignoring a glaring issue like this by simply saying
"no"
to fixing it. So now every game that uses a keyboard has to be sub par, or
the game dev needs to fix a broken engine - without support from the
leadership of the engine. Of course I should be mad about this. At the
very
least keeping the issue up allows the conversation to continue, and not
saying "this is not going to happen" - discouraging people from trying to
submit fixes themselves.
On Mon, Jun 21, 2021, 6:43 AM Mario Zechner @.***>
wrote:

You resurrect an 8 year old issue and tag me to inform me of your
entitlement. Good job, @Emperorlou https://github.com/Emperorlou! I'm
sure people love working with you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/libgdx/libgdx/issues/783#issuecomment-865043806,
or
unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AACM6HDJ4KX2N5RKH2NEUHTTT46W7ANCNFSM4AINDQKA
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/libgdx/libgdx/issues/783#issuecomment-865382633, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD5QBEY2HQPTD2MDA4AWHTTT63LBANCNFSM4AINDQKA
.

Yeah, I'd actually like to see those sources, as the GPL 2 requires.  MISSION ACCOMPLISHED

I was going to watch something on Netflix and changed my mind when I found this thread.
Go Mario!


Renamed comment spider, added environment.yml

@msarahan @youngblood look ok?

LGTM.  My only comment is that in the docker image, I point to scrapinghub for the scrapy install.  Since they are the package maintainers, I think that's a little better.

@msarahan going to merge this. I'm going to add an issue to specify to get scrapy from scrapinghub.


Change "Adicionar" for "Añadir"

Hey,
Thanks for this great gem. I noticed that this translation file mixes "Adicionar" and "Añadir" for "Add". The correct term is "Añadir", so I've changed the other two instances of "Adicionar" for it.

Hey @gfiorav thx for PR.


how to setup vscode for reading golang runtime code?

I have checkout the golang source code (1.13) and ready to jump into it, but found difficult to browser the code base (unable to find definition of a symbol, references etc.), not like normal go project.
Is there anything I need to setup specially for the golang source code project?

after add the "go.goroot" setting to link to the work directory of go source, it solves the problem~

after add the "go.goroot" setting to link to the work directory of go source, it solves the problem~

It appears your problem is solved, then?
Anyway we don't really use the github issue tracker for questions (only Go bugs), and this is a question about vscode, so it's more likely that someone in the vscode issue tracker/forum will be able to help you if you have any other question.
Closing here.


List AWS regions added in release<PHONE_NUMBER>4741

Release Playbook

[ ] Rebase against master
[ ] Code review
[ ] Merge into master
[ ] Verify changes at http://site-staging.convox.com
[ ] Promote release on site-production in the convox/production Rack

 Update supported AWS regions doc

LGTM! I'll be referencing this from the newsletter.


ARM32: fix IntPtr overflow issues with thunk addresses

- thunk addresses can be wider than type Int,
but valid in C pointers terms.

Signed-off-by: Petr Bred<EMAIL_ADDRESS>

@BredPet,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@Dmitri-Botcharnikov
@sergign60
@alpencolt
@jkotas please review

Is this change motivated by a actual crash you have hit, or just by codereview?

Is this change motivated by a actual crash you have hit, or just by codereview?

Crash, pointers are overflow Int type in our sample.
@MichalStrehovsky, @jkotas thanks, I'll fix

@jkotas please review again


[Bug]: Documentation from Query Data source loading to the middle of document

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When we click on new Query Datasource, and click on "Documentation" in right side, an omni bar opens, when we click on any topic it jumps to the middle of the topic and not focused on the heading of the topic

Steps To Reproduce

Click on New data source query
Click on "Documentation"
Click on any topic other than first topic
Observe the topic clicked is not focused in the heading but in the middle

Public Sample App
No response
Version
Release

Stats

Stat
Values

Reach
1200

Effort (months)
1


Terraform is not configured to use service principal

Update provisioning scripts and configure terraform to use a dedicated Service Principal
References: #702

Components on green will need to be added to support this requirement.

Note: Issues #709, #704 and #705 were about to cleaning up terraform provisioning script and stabilize the script for subsequent runs. This was done by removing components such as Key-Vault and SP creation logic, that most likely will need to be added back and improved in order to complete this task.  A design review is needed before to implement this task.


Cleanup recipe to make constant names uppercase (RSPEC-115)

Create a cleanup recipe that makes constant names all uppercase.
See: https://rules.sonarsource.com/java/RSPEC-115

Moving to backlog to focus on other recipes, since renaming constant requires quite a bit of work.


Add tru

Hi, thanks for creating this helpful list. This PR adds a new language called tru.

https://github.com/sungwoncho/tru
https://esolangs.org/wiki/Tru

Hi @sungwoncho thanks for your PR.
The language seems interesting and the description is good, I've added a comment regarding some format issues that need to be addressed before merging

@angrykoala thanks for your review.


Should re-present when sheet/fullScreenCover/popover identity changes

Our view modifier overloads currently call down to the isPresented: Binding<Bool> versions, which can lead to some unwanted behavior: for example, if a presented sheet changes to another presented sheet, this change occurs without animation (brought up in discussion #73).
We can fix this by calling down to the item: Binding<Item?> APIs instead. This means making sure that the "item" being presented is identifiable, but we can hopefully create a lightweight wrapper type to represent this info. Rather than requiring the value itself to conform to Identifiable, we can identify based off a combination of:

The type of value (ObjectIdentifier(Value.self)).
The enum case, where applicable (we can use this enumTag helper or something similar.
An underlying identifier by casting Value as? any Identifiable.

If anyone wants to take a shot at supporting this, we'd gladly take a PR! Otherwise we'll try to get to it soon.

Is this the cause of a .sheet being presented as a .fullScreenCover (or vice versa) when the case of the unwrapping enum changes from one to another?

@Zeta611 It shouldn't be! That sounds like a gnarly SwiftUI bug, though, if you want to share a repro and file a feedback with Apple.

@stephencelis I think he's referring to this https://stackoverflow.com/q/69101690 which I've stumbled upon whilst using the nav branch in TCA as well, so yeah I'm pretty sure it's a vanilla SwiftUI bug.

Is there a workaround for this until this work is done?

@Muhammed9991 You should always be able to stagger the updates, e.g. nil out the presentation, sleep 0.3 seconds, and then set state to some other value.

Closed by #157.


Status of python-netaddr

We have a recipe for python-netaddr_0.7.10 but a newer version (0.7.18) is available in meta-python.
Do we want to keep this particular version of the recipe?

We have install all the latest packages using pip in vagrant-cookbook so I think it would be nice to update the recipes as well :)

Since no component in meta-bistro depends on this particular version this recipe will be removed.
A project using meta-bistro should get it directly from the meta-python layer.


FutureProvider not listening to another provider changes

Describe the bug
FutureProvider not listening to another provider changes.
I have 2 Page LeadListPage, AddEditLeadPage, Leads are fetched using FutureProvider and populated in the leadsListPage.
user can create a new lead by going to AddEditLeadPage where he fills the form and submit it. once the form submitted successfully server sends 200 ok response I am trying to re-fetch the leads(in order to show updated leads) and route the user back to the leads list screen.
I am not sure the way I am trying to re-fetch data using future provider is right to wrong. it would be really helpful if you could help me with this.
what is the right way to re-fetch data using FutureProvider
To Reproduce
class LeadsNotifier extends StateNotifier<DateTime> {
  LeadsNotifier() : super(DateTime.now());

  void updateDate(DateTime date) {
    state = date;
  }
}

final fetchLeadsProvider = FutureProvider.autoDispose<List<LeadModel>>((ref) async {
  final _leadsService = ref.read(leadsServiceProvider);
  final date = ref.watch(leadsProvider);
  print("fetchLeadsProvider: $date");
  final from =
      (Jiffy(date)..startOf(Units.DAY)).dateTime.toUtc().toIso8601String();
  final to = (Jiffy(date)..endOf(Units.DAY)).dateTime.toUtc().toIso8601String();
  final response = await _leadsService.fetchLeads(from, to);
  return response;
});

LeadListPage
class LeadListPage extends HookWidget {
  @override
  Widget build(BuildContext context) {
    final _leadsState = useProvider(leadsProvider);
    final leads = useProvider(fetchLeadsProvider);
    final _leadsProvider = useProvider(leadsProvider.notifier);

    return Scaffold(
       body: leads.when(
        data: (data)=>SuccessWidget(),
        loading: ()=>Loading(),
        error: (err, stck)=> ErrorWidget(),
       );
    );
}

somewhere in another provider
// tried to update date to listen for changes
void onSubmit(){
_leadsNotifier.updateDate(DateTime.now());
}

// tried to refresh via context refresh
void onSubmit(){
final container = ProviderContainer();
container.refresh(fetchLeadsProvider);
}

Expected behaviour
FutureProvider needs to fetch updated data from the server.

void onSubmit(){
final container = ProviderContainer();
container.refresh(fetchLeadsProvider);
}

You cannot create a new ProviderContainer like this. You could instead call context.refresh


fix: upgrade react 17.0.2 to 18.2.0

e2e test for this dependabot PR #101

Merging this PR instead of dependabot PR #101 after testing without breaks.


Add window binary sensors

Got error at initial restart. I had this previously too, so not likely related to this release, but maybe worth looking at. It resolves when removing the integration and install again (it´ll generate same sensors)
Logger: homeassistant.config_entries
Source: custom_components/toyota/init.py:57
Integration: Toyota Connected Services (documentation, issues)
First occurred: 09:10:46 (1 occurrences)
Last logged: 09:10:46
Error setting up entry<EMAIL_ADDRESS>for toyota
Traceback (most recent call last):
File "/usr/local/lib/python3.9/site-packages/httpx/_transports/default.py", line 61, in map_httpcore_exceptions
yield
File "/usr/local/lib/python3.9/site-packages/httpx/_transports/default.py", line 281, in handle_async_request
) = await self._pool.handle_async_request(
File "/usr/local/lib/python3.9/site-packages/httpcore/_async/connection_pool.py", line 237, in handle_async_request
response = await connection.handle_async_request(
File "/usr/local/lib/python3.9/site-packages/httpcore/_async/connection.py", line 136, in handle_async_request
self.socket = await self._open_socket(timeout)
File "/usr/local/lib/python3.9/site-packages/httpcore/_async/connection.py", line 163, in _open_socket
return await self._backend.open_tcp_stream(
File "/usr/local/lib/python3.9/site-packages/httpcore/_backends/auto.py", line 44, in open_tcp_stream
return await self.backend.open_tcp_stream(
File "/usr/local/lib/python3.9/site-packages/httpcore/_backends/anyio.py", line 154, in open_tcp_stream
stream = await TLSStream.wrap(
File "/usr/local/lib/python3.9/contextlib.py", line 135, in exit
self.gen.throw(type, value, traceback)
File "/usr/local/lib/python3.9/site-packages/httpcore/_exceptions.py", line 12, in map_exceptions
raise to_exc(exc) from None
httpcore.ConnectTimeout
The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 304, in async_setup
    result = await component.async_setup_entry(hass, self)  # type: ignore
  File "/config/custom_components/toyota/__init__.py", line 57, in async_setup_entry
    await client.login()
  File "/usr/local/lib/python3.9/site-packages/mytoyota/client.py", line 75, in login
    await self.api.get_new_token()
  File "/usr/local/lib/python3.9/site-packages/mytoyota/api.py", line 117, in get_new_token
    response = await client.post(
  File "/usr/local/lib/python3.9/site-packages/httpx/_client.py", line 1825, in post
    return await self.request(
  File "/usr/local/lib/python3.9/site-packages/httpx/_client.py", line 1494, in request
    response = await self.send(
  File "/usr/local/lib/python3.9/site-packages/httpx/_client.py", line 1586, in send
    response = await self._send_handling_auth(
  File "/usr/local/lib/python3.9/site-packages/httpx/_client.py", line 1616, in _send_handling_auth
    response = await self._send_handling_redirects(
  File "/usr/local/lib/python3.9/site-packages/httpx/_client.py", line 1655, in _send_handling_redirects
    response = await self._send_single_request(request, timeout)
  File "/usr/local/lib/python3.9/site-packages/httpx/_client.py", line 1699, in _send_single_request
    ) = await transport.handle_async_request(
  File "/usr/local/lib/python3.9/site-packages/httpx/_transports/default.py", line 276, in handle_async_request
    (
  File "/usr/local/lib/python3.9/contextlib.py", line 135, in __exit__
    self.gen.throw(type, value, traceback)
  File "/usr/local/lib/python3.9/site-packages/httpx/_transports/default.py", line 78, in map_httpcore_exceptions
    raise mapped_exc(message) from exc
httpx.ConnectTimeout

Rest of install has gone fine and new sensors are generated. Will need to open the windows later today to see if all works as planned!

@renewoensdregt Can I get you to open a separate issue for the install problem? So I can track separately 😊
And great to hear!! Looking forward to an update

Unfortunately first test is not positive. Left front driver window open but sensors not updated.
from MyT:

from HA sensors:

I know you’re going to ask me to run the output as we’d been testing. But don’t have the PC nearby now. Will try later.

Ignore!!! Likely takes some time to update!!!

i did notice it doesn’t update when driving and post driving between 5-10 minutes to update.

The integration has an update interval set at 5 minutes, this was because before it wasn't really necessary to update often, but this my change that. I will change it to 1 minute, but let us test it for a couple of days, just so we are sure it is not causing other problems

Yes, let´s continue (I´ll likely do some more testing this weekend as I hardly use the car during the week), as I am not necessarily sure the issue is the timing of the polling of your module to the MyToyota, but it might even be MyToyota that doesn't poll the car very frequently. In that case increasing your polling won´t really help.

I just pushed an update to here that reduces the update interval to 90 seconds instead of 5 minutes.

Now you should also get 3 sensors, one for headlights(front), backlights and hazard lights 🎉

confirmed! new update pulls those in. Will do some further testing as said during the weekend!

Been testing various combinations and all work well!!! The only thing I’ve noticed is that doors unlocked is not yet showing in your code and that it’s takes time for the updates to see, even in the MyT it takes time. Not sure how to test the lights…

I have not added doors yet. Taking one thing at a time. Will add them in a separate PR in the next couple of days 😊
If your hazard lights are turned on the sensor should show they are on and vice versa 😊

Tested hazards on need and works!! Light detected 😁

Awesome!!
I am also gonna introduce a overall warning sensor in the next PR along with the doors, hood and tailgate😄
AND i may have a surprise for you all. Being able to lock and unlock the car from HA, but i will need you guys to test it 🤞

👏👏👏 did you see the PR for Dutch? Just asking as I’m not sure I did all right.

@renewoensdregt there is no PR open on here, did you open it on your own fork by accident? 🤔

Told you I was no expert :-)
Link is here: https://github.com/renewoensdregt/ha_toyota/pull/1
but I’ll create a new one tomorrow if needed.

Haha that's totally okay, we all have to learn 😄
You need to open the PR against my repository like you did with the first one, or else i can't include it.

Let me try as indeed need to learn how to do it correctly. Movies you picked up the others quickly but this one not, hence why I wondered.

Github can have a steep learning curve when you start using it, it took me a couple of months before i got comfortable with it. So just take your time and ask (As you already do) and i will guide you as best as i can 😃


StreamingLog object has no attribute '_namespace'

StreamingLog object has no attribute '_namespace'
When trying to view a log on a namespace, this is the error I get.
DOCKERCLOUD_NAMESPACE set

As an update, and a little more information. I am seeing this happen when running docker-cloud cli from MAC OS in v1.0.8, as well as when running cli from the docker container of v1.0.8. But I don't see this bug when running from the docker container with tag: v1.0.7 ... seems to be a bug introduced in version 1.0.8

I will take a look at it and do a patch ASAP

@robinduckett @jmshelby
I have updated the SDK to a new version that contains the fix.
Can you do pip install -U python-dockercloud to upgrade the SDK version from v1.0.11 to v1.0.12 and try again?
Thank you

About a month too late, implemented it myself using node / websocket API directly, and no longer use this CLI due to the fact that it didn't seem to support namespaces which is kind of important for the way my client uses Docker Cloud.
Is there anywhere I can log issues against the docker cloud API directly because I've come across a few issues surrounding the implementation of remote execution (no way to send escaped characters, so you can't do things like update the terminal window size of the remote container using control characters \033[ etc) among other things.

@tifayuki - thanks but i'm just using the pre-built docker image, not really sure how to setup all that pip stuff. We're you able to recreate the issue on your end before you fixed it? if so, then I trust the fix

@jmshelby
I have rebuild the image with tag latest and v1.0.9

@robinduckett
Sorry about the late fix. The CLI doesn't directly support namespace with options, but the python SDK supports it.
To Report API issue. You can either open a support ticket, or go to the docker forum and open an issue(https://forums.docker.com/c/docker-cloud)

Although the bug is fixed in v1.0.9, that version does not seem to be available via homebrew yet ... any word on when the taps are going to be updated?

@jmshelby
The homebrew is not updated. I will send a PR for a new version soon.

The PR for the new version has been merged to homebrew

thanks Feng


[NETBEANS-2047] Maven/Java project template should be preferred

Highlight the fact that the Maven/Java Application project template should be the first to use.

Merging this simple HTML change.


Make Python 2 compatible

[ ] Import absolute_import and unicode_literals from future

[ ] Enable corresponding check for isort

[ ] Other things I can't think of..

Closing as we are now going to bump the minimum Wagtail version to 2.0 which only supports Python 3.


If people haven't backed-up their key, i would show a continuous warning message

Or a notification bubble at the settings icon in the right, maybe a red exclamation mark? Or a banner that is continuously shown on top like Trezor wallet does it.

This can be done with the same notification format as the successful transaction. Like so:

for icon use the (!) icon from the Settings view (Backup Recovery Phrase list item)
Heading: Please Backup your Recover Phrase!
subheading/text: Secure your funds to prevent loss.
left button: TAKE SECURITY COURSE
right button: BACKUP NOW (in magenta)


can't find apiGoogleconfig.json in ubuntu server

ERROR` in ../~/react-google-calendar-api/build/ApiCalendar.js
Module not found: Error: Can't resolve '../../apiGoogleconfig.json' in '/var/www/staging/development/source/node_modules/react-google-calendar-api/build'
 @ ../~/react-google-calendar-api/build/ApiCalendar.js 11:13-50
 @ ./src/components/Nanny/NannyProfile.js
 @ ./src/routes/index.js
 @ ./src/index.js

It think, it will be better if we set config by importing.
Automated resolving config might be problem.
I found some issue...
In my local windows machine, your package didn't build and run directly.
Btw in the ubuntu server node_modules/react-google-calendar-api/ I found ./build directory, so that your built package didn't know config json file path since directory level is changed.
Thanks in advance

Hi, Yeah I see
Hmm maybe I should do an automated resolution Path because now this is hard coded in the import with "../../apiGoogleconfig.json"
Didn't thought about build configuration, I will change the hard coded Path, with "../../../apiGoogleconfig.json" temporary. And when I will find the time will do an automated Pathfinding
But if you want to contribute and do this you are welcome.
Thanks

@starcraft0429 I fixed it temporary and tested it, now you can use it on your server.
I'm closing the issue if you have other problems or if this isn't working I'm here.

Thanks @Insomniiak