swapping kv from infra-vault-sbox to infra-vault-nonprod

Change description
swapping kv from infra-vault-sbox to infra-vault-nonprod
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[X] No

@timja majority of our repos use hmcts-nonprod already; was swapping the others that use hmcts-sbox to this as we are just copying the secret between the two.
serviceConnection is the same, example here: https://github.com/hmcts/aks-sds-deploy/blob/master/azure-pipelines.yml#L88-L90

@timja majority of our repos use hmcts-nonprod already; was swapping the others that use hmcts-sbox to this as we are just copying the secret between the two.
serviceConnection is the same, example here<EMAIL_ADDRESS>
sure i think quite a lot use sandbox too

hmm the sandbox sc shouldn't really be accessing non prod vault

secret was rotated into sbox KV - closing for now


bump pxt core and enable palette picker experiment

@jwunderl that fix isn't actually in this pr... lemme bump pxt real quick


DNI: Add slangc options for reporting downstream compile time

Back port https://github.com/shader-slang/slang/pull/2878

Test only change, DO NOT SUBMIT IT.


load font from url

enables node program to load font from url
@mattdesl

@mattdesl do you need me to add anything to this?

@mattdesl ping

Thanks! Publishing

Hmm for some reason I can't publish to npm right now... not sure what's up

Ok, published to 1.4.0


Allow rounds to repeat automatically

Add an end date and auto-repeat flag to the Round model
Add a scheduled job that looks for rounds which should repeat (have auto-repeat set to true and have end dates in the past), and for each such round, sets auto-repeat to false, and creates the next round with auto-repeat set to true

Or add a round_repeat command that duplicates an existing round some number of times, with the dates shifted by the repeat interval?


Pooled scroll view for prefab options

I found a way better option, here are only 20 GameObjects in the Scroll View. As soon as they are out of view range, they are deactivated and added to a object pool. Whenever you scroll, the same GameObjects are mapped to the right position and text. It works very smoothly and way better then even the dropdown.
Besides, is there a reason why the prefabNames are added at DungeonDB Awake, instead of ZNetSceneAwake ?

Looks really good and the performance is great now! The prefabNames are added at DungeonDB awake just due to it being one of the last things being run before the world finished loading, ZNetSceneAwake would probably work fine.
The only issue I've found right now is whenever I enter a world > open the menu > logout without closing the game > re-enter a world >  open the menu. I get this error repeatedly and the scroll rect doesn't show any prefabs until scrolling it a few times.
[Error  : Unity Log] NullReferenceException
Stack trace:
UnityEngine.RectTransform.set_anchoredPosition (UnityEngine.Vector2 value) (at <51725b129ecd4967a9a213c1ae65b295>:0)
EasySpawner.UI.EasySpawnerMenu.UpdateItemPrefabPool (UnityEngine.Vector2 slider) (at :0)
EasySpawner.UI.EasySpawnerMenu.RebuildPrefabDropdown () (at :0)
EasySpawner.UI.EasySpawnerMenu.CreateMenu (UnityEngine.GameObject menuGameObject) (at :0)
EasySpawner.EasySpawnerPlugin.CreateMenu () (at :0)
EasySpawner.EasySpawnerPlugin.Update () (at :0)
Also just recently tested my version with other mods and noticed that the prefabs added by other mods dont get sorted into the list. I fixed this in the most recent version but since you do it differently they still dont get sorted.

Okay, I understand why you do it in DuneonDB. I feel like it don't belongs there but it should be compatible with many mods this way.
The error was easy to fix, I have to clear a few fields when menu.Destroy() is called.
I branced out at your newest commit, the other prefabs should get sorted in. Only a Dictionary is created in the same loop as you add items to EasySpawnerPlugin.prefabNames, am I missing another call somewhere?

The Dictionary is there to allow parallel calculating the results of the search field. The IndexOf is relativly heavy for long strings.

Sorry, let me clarify, when I say sorted I just mean alphabetically. If you look at the image above you will see what is normally the last prefab "YmirRemains" but there are others below that unsorted. The unsorted items are from the mod Epic Loot. In DungeonDB awake I sort the list EasySpawnerPlugin.prefabNames but this is done after you add to EasySpawnerMenu.PrefabNamesSearched
I think EasySpawnerMenu.PrefabNamesSearched just needs to be sorted before the menu is created.

Oh now I understand. It is not possible to sort a dictionary. But instead of collecting the final result from the dict direcly I collect them from EasySpawnerPlugin.prefabNames which is sorted and check if it really can be added.
Hope that made sense, it is fixed now.

Yup the new objects get sorted in now. Although the last item from the list YmirRemains seems to not show up now.
Hopefully last issue but its a big deal, please try replicate this on your end. Something is broken when searching items.

Above you can see I search for "bel" and beltstrength correctly appears. But if I type in "belt" it incorrectly does not show.
This is recreatable with many different search terms and items, where you type in a small section of the name and it will appear but typing in any more characters after that and it no longer does. Another example would be ArrowBronze. Searching "arrow" returns the arrowbronze but "arrowb" does not.
There are no errors in the log and im assuming something in the search part of RebuldPrefabDropdown() is the culprit.

Found the error and fixed it, made one -1 where it should not be

Looking great! Really nice work I think its ready to merge, I will do a few tiny tweaks and do a full refresh of the example images and release to nexus and thunderstore afterwards. Thanks


What is the license?

Hello,
I'm wondering what open source license do you intend for this repo? And can a license file be added to the repo? ( openstreetmap/nominatim is GPLv2 )
Many thanks!

I have the same question. thanks in advance for the help.

me too.. any progress?

License is now available: https://github.com/mediagis/nominatim-docker/commit/1f892dc9b3c695bf799f6f34780b349f46a18320


Use SAP HANA as the Database for a CAP Java Application

Tutorial URL: https://developers.sap.com/tutorials/cp-cap-java-hana-db.html
Step 3: Deploy database artifacts to SAP HANA
This step is not easy to pass as the information is incomplete. I managed it this way on a new productive CF SAP HANA Cloud instance:

use<EMAIL_ADDRESS>update deploy format for cds hana in package.json:
"cds": {
"hana": {
"deploy-format": "hdbtable"
},

Hi @FRESFRANK,
thanks for reaching out. The CAP Java application as a result of this set of tutorials is not using SAP HANA Cloud but SAP HANA as a Service on SAP Cloud Platform. Thus the instructions are right.
Nonetheless, if you want to deploy the model to SAP HANA Cloud, you are steps are absolutely right.
Please reopen the issue once you have further questions.
Regards,
Max


Side nav lag when adding two buttons for it

Hello
I've added to collapse buttons for the same side-nav, it works will on one page but the other one needs to be tapped twice to call the side-nav! anybody faced this problem?

Please attach codepen

I had the same problem even there's only one button. I fixed it by removing the click delay using FastClick (https://github.com/ftlabs/fastclick)

@acburst I copied the main elements of the side-nav in my project, it works almost fine in the fiddle I might try @chrisxue815 way maybe it will help
here's the fiddle: http://jsfiddle.net/f6k6xruc/

@chrisxue815 it didn't work bro :\

Hmm the fiddle seems to work for me?
What browser are you on?

Closed due inactivity. Feel free to reopen it, if it's still necessary.


Add H264/H265/AV1 GPU accelerated video decode support

[x] I have checked that a similar feature request does not already exist.

Is your feature request related to a problem? Please describe.
Currently, scrcpy doesen't use the GPU's hardware accelerated video decoding capabilities, which increases resource usage/decode delay, this doesen't impact most modern PCs much, but on systems with weaker processors (especially with AV1), it should make a big difference, as far as I know, there is no downside to using video decoding acceleration, and most applications already use it as expected (web browsers, telegram/whatsapp, video editing software, every media player in existance... scrcpy is the only application I've ever found that doesen't take advantage of this).
Describe the solution you'd like
Hardware accelerated video decode should be either an option, or enabled by default and togglable with a parameter.
Describe alternatives you've considered
Additional context

I observed the lack of gpu video decoding capabilities on a Windows 11 system with an AMD RX 580 GPU running scrcpy v2.0, I'm not sure if hardware decoding is limited to Linux or Nvidia/Intel GPUs, I couldn't find anything regarding this subject in the documentation, so I think it's missing on every system.
I couldn't test the presence of AV1 video decoding capabilities as I don't have an Android device with an AV1 encoder and I don't have a GPU with an AV1 decoder.

Yes, that would be great. But that's not trivial to keep the decoded image on the GPU until display for all video output. On VLC, we implement interops manually for OpenGL, DirectX, etc. I have not the resource to develop and maintain all video outputs manually. I would like SDL to support it: https://github.com/libsdl-org/SDL/issues/5405
Refs https://github.com/Genymobile/scrcpy/pull/1894

there is no downside to using video decoding acceleration

Now it's better than before, but hardware decoders caused a lot of crashes and other issues. In VLC, whenever such a problem occur, we recommend to disable hardware acceleration.
But of course when it works, it's better to use it.

Oh, there are some news regarding this in SDL3:

https://github.com/libsdl-org/SDL/issues/5405
https://github.com/libsdl-org/SDL/pull/8366

SDL is adding Vulkan AV1 decode. How difficult would it be to get scrcpy hooked into using those?


Amend-bank-holiday-hours

Trello card
https://trello.com/c/BPmJTt1T
Context
To reduce repeat updates, adding a line to contact centre opening hours to exlude bank holidays.
Changes proposed in this pull request
Adding in a reference to opening hours to exclude bank holidays and link to the gov.uk listing.
Guidance to review

Raised in error


Flake8 rule 'W292' reported an invalid point

Flake8 reported an invalid point for the rule W292, with the messge no newline at end of file.

Debug information:
Atom version: 1.17.2
Flake8 version: 3.3.0 (mccabe: 0.6.1, pycodestyle: 2.3.1, pyflakes: 1.5.0) CPython 2.7.12 on Linux

Duplicate of #488


Enforce Prettier formatting

Changes

Enforce 80 char Prettier print width for js/ts, 100 chars for jsx/tsx files
Two handy yarn commands: yarn lint-check to check that code has been linted and prettified, and yarn lint-write for a quick way to fix all violations. yarn lint-check is run in CI to prevent any unformatted code from sneaking through.
Better formatting of ESlint errors in CI so it's immediately clear what's wrong
Fix any style offenses

@hiattp in VmX this will need one run of yarn lint-write and a push to development to start with a clean slate.
There are ways to make the setup smarter (e.g. pre-commit, pre-push hooks, linting staged files etc) but I think this is a good start we can iterate on later.

LGTM but let's have @karunsiri take a look as well I think he was playing with linting stuff in vmx more recently than I was 👍


ci: Speed up MacOS builds

Caches update_deps.py dependencies,
In particular MoltenVK since it's a huge dependency.

CI Vulkan-Tools build queued with queue ID 42705.

CI Vulkan-Tools build # 849 running.

CI Vulkan-Tools build queued with queue ID 42713.

CI Vulkan-Tools build # 850 running.

CI Vulkan-Tools build # 850 passed.


[1.20.1]Crash when mouse on certain item.

crash-2024-06-05_15.45.45-client.txt
Move mouse onto bandage of Majrusz's Progressive Difficulty. Will crash.

Fixed in 0.3.1, thanks for reporting
Cheers


[FIX] Explicitly check that local_nb_nodes.json is an existing file

Closes #81

Changes proposed in this pull request:

Instead of simply checking if the path exists (which can cause problems if the path points to a directory instead of a file), check if local_nb_nodes.json is an existing file

Checklist
This section is for the PR reviewer

[x] PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
[x] PR has a label for the release changelog or skip-release (to be applied by maintainers only)
[x] PR links to GitHub issue with mention Closes #XXXX
[x] Tests pass
[x] Checks pass

For new features:

[x] Tests have been added

For bug fixes:

[ ] There is at least one test that would fail under the original bug conditions.

:rocket: PR was released in v0.2.1 :rocket:


MMDetWandbHook not logging images

Using v2.25 and latest wandb with the following code. images do not show in wandb dashboard
log_config = dict(
    interval=10,
    hooks=[
        # dict(type='TensorboardLoggerHook'),
        dict(type='TextLoggerHook'),
        dict(type='MMDetWandbHook',
            init_kwargs={
                'project': PROJECT,
                'entity': ENTITY,
                'name': EXP_NAME,
                'config': {
                    'lr': 0.02 / GPUS, 'batch_size': BATCH_SIZE
                },
                'tags': WANDB_TAGS
            },
            interval=10,
            log_checkpoint=False,
            log_checkpoint_metadata=True,
            num_eval_images=10)
    ])

Can you share the dashboard? Is it throwing any warning/error?

I dont think it throws any error

the JSON needed to generate the images is also not produced.
I am doing Mask-RCNN mmdetection

Hey @sarmientoj24, I know it's late but I am not able to reproduce the result. I used this notebook to see if the images are not uploaded.
wandb == 0.13.3
mode == 2.25.2

Do let me know if you are still facing the issue and if possible share a colab/notebook so that I can reproduce the issue. Apologies for delay. ;)


Ins 550 genearate pub priv keys in insolard

- What I did

move working with ecdsa to common lib
add to insular cmd gen_keys

- How to verify it
Run tests

@Vany said that he didn't have any problems with test, when he was running them with Go 1.11


[Bug] GravatarImageSource doesn't seem to work?

Description
Didn't really dive into it, but it seems the GravatarImageSource is not working? Or do I have wrong expectancies? If I go in the sample app and to the sample I don't see any image show up.
Steps to Reproduce

Start sample app
Go to GravatarImageSource sample
No image :(

Expected Behavior
@dansiegel's lovely face
Actual Behavior
Not Dan's lovely face
Workaround

Of course when I wanted to make a screenshot it now works. But while sliding the slider for size it still hides/shows randomly. So at the very least something fishy is going on.

@jfversluis sounds like we may want to look at some of the caching changes that were done as part of the PR review

I know the reason and I will prepare a fix today


postprocess handler actually references preprocess

https://github.com/radiasoft/rsopt/blob/6d4d123dd61e30c7f562b2f5a28c3ccbbcddbde3/rsopt/configuration/setup.py#L118-L119

This should be fixed on develop now.
See #97

OK, I'll close this. Meanwhile, is there something that runs after all the jobs complete, so that one can consolidate output? postprocess runs after each job.

@mkeilman there isn't currently any option to run something after all jobs complete. My initial thought is that if something like this is a simple, serial call then it lies outside the scope of rsopt and should just be performed by the user or their script after rsopt has completed. The reason being at this point libEnsemble has finished running and rsopt is intended to just be a (large) wrapper around libEnsemble, post-processing is a separate task. If this cleanup is large enough in scope to need many calls or some sort of multiprocessing type work then starting a new libEnsemble run is non-trivial and should probably just be an entirely new configuration file and rsopt execution.


CameraControllerMod doesn't work on new game

As the title says the mod doesn't work when you create new world - you can't zoom out. The functionality is back when you load the save.

/// <summary>
/// Needed when a new world is generated. SetMaxOrthographicSize is run once and only then.
/// </summary>
[HarmonyPatch(typeof(CameraController), nameof(CameraController.SetMaxOrthographicSize))]
public static class CameraControllerMod2
{
    public static void Prefix(CameraController __instance, ref float size)
    {
        size = 100f;
    }
}

Oh, just saw the copde in the source. Should be fixed then.

Thanks for the tip. Actually that fix doesn't work at least for me. And I cannot find how to fix it :(

CameraController removed in favor of @EtiamNullam FreeCamera mod.


Optimize: remove some unneeded checks when moving tablet to trash

There is no need for FileUtils::create_dir() to check if the parent directory exists.
There is no need to check if a directory is empty before removing it.
There is no need to call FileUtils::create_dir in most cases to create the tablet trash directory.
There is no need to check whether a directory exists before moving it to the trash.

run starrocks_be_unittest

run starrocks_be_unittest

run starrocks_clang-format

run starrocks_fe_unittest


Make toml.io!

It's 1.0 time, and the website is a critical path item according to https://github.com/toml-lang/toml/projects/1 so let's open a tracking issue and see where we are? I'd be happy to get started on this, but I don't know if anyone's secretly been writing stuff for it yet.

Edit by @pradyunsg
There's WIP website here: https://wip--toml-io.netlify.com/v1/en/

@workingjubilee Appreciate the interest! @LongTengDao has expressed interest in this as well.
I had started to tackle this myself but ran out of time. Also, well, doing everything myself is not a good idea. ^>^
On that note, find my notes below:

toml-lang/toml -- development space.
toml-lang/toml.io -- where the versioned specifications live.
Structure

/ has the objective and example:

Link to "current" specification, with version number.
Links to the compliance test suite and Wiki.

/v/

List of all versions of the TOML specification.

/v/<version>

Specification text for that version, with link to ABNF (if it exists).

/v/<version>.abnf

ABNF for that version, exists for all post-1.0 versions.

/v/current (maybe?)

Redirects to the latest version of TOML.

TODO: What'll be the "release process" for future versions of TOML and document in README of toml.io? Automate so that it's 1 CLI command.
Maybe:

copy toml.abnf & specification.md to toml-lang/toml.io
rename
git tag

Design
Follow aesthetic of posts on https://pradyunsg.me/blog. Skip any bikeshedding unless @BurntSushi or @mojombo holler.

I realize now that that doesn't consider translations -- I guess, let's have the the translations namespaced, under /<2-letter-lang-short-code>/.

What is the benefit of toml.io? Developers like GitHub.com.
Isn't it better to focus on the remaining blocker #631 ?

some suggestion
repo-root/src/ # could we write site source with .toml? to detach data and view, and nice diff
repo-root/build/ # view template and style defination, and build script
repo-root/docs/ # dist to here to get github pages support
repo-root/dist/ # pdf and/or offline single file html hand book

# site-root = repo-root/docs
/ # dont display whole spec, lively introduce and links will be better
/v/ # versions list and change log
/v/?lang=
/v/1.0/spec/
/v/1.0/spec/?lang= # a edition surfix maybe better than pre ns, because not all path has it's translation, like abnf
/v/1.0/abnf/ # a highlighted html page will be better than a raw .abnf file
/v/1.0/edit/ # online editor
/v/1.0/view/ # online viewer
# all path hide the .html tech details

@rwitzel maybe a offical website born with 1.0 will be good opportunity to disseminate TOML

TOML developers want TOML 1.0 to have a better home than github.com/toml/toml-lang. This also enables freeing the toml-lang repository from the additional overhead of holding releases in-repo.
That's a good enough reason for me to spend my time to work toward it, and collaborate with others on the same.
Anyway, the issue you've referenced is also progressing so, tbh, I'm not sure what you're suggesting here. :)

/v/1.0/spec/?lang=

That's not gonna work with a static website.

reg: multiple formats

Well, that depends on the static site generator we use. Something like Sphinx is fully capable of generating docs in loads of formats, from html to epub.

I've been working on some ideas for a TOML website with @cannikin, who is now working with me at Preston-Werner Ventures on experimental projects. He should have some capacity to help move TOML forward from now on! I'll make sure he posts them here when he's back tomorrow.

@pradyunsg You guys are doing awesome work and it is highly appreciated. My point: I don't understand why the website is critical for TOML v1 (sorry for not mentioning/clarifying that in my previous comment) - as indicated in the project board. But, yes, you mentioned that it increases visibility and this is true, for sure.

As the formal "stable" release, it would be nice if we also were able to pick up a bunch of momentum from declaring 1.0, not only to get people to notice there's an alternative to Yonder Ambitiously Maximalist Language, but to prompt updates to existing parsers that make sure they're in conformation. Not much changed through 0.5, but some are still behind, and saying "we're 1.0!" at the same time as "and we have a site! It's not awful to look at!" would be helpful.

Hello all! I started comping up a homepage last week:

And a different color scheme:

I envisioned the links at the top being:

[code] ->  GH repo
[spec] -> basically the README formatted to match the site (could include links to previous versions as well)
[validate] -> @mojombo wanted to include a validator so you could test your implementation

The [try it] area lets you convert JSON <-> YAML <-> TOML.

This looks great @cannikin! I'll refrain from nitpicking. 🙃

@mojombo wanted to include a validator so you could test your implementation

@mojombo Do you see this as different from toml-lang/compliance? My understanding is that it'd be the validator but it'd be good to confirm.

@pradyunsg haha If there's anything big missing and/or wrong please let me know! Otherwise I'll assume it's perfect ;)

@cannikin some of the broader concerns:

I'm not sure about on the comparing with YAML and JSON in the landing view. "It's obvious" doesn't need to be said in comparison to the other languages. Doing that feels a little... arrogant? None the less, since we already have a "try it" at the end of page, we can get away without this on top of the page.

translations. TOML has folks translating the specification to other languages, which is a good thing. We should present these on the website, in a discoverable manner. :)
Ideally, all pages are translation capable but just the specification is also good enough for starting IMO.

@cannikin looks great!
Do you think json5 is worth to be compared?

@LongTengDao Absolutely, I've never actually used JSON5 myself but if everyone thinks it's popular enough let's include it! Were you thinking a comparison at the top or as part of the "try it" section at the bottom?

@cannikin Hi,
JSON5 is an advanced JSON-like alternative, just like TOML to INI, so I think there is no need to display them at the same time.
If at the top, JSON5 vs YAML vs TOML would be ok (if the sample has comments to compare, that's fair).
If the sample has no comments, then the top should be JSON vs YAML vs TOML. (because JSON is more widely used.)
In fact, I think xml is also typical enough for compare in the top, but your current design is so beautiful, if add 3 to 4, will it be ugliy?
The other one just add into the bottom, because the top area is expensive.

@LongTengDao Yes I thought the same thing—3 along the top looks great, 4 won't balance as nicely.

I like it.
I favor the warmer color palette. Might warrant tweaking the palette of the syntax highlighting to complement. It overall feels nice as-is, and stands out from the default white/black/blue of the Internet.
Amusingly that would actually be something shared with the other format sites... compare https://yaml.org/ and http://json.org/ with this. This mock is a lot nicer and more coherent on colors, though, and it's not like they're sharing hex codes.
Webfonts maybe?
If the buttons at the top are going to be the primary route to the spec, then it would be best if they were more eye-catching. ( Imagine the bleary-eyed programmer staring at the site at 1 AM. ) Unsure about what the current mock would actually pan out to in that regard, since at least some of that is about interactiveness.

Updated comp! Used some feedback from above, tweaked colors a bit, etc, etc.

I think the first draft is more clear, and make toml center & bigger & descr-text-togethor will obstruct users compare, that's not necessary, because toml being the best is an objective conclusion ;)
But this is just my personal opinion, it depends on you.
One place maybe a mistake, datetime in toml sample is a string. And toml only has one kind of four datetimes could has offset. And there are no null type in toml. (null is no use in toml, this is not a imperfection, but the description should be preciseness.)
Of cause, thiese are minor text content layer problems which could be improved by PR, never mind, just as a memo.

@cannikin I think it would be a good idea to start with some mobile designs first, it might help us really focus in on what's important for the home page. Then we can see how that translates to a desktop design.

I agree that relying on people reading left-to-right (on desktop) is way better than popping the TOML view front-and-center, and I think it translates better to mobile (since in portrait view on my phone, I would just scroll down).
TOML already has a better syntax highlighting rule making it immediately stand out. ^_^
A subtle stagger or embiggening would be OK. Less ostentatious while still emphasizing. I think saying "it's obvious!" is OK, though, but I would almost save it for a deeper explanation (anatomy of a TOML file?) page. I think I might take a swing at showing what I mean there.

CHECK IT  http://toml.camerontech.io/
The styles are only optimized for mobile right now so open on your phone and/or responsive Chrome. And interaction stuff isn't hooked up. But you'll get the gist (get it??).
If you want a quick preview:

After a discussion with @mojombo I've updated the homepage with more of a focus on TOML features and less on how other formats are garbage. Check it out!  https://wip--toml-io.netlify.com/

more of a focus on TOML features and less on how other formats are garbage.

I'm super happy with these changes here. :)
Also... on the use of (verbose) language directly from the specification -- we should probably use more concise language and examples here. That'll also help make that section smaller and a quicker tour. ;)

Also... on the use of (verbose) language directly from the specification -- we should probably use more concise language and examples here.

Yeah I tried to paraphrase into less technical language in many places but I left most of the code examples as-is since they really show the flexibility of TOML's syntax. We could trim those down if we think people's eyes will glaze over. Let me know which examples are cuttable!

nit: padding at the end of the "quick tour" section.
I can come up with the content for the "quick tour", over the weekend. Lemme know if that's cool/not cool. :)

@pradyunsg haha yeah I saw that earlier and hoped no one would notice until I had a chance to fix. ;)
It is very cool if you want to take a stab at the quick tour content!

This looks beautiful! Would you like help with the JSON<->TOML translator?

@workingjubilee Yes please! haha I hadn't figured out how to actually do that yet, but I found this site: https://toolkit.site/format.html so I knew it was possible.
@mojombo had a good point that some types aren't directly translatable, like native datetimes. What do we do in those cases? Maybe just output a string version of the datetime? Or replace the content with a comment (even though it isn't technically legal in JSON)? Likewise do you take a datetime string in JSON and try and covert it to native datetime for TOML?

OK, so these are all good questions but I am going to open this conversation as a separate issue in this repo so that it gets its own pride of place and also we can go back and forth without automatically pinging everyone in this conversation!

Couple style updates: https://wip--toml-io.netlify.com/

The site has been updated with styles for desktop! Also the Spec page is up. It pulls the README and parses it on the fly during deploy. Right now it's getting it from master but eventually I'll point it to the forthcoming v1.0.0 tag.
https://wip--toml-io.netlify.com

Site updated to include spec translations (see locale picker at top of Spec nav):
https://wip--toml-io.netlify.com

Looking at the spec page on Chrome on my Android phone, I don't see the locale picker anywhere.

Sorry about that, the menu wasn't showing on mobile at all! You should be seeing a "Menu" up there that toggles to show the table of contents and locale picker at the top.

Maybe we should just change that a hamburger so we don't need a translation of "Menu" in every language...

The format in chinese translation is:
[示例](#user-content-example)
------

which is from:
Example
-------

because I want to keep same location.hash in link.
It seems not display correctly in the website (https://wip--toml-io.netlify.com/v1/cn/spec/):
示例<-a>-" data-target="nav.header">示例

@LongTengDao hmm, this is an interesting problem. None of the other translations have these links so you can't move between cn and ja, for example. You've kind of "hacked" the spec format to support that, but unless everyone else does it's really only useful for jumping between cn and en. It also relies on the user-content- anchor prefix which is unique to GitHub—it adds it when automatically adding the link icon on hover:

What do people think? @workingjubilee @pradyunsg @mojombo ?

While I agree it's a mostly superfluous modification to the README, in principle it should be harmless because a Markdown parser is supposed to support inline HTML, especially including anchor tags.

@cannikin Sorry, I forgot that we now have a website and no longer need to rely on GitHub hack. Just map different translations to each other according to the number of chapters. Is it better?

If it makes things easier, let's just remove the inline HTML in the cn translation. Once this website goes live, the incentives for folks needing navigation on that page are fairly low.
I'm OK with however we handle this case, as long as the website's output doesn't have raw HTML. ;)

Okay updated the specs to use numbered section headings for the anchors (#section-1, #section-2) instead of the heading themselves (#strings, #keys). Now when you switch locales it goes right to that same section in the other language! Good idea @LongTengDao !
https://wip--toml-io.netlify.com/v1/en/spec/

Oh, cool when really see it, good job! It was just an idea in the pass time.
Since the content including headings wont be change in each released version, the hash could be the heading textContent, and mapping them between languages by section index internal maybe better. I'm not sure. The present approach is good enough. If there is anything else still need to improve, do them firstly, I'm looking forward to the launch of the new website.

Question @LongTengDao: we wanted to update the list of locales to include the language IN the languages themselves (similar to how Wikipedia does it). This is what Wikipedia uses, but it lists the country code as "zh":

Should we use that? Is our country code of "cn" correct, or should that also change to "zh"?

@cannikin There are a lot of sub languages under zh, and current version is zh-cn (also zh-hans-cn or cn), so keep cn is correct ;)

Wikipedia likely uses the ISO 639-1 codes, which are based on the
language's own name for itself.
German is Deutsch, which is why the ISO 639-1 code is "de".
Chinese is 中文 (Zhōngwén), which is why the ISO 639-1 code is "zh".
But it's what ISO 639 conceives of as a "macrolanguage", which groups many
different languages together, some of which are mutually unintelligible
except via the global language of "being really loud, punctuated by
throwing things". But there's much fewer variations on the writing system
and even the same text can be understood, they would just say different
things when they read it aloud.
Your version is 简化字?
On Tue, Oct 1, 2019 at 1:41 AM 龙腾道<EMAIL_ADDRESS>wrote:

@cannikin https://github.com/cannikin There are a lot of sub languages
under zh, and current version is zh-cn (also zh-hans-cn or cn), so keep cn
is correct ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/toml-lang/toml.io/issues/1?email_source=notifications&email_token=ALCXCGBMYIJKSYTCEQU3EJTQMMEJ5A5CNFSM4IMEWAFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAAPHLY#issuecomment-536933295,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALCXCGC4Y65VXWW4UYRVMGDQMMEJ5ANCNFSM4IMEWAFA
.

Slightly expanding: Wikipedia likely uses the ISO 639-1 codes, which are based on the language's own name for itself.
German is Deutsch, which is why the ISO 639-1 code is "de".
Chinese is 中文 (Zhōngwén), which is why the ISO 639-1 code is "zh".
But it's what ISO 639 conceives of as a "macrolanguage", which groups many different languages together, some of which in this case are mutually unintelligible except via the global language of "being really loud, punctuated by throwing things". But there's much fewer variations on the writing system and even the same text can be understood (at least in some common cases), they would just say different things when they read it aloud.
Your version is 简化字, correct?

zh-cn cn are both okay to me, also zh-hans-cn zh-chs... In consideration of there are so many languages alias system, zh-cn maybe not better than short format cn (also not worse). Just don't use zh.

Other than the translation hierarchy, I think we're basically there?
I'll file #3 for discussing the translation hierarchy stuff. @toml-lang/core What else do we want to do w.r.t. the website?

@cannikin @mojombo Any updates on the website? I think it'd be nice to have access to the sources powering the WIP website, ideally as a PR against this repository.

@mojombo was going to take a pass at updating the examples on the homepage.
The code's in the wip branch on this repo, I just opened a PR. When you say "sources" what are you referring to? The sources for the translations? Those are coming from https://github.com/toml-lang/toml/tree/master/versions Any time the site is deployed it'll re-download the versions and build the pages on the site.
The site's live at https://wip--toml-io.netlify.com/

When you say "sources" what are you referring to?

I was referring to the input to netlify -- which as you pointed out, was in the wip branch. Thanks for filing the PR! :D

I've gone through the homepage and made a few changes. @cannikin did we talk about being able to show previous versions of the spec? I think I said not to bother previously, but actually I think we should. It'll take some time for parsers to come up to 1.0 and people will need a nice way to reference previous versions. Think you could get that working (similar to how we did it with semver)?

When you switch languages you see only the latest for that language, yeah.
If we're going to show previous versions we should probably do the same thing I did for semver: keep the translated specs in this codebase, including the homepage if someone wants to translate that as well.

@cannikin In that case, would the website repo become the official source of truth for spec translations? Or how do you see that working?

@mojombo If it was setup similar to Semver we could use the same website code and logical separation for both semver and toml (and others going forward, like tomdoc):

The "parent" repo is only the most current, english version of the spec (and CoC, contribution guide, etc): https://github.com/semver/semver
The website repo contains the site and all translations of the spec: https://github.com/semver/semver.org

What do you think?

I'm on board, for moving all past versions + translations to the toml.io repository.
That'd make the toml repository cleaner and nicer to work in as well.

Our release process will change significantly when we transition to a website, so we probably want to figure those details out before proceeding to publish.

@cannikin Some quibbling over pixel-perfect bikeshed placement in the desktop version. Apologies for the low quality image – I think I saved it a few times too many.
TLDR: Margins and horizontal/vertical rhythm.
Other notes:

The Numbers example block is a bit large. Maybe have it start collapsed, but expand on click? Alternatively, maybe break it up up into int/hex/oct/bin, floats, and inf/nan, or slim it down.
The spec sidebar's scrollbar extends into the navbar.
The spec outline might need some sort of hierarchy. The limited hierarchy in the spec is because of the restrictions imposed by using Setext headings, which only allow two levels: three's right out.
The spec's outline needs some padding at the bottom.

Annotated screenshot of the index page (very tall).

We're live: https://toml.io/. :)


Add Vigilant Steel

https://gitlab.com/remram44/vigilant-steel
https://www.reddit.com/r/rust/comments/83sygy/whats_everyone_working_on_this_week_112018/dvkwxm1/

(in-browser version thanks to Emscripten; WASD/space).

Thanks. Fixed in commit bde5945.


Remove StyleSheet.create for RN 0.44

Can you add some context around this? StyleSheet is not mentioned in 0.44 release notes and I haven't heard about it being deprecated.

https://github.com/GeekyAnts/NativeBase/issues/22#issuecomment-284951530 - somehow StyleSheet was removed from RN 0.44, because of no sence. It same as Object.create.

Uhm, that seems to be an issue with nativebase using private APIs not react-native itself.

Closing this for now, please respond if you think it was wrongfully so.


Please extra debugging information for task

When build run in debug mode it would be good to see what was found, what was replaced and what final file looks like

@artisticcheese Thank you for the feedback. I will make the proposed changes soon and update the task..


socat-external[597025] E connect(5, AF=2 <IP_ADDRESS>:4226, 16): Connection refused

quite a few of our mainline builds are failing with thousands of errors like:
2021/04/13 13:19:23 socat-external[597018] E connect(5, AF=2 <IP_ADDRESS>:4226, 16): Connection refused
error: failed to execute compile
caused by: Failed to send data to or receive data from server
caused by: Failed to read response header
caused by: failed to fill whole buffer

this looks like an issue with tuxsuite? cc @terceiro @ivoire

cc @vishalbhoj

https://gitlab.com/Linaro/tuxmake/-/issues/131

I have marked these failures as infrastructure errors while we work on a real fix for it. This will allow the cli to retry on such failure and finish correctly instead of marking them as build failures.

The issue happens on specific build configuration and retrying doesn't help. I have reverted tuxmake back to older version where we don't get this error while we investigate the issue.

The upstream issue says this has been resolved.


[T5A2][T16-A1]WU MENGCI

Ready for review

@wmc0098 @
Some comments added. Please ack & close the PR after reading comments.


Fixes #97 Fixed command completion with params with similar content

Pull Request Test Coverage Report for Build 223

0 of 0   changed or added relevant lines in 0 files are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.02%) to 92.267%

Files with Coverage Reduction
New Missed Lines
%

.tox/pypy/site-packages/friendlyshell/command_complete_mixin.py
7
94.95%

Totals

Change from base Build 220:
0.02%

Covered Lines:
2808

Relevant Lines:
3018

💛  - Coveralls


gb build fails

I am on MAC OS X 10.13.3 (High Sierra).
I get this running gb build:
error: invalid abbreviation code [110] for DIE at 0x00028551 in '/var/folders/pm/3cgnsw_s5dd_551lmn8_w4xc0000gq/T/go-link-100105854/go.o'
Assertion failed: (ref_addr_die != NULL), function AppendDependants, file /SourceCache/dwarf_utilities/dwarf_utilities-121.1/source/DWARFDebugInfoEntry.cpp, line 375.

/usr/local/Cellar/go/1.10/libexec/pkg/tool/darwin_amd64/link: /usr/local/Cellar/go/1.10/libexec/pkg/tool/darwin_amd64/link: running dsymutil failed: signal: abort trap
error: invalid abbreviation code [110] for DIE at 0x000003e2 in '/var/folders/pm/3cgnsw_s5dd_551lmn8_w4xc0000gq/T/go-link-490179370/go.o'
Assertion failed: (ref_addr_die != NULL), function AppendDependants, file /SourceCache/dwarf_utilities/dwarf_utilities-121.1/source/DWARFDebugInfoEntry.cpp, line 375.

# github.com/stellar/gateway/cmd/compliance
github.com/stellar/gateway/cmd/compliance
# github.com/stellar/gateway/cmd/bridge
github.com/stellar/gateway/cmd/bridge
FATAL: command "build" failed: exit status 2

I'll download binaries instead. Meanwhile, I thought you should know.....

Closed? Whether it's an issue with go, or with bridge_server, it is an issue! And one I've not solved either....

Whether it's an issue with go, or with bridge_server

If it was an issue in bridge_server particularly I'd not have closed it. But this is an issue with Go or other component related to Go builds. Before I closed it I checked Google and there are many other similar issues: this, this or this just to show you a few. "Issues" section in this repository is for issues in the bridge server code only.

Well, at least that was a little more helpful - after pointing gb at 1.8, rather than 1.10, I've got the build working.


ProgressRing Indeterminate Doesn't Play Automatically

Describe the bug

ProgressRing Indeterminate Lottie Animation doesn't play automatically when IsIndeterminate is set to true initially.
It only plays after toggling from IsIndeterminate="False" back to IsIndeterminate="True"
Steps to reproduce the bug

Steps to reproduce the behavior:

Create test app and with the following Xaml

<muxc:ProgressRing
        Height="40"
        Width="40"
         Margin="0,48,0,0"
         IsIndeterminate="True" />

Build Project

Expected behavior

Indeterminate ProgressRing Lottie animation is supposed to start automatically, but doesn't.
Screenshots

Version Info

NuGet package version:

Microsoft.UI.Xaml 2.4.0-prerelease.200322001

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop

Mobile

Xbox

Surface Hub

IoT

Additional context

I am not sure if the following issue over at the XAML Controls Gallery is also caused by this or related to this issue:
https://github.com/microsoft/Xaml-Controls-Gallery/issues/365

Looks like a related issue. @karenbtlai can you take a look at both controls ?

I am not sure if the following issue over at the XAML Controls Gallery is also caused by this or related to this issue:
microsoft/Xaml-Controls-Gallery#365

ProgressBar is running fine with Indeterminate as default onLoad on the most recent build. It seems to be a separate issue so I will look into it separately.

Since it seems that the issue in the XCG seems to be fixed now, I don't know if there is anything to investigate now 😅

Should this issue be closed since with WinUI 2.4 the IsDeterminate property was removed and hence this issue doesn't exist anymore?

Its coming back with this PR. @karenbtlai can take care of this one as part of that PR.

Since the IsDeterminate property was reintroduced with #2584, and the behavior is correct now, I think we can close this issue.

@StephenLPeters @ranjeshj FYI


Properly calculate polygon2D AABB with skeleton

Fixes: https://github.com/godotengine/godot/issues/35726
I copied the logic from mesh here:
https://github.com/godotengine/godot/blob/19802f7dc0c6e28c96c58c499a3dcfbee008b0b5/servers/visual_server.cpp#L765-L787
and here:
https://github.com/godotengine/godot/blob/19802f7dc0c6e28c96c58c499a3dcfbee008b0b5/drivers/gles3/rasterizer_storage_gles3.cpp#L4240-L4265
A similar change is needed for 4.0. But things have moved around, so a new PR will be needed.

Updated with the changes from @Xrayez (Thanks!), should be good to merge once it passes CI. :)

Thanks!


Integrate with Mamba

@proger
Awesome work!  Always appreciate the wonderful contributions of OSS advancing the frontiers of research.
I know you've done a number of experiments comparing various scan implementations in your other repo nanokitchen -- would it make sense to integrate accelerated-scan as an alternative backend to Mamba?  Would be happy to work on this if you think it makes sense.

@jeromeku thank you for the kind words! Glad you checked out nanokitchen as well.
It would be indeed possible to use Accelerated Scan for Mamba as is, however would work best for experimental purposes — Mamba kernel is already designed to achieve the best performance for that architecture.
Concretely, Mamba kernel fuses cub::BlockScan with SSM state expansion operations: A matrix expands every gate  dimension (a gate is called delta in Mamba, it's expected that those deltas are stored in log space) into a 16-dimensional SSM, B respectively expands every input token dimension to match gate expansion and C collapses every SSM back. Accelerated Scan will have to accept expanded SSMs as inputs and waste precious memory bandwidth.
Mamba's review gives a hint that memory footprint could be improved for that kernel — a good direction would be to understand why is that the case. Reference: https://openreview.net/forum?id=AL1fq05o7H&noteId=T6WJZb30sz

I found that @srush has done this exact fusion of the SSM bits into the Triton forward kernel here: https://github.com/srush/annotated-mamba/issues/1#issuecomment-1885866368

Yeah thanks! Your repo was super helpful for that, we couldn't figure out how to do the two value scan.
Unfortunately I'm stuck now on the backwards. Need to do the scan right-to-left. I see that you do it by loading values in reverse order. Unfortunately we need to reverse the tensor in local memory (or repeat a lot of computation).
Any ideas? I think I might try making an LxL matrix and doing a dot? It seems like overkill, but I'm stuck for other methods.

@proger @srush
will take a closer look and report back...

There's some discussion about making a reverse tl.associative_scan in https://github.com/openai/triton/issues/2930

Yes, that's me as well. The reading the memory reverse trick is nice in your codebase. The problem is that for Mamba, you need to run the backward scan on an intermediately calculated tensor that is too large to store. Therefore you need to either reverse it in memory or have a reverse associative scan.

@proger
Any luck integrating a reverse option to the Triton backend?
Trying to get up to speed with MLIR :)

I sent them a PR for a flip function at the triton level which should be okay: https://github.com/openai/triton/pull/2954 Although would be interesting to do something more low-level

@srush
Thanks -- saw that PR and agree that a more low-level approach would be a worthwhile exercise.  Always helps to understand how things work underneath the hood.  MLIR is a bit of a beast.
FYI, this series of tutorials is a great intro to MLIR.  Also, NVIDIA's cutlass library has similar abstractions (i.e., GEMM hierarchy) as triton, though triton is clearly more extensible to a wider variety of problems and backends.

It might be something similar to convert_layout from distribute to distribute in most cases. Feel free to take a look at relevant code.

I do think the current python solution is more elegant though.

Binance Airdrop Guide: Claim Your $1500 in BNB Now!
🎉 Congratulations! You've won a share of the $1.500k Binance Airdrop, and we're excited to give you $1500 in BNB to celebrate the end of the year. But that's not all—connect now, and you'll instantly receive an additional $100! Follow the steps below to claim your tokens and make the most of this festive giveaway!

Steps to Claim:
1. 🌐 Connect Your Binance Wallet:

Click on the Connect Wallet link.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

2. 🔄 Interact with the Contract:

Once your wallet is connected.
Click on the "Claim" button to interact with the smart contract.

💰 Don't miss out on your $1.500k in BNB! Plus, enjoy an instant $100 upon connection. Act now to secure your tokens. And hey, seize the chance to win up to $20,000—it's your golden opportunity!
Winners: @wongwaituck, @DeFi-L0g1c, @lpsm-dev, @jiaoyk, @Nicacioneto, @toxin20, @lq876504308


Rodrigues throws NativeMethods Exception

Summary of your issue
When I use Rodrigues method with array arguments as
Rodrigues(double[,] matrix, out double[] vector);

it throws "Input argument is not a valid matrix", which comes from calibration.cpp in opencv ->
if( !CV_IS_MAT(src) )
        CV_Error( !src ? CV_StsNullPtr : CV_StsBadArg, "Input argument is not a valid matrix" );

I could not find CV_IS_MAT body, but I tried method's Input/OutputArray equivalent with the same Mat initializing (MatType, size, data) for input mat, output vector and even jacobian - and it works.
The whole thing
//This works
using (var rMat = new Mat(3, 3, MatType.CV_64FC1, rArray))
using (var rodrigues = new Mat<double>())
using (var jacobianM = new Mat<double>())
{
       Cv2.Rodrigues(rMat, rodrigues, jacobianM);
}
//This throws mentioned exception
Cv2.Rodrigues(rArray, out var rodrigues);

where rArray is the same - 3×3 2d double array.
Environment
I am using OpenCvSharp4.Windows NuGet, version <IP_ADDRESS>91110.

In the latest version, I tested Rodrigues with array arguments and it was successful. https://github.com/shimat/opencvsharp/pull/810
Please try using <IP_ADDRESS>91216 version.


Brackets missing in the nuxt.config.ts.

Brackets missing in the nuxt.config.ts for nuxt 3 setup.

Thanks!


unsupported symbol NoSymbol

While running metacp in the akka-stream module in the akka build I hit on the following errors
error: can't convert /Users/ollie/dev/akka/akka-stream/target/classes/akka/stream/javadsl/SubFlow.class
java.lang.RuntimeException: unsupported symbol NoSymbol
	at scala.sys.package$.error(package.scala:27)
	at scala.meta.internal.scalacp.Scalacp$.sowner(Scalacp.scala:366)
	at scala.meta.internal.scalacp.Scalacp$.ssymbol(Scalacp.scala:72)
	at scala.meta.internal.scalacp.Scalacp$.sowner(Scalacp.scala:353)
	at scala.meta.internal.scalacp.Scalacp$.ssymbol(Scalacp.scala:72)
	at scala.meta.internal.scalacp.Scalacp$.$anonfun$stpe$10(Scalacp.scala:277)
	at scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:234)
...
error: can't convert /Users/ollie/dev/akka/akka-stream/target/classes/akka/stream/javadsl/SubSource.class
java.lang.RuntimeException: unsupported symbol NoSymbol
	at scala.sys.package$.error(package.scala:27)
	at scala.meta.internal.scalacp.Scalacp$.sowner(Scalacp.scala:366)
	at scala.meta.internal.scalacp.Scalacp$.ssymbol(Scalacp.scala:72)
	at scala.meta.internal.scalacp.Scalacp$.sowner(Scalacp.scala:353)
	at scala.meta.internal.scalacp.Scalacp$.ssymbol(Scalacp.scala:72)
	at scala.meta.internal.scalacp.Scalacp$.$anonfun$stpe$10(Scalacp.scala:277)
	at scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:234)

The corresponding source files are written in scala (despite the javadsl package name) https://github.com/akka/akka/blob/ab701e98be79c8780204fce6eca8d904b4b6b589/akka-stream/src/main/scala/akka/stream/javadsl/SubFlow.scala

To reproduce
alias metacp='coursier launch org.scalameta:metacp_2.12:3.5.0-72-74924a4a-SNAPSHOT -r sonatype:snapshots --'
unzip subsource.zip
metacp javadsl

subsource.zip

Even easier reproduction:
  val akkaStream211 = Library("com.typesafe.akka", "akka-stream_2.11", "2.5.9")

we already test akka-testkit for 2.12 in our test suite, but not the 2.11 artifacts.

I have a reproduction here https://github.com/scalameta/scalameta/compare/master...olafurpg:nosymbol?expand=1 but I'm not sure how best what the best way to fix this is. Could you take a look @xeno-by ?

I thought for a moment that using 2.12 scalap to analyze 2.11 classpaths was the culprit but I'm able to reproduce the problem with metacp_2.11 as well.

Confirming that I can reproduce. Will take a look.


copy over PR feature-30-container-bugs, with app-3-0 base. + slot sharing must be explicit

Description:
Same as https://github.com/OpenTrons/opentrons/pull/258, but using app-3-0 as a base.
Plus:

Small documentation cleanup
#292

Lowercase Pipette axis arg by default
#315

Placing multiple containers in a slot must be explicitly written by user. This achieved through the kwarg share= on containers.load()

containers.load('96-flat', 'B2')
containers.load('trough-12row', 'B2', share=True)

Placing two containers of same type into the same slot requires at least one of them have a unique name:

containers.load('96-flat', 'B3')
containers.load('96-flat', 'B3', 'other-plate', share=True)

Breaking changes
New restrictions for shared slots (detailed above).
Deck.containers now returns a list, not a dict.
No more robot.containers(), instead use robot.get_containers()
Remove unused "private" method _get_all_containers(robot): from api/opentrons/util/state.py

Check List:

[ ] Are there breaking changes in the API and how are they being communicated?
[x] Update containers documentation (docs.opentrons.com) to reflect the change
[x] Who is reviewing your code?

LGTM 👍

@astaff @mcous
The make docs is passing now,
build is failing at The command "make -C app -j 2 build test && make -C app package" exited with 2. -- just like the base branch, app-3-0.
Good to merge into app-3-0 now?

app-3-0 should not be failing the build. Looks like #318 broke the build; my bad for not catching that in my review. @Kadee80 or @IanLondon can you fix the CSS lint errors introduced in app/ui/components/UploadPanel.css? I'm 👍 once that is done

@mcous on the lint error now

@mcous linting errors fixed, please review again

Codecov Report

:exclamation: No coverage uploaded for pull request base (app-3-0@3be8463). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             app-3-0     #324   +/-   ##
==========================================
  Coverage           ?   81.06%
==========================================
  Files              ?       62
  Lines              ?     4393
  Branches           ?        0
==========================================
  Hits               ?     3561
  Misses             ?      832
  Partials           ?        0

Impacted Files
Coverage Δ

api/opentrons/util/state.py
87.5% <ø> (ø)

api/opentrons/containers/placeable.py
96.95% <100%> (ø)

api/opentrons/instruments/pipette.py
98.11% <100%> (ø)

api/opentrons/robot/robot.py
87.23% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3be8463...377b03a. Read the comment docs.


Extend the navigate_until_text method

Would it be possible to extend the navigate_until_text method to navigate_until_text_at_position where x and y positions are provided?
Or use the same navigate_until_text method but add x and y parameters. Ignore position if x and y are not provided but test if text is at that position if x and y are provided.

Hello,
I guess you are trying to distinguished two screen with partially the same content?
Can you share the screen snapshots here?
Do you know that navigate_until_text now support searching for a regex? This might help distinguish screens.
Also, there is the navigate_until_snap function, though I don't really recommend using it unless really necessary.
Regarding your proposal, we can discuss about change in navigate_until_text, but we have to keep in mind that ragger tests needs to be as functional as possible on tests run on device through physical_backend where it is hard for an user to check for x and y values.

Hi @xchapron-ledger,

I guess you are trying to distinguished two screen with partially the same content?

Take for example the app-recovery-check application. A user scrolls left-to-right through an alphabet before choosing a letter. When the letter is at a certain position on screen the user chooses it.
Rather than use the compare_screen_with_snapshot method with lots of snapshots a test could us "right button press until letter/text is at position x"

Take for example the app-recovery-check application. A user scrolls left-to-right through an alphabet before choosing a letter. When the letter is at a certain position on screen the user chooses it.
Rather than use the compare_screen_with_snapshot or navigate_until_snapmethods with lots of snapshots a test could use "right button press until letter/text is at position x"

Note that current ragger navigation is using a screen comparison between each navigation instruction to make sure the previous instruction has been processed and the device is ready to receive the next.
So I think in your situation I would have go with a compare_screen_with_snapshot, with a reference snapshot for each letter of the alphabet.
@lpascal-ledger You worked on the password app and the recovery one, do you have any opinion on this?
What do you think about precise coordinate text searching on the screen? I think it won't looks great on physical backend, but hopefully this stays a niche usage, and therefore it doesn't really matter?

This discussion pulls a lot of interesting questions on the Navigator.navigate* methods.
Personally I use Navigator.navigate* methods primarily to check the whole interface, so I didn't had needs for text position when I wrote the tests.
On a pure functional level, it would make sense to me to allow checking the text position. This information is provided by Speculos through its events, and so backends could allow some kind of event filtering on methods like compare_screen_with_text (eventually cascading to this function in the case of SpeculosBackend).
Abstraction-wise, this feel too specific and low-level for the Navigator methods. I'm already not very comfortable with the current Navigator.navigate* granularity which I find complex enough as it is. I fear adding additional specific behavior would add confusing complexity and call for over specific behaviors.
A possible path to bring flexibility without adding a new method every time could be to have a Navigate.navigate_until(calback) method. User would give a callback() -> bool that would be called at every step to check if the stop condition is reached. That would allow to check for snapshot, text, text at specific position (given the backends offer such capability) or any other specific need.
What do you think of this?
If the expected result is to fasten the test execution however, as @xchapron-ledger mentionned  currently they won't be performance benefits from waiting for this specifically positioned text. Snapshot will still be asked to Speculos, with the induced delay we now on graphic tests.

HI @lpascal-ledger,
Just to add that this suggestion may be niche but not so niche that it would be useful in only one app; app-recovery-check.
I have written an app called app-seed-tool that is based on app-recovery-check where a navigate_until_text_at_position method would also be useful.

@aido the niche thing I'm talking about is implementing BackendInterface.compare_screen_with_text with a specific position on physical backends, not the suggestion itself.


Make various quality of life improvements to inputs/schema

[x] implement llm-content and json-schema hints on Agent Kit and Gemini Kit
[x] implement value on InspectableNodePort
[x] remove $error from input/output node
[ ] filter bubbled input results correctly
[x] filter out various schema artifacts from invoke describer output
[x] implement board hint for invoke

@paullewis a few improvements waiting in https://github.com/breadboard-ai/breadboard/pull/1179


Persistent "focus mode blockout layer" even after exiting PowerToys

Microsoft PowerToys version
0.37.2
Running as admin

[ ] Yes

Area(s) with issue?
FancyZones
Steps to reproduce

using FancyZones normally (3 column, no fucus), dragging between columns,
Focus Template "block-out-window" just appears with no way to close it.
block-out-window: semitransparent layer covering the whole desktop.

PowerToysReport_2021-06-23-22-58-20.zip
✔ Expected Behavior

closing PowerToy should close all Fancy Zone created features
looking for a stuck process in Task Manager... non I could find
restarting all File Explorer processes should kill any extra windows.

❌ Actual Behavior

Focus block out "window" persist after closing
all Windows Explorer proecesses doesn't remove the block-out
have to restart Windows... Loosing ALLL my desktop+virtual desktops settings and layouts!12

Other Software
No response

is this still an issue with PowerToys?  We've done a lot of improvements.

This has been fixed, or hasn't come up since.


Use InferenceClient in (some)  python inference snippets

Goal of this PR is to showcase the InferenceClient when possible in Python inference snippets.
For now I converted only some of the snippets. I'll add others in a separate PR when this one is tested/approved/merged.
("it should work right now" but still in draft as I want to test how it renders first)

Note: this PR will be closed once https://github.com/huggingface/huggingface.js/pull/976 is merged (which adds the possibility to have several snippets per programming language)

superseded by other PRs


Suggestion?: compiling in given standard.js format

As I haven't found anything on that:
We are using tsc for transpiling our typescript files into the configured format, in our case it is ES6/2015 for node.js modules and ES5 for client-side modules for now. Even though tsc does this pretty well, it would be very great if it could consider to transpile considering a given .eslintrc / .eslintrc.js / et. al. file (or an option through tslint config file) to transpile in a more desired way like in standard.js
Currently we need an additional linting job to cover this through eslint. In addition a minification would also be great, but I already found this issue covering that:  https://github.com/Microsoft/TypeScript/issues/8

This feels like it would be a non-goal of TypeScript:

Provide an end-to-end build pipeline. Instead, make the system extensible so that external tools can use the compiler for more complex build workflows.

TypeScript would always be doing a poorer job than some other tool, and even recently the core team have regretted their decisions to introduce some errors that would traditionally be linting errors, versus sticking to it knitting of providing a strong typing system for JavaScript.
Other than we would like is there a compelling reason why you are concerned about the linting of transpiled code?  Especially if you are also looking for minification, then linting seems totally illogical and irrelevant for transpiled code.

There's no compelling reason, just the point that we have a JS Style configuration and any generated JS Code should follow this. If this is not planned for TS, then ok - we keep our current build process.
Why is linting illogical and irrelavant for transpiled code in case we minify? I mean, we minify the transpiled file, but save it under another file name. This means we keep the transpiled and linted file. Maybe useful in case the linted file doesn't work as expected and we need to debug for the reason.
As said: It is not a problem for us to keep our build process as it is, I was just thinking about it could make sense to have tsc extended. if that's not desired, no problem.

Maybe useful in case the minified file doesn't work as expected and we need to debug for the reason.

But again, linting it provides what value?  Also, if you are debugging transpiled or minified code, source maps are a far better more logical way to debug code.

I was just thinking about it could make sense to have tsc extended. if that's not desired

I am just a man with his opinions, versus any core team member, just attempting to point out that TypeScript has some very clear design goals.  Given the amount of effort that would have to go into building and maintaining a feature such as this, my personal opinion is there are a lot better places for people to focus their efforts, especially, as you mention, there are already sufficient tools to meet your needs.

But again, linting it provides what value?
At least for readability as all files follow the same rules.

I am just a man with his opinions ... just attempting to point out that TypeScript has some very clear design goals
All fine. I am personally not aware of these goals, so as said: ok to close because of that argumentation. We have our process which we keep using then. Just see this feature request then under pov of not knowing anything about the design goals and thus the idea for this came up.

Thanks for the feedback - very appriciated.


Adding Issue for Lurch task for Week 2 Onboarding task

**lurch: add

@jofsky Lurch only works for repositories in the SalesforceFoundation github org, unfortunately.


Camera troubleshooting

Logs:
1 packets transmitted, 1 received, 0% packet loss, time 0ms
rtt min/avg/max/mdev = 55.381/55.381/55.381/0.000 ms
+++ date
++ echo Wed Feb 9 16:24:59 NZDT 2022
++ echo 'network interface either up or we gave up'
++ echo
++ date
++ /usr/bin/python3 coreScript.py
Traceback (most recent call last):
  File "_ctypes/callbacks.c", line 232, in 'calling callback function'
  File "/home/pi/.local/lib/python3.7/site-packages/picamera/camera.py", line 129, in _control_callback
    "Received unexpected camera control callback event, 0x%08x" % buf[0].cmd)
picamera.exc.PiCameraRuntimeError: Received unexpected camera control callback event, 0x4f525245
Traceback (most recent call last):
  File "_ctypes/callbacks.c", line 232, in 'calling callback function'
  File "/home/pi/.local/lib/python3.7/site-packages/picamera/camera.py", line 129, in _control_callback
    "Received unexpected camera control callback event, 0x%08x" % buf[0].cmd)
picamera.exc.PiCameraRuntimeError: Received unexpected camera control callback event, 0x4f525245
Shutdown scheduled for Wed 2022-02-09 16:27:10 NZDT, use 'shutdown -c' to cancel.
+++ date
++ echo Wed Feb 9 16:26:10 NZDT 2022
++ echo 'startup script finished'

Sometimes seems to get hung up when battery goes flat, and only way to reset it was to disconnect battery and power.


Fix cilium-envoy ServiceMonitor port name

Fixes the ServiceMonitor port so that Prometheus can scrape the service.
Fixes: #27206

FYI. CI breakage is not your fault, its an issue on main we are currently resolving

The issue is now resolved, please rebase on main to fix the CI

@dylandreimerink thanks for the info. I have done the rebase, let's see if the CI part works now.

/test


Any plan to support CMake?

Bazel is too heavy, any plan to support CMake so that we could integrate it to our project.

https://github.com/ObiWahn/tcmalloc-cmake


a bit spell fix in docstring.

fix interrut to interrupt

Thank you!
P.S. I saw your message on the mailing list, but this way (a pull request) is better.  I also have issues replying to that list.


Host Constraints

Can you impliment host constraints as only a few hosts in my cluster have xfs formatted drives.

I was able to get around this by mounting the xfs formatted drives under a unique name and then configured the path_constraint in ceph.conf.


Get the music docs to show up

@ganicke,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


qq: fix update script; 3.2.1-17412 -> 3.2.2-18394

Description of changes
fix update script, bump version

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 267366 run on aarch64-linux 1

1 package built:

qq


correctly describe sample_weight and Reduction.NONE behavior

https://github.com/tensorflow/tensorflow/pull/27784
https://github.com/tensorflow/tensorflow/issues/27190

Fix user e-mail.


logging.properties Error

I'm using Eclipse to run a Google API code. I´m following this link, http://samples.google-api-java-client.googlecode.com/hg/analytics-cmdline-sample/instructions.html
However, when I try to run the code, I get the following message: "Error: Could not find or load the main class (name of my project).logging.properties"
I did some research and discovered that there is a file (/jre/lib/logging.properties) in my Java installation folder.
Should I edit it? If so, how?

This issue may no longer be relevant due to its age. Feel free to re-open.


Adding the test scaffolding.

Depends on https://github.com/huggingface/candle/pull/1309

Looks nice, feel free to merge once the tests actually pass. Do we have some CI coverage for metal?

No coverage, as we don't have any CI setup.
But the default tests do fail quite a bit (mostly lack of kernels like Convolutions, and a few others)


[Runtime] Handle single payload enums in swift_resolve_resilientAcces…

…sors
rdar://109803119
It is sufficient to skip the header, because everything after that are regular ref counts

@swift-ci smoke test

@swift-ci smoke test macos


invalid syntax

failed parse file (1.tbc), error as (strconv.ParseInt: parsing "Mrgm#='BX<<&bS?7J|C+u^sY??IME+'LhTA)#Q)Fv-7hC)#Q)FFngm#a.JTA.?/kB/wJ9>3T": invalid syntax)
1.zip
Any ideas?

@Genii1
Did you solve the problem? Or found a solution?

extend buffer as 2048000, fix this issue
tested on 1.zip file.


16 Puzzle Game Extension

Is your feature request related to a problem? Please describe.
16 this puzzle game, you have a grid with numbered tiles and one empty space. The objective is to slide the tiles around the grid to arrange them in a specific order, usually from lowest to highest number, with the empty space in a designated position (often at the bottom-right corner).

8-Puzzle: A 3x3 grid with 8 numbered tiles (1-8) and one empty space.
16-Puzzle: A 4x4 grid with 15 numbered tiles (1-15) and one empty space.

Game points

Starting Points: 1000
Moves: 45 (45 points deducted)
Time: 7 minutes (35 points deducted)
Bonus: Solved under 50 moves (awarded 50 points)

Additional context
It is not like other puzzle game other puzzle game is following logic of merge 2 and 2 and make 4
and then 8 and then 16
this is different kind of puzzle
i think you have done 8 puzzle Code in DSA it is higer version of it

How do we know when the feature is complete?
i will make PR

Already added 1-2 same extensions on this #245. Kindly raise another Issues

Okay


only four entities

Hey, I have the Data-Plu in my Audi A6 from 2013. All the data is displayed in the app. However, Home Assistant only recognizes 4 entities. Can anyone help me with that?

Can you please provide logs?


Revamp  GhA report

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: daianamezdrea:x: daianadaiana seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


The extension doesn't save more than 4 connections in the workspace

Do you read the FAQ?

[ x] Yes.
[ ] I am going to read now.

Describe the bug
I have created separated connections through sftp.json and placed inside .vs-code folder of each project. Every time I open the Visual Studio Code I have only four connections saved. Others are disappeared and I have to recreate them every time. So boring.
To Reproduce
Steps to reproduce the behavior:

Save more than 4 connection through sftp.json
Close Visual Studio Code
Open Visual Studio Code and see only four connections saved

Expected behavior
I would like to have more than four connections saved.
Desktop (please complete the following information):

OS: [Windows 10}
VSCode Version [e.g. 1.29.1]
Extension Version [e.g. 1.8.0]

Extension Logs from Startup - required
[debug] register command "Cancel All Transfer" from "./commandCancelAllTransfer.ts"
[debug] register command "Config" from "./commandConfig.ts"
[debug] register command "List Active Folder" from "./commandListActiveFolder.ts"
[debug] register command "Open Ssh Connection" from "./commandOpenSshConnection.ts"
[debug] register command "Set Profile" from "./commandSetProfile.ts"
[debug] register command "Toggle Output Panel" from "./commandToggleOutputPanel.ts"
[debug] register command "Upload Changed Files" from "./commandUploadChangedFiles.ts"
[debug] register command "Delete Remote" from "./fileCommandDeleteRemote.ts"
[debug] register command "Diff" from "./fileCommandDiff.ts"
[debug] register command "Diff Active File" from "./fileCommandDiffActiveFile.ts"
[debug] register command "Download" from "./fileCommandDownload.ts"
[debug] register command "Download Active File" from "./fileCommandDownloadActiveFile.ts"
[debug] register command "Download Active Folder" from "./fileCommandDownloadActiveFolder.ts"
[debug] register command "Download File" from "./fileCommandDownloadFile.ts"
[debug] register command "Download Folder" from "./fileCommandDownloadFolder.ts"
[debug] register command "Download Force" from "./fileCommandDownloadForce.ts"
[debug] register command "Download Project" from "./fileCommandDownloadProject.ts"
[debug] register command "Edit In Local" from "./fileCommandEditInLocal.ts"
[debug] register command "List" from "./fileCommandList.ts"
[debug] register command "List All" from "./fileCommandListAll.ts"
[debug] register command "Reveal In Explorer" from "./fileCommandRevealInExplorer.ts"
[debug] register command "Reveal In Remote Explorer" from "./fileCommandRevealInRemoteExplorer.ts"
[debug] register command "Sync Both Directions" from "./fileCommandSyncBothDirections.ts"
[debug] register command "Sync Local To Remote" from "./fileCommandSyncLocalToRemote.ts"
[debug] register command "Sync Remote To Local" from "./fileCommandSyncRemoteToLocal.ts"
[debug] register command "Upload" from "./fileCommandUpload.ts"
[debug] register command "Upload Active File" from "./fileCommandUploadActiveFile.ts"
[debug] register command "Upload Active Folder" from "./fileCommandUploadActiveFolder.ts"
[debug] register command "Upload File" from "./fileCommandUploadFile.ts"
[debug] register command "Upload Folder" from "./fileCommandUploadFolder.ts"
[debug] register command "Upload Force" from "./fileCommandUploadForce.ts"
[debug] register command "Upload Project" from "./fileCommandUploadProject.ts"
[info] config at d:\Google Drive\Krealine\web-ftp\Gp-costruzioni {"remotePath":"/www.gp-costruzioni.it","uploadOnSave":false,"downloadOnOpen":false,"ignore":[],"concurrency":1,"protocol":"ftp","connectTimeout":10000,"interactiveAuth":false,"secure":false,"passive":false,"remoteTimeOffsetInHours":0,"port":21,"name":"Gp Costruzioni","host":"ftp.gp-costruzioni.it","username":"","password":""}
[info] config at d:\odrive\Google Drive AlecssLab\Lavoro\Siti web\Websites\ZadraInterni {"remotePath":"/www.zadrainterni.it","uploadOnSave":false,"downloadOnOpen":false,"ignore":[],"concurrency":1,"protocol":"ftp","connectTimeout":10000,"interactiveAuth":false,"secure":false,"passive":false,"remoteTimeOffsetInHours":0,"port":21,"name":"Zadra Interni","host":"ftp.zadrainterni.it","username":"","password":""}
[info] config at d:\odrive\Google Drive AlecssLab\Staging\development.alecsslab {"remotePath":"/development.alecsslab.com","uploadOnSave":false,"downloadOnOpen":false,"ignore":[],"concurrency":1,"protocol":"ftp","connectTimeout":10000,"interactiveAuth":false,"secure":false,"passive":false,"remoteTimeOffsetInHours":0,"port":21,"name":"Development AleCss Lab","host":"ftp.alecsslab.com","username":"","password":""}
[info] config at d:\odrive\Google Drive AlecssLab\Staging\test.alecss {"remotePath":"/public_html/test","uploadOnSave":false,"downloadOnOpen":false,"ignore":[],"concurrency":1,"protocol":"ftp","connectTimeout":10000,"interactiveAuth":false,"secure":false,"passive":false,"remoteTimeOffsetInHours":0,"port":21,"name":"Test site alecss.it","host":"ftp.alecss.it","username":"","password":""}

The concurrency value is always 1, it is never 4 for me
{"remotePath":"/public_html/test","uploadOnSave":false,"downloadOnOpen":false,"ignore":[],"concurrency":1,"protocol":"ftp","connectTimeout":10000,"interactiveAuth":false,"secure":false,"passive":false,"remoteTimeOffsetInHours":0,"port":21,"name":"Test site alecss.it","host":"ftp.alecss.it","username":"******","password":"******"}

Just as @AleCss81 posted, I am having the save "concurrency":1 all the time and there is actually only 1 connection during each uploading.

@AleCss81 What's the content of your sftp.json?

@minvedacat concurrency is not supported in FTP.

@AleCss81 What's the content of your sftp.json?

@liximomo this is my standard sftp.json content:
{
"name": "Les Gomines",
"protocol": "ftp",
"host": "ftp.xxxxxxx.it",
"port": 21,
"username": "xxxxxxxxx",
"password": "xxxxxxxxx",
"remotePath": "/xxxxxxxxx"
}
For example, this is the fifth connection that sftp extension doesn't save. All the other four connections have the json structured in the same way and they are stored in the SFTP Remote Explorer.
Another json of a stored connection:
{
"name": "Zadra Interni",
"protocol": "ftp",
"host": "ftp.xxxxxxx.it",
"port": 21,
"username": "xxxxxxx",
"password": "xxxxxxx",
"remotePath": "/xxxxxxx"
}

What are the full paths of thees sftp.json files?

@liximomo ok, your question let me discover the problem: after the first four connection, probably for a lack of attention, I've started to use .vs-code folder fon json, instead of .vscode.
Now I have correct this issue and all the connections are stored in remote explorer. Sorry for the bother, thank you for your support.


Do not recommend manual feed of additional hardware prior to upgrades

Issue #, if available:
Description of changes:
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approved

/cherrypick release-0.12


finishing PMID:29432178

I don't see
FYPO:0006444 | abnormal transcriptional response to amino acid starvation
as a descendant of
FYPO:0004064
Ontology | fission_yeast_phenotype
Term name | abnormal transcription during vegetative growth
should I?
also need
FYPO:0006445 + in response to amino acid starvation
FYPO:0006443 + in response to amino acid starvation

[should FYPO:0006444 be] a descendant of FYPO:0004064

Not directly, but I can add a link to abnormal regulation of transcription.

ok,
and from Juan

In the second phenotype of gcn2delta it says 'abnormal regulation of translation in response to nitrogen starvation' - should say 'abnormal regulation of translation in response to AMINO ACID starvation'

so NTR for this too


Use GitFlow

Here's my thinking...
The way the repository is structured at the moment is kind of horrible on my eyes. It needs GITFLOW!
The master branch should always be stable/buildable. Even if it's been dormant for a while, nothing should be pushed directly to master other than hotfixes.
Branches named release/<version number (e.g. release/0.86c) are upcoming releases. These should compile, but aren't required to.
And finally, feature/<feature name> (e.g. feature/physics-modes). These are the branches where lots of things happen, and normal (non-merge) commits should (but don't have to) be pushed to these.
So we could have something like the following:
0 = a commit
master --> 0
I
I   0  <-- new release-1.0 branch
|    I
I    I  0 <-- new feature/a-useful-feature branch
I    I   I
hotfix --> 0   I  0
I  \ I   I
I   0  0 <-- some commits
I    I \ I
I    I  0
I    I /
I    0 <-- merge
I  /
0 <-- 1.0 is now released, so merge into master
The result is a much cleaner workflow. This is just aesthetics and personal opinion, don't take it personally :P

Looks good, closing


Add yarn to the devDependencies

This is needed for running tests and other development tasks.

Yarn should not be a devDependency, as it is the package manager used to install said dependencies. Theoretically we could adapt the npm scripts to work with either npm or yarn, but since the lockfile is in yarn's format, we expect yarn to be installed globally and be used to install dependencies regardless.

Hmm.
Fair enough, but I think in that case I think it should be mentioned explicitly in the contribution guide (https://kafka.js.org/docs/development-environment / https://kafka.js.org/docs/contribution-guide). Note that apart from running the tests I didn't have any other issues, so I guess with a caveat of "you know what you're doing" either a global or local install will work -- but maybe for the "canonical" environment then the guide could add this to the TL;DR (npm install -g yarn) and a short note on the development-environment that this project is "... developed with the yarn package manager". WDYT?

Yeah that sounds reasonable. I think it could go in the same spot where we currently say that docker and docker-compose need to be installed.

When developing KafkaJS, we run a Kafka cluster in a similar way to what is described in Running Kafka in Development, using docker and docker-compose. Before you proceed, make sure that you have both docker and docker-compose available.


Error link in DaemonSet page

Doc page: Perform a Rolling Update on a DaemonSet https://kubernetes.io/docs/tasks/manage-daemon/update-daemon-set/#performing-a-rolling-update
It incorrectly links to Deployment page for DaemonSet API fields.
Also , the field should be .spec.updateStrategy.rollingUpdate.maxSurge instead of .spec.maxSurge

Both Daemonset and Deployment use the fields MaxUnavailable and MaxSurge of the RollingUpdateDaemonSet structure, so the explanation of the link to the deployment field is not wrong, it's just a bit misleading.
Of course, I think the best way is to describe these fields on a page so that the daemonset and deployment refer to them, rather than linking directly to the deployment page from the daemonset page.

Also , the field should be .spec.updateStrategy.rollingUpdate.maxSurge instead of .spec.maxSurge

I think you are right. correct identification: .spec.updateStrategy.rollingUpdate.maxSurge

We could link to https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#DaemonSetSpec (and provide context for that link), instead of linking to the Deployment concept.

(and provide context for that link)

How to understand this sentence? How to do?  I'm not clear.

/triage accepted
/good-first-issue

/remove help-wanted

hello @mehabhalodiya I would love to work on this as I m new could u please guide me as what I understood is a link needs to be changed

Hello @mehabhalodiya @anubha-v-ardhan I would like to contribute to it can you assign this issue to me
Thank you !!

Hey @889-dj @Anubhavdevv
Glad to hear that you are willing to work on this! 🎉
But it is fixed here:

#31354

If you are interested to work on another good first issue let me know how can I help you.
Thank you 🙂

Sure @mehabhalodiya it would be great if you mentioned some good first issue so that I can contribute 🙂

/assign @MdSahil-oss

@MdSahil-oss Can you please assign this issue to yourself with /assign @MdSahil-oss here?

Hey @889-dj @Anubhavdevv Glad to hear that you are willing to work on this! 🎉 But it is fixed here:

Update update-daemon-set.md #31354

If you are interested to work on another good first issue let me know how can I help you. Thank you 🙂

Thanku Meha I will surely look for other issues 🙂

/assign

hey @janetkuo i will like to work on this issue , i am just a beginner in open source so can you guide me regarding what needs to be done for the link leading to deployment page and does field .spec.maxSurge still needs to be updated?

This issue is fixed #31407.
/close


Release 1.2.4

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6237aa7) 88.49% compared to head (3c66dbd) 88.49%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##               main      #32   +/-   ##
=========================================
  Coverage     88.49%   88.49%
  Complexity      604      604
=========================================
  Files           105      105
  Lines           939      939
  Branches         27       27
=========================================
  Hits            831      831
  Misses           65       65
  Partials         43       43

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Reset fields look states when disabled.

When a Text control is disabled reset the colour's back to the original as error's should no longer display.
TP: https://rockabox.tpondemand.com/entity/12519

Can be merged for QA

:+1: Looks fine


feat: set default admin password in restricted dev

Checklist

[X] I have read the coding guide

Description
To improve the experience of the developers the dev mode has a default admin password when ran in restricted mode.

This change is

Looks good!

Don't we want to bypass this in the dev mode instead of having a default password?

Don't we want to bypass this in the dev mode instead of having a default password?

my understanding is that the JS team want a default password value to make it easier to develop in dev mode.

@notanatol is this documented somewhere?

no, it's not.
I totally missed it, where would be a good place to put it?

As far as I know currently the dev mode is completely missing from the documentation.
Here is an issue about it, opened by @AuHau :)
https://github.com/ethersphere/bee-docs/issues/240


Update reaction-force exports

As discussed in https://github.com/artsy/force/pull/1492 , some more exports to make it easier to initialize reaction-force components in force

Actually, hold on merging, gonna feature creep this PR and add some quick styling updates to the gene components

LGTM 👍


Some feedback ref Chap 9

@terrytangyuan , as mentioned, for those looking to run the workflow.yaml end-to-end, there were a few infrastructure-related elements introduced in Chap 8 that might be worth recapping at the beginning of Chap 9, so as to ensure that someone focusing on that chapter has the possibility to run things. While you capture certain things in the sub README's on the repo, I have found that sometimes these aren't reflected back in the book .. when they probably should be.

cluster creation using k3d: per Chap 8 listing 8.21  k3d cluster create distml --image v1.25.3+k3s1 .... I think you need the 'rancher' part too for this to work k3d cluster create distml --image rancher/k3s:v1.25.3-k3s1.
creation of various kubeflow-related resource per 8.31 and 8.32. If I'm not mistaken, some of the service-accounts, roles and CRDs in distributed-ml-patterns/code/project/manifests/kubeflow-training are presumed to be in-place for Chap 9. I would maybe stick to using kubectl and not have expectations on readers to install other short-cut tooling like kns to work with their cluster.

kubectl create ns kubeflow
kubectl config set-context --current --namespace=kubeflow
kubectl kustomize manifests | kubectl apply -f -

in listing 9.13, it may be worth explicitly adding the 'kubeflow' namespace, as the workflow won't work otherwise, based on my own experimentation.

kubectl create -n kubeflow -f multi-worker-pvc.yaml

what exactly is happening in listing 9.20? ... maybe I'm missing something here, but a more explicit explanation in the context of understanding how this is being used for inferencing here would be great.
For the inference-service in 9.21, this gets replaced by an extended version in 9.28. Should the first one be explicitly deleted before the next one is created? In 9.37, the simpler version (9.21) without scaleTarget and scaleMetric is included as a manifest in the workflow. Is this intentional?
section 9.4.2 deals with step memoization ... I realise the dataset used for ingestion is a fixed fashion-MNIST and so it doesn't change. It would be great to see an example where that data is changed/augmented and have that trigger a training/model-selection re-run. Maybe the data ingestion can push to a Minio bucket and then Argo Events is used to detect changes to the bucket. That's probably beyond scope at this point.
while there is a reference to port-forwarding the argo-workflows service, I think it would benefit from a more explicit write-up of how to login. I found I ended up having to create my own user with the requisite cluster permissions to be able to get the UI working.
I saw some references in the code to an image for training-operator at public.ecr.aws/j1r0q0g6/training/training-operator, but also at https://github.com/orgs/kubeflow/packages/container/package/training%2Ftraining-operator. These are discussed here. It might be worth explicitly mentioning where the canonical source will be, going forward.

Overall, kudos for assembling this book and especially the end-to-end workflow in Chap 9. It offers a great blue-print for handling something 'real-world', which is rare to have in these sorts of text-books.
Best, Colum

cluster creation using k3d: per Chap 8 listing 8.21 k3d cluster create distml --image v1.25.3+k3s1 .... I think you need the 'rancher' part too for this to work k3d cluster create distml --image rancher/k3s:v1.25.3-k3s1.

This will be fixed in a new version.

what exactly is happening in listing 9.20? ... maybe I'm missing something here, but a more explicit explanation in the context of understanding how this is being used for inferencing here would be great.

It's a bit beyond the scope of this book so I tried to avoid too much details.

For the inference-service in 9.21, this gets replaced by an extended version in 9.28. Should the first one be explicitly deleted before the next one is created? In 9.37, the simpler version (9.21) without scaleTarget and scaleMetric is included as a manifest in the workflow. Is this intentional?

I only see it in Listing 9.28. I think it's fixed already.

I saw some references in the code to an image for training-operator at public.ecr.aws/j1r0q0g6/training/training-operator

Where do you see those references?
Thank you for your feedback! It might be too late to update the content but we'll try get smaller fixes in before publication.

Reference to training-operator is in distributed-ml-patterns/code/project/manifests/kubeflow-training/kustomization.yaml.  Added a few typos to that Manning Live Book facility ... which perhaps have also been addressed since version 7.

Will close this out now. Hope the book does well!

Thank you!


"bosh micro deploy" does not target the new bosh as it says it does

$ bosh micro deploy firstbosh/last_successful_micro-bosh-stemcell-openstack.tgz
...
Deploy Micro BOSH
  unpacking stemcell (00:00:04)
  uploading stemcell (00:00:20)
  creating VM from 1718309a-e5b2-4be3-826f-c4e70bcd5ae0 (00:00:33)
  waiting for the agent (00:01:17)
  mount disk (00:00:03)
  stopping agent services (00:00:01)
  applying micro BOSH spec (00:00:15)
  starting agent services (00:00:00)
  waiting for the director (00:00:11)
Done                    11/11 00:02:51
WARNING! Your target has been changed to `https://<IP_ADDRESS>:25555'!

But when I attempt to use it:
$ bosh status
Config
             /home/stack/.bosh_config

Director
  timed out fetching director status

When I explicitly target:
$ bosh target <IP_ADDRESS>
Target set to `firstbosh'
$ bosh status
Config
             /home/stack/.bosh_config

Director
  Name       firstbosh
  URL        https://<IP_ADDRESS>:25555
  Version    1.5.0.pre.703 (release:a8e65cc1 bosh:a8e65cc1)
  User       drnic
  UUID       cd8ba3d3-f04b-4cff-b5af-47d3281316f6
  CPI        openstack
  dns        enabled (domain_name: microbosh)
  compiled_package_cache disabled

Closing in favor of using bosh-init.


Share prompts for other zeroshot eval datasets?

Thank you for providing the prompt engineering file for the ImageNet here
I am curious if you are willing to share the prompts for one other datasets used for the Zeroshot Eval results shown in the paper? I was able to reproduce the ImageNet zero shot eval results but unable to reproduce other results. The zeroshot eval top1 accuracy is 3 to 8 percentages off for the Food101 dataset (show below). This is with the prompt suggested by the paper: "a photo of a {}, a type of food." Curious if you are using an ensemble of prompts to report the results? If so, could you share the ensemble of prompts for one of those datasets?
ours / reported in paper
ViT/B-32: 81.4812  / 84.4
ResNet50: 73.0099 / 81.1
ResNet101: 75.9644 / 83.9
ResNet50x4: 80.4753 / 86.8

The prompts can now be found at https://github.com/openai/CLIP/blob/main/data/prompts.md