Make Configurables more configurable

Is your feature request related to a problem? Please describe.
currently everything is hardcoded and in just two files which can be very annoying when for example european ducks should use different RF parameters.
Describe the solution you'd like
i would like to move the currently hardcoded configurables out of the cdp library code.
as step one, just replace them all by CDP_something defines that go into a separate cdp-config.h in the same dir.
while this is not a longterm-best solution, it is one that is really low effort and unlikely to break anything and already solves the "i commited the wrong frequency/pinout by accident" issue.
this also bundles all configurables in one place which is a good step towards making them actualy configurable.
next step could be to move some of them into even more separate .h files to keep pinout specs for different boards or sensor loadouts or deployment-specific wifi setups in one place each.
this also makes it more obvious which parts could be useful to have runtime-configurable.
Describe alternatives you've considered
there is certainly potential to use an "if xml is not solving your problem, you are not using enough of it" approach.
but i dont see any way to make it as low-effort, gradual and "as needed" scalable.
the define-and-refine way also leaves all options open for runtime-config-storage later, so we can see what works best when we get there.
Additional context
candidates, grouped by "dynamic range":

unlikely to change in a dynamic way

hardware details (pinout)

hardware presence (do we need to init display, powerchip, vext,...)

unlikely to ever change within a deployment

RF parameters (radio type, frequency, bandwidth, spreadfactor, coding,...)

timings (sensor frequency, alivequacks,...)

more likely to change

wifi details (both papaduck-uplink and allducks-AP)

password(s) (config page, wifi,...)

this change will be all over the cdp codebase for the first step, so will have maximal merge-conflict potential there. otoh, that first step is 1-3 hours max.
i would like to get an OK for this from @nfeuer and suggest we coordinate a suitable timeslot (where no one else has major changes open) on slack.
after that first step, the potential for merge conflicts is greatly reduced, so any additional steps (like adding the definition for another board) should require almost no coordination.

the defines from arduino env for the different lora board types i have here:
-DARDUINO_T-Beam -DARDUINO_ARCH_ESP32 "-DARDUINO_BOARD=\"T-Beam\"" "-DARDUINO_VARIANT=\"t-beam\"" -DESP32

-DARDUINO_HELTEC_WIFI_LORA_32_V2 -DARDUINO_ARCH_ESP32 "-DARDUINO_BOARD=\"HELTEC_WIFI_LORA_32_V2\"" "-DARDUINO_VARIANT=\"heltec_wifi_lora_32_V2\"" -DESP32

-DARDUINO_AVR_FEATHER32U4 -DARDUINO_ARCH_AVR

-DARDUINO_TTGO_LoRa32_V1 -DARDUINO_ARCH_ESP32 "-DARDUINO_BOARD=\"TTGO_LoRa32_V1\"" "-DARDUINO_VARIANT=\"ttgo-lora32-v1\"" -DESP32

this covers most pinout-ifdef needs.
it does not help at figuring out whether the given t-beam has a axp192 or not.

segmenting this into iterations that are "sprint sized" and result in a "working PR" after each round:

replace hardcoded parts by defines ... see https://github.com/Code-and-Response/ClusterDuck-Protocol/pull/71
add https://github.com/Code-and-Response/ClusterDuck-Protocol/issues/52 so users can disable debug chatter on the serial (without removing all the debugprints we might need again the next time we have a memory leak hunt)
add an include-if-present cdpcfg-user.h (so users can override f.ex.RF LORA params)
define board-specific blocks ... for https://github.com/Code-and-Response/ClusterDuck-Protocol/issues/62 and/or https://github.com/Code-and-Response/ClusterDuck-Protocol/issues/68
turn parts that should be runtime-configurable into nvs-backed config that defaults to the defined values

OOP has been implemented extensively as well as expanded our config file. This makes it a lot easier to make things more configurable. Some of these items have not been completed yet but should be broken out into their own issues.

OOP has been implemented extensively as well as expanded our config file. This makes it a lot easier to make things more configurable. Some of these items have not been completed yet but should be broken out into their own issues.


Azure Terraform Installer Support

Adds support for Azure via Terraform
Closes Issue #62

Now it's my turn to apologize for the delay. In addition to the minor updates I pushed, I also made a Fermyon Azure Quickstart to match the Fermyon AWS Quickstart. The video is currently unlisted on my channel, but happy to upload to a location of choice for the Fermyon channel.

Thank you @vdice! Bumped spin and added the video to the readme. I will also make the video fully public (was unlisted before pending Fermyon's approval). Happy to also contribute to a dedicated Azure Quick Start doc for the https://www.fermyon.dev/ site!

Excellent, thanks again @jldeen!


Release libstd-like things (alloc, panic, etc.)

Closing this as this is moved to https://github.com/mobilecoinfoundation/sgx-std


Change to .update() in 0.8.0?

In our Terrascript 0.6.1 scripts, we have a bunch of functions that define pieces of the configuration, and we assemble them like this:
ts = terrascript.Terrascript()
ts += terrascript.terraform(
  backend = terrascript.backend(
    "s3",
    **config['backend']['s3']
    )
  )
ts.update(tsumami.provider.define(config))
ts.update(tsumami.s3.define(config))
ts.update(tsumami.security_groups.define(config))

where config is a dict based on a collection of YAML config files.
Each of those functions looks like this:
def define(config):
  my_ts = terrascript.Terrascript()
  if 's3-bucket' in config:
    for (resource, data) in config['s3-bucket'].items():
      # code that does various things
      my_ts += terrascript.resource.aws.aws_s3_bucket(
        resource,
        bucket = bucketname,
        **data
        )
  return(my_ts)

That used to work in 0.6.1, but doesn't in 0.8.0; it seems that each ts.update(something) replaces the previous one, and only the last one ends up in the config when we write out str(ts) at the end.
What's the right way to do this in 0.8.0?

Hi Josh, I always feared that I would break something in 0.8.0. I am going to investigate this later today.

Hi Josh, sorry for the delay. I don't have a solution yet but can at least offer a detailed analysis:
https://github.com/mjuenema/python-terrascript/blob/issue98/docs/issues/098.ipynb (I hope the link works)

Like this https://gist.github.com/angstwad/bf22d1822c38a92ec0a9 ?

And added an idea for a possible solution.

Thanks! Also, if this pattern isn't recommended at this point, it wouldn't be hard to change our script to do something else. We like being able to create multiple Terrascript objects and merge them together, but we could potentially do something else.

As it used to work I should probably retain the feature. I have no opinion how Terrascript is meant to be used the right way.

Josh, can you please verify whether the update() implementation in branch issue98 would fix your problem.

Looks good! At least so far -- I've updated a bunch of our modules, enough to get one of our environments to complete successfully, and all it says now is
+$ git diff -U1 tsumami.tf.json
diff --git a/analytics-gold-useast1/misc/tsumami.tf.json b/analytics-gold-useast1/misc/tsumami.tf.json
index 8f7a142..5ba0be7 100644
--- a/analytics-gold-useast1/misc/tsumami.tf.json
+++ b/analytics-gold-useast1/misc/tsumami.tf.json
@@ -2,4 +2,4 @@
   "provider": {
-    "aws": {
-      "__DEFAULT__": {
+    "aws": [
+      {
         "assume_role": {
@@ -11,3 +11,3 @@
       },
-      "us-east-1": {
+      {
         "alias": "us-east-1",
@@ -20,3 +20,3 @@
       }
-    }
+    ]
   },

which I think is expected! (And before it was missing lots of stuff.)

I've now updated all of our modules, and everything seems to work, and the only changes in the JSON file are like the ones I pasted above. (All this trouble for that little change? Sheesh. :^ )
Looking forward to a 0.8.1 release!

Good, i got the __iter__() method out of it as a side-effect :-)


Added Portuguese Translation to 1.18.2 Branch

Not sure if you're still maintaining this branch, but I added the translation to this branch as well, just in case.

Not sure if you're still maintaining this branch, but I added the translation to this branch as well, just in case.

Yep, haven't really maintained it but I'll accept it in case I decide to do so in the future


number: format numbers faster

Coverage decreased (-0.2%) to 99.766% when pulling 381db37f41e1cc0b4d6bb279c25ae85e1b81568d on omsmith:number-perf into 917afd1c7c883bca274515760d0a102e65edcb2b on Brightspace:master.

~2x faster across all browsers

Removed the code-path without coverage, since it's can't actually occur it turns out

Coverage remained the same at 100.0% when pulling eb1a3974644fab8267aa1607ca9f20b835e266d2 on omsmith:number-perf into 917afd1c7c883bca274515760d0a102e65edcb2b on Brightspace:master.

Coverage remained the same at 100.0% when pulling 4c549d4e13022d4ce244cf81c5dc917f128cbbd4 on omsmith:number-perf into 917afd1c7c883bca274515760d0a102e65edcb2b on Brightspace:master.

Coverage remained the same at 100.0% when pulling 6a4f87f192e573ada56ce30e14a0497c69148f36 on omsmith:number-perf into 917afd1c7c883bca274515760d0a102e65edcb2b on Brightspace:master.

Neat! I like 2x faster!


split vertebral, cardiac, renal, and limb defects syndrome 1

closes #1804

closing this, re-did the pr here: https://github.com/monarch-initiative/mondo/pull/1845


Feature Request: Support progressive JPEG file type

I am serving images from AWS S3, the following mime-type is not supported out of the box for AlamofireImage (2.4.1):
image/pjpeg
I am using af_setImageWithURL() with a single NSURL argument.
I am currently using the workaround:
Alamofire.Request.addAcceptableImageContentTypes(["image/pjpeg"])
(which works fine for me)
I could not tell how standard the pjpeg MIME type is. If nonstandard, please close this request.

Hi @speedy99,
AFI currently does not have any direct support for progressive JPEGs. I've added it to our Trello backlog, but it's not high on our priority list.
Adding the image/pjpeg content type to the list of acceptable content types is what you should do for now. Please keep in mind though that this will not actually perform any progressive rendering. It will just load all the data into a UIImage. If you need progressive display, then I'd recommend checking out something like Concorde.
Cheers. 🍻

Hi @cnoon any update on this?


RND server boards

About the PR

Makes the R&D server constructible and adds a board.
The board isn't obtainable besides just deconstructing the roundstart server
Please don't change that willy-nilly.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

add: The R&D server can be deconstructed. Be warned: this resets all unlocked technology, points, and the current discipline.

so in other words we can now reroll trees so 1. get a telepad 2. get a few bags of holding 3. get cloner 4. uhhhh whats industrial

so in other words we can now reroll trees so 1. get a telepad 2. get a few bags of holding 3. get cloner 4. uhhhh whats industrial

yes. The balancing factors of this specific change are:

you cannot have them simultaneously
you have to research each from the beginning
you discard any points you had on the server

I think this is more than fair, especially if there's a situation where Sci might need to unexpectedly pivot to another discipline.

This change is good, but it permanently kills the discs. After the change, they cannot be used for research because of the duplicates. Getting t3 with them will just become a pointless roulette, too expensive to spin with the long and costly but reliable method of resetting the server.

This change is good, but it permanently kills the discs. After the change, they cannot be used for research because of the duplicates. Getting t3 with them will just become a pointless roulette, too expensive to spin with the long and costly but reliable method of resetting the server.

a few benefits to consider about using disks over resetting:

you don't have to re-unlock t1/t2 technologies (which would probably be more expensive than the printing)
disks can be acquired without having to get permission from the RD to reset the server.

I think that having these as options is fairly balanced.


Speed up OptMergePass by 1.7x.

The main speedup comes from swithing from using a SHA1 hash to std::hash<std::string>. There is no need to use an expensive cryptographic hash for fingerprinting in this context.
Flamegraph of benchmark timings from synthesis of a representative circuit:
Before:

After:

You could probably use an even cheaper hash than SHA1.

@Ravenslofty is there a setting to auto-squash my commits here? I noticed my commits didn't get squashed for the PRs you merged yesterday.

There is, but I have the habit of "rebase and merge" to not lose history; if you want your commits squashed I can do that with my next merge.

Btw @Ravenslofty we were discussing in the dev JF that doing merge commits is better since they have the PR number, which is otherwise lost.

OK, I'll leave that up to you. I'm just used to us squashing for Eigen.

FWIW squash commits should have the PR number and are ok too, it's just the rebase that loses it.

PTAL

Yeah, this looks much better.

I just ran the measurements again, and it actually ended up slightly faster too. Go figure... :-)


[Event Request] Codeunit 6620 Copy Document Mgt. - procedure CopyArchSalesLine - OnAfterCalcShouldRecalculateAmount

Please add the following Event OnAfterCalcShouldRecalculateAmount to Procedure CopyArchSalesLine in Codeunit 6620 Copy Document Mgt.
[Event Request] Codeunit 6620 Copy Document Mgt. - procedure CopyArchSalesLine
var
    ToSalesLine2: Record "Sales Line";
    VATPostingSetup: Record "VAT Posting Setup";
    FromSalesHeader: Record "Sales Header";
    FromSalesLine: Record "Sales Line";
    CopyThisLine: Boolean;
    IsHandled: Boolean;
    ShouldRecalculateAmount: Boolean;
begin
    CopyThisLine := true;
    OnBeforeCopyArchSalesLine(ToSalesHeader, FromSalesHeaderArchive, FromSalesLineArchive, RecalculateLines, CopyThisLine);
    if not CopyThisLine then begin
        LinesNotCopied := LinesNotCopied + 1;
        exit(false);
    end;
    ...
    ShouldRecalculateAmount := ExactCostRevMandatory and
        (FromSalesLineArchive.Type = FromSalesLineArchive.Type::Item) and
        (FromSalesLineArchive."Appl.-from Item Entry" <> 0) and
        not MoveNegLines;  // <-- ADDED (original condition set to new variable)
    OnAfterCalcShouldRecalculateAmount(ToSalesLine, FromSalesLineArchive, ShouldRecalculateAmount); // <-- NEW EVENT
    if ShouldRecalculateAmount then begin // <-- ADDED

        if RecalculateAmount then begin
            ToSalesLine.Validate("Unit Price", FromSalesLineArchive."Unit Price");
    ...

[IntegrationEvent(false,false)]
local procedure OnAfterCalcShouldRecalculateAmount(var ToSalesLine: Record "Sales Line"; FromSalesLineArchive: Record "Sales Line Archive"; var ShouldRecalculateAmount: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10804.


BadDet Regional Misclassification Attack Implementation

Description
Implementation of the BadDet Regional Misclassification Attack. This creates a new poisoning object art.attacks.poisoning.BadDetRegionalMisclassificationAttack which is can be used to generate poisoned samples. Since this is the first poisoning attack on object detector models, a new abstract class art.attacks.attack.PoisoningAttackObjectDetector was created which will serve as the base for all future poisoning attacks on object detectors.
Additionally, a demo notebook notebooks/poisoning_attack_bad_det_rma.ipynb was created to demonstrate how to use the attack.
Paper link: https://arxiv.org/abs/2205.14497
This is a partial implementation of #2038 as the other three attacks need to also be implemented.
Type of change
Please check all relevant options.

[ ] Improvement (non-breaking)
[ ] Bug fix (non-breaking)
[x] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

[x] Tests for BadDetRegionalMisclassificationAttack which are framework agnostic

Test Configuration:

OS
Python version
ART version or commit number
TensorFlow / Keras / PyTorch / MXNet version

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Codecov Report

Merging #2054 (43869f1) into dev_1.14.0 (221a641) will decrease coverage by 53.38%.
The diff coverage is 34.84%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@               Coverage Diff               @@
##           dev_1.14.0    #2054       +/-   ##
===============================================
- Coverage       84.74%   31.36%   -53.38%
===============================================
  Files             291      292        +1
  Lines           25564    25628       +64
  Branches         4621     4632       +11
===============================================
- Hits            21663     8038    -13625
- Misses           2762    17254    +14492
+ Partials         1139      336      -803

Impacted Files
Coverage Δ

art/attacks/poisoning/bad_det/bad_det_rma.py
26.31% <26.31%> (ø)

art/attacks/attack.py
77.85% <83.33%> (-14.74%)
:arrow_down:

art/attacks/__init__.py
100.00% <100.00%> (ø)

art/attacks/poisoning/__init__.py
100.00% <100.00%> (ø)

art/evaluations/evaluation.py
0.00% <0.00%> (-100.00%)
:arrow_down:

art/evaluations/security_curve/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

art/attacks/poisoning/perturbations/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

...essing/expectation_over_transformation/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

...rmation/natural_corruptions/contrast/tensorflow.py
0.00% <0.00%> (-100.00%)
:arrow_down:

...formation/natural_corruptions/zoom_blur/pytorch.py
0.00% <0.00%> (-93.94%)
:arrow_down:

... and 209 more


Fix #40 by using different linking flags depending on rustc version

As suggested in the issue by petrochenkov.

I can confirm this change fixes it on Windows, nice PR :) would be awesome if the maintainer could publish it.

@mxre Can you merge this and publish a new version?


bundle java connector library

Make java a recommended dependency
Download connector library in the formula
Let risingwave binary correctly discover the library

Closed by #32.


Make inspector whitespace more themable

Some tweaks to make it easier to establish visual hierarchy in the inspector:

Before
After

Takes the content margins of EditorInspectorCategory/styles/bg into account when calculating EditorInspectorCategory min height to allow independent padding inside of it. It was only controllable through Tree v_separation, making it impossible to set independently from all of the trees in the editor
Exposes EditorInspector main vbox separation to theming to allow space between inspector categories and sections
Makes horizontal spacing of EditorInspectorSection themable (space between the arrow and the text)
Ensures that text is vertically centered in categories and sections (with floor() they were 1px shy, you can notice if you look real close at those category sections on the left picture)

Note: when using vertical separation there's double separation below some node categories (like Node and Node3D) because there's a 0-height vbox hidden in there (not yet sure what it's for, probably some warning). I think VBoxContainer shouldn't do separation between 0-size controls, this is perhaps something to fix in a future PR
I also want to make section backgrounds themable to support rounded corners but they are drawn immediately through draw_rect because they're using different alphas depending on the nesting level. Maybe I should generate 5-6 stylebox variations for different levels. Something for a future PR as well

This makes the section headers bigger in the default theme. Is this intentional?
It does not look bad, but it takes more space.

I think VBoxContainer shouldn't do separation between 0-size controls

Nah, it's fine like that. If you don't want separation, the Control should be hidden.

This makes the section headers bigger in the default theme. Is this intentional?
Not intentional, will fix

I'd call it "spacing" and not "whitespace" as this doesn't affect label or other text whitespace, so "spacing" or "separation" would be a less confusing naming IMO

meant whitespace as it'd be used in design to refer to empty space, but I understand how it can be confusing

Thanks!


Uncaught exception when DNS resolution fails

Aug 27 04:30:17 nodered[91277]: openWebSocket.js: Reconnecting...
Aug 27 04:30:22 nodered[91277]: 27 Aug 08:30:22 - [red] Uncaught Exception:
Aug 27 04:30:22 nodered[91277]: 27 Aug 08:30:22 - [error] FetchError: request to https://us-api.coolkit.cc:8080/api/user/login failed, reason>
Aug 27 04:30:22 nodered[91277]:     at ClientRequest.<anonymous> (/data/node_modules/ewelink-api/node_modules/node-fetch/lib/index.js:1491:11)
Aug 27 04:30:22 nodered[91277]:     at ClientRequest.emit (node:events:527:28)
Aug 27 04:30:22 nodered[91277]:     at TLSSocket.socketErrorListener (node:_http_client:454:9)
Aug 27 04:30:22 nodered[91277]:     at TLSSocket.emit (node:events:527:28)
Aug 27 04:30:22 nodered[91277]:     at emitErrorNT (node:internal/streams/destroy:157:8)
Aug 27 04:30:22 nodered[91277]:     at emitErrorCloseNT (node:internal/streams/destroy:122:3)
Aug 27 04:30:22 nodered[91277]:     at processTicksAndRejections (node:internal/process/task_queues:83:21)
Aug 27 04:30:22 podman[115215]: 2022-08-27 04:30:22.957355225 -0400 EDT m=+0.355075954 container remove de0c4c4c8274f9d7628ab76c8789d0a3b054a>
Aug 27 04:30:22 systemd[1]: container-nodered.service: Main process exited, code=exited, status=1/FAILURE

Opening this as a new issue on the package b/c the issue with the proximally-failing code is closed.  (See discussed-not-committed) patch suggested by @LiYuanBR (https://github.com/LiYuanBr) at https://github.com/skydiver/ewelink-api/issues/65#issuecomment-1226180143.  Their reconnection attempt in the catch block can ITSELF fail (in my case b/c DNS server failed), and when it does any exceptions are unhandled.
I've exactly zero javascript experience, so I'm loathe to propose an implementation, but think the wssLoginPayload() call needs to be wrapped in its own try-catch block which simply logs the exception and retries.  I'm happy to help further diagnose / test proposed patches.  If my fooling around with it produces something potentially useful, I'll post it here.

@johnjmikucki
Check #187 , and download my fork, as I don't know if they will merge it and get it updated.
I implemented the fix in #65 as @LiYuanBr suggested.
Hope it helps.


Simplify the log_write macro

No changes required apart from the log module itself.

I have added a benchmark that you can run on your computer (https://github.com/metacall/core/commit/5a254055e86797cd32778f91597dc9537355a201):
cmake -DOPTION_BUILD_BENCHMARKS=on ..
make log-bench
ctest -VV -R log-bench

The current implementation of the log_write macro detects if there is any parameter at compile time in order to use printf like formatting. In the case of not having any extra parameter for formatting it calls log_write_impl, otherwise it calls log_write_impl_va. Using va_list when there is no any extra parameter is slow, and that is my point of using that macro.
Here are my results (I have a slow PC and they are compiled with Asan, so it may differ):
115: ----------------------------------------------------------------------------------------------------
115: Benchmark                                                             Time           CPU Iterations
115: ----------------------------------------------------------------------------------------------------
115: log_bench/call_macro/iterations:1/repeats:3/threads:1               821 ms        815 ms          1    11.985k items/s Log Benchmark - Call Macro
115: log_bench/call_macro/iterations:1/repeats:3/threads:1              1945 ms       1937 ms          1   5.04154k items/s Log Benchmark - Call Macro
115: log_bench/call_macro/iterations:1/repeats:3/threads:1              3134 ms       3120 ms          1   3.13039k items/s Log Benchmark - Call Macro
115: log_bench/call_macro/iterations:1/repeats:3/threads:1_mean         1967 ms       1957 ms          1   6.71899k items/s Log Benchmark - Call Macro
115: log_bench/call_macro/iterations:1/repeats:3/threads:1_median       1945 ms       1937 ms          1   5.04154k items/s Log Benchmark - Call Macro
115: log_bench/call_macro/iterations:1/repeats:3/threads:1_stddev       1157 ms       1153 ms          1   4.65956k items/s Log Benchmark - Call Macro
115: log_bench/call_va/iterations:1/repeats:3/threads:1                 4580 ms       4550 ms          1   2.14623k items/s Log Benchmark - Call Variadic
115: log_bench/call_va/iterations:1/repeats:3/threads:1                 6335 ms       6298 ms          1   1.55049k items/s Log Benchmark - Call Variadic
115: log_bench/call_va/iterations:1/repeats:3/threads:1                 8432 ms       8389 ms          1   1.16412k items/s Log Benchmark - Call Variadic
115: log_bench/call_va/iterations:1/repeats:3/threads:1_mean            6449 ms       6412 ms          1   1.62028k items/s Log Benchmark - Call Variadic
115: log_bench/call_va/iterations:1/repeats:3/threads:1_median          6335 ms       6298 ms          1   1.55049k items/s Log Benchmark - Call Variadic
115: log_bench/call_va/iterations:1/repeats:3/threads:1_stddev          1929 ms       1922 ms          1    506.637 items/s Log Benchmark - Call Variadic

I cannot merge this if it is going to be slower (because apparently in your change you are going to use always log_write_impl_va).
A good improvement to the log can be providing a log macro without variadic arguments that can be exported easily to other languages (i.e without using va_list), because this is implementation dependent and breaks the ABI usually (and this is a very important concern in this project). This solution could be implemented with an array of pointers instead of va_list and may solve problems like this: https://github.com/metacall/core/blob/5a254055e86797cd32778f91597dc9537355a201/source/loaders/cr_loader/crystal/metacall.cr#L27
Thanks anyway for your contribution! Feel free to create an issue first if you want to discuss something, it is usually better to talk about it before start implementing things.


Fixed in-place operators "+=" and "-=".

Importing C++ in-place operators "+-" and "-=" currently fail with "Overloading operator [...] not yet supported.". Just adding them to the supported_overloaded_operators seems to fix that and seems to be working fine.

This almost certainly needs some tests added https://github.com/cython/cython/blob/master/tests/run/cpp_operators.pyx (and maybe https://github.com/cython/cython/blob/master/tests/run/cpp_operator_exc_handling.pyx too?).
It'd probably also make sense to do *= and /= at the same time.

Thanks for the remarks. I will try to do both (tests + other operators), but if somebody else with more experience wants to do it I don't mind.


Add set_attribute function

This PR:

Adds a function set_attribute to OpenTelemetrySpanExt to allow setting attributes directly on the OpenTelemetry SpanBuilder.

This allows users to set more than the tracing maximum of 32 fields.
There was a workaround I came up with without using the function involving wrapping the Registry in an Arc and accessing OtelData directly, but that led to this bug in tracing-subscriber.

The 32 field maximum has also been fix over in tracing https://github.com/tokio-rs/tracing/pull/2508


Readme: fix typo

The name of the package in the suggested opam pin invocation was incorrect.

Thanks!


Shell Script to Automate Installation

I was thinking of creating a shell script which will handle the entire installation process with proper error handling. What do you think?

i already have a docker container that does that

:trolley:

:trolley:

@Atakku Why don't you link it then? People don't have to waste time copy pasting commands and changing  entries.

@Atakku Why don't you link it then? People don't have to waste time copy pasting commands and changing entries.

https://github.com/cmyui/gulag/issues/82#issuecomment-822758515

Hey, overall I don't think it's really a big concern since most people just set their servers up a single time, but I'd be alright with merging a bash script in provided it's decent :D.. I'd actually prefer it over a docker container just for simplicity, but setting up a new instance of gulag usually only takes me 10-15minutes; it should be much easier than pretty much any other implementation out there since it uses pretty modern dependencies.

Based on your comment. I'm leaving it here, not worth my time.


[Feature]: support to Jira versions

Describe the feature
We would need that the agent handles versions events triggered by Jira.
It would be useful to be able to assign a mongo table to the event, to have them separate
Code of Conduct

[X] I agree to follow this project’s Code of Conduct

Hi @valesceva! Done in #19


Program crashed with signal 4

Godot version
Godot_v4.0-stable_mono
System information
Linux (EndeavourOS)
Issue description
So, working with Godot, the editor is crashing, and I'm getting the following stacktrace. I cannot provide much information since I don't know what may be causing it. I did attach the project so you could reproduce it.
[axel@Endeavour-OS logs]$ godot4_mono --editor /home/drives/HDD_STORAGE/WORK/AXVEMI/GodotProjects/Worlds-Godot/
Godot Engine v4.0.stable.mono.official.92bee43ad - https://godotengine.org
libspeechd.so.2: cannot open shared object file: No such file or directory
OpenGL API 3.3.0 NVIDIA 525.89.02 - Compatibility - Using Device: NVIDIA Corporation - NVIDIA GeForce RTX 2060

Editing project: /home/drives/HDD_STORAGE/WORK/AXVEMI/GodotProjects/Worlds-Godot
Godot Engine v4.0.stable.mono.official.92bee43ad - https://godotengine.org
libspeechd.so.2: cannot open shared object file: No such file or directory
Vulkan API 1.3.224 - Forward+ - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce RTX 2060

[axel@Endeavour-OS logs]$ WARNING: Blend file import is enabled in the project settings, but no Blender path is configured in the editor settings. Blend files will not be imported.
     at: _editor_init (modules/gltf/register_types.cpp:70)
ERROR: FATAL: Condition "!match" is true.
   at: ~CSharpInstance (modules/mono/csharp_script.cpp:2022)

================================================================
handle_crash: Program crashed with signal 4
Engine version: Godot Engine v4.0.stable.mono.official (92bee43adba8d2401ef40e2480e53087bcb1eaf1)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[1] /usr/share/dotnet/shared/Microsoft.NETCore.App/7.0.3/libcoreclr.so(+0x4a899e) [0x7fc8a46a899e] (??:0)
[2] /usr/lib/libc.so.6(+0x38f50) [0x7fc8cbcecf50] (??:0)
[3] /usr/local/bin/Godot_v4.0_mono/Godot_v4.0-stable_mono_linux.x86_64() [0x1589f68] (??:0)
[4] /usr/local/bin/Godot_v4.0_mono/Godot_v4.0-stable_mono_linux.x86_64() [0x464be71] (??:0)
[5] /usr/local/bin/Godot_v4.0_mono/Godot_v4.0-stable_mono_linux.x86_64() [0xee3b50] (??:0)
[6] [0x7fc8285e010d] (??:0)
-- END OF BACKTRACE --
================================================================

Steps to reproduce
Open the attached project
Open scenes => WorldGenerator.tscn
In the scene tree, inspect Node. It should have the WorldManager script attached.
Play with the settings (Grid Width and Grid Height) and click on Refresh to try it. It usually crashes when changing from 2x2 to 10x10 or like that. Not always.
Minimal reproduction project
Worlds-Godot.zip

Duplicate of https://github.com/godotengine/godot/issues/70449

Duplicate of https://github.com/godotengine/godot/issues/70449.


refactor: use css vars for img filter

#450  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on  Graphite


Add diagnostic_msgs to common_interfaces

Changes are OK IMO. Please install https://pre-commit.com/ and use it to iron out pre-commit complaints.


Minor: Wrong order of qualifiers

Detected while playing around with a new clang-tidy check that is in development. :grin:

Codecov Report

Merging #271 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #271   +/-   ##
=======================================
  Coverage   83.54%   83.54%
=======================================
  Files         280      280
  Lines       22948    22948
=======================================
  Hits        19172    19172
  Misses       3776     3776

Flag
Coverage Δ

#data_tests
61.62% <100%> (ø)
:arrow_up:

#examples
58.42% <100%> (ø)
:arrow_up:

#unit_tests
79.82% <100%> (+0.06%)
:arrow_up:

Impacted Files
Coverage Δ

include/osmium/osm/changeset.hpp
100% <100%> (ø)
:arrow_up:

include/osmium/osm/relation.hpp
91.11% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bb69ec...13dfd56. Read the comment docs.


BkWrap #399

#399 : Added BkWrap class. BkParallel, BkTimeable, BkSafe and BkReuse extend the newly created BkWrap.

@hdouss Many thanks for the PR, let me find a reviewer for it

@dmzaytsev please review, thanks

@HDouss please update the pull request description
according our quality rules

Pull request description explains the solution proposed and contains a link to the original ticket it is related to.

@HDouss please see a few comments above

@dmzaytsev Comments took into consideration. For the unit test, I did not add one. What should the unit test actually test ? I think there is no nedd for a unit test here, like for RqWrap, TkWrap and RsWrap.

@HDouss in my opinion this unit test should check that BkWrap calls #accept() of origin Back and socket passed into the method

@dmzaytsev This is already tested in the BkParallel, BkTimeable, BkSafe and BkReuse tests. Testing BkWrap would rather test the inheritance. If you still convinced it has to have a unit test, I will make a puzzle for it.

@rultor merge

@rultor merge

@dmzaytsev Thanks for your request. @yegor256 Please confirm this.

@rultor try to merge

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor try to merge

@yegor256 Done! FYI, the full log is here (took me 7min)

@elenavolokhova please, check this issue for QA compliance, as per par.24

@rultor deploy

@rultor deploy

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor deploy

@davvd Done! FYI, the full log is here (took me 11min)

@dmzaytsev
According to our quality rules:

Comments were mostly about design problems, not cosmetic issues.

There were mostly cosmetic issues found during review. Try to pay attention to bigger design problems and the overall quality of the code.
Please confirm that this rule is clear.

@elenavolokhova I confirm

@davvd Quality is acceptable here.

@davvd Quality is acceptable here.

@elenavolokhova thanks a lot, next time everybody should try to make it better

@dmzaytsev added 10 mins to @elenavolokhova, for QA review, payment code is 71812775; Much obliged! I have added 24 mins to your account in payment "71812778", 23 hours and 22 mins spent; review comments (c=9) added as a bonus; +24 to your rating, your total score is +953


process_title test case failing

Version: 1.26.1
Platform: OS/390 S0W1 25.00 04 2964

The process_title test cases is failing on zOS, s390x platform.
Looking at the source, it appears that a process title struct is initialized in uv_set_process_title under unix/proctitle.c:
       if (process_title.len != 0) {
 99     /* No need to terminate, byte after is always '\0'. */
100     strncpy(process_title.str, title, process_title.len);
101     uv__set_process_title(title);
102   }

process_title.len is fetched from the length of the argv[0] when running this test case. Having a short command line argument, or a short path to where libuv is on disk will cause this to be a small integer, which in turn will copy fewer characters to process_title.str.
The test cases is setting the title as this fixed string:
set_title("%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s");

and later tries to run an ASSERT by strcmp(buffer, title) == 0.
A short  argv[0] will in turn make the buffer have fewer characters than expected hence the ASSERT fails.
There are a few ways to fix this but first I like to understand the reason for having this test case, why it's being initialized with command line arguments and how it tests setting process title.

The preceding comment explains the reason for that test: Check for format string vulnerabilities.
See also commit a9f6f06feaf02ebb48d4b41bd2ac47fcb2096a00.

@bnoordhuis Thank you, but can't process_title.str get initialized with a string with an equal length to"%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s" ?

Maybe I misunderstand your question but a string without "%s%s%s..." in it wouldn't test for format string vulnerabilities.

@bnoordhuis that's right, what I'm asking is, let's say I start the tests with "/home/libuv/run-test".
upon initialization of the process_title test case, process_title.str will be set to home/libuv/run-test which has fewer characters than "%s%s%s..." above, hence strcmp(buffer, title) == 0 will fail. The string above has a fixed length whereas process_title.str length depends on the command line argument length.

Right, I understand now. I think the answer to your question is that on most platforms it isn't an issue because there's always more room available than just argv[0]; z/os is the outlier, see commit f9484cf51: https://github.com/libuv/libuv/blob/09ba4778d8a8d36b652c714c2cc6557b7e945ee2/src/unix/proctitle.c#L62-L70
A simple fix would be to use a shorter string in the test, perhaps conditionally on #ifdef __MVS__.

@bennoleslie Thanks you, so can I make a PR with this fix? I will add some other minor zos fixes to it also

Wrong at-mention, I think? :-)
A PR is welcome, just don't put unrelated changes in the same commit.

@bnoordhuis my bad, got it right this time :D, thank you.

Link for downloading the zip file:
https://ibm.box.com/s/wzbo9dbuair5e4eaqkjl3dgrz1fko8ax
Instructions for unzipping and exporting path:
https://github.com/nodejs/build/blob/master/jenkins/scripts/select-compiler.sh

@miladfarca Please open a pull request if you still want to. I'll close out this issue due to inactivity.


Fix Issue 13124 - Allow non-bool predicates for until

https://issues.dlang.org/show_bug.cgi?id=13124

Another way to do it and avoid casts is to use two negations with !!

The question that remains: Is this going to be the only predicate-based function that allows non-bool returns. What about other functions?
Also, this feature needs to be documented in the function header.
Pinging @andralex if he wants to approve this.

filter accepts non bool. Not sure about others. On phone atm.


learn enough regex to prevent scunthorpe problems with phrases

Issue created by TheSkeward#1111.

https://regexr.com/


Social media list is hidden

See https://jekyll.github.io/minima/

How. In which commit?
My list is still hidden.

@michaelnordmeyer I think it was in https://github.com/jekyll/minima/commit/d3b57ca46bd69c29342ca9696eb1c317d3c5dde6

Hm, then we're talking about different problems.
My social media list is rendered in HTML (so no disappearing icons because of wrong site.xxx_username), but for whatever reason some elements are hidden:

      <svg class="svg-icon">
        <use xlink:href="/assets/minima-social-icons.svg#github"></use>
      </svg> xxx

      <svg class="svg-icon">
        <use xlink:href="/assets/minima-social-icons.svg#linkedin"></use>
      </svg> xxx

      <svg class="svg-icon">
        <use xlink:href="/assets/minima-social-icons.svg#twitter"></use>
      </svg> xxx

:root .social-media-list, :root .icon--linkedin, :root .icon--twitter {
    display: none !important;
}

None of those are in the source HTML and CSS.
It was working until yesterday when I upgraded from minima 2.1.1 to 2.3.0. I checked all my commits and the commits of minima after 2.1.1 to no avail. I use Github Pages.
Any idea?

Nevermind, I found the problem. µBlock Origin was blocking the list:

Static filter -social-icons. found in:
Fanboy’s Annoyance List
Fanboy’s Social Blocking List


Update with the new official pulumi-ovh provider

Hi,
A new pulumi-ovh provider have been created, and hosted in ovh official github orga. I am maintaning and leading the OVH Terraform provider so is it possible to change the old and not uptodate provider (thanks for create it!) in the pulumui registry to the new official one?
Thanks :)

I'm okay with this change.
I'll archive my provider, and add a deprecation notice.
Please add information to the docs for the new provider to help folks migrate

I will help @scraly first with the migration setup from @jaxxstorm provider to the OVH one. We will need a release of the OVH provider before this PR can/should be merged. Please await my OK.

@scraly I have two questions to support existing users:

Have you published a higher version for your first provider release over the previous v0.32.0? The Pulumi does not namespace providers (presently), and surprising behavior could occur if a user changes to your SDK and there was a version collision.

What steps would a user need to take to migrate, or is there documentation in the provider to reach out to you with migration steps?

@AaronFriel OVH provider is already at v0.34.0. I will help @scraly to have the migration setup in place so the required changes remain minimal.

@ringods wonderful, thank you! Should we block the merge until there is a migration note - a pointer to contact someone - or a guide?

@AaronFriel I will ping you when all info is there.

@AaronFriel v0.34.1 is release:

Github release: https://github.com/ovh/pulumi-ovh/releases/tag/v0.34.1
Migration Guide: https://github.com/ovh/pulumi-ovh/blob/main/docs/how-to-guides/migration-from-lbrlabs-package.md

We are all set to make the switch in the Pulumi Registry.
This PR can be merged now. 🙏🏻


Problems with the code

Thanks for your very nice code.
I met a problem with your code:
At the end of the PolSARFormer model, the code below just takes the x as the input, thus the output nn of the PolSARFormer is just the results of the output_block, and the attention operation is unused.
'nn = output_block(x, num_classes=num_classes, drop_rate=dropout, classifier_activation=classifier_activation)'
So I wonder if there is a mistake, and if the 'x' in the code should be takeplaced by other variable.

Yeah, it was a mistake. It supposed to be nn!!
I corrected it.
Thanks.

Thanks for your reply!


The gradient option in SemanticChunker (langchain_experimental) is not available when installing from pip

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
text_splitter = SemanticChunker(HuggingFaceEmbeddings(), breakpoint_threshold_type="gradient")

Error Message and Stack Trace (if applicable)
 File "/Users/guertethiaf/Documents/jamstack/muniai/anabondsbackend/main.py", line 33, in chunk_text_semantically
    text_splitter = SemanticChunker(HuggingFaceEmbeddings(), breakpoint_threshold_type="gradient")
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/langchain_experimental/text_splitter.py", line 124, in __init__
    self.breakpoint_threshold_amount = BREAKPOINT_DEFAULTS[
                                       ^^^^^^^^^^^^^^^^^^^^
KeyError: 'gradient'

Description
When trying to use the SemanticChunker with 'gradient' as a breakpoint_threshold_type I noticed it always gave me a key error.

After checking  /Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/langchain_experimental/text_splitter.py I noticed the option wasn't present.
It's present in the repository and was merged I think a week ago.
System Info
System Information

OS:  Darwin
OS Version:  Darwin Kernel Version 23.3.0: Wed Dec 20 21:30:27 PST 2023; root:xnu-10002.81.5~7/RELEASE_ARM64_T8103
Python Version:  3.12.4 (v3.12.4:8e8a4baf65, Jun  6 2024, 17:33:18) [Clang 13.0.0 (clang-13<IP_ADDRESS>)]

Package Information

langchain_core: 0.2.9
langchain: 0.2.5
langchain_community: 0.2.5
langsmith: 0.1.81
langchain_experimental: 0.0.61
langchain_huggingface: 0.0.3
langchain_openai: 0.1.9
langchain_text_splitters: 0.2.1

Packages not installed (Not Necessarily a Problem)
The following packages were not found:

langgraph
langserve

Please update to latest version as this issue has been resolved. See this line


Set hint on TextInputLayout

Set hint on TextInputLayout instead of EditText so that it animates properly when you start typing.
From documentation:

The hint should be set on the TextInputLayout, rather than the EditText. If a hint is specified
on the child EditText in XML, the TextInputLayout might still work correctly; TextInputLayout
will use the EditText's hint as its floating label. However, future calls to modify the hint will
not update TextInputLayout's hint.

Check the demo here: https://material.io/components/text-fields/

Hi, when do you think a release will be created with this commit?


show error message in GrafanaDashboard CR when json in CR is invalid

Is your feature request related to a problem? Please describe.
When json in GrafanaDashboard CR is invalid, the error message is only available in grafana-operator, but not CR itself. The GrafanaDashboard CR has no indicator that the json is invalid, and user does not know what's wrong until checking grafana-operator log.
(If applicable)If your feature request solves a bug please provide a link to the community issue
N/A
Describe the solution you'd like
When json in GrafanaDashboard CR is invalid, the error message shall be available in GrafanaDashboard CR itself so that user knows there is problem in json.
Describe alternatives you've considered
N/A
Additional context
N/A
Existing solutions
N/A

The same is valid for other CRs as well.
For example, one of our users defined a GrafanaDatasource with a reference to a Secret, but with a key in Secret missing.
The error is logged in operator logs, where users do not have access. The CR itself was left intact, with no change in status field, so from users perspective it seems the GrafanaDatasource is just ignored by the operator.
What should happen is that the error message that is logged in operator logs should also appear in the status section of the CR as well.

We recently introduced status conditions for the dashboard resource and are tracking conditions implementation in #1450.
Keeping this open to make sure the specific use case of invalid json is correctly reported.
Now that status.conditions is implemented for the dashboard resource, this would be a good first contribution to the project


Add go.work File

Description of changes:
The eks-anywhere repo includes two separate go modules located at ./ and ./release.
By default, vscode will download and resolve dependencies for the module at ./, but throws errors unable to resolve dependencies for packages in the ./release module not present in ./.
We can tell vscode that our workspace actually includes two modules by adding a go.work file pointing at our two modules.
With this file present, vscode knows to look for a go.mod in each module directory and download the dependencies.
Read more about go.work here and how it works with gopls and vscode here
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I wonder if that works for Goland

/LGTM


Update vendor for StopTimeout

please break this up into 2 commits.
first commit for the updates in vendor.conf labeled with what versions you're updating to for rancher-compose-executor and that you're updating go-rancher
second commit would be the vendor updates

LGTM


Falcon-2039 Move falcon post processing to falcon server and remove post processing

I know you plan to open a separate documentation JIRA. Please also open one to disable post-processing for Import/Export, if you are not comfortable making the changes.
Had challenges while adding UTs?

I am comfortable in making the changes for HCat ,Import and Export will make those too...
No challenges for UT will add them too in the current classes.

Hi All ,
I have made the changes for Hcat,Import,Export workflow builder but havenot done any dev testing anyone who is using them can do the dev testing at there end.Rest of the work is dev tested and UT's have been added.
Thanks

+1 apart from the point on HDFSServerConfigs.

@PraveenAdlakha, looks there are code merge conflicts. Please resolve them. Will merge once the conflicts are resolved and build is successful.

@pallavi-rao its mergable now.


Follow new events reacts to events that are not displayed

The Follow new events feature jumps to the last event in the list, even though
the new event is not actually displayed in the list due to filters.

What steps will reproduce the problem?
1. Open a log that can grow (logging events are appended).
2. Set any filter, such that not all logging events are displayed in the list.
Example: Logger name filter for 'foo'.
3. Make sure /Follow new events/ is enabled.
4. Append a log event that is not displayed, because it does not pass the
filter. For example, use the logger name 'bar'.

Expected: The selection in the list of logging events does not change, because
the displayed list does not change (the newly arived event does not show up).
There is nothing to be followed on the screen.

Actual: The last line in the list is selected. The last line contains an old
event.

Build: 2013-01-24
Windows 7

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 12 Jun 2013 at 1:23

To check if it is already fixed


🔒 Upgrade plugins for security-1186

I'm happy to lump this change into #732 if you'd prefer.

Installed plugins:
ace-editor:1.0.1
apache-httpcomponents-client-4-api:4.5.5-3.0
authentication-tokens:1.1
blueocean-autofavorite:1.2.2
blueocean-bitbucket-pipeline:1.9.0
blueocean-commons:1.9.0
blueocean-config:1.9.0
blueocean-core-js:1.9.0
blueocean-dashboard:1.9.0
blueocean-display-url:2.2.0
blueocean-events:1.9.0
blueocean-github-pipeline:1.9.0
blueocean-git-pipeline:1.9.0
blueocean-i18n:1.9.0
blueocean-jira:1.9.0
blueocean:1.9.0
blueocean-jwt:1.9.0
blueocean-personalization:1.9.0
blueocean-pipeline-api-impl:1.9.0
blueocean-pipeline-editor:1.9.0
blueocean-pipeline-scm-api:1.9.0
blueocean-rest-impl:1.9.0
blueocean-rest:1.9.0
blueocean-web:1.9.0
branch-api:2.0.20
cloudbees-bitbucket-branch-source:2.2.12
cloudbees-folder:6.3
conditional-buildstep:1.3.1
config-file-provider:3.2
credentials-binding:1.15
credentials:2.1.17
display-url-api:2.2.0
docker-commons:1.11
docker-workflow:1.14
durable-task:1.24
favorite:2.3.1
git-client:2.7.0
github-api:1.90
github-branch-source:2.3.6
github:1.29.2
github-organization-folder:1.6
git:3.9.1
git-server:1.7
handlebars:1.1
handy-uri-templates-2-api:2.1.6-1.0
htmlpublisher:1.16
jackson2-api:<IP_ADDRESS>
jenkins-design-language:1.9.0
jira:3.0.2
job-dsl:1.70
jquery-detached:1.2.1
jsch:<IP_ADDRESS>
junit:1.26.1
kubernetes-credentials:0.3.0
kubernetes:1.12.8
lockable-resources:2.3
mailer:1.21
mapdb-api:<IP_ADDRESS>
matrix-auth:2.2
matrix-project:1.12
mercurial:2.3
momentjs:1.1
openshift-client:1.0.21
openshift-login:1.0.9
openshift-sync:1.0.29
parameterized-trigger:2.35.2
pipeline-build-step:2.7
pipeline-github-lib:1.0
pipeline-graph-analysis:1.7
pipeline-input-step:2.8
pipeline-milestone-step:1.3.1
pipeline-model-api:1.3.2
pipeline-model-declarative-agent:1.1.1
pipeline-model-definition:1.3.2
pipeline-model-extensions:1.3.2
pipeline-rest-api:2.9
pipeline-stage-step:2.3
pipeline-stage-tags-metadata:1.3.2
pipeline-stage-view:2.4
pipeline-utility-steps:1.5.1
plain-credentials:1.4
pubsub-light:1.12
run-condition:0.10
scm-api:2.2.7
script-security:1.48
sse-gateway:1.16
ssh-credentials:1.14
structs:1.17
subversion:2.10.3
token-macro:2.0
variant:1.1
workflow-aggregator:2.5
workflow-api:2.30
workflow-basic-steps:2.6
workflow-cps-global-lib:2.9
workflow-cps:2.60
workflow-durable-task-step:2.21
workflow-job:2.25
workflow-multibranch:2.20
workflow-remote-loader:1.4
workflow-scm-step:2.6
workflow-step-api:2.16
workflow-support:2.21

rhel plugin rpm https://buildvm.openshift.eng.bos.redhat.com:8443/job/devex/job/devex%252Fjenkins-plugins/79/

Note the script-security and workflow-cps bumps here were superseded buy 2019 sec advisories that were merged to 3.11, so no cherry-pick here.
We'll update the comment in https://github.com/openshift/jenkins/pull/808


New-DBAAvailabilityGroup doesn't pass in all IP's for IPAddress parameter

Environmental information
Name                           Value

PSVersion                      5.1.14393.3471
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.3471
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
Name    : dbatools
Path    : C:\Program Files\WindowsPowerShell\Modules\dbatools\1.0.97\dbatools.psd1
Version : 1.0.97
SQL Server:

Microsoft SQL Server 2016 (SP2-CU11) (KB4527378) - 13.0.5598.27 (X64)   Nov 27 2019 18:09:22   Copyright (c) Microsoft Corporation  Enterprise Edition (64-bit) on Windows Server 2016 Datacenter 10.0  (Build 14393: ) (Hypervisor)
Report

Host used

[X ] powershell.exe
[ X] ISE
[ ] VS Code
[ ] Other (please specify)

If anything other than powershell.exe was used, please confirm that you can duplicate the issue with powershell.exe

[X ] Still buggy in powershell.exe

Errors Received

Steps to Reproduce
Run this script to create the AG.
$Params = @{
Primary= 'RND-Node1'
#primarysqlcredential = $DCred
Secondary = 'RND-Node2'
#SecondarySqlCredential = $DCred
Name = $AgName
Database = 'Test'
SeedingMode = 'automatic'
UseLastBackup = $true
FailoverMode = 'Automatic'
AutomatedBackupPreference = 'Primary'
DatabaseHealthTrigger = $True
AvailabilityMode = 'SynchronousCommit'
ReadOnlyRoutingConnectionURL = 'tcp://RND-Node1.sql.prod.local:1433'
IPAddress = '10.47.67.XX','10.47.67.XX'
subnetmask = '<IP_ADDRESS>'
DHCP = $False
Port = 1433
Confirm = $False
}
New-DbaAvailabilityGroup @Params
Expected Behavior
AG Should be created, complete with the listener, when multiple IP's are passed in due to multi-subnet setups.  I was not able to confirm if the read only routing table is correctly created due to the listener failing to create.  This should be checked as well.
Actual Behavior
AG Listener will not be created.  it appears that only the 1st IP is passed into the array, which will cause the listener creation to fail in multi-subnet setups.

This is an error from SQL Server, it cannot see the network associated with those IPs. As well you only need one IP per subnet when creating the listener via SMO. It cannot support multiple IPs in the same network, that has to be done from the cluster as documented here.

Second side, if you indeed were going to use two networks I don't believe SMO supports the process and/or we do not have it coded for that...I can't remember without re-reading all the code again.

I can confirm I've used Add-DbaAgListener to create a multi-subnet listener.  Right now the code in New-DbaAvailabilityGroup only passes the first in the array of IPs on to create the listener with:
if ($IPAddress) {
            if ($Pscmdlet.ShouldProcess($Primary, "Adding static IP listener for $Name to the Primary replica")) {
                $null = Add-DbaAgListener -InputObject $ag -IPAddress $IPAddress[0] -SubnetMask $SubnetMask -Port $Port -Dhcp:$Dhcp
            }
        }

I don't have a lab environment that I can use to test this right now otherwise I would take on coding it.  I would imagine it's just a simple taking out the array ID reference but I'm not 100% sure.

as a workaround I create the listener separately with the below code and it works, just can't be done in the main New-DBAAvailabilityGroup code
Add-DbaAgListener -sqlinstance $Server1 -AvailabilityGroup $AgName -ipaddress 10.47.67.XX,10.47.67.XX -subnetmask '<IP_ADDRESS>'

Yeah I'm thinking multiple listeners, not IPs. We can update the call go handle it properly.

Might be related, but might not.  I was not able to determine from my review of the code (albeit im very new at looking at PowerShell code).  I don't see a paramter to set the read only routing list anywhere.  I do see the -ReadonlyRoutingConnectionUrl parameter, and that does create the URL properly, but the read only routing list is not created.  Is that by design?

We do not have a command to configure read-only routing, therefore the new AG command does not support it @GLoeffler14 .


a

[ @octocat :+1: This PR looks great - it's ready to merge! :shipit:]

Pic. Flwer. 666. 369
M Bug ho long nejoy vussy


Tutorial updates

Fixed links in rbac tutorial
Move the ChatOps tutorial into docs/tutorials. This is an attempt to bring tutorials together and to be able to point to these tutorials from other part of documentation.

I intentionally didn't move ChatOps one there yet since I wasn't sure if it's still up to date.
In any case, if you think that it is, it's fine :)

ChatOps one there yet since I wasn't sure if it's still up to date.

Yeah. It is reasonably updated. Anyway, since we have tutorials best to have it there and also @lakshmi-kannan was complaining. I will review the docs and update any old stuff soon.


2024-12-11_01-36-07_master-next_aws-sdk-cpp

Automatically created.

Successfully created backport PR for kirkstone-next:

#10722

Successfully created backport PR for scarthgap-next:

#10723

Successfully created backport PR for styhead-next:

#10724


Implements hooks support

Starting work for #4. The hook API will enable developers to create exs files in hooks/ which will auto load. A hook would look like the following:
hook :slack do
  %{"text" => message} = conn.params
  broadcast! :slack_message, message
end

The slack hook above will generate a route at /hooks/slack. The underlying API of hook/2 will be leveraging the Plug.Route API so hooks will have access to the normal conn object just like any other route.

[x] Remove variable conn is unused compiler warning
[x] Fix issue https://github.com/kittoframework/kitto/pull/25#issuecomment-263407134
[x] Have general hook handle params from form, query or JSON
[x] Generate hooks directory when user creates new project

Coverage decreased (-0.4%) to 80.208% when pulling 5a045eb34c67a9f7968381e4c1d74ae1512cc88f on hooks into 9d3f150bd0fbec64edde8d225e4f1510244e483e on master.

Would it make sense to, when building the hook allow the dev to pass a custom route to generate?
hook :slack, "/slash" do
  ...
end

Which would then generate /hooks/slash instead of /hooks/slack.
I can't think of a use case, but it's fairly simple to include.

Concerning https://github.com/kittoframework/kitto/pull/25#issuecomment-261535831 i don't think we need such an option right now.

Coverage decreased (-0.4%) to 80.5% when pulling 40f67179a7a9d1fbfdbed9ec2393796a90f26d0d on hooks into 2806b0c8a000a5b8f8c38df4552b050d673f16c3 on master.

Coverage decreased (-0.4%) to 80.905% when pulling 8cce82d27878472b4969af93e6ea14759600e81e on hooks into 4ad343b12fc4634af5a0f53204a3e7c4112c2153 on master.

All changes that could be implemented, or are not up for further discussion, are added.

Coverage increased (+1.7%) to 83.019% when pulling 2b58fdde860422f9af421d613de9a9918605cff7 on hooks into 4ad343b12fc4634af5a0f53204a3e7c4112c2153 on master.

@davejlong concerning the unused variable warning, we should go with something like:
defmacro hook(name, do: block) do
  quote do
    # Append the hook to the list of hooks
    Kitto.Hooks.register unquote(name), fn(var!(conn)) ->
       _ = var!(conn)
       unquote(block)
     end
  end
end

Just like phoenix does at: https://github.com/phoenixframework/phoenix/blob/v1.2/lib/phoenix/endpoint.ex#L376

Agreed. Do you want to go ahead and add it in?
On Sat, Nov 26, 2016, 9:18 AM Dimitrios Zorbas<EMAIL_ADDRESS>wrote:

@davejlong https://github.com/davejlong concerning the unused variable
warning, we should go with something like:
defmacro hook(name, do: block) do
quote do    # Append the hook to the list of hooks
Kitto.Hooks.register unquote(name), fn(var!(conn)) ->
_ = var!(conn)
unquote(block)
end
endend
Just like phoenix does at:
https://github.com/phoenixframework/phoenix/blob/v1.2/lib/phoenix/endpoint.ex#L376
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kittoframework/kitto/pull/25#issuecomment-263065697,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKs1egYPqkdqkq-etTa7c_NJzanLkVeks5rCD-ugaJpZM4K2fFq
.

Coverage increased (+1.4%) to 86.486% when pulling fd8aced48762304cf7566e300d815c3cb3f3cc8f on hooks into f129784d09c8f912c8705f3ba942ba415c086325 on master.

I'll work up an example of a Slack slash command using the hooks support, but I think we can go ahead and merge this in. Expect another blog post and PR for the slack command hook later this week.

Coverage increased (+1.1%) to 87.308% when pulling 8e3b97a12950dbabd9fe61fce07f66e012bdee86 on hooks into 0d690330dfb1d4fc4c03f007dddfbaaaeead1efa on master.

There seems to be an issue using broadcast! with a hook that I have to look into:
broadcast! :slack_message, text
** (exit) exited in: GenServer.call(nil, {:update, #Function<2.103310966/1 in Kitto.Notifier.cache/2>}, 5000)
    ** (EXIT) no process
    (elixir) lib/gen_server.ex:596: GenServer.call/3
     (kitto) lib/kitto/notifier.ex:46: Kitto.Notifier.broadcast!/2

Hello, @davejlong! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

Coverage increased (+1.3%) to 87.5% when pulling de4f8ac68e6363bf729e1279bd3a25be55fbd744 on hooks into 0d690330dfb1d4fc4c03f007dddfbaaaeead1efa on master.

Coverage increased (+1.3%) to 87.5% when pulling 41eb3b761a3e3ea238bf080f5aabaf5f370c09e7 on hooks into 0d690330dfb1d4fc4c03f007dddfbaaaeead1efa on master.

Failing test is the stats server.

Coverage increased (+0.9%) to 87.5% when pulling c30575c5f8d45a6cef443fc2ea23ed9f47a49900 on hooks into 55fe04b172258f9306c8100244747863f689e612 on master.

Will review this tomorrow (2016-12-05). It's the last thing keeping 0.3.0 from being released and it looks good.

Coverage increased (+0.9%) to 87.459% when pulling 8dd0181cb9bd568f983351102c9c4f5e8214780c on hooks into 55fe04b172258f9306c8100244747863f689e612 on master.

Coverage increased (+0.5%) to 87.129% when pulling 7d49e9c4d581295d78cea0546f6dd5f141725812 on hooks into 55fe04b172258f9306c8100244747863f689e612 on master.

I'm going to close this for right now while I rethink the hook system. Will reopen a PR after I revise the concept to be more unified with the job running system.


AWS::WAFv2::WebACL RateBasedStatement Limit Validation

cfn-lint version: 0.29.2
Description of issue.
When creating a WAF rule that includes a RateBasedStatement there is no validation done on the value set for the Limit. It wasn't until deploying the CloudFormation template that I received an error:
Model validation failed (#/Rules: 3 schema violations found) #/Rules/4/Statement/RateBasedStatement/Limit: failed validation constraint for keyword [minimum] (#/Rules/4/Statement/RateBasedStatement/Limit) #/Rules/5/Statement/RateBasedStatement/Limit: failed validation constraint for keyword [minimum] (#/Rules/5/Statement/RateBasedStatement/Limit) #/Rules/6/Statement/RateBasedStatement/Limit: failed validation constraint for keyword [minimum] (#/Rules/6/Statement/RateBasedStatement/Limit)
The error is due to my Limit value being set below the minimum value allowed. I was able to find this info after attempting to create my rule through the AWS console where I noticed they had a note:

A note about it can also be found here: https://aws.amazon.com/about-aws/whats-new/2019/08/lower-threshold-for-aws-waf-rate-based-rules/
Note that there is nothing mentioned about the minimum / maximum limit anywhere in the CloudFormation documentation: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-webacl-ratebasedstatementone.html
Feature request.
I'm suggesting that validation be added to ensure the Limit value is set between the minimum, 100, and maximum, 20000000, limit. This small feature will be extremely valuable for users due to the lack of CloudFormation documentation, and hopefully save people quite a bit of time!

As described here, this would need something like:
https://github.com/aws-cloudformation/cfn-python-lint/blob/df8d065380e49e53dad9513dab41c2438e105f43/src/cfnlint/data/ExtendedSpecs/all/03_value_types/aws_sqs.json#L17-L24
https://github.com/aws-cloudformation/cfn-python-lint/blob/90657f9aa0f797499460de21c849fc3ca64240ce/src/cfnlint/data/ExtendedSpecs/all/04_property_values/aws_sqs.json#L16-L22
and the rest of the necessary changes should be auto-generatable by running:
cfn-python-lint $ pip3 install -e . --user
cfn-python-lint $ cfn-lint --update-specs

@PatMyron correct, this applies to both AWS::WAFv2::RuleGroup.RateBasedStatementOne and AWS::WAFv2::RuleGroup.RateBasedStatementTwo


Fix web URLs for Copr builds owned by groups

In Copr, when a namespace belongs to a group, its name starts with '@'.
URLs to builds in the Copr web UI though use the 'g/' token, instead of
'@'.
Take the above into account when generating URLs for the log pages.
Relates to packit-service/packit-service#523.

recheck


Frontend type checking error with differing flow control

The following two methods seem to me to be semantically equivalent, but one compiles and one fails to compile:
// This fails to compile with the error:
// A value of type 'Listenable' can't be returned from the function 'getListenableBug' because it has a return type of 'ValueListenable<T>'.
ValueListenable<T> getListenableBug<T>(HasA<T>? a, HasB<T> b) => a == null ? b.b : a.a;

// This compiles just fine.
ValueListenable<T> getListenableNoBug<T>(HasA<T>? a, HasB<T> b) {
  if (a == null) {
    return b.b;
  }
  return a.a;
}

Here is the full snippet, the bug should reproduce just by pasting this directly into dartpad.dev (Dart version 3.3.4 / Flutter 3.19.6):
import 'package:flutter/foundation.dart';

class A<S, T> with ChangeNotifier implements ValueListenable<T> {
  @override
  T get value => throw Error;
}

class B<T> with ChangeNotifier implements ValueListenable<T> {
  @override
  T get value => throw Error;
}

class HasA<T> {
  final a = A<int, T>();
}

class HasB<T> {
  final b = B<T>();
}

ValueListenable<T> getListenableBug<T>(HasA<T>? a, HasB<T> b) => a == null ? b.b : a.a;

ValueListenable<T> getListenableNoBug<T>(HasA<T>? a, HasB<T> b) {
  if (a == null) {
    return b.b;
  }
  return a.a;
}

The function getListenableBug returns a conditional expression (?:) whose type is computed based on both branches. The function getListenableNoBug returns each of the two branches separately. This implies that they are non-equivalent because they are subject to different steps during type checking. With the stable release, this causes a type error.
However, we have just recently introduced an improvement in the computation of the type of conditional expressions, and this makes both versions of getListenable type correct. Choose the 'main' channel in DartPad and you'll see that there are no type errors.
This means that the issue will go away soon.
I'll close this issue because there's nothing to do, we just need to wait for the improvement to reach the stable release.

Ok - thank you for the explanation and quick response.


Make community

Gamification:

Keep track of interesting blocks
Get notifications
Know when someone "reuses" your code
An easy way to contact block’s owners

What's the state of the chat on blocks feature?

A user suggested we could have user-email accounts in which you could contact (via biicode) a user similar to github's email accounts.
Otherwise the disqus chat on the bottom of each block's page seems like a nice feature.

Also @metamaker says: It would be cool to have some kind of issue tracker for blocks at www.biicode.com or any other way to contact block's owner directly (IM, PM, emailing, etc).
http://forum.biicode.com/t/feature-request-a-way-to-contact-blocks-owner-at-biicode-com/409

Hello!
Since PM functionality is already present at forum, merging biicode.com and forum.biicode.com user accounts could nicely solve the problem. I believe it is also possible to enable emailing between users in Discourse (through web form like in phpBB).
Chat on blocks is quite nice feature but issue tracker is better since you can organize messages in a way you want, mark them with tags, etc (you know, that cool stuff on git).
For projects located at github it would be nice to provide a link to github repository on top of block's page (though the link could be just mentioned in readme.md but I haven't see many projects providing links back to github). And again such feature could be implemented for other sites like sourceforge, travis-ci, project's website, etc to wire all things together.

Hi @metamaker! Actually, there is such a link, check: https://www.biicode.com/lasote/lasote/libuv/v0.10
The link to github is created using option "-r" = remote in bii publish:
$ bii publish -r

If currently in a github repo, it will obtain the info, and it will query the user for an url otherwise.
Maybe it should be more visible/highlighted.
About the forum, that is right, we have to merge (OAuth accounts for forum and biicode), the issue tracker should be the one of the VCS that supports the code (github, etc). It would be great if we could provide some integration via API, or whatever, but that will take some time. Thanks!

Maybe it should be more visible/highlighted.

Yep, I don't see this -r option at either http://docs.biicode.com/c++/publishing.html or http://docs.biicode.com/c++/reference/commands/publish.html though it is described at http://docs.biicode.com/c++/integration/git.html#publish-from-git-commit. Linking publishing guide to git integration page and mentioning of -r flag in reference could be wise.

the issue tracker should be the one of the VCS that supports the code (github, etc)

I agree, that is good idea not to create new bycicle but rather use existing solution. Does that mean that bii is not intended to provide VCS functions itself (even in future) but rather be used only as software for publishing libraries releases?

It would be great if we could provide some integration via API, or whatever, but that will take some time.

It is possible for github, I don't know if for others too.

Does that mean that bii is not intended to provide VCS functions itself (even in future) but rather be used only as software for publishing libraries releases?

This is exactly what bii is supposed to be. Projects are hosted and VCSed in existing and well suited services such as github, bitbucket, etc; then released and shipped to bii. biicode provides dependency management and user-ready library hosting. We are planning to support external storage too, in a way you can still host your lib in its github repo for example, and bii only stores dependency management info.


gpio_pin_get_config doesn't return the GPIO_ACTIVE_LOW bit

If you call for example gpio_pin_configure(gpio_dev, pin, GPIO_OUTPUT_INACTIVE | GPIO_ACTIVE_LOW) and then immediately call gpio_pin_get_config, the returned value will be GPIO_OUTPUT_HIGH.  But I expected to get either GPIO_OUTPUT_HIGH | GPIO_ACTIVE_LOW or GPIO_OUTPUT_INACTIVE | GPIO_ACTIVE_LOW.
This is a problem if you desire to round trip the config. For example, if you call gpio_pin_get_config to save the current config, then gpio_pin_configure for a short time, and then put it back to the flags you got from gpio_pin_get_config

Please use our bug template when reporting bugs. You need to edit this issue to include the information requested in https://github.com/zephyrproject-rtos/zephyr/blob/main/.github/ISSUE_TEMPLATE/001_bug_report.md
You neglected to include essential information such as the hardware platform used, the Zephyr SHA or version used, and sample code for reproducing the issue.

I discovered this while writing a unit test. It is not specific to any platform, and it still true at today's HEAD.

I discovered this while writing a unit test. It is not specific to any platform, and it still true at today's HEAD.

Well, that unit test must be using a specific GPIO driver. Which GPIO driver is used?
Posting a minimal example would greatly help in understanding this instead of leaving the guesswork up to people reading through this issue.

Please reopen once more information is provided.


aria positioning attributes

We should test if aria-level, -posinset, and maybe even -setsize will improve UX for AT users.

ARIA incoming clarification: if posinset, then setsize is MUST.


SCCH/MSCAD Overview Page

SCCH/MSCAD Overview Page
This PR covers adding the SCCH/MSCAD page to the site, as well as it's card on the homepage. Includes small changes to styling including adding grid to paragraph and heading elements so that they take up 8/12 grid spaces per Service Canada Design System.
Test Instructions

Go to home page
Navigate to My Service Canada Account dashboard through the card and see that it matches design
Toggle to french and navigate the same way

Definition of Done

[x] Update CHANGELOG

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-1435245698.azurewebsites.net

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-1435245698.azurewebsites.net

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-1435245698.azurewebsites.net


[Mono] Crash when adding a custom Resource

Godot version:
3.1.1 Mono
OS/device including version:
Windows 10
Issue description:
Editor crashes when trying to access the exported Resource.
Steps to reproduce:

Create a plugin.

Create a class that inherits from Resource.

In the plugin script, load the script and add a custom type Resource.
AddCustomType("DialogueTreeRes", "Resource", DialogueTreeRes, (Texture) GD.Load("res://addons/dialogue_tree/assets/ResIcon.png"));

Create a script with that resource exported.

Try to fill the empty exported Resource with your newly created Resource Type

Crash when clicking on it.

Minimal reproduction project:
https://github.com/bigmonte/MyTest

This issue recieved no feedback in last 2 weeks. Is the problem invalid?

Thanks for you comment. Ok less bad. I wish I could help more on this one. When I have time I’ll try to find a way to get some error messages or to debug properly the editor. (Despite my lack of c++ knowledge)

I am shamelessly bumping this thread. Having the same issue, and while I understand this is one of many many problems that need fixing, it would be nice to have it brought further into the light.

I think this is a problem of the Export attribute, when generating the custom resource since the godot code does not close, it is also related to #29064
Possible temporary solutions are:

Generate the resource from the code, but you cannot change the fields from the inspector

Load the resource through a path without using export for the resource, but you will have to configure the fields outside the node.

I tested this working example, using Godot 3.2 stable, everything working as expected.

I'll close this as resolved then. Thanks for letting us know :slightly_smiling_face:


fix: Disable migration tasks

Signed-off-by: Lakshmipathi<EMAIL_ADDRESS>

Yes, just now updated.


Cyclobutyl group in a macrocycle triggers a stereo center

Describe the bug
Adding a cyclobutyl group into a macrocycle causes the nitrogen to be treated as a stereo center.
To Reproduce
>>> from rdkit import Chem
>>> mol = Chem.MolFromSmiles("O=S1(=O)C=CC=C2CCCCC3CC(C3)N21")
>>> [Chem.MolToSmiles(x) for x in Chem.EnumerateStereoisomers.EnumerateStereoisomers(mol)]
['O=S1(=O)C=CC=C2CCCCC3CC(C3)[N@@]21', 'O=S1(=O)C=CC=C2CCCCC3CC(C3)[N@]21']

The nitrogen isn't necessary, the following variation also treats the same position as a carbon as a stereo center:
>>> mol = Chem.MolFromSmiles("C1=CCC2C(=C1)CCCCC1CC2C1")
>>> [Chem.MolToSmiles(x) for x in Chem.EnumerateStereoisomers.EnumerateStereoisomers(mol)]
['C1=CC[C@@H]2C(=C1)CCCCC1CC2C1', 'C1=CC[C@H]2C(=C1)CCCCC1CC2C1']

Screenshots

Configuration:
>>> rdkit.__version__
'2022.09.4-sch'

Here's what's going on in this one.
It's clear that a C in that position should be stereogenic: it has four different neighbors.
The condition for an N with degree three to be stereogenic is that it be in a ring of size 3 or be shared between at least 3 rings (In this case, the docs were actually useful to me in figuring this out, I love it when that happens! https://www.rdkit.org/docs/RDKit_Book.html#stereogenic-atoms-bonds). That last condition was added (PR #3958) in order to handle bridgehead atoms like the N here:

In this case the presence of the four membered ring means that the macrocycle actually counts as 2 rings (due to the symmetric paths around the 3 ring), so the N is in three rings, so it's considered stereogenic. If you make the four-ring a five-ring this goes away. If you make it a para-substituted six-ring it comes back:

So I think the problem here is that queryIsAtomBridgehead() is falsely identifying this N as a bridgehead.


Customizable pop-up box

Hi Randall!
Thanks for making this extension! Appreciate the work put into it! Great initiative!
I'm wondering if there's a way to customize the contents of the pop-up box that shows up. I looked through my local chrome extension's files, and did not find any of the relevant contents in there, so I couldn't modify them locally. Are they being fetched during runtime?
If the pop-up box contents were available locally, I could modify them directly to make it work. I'm not sure if there is a different way of allowing this sort of customization.
Customizing the message shown to users would be valuable esp. in a corporate setting where we would be able to provide some more context, and give users the relevant email address to contact in case they need more info. That could lead to an increased rate of adoption of the extension.
Let me know what you think! Thank you in advance!

Hey  Hi !
Thanks for the suggestion. It's a great idea to have a customizable pop-up  by adding more relevant information .Do let me know if this is something you wanted or any CSS that should be added to the embedded pop-up box .Thanks !

Thanks for the response @RuchiraKonda-okta
Yeah the screenshot looks good, except I'd prefer having the ability to change the entire contents of that pop-up box.
Also one thing worth noting is that I'm not using it for a single website, I'm deploying it on org laptops' browsers so it is enabled everywhere as a chrome extension. Any idea if I can customize it in this case?
Thanks!

Hi @mark-btmt
Great idea ! If there is customization, it would reflect a customized message.
I'm wondering If there is no customization what would you want to be displayed ? the initial default warning message ?

Yeah exactly, I think the default warning message is great! So if there is no org-wide customized message, showing the default one is perfect.
Let me know if I can help out in any way.
Thank you!

@mark-btmt  Sounds excellent! It would be great if you could let me know if any styling should be applied to the embedded user option pop up box?
Thank you !

The only styling I would personally like is supporting images, specifically company logos. I think users may be less likely to dismiss/ignore a pop-up box if it is tailored to them and has a company logo in it.
By adding the company logo (and modifying the message content to include an org email address employees can reach out to) the pop-up box would become much more relevant and seemingly useful overall.
Thanks so much for your understanding and quick responses!

@mark-btmt  Thank you for your suggestions. Would something like this work ?

@mark-btmt  Thank you so much for your suggestions.Would something like this work?
Thanks !

Yeah this looks great!
How would I include images? Does it accept markdown or would it render an image that I link?
Also how would the process look if we're trying to push this out to everyone using it within our org? i.e. if we want all employees to see the same custom message


Add "show correct answer on reveal?" option to custom part types

The built-in part types have an option "Show correct answer on reveal?"
Custom part types should have that, too.

Is this solved? I would like to take this if it isn't.

It's still open. Thanks for offering. Please have a look at our guidelines for contributing to Numbas

Okay great, I'll get on it.

Hello! I noticed this issue is still open. I haven't contributed to open source before, but I think I understand this issue and can work on it. Can I submit a PR?


todos-flow example is broken

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
In examples/todos-flow, the Flow typings are not working correctly.
Just to be clear, this bug isn't about Flow features which don't exist or aren't possible. They used to work perfectly fine, but are currently broken. The typings work correctly on Flow 0.54, however they do not work on Flow 0.55 and above. The current version is 0.59.
TodoList has a required prop todos with type Todos, with the following definition:
export type Todo = {
  +id: Id,
  +text: Text,
  +completed: boolean
};

export type Todos = Array<Todo>;

However, if you change mapStateToProps in src/containers/VisibleTodoList.js to either not provide the todos prop, or provide an invalid type, yarn flow will incorrectly report No errors!.
This incorrectly reports no errors, even though TodoList is not receiving a todos prop and will result in a runtime error:
const mapStateToProps = (state: State) => {
  return {
    NOTtodos: visibleTodosSelector(state)
  };
};

This incorrectly reports no errors, even though TodoList is receiving a todos prop that does not match the Todos type, and will result in a runtime error:
const mapStateToProps = (state: State) => {
  return {
    todos: "this is a string, not a an array of Todos, but Flow doesn't care"
  };
};

To reiterate, both these examples correctly report errors on an older version of Flow, 0.54.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar.
Simply change mapStateToProps in src/containers/VisibleTodoList.js to either of the two examples above, and run yarn flow.
What is the expected behavior?
Both examples above should result in Flow reporting an error.
Which versions of Redux, and which browser and OS are affected by this issue? Did this work in previous versions of Redux?
This became broken in Flow 0.55. Both mapStateToProps examples above correctly report errors in Flow 0.54.
I have reported this issue to both Flow and flow-typed, however I wanted to raise awareness on the main Redux repo that Flow typings are currently broken in what is a canonical example in this repo.
I personally think Flow's strengths really shine on a large Redux driven codebase, and Redux support in Flow would ideally be treated almost as much as a first class citizen as React is itself. It's a shame to see this broken for nearly three months now.
https://github.com/facebook/flow/issues/5343

None of the core team here uses Flow, so it's not surprising this hasn't been fixed. If someone can give the example some love via PR, I'd love to get it updated!


Drop deprecated allowPrivilegedContainers field from the Shoot API

How to categorize this PR?

/kind cleanup
What this PR does / why we need it:
Drop deprecated allowPrivilegedContainers field from the Shoot API.
Follow-up of #8989
Which issue(s) this PR fixes:
Part of #8921
Special notes for your reviewer:
/hold until release-v1.90 branch is created
Release note:

Deprecated `.spec.kubernetes.allowPrivilegedContainers` field in the Shoot API is now removed.

Force pushed to resolve conflicts.

/unhold

/lgtm

/retest


Set hadoop fs delegation token renewer to empty

:mag: Description
Issue References 🔗

Allow delegation tokens to be used and renewed by yarn resourcemanager. (used in proxy user mode of flink engine, address https://github.com/apache/kyuubi/pull/6383#discussion_r1635768060)
Describe Your Solution 🔧
Set hadoop fs delegation token renewer to empty.
Types of changes :bookmark:

[X] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests

Checklist 📝

[X] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

Had an offline discussion with @zhouyifan279, this change is safe, and the changed impl aligns with Spark, merging to master

Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (85dd5a5) to head (f2e1f0a).
Report is 4 commits behind head on master.

Files with missing lines
Patch %
Lines

.../credentials/HadoopFsDelegationTokenProvider.scala
0.00%
1 Missing :warning:

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6753   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files         684     684
  Lines       42281   42288    +7
  Branches     5768    5768
======================================
- Misses      42281   42288    +7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Can simplecralwer provide resource received information for each crawled page?

I'm looking to crawl a website and view the resources (img, js, css) to see if they have successfully loaded. Specifically, I'm trying to crawl a website and check to see what Google Analytics tags are on each page and to see if they are firing correctly.
Casper.js has an onResourceReceived event that I hoping simplecrawler can replicate. Can simplecralwer provide resource received information for each crawled page?
Example Casper.js code:
var casper = require('casper').create({
        verbose: true
});

casper.options.onResourceReceived = function(arg, response){

        // make sure resource has fully loaded and is GA
        if (response.stage === 'end' && (response.url.indexOf('google-analytics') > -1)) {
                console.log(JSON.stringify(response, null, 2));
                console.log(response.status + " = " + response.url);
        }
};

casper.start('http://www.example.com/', function() {
        this.echo(this.getTitle());
});

casper.run();

Results:
200 = http://www.google-analytics.com/r/collect?v=1&_v=j41&a=462664566&t=pageview&_s=1&dl=http%3A%2F%2Fwww.example.com%2F&ul=en-us&de=UTF-8&dt=Example Site...
200 = http://www.google-analytics.com/r/collect?v=1&_v=j41&a=462664566&t=pageview&_s=1&dl=http%3A%2F%2Fwww.example.com%2F&ul=en-us&de=UTF-8&dt=Example Site...
200 = http://www.google-analytics.com/r/collect?v=1&_v=j41&a=462664566&t=pageview&_s=1&dl=http%3A%2F%2Fwww.example.com%2F&ul=en-us&de=UTF-8&dt=Example Site...
200 = http://www.google-analytics.com/collect?v=1&_v=j41&a=462664566&t=pageview&_s=1&dl=http%3A%2F%2Fwww.example.com%2F&ul=en-us&de=UTF-8&dt=Example Site%2...
200 = http://www.google-analytics.com/collect?v=1&_v=j41&a=462664566&t=pageview&_s=1&dl=http%3A%2F%2Fwww.example.com%2F&ul=en-us&de=UTF-8&dt=Example Site%2...

simplecrawler doesn't differentiate between pages and resources, everything it fetches is treated equally (fires all the same events and is searched for new resources). You can write your own discovery function, though, for example one that only finds resources specified in the href's of <a

Sorry about that, submitted too early, there's more stuff coming!

@fredrikekelund, thanks for the response. I guess my case is a bit more unique in that some of the google analytics requests are within google tag manger or tealium, meaning there isn't any ga code on the page itself. What I'm really looking for are the resources loaded on each page (like chrome's network tab), this would allow me to then filter received request (like casper.js above) by google-analytics - even if the actual script tag doesn't physically live on the page. It looks like simplecrawler can return the source of the page, but does it actually load the dom? Appreciate your help.

Ah, I see. You're right that simplecrawler doesn't load a DOM for any of the resources it fetches. Something like the cheerio module could provide that, but it seems like you would need a complete browser environment - not just the DOM - to make the requests for scripts and execute them etc, so PhantomJS or some wrapper (like CasperJS) is necessary.
simplecrawler can work together with PhantomJS, but I wouldn't call the integration first class. There are some duplicate efforts in that both simplecrawler and PhantomJS would fetch the page etc, but there's a section on the README on async event listeners that can be used to call something like PhantomJS, and there's an example in the examples folder as well.
It strikes me that if the module that did the fetching of resources was exchangeable as well, this would be less of a problem (although you'd probably still need a pretty custom solution). This idea had been brought up in #244
Från: Nicholas Blexrud
Skickat: torsdag 24 mars 17:55
Ämne: Re: [node-simplecrawler] Can simplecralwer provide resource received information for each crawled page? (#254)
Till: cgiffard/node-simplecrawler
Kopia: Fredrik Ekelund
@fredrikekelund, thanks for the response. I guess my case is a bit more unique in that some of the google analytics requests are within google tag manger or tealium, meaning there isn't any ga code on the page itself. What I'm really looking for are the resources loaded on each page (like chrome's network tab), this would allow me to then filter received request (like casper.js above) by google-analytics - even if the actual script tag doesn't physically live on the page. It looks like simplecrawler can return the source of the page, but does it actually load the dom? Appreciate your help.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

Figured it would be a custom solution. Appreciate your help @fredrikekelund!


reduce import/load logging

Hi,
Can I suggest to adjust the logging of importing/loading extensions? When debugging issues, about 80% of my log files look like the below. Might it be sufficient to only log failed imports/loading of extensions?
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.nl2br".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.nl2br.Nl2BrExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.sane_lists".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.sane_lists.SaneListExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.codehilite".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.codehilite.CodeHiliteExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.fenced_code".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.fenced_code.FencedCodeExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.toc".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.toc.TocExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.tables".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.tables.TableExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.nl2br".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.nl2br.Nl2BrExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.sane_lists".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.sane_lists.SaneListExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.codehilite".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.codehilite.CodeHiliteExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.fenced_code".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.fenced_code.FencedCodeExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.toc".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.toc.TocExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.tables".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.tables.TableExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.nl2br".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.nl2br.Nl2BrExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.sane_lists".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.sane_lists.SaneListExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.codehilite".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.codehilite.CodeHiliteExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.fenced_code".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.fenced_code.FencedCodeExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.toc".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.toc.TocExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.tables".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.tables.TableExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.nl2br".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.nl2br.Nl2BrExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.sane_lists".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.sane_lists.SaneListExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.codehilite".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.codehilite.CodeHiliteExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.fenced_code".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.fenced_code.FencedCodeExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.toc".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.toc.TocExtension".
uwsgi_1_820da895ad7a | Successfully imported extension module "markdown.extensions.tables".
uwsgi_1_820da895ad7a | Successfully loaded extension "markdown.extensions.tables.TableExtension".

I would also love to have less verbose output

This can be disabled with:
import logging

logging.getLogger('MARKDOWN').setLevel(logging.WARNING)


Custom Editor toggleEditorType Command Only Works One Way

Does this issue occur when all extensions are disabled?:  Switch to a custom editor view.
Try the View: Toggle Editor Type command. The editor should switch to the text editor.
When doing this again, the editor does nothing. However, it should be switching to the highest-priority custom editor.

\closedWith 67bd4e206961dadb4e0d5eb368f97d3a031f4d1f