Fix whitespace and commented code in the repository

I believe there are some style issues and some commented code.  Fix any style issues based on gofmt and implement anything hidden in code comments.

I'll give this a go!


Run checks with pytest

nose isn't maintained and does not work with Python 3.10. We've moved most of the rest of our infrastructure package tests to pytest.
While in the tests I also added a requirements.txt file for test dependencies and pruned argparse, which is in the standard library as of Python 3.2 and coverage which does not appear to be used in this project.

Because I renamed the Nosetests check, it was not rerun and so is stuck in Limbo. The actual check (both with pytest and with nose for now) is covered by "rosdistro / rosdep checks"


#1289: Enabling configuration option for caching of Mustache Views

Solves 1289.

Coverage decreased (-0.02%) to 81.966% when pulling 39303e4f50d50c35525c51532c3dcc9a55e900e4 on lefloh:1289 into 668b356ce3ea88e6892fcbdcf0bf25830f76e9a2 on dropwizard:master.

Thanks for your contribution!


Lagotto is not returning a 404 response on pages that don't exist.

Requesting a page that doesn't exist returns a "302 - Found" response and takes you to the homepage.
Lagotto version 3.9.6

This is intentionally, but I agreed that it can be confusing. Will put in a fix to return a 404 response without a redirect instead. The API behaves as expected.


Remove pods before deleting the containers using crictl

We should remove the pods before deleting the container using crictl, this way old pods configuration/logs are not be part of our image.

This is not required anymore since the pods are cleaned when we shutdown the node gracefully.


Add Coretime examples

With Coretime development making progress, we need to run integration tests for the Coretime parachain. This PR just tests the basic XCM case.

Closing this, putting the e2e tests in the polkado-sdk repo instead -> https://github.com/paritytech/polkadot-sdk/pull/2360


predict pose on a single image

hi
thanks for your amazing work. i want to use this work to predict pose of images which are not present in the main database.(this image is available in the dataset but after changing the image directory it can't predict the pose). can you help me to find a way to do so?

Please ask a more concrete question or provide a clear description of

what data you have,
what you want to achieve,
what steps you have taken (including code or commands), and
where it is failing or why it does not match your expectations.

I will not be able to help otherwise. Thank you.

What steps have you taken...code wise and any other...to fix the issue....
TheRealestAround
On Sat, Nov 21, 2020, 3:06 PM Paul-Edouard Sarlin<EMAIL_ADDRESS>wrote:

Please ask a more concrete question or provide a clear description of

what data you have,
what you want to achieve,
what steps you have taken (including code or commands), and
where it is failing or why it does not match your expectations.

I will not be able to help otherwise. Thank you.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cvg/Hierarchical-Localization/issues/26#issuecomment-731636585,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQGV2BOEBXN3YJJ2WC74ZZLSRATV5ANCNFSM4T52YVQQ
.

I want to implement this code (Aachen outdoor)  with my custom dataset and then use the results to predict pose of a single image.
The feature extraction and feature matching part runs well and there is no problem, but when I try an image in an address other than what was in the first database it doesn't run localization.
To illustrate, I tried using aachen dataset to see whether it works with this dataset or not; but when I feed the localization part a query of an image that is not in the main address (i.e instead of images/query/day/nexus4/   I changed image address to images/query ) but it doesn't work anymore. How can I deal with this address issue?
localize_sfm.main(
reference_sfm / 'model',
dataset / 'queries/*time_queries_with_intrinsics.txt',
loc_pairs,
outputs / f"{feature_conf['output']}.h5",
outputs / f"{feature_conf['output']}{matcher_conf['output']}_{loc_pairs.stem}.h5",
results,
covisibility_clustering=False)
here instead of (  dataset / 'queries/*_time_queries_with_intrinsics.txt ), i put my queries of the image in another address but it didn't work.

Sorry for the late reply. You would need to create a new query_list_with_intrinsics.txt file that contains a list of the new queries with their intrinsics in text format. You also need to extract their features and match them. I cannot help further without a clear error message.

Closing this issue due to inactivity. Feel free to reopen it.


master layout: change the mfact dispatcher to use splitratio

Describe your PR, what does it fix/add?
Change the mfact dispatcher to use split ratio, allowing increment/decrement.
I realized this dispatcher does the same thing as splitratio, so I'm just changing it to call the latter, this allows you to increment/decrement the mfact in addition to only being able to set the exact mfact.
I also thought about just removing it since splitratio exists, but the splitratio dispatcher is really confusing, as it does two different and not necessarily related things in dwindle and master. You also wont find it in the master layout wiki when you look for it since it's not a layout specific dispatcher, but it kinda should be imo. The mfact is a very layout-specific config that is specific to master, and you usually won't look in the universal dispatchers for such a thing, and it's not clear that splitratio changes the mfact in master. I think it would make more sense in the future to have two different dispatchers separately in dwindle and master that will do what this splitratio dispatcher does. Having a dispatcher for the mfact itself seems much more easier to understand.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Needs wiki mr
Is it ready for merging, or does it need work?

I added a wiki mr


High score

Description
I am removing this section relating to the High Score code from pull request#425 into a separate branch so that it can be merged by itself.
Type of change
Please delete options that are not relevant.

[x] Documentation (update or new)

Checklist:

[x] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have requested a review from ... on the Pull Request

I am leaving this branch in order to be merged. Other forks I will create them one by one.

I am leaving this branch in order to be merged. Other forks I will create them one by one.

Closing PR, no review.


Window Style resource not found

Describe the bug
Unable to set MainWindow style
To Reproduce
Steps to reproduce the behavior:

Create a WPF project.
Add <ResourceDictionary Source="pack://application:,,,/WPFUI;component/Styles/WPFUI.xaml" /> to App.xaml.
Set MainWindow style to UiWindowRounded
See error 'UiWindowRounded' resource not found.

Expected behavior
XDG0062 Object reference not set to an instance of an object in App.xaml.
Desktop (please complete the following information):

OS: Windows 10
.NET: net6.0-windows10.0.22000.0
Version: 1.2.2

I think it's a wpf problem.


Very serious bug

Bug is duplicate items
holding Shift and with some armor in hand
Right click on the chest that is set and with no armor in the body
the item doubles
And without the key
I hope i get it
Thank you
Do not call writing because I'm Brazilian.

I just verified this. Shift and left click crate with armor while not wearing armor, and it duplicates the armor by equipping it.

This seems to only be an issue in creative, in survival it doesn't exist.


Add logic for changing icon colors on dashboard

The dashboard / overview page has space for individual events, along with a colored icon. Currently that icon is a hard-coded image path. Instead, these image paths should be based on whether the event has happened today (green), or in the last few days (yellow / red).
This will replace the code originally used in a functions file similar to:
	if ($count == 0) {
		$background = "media/red.png";
	} elseif ($count == 1) {
		$background = "media/yellow.png";
	} elseif ($count >= 2) {
		$background = "media/green.png";
	} else {
		$background = "media/red.png";
	}

	echo $background;

Resolved with PR 15: https://github.com/ubcs-io/trackr/pull/15


Define all endpoints and describe it in "prototype api" document

prototype api document: link

prototype api link in stoplight:
link


Encounter "Stan does not support NA" when using prophet function

OS: Windows 10 Pro, R version: 3.3.3, Gui: RStudio
Screen shot attached of RStudio code and execution, plus the used data set pm.xlsx
The issue can be seen in the attached images. When I load a similar Wikipedia page traffic data set, and use the prophet function I receive the following error. The steps used was sourced from the following URL. (https://facebookincubator.github.io/prophet/docs/quick_start.html#r-api)
"Error in FUN(x[[i]],...) : Stan does not support NA (in t) in data failed to preprocess the data; optimization not done
Error in matrix(m$params[[name]], nrow = n.iteration) : 'data' must be of a vector type, was 'NULL'"
When I validate my source data set I do not see null or NA values. Would this error be contributed to a formatting error when the prophet function runs?

pm.xlsx

It looks like parsing the dates is failing. We use the zoo package to convert the ds column to date format, and you can see that this is introducing a bunch of NAs if you run:
ds <- zoo::as.Date(history$ds)

You can see the issue by trying to run it on a single date:
> zoo::as.Date('8/13/2015')
Error in charToDate(x) :
  character string is not in a standard unambiguous format

The solution is to convert it to date format before passing it in to Prophet.
https://github.com/facebookincubator/prophet/commit/68f88e2b733d2f91769359e7e245472ccc87a2bf raises an exception if the date parsing fails, which should make this issue less opaque in the future.

I've tried the steps of correcting date and y formats and removing nulls, and still get this error message:
Error in FUN(X[[i]], ...) : Stan does not support NA (in y) in data failed to preprocess the data; optimization not done Error in matrix(m$params[[name]], nrow = n.iteration) :    'data' must be of a vector type, was 'NULL' Called from: matrix(m$params[[name]], nrow = n.iteration)
Also, my code is in a loop and tried to fix things with the suggestions in this link (https://github.com/facebookincubator/prophet/issues/93), but still to no avail.
Only breaking on loops of 12 iterations.

Can you check what version of prophet you are using? Is there any chance you can post the data that is failing so that I can replicate?

I'm using prophet version 0.1.1.
I managed to pinpoint the issue, which occurs with non-unique y-values. For example, it breaks if the y-value is all 0.

Thanks, we do currently scale data by dividing by max(abs(y)), which divides by zero if all y's are 0. This needs to be fixed.

I'm going to close the issue here to consolidate it with #251 , where it will be fixed.


Outdated READMEs and HTML previews in the example folders

Some of the example folders include outdated READMEs that link to HTML previews of outdated versions of the example notebooks. These should be updated or removed.

We should add these notebooks to readthedocs, then remove the READMEs and outdated HTMLs


Training surrogate model

I downloaded the weights from drive.
When I load the encoder's weights and use the encoder, I get this error:
Missing key(s) in state_dict:in state_dict: "gconv_input.1.nonlocal1.g.0.weight", "gconv_input.1.nonlocal1.g.0.bias", "gconv_input.1.nonlocal1.theta.weight", "gconv_input.1.nonlocal1.theta.bias", "gconv_input.1.nonlocal1.phi.0.weight", "gconv_input.1.nonlocal1.phi.0.bias", "gconv_input.1.nonlocal1.concat_project.0.weight", "gconv_input.1.nonlocal1.W.0.weight", "gconv_input.1.nonlocal1.W.0.bias", "gconv_input.1.nonlocal1.W.1.weight", "gconv_input.1.nonlocal1.W.1.bias", "gconv_input.1.nonlocal1.W.1.running_mean", "gconv_input.1.nonlocal1.W.1.running_var", "gconv_layers.1.nonlocal1.g.0.weight", "gconv_layers.1.nonlocal1.g.0.bias", "gconv_layers.1.nonlocal1.theta.weight", "gconv_layers.1.nonlocal1.theta.bias", "gconv_layers.1.nonlocal1.phi.0.weight", "gconv_layers.1.nonlocal1.phi.0.bias", "gconv_layers.1.nonlocal1.concat_project.0.weight", "gconv_layers.1.nonlocal1.W.0.weight", "gconv_layers.1.nonlocal1.W.0.bias", "gconv_layers.1.nonlocal1.W.1.weight", "gconv_layers.1.nonlocal1.W.1.bias", "gconv_layers.1.nonlocal1.W.1.running_mean", "gconv_layers.1.nonlocal1.W.1.running_var", "gconv_layers.3.nonlocal1.g.0.weight", "gconv_layers.3.nonlocal1.g.0.bias", "gconv_layers.3.nonlocal1.theta.weight", "gconv_layers.3.nonlocal1.theta.bias", "gconv_layers.3.nonlocal1.phi.0.weight", "gconv_layers.3.nonlocal1.phi.0.bias", "gconv_layers.3.nonlocal1.concat_project.0.weight", "gconv_layers.3.nonlocal1.W.0.weight", "gconv_layers.3.nonlocal1.W.0.bias", "gconv_layers.3.nonlocal1.W.1.weight", "gconv_layers.3.nonlocal1.W.1.bias", "gconv_layers.3.nonlocal1.W.1.running_mean", "gconv_layers.3.nonlocal1.W.1.running_var"
Should I define the encoder in a different way? I used the module defined in encoding.py
waiting for your replay!

Thank you for raising this issue.
The encoder was trained using DataParallel.
Please use this to wrap the model before calling it.
class WrappedModel(nn.Module):
	def __init__(self, encoder):
		super(WrappedModel, self).__init__()
		self.module = encoder
	def forward(self, x):
		return self.module(x)

Thanks! Have a nice day~~


Loss of shape information when using dilation_rate != 1 in Conv layers

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):
TensorFlow version (use command below):
Python version:
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
Running TF 2.3.0 in colab I have come across an issue very similar to the one fixed in #29542 . The difference however being that I have an extra dimension that is undefined at layer construction time. With a dilation rate = 1 the Conv2D layer in the following code produces an output shape as expected (None, None, 512, 64). However, for layers with a dilation rate > 1, the "width" dimension shape information is lost and the result is (None, None, None, 64).
import tensorflow as tf

class DenseBlock(tf.keras.Model):
  def __init__(self, input_size, depth=5, in_channels=64):
    super(DenseBlock, self).__init__(name='')
    self.depth = depth
    self.in_channels = in_channels
    self.pad = tf.keras.layers.ZeroPadding2D(((1, 0), (1, 1)))
    self.twidth = 2
    self.kernel_size = (self.twidth, 3)
    for i in range(self.depth):
      dil = 2**i
      pad_length = self.twidth + (dil-1)*(self.twidth-1)-1
      setattr(self, 'pad{}'.format(i+1), tf.keras.layers.ZeroPadding2D(((pad_length, 0), (1, 1))))
      setattr(self, 'conv{}'.format(i+1), tf.keras.layers.Conv2D(filters=self.in_channels, kernel_size=self.kernel_size, dilation_rate=(dil, 1)))
      setattr(self, 'norm{}'.format(i+1), tf.keras.layers.LayerNormalization())
      setattr(self, 'prelu{}'.format(i+1), tf.keras.layers.PReLU(shared_axes=[1, 2]))

  def call(self, input_tensor):
    skip = input_tensor
    for i in range(self.depth):
      print('Dilation rate', 2**i)
      x = getattr(self, 'pad{}'.format(i+1))(skip)
      print(x.shape)
      x = getattr(self, 'conv{}'.format(i+1))(x)
      print(x.shape)
      x = getattr(self, 'norm{}'.format(i+1))(x)
      x = getattr(self, 'prelu{}'.format(i+1))(x)
      skip = tf.concat((x, skip), axis=3)
    return x

input = tf.keras.layers.Input(shape=(None, 512, 64))
x = DenseBlock(512, 5, 64)(input)

Describe the expected behavior
I believe that the behaviour for dilation rate > 1 should match that of the case where dilation rate = 1.
Standalone code to reproduce the issue
Here is a link to a colab notebook that reproduces the issue
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
The cell output is:
2.3.0
Dilation rate 1
(None, None, 514, 64)
(None, None, 512, 64)
Dilation rate 2
(None, None, 514, 128)
(None, None, None, 64)
Dilation rate 4
(None, None, 514, 192)
(None, None, None, 64)
Dilation rate 8
(None, None, 514, 256)
(None, None, None, 64)
Dilation rate 16
(None, None, 514, 320)
(None, None, None, 64)

Was able to reproduce the issue with TF v2.3 and TF-nightly. Please find the attached gist. Thanks!


No retry when broker is unreachable

Hi, I have a problem with MassTransit.RabbitMQ 5.1.0 on netcoreapp2.0. After some network issues and single exception reports there is no retry and masstransit does nothing with messages on rabbit queue. Rabbit management reports 0 consumers associated with queue despite the fact that application is still working and reports no more problems. The only solution is to restart application.
Message:
Receive transport failed. Input address: rabbitmq://rabbit.local/bus-SERVER-1-Some.Name-qhhyyyd8pxcj5f1bbdkhiz4a8r?durable=false&autodelete=true
Stacktrace:
MassTransit.RabbitMqTransport.RabbitMqConnectionException: Broker unreachable: username@rabbit.local:5672/ ---> RabbitMQ.Client.Exceptions.BrokerUnreachableException: None of the specified endpoints were reachable ---> System.IO.IOException: connection.start was never received, likely due to a network timeout
   at RabbitMQ.Client.Framing.Impl.Connection.StartAndTune()
   at RabbitMQ.Client.Framing.Impl.Connection.Open(Boolean insist)
   at RabbitMQ.Client.Framing.Impl.ProtocolBase.CreateConnection(IConnectionFactory factory, Boolean insist, IFrameHandler frameHandler, String clientProvidedName)
   at RabbitMQ.Client.ConnectionFactory.CreateConnection(IEndpointResolver endpointResolver, String clientProvidedName)
   --- End of inner exception stack trace ---
   at RabbitMQ.Client.ConnectionFactory.CreateConnection(IEndpointResolver endpointResolver, String clientProvidedName)
   at MassTransit.RabbitMqTransport.Integration.ConnectionContextFactory.<CreateConnection>d__9.MoveNext()
   --- End of inner exception stack trace ---
   at MassTransit.RabbitMqTransport.Integration.ConnectionContextFactory.<CreateConnection>d__9.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at MassTransit.RabbitMqTransport.Integration.ConnectionContextFactory.<CreateSharedConnection>d__8.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GreenPipes.Agents.PipeContextSupervisor`1.<GreenPipes-IPipeContextSource<TContext>-Send>d__8.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at GreenPipes.Agents.PipeContextSupervisor`1.<GreenPipes-IPipeContextSource<TContext>-Send>d__8.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at GreenPipes.Agents.PipeContextSupervisor`1.<GreenPipes-IPipeContextSource<TContext>-Send>d__8.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at MassTransit.RabbitMqTransport.Transport.RabbitMqReceiveTransport.<<Receiver>b__15_0>d.MoveNext()

Duplicate of #1121 - resolved in https://github.com/MassTransit/MassTransit/pull/1122/commits/317ae49ca7377e44c6c7982107573c7ef23cea47


Provide text deltas to TextEditingController

Text deltas became available recently, but to my understanding, it is available only if you create a text editor with DeltaTextInputClient. I think it is too much for most developers to implement their own editor.
Use case
I've created a package with a TextEditingController that styles text according to some rules as you type. It works, but the longer the text is, the slower text changes become visible because it takes more time to parse the text.
If I have to implement a text editor to achieve the above, the API of my package must be changed. In addition, thinking about the fact that even the Flutter's standard TextField created by awesome people from the Flutter team still has bugs and is far behind native text input components in terms of quality, I doubt that general developers including me can create good editors on our own.
Proposal
Is it possible to make deltas accessible from TextEditingController? It will become possible to debounce parsing by instead temporarily updating the text spans corresponding to only the changed parts.

Hello @kaboc. Thank you for filing this proposal. Labelling for further insights from the team.

even the TextSelectionGestureDetectorBuilderDelegate is tight to EditableTextState which only implements AutofillClient.
I agree there is too much to copy/paste/tweak 😬

Very much agree. This would be very useful for our project us well.


Silverstripe won't work with newest Apache 2.4.X

Affected Version
Apache 2.4.39+
bigfork/silverstripe-oauth-login          2.0.0              SilverStripe logins via OAuth2, using the PHP League's OAuth2 client
dnadesign/silverstripe-populate           2.0.0              Populate your database through YAML files
friendsofphp/php-cs-fixer                 v2.15.0            A tool to automatically fix PHP code style
lekoala/silverstripe-debugbar             2.0.3              DebugBar for SilverStripe CMS
phpro/grumphp                             v0.14.3            A composer plugin that enables source code quality checks.
phpunit/phpunit                           5.7.27             The PHP Unit Testing framework.
ramsey/uuid                               3.8.0              Formerly rhumsaa/uuid. A PHP 5.4+ library for generating RFC 4122 version 1, 3, 4, and 5 universally unique identifiers (UUID).
sensiolabs/security-checker               v5.0.3             A security checker for your composer.lock
silverstripe/graphql-devtools             dev-master d73f56c Tools to help developers building new applications on SilverStripeâs GraphQL API
silverstripe/postgresql                   2.2.0              SilverStripe now has tentative support for PostgreSQL ('Postgres')
silverstripe/recipe-cms                   4.3.0              SilverStripe recipe for fully featured page and asset content editing
silverstripe/recipe-plugin                1.3.0              Helper plugin to install SilverStripe recipes
squizlabs/php_codesniffer                 3.4.2              PHP_CodeSniffer tokenizes PHP, JavaScript and CSS files and detects violations of a defined set of coding standards.
symbiote/silverstripe-gridfieldextensions 3.2.1              A collection of useful grid field components
symbiote/silverstripe-queuedjobs          4.4.0              A framework for defining and running background jobs in a queued manner
thenetworg/oauth2-azure                   v1.4.2             Azure Active Directory OAuth 2.0 Client Provider for The PHP League OAuth2-Client
unclecheese/display-logic                 2.0.2              Allows assignment of conditions for display and hide of specific form fields based on client side behavior.
Description
SilverStripe is still using Order, Deny, Allow directives in .htaccess files. This was deprecated with the release of Apache 2.4 and has finally been removed as of 2.4.39 causing SilverStripe to no longer work.
https://httpd.apache.org/docs/2.4/howto/access.html
https://httpd.apache.org/docs/2.4/upgrading.html
Steps to Reproduce
Run SilverStripe with Apache 2.4.39 or later. I'm using OpenSUSE Tumbleweed
Osiris:~ # cat /etc/os-release
NAME="openSUSE Tumbleweed"
VERSION="20190512"
ID="opensuse-tumbleweed"
ID_LIKE="opensuse suse"
VERSION_ID="20190512"
PRETTY_NAME="openSUSE Tumbleweed"
ANSI_COLOR="0;32"
CPE_NAME="cpe:/o:opensuse:tumbleweed:20190512"
BUG_REPORT_URL="https://bugs.opensuse.org"
HOME_URL="https://www.opensuse.org/"
LOGO="distributor-logo"
Error in Apache Log:
/SDLT/public/resources/.htaccess: Invalid command 'Order', perhaps misspelled or defined by a module not included in the server

That could be an issue, but please read the upgrading document. At the end:

Invalid command 'Require', perhaps misspelled or defined by a module not included in the server configuration, or Invalid command 'Order', perhaps misspelled or defined by a module not included in the server configuration - load module mod_access_compat, or update configuration to 2.4 authorization directives.

So you need to load the access_compat module. ( just checked, its still there in the apache2 2.4.39-2.1 rpm on opensuse tumbleweed )
But i do agree that it's good to update the default .htaccess and documentation and start using the new directives.

Hi Dirk,
Thanks for this. I'm working around it with some docker containers, but good to know its still in Tumbleweed.
S.

Do you think we should update the Apache config file or the documentation? Would one of you be keen to make a pull request?

My preference would be the .htaccess files, as this issue is going to be more common going forward as deployments of apache don't by default enable the compat mode. This is how I discovered it, I did an update in the weekend and tried to deploy SS today.
I unfortunately do not have the knowledge of SS to make a pull request at this point.

I'm not sure where that .htaccess comes from. If you have a location, maybe in the cms, that would be helpfull.
I could check it and try to make a suggestion on the changes needed. You would probably need a backward-compatible check in there too.

Are we talking about the assets htaccess file? If so it’s generated from a .ss template which you could find by searching for the comment in the output file, it’s ProtectedAdapter.ss or something- sorry I’m not at a computer right now

I found the .htaccess in these repo/files
framework/src/Dev/Install/Installer.php
silverstripe/recipe-core/public/.htaccess
That's something else than @robbieaverill suggested. Am I missing something?

@derkgort  I believe Robbie is referring to this pair of templates which are used to generate .htaccess files in the assets directory:

https://github.com/silverstripe/silverstripe-assets/blob/1/templates/SilverStripe/Assets/Flysystem/ProtectedAssetAdapter_HTAccess.ss
https://github.com/silverstripe/silverstripe-assets/blob/1/templates/SilverStripe/Assets/Flysystem/PublicAssetAdapter_HTAccess.ss

They don’t seem to use Order, so should be okay.

But the first does use "Deny from all". Which comes from the same depricated module/functions. Good to know.

FWIW, I enabled mod_access_compat on my installation and it would not allow me to access any of the SS installation files. It seems to have some weird behaviour.
All in all, I have to modify
/public/.htaccess
/public/assets/.htaccess
/public/resources/,htaccess
in order to get it to function.

What did you change? And what kind of "weird" behaviour?

In /etc/sysconfig/apache2 I enabled access_compat
Note: /etc/apache2/loadmodule.conf is not used
Then I'd get 403 Access denied across the board. When I changed the .htaccess files to Require all denied to replace the Order/Allow/Deny directives everything works. This is still a bit of a hassle as when the .htaccess files are generated it stops things working (installation etc) until you correct the file manually.
My DocumentRoot is /SDLT/public/

Just had a read through all the wonderful comments. Here's what I took away. Let me know if I missed anything important.
Summary

Apache 2.4 introduced the Require directive to replace Order, Deny, Allow.
The Require directive is managed by mod_authz_host. If you want the old directives to keep working you can enable mod_access_compat ... which most Linux distros seem to be doing out of the box.
Some Linux distros (OpenSUSE) are starting to disable mod_access_compat by default, which means that the default .htaccess files that ship with your standard SilverStripe install won't work out of the box. People in that boat can solve their problem by either:

Re-enabling mod_access_compat
Edit their .htaccess files (including asset's htaccess template) to use the newer directive.

Possible next steps

Update documentation with guidance for users who want to use the Require directive.
Drop official support for Apache 2.2

Our doc says we support Apache 2.0+ with mod_rewrite and "AllowOverride All" set
Apache 2.2's final release was in July 2017
Apache 2.4 has been available since 2012

Update installer, recipe-core and recipe-cms to use Require over Deny/Allow

This would only affect users starting brand new projects
Existing users would still have their old .htaccess files

Update assets' HTACCES SS templates to use Require.

This would affect anyone upgrading to SS4.5 who didn't customise those files
Projects running Apache 2.2 ... or Apache 2.4 with mod_authz_host disabled ... would need override their HTACCESS SS templates.

Our doc says we support Apache 2.0+ with mod_rewrite and "AllowOverride All" set

I've since rewritten the server requirements, and it no longer spells out which Apache version we support. Because specific statements like that get us into trouble, and don't age well. In the end, we provide some starting points for configuring your hosting environment, but it is not the primary responsibility of a PHP web framework to ensure compatibility with webservers.
Apache 2.2 calling it a "final release" is just another way of saying end of life, meaning they no longer provide security fixes. So this isn't really a discussion. We have a bug in our framework (current version of Apache breaks), and we should fix it to be compatible with the minimum supported version of Apache (2.4).

Some internal risk assessments on this in https://silverstripe.freshdesk.com/a/tickets/57550.
Here's the section relevant to where we apply those protections in CWP and core modules:

Deny access to *.ss and *.yaml (potentially sensitive config values) everywhere

.htaccess via 3.x defaults: https://github.com/silverstripe/silverstripe-installer/blob/3/.htaccess
public/.htaccess via recipe-core in 4.x: https://github.com/silverstripe/recipe-core/blob/4/public/.htaccess

Deny access to *.php in app/ folder

app/.htaccess via recipe-core in 4.x:  https://github.com/silverstripe/recipe-core/blob/4/app/.htaccess
app/.htaccess via CWP 1.x and 2.x installer: https://github.com/silverstripe/cwp-installer/blob/master/app/.htaccess

Deny access to *.php in CWP 1.x (3.x) core modules

framework/.htaccess via https://github.com/silverstripe/silverstripe-framework/blob/3/.htaccess
cms/.htaccess via https://github.com/silverstripe/silverstripe-cms/blob/3/.htaccess
realme/.htaccess via https://github.com/silverstripe/silverstripe-realme/blob/master/.htaccess
... more modules (need to check)

Note: All supported modules in CWP 2.x (4.x) have shifted to composer-managed directories in vendor/, which prevents access via a highlevel .htaccess file rather than module specific .htaccess files. This new style of writing modules is still opt-in, so there might be modules out there which are still affected (just not ours).
Not affected:

Public assets in CWP 2.x (4.x) via assets/.protected/.htaccess: https://github.com/silverstripe/silverstripe-assets/blob/1/templates/SilverStripe/Assets/Flysystem/PublicAssetAdapter_HTAccess.ss. This uses rewrites rather than Deny rules.
secureassets module in CWP 1.x isn't affected, since it redirects requests rather than denying hem: https://github.com/silverstripe/silverstripe-secureassets/blob/f9d54e7b419574e583f3b958a2f21db163877971/_config.php#L5

Of all modules installed as part of cwp-recipe-kitchen-sink, there are the following .htaccess files:
$ find . -name '.htaccess'
./public/resources/.htaccess
./public/.htaccess
./app/.htaccess
./.htaccess
./vendor/cwp/cwp-installer/public/assets/.htaccess
./vendor/cwp/cwp-installer/app/.htaccess
./vendor/cwp/cwp-installer/.htaccess
./vendor/silverstripe/recipe-core/public/.htaccess
./vendor/silverstripe/recipe-core/app/.htaccess
./vendor/silverstripe/recipe-core/.htaccess
./vendor/silverstripe/recipe-cms/.htaccess
./vendor/silverstripe/vendor-plugin/resources/.htaccess
./vendor/silverstripe/campaign-admin/client/.htaccess

Missing from this list because it's a SilverStripe template that generates a .htaccess file:
./vendor/silverstripe/assets/templates/SilverStripe/Assets/Flysystem/ProtectedAssetAdapter_HTAccess.ss

[ ] cwp/cwp-installer: https://github.com/silverstripe/cwp-installer/pull/27
[ ] silverstripe/recipe-core: https://github.com/silverstripe/recipe-core/pull/49
[x] silverstripe/recipe-cms: unaffected.
[ ] silverstripe/vendor-plugin: https://github.com/silverstripe/vendor-plugin/pull/30
[x] silverstripe/campaign-admin: unaffected.
[ ] silverstripe/assets: https://github.com/silverstripe/silverstripe-assets/pull/334

Not going to patch SS3 modules, they're out of support save for security issues.

Yep, fair call. This is only a security issue if a server is misconfigured (not running the Apache compat module which is required for what's now effectively a legacy SilverStripe release)

All PR's open, CI green. 💚
Calling this done.
Just waiting for mergers before closing 💜

FYI I tried disabling mod_authz_host on my Ubuntu install just to see what kind of error you would get. I got some pretty nasty warning and Apache wouldn't even restart afterwards. So I think it's a pretty safe assumption that no one out there is running Apache 2.4 without support for Require.
WARNING: The following essential module will be disabled.
This might result in unexpected behavior and should NOT be done
unless you know exactly what you are doing!
 authz_host

To continue type in the phrase 'Yes, do as I say!' or retry by passing '-f':

Peer reviewed the 2 other PRs.
I'm thinking we probably need to get everythign merge and do a test run on SSP and CWP.

Tested on SSP and CWP. Everything works fine.

This issue has been worked on as part of a larger initiative focused on reducing the experience debt of the SilverStripe CMS.
Thank you for taking the time to raise this issue and/ or provide feedback supporting the implementation.
This is an initiative from the teams maintaining the commercially supported module list. If you're interested to read more about this initiative and keep up with our progress have a look at our blog post on experience debt.


Rework search results design

Highlight with blue color #543

Update design of search results: add separator, make titles in caps (as on transaction details screen) https://zpl.io/brPoEm7

Search by name https://zpl.io/V0Nzo7E

If no search results display text "There are no transactions matching search criteria", instead of "Your transaction list is empty" https://zpl.io/2pNg33y

Current design:

Please move the "comment"(description) above the separator as it is included in the basic information block

Please move the transaction ID under the field name

in master:

in design:

Please in the search result remove the ":" icon after the fields (tx id, sending/receiving address, kernel id ...)

Checked


Return .None instead of nil

I really like use .None instead of nil where a function returns an optional value. I think it makes more sense. I hope you will agree with me.

Sorry, I think the predominant style is to use nil to represent this case of Optional.

Yes, @gribozavr has it right; using nil was an intentional choice.


Clarify the getting started - incorrect path

The docs state that make can be started from the \docs directory, but make files only exist in the sub dirs \aspnet and \mvc (with thanks to @dpaquette for helping out this Python/Sphinx rookie).

Hi @MisterJames, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

Thanks! Yeah, the project structure changed.  :-|

I can't imagine how hard it is to keep all these docs in line. Hope this helps some.
Cheers.


Deprecate and remove support for adv_target_adjustments

adv_target_adjustments was an early experiment, prior to the ZTpredBG changes, attempting to reduce highs. as it exists today, it does not succeed in reducing highs more than it increases lows. For example, in a 7-day oref0-backtest simulator run, it increased % time <70 by 2.6% while only reducing % time >180 by 0.8%.
This PR deprecates and removes adv_target_adjustments to clean up code in preparation for other efforts to accomplish the same thing (for example by extending the ZTpredBG work).
This PR also reorders some code (per earlier TODO comments) to make it more readable.

Any objections to this approach? Does anyone use these features? Does anyone want to do any more testing on whether adv_target_adjustments are useful? Does anyone want to post to FB to see if anyone there uses it? If no to all of those, I'll go ahead and merge it to dev.


Build fails with GCC 6.4.0

When building using GCC 6.4.0 and OpenMPI 3.1.3 make throws the following error:
mpicxx -O3 -std=c++0x -w -fopenmp -I/include -c -o obj/MpiManager_fem.o src/MpiManager_fem.cpp
In file included from src/../inc/FEMBody.h:29:0,
                 from src/../inc/IBBody.h:30,
                 from src/../inc/ObjectManager.h:30,
                 from src/MpiManager_fem.cpp:24:
src/../inc/FEMElement.h:72:21: error: expected ‘)’ before ‘*’ token
  FEMElement(FEMBody *fPtr, int i, int DOFs, double spacing, double height, double depth,
                     ^
std::vector<double> &angles, double density, double E);

In file included from src/../inc/FEMBody.h:29:0,
                 from src/../inc/IBBody.h:30,
                 from src/../inc/ObjectManager.h:30,
                 from src/MpiManager_fem.cpp:24:
src/../inc/FEMElement.h:79:2: error: ‘FEMBody’ does not name a type
  FEMBody *fPtr;
  ^~~~~~~
make: *** [obj/MpiManager_fem.o] Error 1

when compiling the source file MpiManager_fem.cpp.

This looks like an issue with the mixture of headers and forward declarations. Will take a look at it in the next few days.

Resolved conflict with header files in FEM module and build now succeeds on the reported system. Incorporated into version 1.7.5.


Bootstrapping express v4 on start up

What is the recommended way to bootstrap an Express application so that on start up it will call out to AWS S3 to retrieve some secrets before starting up? Having used Sails.js it allowed you to specify a bootstrap.js file that would allow the server to configure itself before bringing the server up.
How could I do this in Express?
Thanks!

You could write a file that does bootstrapping and then creates or listens to the port in a callback. For example:
getCreds(function (err, creds) {
  if (err) {
    throw err
  }

  var app = express()
  app.listen(port)
})

I have a www/bin file and a separate index file which instantiates and exports the express app. Ideally I'd like the bootstrapping step to be in the index.js file so that it's invoked for testing etc. Is that possible or do I need to bootstrap in www/bin?
import winston from 'winston';
import bodyParser from 'body-parser';

import app from '../index';

app.use(bodyParser.json());       // to support JSON-encoded bodies
app.use(bodyParser.urlencoded({     // to support URL-encoded bodies
  extended: true
}));

const port = 3002;
app.listen(port, () => {
  winston.info(`Server listening on port ${port}!`);
});

import express from 'express';
import {initialize} from './services/appService';
import healthCheckRouter from './routes/healthCheckRouter';
import loginRouter from './routes/loginRouter';

initialize(); // <<< Where I'm retrieving credentials. Would like this to complete then the app exported.
const app = express();

// ---------------------------- Routes ----------------------------
app.use('/', express.static('dist/client/'));
app.use('/login', loginRouter);
app.use('/health-check', healthCheckRouter);

export default app;

If you use any test runner, like mocha or ava, you will have a before function which is perfect for waiting on the express server to start.

You're right, I can initialize the app in the beforeEach. Thanks!

I do something similar to what you outlined, but in addition I use a module runnable so that I can still just run $ node index.js and get a default server.  I use this so that I can hard code dev configs in the index file, and do all my production specific stuff in the bin script.
For testing I do exactly what @LinusU recommended, but I make sure to pass null as the port so that I get an ephemeral port, that way your tests don't randomly fail because of a port conflict.

oh thanks~ Didn't know about passing in null~


ENOENT when running prisma with pkg

npm i -g pkg
npm i @prisma/cli
pkg node_modules/@prisma/cli

./cli-macos --version

results in
Error: ENOENT: no such file or directory, copyfile '/home/runner/.cache/prisma/master/dc0f43d1460553447c563479493914279205d48f/debian-openssl-1.1.x/prisma-fmt' -><EMAIL_ADDRESS>

We can test it by pushing to prisma and rebase into https://github.com/prisma/e2e-tests/pull/425

Seems the issue still exists with dev.12

@timsuchanek I guess this doesn't work anymore https://github.com/prisma/prisma/blob/1bebe39b5a7299392c15d913af3962083c845f11/src/packages/sdk/src/resolveBinary.ts#L48-L52

I can confirm this:

version: 2.1.9-dev.29

Thanks a lot for reporting 🙏
This issue is fixed in the latest dev version of @prisma/cli.
You can try it out with npm i -g @prisma/cli@dev.
In case it’s not fixed for you - please let us know and we’ll reopen this issue!


[FEA] ninja-build for cudf submodule

Is your feature request related to a problem? Please describe.
follow-up of https://github.com/NVIDIA/spark-rapids-jni/pull/2
Leverage ninja-build to speed up cudf build

Fixed by #182


xWebAdministration: Add example usage of mandatory field ConfigurationPath in xiismimetypemapping.

ConfigurationPath is now a required field of xiismimetypemapping.  However, the example does not reflect this.
Fixes #426

[x] Examples appropriately added/updated.
[x ] New/changed code adheres to [DSC Resource Style Guidelines]

This change is

Codecov Report

Merging #427 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #427   +/-   ##
=======================================
  Coverage   90.77%   90.77%
=======================================
  Files          17       17
  Lines        2438     2438
=======================================
  Hits         2213     2213
  Misses        225      225

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed63bc...caac908. Read the comment docs.

@BarnumD the change looks good.  Can you also update the release notes in the readme.md?

Alright, how's that?

@BarnumD, thank you!


feat: exclude grafana login and support

what

exclude grafana login and support

why

grafana requires some clickops actions
support is mostly clickops unless using aws support bot

All the write perms for support according to policy_sentry
✗ policy_sentry query action-table --service support --access-level write

[
    "support:AddAttachmentsToSet",
    "support:AddCommunicationToCase",
    "support:CreateCase",
    "support:InitiateCallForCase",
    "support:InitiateChatForCase",
    "support:PutCaseAttributes",
    "support:RateCaseCommunication",
    "support:RefreshTrustedAdvisorCheck",
    "support:ResolveCase"
]

cc: @baolsen @phzietsman please review when time permits. For now, I have added these perms locally to excluded_scoped_actions using the APPEND mode

Thanks for the contribution (and the other issues logged)!
The new exclusions seem reasonable to me, I'll merge them in as a fix and release.
Please first merge master onto this branch (or rebase);
I made a small change to allow the checks to work again :)

@nitrocode thanks for the contribution!


ZSF - Unknown 'model' in GCE-3 FW.

It appears that the ZSF contains the model name, same number as patch file I think. Below are the ones that GL lets you select...
https://github.com/mungewell/zoom-zt2/blob/master/decode_zsp.py#L23
ModelEnum = Enum(Byte,
    G5N     = 0x00,
    G3N     = 0x02,
    G3XN    = 0x03,
    B3N     = 0x04,
    G1FOUR  = 0x0C,
    G1XFOUR = 0x0D,
    B1FOUR  = 0x0E,
    B1XFOUR = 0x0F,
    A1FOUR  = 0x15,
    A1XFOUR = 0x16,
)

However if you extract the ZSP blobs from the GCE-3 FW, there is another/unknown model (20 = 0x14).
GCE-3_v1.20_Win_E/unzipped/.rsrc/1041/BIN/extract_ZD2/ZSPF$ grep -H model *.dump
10440710.ZSPF.dump:        model = (enum) (unknown) 20
10461190.ZSPF.dump:        model = (enum) (unknown) 20
10481670.ZSPF.dump:        model = (enum) G5N 0
6623238.ZSPF.dump:        model = (enum) G3N 2
6643718.ZSPF.dump:        model = (enum) G3XN 3
6664198.ZSPF.dump:        model = (enum) B3N 4
6717446.ZSPF.dump:        model = (enum) G1FOUR 12
6762502.ZSPF.dump:        model = (enum) G1XFOUR 13
6930438.ZSPF.dump:        model = (enum) B1FOUR 14
6950918.ZSPF.dump:        model = (enum) B1XFOUR 15
6971398.ZSPF.dump:        model = (enum) A1FOUR 21
6995974.ZSPF.dump:        model = (enum) A1XFOUR 22
7020550.ZSPF.dump:        model = (enum) G5N 0
7131142.ZSPF.dump:        model = (enum) (unknown) 20
7151622.ZSPF.dump:        model = (enum) G5N 0
7172102.ZSPF.dump:        model = (enum) G3N 2
7192582.ZSPF.dump:        model = (enum) G3N 2
7213062.ZSPF.dump:        model = (enum) (unknown) 20

Hmm...
$ grep '"model' AllZDL6\(2\).lst
   "models":[
         "modelId":"0x6E000000",
         "modelName":"G5n",
         "modelId":"0x6E000200",
         "modelName":"G3n",
         "modelId":"0x6E000300",
         "modelName":"G3Xn",
         "modelId":"0x6E000400",
         "modelName":"B3n",
         "modelId":"0x6E000C00",
         "modelName":"G1 FOUR",
         "modelId":"0x6E000D00",
         "modelName":"G1X FOUR",
         "modelId":"0x6E000E00",
         "modelName":"B1 FOUR",
         "modelId":"0x6E000F00",
         "modelName":"B1X FOUR",
         "modelId":"0x6E001100",
         "modelName":"A1 FOUR",
         "modelId":"0x6E001200",
         "modelName":"A1X FOUR",
         "modelId":"0x6E001400",
         "modelName":"UNSEL",
         "modelId":"0x6E001500",
         "modelName":"A1 D",
         "modelId":"0x6E001600",
         "modelName":"A1X D",
         "modelId":"0x6E001300",
         "modelName":"G11",
         "modelId":"0x6E001700",
         "modelName":"H8"

I posted the how to change models here.
https://github.com/shooking/ZoomPedalFun/tree/main/GCE-3/InitialModeChangingExperiments#readme
I just haven't created the button to allow changing. Also i posted the hard reset / wipe on the wiki. Use with caution - sometimes one needs to reinstall the firmware after it.

Those are some pretty big logs, is it possible to summarize/annotate the steps? Looks like a large part might be sending the patches to the unit.
I'd like to understand if the model.zsf is sent from GL, or whether it (only) uses the ones embedded in the FW.

It is indeed  the patches too. Thats what happens when a model is loaded.
Each is a sysex sentence. I sometimes subst what i think the verbs and nouns are - hence my EditorOn.sh etc.


Incomplete command shows error in the wrong place

See sample scrapbook:

My third command is completely valid and works just fine if I execute it. Seems odd that it has a red squiggle - I would expect it right after the '.' on line 3, if at all. Also the error message means nothing to me

Complex issue, it's never going to work the way Eric wants it to...   But the main issue is the way the .g4 defines "db" as a token.

Closing this as wontfix since the fix is unfeasible.


chore: v6 update node version for test builds

What
Fix node version for build testing

@nicolethoen @wise-king-sullyman Any idea why the test_a11y failure?

@wise-king-sullyman I reverted the version of the docs framework back to 5.2.15 and reverted to the yarn.lock from prior to the bump. Seems to have fixed the problem but now we need to figure out how to update the @patternfly/documentation-framework dependency going forward.


draggable option

There is an option to disable dragging of elements in HTML5 (draggable="false") as well as in CSS (-webkit-user-drag: none;). It would be great if these two could be added.

1

+1

+1

+1

+1

+1

CSS 'user-drag' property

-webkit-user-drag
-khtml-user-drag (for older webkit browsers)

I don't have any info on hand as to which browsers or versions support those css properties. On caniuse, searching for the properties gives no results.
Permitted values:

auto (default) - default browser behaviour
element - entire element should be dragged, not just contents
none - dragging is not permitted for both element and contents

Draggable element property
Part of the drag and drop API, the modern approach is the draggable attribute on elements:

whole div will be dragged

you cannot drag this div or its text

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/draggable
Searching caniuse leads to a feature page: https://caniuse.com/#feat=dragndrop
It would be good if the component parts of the feature could get their own pages to promote collection of browser compatibility especially on mobile devices.

+1 to this as well.

Draggable attribute available at https://caniuse.com/#feat=mdn-html_global_attributes_draggable

-webkit-user-drag now available at https://caniuse.com/webkit-user-drag

Hey, I'm new to github (literally signed up to post this) so apologies if commenting here like this is incorrect etiquette...
I just thought you should be aware that I found the following info at stackoverflow, thought it might be of use:
-webkit-user-drag: none;
-khtml-user-drag: none;
-moz-user-drag: none;
-o-user-drag: none;
user-drag: none;
Original Post

@broseph-juce Thanks, I also ran into that in my research, however I couldn't find any evidence of browsers actually supporting the -moz-, -o- or the unprefixed version, so I think those were only ever included in the hopes that other browsers might adopt them (or just habit when writing prefixed properties). The -khtml- prefix is something of a legacy prefix that maps to -webkit-.


Additional client settings expand button can be easy to miss

EdgeDB version: 3.0-dev.7255+dc08771
The button to expand additional client settings is far away from the client settings button itself and can be easy for users to miss if they don't know to look for it:

Clicking on the "Client Settings" button triggers a nice animation that draws your eye to the bar, but it may still be easy to overlook the green expansion button on the far right, especially on the first click of "Client Settings" since it takes a bit for settings to load and the green button is not visible until some time after the animation fires.
Would it make sense to move the green button to the left-hand side of the bar, or maybe to place it next to the "Client Settings" button? Maybe @shougan could weigh in on this?

Let's move the expand button to the left side, and use up arrow instead of cross icon to close


FGA doesn't work properly

Preparation

[X] I read the Troubleshooting Guide
[X] My question isn't answered in any other issues (even the closed ones)

Your question
I updated my phone and it can't work. I read and found that my FGO screen is not fullscreen and FGA needs custom in Game Area Mode.

.
Device model
Oneplus Nord
Android version
OxygenOS 12.1 (Android12)
Screen size
1080 x 2400 pixels, 20:9 ratio
RAM
12GB

If the black bar is at the top, configure this to "Hide front camera" for both FGO and FGA.

[ ]

I changed to "Hide front camera" for both apps. However, the position skill is wrong (I use 3 skills of third servant but only 2.)

Is the thick black bar on the top or bottom of the phone?

Also, please provide a video recorded by FGA.

black bar is on the top
video recorded : https://youtu.be/1Ac6x22r9_Q

image for setting up skills

So hiding the camera doesn't seem to have any effect.
Your images are downscaled, so I can't tell you your Custom Game Area values for sure. Looks like left=123 and right=9.
By the way, I have a OnePlus 9 with Android 12 and FGO is displayed in full screen.

it is ok now, ty

So I tried the Custom Game Area values above, and FGA still doesn't work., probably because my game area isn't exactly the same, so how do I get the right values?

@Mostoneman Take a screenshot and measure the black pixels.

On my phone I was able to get rid of the black bars by switching navigation mode to 3 buttons.


Have an empty center for doom theme

Is your feature request related to a problem? Please describe.
I'd like to be able to have an empty center when theme = 'doom'.
Describe the solution you'd like
There should be an option such as empty = true, that will allow an empty center.
Describe alternatives you've considered
I had this in my config.
                  center = {
                      {
                          icon = ' ',
                      },
                  },

So, the bare minimum is that desc must be set. desc must be text.
Additional context
Image the screenshot, but at the words "EMPTY", it is actually just empty. I only want the header and footer only. No center.

I will fix it tomorrow

I will fix it tomorrow

Thank you. I'll try and see if I can come up with a PR, if I can then I'll submit a PR. Been having fun with contributing to plugins I use.

@glepnir I made a PR that solves the issue: https://github.com/glepnir/dashboard-nvim/pull/329


Inconsistent behaviour between miniz and zlib in inflate

If inflate returns Z_OK or Z_BUF_ERROR, and avail_out is not zero, then avail_in must be guaranteed to be zero. I have some data I compressed with deflate using miniz that, when trying to inflate it, does not follow this. This guarantee was confirmed by Mark Adler himself in this Stack Overflow post.
I have enabled the following preprocessor defines in miniz.h:

MINIZ_NO_STDIO
MINIZ_NO_TIME
MINIZ_NO_ARCHIVE_APIS
MINIZ_NO_ARCHIVE_WRITING_APIS

My inflate and deflate loop are copied directly from the zpipe.c example in zlib, with the only difference being that I use a 512KB input buffer for reading from disk, and a 2MB output buffer for inflated data to be written to disk. This includes using Z_NO_FLUSH. I've included my source for testing and the deflated data that I am trying to inflate. Note that zlib inflates this fine.
zlib-test.zip
It seems to me that in mz_inflate, if m_dict_avail on the stream is non-zero, then avail_in is not being properly updated, or avail_out is being incorrectly updated. This might be a naive picture though. It is strange though that avail_out is updated there, but avail_in is not. The result is that one of the calls to inflate near the stream end, avail_out is non-zero, and avail_in is also non-zero.
Changing the termination condition of the inner do-while loop from avail_out == 0 (the one recommended by zlib) to avail_out == 0 || avail_in > 0 successfully decompresses the stream. It appears that calling inflate again after the stream has gotten into such a state is safe, at least with my data stream.

I have encountered a related issue, miniz can enter a state where it keeps returning Z_OK while avail_out is zero, if a loop is set up to check for Z_OK before anything else it can cause an infinite loop: https://github.com/randy408/libspng/blob/9c35dc3ac180f0c486b1792c0f424718c3d07cd6/spng/spng.c#L787-L793
Although the official zlib documentation does say inflate() can set avail_out to zero while returning Z_OK, zlib will also return Z_BUF_ERROR if avail_out is not updated by the user, the latter is what miniz doesn't do.
This was worked around by checking for unknown returns values up front before checking the value of avail_out/avail_in, ingoring Z_BUF_ERROR: https://github.com/randy408/libspng/commit/c1f447eb5539322373a0ef10e1a61b8e7cd44586

Testing miniz with unshield I see some tests fail because of inconsistencies between miniz and zlib inflate
So it's not exactly a drop-in replacement ...

Guys you know what's going on and how to fix it, could you a produce a patch to fix this miniz bug?
It's not a zlib inflate drop-in replacement until that bug is fixed

I do not know how to fix this within miniz, only how to workaround it as a client of miniz (as described in my initial post).

Thanks @drglove for providing zlib-test.zip
I created an automated test procedure for linux (and unix) systems that includes miniz.c/h.
zlib-miniz__inflate-test-linux.zip
Just run ztest.sh.. binaries are compiled, logs are generated, make clean to remove generated files.
Challenge: fix inflate() in miniz.c without editing zlib-test.c
# ./ztest.sh
rm -f inflate.blob zlib miniz *.log *.diff
gcc -g -Wall -o zlib  zlib-test.c -DUSE_ZLIB -lz
gcc -g -Wall -o miniz zlib-test.c miniz.c

* zlib
inflate.blob: OK

* miniz
./ztest.sh: line 7: 14644 Aborted                 ./${i} 2> ${i}.log
inflate.blob: FAILED
sha256sum: WARNING: 1 of 1 computed checksums did NOT match

log files:

zlib.log
miniz.log
zzz_test.diff (red = zlib, green = miniz)

miniz: as we can see, at some point both avail_in and avail_out are non-zero
--- zlib.log	2021-05-14 12:06:28.000000000 +0800
+++ miniz.log	2021-05-14 12:06:29.000000000 +0800
@@ -44,17 +44,17 @@
 total_in: 4718592
 total_out: 15218849
 [10]
-avail_in: 10636
+avail_in: 5913
 avail_out: 0
-total_in: 5232244
+total_in: 5236967
 total_out: 17316001
 [11]
-avail_in: 0
-avail_out: 2053873
-total_in: 5242880
-total_out: 17359280
+avail_in: 5913
+avail_out: 2078881
+total_in: 5236967
+total_out: 17334272
 [12]
 avail_in: 0
-avail_out: 947632
-total_in: 5527204
-total_out: 18508800
+avail_out: 947639
+total_in: 5521291
+total_out: 18483785


handle() redirects should work with browser router

Describe the problem
Currently, if you set up a redirect using hooks.js handle() like so:
/** @type {import('@sveltejs/kit').Handle} */
export async function handle({ event, resolve }) {
  if (event.url.pathname === "/from") {
    return new Response(null, { status: 302, headers: { location: "/to" } });
  }

  const response = await resolve(event);
  return response;
}

and then navigate with a link Link you should expect it to redirect to /to when activated.
In reality Svelte Kit tries, and fails to navigate to the non-existent page /from. This is unintuitive.
Describe the proposed solution
Svelte Kit is smart and can pick up on 302 responses from the server.
Alternatives considered
The workaround is to handle this with JavaScript code, which means duplicating code across both server and client.
Importance
would make my life easier
Additional Information
No response

I don't know how this would work. We don't want to make a request to /from whenever the user clicks a link to /from because that would defeat a lot of the purpose of hydrating to a client-rendered app.

Does Svelte Kit not contact the server to request new pages? In this suggested implementation, the server would say "hey, this is a redirect!", and then deliver the page it's redirecting to. The router would update the url as well.
Did I overlook some part of this process?

It seems like hydrating this way fails to mimic "real" behavior where handle doesn't run redirects when changing links in a navbar or footer for example, so you have an inconsistent experience between typing the URL in browser initially and then clicking around the website. This example of course is only for people putting links they want to redirect inside their nav which is dumb, but it's just one of many cases when you'd want to mimic non hydrated behavior.

The browser SvelteKit code does routing on the client, loads the JS necessary to run the load() function for that page, and runs that (or, if appropriate, it first calls the corresponding shadow endpoint for that page). When navigating to /from via client-side navigation, /from is not one of the requests made by the browser.

So with the current setup it would be impossible, difficult, or unperformant?

Yes. If you want to have this sort of redirection happen during client-side rendering, it should happen in the response from a load() function. We don't want to make and wait for requests to /from for every navigation just in case there's a redirect happening in the handle function.

Point taken. Thanks for clarifying that.
This again makes me question if Svelte Kit should have some sort of built in redirect-from-a-list manifest. Putting a load on every page seems undesirable. This is more important with a large CMS compared to a small app, but I wonder what can be done for this use case beyond just "custom code". It's not exactly an uncommon use case.

Next has this built in.

Closing, as this feature isn't going to be implemented as described. If you have a proposal for configuring redirects that happen in both the server and on the client, you're free to open another issue for that. Or if doing this redirect check in a __layout works for you, great.

Using the proposed workaround using a layout.(server).ts file also won't work and will still result in the above mentioned error.
Even using sveltekit's redirect won't work.
    if (userOnPrivateRoute && !userAuthentication) {
            // redirect
            throw redirect(303, '/no-auth') // still HTML instead of JSON returned client-side
            // return Response.redirect('[...]/no-auth', 303)
    }

Sveltekit's redirect states:
/**
 * Creates a `Redirect` object. If thrown during request handling, SvelteKit will
 * return a redirect response.
 */
export function redirect(status: number, location: string): Redirect;

Maybe we could extend sveltekit's redirect to execute:

client-side:
window.location.replace('/${redirectionPath}')
serverside:
as it is now (returning a Response)

Would be really great to have an client/server idiomatic method for this. @Rich-Harris
Happy to give this a PR if you concur this'd be the way to go.


Building Mixtral engine with --load_by_shard option gives contradictory error

I am trying to following the example for Mixtral to build the engine but I am unable to use '--load_by_shard' as stated in the instructions, with the following error: AssertionError: MoE does not support sharded load. Which is contradictory to the docs in the example where it states: Note that when loading Mixtral weights you must use the --load_by_shard option.  The model does attempt to load without this flag but consumes over >128 GB of RAM, causing OOM on my system.  Is there anyway to build the engine for Mixtral without using so much RAM or getting --load_by_shard to work?
System spec:
Core i7 12700k
Nvidia A6000 48GB
128 GB RAM

Build command:
python build.py --model_dir /mixtral_model  \
               --use_inflight_batching \
                --enable_context_fmha \
                --use_gemm_plugin \
                --load_by_shard \
                --output_dir /models/mixtral-0.1-trtllm

Full traceback:
[01/08/2024-20:07:53] [TRT-LLM] [I] Using GPT attention plugin for inflight batching mode. Setting to default 'float16'
[01/08/2024-20:07:53] [TRT-LLM] [I] Using remove input padding for inflight batching mode.
[01/08/2024-20:07:53] [TRT-LLM] [I] Using paged KV cache for inflight batching mode.
You are using a model of type mixtral to instantiate a model of type llama. This is not supported for all configurations of models and can yield errors.
[01/08/2024-20:07:53] [TRT-LLM] [I] Serially build TensorRT engines.
[01/08/2024-20:07:53] [TRT] [I] [MemUsageChange] Init CUDA: CPU +14, GPU +0, now: CPU 123, GPU 10500 (MiB)
[01/08/2024-20:07:55] [TRT] [I] [MemUsageChange] Init builder kernel library: CPU +1798, GPU +312, now: CPU 2057, GPU 10812 (MiB)
[01/08/2024-20:07:55] [TRT-LLM] [W] Invalid timing cache, using freshly created one
[01/08/2024-20:07:55] [TRT-LLM] [I] [MemUsage] Rank 0 Engine build starts - Allocated Memory: Host 2.2726 (GiB) Device 10.5589 (GiB)
[01/08/2024-20:07:56] [TRT-LLM] [I] Loading HF LLaMA ... from /mixtral_model
[01/08/2024-20:07:56] [TRT-LLM] [I] Loading weights from HF LLaMA...
Traceback (most recent call last):
  File "/models/trtllm_examples/llama/build.py", line 934, in <module>
    build(0, args)
  File "/models/trtllm_examples/llama/build.py", line 878, in build
    engine = build_rank_engine(builder, builder_config, engine_name,
  File "/models/trtllm_examples/llama/build.py", line 721, in build_rank_engine
    load_from_hf_checkpoint(tensorrt_llm_llama,
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/models/llama/weight.py", line 540, in load_from_hf_checkpoint
    assert not tensorrt_llm_llama.moe_config.has_moe(
AssertionError: MoE does not support sharded load

The docs are mistaken, indeed. Thanks for the catch!
We'll work on making the model easier to build with less RAM. But Mixtral is a quite large model (~45B parameters) so you won't be able to fit it directly on a A6000 GPU. We're working on making that that possible through quantization in the following releases.

The docs are mistaken, indeed. Thanks for the catch!

So does the correct command to build the engine for Mixtral require '--load_by_shard' or not? Seems like Mixtral support is going to improve in the next release from this issue.


Make SpatialRule more flexible

After working with SpatialRules for some time I have seen a couple of issues with SpatialRules being not flexible enough.
For example SpatialRules have the method:
public double getMaxSpeed(String highwayTag, double _default)

There are cases where only the highwayTag is not enough to determine the maxSpeed of a country. One current example would be the new maxspeed rules in France, where the maxspeed depends on the number of lanes.
Therefore I propose to change the SpatialRule method signatures to:
public double getMaxSpeed(Readerway way, double _default)

This makes the handling a lot more flexible. The same applies to the method getAccessValue, which could include local differences. See for example #1408 for a good example.
So I would also like to change the method signature of getAccessValue to use the way instead of only the highway.
WDYT?

+1 from me.

This was fixed in #2353 or even before.


i didn't  find three js

Three.js is a Javascript library. It's not a web standard or something like that.

Ok, thank you for the clarification

Message ID: @.***>


[docs] change &signer to signer in script docs

Reflecting recent Move changes in the documentation.

/land


Fix/publishing permissions

What was the thinking behind removing versioned data objects? Just too buggy? 4.0's changeset feature would be worth having this (i.e bundling up a list of changes to blocks in 1 publish)

Sorry no, that was a mistake, let me pull some more together and push hit back.
Headline is we don't need versioned UI anywhere due to nested publish.

 Keen for comments @wilr @Leapfrognz

Looks good. Keen for this to be merged asap. @wilr

This will break any checks that use 'has_extension("VersionedDataObject")' as has_extension does not work properly with subclasses.
At least in 3.2 or lower.

@SilbinaryWolf We've created a pull request for that: https://github.com/silverstripe/silverstripe-cms/pull/1810

This has been integrated into the master branch / ss4 support and partially improved by changes in core for dealing with children.


ci: sync stage automation

Description
This job is used to merge main into stage whenever a deployment is made, ensuring that stage is synchronized with the latest version.

:tada: This PR is included in version 2.1.0-stage.1 :tada:
The release is available on:

npm package (@stage dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Connecting to Simulator

I am unable to connect to the simulator with companion. I am running 3.3.1. I have the IP set to <IP_ADDRESS>:3000.
But it never connects. I am sure this is a user error, but any guidance would be good. Thanks!

Sorry, I am just now realizing that Analog way completely changed the firmware to the 4.0. I understand the devs here are going need to do a lot to get it working with 4.0. Really appreciate all the hard work everyone puts into this.


Update snakeyaml to v1.18

Due to Fix #574, Update SnakeYAML v1.14 to v1.18
Note.
I also tested SnakeYAML version v1.17.
This version does not solve this issue.
From SnkeYAML Changelog.
https://bitbucket.org/asomov/snakeyaml/wiki/Changes
1.18 (2017-02-22)
Fix issue #323: Support "Miscellaneous Symbols and Pictographs"(thanks to Pawel Skierczynski [Atlassian]). This fix introduces minor backwards-incompatible changes - some of the methods have been renamed.This fixes also long standing issue with iOS emoji

test result
+---------+--------------+-------------------------+-------------------------+----------------------------+
| id:long | account:long |          time:timestamp |      purchase:timestamp |          🍣 emoji🍣:string |
+---------+--------------+-------------------------+-------------------------+----------------------------+
|       1 |       32,864 | 2015-01-27 19:23:49 UTC | 2015-01-27 00:00:00 UTC |                     embulk |
|       2 |       14,824 | 2015-01-27 19:01:23 UTC | 2015-01-27 00:00:00 UTC |               embulk jruby |
|       3 |       27,559 | 2015-01-28 02:20:02 UTC | 2015-01-28 00:00:00 UTC | Embulk "csv" parser plugin |
|       4 |       11,270 | 2015-01-29 11:54:36 UTC | 2015-01-29 00:00:00 UTC |                            |
+---------+--------------+-------------------------+-------------------------+----------------------------+

in:
  type: file
  path_prefix: /private/tmp/fuga/csv/sample_
  decoders:
  - {type: gzip}
  parser:
    charset: UTF-8
    newline: LF
    type: csv
    delimiter: ','
    quote: '"'
    escape: '"'
    null_string: 'NULL'
    trim_if_not_quoted: false
    skip_header_lines: 1
    allow_extra_columns: false
    allow_optional_columns: false
    columns:
    - {name: id, type: long}
    - {name: account, type: long}
    - {name: time, type: timestamp, format: '%Y-%m-%d %H:%M:%S'}
    - {name: purchase, type: timestamp, format: '%Y%m%d'}
#    - {name: comment, type: string}
    - {name: "🍣 emoji🍣", type: string}
out: {type: stdout}

Merged. Thank you.

Thanks!.


Add ntp and chrony test case.

In some old kernel, we will encounter below issue, since the kernel doesn't contain the new code which support these parameters of ethtool, we may need skip these images.
ethtool -G eth0 rx 4078 tx 4078
Cannot set device ring parameters: Operation not supported


Generic type constraint new() should offer customization

I think it would make lots of sense if C# would allow new() type constraints customization. It would not only allow developers to create instances of a class without specifying a provider function, it would also allow them to ensure a generic type is non-abstract, without having to provide default constructor.
By customization, I mean something such as new(int, int), new(CustomType, bool), ect.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 68c4db08-089a-4022-f672-7951590e075d
Version Independent ID: 197f1799-2fc6-6f82-ada7-eb3abdc2da50
Content: new constraint - C# Reference
Content Source: docs/csharp/language-reference/keywords/new-constraint.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

@seblaf1 This is a request for a new feature in the language. It should be added in dotnet/csharplang
I'll close this, because the docs accurately reflect the current product.


Remove all cookies with XWalkCookieManager

Unfortunately window.cookies.clear() will crash the cordova application after test, using the Crosswalk webview plugin.

Could you please share your sample to me?

PTAL.

I could not get the cookies cleared with the committed Cookies.java on Android 4.4.4. Nothing happens.

Could you please share your sample to me?


Add Semigroup intances for CritBit and Set

Currently, critbit fails to build on GHC 8.4 since Semigroup has become a superclass of Monoid, and the CritBit and Set data types lack Semigroup instances.
I opted to use CPP to define a Semigroup instance on base-4.9 or later only. If you'd like, I could alternatively incur a semigroups dependency to remove this bit of CPP.

@RyanGlScott I'd be in favour of having (conditional) semgroups dependency and uniform public API (i.e. Semigroup instance for all).

Either option is fine with me. But I'd like to hear what @bos thinks before proceeding!

I made base < 4.11 revisions for <IP_ADDRESS> and <IP_ADDRESS>.
<IP_ADDRESS> doesn't have Monoid instance, so it's fine.

Thanks, @phadej!

This package appears to be unmaintained, so closing.


Thread-per-pod model in Kubelet (second try)

Change Kubelet so that each pod is being synced in a separate goroutine.
This is the second try to change it - the first one was #4804 but was reverted. This time the issue should be fixed - all e2e tests are passing:
Ran 27 of 27 Specs in 1477.220 seconds
SUCCESS! -- 27 Passed | 0 Failed | 0 Pending | 0 Skipped I0227 13:24:26.314146   26913 driver.go:89] All tests pass
This change is a prerequisite for optimizations of this path, e.g. if the specification for a Pod didn't change since the last update, resyncing of pod should be done only if the probing don't succeed. I'm going to implement those changes in subsequent PR.
Those changes were discussed in #4119
cc @vmarmol @dchen1107

Thanks for the fix @wojtek-t! LGTM and merging.

Thanks for the fix.


Update to released tooling

Hi @galvesribeiro, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;


fixed the error in oracle.sol #28

As this repo is not in active development any more and I can't vouch for your changes, I am currently not updating sample contracts. Thanks a lot for your effort though and feel free to fork this :)


[gui error report] Error: Initializing daemon...

just download the lastest version, but can not open ipfs desktop, always downloading...

Specifications

OS: darwin
IPFS Desktop Version: 0.20.3
Electron Version: 17.1.0
Chrome Version: 98.0.4758.102

Error
Error: Initializing daemon...
go-ipfs version: 0.12.0
Repo version: 12
System version: amd64/darwin
Golang version: go1.16.12
Found outdated fs-repo, migrations need to be run.
Looking for suitable migration binaries.
Need 2 migrations, downloading.
Downloading migration: fs-repo-10-to-11...
Downloading migration: fs-repo-11-to-12...
Fetching with HTTP: "https://ipfs.io/ipfs/QmdaCHYBDHEhXCMoynH5UcohEay6m1XayZCcxWZzKAHNVN/fs-repo-11-to-12/versions"
Fetching with HTTP: "https://ipfs.io/ipfs/QmdaCHYBDHEhXCMoynH5UcohEay6m1XayZCcxWZzKAHNVN/fs-repo-10-to-11/versions"
Fetching with HTTP: "https://ipfs.io/ipfs/QmdaCHYBDHEhXCMoynH5UcohEay6m1XayZCcxWZzKAHNVN/fs-repo-10-to-11/versions"
Fetching with HTTP: "https://ipfs.io/ipfs/QmdaCHYBDHEhXCMoynH5UcohEay6m1XayZCcxWZzKAHNVN/fs-repo-11-to-12/versions"
Fetching with HTTP: "https://ipfs.io/ipfs/QmdaCHYBDHEhXCMoynH5UcohEay6m1XayZCcxWZzKAHNVN/fs-repo-11-to-12/versions"
Fetching with HTTP: "https://ipfs.io/ipfs/QmdaCHYBDHEhXCMoynH5UcohEay6m1XayZCcxWZzKAHNVN/fs-repo-10-to-11/versions"
Error fetching: exceeded number of retries. last error was http.DefaultClient.Do error: Get "https://ipfs.io/ipfs/QmdaCHYBDHEhXCMoynH5UcohEay6m1XayZCcxWZzKAHNVN/fs-repo-10-to-11/versions": dial tcp <IP_ADDRESS>:443: i/o timeout
Error fetching: exceeded number of re

help

用清理工具彻底删除IPFS APP, 再重装,解决了
solved, delete the app  by clean tool, reinstall

@kidcdf we would like to understand what was the underlying problem (sadly the relevant log got  cut-off)
Are you able to send  combined.log and error.log  from the logs directory? :pray:
You can open the directory from the tray menu:

Thanks!

Duplicate of #2023


fix(sitemap): rm trailing slash

Fixes #354.

Description

Changes/Tasks

[x] Changed code

Motivation and Context

Screenshots (if appropriate):

Types of changes

[ ] Refactoring/add tests (refactoring or adding test which isn't a fix or add a feature)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My change requires a change to the documentation.

[ ] I have updated the documentation accordingly.

[ ] My changes have tests around them

@lottamus Thanks. Let me know if this is better

Closing as this seems to be fixed in https://github.com/nozzle/react-static/commit/597f18f46a0d20d6663bc782b97f4641be7a35ed


Jinja - support rejectattr

I've added support for rejectattr in Jinja since I encountered some GGUF models that include a chat template that uses it, like this one for example.

I've made the changes, and the tests seem to pass

thanks for the contrib, @giladgd!


unable to install with rpm

Hi I'm trying to install this package with npm several times but every time it stuck on initial installation ...
I also tried different packages and they are installing fine
please check this ASAP I need it badly

Did you try to install using NPM or Yarn ?

you could try the below command since the npm command isn't working for you.
yarn add react-native-documentscanner-android
This should work :D


Note for Readme.md

To enable the file stuff, following functions must be called:

lv_fs_drv_init
-lv_fs_drv_register

But the most important point is, that before calling lv_fs_drv_register the function lv_init must be called. Otherwise its not possible to register the file functions.
Please add a notice about this in the Readme.md.

Thanks, done here: https://github.com/lvgl/lv_fs_if/commit/fdbc24ef429f892616395fee24447342b3acfd32


reduce the size of the NPM Package by splitting examples into separate repository

To reduce the download cost to a developer using our Token-Negotiator package, we should migrate the examples into their own repository. Then add links to and from examples to this repository.

Change to solution. Instead, examples are still found within this package, but ignored by NPM using .npmignore
Savings from this change shown below:
before:
npm notice package size:  11.2 MB
npm notice unpacked size: 11.3 MB
after:
npm notice package size:  21.7 kB
npm notice unpacked size: 55.7 kB


Join Likes with Tv shows Data with more efficient way.

I joined Tv shows Data and Likes data in a more efficient way.

I fix the linter errors from this project.

Hi @Salwa99  👋  Thanks a lot for reviewing this PR 👍


Add temp file method

Fixes https://github.com/AtomLinter/atom-linter/issues/30

Travis is green, everything is awesome


use sourceRect here?

I thought that's what it was but maybe I didn't actually save... Sprites are saving as the whole Sprite sheet, or as a tiny sprite with the rest of the image blank.
Need to figure out how to correctly send cords to ise
https://github.com/jessinthecloud/ValheimJsonExporter/blob/777f74144e5535a0edd05c4cf41d133d9e4e9ec2/ValheimJsonExporter/Docs/SpriteDoc.cs#L81

Related to #14


fix: avoid throwing errors if container is no longer in page

We have identified a few errors that zoid throws that cannot be caught by the implementation code (render.catch() and close.catch()) during asynchronous dismounts. Although this can occur in every webpage, it's primarily an issue when using React as seen here: Issue #334
With this change, we first check if the container element has been removed from the DOM or the user has navigated away from the page mid-render. In these scenarios we should avoid throwing errors.
Here are 3 examples:
https://github.com/krakenjs/zoid/blob/main/src/parent/parent.js#L857
https://github.com/krakenjs/zoid/blob/main/src/parent/parent.js#L826
https://github.com/krakenjs/zoid/blob/main/src/parent/parent.js#L1172
These 3 error flows eventually cause the promise to be rejected since the render was never completed, and an error to be displayed on the console: https://github.com/krakenjs/zoid/blob/main/src/parent/parent.js#L732

I haven't looked into testing in Zoid so I don't know how reasonable this ask is: can we write a test for this?

I agree that it would be awesome to add a couple tests to cover this new logic. I'm really excited about this improvement. Great work so far @oscarleonnogales!

This is great, thanks everyone!

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.01 :tada:

Comparison is base (31d59fb) 95.63% compared to head (a632f03) 95.64%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
+ Coverage   95.63%   95.64%   +0.01%
==========================================
  Files          18       18
  Lines        1213     1217       +4
==========================================
+ Hits         1160     1164       +4
  Misses         53       53

Impacted Files
Coverage Δ

src/constants.js
100.00% <100.00%> (ø)

src/parent/parent.js
95.62% <100.00%> (+0.02%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Looks great man 🔥  Love that you moved the error messages into a const ⚡


FIle organizer script

Pull Request
Title
FIle organizer script for basic organizing on a directory
Checklist

[x] My code adheres to the coding and style guidelines of the project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no errors/warnings/merge conflicts.

A bit too obscure and there are better GUI tools for this.


Update flutter_tizen_engine_unittest

This PR include following things:

Separate headed & headless versions
Fix inactive TC

All contents are included in https://github.com/flutter-tizen/engine/pull/133, so I will close it.


Add DNWebSocket library

Project URL
https://github.com/GlebRadchenko/DNWebSocket
Category
WebSocket
Description
DNWebSocket - Object-Oriented, Swift-style WebSocket Library (RFC 6455) for Swift-compatible Platforms. Its fully tested and faster than other web socket libraries (proved with test results).
Why it should be included to awesome-ios (optional)
As I mentioned above, it's Swift-style library. It's easy to read and understand. All Autobahn tests are passed.
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 4 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Warning

:warning:
Found 6 link issues, a project collaborator will take care of these, thanks :)

Link issues by awesome_bot

Line
Status
Link

25
302
https://twitter.com/awesome_ios redirects tohttps://mobile.twitter.com/awesome_ios

3061
302
https://twitter.com/maxdesiatov redirects tohttps://mobile.twitter.com/maxdesiatov

3074
302
https://twitter.com/objcio redirects tohttps://mobile.twitter.com/objcio

3075
302
https://twitter.com/CocoaPods redirects tohttps://mobile.twitter.com/CocoaPods

3076
302
https://twitter.com/CocoaPodsFeed redirects tohttps://mobile.twitter.com/CocoaPodsFeed

3077
302
https://twitter.com/RubyMotion redirects tohttps://mobile.twitter.com/RubyMotion

  Generated by :no_entry_sign: Danger


I'm getting a "Failed to connect to api.github.com" Error after integration starts

Hi, I'm getting this error after trying to initiate integration on a newly created bot:
Bot Issue: error. Build Service Error.
Issue: Failed to connect to api.github.com: Connection refused (-1).
Integration Number: 1.
Integration URL: https://REDACTED/xcode/bots/C373308/integrations
Description: Failed to connect to api.github.com: Connection refused (-1).

Tracing the code in Xcode, the problem is that the xbot returned is nil and the error status is "checkout-error" (printed here)
Not sure why there's a checkout error or what's the flow, I can manually checkout the code on my computer and I can manually create a bot for this project, it's just not working with XBotBuilder...

Have you found any solution? I'm stuck at the same place. The result of every integration is connection refused.

yes, it was a bug in the app: it was trying to clone from<EMAIL_ADDRESS>I had to manually change the code in GitHubXBotSync.swift:191, to something like this:
                gitUrl:"git@github.com:\(gitHubRepo.repoName).git",

btw, this seems to be fixed by PR #13

Awesome, Thanks! I was looking  at the network traffic with a proxy but I must've missed that. Hopefully this gets pulled into master soon.


Invalid Shipyard File Breaks Bridge

Environment

Client OS (e.g., Linux, macOS, Windows): macOS
Keptn Version (keptn version): 0.9.2
Kubernetes Cloud Provider (e.g., GKE, AKS): k3d
Kubernetes version (kubectl version):

Affected Component

[ ] Docs
[ ] CLI
[ ] Kubernetes Integration
[ ] Openshift Integration
[ ] Helm
[ ] Istio
[x] Bridge
[ ] Approval
[ ] Datastore
[ ] REST API
[ ] eventbroker / distributor
[ ] jmeter

Describe the bug
Uploading an invalid shipyard file causes "No projects available" to be shown in the bridge. Effectively breaking the bridge.
To Reproduce
Conduct this via the UI:

Create a new project using a valid shipyard.yaml file. Call it test1. Everything works as expected
Create a second project using an invalid shipyard file (see example below)
The bridge shows an error explaining that the project could not be created
keptn get projects shows the project has been created
Go to the bridge homepage and you'll  see that no projects are available
keptn delete project test2 and the bridge will start working again

Expected behavior
A shipyard file is validated and unless it's entirely valid, the project is never created.
Additional context
keptn get projects
NAME		CREATION DATE			SHIPYARD VERSION
test1		2021-10-15T08:13:37+10:00	spec.keptn.sh/0.2.2

keptn get projects
NAME		CREATION DATE			SHIPYARD VERSION
test1		2021-10-15T08:13:37+10:00	spec.keptn.sh/0.2.2
test2		2021-10-15T08:15:32+10:00	spec.keptn.sh/0.2.2

keptn delete project test2
Starting to delete project
Project deleted successfully
Shipyard of project test2 cannot be retrieved anymore. After deleting the project, the namespaces containing the services are still available. This may cause problems if a project with the same name is created later.

Valid Shipyard
---
apiVersion: "spec.keptn.sh/0.2.2"
kind: "Shipyard"
metadata:
  name: "shipyard-sockshop"
spec:
  stages:
    - name: "dev"
      sequences:
        - name: "dosomething"
          tasks:
            - name: "printtoconsole"

Invalid Shipyard
---
apiVersion: "spec.keptn.sh/0.2.2"
kind: "Shipyard"
metadata:
  name: "shipyard-sockshop"
spec:
stages:
    - name: "dev"
      sequences:
        - name: "dosomething"

A bit of investigation here shows that the bridge visually breaks due to the call to /api/controlPlane/v1/project?disableUpstreamSync=true&pageSize=50 which returns the full JSON shipyards for each project. If one of those is broken, no projects are shown.
Broken JSON payload example (note null value for stages):
{
    "nextPageKey": "0",
    "projects": [{
            "creationDate": "1634341258081202200",
            "projectName": "p10",
            "shipyard": "---\r\napiVersion: \"spec.keptn.sh/0.2.2\"\r\nkind: \"Shipyard\"\r\nmetadata:\r\n  name: \"shipyard-sockshop\"\r\nspec:\r\nstages:\r\n    - name: \"dev\"\r\n      sequences:\r\n        - name: \"dosomething\"",
            "shipyardVersion": "spec.keptn.sh/0.2.2",
            "stages": null
        },
		...
    ],
    "totalCount": 11
}

So there are a couple of improvements / possibilities here:

Improve shipyard file validation on input to prevent the error proactively
The API validates shipyard files as it's generating the JSON response and ignores invalid projects so it never gets sent. Therefore the bridge never breaks.

@laneli I'm brand new to TypeScript so bear with me!
I've found the spot that I think needs extra error checking. Line 117 of /bridge/client/app/_services/api.service.ts.
I propose that we do some rudimentary error checking and don't even create the project if it doesn't satisfy certain conditions:

Project must have at least one stage
Each stage must have at least one sequence
Each sequence must have at least one task (if it doesn't perhaps we can proactively add a task with the same name as the sequence)

As a trial, I decided to blacklist any project including the letter i. This sort of works in that it never creates the project and so the bridge isn't broken. But I'm wondering how I do this properly to actually get the nice toast error and invoke the notification from line 207 of ktb-project-settings.component.ts:
  public createProject(
    projectName: string,
    shipyard: string,
    gitRemoteUrl?: string,
    gitToken?: string,
    gitUser?: string
  ): Observable<unknown> {

    console.log('createProject called in api.service.ts for: ' + projectName);
    if (projectName.includes('i')) {
      console.log('got an illegal project name as it contains i. Erroring');
      let obs = throwError("Error From ThrowError observable");
      return obs
    }
    const url = `${this._baseUrl}/controlPlane/v1/project`;
    return this.http.post<unknown>(url, {
      gitRemoteUrl,
      gitToken,
      gitUser,
      name: projectName,
      shipyard,
    });
  }

I've changed my mind. This logic fits better into the ValidateShipyardStages function of the keptn_helpers.go in the shipyard-controller. There, it solves this issue for projects created via CLI and the UI.
keptn create project p11 -s invalid.shipyard.yaml
WARNING: Creating a project without Git upstream repository is not recommended.
You can configure a Git upstream repository using:

keptn update project PROJECTNAME --git-user=GIT_USER --git-token=GIT_TOKEN --git-remote-url=GIT_REMOTE_URL

Starting to create project
Error: Create project was unsuccessful.
Could not validate payload: provided shipyard file is not valid: Shipyard must contain stages.
Please update shipyard file with stages and try again.

and
// ValidateShipyardStages godoc
func ValidateShipyardStages(shipyard *keptnv2.Shipyard) error {

	number_of_stages := len(shipyard.Spec.Stages)

	if number_of_stages == 0 {
		errorMsg := "Shipyard must contain stages.\n"
		errorMsg += "Please update shipyard file with stages and try again."
		return errors.New(errorMsg)
	} else {
		fmt.Println(fmt.Sprint("This shipyard looks to have enough stages. It has: ", number_of_stages, " stages"))
	}

	for _, stage := range shipyard.Spec.Stages {
		if stage.Name == "" {
			return errors.New("all stages within the shipyard must have a name")
		}
		if !keptncommon.ValidateKeptnEntityName(stage.Name) {
			errorMsg := "Stage " + stage.Name + " contains upper case letter(s) or special character(s).\n"
			errorMsg += "Keptn relies on the following conventions: "
			errorMsg += "start with a lower case letter, then lower case letters, numbers, and hyphens are allowed.\n"
			errorMsg += "Please update stage name in your shipyard and try again."
			return errors.New(errorMsg)
		}
	}
	return nil
}


Cross check pattern code with previous version from master

From same inputs make sure both version give the same outputs.
Add tests to the simulation output

Found a bug in master (fix in #49), and a bug in develop (fix in #50). Master and develop should now agree. Added a test in develop to check pattern generation code against a known output.


Please change solid-js version in peerDependencies

I got an error when I was installing the package:

npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/solid-js
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>
Here it is:
  "peerDependencies": {     "solid-js": "1.7"   },

done in 0.5.4


listtransactions is convoluted

We are trying to do too many things with  listtransactions. We need to split it into different purposes.
@edouardparis what do you need from the other side of the UDS ? :)

I agree that listransactions has too much things.
All the presigned transactions psbts are also in getrevocationtxs, this is quite a duplicate.
The revault-gui need to have a way to retrieve all broadcasted transactions of a vault.
That way when a stakeholder click on a unvaulting vault he can see

the deposit transaction
the unvaulting transaction
the spend tx ?

So we are closer from a listonchaintransactions then ? Would something like:
{
    "deposit": "hex", // Must be here if a vault exists in the first place
    "unvault": "hex", // Can be `null` !
    "cancel": "hex", // Can be `null` !
    "emergency": "hex", // Can be `null` !
    "unvault_emergency": "hex" // Can be `null`
}

Work for you ? Don't you have any other requirement than the optional onchain transactions ?

It works for me.
For the history panel, GUI needs a list of the deposit transactions and the spend transactions not filtered by vault_id

Ok, this can be done in a separate call to avoid the burden of querying the unvault, cancel, emergency and un_emergency for each vault.
What do you think of spentvaults:
{
    {
         "deposit": "hex",
         "spend": "hex",
     },
     {
         "deposit": "hex",
         "spend": "hex",
     }
 }

However i wonder why you don't ned eg the cancel for the history ?

Yes the cancel is equivalent of the spend.

the deposit transactions and the spend transactions not filtered by vault_id

I need more something like this:
[
      {
          hex: ...
          kind: deposit
       },
       {
          hex: ... // transaction who spend vault A
          kind: spend
       },
       {
          hex: ... // transaction who create vault A
          kind: deposit
       }
]

For the history panel, GUI needs a list of the deposit transactions and the spend transactions not filtered by vault_id

Ok, so that's a different call. Can you create another issue for discussing this one ?
Also, i'm not sure to grasp completely your example. How would you know for which vault is each of the transaction entry? Probably even better if you PR a doc draft so we can be more specific.


[FEATURE]: Drizzle D1 Local Utils

Feature hasn't been suggested before.

[X] I have verified this feature I'm about to request hasn't been suggested before.

Describe the enhancement you want to request
Dev Migrations
Currently migrating the dev DB with wranglers works like this:
wrangler d1 migrations apply
A better way would be to
a: run wrangler to execute the drizzle migration
or
b: directly modify the local sqlite file
The command could be:
drizzle-kit migrate --local
Dev Studio
Also a dev studio would be nice studio operating on dev DB (again with wrangler or sqlite file) e.g.:
drizzle-kit studio --local
Test Migrations
Also currently test env migrations are a mess:
// @ts-ignore
import { D1Migration, defineWorkersConfig, readD1Migrations } from '@cloudflare/vitest-pool-workers/config';
import * as path from 'node:path';

export default defineWorkersConfig(async () => {
	// Read all migrations in the `migrations` directory
	console.log(__dirname);
	const migrationsPath = path.join(__dirname, 'drizzle');
	const migrations: D1Migration[] = await readD1Migrations(migrationsPath);

	return {
		test: {
			setupFiles: ['./test/setup.ts'],
			poolOptions: {
				workers: {
					wrangler: {
						configPath: './wrangler.toml'
					},
					miniflare: {
						// Add a test-only binding for migrations, so we can apply them in a setup file
						bindings: { TEST_MIGRATIONS: migrations }
					}
				}
			}
		}
	};
});

import { applyD1Migrations, env } from 'cloudflare:test';

// Setup files run outside isolated storage, and may be run multiple times.
// `applyD1Migrations()` only applies migrations that haven't already been
// applied, therefore it is safe to call this function here.
await applyD1Migrations(env.DB, env.TEST_MIGRATIONS);

I don't have a good idea for this but currently it feels like a hack.
Maybe adding this as an easy wrapper for the @cloudflare/vitest-pool-workers/config defineWorkersConfig with options to override it for more sophisticated db tests?

I been testing cloudflare d1 with drizzle recently what's the issue you facing with wrangler d1 migrations apply I'm running drizzle migrations with it without issues.

No it's not an issue in general. I have a working setup, it would merely be an API improvement. Especially the mentioned testing bit.