Add different categories/classes/styles to active days

Adds the possibility to add a classname to an active day. This will enable adding different styles to each active days. Still needs better testing and a code review.

This PR had conflicts which were resolved here on Github. A code review is necessary.

Great feature! The original idea about this feature is that provide a :type prop to change .day  element's color & icon.
But I think your idea is better. Use :dafaultClassName to  receive  String or Object is more flexible.
BTW, maybe we can add another prop to control the active day's icon, even control its visible or not.

BTW, maybe we can add another prop to control the active day's icon, even control its visible or not.

Good idea! That way we can hide the SVG icon, if it is not required.
Maybe it could be something like :activeDayIcon=" | true | false", where:

url is the full url to an SVG or image
true uses the default SVG icon, like it is now
false hides the icon

I add two props for YearCalendar component.
colorful (For YearCalendar)
Boolean
default false
When colorful=true activeDates will sync by array with Object. [{ date: '2019-03-13', className: 'red' }, { date: '2019-03-14', className: 'blue' }]
colorful=true with String. ['2019-01-01', '2019-02-01']
dayActiveClass (send to MonthCalendar)
String
default 'calendar--active'
Use on
<year-calendar
v-model="year"
:activeDates.sync="activeDates"
...
dayActiveClass ="custom-day-active-class"
>
Then user can use there custom classList.

You can pull and check it.
Do you have any other ideas?

Hi Nono. So the colorful prop will be the boolean to set how the array should be filled, right?
If true, then it should expect an array of objects [{ date: '2019-03-13', className: 'red' }, { date: '2019-03-14', className: 'blue' }].
If false, it expects an array os Strings ['2019-01-01', '2019-02-01'].
But if the user mixes values, like colorful='true' with an array of strings, it will be invalid. Some checks should be in place.
Other solution, would be to just look inside the array and see if an Object or String was passed and then define a control variable ourselves (just a boolean, like colorful).
That way the user doesn't need to send another prop, and we keep it working properly when the array gets empty.
What do you think?

Hi Nono. So the colorful prop will be the boolean to set how the array should be filled, right?
If true, then it should expect an array of objects [{ date: '2019-03-13', className: 'red' }, { date: '2019-03-14', className: 'blue' }].
If false, it expects an array of Strings ['2019-01-01', '2019-02-01'].

Yes, but I think that is not a good solution. Maybe colorful prop will cause confusion for users.

The only issue I foresee, is if the user mixes values, like colorful='true' with an array of strings. That will be invalid. Either we halt the processing with an error, or we assume a default value. Either way, additional checks need to be made.
Other solution, would be to just look inside the array and see if an Object or String was passed and then define a control variable ourselves (just a boolean, like colorful).
That way the user doesn't need to send another prop, and we keep it working properly when the array gets empty.
What do you think?

Hi, fabioduque. Your solution sounds great! We can measure activeDates prop's of type was Object or String. Then save the boolean variable in calendar component.
In initialing case when array was empty. We pushed  array of objects for the activeDates.Because  array of objects has move information!
Use array of objects can store more state. Maybe we don't need array of strings for activeDates. What do you think ?

Hi Nono. So the colorful prop will be the boolean to set how the array should be filled, right?
If true, then it should expect an array of objects [{ date: '2019-03-13', className: 'red' }, { date: '2019-03-14', className: 'blue' }].
If false, it expects an array of Strings ['2019-01-01', '2019-02-01'].

Yes, but I think that is not a good solution. Maybe colorful prop will cause confusion for users.

Yes, I agree.

The only issue I foresee, is if the user mixes values, like colorful='true' with an array of strings. That will be invalid. Either we halt the processing with an error, or we assume a default value. Either way, additional checks need to be made.
Other solution, would be to just look inside the array and see if an Object or String was passed and then define a control variable ourselves (just a boolean, like colorful).
That way the user doesn't need to send another prop, and we keep it working properly when the array gets empty.
What do you think?

Hi, fabioduque. Your solution sounds great! We can measure activeDates prop's of type was Object or String. Then save the boolean variable in calendar component.
In initialing case when array was empty. We pushed array of objects for the activeDates.Because array of objects has move information!
Use array of objects can store more state. Maybe we don't need array of strings for activeDates. What do you think ?

I think the best solution is to have the array of Objects, because, like you say, it holds more information.
Nevertheless, I think you can support an array of Strings, for when the user does not need anything else than the dates active.
Maybe that way, we don' even need to change the code.
The user starts with an array of strings, which is a kind of a "bonus". Then, when the array becomes empty, the array returns to its default, which is an array of Objects.
What do you think?

Hi, Fabioduque. I agree your thinking. I will merge the PR and push new version.
I appreciate your kind assistance!


No sound output (v1.3.0, Big Sur, Macbook Pro 16-inch, 2019)

Things I have tried:

Open GarageBand and set input to eqMac (Scarlett 2i2)
Open Zoom and go to test audio settings
Set eqMac output to other devices (MacBook Pro Speakers)
Go into MIDI settings and set all devices to 44100 Hz
Tried putting eqMac into bypass mode
Press "reset playback" button in eqMac
Restart eqMac
Restart MacOS

Hi, I am closing this bug just based on the age of this issue, if this issue persists for you, please reopen this issue and I would be glad to help you out.

I don't use eqMac anymore so no idea if this was ever fixed


✅ CI: Fix ci and use new crate for check-contract step

📝 Description

Use latest rust version
Use the new cw-check-contract crate for checking smart contract
Fix ci issue on test and lint
Update some dependencies version

🔗 Link
https://github.com/CosmWasm/cw-tools
https://github.com/CosmWasm/cosmwasm/issues/1371

I highly recommend using cosmwasm-check instead of cw-check-contract. The later is an experiment and should never have been published. It's unmaintained.
See

https://crates.io/crates/cosmwasm-check
https://github.com/CosmWasm/cosmwasm/issues/1371
https://github.com/CosmWasm/cosmwasm/blob/main/CHANGELOG.md#110---2022-09-05

@webmaster128 Hey! Thanks Simon for the tip. 👍 We'll do that, but if you feel like it, you can also propose a PR, that would be great! 😁

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Sparse csr matrix returns nan on 0.0/1.0

I spotted an unexpected behavior in scipy.sparse.csr_matrix, which seems a bug to me. Can anyone confirm that this is not normal? I am not an expert in sparse structures so I may be misunderstanding proper usage.
>>> import scipy.sparse
>>> a=scipy.sparse.csr_matrix((1,1))
>>> b=scipy.sparse.csr_matrix((1,1))
>>> b[0,0]=1
/home/marco/anaconda3/envs/py35/lib/python3.5/site-packages/scipy/sparse/compressed.py:730: SparseEfficiencyWarning: Changing the sparsity structure of a csr_matrix is expensive. lil_matrix is more efficient.
  SparseEfficiencyWarning)
>>> a/b
matrix([[ nan]])

On the other hand, numpy properly handles this:
>>> import numpy as np
>>> a=np.zeros((1,1))
>>> b=np.ones((1,1))
>>> a/b
array([[ 0.]])

Context:
Python 3.5.1 |Continuum Analytics, Inc.| (default, Dec  7 2015, 11:16:01)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-1)] on linux
>>> scipy.__version__
'0.17.1'
>>> scipy.__numpy_version__
'1.11.1'
>>> np.__version__
'1.11.1'

For reference, I posted a question on StackOverflow (before posting here) at: http://stackoverflow.com/questions/38516694/scipy-sparse-csr-matrix-returns-nan-on-0-0-1-0

Confirming that this is a bug. It's located in the _divide_sparse method in scipy/sparse/compressed.py, but I haven't looked into the exact cause at this time.

Looks like the statement in the comment isn't quite correct: values outside self's sparsity pattern should always be NaN, but r's sparsity pattern isn't necessarily a superset of self's because _binopt trims away extra zeros.


There has been an unexpected error while calling npm-groovy-lint

There has been an unexpected error while calling npm-groovy-lint

Please can you provide the log in output/GroovyLint ? :)

Thanks. It worked after I downgraded my java version to 11 from 14.

Thanks for the tip !
I didn't test on java 14 (CI tests are done with java 8 & 11), maybe the embedded Groovy 3.0.3 is not compliant with Java 14, i'll have a look


Implement fixes/changes 23/02/17

[ ] Prevent extra line breaks from being added.
[x] Fix issue with test emails: sending a test email results in an err (400 response) and breaks campaign sending (requiring a page refresh before a campaign can be sent).
[ ] Notification updates are no longer received after the page is refreshed. For example, after uploading a csv and the page is refreshed there will be no progress update notification (e.g. x rows processed) and no import success notification (even though everything is fine server-side).
[ ] Keep frontend responsive during csv imports. At the moment it is difficult to create a template while importing a csv because it takes so long to load the templates page.

Linebreak issue ref https://github.com/quilljs/quill/issues/1341


Builds using esModules/Support Tree Shaking

(This issue tracker is only for bug reports or feature requests, if this is neither, please choose appropriate channel from http://bluebirdjs.com/docs/support.html)
Please answer the questions the best you can:
1) What version of bluebird is the issue happening on?
All of them.
2) What platform and version? (For example Node.js 0.12 or Google Chrome 32)
Every Platform/Every Version
3) Did this issue happen with earlier version of bluebird?
Yes
(Write description of your issue here, stack traces from errors and code that reproduces the issue are helpful)
I'm not sure if this is already represented in the Bluebird pipeline, or I've missed another issue that captures this (I just searched for "tree-shaking", entirely possible). If so, this can be closed.
It would be nice if Bluebird were bundled using a well-known module bundler, or could in some way capitalize on the tree-shaking functionality that many well-known module bundlers provide.
I am requiring Bluebird into a project of mine. It is quite large, but I am willing to include it because of the considerable speed advantages I get out of using it (seriously, awesome work). I am then using Webpack 2<EMAIL_ADDRESS>to bundle my project.
This project does not use any of the ancillary methods bluebird provides (map, filter, each, etc), but because the module is pre-bundled (using "fs"), I cannot shake any of the modules that are in the bluebird.js main.
In addition, I have tried explicitly including Bluebird in my build and referencing bluebird only from 'bluebird/js/release/bluebird':
loaders: [
    {
         test: /\.js$/,
         loader: 'babel-loader',
         exclude: /node_modules\/(?!bluebird)/
    }
]

import bluebird from 'bluebird/js/release/bluebird';

but this results in a build of exactly the same size. It appears as though a bluebird.core.js module is distributed as well, which is slightly smaller, but it also appears to not be as performant as the main module.
In addition, if there are any workarounds, I would love to try them out.

Seems like the v3 documentation is missing this:
https://github.com/caitp/node-bluebird#custom-builds
But it should still work. For an up to date list, see https://github.com/petkaantonov/bluebird/blob/master/tools/build.js#L26

@spion I didn't know that was a possibility, thank you for passing along these links.
Nevertheless, I would classify this under the "workarounds" I mentioned in my issue. It is nice to be able to conditionalize the optional modules based on a build, but it seems like a lot of work for a dependency within any project's build lifecycle.
If I was to do this, I would have to explicitly add a statement to my build scripts that built bluebird without those modules every time my packages were resolved, and rebuild if my project starts to use one of the optional methods is called within my project (imposing some small amount of overhead).
Therefore, I think this is still a relevant issue to track. It's unrealistic to expect users to create implementation-specific builds when there is a perfectly good vehicle to prevent them from having to do so.
Perhaps https://github.com/rollup/rollup/wiki/jsnext:main?

Also, as the node-bluebird steps to create a custom build suggest, this has to be done from a cloned instance of bluebird. The gruntfile associated with Bluebird is npm ignored, so actually adding this to my build pipeline does not work.

Right, the command has changed to ./build but other than that everything should work the same, e.g. node tools/build.js --features=core --no-debug --release --browser --minify
This builds core without "zalgo" (which should be revomeed anyway) which means it should act exactly the same as the full build.
Bluebird's architecture is a bit... different, so I have doubts that rollup's automatic tree shaking will actually work on it. As far as I know, rollup cannot remove individual class methods ( which is what you would need to build a stripped-down version of bluebird). It can only deal with static imports and exports.
Just fyi, the difference between the minified core build and the full build isn't that great:
118758 18 Nov 09:24 bluebird.core.js
55367 18 Nov 09:24 bluebird.core.min.js
178174 18 Nov 09:24 bluebird.js
79282 18 Nov 09:24 bluebird.min.js
Minified + gzipped its 22kb (full), 16kb (core)

I am not suggesting that Bluebird Rollup per se, just suggesting an exposed jsnext:main in the package.json that enabled the use of bluebird's modules as esModules.
I am curious about the reason Bluebird's architecture is so different. It's such a vastly popular library, I would think that there was an effort to make it uniformly consumable as modules.

@benderTheCrime Its written as core + mixins that are applied to that core. This enables custom builds. Otherwise, all features would be provided by a single class and you would not be able to configure what will be included at all (and rollup would not be able to eliminate anything)

Also I am not sure if it is related but because every file is a callable function with dynamic mixins rather than static export, you can make multiple independent yet interoperating copies of the library this way. If a library wants to use bluebird and extend it somehow, they can make such copy and users will not get those extensions in their bluebird promise even if npm decides to use the same copy of the library.


Colors are rendering incorrectly on macOS

Ebitengine Version
2.6.3
Operating System

[ ] Windows
[X] macOS
[ ] Linux
[ ] FreeBSD
[ ] OpenBSD
[ ] Android
[ ] iOS
[ ] Nintendo Switch
[ ] PlayStation 5
[ ] Xbox
[ ] Web Browsers

Go Version (go version)
go1.21.5 darwin/amd64
What steps will reproduce the problem?
Explicitly define the screen color via ebiten.Image.Fill()
func (g *Game) Draw(screen *ebiten.Image) {
    screen.Fill(color.RGBA{0x3b, 0x90, 0x30, 0xff})
}

As can be seen in the image under the "What happens instead?" section, it also impacts colors defined by images.
What is the expected result?
The expected result would be that the colors would appear the same in the app's window as they do in other applications (like Chrome, Safari, Slate, Preview)
What happens instead?
The colors are rendered differently. Using the Digital Color Meter on macOS, I can see that the color #3b9030 renders as expected in Safari, Chrome, Preview, and Slate, yet when displayed in an Ebitengine application window, I instead see #009219.
The top-half of the following image is from an app created with Ebitengine, whereas the bottom half is from the app Slate. As you can see, the colors are off when drawn by Ebitengine. Every channel (Red, Green, and Blue) have been altered, with the Red channel changing from 0x3b in the code to 0x00 on screen.

The brown block colors are also off, but just not as pronounced as can be seen with the green background color.
Anything else you feel useful to add?
No response

This is a difference of color space. Ebitengine uses kCGColorSpaceDisplayP3 and this might be different from other applications.

The expected result would be that the colors would appear the same in the app's window as they do in other applications (like Chrome, Safari, Slate, Preview)

What about Firefox?

Firefox is the same as Chrome and Safari. Here is a screenshot of the browsers in the following order: Firefox, Chrome, and Safari.

The content of the test file is:
<!DOCTYPE html>
<html>
    <head>
        <style>
            body {
                color: red;
                background-color: #3b9030;
            }
        </style>
    </head>
    <body></body>
</html>

All 3 of the browsers display the same color for #3b9030. Consulting the Digital Color Meter app, when I hover over the pixels in each of the browser windows, it displays the decimal equivalent for #3b9030.

I wondered if colorspace played a part in this issue. I believe the browsers interpret CSS colors, as well as untagged images, as sRGB. Firefox made changes in version 89 to follow this approach.

OK so the differences are color spaces, and now all the modern browsers now adopt sRGB by default.
I don't think this is a bug in Ebitengine. Ebitengine is not responsible to output colors that are compatible with other applications.
Also, with OpenGL mode, there is no way to control color spaces and probably Display P3 is used. Ebitengine tries to emulate this with Metal for consistency. You can try it with EBITENGINE_GRAPHICS_LIBRARY=opengl go run path/to/your/game.

Using EBITENGINE_GRAPHICS_LIBRARY=opengl go run path/to/your/game made a difference, and the green color now renders correctly. Is there a way to bake this environment value into the binary? When I try EBITENGINE_GRAPHICS_LIBRARY=opengl go build the resulting binary still produces the unexpected colors.
Or is it possible to add an option in Ebitengine to use the sRGB color profile for macOS (e.g. MTKView.colorPixelFormat = .bgra8Unorm_srgb)?

For those researching how to change the graphics library, you need to use ebiten.RunGameWithOptions() instead of ebiten.RunGame()
ebiten.RunGameWithOptions() has a second parameter, which takes a variable of type RunGameOptions. The following is an example of how to create that variable (in this case, named op), and make the change to the GraphicsLibrary value to select OpenGL.
op := &ebiten.RunGameOptions{}
op.GraphicsLibrary = ebiten.GraphicsLibraryOpenGL

Using EBITENGINE_GRAPHICS_LIBRARY=opengl go run path/to/your/game made a difference, and the green color now renders correctly.

That's odd. I got the same result with OpenGL and Metal. I'm using MacBook Pro 2020.

Also, the Metal version is not incorrect. This just uses a different color space than sRGB and some colors might not be able to be represented in sRGB.

Or is it possible to add an option in Ebitengine to use the sRGB color profile for macOS (e.g. MTKView.colorPixelFormat = .bgra8Unorm_srgb)?

I can consider this if you want, but as I said, this is not controllable when OpenGL is used.

Or is it possible to add an option in Ebitengine to use the sRGB color profile for macOS (e.g. MTKView.colorPixelFormat = .bgra8Unorm_srgb)?

I can consider this if you want, but as I said, this is not controllable when OpenGL is used.

As OpenGL has been deprecated by Apple in favor of Metal, I would greatly appreciate it if you would consider adding that as an option.

Using EBITENGINE_GRAPHICS_LIBRARY=opengl go run path/to/your/game made a difference, and the green color now renders correctly.

That's odd. I got the same result with OpenGL and Metal. I'm using MacBook Pro 2020.

Here are the results I have on my 2018 Mac mini (EBITENGINE_GRAPHICS_LIBRARY=opengl on the right window):

Metal
Use CAMetalLayer's colorSpace property. Possible values are:

kCGColorSpaceP3 (the current default)
kCGColorSpaceSRGB
kCGColorSpaceLinearSRGB
etc.

DirectX
(TBD)
OpenGL
There is no way to specify a color space.

We need more investigation.

I failed to find a good solution for DirectX. Probably just ignoring the option would be fine.


Can you upload Demo page?

Hi
I'd like to see how things work. Can you upload demo page?
Thanks

Yes When Notifynder 3 will be released I'll glad to create an example app

Now is Notifynder 3 :smile:

Now is Notifynder 3 :smile:

@fenos shall we ?

@fenos shall we ?

I think it will be fine to upload a tiny app with Notifynder installed and 3 / 4 url entry points where we show how the notifications are sent, retrieved and readed. I'll address this to you @Maxime-BHA if you have time or i'll do it next week

@fenos If you want i can write a demo page tonight!

@Tjoosten Would be amazing if you have the time for it, so we make some user happy :+1:

Alright i started working on it.

@webcrazy @fenos whut guys want to see to be covered in the demo?

@Tjoosten I think the following would be enough:

Send single notification
Send Multiple Notifications
Send Polymorphic Notifications
Retrieve Notifications
Retrieve notification filtering by category
Read Notifications
If you have any others ideas just add them

Thanks again for the effort

@fenos IMHO something about translations would be useful

Does something new happened here? If yes or also not: you can join us now in Slack for discussion.

I've created a public repo for this usecase: https://github.com/Gummibeer/notifynder-demo
Everyone is welcome to add some stuff.

I will close this cause a basic demo exists now with it's own repo. Following issues, ideas and so on pls in the demo repo => https://github.com/Gummibeer/notifynder-demo


add local CPU profile collection

@ofrobots We could keep the "CPU profiler" terminology in the API here but we'll still need to send these profiles as of "wall" profiling type in the Cloud Profiler speak to be consistent with the data agents for other languages produce. Those use "CPU" profiling type to describe profiles where samples represent the actual CPU time spent by the program.

PTAL
(still trying to figure out why gts check fails, which is why travis fails)

PTAL

PTAL

PTAL


LSP Crashes

Component:

[x] VSCode Extension
[ ] VSCodium Extension
[ ] LSP (used with other editor)

Extension version: Stable, latest
LSP version: 0.7.1
OS version and name: Manjaro/Arch, Linux kernel 6.3.9

[x] I am on the latest stable version of the extension/LSP.
[x] I have searched the issues of this repo and believe that this is not a duplicate.

Issue
The LSP seems to consistently crash after opening it.
Logs
[Info  - 10:30:26 PM] Folder added to workspace: file:///home/lime/.julia/dev/Quelia
[Info  - 10:30:26 PM] server initialized!
[Info  - 10:30:28 PM] New settings applied
[Info  - 10:31:03 PM] New settings applied
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/workspace/source_manager.rs:175:48
stack backtrace:
   0: rust_begin_unwind
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/panicking.rs:578:5
   1: core::panicking::panic_fmt
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:67:14
   2: core::panicking::panic
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:117:5
   3: typst_lsp::workspace::source_manager::SourceManager::get_inner_source
   4: typst_lsp::workspace::source_manager::SourceManager::get_all_by_uri
   5: <typst_lsp::lsp_typst_boundary::world::WorkspaceWorld as typst::World>::resolve
   6: typst::eval::import
   7: <typst::syntax::ast::ModuleImport as typst::eval::Eval>::eval
   8: <typst::syntax::ast::Expr as typst::eval::Eval>::eval
   9: typst::eval::eval_markup
  10: std::thread::local::LocalKey<T>::with
  11: typst::eval::eval
  12: typst_lsp::server::document::<impl typst_lsp::server::TypstServer>::on_source_changed::{{closure}}
  13: typst_lsp::server::lsp::<impl tower_lsp::LanguageServer for typst_lsp::server::TypstServer>::did_change::{{closure}}
  14: tower_lsp::jsonrpc::router::Router<S,E>::method::{{closure}}::{{closure}}::{{closure}}
  15: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll
  16: <futures_util::future::future::Map<Fut,F> as core::future::future::Future>::poll
  17: <core::pin::Pin<P> as core::future::future::Future>::poll
  18: <core::pin::Pin<P> as core::future::future::Future>::poll
  19: <tower_lsp::service::LspService<S> as tower_service::Service<tower_lsp::jsonrpc::Request>>::call::{{closure}}
  20: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll
  21: futures_util::stream::stream::StreamExt::poll_next_unpin
  22: <futures_util::stream::stream::buffer_unordered::BufferUnordered<St> as futures_core::stream::Stream>::poll_next
  23: <futures_util::stream::stream::map::Map<St,F> as futures_core::stream::Stream>::poll_next
  24: <futures_util::stream::stream::forward::Forward<St,Si,Item> as core::future::future::Future>::poll
  25: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll
  26: <futures_util::future::poll_fn::PollFn<F> as core::future::future::Future>::poll
  27: tokio::runtime::park::CachedParkThread::block_on
  28: tokio::runtime::scheduler::multi_thread::MultiThread::block_on
  29: tokio::runtime::runtime::Runtime::block_on
  30: typst_lsp::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
[Info  - 10:34:55 PM] Connection to server got closed. Server will restart.
true
[Info  - 10:34:55 PM] Folder added to workspace: file:///home/lime/.julia/dev/Quelia
[Info  - 10:34:55 PM] server initialized!
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/workspace/source_manager.rs:175:48
stack backtrace:
   0: rust_begin_unwind
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/panicking.rs:578:5
   1: core::panicking::panic_fmt
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:67:14
   2: core::panicking::panic
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:117:5
   3: typst_lsp::workspace::source_manager::SourceManager::get_inner_source
   4: typst_lsp::workspace::source_manager::SourceManager::get_all_by_uri
   5: <typst_lsp::lsp_typst_boundary::world::WorkspaceWorld as typst::World>::resolve
   6: typst::eval::import
   7: <typst::syntax::ast::ModuleImport as typst::eval::Eval>::eval
   8: <typst::syntax::ast::Expr as typst::eval::Eval>::eval
   9: typst::eval::eval_markup
  10: std::thread::local::LocalKey<T>::with
  11: typst::eval::eval
  12: typst_lsp::server::document::<impl typst_lsp::server::TypstServer>::on_source_changed::{{closure}}
  13: typst_lsp::server::lsp::<impl tower_lsp::LanguageServer for typst_lsp::server::TypstServer>::did_change::{{closure}}
  14: tower_lsp::jsonrpc::router::Router<S,E>::method::{{closure}}::{{closure}}::{{closure}}
  15: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll
  16: <futures_util::future::future::Map<Fut,F> as core::future::future::Future>::poll
  17: <core::pin::Pin<P> as core::future::future::Future>::poll
  18: <core::pin::Pin<P> as core::future::future::Future>::poll
  19: <tower_lsp::service::LspService<S> as tower_service::Service<tower_lsp::jsonrpc::Request>>::call::{{closure}}
  20: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll
  21: futures_util::stream::stream::StreamExt::poll_next_unpin
  22: <futures_util::stream::stream::buffer_unordered::BufferUnordered<St> as futures_core::stream::Stream>::poll_next
  23: <futures_util::stream::stream::map::Map<St,F> as futures_core::stream::Stream>::poll_next
  24: <futures_util::stream::stream::forward::Forward<St,Si,Item> as core::future::future::Future>::poll
  25: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll
  26: <futures_util::future::poll_fn::PollFn<F> as core::future::future::Future>::poll
  27: tokio::runtime::park::CachedParkThread::block_on
  28: tokio::runtime::scheduler::multi_thread::MultiThread::block_on
  29: tokio::runtime::runtime::Runtime::block_on
  30: typst_lsp::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
[Info  - 10:34:56 PM] Connection to server got closed. Server will restart.
true
[Info  - 10:34:57 PM] Folder added to workspace: file:///home/lime/.julia/dev/Quelia
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/workspace/source_manager.rs:175:48
stack backtrace:
   0: rust_begin_unwind
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/panicking.rs:578:5
   1: core::panicking::panic_fmt
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:67:14
   2: core::panicking::panic
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:117:5
   3: typst_lsp::workspace::source_manager::SourceManager::get_inner_source
   4: typst_lsp::workspace::source_manager::SourceManager::get_all_by_uri
   5: <typst_lsp::lsp_typst_boundary::world::WorkspaceWorld as typst::World>::resolve
   6: std::thread::local::LocalKey<T>::with
   7: comemo::cache::Cache::lookup
   8: std::thread::local::LocalKey<T>::with
   9: typst::eval::eval
  10: typst_lsp::server::document::<impl typst_lsp::server::TypstServer>::on_source_changed::{{closure}}
  11: typst_lsp::server::lsp::<impl tower_lsp::LanguageServer for typst_lsp::server::TypstServer>::did_open::{{closure}}
  12: tower_lsp::jsonrpc::router::Router<S,E>::method::{{closure}}::{{closure}}::{{closure}}
  13: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll
  14: <futures_util::future::future::Map<Fut,F> as core::future::future::Future>::poll
  15: <core::pin::Pin<P> as core::future::future::Future>::poll
  16: <core::pin::Pin<P> as core::future::future::Future>::poll
  17: <tower_lsp::service::LspService<S> as tower_service::Service<tower_lsp::jsonrpc::Request>>::call::{{closure}}
  18: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll
  19: futures_util::stream::stream::StreamExt::poll_next_unpin
  20: <futures_util::stream::stream::buffer_unordered::BufferUnordered<St> as futures_core::stream::Stream>::poll_next
  21: <futures_util::stream::stream::map::Map<St,F> as futures_core::stream::Stream>::poll_next
  22: <futures_util::stream::stream::forward::Forward<St,Si,Item> as core::future::future::Future>::poll
  23: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll
  24: <futures_util::future::poll_fn::PollFn<F> as core::future::future::Future>::poll
  25: tokio::runtime::park::CachedParkThread::block_on
  26: tokio::runtime::scheduler::multi_thread::MultiThread::block_on
  27: tokio::runtime::runtime::Runtime::block_on
  28: typst_lsp::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
[Info  - 10:34:57 PM] Connection to server got closed. Server will restart.
true
[Info  - 10:34:57 PM] Folder added to workspace: file:///home/lime/.julia/dev/Quelia
[Info  - 10:34:57 PM] server initialized!
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/workspace/source_manager.rs:175:48
stack backtrace:
   0: rust_begin_unwind
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/panicking.rs:578:5
   1: core::panicking::panic_fmt
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:67:14
   2: core::panicking::panic
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:117:5
   3: typst_lsp::workspace::source_manager::SourceManager::get_inner_source
   4: typst_lsp::workspace::source_manager::SourceManager::get_all_by_uri
   5: <typst_lsp::lsp_typst_boundary::world::WorkspaceWorld as typst::World>::resolve
   6: typst::eval::import
   7: <typst::syntax::ast::ModuleImport as typst::eval::Eval>::eval
   8: <typst::syntax::ast::Expr as typst::eval::Eval>::eval
   9: typst::eval::eval_markup
  10: std::thread::local::LocalKey<T>::with
  11: typst::eval::eval
  12: typst_lsp::server::document::<impl typst_lsp::server::TypstServer>::on_source_changed::{{closure}}
  13: typst_lsp::server::lsp::<impl tower_lsp::LanguageServer for typst_lsp::server::TypstServer>::did_change::{{closure}}
  14: tower_lsp::jsonrpc::router::Router<S,E>::method::{{closure}}::{{closure}}::{{closure}}
  15: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll
  16: <futures_util::future::future::Map<Fut,F> as core::future::future::Future>::poll
  17: <core::pin::Pin<P> as core::future::future::Future>::poll
  18: <core::pin::Pin<P> as core::future::future::Future>::poll
  19: <tower_lsp::service::LspService<S> as tower_service::Service<tower_lsp::jsonrpc::Request>>::call::{{closure}}
  20: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll
  21: futures_util::stream::stream::StreamExt::poll_next_unpin
  22: <futures_util::stream::stream::buffer_unordered::BufferUnordered<St> as futures_core::stream::Stream>::poll_next
  23: <futures_util::stream::stream::map::Map<St,F> as futures_core::stream::Stream>::poll_next
  24: <futures_util::stream::stream::forward::Forward<St,Si,Item> as core::future::future::Future>::poll
  25: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll
  26: <futures_util::future::poll_fn::PollFn<F> as core::future::future::Future>::poll
  27: tokio::runtime::park::CachedParkThread::block_on
  28: tokio::runtime::scheduler::multi_thread::MultiThread::block_on
  29: tokio::runtime::runtime::Runtime::block_on
  30: typst_lsp::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
[Info  - 10:34:57 PM] Connection to server got closed. Server will restart.
true
[Info  - 10:34:57 PM] Folder added to workspace: file:///home/lime/.julia/dev/Quelia
[Info  - 10:34:57 PM] server initialized!
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/workspace/source_manager.rs:175:48
stack backtrace:
   0: rust_begin_unwind
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/panicking.rs:578:5
   1: core::panicking::panic_fmt
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:67:14
   2: core::panicking::panic
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:117:5
   3: typst_lsp::workspace::source_manager::SourceManager::get_inner_source
   4: typst_lsp::workspace::source_manager::SourceManager::get_all_by_uri
   5: <typst_lsp::lsp_typst_boundary::world::WorkspaceWorld as typst::World>::resolve
   6: typst::eval::import
   7: <typst::syntax::ast::ModuleImport as typst::eval::Eval>::eval
   8: <typst::syntax::ast::Expr as typst::eval::Eval>::eval
   9: typst::eval::eval_markup
  10: std::thread::local::LocalKey<T>::with
  11: typst::eval::eval
  12: typst_lsp::server::document::<impl typst_lsp::server::TypstServer>::on_source_changed::{{closure}}
  13: typst_lsp::server::lsp::<impl tower_lsp::LanguageServer for typst_lsp::server::TypstServer>::did_change::{{closure}}
  14: tower_lsp::jsonrpc::router::Router<S,E>::method::{{closure}}::{{closure}}::{{closure}}
  15: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll
  16: <futures_util::future::future::Map<Fut,F> as core::future::future::Future>::poll
  17: <core::pin::Pin<P> as core::future::future::Future>::poll
  18: <core::pin::Pin<P> as core::future::future::Future>::poll
  19: <tower_lsp::service::LspService<S> as tower_service::Service<tower_lsp::jsonrpc::Request>>::call::{{closure}}
  20: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll
  21: futures_util::stream::stream::StreamExt::poll_next_unpin
  22: <futures_util::stream::stream::buffer_unordered::BufferUnordered<St> as futures_core::stream::Stream>::poll_next
  23: <futures_util::stream::stream::map::Map<St,F> as futures_core::stream::Stream>::poll_next
  24: <futures_util::stream::stream::forward::Forward<St,Si,Item> as core::future::future::Future>::poll
  25: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll
  26: <futures_util::future::poll_fn::PollFn<F> as core::future::future::Future>::poll
  27: tokio::runtime::park::CachedParkThread::block_on
  28: tokio::runtime::scheduler::multi_thread::MultiThread::block_on
  29: tokio::runtime::runtime::Runtime::block_on
  30: typst_lsp::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
[Error - 10:34:57 PM] The Typst Language Server server crashed 5 times in the last 3 minutes. The server will not be restarted. See the output for more information.

I have the same problem, here on Windows 11 with VS-Code.

v0.7.0 & 0.7.1 don't work with mason.nvim in Neovim. Only if I type :MasonInstall<EMAIL_ADDRESS>and do CocRestart (or re-open) it will work. coc.nvim and mason.nvim don't produce any logs that show that typst-lsp server has failed.

Logs

You should enclose long text (code, logs etc.) in <details> tag (optionally with <summary>):
<details><summary>Optional name</summary>

< your logs >

</details>

https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/organizing-information-with-collapsed-sections#creating-a-collapsed-section

Same problem happening here.
It seems to be caused by missing files in import statements, like #import "missing.typ": *
When I remove the import the problem goes away. It'd be nice to have it more robust.

@nvarner, will the release assets be added later? I wanted to try the new version, but mason tells me:
Failed to download file "https://github.com/nvarner/typst-lsp/releases/download/v0.7.2/typst-lsp-linux-x64".

https://github.com/nvarner/typst-lsp/releases/tag/v0.7.2

@Andrew15-5 if you haven't yet seen, the assets are up now. They get uploaded automatically by GH Actions, which itself is triggered by creating the release, so there's usually a short delay.

Oh, wow, you can even manage assets automatically, I should check it out. Thanks.


Replace some portal URLs

They redirect to docs.debricked.com anyway.

I replaced everything except the final line in the README about contributions, since it wasn't clear what to replace it with, maybe a link to docs + debricked-community organisation? :thinking:


usage with feathersjs authentication module on react-native

Hi
How could I use AsyncStorage with the feathersjs authentication service on react-native.
I used to do:
this.app = feathers()
      .configure(socketio(socket))
      .configure(hooks())
      // Use AsyncStorage to store our login toke
      .configure(authentication({
        storage: AsyncStorage
      }));
  }

but it doesn't work anymore with RN 0.30 and latest feathers client api
I tried
import localstorage from 'feathers-localstorage';
this.app = feathers()
      .configure(socketio(socket))
      .configure(hooks())
      .use('/auth', localstorage({ storage: AsyncStorage }));

but it doesn't work either (return an error: _this2.app.authenticate is not a function)

feathers-localstorage is a service wrapper for Async- or Localstorage and not used in the authentication module (anymore). Are you getting any errors using
const app = feathers()
      .configure(socketio(socket))
      .configure(hooks())
      // Use AsyncStorage to store our login toke
      .configure(authentication({
        storage: AsyncStorage
      }));

How are you using this setup?

No I don't get any error using this. But it doesn't seem to work anymore as the authentication is not stored (I have to re-authenticate each time I restart the app whereas with previous version of react native it was working as expected and the authentication token was correctly stored)


Dynamic containernames in docker-compose.yml

Do you support dynamic container names?
Currently we using docker-compose.yml files with dynamic container names getting set by env variables.
Example shortend docker-compose.yml file
version: "2.0"
services:
  app:
    container_name: ${PROJECT_NAME}-app
[........]

Can be started via PROJECT_NAME=testproject docker-compose up
Looking forward to your answer, thanks a lot!
Tryed
PROJECT_NAME=testproject lazydocker
but no container showing up

Addition to dynamic container names.
Using COMPOSE_PROJECT_NAME (https://docs.docker.com/compose/reference/envvars/) for containernames works in compose file, but does not show up in lazydocker


InvalidOperationException: Timeouts not supported with this stream when using BaGet

Description
I want to install a nuget package from our BaGet server (https://github.com/ai-traders/BaGet). This fails with an InvalidOperationException: Timeouts werden in diesem Datenstrom nicht unterstützt (german windows, the error message says timeouts are not supported for this data stream). It works with the previous stable version (5.181.1)
This behaviour was observed on Windows 10 with both the full dotnet framework and the dotnet core sdk installed (latest-ish versions - let me know if the precicse versions help)
Repro steps
Please provide the steps required to reproduce the problem

Create a new f# console application, add the paket bootstrapper

Use this as paket.dependencies

storage: none
source https://api.nuget.org/v3/index.json
framework: auto-detect

nuget FSharp.Core

source https://baget.cloud.douglasconnect.com/v3/index.json
nuget DouglasConnect

Run paket install and you should see the InvalidOperationException.

Expected behavior
The package should be downloaded and installed
Actual behavior
An exception occurs:
Paket failed with
-> Could not download DouglasConnect 6.0.6 from https://baget.cloud.douglasconnect.com/v3/package/douglasconnect/6.0.6/douglasconnect.6.0.6.nupkg.

Known workarounds
Switch from using paket in magic mode to using the last stable version.

We are experiencing the same error, InvalidOperationException: Timeouts are not supported on this stream. when using paket 5.183.0. The version 5.181.1 works fine.

ok I'm reverting

I can confirm this issue also occurs for ProGet feeds.

Latest version should work again. Can anyone confirm?
Raphael Schweizer<EMAIL_ADDRESS>schrieb am Mi., 31. Okt. 2018,
08:41:

I can confirm this issue also occurs for ProGet feeds.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/issues/3407#issuecomment-434590430,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNKJ5z09aN6rOKNCQpU0T2WTor10aks5uqVRCgaJpZM4YCZm9
.

@forki Yes, latest (5.184.0) does work. Sorry, should have mentioned this as well.

Ok good.
If someone finds a way to reapply the PR in a way that is non-breaking then
it would be appropriated.
Raphael Schweizer<EMAIL_ADDRESS>schrieb am Mi., 31. Okt. 2018,
09:06:

@forki https://github.com/forki Yes, latest (5.184.0) does work. Sorry,
should have mentioned this as well.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/issues/3407#issuecomment-434595325,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNIzhVGyU8-8y2KO9qZMAPaPkAaW1ks5uqVl6gaJpZM4YCZm9
.

@forki - Just following up - 5.184.0 is working for me as well. Thanks!

Thanks to the feed provided i think that i was able to solve the problem and will make a PR tomorrow.
One remaining question to be answered would be if the default timeouts set are ok like they are now.
They could just be set to never timeout as default.

Thanks


Adding a Popup to every Label of a Multiple Search Selection

Bug Report
I was trying to add a popup for the selected options in a Multiple Search by using the renderLabel property of Dropdown. It works fine, except some warnings in browser's console.
Steps
My code:
const UsersDropdown = ({handleChange, options, onLabelClick}) => {

  const renderLabel = (item, index, defaultLabelProps) => {
    const {active, as, key, onRemove, value} = defaultLabelProps;
    return (
      <Popup
        trigger={
        <Label
        content={item.text}
        active={active}
        as={as}
        key={key}
        onRemove={onRemove}
        value={value}
        />
      }
      >
        <div> Some Content</div>
      </Popup>
    )
  };

  return (
    <Dropdown
      placeholder='Participants'
      name='participants'
      fluid
      multiple
      search
      selection
      options={options}
      onLabelClick={onLabelClick}
      onChange={handleChange}
      renderLabel={renderLabel}
    />
  )
};

Expected Result
It actually works like it's supposed to, except the warnings.
Actual Result
The first and only first time I try to hover (or click if the pop-up is triggered by a click) over a label inside the dropdown, I get the warnings below, but otherwise, everything works fine. If the popup is not triggered, the warnings won't appear.

Version
^0.88.0
This is my first time posting an issue on github, sorry if I didn't respect some rules or templates, or if I wasn't explicit enough. Thanks!

Please ask usage questions on Stackoverflow. We use these issues for tracking bugs.


No marker for mutes?

What did you do?
When an alert is silenced in Alertmanager its status is changed from active to suppressed, and the JSON responses for /api/v1/alerts and /api/v2/alerts contain the the IDs(s) of all silences that suppressed it:
[
  {
    "annotations": {},
    "endsAt": "2023-09-07T10:43:50.291+01:00",
    "fingerprint": "3fff2c2d7595e046",
    "receivers": [
      {
        "name": "test"
      }
    ],
    "startsAt": "2023-09-07T10:38:50.291+01:00",
    "status": {
      "inhibitedBy": [],
      "silencedBy": [
        "ed411cae-78ea-47bc-90f5-1e474d6f526e"
      ],
      "state": "suppressed"
    },
    "updatedAt": "2023-09-07T10:38:50.291+01:00",
    "labels": {
      "foo": "bar"
    }
  }
]

However, the same is not said for mutes:
ts=2023-09-07T09:54:39.161Z caller=notify.go:902 level=debug component=dispatcher msg="Notifications not sent, route is within mute time"

  {
    "annotations": {},
    "endsAt": "2023-09-07T10:59:09.159+01:00",
    "fingerprint": "3fff2c2d7595e046",
    "receivers": [
      {
        "name": "test"
      }
    ],
    "startsAt": "2023-09-07T10:54:09.159+01:00",
    "status": {
      "inhibitedBy": [],
      "silencedBy": [],
      "state": "active"
    },
    "updatedAt": "2023-09-07T10:54:09.159+01:00",
    "labels": {
      "foo": "bar"
    }
  }
]

What did you expect to see?
I expected to see "state": "suppressed" and perhaps "mutedBy", just like we have "inhibitedBy" and "silencedBy".
It would be good to understand if this is intention or perhaps just something that was missed when mutes were added to Alertmanager.

When an alert is muted I think it's status should be set to suppressed and the API returns a new field called "mutedBy" containing the names of the applied mute timings. I think we should keep "mutedBy" and "silencedBy" as separate fields as mutes and silences are separate features in Alertmanager.

@grobinson-grafana I think we can close this now?


make abigen-ed modules pub

Motivation
Allows end-users to work around https://github.com/gakonst/ethers-rs/issues/867

Solution
This makes it possible to refer directly to generated types when they have the same name (as occurs with event filter types when one contract inherits another).

PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Updated the changelog

I’ve updated ethers and still getting this error[E0616]: field 0of structiuniswapv2pair_mod::IUniswapV2Pair is private


Integrate into VictiScout

As much as I wish they would, nobody is ever going to learn how to use a CLI to use this. We should just integrate the functionality from vs into VictiScout directly. It'll be easier for everyone (and not even that hard to implement, I don't think).

This is now pretty much done. Farewell, sweet prince.


[Depends on #14399] New provider provisioning

Use OvirtSDK for the provisioning flow, this respects use_ovirt_engine_sdk setting
and will not use OvirtSDK if it is off.
This PR is based on: https://github.com/ManageIQ/manageiq/pull/14398

@borod108 after rebasing, could you also run rubocop -a on the reported files?

ok, except for the phase_context stuff. But if you dont find a way to refactor it, we can try to get it in like this...

@borod108 maybe you want to squash all commits into one? Seems there are just leftovers and and rubocop fixes...
Also - are we waiting for QE tests to pass on this PR or is it good to go from your side?
@miq-bot add_label fine/yes

@durandom so we fixed the rubocops, squashed the commits, and stabilized the version (for both apis with accent on verifying version 3).
We feel ready to merge.

IMHO If we are close to extracting the RHV repo it would make more sense to do that an apply this PR there instead of trying to get this merged quickly.  With other activities going on and some people on PTO I do not see that this PR could be properly reviewed quickly.  One commit with 35 files only extends the timeframe required.

@gmcculloug fair enough, so we'll split repos and ping you again on the new PR

@borod108 this can be closed

PR moved to new provider repo https://github.com/ManageIQ/manageiq-providers-ovirt/pull/2


636 - Check that diamond storage is untouched after each pull request

Resolves #636

There are no successful runs of this CI. Can you prove that it is functional?
https://github.com/PhantomCracker/ubiquity-dollar/actions/workflows/check-diamond-storage.yml

I checked the latest log, and it looks like it only runs on pull requests. Make sure to open a mock pull request on your fork and post the proof of a successful run here when ready. At that point zgo can take a look and see if it archives the specification. Thanks!

Hello @rndquu , yes, please let me know if everything is ok on your side.

There's a warning with "yes standard output broken pipe" can you look into that?

There's a warning with "yes standard output broken pipe" can you look into that?

Can you please let me know where do you see this warning message?

https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5381772606/jobs/9766281151#step:8:10

@rndquu , @zgorizzo69 can you also have a look please?

Any news here?

Any news here?

hey, I'll check it today

Thank you for explanations, I will continue with this ticket in a few hours after I will finish with 663

@PhantomCracker if you're working on this PR, kindly sync with development, as there are a lot of changes!

I update it daily from the development branch, but thank you for the tip 👍

This two actions can be checked:
https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5518756582/jobs/10063137362
https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5518756878/jobs/10063138245

Hei @rndquu ,
Regarding https://github.com/ubiquity/ubiquity-dollar/pull/666/checks?check_run_id=14941872644 do you know what changes has been made? I see that on my side everything pass correctly.
Regarding https://github.com/ubiquity/ubiquity-dollar/actions/runs/5518930201/jobs/10063516480?pr=666 can not be fixed until we merge the PR to development at one of the steps, i checkout to development branch and i try to run my script (diamond-storage.ts) again, but it is not found.

I am looking forward to see if I can use forge inspect for libraries too...

i think we should close this PR, this doesn't seem like a clean PR. mergin this makes the contributions looks bad. We should enforce the bounty hunter for a clean PR, also if the bounty hunter shouldn't test many times things on the PR maybe 3-5 times, but subsequently clogging the PR que testing commits, doesn't look good @rndquu

i think we should close this PR, this doesn't seem like a clean PR. mergin this makes the contributions looks bad. We should enforce the bounty hunter for a clean PR, also if the bounty hunter shouldn't test many times things on the PR maybe 3-5 times, but subsequently clogging the PR with testing commits, doesn't look good @rndquu

Maybe chill and let me do my job, I will let you know when I am finishing this :)
Thank you

Sure, but it's better you open a new PR @PhantomCracker

Sure, but it's better you open a new PR @PhantomCracker

I agree, but I made a lot of changes on this and now it's pretty to late for a new branch :)

You can still make the changes clean on a new a PR, you know what changes you did, and what to commit, you can still complete the bounty on a clean PR

but subsequently clogging the PR with testing commits, doesn't look good @rndquu

Squash and merge is useful for this.

i think we should close this PR, this doesn't seem like a clean PR. mergin this makes the contributions looks bad. We should enforce the bounty hunter for a clean PR, also if the bounty hunter shouldn't test many times things on the PR maybe 3-5 times, but subsequently clogging the PR with testing commits, doesn't look good @rndquu

I agree that this PR is clogged with "test" commits (along with my github email notifications which I get for every push to the current PR) which doesn't look at its best
But this PR is still within our policies of solving the bounties:

bounty hunter self assigned an issue and have a time deadline
draft PR is opened
work is ongoing

So if we want to change something then we should start from our own policies.

So you receive email for each push? Sorry for this... this is the last bounty that it will be clogged with testing commits, maybe you can unassign every participant to this discussion and when I will finish it I will require your reviews again?

So if we want to change something then we should start from our own policies.

New policies to roll out soon™ with comment incentives.

@rndquu @pavlovcik can you please check this?
We need the new files on both dev branch and the new PR branch.
Here is a proof of testing: https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5853930729/job/15869111471

@PhantomCracker

There are 3 jobs in the "Diamond Storage Check" workflow. Right now they are running in parallel. You sure they are not order dependent?
Pls provide a PR with a successful run of the "Diamond Storage Check" workflow
Pls provide a PR with an error run of the "Diamond Storage Check" workflow (when the storage is modified incorrectly)

@PhantomCracker

There are 3 jobs in the "Diamond Storage Check" workflow. Right now they are running in parallel. You sure they are not order dependent?
Pls provide a PR with a successful run of the "Diamond Storage Check" workflow
Pls provide a PR with an error run of the "Diamond Storage Check" workflow (when the storage is modified incorrectly)

That is not important because first time we check the new PR and after that we check development, then we compare the values from both branches
https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5856557646
https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5850725104/job/15860643817

@PhantomCracker

There are 3 jobs in the "Diamond Storage Check" workflow. Right now they are running in parallel. You sure they are not order dependent?
Pls provide a PR with a successful run of the "Diamond Storage Check" workflow
Pls provide a PR with an error run of the "Diamond Storage Check" workflow (when the storage is modified incorrectly)

That is not important because first time we check the new PR and after that we check development, then we compare the values from both branches
https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5856557646
https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5850725104/job/15860643817

I don't understand what PRs those action runs match

Ok, so i need to create 2 new PR's, i will do this today I guess, i am a little busy with some personal issues...

Is it only me, or others have this issue on build too?

Is it only me, or others have this issue on build too?

The latest build in the development branch passed without errors

Ok, here is the success message PR: https://github.com/PhantomCracker/ubiquity-dollar/pull/20

Ok, here is the success message PR: PhantomCracker#20 I will try to do the PR with error message too, do you have any tips for that? And here is with the "error": PhantomCracker#21 @rndquu

I don't understand
Could you provide PRs with the "Diamond Storage Check" workflow in action?
This one (success) doesn't change any solidity files.
This one (error) actually passes without errors. It doesn't change any solidity files either.
How can we make sure that the workflow fails when the storage is not correctly modified?

This isn't a good test for error?
I know that I am not throwing an error, but I can modify that to throw an error, at this point I just log "Modifications found!"
in check_diamond_storage -> Compare files
This is the action for the success message: https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5911052693 (No modifications found)
This is the action for the error message: https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5911057959/job/16033296361 (Modifications found!)
If I can help somehow else with testings, please let me know @rndquu

 This isn't a good test for error? I know that I am not throwing an error, but I can modify that to throw an error, at this point I just log "Modifications found!" in check_diamond_storage -> Compare files This is the action for the success message: https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5911052693 (No modifications found) This is the action for the error message: https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5911057959/job/16033296361 (Modifications found!)
If I can help somehow else with testings, please let me know @rndquu

Oh, I see, it's inside the "Compare files" step
Pls refactor to throw an error if there are incorrect modifications found


ImageFilter.blur creates shadow around image

When wanting to blur an image in flutter, it creates a shadow around the image. While nothing app-breaking, it is a nuisance when your lead designer wants NO shadow on the image.
Steps to Reproduce
Container(
                  height: 220,
                  decoration: BoxDecoration(
                    image: DecorationImage(
                      fit: BoxFit.cover,
                      image: image,
                    ),
                  ),
                  child: BackdropFilter(
                    filter: ImageFilter.blur(sigmaX: 10 ,sigmaY: 10),
                    child: new Container(
                      decoration:
                          BoxDecoration(color: Colors.black.withOpacity(0.5)),
                    ),
                  ),
                );

bunch of unused imports and fields
Flutter doctor
[√] Flutter (Channel master, v1.8.2-pre.242, on Microsoft Windows [Version 10.0.18362.295], locale en-US)
    • Flutter version 1.8.2-pre.242 at C:\src\flutter
    • Framework revision 9bb7142ef7 (5 weeks ago), 2019-07-30 14:45:00 -0700
    • Engine revision c41bbc63d9
    • Dart version 2.5.0 (build 2.5.0-dev.1.0 1e43d65d4a)

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at C:\Users\User\AppData\Local\Android\Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = C:\Users\User\AppData\Local\Android\Sdk
    • ANDROID_SDK_ROOT = C:\Users\User\AppData\Local\Android\Sdk
    • Java binary at: C:\Program Files\Java\jdk1.8.0_191\bin\java
    • Java version Java(TM) SE Runtime Environment (build 1.8.0_191-b12)
    • All Android licenses accepted.

[√] Android Studio (version 3.4)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 38.2.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[!] Android Studio
    • Android Studio at C:\Program Files\Android\Android Studio\bin
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    X android-studio-dir = C:\Program Files\Android\Android Studio\bin
    X Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.
    • Consider removing your android-studio-dir setting by running:
      flutter config --android-studio-dir=

[√] IntelliJ IDEA Community Edition (version 2018.3)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2018.3
    • Flutter plugin version 32.0.2
    • Dart plugin version 183.4588.61

[√] VS Code (version 1.37.1)
    • VS Code at C:\Users\User\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.3.0

[√] VS Code, 64-bit edition (version 1.37.1)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.3.0

[√] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 8.1.0 (API 27) (emulator)

! Doctor found issues in 1 category.

You could do something like this, by blurring the container child instead.
class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
return new MaterialApp(
home: new Container(
decoration: new BoxDecoration(
image: new DecorationImage(
image: new ExactAssetImage('assets/dog.png'),
fit: BoxFit.cover,
),
),
child: new BackdropFilter(
filter: new ImageFilter.blur(sigmaX: 10.0, sigmaY: 10.0),
child: new Container(
decoration: new BoxDecoration(color: Colors.white.withOpacity(0.0)),
),
),
),
);
}
}
Find At Here

A blur effect will extend the edges of the object being blurred as the pixels near the edge are blurred into the surrounding area. If you want to clip the edges of the blur off then you will need to use one of the various Clip* widgets (likely ClipRect in this case).

Also note that we now have the ImageFiltered widget which can achieve the blur effect more directly, as in:
ImageFiltered(
  filter: ImageFilter.blur(sigmaX: 10 ,sigmaY: 10),
  child: Image(),
),

The ImageFiltered would also expand the bounds of the image due to the blur operation, so you would also need to use a ClipRect with this solution if you don't want the blurry edges to expand beyond the original image bounds.

Hi @flar,tthansk for solution
Using same image with fit: BoxFit.cover  is causing weird artifact
    child: ImageFiltered(
            imageFilter: ImageFilter.blur(sigmaX: 10, sigmaY: 10),
            child: Container(
                decoration: BoxDecoration(color: Colors.black.withOpacity(0.5)),
                child: Image.network(
                  'https://i.imgur.com/QCNbOAo.png',
                  height: 200,
                  width: 200,
                  fit: BoxFit.cover,
                )),
          ),

using  fit: BoxFit.contain
  child: ImageFiltered(
            imageFilter: ImageFilter.blur(sigmaX: 10, sigmaY: 10),
            child: Container(
                decoration: BoxDecoration(color: Colors.black.withOpacity(0.5)),
                child: Image.network(
                  'https://i.imgur.com/QCNbOAo.png',
                  height: 200,
                  width: 200,
                  fit: BoxFit.contain,
                )),
          )

Code Sample
import 'dart:ui';

import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: Center(
        child: Container(
          child: ImageFiltered(
            imageFilter: ImageFilter.blur(sigmaX: 10, sigmaY: 10),
            child: Container(
                decoration: BoxDecoration(color: Colors.black.withOpacity(0.5)),
                child: Image.network(
                  'https://i.imgur.com/QCNbOAo.png',
                  height: 200,
                  width: 200,
                  fit: BoxFit.cover,
                )),
          ),
        ),
      ),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.adb),
        onPressed: () {},
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel dev, 1.20.0-7.0.pre, on Mac OS X 10.15.5 19F101, locale en-GB)
    • Flutter version 1.20.0-7.0.pre at /Users/taha/Code/flutter_dev
    • Framework revision cc1af3afb6 (2 days ago), 2020-07-08 10:19:36 -0700
    • Engine revision 0dc86cda19
    • Dart version 2.9.0 (build 2.9.0-20.0.dev 06cb010247)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/taha/Code/sdk
    • Platform android-30, build-tools 30.0.0
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.47.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.2

[✓] Connected device (4 available)
    • SM M305F (mobile) • 32003c30dc19668f • android-arm64  • Android 10 (API 29)
    • macOS (desktop)   • macos            • darwin-x64     • Mac OS X 10.15.5 19F101
    • Web Server (web)  • web-server       • web-javascript • Flutter Tools
    • Chrome (web)      • chrome           • web-javascript • Google Chrome 83.0.4103.116

• No issues found!

I'm not seeing that effect in this dartpad: https://dartpad.dev/1019ddb4e9c8d8a42370071b79f98426
I wonder if it is an effect that comes into play when the image is laid out in a container causing stretching of its edges?

I can also confirm this issue.

I don't have the same issue, instead when I use it in the flexibleSpace of a SliverAppBar it shrinks my image (notice the blue background being shown).

flexibleSpace: Stack(
                children: [
                  Positioned.fill(
                    child: ImageFiltered(
                      imageFilter: ImageFilter.blur(
                        sigmaX: 2,
                        sigmaY: 2,
                      ),
                      child: Image.asset(
                        'assets/images/CoverPicture.jpg',
                        fit: BoxFit.cover,
                      ),
                    ),
                  ),
                ],
              ),

Any idea how can I stop it from shrinking the app bar?

Preview
Scaffold Body

code sample
import 'dart:ui';

import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      // body: CustomScrollView(
      //   slivers: [
      //     SliverAppBar(
      //       pinned: true,
      //       backgroundColor: Colors.red,
      //       collapsedHeight: 250,
      //       flexibleSpace: Stack(
      //         children: [
      //           Positioned.fill(
      //             child: ImageFiltered(
      //               imageFilter: ImageFilter.blur(
      //                 sigmaX: 10,
      //                 sigmaY: 10,
      //               ),
      //               child: Image.network(
      //                 'https://i.imgur.com/9OrBvmZ.jpg',
      //                 fit: BoxFit.cover,
      //               ),
      //             ),
      //           ),
      //         ],
      //       ),
      //     ),
      //     SliverFillRemaining()
      //   ],
      // ),

      body: Container(
        color: Colors.red,
        child: Stack(
          children: [
            Positioned.fill(
              child: ImageFiltered(
                imageFilter: ImageFilter.blur(
                  sigmaX: 10,
                  sigmaY: 10,
                ),
                child: Image.network(
                  'https://i.imgur.com/9OrBvmZ.jpg',
                  fit: BoxFit.cover,
                ),
              ),
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.add),
        onPressed: () {},
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel master, 1.24.0-8.0.pre.408, on macOS 11.0.1 20B29
    darwin-x64, locale en-GB)
    • Flutter version 1.24.0-8.0.pre.408 at
      /Users/tahatesser/Code/flutter_master
    • Framework revision 25986102c1 (2 hours ago), 2020-12-02 20:36:44 +0800
    • Engine revision 20caf54969
    • Dart version 2.12.0 (build 2.12.0-76.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.2)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.2, Build version 12B45b
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.51.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (5 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64  •
      Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios            • iOS
      14.2
    • macOS (desktop)      • macos                     • darwin-x64     • macOS
      11.0.1 20B29 darwin-x64
    • Web Server (web)     • web-server                • web-javascript •
      Flutter Tools
    • Chrome (web)         • chrome                    • web-javascript • Google
      Chrome 87.0.4280.67

• No issues found!

Hi @TahaTesser, thanks for getting back on my issue. Yeah I understand it's not an issue with the SliverAppBar, the issue for me would still be that I can't add a black background as the image can change based on the user. Is that the last option or is there something else I can do?

See also: https://github.com/flutter/flutter/issues/64828
Can you check your layout to see if the widget is being aligned on a pixel boundary?

@bsfdeep the edges of a blur will be affected by whether the colors near the edges of the source and its sampling mode.
We don't really provide control over the edge sampling mode in Flutter so everything tends to default to pretending that the edges of an image extend to infinity (as opposed to pretending that samples beyond the edge of an image are transparent).
The ImageFilter being applied is using the rendering of a widget as its source. If the widget is aligned to pixel boundaries and it is rendering an opaque content, then it will be opaque at its edges and if those are extended to infinity then the edges of the blur will be sampling and blurring the edges of the image at the edges of the blur.
But, if the source widget is not aligned with pixels then when they get rendered, they will leave the edge pixels of the source semi-transparent. Now that semi-transparent edge pixel is the one that is sampled out to infinity and so the edges of the blur will be averaging together those semi-transparent values and allowing the background to shine through.
This is all discussed in the issue I linked.

@flar That is a great explanation, thank you so much for taking the time.
How do I know if my widget is being aligned on a pixel boundary, do I wrap it in a Positioned widget and force it to have left, right and top = 0.0 (that does not work? My widget tree looks something like this
@override
  Widget build(BuildContext context) {
    return Stack(
      children: [
        CustomScrollView(
          controller: scrollController,
          slivers: [
            SliverAppBar(
              backgroundColor: Colors.red,
              expandedHeight: widget.coverPictureHeight,
              flexibleSpace: Stack(
                children: [
                  Positioned.fill(
                    child: ImageFiltered(
                      imageFilter: ImageFilter.blur(
                        sigmaX: 2,
                        sigmaY: 2,
                      ),
                      child: Image.asset(
                        'assets/images/CoverPicture.jpg',
                        fit: BoxFit.cover,
                      ),
                    ),
                  ),
                ],
              ),
              pinned: true,
              toolbarHeight: kToolbarHeight,
            ),
            SliverList(

I did fix my issue by wrapping it in a Positioned widget with left, right and top as -3, it's just a hack though.

The -3 may have just caused the app to extend out of the bounds of the Stack a little so as to push the potentially Antialiased/partially covered edge pixels to be out of sight. The real fix would be to query the DPR and to ensure that the size and the location are integers when scaled by that number (assuming no other scale in effect, but there may be a translation in effect from Scaffolds and such).
The computation would be (coord * dpr).roundToDouble() / dpr.
For devices with an integer DPR, just having the coordinates and sizes all be integers should be fine, but for devices with non-integer DPR, then you need to perform that calculation.
Note that if you use auto-layout widgets like Center and Row/Column, etc. then you are at the mercy of their calculations. Centering an odd sized child in an even sized container, or vice versa, will put you on non-integer coordinates. It gets more complicated when Rows and Columns compute the space they want to distribute between children and how they apportion that overflow space.
I'm taking a look at a series of examples of where non-integer coordinates can come into play to see what recommendations or changes can be made to make all of this easier for the developer. Unfortunately, Flutter does most layout computations behind the scenes on values that aren't easily queried by the app code (it's not rocket science, but you have to use Key objects and find the RenderObject instances on the second frame and the information can't be queried on the first frame, so it's not obvious and it's a bit klunky) so it gets a little tricky to fix these problems and I'll be looking into what we can do to make that process more natural.
Your technique of just oversizing the blurred background may be the easiest workaround for now.
For an example of determining actual size and positioning of your widgets, you can check out the workarounds I used in this gist that is trying to deal with an anchored rotation for an ImageFiltered matrix filter (note the _childKey and _childCenter variables and how they are created and used): https://gist.github.com/flar/639cf7fcc0988ee9d68333c269e42181

In the meantime I also looked more deeply into how we create blur filters and discovered that Skia has an edge sampling parameter (or "tile mode" as they call it) that we hard-code to edge sampling. They also have a decal mode which assumes transparency around the edges of the source which might work better for rotated/rotating/non-edge filled children. A variant of that property appears in our gradient constructors.

@flar Thanks for the explanation. I just got a chance to look at the gist, though I see how it can be used I guess I'll stick to oversizing the blurred background to avoid complicating it for now. Thanks again for looking into it.

Also, check this https://github.com/flutter/flutter/issues/57180#issuecomment-739962941

See now https://github.com/flutter/flutter/issues/71871

Using the code sample provided here and here, I am unable to replicate the behavior on latest versions.

Closing as fixed.

 stable, master flutter doctor -v
[✓] Flutter (Channel stable, 3.3.8, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.3.8 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 52b3dc25f6 (25 hours ago), 2022-11-09 12:09:26 +0800
    • Engine revision 857bd6b74c
    • Dart version 2.18.4
    • DevTools version 2.15.0

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.6.0-3.0.pre.18, on macOS 12.2.1 21D62 darwin-x64,
    locale en-GB)
    • Flutter version 3.6.0-3.0.pre.18 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 1aeb1721ca (2 hours ago), 2022-11-14 21:12:25 -0500
    • Engine revision 78ae241400
    • Dart version 2.19.0 (build 2.19.0-398.0.dev)
    • DevTools version 2.19.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.


Pick up "beta" part of version info in UserAgent

Looks like this is actually already fixed, by moving to dotnet cli.


Linter Feedback

My initial feedback:

The exclusions file is too verbose. Consider this:

network nic ip-config create:
    parameters:
        private_ip_address_version:
            rule_exclusions:
            - missing_parameter_help_rule
network nic ip-config update:
    parameters:
        private_ip_address_version:
            rule_exclusions:
            - missing_parameter_help_rule
network nsg rule create:
    parameters:
        access:
            rule_exclusions:
            - missing_parameter_help_rule
        direction:
            rule_exclusions:
            - missing_parameter_help_rule
network nsg rule update:
    parameters:
        access:
            rule_exclusions:
            - missing_parameter_help_rule
        direction:
            rule_exclusions:
            - missing_parameter_help_rule

Five lines per exclusion!  JSON would be even longer. Consider a custom format, like so:
network nic ip-config create:
  - private_ip_address_version: missing_parameter_help_rule

network nic ip-config update:
  - private_ip_address_version: missing_parameter_help_rule

network nsg rule create:
   - access: missing_parameter_help_rule
   - direction: missing_parameter_help_rule

network nsg rule update: <command/group/help_entry rules here>
    - access: missing_parameter_help_rule
    - direction: missing_parameter_help_rule, <param rules>

This would be much more readable and doesn't require any keywords.

Don't print anything if a rule has no violations. A quiet linter is a happy linter.

Consider a --report flag which will output violations by module.

When a rule violation does occur, print the link or an explanation for how the user is expected to fix it.

There is a folder commandlint and cli_linter.  Are both of these needed?

Environment summary
Install Method (e.g. pip, interactive script, apt-get, Docker, MSI, edge build) / CLI version (az --version) / OS version / Shell Type (e.g. bash, cmd.exe, Bash on Windows)
azure-cli (2.0.31)

acr (2.0.22)
acs (2.0.30)
advisor (0.5.0)
appservice (0.1.31)
backup (1.1.0)
batch (3.2.0)
batchai (0.2.0)
billing (0.1.8)
cdn (0.0.14)
cloud (2.0.12)
cognitiveservices (0.1.11)
configure (2.0.14)
consumption (0.3.0)
container (0.1.21)
core (2.0.31)
cosmosdb (0.1.20)
dev-tools (0.1.1)
dla (0.0.18)
dls (0.0.20)
eventgrid (0.1.11)
eventhubs (0.1.2)
extension (0.0.12)
feedback (2.1.0)
find (0.2.8)
interactive (0.3.19)
iot (0.1.18)
keyvault (2.0.21)
lab (0.0.20)
monitor (0.1.5)
network (2.0.28)
nspkg (3.0.2)
profile (2.0.22)
rdbms (0.2.1)
redis (0.2.11)
reservations (0.1.1)
resource (2.0.27)
role (2.0.21)
servicebus (0.1.2)
servicefabric (0.0.11)
sql (2.0.25)
storage (2.0.31)
testsdk (0.1.1)
vm (2.0.30)

Extensions:
alias (0.3.0)
subscription (0.1.0)

Python location 'c:\Users\trpresco\Documents\github\azure-cli\env\Scripts\python.exe'
Extensions directory 'C:\Users\trpresco\.azure\cliextensions'

Python (Windows) 3.6.1 (v3.6.1:69c0db5, Mar 21 2017, 17:54:52) [MSC v.1900 32 bit (Intel)]

I also suggested requiring a reason for each exception. It helps when reviewing prs instead of us having to ask.

Also, if I specify a module that doesn't exist, it seems to continue but not sure what it's doing.
It should really error out.

Does --modules take azure-cli-NAME or just NAME?

Works with just the name.

@derekbekoe just the name; for your previous question, it will currently run the rules on an empty command table.

Okay. I just thought all the modules I wrote had no errors.. unfortunately this was not the case 😢

PR #6065 implements a less chatty output and removes the stray commandlint directory.


Bug: Cant pass NONE value to MERGE object to unset fields

Describe the bug
How to unset a field via UPDATE tb MERGE {...} object.? JSON doesn't support this . Do we have a workaround for this?
Steps to reproduce
{
    "data": {
        "opt_name": NONE
    }
}

Expected behaviour
Need a way to unset fields via object
SurrealDB version
v1.0.0-beta.11
SurrealDB.js version
0.8.4
Contact Details
No response
Is there an existing issue for this?

[X] I have searched the existing issues

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @hchockarprasad, I'm afraid you will need to use a custom query for this sort of mutation!

This should be resolved by #227, undefined will now be considered none


Add "Report abuse" to player context menu

Open this URL in a browser: https://docs.google.com/forms/d/e/1FAIpQLSfeg4ywc4JVC4frnpkPi6udTRpPqti0d4lH1DEmlRhWOnpagg/viewform?c=0&w=1

now the reporting can be done on faforver.com.

https://www.faforever.com/account/report


Xorm Shards. Automatical Read/Write seperatelly.

When we have two engines, one is for writing and another is for reading. So we can automatically manage the engines and users can use just like only one engine.
When a SQL is a reading operation, we auto chose to use reading engine, or we will chose to use writing engine.

fixed by #748


Could I send an option with Element to js function?

Summary
I had a js library and the constructor need seed an option with container, width and height. The container must be an HTMLElement. So I want to create a struct and send it as JsValue to js libbrary use Rust and wasm_bindgen. But I got an error the trait `JsCast` is not implemented for `Options` .
Additional Details
The struct like this:
struct Options {
    pub container: web_sys::Element,
    pub width: u32,
    pub height: u32,
}

This isn't currently supported natively, see #2645. You should be able to do this with serde-wasm-bindgen, though: see the 'Preserving JavaScript values' section of their docs for how to get the web_sys::Element working.

Thanks. I will try it.


Terragrunt lock region selection ignores AWS_REGION environment variable

Following up from https://github.com/gruntwork-io/terragrunt/issues/48#issuecomment-260013994, the lock section of the .terragrunt config file allows the user to specify a region. Failing to specify a region uses a hard-coded default of us-east-1. The Go SDK supports the AWS standard AWS_REGION environment variable. Not honoring this setting violates the POLA. :wink:
Suggested order of priority:

region value from .terragrunt
AWS_REGION environment variable
Fall back us-east-1 region

Thanks for the great tool!

Thanks for filing! Any interest in submitting a PR? It should be a pretty straightforward change.

I currently don't work with Go at all. :frowning_face: While it's on my To Do list, I'm hoping someone else picks this up before then.

No worries! We'll see if we can get to this in the next week or two.

This is a simple addition, but here is one question (more about the desired behaviour): given the AWS_REGION environment variable present, should it also override any other place where a region is concerned? For example...
The lock backend (e.g. DynamoDB) can take the desired region from the configuration, but when it goes to the remote state handling, then it works by a virtue of passing arguments to Terraform from the config section of the backend section in the configuration file (these are passed as-is as formatted key-value items). Should the aws_region be overridden here too?

Hey there, @kwilczynski. If I'm following this correctly, if the user enters a remote_state:bucket:region setting, that value (and not the environment value) should be used just as it is today. Manually coded values in a conf file should always override default environment variables.

@davidski hi there! Sorry for not being clear enough, my bad. Although, you have answered my question, thank you!

Since Terraform now natively supports locking, Terragrunt no longer has locking built in, so I think this issue can be closed.


🌐 Update Chinese translation for docs/help-fastapi.md

as title

Awesome, thank you @jaystone776! :rocket:
And thanks for the reviews @TimorChow and @qysfblog :bow: :cookie:


e2e testing recommendation for RU

In my old simple pre Webpack/React days I used to do e2e testing of my API with supertest which just loads the express app. Now I run into all kinds of Webpack/middleware issue which leads me to wonder what the best practice might be. What do you use to test an API with RU?  test against a running production server?  with which tools?

@cyberwombat I run a slightly modified version of this for one of my projects. The API is separated from the server-side rendering, but Ive been testing the API right alongside my React app using Jest. However, I've still got a couple tests still relying on chai.
You can see the full repo https://github.com/strues/boldr or here is how I have an API test written https://github.com/strues/boldr/blob/master/src/api/routes/auth/auth.test.js
The server I wrap with supertest is simply const server = http.createServer(app);
Jest config
  "jest": {
    "moduleNameMapper": {
      "^.+\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$": "<rootDir>/tools/test/styleMock.js",
      "^.+\\.(css|scss)$": "<rootDir>/tools/test/styleMock.js"
    },
    "collectCoverage": true,
    "transform": {
      ".*": "<rootDir>/node_modules/babel-jest"
    },
    "testPathDirs": [
      "<rootDir>/src/cms",
      "<rootDir>/src/api"
    ],
    "setupFiles": [
      "<rootDir>/tools/test/setup.js"
    ],
    "testPathIgnorePatterns": [
      "<rootDir>/(tools|docs|node_modules|bin|flow-typed|public)/"
    ],
    "transformIgnorePatterns": [
      "/node_modules/"
    ],
    "coverageReporters": [
      "lcov",
      "text",
      "text-summary"
    ]
  }

Let me know if that helps you out at all.

@strues Thank you. I see that you have a standalone server for the API which would make things a lot easier.  I may need to create a test server that just loads the API as I can't see a reasonable work around.


Exclude not implemented templates for workspace / theme

Please remember that the <excluded> tag from the XSD for the webspace configurations have to be removed as well. But be aware that this will be a BC-Break.

Just had a thought about that, and I am not sure how this should work when we have the theme on the portal. This would mean that we are only allowed to show the templates in the UI which are implemented in all the themes in this webspace, or am I missing something?


RuntimeError: SWIG std::function invocation failed

Environment:
OR-Tools version: 7.3.7083
OS: Mac OSX
Python version: 2.7.16
Traceback (most recent call last):
File "cvrp.py", line 101, in
main(data)
File "cvrp.py", line 97, in main
print_solution(data, manager, routing, assignment)
File "cvrp.py", line 23, in print_solution
plan_output = 'Route for vehicle {}:\n'.format(vehicle_id)
RuntimeError: SWIG std::function invocation failed.
I am getting RuntimeError while running the capacitated vehicle routing problem (CVRP). I have attached my code. Can someone please help me with this. Thanks in advance.
cvrp.py.zip

It works perfectly on master.
Please note that 7.3 is the last release that supports python 2.7.
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le ven. 4 oct. 2019 à 04:24, Chirag Bhatia<EMAIL_ADDRESS>a
écrit :

Environment:
OR-Tools version: 7.3.7083
OS: Mac OSX
Python version: 2.7.16
Traceback (most recent call last):
File "cvrp.py", line 101, in
main(data)
File "cvrp.py", line 97, in main
print_solution(data, manager, routing, assignment)
File "cvrp.py", line 23, in print_solution
plan_output = 'Route for vehicle {}:\n'.format(vehicle_id)
RuntimeError: SWIG std::function invocation failed.
I am getting RuntimeError while running the capacitated vehicle routing
problem (CVRP). I have attached my code. Can someone please help me with
this. Thanks in advance.
cvrp.py.zip https://github.com/google/or-tools/files/3689623/cvrp.py.zip
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/1620?email_source=notifications&email_token=ACUPL3OUX7PJ5FAH2E5AL4DQM34TDA5CNFSM4I5MYH4KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HPTRG4Q,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUPL3PBMBFN7TH3G7EBCCLQM34TDANCNFSM4I5MYH4A
.


Updating docker image checks to make sure JMX image available and used for pipelines

What does this PR do?
Added a check to make sure JMX image of the Agent is deployed by adding a new function called InternalRegistryFullImagePathExists that allows me to use a computed Docker image path. This means that tests that don't care about the JMX image won't have to rely on that job in the gitlab pipeline and we check the the image for the given test.
Also added a check on ECR to make sure we don't check for none ECR images + a unit test for parsing Docker image tags.
Which scenarios this will impact?
Docker end to end test.
Motivation
To run e2e tests for JMXFetch we need the Docker image with Java published.
Additional Notes
This PR will break main on the Agent if merged before the update the gitlab ci definitions that publish the JMX docker image for QA. It needs the PR here to be merged first.

/merge

/merge

/merge


Support single version projects

This should probably be hitting our API to get an unresolved URL for the project, but for now, an option that is single_version or similar would be good. It's breaking the links in the WTD builds because we have a single_version there.

We hit this again on site-community. Probably worth adding to a sprint.


Touching up make_future

add overloads for shared_future
make sure make_future<T>(future<T>) does not create ambiguities
import make_future into namespace hpx
adding test
flyby change: import make_future_void into namespace hpx

@sithhell Your comments have been addressed.

LGTM!


Player frame positioning issue

We are setting the player view in a custom presented modal view controller which is 100% width and about 1.9 aspect ratio to the height of the screen.. There are blank spaces above and below the video -- good.
When we present the player, the player goes outside the view controller it's presented on, and gets cut off on the top of the screen.
My question is how can i reposition the player so that it fits in my view controller and doesnt go outside the VC?

I was able to add the player into a container view which helped solve my problem. The only issue is that the player still tries to become full screen on top and bottom of view


raspi-Release 1.24

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change

Further Comments

Codecov Report
Base: 9.72% // Head: 9.72% // No change to project coverage :thumbsup:

Coverage data is based on head (fb823c8) compared to base (79bb7bc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6150   +/-   ##
======================================
  Coverage    9.72%   9.72%
======================================
  Files         138     138
  Lines       10060   10060
======================================
  Hits          978     978
  Misses       8883    8883
  Partials      199     199

Flag
Coverage Δ

unittests
9.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cli/cmds/log_linux.go
0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Sorry, not sure what the intent is here, but this isn't something we want to do.

how can you be sure this is not smth you like, if you do not get the intent_-?
but i love the meme xD
just working on making a bunch of random linux boards compute models for me. greenhorn obvs


Default methods section is not explanatory

The example does not have any meaningful utility.
The Java tutorial explanation at https://docs.oracle.com/javase/tutorial/java/IandI/defaultmethods.html is much better:

Default methods enable you to add new functionality to the interfaces of your libraries and ensure binary compatibility with code written for older versions of those interfaces.

I respect your point of view and invite you and everyone else to read the official java language documentation, if you can spend the time. The main purpose of my guide is to provide a quick example-driven overview of the new language and api features in Java 8 without covering every feature in full length.
I close this issue since you doesn't provide meaningful improvement suggestions. However I gladly review any pull request for improvements to my guide.