Programmatic access to Assignability rules

Some of the important algorithms outlined in pseudo-code in the spec are already available to developers of extensions, e.g. BeanManager#resolve, BeanManager#resolveDecorators and BeanManager#resolveObserverMethods. However, underlying those are other algorithms which are currently not made available to the programmer without depending on specific vendors, the type assignability rules. It is of course possible to implement the algorithms by hand when needed, the spec is clear enough to do that, but the rules are subtle enough that this is error prone and not completely trivial.
Specific use case that I have in mind: I'd like to add to the CDI container's event mechanism by also delivering events to consumers which can be registered and unregistered at runtime. In order to be consistent, I'd like the consumers to conform to the same strict type rules that observer methods have. Unfortunately, there is no quick and simple way to apply these rules except for diving into Weld's source code and stealing what I need hoping that I don't inadvertently break some subtle edge case in the process.

For the time being, I'd suggest grabbing resolution rules from an impl that fits your case (runtime/build time) as the feature you are implementing will be only in that space anyway. Those rules are pretty stable and don't change much so your code is highly likely to run fine even after updates. I don't think exposing those rules publicly makes a lot of sense plus I am not even sure it is doable due to aforementioned differences.
The only other thing I can think of would be exposing the algorithm via BeanContainer/BeanManger methods - i.e. a method that accepts two Type objects and returns true if assignable. That's certainly doable but there are different rules for events/observers, classic injection and delegate inject point if memory serves. Therefore, we should expose all three ways (either 3 methods, of one with enum param that picks the ruleset you want). Though I am not sure it is worth it since I cannot imagine use cases for it.
WDYT @Ladicek?

Personally, I wouldn't expose the assignability rules directly, as that's too low-level. What might be interesting is to expose the resolution algorithm in a more fine-grained manner. For example, BeanContainer currently exposes
<T> Set<ObserverMethod<? super T>> resolveObserverMethods(T event, Annotation... qualifiers);

which doesn't let you plug your own "observer method". We could add something like this:
<T> boolean isMatchingObserverMethod(T event, Annotation... qualifiers, ObserverMethod<? super T> observerMethod);

This method would apply the observer resolution rules to given observerMethod (probably not all of them, would require more thinking) and whether the observerMethod should be notified of given event.
We could expose something similar for bean resolution, too.

Personally, I wouldn't expose the assignability rules directly, as that's too low-level.

For the scenario presented here, the annotation comparison is trivial, so it boils down to type assignability.
I agree that we could do that in some form with annotations as well however that also requires users to know how things like @Any and @All works but I assume whoever uses this will probably know.

This method would apply the observer resolution rules to given observerMethod

Passing around whole OM might be tricky and IMO it would be simpler to do that with type and qualifiers only.
Ok, let's keep this in the CDI.next tracker and see what we can come up with.

I used ObserverMethod in the proposal sketch above with a bit of hesitation, as indeed it contains way more information than necessary. If the method only accepted Type, Annotation[], Type, Annotation[], that would of course be simpler and more straightforward, but I always find this kind of methods a bit hard to follow.
A slight variation on the sketch above would be:
public interface ObserverMethodData { // bad name, anyone has a better one?
    Type type();
    Annotation[] qualifiers();
}

...
Set<ObserverMethodData> resolveObservers(Set<ObserverMethodData> candidates, Type eventType, Annotation... qualifiers);
...

Where resolveObservers would run through candidates and only return those that match given event type and qualifiers, according to the rules of observer resolution.

@Ladicek I don't think this meets the requirements of the scenario @JHahnHRO drafted.

Specific use case that I have in mind: I'd like to add to the CDI container's event mechanism by also delivering events to consumers which can be registered and unregistered at runtime. In order to be consistent, I'd like the consumers to conform to the same strict type rules that observer methods have.

In such case, you won't necessarily have ObserverMethod instance for given observer which is why I wanted to go with just Type and annotations. OP doesn't ask for annotations either, but I think that would be handy anyway and in CDI it always goes together.

I believe the original use case still requires the knowledge of event types and perhaps qualifiers, and implementing the ObserverMethod interface where most methods throw UnsupportedOperationException is pretty straightforward :-) At least that's what I had in mind when sketching the API above.

Hmm, I see.
But I still think it might be easier to just skip that OM part. It is not that low level either since spec has all these rules laid out fairly plainly for everyone. Alright, either way would work I guess.
As a side note, if we chose to expose these rules, we should IMO do that for beans and events but not for delegate injection points. At least not initially as I cannot imagine anyone trying to extend decorator's delegate IP somehow so it sounds like an overkill for now.

Sure. We can either add an interface, as I mentioned above, or just accept types and annotations.
Agree about the delegate injection points, that can't be practically useful.


refactoring java instance to use pull model for message ingress

Motivation
To simplify the processing model for functions.
Prepare to be able to support running connectors on pulsar functions

@sijie @srkukarni please review


C4

adds c4 certification. filtering tests with child cat1 filter task and cat3 filter task are generated on product creation. filter test status is shown on product show page in main product status display and on CQM Filtering tab. added selection of measure for c4 filtering tests. added associated model, helper, and integration tests

Can you provide screenshots for the visual changes from this pull request?

Don't merge yet. I think we still need a change from @jaebird123

Just needs a rebase from someone. Might be easier to do if you squash this first.

Also has merge conflicts which will have to get resolved in the rebase.


debugging: issues with webpack resolver

While my webpack config works just fine, I am getting a lot of linter errors with the same config:
  resolve: {
    extensions: ["", ".js", ".jsx"],
    modulesDirectories: [
      VENDOR_DIR,
      SRC_DIR,
      path.join(__dirname, "node_modules"),
    ],
    alias: {
      vendor: VENDOR_DIR,
    },
  },

eslint prints erros for each of my files:
   1:19  error  Unable to resolve path to module 'react'                    import/no-unresolved
   2:24  error  Unable to resolve path to module 'inline-style-prefix-all'  import/no-unresolved
   7:18  error  Unable to resolve path to module 'components/Link'          import/no-unresolved
   8:30  error  Unable to resolve path to module 'styles/colors'            import/no-unresolved
  10:21  error  Unable to resolve path to module 'components/Divider'       import/no-unresolved
  11:17  error  Unable to resolve path to module 'components/Div'           import/no-unresolved

my .eslintrc looks like this:
settings:
  react:
    version: "0.14.8"
  import/resolver:
    webpack:
      config: "webpack.config.js"

But also import/resolver: webpack reports the same errors

What version of Webpack + Webpack resolver are you using?
And where are they installed relative to each other?

I am using
webpack 1.13.1
eslint-import-resolver-webpack 0.2.4
eslint 2.3.0
They are all installed in my apps node_modules folder, not globally.

That is a fairly old version of the Webpack resolver. Can you try with v0.5.1?

I have upgraded to 0.5.1 and it works from npm test now. I can verify its loading my webpack config since I do console output in it.
However it does not run well when used as preloader
module: {
    preLoaders: [
      {
        test: /\.jsx?$/,
        loader: "eslint",
        exclude: /node_modules/,
      },
    ],

Ah, yes. eslint-loader has some known issues when running Webpack in watch mode. There is a create-react-app issue open to improve some of the dependency relationships between linted files that result from using certain rules from this plugin, which eslint-loader does not currently understand. (which is appropriate, most lint rules only depend on the linted file)
Does this capture what you mean by

does not run well when used as preLoader

?
And could you elaborate on

also not in Atom

?

Hmm ok. So I guess I'd have to disable linting in preloader for now then?
In atom I get all the same entries underlined like the preloader dumps to the console.

I'm not sure what the problem is. how are VENDOR_DIR and SRC_DIR defined?

const VENDOR_DIR = path.join(__dirname, "products", process.env.APP_VENDOR)
const VENDOR_SRC_DIR = path.join(VENDOR_DIR, "src")
const DEFAULT_DIR = path.join(__dirname, "products", "default")

...

modulesDirectories: [
     VENDOR_DIR,
     DEFAULT_DIR,
     VENDOR_SRC_DIR,
     SRC_DIR,
     "node_modules",
 ],

FYI: https://github.com/AtomLinter/linter-eslint/issues/610 is the issue in the atom eslint plugin.  I'm about to start using webpack on my project, so I might have a lot of motivation real soon to look into the problem.  :)

aha! Very good, a little motivation is always good:)

Eat your own dogfood(tm)

I'm not sure if this is the same issue a mine, but if I use this webpack config entry
resolve: {
   modulesDirectories: ['node_modules', './src'],
 },

and this linter config
import/extensions:
    - error
    - always
    -
      js: never

and trying to import something like
import {mapToSearchParams} from 'tools/http';
OR
import {mapToSearchParams} from 'tools/http.js';
I'm getting an error in BOTH cases. http.js is located in src/tools/http.js. Is this related or I should create another ticket?

P.S. Screenshots are from Atom, but issue remains in CLI run.

@tommiv looks like a different (and especially weird) issue. I'd open a new issue if it's still present on v2.2.0 w/ webpack resolver 0.7.0?

No longer using webpack. No longer care about this bug ;)


Remove cookie “io” since it's not being used.

According to the latest Chrome update, a cookie with SameSite=None requires a secure attribute, or else it will be rejected.
Reference
https://www.chromestatus.com/feature/5633521622188032
Solution
And according to this issue on socket.io, the cookie "io" is not being used and can be removed.
Screenshots

I am not super familiar with socket.io and it's implication of using cookie. If this fall into your domain expertise, I would greatly appreciate a PR

Working on it @xinbenlv

While you are at it, i noticed you are also a graphic designer, if you are interested, we need design contributions too, as you can see the visual and UX is not my domain expertise. :)

Not an expert but would love to give it a try @xinbenlv.


Issue154 upgrade smart contracts to provwasm 2.0.0

Migration guide: https://github.com/provenance-io/provwasm/blob/main/MIGRATION.md
There are a couple broken tests right now that are waiting on this discussion: https://discord.com/channels/897185242182484029/1115703566737342474/1128040123989242008

@EasyEtHP4 / @kherzinger-figure FYI - relevant while you are still on the smart contract


Drop frames if more than MAX_SIF_COUNT consecutive SIFs come in

based on #812

good points!
I would hold off with an event until we can be sure that we're not triggering any false positives. I think at this stage a warning log and dropping the frames seem sufficient, but agree that an event would eventually be nice.


Autocomplete messes up spans

Using autocomplete seems to place the span for replacement wrong, where the last character entered before pressing enter will be put before the completion. undoing the complete makes the wrong selection

https://github.com/Ryex/ic10emu/assets/1502855/801685ea-92d7-447e-8c23-efc19650b23e
I've reproduced this in FF and Edge

I believe this is an error with ace-linters
I have console logs sitting between the server and client so I can see that the completion suggestions are sent correctly

so It knows to start from character 15.
but it could also be an error all they way up in Ace itself.

fixed in d9a8a9f


charmc option "-ld" to specify linker conflicts with passing "-ld" to link libd.so

Original issue: https://charm.cs.illinois.edu/redmine/issues/1812

Any program that uses dlopen() will need to link with libd.so by passing -ld to the linker. However, charmc has options "-ld" and "-ld++" for overriding $CMK_LD and $CMK_LDXX respectively.
I can only recommend removing charmc's -ld and -ld++ options, or renaming them to something else. Maybe -override-ld and -override-ld++.

Original date: 2018-02-22 16:31:54

~~https://charm.cs.illinois.edu/gerrit/3761~~ https://github.com/UIUC-PPL/charm/commit/9cedd1006894b69c19b2be7a7561d0b95e7a9274

Original author: Jim Phillips (@jcphill)
Original date: 2018-02-22 22:16:28

I think you can do this with "-ld++-option -ld".

Original author: Jim Phillips (@jcphill)
Original date: 2018-02-22 22:22:19

Also, don't you need to link with libdl, not libd?


compile on save after restart unchecked

Hi,
normally i have the "compile on save" flag always on, but i recognized that the flag ist unchecked sometimes.
sometimes it happens when i restart atom, sometimes it happens when i switch project? At the moment i can't really say why and when this happens.
does anyone of you also have the same issue?
thanks

Hey! I never heared about such an issue. Can you check your keymap if another package uses the same shortcut for sass-autocompile:toggle-compile-on-save command?
Therefore you can use Ctrl+. (yes, the dot ;) ) to display the Key Binding Resolver and then press Ctrl-Alt-Shift-S (or on a Mac Ctrl-Cmd-Shift-S) for toggling Compile on Save option. You should one or two enitres like in the screenshot:

If everything is fine here, do you use any software for synchronization? Or any package that works on your Atoms settings?

Hi Armin, thanks i checked the Key Binding Resolver (great tool by the way).
I also have the two lines so it looks ok for me.
hmm what i use is the project manager (https://atom.io/packages/project-manager).
here is a complete list, but i think there is no very special package
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├── atom-ternjs
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>thanks a lot for the quick answer 👍

That are a lot of packages ;) Today I will not be able to test that behaviour, perhaps tomorrow!
How often should I restart Atom or change the project? What do you estimate?


Update Logo - Manual Merge Request PR#18896

I'm submitting a ...
[ ] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

Link to my PR: https://github.com/solana-labs/token-list/pull/18896/
Thanks for your support!

the PR seems to have been closed already


Can't execute "hetzner-k3s create --config cluster_config.yaml" - error Unhandled exception: SSL_CTX_new: error: [...] (OpenSSL::Error)

I Installed all required packages ("sudo dnf install libssh2 libevent libyaml pcre gmp gc-devel"), created a cluster_config.yaml and executed "hetzner-k3s create --config cluster_config.yaml".
I got the following error:

Validating configuration...Unhandled exception: SSL_CTX_new: error:030000A9:digital envelope routines::unknown option (OpenSSL::Error)
from /usr/lib/crystal/core/openssl/ssl/context.cr:304:11 in 'new'
from /usr/lib/crystal/core/http/client.cr:136:5 in 'new_http_client'
from /home/runner/work/hetzner-k3s/hetzner-k3s/lib/crest/src/crest/request.cr:135:7 in 'available_releases'
from /home/runner/work/hetzner-k3s/hetzner-k3s/src/configuration/settings/k3s_version.cr:9:15 in 'validate'
from /usr/lib/crystal/core/gc/boehm.cr:132:5 in 'run:parent:program_name'
from /home/runner/work/hetzner-k3s/hetzner-k3s/src/hetzner-k3s.cr:10:3 in 'parse_and_run'
from /home/runner/work/hetzner-k3s/hetzner-k3s/src/hetzner-k3s.cr:96:1 in '__crystal_main'
from /usr/lib/crystal/core/crystal/main.cr:115:5 in 'main'
from src/env/__libc_start_main.c:95:2 in 'libc_start_main_stage2'

Can you please help me?

I'm sorry for the lack of replies. I was sick and then very busy with the day job. Did you figure out what was the problem in the end?

Nö, I have not tried again.
I switched from Fedora to Ubuntu lately and will try again...

@Linutux @rsidhaarth I have upgraded the SSH2 shard in main, can you try again? I haven't released this change yet as I want to merge other changes first.

I had the same error on Fedora 40.
When I built the app from the source code from the main branch, the error is no longer there.
I haven't found a description about the steps required to build the app locally, so I'll paste it here, hope you don't mind.
# from the crystal documentation: https://github.com/crystal-lang/crystal/wiki/All-required-libraries#fedora
sudo dnf -y install \
  gcc \
  gcc-c++ \
  gmp-devel \
  libbsd-devel \
  libevent-devel \
  libxml2-devel \
  libyaml-devel \
  llvm-devel \
  llvm-static \
  libstdc++-static \
  make \
  openssl-devel \
  pcre2-devel \
  redhat-rpm-config

# Needed this to overcome an error message
sudo dnf install libssh2-devel

# install crystal
sudo snap install crystal --classic

# install dependencies
shards install --without-development

# build the app
crystal build src/hetzner-k3s.cr

Hi @konczdam , thanks for confirming that the problem is fixed in main! I am still working on finalising v2.0.0, which will include this together with a lot of other stuff.

Had the same error on my fedora.
@vitobotta supplied a Dockerfile.dev in the repo, which allows to build w/o spamming the laptop. See repo README for vscode hipsters.
Here the old fart way:

podman/docker build Dockerfile.dev -t hk3  (I had to comment out the line with the stern lib, for go incompat)
copy the image id from the output, docker run it and get the container id from docker ps -a
mkdir ../fs && cd $_ && docker/podman export <that container id> | tar xfv -
rmdir home/app/hetzner-k3s && mv ../hetzner-k3s home/app/
sudo systemd-nspawn -D .
Inside: cd /home/app/hetzner-k3s/ && crystal build ./src/hetzner-k3s.cr --verbose --static

the first time before build you have to do a shards init or so, crystal build will tell you.
You can do the build clearly also within the container, with the volume mounted repo but that's the way if you like to have things persistent and tend to clear your docker spam from time to time from the laptop ;-)

Closing this since the problem should now be solved in v2, which I will release probably next weekend.

Running 2.0.4 on Fedora 40 is still producing the same error.

Fedora 40
OpenSSL 3.2.2
Linux 6.10.6-200.fc40.x86_64 #1 SMP PREEMPT_DYNAMIC Mon Aug 19 14:09:30 UTC 2024 x86_64 GNU/Linux

I checked out master, ran crystal shards update crest and then ran crystal src/hetzner-k3s.cr --config /path/to/config.yml and it completed successfully.
diff --git a/shard.lock b/shard.lock
index 87cf9f1..0f02d3e 100644
--- a/shard.lock
+++ b/shard.lock
@@ -6,7 +6,7 @@ shards:

   crest:
     git: https://github.com/mamantoha/crest.git
-    version: 1.3.13
+    version: 1.4.1

   crinja:
     git: https://github.com/straight-shoota/crinja.git
@@ -26,7 +26,7 @@ shards:

   http_proxy:
     git: https://github.com/mamantoha/http_proxy.git
-    version: 0.10.3
+    version: 0.12.0

   ipaddress:
     git: https://github.com/sija/ipaddress.cr.git

I'll raise a pull request with the fixed version.


[Vulnerabilities]Dependabot alerts: Wasmtime may have data leakage between instances

Please see:
Wasmtime may have data leakage between instances in the pooling allocator
Blocked by https://github.com/paritytech/substrate/issues/12986

Will be fixed in #1332

Fixed by https://github.com/LibertyDSNP/frequency/pull/1590


Canvas text is wider than the maxcol specified

I get this when monitoring on heavy load.
Traceback (most recent call last):
  File "/home/mibe/sandbox/mikethebeer/crate-top/.venv/bin/cstat", line 9, in <module>
    load_entry_point('cstat', 'console_scripts', 'cstat')()
  File "/mnt/d/sandbox/mikethebeer/crate-top/cstat/command.py", line 153, in main
    stat.main()
  File "/mnt/d/sandbox/mikethebeer/crate-top/cstat/command.py", line 80, in main
    self.loop.run()
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/main_loop.py", line 278, in run
    self._run()
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/main_loop.py", line 376, in _run
    self.event_loop.run()
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/main_loop.py", line 682, in run
    self._loop()
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/main_loop.py", line 710, in _loop
    self._entering_idle()
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/main_loop.py", line 671, in _entering_idle
    callback()
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/main_loop.py", line 564, in entering_idle
    self.draw_screen()
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/main_loop.py", line 578, in draw_screen
    canvas = self._topmost_widget.render(self.screen_size, focus=True)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/widget.py", line 1750, in render
    canv = get_delegate(self).render(size, focus=focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/container.py", line 1083, in render
    focus and self.focus_part == 'body')
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/decoration.py", line 816, in render
    canv = self._original_widget.render((maxcol,), focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/container.py", line 1520, in render
    canv = w.render((maxcol,), focus=focus and item_focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/widget.py", line 1750, in render
    canv = get_delegate(self).render(size, focus=focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/widget.py", line 1750, in render
    canv = get_delegate(self).render(size, focus=focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/decoration.py", line 225, in render
    canv = self._original_widget.render(size, focus=focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/container.py", line 1520, in render
    canv = w.render((maxcol,), focus=focus and item_focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/container.py", line 2085, in render
    focus = focus and self.focus_position == i)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/container.py", line 1520, in render
    canv = w.render((maxcol,), focus=focus and item_focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/widget.py", line 1750, in render
    canv = get_delegate(self).render(size, focus=focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/container.py", line 1520, in render
    canv = w.render((maxcol,), focus=focus and item_focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/container.py", line 2085, in render
    focus = focus and self.focus_position == i)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/container.py", line 1520, in render
    canv = w.render((maxcol,), focus=focus and item_focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/mnt/d/sandbox/mikethebeer/crate-top/cstat/widgets.py", line 84, in render
    maxcol=maxcol)
  File "/mnt/d/sandbox/mikethebeer/crate-top/.venv/lib/python3.5/site-packages/urwid/canvas.py", line 356, in __init__
    raise CanvasError("Canvas text is wider than the maxcol specified \n%r\n%r\n%r"%(maxcol,widths,text))
urwid.canvas.CanvasError: Canvas text is wider than the maxcol specified
104
[105]
[b'          [|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||101.0%]']

Not entirely sure why CrateDB returns 101 %, maybe this should be fixed there - Could be a problem with the Sigar plugin.

@chaudum sry. this is the same as https://github.com/chaudum/crate-top/issues/7


macOS Sierra installation instructions

Hi!
Amazing tool, been waiting for this for years!
I am running Thyme on macOS Sierra following these steps:

Set GOPATH: export GOPATH=/Users/user/go
go get -u github.com/sourcegraph/thyme/cmd/thyme
cd GOPATH/bin
while true; do ./thyme track -o thyme.json; sleep 30s; done;

For some reason I can't execute thyme anywhere, also, I can't run ./thyme dep because brew install watch is not yet compatible with macOS Sierra

You probably have not added $GOPATH/bin to your PATH.
See https://golang.org/doc/code.html#GOPATH

You don't need watch installed.
Try just downloading the binary directly from here: https://github.com/sourcegraph/thyme/releases

Thanks!


Detect leaky use of time.Tick

https://golang.org/pkg/time/#Tick is appropriate in some cases, but will leak a goroutine as it doesn't provide a mechanism to close the routine. To prevent leaks, it's recommended to use https://golang.org/pkg/time/#NewTicker and close the ticker when no longer required.
As discussed, simply detecting the use time time.Tick will result in false positives, to help reduce them (and also create some false negatives):

Ignore the use of time.Tick in main packages (i.e. not libraries), as short running cli applications may not care about leaking goroutines
Ignore functions that call time.Tick and never return, to prevent valid use of infinite loops such as a for { select { case <-tick: } } block.

Ignore the use of time.Tick in libraries (non-main packages), as short running cli applications may not care about leaking goroutines

Surely you mean ignore them only in main packages? If we ignore them in libraries, there won't be much left to flag, and all the ones in main are probably false positives.

Yes, edited, thanks.

Update: I have this implemented locally, but it's blocking on some other yet unpushed changes.


[BUG]: PlanetScale error when using (now() + interval 14 day) as default

What version of drizzle-orm are you using?
0.26.0
What version of drizzle-kit are you using?
0.18.0
Describe the Bug
Using MySQL + PlanetScale and (now() + interval 14 day) as the default returns an unexpected error.
export const User = mysqlTable('User', {
    trialExpiresAt: datetime('trialExpiresAt', { fsp: 3 }).notNull().default(sql`(now() + interval 14 day)`),
}

Running drizzle-kit push:mysql on the above schema will return the following PlanetScale error (shortened):
Error: Invalid default value for 'trialExpiresAt'.

Expected behavior
The expected behaviour is the same as running the below code:
await db.execute(
  sql.raw(`ALTER TABLE User CHANGE \`trialExpiresAt\` \`trialExpiresAt\` datetime(3) NOT NULL DEFAULT (now() + interval 14 day);`)
);

In that case, everything is working as expected and there are no errors returned from PlanetScale.
Environment & setup
No response

This is probably a duplicate of https://github.com/drizzle-team/drizzle-orm/issues/472. If you change it to now(3) + interval 14 day does it fix your problem?

If you change it to now(3) + interval 14 day does it fix your problem?

Still the same issue, however removing the fsp option and using (now() + interval 14 day) works.

I don't think this is a drizzle issue. If you define a custom default you should verify if it's supported in planetscale.
You might need to try:
...
trialExpiresAt: datetime('trialExpiresAt', { fsp: 3 }).notNull().default(sql`(current_timestamp(3) + interval 14 day)`)
...

I'll close this issue but please feel free to re-open if you have more issues.


allow empty batch data

Description
This fix handles the edge case of flattening a batch of zero size. It is a good  quality metric for a software function to be able to handle zero data input even if the calling function could detect this case and create a fake expected output (that was my work-around before).
Before this fix, this exception would have been thrown:
Caused by: ai.djl.engine.EngineException: cannot reshape tensor of 0 elements into shape [0, -1] because the unspecified dimension size -1 can be any value and is ambiguous
at ai.djl.pytorch.jni.PyTorchLibrary.torchReshape(Native Method)

The change looks good @patins1, but it seems like you are failing the formatter check. Can you run ./gradlew formatJava (see docs)?

Codecov Report

Merging #1569 (a652145) into master (bb5073f) will decrease coverage by 1.25%.
The diff coverage is 52.95%.

@@             Coverage Diff              @@
##             master    #1569      +/-   ##
============================================
- Coverage     72.08%   70.83%   -1.26%
- Complexity     5126     5394     +268
============================================
  Files           473      503      +30
  Lines         21970    23579    +1609
  Branches       2351     2561     +210
============================================
+ Hits          15838    16703     +865
- Misses         4925     5597     +672
- Partials       1207     1279      +72

Impacted Files
Coverage Δ

api/src/main/java/ai/djl/modality/cv/Image.java
69.23% <ø> (-4.11%)
:arrow_down:

...i/djl/modality/cv/translator/BigGANTranslator.java
21.42% <ø> (-5.24%)
:arrow_down:

...odality/cv/translator/BigGANTranslatorFactory.java
33.33% <0.00%> (+8.33%)
:arrow_up:

...nslator/InstanceSegmentationTranslatorFactory.java
14.28% <0.00%> (-3.90%)
:arrow_down:

.../modality/cv/translator/YoloTranslatorFactory.java
8.33% <0.00%> (-1.67%)
:arrow_down:

...i/djl/modality/cv/translator/YoloV5Translator.java
5.69% <0.00%> (ø)

...odality/cv/translator/YoloV5TranslatorFactory.java
8.33% <0.00%> (-1.67%)
:arrow_down:

...pi/src/main/java/ai/djl/ndarray/BytesSupplier.java
54.54% <0.00%> (-12.13%)
:arrow_down:

...ain/java/ai/djl/ndarray/index/dim/NDIndexPick.java
100.00% <ø> (ø)

api/src/main/java/ai/djl/nn/Blocks.java
75.00% <0.00%> (-25.00%)
:arrow_down:

... and 230 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad72072...a652145. Read the comment docs.


Port home-grown test framework to Busted

@Tieske, @hishamhm —
How would you guys feel about it if I were to port all the current tests from the current in-project test runner to Busted? This would not add a runtime dependency, but it would be an extra build / test / developer dependency.
The issues I have with the current system are that...

output is pretty inconsistent. Busted can be run with several modes with output suitable for remote CI jobs, local debugging, quick live checks while coding, etc.
the runner dies of first failure. Busted isolates tests in such a way that one can fail and you still get results from all the tests. This makes it a lot easier to get a feel for the scope of whatever you broke.
expected failure conditions are not too easy to test. Yes a number of the tests use manual pcall() wrappers, but Busted's expectations for error messages and various conditions are quite a bit more robust.
testing complex output isn't easy. Partly because table iteration order is non-deterministic in Lua and also for other reasons, more complex tests are cumbersome to write from scratch. Busted has some utilities that ease this pain.
the runner is single threaded. It's doesn't take that long but test results would be more than $(nproc)× faster if it was easier to run them in parallel. The current framework makes that tricky. Busted doesn't have this built in (yet) either, but the different output options make it much easier to execute from something that does support job control (GNU parallel, GNU Make's test harnesses, etc.)

I make no promise to get around to this right away as it would take a bit of doing, but I thought I'd ask whether such a thing would be acceptable before I get started.

How would you guys feel about it if I were to port all the current tests from the current in-project test runner to Busted? This would not add a runtime dependency, but it would be an extra build / test / developer dependency.

I've had this thought many times, but lacked the time. So fwiw please go ahead

the runner is single threaded. It's doesn't take that long but test results would be more than $(nproc)× faster if it was easier to run them in parallel. The current framework makes that tricky. Busted doesn't have this built in (yet) either, but the different output options make it much easier to execute from something that does support job control (GNU parallel, GNU Make's test harnesses, etc.)

that's over-engineering imho, but doesn't hurt either

I think we can close this now? the whole thing will be a work in progress for a while

Yes. The basics are in place and all new tests should be in Busted. Legacy ones can continue to be ported as we get a chance to refactor them.


Proposal: Enhance settings for namespace mode installation

Summary

Deprecate namespace setting in configmap
Add optional --namespace-mode in workflow-controller start args
Add optional --namespace in workflow-controller start args to support specifying a namespace for workflow-controller to listen to

Motivation
For most of the cases of namespace mode installation, it's redundant to set up the namespace in the configmap, unless people want to make workflow-controller to listen to a different namespace.
It also make it possible to run workflow-controller on the local to test namespace only mode without configmap dependency.
Proposal

#1939 Merged


Remove unnecessary locks

Motivation
There are many unnecessary locks in MultiTopicsConsumerImpl, which affect performance.
BlockingQueue is inherently thread-safe, and there is no need to lock in many places.
Modifications
Remove unnecessary locks
Verifying this change
Use the perf tool, 3 * 8-core 16G nodes,recording time is about 2 minutes
before removing：
Aggregated throughput stats --- 11715556 records received --- 68813.420 msg/s --- 537.605 Mbit/s
after removing：
Aggregated throughput stats --- 25062077 records received --- 161656.814 msg/s --- 1262.944 Mbit/s

/pulsarbot run-failure-checks

@315157973 Can you provide the exact setup on reproducing the perf test results?

Prepare a 3-node pulsar cluster and produce some data
Use pulsar-perf on another machine,
bin/pulsar-perf consume -u'http://x.x.x.x:8080' -s my-sub-6 -sp Earliest -q 100000 persistent://public/default/p-topic
Pressure test twice, the first time with the original one, and the second time to replace the pulsar-client-original.jar in the lib folder

record.zip

/pulsarbot run-failure-checks

Prepare a 3-node pulsar cluster and produce some data（topic with 4 partitions）
Use pulsar-perf on another machine,
bin/pulsar-perf consume -u 'http://x.x.x.x:8080' -s my-sub-6 -sp Earliest -q 100000 persistent://public/default/p-topic
Pressure test twice, the first time with the original one, and the second time to replace the pulsar-client-original.jar in the lib folder

record.zip

Added this into the description

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


How to search selection only in the profile currently active?

For example I have a profile active that searches through Go and some specified go libraries like so :

Can you please add action that will search selection only in the currently active profile?
Thank you.

Hi @nikitavoloboev
Interesting. I will have a look at this.

@nikitavoloboev I threw a question about this one too to Dash developer. Seems like there is no support for this from them literally.

Duplicate with https://github.com/deerawan/vscode-dash/issues/44


Enable JDK 17 client matrix builds

This issue will track the progress in the individual repositories.

Should include Java LTS versions, i.e., 11 and 17. Needs to be done for Amphora, Castor, and Ephemeral clients.


Yaml: status codes are converted as integers

When writing status codes in yaml as:
reponses:
   200:
     description: OK

They are internally converted to integers and json_schema trips over them here. In addition this isn't caught and so the default TypeError: expected string or bytes-like object tells you nothing.
The same schema converted to Json by ApiMatic converts status codes to strings and so the work around is to quote the response codes in your yaml file.

@mes3yd
This is openapi-spec-validator related bug
https://github.com/p1c2u/openapi-spec-validator/pull/30
and should be fixed in openapi-spec-validator version 0.2.2 . Check you have latest version.

I have 0.2.2 - but am passing the pyyaml dict to create_spec, as per README.md. So, not using the safe loader from openapi_spec_validator.
In short, I'm doing:
import yaml
import json

stream = open(path, 'rt', encoding='utf-8')
fname, ext = os.path.splitext(path)
if ext in ('.yaml', '.yml'):
    spec_dict = yaml.load(stream)
else:
    spec_dict = json.load(stream)

spec = create_spec(spec_dict)

Can you classify this as a documentation bug? Then I'll add this to the docs.

Any updates here? Because I have this problem too and didn't know how to resolve it

I suggest wrapping the string 200 with singlequotes.

You can use read_yaml_file from openapi_spec_validator.schemas instead of yaml.load. Works for me.


Parameters against a path definition crashes the studio

If the Swagger definition has parameters defined against the path (not against the Verb) the studio crashes loading it.
These parameters are added to allow APIs to use the same endpoint for different formats (JSON, XML, csv) and there is an Azure bug in that it doesn't honour headers (https://github.com/Azure/autorest/issues/656)
So for now we have to pass in an Accept parameter, which is reflected in the generated document.
At the very least this should be ignored by the studio, but it currently crashes saying it can't find #/parameters/Accept which is clearly present.
An example valid swagger snippet that fails is:
{
    "swagger": "2.0",
    "info": {
        "title": "QuestEngage",
        "version": "1.0"
    },
    "host": "localhost:65000",
    "basePath": "/",
    "schemes": [
        "http"
    ],
    "consumes": [
        "application/json"
    ],
    "produces": [
        "application/json"
    ],
    "paths": {
        "/api/currentUser": {
            "get": {
                "tags": [
                    "api"
                ],
                "operationId": "GetCurrentUserDetailsRequestcurrentUser_Get",
                "consumes": [
                    "application/json"
                ],
                "produces": [
                    "application/json"
                ],
                "parameters": [],
                "responses": {
                    "200": {
                        "description": "Success",
                        "schema": {
                            "$ref": "#/definitions/GetCurrentUserDetailsResponse"
                        }
                    }
                },
                "deprecated": false
            },
            "parameters": [
                {
                    "$ref": "#/parameters/Accept"
                }
            ]
        },
        "/api/snippet/": {
            "put": {
                "tags": [
                    "api"
                ],
                "operationId": "SaveSnippetRequestsnippet_Create",
                "consumes": [
                    "application/json"
                ],
                "produces": [
                    "application/json"
                ],
                "parameters": [
                    {
                        "name": "Snippet",
                        "in": "query",
                        "type": "string"
                    },
                    {
                        "name": "body",
                        "in": "body",
                        "schema": {
                            "$ref": "#/definitions/SaveSnippetRequest"
                        }
                    }
                ],
                "responses": {
                    "200": {
                        "description": "Success",
                        "schema": {
                            "$ref": "#/definitions/SaveSnippetResponse"
                        }
                    }
                },
                "deprecated": false
            },
            "parameters": [
                {
                    "$ref": "#/parameters/Accept"
                }
            ]
        },
      :
      :
      :
    },
    "parameters": {
        "Accept": {
            "name": "Accept",
            "in": "header",
            "description": "Accept Header",
            "type": "string",
            "required": true,
            "enum": [
                "application/json"
            ]
        }
    },
    "securityDefinitions": {
        "basic": {
            "type": "basic"
        }
    },
    "tags": [
        {
            "name": "api"
        }
    ]
}

I think currently param refs are not implemented. But i think this is easy to do...

Will have a look at this soon

I think this is the fix: https://github.com/RSuter/NJsonSchema/commit/b272387d41a0ec5ef8290dd6a4fc6457dd4fe8e8

Please test with CI build artifacts: https://ci.appveyor.com/project/rsuter/nswag-25x6o/build/artifacts

Seems to work. No more errors!
Thanks for the speedy resolution!


Migrate to Swift Package Manager

Task/Issue URL: https://app.asana.com/0/1187352151074490/1187763920072074
Tech Design URL:
CC: @brindy
Description:
Change dependency management from Carthage to Swift Package Manager. This includes:

Removing Alamofire since it was no longer required, and using URLSessionDataTasks instead
Removing Device.swift since it doesn't currently support SPM and we don't really use it
Necessary updates to remaining dependancies to versions that support SPM. This includes API changes to Lottie and OHHTTPStubs

Steps to test this PR:

Test building the project works without Carthage, and that all tests pass
Test all network calls affected by the switch from Alamo fire, including manually testing the features work, and using Charles Proxy to test that the headers etc are unchanged/as expected. The features include:

[x] favicons
[x] autocomplete
[x] searches
[x] pixels
[x] HTTPS upgrading

Copy Testing:

[x] Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

[x] Portrait
[x] Landscape

Device Testing:

[x] iPhone SE (1st Gen)
[x] iPhone 8
[x] iPhone X
[x] iPad

OS Testing:

[x] iOS 11
[x] iOS 12
[x] iOS 13

Theme Testing:

[x] Light theme
[x] Dark theme

Internal references:
Software Engineering Expectations
Technical Design Template

@bwaresiak do you have time to give this a quick look and a smoke test, please?  It's looking good to me, but I just want your eagle eyes on it :) Thanks!


Installation fails

I just tried to install the dev version and I get the following error:
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for pattern-lab/starterkit-mustache-demo dev-dev -> satisfiable by pattern-lab/starterkit-mustache-demo[dev-dev].
    - pattern-lab/starterkit-mustache-demo dev-dev requires pattern-lab/core ~0.5 -> no matching package found.

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://groups.google.com/d/topic/composer-dev/_g3ASeIFlrc/discussion> for more details.

Read <http://getcomposer.org/doc/articles/troubleshooting.md> for further common problems.

@TxHawks -
Good catch. I've updated the dependencies on dev. Looks like a bad merge.

Still no go. I now get:
PHP Fatal error:  Call to undefined method Composer\Script\Event::getOperation() in /var/www/pl-demo/vendor/pattern-lab/core/src/PatternLab/InstallerUtil.php on line 559

Fatal error: Call to undefined method Composer\Script\Event::getOperation() in /var/www/pl-demo/vendor/pattern-lab/core/src/PatternLab/InstallerUtil.php on line 559

Me and a colleague are getting the same fatal errors in InstallerUtil.php on line 559.

Most likely this is an issue w/ Composer. Can you both share which version of Composer you're using? You can run composer -v to get that info.
There was an update that broke how certain events are handled but before I have you update I may want to try to make my code more backwards compatible. Thanks.

Composer version 1.0-dev (bc45d9185513575434021527d7756420e9f4b2cf) 2015-05-11 14:49:39

@dennisfrank -
Ugh. Ok, yours is newer than mine so... Fun ;)

@dmolsen That’s what I got with curl -sS https://getcomposer.org/installer | php
¯_(ツ)_/¯

1.0-dev here as well

Don't mean to just tack on to this thread in such a negative fashion... but I, too, am having that error running composer 1.0-dev.

@dmolsen -
I now get a different error message on both this edition and the Twig edition:
Script PatternLab\Installer::postPackageInstall handling the post-package-install event terminated with an exception

[UnexpectedValueException]
RecursiveDirectoryIterator::__construct(/home/txh/delme/new/pattern-lab/packages/pattern-lab/styleguidekit-assets-default/dist/fonts): failed to open dir: No such file or directory

Also, for the time being, Is there a way to install PL manually, sans composer?

@dmolsen -
Any update on this?
I've now tested this on Linux (Ubuntu), Mac and Windows machines, and get the same error.
Thanks

Quick and dirty fix for this issue:
run
composer create-project pattern-lab/edition-development your-project-name && cd $_ or
composer create-project pattern-lab/edition-development-twig your-project-name && cd $_ or
composer create-project pattern-lab/edition-twig-standard your-project-name && cd $_
as usual, which will fail as above.
Then, run composer install (From within your project dir). When prompted on whether to to merge or replace ./public/styleguide/bower_components, open another terminal window, and in your project directory, type mkdir packages/pattern-lab/styleguidekit-assets-default/dist/images packages/pattern-lab/styleguidekit-assets-default/dist/fonts.
After creating the directories, go back to the first terminal and complete the installation process.
Pattern Lab should now work

Not that this help anyone much but the Mustache edition is now installing cleanly for me. I made some tweaks to handle Mustache 2.9.0 as well as the latest edition of Composer. Feel free to chime in with further issues. Schedule has finally died down.

@dmolsen -
Thanks. Installation of dev editions are now okay again, but only on Linux and Mac. Windows installations still fail, so edition-php-twig-development#19 is still an issue.
Progress on edition-php-twig-development#15 would also be very helpful.


Passing index information to renderers

Hello! Thank you so much for creating and maintaining such an awesome library! 👏
I'd like to be able to conditionally apply some styles based on a node's index under its parent, e.g. to remove some top margin from the first element and the bottom margin from the last element. Basically enabling some of the stuff that in CSS-land we would have done with :first-child, :last-child, :nth-child, etc.
If you're open to it, I have a PR that mirrors what you did with rawSourcePos, passing index information to non-tag renderers if a boolean prop on the Markdown component is set to true. Would love your feedback! And I'm particularly terrible at naming things so please feel free to suggest better alternatives!
Will open that PR momentarily.

Thanks for your kind words! I will address some issues in your PR.

Feature included in 3.6.0.

@Dunridge this discussion is from over 6 years and also six major versions ago.
The API is very different now.
See the README for information on the current API.
If you have questions on how to do something open a discussion and include the context of what you want to solve.
https://github.com/orgs/remarkjs/discussions/new?category=q-a


Metric server with weave net can't collect monitoring data from the node where his pod is placed

Metric server can't collect monitoring data from the node where his pod is placed, I think it is policy or networking problem as I cant ping from the pod to its host (r2s13) while I am able to ping the other two nodes. (same result when I tested on another pod)
I am trying to figure out why Metric server isn't collecting stats from the node where his pod is placed. There are 3 nodes in my cluster (master and 2 workers)
metric server version is 0.3.1
kubernetes version is 1.12 installed with kubeadm
CNI plugin is weave net
"kubectl top node" output:
NAME    CPU(cores)   CPU%   MEMORY(bytes)   MEMORY%
r2s12   344m         4%     3079Mi          12%
r2s14   67m          0%     1695Mi          21%
r2s13
in metric server log I have the below line repeated:
E1023 15:28:14.643011       1 manager.go:102] unable to fully collect metrics: unable to fully scrape metrics from source kubelet_summary:r2s13: unable to fetch metrics from Kubelet r2s13 (<IP_ADDRESS>): Get https://<IP_ADDRESS>:10250/stats/summary/: dial tcp <IP_ADDRESS>:10250: i/o timeout
"netstat -a | grep 10250" output from r2s13:
tcp6       0      0 [::]:10250              [::]:*                  LISTEN
tcp6       0      0 r2s13.r2s13:10250       r2s12.r2s12:33950       ESTABLISHED
"netstat -a | grep 10250" output from inside the pod:
tcp        0      1 metrics-server-7fbd9b8589-r9nnv:60384 <IP_ADDRESS>:10250    SYN_SENT
tcp        0      0 metrics-server-7fbd9b8589-r9nnv:43876 10-199-183-217.kubernetes.default.svc.cluster.local:10250 ESTABLISHED
tcp        0      0 metrics-server-7fbd9b8589-r9nnv:45926 <IP_ADDRESS>:10250    ESTABLISHED
I do not know if the default setting of weave net npc is blocking the traffic from the pod to its hosts, or it is something else.

@hshtel Please provide weave and weave-npc logs as requested in the issue template.

here is more detailed log as you request:
** Is this a REQUEST FOR HELP? **
** Is this a BUG REPORT? **
yes
What you expected to happen?
allow connection from inside the pod to the host where it's placed (so Metric server can collect monitoring data from the node where his pod is placed)
What happened?
I cant get metrics from the r2s14 which is the node where Metric server pod is placed.
"kubectl top node" output:
NAME    CPU(cores)   CPU%   MEMORY(bytes)   MEMORY%
r2s12   320m         4%     1869Mi          7%
r2s13   65m          0%     705Mi           5%
r2s14
in metric server log I have the below line repeated:
unable to fully collect metrics: unable to fully scrape metrics from source kubelet_summary:r2s14: unable to fetch metrics from Kubelet r2s14 (<IP_ADDRESS>): Get https://<IP_ADDRESS>:10250/stats/summary/: dial tcp <IP_ADDRESS>:10250: i/o timeout
Anything else we need to know?
kubeadm is used to create the cluster.
below are my nodes:
NAME         STATUS   ROLES    AGE     VERSION   INTERNAL-IP
node/r2s12   Ready    master   7d19h   v1.12.1   <IP_ADDRESS>
node/r2s13   Ready       7d19h   v1.12.1   <IP_ADDRESS>
node/r2s14   Ready       7d19h   v1.12.1   <IP_ADDRESS>
Versions:
$ weave version
root@r2s12:~# weave version
This is WEAVE, Version 4.4 (TeX Live 2015/Debian)
weave: fatal: web file `version.web' not found.
$ docker version
Client:
Version:           18.06.0-ce
API version:       1.38
Go version:        go1.10.3
Git commit:        0ffa825
Built:             Wed Jul 18 19:11:02 2018
OS/Arch:           linux/amd64
Experimental:      false
Server:
Engine:
Version:          18.06.0-ce
API version:      1.38 (minimum version 1.12)
Go version:       go1.10.3
Git commit:       0ffa825
Built:            Wed Jul 18 19:09:05 2018
OS/Arch:          linux/amd64
Experimental:     false
$ kubectl version
v1.12.1
Logs:
$ kubectl logs -n kube-system  weave
nothing special in this log it is all like below:
WARN: 2018/10/24 09:49:14.479057 Vetoed installation of hairpin flow FlowSpec{keys: [EthernetFlowKey{src: f6:b0:8c:c6:13:40, dst: 56:41:54:56:ea:d8} InPortFlowKey{vport: 1}], actions: [OutputAction{vport: 1}]}
INFO: 2018/10/24 09:49:41.618990 Discovered remote MAC 8a:6d:19:0e:95:26 at ae:9a:41:9a:13:07(r2s13)
INFO: 2018/10/24 09:49:41.637759 Discovered remote MAC 66:eb:77:3e:83:18 at 0a:3a:30:bc:0c:e2(r2s12)
WARN: 2018/10/24 09:52:06.717484 [allocator]: Delete: no addresses for 571ccb5552b16cc8b36780d277323bf979c9604c9a82db508b1df9c2b91e9111
$ kubectl logs -n kube-system  weave-npc
nothing special in this log it is all like below:
DEBU: 2018/10/24 11:57:17.698101 EVENT DeletePod {"metadata":{"creationTimestamp":"2018-10-24T11:03:18Z","deletionGracePeriodSeconds":0,"deletionTimestamp":"2018-10-24T11:56:59Z","generateName":"coredns-745bf547c4-","labels":{"k8s-app":"kube-dns","pod-template-hash":"745bf547c4"},"name":"coredns-745bf547c4-g5v7r","namespace":"kube-system","resourceVersion":"866220","selfLink":"/api/v1/namespaces/kube-system/pods/coredns-745bf547c4-g5v7r","uid":"69b12a72-d77c-11e8-a2ac-00259e1e2b8c"},"spec":{"containers":[{"image":"k8s.gcr.io/coredns:1.2.2","imagePullPolicy":"IfNotPresent","name":"coredns","ports":[{"containerPort":53,"name":"dns","protocol":"UDP"},{"containerPort":53,"name":"dns-tcp","protocol":"TCP"},{"containerPort":9153,"name":"metrics","protocol":"TCP"}],"terminationMessagePath":"/dev/termination-log","terminationMessagePolicy":"File"}],"dnsPolicy":"Default","nodeName":"r2s12","priority":0,"restartPolicy":"Always","schedulerName":"default-scheduler","securityContext":{},"serviceAccount":"coredns","serviceAccountName":"coredns","terminationGracePeriodSeconds":30},"status":{"conditions":[{"lastProbeTime":null,"lastTransitionTime":"2018-10-24T11:03:18Z","status":"True","type":"Initialized"},{"lastProbeTime":null,"lastTransitionTime":"2018-10-24T11:56:00Z","message":"containers with unready status: [coredns]","reason":"ContainersNotReady","status":"False","type":"Ready"},{"lastProbeTime":null,"lastTransitionTime":"2018-10-24T11:56:00Z","message":"containers with unready status: [coredns]","reason":"ContainersNotReady","status":"False","type":"ContainersReady"},{"lastProbeTime":null,"lastTransitionTime":"2018-10-24T11:03:18Z","status":"True","type":"PodScheduled"}],"hostIP":"<IP_ADDRESS>","phase":"Running","podIP":"<IP_ADDRESS>","qosClass":"Burstable","startTime":"2018-10-24T11:03:18Z"}}
INFO: 2018/10/24 11:57:17.698152 deleting entry <IP_ADDRESS> from weave-P.B|!ZhkAr5q=XZ?3}tMBA+0 of 69b12a72-d77c-11e8-a2ac-00259e1e2b8c
Network:
ip route from inside the pod:
/ # ip route
default via <IP_ADDRESS> dev eth0
<IP_ADDRESS>/12 dev eth0 scope link  src <IP_ADDRESS>
netstat from inside the pod:
/ # netstat -a | grep 10250
tcp        0      1 metrics-server-7fbd9b8589-whstv:48430 <IP_ADDRESS>:10250    SYN_SENT
tcp        0      0 metrics-server-7fbd9b8589-whstv:56664 <IP_ADDRESS>:10250    ESTABLISHED
tcp        0      0 metrics-server-7fbd9b8589-whstv:41814 10-199-183-217.kubernetes.default.svc.cluster.local:10250 ESTABLISHED
ip route from the node where the pod deployed:
root@r2s14:~# ip route
default via <IP_ADDRESS> dev enp5s4f1 onlink
<IP_ADDRESS>/12 dev weave  proto kernel  scope link  src <IP_ADDRESS>
<IP_ADDRESS>/26 dev enp5s4f0  proto kernel  scope link  src <IP_ADDRESS>
<IP_ADDRESS>/24 dev enp5s4f1  proto kernel  scope link  src <IP_ADDRESS>
<IP_ADDRESS>/16 dev docker0  proto kernel  scope link  src <IP_ADDRESS> linkdown
netstat from the node where the pod is deployed:
root@r2s14:~# netstat -a | grep 10250
tcp6       0      0 [::]:10250              [::]:*                  LISTEN
tcp6       0      0 r2s14.r2s14:10250       r2s12.r2s12:42440       ESTABLISHED
$ ip -4 -o addr
root@r2s14:~# ip -4 -o addr
1: lo    inet <IP_ADDRESS>/8 scope host lo\       valid_lft forever preferred_lft forever
4: enp5s4f0    inet <IP_ADDRESS>/26 brd <IP_ADDRESS> scope global enp5s4f0\       valid_lft forever preferred_lft forever
5: enp5s4f1    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global enp5s4f1\       valid_lft forever preferred_lft forever
7: docker0    inet <IP_ADDRESS>/16 brd <IP_ADDRESS> scope global docker0\       valid_lft forever preferred_lft forever
10: weave    inet <IP_ADDRESS>/12 brd <IP_ADDRESS> scope global weave\       valid_lft forever preferred_lft forever

@brb please the issue has been updated as your request

@hshtel which kernel version?

@brb it is ubuntu 16.04

@brb please your support :)


IN-4303: Bumpy scipy to 1.11.1

Summary
Bumped scipy to 1.11.1 in the requirements, and updated the scipy sources submodule to 1.11.1.
Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Code style update (formatting, renaming)
[ ] Documentation update
[x] Other (please describe): Dependency version update

Checklist

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary architecture and public interface documentation
[ ] Complex database migration required (with downtime)
[ ] Reprocessing of existing data required

Jira Tickets:

IN-4303

Done manually in master


Fix performance related pedantic clippy lints

This PR enables a couple of lints from the "pedantic" group that can improve performance.

As far as I can see this is mostly noise. (I'm also personally opposed to use of clippy in general, although opt-in lints are the least bad mode.)

For example, "redundant_else" cannot ever have any impact on performance as it does not change codegen. This is pure overreach with no useful outcome, only churn.

Your dismissal and closing without discussion have come across as super hostile to new contributions, you could have just told me to undo said change. I often solve clippy lints to become familiar with a codebase but I'm not going to be looking into this any more.

I feel the same way about your PR; I see it as a statement that boils down to "this codebase isn't to my taste and I would like it to be, without regard to the time of people maintaining it". This is why I responded the way I did.


Update Composer dependencies (2023-02-07-00-09)

Visual regression test passed!
View the visual regression test report


default value for blob/text with mysql adapter

you must place a verification / validation for when the column type is blob or text force the default value to null to avoid errors / exceptions
thanks

Will be resolved with https://github.com/cakephp/phinx/pull/990
Please help to get this merged if you can.


Pushing metadata to clients?

Hi,
Is it possible to push song specific information to the listeners ?
Cheers Marc

@daslicht you can use the API to push, the server support default Metadata from shoutcast/icecast
https://github.com/StreamMachine/StreamMachine/wiki/API


have a bug about AVX2 FMA

Click to expand!
Issue Type
Bug
Have you reproduced the bug with TF nightly?
Yes
Source
source
Tensorflow Version
2.12
Custom Code
Yes
OS Platform and Distribution
ubuntu 2004
Mobile device
No response
Python version
Python3.8.16
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
11.3
GPU model and memory
No response
Current Behaviour?
don't train,I want to fix it
Standalone code to reproduce the issue
2023-04-16 18:41:59.167857: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
Segmentation fault (core dumped)

Relevant log output
2023-04-16 18:41:59.167857: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
Segmentation fault (core dumped)

@stonecropa,
Could you please provide the complete code to debug the issue. Also Please don't file vulnerabilities on GitHub. Please consult https://github.com/tensorflow/tensorflow/blob/master/SECURITY.md and follow rules for responsible disclosure. Thank you!

Uploading RectifiedFlow-main (1).zip…
this

@stonecropa,,
The zip file which was provided above re-directing the same issue page. Please check and confirm whether you have attached the correct file or not. Thank you!


markdown-css: Wrap longer code elements in documentation.

Add a word-wrap rule so that longer code elements, such as example URLs or long return value names in the API documentation, do not overflow out of the view in narrowed browsers or mobile views.
Notes:

<code> tags that are in <pre> tags have the same word-break rule applied confirming that these changes to not impact those elements in the help center and API documentation.

Screenshots and screen captures:

Register response main description changes note - mobile view via browser devtools

Before
After

Get user group membership status endpoint - narrowed browser window

Before
After

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Looks great, marked to merge once CI passes.


Cell edit (small edit) and datepicker

Please add support of custom (etc. bootstrap) datetimepicker (date and datetime) in column edit.

@janmottl It is possible to do it with small edit? Your example is for big editing.

@mabezdek I don't use small editing. So I dion't have experience how to implement it.
DataGrid creates textarea inside td element when particular editing starts. So it will be necessary to catch element creation. Edited td has class 'editing' so it can be identified by that.
I sketch just an idea how it could be done.
$('body').on('DOMNodeInserted', 'textarea', function () { 	if ($(this).closest('td').hasClass('editing')) { 		$(this).addClass('class', 'any class'); // set class and attributes you need 	} });

Let's keep this issue in scope of data picker. Date time picker is in another issue. Thanks. 👍


Error

yasm -D__linux__ -f elf64 libaesni_custom/asm/iaesx64.s -o iaesx64.o
make: yasm: Command not found
Makefile:20: recipe for target 'libaesni' failed
make: *** [libaesni] Error 127

Hi, you need install yasm to compile sorry for no specify it in the README. I will update it.
In your linux system install yasm if you are using debian or ubuntu distro you can install it with the next line:
sydo apt install yasm
Kind Regards

Thanks you


[Feature] Better support for cross-page text selections

Related issues: #87, #115
It will be definitely important, but I'm not sure how cross-page selections should be handled in general.
For example, if we copy a link to text spanning from page 1 to 2, what should the copied text look like?
Especially, we will need a link for each individual page (I want to avoid adding a new link syntax like [[file.pdf#page=1-2]]), like so
> [!PDF|red] [[file.pdf#page=1&selection=...|file, page 1]], [[file.pdf#page=2&selection=...|file, page 2]]
> very very very long long long text spanning multiple pages

This is okay but does not look great.

I appreciate your efforts to enable text linking across multiple pages. It's a valuable feature.
I'm comfortable with having several links adjacent to each other. For instance, my layout would resemble this:

Additionally, being able to click on each link separately is essential.

You say that you want to avoid a new link syntax. But why? It would make it easy to distinguish between a regular link and one that spans many pages. Plus, it would look better than having many smaller links side by side. And when you click on it, then the first line of the highlight will be targeted in the PDF viewer (same as a click on a normal link).

@RyotaUshio
Hmm, maybe you don't want to enable one of your solution from above by default.
I can understand that.
But maybe one of your solutions from above can be a setting to enable in the PDF++ settings?
That would be great.

Apology for deleting my last posts. I was just a bit desperate that I couldn't help.
But perhaps there is another method without having to make changes to the links themselves.
It would certainly save me at least 50 clicks or more per PDF file if there could be a cross-page annotation.
A cross-page annotation alone would be sufficient, which might behave like this:
If you were to highlight the bottom few lines of page 4 and then, in one go, the top lines of page 5, only the formats available for selection in the right-click menu could be those which you might set in a separate cross-page copy link format section (or a checkbox next to the existing formats for cross-page) in the PDF++ settings:

This means that when you have selected a color with a copy link format via right-click, the selected cross-page copy link format will then be applied to both page 4 and page 5.
The advantage here is that you no longer have to perform the action twice (once for page 4 + once for page 5).
So, it simply performs the same copy link format as if you were to execute a copy link format action on page 4 and page 5 separately. But both actions with a single cross-page marking and a right-click afterward.

Hi, I'm sorry for not responding for a while. I've been a bit overwhelmed by all the things happening in my life recently and didn't have enough energy to discuss this issue (and reply to all other messages that I haven't been able to do). I do appreciate your help and engagement in this project very much.
I will get back to you in detail later.


Zones overhaul updates

Description
Merge the working zones-related branches into one.

Update reactors module such that a Core is given an empty Zones upon instantiation (instead of None)
Remove references to zoning strategy hooks and reactors.buildZones: zones will be implemented in downstream applications via Interfaces
Move buildManualZones function to the Core class (if called, then Core.zones is set up using the zoneDefinitions case setting

Checklist

[ ] This PR has only one purpose or idea.
[ ] Tests have been added/updated to verify that the new/changed code works.

[ ] The code style follows good practices.
[ ] The commit message(s) follow good practices.

[ ] The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
[ ] The documentation is still up-to-date in the doc folder.
[ ] The dependencies are still up-to-date in setup.py.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Joshua Chen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Added unit tests to clear the coverage checks, which led me to discover and fix a bug with Zones.getAllLocations. Hopefully we get the green checks, now :)


Support IntelliSense for JSDoc @property/@prop tags

Suggestion
🔍 Search Terms

JSDoc
@property / @prop
suggest / suggestion
complete / completions
IntelliSense

✅ Viability Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
Enable IntelliSense inside JSDoc @typedef/@property tags.
@param is already supported, @property doesn't seem too different.
📃 Motivating Example

The completion on @param is really useful! When you have complexes objects or types that you are using across your app, @typedef is the perfect tag to define a custom type. But the completion is missing from @property. Even @typedef got completion!

💻 Use Cases
This would help significantly while writing @property tags on @typedef definition.
Right now, I don't have any workaround.
Thanks

Looks similar to https://github.com/microsoft/TypeScript/issues/46606. The fix should be in the 4.6-beta
/cc @RyanCavanaugh

Absolutely, sorry I didn't found this issue before posting mine.
I close this one.


I cant upload docx

My config files are :
 true,

    // Middlewares which should be applied to all package routes.
    // For laravel 5.1 and before, remove 'web' from the array.
    'middlewares' => ['web','auth'],

    // The url to this package. Change it if necessary.
    'prefix' => 'laravel-filemanager',

    /*
    |--------------------------------------------------------------------------
    | Multi-User Mode
    |--------------------------------------------------------------------------
    */

    // If true, private folders will be created for each signed-in user.
    'allow_multi_user' => false,        // !Important do not change

    // The database column to identify a user. Make sure the value is unique.
    // Ex: When set to 'id', the private folder of user will be named as the user id.
    'user_field' => 'id',

    /*
    |--------------------------------------------------------------------------
    | Working Directory
    |--------------------------------------------------------------------------
    */

    // Which folder to store files in project, fill in 'public', 'resources', 'storage' and so on.
    // You should create routes to serve images if it is not set to public.
    'base_directory' => 'public_html',

    'images_folder_name' => 'user/user-',    // !Important do not change
    'files_folder_name'  => 'files',     // !Important do not change

    'shared_folder_name' => '',
    'thumb_folder_name'  => 'thumbs',

    /*
    |--------------------------------------------------------------------------
    | Startup Views
    |--------------------------------------------------------------------------
    */

    // The default display type for items.
    // Supported: "grid", "list"
    'images_startup_view' => 'grid',
    'files_startup_view' => 'list',

    /*
    |--------------------------------------------------------------------------
    | Upload / Validation
    |--------------------------------------------------------------------------
    */

    // If true, the uploaded file will be renamed to uniqid() + file extension.
    'rename_file' => false,

    // If rename_file set to false and this set to true, then non-alphanumeric characters in filename will be replaced.
    'alphanumeric_filename' => true,

    // If true, non-alphanumeric folder name will be rejected.
    'alphanumeric_directory' => false,

    'max_image_size' => 5000,
    'max_file_size' => 10000,

    // available since v1.3.0
    'valid_image_mimetypes' => [
        'image/jpeg',
        'image/pjpeg',
        'image/png',
        'image/gif'
    ],

    // available since v1.3.0
    // only when '/laravel-filemanager?type=Files'
    'valid_file_mimetypes' => [
        'image/jpeg',
        'image/pjpeg',
        'image/png',
        'image/gif',
        'application/pdf',
        'text/plain',
        'text/docx'
    ],

    /*
    |--------------------------------------------------------------------------
    | File Extension Information
    |--------------------------------------------------------------------------
    */

    'file_type_array' => [
        'pdf'  => 'Adobe Acrobat',
        'doc'  => 'Microsoft Word',
        'docx' => 'Microsoft Word',
        'xls'  => 'Microsoft Excel',
        'xlsx' => 'Microsoft Excel',
        'zip'  => 'Archive',
        'gif'  => 'GIF Image',
        'jpg'  => 'JPEG Image',
        'jpeg' => 'JPEG Image',
        'png'  => 'PNG Image',
        'ppt'  => 'Microsoft PowerPoint',
        'pptx' => 'Microsoft PowerPoint',
    ],

    'file_icon_array' => [
        'pdf'  => 'fa-file-pdf-o',
        'doc'  => 'fa-file-word-o',
        'docx' => 'fa-file-word-o',
        'xls'  => 'fa-file-excel-o',
        'xlsx' => 'fa-file-excel-o',
        'zip'  => 'fa-file-archive-o',
        'gif'  => 'fa-file-image-o',
        'jpg'  => 'fa-file-image-o',
        'jpeg' => 'fa-file-image-o',
        'png'  => 'fa-file-image-o',
        'ppt'  => 'fa-file-powerpoint-o',
        'pptx' => 'fa-file-powerpoint-o',
    ],
];

When i upload PDF or simple TXT it works. But cant menage to work with doc and docx
thank you for your time

Upgrade to v1.7.1 and run php artisan vendor:publish --tag=lfm_config --force.

Yes, that fixed my problems. But now I have a problem with laravel on the server.
When I upload some PDF. Put a link to that pdf in TinyMCE I have laravel route error:
NotFoundHttpException in RouteCollection.php line 161
https://github.com/UniSharp/laravel-filemanager/issues/130
Maybe this is the same problem in link above but I can't fix it.
Do you have some idea?
I appreciate you time

This is the link :
http://programta.net/user/user-1/img/shares/Accommodation_GetObjectDetails.pdf

I have found what is the problem. The problem is in file permission. When we upload throw file manager some file, automatically file permission on that file is 600. Haw i can change that , please help ?

O.K. I have found what is the problem :)
In Upload Controller on line 65.
Edit and put : http://php.net/manual/en/function.move-uploaded-file.php
               move_uploaded_file ($file->path(), $new_file_path);
@g0110280 Thank you for helping me with this package.

config/lfm.php
'valid_file_mimetypes' => [
'image/jpeg',
'image/pjpeg',
'image/png',
'image/gif',
'image/svg+xml',
'application/pdf',
'application/docx',
'text/plain',
'image/vnd.microsoft.icon',
'image/x-icon',
'application/vnd.ms-excel','application/vnd.openxmlformats-officedocument.wordprocessingml.document','application/docx'
],

view : dropzone type mime

I'm also getting the same issue. only pdf and images are allowed to upload rest of the formats not supported. I'm using latest version 1.8 of laravel file manager. please tell me what might be the issue ??

modify your config/lfm.php with this:
'valid_file_mimetypes' => [
'image/jpeg',
'image/pjpeg',
'image/png',
'image/gif',
'image/svg+xml',
'application/pdf',
'application/docx',
'text/plain',
'image/vnd.microsoft.icon',
'image/x-icon',
'application/vnd.ms-excel','application/vnd.openxmlformats-officedocument.wordprocessingml.document','application/docx'
],
this is due to dropzone.js type mime, which is use for upload

I have tried by replacing this code also but still, I'm facing the same issue.
Can you please tell me what should I do??
should I make changes in dropzone.js  file?

'valid_file_mimetypes' => [
'image/jpeg',
'image/pjpeg',
'image/png',
'image/gif',
'image/svg+xml',
'application/pdf',
'text/plain',
'application/vnd.ms-excel',
'application/vnd.openxmlformats-officedocument.wordprocessingml.document',
'application/docx',
'application/msword',
'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet'
],
this solved my problem which was not able to upload .xlsx files.

After 2hours trying we solve the problem easily.
In file vendor\unisharp\laravel-filemanager\src\Controllers\UploadController.php
Line 82 change code from:
File::move($file->getRealPath(), $new_file_path);
to:
move_uploaded_file($file->getRealPath(), $new_file_path);


Inaccurate position inside flex layout

I've been getting a few instances where popper element is positioned partially outside the viewport. One common factor has been display: flex. I've been able to reproduce this by putting the popper elements inside a nested flex layout (see codepen).
CodePen demo
https://codepen.io/anon/pen/JQLjdP
Steps to reproduce the problem

Put popper elements inside an element with display: flex
Put that element inside another element with display: flex
Give the outer wrapper justify-content: flex-end to push everything to the right of the screen

What is the expected behavior?
The popper element to be positioned so that no horizontal scroll is needed.
What went wrong?
The popper element was positioned partially outside the viewport, requiring a horizontal scroll.
Any other comments?
Edit: the inner flex might not be necessary.

Could this be a dupe of https://github.com/FezVrasta/popper.js/issues/455?

Doesn't look like it to me. Giving the containers in my example (even) height values doesn't make any difference.

If you add left: 0; to #pop it works.

As pointed out, you need to set some initial CSS to the popper element to make sure it doesn't mess the layout before Popper has a chance to run its logic.
The example works correctly on v2
https://codepen.io/FezVrasta/pen/OJPbrJX

@smth Did you manage to solve this in version 1.X?

No, the fix landed in v2

@FezVrasta Thank you, I understand, but you mentioned some initial CSS. I've been struggling for a while, so I wondered if @smth has an example that works.
Unfortunately, I'm locked tor react-popper that hasn't updated to version 2 yet.

I was referring to https://github.com/popperjs/popper-core/issues/797#issuecomment-553458986

I had the same issue. My tooltip was inside of a flex element with justify-content between. the button was smaller than my tooltip and I had to retrigger the translate update using popperTooltip.update() after the toggle event. Putting it here if someone has the same issue.
https://popper.js.org/docs/v2/migration-guide/#8-update-method-names`

I fixed this by passing positionFixed: true to the popper options.


✨ Support videos using obsidian syntax + Copying files at export file

🔖 Feature description
Hi,
When can we expect PR from the original repository to be merged with this one?
A while ago, I submitted PR #261 (see below) to insert videos using obsidian syntax and copying the files when exporting the slides.

Hi,
I had been experiencing this issue for a while aswell https://github.com/MSzturc/obsidian-advanced-slides/issues/260 .
This PR adds support to videos included with obsidian syntax (which were not rendered before)
![[myVideo.mp4]]

And copies the video file when exporting the slides. It also copies the file if it is embedded using html code. For example:
<video data-autoplay="" controls="" loop="" height="700" data-paused-by-reveal="">
  <source src="/99-Attachments/2023-09-12_jumping_jacks.mp4" type="video/mp4">
</video>

✔ Solution
I implemented it in the original repository a while ago:
https://github.com/MSzturc/obsidian-advanced-slides/pull/261
❓ Alternatives
No response
📝 Additional Context
No response

If you have a PR that you would like to have integrated, you'll need to bring it to this fork and make sure it still works w/ fastify + newer reveal.js.
I'm happy to work with your contribution, but I haven't been scrubbing the other repo for pending work.

I've taken a stab at a different approach to this in the latest release (extended image collector to also handle videos, as processing is more or less the same).


Add many more OIDs

Signed-off-by: Jonathan M. Wilbur<EMAIL_ADDRESS>
Checklist

Why?

Why?

I added these OIDs from an extraction I produced from hundreds of ASN.1 modules. I recognize most of them do not really have significance for cryptography. I preferred to submit the complete list and get your feedback on what you'd like removed.
I would be happy to remove many / most of these if you do not want all of these, but I do think we should retain, at a minimum:

The object identifiers pertaining to Platform Certificates
The object identifiers pertaining to CAdES
The object identifiers sourced from the ITU's 2019 edition of the SelectedAttributeTypes module.

There are also object identifiers pertaining to algorithms in there, but maybe you do not want the object identifiers for algorithms not yet implemented in OpenSSL.
Bear in mind that there is an outstanding PR for implementing Attribute Certificates in OpenSSL, which would make a more comprehensive catalog of object identifiers more valuable.

Regarding the CLA check, I emailed the legal team to add the email above to my CLA. I already agreed, just with a different email. I can resubmit with the email that I signed the CLA with if this turns out to be difficult.

IMO, we should not seek to be a database of all known OIDs. This will just lead to a maintenance headache. Only OIDs with relevance to cryptography should be added.

I think a better (future) approach would be having an ability to load OIDs from a file.  Either using a default file name or via configuration (or both).
Then we could look into removing the current OID database from the library.  Or at least most of it.

This approach works only if we don't have to refer to a corresponding NID.

IMO, we should not seek to be a database of all known OIDs. This will just lead to a maintenance headache. Only OIDs with relevance to cryptography should be added.

I figured. I figured since I had them all, I'd make the pitch, since I don't think it's too much overhead to have them in there, but I'll remove the non-cryptography ones. Will that suffice? Major manufacturers want the Platform Certificate attributes, at least, because they expect to use them for hardware security. And CAdES has obvious pertinance to cryptography.

I'll remove the non-cryptography ones. Will that suffice?

From my point of view, yes. As long as there is a reasonable argument for why OpenSSL users would need those OIDs then I don't personally see a problem with adding them.

This approach works only if we don't have to refer to a corresponding NID.

We're moving towards using names not NIDs.

I think a better (future) approach would be having an ability to load OIDs from a file. Either using a default file name or via configuration (or both).

Uhmmmm, we have that ability already.
https://github.com/openssl/openssl/blob/master/doc/man5/config.pod#asn1-object-identifier-configuration


chore: split real broker tests to independant runs

Description
Much faster CI runs and less random erros occures

@davorrunje can u merge it, plz?


Metric Request: PII Score

PII or Personal Identifiable Information is a very important factor in asses the Generation quality of LLMs. PII can include the name of the Person, Credit Card Number etc, etc.
So a set of tokens (let's take word tokens for now), the PII score can be defined as the number of PII's detected by the total number of tokens.
Since, detecting PII would require NER, so it would fall under ModelBasedMetrics as defined on issue #238

@penguine-ip , @jaywyawhare wants to work on this issue :)

Hey @jaywyawhare, thrilled to have you working on this! I'll assign it to you and please feel free to ask for anything in our discord: https://discord.com/invite/a3K9c8GRGt

@penguine-ip Thanks for assigning this to me, I'm excited to dive into it. If I need any clarification or additional information along the way, I'll be sure to reach out on our Discord channel. Let's get started!

Likewise, happy to be working with you

Hey @jaywyawhare any updates?


Outdated dependencies

Your project depends on outdated and vulnerable packages, running npm fix --force didn't solve the issue. Please update your dependencies.

It stops working on Ubuntu 22.04 and I think it is related to outdated dependencies.
I am having the same error as here: https://github.com/webtorrent/node-bencode/issues/36


FR: Add property to InAppMessagingAction to indicate if primary action button

Feature proposal

Firebase Component: In-App Messaging

The InAppMessagingCardDisplay  has two action buttons, primaryActionButton and secondaryActionButton. We're trying to configure a new campaign that uses Cards with these two buttons. However, we have to set the behavior of the buttons at runtime. We cannot simply drop URLs into the Firebase Console because the actions are dependent on the current app state, i.e., the action would be related to the currently viewed content when the message was triggered. For example: if we wanted to recommend a related product to what the user is currently viewing, then we would need to insert the deep link to that recommended product into the message programatically at runtime- we couldn't do that in the Firebase Console, because there will be different recommended products depending on the currently displayed content.
We configured a new message campaign in the Firebase Console that has a Card with two buttons, both of which are set to dismissal behavior. At runtime, we're trying to use the InAppMessagingDisplayDelegate function messageClicked(_:with:) to determine which button was pressed. If and only if it was the primary button, then we will perform some action. The problem is that there is not currently a good way to determine which button was pressed. The only two properties on the InAppMessagingAction class are actionText and actionURL. The former is subject to localization and shouldn't be used as an identifier, and the latter is always nil for the reason described in the previous paragraph. How are we supposed to ID which button was pressed so we can act accordingly?

My API proposal is to add a boolean property isPrimaryAction to InAppMessagingAction to be used to confidently determine how to respond in the messageClicked(_:with:) delegate function.
Also, I'm getting some mixed impressions reading the docs. On one hand, it seems like there may be a way to create messages programatically at runtime where we can directly set the button URLs, but on the other hand there is no example code demonstrating this that I could find. This would be the ideal solution, even more so than the route we are trying to go with the delegate. Being able to set the URLs on the message at runtime before it is displayed would be best, but I'm having a hard time determining if this is possible.
Overall, perhaps because it is in Beta, the FIAM docs seem a bit lacking. At the moment FIAM seems to really only be setup for static campaigns, and less so for campaigns that are responsive to the application state. Please let me know if I'm missing something.

Can someone on the FIAM team let me know if I'm thinking about this correctly or if I've misunderstood something? I find it hard to believe that FIAM cannot be used with URLs inserted at runtime- preventing usage in all use cases that can't use static URLs (which I'd imagine to be the majority of use cases).

@willbattel Hey, this is Chris from the FIAM team. Just to get my head wrapped around your use case-- are you mostly showing in-app messages on app foregrounding, or ones that are triggered by custom analytics events?

@willbattel Hey, this is Chris from the FIAM team. Just to get my head wrapped around your use case-- are you mostly showing in-app messages on app foregrounding, or ones that are triggered by custom analytics events?

Currently it's mostly triggered by custom analytics events while the app is in use, rather than upon the app becoming active.
On a different tangent, another quick question:
Is the only different between:
Analytics.logEvent("event_name") (no custom parameters)
and
InAppMessaging.inAppMessaging().triggerEvent("event_name")
that Firebase Analytics won't record the latter?

Let me also provide a more clear use case example. Let's say the app session flows like the following series:

App launches, session start
User navigates to product page
User purchases product
After completed purchase, trigger FIAM message to suggest another product using a recommendation ML model.
User is taken to other product or dismisses message.

We would need to insert the URL for the FIAM message at runtime, because the product we want to take them to is dependent on the product they just purchased.
Putting in the FIAM action URL in the Firebase Console would only work if the campaign revolved around a single product If the campaign is contextual, as it is in our case, then I don't think we can use FIAM unless we could enter the URLs at runtime.

Is the only different between:
Analytics.logEvent("event_name") (no custom parameters)
and
InAppMessaging.inAppMessaging().triggerEvent("event_name")
that Firebase Analytics won't record the latter?

Yes, that's the only difference. The in-app message display behavior will be the same.

Let me also provide a more clear use case example. Let's say the app session flows like the following series:

App launches, session start
User navigates to product page
User purchases product
After completed purchase, trigger FIAM message to suggest another product using a recommendation ML model.
User is taken to other product or dismisses message.

We would need to insert the URL for the FIAM message at runtime, because the product we want to take them to is dependent on the product they just purchased.
Putting in the FIAM action URL in the Firebase Console would only work if the campaign revolved around a single product If the campaign is contextual, as it is in our case, then I don't think we can use FIAM unless we could enter the URLs at runtime.

OK. That clears things up for me. You're right that you've reached the limits of our API with this case. We have the messageClicked(_:with:) callback for developers that want to handle clicks themselves, but as you mentioned there's no way to tell which button was clicked if you can't rely on the button text.
Adding isPrimaryAction would solve your use case, but I wonder if adding an identifier to an action would be a better API. I'll talk to the team about this.

Adding isPrimaryAction would solve your use case, but I wonder if adding an identifier to an action would be a better API. I'll talk to the team about this.

I agree. I only suggested the boolean for its simplicity- but having a canonical identifier would be more versatile. Thanks for looking into it!

@christibbs because of #6405 it would probably be best if we could set the actionURL programmatically. The ability to set the URL at runtime would solve both issues, I believe.
I think the most straightforward API would be a new delegate function, something like prepare(for inAppMessage: InAppMessagingDisplayMessage) for example. Such a function would allow the app to configure message properties, such as the actions, before it is displayed to the user. We could then use the messageID property from the inAppMessage.campaignInfo parameter to optionally prepare the message. The This is just an idea, let me know what you think.

Hmm, I like the idea of prepare(for inAppMessage: InAppMessagingDisplayMessage), it has recognizability from prepare(for:sender:) and it unlocks a lot of other potential use cases (different background color for light mode/dark mode for example).
We would have to change all of the properties on message objects to be readwrite, but I don't immediately see anything risky in that. Will run this by the group. Any changes to public API require approval from the larger Firebase team.

@willbattel We are going to address this by allowing templated messages in the in-app messaging console. It'll work something like a format string-- you'll add a template parameter for action URL in the console and then supply the action URL in your app's code.
The reasoning for this is we don't want a lot of divergence from what's on the console and what's appearing on users' phones/tablets. I'll keep this open until it's implemented, though it will take a bit longer than adding a prepare method would have.

@christibbs that should do the trick, thanks for looking into it!


Add missing minimal required python version (3.10)

trying with python 3.9, install seemed ok, but running babylon failed with syntax error, due to usage of 'match' satement, introduced in python 3.10

Thank you, we replaced the statement match and add missing minimal required python version (3.9) in toml file


Better java, gradle support

VSCode Version:1.6.1
OS Version: MacOS Sierra

We would like a more out of the box java support without relying on maven or eclipse.

open a java project (gradle if possible)  and be able to execute gradle tasks out of the box
be able to compile and run java apps
be able to local and most important remote debug java applications
keep on improving git support!

plugins existing now are not giving a good experience working with them in such a way.
This features would make vscode the one ide to rull them all, thanks for the excellent work!

1, 2, 3 can be done by extension. Try opening an issue for https://github.com/redhat-developer/vscode-java
If you have concrete points where we can improve git, feel free to open another issue.