Instancing

Continuation of #3023 for issue #3001
I checked that instancing works the same on Edge and IE, as the vao extension isn't supported in either.
I added a test inside the Sandcastle dev folder. So far the performance results show that instancing and batching are typically equal for fps. Though instancing does offer some speed improvements when the billboards are constantly updating.
For test coverage, the instancing and batched code paths are very similar and even basic tests should cover most of the divergences. I did edit the non-instancing test to be slightly more robust. The code coverage for BillboardCollection is 98%.
I'll have the model instancing code up after these changes are reviewed.

Though instancing does offer some speed improvements when the billboards are constantly updating.

What are the numbers?  Are they significant?
Also, it may be hard to measure (check the GPU process), but did you observe a memory savings?

Merging this into instancing-ready-for-master.  Please open the model instancing PR into this branch too.


VMD sphere and 3 loop apps

Here, we are merging the base code for the following apps:

FDEM sphere example for VMD source
TDEM sphere example for VMD source
3 loop model example

Related to the additions requested in geoscixyz/em-apps#37, geoscixyz/em-apps#39, geoscixyz/em-apps#40 and is necessary for pr: geoscixyz/em-apps#50


Project based factory extension popover displays wrong data

As the image shows the current storage is not displayed and the current production progress seems to contain the stored amount instead of the progress.

Fixed in version 1.69.0


Update documentation

Update README.md
Add ARCHITECTURE.md

README
ARCHITECTURE

Uuuugh. Clippy thinks "PostScript" is a doc item.

(Sorry everyone, I rebased from master and ended up doing a force push. My corrections from feedback are in the third commit.)

I think everyone's feedback is addressed. Will merge this today unless there's some egregious problem. Any further tweaks will happen in a future PR.


external: add the optiga-trust-m dependency

Needed to interact with the Optiga secure chip.
The optiga-trust-m module was forked to the BitBoxSwiss org, along with its own submodule mbedtls, so we are safe against deps disappearing.

I've been developing locally on top of this PR for a while now, communicating with the chip, and had no issues. @NickeZ ready for review & merge.

In the future we could probably reduce the size of the optiga lib by removing support for features as well.


Add cats/fs2 backend for JRE11 Http Client

This PR adds a cats/fs2 backend for the JRE11 Http Client.
The actual code is mostly a combination of the fs2 AHC backend and the Monix Http Client backend.
While making these changes, I moved some common things around, to avoid duplicating code.

Btw, I just used Stream[F, ByteBuffer] as the streaming type, because I saw that in the monix implementation, but is there any reason to use ByteBuffer here over Stream[F, Byte]?

I went ahead and changed it, since I couldn't see a reason not to.

Released in 2.0.8, thanks!


[API][SYNC] A user should be able to control the way issues are synced with notes.

Is your feature request related to a problem? Please describe.
The current behavior creates the note when I created it on Gitlab.
When the issue is closed, the note is deleted.
If a note is required for history purposes it can not be kept in the vault with the current behavior.
Describe the solution you'd like
A setting Update type represented as a drop-down list with the following items and corresponding behavior:

Full, full-update (default), current behavior, note is created, updated and deleted in adequacy with the Gitlab Issue.
Write-Only, half-update, note is created and updated in adequacy with the Gitlab Issue.
Once, no-update, note is created in adequacy with the Gitlab Issue.
Archive, full-update, note is created, updated and archived (moved to another folder when closed) in adequacy with the Gitlab Issue.

Describe alternatives you've considered

Make all the update I require, revoke the token when I start closing issues (current work around).
Activate use the plugin when create or update an issue, then deactivate the plugin (no practical, especially since I work with a team of students, it over-complicates the note taking process)
Having all the note created in a "buffer" directory, then moving them to the correct location on creation/update (might implement this one for the next semester).

Additional context
I'm using Obsidian to take notes during my classes. Other students contributes to the note taking.
I'm using Gitlab to manage this process and deploy the notes to Gitlab Pages.

I'm wondering if this can be achieved using a separate plugin. I've done a quick search and found https://github.com/farux/obsidian-auto-note-mover which seems to be able to automatically move notes that have a certain tag.
If you add a tag to your custom template file in this Gitlab Issues plugin, each issue from Gitlab will automatically be tagged, and then this Auto Note Mover plugin can detect it and automatically move it to your archived/permanent folder.

Closing as looks like alternative solution was sufficient. Feel free to re-open this issue if needed.


Running Protractor with Docker Selenium Grid + Firefox

Hi,
I'm currently running into the problem running e2e tests with  protractor on Docker selenium grid.
I have setup Selenium Grid locally  with linked firefox browser (both are docker containers)
My protractor.config file contains selenium grid address and browser as firefox
exports.config = { seleniumAddress: 'http://<IP_ADDRESS>:4444/wb/hub',
multiCapabilities: [ { browserName: 'firefox' }], baseUrl: "sameUrl"}

Test run failing with the error messages:

"Error while waiting for Protractor to sync with the page: "<title>Selenium Grid2.0 help</title>You are using grid 2.50.0

node_modules/selenium-webdriver/lib/atoms/error.js:113

   var template = new Error(this.message);
                  ^
 UnknownError:  <meta http-equiv="Content-Type" content="text/html;charset=ISO-8859-1"/>
Error 405
HTTP ERROR: 405
Problem accessing /wb/hub/session/null. Reason:
  Http method DELETE is not supported by this URL
[launcher] Process exited with error code 1
>> Exited with code: 1.
Warning: Task "exec:runProtractor" failed. Use --force to continue.

I'm new to this kind of setup : selenium grid + docker  and probably missing something . tried to google and stackoverflow but no luck for above error.   Maybe someone had a similar problem ?
Thank you in advance.

Hi there!
Because of its usage/debugging nature, your question is better suited for StackOverflow or Gitter. Please ask a question there with the 'protractor' tag or post in the Gitter Channel to get help. Since your issue is specific to selenium grid and docker, which is not the most common use case, you may also need to ask channels specific to those technologies as well.
Thanks and good luck!


Ability to pull new plans

Is your feature request related to a problem? Please describe.
When customer purchases a SaaS subscription, the current available plans are being pulled. But when the publisher added new plans to the offer, there is no way to pull them other than going through the testing cycle and pulling them.
Describe the solution you'd like
During Fetch I would like to have new plans pulled in for existing SaaS subscriptions
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Fetch All Sub button should already pull the new plans. Hence closing this.


Hex casting spells are able to break unbreakable waystones

first of all, i have no clue how this mod works, but apparently someone on my server who does figured out how to break "unbreakable" waystones that scatter the world.
basically, the waystones mod has a config option that allows you to make all naturally generated waystones unbreakable. unfortunately, this doesn't work the best it can- they are still able to be broken with hexes. i don't have a video of that, but here are the steps you need to make to recreate this:
1- install both the waystones mod and hexcasting
2- enable the naturally generated waystones are unbreakable config option in the waystones config
3-  find a naturally generated waystone (i suggest using the https://www.curseforge.com/minecraft/texture-packs/towers-of-the-wild-reworked-datapack to do that easily)
4- attempt breaking them using a hex

here's an example of the same problem happening with create drills https://www.youtube.com/watch?v=yYgqfXyR0Yc

so when you spell the break spell it will break the waystone ? maybe ask the dev of waystone to make it unbreakable like bedrock

Yeah, this sounds like a bug with Waystones instead of Hexcasting. Go ask them first; if there's some reason they can't do that reopen this and I'll fix it on here


actually import whatwg-fetch polyfill

Looks like this might not be getting picked up automatically? Just a guess based on installation instructions in https://github.com/github/fetch#installation.

The stack is strange, just importing it doesn't actually do anything.  I have a branch with a fix, so closing this.


Enhancement: Vim Scrolling

I love this tool and use it almost every day while looking over  READMEs in local node_modules. One thing that I personally would really enjoy—which is a bit of a pipe dream—would be  keyboard scrolling with J and K keys. (It would also be nice to be able to use gg and G as well, not to mention searching for text with /).

Great idea! There is already an issue for searching within a document #73. You can add a comment there about the / key and subscribe to notifications if you want to keep track.

@xaviervalarino Hey, this is not supposed to be a plug, but it might be of interest to you: https://github.com/felixSchl/gh-preview. I am not really maintaining that project anymore but I use it almost daily or whenever I have markdown work to do like writing my READMEs, changelogs and so on. You edit your markdown in vim and it renders it in the browser, looking as much as possible like if it was on github. Just thought I'd leave this here

@felixSchl I think you misunderstood. I would like to use Vim key bindings to scroll down the page, much like Vimperator or Vimium.
That being said, gh-preview reminds me of issue #82, where @davidmarkclements put forth the idea of having the the electron window scroll to where the cursor was in an open text editor. I can't tell from the gif if gh-preview supports scrolling on the browser window, but wonder if any of your work could be used to create that feature.

Yeah, feel the same way if this support vim-like movement, I am a new vmd user, currently I only found that
SPC  next page
Shift+SPC  previous page.


puppetserver_gem provider requires PATH to include path to puppetserver binary

Affected Puppet, Ruby, OS and module versions/distributions

Puppet: any?
Ruby: any?
Distribution: any?
Module version: 2.2.0

How to reproduce (e.g Puppet code you use)
ensure('vault', {provider=>'puppetserver_gem'})
What are you seeing
Error: /Stage[main]/Profile::Puppetmaster/Package[vault]: Provider puppetserver_gem is not functional on this host
What behaviour did you expect instead
vault to be installed
Output log
Any additional information you'd like to impart
Looking at lib/puppet/provider/package/puppetserver_gem.rb I see that it does a which('puppetserver'), hence the requirement that it be in the path.  But this is the only thing I've ever run in to that required puppetserver to be in the path when I run "puppet agent -t".  The puppetlabs/puppetserver_gem module doesn't do a which, it hard codes it to the path -- maybe this should do the same?

but, how about removing the puppetserver_gem support?
There is an official puppetserver_gem module: puppetserver_gem
but it's not possible to use that one along with this one: it keeps overwriting the ruby gem at each run.

Looks like this provider is no longer in the module in the most recent version. This can probably be closed?


Use Hosted Universal Viewer

Requires token auth

Is this still relevant now that we're using pul_uv_rails?

If we want to support arbitrarily embedding elsewhere (e.g. in a blog), is there any advantage either way?

Nah, we should just close this.

i.e. wrt IIIF Auth?

Nope. Only benefit would be if it were external it would be easier to upgrade in all places. I say we just close this.


Prep for Voice Steering feature

Credits:

ylacombe

Add input_values to DACModel
dac_wrapper/modeling_dac.py
https://github.com/huggingface/parler-tts/pull/110#discussion_r1745381980

stg2015

Delay mask adjustment for input_values
modeling_parler_tts.py
https://github.com/huggingface/parler-tts/issues/81#issuecomment-2288116750

Heya, I am the author of https://github.com/huggingface/parler-tts/pull/110#discussion_r1745381980.
It seems like we have similar results, but our implementations are slightly different. It looks like you are following https://github.com/huggingface/parler-tts/issues/81#issuecomment-2288116750 to adjust the delay patter mask after the tokens have been generated from the Decoder. Where as my implementation modifies the mask before the tokens are injected into the Decoder.
Are our approaches equivalent, or is there a difference?

Howdy!
Thanks for the optimization.
The power has been out here for over 6 hours here due to Helene. Just got the genny fired up. After I take care of getting the fam all situated I'll test your recommended change.
Once I've got the code done, I can do a tutorial video if there is enough interest.
Thanks!

From: Akash Gupta @.>
Sent: Friday, September 27, 2024 8:44:43 AM
To: huggingface/parler-tts @.>
Cc: apresence @.>; Author @.>
Subject: Re: [huggingface/parler-tts] Prep for Voice Steering feature (PR #141)
Heya, I am the author of #110 (comment)https://github.com/huggingface/parler-tts/pull/110#discussion_r1745381980.
It seems like we have similar results, but our implementations are slightly different. It looks like you are following #81 (comment)https://github.com/huggingface/parler-tts/issues/81#issuecomment-2288116750 to adjust the delay patter mask after the tokens have been generated from the Decoder. Where as my implementation modifies the mask before the tokens are injected into the Decoder.
Are our approaches equivalent, or is there a difference?
—
Reply to this email directly, view it on GitHubhttps://github.com/huggingface/parler-tts/pull/141#issuecomment-2379197391, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB5EQDTB753Z4VJ6AX7LGP3ZYVHLXAVCNFSM6AAAAABOYMZWIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZZGE4TOMZZGE.
You are receiving this because you authored the thread.Message ID: @.***>

Heya, I am the author of #110 (comment).
It seems like we have similar results, but our implementations are slightly different. It looks like you are following #81 (comment) to adjust the delay patter mask after the tokens have been generated from the Decoder. Where as my implementation modifies the mask before the tokens are injected into the Decoder.
Are our approaches equivalent, or is there a difference?

I modified my change with your suggestion, and got exactly the same output. Specifically, I used the same inputs and compared a hash of the the WAV file outputs and they are the same.
I'll adjust my PR based on your suggestion.
Thanks!

Hey @apresence, sorry for the long delay ! Turns out you were right. Merging to fix this! Thanks for the work

Does this PR enable inference on longer text, so the voice doesn't change with each chunk? If so, is there any documentation of how to actually do that? Or am I misunderstanding the purpose of this patch?

Yes. And I am working on it, just got tied up with other things.
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Adam J. Kessel @.>
Sent: Friday, November 15, 2024 4:33:22 PM
To: huggingface/parler-tts @.>
Cc: apresence @.>; Mention @.>
Subject: Re: [huggingface/parler-tts] Prep for Voice Steering feature (PR #141)
Does this PR enable inference on longer text, so the voice doesn't change with each chunk? If so, is there any documentation of how to actually do that? Or am I misunderstanding the purpose of this patch?
—
Reply to this email directly, view it on GitHubhttps://github.com/huggingface/parler-tts/pull/141#issuecomment-2479964319, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB5EQDREKXLBOCV6MP3Q73T2AZSCFAVCNFSM6AAAAABOYMZWIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZZHE3DIMZRHE.
You are receiving this because you were mentioned.Message ID: @.***>


[BugFix] Fix runtime filter value escape problem in mysql external table

Problem Summary:
Fixes https://github.com/StarRocks/starrocks/issues/23554
add test cases on https://github.com/StarRocks/starrocks/pull/23555
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 3.0
[x] 2.5
[x] 2.4
[x] 2.3

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5

@Mergifyio backport branch-2.4

@Mergifyio backport branch-2.3


[Bug] Window Snapping not working on Windows 10

Describe the Bug
The window does not "snap" to a screen when dragged. This works on the official Discord program, but for some reason doesn't work on BetterDiscord.
To Reproduce
Try snapping the window to a display while dragging it's title bar.
Expected Behavior
The window to "snap" to the entire display, or to the side of it.
Screenshots
After dragging the window to the top of a display, it doesn't resize or go fullscreen as expected, it just stays there.

Discord Version
Stable 86447 (6b2c76f), running BetterDiscord 1.1.1.
Additional Context
I have three displays, hence why I find display snapping so useful.

This is a limitation with electron's transparency module, which has some inconsistent side-effects on most window managers. If you aren't actively using the transparency option in BD settings, I suggest you disable it.

This is a limitation with electron's transparency module, which has some inconsistent side-effects on most window managers. If you aren't actively using the transparency option in BD settings, I suggest you disable it.

Thank you, this was the problem. I had no idea that was enabled.


turn code to delete branches associated with closed issues into task

Today I used octokit to get a list of branches that correspond to closed issues in order to delete them with it push origin :branchame`.  I need to get the commands from the pry session & turn them into actionable code.

This was created awhile ago, and the logic to do so may have changed. I'm going to close this issue as is & reopen something different


Feat/vertex bone attributes

Checklist

[x] cargo clippy reports no issues
[x] cargo deny issues have been fixed or added to deny.toml
[x] relevant examples/test cases run
[x] changes added to changelog Can do this later, once more substantial changes land

[x] Add credit to yourself for each change: Added new functionality @githubname.

Problems PR Solves
In preparation to supporting mesh skinning, add vertex bone index and bone weight attributes. Following the de-facto standard for this sort of thing, I used UVec4 for indices and Vec4 for weights, supporting up to 4 bones influencing every vertex.
Related Issues
None, that I know of

I just noticed the gltf crate parses bone indices as u16, so I changed the original UVec4 to [u16;4] to use those instead.


Add option to create links with action-create-card

Add the ability to create links between the contract being
created with action-create-card and other pre-existing contracts.
Change-type: minor
Signed-off-by: Josh Bowling<EMAIL_ADDRESS>

@joshbwlng I made a few tweaks to the test case, other than that this is looking ready to go 👌


Lock state does not update unless it's locked/unlocked by Integration?

I have a T8510 WiFi lock installed and the integration configured. I added a second account which I shared the lock to and the integration itself is working perfectly. However, noticed that the status on the lock entity does not update to reflect its current state if it's unlocked or locked via app or manually. Only lock/unlock done via Home Assistant is actually logging the state change.

I am also reporting the same issues I am using a T8500 wifi lock.

Same here with T8510 with bridge.

did you enable all push notifications as this integration/add-on fully rely on this

I assume you mean this @fuatakgun? If it is they're all enabled as you can see.

Same here, all notifications enabled.

I have this issue with 3 of the T8510 locks. When I had just one it worked almost all the time, but using 2 or 3 on the same account seems to completely disable the lock state fetching, unless it is locked and unlocked by HA. I tried slimming the account down to just 1, and it was working again, so it is reproducible.

What is the best way to grab extra logs for this? I am comfortable trying whatever, but if there are any notes for what to enable and where, I would appreciate it!

please share your device following README and let me know when I can debug

merging threads: https://github.com/fuatakgun/eufy_security/issues/298

@fuatakgun I shared my device (wood bru) with you. Please leave mostly locked :)
if it doesn’t show problems, you might need access to a second lock too. If so please let me know, although I will need to coordinate when you want ti test.

@fuatakgun I don't think the issue is resolved. At least it's still not updating the state with the latest stable release.

@fuatakgun Lock status not auto updating for me either.
Home Assistant 2022.7.5
Supervisor 2022.07.0
Operating System 8.2
Frontend 20220707.1 - latest
Eufy T8510 - Firmware <IP_ADDRESS>

@fuatakgun great, ping me if you need a second device if things unexpectedly work perfectly

@fuatakgun also let me know if you need a second account to have access—it works ok when locked/unlocked directly from HA, but it is when a different account or the actual lock operates that HA doesn't update. or I can do some lock/unlock events

hey, can we connect over google meet? https://meet.google.com/esb-vdrd-ggz?pli=1

Per our online debug session, here is the debug line for an unlock event:
2022-07-27 14:27:36 DEBUG (MainThread) [custom_components.eufy_security] eufy_security - set_event_for_entity - device / T8510Q10212603EB / lockStatus / False

please test with v2.2.9 of integration

All sorted, thank you so much! Works nicely with 2.2.9 with both locks.

My T8520 lock is no longer after updating the integration today. Prior to this I had issues (#376) while in geolocation mode, so simply turned it off. Now it's happening in home and away modes.
I have a few eufy devices if this could be related (wifi doorbell +home and floodlight cam E 2K)

Let's follow over new issue (already created one) and i have requested some help there.

@jem , we also need your support on this, is it still working for you? Please get latest integration version, there were some fundamental changes after our workshop.

@jem , we also need your support on this, is it still working for you? Please get latest integration version, there were some fundamental changes after our workshop.

Working correctly for me with 2.5.0 and 0.9.3.

@jem can you also do the same exercise above and share your results?

Same exercise from #402

@fuatakgun I looked at the states for lock.wooden_door and diffed after unlocking with the app, getting only:
> diff {un,}locked
12c12
< lockStatus: false
---
> lockStatus: true

Here is a trimmed version of the locked version:
type: DEVICE_TYPE.LOCK_BASIC
category: LOCK
state:
name: Wooden door
model: T8510
hardwareVersion: '1.2'
softwareVersion: <IP_ADDRESS>
state: 1
locked: false
lockStatus: true

properties:
name: Wooden door
model: T8510
type: 50
hardwareVersion: '1.2'
softwareVersion: <IP_ADDRESS>
state: 1
wifiRssi: -80
wifiSignalLevel: 2
lockStatus: true
locked: false

locked:
  key: custom_locked
  name: locked
  label: locked
  readable: true
  writeable: true
  type: boolean
lockStatus:
  key: 9999
  name: lockStatus
  label: Lock status
  readable: true
  writeable: false
  type: number
  states:
    '1': '1'
    '2': '2'
    '3': Unlocked
    '4': Locked
    '5': Mechanical anomaly
    '6': '6'
    '7': '7'

friendly_name: Wooden door

double confirming, you are on the latest version on integration and between two states, only lockStatus is different. locked is identical for two cases, right?

getting help from @bropat https://github.com/bropat/eufy-security-ws/issues/123

the above is correct for locking and unlocking from the app and merely observing in home assistant. If I use the lock itself, or use the eufy app itself, only lockStatus seems to change.
if I unlock/lock in HA, then use HA to unlock/lock again and take a diff, I instead get this:
> diff {un,}locked
11,12c11,12
< locked: false
< lockStatus: false
---
> locked: true
> lockStatus: true

which is consistent with before, when if I used home assistant exclusively it would work. So Eufy changes only lockStatus, whereas HA seems to also change locked.

merging this into new one: https://github.com/fuatakgun/eufy_security/issues/402


Use LLM to analyze ML-Bench failure cases

In this PR, I tried to provide LLM with some context of OpenDevin interaction histories. Then, we classify it into error classes defined in the ML-Bench paper.

@xingyaoww @li-boxuan please review and merge if it's good for you


Tezos: Support for Multiple Contract calls in one Operation

Is there a way using conseil to submit multiple contracts in a single operation?
It appears that TezosNodeWriter.sendContractInvocationOperation only accepts a single entrypoint and parameter. I have an operation that requires 3 contracts to be invoked.

it's possible to package operations into an operation group: TezosNodeWriter.sendOperation


Legend display false ignored on Radial charts

The display option is ignored for pie charts when passed to the charts options : https://jsfiddle.net/leighking2/n9ukwff7/
But if you set the global option to display false it is respected : https://jsfiddle.net/leighking2/ymrbzhw9/
The docs do not make any mention of specifically being able hide the pie charts legend but its odd that you can get different behaviours by setting the global property.

Root cause is a typo in the test fiddle. Updated fiddle: https://jsfiddle.net/n9ukwff7/1/

I must have looked at that 20 times and managed to miss that. My apologies


App publication failed because the consent pop-up window is getting blocked by the browser

Our Teams app validation has failed because the consent pop-up is getting blocked by the browser. The validation team reported this issue according to this certification policy 1100.5.
We were inspired by the sample here to add SSO authentication to our apps.
I was able to reproduce this by cloning and running the sample above.
I think the consent pop-up must be excluded from other pop-ups that may block the app validation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 410609cf-c930-72de-319d-351212f71b8c
Version Independent ID: 410609cf-c930-72de-319d-351212f71b8c
Content: Code configuration for enabling SSO for tabs - Teams
Content Source: msteams-platform/tabs/how-to/authentication/tab-sso-code.md
Service: msteams
GitHub Login: @surbhigupta
Microsoft Alias: lajanuar

@jouhami - Thanks for reporting this issue.
We will check it from our end and redirect to doc team accordingly.

@jouhami - How are you validating the app?
Can you please share the repro steps or reference doc?

We submitted the app in the Partner Center and the validation Team reported the issue

@jouhami - Regarding "consent pop-up is getting blocked by the browser"
Can you please share the screenshots for this error ?
Meanwhile, we will also try to setup the code and check on it.

Hi @jouhami - We tried with the below sample, and it worked as expected without blocking the consent popup as follows:

Here is a screenshot of the error :

I see you tested with the csharp sample while I am testing with the nodejs sample.
Please make sure your browser is not already allowing the pop-ups from the domain teams.microsoft.com.
Here is my browser settings for Pop-ups and redirects :

@jouhami -To avoid triggering the browser's popup blocker, app developers need to ensure that they only call authenticate API from the call stack of a user input handler (e.g. click, key press, etc.). That's discussed here:
https://docs.microsoft.com/en-us/microsoftteams/platform/tabs/how-to/authentication/auth-tab-aad#initiate-authentication-flow
The way this is typically achieved is by putting a "Sign in" button in the page when an auth popup needs to be shown and then calling the authenticate API only when the user clicks on the button.

@jouhami - We tried to repro the issue by following this sample as mentioned and we are getting same error.

We are checking this internally and will update accordingly.
However this sample works fine.

Does this mean that there is some actions we have to do from our end ?

Hi Prasad, can you please give us a link to this PR?

Hi @Benjiiim - PFB the PR Link
https://github.com/OfficeDev/Microsoft-Teams-Samples/pull/403

I don't understand how the changes in the PR should fix the problem. I always had the HTTPS=false during dev and we still have the issue.

Hello @jouhami - It's not only related to Https =  false but there are couple of more changes that we have added like we need to start one more server to make the application work.

@jouhami - Changes are merged, please verify once and let us know.

I just tried with the nodejs sample and still getting the error  with consent pop-up window blocked.

Hi @jouhami - We checked again at our end, and it worked as expected. Attaching the snapshot below:

Could you please make sure you have correctly configured the Application ID URI and scopes as mentioned in recently updated READ ME file? Please do re-verify.
https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/tab-channel-group-sso-quickstart/js#register-your-application-with-azure-ad

I just restarted from the beginning. Followed the instructions in the README to create the Azure application. Cloned the repo, updated the manifest with the Azure app Id and zipped the package. Still have the issue.

If I allow the pop-up in the browser settings the tab is working properly.
The main issue here is that we do not see the "Almost there pop-up" as chown in the comment above

I am facing the issue in Web client only. In Desktop/mobile I am getting the consent popo-up directly but the "Almost there" pop-up is never shown.

"Almost there" pop up shows up first time while signing it. It won't show next time onwards while using the tab.

"Almost there" pop up shows up first time while signing it. It won't show next time onwards while using the tab. It uses SSO to sign-in the user.

I agree. The user/admin has not consented yet so my understanding is that the "Almost there" pop-up should keep showing unless the user/admin consents to the requested permissions. Am I wrong ?

We tried without user/admin consent, but didn't get the "Almost there" pop-up.

Is it the expected behavior ? According to this comment the pop-up should show if we revoke consent.
Could you please share a link to the documentation about this pop-up if any ?

Please refer this doc: https://docs.microsoft.com/en-us/microsoftteams/app-permissions

Any updates about this issue ?

We checked at our end, and it worked as expected.

Is there any other update you want?

Yes please. I didn't get an answer for my question in this comment. You said that you don't see the "Almost there" pop-up even if the user/admin has not consented. Is it normal ? I checked other apps already published in the store and they are having the same issue (this application for example) : consent-pop up blocked by the browsers (Chrome, Edge and Firefox) and no "Almost there" pop-up is shown.

We will check with engineering team if this is expected or not and will get back to you.

Any updates ?

We are following up with engineering team. We will inform you once we have any update.
Thanks!

@jouhami - We got update from engineering team that " If the getAuthToken API returning a token, then the app must already have the necessary consent and AAD is issuing a token". This happens when your app is registered in the same tenant that it's being used in. Cross-tenant apps will always show a prompt unless the user or admin have already consented.

We are closing this issue for now. Please feel free to reopen if required. Thanks!


Dataset size on CLI

Description
Dataset size on CLI by fetching size on runtime
References
https://github.com/neulab/prompt2model/issues/253
Blocked by
NA

I tested this out and it seems reasonably fast (~0.1s per dataset) and accurate! While this will slow down our script by ~3 seconds for 25 datasets, I think that's ok.
+1 to Chenyang's point about API handling (e.g. we should have default behavior if there are exceptions, e.g. log the error and return NaN as the size).
Can you also add a test case for this? I can add the test in a separate PR if you're not sure how to go about doing this in our repo. I'd suggest you just test get_dataset_size by mocking the execution of prompt2model.utils.dataset_utils.query using the unittest.patch library.

@hitenvidhani Actually, it seems that something is not working correctly when I built and tested this locally. After starting dataset retrieval, I see:
Here are the datasets I've retrieved for you:
#	Name	Size[MB]	Description
{'size': {'dataset': {'dataset': 'yulongmannlp/dev_para', 'num_bytes_original_files': 31562059, 'num_bytes_parquet_files': 15014382, 'num_bytes_memory': 80443172, 'num_rows': 88661}, 'configs': [{'dataset': 'yulongmannlp/dev_para', 'config': 'plain_text', 'num_bytes_original_files': 31562059, 'num_bytes_parquet_files': 15014382, 'num_bytes_memory': 80443172, 'num_rows': 88661, 'num_columns': 5}], 'splits': [{'dataset': 'yulongmannlp/dev_para', 'config': 'plain_text', 'split': 'train', 'num_bytes_parquet_files': 14458314, 'num_bytes_memory': 79346108, 'num_rows': 87599, 'num_columns': 5}, {'dataset': 'yulongmannlp/dev_para', 'config': 'plain_text', 'split': 'validation', 'num_bytes_parquet_files': 556068, 'num_bytes_memory': 1097064, 'num_rows': 1062, 'num_columns': 5}]}, 'pending': [], 'failed': [], 'partial': False}
1):	yulongmannlp/dev_para	76.72	Stanford Question Answering Dataset (SQuAD) is a reading comprehension dataset, consisting of questions posed by crowdworkers on a set of Wikipedia articles, where the answer to every question is a segment of text, or span, from the corresponding reading passage, or the question might be unanswerable.
{'size': {'dataset': {'dataset': 'yulongmannlp/dev_orig', 'num_bytes_original_files': 31560015, 'num_bytes_parquet_files': 15012305, 'num_bytes_memory': 80441120, 'num_rows': 88661}, 'configs': [{'dataset': 'yulongmannlp/dev_orig', 'config': 'plain_text', 'num_bytes_original_files': 31560015, 'num_bytes_parquet_files': 15012305, 'num_bytes_memory': 80441120, 'num_rows': 88661, 'num_columns': 5}], 'splits': [{'dataset': 'yulongmannlp/dev_orig', 'config': 'plain_text', 'split': 'train', 'num_bytes_parquet_files': 14458314, 'num_bytes_memory': 79346108, 'num_rows': 87599, 'num_columns': 5}, {'dataset': 'yulongmannlp/dev_orig', 'config': 'plain_text', 'split': 'validation', 'num_bytes_parquet_files': 553991, 'num_bytes_memory': 1095012, 'num_rows': 1062, 'num_columns': 5}]}, 'pending': [], 'failed': [], 'partial': False}
2):	yulongmannlp/dev_orig	76.71	Stanford Question Answering Dataset (SQuAD) is a reading comprehension dataset, consisting of questions posed by crowdworkers on a set of Wikipedia articles, where the answer to every question is a segment of text, or span, from the corresponding reading passage, or the question might be unanswerable.

Thank you @viswavi, have pushed the requested changes, sorry about that print statement it was added for debugging.

Hey @zhaochenyang20 , thanks for the suggestion!
One counter-suggestion, because @hitenvidhani is a first-time contributor and we've already gone back-and-forth on this PR several times, maybe we can merge the PR for now and then do a follow-up PR for unit tests? Unit tests are important, but it's also important that we welcome new contributors (and we do!) so we can make the process a little simpler this time.

In this case, I gonna merge it and let us add unit tests ourselves. 🤔


Fix a variety of token.md doc inconsistencies; improve multi-sign nonce example

Improve the formatting of the examples in token.md.   Because many of the examples in the doc use multiline input, this change uses the 'console' key word in the markup to help distinguish input from output.   In cases where multiline input and output exists, we omit 'console' and the '$' symbol for the input, but include 'console' in the output.   This makes the coloring consistent and the text easier to read.
For the nonce multisign example, i pretty much rewrote the instructions because for whatever reason several steps were left out making the introduction really hard to understand.

Looks great, thanks so much for the contribution!


remove specific song from queue

Feature request: remove a certain song from the queue without having to wait for it to be played
Submitted by: jrueholidaystan
Server: gridlockstans!

resolved by #128


Get issuer and vc holder used in test data generation from test  config.

This will allow testers to specify the issuer and/or vc holder for generating the test data.

@TallTed I think I have addressed all the suggestions you've left. If it looks good to you, could you please give your approval.


Prevent BoM upload failure on failed builds

This is the same condition fix (with the same logic) that is applied in this PR Azure/azure-sdk-for-cpp#3256

/check-enforcer override


Instance vars should not be allowed on Class, Tuple, NamedTuple, Enum, Pointer , Proc, StaticArray and Union.

Hello
I found a bug playing with random things.
The following make crash the compiler:
class Class
  @x = 1
end
# => BUG: Class doesn't implement instance_vars (Exception)

Similar occurs with:
struct Tuple(*T)
  @x = 1
end
# => BUG: Nil assertion failed (NilAssertionError)

struct NamedTuple(T)
  @x = 1
end
# => BUG: Nil assertion failed (NilAssertionError)

For the following, the compiler doesn't crash but produce inconsistent code:
struct Enum
  getter x = 1
end

enum Foo;A;end

p Foo::A.x # => undefined behavior

struct Pointer(T)
  getter x = 1
end
p Pointer(Int32).malloc.x # => undefined behavior

struct Proc(*T, R)
  getter x = 1
end

p ->{}.x # => undefined behavior

struct StaticArray(T, N)
  getter x = 1
end

puts StaticArray[1, 2, 3].x  # => undefined behavior

struct Union(*T)
  getter x = 1
end
# we cannot test calling x on Union, but it should be unhallowed too

For other types where ivars should be forbidden, the compiler catch the error.
struct Int32
  @x = 1
end
# => Error: can't declare instance variables in Int32

As the fix for that was pretty simple, I send the PR meanwhile :)
I hope I don't forget types where ivars should be forbidden, but I thinks I check all of them.

I think a more concise definition is that instance variables are only allowed on proper subtypes of Reference or Struct. Not sure which one runs faster though.

Your right HertzDevil.
I tested implementing this way. It turned out that some Number like Complex or BigInt allows instance vars although there are not Struct.
So Numbers accept ivars unless the PrimitiveTypes, and unless Int and Float (which are not  PrimitiveType).
Ivars are also allowed on module of course.
The rule would be so "Instance vars are allowed on module and  on every type deriving Reference, Struct, or Number, except PrimitiveType, Float, Int and except  Reference, Struct, and Number themself".
And the implementation would be:
case self
when PrimitiveType, program.float, program.int,
  program.reference,
  program.struct,
  program.number
  false
when .module?,
     .implements?(program.reference),
     .implements?(program.struct),
     .implements?(program.number)
  true
else
  false
end

Unless I miss a simpler way ?
Definitely not sure it's going faster (we can probably play on test order also). But this have the advantage to be more robust if ever a new special type comes.
Do you prefer this implementation and I update the commit? Or we actually keep the previous?, thanks for the answer :)

Sorry for the awkwardness of my previous message, as a simple contributor, I prefer ask on alternative and show pros and cons rather than commit a thing which I would not known all implications.
In above, I wanted meant "What the better between I simpler and faster solution, or a more complex but semantically righter solution ?. Knowing that both are actually exact".
But personally, I thinks the simpler is better here.

I don't see anything awkward in your message :-)
I don't have an answer to your question. In this case, the set is sufficiently small to make the two solutions equally good to my eyes.

yes, let see merging to first solution so :)


No CLI after logging in with root and executing login command.

Proxmox version: 6.1-7
Hass OS Downloaded: 3.12
What happened: After booting for the first time, the homeassistant login appears. When I type in "root", it sends me to the "ha >" prompt. Typing in "login" sends me right back to the homeassistant login.
What's expected to happen: Root access to the VM's CLI.
Troubleshooting steps: Tried the script again, no dice.

Also experiencing this

Are you still experiencing this problem? I have attempted to recreate the issue and cannot.


Return error if failed to obtain auth token

In some cases, we fail to get the auth token, and continue to additional
requests that will fail. It is evident when using verbosity level 2:
connection.go:305] Sending POST request to 'http://localhost:9100/api/v2/authtoken/'.
connection.go:306] Request body:
{
"username": "admin",
"password": "password"
}
connection.go:330] Response body:
{
"detail": "The requested resource could not be found."
}
connection.go:252] Sending GET request to 'http://localhost:9100/api/v2/job_templates/?name=Start+node&project__name=My+project'.
connection.go:274] Response body:
{
"detail": "Authentication credentials were not provided."
}
Now we raise an error in those cases, and do not try any longer:
connection.go:305] Sending POST request to 'http://localhost:9100/api/v2/authtoken/'.
connection.go:306] Request body:
{
"username": "admin",
"password": "password"
}
connection.go:330] Response body:
{
"detail": "The requested resource could not be found."
}
alerts_worker.go:62] Error obtaining auth token

@jhernand https://github.com/openshift/autoheal/pull/24 Is a more general solution so we might want to continue with that direction or keep both.
The reason I'm getting a 404 is that in my server (AWX <IP_ADDRESS>) the auth endpoint is not as documented here:
http://docs.ansible.com/ansible-tower/2.3.0/html/towerapi/auth_token.html
But actually different:
My server has an additional unversioned oauth endpoint and does not have api/v2/authtoken/ or api/v1/authtoken/
{
    "oauth2": "/api/o/",
    "description": "AWX REST API",
    "available_versions": {
        "v1": "/api/v1/",
        "v2": "/api/v2/"
    },
    "custom_login_info": "",
    "current_version": "/api/v2/",
    "custom_logo": ""
}

That seems related to the recent https://github.com/ansible/awx/pull/904/files#diff-64d1ae443d41bb4ff887f175e05bc8d9L70
I thought the whole point in API versioning is to prevent that, meh
cc @elad661 @zgalor @ironcladlou

That seems related to the recent https://github.com/ansible/awx/pull/904/files#diff-64d1ae443d41bb4ff887f175e05bc8d9L70

So FYI

we WILL have to change auth code at some point
we might want to support both versions
we need to figure out which tower version we are expected to work with.

@moolitayer can you please open a new issue for the authentication problem?

https://github.com/openshift/autoheal/issues/25

@zgalor please review


how to do local-registration with data in vue?data must be function?

Please make sure to read the Issue Reporting Guidelines before opening new issues. The issue list only accepts bug reports and feature requests. Questions should be posted to the Gitter chat room,  forum or StackOverflow. Thanks.


remove #controller stuff from EIP DID doc resolution;

add EIP712Method during EIP signature verification;

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Mark McCracken seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Convert depscan and license findings to SARIF format

Scan currently use grafeas format for representing vulnerability and license audit findings. Converting this into SARIF format will make the information presentable on Inspect, GitHub code scanning and in our VS code extension.

This is not going to be possible. We will continue with the existing formats for now.


Gracefully handle return characters in api token

It's important that the collector doesn't break customer builds. If the buildkite api token includes a return character (i.e., \r or \n) the Python libraries throw an InvalidHeader exception, which would cause the process to error out. This patch gracefully handles the error so the customer's test suite doesn't fail.

Thanks for your contribution @swebb


rubucop 0.8 : carriage return

Under Windows, every line has a carriage return. The corresponding new cop should be disabled on Windows

Late for the party here, but I find this rule to be unexpected to be on by default for Windows. As normal git behaviour is to normalize line ending to default OS behaviour upon checkout. But upon check in they are normalized again.


Added option to run tests as a coroutine in an IOLoop instead of syncly

So that you can test things that occur in multiple parts of your program in the same time (i.e. a client and server), without the first one that tries to connect blocking.

Nice, I like it!


updated napari entry point and requirements

Codecov Report

Merging #5 (1fc5699) into main (e7a26db) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   93.79%   93.79%
=======================================
  Files           3        3
  Lines         258      258
=======================================
  Hits          242      242
  Misses         16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7a26db...1fc5699. Read the comment docs.

Codecov Report

Merging #5 (1fc5699) into main (e7a26db) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   93.79%   93.79%
=======================================
  Files           3        3
  Lines         258      258
=======================================
  Hits          242      242
  Misses         16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7a26db...1fc5699. Read the comment docs.


The experiments of task classification

Hi,
Thanks for sharing these interesting works.
When I loaded the best checkpoint to reproduce the results in the defect detection dataset, I got 61.75 ACC. File result.txt in google drive is also 61.78 ACC, while in the paper, the ACC is 63.18.
Is it the best checkpoint?
Thank you so much

Read the answer for Mismatch in performance reported in the paper and achieved using the released checkpoints from https://github.com/wasiahmad/PLBART#faqs.


E2E test fails with Synced=False resources with 'plan failed' errors in CI

What happened?
We have integrated an E2E testing flow which creates a cluster claim using this example and expect it to be ready after waiting enough.
This works fine with running the e2e target locally with:
export UPTEST_AWS_CREDS=$(cat ~/.aws/credentials)
make e2e

However, it fails with timeouts when we run it with GitHub Action CI. When I observe the resources, I am seeing that there are resources in Ready=True, Synced=False with the event observe failed: cannot run plan: plan failed. See the actions run for this PR for more details.

This is most probably due to limited compute resources with GitHub Actions runners and not a bug for platform-ref-aws but worths further investigation and we need a way to make this work for automated e2e testing.
How can we reproduce it?
Open a PR and add a comment with /test-e2e
What environment did it happen in?
GitHub Actions.
cluster-dump.zip

I have validated this issue is no longer happening with the latest Provider AWS version, which includes this PR.


Operator selection: starting version should fail on invalid version

What happened?
oc-mirror did not exit when an invalid starting version of an operator package was referenced. The resulting imageset did not include ANY versions of the specified operator.
What you expected to happen?
Invalid referenced versions should cause oc-mirror to exit with an error.

Related to #272

@david-rh Have any questions or need help with this?

Submitted PR #354


Feature Request: add attention utility functions like flax

It would be nice to split up the the MultiheadAttention Module code into utility functions for calculating attention weights and multihead attention without projection layers. Flax does this -- but would be nice to have it here as well.
https://github.com/google/flax/blob/main/flax/linen/attention.py#L40-L187

Sounds reasonable. I'd be happy to accept a PR doing this.

Hey, I'd be interested in picking this up as a first issue if that's alright!

Go for it!


[DO NOT MERGE] update wrapper version

Description
updating wrapper and tests
Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

bug in the wrapper fixed: https://github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper/pull/878

/run pipeline

Bug in the wrapper causes this test to pass on failure. working on fix, do not merge

closing letting renovate update

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

@daniel-butler-irl If the test wrapper config is ok here, and pipeline is only failing due to backend issue, lets proceed with a force merge here. I kind of want the updater wrapper to run in https://github.com/terraform-ibm-modules/stack-retrieval-augmented-generation/pull/208

/run pipeline

/run pipeline

/run pipeline

@daniel-butler-irl Not sure if you want to force merge, all deploys are successful it just failed on undeploy. Looks like its KMS still has key inside it and fails instance delete. Presumably this is an issue in the main branch too...

"Result": {
│         "details": "{"status_code":409,"name":"ConflictError","message":{"message":"CONTAINS_ACTIVE_KEYS: Remove all keys before de-provisioning: Instance contains 2 active keys","name":"ConflictError","status_code":409,"transaction_id":""},"description":"CONTAINS_ACTIVE_KEYS: Remove all keys before de-provisioning: Instance contains 2 active keys"}",
│         "error_code": "RC-ServiceBrokerErrorResponse",
│         "message": "Please contact the Service Provider for this error. [409, Conflict] CONTAINS_ACTIVE_KEYS: Remove all keys before de-provisioning: Instance contains 2 active keys",
│         "status_code": 422,
│         "transaction_id": "626c-8f564977efde97e1"
│     },

:tada: This PR is included in version 2.0.1 :tada:
The release is available on:

GitHub release
v2.0.1

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.1 :tada:
The release is available on:

GitHub release
v2.0.1

Your semantic-release bot :package::rocket:


Questions about the Logics to Select GPU Cards

Hello, I have some questions about the logic of selecting GPU cards:

In method Rate, the score is defined as below:
https://github.com/elastic-ai/elastic-gpu-scheduler/blob/87e3fa4e1d1ac9a47007cd727a0e6e55ae378816/pkg/scheduler/rater.go#L48-L49

In this formula, the score is defined as range / number of allocated GPUs.
Is this the best objective function that can exactly reflect the Binpack policy, or is it only an approximation?
Will it be better to use variance as the score?

In the stages of Assume/Score/Allocate, a map is used to cache the scheduling result, which is defined as allocated map[string]*GPUOption.
And the key of this map is defined as the hash of GPURequest:
https://github.com/elastic-ai/elastic-gpu-scheduler/blob/87e3fa4e1d1ac9a47007cd727a0e6e55ae378816/pkg/scheduler/node.go#L62-L64

If two pods' GPU requests are same, will it cause a confilct?
Otherwise, can we suppose that they can share the same scheduling result?
Will it be better to use pod's UID as the key of this map?

Thanks for any reply!

@xiaoxubeii @borgerli @payall4u hello, could u please help with this question? 🙏

Rate method
1.1 Is this the best objective function that can exactly reflect the Binpack policy, or is it only an approximation?
Actually it is an very vague approximation. We assume that the binpack will intend to make resource distribution uneven. To be honest, it is a rough algorithm.
2.2 Will it be better to use variance as the score?
Variance is a good algorithm.

GPURequest conflicts
It is fine because it has not been allocated before Bind. So we can allow same GPURequest to grab same option.


Use new p2p api

use new p2p interface.

@leeyr338 You are in charge of this pr.

@driftluo  please review the handling of new added error or event

This PR will fixed bug issue : https://github.com/cryptape/cita/issues/472

May be this pr need wait for p2p libary stable, then can be merged.
now version is tentacle = "0.2.0-alpha.4"

May be this pr need wait for p2p libary stable, then can be merged.
now version is tentacle = "0.2.0-alpha.4"

@driftluo , when will tentacle stable?

when will tentacle stable?

For now, the codec of the discovery protocol has stabilized.
But, there has some possibilities for fine-tuning specific behaviors, this does not affect the communication of the protocol.
At the same time, maybe the API will have minor adjustments, this is uncertain.

when will tentacle stable?

For now, the codec of the discovery protocol has stabilized.
But, there has some possibilities for fine-tuning specific behaviors, this does not affect the communication of the protocol.
At the same time, maybe the API will have minor adjustments, this is uncertain.

I see, so I think is OK to use 0.2.0-alpha.4 for CITA v1.0.0-alpha.


Cannot detect jump table over writable data

For what its worth, I am seeing a similar problem. For myself, its because at the moment of the bctr, the value for the control register cannot be determined. I'm working on the best way I can to broaden the possible values for the submitted control register. In your case, it seems like the r4 register's value may not be able to be determined, while in mine its r0. Without it being able to get a solid for possible reg values, I'm guessing its just gonna assume that the jump table has infinite scope and eat it.
Temporarily resolution: https://github.com/v1X3Q0/jump-table-branch-editor

For what you can see that in this case, r0 is supposed to be something from index void**[0-7], but binja is considering that the value is undetermined for it.

Originally posted by @v1X3Q0 in https://github.com/Vector35/binaryninja-api/discussions/2270#discussioncomment-11219294

Is it possible to share the binary with us?

Absolutely! I've been using a gamecube binary that I shared with @galenbwill
Clonewars.zip
Feel free to hop on over to 0x801a6bc0 as shown in the images. You will see other blocks where disassembly failed in the middle of the binary for similar reasons.

The dataflow analysis is correct up until the selected line:

r3 has the ConstantPointerValue 0x8035b000, and r0 has UnsignedRangeValue {0x0 : 0x1c: 0x4}. However, we are not calculating the value of [r3 + r0].d. If we look at the target area, it looks valid pointers:

The reason for the failure is that the target area is writable, which makes the analysis not creating the jump table
Here is a workaround for now:

Navigate to 0x8035b000, and change the type of the data variable to void const* const @3175[0x8]
(Optional) undefine the functions at 0x801b0f9c, etc (which are targets of the jump table), so that the code shows up in the switch-case, rather than being a tailcall

It looks correct after applying my changes

That definitely did it! Thank you, is that something that will be merged into dev soon? Nice solution!

That definitely did it! Thank you, is that something that will be merged into dev soon? Nice solution!

Sorry I am not sure what you are referring to when you say "be merged into dev" soon. I did not propose a possible way for it yet. Also, the chances are we will leave it as is since if we relax it, it will cause other issues

I see I see... ah well, I appreciate the help than. That's a neat solution. I'll see if someday I can have a solution, but in the meantime thank you.

Maybe someday it will present itself as more annoying, til then thank you.

I am re-opening this for internal disucssion


[1.7.10]Low tps problem

Version of Advanced Rocketry
AdvancedRocketry 1.7.10-1.4.0-16-UNSTABLE build -16 for 1.7.10
Have you verified this is an issue in the latest unstable build
Y
Version of LibVulpes
LibVulpes-1.7.10-0.2.8-34-universal
Version of Minecraft
1.7.10
Crash report or log (if applicable)
Mods Info: https://www.dropbox.com/s/iols5yvmicasq0n/ModpackInfo.txt?dl=0
Description of the problem
Game tps became very low after installing AR. I'm also keeping testing.

It's a conflict with DoggyStyle.

Log: https://www.dropbox.com/s/f4ejo087rtgm79v/fml-client-latest.log?dl=0


Add navigation and hero section

This PR is deprecated. All further changes are in  #21 .

This PR is deprecated. All further changes are in https://github.com/technologiestiftung/innovationserhebung/pull/21 .


support for dataviews

Is your feature request related to a problem? Please describe.
dataviews (see popular obsidian plugins) are not rendered within the presentation.
Describe the solution you'd like
The output of dataviews are rendered within the presentation, i.e. if you write
LIST
FROM #todo

results in a list of entries with the appropriate tag.
Additional context
Left: Markdown (correctly rendered)
Right: Presentation (not rendered)

I'd like to second this request, with the addition of support for dataviewjs as well. There is a an option in Dataviewjs to render the tables into markdown: https://blacksmithgu.github.io/obsidian-dataview/api/code-reference/#markdown-dataviews
So in theory it would "just" require to pipe this into a reveal.js view to render it. My javascript & typescript skills are unfortunately too limited to help crafting this.
The application I'm interested in: automatically creating summary slides for project management meetings. I can create the page views with dataviewjs already, it could then be neatly presented in meetings as slides with your great plugin.


[Bug][Hexagon] Relax Hexagon integration tests pass in simulator but fail on device

Relax Hexagon integration tests are failing on Hexagon device but passing in simulator.
Repro
To repro you will need to have access to hexagon device.
Follow the instructions to compile TVM and setup to run hexagon tests.
./tests/scripts/task_python_hexagon.sh

Right now it gets stuck at
19:12:14  tests/python/contrib/test_hexagon/test_relax_integration.py::test_conv2d
19:12:14  [gw0] RERUN tests/python/contrib/test_hexagon/test_relax_integration.py::test_conv2d
19:12:14  tests/python/contrib/test_hexagon/test_relax_integration.py::test_conv2d
19:12:14  [gw0] RERUN tests/python/contrib/test_hexagon/test_relax_integration.py::test_conv2d
23:12:02  tests/python/contrib/test_hexagon/test_relax_integration.py::test_conv2d Sending interrupt signal to process
23:12:05  script returned exit code 143

@psrivas2 oh sorry, I didn't notice that I closed it. Thanks for reopening it.


buf generate fails on windows with 'node_modules' is not recognized...

Describe the bug
I'm trying to follow the instructions on connect.build to build my company's protos into a TS grpc client for use in browser (not nodeJS).
When I run buf generate I get the following error message:
> buf generate
'node_modules' is not recognized as an internal or external command,
operable program or batch file.
'node_modules' is not recognized as an internal or external command,
operable program or batch file.
'node_modules' is not recognized as an internal or external command,
operable program or batch file.
'node_modules' is not recognized as an internal or external command,
operable program or batch file.
'node_modules' is not recognized as an internal or external command,
operable program or batch file.
'node_modules' is not recognized as an internal or external command,
operable program or batch file.
'node_modules' is not recognized as an internal or external command,
operable program or batch file.
'node_modules' is not recognized as an internal or external command,
operable program or batch file.
'node_modules' is not recognized as an internal or external command,
operable program or batch file.
'node_modules' is not recognized as an internal or external command,
operable program or batch file.
'node_modules' is not recognized as an internal or external command,
operable program or batch file.
'node_modules' is not recognized as an internal or external command,
operable program or batch file.
'node_modules' is not recognized as an internal or external command,
operable program or batch file.
'node_modules' is not recognized as an internal or external command,
operable program or batch file.
'node_modules' is not recognized as an internal or external command,
operable program or batch file.
'node_modules' is not recognized as an internal or external command,
operable program or batch file.
Failure: plugin es: exit status 1; exit status 1; exit status 1; exit status 1; exit status 1; exit status 1; exit status 1; exit status 1

To Reproduce
buf.yaml
version: v1
deps:
  - buf.build/googleapis/googleapis
breaking:
  use:
    - FILE
lint:
  use:
    - DEFAULT

buf.gen.yaml
version: v1
plugins:
  - name: es
    path: node_modules/.bin/protoc-gen-es
    out: dist
    opt: target=ts
  - name: connect-web
    path: node_modules/.bin/protoc-gen-connect-web
    out: dist
    opt: target=ts

buf.lock
# Generated by buf. DO NOT EDIT.
version: v1
deps:
  - remote: buf.build
    owner: googleapis
    repository: googleapis
    commit: 80720a488c9a414bb8d4a9f811084989

With the above setup, I open git bash (I tried it in powershell as well, with the same results), run buf generate and get the error message I see above at the top of the ticket.
Environment (please complete the following information):
    "@bufbuild/connect-web": "^0.1.0",
    "@bufbuild/protobuf": "^0.1.0"
    "@bufbuild/protoc-gen-connect-web": "^0.1.0",
    "@bufbuild/protoc-gen-es": "^0.1.0",

node version v16.13.1
yarn version 1.22.18
npm version 8.1.2
Additional context
Can confirm I have the expected executables in my node_modules dir

Updated our docs to more prominently suggest the "scripts" approach.  In addition, added text for users who want to use protoc from the command line, with links to our protoc-gen-connect-web README.
View the docs here:  https://connect.build/docs/web/generating-code#local-generation
Hopefully this makes things a bit more clear.


Add PackingPlanBuilder

Adds PackingPlanBuilder to fix #946. This reduces almost all container state management code (i.e., map/list manipulation) from the packing algorithms and leaves just the algorithm logic itself.
There are a few more edits I'd need to make (possibly in others PR) but wanted to share this to get feedback on the approach:

Add checking that all required setters were called before adding/removing instances (DONE)
Packing.pack and Packing.repack should throw PackingException instead of returning null. I'd do this in another PR.
Some of the PackingUtils code is now only used by PackingPlanBuilder, so it could move there as internal utils.
Some unit tests for just PackingPlanBuilder.

cc/ @avflor @ashvina @maosongfu

I've addressed all the TODOs in the diff except for throwing PackingException unstead of returning null, which I'll do separately. I've also simplified methods that are now redundant and the PackingPlanBuilder implementation. Let me know if there are additional comments. This is ready to commit IMO.

@avflor @ashvina - can you let us know if you have any comments?

LGTM 👍


Downloading fails with large QA Tile files

While label-maker download mbtiles for united_states_of_america casues  Invalid argument as follows:
File "/Users/xxx/xxxx/label-maker/label_maker/download.py", line 32, in download_mbtiles
    w.write(r.read())
OSError: [Errno 22] Invalid argument

after the mbtiles has showed be downloaded.

same for russia

@Geoyi as temporary solution you may download mbtiles directly
https://s3.amazonaws.com/mapbox/osm-qa-tiles-production/latest.country/united_states_of_america.mbtiles.gz
it works for me

Thanks, @Ashot-KR, glad that works for your case.

Closed via #47


Add current FEC wf in as is  as reference

Description
Provide a brief description of the PR's purpose here.
Fixes #368
We need to have a reference copy of the FEC workflow in whatever state it is currently used in so that we can all improve on it collaboratively.

Tagging @ijpulidos @jthorton, I will probably collect the above in some issues for us to discuss.

I will merge regardless sometime tommorow.

Codecov Report

Merging #369 (04f64ae) into main (b9e7112) will decrease coverage by 0.04%.
The diff coverage is n/a.

Merging, but if anyone has comments feel free to make an issue or add to existing issues #372, #373


Limits for scraping followers?

Are there any limits for scraping followers? If yes, how to get around them...?
I am trying to scrape followers for profiles that have around 30k - 50k followers each. At the beginning it's working smoothly, but after scraping 198 accounts it freezes and stops. When i CTRL+C and try to launch the script again, i can see this error:
0.6459672451019287
0.6380813121795654
0.6969287395477295
0.5864517688751221
10:55^CERROR [2019-03-09 10:55:34] Follower is empty
INFO [2019-03-09 10:55:34] alias name: Surfakademin
INFO [2019-03-09 10:55:34] bio: Surfakademin is a passion driven surf travels company with surfcamps all over the world, year around. The summer never ends. Live. Love. Surf.
INFO [2019-03-09 10:55:34] url: www.surfakademin.se
INFO [2019-03-09 10:55:34] Posts: 1541
INFO [2019-03-09 10:55:34] Follower: 17603
INFO [2019-03-09 10:55:34] Following: {'count': 1723}
INFO [2019-03-09 10:55:34] isPrivate: False
Error with user surfakademin
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/urllib3/connection.py", line 141, in _new_conn
    (self.host, self.port), self.timeout, **extra_kw)
  File "/usr/lib/python3/dist-packages/urllib3/util/connection.py", line 83, in create_connection
    raise err
  File "/usr/lib/python3/dist-packages/urllib3/util/connection.py", line 73, in create_connection
    sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused

When i re-launch the script, this is what i get:
user@vps:/var/crawl# python3 crawl_profile.py surfakademin
Extracting information from surfakademin
security code accepted
logged in
INFO [2019-03-09 10:39:04] Extracting information from surfakademin
INFO [2019-03-09 10:39:05] Extracting follower from surfakademin
Unexpected error: <class 'IndexError'>
list index out of range
ERROR [2019-03-09 10:39:36] Cannot get Follower List

Anyone know what's wrong w this issues. I also got same problem.

I also getting the same problem. Can someone help?


Update sync.py

Error accessing variable 'gar_wg_state' when only using Withings blood pressure device.  Moved set_lastsyn() under reach fit_data if statements so the other variable isn't used..
UnboundLocalError: cannot access local variable 'gar_wg_state' where it is not associated with a value

Oh, I see what's going on here.  This most likely also explains the duplicate entries we see sometimes in the blood pressure stats.
There is no need to duplicate the code block, just declare both variables at the start of the function.
Try something like this:
        # Upload to Garmin Connect
        if ARGS.garmin_username and (
            fit_data_weight is not None or fit_data_blood_pressure is not None
        ):
            logging.debug("attempting to upload fit file...")
            gar_wg_state = None
            gar_bp_state = None

@stynoo thanks, that is cleaner than my approach, and I can confirm it works when syncing only BP data. (I don't own the scale)

lgtm!


correct solution not accepted

Challenge Add Different Padding to Each Side of an Element has an issue.
User Agent is: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.89 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

margin

padding

padding

Hi @anudeepsamaiya. Unfortunately that is not a correct solution.
Please remember to visit the Help chat room when you are having problems with code for the HTML5 and CSS challenges before raising an issue.
Happy coding!

I also have had issues with the client just seeming "fussy" and not always wanting to accept correctly formatted solutions. I think there might just not be a lot of attention being given to this because it's a free course.

@harmoniousjoe this challenge don't have an issue.  since anyone and I could pass this challenge.  it seems you need a help with this challenge. Please use the Help chat room
Happy Coding.


Tecno comfenalco

https://tecnologicocomfenalco.edu.co/

@dittuxdev I am sorry, I have to close the request without merging, because you made a mistake in a request and requested to merge too many files, most of them do not relate to the organization which you would like to add to this repository. Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for understanding!

@dittuxdev I am sorry, I have to close the request without merging, because you made a mistake in a request and requested to merge too many files, most of them do not relate to the organization which you would like to add to this repository. Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for understanding!


Improve Testing API

Closes #157
Testing
For elements Sink and Source of Membrane.Testing workspace there are defined unit tests. Pipeline is tested in integration with Assertions, but Assertions do have sad path tests which are unit tests. Assertions are tested not only to test the behavior but also to force macros residing in Assertions module. If they are not compiled at least once there is no guarantee they will work.
Possibilities of future improvement
Membrane.Testing.Assertions.assert_message_receive/4 could be replaced with custom assert receive so that messages can be tailored to needs. For example assert_sink_processed_buffer/4 could list only buffers that got received and not other messages in case of failure.
Suggested review order

[ ] testing API interface
[ ] testing pipeline implementation
[ ] test Source and Sink implementation
[ ] assertions implementation and tests

Please read comments annotated by # Note: and comments on github.

Can you also update tests using this in an element? e.g. Tee?

Can you also update tests using this in an element? e.g. Tee?

Yes


Installation issues

I am working on a Windows 7 machine and attempting to install and run GPflow.
So far I have just run:

pip install tensorflow
pip install gpflow

There were no issues there as far as I can tell. But if I try and run a code snippet which only contains:
"from gpflow.model import GPModel"
I get the error,
PS C:\Users\tmb14164\Documents\StrathcloudSync\Personal Folders\Python> python .\snippet.py
Traceback (most recent call last):
File ".\snippet.py", line 1, in
from gpflow.model import GPModel
ModuleNotFoundError: No module named 'gpflow.model'
PS C:\Users\tmb14164\Documents\StrathcloudSync\Personal Folders\Python>
Is there some path setting that I need to have done?
Sorry this is probably a bit of a noob question!

Apologies, it seems that the code snippet and program I am trying to run (for streaming sparse GPs https://github.com/thangbui/streaming_sparse_gp) is for gpflow 0.4.0 and not compatible with the current gpflow version.


Add needed objects and resources

Add CustomerioAPI::Client
Add Customer, CustomerioObject and ObjectRelationship resources
Add spec files

@linhho0702 Are you gonna add the V2 resource into the same gem?

Member

I actually haven't thought of this. But I think we can also add v2 resource to this gem to keep everything in the same place.
If doing that, we need to specify the API version when initializing the client:
client = Customerio::Client.new(api_key: ENV['CUSTOMERIO_API_KEY'], version: 2)

Then based on the version, we can get the correct BASE_URL:

v1: https://api.customer.io/v1/
v2: https://track.customer.io/api/v2/

What do you think? @andychongyz

Member

I actually haven't thought of this. But I think we can also add v2 resource to this gem to keep everything in the same place.
If doing that, we need to specify the API version when initializing the client:
client = Customerio::Client.new(api_key: ENV['CUSTOMERIO_API_KEY'], version: 2)

Then based on the version, we can get the correct BASE_URL:

v1: https://api.customer.io/v1/
v2: https://track.customer.io/api/v2/

What do you think? @andychongyz

I think that works!


Better Examples and Documentation for Dynamic Dockables

Just spent some time trying to make these work and I don't remember how it works and seems to fail to load because the dockable is not registered. I have some dynamic panels that are registered with a random UUID as the persistent ID.

Hmm, I was just reviewing how I did this, since I have it working in my old app.
It looks like I was persisting the dynamic part of the dockable as part of the persistent id, then parsing the ID to get the dynamic part back (in this case a file path).
    @Override
    public String getPersistentID() {
        return historyMode ? getLicenseID() + ":" + getHistoryFile() : getLicenseID();
    }

Perhaps there is a better way....


Compatibility with PowerBI service

Looks like LibPQ can not be used in PowerBI service because of providing dynamic arguments to Web.Content(). This page is the place to discuss, develop and test possible workarounds.
Important
I have no account with PowerBI service, so I will need outside help to do the tests
Roadmap

[x] Describe the testing sequence (@sio)
[ ] Test LibPQ 1.2.0 with PowerBI service (@spythan?)
[x] Modify loader to use static base URL with Web.Contents (@sio)
[ ] Test modified version of LibPQ with PowerBI service (not assigned)
[ ] Write documentation on using LibPQ with Power BI service

Testing LibPQ with PowerBI service
this article has not been written yet

I have made some changes in the main LibPQ module. Now it uses static base URLs for web modules. If PBI service performs its checks at runtime, that should be enough. If it runs checks only once at import, we will need to define some hacky no-ops in the LibPQPath.
@spythan, please test both old and new LibPQ with the PowerBI service. Thank you very much!

Mate I just saw these updates, I will review and answer in a couple of days!

I tested both master and pbi-service versions as requested, both are working!
I also published a test project report online, connecting to external sources, and it works just fine.
When I first asked I wasn't even thinking about that Web.Content() detail to be honest, even though i happened to have read those articles.
Having little experience with all these tools I was trying to find a way to access my files on the cloud service, and hadn't realized that using a private online repository to access the code would probably be a good solution, since credentials seem to be managed safely.
At the time I was thinking of somehow uploading the files in scope of Power BI Service, like OneDrive or something.
Regarding Scheduled Refresh though, this message appears:
(both versions since it's unrelated)

Currently I have some ground to cover in my project before needing to solve this problem, but will probably come back to it when I need it. Any of your suggestions are very welcome.
For future reference, this resource will probably come in handy.

Thank you very much!
The fact that local paths still work surprises me, but I'm not familiar with caching mechanisms PBI service uses. Could it be that by default it just publishes the results you've calculated locally unless you "force" the refresh in some way?
I'm pretty busy this week but I'll try to look more into this next week.

I have much more information on PBI Service.
Because Refresh button isn't deactivated , nor any visual feedback if no refresh is actually ran, in PBI Service, I didn't realize that in my case the queries weren't running again at all, I only had the original data. That happened because refresh wasn't really enabled at all.
I set up both personal and enterprise gateways - a gateway is required if you want to refresh a on-premises source, like database, in PBI Service.
Using either of those, I was able to refresh data and set-up automatic refresh for a cloud dataset connected to my database through the gateway.
Only specific sources are supported for refresh though, as stated in the previous link, and I don't know what a query containing a LibPQ module import gets classified as, but it doesn't know how to refresh it, so you get this message:

I found more info in the Refresh History pane after failed manual refresh attempts:

So that's where we stand :smiley:

Well... I'm stuck.
I've signed up for the free tier of Power BI service and have gotten the same results as you. Looks like PBI service needs to be able to statically analyze the destination of each Web.Contents call in each query. The changes in the pbi-service branch are a step in the right direction, but it's not enough. Selecting which base url to fetch at runtime is not allowed at all and PBI service does not fall for the tricks that I have thought of before.
Here is the smallest demo of failing query:
let
    Choices = {"https://google.com", "https://github.com"},
    Random = Number.Round(Number.RandomBetween(0,1), 0),
    Address = Choices{Random},
    Lines = Lines.FromBinary(Web.Contents(Address))
in
    Lines

Same as with LibPQ it is not possible to detect which address will be fetched without executing the code. So PBI service plain out forbids executing it. I hoped that there would be a way to mark all possible destinations as allowed but PBI service does not seem to execute any of its checks at runtime.
Currently I see the following options:

Find/create user voice suggestion and hope that Microsoft will make some changes to PBI service
Somehow modify LibPQ to (optionally) use only a single module source and to pass its address statically everywhere

I will think about this issue some more and will come back here next week.

I have made another attempt at this and have failed again.
Turns out PBI service does not allow some functions/expressions in refreshable queries period, no matter the clever hacks and conditional no-ops.
Smallest demo of non-working query:
if false then Record.FieldNames(#shared) else "hello world"

This line will make the whole dataset non-refreshable in PBI service. Same as with #shared in the example above, "unsafe" invocations of Web.Contents, File.Contents are not allowed at all, even if they are statically verifiable never to be executed.
At this point I'm out of ideas on how to reconcile the service's restrictions with current LibPQ loader. I believe it is still technically possible to load LibPQ modules into PBI service, but the loader for the service may not be the same as for standalone workbooks and will have less functionality than the main loader.
As I'm not seeing much demand for this feature, I'm putting this issue on hold. Everyone is welcome to contribute the alternative loader though. If there are volunteers I can offer my expertise and try to answer any encountered questions.

I believe that #shared execution is blocked on the Power BI Service. This issue was discussed somewhere on the Power BI/Power Query TechNet forums (cannot find an exact link), and Matt Masson mentioned that somebody in the earlier ages of PQ decided to do not allow #shared use in the Service by some security concerns. So, any library/function which requires the use of #shared via Expression.Evaluate or by other way won't work in the Service (but still can work in Desktop or Excel)

I'm not sure if how many things in this library prevent it from running in the Power BI Service, but at least I have a solution for Web.Contents. To make sure functions pass static parameters to Web.Contents' you can use decorator pattern and accept contents` function as the first parameter.
WiqlRunQueryById = (
    contents as function,
    url as text,
    scope as record,
    id as text,
    optional options as record) as table =>
        let

Then, when clients wants to use this function they have to define contents function with static site root.

let
    url = "https://stansw.visualstudio.com",
    collection = "",
    project = "vsts-open-in-powerbi",
    team = "vsts-open-in-powerbi Team",
    id = "d5349265-9c9d-4808-933a-c3d27b731657",

    // Create wrapper for VSTS.AccountContents function as a workaround for the static code analysis in Power BI Service.
    contents = (o) => VSTS.AccountContents(
        url,
        [
            Version              = Record.FieldOrDefault(Record.FieldOrDefault(o, "Headers", []), "Referer", ""),
            IsRetry              = Record.FieldOrDefault(o, "IsRetry", false),
            ManualStatusHandling = Record.FieldOrDefault(o, "ManualStatusHandling", {}),
            Query                = Record.FieldOrDefault(o, "Query", []),
            RelativePath         = Record.FieldOrDefault(o, "RelativePath", null),
            Timeout              = Record.FieldOrDefault(o, "Timeout", null)
       ]),

    Source = Functions[WiqlRunQueryById](contents, url, [Collection = collection, Project = project, Team = team], id)
in
    Source

The obvious drawback is that this is more complicated than a simple call to a function, but the unquestionable advantage is that it passes all the checks and works everywhere.
I used this approach successfully in my PQ library for interacting with Azure DevOps.
https://github.com/stansw/vsts-open-in-powerbi/blob/master/pq/Functions.VSTS.txt

Oh, that's clever! Thank you for sharing with us!
Unfortunately, as @hohlick has pointed out, Web.Contents is not the only
problem with using LibPQ in PBI service - #shared is also essential. So the
overall issue remains unsolved.
You've got us one step closer though! That's cool! :-)

I don't think that #shared will be enabled in PowerBI service. It would allow you to enumerate over all the functions including functions from non-public modules. You will need to find a different way :(


Aquamarine 0.3.x is broken

When I use aquamarine = "0.3.2" the Mermaid diagram does not render and instead shows this error:

You can also see this on the demo crate when you go to the latest version. The demo crate docs.rs links for versions 0.2.0 up to and including 0.3.0 are broken (build failed), but when testing in my own repo I can say that 0.3.0 is also broken but 0.2.2 works fine.

It looks like mermaidjs update doesn't allow dots inside inline strings anymore:
This doesn't work
/// ```mermaid
/// graph LR
///     s([Source]) --> a[[aquamarine]]
///     r[[rustdoc]] --> f([Docs w/ Mermaid!])
///     subgraph rustc[Rust Compiler]
///     a -. inject mermaid.js .-> r
///     end
/// ```
///

ERROR :  Error parsing Error: Lexical error on line 5. Unrecognized text.
... a -. inject mermaid.js .-> r    end

This works
/// ```mermaid
/// graph LR
///     s([Source]) --> a[[aquamarine]]
///     r[[rustdoc]] --> f([Docs w/ Mermaid!])
///     subgraph rustc[Rust Compiler]
///     a -. "inject mermaid.js" .-> r
///     end
/// ```
///

I'll update the demo examples with a fix, but otherwise there doesn't seem to be a bug to fix, it's just the mermaid definitions that are broken

Fixed in 0.3.3


Specify Cache Directory in Azure DevOps

PR Type:
Bug fix

PR Description:
This PR aims to resolve an issue with the Azure DevOps cache directory in AWS Lambda. The execution user in AWS Lambda lacks write permissions to the home directory, which was causing problems. To fix this, the cache directory for Azure DevOps has been explicitly set to '/tmp/.azure-devops/python-sdk/cache'.

PR Main Files Walkthrough:
 files:

pr_agent/servers/serverless.py: An environment variable 'AZURE_DEVOPS_CACHE_DIR' has been added and set to '/tmp/.azure-devops/python-sdk/cache'. This change ensures that Azure DevOps uses the specified directory for caching, avoiding permission issues in AWS Lambda.

/describe

Thank you for the question.
I also believe that it should be defined externally.
On the other hand, I am uncertain whether it is appropriate to define this issue in configuration.toml as a global application setting, considering that it is a serverless-specific problem.
I think there are other ways as well:

Add instructions to the Installation Guide to set AWS Lambda environment variables (without modifying the code.)
Define it in Dockerfile.lambda as an ARG with default values (allowing override with build args).

Which method would be appropriate?

Thank you for the question.
I also believe that it should be defined externally. On the other hand, I am uncertain whether it is appropriate to define this issue in configuration.toml as a global application setting, considering that it is a serverless-specific problem.
I think there are other ways as well:

Add instructions to the Installation Guide to set AWS Lambda environment variables (without modifying the code.)
Define it in Dockerfile.lambda as an ARG with default values (allowing override with build args).

Which method would be appropriate?

Personally, I agree with the first one, but you can also listen to the owner. Does pr-agent have a division of owner CR?

Thank you, I'll limit the updates to the Installation Guide for now.

/describe

/review

@mrT23 Excuse me, may I ask how your Git Action above triggers PR Analysis work?
🌹

@mrT23 Excuse me, may I ask how your Git Action above triggers PR Analysis work?
🌹

https://github.com/Codium-ai/pr-agent/blob/main/INSTALL.md#run-as-a-github-action
https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-action
if you are referring to the labels 'Review effort', see
https://github.com/Codium-ai/pr-agent/blob/main/.pr_agent.toml#L2

@koid
i dont understand this PR.
how 'AZURE_DEVOPS_CACHE_DIR` is related to lambda function deployed on AWS ?

@koid is this PR alive, or should I close it ?
i repeat my question - how 'AZURE_DEVOPS_CACHE_DIR` is related to lambda function deployed on AWS ?

I'm sorry, I noticed the mention late.
In azure-devops, if the cache directory is not explicitly specified, it will be created under the home directory of the executing user.
In the case of AWS Lambda, the executing user does not have write permissions for the home directory, leading to a failure in creating the cache directory.
To address this issue, instructions on specifying a path where the executing user has write permissions as the cache directory are added to the README.

@koid
I still dont understand this PR.
How AZURE_DEVOPS_CACHE_DIR  is related to AWS lambda  ?
Maybe it is a very specific use case, but it is not a general instruction for any AWS lambda .
Share a more logical and coherent instruction in order for it to be merged

This is not a specific use case but a common limitation in Lambda.
https://docs.aws.amazon.com/lambda/latest/dg/images-create.html#images-reqs

The container image must be able to run on a read-only file system. Your function code can access a writable /tmp directory with between 512 MB and 10,240 MB, in 1-MB increments, of storage.

As a prerequisite, in AWS Lambda, writable directories are restricted to those under /tmp. (Directories other than /tmp are treated as read-only.)
The pr-agent supports Azure DevOps as a git provider, but the Azure DevOps library requires write permissions to local storage for caching purposes.
When importing azure.devops.connection.Connection, the Connection class attempts to create a Cache directory. If the Cache directory is not in a writable area, an issue error will occur.
https://github.com/microsoft/azure-devops-python-api/blob/7.1.0b3/azure-devops/azure/devops/connection.py#L9
https://github.com/microsoft/azure-devops-python-api/blob/7.1.0b3/azure-devops/azure/devops/_file_cache.py#L114-L115
If the import of the Connection is done within the AzureDevopsProvider class, it is possible to avoid errors when not using the Azure DevOps provider. However, since the import is done outside the AzureDevopsProvider class, errors will still occur even if the Azure DevOps provider is not being used.
https://github.com/Codium-ai/pr-agent/blob/fe796245a3c43a042d70efc86e8f53c8a0137247/pr_agent/git_providers/azuredevops_provider.py#L12
https://github.com/Codium-ai/pr-agent/blob/fe796245a3c43a042d70efc86e8f53c8a0137247/pr_agent/git_providers/__init__.py#L8
To avoid this, you need to specify AZURE_DEVOPS_CACHE_DIR to a writable directory (or you can specify it to /tmp, which is a writable directory under HOME) as a workaround.
--
Perhaps, in terms of chronology, Lambda support was added first (#92), followed by the Azure DevOps Provider support (#265), which might explain why the Lambda specifications were not taken into consideration during #265.

@koid
thanks for the detailed explanation
i will add a link to that explanation in the readme, since without it, it won't be clear how the things are connected


Disable Facter plugin if yaml import fails

Currently if the yaml module is not installed startup of jsonstatsd will fail.
This commit wraps the import of yaml with a try/except block that allows the
constructor to detect the failure and disable the plugin rather than
propagating the ImportError exception.

Love it. Thanks!


Writing functions and more

Thanks for merging my previous tiny contribution ("permissive=True")! :)
I want to add writing functions (napari_get_writer, napari_write_image) to the plugin, as well as a dock widget with volume and/or slice histograms. The plugin name however is mrcfile-READER so I don't know whether you see it as an appropriate addition or whether it's out of scope and you'd prefer me to make a new separate plugin. Please let me know your thoughts.

@the-lay pleasure! great to work with you 🙂
@Croxa was interested in similar functionality and actually wrote a separate plugin to do it, I suggested combining efforts but haven't yet heard back - what do you think about the idea of us combining efforts and putting together a napari-mrcfile package which wraps useful functionality from mrcfile more completely?
I don't mind where this package lives so if it's useful for you to be able to point to it as a work output it could live on your github
As an aside, it's great to see someone else doing cryo-ET using napari! If you'd like to get a bit more involved, discuss your use case and how we can make napari better for your work definitely hop onto https://napari.zulipchat.com, we'd love to hear about what you're up to!

Also, super supportive of the volume/slice histograms in general! I think these should probably be separate from the mrcfile functionality though and live in a standalone plugin before eventually being moved up into napari proper
@haesleinhuepf demoed some really cool histogramming widgets in a community meeting recently, maybe we could leverage this to get most/all the way for the functionality you want?

Hm, I thought I answered you in an e-mail but apparently it did not work.
I will gladly work with you on the mrcfile plugin if you want.

Ah I completely missed napari-mrcfile_handler plugin, it does seem that the immediate features I was thinking about are already implemented. I guess then @Croxa 's repository should be the main one since it's already ahead. Regarding renaming, I'd also prefer a cleaner napari-mrcfile than mrcfile-reader or mrcfile_handler. But ultimately I did not contribute to either one and don't want to hijack your projects so I'd be happy with anything you and @Croxa decide.
I also didn't realize the scale of the napari project, very cool! I've signed up on Zulip and would be glad to contribute, but not sure if there's anything more to my usecase than just inspecting .mrc tomograms and segmentations, at least right now.

Also, super supportive of the volume/slice histograms in general! I think these should probably be separate from the mrcfile functionality though and live in a standalone plugin before eventually being moved up into napari proper
Fully agree and yes, it seems to be something that should be provided by napari directly.

@the-lay @Croxa cool - let's get a repo set up for napari-mrcfile and get things rolling, I can make one early next week and add you both as collaborators, will be fun 🙂
I'll contact you both on Zulip too! @Croxa I had a quick look but can't see you there, if you have an account could you drop me a message?


Figure out how debug Kibana on the local stack created by elastic-package

During Elastic Agent integration development workflow developers start a local stack using elastic-agent:
elastic-package build && elastic-package stack up -d -v --version 8.12.0-SNAPSHOT

I would love to replace the Kibana version created by the stack and replace it with a version started from source and use the debugger.
Overview

Start the local stack
Stop the Kibana container
Start Kibana from sources
Enjoy

@zmoog Thanks for this really helpful!

Start the local stack

Clone the integration repo
Walk into a package
Create and start the local stack

Clone the integration repo
Walk into a package
Create and start the local stack
elastic-package build && elastic-package stack up -d -v --version 8.12.0-SNAPSHOT

Not sure if the Clone the integration repo and Walk into a package sections were intended to have some contents or not, since it is pretty straightforward what needs to be done there. I did't want to directly edit your content, so if you agree for consistency reasons I suggest following:
Start the local stack

Clone the forked integration repo
Walk into a package
Create and start the local stack

Clone the forked integration repo
git clone git@github.com:{YOUR_FORK}/integrations.git

Walk into a package
cd integrations/{PACKAGE}

Create and start the local stack
elastic-package build && elastic-package stack up -d -v --version 8.12.0-SNAPSHOT

What do you think? Feel free to update your initial content.