Support Non-WASI plug-ins

Currently WASI is required for JS plug-ins. This is for a number of reasons:

Some js code like Math.random() and new Date() requires randomness and clocks respectively
The way that the plug-in is "wizened" is by passing in the JS code through stdin and parsing it in the "compile" step. So WASI is needed during compile and the program is a continuation of that.

Ideally what would come of this would be a flag that you can pass specifying you want non-wasi (or the perhaps it could be non-wasi by default). We will probably need to compile 2 versions of the "core", one with the normal wasi stuff and one neutered from any syscalls. The flag can chose which core initialize at compile time. We should also find some other way to get the code in here: https://github.com/extism/js-pdk/blob/main/crates/core/src/lib.rs#L18
Some investigation into wizer will be needed. Or we may need to disable wizening for non-wasi plug-ins.

It seems like Extism is settling around some type of kernel with a consistent pattern for accessing memory locations for data passing.  For the "getting code in" part, the underlying pdk could have a method that takes in a pointer to the memory where the code is, and have the rust wrapper call that method to load the code into memory for quickjs during the wizer step?
I know the newer versions of javy after this fork was started have the ability to externalize the provider quickjs as a separate module and I think they do memory passing to it currently to give it the bytecode, and not through wasi, but I could be misremembering that, it's been a while since I looked at it.


Sass files don't seem to be included

I pulled a new copy of this solution down, and ran it. Attempted to modify bot core.scss and _base.scss within the src/styles folder. Simple change to modify the background of the body showed no results after saving (waiting for the hot reload) as well as stopping webpack and rebuilding/restarting.
What am I missing to get styles working?

That's weird, definitely not intended. I'm currently traveling so a bit tied up at the moment, but will look at this as soon as I get a chance.

@pilgrimtech I am not having this issue with a fresh checkout can you try another git clone and verify everything installed properly?

Just as an FYI, CSS Modules don't work with HMR out of the box. I believe there are some workarounds out there, but if you want HMR in the kit you'd need to write the module.accept handlers yourself.
That said, if this is that it isn't picking up on your styles at all, then that's definitely a bug.

Not sure what the deal was- I deleted everything and reinstalled. It works fine now, Sorry guys.


Support Sign in With Apple with AuthenticationServices

Feature request
On Apple platforms, Sign in with Apple ID should be done with the AuthenticationServices framework in native apps. Currently it is not possible to use this, we also have an issue open in gotrue-swift but it seems the server itself would required some changes for this to work.
Describe the solution you'd like
@thecoolwinter:

Right now I think the GoTrue server would need to be modified to accept and validate the JWT from the AuthenticationServices framework and send back a GoTrue JWT.

Apple's docs give a little more detail as to what's required to make the AuthenticationServices framework work
Basically, only 2 modifications would need to be made to the gotrue server:

Add a POST /authorize/apple (or another path) endpoint what accepts: JWT identity token, access token, nonce, apple ID, and email.

This endpoint needs to verify the identity token against Apple's servers and then exchange the access token for an refresh token as in the graphic from the docs. It should then create a user if needed, otherwise it needs to store the refresh token for later verification. The apple ID would be nice to store as well, probably where other OAuth information is stored. It should also return a GoTrue JWT.
Also important in this step is checking the nonce given from the client. This should be verified against the nonce field in the identity token to prevent replay attacks.

When verifying this user: Grab the refresh token from 1 and verify it against apple's servers using the validation endpoint. This can only be done once a day, so we'd need to store both the refresh token and the last validated date in the user object. If it's valid, generate a normal GoTrue JWT.

This step takes care of the case where a user removes their account through their Apple ID. The next time we go to refresh their token, it should be invalid and we consider the user signed out.

Hey @thecoolwinter, @catlan, thanks for the feedback! We are currently working on it and we actually have a PR here for this!
We're in the midst of testing it thoroughly and doing abit of refactoring before we merge this in.

That's great to hear, @kangmingtay!

Awesome! Glad to hear it! I'll watch that PR so we can make changes to the swift repo when it becomes available.


Invalid SelectFields are not bordered red

This is visible in the documentation of SelectField:
https://evergreen.segment.com/components/select#invalid_field
comparatively TextInputField:
https://evergreen.segment.com/components/text-input#invalid_field

Good catch. Probably need to update the default theme to include invalid border styles. // cc @kamebkj @zkuzmic

Published with v6.6.2


Pyddq

[Current coverage][cc-pull] is 100% (diff: 100%)

Merging [#104][cc-pull] into [master][cc-base-branch] will not change coverage

@@            master   #104   diff @@
=====================================
  Files           24     24
  Lines          437    437
  Methods        429    421     -8
  Messages         0      0
  Branches         8     16     +8
=====================================
  Hits           437    437
  Misses           0      0
  Partials         0      0

Powered by Codecov. Last update [e2510c3...fef0d91][cc-compare]
[cc-base-branch]: https://codecov.io/gh/FRosner/drunken-data-quality/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/FRosner/drunken-data-quality/compare/e2510c3cd8acb12e133e9102d5c82575bcd6ccf4...fef0d91f4edd2c89dddbd52f9d329c167a745395?src=pr
[cc-pull]: https://codecov.io/gh/FRosner/drunken-data-quality/pull/104?src=pr


Hyperlink bug #7

Unexpected behavior when pasting a url with text selected
Steps to replicate:

Copy a URL
select normal text without a hyperlink:

ctrl+v the URL directly to selected text

The text turns into a hyperlink with the copied URL

Expected behavior: the word is replaced with the clipboard content.

This is a feature, not an issue, I can disable it if we don't want it.
@edsaperia

@Marinaobz, Thank you for your help, This is very valuable to us and I appreciate it.. 😊

Thanks @HMarzban, we are trying to match google docs behaviour and that works the other way 👍


Fix doc generation task

What was wrong?
I tried working on the docs but running make html in docs just left me with
$ make html
Running Sphinx v1.7.2
loading translations [en]... done
making output directory...
loading pickled environment... not yet created
loading intersphinx inventory from https://docs.python.org/3.5/objects.inv...
usage: sphinx-build [OPTIONS] -o <OUTPUT_PATH> <MODULE_PATH> [EXCLUDE_PATTERN, ...]
sphinx-build: error: the following arguments are required: -o/--output-dir
Makefile:20: recipe for target 'html' failed
make: *** [html] Error 2

How was it fixed?
I admit that I have never worked with sphinx before so there's a high chance that I'm doing it completely wrong. I tried to figure out if there's a @carver pattern to the rescue and noticed that I can build the docs for eth-account without problems.
In the end it boiled down to simply deleting some code in conf.py that was getting in the way. After I deleted the code I was able to build the docs with make html and they also looked correct when I served them.
There's a comment on the code that I deleted that indicates that it is important to support readthedocs.io but eth-account also hosts on readthedocs.io and doesn't have this code either so I'm not sure if that still holds.
There's a high chance that this actually isn't the right way of fixing docs generation (or that there's nothing broken at all and I'm just doing it wrong) in which case I hope to receive some additional pointers to explore the right way forward :)
Cute Animal Picture

There's a comment on the code that I deleted that indicates that it is important to support readthedocs.io but eth-account also hosts on readthedocs.io and doesn't have this code either so I'm not sure if that still holds.

I've been following the pattern of committing the generated autodoc files (often with a few customizations), so that may be the difference.


Support reading h265 with Webrtc

Describe the feature
Todo:

[ ] add support for h265 into webrtc_conn
[ ] or realtime transcode from h265 to h264 for playng video over webrtc

Hello, H265 inside WebRTC is currently supported by Safari only, therefore it's not much useful to add support for it at this precise time.
You can transcode from H265 to H264 at any moment by using FFmpeg, as described in the README:
https://github.com/aler9/rtsp-simple-server#remuxing-re-encoding-compression

Streaming H265 with WebRTC is now supported with #4003


Webpack function in config ran twice

After configuring next with a webpack function it seems that the function gets called twice during all builds which results in ForkTsCheckerWebpackPlugin running lint/ts checks twice (in my setup).

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Steps to Reproduce (for bugs)

Create a next config with a webpack function which console.logs something
Run the app and see the message log twice.

Your Environment

Tech
Version

next
canary

node
6.11.5

OS
macosx

Once for the server, once for the client. Nothing weird there. You can check for isServer to distinguish them.
webpack: (config, {isServer}) => {return config}

And it's in the documentation https://github.com/zeit/next.js#customizing-webpack-config

@timneutkens oops thank you for the info 👍


"User SFZ Folder" being ignored

Hi,
When I choose the option to load SFZ presets from the dropdown menu, the lv2 plugin directory is opened by default. Setting  "User SFZ Folder" has no effect.
I've also tried to set the SFZ_PATH environment variable as suggested in the discord chat, but nothing changed at all.
I would expect the plugin to open the directory where sound libraries are stored, maybe also having a preference in settings to remember the latest working directory would be good.
Issue verified against the develop flavor of the sfizz package in OBS, which is updated to the latest commit [ec4656d]

My bad, I realized too late that this is a duplicate of #94, closing the other and report here the original message:

This at least on Linux:

the LV2 file dialog opens by default in the sfizz plugin path, which is not great.
It would be nice to save somewhere the last used directory and open it instead.
when trying to open the SFZ folder in the default file manager nothing happens

These 2 issues doesn't happen in VST3.

Other than the above it also causes some visual artifacts on the screen now here on Linux, which makes it also hard to continue to work.
@it9exm mentioned a crackling issue that matches the description of this comment on Discord.

I'd like to add that the LV2 plug-in keeps creating a directory in the home folder whenever I open the project (LMMS) containing the Carla rack with the sfizz plug-in. Seemingly this does not happen when the VST plug-in is used instead.
(Arch Linux, sfizz-lv2 package, ver. 1.2.3-5)


Settings don't save

I just started the debian stable version on my debian server, and the settings page doesn't want to save when I try to change something there.

Hi LaPingvino,
I'm using Journey on my wheezy stable amd64 server without that problem.
Does creating/deleting posts work?
Saving the settings, there should be PATCH requests to http://<IP_ADDRESS>:8084/admin/api/blog and http://<IP_ADDRESS>:8084/admin/api/user. Can you post the servers response to those requests here?
Thanks

Creating and deleting posts works. I discovered that it actually did work on my tablet, so I decided to try in Incognito mode and there it works too, so probably some problem with one of my extensions...

Now my home page (soneli.ga) doesn't show well, gives this error in console:
Resource interpreted as Image but transferred with MIME type text/html: "http://soneli.ga/".
  (anonymous function) @ jquery.js:3
  jQuery.Callbacks.fire @ jquery.js:3
  jQuery.Callbacks.self.fireWith  @ jquery.js:3
  jQuery.extend.ready @ jquery.js:3
  completed @ jquery.js:3

Hi LaPingvino,
I'm not seeing that when opening http://soneli.ga
Did you fix it already? My first guess would be a problem with the jquery file/version that comes with Journey (built-in/public/jquery/jquery.js). It will be inserted into your page when you use the ghost_foot helper (as Ghost does it. I don't like that behavior but it is there to keep Ghost compatibility).

I can work around the issue, and it seems to be something with the extensions on my side. I will report here if I manage to find out what causes it, as it could be something more people can experience...


/ok-to-test

wawo
/test

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign perfectnewer

/close

@perfectnewer: Closing this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Git branch name Development doesn't match GitFlow Convention

The branch name this plugin is using for what GitFlow calls develop is called 'DEVELOPMENT'.  Any reason why you are using DEVELOPMENT instead of DEVELOP?
https://github.com/egineering-llc/gitflow-helper-maven-plugin/blob/master/src/main/java/com/e_gineering/maven/gitflowhelper/GitBranchType.java#L12

Have not fully tested this out yet but after looking at the code, I think the way around this is to configure the plugin with the following
<configuration>
    ....
    <developmentBranchPattern>origin/develop</developmentBranchPattern>
    ....
</configuration>

Will have a go at this and see how things work.

Yep that should work.

On Jun 8, 2016, at 7:19 PM, Michael Pellegrini<EMAIL_ADDRESS>wrote:
Have not fully tested this out yet but after looking at the code, I think the way around this is to configure the plugin with the following

    ....
    origin/develop
    ....

Will have a go at this and see how things work.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Mainly because I wrote it to work with the layout employed by an opinionated client. ;-)

On Jun 8, 2016, at 5:26 PM, Michael Pellegrini<EMAIL_ADDRESS>wrote:
The branch name this plugin is using for what GitFlow calls develop is called 'DEVELOPMENT'. Any reason why you are using DEVELOPMENT instead of DEVELOP?
https://github.com/egineering-llc/gitflow-helper-maven-plugin/blob/master/src/main/java/com/e_gineering/maven/gitflowhelper/GitBranchType.java#L12
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks for the quick reply.

Would you reconsider opening this issue and change the pattern to develop? It is neater if everything works out of the box and follows mavens preference for convention over configuration.
I think it would be more appropriate for your client to use the special configuration pattern.

@bvarner - What is the right way to specify develop as development branch name? I used the syntax from above and merged to my develop branch, but it was still recognized by the plugin as 'OTHER' and skipped repo deployment step.
<configuration>      ....     <developmentBranchPattern>origin/develop</developmentBranchPattern>     .... </configuration>

The votes have it, it's pretty obvious most of you (us?) want develop to be the default on this one, and I have to agree.
In fact, I agree so much, that the default is already changed... Apparently I didn't reference this issue when I made the adjustment due to popular demand from wonderful folks like yourselves, and a sudden jolt of pragmatism from an unbeknownst origin. :smile:
It looks like I did this back on commit 923a943 which looks like it was included in 1.6.0
@misterzero the current default pattern (post 1.6.0) is (origin/)?develop, with the origin/ being optional, due to the way local SCM manager invocations differ from jenkins-provided env.GIT_BRANCH resolution.


Add Worker Keys

Part of Dynamic Worker Integration -> Design Doc
Give keys to workers as part of genesis and store the public keys as part of the WorkerInfo. Eventually when workers can be dynamically discovered the keys will not be provided at genesis but rather created dynamically in code.
Worker reconfiguration requires some additional thought and the bare minimum was done in this PR in that regard. Only allowed an avenue for the updated worker information to be sent from Sui to NW via NodeRestarters channels. Leaving proper worker reconfiguration changes for a future PR. @asonnino let me know if that is okay.
What has been tested -

[x] Unit/Integration Tests
[x] Local & Remote Benchmark
[x] Client Demo
[x] Docker configurations (NW)
[ ] Sui Integration

Also, converting Sui to use this change should hopefully be fairly easy since each node just has 1 worker so we'd just need to generate an extra key as apart of the node config

Yep, I believe that @arun-koshy is planning on making the changes in sui next.


Keep retrying if cyw43_wifi_join fails

Currently, if the network can't be found we fail almost immediately. Also fix error codes.
Fixes #1054

Lets try this again!


resin-image-flasher.bb: Make the sdcard image creation

depend on resin-image:do_image_resin_sdcard rather than
just need resin-image:do_rootfs
The task add_resin_image_to_flasher_rootfs expects the sdcard image
to be created, not just the rootfs to exist at the time it is called.
Signed-off-by: Florin Sarbu<EMAIL_ADDRESS>

@agherzan @michal-mazurek

Included as part of https://github.com/resin-os/meta-resin/pull/471
Closing this one here


Cleanup code added for CSI support

Signed-off-by: Shiva Krishna, Merla<EMAIL_ADDRESS>

lgtm.
also newCsiPersistentVolume() can be removed from volume.go

done


corrects pagination issue

When switching between pagination mode the number of displayed items was never reduced, because rowsPerPage was calculated based on the height of the scrolling view. Changed to be calculated based on the height of the non-scrolling container instead. List and compact list are now paginated where previously all items were displayed.
https://www.pivotaltracker.com/story/show/169978952

Please re-test this.

Please retest this


potential dead code?

https://github.com/CozySynthesizer/cozy/blob/eb650f36dd16c5170a126761ba504c0072e454a4/cozy/evaluation.py#L597
this closure has an argument stk but not using it

The inner set_arg function is appended to the list of operations to perform. Each operation must be a function that accepts a stack of values as input. Operations are allowed to manipulate the stack. This operation happens not to manipulate the stack, but if you remove the argument the code will crash because a stack will be passed by the caller.

This might be clearer if we had type annotations in the evaluation module (see #50).


[Doc] A section with no description : How to use wso2 securevault:

Description:
There is a section heading "How to use wso2 securevault:" in [1] but no any content for it. Please add relevant information.
[1] https://docs.wso2.com/display/SP400/Monitoring+Stream+Processor#MonitoringStreamProcessor-Howtousewso2securevault:
Suggested Labels:
Priority/High, Severity/Critical, Type/Doc

Reviewed and reorganised this documentation. Removed the "How to use wso2 secure vault" sub headingand added it as a link in the 2nd step of the "Configuring cluster credentials" sub heading.


Feature: compare / compareLikeHuman / naturalCompare

For most cases, humans do not sort text as machines do.
["A friend", 'Boo', "another one"].sort()
// => ["A friend", "Boo", "another one"] 😬

Let's fix that :)
/**
 * @description Compares input text as humans do.
 * @param {String} first
 * @param {String} second
 * @returns {Integer}
 * @example
 * compare('', '') // => 0
 * compare('A', 'a') // => 1
 * compare('A', 'b') // => 1
 * compare('A woman', 'a woman') // => 1
 * compare('b', 'B') // => -1
 * compare('C', 'b') // => -1
 * compare('Qux20', 'Qux5') // => -1
 * compare('Qux10', 'Qux11') // => 1
 */

Aliases
import compare from '@plexis/compare';
import {compare, compareLikeHuman, naturalCompare} from 'plexis';

@vorillaz I am unable to get what you are trying to implement as part of this issue. Can you please elaborate ?
compare('A', 'a') // => 1
compare('b', 'B') // => -1

Why are the return types different for these two ?

@akhil-ghatiki In a human-readable format, the uppercase letters are prioritized against the lowercase. So the first one dictates that A is prior to a. In the next one, B is prior to b and so on.


CSETversion v9.2.0 bug after installation

Bug - After installation in do CSET 9.2.docx

fixed in version 9.2.1


I want to set the shortcut key for switching tabs of bufferline

I want to set the shortcut key for switching tabs of bufferline, but it is not available after I follow the keymap configuration on the official website. How should I configure it to set the shortcut key for switching? Please provide code example if possible
This is the code of the official website:
-- tabs
map("n", "<leader><tab>l", "<cmd>tablast<cr>", { desc = "Last Tab" })
map("n", "<leader><tab>f", "<cmd>tabfirst<cr>", { desc = "First Tab" })
map("n", "<leader><tab><tab>", "<cmd>tabnew<cr>", { desc = "New Tab" })
map("n", "<leader><tab>]", "<cmd>tabnext<cr>", { desc = "Next Tab" })
map("n", "<leader><tab>d", "<cmd>tabclose<cr>", { desc = "Close Tab" })
map("n", "<leader><tab>[", "<cmd>tabprevious<cr>", { desc = "Previous Tab" })

Hello @PILIHU2022,
Are you perhaps referring to the official website of LazyVim?
Questions regarding LazyVim can be asked here.
Best regards!

Hello @PILIHU2022, 你好
Are you perhaps referring to the official website of LazyVim?你指的是LazyVim的官方网站吗？ Questions regarding LazyVim can be asked here.有关 LazyVim 问题可以在这里提出。
Best regards! 此致敬意！

Thank you!


Cuda initialization error when doing PyTorch inference with FastAPI

Hi,
I've been trying to use FastAPI to wrap a PyTorch model for inference.
While this works perfectly for CPU inference, when I'm trying to run my model on a GPU I encounter an Cuda error: initialization error. when trying to move a tensor from CPU to GPU.
I am able to load the model into the GPU during the __init__ stage, so it looks like this problem is related to multiprocessing. However, standard solutions related to PyTorch such as setting its multiprocessing mode to spawn do not seem to work.
Any idea how to approach this from the FastAPI end?

Can you explain how your issue is related to fastapi?

@eladrich Did you manage to find a solution?

@SaeedArisha @eladrich Did you find a solution for this? I face the same error.


Statistics

We would like to have a line count for the Stacks project, but given that Gerby never sees the LaTeX code we don't have that straight away now. We could sum up the number of HTML lines, but that feels like a crude approximation.
We also need a page count. Again, not easily accessible from Gerby right now.

Line counts are accessible after commit eae2c93 in the plasTeX repository. In particular, Gerby now outputs a meta.statistics file, which is a JSON object that contains the line count in the property lines.

For the page count we can use https://stackoverflow.com/a/17931249/348350.

Great. I guess we just need to implement pdf’s before this will happen.
On Feb 15, 2018, at 11:08, Pieter Belmans <notifications<EMAIL_ADDRESS>wrote:
For the page count we can use https://stackoverflow.com/a/17931249/348350.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/pbelmans/gerby-website/issues/35#issuecomment-365975181, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABMuFc2mlRyHhS5uBuVR1lhzjuAYkREeks5tVFZ7gaJpZM4SBDBA.

They will not be implemented as a feature: they will just be assumed to exist in some location. I don't think there's an easy one-size-fits-all implementation available here.

Another thing that can go on the global statistics page: the number of lemmas, propositions, etc. It's just fun to see these things.

Yea, that should be easy. I will do that soon.
On Feb 15, 2018, at 13:19, Pieter Belmans <notifications<EMAIL_ADDRESS>wrote:
Another thing that can go on the global statistics page: the number of lemmas, propositions, etc. It's just fun to see these things.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/pbelmans/gerby-website/issues/35#issuecomment-366015627, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABMuFZGFTLQI0wvE3lDqltR8SYIyVGG3ks5tVHUXgaJpZM4SBDBA.

Okay! Assume that I can output the number of each environment in the meta.statistics file if you wish.
On Feb 15, 2018, at 13:22, Pieter Belmans <notifications<EMAIL_ADDRESS>wrote:
I'm working on some tag statistics now by the way.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/pbelmans/gerby-website/issues/35#issuecomment-366016534, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABMuFawoTe15mG_-6MuvUEJEZSvdyaMIks5tVHXRgaJpZM4SBDBA.

There's no need for that, it's all in the database :).

Oh, good point! Nice! I guess you got this, then.
On Feb 15, 2018, at 13:27, Pieter Belmans <notifications<EMAIL_ADDRESS>wrote:
There's no need for that, it's all in the database :).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/pbelmans/gerby-website/issues/35#issuecomment-366018017, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABMuFf3Ag9O-x1P0z0pwB4bGoVchscaTks5tVHcagaJpZM4SBDBA.

Page counts and line counts are now available, after commits a4af8e3d2debfb7e447caae8b336315cbfb402b9 and 95233bd61798bc58a235de26994b7f19fe438af8.


UI enhancement

Better UI for the main page. Adjust the text in a manner to make it more attractive.
I'm a GSSoC'24 contributor, efficient in Web development and UI/UX design. Can you please assign this work to me.

Thank you for creating this issue! 🎉 We'll look into it as soon as possible. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊
You can also check our CONTRIBUTING.md for guidelines on contributing to this project.

I can update the design according to your choice, as per the above two. Or if you don't prefer these I can suggest other alternative UI's as well, according to your requirements.

Hi @sanskriti-lal,
Thank you for raising this issue. I think the first one is better. There is no need to add a numbered section. We can work on the first one.

Ok cool. I've made a PR can you please look into it.


Clean flags

Reduce the amount of global flags
Unexport all flag vars
Some other minor flag cleaning

Other than my nit-picking, I like this!

Merged in 87ca0d0


removed participant-gitops namespace

Merging anyways. The linter task needs to be updated apparently, but this playbook is correct.


Cannot run example app (crashes after infinite loop)

🐛 Bug Report

When running the example app on an iOS simulator (in example/ios), the example app fails to mount & the app crashes after entering an infinite loop with the error:
Invariant Violation: No callback found with cbID 2903 and callID 1451 for module <unknown>.

To Reproduce

Install both the package & example app dependencies (npm install && npx pod-install)
Start the example app by running npm example:ios

Expected Behavior

The example app builds & runs successfully
Environment

System:
    OS: macOS 10.15.7
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 1.87 GB / 32.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 12.16.3 - /usr/local/bin/node
    Yarn: 1.22.5 - ~/.yarn/bin/yarn
    npm: 7.10.0 - ~/git/sw/react-native-fbsdk-next/node_modules/.bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.10.1 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.4, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
    Android SDK: Not Found
  IDEs:
    Android Studio: 4.1 AI-201.87<IP_ADDRESS>58069
    Xcode: 12.4/12D4e - /usr/bin/xcodebuild
  Languages:
    Java: <IP_ADDRESS> - /usr/bin/javac
    Python: 3.7.7 - /opt/anaconda3/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1
    react-native: ^0.63.3 => 0.63.4
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

I'm using the package in production now.
Not sure about the example though, I haven't tried it.

That's good to know.  What react-native and react-native-fbsdk-next version are you using?  And what platform?

Example app is used for testing if I remember correctly. Either way feel free to update it if you would.
I'm also using it in production without any issues.

Just thought I'd add the error I got here in case anyone else looks at this in the future:
[Tue Jul 06 2021 08:58:32.853]  BUNDLE  example/index.js

[Tue Jul 06 2021 08:59:21.814]  LOG      Running "RNFBSDKExample" with {"rootTag":1}
[Tue Jul 06 2021 08:59:21.815]  ERROR    Invariant Violation: View config getter callback for component `RCTFBLoginButton` must be a function (received `undefined`).

This error is located at:
    in RCTFBLoginButton (at FBLoginButton.js:112)
    in LoginButton (at App.js:55)
    in RCTView (at View.js:34)
    in View (at App.js:54)
    in App (at renderApplication.js:45)
    in RCTView (at View.js:34)
    in View (at AppContainer.js:106)
    in RCTView (at View.js:34)
    in View (at AppContainer.js:132)
    in AppContainer (at renderApplication.js:39)
[Tue Jul 06 2021 08:59:21.816]  ERROR    Invariant Violation: View config getter callback for component `RCTFBLoginButton` must be a function (received `undefined`).

This error is located at:
    in RCTFBLoginButton (at FBLoginButton.js:112)
    in LoginButton (at App.js:55)
    in RCTView (at View.js:34)
    in View (at App.js:54)
    in App (at renderApplication.js:45)
    in RCTView (at View.js:34)
    in View (at AppContainer.js:106)
    in RCTView (at View.js:34)
    in View (at AppContainer.js:132)
    in AppContainer (at renderApplication.js:39)

Ok so I found out more things but still can't fully resolve the error. For some reason named imports from 'react-native' aren't recognized so changing all the import {a, b} from 'react-native' to
import a from 'react-native'
import b from 'react-native'

For example:
import { requireNativeComponent, StyleSheet } from 'react-native';

turns into
import requireNativeComponent from 'react-native';
import StyleSheet from 'react-native';

This gets rid of a bunch of errors but leaves me with this error:
[Tue Jul 06 2021 09:41:54.464]  BUNDLE  example/index.js

[Tue Jul 06 2021 09:42:01.667]  ERROR    TypeError: undefined is not a function (near '..._reactNative.default.create...')
[Tue Jul 06 2021 09:42:01.667]  ERROR    Invariant Violation: Module AppRegistry is not a registered callable module (calling runApplication)
[Tue Jul 06 2021 09:42:01.686]  ERROR    Invariant Violation: Module AppRegistry is not a registered callable module (calling runApplication)

which I believe is coming from render(): JSX.Element; in FBLoginButton.ts but I can't seem to figure our what to do for that

@KrisLau if you have a chance I would love confirmation that the new example app actually works. Of course "it worked for me" when I was developing it but that's a lot less useful then independent confirmation. Cheers!

Sorry been having a hectic week, I'll try and test it out this weekend. Thanks!

No problem whatsoever, I'm happy you're even considering giving it a spin :-). Shouldn't feel guilt + time pressure on open source of course. Cheers

Ran the example yesterday and ran into a two errors that were pretty pretty easy to get around so I'll just drop them here for anyone that might run into the same ones.
The first error: com.android.ddmlib.InstallException: Failed to finalize session : INSTALL_FAILED_UPDATE_INCOMPATIBLE: Package com.rnfbsdkexample signatures do not match the previously installed version; ignoring! was just because I had installed the example before and that was clashing with the new example so I just uninstalled the old version off the emulator.
The other error I ran into was:
Error: EISDIR: illegal operation on a directory, read
    at Object.readSync (fs.js:592:3)
    at tryReadSync (fs.js:366:20)
    at Object.readFileSync (fs.js:403:19)
    at UnableToResolveError.buildCodeFrameMessage (react-native-fbsdk-next-master\node_modules\metro\src\node-haste\DependencyGraph\ModuleResolution.js:304:17)
    at new UnableToResolveError (react-native-fbsdk-next-master\node_modules\metro\src\node-haste\DependencyGraph\ModuleResolution.js:290:35)
    at ModuleResolver.resolveDependency (react-native-fbsdk-next-master\node_modules\metro\src\node-haste\DependencyGraph\ModuleResolution.js:168:15)
    at DependencyGraph.resolveDependency (react-native-fbsdk-next-master\node_modules\metro\src\node-haste\DependencyGraph.js:353:43)
    at react-native-fbsdk-next-master\node_modules\metro\src\lib\transformHelpers.js:271:42
    at Server.<anonymous> (react-native-fbsdk-next-master\node_modules\metro\src\Server.js:842:41)
    at Generator.next (<anonymous>)

only occurs when I run the app through IntelliJ instead of yarn example:android. I just had to run it using the command yarn example:android. The app now runs successfully.
Thanks a bunch @mikehardy !

Thanks a bunch for verifying! With the example up to date and easy to update there's a much more solid basis to do future development

No problem, happy to help!


Add template with code in a Main method

This will allow for examples which are just statements. (Also adds example in 16.1 Arrays to show how to use it.)
Towards #646

@jskeet, I'm confused! This isn't one of the scenarios I reported in the new issue. In fact, I was able to get that example (and other examples like it) to build by using the template standalone-console, and taking advantage of the ability to have statements at the top level in recent compiler versions.

It may not be necessary if we're happy to use a later compiler to test C# 7, but it still feels like it's part of fixing "incomplete example". (I don't have the full context of what doesn't work as we can't see your code with the metadata, unless you've pushed that to a branch I'm not aware of. So I'm going on descriptions basically.)


rapidly scrolling down a topic feed results in a temporarily hung UI

go to popular topics feed
very quickly scroll down (i.e. swipe up on screen)
UI temporarily freezes
after several seconds, the spinner appears and then continues loading

Jaroslaw, could you please verify behavior on the latest build

Verified on build from commit number e3e420b308ff6a043ac652983c64ca130dbee5c7


Add a raw option to display results as JSON

Codecov Report

Merging #43 (3843755) into main (0816198) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            7         7
  Lines          598       639   +41
=========================================
+ Hits           598       639   +41

Impacted Files
Coverage Δ

meilisearch_cli/_config.py
100.00% <100.00%> (ø)

meilisearch_cli/_helpers.py
100.00% <100.00%> (ø)

meilisearch_cli/documents.py
100.00% <100.00%> (ø)

meilisearch_cli/dump.py
100.00% <100.00%> (ø)

meilisearch_cli/index.py
100.00% <100.00%> (ø)

meilisearch_cli/main.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0816198...3843755. Read the comment docs.


Avoid invalidDateMessage to be passed to TextField

[x] I have changed my target branch to develop :facepunch:

Description
Fixes error, caused by invalidDateMessage passed to TextField

I am sorry 😃

I've tried to use the development branch by adding package with:
yarn add https://github.com/dmtrKovalenko/material-ui-pickers.git#develop

but I get:
Module not found: Can't resolve 'material-ui-pickers' in

material-ui-pickers is in node-modules, but webpack (project builder) is not able to resolve it. I suppose it's caused by the "copy" magic which is performed during the release.

@mgenov next beta release will contain that fix, @dmtrKovalenko promised to release it today ;)
Note, that we do not keep built files in repo, so adding source files like you did above will not work.
To use development branch:

Clone the repo and checkout develop branch
Go to lib directory and install dependencies npm install
Build library running npm run build (or npm run start if you want to watch changes in library)
Run npm link in lib directory
Run npm link material-ui-pickers in your project root directory


Adding mixpanel event for loading projects that use deprecated blocks

Fixes #571
This event will fire whenever a Blockly project is loaded, including when you switch from TypeScript to Blockly after making a change in the TypeScript. The payload for the event is a map of deprecated block IDs to the number "1" because the API of pxt.tickEvent will only take a number or string map. Does mixpanel.track() support arrays? If so, I'll change it to just be an array of block IDs.

mix panel does not support batched events, at least not in the JS API

@pelikhan but you can send data in the events, right? I just want to know if I can send an array of strings as data.

This looks good to me.  Mixpanel help says track does support the array of data (track is what our tickEvent maps to)

Updated to send an array

Mixpanel takes properties (https://mixpanel.com/help/reference/javascript-full-api-reference#mixpanel.track). Maybe it just works with arrays, needs to be tested.
A set of properties to include with the event you're sending. These describe the user who did the event or details about the event itself.

I've pushed a dummy event from the console to test out how mixpanel handles it.

which leads to

I think we want to expose the keys and a count of the occurence of each deprecated property to that we can tally the numbers later on.

Mixpanel allows to pivot using properties. In fact, we could probably send a lot of properties. Maybe we could compute some rough statistics about code snippets: # statements, # loops, # conditionals, # deepest nesting

Updated to instead send a map of deprecated blocks

Looks good.


Updating Degen Air $MILES logo.

All requested changes provided!
Token Address: 9YAnyZ2cMUbQSwWAE76fohF58o4DHwaZFE9vgH5dVAJL
Token Name: Degen Air Miles
Token Symbol: MILES
Logo: ✔
Official homepage of token: https://degenair.io
Updating logo.

@bartosz-lipinski @rmshea @oJshua
Is there a process to get token modifications like this accepted other than manual review?
I understand it can't be automerged, but I'm trying to update a token I added myself.
Thanks in advance!

https://github.com/solana-labs/token-list/commit/120af5dc936b7a5d3af91f82c690e7152cc86879


Solution chatflows don't check for available capacity

Currently the chatflows use random nodes to deploy on withouth checking for available capacity.
We should check for correct CRU MRU and SRU before even bothering to make a reservation

CRU is 1 vCPU
MRU is one GiB of memory
HRU and SRU are for GiB of disk HDD or SSD

Currently blocked on: https://github.com/threefoldtech/zos/issues/703


chore: move types

Oh, didn't know an alias is set up for that directory

yeah. there's a wildcard value in tsconfig


Should this be in the junkyard?

It's used in a bunch of ssb-db tests. Should we be throwing some sort of deprecation notice?

yes, definitely should be the junkyard. use ssb-validate instead. I can't be bothered rewriting those tests.


XLSX.read(data,{ type: 'array'}) ，data太大IE浏览器卡死，如何解决？

data.byteLength=19828736

分享一个例子，我们可以仔细看看

xls文件18.9MB，data.byteLength = 19828736

Stop using IE, it's a security honey pot and sink hole that creates zombie PC.

Without seeing the file, we cannot pinpoint the root cause.  But if you are using IE11, you can use a web worker to do the processing without locking up the browser.  Please try using a web worker and reopen the issue after testing


Active class disappears when drag over children

Looks like it's this issue. If I have time I'll open a PR to fix it. We're causing this with just the following code
<Dropzone className='dropzone-component' activeClassName='dropzone-component__active'
  onDrop={this.onUploadHero} size={150}>
  Upload Background Image
</Dropzone>

I've solved this by adding a CSS pointer-events: none. Probably this should be done by the lib itself...

Brilliant! Worked for me too

#73

:+1:

Can we get a npm version patch npm publish with this fix please? xD

Done. npm v2.2.1.


Make effekt have a non-0 exit code when compilation fails

When using effekt ... --compile to compile a program, the exit code is always 0, even when there is an error.
This makes writing scripts (shell scripts, build/test scripts etc) using it harder.
Example:

Intended output:
Terminate with exit code non-0 (e.g. 1), if there are errors.

Fixed by #338


Tailwind needs minor changes to allow @imports

The base installation for using the Tailwind builder works OK until you start trying to @import other CSS. Without imports that can be piped through @apply it's tough to compartmentalize your CSS. To get around this:

Add --postcss to the build:css directive in package.json:

  "scripts": {
    "build:css": "tailwindcss --postcss -i ./app/assets/stylesheets/application.tailwind.css -o ./app/assets/builds/application.css"
  }

There's a few node modules that need to be added:

yarn add postcss-import
yarn add postcss-flexbugs-fixes
yarn add postcss
yarn add postcss-preset-env

And then a postcss.config.js needs to be added:

module.exports = {
  plugins: [
    require('autoprefixer'),
    require('postcss-import'),
    require('tailwindcss'),
    require('postcss-flexbugs-fixes'),
    require('postcss-preset-env')({
      autoprefixer: {
        flexbox: 'no-2009'
      },
      stage: 3
    })
  ]
}

Then put your imports at the start of application.tailwind.css

@import 'home.css';
@import 'foobar.css';

@tailwind base;
@tailwind components;
@tailwind utilities;

Notes: There may be a better way to do this, but this is what I arrived at to get it working. It's a little inconvenient having to manually list imports, but it works. This uses the standard Tailwind PostCSS configs. The Tailwind builder traverses the imports so if you change "foobar.css" it'll trigger a rebuild. The repo I'm working in is using:
gem 'importmap-rails'
gem 'turbo-rails'
gem 'stimulus-rails'
gem 'cssbundling-rails'

It sounds like this is expected of postcss-import as it's adhering the spec strictly.
The Tailwind docs cover this exact issue and provide a solution which basically swaps the @tailwind declarations for @imports.

Documented the this question as part of the FAQ: 2a17da2.


package creation date field always shows error, even when datapackage.json file has correct date in it

Overview
When I try to add the creation date to a package the application interface doesn't retain the value and tells me there is an error (see screenshot):

However, the actual date entered via the application interface IS saved to the datapackage.json file, so I guess it must be something to do with the interface not reading that field correctly:

Thanks for reporting!


GOBBLIN-1127: Provide an option to make metric reporting instantiatio…

…n failures fatal
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1127

Description

[x] Here are some details about my PR, including screenshots (if applicable):
This option allows GobblinTaskRunner to "fail-fast" on metric reporting instantiation failures. This is particularly sseful in scenarios where pipeline monitoring depends on metrics and tracking events being emitted.

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Added unit tests.

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

There's a travis failure seems relevant, can you reproduce locally by ./gradlew :gobblin-modules:gobblin-kafka-09:test ?


The section needs update https://docs.microsoft.com/en-us/dynamics365/mobile-app/setup-mobile-offline-for-admin#step-1-enable-entities-for-mobile-offline-synchronization

The section needs update
https://docs.microsoft.com/en-us/dynamics365/mobile-app/setup-mobile-offline-for-admin#step-1-enable-entities-for-mobile-offline-synchronization
Now with so many out of the box entities available in the product.
Also Position entity has that option disabled.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 47bcdcf0-46c7-2e85-2dc2-1e9afe7220c1
Version Independent ID: a315aeaf-2034-d310-88ee-77dd760e24b7
Content: Configure mobile offline synchronization in Dynamics 365 for phones and tablets
Content Source: ce/mobile-app/setup-mobile-offline-for-admin.md
Service: crm-online
GitHub Login: @mduelae
Microsoft Alias: mkaur

@nishantranacrm - Thanks for providing feedback. The topic has been updated.
Thanks,
Mints


Import architecture docs repo into pulumi

Summary

Release Note

Documentation

this repo already exist, we need to import that manually, i will run the import

closing in favor of https://github.com/sigstore/community/pull/341


Reddit client infinity doesn't show up

I cannot access infinity

Couple of questions since I have not been able to reproduce this locally yet.

Where did you install Infinity from?  (Play Store, F-Droid, apk...)
Did you install Infinity before or after installing and running Unlauncher?

Closing since this is a duplicate of #96


New: Notifications for cookies and other stuff.

Replacing #104 for cleaner commits.

I have checked the code deeply and saw there are few things that needs to be addressed before the merge.

'amp' prefix was missing in every option that you created in options-init.php.
If the notification is off, then Notification text and Notification accept button text should be hidden in options panel.
Styling is not proper for the notification bar, and also the text and button are aligned left.

Please update the code if you can or l will make the changes and will merge the pull request in the morning.
Thank you very much for your contribution.

Hey,
I just added the 'amp' prefix to the option that was missing one, and made the styling changes (sorry, I didn't notice those because it was already in my custom CSS), I also made the enable-notifications selector required for the text and button settings.

Hey,
Awesome that you added this feature, the conflicts were probably due to it not having the latest commits, but thanks for adding the option. I'm now going to close this pull.


Long noteName pushes icon up above inline title

Describe the bug
The inline title, when long, pushes the inline icon up above the title instead of putting it next to the title.
To Reproduce
Steps to reproduce the behavior:

set an icon on a note (i did it via icon: frontmatter
make the note title long
observe

Expected behavior
Icon should push the text, not the other way arond
Screenshots
If applicable, add screenshots to help explain your problem.

Additional Context
I am using the minimal theme, i don't know if this effects it.

This issue should be resolved with v2.12.1.


copilot-cli: 1.30.0 -> 1.30.1

Description of changes
change log: https://github.com/aws/copilot-cli/releases/tag/v1.30.1
diff: https://github.com/aws/copilot-cli/compare/v1.30.0...v1.30.1

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 253083 run on x86_64-linux 1

1 package built:

copilot-cli


[Util/Streamprocessor] PHP file detection

Currently the Steamprocessor does not recognize files other than those using »php« as file extension as a PHP file and therefore will not process its' contents probably to be replaced in order to make it possible to intercept a request and/or response.
Common extensions for a PHP file might also be:
*.inc
*.php(\d?)  //like *.php4 or *.php5
*.phtml
*.cgi

...

can't you provide something to register a custom callback function for this decision?

I think it would be safe to conclude this is no longer needed.


Use asExpected reason for ReconciliationActive=true

What this PR does / why we need it:
Consolidate to use asExpected for happy path condition
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Ref https://issues.redhat.com/browse/HOSTEDCP-722
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/retest

/lgtm


Run doesn't look that good anymore

Description of the new feature / enhancement
Any way you can add a option to make the run feature look like the old way? was more sleeker and the bigger text was nice.
Scenario when this would be used?
when I hit alt+spacebar
Supporting information
No response

/dup #30168


Selecting element in typeahead does not trigger parsers

I'm not sure if this is intended or not, but my custom parser does not get triggered when selecting a value in a typeahead.
As you can see in plunker example, when I type individual characters the custom parser is triggered; but if I actually select a value from the list the parser is not triggered.
Is there a way I can make it so that my parser gets triggered both while typing and on selection?
http://plnkr.co/edit/l9G7QTfhjdq9NYhvxEJ9?p=preview
Thanks!

Unfortunately, what might be happening is that the typeahead is changing the model value - it should probably be calling $setViewValue on selection to trigger the model change. This might require a refactor to support this.

Thanks for the answer; do you have any suggested workaround in the meantime? I see that there is an on-select callback but not sure how I would call $setViewValue from there (if appropriate)

Unfortunately, this may be something that needs to be fixed at the library level.
Can you explain your use case more in detail?

I am attempting to convert an existing input field to a typeahead. The existing input field has two custom parsers.
The input field is currently designed such that the user must enter an entity name followed by a command. As a contrived example let's say the entities are pets and the commands are things you can do to the pet. So the user would enter the name for the pet and then the operation like "Rex feed".
The first parser checks to make sure that the first word is a valid pet name; if it is, it then returns the command portion of the input minus the pet name ("feed"). If it is not a valid pet name, it returns an empty string.
The second parser receives the command minus the pet name ("feed") and then checks to make sure the command has not been "blacklisted", and if it has been, suggests an alternative in a nearby div and returns an empty value. If the command has not been blacklisted, it returns the input value "feed"; it is important that the value returned by the last parser is the command only and does not contain the pet name.
There may be a better UI for doing this, but I was hoping to not have to change it because users are already used to the current way of doing things.
Thanks so much for the help!

+1 Its definetely should trigger setviewvalue or it brake angular forms functionality

I agree with @RootMale. The typeahead component brakes angular forms functionality.
In the code, when a value is selected in dropdown menu, the modelValue is setted directly.
I think, the viewValue and input element value should be defined instead :
modelCtrl.$setViewValue(model, 'select');
element.val(parserResult.viewMapper(originalScope, locals));

The modelValue will be updated automatically with angular form.
Tell me if you agree with this and so, I will create a pull request.

The typeahead does need fixing with how it handles being part of a form - unfortunately I do not have the time to tackle such a task myself.

@wesleycho, you are right.
I tried to adapt typeahead to angular forms functionality. But I realized that is more complicated that I thought.


Replace oadm with oc adm

Looks good, filed an issue for the unstable test that caused the build to  fail: https://github.com/EnMasseProject/enmasse/issues/109


Track object headers option should be used for artwork as well.

Is your feature request related to a problem? Please describe.
My media is behind an authentication layer, and the headers option works perfectly for it. But my artwork is behind the same authentication layer, and it appears the headers only applies to the media, not the artwork.
Describe the solution you'd like
I'd like for either the headers option to be used when fetching the artwork, or to have a new artworkHeaders option (in case it's different; it's not in my case).
Describe alternatives you've considered
I've considered downloading and caching the images.

Good idea @doughsay thank you.
Is this something you could investigate further or even create a PR to fix?
Thank you

Good idea @doughsay thank you.
Is this something you could investigate further or even create a PR to fix?
Thank you

I'm very unfamiliar with the tech involved, but if you pointed me to the general area of the codebase where artwork fetching happens maybe I could figure it out 😅 I'd be happy to give it a shot.

Me neither heh - I'm JS only. Anyone else know where to start? Thanks

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@doughsay are you still interested in taking a crack at this? If so I can try to get you guidance.

Sorry, not at the moment as I'm busy with other things, but I still hold out for maybe trying in the future.

Given there's no one to champion this at the moment, I'm going to add it to the feature backlog and close the issue. We can revisit it again in the future.


take_arrays in repartition is not renamed

Which issue does this PR close?

#12654 change the function name, but there is one left unchanged
Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Hi @jayzhan211
I also try to fix same issue in  https://github.com/apache/datafusion/pull/12657


Enumerable methods TSE Review.

The following methods were created and tested.
#my_each;
#my_each_with_index;
#my_select;
#my_all?;
#my_any;
#my_none;
#my_count;
#my_map;
#my_inject;

I did this project alone because my partner stopped answering due to connectivity issues, so I was requested by Willow to do it by myself.

Thanks for the support @christianotieno!
I improved the code as requested:

Fixed my_all? not correctly returning a boolean value when a regex was passed as an argument;
Fixed my_all? TypeError when an arg was passed;
Fixed my_any? returning self when class was passed as an argument or regex;
Fixed my_any? not returning a right boolean value when a pattern was passed as an argument;
Fixed my_none? not returning a right boolean value when a pattern was passed as an argument;
Fixed my_count to count the similar values when a number was passed as an argument;
Fixed my_inject to return LocalJumpError when a block was not given to the method.

Pull Request under review by Daniel Larbi Addo (TSE)

Pull Request under review by Daniel Larbi Addo (TSE)

Thanks for the support @addod19.
I improved the code as requested:

Change require to require_relative in the test.rb;
Fixed the warning about Proc.new deprecated.


Docs: User Entity Page Updates

(docs): Implementing the necessary changes for the User Entity page based on Paz's feedback.
This PR takes care of Issue #482.

Thanks for the feedback, @PazYanoverr. @mulygottlieb, I'll keep posted for yours!

@PazYanoverr @dericksozo I added my comment but all in all it looks great.
One more thing that we need to think about (not necessarily a blocker for this PR) - in .NET this works a bit differently and we need to document that separately (the names of the Auth plugin(s) are different, and the process behind the scenes of using ASP.NET Core Identity is a bit different). We can decide to open a ticket about that for later on so we don't block this PR any longer.

Thanks @mulygottlieb !
@dericksozo - Can you please apply Muly's comments and open a separate ticket for the .NET part?


Smoke: Notebooks moves focus as it inserts/deletes a cell

VSCode Smoke Tests (Electron)
VSCode Smoke Tests (Electron)
Notebooks
moves focus as it inserts/deletes a cell:
Error: Timeout: get text content '.notebook-editor .monaco-list-row.focused .monaco-editor .view-lines' after 20 seconds.
at /Users/runner/work/1/s/test/automation/out/code.js:182:23
at Generator.next ()
at fulfilled (/Users/runner/work/1/s/test/automation/out/code.js:9:58)

From 8e9beffcf5141874d64e4410d2166750cbf9c373

Seems fine in https://dev.azure.com/monacotools/Monaco/_build/results?buildId=89410&view=logs&j=3792f238-f35e-5f82-0dbc-272432d9a0fb&t=6ba55b26-6502-59ae-6c43-7e580fa53cb9&l=45


no bin/www directory, null error after run by 'node app.js'

Hi I wanted to try this, but I figured out 2 errors:

after npm install & bower install there is missing bin/www as is written in wiki
after 'node app.js '  there is only 'null' written in terminal.
I figured out that it comes from async.waterfall , from  error method  function (err) {
console.log(err);
}.

Does anybody know what coud be a problem ?

sorry for the mistake, bin folder was by default ignored.
I have added this folder into repo.


Client crash

I've tried the datapack on my vanilla server, versione 1.19.3, using a client with optifine (pre-release version).
It was winter and wen i right-clicked on an unemployed villager the game crashed.
I don't actually know if it's a problem from optifine or datapack itself.
In case, here is the crash report, hope it helps.
NOTE: Only the client crashed, the server remained online.
---- Minecraft Crash Report ----
// Hey, that tickles! Hehehe!
Time: 2023-03-03 22:41:05
Description: Getting block state
dbe: Missing Palette entry for index 1.
at day.a(SourceFile:64)
at dbh.a(SourceFile:157)
at dbh.a(SourceFile:151)
at dbb.a(LevelChunkSection.java:52)
at dba.a_(SourceFile:184)
at net.optifine.override.ChunkCacheOF.loadBlockStates(ChunkCacheOF.java:175)
at net.optifine.override.ChunkCacheOF.renderStart(ChunkCacheOF.java:148)
at fgl$c$b.a(ChunkRenderDispatcher.java:973)
at fgl$c$b.a(ChunkRenderDispatcher.java:909)
at fgl.lambda$runTask$0(ChunkRenderDispatcher.java:196)
at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768)
at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1760)
at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)
A detailed walkthrough of the error, its code path and all known details is as follows:
-- Head --
Thread: Render thread
Stacktrace:
at day.a(SourceFile:64)
at dbh.a(SourceFile:157)
at dbh.a(SourceFile:151)
at dbb.a(LevelChunkSection.java:52)
at dba.a_(SourceFile:184)
-- Block being got --
Details:
Location: World: (-273,96,346), Section: (at 15,0,10 in -18,6,21; chunk contains blocks -288,-64,336 to -273,319,351), Region: (-1,0; contains chunks -32,0 to -1,31, blocks -512,-64,0 to -1,319,511)
Stacktrace:
at dba.a_(SourceFile:184)
at net.optifine.override.ChunkCacheOF.loadBlockStates(ChunkCacheOF.java:175)
at net.optifine.override.ChunkCacheOF.renderStart(ChunkCacheOF.java:148)
at fgl$c$b.a(ChunkRenderDispatcher.java:973)
at fgl$c$b.a(ChunkRenderDispatcher.java:909)
at fgl.lambda$runTask$0(ChunkRenderDispatcher.java:196)
at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768)
at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1760)
at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)
-- Affected level --
Details:
All players: 1 total; [fcz['CecchinoG24'/129, l='ClientLevel', x=-272.77, y=98.00, z=355.33]]
Chunk stats: 3025, 690
Level dimension: minecraft:overworld
Level spawn location: World: (0,135,0), Section: (at 0,7,0 in 0,8,0; chunk contains blocks 0,-64,0 to 15,319,15), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,-64,0 to 511,319,511)
Level time: 6449311 game time, 10636530 day time
Server brand: vanilla
Server type: Non-integrated multiplayer server
Stacktrace:
at eyz.a(ClientLevel.java:583)
at ejf.d(SourceFile:2390)
at ejf.f(SourceFile:874)
at ejf.e(SourceFile:770)
at net.minecraft.client.main.Main.a(SourceFile:244)
at net.minecraft.client.main.Main.main(SourceFile:51)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:159)
at net.minecraft.launchwrapper.Launch.main(Launch.java:30)
-- Last reload --
Details:
Reload number: 1
Reload reason: initial
Finished: Yes
Packs: vanilla
-- System Details --
Details:
Minecraft Version: 1.19.3
Minecraft Version ID: 1.19.3
Operating System: Windows 10 (amd64) version 10.0
Java Version: 17.0.3, Microsoft
Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Microsoft
Memory: 847503440 bytes (808 MiB) /<PHONE_NUMBER> bytes (2880 MiB) up to<PHONE_NUMBER> bytes (7168 MiB)
CPUs: 8
Processor Vendor: GenuineIntel
Processor Name: Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz
Identifier: Intel64 Family 6 Model 158 Stepping 9
Microarchitecture: Kaby Lake
Frequency (GHz): 3.60
Number of physical packages: 1
Number of physical CPUs: 4
Number of logical CPUs: 8
Graphics card #0 name: NVIDIA GeForce GTX 1050 Ti
Graphics card #0 vendor: NVIDIA (0x10de)
Graphics card #0 VRAM (MB): 4095.00
Graphics card #0 deviceId: 0x1c82
Graphics card #0 versionInfo: DriverVersion=<IP_ADDRESS>18
Memory slot #0 capacity (MB): 8192.00
Memory slot #0 clockSpeed (GHz): 2.40
Memory slot #0 type: DDR4
Memory slot #1 capacity (MB): 8192.00
Memory slot #1 clockSpeed (GHz): 2.40
Memory slot #1 type: DDR4
Virtual memory max (MB): 20691.72
Virtual memory used (MB): 18530.65
Swap memory total (MB): 4393.06
Swap memory used (MB): 264.19
JVM Flags: 9 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx7G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M
Launched Version: 1.19.3-OptiFine_HD_U_I2_pre5
Backend library: LWJGL version 3.3.1 build 7
Backend API: NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2 GL version 3.2.0 NVIDIA 531.18, NVIDIA Corporation
Window size: 1920x1080
GL Caps: Using framebuffer using OpenGL 3.2
GL debug messages:
Using VBOs: Yes
Is Modded: Very likely; Client jar signature invalidated
Type: Client (map_client.txt)
Graphics mode: fancy
Resource Packs: vanilla
Current Language: English (US)
CPU: 8x Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz
OptiFine Version: OptiFine_1.19.3_HD_U_I2_pre5
OptiFine Build: 20230219-203817
Render Distance Chunks: 15
Mipmaps: 4
Anisotropic Filtering: 4
Antialiasing: 0
Multitexture: true
Shaders: null
OpenGlVersion: 3.2.0 NVIDIA 531.18
OpenGlRenderer: NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2
OpenGlVendor: NVIDIA Corporation
CpuCount: 8

This is an optifine crash - you'll have to report that to them.


Group assets by packages

Is your feature request related to a problem? Please describe.
Currently missing files are being shown individually and there no way to get from which package they are
Describe the solution you'd like
Group individual files to packages or paid DLCs with option to display all included files. Unknown files would be displayed still same or under "Unknown" package.
I would like to see similar approach as with Files and Dependencies on web package page.
Describe alternatives you've considered
Optionally it could be done just same as routes, so double clicking on package would popup included files dialog.
Additional context
It would be really helpful for users to see that route is requiring e.g. DLC Munich to Garmisch route with option to display individual files, instead of seeing that it needs RSC/MG_addons/../tunnel_decal.bin

Partially resolved by @Zdendaki in 82a2835 for the price of significant performance decrease. Should be further optimised. #

Resolved by Zdendaki in 614c1de by splitting deps window into known packages and other files.


[Draft] Optimize ThreadStateBar

Work needs to be done, because some pixels are not rendered correctly, but it's a draft to be used to compare.

This was a draft PR to be used to compare performance. The ThreadStateBar optimization is implemented in https://github.com/google/orbit/pull/4337, so I will close this one.


rankerType got from options in QnA constructor

Fixes #1951
Description
rankerType option passed as option parameter in QnA constructor was ignored
Specific Changes

rankerType got from options parameters in QnA constructor
unit test 'should call qnamaker with rankerType questionOnly' updated

Testing

no tests added, only above mentioned test has been updated

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: deivkk sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @vipeketi for your comment.
Not sure if I understand you, do you refer to the unit test response json? If so, I have to accept that I couldn't test the real qna service after providing the rankerType option because I assume that the qna api keys are not published. So I opted to modify directly the mock.
If someone could provide the real answer from qna service for the updated unit test, I will adapt the mock.

It was not clear to me on why the test response was modified to empty list in test case, for this code change. It is clear to me now.
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: deivkk<EMAIL_ADDRESS>Sent: Friday, March 27, 2020 2:54:57 PM
To: microsoft/botbuilder-js<EMAIL_ADDRESS>Cc: Vijaya Peketi<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [microsoft/botbuilder-js] rankerType got from options in QnA constructor (#1953)
Thanks @vipeketihttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fvipeketi&data=02|01|VIJAYA.PEKETI%40microsoft.com|8108c54affd94d685cd308d7d230b7e3|72f988bf86f141af91ab2d7cd011db47|1|0|637208978994655913&sdata=GB9OigZbLomzpUm3bj2AsOa2ce9qKCyALYcYZRCRgPM%3D&reserved=0 for your comment.
Not sure if I understand you, do you refer to the unit test response json? If so, I have to accept that I couldn't test the real qna service after providing the rankerType option because I assume that the qna api keys are not published. So I opted to modify directly the mock.
If someone could provide the real answer from qna service for the updated unit test, I will adapt the mock.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fbotbuilder-js%2Fpull%2F1953%23issuecomment-604900176&data=02|01|VIJAYA.PEKETI%40microsoft.com|8108c54affd94d685cd308d7d230b7e3|72f988bf86f141af91ab2d7cd011db47|1|0|637208978994665905&sdata=JvecpACKaC4yD701aDorUt1tBEjZCeSwUtDYSAVibFU%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAN4DXHJPW3NLOZZUE6F5PZ3RJRWGTANCNFSM4LUQ7W7A&data=02|01|VIJAYA.PEKETI%40microsoft.com|8108c54affd94d685cd308d7d230b7e3|72f988bf86f141af91ab2d7cd011db47|1|0|637208978994665905&sdata=Pzh5Evr6ojbvZuI8Hy%2FyTauhONqGb0VIZTIiX7UVsKI%3D&reserved=0.

This pull request can be automatically merged by project collaborators
Only those with write access to this repository can merge pull requests.

Who can do that?

Merged changes.


Fixes for Astro v3

What kind of changes does this PR include?

Changes to Starlight code

Description

Astro v3 sets compressHTML to true by default.
Due to https://github.com/withastro/compiler/issues/852 there were a couple of places meaningful whitespace got collapsed in Starlight’s layouts.
This PR fixes though with some explicit whitespace to preserve previous behaviour.
No changeset as this change is basically just part of #615.

size-limit report 📦

Path
Size

/index.html
9.42 KB (0%)

/_astro/*.js
16.33 KB (0%)

/_astro/*.css
8.7 KB (0%)


feat: add token auth method

This allow users to use directly VAULT_TOKEN as authentication method.

Hi @Eywek!
I am sorry that we didn't managed to review your PR. This repository will be deprecated soon ( https://github.com/onebeyond/confabulous-vault-loader/pull/6), let us know if you still depending on it.


test for failing union values

Related to this (and other things), passes in 2.1.4
https://github.com/ash-project/ash_phoenix/issues/253
Contributor checklist

[ ] Bug fixes include regression tests
[ ] Features include unit/acceptance tests

🚀 Thank you for your contribution! 🚀


No napi-v6-darwin-arm64-unknown target available

Currently, M1/M2 Macs are not supported by this project. It would be nice to provide napi-v6-darwin-arm64-unknown target.

The original repo also does not provide a prebuilt library. You should build the entire project on your machine to use.

It supports now. I copied it from upstream.


connector/ldap: fix port parsing

Fixes https://github.com/coreos/dex/issues/1204
Closes https://github.com/coreos/dex/pull/1205
cc @rithujohn191

Closing. See https://github.com/coreos/dex/issues/1204#issuecomment-374772901


Make db.sync public

Use case
When using multiple databases at once, enabling the background sync feature in all of them would be redundant for most filesystems.
The current workaround, deciding which of them to enable background sync on, can get needlessly complicated.
Alternatives

add a helper for the multi-db use case

I was going to make the sync method public, thank you! I'm also considering removing the background sync feature and adding a new SyncWrites option that makes pogreb call sync after every write operation.

new SyncWrites option that makes pogreb call sync after every write

Aaargh, you sure? My code is showing 2-minute sync times, and the database isn't even at 100 GB.

My code is showing 2-minute sync times, and the database isn't even at 100 GB.

That seems very slow, have you tested the same data with LevelDB or Bolt? They call fsync after every write operation.

No, I haven't. Granted, the point of my code (which only syncs every few minutes) is to see what happens when I hit the [2 << 30]https://github.com/akrylysov/pogreb/issues/11 key limit, and if my computer hits a hard performance wall before then.

Thank you!

You're welcome.
The Sync function is last in godoc. Huh.

My code is showing 2-minute sync times, and the database isn't even at 100 GB.

That seems very slow

P.S. I'm not sure about my claim: the slowdowns I see could very well instead be a combination of collisions and hard drive seeks.


[ASK] Example to use DetectionLearner in distributed training

Description

I'd like to use the DetectionLearner in distributed training, but looks current notebooks are only single GPU training. Is there any example to follow? Many thanks!

Hi, our implementation is based on torchvision's example code in their "references" folder. See here what I exactly mean by that, and also e.g. train.py here which we use. As you can see, it supports distributed training, however I don't think we ever tried it.


[Testing] Reduce duplication in functional tests

Thanks to @HaoK for his suggestion in PR #2137: Switch to a shared _client field for functional tests.  In almost-all cases, the server is configured identically for all test methods.  For example,
  private readonly HttpClient _client;

  public ActionResultTests()
  {
    var server = TestHelper.CreateServer(_app, SiteName);
    _client = _server.CreateClient();
  }

(Might be worth a script to delete the existing var server and var client initialization lines.  Have about 650 references just to the CreateServer() overload shown above and about 75 test classes.)

We decided this isn't worth doing.


BUG: Profit and Loss over $400 on creation of a bot and TVL is appears incorrect.

New Bot! - Bot Name: leverage, Token Input: tbtc, Amount Input: 5978.72, Token Output: crvusd, Amount Output: 31970.59, Chain Name: ETH.
Transaction:
https://etherscan.io/tx/0x7007aef02f33282e3638a2f544acbebfd3f01a81954ecc7704106eaac718b382
My bots page:

Bot shows profit of $400 immediately on creation
TVL amount is $38,383.40, but Amount Output is $31970.59

@rootedbox @jamie088 One thing I'd check is the pricing of tBTC and make sure it's correct. There's a slight difference in price between wbtc and tbtc.

@fieldtheory123 Checked the tBTC price and no issue.

@taariq checked user transaction and FE but couldn't find the problem. We used this formula to calculate TVL and PnL.: https://www.notion.so/volumefi/PNL-and-TVL-calculation-for-bots-734b59446f084078b5f22733b1042d76
@fieldtheory123 Could you please check the TVL and PnL formula of the Curve leverage lending bot again?

Both formulas look fine to me

Closing as won't fix. the profit is real.


Integration with elasticsearch to save results

Feature request.
Possibility to save results to elasticsearch.
Plugin - https://github.com/delirius325/jmeter-elasticsearch-backend-listener could be used.

Sure, that looks interesting. Thank you for requesting this.
We will consider it for an upcoming release.
Stay tuned :-).

We have just released a new version with requested feature. Check the new user guide section for details.

Thanks a lot for implementing it quickly.


ray-operator: parameterize Test_ShouldDeletePod

Why are these changes needed?
Parameterizing Test_ShouldDeletePod following the review comment here: https://github.com/ray-project/kuberay/pull/1386#pullrequestreview-1611687999
Also I'm assuming https://github.com/ray-project/kuberay/issues/1392 talks about Test_ShouldDeletePod and not Test_RunningPods_RayContainerTerminated? Lmk!
Related issue number
Fixes https://github.com/ray-project/kuberay/issues/1392
Checks

[x] I've made sure the tests are passing.
Testing Strategy

[x] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

@kevin85421 / @architkulkarni could you PTAL whenever you get a chance, thanks!

Thanks for the comments @kevin85421! I've addressed them.


Add p-try to fix tests

Now it's not possible to run tests locally, because project is missing p-try module.

@TrySound can you take a look, please?

Everything works without p-try. Not sure what's the problem you see.

In the latest master I have:

Try to use npm 6

Problem was reproduced with npm@7. npm@6 doesn't work either:

Try npm ci

I think, it should be possible to run tests with any npm locally.

I'm trying to figure out the problem. npm ci command does not updates dependencies implicitly.

Can't do that locally. Can you have an idea, what can be wrong?

A have a feeling npm is bullshitting us

A have a feeling npm is bullshitting us

Very likely! 😅

Migrated to jest. Though I think the problem in package manager or maybe fs.

Ok, nice!


BSD socket activation behaviour

There is no systemd in BSDs, and It would be good if we can abstract from the OS's way of socket activation/binding to a non existent IP, and let the daemon do the work.
FreeBSD - IP_BINDANY
OpenBSD - SO_BINDANY

Do you know how to achieve that in Go?
I don't see any ways to set socket options before bind(2) is called.

I'm not very good at golang, but I guess we need to make a syscall. Here is an example for linux:
syscall.SetsockoptInt(fileDescriptor, syscall.SOL_IP, syscall. IP_FREEBIND, 1)
and fileDescriptor can be gathered from listenerUDP

@jedisct1 In any case, I may try that out and send a PR

Syscalls can be made, but once we get listenerUDP, the bind(2) call was already made, so it's too late.
It would be wonderful if you could help :)

Here's how it might be possible to do it, thanks to @rs:
https://gist.github.com/rs/06f481daa37773afd677595f8450dfaf


Vickel: Watch websitemaintenanceservices.store

Vickel requests the watch of the watch_keyword websitemaintenanceservices\.store. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

websitemaintenanceservices\.store has been seen in 1 true positive, 0 false positives, and 0 NAAs.


fix: update @usebruno/js to a working version in bruno-electron

update bruno-electron to use v0.9.1 of @usebruno/js closes #751 and closes #749

The problem was that @usebruno/js v0.9.0 is a broken version (contains code that references packages not in the package.json file). This will require a new version of bruno-electron to be cut and released.

Thanks @jwetzell 🙏


Tweak REST function whitelisting and IP whitelisting code

Change summary:

Add isWhitelistedUrl() with tests for REST function whitelisting
Add isWhitelistedIp() with tests for IP whitelisting
Add logging for ip whitelising check
Allow tailing / at the end of endpoint url for api access tools
Rename: addToWhiteListNodeParam.js -> addToWhitelistNodeParam.js

Thanks for the review! Now merging..


MINOR: Fix ConnectWorkerIntegrationTest::testBrokerCoordinator

This test case has become flaky since https://github.com/apache/kafka/pull/16477 was merged.
For a quick fix, we can give workers time to discover that the Kafka cluster has gone down in order for the health check endpoint to be accurate.
Ideally, this would not be necessary and we'd always detect that the Kafka cluster is down at the top of our tick loop here. However, with some rare-but-not-impossible timing, that method may return without sending any requests to the group coordinator. This is itself probably indicative of a bug, and if reviewers agree, we can file a Jira ticket for it. But, because this possibly-buggy behavior is not newly-introduced and the cause of failure for our tests is simply a failure to account for that existing behavior in newly-introduced logic, we should not block on a fix for that behavior before modifying this test case to prevent flakiness.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@gharris1727 would you mind taking a look at this? The fix is pretty straightforward, but the behavior that merits it is a little tricky; let me know if you'd like a more in-depth explanation of what I believe is causing the failures we've started seeing in CI.

Thanks Greg! Filed KAFKA-17130 to track the bug.
Will wait for CI to complete before merging.


The order of the returned urls change when a new plugin is added to the directory

API now is sorted os ascending creation date


Self Service Licensing must be OFF by default and not managed via PowerShell

Thanks for responding Microsoft, but the self-service licensing must be off by default, not on.  And be configurable using opt-in / opt-out radio buttons on the admin centre, not via PowerShell,  Otherwise you are just creating more issues for companies not large enough to have a fulltime / qualified IT Pro to manage this for them.

@VeroniquePalmer  - May we know which Microsoft document link you used in reference to this issue?
Please share it with us so we can investigate further. Thank you.

This one, sorry, I couldn't figure out how to add the comment to the thread.
https://docs.microsoft.com/en-gb/microsoft-365/commerce/subscriptions/self-service-purchase-faq
Sent from my phone, please excuse any brevity or typos
-------- Original message --------
From: "Joyce Y."<EMAIL_ADDRESS>Date: 2019/11/01 16:51 (GMT+02:00)
To: MicrosoftDocs/microsoft-365-docs<EMAIL_ADDRESS>Cc: Veronique Palmer<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/microsoft-365-docs] Self Service Licensing must be OFF by default and not managed via PowerShell (#668)
@VeroniquePalmerhttps://github.com/VeroniquePalmer - May we know which Microsoft document link you used in reference to this issue?
Please share it with us so we can investigate further. Thank you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/microsoft-365-docs/issues/668?email_source=notifications&email_token=ALVZWZ3Y45G6YEMZDOAPUHTQRQ7APA5CNFSM4JHXDWOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC3EQPQ#issuecomment-548816958, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALVZWZ77SJQVJL6P25SSXZLQRQ7APANCNFSM4JHXDWOA.

To further comment on this - just so MSFT is aware, these self-service policies have resulted in us updating our Acceptable Use Policy to include use of the self-service options as a fireable offense.  I assume it is not MSFT's intent to cost people their jobs but that is what these changes are exposing the end-users to.

@UmbraTenebrae  Thank you for your feedback, Microsoft looks to balance the needs across its customer base including IT Pros and users.  By providing a per application toggle through Powershell and providing adequate notification we are looking to provide IT organizations the control they need while ensuring consideration is given to the features intended to provide end-user productivity value.

What about all the companies out there that are NOT IT companies…..?
From: Cern McAtee<EMAIL_ADDRESS>Sent: 06 November 2019 08:51 PM
To: MicrosoftDocs/microsoft-365-docs<EMAIL_ADDRESS>Cc: Veronique Palmer<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/microsoft-365-docs] Self Service Licensing must be OFF by default and not managed via PowerShell (#668)
@UmbraTenebraehttps://github.com/UmbraTenebrae Thank you for your feedback, Microsoft looks to balance the needs across its customer base including IT Pros and users. By providing a per application toggle through Powershell and providing adequate notification we are looking to provide IT organizations the control they need while ensuring consideration is given to the features intended to provide end-user productivity value.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/microsoft-365-docs/issues/668?email_source=notifications&email_token=ALVZWZYJI2SHEIT7ZVWWF3TQSMG2FA5CNFSM4JHXDWOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDHTAAQ#issuecomment-550449154, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALVZWZ7K2O6BV3ELFZYLQSTQSMG2FANCNFSM4JHXDWOA.


Feature/unit feeds

It's a little ugly - but I'll take over on clean-up when you're finished! 👍

ah i forgot i need to add a unit indicator for created posts. will do that shortly.

@JoshFabian Can you design in the branch here?
@matthewdias Conflicts :sob:


[rowset id] A little improvement of rowset id generator

could you add some description of the optimization and add some profile test demonstration.


[DRILL-3300] Bug fix: Unused method parameter

Fixed a bug whereby HBaseGroupScan.setFilterPushedDown(boolean) was not using the value
passed to it to set an internal flag. Instead the method was always
setting the value to 'true'.

This change has already been made in the latest master.


hack: build and tag core first before attempting to build base

@praiskup PTAL
I wonder if this can be done in a nicer way without overriding the original rule...

This is work-around which "knows too much" about the internals, and should work.  Long-term fix could be to have tag-core and tag-base targets (generated similarly to $(VERSIONS)) and we could depend on it.

LGTM

Long-term fix could be to have tag-core and tag-base targets (generated similarly to $(VERSIONS)) and we could depend on it.

As this solution has its own problems and would additionally need changes in container-common-scripts, I will go with what is already in this PR (overriding default rules) and fix it properly in the future, once we find the right way to do it.

The failure in rhel CI is outside of the build so I think this is an issue with the CI and not the PR (similarly to what was encountered in https://github.com/sclorg/postgresql-container/pull/188) and should be safe to merge as any problems with the build process would likely come up on centos as well.

Agreed.


Standardize Names Transformation and Copy AST

Add a transformation to standardize names throughout an Alpha system. This is done top-down, that way a parent's names are set before visiting its children.
This PR also adds a function which performs a deep copy on an AST (or part of an AST), as both Louis and I will need it soon.
When updating the names within an expression, the names to use are determined as follows:

If the expression's parent is a standard equation:

Names on the left-hand side of the equation.
The names used when declaring the variable.
Default names are selected.

If the parent is a dependence expression:

The names from the parent dependence function's output dimensions are used.

If the parent is a reduce expression:

The names from the parent reduction's projection function's output dimensions are used.

Otherwise:

The names come from the parent's context domain.

Once names are selected, the following updates are performed:

The context domain's indices are set to the selected names.
The expression domain's indices are set to the selected names.
If the expression is a restrict expression:

The restrict domain's indices are set to the selected names.

If the expression is a dependence expression:

The dependence function's inputs are set to the selected names.
The dependence function's outputs are set to some default names.

Looks nice, just two things:

What happens with reduceExpressions? Should the input names of the projection function not be standardized as well?
This should be happening anywhere that ISL objs live in the AST, right?

context domains
expression domains
restrict expressions
dependence expressions
reduce expressions
is this it? or am I missing more?

Since this adds new unit tests, could you please add it to the junit tests step in the .github/workflows/build.yaml file too?

Just checked, looks like I missed both index expressions and reduce expressions. I'll add those now

Note: the latest push doesn't include unit tests for index or reduce expressions. I will add those either later today or tomorrow morning

Todo for me (and maybe Louis can answer this): can a function share names between input and output dimensions? If so, outputs computed as just being an input should have this done (e.g., the first two output dimensions in (i,j,i1,j1 -> i,j,i1-j1).

Todo for me: can a function share names between input and output dimensions? If so, outputs computed as just being an input should have this done (e.g., the first two output dimensions in (i,j,i1,j1 -> i,j,i1-j1).

I believe ISLMultiAffs don’t have output dimension names, but maps do because maps have constraints. And names are needed to describe the constraints. For example this snippet,
// ISLMultiAff

var maff = '{[i,j,i1,j1]->[i,j,i1-j1]}'.toISLMultiAff
println('maff1')
println(maff.space.getInputNames)
println(maff.space.getOutputNames)
println

// ISL(Basic)Map

var map = maff.copy.toBasicMap
println('map1')
println(map.getInputNames)
println(map.getOutputNames)
println('---')
map.getConstraints.forEach[c | println(c)]
println('---')
println

map = '{[i,j,i1,j1]->[a,b,c] : a=i and b=j and c=i1-j1}'.toISLBasicMap
println('map1')
println(map.getInputNames)
println(map.getOutputNames)
println('---')
map.getConstraints.forEach[c | println(c)]
println('---')

generates this output:
maff1
[i, j, i1, j1]
null

map1
[i, j, i1, j1]
null
---
{ [i, j, i1, j1] -> [o0, o1, o2] : -i1 + j1 + o2 = 0 }
{ [i, j, i1, j1] -> [o0, o1, o2] : -j + o1 = 0 }
{ [i, j, i1, j1] -> [o0, o1, o2] : -i + o0 = 0 }
---

map1
[i, j, i1, j1]
[a, b, c]
---
{ [i, j, i1, j1] -> [a, b, c] : -i1 + j1 + c = 0 }
{ [i, j, i1, j1] -> [a, b, c] : -j + b = 0 }
{ [i, j, i1, j1] -> [a, b, c] : -i + a = 0 }
---

I believe ISLMultiAffs don’t have output dimension names, ...

Looks like the space of a multi-aff is a map space, and does allow setting the names. While this doesn't affect how the multi-aff is printed, it does affect how the space is printed, and the names can be retrieved later on. See the snippet below, and the output it produces.
Code:
import islpy as isl

maff = isl.MultiAff('{[i,j]->[i,j]}') \
    .set_dim_name(isl.dim_type.out, 0, 'i') \
    .set_dim_name(isl.dim_type.out, 1, 'j')

print(f'1st out name: {maff.get_dim_name(isl.dim_type.out, 0)}')
print(f'2nd out name: {maff.get_dim_name(isl.dim_type.out, 1)}')

Output:
1st out name: i
2nd out name: j

Got it. So in either case, we just want to make sure that the names appearing on the right-hand side of any ISLMultiAffs match the names in the context domain. I don’t see anywhere else that’s missing.
Could we just add a few unit tests for reduce and index expressions. For reduce, maybe something like:
affine useEquationNames2 [N]->{:N>5}
 	inputs X: {[j]: 0<=j<N}
 	outputs Y: {[q]: 0<=q<N}
 	let Y[p] = reduce(+, [j,k], {: 0<=k<=j<=p} : X[j]);
.

affine useVariableNames3 [N]->{:N>5}
 	inputs X: {[j]: 0<=j<N}
 	outputs Y: {[q]: 0<=q<N}
 	let Y = reduce(+, (t,i,j->t), {: 0<=j<=i<=t} : X[t+j]);
.

I’m not sure how the parser will create the projection ISLMultiAff when the bracket syntax [] is used since this doesn’t explicitly denote some of the input names.
In these cases, we’d expect that the depExpr on B after standarization are:

(p,j,k->j)
(q,j,k->q+j)

respectively, ...right?

Great! Thanks for adding those extra tests, this looks good to me.
If you don’t have anything else to push, feel free to merge whenever.