ZodError when initializing PrismaClient

Hello,
I'm currently trying to integrate this libary into my database, I am on version "prisma-field-encryption": "^1.6.0" and am getting the following error when trying to init the prisma client with this lib.
dashboard:dev:  ⨯ ZodError: [
dashboard:dev:   {
dashboard:dev:     "code": "invalid_type",
dashboard:dev:     "expected": "object",
dashboard:dev:     "received": "undefined",
dashboard:dev:     "path": [],
dashboard:dev:     "message": "Required"
dashboard:dev:   }
dashboard:dev: ]

const client = new p.PrismaClient();

console.log(env.PRISMA_FIELD_ENCRYPTION_KEY); // example output: k1.aesgcm256.DbQoar8ZLuUsOHZNyrnjlskInHDYlzF3q6y1KGM7DUM=

export const db = client.$extends(
  fieldEncryptionExtension({
    encryptionKey: env.PRISMA_FIELD_ENCRYPTION_KEY,
  })
) as p.PrismaClient;

I have checked the output of env.PRISMA_FIELD_ENCRYPTION_KEY and can confirm that it is not undefined. It outputs a cloak secret key similar to the example in your README - k1.aesgcm256.DbQoar8ZLuUsOHZNyrnjlskInHDYlzF3q6y1KGM7DUM=
An example of my prisma schema can be found below.
generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider  = "postgresql"
  url       = env("DATABASE_URL")
}

model CustomInstance {
  id             Int            @id @default(autoincrement())
  guildId        String         @unique
  token          String /// @encrypted

  createdAt DateTime @default(now())
}

The Zod error isn't very helpful as it doesn't say what key name is the wrong type, at first I thought it was the PRISMA_FIELD_ENCRYPTION_KEY environment variable, but after double checking it is not that, as I get he correct output from it, i also tried hard coding the secret just encase and I still get the same Zod error.
The reason I know why it is this libary causing the issue is because when I remove the fieldEncryptionExtension function call I do not get the error, and I also get this traceback in my nextjs application:

If there is anymore information that I can provide please let me know :)

What's your Prisma version?
You may have more luck seeing what's going on with logging: https://github.com/47ng/prisma-field-encryption#debugging

What's your Prisma version?
You may have more luck seeing what's going on with logging: https://github.com/47ng/prisma-field-encryption#debugging
The Zod error indicates an object being missing, could that be the dmmf? Looks like you're importing your Prisma client from a p namespace, maybe passing the dmmf from that could help?
export const db = client.$extends(
  fieldEncryptionExtension({
    encryptionKey: env.PRISMA_FIELD_ENCRYPTION_KEY,
    dmmf: p.dmmf
  })
) as p.PrismaClient;

Hi, I am currently on prisma version "prisma": "5.21.1",. I have enabled logging for your library, the output can be seen below:
bot:dev: 2024-10-27T21:34:25.936Z prisma-field-encryption:setup Keys: {
bot:dev:   encryptionKey: {
bot:dev:     raw: Uint8Array(32) [...],
bot:dev:     fingerprint: '...'
bot:dev:   },
bot:dev:   keychain: { dfd6b438: { key: [Object], createdAt:<PHONE_NUMBER>935 } }
bot:dev: }
bot:dev: C:\Users\ben\OneDrive\Desktop\remake\node_modules\.pnpm\zod@3.23.8\node_modules\zod\lib\types.js:55
bot:dev:                 const error = new ZodError_1.ZodError(ctx.common.issues);
bot:dev:                               ^
bot:dev:
bot:dev: ZodError: [
bot:dev:   {
bot:dev:     "code": "invalid_type",
bot:dev:     "expected": "object",
bot:dev:     "received": "undefined",
bot:dev:     "path": [],
bot:dev:     "message": "Required"
bot:dev:   }
bot:dev: ]
bot:dev:     at get error [as error] (C:\Users\ben\OneDrive\Desktop\remake\node_modules\.pnpm\zod@3.23.8\node_modules\zod\lib\types.js:55:31)
bot:dev:     at ZodReadonly.parse (C:\Users\ben\OneDrive\Desktop\remake\node_modules\.pnpm\zod@3.23.8\node_modules\zod\lib\types.js:160:22)
bot:dev:     at analyseDMMF (C:\Users\ben\OneDrive\Desktop\remake\node_modules\.pnpm\prisma-field-encryption@1.6.0_@prisma+client@5.16.1_prisma@5.21.1_\node_modules\prisma-field-encryption\dist\dmmf.js:8:45)
bot:dev:     at fieldEncryptionExtension (C:\Users\ben\OneDrive\Desktop\remake\node_modules\.pnpm\prisma-field-encryption@1.6.0_@prisma+client@5.16.1_prisma@5.21.1_\node_modules\prisma-field-encryption\dist\extension.js:12:43)
bot:dev:     at file:///C:/Users/ben/OneDrive/Desktop/remake/apps//dist/database.js:5:35
bot:dev:     at ModuleJob.run (node:internal/modules/esm/module_job:222:25)
bot:dev:     at async ModuleLoader.import (node:internal/modules/esm/loader:316:24)
bot:dev:     at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:123:5) {
bot:dev:   issues: [
bot:dev:     {
bot:dev:       code: 'invalid_type',
bot:dev:       expected: 'object',
bot:dev:       received: 'undefined',
bot:dev:       path: [],
bot:dev:       message: 'Required'
bot:dev:     }
bot:dev:   ],
bot:dev:   addIssue: [Function (anonymous)],
bot:dev:   addIssues: [Function (anonymous)],
bot:dev:   errors: [
bot:dev:     {
bot:dev:       code: 'invalid_type',
bot:dev:       expected: 'object',
bot:dev:       received: 'undefined',
bot:dev:       path: [],
bot:dev:       message: 'Required'
bot:dev:     }
bot:dev:   ]
bot:dev: }

I'm not entirely sure what DMMF is, but my prisma client doesn't have a p.dmmf field.
Property 'dmmf' does not exist on type 'typeof import("C:/Users/ben/OneDrive/Desktop/remake/packages/database/dist/index")'.ts(2339)
I am exporting the prisma client in a monorepo package called "database" as follows:
export * from "@prisma/client";
and then importing it into my apps using import * as p from "database";
I have of course ran prisma generate, etc and my schema is generated and up to date.

I see, it's indeed the DMMF (the internal representation of your Prisma schema as a JS object) that's missing.
Sounds like you'll need to export it along your Prisma Client in your database package, and import it and pass it to the prismaFieldEncryptionExtension.
So basically, this section of the docs, but adapted for your monorepo setup:
https://github.com/47ng/prisma-field-encryption?tab=readme-ov-file#custom-prisma-client-location

I see, it's indeed the DMMF (the internal representation of your Prisma schema as a JS object) that's missing.
Sounds like you'll need to export it alongside your Prisma Client in your database package, and import it and pass it to the fieldEncryptionExtension.
So basically, this section of the docs, but adapted for your monorepo setup: https://github.com/47ng/prisma-field-encryption?tab=readme-ov-file#custom-prisma-client-location

Thank you so much, this resolved my problem :)


Write new option for 'global' alias that appends to zshrc

Maybe use aliasme for this?
https://github.com/Jintin/aliasme

This would allow for default option for local aliases (#11).


sll.uw alias for slli.uw

In the base ISA, rv32i, we allow sll to accept either a register or an immediate as the shift count.  sll with an immediate shift count is an alias for slli.  It was suggested that for consistency, we should allow sll.uw as an alias for slli.uw.

Is this still relevant for 1.0.0?
We don't list any pseudos/aliases there (in fact these were all removed following the consensus from the early reviews) — but we could start a separate section for them....


Server health/check

I just spent a few hours debugging why login wasn't working on a server.
Turns out it was because session_save_path wasn't writable.
It made me think, is there something we could do to help debug/check that a server is healthy?

We could do it in the installer. We could also add a page alert for this.

Downside of the installer is that it's usually run on the development environment, not the production environment.

@nitriques
Extension – not in the core!
The installer can use the extension.

@froschdesign Well, no sadly: they are the last thing to be installed.


Update type hints such that APIItemInfo.product_info is optional to m…

…atch Amazon responses.
Thank you for maintaining this repo!
I've found that in my code item_info.product_info is often None. The issue is that if I try to access something like ...item_info.product_info.release_date (e.g., for a movie), MyPy doesn't warn me that I need to make sure that item_info.product_info is not None, which it frequently is.
This PR makes product_info optional which should allow MyPy to flag code that doesn't check for a None type item_info.product_info.

This PR also now adds publication_date to ApiContentInfo as that's one of the parameters I'm frequently accessing from the Amazon API.

Thanks a lot for your contribution 👍


feat(Response): add support to Response for the Accept-Ranges header

add support to Response class for Accept-Ranges header
(https://tools.ietf.org/html/rfc7233#section-2.3)
Fixes #646

[Current coverage][cc-pull] is 100%

Merging [#815][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #815   diff @@
==========================================
  Files            29         29
  Lines          1775       1776     +1
  Methods           0          0
  Messages          0          0
  Branches        298        298
==========================================
+ Hits           1775       1776     +1
  Misses            0          0
  Partials          0          0

Powered by Codecov. Last updated by [10d1b7e...1813dc8][cc-compare]
[cc-base-branch]: https://codecov.io/gh/falconry/falcon/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/falconry/falcon/compare/10d1b7e770045b95ff5cb0cc3b4adfcc583049e2...1813dc8397e13fa728b906cec7c40ea28a6c935e
[cc-pull]: https://codecov.io/gh/falconry/falcon/pull/815?src=pr

@kgriffs i did a git rebase to latest master before adding your review comments and pep8 is failing but the issue is not coming from my changes. do you know what might have gone wrong?

There are two main errors:

F405....i am not sure how to handle that
F401....This comes from line 4 in utils/init.py. Add '# NOQA' at the end of the line will fix the issue

@ueg1990 Were you going to create a new PR?


javax.jcr.ItemExistsException returns a 500 and stack trace

It should be caught and a 4xx should be returned instead.
    STATUS: 500 javax.jcr.ItemExistsException: A node definition that allows same name siblings could not be found for the node "{}42" in workspace "default"
    at org.modeshape.jcr.JcrSession$JcrPreSave.processAfterLocking(JcrSession.java:2422)
    at org.modeshape.jcr.cache.document.WritableSessionCache.runPreSaveAfterLocking(WritableSessionCache.java:541)
    at org.modeshape.jcr.cache.document.WritableSessionCache.save(WritableSessionCache.java:614)
    at org.modeshape.jcr.JcrSession.save(JcrSession.java:1166)
    at org.fcrepo.http.api.FedoraLdp.createOrReplaceObjectRdf(FedoraLdp.java:301)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory$1.invoke(ResourceMethodInvocationHandlerFactory.java...

I think this occurs when two threads simultaneously try to create the same resource at the same time. Reported by @ojlyytinen here: https://github.com/projecthydra/sufia/issues/1362

Tracking with: https://jira.duraspace.org/browse/FCREPO-1872
..although reproducing the concurrent error has proven to be challenging. If you have a curl script, that would be helpful.

Which version of Fedora was used?

We have Fedora 4.1 on the server where we encountered this. We have a Sufia based Hydra setup and use Fedora through that but I think essentially what causes it is sending two requests at the same time to create a resource with the same path twice. Our server had a fairly high cpu load at the time (for unrelated reasons) which may have made it more susceptible to concurrency issues.

Closing this issue as it is being tracked in Jira as https://jira.duraspace.org/browse/FCREPO-2086 and there is already a corresponding pull request.


feat: unscoped association (#5899)

[X] Do only one thing
[X] Non breaking API changes
[X] Tested

What did this pull request do?

delete old records when Replace, Delete, Clear associations in Unscoped model.
Of course, permanent or soft deletion depends on DB.Unscoped.
See #5899
User Case Description

// Remove all reference between source & association, won’t delete those associations, set ForeignKey to nil
tx.Model(&item).Association("Contents").Clear()

// Soft delete
// UPDATE `item_contents` SET `deleted_at`= ...
tx.Model(&item).Association("Contents").Unscoped().Clear()

// Delete permanently
// DELETE FROM `item_contents` WHERE ...
tx.Unscoped().Model(&item).Association("Contents").Unscoped().Clear()

Did I do something wrong? The test failed.
SQLite: /home/runner/work/gorm/gorm/tests/associations_belongs_to_test.go:140 FOREIGN KEY constraint failed
MySQL: /home/runner/work/gorm/gorm/tests/associations_belongs_to_test.go:140 Error 1452 (23000): Cannot add or update a child row: a foreign key constraint fails (`gorm`.`users`, CONSTRAINT `fk_users_company` FOREIGN KEY (`company_id`) REFERENCES `companies` (`id`))

I searched by --- FAIL keyword, did not see the error you said in CI.
sqlite
--- FAIL: TestSerializerZeroValue (0.01s)
    serializer_test.go:143: failed to query data, got error unsupported Scan, storing driver.Value type string into type *time.Time

mysql
--- FAIL: TestAssociationUnscoped (0.02s)
    associations_test.go:423: failed to create items, got error: Error 13[66](https://github.com/go-gorm/gorm/actions/runs/4731373972/jobs/8396215932?pr=6246#step:6:67) (HY000): Incorrect string value: '\xD8\xA7\xD9\x84\xD8\xA7...' for column 'name' at row 2

I searched by --- FAIL keyword, did not see the error you said in CI. sqlite related to go-gorm/sqlite#133
--- FAIL: TestSerializerZeroValue (0.01s)
    serializer_test.go:143: failed to query data, got error unsupported Scan, storing driver.Value type string into type *time.Time

mysql seems to be related to this PR, or an existing bug has been tested.
--- FAIL: TestAssociationUnscoped (0.02s)
    associations_test.go:423: failed to create items, got error: Error 13[66](https://github.com/go-gorm/gorm/actions/runs/4731373972/jobs/8396215932?pr=6246#step:6:67) (HY000): Incorrect string value: '\xD8\xA7\xD9\x84\xD8\xA7...' for column 'name' at row 2

Got it.

Before this pr, we need to merge https://github.com/go-gorm/gorm/pull/6250  first (for SQLite test)
And https://github.com/go-gorm/gorm/pull/6127#discussion_r1171214125 (for MySQL test)
(Do I modify it directly in 6250? Or another pr?)

By the way,  how should I notify you @a631807682 .

Assignees
No one assigned

I don't use GitHub very well.

Both ok, because it's all about fixing unit tests.
Comment or update the code on an issue or PR I've commented on and I'll be notified, or just @me


MB-16012 loadtest verify

Jira ticket
Summary
Run the load test as an integration test, but do not require it to pass
How to test
This is a CI only change, so check out this PR and confirm that failures do not prevent merging
NOTE: This PR should only be merged after https://github.com/transcom/mymove/pull/10628

Messages

:book:
:link: MB-16012

  Generated by :no_entry_sign: dangerJS against de8224f1c1dc289502d080a8cdfca66894e4548f

This PR does not (yet) include the changes in https://github.com/transcom/mymove/pull/10628, and you can see the failure at https://app.circleci.com/pipelines/github/transcom/mymove/52831/workflows/d441a6b5-f615-444f-bb3f-08276b3cc1f9/jobs/883837
However, since integration_test_load is not a required check, the PR can still be merged if all other checks pass


Add space for ClusterNetworkPolicy option to align with the others

Add space for ClusterNetworkPolicy value in controller config to align with the others
Signed-off-by: Yuki Tsuboi<EMAIL_ADDRESS>

Thank you for pointing out. I made the changes.

/test-all

@yktsubo there are some merge conflicts, could you resolve? thanks.

Thanks, I rebased. Hopefully, that resolved the conflict.

/test-all


Passing logServerErrorDetail=false seems to not take effect

Describe the bug
I have passed logServerErrorDetail=false as part of the URL connecting to Aurora, but it seems SQL insertion errors still leak the data even tho the correct parameter is passed logServerErrorDetail=false, this works fine on postgres JDBC driver.
https://jdbc.postgresql.org/documentation/use/#:~:text=logServerErrorDetail
  `url: jdbc:aws-wrapper:postgresql://xxxx.eu-west-1.rds.amazonaws.com:5432/test_db?sslmode=verify-full&sslrootcert=/certs/global-bundle.pem&logServerErrorDetail=false`

Expected Behavior
When logServerErrorDetail=false is passed, the SQL insertion errors should report only the SQL statement without the data being inserted.
Example: having the following SQL which inserts a malformed json into a jsonb column.
java.sql.BatchUpdateException: INSERT INTO test_table(id, data) VALUES (?, (?)::jsonb)]; Batch entry 0 <unknown> was aborted: ERROR: invalid input syntax for type json
What plugins are used? What other connection properties were set?
auroraConnectionTracker,failover,iam
Current Behavior
When running a malformed SQL the actual data being inserted is logged.
example:
java.sql.BatchUpdateException: Batch entry 0 INSERT INTO test_table(id, data) VALUES ('7555d945-9be6-4c2a-a3ac-0721ff2bd45d', ('{"id":"7555d945-9be6-4c2a-a3ac-0721ff2bd45d","version":1619607230162000000.0000000000,}{')::jsonb) was aborted: ERROR: invalid input syntax for type json
Detail: Expected end of input, but found "{".
Reproduction Steps
Just try to insert or update into a table and trigger a DataIntegrityException by inserting under the same primary key twice & include
logServerErrorDetail=false
in the parameters.
Possible Solution
No response
Additional Information/Context
No response
The AWS Advanced JDBC Driver version used
2.2.4
JDK version used
oracle-jdk:17 (17.0.6+9-LTS-190)
Operating System and version
Red Hat Enterprise Linux 8.7 (Ootpa)

Hi @abdoofathy95,
Thanks for reaching out and raising this issue.
We'll take a look at this and keep you updated as we investigate.
Thank you for your patience!

Hi @abdoofathy95,
I tried to reproduce this issue by doing a batch execute to insert entries using the same primary key but the logServerErrorDetail parameter seemed to be working as expected. The test code looked like this:
private static final String connString = "jdbc:aws-wrapper:postgresql://database-pg-name.cluster-XYZ.us-east-2.rds.amazonaws.com:5432/connectionSample?logServerErrorDetail=false";
final Properties properties = new Properties();
properties.setProperty("user", "myUser");
properties.setProperty("wrapperPlugins", "auroraConnectionTracker,failover,iam");
properties.setProperty("wrapperLoggerLevel", "all");

try (Connection conn = DriverManager.getConnection(connString, properties)) {
  PreparedStatement statement = conn.prepareStatement("INSERT INTO myTable(test) VALUES(1)");
  statement.addBatch();
  statement.addBatch();
  statement.executeBatch();
} catch (SQLException e) {
  System.out.println(e.getMessage());
}

When the exception was caught, this is what the message contained when logServerErrorDetail was set to false:
Batch entry 0 <unknown> was aborted: ERROR: duplicate key value violates unique constraint "myTable_pkey"  Call getNextException to see other errors in the batch.

This seems consistent with how the PostgreSQL JDBC Driver behaves. Is there anything in this setup that you think might be missing or significantly different?
To figure out what the issue might be, I have a few questions for you:

Do you have a logger properties file set up? If so, how is it configured?
Are you able to provide logs? If not, can you confirm if it was a message from the AWS JDBC Driver logs, or from the PostgreSQL JDBC Driver logs?

Thank you!

Hey, thank you for your response, I will try to test this again and remove any "noise"
I have no logger properties file set up.
The logs are coming from PostgreSQL JDBC driver.


Benchmarking and e2e testing

Implement benchmarking tests for event indexing to gauge scalability of the solution.
The more concerning aspect of the scalability is query access of the storage as the size of the data grows. The aspect of keeping up with the events emitted related to EVM execution is not concerning.
We should also implement loaders that test the whole system on the benchmarking network (benchnet) which would be part of e2e testing.

A tool worth trying out for benchmark & load testing is https://www.paradigm.xyz/2023/06/flood

Let's start benchmarking using the flood tool https://github.com/paradigmxyz/flood
@m-Peter can you take this on and share here suggested strategy to benchmark and to stress-test.
Start by running everything against local emulator and EVM GW. After the test also inspect the output logs for any potential issues during the tests (unknown bugs).

@sideninja Sure thing :+1: I will get started on this, to get a feel of how it works and whether it works for our use-case, and will then share the findings.


We need a logo for this tool - give it some life!

This tool is so good, we gotta give it some pizzazz with a logo and/or mascot. 😈

Will do!


Roll Flutter Engine from 93da47847651 to 4f4e3ea89bef (10 revisions)

https://github.com/flutter/engine/compare/93da47847651...4f4e3ea89bef
2022-09-16<EMAIL_ADDRESS>Roll Dart SDK from 2aefa63a7781 to f5b17ab0bc11 (1 revision) (flutter/engine#36204)
2022-09-16<EMAIL_ADDRESS>Reland "Avoid vsync scheduling delay" (flutter/engine#36197)
2022-09-16<EMAIL_ADDRESS>Roll Skia from 837d57e2d779 to 2bd33c520540 (1 revision) (flutter/engine#36203)
2022-09-16<EMAIL_ADDRESS>Roll Skia from 4f7ea4898cc5 to 837d57e2d779 (1 revision) (flutter/engine#36201)
2022-09-16<EMAIL_ADDRESS>Roll Dart SDK from 326df62ba404 to 2aefa63a7781 (1 revision) (flutter/engine#36199)
2022-09-16<EMAIL_ADDRESS>Roll Skia from a9e11d1225cf to 4f7ea4898cc5 (1 revision) (flutter/engine#36198)
2022-09-16<EMAIL_ADDRESS>Roll Dart SDK from 3e8147f6ea16 to 326df62ba404 (1 revision) (flutter/engine#36196)
2022-09-16<EMAIL_ADDRESS>Roll Skia from 4d5a383d6f30 to a9e11d1225cf (1 revision) (flutter/engine#36195)
2022-09-16<EMAIL_ADDRESS>[Impeller] add support for COLR fonts and bitmap emojis (flutter/engine#36161)
2022-09-16<EMAIL_ADDRESS>Add path to current versions in the symlinks. (flutter/engine#36192)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Closing this to try to prod the autoroller to make a new PR with a necessary revert.

Commit queue failed; closing this roll.


KEP 973 workload-Priority

What type of PR is this?
/kind feature
What this PR does / why we need it:
Add support for workload Priority
Which issue(s) this PR fixes:
Fixes #973
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Add support for workload Priority

TODO: Change KEP based on this implementation

Is this ready for review or still a Draft?

@alculquicondor
It's a draft, but I would appreciate it if you could review it. I've implemented common parts.
Remaining tasks are 1. adding test cases, 2. implementing mutable features for workload priority (discussed on KEP).

Hi @alculquicondor, @tenzen-y
Could you review this PR ?
Though I will add other tests, the basic implementation has done.

/ok-to-test

Sorry for the late. I will review this PR today.

Sorry for the late. I will review this PR today.

Np, thank you so much!

/test pull-kueue-test-e2e-main-1-24

Hi @alculquicondor @tenzen-y,
Thank you so much for your review comments.
I have made the requested changes. Could you review it again?
Additionally, I haven't written tests for preemption and the queue. Should I write tests for them as well?

/approve-cancel

Hi @alculquicondor @tenzen-y,
Thank you so much for your review comments. I have made the requested changes. Could you review it again?
Additionally, I haven't written tests for preemption and the queue. Should I write tests for them as well?

I'm ok with not adding teets for the scheduler and preemptor since they depend only on priority values and priorityClassSources don't directly affect them.
WDYT? @alculquicondor

Hi @alculquicondor @tenzen-y,
Thank you so much for your review comments. I have made the requested changes. Could you review it again?
Additionally, I haven't written tests for preemption and the queue. Should I write tests for them as well?

I'm ok with not adding teets for the scheduler and preemptor since they depend only on priority values and priorityClassSources don't directly affect them.
WDYT? @alculquicondor

However, expanding integration tests for the job with the scheduler might be worth it.
https://github.com/kubernetes-sigs/kueue/blob/fd90aad36c52300493b1c980611946c134f13cde/test/integration/controller/jobs/job/job_controller_test.go#L706

Also, can you update e2e?

Hi @tenzen-y ,
Thank you so much for your comments!
Do you have any test cases I should check in the e2e tests?
I haven't read through the e2e test cases yet, but if you already have some additional cases in mind that should be added, I would appreciate it if you could let me know.

Hi @alculquicondor , @tenzen-y ,
I've fixed all comments and added e2e and integration test cases. Could you review it again?

Also, it would be better to squash all commits into one to avoid a huge commit message.

Hi @tenzen-y , @alculquicondor
Thank you so much for your detailed review! I've learned a lot from this PR.
I've fixed all comments, could you review it again?

Could you open a PR to add documentation for WorkloadPriorityClass?

Sure, do you mean I should add docs under here ?

Could you open a PR to add documentation for WorkloadPriorityClass?

Sure, do you mean I should add docs under here ?

Yes.


Add search input

Add search input for searching through filenames. Also adds option to get images based on orientation (eg. orientation:landscape) and extension (eg. extension:png)

Wow, this is exactly the feature I wanted to get! When it will be merged?

Thanks @poacher2k, this is great! Apols for the glacial response, will be looking into this next.

@robinpyon : nw, thank you for the nice plugin! I'm not very experienced with TypeScript, nor did I dive very deeply into the architecture here, so I'm sure I messed up a bit.

@poacher2k Not at all!
That's now in 0.4.0 – do have a go and let me know if you come across any issues. I took the opportunity to try and do a bit of (much-needed) cleaning too.
I've also made a few minor tweaks to the search – those requests are debounced, there's a reset search button and those shortcut options you've added (e.g. orientation:landscape) are also additive, so in theory it's possible to do a search like orientation:landscape extension:jpg another_search_term_here

Awesome man! Looking good 💯 Thank you for merging and improving :)


Mixed precision training on TensorFlow 2.3 doesn't speed-up training progress as TensorFlow 2.2 does

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 2.2.0/2.3.0
Python version: 3.6/3.7
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: Cuda 10.1, cuDNN 7.6.5
GPU model and memory: 2080Ti/12Gb

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
Mixed precision training on tensorflow 2.3 doesn't speed-up training progress as Tensorflow 2.2 does
Describe the expected behavior
faster or at least equal
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
nmt_with_attention.zip
I modify a bit based on tensorflow offcial tutorial nmt here (https://www.tensorflow.org/tutorials/text/nmt_with_attention). You can see the flag IS_MIXED_PRECISION in the head of the notebook, let change it to True/False to check by urself.
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
log.txt
here is my summary about the time consuming for tensorflow2.2/2.3 on both mixex precision and non-mixed precision.
I have many model on my framework TensorFlowTTS (https://github.com/TensorSpeech/TensorFlowTTS). All of my model training on mixed precsion Tensorflow2.3 have this problem. The above notebook is just example.
BTW, colab gpu haven't support mixed precision so to run this notebook require a local GPU to reproduce my issue.

@reedwm seem you are the person working on mixed precision :)).

what's the latest on this issue?


Resolve the issue with incorrect entity_id generation for Sonos component

Description:
The following PR fixes registration of Sonos player entities with the core.
The issue appears in the log with the following traceback.
Checklist:
If code communicates with devices, web services, or a:

[x] Local tests with tox run successfully. http://hastebin.com/alogujikiy.pl

They don't use this function. Remove 'unique_id' and it will work. The add_device callback from component entity helper make the same...

@pvizeli for some reason it didn't work for me when I tested locally. I'll check again.
With is method the implemented entity must have a name property if I understand it correct, right?

Yes it need a name property. But self._name to init function befor call update itself.

I'll help you to fix that in correct way next week. I think you should delete entity_id on init and but self._name to this. That should fix the bug and remove unneeded logic.

@valentinalexeev check #3217


Please add WorkingDir to Example scripts

Issue: Relative path for #Include can't find Neutron.ahk
Fix: Add to the top of each example script:
SetWorkingDir %A_ScriptDir%

How are you launching the examples that you've found a need to include this line? It works fine for me running with the usual methods (e.g. double clicking the file)


Why spaces in ${{ }}

In all examples in the documentation where the full template expression syntax is used it allways contains spaces in the brackets. Why?
It is not neccessary (https://camel.readthedocs.io/en/latest/yamlref.html#sequences) not is it used in other brackets.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6724abea-bbdc-bf66-ed5e-3214fa6c3e66
Version Independent ID: 4f8dab21-3f0e-da32-cc0e-1d85c13c0065
Content: Templates - Azure Pipelines
Content Source: docs/pipelines/process/templates.md
Product: devops
Technology: devops-cicd
GitHub Login: @vtbassmatt
Microsoft Alias: macoope

I don't understand this feedback. From the point of view of a YAML parser, "${{ whatever }}" is just an arbitrary string. Whether it contains spaces inside the braces is not something YAML would have an opinion about. Spaces make expressions easier to read and to tell apart from $(macro) syntax.
Have I missed something about your feedback? If so, my apologies and please feel free to clarify.

No. I just wanted to know if there is any hidden Syntax difference between ${{ whatever }} and ${{whatever}}. There is not. You only use spaces to emphasize here.
Thanks.


Make access to public repositories the default

After the resolution of #4, it is now possible to choose to authorize access to either all repositories (public and private) or to public repositories only, by selecting the dropdown menu in the "sign in with github" button.
However, the default choice is to access public and private repositories. I believe it would be better (i.e. less invasive) to default to public-only repositories, and have the private option available in the dropdown instead.
/cc @peterennisrda

@waldyrious
I agree with this suggestion.
The default option should always be "No you cannot access my private stuff. . ."
Explicit consent should be required.


Rolling Popups - ECCC site

On the eccc.opendatarescue.org site, the transcription app is experiencing rolling pop-ups after annotation boxes are drawn. Each pop-up stacks on top of the other and floods the page.
Ideally: please remove the pop-ups completely.

This is still an issue. When the transcription screen gets too cluttered, the page has to be refreshed and and all the setttings redone. This is also an issue in editing mode

@VickyS08 can you please give a step by step example of this happening. I tried and the popups go away and they did no accumulate.


test: add integration test for tumblr

Let's keep the minimal number of test data because some of them are quite big

Reduced it to 3 samples and adjusted the TOPK

Let's keep the minimal number of test data because some of them are quite big

Reduced it to 3 samples and adjusted the TOPK

Remember to add the test to the CI

Done

Remember to add the test to the CI

Done


R&D on RGB

Will have to do a R&D and create task based on that

[x] Backup Method : Two method mnemonic Phrase  and Configure Backup
[x] Faucet : Request free RGB asset
[x] Show and Hide asset
[x] Need proper toast message and modals

Completed


Switching from one Other app to another Other app doesn't work

To switch from one 3rd-party app configured with Other App to another, you first need to switch to a built-in app.

Fixed in https://github.com/Cosmic-Chatter/Exhibitera/commit/c01d39542b9055125eb1949ad92964730adfae2f


--target doesn't work for kubectl debug

Environmental Info:
K3s Version: k3s version v1.20.7+k3s1 (aa768cbd)

Node(s) CPU architecture, OS, and Version:  Alpine  5.10.12-0-virt

Cluster Configuration:

1 server, 1 agent
Describe the bug:

pods with spec shareProcessNamespace: true are working fine, but debug container doesn't enable process sharing
Steps To Reproduce:

Installed K3s:

kubectl run test-pod-1 --image busybox  --command sleep --restart Never 24h
kubectl debug --image busybox test-pod-1 --target test-pod-1  -it -- sh
# then run ps
/ # ps
PID   USER     TIME  COMMAND
    1 root      0:00 /pause
   44 root      0:00 sh
   50 root      0:00 ps

Expected behavior:

ps should show the sleep process
PID   USER     TIME  COMMAND
    1 root      0:00 sleep 24h

Actual behavior:

can not see processes inside the test-pod-1
Additional context / logs:

Reference debug-running-pod

From the docs you linked:

Note: The --target parameter must be supported by the Container Runtime. When not supported, the Ephemeral Container may not be started, or it may be started with an isolated process namespace

I haven't chased this down with containerd to see if they support this or not.

I stumbled with this as well, and as mentioned by @brandond this is not yet supported by containerd version used by k3s, it was implemented in this PR which landed in version 1.5. So we have to wait until k3s uses that version of containerd.

You'll probably see that in k3s 1.22.
cc @dweomer

Thanks, looking forward to it

I confirm this works as expected using k3s v1.22, so this can be closed


[core] Close CompactMetrics after closing its corresponding writer

Purpose
Currently we don't have a close method in MetricGroup. When using bucket-wise metric groups (for example CompactMetrics), because more and more buckets will be written as the job runs, we need to clean up the resources (for example, their corresponding Flink metric group) in time.
This PR closes CompactMetrics after its corresponding writer is closed.
Tests
As CompactMetrics is not bridged into Flink's metrics system at this time, we can't come up with unit tests. This should be tested in the PR when bridging CompactMetrics with Flink's metrics system.
API and Format
No.
Documentation
No.

+1


--max-connection-attempts only works when directly specifying

Describe the bug
--max-connection-attempts can't be used with the options in a file (instaloader +options.txt). It only works when directly specifying it when executing the command (instaloader --max-connection-attempts 0).
To Reproduce
First of all, here is my args-file:
--login=<login>
--sessionfile=.instaloader-session
--stories
--highlights
--tagged
--comments
--geotags
--post-metadata-txt="{caption} || {likes} likes, {comments} comments"
--storyitem-metadata-txt="Will expire/Expired on {expiring_utc}."
--filename-pattern={date_utc}_UTC/{date_utc}_UTC
--max-connection-attempts 0
--quiet
--fast-update

Then I'm executing this with the command instaloader +instaloader-args.txt <profile> and then it says that the option --max-connection-attempts 0 is unrecognized (look down for the error).
When I'm directly passing it to the command (instaloader --max-connection-attempts 0 <profile>) it works fine.
Expected behavior
The command shouldn't throw an error because of an unrecognized argument.
Error messages and tracebacks
usage:
instaloader [--comments] [--geotags] [--stories] [--highlights] [--tagged]
            [--login YOUR-USERNAME] [--fast-update]
            profile | "#hashtag" | %location_id | :stories | :feed | :saved
instaloader --help
instaloader: error: unrecognized arguments: --max-connection-attempts 0

Instaloader version
4.2

Might depend on the python version. I don't get an exception with your argument file, it is just silently ignored, and args.max_connection_attempts == 3. By putting an equal sign in the file (i.e. --max-connection-attempts=0) I get the expected result.

Might depend on the python version. I don't get an exception with your argument file, it is just silently ignored, and args.max_connection_attempts == 3. By putting an equal sign in the file (i.e. --max-connection-attempts=0) I get the expected result.

Using an equal sign in the file (--max-connection-attempts=0) works for me.
Is this intended or is this a bug?


Feat/creator hub screen

Creator screen design made.

Podfile.lock issue is not yet resolved.

@Tiny-Angel305  yes thats the case.


14.12 R3nzskin 优化原版 至今依旧稳定

rt 直接甩图为证
纯公益免费 无任何额外插件 干净稳定
当前版本不存在网传的任何封号问题
也不是魔改版本

966481633

Q群 : 966481633

I did modifications with visual studio that in issues page. It works but i can inject dll when vanguard enabled. How u fix that?

I did modifications with visual studio that in issues page. It works but i can inject dll when vanguard enabled. How u fix that?

It work only in cn server.

I did modifications with visual studio that in issues page. It works but i can inject dll when vanguard enabled. How u fix that?

You need to download it from this GitHub https://github.com/hydy100/R3nzSkin/releases/tag/14.12 also you will need to follow this tutorial

拳头服务器能用吗

偏移量是什么

I did modifications with visual studio that in issues page. It works but i can inject dll when vanguard enabled. How u fix that?

You need to download it from this GitHub https://github.com/hydy100/R3nzSkin/releases/tag/14.12 also you will need to follow this tutorial

Thank you! It works perfectly. Is it safe? Because open source and release different. I guess who made that combinated dll and injector.

群已满 还有四群吗

I did modifications with visual studio that in issues page. It works but i can inject dll when vanguard enabled. How u fix that?

You need to download it from this GitHub https://github.com/hydy100/R3nzSkin/releases/tag/14.12 also you will need to follow this tutorial

Thank you! It works perfectly. Is it safe? Because open source and release different. I guess who made that combinated dll and injector.
Have you already used it? On which server and is it banned？

群已满 还有四群吗

兄弟你找到群号了么


Increase test coverage for registry

Describe the problem
Now that we are feature complete for version 1.0.0 we should make sure our test coverage is as good as it should be. The last time we actively worked on increasing the test coverage was quite some time ago (see #37), so we have to make sure everything not related to calling the Docker API is still being tested.
Describe the solution you'd like
Run the registry tests with coverage and find scenarios where the coverage can be increased. Implement the respective tests to do so.

Closed with #134


add phone number validator

Hi, I am a novice developer and this is the first pull request in my life.
I tried to add additional validation of the string also by phone number, where the country code is checked (both with and without "+") and the fact that it consists of numbers.

This functionality already exists using p.string().match(r"YOUR_PHONE_CODE_REGEX") and is way more precise. But thanks for the effort.


Asking for info

Type of issue
Missing information
Feedback
Hi! There is no explicit informations on Internet about how srcTool is working. My problem is that I use it for validating my changes on a .pdb file. Unfortunately, it's too long and I want to replace it to take less than 5sec (currently 45sec), but I don't know what it's doing behind to try to replicate it and optimise it. Is someone having more information on how it's working behind that command line? Have a good day!
Page URL
https://learn.microsoft.com/en-us/windows-hardware/drivers/debugger/the-srctool-utility
Content source URL
https://learn.microsoft.com/en-us/windows-hardware/drivers/debugger/the-srctool-utility
Author
https://github.com/DOMARS

@Gaunic1 - Thanks for reaching out to the Windows Driver Developer Documentation team. This particular channel is monitored by the men and women who write the driver documentation posted on docs.microsoft.com/drivers. Though we'd like to, we don't have the resources to provide support for specific scenarios.
Your best bet is to use one of the forums where other driver developers and Microsoft engineers can be found, such as Stack Overflow, OSR's windbg List or Microsoft Support Community.
The PDB symbols are stored in a multiple stream format, as described in the wiki page and on this git hub site.

https://en.wikipedia.org/wiki/Program_database
https://github.com/Microsoft/microsoft-pdb
https://learn.microsoft.com/en-us/windows-hardware/drivers/debugger/public-and-private-symbols

I would also look at the other symbol parsing tools, like symchk, to see if they would be a possible option.
https://learn.microsoft.com/en-us/windows-hardware/drivers/debugger/symchk
Good luck with your work in optimizing your symbol checking.


NoSuchElementException when html tag name is BODY

It looks like the driver.findElement(By.tagName("TargetTagName")) is case sensitive.  So in BasePage.java and PageObject.java there are 4 occurrences of driver.findElement(By.tagName("body")) which might cause NoSuchElementException when the tag body is not "body".  E.g., BODY.

Is not it general convention to use lower case?
Did you come across a site which uses upper case tags?

In public sites, it should be rare case.  In the internal site of our company, there are some static pages do not follow this convention.  It would be nice to have it fixed, but the priority is low.  I guess not many people would encounter this problem.  I tried to add some ugly code in PageObject to avoid this issue, however I could not come out a graceful solution for it.  So I opened this issue as a note.  Anyway, appreciate for this project.

alright, I am leaving this issue as opened for now. Let's see if there are up votes for it :)


No possibility to remove tags

Right now we only can edit tags under system, but we have no possibility to remove them.

I guess you are talking about the TagRelation ActiveWindow.

Changes in TagRelation ActiveWindow would be a new issue as there are also missing edit and delete functionality.


[tuner] Update tuner lowering_config setting

https://github.com/iree-org/iree/pull/18651 changed the lowering_config attribute used by the LLVMGPUVectorDistribute pipeline. The tuner needs to be updated to account for this.

If someone is planning on having a look, I would wait another week, as i plan to do another wave of changes to the pipeline.


[$500] Expense - The gap between buttons in Concierge whisper is too wide

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:  <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1706185611151319
Action Performed:

User A sends a payment to User B. Then User B @mentions user A in that same IOU thread.

Expected Result:
The space between the two buttons should only be 8-12px
Actual Result:
The gap between buttons in Concierge whisper is too wide
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010f9c7527fb2a6675
Upwork Job ID:<PHONE_NUMBER>979767808
Last Price Increase: 2024-01-25

We think that this bug might be related to #vip-vsb
CC @quinthar

Proposal
Please re-state the problem that we are trying to solve in this issue.
The gap between invite and do nothing button is too big.
What is the root cause of that problem?
The gap is set to 16 here.
https://github.com/Expensify/App/blob/95631f67f1c24b5228abe83ee8f970c45925e3e5/src/components/ReportActionItem/ActionableItemButtons.tsx#L24
Instead of 8/12
What changes do you think we should make in order to solve the problem?

Updat the gap to gap2 or gap3

Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
We are using gap4 here, that's value is 16
<View style={[styles.flexRow, styles.gap4]}> {props.items?.map((item) => ( <Button key={item.key} style={[styles.mt2]} onPress={item.onPress} text={translate(item.text)} small success={item.isPrimary} /> ))} </View>

What changes do you think we should make in order to solve the problem?
use gap3 or gap2
What alternative solutions did you explore? (Optional)

I think we should do 8px as the solution, just to make that clear. cc @Expensify/design in case you disagree.

Also, would we have any interest in doing this one internally? Paying out $500 just for a tiny change seems a bit extreme, no?

That would be wonderful!

Not overdue. @ishpaul777 please link this issue in your PR

@ishpaul777 I think we can close this and manage the change in your PR right? I don't think we need to keep this separate as you'll tackle it in that PR.


Add http config options

Add options to override http logger defaults from the cli

Signed-off-by: Mohamed Abokammer<EMAIL_ADDRESS>

Codecov Report

Merging #132 (8ed27c8) into main (fe65fea) will decrease coverage by 14.20%.
The diff coverage is 17.85%.

:exclamation: Current head 8ed27c8 differs from pull request most recent head 087509f. Consider uploading reports for the commit 087509f to get more accurate results

@@             Coverage Diff             @@
##             main     #132       +/-   ##
===========================================
- Coverage   63.61%   49.40%   -14.21%
===========================================
  Files         164      115       -49
  Lines       10330     7382     -2948
===========================================
- Hits         6571     3647     -2924
- Misses       3036     3127       +91
+ Partials      723      608      -115

Flag
Coverage Δ

e2e
49.40% <17.85%> (-0.04%)
:arrow_down:

integration
?

unittests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/loggerhook/httphook.go
0.00% <0.00%> (ø)

pkg/xcontext/bundles/logrusctx/new_context.go
48.00% <0.00%> (-18.00%)
:arrow_down:

pkg/xcontext/bundles/options.go
57.89% <0.00%> (ø)

cmds/contest/server/server.go
56.66% <31.25%> (-2.13%)
:arrow_down:

plugins/targetlocker/inmemory/inmemory.go
0.00% <0.00%> (-98.48%)
:arrow_down:

plugins/storage/memory/memory.go
0.00% <0.00%> (-87.31%)
:arrow_down:

pkg/xcontext/metrics/prometheus/hacks.go
0.00% <0.00%> (-86.67%)
:arrow_down:

pkg/xcontext/metrics/prometheus/count.go
0.00% <0.00%> (-84.62%)
:arrow_down:

pkg/xcontext/logger/internal/wrap_printf.go
0.00% <0.00%> (-84.62%)
:arrow_down:

pkg/jobmanager/stop.go
0.00% <0.00%> (-83.34%)
:arrow_down:

... and 113 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


fix(password): use flex-end instead of end

Some browsers lack support for end value for align-items css prop.
This would make the icon in ToggleButton to be misplaced.
More specifically:
https://caniuse.com/mdn-css_properties_align-items_flex_context_start_end
Close issue #290

Media:
Before:

After:

Checklist:

[ ] Ready to be merged

The "after:" picture is not showing for me and the link "specifically" is redirecting to 404.

I don't have easy access to "IOS 14 or Mac OS 12.0.1". I've tested it with Chrome Version 106.0.5249.119 and Safari Version 15.4 (176<IP_ADDRESS>.6) and it works well.

The "after:" picture is not showing for me and the link "specifically" is redirecting to 404.

I've fixed the link ⬆

The "after:" picture is not showing for me and the link "specifically" is redirecting to 404.

Yeah, I've just updated the description. Thanks @martimalek for helping me out!


Pass on alias to function call arguments

(continuation of #1221) Pass the alias to function call arguments such that the alias is also recorded for the columns passed as arguments.

I think the tests failing is not related to my change right? Seeing as the error is Failed to prepare destination. Error: key must be a string, a buffer or an object

I think the tests failing is not related to my change right? Seeing as the error is Failed to prepare destination. Error: key must be a string, a buffer or an object

Yes, probably GitHub actions has no access to secrets when running on PR from fork.


Undelying model

Hi Max,
sry to disturb, but I'd like to better understand which network is implemented below the tflite model. From my understanding, the DetectionEngine only inputs SSD models. Is that the network architecture running below the tflite? Or is it another one (like mobilenet SSD, efficientDet, YOLOVx or else).
Will wait for your. Thank you for the great work you did.

I'm not sure what the underlying model architecture space looks like exactly, but you could try the Cloud AutoML docs or visualize the model snapshot.

Ok, from the model snapshot and from the docs I can exclude it actually is a mobilenet. From this page, however, it is written that the DetectionEngine only supports SSD models.
I'd be prone in thinking that it is an SSD model the underlying one. Is that a safe assumption?


Storages: Avoid SegmentReadTaskScheduler blocking the adding threads and ignore empty SegmentReadTaskPool

What problem does this PR solve?
Issue Number: close #9024
Problem Summary:

The thead of SegmentReadTaskScheduler may running with no segment to be scheduled unexpectly and holds the mutex that blocking the adding threads.

What is changed and how it works?

Manual cherry-pick of #8557 to fix the problem above because this PR will may the scheduler sleep if there is no segment need too be schedule.
Ignore SegmentReadTaskPool with no segment.

Check List
Tests

[x] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

Fix the bug that executing queries on partitioned table with empty partition may timeout

/run-integration-test


Fix #775: Ability to style / format mo.ui.table()

📝 Summary

Fix #775: Ability to style / format mo.ui.table()
🔍 Description of Changes

Table formatting, via GUI based / application mode

Different Format options based on the datatype of the column
Able to clear the format
Able to handle null, undefined and ""

Table formatting, programmatically via python code

add a format_mapping arg to create a mapping between column names and formats
download_as will download raw data (no formatting)
handle all types of TableData well
tests for each table type are written

📋 Checklist

[x] I have read the contributor guidelines.
[x] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
[x] I have added tests for the changes made.
[x] I have run the code and verified that it works as expected.

📜 Reviewers

@akshayka OR @mscolnick

wow @metaboulie , this code looks really great! API and implementation 👌
I think since things look good - the last thing would be Python unit tests for the formatting to_csv.
they can go in the files:
tests/_plugins/ui/_impl/tables/test_pandas_table.py
`tests/_plugins/ui/impl/tables/test*_table.py

couple lines to delete, but otherwise looks great!

🚢


Fix  bugs found in testing multi spring boot version

Found some bugs and code smells in testing this PR https://github.com/Azure/azure-sdk-for-java/pull/21258.

/azp run java - spring - tests

/azp run java - spring - tests


[N000127] Rep. Richard Nolan

Rep. Richard Nolan:
http://nolan.house.gov
Likely contact form URL to start with:
http://nolan.house.gov/contact/email-me

YMAL file not found. I am working on it.


Underground on Reserve seems dead

Had a user report that underground on Reserve seems dead, making quests difficult that require bots down there

This is something that will need to be handled via a spawn mod, SWAG v3 will be implementing a fully dynamic location based spawn trigger system, will be the recommended solution going forward


Gradle task assembleDebug failed with exit code 1

Hello, new to Flutter development but not to Android. I created a brand new app with flutter create -a kotlin myapp. Then I added the geolocator dependency and put the following in lib/main.dart:
import 'package:flutter/material.dart';

void main() => runApp(Main());

class Main extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Waynav',
      home: Scaffold(
        appBar: AppBar(
          title: Text('Home'),
        ),
        body: Center(
          child: Text('Hello World'),
        ),
      ),
    );
  }
}

My build fails:
Launching lib/main.dart on BV8000Pro in debug mode...
Initializing gradle...                                           0.3s
Resolving dependencies...                                        0.9s
Gradle task 'assembleDebug'...

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:processDebugResources'.
> Android resource linking failed
  Output:  /home/nolan/Projects/Waynav/waynav/build/app/intermediates/incremental/mergeDebugResources/merged.dir/values-v28/values-v28.xml:7: error: resource android:attr/dialogCornerRadius not found.
  /home/nolan/Projects/Waynav/waynav/build/app/intermediates/incremental/mergeDebugResources/merged.dir/values-v28/values-v28.xml:11: error: resource android:attr/dialogCornerRadius not found.
  /home/nolan/Projects/Waynav/waynav/build/app/intermediates/incremental/mergeDebugResources/merged.dir/values/values.xml:905: error: resource android:attr/fontVariationSettings not found.
  /home/nolan/Projects/Waynav/waynav/build/app/intermediates/incremental/mergeDebugResources/merged.dir/values/values.xml:905: error: resource android:attr/ttcIndex not found.
  error: failed linking references.

  Command: /home/nolan/stow/etc/.gradle/caches/transforms-1/files-1.1/aapt2-3.2.1-4818971-linux.jar/0758a40b82cd1609f6b509483ba5b8fc/aapt2-3.2.1-4818971-linux/aapt2 link -I\
          /home/nolan/opt/android/platforms/android-27/android.jar\
          --manifest\
          /home/nolan/Projects/Waynav/waynav/build/app/intermediates/merged_manifests/debug/processDebugManifest/merged/AndroidManifest.xml\
          -o\
          /home/nolan/Projects/Waynav/waynav/build/app/intermediates/processed_res/debug/processDebugResources/out/resources-debug.ap_\
          -R\
          @/home/nolan/Projects/Waynav/waynav/build/app/intermediates/incremental/processDebugResources/resources-list-for-resources-debug.ap_.txt\
          --auto-add-overlay\
          --java\
          /home/nolan/Projects/Waynav/waynav/build/app/generated/not_namespaced_r_class_sources/debug/processDebugResources/r\
          --custom-package\
          app.waynav.waynav\
          -0\
          apk\
          --output-text-symbols\
          /home/nolan/Projects/Waynav/waynav/build/app/intermediates/symbols/debug/R.txt\
          --no-version-vectors
  Daemon:  AAPT2 aapt2-3.2.1-4818971-linux Daemon #0
  Output:  /home/nolan/stow/etc/.gradle/caches/transforms-1/files-1.1/appcompat-1.0.1.aar/35a543ce7d1c5ec0484f8315086c99e6/res/values-v28/values-v28.xml:9:5-12:13: AAPT: error: resource android:attr/dialogCornerRadius not found.

  /home/nolan/Projects/Waynav/waynav/build/app/intermediates/incremental/mergeDebugResources/merged.dir/values-v28/values-v28.xml:11: AAPT: error: resource android:attr/dialogCornerRadius not found.

  /home/nolan/stow/etc/.gradle/caches/transforms-1/files-1.1/core-1.0.1.aar/3862e527f6d21f51fa877be11bd3344e/res/values/values.xml:89:5-125:25: AAPT: error: resource android:attr/fontVariationSettings not found.

  /home/nolan/stow/etc/.gradle/caches/transforms-1/files-1.1/core-1.0.1.aar/3862e527f6d21f51fa877be11bd3344e/res/values/values.xml:89:5-125:25: AAPT: error: resource android:attr/ttcIndex not found.

  error: failed linking references.
  Command: /home/nolan/stow/etc/.gradle/caches/transforms-1/files-1.1/aapt2-3.2.1-4818971-linux.jar/0758a40b82cd1609f6b509483ba5b8fc/aapt2-3.2.1-4818971-linux/aapt2 link -I\
          /home/nolan/opt/android/platforms/android-27/android.jar\
          --manifest\
          /home/nolan/Projects/Waynav/waynav/build/app/intermediates/merged_manifests/debug/processDebugManifest/merged/AndroidManifest.xml\
          -o\
          /home/nolan/Projects/Waynav/waynav/build/app/intermediates/processed_res/debug/processDebugResources/out/resources-debug.ap_\
          -R\
          @/home/nolan/Projects/Waynav/waynav/build/app/intermediates/incremental/processDebugResources/resources-list-for-resources-debug.ap_.txt\
          --auto-add-overlay\
          --java\
          /home/nolan/Projects/Waynav/waynav/build/app/generated/not_namespaced_r_class_sources/debug/processDebugResources/r\
          --custom-package\
          app.waynav.waynav\
          -0\
          apk\
          --output-text-symbols\
          /home/nolan/Projects/Waynav/waynav/build/app/intermediates/symbols/debug/R.txt\
          --no-version-vectors
  Daemon:  AAPT2 aapt2-3.2.1-4818971-linux Daemon #0

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 0s
 1.1s
Gradle task assembleDebug failed with exit code 1

Thoughts on what I'm doing wrong?

Yes you can solve this issue by making sure of the following:

Use the latest version of the Geolocator plugin (3.0.0)
Migrate your App to AndroidX (see: https://flutter.io/docs/development/packages-and-plugins/androidx-compatibility)

Thanks for the quick response, I'll give that a shot!

Does it work for you ? My build is still broken, even on a brand new app with 3.0.0.

@Yutsa, when you are on the Flutter stable channel (which is the default) you need to migrate you app (even a brand new one) to support AndroidX. This is done using Android Studio but you can also do it manually.

Add the following to your "gradle.properties" file:

android.useAndroidX=true
android.enableJetifier=true

Make sure you set the compileSdkVersion in your "android/app/build.gradle" file to 28:

android {
  compileSdkVersion 28

  ...
}

Make sure you replace all the android. dependencies to their AndroidX counterparts (a full list can be found here: https://developer.android.com/jetpack/androidx/migrate)

Oh I am really sorry ! I thought migrating the app consisted of Refactor -> Migrate to AndroidX and I totally missed the two lines in gradle.properties
It now works fine ! I'm sorry for the inconvenience. Good job and thanks for the support


Fix links to LinkML types

We currently have CCDH types (such as ccdh_Decimal) in the model, which are child types of LinkML types (in this case, linkml:Decimal). Unfortunately, the links in the Markdown documentation from the CCDH type to the LinkML type is broken: instead of linking to https://cancerdhc.github.io/ccdhmodel/dev/types/Decimal/, it links to https://cancerdhc.github.io/ccdhmodel/dev/types/CcdhDecimal/types/Decimal.md instead, which does not work.
(The .md looks incorrect there, but if it wasn't for the duplicated /types/.../types in the URL, it would be resolved correctly and turned into a link to an index.html file.)
This is probably a bug in LinkML's Markdown generation, but it needs to be isolated and reported upstream.

Note that this occurs because we import the LinkML types by specifying import:\n - linkml:types in the ccdhmodel.yaml file. I'm not sure where LinkML gets this file from -- it's probably worth tracing that so we know what we are dependent on.

@monicacecilia was this one that you wanted @turbomam to take a look at?

This will probably be more up @sujaypatil96's alley more than Mark's -- it'll require digging into LinkML Markdown generation to figure out why the URLs are being generated incorrectly.


Changing appearance (color) of element crashes when trying to add color to color picker

Version of Archi
4.8.1
Archi Plug-ins
EIRA plugin
Operating System
MacOs 11.2.2 (Big Sur)
Expected Behaviour
when picking a color from color picker and dragging into available slot for preferred colours it should add the color to the available placeholder in the picker and select the color to be used in the appearance of the selected Archimate element
Actual Behaviour
when picking a color from color picker and dragging into available slot for preferred colours the app crashes, loosing all unsaved changed prior to crash
Steps to Reproduce the Behaviour

Select element (f.i. application component)
Select appearance in properties window
Click fill color (color picker opens)
Select a color from the picker
drag the color from the preview box (down left corner) in the picker to an available slot (bottom right part of the picker)

This isn't specific to Archi. In fact it can happen with other Mac apps on Big Sur. I've reported the issue at Eclipse's bug tracker[1] but the fix is up to Apple.
[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=568920

It seems that the crash in the color picker will only occur if all the slots are empty. See the comment here[1].
A workaround is to drag a color into a slot using another app where the crash doesn't happen, for example the TextEdit app, and then try again in Archi.
[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=568920#c18

Indeed, adding a color to color picker slot in another app (notes f.i.) the problem cannot be reproduced any more. So this is a perfect workaround for now. Just remember to save the Archi file before messing with the color picker

I'll close this as this is a macOS issue (which is still present in 11.4).


apps: hostmetrics use mute_process_name_error

Use the new mute_process_name_error config to mitigate process
readlink log spam.

Converting to draft until https://github.com/GoogleCloudPlatform/opentelemetry-operations-collector/pull/82 is merged so I can bring it in


Why dotenv removed

I notice that dotenv has been removed since 2015.11..
The ones who clone this repo and try to build their own project based on it need to install it by themselves or there is some other module replace the dotenv?
I'm just curious about that and if this issue is not proper plz let me konw and I will close it anyway.

This file was not necessary to run the demo for me.

Likewise, I did not need dotenv to run the site. I'm going to close this, but if you still think it's an issue please re-open with more details (e.g. what exactly is requiring dotenv?)


leastActive worker is undefined when socket io worker servers are built with an express server

There is a problem with the function computeWorkerId when express is used to construct the socket io server. When all the socket worker servers have been closed, the following error appears:
/home/wvhulle/Documents/socket.io-fiddle/node_modules/@socket.io/sticky/index.js:58
        return leastActiveWorker.id;
                                 ^

TypeError: Cannot read properties of undefined (reading 'id')
    at computeWorkerId (/home/wvhulle/Documents/socket.io-fiddle/node_modules/@socket.io/sticky/index.js:58:34)
    at Socket.<anonymous> (/home/wvhulle/Documents/socket.io-fiddle/node_modules/@socket.io/sticky/index.js:80:18)
    at Socket.emit (node:events:525:35)
    at addChunk (node:internal/streams/readable:324:12)
    at readableAddChunk (node:internal/streams/readable:297:9)
    at Readable.push (node:internal/streams/readable:234:10)
    at TCP.onStreamRead (node:internal/stream_base_commons:190:23)

It seems like the function cannot deal with the case where there are no workers. When I remove express, the problem disappears.
The bug can be seen in https://github.com/wvhulle/socket.io-fiddle/tree/cluster-adapter, after running the client and the server, then waiting until the worker threads quit.

Adding app.close() in the workers does not seem to help.
But adding this in the primary
  cluster.on("exit", (worker) => {
    console.log(`Worker ${worker.process.pid} died`);
    if (Object.values(cluster.workers).length === 0) {
      httpServer.close()
    }
  });

solves the problem, but maybe this library should also have something opposite to setupMaster? Like closeMaster? Or otherwise be able to deal with data still coming in the primary server but no workers available.

  cluster.on("exit", (worker) => {
    console.log(`Worker ${worker.process.pid} died`);
    if (Object.values(cluster.workers).length === 0) {
      httpServer.prependListener("connection", (socket) => { socket.destroy() })
    }
  });

Also seems to work.

@wvhulle I could indeed reproduce, thanks. We should definitely handle the case where there are no available worker.

Shoul I open a merge request with one of my fixes?

That would be awesome 👍

For future readers:
This should be fixed by https://github.com/socketio/socket.io-sticky/commit/e8b4203d18fc9601e05af3457baba49fafdb15f0, included in version 1.0.3. Please reopen if needed!

Thanks a lot!


Moving repo changes

Here I report on changed repos and their PR which are needed for the GitHub organisation change:
https://github.com/SolidOS/solid-logic/pull/37
https://github.com/SolidOS/pane-registry/pull/22
https://github.com/SolidOS/solid-ui/pull/495
https://github.com/SolidOS/solid-panes/pull/345
https://github.com/SolidOS/mashlib/pull/161
ToDo - create a release with these PRs.

all done


Fixed capitalization of Program.cs on line 18

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: stacklysm sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Oh, @stacklysm ... Could you please sign the CLA :point_up:. We can't accept this without it.

Done, signed up the CLA. Glad to help!


OWASP 3.1 rules in documentation that are no longer in the WAF Azure UI

The following OWAS 3.1 rules are in the documentation (and used to be in the Azure WAF UI) but are no longer visible in Azure Portal WAF UI (either selected or not selected)
920360	Argument name too long
920370	Argument value too long
920380	Too many arguments in request
920390	Total arguments size exceeded
920400	Uploaded file size too large
920410	Total uploaded files size too large

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 079888f6-188c-1bb9-0516-bd52ad0f287e
Version Independent ID: 1971c541-4019-f620-b57b-8cfd5acf87a1
Content: CRS rule groups and rules - Azure Web Application Firewall
Content Source: articles/web-application-firewall/ag/application-gateway-crs-rulegroups-rules.md
Service: web-application-firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

@phil-dando Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

fixed
#please-close


Add support for --proxy-bypass-list command line argument

Depends on atom/brightray#179
Explanation copied from the brightray PR:

This PR adds support for the --proxy-bypass-list command line argument. It enables you to decide on hosts that should bypass the proxy server set by --proxy-server. For example if your app talks to a local web server (e.g. http://<IP_ADDRESS>:8080), you probably don't want it to go through the proxy server (how will it resolve <IP_ADDRESS> to the correct host?), so you can use --proxy-bypass-list="<IP_ADDRESS>:8080" or the more general --proxy-bypass-list="<local>".
The value can contain more than one host, separated by semi-colon. See examples at: https://www.chromium.org/developers/design-documents/network-settings

This PR adds the documentation for this feature.

:+1:


Updating README

Updated badges, description from user guide, and acknowledgements.

This looks like a stray PR. closing.


[BUG] (type-safe-api) (regression) Path param on path level not recognize properly

Describe the bug
With a shared parameters directly under the path instead of the method (to share path ID for example for get, put, delete methods) the ID model is generated but not imported in the runtime Api.ts file.
For example with this OpenAPI file:
openapi: 3.0.3
info:
  version: 1.0.0
  title: My API
paths:
  /hello:
    get:
      operationId: sayHello
      x-handler:
        language: typescript
      parameters:
        - in: query
          name: name
          schema:
            type: string
          required: true
      responses:
        200:
          description: Successful response
          content:
            'application/json':
              schema:
                $ref: '#/components/schemas/SayHelloResponseContent'
        500:
          description: An internal failure at the fault of the server
          content:
            'application/json':
              schema:
                $ref: '#/components/schemas/InternalFailureErrorResponseContent'
        400:
          description: An error at the fault of the client sending invalid input
          content:
            'application/json':
              schema:
                $ref: '#/components/schemas/BadRequestErrorResponseContent'
        403:
          description: An error due to the client not being authorized to access the resource
          content:
            'application/json':
              schema:
                $ref: '#/components/schemas/NotAuthorizedErrorResponseContent'
        # default:
        #   description: An error due to the client not being authorized to access the resource
        #   content:
        #     'application/json':
        #       schema:
        #         $ref: '#/components/schemas/ServiceUnavailableErrorResponseContent'
  /hello/{id}:
    parameters:
      - in: path
        name: id
        schema:
          $ref: '#/components/schemas/HelloId'
        required: true
    get:
      operationId: sayHelloId
      x-handler:
        language: typescript
      responses:
        200:
          description: Successful response
          content:
            'application/json':
              schema:
                $ref: '#/components/schemas/SayHelloResponseContent'
        500:
          description: An internal failure at the fault of the server
          content:
            'application/json':
              schema:
                $ref: '#/components/schemas/InternalFailureErrorResponseContent'
        400:
          description: An error at the fault of the client sending invalid input
          content:
            'application/json':
              schema:
                $ref: '#/components/schemas/BadRequestErrorResponseContent'
        403:
          description: An error due to the client not being authorized to access the resource
          content:
            'application/json':
              schema:
                $ref: '#/components/schemas/NotAuthorizedErrorResponseContent'
        # default:
        #   description: An error due to the client not being authorized to access the resource
        #   content:
        #     'application/json':
        #       schema:
        #         $ref: '#/components/schemas/ServiceUnavailableErrorResponseContent'
components:
  schemas:
    SayHelloResponseContent:
      type: object
      properties:
        id:
          $ref: '#/components/schemas/HelloId'
        message:
          type: string
      required:
        - message
    HelloId:
      type: string
      format: uuid
    InternalFailureErrorResponseContent:
      type: object
      properties:
        message:
          type: string
      required:
        - message
    ServiceUnavailableErrorResponseContent:
      type: object
      properties:
        message:
          type: string
      required:
        - message
    BadRequestErrorResponseContent:
      type: object
      properties:
        message:
          type: string
      required:
        - message
    NotAuthorizedErrorResponseContent:
      type: object
      properties:
        message:
          type: string
      required:
        - message

Expected Behavior
Path parameters should be handled same as method parameter
Current Behavior
HelloId is correctly generated in models/HelloId.ts but not imported in DefaultApi.ts so build fail.
Reproduction Steps

Follow getting started with OpenAPI configuration
Replace OpenAPI spec with the one specified previously as an example
Build and observe error
Move path param under get method
Build and observe success

If you also try to uncomment default responses you'll also see another error, I use default in all my APIs for 503 responses and it worked before but now it is interpreted as 200 and cause a duplicate in OperationConfig.ts
It is not the same issue so if needed i can report another issue for it
Possible Solution
No time to look at a solution sorry but I'm pretty sure something change in a recent version because I didn't have any issue in v0.23.49
Additional Information/Context
No response
PDK version used
v0.23.55
What languages are you seeing this issue on?
Typescript
Environment details (OS name and version, etc.)
macOS 14.6.1, apple m1 pro, node 20.18.0, pnpm 8.15.9

Hey Vale! Thanks for raising this!
Since 0.23.50 we've replaced openapi-generator with our own code generator for most of the typescript projects. While it's much faster and doesn't have the dependency on Java, it seems I've missed some edge cases here! I'll investigate the three problems you've raised in this issue, don't worry about separating them :)
For now, I'd recommend pinning at 0.23.49 so you're not blocked :)

I've raised #845 to fix these 3 issues!
Note that the default response is an interesting case. While the previous code generation "worked" with a default response, OpenAPI Generator treated the response code as 0, so we generated eg SayHello0ResponseContent types.
Are you returning any default responses from your API in your use case?
I'm curious to know whether you're actually using the generated code for the default response, as it doesn't seem to have ever matched the expected behaviour from the specification: https://swagger.io/docs/specification/v3_0/describing-responses/#default-response

Hi @cogwirrel,
I never used the default 503 responses in my API handlers, but implemented it in api model as a best practice (by looking at recommendations and OpenAPI audit tools)

Cool that makes sense! Definitely better that the generated code compiles now but we should revisit what it looks like for default responses. I've raised https://github.com/aws/aws-pdk/issues/847 to track this :)


refactor using dst_id in pipelinex profile to be same as non pipeline; rename some function names

Proposed changes

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run clickbench


Update Set-CsExternalAccessPolicy.md

https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/4988
Added "applies to"

Docs Build status updates of commit 58e83cc:
:clock10: Full build: the average full build time is 18 min(s) 8 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 58e83cc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Set-CsExternalAccessPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

This is another occurrence of a long standing matter on cmdlets from SfB Online module that also apply to Microsoft Teams.
If we approve this change we would need to do the same for all of them.
Please see @kenwith comment here as there is a current effort on trying to reorganize this content and recently it was decided to leave "applies to" as is.

Agree with @get-itips.


Examples should be in a Code Block

Should be in a code block for easier understanding, similar to:

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e02c19ec-2424-6359-a4cd-ad061f2c3180
Version Independent ID: 5421a6b4-8c29-2143-1df5-7bd90375437f
Content: CosmosClientOptions Class (Azure.Cosmos) - Azure for .NET Developers
Content Source: xml/Azure.Cosmos/CosmosClientOptions.xml
Service: azure
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

This issue has been transferred to the repository where the Azure.Cosmos package is maintained as #3591.


PHP class definitions should be aware of inheritance and method visibility

Currently we have information (we then use, for example, for method name autocompletion) only from a specific class in PHP source code.
We should add support for inheritance, so we know that for class X extends Y there are methods in class Y which the class X also contains.

Done in https://github.com/smuuf/vscode-latte-lang/commit/1b99f9bc7e3f394211f3be5e524684e789ac9a98


Use only KP_0-9 instead of 0-9

As requested by another thread, the other issue would be to only recognize the numpad 0-9 instead of the regular 0-9 which should have another keybinds. Issue detected in linux. (I know there's separate inputs for numpad keys versus regular keys as I use num pad 0-9 for CS:GO keybinds (the only conflicting key is the KP_ENTER which act as any "ENTER" key).

I did some investigation and unfortunately this is much harder than I expected.
The biggest problem is that module pynput that I'm using for global keys doesn't separate NumPad keys from NumRow keys. It suppose to do that, but based on those issues: https://github.com/moses-palmer/pynput/issues?q=is%3Aissue+is%3Aopen+numpad, it's not something new, so also I wouldn't expect it to be fixed soon.
There are 3 things that potentially can by done:

I could use different library for keyboard control - but I couldn't find anything better than pynput
I can try to fix pynput but I'm not sure if I'm able to do that, definitively huge amount of time would be required from my side.
I can write my own implementation for keyboard control using evdev and ctypes modules - I opt fort that option, but still it require a lot of time.

So giving above reason, I will park this issue for the further future.
@olehj , If you feel that you can pull it of, than I encourage you to do that.

No problem, thanks for looking into it anyway :)


Set to the default value when given MaxMessageLength value is zero or negative

If given value is zero or negative, then Exception will throw. I developed in this way but I have noticed that it is not an elegant solution.
Set to default would be more elegant then throwing an exception.

Closing since the ArgumentException have not caused any complaints. I guess an alternative approach would be doing the option-validation inside InitializeTarget()


Use the click password prompt for secret fields

Click has an "option" that prompts the user to input a password.
http://click.pocoo.org/5/options/#password-prompts
This would be more secure than passing secret data through the command line, because it will avoid showing it in the terminal history. This would be most relevant for:
tower-cli config password

This could also be employed in #356.

For job launches we are currently using getpass.
        for password in job_start_info.get('passwords_needed_to_start', []):
            start_data[password] = getpass('Password for %s: ' % password)

https://github.com/ansible/tower-cli/blob/master/tower_cli/resources/job.py#L215

Already kind of have this now thanks to @ryanpetrello new login


Fix issues with selecting fields in the content API

I don't love this approach, but it seems like it might be the only thing that works.
Switch to always getting all data from the database, then limiting whats returned by selectedQueryFields in the Entry class.
Fixes https://github.com/statamic/eloquent-driver/issues/26

@jasonvarga could you sanity check this when you have some time. I really don’t like getting all the data every query but I feel like there may be no other option.

can you see a reason why we shouldn't just get the full row each time

Performance, I guess. The same reason you don't just use select * all the time.
As for #96, we could add origin_id along with collection. Clearly collection isn't the only required field.

Sorry to be clear, initially I suggested "enforce the collection column is selected". What I really mean is that we need "enforce a list of columns".
If you do $query->get('title'), we should merge on collection, origin_id, maybe slug, etc.

Er wait I see what you're saying. The rest of the custom fields are all stored inside data. I forgot it worked that way! The important stuff is all dedicated columns. Ok I guess we just get them all 🤷

Glad it has you going round in circles too! I cant decide whats best either.


SavePng was always using a 3 channel output format. for NRM texture p…

…acking the required number of channels is 4. (2 Normal, 1 Roughness, 1 Metallic). Save added an additinoal parameter targetFormat (defaults to BGR) to override the target format when packing NRM.

How does the merge work ? Do I have to join another group?

Merged. Thanks @mtungekar!


textfield related issue

hi, I have added the text field above the keyboard in the keyboard view as the size is expanding of the text field complete view is expanding and going out of bounds like below. I have tried fixedsize() and other option to define height and width nothing working.
The second thing is how can I access the value of the text field(text typed inside it) ,because i have to send that text in API call  in some other view's button action

Hi!
Have a look at the demo app. It has a text field that doesn't break constraints, so you should be able to use the same view configuration.
Haha, regarding accessing the text, I have completely missed adding that to the views. For now, you could use the config block to get a reference to the text view/field and keep that reference around as a weak reference.
I will add a text property to these views.

I have fixed this in 4.6.3 (https://github.com/KeyboardKit/KeyboardKit/releases/tag/4.6.3) - you can now provide a text binding that lets you access the typed text.
Thanks for making me aware of this issue! :)

thanks 😊

hey daniel
again here to trouble you with stupid queries(ios development newbie)
so i need this oneline text field(not multiline) that will wrap up the text that is provided to it in the fixed constraints without expanding and breaking the keyboard constraints like above. I  tried what you have suggested above, still facing the same issue can you try fixing it in the demo  keyboard textfield or library if you get some time

Hi! There are no stupid questions, so ask away :) However, for me the demo text field (one line) works great, doesn’t it for you?

here is the screenshot for demo app

in the demo also constraints are breaking for me

how can i send the content of keyboard textfield to main app text field ?

Does the constraint problem happen on launch or only when you enter a lot of text into the text field?

You just use the binding text, stop edit the text field (makes the main app the proxy) and modifies the proxy content. However, the proxy api is limited, so replacing the entire content may be difficult, but you could just insert text into it.

https://github.com/KeyboardKit/KeyboardKit/issues/294#issuecomment-886934183
When i enter the text

@shweta-poonia I see the problem now, thank you! I will create a new issue for this, to make the issues easier to follow.


Do not fix dependencies version

pyyaml released few days ago a new minor release, namely 3.12. As Pykwalify explicitely relies on 3.11, this means that many projects could not benefit from the new version. Moreover, as pip isn't bundled with a dependency contraints solver for -r, this means that any requirements.txt that specify pyyaml and pykwalify (in this order) will not be satisfied (because pyyaml will be first installed in 3.12, then pykwalify will require 3.11, which is naturally in conflict with 3.12).

Coverage remained the same at 88.541% when pulling 2bdaf8e6c89a64392fef35842c9b1dee25a148a5 on AlexandreDecan:patch-1 into b53ae72940b23914d9b1d851536d515c4d4a8672 on Grokzen:unstable.

I didn't see there already is an open issue about this #55

@AlexandreDecan Manually merged this PR and added a few more changes that you missed to make this mergable. You can find it in the unstable branch here 8c3327ebbd6d76cd07a48f5ae9c62cee58694090


[Pebble Clock] Support for internationalization / Get steps from built-in step counter

Closes #1697

Thanks!


Remove wrapActionCreators

This is a follow-up to #1705.
After I had a look at the changes and a bit of digging, I came to realize wrapActionCreators has not been used anywhere in the codebase since 5.x, so it's really just a dangling/unreachable file that should have been removed a long time ago.
Now, the remaining question is whether we should move bindActionCreators from src/utils/bindActionCreators.js into src/connect/mapDispatchToProps.js since it is now the only place that references bindActionCreators. My own take would be to leave it as is.

Thanks!


Enable running playground on windows

This launches the playground successfully, but when I try to run the "this is a test" query, the results never show up. And strangely, I'm not asked for an openai key either (using the openai model in the query and settings). Do you have any ideas?

This PR is meant to fix #4.

I think I found the issue. There are at least two things that still need to be changed:

In this file, we assume unix linebreaks \n, but we also need to support Windows \r line breaks: https://github.com/eth-sri/lmql/blob/faff95d5035072309f1e97e581c7a340a27ad15d/src/lmql/ui/live/live.js#L40
One of the search paths for an api.env file that contains the OpenAI secret here (https://github.com/eth-sri/lmql/blob/faff95d5035072309f1e97e581c7a340a27ad15d/src/lmql/runtime/openai_secret.py#L27), does not exist on Windows. We should exclude it if HOME returns None. An even better solution would be to provide a Windows-specific additional search path.

More generally, we also would need a way to set OPENAI_SECRET or the Azure equivalents from a cmd.exe or PowerShell. I am not very familiar with this, but there should be ways to read out environment variables from inside a Python process there, right?

I fixed the first issue (line endings), but now I get the error that
 "OpenAI models are not compatible with HuggingFace tokenizers. Please use 'tiktoken' or 'gpt3_tokenizer' instead."
AssertionError: OpenAI models are not compatible with HuggingFace tokenizers. Please use 'tiktoken' or 'gpt3_tokenizer' instead.
App finished running with exit code 1

In CMD, variables are set with SET OPENAI_API_KEY=sk-... by the way.

Sorry, for the delay. Now, I could finally test it on my windows machine. It all seems to work with your current state.
The issue your seem to be encountering is likely unrelated and may be caused by not having tiktoken installed? Can you try installing tiktoken and run again? We use gpt2 for all OpenAI models, since Chat models do not support tokenized input anyway and text-* models are all based on the GPT-2 vocabulary.

Thanks. I'm traveling right now and don't have my windows laptop. But I don't think I installed any extra dependencies, so it's likely that.

Great, merging this for now then, and please report back if you still encounter issues with the tokenizer. Thanks a lot for your contribution.

Sounds good, thanks.


onnxruntime: fix x86_64-darwin build

Description of changes
Fix build on x86_64-darwin.
(ZHF: #309482)
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 311470 run on aarch64-darwin 1

Result of nixpkgs-review pr 311470 run on aarch64-linux 1

Result of nixpkgs-review pr 311470 run on x86_64-darwin 1

12 packages marked as broken and skipped:

python311Packages.faster-whisper
python311Packages.faster-whisper.dist
python311Packages.mmcv
python311Packages.mmcv.dist
python311Packages.tf2onnx
python311Packages.tf2onnx.dist
python312Packages.mmcv
python312Packages.mmcv.dist
whisper-ctranslate2
whisper-ctranslate2.dist
wyoming-faster-whisper
wyoming-faster-whisper.dist

8 packages failed to build:

magika (python311Packages.magika)
magika.dist (python311Packages.magika.dist)
python311Packages.fastembed
python311Packages.fastembed.dist
python312Packages.fastembed
python312Packages.fastembed.dist
python312Packages.magika
python312Packages.magika.dist

45 packages built:

deface
deface.dist
onnxruntime
onnxruntime.dev
onnxruntime.dist
piper-phonemize
piper-tts
private-gpt
private-gpt.dist
python311Packages.chromadb
python311Packages.chromadb.dist
python311Packages.insightface
python311Packages.insightface.dist
python311Packages.llama-index
python311Packages.llama-index-cli
python311Packages.llama-index-cli.dist
python311Packages.llama-index-vector-stores-chroma
python311Packages.llama-index-vector-stores-chroma.dist
python311Packages.llama-index.dist
python311Packages.onnxruntime
python311Packages.onnxruntime.dist
python311Packages.piper-phonemize
python311Packages.piper-phonemize.dist
python311Packages.private-gpt
python311Packages.private-gpt.dist
python311Packages.pysilero-vad
python311Packages.pysilero-vad.dist
python312Packages.chromadb
python312Packages.chromadb.dist
python312Packages.insightface
python312Packages.insightface.dist
python312Packages.llama-index
python312Packages.llama-index-cli
python312Packages.llama-index-cli.dist
python312Packages.llama-index-vector-stores-chroma
python312Packages.llama-index-vector-stores-chroma.dist
python312Packages.llama-index.dist
python312Packages.onnxruntime
python312Packages.onnxruntime.dist
python312Packages.piper-phonemize
python312Packages.piper-phonemize.dist
python312Packages.private-gpt
python312Packages.private-gpt.dist
python312Packages.pysilero-vad
python312Packages.pysilero-vad.dist

Failed builds for python31{1,2}Packages.{fastembed,magika} are unrelated to this fix.

I'm not sure why iconv is there instead of libiconv. Instead of the fix in this PR, would replacing iconv with libiconv help?

@wegank, not sure, just tried the first thing that occurred to me and it worked. I'll try using libiconv.

@wegank, alrighty made that change and it worked like a charm. Thanks for the suggestion.