[FLINK-10193] Add @RpcTimeout to JobMasterGateway.triggerSavepoint

What is the purpose of the change
This adds the @RpcTimeout annotation to JobMasterGateway.triggerSavepoint so that the default timeout is overridden.
cc: @uce @tillrohrmann
Brief change log

Add @RpcTimeout to JobMasterGateway.triggerSavepoint.

Verifying this change
This change added tests and can be verified as follows:

Manually verified the change by running SlowToCheckpoint job, which is attached to the FLINK-10193 issue. Savepoint duration was 45s and command used to take savepoint was: bin/flink savepoint <JOB_ID> file:///tmp/flink-sps

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

I see the following possibilities to test this:

Override triggerSavepoint to a NOP, and trigger savepoint twice with increasing timeouts. The second invocation should fail later.
Check for presence of the annotation with reflection.

I deliberately did not add tests because Option 1 is slow and depends on
"good" thread scheduling. Option 2 is fragile and not refactoring friendly.

Can't we check in the JobMaster#triggerSavepoint method which timeout value was passed in? It is not a super good test but it would guard against this specific failure in the future.

@tillrohrmann The value of the timeout from the perspective of the method implementation will always be what is passed to the RPC. This is regardless of whether the annotation is present or not because if the annotation is missing, the AkkaInvocationHandler, cannot know which item in the args array should be replaced with the default timeout.
If the call originates from the REST API, the value will be RpcUtils.INF_TIMEOUT:
https://github.com/apache/flink/blob/6258a4c333ce9dba914621b13eac2f7d91f5cb72/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java#L132
I can add a test to the handler test suite but this will not verify my change.

You're right @GJL. Then I would vote for the first test case. Something along the lines:
Future future1 = jm.triggerSavepoint(1 ms);
Future future2 = jm.triggerSavepoint(inf);
future1.get() fails with TimeoutException && !future2.isDone()

Any ETA on this ? for non trivial jobs with a lot of state this is critical

Thanks for the contribution @GJL. Merging this PR.


Update jackson-module-scala to 2.11.4

Updates com.fasterxml.jackson.module:jackson-module-scala from 2.11.3 to 2.11.4.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.fasterxml.jackson.module", artifactId = "jackson-module-scala" } ]

labels: library-update, semver-patch

Codecov Report

Merging #884 (7a364c2) into master (e99abd1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #884   +/-   ##
=======================================
  Coverage   83.45%   83.45%
=======================================
  Files          74       74
  Lines        5488     5488
  Branches      164      164
=======================================
  Hits         4580     4580
  Misses        908      908

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e99abd1...7a364c2. Read the comment docs.


Unable to Link Organization

URL to the linked Repo/Org: https://github.com/zio/zio-arrow
Steps to reproduce the problem: I set up an account with CLA Assistant and gave permissions for my organization. I can now link all the individual repos in the organization but do not see an option from the drop down

I set up an account with CLA Assistant.
I gave permissions for my organization
I go to the drop down menu to link an organization or repo

What is the expected result?
I expect to be able to link the entire organization.
What happens instead?
I can see and link all the individual repos in the organization but I don't see the organization itself, or any section for organizations, on the drop down menu.

hI @adamgfraser, Thank you for reaching out to us :).
You can see all the repositories to which you have write access in the drop-down menu however,  for linking the whole organization you need to provide an additional auth-scope. Then you can link the whole organization.
I have described the steps on how to grant this permission for CLA Assistant in accessing your organization here.
Have you already granted this additional auth-scope but still you don't see the organization zio in the drop-down?

@ibakshay Thanks for getting back to me. Yes, I believe I did that. I used to see that link for "want to link an org?" and I clicked on that. Now I no longer see the link and I received an email that the application was granted an additional scope (admin:org_hook). Is that the right one? Is there anything else I need to do?

Could you also check your settings as described in this comment, please: https://github.com/cla-assistant/cla-assistant/issues/176#issuecomment-259924887
Just to make sure, that everything is set up correctly on the github side.

Yes it looks correct:

Sorry for long delay in our response.
According to github api your user seems not to have administrator rights for this org. You probably should request admin rights first in order to be able to link this organization in CLA assistant.

Thanks! That resolved it for me.


Update notebooks

Codecov Report

Merging #258 into master will not change coverage.
The diff coverage is 60%.

@@           Coverage Diff           @@
##           master     #258   +/-   ##
=======================================
  Coverage   89.11%   89.11%
=======================================
  Files         182      182
  Lines        6044     6044
=======================================
  Hits         5386     5386
  Misses        658      658

Impacted Files
Coverage Δ

creme/compat/sklearn.py
75.84% <60%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 499bd14...1ee3c04. Read the comment docs.


Include formatting imports.

This PR revises the rules for formatting to include sorted imports, sorts existing imports, and switches from using an sbt plugin to using the google java formatter directly in a docker container.  This gives us more control.  bin/fmt continues to work correctly.

Fixes #23.

Fixes #23.

Thanks!!
Not related to this change, but related to the formatter in general: One thing I'm still unclear on is how to run the formatter myself (or whether I should expect things to happen automatically). Any tips?

Thanks!!
Not related to this change, but related to the formatter in general: One thing I'm still unclear on is how to run the formatter myself (or whether I should expect things to happen automatically). Any tips?

You just need to run bin/fmt and it should do it for you.  :)

You just need to run bin/fmt and it should do it for you.  :)

Added that to the README, thanks for pointing out it wasn't in there!

Added that to the README, thanks for pointing out it wasn't in there!

Excellent - thank you!

Excellent - thank you!


Kubectl create job?

The cronjob kind has this feature —from and wondering if we can add here? Ie, kubectl create job —from=cronjob/ .

There is no way to extend the --from functionality at the moment (it does a hard check on an existing cronjob), so sadly: no.


Add streaming support feature

Removes golangci linting deprecation warnings
See: Issue #49

looking forward to this feature. :)

@ealvar3z do you mind I finish this up?

No Sir.
Thank you for your patience on this, as I haven’t been able to spend any of my off time on it.
Sent from my iPhone
On Feb 7, 2023, at 3:46 AM, sashabaranov @.***> wrote:

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
@ealvar3zhttps://github.com/ealvar3z do you mind I finish this up?
—
Reply to this email directly, view it on GitHubhttps://github.com/sashabaranov/go-gpt3/pull/54#issuecomment-1420642077, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANK7YBAOUMKCOLLQIKEGE3TWWIYXRANCNFSM6AAAAAAUDDJTQY.
You are receiving this because you were mentioned.Message ID: @.***>


Ack configuration

We need to be able to configure different acknowledgement variants.
Options are listed in the referenced comment.
Originally posted by @s3rius in https://github.com/taskiq-python/taskiq/issues/222#issuecomment-1834471568

Draft PR: https://github.com/taskiq-python/taskiq/pull/248


Duck DB 0.10 seems to be broken

Hi there
I had expected this to work according to docs in 0.10:
import duckdb

with duckdb.connect() as con:
    con.execute(
        """INSTALL azure;
LOAD azure;
CREATE SECRET secret2 (
    TYPE AZURE,
    ACCOUNT_NAME 'account_name'
);"""

However, I get this: duckdb.duckdb.InvalidInputException: Invalid Input Error: Secret type 'azure' not found

hi @aersam thanks for reporting! We've had some issue during release. I've just bumped the azure extension which should resolve the issue. Please reinstall using FORCE INSTALL azure;

Yeah, my CI/CD looks a lot better now, I think it's fixed :)

Thanks for checking back, great to hear it works now!


click the tag, show content on current page rather than scroll down to the tag location

I don't have much background in HTML, CSS, and things like that, and I am quite new to Hugo and the Academic theme, I got an issue that I can not figure out how to fix it. When I click the tag like "publications", "teaching", ect., I want the content show immediately rather than scroll down automatically to where the tag locates. What changes should I make in order to achieve my goals? Thanks.

For your requirements, you may prefer to create multiple widget pages each with one widget per page - and then update your menu to point to the new widget pages. Refer to the docs: https://sourcethemes.com/academic/docs/managing-content/#create-a-widget-page
These issues are for bug reports and feature requests. For questions and support, see https://github.com/gcushen/hugo-academic/blob/master/.github/support.md


Update to dependencies including fs2 to latest versions

Fix the breaking changes from updating FS2 to 0.10.4

Add force to convert Segment to List
Replace onError with handleErrorWith

Update other dependencies to latest versions including sbt-bintray, Scala, and the AWS SDK.

bump, anyone here :) ?


[Feature request] Add triggers/hooks/logic

It would be great if there would be some way to force a fallback and even trigger automations based on RegEx/flexible conditions.
This way even if an LLM claims to be successful, a fallback can be forced (even if not always).
As a sub feature, response chaining can also be supported this way. So the opposite of a fallback.
Today I use an LLM for adding a "personality touch" and on-device for actions. But I need to rely on sentence triggers, which is not very flexible.

Due to Home Assistant implementing this functionality internally, I will no longer be maintaining this. Sorry


Update manage-devices-with-intune-overview.md

Added Business premium as some steps are possible with M365 Business premium
fixes#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/10692

@JohanFreelancer9 Please copy review

Checking with our Business Premium writer before rolling this out . . .

Greetings, Our Business Premium writer took a look at this addition and we agree that it could be confusing to add the licensing to this table, especially since the steps are different for connecting Intune to Defender for Business (instead of Defender for Endpoint). Instead, we're taking the feedback and planning to write a separate solution specifically for Business Premium customers and also including Lighthouse partners.


Patch 1

Hi Charles. please approve the pull request after review of some of the workbooks I thought will be helpful to the hack

Merging changes from hack week


Error on using library

GET https://signaling.simplewebrtc.com:8080/socket.io/1/?t=1423377575466 net::ERR_CONNECTION_TIMED_OUT
Most likely because of socket.io incompatibility

pass url: 'https://signaling.simplewebrtc.com:443' to the constructor  -- when running on a nonstandard port it tries to connect to the same port and there is nothing running on port 8080


Question Title UI Modifications for better space utilization and prominence

Description: Every question title has a prefix "Question #:" in it. This is redundant as the question index is already being displayed in the navigation bar on the top. The highlighted index number displays the current question number. So, we can remove the "Question #:" prefix from the question title.
Also, the CSS of the question title can be modified to make it more prominent.
Current state:

Suggested Modification: The following screenshot is just a mock-up of the suggested modifications.We can have a discussion about the best way to approach the same.

Hi @rabidbit -- any thoughts on this?

I think removing the number is fine. I think the color and alignment could be tweaked, but I know this is just a quick mock-up. I don't think the question title needs to be too prominent (otherwise, it distracts the eye).

Sounds good, thanks! @abinash-behera -- you might also want to get some informal feedback from others when developing this, so that you can iterate towards a good design.


Feature/update tests

Codecov Report

Merging #24 into develop will increase coverage by 1.27%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop      #24      +/-   ##
===========================================
+ Coverage    93.02%   94.29%   +1.27%
===========================================
  Files          124      124
  Lines         1963     1963
===========================================
+ Hits          1826     1851      +25
+ Misses         137      112      -25

Impacted Files
Coverage Δ

src/App/Documentation/components/Slab/index.js
100% <0%> (+5.88%)
:arrow_up:

src/App/Documentation/core/Lists/index.js
100% <0%> (+8%)
:arrow_up:

src/App/Documentation/components/Sheet/index.js
100% <0%> (+9.09%)
:arrow_up:

src/App/components/Alert/index.js
85.71% <0%> (+14.28%)
:arrow_up:

src/App/Documentation/utils/DocToc/index.js
47.05% <0%> (+41.17%)
:arrow_up:

src/App/Documentation/utils/DocContainer/index.js
100% <0%> (+50%)
:arrow_up:

src/App/Documentation/utils/DocHeading/index.js
100% <0%> (+80%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23a4d48...268aa7c. Read the comment docs.


Ionide Not Loading

Describe the bug
Ionide doesn't load. I've been battling with this for a few weeks now and I cannot for the life of me find a work around. It appears Ionide doesn't even start. I have completely uninstalled all extensions as well as VSCode, and then just installed the ionide-specific extensions.
Steps to reproduce
Open an F# project in VSCode
Link to sample reproduction
Doesn't matter, it affects all projects.
Expected behaviour
I get linting. text highlight, type hinting, etc.
Screenshots
Code:

Extensions:

End of LSP trace?

Extension Runtime Status Tab:

Trying to execute get diag info command:

Folder Structure:

.fsproj

Machine info

Of course after holding off for two weeks and finally deciding to post my issue I made progress 2 minutes later.
###Solution:
Was able to get the the extension to bootup by deleting the %APPDATA%/Roaming/Code folder.


boot2docker setup: make test fails in test TestInitializeCannotStatPathFileNameTooLong

Description of problem:
make test fails with
--- FAIL: TestInitializeCannotStatPathFileNameTooLong (0.00s)
volume_test.go:56: Expected to get ENAMETOOLONG error, got stat ivZgXsMAvLAYitpGtstNvMXsAaAVBmToJKPxJVufDWaiBQQslaOhPAoEuIjbVkMcmDgJgkfobtzfZolRdQoaheGbhjnxzkvihGxbmnSySnAbwimRPMFxrJcxuiwsQaQgChZshHzNRRAxQyfPepZcKWmcFjtXQoFCyMIPPsIMJXvKipMxgPXeROmvaabKYFjnJYVHzmliRDpvIHgazZEtFKXBBjWHZQbzsFFcXUvVYRolrzHDJqzmagfkxzxKWjGwshQrEbbVLsmHcgMxevSjaIIqigrpoahVQcrNLFssLHoQ: protocol error
Test environment:
On a mac (OS X 10.9.5) using boot2docker (1.5.0) and docker (1.5.0 - came with boot2docker).
In the build docker container running in Virtualbox
docker version:
Client version: 1.5.0
Client API version: 1.17
Go version (client): go1.4.1
Git commit (client): a8a31ef
OS/Arch (client): darwin/amd64
Server version: 1.5.0
Server API version: 1.17
Go version (server): go1.4.1
Git commit (server): a8a31ef
docker info:
Containers: 2
Images: 46
Storage Driver: aufs
Root Dir: /mnt/sda1/var/lib/docker/aufs
Backing Filesystem: extfs
Dirs: 50
Execution Driver: native-0.2
Kernel Version: 3.18.5-tinycore64
Operating System: Boot2Docker 1.5.0 (TCL 5.4); master : a66bce5 - Tue Feb 10 23:31:27 UTC 2015
CPUs: 8
Total Memory: 1.961 GiB
Name: boot2docker
ID: 3M76:UYVC:AQ6C:VPU4:L3LE:KJOM:QRBH:RLII:JCQO:7HV4:L3XD:7EDO
Debug mode (server): true
Debug mode (client): false
Fds: 20
Goroutines: 29
EventsListeners: 0
Init Path: /usr/local/bin/docker
Docker Root Dir: /mnt/sda1/var/lib/docker
uname -a:
Darwin xxxxxxxxx 13.4.0 Darwin Kernel Version 13.4.0: Wed Mar 18 16:20:14 PDT 2015; xxxxxxxx/RELEASE_X86_64 x86_64
Environment details (AWS, VirtualBox, physical, etc.):
VirtualBox (boot2docker): uname -a
Linux boot2docker 3.18.5-tinycore64 #1 SMP Sun Feb 1 06:02:30 UTC 2015 x86_64 GNU/Linux
How reproducible:
Every time
Steps to Reproduce:

Setup development environment on Mac OS X using boot2docker as per https://docs.docker.com/project/set-up-dev-env/
Start the docker container using (no changes yet in dry-run-test branch)
docker run --privileged --rm -ti -v pwd:/go/src/github.com/docker/docker dry-run-test /bin/bash
Run basic unit test using
hack/make.sh dynbinary binary cross test-unit

Actual Results:

go test -test.timeout=30m github.com/docker/docker/volumes
--- FAIL: TestInitializeCannotStatPathFileNameTooLong (0.00s)
volume_test.go:53: Expected to get ENAMETOOLONG error, got stat EyCwAvvNYrBMvsDjqaaNMWKtmedHadMhXxIGiLNmuq
jnMtJMNocxiicSnfzNJyscOJzzHHCybsUClNSkDSDtZVLKfuYuyokRuXfgZLIkVypeSfpAgxiTLWJDVyAJboesBvYYtWOXotYQqNcEXgfrVNGXPHJI
jnyBRHjqScGvCbVuvynkwAXWubzjSSRitIwlktUbKSyBRuPaXsnZFmJaOHqMLxsVrHEFSAwUkpVxpdSvtPFBHTCvhIzmdahHxdertyaUJQGHtIkIBz
UTCfdNGNqydbufaVhAospgpLgarxQi: protocol error
FAIL

Expected Results:
The test TestInitializeCannotStatPathFileNameTooLong expects that the os.Stat returns ErrNotExist
when given a long path name. Instead is returns "protocol error"
Additional info:
It appears os.Stat returns "protocol error" rather than ErrNotExist because something is different in the
stat system call behavior in the following kernel that is running in VirtualBox VM.
Linux boot2docker 3.18.5-tinycore64 #1 SMP Sun Feb 1 06:02:30 UTC 2015 x86_64 GNU/Linux
So is this a boot2docker issue or docker issue - my guess is that it is docker issue in the test code itself - volumes/volume_test.go - since it is assuming stat will fail with only "file name too long" error.

seems like a VM issue https://www.virtualbox.org/ticket/11976
(I'm replying because I wrote that test)

lol that ticket

@jfrazelle something known?

no I just had never seen something like before... super weird
On Wed, Apr 15, 2015 at 11:40 AM, Antonio Murdaca<EMAIL_ADDRESS>wrote:

@jfrazelle https://github.com/jfrazelle something known?
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/issues/12410#issuecomment-93526647.

I can change the test to check for another error instead of ENAMETOOLONG but I think the "propagation" error they talk about in the issue still remains

@runcom tx for the quick reply. Just wondering the issue reported there is several months old, so how did other folks using boot2docker not run into this - unless boot2docker just recently moved to the Linux kernel with this issue.
I think it would be great to perhaps relax the check on specific expected error string in volume_test.go.

mm not sure about this, checking ENAMETOOLONG was just a check to get an error different from ENOENT IIRC but without the check string yes it's different but no control

@runcom I am tempted to say that if you don't like relaxing the check then the other option is to maybe check for both "protocol error" and ENAMETOOLONG but that does not seem right either without understanding why is "protocol error" occurring.
Just wondering if other folks running boot2docker see this error.

I think that protocol error is an upstream issue that has to be solved upstream and I shouldn't rely on that, just thinking..

@runcom If this is a temporary issue then the other possibility is can you just check that the error is not ErrNotExist

@rustogi good point, I'll do that then if @jfrazelle is ok with this

This can be closed (wrong  format for autoclose sorry)

Thanks @runcom ! "260 chars should be enough for anybody" 😂
This issue was resolved in https://github.com/docker/docker/issues/12412


Improve performance for PyByteArray::new

Hello, recently i found the loading speed of safetensors is more than 50% slow than loading pickle.
https://github.com/huggingface/safetensors/issues/460
for a  1GB numpy array, loading by pickle only need 1s, but safetensors need 1.8s
safetensors load: 1.8608193397521973
pickle      load: 1.004188060760498

Then, i profiled the performance, and found that, the most slower is calling PyByteArray::new, consuming almost all time!
https://github.com/ZHUI/safetensors/tree/performance/load_speed
https://github.com/ZHUI/safetensors/commit/889c43219a0e38731c3045cbb0c4cc9fbb458ce2
                let data =
                    &mmap[info.data_offsets.0 + self.offset..info.data_offsets.1 + self.offset];

                error!("get_tensor mmap done");

                let array: PyObject = Python::with_gil(|py| PyByteArray::new(py, data).into_py(py));

                error!("get_tensor PyByteArray");

[2024-04-08T03:40:56.506Z ERROR safetensors_rust] Open new statrt
load weight<PHONE_NUMBER>.5070753
[2024-04-08T03:40:56.507Z ERROR safetensors_rust] 710 get_tensor
[2024-04-08T03:40:56.507Z ERROR safetensors_rust] get_tensor
[2024-04-08T03:40:56.507Z ERROR safetensors_rust] get_tensor mmap done
[2024-04-08T03:40:58.375Z ERROR safetensors_rust] get_tensor PyByteArray
[2024-04-08T03:40:58.375Z ERROR safetensors_rust] create_tensor done!
sf load: 1.9328322410583496

for PyByteArray::new(py, data);, the data is mmap address, the PyByteArray::new simple called PyByteArray_FromStringAndSize
https://github.com/python/cpython/blob/733e56ef9656dd79055acc2a3cecaf6054a45b6c/Objects/bytearrayobject.c#L134-L142
it seems just memcpy the mmap data to memory and the data is copying for disk->mem.
and i don't know why it is so slow, does it have additional mem->mem copy for this optional?  thus disk->mem->mem
It there any way to create a PyByteArray from an exists memory without copy data?

It there any way to create a PyByteArray from an exists memory without copy data?

I don't think that is possible, especially with PyByteArray which provides mutable access to the underlying data. Do you need mutability? If not, PyBytes might be a better choice but even that type will copy to move ownership of the data under the control of the Python heap.
I think a real zero-copy solution would be to implement a custom pyclass which implements the buffer protocol and is directly backed by the Mmap instance you already have. We recently discussed this in #4003 and we use something similar in rust-numpy, albeit as a NumPy base object, without the buffer protocol but used to perform type erasure.

Thanks for you  answer.  I am not very familiar with rust.

even that type will copy to move ownership of the data under the control of the Python heap.

it mean the data will always copy  since we pass data from rust to python?

I think a real zero-copy solution would be to implement a custom pyclass which implements the buffer protocol and is directly backed by the Mmap instance you already have. We recently discussed this in #4003 and we use something similar in rust-numpy, albeit as a NumPy base object, without the buffer protocol but used to perform type erasure.

https://github.com/PyO3/rust-numpy/blob/0832b28bf84a3f6053ca647a43625d715831db00/src/array.rs#L402-L421
I checked the PySliceContainer code, is it using  rust  data_ptr ->  python PySliceContainer data_ptr addr -> python PY_ARRAY_API.PyArray_SetBaseObject to avoid memcpy.
        let mut dims = dims.into_dimension();
        let ptr = PY_ARRAY_API.PyArray_NewFromDescr(
            py,
            PY_ARRAY_API.get_type_object(py, npyffi::NpyTypes::PyArray_Type),
            T::get_dtype_bound(py).into_dtype_ptr(),
            dims.ndim_cint(),
            dims.as_dims_ptr(),
            strides as *mut npy_intp,    // strides
            data_ptr as *mut c_void,     // data
            npyffi::NPY_ARRAY_WRITEABLE, // flag
            ptr::null_mut(),             // obj
        );

        PY_ARRAY_API.PyArray_SetBaseObject(
            py,
            ptr as *mut npyffi::PyArrayObject,
            container as *mut ffi::PyObject,
        );

        Bound::from_owned_ptr(py, ptr).downcast_into_unchecked()

Can i use your PySliceContainer directly? or can your give me some pseudo-code to implement it？

it mean the data will always copy since we pass data from rust to python?

Basically because someone has to free the data and know how to do that, i.e. in our case the main task of PySliceContainer is to call the correct drop functions when Python's reference count reaches zero because Python types like bytes do not know how to free Rust-allocated memory.

Can i use your PySliceContainer directly? or can your give me some pseudo-code to implement it？

I don't think so because this type is pretty much tied to backing a NumPy array by a rust-allocated Vec (or boxed slice), but if I understand you correctly you want bytes-like access to a Mmap instance.
I fear you will have to figure this out via https://pyo3.rs/v0.21.1/class/protocols.html?highlight=__getbuffer__#buffer-objects which is a thin layer over the CPython FFI objects until we provide a more ergonomic API to achieve this.
Thinking outside of the box, I am not sure how exactly you are using Rust here but you could also just use Python's mmap support directly and pass the resulting object to Rust as PyAny. But I am not sure how you want to access those bytes afterwards...

Thanks for you advice. For  my case copy mmap is reasonable for load weight to MEM.
The core problem is memcpy for mmap memory is very slow. see:
https://stackoverflow.com/questions/52845387/improving-mmap-memcpy-file-read-performance
for my case， open(filename); f.read() is 2 GB/s,  for memcpy(mmap(filename)) is 1.3 GB/s.
which is mach more slower than read file.

This seems reasonable: If you are going to read the whole file, f.read() knows this intent and can optimize accordingly while memcpy(mmap(filename)) needs to figure this out via the page faults incurred.
I guess you could reduce the difference by applying madvice(.., MADV_SEQUENTIAL); to the memory map to tell the kernel about what you are going to do, but there is little point in modifying the process' address space if all you going to do is pull the data into a buffer. Bypassing the page cache via direct I/O might be useful if you really read it only once (and not repeatedly in an interactive session).
Using std::fs::read and IntoPyArray should also provide a performant approach to turn this into a NumPy array without additional copies.


Using compel affects SDXL 0.9 output (degraded results)

I've been tracking the pr of supporting SDXL 0.9 and saw that released a few hours ago. I've tested and based on my results, I can say that when compel is used with SDXL, the output is degraded in quality without even using and weighting.
The example code was taken from: https://pypi.org/project/compel/2.0.0/
PS: I had to omit returned_embeddings_type=ReturnedEmbeddingsType.PENULTIMATE_HIDDEN_STATES_NON_NORMALIZED in order to make it work. Not sure where to import ReturnedEmbeddingsType
import torch
from compel import Compel
from diffusers import DiffusionPipeline

pipe = DiffusionPipeline.from_pretrained("stabilityai/stable-diffusion-xl-base-0.9", torch_dtype=torch.float16, use_safetensors=True, variant="fp16")
pipe.to("cuda")

compel = Compel(tokenizer=[pipe.tokenizer, pipe.tokenizer_2] , text_encoder=[pipe.text_encoder, pipe.text_encoder_2], requires_pooled=[False, True])

# Without compel
generator = torch.Generator(device="cuda").manual_seed(40)
prompt = "Shot of Vaporwave fashion dog in miami, cinematic"

images = pipe(prompt=prompt, generator=generator, guidance_scale=7.5, num_images_per_prompt=1, num_inference_steps=50).images;

for image in images:
  image.show()

# With compel
generator = torch.Generator(device="cuda").manual_seed(40)

prompt = "Shot of Vaporwave fashion dog in miami, cinematic"
conditioning, pooled = compel(prompt)

images = pipe(prompt_embeds=conditioning, pooled_prompt_embeds=pooled, generator=generator, guidance_scale=7.5, num_images_per_prompt=1, num_inference_steps=50).images;

for image in images:
  image.show()

Without Compel Results:

With Compel Results:

I had to omit returned_embeddings_type=ReturnedEmbeddingsType.PENULTIMATE_HIDDEN_STATES_NON_NORMALIZED in order to make it work

omitting that will indeed result in degraded results

try from compel import Compel, ReturnedEmbeddingsType

i've updated the README, please LMK if the import above resolves your issue

Yep, that solved it. Will be testing further with weighing etc. Closing for now.


python27Packages.bitarray: 1.2.1 -> 1.2.2

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python2.7-bitarray/versions.
meta.description for python27Packages.bitarray is: "Efficient arrays of booleans"
meta.homepage for python27Packages.bitarray is: "https://github.com/ilanschnell/bitarray"
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.2.2 with grep in /nix/store/8jk4yfmc7n8lc929x6v962smbvjia32z-python2.7-bitarray-1.2.2

directory tree listing: https://gist.github.com/8261e8abb6ca4ea78baeaa076a31dcfa

du listing: https://gist.github.com/82eab0a63231ec82cf2703b72f2992a1

Rebuild report (if merged into master) (click to expand)

20 total rebuild path(s)

5 package rebuild(s)

5 x86_64-linux rebuild(s)
5 i686-linux rebuild(s)
5 x86_64-darwin rebuild(s)
5 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
glasgow
python27Packages.bitarray
python37Packages.bitarray
python37Packages.glasgow
python38Packages.bitarray

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/8jk4yfmc7n8lc929x6v962smbvjia32z-python2.7-bitarray-1.2.2 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python27Packages.bitarray https://github.com/r-ryantm/nixpkgs/archive/8694a8f65e658a7f566456c43b246c1be962f905.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/8jk4yfmc7n8lc929x6v962smbvjia32z-python2.7-bitarray-1.2.2
ls -la /nix/store/8jk4yfmc7n8lc929x6v962smbvjia32z-python2.7-bitarray-1.2.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

4 packages built:
- glasgow (python37Packages.glasgow)
- python27Packages.bitarray
- python37Packages.bitarray
- python38Packages.bitarray

Maintainer pings
cc @bhipple for testing.

Result of nixpkgs-review pr 88665 1

4 packages built:
- glasgow (python37Packages.glasgow)
- python27Packages.bitarray
- python37Packages.bitarray
- python38Packages.bitarray


Color track according to the slope

Hi,
Is it possible that the color of the track is variable according to the slope ?
For example, blue on the downhill, Red on the uphill, Green on the flat, with a gradient according to the strength of the slope.
Regards

Not directly. leaflet-gpx just creates a L.Polyline object for the whole track, passing it some optional styling options that you can configure, but this doesn't allow for making the color depend on the slope/incline.
For that, it might require creating many small L.Polyline for each part of the track that has contiguous downhill or contiguous uphill, which could lead to serious performance issues for Leaflet. It seems to be what most Leaflet plugin that try to achieve this do though, but I'm not sure how far you'd be able to push it.

Ah OK, thank you very much for this answer.


Fix Issue 23359 - Rename InOut to ParameterStorageClass

InOut is confusing and wrong. It’s the parameter storage classes and should aptly named.

Again, why is CircleCI failing?

"Could not find a usable config.yml, you may have revoked the CircleCI OAuth app.
Please sign out of CircleCI and log back in with your VCS before triggering a new pipeline."
Did you decline CircleCI access to your fork?

CircleCI Security Alert:  There is an ongoing phishing attempt to obtain CircleCI credentials. For more information, please see our post here
Status: Partial Outage

Closing in favor of #3413 (has Bugzilla reference).


What is the license of the tool?

Hey, I'm adding IT to analysis-tools.dev over here: https://github.com/analysis-tools-dev/static-analysis/pull/553
One thing I noticed was that I can't find any license information for InspectorTiger anywhere. 🤔
By definition that means the tool is proprietary and I'm not sure if that is your intention or it was just an oversight.
Maybe you can shed some light on the situation. 😊

Indeed, thanks for noticing that. I've licensed it with MIT from the commit 0a32be5a6112dde0943cd8f4063a49c0e96a85c2.

Thanks!


Refactor Settings and fix launch environment

Changelog Description

Refactor settings to match with feedback in #31
Additional info

This is a first pass draft, and likely does not work. Just wanted to put it up so there's visibility on that I have a first pass on this. This now works for me, with both Houdini 20 and Maya 2024.2

Bugfix: The used settings are now from the active bundle (and use ayon_core studio settings and project settings retrieval)
Bugfix: Launch context environment is now maintained and used (this contains #32)
Bugfix: Setup resolver env logic now does not 'kill' PATH on Windows by accident because it previously stacked to LD_LIBRARY_PATH and got set to PATH. It is now 'appended'toPATH`.
Simplifies settings (and also changes the settings keys! So note that you need to reconfigure your settings)
Improves logging for invalid server repository, it will report now no timestamp was found for that path. Which was better than the unclear error before.
Added more docstrings to functions

A potential downside to this PR is that aside of the LakeFS instance connection it now uses no local cache - which of course can be implemented in a separate PR later.
Testing notes:

Clone the repository, checkout the branch (and don't forget all the git submodules, etc.)

Note that there's a currently a non-working git submodule set (like in develop branch) for ayon_bin_client. Use branch release_v0_1_0 instead for that submodule. Fixed with https://github.com/ynput/ayon-usd/pull/36

Configure the settings using the LakeFS urls, etc. (request them with Lyon from Ynput team)
Launch Maya or Houdini

@Lypsolon I suppose this is now in your lap - but I'll also add @antirotor as reviewer just in case.

Basic Testing on Almalinux 9
Installed New addon and opend houdini (Resolver was loaded as expected)
Im not the biggest fan of using direct Dict[] access but if most developers like this we can keep it this way.
i would like to ask @BigRoy and @iLLiCiTiT what you think about using a data class that simply exposes the data. aka: Dataclass(settings).lakeFs_Setting_A instead of the direct dict asses.
I prefer that but that might just be bias and if most Developers Prefer it the other way around then this code Looks Good.

Dataclass(settings).lakeFs_Setting_A instead of the direct dict asses.
I prefer that but that might just be bias and if most Developers Prefer it the other way around then this code Looks Good.

I think the best we could get to is sharing the actual pydantic setting classes and somehow be able to use that frontend without much magic and code shuffling around at runtime so that an IDE is able to pick that up. Otherwise it's still a matter of maintaining the models on both client and backend site separately - which I'd prefer to avoid.
But then we'd get type hints as well! (which copying a dataclass to client manually would also do, etc.) - however I have no idea if anything like that is even feasible without code duplication.
Anyway, again - there's merit to it, but preferably this is done in a way that makes sense across all addons. So this may be worth a separate issue in a more global space and go from there.
Also, no matter what we choose - definitely a separate issue or PR.
@Lypsolon could you give the the "Approved" stamp?

We could have model that is dynamically created based on server models, but only change at the end would be that I do settings.lake_fs instead of settings["lake_fs"]. Considering there might be addons that are accessing other addons settings (should not happen, but it does), then you're kinda screwed.
Sum up: I don't see any advantage to use attributes over dictionary keys. It only adds unecessary conversion step of settings to objects, that cannot be used in IDE, because it has to be created on the fly based on current server model (which IDE does not doo).


[ruby] self Param REF Edge

Fixed issue where no REF edges between self params and their identifiers.

@maltek thanks, I'll verify against railsgoat to debug

@maltek Fixed the rest of the cases

@maltek FYI this is causing tests to fail in codescience. I'll chat with Markus when he's back from leave to understand why this may be an issue.


Add warning messages for orphan nodes on debug builds

Godot version:
Any
OS/device including version:
Any
Issue description:
A lot of times, bugs I face when working with Godot were caused by forgetting to add_child() a node to the scene (like an AudioStreamPlayer yday). An idea that might help is adding a warning message to the output for any orphan node you have on your game.

This may also lead to leaks of unreferenced Objects, I think there was another similar issue about that.

I'm not sure displaying a warning is a good thing.
As you might want to keep a Node outside the tree on purpose, I don't think it's a good idea to spam the user for that.

@groud there is no reason to create a Node and lose reference to it, I think, also there is a message of objects still in use when closing the program, but nothing tells you what objects are these, if it can throw a warning when you get an unreferenced object it may be easier to spot.

"Not referenced" is not "not in tree", this is not the same. The add_child() method add the node to the tree, while var mynode = load("my_node.tres")  is a reference.
A warning for unreferenced objects might make sense, but I'm not sure it's even possible as unreferenced objects are deleted automatically.

Only types derived from Reference are deleted automatically, Nodes are not.
Nodes out the tree are useful only if you are keeping a pool of them, since they don't process. I've seen people trying to use the Tree control as a data structure, but that's not a good practice anyway. So a warning might be good, the only problem is when to trigger it.

Isn't there a -v option when running Godot so it tells which objects were leaked in detail?

-v for the editor or the exported game? I can do a var n = Node.new() somewhere to generate an orphan Object and I do not see anything anywhere other than increasing Object count in the monitor.

@eon-s it's a command line argument to send at the execution of Godot, I'm curious if the editor can set it when debugging games. If you don't set it, you should still see a warning like "WARNING: cleanup: ObjectDB Instances still exist!"

You can set the run options in the project settings, but it seems that it skips this final phase when running from the editor, so the warning is never shown. It does show if you run directly from the command line.

#28140 has implemented a monitor for orphan nodes, closing.


Crash when confirm a "Start chat" room with no member

To reproduce:

Hit "+" button, then "Start chat"
Choose a member, then delete it (X button)
Hit the confirm button

Riot crashes
Version 0.60-dev (dbcb396)

Fixed with in PR: 'Fix crash when getDirectChatRoomsDict() returns null #95'


Forbidden MonoBehaviour instantiation through constructor

Describe the bug
When building a poject using MRTK v2.3 I get a warning in the Unity console

You are trying to create a MonoBehaviour using the 'new' keyword.  This is not allowed.  MonoBehaviours can only be added using AddComponent(). Alternatively, your script can inherit from ScriptableObject or no base class at all
UnityEngine.MonoBehaviour:.ctor()
Microsoft.MixedReality.QR.Init:.ctor()
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr)

when looking into Microsoft.MixedReality.QR.Init which is MonoBehaviour you are using [InitializeOnLoad] combined with a static Init() constructor. This is not allowed and very unclean for Unity. dos this even need to be a MonoBehaviour?
In general I just want to point out that there is also [InitializeOnLoadMethod] which you could/should use instead so no constructor is used but you can still execute a private static void Initialize() or something similar.

Unity Version any
MRTK Version v2.3

Target platform

HoloLens
HoloLens 2

Thanks for the report!
Microsoft.MixedReality.QR is not part of this repo. Did you import that separately?

Closing as External


added Inline layout object

I added a new Layout object called Inline. This object lets you render a crispy form/formset inside crispy form. As a Layout object, it can be used anywhere a Field can be used.

@kenthauser This looks good.
I think we need a test covering the basic Happy Path functionality and it needs bringing up to date (rebase).

I'm going to close this given the lack of update. @kenthauser I'm very happy to look at it again if you want to come back to it.


Remove COINBASE_FLAGS

Defined here: https://github.com/jnewbery/bitcoin/blob/edb6b768a4185a4aaa6281ee50a6538f7426cb1e/src/validation.cpp#L133
See where it was added and why it is no longer used.

Sounds like a miner left-over?

d449772cf69c01932fc5d72c46054815d6300b3c

Correct!


Openwhisk Returned HTTP 400 (Bad Request) --> "The request content was malformed:

If an environment variable or another default parameter is not properly set then sls deploy will throw an error. The error that displays is only:
Returned HTTP 400 (Bad Request) --> "The request content was malformed:
However under the covers if you add additional logging you will find.
 message:
   'PUT https://us-south.functions.cloud.ibm.com/api/v1/namespaces/OURNAMESPACE/actions/add-users?overwrite=true Returned HTTP 400 (Bad Request) --> "The request content was malformed:\nparameters malformed!"',
  error:
   { code: '5e5ddc3f2084d2c18cbdbfc66e8665cc',
     error: 'The request content was malformed:\nparameters malformed!' },
  statusCode: 400 }

I feel like there should be a preflight check fo parameters or at the very least a more verbose error message when this happens as it's not 100% apparent what is causing the error without going into the code and adding a log node_modules/serverless-openwhisk/deployFunction/index.js:70

Hello Michael - can you expand on what you mean by environment variable or another default parameter not being set? Do you mean the authentication parameters like (__OW_API_HOST) or something else?
Can you provide a test-case for this and it can get added to the backlog? Adding more verbose error messages or pre-flight checks seems like a good idea. If you want to have a go at a PR - I'd happily review and work on getting it merged.

Where can I find that file when using faas in IBMCloud ?


support 2200m and 630m bands

WSPR bands are noted as a code comment for 136.0 kHz (2200m) and 474.2 kHz (630m), but not actually listed in FSKview.
Add these two bands here:
https://github.com/swharden/FSKview/blob/2076f02eca50999cc4cfe3dd154af95d40cb2832/src/FSKview/WsprBands.cs#L11-L33

solved, will be in 1.0.10


errors out on interface collection..

Getting this error:
root@sw-d8-r11-u36:~# ./sonic-exporter --web.listen-address=:9102
ts=2023-10-27T18:34:31.996Z caller=tls_config.go:274 level=info msg="Listening on" address=[::]:9102
ts=2023-10-27T18:34:31.996Z caller=tls_config.go:277 level=info msg="TLS is disabled." http2=false address=[::]:9102
ts=2023-10-27T18:34:37.741Z caller=interface_collector.go:129 level=info msg="Starting interface metric scrape"
ts=2023-10-27T18:34:37.741Z caller=hw_collector.go:123 level=info msg="Starting hw metric scrape"
ts=2023-10-27T18:34:37.743Z caller=interface_collector.go:118 level=error err="interface counters collection failed: err counters collection failed: value parse failed: strconv.ParseFloat: parsing \"\": invalid syntax"
ts=2023-10-27T18:34:37.745Z caller=hw_collector.go:144 level=info msg="Ending hw metric scrape"

This is using Edgecore Sonic.
SONiC Software Version: SONiC.Edgecore-SONiC_20230822_033113_ec202111_497
Distribution: Debian 11.7
Kernel: 5.10.0-8-2-amd64
Build commit: b91813523
Build date: Tue Aug 22 10:42:26 UTC 2023
Built by: ubuntu@ip-10-5-1-222

Platform: x86_64-accton_as4630_54npe-r0
HwSKU: Accton-AS4630-54NPE

Suggestions?

Hi, this exporter was only tested on Community Sonic, I don't have an EdgeCore Sonic image to test it out so there might be some issues.
I found what the root cause is and will try to release a fix shortly.

Please try using the v0.1.2 release, the issue should be fixed.

@ThomasADavis Please try using the v0.1.2 release, the issue should be fixed.

Thanks, it works!


[ColorPicker] - Decimal RGB color format

Summary of the Pull Request
What is this about:
This PR adds a new color format for ColorPicker and updated names and comments so users can pick between Decimal RGB and Decimal BGR.
What is included in the PR:

new color format (Decimal RGB)
refactoring of computation
new tests for Decimal color formats
small test refactoring

How does someone test / validate:

color decimal value computation is covered with unit tests
color picker can be selected in Settings UI
use picker on #FF0000 and #0000FF to see a clear difference in Decimal RGB and BGR

Quality Checklist

[x] Linked issue: #16678
[x] Communication: I've discussed this with core contributors in the issue.
[x] Tests: Added/updated and all pass
[x] Installer: N/A
[x] Localization: N/A
[x] Docs: N/A
[x] Binaries: Any new files are added to WXS / YML

[x] No new binaries
[ ] YML for signing for new binaries
[ ] WXS for installer for new binaries

Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.

It's been open for a while, but without any traction. Going to close it, but feel free to re-open if you still want to get this in.


Giant buttons on mobile

Giant buttons on mobile, on a normal size desktop, can this be set up?
    actions:     - type: button       text: 'Grafana'       url: 'https://xxx.xxx.com/'

This seems like a slack issue and not alertmanager one. AFAIK button size is not customizable via slack message payload.

As @paulfantom says, the problem should be reported to Slack directly.


Themes not display the 12H clock succesfully

Themes not display the 12H clock succesfully.

Incomplete 12h clock in default RetroOZ image themes:

ES-THEME-NES-BOX

The problem is the font size.


lightningcss: Add passthru testVersion

Description of changes
With a version flag now added, Nix expression adds testVersion. Obsolesces, fixes #191399
It would be better to get the actual version number, but currently the Rust CLI version is labeled as alpha and not in sync with the release version. Awaiting a comment about this situation, and if possible, will fix in the next release.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

I merged the auto update PR. Would be really good to have this additional test. Could you rebase and rename it to lighningcss: Add passthru test

@onny

@onny

Please update commit name and rebase so that in changes only the pasthru test is added

@ofborg eval

Maybe some day this will work. Currently this fails because the version is broken upstream and not in line with the release.


Bump TypeScript Eslint

Happy with the change. But I'd like to see this change bundled with any other possible breaking changes before releasing. If there are any.

Yeah I'll have to chain it up with eslint-config-skuba etc


Type Mismatch

When making a new nodeProperty<> that has anything to do with object selection, I am unable to get the inspector to take in an object without returning "Type Mismatch">
Heres a video I took of the problem, I did this on another project to ensure it wasn't an issue with my library (hence the terrible object names) https://youtu.be/maRfT0QyG68

My workaround is to override the property via inspector https://github.com/thekiwicoder0/UnityBehaviourTreeEditor#blackboardkey-overrides

Will revisit at some point. It's unlikely the NodeProperty structure will remain the way it is


Refactor video loading, 2nd try

More preparatory refactorings for the layout management code ...
NOTE: This subsumes #106, so that PR should be reviewed and merged first.

Note that with this PR, the video in the "grunt dev-verion" is no longer hard coded to be at resources/aav1.mp4. You can (and have to) give a URL to a video with the video URL parameter, like so:
http://localhost:9001?video=resources/aav1.mp4

This would restore the old behavior, assuming there actually is a file under that path in the www directory. Absolute (and thus also foreign origin) URLs should work fine, too.

Player control issue: #112.


4.0.1 Release

Codecov Report

Merging #98 into master will decrease coverage by 0.13%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master      #98      +/-   ##
============================================
- Coverage     14.34%   14.21%   -0.14%
  Complexity       36       36
============================================
  Files            47       47
  Lines          1833     1850      +17
  Branches        136      141       +5
============================================
  Hits            263      263
- Misses         1564     1581      +17
  Partials          6        6

Impacted Files
Coverage Δ
Complexity Δ

...c/main/java/com/conveyal/taui/models/Bookmark.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

.../java/com/conveyal/taui/models/AddTripPattern.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...ava/com/conveyal/taui/models/ModificationStop.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...n/java/com/conveyal/taui/persistence/MongoMap.java
4.21% <0%> (ø)
2 <0> (ø)
:arrow_down:

src/main/java/com/conveyal/taui/models/Region.java
27.27% <0%> (ø)
0 <0> (ø)
:arrow_down:

...rc/main/java/com/conveyal/taui/AnalysisServer.java
39.6% <0%> (-0.4%)
4 <0> (ø)

...java/com/conveyal/taui/models/AnalysisRequest.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...l/taui/controllers/RegionalAnalysisController.java
10.75% <0%> (ø)
2 <0> (ø)
:arrow_down:

...aui/controllers/OpportunityDatasetsController.java
6.06% <0%> (ø)
2 <0> (ø)
:arrow_down:

...com/conveyal/taui/persistence/TiledAccessGrid.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df8f18...6015233. Read the comment docs.


Updating the enablement language for Using GitHub Copilot Chat

Code of Conduct

[x] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
Link: https://docs.github.com/en/copilot/github-copilot-chat/using-github-copilot-chat
Link: https://docs.github.com/en/copilot/github-copilot-chat/using-github-copilot-chat#enabling-or-disabling-github-copilot-chat-at-the-enterprise-level-1
What part(s) of the article would you like to see updated?

Updated

Update Blocked to Disabled
Update Allowed to Enabled

Additional information
No response

👋 @iamcjwilliams Thanks so much for opening an issue! I'll triage this for the team to take a look :eyes:

I'm going to transfer this issue to the internal repository for docs issues so that we can handle this internally.


XDP Support

I was using ebpf_exporter in my project and realized that there is no XDP support in the project. I forked the project and edited it to support XDP programs. I used libbpfgo's AttachXDP function to attach the XDP program to the required interface.
My edit contains two new fields in YAML files: is_xdp  to indicate if the metric has an XDP program, and interfaces is an array with interfaces to attach the XDP program. And usage is like:
is_xdp: true
interfaces: ["enp8s0", "docker0"]

If you consider it worth adding support for XDP programs I can open a PR.

What do you think about using SEC("xdp/enp8s0") instead (see: https://github.com/cloudflare/ebpf_exporter/pull/154)? The downside is that the interface is hardcoded in a program, but the upside is that it's consistent with other SEC setups.
In your setup I don't think there's a need for is_xdp. You can detect it from SEC("xdp"). Having interfaces set in the config means that you attach all programs to all interfaces. I can imagine cases where you'd want to have different programs on different interfaces as a part of the same config.

Makes sense but when I try to use SEC("xdp/enp8s0") in my program I get this error:
missing BPF prog type, check ELF section name 'xdp/enp8s0
failed to load: -22
Error attaching exporter: error loading bpf object from "src/xdp.bpf.o" for config "xdp": failed to load BPF object: invalid argument'

I don't think it recognizes 'xdp/enp8s0' as an XDP program.
It is possible to get the interface from the SEC part but only if this problem can be solved.

I linked https://github.com/cloudflare/ebpf_exporter/pull/154 because it implemented SEC("perf_event/type=0,config=3,frequency=99").
You can do a similar thing here to implement SEC("xdp/enp8s0").

Okay, I will examine the codes and try to implement a similar one. I hope it's not a problem if I ask questions about the codes if I have problems.

I merged #215, thanks!


Error: Resolution bigger than maximum

Im using Oak-D-Pro-W-97 and ros2-humble
I have the following error when I launch camera.launch.py of the depthai_ros_driver package:
"[ERROR] [launch_ros.actions.load_composable_nodes]: Failed to load node 'oak' of type 'depthai_ros_driver::Camera' in container '/oak_container': Component constructor threw an exception: ColorCamera(0) - 'video' width or height (1280, 720) bigger than maximum at current sensor resolution (854, 534)"
Launch-file:
1691130005.2882426 [INFO] [launch]: All log files can be found below /home/julian/.ros/log/2023-08-04-08-20-05-287520-julian-ThinkPad-L490-5887
1691130005.2883549 [INFO] [launch]: Default logging verbosity is set to INFO
1691130005.6257164 [INFO] [robot_state_publisher-1]: process started with pid [5904]
1691130005.6259181 [INFO] [component_container-2]: process started with pid [5906]
1691130005.6548066 [robot_state_publisher-1] [INFO] [1691130005.654550170] [oak_state_publisher]: got segment oak
1691130005.6553915 [robot_state_publisher-1] [INFO] [1691130005.655212690] [oak_state_publisher]: got segment oak-d-base-frame
1691130005.6557660 [robot_state_publisher-1] [INFO] [1691130005.655351986] [oak_state_publisher]: got segment oak_imu_frame
1691130005.6558864 [robot_state_publisher-1] [INFO] [1691130005.655364852] [oak_state_publisher]: got segment oak_left_camera_frame
1691130005.6559782 [robot_state_publisher-1] [INFO] [1691130005.655373450] [oak_state_publisher]: got segment oak_left_camera_optical_frame
1691130005.6560707 [robot_state_publisher-1] [INFO] [1691130005.655381589] [oak_state_publisher]: got segment oak_model_origin
1691130005.6561615 [robot_state_publisher-1] [INFO] [1691130005.655389206] [oak_state_publisher]: got segment oak_rgb_camera_frame
1691130005.6562457 [robot_state_publisher-1] [INFO] [1691130005.655396637] [oak_state_publisher]: got segment oak_rgb_camera_optical_frame
1691130005.6563303 [robot_state_publisher-1] [INFO] [1691130005.655404261] [oak_state_publisher]: got segment oak_right_camera_frame
1691130005.6564093 [robot_state_publisher-1] [INFO] [1691130005.655413045] [oak_state_publisher]: got segment oak_right_camera_optical_frame
1691130005.8796866 [component_container-2] [INFO] [1691130005.879163666] [oak_container]: Load Library: /home/julian/Software/Assemblyassist/dai_ws/install/depthai_ros_driver/lib/libdepthai_ros_driver.so
1691130005.9675229 [component_container-2] [INFO] [1691130005.967208517] [oak_container]: Found class: rclcpp_components::NodeFactoryTemplate<depthai_ros_driver::Camera>
1691130005.9677582 [component_container-2] [INFO] [1691130005.967276317] [oak_container]: Instantiate class: rclcpp_components::NodeFactoryTemplate<depthai_ros_driver::Camera>
1691130005.9765518 [component_container-2] [INFO] [1691130005.976050234] [oak]: No ip/mxid specified, connecting to the next available device.
1691130008.4309049 [component_container-2] [INFO] [1691130008.430647800] [oak]: Camera with MXID: 18443010E1EE870E00 and Name: 1.1 connected!
1691130008.4316204 [component_container-2] [INFO] [1691130008.431441723] [oak]: USB SPEED: SUPER
1691130008.4533288 [component_container-2] [INFO] [1691130008.452640240] [oak]: Device type: OAK-D-PRO-W-97
1691130008.4556460 [component_container-2] [INFO] [1691130008.454996653] [oak]: Pipeline type: RGBD
1691130008.4750526 [component_container-2] [INFO] [1691130008.474498593] [oak]: NN Family: mobilenet
1691130008.6210980 [component_container-2] [INFO] [1691130008.620798154] [oak]: NN input size: 300 x 300. Resizing input image in case of different dimensions.
1691130008.9908464 [component_container-2] [INFO] [1691130008.990133760] [oak]: Finished setting up pipeline.
1691130009.1933334 [component_container-2] [18443010E1EE870E00] [1.1] [1.487] [ColorCamera(0)] [warning] Unsupported resolution set for detected camera OV9782, needs 800_P or 720_P. Defaulting to 800_P
1691130011.4340112 [component_container-2] [ERROR] [1691130011.433268928] [oak_container]: Component constructor threw an exception: ColorCamera(0) - 'video' width or height (1280, 720) bigger than maximum at current sensor resolution (854, 534)
1691130011.4364607 [ERROR] [launch_ros.actions.load_composable_nodes]: Failed to load node 'oak' of type 'depthai_ros_driver::Camera' in container '/oak_container': Component constructor threw an exception: ColorCamera(0) - 'video' width or height (1280, 720) bigger than maximum at current sensor resolution (854, 534)
1691130035.4851186 [WARNING] [launch]: user interrupted with ctrl-c (SIGINT)
1691130036.4734519 [component_container-2] [INFO] [1691130035.484553123] [rclcpp]: signal_handler(signum=2)
1691130036.4744947 [INFO] [robot_state_publisher-1]: process has finished cleanly [pid 5904]
1691130036.4752407 [INFO] [component_container-2]: process has finished cleanly [pid 5906]
1691130036.4766872 [robot_state_publisher-1] [INFO] [1691130035.484553441] [rclcpp]: signal_handler(signum=2)

Hi, currently default parameters are set for OAK-D-PRO (not W), so if you want to use the camera you should update the parameters (there is also a separate parameter file for OAK-D-PRO-W)


Backfed Google+ Comments Date String

Google+ Comments are currently back feeding without Timezone information in timestamps.
Date of comments is feeding as 2016-03-29T13:24:56 for example.
For interoperability purposes, comments should feed as:
2016-03-29T13:24:56Z or
2016-03-29T13:24:56+00:00
Please note: This might be a webmention.io issue. Thought I'd raise it here first.

thanks for filing! yeah, bridgy's G+ markup has been somewhat buggy for a long time now. more in snarfed/granary#105. I'm impressed that you have enough recent usage to notice and care!

huh actually @dg01d i'm not seeing this. eg this recent comment backfed to you, https://brid-gy.appspot.com/comment/googleplus/100181601806021882083/z13djziomxbvito0t22pz5nj4zurxfasx/z13djziomxbvito0t22pz5nj4zurxfasx.1470768965306543 , has the Z suffix on dt-*:
<time class="dt-published" datetime="2016-08-09T18:56:05.306Z">2016-08-09T18:56:05.306Z</time>
<time class="dt-updated" datetime="2016-08-09T18:56:05.306Z">2016-08-09T18:56:05.306Z</time>

do you have an example that doesn't?

tentatively closing. feel free to reopen!


Typos

[x] 1. On the delete prompt box, attempting is missing a t. (also remove the virtual machine just call it image)

[x] 2. For the name length restriction case, it's better to say:
Name cannot be longer than 63 characters -> "Name" cannot be more than 63 characters.

[x] 3. Required fields not completed! In this case, it's better to say: Required fields are not completed! Or anything else can make it better

Validated


Write closed-loop speed control for flywheel on BreadBot

If using SparkMax/Neo, here's example code for running speed control on a single motor. Note that this code is complete and could largely be used as is, setting the device id to 1 and using a joystick stick to control the speed set point.
https://github.com/REVrobotics/SPARK-MAX-Examples/blob/master/Java/Velocity Closed Loop Control/src/main/java/frc/robot/Robot.java

Is this necessary now that the shooter on Spangler has closed-loop PID speed control?


WIP: add nbval to test example notebooks

The plan is to run the example notebooks in the data test job, and check that the output stays the same over time. That means we will have less work when releasing, because we don't need to check the examples manually.
Piggy-backing on this PR are some changes that reduce the number of threads that are started in numba, OpenBLAS, MKL etc. - they were unused anyways, and caused problems when running many notebooks/dd clusters in parallel. Best way to monitor number of threads of the current user: watch -n1 "ps ux -L | wc -l"
TODO

[x] Make --nbval-lax pass
[x] Make --nbval pass
[x] Add notebooks tox environment to the data tests

Contributor Checklist:

[N/A] I have added or updated my entry in the creators.json file
[ ] I have added a changelog entry for my contribution
[ ] I have added/updated documentation for all user-facing changes
[x] I have added/updated test cases
[ ] I have included the rebuilt production build of the client (only if changes were made to the GUI)

Reviewer Checklist:

[ ] /azp run libertem.libertem-data passed

/azp run libertem.libertem-data

/azp run libertem.libertem-data

/azp run libertem.libertem-data

@uellue the CoM notebook fails because the print(result.field) is numerically different - do you have an idea why and/or how to fix this? Maybe because of slightly different versions? numpy patch version is different, for example; so maybe also different BLAS version etc. - the np.allclose(...) check at the end still succeeds. Maybe we can ignore the output of those two cells?
Also, numba doesn't like what we are doing with the NUMBA_NUM_THREADS env var - I'll have another look at that on Thursday probably.
Other than those failures, this should be ready for review.

For the numerical issue one could use https://numpy.org/doc/stable/reference/generated/numpy.printoptions.html to limit the digits in the notebook output.

That's a good idea, I'll adjust the notebooks accordingly!

/azp run libertem.libertem-data

/azp run libertem.libertem-data

We should probably also have some contributor documentation on how to update the notebooks properly so that tests will pass?

We should probably also have some contributor documentation on how to update the notebooks properly so that tests will pass?

True, I'll add a section. A link to https://nbviewer.jupyter.org/github/computationalmodelling/nbval/blob/master/docs/source/index.ipynb covers most of it, plus mentioning the %precision magic.

/azp run libertem.libertem-data

Awesome, merging!

🚀


[SSoC 2.0] Website Ready

Issue Number - 489
Close issue #489

https://github.com/Vikash-8090-Yadav/Future.WebNet/assets/114330097/dafb3cf3-d64d-4ccf-9c33-f58d24f3a1e0

@Vikash-8090-Yadav @shubhisingh184 sir, please review this pull request

@Avdhesh-Varshney Is your project under any folder? If not then, move it to the folder according to the contributions guidelines.

@shubhisingh184 ma'am, i have created it as a frontend website for the future.webnet projects for deploying and showcase them.


need to map descriptive md fields to pbcore doc

Complete the mapping and add the fields to our PBCore map.

I think this is done @ c29ff98 . Maybe needs some cleanup/verification by other eyes?


fix: Update PTL import

What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Changelog

Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"
Pre checks:

[ ] Make sure you read and followed Contributor guidelines
[ ] Did you write any new necessary tests?
[ ] Did you add or update any necessary documentation? Make sure to also update the NeMo Framework User Guide which contains the tutorials

Checklist when contributing a new algorithm

[ ] Does the trainer resume and restore model state all states?
[ ] Does the trainer support all parallelism techniques(PP, TP, DP)?
[ ] Does the trainer support max_steps=-1 and validation?
[ ] Does the trainer only call APIs defined in alignable_interface.py?
[ ] Does the trainer have proper logging?

Additional Information

Related to # (issue)

Merging even though presubmit fails b/c internal CI passes and is blocked by this change


can't run neural art end2end ?

I copy end2end/*.py to neural-style folder, fix some path in py, and run boost_train.py, still error like that:
zp@ubuntu:~/develop/mxnet/example/neural-style$ python boost_train.py
Traceback (most recent call last):
  File "boost_train.py", line 23, in <module>
    style_mod = basic.get_style_module("style", dshape, ctx, vgg_params)
  File "/home/zp/develop/mxnet/example/neural-style/basic.py", line 68, in get_style_module
    style, content = vgg.get_vgg_symbol(prefix)
AttributeError: 'module' object has no attribute 'get_vgg_symbol'

it seems model_vgg19.py not updated?  how to run end2end?

sorry for this. The vgg is https://github.com/dmlc/mxnet/blob/master/example/neural-style/model_vgg19.py
I will make a refactor of code after multi-gpu version is done.

Sorry yes I forget to commit it. I will commit it soon

Fixed in https://github.com/dmlc/mxnet/pull/2502

the new model is ok.
but i still don't know how to run the example, it seems need some parmeters?
could you give the example command to run it?
zp@ubuntu:~/develop/mxnet/example/neural-style/end_to_end$ python boost_train.py
Unknown params: target_gram_3, init with 0
Unknown params: target_gram_2, init with 0
Unknown params: target_gram_1, init with 0
Unknown params: target_gram_0, init with 0
Unknown params: target_gram_4, init with 0
Unknown params: target_content, init with 0
Traceback (most recent call last):
  File "boost_train.py", line 34, in <module>
    loss.set_params(extra_args, {}, True, True)
TypeError: set_params() takes exactly 3 arguments (5 given)

The command is correct, I think you need to pull newest mxnet. If your set
params function is different to
https://github.com/dmlc/mxnet/blob/master/python/mxnet/module/base_module.py#L455
It means you are not using newest mxnet
On Wed, Jun 22, 2016 at 00:27 Zepan<EMAIL_ADDRESS>wrote:

the new model is ok.
but i still don't know how to run the example, it seems need some
parmeters?
could you give the example command to run it?
zp@ubuntu:~/develop/mxnet/example/neural-style/end_to_end$ python boost_train.py
Unknown params: target_gram_3, init with 0
Unknown params: target_gram_2, init with 0
Unknown params: target_gram_1, init with 0
Unknown params: target_gram_0, init with 0
Unknown params: target_gram_4, init with 0
Unknown params: target_content, init with 0
Traceback (most recent call last):
File "boost_train.py", line 34, in
loss.set_params(extra_args, {}, True, True)
TypeError: set_params() takes exactly 3 arguments (5 given)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dmlc/mxnet/issues/2501#issuecomment-227664584, or mute
the thread
https://github.com/notifications/unsubscribe/ABM13nEoKQOYYqjsr3G9JNxOSwJPt4Tlks5qOOP9gaJpZM4I7c2I
.

--
Sent from mobile phone

it is same, i had pull it this noon.  maybe there are some hack you forget commit?

Maybe. Sorry for that I will double check it again tomorrow to make sure
everything is in order.
On Wed, Jun 22, 2016 at 00:39 Zepan<EMAIL_ADDRESS>wrote:

it is same, i had pull it this noon. maybe there are some hack you forget
commit?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dmlc/mxnet/issues/2501#issuecomment-227666713, or mute
the thread
https://github.com/notifications/unsubscribe/ABM13oHUFB8ifOLCVyw07HHTZr_B4nBRks5qOOangaJpZM4I7c2I
.

--
Sent from mobile phone

I also have troubles running the end-to-end algo. I'm new to mxnet, so I'm not sure how to fix it, this is the output:

MPLBACKEND=Agg USE_CUDNN=0 python boost_inference.py
libdc1394 error: Failed to initialize libdc1394
[08:09:44] /root/side-projects/test_install/mxnet/dmlc-core/include/dmlc/logging.h:235: [08:09:44] src/operator/./convolution-inl.h:279: Check failed: (param_.workspace) >= (required_size)
Minimum workspace size:<PHONE_NUMBER> Bytes
Given: 536870912 Bytes
[08:09:44] /root/side-projects/test_install/mxnet/dmlc-core/include/dmlc/logging.h:235: [08:09:44] src/engine/./threaded_engine.h:306: [08:09:44] src/operator/./convolution-inl.h:279: Check failed: (param_.workspace) >= (required_size)
Minimum workspace size:<PHONE_NUMBER> Bytes
Given: 536870912 Bytes
An fatal error occurred in asynchronous engine operation. If you do not know what caused this error, you can try set environment variable MXNET_ENGINE_TYPE to NaiveEngine and run with debugger (i.e. gdb). This will force all operations to be synchronous and backtrace will give you the series of calls that lead to this error. Remember to set MXNET_ENGINE_TYPE back to empty after debugging.
terminate called after throwing an instance of 'dmlc::Error'
what():  [08:09:44] src/engine/./threaded_engine.h:306: [08:09:44] src/operator/./convolution-inl.h:279: Check failed: (param_.workspace) >= (required_size)
Minimum workspace size:<PHONE_NUMBER> Bytes
Given: 536870912 Bytes
An fatal error occurred in asynchronous engine operation. If you do not know what caused this error, you can try set environment variable MXNET_ENGINE_TYPE to NaiveEngine and run with debugger (i.e. gdb). This will force all operations to be synchronous and backtrace will give you the series of calls that lead to this error. Remember to set MXNET_ENGINE_TYPE back to empty after debugging.
Aborted

I tried increasing the workspace in the model_vgg19 file to 2048, however this didn't help. Any ideas? Is it possible to use cudnn to get around this problem? How can I run the modell with cudnn?

The out of memory may caused because your input is too large. Current model
is experimental and I didn't do any optimization on memory. I will do a
refactor in next week.
On Sat, Jun 25, 2016 at 01:26 George Stoyanov<EMAIL_ADDRESS>wrote:

I also have troubles running the end-to-end algo. I'm new to mxnet, so I'm
not sure how to fix it, this is the output:
MPLBACKEND=Agg USE_CUDNN=0 python boost_inference.py
libdc1394 error: Failed to initialize libdc1394
[08:09:44]
/root/side-projects/test_install/mxnet/dmlc-core/include/dmlc/logging.h:235:
[08:09:44] src/operator/./convolution-inl.h:279: Check failed:
(param_.workspace) >= (required_size)
Minimum workspace size:<PHONE_NUMBER> Bytes
Given: 536870912 Bytes
[08:09:44]
/root/side-projects/test_install/mxnet/dmlc-core/include/dmlc/logging.h:235:
[08:09:44] src/engine/./threaded_engine.h:306: [08:09:44]
src/operator/./convolution-inl.h:279: Check failed: (param_.workspace) >=
(required_size)
Minimum workspace size:<PHONE_NUMBER> Bytes
Given: 536870912 Bytes
An fatal error occurred in asynchronous engine operation. If you do not
know what caused this error, you can try set environment variable
MXNET_ENGINE_TYPE to NaiveEngine and run with debugger (i.e. gdb). This
will force all operations to be synchronous and backtrace will give you the
series of calls that lead to this error. Remember to set MXNET_ENGINE_TYPE
back to empty after debugging.
terminate called after throwing an instance of 'dmlc::Error'
what(): [08:09:44] src/engine/./threaded_engine.h:306: [08:09:44]
src/operator/./convolution-inl.h:279: Check failed: (param_.workspace) >=
(required_size)
Minimum workspace size:<PHONE_NUMBER> Bytes
Given: 536870912 Bytes
An fatal error occurred in asynchronous engine operation. If you do not
know what caused this error, you can try set environment variable
MXNET_ENGINE_TYPE to NaiveEngine and run with debugger (i.e. gdb). This
will force all operations to be synchronous and backtrace will give you the
series of calls that lead to this error. Remember to set MXNET_ENGINE_TYPE
back to empty after debugging.
Aborted
I tried increasing the workspace in the model_vgg19 file to 2048, however
this didn't help. Any ideas? Is it possible to use cudnn to get around this
problem? How can I run the modell with cudnn?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dmlc/mxnet/issues/2501#issuecomment-228523170, or mute
the thread
https://github.com/notifications/unsubscribe/ABM13mDCgXsSXs2SfmYb6yDZFGRoTdjNks5qPOYYgaJpZM4I7c2I
.

--
Sent from mobile phone

I also thought it might be because of the input, though I believe I'm currently using 640x480. What size would you recommend?

I try to run boost_train.py, still get error like this:
Traceback (most recent call last):
File "D:\UI MAGISTER FASILKOM\KULIAH\MXNET\mxnet-master-20161013\example\neural-style\end_to_end\boost_train.py", line 51, in
gens = [gen_v4.get_module("g0", dshape, ctx),
File "D:\UI MAGISTER FASILKOM\KULIAH\MXNET\mxnet-master-20161013\example\neural-style\end_to_end\gen_v4.py", line 82, in get_module
mod.init_params(initializer=mx.init.Xavier(magnitude=2.))
File "C:\Python27\lib\site-packages\mxnet-0.7.0-py2.7.egg\mxnet\module\module.py", line 190, in init_params
_impl(name, arr, arg_params)
File "C:\Python27\lib\site-packages\mxnet-0.7.0-py2.7.egg\mxnet\module\module.py", line 187, in _impl
initializer(name, arr)
File "C:\Python27\lib\site-packages\mxnet-0.7.0-py2.7.egg\mxnet\initializer.py", line 44, in call
self._init_weight(name, arr)
File "C:\Python27\lib\site-packages\mxnet-0.7.0-py2.7.egg\mxnet\initializer.py", line 266, in _init_weight
random.uniform(-scale, scale, out=arr)
File "C:\Python27\lib\site-packages\mxnet-0.7.0-py2.7.egg\mxnet\random.py", line 42, in uniform
return _internal._sample_uniform(low=low, high=high, shape=out.shape, out=out)
AttributeError: 'module' object has no attribute '_sample_uniform'
I'm new to mxnet, so I'm not sure how to fix it. Any ideas?

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!


yield from loop.run_in_executor(...) results in headers not set exception

I have the following Router object:
from asyncio import events
from concurrent.futures import ThreadPoolExecutor

from pulsar.apps.wsgi import Router, route

pool = ThreadPoolExecutor()

class GithubWebhooks(Router):
    def post(self, request):
        request.response.status_code = 200

        return request.response

    @route(rule='/push', method='POST')
    def push(self, request):
        loop = events.get_event_loop()
        body_data = yield from loop.run_in_executor(pool, request.body_data)

        return request.response

When I post something to /push I get the following exception:
00:53:56 [p=4424, t=140280307545856, CRITICAL, pulsar.wsgi] Unhandled exception during HTTP response @ POST "/push".

pulsar.cache={'app_handler': /push, 'mixins': {}, 'cfg': <pulsar.utils.config.Config object at 0x7f95878d6518>, 'content_types': ContentAccept([('application/json', 1)]), 'response': WsgiResponse(500 Internal Server Error), 'content_type_options': ('application/json', {}), 'data_and_files': ({'x': 'y'}, None), 'handle_wsgi_error': True, 'urlargs': {}}
SERVER_NAME=localhost
SERVER_SOFTWARE=pulsar/1.0.3
HTTP_CONNECTION=keep-alive
CONTENT_TYPE=application/json
wsgi.multiprocess=True
HTTP_USER_AGENT=HTTPie/0.9.2
wsgi.input=<_io.BytesIO object at 0x7f958706e728>
RAW_URI=/push
REMOTE_ADDR=<IP_ADDRESS>
SERVER_PROTOCOL=HTTP/1.1
HTTP_HOST=localhost:8060
HTTP_ACCEPT=application/json
REMOTE_PORT=39534
REQUEST_METHOD=POST
QUERY_STRING=
PATH_INFO=/push
wsgi.errors=<_io.TextIOWrapper name='<stderr>' mode='w' encoding='UTF-8'>
pulsar.connection=server <IP_ADDRESS>:39534 session 1
wsgi.multithread=False
SCRIPT_NAME=
wsgi.run_once=False
SERVER_PORT=8060
CONTENT_LENGTH=10
HTTP_ACCEPT_ENCODING=gzip, deflate
wsgi.url_scheme=http
wsgi.version=(1, 0)
pulsar.cfg=<pulsar.utils.config.Config object at 0x7f95878d6518>
Traceback (most recent call last):
  File "/home/omer/.virtualenvs/drifter/lib/python3.5/site-packages/pulsar/apps/wsgi/server.py", line 488, in _response
    result = self.write(chunk)
  File "/home/omer/.virtualenvs/drifter/lib/python3.5/site-packages/pulsar/apps/wsgi/server.py", line 437, in write
    tosend = self.get_headers()
  File "/home/omer/.virtualenvs/drifter/lib/python3.5/site-packages/pulsar/apps/wsgi/server.py", line 548, in get_headers
    raise HttpException('Headers not set.')
pulsar.utils.exceptions.HttpException: Headers not set.

I might be doing something completely wrong here but there are no examples to how to attach a concurrent.futures Future to the pulsar event loop.
There's no good reason to do this since ujson (which I am using) never releases the GIL but I'm trying to learn what is possible and what isn't with Pulsar.
In any case, the exception is unclear and I'd consider it a bug.

Your push method returns a coroutine (generator) and therefore it does not comply with pulsar asynchronous wsgi specification.
The server thinks you are returning an iterator an therefore it treats at such, in the same way as standard wsgi does.
In python 3.5 we can distinguish between coroutines and generators thanks to the new async keyword. The new syntax will allow for coroutines to be returned (and therefore your example will work), but for now that is not supported.
For now, if you want an async application handler you need to return a future, not a coroutine. In your case you could do:
   @route(rule='/push', method='POST')
    def push(self, request):
        return asyncio.async(self._push(request))

    def _push(self, request):
        body_data = yield from request.body_data
        return request.response

The error message is correct. You returned a generator and did not set the headers. Returning the request.response object as result of the future will be set the headers for you.

I don't see it documented anywhere. Also async is deprecated. It's called ensure_future in 3.5.


Click + UTest: refactoring on default groups/commands + Refactoring logs capture in utests

Description

click: add invoke_without_command on group command
click: use .set_default_command to set default command on cli
utest: refactoring for settings debug mode on logger globally for tests session

Checklist

[x] Tests covering the new functionality have been added
[x] Code builds clean without any errors or warnings
[ ] Documentation has been updated
[ ] Changes have been added to the CHANGELOG.md
[ ] You added yourself to the CONTRIBUTORS.md

Pull Request Test Coverage Report for Build 509707611

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+9.2%) to 94.0%

Totals

Change from base Build 505919551:
9.2%

Covered Lines:
81

Relevant Lines:
84

💛  - Coveralls

Pull Request Test Coverage Report for Build 509707611

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+9.2%) to 94.0%

Totals

Change from base Build 505919551:
9.2%

Covered Lines:
81

Relevant Lines:
84

💛  - Coveralls


Adding unit tests for pyflakes tool plugin.

Codecov Report

Merging #128 into master will increase coverage by 1.53%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #128      +/-   ##
=========================================
+ Coverage   76.06%   77.6%   +1.53%
=========================================
  Files          44      44
  Lines        2152    2152
=========================================
+ Hits         1637    1670      +33
+ Misses        515     482      -33

Impacted Files
Coverage Δ

statick_tool/plugins/tool/pyflakes_tool_plugin.py
100% <0%> (+76.74%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcdc575...704efba. Read the comment docs.


[HUDI-6085] Eliminate cleaning tasks for flink mor table if online async compaciton is disabled

Change Logs
MOR table in upsert scenario,  not need to clean when online async compaction is turned off.

In scenarios with a large number of files and partitions, turning off clean will improve performance

Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@zhuanshenbsj1 @danny0405 is this PR still relevant?

cc @zhuanshenbsj1 I think we can cloase it, because we already have #8505 .


Cannot Reach the test network

Hello I am facing an issue - I can not reach the test network using tonlib = "0.15"
use tonlib::client::TonClientBuilder;
use tonlib::client::TonConnectionParams;
use tonlib::config::TESTNET_CONFIG;
use tonlib::client::TonClient;
use tonlib::contract::TonContractFactory;
use tonlib::contract::TonContractInterface;

async fn contract() -> anyhow::Result<()> {
    let client = TonClientBuilder::new()
        .with_connection_params(&TonConnectionParams {
            config: TESTNET_CONFIG.to_string(),
            blockchain_name: None,
            use_callbacks_for_network: false,
            ignore_cache: false,
            keystore_dir: None,
            notification_queue_length: 10,
            concurrency_limit: 10,
        })
        .with_pool_size(10)
        .build()
        .await?;

    let contract_factory = TonContractFactory::builder(&client).build().await?;
    let contract =
        contract_factory.get_contract(&"EQCpZMzawIgbus2orvZFlV5p20IrR5LvlsHh7aFLwI94_MyM".parse()?);
    TonClient::set_log_verbosity_level(1);

    let state = contract
        .run_get_method("get_id", &Vec::new())
        .await
        .expect("FAILED");
    println!("{:?}", state);

    Ok(())
}

#[tokio::main]
async fn main() {
    contract().await.unwrap();
}

and i recieve these errors
[ 1][t 1][2024-07-09 00:22:04.711640][adnl-ext-connection.cpp:129][!outconn]	Client got error [PosixError : Connection refused : 61 : Read from [fd:15] has failed]
[ 1][t 1][2024-07-09 00:22:14.713434][adnl-ext-connection.cpp:129][!outconn]	Client got error [PosixError : Connection refused : 61 : Read from [fd:22] has failed]
[ 1][t 1][2024-07-09 00:22:24.713244][adnl-ext-connection.cpp:129][!outconn]	Client got error [PosixError : Connection refused : 61 : Read from [fd:30] has failed]
[ 1][t 7][2024-07-09 00:22:25.918695][adnl-ext-connection.cpp:129][!outconn]	Client got error [PosixError : Connection refused : 61 : Read from [fd:37] has failed]

Am I using the the library right? Thank you!
my Cargo.toml dependecies
[dependencies]
tonlib = "0.15"
anyhow = "1.0"
tokio = { version = "1", features = ["full"] }

@N1ghtStorm  Had same issue, solved by using config from ton website instead of the one bundled with this lib.

Assuming json placed in the project root:

pub const TESTNET_ACTUAL: &str = include_str!("./testnet-global.config.json");
// ...

let client = TonClientBuilder::new()
    .with_connection_params(&TonConnectionParams {
        config: TESTNET_ACTUAL.to_string(),
        blockchain_name: None,
        use_callbacks_for_network: false,
        ignore_cache: true,
        keystore_dir: None,
        notification_queue_length: 1000,
        concurrency_limit: 100,
    })
        .with_pool_size(10)
        .build()
        .await?;