UI support changes

These items block further progress on the UI. I'm merging #7056 so we can make progress, but it is in general not yet safe to accept UI changes because we are missing various supporting functionality: we don't have enough automated checks in place. Please copy me (@lavalamp) on all UI changes.
P0 items: (I'm unlikely to accept UI changes that aren't working towards fixing one of these issues)

[ ] Travis/shippable to run the karma tests.
[ ] Travis/shippable to run the protractor tests.
[ ] Test to verify that go bin data matches the files output by npm install; npm start (i.e., hack/build-ui.sh has been run)
[ ] Test to verify that npm install; npm start has been correctly run (the packaged js/css/html files have been assembled from source)
[ ] www/README.md needs major changes:
[ ] Make it clear how to build files for inclusion in apiserver binary.
[ ] Make it clear how to run in standalone mode.
[ ] Make it clear that these are two distinct modes.
[ ] Either remove all mention of kubectl, or make it clear that there's a third operational mode, where kubectl proxies your cluster's master, and you run the UI locally pointed at that proxy.
[ ] work item: make development.json auto-generated from your .kube/config file; actually provide a separate command for generating the files for inclusion in apiserver that doesn't use development.json.
[ ] Provide more detailed installation instructions.

P1 items:

[ ] UI to be served from a pod, not from apiserver.

Also please copy me @preillyme on all UI changes as well.

Likewise please copy @jackgr.

I've made a partial pass at updating the README it still needs a bit more work.

I'll be taking a look at some of the P0's (I'm a friend of @preillyme)

Thanks @djvirgen

@lavalamp I'm not sure what the best way to handle the shippable configuration will be. Based on what I was reading last night it didn't look like you can nest configurations? But we need something like: https://github.com/lucassus/angular-seed/blob/master/shippable.yml for the Web UI. I'm curious what are your thoughts? Also @djvirgen do you have any experience with this?

@preillyme I'm not sure, but you can try to modify our existing .yml file to install both go and ui stuff, and send a (WIP) PR to see what shippable does with it.

Okay @lavalamp seems like a plan.

@preillyme what configurations would you like to nest? xvfb?

@avinci yeah basically need to be able to test the Web UI https://github.com/GoogleCloudPlatform/kubernetes/tree/master/www and the main Go based Kubernetes code separately.

I've been working on getting everything working in a Docker container for testing the WebUI.
Just wanted to share my Docker container and share some notes on using it.
wget https://kismatic.io/kubernetes_webui.tar.gz
    SHA1(kubernetes_webui.tar.gz)= 47018c936ee69b9d4636df2b272ceee7f05b8c2c
gunzip kubernetes_webui.tar.gz
docker load < kubernetes_webui.tar
docker run -t -i kubernetes:webui /bin/bash
# Xvfb :99 -screen 0 1024x768x16 &> xvfb.log &
# DISPLAY=:99.0
# export DISPLAY
# google-chrome
# ^C
# bg
# su -l kubernetes
$ cd kubernetes/www/master/
$ npm start
^C
$ karma start karma.conf.js

@preillyme, you can do this by starting a kube service inside the container on a port and then starting your protractor service to test it on an another.
We have a sample project that does this using node and selenium. server.js starts up a web server, in this case can be a kube master and then its using nightwatch to run tests on it.
https://github.com/shippableSamples/sample_node_selenium
does this help?
We are also working on a kube based build clusters which will allow doing this cross containers in the next 3-4 weeks which should make it even easier.
I am traveling and might be delayed in responding. Can we do a quick 10 minute hangout so that I understand this better if I am off base here.

Additional issues:

overall unintuitive and mostly broken behavior
focus doesn't change with mouse movement in menu
option dots don't do anything
clicking dashboard title doesn't do anything, either
clicking on Kubernetes produces 404

And the starting URL isn't discoverable.

@bgrant0607 I am working on cleaning up these issues and updating documentation.

These issues impact the Graph tab, which was developed concurrently with the chrome and Dashboard tab, and will be submitted shortly. It follows the model that the UI can be extended by adding tabs. However, this model only works well if the chrome is stable, usable and discoverable.

@bcbroussard Thanks. In what timeframe? We're pushing hard towards our 1.0 release candidate.

@bgrant0607: You can get to the WebUI at the following url: /static/app/#/
I typically test locally with the following flow:
git clone git@github.com:GoogleCloudPlatform/kubernetes.git
cd kubernetes
hack/local-up-cluster.sh
then navigating to: http://<IP_ADDRESS>:8080/static/app/#/

Am I missing something in your comment?

After discussion with @preillyme, it turns out that most, if not all, of these issues were created by a late commit (https://github.com/kubernetes-ui/kubernetes-ui-private/commit/3b46bc4cd74b9088c08e7c102abcd658edd2d597) from one of our team members, which did a large refactoring and removed some key pieces that should not have been removed. All of the functionality was working when we demo'ed at Galvanize on 2/25. @preillyme is working on restoring the broken functionality.

/static/app/#/ is not very obvious nor intuitive, and listing the top-level path, /static, in the list of supported paths isn't sufficient to find it. We need a simple, intuitive top-level path, such as /www and/or /ui, to at least redirect to the GUI location. A redirect could also work in the case that the UI ran as a separate pod.

@bgrant0607 I agree with you completely that the top level path is not obvious nor intuitive. I'm happy to have it changed to something a bit more discoverable. It's mostly an artifact of the original Web UI and the fact that it's using AngularJS for the routing.

@lavalamp, @jackgr Travis was updated to support Karma in #7880. PTAL

@jackgr I've addressed the breadcrumbs issue in https://github.com/GoogleCloudPlatform/kubernetes/pull/8332

These issues impact the Graph tab, which was developed concurrently with the chrome and Dashboard tab, and will be submitted shortly. It follows the model that the UI can be extended by adding tabs. However, this model only works well if the chrome is stable, usable and discoverable.

Is the graph component going to be merged into this repo?
I had several attempts to add the graph and see its visualizatoins by following the several readme files in this repo (like the one under www, for example), but no luck so far.

@lavalamp : Looking at the original list above, there are two items that might want to be done differently...

Test to verify that go bin data matches the files output by npm install; npm start (i.e., hack/build-ui.sh has been run)
Test to verify that npm install; npm start has been correctly run (the packaged js/css/html files have been assembled from source)

The concern is totally legitimate - i.e., make sure we have current ui bits. However, writing those tests would be hard because neither of the assertions is easy to prove.
Another way to address the concern is to generate the ui bits during a build-cross.sh, instead of checking them into the repository.
So, that begs the question of how to generate the ui bits. The approach i'm considering is to:

Provide a container with npm, bower, gulp and friends installed (thanks, @preillyme for that suggestion).
Make build-ui.sh run npm install and gulp in the container with a gulp task that doesn't watch, since that would hang the build, with the environment flag set to production to cause minification, obfuscation, etc., so that running build-ui.sh generates the gulp output and then runs the go binary data file compiler.
make build-cross.sh call build-ui.sh.
remove the build output from git and add the app directory to .gitignore.

Would you consider that a reasonable replacement for the two tests in question?

@jackgr Yes, that's fine, as long as hack/build-go.sh continues to work (i.e., you can build the repo outside of the container, too-- this is important for tools that need to build); in practice this may mean that you keep a dummy UI go file checked in which is replaced by the real UI when you do the "real" release-building process.

@abonas Yes, the Graph tab will be merged into this repo. Goal is to have it in by 0.18.

@abonas PR #8716 has been submitted for the graph tab.

Thanks for letting me know
On May 23, 2015 2:01 AM, "Jack Greenfield"<EMAIL_ADDRESS>wrote:

@abonas https://github.com/abonas PR #8716
https://github.com/GoogleCloudPlatform/kubernetes/pull/8716 has been
submitted for the graph tab.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/7122#issuecomment-104795191
.

UI is gone.


Single click on "Fork" to redirect to personal fork

Hi,
if I remember correctly, I could once in an upstream repository click on "fork" and would then be redirected to my personal fork.
This does not work anymore. I am not sure when this exactly "broke" for me. I looked through the issues and found "Drop forked-to feature #5745", which could be the feature I was using.
Is there still the possibility with a one-click action, to get to my personal fork? Now I've to click on "Fork" and then select the only listed fork (my fork).
Not a big deal, but I wanted to ask in case there is a solution to save me one click 😉

Indeed we used to have a one-click button when a fork was detected. I suppose I wouldn't be opposed to restoring that button if a single fork was detected:
https://github.com/refined-github/refined-github/blob/10d57548f67c34f26e4d44e83007ef9f24b673f9/source/features/forked-to.tsx#L55-L61
Possible feature:

on fork menu opening, store fork if there's only one, clear cache if there's more than one
if there's a stored fork, add button on load

I can't provide a PR for that, as I am not familiar with typescript. If you or someone else implements this, that would be cool.

Not worth the complexity to save 1 second. Just open the dropdown:


APEXMALHAR-2154 Update the Kafka Input Operator to use CheckpointNotificationListener

Should this be done for every operator in Malhar?


CIF-1039 - Revisit the MiniCart and Checkout implementation (Part 2)

Description
This is a follow up PR to https://github.com/adobe/aem-core-cif-components/pull/119. I will update this PR against master once https://github.com/adobe/aem-core-cif-components/pull/119 was merged.

Added state management for checkout with CheckoutProvider.

State management for cart was refactored to separate both more easily.

Added error handling for cart and checkout.
Improve asynchronous loading behaviour so that the loading state now waits for any action to finish to allow a smooth user experience (No more sudden changes in the cart).
Fix bug with button styling in checkout forms.

How Has This Been Tested?
Tested locally, existing unit tests were adapted.
Verification

Test the complete checkout workflow. Make sure that after a complete checkout the cart is reset and you can still add / remove items to / from the cart.
This PR is mostly refactoring, so it should not impact the cart functionality in any way in comparison to before.
Make sure the buttons in the checkout have a proper styling.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes and the overall coverage did not decrease.
[X] All unit tests pass on CircleCi.
[X] I ran all tests locally and they pass.

Codecov Report

Merging #122 into issue/CIF-1039 will decrease coverage by 0.52%.
The diff coverage is 20.88%.

@@                 Coverage Diff                  @@
##             issue/CIF-1039     #122      +/-   ##
====================================================
- Coverage             55.32%   54.79%   -0.53%
  Complexity              341      341
====================================================
  Files                   105      106       +1
  Lines                  2950     2971      +21
  Branches                473      483      +10
====================================================
- Hits                   1632     1628       -4
- Misses                 1246     1271      +25
  Partials                 72       72

Flag
Coverage Δ
Complexity Δ

#jest
32.23% <20.88%> (-0.67%)
0 <0> (ø)

#karma
93.61% <ø> (ø)
0 <ø> (ø)
:arrow_down:

#unittests
79.54% <ø> (ø)
341 <ø> (ø)
:arrow_down:

Impacted Files
Coverage Δ
Complexity Δ

...script/minicart/src/components/Minicart/product.js
78.94% <ø> (+1.67%)
0 <0> (ø)
:arrow_down:

...ascript/minicart/src/components/Minicart/header.js
100% <ø> (ø)
0 <0> (ø)
:arrow_down:

...in/javascript/minicart/src/components/Mask/mask.js
71.42% <ø> (ø)
0 <0> (ø)
:arrow_down:

...ascript/minicart/src/components/Minicart/footer.js
20% <ø> (ø)
0 <0> (ø)
:arrow_down:

...pt/minicart/src/components/Minicart/productList.js
100% <ø> (ø)
0 <0> (ø)
:arrow_down:

...icart/src/components/Minicart/emptyMinicartBody.js
60% <ø> (ø)
0 <0> (ø)
:arrow_down:

...pt/minicart/src/components/Minicart/cartContext.js
22.22% <0%> (ø)
0 <0> (?)

...t/minicart/src/components/Checkout/editableForm.js
4% <0%> (-0.17%)
0 <0> (ø)

...pt/minicart/src/components/Checkout/addressForm.js
23.52% <0%> (-1.48%)
0 <0> (ø)

...rt/src/components/Checkout/paymentMethodSummary.js
28.57% <0%> (+10.38%)
0 <0> (ø)
:arrow_down:

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35d6f28...45e8070. Read the comment docs.


Fix doc comment of client.watch()

The exception raised when the timeout expires is etcd.EtcdWatchTimedOut

Coverage remained the same at 88.4% when pulling d0cd0a94dafbecd95b3c2f1e2d7f327b99e54fe5 on the-gigi:master into d2638cc34c633c51239b83c9da3d3114fe9de88b on jplana:master.

Coverage remained the same at 88.4% when pulling d0cd0a94dafbecd95b3c2f1e2d7f327b99e54fe5 on the-gigi:master into d2638cc34c633c51239b83c9da3d3114fe9de88b on jplana:master.


feat: added singleton pattern in python3 and added .gitignore

Needed to change the git config user details for better github integration. Previous commits had user.email set to my office mail.

No issues...


[local_auth:1.1.4] popup for user with no fingerprint is registered not shown

With old version of local_auth(0.6.2+2) when user didn't have any fingerprint registered next popup was shown:

After update to flutter 2 and local_auth:1.1.4(same with other version of local_auth:1.0.0 and greater) instead of this popup exception is thrown:
E/flutter ( 7662): [ERROR:flutter/lib/ui/ui_dart_state.cc(186)] Unhandled Exception:
PlatformException(NotAvailable, Required security features not enabled, null, null)
E/flutter ( 7662): #0      BioAuth.getAuthData (package:mobile/bio_auth.dart:49:9)

Looks like LocalAuthPlugin.authenticate now performs biometrics availability checks before calling authHelper.authenticate() and just exists function. But error dialog is shown in AuthenticationHelper.onAuthenticationError which now is never reached in case when there no fingerprints registered

Hi @AdamZLevy
This is a known issue, biometrics registered or not, error is thrown
Closing as duplicate of https://github.com/flutter/flutter/issues/80259


Fix output flag to work with spago

spago passes the output flag to a backend as --output.

I also changed the flag for bundle-app just to be consistent.


Add unified_mode to resources

Description
Just added unified_mode true to resolve CHEF-33 deprecation
Check List

[x] All tests pass. See TESTING.md for details.
[x] New functionality includes testing. (Covered with cookstyle tests)

Hello @bastianschwarz,
It's always good to see a contribution. Thank you for yours.
I'm not a maintainer for this project but I've done a few of these updates.
Could you change the chef_version supported in metadata to >= 15.3?
Also a comment in the Unreleased section of the changelog would probably be appreciated.
Regards, Mark

I guess the delivery action fails because actionshub/chef-delivery should now use @main but it seems to be behind master? Not sure if I should change this in this PR ... probably not?

@bastianschwarz I get the same messages about @main in projects I contribute to. I don't think that has anything to do with the failure.  I hope @xorima or @ramereth can explain the delivery issue. I don't think your PR is responsible for that issue.

@bastianschwarz can you please rebase again? I think that will fix the remaining issue.

So ... not sure what to make of the build error since it works in some instances? Also the actual error is not in the logs since it seems that the command just didn't return 0.
I don't think this is related to unified_mode
How to proceed with this?

Add some temporary debug code into get the stdout/stderr for the command to see why it's failing would be my first port of call. Shouldn't be too diffcult to add a Chef::Log.warn to the stdout and stderr properties of the shellout object in the library that does the work.


KAFKA-10395: relax output topic check in TTD to work with dynamic routing

I went through all 5 stages of grief in thinking about what to do here and decided the best thing was to just relax the check after all. Hopefully users who find their output topic unexpectedly empty due to a typo in the topic name will be able to figure it out quickly from the warning we now log instead.
Not sure how rampant the problem of output-topic-typos is to begin with...

@cadonna @guozhangwang

Failure seem related

Might it be worth to cherry-pick to 2.6 ?

@mjsax Be my guest 🙂

Cherry-picked to 2.6 branch.


Teva 559 sign in issue messages

Shows the agreed error message when the feature flag is set.

[x] Product to sign off before release.

In Isabelle's absence, Chris has signed this off. @cesidio is working on getting the environment variable on to the various environments.


Include low-res satellite image of wider geographical context

Some of @jacobbieker's models include a low-res satellite image of a wider geo region.  And this trick is used in the MetNet paper, too.  And a wider view of the satellite imagery is probably necessary for forecasting PV power for entire GSP regions, too.
@jacobbieker, how large are your 'large' crops?

They are around 768km in physical size, 256x256 with 3km pixels for a center prediction area of between 48 and 96km square, depending on the model.

For context, MeNet uses 1024km squares to predict the center 64x64km

Cool, thank you!  And, do you down-sample the 'large crop' as a pre-processing step?  Or do you give the full-res 'large crop' to a CNN front-end, and let the CNN down-sample the image?

I do it in the CNN, here: https://github.com/openclimatefix/metnet/blob/main/metnet/layers/Preprocessor.py You could do it beforehand and it'd probably save some computation, but this meant I didn't need to change the inputs vs other models. The preprocessing stage doesn't have any CNN parts to it, just pooling and space2depth layers. There is a CNN downsampler though which then works on the downscaled imagery: https://github.com/openclimatefix/metnet/blob/75e743423d84b1661296bafa83e9188a26ff26f8/metnet/metnet.py#L10

OK, cool, thanks!  In which case - instead of having separate, pre-processed 'centre crop' and 'large crop' features in each example -  maybe we should just always have the satellite imagery as be a large crop (~768km x 768km) and let the model decide what to do with the image?

Yeah! I think that's a good way of doing it, gives us a lot of flexibility then


shell: builtins vs. core API

Context
The shell introduces a new concept of builtins (.help, .login etc). Builtins can be contextually in a pipeline (for example .container | from alpine | .doc) which makes them very useful.
Problem
The relationship between shell builtins and core API is unclear: some builtins map directly to core API calls, others don't.
This creates the risk of a "shadow API". We should clarify the relationship that we want.
Solution
A solution is still being discussed. Please participate below.
Initial thoughts from @sipsma, on the possibility of builtins becoming a shadow API:

my main thought is that it would be better to avoid too much of that since, all else being equal, it's better to have functionality in the core API. Then it's available to e.g. module function implementations too (which use the various SDKs directly and don't go through dagger shell)

However, for functionality that absolutely only ever makes sense in the context of dagger shell, then it should be fine. So I guess that raises the question what sort of builtins you are thinking about specifically here

Initial thoughts from @shykes:

Empirically, when I'm tempted to add a builtin today, it's for one of the following reasons:

It involves accessing the client context (filesystem; env variables; commands; network) and therefore feels "weird and special" - stuff like Directory.export, Service.up, etc. It's part of the Dagger API today, but it's a special and weird part. So moving it out can be tempting.
It's "middleware" - a cross-cutting action that I want to inject into any type. For example .doc. I can't just add a doc function to every single type - it wouldn't belong there. It would require adding a new dimension to the schema.
It's faster to iterate. Sometimes I want to add polish on an existing call. Or try a new syntax for doing the same thing.  I feel a freedom and a velocity adding builtins to the shell, that I just don't know how to get when contributing to the core API. There's the complexity of the code; the overhead of building and testing; the bikeshedding and having to argue with lots of people; the concerns about breaking changes; etc. Below a certain size of change, I won't even bother with the overhead.
The API got bloated. In the early days we carefully bikeshedded every detail of the API, with the assumption that it was user-facing. Over time we started treating it more like a hidden implementation detail. As a result, we can't just expose the core API as-is as shell builtins. It's too bloated. So no matter what, some hiding has to happen. Then from there, it's a slippery slope. It used to be the API itself was treated like a self-sufficient UX domain - you designed it end-to-end so that interacting with it would make sense. Now that it's not the case, I kind of need a another self-sufficient UX domain.

One analogy that seems potentially useful here is between systems shells like bash and the Linux kernel:

dagger shell is obviously bash in that it's a userspace wrapper around low level syscalls
the engine + core API are the kernel and syscalls

From that sort of perspective, it makes sense to me that there's going to be cases where it's faster+easier to just "do it in userspace" and add functionality to the shell. But some features either have to be in the engine/core or might be better there because it can be more optimized/used in more use cases/etc.
It also may often make sense to start with something in the shell and then move it to the engine API later once a need for it is proven there.
Not a flawless analogy, but might be a useful framing for thinking about this sort of stuff. Either way I'd say that:

Let's not block shell features for the sake of purity, if it's faster to get going there then let's do it
We can look at putting features in the engine on a case-by-case basis and can also migrate shel features to "engine native" features at a later time if that makes sense

I suspect we'll end up hitting cases like "I can do this cool thing in the shell but not from my module code"; that would be a good time to consider either spinning out the feature to the core engine or perhaps even to a module implementation that's depended on by the shell

I agree with @sipsma, but currently that's cobra commands, not shell builtins. There's currently 3 shell builtins that are proxying cobra commands and these could be in core as much as possible:

.login
.logout
.install
(soon) .uninstall

Each of those is a single line of code that can be removed if they end up in the core API, and they'd still be there since core functions appear as a built-in right now.
The rest is just very shell specific helpers or wrappers:

.config - sets a module's constructor arguments
.doc, .help, and .deps - these can be merged and output a CLI specific --help kind of thing
.load, and .use - they're like calling multiple dagger call with different -m flags, there's also a lot of introspection being loaded into memory at runtime, to compensate for the lack of client bindings.

We're thinking about adding .print, .json, and .list (names not set in stone), but they're also CLI specific helpers.
I any case, for the future, I agree it's best to move things to the core API if it makes sense.
I also think that Query may have too much, but that could just be organized differently. Like engine stuff you place in the Engine object. A login and logout could be placed in a Cloud object. All the typedef stuff could be under a common object too. All the SDK specific stuff could be marked as internal so it doesn't have to be hardcoded in the CLI (current function call, etc). Similar thing with loadXXXFromID, but marked as hidden so we can decide not to show by default but still make it available if accessed directly (or listed unfiltered like with .core in the shell).

This is addressed by #9035 .


Add uncertainty for the traditional (non-Bayesian) models

Suggested by @juanitorduz. Would be good to get measures of uncertainty for the non-Bayesian models. Could use:

https://github.com/scikit-learn-contrib/MAPIE
https://github.com/statsmodels/statsmodels

Statsmodels notes

Using R-style formulas https://www.statsmodels.org/dev/example_formulas.html (also see alternate constructor)
Out of sample prediction: https://www.statsmodels.org/dev/examples/notebooks/generated/predict.html

FYI: We are pushing ahead with the Bayesian causal inference methods. So there are no immediate plans for this. But if someone out there wants to give this a go, then feel free. It is also worth reviewing the Discussion here https://github.com/pymc-labs/CausalPy/discussions/250


CUPS 100% CPU usage

This bug might be related to #5360. I've originally reported the issue at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=841028 . Since we haven't yet received any feedback there we're trying here instead.
Our cups process sits idling at around 100% CPU usage. While some devices may connect to that server for the purpose of printer discovery etc. it's not actually used for printing. We have setup a couple of dummy printers though - none of them being actively used on this specific server. The log doesn't show any obvious signs of errors. I'll post a full log once the problem occurs again with debug logging enabled. We believe that the cause is related to network activity as we were able to reproduce the issue at least once when restarting the CUPS daemon on the workstation mentioned below. The cups daemon will use 100% CPU usage after unspecific amount of time running on the server as long as it isn't restarted.
strace (scrolling through rapidly):
poll([{fd=19, events=POLLIN}], 1, 0)    = 1 ([{fd=19, revents=POLLIN}])
recv(21, "\247", 1, MSG_PEEK)           = 1
poll([{fd=21, events=POLLIN}], 1, 0)    = 1 ([{fd=21, revents=POLLIN}])
epoll_wait(5, [{EPOLLIN, {u32=1468342600, u64=83072721224}}, {EPOLLIN, {u32=1468196936, u64=91662510152}}], 4096, 1000) = 2
recv(19, "\303", 1, MSG_PEEK)           = 1
poll([{fd=19, events=POLLIN}], 1, 0)    = 1 ([{fd=19, revents=POLLIN}])
recv(21, "\247", 1, MSG_PEEK)           = 1
poll([{fd=21, events=POLLIN}], 1, 0)    = 1 ([{fd=21, revents=POLLIN}])
epoll_wait(5, [{EPOLLIN, {u32=1468342600, u64=83072721224}}, {EPOLLIN, {u32=1468196936, u64=91662510152}}], 4096, 1000) = 2

The file descriptors correspond to the following sockets:
cupsd     32123                   root   19u     IPv4           33857634       0t0        TCP iserv.dev2.iserv.eu:ipp->Dogmeat.dev2.iserv.eu:43696 (CLOSE_WAIT)
cupsd     32123                   root   21u     IPv4           33865820       0t0        TCP iserv.dev2.iserv.eu:ipp->Dogmeat.dev2.iserv.eu:43706 (CLOSE_WAIT)

iserv.dev2.iserv.eu being the server CUPS is installed on and Dogmeat.dev2.iserv.eu being a workstation on our network.
When inspecting network traffic we don't see any traffic related to this connection.
We're currently running:
cups				2.2.1-8+deb9u1
cups-bsd			2.2.1-8+deb9u1
cups-client			2.2.1-8+deb9u1
cups-common			2.2.1-8+deb9u1
cups-core-drivers		2.2.1-8+deb9u1
cups-daemon			2.2.1-8+deb9u1
cups-filters			1.20.3-1+b1
cups-filters-core-drivers	1.20.3-1+b1
cups-ipp-utils			2.2.1-8+deb9u1
cups-pdf			2.6.1-22
cups-ppdc			2.2.1-8+deb9u1
cups-server-common		2.2.1-8+deb9u1
cupsddk				1.5.3-5+deb7u6
The versions refer to Debian package versions as we're on Debian Stretch (Yes Stretch, not Buster. Since the original answer suggested a newer version might fix our issue). Stretch's default versions are affected by the same issue.
I'll provide more information as needed. I'm no expert when it comes to network printing, so bear with me.

Sadly the error log doesn't provide much more insight:
[...] D [03/Aug/2018:15:05:54 +0200] [Client 81] Read: status=100 D [03/Aug/2018:15:05:54 +0200] [Client 59] Read: status=100 D [03/Aug/2018:15:05:54 +0200] [Client 62] Read: status=100 D [03/Aug/2018:15:05:54 +0200] [Client 81] Read: status=100 D [03/Aug/2018:15:05:54 +0200] [Client 59] Read: status=100 D [03/Aug/2018:15:05:54 +0200] [Client 62] Read: status=100 D [03/Aug/2018:15:05:54 +0200] [Client 81] Read: status=100 I [03/Aug/2018:15:05:54 +0200] Scheduler shutting down normally. D [03/Aug/2018:15:05:54 +0200] Discarding unused server-stopped event... D [03/Aug/2018:15:05:54 +0200] [Client 59] Closing connection. D [03/Aug/2018:15:05:54 +0200] cupsdSetBusyState: newbusy="Not busy", busy="Not busy" D [03/Aug/2018:15:05:54 +0200] [Client 62] Closing connection. D [03/Aug/2018:15:05:54 +0200] cupsdSetBusyState: newbusy="Not busy", busy="Not busy" D [03/Aug/2018:15:05:54 +0200] [Client 81] Closing connection. D [03/Aug/2018:15:05:54 +0200] cupsdSetBusyState: newbusy="Not busy", busy="Not busy" D [03/Aug/2018:15:05:54 +0200] Creating keep-alive file "/var/cache/cups/org.cups.cupsd". I [03/Aug/2018:15:05:54 +0200] Saving job.cache... D [03/Aug/2018:15:05:54 +0200] cupsdStopSelect()

Please attach your cupsd.conf file.

https://gist.github.com/KimBrodowski/b0db8ddd5060f216d35acc1a9d79c7ce
Thank you for looking into this.

OK, try adding "Allow @LOCAL" to the <Location /> section.

I've deployed the recommended change above and will monitor the service.

Good morning,
unfortunately this didn't resolve the issue for us:
New strace. same symptoms otherwise.
open("/etc/group", O_RDONLY|O_CLOEXEC)  = 19
lseek(19, 0, SEEK_CUR)                  = 0
fstat(19, {st_mode=S_IFREG|0644, st_size=1848, ...}) = 0
mmap(NULL, 1848, PROT_READ, MAP_SHARED, 19, 0) = 0x7f6b42f75000
lseek(19, 1848, SEEK_SET)               = 1848
munmap(0x7f6b42f75000, 1848)            = 0
close(19)                               = 0
gettimeofday({tv_sec=1536828573, tv_usec=553930}, NULL) = 0
write(6, "D [13/Sep/2018:10:49:33 +0200] ["..., 61) = 61
poll([{fd=15, events=POLLIN}], 1, 0)    = 1 ([{fd=15, revents=POLLIN}])
recvfrom(18, "+", 1, MSG_PEEK, NULL, NULL) = 1
open("/etc/group", O_RDONLY|O_CLOEXEC)  = 19
lseek(19, 0, SEEK_CUR)                  = 0
fstat(19, {st_mode=S_IFREG|0644, st_size=1848, ...}) = 0
mmap(NULL, 1848, PROT_READ, MAP_SHARED, 19, 0) = 0x7f6b42f75000
lseek(19, 1848, SEEK_SET)               = 1848
munmap(0x7f6b42f75000, 1848^Cstrace: Process 4268 detached

Sorry, I'm still not able to reproduce using the stock CUPS sources. I suspect this is being caused by one of their patches to CUPS... :/

CUPS 2.2.9 built from source is also affected. This is NOT a Debian specific bug.

It is possible an other program sends a lots of requests in small time frame, which causes high CPU load in CUPS, f.e. cups-browsed (part of cups-filters project, not cups project) can cause it in certain circumstances - I'm currently working on https://bugzilla.redhat.com/show_bug.cgi?id=1648697 , which causes high load in CUPS, when cups-browsed doesn't manage to update print queue in time.
You can check cups-browsed logs for what's going on there then...

Thank you for your suggestion. However we don't ship cups-browsed, so I'm afraid it can't be the origin. As we don't actually make use of cups much on the server I'm using I doubt it's an external source, but I'll see what I can find.
What surprises me is that cups appears to access /etc/group in one of the previous straces directly, since our user backend is handled by LDAP. I don't think this is related however.

Actually maybe it is. This looks very similar to https://github.com/apple/cups/issues/4901
I bet it's actually the same issue.

This is to confirm this challenge. We’re facing the same challenge on one device.
Steps to reproduce

Before trying to reproduce this challenge, I suggest to reproduce it only on a disposable non-production device. Such as a QEMU virtual machine. Because there is a very high risk that the Debian will slow down. In turn, the boot volume will fill very quickly. In turn, the Debian will crash. In turn, you will not be able to log-in Debian GNOME. In turn, Debian GNOME is not usable. In turn, only Terminal in rescue mode will be available.

Using:

Debian 10 Buster
CUPS 2.2.10
GNOME 3.30.2 with Wayland

Using Terminal/Console, as a user with the Sudo permission, execute this command to change the chmod permissions on this "cups" with recursive
sudo chmod -R "g+w" "/var/log/cups"

Note:

Changing this permission is the primary cause of this challenge
What this command does is it add the "Group" permission to the "cups" folder and all its sub-folders and files
According to CUPS, adding this "Group" permission is insecure

Reboot your device

Using GNOME, open Printers. This error message is display Sorry! The system printing service doesn’t seem to be available. If you do not yet see this error message, try again later. Depending on the available storage on the volume it might need more time. This is the 1st challenge.

Using GNOME "Monitor", search for cupsd -l. Notice that it permanently used 100% of one CPU. This is the 2nd challenge.

Using Terminal/Console, as a user with the Sudo permission, execute this command to see the last 100 lines of the cups "error_log" log file
tail -n 100 "/var/log/cups/error_log"

Note:

This file is likely very large. Up to GB or TB. So I suggest to use this command. Which is able to open very large text file. In comparison Gedit or Nano are not able to do this.

Notice that the "error_log" file contains millions or trillions of those lines below. This is the 3rd challenge.:

W [15/Jul/2015:11:23:03 -0700] Notifier for subscription 911 (dbus://) went away, retrying!
E [15/Jul/2015:11:23:03 -0700] File "/usr/lib/cups/notifier/dbus" has insecure permissions (0100777/uid=0/gid=0).

Notice that this error recorded for a very large amount of time. Using GB or TB of space. The volume fills up very quickly. Depending on the space of your device and hardware, the volume is full within minutes or hours. This is the 4th challenge.

Using Terminal/Console, as a user with the Sudo permission, execute this command to find the available space on the boot volume
df -h

Periodically execute again this df -h command. Notice that the boot volume fill up very quickly.

The expected result is that CUPS would not infinitely fill the volume, then crash Debian. While at the same time CUPS would still report the "insecure permissions" warning to its log.

Suggested Resolution
How about this, before writing this "insecure permissions" warning to the log, how about CUPS would detect if the error was already recently reported, then write it less frequently. For example, maximum once every 5 minutes. Instead of multiple time per seconds. Optionally, a new configuration could be added to CUPS. So that user could customize this frequency to their liking.

This workaround below permanently resolved the challenge for us

Using Terminal, as a user with the Sudo permission, execute this command to activate Sudo for all the following commands
sudo su

Using Terminal, as a user with the Sudo permission, execute this command to set the cups folder OWNER to root for both its folder and files.
chown -R root:root /usr/lib/cups/* && \

Using Terminal, as a user with the Sudo permission, execute this command to set the cups folder PERMISSION to 755 for both its folder and files.
chmod -R 755 /usr/lib/cups/* && \

Using Terminal, as a user with the Sudo permission, execute this command to restart CUPS
/etc/init.d/cups restart

Using Terminal, as a user with the Sudo permission, execute this command to TBD
ÀD

Using Terminal, as a user with the Sudo permission, execute this command to permanently erase the present CUPS log file
sudo rm -rf /var/log/cups/error_log

Note: In the future, after a reboot, this file will automatically be recreated by CUPS. But a smaller file.

Using Terminal, as a user with the Sudo permission, execute this command to TBD
ÀD

Using Terminal, as a user with the Sudo permission, execute this command to TBD
ÀD

This workaround below permanently resolved the challenge for us

Using:

Debian 10 Buster
CUPS 2.2.10
GNOME 3.30.2 with Wayland

Using Terminal, as a user with the Sudo permission, execute this command to activate Sudo for all the following commands
sudo su

Using Terminal, as a user with the Sudo permission, execute this command to set the cups folder OWNER to root for both its folder and files.
chown -R root:root /usr/lib/cups/* && \

Using Terminal, as a user with the Sudo permission, execute this command to set the cups folder PERMISSION to 755 for both its folder and files.
chmod -R 755 /usr/lib/cups/* && \

Using Terminal, as a user with the Sudo permission, execute this command to restart CUPS
/etc/init.d/cups restart

Using Terminal, as a user with the Sudo permission, execute this command to permanently erase the present CUPS "error_log" file
sudo rm -rf /var/log/cups/error_log

Notes:

This "error_log" was very large and using the boot volume available space. In turn, we were not able to login Debian GNOME. Thus the need to delete this file.
In the future, after a reboot, this file will automatically be recreated by CUPS. But a smaller file.

Using Terminal, as a user with the Sudo permission, execute this command to stop CUPS
sudo service cups end

Using Terminal, execute this command to find the present available space of the boot volume. If successful, the available space has increased.
df -h

Using Terminal, as a user with the Sudo permission, execute this command to restart your device
sudo service cups end

Done. You have successfully resolve this challenge :)

Attribution and thanks to voy for this commands to set the chmod


UI gets freeze when deleting multiple files

Description
In the new version of Files, the UI freezes when deleting multiple files at once (I am deleting about 100 files). I think the deletion process is handling files one by one, which takes a lot of time. Additionally, the deletion process locks up the UI.
Steps To Reproduce

install 3.7.6 version
delete 100 files at same time

Requirements
the UI must not get locked
Files Version
<IP_ADDRESS>
Windows Version
Edition	Windows 10 Pro Version	22H2 Installed on	16/06/2023 OS build	19045.4894 Experience	Windows Feature Experience Pack 1000.19060.1000.0
Log File
debug.log

Thanks for the report, Do you have many items in the recycle bin?

I had 3,174 files totaling about 200 MB. After emptying the Recycle Bin, I deleted multiple files, and it seemed to be a bit faster, but the UI is still unusable.

Thank you for the report, we're going to continue tracking this issue in #14108.


"Godot4.0-beta5" cannot be stuck directly

"Godot4.0-beta5" cannot be stuck directly

Well - Godot is currently a moving target and I have no resources to update to all their betas.
So I'll wait until the final version is available.
If you have a fix I would be happy if you could send a PR...


Refs #26250 -- Added str.format() placeholder support to ValidationError

Deprecated legacy %(<foo>)s placeholder support.
https://code.djangoproject.com/ticket/26250

So far the opinions on the mailing list haven't favored this change. Will reopen if things change.


Fix update alias

Create alias on update if it does not exist
Update alias always (even if there is no code change, alias might change version)
Adding a bunch of placebo responses for new behaviour (old tests still work with old responses)

Tested on Python 2.7.13 and 3.6.0

Thanks.  I'm just going to merge locally and run the tests.  Looks great!


Add MELODIES-MONET example on JupyterHub (or similar)

Let's add MELODIES-MONET example on JupyterHub (or another) for conferences, link to the docs. This way people can provide something similar for conferences. @dwfncar  and @mebruckner were working on this for the Earth Cube Conference and ran into memory problems. Once these are resolved, let's get an example working that people can point to.

The idealized example should run on Binder, I could make a link for that.

JupyterHub memory limits prevented a full example for EarthCube summer '22.


Don't load_provider if provider already deleted

Our retry logic never stops trying to load a provider until it works. Even after a provider is removed.
Because failures are captured with self.config.set, this causes corruption where we re-insert a nearly empty dict for an instance id:
  "providers": {
    "snapcast--e8gUtVPG": {
      "last_error": "Unable to start the Snapserver connection ?"
    }
  }

This PR changes things to make sure a provider still exists in the config system before trying to load_provider. The corruption never happens, and the looping stops.
The problem with this approach is that it requires a ProviderConfig to be stored before we can call load_provider. This is a change in behaviour.

Are you ok with changing the load/save order?

Are you ok with changing the load/save order?

Yeah, but we maybe have to simulate a few edge cases, such as setting up a provider and then fail in that setup to test if we recover from that. I believe the order was that way to prevent a half baken config to land up in the storage but now you handle that later in the process so see what it brings.

This actually has a horrible regression, caused by changing the save/load order. To simulate failure I broke jellyfin. Now it created a new save (with a new instance_id) every time i hit save.. So i suddenly had multiple Jellyfin instances. I reworked it a bit to preserve the old order and that is fixed.
So now theres 2 API's - one that takes a ProviderConfig and does not retry. It raises, and is meant to be used when adding a new provider instance only. Then the 2nd, which takes an instance_id and checks the provider still exists in settings.

yeah, this makes a lot of sense!


Triggering Zoid components programmatically

Is there a way to trigger a "click" on a zoid component, rendered as a button inside an iframe from  the parent page that it is rendered on?
For example, with the PayPal button, would it be possible to call paypal.Button.trigger("click") for example or something similar that would cause the button to be clicked?
I know you can't, for instance, use jQuery to search the DOM tree for the button element since it lives inside an iframe and accessing those elements is against the cross domain policy.
My main reason for asking is because I'm trying to build a plugin for Wordpress/Woocommerce with Zoid. The flow is similar to how the Zoid demos work:

A user clicks a zoid button on the wordpress page
It opens a popup that is also a zoid component which allows the user to log in
User logs in and the popup closes, calling a callback on the button zoid component which triggers the Woocommerce/Wordpress login functionality

The issue im facing is that, sporadically, after the popup closes, the callback props on the zoid button are never called. The window closes but the user never gets logged in to the website.
So as a workaround, I'm trying to figure out if there's a way to programmatically trigger the first zoid button the wordpress page.

Additionally, if the connection between the zoid component on the parent page and the zoid popup window "breaks", is there any way to re-establish that connection?

Additionally, if the connection between the zoid component on the parent page and the zoid popup window "breaks", is there any way to re-establish that connection?

@ziyadparekh did you ever figured out this piece?


Add tftpd64

Please can we add tftpd64 to evergreen.
May be able to get the required info via API from bitbucket?
https://bitbucket.org/phjounin/tftpd64/downloads/

Thanks, I'll see if I can contribute it to Nevergreen instead.


fix (data-apps): base image info

Changes:

data-apps - base image section contained link to private repo Dockerfile. Added Dockerfile contents inline with a list of pre-installed packages


Do not create artifical name for extension-only filenames

Problem
Verification of files that starts with dot (e.g. .editorconfig) generates/uses snapshots which prepend nofilename to the tested file. This is a minor inconvenience - discussed here: https://github.com/VerifyTests/Verify/issues/699#issuecomment-1302881371
Solution
filename is preserved as empty
directory structure is preserved as well
appropriate tests added
Note
Potentially similar approach might be taken for files without extensions (currently artifical .noextension extension appended). This would require some changes in EmptyFiles as well (to support empty extension). I'm leaving it for separate work if it ever becomes concern for anyone.

so this is a breaking change?

That's correct.
More precisely:

For updates from >= 18.3.1-beta.1 it's breaking
For updates from <= 18.3.0 it's actualy enabling the upgrade without the breaking change that's currently imposed (as previously the 'dot filename' that was contained within some subdirectory was supported as is and in newer version the snapshot name is altered)

We are currently in the second category (trying to prevent sequence of 2 breaking changes)

do u think it makes sense for this to handle deletion of the legacy file?
if no can u add a section in the description for how people can manually clean up

Good point.
Will look into that and update.

@SimonCropp I update the PR to rename the snapshots from previous naming convention (simple cleanup of previous naming convention is in previous commit - if that feels as better strategy). Let me know what are your thoughts on that.
Thanks!


Use ephemeral credentials from AWS OIDC provider

CI will fail here temporarily on purpose. Relies on another PR. I'll re-run CI when that goes through but wanted to stage here first.

ok, poke when the other pr appears.  will be watching them.

ok, poke when the other pr appears. will be watching them.

@prozacchiwawa sorry, should have specified the other PR that this one relies on was in a different repo which has just been merged. This one should be g2go now

gotcha


[RFR] 1.1.0 French

Fixed and merged. Terrific! Thanks for your quick translation Pierre. :)

:+1:


Pre-release 24.07.29 causes issues when are not scheduled requests in every coordinator update loop

Just tried the above and it raises a load of errors. Downgrading to .28 fixes.
Sorry, I've lost the log....
No I haven't, looking at it now it appears to have recovered just as I moved back to the previous version....I'll try again when I have some time just in case the inverter really was off-line?
home-assistant_solarman_2024-07-30T08-21-37.172Z.log

As it's unfortunate this pre-release version is mainly for testing some niche cases of some users which are not able to run at all it proly will change multiple times before the release. But still thanks for the report for sure! I'm also running it but without any problems, maybe it's device dependent hm?

For info I've just tried the latest from main and it still causes issues so will need a tweak before releasing. Log attached which will hopefully help.
home-assistant_solarman_2024-07-31T14-46-38.733Z.log

Not sure what exactly could cause that but I tried: fix: Reverted partial request fulfillment as it turned out this feature is not necessary and original issue was caused by incorrect profile used.

Sorry, only just seen your Edit2: above. I have been seeing some really variable update intervals which I think has been also caused by the auto discovery. I have now disabled auto discovery which has improved matters plus have loaded 24.07.31 with no issues so far.
Going off-line

Coming on-line

I'm still struggling to debug what happened at 8.05am when I restarted HA with a slightly different profile that had 3 disabled parameters. Now I've disabled auto discovery and running the latest build I will evaluate again over the coming days.

Could you maybe do a test for me with 5 sec update interval for lets say a hour during the day? And also share the graph here?

Just realised, would you like a debug log too? If so I'll run again.

Thanks! And no it is not necessary I just wanted to see what are the usual update intervals on other installations.
Very appreciated!

What about the issues you were seeing? Are they still present in the last pre-release?

Latest release has been fine, I was just giving it a few days to confirm. I  couldn't determine the cause of the variable polling time when it varies between 30-40s as shown on the "coming on line" graph above.  Integration, inverter or network? If I ever find a way of provoking it then I'll raise an issue (if it is the integration) so I think it's safe to close this.


Studio Heading 1 and Heading 2 both render as <h3>

Steps to Reproduce

Create a page in Studio
Add some text with "Heading 1" style
Add some text with "Heading 2" style
Publish the page

Expected Behavior

"Heading 1" and "Heading 2" should have different styling to distinguish them

Actual Behavior

"Heading  1" and "Heading 2" look the same
they both renders with <h3> HTML tags

Screenshot or Screencast
compare https://ocw-studio-rc.odl.mit.edu/sites/peters-test-site-for-unpbulishing/type/page/edit/7e4f5b8c-9592-495f-b2c4-8423c788ec41/

and  https://draft-qa.ocw.mit.edu/courses/test101-peters-test-site-spring-2023/pages/a-page-full-of-headers/

While you are working on this, note that the  "Heading 3" text is styled red when it should be black. Compare to the style guide: https://projects.invisionapp.com/d/#/console/21537330/468374061/comments

@pdpinch Need your clarification on something:
We have this course lists page:
https://ocw.mit.edu/course-lists/open-learning-library/
It currently has red styled h1 heading which has applied styling of h2 with caps (MIT OPEN LEARNING LIBRARY). Plus, currently this same heading size is also applied to mobile screen size. Other than that, there are more headings on this page.
But OCW Style Guide does not mention anything for this. How should this be handled.
Also: I noticed a few inconsistencies of our current themes in relation to the style guide (such that h4 and h5 are not actually h4 and h5, but they are div texts with applied styling to achieve the behaviour). But I believe they are out of scope for this ticket. I'll R&D what other inconsistencies are there and open an issue for that after this.


[BUG]

Contact Details
<EMAIL_ADDRESS>What happened?
When I try to withdraw my deposit in WETH and it doesn't let me, I get this message: 'Something went wrong cannot estimate gas; transaction may fail or may require manual gas limit [ See: https://links.ethers.org/v5-errors-UNPREDICTABLE_GAS_LIMIT ] (reason="execution reverted", method="estimateGas", transaction={"from":"0x8e66ED6fDC1e19983Da7c4D7A4F3b3F22876300c","to":"0xe04Bb5B4de60FA2fBa69a93adE13A8B3B569d5B4","data":"0xac9650d800000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000004000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000084a6459a32000000000000000000000000e50fa9b3c56ffb159cb0fca61f5c9d750e8128c800000000000000000000000000000000000000000000000000000000000000000000000000000000000000008e66ed6fdc1e19983da7c4d7a4f3b3f22876300c000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000006469328dec000000000000000000000000e50fa9b3c56ffb159cb0fca61f5c9d750e8128c800000000000000000000000000000000000000000000000000000000000000000000000000000000000000008e66ed6fdc1e19983da7c4d7a4f3b3f22876300c00000000000000000000000000000000000000000000000000000000","accessList"
}, error={"code":-32603,"message":"execution reverted","data":{"originalError":{"message":"execution reverted","code":3,"data":"0x1c3125d4000000000000000000000000000000000000000000000000000000000000004000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000084a6459a32000000000000000000000000e50fa9b3c56ffb159cb0fca61f5c9d750e8128c800000000000000000000000000000000000000000000000000000000000000000000000000000000000000008e66ed6fdc1e19983da7c4d7a4f3b3f22876300c0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000024bf16aab6000000000000000000000000e50fa9b3c56ffb159cb0fca61f5c9d750e8128c800000000000000000000000000000000000000000000000000000000000"}}}, code=UNPREDICTABLE_GAS_LIMIT, version=providers/5.7.2)' and it doesn't proceed further. I have been trying for a few hours now.
Steps to reproduce

...
Expected behavior
No response
What browser were you using?
Other
If you selected "Other" above, fill in the browser you used here.
Edge

Refesh web and try again


[🚩release 5.0.0]: Drop IE11 / ES5 support

As an ESL architect, I don't want to spend team resources to support and not popular and completely legacy targets.
It is requested to drop IE11 browser support and support of ES5 target in general.
Scope of proposed updates:

[ ] Get rid of the full version of the polyfill for esl-ui.com site renderer
[ ] Remove shims and targets =ES5 (if such presented) in the site codebase
[ ] Remove ES5-related OOTB ESL polyfills except es5-target-shim.ts

Target branch: main-beta

:tada: This issue has been resolved in version 5.0.0-beta.3 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Documentation is unclear. Stuck on Quick Start

[X] I've searched existing issues and couldn't find a duplicate.

Hello there. I am not experienced in running a Minecraft server, but I wanted to try out Pumpkin. Unfortunately, I am stuck on the Quick Start guide. Specifically:

You can place a vanilla world into the Pumpkin/ directory when you want. Just name the World to world

I am not sure what this means. I made a directory called world in the git root (Pumpkin/), but the server fails to start with:
➜ Pumpkin (master) ✔ cargo run --release
    Finished `release` profile [optimized + debuginfo] target(s) in 0.33s
     Running `target/release/pumpkin`
2024-10-12T21:22:28.106Z INFO  [pumpkin::server@main] Loading Plugins
thread 'main' panicked at pumpkin-world/src/level.rs:112:13:
World region folder does not exist, despite there being a root folder.
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I assume I need to do more than just mkdir world, but I'm not sure what that is. I am able to start the server without creating that directory, but the client fails to connect even though an attempt seems to have been made:
2024-10-12T21:20:44.818Z INFO  [pumpkin@main] Accepted connection from: <IP_ADDRESS>:37296
[pumpkin/src/client/client_packet.rs:37:9] "handshake" = "handshake"
[pumpkin/src/client/client_packet.rs:62:9] "ping" = "ping"

I'd be happy to update the Quick Start guide in a PR if someone is able to help a noob understand what one should do 🙁
Thanks!

Sounds like you just put a folder named world there instead of putting a world that you'd like to play there with the name world

It says "place a vanilla world" in "Pumpkin/" named "world". An empty folder is not a vanilla world, So it does not work

If i remember correctly, you need world/ folder and world/region/ folder.

If i remember correctly, you need world/ folder and world/region/ folder.

ye, thats what a vanilla world also usually has

You can get a world folder from your Minecraft save files. Some sites also offer pregenerated/built worlds.


Fix test failures due to ui bugs1

I need to do this in two parts to accomplish the rename of one of the .cl files.

Modified two test cases to deal with failures due to UI Bugs.

:tada: This PR is included in version 0.413.0 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Use an before 1x, not a

Similar to #5 and #7, I received the following warning:
1:14-1:15  warning  Use `an` before `1x`, not `a`   retext-indefinite-article  retext-indefinite-article

I expected "a 1x" to be correct. If you agree, I'd be happy to create a PR.

Good catch. I believe you are correct and happy to take a PR.
You can check this commit to see how a previous exception for "1" was implemented: https://github.com/retextjs/retext-indefinite-article/commit/2fc613a641349a45ba02ad1459eafde8a95a4914


update the storage selfhealing spec

since it was created, it got a bit out of sync with
the actual planned work and issues in 0-Disk.
this patch aims to update the storage selfhealing spec
such that the work that is planned is reflected in the spec as it is.

As a general comment. Only AYS should update the etcd, to prevent race conditions.

Sure, I have never wanted otherwise :) I'm fairly sure I was one of the people saying that since the beginning.

@FastGeert is there anything you still want to have changed, or is it good as it is now? Just so I know we're on the same page.


Various updates, mainly bug fixes and updating tests

Changelog:

OK now errors if no tests were able to be loaded. If a single test source is not able to be loaded (e.g. can't find hw01.py), but other tests can be loaded, no error occurs (although a debug message is printed). This is to accomodate labs, where a student might have downloaded lab02.py but not lab02_extra.py; OK shouldn't exit prematurely just because it can't find lab02_extra.py
Fix/add tests and make exceptions more consistent/informative
Fix some bugs introduced in v1.3.2
Resolve #19

This PR should fix most outstanding bugs in the client, except for authentication. It's ready for review, whenever you're ready.

Okay, yeah. LGTM.


add creator to the log emit, and put the emit in the correct spot chronologically

changed the line, more important to be consistent

changed the line, more important to be consistent


drivers: ethernet: nxp_enet: Fused MAC address fixes

Add required initialisation of OCOTP.
The IMXRT10XX variants don't support fuseWords to be greater than 1.
Fill in mac_addr buffer correctly.
I derived the MAC0 fuse map address from the datasheet, MCUXpresso Secure Provisioning Tool and a sample of the RT1064.
In the datasheet is mentioned:

In the MCUXpresso Secure Provisioning Tool is mentioned:

In a sample is mentioned:
https://github.com/JayHeng/imxrt-level2-boot/blob/master/boards/evkmimxrt1060/driver_examples/ocotp/ocotp_example.c#L28
I am not able to test it, but the MCUXpresso Secure Provisioning Tool mentions for the RT1176 that the fuse map address of MAC1 is 40 (0x28).

@decsny could you give some feedback as rc3 will be tagged on Friday and this looks like we want to have in 3.7.0.

rebased to re-trigger stuck CI


Stop a GIF mid playing

Hello, first of all wonderful work with the library, its really helpful
so is there a command or any way by which i can stop a gif, while its playing
currently by using
gif.close()
or
f = FILESYSTEM.open(fileName);
f.close();
the gif closes but only after completely playing through, so is there any way to stop it mid way and play the next gif

The API decodes a frame at a time. You can stop at any frame.


TestValidatorSetHandling is flaky/non-deterministic

TestValidatorSetHandling fails on CI from time to time. It's using time.Sleeps  corresponding to BlockTime aggregator config. This is "fragile" solution, especially with when running with GitHub actions.
Test should be updated so it's not using time.Sleep anymore. Possible solution is to use channel in EndBlock mock, to signal about block availability.

@tzdybal could you assign this to me?


Multiple groups as "superadmin"

I have the following setup:
Using ULX we have multiple groups above superadmin, like owner and headadmin.
There is no way to set the owner and headadmin group to max privileged.
Currently owner and headadmin do not have access to bLogs' operator tab at all.

yes there is... it's literally right here
https://github.com/GmodAdminSuite/OpenPermissions-Config/blob/master/lua/openpermissions_config.lua

Uh. Sorry. Literally was desperate and didn't see that,. Thanks.


In JS, type unioning of this-assignments has undesired behaviour

function A() {
  this.p = 0
}
A.prototype.m = function(x) {
  this.p = x
}
var a = new A()
a.p // p: any

Expected behavior:
a.p: number
Actual behavior:
a.p: any
This happens because we treat all assignments to the property as declarations and then union their types. And any | T | ... === any
But compare:
function A() {
  this.ps = []
  this.maybe = undefined
}
A.prototype.init = function(x) {
  this.ps = [1,2,3]
  this.maybe = 'just'
}
var a = new A()
a.ps // ps: number[]
a.maybe // maybe: string | undefined

When the initialiser in the constructor has an uninformative type, the unioning can result in a much better type, or at least a less bad type (any). But perhaps the fix here is to handle these uninformative initialisers differently.

humm.. this looks right to me.. why is it different from say:
function A(x) {
  this.p = x || 0;
}

It's different because assignments in a constructor should have higher priority than those in a method. In the any case above, we lose type information from the constructor that is unambiguously more important than the assignment in the method, unlike the this.p = x || 0 case. And this is even worse:
function A(x) {
  this.notANumber = 'one'
}
A.prototype.m = function() {
  this.notANumber = 1
}

I need to see some concrete examples of init-style patterns, but I suspect with those you will not see this-assignments both in the constructor and in the init method.


Consider whether to treat some Low Priority measures as Cost Saving

At the moment we don't, which leads to the slightly odd behaviour raised in #725.
Which of the current crop of low priority measures are candidates for cost savings?
And does it still make sense to calculate savings in the same way as we do for other measures (i.e. compare to best performing decile)? Or as the "ideal" prescribing quantity for these is zero, should we treat the entire cost as a potential saving?
Thoughts @richiecroker?

This is tagged at you @richiecroker !

And again for @richiecroker email test

We now calculate cost savings for all cost-per-1000 measures


Feature/loadtesting v2023 04 01 preview/draft1

Data Plane API - Pull Request

API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

Link to API Spec engagement record issue:

Is this review for (select one):

[ ] a private preview
[x] a public preview
[x] GA release

Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified. Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

Added a new API version - 2023-04-01-preview
Design Document:
Previous API Spec Doc: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/loadtestservice/data-plane/Microsoft.LoadTestService/stable/2022-11-01/loadtestservice.json
Updated paths: No root path updated.

Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!

 Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

💬 Teams Channel
💌 email

Click here for links to tools, specs, guidelines & other good stuff
Tooling

Open API validation tools were run on this PR. Go here to see how to fix errors
Spectral Linting
Open API Hub

Guidelines & Specifications

Azure REST API Guidelines
OpenAPI Style Guidelines
Azure Breaking Change Policy

Helpful Links

Azure DevTools Wiki

fix https://github.com/Azure/azure-rest-api-specs/issues/26367

Also make sure to check the TypeSpec Validation step and address any issues there after you've pushed more recent commits.

/azp run

@mikekistler @catalinaperalta , We have addressed the comments and resolved most of them. Have dropped few comments on unresolved comments. Please re-review the latest code.

@Himanshu49 is this PR ready to merge?

@Himanshu49 is this PR ready to merge?

Yes @tjprescott , we got the spec reviewed and are good to go.


Extract from BlockInfo into ChainInfo

BlockInfo should only contain block-level info, whereas chain-level information should be held at the BlockContext level, encapsulated in a dedicated ChainInfo struct.
Changes:
Only extract from BlockInfo and store in BlockContext.chain_info: ChainInfo. All other changes are search-replace + moving the fee_token_address getter into ChainInfo.
TODO: extract more stuff from BlockInfo: version-dependant constants should be extracted into a dedicated VersionedConstants, which will be a member of BlockContext

This change is

@elintul  Sorry i merged this by mistake into the block_info branch, i reverted the merge and reopened this PR (no other changes): https://reviewable.io/reviews/starkware-libs/blockifier/1344


Office 365 Excel "DDE Server Window" error

Environment
Windows build number: v1909 build 18363.476
PowerToys version: 0.14.0
PowerToy module for which you are reporting the bug (if applicable): FancyZones (suspected)

Steps to reproduce
fully repeatable whenever I open any Excel spreadsheet, or simply the .exe, even with /safe
Expected behavior
no issues prior to installing v.014.0
Actual behavior
Excel freezes with 4 screens open, all blank. See screenshot
Screenshots

I should add that Excel opens and runs fine once I close PowerToys. No need to uninstall PowerToys, just closing it fixes the problem.

Hi @ottogunter
thank you for reporting the problem. We stopped distributing 0.14 because of this bug.
We are planning to release the fix soon. In the meantime, if you have the FancyZones option "Move newly created windows to their last known zone" on, try turning it off, it may solve the problem.

Thanks for your prompt reply. I can live without FancyZones for a while, but will be checking for the update…

Horst
From: Enrico Giordani<EMAIL_ADDRESS>Sent: December 3, 2019 2:06 PM
To: microsoft/PowerToys<EMAIL_ADDRESS>Cc: ottogunter<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [microsoft/PowerToys] Office 365 Excel "DDE Server Window" error (#851)
Hi @ottogunterhttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fottogunter&data=02|01||1e90015e69cd4528ee8c08d7783cfa4a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637110075597771698&sdata=oJQH1CCJRiuzsPtQx8gqId%2BQYMiLZB5sNZEpP3EPUg8%3D&reserved=0
thank you for reporting the problem. We stopped distributing 0.14 because of this bug.
We are planning to release the fix soon. In the meantime, if you have the FancyZones option "Move newly created windows to their last known zone" on, try turning it off, it may solve the problem.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FPowerToys%2Fissues%2F851%3Femail_source%3Dnotifications%26email_token%3DAKGXPFGVEAZFLAOH7IJ3IATQW3J4JA5CNFSM4JU6U272YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF27IMY%23issuecomment-561378355&data=02|01||1e90015e69cd4528ee8c08d7783cfa4a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637110075597781697&sdata=6HqRrfv6kqyBVAXnYzYAxG99FIXiNiRYxMvMLC7Nb1w%3D&reserved=0, or unsubscribehttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKGXPFAAUDA5ZRKEFPXDMJDQW3J4JANCNFSM4JU6U27Q&data=02|01||1e90015e69cd4528ee8c08d7783cfa4a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637110075597791714&sdata=VxBQovCfGCclDD99VQjHIHPkkAQi7Pg2tCoh80mzZ80%3D&reserved=0.

Had this happen yesterday (12/2/19) after updating to PowerToys version: 0.14.0 also. Had to sign out of my Windows user account and back in to fix problem.

@ottogunter @lotsacaffeine97 could you try our new DLL and see if the problem persists. Here are the instructions and the download link.

The new DLL has fixed the problem, Excel now opens properly. 👍
Thanx.
From: Bartosz Sosnowski<EMAIL_ADDRESS>Sent: December 4, 2019 1:42 AM
To: microsoft/PowerToys<EMAIL_ADDRESS>Cc: ottogunter<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [microsoft/PowerToys] Office 365 Excel "DDE Server Window" error (#851)
@ottogunterhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fottogunter&data=02|01||66e15437e166432787ec08d7789e3575|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637110493196690385&sdata=cDMoRSdiDJI%2FfsovHvutX3%2F9F6YYD5aY%2BOYSz0ZI7z0%3D&reserved=0 @lotsacaffeine97https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flotsacaffeine97&data=02|01||66e15437e166432787ec08d7789e3575|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637110493196700395&sdata=TORHksSIpzBttWj7PGS%2BSbqL46T6ekrhsigT%2FAujm30%3D&reserved=0 could you try our new DLL and see if the problem persists. Here are the instructions and the download linkhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FPowerToys%2Fpull%2F856%23issuecomment-561553060&data=02|01||66e15437e166432787ec08d7789e3575|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637110493196700395&sdata=tDqqkTiVTTOyjOiKJPQkFYOOBZ4AqC2iPgx%2Bqka6g5w%3D&reserved=0.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FPowerToys%2Fissues%2F851%3Femail_source%3Dnotifications%26email_token%3DAKGXPFC7UCIVJQR2Y3KEYETQW53ONA5CNFSM4JU6U272YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF4LHCI%23issuecomment-561558409&data=02|01||66e15437e166432787ec08d7789e3575|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637110493196710404&sdata=NJ3gXKcs5Y1tzbAkLwgdtPVLuZj134aRz0%2FCAjGFyKE%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKGXPFAAEGCTLMEP43JURJLQW53ONANCNFSM4JU6U27Q&data=02|01||66e15437e166432787ec08d7789e3575|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637110493196710404&sdata=j%2BZyJdFfNfIE1wlDvCoFE4iwbHnjTy2CzrcrMkac13U%3D&reserved=0.

The new release is available https://github.com/microsoft/PowerToys/releases/tag/v0.14.1

The new release is available https://github.com/microsoft/PowerToys/releases/tag/v0.14.1


FINERACT-2089 Upgrade java dependencies/libraries

Description
FINERACT-2089 Upgrade java dependencies/libraries
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[X] Write the commit message as per https://github.com/apache/fineract/#pull-requests

[X] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

[ ] Create/update unit or integration tests for verifying the changes made.

[ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

[ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

[ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@jdailey @adamsaghy @vidakovic @galovics

I will close this PR, the org.owasp.antisamy:antisamy is a dependency of org.owasp.esapi:esapi and the com.nimbusds:nimbus-jose-jwt is dependency of org.springframework.boot:spring-boot-starter-oauth2-resource-serve, both libraries have been updated to the latest version (until today 2024-05-30) so then until the release of new version of both libraries we can proced with the update.


feat: Implement a plugin that can retrieve Marlin TEE remote attestations

Risks
Low.
Background
What does this PR do?
This PR aims to add a plugin that makes Eliza verifiable through the use of TEEs. The plugin leverages the Marlin Oyster platform and SDKs. More concretely, it adds an action that lets Eliza respond with remote attestations when asked. It is expected to be followed up with additional PRs for other aspects as well.
What kind of change is this?
Features.
Why are we doing this? Any context or related work?
It's important for AI agents to be verifiable in Web3 so users can verify behaviors and responses of an agent they are interacting with. A performant way of accomplishing this is running the agent in a TEE and providing remote attestation infrastructure for verification by users. Additionally, TEEs provide privacy protections to users' interactions with agents.
It is similar in spirit to plugin-tee but targets the Marlin Oyster stack instead.
Documentation changes needed?
Yes. A section on the plugin has been added.
Testing
Where should a reviewer start?
The README of the plugin. It specifies the .env settings as well as how to run a mock attestation server for local testing.
Detailed testing steps

Run the mock attestation server, simplest way is docker - docker run --init --rm -p 1350:1350 marlinorg/attestation-server-custom-mock
Set configs corresponding to the plugin, just TEE_MARLIN=yes should suffice.
Chat with Eliza and ask for a remote attestation, I have tried various phrasings like "attest yourself", "get me a remote attestation", etc which seem to work.

Discord username
roshanroshan

Hey! Nice to see another TEE option here. We should talk more on how we want to document and educate developers on TEE and the different options available for devs to get started.
Some comments:

Can you add the lint file?

eslint.config.mjs
import eslintGlobalConfig from "../../eslint.config.mjs";

export default [...eslintGlobalConfig];

package.json
"scripts": {
        "build": "tsup --format esm --dts",
        "dev": "tsup --format esm --dts --watch",
        "lint": "eslint . --fix"
},

Rebased on latest main and added linting.

Hey @roshanrags, sorry for the delay here. I have a coupl of  questions:

Is the expectation that the Eliza Agent will be running inside the TEE Oyster on Marlin? And if so, will the eliza agent be connecting through a websocket or via http request to get the RA Quote?
If Eliza is not running in the TEE Oyster, can a user trust the RA Quote since it is not executed in a TEE?

Rebased on latest develop.

Is the expectation that the Eliza Agent will be running inside the TEE Oyster on Marlin?

Yes.

And if so, will the eliza agent be connecting through a websocket or via http request to get the RA Quote?

It makes a HTTP request to fetch attestations.

If Eliza is not running in the TEE Oyster, can a user trust the RA Quote since it is not executed in a TEE?

The attestation would not verify properly in this case. A valid production attestation should fully verify and be anchored to AWS's root certificate. The mock server generates valid attestations but they are anchored to a custom root certificate instead.

Any idea what's failing here? https://github.com/ai16z/eliza/actions/runs/12367420001/job/34515692344?pr=935
The chat interface seems to set itself up just fine :thinking:

Rebased on the latest develop.

The lockfile wants things to be ordered alphabetically, the elizaos rename seems to have messed that up btw.


introduce websocket maxFramePayloadLength

fix https://github.com/spring-cloud/spring-cloud-gateway/issues/1610

@spencergibb done. I also made classes static.


Align texts messages in the ubiquity installer scripts.

According to Dima review.

This change is

Review status: 0 of 4 files reviewed at latest revision, 6 unresolved discussions.

scripts/installer-for-ibm-storage-enabler-for-containers/ubiquity_cli.sh, line 22 at r1 (raw file):

assumes
done (1 and 3)

scripts/installer-for-ibm-storage-enabler-for-containers/ubiquity_cli.sh, line 94 at r1 (raw file):
Previously, alonm wrote…
Are the components fully stopped at this stage? Or is it an async operation?

async - this is why there is NOTE to view the deployment s status.
not going to add wait for deployments here (at least not now).

scripts/installer-for-ibm-storage-enabler-for-containers/ubiquity_cli.sh, line 175 at r1 (raw file):
Previously, alonm wrote…
I think the convention is NOT OK (all capitals)

Follow Dima instructions.

scripts/installer-for-ibm-storage-enabler-for-containers/ubiquity_lib.sh, line 244 at r1 (raw file):
Previously, alonm wrote…
better break the lines

prefer not
its look OK as it echo out to the user.

scripts/installer-for-ibm-storage-enabler-for-containers/ubiquity_uninstall.sh, line 21 at r1 (raw file):
Previously, alonm wrote…
issing 'n' in uninstalls

good catch

Comments from Reviewable


Bug: links to insight pages take non-logged in users to highlight feed

Describe the bug
Currently, if a user isn't logged in and clicks on a link to a public insight page or workspace, they are redirected to the main feed.
ref for core team: https://opensaucedworkspace.slack.com/archives/C035RQ8ANBW/p1709847745002639?thread_ts=1709847327.367359&cid=C035RQ8ANBW
Steps to reproduce

Logout or use an incognito window
Click this link: https://app.opensauced.pizza/pages/BekahHW/1055/dashboard

Potential solution is to 404 for these pages for now.
Browsers
No response
Additional context (Is this in dev or production?)
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[ ] I agree to follow this project's Contribution Docs

Hmm thought this was fixed in: https://github.com/open-sauced/app/issues/2773 - seeing the same thing. Maybe a routing regression?

I moved this to planned for launch. We should also consider adding a test for this in the future.


Move Related technologies to end

Please use this template to ensure easier processing of your pull request
Category

[x] Content fix
[ ] New article

Related issues

fixes #issuenumber
partially #issuenumber
mentioned in #issuenumber

Contents of the Pull Request

Updated document headings and order for consistency

Guidance

Docs Build status updates of commit 4347e60:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Community/microsoft365-maturity-model--search.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Use uv

Since Astro team released uv recently, should we try it with ada-python?

From https://github.com/ada-url/ada-python/pull/60, it seems that there are still some issues being resolved for uv pip to be a drop in replacement on CI systems (example). I think it might make sense to wait for some of that to settle down.
I have been using ruff in place of flake8 and black on other projects, however, and am very happy with it. I'll switch this one to use them.


Nickname registration end point not working

@ChetanKhanna
Nickname registration request results in an invalid response.

I think this one is done. Closing it now.


Table type ZMQBA_GUI_T_SUBSCREEN

Hi,
Currently abapGit does not support having DDIC objects refer to workbench objects, as DDIC objects are always activated first.
Suggest moving the table definition to interface zif_mqba_gui_bl instead of having it in DDIC.
Definition,

Error when activating,

Suggested move,

i will check this. Thanks.


Implement \G "vertical" output format like MySQL client

The MySQL client has a great "vertical format" if you use "\G" instead of "\g" or ";".
The benefit of this is that it's easy to get very long/wide output in a way that it can be easily copied in the terminal.
It's nice to be able to use \G on a single-statement instead of having to change the output format in a more persistent way.
mysql> show create table t3;
+-------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Table | Create Table                                                                                |
+-------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| t3    | CREATE TABLE `t3` (
  `id` char(4) NOT NULL,
  `x` int(11) DEFAULT NULL,
  PRIMARY KEY (`id`),
  KEY `x` (`x`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin |
+-------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.001 sec)

mysql> show create table t3\G
*************************** 1. row ***************************
       Table: t3
Create Table: CREATE TABLE `t3` (
  `id` char(4) NOT NULL,
  `x` int(11) DEFAULT NULL,
  PRIMARY KEY (`id`),
  KEY `x` (`x`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin
1 row in set (0.001 sec)

There's \x that allows you to switch to a vertical format. If you don't want to make it permanent try \x auto which will automatically use vertical format if the output is too wide for the current terminal. This was recently added and is only available on the master branch, not in the latest release (0.8.2).

The recently-added "vertical" format doesn't really address the copy-paste use case.
ti:root@localhost:4000=> \x
Expanded display is on.
ti:root@localhost:4000=> show create table t4;

-[ RECORD 1 ]---------------------------------------------------------------
 Table        | t4
 Create Table | CREATE TABLE "t4" (                                        +
              |   "id" char(4) NOT NULL,                                   +
              |   "x" int(11) DEFAULT NULL,                                +
              |   PRIMARY KEY ("id"),                                      +
              |   KEY "x" ("x")                                            +
              | ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin

And in any case \x auto doesn't seem to trigger in this setting:
ti:root@localhost:4000=> \x auto
Expanded display is used automatically.
ti:root@localhost:4000=> show create table t4;

 Table |                        Create Table
-------+-------------------------------------------------------------
 t4    | CREATE TABLE "t4" (                                        +
       |   "id" char(4) NOT NULL,                                   +
       |   "x" int(11) DEFAULT NULL,                                +
       |   PRIMARY KEY ("id"),                                      +
       |   KEY "x" ("x")                                            +
       | ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin
(1 row)

We try to follow psql closely and I don't think there's a way to display newlines ignoring being inside a table cell. Can you try using other output formats, like csv? We recently also added asciidoc which should be human readable but allow you to achieve what you want. But it's also only on the master branch, not released yet.

For what it's worth, I'm open to adding a \G metacommand. I of course do think we should try to be as close to psql as possible, but there's no reason we can't adopt some of MySQL's command line functionality as long as:

it's not a duplicate of existing functionality (I would even suggest that aliases would not be allowed, but since this is functionally different enough it's worth considering)
doesn't clash with behavior from psql -- since psql doesn't have a \G, I think this would be acceptable

Assuming the above, I think it would be OK to add this.

There's already \g (and \gx) implemented but without formatting options. \G could be an alias of \gx with a new option for tbmlfmt, something like contain-newlines=false.

\G could be an alias to \gx (tuples_only=on)

I just pushed a commit that copies MySQL's \G. @kolbe please test and let me know if this works as expected.
Note: this deviates from MySQL in that NULL is shown as a blank string. This can be configured by setting the \pset null variable:
my:root@localhost/test=> \pset null 'NULL'
Null display is "NULL".
my:root@localhost/test=> select * from test \G
*************************** 1. row ***************************
a: yes
b: no
*************************** 2. row ***************************
a: three
b: NULL
*************************** 3. row ***************************
a: 1
b: 2
*************************** 4. row ***************************
a: 1
b: 2
*************************** 5. row ***************************
a: 1
b: 2
*************************** 6. row ***************************
a: 1
b: 2
*************************** 7. row ***************************
a: 1
b: 2
*************************** 8. row ***************************
a: 1
b: 2
*************************** 9. row ***************************
a: 1
b: 2
*************************** 10. row ***************************
a: 1
b: 2
*************************** 11. row ***************************
a: 1
b: 2
*************************** 12. row ***************************
a: 1
b: 2
*************************** 13. row ***************************
a: 1
b: 2
*************************** 14. row ***************************
a: 1
b: 2
*************************** 15. row ***************************
a: 1
b: 2
*************************** 16. row ***************************
a: 1
b: 2
*************************** 17. row ***************************
a: 1
b: 2
*************************** 18. row ***************************
a: 1
b: 2
*************************** 19. row ***************************
a: 1
b: 2
*************************** 20. row ***************************
a: 1
b: 2
*************************** 21. row ***************************
a: 1
b: 2
*************************** 22. row ***************************
a: 1
b: 2

my:root@localhost/test=>


feat: :sparkles: PyTorch Recognition Model Multi-GPU support

Fix https://github.com/mindee/doctr/issues/1146
Highly inspired from:

https://pytorch.org/tutorials/intermediate/ddp_tutorial.html#comparison-between-dataparallel-and-distributeddataparallel
https://pytorch.org/docs/stable/notes/ddp.html
https://pytorch.org/docs/stable/distributed.html#which-backend-to-use

How to use this script
wget https://github.com/mindee/doctr/releases/download/v0.3.1/toy_recogition_set-036a4d80.zip
sudo apt-get update && sudo apt-get install unzip -y
unzip toy_recogition_set-036a4d80.zip -d reco_set

python references/recognition/train_pytorch_ddp.py crnn_mobilenet_v3_small --train_path ./reco_set --val_path ./reco_set -b 2 --epochs 10 --devices 0 1

How to retrieve device id
import torch
devices = [torch.cuda.device(i) for i in range(torch.cuda.device_count())]
device_names = [torch.cuda.get_device_name(d) for d in devices]

Todo

[ ] What to do with training loss ?

Dear @aminemindee please have a look I am facing the same problem and you can use this code.

Hi @odulcy-mindee thanks for the PR 👍
Could you update the readme in references with an example how to use this script ? And maybe add this also for the detection task ? :)


Fixed random failure of creating users in populatedb

Randomly, even on an empty database, populatedb could crash when trying to create an existing user twice.
  File "/develop/saleor/saleor/core/management/commands/populatedb.py", line 103, in handle
    for msg in create_users(20):
  File "/develop/saleor/saleor/core/utils/random_data.py", line 513, in create_users
    user = create_fake_user()
  File "/develop/saleor/saleor/core/utils/random_data.py", line 360, in create_fake_user
    password="password",
  File "/develop/saleor/saleor/account/models.py", line 116, in create_user
    user.save()
  File "/develop/saleor-venv/lib/python3.7/site-packages/django/contrib/auth/base_user.py", line 66, in save
    super().save(*args, **kwargs)
  File "/develop/saleor-venv/lib/python3.7/site-packages/django/db/models/base.py", line 741, in save
    force_update=force_update, update_fields=update_fields)
  File "/develop/saleor-venv/lib/python3.7/site-packages/django/db/models/base.py", line 779, in save_base
    force_update, using, update_fields,
  File "/develop/saleor-venv/lib/python3.7/site-packages/django/db/models/base.py", line 870, in _save_table
    result = self._do_insert(cls._base_manager, using, fields, update_pk, raw)
...
  File "/develop/saleor-venv/lib/python3.7/site-packages/django/db/utils.py", line 89, in __exit__
    raise dj_exc_value.with_traceback(traceback) from exc_value
  File "/develop/saleor-venv/lib/python3.7/site-packages/django/db/backends/utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
django.db.utils.IntegrityError: duplicate key value violates unique constraint "userprofile_user_email_key"
DETAIL:  Key<EMAIL_ADDRESS>already exists.

Screenshots

Pull Request Checklist

[ ] Privileged views and APIs are guarded by proper permission checks.
[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Database queries are optimized and the number of queries is constant.
[ ] Database migration files are up to date.
[x] The changes are tested.
[ ] GraphQL schema and type definitions are up to date.
[x] Changes are mentioned in the changelog.

Here is the report for 9ff0f90d8febd61270e6a4cc970368da3570a013 (NyanKiyoshi/saleor @ fix/populatedb/skip-existing-emails)
Base comparison is 3742319bd79f27d74f2efc213db4b18ec95b32e0.
No differences were found. (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         38	         38	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         14	         14	              0
  complete checkout                          	          6	          6	              0
  create checkout                            	         52	         52	             24

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         15	         15	              3
  retrieve product attributes                	         13	         13	              2

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve variant list                      	         18	         18	              8

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0


%Ueberauth.Auth.Info{} is population wrong

%Ueberauth.Auth.Info{
  description: nil,
  email: nil,
  first_name: "Dmitry",
  image: nil,
  last_name: "Rubinshteyn",
  location: nil,
  name: "Dmitry Rubinshteyn",
  nickname: nil,
  phone: nil,
  urls: %{vk: "https://vk.com/id"}
}

This is what I'm getting from success auth.
It seems, that uid was changed to id, so urls are population wrong.

Thanks for reporting!
@Virviil could you please provide a fix for that?


Moment object and calendar start day

Is there anyway that I could grab the date as a Moment object instead of the formatted string? Also, it might be useful to have an option to set the first day of the calendar since it's different here (we start our weeks on Monday).

Hi @taufnrsyd, Angular Moment Picker just returns strings, not object. There's no way at the moment to get the moment object from the directive, but you can have your own Angular Filter to achieve that.
Regarding the first day of the week, it depends on the locale you've set for the picker (i.e en-gb starts the week from Monday; instead en-us starts from Sunday). Check out the demo page at http://indrimuska.github.io/angular-moment-picker/#locales.


ports deltastation shuttle from ss13, assigned to fland installation

About the PR

ports the deltastation shuttle from ss13
features:
EVA area
medibot
fire axe
shotgun cabinet
sectec
telecomms server tuned to common
engi area has access to space (with fans)
Why / Balance

the courser was too small for the map
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl:JoeHammad

add: Fland now has its own shuttle, ported from ss13

realops

Have you checked to make sure the escape pods don’t clip into the shuttle when they launch?

Have you checked to make sure the escape pods don’t clip into the shuttle when they launch?

yes


merging PRs: PR into target, rename after

merge PRs: rename to pr/{pr_id} after merging
There are many ways to implement this behavior and this commit is the
least intrusive way.
I tried other ways as well but there was always some problem. The
presented solution seems the least prone to errors since it doesn't
change the merging process (except using original target_branch name
instead of pr/{pr_id}) and only renames the target_branch to pr/{pr_id}
after the merge is done.
This change is needed to keep the consistency in NVRs (they show up as
pr{pr_id} in the %release field).
Related to #1443 #1445

Release notes are in #1445

recheck

recheck