Structured Output Parser Always Gives Error

System Info
langchain==0.0.330
openai==0.28.1
python==3.9.17
Who can help?
@hwchase17
@agola11
Information

[X] The official example notebooks/scripts
[X] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[X] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
I have written a simple structured output parser. I am using to extract useful data from a document text. Here's my code:
import os
import logging
from dotenv import load_dotenv
from langchain.output_parsers import StructuredOutputParser, ResponseSchema
from langchain.prompts import (
    ChatPromptTemplate,
    HumanMessagePromptTemplate,
)
from langchain.llms import OpenAI
from langchain.chat_models import ChatOpenAI

load_dotenv()

response_schemas = [
    ResponseSchema(
        name="document_type", description="Type of document, typically found on top"
    ),
    ResponseSchema(name="shipper", description="Shipper name found in the data"),
    ResponseSchema(name="consignee", description="Consignee name found in the data"),
    ResponseSchema(name="point_of_origin", description="Point of origin in the data"),
    ResponseSchema(
        name="customer_order_number", description="Customer order number in the data"
    ),
    ResponseSchema(
        name="order_number", description="Order number mentioned in the data"
    ),
    ResponseSchema(
        name="bill_of_lading",
        description="Bill of lading number(B/L number) found in the data",
    ),
    ResponseSchema(
        name="carrier_name", description="Carrier name mentioned in the data"
    ),
    ResponseSchema(
        name="required_ship_date", description="Required ship date in date format"
    ),
    ResponseSchema(
        name="shipped_date", description="Shipped date, typically separated by /"
    ),
    ResponseSchema(
        name="transportation_mode", description="Transportation mode such as truck etc."
    ),
    ResponseSchema(
        name="vehicle_number", description="Vehicle number found in the data"
    ),
    ResponseSchema(name="routing_info", description="Routing info found in the data"),
    ResponseSchema(
        name="invoice_to_buyer", description="Invoice to buyer data found in the data"
    ),
    ResponseSchema(
        name="consignee_number", description="Consignee number mentioned in the data"
    ),
    ResponseSchema(
        name="net_weight",
        description="Net weight found in the data, typically found on the second page. It's a number succeeded by weight symbol such as kg/lb/1b/15/16 and ends with NT (Net weight).",
    ),
    ResponseSchema(name="ticket_number", description="Ticket number found in the data"),
    ResponseSchema(name="outbound_date", description="Outbound date found in the data"),
]

system_prompt = """
Following is the data extracted from a document through OCR wrapped inside <ocr_data> delimeter. It may be unstructured and unorganized, and you'll help me extract key information from this data. The data can be nuanced, and field and it's respective values may be at different positions. The presented data can be of multiple pages, separated by (------). Analyze the OCR data below and give me the value of given fields. If you can't find the values in the OCR data, simply return 'N/A'.
"""

class BolAgent:
    def __init__(self):
        self.openai_api_key = os.getenv("OPENAI_API_KEY")
        self.llm = OpenAI(
            openai_api_key=self.openai_api_key, temperature=0.1, max_tokens=1000
        )
        self.chat_model = ChatOpenAI(
            model="gpt-3.5-turbo-16k",
            openai_api_key=self.openai_api_key,
            temperature=0,
        )
        self.response_schemas = response_schemas
        self.system_prompt = system_prompt

    def extract_paramerts(
        self,
        ocr_data,
    ):
        output_parser = StructuredOutputParser.from_response_schemas(
            self.response_schemas
        )
        input_data = f"<ocr_data>/n{ocr_data}/n</ocr_data>"

        format_instructions = output_parser.get_format_instructions()

        prompt = ChatPromptTemplate(
            messages=[
                HumanMessagePromptTemplate.from_template(
                    "{system_prompt}\n\n{format_instructions}\n\n{input_data}"
                )
            ],
            input_variables=["system_prompt", "input_data"],
            partial_variables={"format_instructions": format_instructions},
        )

        llm_input = prompt.format_prompt(
            system_prompt=system_prompt, input_data=input_data
        )
        logging.info(f"LLM Input: {llm_input}")

        output = self.chat_model(llm_input.to_messages())
        logging.info(f"LLM Output: {output}")
        result = output_parser.parse(output.content)
        return result

When I use this code on any input data, the output parser gives error most of the time. Here's a sample input data:
\n------------------\nSTRAIGHT BILL OF LADING - SHORT FORM\nTEST\nCHEMTRADE\nFICHE D\'EXPEDITION - FORMULE REGULIERE\nS4D\nSHIPPER/EXPEDITEUR\nChemtrade West Limited Partnership\nTIME IN/ARRIVEE\nGROSS/BRUT\nCONSIGNEE/DESTINATAIRE\nSASK POWER\n TARE\nSHIP TO/EXPEDIEZ A\nCORY \nCOGENERATION STATION\nTIME OUT/DEPART\n8 KM W OF SASKATOON HWY 7\nNET\nVANSCOY SOK 1VO SK CA\nPOINT OF ORIGIN/POINT D\'EXPEDITION\nCUSTOMER ORDER NO./N DE COMMANDE DU CLIENT\nORDER NO./N DE COMM.\n3/L NO./NDE CONN.\nCHEMTRADE (SASKATOON)\nS\n1856\n80001877\n CARRIER NAME/NOM DU TRANSPORTEUR\nREQUIRED SHIP DATE/DATE EXP.DEM.\nDATE SHIPPED/EXPEDIE LE\nCARON TRANSPORT LTD\nNov 06,2023\nTRANSPORTATION MODE/MODE DE TRANSPORT\nVEHICLE T/C NO. - MARQUE DU WAGON\nTruck\n UNIVAR CANADA LTD.\n ROUTING/ITINERAIRE\nCONSIGNEE#/CONSIGNATAIRE\nPAGE\n600929\n1 of\n3\nNO.AND DESCRIPTION OF PACKS\nD.G.\nDESCRIPTION OF ARTICLES AND SPECIAL MARKS\nNET WEIGHT KG\nNBRE ET DESCRIPTION DE COLIS\nDESCRIPTION DES ARTICLES ET INDICATIONS SPECIALS\nPOIDS NET\n1 TT\nX\nUN1830, SULFURIC ACID, 8, PG II\n21.000 Tonne\nSULFURIC ACID 93%\nER GUIDE #137\n4 PLACARDS REQUIRED; CLASS 8, CORROSIVE\nSTCC 4930040\nSulfuric Acid 93%\nCOA W/ SHIPMENT\nDELIVERY HOURS: 8:OOAM-1: OOPM MON-THURS\nATTENDANCE DURING OFFLOAD REQUIRED\nSAFETY GOGGLES, FACE SHIELD, GLOVES, BOOTS, HARD\nHAT, STEEL TOED SHOES, PROTECTIVE SUIT\n3" QUICK CONNECT CAMLOCK; 1 HOSE REQUIRED\nPersonal Protective Equipment: Gloves. Protective clothing. Protective goggles. Face shield.\nnsufficient ventilation: wear respiratory protection.\nERP 2-1564 and Chemtrade Logistics 24-Hour Number >>\n1-866-416-4404\nPIU 2-1564 et Chemtrade Logistics Numero de 24 heures >>\n1-866-416-4404\nConsignor / Expediteur:\nLocation / Endroit:\nCHEMTRADE WEST LIMITED PARTNERSHIP\n11TH STREET WEST\nI hereby declare that the contents of this consignment are fully and accurately described above by the proper shipping\nSASKATOON SK CA\nare in all respects in proper condition for transport according to the Transportation of Dangerous Goods Regulations.\nS7K 4C8\nPer/Par:Michael Rumble, EHS Director, Risk Management\nIF CHARGES ARE TO BE PREPAID, WRITE OR STAMP\nJe declare que le contenu de ce chargement est decrit ci-dessus de faconcomplete et exacte par Iappellation reglementaire\nINDIQUER ICI SI L\'ENVOI SE FAIT EN "PORT-PAYE"\negards bien conditionne pouretre transporte conformement au Reglement sur le transport des marchandises dangereuses.\nPrepaid\nFORWARD INVOICE FOR PREPAID FREIGHT\nChemtrade West Limited Partnership\nQUOTING OUR B/L NO.TO:\n155 Gordon\nBaker Rd #300\nWeight Agreement\nFAIRE SUIVRE FACTURE POUR EXPEDITION PORT\nToronto,\nOnt.\nM2H 3N5\nPAYE EN REFERANT A NOTRE NUMERO DE CONN.A:\nSHIPPER\nChemtrade West Limited\nAGENT\nCONSIGNEE.\nEXPEDITEUR\nPartnership\nDESTINATAIRE\nPER\nPERMANENT POST OFFICE ADDRESS OF SHIPPER\nPER\nPER\nPAR\n(ADRESSE POSTALE PERMANENTE DE L\'EXPEDITEUR)\nTHESE PRODUCTS ARE SOLD AND SHIPPED IN ACCORDANCE WITH\nTHE TERMS OF SALES ON THE REVERSE SIDE OF THIS,DOCUMENT.\nResponsible Care\nCES PRODUITS SONT VENDUS ET EXPEDIES CONFORMEMENTAUX\nCONDITIONS DE VENTE APPARAISSANT AU VERSO DE LA PRESENTE\nOur commitment to sustainability.\nS4D PRASRNov 06,2023 1618
Upon further debugging I found that for some reason the output has two triple-backticks at the end and because of this the Structured Output Parser ends up giving the error. Here the output for better clarity (Notice the end of output):
content='```json\n{\n\t"document_type": "STRAIGHT BILL OF LADING - SHORT FORM",\n\t"shipper": "Chemtrade West Limited Partnership",\n\t"consignee": "SASK POWER",\n\t"point_of_origin": "VANSCOY SOK 1VO SK CA",\n\t"customer_order_number": "80001877",\n\t"order_number": "1856",\n\t"bill_of_lading": "600929",\n\t"carrier_name": "CARON TRANSPORT LTD",\n\t"required_ship_date": "Nov 06,2023",\n\t"shipped_date": "Nov 06,2023",\n\t"transportation_mode": "Truck",\n\t"vehicle_number": "T/C NO.",\n\t"routing_info": "UNIVAR CANADA LTD.",\n\t"invoice_to_buyer": "Chemtrade West Limited Partnership",\n\t"consignee_number": "600929",\n\t"net_weight": "21.000 Tonne",\n\t"ticket_number": "N/A",\n\t"outbound_date": "N/A"\n}\n```\n```'
I have started to notice this error at high-frequency after OpenAI dev day. Any idea what I might be doing wrong?
Expected behavior
The output should only have one triple-backticks at the end and the output parser should parse the output properly.

@dosu-bot Thanks for the analysis but that doesn't solve my problem. Since I am using standard output parser from langchain, I am not sure how can I address this issue.


add title elements to SVGs

optional  tag for SVGs
improves accessibility

I created this PR to improve the accessibility of the SVG icons by adding a title element

Hey @cleaver, thanks for contributing!
The outline.ex + solid.ex files are actually auto generated by a mix command - see generate.ex. So if you'd like to modify outline/solid you will need to modify the generate.ex file and then run these commands to generate:
# in petal_components root
git clone https://github.com/tailwindlabs/heroicons.git
mix heroicons.generate

Since the svgs are copied over from the heroicons library - you will have to do either a String.replace or maybe use https://github.com/philss/floki or something to get the title attribute in there. Hope this all makes sense

Cool, makes sense. I'll have a look at the best way to do that.

I went with the regex rather than adding a dependency. Seems to do the job.

I haven't added anything to documentation. I see the generated documentation, but it looks like the website is private. Is that right?
If the PR looks OK to you so far, I was thinking to just add a line to the example code in the moduledoc, unless you were thinking of a way to improve on that.

Looks good. Yeah, we will handle the documentation.
The only thing is that we may introduce other icon libraries in future. So PetalComponents.Heroicons.Attributes might be better as just PetalComponents.Svg. As `<Svg.title title="Home" /> makes sense and can be used with other svg icons libs.

Thanks - hmm is the file size resulting in a big problem when you deploy? I haven't seemed to notice a problem deploying to fly.io at least. I think unless it's truly painful, it's not worth introducing another step.

Thanks - hmm is the file size resulting in a big problem when you deploy? I haven't seemed to notice a problem deploying to fly.io at least. I think unless it's truly painful, it's not worth introducing another step.

I've been thinking about this over the weekend and it does seem a bit over-complex. I don't think it would be an issue at run time. File under premature optimization. :)


[C#] The native method "grpcsharp_slice_buffer_create" does not exist

What version of gRPC and what language are you using?
2.23.1 & 2.24.0
What operating system (Linux, Windows,...) and version?
Windows 10 v1803
What runtime / compiler are you using (e.g. python version or version of gcc)
MSBuild VS 2019 (16.3.5)
What did you do?
I tried to have a library targeting the minimum version possible (2.23.1) and an application overwriting the target to latest version possible (2.24.0).
What did you expect to see?
The application should start. All Grpc DLLs (managed + unmanaged) should be from 2.24.0.
What did you see instead?
**System.MissingMethodException:** The native method "grpcsharp_slice_buffer_create" does not exist
When checking the DLLs, the windows native DLLs are not correctly copied.
This image shows, that when only targeting 2.23.1 (left, test-23) and 2.24.0 (right, test-24) without changing the version in the app, all files are different.

The output of 2.24.0 (app) over 2.23.1 (lib) looks like here on the left. The only files matching with 2.23.1 are the windows files.

The output of 2.24.0 (app) over 2.23.1 (lib) again on the left. The only files NOT matching with 2.24.1 are the windows files.

So there seems to be a bug, that the windows libraries are not taken from the correct version. The Linux libraries are taken from the correct version. So there might be a bug in the NuGET script. I sadly don't know enough about NuGET to look further for the reason why this appears.
Anything else we should know about your project / environment?
This bug was already discovered by another user in #19211 but not followed up. Having different version in library and application is common, so this should be fixed to always work.
This occured on https://github.com/opentracing-contrib/csharp-grpc/tree/Falco20019/updated-dependencies but I also made a minimal example at https://github.com/Falco20019/test-net461-bug

I assume the problem is PreserveNewest. 2.23.1 is newer than 2.24.1
But the .so and .dylib files would also be newer and were replaced by the same target.


remove mentions of ontobio

addresses #2422

this file can't be opened in Protege, I am going to try this again.


Support higher-order interpolation

Allow multiple axes with the same tag. All but one must be hidden. This permits higher-order interpolation without requiring spec changes. This is the FontTools edition of harfbuzz/harfbuzz#1673.

Well, it doesn't "permit" it, currently the behavior of engines is undefined (some accidentally perform HOI). There is nothing nowhere about "all axes but one must be hidden", that's anecdotal and by no means supported by any spec.
But there is some early consensus that multiple same-tagged axes are permissible.

I ran into this issue while writing https://bungeman.github.io/hoi.html . In the font itself axes are referred to by index, and in fvar axes have-a tag.
The idea is that at the API level if a user sets a variation value for a given axis tag then all axes with that tag should be set with that value (though if the axes have different min and max values that value may be clamped to different values). This is more or less what all modern implementations do.
Hiding axes isn't really necessary here, though APIs and UIs will need to be aware of the difference between an axis tag and an axis index. Generally one would probably want to mark all but one axis with a given tag as hidden for sanity and backward compatibility. If the API or UI is based on axis tag and shows two sliders both associated with the same axis tag which should it use to set the value? However, there shouldn't be any limitation in FontTools around this since it should be general purpose where it can be.
I propose a  (like ) which could be used in an   tag. If present the axis id would be the content of , if not the the axis id would be the content of . Then the axis id would be used to specify an axis in all the places the axis attribute is used. When converting a font file to ttx the first axis with a given tag would just be given an id which matches the tag, subsequent axes with the same tag would be given an id like 'axis#1'. This is nicely backward compatible and shouldn't be too difficult to implement.

I was thinking along the same lines, except that I think we don't need a formal definition for <AxisID>.

upon writing fvar, if len(axisTag) > 4, strip the rest. (Perhaps requiring that `axisTag[4] == "#", but nothing more.)
upon reading fvar, append #N to the tags that exist multiple times, where N increments for each additional duplicate.

https://bungeman.github.io/hoi.html

BTW., excellent write-up! Thanks for sharing.

I was thinking along the same lines, except that I think we don't need a formal definition for <AxisID>.

upon writing fvar, if len(axisTag) > 4, strip the rest. (Perhaps requiring that `axisTag[4] == "#", but nothing more.)
upon reading fvar, append #N to the tags that exist multiple times, where N increments for each additional duplicate.

I actually started writing this as a proposal and instead went with <AxisID>. Something like <AxisTag>axis#1</AxisTag> means parsing the axis tag string and giving the string double duty: the first four chars are the axis tag (a category), but the whole thing is the id. While I can't think of a good reason this isn't the only possible way to parse the string it does mean that it needs to be parsed. Instead, allowing <AxisID id="1" name="usedForSquare" /> (with the comment <!-- The 'id' attribute is only for humans; it is ignored when parsed. --> makes it more obvious that this is an arbitrary name which identifies an axis uniquely (corresponds to the index used in the font file) while the <AxisTag> is more of a category the axis is in (since in the font file an axis has-a tag; the axis tag isn't the id of the axis but a category the axis is part of). <AxisID> could also surface the original order of the axes in the same way the <GlyphOrder> <GlyphID> does. In short, I wanted to avoid making the axis tag string do double duty. While doing double duty works technically, it can lead to incorrect mental models about how things work. I would prefer that <AxisTag> always be exactly the axis tag and the ttx metadata about how to internally refer to a specific axis be separate.
That being said, <GlyphOrder> is a little strange in that the <GlyphID>' stuff could have gone on the directly (thenameattribute already is there, just needs theidattribute). A simpler approach than theproposal (and one which allows clean separation between data and metadata) could be to allowanameattribute (and possibly anidattribute). On serializing ttx to font file if present thenameattribute would be the axis id, if not present the axis id would be the(for backward compatibility); anyidattribute would be ignored. It would be an error for two axes to have the same id. On parsing a font file to ttx the generatednameattribute could look likeaxis#1, with the id` attribute set to the index of the axis in the font file.


api: define common error message payload

What this PR changes/adds
Extracts an ApiErrorDetail class and use it to describe api call errors to the clients
Why it does that
To have an unique and shared way to describe details for failing requests
Further notes

I applied it to all the data-management apis, I wonder if it could be used to describe other api failures as well (as data-plane ones).
remove unused (and "illegal") http dependency from auth-spi module.
make AssetService.query return a ServiceResult, this slipped off from #1657
make all the exceptions that are going to be thrown in the filter/controllers extend EdcApiException and add a getType method on them to improve the result detail

Linked Issue(s)
Closes #1490
Checklist

[x] added appropriate tests?
[x] performed checkstyle check locally?
[x] added/updated copyright headers?
[x] documented public classes/methods?
[x] added/updated relevant documentation?
[x] added relevant details to the changelog? (skip with label no-changelog)
[x] formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

Codecov Report

Merging #1705 (5449bc4) into main (c38d744) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1705      +/-   ##
==========================================
+ Coverage   67.84%   67.89%   +0.04%
==========================================
  Files         784      784
  Lines       16797    16816      +19
  Branches     1065     1066       +1
==========================================
+ Hits        11396    11417      +21
+ Misses       4932     4930       -2
  Partials      469      469

Impacted Files
Coverage Δ

...r/api/datamanagement/asset/AssetApiController.java
97.72% <100.00%> (+0.22%)
:arrow_up:

...datamanagement/asset/service/AssetServiceImpl.java
100.00% <100.00%> (ø)

...econnector/extension/jersey/JerseyRestService.java
94.59% <100.00%> (+0.15%)
:arrow_up:

...extension/jersey/mapper/EdcApiExceptionMapper.java
100.00% <100.00%> (ø)

...nsion/jersey/mapper/ValidationExceptionMapper.java
100.00% <100.00%> (ø)

...e/dataspaceconnector/api/ServiceResultHandler.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c38d744...5449bc4. Read the comment docs.


add an event when the bot is invited into a room

When others join in the room, it can emit 'room-join' event, but when the bot is invited to a room, we don't have any event.
So I suggested to add an event when the bot is invited to a room.
Maybe we can still  use room-join event.
Sys Message as follows:

"李佳芮"邀请你加入了群聊，群聊参与人还有：洁云微商、感觉、逗比
“李佳芮”invited you to a group chat with 独留一人、于、DEE

Thanks, this event should be included in the room-join event(and `join event for Room).
PR is welcome!

Moved to puppet puppeteer repo for more specific tracking.


merge from arlac77/npm-package-template-esm-only

LICENSE

chore(license): add year 2020

:tada: This PR is included in version 2.0.13 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Figure out the best way to include multiple example pages in this single repo

I want this repo to include three different example pages:

Top nav (current) layout w/ a web map
Side bar layout (see #24) that loads the map from individual layers in the config. This would also be the one that we'd include the configuration/instructions to do a Dojo Build
A dashboard layout based on something like http://keen.github.io/dashboards/examples/sfmta-parking/

I need to figure out what is the best way to include all 3 in the single repo. I can think of two different ways, both involve multiple top level documents (i.e. index.html, sidebar.html, dashboard.html, etc). The question is whether the supporting files (the different config, controllers, and layouts) for each of those all reside under the same application (package) or separate applications/packages:
Same Application:
└───src
    │   dashboard.html
    │   index.html (would default to the current, top nav layout)
    │   sidebar.html
    │   unbuilt.html (would be an un-built configuration of the side bar layout)
    │
    └───app
        │   dashboardConfig.js
        │   dahsboardController.js
        │   sidebarConfig.js
        │   sidebarController.js
        │   topnavConfig.js
        │   topnavController.js
        │
        ├───layout
        │   │   Dashboard.js
        │   │   SideBar.js
        │   │   TopNav.js
        │   │
        │   ├───nls
        │   │
        │   └───templates
        │           Dashboard.html
        │           SideBar.html
        │           TopNav.html
        │
        ├───mapping
        │   │   Map.js
        │   │
        │   └───templates
        │           Map.html
        │
        └───resources
                app.css
                main.css

Different Applications (packages)
└───src
    │   dashboard.html
    │   index.html (would default to the current, top nav layout)
    │   sidebar.html
    │   unbuilt.html (would be an un-built configuration of the side bar layout)
    │
    ├───DashboardApp
    │   │   config.js
    │   │   Controller.js
    │   │
    │   ├───layout
    │   │   │   Dashboard.js
    │   │   │
    │   │   ├───nls
    │   │   │
    │   │   └───templates
    │   │           Dashboard.html
    │   │
    │   ├───mapping
    │   │   │   Map.js
    │   │   │
    │   │   └───templates
    │   │           Map.html
    │   │
    │   └───resources
    │           app.css
    │           main.css
    ├───SidebarApp
    │   │   config.js
    │   │   Controller.js
    │   │
    │   ├───layout
    │   │   │   SideBar.js
    │   │   │
    │   │   ├───nls
    │   │   │
    │   │   └───templates
    │   │           SideBar.html
    │   │
    │   ├───mapping
    │   │   │   Map.js
    │   │   │
    │   │   └───templates
    │   │           Map.html
    │   │
    │   └───resources
    │           app.css
    │           main.css
    └───TopNavApp
        │   config.js
        │   Controller.js
        │
        ├───layout
        │   │   TopNav.js
        │   │
        │   ├───nls
        │   │
        │   └───templates
        │           TopNav.html
        │
        ├───mapping
        │   │   Map.js
        │   │
        │   └───templates
        │           Map.html
        │
        └───resources
                app.css
                main.css

I'm leaning towards the different packages approach b/c it's unlikely that anyone would use multiple layouts/configs, etc w/in the same app, which would make any one of the individual apps a better starting point for someone than a single app that has them all. The problem w/ that is the duplication of the map widget in each app. That could be resolved by make it it's own package at the same level as the apps.
I'm curious if @tsamaya or any other users of this repo have thoughts on which folder/package structure would make the most sense.
Thanks!

Hi Tom,
For my money, different packages would be the best way to go. Let the users pick an app and delete the others if necessary. This way they can remove the cruft easily.

Thanks @npeihl!
That's how I'm leaning too.

Hi Tom and Nick,
regardings apps, I agree, diffrents apps : it is easier to delete unecessary fodlers.
But regarding maintaining source files, I think it is easier to have only one app folder. For the demos, and the gh-pages the index.html may explain the diffrents sample and point then on dashbord, simpleTopNav and the sidebar sample, in each sample diffrent config files could be injected.

Thank you @tsamaya and @npeihl for your thoughts.
I ended up deciding to implement this in a separate repo, see:
http://tomwayson.github.io/responsive-citizens/dashboard.html
https://github.com/tomwayson/responsive-citizens

This is really nice !
you should put a link on the dojo-bootstrap-map-js readme.md as a sample implementation !

Thanks @tsamaya - that was my demo for DevSummit. I thought I already had added a link to the README, but I guess that slipped through the cracks.

I was think about something like that :
https://github.com/tsamaya/dojo-bootstrap-map-js/commit/b6fd92d994bff8ecef57fefea33dd3e043056a68#diff-04c6e90faac2675aa89e2176d2eec7d8
2015-03-20 15:20 GMT+01:00 Tom Wayson<EMAIL_ADDRESS>
Thanks @tsamaya https://github.com/tsamaya - that was my demo for
DevSummit. I thought I already had added a link to the README, but I guess
that slipped through the cracks.
—
Reply to this email directly or view it on GitHub
https://github.com/Esri/dojo-bootstrap-map-js/issues/65#issuecomment-84030078
.


Revamping ideas

Don't have bossfights, but make the level really difficult, and with reaching the end, you get a new mechanic and you will need to use that mechanic in the next level (downside, we'll need to think of those and have that be somehow be reflected in the randomized design of the map)
Have a backstory and have mechanics that explain that story throughout the world, like books you can read, posters and signs you can read, conversations that you can overhear (with your superhearing)
Abilities with a visible cooldown period, for example a special jump/run that makes you jump a couple blocks, but you need to save it until you really need it because you can do it only every hour and time is ticking away

Sunlight prevents use of (certain) abilities.

Empty tiles in between occupied tiles (like buildings) have shadow cast on them, i.e. block sunlight and allow abilities.

A powerful enough vampire character is allowed to 'recruit' up to 3 Ghouls, starting with 1.
Ghouls are made by giving a mortal victim some of your blood. A blood tax is created and at certain point your Ghouls will need to recoup their strength by taking some of their masters blood.

Ghouls are not controlled directly but operate in the background and can be given a couple of tasks to complete while the master is doing their own thing. They will steal things, gather information, or capture someone for their master to drink/eat.

Sunlight prevents use of (certain) abilities.

Hm right. I was initially thinking about sunlight just killing you, so there's a time aspect to the game. If you don't get on in time, it's game over. But there's of course the moments of sunrise and things blocking the sun, so there's definitely room for this, I think.

Empty tiles in between occupied tiles (like buildings) have shadow cast on them, i.e. block sunlight and allow abilities.

Yes, good idea

A powerful enough vampire character is allowed to 'recruit' up to 3 Ghouls, starting with 1.

Sounds cool, like a necromancer

Ghouls are made by giving a mortal victim some of your blood. A blood tax is created and at certain point your Ghouls will need to recoup their strength by taking some of their masters blood.

Ahh yes

Ghouls are not controlled directly but operate in the background and can be given a couple of tasks to complete while the master is doing their own thing. They will steal things, gather information, or capture someone for their master to drink/eat.

Sounds like a lot of AI to write though.
I would be more into taking control of the ghouls body and doing things, but then the question arises; why wouldn't you just do it yourself?

I was thinking that it wouldn't really be animated except for in a special screen where you can track what they're up to. Which would be just 3 profile shots of the people you ghoulified. So it would be just numbers going up in the background, with a chance for authorities to spawn in the masters vicinity. They followed one of your henchlads while they was criming.

Ahh interesting

xD

We might want to have a Wanted/Reputation/Influence meter that dictates how many law enforcement or other enemies can spawn.

Figure out if we want drained victims to be actually dead or just replaced with a almost bloodless husk of a person that sort of recuperates over time.  Killing them doesn't seem super lore-friendly to me but should probably be an option.

If a potential victim is not alone (there's at least one other person in a nearby tile) you cannot feed on them and they need to be lured away? This would emphasize the feeling of hunting and stalking. It would also give a lot of options for special abilities. Seducing, ambushing, mind controlling, that sorta thing.


User interface and experience improvements for Teams page

Acceptance Criteria: #63
The improvements for this page is not completed yet (need go sleep now), but the PR can be merged.

Current status:

Admin menu will be placed below the page title and styles will be improved in #61

I like the loading screen, but maybe we could use a image of a world that would have real colors like our map? there wouldn't be so much contrast.
Another thing: have you checked if the images you used can be used freely in our project?

worldmap.png is not used. please remove

The (R) character next to X-Team in the loading screen is rather small, therefore X-Team string does not look like it was centered, but more like left-aligned. Any change you could make it look more centered?

I'd show some more information, not just avatars. Some users might not have avatars set, so you'd see the default one multiple times. And even if they do have avatars, you'd need to know people's faces/avatars to be able to tell who is who on the list. I'd made it more look like a list and display the avatar + first/last name at least, maybe slackId as well, as that's what people see all the time in Slack. So it's more likely that people would find slackId more familiar than first/last name :)

Hey @jedrzej, I made all changes in js files. About change design stuff, I'd suggest to dont make this as a blocker for PRs unless it's a regression, we can keep improving until have some art direction. If you want to take a look, I found images here http://www.freepik.com/, suggestions are welcomed. :)
Need to end the day and wait other timeframe for next changes, so feel free to merge if this represent merge conflict. I want to focus my time to finish the display of the components, about the content and further improvements, let's move discussions in the issues #59 and #63, the main important piece of information missing is what exact data and elements we want to fit in each of these pages.
About #57, if you want to take that, all yours, I like your suggestions, just comment about what changes to update in the AC.
Thanks!


add link to https://learn.microsoft.com/en-us/azure/aks/outbound-rules-control-egress on https://learn.microsoft.com/en-us/azure/aks/limit-egress-traffic

Please add a link to https://learn.microsoft.com/en-us/azure/aks/outbound-rules-control-egress on this page for a detailed reference of what fqdn is required. For some reason search engine favors this page over the outbound rules page, but this page only gives vague entries.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ab53ab25-92d7-ffc9-be5c-16ea5aff52ea
Version Independent ID: 82d1240f-f358-7731-d308-4003cefc28c8
Content: Use Azure Firewall to protect Azure Kubernetes Service (AKS) clusters
Content Source: articles/firewall/protect-azure-kubernetes-service.md
Service: firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

@tdihp , thank you for your feedback. We'll review this and get back to you shortly!

@tdihp , We have assigned this to the content owner/author for review.
@vhorne , for your review.

done
#please-close


Update authorized user in blossom-ci whitelist [skip ci]

Update Github ID (winningsix) into blossom-ci whitelist allowing triggering spark-rapids build by commenting "build"
Old one (winningsixnv) was deprecated.

build


Improving the Footer UI

Description
The current Footer UI can be improved with better visuals and more interactive places that can help the user meet their project ends. Therefore I would like to take up this feature where I can improve the current build.
An example can be viewed below:
Basic Example

Can i work on this issue?

What is expected to does means does you any design for footer you want

Basically, I will build a design that can be cleaner and can have a better visual appeal to the user. Moreover, there can be more interaction with the footer as it contains many important details of any webpage.
Therefore, I will research more up on the design and build the code for that.

So @bieefilled can you assign this to me?

What kind of reusable-component do you need for the existing project, do you have something in mind?

I can work with Forms if that's cool with you, if yes you can assign it to me?

Then I can also rename the issue-name as well.


provide CorrelationID and timestamp after publish

Hi, Andrè.
We need the CorrelationID and Timestamp when we trigger a new event, e.g. B. for tracking.
Kind regards,
Beppo

Hi Beppo!
I've got to admit, I am not a huge fan of a signature change here. I do however see the validity of your request so my suggestion would be to extend the OutgoingMessageContext with an array of "OnPublished" functions where you can add your callbacks for whatever you need to be done after a publish. It could look like this:
endpoint.Message("MyMessage")
    .AsOutgoing()
    .OnPublished(myTrackingHandler)

func myTrackingHandler(ctx *serviceBus.OutgoingMessageContext) {
    //execute whatever after a message has been published
}

Might not be a final solution, but I think this is more versatile and cleaner than changing the signature of the publish functions.
Are you okay with that change? How urgently do you need this to happen? We can also move this discussion to Discord, if you like.
André

Hi.
I discussed it with the team and we decided on a different solution.
But you should know that we are planning a major changes, which is why we will come up to you again.
Beppo

Sure thing! Let me know if I can be of any assistance.


Fix 'cutsio' cheat to correctly force a cutscene

Currently there are times when the 'cutsio' cheat finds a cutscene with no particular chefs/customers -- but then does not force the chefs to fit that cutscene, so the cutscene still does not play.
In other words, the 'cutsio' cheat detects or enqueues a general cutscene where the player talks to the chef. But then that cutscene cannot play, because all levels have specific chefs.

The 'quirky customer' cutscene logic appears to fix this bug, or at least makes it much harder to reproduce.


How to treat pixels that never reach theshold GDD?

Currently these are NAs, but they aren't really "missing" per se.  Also, points that have these NAs for any year are currently excluded from the pixel-wise regressions (#27).
Things to try/consider:

Code these as Inf (and squish oob values in color scale on maps)
Code these as 365
Do regressions with at least x number of non-NA values

If I choose the third option (only keep pixels were at least x years reach the threshold), it turns out my choice of "x" is very consequential to the range of slopes calculated for the region.

From Theresa:

let's only fit a line if we have DOYs in at least half of the years with data, does that seem reasonable? I don't think we should convert them to 365, I think years where a threshold isn't met should be left as NA for those pixels/years.

Going to close for now.  We can always tweak the % of pixels that need to be non-NA to fit a line.


Argument parsing conflicts with Marian arguments

We use both Marian yaml configuration files and command line arguments and it appears that argparse conflicts with some Marian arguments. For example, I cannot use Marian --log  argument.
Here is how we integrate OpusTrainer in the Firefox training pipeline: PR
Command:
opustrainer-train
  --config /data/rw/evgeny/models/ru-en/opustrainer/student/config.opustrainer.yml
  -d
  --log-file /data/rw/evgeny/models/ru-en/opustrainer/student/opustrainer.log
  --log-level INFO
/data/rw/evgeny/firefox-translations-training-ci/3rd_party/marian-dev/build/marian
  --model /data/rw/evgeny/models/ru-en/opustrainer/student/model.npz
  -c configs/model/student.yml configs/training/student.train.yml
  -T /data/rw/evgeny/models/ru-en/opustrainer/student/tmp
  --vocabs /data/rw/evgeny/models/ru-en/better-teacher/vocab/vocab.spm /data/rw/evgeny/models/ru-en/better-teacher/vocab/vocab.spm
  -w 8000
  --devices 0 1 2 3 4 5 6 7
  --log /data/rw/evgeny/models/ru-en/opustrainer/student/train.log
  --valid-metrics chrf ce-mean-words bleu-detok
  --valid-sets /data/rw/evgeny/data/ru-en/ci/original/devset.ruen.tsv
  --valid-translation-output /data/rw/evgeny/models/ru-en/opustrainer/student/devset.out
  --valid-log /data/rw/evgeny/models/ru-en/opustrainer/student/valid.log
  --shuffle batches
  --sentencepiece-alphas 0.1
  --no-restore-corpus
  --sharding local
  --sync-sgd
  --quiet-translation
  --overwrite
  --keep-best
  --tsv
  --disp-freq 1
  --save-freq 5
  --valid-freq 10
  --after 10u
  --dim-vocabs 1000 1000

Error:
usage: opustrainer-train [-h] --config CONFIG [--state STATE] [--sync] [--temporary-directory TEMPORARY_DIRECTORY] [--do-not-resume] [--no-shuffle] [--batch-size BATCH_SIZE] [--chunk-size CHUNK_SIZE] [--workers WORKERS] [--log-level LOG_LEVEL] [--log-file LOG_FILE] ...
opustrainer-train: error: ambiguous option: --log could match --log-level, --log-file

Wait am I not using https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_known_args ? I should and will fix that if I don't already.
Separating opustrainer args and the marian command with -- should also work.

-- doesn't work either. I made it work with this fix as a workaround. I can create a PR but maybe using parse_known_args would be a better approach.

 Mind if I just pull that in, add a couple of tests, and merge that in main?

sure, thanks!

Unfortunately your fix didnt' seem to work in all scenarios, prefix matching was still being annoying. Disabling prefix matching did the trick for me. I added tests for it as well now.


disable unconstrained_1cq test

https://github.com/grpc/grpc/issues/11500

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences


Fix markup broken since cache related changes

@graceguo-supercat I mentioned this when we spoke today. It needs to be bundled along other caching-related changes

🚢

@mistercrunch I believe this PR may have introduced a regression. We now see No data for a query where the table no longer exists, whereas previously we would have seen something of the form,
line 5:9: Table <cluster>.<schema>.<table> does not exist

which is more informative.

Also seeing the general no data message when we previously would have seen line 10:7: Column '<column name>' cannot be resolved which is helpful in debugging the problem.

We should add a unit test that covers that proper error message.

@mistercrunch would you mind proving more context for the reason of this PR so we can further debug and provide a fix with the appropriate unit tests.


Adds fact about machine's RAID Controller

This adds a small fact to read out machine's raid controllers.
We use it to check RAID Controller on host and install the matching utils.
We also feed our nagios raid check with information from it.

I like more this approach:
https://github.com/kumina/fact-pci_devices/blob/master/pci_devices.rb
This could be easily modified to detect any other devices (RAID, InfiniBand, GPU cards etc.)
I'm commenting on this patch only because I'm solving previous problem (module for nvidia, infiniband etc.) right now and don't want to replicate lspci parsing code between independent modules. I would like to see a generic lspci parsing code in Facter::Util:: reused in a device specific facter utils (raid.rb, ib.rb etc). This is just my idea, dont' know if it's good approach.

Yeah, that would be nice. The pci_devices.rb is a good start also.
I will take a look if I can start with that Facter::Util thingy! Thanks! The other approach would be a gigantic pci_devices_do_it_all.rb thingy, which nobody wants to see, indead!

Hi @LarsFronius - thanks for the submission - can you please raise a ticket on this if one doesn't already exist:
http://projects.puppetlabs.com/projects/facter
So we can track the requirement? (versus just the code submission).
You'll need to reference the ticket in any commit messages. Also - be aware that any code we accept will require rspec tests to be added before it can go into core.


[5.7] Remove loose comparisons

As suggested in https://github.com/laravel/framework/pull/25251#issuecomment-414090792, we should get rid of loose comparisons in the next version of Laravel.
This PR remove the ones that we know the return from sure:

count, pcntl_waitpid: int
trim, strtolower, realpath: string
DIRECTORY_SEPARATOR: string

There is no point in doing strict comparisons against count. It ALWAYS returns int. Changing all of those just ends up creating other potential merge conflicts.


Update to vue3

MEMO

[x] Fix warn errors
[x] Fix bugs (app doesn't work)
[x] Operation check

close https://github.com/bmf-san/gobel-admin-client-example/issues/33


Make indexing possble in ordered vector

DSPEC Parser should be able to take an optional configuration in the ordered vector section that allows indexing of a range of the series instead of just appending the whole Series.
Input Gatherer should read the above configuration and preform the indexing and appending operation correctly.

This needs tests, unfortunately I did not push it on my home computer, Sorry!


Updated migrate-from-mysql.md file

This P.R fixes issue number #8449

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/3b65d631384426af78ea9d2e5c4113a33e2e6cda/
Edited pages:

v19.1/migrate-from-mysql.md
v19.2/migrate-from-mysql.md
v2.1/migrate-from-mysql.md
v20.1/migrate-from-mysql.md
v20.2/migrate-from-mysql.md

@UdokaVrede Thank you for contributing to CockroachDB this year. As a token of our appreciation, we would like to send you a gift. Please DM me on our community Slack @Amruta so I can send you a link. (If you don’t want a gift, we also have a charitable contribution choice.) All orders need to be in by December 13, so please contact me as soon as possible :)


Waltz 3329 emp count

#3329

This pull request introduces 1 alert when merging 5dbbacb4e44df3dcb56670ba520a650da445ad20 into 44fc2add202b8579782fba5d6aa7b71669d55f59 - view on LGTM.com
new alerts:

1 for Superfluous trailing arguments

Comment posted by LGTM.com


feat: add api key support

Add API key support. There are two ways to provide the API key, either by setting GOOGLE_API_KEY environment variable, or setting apiKey option in GoogleAuth constructor. GOOGLE_API_KEY and GOOGLE_APPLICATION_CREDENTIALS are mutually exclusive so providing both will cause an exception.
The code has been tested with the sample in this PR.

@bcoe please take a look, thanks!


Add missing XML documentation to Bot.Builder.Dialogs.Adaptive/Recognizers

Address # 4321
Description
This PR adds the missing XML documentation to all visible classes, methods, properties, and parameters in Bot.Builder.Dialogs.Adaptive/Recognizers, removing 104 errors.
Note: the NoWarn-CS1591 property is removed in the last PR of the series adding the documentation to avoid build failures.
Specific Changes

Adds all missing documentation instances to all .cs files found within Microsoft.Bot.Builder.Dialogs.Adaptive Recognizers directory.

Testing
Below you can see the number of errors shown before and after the changes when de NoWarn-CS1591 property is removed.

Promoted


Test Norse with Cbc and GLPK and conditionally with SCIP

Pull request details
Describe the changes made in this pull request
Remove SCIP.
Test Norse with Cbc and GLPK as well.
List of related issues or pull requests
Closes #378
Collaboration confirmation
As a contributor I confirm

[x] I read and followed the instructions in README.dev.md
[x] The documentation is up to date with the changes introduced in this Pull Request (or NA)
[x] Tests are passing
[x] Lint is passing

Needs to be rebased after #379

Hi @abelsiqueira,
Cbc and GLPK are good enough for the testing in the GitHub actions. It is a pity that SCIP can't be used for testing in Windows. Is it possible to set up the GitHub action to test SCIP only for Linux and Mac?

It is possible, but it would be a bit ugly. Something like:

Create a EXTRA_SOLVERS environment variable in the actions storing the package/solver pairs.
Install the packages in the action
In the test code, get the packages and using them
In the test code, get the solvers and loop through them

It would change things in four places, so I would not recommend just to test SCIP.
However, it might be useful in the future to also run tests on the server/remote machine that has the proprietary solvers, and in that case we might want to run the tests with the proprietary solvers as well. Assuming it will be a Linux machine, we can also test SCIP.
If that is feasible, we can create an issue for that.

Great! Thanks for the explanation. Having the option of testing on "server/remote machine that has the proprietary solvers" is good for the future since we will use Xpress, and then we also might want to test that using one of our machines. So, let's go forward without SCIP and use Cbc and GLPK instead.


Implement DeleteCompanyCommand

Since I am doing #61 , might as well implement for Company.

Was already implemented, apologies.


Ubuntu: Install docker-ce instead of docker-engine?

Folks; is there a default way to make sure (on Ubuntu 16.04) docker-ce instead of docker-engine is being installed?
Thanks,
Kristian

This module has been forked and officially taken over by the puppet team.  This specific repo hasn't been updated in over a year so you really should use that instead:
https://forge.puppet.com/puppetlabs/docker


Not building in Linux

The README.MD instructions are clear enough to be followed. I am however getting this error below when compiling from within eclipse.
Building file: ../lv_drivers/win32drv/win32drv.c
Invoking: Cross GCC Compiler
gcc -I"/mnt/ext4data/git/pc_simulator_sdl_eclipse" -O0 -g3 -Wall -c -fmessage-length=0 -Wall -Wmaybe-uninitialized -MMD -MP -MF"lv_drivers/win32drv/win32drv.d" -MT"lv_drivers/win32drv/win32drv.o" -o "lv_drivers/win32drv/win32drv.o" "../lv_drivers/win32drv/win32drv.c"
In file included from ../lv_drivers/win32drv/win32drv.c:10:
../lv_drivers/win32drv/win32drv.h:17:10: fatal error: ../lv_drv_conf.h: No such file or directory
17 | #include "../lv_drv_conf.h"
|          ^~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [lv_drivers/win32drv/subdir.mk:20: lv_drivers/win32drv/win32drv.o] Error 1
"make all" terminated with exit code 2. Build might be incomplete.
any comments?

seems this is related to issue 90 (https://github.com/lvgl/lv_sim_eclipse_sdl/issues/90) I followed his suggestion and the project compiles okay now.

Does it work if you manually pull  lv_drivers?

Hi. thank you for getting back to me. Still encountering the same problems. I mainly just removed --recursive and do manual update per submodule. The log for lv_driver below.
pci@pci-G3-3579:~/work/git/lv_sim_eclipse_sdl$ git submodule update --init lv_drivers
Submodule 'lv_drivers' (https://github.com/littlevgl/lv_drivers.git) registered for path 'lv_drivers'
Cloning into '/mnt/ext4data/git/lv_sim_eclipse_sdl/lv_drivers'...
Submodule path 'lv_drivers': checked out '8c96359f4199297809ab205870eb603b03d98b4e'

Please try going into the lv_drivers directory and running git checkout master followed by git pull.

@embeddedt I did exactly what you said (working from a fresh clone) and encountered an entirely different problem now. please see log of actions below:
pci@pci-G3-3579:~/work/git$ git clone --recursive https://github.com/littlevgl/pc_simulator_sdl_eclipse.git
Cloning into 'pc_simulator_sdl_eclipse'...
remote: Enumerating objects: 132, done.
remote: Counting objects: 100% (132/132), done.
remote: Compressing objects: 100% (105/105), done.
remote: Total 1343 (delta 71), reused 77 (delta 27), pack-reused 1211
Receiving objects: 100% (1343/1343), 3.01 MiB | 477.00 KiB/s, done.
Resolving deltas: 100% (727/727), done.
Submodule 'lv_drivers' (https://github.com/littlevgl/lv_drivers.git) registered for path 'lv_drivers'
Submodule 'lv_examples' (https://github.com/littlevgl/lv_examples.git) registered for path 'lv_examples'
Submodule 'lvgl' (https://github.com/littlevgl/lvgl.git) registered for path 'lvgl'
Cloning into '/mnt/ext4data/git/pc_simulator_sdl_eclipse/lv_drivers'...
remote: Enumerating objects: 46, done.
remote: Counting objects: 100% (46/46), done.
remote: Compressing objects: 100% (40/40), done.
remote: Total 1385 (delta 17), reused 22 (delta 6), pack-reused 1339
Receiving objects: 100% (1385/1385), 355.81 KiB | 216.00 KiB/s, done.
Resolving deltas: 100% (900/900), done.
Cloning into '/mnt/ext4data/git/pc_simulator_sdl_eclipse/lv_examples'...
remote: Enumerating objects: 1303, done.
remote: Counting objects: 100% (1303/1303), done.
remote: Compressing objects: 100% (569/569), done.
remote: Total 12862 (delta 895), reused 1015 (delta 720), pack-reused 11559
Receiving objects: 100% (12862/12862), 116.88 MiB | 519.00 KiB/s, done.
Resolving deltas: 100% (9043/9043), done.
Cloning into '/mnt/ext4data/git/pc_simulator_sdl_eclipse/lvgl'...
remote: Enumerating objects: 46091, done.
remote: Total 46091 (delta 0), reused 0 (delta 0), pack-reused 46091
Receiving objects: 100% (46091/46091), 39.81 MiB | 614.00 KiB/s, done.
Resolving deltas: 100% (36694/36694), done.
Submodule path 'lv_drivers': checked out '8c96359f4199297809ab205870eb603b03d98b4e'
Submodule path 'lv_examples': checked out '5f685373743f6999a5b6c0f2782767f2815e151b'
Submodule path 'lvgl': checked out 'e1ac174e166f07def7deccaf3b3e8e6b8f658a20'
pci@pci-G3-3579:~/work/git$ cd pc_simulator_sdl_eclipse/
pci@pci-G3-3579:~/work/git/pc_simulator_sdl_eclipse$ cd lv_drivers/
pci@pci-G3-3579:~/work/git/pc_simulator_sdl_eclipse/lv_drivers$ git branch

(HEAD detached at 8c96359)
master

pci@pci-G3-3579:~/work/git/pc_simulator_sdl_eclipse/lv_drivers$ git checkout master
Previous HEAD position was 8c96359 Release v7.11.0
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
pci@pci-G3-3579:~/work/git/pc_simulator_sdl_eclipse/lv_drivers$ git pull
warning: Pulling without specifying how to reconcile divergent branches is
discouraged. You can squelch this message by running one of the following
commands sometime before your next pull:
git config pull.rebase false  # merge (the default strategy)
git config pull.rebase true   # rebase
git config pull.ff only       # fast-forward only
You can replace "git config" with "git config --global" to set a default
preference for all repositories. You can also pass --rebase, --no-rebase,
or --ff-only on the command line to override the configured default per
invocation.
Already up to date.
pci@pci-G3-3579:~/work/git/pc_simulator_sdl_eclipse/lv_drivers$ git branch

master

------------------------- see new compile error below ---------------------
Building file: ../lv_drivers/indev/keyboard.c
Invoking: Cross GCC Compiler
gcc -I"/mnt/ext4data/git/pc_simulator_sdl_eclipse" -O0 -g3 -Wall -c -fmessage-length=0 -Wall -Wmaybe-uninitialized -MMD -MP -MF"lv_drivers/indev/keyboard.d" -MT"lv_drivers/indev/keyboard.o" -o "lv_drivers/indev/keyboard.o" "../lv_drivers/indev/keyboard.c"
../lv_drivers/indev/keyboard.c: In function ‘keyboard_handler’:
../lv_drivers/indev/keyboard.c:72:21: error: ‘LV_INDEV_STATE_PRESSED’ undeclared (first use in this function); did you mean ‘LV_BTN_STATE_PRESSED’?
72 |             state = LV_INDEV_STATE_PRESSED;          /Save the key is pressed now/
|                     ^~~~~~~~~~~~~~~~~~~~~~
|                     LV_BTN_STATE_PRESSED
../lv_drivers/indev/keyboard.c:72:21: note: each undeclared identifier is reported only once for each function it appears in
../lv_drivers/indev/keyboard.c:75:21: error: ‘LV_INDEV_STATE_RELEASED’ undeclared (first use in this function); did you mean ‘LV_BTN_STATE_RELEASED’?
75 |             state = LV_INDEV_STATE_RELEASED;         /Save the key is released but keep the last key/
|                     ^~~~~~~~~~~~~~~~~~~~~~~
|                     LV_BTN_STATE_RELEASED
make: *** [lv_drivers/indev/subdir.mk:41: lv_drivers/indev/keyboard.o] Error 1
"make all" terminated with exit code 2. Build might be incomplete.
07:24:02 Build Failed. 3 errors, 1 warnings. (took 18s.97ms)

Ah... that's because this is still a v7 repo and v8 got merged into master in lv_drivers. Checkout the release/v7 branch of lv_drivers instead.

@embeddedt
pci@pci-G3-3579:~/work/git/pc_simulator_sdl_eclipse/lv_drivers$ git checkout -b v7 origin/release/v7
Branch 'v7' set up to track remote branch 'release/v7' from 'origin'.
Switched to a new branch 'v7'
now I am back to my old problem:
Building file: ../lv_examples/src/assets/lv_font_montserrat_28_compr_az.c
Invoking: Cross GCC Compiler
gcc -I"/mnt/ext4data/git/pc_simulator_sdl_eclipse" -O0 -g3 -Wall -c -fmessage-length=0 -Wall -Wmaybe-uninitialized -MMD -MP -MF"lv_examples/src/assets/lv_font_montserrat_28_compr_az.d" -MT"lv_examples/src/assets/lv_font_montserrat_28_compr_az.o" -o "lv_examples/src/assets/lv_font_montserrat_28_compr_az.o" "../lv_examples/src/assets/lv_font_montserrat_28_compr_az.c"
Finished building: ../lv_examples/src/assets/lv_font_montserrat_28_compr_az.c
Building file: ../lv_drivers/win32drv/win32drv.c
Invoking: Cross GCC Compiler
gcc -I"/mnt/ext4data/git/pc_simulator_sdl_eclipse" -O0 -g3 -Wall -c -fmessage-length=0 -Wall -Wmaybe-uninitialized -MMD -MP -MF"lv_drivers/win32drv/win32drv.d" -MT"lv_drivers/win32drv/win32drv.o" -o "lv_drivers/win32drv/win32drv.o" "../lv_drivers/win32drv/win32drv.c"
In file included from ../lv_drivers/win32drv/win32drv.c:10:
../lv_drivers/win32drv/win32drv.h:17:10: fatal error: ../lv_drv_conf.h: No such file or directory
17 | #include "../lv_drv_conf.h"
|          ^~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [lv_drivers/win32drv/subdir.mk:20: lv_drivers/win32drv/win32drv.o] Error 1
"make all" terminated with exit code 2. Build might be incomplete.

I was testing using CMake, which apparently hid the problem. The latest commit to this repo should fix the problem and the extra lv_drivers manipulation should not be needed.
Let me know if it's still broken.

@embeddedt works out of the box now. thank you for your time fixing this.

I just did a brand new checkout and am still having this issue

This is a good reminder to add a CI to this repository. :wink: The problem should be fixed if you pull again.

I can confirm it works now. Thanks for your help.


LSP Crash on opening any files

Component:

[x] VSCode Extension
[ ] VSCodium Extension
[x] LSP (used with other editor)

Extension version: 0.7.0
LSP version: 0.7.0
OS version and name: Windows 11

[x] I am on the latest stable version of the extension/LSP.
[x] I have searched the issues of this repo and believe that this is not a duplicate.

Issue

When opening a file, it crashes at once.
Logs

[Info  - 1:01:54 PM] Folder added to workspace: /path/to/workspace/
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src\workspace\source_manager.rs:180:61
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
[Error - 1:01:54 PM] The Typst Language Server server crashed 5 times in the last 3 minutes. The server will not be restarted. See the output for more information.

I cannot set "RUST_BACKTRACE=full" for a VSCode process so no full bracktrace :(.
Edited AppData\Local\Programs\Microsoft VS Code\bin\code.cmd with appending set RUST_BACKTRACE=full.

I have encountered the same situation, restarting VSCode and reinstalling LSP did not work, looking for a solution.

As a temporary solution, I rolled back the LSP version to 0.62 on VSCode and found that it worked fine.

Is anyone who is having this issue able to share more details about the files they're working with? I'll investigate, but I haven't had this happen locally.

This should be fixed in the latest version (v0.7.1) of the extension. If not, please reopen this issue.


Add unit test cases using a secret with slashes to UriUtils

Description
This PR adds URL parsing test cases against real credentials produced by Ceph. One specific target is the infamous slash character should break the existing parser.
I am expecting this PR to fail unit tests, as it is meant to engage a discussion about cleaning up the URI parser.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[X] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity
N/A
Screenshots (if appropriate):
How Has This Been Tested?
N/A

@blueorangutan package

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Okay, now the unit test fails exactly where it was supposed to:
https://github.com/apache/cloudstack/actions/runs/5342685611/jobs/9685337907?pr=7671#step:7:3864
@DaanHoogland how do you think we should proceed? Unfortunately I'm not comfortable writing code, not sure I'll be able to provide much more help than this.

@vdombrovski create a new issue, label it for 4.18.1 (provisionally) and add any other label that seem appropriate. Unfortunately you will depend on good will or a fellow victim of the issue. No guarantees :(
If they appear they will have to copy your code or get access to your branch btw.

Alright, issue created, let's wait and see. Thank you for the help.

Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 6309

In case this helps, here is the regexp we're using to test for the secret in our automation (can also be used for properly parsing the URI I believe):
rbd:\/\/([\w\-\.]+):([A-Za-z0-9+/=]+)@([^:]+):(\d+)/([\w_.]+)/?([\w_.]+)?

@weizhouapache I'm not working on a fix; as stated previously, I'm not really comfortable in making such bigger changes to the Java code. I've added the regexp as is, simply because we are already using it as a check in our automation (outside Cloudstack).
In case someone would be willing to make the required changes to this parser function (pretty sure it's this one) to make the new testcase pass, it would be quite nice and we'd be able to close this PR/Issue:
https://github.com/apache/cloudstack/blob/0466bf9d4713ab9221a4f4ae8a257996dd6cd8c6/utils/src/main/java/com/cloud/utils/UriUtils.java#L706

In case this helps, here is the regexp we're using to test for the secret in our automation (can also be used for properly parsing the URI I believe):
rbd:\/\/([\w\-\.]+):([A-Za-z0-9+/=]+)@([^:]+):(\d+)/([\w_.]+)/?([\w_.]+)?

@vdombrovski
regarding the password, does ([A-Za-z0-9+/=]+) cover all possible values ?

In case this helps, here is the regexp we're using to test for the secret in our automation (can also be used for properly parsing the URI I believe):
rbd:\/\/([\w\-\.]+):([A-Za-z0-9+/=]+)@([^:]+):(\d+)/([\w_.]+)/?([\w_.]+)?

@vdombrovski regarding the password, does ([A-Za-z0-9+/=]+) cover all possible values ?

Yes, because Ceph passwords are base64 encoded.
However judging by other test cases (which may or may not be realistic), I believe that no single regexp is able to match all of them. So I would guess either maching repeatedly against different regular expressions or keeping a more "traditional" failover mechanism might be the answer here.

Okay, now I don't know if this project is AI-friendly, but here's a regexp generated with the help of GPT that will consistenly match all testcases except the one with a user but no password (e.g. rbd://user@host which to be honest might be a non-realistic test case). Tested against IPv4, RFC1035, IPv6 hosts, and base64 passwords.
String regex = "rbd:\\/\\/(?:(\\w+):([A-Za-z0-9+/=]+)@)?([\\[\\]:\\w.-]+)(?::(\\d+))?(?:\\/([\\w]+)(?:\\/([\\w]+))?)?";

The capture groups (if they exist) will be as follows:
Capture Group 1: user
Capture Group 2: password
Capture Group 3: host
Capture Group 4: 3300
Capture Group 5: pool
Capture Group 6: volume2

Please tell me if any use of AI is prohibited; I will delete this comment.

Okay, now I don't know if this project is AI-friendly, but here's a regexp generated with the help of GPT that will consistenly match all testcases except the one with a user but no password (e.g. rbd://user@host which to be honest might be a non-realistic test case). Tested against IPv4, RFC1035, IPv6 hosts, and base64 passwords.
String regex = "rbd:\\/\\/(?:(\\w+):([A-Za-z0-9+/=]+)@)?([\\[\\]:\\w.-]+)(?::(\\d+))?(?:\\/([\\w]+)(?:\\/([\\w]+))?)?";

The capture groups (if they exist) will be as follows:
Capture Group 1: user
Capture Group 2: password
Capture Group 3: host
Capture Group 4: 3300
Capture Group 5: pool
Capture Group 6: volume2

Please tell me if any use of AI is prohibited; I will delete this comment.

@vdombrovski
hmm, great. thanks

@vdombrovski
I have tried to add a RBD pool into cloudstack, it succeeded.
CloudStack UI converted "/"to "_", and passed to cloudstack API.
so I removed the ceph pool and re-added it with the new secret (/ to _), and it succeeded as well.
The problem is, if password contains "/", Java.net.URI class cannot handle it correctly.
If you cannot add ceph RBD pool with "/" in the token, please replace / with _ and retry

@vdombrovski I have tried to add a RBD pool into cloudstack, it succeeded. CloudStack UI converted "/"to "_", and passed to cloudstack API. so I removed the ceph pool and re-added it with the new secret (/ to _), and it succeeded as well.
The problem is, if password contains "/", Java.net.URI class cannot handle it correctly. If you cannot add ceph RBD pool with "/" in the token, please replace / with _ and retry

@weizhouapache I believe your test is incorrect: the URL gets added  (even if it is invalid, it's an issue by itself actually); but it fails in libvirtd (which is why I'm calling this a silent error). We have tested this with multiple Ceph installs, we have the exact same issue everytime a slash character is present, and yes we are deploying using API only (again, nowhere is it stated that the API is actually broken and that we can't use the tools that use the ACS API).
Furthermore, asking the users to replace characters in URL manually is awful and frustrating in terms of user experience (especially as it is not properly documented). Why not asking them to provision the secret directly in libvirtd while we are at it? This example might go too far, but isn't one of the goals of this projectl to provide a easy to use and simple experience to cloud administrators and users?
Finally, I'm pretty sure that Java.net.URI is not the culprit here, as your function signature returns a custom struct (UriInfo) which has nothing to do with this lib. Also, in no way you're constrained into using Java.net.URI in your code, thus I don't see a valid reasoning here.
The way I see it, there are two main ways to fix this:

Improving the parser (e.g. via the regexp provided above) to handle all cases
Sanitizing the password input inside the API call (instead of the UI), to replace the slash character with underscore, which, and updating the unit test with passwords containing underscores.

I'll leave it up to the community to decide which implementation is best in this case.

@vdombrovski I have tried to add a RBD pool into cloudstack, it succeeded. CloudStack UI converted "/"to "_", and passed to cloudstack API. so I removed the ceph pool and re-added it with the new secret (/ to _), and it succeeded as well.
The problem is, if password contains "/", Java.net.URI class cannot handle it correctly. If you cannot add ceph RBD pool with "/" in the token, please replace / with _ and retry

@weizhouapache I believe your test is incorrect: the URL gets added (even if it is invalid, it's an issue by itself actually); but it fails in libvirtd (which is why I'm calling this a silent error). We have tested this with multiple Ceph installs, we have the exact same issue everytime a slash character is present, and yes we are deploying using API only (again, nowhere is it stated that the API is actually broken and that we can't use the tools that use the ACS API).
Furthermore, asking the users to replace characters in URL manually is awful and frustrating in terms of user experience (especially as it is not properly documented). Why not asking them to provision the secret directly in libvirtd while we are at it? This example might go too far, but isn't one of the goals of this projectl to provide a easy to use and simple experience to cloud administrators and users?
Finally, I'm pretty sure that Java.net.URI is not the culprit here, as your function signature returns a custom struct (UriInfo) which has nothing to do with this lib. Also, in no way you're constrained into using Java.net.URI in your code, thus I don't see a valid reasoning here.
The way I see it, there are two main ways to fix this:

Improving the parser (e.g. via the regexp provided above) to handle all cases
Sanitizing the password input inside the API call (instead of the UI), to replace the slash character with underscore, which, and updating the unit test with passwords containing underscores.

I'll leave it up to the community to decide which implementation is best in this case.

@vdombrovski
what I provided in my previous comment is a workaround for your issue, not the final solution.
I have tested it and it worked as expected. could you please test it (on UI or API ) ?

Another workaround is to use a Ceph password without slashes.
I'll test this on the next occasion, for now I don't have a means to do it.

Another workaround is to use a Ceph password without slashes.
I'll test this on the next occasion, for now I don't have a means to do it.

@vdombrovski
I have created a PR https://github.com/apache/cloudstack/pull/7708
Please feel free to review and test it

Sure, the fix looks good. Thank you for your help, closing this one.


Errors when importing SteamVR

I have just imported SteamVR and I am trying to use it with the OpenVR XR plugin.
As soon as the package is imported, I got these 2 errors:

Asset Packages/com.valvesoftware.unity.openvr/Runtime/x64/XRSDKOpenVR.ilk has no meta file, but it's in an immutable folder. The asset will be ignored

Assets\SteamVR\Scripts\SteamVR_Menu.cs(175,36): error CS1061: 'CVRSystem' does not contain a definition for 'ResetSeatedZeroPose' and no accessible extension method 'ResetSeatedZeroPose' accepting a first argument of type 'CVRSystem' could be found (are you missing a using directive or an assembly reference?)

I cant find a solution to this, any ideas?
Thanks!

Hi! Did you download beta 3 from the releases page? Or what version did you import?

Ok, what I installed was: SteamVR Unity Plugin v2.6.0b2 (sdk 1.12.5)
I just saw the release of SteamVR Unity Plugin v2.6.0b3 (sdk 1.13.10), probably that's it, but I will test as soon as I'm back and let you know.
Thank you!

Ok, I have now installed this version:
SteamVR Unity Plugin v2.6.0b3 (sdk 1.13.10)
And I am getting multiple messages of:
Asset Packages/com.valvesoftware.unity.openvr/Runtime/x86/XRSDKOpenVR.ilk has no meta file, but it's in an immutable folder. The asset will be ignored.
And at the very end this one:
Assets\SteamVR\Editor\SteamVR_AutoEnableVR.cs(78,68): error CS0117: 'VREditor' does not contain a definition for 'GetVREnabledDevicesOnTargetGroup'

You can fix the .ilk errors by updating the OpenVR XR Plugin in the Package Manager window. Latest should be preview-9.
That editor error is strange, if it doesn't go away when you update can you tell me what version of Unity are you running?

Ok, so I did the update.
No I got 9 errors! Got multiplied :)
Still these, with x86 and x64 errors:

Asset Packages/com.valvesoftware.unity.openvr/Runtime/x64/openvr_api.pdb has no meta file, but it's in an immutable folder. The asset will be ignored.
Asset Packages/com.valvesoftware.unity.openvr/Runtime/x64/XRSDKOpenVR.pdb has no meta file, but it's in an immutable folder. The asset will be ignored.

When I click "Clear" all the errors leave, except for this one again:
9) Assets\SteamVR\Editor\SteamVR_AutoEnableVR.cs(78,68): error CS0117: 'VREditor' does not contain a definition for 'GetVREnabledDevicesOnTargetGroup'
I have restarted unity after upgrading the package, and still the same.
The Unity version I am trying to use is 2020.2.0a18 (I need to use the Articulated Bodies).

Okay, looks like two issues. Try upgrading to preview.10 of the OpenVR XR Plugin, and download this preview of beta4: https://drive.google.com/file/d/1G9OV-_sQ0D2qjlEoE7tiiNI18WTsd4Di/view?usp=sharing

Ok, interesting, the update of SteamVR beta 4 detected that the old package of "SteamVR Desktop" was installed. Which I never installed manually, so it must have been downloaded with an update or somewhere in the process.
Now I got also the XR plugin preview 10.
It seems that thee changes did the trick, not even a single warning!
Thank you for the help :)

Great to hear!


adds a way to add in a section seperator in pr posts

updated pr29 to use it. imo this makes sections way more apparent. i like it alot more than my previous methods of just putting a horizontal rule.

would like an opinion on it from @PJB3005

pog


moon with playwright: why all sessions lanched in parellel are not recorded to s3 bucket ?

Hello,
I deployed moon2, using helm, on my k8s Cluster. When i launch 2 tests in parallel, i got just one  1/2 video on my bucket ?
i am using c# with playwright
have you an idea please ?
Thank you in advance for your help

@MohamedBenighil are you using Playwright browser contexts or separate connections to Moon? For Moon every connection to ws:// endpoint is a separate browser session being recorded independently, whereas browser contexts are considered the same session.


Add Title/Prefix, Suffix options to Personal

As an example, have something like person.title() that would randomly pull from values such as 'Dr.', 'Sir', 'Honorable' (or ' '), or person.prefix(gender=) that returns 'Mr.', 'Mrs.', 'Ms.' as appropriate.
Also, similar for suffix to the surname... either person.surname(suffix=True) or person.suffix() to return values such as 'Sr', 'Jr', 'III', 'PhD', etc.

If you want to get degree, then use personal.qualification() that return 'Bachelor', 'Master' or 'PhD' (for en).
The problem is that the prefixes of the names is not available in all languages. For example in Russian we have not name prefix.
We will try to add this capability. Thank you for idea!

We also can add prefix for person.profession()
Example:
from church import Personal

person = Personal('en')

person.job(prefix=True)

# Output: Sr. Technical Support Engineer

@memilanuk It's done!
from church import Personal

p = Person('en')

# available types: typical, aristocratic, religious, academic
title = p.title(type_='academic')


Unable to install dependencies on React Native project after upgrade due to an error when running the build_framework.ios.sh script

Description
I attempted to update a React Native project from 0.59.10 to 0.63.3. Since then, on a MacOS device, I am not able to install the dependencies of my project through npm install because the postinstall.js script encounters an error when building the Detox framework.
Detox is neither used nor in the dependencies of the project.

[ ] I have tested this issue on the latest Detox release and it still reproduces

Reproduction
Provide the steps necessary to reproduce the issue. If you are seeing a regression, try to provide the last known version where the issue did not reproduce.

Clone project
Install dependencies npm install

For the record, when I run the command npm install -D detox, the installation works just fine but I run npm install right after this command, it will fail in the same way.
Expected behavior
The dependencies are correctly installed
Environment (please complete the following information):

Detox: 14.9.2 (from the logs of npm but it is not declared in the package.json file of the project)
React Native: 0.63.3
Node: 11.15.0
Device: Mac
Xcode: 12.0
iOS: Target is set to iOS 9.0 in .xcodeproj file
macOS: Catalina 10.15.6

Logs
If you are seeing a build problem (e.g. during npm install)

[x] I am providing the npm install log below:

user@machine project_folder % npm install
npm ERR! prepareGitDep 1>
npm ERR! prepareGitDep ><EMAIL_ADDRESS>install /Users/user/.npm/_cacache/tmp/git-clone-9591e57d/node_modules/dtrace-provider
npm ERR! prepareGitDep > node-gyp rebuild || node suppress-error.js
npm ERR! prepareGitDep
npm ERR! prepareGitDep   ACTION binding_gyp_ndtp_target_build_ndtp .
npm ERR! prepareGitDep   TOUCH Release/obj.target/ndtp.stamp
npm ERR! prepareGitDep
npm ERR! prepareGitDep ><EMAIL_ADDRESS>install /Users/user/.npm/_cacache/tmp/git-clone-9591e57d/node_modules/fsevents
npm ERR! prepareGitDep > node install.js
npm ERR! prepareGitDep
npm ERR! prepareGitDep   SOLINK_MODULE(target) Release/.node
npm ERR! prepareGitDep   CXX(target) Release/obj.target/fse/fsevents.o
npm ERR! prepareGitDep   SOLINK_MODULE(target) Release/fse.node
npm ERR! prepareGitDep
npm ERR! prepareGitDep ><EMAIL_ADDRESS>postinstall /Users/user/.npm/_cacache/tmp/git-clone-9591e57d/node_modules/core-js
npm ERR! prepareGitDep > node -e "try{require('./postinstall')}catch(e){}"
npm ERR! prepareGitDep
npm ERR! prepareGitDep Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!
npm ERR! prepareGitDep
npm ERR! prepareGitDep The project needs your help! Please consider supporting of core-js on Open Collective or Patreon:
npm ERR! prepareGitDep > https://opencollective.com/core-js
npm ERR! prepareGitDep > https://www.patreon.com/zloirock
npm ERR! prepareGitDep
npm ERR! prepareGitDep Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)
npm ERR! prepareGitDep
npm ERR! prepareGitDep
npm ERR! prepareGitDep ><EMAIL_ADDRESS>postinstall /Users/user/.npm/_cacache/tmp/git-clone-9591e57d/node_modules/detox
npm ERR! prepareGitDep > node scripts/postinstall.js
npm ERR! prepareGitDep
npm ERR! prepareGitDep Extracting Detox sources...
npm ERR! prepareGitDep Building Detox.framework from /Users/user/.npm/_cacache/tmp/git-clone-9591e57d/node_modules/detox/ios_src...
npm ERR! prepareGitDep
npm ERR! prepareGitDep 2> npm WARN install Usage of the `--dev` option is deprecated. Use `--only=dev` instead.
npm ERR! prepareGitDep npm WARN deprecated<EMAIL_ADDRESS>core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.
npm ERR! prepareGitDep npm WARN deprecated<EMAIL_ADDRESS>fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
npm ERR! prepareGitDep npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm ERR! prepareGitDep npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm ERR! prepareGitDep npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
npm ERR! prepareGitDep npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
npm ERR! prepareGitDep npm WARN deprecated<EMAIL_ADDRESS>use String.prototype.padStart()
npm ERR! prepareGitDep npm WARN deprecated<EMAIL_ADDRESS>request-promise-native has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
npm ERR! prepareGitDep child_process.js:660
npm ERR! prepareGitDep     throw err;
npm ERR! prepareGitDep     ^
npm ERR! prepareGitDep
npm ERR! prepareGitDep Error: Command failed: /Users/user/.npm/_cacache/tmp/git-clone-9591e57d/node_modules/detox/scripts/build_framework.ios.sh
npm ERR! prepareGitDep     at checkExecSyncError (child_process.js:639:11)
npm ERR! prepareGitDep     at Object.execFileSync (child_process.js:657:15)
npm ERR! prepareGitDep     at Object.<anonymous> (/Users/user/.npm/_cacache/tmp/git-clone-9591e57d/node_modules/detox/scripts/postinstall.js:2:27)
npm ERR! prepareGitDep     at Module._compile (internal/modules/cjs/loader.js:816:30)
npm ERR! prepareGitDep     at Object.Module._extensions..js (internal/modules/cjs/loader.js:827:10)
npm ERR! prepareGitDep     at Module.load (internal/modules/cjs/loader.js:685:32)
npm ERR! prepareGitDep     at Function.Module._load (internal/modules/cjs/loader.js:620:12)
npm ERR! prepareGitDep     at Function.Module.runMain (internal/modules/cjs/loader.js:877:12)
npm ERR! prepareGitDep     at internal/main/run_main_module.js:21:11
npm ERR! prepareGitDep npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta but none is installed. You must install peer dependencies yourself.
npm ERR! prepareGitDep npm WARN<EMAIL_ADDRESS>requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
npm ERR! prepareGitDep npm WARN<EMAIL_ADDRESS>No repository field.
npm ERR! prepareGitDep
npm ERR! prepareGitDep npm ERR! code ELIFECYCLE
npm ERR! prepareGitDep npm ERR! errno 1
npm ERR! prepareGitDep npm ERR<EMAIL_ADDRESS>postinstall: `node scripts/postinstall.js`
npm ERR! prepareGitDep npm ERR! Exit status 1
npm ERR! prepareGitDep npm ERR!
npm ERR! prepareGitDep npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! prepareGitDep npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! prepareGitDep
npm ERR! prepareGitDep npm ERR!      /Users/user/.npm/_logs/2020-11-16T14_36_31_226Z-debug.log
npm ERR! prepareGitDep
npm ERR! premature close

npm ERR!      /Users/user/.npm/_logs/2020-11-16T14_36_32_005Z-debug.log

detox_ios.log
I am not able to put the full log file because it would be a lot of work to anonimyze the whole file but I can give the failing command found in the logs :
The following build commands failed:
	CompileC /Users/user/Library/Developer/Xcode/DerivedData/Detox-ahbwgarbmgzdbtaktwywffunlmvz/Build/Intermediates.noindex/EarlGrey.build/Release-iphoneos/EarlGrey.build/Objects-normal/arm64/GREYActions.o EarlGrey/Action/GREYActions.m normal arm64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Additional informations

When using the npm install -D detox command, I am able to install my dependencies and I can use the detox-cli to clean the cache and rebuild the framework and these 2 commands (detox clean-framework-cache and detox build-framework-cache) run without encountering any error but when I run the npm install command, the install fails again.
I tried all the commands mentionned here with both the New Build System and the Legacy Build System of XCode with the same result.
The NPM logs indicate that the version of detox is 14.9.2 but after running the command find ./node_modules/ -name package.json | xargs grep detox@14, there is no dependency using detox 14.

Some of your dependency is bringing a very old version of Detox. There is nothing we can do. Find the dependency that is responsible and fix it.

The problem in this case comes from Xcode 12, not RN upgrade. We’ve already upgraded Detox to support Xcode 12, but one of your dependencies has hardcoded Detox to an old version. Detox should not even be found under dependencies but under dev dependencies, so it’s even dumber on their part. Sorry, you must find that dependency and either remove it or open an issue and hope for a fix.

Okay, I will investigate on which dependency cause this problem.
Thanks for your time

As a dirty workaround, we decided to completely disable the post install script of Detox using the environment variable DETOX_DISABLE_POSTINSTALL=1.
Since we don't use Detox in this project but it is still required by another dependency, it won't be a problem for us.


504: Error during a mutation

For bug reports, please fill in the next sections:
Current behavior
It throws a 504 error when I try to call a mutation using node & graphql-request. I got a failed to fetch when I ran it the first time in the playground. I ran it a second time and it worked. I'm not sure what's going on here. I have built my project on the graph.cool interface. This is a simple update I'm calling. It's failing on this simple case. This is my first time using it. I can provide the code I'm using to call the mutation.
    const draftedData = await request('https://api.graph.cool/simple/v1/<my-id>', graphqlQuery.updatePlayerAdp,
	{
		id: queryPlayer[0].id, adp: newAdp, drafts: newDrafts, development: player.devTrait.toString(),
		round: newRound, oldAdp: (queryPlayer[0].adp || 0), adpDiff (queryPlayer[0].adp - newAdp)
	}
    );

GraphQL Error (Code: 504): {"response":{"error":"<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01 Transitional//EN\" \"http://www.w3.org/TR/html4/loose.dtd\">\n<META HTTP-EQUIV=\"Content-Type\" CONTENT=\"text/html; charset=iso-8859-1\">\n<TITLE>ERROR: The request could not be satisfied</TITLE>\n\n
504 ERROR
\n
The request could not be satisfied.
\n
\nCloudFront attempted to establish a connection with theorigin, but either the attempt failed or the origin closed the connection.\n
\nFor more information on how to troubleshoot this error, please refer to the CloudFront documentation\n(https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/http-504-gateway-timeout.html).\n
\n
\n
\nGenerated by cloudfront (CloudFront)\nRequest ID: b3sump64Q-9Aw3focfcFJLLTx2yF7exSHBNLK-hBzhGZCZ5gYGorcg==\n
\n<ADDRESS>\n</ADDRESS>\n","status":504},"request":{"query":"mutation UpdatePlayerAdp($id: ID!, $adp: Int, $drafts: [Int!], $development: String, $round: Int, $oldAdp: Int, $adpDiff: Int) {\n\tupdatePlayer(id:$id, adp: $adp, drafts: $drafts, development: $development, round: $round, oldAdp: $oldAdp, adpDiff: $adpDiff){\n    firstName\n    lastName\n    adp\n    round\n  }\n}\n","variables":{"id":"cjghn2enlztba0143qg4b85ru","adp":593,"drafts":[593],"development":"1","round":19,"oldAdp":0,"adpDiff":-593}}}
    at GraphQLClient.<anonymous> (/Users/Birdwell/Documents/GraphQLMadden/node_modules/graphql-request/src/index.ts:71:13)
    at step (/Users/Birdwell/Documents/GraphQLMadden/node_modules/graphql-request/dist/src/index.js:40:23)
    at Object.next (/Users/Birdwell/Documents/GraphQLMadden/node_modules/graphql-request/dist/src/index.js:21:53)
    at fulfilled (/Users/Birdwell/Documents/GraphQLMadden/node_modules/graphql-request/dist/src/index.js:12:58)
    at <anonymous>
    at process._tickDomainCallback (internal/process/next_tick.js:228:7)

Reproduction

If your problem can be reproduced with a certain service definition, please create a new GitHub repository with the reproduction instructions.

Expected behavior?
That it would accept the query. I copied it exactly to the playground and failed then it worked on the second go. Sometimes these queries work and other times they fail.

Same here. Not sure what changed.

This is now fixed, thanks for bringing it up!

@marktani Thanks for looking into this!


citadel listened-namespaces to namespaceall for readability.

Makes how default Citadel working clearer to the reader.

metav1.NamespaceAll equals to ""
strings.split("", ",") returns []string{""}

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incfly
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS [incfly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, incfly
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS [howardjohn,incfly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

@incfly: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wattli @howardjohn might re-grant LGTM label?

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, incfly
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS [howardjohn,incfly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test integ-galley-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test integ-galley-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-v1alpha3.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test integ-galley-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-v1alpha3.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/istio-unit-tests.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test integ-galley-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-v1alpha3.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/istio-unit-tests.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test istio-unit-tests-master

prow/e2e_pilotv2_auth_sds.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test integ-galley-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-v1alpha3.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/istio-unit-tests.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test istio-unit-tests-master

prow/e2e_pilotv2_auth_sds.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test istio_auth_sds_e2e-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-k8s-presubmit-tests-master
/test integ-galley-k8s-presubmit-tests-master
/test e2e-bookInfoTests-envoyv2-v1alpha3-master
/test istio-unit-tests-master
/test istio_auth_sds_e2e-master
/test istio-pilot-e2e-envoyv2-v1alpha3-master

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test integ-galley-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-v1alpha3.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e_pilotv2_auth_sds.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

source/common/secret/sds_api.h

/test istio_auth_sds_e2e-master

@incfly: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
ff13497445f5b8c8a623862e973945a03601a10a
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-bookInfoTests-envoyv2-v1alpha3-master

Thanks for working on this.


Integrate llama-index parsers

Wrap all llama-index parses to get easy access to a lot of file formats (pdfs, wikipedia etc)

As far as I know llama_index doesn't offer any other parser apart from this.
Please correct me if I am wrong.

Not sure of other file types but for PDF this can be used. Here is the sample code that converts a pdf file into a md file.
I tested it with this paper and here is the output_file.

If you have any complex pdf file, do test it and lmk the results. If results are satisfactory I'll add a PR for this.

I'm thinking now with the plugin arch this could be done in a separate package "docetl-llama-index-parsers" or some such if it's too off topic for the main library.

I am also starting to wonder whether a plugin system for file-readers might be a good idea. I appreciate this might be an early optimisation though... 🤔

@AntoineDao  So, I already built a plugin system, and the PR above could easily be moved to a separate repo.
However, the API for parsers is a bit limited, see https://github.com/ucbepic/docetl/issues/72, and it would be good to address that first...
I think parsing and loaders is where there is a near infinite set of libraries that could be useful to integrate with, and doing so directly in this repo would end up very messy. Hence plugins :)

I agree that we'll eventually want a plugin system, but it currently feels a bit premature to do so...
If anyone has a concrete use case, please react and/or comment here. We can bump up the priority for this

Well, the entrypoint stuff I wrote /is/ a simple plugin system... I think that's good enough for now.


Modify label filter issue and add stick label to image case

Coverage increased (+0.3%) to 62.624% when pulling e5a757d78dd8e47779f01924f002efa948487ae5 on pengpengshui:label into 3f46df808740014de6a018c01d663215d3f77a89 on vmware:master.


[Todo List] Set "Doing" which in turn shown what task is currently on doing status on menu bar

Extension
https://www.raycast.com/maggie/todo-list
Description
sometime I lost what I am currently doing because I need to context switch (take break, doing chores, replying email) or just because I have low ability to . I wish when I back to focus to work I can know what I am in the middle of doing just by looking at my menubar
Who will benefit from this feature?
someone who have specific job (like coding) but have to context switch frequently
Anything else?
I am willing to contribute making PR but I have to learn about developing extension for Raycast first because never done it before

if it is easier we could just show the first pinned uncomplete to do, then add settings for it so it doesn't someone who doesn't want this feature

nvm, I am using Session instead


Logger should have log level trace

A common log level, which is currently missing, is 'TRACE'. I would like to use it for very verbose debug msgs. I would volunteer to implement it.

I believe we already discussed increasing log levels. However, I am quite happy with the variety that exists and suggest that you use debug(). If you absolutely need a different identifier, how about function extension:
fun Logger.trace(message: String) {
    // ...
}

The reasoning behind that is that trace messages are usally much more verbose and you seldom configure them. A usecase is for instance to trace a procedural content generator (terrain). If you use the debug level for it, your whole log gets cluttered, although you only need it if you have issues with the generator.
But the extension function is also fine with me...


Consider adding templates

We might want to add a separate NuGet package to this project containing templates for dotnet new so that new projects can be easily created. Perhaps we can even add templates for specific SQL object types like stored procedures, tables, views, etc.

According to this these templates will eventually show up in Visual Studio as well, which would be super neat. Especially if item templates show up as well.

An initial set of templates has shipped with 1.4.0. If additional item templates are needed please don't hesitate to file an issue or submit a PR.


Update error message guidance

Description
Updating the error message guidance to help users understand how to use them with different components.
Related issue

GitHub issue 222
Jira - STAN-1684

Checklist

[x] Tested against the NHS.UK frontend testing policy (Resolution, Browser & Accessibility)
[x] Code follows the NHS.UK frontend coding standards
[ ] Version number has been increased in package.json (using SEMVER)
[x] CHANGELOG entry
[x] Whats new page entry

Hi @sarawilcox, this is now ready to review.