Request refresh of genshin-db-dist for 4.4

Hi @theBowja I don't think that the new characters (Xianyun / Gaming) are present in the current dist release. It looks like there was an update post 4.4, was it intended that this update was synced into the dist release at the same time as the main?

I can definitely see this info in genshin-db https://github.com/theBowja/genshin-db/blob/main/src/data/English/characters/xinyan.json

Actually, it looks like the character data is there, but missing from "names" config.
"names": {
          "Aether": "aether",
          "Albedo": "albedo",
          "Alhaitham": "alhaitham",
          "Aloy": "aloy",
          "Amber": "amber",
          "Arataki Itto": "aratakiitto",
          "Baizhu": "baizhu",
          "Barbara": "barbara",
          "Beidou": "beidou",
          "Bennett": "bennett",
          "Candace": "candace",
          "Charlotte": "charlotte",
          "Chevreuse": "chevreuse",
          "Chongyun": "chongyun",
          "Collei": "collei",
          "Cyno": "cyno",
          "Dehya": "dehya",
          "Diluc": "diluc",
          "Diona": "diona",
          "Dori": "dori",
          "Eula": "eula",
          "Faruzan": "faruzan",
          "Fischl": "fischl",
          "Freminet": "freminet",
          "Furina": "furina",
          "Ganyu": "ganyu",
          "Gorou": "gorou",
          "Hu Tao": "hutao",
          "Jean": "jean",
          "Kaedehara Kazuha": "kaedeharakazuha",
          "Kaeya": "kaeya",
          "Kamisato Ayaka": "kamisatoayaka",
          "Kamisato Ayato": "kamisatoayato",
          "Kaveh": "kaveh",
          "Keqing": "keqing",
          "Kirara": "kirara",
          "Klee": "klee",
          "Kujou Sara": "kujousara",
          "Kuki Shinobu": "kukishinobu",
          "Layla": "layla",
          "Lisa": "lisa",
          "Lumine": "lumine",
          "Lynette": "lynette",
          "Lyney": "lyney",
          "Mika": "mika",
          "Mona": "mona",
          "Nahida": "nahida",
          "Navia": "navia",
          "Neuvillette": "neuvillette",
          "Nilou": "nilou",
          "Ningguang": "ningguang",
          "Noelle": "noelle",
          "Qiqi": "qiqi",
          "Raiden Shogun": "raidenshogun",
          "Razor": "razor",
          "Rosaria": "rosaria",
          "Sangonomiya Kokomi": "sangonomiyakokomi",
          "Sayu": "sayu",
          "Shenhe": "shenhe",
          "Shikanoin Heizou": "shikanoinheizou",
          "Sucrose": "sucrose",
          "Tartaglia": "tartaglia",
          "Thoma": "thoma",
          "Tighnari": "tighnari",
          "Venti": "venti",
          "Wanderer": "wanderer",
          "Wriothesley": "wriothesley",
          "Xiangling": "xiangling",
          "Xiao": "xiao",
          "Xingqiu": "xingqiu",
          "Xinyan": "xinyan",
          "Yae Miko": "yaemiko",
          "Yanfei": "yanfei",
          "Yaoyao": "yaoyao",
          "Yelan": "yelan",
          "Yoimiya": "yoimiya",
          "Yun Jin": "yunjin",
          "Zhongli": "zhongli"
        },

Main file includes names
https://github.com/theBowja/genshin-db/blob/main/src/data/index/English/characters.json
Dist does not
https://github.com/theBowja/genshin-db-dist/blob/main/data/gzips/english-characters.min.json.gzip

The reason might be because my workflow failed to commit the new update.
remote: error: File data/standard/data.min.json is 118.60 MB; this exceeds GitHub's file size limit of 100.00 MB

@theBowja could we temporarily commit only the gzipped version, which meets the size limits?

ok i removed data.min.json
try again?

Yep it's fixed now! Just waiting for cdn.jsdelivr.net cache to refresh and I can test my app.

Done and done. :)

Thank you @theBowja I appreciate your quick response.


Indented syntax improvements

@nex3 I'm close to wrapping up newline handling, but have a question.
In @supports and @import ... supports rules, I'm not sure what the correct output is. The proposed spec reads "In the indented syntax, LineBreak is not whitespace in the ImportAtRule, SupportsAtRule or MediaAtRule, except inside of parentheses or square brackets as defined by CSS syntax."
In the SCSS format, I'm seeing some curious whitespace handling that wouldn't conform to the above- here are some examples, with the failing versions commented out.
Should I match existing SCSS behavior, or does the SCSS behavior need to be fixed here?

Yes, it's an SCSS bug that no whitespace is allowed after the ( in that case.

Moved to https://github.com/sass/dart-sass/pull/2467


Document how to run Travis scripts locally for testing/fixing build issues of Website

Recently there have been some website builds break as a result of changes in Flutter (eg. deprecating constants). Since the website doesn't rebuild on flutter changes but does pull flutter, this means the next push to the website will fail (and may not be related to the change made).
To debug these (for ex. #16153) it'd be useful to be able to run the Travis script locally (since the build is slow, shotgun fixing by pushing to Travis is tedious) however when I tried to run it manually it seemed to fail:
Running "flutter packages get" in animate1...                0.5s
Run flutter analyze on _includes/code/animation/animate1

ProcessException: No such file or directory
  Command: /usr/bin/xcodebuild -project /Users/dantup/Dev/Google/flutter-website/ios/Runner.xcodeproj -target Runner -showBuildSettings

I had a scan through the scripts, but I couldn't figure out where that ios folder was supposed to come from.

@sfshaza2 Should this be a web site issue? See jgmagman's comment above. I'm not sure either!


Add stylelint for inline css

https://github.com/stylelint/stylelint
Add stylelint for html (it supports inline css)
try :!stylelint %

This one we set up for HTML by default, because the linter itself comes with built-in support for checking CSS inside of HTML code, unlike ESLint, which requires a plugin.

Hey @w0rp, I've managed to get this working but I'm not sure how to write tests for it, can you point me to a direction?

Sure, check out :help ale-development. That should tell you everything you need to know.


Support tag/branch & rev at the same time for git dependencies

Problem
Caused by:
  dependency (xyz) specification is ambiguous. Only one of `branch`, `tag` or `rev` is allowed

In some contexts it is useful to specify the exact rev to ensure a given revisions, but keep the tag/branch for human readability and preventing mistakes.
Proposed Solution
rev is great to ensure a given revision in projects that require it, but it's not very human-readable. Having both would be ideal in some context, but then it would be great if cargo actually did some checking that they actually match (otherwise the human-readable one could be a mistake and be worse than not being there at all).
The behavior I'm thinking of:
If rev is used with tag/branch, the rev should be used and cargo should verify that the rev is part of the history of the tag/branch (if it can) and print a warning (but not error) if it can't (--frozen etc.). cargo should only fail if it was able to check the history and rev and tag/branch don't actually match.
Users that don't want this behavior, can just not use both and retain current behavior.
Notes
No response

Why is a Cargo.lock insufficient for this? This sounds like an alternative form of locking.

Some reasons:
Cargo.lock is ignored when a library is used as a dependency.
Cargo.lock is a mechanical lock file, hard to read, people don't pay attention to it during code reviews (as much). In Cargo.toml there's a semantic meaning. rev =  means "you must use this revision, no updates supported/desired in this use-case", branch =  means you should use stuff from this brunch, and potentially things might get updated there".
rev is very useful, but it just suffers from not being very human readable and hard to verify. Pairing it with something more readable just helps humans review updates and go about their work.

If I understand our current git behavior and git in general, we have the potential to move to shallow clones but this would prevent us from being able to do so, at least in this scenario.

Yes. I think that's the downside. But, I would be willing to pay that cost for these few deps that need to be git deps and that's the reason I mention that maybe cargo could verify rev to tag/branch correspondence only sometimes. Because once it's verified it's job done - human did not make a mistake and things are great, and dependency is pinned to the rev.

If rev is used with tag/branch, the rev should be used and cargo should verify that the rev is part of the history of the tag/branch

Generally tags are assumed and treated to be immutable, so do we need it for that?  And if you want a human readable name for a rev, wouldn't tagging it be more appropriate or do you not have control over that repo and you aren't on one of their sanctioned releases?

registry dependencies also cannot have git dependencies.

I must admit we're doing lots of git dependencies... :D ... unfortunately. Basically we have a a project that depends on open source project and we often need to pin to a given git release, and that internally often needs to pin things to git release ... it's fun.

So this is exclusive to git/path dependencies where a common workspace is involved. Do I have that right?

I'm not sure what do you mean. This generally applies to any git dependency. In any project that needs a git dependency to use ref= it's hard for the human to know immediately what does a git hash points to.
The whole feature is mostly a UX improvement.

Generally tags are assumed and treated to be immutable, so do we need it for that?

It's true that usually tags are immutable, so generally this wouldn't be that much of an issue. But it occurred to me that sometimes people do use rev for "security" reason and in that case having both rev and tag, instead of tag might be desired as well.


Request for options to hide the label text margin bottom on Dropdown component

If you're using dropdown component without label, then the margin bottom doesn't removed.

Expected Result:
If you're using dropdown component without label, then the margin bottom should be removed.

Input labels are required always for accessibility reasons.


Vs Code fails to get the encoding of the file

Look at the following issue https://github.com/pre-commit/pre-commit/issues/519
VS Code has issue recognising the encoding of pre-commit file

VSCode Version: 1.12
OS Version: OSX 10.10

Steps to Reproduce:

Configure pre-commit tool for your repo
Try committing the a file from gui. Notice the following error

An unexpected error has occurred: LookupError: unknown encoding:
Check the log at ~/.pre-commit/pre-commit.log

From what I understand here, VS code is not passing the LANG environment variable (or passing an invalid LANG environment variable) causing python to misinterpret the default encoding.  Usually python will fall back to US-ASCII when not receiving LANG or receiving LANG=, I'm unable to reproduce the python issue outside of VSCODE
A minimal reproduction would be a pre-commit hook which does the following:
#!/usr/bin/env python
import io
# io.open triggers an encoding lookup
with io.open('/dev/null') as f:
    f.read()

Simply write that to .git/hooks/pre-commit, chmod 755 .git/hooks/pre-commit and commit from VS code

This is an issue of pre-commit

@joaomoreno I encourage you to reconsider. My reproduction above does not involve the framework, just vanilla git, vanilla python,  and vanilla vscode. Commit with that set up works fine for me outside of vscode but crashes with the LookupError listed above. (the small python script also works just fine outside).
I think you may be confused about my poor choice in naming (heh), pre-commit (the framework) is named after the built in git hook by the same name.

What would a fix in VS Code look like?

I'm not entirely sure without analyzing the problem more.  My guess is VS Code needs to pass along the LANG environment variable it was started with to subprocesses.

I've submitted a PR here: https://github.com/Microsoft/vscode/pull/26412

Thanks for taking the time to look into this. 🍻

@joaomoreno hopefully this will land in next version of vscode


In a multi page tour, how to start the tour from a particular page on the same domain.

suppose i have 3 pages (1.html, 2.html and 3.html). My tour start from 1.html and progresses to 2 and 3. Now what i want to know is if i open 3.html directly, i want the tour to start from the first step in 3.html and skip the previous steps. and this should happen for all the pages.
Currently whats happening is if i go to any page, it redirects to the first page and starts from step 1.
I need to deliver a project and need this functionality urgently. Any quick help will be really appreciated.
Thanks
Vipul

As this is a specific demand, you will need to write some simple code to make it work. For example, you can use the method goTo(i) when you are at the page number 3.


Android Client not available on FDroid

Hi;
I would like to understand way, as an open source software, your android client is not available on FDroid, or other open source repository ?
It is because I need a google account to use keybase ?
Regards!
Jonathan

Indeed this would be nice.  As a workaround for now, you can download the Yalp Store in F-Droid, then download Keybase from within Yalp.  Works on my Google-free Android!

Duplicate of #6899


Why Uber Engineering Switched from Postgres to MySQL / Uber Engineering Blog

URL: https://www.uber.com/en-US/blog/postgres-to-mysql-migration/
Review (1-2 sentences): Uber started with a monolithic backend application that used Postgres. As the company evolved and grew, it moved to microservices and changed its approach to working with data. The paper explains why this migration happened and what benefits the company gets from it. There is nothing about OLAP in the paper but still a very interesting story.

Published in Digest #33.


HBASE-23307 Add running of ReplicationBarrierCleaner to hbck2 fixMeta…

… invocation

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
5m 14s
branch-2 passed

+1 :green_heart:
compile
0m 56s
branch-2 passed

+1 :green_heart:
checkstyle
1m 23s
branch-2 passed

+1 :green_heart:
shadedjars
4m 13s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
branch-2 passed

+0 :ok:
spotbugs
3m 34s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 31s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 44s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
checkstyle
1m 22s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 11s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m  9s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 36s
the patch passed

-1 :x:
findbugs
3m 29s
hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

-1 :x:
unit
286m 47s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 35s
The patch does not generate ASF License warnings.

341m 21s

Reason
Tests

FindBugs
module:hbase-server

Nullcheck of regionDir at line 268 of value previously dereferenced in org.apache.hadoop.hbase.master.HbckChore.loadRegionsFromFS()  At HbckChore.java:268 of value previously dereferenced in org.apache.hadoop.hbase.master.HbckChore.loadRegionsFromFS()  At HbckChore.java:[line 268]

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-854/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/854

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux d63aa78665c4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-854/out/precommit/personality/provided.sh

git revision
branch-2 / 70771b603e

Default Java
1.8.0_181

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-854/1/artifact/out/new-findbugs-hbase-server.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-854/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-854/1/testReport/

Max. process+thread count
4863 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-854/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


[NNPA] Call ScrubDisposablePass before ZHighConstPropagation

Since ZHighConstPropagation currently works with DenseElementAttr only, call ScrubDisposablePass to replace any DisposableElementsAttr with DenseElementsAttr before calling ZHighConstPropagation.

it should be easy to make ZHighConstPropagation read DisposableElementsAttr, are you interested in help with that?

it should be easy to make ZHighConstPropagation read DisposableElementsAttr, are you interested in help with that?

@sorenlassen it's a good idea. I am a bit busy this week so will create a new PR for it later. If possible I would like to have this landed since it fixes a performance regression in one of our benchmarks.

it should be easy to make ZHighConstPropagation read DisposableElementsAttr, are you interested in help with that?

@sorenlassen it's a good idea. I am a bit busy this week so will create a new PR for it later. If possible I would like to have this landed since it fixes a performance regression in one of our benchmarks.

Maybe create an issue so you do not forget to remove the ScrubDisposablePass and allow zHighConstPropagation to read DisposableElementsAttr.

If possible I would like to have this landed since it fixes a performance regression in one of our benchmarks.

ok

Thanks @sorenlassen and @hamptonm1! I created an issue as a memo: https://github.com/onnx/onnx-mlir/issues/2587

Jenkins Linux ppc64le Build #12128 [push] [NNPA] Call ScrubDisposa... started at 05:11

Jenkins Linux amd64 Build #13111 [push] [NNPA] Call ScrubDisposa... started at 04:04

Jenkins Linux s390x Build #13135 [push] [NNPA] Call ScrubDisposa... started at 05:04

Jenkins Linux s390x Build #13135 [push] [NNPA] Call ScrubDisposa... passed after 1 hr 14 min

Jenkins Linux ppc64le Build #12128 [push] [NNPA] Call ScrubDisposa... passed after 1 hr 52 min


Not possible to leave network card without ip address

Full example
provider "libvirt" {
    uri = "qemu:///system"
}

resource "libvirt_volume" "my2_qcow2" {
  name = "my2_qcow2-${count.index}"
  count = 2
  pool = "default"
  source = "/home/some-image.qcow2"
  format = "qcow2"
}

resource "libvirt_network" "vm_network" {
   name = "inet"
   addresses = ["<IP_ADDRESS>/24"]
   dhcp {
		enabled = false
	}
}

resource "libvirt_domain" "domain-sle" {
  name = "sle-terraform-${count.index}"
  memory = "512"
  vcpu = 1
  count = 2

  network_interface {
    network_id = "${libvirt_network.vm_network.id}"
  }

  network_interface {
    network_id = "${libvirt_network.vm_network.id}"
  }

  console {
    type        = "pty"
    target_port = "0"
    target_type = "serial"
  }

  console {
      type        = "pty"
      target_type = "virtio"
      target_port = "1"
  }

  disk {
   volume_id = "${libvirt_volume.my2_qcow2.*.id[count.index]}"
  }

  graphics {
    type = "spice"
    listen_type = "address"
    autoport = "true"
  }
}

Details
Given network:
resource "libvirt_network" "vm_network" {
   name = "inet"
   addresses = ["<IP_ADDRESS>/24"]
   dhcp {
		enabled = false
	}
}

And network interface:
  network_interface {
    network_id = "${libvirt_network.vm_network.id}"
  }

It is not possible to leave the IP address unconfigured, which is a common case for QA teams.
libvirt_domain.domain-leap15: Cannot map 'leap15-terraform': we are not waiting for DHCP lease and no IP has been provided
```

This could be a check/leftover from the initial times, where the provider tried to emulate a cloud-like environment and always have a way to access the domain, however, this may not be necessary.

this is problematic code from libvirt/domain.go :
// no IPs provided: if the hostname has been provided, wait until we get an IP
					wait := false
					for _, iface := range *waitForLeases {
						if iface == &netIface {
							wait = true
							break
						}
					}
					if !wait {
						return fmt.Errorf("Cannot map '%s': we are not waiting for DHCP lease and no IP has been provided", hostname)
					}

getting to waitForLeases is controlled by
if waitForLease, ok := d.GetOk(prefix + ".wait_for_lease"); ok {
			if waitForLease.(bool) {
				*waitForLeases = append(*waitForLeases, &netIface)
			}
		}

from what I have learn about go in last days  :
network_interface {
    network_id = "${libvirt_network.vm_network.id}"
  }

should not reach waitForLeases collection , but it reaching it what I have missed ?

hi all, can you provide the full example.tf here for reproducing it? Tia :sunflower:

github not allow to load tf files so need to change ext.
three_machines.txt

@asmorodskyi currently i still don't get your issue and i'm trying to reproduce.
Remember that it is an opensource and community project here, and also in day by day business i am busy with other stuff.
I try always to help people around and silently fixing without giving explication is not my style.
As i say before, i don't know how to reproduce and dunno what is your problem, so i'm taking the time to see where is the problem , and see if i can reproduce it :)
Once i got the picture we can help fixing the problem.
For me if it is a small/medium fix i will be glad to  help you on fixing it. If it is an huge tech-debt that need some really advanced knowledge, it think you will understand that we fix ourself. But in anyway, all process here is opensource, you will see the fix and gain knowledge by that.
So let see.  :sun_with_face:

@MalloZup didn't plan to push you anyhow take your time and get to the issue whenever it will suit your priorities list I have no problems with that. Meanwhile I will try to proceed on my own. In case you have any certain question I am ready to answer.
Some background for this issue : we trying to use terraform to setup  environment which we plan to use for testing Network stack. So we  need to have VMs which have NICs but NICs not initialized nor with static IPs neither with DHCP. But looks like such setup not supported by libvirt provider. Currently we workaround this with using <IP_ADDRESS> IP and after short discussion with @dmacvicar  he open this issue for us to find proper solution for that

@asmorodskyi  no worry, it is ok! thank you for feedback and infos.

@asmorodskyi ok i see the problem.
What i would try if i were you:

remove the if block https://github.com/dmacvicar/terraform-provider-libvirt/blob/master/libvirt/domain.go#L663-L665
rebuild the provider with these changes on your $GOPATH: make, make install. This will generate a bin .
Move the binary terraform-provider-libvirt in /usr/bin, removing the old provider.

After 2 i would rerun the example with the new provider.

@asmorodskyi As @MalloZup mentioned, I think the key would be to replace the https://github.com/dmacvicar/terraform-provider-libvirt/blob/master/libvirt/domain.go#L663-L674 block by a if wait { partialNetIfaces[strings.ToUpper(mac)] = ...} (so we would add the interface to the list of partially resolved interfaces if and only if we have the wait set). In this way, we would not force users provide IPs or wait for DHCP: we could also just ignore the IPs...

@MalloZup  I deleted more then you suggesting https://github.com/dmacvicar/terraform-provider-libvirt/blob/master/libvirt/domain.go#L655-L665 because go complains about wait variable which was declared but never used. after compiling and running terraform with modified version of provider I got some different error :
Error applying plan:

2 error(s) occurred:

* libvirt_domain.domain-sle[1]: index 1 out of range for list libvirt_volume.my2_qcow2.*.id (max 1) in:

${libvirt_volume.my2_qcow2.*.id[count.index]}
* libvirt_domain.domain-sle[0]: 1 error(s) occurred:

* libvirt_domain.domain-sle.0: Did not obtain the IP address for MAC=06:4F:42:C3:FD:D6

not sure why error about qcow image popup and if it is related. before changes I didn't have any  issues with libvirt_volume domain
anyway removing block that you mention just make this problem popup in different place , so I would like to figure out why NIC without waitForLease defined getting into *waitForLeases here https://github.com/dmacvicar/terraform-provider-libvirt/blob/master/libvirt/domain.go#L604-L608 instead of firefighting of what happening afterwards when it gets there.

@inercia  sorry but I am not experienced enough to understand what you meant under "..." or go supports exactly such string ? Nevertheless not sure how it could help if we failing before lines which you suggesting to change https://github.com/dmacvicar/terraform-provider-libvirt/blob/master/libvirt/domain.go#L664

@inercia sorry but I am not experienced enough to understand what you meant under "..." or go supports exactly such string ? Nevertheless not sure how it could help if we failing before lines which you suggesting to change https://github.com/dmacvicar/terraform-provider-libvirt/blob/master/libvirt/domain.go#L664

Sorry, I was suggesting to do something like:
                               if wait {
					// the resource specifies a hostname but not an IP, so we must wait until we
					// have a valid lease and then read the IP we have been assigned, so we can
					// do the mapping
					log.Printf("[DEBUG] Do not have an IP for '%s' yet: will wait until DHCP provides one...", hostname)
					partialNetIfaces[strings.ToUpper(mac)] = &pendingMapping{
						mac:      strings.ToUpper(mac),
						hostname: hostname,
						network:  network,
					}
                               }

to investigate qcow error i did the following :

delete network domain from config at all so it will look like this :

provider "libvirt" {
    uri = "qemu:///system"
}

resource "libvirt_volume" "my2_qcow2" {
  name = "my2_qcow2-${count.index}"
  count = 2
  pool = "default"
  source = "/home/some-image.qcow2"
  format = "qcow2"
}

resource "libvirt_domain" "domain-sle" {
  name = "sle-terraform-${count.index}"
  memory = "512"
  vcpu = 1
  count = 2

 console {
    type        = "pty"
    target_port = "0"
    target_type = "serial"
  }

  console {
      type        = "pty"
      target_type = "virtio"
      target_port = "1"
  }

  disk {
   volume_id = "${libvirt_volume.my2_qcow2.*.id[count.index]}"
  }

  graphics {
    type = "spice"
    listen_type = "address"
    autoport = "true"
  }
}

Run this config with master HEAD version of provider => no errors
Run this config with modified version with suggestions by @MalloZup => no errors

So for me it looks like something which requires investigation too no related  to current issue. I mean it shouldn't the case that problems in one domain cause errors in another, right ?

@asmorodskyi your snippet of terraform without network Interface is ok that you don't have any error, if you remove the networkIface and this from domain.
The comment from @inercia  to me make sense. see (https://github.com/dmacvicar/terraform-provider-libvirt/issues/502#issuecomment-449385214)
With that modified codebase, if i were you, i would build the provider and then retry this tf: https://github.com/dmacvicar/terraform-provider-libvirt/issues/502#issue-391734919
note that the networkInterface is present on hcl.
:santa: :mrs_claus: :three: :gift: :santa:

@MalloZup I just tried code suggested by @inercia with initial tf  -
2 error(s) occurred:

* libvirt_domain.domain-sle[1]: 1 error(s) occurred:

* libvirt_domain.domain-sle.1: Did not obtain the IP address for MAC=06:E9:9D:19:CF:9A
* libvirt_domain.domain-sle[0]: 1 error(s) occurred:

* libvirt_domain.domain-sle.0: Did not obtain the IP address for MAC=76:8F:72:5C:EA:3B

after spending more time on reading a code I found that we need to clarify issue description :

Not possible to leave network card without ip address when network mode equal nat

when I add mode = "none" all works as expected no errors and domain created successfully. So issue popup only for nat and route modes ( and also when nothing is defined which treated as default nat ). More code investigation needed how actually NAT is created ? Maybe it really need to have IP address on guest to setup link between host and guest ?

fixed and works on latest master thx

@MalloZup so just to clarify for myself - my assumption was wrong and to create network with mode=nat you don't need any IP ? Also can you please advise me what release model libvirt-provider has ? I mean when I will see released version which will contain this fix ? Want to test it

you can build from source the master branch

you can build from source the master branch. fix pr #556. for the released version we need to do other things before releasing a new version.


Recursive data structure fails to load on web page when group name contains space

[X] What version of the library are you using? 2.92 Is it the latest version? Yes The latest released version is

What kind of issue is this?

[X] Bug report.

I have a model that contains a recursive data structure (e.g. Node contains Node). This works fine in most cases. However, if I try to use multiple Swagger groups, the page will fail to load with a javascript error ("InternalError: too much recursion") if I use a group name that contains a space. If I remove the space from the group name, the error goes away.

I have the same issue with this method
@GetMapping("/downloadFile/{fileName:.+}")
    public ResponseEntity<Resource> downloadFile(@PathVariable String fileName, HttpServletRequest request) {
        // Load file as Resource
        Resource resource = cboFileStorageService.loadFileAsResource(fileName);

        // Try to determine file's content type
        String contentType = null;
        try {
            contentType = request.getServletContext().getMimeType(resource.getFile().getAbsolutePath());
        } catch (IOException ex) {
            log.info("Could not determine file type.", ex);
        }

        // Fallback to the default content type if type could not be determined
        if (contentType == null) {
            contentType = "application/octet-stream";
        }

        return ResponseEntity.ok()
                .contentType(MediaType.parseMediaType(contentType))
                .header(HttpHeaders.CONTENT_DISPOSITION, "attachment; filename=\"" + resource.getFilename() + "\"")
                .body(resource);
    }

@Configuration
@EnableSwagger2
public class CboSwaggerConfig extends SwaggerConfig {

    @Bean
    public Docket apiCbo() {
        return new Docket(DocumentationType.SWAGGER_2)
                .groupName("CBO Simulateur")
                .select()
                .apis(RequestHandlerSelectors.basePackage("fr.grouperatp.oiv.simulator.cbo"))
                .paths(PathSelectors.any())
                .build()
                .apiInfo(apiInfo());
    }
}

If I replace "CBO Simulateur" with "CBO_Simulateur", swagger work again


unit llPDFJBIG2; problems

On unit llPDFJBIG2; no forward declaration for ANY function/procedure.
Using D10.2.3

Fixed


How to specify custom Maven Repository when running in CLI or Docker

Thanks for this project and all the hard work you are doing for securing the web. I am trying to get the DependencyCheck working from the CLI/Docker in order to bulk check multiple applications before deployment.
I am however unsure how to specify a custom maven repository using an settings.xml or similar in this configuration. Currently DependencyCheck tries to download from Maven Central which does not have all of the dependencies for my applications.

Output
[INFO] Checking for updates
[INFO] Skipping NVD check since last check was within 4 hours.
[INFO] Check for updates complete (21 ms)
[INFO] Analysis Started
[INFO] Finished Archive Analyzer (1 seconds)
[INFO] Finished File Name Analyzer (0 seconds)
[INFO] Finished Jar Analyzer (1 seconds)
[WARN] Unable to download pom.xml for ***.war: ***.jar from Central; this could result in undetected CPE/CVEs.
[INFO] Finished Central Analyzer (38 seconds)
[INFO] Finished Dependency Merging Analyzer (0 seconds)
[INFO] Finished Version Filter Analyzer (0 seconds)
[INFO] Finished Hint Analyzer (0 seconds)
[INFO] Created CPE Index (1 seconds)
[INFO] Finished CPE Analyzer (2 seconds)
[INFO] Finished False Positive Analyzer (0 seconds)
[INFO] Finished Cpe Suppression Analyzer (0 seconds)
[INFO] Finished NVD CVE Analyzer (0 seconds)
[INFO] Finished Vulnerability Suppression Analyzer (0 seconds)
[INFO] Finished Dependency Bundling Analyzer (0 seconds)
[INFO] Analysis Complete (44 seconds)
[ERROR] Error generating the report for My OWASP Dependency Check Project

Does the ./report directory exist?  Can you add a log file to get more info on what is going on?
docker run --rm \
    --volume ./target:/src \
    --volume ./data:/usr/share/dependency-check/data \
    --volume ./report:/report \
    owasp/dependency-check \
    --scan /src \
    --log /report/dc.log
    --format "ALL" \
    --project "My OWASP Dependency Check Project"

Thanks @jeremylong for the prompt response!
I added --log and --out to the report directory and now the report gets generated successfully!
It still complains about one dependency not found in Maven Central, but it looks like it is working.
I have attached the dc.log here.


Test for: FileTarget fails to write to primary log file when archive files do not match DateAndSequence numbering pattern

Prove that https://github.com/NLog/NLog/issues/1664 has been fixed.
fixes https://github.com/NLog/NLog/issues/1664
Tested in 4.3.7 and unit test fails there

This change is

Current coverage is 80% (diff: 100%)

Merging #1696 into master will increase coverage by <1%

@@             master      #1696   diff @@
==========================================
  Files           274        274
  Lines         16871      16871
  Methods        2666       2666
  Messages          0          0
  Branches       1871       1871
==========================================
+ Hits          13499      13507     +8
+ Misses         2928       2919     -9
- Partials        444        445     +1

Powered by Codecov. Last update 33b0bea...5f31f0c


How to config webpack to reuse existing dependencies from the main bundle

Ask your Question
Hi team,
I try to using repack v4 with Module Federation plugin in sub app  but after run webpack bundle size. The output bundle still content shared dependencies (react, react-native).
I research from document
Beware, with dynamic scripts there's no dependency sharing by default. If you want your scripts to reuse existing dependencies from the main bundle, it's up to you to figure out how to do it. A good starting point would be: https://webpack.js.org/configuration/externals/ https://webpack.js.org/plugins/dll-plugin/
How to config webpack dll plugin in host app and miniapp to reuse existing dependencies from the host app bundle (react, react-native)
Thanks team.

@trinhhcse
Correct me If I'm wrong, but I'm guessing you are talking about the shared dependencies still being present in the output directory of the mini-app despite being declared shared right?

@jbroma Yes, that’s right.

You can add import: false to shared dependency config to prevent that (next to singleton and eager, for each dep)

I tried it. It works like a charm. Thanks you.


Added an example for redacted vcon

Added examples/redact.py to redact dialog texts and add it to the vcon as analysis object(s).
Renamed the googlemeet recording file name to be windows compatible, so that git pull works on windows.

@dgpetrie any input on these build failures? they dont look related to the changes in this PR. Appreciate any pointers, thanks!

Several of the failures are due to the the Deepgram and OpenAI keys are not set.

Oh ok, how to set these keys for automated tests?

I think that you will also need to add the dataprofiler package and any other new dependencies to vcon/docker_dev/pip_package_list.txt


[Pick up city UBS.UBS Admin Cabinet]  Admin sees sorting of packages of each size in ascending order on one line in Orders table

Environment: Windows 10 Pro v.21H2, Google Chrome 111.0.5563.65 (64-bit).
Reproducible: always.
Build found: 19/03/23
Preconditions

User is logged in as administrator.
Orders tab is opened.
At least 1 order is in the orders table.

Steps to reproduce

Pay attention to the order of sorting of packages of each size ’ in the column ‘Bags amount’.
e.g. order 1157

Actual result
Packages of each size are sorted in ascending order on one line.
20л - 1шт; 60л - 1шт; 120л - 2шт

Expected result
Packages of each size should be sorted in descending order on one line.
120л - 2шт; 60л - 1шт; 20л - 1шт
User story test case links
User story #3184
Test case"
Labels to be added
"Bug", Priority ("pri: Medium"), Severity ("severity:  Minor"), Type ("UI").

We have no access to the Pick up city UBS.Admin Cabinet.


Bug 294208 : VS hangs while trying to reload a project in the background

Remove the unnecessary ExecuteSynchronously call which wrapped the async operations.

What's the background on this? Why did this hang?

Bill, the change itself looks good. Would like to know why this caused a deadlock for my own education.
Can we get this merged in?

I guess y'all know it hangs in 15.0.26014.0 when reloading after saving an edit to the <TargetFrameworks> value, just double checking.

Edit: also when unloading projects while closing, trying to avoid reloading.

@jnm2 That is not known and I cannot reproduce this. Can you file it?
@BillHiebert What's going on with this change? Can we merge it in?

I retargeted this PR to master from RC2 (which is now closed). I'll merge in next week.

@davkean I'll get a repro for the hang when reloading after saving an edit to the <TargetFrameworks> value. In the meantime, you can repro the hang when unloading projects in general by cloning https://github.com/nunit/nunit and opening src/nunit.sln, making sure all projects are loaded (by building?), and then close the solution or try to open a new solution. It gets as far as unloading project 6 of 60 and seems to hang indefinitely.

Or as the case may be, it just hangs at "Uploading project 0 of 60: path\to\solution.sln" (tested in today's update).

@jnm2 I've filed that hang: https://github.com/dotnet/roslyn-project-system/issues/1089, however, that hang will be different to the other hang.
It "unloading" projects - is just it closing the project.

Just now in the NUnit solution, I switched branches which changed a project file. Rather than click "Reload solution" I clicked "Reload" and it has frozen on the first project with "Unloading project file ..." It's a good couple minutes in with no sign of progress. NuGet restores happen in seconds.
I'll test for the TargetFrameworks thing now.

Another thing is that double-clicking a Git repository will sometimes but not always cause a similar hang. I wonder if this is somehow related to Git. I'll test in a project without version control.

Let me run in safe mode while I'm at it.

Oh no! No hangs in safe mode. I really hope I'm not misleading you here. Binary search time...

Though to be fair, Git was also not loaded.

Not sure what SafeMode turns off, can you start a new issue on this? This PR isn't a good place to discuss - this issue is probably unrelated.

What's the MEF errors you see?

@davkean They were errors that only showed up the first time after installing NCrunch and ReSharper. I can't reproduce in 15.0.26020 and it looks pretty likely that the bug was not yours. I'm sorry I didn't think of disabling them before saying something.

@davkean By the way, I truly appreciate how hard everyone is working to build the right system. It's so exciting, I can't wait to use it everywhere!

👍 to @jnm2's sentiment.  This project is the only (major) one that I have followed on GitHub and it is pretty incredible to watch all the activity.  I can't tell if I am more of a creeper or a fan by going through each and every activity that lands  in my inbox each and every day. 👼 Usually I just turn off all the notifications but for some reason I've found myself sticking with this one.  It's a bit of a marvel to witness.  Really great work here, team!


Remove console.log, events and serv.log should be used

serv.log can't be used in a serverInject though

In listeners of serverInject it can. And you don't need to print anything on plugin loading (and if you really really need it, use 'asap')


Accept arguments in useQuery dispatch

Closing in favor of the new approach which allows dispatch to override the query variables with an argument


A user base user who is added to a RKE2 cluster with "Manage Nodes" sees a weird screen for view config

v2.6-head 8/24

Create a RKE2 cluster
Add a user base user with Manage Nodes role
Login as user base user
Navigate to cluster through Cluster Management
Switch to "Config" view

See the following screenshot of the view

Is this backend or frontend issue? What perms are missing for the UI to be able to display Cluster config?

Added more checks to only load more types if you can see them...


fix: inverted list padding

📜 Description
I noticed the padding is incorrectly added if the Flatlist/Flashlist is inverted. Also, I have noticed that because of the bottom tab navigation, the offset when the keyboard is opened is not correctly calculated and the bottom tab height should be deducted.
💡 Motivation and Context
This problem fixes padding on inverted flatlist/flashlist if the keyboard is opened.
📢 Changelog
JS

added inverted handling
added property to be able to adjust the offset when the keyboard is opened

🤔 How Has This Been Tested?
It was tested in the app.

@kirillzyusko I will try your suggestion and get back to you. Thank you for your promptness

@lpatrun I also merged some PRs into main and I think they can produce a conflict with your PR. May I ask you to merge/rebase your branch onto latest main?

@lpatrun what is the status of this PR? Are you going to finish the changes that I requested or not? 👀

@kirillzyusko my apologies, I will finish it

@kirillzyusko I made changes and I have tested with and without the inverted prop.

I approved to see if CI passes or not 👀

@lpatrun TS is failing 😔

@kirillzyusko how about now?


User experience Optimization: API & Language selection should displayed in the home page and start page

User experience Optimization: API & Language selection should displayed in the home page and start page.
Thanks for your job.

I don't understand this issue ..
you looking for something like this?
http://docs.bitshares.eu/api/

@xeroc sorry, I didn't explain it clearly. I mean, for newbies:
If you are an American, don't understand Chinese, what do you want to do when you open a Chinese website? I will change the Default Language first.
API servers are in different countries, the default API server of BitShares 2.0 GUI is OpenLedger, then some people may be difficult to access OpenLedger, he might have been unable to enter the wallet home page. He need to change the Defaule API server first.
I hope you can understand this now.

This is something we talked about for the revamp of account creation but got lost somewhere, it's definitely something we should do.

This issue was moved to bitshares/bitshares-ui#63


Audio pitch shift

When the recording frequency in the MicrophoneManager does not match the encoding frequency in the VoiceManager, the audio is pitch shifted upwards.
I imagine the fix for this is to make the encoder actually match the recording frequency of the MicrophoneManager, updating the frequency whenever the mic device is changed

Commit https://github.com/roydejong/BeatSaberMultiplayerChat/commit/a440f110c29dc02a285d64e10cc705b3b05c5ac8 now also adds automatic resampling to 48 kHz.
I've also changed the default mic target to 48000, it should have been set to that already.


Fix how route/category change observers are managed

In my attempt to move from selector to block based notification observers in #1188 I inadvertently introduced the ability to add the same observer multiple times. Once a route change did happen and multiple route change observers were in place (as a result of starting more than initially) restartEngineAfterRouteChange(…) could be called multiple times in quick secession which in turn called start() and seemingly causing a cascade of restarts. A fun symptom of this was "volume thrashing" in control center:

Before Merging

[x] Replace both TODO comments with explanations for future contributors.
[x] Potentially find a Swiftier way to check if the observers exist before attempting to remove them.
[ ] Confirm that replacing an observer reference so that it loses scope removes it.

I think that once this is merged, we'll come out with a 4.2.4


fix: removal of dynamic profiles fix

Description
When * is encountered only dynamically created profiles are removed
Type of change

[x] Bug fix

How Has This Been Tested?
I reproduced scenario from bug description and verified that after the fix the problem disappeared.
Checklist

[x] My commit message is conventional
[x] I have run pre-commit on all files before creating the PR
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have checked my code and corrected any misspellings

:tada: This PR is included in version 1.5.0-develop.38 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Can't find Flow definition files

I seem to recall that Flow definitions had been added here last year. Now I can't find them. Were they removed?
Or are they being generated from TypeScript definitions?

Yeah, flow support was dropped

Any plans to add the flow types to flow-typed? I've been waiting for months to use this in a project, and I finally got a chance. I guess I can downgrade and keep using 0.6.8.

I added an FAQ section to the documentation (soon to be merged) with a short statement about fp-ts not supporting Flow types anymore, so I will close this issue for now.


ignore upgrades dir in linters and formatters and precommit

i ran into this issue with pre-commit linting this lnbits/upgrades/ directory

Codecov Report

Merging #1783 (a04330d) into main (7e1f439) will decrease coverage by 6.65%.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main    #1783      +/-   ##
==========================================
- Coverage   55.44%   48.80%   -6.65%
==========================================
  Files          47       47
  Lines        7250     7250
==========================================
- Hits         4020     3538     -482
- Misses       3230     3712     +482

see 17 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Model is not Giving Correct results

The trained model which you have provided is not giving correct results

The trained model which you have provided is not giving correct results

I have also tried re training the model using code provided in notebook file but not able to import tensorflow_hub.

I have also tried re training the model using code provided in notebook file but not able to import tensorflow_hub.

The current code provided by @frogermcs is not compatible with TensorFlow 2.0.
In my fork I did some adaptions to resolve this.
@frogermcs If you want, I can create a Pull Request.

It would be great if you can do this! 🙏 :)


[IMPROVEMENT] Reworked Node Operator fee change mechanism

Node Operator Fee Update Mechanism
The system manages operator fees using two storage areas: StakingStorage for the currently active fee, and NodeOperatorFeeChangesStorage for pending fee updates.
High-Level Sequence Diagram

Initial State
At the start, the operator's fee is recorded only in StakingStorage. This fee is used for all calculations until any update occurs.
Updating the Fee
1. Initiating an Update: When a node operator decides to update their fee, they submit the new fee along with an "activation timestamp" to NodeOperatorFeeChangesStorage. This activation timestamp is set to 28 days from the update submission, marking a delay period before the new fee takes effect.
2. Transitioning Fees: If there's already a pending fee update in NodeOperatorFeeChangesStorage, this pending fee is moved to StakingStorage to become the current active fee. The new update then waits in NodeOperatorFeeChangesStorage until its activation timestamp.
Reward Collection Check

When collecting rewards, the system checks for any pending fee updates in NodeOperatorFeeChangesStorage.
If an update has become "active": This is determined by checking if the activation timestamp of the fee in NodeOperatorFeeChangesStorage has passed after the close of the Commit Window for the current epoch.

If yes (the update became active after the Commit Window closed), the system uses the fee from StakingStorage for calculations, as this represents the fee before the latest update.
If the update's activation timestamp was during the Commit Window or in previous epochs, the system adopts the new fee from NodeOperatorFeeChangesStorage for calculations.

This process ensures that fee updates are transparently managed, maintaining fairness in fee application across commits/proofs.

Pros:

No storage changes
1 tx for Node Operator fee change instead of 2 txs

Cons:

Removal of the fee change finalization event (affects dependent indexers)
More complicated way of checking current operator fee as you potentially need to check in 2 places to find active operator fee

Hi,
Let me check I follow you here (from indexer point of view)
Current state - new value for operator fee becomes active after second transaction which emits staking_operator_fee_change_finished.
Proposed new state - new value for operator fee becomes active after datetime=[timestamp] from staking_operator_fee_change_started event emitted by first transaction. No second transaction needs to be issued.
Also i'm not sure i'm clear here

Transitioning Fees: If there's already a pending fee update in NodeOperatorFeeChangesStorage, this pending fee is moved to StakingStorage to become the current active fee. The new update then waits in NodeOperatorFeeChangesStorage until its activation timestamp.

Active fee - 1%, no pending fee.
I issue 1st tx (2% fee), active fee is still 1%, pending fee is 2%.
I issue another tx to update fee (3%), according to above my active fee should become 2% and pending 3%.
Which does not make sense as 28 days haven't passed yet.

Hi, Let me check I follow you here (from indexer point of view)
Current state - new value for operator fee becomes active after second transaction which emits staking_operator_fee_change_finished.
Proposed new state - new value for operator fee becomes active after datetime=[timestamp] from staking_operator_fee_change_started event emitted by first transaction. No second transaction needs to be issued.
Also i'm not sure i'm clear here

Transitioning Fees: If there's already a pending fee update in NodeOperatorFeeChangesStorage, this pending fee is moved to StakingStorage to become the current active fee. The new update then waits in NodeOperatorFeeChangesStorage until its activation timestamp.

Active fee - 1%, no pending fee. I issue 1st tx (2% fee), active fee is still 1%, pending fee is 2%. I issue another tx to update fee (3%), according to above my active fee should become 2% and pending 3%. Which does not make sense as 28 days haven't passed yet.

Hi,
It's a little bit different from what you described. Even if "active timestamp" now is in the past, it doesn't mean that new operator fee will apply for all proofs (rewards). For new operator fee to become active, 2 requirements should be satisfied:

Fee change timestamp should pass (28 days delay)
For given KA, Fee change timestamp should overlap with the Commit Window, otherwise it will become active starting from the next epoch

Regarding scenario you described, it's not possible to update fee when there is a pending change

I see, so in this case fee can be updated at most once in 28 days, right?
I see examples of node operators changing their fees more often. Yeah, that would be a downgrade from a current process.
I agree that issuing 2 txs to change operator fee is worse then 1 tx. But I'm not sure this 1 tx difference makes up for all the Cons.
From node operator point of view I pick 2 txs solution (with ability to change my mind every day) over 1 tx solution (i can change my mind only every 28 days). Operator also can make mistakes, like fat-finger 100% fee. So 1 tx solution makes it very hard to fix these mistakes.
From othub indexer 1 tx solution adds complexity, with no obvious benefit.

I see, so in this case fee can be updated at most once in 28 days, right? I see examples of node operators changing their fees more often. Yeah, that would be a downgrade from a current process.
I agree that issuing 2 txs to change operator fee is worse then 1 tx. But I'm not sure this 1 tx difference makes up for all the Cons.
From node operator point of view I pick 2 txs solution (with ability to change my mind every day) over 1 tx solution (i can change my mind only every 28 days). Operator also can make mistakes, like fat-finger 100% fee. So 1 tx solution makes it very hard to fix these mistakes.
From othub indexer 1 tx solution adds complexity, with no obvious benefit.

Well, this is not a 1 tx vs 2 txs problem, main purpose of this rework is to remove possibility to change operator fee for commits that are already locked

@botnumberseven I think this problem can be resolved with the following mechanism
SS - staking storage
NOFCS - NodeOperatorFeesChangeStorage

I set operator fee to 1% initially (stored in SS)
I update operator fee to 2% (timestamp=now+28days, request stored in NOFCS)
I update operator fee to 3% (newTimestamp=now+28days)

If now <= timestamp -- move 2% to SS, store 3% with newTimestamp in NOFCS
Else if now > timestamp -- replace 2% in NOFCS with 3% and newTimestamp

I see
From othub point of view that would require be a fair amount of changes in staging/stats tables as operator fee becomes a property of node-asset-epoch-?time?, rather then just node-time (like Ask). So the fee value need to be determined for every proof.
Could you help me with an example of how to calculate it based on tx and events data?

@botnumberseven I'll help you with that when final implementation is confirmed


[Harvest] ...

Extension
https://www.raycast.com/eluce2/harvest
Description
When setting the time format to hours:minutes, the menu bar item doesn't reflect these changes.
Steps To Reproduce

Set time format to hours:minutes
Check the running timer in the menu bar

Current Behaviour
Keeps displaying decimal time in menu bar
Expected Behaviour
Adapts to the selected time format

I'm having the exact same issue

Thanks everyone, oversight on my end. A fix is in the works!


deltaQ's first few G estimates are very wrong.

DeltaQ's first estimates of g are normally around, -1200s, 12s, -10s. Expected value should be 5ms - 1s.

That would imply that the timestamps for the events are not being taken at the right points ; -1200s suggests something like bad initialisation

Fixed in #2636


BUGFIX: Redo roof prep [URGENT]

The roof prep I made was too shoddy and it has to be redone more professionally.

the pop edges are not aligned
the front thing is 90 degrees flat to the horizon when it should be at the same angle (8) as the roof
the bottom edges are not aligned

Yokoyama says he will handle it.
For now, I should remove it.
It's almost December and snow is forecasted for everyday next week.
It might simply be easier to  cover up everything and wait till next Spring. This year's winter is projected to be short anyway due to El Nino.
Tasks

[x] remove top and bottom strips

I've removed all the strips.
After checking the weather forecast for the next two weeks, I've realised that it's not likely the roof will get done this year. So I've chosen to place a tarp over the roof.


"server_key is not a valid"after updating to latest verion when calling client.UpdateAppSettings

I recently updated to the latest version v3.12.1 (previously it seems that i was using v1.0.0, I didn't pay attention (or it was missing) to the README which shows both an import to /v3 and an installation step with /v3 at the end.
Here's my code right now -
	streamChatClient, err := streamchat.NewClient(streamKey, streamSecret)
	if err != nil {
		return nil, nil, err
	}
	streamChatClient.BaseURL = "https://chat-proxy-dublin.stream-io-api.com"
	err := streamChatClient.UpdateAppSettings(&streamchat.AppSettings{
		FirebaseConfig: &streamchat.FirebaseConfig{
			Enabled: true,
			DataTemplate: `{
    "sender": "{{ sender.id }}",
    "dm_id": "{{ channel.id }}",
    "message": "{{ message.id }}"
}`,
			NotificationTemplate: `{
	"title": "{{ sender.nickname }}",
	"body": "{{ message.text }}",
	"sound": "default"
}`,
		},
	})

but upon starting that code I get the following error -
chat-client: HTTP PATCH https://chat-proxy-dublin.stream-io-api.com/app?api_key=<snip> status 400 Bad Request: {"code":4,"message":"UpdateApp failed with error: \"server_key is not a valid\"","StatusCode":400,"duration":"0.00ms","more_info":"https://getstream.io/chat/docs/api_errors_response"}

What were some changes from v1 to v3 that could be causing this issue?

You should provide your server key if firebase is enabled. It could be found in firebase console project settings / cloud messaging section.
type FirebaseConfig struct {
	Enabled              bool   `json:"enabled"`
        // New field is already there
	ServerKey            string `json:"server_key"`
	NotificationTemplate string `json:"notification_template,omitempty"`
	DataTemplate         string `json:"data_template,omitempty"`
}

You should provide your server key if firebase is enabled. It could be found in firebase console project settings / cloud messaging section.
type FirebaseConfig struct {
	Enabled              bool   `json:"enabled"`
        // New field is already there
	ServerKey            string `json:"server_key"`
	NotificationTemplate string `json:"notification_template,omitempty"`
	DataTemplate         string `json:"data_template,omitempty"`
}

Thank you!


Populate database: keep Compound Disease path counts

refs https://github.com/greenelab/hetmech/issues/174

Hit an error populating the database with https://github.com/greenelab/connectivity-search-backend/pull/79/commits/50801395c58311b7e18c890922b2875c3a875c06:
python manage.py populate_database --max-metapath-length=3 --batch-size=12000                 _download_hetionet_hetmat(self=<dj_hetmech_app.management.commands.populate_database.Command object at 0x7fba5f845700>) ran in 0:00:00
_populate_metanode_table() ran in 0:00:00
_populate_node_table() ran in 0:00:21
_populate_metapath_table() ran in 0:00:00
_download_path_counts(length=1) ran in 0:00:02
_populate_degree_grouped_permutation_table(length=1) ran in 0:00:51
_download_path_counts(length=2) ran in 0:00:49
_populate_degree_grouped_permutation_table(length=2) ran in 0:07:52
_download_path_counts(length=3) ran in 0:10:21
_populate_degree_grouped_permutation_table(length=3) ran in 0:45:36
_populate_path_count_table() ran in 2 days, 21:10:16
Exception ignored in: <function Driver.__del__ at 0x7fb9d8213280>
Traceback (most recent call last):
  File "/home/dhimmel/miniconda3/envs/hetmech-backend/lib/python3.8/site-packages/neo4j/__init__.py", line 277, in __del__
  File "/home/dhimmel/miniconda3/envs/hetmech-backend/lib/python3.8/site-packages/neo4j/__init__.py", line 307, in close
  File "/home/dhimmel/miniconda3/envs/hetmech-backend/lib/python3.8/site-packages/neo4j/io/__init__.py", line 488, in close
  File "/home/dhimmel/miniconda3/envs/hetmech-backend/lib/python3.8/site-packages/neo4j/io/__init__.py", line 477, in remove
  File "/home/dhimmel/miniconda3/envs/hetmech-backend/lib/python3.8/site-packages/neo4j/io/_bolt3.py", line 390, in close
AttributeError: 'NoneType' object has no attribute 'debug'

Will investigate.

Hit an error populating the database with https://github.com/greenelab/connectivity-search-backend/pull/79/commits/50801395c58311b7e18c890922b2875c3a875c06:
python manage.py populate_database --max-metapath-length=3 --batch-size=12000                 _download_hetionet_hetmat(self=<dj_hetmech_app.management.commands.populate_database.Command object at 0x7fba5f845700>) ran in 0:00:00
_populate_metanode_table() ran in 0:00:00
_populate_node_table() ran in 0:00:21
_populate_metapath_table() ran in 0:00:00
_download_path_counts(length=1) ran in 0:00:02
_populate_degree_grouped_permutation_table(length=1) ran in 0:00:51
_download_path_counts(length=2) ran in 0:00:49
_populate_degree_grouped_permutation_table(length=2) ran in 0:07:52
_download_path_counts(length=3) ran in 0:10:21
_populate_degree_grouped_permutation_table(length=3) ran in 0:45:36
_populate_path_count_table() ran in 2 days, 21:10:16
Exception ignored in: <function Driver.__del__ at 0x7fb9d8213280>
Traceback (most recent call last):
  File "/home/dhimmel/miniconda3/envs/hetmech-backend/lib/python3.8/site-packages/neo4j/__init__.py", line 277, in __del__
  File "/home/dhimmel/miniconda3/envs/hetmech-backend/lib/python3.8/site-packages/neo4j/__init__.py", line 307, in close
  File "/home/dhimmel/miniconda3/envs/hetmech-backend/lib/python3.8/site-packages/neo4j/io/__init__.py", line 488, in close
  File "/home/dhimmel/miniconda3/envs/hetmech-backend/lib/python3.8/site-packages/neo4j/io/__init__.py", line 477, in remove
  File "/home/dhimmel/miniconda3/envs/hetmech-backend/lib/python3.8/site-packages/neo4j/io/_bolt3.py", line 390, in close
AttributeError: 'NoneType' object has no attribute 'debug'

Will investigate.

Hit an error populating the database with 5080139

The error is happening when the neo4j driver connection closes. See https://github.com/neo4j/neo4j-python-driver/blob/4.0.0/neo4j/io/_bolt3.py#L390. Luckily, this is occurring after the database has been fully populated, since _populate_path_count_table() ran in 2 days, 21:10:16.
Perhaps neo4j-python-driver 4.2.1 fixes this: upgraded in https://github.com/greenelab/connectivity-search-backend/pull/79/commits/b27c0e975c68eb17d4a47644d838ad6ffedf357e. Will open a separate issue if we see this again.
Database import was slightly faster than last time: https://github.com/greenelab/connectivity-search-backend/pull/41#issuecomment-488054789 by ~20 hours (guessing this is due to newer hardware, since we're actually importing more data).

Hit an error populating the database with 5080139

The error is happening when the neo4j driver connection closes. See https://github.com/neo4j/neo4j-python-driver/blob/4.0.0/neo4j/io/_bolt3.py#L390. Luckily, this is occurring after the database has been fully populated, since _populate_path_count_table() ran in 2 days, 21:10:16.
Perhaps neo4j-python-driver 4.2.1 fixes this: upgraded in https://github.com/greenelab/connectivity-search-backend/pull/79/commits/b27c0e975c68eb17d4a47644d838ad6ffedf357e. Will open a separate issue if we see this again.
 Specifically, this PR adds 3,403,805 rows, all of which are from Compound...Disease metapaths:
path_count_rows_before    166199174
path_count_rows_after     169602979

So not sure why the previous row count for the path_count table was inflated. But for the current export, the database_info command output and SQL output match.

PathCount Table now has fewer rows (169,602,979 rows now versus 174,986,768 rows before)

I looked into this in https://github.com/greenelab/hetmech/pull/175 / connectivity-search-backend-pull-79.ipynb and found that the current production database, which I'm pretty sure was created in https://github.com/greenelab/connectivity-search-backend/pull/41, doesn't actually have any more rows. Specifically, this PR adds 3,403,805 rows, all of which are from Compound...Disease metapaths:
path_count_rows_before    166199174
path_count_rows_after     169602979

So not sure why the previous row count for the path_count table was inflated. But for the current export, the database_info command output and SQL output match.


Workflow validation failed and is unable to switch to designer view

Describe the Bug with repro steps
All our consumption logic apps that use integration account (xslt transformation, liquid, edifact encoding) can't be edited in the portal and for some the logic app designer appears empty. We didn't change anything and this happens in different subscriptions and integrations accounts.
Error message:

Workflow Settings:

What type of Logic App Is this happening in?
Consumption (Portal)
Which operating system are you using?
Windows
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON

Screenshots or Videos
No response
Browser
Chrome
Additional context
No response

Hi @josegomes41 would you be able to try on our staging link https://portal.azure.com/?feature.canmodifystamps=true&Microsoft_Azure_EMA=staging#home there was a fix that is currently going out that is there to fix a code view issue where its unable to get the integration account

Hi @Eric-B-Wu
I don't get the integration account error but for some logic apps I can't see anything in the designer:
Example:

The logic runs and I can see the run details:

Best Regards

Would you be able to send har and console logs to me at<EMAIL_ADDRESS>following these steps: https://agreeable-beach-04ed7ce1e.5.azurestaticapps.net/tsg#collecting-console-errors? This'll let me look at which part could be failing

closing issue, followed up through email - turned out to be Referenced shape does not exist issue due to new designer being case-sensitive


calamares-nixos-extensions 0.3.12 -> 0.3.13

Description of changes
Update including #21 and #20.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2526

@vlinkz ping?
Foxes vuln https://github.com/NixOS/calamares-nixos-extensions/security/advisories/GHSA-3rvf-24q2-24ww


InputType Array Validation

Discussed in https://github.com/hayes/pothos/discussions/921

Originally posted by enri90 May 26, 2023
I have a problem with the module
https://pothos-graphql.dev/docs/plugins/validation
when I use an inputType in array it doesn't parse for validation
export const BlockByInput = builder.inputType('BlockByInput', {
  fields: (t) => ({
    code: t.string({
      required: true,
      validate: {
        schema: z.string().min(1).max(5),
      },
    }),
  })
})

the code is not parsed validation
t.stringList({
  nullable: false,
  args: {
    blocks: t.arg({
      type: [BlockByInput],
      required: true,
    }),
  },
  errors: {
    types: [ZodError],
  },

the code is parsed
t.boolean({
  nullable: false,
  args: {
    block: t.arg({
      type: BlockByInput,
      required: true,
    }),
  },
  errors: {
    types: [ZodError],
  },

This is a bug, just pushed a fix that should resolve this

fix is published now


Fix a crash when an issue is recorded on a detached task.

Given the following code:
@Test func f() async {
  await Task.detached {
    #expect(1 == 2)
  }.value
}

An issue is recorded on a detached task, but Swift Testing is unable to determine at runtime which test it corresponds to. This should simply result in the issue being attributed to an arbitrary test, or to the aether, but #421 caused a regression that triggers an optional unwrap crash instead.
This PR fixes the crash. :)
Checklist:

[x] Code and documentation should follow the style of the Style Guide.
[x] If public symbols are renamed or modified, DocC references should be updated.

@swift-ci please test


[Feat]: Add a dark mode.

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I want to add a dark mode to the website.
Use Case
It looks more attractive.
Benefits
No response
Priority
High
Agreements

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC contributor
[X] I'm a Hacktoberfest contributor
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

@Tejashri-Taral

please assign me this issue so i can start working on the same.


Guard against missing currentDragEvent

I know this isn't really a "solution" -- just a quick hack -- but it prevents https://github.com/mharris717/ember-drag-drop/issues/146

Seems like it would be fine. I'd really appreciate if there was a test added to check for it though. If you can find some time to add it, I'd appreciate it!


all-shards cluster

We have a use case where we would like to have multiple CH clusters, but allow querying all shards from each cluster from a single place, similar to all-sharded. The key difference being that we respect the replication of shards, instead of treating each replica as its own shard.
For example:
clusters:
  prod_one:
    replicas: 2
    shards: 2
  prod_two:
    replicas: 2
    shards: 2

and have a resulting settings.conf cluster like
<clusters>
  <all-shards>
    <shard>
      <internal_replication>True</internal_replication>
      <replica>
        prod_one-0-0 // shorthand for brevity
      </replica>
      <replica>
        prod_one-0-1
      </replica>
    </shard>
    <shard>
      <internal_replication>True</internal_replication>
      <replica>
        prod_one-1-0
      </replica>
      <replica>
        prod_one-1-1
      </replica>
    </shard>
    <shard>
      <internal_replication>True</internal_replication>
      <replica>
        prod_two-0-0
      </replica>
      <replica>
        prod_two-0-1
      </replica>
    </shard>
    <shard>
      <internal_replication>True</internal_replication>
      <replica>
        prod_two-1-0
      </replica>
      <replica>
        prod_two-1-1
      </replica>
    </shard>
  </all-shards>
</clusters>

We could then create a distributed table on the all-shards cluster, which would fan out the query to each shard in all clusters.
I have a draft of the code required to do so already. If a PR for this is welcome, I will happily make one

We are welcome to PR
but please name this cluster as something like chi-<chi_name>
all-shards like not mental name because all-sharded means entirely different behavior
Moreover, could you explain more detailed your use case?
Why do you need different clusters instead of just using:
clusters:
  prod:
    layout:
      replicasCount: 2
      shardsCount: 4

Actually, operator currently missing any way to customize remote_servers configuration, probably some templating option would be nice to have for it.
May be automatic cluster discovery feature can be used here(problem it's experimental, so potentially can be removed by ClickHouse team)
https://github.com/ClickHouse/ClickHouse/blob/4ff0eefe23f5209caa628b26f53f77790c761d0e/docs/en/operations/cluster-discovery.md?plain=1#L59

@UnamedRus yes, great suggestion
@tanner-bruce try to use
spec:
 configuration:
   files:
     config.d/whole-chi-cluster.xml: |
       <remote_servers>
         <all-prods>
           <discovery>
              <path>/clickhouse/discovery/{all-prods}</path>
           </discovery>
        </all-prods>
       </remote_servers>

IMO, it still make sense to have some templating options in operator, to generate such configuration.
For example, we need to populate shard value in config. (currently probably it can be done, if we populate value in config from ENV)


Add setting name on ConfigurationPolicy

When creating a policy with multiple manifests and consolidateManfifest: false the generated ConfigurationPolicies are names after the Policy with an index appended.
This causes issues when attempting to use extraDependencies such as below.  Adding an additional manifest will change the index causing the existing dependencies to be incorrect.
Allowing setting the name would also make it easier to identify in the UI when reviewing a policy.
Ref: https://issues.redhat.com/browse/ACM-12563

/cc @dhaiducek @mprahl

/unhold


Ensure that prfTime is loaded on the target node

prfTime can be called on the target node, so it needs to be loaded there.
Without this change, running redbug from the command line fails for me with this error:
09:32:57.749 [error] Error in process <0.845.0> on node<EMAIL_ADDRESS>with exit value: {undef,[{prfTime,ts,[],[]},{prf,incr,2,[{file,"src/prf.erl"},{line,48}]},{prf,ticker_odd,0,[{file,"src/prf.erl"},{line,45}]},{prfTarg,init,0,[{file,"src/prfTarg.erl"},{line,99}]}]}

fix dependency error

in 0.94.0


Add error handling to readme + examples

Resolves https://github.com/evoluhq/evolu/issues/59

Very nice, thank you!


Show pricing plan and limits

Thanks for submitting a PR! Please check the boxes below:

[X] I have run pre-commit to check linting
[X] I have filled in the "Changes" section below?
[ ] I have filled in the "How did you test this code" section below?

Changes

Updated the "upgrade" button to show Api calls in 30 days/max api  calls in the subscription, when only 30% left

How did you test this code?

Please describe.

@dabeeeenster a couple of product questions based on this PR

The PR adjusts the upgrade nav to show regardless of their plan, I'm not sure we'd want to do this? Especially with auto seats this seems more relevant to startup / free?
The PR adds a usage message based on <30% remaining, I guess maybe this is down the line but I'd have thought that the velocity of usage is more important than the amount remaining. E.g. 50% usage in the first 2 months

@kyle-ssg
point 1: I think we would want to show if people are near their limit regardless of their plan.
point 2: Given that the data is from the last 30 days, I think current data is fine.


Crash on --harmony flag

Are you requesting a feature or reporting a bug?
Reporting a bug
What is the current behavior?
min.js:
require('testcafe');

$ node --harmony min.js

/home/willem/w/bizaline/testcafe/node_modules/testcafe-hammerhead/node_modules/lodash/lodash.js:1244
    set.forEach(function(value) {
        ^
TypeError: Object #<Set> has no method 'forEach'
    at setToArray (/home/willem/w/bizaline/testcafe/node_modules/testcafe-hammerhead/node_modules/lodash/lodash.js:1244:9)
    at runInContext (/home/willem/w/bizaline/testcafe/node_modules/testcafe-hammerhead/node_modules/lodash/lodash.js:5452:35)
    at Object.<anonymous> (/home/willem/w/bizaline/testcafe/node_modules/testcafe-hammerhead/node_modules/lodash/lodash.js:16955:11)
    at Object.<anonymous> (/home/willem/w/bizaline/testcafe/node_modules/testcafe-hammerhead/node_modules/lodash/lodash.js:16982:3)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)

What is the expected behavior?
TestCafe is loaded, no crash occurs and users using NodeJS 4 LTS (4.7.2 / 0.10.29) can use ES5 functionality such as yield, rest parameters and spread operators.
How would you reproduce the current behavior (if this is a bug)?
Take up-to-date NodeJS from any supported Debian/Ubuntu, use --harmony flag, crash.
Specify your

operating system: Debian Testing
testcafe version: 0.12.0
node.js version: 0.10.29

Hello, @WillemMali! Unfortunately, the problem is in lodash package, just try require('lodash') with node --harmony: https://github.com/lodash/lodash/issues/2324. The reason is that some some ES6 classes have incomplete implementation under --harmony flag. However, lodash uses a polyfill, so it works fine without that flag. What's about ES6 features, you can use a transpiler, e.g. babel. It takes couple of minutes to setup, but it's not so hard with yeoman template - https://www.npmjs.com/package/generator-babel.


Not Completing Assert-Plus

For some reason I am not getting any completions for node-assert-plus
Note: Other imported modules like lodash and bunyan are working as expected.
.tern-project file:
{
  "plugins": {
    "node": {}
  }
}

Screenshot from VIM

Screenshot from VSCode

node-assert-plus's code is a little trick for ternjs to understand.
I think the easiest way to have support write a definition json file.


Multiple domain

It would be really nice if we could add multiple domains instead of just one.

Or at least I should be able to change the domain. Why is the domain field locked after the app is deployed?

@andrasbacsai this should be flagged for v2

@itsezc A small question about this enterprise-ready v2...
Is it going to be paid/freemium?

(I am not associated with this project in an official capacity) It is OSS, the development branch should be available on: https://github.com/coollabsio/coolify/tree/v2 and I would recommend joining the Discord community for direct communication with the development team.

@itsezc A small question about this enterprise-ready v2...
Is it going to be paid/freemium?

It will stay totally free and open-source!
I'm just adding these features (and refactoring the codebase) to have more use cases for Coolify. Not just for hobbyists but for enterprises.

V2 is released, with an option to define domain at runtime instead of installation time!

Hey @andrasbacsai,
Did you also add the feature of multiple domains?

Oh, no. Reopening.

Hi @andrasbacsai, any news on the progress for this? So having the possibility to proxy multiple domains for an application or service? Thanks :)

Multiple domains would really get me out of a bind right now. :grin:

Is it possible all fields with URL (FQDN) can be supplied a value like https://coolify.com;https://coolify.dev;https://coolify.dev
Semi colon separated urls and traefik will generate all ssl.
This is a must especially with SAAS setup.

+1 on this, being able to have multiple URLs (FQDN) for the same app would be gold.

I need domain-catchall feature🙌

Hey @andrasbacsai, any possibility that this could be implemented, even still in V3? Or if it will be supported in V4, when will this be ready so I could migrate from V3 to V4.... Thanks much for feedback on this! :)

Hey, I have a coolify app running on subdomain1.mydomain.com.
I have created another CNAME record subdomain2.mydomain.com and it points to subdomain1.mydomain.com.
I sit supported in coolify??

It is available in v4.
I'm closing this issue, because tracking features will be moved to GitHub discussions. Github issues will be only for bugs.
Version 4 is in full focus. v3 related issues will be closed, if it is not a critical bug.
Thanks for your understanding.

for v3 folks like me, you can now do this with my pr at https://github.com/coollabsio/coolify/pull/1505


Cannot recieve broadcasted events in the browser

Hello there,
I have a real time auctioning platform. I recently decided to switch from Pusher to socket.io. I configured everything and ran the laravel-echo-server command. Everything seems to be fine, except I cannot receive events in the browser. Everything is broadcasted perfectly from the backend. Can someone please help me out?
Versions of packages that are in use:
Laravel: 8
socket.io-client: 4.0.1
laravel-echo-server: 1.6.2
redis-server: 5.0.3
redis-server(package.json): 1.2.2
Here is a screenshot of my laravel-echo-server output(as you can see the event are being received here):

Code for broadcasting in my event:
public function broadcastOn()  {         return new PrivateChannel('auction.fives');   }
My bootstrap.js:
import Echo from 'laravel-echo';

 window.io = require('socket.io-client');

 window.Echo = new Echo({
    broadcaster: 'socket.io',
    host: '<IP_ADDRESS>:6001'
});

Listener in my vue file(I tried the event name with and without dot as a prefix. Nothing works):
window.Echo.channel('private-auction.fives')
        		.listen('Fives', (e) => {
        			console.log("sdf");
        			if(e.id == this.$route.params.id){
        				document.getElementById('hdenH').hidden = false;
        				document.getElementById('cdown').hidden = false;
        				this.startTicking();
        			}
        		});

Channels.php:
Broadcast::channel('auction.newbid', function ($bid) {
    return true;
});

I would like to add that pings to localhost:6001 from the browser are returned with a status code 200. As far as I know successful subscription mean a 101 status code. So I'm not sure if something is wrong there.
Any help would be much appreciated.
Thank you

I reverted the laravel-echo-server version to 2.3.1 and it worked


Error Route cache

Q
A

Bug?
yes

Framework
Laravel

Framework version
5.7.28

Package version
2.1.0

PHP version
7.2.15

when I run artisan commmand "php artisan route:cache" then run "php artisan api:cache"
all api routes are still not found, api:routes not show any route.

I have the same problem after updating from 2 beta to 2.1

I move mapApiRoutes() function from RouteServiceProvider to boot function. Currently bug is temporary fixed.

Bug fixed in 2.2.2 thanks @specialtactics

Fantastic ! Closing.


feat: support commas in PipelineRun annotations

This commit introduces support for using commas within annotations by
allowing users to escape them with the HTML entity ,. This ensures
compatibility with annotations that rely on comma-separated values while
also permitting the inclusion of literal commas in file paths or branch
names.
This enhancement maintains backward compatibility while enabling more
precise and flexible use of annotations.
Jira: https://issues.redhat.com/browse/SRVKP-6790
Signed-off-by: Chmouel Boudjnah<EMAIL_ADDRESS>Submitter Checklist

[ ] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).

[ ] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.

[ ] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).

[ ] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.

[ ] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.

[ ] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.

[ ] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).

This needs to be merged after #1823


Ticking checkboxes doesn't work

It's the same issue as #9, but I can't reopen this issue.

Unfortunately it's not possible to tick checkboxes inside admonition enviroment in preview.

Thank you for fixing again.

Reporting this is still an issue. Thanks!

Hi, this should be fixed in 6.7.3. Sorry this took so long!


Not working on iOS

Hi, I am trying to use this package, but it doesn't seems to work on iOS devices.
When I zooming out to the view of the whole globe or zooming in to the maximum possible zoom to the street nothing changes. Markers are not clustering to groups or anything.
I am using the following:
"react-native": "0.57.8",
"react-native-map-clustering": "^1.3.1",
"react-native-maps": "^0.23.0",
Thanks in advance for any help!

When i log your calculateClustersForMap method.
In the if (this.props.clustering && this.superCluster) true statement the clusters array computed from this.superCluster.getClusters() method always return an empty array.
After following trails to createMarkersOnMap method I figure out that markers and otherChildren arrays are empty too. Even after the computation, when you are trying to push items to one array or another with your if else statement inside of forEach function.
The issue is located in the marker.props.cluster. which is undefined.
In you documentation there is no such mention of that I have to add "cluster={true}" prop to every single Marker component. At least it is not obvious from the point 2. of the documentation.
Where the following stands:
<MapView
region={{latitude: 52.5, longitude: 19.2,
latitudeDelta: 8.5, longitudeDelta: 8.5}}
style={{width: mapWidth, height: mapHeight}}>
<Marker coordinate={{latitude: 52.0, longitude: 18.2}} />
<Marker coordinate={{latitude: 52.4, longitude: 18.7}} />
<Marker coordinate={{latitude: 52.1, longitude: 18.4}} />
<Marker coordinate={{latitude: 52.6, longitude: 18.3}} />
<Marker coordinate={{latitude: 51.6, longitude: 18.0}} />
<Marker coordinate={{latitude: 53.1, longitude: 18.8}} />
<Marker coordinate={{latitude: 52.9, longitude: 19.4}} />

Please update this part of your your docs to the following instead:
<MapView
region={{latitude: 52.5, longitude: 19.2,
latitudeDelta: 8.5, longitudeDelta: 8.5}}
style={{width: mapWidth, height: mapHeight}}>
<Marker coordinate={{latitude: 52.0, longitude: 18.2}} cluster />
<Marker coordinate={{latitude: 52.4, longitude: 18.7}} cluster />
<Marker coordinate={{latitude: 52.1, longitude: 18.4}} cluster />
<Marker coordinate={{latitude: 52.6, longitude: 18.3}} cluster />
<Marker coordinate={{latitude: 51.6, longitude: 18.0}} cluster />
<Marker coordinate={{latitude: 53.1, longitude: 18.8}} cluster />
<Marker coordinate={{latitude: 52.9, longitude: 19.4}} cluster />

Besides this little confusion I have to thank you for this module.
It's pretty neat and saves me a lot of work and effort.
Good job!

Ahhh snap.
Sorry my mistake.
I changed this to:
 if (marker.props.cluster === false) {
    otherChildren.push(marker);
    return;
 }

 if (marker.props && marker.props.coordinate) {
...

Now it will not cluster only if cluster={false}.
I updated module to versions 1.3.2
Let me know if that will work now for you ;)

Thanks Tomasz for your quick fix and response!
This little condition treatment of your forEach loop will definitely work!
I have updated your module to version 1.3.2, but somehow I still have the original source from version of 1.3.1.
But this could also be an issue with github versioning, I don't know...
Anyway, this fix works! Great job!

Ye it is often a problem cache.
You can try running:
npm start -- --reset-cache
or if you are using expo:
exp r -c
And restart your project ;)

@venits  just installed this library but it's still keeping the old code
React.Children.forEach(this.props.children, (marker) => {
if (marker.props && marker.props.coordinate && marker.props.cluster) {
markers.push({
marker,
properties: { point_count: 0 },
geometry: {
type: 'Point',
coordinates: [
marker.props.coordinate.longitude,
marker.props.coordinate.latitude,
],
},
});
} else {
otherChildren.push(marker);
}
});
What will i change to ?


Headless Chrome

Just need to create a bin-wrapper for it. Also, not sure if a streaming interface is available using https://github.com/cyrus-and/chrome-remote-interface. Worst case scenario is that we skip the streams altogether and just return a Promise or if we want to keep them, possibly just emit a data event with the buffer.

The only reason we're using streams today is to improve performance, as we have to decode a huge Base64 string. If Promise is possible, I would much prefer that.

Just need to create a bin-wrapper for it

I tried doing that two weeks ago but gave up. I couldn't find a version of Chrome that's just one binary that we can ship. Instead I tried doing it with the full blown Chrome from my computer which is like 160 MB or something. So if you guys can point me in the right direction, happy to create the wrapper.

Also, is this really something we want to maintain? For reference: https://github.com/Medium/phantomjs/issues?utf8=✓&q= (Note the issue count)

I was hoping I could just ignore Chrome Headless until someone did a bin wrapper, so I don't have to maintain it.

I was hoping I could just ignore Chrome Headless until someone did a bin wrapper, so I don't have to maintain it.

I'm afraid that if no one of us does it, nobody will do it :p. Maintaining a bin-wrapper doesn't feel as complex as maintaining PhantomJS, or am I missing something? It's just a binary, right?

Well, I had a look at it yesterday and it doesn't seem too complex tbh. I'd just get the latest revision from here https://chromium.woolyss.com/#api and then fetch the binary. There is some logic in here that we could make us of https://github.com/scheib/chromium-latest-linux/blob/master/update.sh.

The only reason we're using streams today is to improve performance, as we have to decode a huge Base64 string. If using a Promise is possible, I would much prefer that.

It still returns a Base64 string https://chromedevtools.github.io/devtools-protocol/tot/Page/#method-captureScreenshot.

puppeteer might be worth checking out.

Yeah, what's stopping this issue from moving forward is https://github.com/kevva/chromium-bin. I need to finish bin-wrapper to make it work.

Only works on Node 7.10+ for now though. But looks really nice.

Yeah. It has no streaming API that I see, but we should evaluate if we can require Node.js 8, and possibly rename this package or create a new one with a more fitting name.

@SamVerschueren the readme for puppeteer now reads:

Puppeteer requires at least Node v6.4.0,

What are the chances of getting this thing rolling again? Not sure that I would be successful at a PR but I might be able to take a stab.


Add code for speaker embeddings task

This fails some pre-commit tests on openmind, not sure why.

This fails some pre-commit tests on openmind, not sure why.

I have fixed that by adding requests as a required dependency to the mypy pre-commit hook.

@900miles i have noticed that speechbrain creates a folder for checkpoints called pretrained_models. 2 things:

do you know if there is a way to customize the directory?
can you please add the default directory to the .gitignore file?
thank you!

All of the suggested changes have been pushed.

@900miles i have noticed that speechbrain creates a folder for checkpoints called pretrained_models. 2 things:
* do you know if there is a way to customize the directory?

* can you please add the default directory to the .gitignore file?
  thank you!

I added the default directories to the .gitignore file. I'm not sure if there's a way to customize the directory, and a quick google wasn't very helpful either.

All of the suggested changes have been pushed.

@900miles i have noticed that speechbrain creates a folder for checkpoints called pretrained_models. 2 things:
* do you know if there is a way to customize the directory?

* can you please add the default directory to the .gitignore file?
  thank you!

I added the default directories to the .gitignore file. I'm not sure if there's a way to customize the directory, and a quick google wasn't very helpful either.

classifier = EncoderClassifier.from_hparams(
    ...     source="speechbrain/spkrec-ecapa-voxceleb",
    ...     savedir=tmpdir,
    ... )

Codecov Report
Attention: Patch coverage is 85.47486% with 26 lines in your changes missing coverage. Please review.

Please upload report for BASE (release_040@d68cedf). Learn more about missing BASE report.

Files
Patch %
Lines

src/tests/audio/tasks/features_extraction_test.py
80.88%
13 Missing :warning:

...peaker_diarization/pyannote_speaker_diarization.py
0.00%
5 Missing :warning:

src/senselab/audio/tasks/voice_cloning/knnvc.py
0.00%
4 Missing :warning:

...udio/tasks/features_extraction/torchaudio_squim.py
71.42%
2 Missing :warning:

src/senselab/audio/tasks/speaker_embeddings/api.py
91.66%
1 Missing :warning:

src/tests/audio/tasks/speaker_embeddings_test.py
97.61%
1 Missing :warning:

Additional details and impacted files
@@              Coverage Diff               @@
##             release_040      #75   +/-   ##
==============================================
  Coverage               ?   87.32%
==============================================
  Files                  ?       44
  Lines                  ?     1625
  Branches               ?        0
==============================================
  Hits                   ?     1419
  Misses                 ?      206
  Partials               ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thank you @900miles ! I have added a couple of edits (mostly for making the SpeechBrain class a factory). there are a couple of todoes, but they are minor and we can keep them for later:

we may want to have a standard repo for saving pre-trained models
we may want to better check if a model is a speechbrain model (being a hf model is not enough)


New Export Options

[ ] Download as zip (@modderme123)
[ ] Export to Github
[ ] Export to Stackblitz

duplicate of https://github.com/solidjs/solid-playground/issues/38


Use http.rb ~> 1.0.0

I did the minor modifications for the http gem v1.0.x to work.
It brings a few improvements: https://github.com/httprb/http/blob/master/CHANGES.md#100-2015-12-25

i think this update is a great idea. however, would it be possible to maintain compatibility with the http.rb > 0.8 & < 2.0? The 0.9 release removed http caching which i need for some of my projects.

Any news on this one?
Upstream is now at 2.0.2 and includes a number of cool fixes, it would be awesome if this could be applied.

I still have the same problem with this PR as before. HTTP.rb still doesn't support caching nor are there, to my knowledge, any third party libraries for it that provide that functionality. I'd love to move to the newest version but caching is integral to every successful API implementation I've ever done. I am not willing to upgrade until we have a caching solution.

Do you guys think a backwards compatibility approach like this one would be feasible: https://github.com/jeromegn/hal-client/pull/1
It was tested against http.rb versions 0.7.4, 0.9.9 and 1.0.4 and all tests are passing.

@tjsousa, that looks great! I'd merge a PR to that effect. :smile:

I opened the PR against @jeromegn's fork since he had the work of actually inspecting the code to make it ~> 1.0.0 compatible. If he accepts it and rebase the changes into this PR, I'm happy with that.
Otherwise I can open a PR against the master branch here as well. :)

I merged @tjsousa in my branch. Nice work there! (I didn't even remember I had made a PR)

@tjsousa so the way it'd work is that the hal-client gem will support any version of the http gem between 0.7 and 2.0 (excluded), then it's up to you to include in your project the http gem explicitly (as well as the version you desire)?

@lucke84 It will install the latest version of the gem compatible with all your other gems. If you've explicitly included the http gem with a specific version that is between 0.7 and 2.0.0 (exclusive), then it'll be satisfied and use that. Else it'll install 1.x.x if all other gem dependencies are good with it.

@jeromegn, looking good. If you rebase on to master i'll merge it.

Hmm I rebased, but things are weird now. A local diff shows everything is good (2 files changed), but for some reason there are 19 files changed here.

Worse case you could cherry pick your two commits into a new branch

@jeromegn, any chance of landing this PR?

I'm preparing another take on this in branch https://github.com/ivoanjo/hal-client/tree/http-one-oh-try2 , but I haven't tested it very much so I wanted to do that before submitting it.

More than happy if somebody else wants to tackle it. I won't be using this project in the near future and I won't be as interested as contributing.
I haven't had much time lately, I'm starting my own company and resolving git merge weirdness (well, they are my weirdnesses) is making it hard to get motivated ;)

Fixed by #59