Change SConscript() default behavoir to error if SConscript is not present.

This is the completion of deprecation of old behavior.
When we introduced must_exist flag, the intent was to flip the default to error out and allow users to specify must_exist=False in the case it was ok for the file to not exist.

Should this completely clean out the warnings setup leaving just "fail unless must_exist is false", or leave in the warnings setup and flip the default, so that the cmdline options are still accepted but maybe don't mean whything?

Ok so we added warnings in 4.2.0 and that was 07/31/2021
I'd say flip the default and remove this bit? (from SConscript.py handle_missing_SConscript())
            msg = (
                "Calling missing SConscript without error is deprecated.\n"
                "Transition by adding must_exist=False to SConscript calls.\n"
                "Missing SConscript '%s'" % f.get_internal_path()
            )

I think that means next version must be 4.4.0
https://github.com/SCons/scons/wiki/DeprecationCycle
?

Sure, this part of the change is easy enough:
diff --git a/SCons/Script/SConscript.py b/SCons/Script/SConscript.py
index 61881515e..992cf95cc 100644
--- a/SCons/Script/SConscript.py
+++ b/SCons/Script/SConscript.py
@@ -145,7 +145,7 @@ def Return(*vars, **kw):

 stack_bottom = '% Stack boTTom %' # hard to define a variable w/this name :)

-def handle_missing_SConscript(f, must_exist=None):
+def handle_missing_SConscript(f, must_exist=True):
     """Take appropriate action on missing file in SConscript() call.

     Print a warning or raise an exception on missing file, unless
@@ -163,22 +163,10 @@ def handle_missing_SConscript(f, must_exist=None):
           :data:`SCons.Script._no_missing_sconscript` is true.
     """

-    if must_exist or (SCons.Script._no_missing_sconscript and must_exist is not False):
-        msg = "Fatal: missing SConscript '%s'" % f.get_internal_path()
+    if must_exist:
+        msg = f"Fatal: missing SConscript '{f.get_internal_path()}'"
         raise SCons.Errors.UserError(msg)

-    if must_exist is None:
-        if SCons.Script._warn_missing_sconscript_deprecated:
-            msg = (
-                "Calling missing SConscript without error is deprecated.\n"
-                "Transition by adding must_exist=False to SConscript calls.\n"
-                "Missing SConscript '%s'" % f.get_internal_path()
-            )
-            SCons.Warnings.warn(SCons.Warnings.MissingSConscriptWarning, msg)
-            SCons.Script._warn_missing_sconscript_deprecated = False
-        else:
-            msg = "Ignoring missing SConscript '%s'" % f.get_internal_path()
-            SCons.Warnings.warn(SCons.Warnings.MissingSConscriptWarning, msg)

 def _SConscript(fs, *files, **kw):
     top = fs.Top

But leaves the question of what to do with other bits: the logic around SCons.Script._no_missing_sconscript - the flag setting and warning settings; and the command-line option to fiddle it.

I think that means next version must be 4.4.0
https://github.com/SCons/scons/wiki/DeprecationCycle ?

I no longer know how to interpret that. We added the deprecation warning in 3.1.  There have been plenty of releases, and somewhat over two years, since then, what constitutes major now?  e.g. Python now considers their annual realase to be basically major, while 2. to 3. wa something different, perhaps a "generational" change.  One reading says it would need to be 5.0, which I hope isn't the case.  The earlier things I kicked out were deprecated in or before the 1.0 timeframe so really no questions there.


Added a REP/REQ context example

Rebased, added in AUTHORS, and fixed commit comment:
6af6369964d99a406ffa9ee3f923684de3b0c8aa


Add icon to tree view

It would be super helpful if the tree view could show which files have annotations in them currently!

It seems it is not that easy to add more css classes to tree view entries.
Let's what happens next: https://github.com/atom/tree-view/issues/1196

Another possibility might be tree-view's entryForPath(entryPath) API. Annotated files' entries could be manually traversed and modified. But that's probably way more error-prone (because tree-view would be unaware of the modifications which could result in losing the changes upon rerendering - basically the react argument) than providing an icon service.

@edahlseng Hey, I just saw you recently contributed to the tree-view package.
I guess you most likely know that package better than me - and since this issue has been created some code has probably changed.
So do you have any ideas for solving this issue?
I would currently just try and see if consuming the service works together with file-icons.
If it doesn't I have no idea how to proceed...I've read through some tree-view and file-icons code but that hasn't really been enlightening 😕


Update lissy93/dashy Docker tag to v3

This PR contains the following updates:

Package
Update
Change

lissy93/dashy
major
2.1.2 -> 3.1.0

Release Notes

Lissy93/dashy (lissy93/dashy)
v3.0.1
Compare Source
Version 3.0.1 Released 🚀
This release includes several UX and security improvments.  The security of auth has been hardened. You can now prevent direct access to your config. And there are many little bug fixes.
Changes 📋

Show more detailed message when Dashy fails to load
Put all config.backup.***.yml in own folder inside user-data, so it doesn't clutter up the root
Add support for HTTP auth, to protect config from unauthorized access
Add support for environmental variables for auth passwords (instead of hashes)
Fix the Item Size and Layout buttons, and add support for different settings for sub-pages
Disable configuration edit options for guests, when auth enabled (#1552)
Update docs to include directory structure of ./user-data (#1538)
Made cards hyperlinks to repos in GitHub widget (#1531)
Apply page title, from pageInfo.title (#1544)
Update Docker start command, to remove the build on first container start (#1543)
Fix Collapsed state persisting over different pages (#1546)
Remove the automation where @liss-bot prompts non-stargazers to star the repo on ticket open (#1412)
Update widget fetch function to send user-specified headers (#1549)
Updated README.md to include sponsored message from Umbrel

New Sponsor 💖
I want to give a shout out to Umbrel, who are now sponsoring Dashy. If you haven't yet checked them out, they maintain a super easy all-in-one OS for self-hosting, and sell a plug-and-play homelab device. Well worth checking out, especially if you're new to the scene!
It's our sponsors which make continued maintenance possible. You can consider sponsoring me and our other core contributors.

v3.0.0
Compare Source
Dashy 3.0 has been released!
This version includes some major changes, including:

No more rebuilding 🎉
Mounting a directory, not a file 😌
Switch to Non-Root of Port 🔒
Environmental Variables for Widget API Keys 🔒
Other performance, stability and security updates ⚡

For a full break-down, see #1529

[!IMPORTANT]
This release includes breaking changes.
The port within the container has changed from 80 to 8080, and the location of your config and other assets has changed from /app/public to app/user-data. You will need to update your Docker compose/run command after upgrading to this version.

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Hi, because of the breaking changes introduced in version 3.0.0, the chart will need to be changed in places such as:

https://github.com/vyrtualsynthese/selfhosted-helmcharts/blob/main/charts/dashy/templates/deployment.yaml#L82
https://github.com/vyrtualsynthese/selfhosted-helmcharts/blob/main/charts/dashy/templates/deployment.yaml#L74

And possibly change the default here:

https://github.com/vyrtualsynthese/selfhosted-helmcharts/blob/main/charts/dashy/values.yaml#L47

Do you take contributions?
Thank you in advance.

Sorry, I didn't noticed your comment.
Helm chart should be fixed for 3.x dashy. Feel free to push any contribution.


meson: Fix generation of import library on Windows

Add the .def file when generating the DLL so that the required symbols are exported when building with MSVC and an import library is generated.
Without this, you can't use the openh264 DLL generated with the meson build files.

lgtm

I had to force-push multiple times because the CI kept erroring out while setting up the image.


To add a calculator to calculate shortest distance between two vector Lines

Is your feature request related to a problem? Please describe.
To add a calculator to calculate shortest distance between two vector Lines

Hi, I want to work on this issue I will start working on it as soon as I get assigned!! I am a part of GSSoC'21.
Kindly assign this issue to me!
Discord Username : Abhijeet Sinha(P)
Discord Tag: #4018


no exchange 'celeryresults' in vhost '/'

When send jobs to a python worker, it failed with
{ [Error: NOT_FOUND - no exchange 'celeryresults' in vhost '/'] code: 404 }

I too was getting this message, and I think it occurs when you are attempting to send data back from the celery worker, without having first configured a result backend as specified here: http://celery.readthedocs.org/en/latest/getting-started/first-steps-with-celery.html#keeping-results

thanks @voltaicio! Indeed, node-celery doesn't create the result exchange. You can launch celery worker before node-celery to ensure the result exchange is created.


llama-7b command correct?

OSError: huggyllama/llama-7b does not appear to have a file named pytorch_model.bin, tf_model.h5, model.ckpt or flax_model.msgpack.
WARNING:torch.distributed.elastic.multiprocessing.api:Sending process 715682 closing signal SIGTERM
ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: 1) local_rank: 1 (pid: 715683) of binary:
Facing this error. Is the llama-7b command accurate? Can someone help me figure this out.
Thanks.

Downloaded the model. This is fixed.

I'm experiencing the same problem, may I ask how you solved it?


Fix wrong environment test that breaks clang++ builds.

g++ builds require extra flags rejected by clang++. The bug is that the
flags are actually added unconditionally. This commit fixes the
condition.
See https://github.com/tesseract-ocr/tesseract/pull/1474 and related.
Tests conducted and report: https://github.com/tesseract-ocr/tesseract/pull/1474#issuecomment-383437228

This commit does not fix the problem: on macOS without g++ from MacPorts there exists a g++ frontend which calls Apple's clang. And of course that g++ fails with the new compiler flags.

I see, sorry about that. For now, rolled back, and I put a workaround note in the wiki.


Correct typo: Nesponses -> Responses

I've also cleared the output of the last cell, a 3d volume rendering of neurons, which was blowing up the size of the notebook to over 30MBs from mere KBs. Such large notebooks will hang editors and IDEs, so please don't persist heavy plots in notebooks.

Thank you for this one! Agreed on deleting the heavy plot.


DEVEXP-402: Mount trusted-ca to registry base pki trust source

/hold
Blocked by #340

/retest
s3 issue from earlier today

/retest

/hold cancel

/lgtm

/hold
I may not be mounting the trust correctly

/hold cancel

@dmage ready for review again

/retest

/retest

/lgtm


v4.11.3

@j0tunn @DudaGod @sipayRT

Coverage remained the same at 83.807% when pulling 692f4438d713795204860477deaed83137514056 on version/4.11.3 into 57180aa835a6b1b811dc93499adb28bfc6e92805 on master.

Coverage remained the same at 83.807% when pulling 692f4438d713795204860477deaed83137514056 on version/4.11.3 into 57180aa835a6b1b811dc93499adb28bfc6e92805 on master.


Logging Refinement

Some possible refinements to logging:
1.) Module-specific logging; avoids having to deal with these messages at the root logger.
2.) Make graphite push logging 'debug', which seemed more appropriate for this type of log.

This looks sensible. In it goes! And thanks.


Update README

A README is often the first item a visitor will see when visiting your repository. From what I see with your current README, it looks good. I would recommend adding:

A more thorough step by step for a user to clone and run this repo on their computer.
A section explaining that folks can learn how to recreate your project in the LEARN.md file.
A mention of your code of conduct.
How to contribute to your project

Depending on the complexity of your project, you might be interested in creating a CONTRIBUTING.md file, but we recommend starting simple with the bullet points above, and once you start to see an increase in users interested in contributing, you should consider a CONTRIBUTING.md file so you don’t find yourself overwhelmed with questions from other users.

Added https://github.com/rawheel/MyUnfollowers-App/blob/main/README.md


Added updateHelpUri + Added helpUri

Added support script for updating helpUri when new releases are being released.
Added helpUri to all Public functions.

Script looks great. I want to make sure we get more module release automation in-place before merging.

Let's revisit this one once we've automated the release flow completely.


chore: release 1.3.0

:robot: I have created a release *beep* *boop*
1.3.0 (2019-06-19)
Features

add avro support (#310) (ac4f6d9)

This PR was generated with Release Please.

Release is at https://github.com/googleapis/nodejs-dlp/releases/tag/v1.3.0

The release build has started, the log can be viewed here. :sunflower:

:egg: You hatched a release! The release build finished successfully! :purple_heart:


attach logs to healthchecks.io

useful feature for attaching logs of ansible-pull output
https://healthchecks.io/docs/attaching_logs/

Closing this since inspecting the log file would require logging into healtchecks. I was hoping for logs to be attached in email body.

Hi @ahemdsajid, the email should contain a "Last Ping Body" with the first 10KB of logs.
Here's an example email I received when I used runitor with a command (pgmetrics & pgdash) that produced sterr output:

Thanks for comment on this @cuu508
If that's the case, I'll try it out!


Adding helpers for semver usage

Attempt to fix https://github.com/docker/metadata-action/issues/384
I kinda fail at getting why IsRawStatement exists, and also why {{major}}.{{minor}} (in tag13 test) is supposed to give {{version}} ?
Hopefully this works properly and helps users get the best from the tags.

Seems like we'll might be having an issue here in terms of semver compliance of docker tags :

After the image name, the optional TAG is a custom, human-readable manifest identifier that's typically a specific version or variant of an image. The tag must be valid ASCII and can contain lowercase and uppercase letters, digits, underscores, periods, and hyphens. It can't start with a period or hyphen and must be no longer than 128 characters. If you don't specify a tag, the command uses latest by default.

https://docs.docker.com/engine/reference/commandline/image_tag/

Seems like we might be having an issue here in terms of semver compliance of docker tags :

After the image name, the optional TAG is a custom, human-readable manifest identifier that's typically a specific version or variant of an image. The tag must be valid ASCII and can contain lowercase and uppercase letters, digits, underscores, periods, and hyphens. It can't start with a period or hyphen and must be no longer than 128 characters. If you don't specify a tag, the command uses latest by default.

https://docs.docker.com/engine/reference/commandline/image_tag/

Ah completely forgot about this limitation :disappointed:

Ok, so until we get any news from those, we can use this but with a hyphen instead of a plus ? kinda breaks readability of semver but what can we do ? Use another letter/keyword ? An underscore maybe ?
https://github.com/docker/cli/issues/4877
https://github.com/distribution/distribution/issues/1201
https://github.com/opencontainers/distribution-spec/issues/154

but with a hyphen instead of a plus ? kinda breaks readability of semver but what can we do ?

Don't think we have much choice atm than waiting. Hyphens are specially treated by semver spec to handle prerelease. That would break versioning.


Add reinforcement learning example

Ported the RL example to Flutter

For the model link, instead of pulling from the other TFLite example repo, let's use
https://storage.googleapis.com/download.tensorflow.org/models/tflite/flutter-plugin/reinforcement_learning/planestrike_tf.tflite
and
https://storage.googleapis.com/download.tensorflow.org/models/tflite/flutter-plugin/reinforcement_learning/planestrike_tf.tflite

Looks good on Android. Will test iOS either this weekend or mid-next week (I forgot my iPad at the office and only have one iOS device :P)

So I'm getting a message in iOS about wanting permission to see connected devices on the network. Since this is on-device ML, that shouldn't be necessary. Can you remove whatever is causing that?

What's the exact msg? I don't have an iOS device and I didn't see such a msg in the iOS emulator?

Weird, can't replicate it. Sounds like a later problem if it comes up again :P


gReplace ChainErr with crate-level Error trait

Instead of creating one trait at each macro invocation, we create it one time in
this crate. Bonus point: the trait in visible in the doc of error-chain.
TODO:

doc
Better name for ChainErr (trait and enum)
add tests for chain_err

The one downside I see to this is that error-using code must have two imports instead of one. That is:
use errors::*;
use error_chain::ChainErr;

vs.
use errors::*;

So I'm not sure this is an improvement. Besides reducing duplication are there other benefits? I wouldn't be surprised if there are benefits around import shadowing but haven't thought specific cases.

Hum. Maybe pub use?

Additional benefit: no need for ErrorKind in links {}.

rebased

As for the benefits:

Fix https://github.com/brson/error-chain/issues/32
Better documentation (you can see the available methods in error-chain's doc)
No need for ChainErr.

The kind(), iter() and such can be removed from the trait while keeping the benefits, though. After thought, we don't really need polymorphism.
BTW, there is also the trait ResultExt. Is that OK?

Removed kind() and such from ChainedError.

@brson others comments before merge?

Merging since no response.


FileNotFoundError errors when running with a remote ray cluster

When running a flow from my laptop against a remote ray cluster, prefect tries to reference directories that only exist on my laptop (eg: /Users/tekumara/.prefect/storage):
$ python flows/ray_flow.py
20:38:31.738 | INFO    | prefect.engine - Created flow run 'fiery-copperhead' for flow 'greetings'
20:38:31.738 | INFO    | Flow run 'fiery-copperhead' - Starting 'RayTaskRunner'; submitted tasks will be run in parallel...
20:38:31.790 | INFO    | prefect.task_runner.ray - Connecting to an existing Ray instance at ray://<IP_ADDRESS>:10001
20:38:35.568 | INFO    | prefect.task_runner.ray - Using Ray cluster with 1 nodes.
20:38:35.568 | INFO    | prefect.task_runner.ray - The Ray UI is available at <IP_ADDRESS>:8265
20:38:37.838 | INFO    | Flow run 'fiery-copperhead' - Created task run 'say_hello-811087cd-0' for task 'say_hello'
20:38:39.172 | INFO    | Flow run 'fiery-copperhead' - Submitted task run 'say_hello-811087cd-0' for execution.
20:38:39.477 | INFO    | Flow run 'fiery-copperhead' - Created task run 'say_goodbye-261e56a8-0' for task 'say_goodbye'
20:38:39.531 | INFO    | Flow run 'fiery-copperhead' - Submitted task run 'say_goodbye-261e56a8-0' for execution.
20:38:39.838 | INFO    | Flow run 'fiery-copperhead' - Created task run 'say_hello-811087cd-1' for task 'say_hello'
20:38:39.887 | INFO    | Flow run 'fiery-copperhead' - Submitted task run 'say_hello-811087cd-1' for execution.
20:38:40.169 | INFO    | Flow run 'fiery-copperhead' - Created task run 'say_goodbye-261e56a8-1' for task 'say_goodbye'
20:38:40.205 | INFO    | Flow run 'fiery-copperhead' - Submitted task run 'say_goodbye-261e56a8-1' for execution.
(get_dashboard_url pid=385) /home/ray/anaconda3/lib/python3.9/site-packages/paramiko/transport.py:236: CryptographyDeprecationWarning: Blowfish has been deprecated
(get_dashboard_url pid=385)   "class": algorithms.Blowfish,
20:38:40.504 | INFO    | Flow run 'fiery-copperhead' - Created task run 'say_hello-811087cd-2' for task 'say_hello'
20:38:40.540 | INFO    | Flow run 'fiery-copperhead' - Submitted task run 'say_hello-811087cd-2' for execution.
20:38:40.826 | INFO    | Flow run 'fiery-copperhead' - Created task run 'say_goodbye-261e56a8-2' for task 'say_goodbye'
20:38:40.862 | INFO    | Flow run 'fiery-copperhead' - Submitted task run 'say_goodbye-261e56a8-2' for execution.
(begin_task_run pid=385) 03:38:41.096 | INFO    | Task run 'say_hello-811087cd-0' - hello arthur
20:38:41.165 | INFO    | Flow run 'fiery-copperhead' - Created task run 'say_hello-811087cd-3' for task 'say_hello'
20:38:41.207 | INFO    | Flow run 'fiery-copperhead' - Submitted task run 'say_hello-811087cd-3' for execution.
20:38:41.510 | INFO    | Flow run 'fiery-copperhead' - Created task run 'say_goodbye-261e56a8-3' for task 'say_goodbye'
20:38:41.551 | INFO    | Flow run 'fiery-copperhead' - Submitted task run 'say_goodbye-261e56a8-3' for execution.
(begin_task_run pid=385) 03:38:41.605 | INFO    | Task run 'say_hello-811087cd-1' - hello trillian
(begin_task_run pid=385) print goodbye
(begin_task_run pid=385) 03:38:42.104 | INFO    | Task run 'say_goodbye-261e56a8-3' - goodbye marvin
(begin_task_run pid=385) print goodbye
(begin_task_run pid=385) 03:38:42.593 | INFO    | Task run 'say_goodbye-261e56a8-2' - goodbye ford
(begin_task_run pid=385) print goodbye
(begin_task_run pid=385) 03:38:43.139 | INFO    | Task run 'say_goodbye-261e56a8-1' - goodbye trillian
(begin_task_run pid=385) 03:38:43.635 | INFO    | Task run 'say_hello-811087cd-3' - hello marvin
(begin_task_run pid=385) print goodbye
(begin_task_run pid=385) 03:38:44.126 | INFO    | Task run 'say_goodbye-261e56a8-0' - goodbye arthur
20:38:44.644 | INFO    | Task run 'say_hello-811087cd-0' - Crash detected! Execution was interrupted by an unexpected exception.
(begin_task_run pid=385) 03:38:44.623 | INFO    | Task run 'say_hello-811087cd-2' - hello ford
20:38:44.936 | INFO    | Task run 'say_goodbye-261e56a8-0' - Crash detected! Execution was interrupted by an unexpected exception.
20:38:45.279 | INFO    | Task run 'say_hello-811087cd-1' - Crash detected! Execution was interrupted by an unexpected exception.
20:38:45.561 | INFO    | Task run 'say_goodbye-261e56a8-1' - Crash detected! Execution was interrupted by an unexpected exception.
20:38:45.845 | INFO    | Task run 'say_hello-811087cd-2' - Crash detected! Execution was interrupted by an unexpected exception.
20:38:46.193 | INFO    | Task run 'say_goodbye-261e56a8-2' - Crash detected! Execution was interrupted by an unexpected exception.
20:38:46.472 | INFO    | Task run 'say_hello-811087cd-3' - Crash detected! Execution was interrupted by an unexpected exception.
20:38:46.751 | INFO    | Task run 'say_goodbye-261e56a8-3' - Crash detected! Execution was interrupted by an unexpected exception.
20:38:48.741 | ERROR   | Flow run 'fiery-copperhead' - Finished in state Failed('8/8 states failed.')
Traceback (most recent call last):
  File "/Users/tekumara/code/orion-demo/flows/ray_flow.py", line 38, in <module>
    greetings(["arthur", "trillian", "ford", "marvin"])
  File "/Users/tekumara/code/orion-demo/.venv/lib/python3.9/site-packages/prefect/flows.py", line 367, in __call__
    return enter_flow_run_engine_from_flow_call(
  File "/Users/tekumara/code/orion-demo/.venv/lib/python3.9/site-packages/prefect/engine.py", line 150, in enter_flow_run_engine_from_flow_call
    return anyio.run(begin_run)
  File "/Users/tekumara/code/orion-demo/.venv/lib/python3.9/site-packages/anyio/_core/_eventloop.py", line 70, in run
    return asynclib.run(func, *args, **backend_options)
  File "/Users/tekumara/code/orion-demo/.venv/lib/python3.9/site-packages/anyio/_backends/_asyncio.py", line 292, in run
    return native_run(wrapper(), debug=debug)
  File "/Users/tekumara/.pyenv/versions/3.9.13/lib/python3.9/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/Users/tekumara/.pyenv/versions/3.9.13/lib/python3.9/asyncio/base_events.py", line 647, in run_until_complete
    return future.result()
  File "/Users/tekumara/code/orion-demo/.venv/lib/python3.9/site-packages/anyio/_backends/_asyncio.py", line 287, in wrapper
    return await func(*args)
  File "/Users/tekumara/code/orion-demo/.venv/lib/python3.9/site-packages/prefect/client.py", line 104, in with_injected_client
    return await fn(*args, **kwargs)
  File "/Users/tekumara/code/orion-demo/.venv/lib/python3.9/site-packages/prefect/engine.py", line 226, in create_then_begin_flow_run
    return state.result()
  File "/Users/tekumara/code/orion-demo/.venv/lib/python3.9/site-packages/prefect/orion/schemas/states.py", line 159, in result
    state.result()
  File "/Users/tekumara/code/orion-demo/.venv/lib/python3.9/site-packages/prefect/orion/schemas/states.py", line 145, in result
    raise data
ray.exceptions.RayTaskError: ray::begin_task_run() (pid=385, ip=<IP_ADDRESS>)
FileNotFoundError: [Errno 2] No such file or directory: '/Users/tekumara/.prefect/storage'

During handling of the above exception, another exception occurred:

ray::begin_task_run() (pid=385, ip=<IP_ADDRESS>)
  File "/home/ray/anaconda3/lib/python3.9/pathlib.py", line 1313, in mkdir
    self._accessor.mkdir(self, mode)
FileNotFoundError: [Errno 2] No such file or directory: '/Users/tekumara/.prefect'

During handling of the above exception, another exception occurred:

ray::begin_task_run() (pid=385, ip=<IP_ADDRESS>)
  File "/home/ray/anaconda3/lib/python3.9/pathlib.py", line 1313, in mkdir
    self._accessor.mkdir(self, mode)
FileNotFoundError: [Errno 2] No such file or directory: '/Users/tekumara'

During handling of the above exception, another exception occurred:

ray::begin_task_run() (pid=385, ip=<IP_ADDRESS>)
  File "/Users/tekumara/code/orion-demo/.venv/lib/python3.9/site-packages/prefect/utilities/asyncutils.py", line 193, in wrapper
  File "/tmp/ray/session_2022-07-19_04-28-59_171336_7/runtime_resources/pip/3a2844a8f2bb50700ae9149311bce23037a95e22/virtualenv/lib/python3.9/site-packages/prefect/utilities/asyncutils.py", line 140, in run_async_in_new_loop
    return anyio.run(partial(__fn, *args, **kwargs))
  File "/home/ray/anaconda3/lib/python3.9/site-packages/anyio/_core/_eventloop.py", line 56, in run
    return asynclib.run(func, *args, **backend_options)
  File "/home/ray/anaconda3/lib/python3.9/site-packages/anyio/_backends/_asyncio.py", line 233, in run
    return native_run(wrapper(), debug=debug)
  File "/home/ray/anaconda3/lib/python3.9/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/home/ray/anaconda3/lib/python3.9/asyncio/base_events.py", line 642, in run_until_complete
    return future.result()
  File "/home/ray/anaconda3/lib/python3.9/site-packages/anyio/_backends/_asyncio.py", line 228, in wrapper
    return await func(*args)
  File "/tmp/ray/session_2022-07-19_04-28-59_171336_7/runtime_resources/pip/3a2844a8f2bb50700ae9149311bce23037a95e22/virtualenv/lib/python3.9/site-packages/prefect/engine.py", line 944, in begin_task_run
    return await orchestrate_task_run(
  File "/tmp/ray/session_2022-07-19_04-28-59_171336_7/runtime_resources/pip/3a2844a8f2bb50700ae9149311bce23037a95e22/virtualenv/lib/python3.9/site-packages/prefect/engine.py", line 1081, in orchestrate_task_run
    await _persist_serialized_result(
  File "/tmp/ray/session_2022-07-19_04-28-59_171336_7/runtime_resources/pip/3a2844a8f2bb50700ae9149311bce23037a95e22/virtualenv/lib/python3.9/site-packages/prefect/results.py", line 15, in _persist_serialized_result
    await filesystem.write_path(key, content)
  File "/tmp/ray/session_2022-07-19_04-28-59_171336_7/runtime_resources/pip/3a2844a8f2bb50700ae9149311bce23037a95e22/virtualenv/lib/python3.9/site-packages/prefect/filesystems.py", line 94, in write_path
    path.parent.mkdir(exist_ok=True, parents=True)
  File "/home/ray/anaconda3/lib/python3.9/pathlib.py", line 1317, in mkdir
    self.parent.mkdir(parents=True, exist_ok=True)
  File "/home/ray/anaconda3/lib/python3.9/pathlib.py", line 1317, in mkdir
    self.parent.mkdir(parents=True, exist_ok=True)
  File "/home/ray/anaconda3/lib/python3.9/pathlib.py", line 1317, in mkdir
    self.parent.mkdir(parents=True, exist_ok=True)
  File "/home/ray/anaconda3/lib/python3.9/pathlib.py", line 1313, in mkdir
    self._accessor.mkdir(self, mode)
PermissionError: [Errno 13] Permission denied: '/Users'

flows/ray_flow.py:
from typing import List

from prefect import flow, get_run_logger, task
from prefect_ray.task_runners import RayTaskRunner

@task
def say_hello(name: str) -> None:
    logger = get_run_logger()
    logger.info(f"hello {name}")

@task
def say_goodbye(name: str) -> None:
    # logs not currently working see https://github.com/PrefectHQ/prefect-ray/issues/25
    logger = get_run_logger()
    print("print goodbye")
    logger.info(f"goodbye {name}")

# run on an existing ray cluster
@flow(
    task_runner=RayTaskRunner(
        # <IP_ADDRESS>:10001 is port-forwarded to the remote ray cluster
        address="ray://<IP_ADDRESS>:10001",
        init_kwargs={"runtime_env": {"pip": ["prefect==2.0b12"]}},
    )
)
def greetings(names: List[str]) -> None:
    for name in names:
        say_hello.submit(name)
        say_goodbye.submit(name)

if __name__ == "__main__":
    greetings(["arthur", "trillian", "ford", "marvin"])

prefect 2.0b12

Hi thanks for sharing this!
I was wondering if you can test this with the newest Prefect version
pip install -U "prefect>=2.0"

Closing as I can't replicate this now in prefect 2.3.2.

This still occurs in prefect 2.3.2.

This still occurs in prefect 2.3.2.
I'm trying to run directly against the cluster without a Deployment, and so there is no storage involved.

This still occurs in prefect 2.3.2.
I'm trying to run directly against the cluster without a Deployment, and so there is no storage involved. It would be nice if this were supported, or do I have to create a Deployment?

This still occurs in prefect 2.3.2.
I'm trying to run directly against the cluster without a Deployment, and so there is no storage involved.
I would have thought it possible to run the flow locally, but submit tasks to the remote ray cluster.

From the stack trace above it looks like the error is occurring in the filesystems module.
Digging into this further, it looks what is happening is prefect is persisting task run results to  PREFECT_LOCAL_STORAGE_PATH. This path defaults to ${PREFECT_HOME}/storage.... the problem seems to be that prefect is resolving ${PREFECT_HOME} in the process running the flow (eg: my laptop which is/Users/tekumara/.prefect)  and not in the process running the task (eg: on the ray cluster this would be /home/ray/.prefect)

My current workaround is prior to running the flow, is to set PREFECT_LOCAL_STORAGE_PATH to a writable path inside the container running on the ray cluster, eg:
export PREFECT_LOCAL_STORAGE_PATH=/tmp/prefect/storage

Thanks so much for helping debug this!
I think we could use by wrapping call.func in task_runner.submit with
def call_func_wrapper():
    with temporary_settings(updates={PREFECT_LOCAL_STORAGE_PATH: "/tmp/prefect/storage"}):
        return call.func(*args, **kwargs)

And also try to resolve https://github.com/PrefectHQ/prefect-ray/issues/37 with Michael's suggestion too.
Would you be interested in contributing a PR?

We also ran into this. The workaround we used is setting export PREFECT_HOME="/tmp/prefect", which exists both on the laptop and the cluster. We should try to fix this upstream or otherwise every single user of prefect-ray will run into this problem :)

I'll attempt to address this as a part of https://github.com/PrefectHQ/prefect/pull/6908

Thanks, that's awesome! I'm happy to try out a PR once it is ready, I have a setup that reproduces the problem. Also happy to try out if https://github.com/PrefectHQ/prefect-ray/issues/26#issuecomment-1244804261 fixes the problem in case that helps you @madkinsz :)

I think we'll want to consider more fundamentally the "local persistence for tasks on remote workers" story. I added a couple tickets to the tracking pull request:

Ensure task run results persisted to local file systems on remote workers respect relative paths
Investigate storing results after return from the remote worker for task runs with local file systems

Btw, unfortunately the workaround from https://github.com/PrefectHQ/prefect-ray/issues/26#issuecomment-1244804261 is not working for me, even after some obvious modifications. Maybe temporary_settings is not enough (I have a feeling these settings are pickled with cloudpickle, maybe even before temporary_settings is called, but I don't really know how this stuff works).
What did work for me is the following atrocious hack:
diff --git a/prefect_ray/task_runners.py b/prefect_ray/task_runners.py
index deb7a8d..fcafb74 100644
--- a/prefect_ray/task_runners.py
+++ b/prefect_ray/task_runners.py
@@ -79,6 +79,11 @@ import anyio
 import ray
 from prefect.futures import PrefectFuture
 from prefect.orion.schemas.states import State
+from prefect.settings import (PREFECT_HOME,
+                              PREFECT_PROFILES_PATH,
+                              PREFECT_LOCAL_STORAGE_PATH,
+                              PREFECT_LOGGING_SETTINGS_PATH,
+                              PREFECT_ORION_DATABASE_CONNECTION_URL)
 from prefect.states import exception_to_crashed_state
 from prefect.task_runners import BaseTaskRunner, R, TaskConcurrencyType
 from prefect.utilities.asyncutils import sync_compatible
@@ -116,6 +121,13 @@ class RayTaskRunner(BaseTaskRunner):
         address: str = None,
         init_kwargs: dict = None,
     ):
+        import pathlib
+        PREFECT_HOME.value = lambda: pathlib.Path("/tmp/prefect")
+        PREFECT_PROFILES_PATH.value = lambda: pathlib.Path("/tmp/prefect/profiles.toml")
+        PREFECT_LOCAL_STORAGE_PATH.value = lambda: pathlib.Path("/tmp/prefect/storage")
+        PREFECT_LOGGING_SETTINGS_PATH.value = lambda: pathlib.Path("/tmp/prefect/logging.yml")
+        PREFECT_ORION_DATABASE_CONNECTION_URL.value = lambda: pathlib.Path("sqlite+aiosqlite:////tmp/prefect/orion.db")
+
         # Store settings
         self.address = address
         self.init_kwargs = init_kwargs.copy() if init_kwargs else {}

Any updates on this?

As a workaround for this issue, we are adding instructions to the prefect-ray documentation to recommend updating the PREFECT_LOCAL_STORAGE_PATH setting to a path available on the Ray worker and in flow execution environment in #47. This is not a perfect solution, but should unblock current use cases. We will continue to work on improving results management when local storage is used in conjunction with remote workers.


fix(version): update fabric8-runtime-console to 0.17.2

There were the following issues with your Pull Request

Commit: 8faf172438353fefe3832e96b831b3f25daa89ef
Your subject line is longer than 50 characters

Guidelines are available at https://github.com/fabric8io/fabric8-ui

This message was auto-generated by https://gitcop.com


Workflow and testing improvements

This is somewhat opinionated PR with the intention to improve the role workflow a bit, make it a bit more readable and less fragile. I'm very open to discuss individual changes. I have split it into two commits that are effectively unrelated, it's just I encountered the test bug while working on the rest.
05407c26810f541baa8c0975af251851a65f7000
Adds extra steps to update hosts file in test container. Tailscale does attempt to manage resolv.conf which is somewhat in conflict with Docker attempting to provice container name resolution. This is problematic in multi-stage scenarios where tailscale is initialized multiple times and eventually ends up in a state where container name resolution no longer works and test fails.
This extra steps add static hosts override for headscale container so that Tailscale managing DNS resolution does not mess up the connectivity to Headscale container.
f716fc2935c35b3a5d197fecd4f90099b0dc7fbd
The main changes are:

Switch to parsing json output of tailscale status - this should hopefully lead to less fragile detection of current status of tailscale connection and should also end up with more readable conditional logic in the role.

Split tailscale up step into two separate steps depending on situation:

If state didn't change and network is down, simple tailscale up without any arguments is used as the connection should already be properly set and this is all that is needed to bring the connection up.
If there is state change, full tailscale up with all the arguments is executed.

This can enable use cases where we don't necessarily want to fully manage the tailscale connection via Ansible, but the user still wants to bring the connection up. (ie. to prepare the instance for subsequent roles that rely on that connections)

Dropped some failed_when and changed_when conditions and instead rely on default behavior, that assumes non-zero return is failure and that any time command is executed (except tailscale status) it is performing a change. This probably reflects reality better.

I remember having to dig through tailscale source to find out how exit codes were produced by the binary, and the resulting reason led to this setup.

If that makes things a bit easier, the dropped failed_when is in tailscale status task and it effectively changed from:
  failed_when:
    - tailscale_status.rc != 0
    - "'Logged out.' not in tailscale_status.stdout"
    - "'not logged in' not in tailscale_status.stdout"

to default behavior:
  failed_when:
    - tailscale_status.rc != 0

In this case the other two conditions were likely to account for unexpected output. In this new implementation we would notice that when parsing json.
The changed_when is in tailscale up task. The changed_when: tailscale_start.rc != 0 setting was irrelevant anyways as it would fail the playbook. And it probably didn't reflect reality, because failure to run tailscale up might have changed configuration - for example if we attempted to change connection that was up with invalid auth key. This would effectively drop the connection, which is a change. It's kind of edge case, but IMO if we can't be sure whether any change was done or not, we should err on the side of reporting change.

I have now dropped the separate tailscale up task with no arguments. So we're back to running full tailscale up with arguments when state changes or connection is not up. Thanks for the feedback.

Ignore the failing lint check - https://github.com/ansible/ansible-lint/pull/3405 is needed to fix the error inside ansible-lint.

I have rebased and fixed some lint failures. Also reverted the tailscale up task name change.

Fixed the issue, you correctly identified. Well spotted!

I added requested comment and rebased PR onto the current main branch.


fix the panic when "ps -a" with dead containers

Fixes #1436
Fixes #1421
If it fails after https://github.com/docker/docker/blob/master/daemon/delete.go#L118 on container deletion, the container.Names will be empty because the container list API will query the graphdb at https://github.com/docker/docker/blob/master/daemon/list.go#L200
Signed-off-by: Shijiang Wei<EMAIL_ADDRESS>

@mountkin Thanks
Related : https://github.com/docker/swarm/issues/985
ping @docker/swarm-maintainers

Yep, there's a case of len(Names) being 0 when a container's status is Dead.
Is it possible to start a container with Dead status? This is quite tricky for integration test, IMO.

@chanwit I think it's quite tricky to add the integration test because we have to manage to create a Dead container first :crying_cat_face:
I opened another PR in the Docker project to reduce the probability of the empty Names problem. https://github.com/docker/docker/pull/18308

Thanks @mountkin, also thanks for trying to mitigate the issue on the docker side as well as we shouldn't get an empty container name. I assume it's better to merge and check it on our side to avoid this panic even though we shouldn't get it in the first place. As a safety measure.
And indeed this is going to be tricky for the integration tests, no way to reliably get a Dead container AFAIK (same problems applies in docker).
LGTM

LGTM

I know this is merged already, but seeing as this is a bad case, I think it would be good to log some data saying that this case was reached.

@MHBauer Do you mean: when using --debug, logging that a container has reached the dead state?


Issue with bundles and live-reload when adding new images

Not sure what it is, needs investigating. At least for branch bundles, I need a restart for it to pick up a new image.

See #4768


Now with Dalle support

idk if this works this was a mixture of chatGPT, google, and yoinking together bits from other commands in apollo It might work it might yeet everyrhing. Who knows? Tjats the fun part!

Also run black and isort on it

Also, you need to add the command to apollo.py otherwise it will never be loaded


dgram 404

Hello,
trying to create sample project in a browser for now.
Your JS has 3 dependencies: net/util/dgram.
"npm install dgram" results in a 404 however. Could you clarify where the dgram you used came from?
Thanks

@braden-smith dgram is part of the node.js std lib https://nodejs.org/api/dgram.html.
For use in a browser  there needs to be a dgram compatible wrapper library around  something like chrome's udp library https://developer.chrome.com/apps/sockets_udp.
So as it stands right now, there is some extra work which needs to be done to run this in a browser....

Hi @braden-smith did you ever look at https://github.com/feross/chrome-dgram or https://github.com/DecipherCode/firefox-dgram to solve this?


Resource Group Naming should also include business unit and product name as optional

Can Resource Group Naming include business unit and product name as optional ?
<rba.resourceGroupType>-<rba.BusinessUnit>-<rba.productgroup>-<rba.productName>-<rba.environment>-<rba.azureRegion>
Business Unit - It will help in segregating if similar product name is used by different business unit
Product group - Multiple teams can have subscription like esp , roxie ,  DE pertaining to supporting/implementing infra/app for same service

@burgerjx thoughts?


transaction support

Hi! Thank you for your library !
Do you have any plan of supporting native pgx transaction ? (like sqlx)

Hi, thanks for your question. It's already supported.
When you call pgxscan.Select() or pgxscan.Get() you pass something that implements pgxscan.Querier interface and from the docs for this interface:

Querier is something that pgxscan can query and get the pgx.Rows from. For example, it can be: *pgxpool.Pool, *pgx.Conn or pgx.Tx

So you can use all scany functions on transactions or database instances, it doesn't matter for this library.
Actually, I am going to spot more light on this in the pgxscan package documentation.

Here is the new docs for it:
<EMAIL_ADDRESS>

You rock ! thank you


⚠ Bofrost.lu has degraded performance

In 6913b55, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1549 ms

Resolved: Bofrost.lu performance has improved in 923a19f after 6 minutes.


How to split train and test

How to split the data intologs_train and logs_test? Timberseg dataset does not appear to come with a default train/test split.

OK, I got the annos_train.json and annos_test.json by running init_maskrcnn function in python3 standard_maskrcnn.py...


[TypeScript][Virtual Assistant Sample] Update Test folder

Purpose
What is the context of this pull request? Why is it being done?
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
Tests
Is this covered by existing tests or new ones? If no, why not?
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
Checklist
General

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated the appropriate tests
[ ] I have updated related documentation

Bots

[ ] I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
[ ] I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

[ ] I have replicated my changes in the Virtual Assistant Template and Sample projects
[ ] I have replicated my changes in the Skill Template and Sample projects

@VictorGrycuk , the changes should be only in the template of the assistant.
Also, we are migrating only the changes in the Virtual Assistant, so those of BotBuilder-Solutions should be rollbacked.

LGTM


Create a Character Selection Screen

Comment from #60
However, to do this I suggest creating a new scene. If the user pressed wasd or arrow keys, use an array to track character sprites and things, and every left or right increase the array index, and save it in our save manager
THis should be created, and used to save the selected character

Finished via c35166ece8f69d3556af82df2889c1ab88c7630c


@himanshu211raj Take a look at the contributing.md to learn how to contribute in this repo. You can open a discussion if you have any questions ✨

@himanshu211raj Take a look at the contributing.md to learn how to contribute in this repo. You can open a discussion if you have any questions ✨
Originally posted by @janiceilene in https://github.com/github/docs/issues/1571#issuecomment-736053188

Good afternoon,
Just letting you know I hope you accept my apologies for mistakes I made whilst trying out GitHub a little time back.
Yours sincerely
Mike Mckenzie
Get Outlook for iOShttps://aka.ms/o0ukef

From: jace<EMAIL_ADDRESS>Sent: Sunday, January 3, 2021 10:54:00 AM
To: github/docs<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [github/docs] @himanshu211raj Take a look at the contributing.md to learn how to contribute in this repo. You can open a discussion if you ha...
Closed #2511https://github.com/github/docs/issues/2511.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/github/docs/issues/2511#event-4162354861, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR5INP4ZE23DL3FEYZE6J5TSYBEERANCNFSM4VRYWY5A.

Good afternoon,
Just letting you know I hope you accept my apologies for mistakes I made whilst trying out GitHub a little time back.
Yours sincerely
Mike Mckenzie
Get Outlook for iOShttps://aka.ms/o0ukef

From: jace<EMAIL_ADDRESS>Sent: Sunday, January 3, 2021 10:54:00 AM
To: github/docs<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [github/docs] @himanshu211raj Take a look at the contributing.md to learn how to contribute in this repo. You can open a discussion if you ha...
Closed #2511https://github.com/github/docs/issues/2511.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/github/docs/issues/2511#event-4162354861, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR5INP4ZE23DL3FEYZE6J5TSYBEERANCNFSM4VRYWY5A.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Mike Mckenzie<EMAIL_ADDRESS>Sent: Sunday, January 3, 2021 1:11:05 PM
To: github/docs<EMAIL_ADDRESS>github/docs<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Apologies for mistakes made by myself
Good afternoon,
Just letting you know I hope you accept my apologies for mistakes I made whilst trying out GitHub a little time back.
Yours sincerely
Mike Mckenzie
Get Outlook for iOShttps://aka.ms/o0ukef

From: jace<EMAIL_ADDRESS>Sent: Sunday, January 3, 2021 10:54:00 AM
To: github/docs<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [github/docs] @himanshu211raj Take a look at the contributing.md to learn how to contribute in this repo. You can open a discussion if you ha...
Closed #2511https://github.com/github/docs/issues/2511.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/github/docs/issues/2511#event-4162354861, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR5INP4ZE23DL3FEYZE6J5TSYBEERANCNFSM4VRYWY5A.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Mike Mckenzie<EMAIL_ADDRESS>Sent: Sunday, January 3, 2021 1:11:05 PM
To: github/docs<EMAIL_ADDRESS>github/docs<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Apologies for mistakes made by myself
Good afternoon,
Just letting you know I hope you accept my apologies for mistakes I made whilst trying out GitHub a little time back.
Yours sincerely
Mike Mckenzie
Get Outlook for iOShttps://aka.ms/o0ukef

From: jace<EMAIL_ADDRESS>Sent: Sunday, January 3, 2021 10:54:00 AM
To: github/docs<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [github/docs] @himanshu211raj Take a look at the contributing.md to learn how to contribute in this repo. You can open a discussion if you ha...
Closed #2511https://github.com/github/docs/issues/2511.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/github/docs/issues/2511#event-4162354861, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR5INP4ZE23DL3FEYZE6J5TSYBEERANCNFSM4VRYWY5A.


Reliable start on Windows

We need to develop some reliable way to start that as a service (or a service-like entity) on Windows.

Hm, unfortunately it seems to be no good way of creating Windows service with Vagrant. Tuned my startup task a bit more, let's check if it will work. I should document that after testing.


Add more color picker tools

Added: Colourcode, NIPPON COLORS, and UI Gradients

hey, Alex, a lot of thanks for your contribution! I found these tools very useful!
I just removed http://nipponcolors.com, because I don't understand Japanese :)


Add collect perf task

It seems we forgot to add perf counter collect in the task in the last merge.

fix blank lines

Codecov Report

Merging #153 into master will increase coverage by 1.3%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #153     +/-   ##
=========================================
+ Coverage   92.43%   93.73%   +1.3%
=========================================
  Files           4        4
  Lines         542      543      +1
=========================================
+ Hits          501      509      +8
+ Misses         41       34      -7

Impacted Files
Coverage Δ

vmware_exporter/vmware_exporter.py
92.96% <100%> (+0.44%)
:arrow_up:

vmware_exporter/defer.py
97.22% <0%> (+13.88%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d1687...8a96fe8. Read the comment docs.

Have you tested this locally to make sure it works?

Yes it works


CU-861nb31h3_bug-stepCA-kustomization_Alok-Hom

CU-861nb31h3_bug-stepCA-kustomization_Alok-Hom

Task linked: CU-861nb31h3 bug stepCA kustomization


[Enhancement] allow Kafka Producer to be stored in Egeria

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Kafka Producers cannot be stored in Egeria
Expected Behavior
We currently have   https://egeria-project.org/open-metadata-publication/website/open-metadata-types/0223-events-and-logs
The SubscriberList would be a list of consumers.
I propose :

we deprecate  SubscriberList and add TopicSubscriber - the type name should be singular
deprecate SubscriberTopic relationship and introduce a new one with end TopicSubscriber. Maybe call is SubscriberTopicLink
add a new TopicPublisher and TopicPublisherLink
Consider changing the cardinality so that there is only one subscriber for a Topic. Unless subscribing to multiple topics is likely to be needed.
consider what identifies a consumer or publisher. I see group.id as a property. Is this the identifier that is important?
consider adding properties to the TopicSubscriber and TopicPublisher to hold the Kafka properties associated with the consumer and producer, or do these all go in as additional properties.
consider whether we need to be aware of consumer groups and partitions.

Alternatives
no
Any Further Information?
no
Would you be prepared to be assigned this issue to work on?

[X] I can work on this

@mandy-chessell I see that the asset manager omas has ServerAssetUseType. I cannot see it being used. I cannot see an OMAS API that would allow the consumers and producers to be added and queried in Egeria. I assume this would be asset manager omas, rather than the data manager which is handling topics and schemas.
The AssetManagerElement in the Asset manager OMAS contains SoftwareServerCapability properties. I looks like we might need to extend this OMAS so that AssetManagerElement contains this relationship content, either by
1- add CRUD calls for the relationship
or
2- extend AssetManagerElement to contain an array of cutdown topics objects. something like
{
qualifiedName:
guid:
assetUse:
}
Maybe add more granular CRUD calls for the contents of the array,
The 2nd option looks more consumable - as the caller could then query the asset manager element and see the software server capability properties and the consumer and producer information.
Would it be reasonable for the data manager to be able to see the consumers and producers associated with the topic? I am not sure whether the persona would ever need this information.
Can you confirm this makes sense please @mandy-chessell .


Use regional endpoints for sts:AssumeRoleWithWebIdentity

Background
We can use Regional AWS STS endpoints instead of the global endpoint to reduce latency, build in redundancy, and increase session token validity when pods execute sts:AssumeRoleWithWebIdentity for IRSA. However, K8s manifests don't have AWS_STS_REGIONAL_ENDPOINTS=regional to use the regional endpoints. So, I will add the environment variable to the manifests.
Target
> ag -l eks.amazonaws.com/role-arn
modules/cluster/addons/aws-ebs-csi-driver.yaml
modules/cluster/addons/cluster-autoscaler.yaml
modules/cluster/addons/kustomize/overlays/aws-ebs-csi-driver/eks_iam_for_sa.yaml
modules/cluster/addons/kustomize/overlays/aws-alb-ingress-controller/eks_iam_for_sa.yaml
modules/cluster/addons/helm/cluster-autoscaler.yaml
modules/cluster/addons/aws-alb-ingress-controller.yaml

Related info

Managing AWS STS in an AWS Region

Seems like a good optimisation


allow openpilot to work when gear shifter is in sport mode

We've only ever allowed engagement in Drive in the past, will let @rbiasini comment on if we want to support sport mode. Also, openDBC changes should be made in that repo

supporting sport mode seems totally harmless. not allowing it would be an excessive restriction / unnecessary irritant.
also feel free to move the one-line dbc change (which improves decoding, regardless of  whether sport mode is allowed or not) to that repo.

@marcbou , the issue is that the throttle tuning is quite different if the the gear is in sport. It would require a different controls tuning (especially when pedal interceptor is used).


create template from snapshot regression (partly reverted)

Description

see #3723 for details. backport after merging

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan package

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-465

@DaanHoogland If I understood it correctly, this PR should go to <IP_ADDRESS>. If so, can you please change the target branch to 4.13?

Have I missed something here? Where did take snapshot button go?

tnx @GabrielBrascher
@borisstoyanov I have no idea, this PR is about creating templates from snapshots, not about creating snapshots. seems like you have another issue there.

@blueorangutan package

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-470

I double checked the changes in this PR @borisstoyanov . These exact changes are in master so if the bug is not on master there is something else wrong either in 4.13 or inyour env. I'm testing in simulator as well.


Version question

Me again :-)
How would you suggest to handle versions of the API endpoints?
Not sure https://github.com/dotnet/aspnet-api-versioning this package can be used with yours.
Would it help if it was possible to have a .Version property on the endpoint (optional) as well?
And that, by convention (or trough setup), you could have /v1 or /v2.1 or whatever prefixed?
Of course, manually is also optional, just create two EndPoints and point manually to this version.
But it might me a nice optional feature to add?
Happy to discuss or collaborate on this one.

minimal api does not have support for versioning yet. it's coming in .net 7 if i remember correctly.
i will investigate in the meantime if there's an easy way to do it without waiting for the next .net release.
we might have to throw away our efforts when it comes out though.
so i'll treat this as a low priority issue.

Ok thx. In the meantime I will investigate if I can prepare something that's pluggable (and can be thrown away later) :-)

sounds good!

My proposal (did not make a PR, so that you can evaluate it first)
Extend class EndpointSettings with internal string? Version;
Extend class Endpoint in file Endpoint.Setup with
protected void Version(string version)
{
    Settings.Version = version;
}

In class MainExtensions
Add class
public class VersioningOptions
{
	public string DefaultVersion { get; set; }
	public string Prefix { get; set; }
}

In the Config class
internal static VersioningOptions versioningOptions { get; set; } = new();

	public Action<VersioningOptions>? VersioningOptions
	{
		set => value?.Invoke(versioningOptions);
	}

and in UseFastEndpoints method add following above var hb = builder.MapMethods(targetRoute, new[] { verb }, EndpointExecutor.HandleAsync);
var targetRoute = route;
if (Config.versioningOptions is not null)
{
  var prefix = Config.versioningOptions.Prefix;
  var version = ep.Settings.Version ?? Config.versioningOptions.DefaultVersion;
  var slash = targetRoute.StartsWith("/") ? "" : "/";
  targetRoute = $"{prefix}{version}{slash}{targetRoute}";
}

This was it is not mandatory to use (if not set in the UseFastEndpoints).
If you want to use it add it to the config properties on startup:
	config.VersioningOptions = options =>
	{
		options.DefaultVersion = "1.0";
		options.Prefix = "v";
	};

then all routes will have v1.0/ prefix for example.
In the EndPoints itself you can override in the Configure:
    public override void Configure()
    {
        Post("test-cases/plaintext/{Id}");
        AllowAnonymous();
        Version("1.1");
    }

You can have 2 endpoints with same route, but because of the different version it will work.
Happy to discuss it further.

awesome! this looks great.
chuck it in a PR and I will merge.
oh and don't forget to write a couple of tests that will cover the new code paths.
thanks 🙏

Ok. Will do.

@stefandevo added versioning support for swagger...
https://github.com/dj-nitehawk/FastEndpoints/blob/c3518d055e138b5f7785441a6c7df070b9d77b21/Web/Program.cs#L21-L34

@dj-nitehawk How does this work with the latest swagger package? Swagger listed all my endpoints until I enable versioning. After I enabled the versioning, swagger does not list any of my endpoints. But the endpoints are available and I can access them through postman
builder.Services.SwaggerDocument(o => {     o.DocumentSettings = s =>     {         s.Title = "FastEndpoints Sandbox";         s.Version = "v1.0";         s.DocumentName = "v1";         s.ApiGroupNames = new[] { "v1" };     }; }); ... app.UseFastEndpoints(c => {     c.Versioning.Prefix = "v";     c.Versioning.PrependToRoute = true;     c.Versioning.DefaultVersion = 1; });

Thanks @dj-nitehawk. It worked.


Add PutGraphEdgeAsync PUT/_api/gharial/{graph}/edge/{collection}/{edge}

Properties in PutGraphEdgeResult do not match the response, I'll open a new PR on that issue.


add white-label options for title, custom logo, code and styles

Hi,
we're using Zeebe Simple Monitor in multiple environments like DEV, STAGE, and PROD.
I would like to highlight what environment I'm in by changing colors and logos on the page.
E.g. green for test and red for PROD.
That basic wish led me to the idea, to enable basic white-label features for CSS, JS, the logo, and the title.
This PR adds some new options in the application yaml, extends the ViewController
and obviously adds some tests to be safe in the future.
I took the freedom to drop the empty test class in favor of some real one.
Any feedback is welcome.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@nitram509 thank you for your contribution 🎉
I'll look into your PR when I'm back from vacation 🌴


fix(style-props): add content property and example to style-props page

Closes # https://github.com/chakra-ui/chakra-ui/issues/561
📝 Description

add missing content property & example for ::before example with extra note about quotes

⛳ Current behavior (updates)

content prop is missing and no clear example for its usage

🚀 New behavior

add missing content property & example for ::before example with extra note about quotes

💣 Is this a breaking change (Yes/No):
no
📝 Additional Information

@nikolovlazar feedback addressed

@aaarichter when the build is failing in the pipeline, most of the time you can reproduce the fail locally.

@aaarichter we just merged a big PR that restructures the docsite. You have a conflict in the style-props.mdx file now, because it got moved to pages/docs/styled-system/features/style-props.mdx.

seems like the rebase did the trick. pipeline is green now. 💚

when the build is failing in the pipeline, most of the time you can reproduce the fail locally.

good to know. On that point I was expecting to just open the pipeline tool and see what the issue is but when faced with a login and the need to register, I bailed. I wonder if it is better than github actions, which can be viewed from anyone ?!

@aaarichter just add an empty space after the '5px', and then we merge, okay?

force pushed @nikolovlazar


Failing Uncontested Election

IRV fails when the election is uncontested. See branch https://github.com/nathanllww/slivka-irv/tree/test_case for the new test case.

This issue was actually much broader and problematic, so I'll include here what it was.  Essentially, if only one candidate remained, IRV did not recompute tallies.  This lead to systems like "a; b,a" being marked as no confidence even when a should win.  The fix is thus somewhat straightforward: when we've eliminated all but one candidate, compute tallies one final time before declaring a winner.
Thanks for catching this, seems it could have affected a wide number of elections.


Add .frm and .cls extensions to VB6

Following up on discussions in issue https://github.com/github/linguist/issues/5824, I'm proposing to add .frm and .cls as extensions for VB6 with heuristics to distinguish it from VBA.
Description
The heuristics added to distinguish VBA from VB6 were suggested by @XusinboyBekchanov :

frm
VBA:

VB6:

cls
VB6 :

VBA : If the pattern above doesn't match, we default to VBA.

The key of these are based on the way the VB6 and VBA IDEs encode information at the top of the file when exporting the forms or class module as text files. From what I know, there isn't really a good reason for developers to alter this information as this could cause issues when trying to import back the text file into their IDE. Hence, those differences should be sufficiently reliable to distinguish between VBA and VB6.
PS : Due to the way I pulled changes from master, this pull request appears to contain more commits that it really does. Commits before 2d3547 can be ignored.
Checklist:
VB6

[x] I am associating a language with a new file extension.

[x] The new extension is used in hundreds of repositories on GitHub.com

Search results for each extension:

https://github.com/search?utf8=✓&type=Code&ref=searchresults&q=extension%3Afrm+"Begin+VB.form"+NOT+nothack
https://github.com/search?utf8=✓&type=Code&ref=searchresults&q=extension%3Acls+Persistable+NOT+nothack

[x] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

https://raw.githubusercontent.com/dragokas/hijackthis/devel/src/frmMain.frm
https://raw.githubusercontent.com/dragokas/hijackthis/devel/src/clsDataPack.cls

Sample license(s): GPL-2.0 license (both)

[x] I have included a change to the heuristics to distinguish my language from others using the same extension.

VBA

[x] I am fixing a misclassified language

[x] I have included a new sample for the misclassified language:

Sample source(s):

https://raw.githubusercontent.com/ivankokan/Excel2LaTeX/master/src/frmConvert.frm
https://raw.githubusercontent.com/rubberduck-vba/Battleship/master/src/GridCoord.cls

Sample license(s): LaTeX public license / MIT

[x] I have included a change to the heuristics to distinguish my language from others using the same extension.

Regarding the .bas extension, I've intentionally kept it out of this PR since I'm still not sure about the heuristic for it when it's time to distinguish between VBA and VB6.

Because this sample is a VB6 sample (based on the heuristics this PR introduced). My understanding is that in the PR https://github.com/github/linguist/pull/4725, where this sample was added, the intention was to put VBA and VB6 under the same language "VBA/VB6", but when it changed to just VBA, the sample for VB6 was left there by mistake.

Cool. In that case, please move it rather than remove it. We've already approved its inclusion so there's no need to find the source etc.
You can still add another if it'll help the classifier which is falling on this extension.

Tthe Classifier test didn't succeed with 100%, but it's already better:
.cls (5/6)
VBA/GridCoord.cls BAD ❌(Visual Basic 6.0)
VBA/WorkbookReporter.cls ✅
VBA/dictionary.cls ✅
Visual Basic 6.0/cApplication.cls ✅
Visual Basic 6.0/clsDataPack.cls ✅
Visual Basic 6.0/clsMenuImage.cls ✅
.frm (4/4)
VBA/frmConvert.frm ✅
VBA/stdSaveHandler.frm ✅
Visual Basic 6.0/Adjustments_BlackAndWhite.frm ✅
Visual Basic 6.0/frmProcMan.frm ✅
Considering that the heuristics saould be pretty reliable, can this suffice?

The Classifier test didn't succeed with 100%, but it's already

It needs to. Try removing the sample or adding another sample.

Alright, I've switched the problematic sample with another one from the same project. Now, all the tests passed and I updated the PR description at the top with the correct samples.
Looks like we are good to go unless there is something I missed.


When a program is activated through Workspaces, it no longer works with FancyZones

Microsoft PowerToys version
0.84.0
Installation method
Microsoft Store
Running as admin
No
Area(s) with issue?
FancyZones
Steps to reproduce
I ran Microsoft Word and Adobe Acrobat using a Workspace. When trying to move either of their windows holding shift to move it to FancyZone, the FancyZone overlay didn't show up, and I couldn't snap either of these windows to the zone. All other windows worked fine. Also, it was another Workspace which I ran: after starting the computer I ran one workspace, then the second workspace over it with Word and Acrobat in question.
✔ Expected Behavior
Moving window (of the program started with Workspace) while holding shift displays FancyZone overlay and allows to snap a window to the Zone.
❌ Actual Behavior
Moving window (of the program started with Workspace) while holding shift didn't display FancyZone and essentially worked as regular moving window.
Other Software
Microsoft Word 365 Insider Preview, newest version, Adobe Acrobat from Adobe Creative Cloud, latest version

/dup #34566


Lens view not loading, locking up app

[Beta6] After successfully downloading papers, double clocking them from Saved does not load Lens. Furthermore, while hover highlighting is still present, all UI elements lose click interaction - the app's UI is essentially locked up after attempting to read a paper.

@gmaciocci which OS is this?
Could you please try opening the devtools,:

macOS: Cmd Alt I or F12
Windows: Ctrl Shift I or F12

Under the console tab there should be one or more errors - if you could copy them here that would be awesome.
For the next release I hope to have these errors reporting directly to a server.

@blahah  MacOS.
http://doi.org/10.7554/eLife.10627
/Applications/ScienceFair.app/Contents/Resources/app/client/views/reader.js:45 Uncaught TypeError: Cannot read property 'source' of undefined     at reader (/Applications/ScienceFair.app/Contents/Resources/app/client/views/reader.js:45)     at /Applications/ScienceFair.app/Contents/Resources/app/node_modules/choo/index.js:43     at emit (/Applications/ScienceFair.app/Contents/Resources/app/node_modules/nanorouter/index.js:47)     at Function.<anonymous> (/Applications/ScienceFair.app/Contents/Resources/app/node_modules/choo/index.js:58)     at redraw (/Applications/ScienceFair.app/Contents/Resources/app/node_modules/nanoraf/index.js:28) reader @ /Applications/ScienceFair.app/Contents/Resources/app/client/views/reader.js:45 (anonymous) @ /Applications/ScienceFair.app/Contents/Resources/app/node_modules/choo/index.js:43 emit @ /Applications/ScienceFair.app/Contents/Resources/app/node_modules/nanorouter/index.js:47 (anonymous) @ /Applications/ScienceFair.app/Contents/Resources/app/node_modules/choo/index.js:58 redraw @ /Applications/ScienceFair.app/Contents/Resources/app/node_modules/nanoraf/index.js:28 /Applications/ScienceFair.app/Contents/Resources/app/node_modules/nanologger/index.js:81

@gmaciocci perfect thanks, that should be enough to debug it this evening

I can't recreate this issue in the latest betas, so I'm closing for now. Please reopen if you experience it again.

I actually did manage to recreate this eventually, by accident. The problem was a race condition between single and double-click handlers. Fix incoming.


Support for optional input artifacts

FEATURE REQUEST:
In order to support building workflows out of reusable templates, I'd like to see Argo support optional input artifacts.  At the moment, failing to provide an input artifact when a step calls a template is always an error.  Parameters are already optional if they have a default value.
Has this been considered?

In other words, are you asking for default field for artifacts? I think it is possible for artifacts to follow the same semantics as parameters. If there is a default value for an input artifact, then it becomes optional.

Fixed in https://github.com/argoproj/argo/pull/1277.
Example: https://github.com/argoproj/argo/blob/master/test/e2e/functional/input-artifact-optional.yaml


docker:dind 20.10 is slow to start when TLS is disabled.

docker:dind 20.10 is slow to start when TLS is disabled. From looking at dockerd logs, the cause is clear.
time="2021-02-05T23:51:10.090433317Z" level=warning msg="Binding to an IP address without --tlsverify is deprecated. Startup is intentionally being slowed down to show this message" host="tcp://<IP_ADDRESS>:23
75"
time="2021-02-05T23:51:10.090713833Z" level=warning msg="Please consider generating tls certificates with client validation to prevent exposing unauthenticated root access to your network" host="tcp://0.0
.0.0:2375"
time="2021-02-05T23:51:10.090768981Z" level=warning msg="You can override this by explicitly specifying '--tls=false' or '--tlsverify=false'" host="tcp://<IP_ADDRESS>:2375"
time="2021-02-05T23:51:10.090786304Z" level=warning msg="Support for listening on TCP without authentication or explicit intent to run without authentication will be removed in the next release" host="tcp
://<IP_ADDRESS>:2375"

The dind entrypoint doesn't set --tls=false when starting up docker with tls disabled: https://github.com/docker-library/docker/blob/master/20.10/dind/dockerd-entrypoint.sh#L129
This causes slow start up now, and those logs indicate that it will not be functional in the future.

This is intentional behavior added by Docker upstream in order to discourage users from using plain-text TCP connections to the daemon (which can provide them with direct root access to the host, even with Docker-in-Docker). :confused:
I would not be comfortable with disabling this automatically against the wishes of the upstream project, and would provide the same recommendation as in #292 - the "correct" solution here is to adjust the command (and in this case, petition GitLab to allow adjusting that, because that seems like an oversight).

I am not asking to have it TLS be disabled automatically. I would just prefer for there to be a variety of functional ways to disable it explicitly. As I mentioned in #292, supplying command is not ideal for us.
I doubt that we'll be the only users to have issues switching to TLS, so I expect this will come up again.

@acornax not sure if this is best here or on #292 but mentioning it will show it on both sort of:
Why don't you simply build a derivative image that has the behaviour you need and publish it publicly and consume that in gitlab?
You don't have to use any container as is and I'd personally never use any public container as is without at the very least caching it under my own (or my org's) control with a FROM-only D-file arrangement. Never trust any upstream to not pull the rug out from under you by retagging.
It was a MASSIVE failure in design to make images mutable in the first place, but that's the world we live in - trust no docker image, you will be burned sooner or later by:
Tag vanishes
New content for same tag (potentially malicious)
Tag moves home to a new host/service eg gcr.io or quay.io or vice versa from there
If your infra (at any level) depends directly on images served from elsewhere then your infra is fragile by definition.
End rant.

Unfortunately, this is as much as we're going to do here -- most CI platforms now allow adjusting the command: of services (and more full-featured orchestration systems like Kubernetes definitely do).


Test querying a target with a low quality image and a SUCCESS status

We already have the image_file_success_state_low_rating fixture for this.

In the real Vuforia, this has no matches.
It does match in our mock.
We can't really test this now, as the target ratings are assigned randomly.
We could just "modify" the database in the test - but that doesn't seem great.
Let's instead implement a quality-assigning algorithm which is close enough for our tests.

Suggested plan:

First, replace the hardcoded random function for getting a target rating with a parameter callable. Use random as the default for now.
Replace random with a use of brisque - either by default or as an option.


Confirm action when deleting a folder

In the Files > Files view, if I right-click on a folder and (accidentally) select "Delete" (instead of "Import Files"), I expected a confirmation dialog to confirm the action because it is a destructive action.

Not sure, I think you can undo/redo this?
If that's the case, there is no need for a confirmation dialog.


remove imports unnecessary of react-router

Remove imports of react-router in client #62

@carloscuatin Thanks a lot!


Not compatible with Minecraft 1.21.1

Describe the bug
Modrinth page says that Proxy Command Reloaded is compatible with Minecraft 1.21.x, but it not actually compatible with 1.21.1
To Reproduce
Start a fabric minecraft server 1.21.1 with a latest version of Proxy Command Reloaded
Expected behavior
The server should start
Additional context
The log
[19:37:11] [main/INFO]: Loading Minecraft 1.21.1 with Fabric Loader 0.16.5
[19:37:11] [main/WARN]: Mod resolution failed
[19:37:11] [main/INFO]: Immediate reason: [HARD_DEP_INCOMPATIBLE_PRESELECTED proxy-command 1.1-1.21-34 {depends minecraft @ [1.21]}, ROOT_FORCELOAD_SINGLE proxy-command 1.1-1.21-34]
[19:37:11] [main/INFO]: Reason: [HARD_DEP proxy-command 1.1-1.21-34 {depends minecraft @ [1.21]}]
[19:37:11] [main/INFO]: SERVER environment disabled: [fabric-renderer-api-v1, fabric-model-loading-api-v1, fabric-keybindings-v0, fabric-renderer-registries-v1, fabric-client-tags-api-v1, fabric-sound-api-v1, fabric-rendering-v0, fabric-screen-api-v1, fabric-rendering-v1, fabric-key-binding-api-v1, fabric-renderer-indigo, fabric-blockrenderlayer-v1]
[19:37:11] [main/INFO]: Fix: add [], remove [], replace [[proxy-command 1.1-1.21-34] -> add:proxy-command 1 ([(-∞,∞)])]
[19:37:11] [main/ERROR]: Incompatible mods found!
net.fabricmc.loader.impl.FormattedException: Some of your mods are incompatible with the game or each other!
A potential solution has been determined, this may resolve your problem:
         - Replace mod 'ProxyCommand' (proxy-command) 1.1-1.21-34 with any version that is compatible with:
                 - minecraft 1.21.1
More details:
         - Mod 'ProxyCommand' (proxy-command) 1.1-1.21-34 requires version 1.21 of 'Minecraft' (minecraft), but only the wrong version is present: 1.21.1!
        at net.fabricmc.loader.impl.FormattedException.ofLocalized(FormattedException.java:51) ~[ma1bspjw4klsqkqn4h0gbm09wvgl1w8b-fabric-server-launch.jar-fabric-0.16.5-1.21.1:9.6]
        at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:196) ~[ma1bspjw4klsqkqn4h0gbm09wvgl1w8b-fabric-server-launch.jar-fabric-0.16.5-1.21.1:9.6]
        at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:146) ~[ma1bspjw4klsqkqn4h0gbm09wvgl1w8b-fabric-server-launch.jar-fabric-0.16.5-1.21.1:9.6]
        at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68) [ma1bspjw4klsqkqn4h0gbm09wvgl1w8b-fabric-server-launch.jar-fabric-0.16.5-1.21.1:9.6]
        at net.fabricmc.loader.impl.launch.knot.KnotServer.main(KnotServer.java:23) [ma1bspjw4klsqkqn4h0gbm09wvgl1w8b-fabric-server-launch.jar-fabric-0.16.5-1.21.1:9.6]
        at net.fabricmc.loader.impl.launch.server.FabricServerLauncher.main(FabricServerLauncher.java:69) [ma1bspjw4klsqkqn4h0gbm09wvgl1w8b-fabric-server-launch.jar-fabric-0.16.5-1.21.1:9.6]

Thanks for letting me know, I'll take a look asap. It might be a bit tho, I've got a lot on my plate atm

Thanks for letting me know, I'll take a look asap. It might be a bit tho, I've got a lot on my plate atm

No rush, please take care of yourself! Thank you!

You can fix this by changing "1.21" in fabric.mod.json to ["1.21", "1.21."], but it might be possible to use just "1.21.".


Fixups from #3324

Fixes some bugs and other issues, including unnecessary metadata options and uneven info in metadata.yaml files, introduced in #3324

FYI @sicoyle

reviewing rn. Thanks for the tag here :)

@holopin-bot @ItalyPaleAle Enjoy the Dapr components badge!


TINKERPOP3-1013: Traverser tags as a safer way of using path labels

https://issues.apache.org/jira/browse/TINKERPOP3-1013
We have had a hack in MatchStep this whole time where we use path labels to store branch history. This is not only semantically awkward (as labels are added that were not provided via as()), it also means we will not be able to do https://issues.apache.org/jira/browse/TINKERPOP3-736. Also, this will allow us to cleanly implement IntersectStep and SymetricDifferenceStep (down the road).
The implementation is really simple. Traverser.getTags(). This method returns a mutable set and thus, we can remove, add, size, contains, etc. tags associated with a traverser.
Ran mvn clean install and all is golden.
VOTE +1.

Ran mvn clean install - all good.
VOTE +1

Tests passed and code looks good.
VOTE +1


Loading data from CD and DICOM dir locally

I was wondering if there OHIF supports reading DICOM files from local directories or CD. If not I am willing to work on it. I can come up with a design and propose it and then implement it. Only thing I would need is some pointer to where to start from

👋 Hi @mbbs, I think this is something we would eventually like to see support for. Most/all of our DICOM data comes in through a cornerstone image loader. Our specific implementation is the cornerstoneWADOImageLoader. There is an example of it loading a file from the local system here:
https://rawgit.com/cornerstonejs/cornerstoneWADOImageLoader/master/examples/dicomfile/index.html
A simple/good MVP would likely add a toolbar button that allows file/directory selection. Once selected, we load and cache each image, and add the study(ies) to the current viewing session. I think the biggest hurdle here, if we're not going to persist the images to some sort of web accessible storage, will be memory limitations and informing the user appropriately when they're reached.

You can use the local viewer (at /local) where you can drag/drop files or use the Browser's file selector. If you want to send a PR to add a folder selector option that would also be fine, but I think that's Chrome-only: https://viewer.ohif.org/local

Hello @swederik Is there anyway to push File Base64 directly to Viewer rather than using /local for file selection option?


Wkhtmltopdf 0.12.1

I'm not sure everything is working well. At least all tests passed.
Related: #200 #234

@pdfkit/rb The more I get a feel for this project, the more I think this PR should just be merged in. Many, many of our users are on wkHTMLtoPDF 0.12.x and our installation instructions will lead people to end up with such a version.
We require no code changes to support 0.12.x, so there's really no point in keeping this PR open until a major version change. There's no loss of compatibility.
Thoughts or concerns?

I agree. I've been using pdfkit with wkhtmltopdf 0.12.1 for a while in production with no issues.
Serene
-----Original Message-----
From: Amy Unger<EMAIL_ADDRESS>To: pdfkit/pdfkit<EMAIL_ADDRESS>Cc: Serene Yew<EMAIL_ADDRESS>Sent: Sat, 13 Jun 2015 3:14 PM
Subject: Re: [pdfkit] Wkhtmltopdf 0.12.1 (#250)
@pdfkit/rb The more I get a feel for this project, the more I think this PR should just be merged in. Many, many of our users are on wkHTMLtoPDF 0.12.x and our installation instructions will lead people to end up with such a version.
We require no code changes to support 0.12.x, so there's really no point in keeping this PR open until a major version change. There's no loss of compatibility.
Thoughts or concerns?

Reply to this email directly or view it on GitHub:
https://github.com/pdfkit/pdfkit/pull/250#issuecomment-111752994

I agree. I've been using pdfkit with wkhtmltopdf 0.12.1 for a while in production with no issues.

In that case...

:sparkles: :cake: :sparkles: