Colorspace: publish config data with rootless path

We are currently publishing the representation's colorspaceData with an absolute path and a template. However, these are not usable because the absolute path might not work on different platforms, and the template requires formatting data that we are not publishing with the colorspaceData.
It would be better to publish the path using a rootless path and remove the template. Since we can now publish the OCIO product, it would also be good to add a representation ID if colorspaceData refers to a published OCIO product.

Don't we technically allow different OCIO paths based on OS - and hence, this may differ more than just by rootless path?


Suggestion: Add message to log as to what the run is trying to accomplish

The current auto pilot is running on node 10.3. It is at w0r1d_d43m0n with 55k Hack atm. It seems to have all the augs, except a few NeuroFlux levels. I have 3Q money, 19t stock and almost 800k STR. Why doesn't it just backdoor and destroy 10.3? Is it working toward some other goal?
Latest autopilot log:
Can currently get: 0 of 0 remaining augmentations + 5 levels of NeuroFlux.
Total Cost: $814.101q (run faction-manager.js for details)
Currently at 4h 16m 38s since last aug. Waiting for 9 new augs (or 12 including NeuroFlux levels) before installing.
Can currently get: 0 of 0 remaining augmentations + 6 levels of NeuroFlux.
Total Cost: $1.431Q (run faction-manager.js for details)
Currently at 6h 41m 18s since last aug. Waiting for 8 new augs (or 11 including NeuroFlux levels) before installing.
Can currently get: 0 of 0 remaining augmentations + 7 levels of NeuroFlux.
Total Cost: $2.717Q (run faction-manager.js for details)

If you scroll up a bit higher, you would hopefully see:

WARNING: Detected that you only have ${numSleeves} sleeves, but you could have ${shouldHaveSleeveCount}. + Try not to leave BN10 before buying all you can from the faction "The Covenant", especially sleeve memory! +
NOTE: You can ONLY buy sleeves/memory from The Covenant in BN10, which is why it's important to do this before you leave.

So the log is already in place, but there's nothing currently in place to increase its visibility if you are AFK for a long time when it comes up.


Installing F# SDK Tools to VS Experimental Instance

https://github.com/Microsoft/visualfsharp/blob/master/DEVGUIDE.md#4-optional-install-the-visual-f-ide-tools-and-clobber-the-f-sdk-on-the-machine
Instead of clobbering the machine wide installation of F# is it possible to install the VSIX and update the vsintegration in an experimental instance instead to remove the need to repair VS to go back to the release version of the SDK?

Or at the very least anything to avoid

Repairing Visual Studio 2015 is currently the only way to revert this step

as this can take several hours at worst

This is a duplicate of https://github.com/Microsoft/visualfsharp/issues/232


qwx does not work in reader view

Describe the bug
qwx does not work in reader view.
To Reproduce
Steps to reproduce the behavior:

Go to any web page which support reader view
Click on 'show reader view' icon(hamburg)
Use qwx to switch or close tab, no response.

Expected behavior
qw should switch  and x should closed tab.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

macOS version: 10.15.5
Safari version: 13.1.1
Vimari version: 2.0.3

Additional context
Add any other context about the problem here.

Thanks for your report evenlee, as far as I know Safari Extensions are limited to the webpage. This means that none of the added behaviour by Vimari will work in reader view and there is (AFAIK) no way to make it work this way.
While testing this out for myself I did find that the scrolling using q and j seems to work (although somewhat unpredictable). As a workaround you could use esc to get out of reader mode and use the features provided by Vimari. When you want to get back into reader mode you can use the shortcut CMD + SHIFT + R which should bring you to the position where you left of (if you didn't scroll the page yourself).
Perhaps the requested behaviour is possible using the new WebExtensions support that was announced during WWDC20. But this is something currently out of scope.


update: bump trivy to 0.55.0

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

We'll probably wait for v0.55.1 to be released as it contains some important bug fixes. In the meantime, could you update the tests?

Closing in favor of https://github.com/aquasecurity/trivy-action/pull/387


Feature/gradle migration

This PR includes code to migrate to gradle, needs testing for publishing and releasing to maven central.

https://scans.gradle.com/s/5z7bckis5id6s - maven clean install scan
https://scans.gradle.com/s/kgcmqodvj6nxu - gradle build scan


Add a good README to the project

[ ] What's the project.

[ ] Create a web/app online preview.

[ ] How to run the project.

[ ] Thanking and acquired knowledge.

Tools used in development:
Node.js

Express
Nodemon


fix: ci not setting up pages in doc dryrun

issue
I just realized the dryrun action will wipe the github page, sorry for this.
changes

dryrun only happened in pr before merge
removed the wrong step, this will wipe the pages

ref:

opened: A new pull request is created.
synchronize: The pull request's branch is updated with new commits.
reopened: A closed pull request is reopened.

Codecov Report
Patch and project coverage have no change.

Comparison is base (0bc8202) 0.00% compared to head (3fa6353) 0.00%.

:exclamation: Current head 3fa6353 differs from pull request most recent head adb4646. Consider uploading reports for the commit adb4646 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #231   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files          74      74
  Lines        2532    2532
  Branches      275     275
======================================
  Misses       2532    2532

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update Windows workflow

X-ref: kokkos/kokkos#7068

Windows workflow passed, don't care to wait for the Jenkins.


adds TrustedOriginPredicateFunc option, tests

Related: https://github.com/gorilla/csrf/issues/178
If upstream is chill with the feature request, I will open a PR to contribute this back!
Until then, we will maintain this fork so that we can utilize the new TrustedOriginPredicateFunc option.

Some of these CI checks failing don't matter. Gonna go ahead with this.


iox-#2066 Switch to C++17

Pre-Review Checklist for the PR Author

[x] Add a second reviewer for complex new features or larger refactorings
[x] Code follows the coding style of CONTRIBUTING.md
[x] Tests follow the best practice for testing
[x] Changelog updated in the unreleased section including API breaking changes
[x] Branch follows the naming format (iox-123-this-is-a-branch)
[x] Commits messages are according to this guideline

[x] Commit messages have the issue ID (iox-#123 commit text)
[x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[x] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[x] Relevant issues are linked
[x] Add sensible notes for the reviewer
[x] All checks have passed (except task-list-completed)
[x] All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
[x] Assign PR to reviewer

Notes for Reviewer

This PR moves the last two platforms, Linux and QNX, to the C++17 language standard. This means that we can start using C++17 features.
Checklist for the PR Reviewer

[x] Commits are properly organized and messages are according to the guideline
[x] Code according to our coding style and naming conventions
[x] Unit tests have been written for new behavior
[x] Public API changes are documented via doxygen
[x] Copyright owner are updated in the changed files
[x] All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
[x] PR title describes the changes

Post-review Checklist for the PR Author

[x] All open points are addressed and tracked via issues

References

Relates to #2066

@FerdinandSpitzschnueffler @mossmaurice @dkroenke @MatthiasKillat @elfenpiff @budrus feel free to add yourself as reviewer

@mossmaurice I hope the compiler vendors manage to get their act together and fully implement modules by then :sweat_smile:


SLAM estimate data

First of all I would like to thank the creators of the Lego-LOAM @TixiaoShan , this is a brilliant algorithm and works amazingly.
I am fairly new to SLAM and ROS in general, thus I am seeking advice on a certain doubt.
I would like to extract pose estimate data and i have carried out rostopic echo command on all the topics displayed in the rviz, however with no concrete conclusion in sight i would like to know if there is a way to extract estimate data in the format of [#timestamp tx ty tz].
I would greatly appreciate it if there is a method to do so or which topic to subscribe to.

I just want to know which topic i need to subscribe on to get the pose data, i tried /integrated_to_init and it did not seem to help.


Issues with setup

These are your instructions:
python3 -m pip install -r requirements.txt
python3 -m ipykernel install p
git clone git@github.com:dmatrix/ray-core-tutorial.git
cd to <cloned_dir>
Should they be?
git clone git@github.com:dmatrix/ray-core-tutorial.git
cd to <cloned_dir>
python3 -m pip install -r requirements.txt
python3 -m install ipykernel

@zitterbewegung I believe you can do a git clone before or after you have you've created your conda environment, activated and installed all the dependencies. But order setup as is should be fine.
Did you have any problems? BTW there is typo python3 -m ipykernel install p should be python3 -m ipykernel install

fixed in PR #41


Incorrect README examples

Hi,
First of all thank you for a create operator in general. However, there seems to be many cases where the README examples of configurations don't correspond to the actual CRD. Comparing the QuaEcosystem CRD with the examples, the major discrepancy seems to be the key externalAccess which I can't find in the yaml. This means that for example the case in the README with
apiVersion: redhatcop.redhat.io/v1alpha1
kind: QuayEcosystem
metadata:
  name: example-quayecosystem
spec:
  quay:
    imagePullSecretName: redhat-pull-secret
    externalAccess:
      tls:
        secretName: custom-quay-ssl

rather should be
apiVersion: redhatcop.redhat.io/v1alpha1
kind: QuayEcosystem
metadata:
  name: example-quayecosystem
spec:
  quay:
    imagePullSecretName: redhat-pull-secret
    sslCertificatesSecretName: custom-quay-ssl

The same applies to the hostname and probably more cases.

@windmark The externalAccess property is being introduced in the next release of the Operator. There will be a guide in a newly forthcoming release notes to describe the changes.
The tagged release should be the safe path to use.
Hopefully this should clarify any confusions

Hi @sabre1041,
Thank you for a quick answer. Ah yes I see, I had missed that the different branches (and thus versions of README) for the releases. Confusing when different open-source repositories use different release methodologies. Thanks!


Portfolio: Desktop Version

Updated index.html & mobile_first.css

Worked in a 768px view

Added remaining sections for my recent works.
Added nav menu in top of the page.
Fixed stlyes in buttons.
Implemented Media Queries for Desktop Version
Reorder some elements for Desktop Version
Added new background imgs for Desktop Version

Sumary Preview :

Updated index.html & mobile_first.css

Made the Required Changes: ♻

Removed hamburguer button when displaying Desktop View. ✅
Fixed "projects" positions from "my-work" section. ✅
Fixed positions from "languages", "frameworks" and "skills" sections. ✅
Fixed width of the contact form. ✅

Sumary Preview : 🕵🏼♂


chore: improve ExpectionAssertion type in Brittle TypeScript definitions

Noticed a couple of minor issues:

types were not handling providing a promise (note, not a function returning a promise) as the first argument
was noticing some misleading "unnecessary awaits" warnings in my editor, even though the provided function was async. narrowed it down to needing to adjust the order of the overload so that it was ordered from most specific to least specific (i.e. () => Promise<unknown> is a subset of () => unknown)

Thanks for fixing this!


[WIP] - Resource Controller

This PR

introduces a new resource controller which manages a collection of instance plugins to provision named resources (e.g. networks, gateways, volumes)
manages lifecycle and dependencies of resources
implements finite state machine FSM models for generic resources from requested to provisioning to ready states.  FSM will reconcile and re-provision if resources are lost.
will be used to provide Cloudformation-like creation of entire cluster from vpc to networks to gateways and security groups; complements the group controller which manages machines in the same environment.

Signed-off-by: David Chung<EMAIL_ADDRESS>

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "resource-controller" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354172632
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.


Add a TicTacToe board and basic tests for it.

Is this what you were thinking of?

My only suggestion is that we should use Empty as part of the enum instead of null.  Otherwise I guess we're going to hit the ground running on this!
Should we break up the rest of the work on state/server?

Done. @jonahwilliams: Yep, I think we should just start self-assigning issues we want to work on!


Update face-detection-attendance-system-using-OpenCV

Related Issues or bug

Updating face-detection-attendance-system-using-OpenCV File to make it more readable and adding new functionalities to it and enhancing its features

Fixes: #1819
Proposed Changes
The Ways that I have currently Improved this code--->

    Completely Rewritten Code for Better Visibility

    Use a DATA_PATH variable to organize your data

    Break down the code into functions (like load_known_faces, mark_attendance, and recognize_faces) for better structure and
    reusability.

    Append attendance records to a CSV file (like attendance.csv) for easy record-keeping.

    Display recognized faces with green rectangles and namesand use red rectangles for unknown faces.

    Enable the user to exit the system using the 'q' key.

    Added Comments for better Understanding

Additional Info

Hey! I am A complete begginer to this so if there is any issue with this please let me know as I wish to imporve my self. Thanking You

Screenshots
Updated ScreenShot

@akshitagupta15june can you please review this


AtotiJavaException: Missing base

Steps to reproduce
Hello,
I am not able to reproduce on a simple notebook so maybe there is a link between this issue and my data, note that it worked on 0.5.2.
The issue only happens if I perform the join in a certain order.
Actual Result
AtotiJavaException: Missing base: com.qfs.store.ref.impl.MultiVersionUniqueConcreteReference$UniqueConcreteReferenceBase@101a4304
Expected Result
I would like to perform the joins in the order I wish, moreover if I remember well, the order I was using in 0.5.2 was the best in term of performances.
You can find the data here: https://drive.google.com/file/d/1ppeHogGGYHR_0KYIztwiKQDkNKg_rx8Y/view?usp=sharing.
import atoti as tt

session = tt.create_session(
    config={
        'logging': {'file_path': './logs/server.logs'}
    }
)

contracts_table = session.read_csv(
    './data/contracts/*.csv',
    keys=['Reporting Date', 'Contract ID', 'Legal Entity'],
    table_name='Contracts'
)

previous_contracts_table = session.read_csv(
    './data/contracts_previous/*.csv',
    keys=['Reporting Date', 'Contract ID', 'Legal Entity'],
    table_name='Previous Contracts'
)

clients_table = session.read_csv(
    './data/clients/*.csv',
    keys=['Reporting Date', 'Client ID', 'Legal Entity'],
    table_name='Clients'
)

previous_clients_table = session.read_csv(
    './data/clients_previous/*.csv',
    keys=['Reporting Date', 'Client ID', 'Legal Entity'],
    table_name='Previous Clients'
)

# Working
contracts_table.join(previous_contracts_table)
contracts_table.join(clients_table)
clients_table.join(previous_clients_table)

#  Not working
# clients_table.join(previous_clients_table)
# contracts_table.join(clients_table)
# contracts_table.join(previous_contracts_table)

Environment

atoti: 0.6.0
Python: 3.9.6
Operating System: win32

Logs
server.zip
---------------------------------------------------------------------------
AtotiJavaException                        Traceback (most recent call last)
~\AppData\Local\Temp/ipykernel_24936/1425484363.py in <module>
     33 clients_table.join(previous_clients_table)
     34 contracts_table.join(clients_table)
---> 35 contracts_table.join(previous_contracts_table)

~\.conda\envs\atoti-plus-0.6.0\lib\site-packages\atoti\_type_utils.py in typechecked_func_wrapper(*args, **kwargs)
    188
    189             # Call the actual function.
--> 190             return self._func(*args, **kwargs)
    191
    192         # Mark the function as typechecked and return it.

~\.conda\envs\atoti-plus-0.6.0\lib\site-packages\atoti\table.py in join(self, other, mapping)
    118                 Defaults to the columns with the same names in the two tables.
    119         """
--> 120         self._java_api.create_join(
    121             self,
    122             other,

~\.conda\envs\atoti-plus-0.6.0\lib\site-packages\atoti\exceptions.py in catch_py4j_exceptions(java_api, *args, **kwargs)
     71                 else f"{java_api.get_throwable_root_cause(java_exception.java_exception)}"
     72             )
---> 73             raise AtotiJavaException(
     74                 cause,
     75                 java_traceback=str(java_exception),

AtotiJavaException: Missing base: com.qfs.store.ref.impl.MultiVersionUniqueConcreteReference$UniqueConcreteReferenceBase@7e1110a3

Hi, thanks for reporting this issue.
I'm tracking this in an internal ticket : https://support.activeviam.com/jira/browse/PIVOT-4960
This should not be true anymore the order I was using in 0.5.2 was the best in term of performances., there shouldn't be any difference in 0.6.0. If you notice one can you open a ticket ?

Thank you, I will test if there is a difference or not, do you also have a link to the ticket changing this feature please? I was not aware of it.

This will be fixed in the next release


Deploy backing apps to a space dedicated to the service instance

GIVEN The application manifest contains:
spring:
  cloud:
    appbroker:
      services:
        apps:
        - name: my-app
          target:
          - name: SpacePerServiceInstance
      deployer:
        cloudfoundry:
          api-host: api.cf.example.org
          default-org: my-broker-org
          default-space: development

WHEN a service instance is created
THEN the a backing app is deployed with the following properties  (where [SI GUID] is the GUID assigned by the platform to the created service instance):

org: my-broker-org
space: [SI GUID]
app name: my-app
app route host: my-app-[SI GUID]

There are a few issues with the implementation, so I'm re-opening this issue.

On update-service, the update needs to know about the SpacePerServiceInstance target to it can re-deploy apps to the proper space, but it shouldn't try to create the space.
Deleting the space immediately before pushing an app, and deleting the space immediately after deleting an app, won't work when more than one application is configured to back a single service instance.


Lazy loading components without Route

This is not a real seed issue, but more of a help question.
I was using DynamicComponentLoader to lazy load components into my app, without ng2 Route. Then at some RC, when DynamicComponentLoader got deprecated I updated the code to use ComponentResolver.
That has been deprecated since RC5, and I've been searching for a way to do what I need, now with 2.0.0. (current docs have no coverage on this topic)
I presumed I'd need to use NgModules for the dynamically loaded components and I found SystemJsNgModuleLoader, which works fine. I loads the module and its components, as I can see on the browser's network tab.
But I am struggling to find the next steps to get the loaded module activated/injected, and the main component in that module as well.
SystemJsNgModuleLoader loads the module and gives me its NgModuleFactory and I can then use factory.create() to get me a NgModuleRef. Do I need to do anything else to get the loaded ngModule up and active?
How do I inject the module's main component?
I tried to use System.import(comp) (which is what I was using before), and that too works fine and gives me what I believed is a provider, but I could not find a way to inject that into my app.
Of course, this being brand new functionality, there is only old stuff on google/stackoverflow/etc.
I'll keep on digging and will post a solution I hope.
But if you can chime in and give me some pointers, that would be a great help.
thanks anyway,
julio
ps: sorry to use this venue to ask for help, but I could not find a better place or a better community to talk to

This is how you implement dynamically loaded components. It's updated: https://github.com/laco0416/angular2-component-outlet
Not even that hard.

use ComponentFactoryResolver instead ComponentResolver.. u may reference http://stackoverflow.com/questions/39580484/typescript-error-ts2339-on-componentref to load components dynamicaly ...  this works with latest version

@i7326 yes, you do have to use ComponentFactoryResolver to inject components dynamically. But that is not sufficient if the component is loaded dynamically in runtime. The Component type is not known ahead of time.
@OogieBoogieInJSON pointer does solve the problem. You have to use Compiler. compileModuleAndAllComponentsAsync() to compile a dynamically loaded ngModule and get access to its component factories. In my case I use SystemJsNgModuleLoader.load() to load modules, and embedded components, on the fly. The missing step was the compiler.
Here is what I am using in case this helps someone else, and it works like a charm:
    constructor(
                private viewref: ViewContainerRef ,
               private resolver: ComponentFactoryResolver,
               private loader:SystemJsNgModuleLoader,
                private compiler:Compiler)  {}

   openWebApp(menu) {
                this.loader.load(menu.modulePath)  // load the module and its components
                .then ((modFac) => {
                    // the missing step, need to use Compiler to resolve the module's embedded components
                    this.compiler.compileModuleAndAllComponentsAsync<any>(modFac.moduleType)
                        .then((factory) => {
                            let cmpFactory: any;
                            // now look for the module's main component so we can instantiate it
                            for (let i = factory.componentFactories.length - 1; i >= 0; i--) {
                                if (factory.componentFactories[i].componentType.name === menu.componentName) {
                                    cmpFactory = factory.componentFactories[i];
                                }
                            }
                            return cmpFactory;
                            })
                        .then(cmpFactory => {
                            // need to instantiate the Module so we can use it as the provider for the new component
                            let modRef = modFac.create(this.viewref.parentInjector);
                            let compRef = this.viewRef.createComponent(cmpFactory,0,modRef);
                            // done, now Module and main Component are known to NG2
                            ........
                        });
   }

thanks a lot for the help

Actually much better with this code snippet commented.

This looks pretty nice. What's your current setup? Do you have separate bundles for the individual modules that you want to load lazily or you load each individual component on demand?

@fourctv  -- I would be interested to understand more.  Can you elaborate on menu.modulepath referenced in your code above. What does that look like. I currently use lazy loading feature to dynamically create routes and execute them.  However, in the angular2-seed production build that ability is lost.  I can no longer use the dynamic route that i generate.
I have been doing the following:
Build an array of lazy routes, like this example:
{path: 'application', loadChildren: './app/core/application/application.module#ApplicationModule'}
Then I use resetConfig to define those routes:
let routerConfig = this.router.config; routerConfig.unshift(<Route>dynRoutesArray); this.router.resetConfig(routerConfig);
This works perfectly well in DEV build but fails in PROD build as a result of bundling, minification (I believe).   Ultimately I need to be able to dynamically load and execute routes.  Looking for the best way to do this in PROD and DEV.

@mgechev the idea is to have one bundle per module, so all its components get loaded, when the module loads. At this point I see no reason (yet?) to lazy load components individually.
Still in the todo list is a way to optimize bundles to avoid reloading components that are shared among modules. Of course some of the shared components that are part of the main 'framework' get loaded with index, but there are always other components that end up being used by multiple components on large app. And I'll have to address that at some point.
Any ideas are welcome.

@vijosoco -- as I mentioned above, in my case I am not using routing at all, or better, I do  not use angular routes, I do it my own way.
FYI, menu entries look something like:
        {
            modulePath: 'app/components/userRating/',
            moduleFile: 'userRatingModule.js',
            moduleName: 'UserRatingModule',
            componentName: 'UserRating',
            roles: ['Viewer', 'Admin'],
            hideMenu: false,
            title: 'User Rating'
        },

@fourctv yes, I agree that it's the optimal case.

This is just a suggestion at this point but did you try to achieve the same behavior with webpack instead of systemJS ? I believe you can create a Webpack bundle per module then load your bundles on demand. It would theoretically also work using ng2 route.

Closing this issue. We can keep the discussion here.

This works
{
path: 'account',
loadChildren:'./app/account/account.module#AccountModule'
}

lazyloading fails in production

@gomesNazareth in production you have to provide separate bundles. You can configure them and create them by using SystemJS builder. At this point I haven't spend much time researching how this can be implemented in the seed. I only did some basic testing in the "lazy" branch of the seed. The production build there doesn't work yet but it's in the right direction. Let me know how your experiment goes.

@gomesNazareth have a look here: https://youtu.be/QLns6s02O48?t=6m27s

Thanks mgechev and TheDonDope for the help . I used the seed from the lazy branch .After some modifications to the seed.config and the routes lazy loading is working  now for production.

Yes, I fixed the production build today. AoT still doesn't work, unfortunately.

@mgechev I having an issues with the directory and file paths in production for windows machine. The production builds but the file path for main.js is wrong in app.js . Below is the screen shot . Can you help me with this ?

Same error here (systemjs unexpected token <)

Try the "lazy" branch. It implements lazy loading and supports AoT.

I'm already using the lazy loading branch. It doesn't work either.

With custom setup or a clean clone? It shows a very basic implementation of lazy-loading behavior so for your custom setup it most likely will not work. I am using it for a big project where the module bundling strategy is much more complicated and covers much more cover cases compared to what we have in the lazy branch here.

No, I have built a clean clone from the lazy branch.

I have used the lazy loading  seed for  my project.It worked fine. you need  to specify the modules in the seed.config so that production build can find them. And check your  imports in alll  your components. I had an issue  with rxjs imports. how ever  there is still a path issue on windows  os

Hi, is there a way to do this using Webpack?
I'm using,
angular-cli: 1.0.0-beta.21
node: 6.9.1
os: win32 x64

@angular/*: 2.4.3
@angular/router: 3.4.3

And if I use above code block in a Webpack project, following error is shown in compile time,
Argument of type 'NgModuleRef<any>' is not assignable to parameter of type 'Injector'.
  Property 'get' is missing in type 'NgModuleRef<any>'.

and when I try to load a module manually following error comes up in browser,
EXCEPTION: Uncaught (in promise): Error: Cannot find module 'app/+profile/summary/summary.module'.
Error: Cannot find module 'app/+profile/summary/summary.module'.

@charitharumapperuma I recommend you take a look at this : https://github.com/meligy/routing-angular-cli

@ruffiem I took a look at the project you suggested. Seems like it is similar to router based lazy loading. In my case I need a mechanism to load modules on demand within the same route.

any progress on this? i'm having the same error as  @gomesNazareth

@fourctv This  method worked. But let's say you've dynamically loaded a module that has two components, how to navigate from component 1 to component 2 ?
Please look here for more details:
https://stackoverflow.com/questions/47868321/routing-between-components-inside-a-dynamically-loaded-module

@fourctv @vijosoco I am currently facing the same issue with the path to my dynamic module, but I am getting "Error: Uncaught (in promise): Error: Cannot find module '././external/external.module#ExternalModule'." So my question is, am I missing another step? Can this work at all with .ts files or do I have to bundle the module somehow before?
Thank you for your help!


Rewayat Ar / Kol novels doesn't working

Source information
Rewayat Ar / Kol novels
Steps to reproduce
.
Expected behavior
Open
Actual behavior
No results found
LNReader version
1.1.7
Android version
10
Other details
It's says "no results found"
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 1.1.6.
[X] I have updated all installed extensions.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

Duplicate of #118


User installed assyst

What would you like to see added to Assyst?
Since assyst already has slash commands i think it would be pretty cool to add those as user installed commands as well
Additional context
Below is a carefully crafted recreation of what that would look like in practice

Library support is missing for now, but can tackle this when it's added. Will also need to refactor some commands not available in DMs or private channels to make sure that they also respect these conditions with user installed apps.

Prelim version of this should be working now.


Renaming Mimir to Local

as per https://github.com/slamdata/slamdata/pull/2212 renaming Mimir to Local

I don't think we need to change anything here, it's only the label in the dropdown in the frontend that should change.

But why have the disconnect between code and domain?

@garyb thought it would be nice to have one name used through out rather than customers use local and we use mimir.

@kRITZCREEK there's always going to be a mismatch somewhere, since it's still Mimir everywhere we interact with Quasar itself :wink:

Oh I see. So we're going to continue calling it mimir everywhere but in the UI? That's a little confusing... But thanks for the clarification!

why not ask quasar folk to change it to Local so we have it through out?

what is the consensus then we just renaming it in the dropdown or going through out?

I think it's just in the dropdown

@kRITZCREEK I don't know, but if we want this to work with Quasar as it stands the mount type is called "mimir" and I haven't seen anything to suggest it'll be renamed? If that's changing too, then yeah it definitely makes sense to update the naming internally.
@Cmdv that's talking about the name of the mount in the VFS, like there'll be a /local/... mounted automatically.

@garyb well I linked above where it was agreed for a rename of local on frontend but haven't a clue about the VFS or anywhere else. It's all pretty vague and doesn't seem set in stone. I'll close this then just rename in drop down until there is more clarity on what is actually happening 😄

@Cmdv what I'm saying is that reply isn't about renaming anything, it's saying "when we add the prebaked mount, call it /local" :wink:
The VFS means the filesystem you see via the frontend, as opposed to the actual (physical) filesystem.

but it's also going to be called local in the dropdown so kind of confused, there should have been more clarity that's all I'm saying 😉


Create Profile for ... Saiki Daniel Comboni

Name
Saki Daniel Comboni
Profile Image

Country
South sudan
Region
West Nile
Organisation
YEF
Languages
English (very Good), Madi (very good)
Skill 1
Organizational Development
Qualifications for Skill 1
Certificate in Business and management
Certificate in Administrative law
Diploma in Accountancy
Bachelor Degree in Business Administration majoring in Finance
co-founder of Youth Empowerment Foundation
A chief accounting officer at Youth Empowerment Foundation
Skill 2
No response
Qualifications for Skill 2
No response
Skill 3
No response
Qualifications for Skill 3
No response
Skill 4
No response
Qualifications for Skill 4
No response
describe yourself
My name is saki Daniel comboni,a south sudanese residing in Adjumani district in Uganda.I am one of the founders of The Youth Empowerment Foundation which started in 2017 working as a financial administrative Executive.I posses a bachelor's in business and management majoring in finance, diploma in accountancy,and acertificate in administrative law leading to a substantial contribution to my management and business skills such as team work, administration and financial management.
The foundation is a platform in place that supports youth difficulties as well as building up their skills,we intend to create a community with the proficiency of business, technology and media which help them commence their careers.
E-Mail
<EMAIL_ADDRESS>Phone
+256780877885
WhatsApp
+256780877885
Website
No response
Telegram
Shakiss
GitHub
No response
LinkedIn
https://. LinkedIn.com/in/saki-daniel-comboni-31a627179
No response
Twitter
https://twitter.com/shakiss 01
No response
Facebook
https://.facebook.com/profile.php?I'd=100007106350469
No response
Instagram
https://. instagram.com/shakiss 01
No response
Mastodon
No response
WikiFab
No response
Other
No response

Self description and links your work if any.

Updated the description and corrected name spelling.

will be uploaded shortly


chore(master): release 0.1.7

:robot: I have created a release beep boop
0.1.7 (2024-09-10)
Bug Fixes

processing of workflow outputs (#30) (98a88c6)
refactor processor to facilitate progress bar (#22) (97bae20)
release data output (#31) (4650882)
use version computation (#29) (4115987)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.1.7
:sunflower:


[File Explorer] OneDrive SVG fix

Summary of the Pull Request
What is this about:
When disk access is really slow, or more commonly, when .svg files are being accessed using e.g. OneDrive, the reading and processing of the file was being done on the Explorer UI thread, which caused the window to be unresponsive. This PR fixes that issue. See #8152
What is include in the PR:
This PR moves the code which reads the file and checks if it is valid outside the UI loop, ensuring the UI stays responsive.
How does someone test / validate:

Put a large .svg file in your OneDrive folder, for example, this one: https://upload.wikimedia.org/wikipedia/commons/6/63/A_large_blank_world_map_with_oceans_marked_in_blue.svg
In OneDrive settings, set download speed limit to 400 KB/s

Before this PR, the UI will be unresponsive for about 10 seconds (the time it takes to download the file).
With this PR, the image will appear after 10 seconds but in the meantime, the UI will be responsive.
Remember that you must test this PR by building the installer. Also I recommend manually terminating explorer.exe to ensure the proper version of PT File Explorer is being tested.
Quality Checklist

[x] Linked issue: #8152
[x] Communication: I've discussed this with core contributors in the issue.
[ ] Tests: Added/updated and all pass
[ ] Installer: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Docs: Added/ updated
[ ] Binaries: Any new files are added to WXS / YML

[x] No new binaries
[ ] YML for signing for new binaries
[ ] WXS for installer for new binaries

Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.

is there anyway we can add a test against this scenario?

is there anyway we can add a test against this scenario?

@crutkas
a unit test would require to implement a mock for Explorer and OneDrive, something that would take weeks if not months and not really mock the real scenario. This type of issues require integration tests with the "real thing".

@crutkas
a unit test would require to implement a mock for Explorer and OneDrive, something that would take weeks if not months and not really mock the real scenario. This type of issues require integration tests with the "real thing".


Add package to Debian

I was wondering if this can be added to the Debian distribution so that everyone can just 'apt install' zola.
The official guidelines for adding a package are here: https://www.debian.org/doc/manuals/distribute-deb/distribute-deb.html#adding-packages-to-debian
Has this already been attempted?

That would be awesome

I somehow missed this issue. Efforts have been started a while ago to officially package zola but there are still quite a few upstream dependencies (crates) missing: https://salsa.debian.org/debian/zola


[SPARK-44079][SQL][3.4] Fix ArrayIndexOutOfBoundsException when parse array as struct using PERMISSIVE mode with corrupt record

What changes were proposed in this pull request?
cherry pick #41662 , fix  parse array as struct bug on branch 3.4
Why are the changes needed?
Fix the bug when parse array as struct using PERMISSIVE mode with corrupt record
Does this PR introduce any user-facing change?
No
How was this patch tested?
add new test.

cc @MaxGekk

+1, LGTM. Merging to 3.4.
Thank you, @Hisoka-X and @yaooqinn for review.

Thanks @MaxGekk @yaooqinn


Write unit testing

The unit testing hasn't been set for this project due to moving to Quran Annotation backend


[UI Shell SideNav] The hamburger menu icon should get replaced with a close icon when its open

What package is this for?

[x] React

Describe the bug
In the UI Shell SideNav component when I click on the Hamburger menu and the sidenav expanded the "Hamburger" icon should replaced to a "X" or "Close" icon as you can see in the vanilla Carbon storybook (hamburger menu only visible on small screen width):
https://react.carbondesignsystem.com/?path=/story/components-ui-shell--header-base-w-navigation
To Reproduce
Steps to reproduce the behavior:

Go to UI Shell SideNav component storybook page
Click on "Hamburger" icon
When the sidenav expanded the "Hamburger" icon didn't replaced to a "Close" icon

Expected behavior
The hamburger menu icon should get replaced with a close icon when its in open state.
Environment/versions:

all env/version

I believe @lukefirth and @dianatran18 have determined this item to be invalid/working as designed.


Swift 6

Could you update the library to make it compatible with Swift 6

You just need to update webim sdk

Fixed in version 1.2.5.


Error destroying when closing dialog or navigating in Firefox (47.0.1)

To reproduce
Put the editor on a dialog
Close the dialog without editing any of the text
An error occurs in in the tinyInstance.remove() calls
Put the editor on a view
Navigate away from the view without making any changes
An error occurs in the tinyInstance.remove() calls
The code in the directive is:
scope.$on('$destroy', function () {
ensureInstance();
              if (tinyInstance) {
                  **tinyInstance.remove();** /// <-- This call errors
                  tinyInstance = null;
              }
          });

          function ensureInstance() {
              if (!tinyInstance) {
                  tinyInstance = tinymce.get(attrs.id);
              }
          }

Stack trace:
.serialize@http://localhost:43548/Scripts/vendor/tinymce.min.js:5:19133
A.prototype.getContent@http://localhost:43548/Scripts/vendor/tinymce.min.js:11:19898
A.prototype.save@http://localhost:43548/Scripts/vendor/tinymce.min.js:11:18533
A.prototype.remove@http://localhost:43548/Scripts/vendor/tinymce.min.js:11:21799
.link/<@http://localhost:43548/Scripts/angular-ui/tinymce.js:194:23
$RootScopeProvider/this.$get</Scope.prototype.$broadcast@http://localhost:43548/Scripts/vendor/angular.js:17767:15
$RootScopeProvider/this.$get</Scope.prototype.$destroy@http://localhost:43548/Scripts/vendor/angular.js:17385:9
afterAnimating@http://localhost:43548/Scripts/angular-ui/ui-bootstrap-tpls.js:3826:11
processQueue@http://localhost:43548/Scripts/vendor/angular.js:16170:28
scheduleProcessQueue/<@http://localhost:43548/Scripts/vendor/angular.js:16186:27
$RootScopeProvider/this.$get</Scope.prototype.$eval@http://localhost:43548/Scripts/vendor/angular.js:17444:16
$RootScopeProvider/this.$get</Scope.prototype.$digest@http://localhost:43548/Scripts/vendor/angular.js:17257:15
$RootScopeProvider/this.$get</Scope.prototype.$evalAsync/<@http://localhost:43548/Scripts/vendor/angular.js:17483:15
completeOutstandingRequest@http://localhost:43548/Scripts/vendor/angular.js:5955:7
Browser/self.defer/timeoutId<@http://localhost:43548/Scripts/vendor/angular.js:6234:7

I am getting the same error under the same circumstances as @johnwpowell, however I only get this exception thrown w/ FireFox 47.x
I believe this thread is related. [https://github.com/tinymce/tinymce/issues/794]

Could you please post a plunker reproducing the issue. From @calbear47's comment it might be an issue with TinyMCE core, and not this library. I could take a closer look if you put up a plunker.

I had the same issue and updating tinymce and ui-tinymce with the latest versions resolved everything.


[▔WATCH .SEX. VIDEOS▔] 18+ XXX SEX Baltasar Engonga Wife Viral sex Video Original Trending On Social Media X Twitter

21 seconds ago
L𝚎aked Video Balthazar Baltasar Ebang Engonga Original Video Viral Video L𝚎aked on X Twitter Telegram
Balthazar Baltasar Ebang Engonga Dark Video Female Balthazar Baltasar Ebang Engonga Dark Video Link Viral On Social Media X TikTok Trending Now
Balthazar Baltasar Ebang Engonga Original Video video took the internet by storm and amazed viewers on various social media platforms. Balthazar Baltasar Ebang Engonga , a young and talented digital creator, recently became famous thanks to this interesting video.
L𝚎aked Video Balthazar Baltasar Ebang Engonga Original Video Viral Video L𝚎aked on X Twitter
Balthazar Baltasar Ebang Engonga Original Video video oficial twitter
L𝚎aked Video Balthazar Baltasar Ebang Engonga Original Video Viral Video L𝚎aked on X Twitter.

fghfgh

fsds


.NET 9 version expected release date

When will .NET 9 version of this package be released? I saw in version policy that it's expected to be released at the same time as .NET 9 which is already available. In README it says that it's compatible with .NET 9, but I get an error when trying to use 9.x versions because this package requires 8.x versions of Microsoft's packages.

Thank you for this library, it's awesome for multitenant applications.

Hi, it’ll be this evening once I get home from work.

Awesome, thank you a lot!


Fix typo in 02RL Jupyter Notebook

I modified the comment under "Decay Epsilon with Generator" in the 02RL notebook from:
"""Convenient generator function to generate and decy epsilon."""
to:
"""Convenient generator function to generate and decay epsilon."""
I made the same modification in the 02RL file under the solution folder.

Thank you!


Doesn't support .media ?

This gem is not support .media domain.

It's there.
https://github.com/weppos/publicsuffix-ruby/blob/master/data/definitions.txt#L8816-L8817
Please make sure you are using the most recent version.


JavaScript parser

This is a JavaScript parser for Subtext with streaming capability. Since I am using something similar for my own notes app, I thought I might as well provide a parser for this repo.
It uses the Web Streams API which means it can be used with compatible browsers and server runtimes like Node.js and Deno. The parser does not have any dependency.
I have included the example from the Rust parser and some tests from the Rust test suite.
You can run the example via npm run example and run tests via npm run test.
Feel free to suggest improvements or close the request if it does not match your requirements. If you prefer TypeScript, I could also make the adjustments.

Closing this as the PR is stale and I'm not fond of this non-type-safe implementation anymore. I might try my hand at an updated TypeScript parser when the spec or the Rust implementation have become more stable.


Ease support of remote environments

First of all, I totally admire the the work done in this project. This is the 3rd VS Code extension I'm trying today and so far seems quite promising, however, I need to give more context.
I'm currently trying to being using code-server in my development routine, since I was long yearning for a nice in-browser IDE that can be deployed on my in-office PC. The nature of my development environment happens to be that the code in the current workspace/project gets deployed onto remote machine(available via SSH) that contains all of the necessary dependencies, required for it to be successfully executed. Keeping the dependencies or trying to run them locally in a container is 99% unfeasible due to the architecture.
I however would fancy very much to have auto-completion and insight into all of the available code(the project and its 3rd party dependencies) on the office PC I run code-server from.
Due to glorious licensing issues, only VS Code currently has Remote Extensions support, so I can't utilize that for your extension.
I saw the discussion in #33 regarding executing Perl in Docker and I tried to do the same with SSH but failed since Perl scripts that make bulk of the actual work are hidden as assets of this add-on and path to them can't be mangled with via the configuration.
Thus, I propose those few following steps to improve the situation:

[ ] Isolate Perl code so that it can be built/delivered separately if required
[ ] Ensure that LSP Server code depends on Perl code only by execution and not by sharing files(this translates harder via stuff such as SSH)
[ ] Allow parametrize the path to the Perl code, instead of hard-coded path to the assets
[ ] Publish actual version of the extension to https://open-vsx.org/extension/bscan/perlnavigator so that other projects based off VS Code can have easier time accessing it

I assume that after this hopefully simple clean up, it would barely matter whether the environment is a container, a remote machine or something else, as long as execution of Perl code can be delegated there.
So far I've tried https://github.com/richterger/Perl-LanguageServer which has somewhat poor auto-completion and https://github.com/FractalBoy/perl-language-server which unexpectedly ceases to function over SSH, possibly because an issue similar to https://github.com/FractalBoy/perl-language-server/issues/103 or not. So my hopes for "the third time is a charm" case are quite high =)

This is a good idea, and would also help with Docker and WSL support (for people who aren't using the respective Remote Extensions). I believe the easiest way to support this would be adding the Perl code to CPAN so that it can be installed independently. Then there could be a configuration setting to use the installed version instead of the extension bundled version. Would that type of solution work for code-server?

@bscan I feel that for CPAN the code hierarchy needs tidying up(and using something like ExtUtils::MakeMaker or such https://wiki.archlinux.org/title/Perl_package_guidelines#ExtUtils::MakeMaker ), as it now more of a collection of hacky scripts loosely tied up together =)
But sure, that's one way to go about it. It also would highlight the dependencies for this part of the code, which I think are quite minimal but still =) I'd say generally anything works as long as it gets split up from the JS/IDE part, since this extension isn't about supporting Node.js completion or something, so ideally only Perl part needs to be portable.

@bscan I have given it some more thought and I think there's a 5th step that would be next to required for such advanced scenarios: customizable mapping of paths. In https://github.com/richterger/Perl-LanguageServer this is already supported but I feel with extra inspiration from https://github.com/FractalBoy/perl-language-server where configuration allows to reference workspace directory, this will help with "Go to definition" functionality for the scripting language.
Also, regarding note on a filesystem, stuff like configuration files for perlcritic and such might be better suited to be passed as content rather than a path to the Perl code.
Does these improvements still sound sane enough? =)

as it now more of a collection of hacky scripts loosely tied up together =)
Haha, pretty accurate. The overall design of the Navigator is certainly fairly unusual. The reason it is node.js based is for portability reasons and ease of install. For most uses, you can simply install from the Marketplace and it will just work. No need to do any cpan installs or use a package manager. Similarly, due to the bundling, the perl code automatically stays updated with new releases, and there's no opportunity for mismatch between the perl code and the vscode extension. Being in node.js also allows me to leverage the Microsoft LSP libraries, which is also nice for compatibility and stability.

It also would highlight the dependencies for this part of the code, which I think are quite minimal but still =)

All dependencies are currently bundled in the extension, which enables the Navigator to work against a bare bones install of Perl anywhere as old as version 5.8. The two bundled dependencies are Class::Inspector and Devel::Symdump.
For the remote running, I'm surprised code-server doesn't have a more comprehensive solution for dealing with these things. For the vscode remote extensions, all extensions simply work without any modification. Otherwise, it seems like all extension developers would need to add the workspace mappings and similar.
Overall yes, it makes sense though. WSL has a similar mapping need where a file may be /mnt/c/foo.pl on the linux side and would map to c:\foo.pl when accessing files from the Windows side.

I just gave code-server a try and it worked very well for me out of the box. The OpenVSX version of Perl Navigator also worked instantly without any configuration at all (image below). Overall I'm very impressed with code-server, and I'll make sure to upload new versions of the Navigator to open-vsx to support it (and the other open source vscode variants). Although now I'm also re-reading your initial request and trying to understand what you are trying to do. If you have a remote development environment, why not run code-server directly on that environment? I believe that's the core purpose of code-server to begin with.

@bscan Yeah, I probably should rephrase the description of my issue more clearly. It is true that your extension works fine in code-server, I just highlighted that I want to use code-server instead of the all-power with proprietary code support VS Code since I would like to have in-browser IDE interface, I just find it convenient. It really barely matters whether I use code-server or Theia(which unfortunately lags behind code-server in my opinion) or any other fork pretty much since Remote Extensions won't(at least legally) work on any of the forks to possibly(I haven't really tried it much) give me the edge I need.
And thus, the real struggle is that I want/need to have IDE with completion and stuff on one machine(where Git and currently open workspace is) and language server or whatever backs it up on another(where final artifact is deployed, yielding the same code just by a different path 95% of the time), since I find that it's the advantage of the technology - language server can be deployed somewhere else than the client in order to provide most benefit.
It would be a real hustle to use code-server or anything else where language server is deployed for one reason or another but at the very least in the fact that for Perl support it is enough to have only Perl code there since it will work wherever the interpreter is ported to and not whether Node.js and the whole enormous tree of dependencies of the IDE is. For example, code-server is currently bundled only for amd64 and aarch64 architectures, and riscv64gc is something of a rising star but where one could run Perl code and even language server, running a whole IDE backend would be more on the suicidal side =)
I'd say it's pretty much the same deal with containers, especially if one targets K8s, where it would be a real hustle to put whole IDE in there in place of just a few extra Perl dependencies.
Hope I get my point across.
In  that maybe somewhat extra complicated but really "enterprise" setup, https://github.com/FractalBoy/perl-language-server currently mostly just works, if only it had path mapping =) But I'm really interested in trying out what you've done here once such configuration will be possible


Support ruff 0.5.0 in CI

Support ruff 0.5.0 in CI and revert:

#7007

Fix #7008.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


OptiX support

Let's investigate if it's possible to add OptiX denoiser.

I just tried to render with OptiX inside Softimage and it just works! I just added denoise_optix_filter to the available filters and done. But it doesn't update between every AA pass, only when the image is done after the final AA level.
I also tried to disable all "Progressive Refinement" levels and put enable_progressive_render true in user options instead to enable REAL progressive refinement and that feature just works as well. But OptiX still doesn't show any image until rendering is done. So we just need to find out how we can get SItoA to update the image between each pass.
That and put all settings in the UI.
I will probably look at this tomorrow.

Hmm.. I'm scratching my head on this one... Would be really nice to see a reference implementation of a OptiX display driver that's updating on each IPR.
@sjannuz How are you doing it in ARV in Maya? Or are all plugins using a separate AOV for the denoising that only updates after image is completely done or on each IPR?

So I added initial support for OptiX in #45
It works really well but it lacks updating on every IPR / iteration of Progressive right now.

Created a new ticket for the OptiX denoising in display driver #48


[FEATURE REQUEST] Support Laravel 7

For now, laravel-love do not support laravel >= 7.x

Yes. I'm gonna add its support on this weekend. Feel free to add pull request if you want  to make it happen faster!

Added Laravel 7.x support in Laravel Love v8.3.1


Enhanced Rate Us Page

Hello Project Admin
I Enhanced Rate Us Page - Solved #324
Kindly Please go through it @hustlerZzZ
https://github.com/VanshKing30/FoodiesWeb/assets/161804629/b4505a12-c808-40b5-98d6-efce8cb02dbb

Great work

Thank You :)


Internal error IllegalArgumentException

When we are using Java Language Server sometimes we are getting this issue reported
To Our Error Tracking Application we are getting an Error like
Internal Error
In Logs we are getting the below code,
Java Language Client-front:   Message: Internal error.
  Code: -32603
java.util.concurrent.CompletionException: java.lang.IllegalArgumentException: Invalid identifier

Why are these errors being reported?

This repository is about the general LSP library implementations not about a specific language server. Please report the error against https://github.com/Microsoft/vscode-java-pack


⚠ ClamAV has degraded performance

In cf4d886, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 145 ms

Resolved: ClamAV performance has improved in 3e88eda.


Simplify and refactor IncompatibleClassChangeError

Simple refactor that makes the code more cleaner/understandable

Closing PR because I missed this https://github.com/apache/incubator-pekko/pull/702/files#r1350597088


add weight in tree model output

fix #2037

@guolinke I can update plotting part if you don't mind.
https://github.com/microsoft/LightGBM/blob/611cf5d414a8273dfdd261651e2f127322a3db89/python-package/lightgbm/plotting.py#L392-L396

@StrikerRUS sure, thanks very much!

@guolinke Just updated plotting module in Python in the latest commit.

ping @jameslamb and @Laurae2 for R-package updates
https://github.com/microsoft/LightGBM/blob/master/R-package/R/lgb.model.dt.tree.R
https://github.com/microsoft/LightGBM/blob/master/R-package/R/lgb.interprete.R

@StrikerRUS could this PR merge first? then a new PR for R package could be proposed.

@guolinke Yeah, sure!

Created #2281 to track the R work, agree with the decision that was made to merge this and come back to R.


Memory Allocation overflow on abi.decode()

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (b44b045 2023-02-21T00:22:41.521901Z)
What command(s) is the bug in?
forge test --optimize --vv
Operating System
macOS (Apple Silicon)
Describe the bug
I’m getting the error [FAIL. Reason: Memory allocation overflow] on one of my tests.
it happens when I run abi.decode() like so:
// Structre of `Indexed Strategy`
struct IndexedStrategy {
  uint8 i;
  bytes b;
};

...

// Actual code that fails
(
    address v,
    uint256 id,
    Choice choice,
    IndexedStrategy[] memory uvs,
    string memory reason
) = abi.decode(data, (address, uint256, Choice, IndexedStrategy[], string));

This code works just fine if I remove reason. It also works just fine if I remove uvs and keep reason.
I get the same error if I interchange reason and put it between id and choice (I thought maybe it had to do with two dynamic args being next to each other).

this is an evm panic.
can you try after increasing the memory_limit
forge config | grep memory
memory_limit = 33554432

not sure if that's exposed in cli, if not we should

this is an evm panic ref https://soliditydeveloper.com/solidity-0.8 0x41 can you try after increasing the memory_limit
forge config | grep memory
memory_limit = 33554432

not sure if that's exposed in cli, if not we should

Cheers. Indeed
➜  tmp git:(main) ✗ forge config | rg memory
memory_limit = 33554432

Haven't found a way to increase the memory limit via CLI.
Also I'm not sure why this would trigger 0x41: my IndexedStrategy array holds 1 element and reason is set to "".. 🤔

unfamiliar with the internals but Memory allocation overflow is the mapped error for the evm panic with 0x41

can you try with something ridiculous like 1GB?
@rakita Under what circumstances is the memory limitation in the evm actually violated?

memory_limit =<PHONE_NUMBER> still fails.
I wonder if memory_limit is actually taken into account because I have no way of knowing whether the memory limit actually is 1GB or the default one

hmm, perhaps this is actually unrelated to the revm env setting @rakita?

can you try with something ridiculous like 1GB?
@rakita Under what circumstances is the memory limit in the evm actually violated?

Do you mean this: https://github.com/bluealloy/revm/blob/main/crates/primitives/Cargo.toml#L60
It is memory inside Interpreter, when there is for example MSTORE that wants to write to the memory location with offset of 20gb, this would trigger.

this error is decoded from a revert/panic here
https://github.com/mattsse/foundry/blob/13c1cf724a5657a7c7005560f773ffd9a59d8962/evm/src/decode.rs#L117-L118
for

// allocating too much memory or creating too large array

is this unrelated to the memory_limit setting?

Nvm.. this error actually gets thrown when you try to decode something invalid (in my case, I forgot to add the last argument when ENCODING, so decoding was failing).
Would have expected another error to pop, not a weird memory overflow error but.. such is life.
sorry for wasting your time :(

nice!
good to know, thanks for sharing


Add Tailwind styled scaffold templates

Summary
This PR adds Tailwind styled scaffold templates when this gem is installed. These styles were sanctioned by Adam and the Tailwind team. Some examples:

TODO
[✓]  Make new styles based on Adam Wathan suggestions
[✓]  Conform template partials to Rails 7 main branch
[✓]  Make it work with Rails 6
Additional information
It would great if we had the option of using Tailwinds @apply directive. This would be useful when extracting components like buttons, inputs etc. But since the css comes precompiled we did what we could.
Maybe something to work on in the future?
Co-authored-by: Dino Marić<EMAIL_ADDRESS>

Resolves #23

Digging this! Will look closer in a bit. Thanks for working on it!

We have to make this match the new style in rails/main where the _post.html.erb partial is used on the index. That's how it matches up to work out of the box with Turbo. Which means we can't use a table on the index.
See the templates in https://github.com/rails/rails/tree/main/railties/lib/rails/generators/erb/scaffold/templates

@dhh no problem.
That was the one of the points we debated internally, main reason why we choose table is that Adam sent us mockups with the table and we didn't wan't to deviate too much from his mockups.
But, yeah I agree that index without the table is going to be easier especially for the scaffolds where the table columns are dynamic and it is hard to style the table properly.
Anyways, we'll match with the Rails 7 changes 👍🏻

@dhh I think this should be ready now, and it should also work with Rails 6. Take a 👀 when you have some time.

Finally got a chance to check this out. Looking very good! Only thing I'd say is that we could use some padding. So headings and buttons aren't slammed against the edges of the browser:

@dhh re paddings that is strange! Only way I could see that happening is if you don't have a main wrapper(https://github.com/rails/tailwindcss-rails/pull/71/files#diff-82d31adf98ad40bfa67ed05464d36790777703adead66a2478d97320061f136cR9)
Could you push sample app you are showing on the Github so we can double check 🙏
For the reference here how it looks like on the app I've just created

I had not run the installer correctly. You're right. It looks great!! This is really neat.

@dixpac Thanks for your work on this, I’m finally going to get rid of rails_admin gem (with heaps of dependent gems) and scaffold out the rest of my models. Great work 👍 I appreciate it.

@BakiVernes I absolutely love this, I was working on a similar thing :) Have you considered applying the tailwind classes in css, like daisy-ui does?

Thank you @lafeber! We have considered extracting classes, but since this gem comes with a precompiled css file with all of tailwinds utility classes inside (so no preprocessing done) it's gonna be a challenge. But we will definitely take a shot at it :)

I'm still not sure what the best DRY approach is for Rails. Viewcomponents in combination with helper methods like def input_class ?

We have to make this match the new style in rails/main where the _post.html.erb partial is used on the index. That's how it matches up to work out of the box with Turbo. Which means we can't use a table on the index.
See the templates in https://github.com/rails/rails/tree/main/railties/lib/rails/generators/erb/scaffold/templates

I'm sorry if this is not the place for this comment:
@dhh I love Rails, among other things, because it enables me to do very fast functional prototypes. And part of that was having an index scaffold that I could instantly show to a client to display a list of items, and customize later. It was amazing and well known:
Rails automates scaffolding to make early coding more productive than ever before. (Ruby on Rails: Up and Running by Bruce Tate, Curt Hibbs)
Now, with Rails 7.0.3, if I wanted that, do I have to manually code another view? Or maybe there is some CSS that would allow me to show this new index like a table? I'm not UI expert, and with earlier Rails versions, I didn't needed to be.
I'm not the only one troubled with this:
https://www.reddit.com/r/rails/comments/pztx9g/scaffold_index_no_longer_generating_html_tables/
https://www.reddit.com/r/rails/comments/qypvnm/rails_new_scaffold_index/
https://stackoverflow.com/questions/71357307/no-table-view-after-crud-scaffolding
https://stackoverflow.com/questions/72402399/add-new-partial-to-rails-7-generate-scaffold
IMHO this change as it is, may be beneficial to some while detrimental to others. I feel like the small guy being left behind here.
I appreciate very much all the work you have done, @dhh along with all the Rails team.
Regards.

$ rails -v
Rails 7.1.3
rails new --css=tailwind rails-7-1-tailwind
cd rails-7-1-tailwind/
bin/rails g scaffold Post title:string description:text
bin/rails db:migrate
bin/rails s

@dixpac I'm curious what you did to obtain the output shown in your post. Granted this was likely several versions behind what I used here.
There are no browser console or Rails server errors indicating any issues with loading CSS. So is this is the expected stock output of Rails scaffolds in <IP_ADDRESS> with tailwindcss-rails 2.3.0?


COB Miscalculated at Profile Change After Meal

Issue:
For a scheduled profile change made with carbs on board, the COB will be re-calculated with the new CR but the old ISF until COB goes to zero.
For larger changes this means iAPS fails to adhere to the minimum carb absorption fallback set by the min_5m_carbimpact setting during changes to profile CR and ISF resulting in inaccurate carb absorption, higher COB and overdosing of insulin.
This issue occurs even when CSF (CR  ÷ ISF) is intentionally held constant to establish a constant minimum carb absorption across profile changes.
The easiest way to check this would be to log the sens variable on line 125 of oref/lib/determine-basal/cob.js
Steps when encountered issue:

min_5m_carbimpact = 26
Profile:
ISF = 205
CR = 15.4
Profile CSF (CR/ISF) = 13.3
Minimum carb absorption calculated at 1.95 g/5m (min_5m_carb Impact * CR / ISF)
83 meal carbs entered
188 minutes elapse with carb absorption fallback scenarios encountered (i.e flat BGs, deviations < min_5m_carbimpact)
COB = 10
COB decayed as expected with total absorption = 1.94g/5m
A scheduled profile change to CR and ISF enacted.
ISF = 105
CR = 8
Profile CSF (CR/ISF) intentionally held near constant =  13.3
Minimum carb absorption calculated at 1.98 g/5m
At next loop:
Expected COB = 8
Actual COB = 44
InsulinReq = 1.2
Microbolusing .4
All future loops decayed COB from this new baseline of 44
42… 40… 37…35… 31…27…25…23…21…19…17…15…13…11…8…6..4..2..0
Additional SMBs were later delivered due to the new COB resulting in a low several hours later

2 days later, for testing purposes, I staggered the ISF change and CR change by 30 minutes.
At the ISF change, COB did not change
At the CR change 30 minutes later, COB again increased substantially similar to the above

### Suspected Reason:
It seems that the new profile ISF is not being used in the carb impact calculation.
Expected COB Calculation Before Profile Change
Baseline Minimum Absorption: (Min_5m_carbimpact * CR / ISF):
26*15.4/205 =  1.95 g/5m
Number Loops: 188 minutes / 5 = 37.6
Minimum Carbs Absorbed = 73
COB = 83 - 73 = 10 <--- Aligns with actual
Expected COB Calculation at Profile Change
Baseline Minimum Absorption: (Min_5m_carbimpact * CR / ISF):
26*8/105 =  1.98 g/5m
Number Loops: 193 minutes / 5 = 38.6
Minimum Carbs Absorbed = 75
COB = 83 - 75 = 8. <----- Doesn't Occur
Suspected Actual COB Calculation at Profile Change
Baseline Minimum Absorption: (Min_5m_carbimpact * CR / OLD ISF):
26*8/205 =  1.01 g/5m <----- Less Than Fallback Minimum
Number Loops: 193 minutes / 5 = 38.6
Minimum Carbs Absorbed = 39
COB = 83 - 39 = 44 <----Actual Outcome
It’s not clear if iAPS is somehow causing this issue or if the issue is native to oref.  The DetectCarbAbsorption Function in oref(o) seems to use the ISF associated with the last BG data, not the current profile ISF.  Could this lead to an issue based on the data iAPS is passing to oref(o)?
Added Context:
Carb Absorption is retrospectively determined since last meal using CSF (CR ÷ ISF) and min_5m_carbimpact to set minimum fallback absorption.

IF | THEN |
-- | -- | --
CSF (CR ÷ ISF) > prior profile | > Min Fallback Absorption | COB drops
CSF (CR ÷ ISF) <  prior profile | < Min Fallback Absorption | COB increases
CSF (CR ÷ ISF) = prior profile | = Min Fallback Absorption | COB decreases slightly based only on the carb absorption calculated in last 5 mins. Impact of profile change should be null.

The magnitude of the difference between the old COB value and new COB value should vary based on extent of the magnitude of change to profile CSF change.

Changes to CR ÷ ISF resulting in a relatively larger CSF number can wipe out COB completely
Changes to CR ÷ ISF resulting in a relatively smaller CSF number can make COB increase significantly (i.e ghost carbs)
- If CSF is held constant neither should occur

Logs attached for both days issue encountered
drive-download-20231111T051607Z-001.zip

I tested this with a temp profile that changes ISF and CR via the slider at 180%.  The issue did not occur;  COB remained the same.  Not sure what the difference would be between a scheduled profile change and a temp profile change.

What’s your definition of a “scheduled profile change”?

I was referring to a change to settings at a given hour. For instance, at 8pm, ISF and CR are changed from the values set at 7pm.
It's been a while since I logged this.  The issue may still be present. Not sure, but it's not impacting me much so not a big concern.


document.write() no longer supported on mobile chrome

See this older update notice from Google. https://developers.google.com/web/updates/2016/08/removing-document-write
Note that we appear to use document.write() in our Nunaliit JS and this may cause issues on mobile and was discovered by one of our app developer candidates as being a problem for the webviews in the nunaliit_android project.

Notes from dev:
The project consists of a native Java part describing communication and data transfer from CouchDB and a hybrid Web-based part of the Cordova framework. The web part is responsible for displaying the JavaScript code generated by the Nulaliit framework. The web part uses configuration scripts with the “debug” suffix and without it the content seems to be a minified javascript. For example, nunaliit2-couch.js and nunaliit2-couch-debug.js. Looks like the debug version of the script prepares all declared scripts inside it and injects the result into the web form body with the help of the ‘document.write()’ command.
When debugging the Nunaliit-Android project in the Chrome Developers Tools we noticed the warnings about scripts being blocking. Those scripts were calling ‘document.write()’:
Looks like it was the reason for a WebView not being able to display content on Android. According to Google resources for Web Developers ‘document.write()’ usage impacts the performance of the page rendering and therefore Google blocked ‘document.write()’ in Chromium engine, which in fact is a core for Android WebView.

I have combined all the components for nunaliit2 and nunaliit2-couch into one compressed file: nunaliit2.js  Also, the build now creates two version of that file: a debug version (nunaliit2-debug.js) and a debug inline version (nunaliit2-debug-il.js). The latter might be useful for mobile apps.
The files nunaliit2-couch.js and nunaliit2-couch-debug.js are still produced but are empty. This is to not generate errors on legacy sites that still reference them.
Finally, the mobile libraries are still generated, but the debug version has been changed to inline. During Android app development, this is the file that should be loaded.


final update UGDG before submit

Pull Request Test Coverage Report for Build 341

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.15%

Totals

Change from base Build 336:
0.0%

Covered Lines:
2786

Relevant Lines:
3476

💛  - Coveralls


C++ code for DetectNet model inference outside Digits

Dear all,
Is anyone aware of a sample C++ code to perform inference on a DetectNet model trained using Digits.
I am aware of the the C++ codes provided for Jetson but these seem to produce quite different results from those in the Digits environment.

It sounds like the best course of action would be for you to investigate the discrepancies.

@gheinrich  this seems quite impossible due to poor documentation of Jetson C++ codes

This is open source software, you are welcome to look into the code and contribute better documentation.

@gheinrich I would if at least some algorithmic reference for the code was already available or the code writers were willing to provide such an explanation!

Thanks for the feedback. I will close this issue for now since this does not report an issue in DIGITS. Discussions are welcome on the DIGITS distribution list: https://groups.google.com/forum/#!forum/digits-users


JavaFX add-opens fiji.toml support

First of all, thank you for all your awesome work on jaunch! In my testing it works as expected/described!
I have several questions about JavaFX support as fiji migrates to jaunch and Java 11 and higher. I am not sure this will be the correct place for all of them, but I hope this is a good starting place.
The GUI for our collection of Fiji tools (Mars), uses JavaFX and depends on direct access to several JavaFX classes. Starting with Java 9, we now have the module system. I had to add the following lines to the fiji.toml for the Mars GUI to have the access needed to run:
'JAVA:9+|--add-opens=javafx.controls/com.sun.javafx.scene.control.inputmap=ALL-UNNAMED',
    'JAVA:9+|--add-opens=javafx.graphics/com.sun.javafx.scene.traversal=ALL-UNNAMED',
    'JAVA:9+|--add-opens=javafx.graphics/javafx.scene=ALL-UNNAMED',
    'JAVA:9+|--add-opens=java.base/java.lang.reflect=ALL-UNNAMED',
    'JAVA:9+|--add-opens=javafx.base/com.sun.javafx.runtime=ALL-UNNAMED',
    'JAVA:9+|--add-opens=javafx.controls/com.sun.javafx.scene.control.behavior=ALL-UNNAMED',
    'JAVA:9+|--add-opens=javafx.controls/com.sun.javafx.scene.control=ALL-UNNAMED',
    'JAVA:9+|--add-opens=javafx.base/com.sun.javafx.binding=ALL-UNNAMED',
    'JAVA:9+|--add-opens=javafx.base/com.sun.javafx.event=ALL-UNNAMED',
    'JAVA:9+|--add-opens=javafx.graphics/com.sun.javafx.stage=ALL-UNNAMED'

Will it be possible to add these through update sites? Otherwise, could these be added to the fiji.toml?
When I launch fiji, with these lines added to the toml, I get the following warnings in the terminal:
WARNING: Unknown module: javafx.controls specified to --add-opens
WARNING: Unknown module: javafx.graphics specified to --add-opens
WARNING: Unknown module: javafx.base specified to --add-opens
WARNING: Unknown module: javafx.controls specified to --add-opens
WARNING: Unknown module: javafx.graphics specified to --add-opens
WARNING: Unknown module: javafx.base specified to --add-opens
WARNING: Unknown module: javafx.base specified to --add-opens
WARNING: Unknown module: javafx.controls specified to --add-opens
WARNING: Unknown module: javafx.graphics specified to --add-opens

I think I get these warning became now the JavaFX jars are no longer bundled with the JDK, but instead are now in the jars folder. I think the jars in the jars folder haven't yet been added to the class path during startup and perhaps this is why I receive these warnings.
Is there a way to prevent these warning from happening?
On my M2 Mac Studio machine, when compiling mars-fx in IntelliJ IDEA using the following pom, the following jars are added to the jars folder:
javafx-base-21-mac-aarch64.jar
javafx-base-21.jar
javafx-controls-21-mac-aarch64.jar
javafx-controls-21.jar
javafx-fxml-21-mac-aarch64.jar
javafx-fxml-21.jar
javafx-graphics-21-mac-aarch64.jar
javafx-graphics-21.jar
javafx-media-21-mac-aarch64.jar
javafx-media-21.jar
javafx-swing-21-mac-aarch64.jar
javafx-swing-21.jar
javafx-web-21-mac-aarch64.jar
javafx-web-21.jar
javafxsvg-1.3.0.jar

It seems the jars will depend on the java version as well as possibly the computer architecture. How should these jars be distributed? Can I somehow help with testing/evaluating what should be done? (maybe I should post this question elsewhere, but I am not really sure where)

Will it be possible to add these through update sites?

Yes, issue #38 tracks the need for this.

Is there a way to prevent these warning from happening?

Java now has the module path as well as the classpath. Maybe if you add those JavaFX JARs to the module path, it will work. Right now, the fiji.toml Jaunch configuration adds only the imagej-launcher JAR to the classpath—unless you pass the --full-classpath flag, or run in --python mode, in which case it puts all JARs in jars/*/*.jar and plugins/*.jar on the classpath. But in no case does Jaunch put anything on the module path right now. It may be that simply having them on the classpath at startup is sufficient to quelch the warnings. Do you see the warnings when you run in Python mode and/or with the --full-classpath flag? You can use the --dry-run flag to see exactly how Jaunch is launching Java under the hood.

It seems the jars will depend on the java version as well as possibly the computer architecture. How should these jars be distributed?

Platform-specific JARs go into a subfolder of jars. For mac-aarch64, it'll be jars/macosx-arm64. The Updater is smart enough to mark JAR files in the platform-specific folders as specific to the respective platform in the db.xml metadata, meaning that only Fiji installations running on the matching platform will download them.

Thanks for the prompt feedback. Sorry I was so slow to reply.

Yes, issue #38 tracks the need for this.
Wonderful! I didn't realize there was already an issue.

Or, it may be that simply having them on the classpath at startup is sufficient to quelch the warnings. Do you see the warnings when you run in Python mode and/or with the --full-classpath flag?
I tried using --full-classpath in different combinations with or without python. In all cases, I am still getting the warnings. I also added the --dry-run flag and I can see all the jars are added. However, I still get the warnings. This surprises me. I will keep testing.

Platform-specific JARs go into a subfolder of jars. For mac-aarch64, it'll be jars/macosx-arm64. The Updater is smart enough to mark JAR files in the platform-specific folders as specific to the respective platform in the db.xml metadata, meaning that only Fiji installations running on the matching platform will download them.
This sounds like a great solution. I didn't know about this.

Sounds like all the important details are being worked on. The warning are a minor issue and not urgent, but I guess in the long run it would be nice if there were no warnings. I will keep exploring.


Feature Request

Dear Team,
Your work is awesome. I request you to add the following new feature to kapacitor.
Use case:
On insert, store specific column of a newly inserted record, in another table
Ex:
Newly inserted record in table firsttable
firsttable

timestamp
value
otherdata

01-10-2016 10:00
50
35

On insert store this timestamp,value in second table,
ex:
secondTable

timestamp
inTime
inData
otherData

xxx
01-10-2016 10:00
50
xxxx

On insert, Store timestamp 01-10-2016, value50 from firsttable to secondtable in new field.
Thanks,
Bala

@balamurugan-code Thanks for the detailed request.
Since InfluxDB does not have native support for time fields do you plan to store the time as a string or an integer?


Microsoft Graph was referenced incorrectly

The article had an incorrect reference to Microsoft Graph instead of Azure AD Graph.

@piotrci : Thanks for your contribution! The author, @MarkusVi, has been notified to review your proposed change.

Verified branding correction. Thanks!


Should PHP variables be detected and highlighted?

Taking the following code as an example, the php variable is not detected as a variable when it resides as a function argument or inside any bracketed syntax:
$var_is_detected = ''; # < This is detected as a variable

function my_function ( $var_not_detected, $another_var_not_detected ) {
    # These arguments are NOT detected as variables...
 }

# The value of 'id' is not detected as a variable...
$working_variable = array ( 'id' => $var_not_detected );

Is Detected = variable is highlighted
Not Detected = variable NOT highlighted

Currently we don't highlight variables in PHP (if they are highlighted in your example it's likely caused by a wrongly detected different language). This was done for consistency with many other languages where variables aren't highlighted either (Java, C, Ruby, Python, JavaScript, etc.)
Given the amount of controversy it is causing we may revisit this decision though… It's very subjective :-)

@marcoscaceres @egor-rogov
I sounds like before we were philosophically against this.  Is that still true?  If so I will close this as "wontfix" but if not I'll mark it as a feature request and help needed and we'd be open to PRs.
I'm not sure I completely buy the consistency argument as if I spent an afternoon I think I can find already find a lot of small inconsistencies already between languages and what they support.  It seems if our long term vision is truly "let the best people maintain the grammars" (which has a lot of benefits) then really this would become more of a community by community decision.
eg, Maybe PHP people like their variables highlighted, maybe XYZ people do not.

See #1142 for some context/discussion at the time amount of highlight dropped for PHP.
In my personal opinion the amount of highlight for PHP fell to... pointless at that point.

Quoting the original maintainer:

First, we just want to be consistent across languages. Most highlighters don't highlight local variables in other languages simply because they're not syntactically distinguishable. In PHP (and, say, Perl) they're easy to highlight because of the $ sign. But "because we can" is not reason enough.

Second, one of our design guidelines is to keep the bulk of code plain and only highlight things that are semantically significant, and highlighting them will add to code readability (all of this highly subjective and fuzzy, of course). Thus, we don't highlight many things that others do: UPPERCASE_CONSTANTS, CamelCaseNames, .method_calls().

But since then time has moved on, so perhaps time to revisit these things...

I don't think we have some strict policy nowadays. This is really subjective matter.
At the same time I don't think we should change existing behaviour.
I can see two possible solutions.
The first one is to clone php into separate repo and then adjust it to the taste of its maintainer. I'm not sure it's a very good idea, but probably we'll find it possible?
Second is to come up with some general approach to pass parameters into languages. This would be nice in cases like this.

At the same time I don't think we should change existing behaviour.

If it's pretty trivial... why not? Is consistency still the thought?

The first one is to clone php into separate repo and then adjust it to the taste of its maintainer.

I thought long-term that was the desired goal to reduce stress on the maintainers of the core parser project?
Consistency is a nice goal, but also "nicest styling possible per language" is another nice goal.  And who would best define that but users/readers of that language itself? :-)

Second is to come up with some general approach to pass parameters into languages. This would be nice in cases like this.

You mean allow people to extend the grammar with tiny grammar tweaks or alternations?  Do you see a lot of people actually do that?  I think the external PHP repository that does what the PHP people want just "drop it in" seems to be the more likely outcome.
A little bit of this does get at "who are the users of highlight.js"... a general purpose website who wants "consistent highlighting of all code" might be a very different audience than someone who wants the "best highlighting per language".  Those are very different goals,  hard to say which is better or worse.
IF the goal is user-maintained grammars long-term though I think consistency is going to be impossible to maintain (just too many different languages, too many different syntaxes, etc) so "the very best for a particular language" would seem to be the goal that would win, by default.

Removing PHP from the topic here and making this the general purpose topic for discussion so I can file other issue as dups and point them here.

In another thread I commented on the same type of request (but regarding highlighting the names of calling functions):

To push this forward for Javascript (or any other language at the moment) the best way would be to find a few people interested in maintaining the Javascript grammar and then fork that into it's own repo and make those improvements there.

Then we could discuss the value in that new repo becoming the defacto "JS" that's bundled by default with Highlight.js. I think that's how these types of discussions are going to move forward in a meaningful way - by people to show they are willing to put in the effort to maintain these things. That's currently the problem in core. Too many grammars, too little time and maintainers. So you can imagine the hesitancy to add even more features that will break, require maintenance, etc...

At the very least people would have a choice and could use the built-in one or decide to use the enhanced version and all it offers.

I think that same advice applies here regarding PHP.

At the same time I don't think we should change existing behaviour.

If it's pretty trivial... why not? Is consistency still the thought?

Why yes?
It's not about consistency. You're right, we can hardly maintain it across repos and across hundreds of languages.
But all we have now is one opinion that variables should be highlighted. I don't think it's a valid reason to change things (at least, not in the core).
As long as it is just two options (highlight variables or not), it looks simpler to have something like a parameter inside a single grammar. And if we speak of lots of deviating improvements, then yes, another repo with another grammar is more appropriate.
Anyway, I have no objections if someone is willing to maintain an alternative repo for PHP or other language. The only question is what to do with aliases?

The only question is what to do with aliases?

Not sure I follow?  I think at some point we'd "package" or "link to" the "official" community grammar... OR we'd let people choose when building the package... so someone would decide if "php" meant the one still in core or the 'community' one...  And all aliases would then refer to whatever was the version plugged in.
Or am I missing something?

But all we have now is one opinion that variables should be highlighted.

Evidently at the time we had LOTS of opinions from some vocal PHP people who hated the "improvement" to not highlight variables... so you could imagine in community hands that feature would come back pretty fast. ;-)

it looks simpler to have something like a parameter inside a single grammar.

Or just use the CSS rules?

It sounds like we've sort of resolve this I think:

There is some value in core itself staying consistent (while there still is a core for grammars).
IE, if we were to add variables to one we really should add to all (and that's not feasible, time wise)
There is also some value in legacy also (ie, let's not change it without a good reason).
So therefore: will not accept PRs against existing languages that add variable highlighting.
But if community maintainers decide to diverge from this with their own grammars, more power to them - so long as they are the ones maintaining it?

Is that a fair summary?  And would this same summary also apply to similar feature requests:

Desire to highlight every little punctuation mark, etc

I think the issue of making parts of the grammar process configurable would be a larger discussion and could perhaps be moved into a new fresh thread to discuss ideas for how we might go about even if we wanted to?

The only question is what to do with aliases?

Not sure I follow? I think at some point we'd "package" or "link to" the "official" community grammar... OR we'd let people choose when building the package... so someone would decide if "php" meant the one still in core or the 'community' one... And all aliases would then refer to whatever was the version plugged in

What if you load two versions of the same language? Say, in-core one from a bungle, and then an alternate.
Probably it's not a problem at all, and definitely we can do something about it, so nevermind.

Oh I'd say you'd let the latest one override the previous one... that way someone could start with a "default" build if they wanted and then overlay languages on top of it, even if they happened to be built in the existing bundle.

So therefore: will not accept PRs against existing languages that add variable highlighting.

Unless there are lots of people telling us we do it wrong, I guess.

But if community maintainers decide to diverge from this with their own grammars, more power to them - so long as they are the ones maintaining it?

Yep.
@marcoscaceres do you agree?

I think the issue of making parts of the grammar process configurable would be a larger discussion and could perhaps be moved into a new fresh thread to discuss ideas for how we might go about even if we wanted to?

I'm not sure we want, so let start such thread when we have reasons for that.

I'm not sure we want, so let start such thread when we have reasons for that.

Ok, so no thread yet. :-)

@egor-rogov Ok I was kind of 50/50 on this before but after reading thru MANY of our grammars we allow variables to be highlighted in a great many of them.  Just a small list:

ISBL
Powershell
Awk
Julia
Kotlin
Apache
Bash
Elixir
Ini
Makefile
Nginx
Puppet
RouterOS
SCSS

And that's not even a COMPLETE list.
That being the case, if someone made a PR adding this support to PHP I can't think of a good reason we should reject it.

Blatantly going to copy/paste my comment from the other ticket after @yyyc514 pointed out that it would have been better to post here in the first place.
TL;DR: I am writing a lot of Typescript lately and coming from Markdown to Asciidoctor (which uses highlight.js) I am really missing the contextual parsing and highlighting of variable names, function invocations and possibly types (at some point).

For training material and a lot of code that I am writing, I am in the process of migrating over from Markdown to AsciiDoc. Missing some of the highlighting I had previously is really noticeable as you can see in this example:

The same code snippet is more difficult to read (which is highly subjective of course) and I personally appreciate the distinction of classes/types from object members etc. which is helpful for beginners to distinguish various code elements.

@ChristianIvicevic In that example how would we know Client and Project are classes?

I do believe parsing 3rd party classes is one of the most difficult tasks when working with Typescript source files. This is due to their nature in possibly being intertwined with various syntactical elements and decorations.
Really naive example: assuming everything after the colon is a type you might run into a literal union doSomething(arg: "div" | "span") and all of a sudden you run into a scenario wherein you expected a type but got a literal value.
Another example is with regards to the generics. As you can see, T and K are contextually picked up being types as well even though they are referred to on multiple occasions in different contexts.
My suggestion is to analyze first whether some more naive features can be implemented to improve highlighting and ignoring more complex cases in the beginning:

Anything of the form foo(...) or bar.foo(...) that seems to be a function invocation can be highlighted (in my screenshot the map method)
Parameters inside a function declaration, i.e. in the scope of Typescript anything of the form name: Type inside parens such as entity, obj or propertyNames without highlighting their next occurences again

Before going more into detail, I'd like to ask whether it'd be useful to separate out this very specific discussion on the topic of Typescript into its own issue since the original issue was created based on PHP.

Sure, thanks for asking that. :-)  Can you pull this last bit over to a new thread then?

Closing this as I think the discussion seems to be over (for now).  My personal conclusion is posted above.  We can revisit this (if necessary) whenever this matter actually comes up again in a PR.


comments on faq

Changed some of the answers.
Please review and merge.
Also we need to address item 10 more seriously and present clear budget with milestones etc.
I think even more seriously than in the DEV grant application.

Nice 👍
Let's wait for @loiluu review then I will make changes to index.slim which is the source to generate our index.html. I will soon update a script for you guys to compile it yourselves. We should not make change directly to the html file.


a read-from-here folder or file

🚀 Feature
I was trying to read the project I found it hectic to continue in a normal fashion, It would have been a great help if there was a file that directed me to start reading from this folder then that one &c.
Motivation
This simple file could help and encourage others to read the project and also be less time consuming when doing so.
Correct me if I'm wrong and please help me see what my mistake was.

@Devansh-Walia I am not sure if I follow your suggestion, are you talking about some PL component or any other project using PL?

actually no. let me try and explain.
what I wanted to say was: A there should be a file that could direct people who are interested in reading the code of the project that highlights the workflow of the project. ( which module comes first which second)


Add VEGAN Token

Please Add VEGAN Token on TrustWallet
Contract Address: 0xfade17a07ba3b480aa1714c3724a52d4c57d410e
Token Name : VEGAN
Token Symbol: VEGAN
Decimal: 8
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[x] Filename in the lowercase format
[x] Image format: png
[x] Image size: 256 by 256 px

Dear team, I've submitted all required info as already marked as "Tick". Please take a closer look. Thanks.

Also, you can use these graphics to say that your ERC20 token fully compatible with Trust Wallet (https://trustwallet.com/logo-assets). Tokens will show up automatically once the user receives them.
Feel free to share this on social media and tag Trust Wallet:

Twitter: @trustwalletapp

Facebook: @trustwalletapp