bluetooth: host: Failed to set security right after reconnection with bonded Central

Describe the bug
Failed to set security right after reconnection with bonded peer. The failure is caused by inability to find SMP channel. It seems that ATT L2CAP channel tries to send security request before SMP L2CAP channel is initialized.
To Reproduce
The issue can be observed with samples/bluetooth/peripheral_hids sample. Steps to reproduce:

Build and program the peripheral_hids sample.
Connect with device over BLE (e.g. with Android phone) and establish security
Disconnect
Reconnect
Right after reconnection, the information about error is observed in the logs. The error log is observed on every reconnection.

Expected behavior
The SMP channel must be initialized before ATT channel tries to send the security request, so that security request from peripheral would work fine.
Impact
Sending SMP security request by peripheral right after reconnection with bonded peer ends with error. The SMP request is triggered by CONFIG_BT_GATT_AUTO_SEC_REQ which is enabled by default.
Logs and console output
Error log denoting problem:
[00:00:43.157,531] <err> bt_smp: Unable to find SMP channel
[00:00:43.157,562] <wrn> bt_gatt: Failed to set security for bonded peer (-128)

Environment (please complete the following information):
Commit hash: 2dc866fa487ba524b426adc453d028bdd7aaa4e2
Board: nrf52840dk_nrf52840

I set this issue to priority medium because @MarekPieta told me it affects a lot of samples in NCS.


DCOS-38943: Add Logo to Header Bar

Add the images and responsive styling for the Mesosphere logo on the header bar.
Show just the logo if the viewport is small. Otherwise, show the full logo with the label
"Mesosphere DC/OS".
Closes DCOS-38943
Browser (excuse the bad crop)

Mobile

Checklist

[x] Did you add a JIRA issue in a commit message or as part of the branch name?
[ ] Did you add new unit tests?
[ ] Did you add new integration tests?
[ ] If this is a regression, did you write a test to catch this in the future?

@leemunroe can you get it a quick look?

On that Feature branch: We decided not to do feature branches anymore, instead we disable WIP stuff before we commit.

Nice work @tnguyen0. This looks on track. Here's the final state we're targeting. Assuming color, spacing, hamburger is a separate task/PR?

@tnguyen0 For the logo, couple of comments.

Is there a reason we didn't use the logo that already exists in the product? We use one on the login. I think this could be reused so we're not loading more assets.

Looking at your CSS, couldn't we use the same logo graphic for both desktop and responsive views? Since we're using it like a background sprite the "Mesosphere DC/OS" part would just be hidden given the width.

I have a feeling these logo graphics are not suited for retina displays.

@leemunroe regarding the colors and other parts: they will be added in parallel issues and there is one “janitor issue” at the end. Your points about the images are valid tho 🤔

Thanks @leemunroe for your feedback. Regarding your points:

The existing logo wasn't the correct size. I had originally resized it using CSS, which worked fine. But then I thought it would be better to just add a new asset so there is no coupling.

I thought about doing this, but again opted to add a new asset.

But If we want to avoid adding new assets when possible, then I can make the changes.

How can I check this? They are essentially same graphics for login screen. So would the same point apply there too?

@tnguyen0 I think if you were to reuse that graphic, use CSS to resize, that would solve 1, 2 & 3 issues above. By scaling it down that solves the retina issue. By reusing it then we're not introducing two new assets and easier to maintain.

@juliangieseke @leemunroe done

gnah, forgot the summary: Yeah! LGTM 👍  - But two very small things which are important because we do want to work in parallel and need to be careful which lines we actually change.

@DanielMSchmidt @juliangieseke comments addressed


First pass for creating cloud resources

WIP, still need to do the following before it's ready for a full review + merge

[x] Test that it can deploy successfully
[x] Test reachability (ssh, http, etc) for launched instances to verify security group/VPC setup and everything
[x] Add OpenTofu commands to pixi.toml/etc incl installing OpenTofu in an environment
[x] Documentation (how to run commands, where everything is located, broad-strokes motivations for each piece of infra, etc)

Sending this out as a draft PR for now before I'm OOO in case I'm missing anything big with what's on the page
UPDATE 9/3 There's a conflict in the pixi lock, i'll look into that tomorrow (9/4)

lock ssh down to just ssm & ec2 instance connect before taking this out of draft

This is really great @nikiburggraf! I think we're really on our way to a reproducible infrastructure 😄 I do have suggested changes for the terraform code so that we follow the industry best practice for that and also start making labels not too tied to only support_sphere and laurelhurst. Let me know if you have any questions. Thanks!

Thank you so much for taking a look @lsetiawan!! I definitely appreciate the suggestions for more reproducibility and for letting me know about best practices! Definitely will be great to get my first terraform/opentofu build up to snuff with what everyone else is doing in this space :)

Updated with requested changes, @lsetiawan!
I'm only providing the tf inputs via envvars for now, I know that offline we discussed parameters, but I couldn't think of a great way to do that without repeating the project name and neighborhood several times throughout the pixi.toml. I'd rather just define those in one specific place, honestly
All pixi commands have been tested with these new changes


testing bad code

Summary by CodeRabbit

New Features

Added "hackathon testing" section with commands to print current user, output error codes, and execute specific tests in the recovery script.

@coderabbitai generate unit testing code for this file

@coderabbitai full review


Eliminate deprecated stream method usage

com.google.common.collect.Streams.stream(Collection) is deprecated. We can directly use the stream method in any collection.

Merged, thanks!


Add documentation of public fields in net.NetAddress

There is no point in the stdlib docs that mentions that net.NetAddress represents the C sockaddr (sockaddr_storage to be exact) struct and thus e.g. the port is in network byte order. Add some docstrings to the public fields that explain the format of the fields and their usage (e.g. using htons beforehand).

This depends on getting docstrings for public fields. See the corresponding rfcs issue: https://github.com/ponylang/rfcs/issues/106

This is merged into master and will be released with 0.22.


Common registry crash

Hi all
I just remade my modpack for 1.12
However,when adding refined storage, i get a common.registry.GameRegistry
This seems to be forge overhauling registry systems? But I just updated everything.
Forge version is latest: 1.12.2 - <IP_ADDRESS>47
Refined storage is: 1.6.3
vkr
vic
https://pastebin.com/EyJGPSND

Hi, your Forge version is older than my grandmother. You'll have to update that


locale is not a function

I just updated from v3.0.0 to v4.7.14, just imported the new libs instead of the old.
I'm getting the following error twice:

b.locale is not a function  (line 8, col 28068)
a.locale is not a function  (line 8, col 16269)

I searched my site code and I don't seem to be setting the locale any place, as I never had.  Is this a known issue / change with the latest code base?  How should I resolve it?

I think v3 it was lang or something like that in v4 it should be locale. do you have demo page or a fiddle of the issue?
Are you sure you've got the v4 libs?

Thanks for the quick reply.  I just downloaded and included the latest code so I'm definitely on v4.7.14.
Just did a app search for "lang" and the only place I use that is in the main   tag.
To replicate what I have in a fiddle would be tough.  We include your libs in the head, we init all our daytime pickers at one time in another include, then we just use markup all over the site (its kinda a complicated site).  We do pass all the config settings in on a single "config" data attribute, then parse that out (I think one of our divs pinged you about that last year sometime).
Here's an example of the markup used:

<input type="text" data-config="{'pickTime':false,'format':'MM/DD/YYYY', 'defaultDate':''}" id="srEnd" name="srend" class="form-control">

Note this is my v3 code so it includes the pickTime which I also needed to remove.
Here is how we init it all globally in one call:
 $(function(){
dtpicker.initDatePicker();
});
var dtpicker = {};
function initDatePicker(){
$('.input-group.date').find('.fa-calendar').css('cursor','pointer');
$('.input-group.date').each(function(){
var config = eval("(" + $(this).find('input').data('config') + ")");
$(this).datetimepicker(config);
$(this).on('click',function(){
$(this).data("DateTimePicker").show()
});
});
}
dtpicker.initDatePicker = initDatePicker;
I hope that gives you a little picture of what we have.  If you want to anything else just let me know.
Thanks!

can you look at the console in Chrome (or something) and past a screen cap?

Its not very detailed but thats what I get

I assume you have included the latest version of MomentJs?
Can you try the non-minified version?

So we have moment 2.6.0.  I see on their site the current version is 2.10.3
We only include:  moment.min.js
I am not including moment-with-langs.js nor am I including the any of the lang files.  We really only have a need for English.  So if thats something the newer code base needs that is probably the issue.

nope that shouldn't be an issue. I'd update your moment version and try the non minified version of the picker to see if you get the same or different errors

FYI - updating to the latest version of moment fixes my issue.  I had version 2.6.0, and have now updated to version 2.10.3 and the locale error went away.
I did then run into an issue where it wasn't finding my glyphic font files.  It seems to expect them in the same location as the CSS file in a fonts sub folder. But we're using font awesome anyway so I just set the icons property on the config.
One thing to mention on your documentation's custom icons section.  In the example you show us of time, date, up and down, but no mention of previous or next.  It would be helpful to see a full list of the icons you can override.  It's easy enough to look in your code but other might not think to do that.
Thanks for your timely responses yesterday.  We love using your plugin!


"vbox client not running" error dunst notification on startup (desktop)

resolved... there was a bug in the setup script where it was installing packages meant only for virtual machine installs, on any install. was a bash syntax error. fixed.


Footer shadows left nav

Go to https://cucumber.io/docs/reference/jvm and scroll all the way down to see it.


Bug: Imported files show no size

What happened?
When importing files via the import script, they all show 0.0B as the size in the dashboard. The total storage stats show the correct total size. The logs don't seem to have anything useful.

Version
latest (ghcr.io/diced/zipline or ghcr.io/diced/zipline:latest)
What browser(s) are you seeing the problem on?
Firefox
Zipline Logs
2023-09-30 05:00:21,443 PM info  [datasource] using Local(./uploads) datasource
Imported konata4.png (image/png mimetype) to user 4
Imported legogar.png (image/png mimetype) to user 4
Imported test.txt (text/plain mimetype) to user 4
2023-09-30 05:00:21,451 PM info  [database::migrations] establishing database connection
2023-09-30 05:00:21,451 PM info  [database::migrations] ensuring database exists, if not creating database - may error if no permissions
2023-09-30 05:00:21,578 PM info  [database::migrations] exiting migrations engine - database is up to date
Starting transaction to database..
Finished transaction to database.
Copying files to local storage..
Finished copying files to local storage.

Browser Logs
No response
Additional Info
No response

Not a bug. It is, however a bit dated, since it doesn't include a file's size.

fixed in https://github.com/diced/zipline/commit/89c58044a3fa12330c49034e081b26a030c4af2c
imported files will now have size associated


[C#] Add Log support for the gridlib

Gridlib will need to be given a ILogger object to generate its logs.

SymphonyAPI should also provide a IloggerFactory

Need to enrich log with Error and Exception

Reference to Issue #67

Fixed issue with Exception in version 2.5.2


Doc around caching strategy is confusing.

Docs state:

You can also configure how to control the network requests interception for any of your application resources. You can find more information on Workbox - Caching Strategies. -- https://vite-pwa-org.netlify.app/guide/service-worker-precache.html

The linked workbox doc talks about cache-only, network-only, and cache-first-then-network, network-first-then-cache, showing you how to implement this if your implementing the caching yourself (and hence the entire service worker yourself). That's not really helpful - I'm using vite-pwa to avoid having to write the SW  and caching implementation myself! Neither docs hint at a workbox or vite-pwa option to configure any one of the strategies.
AFAICT vite-pwa just generates a service worker with a cache-only strategy and there is no option to select a strategy. Is that the case? If so, saying "You can also configure how to control the network requests interception for any of your application resources" seems misleading/erroneous, and "configure" should be  "implement you own".

PWA plugin options:

genarateSW strategy, use workbox PWA plugin option
injectManifest strategy, use injectManifest PWA plugin option

If you use genarateSW strategy, then,  you only need to configure the runtime caching plugins (via workbox.runtimeCaching), check VitePWA options codesnippet here https://vite-pwa-org.netlify.app/workbox/generate-sw.html#cache-external-resources
vite-plugin-pwa is a Workbox wrapper, you should be familiar with Workbox.

Types can be found here:

https://github.com/vite-pwa/vite-plugin-pwa/blob/main/src/types.ts#L127-L134
https://github.com/vite-pwa/vite-plugin-pwa/blob/main/src/types.ts#L6
https://github.com/vite-pwa/vite-plugin-pwa/blob/main/src/types.ts#L2

Thanks for the pointers. Will be sure to PR to clarify doc once I understand how to cache-first and other policies configured  and working correctly.


Crashes when navigating between top-level menu items

I get crashes when navigating between top level Blog and Community items and back. Sometimes it blows away the whole page.

To repro:

Open https://reactjs.org/blog/2017/11/28/react-v16.2.0-fragment-support.html
Press "Community" on the top level
Page is blown away
Refresh
Press "Blog"
Page isn't blown away, but there are errors

Possibly related to https://github.com/reactjs/reactjs.org/issues/298

Paging @KyleAMathews

I wasn't able to reproduce — I can look later at how eventHandler could be called before window.___history is set.

Doesn't repro for me either now 😞

I have seen Gatsby occasionally get into a broken state- maybe not quite like this- and refreshing the page always fixes it, which makes it difficult to track down.
One reliable way to get it broken like this is to load a page without the file extension. For example, rather than loading reactjs.org/docs/hello-world.html, open reactjs.org/docs/hello-world. Now every link you click causes the error @gaearon mentioned above:

app-ac5cc93e27d86a811a05.js:1 Uncaught TypeError: Cannot read property 'push' of undefined

I think I may have chatted with @KyleAMathews about this before, but I'm not certain.

I may have fixed this issue via PR #397 but since I was unable to reproduce it I don't know.
I do still see some errors in the console:

But no crashing.

I'm going to assume this issue has been fixed for now given that the repro steps are not sufficient to repro it. Let's re-open if we're still seeing it.

Nice, thanks Brian!


Fix go sum error in CI build

CI build has been failing. Trying to reproduce.
WIP
go version used in CI is:
go1.16.5 linux/amd64
There is a known bug in this version that results in error like this:
missing go.sum entry for module providing package golang.org/x/net/idna
See golang bug here: https://github.com/golang/go/issues/44129

Fixed by https://github.com/go-swagger/go-swagger/pull/2606. Fixing go version to 1.15


fix(deps): update dependency com.google.cloud:google-cloud-shared-dependencies to v3.12.0

update dependency com.google.cloud:google-cloud-shared-dependencies to v3.12.0
To solve upper bound dependencies error caused by this upgrade for google-cloud-notification, also upgrade storage and pubsub versions.
Closes #9573

Which guava version will work with 2.20.0?


Make project more approachable for outside contributors (miscellaneous tasks)

[x] Fix the tests.
[x] Update any other existing documentation not covered in other issues.
[x] Clean up open issues and branches.
[x] Curate a list of good first issues and things we want help with.
[x] Create a good issue template (not PR template, that's covered elsewhere)

This is all done or covered by #174 and #175.


RDM-4108 Definition Store to create new import format definition for …

…new web components - Event List and Details, & Support Columns in Tab View
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/RDM-4108
Change description
Definition Store to create new import format definition for new web components - Event List and Details, & Support Columns in Tab View
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Verified on my local, OK to merge in.


Is run-hidden faster than .vbs wrapper for launching powershell scripts?

You would have to measure it. I would guess run-hidden in faster, possibly not much faster. My tests can be found here:
https://forum.doom9.org/showthread.php?t=183935


Fix duplicate remove from running liveactions set

On action runner shutdown, item in the _running_liveactions set is removed twice, once during the abandon process and a second time on completion of _run_action.

LGTM, add a changelog and address one minor comment.


Account JWK Fixes

Fixed some mistakes introduced in #12 due to not running tests after I refactored a bunch of things 🫠 All account tests now pass, though the only test that doesn't complete is the DNS one. I expect that one is a bit more manual, as it dies waiting for a DNS challenge to be written?

Thanks a lot, give me a couple of days to test/validate and merge this.


Improve README

Update README with minor corrections so that the example works out of the box.

I see it, but currently I'm working on major update, so this will be outdated soon. However, I noticed that a more novice-approached description is needed.


[WIP][da-vinci] Make chunk assembly a utility

Summary, imperative, start upper case, don't end with a period

This moves chunk deserialization and assembly to a utility, so it can be used in different areas in the da-vinci client. This is because other areas face the issue of message sizes being too large to be sent under one message, so they need to be serialized and chunked.
How was this PR tested?

CI
Does this PR introduce any user-facing changes?

[X] No. You can skip the rest of this section.
[ ] Yes. Make sure to explain your proposed changes and call out the behavior change.

Just a quick thing,
I 'think' you should make a new local branch or merge the branch your working on with main, this PR seems to be recording the changes from your last change.

New PR opened here


Bot stays in channel after adding invalid link to queue.

I am running the latest version (0.1.2) on Ubuntu Server 16.04. When anyone adds a link from youtube that is "unavailable" when you open it in your browser then bot stays in voice channel even though stayinchannel is set to false in config. There are no errors in console output.

This will be resolved in the next release with the merge of #583


MC kernel updates for V3.0 RouteLink

The v3.0 RouteLink file contains stream segments with zero-valued floodplain widths, which causes issues in the existing MC kernel - specifically NaN flow predictions. The same issues are also caused in the WRF Hydro MC kernel - addressed in this PR: https://github.com/NCAR/wrf_hydro_nwm_public/pull/599
The changes proposed here include some additional conditions on if statements that account for situations when the water height is greater than the trapezoidal channel bank full height and the floodplain width is zero.
Testing

The newly changed MC kernel produces the same exact results as the old one.
NCAR will conduct additional testing to make sure the changes work with the v3.0 RouteLink

@aubreyd I tested @ CONUS scale with v 3.0 RouteLink and LAKEPARM, cold started. No nans to be found, so I'm optimistic that these changes work. Curious to see how your assessment turns out.


Service 'redmine' failed to build : Build failed has appered.

Thank you for your help.
I tried to run docker-compose according to the Quick Start guidance, but I got an error like the one in the image.
I tried to create a directory because there are no such files or directory, but the error like the image is still displayed.
Can you tell me if there is any workaround?

Note: docker-compose uses the name of the folder where the .yml file is located to name the container.
Remove "build: ./" from docker-compose.yml

Thanks a lot!!
With your valuable advice, it was solved successfully!


added redis support

Had a need for Redis support, so I thought I'd make the addition quick. It uses the official redis image from Docker: https://hub.docker.com/_/redis/

Hey thanks for your contribution! I will take a closer look at this today afternoon (CET)

Looks great!


add GetTreeState gRPC

Part of #304. This PR requires https://github.com/zcash/zcash/pull/4744 (which hasn't been merged yet, but this PR will gracefully return an error if running with a zcashd that doesn't include that PR).

Latest force-push is a rebase, and changes to correspond to the latest version of https://github.com/zcash/zcash/pull/4744


Add a font function

Currently text settings do not play well with font fallback list. There is no way to invoke font features for each font separately.
#set text(font: ("font1", "font2"), stylistic-set: "ss03") // Set to ss03 both fonts

I propose a new font function, which contains options that should apply to specific font. The above code would become:
#set font(stylistic-set: "ss03")
#set text(font: ("font1", "font2"))

Additionally we can set font features separately:
#let font1 = font("font1", stylistic-set: "ss03")
#let font2 = font("font2", stylistic-set: "ss01")
#set text(font: (font1, font2))

This change will also make #3331 easier by just add one more unicode-range option to font.

Working on this right now.


Adding externalServices

Migrating this info from https://extensions-registry.firebaseapp.com/extensions.json to extension.yaml.

Testing

[x] Extension installs as expected.
[x] Functions work as expected.

Thanks @joehan.
Approved and added to our tracker.


CI fails on Node v12

See this comment: https://github.com/trufflesuite/drizzle-utils/issues/108#issuecomment-500475833

fix this


More cleanup of the site dispatcher

This is my go at cleaning up one of the most important files in Elkarte.
A fool's work is never done, though.

Juts a technical remark: it would be better to avoid merges, but use rebase instead, if you have problems with it, I can do the rebase for you, I got quite used to them. lol

Apart from that I'd say... cool stuff! :dancer:

LOL .. I made comments right while live627 was making the updates to the commit.

LOL .. I made comments right while live627 was making the updates to the commit.

Yeah... bad merge.

it would be better to avoid merges, but use rebase instead

Why? To get rid of merge commits?

Sorry, I got the email notification only today... :-\
Yep, that and because the tree becomes cleaner.

GH has the option to not make a merge commit in the repo options-I just now found this out accidentally.

GH has an option to squash all the commits in a PR into a single commit (squash and merge), what I was suggesting is a little different (rebase instead of the merge you did to keep up with the changes in development).
Anyway, this is already here, and we have done it in the past, so I guess I can avoid being too picky.


Refactor, new features and bug fixes

This PR contains multiple changes:

Expose parts of the Manager API
Properly store event handlers
Follow event emitter API and return self to allow chaining of on, once, off and emit
Add unit tests from the web client

The manifest's still need to be bumped I think. Also, the connection still breaks up on Android after ~ 10s :(.

@hansemannn the version bump will be made via #12. The unit tests on their own are using the socket and i didn't see any issues with Android disconnection there.
Let me check again testing with a longer running connection and i'll get back to you.


Adding linker gen

What problem does this solve? I mean we still have to edit the param file and rebuild the linker to change those values. Isn't the --defsym approach more versatile?

What’s the defsym approach?
My thought here would be so that we would eventually have several platforms to support which may/will have different peripherals and memory maps

To set it through the gcc flags for each test suite. Are different platforms going to need different linker scripts though? Stuff like stack size is more dependent on the program than the platform.

Linker scripts are the primary way to differentiate between platforms. Program segments may be placed in ROM/RAM/FLASH, have size and address differences, etc.
I see what you’re saying though, changing symbols is useful for things that are different per program e.g. argc / argv. Top of dram / stack I would say is platform dependent more than program. The minimum stack size needed for a program is of course program dependent, but shrinking the maximum stack size to fit it is just an optimization we use to reduce sim time

I see. So are we going to write a linker script generator for each platform?

Probably just add parameters to this one, but whatever ends up being easier


[suggestion] Data retrieval instruction

Feature request
We add a new instruction Instruction::RetrieveData(QueryBox, ...) the permissions for which are tracked separately from the regular query execution. Its execution can have side-effects defined by the executor, and the event system should be made aware of the events that result when specific information is retrieved.
Consider implications for #3527.
Motivation
Some data stored even in public blockchains, can be privileged. As such, knowing who retrieved the data, recording the time of retrieval, and controlling the conditions of the retrieval attempts is is an important use case that Iroha should support.
The idea with this implementation is that the blockchain operator disallows all queries for all accounts by default. Privileged information is retrieved with the given instruction, but the success/failure of a data retrieval instruction is subject to arbitrarily complex logic on the executor side.
Example
Blockchain contains a collection of people's medical records. Both patients and their doctors are accounts on the blockchain. The patient can mint a token to the M.D. of their choosing and using that token the M.D. can retrieve data of that patient once, which burns that token. If further updates are needed, the patient mints the token again. But if the doctor is no longer the medical professional handling the patient, and doesn't have the token data retrieval is no longer possible.
If this were handled through queries, the permission should have been granted, and revoked based off of complex logic that would not necessarily correspond to anything meaningful. A lot of automation is impossible, because the automatic burning of the token has to be done elsewhere given the restrictions placed by #3717.
Who can help?
@DCNick3 @appetrosyan
Progress

[ ] Implement internally in Iroha (#3891)
[ ] Implement output recovery on client side (#3892)

I've thought of an additional idea (which is just a potential improvement for the future, shouldn't be definitely considered within the issue) to preserve unauthorized data access by a node owner. The permission mentioned in the example might be treated as a sort of "encryption". Given that, will it make sense to allow a data owner specifying the encryption public key, which is used to encrypt the data related to the user (either on client or node side)? With that anyone can retrieve the data but only ones who have the private key to decrypt the data could read the actual content. The data owner could be also allowed to reencrypt the data using new keypair to 'reset' access. Though in that case some proof of data unchangeability might be required (referring to the medical records example, I doubt the user should be able to rewrite that in more regards than allowed).
Ofc there are cons (or at least gaps) in this approach, e.g. it's still possible to get a historical state content once an outdated keypair is acquired.
Again, that is not a technical solution proposal, just a quick glance  for a direction for a feature I find really attractive for the example from the description (privileged data).

Some data stored even in public blockchains, can be privileged.

If blockchain is public and privileged data has some value, what prevents malicious actor to get whole blockchain and leak this data?


Changed implementation to optimized token bucket counters

@STRML these comments are addressed in the latest commits

I believe I've addressed everything in the various review threads, have tried to thumbs-up stuff that I've committed. These changes are published to internal npm and referenced in https://github.com/BitMEX/api/pull/165


Fix spelling error of tesselFirmwareVerion

See incorrect spelling here: lib/controller.js#L941
While I am in there, since it displays node version as well. Would just tesselVersion or tesselVersions (plural) be a more appropriate name?
cc @rwaldron

Maybe even... tesselEnvVersions?

Do up a patch with "Fixes gh-682" in the commit message and I'll land it as soon as it's green

That works too.

Is it accurate though? Push back if you think not.

Might not be. When I hear environment variables. I think more like flags. NODE_ENV=production or PORT=3001. I think, in this case, you wouldn't set the version this way.
On the other hand, the versions here define the environment you are working with. So, really, I think it could go either way.

I thought about it a little more, and tesselVersions could be construed as versions of Tessel, ie. 1 or 2.
And tesselEnvVersions more accurately describes the environment within Tessel which you are working with.

I agree with that. tesselEnvVersions it is!
I have to step out for a bit, so if I don't follow land right away, no worries—I will do it as soon as I have a chance :)

Sounds good and no worries!


Precache with less strict update time

Description
By debugging, I found that the update time in the cache key set by precahing was 15 min different from the update time on sample report view. This change truncates to the nearest day so there is little chance of mismatch.
Any new pipeline runs are assumed to be run with a new pipeline version. The report_ts covers exceptional situations.
Note
I don't know why a pipeline run would be updated after this:
    # Check if run is complete:
    if all_output_states_terminal?

      if all_output_states_loaded? && !compiling_stats_failed
        update(results_finalized: FINALIZED_SUCCESS)

        # Precache reports for all backgrounds
        Resque.enqueue(PrecacheReportInfo, id)

Any ideas? It is important to know if any such update would affect the report counts.
Test
load report page
see no errors
check datadog in prod for cache hits after preaching

I don't see a reason the pipeline should update after all outputs were loaded and it was marked finalized


Update to .NET 6 and Remove Unused Usings

Update to .NET 6
Removing unused usings
Sorting using statements
Adding .editorconfig from https://github.com/RehanSaeed/EditorConfig

Mate you can dump this if you don't want it.  Can't help myself adding .editorconfigs all over the place
It's a lot of changes really so feel free to tell me to go jump in a lake.

That editorconfig is pretty opinionated but I like most of it's moxy.  The only update should be to expression body constructors.....boooo

@stphnwlsh Thank you for this.


Redo the splash screen download loop

It's long and could be more efficient.

We need to look at the default term logic again, it doesn't make sense where it is
We need to delete the stuff from internal storage when logging out
We need to remove the NoInternetException
We need to broadcast MinervaExceptions


Search

SearchView and Search urls should be implemented
Better if using built in MongoDB full text search feature
modules should have a way to define the index schema, maybe a new file search_indexes.py (remember to add in cookiecutter template)
By default Content and Channel should be indexed.
Search results should respect  "indexable" attribute in channels and avoid duplications.
It should use for thumbnail the SubContent with "thumbnail" or "main_image" purpose (adding _thumb)

#134 related, this should work with elasticsearch, whoosh, mongo


Tab icons only for small devices

Hi,
would be awesome if its possible to use icons for the tabs on small devices only, otherwise a text for the tab.
Thanks!

Going to call this one a duplicate of #58 as once that is implemented then you'd be able to make an mobile exception using that new feature.


installation using ipk does not install /etc/init.d/netclient

Specifically "opkg install netmaker-dev_0.9.0-1_all-openwrt-19.07.ipk" finishes silently, without indicating success or failure. No /etc/init.d/netclient as expected. There is, however, /usr/share/gocode/src/github.com/gravitl/netmaker/netclient on the file system.

netmaker-dev_*.ipk (eg. netmaker-dev_0.9.0-1_all-openwrt-21.02.ipk) are source code packages for development, use netmaker_*.ipk (eg. netmaker_0.9.0-1_x86_64-openwrt-21.02.ipk) instead.


[Layout] v2 Epic

Epic to track changes for Layout

Deprecate layout component
Remove from Storybook
Add notice to v1 website
Migration guidance needed

How to use the Carbon grid

moved tasks to #10722


IDVA5-1075-Updating chs-node-utils

Updating chs-node-utils to get the latest changes which  Capture analytics for the English AND Welsh toggle

CI: No security warnings found


editor accessibility must be reenabled at the start of each lesson

Looking forward for reporting a security issue:
Please report security issues by sending an email to<EMAIL_ADDRESS>instead of raising a Github issue.
Describe the bug
A clear and concise description of what the bug is.
The Monaco editor contains features for accessibility, specifically a mode for screen reader users which helps in navigating and using the editor effectively. This feature, as of now, must be enabled at the start of each lesson, even after enabling it once at the beginning of the session.
To Reproduce
Steps to reproduce the behavior:

Go to any lesson in the curriculum.
Enter the code editor, set focus to it.
Press alt+f1 to show accessibility help for the editor, and choose to enable the screen reader mode
complete the lesson, advance to the next, and repeat steps two and three

Expected behavior
A clear and concise description of what you expected to happen.
The screen reader mode should have stayed enabled across lessons.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS] Windows
Browser [e.g. chrome, safari] Chrome
Version [e.g. 22] 69.0.3497.100 (Official Build) (64-bit)

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.
Tested screen reader: NVDA version 2018.3.2
from https://www.nvaccess.org/download/

Hey, @devinprater @Bouncey. As a part of hacktoberfest, I would like to work on this issue.
Can I expect mentorship on this?

@iAziz786 I'm new on this too. But if you need help, I would like to work on this issue too.

@kelvinromero Can you reproduce this issue?

A group of us are working on this issue for a class project in university. We aim to address this in the next couple of days. We will try and at least present the community with a first iteration of our proposed solution.
Just a heads up. If the current developers have any advice or tips, feel free to contact me. Thank you.

Any updates on this @oalhait @saransha ?

This looks to be fixed, the editor is focused on load. Can you confirm that this is fixed @devinprater ? If so, this can probably be closed.

@moT01 I don't think it is fixed.  It focuses on load by default, but I think that turning on the screen reader mode is separate from just focusing.
I don't have a screen reader installed, but if I follow the steps above I keep having to re-enable that mode each time I go to a new challenge.

Sorry, I don’t think the editor should be focused on load, as that means the screen reader user most unfocus it, move back to the heading to read the challenge, then focus it again to write code. Also, I still have to enable accessibility mode on each challenge.

On Nov 13, 2019, at 8:48 AM, Tom<EMAIL_ADDRESS>wrote:
This looks to be fixed, the editor is focused on load. Can you confirm that this is fixed @devinprater https://github.com/devinprater ? If so, this can probably be closed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/freeCodeCamp/freeCodeCamp/issues/18487?email_source=notifications&email_token=ADUMTTXMUB3LDG7DE2GNHHTQTQHS7A5CNFSM4F3HCXVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED6LL7Q#issuecomment-553432574, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUMTTVPPS7CY7KX35O2KYTQTQHS7ANCNFSM4F3HCXVA.

VoiceOver on MacOS is… not the best, sadly, when it comes to web apps. If possible, you can send technical info about this to<EMAIL_ADDRESS><EMAIL_ADDRESS>Mono is Microsoft’s editor, which seems to be VSCode stripped down to the editor. Perhaps you could contact Microsoft and see if they could add a way to make accessibility states persistent across loads, if this isn’t possible already.

On Nov 13, 2019, at 9:14 AM, Tom<EMAIL_ADDRESS>wrote:
I see now. And I can say that the built in screen reader on osx doesn't do anything with the editor.
Is this something we can control? Or is it just part of the monaco editor and we are at their mercy?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/freeCodeCamp/freeCodeCamp/issues/18487?email_source=notifications&email_token=ADUMTTSF2UES44CLCHV3KUTQTQKVFA5CNFSM4F3HCXVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED6OEWA#issuecomment-553443928, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUMTTXKHV3OCY6H46VESADQTQKVFANCNFSM4F3HCXVA.

Sorry, I don’t think the editor should be focused on load, as that means the screen reader user most unfocus it, move back to the heading to read the challenge, then focus it again to write code.

That is annoying.  For now you should be able to focus the description by pressing escape (at the moment, it's still in a state of flux), but I'll see about making screen-reader mode something that persists between challenges.

Seeing as how this issue is beyond our control, should we close this and make a new issue about the editor being focused on load?
You can feel free to email apple or microsoft if you want @devinprater. Thanks for the advice though.

@moT01 no need to close this. I think I can fix it.

Yes, we can close this issue.

On Nov 13, 2019, at 9:38 AM, Tom<EMAIL_ADDRESS>wrote:
Seeing as how this issue is beyond our control, should we close this and make a new issue about the editor being focused on load?
You can feel free to email apple or microsoft if you want @devinprater https://github.com/devinprater. Thanks for the advice though.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/freeCodeCamp/freeCodeCamp/issues/18487?email_source=notifications&email_token=ADUMTTXX3LLG3STYUNXDGDLQTQNOBA5CNFSM4F3HCXVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED6QWTY#issuecomment-553454415, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUMTTRUF3WKWLLNLY3GP33QTQNOBANCNFSM4F3HCXVA.

Quick update.  Both the auto-focusing and the persistence of accessibility mode should be fixable.  I think I'm about 90% of the way there, but for some reason it stops letting you toggle the accessibility support after a couple of toggles.
This, obviously, isn't ideal, but most of the functionality is there.


Verify Node Ready

Type of change
Note: Fill x in []

[ ] bug
[x] enhancement
[ ] documentation
[ ] dependencies

Description

Check the node status after the OpenShift installation or upgrade, and raise an error if any node is not in 'Ready' status. Additionally, add relevant unit tests or integration tests.
For security reasons, all pull requests need to be approved first before running any automated CI

@RobertKrawitz, any more comments ?


Plugin metadata changes

Current Behaviour
Plugin metadata still references files and package ID for the MLKit plugin.
Expected Behaviour
Plugin metadat should now reference the new SmartScanner files and package ID.
Steps to Reproduce the Problem

npm install -D @idpass/smartscanner-cordova
cordova plugin add @idpass/smartscanner-cordova

Error during processing of action! Attempting to revert...
Failed to install 'cordova-plugin-impactlabs-mlkit': CordovaError: Uh oh!

Context

Version: 0.3.0-beta.1
Platform: Android
Cordova version: 9.0.0<EMAIL_ADDRESS>

Already applied changes in latest version v0.3.6


chore(files): when we upload a file more than 1gb no error appears in the user side

we have 1gb space, when we upload a file of 2gb there's an error in terminal but no visible error to the user
2023-05-12 17:43:42 | ERROR | Error when upload file: InvalidLength { context: "DJI Osmo Pocket downloadable 4K video sample test footage file - 2.MP4", current:<PHONE_NUMBER>, minimum: None, maximum: Some(1073741824) }

https://github.com/Satellite-im/Uplink/assets/29093946/f381d72c-2be0-419d-9df3-bd125df57489
macOS, m1
feedback from https://github.com/Satellite-im/Uplink/pull/797

if you need big files for testing purposes
https://www.mediafire.com/folder/9971h5184vpju/Osmo_Pocket_test_files


forgytroies.com

Domain
forgytroies.com
Link
http://forgytroies.com/redirect.html?od=1syq614519af29ec5_vl_weekvl_0z61.11u3t3k.O0000rg2riu1b670ij_xf1266.g2riuMHV5ZzdnLTFlcjJwOW80m4NPa
Version
0.0.0
What browsers are you seeing the problem on?
Firefox
What OS are you seeing the problem on?
Windows
(Optional) Anything else?
http://forgytroies.com/redirect.html?od=1syq614519af29ec5_vl_weekvl_0z61.11u3t3k.O0000rg2riu1b670ij_xf1266.g2riuMHV5ZzdnLTFlcjJwOW80m4NPa
http://forgytroies.com/redirect.html?od=1syq61461378774c3_vl_weekvl_0z61.11u3t3k.O0000rg2rsm16e90ij_xf1266.g2rsmMHV5ZzdnLTJocXBvNG80m4NPa
Code of Conduct

[X] I agree to follow this project's Code of Conduct

All 404s.


drivers: adc: add max1125x driver

Hi everyone !
This adds support for the max1125x (max11254, max11254) family of spi adc devices.
Signed-off-by: Mustafa Abdullah Kus<EMAIL_ADDRESS>

@nashif @galak @anangl ping

Thank you for your contribution!

MaureenHelm

:star_struck:


[7.x] $attributes are not being passed down to Blade components anymore

Laravel Version: 7.0
PHP Version: 7.4
Database Driver & Version: MySQL 8

Description:
Hello,
we were using Laravel 7 dev version in our project and it was ok. After upgrading to 7.0 release (released today), the $attributes variable are not taking effect anymore inside components.
Steps To Reproduce:
Just create a Blade component, pass some attributes (e.g. "class") and add {{ $attributes }} inside the component, and you can see that it won't be taking any effect (not being passed down).

Investigating

@driesvints thanks!
Just to help, I created a new L7 app, changed my welcome.blade.php to this:
<!DOCTYPE html>
<html lang="{{ str_replace('_', '-', app()->getLocale()) }}">
    <head>
        <meta charset="utf-8">
        <meta name="viewport" content="width=device-width, initial-scale=1">

        <title>Laravel</title>

        <!-- Fonts -->
        <link href="https://fonts.googleapis.com/css?family=Nunito:200,600" rel="stylesheet">

        <!-- Styles -->
        <style>
            .font-red {
                color: red;
            }
        </style>
    </head>
    <body>
        <x-teste class="font-red"/>
    </body>
</html>

And my teste.blade.php component is simply:
<div {{ $attributes }}>
    Hello World
</div>

Fixed in 7.0.1.

Wow, you're fast men!
Thank you!

This one was my fault. Apologies to all for the problems caused 😢


Selection tool: add flip and delete buttons

Add 'flip horizontally', 'flip vertically' and 'delete' buttons to the selection tool.
For example

When multiple disconnected structures are selected - they should be flipped based on the selection box origin, not separately.
For example:
original structure

after vertical flip

Additionally - we should remove the current flip and rotation buttons in the right toolbar, since now this functionality will be done via the rotation box.
#184121704

Does 'Delete Button' equal to 'Erase Tool'? If I click the delete button, the selected structure will be deleted from the canvas, right?

One more question is what if the selected structure is out of canvas' bounding, should we do something like

@yuleicul regarding your first question - yes it should work the same way as the erase button, or like pressing "delete" key on the keyboard
Regarding your second question - this is not 100% required right now, but would be great to have, we can add a separate task for this.

P.S. The functionality of flipping one single bond should be removed. (Confirmed with @KonstantinEpam23 )


I2C

Hi, I have a problem .
hosting 10 arduino uno r3 with Esp8266 but when it connects, it disconnects after a few minutes and no longer connects. What's the problem?

Unfortunately I have been having a very similar interaction @CypherHex above. I have my rigs on automated power switches and it seems that my I2C rig will go on for a couple hours and then max out at around call at 11 or 12 hours a day and then not come online again until the next day when the power switch turns on for the day. Sometimes I noticed the I2C rig does not even come on initially in the beginning of the day and I’ll have to manually turn on and off the plug via the app I have.


TST: try to make Appveyor work again, setuptools was too old there.

This fixed it, so merging: https://ci.appveyor.com/project/rgommers/pywt/build/1.0.19


URL Shortner App

Hello,
I want to add one new app idea to this repository. Which is a URL Shortner app.
Kindly assign this to me.
Thank you

Hi I am new to OpenSource can you assign this to me

i can work upon this

Hi, I am new to this project and would like to work on this.


Update README.md

I'm wondering how I can't approve my own pull request of my own repository. Hold up...

I did something and I might have to revisit branch permissions in a while, not sure..


Update to web-ext-plugin version 2.x.x

Required addional compiler options for ts-node to be able to handle ESM
modules, which web-ext and web-ext-plugin now use. Also Webpack
configuration needed to be split for ESLint to still be able to use it.
See https://github.com/webpack/webpack-cli/issues/2458 for details
regarding ts-node and ESM.

Finalizes originally automated attempt of #259.


build: include go_package mapping for csi.proto

Generating Go code from the .proto files gives a deprecation warning when csi.proto is imported. By passing the M option on the commandline to the generators, the warning is addressed.
See-also: https://developers.google.com/protocol-buffers/docs/reference/go-generated#package

The warning can be observed in recent (successful) executions of the protoc workflow:
# generate libs
cd .. && ./bin/protoc --go_out=lib/go --go_opt=paths=source_relative --plugin=./bin/protoc-gen-go replication/replication.proto
2023/06/28 13:11:22 WARNING: Deprecated use of 'go_package' option without a full import path in "github.com/container-storage-interface/spec/lib/go/csi/csi.proto", please specify:
	option go_package = "github.com/container-storage-interface/spec/lib/go/csi";
A future release of protoc-gen-go will require the import path be specified.
See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information.

cd .. && ./bin/protoc --go-grpc_out=lib/go --go-grpc_opt=paths=source_relative --plugin=./bin/protoc-gen-go-grpc replication/replication.proto
2023/06/28 13:11:22 WARNING: Deprecated use of 'go_package' option without a full import path in "github.com/container-storage-interface/spec/lib/go/csi/csi.proto", please specify:
	option go_package = "github.com/container-storage-interface/spec/lib/go/csi";
A future release of protoc-gen-go will require the import path be specified.
See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information.

Runs with this PR do not have these warnings anymore.


Will the cache be rebuilt if an item is created/edited within Strapi admin?

Hi, as above, :-)
Thanks

Currently not, but we can surely make bust the cache via the admin endpoints as well.
Closing this ticket as it's a duplicate of #8


[docs] Improve docs for std.conv.to

Document overloads of to which take a radix - see last commit.

Note: This continues the work done in #4208.

Have to say that I'm against these changes.
Before I changed the to docs to what they are now, it was a jumbled mess of all of the different overloads of toImpl for every type. The idea with how it's arranged now is that the particulars of each type to type conversion would be under one place. The fact that the radix overloads exist is already listed under the integer conversion examples.

The radix overload docs are currently buried in the middle of all the other to docs. It seems to me that they are significantly different because they take an extra argument, and should be documented after the usual to overloads. It is also non-standard to document the radix overloads without showing their signature, only their usage.

Have to say that I'm against these changes.
Before I changed the to docs to what they are now, it was a jumbled mess of all of the different overloads of toImpl for every type. The idea with how it's arranged now is that the particulars of each type to type conversion would be under one place. The fact that the radix overloads exist is already listed under the integer conversion examples.

We are currently in the process of removing overloads from Phobos - not adding new ones - as the overloads are an implementation details, that the user of a generic function shouldn't be bothered with..
@ntrel: is there a chance you could maybe improve the text documentation so that it's even clearer?

@wilzbach:

We are currently in the process of removing overloads from Phobos - not adding new ones - as the overloads are an implementation details, that the user of a generic function shouldn't be bothered with..

The 2 radix overloads are not implementation details, they are important for the user - all the other overloads only take one argument. I have now simplified the constraints (and removed one) so they only show what source type the radix overloads apply to. I have undocumented the static array ref (non-radix) overload as I agree that could be seen as an implementation detail.

@ntrel: is there a chance you could maybe improve the text documentation so that it's even clearer?

Possibly, but it would be fighting against ddoc's purpose of documenting declarations, we shouldn't be explaining what hidden arguments a function takes manually IMO. Documenting the 2 radix overloads normally we get the usual Parameters section etc.
I have also added 3 signatures manually at the top of the docs, partly because the actual signatures from this PR are so far below the pages of docs & examples, but also so the user can quickly grok the function, and the docs now refer to S, the source type from the signatures.

@wilzbach Removed overloads from docs.

@wilzbach  I can't work out why ./circleci.sh style_lint is failing on this. Any ideas?

@wilzbach I can't work out why ./circleci.sh style_lint is failing on this. Any ideas?

Not really, looked pretty strange to me as well. However, rebasing to the latest master commit worked :)

@wilzbach Thanks!


Add Katharine as a user

What
Added Katharine Ahern as a user to initializer and seed files so she can run application locally
Checklist
Before you ask people to review this PR:

[ ] Tests and rubocop should be passing: bundle exec rake
[ ] Github should not be reporting conflicts; you should have recently run git rebase master.
[ ] There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
[ ] The PR description should say what you changed and why, with a link to the JIRA story.
[ ] You should have looked at the diff against master and ensured that nothing unexpected is included in your changes.
[ ] You should have checked that the commit messages say why the change was made.

Codecov Report

Merging #2714 (7200e84) into master (ed1f705) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #2714   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          532       532
  Lines        11100     11100
=========================================
  Hits         11100     11100

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed1f705...7200e84. Read the comment docs.


What is the difference between this repo and "arqamAR" repo?

Hello,
I have already used this repo (nArabicWords), and i want to know what is the difference between this repo and arqamAR repo?
Thanks.

I think I need to re-organize my repos properly.
Thanks for your note


release: update manifest and helm charts for v1.3.0

Signed-off-by: Anish Ramasekar<EMAIL_ADDRESS>
Reason for Change:

Requirements

[ ] squashed commits
[ ] included documentation
[ ] added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

[ ] Yes
[ ] No

If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers:

Codecov Report

Merging #958 (bc69dc5) into master (cdc1c0e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #958   +/-   ##
=======================================
  Coverage   59.13%   59.13%
=======================================
  Files          10       10
  Lines        1062     1062
=======================================
  Hits          628      628
  Misses        399      399
  Partials       35       35

/azp run pr-e2e-azure


Build Tags

Pass build tags though from config

https://github.com/asticode/go-astilectron-bundler/pull/71 took care of this change


FancyZones only lets you set left and right of three zones

ℹ Computer information

PowerToys version: 0.23.0
PowerToy Utility: FancyZones
Running PowerToys as Admin: No
Windows build number: 19041.508

📝 Provide detailed reproduction steps (if any)

… FancyZones has three zones set Priority Grid
… Shift key down, drag app to left and sticks
… Shift key down, drag app to right and it sticks
… Shift key down can't set app into primary middle area

✔ Expected result
expect App to show all three areas and snap app to middle one
❌ Actual result
Shift has no affect while trying to drag 3rd app
📷 Screenshots
Pressing shift and side

pressing shift for centre

Are there any useful screenshots? WinKey+Shift+S and then just paste them directly into the form

Seems to be an issue with Chrome only, Version 85.0.4183.121 (Official Build) (64-bit), works as normal with Chromium Edge, OneNote and Excel

@pmtate
are you shift-dragging the whole Chrome window or just one tab?

I was dragging the whole Chrome window

@pmtate
I cannot reproduce this and given how common is Chrome I would expect that this would be reported by other users as well if it was a common bug, but I suspect it's something specific of your configuration.
Can you try disabling any Chrome extension that you installed? Is Chrome running in developer mode or something like that?

been trying to repeat and things are working as they should, apologies must just have been that day when it was repeatable and consistently not likely Chrome


make Dependabot PRs trigger changie generating Github workflow

Issues

Changelog
Use reusable workflow from our actions repo to trigger adding a changelog to Dependabot PRs with changie.
Note: the job in this workflow runs only if dependabot opens a PR. If we want to also keep a manual way of triggering the chanige job lmk and I can add some extra "triggered by" stuff there

[X] List your changes here
[ ] Make a changie entry, N/A CI only

Tophatting

@davidbloss will this end up changing the currently open dependabot PR's we have open to create changie entries?


Fix automatic submission service

Checklist

[x] I run yarn run webpack:build:main: the project builds without errors.
[x] I run yarn lint: the project builds without code style warnings.
[x] ~I updated the documentation and models.~
[x] I tested the changes and all related features on the test server https://artemistest.ase.in.tum.de.
[x] ~I added (end-to-end) test cases for the new functionality.~

Motivation and Context

The automatic submission service that was re-enabled in https://github.com/ls1intum/ArTEMiS/pull/393 did not work properly.
Description

The problem was that the service also loaded example submissions that do not have an associated participation. The missing participation then caused a NullPointerException. I fixed it by excluding submissions that do not have a participation associated when loading the submissions from the database.

I still have to check the correct behavior for submissions started after the exercise due date, as these submissions should not get submitted automatically.

I discussed the desired behavior with @krusche and adjusted the implementation accordingly:
Submissions should be automatically submitted if

the corresponding exercise has finished
the submission has a submissionDate
the submissionDate is before the exercise dueDate

It's not that easy to test it properly, but I think I finally made it to test all different scenarios on the test server. It looks fine to me.
One note: In the text submission component we do not subscribe for automatic submissions, i.e. the UI is not properly updated when the corresponding submission is submitted automatically in the mean time. For modeling exercises it works fine.

Does this fix #402?

@jpbernius Yes, modeling and text submissions that are saved before the exercise due date get automatically submitted by the automatic submission service. However, it checks the submissions every night at 01:00 a.m. and not directly at the time of the due date of every exercise.


Add automated workflow to turn Documentation and one-pagers into markdowns and update table

How to make sure both the local repo and remote are up-to-date when pushing from local?

done


Update the available ruby version to 2.3.0 or later

sorry, could you change the commit message since it's contradicting. 37d6d6b

ah, never mind.


How to start  ?

I don't understand how to run it

You can follow README file for flow of execution


Authentication work

If credentials mode (and only), add a line in _configure:
# This is pseudo-code
self.authentication_policy =
    kwargs.get('authentication_policy') or
    credentials if isinstance(credentials, HTTPPolicy) else None or
    policies.BearerTokenCredentialPolicy(credentials, **kwargs)

Same in the async config, with the async policy

Since you work on this, please do https://github.com/Azure/autorest.python/issues/109 as well

Updated spec after discussion (for the sake of accurate issue :))
# This is pseudo-code
self.authentication_policy = kwargs.get('authentication_policy')
if self.credential and not self.authentication_policy:
    self.authentication_policy = policies.BearerTokenCredentialPolicy(credentials, **kwargs)

fixed


Yelo Update inscriptions.json

Found a duplicate, I would like to replace BTC Yelo 42 with the inscription ID 0ca035777c5f1e3e6005c633a9f3e30d6e35c75b81e669e4949bbbd21c975f39i0 with b40de5727f0f010738566e8bd7d366ef54d31b149cdf59a71de705838030cb06i0. BTC YELO 476 was added by mistake as there is already a BTC Yelo 42.

inscription ID 0ca035777c5f1e3e6005c633a9f3e30d6e35c75b81e669e4949bbbd21c975f39i0 has not been removed from the collection


Checkin for CANOPUS

Notebook still contains run results from NIST, we should remove this completely or update this with CANOPUS results; some files in the data folder are also for NIST e.g. MHfilter_trvate_idx.pkl and filter_te.pkl - should we remove these?

README script says that ens_train_realistic.py is used for training ESP, but the examples shown use ens_train.py

README header for DEMO is referring to NIST instead of CANOPUS

final5 folder already contains mol_dict.pkl and pos_test.csv so it's unclear if those still need to be downloaded

Made some more changes based on feedback


0.7.4 release

@sezanzeb 0.7.4 should now be available. sorry for the delay.

no problem, it wasn't urgent :)


Complete remote record fields on elixir 1.18

Local buffer records addressed in https://github.com/elixir-lsp/elixir-ls/issues/1074

Addressed in 4d932055617ed6b05cdbd5ca270f3335c4cbcd65


[Chart] Metric columns are not in the correct order in bar chart

When design a bar chart, I encounter problem with the order of metric columns. They are not in the correct order.
Expected results
Metric columns are preserved correct order in the request
Actual results
Metrics columns is sorted by alphabet
Screenshots
Before

After

How to reproduce the bug

Go to explore window and design any bar chart
Create list of metrics, name them as any order in alphabet (Example: z_metric, a_metric, k_metric)
Run the visualization
See the problem, now the columns are: a_metric, k_metric, z_metrics which are not in correct order.

Environment

superset version: master branch
python version: 3.8

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

@duynguyenhoang thanks so much, Duy! Every issue you open comes with a fix! Appreciate your help to improve Chart and Explore lately. If you are looking into making a more significant impact on Superset, please reach out to me on slack!

@duynguyenhoang thanks so much, Duy! Every issue you open comes with a fix! Appreciate your help to improve Chart and Explore lately. If you are looking into making a more significant impact on Superset, please reach out to me on slack!

I believe this was resolved by the linked PR, but the issue was never closed out! Closing it now, but let's open a new one if anything resurfaces. Thanks again @duynguyenhoang for the fix, and as @junlincc said, if you ever want to get involved again, reach out to either of us on Slack!


withScriptjs is undefined

Both of the following still makes withScriptjs undefine:
import { withScriptjs } from 'react-google-maps
import { withScriptjs } from 'react-google-maps/lib/withScriptjs

@thanhacun which version are you using now?
https://github.com/tomchentw/react-google-maps/blob/77a5f4ffead3f818a7a3c86f54dbcbbd852ba912/lib/index.js#L7-L14

I am using version 8.0.0, temporary I have to use
import * as withScriptjs from ...
and use withScriptjs.default as a fucntion

Are u using webpack/babel?
Does this only happen to withScriptjs? Or other components as well?

I do use webpack/babel (create-react-app)
It only happens with withScriptjs

Working code sample:
import  * as withScriptjs from 'react-google-maps/lib/withScriptjs';
import { withGoogleMap, GoogleMap, Marker } from 'react-google-maps';

const MapWithAMarker = compose(
  withScriptjs.default,
  withGoogleMap
)(props =>
  <GoogleMap
    defaultZoom = {8}
    defaultCenter = {{ lat: -34.397, lng: 150.644 }}
  >
    <Marker position={{ lat: -34.397, lng: 150.644 }} />
  </GoogleMap>
);

Oh, read the Changlog. WithScriptjs is now exported by root(but I don't know why you can't use it)
For explicit import, just use default import:
import withScriptjs from lib/...

Yes as I mention in the first post: if import as the changelog, withScriptjs will be undefined.
I have tried both root import and explicit import as well

It is working now!
May be when upgrading to v8.0.0, it is not successful!
Very sorry to bother you!

LOL good to hear that!!

Released v8.1.0


Add a Meta.allTables extension variable/function

Use case
It would be nice (when developing/testing) to perform CREATE and/or DROP on all tables at once. When there a few tables it is easy to list them all and also not forget one. As the table count grows, there is an increased likelihood of forgetting to include one when creating the list manually. (I'm currently testing against a DB with ~40 tables.)
Describe the solution you'd like
Instead of running
val query: Query<Unit> = QueryDsl.create(
    Meta.alpha,
    Meta.bravo,
    Meta.charlie,
    Meta.delta,
    Meta.echo,
    Meta.foxtrot,
    ..
)

Run
val query: Query<Unit> = QueryDsl.create(Meta.allTables)

Note: This might need to be named something else or located somewhere else in the unlikely event that a database has a table called AllTables
Versions

Komapper: 1.1.2
Kotlin: 1.7.10
JVM: Corretto 14
Database: SQL Server and H2 In-Memory
JDBC Driver or R2DBC Driver: Dependencies as pulled in via komapper-dialect-h2-r2dbc and komapper-dialect-sqlserver-r2dbc
OS: Windows 10

It isn't easy.
If we generate Meta.allTables at compile-time, we will not benefit from KSP's incremental processing. Because we always have to process all entities and entity definitions to know all meta names.
Do you have any good ideas?

After a bit of reading into KSP, which I still have limited knowledge of, I can't see a way to do it without requiring a reprocessing of all entities and definitions.
The only suggestion I would have is in opt-in build flag, which would generate the allTables variable at the cost of a full reprocessing.
This is be no means a must-have request, it would just be a convenience. I'm quite happy for this to closed as 'won't implement' if you want.

Thanks for sharing your thoughts.
I won't fix it at this time.

Maybe have an extension property generated at compile time that uses reflection at run-time (basically just used for unit tests... so maybe not so bad to have that extra overhead?)

It is not possible to collect all extended properties in reflection.
Why do we need a sealed interface/class? I am not sure if it will help in this case.
There is a way to enable the Metamode listing with the KSP option as follows:
ksp {
    arg("komapper.enableMetamodelListing", "true")
}

When this option is enabled, Komapper always processes all entity classes. This approach will result in some loss of compilation performance.
However, if you want we would provide it.

Say you'd just Add a special sealed interface EntityMetaBaseForMeta1 and derive all Meta1 entity meta classes from it, we could retrieve a list of all those classes by doing something like this in the test code val entities: List<KClass<*>> = EntityMetaBaseForMeta1::class.sealedSubclasses, then you wouldn't need the extra pass in KSP...

Who should provide EntityMetaBaseForMeta1?
Kotlin documentation says:

All direct subclasses of a sealed class are known at compile time. No other subclasses may appear outside a module within which the sealed class is defined.

So Komapper cannot provide EntityMetaBaseForMeta1.

This issue has been fixed by #857.


Clean up and upgrade dependencies

Closes #241.

Remove Node versions that reached End-of-Life from Travis CI
Upgrade all dependencies to latest versions (and update tests accordingly)

Woohoo! Thank you for this work.

Awesome! Thanks @mourner!


TC-DIAG-TH_NW 2.1 Neighbor table list contains an entry with FrameErrorRate out of range, Security policy Flags value is also out of range

SHA: 1e3f12041013dd71a53d035dbf2f6d142fc06c4e
platform: nRF52840
all clusters app
Frame error rate should be in range 0-100 but it's 124.
./chip-tool threadnetworkdiagnostics read neighbor-table-list 1 0
[1655894245.353869][13550:13555] CHIP:TOO:   NeighborTableList: 1 entries
[1655894245.353936][13550:13555] CHIP:TOO:     [1]: {
[1655894245.353959][13550:13555] CHIP:TOO:       ExtAddress:<PHONE_NUMBER>5606181840
[1655894245.353971][13550:13555] CHIP:TOO:       Age: 19
[1655894245.353983][13550:13555] CHIP:TOO:       Rloc16: 8192
[1655894245.353993][13550:13555] CHIP:TOO:       LinkFrameCounter: 1947
[1655894245.354003][13550:13555] CHIP:TOO:       MleFrameCounter: 636
[1655894245.354023][13550:13555] CHIP:TOO:       Lqi: 3
[1655894245.354036][13550:13555] CHIP:TOO:       AverageRssi: -38
[1655894245.354047][13550:13555] CHIP:TOO:       LastRssi: -39
[1655894245.354058][13550:13555] CHIP:TOO:       FrameErrorRate: 124
[1655894245.354070][13550:13555] CHIP:TOO:       MessageErrorRate: 0
[1655894245.354081][13550:13555] CHIP:TOO:       RxOnWhenIdle: TRUE
[1655894245.354091][13550:13555] CHIP:TOO:       FullThreadDevice: TRUE
[1655894245.354101][13550:13555] CHIP:TOO:       FullNetworkData: TRUE
[1655894245.354107][13550:13555] CHIP:TOO:       IsChild: FALSE
[1655894245.354117][13550:13555] CHIP:TOO:      }

Flags should be of type uint8 but its 8335.
./chip-tool threadnetworkdiagnostics read security-policy 1 0
[1655895190.363600][14037:14042] CHIP:TOO: Endpoint: 0 Cluster: 0x0000_0035 Attribute 0x0000_003B DataVersion:<PHONE_NUMBER>
[1655895190.363619][14037:14042] CHIP:TOO:   SecurityPolicy: {
[1655895190.363623][14037:14042] CHIP:TOO:     RotationTime: 672
[1655895190.363626][14037:14042] CHIP:TOO:     Flags: 8335
[1655895190.363629][14037:14042] CHIP:TOO:    }

For the neighbor table frame error rate src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.cpp does:
neighborTable.frameErrorRate   = neighInfo.mFrameErrorRate;

where neighInfo is a otNeighborInfo.  Its definition for mFrameErrorRate at https://openthread.io/reference/struct/ot-neighbor-info#structot_neighbor_info_1a98814b49467b869ff4a15bba5c1d9ca2 says:

uint16_t otNeighborInfo::mFrameErrorRate
Frame error rate (0xffff->100%).

I'm surprised this assignment even compiles.  @Damian-Nordic @kkasperczyk-no is the relevant directory not using -Wconversion in its build flags?
For the security policy, it looks like our XML is wrong:
  <struct name="SecurityPolicy">
    <cluster code="0x0035"/>
    <item name="RotationTime" type="INT16U"/>
    <item name="Flags" type="BITMAP16"/>
  </struct>

(as noted above per spec the flags are uint8) and the implementation in GenericThreadStackManagerImpl_OpenThread<ImplClass>::_WriteThreadNetworkDiagnosticAttributeToTlv does not make sense to me:
            memcpy(&policyAsInts, &activeDataset.mSecurityPolicy, sizeof(policyAsInts));
...
            securityPolicy.flags        = policyAsInts[1];

but mSecurityPolicy is defined at https://openthread.io/reference/struct/ot-security-policy to have 9 boolean members, a uint8_t member, and a uint16_t member (rotation time), and nothing I see says that they come in the order this code is expecting....  And clearly we are getting bits that are not part of the actual flags in some way here.

The spec issue: https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/5414


test  Add materialized view which contain external table rewrite test

Proposed changes
test the query rewritting when materialized view  contains external table.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall


Update bitcoind to v22.0

Interesting project. Saw the mention on twitter about it.
Just letting you know as maintainer of the https://github.com/lncm/docker-bitcoind project that 22.0 is now available.

@krtk6160 if you want to take over this PR. we should do it before taproot get activated to do our part in helping to reduce the odds of a chain split (I don't remember the detail for why that is thought, I just know it's better if more nodes run on v22 during taproot activation)

Yep, I'll take over this


Fix input event

Fixed missing dispatch input event to gradio
code from: https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/master/javascript/edit-attention.js#L42
Fixed this issues: https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/issues/2
Tested passed

Good catch, thanks!


Documenting the undocumented features

There are a number of undocumented features in the API docs. I looked through the WABT README, which didn't explain them either, and there does not seem to be any other documentation. There are also one or two places where docstrings exist, but could be clearer.
Default Options
Is it true that every option within all four of the options objects (WasmFeatures, ReadWasmOptions, ToTextOptions and ToBinaryOptions) default to false (at least currently)?
WasmModule
The WasmModule has a few methods, resolveNames, generateNames and applyNames which have docstrings, but it's not clear what these methods are used for. Are they specific to binaryen?
ToTextOptions
The ToTextOptions hash has two undocumented properties, foldExprs and inlineExport. I'm assuming that {foldExprs: true} enables S-expressions, and {inlineExport: true} enables inlining export declarations, in the generated output??
ToBinaryOptions
The ToBinaryOptions hash has four undocumented properties. The log property presumably determines whether a log is generated.
I couldn't work out what canonicalize_lebs or write_debug_names are for. Also, relocatable was a bit confusing to me, considering how WebAssembly abstracts memory. Adding a link here and there that explains the purpose of these features would be helpful.
Personal Bit
My own ignorance is bound to contribute to some of the misunderstanding here, but there should be enough information in the docs for somebody to at least figure out what they need to look into. For example, I googled (and binged) lebs, wabt lebs, wasm lebs, emscripten lebs and binaryen lebs, and still don't know what lebs (or LEBs) are.
If we can gather the missing bits of information here, I'd be happy to update the README. I just need to understand the features myself first.
I'm not in urgent need of any of this information personally. I just like the library, and the README has been like that for ages, so it seemed worth trying to fix. Thanks.

Update: I found the docs for the toolkit's command line flags, which has made everything a lot clearer.

Note that this repository is just a buildbot for the original repo, and questions are better directed to the original authors of WABT. However, these descriptions look fine and I'd be happy to merge a PR improving both the README and .d.ts docs :)

Thank you. I'll keep the repos in mind in future, and will make a PR soon. Much appreciated.


Ability for  containers/service links to leave a service similar to being able to join a service using selectorContainer/selectorService.

Server version - v0.41.0-rc1
We have the ability to join containers/ add service links to a service by specifying selectorContainer/selectorService.
Since we do not have the ability to edit a container/service label , once containers get added / service links get added to a service , there is no way them to be delinked from the service.
It would be useful to have a way to delink the containers/service links from a service similar to having the ability to join the service.

@sangeethah for service link, you can remove it using removeServiceLink API, just the way you would do for a regular link.
For container that joined the service using selector, currently there is no way to leave the service, this is correct. Could you change bug description so it reflects only selectorContainer use case?

This bug should be fixed with this https://github.com/rancher/rancher/issues/2321. So closing as a duplicate.


Add some basic support for HAML

Hello! Would it be possible to add some basic support for HAML? I think this should be very similar to Slim, and it would be super helpful. Thanks!

Hey @ndbroadbent!
In haml, do we use also hashtag # for ID's and dots . for classes?

Hi @gencer, yes that's the same!

Yws, we do! Checked on haml website.
Changes are on master

v1.7.5
Can you test this version and let me know?
html-slim-scss-css-class-completion-1.7.5.zip

Hi @gencer, I tested v1.7.5 and it works great! Thanks very much for working on that so fast!


use the latest rest api from the revenue cat, fix request issues, add tests

Hi,
The plugin doesn't work in the latest main branch.
The first issue it doesn't use provided userId.
The other issue that json object received from the latest Revenue Cat Rest API is completely different from what the plugin is trying to parse  here.
Looks like this plugin not really supported, since there were no changes in the last 8 month. But feel free to apply changes if  you see necessary.

Thanks for taking the time to create the PR, I will take a look in the upcoming days and provide feedback.


Gossip and store blocks with different beacon values

Description
Today, nodes immediately discard blocks that were created using a different tortoise beacon value, since those blocks will appear syntactically invalid:
https://github.com/spacemeshos/go-spacemesh/blob/50268fc6c8aa7205c8a5c5d573f17cf7956084df/blocks/blocks.go#L105-L108
Instead of discarding these blocks, per @tal-m, we need to store and gossip these blocks:

A block with an incorrect beacon value isn't syntactically invalid --- it's valid, but its vote is postponed
It should still be gossiped and stored (and its votes should be counted once they are old enough)

Related: #2541
Affected code
blocks/blocks.go
blocks/blockeligibilityvalidator.go
This issue appears in commit hash: 50268fc6c8aa7205c8a5c5d573f17cf7956084df
CC @nkryuchkov

the current implementation matches the description already. closing this issue.

and i am wrong. we still consider ballot with different beacon invalid.

damn. this is embarrassing. this is indeed what's implemented now. ballots with different beacon are saved.


Suggestion: use SubtleCrypto digest over @oslojs/crypto for sha256

As noted in this discussion it seems possible to drop the dependency on @oslojs/crypto in favour of using SubtleCrypto.
The main argument towards this would be to reduce the number of dependencies at play.
There are additional aspects that SubtleCrypto does not block the event loop and has faster digest computations for bigger inputs. For the expected sizes of 32 bytes this is not a direct issue here.

My understanding is that contrary to #110 this feature would be present in Cloudflare workers: https://developers.cloudflare.com/workers/runtime-apis/web-crypto/

@sergiodxa any opinions on this? Would you rather have it in our out?


State Changes section example

public class AppState
{
    public string Message { get; }

    // Lets components receive change notifications
    public event Action OnChange;

    public void UpdateMessage(string message)
    {
        shortlist.Add(itinerary);
        NotifyStateChanged();
    }

    private void NotifyStateChanged() => OnChange?.Invoke();
}

Where does shortlist and itinerary comes from?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 60c195c0-99f6-64f5-66a3-4e69109dc8ee
Version Independent ID: 24368808-4b90-f75a-e887-eb72a1c85f5b
Content: Build reusable UI components with Blazor
Content Source: docs/architecture/blazor-for-web-forms-developers/components.md
Product: dotnet-architecture
Technology: blazor
GitHub Login: @danroth27
Microsoft Alias: daroth

Looks like shortlist.Add(itinerary); should be replaced with Message = message;.


Name Service missing - SPL

Hi, I've noticed that the name service for SPL is not available here.
https://github.com/solana-labs/solana-program-library/blob/c05f445d73ffe917367c590aaccee1ec018801f6/name-service/
Any plan to add next days/weeks? or not in priority list?
Thank you!

I'd be happy to take a PR :)

Hi Michael!
Actually, one of the forks already have the Naming Service. https://github.com/Auguron/solana-py/tree/master/spl/name_service from @Auguron
I don't know why didn't PRd to this repo.
Thanks!!

https://github.com/Auguron/solana-py/tree/master/spl/name_service

Cool! Would be amazing if someone could PR these in. 🙏 .


Optionally prevent unintended database schema updates

Some time ago we had 2 configuration settings to optionally avoid database upgrades:

SkipOrchestratorDatabaseUpdate
SmartOrchestratorDatabaseUpdate

These were removed as the code to handle updates was improved and considered more reliable.
I think that a similar option would be good to reinstate, especially on large environments.
Reasoning is:

the current assumption is that all versions of the code in use are identical. If you deploy large amounts of servers and also run orchestrator on application nodes too then achieving this instantly is likely to become harder and harder.
if you have a cluster of orchestrator nodes (providing an http service) then you probably want to update the database only when no nodes are trying to write to the database so possibly only with a single node being active.  You really don't want any other servers suddenly trying to upgrade the database without prior notice and preparation.

So probably in a small environment it's ok to let this happen automatically and I think it's fine for it to be the default behaviour. However, an option to prevent this would at least ensure that an unintended run by some orchestrator binary won't generate ALTER TABLE commands which potentially might lock up the main orchestrator node while it tries to write to the same table.
I suggest we add a configuration setting AvoidDatabaseUpdates bool which by default has a value of false and intend to write a patch to support such a change.
I have been bitten by this sort of thing happening a number of times now and would prefer to stop everything and only on a single node allow the update, after which point the configuration setting would be disabled again.

Basically I wonder if it might be simplest to revert this: https://github.com/github/orchestrator/commit/54a0b54f3e0861b052bfda0c28b7bdd905a87805

Yes, makes perfect sense!

addressed by https://github.com/github/orchestrator/pull/85


Pass Hash with attributes

Normally i define my factories like this one:
FactoryGirl.define do
  factory :user do
    vorname "John"
    ......
    ......

But in my recent project i get the data from a File in shape of a Hash:
 read_data_from_file('data.xml')
   => {:vorname => "John" .......}

Is it somehow possible to write my Factories like this?
FactoryGirl.define do
  factory :user do
    {:vorname => "John"...}
  end
end

Ps. When I tried to run my test like this It returned:
expect(build(:user).vorname).to eq("John")

   expected: "John"
        got: nil

I'm not sure what you're trying to achieve there, but my solution would be storing the read_data_from_file('data.xml') output to a variable and building the factory only with the values, not the keys.

data = read_data_from_file('data.xml')

FactoryGirl.define do
  factory :user do
    vorname data[:vorname]
  end
end

It may not be a great option but you can actually pass a hash to the attributes method:
  factory :user do
    attributes { {:vorname => "John"} }
  end

I do think that @romulomachado's  solution would be preferable to mine.


web: style error page a bit better

Hello @jazzdan, @yuindustries,
Please review the following commits I made in branch nicks/loading:
1d8d108b390d11adf659891c81d2c24824dd1371 (2019-05-29 01:23:19 -0400)
web: style error page a bit better


⚠ ClamAV has degraded performance

In 3076fff, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 65 ms

Resolved: ClamAV performance has improved in 142d8b2.


fix: rely on pod informer to requeue while share manager is starting

Which issue(s) this PR fixes:
longhorn/longhorn#9086
What this PR does / why we need it:
My preferred solution. There is no reason to enqueue the share manager in hopes of catching the pod with containers ready. The share manager controller has a pod informer that will enqueue the share manager any time the pod status changes.
Additional documentation or context
Reduced number of reconciles with the following message to 34 on master-head. (Even this number is inflated, because it accounts for reconciles from all share manager controllers in the cluster. In the buggy case, the tens of thousands were additional reconciles from only the owner).
[longhorn-manager-mckzz longhorn-manager] time="2024-07-25T21:44:39Z" level=warning msg="=====> In syncShareManager with state starting" func="controller.(*ShareManagerController).syncShareManager" file="share_manager_controller.go:333" controller=longhorn-share-manager node=eweber-v126-worker-9c1451b4-6464j owner=eweber-v126-worker-9c1451b4-kgxdq shareManager=pvc-781870d7-26e5-4a11-907a-f51d12acb2e8 state=starting volume=pvc-781870d7-26e5-4a11-907a-f51d12acb2e8
[longhorn-manager-cxksx longhorn-manager] time="2024-07-25T21:44:39Z" level=warning msg="=====> In syncShareManager with state starting" func="controller.(*ShareManagerController).syncShareManager" file="share_manager_controller.go:333" controller=longhorn-share-manager node=eweber-v126-worker-9c1451b4-kgxdq owner=eweber-v126-worker-9c1451b4-kgxdq shareManager=pvc-781870d7-26e5-4a11-907a-f51d12acb2e8 state=starting volume=pvc-781870d7-26e5-4a11-907a-f51d12acb2e8
[longhorn-manager-sfwwt longhorn-manager] time="2024-07-25T21:44:39Z" level=warning msg="=====> In syncShareManager with state starting" func="controller.(*ShareManagerController).syncShareManager" file="share_manager_controller.go:333" controller=longhorn-share-manager node=eweber-v126-worker-9c1451b4-rw5hf owner=eweber-v126-worker-9c1451b4-kgxdq shareManager=pvc-781870d7-26e5-4a11-907a-f51d12acb2e8 state=starting volume=pvc-781870d7-26e5-4a11-907a-f51d12acb2e8
[longhorn-manager-mckzz longhorn-manager] time="2024-07-25T21:44:39Z" level=warning msg="=====> In syncShareManager with state starting" func="controller.(*ShareManagerController).syncShareManager" file="share_manager_controller.go:333" controller=longhorn-share-manager node=eweber-v126-worker-9c1451b4-6464j owner=eweber-v126-worker-9c1451b4-kgxdq shareManager=pvc-781870d7-26e5-4a11-907a-f51d12acb2e8 state=starting volume=pvc-781870d7-26e5-4a11-907a-f51d12acb2e8

I prefer this one over https://github.com/longhorn/longhorn-manager/pull/3010

@megify bacport v1.7.x

@megify backport v1.7.x

@mergify backport v1.7.x

@mergify backport v1.6.x v1.5.x


Update sbt-unidoc to 0.4.0

Codecov Report

Merging #568 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #568      +/-   ##
==========================================
+ Coverage   82.67%   82.72%   +0.05%
==========================================
  Files          72       72
  Lines        1997     1997
  Branches      147      147
==========================================
+ Hits         1651     1652       +1
+ Misses        346      345       -1

Impacted Files
Coverage Δ

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
90.74% <ø> (-0.62%)
:x:

.../core/shared/src/main/scala/io/circe/Decoder.scala
88.12% <ø> (+0.38%)
:white_check_mark:

...re/shared/src/main/scala/io/circe/KeyDecoder.scala
45.94% <ø> (+2.7%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2281f2d...4d0356a. Read the comment docs.

Hey, @n4to4, is there a reason not to merge this? It looks good to me.

Thanks @n4to4!


Restore integration-test execution

@jimma FYI, just figured out one of your PR (the one you added a new surefire execution for the json b test) accidentally disabled the whole integration-testsuite.

Merged immediately to prevent regressions. We can improve the solution in other commits, if needed.

@asoldano Can you explain why that change disabled the whole integration test suite ?

@jimma I'm not 100% sure, it has to do with mixed configuration in plugin and plugin execution, plus one of the execution being the default one. I just noticed that the build was taking way less time than before and then noticed that no test was run in that module. So I applied the same "setup" that we've been using successfully for years in JBWS (disable default execution and explicitly enable 2 new ones, avoiding mixing includes and excludes in the same execution config) and it solved the problem.


code: moving random out of runtime

Doing the runtime features work I kept stumbling on code pulling in runtime which only needed random.
This has been on my cleanup list for a while, though if I'd known how many references there were I might have left it on the list :-/
Risk Level: n/a (code move)
Testing: n/a
Docs Changes: n/a
Release Notes: n/a

/azp run envoy-presubmit

CI passing - can I get an LGTM on the tidified version?


fix build for targeting arm (android)

JNI_XXX consts change to type c_int because c_char is unsigned targeting arm.
jint, jlong should use fix length type. Now, use i32, i64 to void add dependency on libc. maybe better to use libc::int32_t, libc::int64_t

changed all numeral j{type} to fixed length types

Sorry to pull this out from under you - I switched to using the upstream jni-sys crate which already had your proposed changes in it. No need to keep duplicating effort.


New release for pypi

May I kindly ask for a new release on pypi?

Sorry, I nearly forgot that I put it there at all. I only did it once. I hope it's correct now.


Error SSR with v2.0.0-beta.3

I have the error on ssr :
ReferenceError: window is not defined
using v2.0.0-beta.3
I tried the solution:
alias: {
  'hammerjs$': 'vue-touch/dist/hammer-ssr.js'
}

But now have new error after compilation:
ERROR in app.e58c50a4d0f7aa688e35.js from UglifyJs
SyntaxError: Unexpected token: name (Hammer)

Those are two different errors, hence why I asked for separate issues. Feel free to open another issue for the second problem.

Source of the error her:
https://github.com/vuejs/vue-touch/blob/next/src/index.js#L41
solution: check if window is undefined beforehand.

hopefully solved in 2.0.0-beta.4


How to run the tracker with my own video?

Hi,
How to run the tracker with my own video?
I find the vot_2016 datasets are all pictures.Should I frame the video and give the groundtruth of first frame?

you can use
--main main_custom
and also set
--custom_dataset_root_dir /path/to/data
and the dataset needs to be converted to frames and you need to give the ground truth of the first frame.
For more details, please look at https://github.com/VisualComputingInstitute/SiamR-CNN/blob/master/tracking/do_tracking.py and/or ask here


update the readme about ffupdater

Checklist

[x] I have used the search function to see if someone else has already submitted the same bug report.
[x] I will describe the problem with as much detail as possible.

App
Thunderbird for Android
App version
8.1
Where did you get the app from?
Other
Android version
Android 14
Device model
Samsung galaxy S22
Steps to reproduce
The developer released an new version that support thunderbird on stable and beta version as you can see here:

And it works

Expected behavior
An readme update to add an link to download ffupdater (or an tutorial on how to download and update)
Actual behavior
The readme still saying that its coming soon
Logs
No response

Thanks for the reminder, I wasn't sure if the release was ready yet :) I sent a PR to update the README

Thanks


How is the mongo client closed in MongoSplitReader?

Only code to close the cursor, no code to close the connection.
should we use independent MongoClientProvider for each MongoSplitReader?.
@link3280

@gj-zhang Sorry for my late response. I was on vacation.
You're right. I checked the codes and found the connection wouldn't be closed until the job is finished. WRT to your independent MongoClientProvider suggestion, now MongoSplitReader should be one per-taskmanager, I think it's no much difference.
May I ask what trouble you encountered?

@link3280 if the source mongo table is empty. the flink program not exit.

@gj-zhang Thanks for reporting the issue. I'll try to reproduce the problem and then get back to you.


Count the divisible numbers

Gather 3 numbers: x, y and k.
Count numbers within range [x..y] (both ends are included) that are divisible by k.
Also create a function to return these numbers.
More scientifically: { i : x ≤ i ≤ y, i mod k = 0 }
Tasks:

[ ] write a function to return the number of divisible items
[ ] write a function to return a list of divisible items

Constant time is possible (O(1)) - benchmark test required.

Hi @shorodilov, I would like to work on this issue. Could you please assign this to me.

Hi @shorodilov, I would like to work on this issue. Could you please assign this to me.

done

I believe calc package is a good place to implement this functions.
Naming propose:
get_divisible_by and get_divisible_by_count.


Configure menu displays under editor scrollbar

OS X 10.11.3 Observed in Safari, Firefox, Chrome (Stable & Canary)

I believe this has been fixed in pull?

It appears fixed in Firefox, but remains in Chrome Stable & Canary, and Safari.
Tested with http://www.webpackbin.com/VkdRlq93g on OS X 10.11.3

Ready for release


Add a Micrometer metrics collector

Fixes #795
Make sure that:

[x] You have read the contribution guidelines.
[x] You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
[x] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
[x] You submit test cases (unit or integration tests) that back your changes.

Thanks a lot. Looks very interesting at first sight. Paging @shakuzen and @snicoll as that integration touches Micrometer and could be of interest for Spring Boot (or even be moved into Micrometer entirely).

Do we really need to provide this part of the metrics? Can we just provide a SPI interface. and In this way we can only provide the data by calling the SPI implementation, Let them customize the way they collect. （Of course, this is just my personal opinion）: )

@mp911de I think I've addressed all the review comments if you want to take a second pass at it.

Thank you for your contribution. That's merged and polished now.


[ADD]: BUTTON UI Components

Current Behavior
Addition of Button UI components
Desired Behavior

A  performant, extendable, highly customizable, production ready React Component that renders an animated set of 3D UI buttons. Bundled together with a social share and progress enabled components.

i would like to work on this under GSSOC'23

@thekavikumar Can you assign me this issue


Push failed when using self-managed GitLab instance.

Hi,
I am new to the python semantic release, just tried a bit but I like it.
It works all good with only one issue,
We have a self-managed GitLab instance, so when I push it pushed to the wrong url. As in the log it says
    raise GitCommandError(redacted_command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git push<EMAIL_ADDRESS>master
  stderr: 'remote: HTTP Basic: Access denied. The provided password or token is incorrect or your account has 2FA enabled and you must use a personal access token instead of a password. See https://gitlab.com/help/topics/git/troubleshooting_git#error-on-git-fetch-http-basic-access-denied
fatal: Authentication failed for 'https://gitlab.com/xxx/django-xxx.git/''

the gitlab we have is something like https://gitlab.example.com/.
Is there a way to config the remote url? Thanks!

I have not tried it yet, but looks like you have to set it in pyproject.toml:
[tool.semantic_release.remote]
type = "gitlab"
token = { env = "GL_TOKEN" }
domain = "my-gitlab.mydomain.com"
api_domain = "/api/v4"

Checkout:
https://github.com/python-semantic-release/python-semantic-release/blob/3abfb7ac216b9ad439de24fda60eca84038e850e/semantic_release/cli/config.py#L348
Seems like there still is a lot of documentation missing in this regard.

Hi @domste ,
Thanks for the hint, it works after setting it in the config file! You saved my day!

Wow, another thing to add to #666