Auto update chromedriver version in Travis Job

Since most of the CI builds are failing due to the incompatibility chrome <-> chromedriver, this PR adds a slight change to the travis job config: now, the chromedriver is installed matching the currently installed chrome version. It removes the need to manually bump the chromedriver version each time a new chrome update is released.
The script follows the procedure given here: https://chromedriver.chromium.org/downloads/version-selection.
(BTW, https://travis-ci.org will be closed down for good on June 15th so you may migrate to https://travis-ci).

I really like this PR! :) @pbylicki would You have some time to switch to travis-ci form travis.org?


Added CosmicGameStorage.startingBidPriceCSTMinLimit. Plus other mostly related refactorings.

Closing this PR without a merge. Will create another one.


Update Ubuntu CI legs to test on Ubuntu 24.04

Ubuntu 24.04 was released on 2024-04-25. The Ubuntu CI legs should be update to test on it.

Superseded by https://github.com/dotnet/source-build/issues/4399


add namespace check for uid/gid mappings

Signed-off-by: Ma Shimiao<EMAIL_ADDRESS>

bf50b73b looks good to me.  It's taking the (b) approach from 1,
even though the current spec wording doesn't quite match that
interpretation.  But it matches the ocitools existing namespace
validation logic, and we can revisit all of that if 1 ends up being
resolved in a different direction.

LGTM


fix: Visibility of showing papers while approval

📋 Description
Fixed the CSS styling in stk_papers.ejs for better visibility of showing the papers while approval and improved responsiveness among all devices.
🔨 Changes Made

Changed the position of container from absolute to fixed.
Added media query for phones and tabs to improve responsiveness.

✅ Checklist
Before submitting the PR, please make sure you have completed the following:

[x] I have followed all the guidelines mentioned in CONTRIBUTING.md.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation (if applicable).
[x] I have tested it locally and it works fine.
[x] Any dependent changes have been merged and published in downstream modules.

🏷 Types of Changes
What type of changes does your code introduce? (Check all that apply)

[x] Bug fix (non-breaking change which fixes an issue) 🐛

[ ] New feature (non-breaking change which adds functionality) ✨

[x] UI enhancement (non-breaking change which enhances UI) 🎨

[ ] Documentation update 📚

Fixes #134

📸 Screenshots (if applicable)

Desktop/laptop

Phone

Tab

Thank you for contributing to Research Nexus! We look forward to reviewing your PR and getting it merged!

@Harshdev098 I have made the required changes. Please review it and add the hacktoberfest, hacktoberfest-accepted, gssoc-ext and level2 tags.


adapt to CRI

kubectl-debug only support docker as container runtime now. We should use CRI for container operations.

Hi! Any progress with CRI?

Hi! Any progress with CRI?

Thanks for the ping😜, this work has not yet been started. And hopefully I will have time to work on this in Mar😄

I think #99 fixes this, though we did adopt CRI but we effectively abstract an interface of different container runtime


Change popups into bottom screen modal slider

@anniinakovalainen add more info

@Rikuoja I started working on this last night. I will push some (possibly draft) PR later on.


AttributeError: 'FileDataset' object has no attribute 'SOPClassUID'

Hello,
Thanks for this package.
I'm getting this error:
AttributeError: 'FileDataset' object has no attribute 'SOPClassUID'
I checked and my dicoms do not have this attribute
Thanks

Sorry for my late replying...being extremely busy recently.
I wrongly assumed the tag is universal.
Please update to the new version
pip install -U dicom2jpg
Hope it will fix this problem


Some scripts reference to a malicious package "child_process"

Prerequisites
Please answer the following questions before submitting an issue.
YOU MAY DELETE THE PREREQUISITES SECTION.

[x] I am running the latest version of Node and the tools
[x] I checked the documentation and found no answer
[x] I checked to make sure that this issue has not already been filed

There is an NPM package called "child_process" which is marked as a malicious package by Snyk and also the NPM listing points to https://github.com/npm/security-holder
I've just found that this package is used/installed by the following Office Addin packages/scripts:
./packages/office-addin-node-debugger/package.json:25:    "child_process": "^1.0.2",
./packages/office-addin-debugging/package.json:26:    "child_process": "^1.0.2",
./packages/office-addin-dev-certs/package.json:35:    "child_process": "^1.0.2",
./packages/office-addin-dev-settings/package.json:27:    "child_process": "^1.0.2",

I'm not sure how those packages can even work without fulfilling that external "child_process" dependency, but there is a stable implementation of similar functionality directly in Node.js: https://nodejs.org/api/child_process.html - so maybe it's time to migrate to that internal Node.js implementation?

Thanks for pointing this out . . . we'll make the change.

This should be fixed


feat(ingestion/tableau): introduce project_path_pattern

Description
We have the need to exclude certain projects and all their nested projects from the ingestion. Unfortunately, this is not possible with the current project_pattern as this currently allows a project to be ingested if the project name OR the project path is allowed by the pattern, see:
https://github.com/datahub-project/datahub/blob/74a543db3fe6773443a7d63b2e45598e06b79286/metadata-ingestion/src/datahub/ingestion/source/tableau.py#L690-L692
For example, if you have a project structure as follows: Project1/Nested1/Test1, Project1/Nested1/Test2, Project1/Nested2/Test1 and you would like to deny "Nested1" and all its nested projects, we couldn't find a way to do this. Using a regex like ^.*Nested1.*$ in the deny section of project_pattern would still ingest the nested projects because the project name is allowed. And a project is allowed if either the name or the project path is allowed.
This PR introduces a new config property project_path_pattern that exclusively checks the project path of a project when deciding if a project is allowed to be ingested or not. This enables the mentioned use case to be configured.
The current implementation of project_pattern also seems to have some flaws that I would like to discuss with you (see comments).
Let me know what you think.
Many thanks.
Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

New Features

Introduced the ability to filter Tableau projects based on their full path using project_path_pattern, supporting both allow and deny patterns via Regex.

The fields project_pattern and project_path_pattern might cause confusion for users. Please implement the following changes:

Mark project_pattern as deprecated and recommend using project_path_pattern going forward. refer _deprecate_projects = pydantic_field_deprecated("projects") in tableau config
Add validation to ensure project_pattern and project_path_pattern are mutually exclusive.

I guess they both serve different purposes and that's why I wouldn't just deprecate project_pattern. As mentioned in one of my previous comments (https://github.com/datahub-project/datahub/pull/10855#discussion_r1666570438) I think it would make sense to completely separate project_path_pattern and project_name_pattern to avoid these issues. But this would break backwards compatibility to current ingestions unfortunately. But if feels a bit strange to me that the project_pattern checks for both the path and the project name. What do you think?

The fields project_pattern and project_path_pattern might cause confusion for users. Please implement the following changes:

Mark project_pattern as deprecated and recommend using project_path_pattern going forward. refer _deprecate_projects = pydantic_field_deprecated("projects") in tableau config
Add validation to ensure project_pattern and project_path_pattern are mutually exclusive.

I guess they both serve different purposes and that's why I wouldn't just deprecate project_pattern. As mentioned in one of my previous comments (#10855 (comment)) I think it would make sense to completely separate project_path_pattern and project_name_pattern to avoid these issues. But this would break backwards compatibility to current ingestions unfortunately. But if feels a bit strange to me that the project_pattern checks for both the path and the project name. What do you think?

I preferred project-path based ingestion because of following reason:

project-path is inherently unique whereas project-name is not unique and it can lead to ambiguity when multiple projects have the same name
project-name losses the context about it location whereas project-path is context aware and allow us to retain the hierarchical structure and allows us to better organize and locate projects, especially in environments with complex project trees
As tableau instance is grows, the likelihood of having duplicate project names increases, leading to challenges in scaling metadata ingestion pipeline.

so better to have a one way of doing the things to avoid confusion later.

The fields project_pattern and project_path_pattern might cause confusion for users. Please implement the following changes:

Mark project_pattern as deprecated and recommend using project_path_pattern going forward. refer _deprecate_projects = pydantic_field_deprecated("projects") in tableau config
Add validation to ensure project_pattern and project_path_pattern are mutually exclusive.

I guess they both serve different purposes and that's why I wouldn't just deprecate project_pattern. As mentioned in one of my previous comments (#10855 (comment)) I think it would make sense to completely separate project_path_pattern and project_name_pattern to avoid these issues. But this would break backwards compatibility to current ingestions unfortunately. But if feels a bit strange to me that the project_pattern checks for both the path and the project name. What do you think?

I preferred project-path based ingestion because of following reason:

project-path is inherently unique whereas project-name is not unique and it can lead to ambiguity when multiple projects have the same name
project-name losses the context about it location whereas project-path is context aware and allow us to retain the hierarchical structure and allows us to better organize and locate projects, especially in environments with complex project trees
As tableau instance is grows, the likelihood of having duplicate project names increases, leading to challenges in scaling metadata ingestion pipeline.

so better to have a one way of doing the things to avoid confusion later.

You're right, since we can also use the new project_path_pattern to allow/deny specific projects we should be fine with just this property in the future. I'll try to implement the deprecation as you suggested.


Maven support?

Can I use this project into my maven structure?

checkout the project (git clone) then run gradle install and it will install the project into your local maven repo.
then in your pom.xml, add a dependency to : com.github.aesteve.vertx.nubes:vertx-nubes:0.1-SNAPSHOT

As soon as I'm happy with a version, I'll publish it to maven central. But I'm still working on the project at the moment.

Great, thanks!


HSEARCH-5004 Default to SqlTypes.UUID instead of CHAR for the OutboxEvent/Agent ID in databases supporting it

https://hibernate.atlassian.net/browse/HSEARCH-5004

the failed cockroach test seems to be the one failing in other branches ....
as for the mssql one -- it was an incorrect expected type, so I've updated it. new build for all DBs: https://ci.hibernate.org/job/hibernate-search/job/PR-3856/5/


Add splitCharacters to ens-utils

@djstrong I believe this requires a changeset

@djstrong I don't think you should be updating the versions in package.json manually, it's done automatically during release I think.


chore: fix lint and enable it cI

This PR fixes all the lint complaints and enables link checks on pull requests.
I also changed the shadowed GraphQL classes to use the Python convention of underscore suffix, instead of prefix.

Closes #204.


[Help wanted] Support iOS

TODO

[x] Follow https://github.com/k2-fsa/sherpa-ncnn/tree/master/ios-swift/SherpaNcnn to support iOS

Closing via #65


ICEES API documentation - user requests

This issue is to suggest that we expose documentation on cohort descriptions, clinical feature variables, environmental exposures feature variables, and binning strategies via the API. At one point, we had documentation linked out from the top left corner of the Swagger UI (see screenshot below), but this was deemed inappropriate, and so, the documentation was removed.
I've received requests from potential users (Alex's DSiP students) to expose the following in a human-readable format:

Expose cohort descriptions via ICEES+ Swagger UI
Stand-up a video tutorial of how to ask ICEES+ a query

In response, I've updated or created new documentation, which I added to this G-folder. I also reviewed the ICEES Overview page, which is linked out from the Swagger UI. While the overview points to a very outdated website, the tutorial is pretty nice (if I do say so myself!), albeit a bit outdated.
Here are my thoughts:

We should maintain the documentation within the G-folder as "living docs", so that we can more readily update them.
We should include the brief cohort descriptions as new API endpoints, similar to the Terms of Service endpoint. However, unlike the Terms of Service endpoint, I think we should include the cohort description that is specific to each ICEES instance (e.g., asthma).
We should replace the "Documentation" link within the Swagger UI with a link to the description of feature variables and binning strategies, perhaps as a new file within GitHub. I suppose we could create a new endpoint for feature variables, too, but it seems like the easier solution is to simply point to the documentation.
The ICEES Overview page was created using markdown, so we can probably add it to the API repo and point to it from the Swagger UI. Of course, I should probably first update a few outdated items.

Thoughts?

@karafecho All sounds good to me. My response to your thoughts are below:

We should maintain the documentation within the G-folder as "living docs", so that we can more readily update them.

Right, "Living docs" is necessary to keep documentation up to date, but my preference is to have the documentation in the same repo either as markdown file or pdf file, but I can see your point to have it live in the G-folder for easier update. As long as it is linked out from Swagger UI, it should be fine.

We should include the brief cohort descriptions as new API endpoints, similar to the Terms of Service endpoint. However, unlike the Terms of Service endpoint, I think we should include the cohort description that is specific to each ICEES instance (e.g., asthma).

Alternatively, if cohort description serves as documentation not specific to a dynamically created cohort, it might be better to include it as part of the documentation or just include a cohort description link to get it stand out rather than creating a new endpoint. I'll defer to you to see which way works better for users from user perspective.

We should replace the "Documentation" link within the Swagger UI with a link to the description of feature variables and binning strategies, perhaps as a new file within GitHub. I suppose we could create a new endpoint for feature variables, too, but >>> it seems like the easier solution is to simply point to the documentation.
Agreed. I think we should only create a new endpoint when it is absolutely necessary. In other words, we should not use endpoints to return documentation related content, but to only return data and analysis results.

The ICEES Overview page was created using markdown, so we can probably add it to the API repo and point to it from the Swagger UI. Of course, I should probably first update a few outdated items.

Sounds good.

Thanks for your comments, @hyi.
Re (1), I am fine with storing the documentation in the repo. In fact, I had deposited a pdf file a while back, but Patrick Wang removed it for organizational purposes, I believe. I pulled a few new exposures datasets this morning and will update the documentation before adding it to GitHub.
Re (2) and (3), I agree. Let's add/update the documentation links in the Swagger UI.
Re (5), I'll update the markdown file.

Closing tickets, as issue has been resolved.


Script to make streamers

Streamers are hard-coded in uproot, covering a superset of the types of objects we can write. (We'll never write types from Python that aren't known in C++. That wouldn't be fair: there would be no C++ classes to fill, so they'd be unusable in C++. The point of writing from uproot is to subsequently use the data in C++.)
I needs to be possible to generate this hard-coded streamer list from a script. That script would only ever be used by developers.
The script should also have a way of checking streamer version numbers because we need to generate objects according to the same streamer definitions that we put into the file. This can be manual or automatic, but the more automated, the better. It only needs to be a one-time check between the code and the generated streamers, though: no need to check anything at runtime.

I have been thinking about how this streamer generating script would work.
We do not know how to incrementally add streamers yet.
Do we want the user of the script to supply a ROOT file which has all the streamers that we want to hardcode and this script would automatically replace the hardcoded streamers in our codebase with the streamers from this new file? - Might not be the most efficient way to do this, because the user might miss out on one of the streamers that are already present.
As for version numbers, the script could match the version numbers of the streamers already in place with the new streamers in the ROOT file supplied by the user and throw an error if they don't match.

The same way the streamers were made the first time: create a ROOT file that has one of each type of object and then extract the bytes corresponding to its streamers. This has all of them as a block— no incremental merging involved (though we now know what's involved in doing that, if we need to in the future).
A useful format to output would be a Python repr string that can replace the one in uproot/write/streamers.py (or replacing this whole file). As for versions, it would be nice to output something like a JSON file to check against the versions used in TH1.py (once).

Hey @jpivarski , could you take a look at this - https://github.com/scikit-hep/uproot/blob/issue131/uproot/write/streamergen.py#L49 if you get the time? It throws an UnicodeError. I have been trying to solve it for a while now without success.
with open("allstreamers.root", "rb") as binary_file:
    binary_file.seek(start)
    couple_bytes = binary_file.read(streamerlen + 1)
streamers = "streamers = b\"" + couple_bytes.decode("utf-8") + "\""

gives the same error.

UTF-8 has a particular format: some binary sequences are invalid. There are other encodings, like Latin-1, that use all 8 bits and have no invalid sequences, but don't use that.
What you're trying to do is "escape" or "quote" the byte string so that it becomes a valid Python string. That is, all of the bytes whose value is 0 must become '\x00' and the bytes whose value is 1 must become '\x01', but bytes like 42 may remain as '*' (the corresponding ASCII value). Decoding as UTF-8 or Latin-1 will not do that. If you were successful in creating the streamers string, it would be the wrong string. If we tried to use it, it would be garbage.
Python has a quoting function; it's repr. For most types, repr creates a string that can be literally evaluated. For byte strings, it puts the "b" prefix at the beginning and adds quotation marks.
streamers = "streamers = {0}".format(repr(couple_bytes))

If you print this string and execute it, it returns the original bytes (tested with Numpy tostring/frombuffer).

(Quoting is one of the most fundamental concepts in computer science. LISP is special because it's a language built from only five basic forms, and quoting is one of those five.)

(And the philosophy of computability: Gödel's incompleteness theorem relies on the ability of a mathematical expression to quote another. "This sentence is false" quotes "this sentence.")

Yes, this is solved. I did a touch-up on your PR, mostly moving the files into a dev/ directory because it's code that would only ever be run by developers, not users. This also keeps it from being deployed when someone pip installs uproot.
Thanks!


Changed the System.Net.Http from being a dependency to being a framew…

Changed the System.Net.Http from being a dependency to being a frameworkassemblies reference for net45 builds
#31

Thanks - but I made that change already last week -- you should pull the latest first before doing a PR ;)
Still not bad for the first time!

isn't there a difference between Dependencies and Frameworkassemblies? I'm not familiar with multi-targeting however...

There is a difference - that's how it looks now.
https://github.com/IdentityModel/IdentityModel2/blob/dev/src/IdentityModel/project.json#L21-L35


Avoid duplicate code in downchunking

In the previous code, the compute function for downchunking plugins (S2PhotonPropagationBase, PMTResponseAndDAQ) has some duplicate code. While I understand this is because the chunking start/end times are different, it can be avoided by defining a function compute_chunk, and calling it to calculate the data in each chunk.
This PR should not alter the behavior of fuse and should be purely cosmetic. If the simulation results change, please let me know.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

6 of 9 (66.67%)  changed or added relevant lines in 2 files are covered.
119 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 67.507%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

fuse/plugins/pmt_and_daq/pmt_response_and_daq.py
5
6
83.33%

fuse/plugins/detector_physics/s2_photon_propagation.py
1
3
33.33%

Files with Coverage Reduction
New Missed Lines
%

fuse/plugins/detector_physics/s2_photon_propagation.py
119
56.23%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
1820

Relevant Lines:
2696

💛  - Coveralls

I don't understand why the 3.9 test passes while the 3.10 test timeout...


Fade yellow ("root") nodes slowly back to green; offer button to "bring yellow nodes back"

Make the rootness get out of the user's face, unless they want/need to see it (via a Google-style "undo" toaster or similar).

Like it - maybe even the "bring yellow nodes back" is unnecessary. I feel it would be better to let the user mark or "favorite" nodes explicitly as needed. And by "favoriting" simply updating the color is a good start, but also showing a node label for that node would probably help a lot.
I see that instead of marking what has been expanded or searched on, it may be more useful to provide some subtle visual cues that there are more links available from a node. This would let the user see when expanding would provide more information. This would not be trivial to implement though and would require more "lookahead" type queries being available to the view which means more computation.

On Wed, Aug 5, 2015 at 9:26 AM Jeffrey Baumes<EMAIL_ADDRESS>wrote:

Like it - maybe even the "bring yellow nodes back" is unnecessary. I feel
it would be better to let the user mark or "favorite" nodes explicitly as
needed. And by "favoriting" simply updating the color is a good start, but
also showing a node label for that node would probably help a lot.

The "bring yellow nodes back" would be a fair amount of coding effort in
any case, so it's good that we drop it for now.  I'll open issues for
"favoriting" a node (I'll even use the standard lit-up star UI widget for
that).
What do you mean by "node label" in this context?

I see that instead of marking what has been expanded or searched on, it
may be more useful to provide some subtle visual cues that there are more
links available from a node. This would let the user see when expanding
would provide more information. This would not be trivial to implement
though and would require more "lookahead" type queries being available to
the view which means more computation.

I recently implemented a "findLinks()" operation (in analogy to
findNodes()) so this may actually not be too difficult to do.  It would be
something along the lines of marking new nodes with an "unexpanded" flag,
and decorating those nodes with a little "hairball" of preview links.  I'll
open an issue for this feature as well.

I don't know what I mean by "node label". I would start with the unique ID but in the future you could potentially put anything there, customizable by the user.


how to get json and use it in the same time ?

hi , i'm working on s project and i get confused from something
when i have a  long playlist it take a time to have all the json information
the time depending to the number of videos inside the playlist
i saw this website he is working with ajax
http://youtubemultidownloader.com/list.php
i think he use    youtube-dl too
try to use any long playlist like this (600 video)
https://www.youtube.com/playlist?list=PL6BA2D5208E8EF161
and all the information came immediately
any idea how that is possible in youtube-dl  please ?
my server is ubuntu and i'm working on php

--flat-playlist to extract list of videos.
Extract each video separately.

i didn't  understand any thing from those what is the idea from it please ? i just get
> [download] Downloading video 1 of 11
> [download] Downloading video 2 of 11
> [download] Downloading video 3 of 11
> [download] Downloading video 4 of 11
> [download] Downloading video 5 of 11
> [download] Downloading video 6 of 11
> [download] Downloading video 7 of 11
> [download] Downloading video 8 of 11
> [download] Downloading video 9 of 11
> [download] Downloading video 10 of 11
> [download] Downloading video 11 of 11

Use it in combine with -j obviously or whatever you use.


Added support for specifying a precision with which to compare elements of AbstractDoubleArrays

This request is in relation with issue #505 . I attempted modify the containXXX and doesNotContainXXX methods from AbstractDoubleArrays.
Awaiting a review and possible recommendations on how to write the tests.

Thanks.
I would only replace the last double by an Offset<Double> to clarify the intent of this last parameter and to be consistent with DoubleAssert#isCloseTo(final double other, final Offset<Double> offset).
Add unit test following what was done in DoubleArrays_assertContains_Test and DoubleArrayAssert_contains_Test.
I'm also thinking to deprecate the existing containsXXX methods as it is best practice to give an offset.

Finished


go.dev: inconsistent imported by numbers

What is the URL of the page with the issue?
https://pkg.go.dev/search?q=mux
https://pkg.go.dev/github.com/gorilla/mux?tab=doc
What is your user agent?
Google Chrome Version 81.0.4044.138 (Official Build) (64-bit)
Screenshot

What did you do?
Searched for "mux" in pkg.go.dev
What did you expect to see?
Expected Imported by numbers in the search result and in the package page to be the same
What did you see instead?
Different Imported by numbers for the same package - 9381 vs 12162

Thanks for the feedback! We'll look into this.


Remove the parachain info

We do not need to change because I've change the Krest parachain's ID to 2241 in the config.yml


Lab_isaacparada.md

Isaac Parada's lab report for CIS 411
@trevordbunch
@hallienicholas

This is my redone assignment @trevordbunch


how to add stock molecules?

Hi,
I have installed the aizynthfinder and I noticed you are using zinc as the stock database. I am trying to add the emolecules databse into the stock as well. I have the emolecules database as a json file and I added it directly in the config.yml, however, only the first molecule in the json file was loaded. So I am writting to ask that is this the right way to add the stock database, and if not, how can I do that? Thanks very much for your help!
Best,
Hongxiang

There are some instructions in the documentation on how to create new stock files: https://molecularai.github.io/aizynthfinder/stocks.html

Closing due to inactivity


Add gauntlet tests workflow without admission control commit

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you are proposing
Add gauntlet tests workflow without admission control commit
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #64 (43d3882) into feature/without-ac (345a10f) will increase coverage by 1.66%.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##             feature/without-ac      #64      +/-   ##
========================================================
+ Coverage                 70.48%   72.14%   +1.66%
- Complexity                 2794     2927     +133
========================================================
  Files                       367      371       +4
  Lines                     18477    18624     +147
  Branches                   1401     1415      +14
========================================================
+ Hits                      13024    13437     +413
+ Misses                     4897     4612     -285
- Partials                    556      575      +19

Impacted Files
Coverage Δ

...nceanalyzer/rca/store/OpenSearchAnalysisGraph.java
100.00% <0.00%> (ø)

.../rca/admission_control/AdmissionControllerRca.java

.../admission_control/AdmissionControlClusterRca.java

...tore/rca/admissioncontrol/AdmissionControlRca.java
68.00% <0.00%> (ø)

...nalyzer/rca/configs/AdmissionControlRcaConfig.java
0.00% <0.00%> (ø)

.../util/range/RequestSizeHeapRangeConfiguration.java
88.23% <0.00%> (ø)

.../decisionmaker/actions/AdmissionControlAction.java
81.81% <0.00%> (ø)

...ensearch/performanceanalyzer/util/range/Range.java
50.00% <0.00%> (ø)

...a/admissioncontrol/AdmissionControlClusterRca.java
100.00% <0.00%> (ø)

...yzer/rca/framework/metrics/RcaVerticesMetrics.java
96.96% <0.00%> (+0.19%)
:arrow_up:

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345a10f...43d3882. Read the comment docs.


Fixed for Yosemite final and Xcode 6.1 final

Fixed for Yosemite final and Xcode 6.1 final

Thanks! But fixed in a separate commit.


feat: add route command's blueprint

addon/ng2/blueprints/routes/* provides a blueprint for installing routes.ts, configuring main.ts and adding routes to routes.ts.
The blueprint name 'routes' will be replaced by 'route' when completed.

@alxhub is this still relevant or should it be closed for now?

closing this but it'll be available as a reference.


bug: example API values are incorrect

Celestia Node version
v0.13.0
OS
macOS
Install tools
docs
Others
No response
Steps to reproduce it
Submit a blob through the CLI, it returns:
{
  "result": {
    "height": 1286715,
    "commitment": "cjtmIuILvB4ItexsJoHux/G6Yp15w6YmpSbXkSlS2ZE="
  }
}

This differs from the expected response, which the docs just show as including height, not commitment.

Expected result
This is the correct result, the autogenerated examples for node-rpc-docs.celestia.org are incorrect, though.
Actual result
{
  "result": {
    "height": 1286715,
    "commitment": "cjtmIuILvB4ItexsJoHux/G6Yp15w6YmpSbXkSlS2ZE="
  }
}

Relevant log output
No response
Notes
No response

same on current version v0.13.1:
--> Generating OpenRPC spec
{
    "openrpc": "1.2.6",
    "info": {
        "title": "Celestia Node API",
        "description": "The Celestia Node API is the collection of RPC methods that can be used to interact with the services provided by Celestia Data Availability Nodes.",
        "version": "v0.11.0"


Web Components:  Provide Fluid Form training to the DDS engineers

User Story

As a [user role below]:
DDS engineer with the Fluid Form expertise

I need to:
train my DDS team members in this skill

so that I can:
share my knowledge and support Agile processes

Additional information

Engineers to be trained:  Andy, Anna, Ariella, Gui, Ignacio, Kenny and Raph

Acceptance criteria

[ ] training meetings are conducted
[ ] follow-up support is provided as the engineers work on their Fluid Form development assignments

@asudoh If you could assign story points, that would be great.

@RobertaJHahn Done!


Fix tests on main and run tests on CI

Currently we don't execute the tests in the CI. The tests are failing on the main branch. We should run these tests for every commit including PRs.

Fixed by https://github.com/maplibre/maplibre-navigation-android/commit/41218bdb923a3ceeac68a6d053c8fd3110f53ab6


Build fail with AGP 8.0

Hi,
Please resolve issues with AGP 8.0 on Android.(’namespace’)
Thank you.

What version are you using? This was fixed in version 3.2.1

I'm using 3.2.0
I will wait for the next version.
Thank you

@navaronbracke version 3.2.1 is not available here. How should it be installed?

@Nodios I don't think @juliansteenbakker published it as a release yet.
You can use a git override in your pubspec.yaml instead:
mobile_scanner:
   git: https://github.com/juliansteenbakker/mobile_scanner.git

@Nodios Version 3.2.1 has been published for a while now. The plugin itself also uses Gradle 8 since a few versions.


Why must bind_to_thread be called before using CudaDevice on a separate thread?

It is a safe function. Are there other safe functions which are depending on this being called first in order to remain memory-safe? Are there unsafe functions which depend on this in order to remain soundly callable?

I am skeptical that this is "just how the API works". The thread-binding calls that Nvidia provides are likely concealing either thread-local initialization or single-threaded accesses. Anything expressed as "you have to do this" from a C or C++ library should probably be interpreted as an unsafe requirement until evidence is obtained that it isn't.
Note that calling bind_to_thread could return a zero-sized ThreadAccessToken that may only be created safely by the cudarc library, and then this would be used to obtain access to types that allow reaching the rest of the API surface.

Also linking to https://github.com/coreylowman/cudarc/issues/165 where we first added this for more information for ya. It was also added to address a situation where multiple CudaDevice objects were being used on a single thread
Feel free to do some digging into context management of cuda and let me know if you find something that indicates we are using it wrong.
A starting place for researching how context management works can be found here: https://docs.nvidia.com/cuda/cuda-driver-api/driver-vs-runtime-api.html#driver-vs-runtime-api


Pen Test Remidial Work

This is blocked by #189. When it becomes unblocked it will move up the backlog.


Instructions text error

Challenge Use CSS Selectors to Style Elements has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
The instruction reads:
"Ensure that your stylesheet h2 declaration is valid with a semicolon and closing brace."
Issue: the word semi-colon here should be "colon"

Hi @mattfish, thanks for reporting. The test text is correct, as per this line in the instructions:

Finally, be sure to add the semicolon to the end of each of your element's styles.

The semicolon goes before the closing brace, as such: h2 {color: red;} (from the example code in the instructions). Its purpose is to terminate a style so that multiple styles can correctly be applied to a single selector (here, h2).
There is also a colon in the style declaration, but that is not what this test checks for.
Please visit the Help chat if you need any further assistance or explanation.
Happy coding!


No compilation output

(I'm using last version 0.2.0 of ng-socket-io)
Since I update to angular5 and angular-cli 1.5, I have this error when starting my app:

ERROR in ./node_modules/ng-socket-io/socket-io.module.ts
Module build failed: Error: /usr/src/app/node_modules/ng-socket-io/socket-io.module.ts is not part of the compilation output. Please check the other error messages for details.
at AngularCompilerPlugin.getCompiledFile (/usr/src/app/node_modules/@ngtools/webpack/src/angular_compiler_plugin.js:629:23)
at plugin.done.then (/usr/src/app/node_modules/@ngtools/webpack/src/loader.js:467:39)
at process._tickCallback (internal/process/next_tick.js:109:7)
@ ./node_modules/ng-socket-io/index.js 3:25-54
@ ./src/app/app.module.ts
@ ./src/main.ts
@ multi webpack-dev-server/client?http://<IP_ADDRESS>:0 ./src/main.ts

ng serve --aot works

Make sure your tsconfig.json file looks like this:
{
  "compileOnSave": false,
  "compilerOptions": {
    "outDir": "./dist/out-tsc",
    "sourceMap": true,
    "declaration": false,
    "moduleResolution": "node",
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "target": "es5",
    "typeRoots": [
      "node_modules/@types"
    ],
    "lib": [
      "es2017",
      "dom"
    ]
  },
  "include": [
    "src/**/*",
    "node_modules/ng-socket-io/index.ts"
  ]
}

Add the index.ts file of the module to the includes section of the file, work perfectly

@DerJP this doesn't seems to do the trick
FYI @bougarfaoui

At first it wasn't working for me, but then I noticed that I needed to restart the webserver so it compiles completely. Thanks.

The problem with this is that the library is incorrectly packaged. Libraries should never ship their ts files. Here's a very good explanation, I hope you can update the library accordingly as it is really helpful and should be coded properly:
https://github.com/angular/angular-cli/issues/8284#issuecomment-341417325

@Vxrize I published a new version<EMAIL_ADDRESS>as you said, I tested it in JIT and Aot and it works just fine on both Angular and Ionic

Great, I will test it out!


"Open" button behavior different across views

Describe the bug
In List view, if admin clicks on "Open", link is opened through short link redirect, which also logs the tracking detail as well. But in Card view, it directly opens it without any tracking logs.
To Reproduce
Steps to reproduce the behavior:

Go to 'List View'
Click on 'Open' for a link which is being tracked.
See the hits count incremented.
Do the same in 'Card View'
Hits count remain the same.

Expected behavior
Both views should have the same behaviour.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

@rahul1995 thanks for pointing that out, ideally it should open the long URL just like the Card Layout, this should be an easy fix, let me know if you are interested.


Remove UIWebview reference. Deprecated

Description
UIWebview is deprecated. ITMS-90809: Deprecated API Usage - Apple will stop accepting submissions of apps that use UIWebView APIs . See documentation for more information.
Fixes
Remove reference to UIWebview

Thanks for this PR! 😄
It's nice. 👍
I'll fix CI later.

Thanks!!!!


Revert "Add support for security opts on containers"

This reverts commit aa1585bf0acbf0475ed5a8908c7a1693e13d4847.
As it turns out, the list of supported options for SecurityOpt is small and well-structured. The existing Privileges type should prove adequate to add support for seccomp and apparmor, in a subsequent change.

Let's bring this one in, while we work on finishing the details in https://github.com/moby/swarmkit/pull/3152


The log information is suggested to be omitted. . .（log信息建议省略一下。。。）

https://github.com/analysys/EasyScheduler/blob/8eefa0e947ad8052485901801665833dabe17de0/escheduler-server/src/main/java/cn/escheduler/server/worker/task/sql/SqlTask.java#L281

good idea, thx!
and if don't want to see too many log info , can set log level to warn or error !

Duplicate of https://github.com/apache/incubator-dolphinscheduler/issues/226


Teleporter Bugs!

Entities are not teleported.
Incorrect amount of energy is used.
Crashes when teleporting from lowest level in the End,

Fixed in v8.


Question about your reported 'experts' result

It's just about Lab space error.
I run the 'experts C' experiment according to your scripts, with a 4500-500 train-test split. I trained about 100k step, the eval PSNR came round 22.5. Then I use cv2.cvtColor(BGR2Lab) to convert BGR to Lab space and calculate l2 error. According to opencv document, the output Lab range is in [0, 255], but actually we need to scale 'L' channel into [0, 100]. Meanwhile, 'a' channel and 'b' channel shouldn't be scaled, instead just add an bias of 128.
Then something interesting happened. My original result in Lab(range[0, 255]) is around 52, if I scale 'L' channel only, the result will decrease to around 40, which is much higher than your reported '7.8'

But if I scale all the channels, including 'a' and 'b' channel, the result comes to 7.9, which seems more consistent with your paper results.
So I am wondering whether you scaled all the channels and report this result.
Thanks.

As far as I recall, we followed the experimental procedure of previous work for this comparison with Lab* values in [0,100]x[-127, 127]^2. We did not use the OpenCV implementation of the RGB2Lab tranform.
In particular:
https://arxiv.org/pdf/1412.7725.pdf
https://www.microsoft.com/en-us/research/wp-content/uploads/2012/10/eccv2012_final.pdf
Hope this helps!


Out of memory

When I tried to run the command " sh run_demo_ECO_Full.sh local ", the "RuntimeError: CUDA error(2): out of memory" showed up.

Maybe your gpu memory is full, lower the batch size or run the command：'nvidia-smi' to check your gpu memory


LTTextLineHorizontal nested immediately under LTPage

With the demo PDF from this page (direct link to PDF), Pdfminer.six parses a few LTTextLineHorizontal objects immediately under the LTPage object. I don't think this is expected: for instance, it breaks the script in your documentation:
from pdfminer.high_level import extract_pages
from pdfminer.layout import LTTextContainer, LTChar
for page_layout in extract_pages("demo1.pdf"):
    for element in page_layout:
        if isinstance(element, LTTextContainer):
            for text_line in element:
                for character in text_line:
                    if isinstance(character, LTChar):
                        print(character.fontname)
                        print(character.size)

with:
TypeError: 'LTChar' object is not iterable

Edit: completed the report with error message.

I have found a related issue: https://github.com/pdfminer/pdfminer.six/issues/526.
Btw, I am using Pdfminer.six v20220524.

This started happening from 20220319 version, possibly related to https://github.com/pdfminer/pdfminer.six/pull/659
Reproducible example:
import urllib.request
from io import BytesIO

import pdfminer.high_level

pdf_url = 'https://www.orimi.com/pdf-test.pdf'
pdfminer_page = list(
    pdfminer.high_level.extract_pages(BytesIO(urllib.request.urlopen(pdf_url).read()))
)[0]

text_boxes = [i for i in pdfminer_page if hasattr(i, "get_text")]
print(text_boxes)

Before 20220319 version it shows
20211012:
[<LTTextBoxHorizontal(0) 197.400,660.468,200.736,672.468 ' \n'>,
 <LTTextBoxHorizontal(1) 72.000,455.448,532.853,661.368 ' \nPDF Test File \n \nCongratulations, your computer is equipped with a PDF (Portable Document Format) \nreader!  You should be able to view any of the PDF documents and forms available on \nour site.  PDF forms are indicated by these icons: \n \nYukon Department of Education \nBox 2703 \nWhitehorse,Yukon \nCanada \nY1A 2C6 \n \nPlease visit our website at:  http://www.education.gov.yk.ca/\n   \n'>,
 <LTTextBoxHorizontal(2) 348.900,579.588,372.962,591.588 '  or  \n'>,
 <LTTextBoxHorizontal(3) 384.900,579.588,398.284,591.588 '.   \n'>]

20191107 (same result):
[<LTTextBoxHorizontal(0) 197.400,660.468,200.736,676.440 ' \n'>,
 <LTTextBoxHorizontal(1) 72.000,455.448,532.853,665.340 ' \nPDF Test File \n \nCongratulations, your computer is equipped with a PDF (Portable Document Format) \nreader!  You should be able to view any of the PDF documents and forms available on \nour site.  PDF forms are indicated by these icons: \n \nYukon Department of Education \nBox 2703 \nWhitehorse,Yukon \nCanada \nY1A 2C6 \n \nPlease visit our website at:  http://www.education.gov.yk.ca/\n   \n'>,
 <LTTextBoxHorizontal(2) 348.900,579.588,372.962,595.560 '  or  \n'>,
 <LTTextBoxHorizontal(3) 384.900,579.588,398.284,595.560 '.   \n'>]

After (20220319):
[<LTTextBoxHorizontal(0) 72.000,635.568,148.627,647.568 'PDF Test File \n'>,
 <LTTextBoxHorizontal(1) 72.000,579.588,532.853,619.968 'Congratulations, your computer is equipped with a PDF (Portable Document Format) \nreader!  You should be able to view any of the PDF documents and forms available on \nour site.  PDF forms are indicated by these icons: \n'>,
 <LTTextBoxHorizontal(2) 348.900,579.588,372.962,591.588 '  or  \n'>,
 <LTTextBoxHorizontal(3) 384.900,579.588,398.284,591.588 '.   \n'>,
 <LTTextBoxHorizontal(4) 72.000,496.848,245.380,564.048 'Yukon Department of Education \nBox 2703 \nWhitehorse,Yukon \nCanada \nY1A 2C6 \n'>,
 <LTTextBoxHorizontal(5) 72.000,469.248,389.460,481.248 'Please visit our website at:  http://www.education.gov.yk.ca/\n'>,
 <LTTextLineHorizontal 197.400,660.468,200.736,672.468 ' \n'>,
 <LTTextLineHorizontal 72.000,649.368,75.336,661.368 ' \n'>,
 <LTTextLineHorizontal 72.000,621.768,75.336,633.768 ' \n'>,
 <LTTextLineHorizontal 72.000,565.848,75.336,577.848 ' \n'>,
 <LTTextLineHorizontal 72.000,483.048,75.336,495.048 ' \n'>,
 <LTTextLineHorizontal 72.000,455.448,82.061,467.448 '   \n'>]

20220524:
[<LTTextBoxHorizontal(0) 72.000,635.568,148.627,647.568 'PDF Test File \n'>,
 <LTTextBoxHorizontal(1) 72.000,579.588,532.853,619.968 'Congratulations, your computer is equipped with a PDF (Portable Document Format) \nreader!  You should be able to view any of the PDF documents and forms available on \nour site.  PDF forms are indicated by these icons: \n'>,
 <LTTextBoxHorizontal(2) 348.900,579.588,372.962,591.588 '  or  \n'>,
 <LTTextBoxHorizontal(3) 384.900,579.588,398.284,591.588 '.   \n'>,
 <LTTextBoxHorizontal(4) 72.000,496.848,245.380,564.048 'Yukon Department of Education \nBox 2703 \nWhitehorse,Yukon \nCanada \nY1A 2C6 \n'>,
 <LTTextBoxHorizontal(5) 72.000,469.248,389.460,481.248 'Please visit our website at:  http://www.education.gov.yk.ca/\n'>,
 <LTTextLineHorizontal 197.400,660.468,200.736,672.468 ' \n'>,
 <LTTextLineHorizontal 72.000,649.368,75.336,661.368 ' \n'>,
 <LTTextLineHorizontal 72.000,621.768,75.336,633.768 ' \n'>,
 <LTTextLineHorizontal 72.000,565.848,75.336,577.848 ' \n'>,
 <LTTextLineHorizontal 72.000,483.048,75.336,495.048 ' \n'>,
 <LTTextLineHorizontal 72.000,455.448,82.061,467.448 '   \n'>]

This was introduced by: 43c8fc8557528463c99598049b7005ae96ab8084

This happens because these text lines only contain white space. Previously, all text lines with a zero width or high were added directly under the page object. After the change text lines with just white space are also added directly.
I guess it is preferable if the hierarchy is always the same. Always LTPage -> LTTextBox -> LtTextLine -> LTChar.
The empty textlines on this line (https://github.com/pdfminer/pdfminer.six/blob/master/pdfminer/layout.py#L949) need to be wrapped in a LTTextBox.

I'm picking up this issue.

This commit fixes the issue, but I'm unsure if it's the ideal way.
I tested the code with @lifepillar 's code and manually checked the hierarchy of the LT Objects.
But I'm getting tests/test_layout.py:130: AssertionError and tests/test_layout.py:148: AssertionError while running nox because the tests have hardcoded assert len(textboxes) == 3 and are throwing AssertionError: assert 7 == 3.

@KunalGehlot Can you create a PR with that specific commit such that I can review and merge it?


Visualize case + ensemble members

It would be neat to have something similar to a dask task graph, similar to this

for the catalog building (helping to visualize experiments and their branches) - example would be the CESM-LE, where we could have the experiment, number of ensemble members, components within each, and streams. This be helpful when visualizing what is all in the catalog.

My question is "how do we accomplish this" :) ?

The visualization part is simple (via py-graphviz) once we have the graph. So, how do we construct the graph and what level of granularity should we aim for?

I think to start, it would be helpful to have a "default" of case --> member_id --> stream --> list of variables maybe?
What is required for py-graphviz to construct the "graph"? A dictionary?

What is required for py-graphviz to construct the "graph"? A dictionary?

A dict of dicts is the simplest interface but you could use the built-in Graph object, too

Perhaps something like this

I am considering adding the following as part of a blog post on ESDS - would this block make sense? As well as the visual?
# Create Digraph object
dot = Digraph(graph_attr={'rankdir':'LR'})

num_node = 1

# Loop through the different experiments
for experiment in df.experiment.unique():
    exp_i = num_node
    dot.node(str(exp_i), label=experiment)
    num_node+=1
    for component in df.loc[df.experiment == experiment].component.unique():
        comp_i = num_node
        dot.node(str(comp_i), label=component)
        dot.edge(str(exp_i), str(comp_i))
        num_node+=1
        for frequency in df.loc[(df.experiment == experiment) &
                                (df.component == component)].frequency.unique():
            freq_i = num_node
            dot.node(str(freq_i), label=frequency)
            dot.edge(str(comp_i), str(freq_i))
            num_node+=1
        comp_i+=1
    exp_i+=1

Here's an example of part of the output (output is a svg file)


Arrow keys (e.g. right) doesn't stop and pause at the last slide. Reverse one item is performed

Hi!
I try to achieve the following behavior on my slider: When user goes to the last slider using right arrow from keyboard, when pressing again right arrow the slide should stay unchanged. The opposite should happen when you reach the first slide using left arrow. Currently, reverse slide a step back or forward is applied in each case.
My configuration:
jssor_slider1_starter = function (containerId) {
            var options = {
                $FillMode: 1,										//[Optional] The way to fill image in slide, 0 stretch, 1 contain (keep aspect ratio and put all inside slide), 2 cover (keep aspect ratio and cover whole slide), 4 actuall size, 5 contain for large image and actual size for small image, default value is 0

                $AutoPlay: false,                                    //[Optional] Whether to auto play, to enable slideshow, this option must be set to true, default value is false
                $Loop: 0,                                            //Enable loop(circular) of carousel or not, 0: stop, 1: loop, 2 rewind, default value is 1
                $AutoPlaySteps: 1,                                  //[Optional] Steps to go for each navigation request (this options applys only when slideshow disabled), the default value is 1
                $AutoPlayInterval: 4000,                            //[Optional] Interval (in milliseconds) to go for next slide since the previous stopped if the slider is auto playing, default value is 3000
                $PauseOnHover: 1,                               //[Optional] Whether to pause when mouse over if a slider is auto playing, 0 no pause, 1 pause for desktop, 2 pause for touch device, 3 pause for desktop and touch device, 4 freeze for desktop, 8 freeze for touch device, 12 freeze for desktop and touch device, default value is 1

                $ArrowKeyNavigation: true,   			            //[Optional] Allows keyboard (arrow key) navigation or not, default value is false
                $SlideDuration: 600,                                //[Optional] Specifies default duration (swipe) for slide in milliseconds, default value is 500
                $MinDragOffsetToSlide: 20,                          //[Optional] Minimum drag offset to trigger slide , default value is 20
                //$SlideWidth: 800,                                 //[Optional] Width of every slide in pixels, default value is width of 'slides' container
                //$SlideHeight: 400,                                //[Optional] Height of every slide in pixels, default value is height of 'slides' container
                $SlideSpacing: 0, 					                //[Optional] Space between each slide in pixels, default value is 0
                $DisplayPieces: 1,                                  //[Optional] Number of pieces to display (the slideshow would be disabled if the value is set to greater than 1), the default value is 1
                $ParkingPosition: 0,                                //[Optional] The offset position to park slide (this options applys only when slideshow disabled), default value is 0.
                $UISearchMode: 1,                                   //[Optional] The way (0 parellel, 1 recursive, default value is 1) to search UI components (slides container, loading screen, navigator container, arrow navigator container, thumbnail navigator container etc).
                $PlayOrientation: 1,                                //[Optional] Orientation to play slide (for auto play, navigation), 1 horizental, 2 vertical, 5 horizental reverse, 6 vertical reverse, default value is 1
                $DragOrientation: 1,                                //[Optional] Orientation to drag slide, 0 no drag, 1 horizental, 2 vertical, 3 either, default value is 1 (Note that the $DragOrientation should be the same as $PlayOrientation when $DisplayPieces is greater than 1, or parking position is not 0)

                $ArrowNavigatorOptions: {
                    $Class: $JssorArrowNavigator$,              //[Requried] Class to create arrow navigator instance
                    $ChanceToShow: 1,                               //[Required] 0 Never, 1 Mouse Over, 2 Always
                    $AutoCenter: 2,                                 //[Optional] Auto center arrows in parent container, 0 No, 1 Horizontal, 2 Vertical, 3 Both, default value is 0
                    $Steps: 1                                       //[Optional] Steps to go for each navigation request, default value is 1
                }
            };

I guess you are using an old version. In current version, the right arrow will hide at last last slide.
Please download the latest.

Thank you a lot! It seems that you update too often (and that's good) ;)
I realized that jssor.js is not offered minified is there any reason for that or it is bundled and minified with other file?

You are right.
Jssor.slider.mini.js = (jssor.js + jssor.slider.js)


Update UG

Update phrasing and picture

Codecov Report
Base: 68.52% // Head: 68.52% // No change to project coverage :thumbsup:

Coverage data is based on head (643dace) compared to base (6188727).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #147   +/-   ##
=========================================
  Coverage     68.52%   68.52%
  Complexity      505      505
=========================================
  Files            86       86
  Lines          1614     1614
  Branches        157      157
=========================================
  Hits           1106     1106
  Misses          450      450
  Partials         58       58

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fix exception in library initialization in mono

In mono TryLoadFromDirectory throws an Exception.
Added a try/catch to avoid the crash.

Can you say more about the context in which you are receiving this error?
What platform is it happening on?
That particular piece of code is supposed to be explicitly Windows-specific, so your mention of Mono is confusing.

Sorry, we were using an old version and the pull request is no longer needed.
The "experimental change" in that section of the code works properly.


Custom primary keys with custom remoteKey values cause incorrect sync behavior

When an attribute of an entity has both hyper.isPrimaryKey and hyper.remoteKey defined, an incorrect value is used for fetching existing objects from the database. -[NSEntityDescription(Sync) sync_remoteKey] doesn't take the hyper.remoteKey property into account.
For example, in my use case, I have a local property "imageId" and a remote JSON property for the primary key of "ImageId". I have "ImageId" stored under hyper.remoteKey for this property. sync_remoteKey then takes the value from sync_localKey, which is the correct "ImageId" string and pushes it through hyp_remoteString which changes it to "image_id", which isn't present in the JSON. As a result, no remote IDs are located, no local objects can be fetched, and updates and deletions never happen.

Hi Ben!
Thanks for reporting this issue, I'll see if I can reproduce it.
Is there any reason why you would need to use imageId instead of the default remoteID?

Nope, no particular reason for the naming on the local side, that's just what was used when I wrote the original data layer.

Fair enough :grin:

I've got a partially complete fix locally, let me polish it up a bit and I can send over a PR.

@bmnick fantastic! Would be great to hear what do you think about us uppercasing acronyms? Looks like you use imageId while we use imageID.
https://github.com/hyperoslo/NSString-HYPNetworking#acronyms

I'm not opposed to either case style. Convention here at work is for objectId, but I believe that objectID is more conventional in Cocoa/Cocoa Touch overall. Downsides of working at a primarily non-iOS shop... :confused:

@bmnick Does your JSON looks like this?

[
  {
    "ImageId": 0,
    "url": "http://sample.com/sample0.png"
  },
  {
    "ImageId": 1,
    "url": "http://sample.com/sample1.png"
  },
  {
    "ImageId": 2,
    "url": "http://sample.com/sample2.png"
  }
]


/admin - ability to disable events

There is already a similar functionality to ban users or remove posts.
This is needed because sometimes there are events that are just noise, since they are not tech related.

Solved by introducing rails_admin
Thanks @vigliag


Backport PyPA link fix to v1.35.x

Backports #25647

The backport commit contained many unwanted changes like clang version, base image, Python version, also Twisted has deprecated 27 and created multiple small packages, so it's hard to find a right combination. The original backport is force merged, this PR is no longer needed, closing.


Feature Request: NSTableView

This would be a very nice addition for data-heavy applications. Using a Material UI table with other mac widgets just won't look right.

Appears this is also captured by https://github.com/GroovinChip/macos_ui/issues/199


Generalize emerald tables to multiple runtimes

Generalize former emerald tables so they can store data from multiple runtimes:

adds a runtime column to all of them
renames them appropriately
udpates SQL queries appropriately

This is the first step towards https://app.clickup.com/t/3u9y285
The main benefit of this PR is that we can support new runtimes without copy-pasting CREATE TABLE and CREATE INDEX from e.g. Emerald.
The first two commits are only vaguely related to the rest of the PR:

The first one improves the ergonomy of e2e regression tests, so I was able to test every change.
The second one adds an ORDER BY to all SELECT statements that use LIMIT. Without ORDER BY, an arbitrary subset is returned, which is a serious bug for windowed queries. Thanks, regression tests (they found this bug because the API output was not stable).

TODO:
Testing:
Before and after this PR, indexed 200 blocks of emerald. With tests/e2e_regression/run.sh, compared the API output for endpoints that exercise most of the API (see list in run.sh). No regressions/changes detected.

looking good so far. any other testing you want to do?

I'm doing the tokens part in #284 fyi

looking good so far. any other testing you want to do?

I think the regression testing is good enough for now. It makes me pretty confident that all the SQL is valid. As for correctness ... the regression test also checks for that pretty ok, I think it' relatively hard to mess up beyond that. The exceptions are mistakes around missing a WHERE or a JOIN condition that involves the new runtime column. I think I did them all correctly, but I'll also test that once I have enough generalization to instantiate two emerald analyzers. The plan is to name them "emerald1" and "emerald2" or something, then run emerald1 to height X and emerald2 to height Y. Then regression test their outputs against a standalone analyzer that runs to height X (or Y). That will convince me further that there's no crosstalk across runtimes.

I have now confirmed that tests pass.

I'm doing the tokens part in #284 fyi

Yes, I noticed that the new table is already runtime-agnostic, thank you. For the existing runtime_tokens table, I think the merge conflict will be pretty light :crossed_fingers:

I'll also test that once I have enough generalization to instantiate two emerald analyzers

Hah, I did find an error that would only show up once we have multiple active runtimes: The FKs into runtime_blocks were all referencing the round, not the (runtime, round) pair. Fixed now.


Decode SSLResponse message + Support Keys in UpdateResult

can you make two PRs instead of one ? this PR mixes two concerns, it should'nt be the case

Ok


Add macOS support version in Package.swift

We can support macOS 10.15 and above for now.

Hi,
please help me:
I just added package to own project and got this error:
The package product 'GTMAppAuth' requires minimum platform version 10.11 for the macOS platform, but this target supports 10.10
How to resolve it?
Thanks!

That's because GSI doesn't reconcile these. After I merge this changes these errors will go away. Right now GSi doesn't support macOS, but it is coming soon.


[vcpkg-tool] 2024-09-18 Release is broken

config-x64-windows-release-out.log
Build works fine with the https://github.com/microsoft/vcpkg-tool/releases/tag/2024-08-01 release

E:\vcpkg_folders\vcpkg-tool-bisect>git bisect start
status: waiting for both good and bad commits

E:\vcpkg_folders\vcpkg-tool-bisect>git bisect good fd884a0d390d12783076341bd43d77c3a6a15658
status: waiting for bad commit, 1 good commit known

E:\vcpkg_folders\vcpkg-tool-bisect>git bisect bad 5f5da308dd1dd3cc49641c60eafff176e248a9dd
Bisecting: 8 revisions left to test after this (roughly 3 steps)
[b8b3c1b31e99343cf7685aa25aaa5d2c52e33c8d] Make comparison of installed files case-insensitive (#1483)

E:\vcpkg_folders\vcpkg-tool-bisect>git bisect good
Bisecting: 4 revisions left to test after this (roughly 2 steps)
[a65b710faf24541f51eb46eebfb22ae8079dd58f] Preserve the full exit code range in the system.process layer. (#1489)

E:\vcpkg_folders\vcpkg-tool-bisect>git bisect bad
Bisecting: 1 revision left to test after this (roughly 1 step)
[d3fc35774f86782f356ef0f9352ba857fa57302e] Keep all CUDA_PATH_* environment variables when forming the clean environment on Windows (#1476)

E:\vcpkg_folders\vcpkg-tool-bisect>git bisect bad
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[e720ee8b6d4e3353f0efc5d88b1224320fd6f398] [upgrade] Don't crash on non-installed ports (#1473)

E:\vcpkg_folders\vcpkg-tool-bisect>git bisect good
d3fc35774f86782f356ef0f9352ba857fa57302e is the first bad commit
commit d3fc35774f86782f356ef0f9352ba857fa57302e
Author: autoantwort<EMAIL_ADDRESS>Date:   Tue Sep 3 21:14:49 2024 +0200

    Keep all CUDA_PATH_* environment variables when forming the clean environment on Windows (#1476)

 include/vcpkg/base/system.h       |  2 +-
 src/vcpkg.cpp                     |  2 +-
 src/vcpkg/base/system.cpp         |  8 ++++----
 src/vcpkg/base/system.process.cpp | 33 ++++++++++++++++-----------------
 4 files changed, 22 insertions(+), 23 deletions(-)

E:\vcpkg_folders\vcpkg-tool-bisect>

https://github.com/microsoft/vcpkg-tool/pull/1476 broke it

Already noticed before the release but couldn't stop it: https://github.com/microsoft/vcpkg/issues/41199#issuecomment-2378351021

Fixed by PR #41271


test-pr

Description
Please include a summary of the change, motivation and context.

Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:

[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been merged and published in downstream modules

Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

resolved in https://github.com/hypertrace/attribute-service/pull/56


Hierarchical Task

Hello! I'm very interested in hierarchical thinking,and it's a very important thought in RL. What does "action [3] = -0.01" mean? I want to divide "fetchpush-v1" and "fetchslide-v1" into "approach" and "push". I can directly use "fetchpickandplace ddpg + her / rl_modules / ddpg_agent_manual. Py" for the skills of "push". Can you give some code guidance? Thank you very much for replying in your busy schedule!

Hi! Thanks for your interest in this work. The action[3] = -0.01 is inherent to the gripper closure that is not trained but manually set because this work aims to compare BC and DRL in learning the basic behavior such as approach, manipulate, and retract. As you can see, action[3] value changes following the subtask we are training. In the "approach" subtask, for example, we set the gripper closure to 0.05, which is a positive value and implies that the gripper is open (in general, if the value is positive, you are opening the gripper, and if it is negative you are closing the gripper. The value implies how fast you open/close the gripper. You can make some tests also using hand-engineered solutions provided by OpenAI).
For the second question, "fetchpush-v1" and "fetchslide-v1" tasks are complex to divide into approach and push/slide. I did some tests one year ago to try to reuse the "approach" subtask of "fetchPickAndPlace" for "fetchpush-v1", and the results were interesting but not so significant, maybe because I used only a fine-tuning approach. I'm dealing with other research topics now and wouldn't know how to help you more, sorry. I hope this answer was helpful to you. Greetings

Thank you very much for your reply, which is very important to me. Could you provide the code  of “fetchpush-v1" and "fetchslide-v1" hierarchical subtasks? If you can provide, please send my email<EMAIL_ADDRESS>you very much for your help!


[Maintenance] Remove Github Actions deprecations

Thanks @NoResponseMate!

Can you help to test this change by using IonBazan/composer-diff-action@master in your workflow? I'd like to make sure it works as expected before tagging a new release. Thanks in advance @NoResponseMate!

While it fixes the deprecations, it also breaks the formatting of the comment.
I'll have a fix opened for that in a few.


/bus/refresh not work in Camden.SR5

Hi, When I used the endpoints of /bus/refresh/ to refresh configuration on multiple instances(with rabbitmq), It does not work on Camden.SR5, I try the same code with Camden.SR4 and Camden.SR6, it works.
when I used Camden.SR5, I saw the rabbitmq created two exchanges:
springCloudBusInput
springCloudBusOutput
but when SR4 and SR6, it created one exchange only : springCloudBus
I see the Document did not find anything.
I see the code of class: org.springframework.cloud.bus.BusAutoConfiguration, the init method always gets the default destination for "springCloudBus".
Is there some bug in Camden.SR5?

Yes there was a bug and it is fixed in Camden.SR6 https://spring.io/blog/2017/03/10/spring-cloud-camden-sr6-is-available


Fixx: Ensure npmrc gets copied into the artifacts directory

.npmrc file is not copied into the artifacts directory, resulting in npm using the default .npmrc configuration
This PR fixes the bug

Codecov Report

Merging #596 (64f8a2e) into develop (0159c22) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #596   +/-   ##
========================================
  Coverage    64.24%   64.24%
========================================
  Files           35       35
  Lines         1351     1351
  Branches       238      238
========================================
  Hits           868      868
  Misses         483      483

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a4876...64f8a2e. Read the comment docs.

Closing this as its not necessary


Remove resize event listener on destroy

In the current setup, if you have dynamicSizing on, a resize listener gets added to window, but never removed (leaks).
This causes issues if, say, you have the image cropper in a modal, which is then closed. The resize listener keeps trying to update the canvas whenever the window is resized, but the canvas is gone, causing errors to be thrown.
It also means every time a new image cropper is spawned, another listener is added to the window.
This cleans up the window listener when the image cropper component is destroyed.

Thanks!


ReadCSV should take a Reader as input rather than a string

I've started looking at reimplementing some of the functionality of https://github.com/tobgu/qcache in Go (currently python and pandas) and found gota. Looks good, keep it up!
I think it would be better to take a Reader as input to ReadCSV than a string. As it is right now I have to read all bytes from a reader into a byte buffer that then has to be converted to a string. That string is then immediately converted into a Reader in ReadCSV.
Do you agree?

Hi @tobgu this makes complete sense. Reading from a Reader should be the preferred way of dealing with this.
In addition to this, it would also make sense that the Save methods would write to a Writer or WriteCloser for consistency and better composability.
The exception to this would be the ReadRecords/SaveRecords methods, but for other formats (CSV, JSON, XML...) it should work.

Sounds good!

I've finished with these modifications on the dev branch as of commit 48ef419800e1b5b6da58ebb2e2a6390224301de6
As a summary:

ReadCSV now accepts an io.Reader instead of a string
SaveCSV/SaveJSON now write directly to the given io.Writer instead of returning a []byte
SaveRecords/SaveMaps has been renamed to Records/Maps respectively to be consistent with the Dense method
ReadCSV/ReadMaps has been renamed to LoadCSV/LoadMaps since they don't accept readers.
SaveCSV/SaveMaps has been renamed to WriteCSV/WriteMaps for consistency with the Read* methods.
SaveMaps was not working properly and thus it has been fixed.


unable to connect to huggingface to download the model

when i run server.py . i'v got :
requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://huggingface.co/CompVis/stable-diffusion-v1-4/resolve/main/model_index.json
i'm correctly logged in with hugginface_cli and i my account has acces to the model on the site

I left a step out of the instructions. You also need to agree to share your email address with Hugging Face in order to download the model. Please see the new Hugging Face instructions in the README. (Sorry about that.)


Expected output for running caption.py

Hi,
I'm running caption.py with pretrained model just for inference. After I run the model it just outputs
<Figure size 640x480 with 10 Axes>
with a bunch of warnings which I guess it's ok to ignore. But how can I get the output option from it then?
Thanks in advance

@lisaliu1997 I also met this problem and I think it might be due to the window size. So that plt.show() did not work. To solve this, you can add one more line to the code header %matplotlib inline. My code is here:

Hope this can help you, although it might be too late now:)


Adding fastqc pipeline

Some additional code to allow access of FastQC independently of KneadData.

Coverage increased (+3.03%) to 95.625% when pulling 71a9c031ef08c916c4bb84ff4df560f6d76d6a59 on tanaes:adding-fastqc-pipeline into a35abcf8873e123ee7986533d339acecc4ab6160 on qiita-spots:master.

ok to test

Can one of the admins verify this patch?

Closing as this has been superseded.


Fix Extension Buttons

🔍 Is there already an issue for your problem?

[X] I have checked older issues, open and closed

ℹ Environment / Computer Info
Spotify for Windows (64 bit)
<IP_ADDRESS>2.g01893f92
Spicetify v2.38.5
xpui_2024-12-02_1733143341811_01893f9
cef_130.1.16+g5a7e5ed+chromium-130.0.6723.117
Runtime: Chrome
Build System: Bazel

📝 Description

bookmark.js and popupLyrics.js button does not look similar to other buttons.

But aren't they shipped with spicetify itself? they are spicetify's extensions, right?


Feature Requests

Option to specify the working drive. (basically the ability not to use the C: drive)
Option to provide your own ISO path. That way you don't need to wait for the WindowsInstaller download.

+1


Fix web compilation issues

This PR will fix https://github.com/rinukkusu/spotify-dart/issues/42, an issue that was introduced with https://github.com/rinukkusu/spotify-dart/pull/34 (my bad).
I'm making two assumptions with these changes, please call me out if either are incorrect:

There's no real reason that we need spotify_mock.dart to be part of the spotify library
We don't actually need to import dart:io or dart:html in order for http.Client() to know which type  of client to create; it just detects which library is available, not which library is imported

Testing looks good run from running unit tests and debugging in a Flutter app. However, I haven't directly tested these changes against a web app yet, which is why this is marked as a draft. 😃

Yep, just tried it out with a sample web app - looks fine, very straight forward to use also 👍

@rinukkusu

Yep, just tried it out with a sample web app - looks fine, very straight forward to use also 👍
Can you share me thet sample? I'm trying to implement this package on web but I have problems with the OAuth callback


Transpiling to ES5 causes Uncaught TypeError

Dear Ulyanov,
I want to thank you for creating this module, i do like it very much because of its lightweight size and simplicity. I recently used it for the first time and unfortunately encountered an js error when running under production mode.
I am using a gulp js minifier module which only accepts ES5, thats why i recognized your plugin been shiped as ES6 source. I did point my babel to transpile it to ES5 which worked without any error inside my dev setup. But then in the console i got the following error on this line:
if (typeof define === 'function' && define.amd) {
    define('ImageComparison', [], function() {
        return ImageComparison;
    });
} else {
    root.ImageComparison = ImageComparison;
    ^ Uncaught TypeError: Cannot set property 'ImageComparison' of undefined
}

I did double check my setup for causes, without success. Also i use two other npm modules shipped in ES5 which work perfectly. Removing the causing js block from your plugin does fix the error but corebreaks your module.
While searching your github, npm and examples page, i recognized that your example pages source js differs to the one in your github repo.
I hope to hear soon from you, i am out of ideas...
Best regards

I did create a fiddle where you can reproduce it.
https://jsfiddle.net/zhxr8k7j/1/
Best regards

heyho @skyclb
I also had problems when trying out the latest version.
The example page shows another version, you can download here. I just stayed with using this version and had no problems.
Anyway, I also like the script a lot because its touchfriendly and leightweight.


Add pgvector datastore

Closes #36

Thanks for the review @isafulf!
I addressed your comments and will run an end-to-end test of the plugin soon.


CB-7290 - No services listed for 7.2.0 Datahub blueprints

CB-7290 - No services listed for 7.2.0 Datahub blueprints

please make sure that the version numbers are correct (what is the source of those btw?)


please add to the guide that for some locations in aws config main instance type need to be changed from t2.micro to t3.micro

Probably would be best if you go ahead and make a PR yourself since as I understand it's not all regions that need this

i suggest to add also graviton instances, as they have lowest prices and better cpu/mem throughput.

I believe it's already covered by https://github.com/Arriven/db1000n/pull/403/files#diff-e0beaf635e7e58ca4243047eed9acca64a5426826fb4c19579c3fef5c6cc6cc2R22


I want to use an Alderaan Raiden Network with just paying a hub

User Story
As Chris I want to use an Alderaan Raiden Network with just paying a hub so that I can quickly get started
Acceptance criteria

Messages are compatible

New HashFunction (sha256) is used (see https://github.com/raiden-network/raiden-contracts/pull/979)
Hash of Locks instead of MerkleTree
Fee = 0
Route = Static (Light Client -> Hub)
No PFS

Hub is the target
No mediated transfers
Don’t answer to channel withdraw message
We cannot send a transfer where we don't have a direct channel
Feature branch for Alderaan
Pulling new contracts
Maintain the Red Eyes branch (pull patches from Alderaan - backporting - self-containing PRs after it has been merged to the Alderaan branch)
We don't change something in the dApp

Tasks

[ ] Create a skeleton on a different branch @andrevmatos
[ ] Adapting to the new contract

[ ] Changing the MerkleTree to an array of locks
[ ] Change the HashFunction to sha256
[ ] Check all message fields and compare with new contract
[ ] Set the route (address light client to address hub in the metadata field
[ ] Upgrade the contracts.json

Raiden message spec:
https://raiden-network-specification.readthedocs.io/en/latest/messaging.html#locked-transfer
Route
Route Metadata
metadata

Last contracts release before Alderaan  is planned for tomorrow
CC @Dominik1999

@christianbrb I went and renamed everything from Ithaca to Alderaan in the issue.

Split in #289, #290, #291, implemented in #293, #294 , #295 and #304


Allow users to plug in their own HTTP headers validator

We've been looking into ways to ensure a better support to HTTP header names as defined in RFC7230, Section 3.2.6 in Finagle. Today's header validation rules in Netty (as per DefaultHttpHeaders.java) don't prohibit ASCII delimiters (e.g., []), and, unfortunately, there is no easy way to to configure it otherwise.
One way to do that would be make a DefaultHttpHeaders constructor that also takes NameValidator public. This should allow users to opt-in for RFC7230 headers in their application code. HTTP codecs (think inbound HTTP messages), however, will still be using a default validator. Perhaps, allowing users to configure a NameValidator for HTTP codecs is a way to approach this.
I'm curious what do people think about this?

Sounds reasonable to me... @ejona86 @Scottmitch @carl-mastrangelo @trustin WDYT ?

I'm not familiar with the mentioned change in the characters permitted. Which BNF rule is now different? I see token excludes [], but that was true in RFC 2616 as well.

Oh I think you're right, @ejona86. Token is defined identically in both RFCs:
RFC7230:
token          = 1*tchar

tchar          = "!" / "#" / "$" / "%" / "&" / "'" / "*"
                    / "+" / "-" / "." / "^" / "_" / "`" / "|" / "~"
                    / DIGIT / ALPHA
                    ; any VCHAR, except delimiters

Delimiters are chosen from the set of US-ASCII visual characters not allowed in
a token (DQUOTE and "(),/:;<=>?@[\]{}")

RFC2616:
token          = 1*<any CHAR except CTLs or separators>
separators     = "(" | ")" | "<" | ">" | "@"
                 | "," | ";" | ":" | "\" | <">
                 | "/" | "[" | "]" | "?" | "="
                 | "{" | "}" | SP | HT

The feature request about allowing users to override header validator still makes sense though as today, we're neither RFC2616 nor RFC7230 compliant:
scala> import io.netty.handler.codec.http._
import io.netty.handler.codec.http._

scala> val h = new DefaultHttpHeaders()
h: io.netty.handler.codec.http.DefaultHttpHeaders = DefaultHttpHeaders[]

scala> h.add("fo@o", "bar")
res0: io.netty.handler.codec.http.HttpHeaders = DefaultHttpHeaders[fo@o: bar]

scala> h.add("[foo]", "bar")
res1: io.netty.handler.codec.http.HttpHeaders = DefaultHttpHeaders[fo@o: bar, [foo]: bar]

@vkostyukov Why don't you just disable it and verify the headers in your application?

@vkostyukov, yeah, that looks like a bug. Seems we should fix Netty.
It looks like Netty is missing quite a bit of punctuation and virtually all the control characters (yet prohibits obs-text). I did check, the HTTP parser also doesn't disallow the control characters.
That is quite a find, since those characters were prohibited even in RFC 2068:
          field-name     = token
...
          token          = 1*<any CHAR except CTLs or tspecials>

          tspecials      = "(" | ")" | "<" | ">" | "@"
                         | "," | ";" | ":" | "\" | <">
                         | "/" | "[" | "]" | "?" | "="
                         | "{" | "}" | SP | HT

@ejona86 With all my passion to fixing things that are broken, I'm somewhat skeptical we could pull this sizable behavior change in Netty, at least in 4.x. We're (Finagle) still getting beaten by Netty 3 allowing null-characters in header names today, after completing the Netty 3 -> Netty 4 migration nearly 2 years ago.
Perhaps a compromise, to allow users (us) to override the behavior via a custom header validator, would get us all into a slightly better state on Netty 4.x?

@normanmaurer, @Scottmitch, thoughts? It looks like Netty is permitting characters disallowed by all the HTTP specs, but it's been broken for a while...

Pinging this again in case it fell through the cracks: @ejona86, @normanmaurer, @Scottmitch

+1 would love to see this happen

@vkostyukov @smlance @ejona86 I would be totally up for allowing to pass in a validator but I am not strong on it... About fixing the parser I am not sure... maybe we could do it by adding a new "strict" mode. I am a bit afraid if we just fix it it may break things for users in an unexpected way.

I'm fine with adding a new strict mode. I don't want to add a validator if the primary use-case is to make Netty conform to the HTTP spec, as then that logic needs to be copied into each application.

I like the strict mode idea. As long as users would be able to opt-in for "more valid" headers (either by writing their own validator or switching over to strict) I'm happy.

@normanmaurer Maybe we can include this ticket into the Netty 5 roadmap? We'll have more room for maneuver there and, perhaps can actually support RFC7230 out of the box.

Done

I think this could be solved somewhat elegantly in Netty 4 by simply introducing overloaded constructors that replace boolean validateHeaders with an enum for RFC header validation compliance or  a custom NameValidator. The RFC enum could map to the relevant NameValidators that Netty maintains and be easy to discover for users.

@Bennett-Lynch sure if there is someone who wants to do the work ... hint


Do not check commands for wildcard characters.

PR Summary
Remove the check in CanDoPathLookup for wildcard characters in the command, as it prevents a PATH search of the command if it contains wildcard characters.
Fixes #10997
PR Checklist

[ ] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[ ] Summarized changes
[ ] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[ ] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[ ] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[ ] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

A test is now failing on Windows,  (Shouldn't it fail on MacOs and Linux too?)
Describing Use literal path first when executing scripts
  [-] 'Relative path that where module qualified syntax overlaps' should not execute 28ms
    Expected an exception, with FullyQualifiedErrorId 'CouldNotAutoLoadModule' to be thrown, but no exception was thrown.
    139:             { & $command } | Should -Throw -ErrorId $ExpectedErrorId

I actually don't understand why this test would succeed (produce an exception).  I think the wildcard was preventing it from working, and the exception thrown was misleading.

@msftrncs If the syntax is not longer treated as a module qualified invocation, then the change is breaking.

This probably doesn't fail on non-windows because of differences in handling of the file system.

Its not that the syntax is no longer treated as module qualified …   if it hadn't been for the wildcard characters, it would have executed …  if the actual path had not been found, PowerShell would have still checked for modules, but an existing file will be executed if it is found.
I do not think this breaks anything.
In the test, the file path is subFolder\[test1].ps1.
The test for this kind of path appears to occur in the same section as $env:PATH, so when the code I removed previously flagged this path as WildcardCharacters, this prevented this path from testing for DirectorySeparator.  Under DirectorySeparator the path would be tested as a relative path to a file.  With the fix, this now works as it should.
Had the file been subFolder\test1.ps1, this test would also have failed, because the file would have executed, since it would have flagged as DirectorySeparator.

Please write tests under the old code (separate PR) validating your assumptions and show that your are not breaking these scenarios.

This potentially fixes #9256.

@TravisEz13, I have submitted PR #11225, though I do not know if it meets your criteria.  After submitting that PR, I became aware of #9256, which is exactly the issue being raised in this potential breaking change.

Can you please write up an summary of the use cases that you are trying to fix and why?  I don't feel like I have enough information to send this to the committee for review.

@TravisEz13 #10997 contains full and clear description and examples.

#10997 contains full and clear description and examples.

Where?


Mention the use of the '--force' flag when raising WrongArgs error

Closes #266

Codecov Report
Base: 81.88% // Head: 81.88% // No change to project coverage :thumbsup:

Coverage data is based on head (6390662) compared to base (fb35551).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #267   +/-   ##
=======================================
  Coverage   81.88%   81.88%
=======================================
  Files          16       16
  Lines        1905     1905
=======================================
  Hits         1560     1560
  Misses        345      345

Impacted Files
Coverage Δ

gto/registry.py
74.89% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Thank you @jellebouwman! Good idea. Merging!


Clicking on messages to see the details or clicking on "Repair and resubmit" fails in 4.1.111

I am not able to click on messages in Message List to see their details or "Repair and resubmit" DLQ messages in 4.1.111. It shows  Exception: The item argument cannot be null. in log window.
Tested with 4.0.110 and everything works as expected.
Cheers.

@batizar I've just tried 4.1.111 and it worked.
Click Deadletter then "Peek top 10" then double-click on any message brings "Repair and Resubmit Messages" window. Was able to update and resubmit a message.

This is a symptom of #310.
I have submitted a PR with my code fixes.

Fixed via https://github.com/paolosalvatori/ServiceBusExplorer/commit/4706ba915ae70f1246772fca4702c88996c603c7


Scenes with all channels set to zero don't light buttons

Reproduce:

Given any fixture is added
Given Scene A and B exists
Given Scenes A and B use a single channel of any fixture
Given Scene A sets it to zero
Given Scene B sets it to any non-zero value
Given two Buttons A and B in solo-frame (it's not solo frame specific, but this illustrates issue nicely)
Given Button A activates Scene A
Given Button B activates Scene B
I expect that pressing button B will activate (light up) Button B and deactivate Button A - this works
I expect that pressing button A will activate (light up) Button A and deactivate Button B - this doesn't

It also happens if for example I have a chaser going through Scenes A and B and buttons attached to these function - button B will light up, A - won't.
I'll provide a test workspace as soon as I get my hands on working QLC+ (I noticed this last night on event that I've ran).

This might be related to the fact that setting HTP channel to zero is no-op. Nevertheless, it should at least deactivate button B.

@janosvitok it deactivates button B. I'm sorry I didn't state it correctly.

This might be related to the fact that setting HTP channel to zero is no-op. Nevertheless, it should at least deactivate button B.

Yes, I thought about that, but couldn't check it since I broke my Qt environment :c
This should be the demo console: https://pastebin.com/1ckrSX2V
BTW. I'm not sure if it's issue with my environment (which it might, cause I messed up Qt lib installs), but latest git version of QLC+ crashes when trying to start chaser from button. (for example when running chaser in provided console)

I think the behavior has changed with the latest sources.
Looks kind of correct to me now


How to add empty option to select

Hi,
I'm trying to add an empty option to a select on a form, but I'd like some thoughts on how to do that properly.
Currently adding a caption will not add a empty option.
This code will result in the image below.
my_form.select_list(name: :some_name,
                              label: :thumbnail_page_video
                              caption: :label_select_one_option) do |field|

What I'm doing is adding an empty option hardcoded
field.option(label: "", value: "")
add_more_options_based_on_a_list

Although it looks small and simple, any thoughts on how to improve it?
Best,

Hey @raivil, it looks like the way to add a blank option is to pass include_blank: true to the select method on the Rails form builder. Due to a bug, the SelectListInput class doesn't currently pass these arguments on to Rails, but #1505 should fix that.

thank you, @camertron!


addMultiplier() is not working

Error: Control or Container items expected, [Nette\Application\UI\Multiplier] given.
I think it should be replaced by contributte/forms-multiplier.

for Multiplier functionality, use the new AJAX-less FormCollection through addCollection() method. It is available since v3.0


Media Gallery Thumbnail For Image Missing Until Refresh (Gitlab Self-hosted Repo)

Describe the bug
When a new image is uploaded to the Media Gallery, no image is displayed for it until the page is refreshed.
To Reproduce

Upload an image to the media gallery (.png or .jpg)

Expected behavior
An image appears as a preview for the image file.
Observations

No error in console
Element html doesn't contain an  element:

dawg.jpg

If image is added it is correctly rendered inline.
If Media Gallery is reopened it is still not rendered.
It will only be rendered after a page refresh.
Looks like this is related to #993. Either a regression or something that was never fixed for Gitlab

Screenshots
After Upload:

After Page Refresh:

Additional
Refreshing the page causes its own problems. After a page refresh, any images that were uploaded subsequent to the most recent deploy will be broken. Although the path is correct, there is no image at that location. The images will only work after a new deploy, at which point images do exist at the same paths. I've noticed some mention of this is other issues, but there doesn't appear to be an issue that captures this problem. Should I file a separate issue for it?
Applicable Versions:

Netlify CMS version: netlify-cms 2.3.2
Git provider: Gitlab
OS: OSX
Browser version: 71.0.3578.98
Node.JS version: 8.11.3

CMS configuration
backend:
  name: gitlab
  repo: company/repo
  auth_type: implicit
  app_id: XXXXXXXXX
  api_root: https://gitlab.comnpany.com/api/v4
  base_url: https://gitlab.comnpany.com
  auth_endpoint: oauth/authorize
  slug:
    clean_accents: true
    sanitize_replacement: '-'
media_folder: static/images/uploads
public_folder: /images/uploads

I had not noticed that they are missing until the next deploy because my infrastructure autodeploys. So I am just adding my me-too comment here -- I am living with this, and since my infra auto-deploys it typically takes less than 30 seconds for the images to be available on a refresh, but it's kind of an ugly "feature" for a non-technical-user to have to accept.

We used to hold onto the local file object and reuse that, but if you refreshed before your deploy completed, the image was gone, and the experience was even more confusing because it was working at first.
The route we've been using instead is to pull the image through the API, but it's a pain when the image is huge, so we need to augment with generating thumbnails and pushing those to the backend in some sort of remote cache.

I'm having the same problem.

Not stale. Still an issue.

What's the best workaround for this? Experiencing the same issue.

I this still happening? A lot had changed in regards with asset management in the CMS since this was opened

Closing, please comment if still relevant


Add roc test --ignore-error flag

closes #6622
adds new flag to allow tests to be run even if build errors occurred, like roc run

@Anton-4 ci checks got blocked earlier as some commits are "partially signed", can you sign it again?

@Anton-4 ci checks failed earlier as some commits are "partially verified", can you sign it again?

I believe there was also a failure in the wasm tests but I'll run CI again and we'll see what happens :smile:


请问SEMA的相关代码在哪个位置？

请问SEMA的相关代码在哪个位置呢，没使用过openmixup。

I apologize for the delayed response. You can find the source code for Switch EMA in detection/mmdet_custom/core/hook/switch_ema.py.
Furthermore, we will continue to update the open-source activities in this repository.

请问SEMA的相关代码在哪个位置呢，没使用过openmixup。

I apologize for the delayed response. You can find the source code for Switch EMA in detection/mmdet_custom/core/hook/switch_ema.py.
Furthermore, we will continue to update the open-source activities in this repository.


Fix billing

Some fixes to billing page.
Fixed lists
Changed headers to be per service
Fixed project => Scratch disk

Seems ok.


chore: first try of dnd upload

fixes: #56
Already working

[x] HTML file upload
[x] Upload of (nested) folders
[ ] Upload only into existing projects (for now)
[x] filtering of unwanted files
[x] Asset files upload
[ ] UI updated correctly
[ ] UI feedback (toast or other visualization of uploaded files)
[ ] Error handling

Test:

https://import-dnd--da-live--adobe.hlx.live/

Stale & implemented.