key lazyloading with which-key.nvim needs to be used twice

Describe the bug
I need to press <space>cc twice to actually make it work
the first time it isn't mapped
Which version of Neovim are you using?
NVIM v0.9.0-dev-525+ga7332ba9b
To Reproduce
Steps to reproduce the behavior:

`nvim -u repro.lua repro.lua
<space>cc
<space>cc

Expected Behavior
line gets commented out on 2.
Log
Please include any related errors from the Noice log file. (open with :Lazy log)

Lazy log

lazy.nvim (H)   Install (I)   Update (U)   Sync (S)   Clean (X)   Check (C)   Log (L)   Restore (R)   Profile (P)   Debug (D)   Help (?)
Total: 60 plugins
Breaking Changes (1)
● lazy.nvim 18.74ms   init.lua
b7c489b fix(loader): lua modules can be links instead of files. Fixes #66 (55 minutes ago)
7a57ea2 chore(build): auto-generate vimdoc (74 minutes ago)
c228908 fix(health): don't show warning on module=false (75 minutes ago)
b68f94b ci: Update issue templates (2 hours ago)
bbebb67 ci: Update issue templates (2 hours ago)
95fc814 chore(build): auto-generate vimdoc (2 hours ago)
876f7bd feat(loader): allow to add extra paths to rtp reset. Fixes #64 (2 hours ago)
a345649 fix(cache): if we can't load from the cache modpath, find path again instead of erroring right away (2 hours ago)
bbace14 fix(git): only mark a plugin as dirty if an update changed the commit HEAD. Fixes #62 (3 hours ago)
a939243 fix(checker): allow git checks only for non-pinned plugins (#61) (3 hours ago)
57bea32 chore(build): auto-generate vimdoc (3 hours ago)
ff24f49 fix(loader): source rtp /plugin files after loading start plugins. Fixes (3 hours ago)
b802729 chore(build): auto-generate vimdoc (6 hours ago)
9dfefac docs: fixed indentation of auto-generated code blocks (6 hours ago)
71b2e2f docs: lazy works on all OSs now (6 hours ago)
232232d fix(ui): install command can have plugins as a parameter (6 hours ago)
4ca3039 feat(loader): warn when mapleader is changed after init (7 hours ago)
540847b fix: strip / from dirs. Fixes #60 (7 hours ago)
86eaa11 fix(git): dereference tag refs. Fixes #54 (7 hours ago)
e95da35 feat(util): utility method to get sync process output (7 hours ago)
3c3a711 chore(build): auto-generate vimdoc (8 hours ago)
44f80a7 feat(plugin): allow plugin files only without a main plugin module. Fixes #53 (8 hours ago)
f5734f5 chore(build): auto-generate vimdoc (9 hours ago)
3814883 fix(ui): set current win only when its valid (9 hours ago)
3a7b8c8 chore(main): release 5.1.0 (#30) (18 hours ago)
3606d62 fix: add after directories to rtp to make after/ftplugin and others work. Fixes #47 (18 hours ago)
b193f96 fix(spec): only process a spec once (18 hours ago)
7be46bc style: removed unused requires (19 hours ago)
897d6df fix: add filetype to window buffer. (#41) (20 hours ago)
14300b3 chore(build): auto-generate vimdoc (20 hours ago)
78e9d6c docs: add a note about mapleader (20 hours ago)
06ac8bd perf(ui): clear existing extmarks before rendering (21 hours ago)
ffcd0ab fix(loader): source filetype.lua before plugins. Fixes #35 (21 hours ago)
9d12cdc fix(git): don't run git log for submodules. Fixes #33 (21 hours ago)
06ffcf5 chore(build): auto-generate vimdoc (22 hours ago)
7fb0652 docs: added docs on update checker (22 hours ago)
1f86cb3 chore(build): auto-generate vimdoc (22 hours ago)
3cffb2a docs: added change detection to the readme (22 hours ago)
6c767a6 feat: added options to configure change detection. Fixes #32 (22 hours ago)
cd162f3 chore(build): auto-generate vimdoc (22 hours ago)
941df31 feat(ui): make the windoww size configurable. Fixes #34 (22 hours ago)
5298441 fix: use nvim_feekeys instead of nvim_input for keys handler. Fixes #28 (23 hours ago)
2927b05 docs: added lincense (23 hours ago)
4d78203 chore(main): release 5.0.1 (#17) (24 hours ago)
1371a14 fix(build): use the shell to execute build commands (24 hours ago)
ffabe91 fix(cache): if mod is loaded already in the loader, then return that (25 hours ago)
316503f fix: dont autoload cached modules when module=false (25 hours ago)
992c679 fix: always set Config.me regardless of reset rtp (25 hours ago)
df6c986 fix: add neovim libs to rtp for treesitter parsers etc (26 hours ago)
49b69b7 chore(build): auto-generate vimdoc (27 hours ago)
e9d3a73 fix: default logs are now since 3 days ago to be in line with the docs (27 hours ago)
4234322 chore(build): auto-generate vimdoc (27 hours ago)
6e32759 fix: deepcopy lazyspec before processing (27 hours ago)
ec0f8d0 docs: added config.dev.path to the example (28 hours ago)
6404d42 fix: move re-sourcing check to the top (28 hours ago)
ddf36d7 fix: checker should not error on non-existing dirs (28 hours ago)
50ba619 test: fix tests (28 hours ago)
f78d8bf fix: show error when merging, but continue (28 hours ago)
b8a0055 chore(build): auto-generate vimdoc (29 hours ago)
1754056 fix: use jobstart instead of system to open urls (29 hours ago)
5ecc988 docs: use https to bootstrap lazy (29 hours ago)
ae644a6 fix: only run updated checker for installed plugins. Fixes #16 (29 hours ago)
7225b05 chore(build): auto-generate vimdoc (30 hours ago)
17fd57a docs: added docs for statusline and count (30 hours ago)
48a596e chore(build): auto-generate vimdoc (30 hours ago)
dfe8a65 docs: removed extra performance section (30 hours ago)
1fa2d87 docs: moved my dots to structuring plugins (30 hours ago)
9916318 chore(build): auto-generate vimdoc (30 hours ago)
abe026a docs: added section on performance (30 hours ago)
82aea47 chore(build): auto-generate vimdoc (31 hours ago)
72d66cd docs: updated lua stuff (31 hours ago)
ca43018 chore(build): auto-generate vimdoc (31 hours ago)
36cb7ea docs: migration guide (31 hours ago)
2f59ead chore(main): release 5.0.0 (#12) (31 hours ago)
dbcf675 chore(build): auto-generate vimdoc (31 hours ago)
b906ad9 docs: added windows to supported platforms (31 hours ago)
cb87aa3 ci: run tests on linux only for nw (32 hours ago)
75a36f3 chore(build): auto-generate vimdoc (33 hours ago)
af87108 fix(util): fixed double slashes (33 hours ago)
62c1542 fix(cache): normalize paths (33 hours ago)
bb1c2f4 feat: added support for Windows (34 hours ago)
198963f feat: utility method to normalize a path (34 hours ago)
a189883 fix: check for installed plugins with plain find (34 hours ago)
833b387 chore(build): auto-generate vimdoc (2 days ago)
ff89319 docs: removed dots from features (2 days ago)
b7bf18a style: spelling (2 days ago)
66dad89 chore(build): auto-generate vimdoc (2 days ago)
0c0b8b7 docs: todo (2 days ago)
92fd0d4 docs: updated installation and structuring plugins (2 days ago)
1baa92f docs: added docs on <cr> and <K> (2 days ago)
d827d8a docs: collapse semver examples (2 days ago)
1e16363 chore(build): auto-generate vimdoc (2 days ago)
980cfa9 docs: added config example when not using a Nerd Font (2 days ago)
713dcb6 build: added markdownlint config (2 days ago)
706fe6f chore(build): auto-generate vimdoc (2 days ago)
5ed9855 feat: added completion for all lazy commands (2 days ago)
b462787 docs: added optional plugins to docs for commands and methods (2 days ago)
f29f3d2 chore(build): auto-generate vimdoc (2 days ago)
1efa710 feat: added module=false to skip auto-loading of plugins on require (2 days ago)
55d194c chore(build): auto-generate vimdoc (2 days ago)
bac34cc docs: added section on uninstalling (2 days ago)
c065ca2 chore(build): auto-generate vimdoc (2 days ago)
2dd6230 feat: added :Lazy load foobar.nvim to load a plugin (2 days ago)
8a0da3b config: move lazy cache to state/nvim/lazy/cache (2 days ago)
7eb6034 chore(build): auto-generate vimdoc (2 days ago)
6567580 chore: todo (2 days ago)
6f00cde docs: typos (2 days ago)
faac2dd perf(cache): cache loadfile and no find modpaths without package.loaders (2 days ago)
32f2b71 fix(cache): do a fast check to see if a cached modpath is still valid. find it again otherwise (2 days ago)
1fe43f3 fix(ui): focus Lazy window when auto-installing plugins in VimEnter (2 days ago)
d4aee27 feat!: removed the LazyUpdate etc commands. sub-commands only from now on (2 days ago)
b89e6bf perf: lazy-load the commands available on the lazy module (3 days ago)
Log (10)
○ LuaSnip
5570fd7 Auto generate docs (21 hours ago)
618b945 log: don't print a message on every start, provide log.ping() instead. (21 hours ago)
○ formatter.nvim
    8a4c961 Add configuration for standardrb (#212) (31 minutes ago)
    31a0ee7 Fix lua-format args (#214) (31 minutes ago)
    9aaf855 feat: add support for PHP-CS-Fixer (#216) (32 minutes ago)
    c7d7d90 feat: add nix formatting support (#217) (33 minutes ago)
    369e35b Use `--stderr` flag for rubocop rather than parsing output (#210) (33 minutes ago)

○ gitsigns.nvim
    2ab3bdf fix(blame): #697 (2 days ago)

○ neodev.nvim
    c5f0a81 chore: auto-generated types for Neovim nightly (10 hours ago)
    f8b17d3 chore: auto-generated types for Neovim nightly (34 hours ago)

● noice.nvim 10.51ms  VeryLazy
    585d24e fix(health): dont use nvim-treesitter to check if a lang exists (80 minutes ago)
    81269c5 ci: added .repro to .gitignore (2 hours ago)
    044767a fix: dont error in checkhealth if nvim-treesitter is not installed (2 hours ago)
    4e03e16 chore(main): release 1.5.0 (#269) (2 hours ago)
    d833d5e chore(build): auto-generate vimdoc (2 hours ago)
    aa68eb6 feat(format): allow `config.format.level.icons` to be false. Fixes #274 (2 hours ago)
    e4a4290 chore(build): auto-generate vimdoc (2 days ago)
    29a2e05 feat: added `Filter.cond` to conditionally use a route (2 days ago)

● nui.nvim 0.33ms   noice.nvim
    b12db53 fix(layout): process split layout box change (11 hours ago)
    51721a4 fix(layout): process float layout box change (11 hours ago)
    96ef1cb feat(split): store id internally (11 hours ago)

○ nvim-dap
    284c754 Stop resizing widgets if converted to non-float window (2 days ago)
    3971d9b Allow opening multiple frames or scopes widgets (2 days ago)

○ nvim-lspconfig
    5292d60 docs: update server_configurations.md skip-checks: true (14 hours ago)
    f70a094 fix: rename ruff-lsp to ruff_lsp (#2337) (14 hours ago)
    80e81b1 docs: update server_configurations.md skip-checks: true (14 hours ago)
    d8a4493 chore: remove `languageFeatures`, `documentFeatures` (#2336) (14 hours ago)
    baab771 docs: update server_configurations.md skip-checks: true (15 hours ago)
    4e13145 feat: add ruff-lsp support (#2335) (15 hours ago)
    d597b0f fix: send the lsp method request after insert workspace folders (#2330) (34 hours ago)
    1ab2720 docs: update server_configurations.md skip-checks: true (34 hours ago)
    9c70f37 feat: add jq support (#2333) (34 hours ago)
    259729c docs: update server_configurations.md skip-checks: true (2 days ago)
    aa22008 feat: add uvl support (#2331) (2 days ago)
    dd9e7f9 fix(gdscript): support get the port from env variable (#2313) (2 days ago)
    22c87d6 build(rockspec): fix rockspec package name (2 days ago)

● nvim-treesitter 52.02ms   nvim-treesitter-refactor
    770c66d Update parsers: v (4 hours ago)
    87dd482 fix(health): align the list of parsers when doing checkhealth (4 hours ago)
    ca09752 Update parsers: c_sharp, gdscript, sql (8 hours ago)
    eedb7b9 csharp: update query to parser change (33 hours ago)
    8498ebd Update parsers: c_sharp, jsonnet, query (33 hours ago)
    6e37050 Update parsers: swift (2 days ago)
    a75aded highlights(java): fix '!',param,global group (3 days ago)

○ telescope.nvim
    e960efa fix: jumplist picker indexing the line after (#2273) (5 hours ago)
    d16581e fix: misidentification invert and files_with_matches (#2240) (#2262) (8 hours ago)
    278c797 fix(builtin.live_grep): add spacer ":" even when coordinates disabled (#2275) (8 hours ago)

Clean (11)
○ colorscheme_switcher
○ friendly-snippets
○ lense.nvim
○ neocomplete.nvim
○ neorg-context
○ neorg-kanban
○ neorg-telescope
○ neorg-zettelkasten
○ nvim-cmp
○ nvim-treehopper
● which-key.nvim 90.63ms   LazyLoad
Loaded (6)
● heirline.nvim 5.26ms  start
● nvim-notify 0.2ms   noice.nvim
● nvim-treesitter-endwise 1.76ms   nvim-treesitter
● nvim-treesitter-refactor 57.96ms   LazyLoad
● nvim-treesitter-textobjects 21.98ms   nvim-treesitter
● playground 1.67ms   nvim-treesitter
Installed (32)
○ Comment.nvim
○ bufferline.nvim
○ cmp-emoji
○ cmp-latex-symbols
○ cmp-nvim-lsp
○ cmp-nvim-lua
○ cmp-path
○ cmp_luasnip
○ dirbuf.nvim
○ gitlinker.nvim
○ indent-blankline.nvim
○ jeskape.nvim
○ lightspeed.nvim
○ luv-vimdocs
○ nabla.nvim
○ neogen
○ neorg
○ nvim-autopairs
○ nvim-colorizer.lua
○ nvim-dap-ui
○ nvim-dap-virtual-text
○ nvim-surround
○ nvim-web-devicons
○ one-small-step-for-vimkind
○ paperplanes.nvim
○ plenary.nvim
○ rust-tools.nvim
○ ssr.nvim
○ telescope-file-browser.nvim
○ telescope-fzf-native.nvim
○ toggleterm.nvim
○ trouble.nvim

repro.lua
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
    vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end
vim.g.mapleader = " "

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
    vim.fn.system({
        "git",
        "clone",
        "--filter=blob:none",
        "--single-branch",
        "https://github.com/folke/lazy.nvim.git",
        lazypath,
    })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
    "folke/tokyonight.nvim",
    {
        "folke/which-key.nvim",
        config = function()
            require("which-key").register({

                c = {
                    name = " Comment",
                    c = { "Toggle Line" },
                },
            }, {
                prefix = "<leader>",
                mode = "n",
            })
        end,
    },
    {
        "numToStr/Comment.nvim",
        keys = { "<leader>c", "gb" },
        config = function()
            require("comment").setup({
                toggler = {
                    ---line-comment keymap
                    line = "<leader>cc",
                    ---block-comment keymap
                    block = "gbc",
                },

                ---LHS of operator-pending mappings in NORMAL + VISUAL mode
                opleader = {
                    ---line-comment keymap
                    line = "<leader>c",
                    ---block-comment keymap
                    block = "gb",
                },
                mappings = {
                    -- extended = true,
                },
            })
        end,
    },
    -- add any other pugins here
}
require("lazy").setup(plugins, {
    root = root .. "/plugins",
})

-- add anything else here
vim.opt.termguicolors = true
vim.cmd.colorscheme("tokyonight")

two other things:

add the repro.lua fold thing like I did to this issue template
perhaps rethink the root in repro. because people don't expect the plugins to be cloned into their current directory (at least I didn't)

#28 is related, have you checked it, or updated the plugin?

yes and yes

You didn't add <leader>cc to the keys handler. Adding that one makes it work

reopening the issue
<leader>cj @folke

What do you mean?

<leader>cj doesn't work

which is also not in that keys handler?

yes it isn't
because it's an operator pending mapping
and I can't put all the different text objects and motions into the keys handler

I get what you mean with that leader cj now. leader c is an operator pending mode. Keys currently only supports normal mode, so the retrigger will not to what you want.

I'm planning on expanding the keys handler soon.
That works, because that will load the comments plugin. Your then inside whichkey and pressing c again, wich-key will redo the whole mapping, so that works

I'll wait for that expansion then and until then try to hack something together with init

I think I was able to fix it anyway. At least it also works now for <leader>cj

works perfectly now
thank you very much for the quick fix


:OmniSharpInstall command missing

Noticed today when I went to update the omnisharp server version that the install command is no longer registered. Took a quick look and narrowed it down to commit 53ac2ac9. Reverting said commit restores the previous behaviour

Oops! In that commit I moved the command from ftplugin/cs/OmniSharp.vim to plugin/OmniSharp.vim, to make it globally available instead of only from .cs buffer which trips people up.
But I forgot to remove the -buffer flag on the command, meaning is only available in the buffer vim is opened to!
Thanks for the report, I'll fix it soon.


build: update golang k8s API's to v0.23

Signed-off-by: Nitin Goyal<EMAIL_ADDRESS>

Please explain that this is upgrading to k8s v1.23 api in the PR title and commit msg

/lgtm /approve


Add option to restart daemon

The workaround here is to use a shellscript:
#!/bin/sh
flexget daemon stop --wait
flexget daemon start --daemonize

This issue is about allowing just a simple flexget daemon restart which would do the equivalent action to the above script, FULLY restarting the daemon so that no part remains running.

Or do what I did and make it a service on the linux box

Did that too :)
Services are rather ungracefully shot down when restarting, with SIGTERM.


OpenSSL 3.0 performance degradation due to bottleneck in the ossl_gcm_get_ctx_params and ossl_gcm_set_ctx_params functions

Context: We are observing some performance degradation when migrating to OpenSSL 3.0.7 from OpenSSL 1.1.1s.
Looking at a profiler in a Linux architecture revealed that the calls to EVP_CipherInit_ex, EVP_CIPHER_CTX_set_params, and
EVP_CIPHER_CTX_get_params are now taking more cycles.
Problem: These APIs end up in the ossl_gcm_get_ctx_params and ossl_gcm_set_ctx_params functions, which seem to be the bottleneck. These functions call OSSL_PARAM_LOCATE for every possible parameter. For every call to OSSL_PARAM_LOCATE, we are iterating over the parameters and doing a string comparison that checks if the parameter key matches the one we are looking for. Summing up, every time we set a parameter, we end up doing a bunch of strcmp.
Alternative: The performance would be greatly improved if the key were an integer instead of a string.
Side note: Another way that performance could be improved is by skipping the call to OPENSSL_PARAM_LOCATER. Instead, iterating (once) over all parameters, checking for each parameter its key.

This is a known issue and one that is very hard to overcome as the params API cannot be broken.
Whether you iterate over parameters instead of calling locate, does not really matter because you always need to compare n strings of settable/gettable parameter names with m strings of parameter names in params.  It is irrelevant whether you iterate over settable parameters first and locate is the inner loop, or you iterate over names in params as outer loop and the inner loop iterates over settable parameters.
We made some experiments using prehashed names but that did not really help in the most common cases.
There was also this hack PR that optimizes a few of the most common cases a little but it is really just a hack -
https://github.com/openssl/openssl/pull/17281 - we could revive it again but I am not sure it will be accepted by OTC.

Are these set_params/get_params calls the real bottleneck in your application or is it just one of the cases where the performance degraded from 1.1.1 but there are bigger issues? Could you please describe how your application uses OpenSSL?

Hi @t8m, thanks for looking into this. Our application is essentially calling EVP_EncryptInit_ex, EVP_EncryptUpdate, EVP_EncryptFinal_ex, and EVP_CIPHER_CTX_ctrl (similarly for the receiver side). The set_param/get_param calls are not  a real bottleneck in the application, but the reason performance (measured in bytes per second, essentially throughput) degraded when switching to OpenSSL 3. When I mention performance here, I mean samples per second, essentially throughput (bytes per second). We usually test sending/receiving samples between 32 and 64k bytes, where for each sample we call the aforementioned functions, in a way very similar to what openssl speed does when setting the -aead flag. I can see that the results of openssl speed really improved in #17281. I'll apply the patch and let you know how it goes.
One of the things that may be important to remark from our application is that we are only setting one parameter: EVP_CTRL_AEAD_GET_TAG. Asking from ignorance, would it make sense to have a get_params API with one additional parameter where you specify a key (or a list of them) so that we only call OSSL_PARAM_locate_const f or it?

I can see that the results of openssl speed really improved in #17281. I'll apply the patch and let you know how it goes.
The PR is not complete in that regards so I do not think it will really help you as it changes only the get_params() functions.

We would need something more generic. I have something on mind, I'll try prepare a PR when I have some free time.

In case it helps: evp_cipher_init_internal calls EVP_CIPHER_CTX_get_key_length and EVP_CIPHER_CTX_get_iv_length (line, line), which end up calling evp_do_ciph_ctx_getparams as well. So improvements in the performance of get_params will also have benefits here. Also, according to the documentation:

Note: although EVP_CIPHER_get_key_length() is fixed for a given cipher, the value of EVP_CIPHER_CTX_get_key_length() may be different for variable key length ciphers.

It looks like the get_params call is needed to support variable key length ciphers. If we could detect whether the cipher is variable, then we would avoid a call to get_params and simple do ctx->cipher->key_length.

We would need something more generic. I have something on mind, I'll try prepare a PR when I have some free time.

It is disappointing that the team does not have "fix 3.0 performance issues" as a high priority.

Master (and 3.1) cache these 2 getter values in the ctx, so that the get_params() calls only happen once

We just wanted to add our findings to this on going discussion.
My team has been looking into the performance of OpenSSL vs calling a crypto implementation directly for AES-CBC-HMAC-SHA encrypt and auth operations.
We used DPDK to test the throughput of data for a variety of buffer sizes and noticed that for smaller buffers (around 1kB or less) there is a fairly noticeable drop in the performance of OpenSSL relative to calling the crypto implementation directly.
For 32 byte buffers (the smallest that we measured for), the performance disparity was greatest, with OpenSSL achieving only around 36% of the throughput speeds attained by AArch64CryptoLib.
Whilst it is not fair to attribute all of this performance loss to OSSL_PARAM_locate it became clear from looking at flame graphs that OSSL_PARAM_locate was a significant hot-spot in the application.
The flame graphs were produced using the Hotspot application and this tool also automatically identifies hot-spots, and it identified OSSL_PARAM_locate as a top hot-spot during this measurement. We can also verify this visually from the graph.
The flame graph below shows an AES-CBC-128-SHA1-HMAC encrypt and auth interleaved operation in OpenSSL for a buffer size of 32 Bytes. The pink rectangles show where we are spending time in OSSL_PARAM_locate  and the associated call to strcmp  and the green rectangle indicates where we are spending time in the AES-CBC/SHA1 interleaved encrypt and auth. It can be seen here that we are spending comparable amounts of computation time in the actual cipher and auth operation as we are in the parameter location code.

We have this issue https://github.com/openssl/project/issues/354 to improve OSSL_PARAM lookups for various call sites.

The GCM part was addressed by #20935 but I'm pretty sure it wasn't merged back to 3.0.


Don't let CRD affect the instance

When CRD is deleted, the mysql instance is deleted. I think we should reduce the impact of all environments on mysql instances.

I think this is the desired result.


Install error

C:\dev\web\genericServer>npm install sharp

<EMAIL_ADDRESS>install C:\dev\web\genericServer\node_modules\sharp
node-gyp rebuild

C:\dev\web\genericServer\node_modules\sharp>node "C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin\....\node_
modules\node-gyp\bin\node-gyp.js" rebuild
child_process: customFds option is deprecated, use stdio instead.
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
common.cc
C:\Program Files\Microsoft Visual Studio 10.0\VC\include\xlocale(323): warning C4530: C++ exception handler used, but u
nwind semantics are not enabled. Specify /EHsc [C:\dev\web\genericServer\node_modules\sharp\build\sharp.vcxproj]
..\src\common.cc(3): fatal error C1083: Cannot open include file: 'vips/vips.h': No such file or directory [C:\dev\web
genericServer\node_modules\sharp\build\sharp.vcxproj]
utilities.cc
..\src\utilities.cc(2): fatal error C1083: Cannot open include file: 'vips/vips.h': No such file or directory [C:\dev\w
eb\genericServer\node_modules\sharp\build\sharp.vcxproj]
metadata.cc
..\src\metadata.cc(2): fatal error C1083: Cannot open include file: 'vips/vips.h': No such file or directory [C:\dev\we
b\genericServer\node_modules\sharp\build\sharp.vcxproj]
resize.cc
..\src\resize.cc(6): fatal error C1083: Cannot open include file: 'vips/vips.h': No such file or directory [C:\dev\web
genericServer\node_modules\sharp\build\sharp.vcxproj]
sharp.cc
..\src\sharp.cc(2): fatal error C1083: Cannot open include file: 'vips/vips.h': No such file or directory [C:\dev\web\g
enericServer\node_modules\sharp\build\sharp.vcxproj]
gyp ERR! build error
gyp ERR! stack Error: C:\Windows\Microsoft.NET\Framework\v4.0.30319\msbuild.exe failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\build.js:2
67:23)
gyp ERR! stack     at ChildProcess.emit (events.js:110:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:1067:12)
gyp ERR! System Windows_NT 6.1.7600
gyp ERR! command "node" "C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "rebuil
d"
gyp ERR! cwd C:\dev\web\genericServer\node_modules\sharp
gyp ERR! node -v v0.12.0
gyp ERR! node-gyp -v v1.0.2
gyp ERR! not ok
npm ERR! Windows_NT 6.1.7600
npm ERR! argv "C:\Program Files\nodejs\\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "i
nstall" "sharp"
npm ERR! node v0.12.0
npm ERR! npm  v2.5.1
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the sharp package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls sharp
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\dev\web\genericServer\npm-debug.log
C:\dev\web\genericServer>

Hello, has VIPS_HOME been set to the location of libvips on this machine?

@Auxolust Have you been able to make any progress with this?

Hi @lovell, sorry for the delay, VIPS_HOME has been set correctly, I haven't been able to progress any further with the installation despite numerous attempts

Thanks for the update. Does the $(VIPS_HOME)\include\vips\vips.h file exist? Are you able to share the node_modules\sharp\build\sharp.vcxproj file generated during installation?

I'm getting the same error following the install instructions. VIPS_HOME is set:
C:\Users\DavidRevay\Documents\Git\stemn\node_modules\sharp>if not defined npm_config_node_gyp (node "c:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp
.js" rebuild )  else (rebuild)
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  common.cc
  utilities.cc
  metadata.cc
  resize.cc
  sharp.cc
..\src\metadata.cc(2): fatal error C1083: Cannot open include file: 'vips/vips.h': No such file or directory [C:\Users\DavidRevay\Documents\Git\stemn\node_modules\sharp\build\sharp.vcxproj]
..\src\utilities.cc(2): fatal error C1083: Cannot open include file: 'vips/vips.h': No such file or directory [C:\Users\DavidRevay\Documents\Git\stemn\node_modules\sharp\build\sharp.vcxproj]
..\src\sharp.cc(2): fatal error C1083: Cannot open include file: 'vips/vips.h': No such file or directory [C:\Users\DavidRevay\Documents\Git\stemn\node_modules\sharp\build\sharp.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\include\xlocale(336): warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc (..\src\common.cc) [C:\User
s\DavidRevay\Documents\Git\stemn\node_modules\sharp\build\sharp.vcxproj]
..\src\resize.cc(6): fatal error C1083: Cannot open include file: 'vips/vips.h': No such file or directory [C:\Users\DavidRevay\Documents\Git\stemn\node_modules\sharp\build\sharp.vcxproj]
..\src\common.cc(4): fatal error C1083: Cannot open include file: 'vips/vips.h': No such file or directory [C:\Users\DavidRevay\Documents\Git\stemn\node_modules\sharp\build\sharp.vcxproj]
gyp ERR! build error
gyp ERR! stack Error: `C:\Windows\Microsoft.NET\Framework\v4.0.30319\msbuild.exe` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (c:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\build.js:269:23)
gyp ERR! stack     at ChildProcess.emit (events.js:110:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:1074:12)
gyp ERR! System Windows_NT 6.3.9600
gyp ERR! command "node" "c:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users\DavidRevay\Documents\Git\stemn\node_modules\sharp
gyp ERR! node -v v0.12.2
gyp ERR! node-gyp -v v1.0.3
gyp ERR! not ok
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "c:\\Program Files\\nodejs\\node.exe" "c:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install" "sharp"
npm ERR! node v0.12.2
npm ERR! npm  v2.7.4
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the sharp package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls sharp
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:

I would like to capture the sharp.vcxproj file but the entire node_modules\sharp directory is removed after a failed install.

It looks like @Auxolust is using Visual Studio 2010 ("10.0") and @DaveRevay2 is using VS 2012 ("11.0").
I've tested installation works with VS 2013 (on a laptop) and VS 2014 (via Azure).
My best guess is that the environment variable is not being made available to the msbuild.exe process.
Please can you try npm install --arch=ia32 --msvs_version=2012 (or npm install --arch=ia32 --msvs_version=2010). Alternatively are either of you in a position to try  a more recent version of Visual Studio?

@Auxolust @DaveRevay2 have either of you been able to make any progress with either the suggested npm flags or a newer version of Visual Studio?

C:\Users\DavidRevay\Documents\Git\stemn>npm install sharp --arch=ia32 --msvs_version=2012
npm WARN package.json<EMAIL_ADDRESS>No README data
npm WARN package.json<EMAIL_ADDRESS>No repository field.

><EMAIL_ADDRESS>install C:\Users\DavidRevay\Documents\Git\stemn\node_modules\sharp
> node-gyp rebuild

C:\Users\DavidRevay\Documents\Git\stemn\node_modules\sharp>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\n
ode-gyp\bin\node-gyp.js" rebuild )  else (rebuild)
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  common.cc
  utilities.cc
  metadata.cc
  resize.cc
  sharp.cc
C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\include\xlocale(336): warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc (..\src
\common.cc) [C:\Users\DavidRevay\Documents\Git\stemn\node_modules\sharp\build\sharp.vcxproj]
..\src\utilities.cc(80): warning C4344: behavior change: use of explicit template arguments results in call to 'v8::Local<T> NanNew<v8::String,char*>(A0)' [C:\Users\DavidRevay\Doc
uments\Git\stemn\node_modules\sharp\build\sharp.vcxproj]
          with
          [
              T=v8::String,
              A0=char *
          ]
          but the regular function 'v8::Local<T> NanNew(const char *)' is a better match
          with
          [
              T=v8::String
          ]
          if you expect 'v8::Local<T> NanNew(const char *)' to be called then you need to make it an explicit specialization
          with
          [
              T=v8::String
          ]
..\src\utilities.cc(99): error C2059: syntax error : '{' [C:\Users\DavidRevay\Documents\Git\stemn\node_modules\sharp\build\sharp.vcxproj]
..\src\utilities.cc(99): error C2143: syntax error : missing ';' before '}' [C:\Users\DavidRevay\Documents\Git\stemn\node_modules\sharp\build\sharp.vcxproj]
c1xx : fatal error C1063: INTERNAL COMPILER ERROR [C:\Users\DavidRevay\Documents\Git\stemn\node_modules\sharp\build\sharp.vcxproj]

           Please choose the Technical Support command on the Visual C++

           Help menu, or open the Technical Support help file for more information

..\src\resize.cc(286): error C3861: 'round': identifier not found [C:\Users\DavidRevay\Documents\Git\stemn\node_modules\sharp\build\sharp.vcxproj]
..\src\resize.cc(289): error C3861: 'round': identifier not found [C:\Users\DavidRevay\Documents\Git\stemn\node_modules\sharp\build\sharp.vcxproj]
..\src\resize.cc(295): error C3861: 'round': identifier not found [C:\Users\DavidRevay\Documents\Git\stemn\node_modules\sharp\build\sharp.vcxproj]
..\src\resize.cc(298): error C3861: 'round': identifier not found [C:\Users\DavidRevay\Documents\Git\stemn\node_modules\sharp\build\sharp.vcxproj]
gyp ERR! build error
gyp ERR! stack Error: `C:\Windows\Microsoft.NET\Framework\v4.0.30319\msbuild.exe` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\build.js:269:23)
gyp ERR! stack     at ChildProcess.emit (events.js:110:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:1074:12)
gyp ERR! System Windows_NT 6.3.9600
gyp ERR! command "node" "C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users\DavidRevay\Documents\Git\stemn\node_modules\sharp
gyp ERR! node -v v0.12.2
gyp ERR! node-gyp -v v1.0.3
gyp ERR! not ok
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\\Program Files\\nodejs\\\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install" "sharp" "--arch=ia32" "--msvs_version=2012"
npm ERR! node v0.12.2
npm ERR! npm  v2.7.4
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the sharp package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls sharp
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\DavidRevay\Documents\Git\stemn\npm-debug.log

Still getting an error unfortunately.

@DaveRevay2 Thank you for checking. This helps us make progress as syntax error : missing ';' before '}' and 'round': identifier not found are different errors to those you saw previously. These are due to the compiler's inability to understand certain features of C++11.
I suspect a minimum version of Visual Studio 2013 ("12.0") is what's really required to get it to compile. If either of you are in a position to install or use it, that will help narrow this problem down further.

@lovell , haven't made any progress, decided to switch to an alternative as the work I'm doing is time sensitive

I'm pretty certain this problem relates to older versions of Visual Studio and have declared a minimum of MSVC 2013 in the documented prerequisites.
Please feel free to re-open if the problem persists when using MSVC 2013 or later.

I'm working with vs2015 and have the same issue. Unfortunately i have can share the sharp.vcxproj
here the log
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
common.cc
utilities.cc
metadata.cc
resize.cc
..\src\metadata.cc(2): fatal error C1083: Cannot open include file: 'vips/vips.h': No such file or directory [C:\Users
Joost\Documents\projects\ddc\ddc2015\node_modules\gulp-responsive\node_modules\sharp\build\sharp.vcxproj]
..\src\utilities.cc(2): fatal error C1083: Cannot open include file: 'vips/vips.h': No such file or directory [C:\Users
\Joost\Documents\projects\ddc\ddc2015\node_modules\gulp-responsive\node_modules\sharp\build\sharp.vcxproj]
sharp.cc
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\xlocale(341): warning C4530: C++ exception handler used,
but unwind semantics are not enabled. Specify /EHsc (compiling source file ..\src\common.cc) [C:\Users\Joost\Documents
\projects\ddc\ddc2015\node_modules\gulp-responsive\node_modules\sharp\build\sharp.vcxproj]
..\src\sharp.cc(2): fatal error C1083: Cannot open include file: 'vips/vips.h': No such file or directory [C:\Users\Joo
st\Documents\projects\ddc\ddc2015\node_modules\gulp-responsive\node_modules\sharp\build\sharp.vcxproj]
..\src\resize.cc(6): fatal error C1083: Cannot open include file: 'vips/vips.h': No such file or directory [C:\Users\Jo
ost\Documents\projects\ddc\ddc2015\node_modules\gulp-responsive\node_modules\sharp\build\sharp.vcxproj]
..\src\common.cc(4): fatal error C1083: Cannot open include file: 'vips/vips.h': No such file or directory [C:\Users\Jo
ost\Documents\projects\ddc\ddc2015\node_modules\gulp-responsive\node_modules\sharp\build\sharp.vcxproj]
gyp ERR! build error
gyp ERR! stack Error: C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (c:\Program Files (x86)\nodejs\node_modules\npm\node_modules\node-gyp\lib\buil
d.js:269:23)
gyp ERR! stack     at ChildProcess.emit (events.js:110:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:1074:12)
gyp ERR! System Windows_NT 6.3.9600
gyp ERR! command "node" "c:\Program Files (x86)\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "
rebuild"
gyp ERR! cwd C:\Users\Joost\Documents\projects\ddc\ddc2015\node_modules\gulp-responsive\node_modules\sharp
gyp ERR! node -v v0.12.7
gyp ERR! node-gyp -v v2.0.1
gyp ERR! not ok
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "c:\Program Files (x86)\nodejs\node.exe" "c:\Program Files (x86)\nodejs\node_modules\npm\bin\npm-
cli.js" "install" "--save-dev" "gulp-responsive"
npm ERR! node v0.12.7
npm ERR! npm  v2.11.3
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the sharp package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls sharp
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\Joost\Documents\projects\ddc\ddc2015\npm-debug.log

Hallo @JSchermers, the Cannot open include file: 'vips/vips.h' message suggests one or more of the following might be the case:

the VIPS_HOME environment variable is not set
the VIPS_HOME environment variable is unavailable at compile time, e.g. user/permissions
the $(VIPS_HOME)/include/vips/vips.h file doesn't exist

Are you able to check and confirm?

Hello @lovell
the VIPS_HOME environment variable is not set --
i tried this in user and system variables
the $(VIPS_HOME)/include/vips/vips.h file doesn't exist
it does exist
so it can only be permissions? But the user and system variables are set to the vips path. That must be ok doesn't it

@JSchermers Does this mean you've been able to make progress? If you've not already tried it, adding the --arch=ia32 flag to npm should force it to 32-bit.

@lovell
yes there's progress , tnx very much.
the --arch=ia32 might do something but i still get the fatal error windows64 bit is currently unsupported

@JSchermers The Windows 64-bit is currently unsupported error is generated by https://github.com/lovell/sharp/blob/master/src/common.cc#L14 when _WIN64 is detected.
I guess you're using the x86 32-bit node.exe on a 64-bit Windows machine.
It might be that you'll need to use the msvs_version flag to help node-gyp realise it should only be using 32-bit. The full command would then be npm install --arch=ia32 --msvs_version=2013.

@lovell
Sorry for the delay in response.
Your right about my setup! I have 64 bit with 32 bit node.
i used the command to set node gyp version and then ran npm install gulp-responsive. But the error is still here

C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\xlocale(341): warning C4530: C++ exception handler used,
but unwind semantics are not enabled. Specify /EHsc (compiling source file ..\src\common.cc) [C:[projectdir]\node_modules\gulp-responsive\node_modules\sharp\build\sharp.vcxproj]
..\src\common.cc(11): fatal error C1189: #error:  Windows 64-bit is currently unsupported - see https://github.com/love
ll/sharp#windows [[projectdir]\node_modules\gulp-responsive\node_modules\sharp\build\s
harp.vcxproj]
sharp.cc
..\src\resize.cc(988): warning C4267: 'argument': conversion from 'size_t' to 'uint32_t', possible loss of data [C:\Use
rs\Joost\Documents\projects\ddc\ddc2015\node_modules\gulp-responsive\node_modules\sharp\build\sharp.vcxproj]
..\src\utilities.cc(27): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [C:[projectdir]\node_modules\gulp-responsive\node_modules\sharp\build\sharp.vcxproj]
c:[projectdir]\node_modules\gulp-responsive\node_modules\sharp\node_modules\nan\nan_new.
h(214): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data (compiling source file ..\s
rc\resize.cc) [[projectdir]\node_modules\gulp-responsive\node_modules\sharp\build\shar
p.vcxproj]
..\src\resize.cc(968): note: see reference to function template instantiation 'v8::Localv8::String NanNew<v8::Strin
g,const _Elem*,unsigned __int64>(A0,A1)' being compiled
with
[
_Elem=char,
A0=const char *,
A1=unsigned __int64
]

@JSchermers The presence of _WIN64 at compile-time tells me something about your environment is still trying to build 64-bit code. Have you ever had a 64-bit node executable installed at any point?
I updated the Appveyor CI environment to use MSVC 2015 and it seems to be able to compile without error. It uses 64-bit Windows with 32-bit node - you can see the full config here https://github.com/lovell/sharp/blob/msvc-2015/appveyor.yml
Perhaps there's something in there that may help you - otherwise you're probably beyond the limit of my Windows knowledge and therefore ability to help with what appears to be an environment-specific problem.


Cant change value from a script using a custom note, please help im dumb

Describe your problem here.
Basically i have this script with a specific value " timer = 30" that decreases during the song, and i want to have a custom note to increase the value by hitting it. The problem is that i been triying for like 1 hour and i cant get it to work. I know its a problem on the note script but im to dumb to understand any coding. Can someone help me?
function onCreate()
	--Iterate over all notes
	for i = 0, getProperty('unspawnNotes.length')-1 do
		if getPropertyFromGroup('unspawnNotes', i, 'noteType') == 'Gww_Note' then --Check if the note on the chart is a
			setPropertyFromGroup('unspawnNotes', i, 'texture', 'Gwgw/notes/Gww_Note'); --Change texture
			setPropertyFromGroup('unspawnNotes', i, 'noteSplashHue', 0); --custom notesplash color, why not
			setPropertyFromGroup('unspawnNotes', i, 'noteSplashSat', -20);
			setPropertyFromGroup('unspawnNotes', i, 'noteSplashBrt', 1);

			if getPropertyFromGroup('unspawnNotes', i, 'mustPress') then --Doesn't let Dad/Opponent notes get ignored
				setPropertyFromGroup('unspawnNotes', i, 'ignoreNote', false); --Miss has penalties
			end
		end
	end
end

local shootAnims = {"LEFTshoot", "DOWNshoot", "UPshoot", "RIGHTshoot"}
function goodNoteHit(id, direction, noteType, isSustainNote)
	if noteType == 'Gww_Note' then
			playSound('rice');
			timer = timer + 15
		characterPlayAnim('dad', shootAnims[direction + 1], false);
		characterPlayAnim('boyfriend', 'hey', true);
		setProperty('boyfriend.specialAnim', true);
		setProperty('dad.specialAnim', true);
		cameraShake('camGame', 0.01, 0.2)
    end
end

function noteMiss(id, direction, noteType, isSustainNote)
	if noteType == 'Gww_Note' then
		characterPlayAnim('boyfriend', 'hurt', true);
	end
end

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

I can make this script work (hopefully)

function onUpdate(elapsed)
    timer = timer - elapsed
end


Add the ability to add prefix to comment output

Feature Request
Currently, Digger supports $DIGGER_OUT in workflow custom steps to display output back into the PR comment.  This is put into a section block Additional Outputs which is hidden by default.
I would like there to be a way to target a different output variable to prepend before any other comment output.  We have done this with security scanning using a custom variable called $DIGGER_PREFIX_OUT.  Here is an example image of the output comment using $DIGGER_PREFIX_OUT instead of $DIGGER_OUT:
This would provide more power to customizing the information in the PR to the user for custom extension on top of Digger (security, format, cost, etc)

Regarding this and #1715 I heard a feature request to introduce some sort of templating override for powerusers who want to structure their comments in different ways. Perhaps a "digger.mustache.tpl" file that lives somewhere and instrucructs digger what to include in the outputs somehow. Unformed thoughts, but it seems that its inevetible to allow for powerusers of comments to customise them heavily

I think some type of templating built in for display would be a welcomed addition.


Temporary downgrade Flutter version to 3.7.12 for Android CI workflows

We're downgrading from stable latest to stable 3.7.12 because of issue mentioned in https://github.com/leancodepl/patrol/issues/1265

let's go


chore: release main

:robot: I have created a release beep boop
biblo: 0.4.3
0.4.3 (2022-11-27)
Bug Fixes

Add package-lock.json to example (8207b82)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/larsmunkholm/biblo/releases/tag/biblo-v0.4.3 :sunflower:


Generalize - Organ Registries - Donor registry

@tejash-jl To add details

This story was created to show case the pledge registry work in donor portal
The approach we took to generalize this is to create a mock layer for the nha related APIs
Mock data was created and added it to this particular service

Status as of today :- Mock data is added and the service is ready. Mock Esign functionality is not working currently since the front end has hardcoded url for esign. Once the hardcoding is removed, Mock esign functionality should be working
cc @chaitrali-r @Pratikshakhandagale @suvarnakale @manukalia29

@chaitrali-r @Pratikshakhandagale  Can you take this up?

@manukalia29  I am working on it

@chaitrali-r Is this task completed?

Chaitrali to check the status and update

It is done from frontend. Backend apis were not working then hence it was assigned to Sreejith. If there are any new changes please let me know.

I remember adding proxy configuration's for the mock-donor-service (mock-API's) which are used to replicate the e-sign functionality in the UI and verified the API's functionality. The demo portal is down even though the nginx and the docker services are up and running. I'll try to replicate the issue in local and will make the changes to make it work.

@Sreejit-K  Demo portal is up and running now. Kindly look into this.
cc: @srprasanna

Have noticed multiple issues while working on the mock Esign redirect

[ ] Random Generation of ABHA and mobile number in mock-donor-service [ Aadhar based login was failing - As it was returning already existing credentials(mobile no and abha)]
[ ] Nginx proxy configuration changes for mock-donor-service
[ ] UI changes for Esign redirection
[ ] Change the certificate Image while issuing a credential for mock-donor-service
[ ] Template changes to make the UI more generic (remove the NHA specific changes)


[resolves #452] Add support for camel-jackson data format

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/325/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/326/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/327/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/328/
Test FAILed.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/329/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/330/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/331/
Test FAILed.


Export feature, option to not include the @type columns

Storage Explorer Version: 1.5.0
Platform/OS Version: Windows 10
Architecture: ia32
Regression From: No
Steps to Reproduce:

This is a feature request (and this tool is awesome thank you), it would be great when exporting data that there was an option or setting to not include the @type columns. The reason is when you have large entities in the table and just want to use the data these columns are redundant and difficult to delete in the export file.

Hi @mark6543 this feature actually already exists!

When you export, you can change the file type to csv, which doesn't type annotations.


Create ass.txt

@Copperearth I am sorry for a delay with processing your request.
Pull request merged. Thank you!
FTR: domain proof ownership is at https://albert-offenbach.de/schulgemeinde/schulleitung/


Simplify rdchiral installation

While installing the package, I didn't understand why there was a copy of the rdchiral codebase, which appears to be available from PyPI. Could this be added to the environment.yml instead of distributing it? Or, if you've made some changes, it would be a good thing to outline what they were.
I tested that this works if you point to the canonical codebase, so I'd be happy to send a PR with the corresponding update.

Thanks for the suggestion! But since we are using a modified version of the rdchiral package, we cannot replace it with the pypi version unless we've done thorough testing. We will leave that as an option for the users.

What modifications to RDChiral have you done?

I think an alternate solution that would be helpful for both me and @SGenheden would be if you forked the original RDChiral repository (https://github.com/connorcoley/rdchiral) and made the updates there. Then you would be able to

Make a comparison of changes
Possibly give improvements back to the developer
Have a bit more of a logical way of incorporating dependencies in your setup.py


other_parties[0].birthdate triggered multiple times when editing respondent info (but maybe irrelevant if this won't be editable)

Tried to edit respondent info. After address, it triggered other_parties[0].birthdate, then phone, then other_parties[0].birthdate again.
(Domestic, Mason)

not fixing this for now since age is not currently editable.


"original" place links have a broken URL

Something broke the place links. Original place links with prefixes such as WD and GN have a link construction process that is different than the one for the "added" place links. Somehow this process was broken by the recent changes.
For example, this place:

Has a link to wd:Q3107354, which should be built as https://www.wikidata.org/wiki/Q3107354 but is instead built as https://tool.mehdie.org/datasets/wd/browse?pid=Q3107354

This used to work and was broken by the recent changes to the code to allow navigation using the place_id for added places. @zarifbekturdiev please look back at the previous version to see how this was broken and restore it.

fixed


CNF-6019: Update readme to account for changes to conditions/reasons/messages

Update the README.md file to account for all the changes made in the previous two vertical slices

/retest


Config help

Hi i try to setup helm-ls and yamlls in a LazyVim. But i cant get it working. helm filetype is not recognize and if i had yaml it's a mess with yamlls.
Don't really understand all this LSP stuff, I need help please

Is your issue solved with the vim-helm plugin? @goof03

Hey @mrjosh I'm not sure if I should open a new issue or use this one, as I'm in the same boat as OP.
I have yamlls and helmls setup, I have the vim-helm plugin installed and it looks like both LSP's attach to Helm chart files, but I get an absolute mess of yamlls errors.
The best thing I can do is just add some code to my LSP config to disable Diagnostics on helm filetypes, but I obviously want to get helmls working as it should.
If you want me to open a new issue, let me know and I'll do it. My nvim config is in a public repo if you want to take a look at my LSP configuration for disabling the Diagnostics.

Hi @Mo0rBy, please check out https://github.com/mrjosh/helm-ls/issues/44 and also the minimal config in the examples directory.


Clean code for Image display

Some cleanup:

Considering duplicated code in multiple places, using a common function to handle YUV to RGB pixel conversion.
Using std::clamp() instead of clamp expressions.

@ahcorde Thanks for your suggestion. I ignored the performance impact of function calls, will change it to inline.
I will continuelly work on ImageDisplay to support more YUV format, such as nv12, nv24 etc.
BTW, eventhough it is inline, convert color for every pixel is not efficient, especially when image is large.
Can we consider to convert with OpenGL / OpenMP, I can have a try on it.

Has pushed new commit change this function to inline.

I also compared std::clamp with ((i & 0xFFFFFF00) == 0) ? i : (i < 0) ? 0 : 0xFF, it shows std::clamp faster.
And checked std::tie, it shows no more extra performance cost.

In O2 flag, std::clamp and std::tie are faster than old code. I think compiler making optimization for std functions.

Hi @ahcorde
Is there any update for this PR

Pulls: ros2/rviz#1271
Gist: https://gist.githubusercontent.com/ahcorde/3e98ba46a6470006da49fd65022f8c58/raw/02f480667308172745d5283f9da22dc37754cf03/ros2.repos
BUILD args:   --packages-above-and-dependencies rviz_default_plugins --packages-above-and-dependencies rviz_default_plugins
TEST args:  --packages-above rviz_default_plugins --packages-above rviz_default_plugins
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14700

Linux
Linux-aarch64
Linux-rhel
Windows

Linux
Linux-aarch64
Linux-rhel
Windows


AMQP version negotiation not working if initiated by broker

The last bullet point in chapter 2.2 Version Negotiation in the specification says the following:
Note that if the server only supports a single protocol version, it is consistent with the above rules for the server to send its protocol header prior to receiving anything from the client and to subsequently close the socket if the client’s protocol header does not match the server’s.
This is currently not working because in the SASL authorization can read too many bytes from the TcpStream. I'll link a workaround PR which fixed the issue for me but I think it could be handled more elegantly.

Thank you for raising the issue. I felt like the problem could be that the Transport might be mistakenly reading too many bytes. I will investigate that

I think the problem is caused by my improper use of self.framed.into_inner(), which, according to the documentation

Note that care should be taken to not tamper with the underlying stream of data coming in as it may corrupt the stream of frames otherwise being worked with.

So some of the bytes that were read into the buffer were lost when self.framed.into_inner() is executed. into_parts, which doesn't lose the underlying buffer, seems like what I actually want.

Hi @minghuaw, thank you very much for your fast response and fixing of the issue. With the new version the version negotiations works as intended.


⏫ 403 forbidden screen development [FIRST ERROR SCREEN]

Describe the task
Developing the error screen that appears in SPAR when a user does not have the authority level to view the content they're trying to access.
Acceptance Criteria

[ ] Refactor the <Layout /> component so the <Header />'s <SideNav /> is not showing
[ ] Peer review with a developer
[ ] QA review with designers
[ ] Merge PR

Additional context
Text for the smallest screen breakpoint (320 px):
Access denied
You don't have permission to access this page.
Text for every other breakpoint:
Access denied
Oops! This cone is protecting this area.
You don't have permission to access this page.

The Figma file with screen designs for reference can be found here.
This is the .svg image file:

Trying to upload the .svg file again:


Added a .gitignore, license and a requirements.txt

I have added an MIT license with the name TriAay249 but feel free to reject this pr if you want maybe your real name or something, or maybe a different license entirely. Also I couldn't find a library that has supabase_py, I've assumed you meant supabase so I've added that to the requirements.txt
And do you want me to send a pr on removing some of the hard-coded parts? If you could enable discussions on this repository we could discuss how to approach this.

Hi. The library is called supabase-py.

Please check, I have opened the first discussion of this rep

I have added an MIT license with the name TriAay249 but feel free to reject this pr if you want maybe your real name or something, or maybe a different license entirely. Also I couldn't find a library that has supabase_py, I've assumed you meant supabase so I've added that to the requirements.txt
And do you want me to send a pr on removing some of the hard-coded parts? If you could enable discussions on this repository we could discuss how to approach this.

I have fixed the requirements.txt


Update needed for Mage Knights family

name: Mage Knights
key: mageknights
color: violet
emblem: A_Char_Knight_01
info:
logo: static/img/brands/logo/mage-knights.png?t=393c9e38c
description: >
The Mage Knights are a family of clans, which is primarily war-focused
and a community based on Clash Royale and Brawl Stars, playing both competitively and casually.
We value the entire card collection, not just your ladder deck,
but our family accepts players of all skill and card levels.
We also value practice and constructive criticism and there's always room for improvement.
Mage Knights’ main clan is currently top 50 in U.S. clan war rankings.
social:

website: https://www.secondlightband.com/
facebook: https://www.facebook.com/SecondLightBand/
instagram: https://www.instagram.com/secondlightband/
discord: https://dsc.gg/mageknights
reddit: https://www.reddit.com/user/Mage_Knights/
youtube: https://www.youtube.com/channel/UC1R-b1AET3-eLGQNed6TYzA
clans:
name: Mage Knights
tag: 2V28Y88Q
name: Mage Knights 2
tag: YR00L2LY
name: Mage Knights 3
tag: YLRJ8LUP

Just updated the following links and the Discord server invite link.

Oh, okay, but thanks.


DBeaver 21.0.4: Not all columns showing in DB Navigation Pane/Generated SQL - View

System information:

Operating system: Windows 10 v1909
DBeaver version: 21.0.4

Connection specification:

Database name and version: AWS Redshift
Driver name: com.amazon.redshift.jdbc42.Driver, using local PostgreSQL Binaries
Using SSL

Describe the problem you're observing:
None of the date/time fields are showing in the Navigation Pane for Views. Also, when generating SELECT, none of the date/time fields in the DDL are generated.
Example: DDL for View
CREATE OR REPLACE VIEW ei_ops.atom_prod_tasks_data AS
SELECT atom_prod_tasks_data.id_nbr
, atom_prod_tasks_data.lni_text
, atom_prod_tasks_data.status_text
, atom_prod_tasks_data.has_hist_ind
, atom_prod_tasks_data.create_dts
, atom_prod_tasks_data.updt_dts
, atom_prod_tasks_data.msg_dts
FROM ops.atom_prod_tasks_data with no schema binding;
The three *_dts fields are not showing in the navigation pane, or in the generated SELECT. (see attached images)
Is there a fix for this bug?

Verified


Desktop - IOU - The Distance IOU is unable to determine the user's coordinates

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.56-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4446001
Issue reported by: Applause - Internal team
Action Performed:

Open NewDot app
Log in to the employee account
Navigate to the WS room
Navigate to Request money -> Distance -> Start
In the Address field, select the "Use current location" option

Expected Result:
When using the "Use current location" option in the Distance IOU, the application must determine the user's coordinates.
Actual Result:
The Distance IOU is unable to determine the user's coordinates.
Workaround:
n/a
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/941e8e76-9943-4a60-8f0b-1d3e04541975
View all open jobs on GitHub

We think that this bug might be related to #wave-collect - Release 1

not able to reproduce on dev on main. I suspect this may be a back-end issue

not able to reproduce this on staging web either, though I just noticed this was reported on desktop. I'll check there...

I got this error on desktop:

the link just links to Expensify Help and not a specific page, which isn't very helpful

This may be a regression from https://github.com/Expensify/App/pull/38442

seeing the same error locally

seeing the same error locally

If you haven't manually added the GCP key in your local .env, then it's expected that the current location feature won't work on the local desktop app because of the changes I made

but this shouldn't happen on the staging or production. I'll also gonna investigate it

Maybe problem is that environment variables set when running electron-builder here aren't made available to the main process at runtime?

@hayata-suenaga I'm thinking maybe we can fix this issue with a PR like this: https://github.com/Expensify/App/pull/38953

the only problem with that is that I think it might make it available to the renderer process as well, which could mean that a determined actor could read it at runtime. The main process is generally more secure, but still I'm not 100% sure if something set in the Electron main process.env is secure

that interesting that webpack doesn't pick up env vars from the runner environment and you have to supply the env file as a command argument 🤔

the only problem with that is that I think it might make it available to the renderer process as well, which could mean that a determined actor could read it at runtime. The main process is generally more secure, but still I'm not 100% sure if something set in the Electron main process.env is secure

This issue exists either way because the token needs to be included in the build code.

the Secrets should be set correctly in the App repo 🤔

that interesting that webpack doesn't pick up env vars from the runner environment

I think it makes sense. electron-builder doesn't take all your bash environment variables and inject them into the bundled app - only those included in your .env file (which is consistent with react-native-config)

yes that's probably it
we use react-native-config which reads values from the .env file

it's actually react-web-config on web and desktop

we have a custom version of the webpack plugin to support desktop: https://github.com/Expensify/App/blob/59a71f3d1a34713e6c8213781c423440fb9436f8/config/webpack/webpack.common.js#L122-L130

ah I see 😄 wow that's deep

@roryabraham we can go with your PR then

Put the PR in for review, though I'm still working on local testing steps

If you haven't manually added the GCP key in your local .env

Where can I find this key?

Removing the blocker as per the conversation here: https://expensify.slack.com/archives/C01GTK53T8Q/p1711394691005269

No payment is needed for the PR linked above.
The issue hasn't been solved yet. I'll work on this next week.

I changed the priority of this task to weekly, but I'll try to get to this this week.

The issue is still reproducible. will work on this when I have time.

I'm unassigning myself since we don't both need to be assigned

I'll work on this after the QBO project is over 🙇

The request to Google geolocation endpoint from Electron is failing. The geolocation API token is not properly injected during build time.
I'll investigate this when I have time after the initial QBO release.

I still don't have a time to get around this issue yet. I'll circle back once QBO finishes.

still no time to get around this will be back when I have time

was putting off this for a while. will take a look during this week 🙇

got sick lasst week. catching up with issues.


Lighthouse report unavailable after run

Hi,
After a performance test completes, we have Sitespeed configured to push the results to an S3 bucket for long-term storage.  When viewing the report, we have the lighthouse option however the report URL is unavailable (404) - having looked at the s3 bucket directly it appears that there is no report in the /data directory.
Steps to reproduce:

with the sitespeed.io:16.9.2-plus1 docker image
Run the test and view results of the run on the published URL via S3 bucket
Within the report select a specific page and select the lighthouse option
Note the 404 error in the frame

Looking in the S3 bucket it appears the test has not been run for the specific page requested, but for the domain and I can see the lighthouse.1.html file in: [domain]/[date]/pages/[domain]/data/lighthouse.1.html

Hi @andyfrancis I don't think it should be something special with uploading that should break it. Do you use an alias for your URL? If so this https://github.com/sitespeedio/plugin-lighthouse/issues/72 is the problem, I'll fix that in the couple of days.
If you do not use an alias, please share how your run your tests so I can reproduce.
Thanks!

Hi,
Yes we do use an alias on the bucket so that would make sense :).  I'll try again after the fix and let you know.

Hi @andyfrancis I've just tried 16.10.0  v7 lighthouse now and this working for me - worth a try following https://github.com/sitespeedio/sitespeed.io/releases/tag/v16.10.0

Yep the alias fix is there now.


[YAML] In CI, polars error: 'column with name "timestamp_right" already exists'

Summary
My (Trent's) local tests all pass. But in CI, everything passes these two tests:
=========================== short test summary info ============================
FAILED pdr_backend/aimodel/test/test_aimodel_data_factory.py::test_create_xy__2exchanges_2coins_2signals - polars.exceptions.DuplicateError: unable to hstack, column with name "timestamp_right" already exists
FAILED pdr_backend/lake/test/test_ohlcv_data_factory.py::test_get_mergedohlcv_df_happypath - polars.exceptions.DuplicateError: unable to hstack, column with name "timestamp_right" already exists
======= 2 failed, 300 passed, 3 skipped, 9 warnings in 102.95s (0:01:42) =======

Full traceback here. It originated in the gql data factory work, when polars was introduced. Most CI runs since the gql merge fail due to this, though sometimes they do pass (20%?).
Here's a useful blog post about polars "join()".
What 's almost certainly happening: it's successful on the first merge, but leave a "timestamp_right" column as an artifact. Then for the second merge it can't add "timestamp_right" column because it's already there, and complains.

I should be able to reproduce this in a unit test

I don't know why it's not happening for me (Trent) locally and not in CI.
I've also noticed that _merge_rawohlcv_dfs() got 2x more complex from the gql merge. Let's see if we can refactor to make it simpler again, as part of the fix. Below I show the full code of this function before & after gql.
Details on problem area
It's in ohlcv_data_factory::_merge_rawohlcv_dfs() in this code:
                # join rawohclv_df into merged_df
                if merged_df.shape[0] == 0:
                    merged_df = raw_df
                else:
                    merged_df = merged_df.join(
                        raw_df, on="timestamp", how="outer"
                    )

Full code of problem area
    def _merge_rawohlcv_dfs(self, rawohlcv_dfs: dict) -> pl.DataFrame:
        """
        @arguments
          rawohlcv_dfs -- see class docstring

        @return
          mergedohlcv_df -- see class docstring
        """
        raw_dfs = rawohlcv_dfs

        # init mergedohlcv_df such that it can do basic operations
        print("  Merge rawohlcv dataframes.")
        merged_df = initialize_df()  # grow this
        merged_cols = ["timestamp"]  # grow this
        for exch_str in raw_dfs.keys():
            for pair_str, raw_df in raw_dfs[exch_str].items():
                assert "/" in pair_str, f"pair_str={pair_str} needs '/'"
                assert "datetime" in raw_df.columns
                assert "timestamp" in raw_df.columns

                for raw_col in raw_df.columns:
                    if raw_col in ["timestamp", "datetime"]:
                        continue

                    signal_str = raw_col  # eg "close"
                    merged_col = f"{exch_str}:{pair_str}:{signal_str}"

                    raw_df = raw_df.with_columns(
                        [pl.col(raw_col).alias(merged_col)]
                    )
                    merged_cols.append(merged_col)

                # drop columns we won't merge
                # drop original OHLCV cols and datetime
                raw_df = raw_df.drop(OHLCV_COLS)
                if "datetime" in merged_df.columns:
                    raw_df = raw_df.drop("datetime")

                # only keep OHCLV cols
                merged_cols = [
                    col for col in merged_cols if col not in OHLCV_COLS
                ]

                # join rawohclv_df into merged_df
                if merged_df.shape[0] == 0:
                    merged_df = raw_df
                else:
                    merged_df = merged_df.join(
                        raw_df, on="timestamp", how="outer"
                    )

        # select columns in-order [timestamp, ..., datetime]
        merged_df = merged_df.select(merged_cols + ["datetime"])

        assert "datetime" in merged_df.columns
        assert "timestamp" in merged_df.columns

        mergedohlcv_df = merged_df
        return mergedohlcv_df

Code before the gql changes
From here:
python
    def _merge_csv_dfs(self, csv_dfs: dict) -> pd.DataFrame:
        """
        @arguments
          csv_dfs -- dict [exch_str][pair_str] : df
            where df has cols={signal_str}+"datetime", and index=timestamp
        @return
          hist_df -- df w/ cols={exch_str}:{pair_str}:{signal_str}+"datetime",
            and index=timestamp
        """
        print("  Merge csv DFs.")
        hist_df = pd.DataFrame()
        for exch_str in csv_dfs.keys():
            for pair_str, csv_df in csv_dfs[exch_str].items():
                assert "-" in pair_str, pair_str
                assert "datetime" in csv_df.columns
                assert csv_df.index.name == "timestamp"

                for csv_col in csv_df.columns:
                    if csv_col == "datetime":
                        if "datetime" in hist_df.columns:
                            continue
                        hist_col = csv_col
                    else:
                        signal_str = csv_col  # eg "close"
                        hist_col = f"{exch_str}:{pair_str}:{signal_str}"
                    hist_df[hist_col] = csv_df[csv_col]

        assert "datetime" in hist_df.columns
        assert hist_df.index.name == "timestamp"
        return hist_df

I think if we just do an inner join, we won't get a 2nd timestamp.

I fixed this before the xmas break
FYI Roberto it was your code that did the outer join. AFAIK we can't do an inner join here because we'd lose too many candles. Better to infill later.


can't run ldapsearch -Y EXTERNAL -H ldapi:/// -b cn=config

when I try to run the following command
ldapsearch -Y EXTERNAL -H ldapi:/// -b cn=config
i get the following error message:
ldap_sasl_interactive_bind_s: Can't contact LDAP server (-1)

Apparently it is not possible to connect via socket to slapd using Docker when the slapd itself is the running process. I've used another script as a process (using sleep) and then I could access slapd via socket.


Added examples from examples repo

Closes #1369
Added all examples (except "build all examples") into forc_init.rs

@eureka-cpu It's fine. I've seen your ticket which has a bunch more code changes so I thought that I'd just merge them in instead of changing the string although it wouldn't have caused any problems if I have updated it here myself. I've got a bit more to do anyway

Just a related note: I've opened https://github.com/FuelLabs/sway/issues/1380 with a rough design for a more general approach to template sources.

remove the match altogether and just try

One downside of not hardcoding examples somewhere (pending better fancy stuff of course) is that there wouldn't be an immediate way for the user to get a list of templates to use.

remove the match altogether and just try

One downside of not hardcoding examples somewhere (pending better fancy stuff of course) is that there wouldn't be an immediate way for the user to get a list of templates to use.

give a current list of templates when fetching fails?

If a user attempts to fetch the counter example but accidentally types in counte then the initial request will fail as such a repo does not exist.
This would then present the user with an error message prompting them to

Make sure they know what they are trying to fetch
Display a list of the current examples in addition to that message.

Option 2 may obviously fail and thus the displaying of the repos should be an optional step that is appended to the end of the regular error message.
This means that if they type in an incorrect example (or one that no longer exists) it will fetch all of the repo names so that they do not have to look it up themselves.

Nice one LGTM. Might just need to rebase onto master again first.


no_this rule

It does not really work. Why? :-(

Ah, I noticed why I had problems in the first place.  So I was just modifying coffee files and running tests and nothing worked.

Please check the pull request now.

Looks great. Thanks.
I'll update those instructions, and I started on doc/writing_rules.md


Action selection style for Gantt charts

Once Event selection has been implemented for Gantt charts, we may want to consider changing the current circular selection pattern for Actions to match the rectangular shape used elsewhere in Gantt charts.
Further thoughts/discussion, especially for MAR, are needed.

Propose that the selection match bar selection for consistency -
Related to centering carbon chunks issue: https://github.com/cerner/carbon-graphs/issues/100

Yes - enhancement, doable, follow rectangular pattern as in bars.

Note: this one will cover https://github.com/cerner/carbon-graphs/issues/115#issuecomment-568024678 so it will be close. The surrounding selection should wrap around the item that was clicked wherever it is placed in the row.

Is there any way we can get this prioritized? We are planning a release in March and there are concerns that there will be confusion as to what is selected due to the selection bug mentioned in #115.

We are planning on displaying events below the blue background bar, so it will be possible for an event below the background bar to look selected even though the event in the middle of the bar is what's actually selected.

@mrw100 we split this into two separate issues again. A bug for the alignment and this one for the shape of the selection surround. Here is the bug: https://github.com/cerner/carbon-graphs/issues/170

@mrw100
Can you provide a link for this Gantt chart?

@pranav300 https://pages.github.cerner.com/medication-record/mar-js/raw/tests/mar-js/main-content/standalone


Seperate email address for automated emails

This email address can be a alias to<EMAIL_ADDRESS>(so that replys to automated email are sent to<EMAIL_ADDRESS>This makes sure that people who block the automated email aren’t also blocking support emails.

Emails from the server<EMAIL_ADDRESS>Emails from the newsletter<EMAIL_ADDRESS>

I've added<EMAIL_ADDRESS>alias for the acc.clothingloop.org website

It works on acceptance, I'll run ansible-playbook setup-4-api.yml after 3.7.0 is released


Why does the cephfs provisioner comprise both go and python files?

Cephfs has ceph-provisioner.go AND cephfs_provisioner/cephfs_provisioner.py
I can see that both are copied to the container, also that cephfs_provisioner.py is the entry point for the container.
I cant see any reference to cephfs-provisioner (the go binary) in cephfs_provisioner.py, so when is cephfs-provisioner actually called?

I just realised the go based cephfs-provisioner is the entry point which kubernetes calls, cephfs-provisioner, then calls cephfs_provisioner (the python program), presumably to create the volume. You can track this by checking example/class.yaml:
provisioner: ceph.com/cephfs

Then a grep in cephfs-provisioner:
const (
        provisionerName    = "ceph.com/cephfs"
        provisionCmd       = "/usr/local/bin/cephfs_provisioner"

And we can also see there that it will call cephfs_provisioner(.py)
Ill RTFM a bit more in future!!! :)


Player Indicators: Highlight ToB Party

Is your feature request related to a problem? Please describe.
Player Indicators are very useful for verzik part 1. But if you have "Highlight other" disabled you wouldn't see their names.
Describe the solution you'd like
Add option to highlight ToB party members

Turn on "Highlight other" then? I don't see this being a situation where it is worth us adding a special case for highlighting.

Turning on highlight other during the raid means we have to turn it off after. If you're doing 416 tob (ffa world, quite a lot of people in lobby) it becomes a mess and its hard to identify when your team are pre-potting.


Select Active Target hard to reach on Ubuntu: Ctrl-alt-T displays the terminal on all versions of Ubuntu.

What can I do? For some reason atom build is not switching build targets when I have a file from another project open... always remembering the first project I built... not the one I'm on. I can't seem to switch the target. And ctrl+alt+T is a holy shortcut in Ubuntu which I love.
Is there a way to select the active target based on the file I have open?
Or at least change the shortcut on linux.

You can change the keybinding to whatever you want globally via the keymap settings:
Press ctrl-alt-p, type open your keymap. Add something like:
  "atom-workspace":
    "ctrl-alt-t": "build:select-active-target"

And substitute ctrl-alt-t with whatever you want.
You could also assign a custom keymap to separate builds in the custom build file configuration, key keymap.

Perfect... made it be Ctrl-Alt-Shift-B
Still think it should be the default on at least Linux.
Thank you! ( btw you meant "Press ctrl-shift-p" )

Almost forgot.... This wouldn't even be necessary if the Active Target would auto switch based on which project the currently highlighted file was from. Is there a way to do that?

Do you mean when it's using multiple project folders in one Atom window? If so, I've been meaning to change the behavior there so that it will remember which target was selected per project, and if any file in that project is currently active, it will run that target. Right now it's kind of silly that it builds Project A even if you're currently working in Project B just because you happened to build that last.

Exactly my point... Though pressing a 4 key shortcut isn't horrible for now... Thank you.


Add changes to expose metrics for installed knative version

JIRA: https://jira.coreos.com/browse/SRVKS-187
Description:
This PR include changes to expose installed knative version information to metric and servicemonitor.

This is not about metrics for the instance but about metrics for the operator itself. We need to know whichever namespace the operator is installed in so we can hook that up with the ServiceMonitor etc etc.
Especially in the light of SRVKS-214 the namespace entanglement might not be clear cut.

Umm... In my env I needed to creat the Role to monitor from Prometheus console, but Savita said that her test was fine. So, probably I am missing something... The code looks fine if @wtam2018's comments were addressed. (Thank you @wtam2018 !)

@markusthoemmes @wtam2018 @nak3 addressed all the comments and rebased PR

Closing
Addressed all the comments and raised same PR against TP1 branch
https://github.com/openshift-knative/knative-serving-operator/pull/54
Thank you


希望提供一个Widget 类似Cavnas 能够让开发者自己实现2D/3D效果  或者提供渲染相关的更底层的API

Looks Chinese. What does it mean?

I hope to provide a Widget like Cavnas that allows developers to implement 2D/3D effects themselves or provide rendering-related lower-level APIs.

What 2D/3D effects are you missing?

I seem to have found some of them in the ui library.


Error note while reading methylation data

While trying to read methylation data, following error occurs:
truncating string with embedded nuls”
Error in read.metharray(basenames = files, extended = extended, verbose = verbose, : [read.metharray] Trying to parse IDAT files with different array size but seemingly all of the same type.
  You can force this by 'force=TRUE', see the man page ?read.metharray
Traceback:

1. read.metharray.exp(targets = targets)
2. read.metharray(basenames = files, extended = extended, verbose = verbose,
 .     force = force)
3. stop("[read.metharray] Trying to parse IDAT files with different ",
 .     "array size but seemingly all of the same type.\n  You can force ",
 .     "this by 'force=TRUE', see the man page ?read.metharray")

based on this post, https://support.bioconductor.org/p/97773/ , this seems to be a common phenominum.

This looks good to me.  You don't get an error with force=TRUE.  What
you're seeing is that you have two sets of IDAT files scanned with
different scan settings (specifically with different DMAP files).  We see
this a lot with the EPIC array.  It is unfortunate that Illumina has
released some many DMAP files and so many different annotation versions for
this array, but that's how it is.

Best,
Kasper

this may be specific to our data but can also happen in others'. What's the implication here? Batch effects?

this may be specific to our data but can also happen in others'. What's the implication here? Batch effects?

I suppose this will be one implication, but we have something to handle batch effect in place.

Please make a note in your documentation on this error and point to this ticket for future reference where additional discussions might take place.

Done


Upload ICO Review Token (ICRT)

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[x] Filename in the lowercase format
[x] Image format: png
[x] Image size: 256 by 256 px

@ICRToken
Also, you can use these graphics to say that your ERC20 token fully compatible with Trust Wallet (https://trustwalletapp.com/logo-assets). Tokens will show up automatically once the user receives them.
Feel free to share this on social media and tag Trust Wallet:

Twitter: @trustwalletapp

Facebook: @trustwalletapp


nixos: add system.nixos.stateVersion alias (18.03)

Motivation for this change
The stateVersion option has been renamed in 18.09pre, so this adds forwards
compatibility for configurations that use the new option.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

I vote we revert the rename of the option, and document that randomly renaming options is bad exactly for these reasons so that this won't keep happening again.

I guess we can let @edolstra decide.

Unless there was a very compelling reason for renaming system.stateVersion, I'd say revert it.
@LnL7 Regarding users who may have already switched, well that's the risk of living on the unstable branch ;-)

That's fair, just wanted to mention it since it's been part of unstable for some time now. I didn't look into why this was renamed but I agree that it's probably not a good idea.

Revert in https://github.com/NixOS/nixpkgs/pull/44107

Closing since https://github.com/NixOS/nixpkgs/pull/44107 was merged.


ci: simplify commit lint

@ruudandriessen it's been a while 😁 . closing as it is stale. pls open a fresh one if still up for it


On push property change detect

resolves #559
This calls markForCheck() and checkForUpdates() for all properties on an ChangeDetection.OnPush component, when a property is updated, as well as fixes an issue with resolving the ChangeDetectionStrategy (when it's OnPush).

@igor-ka said :shipit:, but github being down prevented him from saying it himself. I swear.


Search youtube

Please describe the changes this PR makes and why it should be merged:

Add a search to YouTube button that does what it say

TODO

[x] Create popup/template

[ ] Finish styling
[ ] Finish adding buttons

[x] Add 'add to div' button
[ ] Add clear search button
[ ] Add search on enter
[ ] Add next page button

Merged do to rebranding, will merge TODO changes on other pr

Merged do to rebranding, will merge TODO changes on other pr


Add test & update

In this PR :

I  set up tests on the controllers I recently added to my Blog app.

Thank you very much @BregornOriginal.
I'll definitely tag you.


hundreds of inline 'body123' types when using large APIs (e.g. msgraph)

using the parser with flatten option+ codegen for generating java pojos we get hundreds of Body123 pojos.
Which makes them complicate to use in java. ... was it Body57 or Body59 that I need to send?
This happens to the extremes if I use ms-graph apis which contain many inline body types.
https://graphexplorerapi.azurewebsites.net/openapi?tags=me.user,me.calendar,users.calendar,me.message,me.Actions,me.todo&openApiVersion=3&graphVersion=v1.0&format=json&style=PowerShell
However, we could easily make things simpler and better to read, by adding path parts to the 'body' name. And therefore avoid too many instances of the same type with number postfixes.

Thanks for accepting the PR @gracekarina . So I'm happily closing this PR and switch to parser 2.0.26, once the final release is available. :+1:


Remove covid19.nhs.uk; site breaches PECR and GDPR

The website https://covid19.nhs.uk/ currently unlawfully includes advertiser tracking.
The site has adopted Youtube in such a way that it exposes users to the tracking systems of Youtube and Doubleclick.
I've posted details here
https://markalanrichards.com/2020/05/15/covid19-app-website-includes-advertiser-tracking.html
Please remove references to it so that users may not be directed to this content from the app.

Removing trackers would also close #11


PhpStorm code inspection cleanups

This fixes most issues, there are a few left, practically all stemming from the slightly sloppy usage of traits for fields and types. I figured it's not worth trying to work around those with phpdoc annotations, instead they should ideally be refactored somewhat.
The most notable changes are:

https://github.com/digiaonline/GraphQL/commit/248f0ae44e6b2783d64ffe56933acec1c1249397 removes a new ResolveInfo call, may speed things up a tiny bit
https://github.com/digiaonline/GraphQL/commit/c422fc044408259ad512f579d9f4bc94f17df254 removes two unused traits. They have been marked as deprecated and the TODO says they should be removed in the next release, so I figured why not.

Scrutinizer seems to be happy at least:

Good job, 12 issues were fixed.

Test Coverage has increased to 91% (+2%)

Everything looks fine except the removal of the DirectiveTrait. It was WIP that got merged into the branch, but it will be used in the future release. Can you revert that one?

Sure, I'll drop that commit

@viniychuk done

@Jalle19 sorry, if you could fix the conflicts — I'll merge it again and publish today

@viniychuk I'm at a hotel with restricted Internet but I'll rebase next weekend or when I find a better connection.

@viniychuk rebased

@viniychuk are the tests supposed to pass?

https://travis-ci.org/Youshido/GraphQL/jobs/259325602 apparently not

The master branch is fixed. I was looking through the changes and have noticed this: http://take.ms/G4q4L — got it restored.

Not really sure what you mean, but thanks for merging.


Fix bug not showing orgs the user is an admin of.  Fixes #491.

-- confirm only admin roles exist
select count(*), metadata->>'role' from organizationmembercache group by metadata->>'role'; ;

count
role

4
admin

Before this commit, orgs that a user is an admin of show up in the “available organizations” area.

After this commit, those orgs show up as orgs the uers is a member of.

Note:
I have not performed an exhaustive analysis to see if the new in logic should be used in any other views.

@microsoft-github-policy-service agree


fix: file name bug

Addressed issue where file names were not being properly parsed from the response headers.
Updated tests to ensure that the file name is properly parsed from the response headers.

:tada: This PR is included in version 1.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Exclusivity] Relax enforcement for separate struct stored properties

Relax the static enforcement of exclusive access so that we no longer diagnose
on accesses to separate stored structs of the same property:
takesInout(&s.f1, &s.f2) // no-warning
And perform the analogous relaxation for tuple elements.
To do this, track for each begin_access the projection path from that
access and record the read and write-like modifications on a per-subpath
basis.
We still warn if the there are conflicting accesses on subpaths where one is
the prefix of another.
This commit leaves the diagnostic text in a not-so-good shape since we refer
to the DescriptiveDeclKind of the access even describing a subpath.
I'll fix that up in a later commit that changes only diagnostic text.
https://bugs.swift.org/browse/SR-5119
rdar://problem/31909639
Resolves SR-5119.

@swift-ci Please smoke test and merge