Updated Icon Contact Us

Updated the icon for 'Contact Us'
Related Issue

'About Us' In the Sidebar had the same icon as the 'Contact Us'

Closes: #259
Description of Changes

Changed the icon for 'Contact Us' in the Sidebar
Both have different icons now

Checklist:

[x] My code adheres to the established style guidelines of this project.
[x] I have conducted a self-review of my code.
[x] I have included comments in areas that may be difficult to understand.
[x] I have made corresponding updates to the project documentation.
[x] My changes have not introduced any new warnings.

Screenshots

Original
Updated

@AKD-01 Have done the necessary changes please check.


[1.12.2] Adding block with different texture on each side

Hi. I tried to add block with different textures on each side. I tried to add new model
{   "parent": "block/cube",   "textures": {     "down": "contenttweaker:blocks/BLOCK_NAME_HERE"},     "up": "contenttweaker:blocks/BLOCK_NAME_HERE"},     "north": "contenttweaker:blocks/BLOCK_NAME_HERE"},     "south": "contenttweaker:blocks/BLOCK_NAME_HERE"},     "west": "contenttweaker:blocks/BLOCK_NAME_HERE"},     "east": "contenttweaker:blocks/BLOCK_NAME_HERE"},   "elements": [     {       "from": [ 0, 0, 0 ],       "to": [ 16, 16, 16 ],       "faces": {         "down":  { "texture": "#down", "cullface": "down" },         "up":    { "texture": "#up", "cullface": "up" },         "north": { "texture": "#north", "cullface": "north" },         "south": { "texture": "#south", "cullface": "south" },         "west":  { "texture": "#west", "cullface": "west" },         "east":  { "texture": "#east", "cullface": "east" }       }     }   ] }
And then add new blockstate
{   "forge_marker": 1,   "defaults": {     "textures": {     "down": "contenttweaker:blocks/BLOCK_NAME_HERE"},     "up": "contenttweaker:blocks/BLOCK_NAME_HERE"},     "north": "contenttweaker:blocks/BLOCK_NAME_HERE"},     "south": "contenttweaker:blocks/BLOCK_NAME_HERE"},     "west": "contenttweaker:blocks/BLOCK_NAME_HERE"},     "east": "contenttweaker:blocks/BLOCK_NAME_HERE"},       "particle": "contenttweaker:blocks/BLOCK_NAME"     },     "model": "contenttweaker:BLOCK_NAME",     "uvlock": true,     "transform": "forge:default-block"   },   "variants": {     "normal": [{}],     "inventory": [{}]   } }
But no way that I'm trying, block in the game has no texture. Could someone tell me what to do?

I had the same problem.
block in the world has no texture but the item in GUI or Inventory has textures. I can't figure out why.  I was trying to add a custom slab—just a simple half-block.


Modular Rendering

This changes how render logic is composed to make it much more modular. Previously, all extraction logic was centralized for a given "type" of rendered thing. For example, we extracted meshes into a vector of ExtractedMesh, which contained the mesh and material asset handles, the transform, etc. We looked up bindings for "drawn things" using their index in the Vec<ExtractedMesh>. This worked fine for built in rendering, but made it hard to reuse logic for "custom" rendering. It also prevented us from reusing things like "extracted transforms" across contexts.
To make rendering more modular, I made a number of changes:

Entities now drive rendering:

We extract "render components" from "app components" and store them on entities. No more centralized uber lists! We now have true "ECS-driven rendering"
To make this perform well, I implemented #2673 in upstream Bevy for fast batch insertions into specific entities. This was merged into the pipelined-rendering branch here: #2815

Reworked the Draw abstraction:

Generic PhaseItems: each draw phase can define its own type of "rendered thing", which can define its own "sort key"
Ported the 2d, 3d, and shadow phases to the new PhaseItem impl (currently Transparent2d, Transparent3d, and Shadow PhaseItems)
Draw trait and and DrawFunctions are now generic on PhaseItem
Modular / Ergonomic DrawFunctions via RenderCommands

RenderCommand is a trait that runs an ECS query and produces one or more RenderPass calls. Types implementing this trait can be composed to create a final DrawFunction. For example the DrawPbr DrawFunction is created from the following DrawCommand tuple. Const generics are used to set specific bind group locations: pub type DrawPbr = (
    SetPbrPipeline,
    SetMeshViewBindGroup<0>,
    SetStandardMaterialBindGroup<1>,
    SetTransformBindGroup<2>,
    DrawMesh,
);

The new custom_shader_pipelined example illustrates how the commands above can be reused to create a custom draw function:type DrawCustom = (
    SetCustomMaterialPipeline,
    SetMeshViewBindGroup<0>,
    SetTransformBindGroup<2>,
    DrawMesh,
);

ExtractComponentPlugin and UniformComponentPlugin:

Simple, standardized ways to easily extract individual components and write them to GPU buffers

Ported PBR and Sprite rendering to the new primitives above.
Removed staging buffer from UniformVec in favor of direct Queue usage

Makes UniformVec much easier to use and more ergonomic. Completely removes the need for custom render graph nodes in these contexts (see the PbrNode and view Node removals and the much simpler call patterns in the relevant Prepare systems).

Added a many_cubes_pipelined example to benchmark baseline 3d rendering performance and ensure there were no major regressions during this port. Avoiding regressions was challenging given that the old approach of extracting into centralized vectors is basically the "optimal" approach. However thanks to a various ECS optimizations and render logic rephrasing, we pretty much break even on this benchmark!
Lifetimeless SystemParams: this will be a bit divisive, but as we continue to embrace "trait driven systems" (ex: ExtractComponentPlugin, UniformComponentPlugin, DrawCommand), the ergonomics of (Query<'static, 'static, (&'static A, &'static B, &'static)>, Res<'static, C>) were getting very hard to bear. As a compromise, I added "static type aliases" for the relevant SystemParams. The previous example can now be expressed like this: (SQuery<(Read<A>, Read<B>)>, SRes<C>). If anyone has better ideas / conflicting opinions, please let me know!
RunSystem trait: a way to define Systems via a trait with a SystemParam associated type. This is used to implement the various plugins mentioned above. I also added SystemParamItem and QueryItem type aliases to make "trait stye" ecs interactions nicer on the eyes (and fingers).
RenderAsset retrying: ensures that render assets are only created when they are "ready" and allows us to create bind groups directly inside render assets (which significantly simplified the StandardMaterial code). I think ultimately we should swap this out on "asset dependency" events to wait for dependencies to load, but this will require significant asset system changes.
Updated some built in shaders to account for missing MeshUniform fields

Examples needs to be added to examples/README.md
:)

bors r+


Get current EventId  and activityId and put in session

Currently, the EventId is hard to code as 1; it needs to get from the event table for the last active event
check the logic in the guest login, also need change to use last active event
the value for Judge should be use LoginUser
after inserting the new activities, you need to get the current activityId,  and it needs to be stored in the session and will be inserted into the records table as FK.

for #3 insert new row and get a id, see example:  https://stackoverflow.com/questions/897356/php-mysql-insert-row-then-get-id


62 full birthday

Closes #62.

Ask for birthday instead of just birth year when creating a new patient.
Only birthdays in the eligible age range (15-24) can be selected in the date picker.
Display patient's age on patient screen.

Codecov Report

Merging #82 into develop will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           develop     #82      +/-   ##
==========================================
- Coverage     5.36%   5.34%   -0.03%
==========================================
  Files           61      61
  Lines         6262    6287      +25
==========================================
  Hits           336     336
- Misses        5926    5951      +25

Impacted Files
Coverage Δ

lib/database/models/Patient.dart
0% <0%> (ø)
:arrow_up:

lib/screens/PatientScreen.dart
0.19% <0%> (ø)
:arrow_up:

lib/database/DatabaseProvider.dart
3.65% <0%> (-0.05%)
:arrow_down:

lib/utils/Utils.dart
0.65% <0%> (-0.04%)
:arrow_down:

lib/screens/NewPatientScreen.dart
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6cf82d...1d2672c. Read the comment docs.


Encoding issue with french text

I have issues on my displayed messages. They are in french and characters like "é" and "è" are replaced by "?". I've look through the code, and I can't tell what's wrong with the encoding, but the fact is it's not working well.
You maybe should use a different ISO...
I just noticed that the "¤" isn't working too.
Thanks for the future fix :)

Well, syntax coloring should not affect that.
What CP do you use? You can get this information running
display session:cpstream session:cpinternal.

1252 utf-8

And the file you are writing is in UTF-8?

it is yes. I wrote this on procedure editor, just works fine.
Opened it with youre extension, and saw "?" on every special character.

And the problem persists when you deactivate/remove this extension? You use it in OpenEdge Architect I presume.

Still got this � when it is removed.
It appears that it's more from Code Visual than youre extension.
It works with notepad but not with visual.


arch: arm, arm64: Disable swi_tables.ld file when not required

This commit removes the need of swi_tables.ld file if the ISR table generator is not configured to use it.
Fixes #68508

Please include something like the following information:

Linking in Zephyr / CMake.

Ninja invokes linking directly from <build>.
Make invokes linking form <build>/zephyr.

The linker default uses cwd for looking up INCLUDE directives if not found in list of includes.
Zephyr always adds <build>/zephyr as link include using CMake,
and this is passed to ld as -L<build>/zephyr  therefore using INCLUDE isr_tables_swi.ld ensures it will be correctly found in all cases.

I made a comment in the original PR, but these changes are important enough they really need to go into the release notes. A separate PR can be raised for that, though.

And fixed spaces. But please take a note that we are not consistent about defined and space after it. Personally I prefer it anyway how @pdgendt suggested - just aligned previously my style to the one found in the near surrounding.

@microbuilder

I made a comment in the original PR, but these changes are important enough they really need to go into the release notes. A separate PR can be raised for that, though.

Here is proposal: #68542 68542


Husky/Jackal PID values missing

So, I was using husky and Jackal for my application. I was not getting any error until i updated my protobuff in /usr/loca/include/google and gazebo. So now I'm getting this error for both the robot

Anybody has any idea about this? I don't think we need to add specifically PID values. It's just not taking the values from gazebo_ros_control.
If the PID values need to be assigned separately in control.yaml, What should be the values in that case then??

This is a bug in Gazebo.  See the comments here: https://answers.ros.org/question/293830/what-is-the-fix-for-no-p-gain-specified-for-pid-namespace-gazebo_ros_controlpid_gainsback_right_wheel_joint-ros-melodic/
and here: https://github.com/ros-simulation/gazebo_ros_pkgs/blob/e42cc26a473733b05abc648181a6de1286105ed6/gazebo_ros_control/src/default_robot_hw_sim.cpp#L218
Basically Husky does not use PID values to control the wheels, so we do not specify them in control.yaml.  If you try adding PID values the simulated Husky will not move correctly.  Gazebo is reporting this as an error in its output, even though it's by design that you can omit the PID values in order to force gazebo to use the SetAngle or SetParam(vel) functions.


chore: clean-up automation

:tada: This PR is included in version 1.0.44 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Go executable available after build?

It would be useful to have the go command available after the compile step for running management commands (with go run).
Is there any reason it's not currently available? I see that it is installed in ${build_dir}/.heroku/go, but ${build_dir}/.heroku is removed after compiling.

This is a tough call. My two cents:
I agree it's useful to be able to 'go run' things in the app. On the other hand, the slug would be bigger if it included the compiler and standard library. The common case is starting ordinary dynos that don't need the compiler, and a larger slug makes dynos take longer to start up.
I'm not sure if it's worth making that common operation slower for the benefit of running management commands, especially since you can still run those management commands on other systems such as your laptop (possibly after first loading environment variables from the app's config). On the other hand, sometimes there's a significant advantage to running management processes in a dyno inside AWS with fast network RTT to the other services such as a database. This can mean the difference between minutes and hours for some tasks.
Here's a possible alternative. The buildpack could include a shell script to install the go compiler. It could install this script into the slug filesystem as a command like 'get-go-compiler'. That way, ordinary dynos wouldn't have to suffer the overhead of including the whole go compiler, and one-off dynos can still use the compiler with heroku run get-go-compiler '&&' go run foo.go. If we wanted to get fancy, this shell script could be installed under the name go and it could install the compiler on demand, otherwise transparently invoking the go tool. Then the usage would be easier, heroku run go run foo.go. I'd write a patch for this if other folks think it's a good idea.

 This is the way the docker image works right now and I'm been thinking of aligning them.
@ecordell What are your use cases for having go available in the slug?

Closing as it's been here for a long time w/o response.


Register the package on packagist

The package is not available on packagist despite there is a composer require sitegeist/inspectorgadget advice in the documentation.

Thanks for the reminder, the package has now really been published:
https://packagist.org/packages/sitegeist/inspectorgadget


[ASK] xDeepFM - Help on saving model checkpoint to Azure ML output directory

Description

I've taken the xDeepFM deep dive notebook and adapted it so that it can run in Azure Machine Learning Service. I would like Azure to capture the model checkpoints and associated files so that I can download the best run and visualize training in Tensorboard, as well as restore the model at a later point in time. Currently, I do not see any of the model files captured (AML Service needs these to be in the outputs directory).

It appears that MODEL_DIR is used in a concatenation above. Should MODEL_DIR be passed in the form of a string such as './outputs' or as an os.path.join type construct?

When I tried the above on my local machine, I get the summaries nicely placed in the summaries directory under the outputs directory as I would expect. However the model files are placed in the outputs directory and are prepended with "model"

When I run this in Azure ML Service, summary files and model files are not available for download. My hunch is that the relative directory must be off.
Any tips on how to set up MODEL_DIR correctly in order to get the files placed in the outputs directory and how to set this up for running in Azure ML Service would be welcome.
Other Comments

maybe @eedeleon can help here?

@miguelgfierro: I have a solution to this problem. It involves adding a "/" to the save_path string as shown below:

This code is located in base_model.py. I have validated that this works on the Azure Machine Learning service.

I'm in the process of validating that the change works on local notebooks as well. Will you accept a pull request for this?

@miguelgfierro: Just finished testing this change on the local xdeeepfm notebook in 00_quick_start:

contents of the local folder in my C: drive -

Thanks @elogicaadith I added a comment, can you please take a look?


make decimalPlaces work for StackedBar Chart

I was trying to fixed my numbers to 0 decimals I tried alot until I decided to see why it not work from the source code, so I found that the decimalPlaces didn't destructed from the props and not passed to the horizontal labels, so I fixed it by destructing and pass it as a prop to horizontal labels.

Thanks! v4.5.0 is up on npm


Add ES6 module build

Snabbdom cannot be scope hoisted because it only has a commonjs build.
The package.json file allows for a second entry module near main that can be used to additionally provide an ES6 build.
The problem is that snabbdom has many snabbdom/XX modules, that makes this harder to solve (ie impossible without restructuring or splitting in multiple packages)

It is certainly doable. We can start by generating the output in ES6 module format into a folder, and update pkg.json with the module configuration. The good news here is that we can use this opportunity to readjust a little bit the API when using it via ES6 modules (this does not have to be backward compatible). There is a very old PR https://github.com/snabbdom/snabbdom/pull/247 that we should probably attempt to revamp for this.

I think this is solved by now. Last release as es folder

Thank you for using snabbdom.
An ES modules build is provided since fc47e2c9b1bd1dfdaeea7b86227c7b75be14a071.

@mightyiam yes but we would be very pleased about more attention on https://github.com/snabbdom/snabbdom/pull/247#issuecomment-422414530 (and while #247, #225 and issues pointed in that comment) :smile: Thanks!


New version: Albion.Online version<PHONE_NUMBER>3145

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

It appears that the developer reverted to a previous version.


.circleci: fix build-and-publish-container workflow

Closing this PR as this issue was fixed here: https://github.com/beamer-bridge/beamer/pull/1294


CSHARP-2239: Refactor ChangeStreamDocument to be a BsonDocumentBasedClass

Checking whether Evergreen is working for us again:
https://evergreen.mongodb.com/version/5b042961e3c3310342a51a89

Fixed commit message and pushed to master.


updated error description to be more descriptive

This error message was causing me a bit of a headache because I never knew which element caused it.
Appending the selector helps a little. Hope that helps others too.

I'm happy to merge this if you don't mind rebasing with master. Also, you may consider either not defining selector or using it for the other two references to opts.element

Hi @b-ash. Ouch I just saw that you wanted a rebase. I just pulled from master basically, let me know if that's cool.
Also btw, having the bundled javascript in the git repo makes for a very noisy git history.
You could probably have a preinstall hook in your package.json that way the project builds automatically when you install the package.

Thanks for the update. Keeping the compiled JS in the repo is indeed a bit of a pain, but it lowers the barrier to entry for folks wanting to toss it in their project quickly. We'll keep it in mind going forward if it becomes a real burden :smile_cat:

Thanks for merging. FYI ->
https://help.github.com/articles/creating-releases/
On Thu, Apr 2, 2015 at 6:42 PM, b-ash<EMAIL_ADDRESS>wrote:

Thanks for the update. Keeping the compiled JS in the repo is indeed a bit
of a pain, but it lowers the barrier to entry for folks wanting to toss it
in their project quickly. We'll keep it in mind going forward if it becomes
a real burden [image: :smile_cat:]
—
Reply to this email directly or view it on GitHub
https://github.com/HubSpot/shepherd/pull/51#issuecomment-88969748.


feat: add an optional summary row to Datagrid

🙋 Feature Request
It would be nice to be able to add an optional summary row which aggregates data from RowsData.
For example, here's a green summary row that summarizes the two rows above:

💁 Possible Solution
One possible design would be to add a property ShowRowSummary="true" on the grid itself, then a property on the columns that configures how cells are aggregated:
    <FluentDataGrid RowsData="@MyBankAccounts.AsQueryable()" ShowRowSummary="true">
        <PropertyColumn Property="@(p => p.Title)" Sortable="true" />

        <PropertyColumn Property="@(p => p.Balance)" Sortable="true" SummaryAggregate="Sum">
    </FluentDataGrid>

SummaryAggregate could then perhaps be one of Sum, Max, Min, Average, Median.

Converting this to a discussion item as it is not an issue


Added my school details for London Institute of Banking and Finance

Domain for LIBF students is libfstudy.ac.uk

@oggie-z Please provide us with a proof, which shows that the school recognizes the domain libfstudy.ac.uk you are submitting as an official email domain for the students.
You can provide us with any of the following:

A copy of instruction (a hard-copy or electronic one) given to you by the school that tells you to use an email address in this email domain
An URL of a page at the official school website that says that students use this email domain
A reference to a recognized journal where an article was published by someone from the school, with explicit affiliation to the school, and e-mail address from the email domain
A WHOIS data that link the email domain to the school somehow
A copy of official letter from the school representative saying that the school provides e-mail addresses in this domain to the students
Anything else that can prove this fact in similar way, i.e. can be verified independently.

@oggie-z You might miss my previous comment. Please react.

@oggie-z You might miss my previous comment. Please react.

Ok I will get the info requested

@oggie-z Please provide us with an update.

@oggie-z You might miss my previous comment. Please react.

@oggie-z I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!


[bug]: channel event update "active" received but GetChanInfo fails as edge is not yet in graph

Background
When opening a trusted channel between two peers while one peer is subscribed to channel events, it can sometimes happen that the "active" update about a newly opened channel is received before the channel edge is added to LNDs router, preventing proper use of GetChanInfo. An excerpt from the (attached lnd1.log) detailing this behavior:
2023-01-18 20:58:28.838 [DBG] PEER: Peer(022b26cbddc58b9ecfb81adfa7dffa8014dee0641d2e2868fdb021d86839cf010e): Received FundingLocked(chan_id=0ebd171c3e073129172d4a7765613daad9cb715dce437729a952e5c0cc1a2db7, next_point=03baa763f2ced13f43258da0b05068fd8371503e0acee93c9f0980c2499408c53e) from 022b26cbddc58b9ecfb81adfa7dffa8014dee0641d2e2868fdb021d86839cf010e@<IP_ADDRESS>:49420
2023-01-18 20:58:28.838 [DBG] FNDG: Received FundingLocked for ChannelID(0ebd171c3e073129172d4a7765613daad9cb715dce437729a952e5c0cc1a2db7) from peer 022b26cbddc58b9ecfb81adfa7dffa8014dee0641d2e2868fdb021d86839cf010e
2023-01-18 20:58:28.838 [DBG] LNWL: ChannelPoint(b72d1accc0e552a9297743ce5d71cbd9aa3d6165774a2d172931073e1c17bd0e:0): Restoring 0 dangling remote updates
2023-01-18 20:58:28.838 [DBG] LNWL: ChannelPoint(b72d1accc0e552a9297743ce5d71cbd9aa3d6165774a2d172931073e1c17bd0e:0): Restoring 0 local updates that the peer should sign
2023-01-18 20:58:28.838 [DBG] FNDG: Channel(0ebd171c3e073129172d4a7765613daad9cb715dce437729a952e5c0cc1a2db7) with ShortChanID 16000000:0:2 has opening state markedOpen
2023-01-18 20:58:28.838 [DBG] SRVR: Notifying that peer 022b26cbddc58b9ecfb81adfa7dffa8014dee0641d2e2868fdb021d86839cf010e is online
2023-01-18 20:58:28.838 [INF] FNDG: Peer(022b26cbddc58b9ecfb81adfa7dffa8014dee0641d2e2868fdb021d86839cf010e) is online, sending FundingLocked for ChannelID(0ebd171c3e073129172d4a7765613daad9cb715dce437729a952e5c0cc1a2db7)
2023-01-18 20:58:28.838 [DBG] PEER: Peer(022b26cbddc58b9ecfb81adfa7dffa8014dee0641d2e2868fdb021d86839cf010e): Sending FundingLocked(chan_id=0ebd171c3e073129172d4a7765613daad9cb715dce437729a952e5c0cc1a2db7, next_point=024be15b07baaef7cb5a7817453fd149a85ba4e70208741feaa4259e315c77f1b6) to 022b26cbddc58b9ecfb81adfa7dffa8014dee0641d2e2868fdb021d86839cf010e@<IP_ADDRESS>:49420
2023-01-18 20:58:28.839 [DBG] NTFN: Updated spend hint to height=488 for unconfirmed spend request outpoint=b72d1accc0e552a9297743ce5d71cbd9aa3d6165774a2d172931073e1c17bd0e:0, script=0 11eb02ed37a8a5d278480e7816fd939eb581c857453a9efb8900dca25c2f58f8
2023-01-18 20:58:28.840 [DBG] FNDG: Channel(0ebd171c3e073129172d4a7765613daad9cb715dce437729a952e5c0cc1a2db7) with ShortChanID 16000000:0:2: successfully sent FundingLocked
2023-01-18 20:58:28.840 [DBG] FNDG: Channel(0ebd171c3e073129172d4a7765613daad9cb715dce437729a952e5c0cc1a2db7) with ShortChanID 16000000:0:2 has opening state fundingLocked
2023-01-18 20:58:28.840 [DBG] SRVR: Notifying that peer 022b26cbddc58b9ecfb81adfa7dffa8014dee0641d2e2868fdb021d86839cf010e is online
2023-01-18 20:58:28.843 [INF] CHBU: Updating backup file at /tmp/lndtest-node637347766/data/chain/bitcoin/regtest/channel.backup
2023-01-18 20:58:28.844 [INF] CHBU: Swapping old multi backup file from /tmp/lndtest-node637347766/data/chain/bitcoin/regtest/temp-dont-use.backup to /tmp/lndtest-node637347766/data/chain/bitcoin/regtest/channel.backup
2023-01-18 20:58:28.850 [DBG] LNWL: ChannelPoint(b72d1accc0e552a9297743ce5d71cbd9aa3d6165774a2d172931073e1c17bd0e:0): Restoring 0 dangling remote updates
2023-01-18 20:58:28.850 [DBG] LNWL: ChannelPoint(b72d1accc0e552a9297743ce5d71cbd9aa3d6165774a2d172931073e1c17bd0e:0): Restoring 0 local updates that the peer should sign
2023-01-18 20:58:28.850 [INF] PEER: Peer(022b26cbddc58b9ecfb81adfa7dffa8014dee0641d2e2868fdb021d86839cf010e): New channel active ChannelPoint(b72d1accc0e552a9297743ce5d71cbd9aa3d6165774a2d172931073e1c17bd0e:0) with peer
2023-01-18 20:58:28.850 [DBG] CNCT: New ChainEventSubscription(id=1) for ChannelPoint(b72d1accc0e552a9297743ce5d71cbd9aa3d6165774a2d172931073e1c17bd0e:0)
2023-01-18 20:58:28.850 [INF] HSWC: ChannelLink(b72d1accc0e552a9297743ce5d71cbd9aa3d6165774a2d172931073e1c17bd0e:0): starting
2023-01-18 20:58:28.851 [INF] HSWC: Trimming open circuits for chan_id=16000000:0:2, start_htlc_id=0
2023-01-18 20:58:28.851 [INF] HSWC: Adding live link chan_id=0ebd171c3e073129172d4a7765613daad9cb715dce437729a952e5c0cc1a2db7, short_chan_id=16000000:0:2
2023-01-18 20:58:28.851 [INF] CNCT: Attempting to update ContractSignals for ChannelPoint(b72d1accc0e552a9297743ce5d71cbd9aa3d6165774a2d172931073e1c17bd0e:0)
2023-01-18 20:58:28.851 [INF] HSWC: ChannelLink(b72d1accc0e552a9297743ce5d71cbd9aa3d6165774a2d172931073e1c17bd0e:0): HTLC manager started, bandwidth=244999996100000 mSAT
2023-01-18 20:58:28.851 [DBG] HSWC: ChannelLink(b72d1accc0e552a9297743ce5d71cbd9aa3d6165774a2d172931073e1c17bd0e:0): loaded 0 fwd pks
2023-01-18 20:58:28.855 [DBG] RPCS: [updatechanpolicy] updating channel policy base_fee=0, rate_fixed=0, time_lock_delta: 40, min_htlc=<nil>, max_htlc=0 mSAT, targets=([]wire.OutPoint) (len=1 cap=1) {
 (wire.OutPoint) b72d1accc0e552a9297743ce5d71cbd9aa3d6165774a2d172931073e1c17bd0e:0
}

2023-01-18 20:58:28.857 [ERR] RPCS: [/lnrpc.Lightning/GetChanInfo]: edge not found
2023-01-18 20:58:28.857 [INF] NTFN: Cancelling epoch notification, epoch_id=10```

Your environment

version of lnd: 0.15.99-beta commit=kvdb/v1.2.1-1645-g4e3decd26 (https://github.com/guggero/lnd/tree/musig2-versioned-rpc)
which operating system (uname -a on *Nix): 5.19.0-26-generic Ubuntu 22.10
version of btcd, bitcoind, or other backend: 22.0
any other relevant environment details

Steps to reproduce

Two peers open a trusted channel and one of them subscribes to channel events
Once the active update arrives one of them call GetChanInfo

Expected behaviour

GetChanInfo should succceed.

Actual behaviour

GetChanInfo failes with "edge not found" error

lnd2.log
lnd1.log

I think this can happen independent of zero-conf channels

I think this can happen independent of zero-conf channels

Yeah afaict it's just the case that the event propagates befre the cannel edge is added to the router.

Yeah afaict it's just the case that the event propagates before the channel edge is added to the router.

Does a sleep before the GetChanInfo call change this behavior?

Yeah afaict it's just the case that the event propagates before the channel edge is added to the router.

Does a sleep before the GetChanInfo call change this behavior?

A sleep can be used to work around this issue from the RPC client's perspective, however the correct behavior should be that state transition also implies that the channel edge is at that point already is in the local channel graph (meaning that the state transition after funding locked is "atomic" from the RPC client's pov).

Does this pr https://github.com/lightningnetwork/lnd/pull/7264 address this?

Does this pr #7264 address this?

No I don't think so - this can also happen independently of zero-conf so I removed the label


remove useRef for muscleData

feel free not to accept this, but we are currently using the body part highlighter to select muscles and then show them colored in on selection.
The upgrade to version 2 added React.useRef around the muscleData that is passed in, so the Model component won't update as muscleData changes (only if we dismount / completely re-render).

Makes sense, thanks!


Add AsInterface support for generated COM interfaces.

Closes #1533.

[!NOTE]
I would recommend reviewing this with whitespaces disabled.

Can we add a unit test?

Does the CI run the unit tests in .NET 8 or only in .NET 6? The Directory.Build.props file specifies that the unit tests are only up to .NET 6 locally but .NET 8 on CI?

CI runs all 3 TFMs listed (netcoreapp3.1, net6.0, net8.0).  For local runs we drop net8 just to save time, but you can manually add it to AppBuildTFMs for your testing purposes.

I've copied the COM Import unit test and modified it to use generated COM interfaces instead, though I'm not too certain about the signatures of both.

Looks like the following 3 authoring tests regressed in non AOT scenarios.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] AuthoringTest.Statics
[  FAILED  ] AuthoringTest.Events
[  FAILED  ] AuthoringTest.ExplicitInterfaces

Oh, I don't test against authoring as building the WinRT projection for the Windows namespace is very time consuming on my machine.
However though, I'm not sure how Authoring utilizes IWinRTObject, but if it turns out to rely on the signature of the interface I guess we could implement IUnmanagedVirtualMethodTableProvider lazily through IDynamicInterfaceCastable, like Jeremy suggested.

Oh, I don't test against authoring as building the WinRT projection for the Windows namespace is very time consuming on my machine.
However though, I'm not sure how Authoring utilizes IWinRTObject, but if it turns out to rely on the signature of the interface I guess we could implement IUnmanagedVirtualMethodTableProvider lazily through IDynamicInterfaceCastable, like Jeremy suggested.

I will see if I can get the exception stacks when I get a chance and get back to you.  That should tell us what is failing.

The exception was Method 'GetVirtualMethodTableInfoForKey' in type 'NativeDelegateWrapper' from assembly 'AuthoringTest, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have an implementation.  But looking more into it, it looks like the AuthoringTest was built for .NET 8 with the .NET 8 WinRT.Runtime, but the native app that consumes it bundled a .NET 6 version of WinRT.Runtime.  I think this is a test authoring error rather than a real scenario.  So, I tried a change to fix the test and it seems to work.  I think you should add that change to your PR and that should address the test failures.
Change: https://github.com/microsoft/CsWinRT/commit/fe2813313a4bfb70b7559200d955e264d6e36e77

I’ve cherry picked the change in, thanks.

Thanks for addressing all the feedback, will merge once CI passes.


Include Windows pre-compiled builds

Working on it, but it's very hard: compiling Faiss is tricky, and doing it on Windows is even harder. I'm trying, but it'll take some time.
In the meantime, consider WSL and using the pre-built extensions for linux x86_64

https://github.com/facebookresearch/faiss/issues/2551 seem to be a common difficulty


SD-884: utilize http4s FileService

supersedes #958

Current coverage is 84.66%

Merging #961 into master will increase coverage by +0.58% as of 0d27e73

@@            master    #961   diff @@
======================================
  Files            6       6
  Stmts          578     574     -4
  Branches        31      34     +3
  Methods          0       0
======================================
  Hit            486     486
  Partial          0       0
+ Missed          92      88     -4

Review entire Coverage Diff as of 0d27e73

Powered by Codecov. Updated on successful CI builds.


When the Python SDK is published remove the Python SDK locally

for this when we release the pythonSDK we will also be able to pull the SDK in via the requirements instead of have a full copy of the SDK
this will require us to publish the SDK

@mark-at-pieces this is resolved now with our package management and release pipelines


We should probably stop trying to validate email addresses

pkg/validator/validator.go validates emails with a big long regexp; this probably does more harm than good:

https://medium.com/hackernoon/the-100-correct-way-to-validate-email-addresses-7c4818f24643
https://en.wikipedia.org/wiki/ReDoS

We can probably confirm the address has an @ in it and leave it at that.

we could use https://www.mailgun.com/email-validation, at least for the SaaS


IOU - As admin if opens chat, money transaction is blank& in amount space only tick mark is shown

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.83-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to https://staging.new.expensify.com/

Login as employee

Tap on chat DM 1:1 with admin

Tap plus icon

Select send money

Enter an amount

Tap next

Tap Pay elsewhere

Login as admin in other device

Tap on 1:1 DM with employee

Tap on the IOU transaction (money which is sent)

Note blank space is shown instead of IOU amount details

Tap on the the skeleton IOU

Expected Result:
User must be able to see the amount, skeleton IOU must not be shown and tapping on it, amount should be shown along with green tick mark
Actual Result:
User can see only skeleton IOU and tapping on it, amount is not shown along with green tick mark
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

https://github.com/Expensify/App/assets/78819774/891de1c2-35d5-4a14-ab80-efe4ea5dcfe6
https://github.com/Expensify/App/assets/78819774/8b682d9a-048c-4e98-a165-bf8a3f611d27

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

I'm OOO Oct 16-23. Adding leave buddy

Sounds good, I will triage!

I just tried, and I'm unable to reproduce this, so going to close!


Consider filtering options for the ListTasks endpoint

Currently the ListTasksRequest contains a couple fields for filtering
message ListTasksRequest {

  // OPTIONAL
  //
  // Filter the task list to include tasks in this project.
  string project = 1;

  // OPTIONAL
  //
  // Filter the list to include tasks where the name matches this prefix.
  // If unspecified, no task name filtering is done.
string name_prefix = 2;

...

There have been suggestions for changing this:

Remove project and name_prefix
Allow filtering on Task.state and Task.tags

#92 is where most of the work is happening

The current proposal is reflected in #104. This approach would require a switch to OpenApi 3.0

@kellrott has this been addressed by #170


Parsing error. When using cfscript reserved words.

Example:
<cfset switch = lv_struct_include_params.phase />
returned InputMismatchException
mismatched input 'switch' expecting {BOOLEAN_LITERAL, OPEN_STRING, PAGE_ENCODING, CONTAINS, CONTAIN, GT, GTE, LTE, LT, EQ, NEQ, OR, TO, IMP, EQV, XOR, AND, NOT, MOD, VAR, NEW, FUNCTION, DEFAULT, '.', '+', '++', '-', '--', '!!', '!', '[', '(', '{', INCLUDE, IMPORT, ABORT, ADMIN, THROW, RETHROW, EXIT, PARAM, PROPERTY, LOCK, THREAD, TRANSACTION, SAVECONTENT, HTTP, CFHTTP, FILE, DIRECTORY, LOOP, SETTING, QUERY, STRING, NUMERIC, BOOLEAN, ANY, ARRAY, STRUCT, PRIVATE, PUBLIC, REMOTE, PACKAGE, REQUIRED, COMPONENT, INTERFACE, LOG, APPLET, ASSOCIATE, AUTHENTICATE, CACHE, COL, COLLECTION, CONTENT, COOKIE, ERROR, EXECUTE, FORM, FTP, GRID, GRIDCOLUMN, GRIDROW, GRIDUPDATE, HEADER, HTMLHEAD, HTTPPARAM, CFHTTPPARAM, IMPERSONATE, INDEX, INPUT, INSERT, LDAP, LOCATION, MAIL, MAILPARAM, MODULE, OBJECT, OUTPUT, POP, PROCESSINGDIRECTIVE, PROCPARAM, PROCRESULT, QUERYPARAM, REGISTRY, REPORT, SCHEDULE, SCRIPT, SEARCH, SELECT, SERVLET, SERVLETPARAM, SET, SILENT, SLIDER, STOREDPROC, TABLE, TEXTINPUT, TREE, TREEITEM, UPDATE, WDDX, ZIP, CFCUSTOM_IDENTIFIER, IDENTIFIER, INTEGER_LITERAL, '#', FLOATING_POINT_LITERAL}

reported here: https://github.com/cfparser/cfparser/issues/131


Opaque types as inferred associated types violate type safety

Description / Reproduction
The following ought to generate a type-error where whoops is declared, but instead it complies and violates type safety, interpreting memory as incorrect type.
protocol ExampleProtocol {}
extension Int: ExampleProtocol {}
extension String: ExampleProtocol {}

struct ExampleFactory {
    func makeExample() -> some ExampleProtocol { 0 }
}

protocol MakeExampleProtocol {
    associatedtype Example
    func makeExample() -> Example
}
extension ExampleFactory: MakeExampleProtocol {}

let whoops: ExampleFactory.Example = "hi"
print(whoops) // -> 26984

In the example above, the String "hi" was reinterpreted as an Int since ExampleFactor.Example is Int.
If we were to unsafeBitCast a String to Int, it would trap since the sizes don't match. Instead, we can run the following:
print(unsafeBitCast("hi", to: (Int, Int).self)) // (26984, -2161727821137838080)

As you can see, the first component matches the value of whoops, confirming that Swift in the first example silently reinterpreted whoops's initializing value as a conflicting type.
Expected behavior

Cannot convert value of type 'String' to specified type 'some ExampleProtocol'

Environment
swift-driver version: 1.87.3 Apple Swift version 5.9.2 (swiftlang-<IP_ADDRESS>.56 clang-15<IP_ADDRESS>.5)
Target: arm64-apple-macosx14.0
Additional information
No response

I updated the expected behavior from

Cannot convert value of type 'String' to specified type 'Int'

to

Cannot convert value of type 'String' to specified type 'some ExampleProtocol'

since I don't think type inference should act as a side-channel to determine the concrete instance of an opaque type.

A simpler example:
// test.swift

func f() -> some Sequence { "" }
typealias A = @_opaqueReturnTypeOf("$s4test1fQryF", 0) __

let a: A = "" // OK

let b: A.Element = "" // Crash
let c: A
c = "" // error: cannot assign value of type 'String' to type 'A' (aka 'some Sequence') [cannot_convert_assign]

I suspect we are wrongly assuming somewhere that an explicit type annotation necessarily implies the opaque types it represents are declared on the variable.


Fix parsing async get/set in a class

Fixes #1861
Fixes #1875

Codecov Report

Merging #1939 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1939   +/-   ##
======================================
  Coverage     100%    100%
======================================
  Files           1       1
  Lines        4056    4053    -3
  Branches      717     715    -2
======================================
- Hits         4056    4053    -3

Impacted Files
Coverage Δ

dist/esprima.js
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aefb57a...d8b61fc. Read the comment docs.


Depandabot wont recognise package with vulnerability from WhiteSource Vulnerability Database

Package manager/ecosystem
JavaScript
Manifest contents prior to update
yarn.lock
package.json
Description
One of hour packages, hellojs, is flagged with a vulnerability in WhiteSource Vulnerability Database all version below 1.18.6 is affected. However dependabot won't recognise this vulnerability. Goto WhiteSource Vulnerability Database and search for CVE-2020-7741.
I have created a repo where I can reproduce the issue. I have added hellojs and jquery at a version that has a vulnerability. We can see that dependabot finds the jquery vulnerability and creates a PR but no for hellojs.
Is this a bug or have I missed something?
/C

Your package.json has hellojs as ^1.17.1 (minor updates) this it is will update to the latest which is 1.18.6. Since it's a minor update. If you check your yarn.lock you can see that it is indeed at 1.18.6. So, this is working as intended as the dependency is at the latest version.
For more information on the versioning check:  https://docs.npmjs.com/about-semantic-versioning/ and to see what updates can be accepted with the version in package.json you can refer to this: https://semver.npmjs.com/

Ohh sorry about the noice, thought I had pushed the correct commit.. I really need the upcoming christmas break :)
But, I have pushed the right commit now and I cant see the hellojs vulnerability over at
Thanks for the quick response!
/C

Hello and Happy new year! I realise I made some mistakes when I created this issue. I have now put my repo in a state where I think dependabot should find the vulnerability.
So I have updated the repo where hellojs is installed @1.18.4 but still no depenadabot alerts nor pull requests in regards to hellojs.
If you go to WhiteSource Vulnerability Database and search for CVE-2020-7741 you will see the vulnerability and all versions below 1.18.5 should be affected.
@WalshyDev

Hello and Happy new year! I realise I made some mistakes when I created this issue. I have now put my repo in a state where I think dependabot should find the vulnerability.
So I have updated the repo where hellojs is installed @1.18.4 but still no depenadabot alerts nor pull requests in regards to hellojs.
If you go to WhiteSource Vulnerability Database and search for CVE-2020-7741 you will see the vulnerability and all versions below 1.18.5 should be affected.
@WalshyDev

We are still not seeing any vulnerabilities alerts from dependabot in regards to hellojs. Could we re-open this issue to get someone to take a closer look at it?

We are still not seeing any vulnerabilities alerts from dependabot in regards to hellojs. Could we re-open this issue to get someone to take a closer look at it?


Add icons under the chat and community dropdown

This PR is associated with #863.

[chat]

[community]

Perfect, thanks @wadakatu! 🙂


Prepare for new release of Bitbucket

Workflow links: https://github.com/atlassian-labs/atlassian-slack-integration-server/actions/runs/11606083881, https://github.com/atlassian-labs/atlassian-slack-integration-server/actions/runs/11606086151, https://github.com/atlassian-labs/atlassian-slack-integration-server/actions/runs/11606090030

Integration tests pass, so current version in a branch release-1.x of Bitbucket DC for Slack is marked compatible with Bitbucket 8.19.10


TrafficCounter (raspberrypi)

read ir sensor movement
send reading to mqtt topic (1 topic per sensor / topic should be configurable for each sensor)

issues:
missing obstacle detection sensor
the ir proximity sensor doesn't seem to work correctly

exploration on how the ir sensor will work until the end of today with the help of Francesco


[SUGGESTION] Disable 1.19.4+ armor hotbar switching

Since 1.19.4, you can equip another piece of armor through your hotbar clicking on it. Hypixel blocks this feature, if you try to do this, the game will first try to equip the armor and then Hypixel will cancel it. Instead of having that, completely remove this feature so that's like pre-1.19.4 versions

https://youtu.be/eqzLJKI_mxg

So just to be clear, you are asking for right clicking to do nothing when you already wearing the item? That's almost certainly possible to do safely. It does feel a little odd to solidify a Hypixel bug though.
I also suspect this bug might actually be fixed at some point as they continue to work on modern features.
I'm not against this but it does feel a little out of scope. I'm happy to be convinced otherwise though if you have solid reasoning for it.

So for me this isn't a bug but it is rather intentionally done so players from modern versions don't have an advantage over 1.8.9 players as this feature can clearly give an advantage in fights (switching armor faster)
Like, on newer versions you can switch armor even if you already have one equiped, which isn't possible in 1.8.9 for example

That's a fair point, yeah. Though knowing Hypixel I feel it could have been a lucky accident. They could also have just backported it to old versions without much effort.
Can you think of any other "new" features like this where Hypixel just blocks them (or cases where they used but don't anymore)?

 So we can know whether that's intentional I guess

I'll do some investigation on how it impacts things and get back to you on that :P


Old Version is removed from Leetcode site. Doesnt Work on New Version

Leetcode old UI is going to be dprecated. If this is not fixed on new Leetcode version.
Then this extension is of no use to anyone.
Please fix it is not working with the latest and old is deprecated.
Below is picture of old UI not working

+1 - this addon is so great, would be great if someone could maintain it.


Feature request: server_time function

My experience with SageMathCloud has taught me that it is important to use server time not one's client time because people's clients are out of sync.

Thanks for the feature request @timothyclemansinsea . There has been some previous discussion on this in https://github.com/rethinkdb/horizon/issues/194 , and to a smaller degree in https://github.com/rethinkdb/horizon/issues/50 .
I'm going to close this as a duplicate.


Update geolexica-site.gemspec

Updated to use latest version of Jekyll-geolexica which now uses glossarist to read concept files.

Version 1.7.10 released for this change.


Fix missing from/to in header and special \ No new line

This PR updates the regex for headers to support ones without from/to, eg @@ -1 +1 @@.
It also adds support for the \\ No newline at end of file special case but tagged as context. Maybe it should have its own type?
Closes #1

I honestly don't have an answer for you on whether or not it should have its own type.
On one hand it's a warning that the diff is being modified slightly to actually display properly, and on the other hand I suppose you could call that contextual information about the diff itself.
I definitely think it should be kept and passed along as I wouldn't want to drop anything from the diff...though when I'd written this I'd envisioned context as being the surrounding lines before/after the actual line changes, so being actual lines that are in a file somewhere. This special case isn't that.
It's something that is part of the diff, definitely adds information to the diff that is important, but is not a line that actually appears in a file somewhere...which could be an argument for its own type.
If you were going to be ingesting the output of the file, what would you want to do with that last warning/line? Display it the same as the contextual lines of the file? Display it differently? Have an easy way to drop it?

I'm leaning towards wanting to be able to drop it actually, although it's not critical for me. I should take a look at what some other parsers do

I can definitely see wanting to drop it, since while most tooling expects and in can even require a newline at the end of the file it's not absolutely required in all situations in which a diff can exist. Even for code.
Could maybe have a :warning or :diff_warning or something like that. I'll have to think about it a little bit. If you come up with something shoot it over my way and I'll take a look. Won't be until tonight until I'm able to spend much time thinking about it myself as it's the beginning of my work day.

Alright, I can't think of anything better right at the moment so I'm just gonna go ahead and pull it in as-is.


Behaviour of cdist when edit distance exceeds score_cutoff

Quoting https://maxbachmann.github.io/RapidFuzz/Usage/process.html#cdist

score_cutoff (Any, optional) – Optional argument for a score threshold. When an edit distance is used this represents the maximum edit distance and matches with a distance <= score_cutoff are inserted as -1. When a normalized edit distance is used this represents the minimal similarity and matches with a similarity >= score_cutoff are inserted as 0. Default is None, which deactivates this behaviour.

This gives the impression that if score_cutoff is used with an edit distance (meaning this is an upper bound), when the score exceeds it the flag value -1 is returned.
However, other parts of the documentation suggest score_cutoff + 1 is returned. For example, Hamming or Levenshtein distance. See the max= argument to rapidfuzz.string_metric.levenshtein as documented at https://maxbachmann.github.io/RapidFuzz/Usage/string_metric.html#rapidfuzz.string_metric.levenshtein

max (int or None, optional) – Maximum distance between s1 and s2, that is considered as a result. If the distance is bigger than max, max + 1 is returned instead. Default is None, which deactivates this behaviour.

e.g. using v2.1.2
>>> from rapidfuzz.process import cdist
>>> from rapidfuzz.string_metric import levenshtein
>>> import numpy as np
>>> seqs = ["ACGTACGT", "ACGTTACGT", "ACGTAACGT", "ACGTACT", "X"]
>>> cdist(seqs, seqs, scorer=levenshtein, dtype=np.int8, score_cutoff=3)
array([[0, 1, 1, 1, 4],
       [1, 0, 1, 2, 4],
       [1, 1, 0, 2, 4],
       [1, 2, 2, 0, 4],
       [4, 4, 4, 4, 0]], dtype=int8)

If many/all of the provided edit distances use score_cutoff + 1 then perhaps the cdist documentation is misleading?

This is a behaviour change from v1.9.1 to v2.0.0, quoting the change log:

when the result of string_metric.levenshtein or string_metric.hamming is below max they do now return max + 1 instead of -1

$ python
Python 3.9.13 | packaged by conda-forge | (main, May 27 2022, 17:00:52)
[Clang 13.0.1 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from rapidfuzz.process import cdist
>>> from rapidfuzz.string_metric import levenshtein
>>> import numpy as np
>>> seqs = ["ACGTACGT", "ACGTTACGT", "ACGTAACGT", "ACGTACT", "X"]
>>> cdist(seqs, seqs, scorer=levenshtein, dtype=np.int8, score_cutoff=3)
array([[ 0,  1,  1,  1, -1],
       [ 1,  0,  1,  2, -1],
       [ 1,  1,  0,  2, -1],
       [ 1,  2,  2,  0, -1],
       [-1, -1, -1, -1,  0]], dtype=int8)
>>> import rapidfuzz
>>> rapidfuzz.__version__
'1.9.1'

$ python
Python 3.9.13 | packaged by conda-forge | (main, May 27 2022, 17:00:52)
[Clang 13.0.1 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from rapidfuzz.process import cdist
>>> from rapidfuzz.string_metric import levenshtein
>>> import numpy as np
>>> seqs = ["ACGTACGT", "ACGTTACGT", "ACGTAACGT", "ACGTACT", "X"]
>>> cdist(seqs, seqs, scorer=levenshtein, dtype=np.int8, score_cutoff=3)
array([[0, 1, 1, 1, 4],
       [1, 0, 1, 2, 4],
       [1, 1, 0, 2, 4],
       [1, 2, 2, 0, 4],
       [4, 4, 4, 4, 0]], dtype=int8)
>>> import rapidfuzz
>>> rapidfuzz.__version__
'2.0.0'

It looks like the documentation for cdist does just need updating to match?

Yes this was a change in behavior of the string metric. cdist really does not care about it, since it just passes the score_cutoff to the string metric. I clarified this in the documentation by removing these confusing bits: https://github.com/maxbachmann/RapidFuzz/commit/fde0a662fafbf50a6aab53676002f8fd6bbd33a8

As a note you should change:
from rapidfuzz.string_metric import levenshtein
...
scorer=levenshtein

to something like
from rapidfuzz.distance import Levenshtein
...
scorer=Levenshtein.distance

The whole string_metric module is deprecated since v2.0.0 and moving forward all metrics will be added in the distance namespace

Thank you - I've updated my imports accordingly.


Feature Request: Project differentiation on multi-project workspaces

Hiya there!
While I know this feature is still quite new, I'd thought I'd go ahead and contribute with my 2c.
Basically what I feel is that it's too difficult to visually identify the begining and end for 2 different projects on a multi-project workspace (particularly large projects!), as there are no visual cues apart from indentation on the workspace. And when we start drilling down into each project's folders, it becomes even more difficult.
My suggestion is to maybe introduce spacing or colour cues (or both) such that it's easier to identify where each project begins and ends!

This issue has already been reported. Please use the search function next time before reporting an issue and/or this time if you are curious about the progress of the issue.


Rename all C++ classes/structs to match our new convention of having PM prefix instead of ProjectM

Add the prefix to types that are missing it. Use Core Redirects so we don't have to update Blueprint references. Then as a separate PR we can update Blueprint references and remove the Core Redirects. Talk to Leroy for details.
Ctrl+Shift+H to find/replace in files.
Example PR.
See here for more information about Core Redirects.
To remove core redirects later see here.

I'm reopening this because there are still other classes you need to rename, but you should wait because I wanted to prevent conflicts with some big open PRs.

@Kalchev89 this should be fine to continue on now in the other ProjectM subfolders that you didn't do the renaming yet.


Issue 2, NS typo

Fixing reported typo in NetStorage auth.

Closing because this change invalidates signature. Will update and resign.


RN error : Unexpected token '*' (http://localhost:8081/index.delta?platform=android&dev=true&minify=false:94148)

Environment
Environment:
OS: Windows 10
Node: 10.7.0
Yarn: 1.9.4
npm: 6.1.0
Watchman: 4.9.4
Xcode: N/A
Android Studio: 3.1.3
Packages: (wanted => installed)
react-native-cli:  2.0.1
react-native:  0.55.4
Description
I meet this  error when I run command: react-native run-android . Although it show me Build successful.

And in android studio ,the logcat shows words below:
8-08 16:41:20.296 19265-19412/com.securemail E/ReactNativeJNI: Got JS Exception: Unexpected token '*' (http://localhost:8081/index.delta?platform=android&dev=true&minify=false:94148)
08-08 16:41:20.298 19265-19412/com.securemail E/unknown:ReactNative: Exception in native call from JS
    com.facebook.react.devsupport.JSException: Unexpected token '*' (http://localhost:8081/index.delta?platform=android&dev=true&minify=false:94148)
        at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method)
        at android.os.Handler.handleCallback(Handler.java:815)
        at android.os.Handler.dispatchMessage(Handler.java:104)
        at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:29)
        at android.os.Looper.loop(Looper.java:224)
        at com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run(MessageQueueThreadImpl.java:192)
        at java.lang.Thread.run(Thread.java:818)
     Caused by: com.facebook.jni.CppException: Unexpected token '*' (http://localhost:8081/index.delta?platform=android&dev=true&minify=false:94148)
        at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method)
        at android.os.Handler.handleCallback(Handler.java:815)
        at android.os.Handler.dispatchMessage(Handler.java:104)
        at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:29)
        at android.os.Looper.loop(Looper.java:224)
        at com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run(MessageQueueThreadImpl.java:192)
        at java.lang.Thread.run(Thread.java:818)
08-08 16:41:20.300 19265-19412/com.securemail E/unknown:ReactNative: Exception in native call
    java.lang.RuntimeException: Error calling AppRegistry.runApplication
        at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method)
        at android.os.Handler.handleCallback(Handler.java:815)
        at android.os.Handler.dispatchMessage(Handler.java:104)
        at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:29)
        at android.os.Looper.loop(Looper.java:224)
        at com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run(MessageQueueThreadImpl.java:192)
        at java.lang.Thread.run(Thread.java:818)
     Caused by: com.facebook.jni.CppException: Could not get BatchedBridge, make sure your bundle is packaged correctly
        at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method)
        at android.os.Handler.handleCallback(Handler.java:815)
        at android.os.Handler.dispatchMessage(Handler.java:104)
        at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:29)
        at android.os.Looper.loop(Looper.java:224)
        at com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run(MessageQueueThreadImpl.java:192)
        at java.lang.Thread.run(Thread.java:818)

Someone said delete the files in assets and run under command can help, but I tried it and no use, feeling confused.
react-native bundle --platform android --dev false --entry-file index.js --bundle-output android/app/src/main/assets/index.android.bundle --assets-dest android/app/src/main/res/

I tested other mobilephone but no use. Please help me ,thanks a lot.

Already searched for an * somewhere in your code?

Had the similar problem. You need to download http://localhost:8081/index.delta?platform=android&dev=true&minify=false directly (from browser etc.), then open in editor and search for row 94148 from which your error came from.
After that you'll see exactly the place of error and be able to find it in your project's js files.

same thing for me, and searching for that column did not work. there is no *

I had very similar issue and rebooting system worked for me.

Edit android/app/build.gradle
use this
compile ("com.facebook.react:react-native:0.44.0") { force = true }
and write version of app you use instead of 0.44.0 and delete something like this compile "com.facebook.react:react-native:+" or this compile "com.facebook.react:react-native:0.44.0"

please let me know the solution to this. :(

from my side, I was running tomcat on port 8081 [just in case]

I have same issue. My project crash without any reason.
Any working solution?

Guys I found the problem.
I remove my node_modules and use npm install and anything works well but when I use yarn install it's break with this error:
Unexpected token '*' (http://localhost:8081/index.delta?platform=android&dev=true&minify=false:...)

It seems it's a yarn issue. :thinking:

Just fixed the problem after hours of headache. for me, the problem was one of my dependencies was using **  operator which was not recognized by my babel compiler (apologies if I misused the terms, I am not very experienced with these staff). so I went there and changed ** operator with the regular Math.pow().
for me the file that was causing the issue was
\node_modules\react-native-elements\src\tooltip\getTooltipCoordinate.js
third line, in react-native-elements library.
check your last installed libraries for same operator and replace. probably not the best way to fix it but at least you'll know what's causing the issue.

I just encountered a similar problem after some package updates.
Turns out if you start Remote Debugging (open the dev menu and press Debug JS Remotely), you get a more detailed explanation of the error - in my case, one of the new versions of my dependencies required a newer version of RN (and I'm yet to migrate that to a later version).


Create migrations to modify existing data for new app context

The application URL is stored in the database in various places (map sources, map layers (legend?), file names, etc. These are currently /int/bcrhp and will become /bcrhp when moving to OIDC authentication. Need to develop a migration that makes the changes in the database.
Issue #910 must be completed prior to this
Areas to be addressed:

[x] map_sources and associated JSON files
[x] map_layers legend column
[x] cards_x_nodes_x_widgets - Concepts & associated resource model JSON files
[x] concepts - legacyoid - should change the host to the PROD host too
[x] tiledata - file URLs
[x] nodes config column - relationship search string
[x] values value column
[x] published_graphs serialized_graph column - nodes search string
[x] v_historic_site site_url column
[ ] edit_log (unclear if this is necessary)

Updated the description, there were additional tables that needed to also be changes.
@bferguso @emjohnst There is also the question of if the instances in the edit_log tables should also be updated. But I'm not familiar enough with how the edit log view is intended to work both from a technical side and user perspective.

@jrods Yes we do rely on the edit log for the records, there is a history of data clean up we've preserved in the edit history for reference and will continue to used the edit history log for referenced of changes to the record over time. Thanks!

@bferguso was the edit log migration developed?

@emjohnst - I believe this can be marked as done.


Update guardrails to v2

update to most recent version of docs
link to https://www.tbs-sct.canada.ca/pol/doc-eng.aspx?id=32787

I think this is confusing and why I flagged the dual repo approach wasn't a great idea at the beginning.

One or the other should be archived
You should publish this information to Canada.ca, not point to a GitHub repo (or GCX site like on the linked page) for any official policy related stuff. It's a great place for collaborating with some audiences, but doesn't meet OL amongst other issues

I very much agree with @nschonni. Why bother hiding all that?
You could always link that repo in this one, and say the current version of the guardrails were "created" or refined there.

Thanks to you both for your feedback, although contradictory ;-) We wanted to close one repo to minimize confusion. There is nothing to hide which is why we established the repo in the first place. Happy to chat about future approaches as the goal was a collaborative and open approach.

@ptd-tbs, my apologies.
My choice of words was inappropriate, and I didn't intend to suggest you were actively hiding things. I think I meant that the V2 repo is hidden, so even if we wanted to reference it, it's not possible.
I'd very much like to chat about how to capture the feedback generated via the V2 consultation, and allow the discussion to be preserved.
A quick Google search says there's a pretty simple way to transfer issues between repos. I think most of the feedback came via issues (though I think there were some via PRs), so maybe that's a good thing to look at.
My $0.02, but in the future, I'd suggesting creating a separate branch in this repo for changes/consultation. It keeps things in one place, and maintains the fully history.

Thanks Greg. We will definitely look at that option to transfer the issues between repos. And yes, I take your recommendation about the branch thingy in this repo in the future too :-)
cc/ @lcampbell2 FYA


Visualization for QuantumModel instances

Allow for calling something like:
from qadence.draw import display
from qadence import QuantumModel

qm = QuantumModel(...)
display(qm)

display(model._circuit.original) does the same as display(qc_ansatz). It displays a huge image of the circuit and also does not show the measurements (screenshot attached).


invalid default value codegen

I compiled a zod validator from a json schema using roughly this snippet:
import jsonSchemaToZod from "json-schema-to-zod";

const schema = await import("schema.json");
const asZod = jsonSchemaToZod(schema);
await writeFile("output.ts");

here's a gist with the 2 other files (for brevity in this issue description) https://gist.github.com/cdmistman/c73e1c66ee02e21235bac109c1a354ce
note that the generated default value is invalid; typescript returns the following error:
output.ts:7:5 - error TS2769: No overload matches this call.
  Overload 2 of 2, '(def: () => objectInputType<{ insert: ZodObject<{ string: ZodString; }, "strip", ZodTypeAny, { string: string; }, { string: string; }>; }, ZodNever, "strip">): ZodDefault<...>', gave the following error.
    Argument of type '{ $schema: string; title: string; oneOf: { type: string; required: string[]; properties: { insert: { type: string; required: string[]; properties: { string: { type: string; }; }; }; }; additionalProperties: boolean; }[]; }' is not assignable to parameter of type '() => objectInputType<{ insert: ZodObject<{ string: ZodString; }, "strip", ZodTypeAny, { string: string; }, { string: string; }>; }, ZodNever, "strip">'.
      Object literal may only specify known properties, and '$schema' does not exist in type '() => objectInputType<{ insert: ZodObject<{ string: ZodString; }, "strip", ZodTypeAny, { string: string; }, { string: string; }>; }, ZodNever, "strip">'.

7     $schema: "http://json-schema.org/draft-07/schema#",
      ~~~~~~~

i'd at least expect an error if a valid default value can be generated! it would also be nice to report in the error that withoutDefaults: true should be passed as an option to jsonSchemaToZod

Cant recreate this with the gists you posted


Chain Sync from RPC provider throws an error

I tried to sync the chain with the current commit 21c4e14 and the script throws an error for block 56302.
INFO:ethereum_spec_tools.sync:block 56300 applied (took 0.016568107001148746s)
INFO:ethereum_spec_tools.sync:block 56301 applied (took 0.013835476998792728s)
Traceback (most recent call last):
  File "/home/guruprasad/Documents/execution-specs/venv/bin/ethereum-spec-sync", line 33, in <module>
    sys.exit(load_entry_point('ethereum', 'console_scripts', 'ethereum-spec-sync')())
  File "/home/guruprasad/Documents/execution-specs/src/ethereum_spec_tools/sync.py", line 734, in main
    sync.process_blocks()
  File "/home/guruprasad/Documents/execution-specs/src/ethereum_spec_tools/sync.py", line 693, in process_blocks
    self.module("spec").state_transition(self.chain, block)
  File "/home/guruprasad/Documents/execution-specs/src/ethereum/frontier/spec.py", line 193, in state_transition
    ensure(receipt_root == block.header.receipt_root)
  File "/home/guruprasad/Documents/execution-specs/src/ethereum/utils/ensure.py", line 42, in ensure
    raise exception_class()
ethereum.utils.ensure.EnsureError

Way to reproduce.

Checkout the above mentioned commit
ethereum-spec-sync --rpc-url=<rpc-provider> --optimized --persist=<sync-data-location>

I was using Infura in this case. Not sure if that has an impact.

This is a bug in handling of logs. There is a fix in #473.

This issue is solved after #473 and the block is syncing now without any error


Dimensionality Error

I created a non persistent collection and added data as follows:
collection = client.create_collection(name=collection_name)
collection.add(
    embeddings=[
        [0, 0, 0],
        [0, 0, 0],
    ],
    metadatas=[
        {"status": "read"},
        {"status": "unread"},
    ],
    documents=["doc1", "doc2"],
    ids=["id1", "id2"]
)

then on running the following query:
embeds = collection.query(
        query_texts=["doc1"],
        n_results=1,
)

I am getting this error:
InvalidDimensionException                 Traceback (most recent call last)
Cell In[91], line 1
----> 1 embeds = collection.query(
      2         query_texts=["doc1"],
      3         n_results=1,
      4 )

File [~/Library/Python/3.9/lib/python/site-packages/chromadb/api/models/Collection.py:202](https://file+.vscode-resource.vscode-cdn.net/Users/shivankar/Desktop/chroma_persistence/~/Library/Python/3.9/lib/python/site-packages/chromadb/api/models/Collection.py:202), in Collection.query(self, query_embeddings, query_texts, n_results, where, where_document, include)
    199 if where_document is None:
    200     where_document = {}
--> 202 return self._client._query(
    203     collection_name=self.name,
    204     query_embeddings=query_embeddings,
    205     n_results=n_results,
    206     where=where,
    207     where_document=where_document,
    208     include=include,
    209 )

File [~/Library/Python/3.9/lib/python/site-packages/chromadb/api/local.py:247](https://file+.vscode-resource.vscode-cdn.net/Users/shivankar/Desktop/chroma_persistence/~/Library/Python/3.9/lib/python/site-packages/chromadb/api/local.py:247), in LocalAPI._query(self, collection_name, query_embeddings, n_results, where, where_document, include)
    238 def _query(
    239     self,
    240     collection_name,
   (...)
...
--> 114     raise InvalidDimensionException(
    115         f"Dimensionality of ({dim}) does not match index dimensionality ({idx_dim})"
    116     )

InvalidDimensionException: Dimensionality of (384) does not match index dimensionality (3)

Where am I going wrong?

@shivankar-p you are loading in "Fake" embeddings with dimensionality 3 [0,0,0]. and then the default embedding function, sentence-transformers has 384 dimensions.


Suggestion: Developer setup documentation

This documentation may exist - I just cant find it!
Can we get some setup docuemntation for this project (and if some exists can someone point me in the that direction or make it alot more visible?).
As a developer
I want to have instructions for application setup and configuration
So that I can get developing on this project quickly and without any errors
Acceptance Criteria:

Installations (what do i need to install?)
Configuration (what do i need to configure?)
Running (what do i need to run?)

Thanks @marblekirby
We do have some documentation but as always it could probably use some improvement.
There are 3 main parts to TwoWeeksReady. Each is in it's own folder in this repo and each of those folders has it's own README file which should have the info you need to get started.

api: The backend API built using Azure Functions, .NET Core and CosmosDB
2wr-app: The Progress Web App built using VueJS and Vuetify
admin: An admin app for configuring data in the app built using Blazor.

You won't find much documentation on getting the Blazor app running. That part is still pretty new. The api and 2wr-app should have the information you need though,
Take a look and feel free to submit a PR with any improvements you can think of. It's always good to get a fresh new perspective on the docs.  One thing we could do is lay out the 3 different parts of the repo in the main README and link to the different folders.
I hope that helps!

Thanks. Let's try add that to the main Readme file so people can easily find it

Added links to project README docs on the main landing page in PR #81


[CARBONDATA-3108][CARBONDATA-3044] Fix the error of jvm will crash when CarbonRow use wrong index number in CSDK

This PR:

fix the error of jvm will crash when CarbonRow use wrong index number in CSDK
including getString, getVarchar, getArray, getDecimal
delete/release the data after running
init the variable to NULL

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[x] Any interfaces changed?
No
[x] Any backward compatibility impacted?
No
[x] Document update required?
No
[x] Testing done
add
[x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
JIRA2951

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1453/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1663/

Build Success with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9711/

@KanakaKumar @brijoobopanna @BJangir @jackylk Please review it.

@KanakaKumar @brijoobopanna @BJangir @jackylk @ajantha-bhat @kunal642  Please review it.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1475/

LGTM

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9733/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1685/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1480/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1690/

Build Success with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9738/

@xubo245 Please resolve the conflicts

@kunal642 Rebased.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1487/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1697/

Build Success with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9745/

@kunal642 @KanakaKumar Rebased, CI pass, please check it.

LGTM


keys may need quotes

I have some badly designed legacy interfaces to deal with, which use a ton of kebab keys:
/**
 * @typedef {Object} JsonDataInterface
 * @property {number} foo-bar-1
 * @property {number} foo-baz-1
 */

which gives me:
declare interface JsonDataInterface {
  foo-bar-1: number;
  foo-baz-1: number;
}

where it should return:
declare

Ill see if I can find a fix for this, so far no luck.

This may be related to #61.

nvm. I can fix this by adding "identifier" to the doclet. sorry for the noise


ADE Updates for VS Code

Add azd env list command to the context menu
Add Dev Center mode (azd config set devCenterMode true) to command palette

Seems like we could dupe this to #2762?


update volume path

The volume path in docker-compose.yml was never updated since we made the change to the directory in the UI Dockerfile.
I have no idea how the change to census/src/test/scala/grasshopper/census/search/AddressInterpolatorSpec.scala happened. I have never touched that file.
@jmarin @hkeeler

@awolfe76 The Scala file has changed due to some changes in formatting of the code (which would be triggered by a build). Merging since this does no harm, if we see this changes again we will need to make sure all scalariform settings are the same for everyone


Feature/cr

Still a work in progress but will speed up documentation and remove errors such as missing prop declarations.
As JC suggest to move the component reference declarations to each individual component. Sadly right now with the use of vue press, I have not found a clear way to extend the page data with the component declarations.

thanks!

Will be producing test cases for this plugin. More to come!


feat(core-HomeFeatures): support home feature grid 3xN & costom grid …

…length (#215)
Summary

copilot:summary
Details

copilot:walkthrough
Related Issue
https://github.com/web-infra-dev/rspress/issues/215
Checklist

[x] I have added changeset via pnpm run change.
[x] I have updated the documentation.
[ ] I have added tests to cover my changes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please sign the CLA 👆🏻

Please sign the CLA 👆🏻

it's ok. :)


Dockerize for easier development

I wanted to propose a feature to sql-rom via PR but could not bundle the gem as I was missing dependencies.
As I prefer not to keep dependencies I am not actively using on my host machine and it's my presumption a lot of other developers these days are doing the same, I would like to offer this small PR. It should add an easy way to start developing within docker container with all dependencies already present.
How to use? Well, you type make dev and, assuming you do have docker installed, that's it. You are in the container with dependencies available and can start working.

This should be helpful indeed. Could you also add a couple sentences to the README about this?

@solnic Updated

Is this still considered useful?

Maybe not make it by default to use docker, so depending on if you are using docker or not you should have a default when setting the spec_helper https://github.com/rom-rb/rom-sql/pull/267/files#diff-93830fa29d616f7c87903d08b5b1b29aR42

I do not see why not to merge it. I really think is a valuable addition

@flash-gordon I'm OK with merging this in, you?

yeah, whatever works, I didn't test it :)

One thing I'd change here, is Makefile, it's uncommon in the ruby land to use make, so could we change it to use rake tasks instead?

I would limit Rake for Ruby things, but this is docker container management. Prefer to keep it separate and make is present almost everywhere.

Let's use Rake tasks for this. It's a ruby project already, Rake is already in use, and Rake is perfectly suited to running external commands.

@Krule - we use a lot of Docker and Docker Compose on our projects and we opt to let the developers alias those commands as they see fit. We document them in the README.
This is especially helpful on platforms where they may not already have ruby or make or whatever. Then the set up is: "Install Docker and Docker Compose and run these commands".

@Krule I've just tested the docker setup with a clean repo and it seems that Gemfile.lock to has to be present.
(Unfold for more details)

Step 1/7 : FROM ruby:2.4.2
 ---> 2a867526d472
Step 2/7 : RUN mkdir /gem
 ---> Using cache
 ---> 113e6877ebb3
Step 3/7 : WORKDIR /gem
 ---> Using cache
 ---> a3ed606352ca
Step 4/7 : COPY Gemfile Gemfile.lock rom-sql.gemspec ./
ERROR: Service 'gem' failed to build: COPY failed: stat /var/lib/docker/tmp/docker-builder021717139/Gemfile.lock: no such file or directory
Makefile:2: recipe for target 'build' failed
make: *** [build] Error 1

Not copying Gemfile.lock during docker build would help:
diff --git a/Dockerfile b/Dockerfile
index 22dec3e..6bdd15f 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -3,7 +3,7 @@ FROM ruby:2.4.2
 RUN mkdir /gem
 WORKDIR /gem

-COPY Gemfile Gemfile.lock rom-sql.gemspec ./
+COPY Gemfile rom-sql.gemspec ./
 COPY lib/rom/sql/version.rb ./lib/rom/sql/

 RUN bundle install --jobs 8 --retry 5

WDYT?

@splattael I think dependencies should be locked in order to have reproducible environment. But, as that is not the case, yes, Gemfile.lock is not supposed to be used as I did.

Yes this is useful. It will help new contributors be productive more quickly. Also, I think we could port this to rom-factory as well.

Doesn't work for me:
∞ [ruby-2.5.1][node-v8.12.0] rom-sql git(dockerize_for_easier_development) docker-compose build gem
Building gem
Step 1/7 : FROM ruby:2.4.2
 ---> 2a867526d472
Step 2/7 : RUN mkdir /gem
 ---> Using cache
 ---> 6707b99fdef9
Step 3/7 : WORKDIR /gem
 ---> Using cache
 ---> f5ad6d6e9666
Step 4/7 : COPY Gemfile rom-sql.gemspec ./
 ---> Using cache
 ---> 26e6de61585d
Step 5/7 : COPY lib/rom/sql/version.rb ./lib/rom/sql/
 ---> Using cache
 ---> aa9431de4c3f
Step 6/7 : RUN bundle install --jobs 8 --retry 5
 ---> Using cache
 ---> 9a6796c5e6b7
Step 7/7 : ADD . /gem/
 ---> b4e0ed529e56
Successfully built b4e0ed529e56
Successfully tagged rom-sql_gem:latest
∞ [ruby-2.5.1][node-v8.12.0] rom-sql git(dockerize_for_easier_development) docker-compose run --rm gem 'rspec'
Starting rom-sql_mariadb_1  ... done
Starting rom-sql_postgres_1 ... done
Could not find concurrent-ruby-1.0.5 in any of the sources
Run `bundle install` to install missing gems.


Fix hasPreviousPage

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   78.46%   78.46%
=======================================
  Files           5        5
  Lines          65       65
  Branches       11       11
=======================================
  Hits           51       51
  Misses         11       11
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cdba52...b4c25cd. Read the comment docs.


Some bug on end of Web Animations API (WAAPI)

Hi @Funlang I'm very impressed how lightweight is this framework, until now I was using the Petite Vue for the same proposite, because I needed something very small, and when I saw your framework my eyes shiny again. Soo thank u for your work on this.
I started to migrate my custom elements on Petite Vue to Z-data and I found kind of a bug on rendering the state of the element at the end of an animation. to examplify this I created the same thing in Petite Vue and Z-data.
To reproduce the bug you need to shrink the accordion, and at end of animation will show a jump.
Animated details summary on Petite Vue
Animated details summaryon Z-data
At the end of animation the state need to be open === false, but somehow that was true  and I can't figure out how.
Can you help me with this?

Thanks for your example, I will do something to locate the issue.

I don't know how and why.
Changed this line and it works fine.
if (start > end) this.open = details.open = false;

https://codepen.io/funlang/pen/zYjmYxE?editors=1010

@Funlang That's work, thak u!!!

if (start > end) this.open = details.open = false;

but I did it this way, because of the State Based paradigm. So I assumed the open state would be more important than touching the property directly.
but thank u again. I'm closing this issue now.


Expose admin style to plugins

Take wagtailblocks_cards for instance. I want to use the "light blue" color in my CSS, but I have to hardcode it. If that color ever changes, it will break my plugin.
I'm wondering if there's a way to expose certain things, like maybe SCSS variables, so that third-party packages can use it.

If the wagtail npm package also included the Wagtail .scss files, specifically the mixins and global variables, then you could import the styles from there. @JoshBarr would probably be able to answer how this might work.

As of #8824, we now have CSS variables for all colors, and all fonts. I believe this solves what this issue is about much more neatly than Sass, as the CSS variables are bundled directly in Wagtail’s stylesheets.
I’ll close this now, if there’s a use case for other variables I’m sure we’d be interested in having more available.


[BUG] Can't create backup of turned off VM

Describe the bug

Creating a backup from a VM that is turned off never finishes
To Reproduce
Steps to reproduce the behavior:

Create a VM from raw image template with template and password from cloudconfig
Log in to VM
Create a file
Add some data to the file
Turn off the VM
Take backup

Expected behavior

Backup should complete with no error
Support bundle

harvester-supportbundle_50043b09-3cc7-4421-8769-294c983cfbbc_2021-06-07T18-27-59Z.zip
Environment:
Harvester ISO version: master-3b6b8a6d-head
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): baremetal DL160G9
Additional context
Add any other context about the problem here.

This eventually finished hours later. Here's the support bundle with it and some screenshots of the status

harvester-supportbundle_50043b09-3cc7-4421-8769-294c983cfbbc_2021-06-07T21-30-35Z.zip

Here is the minimal amount of reproducible logs from the support bundle and locally tests so far after pressing "Take backup". I think the last line GRPC error in the log Action [snapshotList] not available on xxx results in this issue. Will investigate it more. Any input is welcome.

Expand to read minimal log preventing backup
longhorn-manager-lsw5z longhorn-manager time="2021-06-22T02:15:02Z" level=debug msg="Can't find share manager, may have been deleted" controller=longhorn-share-manager node=h0 shareManager=pvc-18c99596-9eed-4fb6-8b23-047b160b658e
longhorn-manager-lsw5z longhorn-manager time="2021-06-22T02:15:02Z" level=debug msg="Prepare to create instance pvc-18c99596-9eed-4fb6-8b23-047b160b658e-r-3d352712"
longhorn-manager-lsw5z longhorn-manager time="2021-06-22T02:15:02Z" level=info msg="Event(v1.ObjectReference{Kind:\"Replica\", Namespace:\"longhorn-system\", Name:\"pvc-18c99596-9eed-4fb6-8b23-047b160b658e-r-3d352712\", UID:\"9f65a47a-c204-4fd4-a5e9-5d6051cd227b\", APIVersion:\"longhorn.io/v1beta1\", ResourceVersion:\"83219\", FieldPath:\"\"}): type: 'Normal' reason: 'Start' Starts pvc-18c99596-9eed-4fb6-8b23-047b160b658e-r-3d352712"
longhorn-manager-lsw5z longhorn-manager time="2021-06-22T02:15:02Z" level=info msg="Share manager got new owner h0" controller=longhorn-share-manager node=h0 owner= shareManager=pvc-18c99596-9eed-4fb6-8b23-047b160b658e state= volume=pvc-18c99596-9eed-4fb6-8b23-047b160b658e
longhorn-manager-lsw5z longhorn-manager time="2021-06-22T02:15:02Z" level=info msg="share manager is no longer required" controller=longhorn-share-manager node=h0 owner=h0 shareManager=pvc-18c99596-9eed-4fb6-8b23-047b160b658e state= volume=pvc-18c99596-9eed-4fb6-8b23-047b160b658e
longhorn-manager-lsw5z longhorn-manager time="2021-06-22T02:15:02Z" level=info msg="stopping share manager" controller=longhorn-share-manager node=h0 owner=h0 shareManager=pvc-18c99596-9eed-4fb6-8b23-047b160b658e state= volume=pvc-18c99596-9eed-4fb6-8b23-047b160b658e
longhorn-manager-lsw5z longhorn-manager time="2021-06-22T02:15:02Z" level=info msg="requesting Volume detach from node h0" controller=longhorn-share-manager node=h0 owner=h0 shareManager=pvc-18c99596-9eed-4fb6-8b23-047b160b658e state= volume=pvc-18c99596-9eed-4fb6-8b23-047b160b658e
longhorn-manager-lsw5z longhorn-manager time="2021-06-22T02:15:02Z" level=debug msg="Requeue volume due to error Operation cannot be fulfilled on volumes.longhorn.io \"pvc-18c99596-9eed-4fb6-8b23-047b160b658e\": the object has been modified; please apply your changes to the latest version and try again or <nil>" accessMode=rwx controller=longhorn-volume frontend=blockdev migratable=false node=h0 owner=h0 shareEndpoint= shareState= state=detached volume=pvc-18c99596-9eed-4fb6-8b23-047b160b658e
longhorn-manager-lsw5z longhorn-manager time="2021-06-22T02:15:02Z" level=debug msg="Prepare to delete instance pvc-18c99596-9eed-4fb6-8b23-047b160b658e-r-3d352712"
longhorn-manager-lsw5z longhorn-manager time="2021-06-22T02:15:02Z" level=debug msg="Instance pvc-18c99596-9eed-4fb6-8b23-047b160b658e-r-3d352712 starts running, IP <IP_ADDRESS>"
longhorn-manager-lsw5z longhorn-manager time="2021-06-22T02:15:02Z" level=debug msg="Instance pvc-18c99596-9eed-4fb6-8b23-047b160b658e-r-3d352712 starts running, Port 10000"
longhorn-manager-lsw5z longhorn-manager time="2021-06-22T02:15:02Z" level=debug msg="Instance handler updated instance pvc-18c99596-9eed-4fb6-8b23-047b160b658e-r-3d352712 state, old state stopped, new state running"
longhorn-manager-lsw5z longhorn-manager time="2021-06-22T02:15:02Z" level=info msg="Event(v1.ObjectReference{Kind:\"Replica\", Namespace:\"longhorn-system\", Name:\"pvc-18c99596-9eed-4fb6-8b23-047b160b658e-r-3d352712\", UID:\"9f65a47a-c204-4fd4-a5e9-5d6051cd227b\", APIVersion:\"longhorn.io/v1beta1\", ResourceVersion:\"83225\", FieldPath:\"\"}): type: 'Normal' reason: 'Stop' Stops pvc-18c99596-9eed-4fb6-8b23-047b160b658e-r-3d352712"
longhorn-manager-lsw5z longhorn-manager time="2021-06-22T02:15:02Z" level=debug msg="Prepare to delete instance pvc-18c99596-9eed-4fb6-8b23-047b160b658e-r-3d352712"
longhorn-manager-lsw5z longhorn-manager time="2021-06-22T02:15:02Z" level=info msg="Event(v1.ObjectReference{Kind:\"Replica\", Namespace:\"longhorn-system\", Name:\"pvc-18c99596-9eed-4fb6-8b23-047b160b658e-r-3d352712\", UID:\"9f65a47a-c204-4fd4-a5e9-5d6051cd227b\", APIVersion:\"longhorn.io/v1beta1\", ResourceVersion:\"83229\", FieldPath:\"\"}): type: 'Normal' reason: 'Stop' Stops pvc-18c99596-9eed-4fb6-8b23-047b160b658e-r-3d352712"
longhorn-manager-lsw5z longhorn-manager time="2021-06-22T02:15:03Z" level=debug msg="Instance handler updated instance pvc-18c99596-9eed-4fb6-8b23-047b160b658e-r-3d352712 state, old state running, new state stopped"
longhorn-csi-plugin-49px9 longhorn-csi-plugin time="2021-06-22T02:15:15Z" level=info msg="GRPC call: /csi.v1.Identity/GetPluginInfo request: {}"
longhorn-csi-plugin-49px9 longhorn-csi-plugin time="2021-06-22T02:15:15Z" level=info msg="GRPC response: {\"name\":\"driver.longhorn.io\",\"vendor_version\":\"v1.1.1\"}"
longhorn-csi-plugin-49px9 longhorn-csi-plugin time="2021-06-22T02:15:15Z" level=info msg="GRPC call: /csi.v1.Controller/CreateSnapshot request: {\"name\":\"snapshot-3904ae97-f60f-4161-b18b-08c44a13706c\",\"source_volume_id\":\"pvc-18c99596-9eed-4fb6-8b23-047b160b658e\"}"
longhorn-csi-plugin-49px9 longhorn-csi-plugin time="2021-06-22T02:15:15Z" level=debug msg="ControllerServer CreateSnapshot req: source_volume_id:\"pvc-18c99596-9eed-4fb6-8b23-047b160b658e\" name:\"snapshot-3904ae97-f60f-4161-b18b-08c44a13706c\" "
longhorn-manager-lsw5z longhorn-manager <IP_ADDRESS> - - [22/Jun/2021:02:15:15 +0000] "GET /v1/backupvolumes/pvc-18c99596-9eed-4fb6-8b23-047b160b658e HTTP/1.1" 200 896 "" "Go-http-client/1.1"
longhorn-manager-lsw5z longhorn-manager time="2021-06-22T02:15:18Z" level=error msg="message from backupVolume[pvc-18c99596-9eed-4fb6-8b23-047b160b658e], type[error], content[cannot find backupstore/volumes/35/45/pvc-18c99596-9eed-4fb6-8b23-047b160b658e/volume.cfg in backupstore]"
longhorn-manager-lsw5z longhorn-manager <IP_ADDRESS> - - [22/Jun/2021:02:15:18 +0000] "POST /v1/backupvolumes/pvc-18c99596-9eed-4fb6-8b23-047b160b658e?action=backupList HTTP/1.1" 200 162 "" "Go-http-client/1.1"
longhorn-manager-lsw5z longhorn-manager <IP_ADDRESS> - - [22/Jun/2021:02:15:20 +0000] "GET /v1/volumes/pvc-18c99596-9eed-4fb6-8b23-047b160b658e HTTP/1.1" 200 3914 "" "Go-http-client/1.1"
longhorn-csi-plugin-49px9 longhorn-csi-plugin time="2021-06-22T02:15:20Z" level=error msg="GRPC error: rpc error: code = Internal desc = Action [snapshotList] not available on [&{pvc-18c99596-9eed-4fb6-8b23-047b160b658e volume map[self:http://longhorn-backend:9500/v1/volumes/pvc-18c99596-9eed-4fb6-8b23-047b160b658e] map[activate:http://longhorn-backend:9500/v1/volumes/pvc-18c99596-9eed-4fb6-8b23-047b160b658e?action=activate attach:http://longhorn-backend:9500/v1/volumes/pvc-18c99596-9eed-4fb6-8b23-047b160b658e?action=attach cancelExpansion:http://longhorn-backend:9500/v1/volumes/pvc-18c99596-9eed-4fb6-8b23-047b160b658e?action=cancelExpansion detach:http://longhorn-backend:9500/v1/volumes/pvc-18c99596-9eed-4fb6-8b23-047b160b658e?action=detach engineUpgrade:http://longhorn-backend:9500/v1/volumes/pvc-18c99596-9eed-4fb6-8b23-047b160b658e?action=engineUpgrade expand:http://longhorn-backend:9500/v1/volumes/pvc-18c99596-9eed-4fb6-8b23-047b160b658e?action=expand pvCreate:http://longhorn-backend:9500/v1/volumes/pvc-18c99596-9eed-4fb6-8b23-047b160b658e?action=pvCreate pvcCreate:http://longhorn-backend:9500/v1/volumes/pvc-18c99596-9eed-4fb6-8b23-047b160b658e?action=pvcCreate recurringUpdate:http://longhorn-backend:9500/v1/volumes/pvc-18c99596-9eed-4fb6-8b23-047b160b658e?action=recurringUpdate replicaRemove:http://longhorn-backend:9500/v1/volumes/pvc-18c99596-9eed-4fb6-8b23-047b160b658e?action=replicaRemove updateAccessMode:http://longhorn-backend:9500/v1/volumes/pvc-18c99596-9eed-4fb6-8b23-047b160b658e?action=updateAccessMode updateDataLocality:http://longhorn-backend:9500/v1/volumes/pvc-18c99596-9eed-4fb6-8b23-047b160b658e?action=updateDataLocality]}]"

Another quick note.
This issue may be caused by reconciling longhorn volumes in following lines.
https://github.com/harvester/harvester/blob/158a35d34e9ab4f9b4cc8f6b4268fa495a69c3f1/pkg/controller/master/backup/backupcontent.go#L344-L353
Since snapshotList action is only supported for attached volume, we need to attach it first. However, the volume won't turn into attached state within a reasonable period, say, 10 minutes. Sometimes it results in a weird state transitiondetached -> attaching -> detached.
NAMESPACE         NAME                                       STATE      ROBUSTNESS   SCHEDULED   SIZE          NODE   AGE
longhorn-system   pvc-1cf6533a-f95c-403e-97d1-51a95beecdb4   detached   unknown      True<PHONE_NUMBER>0          8m17s
longhorn-system   pvc-1cf6533a-f95c-403e-97d1-51a95beecdb4   detached   unknown      True<PHONE_NUMBER>0          9m37s
longhorn-system   pvc-1cf6533a-f95c-403e-97d1-51a95beecdb4   attaching   unknown      True<PHONE_NUMBER>0   h0     9m37s
longhorn-system   pvc-1cf6533a-f95c-403e-97d1-51a95beecdb4   attaching   unknown      True<PHONE_NUMBER>0   h0     9m37s
longhorn-system   pvc-1cf6533a-f95c-403e-97d1-51a95beecdb4   detached    unknown      True<PHONE_NUMBER>0          9m37s
longhorn-system   pvc-1cf6533a-f95c-403e-97d1-51a95beecdb4   detached    unknown      True<PHONE_NUMBER>0          9m37s

The root cause
Here is a list of available action for a longhorn volume in different state.
From Harvester we do VM offline snapshot by first attaching the Longhorn volume manually. Then take a snapshot. However, sometimes the final status won’t become attached so we fail to do a offline VM backup. The description is here for what I discovered.
From Longhorn side, this controller/share_manager_controller.go:detachShareManagerVolume cause the volume detach in the final stage.
The following represents the call stack:
volume.Spec.NodeID change triggers VolumeController.ReconcileShareManagerState
→ which calls createShareManagerForVolume  because the previous one was deleted after VM off
Then in ShareManagerControlle.syncShareManager we sync changes of share managers
→ calls syncShareManagerVolume
→ calls isShareManagerRequiredForVolume, the result would be no longer required since there is no active workload
→ the defer function calls detachShareManagerVolume which triggers a detachment
The approach
JenTing proposes using maintenance mode by changing volume.Spec.DisableFrontend = true. This will prevent share manage from detaching the volume, which is the expected outcome.
Things to do

[ ]  When reconciling Longhorn volume by propose previous Node ID, also enter the maintenance mode by change volume.Spec.DisableFrontend = true
[ ]  Turn back DisabledFrontend = false before we restart the VM (exit maintenance mode)

[ ]  When all volumes backup complete and the VM is not running

[ ]  detach all volumes related the VM
[ ]  set all volumes back to DisableFrontend = false

To beware (may be some straw men)

Is manually changes DisabledFrontend legit? If not, how to tell whether the maintenance mode is turned-on by backup from Harvester or manually by user via Longhorn UI?
Should we prevent use from starting the VM while doing offline backup?

Tested successfully with the last master branch master-88f1d22c-head and a 5 baremetal nodes cluster.

Create a VM :heavy_check_mark:

Log in to VM :heavy_check_mark:

Create a file (testfile1 - testfile2) :heavy_check_mark:

Turn off the VM :heavy_check_mark:

Take backup :heavy_check_mark:

Try to start the VM after taking the backup :heavy_check_mark:

Create other files testfile3 testfile4 :heavy_check_mark:

Restore from the backup :heavy_check_mark:

Connect to the VM and check the files :heavy_check_mark:

ubuntu@vm1:~$ ls
testfile1  testfile2


Update backend dependencies

Closes https://github.com/grafana/oss-plugin-partnerships/issues/175

The code coverage workflow seems to fail when the organization of the repo is not pkg/<datasource>/<all other directories
We'll have to solve that, but I propose doing that in another PR and bypassing this check for this PR.