Add check for extension of output file in cg()

The title is explicit.
After I have tested the app, I have no explicit message when using -o argument without extension or with a bad one.
So I have a IndexError on https://github.com/androguard/androguard/blob/8d091cbb309c0c50bf239f805cc1e0931b8dcddc/androguard/cli/main.py#L122

I would use os.path.splitext for that. It is more resilient

Should I change only my PR with this or also main.py ?
https://github.com/androguard/androguard/blob/8d091cbb309c0c50bf239f805cc1e0931b8dcddc/androguard/cli/main.py#L122

It is probably a good idea to change it everywhere, however I can not merge PRs and I do not know what the plan is for the python androguard version see https://github.com/androguard/androguard/issues/833#issuecomment-759304208

Hoooo issue #833  was closed so I miss that.
So I will update my PR and keep changes for my own purpose ^^
Thanks anyway.

Given that this PR is old and the project is substantially different nowadays, I will be closing this.
Please feel free to reopen it in case it still stands.


Issue 3578 expected conditions

Add error handler falseIfMissing to all expected conditions that depend
on the presence of an element.
Expected conditions check the presence of an element before other checks,
but when an element is removed exactly in the moment after the isPresent
and before isDisplayed in visibilityOf the condition used to fail.
This solution does not handle missing elements in (isEnable, isDisplayed, isSelected) and focused only on expected conditions (see
#3972)
This problem was also referenced in
#3578.
Tests
Add test cases to reproduce the missing element race conditions possible in
expected condition methods visibilityOf, textToBePresentInElement,
textToBePresentInValue and elementToBeClickable.
See failing tests before implementation: https://circleci.com/gh/tilmanpotthof/protractor/14

Thanks so much for this! Especially for including test cases!

@mgiambalvo Thanks for merging!


Toast Not Working (Production)

Toast is not showing on production

@Otrex maybe some of the classes are being pruned in tailwind? did you check if they're there?

@Otrex looks like the same issue of this guy, please check: https://github.com/acidjazz/nuxt-tailvue/issues/7#issuecomment-996309084


Manifest verification

The serde code for parsing the manifests is pretty ok but misses some semantic checks:
Uncomplete list of needed checks:

[x] env, init, args may not not contains any null byte - needs to be convertible to a CString
[x] mount points may not overlap
[x] name, version, uid and gid are mandatory
[x] args, env and others are not valid if init equals None
[x] croups names must be convertible to CString
[x] uid range
[x] gid range
[x] character range for all items especially name

See #208

Implemented by #387


Saving clients/streams into the revit file.

Is there such a thing as user data for a rvt file? How to save client senders and receivers in a revit file like we do in SpeckleRhino?

You use something called ExtensibleStorage which allows arbitrary data to be stored/retrieved in a Revit file. ES offers control over who can see/access that data too.
Most commonly, you store serialised JSON as a string and deserialise on retrieval.

I have some utils i've written on my projects that i can donate for this :)

Doesn't Revit display a warning message if ExtensibleStorage data is found in a file and that specific plugin is not installed?


helper_linux: Set mtu_request for ovs-doca ports

ovs-doca requires mtu_request to be set on ports metadata for fragmented packets

📑 Description

Fixes #
Additional Information for reviewers

✅ Checks

[ ] My code requires changes to the documentation
[ ] if so, I have updated the documentation as required
[ ] My code requires tests
[ ] if so, I have added and/or updated the tests as required
[ ] All the tests have passed in the CI

How to verify it

@girishmg can you please review?


Bump landing to raw to pick up validation changes

I think the smoketest will fail until we merge https://github.com/ministryofjustice/data-platform/pull/1835


Fix when you change the Factory name of device

Fix when you change the Factory name of device

@julianoAffonso thank you!


Add documentation for use-safe-access linter rule

See #14322 for more information.

PR created - https://github.com/MicrosoftDocs/azure-docs-pr/pull/281307/files


Set Expiration and Renewal Policies for JWTs Generated by the External System

Discovery:
JWT tokens used for authentication in LibreChat need to have an appropriate expiration policy to ensure security and prevent unauthorized access. Tokens that last too long increase the risk of misuse, while tokens that expire too quickly may disrupt the user experience. Additionally, a token renewal mechanism may be required to extend a session without forcing users to reauthenticate frequently.
Problem Definition:
The external system currently generates JWT tokens for authentication, but it does not enforce an explicit expiration policy or provide a mechanism for renewing tokens. Without these, tokens may remain valid indefinitely, posing a security risk, or users may need to log in again after each token expires, negatively affecting the user experience.
Motivations:
By setting proper expiration and renewal policies for JWT tokens, we will:

Enhance security by ensuring tokens expire after a reasonable period, limiting the window for misuse.
Provide a seamless user experience by allowing tokens to be renewed via a secure endpoint, extending session duration without requiring reauthentication.
Ensure that token expiration aligns with security best practices while balancing user convenience.

Proposed Solution:

Set Token Expiration Policy:

Define a default expiration period for the JWT tokens (e.g., 24 hours). This means that after 24 hours, the token will no longer be valid, and the user will need to renew or reauthenticate.
The expiration (exp) claim should be added to the JWT payload, specifying the exact time at which the token will expire. This will be used to enforce token expiration on the LibreChat side.

Implement Token Renewal Endpoint:

Create a secure endpoint in the external system to handle token renewal. This endpoint will allow clients to exchange a valid but soon-to-expire token for a new one without requiring full reauthentication.
Ensure that the renewal process only works if the current token is still valid (i.e., not expired) and that the new token is issued with a fresh expiration period (e.g., another 24 hours).
Consider requiring the user’s refresh_token or other secure mechanism to prevent misuse of the renewal process.

Grace Period for Expired Tokens (Optional):

Optionally, introduce a grace period after the token has expired where the user can still renew the token without logging in again. This can help prevent user frustration caused by accidental session expiration.

Security Considerations:

Ensure that the expiration policy is set according to security best practices. Shorter expiration periods are generally more secure, but they must be balanced with user convenience.
Ensure tokens are signed with a secure algorithm (e.g., HS256, RS256) and verify the signature during both authentication and renewal processes.
Store any refresh_token or related sensitive information securely, using encryption if necessary.

Definition of Done:

[ ] JWT tokens are issued with an exp claim that expires after a reasonable period (e.g., 24 hours).
[ ] A secure token renewal endpoint is implemented, allowing clients to renew tokens before they expire.
[ ] Proper security checks are implemented to validate tokens and prevent misuse of the renewal process.
[ ] Expired tokens are rejected for authentication, but if a renewal policy is in place, the system will allow tokens to be renewed within the grace period (optional).
[ ] Test cases are added to ensure tokens expire correctly and that the renewal process works as expected.

Additional Information:

Documentation: Update internal and external documentation to describe the expiration policy and how token renewal should be handled.
Testing: Ensure tests cover token expiration, invalid token handling, and renewal scenarios to verify that the security and functionality work as expected.
Monitoring: Use logging and monitoring tools (e.g., CloudWatch) to track token expirations and renewal attempts for auditing and debugging.

#time 1
Update of the JWT creation scripts (they were using a too short exp time)


EIP-2612 support

Since ERC20 of solady supports EIP-2612 I think it would make sense if DN404 also supports EIP-2612 as well.
Or, for the meantime I should be using the ERC20Permit extension from openzeppelin?
cc @Vectorized

Oh... u want 2612? We can add it. Nice suggestion.

Not sure how many dapps would actually benefit from 2612.

@Vectorized Maybe we want this instead? https://github.com/Uniswap/permit2 😈

What if we go the route of auto approval of permit2 similar to polygon's POL token

2612 or permit2… which one is cheaper?

Depends. Permit2 can be used gaslessly so integrating it optionally here means that users do not have to approve permit2 for max uint256 beforehand. On the other hand, with 2612, not sure how many dapps use it.
Though it's important to think of the malicious signing attack vector that it introduces

What is the canonical Permit2 address?


New+ not showing on context (right-click) menu, even under "show more options"

Microsoft PowerToys version
0.85.1
Installation method
PowerToys auto-update, WinGet
Running as admin
No
Area(s) with issue?
New+
Steps to reproduce
I don't really know what triggered the bug.
I've just updated from the in-program option. Sometimes I do winget upgrade also.
My windows is in English (US), but my keyboard is PT-BR ABNT2.
✔ Expected Behavior
A "New+" menu should appear when right clicking in a folder/desktop.
❌ Actual Behavior

Other Software
No response

/dup https://github.com/microsoft/PowerToys/issues/35210


chore(engine-test): use a temp directory instead of a Shrinkwrap archive

allows removing the dependency on Shrinkwrap.
How are there so many of these???

oh hey there Jenkins, that's some failing tests showing up

Oh. A bunch of NPEs because it doesn't like that I tried to pass null as the list of attributes. That's easily explicable, at least.


Stop registering children during willInsertElement

Per a discussion with @stefanpenner, this is causing re-render of components and slowness. In particular, axes are problematic.

One thing worth noting, it isn't that all registrations are inherently going to cause performance issues. I did notice that some of them in nf-graph. where themselves causing data changes that would require further render updates.
Doing this these extra renders obviously means we need to render parts twice. This clearly should be avoided. The caveat is, it isn't clear that this is actually happening.

@stefanpenner one quirky thing I'm doing that was a sort of "hack" recommended by @ebryn is seen in the nf-graph component. This is where i have a willInsertElement that is setting a hasRendered to true. That hasRendered is used in an {{#if}} in the template that tells it it's okay to render. This was because I needed a way to delay the render until the children were ready. I'll have to experiment with other ways to do this, as it will not be straightforward. It's also possible that I no longer need to do this, and it's legacy code. I'm unsure.

PR #54 is related.
Interestingly, when I run benchpress against this PR branch and the code before the PR, the code before the PR is some trivial amount faster, on average, 10 ms or so.


K8's 1.31 support for csp-adapter

Add k8's 1.331 support for csp adapter

@Sahota1225 what is the approximate timeframe for 2.10? I'm aware of the maintenance releases for 2.8/2.9 in August, Sept, but am not caught up on 2.10 plans. Thank you!


[Bug]: Jest crashes on Node.js v23 when using jest.config.js contains TLA

Version
30.0.0-alpha.6
Steps to reproduce
The jest.config.js file in Prettier repo imports a module that contains TLA  (comes from temp-dir), when using Node.js v23 Jest crashes. https://github.com/prettier/prettier/pull/16761
Expected behavior
Run tests without error.
Actual behavior
Error: require() cannot be used on an ESM graph with top-level await. Use import() instead. To see where the top-level await comes from, use --experimental-print-required-tla.

Additional context
I tried to comment out our install-prettier.js
Jest runs without error.
If I add
await Promise.resolve()

The error comes back.
Environment
System:
    OS: Windows 10 10.0.19044
    CPU: (8) x64 Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
  Binaries:
    Node: 23.1.0 - ~\AppData\Local\fnm_multishells\1144_1730082443572\node.EXE
    Yarn: 4.5.0 - D:\npm\yarn.CMD
    npm: 10.9.0 - ~\AppData\Local\fnm_multishells\1144_1730082443572\npm.CMD
    pnpm: 9.3.0 - D:\npm\pnpm.CMD
  npmPackages:
    jest: 30.0.0-alpha.6 => 30.0.0-alpha.6

This happens on Node v22.12 now, since they enabled requiring ESM by default.
The problem lies within requireOrImportModule, since it doesn't check for the new ERR_REQUIRE_ASYNC_MODULE error code that is thrown when the modules contains TLA.
https://github.com/jestjs/jest/blob/3c50aab0c5250cb4cfeafe72d3053b65237a3bc5/packages/jest-util/src/requireOrImportModule.ts#L28


update limitations section for clear containers 3.0

Per discussion on https://github.com/clearcontainers/runtime/issues/12  :
Need to update known-limitations section to our project's readme.

Let's collect everyones input below and I'll then work this into a doc to store in-tree:

https://github.com/clearcontainers/runtime/wiki/Current-Limitations


reserved identifier violation

I would like to point out that an identifier like "__LCUI_WIDGET_EVENT_H__" does not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

ok, I know, you are already said it again.

the C language standard also has such this identifier naming rule ?

Yes. - It is similar.
Thanks for your improvements of affected include guards.

Thanks for further source code improvements.

If there are no other problems, you should choose to close this issue.


added block formUserOptions around user options in slideshow editor

i think it should be possible to change the user options in a widget that's based on the slideshow without copying the whole formAll block

Closing because 0.5.x is in maintenance mode.


Crashes After Opening

Hi, I was following along with Paul Allen Clifford's video on how to use this software and the function opens unless my port and password matches with PCO. Once I do that, the function opens, escapes from full screen and then closes itself. Any suggestions?

Resolved. There are two places that it says “port” on the network settings for PCO. If the port in the “Enable Network” section matches the .jar configure file, the program crashes. The “port” that we are supposed to match is the one in the “enable stage display app” section.


Add API documentation for PixelDisplay interface

Also fixes color issue with tool/common.sh print_divider, where the
bottom diviider was white when it should have been yellow.
Resolves #799

Coverage increased (+0.1%) to 78.107% when pulling 1e85c6722e7f64ef125df2c2acc8462d6f51dede on add-pixel-api into 0bfc5d09bb501ac1d73cc893ae663cb04be33de3 on master.


Missing _gstplayer.sо

Missing _gstplayer.sо in Kivy installed from daily PPA. Ubuntu 14.04

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

Will take a look why we are not building with gstreamer support.

Really don't want to blame that problem on others, but it seems that our setup.py does not find the
gstreamer-1.0.pc file.
Just looked which package includes the needed file for your detection and here it is:
thopiekar@hp:~$ apt-file find gstreamer-1.0.pc
libgstreamer1.0-dev: /usr/lib/x86_64-linux-gnu/pkgconfig/gstreamer-1.0.pc

Line 19 in our debian/control says it should install the package (https://github.com/kivy/kivy/blob/pkg-debian-daily/control#L19) and it does according to the latest build for vivid ( https://launchpadlibrarian.net/195552292/buildlog_ubuntu-vivid-i386.kivy_1.9.0-dev~daily0%2B201501221246-2559-testing55~ubuntu15.04.1_UPLOADING.txt.gz ), but:
 * use_gstreamer = 0

So it does not seem to be a packaging problem, more a gstreamer-detection problem..

Tested it now locally by installing pkg-config and libgstreamer-1.0-dev and it seems to work:
thopiekar@hp:~$ pkg-config --libs --cflags gstreamer-1.0
-pthread -I/usr/include/gstreamer-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -lgstreamer-1.0 -lgobject-2.0 -lglib-2.0

Really strange..

Found the reason in line 75: https://github.com/kivy/kivy/blob/master/setup.py#L75
Well, by now it is not my decision to set c_options['use_gstreamer'] = None, but I think it is intended to be None, when looking at https://github.com/kivy/kivy/blob/master/setup.py#L272.
Think it is time to bring back the facepalm..

Also, on L272 that should be use_sdl2 not use_gstreamer. Gstreamer is handled by the block above that one.

 The code needs there more clean ups..

Done. Sorry for the mess, the setup have been splitted for sdl2 and gstreamer (was on the same boat before) and we now take care of what the user set prior the setup.py execution.
Example:

python setup.py  -> autodetect sdl2 / gstreamer
USE_GSTREAMER=1 -> allow usage of gstreamer (but don't fail if it's not found)
USE_GSTREAMER=0 -> disable gstreamer (no autodetection, no compilation)


10 attempts run socket tests #1229 and branch vNext_yarong_417_812_1205

This change is

PR is added to the queue for testing as 1. task. (150ee9f)

Test 96293062 (150ee9f) build started.

Test (Success) 96293062 build is completed (150ee9f)
See https://github.com/ThaliTester/TestResults/tree/96293062150ee9f_10_attempts_run_socket_tests__1229_and_branch_vNext_yarong_417_812_1205_vasilevskayaem/ for the logs

Test<PHONE_NUMBER>0ee9f(150ee9f) has failed
See https://github.com/ThaliTester/TestResults/tree/96293062150ee9f_10_attempts_run_socket_tests__1229_and_branch_vNext_yarong_417_812_1205_vasilevskayaem/ for the fail logs

Review status: 0 of 5 files reviewed at latest revision, 6 unresolved discussions, some commit checks failed.

src/android/test/io/jxcore/node/IncomingSocketThreadMockWithLatch.java, line 25 at r1 (raw file):

    @Override
    public void onStreamCopyingThreadDone(StreamCopyingThread who) {
        Log.e("!!", "countdown!");

I don't think that we need this log

src/android/test/io/jxcore/node/IncomingSocketThreadTest.java, line 142 at r1 (raw file):

    @Test
    public void testConstructor() throws Exception {

Useless test. We are testing that operator new works fine

src/android/test/io/jxcore/node/IncomingSocketThreadTest.java, line 148 at r1 (raw file):

    @Test
    public void testGetTcpPortNumber() throws Exception {

Useless test. I don't think that testing getter via reflection is good idea

src/android/test/io/jxcore/node/IncomingSocketThreadTest.java, line 179 at r1 (raw file):

                    mIncomingSocketThread.getLocalHostPort(), is(0));
        } else {
            assertThat("getLocalHostPort should return null if mLocalhostSocket is null",

We will never fall into that branch. Also assert naming lies to us. Comparing primitive type to null is bad idea. The whole idea of this test is to test default value via getter. I don't think that we still need this test

src/android/test/io/jxcore/node/OutgoingSocketThreadTest.java, line 141 at r1 (raw file):

    @Test
    public void testConstructor() throws Exception {

We don't need that. See comments above

src/android/test/io/jxcore/node/OutgoingSocketThreadTest.java, line 147 at r1 (raw file):

    @Test
    public void testGetListeningOnPortNumber() throws Exception {

Test for default value. It's a disputable  test

Comments from Reviewable

PR is added to the queue for testing as 5. task. (7a5cd25)

Review status: 0 of 5 files reviewed at latest revision, 6 unresolved discussions, some commit checks failed.

src/android/test/io/jxcore/node/IncomingSocketThreadMockWithLatch.java, line 25 at r1 (raw file):
Previously, evabishchevich wrote…
I don't think that we need this log

Done.

src/android/test/io/jxcore/node/IncomingSocketThreadTest.java, line 142 at r1 (raw file):
Previously, evabishchevich wrote…
Useless test. We are testing that operator new works fine

Done.

src/android/test/io/jxcore/node/IncomingSocketThreadTest.java, line 148 at r1 (raw file):
Previously, evabishchevich wrote…
Useless test. I don't think that testing getter via reflection is good idea

Done.

src/android/test/io/jxcore/node/IncomingSocketThreadTest.java, line 179 at r1 (raw file):
Previously, evabishchevich wrote…
We will never fall into that branch. Also assert naming lies to us. Comparing primitive type to null is bad idea. The whole idea of this test is to test default value via getter. I don't think that we still need this test

removed only unreached part code. let's leave default value check

src/android/test/io/jxcore/node/OutgoingSocketThreadTest.java, line 141 at r1 (raw file):
Previously, evabishchevich wrote…
We don't need that. See comments above

Done.

src/android/test/io/jxcore/node/OutgoingSocketThreadTest.java, line 147 at r1 (raw file):
Previously, evabishchevich wrote…
Test for default value. It's a disputable  test

Done.

Comments from Reviewable

Test 96293062 (7a5cd25) build started.

Test (Fail) 96293062 build is completed (7a5cd25)
See https://github.com/ThaliTester/TestResults/tree/962930627a5cd25_10_attempts_run_socket_tests__1229_and_branch_vNext_yarong_417_812_1205_vasilevskayaem/ for the logs

Review status: 0 of 5 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

src/android/test/io/jxcore/node/IncomingSocketThreadTest.java, line 138 at r2 (raw file):

    @Test
    public void testSetTcpPortNumber() throws Exception {

Is there any reason for setter and getter test?

src/android/test/io/jxcore/node/OutgoingSocketThreadTest.java, line 147 at r1 (raw file):
Previously, vasilevskayaem wrote…
Done.

@vasilevskayaem Why did you agreed to delete this test but didn't agree to remove testGetLocalHostPort? They look similar

Comments from Reviewable

PR is added to the queue for testing as 1. task. (71be26a)

Test 96293062 (71be26a) build started.

Test (Success) 96293062 build is completed (71be26a)
See https://github.com/ThaliTester/TestResults/tree/9629306271be26a_10_attempts_run_socket_tests__1229_and_branch_vNext_yarong_417_812_1205_vasilevskayaem/ for the logs

Test<PHONE_NUMBER>be26a(71be26a) has failed
See https://github.com/ThaliTester/TestResults/tree/9629306271be26a_10_attempts_run_socket_tests__1229_and_branch_vNext_yarong_417_812_1205_vasilevskayaem/ for the fail logs

PR is added to the queue for testing as 1. task. (6a8dc4e)

Test 96293062 (6a8dc4e) build started.

Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions.

src/android/test/io/jxcore/node/IncomingSocketThreadTest.java, line 138 at r2 (raw file):
Previously, evabishchevich wrote…
Is there any reason for setter and getter test?

Done.

src/android/test/io/jxcore/node/OutgoingSocketThreadTest.java, line 147 at r1 (raw file):
Previously, evabishchevich wrote…
@vasilevskayaem Why did you agreed to delete this test but didn't agree to remove testGetLocalHostPort? They look similar

Done.

Comments from Reviewable

@yaronyg Please, look at my comments in this PR. They can clarify our concerns about the tests.

Test (Success) 96293062 build is completed (6a8dc4e)
See https://github.com/ThaliTester/TestResults/tree/962930626a8dc4e_10_attempts_run_socket_tests__1229_and_branch_vNext_yarong_417_812_1205_vasilevskayaem/ for the logs

Test 962930626a8dc4e(6a8dc4e) has failed
See https://github.com/ThaliTester/TestResults/tree/962930626a8dc4e_10_attempts_run_socket_tests__1229_and_branch_vNext_yarong_417_812_1205_vasilevskayaem/ for the fail logs

Review status: 0 of 3 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions.

src/android/test/io/jxcore/node/IncomingSocketThreadTest.java, line 189 at r4 (raw file):

                attempts--;
                closeSockets();
                setUp();

I'm scary about calling setUp manually. Please at least expand some logic into another method and use it in setup too.

src/android/test/io/jxcore/node/OutgoingSocketThreadTest.java, line 214 at r4 (raw file):

                attempts--;
                closeSockets();
                setUp();

see my comment about setup above.

Comments from Reviewable

Review status: 0 of 3 files reviewed at latest revision, 3 unresolved discussions.

src/android/test/io/jxcore/node/IncomingSocketThreadTest.java, line 210 at r4 (raw file):

    }

    private Future runningOutgoingSocketThread() throws Exception {

NB: strange naming. Run instead of running is better option as for me

Comments from Reviewable

PR is added to the queue for testing as 3. task. (5c465b9)

Test 96293062 (5c465b9) build started.

Test 96293062 (5c465b9) build started.

PR is added to the queue for testing as 4. task. (9a6bd77)

Review status: 0 of 3 files reviewed at latest revision, 3 unresolved discussions.

src/android/test/io/jxcore/node/IncomingSocketThreadTest.java, line 189 at r4 (raw file):
Previously, larryonoff (larryonoff) wrote…
I'm scary about calling setUp manually. Please at least expand some logic into another method and use it in setup too.

Done.

src/android/test/io/jxcore/node/IncomingSocketThreadTest.java, line 210 at r4 (raw file):
Previously, evabishchevich wrote…
NB: strange naming. Run instead of running is better option as for me

Done.

src/android/test/io/jxcore/node/OutgoingSocketThreadTest.java, line 214 at r4 (raw file):
Previously, larryonoff (larryonoff) wrote…
see my comment about setup above.

Done.

Comments from Reviewable

Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions.

src/android/test/io/jxcore/node/IncomingSocketThreadTest.java, line 72 at r6 (raw file):

    }

    private void init() throws Exception {

I think initDependencies better name

Comments from Reviewable

PR is added to the queue for testing as 5. task. (c9b8e19)

Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions.

src/android/test/io/jxcore/node/IncomingSocketThreadTest.java, line 72 at r6 (raw file):
Previously, larryonoff (larryonoff) wrote…
I think initDependencies better name

Done.

Comments from Reviewable

Test (Fail) 96293062 build is completed (5c465b9)
See https://github.com/ThaliTester/TestResults/tree/962930625c465b9_10_attempts_run_socket_tests__1229_and_branch_vNext_yarong_417_812_1205_vasilevskayaem/ for the logs

Test 96293062 (9a6bd77) build started.

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Test (Success) 96293062 build is completed (9a6bd77)
See https://github.com/ThaliTester/TestResults/tree/962930629a6bd77_10_attempts_run_socket_tests__1229_and_branch_vNext_yarong_417_812_1205_vasilevskayaem/ for the logs

Test 96293062 (c9b8e19) build started.

Test 962930629a6bd77(9a6bd77) has failed
See https://github.com/ThaliTester/TestResults/tree/962930629a6bd77_10_attempts_run_socket_tests__1229_and_branch_vNext_yarong_417_812_1205_vasilevskayaem/ for the fail logs

Test (Success) 96293062 build is completed (c9b8e19)
See https://github.com/ThaliTester/TestResults/tree/96293062c9b8e19_10_attempts_run_socket_tests__1229_and_branch_vNext_yarong_417_812_1205_vasilevskayaem/ for the logs

Test 96293062c9b8e19(c9b8e19) has failed
See https://github.com/ThaliTester/TestResults/tree/96293062c9b8e19_10_attempts_run_socket_tests__1229_and_branch_vNext_yarong_417_812_1205_vasilevskayaem/ for the fail logs


Search with English using Quotes

Is your feature request related to a problem? Please describe.
When a request for a word is made where the keyword is wrapped in quotes, for example, http://localhost:8080/api/v1/words?keyword="word", the API should interpret the term as English and search for related terms.
The words controller is responsible for determining whether or not to treat the keyword as if it's Igbo or English. The API prioritizes searching with Igbo, so when quotes are involved the API should switch to prioritizing English.
Describe the solution you'd like

Update the API so that when a keyword is wrapped in quotes, the API will only treat the word as an English term
Create tests to make sure that the API handles quoted keywords

Describe alternatives you've considered
N/A
Additional context
N/A

This issue has been addressed in #367


Multiple headers with the same name

I am trying to connect to a server that returns three headers with the same name: Set-Cookie. When I do a simple
dd(Zttp::asFormParams()->post($url, [
    // some data
])->headers()->toArray());

it returns an array of headers, but Set-Cookie is only one there.
Expected: There should be an array of cookies returned:
[
    'Set-Cookie' => [
        'cookie-1',
        'cookie-2'
    ],
    // some other data
]

Actual: Only first cookie is returned
[
    'Set-Cookie' => 'cookie-1',
    // some other data
]

I should note that
$response->header('Set-Cookie')

works as expected by creating a comma-separated list :)

I run into the same problem. Took me quite some time to figure it out.

Is this just the use of $v[0] instead of return [$k => $v]; which is causing this?
https://github.com/kitetail/zttp/blob/39f84d07461cd40bcc2bc326f2f317c5f97f46bb/src/Zttp.php#L270-L275

@pxgamer this is one way to solve it. but it's a breaking change :) it will convert all values into arrays of strings instead of just strings.
i did it exactly this way, but now i can't update the package. which is fine in my case.


Ignore following request functionality

Description

Prep for https://linear.app/serverless/issue/SC-690/python-sdk-instrument-aws-sdk-requests
This will allow us to selectively ignore http instrumentation in the case of AWS SDK calls

Testing done
Unit tested

@Mmarzex ready for review please 🙏

@medikoo ready for review please 🙏


Added extraction of the encoding from url requests in evidence.py

Fixed clumsy handling of unicode values in SimpleProperty __str__
method
Related to openworm/PyOpenWorm#210

@mwatts15 Messaged you about it. As far as I can tell, the solution (in the test files) would be doing u"Frédéric MY".encode('UTF-8') for the first argument instead of only u"Frédéric MY", and then the build should pass. I just don't know exactly why, I was trying out things to figure out what was happening, and I found out that's what it's doing.

Closing this PR as it brings in changes unrelated to #210


Prevent .row from shrinking in .navbar > .container

Fixes #30840
Working around this issue, this seems the simplest and cleanest way to prevent row from shrinking.
Didn't notice any drawback yet, since it'll only be applied if .row's parent is a flex container.
FYI it'll still break if .row's parent is display: flex but doesn't allow wrapping. Don't know if it should be adressed at all, though.
@mdo @MartijnCuppens you know rows and history better than I do, so feel free to drop this if it looks wrong.

Why do we set the flex-basis to 100% and than use flex-grow to grow anyway? just flex-grow should do the trick?

flex-grow: 1 does the job, indeed.
I always use the flex shorthand as recommend by the specs. FWIW, after reading flex common patterns, flex: 1; would do the job, too.
Do we stick with flex-grow: 1;?

Do we stick with flex-grow: 1;?

Yeah we should. 100% doesn't make any sense since the width is actually more  due to the negative margins.

Scratch that, a flex-basis of 100% might be useful if you're adding multiple .rows in a flex container.


Fix links without href check

Currently linksWithoutHref throws an exception when it encounters a link without an href attribute, as the null value that is returned from getAttribute(link, 'href') chokes on .trim().
The fix in this PR simply reverses the order of the test so that hasAttribute is called first, which ensures that a string value will always be provided.

I just missed it, my fault. thanks @justisb  💯 👍


Compile 1.17.5 flutter engine failed

MacOS:Big Sur 11.5.2
XCode:12.5.1
I get some errors when I compile 1.17.5 flutter engine. I'm sure the branch is right，and the every step is right。

How can I fix?

Hi @Wbqqqq
This is probably because you're using a newer Xcode with a very old Flutter version
Please try latest master engine branch with it's latest Flutter master branch


FEATURE: MPNT-31 Update correct data source password

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/compliance/job/gdc-public-demos-oss-check/20/ : SUCCESS in 6s

Sonar scan result

No issue found. Congratulations!

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gdc-public-demos-gate-PR8
To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

Build succeeded (gate pipeline).

https://checklist.intgdc.com/job/compliance/job/gdc-public-demos-fossa-scanning-zuul-el7/8/ : SUCCESS in 46s (non-voting)
https://checklist.intgdc.com/job/compliance/job/gdc-public-demos-sonarqube-scan-zuul-gate/8/ : SUCCESS in 15s
https://checklist.intgdc.com/job/compliance/job/gdc-public-demos-merge-compliance-check/9/ : SUCCESS in 25s


Updated beta for 8.0

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)

We finally have the OpenMM-Torch build issues resolved and can move forward with the beta.  This updates the source revision to get the latest changes.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

All of the builds for ARM Mac failed with this error:
2022-09-13T19:51:11.9299260Z /Users/runner/miniforge3/etc/profile.d/conda.sh: line 9:  6048 Segmentation fault: 11  "$CONDA_EXE" $_CE_M $_CE_CONDA "$@"

Any idea what could be causing it?

  Do you remember why?  In any case, it passed when we did the last build two months ago.

IIRC, it's due to the fact we can't run ARM64 code on the regular CI.
We included this line
https://github.com/conda-forge/openmm-feedstock/blob/036712c3b1647d28ee2bb5d1df6c1581a6390a70/recipe/meta.yaml#L5
so the tests get included in the final package, and we could test the artifacts locally, because we couldn't be sure cross-compilation was not introducing errors in the unit tests. If you are confident the process works ok, I guess you can remove it!

It might also do with the patching we needed for OSX tests, which had wrong rpaths or something. The patching was needed to make tests relocatable, iirc. This way people can test the package locally with conda build --test <tarball>. But if that's getting in the way, go ahead and skip it.
It'd be nice to know why it's segfaulting now, though. I'd start by comparing the versions of the packages installed in the build and host environments in both commits, but up to you.

Let's try leaving out the tests and see what happens.  Something upstream must have changed in the last two months to cause the error to appear.

That seems to have worked.  Shrug?  Since this is just a beta, let's go ahead with it.  We'll see if any problems come up when users start working with it.


Emoji reaction css

Light theme version after improvement ->

Dark theme version after improvement ->

Closing as we're doing a different redesign of emoji CSS in https://github.com/zulip/zulip/pull/26580, thanks @jai2201!


Missing Color on bracets with noting inn it

Describe the bug
missing colors on empty (), [] and {}.
To Reproduce
Steps to reproduce the behavior:

call a C# function with no parameters, it will be white.

Expected behavior
Should have color matching a function with parameters.
Screenshots

This is actually by design. I thought it would add unnecessary colors.

I would prefer empty braces to not be colored. IMO it makes the code too colorful without any benefit. Maybe add an option for this?


Fix Android preview initialization error

Fix for initialization error due to miss-match of SupportedPictureSizes and SupportedPreviewSizes.
On at least one device, the list of supported picture sizes and the list of supported preview sizes are wildly different. This leads to getOptimalPictureSize returning a resolution that is a supported picture size, but not necessarily a supported preview size.
The fix is simply to use the getSupportedPreviewSizes method to find candidates for resolution.

@lelandbatey This android implementation by me is pretty weak, if you have any other ideas how to make it better - send them here!


change timestamp format and fix unit tests for /clusters

Description
The timestamp format doesn't match other timestamp formats in our API. This PR fixes it so it is RFC3339 as others.
Also, some of the unit tests weren't working properly :face_with_head_bandage:
Fixes CCXDEV-6791
Type of change
Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
Unit tests (no changes in the code)

Testing steps
checked timestamp is RFC3339 + fixed unit tests
Checklist

[x] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report

Merging #833 (a851948) into master (d7dce94) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #833   +/-   ##
=======================================
  Coverage   56.95%   56.95%
=======================================
  Files          22       22
  Lines        2797     2797
=======================================
  Hits         1593     1593
  Misses       1023     1023
  Partials      181      181

Impacted Files
Coverage Δ

server/handlers_v2.go
58.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7dce94...a851948. Read the comment docs.


Spreadsheet for interesting reference content

Maybe we get a spreadsheet going of interesting reference content.
Originally posted by @mrmetaverse in https://github.com/AngellXR/metaversedev/discussions/17#discussioncomment-3171631

https://docs.google.com/spreadsheets/d/1vmx2E2pFOJWvMvFkrcg_HHGPUNHdj4SRiM-NTDHe4QE/edit?usp=sharing :heavy_check_mark:


Greenkeeper/@types/node 10.11.2

Coverage remained the same at 40.876% when pulling f9a9c1d54ac4b4bd1e0369ac59d1574fb66ab5e1 on<EMAIL_ADDRESS>into e8271fd29ead024bfca8aa0e2e35fd657f25e6f0 on master.


Add Android/ARM support

When I first added Android support, it was based on the x86 headers of Android API 9, with any definitions coming from architecture-dependent headers placed inside a version(X86) block, just in case.  For this pull, I checked each of those blocks for the three 32-bit platforms from Android API 9, X86, ARM, and MIPS32.  If they're all the same, the versioning was removed.  If any arch varied, the definition was put inside its own version(ARM) block.
I did not check the new 64-bit platforms added with the latest Android API 21.  This pull overlaps and obsoletes some of #764, which has not been updated in a while.
I need to add one last bit to core.stdc.errno, but cannot do so till a change to that module in my previous #1010 is merged first.  Once that's merged, I can add the last necessary bit for this pull to be done.

Thanks a lot.


Memory leak in ub_ctx (event_base will never be freed)

Hey,
the API method ub_ctx_create_event  combined with ub_ctx_delete leaks some memory (24 bytes).
This is because a new event_base will be allocated via ub_libevent_event_base, but never deallocated. Even if we call ub_ctx_delete.

Thanks for the heads up!  Added a check that when the event base is set via this method it frees the struct that is alloced.

This is only true for ub_libevent_event_base  in util/ub_event_pluggable.c.
The one in util/ub_event.c does not allocate memory but uses the passed in event_base.
So now I'm facing a use-after-free and most of the time event_dispatch() just returns.

Well this is really an major issue. It has been implemented falsely.
Lookup this part of code:
https://github.com/NLnetLabs/unbound/blob/1d45b4a1e085acba51e27d6e7d360322959aaceb/libunbound/libunbound.c#L220-L225
I'll create a PR in a few min which will fix this flaw

Hi Florian,
As far as I can tell libunbound always uses ub_event_pluggable.c, in which case this should not be an issue. That is assuming you build Unbound with the shipped Makefile. I see in the OpenBSD code that you are using your own Makefile which uses the ub_event.c, is that intentional?

I'm not sure, however, this is the knob in configure if I'm not mistaken:
--enable-event-api      Enable (experimental) pluggable event base
libunbound API installed to unbound-event.h
It says experimental...

unwind(8), which is the only consumer of libunbound in OpenBSD base, uses libevent so it felt natural to also stick to that.
I could investigate to switch to the plugable version if that's better / supported.

I switched unwind over to ub_event_pluggable,c and it seems to be working.
Needs a whee bit more testing though.
In any case, I don't have a strong opinion in which direction this should go.
I'd suggest to delete ub_event.c though if that's deprecated / should not be used.

I'm not sure, however, this is the knob in configure if I'm not mistaken:
--enable-event-api Enable (experimental) pluggable event base

I understand the confusion. I think we should remove the experimental part, especially since it is there already for 6 years. Note that the flag does not enable or disable the pluggable event base, it is about installing the header file. The ub_event_pluggable.c is always used for libunbound.

I'd suggest to delete ub_event.c though if that's deprecated / should not be used.

It is actually used when using Unbound in daemon mode, but not when using libunbound.

I switched unwind over to ub_event_pluggable,c and it seems to be working.

Yes, I think this is the right approach.

I'd suggest to delete ub_event.c though if that's deprecated /
should not be used.

It is actually used when using Unbound in daemon mode, but not when
using libunbound.

Are you sure? I see it being compiled, but not actually linked.
Anyway, my problem is solved :)


Publish artifacts on release branches

The CI was supposed to publish artifacts on the main branch and on release branches. However, I misread the documentation for the contains(search, item) expression. I expected that search is the value to search for, while item is the thing to search in. It is actually the other way around: search is the thing to search in, and item is what is searched for.
In addition, contains might not be explicit enough. So for safeguarding it may be better to use startsWith(searchString, searchValue). This function 'Returns true when searchString starts with searchValue'.
This problem should now be resolved.
We also need to backport this to v1.3 where the problem also exists. Before that release, there was no automated packaging and publishing of artifacts yet, so there is no need to backport it further down.

It's seems the backport workflow is skipped for this pull request, even though the workflow triggers on:
on:
  pull_request_target:
    types: [closed]
  issue_comment:
    types: [created]

Perhaps local pull requests don't trigger the pull_request_target:closed event when closed, but I'm a bit surprised by this. If anyone knows more, I'd love to understand this better. I guess I'm learning new things every day.
I'll trigger the backport manually then: /backport


UAR-1299 investigate remove signout validation issues

JIRA link
https://companieshouse.atlassian.net/browse/UAR-1299
Change description
Investigate (I have actually done fixes) why the validation fails on the sign-out page
Work checklist

[ ] Tests added where applicable
[ ] UI changes meet accessibility criteria

Merge instructions
We are committed to keeping commit history clean, consistent and linear.  A BREAKING CHANGE can be part of commits of any type,
types other than fix: and feat: are allowed, for example build:, chore:, ci:, docs:, style:, refactor:, perf:, test:, and others,
footers other than BREAKING CHANGE: <description> may be provided.

LGTM


Redux/redux-thunk must be npm-installed on the host app

@toranb thanks for putting this together, this is really awesome!
From my experience with using this addon, I had to npm install redux and redux-thunk for it to compile properly.
It appears that this is a known limitation with ember-browserify:
https://github.com/ef4/ember-browserify

To have the host app consume the npm dependency, ember-browserify and the npm dependency must be installed in the host app as well AND the module must be imported from within the app/ directory of the addon. So in your app, simply npm install ember-browserify and whatever npm dependencies you need consumed by ember-browserify.

It doesn't look like https://github.com/toranb/ember-redux-example/ includes redux or redux-thunk in it's package.json, so I'm curious about your experience with this.

@brettburley honestly I assumed having redux-thunk in the dependencies block of the package.json was enough. When I install this in any modern ember app I don't get any type of compile error with ember-cli.
What versions of ember-cli / ember / and ember-browserify are you using? If you use the versions you see below everything should be solid? Here are 2 examples worth looking at
ember-cli v2.4.2 and v2.4.3
ember-browserify v1.0.2
ember v2.4
https://github.com/toranb/ember-redux-ddau-example/blob/master/package.json
https://github.com/toranb/ember-redux-example/blob/master/package.json

Both of those repos failed for me locally (Max OS X). It appears to be a result of the latest ember-browserify v1.1.8. If I downgrade to v1.0.2 as suggested, it seems to work fine.
For reference, here's the error I get with v1.1.8:
The Broccoli Plugin: [object Object] failed with:
Error: Cannot find module 'redux' from '/Users/brettburley/Git/ember-redux-ddau-example/tmp/core_object-input_staging-zXLMsE6R.tmp'

I haven't investigated to see why ember-browserify seems to have regressed (although the behavior I'm seeing with v1.1.8 seems to be consistent with their documentation).

Huh so I just bumped both of those examples to ember-browserify v1.1.8 and they work w/out error
https://github.com/toranb/ember-redux-ddau-example/commit/d9f87e3882576c4ea4f72f5e8f57493563651947
https://github.com/toranb/ember-redux-example/commit/14873188339547cadb2320f2fe84ff4eb363e111
What version of node/npm are you using? I'm using node v5.6.0 and npm v3.6.0

Interesting... I think my "success" with v1.0.2 was a red herring because while it built successfully, it didn't actually include redux or redux-thunk in the build. It looks like ember-browserify >1.1 is required to work with ember-cli 2.x.
I was using node 0.12.4. Upgraded to v5.10.1, but am seeing the same error. I have npm 3.8.3.
$ ember --version
ember-cli: 2.4.3
node: 5.10.1
os: darwin x64

Tracing this a bit more, it does look like it will recursively look for a node_modules folder in every parent directory above the current project to resolve the package. Do you perhaps have a node_modules folder in one of the parent directories of ember-redux-ddau-example or ember-redux-example that might have redux and redux-thunk?

So I tried the install process on another MacBook and wouldn't you know it - busted without redux and redux-thunk in the main app ... That was using node v4.2.6 but it's enough to say we should update the install steps to include these both.
I'll likely need to support redux-thunk 1.0.x and 2.0.x

This is now correctly mentioned in the readme and v1.2.0 of ember-redux now supports both redux-thunk v1.x and v2.x


Yarn build results to broken or jumbled pages

Why does the pages result to broken or jumbled pages? But when a route navigation is clicked it suddenly fixes? Looking at console here is an error message that I cannot understand why:

We'll need more info on how to reproduce this issue. Please reopen with more details, thanks!


Status code 401 on /users/session API

Description:
For the first time, I inputed right password for user "ABC123" to ensure my code is right,
then I input wrong password few times to trigger this issue. (In some case right password also triggers this)
Detail:
Post with LibCURL
Code: https://github.com/GEEKiDoS/cso2-launcher/blob/modularizated/src/Plugins/Login/Auth.cpp#L177

The error should be 409 (session already exists) instead of 401 (bad credentials).
Be careful when exposing the user service to the internet, I didn't design it to be a public service.
If you do a GET /users you will get every user's information (including the hashed password)

The error should be 409 (session already exists) instead of 401 (bad credentials).
Be careful when exposing the user service to the internet, I didn't design it to be a public service.
If you do a GET /users you will get every user's information (including the hashed password)

That's not "session already exists", I have comfirmed there's no active sesstion in the service.

The error should be 409 (session already exists) instead of 401 (bad credentials).
Be careful when exposing the user service to the internet, I didn't design it to be a public service.
If you do a GET /users you will get every user's information (including the hashed password)

That's not "session already exists", I have comfirmed there's no active session in the service.
And the issue is 400 instead of the 401.
At the end of GIF, the service responsed 400 instead of 401.

I can't recreate this. I executed these steps:

Created a session with
curl --data "username=test&password=123" http://localhost:30100/users/session

It returned status code 201

Sent multiple create session requests with bad credentials with
curl --data "username=test&password=bad" http://localhost:30100/users/session

They returned status code 401
Maybe try sending the body as JSON? This is how I do it with cURL:
curl -X POST \     -H "Content-Type: application/json" \     -d '{"username":"test","password":"123"}' \     http://localhost:30100/users/session

The error should be 409 (session already exists) instead of 401 (bad credentials).
Be careful when exposing the user service to the internet, I didn't design it to be a public service.
If you do a GET /users you will get every user's information (including the hashed password)

That's not "session already exists", I have comfirmed there's no active session in the service.
And the issue is 400 instead of the 401.
At the end of GIF, the service responsed 400 instead of 401.

I can't recreate this. I executed these steps:

Created a session with
curl --data "username=test&password=123" http://localhost:30100/users/session

It returned status code 201

Sent multiple create session requests with bad credentials with
curl --data "username=test&password=bad" http://localhost:30100/users/session

They returned status code 401
Maybe try sending the body as JSON? This is how I do it with cURL:
curl -X POST \ -H "Content-Type: application/json" \ -d '{"username":"test","password":"123"}' \ http://localhost:30100/users/session

After few tests looks like using json fixed this issue.


chore(cargo): Update dependency

What this PR does 📖

Generate thumbnails for images internally rather than in uplink
Remove function generating thumbnail for image
Added small helper to generate base64 based on internal file type

Which issue(s) this PR fixes 🔨

N/A

Special notes for reviewers 🗒

Not every image will generate a thumbnail. At the time, only PNG, JPG/JPEG, GIF, ICO, BMP, and WEBP will be supported for generating a thumbnail
Clicking on an thumbnail in the file explorer will show the image/thumbnail at 500x500 (default, but configurable though recommend to leave it at this size or lower it down). A separate ticket may need to be opened to grab the image itself to display it in the modal rather than the thumbnail

Additional comments 🎤

Due to changes to File in warp, this will not be compatible with previous index (does not require new identity).
Should unblock #728

AI CODE REVIEW
General feedback:
The code changes seem to be focused on generating thumbnails for images internally instead of using the "uplink" functionality.
A function that generated thumbnails for images has been removed.
A small helper has been added to generate base64 data based on the internal file type.
The pull request does not mention any specific issues that it fixes.
Comments and considerations:
It is mentioned that only certain image formats (PNG, JPG/JPEG, GIF, ICO, BMP, and WEBP) will be supported for generating thumbnails.
Clicking on a thumbnail in the file explorer will display the image/thumbnail at 500x500 size, which is the default but can be configured.
There is a suggestion to open a separate ticket to display the full image in the modal instead of the thumbnail.
There is a note about compatibility issues with the previous index due to changes in the File module in Warp.
Overall, the changes seem to be aimed at improving thumbnail generation for images. It would be helpful to have access to the actual code changes in order to provide more specific feedback.

minor feedback above, all in macOS, m1

the jpg one didn't generated a thumb

Could you provide the jpg so I could check. Every jpg ive used produced a thumbnail

non image files shows this thumb

It should be showing up with its default images in uplink for anything that dont generate a thumbnail. I can double check that here shortly

gif shows a thumb but isn't animated

That is expected since its producing a thumbnail and clicking on the image only show the thumbnail itself and not the direct contents (referring back comment mentioning of wiring it to fetch the image for the preview)

ico file no thumb displayed

WEBP no thumb

Ill check the ICO (havent tested this yet, but assumed it will work) and try with more samples of webp. Only used one image but never tried any other so it might be related to how the library being used is detecting it up.

Making one minor change to add a function to determine thumbnail format than to depend on the file format itself


Generate enums in sorted order

This PR forces the order of the generated enums in alphabetically order. This is needed to have a predictable order of the enums across different python versions. Which reduces the pain for merging multiple enum additions.

Cool stuff! thanks


Prepare 0.2 release

Change log description
Prepare 0.2 release.

Codecov Report

Merging #258 (ada2d56) into master (32db12a) will decrease coverage by 0.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
- Coverage   77.93%   77.10%   -0.84%
==========================================
  Files          44       42       -2
  Lines       10367    10080     -287
==========================================
- Hits         8080     7772     -308
- Misses       2287     2308      +21

Impacted Files
Coverage Δ

src/lib.rs
100.00% <ø> (ø)

retry/src/retry_result.rs
57.14% <0.00%> (-28.58%)
:arrow_down:

shared/src/naming_utils.rs
73.33% <0.00%> (-23.04%)
:arrow_down:

retry/src/retry_async.rs
78.57% <0.00%> (-14.77%)
:arrow_down:

shared/src/lib.rs
78.43% <0.00%> (-8.82%)
:arrow_down:

retry/src/retry_policy.rs
92.30% <0.00%> (-7.70%)
:arrow_down:

retry/src/retry_sync.rs

retry/src/lib.rs

auth/src/lib.rs
90.42% <0.00%> (+9.78%)
:arrow_up:

@Tristan1900  could we add more logs/println! to the example
pravega-client-rust(master)$ cargo run --example event_write_and_read
This will ensure that the users realize the outcome of the steps performed in the example..


[ISSUE #1467] notify consumer when topic config change

What is the purpose of the change
notify consumer when topic config change in broker, work for issue 1467
Brief changelog
broker notify consumer after topic config change
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

@wqliang Could you list when this command will be triggered?

It will be triggered when create topic or update topic. Broker will trigger this notify when handling request code "UPDATE_AND_CREATE_TOPIC";
AdminBrokerProcessor.updateAndCreateTopic

Coverage increased (+0.03%) to 50.271% when pulling 291aac82a5f6711e165346b9b0a638cfeec16718 on wqliang:notifyTopicConfigChange-dev into 7c469fe949929ea039dfd8a6310db2f350ca316b on apache:develop.


Replace eth_account._utils with something non-internal

Overview
To be able to more safely handle the eth-account dependency, we should replace any usage of ._utils with something public or copy the code in to ape ourselves.
Right now, eth-account can change the methods / signatures / functionalities of everything in the _utils space ; they do not consider this a public API for the lib.
Specification
Create a similar, simpler functionality in ape by looking at what eth-account does
Dependencies
Include links to any open issues that must be resolved before this feature can be implemented.

I wish eth-account would open up these APIs...


Update WebAPI intro to RTM from RC2

Fixes #19782
https://review.docs.microsoft.com/en-us/aspnet/core/tutorials/first-web-api?view=aspnetcore-5.0&branch=pr-en-us-20664&tabs=visual-studio#add-nuget-packages

@wadepickett  please review this ASAP.

Do you still want it reviewed?  I just saw it now when you pinged me, sorry.  I gave a thumbs up to show I was starting but you merged.

Yes, please review the changes.

@wadepickett  next time you the approve radio please.

@Rick-Anderson, I had tried but  couldn't.   Once you merged I didn't have that option.

OK, thanks, didn't realize that.


Latest version of isort breaks import order linting

Issue Summary
isort version 4.3.5 has some breaking changes with regards to sorting imports: https://github.com/timothycrosley/isort/releases/tag/4.3.5
Steps to Reproduce
Run the flake8 linting tests without a version of isort that is pinned less than 4.3.5 and the tests will fail.
What were you expecting to happen?
The tests to pass
What actually happened?
checkqa installdeps: flake8 == 3.4.1, flake8-isort == 2.2.2, flake8-quotes == 0.11.0, Django < 2.2
checkqa develop-inst: /home/circleci/repo
checkqa installed: atomicwrites==1.3.0,attrs==19.1.0,certifi==2019.3.9,chardet==3.0.4,Django==2.1.8,django-appconf==1.0.3,django-ipware==2.1.0,flake8==3.4.1,flake8-isort==2.2.2,flake8-polyfill==1.0.2,flake8-quotes==0.11.0,idna==2.8,isort==4.3.17,jsonfield==2.0.2,mccabe==0.6.1,mock==2.0.0,more-itertools==7.0.0,pbr==5.1.3,-e git+git@github.com:pinax/pinax-stripe.git@d27a73f529708da73ccee3aa07c54b4a3dd3005a#egg=pinax_stripe,pluggy==0.9.0,py==1.8.0,pycodestyle==2.3.1,pyflakes==1.5.0,pytest==4.4.1,pytest-django==3.4.8,pytz==2019.1,requests==2.21.0,six==1.12.0,stripe==2.26.0,testfixtures==6.7.0,urllib3==1.24.2
checkqa run-test-pre: PYTHONHASHSEED='528838759'
checkqa run-test: commands[0] | flake8 pinax
pinax/stripe/__init__.py:2:1: I004 isort found an unexpected blank line in imports
pinax/stripe/tests/test_webhooks.py:13:1: I001 isort found an import in the wrong position
pinax/stripe/tests/test_webhooks.py:14:1: I001 isort found an import in the wrong position
pinax/stripe/tests/test_webhooks.py:15:1: I001 isort found an import in the wrong position
pinax/stripe/tests/test_webhooks.py:16:1: I001 isort found an import in the wrong position
pinax/stripe/tests/test_webhooks.py:17:1: I001 isort found an import in the wrong position
pinax/stripe/actions/customers.py:8:1: I001 isort found an import in the wrong position
pinax/stripe/actions/refunds.py:4:1: I001 isort found an import in the wrong position
pinax/stripe/actions/invoices.py:5:1: I001 isort found an import in the wrong position
ERROR: InvocationError for command /home/circleci/repo/.tox/checkqa/bin/flake8 pinax (exited with code 1)

Might be worth adding --diff to the check (to see what is expected to be different).
I guess that it is related to local packages?

Not seeing this after upgrading the CI


[ELY-1430] automated test for https://issues.jboss.org/browse/JBEAP-13656

Tests if the WARN message was logged during server shutdown when Elytron JACC is set.
Link to EAP JIRA issue: https://issues.jboss.org/browse/JBEAP-13656
Link to component JIRA issue: https://issues.jboss.org/browse/ELY-1430
EAP 7 PR: https://github.com/jbossas/jboss-eap7/pull/2567

Thanks for the PR, but we don't accept test that just check for the presence or absence of log messages.


Make the tool deterministic on the Ireland benchmark

Fixes #50
The culprit was iterating over Python sets. The iteration order is nondeterministic.

Whoops looks like I missed something. Let me look into this tomorrow

Ready for review now. :)

Well done! 🚀


Usage example for Property Bags (what problems do these solve; how to query them)?

Please expand on the obscure feature of Property Bags with indexers, or reference a page with explanation. It's not clear what in the world this would help us with, edge cases? or help us reduce head-aches? or what?
Thanks!
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 550a3c36-7f1d-efa7-3ed8-769720168da4
Version Independent ID: 627c4301-e00d-826e-d545-3a244305dec9
Content: Shadow and Indexer Properties - EF Core
Content Source: entity-framework/core/modeling/shadow-properties.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @AndriySvyryd
Microsoft Alias: avickers

Right now they are mainly used for the many-to-many join table. But they could also be useful as a DTO without having to declare a DTO class.


feat(ONYX-728): address design changes in alerts management section

The type of this PR is: Feat

This PR solves ONYX-728
Description

Address design changes in alerts management section

Before Web
After Web
Before mWeb
After mWeb

wondering if we should align Edit and View all buttons, and shift number of artworks to the right, so that numbers of different orders won't affect alignment:

let's ask Barney about this?


bug: vote count not working properly

Describe the bug
sometimes clicking on the upvote button doesn't update the status
sometimes clicking on the upvote button simply changes the color of the button, but not the number for the vote count.
sometimes the vote count is gray on the main page, but red in the /item page.
sometimes refreshing the page changes the vote state.
To Reproduce Steps to reproduce the behavior:
Click many times on the upvote button on the main page and on the /item page
It is difficult to give specific directions on how to reproduce the issue because the behavior is not consistent. Doing the same thing yields different results from time to time.
Hopefully you can easily see the same issue as I'm seeing now. Please let me know if you are not experiencing this same bug and I can try to isolate it better.

Do you still experience this ? It should be resolved in this https://github.com/denoland/saaskit/pull/217


[Bug]: Connection with Github got stuck and I can't Deploy new changes

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Once an App is connected to Github, if I return to that app several days after the successful connection and make some changes, the screen to Commit the changes got stuck and I can't commit and of course release the new changes, the only thing that works is to disconnect the app from Git.
Steps To Reproduce
I'm attaching a Loom video so you can see how to reproduce the error.
Thank you.
Public Sample App
No response
Issue video log
https://www.loom.com/share/ea45096dc1be48b8827b701b41c100cd
Version
Self Hosted / Appsmith Community v1.8.7

@ofsantana Apologies for the delayed response. Could you please share the logs from the machine where the Appsmith instance is running?

@ofsantana Are you still facing the issue? I will be closing the issue for the time and feel free to reopen the issue if you face the issue.


[BUG] OnlineGDB wrong link

Description
OnlineGDB supports html, css, js
But you are redirecting to the code editor of w3school tryit
You have already given separate card for tryit.
so, I am thinking that for OnlineGDB the link has been given wrong
correct link - https://www.onlinegdb.com/
Screenshots

Any additional information?
No response
What browser are you seeing the problem on?
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)
[X] I am a GSSoC'23 contributor

Hi @dev-AshishRanjan! :) Welcome to LinksHub! :) Just to confirm, are you participating in GSSOC'23?

Hi @dev-AshishRanjan! :) Welcome to LinksHub! :) Just to confirm, are you participating in GSSOC'23?

Yes I am GSSoC'23 contributor

Done @dev-AshishRanjan


Cherrypick of #3995 to 2.2.0: Add custom tempLocation support to BigQueryIO

#3995
R: @reuvenlax
CC: @azurezyq

lgtm


dump_syms

You say to use dump_syms, but this doesn't seem to work on macOS.
I get a message like "...so: file is neither a fat binary file nor a Mach-O object file"
I've read comments (e.g. https://groups.google.com/forum/#!topic/google-breakpad-discuss/XT8bh08JE4g) saying that to use dump_syms for an Android binary, would require dump_syms to be run on Linux. Can you please advise as to what macOS-based developers, or indeed Windows-based developers, are supposed to do?
Thanks, Pete

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5dbf28d0-dedf-3e44-7c5b-4d2a2ed22c02
Version Independent ID: 353d51d2-d428-c95d-2746-1d8b285a312d
Content: Android NDK - Visual Studio App Center
Content Source: docs/diagnostics/Android-NDK.md
Service: vs-appcenter
GitHub Login: @winnieli1208
Microsoft Alias: yuli1

Furthermore, is the intention that we're supposed to use https://github.com/microsoft/appcenter-sdk-android-breakpad instead?
If so, then that project has various build problems that need fixing (I've logged them there...)
Please advise!
Pete

Just to clarify further, I installed a Linux VM on my mac, pulled your code from GitHub; found it didn't build; had to patch it for Linux; then got it built; I was then able to use dump_syms on Linux from the VM to create the symbols.zip file ... not easy! :)

@jwargo Furthermore, is there any reason why appcenter CLI doesn't contain a simple comment to do all this automatically?
Create symbols.zip that covers all the so files in the distribution:
appcenter crashes make-ndk-symbols-zip

@sseyod I can't answer your question, but I'll ask the PM to respond. Isn't this similar to #609 ??

Apologies for the delay. Our engineering team is looking into our NDK support now. We'll get back to you shortly.
Thanks for your patience!

Hi @sseyod
I've responded to #609, pointing to https://github.com/jpeg-ms/breakpad-tools-appcenter
I hope this helps and we will keep looking into improving this.


Update exhibits code to work with OpenSearch

This is done.

Changing the title to reflect what I think we mean.


CI jobs failing after v0.7.10 images were published

Overview
After the v0.7.10 images were uploaded I began working on a new release for a different project. As part of a routine CHANGELOG PR the CI jobs began falling over:

linting
building

Example of a CI failure involving the ghcr.io/atc0005/go-ci:go-ci-stable-mirror-build image:
Run make all

fatal: detected dubious ownership in repository at '/__w/check-cert/check-cert'
To add an exception for this directory, call:

	git config --global --add safe.directory /__w/check-cert/check-cert
fatal: detected dubious ownership in repository at '/__w/check-cert/check-cert'
To add an exception for this directory, call:

	git config --global --add safe.directory /__w/check-cert/check-cert
Removing object files and cached files ...
Removing any existing release assets
Removing any existing quick build release assets
Removing any empty asset build paths
Building release assets for windows x86 ...
  running go generate for check_cert 386 binary ...
2023/02/10 12:51:54 failed resolving git tag: exit status 128
main.go:8: running "go-winres": exit status 1
  running go generate for lscert 386 binary ...
2023/02/10 12:51:54 failed resolving git tag: exit status 128
main.go:8: running "go-winres": exit status 1
  running go generate for certsum 386 binary ...
2023/02/10 12:51:54 failed resolving git tag: exit status 128
main.go:8: running "go-winres": exit status 1
make: *** [Makefile:253: windows-x86-build] Error 1
Error: Process completed with exit code 2.

Error: Process completed with exit code 1.

References

https://github.com/atc0005/check-cert/actions/runs/4143998031/jobs/7166617836
https://github.com/atc0005/check-cert/pull/499/checks
https://github.com/pulumi/ci-mgmt/issues/324
https://github.com/actions/runner-images/issues/6775
https://github.com/atc0005/shared-project-resources/pull/56
https://github.com/docker-library/golang/issues/448
https://github.com/docker-library/official-images/issues/12277#issuecomment-1105773842
https://confluence.atlassian.com/bbkb/git-command-returns-fatal-error-about-the-repository-being-owned-by-someone-else-1167744132.html
https://stackoverflow.com/questions/72978485/git-submodule-update-failed-with-fatal-detected-dubious-ownership-in-repositor
https://github.com/cloudtostreet/black-suggest/pull/3/files

This is a slightly older report, but may be relevant to what I'm seeing here:

https://github.com/actions/runner-images/issues/6775

The reporter used these commands to generate diffs of the images:

container-diff diff --type=apt IMAGE1 IMAGE2
container-diff diff --type=node IMAGE1 IMAGE2

I'll lookup how to obtain that tool and run the first command.

Digging around, the consensus is that it's related to recent Git updates.
The workarounds appear to be providing a "safe directory" for the checked out Git repos.
Oddly enough, the GHAWs are already doing this?

Error: Process completed with exit code 1.

This command is being run:

git config --global --add safe.directory /__w/check-cert/check-cert

and that is the path referenced by the earlier code checkout?

/__w/check-cert/check-cert

Explicitly downgraded the shared CI workflows from using the latest atc0005/go-ci images to the specific v0.7.9 release version to see whether that helps.

Explicitly downgraded the shared CI workflows from using the latest atc0005/go-ci images to the specific v0.7.9 release version to see whether that helps.

It did, but only after I asked for all jobs to be re-ran. Re-running just the failed jobs seemed to continue referencing the latest images.

$ docker container run -it --rm -v $PWD:$PWD -w $PWD ghcr.io/atc0005/go-ci:go-ci-stable-v0.7.9-0-gdf9564d3 git --version
git version 2.30.2
$ docker container run -it --rm -v $PWD:$PWD -w $PWD ghcr.io/atc0005/go-ci:go-ci-stable-v0.7.10-0-gcc0a2418 git --version
git version 2.30.2

The reporter used these commands to generate diffs of the images:

container-diff diff --type=apt IMAGE1 IMAGE2
container-diff diff --type=node IMAGE1 IMAGE2

I'll lookup how to obtain that tool and run the first command.

Installed the tool per directions on https://github.com/GoogleContainerTools/container-diff
$ container-diff diff --type=apt ghcr.io/atc0005/go-ci:go-ci-stable-v0.7.9-0-gdf9564d3 ghcr.io/atc0005/go-ci:go-ci-stable-v0.7.10-0-gcc0a2418

-----Apt-----

Packages found only in ghcr.io/atc0005/go-ci:go-ci-stable-v0.7.9-0-gdf9564d3: None

Packages found only in ghcr.io/atc0005/go-ci:go-ci-stable-v0.7.10-0-gcc0a2418: None

Version differences:
PACKAGE                 IMAGE1 (ghcr.io/atc0005/go-ci:go-ci-stable-v0.7.9-0-gdf9564d3)        IMAGE2 (ghcr.io/atc0005/go-ci:go-ci-stable-v0.7.10-0-gcc0a2418)
-curl                   7.74.0-1.3 deb11u3, 429K                                              7.74.0-1.3 deb11u5, 430K
-git                    1:2.30.2-1, 34.2M                                                     1:2.30.2-1 deb11u1, 34.3M
-git-man                1:2.30.2-1, 1.8M                                                      1:2.30.2-1 deb11u1, 1.8M
-libcurl3-gnutls        7.74.0-1.3 deb11u3, 735K                                              7.74.0-1.3 deb11u5, 736K
-libcurl4               7.74.0-1.3 deb11u3, 739K                                              7.74.0-1.3 deb11u5, 740K
-linux-libc-dev         5.10.158-2, 5.7M                                                      5.10.162-1, 5.7M

git package version diff:
-1:2.30.2-1
+1:2.30.2-1 deb11u1

root@7c4235dc9081:/home/ubuntu/Desktop# apt list -a git
Listing... Done
git/stable-security,now 1:2.30.2-1+deb11u1 amd64 [installed]
git/stable 1:2.30.2-1 amd64

root@7c4235dc9081:/home/ubuntu/Desktop# dpkg -l | grep git
ii  dash                       0.5.11+git20200708+dd9ef66-5   amd64        POSIX-compliant shell
ii  git                        1:2.30.2-1+deb11u1             amd64        fast, scalable, distributed revision control system
ii  git-man                    1:2.30.2-1+deb11u1             all          fast, scalable, distributed revision control system (manual pages)
ii  librtmp1:amd64             2.4+20151223.gitfa8646d.1-2+b2 amd64        toolkit for RTMP streams (shared library)

root@7c4235dc9081:/home/ubuntu/Desktop# apt-get install git=1:2.30.2-1
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Suggested packages:
  gettext-base git-daemon-run | git-daemon-sysvinit git-doc git-el git-email git-gui gitk gitweb git-cvs git-mediawiki git-svn
Recommended packages:
  patch less
The following packages will be DOWNGRADED:
  git
0 upgraded, 0 newly installed, 1 downgraded, 0 to remove and 2 not upgraded.
Need to get 5527 kB of archives.
After this operation, 22.5 kB disk space will be freed.

Downgrading is an option, at least for now.

Workarounds applied at the workflow level:

atc0005/shared-project-resources
atc0005/mysql2sqlite

about to apply this change shortly

Workarounds applied at the workflow level

This was done to avoid making a change directly at the image level that could impact other users.


Version 0.12 PR

Detailed changelog

Coverage decreased (-0.006%) to 98.106% when pulling 360cf01eb17b0537d6fb22409f8577d3cd8ea224 on next into 701dca65c1c924dd543a8b02a81b60b7d788b2c8 on master.


'joe ls' is now outputting incorrect and incomplete information

Now that data/ is under version control, the output of joe ls includes the .git file and neglects all of the .gitignore files within data/Global.
$ joe ls
.git, actionscript, ada, agda, android, appceleratortitanium, archlinuxpackages, autotools, c++, c, cakephp, cfwheels, chefcookbook, clojure, cmake, codeigniter, commonlisp, composer, concrete5, contributing.md, coq, craftcms, dart, delphi, dm, drupal, eagle, elisp, elixir, episerver, erlang, expressionengine, extjs, fancy, finale, forcedotcom, fortran, fuelphp, gcov, gitbook, go, gradle, grails, gwt, haskell, idris, igorpro, java, jboss, jekyll, joomla, jython, kohana, labview, laravel, leiningen, lemonstand, license, lilypond, lithium, lua, magento, maven, mercury, metaprogrammingsystem, meteor, nanoc, nim, node, objective-c, ocaml, opa, opencart, oracleforms, packer, perl, phalcon, playframework, plone, prestashop, processing, python, qooxdoo, qt, r, rails, readme.md, rhodesrhomobile, ros, ruby, rust, sass, scala, scons, scrivener, sdcc, seamgen, sketchup, stella, sugarcrm, swift, symfony, symphonycms, tex, textpattern, turbogears2, typo3, umbraco, unity, visualstudio, vvvv, waf, wordpress, xojo, yeoman, yii, zendframework, zephir

PR forthcoming

Prior to the switch to using git submodule, it didn't include the files within Global: https://github.com/karan/joe/tree/4e359896fdeee4168ca0ba522881f2eb055a7ddb/joe/data. I was about mention it. They can be easily added by just checking another folder for files.

Yeah I didn't include Global on purpose to keep it simple, and have enough time to think about how to structure the directory. Starting #9 to discuss this more.
@munrocape will wait for your PR. Thanks for taking this on.


Ensure proper usage of Guard helpers

ArgumentGuard is made to check only arguments, for internal state, we should use ApplicationStateGuard instead.

Force merging.


Remove version: Thunisoft.HuayuPY version <IP_ADDRESS>5

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://pinyin.thunisoft.com/webapi/v1/setup/downloadSetup?setupid=ccb74c06c7b248e49d37fd25e8d70727&filename=HuayuPY-V<IP_ADDRESS>5.exe
Response status code does not indicate success: 405 (Not Allowed).
(Automated message - build 656)


State undetermined

I know that a status key is sent as follows:
state: {       disabled: false       loaded: true       opened: false       selected: true }
But is it possible to include in the state the undetermined item?
would be like this:
state: {       disabled: false       loaded: true       opened: false       selected: true       undetermined : true }
I need to get the value if the parent is undetermined and save in database.
That's all I have.
 var jstree = [];
if ($('#jstree').find('.jstree-checkbox').length > 0) {
 jstree = $('#jstree').jstree(true).get_json('#', { 'flat': true });
 }

Undetermined is a visual state only and is calculated at runtime - it is never stored. But it is fairly easy to apply the results of: https://www.jstree.com/api/#/?q=get_un&f=get_undetermined([full]) to the array you get from get_json


issue with 7888 Series in India

Number +91<PHONE_NUMBER> is shown as invalid number.

Thank you for using libphonenumber!
Please upgrade to the latest release, this is not a live issue. To check the
latest behavior for yourself, see the demo* (instructions in our contribution
guidelines).
*http://libphonenumber.appspot.com/phonenumberparser?number=%2B91+7888048396&country=IN


Support authentication with client_secret

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


.has-validation doesn't work if both .invalid-feedback and .valid-feedback present in the .input-group

.has-validation doesn't work if both .invalid-feedback and .valid-feedback present in the .input-group

	<input type="text" name="firstname" class="form-control" minlength="2" maxlength="100" required autofocus>

Please enter a first name (minimum 2 characters)

Looking good

Expected: rounded corners of the .input-group , observed: right side is not rounded.

I check out the source code and find the reason:

Because the input in the issue you described is the last third child of input.has-validation,it has been applied @include border-end-radius(0);, the consequences are below:

In this case, the right side rounded corner disappear incorrectly
In this case, if you put only one input-group-text after the input, the right side rounded corner remains incorrectly.

        Input
        <input type="text" class="form-control" required>

            Bad!

Good!

        wwww.
        <input type="text" class="form-control" required>
        .com

here is the screenshot of the result:

I think the solution is to cancel the border-end-radius(0) section and use script to judge when the input element should eliminate the right side bounded corner( when contents show on its right side, feed-back element excluded! )

You can add rounded-end (rounded-right) class to the input to fix this case, but it probably should be fixed in a way that it just works without additional classes.

Since my control BsMultiSelect  is js-enabled (not pure css) I've just moved the messages out of input-group and manipulate them through JS.
You can go the same way and support pure css component  with the custom validation (not HTML vlaidation, means :input) .
I mean you could support such markup (for custom validation):

	<input type="text" name="firstname" class="form-control" minlength="2" maxlength="100" required autofocus>

Please enter a first name (minimum 2 characters)

Looking good

I am getting the same trouble but I think that validation feedback message should be out of the input group...
Or at least, use :last-of-type instead of :last-child

You can add rounded-end (rounded-right) class to the input to fix this case, but it probably should be fixed in a way that it just works without additional classes.

It would be good that  Bootstrap team listen us - there should be full functional css class system or (css variables) to "reconstruct" input field by parts.  '.form-control' is not enough. Check BsMultiSelect : https://dashboardcode.github.io/BsMultiSelect/ . There is fake input, but I can't without hardcoding to set the valid and invalid colors. What ruins SASS free "thems". Even 'disabled' styles should be hardcoded. There is only ':disabled' but not '.disabled' css.


10.0 lint for travis

Fixes this: https://travis-ci.com/it-projects-llc/website-addons/jobs/220454303

wonfix:
************* Module website_seo_url
website_seo_url/__init__.py:1: [E7988(manifest-name), ] Empty or too long module name. The name must be no more than 25 characters
website_seo_url/__init__.py:1: [E7991(manifest-image), ] Module's image is absent or it's not in images/ folder. Check attribute "images" in module's __manifest__.py
website_seo_url/__init__.py:1: [E7992(absent-index-html), ] File: static/description/index.html is absent in module. Contact Technical Writers for assistance
************* Module website_multi_company_demo
website_multi_company_demo/__init__.py:1: [E7988(manifest-name), ] Empty or too long module name. The name must be no more than 25 characters
website_multi_company_demo/__init__.py:1: [E7991(manifest-image), ] Module's image is absent or it's not in images/ folder. Check attribute "images" in module's __manifest__.py

I approve to merge it now