change close order during fork and exec

close vcpus, machine and them kvm fd in this specific order.

LGTM, but a bit unclear why/if it even maters

when close is called by userland code, resources associated with machine are freed. If a vcpu is running at this time it gets messed up.
KKM implements a refcount to handle out of order closes(vcpu and machine), but the path was never tested.
There is a memory access after free in that code about 10 instructions window.
Separate review is on kkm repo for that fix.


Add link to themer to themes section.

@viatsko I know the format of this suggestion doesn't follow the outline in contributing.md, but it's an auxiliary tool for creating themes rather than a theme found in the marketplace. I'm happy to change things around if you wish. Thanks for considering!

I'm not sure about this one. We have tools section which it will fit really well. What do you think?

Good idea! I didn't see that section before. I will move it there.

This looks great! Thanks


Add module names to function names

Needed to prevent name collisions since MATLAB doesn't support modules.

It seems like this is already done for functions generated from PureScript-land; if so we just need to be careful with Runtime function names


Make feed updating do much less work

I noticed that feed updating is frequently outright failing because it takes so long it exceeds the Cloud Function runtime limit, and it looked like it was easy to make it much more efficient, so I did that.
Previously, to update each category feed, it was loading all bets and comment data for every contract (likely 75) in the feed of every user in every batch of users (30). But even though the feeds were probably very similar -- they use lots of user-agnostic ranking data -- each user would independently query all the bet and comment data for all their contracts. Now, the batch queries bet and comment data once for the union of the contracts of all the user feeds in the batch, so that might be something not far off from a factor of 30 less queries.
I didn't measure it, but this is by far the majority of the database work done by this computation, so common sense would suggest that it may be the majority of the overall work, so I might expect this to speed up the whole thing by something like an order of magnitude.

By the way, if we moved this to a v2 function, it would have a much longer limit on how long it can run -- up to 60 minutes, IIRC -- but I guess there's no point doing that if we can just make it a billion times faster instead.

Gonna merge this sooner rather than later now that we think it might be costing hundreds of dollars per day.


name/chatname/tabname/servername mechanisms or commands

We currently have a mechanism to change a player's chat nickname, one to change the tab name, and one that does does all of them together, including the nameplate above a player's model (name mechanism) could we have 4 seperate and independent commands/mechanisms that does it's own thing only? Could prefixes and suffixes be used to increase the length of these values?

the dPlayer.name mechanism now only changes the nameplate without affecting the result of the <player.name> tag. woot! thank you morphan! perhaps you guys can rename that mechanism to dPlayer.nameplate?
all what's left now is to use prefixes and suffixes to triple the size of the nameplate!

on a sidenote, dPlayer.name currently also edits a plkayer's tab list name. since there already is a seperate mechanism for that (dPlayer.player_list_name), perhaps if it would be possible you guys could make the dPlayer.name only adjust the nameplate and not the tab list name

Uh... Is this still... Necessary for any reason?

i believe there is some incorrect stuff in the name mechanism description to what it actually does right now

i believe 'name' only changes their nameplate now?

Yup, and I just fixed that meta.. I'm gonna go ahead and close this


crash when killing with a bow

PocketMine-MP Crash Dump Wed Jan 17 14:20:52 UTC 2024
PocketMine-MP version: 5.10.0 [Protocol 630]
Git commit: daeba95101e6278d1f2552397043d29d29d272f8
PHP version: 8.1.26
OS: Linux, linux
A PLUGIN WAS INVOLVED IN THIS CRASH
BAD PLUGIN: MurderMysteryLED
Thread: Main
Error: Typed property pocketmine\network\mcpe\protocol\SetSpawnPositionPacket::$spawnPosition must not be accessed before initialization
File: pmsrc/vendor/pocketmine/bedrock-protocol/src/SetSpawnPositionPacket
Line: 66
Type: Error
Backtrace:
#0 pmsrc/vendor/pocketmine/bedrock-protocol/src/DataPacket(84): pocketmine\network\mcpe\protocol\SetSpawnPositionPacket->encodePayload(object pocketmine\network\mcpe\protocol\serializer\PacketSerializer#76261)
#1 pmsrc/src/network/mcpe/NetworkSession(502): pocketmine\network\mcpe\protocol\DataPacket->encode(object pocketmine\network\mcpe\protocol\serializer\PacketSerializer#76261)
#2 pmsrc/src/network/mcpe/NetworkSession(483): pocketmine\network\mcpe\NetworkSession::encodePacketTimed(object pocketmine\network\mcpe\protocol\serializer\PacketSerializer#76261, object pocketmine\network\mcpe\protocol\SetSpawnPositionPacket#68939)
#3 plugins/MurderMysteryLED-main/src/mm/game/Game(819): pocketmine\network\mcpe\NetworkSession->sendDataPacket(object pocketmine\network\mcpe\protocol\SetSpawnPositionPacket#68939)
#4 plugins/MurderMysteryLED-main/src/mm/game/Game(792): mm\game\Game->setSpawnPositionPacket(object pocketmine\player\Player#155796, object pocketmine\math\Vector3#67329)
#5 plugins/MurderMysteryLED-main/src/mm/game/Game(689): mm\game\Game->killPlayer(object pocketmine\player\Player#187131, string[33] ..eYou killed an innocent player!)
#6 plugins/MurderMysteryLED-main/src/mm/game/Game(711): mm\game\Game->playerKillPlayer(object pocketmine\player\Player#187131, object pocketmine\player\Player#155796)
#7 pmsrc/src/event/RegisteredListener(61): mm\game\Game->onDamage(object pocketmine\event\entity\EntityDamageByChildEntityEvent#88851)
#8 pmsrc/src/event/Event(63): pocketmine\event\RegisteredListener->callEvent(object pocketmine\event\entity\EntityDamageByChildEntityEvent#88851)
#9 pmsrc/src/entity/Entity(530): pocketmine\event\Event->call()
#10 pmsrc/src/entity/Living(548): pocketmine\entity\Entity->attack(object pocketmine\event\entity\EntityDamageByChildEntityEvent#88851)
#11 pmsrc/src/player/Player(2466): pocketmine\entity\Living->attack(object pocketmine\event\entity\EntityDamageByChildEntityEvent#88851)
#12 pmsrc/src/entity/projectile/Projectile(298): pocketmine\player\Player->attack(object pocketmine\event\entity\EntityDamageByChildEntityEvent#88851)
#13 pmsrc/src/entity/projectile/Arrow(149): pocketmine\entity\projectile\Projectile->onHitEntity(object pocketmine\player\Player#155796, object pocketmine\math\RayTraceResult#88891)
#14 pmsrc/src/entity/projectile/Projectile(240): pocketmine\entity\projectile\Arrow->onHitEntity(object pocketmine\player\Player#155796, object pocketmine\math\RayTraceResult#88891)
#15 pmsrc/src/entity/Entity(997): pocketmine\entity\projectile\Projectile->move(float 1.4092843909644, float -0.10378671435724, float -2.5466132656771)
#16 pmsrc/src/world/World(997): pocketmine\entity\Entity->onUpdate(int 5724)
#17 pmsrc/src/world/World(922): pocketmine\world\World->actuallyDoTick(int 5724)
#18 pmsrc/src/world/WorldManager(351): pocketmine\world\World->doTick(int 5724)
#19 pmsrc/src/Server(1805): pocketmine\world\WorldManager->tick(int 5724)
#20 pmsrc/src/Server(1687): pocketmine\Server->tick()
#21 pmsrc/src/Server(1065): pocketmine\Server->tickProcessor()
#22 pmsrc/src/PocketMine(341): pocketmine\Server->__construct(object pocketmine\thread\ThreadSafeClassLoader#6, object pocketmine\utils\MainLogger#3, string[16] /home/container/, string[24] /home/container/plugins/)
#23 pmsrc/src/PocketMine(364): pocketmine\server()
#24 pmsrc(11): require(string[60] phar:///home/container/PocketMine-MP.phar/src/PocketMine.php)
Code:
[57] 	protected function decodePayload(PacketSerializer $in) : void{
[58] 		$this->spawnType = $in->getVarInt();
[59] 		$this->spawnPosition = $in->getBlockPosition();
[60] 		$this->dimension = $in->getVarInt();
[61] 		$this->causingBlockPosition = $in->getBlockPosition();
[62] 	}
[63]
[64] 	protected function encodePayload(PacketSerializer $out) : void{
[65] 		$out->putVarInt($this->spawnType);
[66] 		$out->putBlockPosition($this->spawnPosition);
[67] 		$out->putVarInt($this->dimension);
[68] 		$out->putBlockPosition($this->causingBlockPosition);
[69] 	}
[70]
[71] 	public function handle(PacketHandlerInterface $handler) : bool{
[72] 		return $handler->handleSetSpawnPosition($this);
[73] 	}
[74] }
===END CRASH DUMP===

well ive tested myself and havent got this issue before but ill check up on it

and also collecting gold does nothing, i even set it to 5 and collected 15 but nothing happened

yep i know that, currently im paying attention to fixing throwable sword, but yeah im working on fix both of the issues right now.

ok so its happening cuz theres something wrong with compass directions basically that part of the code is to locate where the bow is for compass or players, right now i feel like using some other method to ill keep that feature on hold for know.
but ill soon like tomorrow or in a few days will do it. gold im working on a fix right now.

bro btw the fix for the gold is just simply getEntity() instead of getOrigin because the event extends EntityEvent, tho i know i might be too late


Document refactoring

Coverage remained the same at 53.313% when pulling 4beb5699308d515b96263f4528d4d62e53b81cbb on squirrelsc:doc_fix into fda440f3fe01a8226e12f530869eb266e7cbdfac on microsoft:master.

Coverage remained the same at 53.313% when pulling 4beb5699308d515b96263f4528d4d62e53b81cbb on squirrelsc:doc_fix into fda440f3fe01a8226e12f530869eb266e7cbdfac on microsoft:master.


Make the material system physically correct

Currently, the material system is not quite physically correct. Take for instance the diffuse material:
bool lambertianBSDF(struct hitRecord *isect, struct color *attenuation, struct lightRay *scattered, sampler *sampler) {
      struct vector scatterDir = vecNormalize(vecAdd(isect->surfaceNormal, randomOnUnitSphere(sampler))); //Randomized scatter direction
      *scattered = ((struct lightRay){isect->hitPoint, scatterDir, rayTypeScattered});
      *attenuation = diffuseColor(isect);
      return true;
  }

The rendering equation is:

The Lambertian BSDF is:

Thus, if you want your MC estimator to be correct, you need to sample a direction  according to some pdf  and use it to evaluate the BSDF, then multiply that by the cosine and incoming light, and divide by that pdf. You then get the correct MC estimator:

In the case of the Lambertian BSDF, that would give:

Note that the incoming light  is computed by pathTrace so that's already taken care of. In the current version of the code, the division by , the multiplication by the cosine, and the division by the sampling pdf are completely missing, though, and that's the case for every material in the framework. There are cases where you can avoid multiplying by the cosine, namely:

if the BSDF already contains a division by the cosine (which is the case for perfect mirrors, or perfect glass),
if the pdf used to sample contains the cosine, in which case the division by the pdf cancels the multiplication by the cosine.

As far as I can see, the diffuse BSDF that you have doesn't fall into that category (it is not using cosine-weighted hemisphere sampling). Thus, I think it is not physically correct.
If you want references on the topic, I can recommend PBRT. It's not perfect, but it gets the points across. For a reference on the formulas, there's the very good GI compendium. If you want to discuss this further, I am on Discord and can get in touch if you're interested. Alternatively, if you think it's fine to leave this not physically correct, that's an option too, although I would not suggest to do that as solving visual bugs such as fireflies and the like will get harder.

Currently, the material system is not quite physically correct.

You are absolutely right. In the past my priority has been what looks 'good enough', often with a rather lax definition of 'good enough'. It is about time we start putting an emphasis on physical correctness, so it's great that you pointed this out!
It's doubly-awkward that the material system is flawed when literally the first thing the README says is:

C-ray is a research oriented, physically accurate rendering engine built for learning.

Oops! 😅
The current set of materials, and in fact the entire material system has been inadequate for quite a while now. So a rework of these materials could be combined with an effort to improve the material system as a whole, perhaps with a simple node-based approach.

If you want references on the topic, I can recommend PBRT.

I actually own a physical copy! But as you can probably tell, I haven't put it to good use yet.
And yes, I would very much love to talk on Discord! You can find me at vkoskiv#3100 there.


Unusual address formatting

Addresses are being returned from Get with the town and/or district included in the line_1 field.
Example 1:

Suggestion

Id = ZmQwMTdjNWIxMWUyYTE2IEd1X182NTI2NTgyfFNwcmluZ2ZpZWxkLS0tUHJpbWFyeS0tLVNjaG9vbC0tLUJyb29tc3ByaW5nLS0tTGFuZS0tLVNoZWZmaWVsZCA5ZjYzYTQ1Y2UzNDY4ZGI=
Address = Springfield Primary School Broomspring Lane Sheffield, Eyre Street, Sheffield, South Yorkshire
Url = /get/ZmQwMTdjNWIxMWUyYTE2IEd1X182NTI2NTgyfFNwcmluZ2ZpZWxkLS0tUHJpbWFyeS0tLVNjaG9vbC0tLUJyb29tc3ByaW5nLS0tTGFuZS0tLVNoZWZmaWVsZCA5ZjYzYTQ1Y2UzNDY4ZGI=

Result Json, I would not expect Sheffield to come out on line_1 and I would expect Springfield Primary School and Broomspring Lane on separate lines (Interestingly, it is also marked as residential?)

{"postcode":"S1 4QY","latitude":53.3767,"longitude":-1.4711,"formatted_address":["Springfield Primary School Broomspring Lane Sheffield","Eyre Street","","Sheffield","South Yorkshire"],"thoroughfare":"Eyre Street","building_name":"","sub_building_name":"","sub_building_number":"","building_number":"","line_1":"Springfield Primary School Broomspring Lane Sheffield","line_2":"Eyre Street","line_3":"","line_4":"","locality":"","town_or_city":"Sheffield","county":"South Yorkshire","district":"Sheffield","country":"England","residential":true}

Hi, please use<EMAIL_ADDRESS>


Verification failure with chef-sugar on fresh chef-dk 0.16.28

Description
Verification failure with chef-sugar on fresh chef-dk 0.16.28
ChefDK Version
Chef Development Kit Version: 0.16.28
chef-client version: 12.12.15
delivery version: master (921828facad8a8bbbd767368bfc72f19bd30e7bd)
berks version: 4.3.5
kitchen version: 1.10.2
Platform Version
System Software Overview:
  System Version: OS X 10.11.6 (15G31)
  Kernel Version: Darwin 15.6.0'

Replication Case

install chef-dk
run chef-verify

Stacktrace
Running verification for component 'chef-sugar'
.........
F

Failures:

  1) example::default When all attributes are default, on an unspecified platform converges successfully
     Failure/Error: expect { chef_run }.to_not raise_error

       expected no Exception, got #<Net::HTTPFatalError: 504 "Gateway Timeout"> with backtrace:
         # ./spec/unit/recipes/default_spec.rb:13:in `block (3 levels) in <top (required)>'
         # ./spec/unit/recipes/default_spec.rb:17:in `block (4 levels) in <top (required)>'
         # ./spec/unit/recipes/default_spec.rb:17:in `block (3 levels) in <top (required)>'
     # ./spec/unit/recipes/default_spec.rb:17:in `block (3 levels) in <top (required)>'

Finished in 2.04 seconds (files took 1.96 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./spec/unit/recipes/default_spec.rb:16 # example::default When all attributes are default, on an unspecified platform converges successfully

I apologize for the noise. I should not have opened this.


Add missing Dread runes

I missed one of the things I need to change I think, the material can't be set on items despite appearing in the menu.

Is the material part of the rune?


F* crashes on ill-types effect annotations

The following program causes F* exit in the interactive mode, note the incorrect effect annotation on the test function, if I make it right, things work as expected.
module Test

type repr (a:Type) (_:unit) = ℤ → a & ℤ

let return (a:Type) (x:a) : repr a () = λ n → x, n

let bind (a:Type) (b:Type) (f:repr a ()) (g:a → repr b ()) : repr b () =
  λ n →
  let x, n1 = f n in
  (g x) n1

let subcomp (a:Type) (f:repr a ()) : repr a () = f

let if_then_else (a:Type) (f:repr a ()) (g:repr a ()) (p:Type0) : Type = repr a ()

reifiable reflectable
layered_effect {
  MSTATE : a:Type → unit → Effect
  with
  repr = repr;
  return = return;
  bind = bind;
  subcomp = subcomp;
  if_then_else = if_then_else
}

let lift_pure_mstate (a:Type) (wp:pure_wp a) (f:unit → PURE a wp)
: PURE (repr a ()) (λ p → wp (λ _ → ⊤) ∧ (∀ x. p x))
= λ n → f (), n

sub_effect PURE ↝ MSTATE = lift_pure_mstate

let read () : MSTATE ℤ () = MSTATE?.reflect (λ n → n, n)

let write (n:ℤ) : MSTATE unit () = MSTATE?.reflect (λ _ → (), n)

let test () : MSTATE unit =
  let n = 3 in
  write n

Fixed as part of #1861


Pipeline fails if there is no new data in delta folder

Hi,
In a scenario where there are a lot of tables to be exported having syncrhonization in BC and Pipelines in Synapse scheduled at regular interval can happen that for some tables there will be no new records, that means no new delta.
With the current version the Pipelines fail.

Error Messages:
Operation on target FailIfEntityNotFound failed: Entity with name Customer-18 was found in the deltas.manifest.cdm.json but no directory with that name was found in businesscentralgb/deltas/. This may be the case if no new deltas have been exported.
Operation on target FailIfEntityNotFound failed: Entity with name LSCStore-99001470 was found in the deltas.manifest.cdm.json but no directory with that name was found in businesscentralgb/deltas/. This may be the case if no new deltas have been exported.
Operation on target FailIfEntityNotFound failed: Entity with name GLAccount-15 was found in the deltas.manifest.cdm.json but no directory with that name was found in businesscentralgb/deltas/. This may be the case if no new deltas have been exported.
Operation on target For each entity failed: Activity failed because an inner activity failed; Inner activity name: ConsolidateNewDeltas, Error: Operation on target FailIfEntityNotFound failed: Entity with name GLAccount-15 was found in the deltas.manifest.cdm.json but no directory with that name was found in businesscentralgb/deltas/. This may be the case if no new deltas have been exported.
In my opinion the system should not return a failure but rather an info or warning.
Thank you
Eclipses

Hi @eclipses,
The Fail activity performs two functions:

It ensures that the pipeline does not fail silently, when no deltas are found. In some scenarios, such as the one you mentioned where no changes took place, this is okay, but in others, it may not.
More importantly, however, it ensures that the pipeline exits prematurely if no deltas exist (meaning that it does not need to be run for that entity). If you were to simply remove the Fail activity, the surrounding condition activity would still succeed, and the pipeline would continue to be executed. This will lead to unnecessary dataflow executions, which greatly increases cost. We could circumvent this issue by adding the following activities into the "True" block of the condition activity. However, since the pipeline contains another condition activity later, we cannot do that (we cannot nest activities like that). The way around this would be to move all activities to the right of the "Entity found" condition into a new pipeline and invoke that pipeline from the "True" block of the condition, which also adds another level of complexity.

For this reason, we have elected to leave it as is for the moment. With this information, you are of course free to modify the pipeline as you see fit.
On the other hand, consider monitoring the activities from the Synapse pipeline runs, where you could filter better on the actual error message and ignore those that point to an deltas being absent, if you so wish.
Best regards,
The bc2adls team.

Hi @DuttaSoumya,
An error in my opinion is misleading as in reality the process/pipeline is not failing as there is not delta to be processed.
The error is not handling properly this case.
I think you could move everything is at the right of the red point to a new IF Condition activity and process only when you have delta files.
Please let me know if it make sense to you
Kind Regards
Eclipses


Reconfigure options must be with_indifferent_access

Reconfigure options provided by the API should be made with_indifferent_access to work with the providers.
See https://github.com/ManageIQ/manageiq-api/issues/260
Without this fix, all reconfigure attempts using the API (add and remove disk) will fail.

@evertmulder Looks good 👍
Could you add test cases to show input options in either string or symbol would work? Thanks.

The issue happened when backend methods use option keys in symbols while user passes the options in string format via API.
Suggested fix is applied when data is retrieved from DB.
Wondering if it is better to fix in API when data is collected and going to be stored in to the DB.
@abellotti @jntullo Any idea?

@lfu the API can symbolize the keys before calling the method if that works better for you

@jntullo Can we have the same data format as how they are collected via UI?
This is the data saved via UI task.
---
:src_ids:
- '7000000000029'
:vm_memory: 1024
:disk_add:
- !ruby/hash:ActiveSupport::HashWithIndifferentAccess
  disk_size_in_mb: '1'
  persistent: true
  thin_provisioned: true
  new_controller_type: VirtualLsiLogicController
  dependent: true
  bootable: false
:request_type: :vm_reconfigure

@lfu Before creating a test we have to agree on the best solution right?

Playing around with the API, it is a quick fix to deep symbolize the keys. The format would then be:
{
  :src_ids=>["10000000002203"],
  :request_type=>"vm_reconfigure",
  :disk_add=>[
    {:disk_size_in_mb=>"20",
     :persistent=>true,
     :thin_provisioned=>false,
     :dependent=>true,
     :bootable=>false
     }
]}

Does that look correct @lfu @evertmulder?

@evertmulder Fix in API code seems better to me.

@evertmulder Do we need to keep this PR open now that PR https://github.com/ManageIQ/manageiq-api/pull/312 is merged?

No, ManageIQ/manageiq-api#312 is a better sollution. I will close this PR. Thanks!


bug: title tooltip of custom plugin is in i tag

the tooltip texts of built-in plugins are outside the i tag:

but that of custom plugins are inside the i tag, which made they show up italic font-style:

The issue is not reproduced.
Did you put the button type as below?
{
    // plugin's name attribute
    name: 'custom_plugin_submenu',
    // name of the plugin to be recognized by the toolbar.
    // It must be the same as the name attribute of the plugin
    dataCommand: 'custom_plugin_submenu',
    // The class name of the button to add
    // ** If you want to enable it even in code view mode, add a "code-view-enabled" class **
    buttonClass:'',
    // HTML title attribute
    title:'Custom plugin of the submenu',
    // 'submenu' or 'dialog' or '' (command button)
    dataDisplay:'submenu',
    // HTML to be append to button
    innerHTML:'<i class="se-icon-add"></i>'
}


Migrate from rails to ruby Dockerfile

I rule and have completed some work on Case Manager that's ready for review!
Sooooo this switches the Dockerfile from rails (deprecated) to ruby, also switches to using alpine from debian, and trims down ruby quite a bit. End result is the image is half the previous size, should run faster, etc... This PR would supercede #720 #722 and #723
Testing looked ok to me, someone with much more knowledge of the ecosystem should definitely examine since it's an OS change, etc...
This pull request makes the following changes:

Switches to ruby:3.2.1-alpine for base image
Rejumbling of packages installed
Switches to using a dcaf user ( consistent with #722 )
Adds an expose for port 3000
Adds dockerignore file

It relates to the following issue #s:

Fixes #721

Current coverage is 98.81% (diff: 100%)

Merging #724 into master will not change coverage

@@             master       #724   diff @@
==========================================
  Files            28         28
  Lines           589        589
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            582        582
  Misses            7          7
  Partials          0          0

Powered by Codecov. Last update e8a3eca...92b76f0

Test failures on all of the commits, but they seem unrelated ¯_(ツ)_/¯

Yeah, the test failures are 100% unrelated -- we have a couple scrub tests.
Here's my output from docker-compose run web after doing docker-compose build -- looks like it chokes on a tzinfo error. @DarthHater can you replicate or is this just my machine acting weird?
$ docker-compose run web
Array values in the parameter to `Gem.paths=` are deprecated.
Please use a String or nil.
An Array ({"GEM_PATH"=>["/usr/local/bundle"]}) was passed in from bin/rails:3:in `load'
=> Booting WEBrick
=> Rails <IP_ADDRESS> application starting in development on http://<IP_ADDRESS>:3000
=> Run `rails server -h` for more startup options
=> Ctrl-C to shutdown server
Exiting
/usr/local/bundle/gems/tzinfo-1.2.2/lib/tzinfo/data_source.rb:182:in `rescue in create_default_data_source': No source of timezone data could be found. (TZInfo::DataSourceNotFound)
Please refer to http://tzinfo.github.io/datasourcenotfound for help resolving this error.
# ... big ol' stack trace

Appears to be very straightforwardly resolvable by adding the tzinfo-data gem to the gemfile though. I'll spin that up now.

It did not, @colinxfleming , I'm on OS X so maybe there's something native that can use (but that seems odd too). I can add this I think as an APK package if you want.

Actually, I can't add it. For some reason there isn't a ruby-tzinfo package for Alpine 3.4 yet. Gem install probably best for now!


Unification: Ruuvi logo

Description:
Please use new Ruuvi logo everywhere in the app (without the eye or banner)

1.5.43

In app all good, just want to remind about the Play Store screenshots whoever will replace those.

It should be different task in my opinion. This one for example: https://github.com/ruuvi/com.ruuvi.station/issues/498


Support for SQL DB, Synapse SQL-POOL or SQL Managed Instance ?

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Problem
The resource type SQL DB, Synapse SQL-POOL or SQL Managed instance is not supoported
Desired Solution
being able to use the resource types: SQL DB, Synapse SQL-POOL or SQL Managed instance
Alternatives and Workarounds

Additional Context

Duplicate of #5308


How do you measure compression quality?

Hi!
What is your loss function and what metric do you use to evaluate quality of decompressed images?
Thank you,
Anton.

Hello Anton,
Mean Squared Error is used to compute the reconstruction error between the output and original image. https://github.com/alexandru-dinu/cae/blob/f0f60f768c78cf1d182c6778df6cad6d69712634/src/train.py#L57-L58
Currently, there is no other measure of quality. An in-depth evaluation and report is needed.
It has been on my to-do list for quite some time now, but unfortunately did not get the chance to write it.
If you have any suggestions, please let me know. Also, feel free to submit pull requests.
Thank you,
Alex


Builders on elements.

It's tedious constructing a message, for example. The tests are littered with a bunch of default values for everything.

Fixed by #81.


[FEATURE REQUEST] Choose which apps to upgrade automatically

Please confirm these before moving forward

[X] I have searched for my feature proposal and not found a work-in-progress/duplicate/resolved/discarded issue.
[X] This proposal is a completely new feature. If you want to suggest an improvement or an enhancement, please use this template

Describe the new feature
I believe this feature would be very helpful to have, as having all programs update automatically is not wished in every use case.
It could be something like a favorites list.
Describe how this new feature could help users.
Users could create a list of their "favorite" apps to have updated all the time, while other apps which tends to have problematic installations or hash mismatches etc could be excluded from automatic upgrades.

possibly duplicate of https://github.com/marticliment/WingetUI/issues/1383

Actually yes, duplicate #1383


Fixed "unless" test condition for ppa repository

After the repository is added, the ${::apt::sources_list_d}/${sources_list_d_filename} file is created as an empty file.The unless condition of Exec["add-apt-repository-${name}"] calls test -s, which returns 1 if the file is empty. Because the file is empty, the unless condition is never true and the repository is added on every execution. This commit replaces the -s test condition with -f, which is true if the file exists or false otherwise.

Thanks for the fix!
This breaks a number of tests as we check that we get the full command, including what used to be the -s switch. Please check the spec/ directory and update the tests accordingly. We can't merge it otherwise.

As requested, the last commit fixes the broken tests.

@bmjen @tphoney Could someone take a look at why the Beaker tests fail? Looking at them it's not related to this PR.
@nicobn Could you squash your commits into one so we get one single commit that fixes the bug and adjusts the tests?

@nicobn @daenney one of the errors was a transient issue. I will look further into the other issue.


python3Packages.PyChromecast: 7.7.1 -> 7.7.2

Motivation for this change
Update to latest upstream release 7.7.2
Change log: https://github.com/home-assistant-libs/pychromecast/releases/tag/7.7.2
The upstream project doesn't have any test. Disabled.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108754 run on x86_64-darwin 1

1 package marked as broken and skipped:

gnomecast

5 packages built:

catt
mkchromecast
python37Packages.PyChromecast
python38Packages.PyChromecast
python39Packages.PyChromecast

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108754 run on x86_64-darwin 1

1 package marked as broken and skipped:

gnomecast

5 packages built:

catt
mkchromecast
python37Packages.PyChromecast
python38Packages.PyChromecast
python39Packages.PyChromecast

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108754 run on x86_64-linux 1

6 packages built:

catt
gnomecast
mkchromecast
python37Packages.PyChromecast
python38Packages.PyChromecast
python39Packages.PyChromecast

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:
gnomecast:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108754 run on x86_64-linux 1

6 packages built:

catt
gnomecast
mkchromecast
python37Packages.PyChromecast
python38Packages.PyChromecast
python39Packages.PyChromecast

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:
gnomecast:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.


Add new Mastercard range

Start from Oct 2016 Mastercard is introducing a new range of numbers with the following first 6 digits range,<PHONE_NUMBER>99
please add it up

Thanks. Source?

@PawelDecowski since we work heavily in the industry it was a direct request by several psp's.
but you can see articles here:

I'm looking for the same update. We've currently implemented a work around until this has been updated.

looking for same update as well.  thanks

I too am in need of this.  I found a decent reference on the topic:
https://www.mastercard.us/en-us/issuers/get-support/2-series-bin-expansion.html
While they don't seem state it clearly on that page, the linked PDFs all state in the opening sentence:

MasterCard is rolling out an additional range of six-digit BINs<PHONE_NUMBER>99).

For the moment I've manually updated my javascript, but I would prefer not to deviate from the published version.  I stole the regex learnt from here, and stripped out all the extra [0-9] criteria since they seem redundant, leaving this complete Mastercard regex:
pattern: /^(5[1-5]|222[1-9]|22[3-9]|2[3-6]|27[01]|2720)/,
Works with the only test card number I have (2221 0000 0000 0009).  Haven't found an online site to generate test numbers in the new range yet.

I've received an email from a rep and for the time being implemented ianleeder's patch above. There is an implementation deadline of 30 Sep 2016 so am hoping to update from main branch once an official update is released... Thanks!
Dear Merchant
As a step to increasing the supply of BINs, MasterCard is in the process of issuing cards within BIN range from 222100 to 272099. This will be in addition to the existing BIN range from 510000 to 559999.
Prior to issuing the new 2 series BIN cards MasterCard is working with all the participants to ensure that the entire eco-system can recognize and process cards issued in the new BIN range just as they process the existing 5 series BINs 510000 to 559999.
In this context the E-commerce space requires some additional work due to the unique aspects of processing, such as the role of payment service providers, 3-D secure validation and gateways.
The purpose of this note is to make sure that you, as a participant in the E-com space, are aware of the introduction of MasterCard branded cards issued with the new 2 series BINs.
If you are a

 Merchant hosting your own payment page, or

 Payment facilitator providing any payment page / hosting services to any merchants, or

 Software provider to merchants who have their own payment page, or

 M-POS payment facilitator or aggregator, or

 Play any role in the transaction processing cycle

and
if any of the following have any validation routine based on the card number prior to sending the transaction onward either to the gateway or for 3-D secure validation

 Merchant’s own payment page

 Payment page hosted by you in your capacity as a payment service provider

 Loyalty/promotion related software where rewards are linked to the brand of the card

 Any other routine in the processing sequence that validates based on card number before sending the transaction to the next stage

then you will have to make all the necessary changes to your software and databases to make sure that cards issued in the new 2 BIN range from 222100 to 272099 pass seamlessly through the filters and checks, just as the cards issued with the existing 5 series BINs 510000 to 559999 do.
The above are examples of scenarios that definitely require work to be done to achieve 2 series BIN acceptance. You may like to review all parts of your system to identify other areas that may require work to achieve the same objective.
It is critical that all of these changes are executed and tested prior to 30 September 2016.
We would appreciate if you could carry out an assessment of your systems in this regard, and send us an email to confirm one of the following:

 You have reviewed all the elements in your systems and processes which may be impacted by this new BIN range 222100 to 272099 and confirm that system can handle them without the need for any software or database changes, or

 Your systems, database or software do require changes, and indicate the date by which you will be able to complete all the required changes, test and confirm to us that your systems are 2 Series BIN ready. When the necessary changes have been completed and tested please send us an email to confirm completion.

Thanks in advance for your help to implement this critical project.

Thanks, guys. This will be included in the next version, to be released in September.

Hi, I made this regexp for the new BIN range. Could you please check if is valid?
(2221[0-9]{2}|222[2-9][0-9]{2}|22[3-9][0-9]{3}|2[3-6][0-9]{4}|27[0-1][0-9]{3}|2720[0-9]{2})

Hi Paweł, I've made a PR before I found the above conversation. Anyway, thanks and looking forward to the next ver.

Had trouble catching all cases with the examples above. This worked for the needed ranges:
^5$|^5[1-5][0-9]{0,14}$|^2[2]?[2]?$|^2221[0-9]{0,12}$|^222[3-9][0-9]{0,12}$|^22[3-9][0-9]{0,13}$|^2[3-6][0-9]{0,14}$|^2[7]?$|^27[2]?$|^27[0-1][0-9]{0,12}$|^2720[0-9]{0,12}$

@PawelDecowski could you provide some update on this please?

@akhilgoyal I’ll do my best to finish it tonight.

Hi @PawelDecowski thanks for this. Any updates?

v1.1 will be released tonight.

Thanks @PawelDecowski for this much appreciated


Veredict breaks with Zeitwerk

👋 Hello! First of all, thanks for this awesome gem, we are currently using it in production and we are very happy with it.
We have an issue when updating to Rails 6 and using Zeitwerk (using latest gem version).
We have an experiment in the following folder: components/public/app/ab_tests/public/remove_confirmation_email_ab_test.rb and configured `Veredict.
We also have configured verdict to read from that directory:
Verdict.directory = Rails.root.join('components', 'public', 'app', 'ab_tests', 'public').
But when loading the application in production (I bet because of eager loading) it raises the following error:
expected file /app-test/components/public/app/ab_tests/public/remove_confirmation_email_ab_test.rb to define constant Public::RemoveConfirmationEmailAbTest, but didn't (Zeitwerk::NameError)

I've seen the railtie and the change introduced in https://github.com/Shopify/verdict/pull/61/files but I honestly don't understand what would be the best way to work around the error.
The file defines an experiment as follows:
unless Verdict.repository.has_key?('remove_confirmation_email_ab_test')
  Public::Experiments::BaseExperiment.define 'remove_confirmation_email_ab_test' do
    # ...
  end
end

Thanks in advance,
Pau

Hi there,
I work with @masylum at Factorial and I'm posting this here in case someone stumbles upon this issue, to explain what we were doing wrong and how we fixed it
What were we doing wrong?
We were setting this in our initializer:
Verdict.directory = Rails.root.join('components', 'public', 'app', 'ab_tests', 'public')

without taking into account that said initializer(since it named "verdict.rb") is loaded after the one defined in the railtie https://github.com/Shopify/verdict/blob/master/lib/verdict/railtie.rb#L2 and therefore we were overriding the directory config setting but not telling zeitwerk to ignore it with Rails.autoloaders.main.ignore(Verdict.directory)
How did we fix it?
Making sure that our initializer is either executed after the one defined in the verdict railtie or adding the Rails.autoloaders.main.ignore(Verdict.directory) line to it
Cheers and thanks for developing and supporting this lib!

Thanks @enriclluelles


Update default.coins.json

This json file is not used anymore, all our supported coins list is on our backend now.


Code Style

Description

[ ] The code style of Rust
[ ] The code style of Shell
[ ] The code style of Python
[ ] The code style of JavaScript
[ ] The code style of Solidity

Additional Information
#395

:+1:

https://github.com/cryptape/cita/wiki/Style-Guide


U2F Timeout in Chrome 72+

Describe the bug
Ledger has announced an incompatibility issue that appear in Chrome 72+. Using transport-u2f results in U2F TIMEOUT.
Their recommendations at this moment are:

When U2F is used, migrate to other browsers not affected by the bug.
Switch to webusb. They will provide more information about this in the next few days.

It is likely that it will be necessary to switch to webusb.
We need to:

Analyse the implications of switching
Probably modify the ledger js library to use webusb instead. Most likely, the API will remain stable so Voyager should not be affected.

Ledger will apply a fix in their SDK that should resolve the issue without changes in Voyager.
Apps memory requirements have changed so I have submitted a PR at their request that includes this change.
Also we are submitting v1.1.0 that includes bech32 address explorer.
https://github.com/LedgerHQ/ledger-app-cosmos/pull/3

I have removed the webusb mention as it seems the fix will not require this.

Is this actually a problem? Didn't hear complaints so far.

Referencing related issues here to facilitate tracking:
https://github.com/LedgerHQ/ledgerjs/issues/306
https://bugs.chromium.org/p/chromium/issues/detail?id=935131
It seems that Chrome has fixed the problem, but Ledger still keeps the issue open.

Closing as this apparently is no bug.


Nameserver RouteInfoManager logic can be simplified.

a lot of code logic relate to find target brokerName in queueData list.
this can be replaced by add a mapping from brokerName to queueData.

@RongtongJin

@RongtongJin can you take a look？

Good catch! I will review the pr ASAP


Broken netcat on Darwin since recent changes

The improvements made in a55b7d7 and a57721d1 breaks compilation of netcat.c on Darwin. No SOCK_CLOEXEC. Not sure if the fix in https://github.com/ArduPilot/ardupilot/issues/8592 would do the trick?

Hmmm, happy to break it up but I need a way to signal to xsocket() that it should call the fcntl.
The easy thing seems to be to #define SOCK_CLOEXEC in portability.h and then either move xsocket() to portability.c and have an apple version, or add a check if it's the new constant (something like SOCK_CLOEXEC == 0xc0000000 which sets the top two bits and thus should never be used as a real value, and the test drop out as a compile time constant comparison on other platforms) and do the fcntl then.
Unfortunately either way requires #defining SOCK_CLOEXEC for the callers, and I can't look at the apple headers to see what's a safe value to define it to because proprietary, but I'm guessing they're the same as freebsd?

In this case, they're highly modified versions derived from OpenBSD.
Here's how libressl handles it:
https://github.com/libressl-portable/portable/tree/master/apps/nc/compat

(patch sent to list.)

@landley --- i can confirm this is fixed by b8be71f842333bf5ebfed6ee70626b1870d2a7d0.

Yay.


🔧 Enable Coverage dynamic context to see the function that called a test

🔧 Enable Coverage dynamic context to see the function that called a test

pytest-cov doesn't play well with dynamic_context = "test_function"


MDL in Google Apps Script does not scroll on iOS 9.3.1

I have used successfully the MDL framework in a web application implemented throught the Google Apps Script environment. It works well through chrome on desktop and android. When accessing the application through safari on iOS 9.3.1, there is an issue: the content does not scroll. The same web app worked well on an older version of iOS.
Here is the code illustrating the issue, using demo code from getmdl.io
Code.gs :
function doGet(e) {
  var template = HtmlService.createTemplateFromFile('Index');
  return template.evaluate()
      .addMetaTag('viewport', 'width=device-width, initial-scale=1')
      .setSandboxMode(HtmlService.SandboxMode.IFRAME);
}

Index.html :
<!DOCTYPE html>

    <link rel="stylesheet" href="https://code.getmdl.io/1.1.3/material.indigo-pink.min.css">
    <link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons">

          Title

 Main page - text that should scroll
 		 <? for (var i=0 ; i < 25; i++) { ?>
Item <?=i ?>
   <? } ?>

You can try this published version of the code above.
When executing the web app in chrome on a desktop or android, you can scroll the main content up and down.
When executing it from Safari on iOS 9.3.1 device (iPhone 5, iPad), the main content does not scroll.
If you deploy the index.html in a standard environment (see example in codepen) it works well on iOS 9.3.1   I therefore conclude the issue has to do with the combination of MDL in Google Apps Script environment.
Using MDL framework within Google Apps Script helps build simple, beautiful web applications.... if this issue can be fixed.

Please use StackOverflow for support and integration assistance. This tracker is only for problems with the code provided by Material Design Lite.
Thank you.


Feature Suggestion: Support 5/10/5 rule for templates

The way templates are implemented in Foundry does not match the DnD5e 5/10/5 distance rules. Would be great if the module would also offer an option to convert templates using the 5/10/5 distance rules.

That's basically what the standard foundry template do is it not?

That's basically what the standard foundry template do is it not?

Unfortunately not, here some examples:

Unfortunately not, here some examples:

I agree about the cones (but that's just angle not range,  and the sphere one seems accurate (not the red line version)

I agree about the cones (but that's just angle not range,  and the sphere one seems accurate (not the red line version)

You can see here how you can get to this square with 20ft of movement using 5/10/5

You can see here how you can get to this square with 20ft of movement using 5/10/5

Regarding the circle - the point of origin is a square corner. If I start counting from the actual point of origin reaching the top left corner of the squares results in a distance of 25 feet.

Regarding the circle - the point of origin is a square corner. If I start counting from the actual point of origin reaching the top left corner of the squares results in a distance of 25 feet.

How? It's still 20ft

How? It's still 20ft

But tokens can't occupy grid corners, with your method it only takes 15ft of movement to leave the area no matter where you are, it actually makes these less effective

But tokens can't occupy grid corners, with your method it only takes 15ft of movement to leave the area no matter where you are, it actually makes these less effective

Hm, that's actually a good Point, didn't consider this - thanks for the clarification :-)
Still, cones are somewhat problematic.

Hm, that's actually a good Point, didn't consider this - thanks for the clarification :-)
Still, cones are somewhat problematic.

I would use the standard cones from 5e helpers, I find those are pretty much correct

I would use the standard cones from 5e helpers, I find those are pretty much correct

The 5/10/5 rule is actually harder to adjust templates for due to the quantization error between grid squares vs linear distance. And increasing the cone angle on diagonals will drastically overshoot the proper number of covered squares (cones are as long as they are wide at any point).
Thank you for the concern, but this one is a wont-fix. Happy gaming.

The 5/10/5 rule is actually harder to adjust templates for due to the quantization error between grid squares vs linear distance. And increasing the cone angle on diagonals will drastically overshoot the proper number of covered squares (cones are as long as they are wide at any point).
Thank you for the concern, but this one is a wont-fix. Happy gaming.


Cropper crashes after selecting a picture and transitioning to crop view. - Android 9 (Pie)

No Error message is given but the app crashes in the transition and returns to the screen it was on before the image-cropper is initiated.
`profilePicture?.setOnClickListener {
Log.d("CreateProfileFrag","Open picture selection")
        //crop image to circle
        if (context != null) {
            CropImage.activity()
                    .setGuidelines(CropImageView.Guidelines.ON)
                    .setCropShape(CropImageView.CropShape.OVAL)
                    .start(activity!!)
        }
    }`

The cropper continues to work on lower versions of android. <=8 (Oreo)

#553 #558 I think you might experience this issue. It is still not resolved

Any update guys? I am also facing the same issue in Android Pie. If you know any workaround, then please let me know.

This can be resolved by the following changes in CropOverlayView
canvas.clipPath(mPath, Region.Op.XOR); //Deprecated
//https://developer.android.com/reference/android/graphics/Canvas#clipPath(android.graphics.Path,%20android.graphics.Region.Op)
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
    canvas.clipOutPath(mPath);
} else {
    canvas.clipPath(mPath, Region.Op.INTERSECT);
}

I hope this will be fixed soon

Its not working

This can be resolved by the following changes in CropOverlayView
canvas.clipPath(mPath, Region.Op.XOR); //Deprecated
//https://developer.android.com/reference/android/graphics/Canvas#clipPath(android.graphics.Path,%20android.graphics.Region.Op)
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
    canvas.clipOutPath(mPath);
} else {
    canvas.clipPath(mPath, Region.Op.INTERSECT);
}

Its not working

Facing same issue and waiting for new release with fixes.

Facing the same problem but no answers found yet

Full fix here:
On CropOverlayView, search and change two following places:
Place 1:
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {                     canvas.clipOutPath(mPath);                     canvas.clipOutRect(rect);                 } else {                     canvas.clipPath(mPath, Region.Op.INTERSECT);                     canvas.clipRect(rect, Region.Op.XOR);                 }
Place 2:
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {                 canvas.clipOutPath(mPath);             } else {                 canvas.clipPath(mPath, Region.Op.XOR);             }
At the moment, I had to download zip file to local and import to my project, and fix it myself. Hope admin will fix it as soon as possible.

I am encountering the same issue.  I hope this will be fixed soon. Will try VuHongKy's solution otherwise.


CEF needs an automatic update script

I just filed a pull request to update our version of CEF to fix a crash in OBS. The previous version was released on 2019-07-27— that's almost 2 years! For a piece of software that's functionally a web browser, we certainly shouldn't be using an out-of-date version: web browsers have a massive attack surface and it's very important to keep them updated at all times. I don't have the time to work on this right at the moment, but it shouldn't be too difficult. There's a JSON file containing metadata for every CEF release. All that should be necessary is to grab the latest stable version for the right platform. While we're at it, we could also consider building for i686 and AArch64.
Tagging @puffnfresh, the maintainer

IDK how it works, but it sounds like a job for the @ryantm bot (https://github.com/ryantm/nixpkgs-update).


Hyperparameter settings and cold start value head

Hello everyone, I am currently using PPOTrainer for training, and some of the hyperparameter settings are making me very confused. I've noticed different terms like batch/minibatch/microbatch. The document doesn't provide detailed explanation so I read some previous PR discussion. It seems that in PPOConfig:
batch is the granularity loaded by the dataloader and doesn't seem to play a significant role internally in PPOTrainer.
minibatch is the actual granularity of execution, equivalent to what is discussed as microbatch.
minibatch * gradient_accumulation_steps is the granularity for gradient updates, equivalent to what is discussed as minibatch.
So, if my goal is to achieve a smoother learning curve while keeping memory usage in check, would it be sufficient to increase gradient_accumulation_steps and maintain the sizes of minibatch and batch the same?
Additionally, I've noticed that ValueHead is a cold start layer. I've read the original PPO paper, and there is no mention of pretraining this head. Currently, I am using PPO for code generation training, and due to the task's high sensitivity, I observe that training is struggling to converge and eventually explodes. Would pretraining the Value head help alleviate this issue?
Thanks in advance for any helpful comments~~~

Yes, your understanding of the batches is correct! Note that at some point you'll have only very few updates per rollout if you increase grad_acc so you might want to also update the batch size of the dataloader.
Indeed, the ValueHead is randomly initialized but I am not sure how you would pretrain it since it's related to the RL loop and the reward function?

Yes, your understanding of the batches is correct! Note that at some point you'll have only very few updates per rollout if you increase grad_acc so you might want to also update the batch size of the dataloader.

Cool, thank you for this confirmation!

Indeed, the ValueHead is randomly initialized but I am not sure how you would pretrain it since it's related to the RL loop and the reward function?

Maybe I should use the word 'warmup' instead of 'pertrained', just freeze the parameter of the pretrained_model by set requires_grad=False and run PPO training for a few epochs, so that the value head can be trained without influence the pretrained_model.

If you can run some experiments to show that it makes a difference we are happy to consider adding it to the library as an option!


[Request] Princess Arthur (PSP)

Hello ^_^
I'd like to request a script for Princess Arthur (PSP), please~

1 Request

Due to the PSVita port becoming playable with the Vita3K emulator, gonna edit this post ^^


Phone Validator

Just found out about this lib since I am trying to reduce my app bundle size. One nice feature would be to implement a light weight version of Yup Phone (https://www.npmjs.com/package/yup-phone) once done this lib will meet all my needs!

hi there, I'll see what I can do
I'll attempt to add a phone validator that can monkey-patch the library, so its fully optional and not included in the bundle by default (phone validator libs can't really be that small...)
In the meantime, you can try using https://www.npmjs.com/package/libphonenumber-js together with Nope.string().test()

Thanks @bvego tha would be awesome if you could come up with a super light weight version of this validator, the problem with libphonenumber-js is that it expect a country code and I do not want to restrict my validation to a specific country.


Enable S3 offsite backups for CDN-logs

Don't merge this before I've done testing elsewhere please :)


Complation error in golang.org/x/sys/unix/syscall_unix.go

Hi.
I recently updated the dependencies of my GopherJS project and found that it no longer compiles on compile.jsgo.io.
The following link reproduces the problem: https://compile.jsgo.io/johanbrandhorst/grpcweb-example.
The error is:
gopath/src/github.com/johanbrandhorst/grpcweb-example/vendor/golang.org/x/sys/unix/syscall_unix.go:153:38: undeclared name: _Socklen

Yes, it works locally with
$ gopherjs version
GopherJS 1.10-2

Actually I'm an idiot, I chose the wrong directory to compile. This will attempt to compile my server :man_facepalming:. Sorry!


Replaced WebL10n with i18next in Markdown activity

fix issue #1378
Replaced Code in MarkDown Activity to l10n
@llaske  , could you please review it

Could you avoid to change file formatting.
Only updated lines must be changed in files. It's important for maintenance reason.
I guess it's coming from your editor settings.

Sure @llaske

I have tried to make the changes as much as possible @llaske please review it

@llaske Resolved all the indentations mentioned


Use MultiheadAttention instead of MAB

One outstanding issue from #187 was that we are currently using a self-implemented MAB module. Torch provides a MultiheadAttention module built-in that can probably be used instead.

Hi @dereklhansen just wanted to check if you think this is still worth doing? (perhaps whenever you start working again on the FNP module)


Improve AU UI to not require direct/instance access

Not sure if possible..

implemented in develop branch


EPIC: Spawn should have a Prod env

[x] https://github.com/rollchains/spawn/pull/105
[x] https://github.com/rollchains/spawn/pull/107
[x] https://github.com/rollchains/spawn/pull/109

completed


Publish container workflow fails when Dependabot merges

When a pull request is merged to main, a workflow is run to publish the package to ghcr.io. But, if that pull request was merged by @dependabot then this workflow fails.
During the step Login to the container registry, the following is logged:
Run docker/login-action@v2
with:
    registry: ghcr.io
    username: korthout
    ecr: auto
    logout: true
  env:
    REGISTRY: ghcr.io
    GHCR_USER: korthout
    JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.6-10/x6[4](https://github.com/korthout/camunda-platform-rest-api/actions/runs/4263903410/jobs/7421242143#step:5:4)
    JAVA_HOME_17_X[6](https://github.com/korthout/camunda-platform-rest-api/actions/runs/4263903410/jobs/7421242143#step:5:6)4: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/1[7](https://github.com/korthout/camunda-platform-rest-api/actions/runs/4263903410/jobs/7421242143#step:5:7).0.6-[10](https://github.com/korthout/camunda-platform-rest-api/actions/runs/4263903410/jobs/7421242143#step:5:10)/x64
Error: Username and password required

This does not happen when I merge the pull request.

Failed pull request
Successful pull request

This may also block #12


How to check syntax from abap code

How to check syntax from abap code were i have include in separated file?.
i use new SyntaxLogic(reg, obj).run().issues
and added to my object files with include code but i have error ... "data types not detected " or "form definition not found".
i also use default configuration.

run the command line or https://github.com/marketplace/abaplint to check code

i have error

the config file is passed on command line to the executable, not the abap code itself
if not supplying any configuration it will use the default, see https://playground.abaplint.org
the default abaplint configuration will check the abap files in the /src/ folder, like abapGit defaults commiting files to the same folder


Confusing UX for Enable all extension

Type: Bug

In extensions view, search @builtin python
See list of python extensions that I had previously disabled
I now want to enable all of them so I selected enable all extensions from the extensions view ... menu

Bug
This ends up enabling all of my installed extensions, not just the visible ones
I could not find a way to enable multiple extensions at a time in the extensions view
VS Code version: Code - Insiders 1.85.0-insider (Universal) (f346494c77e1245505e53a2ddcab3bfb4ee52e08, 2023-11-09T05:36:20.154Z)
OS version: Darwin arm64 23.1.0
Modes:

System Info

Item
Value

CPUs
Apple M2 Max (12 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
9, 6, 4

Memory (System)
64.00GB (5.46GB free)

Process Argv
--crash-reporter-id 0fffb5da-9cd7-46fd-9e7f-a1564e8c5fda

Screen Reader
no

VM
0%

/duplicate
Enable all extensions - As name says it enables all extensions. This is a request for multi-selection.

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Need a database model for inventory

As a developer
I need a place to persist inventory information
So that inventory information can be accessed from different sessions.
Details and Assumptions

Need to decide what database to use and create a data model
An inventory item will have a name, product_id, quantity, restock_level and item_condition value associated with it

Acceptance Criteria
Given a new piece of inventory information
When I want to save the information
Then I have a database to store it.

We are using PostgreSQL database


Failed to start redis-server on wsl boot

Version
Microsoft Windows [版本 10.0.19043.1288]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
5.10.16
Distro Version
Ubuntu 18.04
Other Software
redis版本
Redis server v=6.2.4 sha=00000000:0 malloc=libc bits=64 build=31bab94b7c80a0cb

Repro Steps
step 1
C:\ProgramData\Microsoft\Windows\Start Menu\Programs\StartUp 加入 vbs脚本
step2:
vbs脚本内容如下
Set ws = WScript.CreateObject("WScript.Shell")
ws.run "wsl sudo /etc/init.wsl start", vbhide

step3
在wsl的/etc目录，新建init.wsl文件
step4
init.wsl内容如下
/usr/local/redis/start_redis_cluster.sh

step5
start_redis_cluster.sh内容
#!/bin/sh
redis-server /usr/local/redis/conf/redis-6373.conf
redis-server /usr/local/redis/conf/redis-6374.conf
redis-server /usr/local/redis/conf/redis-6375.conf
redis-server /usr/local/redis/conf/redis-6376.conf
redis-server /usr/local/redis/conf/redis-6377.conf
redis-server /usr/local/redis/conf/redis-6378.conf

Expected Behavior
result

重启windows无法随机启动redis server
进入wsl控制台，手动执行start_redis_cluster.sh可以启动redis-server
不知道为什么不能随机启动，求助

Actual Behavior
开机进程没有redis-server
Diagnostic Logs
没有日志

Hi, this issue is hard for me to understand as it is written in Chinese, a language that I don't speak. I ran it through a translator to help and I think I understand your issue.
You would like to start the redis server automatically on start up of your Windows machine. You can do this use Task Scheduler in Windows like this community video shows.
If this doesn't solve you please mention me in this issue so I can see it. Thank you!


[MM-45426] - Able to manually downgrade from Enterprise to Starter

Summary
The pricing modal could be opened from the console using /admin_console/billing/subscription?action=show_pricing_modal. Opening it this way exposed a bug where users are able to Downgrade from Enterprise plans that are not trialing.
Ticket Link
https://mattermost.atlassian.net/browse/MM-45426
Release Note
NONE

/update-branch

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/221641


Aggregation with EntityStream calls two requests

When calling the aggregation functions through the EntityStream, first a 10,000 row search is performed, and then a second query with the aggregation. The "close" method from a Stream is a terminal operation, it calls stream. We haven't to ctually close an EntityStream if we need an aggregation because it's just an object that will be garbage collected.

Hi @justTimTim!
Can you show me some example about how you building an Aggregation queries with Redis OM Spring library please?
I tried to find some examples and information, but I don't found nothing :/


Save vector_search history for downstream monitoring of model performance

Adding just a few details we discussed on our call:

vector_search table columns come from the vector_search function: query, query_parameters, top_k, model_id, splitter_id, uuid, output, metadata
uuid is the hash of all other columns


Fix size in tests

fixes #2759
I'm not sure why we need to add 5 bytes to the size though...

@lhoestq do you have an idea of why we need to add 5 bytes? Is it insignificant, or should we dig a bit to understand what is happening?

it's insignificant


BREAKING CHANGE: make AMISelectorTerms required

Fixes #N/A
Description
Makes the AMISelectorTerms required. @jmdeal is taking this over.
How was this change tested?
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

34 of 51 (66.67%)  changed or added relevant lines in 4 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.2%) to 81.781%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/providers/amifamily/ami.go
14
16
87.5%

pkg/apis/v1beta1/ec2nodeclass_validation.go
8
13
61.54%

pkg/apis/v1beta1/zz_generated.deepcopy.go
5
15
33.33%

Files with Coverage Reduction
New Missed Lines
%

pkg/apis/v1beta1/ec2nodeclass_validation.go
1
67.74%

pkg/providers/amifamily/custom.go
3
66.67%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
5409

Relevant Lines:
6614

💛  - Coveralls


Aimbot is kinda different

Hi. I know it's weird but I use mouse1 for pistol aimbot (cuz I play legit with low FOV) so basically whenever I press mouse1 the aimbot hit the target and that's enough for me (I don't hold the aimbot key to lock on target like most people do).
However, after your last update I realize that the new aimbot (2nd image) doesn't work as good as the old one (1st image). When I press mouse1 the new aimbot sometimes doesn't respond instantly. Sometimes I press 6 times and only 1 time the aimbot works. In the old version of Osiris the aimbot works perfectly everytime I press mouse1.
I don't know about C++ so I don't know why you change the aimbot but I think the old DLL is better :)

And also please don't change the interface of aimbot so often (like the aimbot button). I have 15 different configs and everytime you change the aimbot interface I have to adjust my config because the aimbot button of the old config is no longer accepted...

And also please don't change the interface of aimbot so often (like the aimbot button). I have 15 different configs and everytime you change the aimbot interface I have to adjust my config because the aimbot button of the old config is no longer accepted...

disable on key, aimbot in general works only if you are shooting (providing that you don't toggle aimlock)
on the current aimbot, for pistols I set fov to 1.5 or below and smooth 1 (no between shots, no on key) and it's prettey good for deagle headshots (not 100% legit, so I use it situationally)
for rifles fov 3 and smoothness 10 or more, and add the autostop feature if your movement is not so good

disable on key, aimbot in general works only if you are shooting (providing that you don't toggle aimlock)
on the current aimbot, for pistols I set fov to 1.5 or below and smooth 1 (no between shots, no on key) and it's prettey good for deagle headshots (not 100% legit, so I use it situationally)
for rifles fov 3 and smoothness 10 or more, and add the autostop feature if your movement is not so good

disable on key, aimbot in general works only if you are shooting (providing that you don't toggle aimlock)
on the current aimbot, for pistols I set fov to 1.5 or below and smooth 1 (no between shots, no on key) and it's prettey good for deagle headshots (not 100% legit, so I use it situationally)
for rifles fov 3 and smoothness 10 or more, and add the autostop feature if your movement is not so good

Yeah I know. The problem is that with the old DLL of Osiris Deagle 1.5 FOV + smooth 1 hits perfectly while with the new DLL Deagle 1.5 FOV + smooth 1 sometimes doesn't hit.

disable on key, aimbot in general works only if you are shooting (providing that you don't toggle aimlock)
on the current aimbot, for pistols I set fov to 1.5 or below and smooth 1 (no between shots, no on key) and it's prettey good for deagle headshots (not 100% legit, so I use it situationally)
for rifles fov 3 and smoothness 10 or more, and add the autostop feature if your movement is not so good

Yeah I know. The problem is that with the old DLL of Osiris Deagle 1.5 FOV + smooth 1 hits perfectly while with the new DLL Deagle 1.5 FOV + smooth 1 sometimes doesn't hit.

Yeah I know. The problem is that with the old DLL of Osiris Deagle 1.5 FOV + smooth 1 hits perfectly while with the new DLL Deagle 1.5 FOV + smooth 1 sometimes doesn't hit.

If you really want the old version, check the commit history of "aimbot.cpp" down to the date of your dll file, then take that old "aimbot.cpp" and "paste" it to the current version (of course you want to check variables names or config structure changes).

Yeah I know. The problem is that with the old DLL of Osiris Deagle 1.5 FOV + smooth 1 hits perfectly while with the new DLL Deagle 1.5 FOV + smooth 1 sometimes doesn't hit.

If you really want the old version, check the commit history of "aimbot.cpp" down to the date of your dll file, then take that old "aimbot.cpp" and "paste" it to the current version (of course you want to check variables names or config structure changes).

for rifles fov 3 and smoothness 10 or more, and add the autostop feature if your movement is not so good
Tbh i wouldnt advise to use that if you're trying to play legit... FOV 3 and smoothness 10 is extremly blatant, everybody who is at least decent at the game will call you out...

for rifles fov 3 and smoothness 10 or more, and add the autostop feature if your movement is not so good
Tbh i wouldnt advise to use that if you're trying to play legit... FOV 3 and smoothness 10 is extremly blatant, everybody who is at least decent at the game will call you out...

for rifles fov 3 and smoothness 10 or more, and add the autostop feature if your movement is not so good

Tbh i wouldnt advise to use that if you're trying to play legit... FOV 3 and smoothness 10 is extremly blatant, everybody who is at least decent at the game will call you out...
yes you are correct, in the last few days I became used to maximum FOV of 1.5 and nearest bone,
I think this won't look fishy if you have good positioning and crosshair placement

for rifles fov 3 and smoothness 10 or more, and add the autostop feature if your movement is not so good

Tbh i wouldnt advise to use that if you're trying to play legit... FOV 3 and smoothness 10 is extremly blatant, everybody who is at least decent at the game will call you out...
yes you are correct, in the last few days I became used to maximum FOV of 1.5 and nearest bone,
I think this won't look fishy if you have good positioning and crosshair placement


Fix vertical overflow inside info panel

Content inside the info panel can be cut off because part of the info panel is outside of the viewport. This should be fixed.

https://github.com/voorhoede/demo-viewer/blob/split-styles-into-modules/src/modules/info-panel/info-panel.css#L5 in PR #14 would resolve this issue.

Note: not resolved by #21


Add colima to arkade get

Expected Behaviour

arkade get colima installs lima
Link to the project: https://github.com/abiosoft/colima/blob/main/docs/INSTALL.md
Are you a GitHub Sponsor yet (Yes/No?)

[ ] Yes
[x] No

Possible Solution

Add colima to pkg/get/tools.go
Context

I use colima pretty often to use as a replacement for docker and spin up Kubernetes
If requesting a CLI for "arkade get"
687
Your Environment

What Kubernetes distribution are you using?

Client Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.0", GitCommit:"4ce5a8954017644c5420bae81d72b09b735c21f0", GitTreeState:"clean", BuildDate:"2022-05-03T13:36:49Z", GoVersion:"go1.18.1", Compiler:"gc", Platform:"darwin/arm64"}
Kustomize Version: v4.5.4
Server Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.6+k3s1", GitCommit:"418c3fa858b69b12b9cefbcff0526f666a6236b9", GitTreeState:"clean", BuildDate:"2022-04-28T22:16:58Z", GoVersion:"go1.17.5", Compiler:"gc", Platform:"linux/arm64"}

Operating System and version (e.g. Linux, Windows, MacOS):

Darwin laptoplocal.local 21.4.0 Darwin Kernel Version 21.4.0: Fri Mar 18 00:47:26 PDT 2022; root:xnu-8020.101.4~15/RELEASE_ARM64_T8101 arm64

What arkade version is this?

Version: 0.8.34
Git Commit: b273819ddf3f78f5d23f5af204ed815638f97d56

The way that Lima is packaged isn't compatible with arkade and the maintainer actively said he wasn't going to change the packaging to suit arkade better.
I'm not sure if colima has the same issues? https://github.com/lima-vm/lima/issues/591

Yes, you are right. If deps aren't satisfied (e.g. limactl) it won't work.

There may be a case for using arkade system install here. What kinds of steps are required to install Lima?

@alexellis Hello. For lima installation steps aren't trivial tho:
https://github.com/lima-vm/lima#installation

I checked installation requirements. As a first step we have to install qemu which isn't possible via single binary - it either requires brew or make call from the directory with qemu's source code.


support locally installed esformatter

I (and I believe many other people) install esformatter as a local dev-dependency (it is easier for team collaboration). With this PR, sublime-esformatter will first search for locally installed esformatter and then global one.

Just found someone with the same issue: #64

looks nice, just out of curiosity, are you using mac / win / linux?

Windows. And all my colleagues use win too so I only tested it on windows.

great I can test on mac

@felixhao28 thanks for this and sorry if it took so long. I tested on mac and works fine.


Build Windows on Mac

Describe the bug
Started a clean project and tried to build for windows using Mac (10.15.7 Catalina).

cannot build native dependency  reason=prebuild-install failed with error and build from sources not possible because platform or arch not compatible
cause=exit status 1
errorOut=prebuild-install info begin Prebuild-install version 6.0.0

prebuild-install WARN install prebuilt binaries enforced with --force!
prebuild-install WARN install prebuilt binaries may be out of date!
prebuild-install info looking for cached prebuild @ /Users/xxx/.npm/_prebuilds/90c5a2-sharp-v0.27.0-electron-v85-win32-x64.tar.gz
prebuild-install http request GET https://github.com/lovell/sharp/releases/download/v0.27.0/sharp-v0.27.0-electron-v85-win32-x64.tar.gz
prebuild-install http 404 https://github.com/lovell/sharp/releases/download/v0.27.0/sharp-v0.27.0-electron-v85-win32-x64.tar.gz
prebuild-install WARN install No prebuilt binaries found (target=11.2.0 runtime=electron arch=x64 libc= platform=win32)

OS: Mac Os Catalina
Capacitor/Electron: 1.3.1
Electron: 11.0.1
Electron-builder: 22.9.1

cannot build native dependency reason=prebuild-install failed with error and build from sources not possible because platform or arch not compatible

prebuild-install http 404 https://github.com/lovell/sharp/releases/download/v0.27.0/sharp-v0.27.0-electron-v85-win32-x64.tar.gz

prebuild-install http request GET https://github.com/lovell/sharp/releases/download/v0.27.0/sharp-v0.27.0-electron-v85-win32-x64.tar.gz

The prebuilt data your mac needs to build a windows app is not available (404), and because electron-builder can not build from source for windows on a mac, it fails.
This would be an issue to bring up over at the electron-builder repo.
I'm afraid I'm unable to help with this issue from this repo.

cannot build native dependency reason=prebuild-install failed with error and build from sources not possible because platform or arch not compatible

prebuild-install http 404 https://github.com/lovell/sharp/releases/download/v0.27.0/sharp-v0.27.0-electron-v85-win32-x64.tar.gz

prebuild-install http request GET https://github.com/lovell/sharp/releases/download/v0.27.0/sharp-v0.27.0-electron-v85-win32-x64.tar.gz

The prebuilt data your mac needs to build a windows app is not available (404), and because electron-builder can not build from source for windows on a mac, it fails.
This would be an issue to bring up over at the electron-builder repo.
I'm afraid I'm unable to help with this issue from this repo.


Beta

[x] #314
[x] #306
[x] #319
[x] #323
[x] #322
[x] #316
[x] #308
[x] #332
[x] #297
[x] #312
[ ] #295
[ ] #223
[ ] #294
[ ] #324
[ ] #260
[ ] #255
[ ] #331
[ ] #160
[ ] #315
[ ] #209
[ ] #326
[ ] #304
[ ] #329
[ ] #242
[ ] #303
[ ] #346
[ ] #301
[ ] #244
[ ] #307
[ ] #338
[ ] #333
[ ] #339

not working on any of these because i aint no beta male 😤

Closing in favour of using the board


503 during VirtualService update in 1.8

Bug description
We're trying to upgrade knative to Istio 1.8, but are running into issues (knative/net-istio#426). We have a test that creates a VirtualService, then updates it 10 times to return different headers. We usually run 10 of these tests in parallel.
After updating to 1.8, I consistently see 503s between updates. [ingress-conformance-0-update-bflpksfb] and [ingress-conformance-0-update-jwnqvzhi] reflect the headers in the response; as below. The outage happens when the header gets applied.
    update.go:191: [ingress-conformance-10-update-bxlqwtjl] Got OK status!
    util.go:975: Error meeting response expectations for "http://ingress-conformance-10-update-uvnvrjow.example.com": got unexpected status: 503, expected map[200:{}]
    util.go:975: HTTP/1.1 503 Service Unavailable
        Date: Tue, 01 Dec 2020 21:04:57 GMT
        Server: istio-envoy
        Content-Length: 0

    update.go:191: [ingress-conformance-10-update-xuzhueaw] Got OK status!

Envoy's logs point to there not being a route during this time, which is odd:
[2020-12-01T21:04:57.972Z] "GET / HTTP/1.1" 503 NR "-" 0 0 0 - "<IP_ADDRESS>" "knative.dev/TestIngressConformance/10/update/ingress-conformance-10-update-gouiithw" "e27c8599-d973-4d80-876d-4838ac4e0523" "ingress-conformance-10-update-uvnvrjow.example.com" "-" - - <IP_ADDRESS>:8080 <IP_ADDRESS>:23011 - -

Recently
[ ] Docs
[ ] Installation
[X] Networking
[X] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
VirtualService should stay available between updates.
Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
client version: 1.7.2
control plane version: 1.8.0
data plane version: 1.8.0 (1 proxies)

How was Istio installed?
Latest 1.8 using istioctl with the following config:
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
spec:
  values:
    global:
      proxy:
        autoInject: disabled
      useMCP: false
      # The third-party-jwt is not enabled on all k8s.
      # See: https://istio.io/docs/ops/best-practices/security/#configure-third-party-service-account-tokens
      jwtPolicy: first-party-jwt
    pilot:
      autoscaleMin: 3
      autoscaleMax: 10
      cpu:
        targetAverageUtilization: 60
    gateways:
      istio-ingressgateway:
        autoscaleMin: 2
        autoscaleMax: 5

  addonComponents:
    pilot:
      enabled: true

  components:
    ingressGateways:
      - name: istio-ingressgateway
        enabled: true
        k8s:
          resources:
            limits:
              cpu: 3000m
              memory: 2048Mi
            requests:
              cpu: 1000m
              memory: 1024Mi

Environment where the bug was observed (cloud vendor, OS, etc)
GKE

/cc @ZhiminXiang @JRBANCEL

@arturenault so the test is essentially doing:

Create VS with header match foo: bar-1
curl -H "foo: bar-1"
Edit VS with header match foo: bar-2
curl -H "foo: bar-2"

And step (4) is getting a 503?
if so that seems expected since there may be a race between the new VS config being propagated. Maybe it looks more like

Create VS with header match foo: bar-1
curl -H "foo: bar-1"
Edit VS with header match foo: bar-2
Prober: curl -H "foo: bar-2" until it returns 200
After prober success, run curl -H "foo: bar-2" again, and it 503s

Let me know if either of those are accurate

Sorry, we're updating the set headers (spec.http.route.headers.request.set), not the header match. Otherwise it does look like 1.

ah, got it. That certainly shouldn't happen then. Thanks

for i in {0..100}; do
cat <<EOF | kubectl apply -f -
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  name: echo
  namespace: default
spec:
  gateways:
  - echo
  hosts:
  - '*'
  http:
  - headers:
      request:
        set:
          foo: bar-$i
    route:
    - destination:
        host: echo
        port:
          number: 8080
      headers:
        request:
          set:
            other: baz-$i
EOF
sleep 1
done

I tried reproducing by running ^ and send a bunch of requests; no luck. I must be doing something differently than knative if you are able to consistently hit this with the test

It might require doing this in parallel with a few different VirtualServices. The test creates 10 VSes in parallel and updates each of them 10 times. When I change the test to just create one and update it things succeed. I'll play around and see if I can get a knative-less repro as well

It looks like I misunderstood what the test was doing, sorry for the confusion.
At first we create a k8s service and a virtualservice.
The first verification we do is update the VS's header as described above and make sure we get a 200. We do this 10 times.
Then, we create a new k8s service and pod at each iteration, wait for them to be ready, and then update the VS to point to them. We do this 10 times too. This is the stage at which we're getting 503s; in almost every test run I've done I've hit this at least once.
Is this expected in any way in 1.8? We have this as a knative conformance test and it was passing before.

@arturenault at any point is there two services pointing to the same pod? If so it might be fixed in 1.8.1 by https://github.com/istio/istio/pull/29333
Whatever it is, its certainly not expected

It doesn't look like we ever have two services pointing at the same pod, at least not the ones we create for the test since we use randomly generated names for those.

It would be based on the label selector I think. I have had problems running knative e2e tests in the past, it would be great to have a non-knative reproducer if possible

Correct, the label selector is the randomly generated test name.
I'll try to create a non-knative repro when I have some time; if you want to check out the knative repro in the meantime this is the test I'm running:
go test ./test/conformance -count=1 -tags=e2e -v -run TestIngressConformance/^0$/update

OK, I have a repro!

Create 12 pods and services, each listening on its own port:

for i in {20000..20012}; do export i
envsubst < pod.yaml | kubectl apply -f - ; envsubst < service.yaml | kubectl apply -f -
done

Repeatedly update virtual service to point at different services:

for i in {20000..20012}; do export i
envsubst < vs.yaml | k apply -f -
done

Meanwhile make a bunch of curl requests:

while :
do
curl -s http://<istio-ingressgateway-ip>:80/ -HHost:ingress-conformance.example.com -I | tee -a reqlogs.log
done

YAMLs below:
pod.yaml
apiVersion: v1
kind: Pod
metadata:
  labels:
    test-pod: ingress-conformance-$i
  name: ingress-conformance-$i
spec:
  containers:
  - env:
    - name: PORT
      value: "$i"
    image: gcr.io/knative-samples/helloworld-go
    name: foo
    ports:
    - containerPort: $i
      name: http
      protocol: TCP

service.yaml
apiVersion: v1
kind: Service
metadata:
  name: ingress-conformance-$i
spec:
  ports:
  - name: http
    port: $i
    protocol: TCP
    targetPort: $i
  selector:
    test-pod: ingress-conformance-$i
  sessionAffinity: None
  type: ClusterIP

vs.yaml
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  name: ingress-conformance
spec:
  gateways:
  - knative-serving/knative-ingress-gateway
  hosts:
  - ingress-conformance.example.com
  http:
  - route:
    - destination:
        host: ingress-conformance-$i.default.svc.cluster.local
        port:
          number: $i
      headers:
        respons:
          set:
            Who-Are-You: ingress-conformance-$i

knative-ingress-gateway just looks like this:
apiVersion: networking.istio.io/v1beta1
kind: Gateway
metadata:
  labels:
    networking.knative.dev/ingress-provider: istio
    serving.knative.dev/release: devel
  name: knative-ingress-gateway
  namespace: knative-serving
spec:
  selector:
    istio: ingressgateway
  servers:
  - hosts:
    - '*'
    port:
      name: http
      number: 80
      protocol: HTTP

Thank you! I reproduced it, looking into it now

This is fixed in https://github.com/istio/istio/pull/29060. Basically we accidentally enabled a feature in 1.8 due to a merge conflict when it wasn't ready. Its fixed in 1.8.1 (as tested by 100 iterations of the above reproducer). https://github.com/istio/istio/issues/29131 tracks the re-enablement of this feature and marks fixing this as a blocker.
The root cause is the feature will filter out clusters we don't need in the gateway. However, when we get the new VS we then send the cluster and route referncing the cluster to envoy at the same time. There is a race here if the route is applied before the cluster.

Thanks for looking into it. So is a fix expected in 1.8.1?

Yes which is expected very soon - afaik tomorrow
On Mon, Dec 7, 2020, 4:31 PM Artur Upton Renault<EMAIL_ADDRESS>wrote:

Thanks for looking into it. So is a fix expected in 1.8.1?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/29310#issuecomment-740267266, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXKFHOQMNBJFNWOTTQDSTVXVPANCNFSM4UJUDXOQ
.

Confirmed that 1.8.1 fixed the issue. Thanks for looking into this!

Note: while this issue is fixed in 1.8 by dark launch PILOT_FILTER_GATEWAY_CLUSTER_CONFIG, the original issue introduced by the PILOT_FILTER_GATEWAY_CLUSTER_CONFIG feature still exist, as John mentioned: https://github.com/istio/istio/issues/29310#issuecomment-740224564

reopen to avoid confusion that this is fixed... only fixed when the PILOT_FILTER_GATEWAY_CLUSTER_CONFIG feature is disabled.

flag issues are tracked in https://github.com/istio/istio/issues/29131


Cursor pointer on hover in sponsors.

Cursor pointer on hover in sponsors fixes #43 .

@akshathar-navada  kindly review this PR :)

@shreya26-bit Thank you for contributing to our repo, we will soon review and merge it!!

@shreya26-bit As we are not going link each sponsors to other link, I think previous one is better.
Thank you!

May, I join the links for sponsors that redirect to their respective
website?
On Sun, May 21, 2023, 8:11 AM Akshatha R @.***> wrote:

@shreya26-bit https://github.com/shreya26-bit As we are not going link
each sponsors to other link, I think previous one is better.
Thank you!
—
Reply to this email directly, view it on GitHub
https://github.com/OSCode-Community/OSCodeCommunitySite/pull/94#issuecomment-1556068311,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5JUV73V6HX4H6JETH56NATXHF6G3ANCNFSM6AAAAAAYI5A66U
.
You are receiving this because you were mentioned.Message ID:
@.***>

May, I join the links for sponsors that redirect to their respective website?
…
On Sun, May 21, 2023, 8:11 AM Akshatha R @.> wrote: @shreya26-bit https://github.com/shreya26-bit As we are not going link each sponsors to other link, I think previous one is better. Thank you! — Reply to this email directly, view it on GitHub <#94 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5JUV73V6HX4H6JETH56NATXHF6G3ANCNFSM6AAAAAAYI5A66U . You are receiving this because you were mentioned.Message ID: @.>

@shreya26-bit As of now it's not required. It is just to show that they are our partners. If there is any other issue, in which u want to contribute, please go ahead
Thank you:)


More robust native tests

This fixes a case where a connection from an old test was closed and caused a crash in a subsequent test

Obsoleted by https://github.com/apollographql/apollo-android/pull/3148


Allow users to navigate the Create Project form out of order

Overview
This PR contains the following changes

Allow users to navigate the Create Project form out of order

This PR contains the following types of changes

[x] New feature (change which adds functionality)
[x] Enhancement (improvements to existing functionality)

How Has This Been Tested?

Locally

Screenshots

When you open a saved draft, the forms should also open that the first incomplete section.

will handle in different ticket as not part of acceptance criteria and also requirement is still unclear


adds "VisualsExtensibility" to Visual Studio solution

Adds "VisualsExtensibility" to Visual Studio solution.

Hi @ignatvilesov, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Vilesov Ignat (Akvelon)). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

lgtm, thanks


Make time travelling optional

Hi,
in my specific case, I'm dispatching a replace action whenever no locale is set in the URL to go to a correct URL. E.g. mysite.com would be considered wrong because I want my URL to be mysite.com/en-us by default.
For some reason (because of the check for time travelling) the URL would always jump back to the previous one, the one without locale...
This PR adds an extra prop to ConnectedRouter to disable the time travelling. Default value is still true, so I believe this could be merged without any issues.
Usage:
    <ConnectedRouter allowTimetravel={false}>
        ...
    </ConnectedRouter>

@nickwaelkens Thanks for sharing this info and PR.
Could you share me your problematic gist or repo? I'd like to inspect for the root cause.

We opted for a different approach that fixes the problem in the end, but I will make a small example of what was going wrong this weekend! Thanks for your patience @supasate.

Don't worry. No rush. Just do it when you're comfortable ^^.

Hi @nickwaelkens. Is there any update on this issue? I'd be happy to see the root cause and what alternative way you used to solve it.

Hi @supasate, sorry for my extremely late reply.
Basically, we ended up handling the redirects/rewrites using our Express server so we have proper 302's and we can remove the logic from the front-end application. I have very little time to recreate the problem, but this is the gist of it...
Make a HOC and put it before the connected router which handles the rewriting of the URL like I described here. Then in your mounted component it would look something like this:
      <Provider store={store}>
        <L10nProvider history={history} store={store}>
          <App history={history} /> // connected-react-router happens inside App
        </L10nProvider>
      </Provider>

And because I trigger a replace in the L10nProvider the router thinks I'm in time travel mode, which I'm not...?


ci: switch to re-usable workflow from rdmorganiser/.github

Description
This is a proposal to move the CI workflows, that can be used by multiple projects (e.g. rdmo, plugin a, plugin b, etc) to rdmorganiser/.github.
At the moment the only re-usable workflow is the lint workflow. It is available at the main branch. But if you like this approach, I will add a tag to the repo.
What do you think?
Types of Changes

[x] Other (please describe):

Checklist

[x] I have read the contributor guide.

I can move additional jobs into the central .github repo, if you like.

yes, think it makes sense to move most of the jobs that could be re-used to the .github and maintain them there, thank you!

yes, think it makes sense to move most of the jobs that could be re-used to the .github and maintain them there, thank you!

Alright. But let's merge this now, okay? I will submit another PR for the Dev setup job.


Adding more features to login and signup front end project

Added input validation in signup form through javascript function call
Added redirection to login page after signing up
Added built-in input validations in both signup and login forms.

Title and Issue number
Close #1589
Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md

@MohitGupta121 Review this PR


file are empty after plugin run ruff if file located in ignored directory

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

create a new python project with pycharm
run git init and create a git repo
add .gitignore file and add a directory build
commit code to git
create a file build/a.py, and this file is ignored by git
write any code
format code, trigger plugin to run ruff

Actual behavoir
build/a.py become empty file
Expected behavior
file content should be checked correctly
Screenshots
If applicable, add screenshots to help explain your problem.
Also, gif movies are recommended.
Environments (please complete the following information):

IDE: PyCharm 2023.1.4 (Professional Edition)
OS: windows 10
Ruff Version 0.0.278
Plugin version 0.0.18

Additional context

https://github.com/koxudaxi/ruff-pycharm-plugin/assets/13553903/67a812de-0a33-4a12-9271-c27bb3770401

This also happend if you create a new file and not tracked by git

I find that this issue is not caused by git status, but caused by ruff ignored directory. The file content will lost if you put it in build directory

looks like https://github.com/koxudaxi/ruff-pycharm-plugin/issues/161

yes it's same issue


Track pageView after lightbox content is ready

This one handles page view tracking in appropriate place and ensures event is sent after lightbox renders its content with new datalayer.

👍


Update Ubuntu install guide for 17.10

Now that Docker have updated their Ubuntu repo for artful:

https://download.docker.com/linux/ubuntu/dists/artful/

... we need to update the Ubuntu install guide after testing everything works.

Looks like I was premature as although the repo now exists, the package hasn't yet made it into stable and currently resides in:

https://download.docker.com/linux/ubuntu/dists/artful/pool/test/amd64/


Can't select any completion item because snippet engine is not configured

Getting the following error whenever I press  to pick a completion item:

Here's my cmp configuration stuff:
  require'lspconfig'.tsserver.setup{
    on_attach = custom_on_attach,
    capabilities = require('cmp_nvim_lsp').update_capabilities(vim.lsp.protocol.make_client_capabilities())
  }

  -- Setup nvim-cmp.
  local cmp = require'cmp'

  cmp.setup({
    snippet = {},
    mapping = {
      ['<C-d>'] = cmp.mapping.scroll_docs(-4),
      ['<C-f>'] = cmp.mapping.scroll_docs(4),
      ['<C-Space>'] = cmp.mapping.complete(),
      ['<C-e>'] = cmp.mapping.close(),
      ['<CR>'] = cmp.mapping.confirm({ select = true }),
    },
    sources = {
      { name = 'nvim_lsp' },
      { name = 'buffer' },
    }
  })

I'm on NeoVim v0.6.0-dev+479-g9086938f7
Update:
I've updated my config's snippet section to be like:
    snippet = { expand = function() end },

and now, whenever I select an item, the word i'm trying to complete gets deleted.
I also found that this happens only for certain types of completion (e.g.: .toUpperCase after a string in javascript)
`

It seems like a duplicate of #304.
You need a snippet engine. If you don't want to use one, there is an alternative here.

For example, html/css/json language server does not support any completion if snippet capabilities wasn't set.
We should define the behavior when receiving snippet completion item without a snippet engine.

The documentation has been updated by the colaborator.

for future self:
capabilities.textDocument.completion.completionItem.snippetSupport = false

turns it of on lsp level