Execute Prettier from ESLint

Changes

Add a new shortcut npm run fix to fix styles.

*.ts and *.js, *.json are the target of prettier.

Introduce nom-run-all to execute lint in parallel.
Introduce husky to fix the styles of files which has been staged.

Fix

Execute prettier --check before running eslint.
Execute prettier --write before running eslint --fix

I disagree with you because the prettier team recommends to avoid using the plugin.

https://prettier.io/docs/en/integrating-with-linters.html
Prettier と ESLint の組み合わせの公式推奨が変わり plugin が不要になった

On the other hand, we can setup npm scripts and git hook (husky)[https://github.com/typicode/husky].
Please consider these options.

I disagree with you because the prettier team recommends to avoid using the plugin.

https://prettier.io/docs/en/integrating-with-linters.html
Prettier と ESLint の組み合わせの公式推奨が変わり plugin が不要になった

On the other hand, we can setup npm scripts and git hook (husky)[https://github.com/typicode/husky].
Please consider these options.

I see. Purge eslint-plugin-prettier and run prettier --write before eslint --fix.

I see. Purge eslint-plugin-prettier and run prettier --write before eslint --fix.

I was also creating this function in my local in this morning.
At the time, I was writing commit message :wink:
However, I need no more improvement because of yours. Thanks!

I was also creating this function in my local in this morning.
At the time, I was writing commit message :wink:
However, I need no more improvement because of yours. Thanks!

Nice work! Thank you for your nice update. We now have nice workflow!

Nice work! Thank you for your nice update. We now have nice workflow!


[$1000] Web- Announce room - Clicking on split bill IOU card after removing members behaves inconsistently

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Create a new workspace and add members
Split bill with all the members
Notice clicking on the IOU card in the #announce room opens the details panel
Remove all members from the workspace
Go back to the #announce room and click on the IOU card

Expected Result:
The behavior should be the same before removing members and after removing, hence a new thread should not be created after members have been removed. And if the thread being created is an intended behavior then the message "[Deleted message]" should not appear before the thread gets created. The card in the newly created thread should also not remove the hover state when clicked.
Actual Result:
A new thread will be created when clicking on the IOU card and at first the thread being created will show the message "[Deleted message]". After the thread have been created clicking on the card does nothing and it removes the hover state.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/4819953f-4f43-4427-91a9-6875a5ac7652
https://github.com/Expensify/App/assets/93399543/c0dd3b8c-a91a-4261-90e5-dcb6877c0240
Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685001984533859
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0109384175d45c6600
Upwork Job ID:<PHONE_NUMBER>690783232
Last Price Increase: 2023-06-14

I need to start a discussion to figure out what the ideal behavior should be for this. Will do that soon.

@Santhosh-Sellavel I'll be OOO this week, so if you need Internal help moving this forward during that time please ask in #contributor-plus. Thanks!

@tylerkaraszewski looks like you got auto-assigned then i accidentally removed you 😳

This bug report is old. The details page was a placeholder ahead of introducing the split confirmation screen.

I removed members and it remains the same, as intended. http://g.recordit.co/LWBlPIBciO.gif
Closing.

Solution:
Maintain IOU Card Behavior Consistency:
The IOU card should maintain the same behavior regardless of the number of workspace members. This might involve adjusting the condition that triggers the creation of a new thread when the IOU card is clicked.
Handle Empty Threads:
The application should be adjusted so that "[Deleted message]" does not appear when creating an empty thread. This could be an issue with how the app handles empty threads or threads that lose all members.
Persistent Hover State:
The hover state of the IOU card should not be removed when clicked. It might be a CSS or JS issue that needs to be investigated.
Here's a general plan on how to approach these changes:
Identify the sections of the code that handle IOU card click events, thread creation, and hover states.
Investigate the conditions that lead to new thread creation on IOU card click. Adjust these conditions so the behavior stays consistent regardless of member count.
Adjust the code that handles thread creation to prevent the "[Deleted message]" text from appearing in newly created threads.
Debug and resolve the issue causing the hover state removal on the IOU card click event.

Thanks for closing @trjExpensify and nothing is due.


Make Dev Toolbar App development easier

It would be great to provide utilities to allow authors easily write their dev toolbar app using their favorite UI framework

https://react.dev/reference/react-dom/client/createRoot

I'd love an api sorta like
defineDevToolbarApp({
  type: 'react' | 'vue' | 'svelte' | etc,
  src: resolve('./app.jsx'),
})

Then behind the scenes it'll load a boilerplate entrypoint to setup.addDevToolbarApp which will load your component and choose the correct renderer.
It'll also need to add the correct renderer to setup.addRenderer too which I guess would mean the integration author would have to set that framework as a peer dependency of their integration

That's what I was thinking too, it would up to the author to import the right dependencies. If it's documented, everything is fine


Feature requests

I'm getting this error message when trying to run script w/o being on a HLL server: https://pastebin.com/Fp1Q6irS  OBS is ran as an admin. Script refuses to work until the pc is rebooted no matter what.
Therefore could the following features be added?

option to run script in paused state by default
hotkey to pause the script

Hey, thanks for the bug report.
To confirm, did you have the game open and you were in the menus, or was the game closed?
Does the script work for you normally otherwise?
Just killing the script (e.g. Control-C, or closing the terminal), then restarting it should work in terms of getting it up and running again.

To confirm, did you have the game open and you were in the menus, or was the game closed?
Does the script work for you normally otherwise?
The behaviour happens with HLL not running.

After trying to to restart the script in the game, it sometimes continues to give the error, thus the rebooting pc comment.
A few moments ago, after a reboot, script worked fine after starting it in game (after ctrl+c termination w/o the game running).

This is quite weird. After starting the script with game running, map visible, after a reboot, I'm getting the errors once again. https://pastebin.com/83J6dY9s
Terminating the script and re-running doesn't help.


How to send a query or stored procedure execution to a specific region/location ?

Once a connection is defined with several PreferredLocations defined in the connectionPolicy, is it possible to micro-manage query and storedprocedures posts to parallelize calls to each locations/regions ?
There is no examples including anything regions related, and as for now the doc is still empty well...

This is not possible with a single client. You'll need a create a client for each region by setting preferred locations to a single value and then deciding which client to use in application code.


module 'pyTMD' has no attribute 'compute'

Hi,
I fell I am missing something basic here.
I was trying to use the example given in here, i.e.:
tide_h = pyTMD.compute.tide_elevations(x, y, delta_time,     DIRECTORY=path_to_tide_models,     MODEL='CATS2008', EPSG=3031, EPOCH=(2000,1,1,0,0,0),     TYPE='drift', TIME='GPS',     METHOD='spline', FILL_VALUE=np.nan)
But, after I receive the error:
`AttributeError: module 'pyTMD' has no attribute 'compute'
What I have done:

created a separate conda environment
installed with conda the pyTMD package (conda install -c conda-forge pytmd)
Run the following script:
`import numpy as np
import pyTMD

x                   = 14.5625
y                   = 36.4375
delta_time          = pyTMD.time.convert_calendar_dates(2000, 1, 1, minute = np.arange(0,24*60,30))
path_to_tide_models = 'D:\TPXO9\TPXO9_atlas\TPXO9_atlas_v5'
model_name          = 'TPXO9-atlas-v5'
epoch_tuple         = (1992,1,1,0,0,0)
tide_h = pyTMD.compute.tide_elevations(x, y, delta_time,
DIRECTORY   = path_to_tide_models,
MODEL       = model_name,
EPOCH       = epoch_tuple,
TYPE='drift', TIME='GPS',
METHOD='spline', FILL_VALUE=np.nan)`
Can you please help?

Sorry about that @maucollu! I need to make a new release as I've refactored some things since v2.1.0. I've been working on some things that I was hoping to get in before v2.1.1.
In the mean time, can use the stable documentation :point_down:
https://pytmd.readthedocs.io/en/stable/getting_started/Getting-Started.html

Thanks a lot @tsutterley for the quick answer, no problem!
I have another doubt, though, but I'll post it in another separate issue.
Many thanks!


How to add class names to markdown components?

I want to control the style of the markdown components using CSS classes. I'm setting the className prop to every component like this:
import React from 'react'
import CommonMark from 'commonmark';
import ReactRenderer from 'commonmark-react-renderer'

const parser = new CommonMark.Parser();
const renderer = new ReactRenderer();

const setMarkdownCSSClassToComponentFunc = (className) => {
  return (component) => React.cloneElement(component, { className })
}

const markdownToComponentArray = (markdownSource, markdownClass) => {
  const ast = parser.parse(markdownSource)
  const componentArray = renderer.render(ast);
  const setMarkdownCSSClassToComponent = setMarkdownCSSClassToComponentFunc(markdownClass)
  return componentArray.map(setMarkdownCSSClassToComponent)
}

export default markdownToComponentArray

This seems to work fine with <p> elements, but it doesn't work at all with other elements like <h2> or <pre>. Can anyone please give me any suggestions?

I just pushed v4.3.3 which makes className a "core prop", which should make sure it's included by all renderers.
Do note that the code you have above will only address root-level components, but that might be OK depending on your use case?
For even more control, you can use custom renderers.


Shortlist stereotypes

We need to shortlist stereotypes of interest (say 10). These will be used together with a list of tags derived from one of the test datasets.

Examples of stereotypes in online pornography:

White women as 'submissive', sexually ‘innocent’ or 'subservient’; a more specific stereotype that falls within this category is that of the ‘Schoolgirl’, another that fits within this frame is the ‘Slut’ stereotype used to denote women who do want to have sex, the ‘Mom’ stereotype may also fall within this category;
Men as 'aggressive' and 'dominant’
Asian women as 'exotic’ or ‘innocent’; specific stereotypes that fall within this category are those of the ‘Dragon Lady’ and ‘Lotus Flower’;
Black men as ‘overly aggressive’ and endowed with 'a heightened libido' and 'large genitalia’; specific stereotypes that fall within this category are those of the ‘Thug’, ‘Gang’ and ‘BBC’ (Big Black Cock)
Black women also as endowed with ‘a heightened libido’ and ‘large bottoms’; a specific stereotype that falls within this category is that of the ‘Jezebel’.
Taboo subjects, like ‘incest narratives’; specific stereotypical figures that fall within this category are the ‘stepmom’ and ‘step brother/sister’.
White women with very ‘large breasts’ and small waists

Some of the literature I used to come to this list, that may also be interesting to look at in the future:

Bond KT, Leblanc NM, Williams P, Gabriel C-A, Amutah-Onukagha NN. Race-Based Sexual Stereotypes, Gendered Racism, and Sexual Decision Making Among Young Black Cisgender Women. Health Education & Behavior. 2021;48(3):295-305. doi:10.1177/10901981211010086
Cowan, G., & Campbell, R. R. (1994). Racism and sexism in interracial pornography a content analysis. Psychology of Women Quarterly, 18(3), 323-338.
Fritz, N., Malic, V., Paul, B., & Zhou, Y. (2021). Worse than objects: The depiction of black women and men and their sexual relationship in pornography. Gender Issues, 38(1), 100-120.
Shor, E., & Golriz, G. (2019). Gender, race, and aggression in mainstream pornography.
Smith, J. G., & Luykx, A. (2017). Race play in BDSM porn: The eroticization of oppression. Porn Studies, 4(4), 433-446.
Vannier, S. A., Currie, A. B., & O’Sullivan, L. F. (2014). Schoolgirls and soccer moms: A content analysis of free “teen” and “MILF” online pornography. The Journal of Sex Research, 51(3), 253-264.
Zhou, Y., & Paul, B. (2016). Lotus blossom or dragon lady: A content analysis of “Asian women” online pornography. Sexuality & Culture, 20(4), 1083-1100.

Looking at the stereotypes above, they can be defined along several axes:

Ethnicity: White, Black, Asian, Other?, Unknown?
Gender: Male, Female, Other?
Behavior: Submissive, Innocent to Aggressive
Setting: Neutral to Taboo like Incest, Stepmom, Amateur
Physical appearance: Breast / Waist size; BBC

We can make classifiers or scorers that label a video along each of those to get at the stereotypes.
Setting and physical appearance could be broken up in multiple subgroups. Which are necessary?
Taboo could be because of the person (stepmom/incest, age) or action (fetishes?) or location (in public / gym / pool)
Appearance has subgroups: length, weight, cupsize, waist, hair color and size.
We see other axis in the data that could be relevant (or not):

hardcore / softcore
HD
specific actions: blowjob, cumshot, creampie etc. but could be mapped to the 'Setting' or taboo axis?

@SamiraBohemen can you please look at this?

I think this already looks pretty comprehensive, but I think we at least need to add:
6.

Ethnicity: White, Black, Asian, Other?, Unknown?
Gender: Male, Female, Other?
Behavior: Submissive, Innocent to Aggressive
Setting: Neutral to Taboo like Incest, Stepmom, Amateur
(Physical) Appearance: Breast / Waist size; BBC
Attributes: e.g., exotic, slutty, large sex drive, creep
Actions: blowjob, cumshot, creampie etc

Examples of stereotypes in online pornography:

White women as 'submissive', sexually ‘innocent’ or 'subservient’; a more specific stereotype that falls within this category is that of the ‘Schoolgirl’, another that fits within this frame is the ‘Slut’ stereotype used to denote women who do want to have sex, the ‘Mom’ stereotype may also fall within this category;
Men as 'aggressive' and 'dominant’
Asian women as 'exotic’ or ‘innocent’; specific stereotypes that fall within this category are those of the ‘Dragon Lady’ and ‘Lotus Flower’;
Black men as ‘overly aggressive’ and endowed with 'a heightened libido' and 'large genitalia’; specific stereotypes that fall within this category are those of the ‘Thug’, ‘Gang’ and ‘BBC’ (Big Black Cock)
Black women also as endowed with ‘a heightened libido’ and ‘large bottoms’; a specific stereotype that falls within this category is that of the ‘Jezebel’.
Taboo subjects, like ‘incest narratives’; specific stereotypical figures that fall within this category are the ‘stepmom’ and ‘step brother/sister’.
White women with very ‘large breasts’ and small waists

@SamiraBohemen Can these improve this description?

I use it for word embedding to link descriptions of stereotypes and tags that represent them. The better descriptions, the better results.


Ignore converting useless images

Romhacks are generally identifiable in libretro-thumbnails via the filename. These are useless until Analogue allows either (or both):

unrecognized CRC IDs to display the Game Details screen on custom carts
OpenFPGA cores to read and display Library images for loaded ROMs

e-Reader cards for the GBA also fall into a similar bucket.
Removing these will clean up verbose output a bit more as well as reduce the processing time and library size.

This has been completed. An md file was created to track explicit special cases and has also been codified in the script to either ignore images useless (today) on the Pocket or redirect one of the few missing entries that is actually due to a naming mismatch on the libretro-thumbnails side.


Feature: Edit job's data at failed / waiting tabs

The ability to edit the "data", save then it creates a log of what it previously was

Can you elaborate?

Duplicate of #425

So it's a duplicate of #426 :]
The ability to add a new job (with predefined params from an existing one).

I don't think that existing jobs is a good practice...
Think that you will need to move it to waiting as well.
How would you do that with code? is bull & bullmq supports it?
The suggested solution that I thought of, is to add a new job with duplicated data.

Ok, get your point.

Is this currently implemented?

Not yet ...

Released in v5.22.0


#CodeAgainstCoronavirus

Hey,
We both have to same intention. To Fight Against Coronavirus with Code.
Can you guys link my project to your Repo?
Could you guys promote my repo as well?
I feel there are many people working on code to fight COVID-19.
https://github.com/NotMoni/code-against-coronavirus

@NotMoni I don't think your repo has an impressive value for the users.

@soroushchehresa I will start to get some traction if you could help.


swagger-springmvc and spring security

Hi.
I'm trying to use swagger-springmvc 1.0.2 in my project and I can't figure out how to configure authorizations using Oauth.
I investigated an example given here I learned an example
https://github.com/adrianbk/swagger-springmvc-demo/blob/master/spring3-testsuite/src/main/java/com/ak/spring3/testsuite/config/SwaggerConfig.java
This is a part of my security config
`
<beans:bean id="clientAuthenticationEntryPoint"
class="org.springframework.security.oauth2.provider.error.OAuth2AuthenticationEntryPoint"/>
<beans:bean id="oauthAccessDeniedHandler"
            class="org.springframework.security.oauth2.provider.error.OAuth2AccessDeniedHandler"/>

<beans:bean id="clientCredentialsTokenEndpointFilter"
            class="org.springframework.security.oauth2.provider.client.ClientCredentialsTokenEndpointFilter">
    <beans:property name="authenticationManager" ref="clientAuthenticationManager"/>
</beans:bean>

<http pattern="/oauth/token" create-session="stateless" authentication-manager-ref="clientAuthenticationManager">
    <intercept-url pattern="/oauth/token" access="IS_AUTHENTICATED_FULLY" method="POST"/>
    <anonymous enabled="false"/>
    <http-basic entry-point-ref="clientAuthenticationEntryPoint"/>
    <access-denied-handler ref="oauthAccessDeniedHandler"/>
    <custom-filter ref="clientCredentialsTokenEndpointFilter"
                   after="BASIC_AUTH_FILTER"/>
</http>

<http pattern="/**" create-session="never"
      entry-point-ref="oauthAuthenticationEntryPoint" use-expressions="true">
    <anonymous enabled="true"/>
    <custom-filter ref="resourceServerFilter" before="PRE_AUTH_FILTER"/>
    <access-denied-handler ref="oauthAccessDeniedHandler"/>
    <intercept-url pattern="/cms/**" access="hasRole('ROLE_CMS_USER')"/>
</http>

<beans:bean id="oauthAuthenticationEntryPoint"
            class="org.springframework.security.oauth2.provider.error.OAuth2AuthenticationEntryPoint"/>

`
and I'm receiving Oauth token on myAppContext/oauth/token endpoint.
Then I just add Authorization:Bearer token to request header
Could you please explain what I should pass in authorizationContext() and authorizationTypes() to
get work authorization on swagger UI?

@Mikhail88 before I answer, we're very close to releasing 2.0.0, which has better support for all of this anyways and it supports swagger spec 2.0. So would you be willing to be our test subject in verifying that the security related work we've been doing works in 2.0 of the library as well.
The bonus is ofcourse you'll be already on the  2.0 upgrade path :)


Exluded field annotations (sometimes) ignored when also used on a constructor

An interesting case, which I'm trying to track why it occurs on some of my code, but not others.
I have com.google.inject.Inject configured under -XepOpt:NullAway:ExcludedFieldAnnotations and have some code that looks like:
public class Someclass {
  @Inject ServiceA serviceA;

  @Inject
  public Someclass(ServiceB serviceb) {
    ...
  }
}

and NullAway complains on the constructor, that serviceA is not initialised, when Guice will actually inject the constructor arguments, then set the injected fields correctly.
This doesn't appear to occur on all of my modules, but on those it does, it seems to always happen - is there anything I could look at as to why this might trigger?
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile) on project smx3.archiving: Compilation failure
[ERROR] /Users/amrk/IdeaProjects/Something.java:[63,10] [NullAway] initializer method does not guarantee @NonNull fields archiveProvisioningService, archivingService, eventStoreLogSearchService, lookupService, dslContext, notificationService are initialized along all control-flow paths (remember to check for exceptions or early returns).
[ERROR]     (see http://t.uber.com/nullaway )

@lazaroclapp all good - things get away with us at times. I'll recheck our code where I was hitting it, and will try with 0.5.0 and report back.

@talios this has been open for some time; have you ever been able to reproduce?  If not, maybe we can close?


SA1633 shows a code fix even if the header is correct.

We use headers in our CS files with this format :
//-----------------------------------------------------------------------
// <copyright file="ViewModel.cs" company="Company">
// Copyright (c) Company. All rights reserved.
// </copyright>
// <author>FirstName LastName</author>
//-----------------------------------------------------------------------

This format is valid as described here : https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1633.md
But stylecop is reporting it as a violation and suggest the following code fix :
// <copyright file="ViewModel.cs" company="Company">
// Copyright (c) Company. All rights reserved.
// </copyright>

We are using version 1.0.0-beta013
I am using

@vweijsters Does the file header extraction not currently support bars?

Assign it to me, I'll have a look

There is a test case for this in FileHeaderTestBase.TestValidFileHeaderWithBordersAsync
The code however is very strict in formatting.
@MatthieuNarcisi Do your headers have any spaces (or other characters) between the // and the - characters?

I think I found the issue. It is (kind of) my fault.
My default header (when I create a class) look like this :
//-----------------------------------------------------------------------
// <copyright file="ViewModel.cs" company="Company">
//     Copyright (c) Company. All rights reserved.
// </copyright>
// <author><FullName></author>
//-----------------------------------------------------------------------

There is a XML tag that the user has to replace by their name.
The error is only reported when I have this default header before I change it, so my guess is that the parser tries to parse the XML but fails (as the FullName tag is not closed) and report an error.

@MatthieuNarcisi Perhaps {FullName} would be a better alternative?

:question: @MatthieuNarcisi What is the exact message reported by StyleCop.Analyzers in your case? Does it indicate that the header does not contain valid XML?

@sharwell Indeed the exact message is :
Warning	SA1633	The file header XML is invalid.

You are right, my understanding of the error was wrong. It was simply that the code fix was misleading, I though the whole header was wrong. But I agree with you, the improvement to the project is minimal.
Thank you for your time and help anyway.

@MatthieuNarcisi I filed #1633 with a more specific enhancement request that would likely improve the user experience in scenarios like yours. :+1:

this is a little be late now but you guys build the json file first which is fine also you guy need to set explicit access modifiers and XML comments for the class and method


Chore/es6 updates

1⃣ Is this something that is wanted/needed? Did you create a feature-request issue first?
This is a small syntax update in a few javascript file, no new features included.
2⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
The first commit introduces a new .gitignore item for the .idea folder created when using PHPStorm (and similarly WebStorm).
The rest of the pr contains only syntax changes in some js files, i toyed with the idea of breaking down the changes for 1 liner returns and destruction separately, but in most cases the changes are on the same lines so didn't seem correct to pollute the history with the 2 changes which both fall under formatting changes.
3⃣ Does it include tests if possible? (Not a deal-breaker, just a nice-to-have)
No new features, all existing js test continue to pass after the changes.
4⃣ Please include a thorough description of the feature/fix and reasons why it's useful.
The change updates some syntax to make use of the new js formatting features, specifically object destruction, implied returns in arrow functions and a small tweak to the getCSRFToken method in the http driver.
The later converts the method signature to be declarative instead of imperative, reducing control flow.
The former simply reduce repetition.
5⃣ Thanks for contributing! 🙌

Is this an optimization we could do as well? https://github.com/pusher/pusher-js/pull/370

The pusher-js optimization you linked does not apply here as you don't use typescript (or rather it is already applied, as you already feed ES modules to webpack).
The optimization that you could benefit from though is https://github.com/pusher/pusher-js/pull/361: making sure that the only difference between your output files are the minification, not prod vs dev mode of webpack, so that other webpack prod optimization (and especially the module concatenation, which helps a lot the minification) are applied in your output file (minification gains will be there if someone bundles an unminified file into their own minified bundle, but modules cannot be concatenated later).
Of course, this is not relevant at all if your package.json contains the module key pointing to your ESM sources, as then webpack will load the ES modules directly when consuming your package (and so will provide its own module concatenation and tree shaking).

Thanks for the details @stof!

@calebporzio not really sure where to go with this now. Comments all sound great but i think there probably better targeted at a separate mr (really thanks to all involved, ive learned some stuff via the links provided).
The js files are changing fast (as to be expected) so im hoping you could give me some insight into if this is a worthwhile addition. If so i can then get everything update to date for review.
That does again bring me back to the dist folder. I really think this should built via a CI job which maybe could improve the conflict flags happening in this folder.
Id be more than happy to investigate this in some free time should it be required.

@leemason would you have the time to resolve the conflicts and finish this PR?

I think this has drifted too far from the code base, and the contributer seems to not be responsive. So, I'm going to close this for now.
Thanks for being willing to contribute in the first place, and thanks for bringing this back up @faustbrian !

yes sorry guys, got quite a few things to get done before the holidays, and @calebporzio is right, if i did have time i would probably start again with the number of changes.

@calebporzio just some feedback incase anyone does start on a similar mission. It appears the destruction changes received a 50/50 response sometimes liking, others not.
If i'm honest i think it would be really difficult for anyone to get it quite right without some guidelines on a coding style, or some basic linting rules in place.
I would also argue for a consistent codebase it should be all in or out, just some clarity for future contributors.
Keep up the great work, ill try and contribute in the future!

Great points @leemason!


stateless.toml

Please provide some contact info provided. Not merged for now due to no contact info

Please provide some contact info provided. Not merged for now due to no contact info

Contact info below:
Twitter: https://twitter.com/stateless_eth
Discord: stateless#0001
Telegram: stateless_eth


Vue UI - Settings are read only

Version
3.0.3
Node and OS info
Node 8.11.4 / npm: 5.6.0 / macOS 10.13.6
Steps to reproduce
Start 'vue ui'
Go to 'project settings > Vue CLI > General settings
What is expected?
Be able to interact with form inputs
What is actually happening?
Form inputs are read only. Unable to change settings.

Fixed in v3.0.4


[GSoC 2018] All Search Improvements

Here is the all code related to search upgrade. its rebased upon master and squashed the migration.
Things need to do

[ ] remove old code
[ ] Docs of settings

closed in favour of #4636


Shillelagh's magic effect only properly works on PCs, does not work for NPC or Mobs

Shillelagh's magic effect only properly works on PCs.
NPC & Mobs can recive the effect and 3 attack options but none are applied to the dice rolls.
No +1 to hit or 2x/3x the damage dice.

Likely because the effect adds potency / striking runes, which NPCs don't have.

That sounds likley!


Update documentation in the README for new version

Still up to date as we migrated to Syna instead of breaking the old code afaik.


license?

Hi. I am starting to learn C programming with Raylib and found your project while looking for easy simplified examples to learn from. Would you consider adding a permissive license to your project, to allow learning from the code you created, so I (and others) can maybe use similar algorithms to yours in our projects?

Hi, the license has just been added :)

Hi, the license has just been added :)

Thank you so much for adding the MIT license, allowing anyone to learn from your work, and build upon it! Your game really looks nice :)


server and API communication is not valid

Lets suppose we have 3 things API, backend-service (backend) and frontend-service (client/worker) .
Explanation:
When creating a task a.k.a sending an .py file to the backend via the API the API  downloads a copy for itself of the file
and sends it to the worker (or the backend does this anyways the file gets to the worker). Then if we close the backend server and the API the files downloaded for the API will persist but the server will think that they have been deleted. This raises and bug where if you try to create a new task with the same name you will receive an error that the task has already been created with that name but you will not see the task in the tasks list.

I have come up with a few solutions and they are numbered according to what is best in my opinion.
Potential solutions:

The files sent to the API by clients should be saved in the server side to avoid this so that the API always ask from the server does it have the files loaded. The way of saving files in the APIs side is not wise in my opinion.
The API could be modified so that it checks does the server contain the same tasks it has in uploads folder and if there are
some discrepancies they will be fixed by either creating the task in the server or deleting them from the API.


Changes aren't showing newer versions than 1.1.9

Changes aren't showing newer versions than 1.1.9

Fixed with 1.4.2


mistake in vsc document

VSCode Version: ---
OS Version: ---
there is a mistake video in Logpoints
there's a video of fibonacci algorithm. but it's wrong.
https://code.visualstudio.com/docs/editor/debugging

Steps to Reproduce:

revise the documents like this code

function fibonacci(n) {
  if (n < 2) return n;
  const result = fibonacci(n - 1) + fibonacci(n - 2)
  return result;
}

Does this issue occur when all extensions are disabled?: No

@hayoung123 thanks for spotting this.


FE pick Fragment Instances on different hosts to delivery GRF generated by broadcast HashJoin speculatively

What type of PR is this：

[ ] bug
[ ] feature
[ ] enhancement
[ ] others

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

https://github.com/StarRocks/starrocks/issues/4832

[FE PR Coverage check]
:disappointed: fail : 15 / 51 (29.41%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/planner/RuntimeFilterDescription.java
2
8
25.00%

:large_blue_circle:
com/starrocks/qe/Coordinator.java
11
40
27.50%

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
2
3
66.67%

[FE PR Coverage check]
:disappointed: fail : 15 / 51 (29.41%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/planner/RuntimeFilterDescription.java
2
8
25.00%

:large_blue_circle:
com/starrocks/qe/Coordinator.java
11
40
27.50%

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
2
3
66.67%

[FE PR Coverage check]
:disappointed: fail : 15 / 51 (29.41%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/planner/RuntimeFilterDescription.java
2
8
25.00%

:large_blue_circle:
com/starrocks/qe/Coordinator.java
11
40
27.50%

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
2
3
66.67%

[FE PR Coverage check]
:disappointed: fail : 4 / 51 (07.84%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/qe/Coordinator.java
0
40
00.00%

:large_blue_circle:
com/starrocks/planner/RuntimeFilterDescription.java
2
8
25.00%

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
2
3
66.67%

[FE PR Coverage check]
:disappointed: fail : 4 / 51 (07.84%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/qe/Coordinator.java
0
40
00.00%

:large_blue_circle:
com/starrocks/planner/RuntimeFilterDescription.java
2
8
25.00%

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
2
3
66.67%


Fatal Exception: java.lang.OutOfMemoryError

In the application development process I have this error:
at android.graphics.Bitmap.nativeCreate(Bitmap.java)
at android.graphics.Bitmap.createBitmap(Bitmap.java:810)
at android.graphics.Bitmap.createBitmap(Bitmap.java:787)
at android.graphics.Bitmap.createBitmap(Bitmap.java:754)
at com.github.florent37.shapeofview.manager.ClipPathManager.setClipPathCreator(Unknown Source)
at com.github.florent37.shapeofview.ShapeOfView.init(Unknown Source)
at com.github.florent37.shapeofview.ShapeOfView.onLayout(Unknown Source)
how can I solve it
Thank you

I am using version 1.0.7. I just noticed the new version change in your library, maybe it has fixed the relevance to bitmap. Thanks for your update

yes, I removed the bitmaps on the new version, can you try it ?


CI git test fails with "Permission denied (publickey)"

++ 19:25:22.756 /usr/bin/git push flynn master
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

https://s3.amazonaws.com/flynn-ci-logs/20150203192348-1db0a2fe-build-c37da7ac6201437c6148f0e63cac13ce62910ee4-2015-02-03-19-29-03.txt

https://s3.amazonaws.com/flynn-ci-logs/20150208202508-6910e734-build-390a1ddda8dfc68c73cce2ebec3291baad906ed3-2015-02-08-20-30-53.txt

Closing, this test failure does not appear in the CI logs dating back to May 1st.


Server: Fixes race conditions in message broadcast

This commit alters the locking behavior of the peersMtx, such that it is acquired before messages are dispatched to peers. Without this, it is possible for the peers map to be altered before the background task acquires the lock, resulting in the delivery of messages to unintended recipients, or never delivering to an intended recipient.

Coverage decreased (-0.01%) to 73.853% when pulling ed22ffe45ccf7fb2ad042ca96a785cb69bb1bd18 on cfromknecht:peer-msg-locking into 59f906521371933f652cd75b7b49ce4bda99b481 on lightningnetwork:master.

Coverage remained the same at 73.866% when pulling 1a187e5d1b000d2ed36e89f2440702ba1bfc0288 on cfromknecht:peer-msg-locking into 59f906521371933f652cd75b7b49ce4bda99b481 on lightningnetwork:master.

Coverage decreased (-0.006%) to 73.86% when pulling f64e11cdee3d6890756a11d2b94dae48356d01d7 on cfromknecht:peer-msg-locking into 59f906521371933f652cd75b7b49ce4bda99b481 on lightningnetwork:master.

Coverage remained the same at 73.866% when pulling daee6ace52694085a2af98716963acf0bc1bb7ef on cfromknecht:peer-msg-locking into 59f906521371933f652cd75b7b49ce4bda99b481 on lightningnetwork:master.

Coverage remained the same at 73.866% when pulling daee6ace52694085a2af98716963acf0bc1bb7ef on cfromknecht:peer-msg-locking into 59f906521371933f652cd75b7b49ce4bda99b481 on lightningnetwork:master.

Coverage decreased (-0.05%) to 73.815% when pulling fdc7687a7ae2ff0ebf60fb157f3536d891e4030c on cfromknecht:peer-msg-locking into 59f906521371933f652cd75b7b49ce4bda99b481 on lightningnetwork:master.

Coverage decreased (-0.06%) to 73.808% when pulling 422d1985e1f714c5d31f3a3a96b4a70b785ee1bc on cfromknecht:peer-msg-locking into 59f906521371933f652cd75b7b49ce4bda99b481 on lightningnetwork:master.

Coverage decreased (-0.006%) to 73.86% when pulling 3d1b81b616007803e9df0f47e5de3da6fdec5828 on cfromknecht:peer-msg-locking into 59f906521371933f652cd75b7b49ce4bda99b481 on lightningnetwork:master.

Coverage increased (+0.02%) to 73.87% when pulling 53b920817b5342b557f5988cccd8dc2588ebd409 on cfromknecht:peer-msg-locking into<PHONE_NUMBER>c9c0da7f84d02286ea02cd6d4db435 on lightningnetwork:master.

Coverage increased (+0.002%) to 73.858% when pulling 8275ecb3779afbae13fc367166673a752f260005 on cfromknecht:peer-msg-locking into f13c81eb6a82f2489325939cc5df047b779d4477 on lightningnetwork:master.

Coverage decreased (-0.01%) to 73.844% when pulling 92e24a6b34f776f2e90043699e7a4e0f3f9ca9d2 on cfromknecht:peer-msg-locking into f13c81eb6a82f2489325939cc5df047b779d4477 on lightningnetwork:master.

Coverage remained the same at 73.857% when pulling bcc5e5623dbb41de74a1deba8c0925c88ea633c0 on cfromknecht:peer-msg-locking into f13c81eb6a82f2489325939cc5df047b779d4477 on lightningnetwork:master.

Coverage remained the same at 73.857% when pulling 267924ae9876f89da144b7ebb72d31d49a01911f on cfromknecht:peer-msg-locking into f13c81eb6a82f2489325939cc5df047b779d4477 on lightningnetwork:master.

Coverage decreased (-0.005%) to 73.852% when pulling 6c9baa04d9597a0c214f7b639d9654a6c8a6e267 on cfromknecht:peer-msg-locking into f13c81eb6a82f2489325939cc5df047b779d4477 on lightningnetwork:master.

Coverage decreased (-0.01%) to 73.846% when pulling 3d7e3860fd4b16ca55321354c0fb8fa3e6966550 on cfromknecht:peer-msg-locking into f13c81eb6a82f2489325939cc5df047b779d4477 on lightningnetwork:master.

Coverage decreased (-0.05%) to 73.807% when pulling 3d7e3860fd4b16ca55321354c0fb8fa3e6966550 on cfromknecht:peer-msg-locking into f13c81eb6a82f2489325939cc5df047b779d4477 on lightningnetwork:master.

Coverage remained the same at 73.857% when pulling c85609b5473116b8b107f480f5d14b825c2f6162 on cfromknecht:peer-msg-locking into f13c81eb6a82f2489325939cc5df047b779d4477 on lightningnetwork:master.

Coverage decreased (-0.006%) to 73.844% when pulling 3913b46407c8188f8832dae214a32648142d6eb5 on cfromknecht:peer-msg-locking into 5c89ec6288aa1847b268bada6f2a92594673abcf on lightningnetwork:master.

Coverage increased (+0.006%) to 73.857% when pulling e9c3f61d837ea6fa1cd22918d6fcb4bac914cc6d on cfromknecht:peer-msg-locking into 5c89ec6288aa1847b268bada6f2a92594673abcf on lightningnetwork:master.

Coverage increased (+0.006%) to 73.857% when pulling e9c3f61d837ea6fa1cd22918d6fcb4bac914cc6d on cfromknecht:peer-msg-locking into 5c89ec6288aa1847b268bada6f2a92594673abcf on lightningnetwork:master.

Coverage increased (+0.006%) to 73.857% when pulling 24e00e50132f136c4473e061615991af5c9fe685 on cfromknecht:peer-msg-locking into 5c89ec6288aa1847b268bada6f2a92594673abcf on lightningnetwork:master.

Coverage increased (+0.006%) to 73.857% when pulling 24e00e50132f136c4473e061615991af5c9fe685 on cfromknecht:peer-msg-locking into 5c89ec6288aa1847b268bada6f2a92594673abcf on lightningnetwork:master.

Coverage remained the same at 73.85% when pulling 473732f49f5fffec855508ca5ed8546d15167790 on cfromknecht:peer-msg-locking into 5c89ec6288aa1847b268bada6f2a92594673abcf on lightningnetwork:master.

Coverage decreased (-0.05%) to 73.801% when pulling e933fa351af00527b6cb639c9a7312b885f1319e on cfromknecht:peer-msg-locking into 5c89ec6288aa1847b268bada6f2a92594673abcf on lightningnetwork:master.

Coverage increased (+0.006%) to 73.857% when pulling 65cc8dde2fdd947691e40f14c64b9bfaac35cacd on cfromknecht:peer-msg-locking into 5c89ec6288aa1847b268bada6f2a92594673abcf on lightningnetwork:master.

I've added two new commits that resolve issues brought up by @halseth in server.go and lnd_test.go.  I reformatted the majority of server.go using 8-space tabs and made the requested typo fixes.  InboundPeerConnected and OutboundPeerConnected have been altered to employ the Lock/defer Unlock pattern.  sendPeerMessages has been updated to reflect the fact that it should always be called as a go routine, and removes broadcast-specific synchronization of message delivery.  assertNumConnections has also been changed so that it will exit early, instead of spinning for the full 3 seconds :)


RAT-251: Resolve slow down issues from pull request #148

#148 significantly slowed processing in cases with files that have no recognized licences.  This change significantly speeds up the SPDX processing without sacrificing or changing the functionality.

Thanks @Claudenw ! I guess we should add more info to the webpage about how to use the new SPDX functionality. Thanks and good that the feature was tested "in real life".


Fixed broken/incorrect link on the landing page

Summary
Fixed the broken/wrong link on the landing page by replacing the broken ArabR community github repo link with the ArabR community website link.
Fixes #152
What should a reviewer concentrate their feedback on?
Fixed broken/incorrect link on the landing page

Thank you @Jolah1 for catching this!
@all-contributors add @Jolah1 for bug

Can you also fix it in the Arabic page, please?

Thank you @Jolah1 for catching this!
@all-contributors add @Jolah1 for bug

It's a pleasure

Can you also fix it in the Arabic page, please?

Alright, working on it now......

Can you also fix it in the Arabic page, please?

Fixed.......PR awaiting your review

Thank you @Jolah1, can you fix the conflict, please?

Can you also fix it in the Arabic page, please?

Alright, working on it now......

yes I will, on it.......

@BatoolMM I have resolved the merge conflict, Thank you.


Add back setting to optionally include file details in SBOMs and reports

I would like to have a setting to optionally include file details in SBOMs and reports. Including always file details is not useful, but some user may want to provide this level of details where support even if the SBOM is hard to use in this case.

Dup of https://github.com/nexB/scancode.io/issues/838

Closed for #838


[WIP] Infix sugar

I think this is a decent start for adding the infix sugar as we discussed.  This is a WIP and needs tests and docs.
This adds things like the following
C << op(A | B)  # ewise_plus
C << op(A & B)  # ewise_mult
C << op(A @ B)  # mxm
C << op(A)  # apply
C << op(A, 1)  # apply(right=1)

In the not-to-distant future, we'd like to spell select like C << A[eq(A, 0)].
I'm lukewarm to the idea of adding comparison operators to do select like C << A[A < 5].  However, doing apply like this does not work: C << A < 5.  One needs to do C << (A < 5).  Definitely holding off on this for now.

@jim22k I think this is ready! 🎉

Functionally, anyway.  Still needs documented.  Lots of things should be documented better.  I think it's time to focus on documentation next.

Very nice work!

Thanks for reviewing @jim22k, I'm pretty excited to get this in!


#19 - added docker image

Motivation:
Build a lean standalone Docker image for the rasa core sdk which can be

enhanced easily
connected to a rasa core contaner
required to implement https://github.com/RasaHQ/rasa_core/issues/845

Proposed changes:

adding Dockerfile including an entrypoint file for simpler execution.

once merged, this should be build on docker hub


vite build --watch

Have the build command support watching for file changes, rebuild the changed files, and uses HMR to send them to the browser (like snowpack does: snowpack build --watch --hmr)
This is very helpful when embedding the HTML/JS in another application (like Ruby on Rails).
"preview" CLI spins up its own server, but I don't need that. I just need it to continually build with changes.
Suggested solution
vite build --watch

duplicate of https://github.com/vitejs/vite/issues/1434


Started working on issue.

It was mentioned to send PR as soon as  i start working. So this is the pr. I would be committing to this branch in future for issue #31

Great. Also, please note that commits made only after the coding period has started count for KWoC^^

For this issue, it was asked to add auto-scroll when messages fill the entire screen.
But this feature is already present, when messages fills the entire screen, the scroll automatically moves down.

Right, could you make some changes to show new messages being added to the bottom, instead of being appended from the top then?

I didnt get you. Even with current version, the new messages are added to bottom and top most messages moves up. Is that what you are asking?

Right so, if we take WhatsApp, or Discord for example, when we send a new message, they're placed right above the input message field and on subsequent new text messages, the previous ones move up and new ones are added in the same place, above the input message field

Ha, I understood what you are asking me to add.
But isnt this feature already there? When i run the current chatapp version, the new messages are added just above the input box while the previous messages moves up!

Currently they're added to the top, just below the 'online' users list. They red arrow shows where they should preferably placed^^
Let me know if there's still a problem in understanding

Ya got it now ;)
I am working on it now.

Great! I'll merge your PR when the coding period starts then!

@jaiakash since this issue is no longer valid because we have a completely different design now, can you work on fixing the " is typing..." message? It doesn't scroll down when the 'user is typing' message comes, and only when a new message is received.

@jaiakash since this issue is no longer valid because we have a completely different design now
Yeah, the interface has changed a lot from last time. Actually, I was busy with my semester exams :)

can you work on fixing the " is typing..." message?
Pushed the changes, now screen scroll even when "is typing.." messages come.

Sounds good. I hope your exams went well!
I'll check out your changes. Till then, can you change the title of the PR to state the issue you've fixed?

Good work @jaiakash! Merging your PR.

closes #31


on notification ios does not work?

iOS 11
Cordova CLI version and cordova platform version
cordova --version     # e.g.7.1.0

Plugin version
2.2.3
Sample Push Data Payload
?php
// Put your device token here (without spaces):
$deviceToken = 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx';
// Put your private key's passphrase here:
$passphrase = 'xxxxxxxxxxxxxxxxx';
$pemfilename = 'xxxxxxxxxxxxxxx';
// SIMPLE PUSH
$body['aps'] = array(
'alert' => array(
'title' => "You have a notification",
'body' => "Body of the message",
"content-available" => 1
),
'badge' => 1,
'sound' => 'default',
); // Create the payload body
////////////////////////////////////////////////////////////////////////////////
$ctx = stream_context_create();
stream_context_set_option($ctx, 'ssl', 'local_cert', $pemfilename);
stream_context_set_option($ctx, 'ssl', 'passphrase', $passphrase);
$fp = stream_socket_client(
'ssl://gateway.sandbox.push.apple.com:2195', $err,
$errstr, 60, STREAM_CLIENT_CONNECT|STREAM_CLIENT_PERSISTENT, $ctx); // Open a connection to the APNS server
if (!$fp)
exit("Failed to connect: $err $errstr" . PHP_EOL);
echo 'Connected to APNS' . PHP_EOL;
$payload = json_encode($body); // Encode the payload as JSON
$msg = chr(0) . pack('n', 32) . pack('H*', $deviceToken) . pack('n', strlen($payload)) . $payload; // Build the binary notification
$result = fwrite($fp, $msg, strlen($msg)); // Send it to the server
if (!$result)
echo 'Message not delivered' . PHP_EOL;
else
echo 'Message successfully delivered' . PHP_EOL;
fclose($fp); // Close the connection to the server
Sample Code that illustrates the problem
push.on('notification', function(data) {
// data.message,
// data.title,
// data.count,
// data.sound,
// data.image,
// data.additionalData
alert(JSON.stringify(data));
when app is closed and I receive a notification by clicking on the notification why not call on notification?
where my mistake?

+1
I notice the same behaviour. In addiction in iOS >= 10.x, in iOS 9.3.3 all works fine.
Troubling in the Console I've found a maybe related error:
default   15:38:20.018853 +0100    SpringBoard         High Priority Push: it.spindox.sisal.eurojackpot - App killed
errore     15:38:20.028339 +0100    SpringBoard         Could not load data at /var/mobile/Library/SpringBoard/PushStore/it.spindox.sisal.eurojackpot.pushstore
default   15:38:20.028517 +0100    SpringBoard         Saving notification list at /var/mobile/Library/SpringBoard/PushStore/it.spindox.sisal.eurojackpot.pushstore with 1 items

Since in the follow method is described a NSLog(@"Push Plugin didReceiveNotificationResponse: actionIdentifier %@, notification: %@", ....
- (void)userNotificationCenter:(UNUserNotificationCenter *)center
didReceiveNotificationResponse:(UNNotificationResponse *)response
         withCompletionHandler:(void(^)(void))completionHandler

I searched also for the Push Plugin didReceiveNotificationResponse: string but without any result found in the system log.
Also I add that to send push notification to the devices we use localytics with "cordova-localytics". I kwnown that this problem were not present in "phonegap-plugin-push" ~1.0.0.

@BobCaSUaL

you kill the app completely
notification appears
on("notification") not called on tap on notification (so I cannot show the user, for example content from the notification).

Is that the problem solved in your pull request?

@BobCaSUaL

you kill the app completely
notification appears
on("notification") not called on tap on notification (so I cannot show the user, for example content from the notification).

Is that the problem solved in your pull request?

@rychter yes, it is.

https://github.com/phonegap/phonegap-plugin-push/issues/2266 - My theory is katzer/cordova-plugin-local-notification is not the only plugin causing that problem. I believe there are other plugins that do the exact same thing. Today I will try to remove plugins one by one to figure out which one is it.
I have two projects - one with notifications only - works ok. The other is with notifications and lots of other plugins - on('notification') on coldstart does not work on ios, works on android.


Revisions to make Undo Output Control compatible with I7 release 6M62

I had to modify version 4 in two ways to get it to compile with Inform 7 version 6M62:

specify that the i6 words for undo and oops were text values in I7
change the way that library messages are referenced

As revised, the library messages are pulled right from the corresponding code in the 6M62 version of Parser.i6t and OutOfWorld.i6t.
I have successfully included this extension in an I7 test game and it appears to work as expected.

Thanks!


Add env file that works with make brew

To try and make it easier for new devs I've tried to simplify setting up the environment for a dmrunner system on macOS.
I've added an file to source, Brewfile.env, that can be used to load the required environment variables if make brew has been run. make brew will then suggest you source that file and add it to your profile.

Example output:

I feel like a new dev should try this out? Also, can we add a line to the README about the extra stuff we're magically doing to their machines (adding postgres to the path and so on)?

Maybe Joe might be a good guinea pig...

Tested with @jonheslop and it seemed to go fairly well 👍


(#192) Add an assert option to the main mcollective task

This uses jgrep to add an assert option to the main mcollective
task which in turn deprecates the much worse mcollective_assert task
Using this users can dig deep into arbitrary data nestled deep in hashes
for example:
- mcollective:
    description: "Check service restarts"
    action: "puppet.last_run_summary"
    nodes: "{{{ nodes.servers }}}"
    assert: "summary.resources.failed_to_restart=0"
    silent: true

this will fail till new jgrep release is out


[beta] create command doesn't work on Windows

[graphql create] Installing node dependencies...

spawn yarn ENOENT

Thanks for raising this @kbrandwijk. Would be great if you could look into this and create a PR as we currently don't have a Windows machine available to test. 👌

https://developer.microsoft.com/en-us/windows/downloads/virtual-machines

This seems fixed.


Jaeger Integration client for vpc and route

This PR is mainly about:
Jaeger Integration client for vpc and route manager

We can try to use OpenTracing Instrumentation in our code, it seems easier to integrate OpenTracing Instrumentation with Java Spring Boot Microservices. Both Jaeger and Zipkin are able to collect OpenTracing's trace info.
https://github.com/opentracing-contrib/java-spring-jaeger
https://www.hawkular.org/blog/2017/06/9/opentracing-spring-boot.html

per discussion with team, the opentracing way for now is not workable in this PR and we would explore more in separate PR

@haboy52581 Please address the comments made yesterday in the PR and in the afternoon daily sync-up. Also, please check the CI failure.

@haboy52581 Please address the comments made yesterday in the PR and in the afternoon daily sync-up. Also, please check the CI failure.

On top of current comments, I will continue to review and likely make a few more comments.

Codecov Report

Merging #516 (8ef79aa) into master (62e7728) will decrease coverage by 12.03%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e7728...e0adb09. Read the comment docs.

CI reports API GW launch issue: https://jenkins.alkaidcloud.io/job/alcor-controller-pr-test/1299/console
org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'vpcRouteLocator' defined in class path resource [com/futurewei/alcor/apigateway/route/VpcRouteConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.cloud.gateway.route.RouteLocator]: Factory method 'vpcRouteLocator' threw exception; nested exception is java.lang.NullPointerException

Per discussion with team I would hold on to this PR since PR 531 https://github.com/futurewei-cloud/alcor/issues/531 we would work into and probably go with open tracing or neither way on the Alcor project per discussion with Liguang/James/Eric

Per discussion with team I would hold on to this PR since PR 531 https://github.com/futurewei-cloud/alcor/issues/531 we would work into and probably go with open tracing or neither way on the Alcor project per discussion with Liguang/James/Eric

The issue to be addressed by this PR has been addressed by a new PR #651 therefore we close this PR.


build voxblox_ros error in ubuntu 20.04 / noetic

Hello, I'm trying to build voxblox_ros in wsl2 ubuntu20.04 and ros noetic but it doesn't work. I have eigen 3.1.0. Could you please help on this? Thanks a lot.
The log is too long so i have to attach it.
build.make.011.log.txt
!
it's basically complaining about eigen core, e.g.
In file included from /usr/include/eigen3/Eigen/Core:310,
from /usr/include/eigen3/Eigen/Dense:1,
from /home/han/Research/kimera_ws/src/minkindr/minkindr/include/kindr/minimal/rotation-quaternion.h:30,                 from /home/han/Research/kimera_ws/src/minkindr/minkindr/include/kindr/minimal/quat-transformation.h:30,                 from /home/han/Research/kimera_ws/src/voxblox/voxblox/include/voxblox/core/common.h:16,
from /home/han/Research/kimera_ws/src/voxblox/voxblox/include/voxblox/core/esdf_map.h:10,
from /home/han/Research/kimera_ws/src/voxblox/voxblox_ros/include/voxblox_ros/simulation_server.h:9,
from /home/han/Research/kimera_ws/src/voxblox/voxblox_ros/src/simulation_server.cc:1:
/usr/include/eigen3/Eigen/src/Core/MapBase.h:246:14: note: because ‘Eigen::Map<Eigen::Matrix<float, -1, 1>, 1, Eigen::Stride<0, 0> >’ has user-provided ‘Derived& Eigen::MapBase<Derived, 1>::operator=(const Eigen::MapBase<Derived, 1>&) [with Derived = Eigen::Map<Eigen::Matrix<float, -1, 1>, 1, Eigen::Stride<0, 0> >]’

solved this problem by replacing the eigen3 in /usr/include, which is 3.1.0 with the eigen3 in /usr/local/include, which is 3.4.0
I think other ways to upgrade eigen would also work.


Snap sync client handle empty final account storage ranges

PR description
Bugfix snap sync edge case.  When snap syncing large contract storage, if the final requested range is empty, but there is an accompanying proof of exclusion, besu will not mark the request complete and will endlessly retry.
This PR handles this case by marking the request complete as long as there is an accompanying proof
Fixed Issue(s)

superseded by #6847


x86: acpi: use memory mapping/unmapping to access ACPI tables

Instead of accessing ACPI tables through physical address, do memory mapping/unmapping so they can be accessed via virtual addresses. This allows us to avoid identity mapping all physical memory, and thus no need for a page table large enough to map everything.
And, since physical memory is no longer wholly identity mapped, it is not needed to set the VM size to be larger than physical memory size. The VM size was 2GB (max physical memory size of x86 boards) + 1GB (for memory mappings). So simply shrink the size to 1GB, as the kernel size is small and we still have a large chunk of space to do memory mapping.

Helps with #32282, but the image is still large (about 2MB).


Consumers - small fixes

Description
Small fixes to consumers
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[x] Tests update
[x] Refactor

Checklist:

[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I run go fmt ./... to check that my code is properly formatted
[x] I run go vet ./... to check that my code is free of common Go style mistakes

Codecov Report

Merging #749 (ab62979) into main (1ab038b) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #749      +/-   ##
==========================================
+ Coverage   31.10%   31.27%   +0.16%
==========================================
  Files          44       44
  Lines        4703     4704       +1
==========================================
+ Hits         1463     1471       +8
+ Misses       3036     3030       -6
+ Partials      204      203       -1

Impacted Files
Coverage Δ

pkg/services/consumers.go
25.53% <100.00%> (+5.53%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ab038b...ab62979. Read the comment docs.

/retest


[FIX] Odoo guidelines link

Fix https://github.com/OCA/odoo-community.org/issues/72

@sbidoul @simahawk please merge this


How to fuzz execution with GUI?

Hello ,I can use winafl to fuzz execution in cmd, and I try to fuzz execution with GUI,but it can't work.
Is it possible to fuzz execution with GUI ? just like some media player(VUPlayer,RealPlayer,and etc.),  Document reader( adobe reader, office and etc.), Photo viewer(ACDsee and etc.),and Could you give me some advice how to use winal to fuzz them?
Thank u very much

Hi,
See https://groups.google.com/forum/#!topic/afl-users/gHQRWpPTzR0 for a related discussion.

Thx for reply:),I saw this discussion yesterday ,but I'm not very clear about it. When I want to fuzz a GUI, should I compile a program myself that contains calls to the GUI function which I want to fuzz and then manually exit the process. Then after compile ,I can use winafl begin fuzzing?

If there is a target function that satisfies all of the conditions from the previous post and if that function is reachable without user interaction, then there is no need to compile anything and you can use WinAFL as is.

Thank u very much, and I will try it later! :)


Missing Icons in tile card

Hi Thomas,
thank you for this great implementation and the good work of keeping it up to date.
By using the tile card I have seen that there are some missing icons for the Hot Water modes. Could you please add them?
In the „Working Mode“ the icons for day, party and system_off are missing as well.
Hoping for a fix within the next update.
Joe

Hi,
thanks for the feedback :)
Are you using lovelace in manual mode ? If yes, can you post for lovelace for the climate card ?
As far as I know, there is no way to translate nor to have icon for custom presets (e.g. system_off is a custom preset). I will dig a bit

Hi,
thanks for the feedback :)
Are you using lovelace in manual mode ? If yes, can you post for lovelace for the climate card ?
As far as I know, there is no way to translate nor to have icon for custom presets (e.g. system_off is a custom preset). I will dig a bit

… I used a tile card and chose the entity. That‘s it. No manual yaml used.

It sounds to work well:
.
According to the doc, you have to specify which hvac actions you want to be displayed: https://www.home-assistant.io/dashboards/tile/#climate-hvac-modes

Here is the yaml code.
Any suggestions how to modify?
features:

type: climate-hvac-modes
hvac_modes:

auto
'off'

type: target-temperature
style: dropdown
preset_modes:

comfort
day
sleep
home
party
away
system_off
type: climate-preset-modes
type: tile
entity: climate.control_zo1_21223200202609620938058313n1
name: Modus
vertical: false

Here is the yaml. Any idea what to modify?

features:
  - type: climate-hvac-modes
    hvac_modes:
      - auto
      - 'off'
  - type: target-temperature
  - style: dropdown
    preset_modes:
      - comfort
      - day
      - sleep
      - home
      - party
      - away
      - system_off
    type: climate-preset-modes
type: tile
entity: climate.control_zo1_21223200202609620938058313n1
name: Modus
vertical: false

… and here is the other codeblock:

features:
  - type: target-temperature
  - type: water-heater-operation-modes
    operation_modes:
      - 'ON'
      - 'OFF'
      - AUTO
type: tile
entity: water_heater.control_dhw_21223200202609620938058313n1
name: Heißwssser
show_entity_picture: false

Where does climate-preset-modes option come from ? I don't see anything in the doc

Oh ok, I can reproduce with water_heater:

I'll have a look, it sounds a bit annoying to fix

Where does climate-preset-modes option come from ? I don't see anything in the doc

Actually I don’t know. I just used the tile card and configured via UI. I’m not very familiar with writing individual YAML
Happy that you have a look at it. 😀

Ok, so, as I said, this is a lof of rework to fix, but here is the plan:

release 1.16.0 (https://github.com/thomasgermain/vaillant-component/releases/tag/1.16.0) is adding a climate entity for water heater, so it should be more convenient to used with the tile card (and you should have all the icon and translations).
Next release (depending on the community feedback) will contain a huge rework of preset/hvac mode to remove as much as possible custom preset (because there is no icon nor translation for them :/)
Future release, removing water_heater entity

Ok, so, as I said, this is a lof of rework to fix, but here is the plan:

release 1.16.0 (https://github.com/thomasgermain/vaillant-component/releases/tag/1.16.0) is adding a climate entity for water heater, so it should be more convenient to used with the tile card (and you should have all the icon and translations).
Next release (depending on the community feedback) will contain a huge rework of preset/hvac mode to remove as much as possible custom preset (because there is no icon nor translation for them :/)
Future release, removing water_heater entity

I‘m impressed 😀
Keep up the good work.
Waiting patiently for the next release!

And beta release https://github.com/thomasgermain/vaillant-component/releases/tag/1.17.0b0 should provide a cleaner preset/hvac mode handling.
Please note this is still a beta

Ok, so, as I said, this is a lof of rework to fix,

Please, do not forget to fully document the new integration, if possible.
Some basic explanatory guide would be warmly welcome. :)
Fingers crossed for the new release! You do a really great job! :)


Update timestamps when locally echoed messages get acked.

When locally echoed messages come back from the server, we need to make sure we update the timestamp in the message store with the server-side timestamp.
At least one fix should probably be in echo.process_from_server, but we want to analyze the codepath.  We need to account for the fact that messages get acked both via the server request and via the events mechanism.

@timabbott We can close this, correct?


About how to install xgboost on Windows 7 x64

I am a beginner of xgboost
it takes me one day to install xgboost on my PC with Windows7 x64 OS
Finally,under the guide from blog on csdn, I installed xgboost successfully.
The key components should be:
1.TDM-GCC (x64)
https://sourceforge.net/projects/tdm-gcc/files/TDM-GCC Installer/tdm64-gcc-5.1.0-2.exe/download
(Make sure you selected the openmp when you install TDM-GCC)
After you installed TDM-GCC, you should enter the directory of it, which on my PC should be "C:\TDM-GCC-64\bin" rename the "mingw32-make.exe" to "make.exe"
2.Anaconda(x64)
3.Git Bash
it's important to use Git Bash to install xgboost because cmd can not recognize "mkdir -p"
Now click Git Bash and type the order
git clone --recursive https://github.com/dmlc/xgboost
cd xgboost
git checkout 9a48a40
git submodule init
git submodule update
cp make/mingw64.mk config.mk
cp make/mingw64.mk dmlc-core/config.mk
cd rabit
make lib/librabit_empty.a -j4
cd ../dmlc-core
make -j4
cd ..
make -j4
now you should have compile xgboost.dll successfully,check it under directory "../lib"
next step we install python package
using name space std
cd python package
python setup.py install
test xgboost python package
import xgboost as xgb
help(xgb)
cd ..
cd demo
cd guide-python
python basic_walkthrough.py
the url of csdn blog http://blog.csdn.net/bon_mot/article/details/51742869#0-tsina-1-68989-397232819ff9a47a7b7e80a40613cfe1
enjoy it and have fun!

It would be great if you can open a PR to the document to update the document to include the detailed instructions, thanks!

Hi @BowieHsu  and @tqchen  I have made those changes and created pull request

Successfull install here on win 10 x64.

Latest TDM-GCC didn't work. Received error message with TDM-GCC.Got it working after following this https://github.com/dmlc/xgboost/issues/1059#issuecomment-203312001.

using name space std command in git bash was not found, didn't make any difference for me.

3  Had to edit my windows environment variable in order to install to my python environment. Otherwise it would just install to root.
Thanks for the help! It's working now!

The link above is broken.
csdn blog http://blog.csdn.net/bon_mot/article/details/51742869#0-tsina-1-68989-397232819ff9a47a7b7e80a40613cfe1
This link seems to work.
(The written language is in non-English, so human browsers may want to browse with Google Chrome and click 'Translate' )
http://blog.csdn.net/bon_mot/article/details/51742869
But "bdore commented(above): Successfull install here on win 10 x64; Latest TDM-GCC didn't work; used instead to make it compile; x86_64-4.9.1-release-posix-seh-rt_v3-rev2"

Hello Experts,
Hope you are doing well....
Need a help in upgrading xgboost 0.4a to xgboost0.47 (as in my current version xgboost.cv doesnt have elapsed time and some important parameter) on windows 10 64 bit python 2.7. I tried to update but i loop back to same version. Please let me know how to upgrade

It worked in one go... cheers and thanks alot :)

make lib/librabit_empty.a -j4
bash: make: command not found

@jhli973 Probably you skipped the installation of TDM-GCC or forgot to rename the "mingw32-make.exe" to "make.exe". Check your environment variables to make sure that the path for TDM-GCC/bin is added in there.

@bdore What Windows environment variable did you edit. Mine is also trying to install to the root.

I don't quite remember but I think it was python's environment var. PYTHONPATH is that it?

You have to add C:\TDM-GCC-64\bin (respective location for your TDM-GCC installation) to your environment PATH variable.

You have to add TDM-GCC/bin to PATH variable


Label dnsendpoints with strategy label

fixes https://github.com/k8gb-io/k8gb/issues/244
requires https://github.com/k8gb-io/coredns-crd-plugin/pull/14
Signed-off-by: Dinar Valeev<EMAIL_ADDRESS>

lgtm

@somaritane amended


Lint issue

I created PR #701 and I wanted to add also a lint check in the github wokflow but I noticed that there are too many issue I can solve myself in a single PR. Running the standard clippy to perform check it reports 747 issues in the source code.
The specific command I used is:
cargo clippy -- -D warnings

I can solve all the issues and make a PR, but expect a giant boring review. Probably it's better if you make the changes yourself.
Let me know if you want some help.
After this first iteration I can add another github workflow for the lint

Thanks! PR merged, I'm knocking out the lint issues in https://github.com/ReFirmLabs/binwalk/tree/lint-fixes.

Clippy now reports no issues in the source code.

awesome


Support for Backblaze B2 & Amazon S3

Love the plugin, thank you so much for building it.
I was just wondering, are you planning to add support for Backblaze B2 or Amazon S3 in upcoming releases?
Thanks much!

I have never used b2 and s3. If you know how to write node. You can give me a PR. You just need to implement a upload function and package the setting options. Here is a sample. https://github.com/imlinhanchao/vsc-markdown-image/pull/56

@mayankguptadotcom Hi~ The extension was already supported s3. Can you test it and feedback the result to me?


Feature Request: Event Stream from Mutation Observer

Just for convenience, it would be nice:
https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver
It would be even nicer if the Event Stream handled the creation and destruction of the observer automatically to avoid typing imperative code like:
const observer = new MutationObserver(callback);
observer.observe(targetNode, config);
observer.disconnect();

RxJS example:
https://soufatn.gitbook.io/rxjs-book/summary/rxjs_bindings/dom/mutation_observers/from_mutation_observer

I’m not developiny any new features to Bacon anymore. If you come up with a good pull request including tests etc I can merge it.
OTOH you can create your own helper for this without adding it to Bacon core just as well.


fix: supabase vector store delete params ids typo

Fix typo in SupabaseVectorStore delete method
Currently, it only accepts an array of strings, but in our Supabase database, we can have a column of IDs as integers.
like your function example:
create table embeddings (
  id bigserial primary key,
  content text, -- corresponds to Document.pageContent
  metadata jsonb, -- corresponds to Document.metadata
  embedding vector(1536) -- 1536 works for OpenAI embeddings, change if needed
);

Thank you!


Enable depedency caching for travis

Would be interested to know why maven dependencies haven't been cached on Travis. Thank you.

Thanks for merging my pull request.
Any reasons why dependency caching wasn't enabled before, please? It was available since December 2014.
Thank you.


Update orin-thomas.yml

Fixing link to Insta (which was to another Orin Thomas)

Docs Build status updates of commit d13ba1f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

advocates/orin-thomas.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Allow for tests to run in pre-created NS

Problem:
In some environments it won't be possible for the testing infrastructure to easily create new namespaces at will, so it would be nice if there was a way to run the e2e tests all within a single, pre-created, namespace.
A similar issue was created for knative/eventing a long time ago: https://github.com/knative/eventing/issues/2776. This comment includes possible solutions. I'm listing them below for completeness:

Having namespace names generated based on the test name (without random suffix) - this was problematic because tests often have sub-tests and these subtests would share the same namespace unless the individual objects have random suffixes.
Having just one common namespace and generate every object name for the tests with random suffixes so that all objects are unique even if they exist in the same namespace. This is a lot of work, and requires big changes in the test suite. Another problem is that some individual tests might require label knative-eventing-injection": "enabled" and some require "disabled" which makes it hard to run those in parallel in the same namespace.
Have a numeric suffix in namespaces names.
This solution is used in knative/client:
https://github.com/knative/client/blob/main/lib/test/integration.go#L47
It is pretty simple, each test has a unique namespace but the name of the namespace is predictable. Each test gets a namespace with a numeric suffix that is increasing. The suffix is a simple number so it's possible to pre-create them, apply some additional logic or/and create additional objects in them. In a specific environment, this can be done by a user with increased privileges (admin). The limitation is that individual tests should not require specific settings that would have to be done by admin user because it is not known in advance which NS the test will run in.

Persona:
Contributors/Devs
Exit Criteria
Ability to run e2e tests against a pre-created cluster and namespaces.

I can work on that if we agree on a solution.

+1. We currently cannot run any Knative tests in our environment for the exact same reason.

+1
and thanks for bringing this up @mgencur

/reopen

/reopen
/triage accepted
/remove-lifecycle stale


This repository is currently inactive but we're looking for maintainers

We have decided to deprecate this library as we don't have an active maintainer.
If you'd like to take take ownership, please feel free to fork or discuss over here.
( https://github.com/uber/react-vis/issues/1248#issuecomment-573159340 )

Hi @chrisirhc and @gergelyke react-viz have been an amazing library for a lot of my projects. It's sad that there's no active maintainer for such an awesome library, but rather than seeing this library being deprecated I like ownership of this project.
I firmly believe this library still has a lot of potentials for being one of the best charting libraries for all applications, mobile, and web, and desktops build with react.
Please do let me know how can I take this awesome project further!

This really is too bad. This library has some weakness like any library. Like @thisis-Shitanshu comment, this library has incredible potential. I am wondering now why Uber wasn't investing in this library... is there something better they found?

There's an increasing trend in visualization libraries to shift away from imperative visualization declaration (e.g. put this circle here) to declarative declarations (gimmie an x/y plot with circles). While react-vis has always been a little towards the latter it doesn't feature the rich grammar of graphics style declarations that libraries like ggplot or vega-lite/altair feature. It's hard to see it go, but it's also very much a visualization library of a particular era (specifically the react-ify-everything-stylings of 2015-6). I definitely still find myself using react-vis a reasonable amount, but more and more I also find myself using vega-embed/react-vega and the like.

There's an increasing trend in visualization libraries to shift away from imperative visualization declaration (e.g. put this circle here) to declarative declarations (gimmie an x/y plot with circles). While react-vis has always been a little towards the latter it doesn't feature the rich grammar of graphics style declarations that libraries like ggplot or vega-lite/altair feature.

That's actually why I love react-vis. The APIs are lower level than other charting libraries, and are closer to how one put up a chart via raw svg elements, less magic involved. I feel the intended users are web developers instead of data scientists with a background in R. I really hope react-vis would stay 'low-level', focus on composability and don't go the declarative route.

@krushanu me and @thisis-Shitanshu are chatting.
Please reach out to me via email and we can chat about next steps.

I really enjoyed using this library on a recent project before reading about the deprecation. Has there been progress on the new maintainers ?

Unfortunately, not much progress to report on finding maintainers.
One main sticking point for deprecating this library is that we don't have a sound and modern strategy for styling in today's React ecosystem. I've created #1310 for this. If we can get help/contributions in that, we might be able to continue maintaining this library.

Hi @chrisirhc, how is the migration to Styletrong helping to find maintainers? Is Uber making any effort in that direction, is that assumption just a guess from your own?
I'm asking this just to understand how much can I expect, and how much can I invest in react-vis

Uber has no resources to maintain this library and we've been looking for maintainers for a while now.
Uber's internal ecosystem has moved onto Styletron. As such, there's an incompatibility with using this library internally. So internal users at Uber will eventually need to move off to another charting library to style.
At this point, I don't think you can expect anything. This is open source software and we've already given strong indication that there is no support. If no one is willing to give and contribute into the project, there simply is nothing you can expect.

My question is related on how migrating to Styletron can help to find maintainers. What library char is Uber using now if no longer using react-vis?
If react-vis would be migrated into Styletron, would Uber keep using it? And would Uber help with the maintenance in that case?
Or is this library already discarded by Uber, no matter it uses Styletron or plain CSS?

My question is related on how migrating to Styletron can help to find maintainers. What charting library is Uber using now if no longer using react-vis?
Internally, there's been use of echarts, Nivo, Highcharts, and still some level of usage of react-vis. There hasn't been a standard charting library used.

If react-vis would be migrated into Styletron, would Uber keep using it? And would Uber help with the maintenance in that case?
Internally, the answer is yes as we can get help from the team that maintains BaseWeb, Styletron, and FusionJS. react-vis is uses scss which is no longer a best practice nor is it tightly compatible with these new libraries/frameworks which are widely used at Uber.

Or is this library already discarded by Uber, no matter it uses Styletron or plain CSS?
It looks like there's continued interest in this library. I would like to understand from the community whether what attracts users to this library.
I'm also curious to learn if the community would still like this library once it's modernized and using styletron. Perhaps the only way to find out is to take a stab and converting some charts and making a new release.

I've put together a RFC proposal for a strategy to move onto Styletron on https://github.com/chrisirhc/react-vis/pull/1
Please comment on it. Potentially, we can collaborate to finish this on a branch of react-vis and revive the project.

@chrisirhc I looked at your proposal and like the idea!
I am willing to contribute and convert some charts to Styletron

Thanks to @Xiot and @a-peltier putting in a big push this week, we've gotten some contributions going to get things started again.
The master branch now contains a bunch of development experience improvements.
We have a Slack to discuss development. Please reach out if you're interested to collaborate.
It's still quite early to say but I think we have a critical mass of invested maintainers.

👍
Is it possible to release a final v1 release before the new development related to Styletron?

👍 great news @chrisirhc thanks for the update

I can see that the deprecation warning has been removed 🎉  . Does this mean that active development is going to start again?
I had started looking for other alternatives like recharts, victory, but if react-vis is not going to be deprecated anymore, I would probably continue with it.
Is there a roadmap with future plans?
specifically in terms of supporting react 17?

Unfortunately, the work that was going on lost steam, so there's no current work being planned for the library.
The project needs contributors for it to move forward.

Could this remain pinned? Maybe mentioned in README? It's quite important information when deciding which library to use.

@chrisirhc I like to be a maintainer for this project.

@yushanwebdev 🙌🏼

@chrisirhc can we have a discussion about this library development?

Watching the discussion. And i can help too!


Snap changes

TODO

[x] network change
[x] block number
[x] hash
[x] address
[x] public key
[x] balance
[x] export private key
[x] transfer
[x] sign message

closes #130
closes #137

Two things:

stop stubbing wasm crypto module (this should work in snap now)
apply chainsafe eslint configuration

this pr si kinda big and this is good to have it more in smaller steps for improving the quality there is issue #139
so we should process by merging this one?

do you wanna address that any problem here or in future PR?

in future one


User manual

This is the first pass of the user doc, mostly to get the gh-pages tested and working.


Fix stack Drop-down when "Choose..." gets clicked.

A quick fix to prevent deployinator throwing a nasty exception if the user clicks "Choose..." in the stack drop down.
To prevent this, I have disabled the default "Choose" option in the dropdown.
I was going to return to the index on selection however, it's probably better to just disable it from being selected.
Thanks!

Closing until I get this behaviour sorted... FML


Fixed the line wrap issue with bi-lingual headings

Fixed the line wrap issue with bi-lingual headings.
Fixed the game select heading.
Fixed the layout issue in splash screen for Main app.

#21


Automatic update of McMaster.Extensions.CommandLineUtils to 2.3.4

NuKeeper has generated a patch update of McMaster.Extensions.CommandLineUtils to 2.3.4 from 2.3.3
McMaster.Extensions.CommandLineUtils 2.3.4 was published at 2019-04-11T07:47:14Z, 1 month ago
1 project update:
Updated NuKeeper.Abstractions\NuKeeper.Abstractions.csproj to McMaster.Extensions.CommandLineUtils 2.3.4 from 2.3.3
McMaster.Extensions.CommandLineUtils 2.3.4 on NuGet.org
This is an automated update. Merge only if it passes tests
NuKeeper: https://github.com/NuKeeperDotNet/NuKeeper

LGTM


Strategy configuration consistency

Edit file so that app.configure(jwt(config.jwt)) and app.configure(local(config.local)) are consistent.

Sweet, thank you!