Enable placeholders support in all query builder methods

Currently only Where method accepts args as placeholder values
func (b *SelectBuilder) Where(pred interface{}, args ...interface{}) *SelectBuilder {
    b.whereParts = append(b.whereParts, newWherePart(pred, args...))
    return b
}

Other methods like GroupBy can not accept placeholdered data
// GroupBy adds GROUP BY expressions to the query.
func (b *SelectBuilder) GroupBy(groupBys ...string) *SelectBuilder {
    b.groupBys = append(b.groupBys, groupBys...)
    return b
}

Please add placeholders support to these methods to provide means for building rich SQL statements.

Can you list all methods that need it? I will try to implement it.

I'm also desperately in need of args support in GROUP BY and ORDER statements

I'll look into that :-)
On Thu, Apr 20, 2017, 5:23 PM bbrodriges<EMAIL_ADDRESS>wrote:

I'm also desperately in need of args support in GROUP BY and ORDER
statements
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/elgris/sqrl/issues/1#issuecomment-295648788, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AE_mfVka4ne-Fe9A6y5H9wKfK6MbT309ks5rxyQsgaJpZM4H-vC5
.

@bbrodriges @vearutop How do you see placeholders usage? It would be nice if you provide a couple of examples.
From my point of view GROUP BY clause (for instance) receives a list of columns and additional options (like ASC or DESC). And those can be passed as strings.

Group by is often used with aggregate functions.
On Mon, May 15, 2017, 12:55 AM Ivan Kirichenko<EMAIL_ADDRESS>wrote:

@bbrodriges https://github.com/bbrodriges @vearutop
https://github.com/vearutop How do you see placeholders usage? It would
be nice if you provide a couple of examples.
From my point of view GROUP BY clause (for instance) receives a list of
columns and additional options (like ASC or DESC). And those can be
passed as strings.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/elgris/sqrl/issues/1#issuecomment-301325125, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AE_mfWM9ykhLK7ki8rEPxcFhShUu4XXJks5r5zIDgaJpZM4H-vC5
.

How about the FROM clause? E.g. when using derived tables (subqueries in the FROM Clause)

Missing placeholders' support for FROM clause.


Failed to verify Helm chart Images.lock when unwrapping

Describe the bug
This might be a intentional beheaviour and me simply using this plugin wrong. When I'm unwrapping a chart, I'm getting the following error:
Failed to push images: failed to verify Helm chart Images.lock: Images.lock does not validate:
Helm chart "benthos": image "localhost:5000/jeffail/benthos:4.11.0": digests do not match:
- sha256:e2fa170d1d0c2e7bf5c89986b6e5de471fe6499f231d6f8e9c1f31c4350353b0
+ sha256:85689f09ddac1449188c9b9c50138027ff476bab81e39d4229f28eb72793314b
Helm chart "benthos": image "localhost:5000/jeffail/benthos:4.11.0": digests do not match:
- sha256:244e9c77b90ec18e692acf162c55060156b1d36a820d19a8606f0a98e55d4ee3
+ sha256:f794f3b17252736664244d508c6ffc10f05619cc6d09bf4c4d465d1815e0afa7

Reproduction steps
Setup a OCI-based registry locally using docker:
docker run -d -p 5000:5000 --restart=always --name registry registry:2

Run the following script
#!/bin/bash

helm repo add temp --force-update https://benthosdev.github.io/benthos-helm-chart/
helm repo update

helm pull temp/benthos --version 0.8.0 --untar --untardir .

# This helm chart isn't annotated by default, so I'm manually doing this here
images_override=$(cat <<-END
- name: benthos
  image: docker.io/jeffail/benthos:4.11.0
END
)
yq -i e ".annotations.images |= \"$images_override\"" ./benthos/Chart.yaml

helm dt wrap  ./benthos
helm dt unwrap  benthos-0.8.0.wrap.tgz oci://localhost:5000 --yes

After this script has ran, a new directory named benthos is present in the current working directory.
.
└── benthos/
│   ├── images/
│   │   ├── 244e9c77b90ec18...tar (linux/arm64)
│   │   └── e2fa170d1d0c2e7...tar (linux/amd64)
│   └── Images.lock
│   └── ....
└── benthos-0.8.0.wrap.tgz
When untaring benthos-0.8.0.wrap.tgz you get the same content as ./benthos.
Expected behavior

The helm chart and docker images is being relocated and pushed to the local registry

The benthos-0.8.0.wrap.tgz wound have the Image.lock relocated and Image.lock look like this:

apiVersion: v0
kind: ImagesLock
metadata:
  generatedAt: "2023-11-30T09:27:39.313962408Z"
  generatedBy: Distribution Tooling for Helm
chart:
  name: benthos
  version: 0.8.0
  appVersion: 4.11.0
images:
  - name: benthos
    image: localhost:5000/jeffail/benthos:4.11.0
    chart: benthos
    digests:
      - digest: sha256:e2fa170d1d0c2e7bf5c89986b6e5de471fe6499f231d6f8e9c1f31c4350353b0
        arch: linux/amd64
      - digest: sha256:244e9c77b90ec18e692acf162c55060156b1d36a820d19a8606f0a98e55d4ee3
        arch: linux/arm64

instead of this:
apiVersion: v0
kind: ImagesLock
metadata:
  generatedAt: "2023-12-05T10:32:00.611186491Z"
  generatedBy: Distribution Tooling for Helm
chart:
  name: benthos
  version: 0.8.0
  appVersion: 4.11.0
images:
  - name: benthos
    image: docker.io/jeffail/benthos:4.11.0
    chart: benthos
    digests:
      - digest: sha256:e2fa170d1d0c2e7bf5c89986b6e5de471fe6499f231d6f8e9c1f31c4350353b0
        arch: linux/amd64
      - digest: sha256:244e9c77b90ec18e692acf162c55060156b1d36a820d19a8606f0a98e55d4ee3
        arch: linux/arm64

Additional context
I'm able to produce the digests found in the error, when doing the following addtional steps(after the bash script previously mentioned):
> helm dt charts relocate benthos/ oci://localhost:5000
> helm dt images lock ./benthos
> cat Images.lock

apiVersion: v0
kind: ImagesLock
metadata:
  generatedAt: "2023-12-05T13:48:53.107936871Z"
  generatedBy: Distribution Tooling for Helm
chart:
  name: benthos
  version: 0.8.0
  appVersion: 4.11.0
images:
  - name: benthos
    image: localhost:5000/jeffail/benthos:4.11.0
    chart: benthos
    digests:
      - digest: sha256:85689f09ddac1449188c9b9c50138027ff476bab81e39d4229f28eb72793314b
        arch: linux/amd64
      - digest: sha256:f794f3b17252736664244d508c6ffc10f05619cc6d09bf4c4d465d1815e0afa7
        arch: linux/arm64

So this seems to me that the relocate changes the digest of the images. I'm assuming this is some metadata within the images that is changed.
However this change seems to be messing with the actual digest which is used when comparing.

Hi @RasmusGodske. Verification usually will fail when the digests that are in the lock file don't match the digests of the images that the user has asked dt to push.
When running relocate , what dt does is to modify the container image references found at different places like Chart.yaml or values.yaml, so indeed it modifies the Chart. When you then run lock afterwards, that generates a lock from the relocated chart which well, it will cause such inconsistency.
This is probably our bad at documentation. wrap and unwrap are meant to be used together, and not with the "finer grained" commands. Also lock is always the first command you would run after annotate. Only then you should run relocate and not the other way around.
Technically, you can reproduce a wrap -> unwrap with: annotate -> lock -> verify -> pull -> relocate -> push -> verify and then manually pushing the chart to a registry with helm or crane. Wrap and unwrap just try to do all that for you.

Hello @mpermar. Thanks for the quick response, that makes perfect sense.  However I have tried using wrap and unwrap together, which caused the same problem. This led me down the path of using the "fine grained" commands.
This is the modified bash script, using just wrap and unwrap.
#!/bin/bash

helm repo add temp --force-update https://benthosdev.github.io/benthos-helm-chart/
helm repo update

helm pull temp/benthos --version 0.8.0 --untar --untardir .

######### Manually Annotating Chart.yaml #########
images_override=$(cat <<-END
- name: benthos
  image: docker.io/jeffail/benthos:4.11.0
END
)

yq -i e ".annotations.images |= \"$images_override\"" ./benthos/Chart.yaml

helm dt wrap ./benthos
helm dt unwrap  benthos-0.8.0.wrap.tgz oci://localhost:5000 --yes

output:
"temp" has been added to your repositories
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "temp" chart repository
...Successfully got an update from the "stable" chart repository
...Successfully got an update from the "benthos" chart repository
...Successfully got an update from the "openebs-jiva" chart repository
...Successfully got an update from the "vmware-tanzu" chart repository
...Successfully got an update from the "traefik" chart repository
...Successfully got an update from the "grafana" chart repository
...Successfully got an update from the "bitnami" chart repository
Update Complete. ⎈Happy Helming!⎈
 »  Wrapping Helm chart "./benthos"
    ✔  Images.lock file written to "/home/godske/Documents/repositoriesoci-container-registry-storage/test/benthos/Images.lock"
    »  Pulling images into "/home/godske/Documents/repositories/oci-container-registry-storage/test/benthos/images"
       ✔  All images pulled successfully
    ✔  Compressed into "/home/godske/Documents/repositories/work/oci-container-registry-storage/test/benthos-0.8.0.wrap.tgz"

 🎉  Helm chart wrapped into "/home/godske/Documents/repositories/oci-container-registry-storage/test/benthos-0.8.0.wrap.tgz"
 »  Unwrapping Helm chart "benthos-0.8.0.wrap.tgz"
    ✔  Helm chart uncompressed to "/tmp/chart-3226158309/at-wrap3259428596"
    ✔  Helm chart relocated successfully
    »  The wrap includes the following 1 images:

       localhost:5000/jeffail/benthos:4.11.0

    »  Pushing Images
       ✔  All images pushed successfully
    ✘  Failed to push images: failed to verify Helm chart Images.lock: Images.lock does not validate:
      Helm chart "benthos": image "localhost:5000/jeffail/benthos:4.11.0": digests do not match:
      - sha256:e2fa170d1d0c2e7bf5c89986b6e5de471fe6499f231d6f8e9c1f31c4350353b0
      + sha256:85689f09ddac1449188c9b9c50138027ff476bab81e39d4229f28eb72793314b
      Helm chart "benthos": image "localhost:5000/jeffail/benthos:4.11.0": digests do not match:
      - sha256:244e9c77b90ec18e692acf162c55060156b1d36a820d19a8606f0a98e55d4ee3
      + sha256:f794f3b17252736664244d508c6ffc10f05619cc6d09bf4c4d465d1815e0afa7
Failed to push images: failed to verify Helm chart Images.lock: Images.lock does not validate:
Helm chart "benthos": image "localhost:5000/jeffail/benthos:4.11.0": digests do not match:
- sha256:e2fa170d1d0c2e7bf5c89986b6e5de471fe6499f231d6f8e9c1f31c4350353b0
+ sha256:85689f09ddac1449188c9b9c50138027ff476bab81e39d4229f28eb72793314b
Helm chart "benthos": image "localhost:5000/jeffail/benthos:4.11.0": digests do not match:
- sha256:244e9c77b90ec18e692acf162c55060156b1d36a820d19a8606f0a98e55d4ee3
+ sha256:f794f3b17252736664244d508c6ffc10f05619cc6d09bf4c4d465d1815e0afa7
Error: plugin "dt" exited with error

Worth mentioning that I have tried running it with a redis helm chart from a OCI based registry which runs without any problems.
Example:
#!/bin/bash

helm pull oci://registry-1.docker.io/bitnamicharts/redis --version 18.1.5 --untar --untardir .

helm dt wrap ./redis
helm dt unwrap  redis-18.1.5.wrap.tgz oci://localhost:5000 --yes

Output:
Pulled: registry-1.docker.io/bitnamicharts/redis:18.1.5
Digest: sha256:892a93be15b28f4a03870c31afbaa73578c5bcf1eeb3f32d8d5649d1be9e51ee
 »  Wrapping Helm chart "./redis"
    ✔  Images.lock file written to "/home/godske/Documents/repositories/work/oci-container-registry-storage/test/redis/Images.lock"
    »  Pulling images into "/home/godske/Documents/repositories/work/oci-container-registry-storage/test/redis/images"
       ✔  All images pulled successfully
    ✔  Compressed into "/home/godske/Documents/repositories/work/oci-container-registry-storage/test/redis-18.1.5.wrap.tgz"

 🎉  Helm chart wrapped into "/home/godske/Documents/repositories/work/oci-container-registry-storage/test/redis-18.1.5.wrap.tgz"
 »  Unwrapping Helm chart "redis-18.1.5.wrap.tgz"
    ✔  Helm chart uncompressed to "/tmp/chart-1844294399/at-wrap3814855721"
    ✔  Helm chart relocated successfully
    »  The wrap includes the following 4 images:

       localhost:5000/bitnami/os-shell:11-debian-11-r90
       localhost:5000/bitnami/redis-exporter:1.55.0-debian-11-r0
       localhost:5000/bitnami/redis-sentinel:7.2.1-debian-11-r26
       localhost:5000/bitnami/redis:7.2.1-debian-11-r26

    »  Pushing Images
       ✔  All images pushed successfully
       ✔  Chart "/tmp/chart-1844294399/at-wrap3814855721" lock is valid

    ✔  Helm chart successfully pushed

 🎉  Helm chart unwrapped successfully: You can use it now by running "helm install oci://localhost:5000/redis --generate-name"

After some more tinkering and experimenting, I got a working script. This works with the non OCI-based benthos helm chart, which did not work using wrap and unwrap. This time I only made use of the "fine-grade" commands, in the order you mentioned(Much appreciated). I can however not explain why the wrap and unwrap commands did not work for me.
#!/bin/bash

helm repo add temp --force-update https://benthosdev.github.io/benthos-helm-chart/
helm repo update

helm pull temp/benthos --version 0.8.0 --untar --untardir .

images_override=$(cat <<-END
- name: benthos
  image: docker.io/jeffail/benthos:4.11.0
END
)

yq -i e ".annotations.images |= \"$images_override\"" ./benthos/Chart.yaml

helm dt images lock ./benthos

helm dt images verify ./benthos

helm dt images pull ./benthos

helm dt charts relocate ./benthos oci://xragoregistryforgiggles.azurecr.io

helm dt images push ./benthos

helm dt images lock ./benthos

helm dt images verify ./benthos

helm package ./benthos

helm push ./benthos-0.8.0.tgz oci://xragoregistryforgiggles.azurecr.io

I will try to replicate once back from holidays. I wonder if it might be related to be using a local registry. Have you tried the wrap/unwrap with azurecr?

No rush this can wait, holidays are important.
I have tried using ACR, however with the same result.

@RasmusGodske I could reproduce the issue with the exising dt release 0.2.3. Then decided to build from source to debug it and it turned out that I was able to successfully wrap/unwrap the benthos Helm chart. So my theory is that you were hitting a bug that somehow @juamedgod had already fixed but that we hadn't release yet.
Can you try updating to the latest release (v0.3.0) with helm plugin update dt and give it a go again?
By the way, in this release, we have changed how the wraps are structured internally as the way they were it could cause some side-effects with certain Helm charts. This is an improvement but breaks backwards compatibility with older wraps. So you will have to wrap and unwrap for it to work.
Let me know if doing an upgrade fixes it 🙏

@mpermar I tried to update to the v0.3.0 however the error still persists.
The following script:
#!/bin/bash

helm dt version

helm repo add temp --force-update https://benthosdev.github.io/benthos-helm-chart/
helm repo update

helm pull temp/benthos --version 0.8.0 --untar --untardir .

# This helm chart isn't annotated by default, so I'm manually doing this here
images_override=$(cat <<-END
- name: benthos
  image: docker.io/jeffail/benthos:4.11.0
END
)
yq -i e ".annotations.images |= \"$images_override\"" ./benthos/Chart.yaml

helm dt wrap  ./benthos
helm dt unwrap  benthos-0.8.0.wrap.tgz oci://localhost:5000 --yes

Gives me the following error:
./scripts/test.sh
Distribution Tooling for Helm v0.3.0
Built on: 2023-12-11T17:44:44Z

"temp" has been added to your repositories
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "benthos" chart repository
...Successfully got an update from the "temp" chart repository
...Successfully got an update from the "stable" chart repository
...Successfully got an update from the "openebs-jiva" chart repository
...Successfully got an update from the "vmware-tanzu" chart repository
...Successfully got an update from the "traefik" chart repository
...Successfully got an update from the "grafana" chart repository
...Successfully got an update from the "bitnami" chart repository
Update Complete. ⎈Happy Helming!⎈
 »  Wrapping Helm chart "./benthos"
    ✔  Images.lock file written to "/tmp/chart-3552518746/wrap/chart/Images.lock"
    »  Pulling images into "/tmp/chart-3552518746/wrap/chart/images"
       ✔  All images pulled successfully
    ✔  Compressed into "/home/godske/Documents/repositories/work/oci-container-registry-storage/benthos-0.8.0.wrap.tgz"

 🎉  Helm chart wrapped into "/home/godske/Documents/repositories/work/oci-container-registry-storage/benthos-0.8.0.wrap.tgz"
 »  Unwrapping Helm chart "benthos-0.8.0.wrap.tgz"
    ✔  Helm chart uncompressed to "/tmp/chart-2496835767/at-wrap2084825586"
    ✔  Helm chart relocated successfully
    »  The wrap includes the following 1 images:

       localhost:5000/jeffail/benthos:4.11.0

    »  Pushing Images
       ✔  All images pushed successfully
    ✘  Failed to push images: failed to verify Helm chart Images.lock: Images.lock does not validate:
      Helm chart "benthos": image "localhost:5000/jeffail/benthos:4.11.0": digests do not match:
      - sha256:e2fa170d1d0c2e7bf5c89986b6e5de471fe6499f231d6f8e9c1f31c4350353b0
      + sha256:85689f09ddac1449188c9b9c50138027ff476bab81e39d4229f28eb72793314b
      Helm chart "benthos": image "localhost:5000/jeffail/benthos:4.11.0": digests do not match:
      - sha256:244e9c77b90ec18e692acf162c55060156b1d36a820d19a8606f0a98e55d4ee3
      + sha256:f794f3b17252736664244d508c6ffc10f05619cc6d09bf4c4d465d1815e0afa7
Failed to push images: failed to verify Helm chart Images.lock: Images.lock does not validate:
Helm chart "benthos": image "localhost:5000/jeffail/benthos:4.11.0": digests do not match:
- sha256:e2fa170d1d0c2e7bf5c89986b6e5de471fe6499f231d6f8e9c1f31c4350353b0
+ sha256:85689f09ddac1449188c9b9c50138027ff476bab81e39d4229f28eb72793314b
Helm chart "benthos": image "localhost:5000/jeffail/benthos:4.11.0": digests do not match:
- sha256:244e9c77b90ec18e692acf162c55060156b1d36a820d19a8606f0a98e55d4ee3
+ sha256:f794f3b17252736664244d508c6ffc10f05619cc6d09bf4c4d465d1815e0afa7
Error: plugin "dt" exited with error

@RasmusGodske definitely a bug. @juamedgod figured out. We are using Crane (go-containerregistry) to relocate the packages, and the way we are doing it actually modifies the format of the manifest. Not the content, but the format.
That does not affect any images that were put into registries using go-containerregistry, like Bitnami's for example. And that's why we hadn't see this earlier. But your image manifest in DockerHub is pretty-printed. Therefore when we relocate it, go-containerregistry flattens the format and the manifest ends up being different.
We will come up with a bug fix soon. But if you try using crane to upload something into DockerHub and then try to wrap/unwrap it, then it should work flawlessly.

@RasmusGodske  We just merged #30, which should fix your use case. In case you want to give it a try.


Asar

Base patch now built with asar instead of xkas

Excellent! Thanks a million for this contribution. I was just trying to find the time to check it out and I've finally got the code sorted. I'm going to be making further changes but I'll merge this in and make my changes on top of it.


Generation of compound propositions to simple propositions

Hello, how are the simple propositions corresponding to the compound propositions in the training set obtained? Are they generated manually or by GPT?

We observe the data structure and apply rules manually to gain the simple propositions. With the emergence of large language models, we will be able to do better with large language models.


EmptyStaticCreds: static credentials are empty

It always prompt: EmptyStaticCreds: static credentials are empty
Even  I have specified the cfg file. and the cfg file works well if using s3cmd
./s3-cli -c s3cfg ls s3://xxx

I am also affected by this.

Any possibility of getting a redacted version of your s3cfg to make sure I'm testing the right thing?

It was exactly as specified in the demo:
[default]
access_key = foo
secret_key = bar

There may have not been spaces between equals and the value access_key=$ACCESS_KEY.

For what it's worth, I also tried just using AWS credentials via environment variables and got the same result. I also used the CLI flags to specify the keys at process start time. None of these worked. I'm on Ubuntu 16.04 amd64 if that's helpful.

I'm getting the same error, but I was expecting it to support IAM roles. Does it not support this?

Fix:
--- a/config.go
+++ b/config.go
@@ -62,7 +62,12 @@ func loadConfigFile(path string) *Config {

        // fmt.Println("Read config ", path)

-       if err := ini.MapTo(config, path); err != nil {
+       cfg, err := ini.Load(path)
+       if err != nil {
+               return config
+       }
+
+       if err := cfg.Section("default").MapTo(config); err != nil {
                return config
        }

Can you make a PR?

@koblas https://github.com/koblas/s3-cli/pull/12

The pull request from @delfer was merged.  Please let me know if you continue to have problems.

any one can help me how to resolve this question?

facing this issue while trying to use s3 as storage with the version 2.4.0, any help to resolve this issue

I'll take a look, though tempted to upgrade to the v2 golang APIs since they're usable...


Missing documentation

Problem:
ERROR in ./node_modules/vue-gallery-slideshow/dist/js/vue-gallery-slideshow.js
Module not found: Error: Can't resolve 'vue-runtime-helpers' in 'node_modules\vue-gallery-slideshow\dist\js'
Solution:
Add dependency package vue-runtime-helpers.
You should update the documentation.

Thanks for the report! This problem is solved with the new version v1.5.1 and vue-runtime-helpers is now added to the projects's bundle.


schedule / active time for recordings - control via api/mqtt/http

Hi!
is it possible to configure times when recordings should be active? For example tigger recording only at night-time.
Personally it would be enough if i can switch some "recoding-active" value like sensor.camera_1_operation_state via http/mqtt or similar. By the way would such a api for example enable me to use my cameras internal motion detection to trigger recordings.
Nice Greets!

This can sort of be accomplished by using the MQTT Toggle Topic to turn the camera on/off.
The downside of this is that Viseron will stop reading from the camera completely, meaning everything else also stops running (object detection, face recognition, MJPEG streams etc)
I have plans to make it possible to pause recordings, but i need to do an overhaul of the API first so it might take me some time

Thank you very much. I dont why i have overseen the mqtt-component :)


[5.5] Fatal error during package discovering

Laravel Version: 5.5-dev
PHP Version: 7.0

Description:
During:

Illuminate\Foundation\ComposerScripts::postAutoloadDump
@php artisan package:discover

Get:

Fatal error: Uncaught ReflectionException: Class App\Console\Kernel does not exist in D:\PHP\MariVrac\vendor\laravel\framework\src\Illuminate\Container\Container.php:752

Steps To Reproduce:
In composer.json modify
"autoload": {
    "psr-4": {
        "App\\": "app/"
    }
},

by
"autoload": {
    "psr-4": {
        "AnythingButApp\\": "app/"
    }
},

And run composer update

This is wrong, you can't update the namespace in your composer.json without updating the namespace in your files.

That's the definitive proof that I'm no good just out of bed and before breakfast ! Still I'm ashamed of missing out that obvious reason !

Haha, It happens 😀


[remove-resource] Course Hub Grav Bootstrap theme

Now that the new Bootstrap4 Open Matter theme has been available for the past several months, I think it's time to retire and remove the old Bootstrap3 theme:
https://github.com/hibbitts-design/grav-theme-course-hub-bootstrap
Thanks very much,
Paul

Will get to this over the weekend (hopefully)

done.

Thanks very much Andy!


Platform Feature

https://www.loom.com/share/1aa0492aa5464931a55031392ab29744

Hello @ahmetbozaci. Thanks for your comment. now, I got the point. I will walk through it.


add CDNJS version badge in README.md

This badge will show the version on CDNJS!

Sorry, don't want to be a badge mania :)

@nosir It's okay 😄


Two potential problem I encountered during using the code.

I recently wrote a Python binding for surface generation. During the test, I found that there are usually some unexpected spikes on the surface as demonstrated in Fig1. Another problem is that the surface is not watertight as demonstrated in Fig2. Did you ever experienced such a situation? Is it like a bug in the program or setting?
Fig1

Fig2

A few questions:

Did you change the smoothing parameter to use Laplacian smoothing ? This is the "l" parameter.
Did you change the voxel size, you can improve the quality of the mesh by setting it to something lower.
How do you visualize the results ? It looks like the normals are not used.

Thanks for your reply. I tried with a higher number of Laplacian smoothing, increased the slice size, and lowered the voxel size, the surface spike problem was reduced. However, the surface is still not water-tight.
The tool I used for visualization is Open3D. Basically, I just outputted the vertices and faces to the object file and the normal is from open3d's computation before rendering.
The surface you are viewing is the atoms within a cubic bounding box from part of a protein. As you might see atoms outside of the surface, they are atoms outside of the bounding box.

Slice size shouldn't matter as your surface seems rather small. If your GPU has enough memory to compute the whole surface in one run, you can ignore this setting.
I can increase the limit of the grid to see if that solves your issue.

Could you try this branch and see if that fixes your issue ?

There is still the problem in the fix-origin branch. I am using RTX4090 with 24GB memory. GPU hardware should not be the problem.
Could it be a Cuda version or nvcc problem? When I compile the program, there are some errors about missing functions. I have to add the following code to CudaSurf.cu to enable the compilation.
#include <thrust/sort.h>
#include <thrust/unique.h>
#include <thrust/count.h>

Error message:
nvcc -c -o CudaSurf.o CudaSurf.cu -Icpdb/ -use_fast_math -O3
CudaSurf.cu(419): error: namespace "thrust" has no member "sort"
      thrust::sort(vertThrust, vertThrust + totalVerts, sort_float3());
              ^

CudaSurf.cu(421): error: namespace "thrust" has no member "unique"
      thrust::device_ptr<float3> last = thrust::unique(vertThrust, vertThrust + totalVerts, samefloat3());
                                                ^

CudaSurf.cu(567): error: namespace "thrust" has no member "sort"
      thrust::sort(D_beg, D_beg + N, cmp);
              ^

CudaSurf.cu(646): error: namespace "thrust" has no member "sort"
                  thrust::sort(fillThrust, fillThrust + sliceNbCellSES);
                          ^

CudaSurf.cu(648): error: namespace "thrust" has no member "count_if"
                  unsigned int notEmptyCells = thrust::count_if(thrust::device, fillThrust, fillThrust + sliceNbCellSES, is_notempty());
                                                       ^

CudaSurf.cu(648): error: namespace "thrust" has no member "device"
                  unsigned int notEmptyCells = thrust::count_if(thrust::device, fillThrust, fillThrust + sliceNbCellSES, is_notempty());
                                                                        ^

6 errors detected in the compilation of "CudaSurf.cu".
make: *** [Makefile:21: CudaSurf.o] Error 2

My Cuda info:
+---------------------------------------------------------------------------------------+
| NVIDIA-SMI 535.98                 Driver Version: 535.98       CUDA Version: 12.2     |
|-----------------------------------------+----------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |         Memory-Usage | GPU-Util  Compute M. |
|                                         |                      |               MIG M. |
|=========================================+======================+======================|
|   0  NVIDIA GeForce RTX 4090        Off | 00000000:01:00.0  On |                  Off |
|  0%   38C    P8              17W / 450W |   1929MiB / 24564MiB |      4%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+

Could it be the case that there is no enough shifting of the voxels which causes the truncation of the surface?
There is also some implicit problem with some specific values of grid spacing.
./QuickSES -i 4bso.pdb -o 4bso.obj -v 0.24

Look like a truncation
./QuickSES -i 4bso.pdb -o 4bso.obj -v 0.22

With spacing at 0.2 everything looks fine.
./QuickSES -i 4bso.pdb -o 4bso.obj -v 0.20

I need a bit of time to work on this. Thanks for your report

I fixed the compilation errors on recent CUDA versions.
Also, I investigated the issue with some values of the voxel size, the problem comes from the Marching Cubes implementation.
I am currently trying to fix it

I fixed the issue with welding vertices that caused holes and weird artefacts in the mesh for some values of voxel size.
I didn't manage to reproduce the truncation issue on my machine though


Fix Map leniency

Motivation
This PR handles the Map leniency described here - https://github.com/AleoHQ/snarkVM/issues/1353. This is done by removing Borrow<F> trait requirement from Bech32ID and Bech32Object.
This leniency allowed map functions to take in generic fields by input instead of their wrapper, Bech32ID. In other words, a map would consider N::StateRoot, N::BlockHash, N::TransactionID, and N::TransitionID all the same (as fields), instead of their wrapper types. This leads to possible errors in the map operations like the one fixed in https://github.com/AleoHQ/snarkVM/pull/1345.
Alternative solutions are welcome, as this adds (minor) restrictions to the updated traits.

LGTM


Add kamino.auto.crontab feature

Kamino is designed to be lights-out operation.  As such, it can
be installed as a crontab that runs the auto-update process on
a regular basis.
In most of our clusters, we run this automatic update process on
a daily basis.  Since OS updates usually don't happen daily, this
ends up just checking and noting that there is nothing to do.
When an OS update does happen (or the age limit on the prior image
is reached) then the auto-update process does what it needs to do.
This allows the whole thing to be running in clusters without
intervention.
The schedule could easily be run more often as the cronjob is set
up to not run while a prior instance is running.  I run my test
clusters with this turned to running every few minutes just to
stress test the logic and to quickly notice a condition where a
new image is needed (just to reduce testing time).
This addresses issue #44
Enhanced smoketest3.sh a bit to make it do what I needed.
The new smoketest4.sh is just like smoketest3.sh only it uses the
cronjob (with an "every minute" schedule) to run the cronjob and
then uninstalls after it completes so as to not continually rerun.
It is just a smoketest of the chart...

The check is failing due to some azure login at the start (unrelated to this change, I believe)

Note that I also now merged in the fix for the fixed machine-id value (it now gets generated for each new instance rather than remembered from the source node instance)
This fix is, as far as I can tell, mostly optional.  While machine-id is defined as being unique, it is only "randomly unique" and has not had any noticeable impact on our systems when they were not unique.
This change make this issue go away at the cost of a bit of time to run a pod on the donor node before it is deallocated (but after it is cordoned)


Updated embeddings.ipynb doc file

Updating embeddings.ipynb
I am new to git, hope it is correct,

i think you also included a lot of your notebooks/ that maybe shouldnt be in there?


allowedStyleExtensions not including scss causing scss files to be ignored

After upgrading ember from version 2.10 to latest scss files are not being picked up / processed. After some digging i've discovered that app.registry.extensionsForType('css').filter(Boolean) only returns css so all scss files are ignored.
I've been able to reproduce this in a bare bones application built with ember-cli 2.14.  Happy to provide a repo for testing if need be.

@robmonie what version on ember-cli-sass are you on?

Hi @webark, i've tried various versions from way back at 4.2.0 which were on before, through to the current version 7.0.0.

that was happening with an older version of ember-cli-sass. hmm. you have that repo for testing @robmonie ?

Forgive me @webark, in all my version combinations and different test apps it turns out it that I hadn't tested properly with the latest ember-cli-sass so this is no longer an issue.  Thanks for you help, I'll close this issue.


Feature request: Is there a library for Personalization API?

Browsing through the docs and code I think the following isn't integrated yet, am i right?
https://developer.spotify.com/documentation/web-api/reference-beta/#category-personalization
 GET https://api.spotify.com/v1/me/top/{type}

Nvm, got it

Yes, and for others that may find this issue, the Personalisation API is a part of the client.


LXD fails to start container on host using isolcpus and hugepages

While i am not 100% sure the two are related, I have a host configured to use isolcpus for a subset of cores and also a small number of hugepages allocated and when i stop and start a container it fails and spews a lot of errors - see http://pastebin.ubuntu.com/25226827/
The command line opts im adding are:
isolcpus=4,5,12,13,14,15,16,17 hugepagesz=1G hugepages=8 default_hugepagesz=1G
and my numa cells look like:
# numactl --hardware
available: 2 nodes (0-1)
node 0 cpus: 0 1 2 3 4 5 12 13 14 15 16 17
node 0 size: 32140 MB
node 0 free: 16550 MB
node 1 cpus: 6 7 8 9 10 11 18 19 20 21 22 23
node 1 size: 32253 MB
node 1 free: 21046 MB
node distances:
node   0   1
0:  10  20
1:  20  10
This is with lxd 2.0.10-0ubuntu1~16.04.1 i.e. the version in xenial-updates. I also tried upgrading to 2.15-0ubuntu6~ubuntu16.04.1 from xenial-backports but still see the problem albeit without the tons of errors on stdout. After I upgrade, if i reboot the host it does seem to work.

@dosaboy, are you handing any specific cpus to your containers that include isolcpus?

@brauner actually I'm not specifying anything from a lxd perspective. I'm just setting isolcpus so that I can use it with libvirt from a separate use case but also happen to have lxc containers on the same node.

And the output of lxc info.

I actually suspect this to be related to your numa setting.

Also, if you upgraded liblxc from a version that doesn't support isolcpus to a version that does and you have container's running that have been created by a  non-isolcpus liblxc any new containers will likely fail to start since you cannot remove cpus from a cpuset that is also in a child of that cpuset.

@brauner so a few things. Firslty i upgraded from the latest version in xenial-updates to the latest version in xenial-backports, both of which iiuc are fully supported albeit generally with a feature delta. Does the version in xenial-updates (2.0.10-0ubuntu1~16.04.1) not support isolcpus? Also, when i rebooted, following lxd upgrade and subsequent failure to start some containers, it all works fine and i'm guessing that's because lxd is reconfiguring cpusets based on what is available before starting any containers but i'd have to check. If you want I can redeploy and start the process again to pull data in between each step.

Sorry i forgot to supply that last piece of info so here it is:
cat /sys/devices/system/cpu/isolated
4-5,12-17

If you happen to be able to redeploy and provide me with info about the liblxc version used before and after the upgrade that would be great. You can just gather this info by running lxc info.

@dosaboy, thanks! @stgraber and I fixed that bug yesterday. :)


Downloads fail - Firefox 91.0.1 "blob resource"

Using version 3.1.2 it shows a completed download. When Firefox tries to complete the download, it fails with the message, "blob resource". I have replicated this same error on a couple of different websites. The only commonality is hls-downloader.

Thanks! I'm working on a solution here #207

Thank you!

Solved, now available on https://addons.mozilla.org/en-US/firefox/addon/hls-downloader/


Change error messages to stderror

Fixes #66 Instead of printing out error messages to the screen or file, print error messages as stderror's.

One more change request:
If -h/--help is called, the usage string should go to stdout, not stderr.
(If a bad option is passed, the usage string should go to stderr, as it doesn now.)


Sync eng/common directory with azure-sdk-tools for PR 8158

Sync eng/common directory with azure-sdk-tools for PR https://github.com/Azure/azure-sdk-tools/pull/8158  See eng/common workflow

API change check
API changes are not detected in this pull request.

I'm disabling auto-merge because I discovered an issue in JS. Just clarifying before I merge this.


Create a release so pyceres can be added to conda-forge

Hi,
Is it possible to create a release for pyceres so that it can be added to conda-forge? It will be much easier to install and manage pyceres that way.

Hi, this is very much welcome! What is the process for publishing to conda-forge? Can you provide scripts to automatically build, package, and publish pyceres? In the pycolmap repo, we automatically build pip wheels on PR update and publish to PyPI on release. You can check how we do it and maybe adapt to conda? Thanks :)

Another pointer to see how it's done for GTSAM: https://github.com/conda-forge/gtsam-feedstock

Hi @Skydes, I maintain quite a lot of robotics/vision packages on conda-forge and it would be great to see pyceres there, too. The process is quite easy, it just requires opening a pull request such as this one: https://github.com/conda-forge/staged-recipes/pull/21715
Once the pull request is approved, all build/packaging/publishing is automated in a feedstock like the gtsam once you linked above.
The first step for pyceres would be to create a release - only released packages are accepted to conda-forge. I’m happy to take care of the other steps on the conda-forge side.

I've create this release: https://github.com/cvg/pyceres/releases/tag/v1.0 Thank you for offering to help, It'd be great if you could take care of the rest! Note that for the moment pyceres also requires COLMAP for its camera models.

Awesome, thanks @Skydes! Re colmap: is pyceres compatible with the 3.7 release, or does it need a newer version of colmap based off the main branch?

And one more thing - any chance to push this release to pypi?

is pyceres compatible with the 3.7 release, or does it need a newer version of colmap based off the main branch?

We require 3.8, which has now been published.

any chance to push this release to pypi?

I'd need to setup the CI first, I'll try to get this done in the next days.

We will setup a build CI once we've gotten rid of the dependency on COLMAP (soonish).


Refactor to use new bot event queue handling

See phergie/phergie-irc-bot-react#19. Update Client to use this functionality rather than rolling its own. Note that this should include requiring bot:~1.2 in composer.json.
Related: phergie/phergie-irc-connection#5

Addressed by #35.

Confirmed. Closing.


Better partials

The PR is a total rewrite of the templating engine inside of Fabricator.

allows user to define their own taxonomy; not tied to "components" and "structures". FYI these are called "materials"
adds support for feeding data into materials (components/structures/whatever)
adds support for multiple layouts
"notes" are now stored inside the material file (as front-matter), rather than in a separate .md  file
remove support for material as "helper"; now they are "partials" so they can receive data

More detail can be found here: https://github.com/fbrctr/fabricator-assemble. These docs will be migrated  into the main project once the PR is merged.
#100 #81 #69

Looking for feedback on this. Check out the branch and poke around.

I took it for quick spinn this morning and must say it was smooth.
Love the new easy way to make your own taxonomy and layouts (includes, looping any material as you want). Feeding data into materials is a very nice feature and to store notes inside the files is a big plus, reduces amount of files.
Will play some more with this branch during the coming week.
And as i said no issues at all my initial test round.
Keep up the good work Luke!

Added support for grouping materials (components/structures/whatever).
For instance, if you have:
├── materials
│   ├── components
│   │   ├── buttons
│   │   │   └── primary.html
│   │   │   └── secondary.html
│   │   └── checkbox.html

"Buttons" will appear in the sidebar menu, but "primary" and "secondary" will not.
When you navigate to the Components listing page, the "primary" and "secondary" button variations are grouped under the "Buttons" heading.
You can access the partial using dot notation {{> buttons.primary}} {{> buttons.secondary}}

Added support for user-defined helpers. Defined as key:val pairs in the options.helpers passed into the assemble() task:
// assemble
gulp.task('assemble', function (done) {
    assemble({
        helpers: {
               markdown: require('helper-markdown')
        }
    });
    done();
});


Changed selectize dropdown parents to body.

Fixes #499

See: https://github.com/brianreavis/selectize.js/issues/192

Thank you :+1:


e621 not working and quitting bug.

I've tried downloading from e621, usually based off of artist tags, only for the entire process to only give me one file called "_.net". I think that the site might have changed somehow.
Also whenever I try to exit the program it "crashes" and asks me to submit a bug report...which is what I'm doing now.

See issue #465. e621 will be fixed in next version. :)


(Potential) DIMOWA ModDebugger failure with connectedSck.Close(); or SetServerIsUp(false);

I was using the Mod Debugger, and everything loads fine and works fine. But when I close the game window, the Mod Debugger prints "Closing Server..." but not "Server Closed". I looked at the code, and it seems as though it is a issue with connectedSck.Close(); or SetServerIsUP(false); (lines 139 and 140)

That's really odd, I'm not sure what might have happen, neither the "developer version" nor the release version showed me that strange behaviour:

If it is happening everytime you use the debugger, I'll try to search more to understand what caused this.

That's really odd, I'm not sure what might have happen, neither the "developer version" nor the release version showed me that strange behaviour:

If it is happening everytime you use the debugger, I'll try to search more to understand what caused this.

I found the reason why its happening; I always close the Alpha window by clicking the windows close button, but the Debugger can only close the server if you click the "Exit Game" button.

I found the reason why its happening; I always close the Alpha window by clicking the windows close button, but the Debugger can only close the server if you click the "Exit Game" button.


chore(synthetic-chain): release 0.4.0

I'd like to leverage #191 in agoric-sdk CI.
Also, a question about RELEASING.md... is the intended process to npm publish from this branch and then merge to main, or merge to main and then npm publish from there?

is the intended process to npm publish from this branch and then merge to main

That one, so we can review that it happened.
Approving because I've done it<EMAIL_ADDRESS>To be improved with,

https://github.com/Agoric/agoric-3-proposals/issues/60


Move in correct direction when skipping over step

Let's say I have three steps. Steps 1 and 3 are fine. Step 2's element is missing. When I try to move to next step from step 1, it skips over step 2 to step 3. But when I try to move to previous step from step 3, it skips over step 2 back to step 3. There's no way for me to get to step 1 anymore.
When skipping over a step with element missing, it should check the direction of the skip.
The question is, what should happen, when previous skipping over the first step. When skipping over last step, the tour ends. I guess when skipping over first step, the tour should restart.

How can I skip a step based on if the step element is present or not, I am trying to do something like:
onShow:function(tour){ if(somecondition){      //do something if the element exists }else{     tour.next(); } }
This is stuck in a callback loop and says Uncaught RangeError: Maximum call stack size exceeded.


Crashing before STARS Conference Room

Version
2.3.0 (d86eb61)
Seed
R730-ZK1A-ZJ040HTZ1F700E09TTP0ZZZZZZZZZZZZZZZ
Scenario
RE 1 (Chris)
What happened?
Random Crash in ROOM 115, Resident Evil 3. Also the Hunter Gammas seem to be very problematic; almost every room they appear in the game crashes

Thanks, the crash was also a hunter gamma. I did originally stop them from spawning, but a regression creeped in. This should be fixed now.


Create Page Footers

Created both the lofi and hi fi footer using the primary and secondary colour, then made it a component for easy use by the design team.


Loading Paddle parameters

We need to figure out whether Paddle params will be read:

in C++ using an executor run,
in C++ using a new interface just for reading
in Python, with logic identical to C++ logic

Additionally, we need to get on the same page with populating the graph with parameters

@varunarora Seems that no need extra C++ code to load parameters.  I thought it wasn't possible to use after using an load on an inference model. You have taken care of this.


Support exporting to SRT or WebTT?

Timed text format?
PTAL at https://github.com/arcusmaximus/YTSubConverter

Apple's speech recognition API does not provide any timestamps so this is not gonna work.


Asciimath matrix not rendered correctly

Problem
The asciimath matrix is not rendered correctly
Input
= Test
:stem:

== Content
stem:[[[1,2,3\], [4,5,6\]\]]

Command
 asciidoctor-pdf -r asciidoctor-mathematical Test.adoc
Expected

Output

Gem Versions
Ascii85 (1.1.0)
asciidoctor (2.0.16)
asciidoctor-mathematical (0.3.5)
asciidoctor-pdf (1.6.1)
asciimath (2.0.3)

How about [[1,2,3],[4,5,6]] in block stem? The handler is still there in the code and shall work.

How about [[1,2,3],[4,5,6]] in block stem?

It renders correctly.

OK. This seems a problem in the expression itself. You do not have to escape them in block macros. The inline macro can not handle [] at the moment, unfortunately.

Is it possible to open this issue back? The [] still does not work for the inline macro, and this is the example given in the documentation.
A matrix can be written as stem:[[[a,b\],[c,d\]\]((n),(k))].

should be:

but results in:

And even inside a block stem, the example does not work:
A matrix can be written as
[stem]
++++
[[[a,b],[c,d]]((n),(k))]
++++

results in:

which is not how it looks in the documentation.


Can't Install/update

Whenever using either the exe or msi installer I get the error message shown here https://i.imgur.com/CxwxLiv.png

@MrChickenDipper are you trying to install 0.20 or 0.21?  Where are you getting the installer from?
@enricogior why is the MSI file renamed here?  Do we rename it for the bootstrapper?

@crutkas
yes, it's renamed when extracted from the .exe, I'll check why that is needed, given in the past we had issues with anti-virus software blocking it because of that. If it's not strictly needed we shouldn't do it.


Update contributors-guidelines.md

Removed mention of resharper (use dotnet format instead), also updated some other parts.

Updated the mention of NTS and made some further improvements.


outdated packages check

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Abubakar Yousafzai seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Minor change to remove the unnecessary braces in the @SuppressWarnings annotation.

I inadvertently added them in my previous commit.

Codecov Report

Merging #563 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #563   +/-   ##
=========================================
  Coverage     64.49%   64.49%
  Complexity     1483     1483
=========================================
  Files           177      177
  Lines          5278     5278
  Branches       1180     1180
=========================================
  Hits           3404     3404
  Misses         1370     1370
  Partials        504      504

Impacted Files
Coverage Δ
Complexity Δ

...ntellij/plugin/processor/clazz/ValueProcessor.java
79.41% <ø> (ø)
9 <0> (ø)
:arrow_down:

...j/plugin/processor/field/WitherFieldProcessor.java
85.34% <ø> (ø)
35 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 543e9cb...b766131. Read the comment docs.


Home page

To see the new home page, go to /home
To see the "/" in its four possible states, edit the group variable prior to the switch statement in Router.coffee.

Teacher and learn more buttons need smooth down navigations.  See /schools for an example.
Top and bottom menu teachers option should go to /courses/teachers instead of /teachers.  In general, we should try to avoid hitting redirects that make it impossible to go back in your browser.
Let's make play now do a normal nav, instead of new tab.
Lesson time 1 hours shouldn't be plural.
Jobs link should be Careers.
Homepage title should be CodeCombat, instead of the view class.

@sderickson I'm done looking at this.

@differentmatt

Homepage title should be CodeCombat, instead of the view class.

That's just a dev-specific setup that you saw, I think. In production, every page has the default "CodeCombat - Learn how to code by playing a game'.
https://github.com/codecombat/codecombat/blob/master/app/views/core/RootView.coffee#L114-L117


Change Indev back to Master (Which is now Indev)

Fix for the restructuring of Discord.js branches

Already fixed in https://github.com/eslachance/komada/commit/85bfdb375d82172ca620d5829c2169c8297a20b0


Parser: Syntax error improvement request

This is another case of the parser's error messages not being particularly user friendly.
Input:
schema * as MySchema
  Text value

Error:
Post-parse processing error caused by './in-memory-1269713.manifest' line 1.
Parse error in './testInput.arcs' line 1.
Expected "*", "extends", or an uppercase identifier (e.g. Foo) but "a" found.
    schema * as MySchema
             ^
  import './testInput.arcs'

The expected fix is to add 'alias' to the definition,
alias schema * as MySchema
  Text value

Thanks @alxrsngrtn  for finding and documenting it.

Thanks to @piotrswigon for writing up the desired syntax in #3663.

@alxrsngrtn
#3663 does use alternate syntax, but it is not clear to me that this is a proposal rather than an omission. My intent here is to improve the error message, without changing the alias schema syntax.


Other:  Add Youtube link to new Uptane site footer

Issue Summary
Add the Uptane Youtube link to the new Uptane site footer, under the community section

here is the link to the channel: https://www.youtube.com/@Uptane

I would like to work on this issue

sure @tejas-raskar go ahead

@Abhijay007 I have made the required changes. Please review


Support for KeyConditionExpression& ProjectionExpression in queryRectangle

Adding the possibility to append user-defined conditions in query rectangle method.
Adding extra possible parameter that user can define (like ProjectionExpression) to filter further the returned results

Hey @Sford4, The new version now support using query_input_dict param, will be working on deploying the changes to today/tomorrow maximum


Master

Access LSASS Memory for Dump Creation

@muralith-xilinx : This seems like an incorrect pull request. Please make pull requests against develop. We update the master branch every time we make release


IE 11 sometimes re-renders unexpectedly

Preact version: 8.2.7
I have a component that returns null from render and shouldComponentUpdate always returns false.  All component logic is handled by componentWillReceiveProps. Whether or not this is best practice is another story.
I'm now seeing some weird behaviour on IE 11 on Windows 7 as well as Windows 10.
I would expect that the components render function is only called once in the very beginning since shouldComponentUpdate is always false.
However, it seems IE 11 ignores it sometimes when new props come in for the first time and re-renders the component anyway. Sometimes not on the first time but second or third time when new props arrive.
Because the componentWillReceiveProps method is not called on the initial render (or what IE 11 thinks is the initial render), this caused a nasty bug in my app when an important update for the component was "missed".
I created basic test case to demonstrate the issue:
https://codepen.io/mrMetalWood/pen/dJXLjq
Just click the button an watch the console. Here is the debug view: https://s.codepen.io/mrMetalWood/debug/dJXLjq/mVMbGEjaBndr
In modern browsers all is fine:

On IE 11 on Windows 7 it looks like this:

Same on IE 11 on Windows 10:

The (initial?) render method is called twice and thus causing the componentWillReceiveProps to be skipped because it thinks it is the initial render.
For know I worked around this by returning an empty <div /> instead of null which now works as expected. But I still wanted to report the issues I had with this.
I don't know if this is even a preact bug or just the IE doing its weird thing it sometimes tends to do ;)

I'm trying to figure this out.
This is what I have so far:
IE seems to have a flakey behavior when setting custom properties to text nodes, like preact does with __preactattr_ and _component.
It is wiping custom properties like _component sometime after page load, thus confusing preact renderer.
The issue only affects pure text nodes, that's why empty divs and other elements work.
Looks like the wiping process is async, difficult to debug in IE.
Hope there is a way to prevent this.

One thing I hadn't tried: using Object.defineProperty(Text.prototype, '__preactattr_', ...etc)

@developit I tried that, it has the same behavior.
Also, on topic: Does preact 9 or later aim to remove some state (like _component) from the DOM? That would prevent this kind of issue from happening too.

Good news: With Preact X we are not adding any new non-standard properties to the DOM anymore. The only exception is the topmost one which is treated as the root of a tree and containsa reference to the previous one via _prevVNode 👍


fix vercel default path for docs preview env.

we updated the default path to support single domain.
currently the vercel preview sites open with the default path "/" and that needs to be updated to "/docs"

Hey @ainvoner
Just double checking, is this still relevant?


Cookies are domain specific

Need to persist across www and non-www domains

Started looking at this, have something that may work by setting hostname in env, but doesn't play nice with localhost, this is a known issue. Will need to set up a dev domain to test with


Revert "TSCUtility: deprecate Bitstream interfaces"

Reverts apple/swift-tools-support-core#351
This change introduced warnings for SerializedDiagnostics which is used by SwiftPM.

@swift-ci please test


Error state if query is reset while loading

Describe the bug
Upon pressing 'reset' on a query while it is already loading, the error state is shown.
To Reproduce
Steps to reproduce the behavior:

Open react-query dev tools.
Click on a query in the list.
In the panel that opens, under 'Actions', click 'Reset'.
Ordinary loading behaviour should be seen.
Now press 'Reset' twice in quick succession.
An error state should be seen.

Expected behavior
The component should have stayed in the loading state the whole time.
Screenshots
Here's a sandbox: codesandbox.io/s/i8443.
Here's a screenshot:

Desktop (please complete the following information):

OS: macos
Browser: chrome
Version: 87.0.4280.88

Let me know if I can help at all!

I debugged this a bit. It seems that while re-setting, any active fetches will be cancelled, which makes sense. If we reset the first time, the active subscriber will be re-fetched (we can also see the transition to fetching in the gif). Now if we are re-fetching and reset at the same time, the ongoing fetch will be cancelled by the reset, leading to a CancelError in the process.
The code in question would be here:
https://github.com/tannerlinsley/react-query/blob/361935a12cec6f36d0bd6ba12e84136c405047c5/src/core/query.ts#L228-L230
Passing silent to cancel will not show cancellation errors:
  destroy(): void {
    this.clearGcTimeout()
-    this.cancel()
+    this.cancel({ silent: true })
  }

This works, but I'm not sure if this is totally the right fix, as it impacts every call to destroy. We could also forward the CancelOptions to destroy and only pass them from reset. This would then only impact reset:
-  destroy(): void {
+  destroy(options?: CancelOptions): void {
    this.clearGcTimeout()
    this.cancel(options)
  }

  reset(): void {
-   this.destroy()
+   this.destroy({ silent: true })
    this.setState(this.initialState)
  }

I think the first approach is fine, because I don't see that we need errors while we are destroying 🤷 - but I'll leave this for @tannerlinsley to decide - and then you can maybe do a PR and add some tests?

I debugged this a bit. It seems that while re-setting, any active fetches will be cancelled, which makes sense. If we reset the first time, the active subscriber will be re-fetched (we can also see the transition to fetching in the gif). Now if we are re-fetching and reset at the same time, the ongoing fetch will be cancelled by the reset, leading to a CancelError in the process.
The code in question would be here:
https://github.com/tannerlinsley/react-query/blob/361935a12cec6f36d0bd6ba12e84136c405047c5/src/core/query.ts#L228-L230
Passing silent to cancel will not show cancellation errors:
  destroy(): void {
    this.clearGcTimeout()
-    this.cancel()
+    this.cancel({ silent: true })
  }

This works, but I'm not sure if this is totally the right fix, as it impacts every call to destroy. We could also forward the CancelOptions to destroy and only pass them from reset. This would then only impact reset:
-  destroy(): void {
+  destroy(options?: CancelOptions): void {
    this.clearGcTimeout()
    this.cancel(options)
  }

  reset(): void {
-   this.destroy()
+   this.destroy({ silent: true })
    this.setState(this.initialState)
  }

I think the first approach is fine, because I don't see that we need errors while we are destroying 🤷 - but I'll leave this for @tannerlinsley to decide - and then you can maybe do a PR and add some tests?

Thanks for looking into this! Yep, I'd be happy to put up a PR and try to add some tests (though may ask for some pointers as I've not looked at this code before), provided we're agreed this is the way to go.

Thanks for looking into this! Yep, I'd be happy to put up a PR and try to add some tests (though may ask for some pointers as I've not looked at this code before), provided we're agreed this is the way to go.

I think for now, it would be fine to go with @TkDodo's first approach as he also recommended. If we need more control later, we can always add it. Feel free to open a PR and we can start working through it!

I think for now, it would be fine to go with @TkDodo's first approach as he also recommended. If we need more control later, we can always add it. Feel free to open a PR and we can start working through it!

:tada: This issue has been resolved in version 3.5.15 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 3.5.15 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add simulation for recrafting of items you do not currently have in your inventory

Hi today i found out that recrafting gear with all Q3 mats is not the same as crafting new gear with all Q3 mats.
Simulator shows 100% Q5

In recrafts few points are missing

would it be possible to add separete simulation for recrafts of items that are not currently in you inventory?

I will look into making the craftsim frames available for the work order interface in a future update


Docker build cleanups

Description
Docker build cleanups
License Acceptance

[ ] This repository is Apache version 2.0 licensed and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

Type of changes

[ ] Add/update a helper script
[ ] Add/update link to an external resource like a blog post or video
[x] Bug fix
[ ] New feature
[ ] Test updates
[ ] Text cleanups/updates

Checklist

[x] I have read the CONTRIBUTING document.
[x] All new and existing tests pass.
[ ] Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh is an allowed exception)
[ ] Scripts added/updated in this PR are all marked executable.
[ ] Scripts added/updated in this PR do not have a language file extension unless they are meant to be sourced and not run standalone. No one should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
[ ] I have confirmed that any links added or updated in my PR are valid.

🦙 MegaLinter status: ❌ ERROR

Descriptor
Linter
Files
Fixed
Errors
Elapsed time

✅ COPYPASTE
jscpd
yes

no
1.54s

❌ DOCKERFILE
hadolint
1

1
0.07s

✅ EDITORCONFIG
editorconfig-checker
2

0
0.01s

✅ REPOSITORY
gitleaks
yes

no
0.25s

✅ REPOSITORY
git_diff
yes

no
0.0s

✅ REPOSITORY
grype
yes

no
9.31s

✅ REPOSITORY
secretlint
yes

no
0.74s

✅ REPOSITORY
trivy
yes

no
4.48s

✅ REPOSITORY
trivy-sbom
yes

no
3.23s

✅ REPOSITORY
trufflehog
yes

no
2.84s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by


TaskQueue behavior for duplicate tasks in a list during Queue.add()

I have some questions about the behavior of taskqueue.Queue().add(task_list) when 1 of the tasks is duplicate, but the others are not.
I am not aware of any documentation around the taskqueue API that explains this behavior - as such it seems undefined.
My concern is that adding a list of multiple tasks, where 1 may already have been tombstoned/created, may cause the other legitimate tasks to fail.
This affects the pipeline library in the following codeblock:
try:
  taskqueue.Queue(self.queue_name).add(task_list)
except (taskqueue.TombstonedTaskError, taskqueue.TaskAlreadyExistsError):
  pass

https://github.com/GoogleCloudPlatform/appengine-pipelines/blob/bd9fa1e7000dc6af6fe704137cc53fa6d8cde427/python/src/pipeline/pipeline.py#L1659-L1663

Any clues? This may be a good question for @tkaitchuck.
This was brought up in issue #54.

As far as I can tell this is ok. If it turns out not to be, it should be treated as a bug in taskqueue, as a TaskAlreadyExistsError should be raised at a lower priority than a failure for other reasons.

@tkaitchuck It's definitely a task-queue related question, but it's unclear as to what happens to all 10 tasks when 1 out of 10 tasks is a duplicate. Any ideas?

I know that is the case for Java's task queue that all 10 will be attempted and only if there is no more serious error will that be raised. So I assume it is for the python client as well.


Dates are not working for .co domains

Describe the bug
When using python-whois to lookup a .co domain the dates appear to not be returned
To Reproduce
Steps to reproduce the behavior:

Look up stuff.co in python-whois
Run the same query via Linux whois

Expected behavior
The dates to be populated
Screenshots
$ ./whois_check.py -d stuff.co
{'last_updated': None, 'name': 'stuff.co', 'expiration_date': None, 'creation_date': None, 'registrar': '', 'name_servers': set(['ns-518.awsdns-00.net', 'ns-410.awsdns-51.com', 'ns-1864.awsdns-41.co.uk', 'ns-1489.awsdns-58.org'])}
$ whois stuff.co
Domain Name: stuff.co
snip
Updated Date: 2019-11-18T20:51:19Z
Creation Date: 2010-04-23T07:10:01Z
Registry Expiry Date: 2021-04-22T23:59:59Z
Desktop (please complete the following information):
Ubuntu 18.04
python-whois 0.7-6
Thanks :)

Seems that around 0.7 something changed and we need to update - I will ask ubuntu to update the package but I doubt that will happen


Hacktoberfest topic missing

Hactoberfest is not seeing this repo as a participating repo. the topic "hacktoberfest" needs to be added for the PRs to be counted.

Added, thank you!


Manage keystores and truststores more intelligently.

WIP to solve #30. Tag @liamjbennett and @ak0ska.

Overall this looks good. If we are going to default to ssl enabled (which we probably should) then this is going to have to be done is a new major version.

Agreed.

@liamjbennett should we not enable ssl by default then? The only thing I can think of in that sense is if we break up framework-config.

One of the gems is failing on ruby 1.9.3 because it pulls something in that has ruby 2.0.0. I assume dropping ruby 1.9.3 isn't an option?

yeah, nope… not at this point in time anyway :(

I'm really uncertain what to do here, then. Do we peg the gem versions at something particular? What is even requiring that?
Also, we need standards for this thing. :)

@jyaworski
I review the codes, the re-style way mixed in commits is annoying that I can't focus what change is related to problem fixed. Please restore them.
Recommend to raise a new pull request which only focus on re-style.

@jyaworski any chance you can rebase this so we see what travis thinks of it now?

@jyaworski Any idea when this could be merge into master?

Closing as I don't have time to work on this at the moment.

would love to see anyone else in here (@devcfgc? @SydOps?) pick it up


Support CPLEX too

Could help
Thanks

Someone from CPLEX said they were working on an interface. I haven't heard from them in a long time, but I'm not going to do it myself when someone is willing to contribute.

I contacted the CPLEX development team.  They do not intend to support cvxpy unless they receive "more requests".  Instead, they point those who inquire to their proprietary APIs.

Any news?

I've created a pull request here: #506.

A simple QP interface should already be working inside CVXPY. I wrote it a while ago and it was working. Check out this file.

Now that pull request #506 has been merged, should this issue be closed?


Treat node_modules as external for resulting build and move langchain to peerDependencies

Problem
Currently langfuse(-langchain) does not correctly treat dependencies as external. See https://www.npmjs.com/package/langfuse-langchain?activeTab=code for the included files in node_modules and check the content of index.(cjs|esm).js.
This results in some issues:

langchain upstream code is inlined. This will cause (hidden) issues when the bundled code diverges from the langchain version the including package is using. Additionally some checks won't work, like the instanceof AIMessage check in langfuse-langchain/src/callback.ts. As the passed down AIMessage from langchain will be an instance of their AIMessage class, whereas the comparision will be against the bundled in class.
When upstream langchain types change, the langfuse-langchain callback handler won't be passable into chains anymore, as the returned handler will confirm to the bundled in types and version and not correctly inherit from the latest BaseCallbackHandler provided by langchain.

Additionally langchain should be a peerDependency so downstream can correctly use their version.
Changes
Don't use the package.json files for defining externals in rollup, instead just treat everything in node_modules as external.
Change to peerDependency.
This will also shrink the bundled size by around 100kb.
Caveat
I didn't test this further in my local setup/downstream package as I didn't setup project linking (yet).
Release info Sub-libraries affected
Bump level

[ ] Major
[X] Minor
[ ] Patch

Libraries affected

[X] All of them
[ ] langfuse
[ ] langfuse-node

Changelog notes

Treat node_modules as external for rollup
Move langchain to peerDependencies for langfuse-langchain

Updated in https://github.com/langfuse/langfuse-js/pull/46


Save control point information on LTCurve

Feature request
Save control point information on bezier curves during parsing (as suggested by @jsvine in https://github.com/pdfminer/pdfminer.six/pull/530#issuecomment-774742279).
Description
I need to render bezier curves in pdfs with different levels of resolutions and what jsvine suggests in PR-comment would solve my problem.

(Relatedly: Are the maintainers open to adding a .path attribute (which would contain the full path-command information that .paint_path is using) to LTCurve objects? That would allow users to reproduce the Beziér curves themselves — currently not possible because the command types themselves (m/l/h/c/v/y) are not accessible through .pts. If that sounds like a good idea, I can submit a separate PR once this one is resolved.)

Since I could not find any discussion regarding jsvine's suggestion I made this issue. Maybe there already exists an issue for this?
Example of use case
Example, this file contains a simple circle. Using a function like cubic_bezier below, I would like to be able to render points on the circle. Moreover, I need to be able to generate the points with different levels of resolution (e.g.res=5, res=10 and res=100) so the original control points needs to be saved on the curve object somehow.
def cubic_bezier(p0, p1, p2, p3, res=10):
    pts = []
    for i in range(0, res):
        t = i / res
        pt = pow(1-t, 3) * p0 + 3 * pow((1-t), 2)*t*p1 + 3 * (1-t) * pow(t,2)* p2 + pow(t, 3) * p3
        pts.append(pt)
    return pts

Image of rendered points from bezier curve in pdf file

I need this feature too. Is someone working on it? Otherwise i can also offer to work on a PR?

@JulianFeinauer PR is more than welcome here!


Allow for more flexibility in what path SWIFTCI_USE_LOCAL_DEPS means

This patch allows SWIFTCI_USE_LOCAL_DEPS to be either 1 (use ..) or a string to be prepended to the path.
It also moves from the deprecated swiftLanguageVersion to swiftLanguageMode.
Both of these are required to work with this benchmarking update in swift-foundation.

@swift-ci test

@swift-ci please test Linux platform


[docs] Suggestion / Change Request

File: docs/01_nodeos/04_replays/how-to-generate-a-snapshot.md
The callout caption looks incomplete or grammatically incorrect
Other blocks.log files
You can also download a blocks.log file from third party providers.
Why are both plural files and a singular file used?

I don't see a singular vs. plural conflict here. The name blocks.log describes a singular log file that contains blocks - a local copy of the blockchain. The title is plural because you can get various instances (plural) of such blocks.log files from different vendors.

Sorry for the tone was a bit too direct. It was late last night.
With your description, I understand it now. Maybe it is easier to follow for a new user as this:
Getting blocks.log files from other sources
What do you think?

When designing callouts, I like to choose titles that are descriptive enough yet not too long. If the title is too long it will take more vertical space than needed. In this case, we could compromise by adding a verb to the title as you suggest but removing the last complement "from other sources". How about "Getting other blocks.log files" ?

Sounds good. will create a PL

fixed


Refactor ExportLogs target for UIKit and SwiftUI

Current implementation works fine with SwiftUI, but needs to be refactored to work with SwiftUI and UIKit.

Do we need to support UIKit?

Mostly depends on if there is a customer who uses UIKit and wants this package. If not, then we can leave it out right now and I can just manually add the export logs feature to our current demo apps that use UiKit, like Inventory.

I’d probably just ship the Swift version first and leave the UIKit improvements as a feature request for later.


Pinned sources

Enhancement -- Sometimes when adding a specific source to various galls, typing in the same name for a source can get tedious. I've recently been adding a lot of galls from the Gagne book but it does get repetitive having to type in the source again and again. Perhaps having a list of frequently used sources could work?

My suggestion was pretty much just for the Admin's side, just think it would hasten the job a bit


ubuntu:"Cannot determine sdk root"

I have set the environment variable, but I still report an error, please help me to see how to deal with it, thank you very much
.bashrc
export ANDROID_HOME=$HOME/Android/Sdk
export PATH=$PATH:$ANDROID_HOME/tools

@moroal, Glad that you were able to solve the issue!
If it was an issue with the extension, it might help if you can share the issue and solution. If it was some issue with your setup, can we please close this issue?

Starting vscode from the shell works just fine
@nisargjhaveri


The logic regarding the initial trade bar in TradeBarConsolidatorBase.cs:Update

The AggregateBar() was always called before the OnDataConsolidated event was fired. This may result in an additional trade bar aggregated in TimeSpan-only mode.
The proposed logic is to aggregate the bars after firing the OnDataConsolidated event for TimeSpan-only consolidators, except when TimeSpan is TimeSpan.Zero.
Note that two test cases were updated to reflect the logic change, and an additional test case was written to verify the updated logic.

It seems there are some files in here from your personal library. Please remove those files from the pull request.

There you go. It should look better now.
I'm still familiarising myself with Git/GitHub, in case it was not obvious enough ;)

Great contributions @willniu, thanks!


Initial commit of Origin oct Jenkins jobs

The set of Jenkins jobs that are run on a pull request to Origin that
use the origin-ci-tool are generated using the tools in this commit.
To change the set of jobs that are included in a full Origin test run,
change children/test_pull_requests_origin_future.txt. To change the
commands that are run in any specific test, change the corresponding
file under commands/.
Re-generate the set of job XMLs with generate.sh.
Push the new job XMLs to the Jenkins server by running push-update.sh
with $USERNAME and $PASSWORD set.
Verify that any new commit you make is checking in the accompanying
generated changes with verify.sh.
Signed-off-by: Steve Kuznetsov<EMAIL_ADDRESS>

@jupierce

@smarterclayton PTAL commands/*


Fix IB crash for SSDynamicButton subclasses

Fix IB crash for SSDynamicButton subclasses, issue https://github.com/splinesoft/SSDynamicText/issues/36
It's the simplest solution that I found.
AFAIK there no way to change DynamicType in Storyboard, so this should not do any harm.

Current coverage is 88.05% (diff: 100%)

Merging #37 into master will decrease coverage by 8.75%

@@             master        #37   diff @@
==========================================
  Files            10         25    +15
  Lines           219        611   +392
  Methods          83        162    +79
  Messages          0          0
  Branches          7         35    +28
==========================================
+ Hits            212        538   +326
- Misses            5         45    +40
- Partials          2         28    +26

Powered by Codecov. Last update 8157ff9...a9d7c4a

😭 :ship: if this fixes the issue

@segiddins Would you be so kind and release version 1.1.0?


[YUNIKORN-2986] Improve visual in applications/node page

What is this PR for?

Add queue menu tree component & spliter improve user experience
Componentized search input, make consistency in app/node page
Change form field to outline apperence

What type of PR is it?

[x] - Improvement

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2986
Screenshots (if appropriate)

Before
After

I'm -1 on this approach. It wastes far too much real estate that is better used for the table data.


Improve Landing Page UI

Current Landing Page is a bit basic and its UI can be made better by adding a background image and using a better font

Kindly assign this issue to me so that I can start working on it.

@Nandini-13 i would like you to keep same color combination
you can refer to this color pallet for your help [https://coolors.co/palette/22577a-38a3a5-57cc99-80ed99-c7f9cc]


Add -c or --config option`

I would like to add support for a --config commandline argument to your project that takes a TOML file as input, and eliminates the need for users to type out all the options/flags manually.
I would likely be using a library called Tomlib to parse the TOML files. If you don't have any issues, I can start working on it now.

Sounds good, go for it.


DOC: Update versions in build matrix

Don't love this process. Perhaps we make it e.g. 0.8.x

Thanks! Yeah I have no idea how to speed it up except a search and replace in the whole project.


Port 9695 is not available

Hi, I'm not being able to start my local dev env
marcusrohden@Marcuss-MBP tribe-end % nhost dev up
> Failed to start services
> [port 9695 is not available, use --console-port flag to provide another one] Failed to start services

Nhost CLI v0.8.3 for darwin-amd64
Docker version 20.10.17, build 100c701

Hey @marcusrohden! It's possible that nhost dev didn't exit properly and something keeps using that port.
Could you please try running the following command in your terminal to see what is using that port?
lsof -nPi | grep 9695

You can kill the process using that port, then run nhost dev again.

looks like hasura console is running, check in Activity Monitor by querying hasura


试过了，现在不支持CompletableFuture的方法进行事务管理

Why you need it?
Is your feature request related to a problem? Please describe in details
是否支持Future的异步方法事务回滚
How it could be?
A clear and concise description of what you want to happen. You can explain more about input of the feature, and output of it.
Other related information
Add any other context or screenshots about the feature request here.

参考 https://github.com/caohdgege/seata-async


Add retry option

Feature request
Create many options at once and let us pick one
Why?
Answering just "No" does not mean that I dont' want to try again. What if you add a retry|next option for this use case?
The retry should consider previous messages so that the AI is aware that we did not like any of the previous ones.
For example, I had to ran it twice to get something that was truly describing what my changes were.

Alternatives
run the command multiple times
Additional context
No

It would be much more pleasant seeing N possible options. If I have to run it N times until I find the one that best describes the changes, I prefer to write it myself.  This could also reduce the number of repetitive outcomes it generates.

FYI there's generate: https://github.com/Nutlope/aicommits#generate-multiple-recommendations
I'm open to accepting a "Retry" option

@privatenumber @Nutlope is this ready to be picked up? I would love to contribute.

Sure, go ahead! Thanks


APKINDEX.tar.gz runs into BADSIG for main and community repo

I am not sure if this is the right forum to log this:
Looks like the APKINDEX for main and community was updated recently earlier today:
http://dl-3.alpinelinux.org/alpine/v3.3/community/x86_64/
APKINDEX.tar.gz	2016-May-10 13:06:58	58.7K	application/x-gzip
ERROR: http://dl-3.alpinelinux.org/alpine/v3.3/community/x86_64/: BAD signature

Logged here:
http://bugs.alpinelinux.org/issues/5556


feat: Add High Resolution Fix to SDXL Linear Flow

What type of PR is this? (check all applicable)

[ ] Refactor
[x] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Community Node Submission

Have you discussed this change with the InvokeAI team?

[x] Yes
[ ] No, because:

Have you updated all relevant documentation?

[x] Yes
[ ] No

Description
Adds the high resolution fix feature to the SDXL linear flow.
Related Tickets & Documents

Related Issue #
Closes #

QA Instructions, Screenshots, Recordings

Added/updated tests?

[ ] Yes
[x] No : Front end change

[optional] Are there any post deployment tasks we need to perform?
I'm having difficulty getting this to work on my development machine (m2 macbook). I'm getting a black image when I run sdxl with the VAE fix at fp32. Can someone try this on a more capable machine to verify it works correctly?

Works great for me! The print looks like it comes from the REALESRGAN library:
https://github.com/xinntao/Real-ESRGAN/blob/master/realesrgan/utils.py#L163
Not sure how to suppress this

I agree it's probably out of scope for this PR, and double checked - the same behavior appears when doing a normal upscale as well

@lstein I've addressed the print statements in #5177

@marict - Checking in here! We're getting ready for an RC - do you want to include this in it?


Fixed bug with SPSearchServiceApp to allow mangement of default crawl account

Fixes a quick bug where a defautl crawl account would not be reported correctly, causing an error in the get method.

[X] Change details added to Unreleased section of readme.md?
[n/a] Added/updated documentation and descriptions in .schema.mof files where appropriate?
[n/a] Examples updated for both the single server and small farm templates in the examples folder?
[X] New/changed code adheres to [Style Guidelines]?(https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md)?
[X] Unit and Integration tests created/updated where possible?

This change is

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Support cocoa pod and/or carthage?

Do you have any plan for support the cocoa pod or carthage? Thanks.

Yes, there are plans to support Carthage soon. Cocoa Pods will not be supported.


List of all scanned files

Hi,
It would be nice to have a page where all scanned files are displayed. Maybe the "Search" page could display all files by default?
Also, it would be nice if the files were displayed ordered by last scan timestamp, I think it would make more sense for the user.
Thank you if you have some time to think about it!
PS: actually, this patch allows to return all the files if no "name" or "hash" is specified in the /search/files request (or if they are empty):
diff --git a/frontend/api/controllers/search.py b/frontend/api/controllers/search.py
index f755c40..f6cf018 100644
--- a/frontend/api/controllers/search.py
+++ b/frontend/api/controllers/search.py
@@ -46,9 +46,9 @@ def files(db):
         offset = int(request.query.offset) if request.query.offset else 0
         limit = int(request.query.limit) if request.query.limit else 25

-        if name is not None:
+        if name:
             base_query = FileWeb.query_find_by_name(name, db)
-        elif h_value is not None:
+        elif h_value:
             h_type = guess_hash_type(h_value)

             if h_type is None:
@@ -56,7 +56,7 @@ def files(db):

             base_query = FileWeb.query_find_by_hash(h_type, h_value, db)
         else:
-            raise ValueError("Missing query attribute name or hash")
+            base_query = FileWeb.query_find_by_name("%", db)

         # TODO: Find a way to move pagination as a BaseQuery like in
         #       flask_sqlalchemy.

Not the best way to do it, but this kind of API may be useful.

temporary fixed (need a proper /file api coming in next version)


Date contains only the month and date but not the year

When I'm downloading my data, all my date fields are of the form, "Month date", (e.g. Oct 29). However, I wanna get also the year of the date and get something like Oct 29, 2015. Can you fix that please? I guess it's pretty simple.

Thanks for the report! Can you clarify what command line command or API command you are using to get data, as there are many :) For some APIs, Mint doesn't return year data if the year is the current year, and then will start appending years once you get into the past year.


React form support for ListboxField

See https://github.com/silverstripe/silverstripe-framework/issues/5521 for context.

Not critical for beta1

Replaced by https://github.com/silverstripe/silverstripe-admin/issues/52


chore(deps): bump dependencies

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
chore: deps

What is the current behavior? (You can also link to an open issue here)
n/a

What is the new behavior (if this is a feature change)?
n/a

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
n/a

Other information:

CDS Report test#1634.0 ✘

tests and lint

golangci-lint ✘
unit-test and integration-tests ✔


Clean code: should we replace macros with methods, and why?

Recently, there was some little refactoring in a few abap2xlsx programs or classes, to replace macros (DEFINE ... END-OF-DEFINITION) with methods:

#806
#818

My question:

Is that a best practice in ABAP community? Discussion links?
Could it be decided once for all and write the decision in the abap2xlsx contribution guidelines, so that to have coherent code?

Thanks!
This issue can be used as support to collect future modifications. These are the macros left in abap2xlsx:

https://github.com/sapmentors/abap2xlsx/blob/d19ac690c6089dcdfe9d2895baab2e8cd7279399/src/demos/zdemo_excel27.prog.abap#L104-L126
https://github.com/sapmentors/abap2xlsx/blob/d19ac690c6089dcdfe9d2895baab2e8cd7279399/src/demos/zdemo_excel27.prog.abap#L136-L157
https://github.com/sapmentors/abap2xlsx/blob/ac5c95ace70a958bcd401e51e190054ece888978/src/demos/zdemo_excel_outputopt_incl.prog.abap#L188-L193
https://github.com/sapmentors/abap2xlsx/blob/ac5c95ace70a958bcd401e51e190054ece888978/src/not_cloud/zcl_excel_ole.clas.abap#L251-L296
https://github.com/sapmentors/abap2xlsx/blob/ac5c95ace70a958bcd401e51e190054ece888978/src/not_cloud/zcl_excel_ole.clas.abap#L301-L309
https://github.com/sapmentors/abap2xlsx/blob/ac5c95ace70a958bcd401e51e190054ece888978/src/zcl_excel_worksheet.clas.abap#L1409-L1422
https://github.com/sapmentors/abap2xlsx/blob/ac5c95ace70a958bcd401e51e190054ece888978/src/zcl_excel_worksheet.clas.abap#L1424-L1439
https://github.com/sapmentors/abap2xlsx/blob/ac5c95ace70a958bcd401e51e190054ece888978/src/zcl_excel_worksheet.clas.abap#L1592-L1597
https://github.com/sapmentors/abap2xlsx/blob/372fe61c759257c8d49913e1924db9bdce7aa83d/src/zcl_excel_writer_2007.clas.abap#L2285-L2299
https://github.com/sapmentors/abap2xlsx/blob/372fe61c759257c8d49913e1924db9bdce7aa83d/src/zcl_excel_writer_2007.clas.abap#L3119-L3133

I'm not the devil's advocate, just to say, here's an example of "exceptional case" (c.f. macro guidelines), which is about avoiding a huge number of lines, in standard method GET_METADATA of CL_SHM_RIS_METADATA (https://launchpad.support.sap.com/#/corrins/3006480/41), with 15,000 lines of below kind of code, combined with the context which requires the code to be compatible with ABAP < 7.40, i.e. VALUE expressions are not possible (which is currently the case of abap2xlsx):
    CLEAR ls_md.
    insert_risdata '1' 'PROG' '' 'P' ls_md-where_used.
    insert_srchgrp 'STANDARD' '' 'TEXT-S01'.
    insert_srchgrp 'EINSTELLUNG' '' ''.
    insert_srchelm 'TITLE-PROGNAME' 'STANDARD' '1' '' '' '0' 'KEY1X' '' 'PA'.
    INSERT ls_search_elements_fb INTO TABLE ls_md-search_elements.
    insert_srchelm 'TITLE-PROGNAME' 'STANDARD' '2' '' '' '0' 'KEY1' '' 'SO'.
    INSERT ls_search_elements_fb INTO TABLE ls_md-search_elements.
    ...
    insert_ris_md 'PROG' '' 'PZ'.

the 4 macros are:
    DEFINE insert_risdata.
      CLEAR ls_risdata.
      ls_risdata-group            = to_upper( &1 ).
      ls_risdata-trobjtype        = to_upper( &2 ).
      ls_risdata-subtype          = to_upper( &3 ).
      ls_risdata-legacy_type      = to_upper( &4 ).
      INSERT ls_risdata INTO TABLE &5.
    END-OF-DEFINITION.

    DEFINE insert_srchgrp.
      CLEAR ls_search_group_fb.
      ls_search_group_fb-name            = &1 .
      ls_search_group_fb-parent_group    = &2 .
      ls_search_group_fb-text_ref        = &3 .
      INSERT ls_search_group_fb INTO TABLE ls_md-search_groups.
    END-OF-DEFINITION.

    DEFINE insert_srchelm.
      CLEAR ls_search_elements_fb.
      ls_search_elements_fb-for         = &1 .
      ls_search_elements_fb-group       = &2 .
      ls_search_elements_fb-index       = &3 .
      ls_search_elements_fb-label_for   = &4 .
      ls_search_elements_fb-label_ref   = &5 .
      ls_search_elements_fb-line        = &6 .
      ls_search_elements_fb-name        = &7 .
      ls_search_elements_fb-rb_group    = &8 .
      ls_search_elements_fb-type        = &9 .
    END-OF-DEFINITION.

    DEFINE insert_ris_md.
      ls_md-trobjtype        = to_upper( &1 ).
      ls_md-subtype         = to_upper( &2 ).
      ls_md-legacy_type     = to_upper( &3 ).
      INSERT ls_md INTO TABLE lt_metadata_fb.
    END-OF-DEFINITION.

yea
this is INSERT VALUE #( something something ) INTO TABLE lt_foobar.
which we cant use in 702 syntax
on long term I propose to develop abap2xlsx in 740 syntax, and then automatically downport it to 702, a prerequsite for this is using abaplint, which requires the macros to be refactored. After refactoring the macros, we can use the upport rules in abaplint to upport it to 740. But again, this is long term

Another point which makes a macro more easy than a method is IF &1 IS SUPPLIED. You may have a look at the draft PR I have just proposed, all macros are removed (NB: I didn't test at all so it's a draft), which shows an example with SUPPLIED. I think the macros in zcl_excel_worksheet are more easy to read than the methods. If you are okay to keep the methods, I'm fine with it.

We should avoid "fix" as keyword when referencing this bug, since GH will then react by closing the report.
I suggest "WIP" for partial work addressing this issue.

Reopened, then closed again after double-checking they're all gone, sorry for the noise.

Is it a problem to reopen when needed? (and keep "fix" as text of a PR if it's a fix)

Is it a problem to reopen when needed? (and keep "fix" as text of a PR if it's a fix)

It's more of an inconvenience than a real problem, especially with long-running cleanups like the DDIC, since we can always reopen as needed.
More to the point, "fix" gives the idea that that specific commit actually solves the issue, whereas "WIP" clearly marks this as a partial solution toward the goal.

Okay, fine, I'll keep it in mind. Agreed for "WIP".
Another solution is to always have a dedicated issue/enhancement per PR, even if its goal is to facilitate the fix of another issue. This way, "fix" can be kept. For instance, enhancement #524 is difficult to do without first refactoring change_cell_style with a dedicated PR, so I would create another enhancement to support that.

Yup, I agree that having a dedicated intermediate issue as stepping stone, where possible, is a good idea.


Optimizer not doing anything on Apply/Launch/Extract

Hi! I wanted to try out the optimizer to setup my yuzu config, but whenever i click apply/launch/extract, nothing happens. The log doesn't show anything at all, and the yuzu config doesn't update - no mods are added. I'm attaching a video of my process.
I'm on Arch with i3 as VM, not sure if that matters. I'm not sure if I'm doing something wrong, but I'd expect something to happen after pressing apply - at least an error log in the console.
Any help is appreciated, thank you.
https://github.com/hoverbike1/TOTK-Mods-collection/assets/32719316/2eca88ec-acd0-45e2-9b56-bcbe676f9ff2

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

We believe this issue to be related to the OS, or the hardware config. We cannot replicate the issue.


create with_fetch_all functional

create with_fetch_all functional

Codecov Report

Merging #55 (88966a3) into main (2fd61c7) will decrease coverage by 0.22%.
The diff coverage is 94.26%.

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   98.69%   98.47%   -0.21%
==========================================
  Files          99       99
  Lines        2058     2091      +33
  Branches      256      261       +5
==========================================
+ Hits         2031     2059      +28
- Misses         21       24       +3
- Partials        6        8       +2

Impacted Files
Coverage Δ

crowdin_api/api_resources/abstract/resources.py
91.08% <84.85%> (-8.92%)
:arrow_down:

crowdin_api/api_resources/bundles/resource.py
100.00% <100.00%> (ø)

crowdin_api/api_resources/dictionaries/resource.py
100.00% <100.00%> (ø)

...rowdin_api/api_resources/distributions/resource.py
100.00% <100.00%> (ø)

crowdin_api/api_resources/glossaries/resource.py
100.00% <100.00%> (ø)

crowdin_api/api_resources/groups/resource.py
100.00% <100.00%> (ø)

crowdin_api/api_resources/labels/resource.py
100.00% <100.00%> (ø)

crowdin_api/api_resources/languages/resource.py
100.00% <100.00%> (ø)

..._resources/machine_translation_engines/resource.py
100.00% <100.00%> (ø)

crowdin_api/api_resources/projects/resource.py
100.00% <100.00%> (ø)

... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


#33 Copy Offload - Example C++ Client

Closes #33
Signed-off-by: Nate Roiger<EMAIL_ADDRESS>

Looks good. Mostly nitpicks on my part.


Functions in interfaces cannot have readonly specified but are still checked

export interface Zoo {
  (foo: Bar): void // Check for readonly but cannot have it
}

have just come across this myself this morning

Seems like there are three different ways that a function can be declared in an interface:
export interface Foo {
  (): string, // I guess this assumes the object is a function itself
  zoo(): string // This is a named function but cannot have readonly modifier
  readonly bar: () => string, // This is also a named function but can have readonly modifier
}

They way they are represented in the AST:
export interface Foo {
  (): string, // CallSignature
  zoo(): string // MethodSignature
  readonly bar: () => string, // PropertySignature
}

This is now released in 3.3.2


Use html to replace  Widget build(BuildContext context)

Hi @wch1618
Not sure if this is a proposal dart with HTML and why? Nevertheless, doesn't sound like a valid proposal.
Closing, as invalid proposla. If you disagree, please write in the comments and I will reopen it.
Thank you

OK，thanks
------------------ 原始邮件 ------------------
发件人: "Taha<EMAIL_ADDRESS>发送时间: 2020年12月4日(星期五) 下午4:14
收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS><EMAIL_ADDRESS>主题: Re: [flutter/flutter] Use html to replace  Widget build(BuildContext context) (#71698)
Closed #71698.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


Install fat flags jar

FYI @gjoranv @toregge

You will also need do add the flags directory as a subdirectory in the top level CMakeLists.txt.

Done

woops, saw the three green bullets and merged... but @toregge has verified the config server works with this PR.

👍


Module development tests with the flutter run command are inconvenient

Use case
flutter app module test ,by flutter commond or  ide,
During the production development phase, I needed to test the Flutter as a normal application. But it's very troublesome. I need to copy all the files so that I can run some tests. Android I plan to use native development and reference some Of the Flutter modules, but ios uses the whole Flutter project, so I created a module project, but Android only uses some of the features, while ios devices use all of the features. But I encountered a very difficult problem in the process of development, the module will automatically generate. Android folder, modification is usually invalid, will automatically restore.
Proposal
Module development tests with the flutter run command are inconvenient because android folders are automatically restored after modification and cannot be tested on Windows.

Hi @qssq
Can you please provide your flutter doctor -v and a minimal complete reproducible code sample so I can verify this on my end?
Thank you

why ,module launch not contain android folder,but auto genereate .android  so  auto delete. but i need keep .android folder  or include android folder

Hi @qssq, From what I understand you have a flutter module project that does not include the android folder. But when you run tests in the project, the folder is automatically generated which is not convenient for you.
So can you please provide a sample code, a simple reproducible project so i can confirm this behavior on my end too?

This does not require a demo. You have always stressed the need to provide a demo. Is it Yi? If necessary, you can create a module with the command, and then add a value under the Android project, or modify the Android manifest XML app_ Name, and then execute the operations such as fluent clean and pub get to replicate this operation. What I said about automatic deletion is that it will be restored after a series of operations, but it is normal to directly modify and then fluent run. However, I do develop based on modules, but I do not want to restore some specific properties. This is a bit of a headache.

@qssq, it is not normal to modify the contents of .android directory as it it autogenerated and the content can be changed/deleted anytime. See https://docs.flutter.dev/development/add-to-app/android/project-setup#create-a-flutter-module
There's also a discussion here why it is neccessary/or not to modify the content of the .android folder https://github.com/flutter/flutter/issues/32989
https://github.com/flutter/flutter/issues/28135
You can make changes in your wrapper android folder instead of the autogenerated .android folder.
I'll go ahead and close this as a duplicate of https://github.com/flutter/flutter/issues/23123, you can follow up the issue from there.