Resizing an image with format RH or RF produces unwanted artifacts

Godot 3.0.6
If I resize an image with the RF or RH formats to be smaller or bigger, I get unexpected dark lines, which doesn't happen with 8-bit formats. I am using this in my terrain plugin, and the result is very noticeable: https://github.com/Zylann/godot_heightmap_native_plugin/issues/38
Here with a simple resized gradient (click to see full size):

Example project:
ImageResizing.zip

Actually, this doesn't reproduce in Godot 3.1 alpha2.
Maybe has been fixed by https://github.com/godotengine/godot/commit/3fd2fc1e0159e480df6c1f01eea89a66ec89e67b

Thanks, closing as fixed then. I don't think that we'll attempt to backport 3fd2fc1 however though, unless it's strongly needed.


Expose Prometheus metrics in glbc controller

Some metrics are already collected but not exposed.
ref https://github.com/kubernetes/kubernetes/issues/40736

This change is

ref https://github.com/kubernetes/ingress/issues/238

Coverage remained the same at 46.099% when pulling fd7990de6743588fb7a68dc71bd51ee05b0829f6 on piosz:metrics into 8f23451c243d57d0ee966546fdf4560f701dcea3 on kubernetes:master.

@aledbf this is every simple change. Maybe you can take a look?

/lgtm


pull request for e2e test at 12/28/2016 04:15:06

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Cleanup unreferenced strings

This PR fixes #13854

Pull Request Test Coverage Report for Build 449375945

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.005%) to 43.081%

Files with Coverage Reduction
New Missed Lines
%

extensions/import/src/wizard/pages/fileConfigPage.ts
1
73.46%

Totals

Change from base Build 447661789:
-0.005%

Covered Lines:
24165

Relevant Lines:
51399

💛  - Coveralls


Include HTTP Headers for security

Include HTTP Headers for securit.
For exmaple:

X-XSS-Protection
X-Content-Type-Options
Strict-Transport-Security
X-Frame-Options

Reference: https://cheatsheetseries.owasp.org/cheatsheets/HTTP_Headers_Cheat_Sheet.html

[x] X-Frame-Options
[x] X-XSS-Protection
[ ] X-Content-Type-Options


No edit options

config.json file in smapi-internal not mods and has none of the bed options to edit.

Nevermind >_< I forgot to enable the mod on the vortex thingy.


Unclaimed rewards not counting towards boost - caused failed cycles

Cache unclaimed rewards from propose and use to validate on approve
The unclaimed rewards API does not have a snapshot feature where you can get data from the past.  We need to investigate a path to handle this correctly and safely.  Some suggestions:

Work with API team to add a cache=true param that returns a unique ID where we can retrieve the data used to generate the rewards and store that unique ID somewhere the approve bot can access
Save the unclaimed API data to a file / DB in AWS and have the approve bot download and compare that data to the API with some tolerance in difference between the saved data file and the API

I'll be having a discussion with @axejintao next week about scoping the API solution

Requirements doc: https://hackmd.io/@utbskePYTLmslPtU8zjZQQ/SkKcL65Ot

closed by #422


Fix auth sample to explicitly set the projectId

When explicitly setting credentials for a service, we should also advise the user to explicitly set their project id. ServiceOptions will not look for the project id in the service account json if provided (See https://github.com/GoogleCloudPlatform/google-cloud-java/issues/3386). Instead, it will still use ADC's rules for finding the projectId with may or may not be what the user intends.
Context: internal b/110528397

cc @jabubake

@hostirosti @theacodes FYI

Can we hold back on this change? It doesn't address the underlying issue of inconsistent behavior between credentials provided via GOOGLE_APPLICATION_CREDENTIALS and .setCredentials(...) using the same service account credentials both times.

@chingor13 @hostirosti Is this change still wanted? If not, are there any objections to closing the PR?

I lost track, but I believe the underlying issue was fixed iirc. Can you check with @theacodes around this? If the project id is picked up from the credentials this change is obsolete afaik.


Use Sphinx to manage docs/latest/

This commit adds https://containerd.io/docs/latest/, based on
github.com/containerd/containerd's docs directory.
We would need docs/1.6/, docs/1.5/, ... eventually. But for now
we can start from the tip of the main branch.

FYI the preview site is https://deploy-preview-120--containerd-io.netlify.app/docs/latest/.

Is this still draft?

Overall I'm LGTM on this direction; we have some things to figure out with how we point to this site and the fact that the "UI" /design isn't really aligned with the overall website, but I'm fine with that generally. At some point it would be nice to make it like going between pkg.go.dev and go.dev; that top bar is consistent across both, even though the pkg site (I assume) is generated based on doc input from the source.

We should now remove https://github.com/containerd/containerd.io/blob/main/.github/workflows/sync-releases.yml , but it can be a separate PR.

This is superseded by #121.


Custom Network Support

A new Snapshot user here, it looks like a great product 👍
The use case have for Snapshot is developing (& testing) a custom strategy against an in-memory network. When the strategy is eventually live, the CI testing will remain as part of the CI/CD pipeline (so it'll be a feature needed beyond the initial strategy development).
Although running Snapshot against a network defined outside of the networks.json is not is not currently a feature, if it is a feature you'd like, I'll happily port the changes from my open PR https://github.com/snapshot-labs/snapshot-strategies/pull/79
Generally speaking, this change switches the sourcing of the networks json from being hard-coded import to a CLI option, with the default being the network.json
The use case(s) supported by such a change are:

Running strategy tests on CI boxes
Running Snapshot against private networks

Let me. know if this is a change you'd like me to create a PR on, or if there's a better solution in this case with Snapshot 🙂
Desired behavior
Run Snapshot against a network whose definition is in a custom json file.
Actual behavior
The neworks.json from Snapshot.js is used.
Steps to reproduce the behavior
Running a test on the default strategy, with the network being a local Ethereum node.

Now it is very easy to add a network :) https://docs.snapshot.org/developer-guides/networks


Update editorconfig-code-style-settings-reference.md

Rule name dotnet_style_require_accessibility_modifiers shouldn't have a space.

@nnpcYvIVl : Thanks for your contribution! The author, @kuhlenh, has been notified to review your proposed change.


make doctests deterministic

Codecov Report

Merging #6914 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #6914      +/-   ##
============================================
+ Coverage     83.12%   83.15%   +0.03%
- Complexity    13292    13294       +2
============================================
  Files          1527     1527
  Lines         49385    49385
  Branches       5942     5942
============================================
+ Hits          41052    41068      +16
+ Misses         5546     5530      -16
  Partials       2787     2787

Impacted Files
Coverage Δ
Complexity Δ

...exceptions/GroupByOnArrayUnsupportedException.java
66.66% <0%> (-33.34%)
1% <0%> (-1%)

...main/java/io/crate/breaker/ArraySizeEstimator.java
80% <0%> (-20%)
4% <0%> (-1%)

...ore/src/main/java/io/crate/types/GeoPointType.java
75% <0%> (-6.25%)
22% <0%> (-2%)

...ate/execution/ddl/TransportSchemaUpdateAction.java
85.24% <0%> (-4.92%)
13% <0%> (-2%)

...nce/sys/check/node/DiskWatermarkNodesSysCheck.java
57.69% <0%> (-3.85%)
6% <0%> (-1%)

...ion/engine/collect/sources/ShardCollectSource.java
81.62% <0%> (-3.79%)
29% <0%> (-3%)

...expression/udf/DropUserDefinedFunctionRequest.java
91.42% <0%> (-2.86%)
10% <0%> (-1%)

...lob/src/main/java/io/crate/blob/BlobContainer.java
77.5% <0%> (-2.5%)
17% <0%> (-1%)

...er/src/main/java/io/crate/sql/tree/AstVisitor.java
25.18% <0%> (-2.23%)
34% <0%> (-3%)

...ql/src/main/java/io/crate/metadata/TableIdent.java
87.03% <0%> (-1.86%)
28% <0%> (-1%)

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a81b28...080d5de. Read the comment docs.


Fix SFNO tests in CI.

Modulus Pull Request
Description
Closes #483
Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[ ] The documentation is up to date with these changes.
[ ] The CHANGELOG.md is up to date with these changes.
[x] An issue is linked to this pull request.

Dependencies

/blossom-ci


Pdf.js cuts off everything after = (including =) on the pdf file url.

Link to PDF file (or attach file here):
https://mybucket.s3.amazonaws.com/04_HelloWorld.pdf?Signature=dFGU%252FFxw4A%253D&Expires=1466870475&AWSAccessKeyId=AJQ
Configuration:

Web browser and its version: All
Operating system and its version: All
PDF.js version: v1.5.309 (build: e908b71)
Is an extension: No

Steps to reproduce the problem:

Take any private pdf url, with signature=
Try to use the viewer.html?file=file_url
pdf.js responds with Bericht: Unexpected server response (403) while retrieving PDF "https://mybucket.s3.amazonaws.com/04_HelloWorld.pdf?Signature"
It cuts off everything after =, so the url doesn't work.

What is the expected behavior? (add screenshot)
Just work.
What went wrong? (add screenshot)
Everything.
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):
Just the default viewer, with a modified validateFileURL to make it work on amazon s3 (commented the throw new Error line).

Solved it very unelegantly by doing:
file = queryString.split('file=')[1]
on line 8403


Remove mappings which conflict with fastTabs

Removes the H and L mappings which conflict with the pre-existing fastTabs mappings.
Fixes #764

This pull request has been superseded by #787.  Closing.


[date-picker] Aria-Disabled added.

Summary
Fixes #908

I don't know that setting aria-disabled for the disabled days would necessarily fix the color-contrast issue. We initially disabled color-contrast in accessibility tests because we didn't have access to the react-datepicker styles. Now that we've forked it, my thought to fix this color contrast issues was to use a darker color for the disabled days and ultimately to remove ignoredA11y.

We'll want to check and see if setting this aria-attribute allows axe-core to pass on checking the contrast ratio for the text within it.

We'll want to check and see if setting this aria-attribute allows axe-core to pass on checking the contrast ratio for the text within it.

I removed ignoredA11y and ran wdio looks like setting aria-disabled fixes the color contrast issue mentioned. But there is another color contrast issue (ratio 3.83) which pops up due to this https://github.com/cerner/terra-framework/blob/628ae60412da7756b66ede35619c9a14f41379c6/packages/terra-date-picker/src/react-datepicker/stylesheets/react_datepicker.module.scss#L202.
Although changing it to this:
https://github.com/cerner/terra-framework/blob/628ae60412da7756b66ede35619c9a14f41379c6/packages/terra-date-picker/src/react-datepicker/stylesheets/react_datepicker.module.scss#L197 fixes the issue.
Should I make this change and remove the ignore rules for color contrast.
@benbcai @bjankord

adding @neilpfeiffer

@saket2403 I will take your changes with removing ignoredA11y and test in the theme repos to see what the impacts are.

@saket2403 I will take your changes with removing ignoredA11y and test in the theme repos to see what the impacts are.

I have tested the theme repos they are fine, will just wait for UX input on the color change @benbcai

@saket2403 I have also tested in both the clinical and fusion themes. Removing the color-contrast rule doesn't introduce any issue other than needing to update the wdio screenshots due to having to change the keyboard select background color. I think we should proceed to get a darker color from UX and remove the color-contrast rule.

UX Input
The first gray value that passes contrast ratio tests is #757575. But, if you look at that implemented in the component, that value doesn't yield enough contrast between disabled and enabled dates:

I'm seeing above what happens when ignoring this in WDIO tests, but did we try adding thearia-disabled attribute and seeing if that helped the issue?

Aria-disabled allows the test to pass without changing the gray color. The other contrast issue is for the blue color, for which we require the UX input.Primarily beacuse of these 2 lines:
https://github.com/cerner/terra-framework/blob/628ae60412da7756b66ede35619c9a14f41379c6/packages/terra-date-picker/src/react-datepicker/stylesheets/variables.scss#L5
https://github.com/cerner/terra-framework/blob/628ae60412da7756b66ede35619c9a14f41379c6/packages/terra-date-picker/src/react-datepicker/stylesheets/react_datepicker.module.scss#L202
So I need a new color for this. @jeremyfuksa

@jeremyfuksa  Sounds like adding aria-disabled to the disabled days will fix the color-contrast violation for the disabled days so a different gray color is not needed. The issue @saket2403 runs into now is the color contrast between with the background-color and the text color when a day in the calendar is preselected using the keyboard. Should we make the background-color for the pre-selected day (as well as when hovered) match what we use as the background-color for the emphasis terra-button, which is #0079be ?

Should we make the background-color for the pre-selected day (as well as when hovered) match what we use as the background-color for the emphasis terra-button, which is #0079be  or do you have a different background-color we should use?

That color will work.

Color updated and ignoreA11y removed in 271216a

@benbcai. If this PR looks good to go can we remove the Functional Review label and merge?

@saket2403 Engineering review is complete but we need @PaulSolDev to do a quick functional review and then we should be able to merge.

Functional review complete. No issues identified.


warning message on pausing a deploy

make the warning msg in RED and add more verbose msg saying something like "pause is not recommended. it should only be used in emergency case. say the implication...."

@yongwen I changed message to more verbose however, left color as-is to be consistent with other warnings/alerts in UI for ex: have warning yellow and error red.

Changed to alert danger. looks better.

verbing suggestion:  environment will not be deployed properly on new host(s) added manually or through ASG autoscaling .......

verbing suggestion: environment will not be deployed properly on new host(s) added manually or through ASG autoscaling .......

since this is merged, i have taken care of this in https://github.com/pinterest/teletraan/pull/721/files


Discriminate return type based on property in input object

TypeScript Version:  3.5.0-dev.20190509

Search Terms:
discriminate return type, keyof, extends
Expected behavior:
I want to discriminate the return type to "if a property in an object exists, return something different".
These are the 2 approaches I try, both don't work.

Using 'select' extends keyof T Playground Link

type Args = {
  select?: boolean
}

interface Search {
  findIt<T extends Args>(a: T): 'select' extends keyof T ? number : boolean
}

function Search(): Search {
  const search = () => null
  search.findIt = <T extends Args>(a: T) => a.select !== undefined ? 1 : false
  return search
}

Error:
Type '{ (): any; findIt<T extends SomeArgs>(a: T): false | 1; }' is not assignable to type 'Search'.
  Types of property 'findIt' are incompatible.
    Type '<T extends SomeArgs>(a: T) => false | 1' is not assignable to type '<T extends SomeArgs>(a: Subset<T, SomeArgs>) => "select" extends keyof T ? number : boolean'.
      Type 'false | 1' is not assignable to type '"select" extends keyof T ? number : boolean'.
        Type 'false' is not assignable to type '"select" extends keyof T ? number : boolean'.ts(2322)

Using T extends ArgsWithSelect Playground Link

type Args = {
  select?: boolean
}

type ArgsWithSelect = {
  select: boolean
}

interface Search {
  findIt<T extends Args>(a: T): T extends ArgsWithSelect ? number : boolean
}

function Search(): Search {
  const search = () => null
  search.findIt = <T extends Args>(a: T) => a.select === undefined ? false : 1
  return search
}

Error:
Type '{ (): any; findIt<T extends SomeArgs>(a: T): false | 1; }' is not assignable to type 'Search'.
  Types of property 'findIt' are incompatible.
    Type '<T extends SomeArgs>(a: T) => false | 1' is not assignable to type '<T extends SomeArgs>(a: T) => T extends SomeArgsWithSelect ? number : boolean'.
      Type 'false | 1' is not assignable to type 'T extends SomeArgsWithSelect ? number : boolean'.
        Type 'false' is not assignable to type 'T extends SomeArgsWithSelect ? number : boolean'

I'm running on<EMAIL_ADDRESS>Testing both interface definitions on a type level - they work perfectly. The only problem here is that TypeScript is not able to correctly infer the types from the ternary expression in the actual implementation.
In other words, I'm able to express this on a TypeSystem level, but I'm not able to provide an implementation that the compiler accepts.
Playground Link:
First Playground
Second Playground
Related Issues:
https://github.com/microsoft/TypeScript/issues/28597

Duplicate of #22735.

Thanks a lot for the answer! Looks like I'll have to go with an explicit return type annotation for now.


Implement RULE-2-8, project should not contain unused object definitions

Description
Implement RULE-2-8, project should not contain unused object definitions
Also add a new AlertReporting shared query library for deduplicating results across macro definitions/invocations/etc.
Split __attribute__((unused)) variables (and similar) to a Strict pair of queries.
Change request type

[ ] Release or process automation (GitHub workflows, internal scripts)
[ ] Internal documentation
[ ] External documentation
[x] Query files (.ql, .qll, .qls or unit tests)
[ ] External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

[ ] No rules added
[x] Queries have been added for the following rules:

RULE-2-8

[ ] Queries have been modified for the following rules:

rule number here

Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

The structure or layout of the release artifacts.
The evaluation performance (memory, execution time) of an existing query.
The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?

[ ] Yes
[x] No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

[ ] Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

[ ] Confirmed

Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author

[x] Have all the relevant rule package description files been checked in?
[x] Have you verified that the metadata properties of each new query is set appropriately?
[x] Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
[x] Are the alert messages properly formatted and consistent with the style guide?
[x] Have you run the queries on OpenPilot and verified that the performance and results are acceptable?As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
[x] Does the query have an appropriate level of in-query comments/documentation?
[x] Have you considered/identified possible edge cases?
[x] Does the query not reinvent features in the standard library?
[x] Can the query be simplified further (not golfed!)

Reviewer

[ ] Have all the relevant rule package description files been checked in?
[ ] Have you verified that the metadata properties of each new query is set appropriately?
[ ] Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
[ ] Are the alert messages properly formatted and consistent with the style guide?
[ ] Have you run the queries on OpenPilot and verified that the performance and results are acceptable?As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
[ ] Does the query have an appropriate level of in-query comments/documentation?
[ ] Have you considered/identified possible edge cases?
[ ] Does the query not reinvent features in the standard library?
[ ] Can the query be simplified further (not golfed!)

Apologies, I forgot I had unaddressed feedback here! Incorporated.


fix: change WebView scroll decelerationRate on iOS to match UIScrollView's behavior

Description
On iOS, scrolling WebViews wasn't feeling natural, decelerating too fast. This fixes it.
This should be the default in react-native-webview.
Tested
before
https://user-images.githubusercontent.com/57791/163124078-bc00af14-298f-4574-babe-442b3d37ce13.mp4
after
https://user-images.githubusercontent.com/57791/163124206-402f7b43-bb04-4315-909c-c27347741e7b.mp4
How others should test
The scroll behavior in WebViews should match normal ScrollViews, as seen in the video above.
Related issues
N/A
Backwards compatibility
Yes

Hey @MuckT, We have verified above issue on Latest Test flight Release build V1.30.1 & updated status in test rails.
Observation :

User is able to scroll the impact market page as normal scroll view & it does not get stuck in between

Test rail link:
iOS15: https://valoraapp.testrail.io/index.php?/tests/view/27231
Device: iPhone 13 mini(15.1.1)
CC: @jeanregisser
Thanks..!!

Hey @MuckT, We have verified above task on Latest Test flight Release build V1.30.1 & updated status in test rails.
Observation :
User is able to scroll the impact market page as normal scroll view & it does not get stuck in between
Test rail link:
iOS14: https://valoraapp.testrail.io/index.php?/tests/view/27324
Device: iPhone 12 (14.7.1)
CC: @jeanregisser
Thanks..!!


Enable running ingress conformance pre-submit.

I am totally copying the great work @tcnghia did for net-istio here, with some small tweaks.
I was able to run ./test/upload-test-images.sh and then the go test line from ./test/e2e-tests.sh manually, so 🤞
cc @tanzeeb @shashwathi
Note that I had to pass -run=Test[^U] as a HACK to skip TestUpdate until #12 is resolved.

/lgtm


Handle flaky CI failures in integration tests

See https://github.com/neo4j/neo4j/issues/13404 for context.
The neo4j 4.x container in our CI occasionally fails integration tests because we create indexes quickly without giving the database enough time for those actions to settle (roughly speaking).
This PR uses pytest-rerunfailures to retry flaky tests so that we don't need to manually re-run them.
Credit to @heryxpc for figuring this out.

cc: @chandanchowdhury FYI this should fix the CI problems


crypto/sha: implement SHA1 & SHA256 acceleration using Intel SHA extensions

This change implements SHA1 & SHA256 acceleration using the Intel SHA
extensions if those instructions are enabled. First the internal/cpu
package needs support to detect the CPU extension flag for SHA extensions.
The crypto/sha256 package contains a small refactor so that it matches how
crypto/sha1 & crypto/sha512 are set up and it makes it easier to use
consistent code in how it's decided which implementation can be used based
on CPU support.
All the work here is based on the Intel reference documentation at
https://software.intel.com/content/www/us/en/develop/articles/intel-sha-extensions.html.
Using only the reference documentation avoids issue like in #27443 where
code from another project was converted to Go assembly.
Benchmarks show a close to 2x performance improvement on an AMD Ryzen 5
3600 for SHA1:
name                       old time/op  new time/op  delta
Sha/SHA1______16_bytes-12   172ns ± 3%   105ns ± 4%  -39.06%  (p=0.000 n=20+21)
Sha/SHA1______64_bytes-12   261ns ± 2%   139ns ± 3%  -46.85%  (p=0.000 n=21+21)
Sha/SHA1_____256_bytes-12   492ns ± 2%   229ns ± 2%  -53.41%  (p=0.000 n=20+20)
Sha/SHA1______1k_bytes-12  1.17µs ± 1%  0.59µs ± 1%  -49.43%  (p=0.000 n=20+19)
Sha/SHA1______8k_bytes-12  7.48µs ± 1%  3.94µs ± 1%  -47.35%  (p=0.000 n=20+21)
Sha/SHA1____256k_bytes-12   232µs ± 2%   122µs ± 1%  -47.25%  (p=0.000 n=21+20)
Sha/SHA1___1024k_bytes-12   928µs ± 2%   491µs ± 1%  -47.12%  (p=0.000 n=21+21)
Benchmarks show a close to 4x performance improvement on an AMD Ryzen 5
3600, especially on larger inputs. Even on the smallest it's at least 2x
faster.
name                       old time/op  new time/op  delta
Sha/SHA256____16_bytes-12   248ns ± 3%   117ns ± 3%  -52.84%  (p=0.000 n=20+19)
Sha/SHA256____64_bytes-12   384ns ± 2%   153ns ± 3%  -60.10%  (p=0.000 n=20+17)
Sha/SHA256___256_bytes-12   786ns ± 1%   249ns ± 3%  -68.29%  (p=0.000 n=19+19)
Sha/SHA256____1k_bytes-12  2.36µs ± 1%  0.64µs ± 3%  -72.93%  (p=0.000 n=19+20)
Sha/SHA256____8k_bytes-12  17.0µs ± 2%   4.2µs ± 1%  -75.16%  (p=0.000 n=20+20)
Sha/SHA256__256k_bytes-12   537µs ± 1%   131µs ± 1%  -75.60%  (p=0.000 n=20+20)
Sha/SHA256_1024k_bytes-12  2.15ms ± 1%  0.52ms ± 1%  -75.60%  (p=0.000 n=20+20)
The discussion in #27443 mentions that for SHA1 including this was
debatable, since the algorithm itself is no longer considered safe. I think
that a 2x performance improvement is still significant though and there's
still a lot of places where SHA1 is still used (for example for Git itself).
Of course the SHA1 change can be backed out if this change is only desired
for SHA256 because of that.
Fixes #27443

@googlebot I signed it!

From what I understand, not all comments have been resolved?

From what I understand, not all comments have been resolved?

I have addressed & resolved all comments made in Gerrit so far, so not sure what other comments there would be?

Sorry, I think Gerrit tricked me. Might need attention from @josharian?

Closing as an implementation for SHA256 was submitted by Intel.


Compiling from source does not deliver working firmware

First; thanks for this awesome piece of software. It was exactly what I have been looking for / wanting to put together myself for a few months. But I would never have been able to get even close to this project :)
That being said, today I downloaded the source in an attempt to debug a bit of MQTT / ESPilight as I was experiencing some trouble in trying to turn an arctech dimmer completely off (which is a different issue, I might try to debug it myself and send a pull request or file another issue).
After installing the Platformio IDE and the necessary libraries I was able to compile the project. Though when uploading it (succesfully) to my NodeMCUv2 board the following error appeared:
ets Jan  8 2013,rst cause:2, boot mode:(3,6)

load 0x4010f000, len 1384, room 16
tail 8
chksum 0x2d
csum 0x2d
v614f7c32
~ld

I tried uploading the binary file via the WebUploader sketch, as well as directly form the commandline with PlatformIO. Also did a clean install of PlatformIO on my other laptop and tried with a D1 mini R2 board as well. All yield the same boot loop as result.
While trying to figure this out by myself, I tried the following code which did work and after uncommenting the settings line started boot looping again.
#include <ESP8266httpUpdate.h>
#include <ESP8266mDNS.h>
#include <FS.h>

#include <ArduinoSimpleLogging.h>
#include <WiFiManager.h>

#include <ConfigWebServer.h>
#include <MqttClient.h>
#include <RfHandler.h>
#include <Settings.h>
#include <StatusLED.h>
#include <SyslogLogTarget.h>
#include <SystemHeap.h>
#include <SystemLoad.h>

WiFiClient wifi;

// Settings settings;
ConfigWebServer *webServer = nullptr;
MqttClient *mqttClient = nullptr;
RfHandler *rf = nullptr;
SyslogLogTarget *syslogLog = nullptr;
StatusLED *statusLED = nullptr;
SystemLoad *systemLoad = nullptr;
SystemHeap *systemHeap = nullptr;

void setup() {
    Serial.begin(115200);
    Serial.println("Hello world!");
    // Logger.addHandler(Logger.DEBUG, Serial);
}

void loop() {
    Serial.println("Hello world!");
    delay(1000);
}

Both laptops run Ubuntu 17.10, PlatformIO: Home 0.9.5·Core 3.5.3b1
Source from master branch on git; commit 5418b4ec6ceaf0ecb0e110ff2df3a86cab444429 (HEAD -> master, tag: v0.1.0, origin/next, origin/master, origin/HEAD)

Thank your for trying MQTT433gateway!
Please try the binary from releases?
I can not reproduce this issue. Your output looks like a crash at boot time. May be your power supply is not sufficient.

The binary works fine generally, though as I experienced some problems with sending dimmer commands via MQTT I was trying to debug I ran into this problem.

Same here with PlatformIO 3.6.1a1 running in Atom.io 1.3, OS X High Sierra 10.13.6. Got a bunch of older Intertechno plugs, and imho the Intertechno definition is missing in ESPiLight 0.14.2, tried to compile the original version first. Hardware is a ESP8266 ESP-12E CP2102, tried it with nodemcuv2.bin and esp12e.bin, either flashed with Aton and pyFlasher 3.0 in DOUT mode. The binary release (esp12e-v0.1.0.bin) worked out of the box with the same settings, but is unfortunately without the driver for the Intertechnos. Perhaps someone could merge the actual pilight libs in ESPiLight and make a fresh binary?

Try to erase the chip first. I cannot reproduce the problem but if its "fixed" by commenting the settings loading it seems that it loads some old config that isn't really a config. This can happen when the layout in the flash-chip changes maybe because of an incompatible version of the esp toolchain to the one the original FW was build with.
You can erase the flash using the esptool that should be somewhere in your .platformio dir (e.g. ~/.platformio/packages/tool-esptool/esptool. I think the option to erase the chip was -ce but I havn't done it for a while - try -h to get the help. There is also a python-wrapper out there, that is a bit more user-friendly (search for esptool.py). And don't worry, you cannot "break" the chip with erasing the flash. The boot-from-uart works independent from it by pulling on some GPIOs (see https://github.com/espressif/esptool/wiki/ESP8266-Boot-Mode-Selection for details).

I believe, this bug is now fixed. See edbb64a76601032941498039b6e8b5990e9391a0 .

Indeed; this seems fixed. Awesome work and thanks again for this amazing project!


scipy.signal.chirp problem

Scipy.signal.chirp produces strange looking frequency sweep - see figure and example code below.

Looking at the source code for Scipy.signal.chirp pasted below:
# 'phase' is computed in _chirp_phase, to make testing easier.
phase = _chirp_phase(t, f0, t1, f1, method, vertex_zero)
# Convert  phi to radians.
phi *= pi / 180
return cos(phase + phi)
The phase from _chirp_phase should be converted from degrees to radians for numpy.cos to work correctly.
Reproducing code example:
import os
import numpy as N
import matplotlib.pyplot as plt
from scipy.signal import chirp

fStart = 5
fStop = 10005
scanTime = (8 * 60.)
fCycles = (fStop-fStart)/scanTime
numPoints = 600000
stepTime = scanTime/numPoints
t = N.linspace(0, scanTime, numPoints)
pulseSeq = chirp(t, f0=fStart, f1=fStop, t1 = scanTime, method = 'linear')
plt.plot(t,pulseSeq)
plt.show()

Error message:
The phase from _chirp_phase should be converted from degrees to radians for numpy.cos to work correctly.

Scipy/Numpy/Python version information:
('1.0.0', '1.14.0', sys.version_info(major=2, minor=7, micro=14, releaselevel='final', serial=0))

The phase returned from _chirp_phase() is already in radians, not degrees.

As the first paragraph of the chirp docstring explains, the function expects f0 and f1 to be expressed in cycles per time unit (not radians per time unit).  If the time unit is seconds, then the frequencies must be in Hz.  The function _chirp_phase already converts the phase values to radians, so that is not the source of your problem.
Your problem is aliasing.  You are varying the frequency from 5 Hz (assuming t is measured in seconds) to 10005 Hz, but your sample rate of that signal is (approximately) numPoints/scanTime, which is 1250 Hz.  To minimize aliasing, you'll have to sample at more than 20010 Hz.  20010 would be the minimum required if the bandwidth was exactly 10005 Hz, but the varying frequency undoubtedly generates higher bandwidth.  To test, try using a short time interval (so you don't have such huge samples), and increase the sample rate.

@art4206, I'm closing the issue, but don't hesitate to comment here if you have questions.


Navbar hiding details in contact us section

Describe the bug
The navbar in the contact section is hiding some part of the form .
To Reproduce
Steps to reproduce the behavior:

Go to  contactus page
Scroll down and scroll up.
See error

Expected behavior
it is hiding the first name and last name label of the form.
Screenshots
https://github.com/SurajPratap10/Imagine_AI/assets/104729493/559cf03d-6439-40ad-9a02-9383f6bd0eec
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

@SurajPratap10  kindly assign me this.....

Assigned @kumar11jr


Symbolic links can change script behavior due to lack of invocation information

Steps to reproduce
This is a symptom of #4217, which was closed due to inactivity. Per "reopen a new issue and reference this issue if this is still a blocker for you", I am submitting this bug report as an example of why this issue is not simply cosmetic and needs to be fixed.
On UNIX based operating systems it is common to create user friendly aliases to commands using symbolic links. Symbolic links should not result in functional changes to script behavior, barring the case where the script itself is evaluating the name of the command used to invoke it (similar to what busybox does). The opposite applies here: a script cannot even test for its own name when the bug presents itself.
Expected behavior
Create a file named test.ps1 with the following contents:
#!/usr/bin/env pwsh
$PSCommandPath
$PSScriptRoot
$MyInvocation

Make the script executable and create a symbolic link to test.ps1 that does not contain a suffix of ".ps1":
chmod 755 test.ps1
ln -s test.ps1 test

The output of the script should be identical regardless of how it is invoked. Invoking the script on its own yields the expected result:
PS /tmp> ./test.ps1
/tmp/test.ps1
/tmp

MyCommand             : test.ps1
BoundParameters       : {}
UnboundArguments      : {}
ScriptLineNumber      : 1
OffsetInLine          : 1
HistoryId             : 5
ScriptName            :
Line                  : ./test.ps1
Statement             : ./test.ps1
PositionMessage       : At line:1 char:1
                        + ./test.ps1
                        + ~~~~~~~~~~
PSScriptRoot          :
PSCommandPath         :
InvocationName        : ./test.ps1
PipelineLength        : 1
PipelinePosition      : 1
ExpectingInput        : False
CommandOrigin         : Runspace
DisplayScriptPosition :

Actual behavior
The output changes because the absence of a ".ps1" extension resulted in the invocation information not being populated. (#4217)
PS /tmp> ./test

MyCommand             : #!/usr/bin/env pwsh
                        $PSCommandPath
                        $PSScriptRoot
                        $MyInvocation

BoundParameters       : {}
UnboundArguments      : {}
ScriptLineNumber      : 0
OffsetInLine          : 0
HistoryId             : 1
ScriptName            :
Line                  :
Statement             :
PositionMessage       :
PSScriptRoot          :
PSCommandPath         :
InvocationName        :
PipelineLength        : 2
PipelinePosition      : 1
ExpectingInput        : False
CommandOrigin         : Runspace
DisplayScriptPosition :

Error details
No response
Environment data
Name                           Value
----                           -----
PSVersion                      7.4.1
PSEdition                      Core
GitCommitId                    7.4.1
OS                             Ubuntu 22.04.4 LTS
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
No response

Try running both from bash instead of PowerShell. What you will see is that when run with the ps1 extension PowerShell interprets it directly and ignores the #!/usr/bin/env pwsh. Without the ps1 extension PowerShell will simply use the fork/exec to run it.
So when run from PowerShell with the ps1 extension much more is known than running using the "#!/usr/bin/env pwsh" executable prefix.
On another note, remove the symbolic link so you only have "test.ps1" and PowerShell will run ./test by looking for a ./test.ps1 and running that.

On a final note, PowerShell should not have to follow OS symbolic links to find out what something is referring to when executing a program and neither should it be reading an executable and trying to determine how it has been implemented, that is the job of the exec system call.

To simplify analysis and drive the point home, I will provide additional examples that are executed from bash. I am also removing the /usr/bin/env abstraction in favor of an absolute path in the shebang line.

test2.ps1 - Same as test1.ps1, but an absolute path in the shebang line.
test2link - A symbolic link to test2.
test3 - The contents are exactly the same as test2.ps1. The only difference is the name of the file.

# what shell is this running in?
$ readlink /proc/$$/exe
/usr/bin/bash

# create a symbolic link named test2link that points at test2.ps1
$ ln -s test2.ps1 test2link

# copy test2.ps1 to test3
$ cp test2.ps1 test3

# confirm that all three files produce the same sha1sum
$ sha1sum test2.ps1 test2link test3
49b77df919a70469a111ab644d0eea5650ef2b4b  test2.ps1
49b77df919a70469a111ab644d0eea5650ef2b4b  test2link
49b77df919a70469a111ab644d0eea5650ef2b4b  test3

# confirm the contents of test2.ps1 before we begin
$ cat test2.ps1
#!/opt/microsoft/powershell/7/pwsh
$PSCommandPath
$PSScriptRoot
$MyInvocation

$ ./test2.ps1
/tmp/test2.ps1
/tmp

MyCommand             : test2.ps1
BoundParameters       : {}
UnboundArguments      : {}
ScriptLineNumber      : 0
OffsetInLine          : 0
HistoryId             : 1
ScriptName            :
Line                  :
Statement             :
PositionMessage       :
PSScriptRoot          :
PSCommandPath         :
InvocationName        : /tmp/test2.ps1
PipelineLength        : 2
PipelinePosition      : 1
ExpectingInput        : False
CommandOrigin         : Runspace
DisplayScriptPosition :

$ ./test2link

MyCommand             : #!/opt/microsoft/powershell/7/pwsh
                        $PSCommandPath
                        $PSScriptRoot
                        $MyInvocation

BoundParameters       : {}
UnboundArguments      : {}
ScriptLineNumber      : 0
OffsetInLine          : 0
HistoryId             : 1
ScriptName            :
Line                  :
Statement             :
PositionMessage       :
PSScriptRoot          :
PSCommandPath         :
InvocationName        :
PipelineLength        : 2
PipelinePosition      : 1
ExpectingInput        : False
CommandOrigin         : Runspace
DisplayScriptPosition :

$ ./test3

MyCommand             : #!/opt/microsoft/powershell/7/pwsh
                        $PSCommandPath
                        $PSScriptRoot
                        $MyInvocation

BoundParameters       : {}
UnboundArguments      : {}
ScriptLineNumber      : 0
OffsetInLine          : 0
HistoryId             : 1
ScriptName            :
Line                  :
Statement             :
PositionMessage       :
PSScriptRoot          :
PSCommandPath         :
InvocationName        :
PipelineLength        : 2
PipelinePosition      : 1
ExpectingInput        : False
CommandOrigin         : Runspace
DisplayScriptPosition :

Illustration that other shells provide consistent invocation information:
$ cat bash.sh
#!/bin/bash
echo $0

$ ln -s bash.sh bashlink

$ chmod 755 bash.sh

$ sha1sum bash.sh bashlink
78fd4ed1622a581ca0a81676dbf83ce644ca85f8  bash.sh
78fd4ed1622a581ca0a81676dbf83ce644ca85f8  bashlink

$ ./bash.sh
./bash.sh

$ ./bashlink
./bashlink

## Debian's dash shell
$ cat dash.sh
#!/bin/dash
echo $0

$ ln -s dash.sh dashlink

$ chmod 755 dash.sh

$ sha1sum dash.sh dashlink
f0763356461e8a06757e20eff2fef3883dbf15d8  dash.sh
f0763356461e8a06757e20eff2fef3883dbf15d8  dashlink

$ ./dash.sh
./dash.sh

$ ./dashlink
./dashlink

From your tests I think it suggests that the behaviour of PowerShell depends on the ps1 extension rather than the symbolic link. If it is a ps1 extension then MyCommand is the path to the script, if not it is the full contents of the file. It literally does not know it is a script file so it just reads the contents as the command to run and tries to interpret it.
Notice that with ps1 extension you then have invocation name populated with the path to the script. Even with the ps1 extension the PSScriptRoot was not populated.
UNIX shells however do not care about extensions, Using *.sh is merely a convention, not a requirement. PowerShell comes from windows where the extension cmd, bat, exe, com is important in determining how to handle executable files.
Despite its name, PowerShell is not a UNIX shell, it is much more like Perl or Python and I suggest that consistency with PowerShell  across each platform is more important than trying to emulate behaviour from UNIX shells.

From your tests I think it suggests that the behaviour of PowerShell depends on the ps1 extension rather than the symbolic link.

Correct. As mentioned before this is a symptom of #4217, which describes this exact behavior. My intent was to highlight that this behavior could create functional differences in script behavior with little more than a symbolic link, which is concerning from UNIX administrator's perspective.

Despite its name, PowerShell is not a UNIX shell, it is much more like Perl or Python and I suggest that consistency with PowerShell across each platform is more important than trying to emulate behaviour from UNIX shells.

I respectfully submit that this is a false equivalence. Your cited examples provide a consistent interface to invocation information. Of the shells and languages that have been discussed in these comments, Powershell is the only one I am aware of that masks the user facing interfaces to the name of the script depending on how the file is named. If you can provide a counter example I will happily concede the point, but my experience with Linux, Perl, and Python all suggest that this is not the case.

UNIX shells however do not care about extensions, Using *.sh is merely a convention, not a requirement. PowerShell comes from windows where the extension cmd, bat, exe, com is important in determining how to handle executable files.

I would not certainly expect a Python script to directly execute on a Windows OS if it lacked a .py suffix. Likewise, I would not expect a Powershell script to directly execute on a UNIX based OS if I did not either modify it to include a shebang line and apply an executable bit. Prefacing the Python or Powershell script with the path to the intended interpreter allows both scripts to run without modification.
The difference between these is that Powershell simply makes no attempt to populate the invocation information if the suffix does not end in ps1. Python does not do this with its extension. Perl does not do this with its extension. It is happening because of a design choice inside of the interpreter, not because it has to.
If this is the design choice of the Powershell developers and they intend to be the sole interpreter that deviates from common UNIX conventions, this is fine. Questionable, but fine. I will not belabor the point, but I do want the community to understand that this is the reason why this behavior persists and not because there is a lack of understanding as to why this should change. (as per #4217)

@rhubarb-geek-nz, to add to @blightbow's comment:

The behaviour of PowerShell depends on the ps1 extension

Indeed - and it shouldn't.

It literally does not know it is a script file so it just reads the contents as the command to run and tries to interpret it.

It does know that it is a script file, because a shebang line is translated by the system into passing the file path to the interpreter specified in the shebang line.
In short: The problem is the lack of "self-awareness" when an extension-less script is executed  - whether explicitly or via a shebang line -  and this lack is clearly a bug.

The behaviour of PowerShell depends on the ps1 extension

Indeed - and it shouldn't.

Within PowerShell itself, if you run a script with a ps1 extension it is run within the same process. Without ps1 it has no idea what kind of executable it is so uses fork/exec, this will run the script or executable in a separate process. This is existing behaviour.

Within PowerShell itself, if you run a script with a ps1 extension it is run within the same process. Without ps1 it has no idea what kind of executable it is so uses fork/exec, this will run the script or executable in a separate process. This is existing behaviour.
In comparison, UNIX shells always run a new script in a separate process unless you dot-source them.

This sounds like a consequence of an interpreter that needs to fork its behavior to handle multiple formats of text files without standardizing on a default one. It also sounds like behavior that could be solved with a simple commandline switch, or (ironically) a symlink to the pwsh executable with different behavior. :)
I understand that there will be significant inertia to implementing these solutions, but it also stands to reason that Powershell appears to be the only modern text interpreter with this design problem that I've seen on a UNIX OS. (again, I am happy to concede to counter-examples) Occupying such a unique design constraint that differentiates Powershell from other interpreters does in fact suggest that an alternative startup mode is warranted.

@rhubarb-geek-nz, here's a self-contained example that demonstrates that PowerShell does know what file path it was invoked with via a shebang line (by design resulting in  a separate PowerShell (child) process, but that  is beside the point); as noted in my previous comment this is system-level behavior, unrelated to PowerShell:
@'
#!/usr/bin/env pwsh
[pscustomobject] @{
  CommandLine = [Environment]::GetCommandLineArgs()[1]
  PSCommandPath = $PSCommandPath
}
'@ > foo
chmod a+x foo
./foo  # Effectively the same as: pwsh -File "$PWD/foo"

There is no justification for PowerShell not reflecting the given script-file path in $PSCommandPath / $PSScriptRoot / $MyInvocation simply because the file path happens not to have a .ps1 extension.

There is no justification for PowerShell not reflecting the given script-file path in $PSCommandPath / $PSScriptRoot / $MyInvocation simply because the file path happens not to have a .ps1 extension.

The current behaviour does support passing /dev/fd/4 or similar as the command line argument to pwsh eg to support remote servers for example. It's current behaviour is it isn't a script file but I can try and read it, either a socket or a pipe.

To be clear: The following aspects are incidental to the issue at hand:

That files with extension .ps1 files run in-process by design - whether or not they have as shebang line.

Whether or not a shebang line-based script that happens to use PowerShell as its interpreter is invoked via a symlink (if you create a .ps1 symlink that targets an extension-less shebang line-based script, things work as expected, with the symlink's path being reflected in $PSCommandPath)

@rhubarb-geek-nz:

support passing /dev/fd/4 or similar

That's because its default CLI parameter is -File, expecting a path to a file as the argument whose content is PowerShell code. Of course this means that you may also pass  that path of special files such as /dev/fd/4 (from Bash, try  pwsh <(echo '[Environment]::CommandLine')) - again, this has nothing to do with the issue at hand.

This is not problem of symbolic link itself but the name of file. With ps1 extension scripts and theirsymlinks working in pwsh and bash as expected:
$ dir aaa*,bbb*,ccc*,ddd*,eee*

    Directory: /tmp

UnixMode     Num   UID   GID      LastWriteTime    Size Name
--------     ---   ---   ---      -------------    ---- ----
-rwxr-xr-x   755  1000  1000   02.04.2024 12:56      63 aaa.ps1                       # working
-rwxr-xr-x   755  1000  1000   02.04.2024 12:56      63 bbb                           # not working
lrwxrwxrwx   755  1000  1000   02.04.2024 12:58       9 ccc -> ./aaa.ps1              # not working
lrwxrwxrwx   755  1000  1000   02.04.2024 12:59       9 ddd.ps1 -> ./aaa.ps1          # working
lrwxrwxrwx   755  1000  1000   02.04.2024 13:07       3 eee.ps1 -> bbb                # working

@rhubarb-geek-nz, the - to me problematic - pseudo-interactive behavior with - (stdin, both with -File and -Command) is yet another issue, unrelated to the bug at hand - see #3223

On Posix PowerShell does attempt to run other types of files by reading their content and interpreting as a series of PowerShell statements.

That's pretty much how all shells and interpreters work (POSIX-compatible shells, Python, Ruby, Perl, ...); PowerShell on Windows, with its requirement that the file have extension .ps1, is the exception. Given PowerShell's need to support shebang line-based scripts on Unix-like platform, this restriction had to be lifted there (along with switching the default CLI parameter from -Command to -File).
While it's good to know workarounds (suggestion: %~dp0test.ps1 -> "%~dpn0.ps1") and have background information, I suggest we stay focused on the bug at hand, which is fully described above.

That's pretty much how all shells and interpreters work

I meant absolutely literally, if the file has a ps1 extension then MyCommand contains the filename, if not then it contains the file contents.

While it's good to know workarounds

It certainly is, it stops issues being treated as show stoppers, it unblocks people from working now and gives you a backward compatible solution and the bug fix may be months or years away if ever.

if the file has a ps1 extension then MyCommand contains the filename, if not then it contains the file contents.

Yes, PowerShell choosing do to that - inappropriately - appears to be the bug.
Agreed re workarounds - if succinctly presented, while acknowledging the bug and avoiding distractions.


Fix test using assume APIs, which landed concurrently to API renames

The PR https://github.com/apple/swift/pull/64800/ had been using assume APIs in the tests which changed concurrently to merging this PR, resulting in a broken compile of the test.
This unbreaks the build and CI -- cc @rintaro

@swift-ci please smoke test and merge

Resolves rdar://107541711


White column of pixels outside borders on second monitor when maximized

Whenever Chatterino is open, maximized, and focused, there are about 8 white pixels that appears next to the window on the other monitor.
This can be seen below:

(Those white pixels appear on the other monitor).
Chatterino 2.2.2-fix (commit a82f57f94), Windows 10 Build 19042.746

Please search for issues prior to making a new one in future.
Duplicate of https://github.com/Chatterino/chatterino2/issues/2205

Please search for issues prior to making a new one in future.
Duplicate of https://github.com/Chatterino/chatterino2/issues/2205


Idea: move debouncing from hooks into dendriform itself

Allows debouncing to be used anywhere a .set() can take place. Perhaps as form.set("new", 200)

Added in 2.0.0-alpha-9. Might need to add something to allow optimistic values coming straight out of dendriform forms, but not yet.


Update azd credential order in DAC

Adjust the README section and XML docs to reflect reality, as defined in: https://github.com/Azure/azure-sdk-for-net/blob/e2018b09bd902d4bdd21329f4c825146bea1c011/sdk/identity/Azure.Identity/src/DefaultAzureCredentialFactory.cs#L31

API change check
API changes are not detected in this pull request.


Which target names should be standardized?

Thought I'd get the ball rolling. I can think of a few target names we probably need to come up with:

Installing dependencies
Testing
Test code coverage
Opening test coverage reports
Pre-commit checks
Pre-publishing
Running the app/server
Building for release
Building for debugging

Agreeing on some standard project "types", and what each target means in each context would probably useful too. I'm thinking along the lines of library vs. app, compiled vs. not (maybe even app vs. server?)

(maybe even app vs. server?)

Do you mean web-app in this context?

Do you mean web-app in this context?

Maybe? But also potentially more of a long running server vs. command line tool type split. Not sure if there would actually be a meaningful difference in Makefiles for those.

Yeah, I see. From the perspective of Go, at least, I see no need to make a distinction there.
I think the naming we have been using so far is still largely OK, some quick notes/questions on each below:

Installing dependencies - vendor or deps, advise against install as in the *nix world this typlically means "install the built app onto the system"
Testing - I see no reason to change from test
Test code coverage - I see no reason to change from coverage
Opening test coverage reports - I have taken to using coverage-open, just as its easier for autocompletion imo (vs open-coverage).
Pre-commit checks - IIRC this is the one where we use prepare but this already has some meaning to NPM or Node more generally?
Pre-publishing - Meaning pruning dev dependencies etc?
Running the app/server - It's reasonably common IME to have multiple binaries in a single repo, so there's not necessarily "an app". I typically define a run target in the project-specific Makefile, rather than attempting to do this generically.  We can probably do better.
Building for release - release - as per C++/compiled language world
Building for debugging - debug - as per C++/compiled language world

Cool, I agree with all of that.

Pre-commit checks - IIRC this is the one where we use prepare but this already has some meaning to NPM or Node more generally?

Yes, NPM and Yarn support prepare as a script type. It has to do with "preparing" a package for publishing to the NPM registry. In most cases that means transpiling.

Pre-publishing - Meaning pruning dev dependencies etc?

More like transpiling before publishing to the NPM registry, similar to what prepare means in the JS world (https://docs.npmjs.com/misc/scripts#prepublish-and-prepare).

Running the app/server - It's reasonably common IME to have multiple binaries in a single repo, so there's not necessarily "an app". I typically define a run target in the project-specific Makefile, rather than attempting to do this generically.  We can probably do better.

That's fair. In the case of "servers" I'm not sure if a distinction needs to be made between:

Running a server that "hosts" the current project as an application (i.e. the case of a project that uses something like webpack-dev-server)
Running the current project, which is a server itself


how to make portrait mode❓

Question
I want to implement portrait mode with background blur, can you please tell me if this can be done?
What I tried
i tried use enablePortraitEffectsMatteDelivery
VisionCamera Version
2.15.0
Additional information

[ ] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar questions in the issues page as well as in the discussions page and found none.

any update on this ?

Closing as this is a stale issue - this might have been fixed with the full rewrite in VisionCamera V3 (🥳) - if not, please create a new issue.
If your issue has been fixed, consider sponsoring me on GitHub to say thanks 💖


[Feature] Multi dub w/ season constraints

I created this because there are times where i want to get multiple dubs within a series but i cant do that with -s and --srz uses indexes rather than episode numbers for ordering. With this change the following output will be generated when using both -s and --srz:
[E1|SGY2PCV21D] TSUKIMICHI -Moonlit Fantasy- - Season 1 - Failed... Hero [Japanese, English, Portuguese, Spanish]
[E2|SGY2PCV21D] TSUKIMICHI -Moonlit Fantasy- - Season 1 - Black Spider of Disaster [Japanese, English, Portuguese, Spanish]
[E3|SGY2PCV21D] TSUKIMICHI -Moonlit Fantasy- - Season 1 - Human Shock [Japanese, English, Portuguese, Spanish]
[E4|SGY2PCV21D] TSUKIMICHI -Moonlit Fantasy- - Season 1 - Too Late [Japanese, English, Portuguese, Spanish]
[E5|SGY2PCV21D] TSUKIMICHI -Moonlit Fantasy- - Season 1 - The Greedy Wagon's Journey [Japanese, English, Portuguese, Spanish]
[E6|SGY2PCV21D] TSUKIMICHI -Moonlit Fantasy- - Season 1 - The Melancholy of Handsome Middle-Aged Men [Japanese, English, Portuguese, Spanish]
[E7|SGY2PCV21D] TSUKIMICHI -Moonlit Fantasy- - Season 1 - Wondrous Medicine Production [Japanese, English, Portuguese, Spanish]
[E8|SGY2PCV21D] TSUKIMICHI -Moonlit Fantasy- - Season 1 - Demiplane Ranking [Japanese, English, Portuguese, Spanish]
[E9|SGY2PCV21D] TSUKIMICHI -Moonlit Fantasy- - Season 1 - Eat or Be Eaten [Japanese, Portuguese, Spanish, English]
[E10|SGY2PCV21D] TSUKIMICHI -Moonlit Fantasy- - Season 1 - Hidden Ogre Village [Japanese, Portuguese, Spanish, English]
[E11|SGY2PCV21D] TSUKIMICHI -Moonlit Fantasy- - Season 1 - Goodbye [Japanese, Portuguese, Spanish, English]
[E12|SGY2PCV21D] TSUKIMICHI -Moonlit Fantasy- - Season 1 - Guided by the Moon... [Japanese, Portuguese, Spanish, English]
[E1|SG69PC2JJ4] TSUKIMICHI -Moonlit Fantasy- Season 2 - Season 2 - What? Moon over the Ruined Castle? [☆ Japanese, ☆ English, ☆ Portuguese, ☆ Spanish]
[E2|SG69PC2JJ4] TSUKIMICHI -Moonlit Fantasy- Season 2 - Season 2 - The Heroes Are a Couple of Beauties [☆ Japanese, ☆ English, ☆ Spanish, ☆ Portuguese]
[E3|SG69PC2JJ4] TSUKIMICHI -Moonlit Fantasy- Season 2 - Season 2 - Stellar Wars [☆ Japanese, ☆ English, ☆ Portuguese, ☆ Spanish]
[E4|SG69PC2JJ4] TSUKIMICHI -Moonlit Fantasy- Season 2 - Season 2 - Why Am I a Teacher?! [☆ Japanese, ☆ English, ☆ Portuguese, ☆ Spanish]
[E5|SG69PC2JJ4] TSUKIMICHI -Moonlit Fantasy- Season 2 - Season 2 - The Lesson Will Now Begin [☆ Japanese, ☆ Portuguese, ☆ Spanish, ☆ English]
[E6|SG69PC2JJ4] TSUKIMICHI -Moonlit Fantasy- Season 2 - Season 2 - Becoming a Three-Star Chef [☆ Japanese, ☆ Spanish, ☆ Portuguese, ☆ English]
[E7|SG69PC2JJ4] TSUKIMICHI -Moonlit Fantasy- Season 2 - Season 2 - New Member Audition [☆ Japanese, ☆ English, ☆ Portuguese, ☆ Spanish]
[E8|SG69PC2JJ4] TSUKIMICHI -Moonlit Fantasy- Season 2 - Season 2 - The Notorious Beautiful Sisters [☆ Japanese, ☆ English, ☆ Portuguese, ☆ Spanish]
[E9|SG69PC2JJ4] TSUKIMICHI -Moonlit Fantasy- Season 2 - Season 2 - The Perverted Dragon [☆ Japanese, ☆ English]
[E10|SG69PC2JJ4] TSUKIMICHI -Moonlit Fantasy- Season 2 - Season 2 - Watch As I Improve the World [☆ Japanese]
[E11|SG69PC2JJ4] TSUKIMICHI -Moonlit Fantasy- Season 2 - Season 2 - Summer of Growth and New Skills [☆ Japanese]

With this, it sorts by season_id and episode (using season numbers is convoluted with cr's api)
if you exclude -s it falls back to the original format of using indexes (so it'll be number 1-23...etc) so overall this will retain the same functionality, but with the added effect that using -s will constrain it to the season and allow -e to use the episode number of that season.

While the code looks good and appears to work, I do have a couple questions.

When adding a season constraint by ID, wouldn't it be better not to show the other seasons in the first place? It may be confusing to see everything that isn't in the constraint. If that is done, then the Season ID next to the episode also becomes unnecessary. (It would also allow for --all for multi-dub on a specific season in a --srz)
When you say ordering, do you mean the order of the list specifically, or the resulting episode number ordering?

Yes I just didn't change the logs to reflect that. I'll change it.
Episode numbering, like when im searching episode 11 in a series (while i was using -s) I was expecting to get episode 11 of season 2 but it gave me episode 11 of season 1 because it ignored the -s param.

@AnimeDL I've made the changes

Alright, did some more testing and this does seem to break the GUI in it's current state due to ./gui/server/services/crunchyroll.ts L22, since data isn't passed data.s doesn't exist and throws an exception. Once that's fixed, this is probably good to go

Alright, I changed it.
One a side node if you're still looking to have the specials be located at the end of the episode listing (in the TODO comment) doing something like:
const specials = Object.entries(episodes).filter(a => a[0].startsWith('S')),
      normal = Object.entries(episodes).filter(a => a[0].startsWith('E')),
      sortedEpisodes = Object.fromEntries([...normal, ...specials]);

After they get prepended with E and S would work, then have then have the console.info for loop and the return object use sortedEpisodes

LGTM, Merging


Error / incorrect values returned from FrameMetadata methods

FrameMetadata object is assigned to every packet that comes out of the DepthAI pipeline.
However, not every field is being initiated, and sometimes calling them may result in strange large numbers (like<PHONE_NUMBER>), segfaults etc.
In most of the cases, the following methods should WORK:

getCameraName
getInstanceNum
getSequenceNum
getTimestamp

These methods will be available for frames coming from left / right / color / previewout streams. Others, like metaout or jpegout, may have these invalid.
The following methods most probably WON'T WORK:

getCategory
getFrameBytesPP
getFrameHeight
getFrameWidth
getFrameType
getStride

They were added a nice-to-have's, but as we migrate to #136, they won't be fixed to return correct values, and instead we'll focus on Gen2 not having these issues

This is fixed in gen2 for a while.


[Bug]: Homepage UI is broken on mobile screen on release-ee

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Homepage UI is broken on mobile screen on release-ee:

Also, in certain scenarios extra space is showing up on desktop home page:

Steps To Reproduce
Open home page for release-ee on mobile. See that the UI is broken.
Public Sample App
No response
Environment
Release
Issue video log
No response
Version
Self Hosted - latest

Fixed


be online

i want install it an make it online. but, as i know vps does't support for installing cuda. how u make in online? (like demo)

waifu2x.udp.jp is hosted on AWS EC2 GPU Instance (g2.2xlarge or g2.8xlarge).

so. its not vps like DO. thats so expensive for me. :smile:

can waifu2x run on ordinary vps?

No. My implementation requires CUDA and GPU. But other implementation (e.g. waifu2x-converter-cpp) can run on ordinary vps with CPU mode.

okay. arigatou :laughing:


Updated Dockercompose

Redis dependency was missing
Issue Reference
This PR addresses the Issue : Fixes #
Summarize
Please, describe what the PR does, the changes you have made.

Also, mention the key points if any to look into while code reviews

hey can we link all the tests under one issue. So we can add each issue as its sub issue say #562
this will ease tracking tests


Unexpected Numbers Displayed in Angular Material Datepicker Calendar

Description
I am using Angular Material's mat-datepicker in my Angular project. The datepicker UI is displaying incorrect numbers instead of proper dates (see screenshot). I want to show a proper calendar for date selection.
Note: I have already imported all the required Angular Material modules, including MatDatepickerModule, MatInputModule, and MatNativeDateModule,
Here's the relevant code snippet:

Choose a To date
<input
matInput
readonly
[min]="selectedFromDate"
[matDatepicker]="ToDatepicker"
[(ngModel)]="selectedToDate"
(dateChange)="onDateChange($event.value, 'addedon', 'lte')"
placeholder="MM/DD/YYYY"
/>
<mat-icon matSuffix [for]="ToDatepicker">event
<mat-datepicker #ToDatepicker>

Reproduction
StackBlitz link:
Steps to reproduce:
1.
2.
Expected Behavior

Actual Behavior

Environment

Angular:
CDK/Material:
Browser(s):
Operating System (e.g. Windows, macOS, Ubuntu):

What locale are you on and which date adapter are you using?

Looks like an issue with the styles. The columns are too wide and squish the last 3 days, so the correct numbers are partially overlapping.

This is most likely a case of styles bleeding in from other parts of the app and overriding Material's styles.

This is most likely a case of styles bleeding in from other parts of the app and overriding Material's styles.

Yes, this was indeed the issue. The td, th { width: 25%; } style was overriding Material's styles. After removing or adjusting it, everything works fine now.


make k8s deployment script executed

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

master node deployed. I think we can merge it if there is no other comments.
I'm working on slave node deployment


Update supposed Anticheat for Arena Breakout: Infinite

Game Title
Arena Breakout: Infinite
Status of the Anti-Cheat
🚫 Denied
Tinkering Steps
It is using ACE Anticheat instead of the supposed EasyAntiCheat.
Proof of Mention
https://twitter.com/AntiCheatPD/status/1791269132626763924

Did you mean to mark this as Denied? Did the developers say they aren't going to work on supporting Linux? Alternatively, do the ACE devs have a anti-Linux stance that made you mark it like you did?

@Starz0r commented on May 19, 2024, 1:20 AM GMT+2:

Did you mean to mark this as Denied? Did the developers say they aren't going to work on supporting Linux? Alternatively, do the ACE devs have a anti-Linux stance that made you mark it like you did?

Actually, nope. It's just the Github template, that asked me to add a status. I'll edit it normally to confirm the unconfirmed status.


Refactor divider component

This is the first time im working with TS. Please point out things I can improve. I mainly copied from the button element. Implements #43

@frankadrian thanks for your PR, though we are still preparing environment for community contributions. Please remove demo folder and .js files from your PR and squash your commits into one.

@m0t0r, sure done.

@frankadrian LGTM, just one thing. Please change commit message to follow conventional-changelog
refactor(elements): Refactor sm-divider component to TS

would work

@frankadrian there is a conflict with last merge to master, could you please resolve it and I will merge your PR.

@m0t0r sure, base is up to date.


Spyder 4.1.4 Starting the Kernel Error

I checked other pages and tried everything that I could find but I couldn't resolve the issue.
Issue Report Checklist

[x] Searched the issues page for similar reports
[x] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[x] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[x] Could not reproduce inside jupyter qtconsole (if console-related)
[x] Tried basic troubleshooting (if a bug/error)

[x] Restarted Spyder
[x] Reset preferences with spyder --reset
[x] Reinstalled the latest version of Anaconda
[x] Tried the other applicable steps from the Troubleshooting Guide

[x] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
After "update --all", my kernel is not starting.
What steps reproduce the problem?
See above
1.
2.
3.
What is the expected output? What do you see instead?
N/A
Paste Traceback/Error Below (if applicable)
An error ocurred while starting the kernel
The error is:
Traceback (most recent call last):
File "C:\Users\fberks\Anaconda3\lib\site‑packages\spyder\plugins\ipythonconsole\plugin.py", line 1223, in create_kernel_manager_and_kernel_client
kernel_manager.start_kernel(stderr=stderr_handle)
File "C:\Users\fberks\Anaconda3\lib\site‑packages\jupyter_client\manager.py", line 304, in start_kernel
kernel_cmd, kw = self.pre_start_kernel(**kw)
File "C:\Users\fberks\Anaconda3\lib\site‑packages\jupyter_client\manager.py", line 251, in pre_start_kernel
self.write_connection_file()
File "C:\Users\fberks\Anaconda3\lib\site‑packages\jupyter_client\connect.py", line 468, in write_connection_file
self.connection_file, cfg = write_connection_file(self.connection_file,
File "C:\Users\fberks\Anaconda3\lib\site‑packages\jupyter_client\connect.py", line 138, in write_connection_file
with secure_write(fname) as f:
File "C:\Users\fberks\Anaconda3\lib\contextlib.py", line 113, in enter
return next(self.gen)
File "C:\Users\fberks\Anaconda3\lib\site‑packages\jupyter_core\paths.py", line 435, in secure_write
win32_restrict_file_to_user(fname)
File "C:\Users\fberks\Anaconda3\lib\site‑packages\jupyter_core\paths.py", line 377, in win32_restrict_file_to_user
win32security.SetFileSecurity(fname, win32security.DACL_SECURITY_INFORMATION, sd)
pywintypes.error: (87, 'SetFileSecurity', 'The parameter is incorrect.')
 Maybe you could try updating/installing jupyter_core 4.6.3 (running something like conda install jupyter_core=4.6.3). Also, you could try to create another env.
Hopefully this info will let you fix your env, but there is not much more we can do, sorry :/


Move mesh generation to vispy

Description

I've added a benchmark to check for regressions when switching to updating the mesh with every slice event.
Based on my understanding, calling refresh should trigger both on_data_change and set_view_slice. This means that refresh should encompass the mesh code in both locations and be as close to apples to apples as possible.
That said, I'm not certain whether refresh should be called more than once in order to capture the additional burden of recalculating the mesh with every slice. I believe that in the old code, there was basically a check to see if anything had changed and if not, the mesh wasn't recalculated. This would mean that running refresh multiple times on the old code should be less computationally expensive than the new code unless the reduction to only generate the mesh in the slice subset is sufficiently efficient.
TLDR - I benchmarked against calling refresh in the test function once, and again with three consecutive calls to refresh.
RESULTS:
call refresh once
**old code**
[100.00%] ··· ======== =============
               param1
              -------- -------------
                 16     2.81±0.02ms
                 64     4.67±0.09ms
                256      10.2±0.1ms
                1024     36.3±0.8ms
                4096     74.6±0.2ms
               16384      110±1ms
               65536      250±3ms
              ======== =============

**new code**
[100.00%] ··· ======== =============
               param1
              -------- -------------
                 16     2.93±0.03ms
                 64     4.70±0.06ms
                256      10.5±0.1ms
                1024     38.1±0.9ms
                4096     75.8±0.4ms
               16384     122±0.8ms
               65536      298±2ms
              ======== =============

call refresh 3 times
**old code**
[100.00%] ··· ======== =============
               param1
              -------- -------------
                 16      8.30±0.1ms
                 64     13.9±0.07ms
                256      31.2±0.3ms
                1024     105±0.6ms
                4096      216±1ms
               16384      326±6ms
               65536      756±9ms
              ======== =============

**new code**
[100.00%] ··· ======== =============
               param1
              -------- -------------
                 16     8.63±0.02ms
                 64     14.3±0.09ms
                256      32.0±0.2ms
                1024     106±0.7ms
                4096      224±2ms
               16384     358±0.8ms
               65536      896±4ms
              ======== =============

Type of change

[ ] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

I added this benchmark as a qt benchmark because otherwise, the benchmark wasn't getting into on_data_change. It was strange because when I ran the same commands through pytest, I could have gotten away with not instantiating the viewer (I think). If there is a better approach, I'm happy to hear it!
How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change
[ ] example: I check if my changes works with both PySide and PyQt backends
as there are small differences between the two Qt bindings.

Final checklist:

[x] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

@sofroniewn Is this git approach what you're looking for? https://github.com/sofroniewn/napari/pull/17

curious why is this PR closed? is there a git problem or?


Use RibbonClientConfiguration as default for configuration in @RibbonClient

Currently, if wants to config Ribbon with @RibbonClient, it has to set configuration of @RibbonClient and RibbonClientConfiguration is suitable for most of it. So setting RibbonClientConfiguration as default for configuration in @RibbonClient makes code simple as @RibbonClient("foo")

I am not sure I am following what you are saying, can you be more concrete?  Maybe using some code examples?

here is PR https://github.com/spring-cloud/spring-cloud-netflix/pull/1342

RibbonClientConfiguration is already the default.

See https://github.com/spring-cloud/spring-cloud-netflix/blob/master/spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/ribbon/SpringClientFactory.java#L41 which specifies it as a default.

@spencergibb With this default, @RibbonClient("foo") should read server list from configuration foo.ribbon.listOfServers. However, it says No instances available for foo due to empty server list (it has two servers configured for foo.ribbon.listOfServers ). By the way, I use zookeeper service-discovery, so it also has another default from RibbonZookeeperAutoConfiguration

If you include zookeeper or eureka or consul, those become the default server lists. #927 supports setting NIWSServerListClassName=com.netflix.loadbalancer.ConfigurationBasedServerList and then your list of servers.
It's helpful when creating an issue to tell us why you want or need something rather than telling us what to change. Your comment you just left is what you should have started with.


Request to Publish Extension on open-vsx.org

Hello,
Thank you for developing the jupyter-renderers extension; it's been very useful! I noticed that the extension is available on the Microsoft Marketplace but not on open-vsx.org, which is an open-source alternative that serves the broader community, including VSCodium users.
Would you consider publishing your extension on open-vsx.org as well? It would benefit users who prefer or are required to use open-source software. The process is outlined here: Publishing Extensions.
Thank you for considering this request. I'm looking forward to continuing to use jupyter-renderers in my development environment.
Best regards,
Tony

Closing as duplicate of https://github.com/microsoft/vscode-jupyter/issues/13919


Cant run object_deteection_app.py

Hi guys, I tried to run object_deteection_app.py but I has this error
`phong@Storm:~/PycharmProjects/Object-Detector-App-master$ python object_detection_app.py
[DEBUG/MainProcess] created semlock with handle<PHONE_NUMBER>90176
[DEBUG/MainProcess] created semlock with handle<PHONE_NUMBER>86080
[DEBUG/MainProcess] created semlock with handle<PHONE_NUMBER>16736
[DEBUG/MainProcess] Queue._after_fork()
[DEBUG/MainProcess] created semlock with handle<PHONE_NUMBER>12640
[DEBUG/MainProcess] created semlock with handle<PHONE_NUMBER>08544
[DEBUG/MainProcess] created semlock with handle<PHONE_NUMBER>04448
[DEBUG/MainProcess] Queue._after_fork()
[DEBUG/MainProcess] created semlock with handle<PHONE_NUMBER>00352
[DEBUG/MainProcess] created semlock with handle<PHONE_NUMBER>96256
[DEBUG/MainProcess] created semlock with handle<PHONE_NUMBER>92160
[DEBUG/MainProcess] created semlock with handle<PHONE_NUMBER>88064
[DEBUG/MainProcess] added worker
[DEBUG/PoolWorker-2] Queue._after_fork()
[DEBUG/PoolWorker-2] Queue._after_fork()
[INFO/PoolWorker-2] child process calling self.run()
[DEBUG/MainProcess] added worker
[DEBUG/PoolWorker-3] Queue._after_fork()
[DEBUG/PoolWorker-3] Queue._after_fork()
[INFO/PoolWorker-3] child process calling self.run()
[DEBUG/MainProcess] Queue._start_thread()
[DEBUG/MainProcess] doing self._thread.start()
[DEBUG/MainProcess] starting thread to feed data to pipe
[DEBUG/MainProcess] ... done self._thread.start()
2017-06-28 11:10:45.146711: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.1 instructions, but these are available on your machine and could speed up CPU computations.
2017-06-28 11:10:45.146755: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.2 instructions, but these are available on your machine and could speed up CPU computations.
2017-06-28 11:10:45.146776: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX instructions, but these are available on your machine and could speed up CPU computations.
2017-06-28 11:10:45.254015: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.1 instructions, but these are available on your machine and could speed up CPU computations.
2017-06-28 11:10:45.254073: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.2 instructions, but these are available on your machine and could speed up CPU computations.
2017-06-28 11:10:45.254082: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX instructions, but these are available on your machine and could speed up CPU computations.
2017-06-28 11:10:45.300271: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:893] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2017-06-28 11:10:45.301197: I tensorflow/core/common_runtime/gpu/gpu_device.cc:940] Found device 0 with properties:
name: GeForce GTX 1070
major: 6 minor: 1 memoryClockRate (GHz) 1.7085
pciBusID 0000:02:00.0
Total memory: 7.92GiB
Free memory: 7.43GiB
2017-06-28 11:10:45.301219: I tensorflow/core/common_runtime/gpu/gpu_device.cc:961] DMA: 0
2017-06-28 11:10:45.301227: I tensorflow/core/common_runtime/gpu/gpu_device.cc:971] 0:   Y
2017-06-28 11:10:45.301238: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1030] Creating TensorFlow device (/gpu:0) -> (device: 0, name: GeForce GTX 1070, pci bus id: 0000:02:00.0)
2017-06-28 11:10:45.390544: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:893] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2017-06-28 11:10:45.390759: I tensorflow/core/common_runtime/gpu/gpu_device.cc:940] Found device 0 with properties:
name: GeForce GTX 1070
major: 6 minor: 1 memoryClockRate (GHz) 1.7085
pciBusID 0000:02:00.0
Total memory: 7.92GiB
Free memory: 302.94MiB
2017-06-28 11:10:45.390785: I tensorflow/core/common_runtime/gpu/gpu_device.cc:961] DMA: 0
2017-06-28 11:10:45.390793: I tensorflow/core/common_runtime/gpu/gpu_device.cc:971] 0:   Y
2017-06-28 11:10:45.390824: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1030] Creating TensorFlow device (/gpu:0) -> (device: 0, name: GeForce GTX 1070, pci bus id: 0000:02:00.0)
2017-06-28 11:10:46.907853: E tensorflow/stream_executor/cuda/cuda_blas.cc:365] failed to create cublas handle: CUBLAS_STATUS_NOT_INITIALIZED
2017-06-28 11:10:46.907894: W tensorflow/stream_executor/stream.cc:1601] attempting to perform BLAS operation using StreamExecutor without BLAS support
[INFO/PoolWorker-2] process shutting down
[DEBUG/PoolWorker-2] running all "atexit" finalizers with priority >= 0
[DEBUG/PoolWorker-2] running the remaining "atexit" finalizers
Process PoolWorker-2:
Traceback (most recent call last):
File "/usr/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap
self.run()
File "/usr/lib/python2.7/multiprocessing/process.py", line 114, in run
self._target(*self._args, **self._kwargs)
File "/usr/lib/python2.7/multiprocessing/pool.py", line 97, in worker
initializer(*initargs)
File "object_detection_app.py", line 79, in worker
output_q.put(detect_objects(frame, sess, detection_graph))
File "object_detection_app.py", line 49, in detect_objects
feed_dict={image_tensor: image_np_expanded})
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 789, in run
run_metadata_ptr)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 997, in _run
feed_dict_string, options, run_metadata)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 1132, in _do_run
target_list, options, run_metadata)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 1152, in _do_call
raise type(e)(node_def, op, message)
InternalError: Blas SGEMM launch failed : m=22500, n=64, k=32
[[Node: FeatureExtractor/MobilenetV1/MobilenetV1/Conv2d_1_pointwise/convolution = Conv2D[T=DT_FLOAT, data_format="NHWC", padding="SAME", strides=[1, 1, 1, 1], use_cudnn_on_gpu=true, _device="/job:localhost/replica:0/task:0/gpu:0"](FeatureExtractor/MobilenetV1/MobilenetV1/Conv2d_1_depthwise/Relu6, FeatureExtractor/MobilenetV1/Conv2d_1_pointwise/weights/read)]]
[[Node: Postprocessor/BatchMultiClassNonMaxSuppression/MultiClassNonMaxSuppression/Minimum_31/_1185 = _Recvclient_terminated=false, recv_device="/job:localhost/replica:0/task:0/cpu:0", send_device="/job:localhost/replica:0/task:0/gpu:0", send_device_incarnation=1, tensor_name="edge_7609_Postprocessor/BatchMultiClassNonMaxSuppression/MultiClassNonMaxSuppression/Minimum_31", tensor_type=DT_INT32, _device="/job:localhost/replica:0/task:0/cpu:0"]]
Caused by op u'FeatureExtractor/MobilenetV1/MobilenetV1/Conv2d_1_pointwise/convolution', defined at:
File "object_detection_app.py", line 107, in
pool = Pool(args.num_workers, worker, (input_q, output_q))
File "/usr/lib/python2.7/multiprocessing/init.py", line 232, in Pool
return Pool(processes, initializer, initargs, maxtasksperchild)
File "/usr/lib/python2.7/multiprocessing/pool.py", line 159, in init
self._repopulate_pool()
File "/usr/lib/python2.7/multiprocessing/pool.py", line 223, in _repopulate_pool
w.start()
File "/usr/lib/python2.7/multiprocessing/process.py", line 130, in start
self._popen = Popen(self)
File "/usr/lib/python2.7/multiprocessing/forking.py", line 126, in init
code = process_obj._bootstrap()
File "/usr/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap
self.run()
File "/usr/lib/python2.7/multiprocessing/process.py", line 114, in run
self._target(*self._args, **self._kwargs)
File "/usr/lib/python2.7/multiprocessing/pool.py", line 97, in worker
initializer(*initargs)
File "object_detection_app.py", line 71, in worker
tf.import_graph_def(od_graph_def, name='')
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/framework/importer.py", line 311, in import_graph_def
op_def=op_def)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/framework/ops.py", line 2506, in create_op
original_op=self._default_original_op, op_def=op_def)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/framework/ops.py", line 1269, in init
self._traceback = _extract_stack()
InternalError (see above for traceback): Blas SGEMM launch failed : m=22500, n=64, k=32
[[Node: FeatureExtractor/MobilenetV1/MobilenetV1/Conv2d_1_pointwise/convolution = Conv2D[T=DT_FLOAT, data_format="NHWC", padding="SAME", strides=[1, 1, 1, 1], use_cudnn_on_gpu=true, _device="/job:localhost/replica:0/task:0/gpu:0"](FeatureExtractor/MobilenetV1/MobilenetV1/Conv2d_1_depthwise/Relu6, FeatureExtractor/MobilenetV1/Conv2d_1_pointwise/weights/read)]]
[[Node: Postprocessor/BatchMultiClassNonMaxSuppression/MultiClassNonMaxSuppression/Minimum_31/_1185 = _Recvclient_terminated=false, recv_device="/job:localhost/replica:0/task:0/cpu:0", send_device="/job:localhost/replica:0/task:0/gpu:0", send_device_incarnation=1, tensor_name="edge_7609_Postprocessor/BatchMultiClassNonMaxSuppression/MultiClassNonMaxSuppression/Minimum_31", tensor_type=DT_INT32, _device="/job:localhost/replica:0/task:0/cpu:0"]]
[INFO/PoolWorker-2] process exiting with exitcode 1
[DEBUG/MainProcess] cleaning up worker 0
[DEBUG/MainProcess] added worker
[DEBUG/PoolWorker-4] Queue._after_fork()
[DEBUG/PoolWorker-4] Queue._after_fork()
[INFO/PoolWorker-4] child process calling self.run()
2017-06-28 11:10:49.761792: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.1 instructions, but these are available on your machine and could speed up CPU computations.
2017-06-28 11:10:49.761841: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.2 instructions, but these are available on your machine and could speed up CPU computations.
2017-06-28 11:10:49.761849: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX instructions, but these are available on your machine and could speed up CPU computations.
2017-06-28 11:10:49.871478: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:893] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2017-06-28 11:10:49.871800: I tensorflow/core/common_runtime/gpu/gpu_device.cc:940] Found device 0 with properties:
name: GeForce GTX 1070
major: 6 minor: 1 memoryClockRate (GHz) 1.7085
pciBusID 0000:02:00.0
Total memory: 7.92GiB
Free memory: 7.26GiB
2017-06-28 11:10:49.871817: I tensorflow/core/common_runtime/gpu/gpu_device.cc:961] DMA: 0
2017-06-28 11:10:49.871824: I tensorflow/core/common_runtime/gpu/gpu_device.cc:971] 0:   Y
2017-06-28 11:10:49.871836: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1030] Creating TensorFlow device (/gpu:0) -> (device: 0, name: GeForce GTX 1070, pci bus id: 0000:02:00.0)`
I see my webcam work but there is no windows openning after that.
One more weird thing is I can run object_detection_multiplayer.py with no problem.
Please help me to fix it !

I think you are running this with multiple workers and GPU. It was not intended to run this with GPU. Have a look at here if you still want to use GPU. Valikund gave a solution to run this with multiple workers/GPU. The reason why you could run the object_detection_multiplayer.py is because it has only 1 worker.

Dear Datitran, thanks for your code, I learn a lot from them.
But I have a question about about GPU use in this APP,  my computer have a GPU GXT1060, WIN7，memory 8G , when I run this APP, it is auto run GPU, sometimes it will work well, but sometimes it show that there is not enough memory. then the APP crash, and computer not response.
Today I saw that you mention that you don't suggest use GPU for this APP, so my question is that

How to set the APP, then when I run this APP, it will not use GPU.
Thank you very much

@l-chenyao well I said that I don't recommend to use it with GPU because my code is not optimized for it. If you want to use it with GPU, you need to do a couple of things. First of all, you need to limit the memory consumption of GPU (see https://github.com/datitran/object_detector_app/issues/4). TensorFlow usually reserves entire GPU memory even though it is not using everything. This is problematic if you have a couple of workers running at the same time. So that's why you have this random behavior because sometimes not all workers are taking every memory. Secondly, I'm using feed_dict to read in the data. This is okay for CPU but not good for GPU. For GPU, it would be better to use queues but well this is more an optimization aspect.


Feature Request: dh-parameters regeneration UI/schedule

Talking to Fitch in IRC we came up with a few ideas to keep dh-parameters fresh:

have a warning in the webui if they are past a certain age based on modification date
save a hash of the files on install, and on updates if the hash matches it's safe to overwrite with a newer system one; rehash
regen new files each update
Allow users to set a cronjob (nice -n 20) to refresh them, maybe with weekly or monthly options, also a button to regen on demand (like if they get the warning it's old) with time of day to make sure it's off-peak

Thanks! So what we need first is a function that wraps getting the correct du parameters file: self-generated or standard file provided by core package. When we have this we can automatically select the file that is newer, other logic as we come up with later.

Looks like filemtime will tell you when the file was last modified http://php.net/manual/en/function.filemtime.php
I would bundle the hash of the last few dh-parameter versions, maybe going back to whatever date you think is too stale, and have a notification when you login to the webui if it's stale.
Maybe even just forcing it's replacement even if it's custom but too old. Once the system overwrites the files with defaults from an update, the file with the hashes only needs to keep the hash of the currently installed file
Another thing to consider is if the admin installs other key lengths than the default… Does the system recognize those like pfsense does? If so they should be checked and the option given to admins to regen those as well, but they might want to do that remotely since they take so long to generate.

I was thinking every minor update provide new dh files, and those replace the installed unless a custom job is scheduled or the installed ones are older than 1-3 month default (configurable under advanced)
There should also be logic to allow admins to override generation esp if OpenVPN can use up to a 16k dh. Then they should be checked by mod date (not creation) and hashed, and yell at admins when they get stale. Would be nice to decide which files get generated on the machine as well, faster boxes may never want to use provided dh but only generate them on the box.
Shared random numbers aren't random really :-)

Shared random numbers aren't random really :-)

Low entropy is not to be confused with higher but shared entropy.
Obviously we can't update DH parameters every release as it takes too much time and there is no randomness guarantee. And I don't see a lot of benefit from registering past entropy records or allowing more fine-grained local regeneration other than "use shared file or update weekly/monthly/custom" with a cron job to use as one sees fit.
This state will be in 18.1.10. Every additional submission and improvement is welcome of course.

Last bits via 00429edb9 await testing and backport.


Remove some secrets from client in multiplayer game

Fix #399 .
My current understanding: In the multiplayer game, undo and redo also must be handled by server, but there is no implementation now (in src/master/master.js) .
I explicitly disabled these features to fix #399 for now. I think we can implement multiplayer undo/redo,  but its priority doesn't seems so high... does it?
Checklist

[x] Use a separate branch in your local repo (not master).
[x] Test coverage is 100% (or you have a story for why it's ok).

@nicolodavis Is this change acceptable? If it's okay I'll add the test cases.

@nicolodavis Thank you for reviewing! I think I understood. I made changes and rebased on master branch.

Made some small changes and added an interactive example.

Thanks for the fix, @qsona!
I think there are still a couple of issues with the undo / redo mechanism that are not ideal:

Right now any player can call undo at any time (you can even undo another player's move).  We should restrict this to only ctx.currentPlayer (https://github.com/nicolodavis/boardgame.io/issues/345).

After this PR, all the undo logic is handled on the server for a multiplayer game.  The client merely sends an undo message to the server and has the wait for the response before its move is undone.  This can be laggy in case the network is slow.  We should instead not override the local copy of _undo during an UPDATE.  That way the client can undo its move immediately and the server later just sends an update that enables other players to see that a move has been undone.

Something like this in reducer.js:
+      case Actions.UPDATE: {
+        // Override local state, but don't touch _undo or _redo.
+        if (state !== null) {
+          const { _undo, _redo } = state;
+          return { ...action.state, _undo, _redo };
+        }
+        return action.state;
+      }

Let me know if you'd be interested in working on either of these.

@nicolodavis Thank you for describing the remaining issues. I'm interested in solving them. For 1, I've sent a PR #408 . For 2, I'd like to work on this issue if sometime I have enough time, but actually it's hard to promise (a bit busy for a while).

Thanks @qsona!  Will take a look at your PR.
Don't worry about the other one if you don't have time.  I'll probably get down to it eventually.


Add support to Instrinsic Height

Is it possible to add instrinsic height support?
return IntrinsicHeight(
     child: ExpandablePageView(
       children: [
         Container(
           color: Colors.pinkAccent,
           height: 200,
         ),
         Container(
           color: Colors.greenAccent,
           height: 150,
         ),
         Container(
           color: Colors.blueGrey,
           height: 340,
         ),
       ],
     ),
   );

Expected result is all the children should get the taller child's height

Hi @balaji101010, material PageView is built in a way that does not work with IntrinsicHeight. Even if I was able to create such functionality, it would only work with regular ExpandablePageView constructor and would not work with .builder because in the latter case we would not know the sizes of all children because they are not laid out yet.
Because of the inconsistencies it would introduce (would work with one constructor but wouldn't work with the other) I need to resign from implementing this feature.
To suggest some solution, maybe you could use a regular PageView, collect all your children sizes after they are first built using WidgetsBinding.instance.addPostFrameCallback and set your PageView's size to match the biggest child.
I'm going to close this issue for now, let me know if you have any other questions.


New mantainer

Hey I want to maintain this extension as I use everyday in my tablet. I already have a fork working and published in gnome extensions.
If you accept I would like to take the main name or contribute back here so we don't have two extensions in the store.
What do you think?
https://extensions.gnome.org/extension/7196/maximized-by-default-reborn/

+1 for adding a new maintainer.
Though I think it would be best to rebase on @matthijskooijman's changes, given he was first to provide support for later Gnome versions: https://github.com/aXe1/gnome-shell-extension-maximized-by-default/pull/13.
And it could be worth seeing if there's anything worth pulling in from: https://github.com/darkretailer/gnome-shell-extension_maxi.
I'd recommend perusing a repo's PRs and network graph on GitHub to avoid duplicate effort in future 😉

This post suggests that asking on the gnome shell mailing list might be a working strategy:  https://lists.gnome.org/archives/gnome-shell-list/2015-January/msg00019.html
As for a new maintainer: I am interested in this extension and will probably continue to keep it working as long as I use it myself, but I already have a ton of projects that I maintain that do not receive the attention they deserve. So I would rather not take over maintainership, but am still interested in contributing and happy to help merging my changes back.

Hey @aXe1, sorry for the delay, I was in a work trip.
I've made changes to the fork and opened this PR #15 so we can upstream the necessary changes to support newest Gnome versions.
I use this extension everyday on my tablet, so I'm happy to maintain it going forward.
Thanks for the work!

+1, this extension is excellent (I hate every moment of my GNOME experience without it) and it's sadly going out of date. Please continue maintaining it/add more maintainers and keep it up to date with the latest GNOME versions!

Thank you for the work on this helpful tool! Has there been any progress regarding an updated version?


Changed %lld to use mingw supported PRId64

This resolves part of the ruby build errors blocking release.

Addressed comments.

LGTM.