Reproduce the result from HuggingFace

Hi,
Text2Video-Zero code open at huggingface.co/spaces
It requires A100 GPU to run, Can you help me implement the code to run on Colab?
Thanks for your research!
Best regards,
Tin Nguyen Thanh

I only use P100 run my current code on Kaggle, you can also try it.

Thanks, I ran your code on Colab Tesla T4 GPU, it works.
Looking forward to your work!

I update version 2, you can try it too.

Thank! I will try it.

Thanks, I ran your code on Colab Tesla T4 GPU, it works.
Looking forward to your work!

can u share demo please, wanna try it

Ok, Wait for me a few minutes

Hi,
I sent Text2Video-Zero-Colab

huggingface.co/spaces

its nice, i will try it

Hi @JiauZhang
Updated Text2Video-Zero code with Pose and Canny, Please update!

Hi @JiauZhang
Updated Text2Video-Zero code with Pose and Canny, Please update!

I will add these feature this week.

Thank for your work!

Update: GPU VRAM 12 GB Supported

Got it.
The model is the same. Theoretically, only batch size and some intermediate variables can cause different memory usage

Hi, Thank you for the explanation!


ktor-jwt + toml

Merge branch jwt-auth (which is a fork of branch toml) that adds support to webhook-service for verifying json web tokens for certain paths/topics. These are defined in the routes file that now uses toml format.

@williamhogman Thank you for the feedback. I think the code is in a better state now and also slightly more testable.


Recommend chmod 700 OMERO.server directory

https://trello.com/c/xDMnFnPd/498-fix-omero-web-var-permissions
https://github.com/openmicroscopy/openmicroscopy/pull/3818

etc and var contain sensitive data, and on shared machines should be protected.

Is it possible/appropriate to do what's suggested here in, say, https://github.com/ome/omero-install/blob/f8fc523c1bedf2d4ce853a3a6ea22d868f16c7df/linux/system_setup.sh#L4 ?

Yes, I'll take out the chmod $HOME and chmod the server directory. Are there any other security issues worth mentioning (bearing in mind the walkthrough needs to be as simple as possible)?

Doh. The OMERO.web static files are in lib/python/omeroweb

@manics : I would assume that's feasible. Worst-case, we add a simple README.txt to var/.

Reads fine & is a good start before we try to go too far in warning new users.


Make an integration test for disabling oauth_body_hash

The PR making this an toggle feature has been merged. However, the tests were pretty minimal. Let's add an integration test for body_hash_enabled when it's both true and false to test Consumer all the way through.
I'll assign this to myself and get to it in the next month or so.

@pboling Please assign this to me and I'll take care of it.

@chuckremes ping 😄


The ensembleMLP used in IPL-IQL algo value calculation

Does this ensembleMLP perform as the same character as the ensemble reward models in normal PbRL?
Thanks for your paper and codes.

EnsembleMLP supports ensemble size of one or more. I wrote the code this way to be maximally flexible. In practice, I use ensemble size of 1 for the value and reward function, as is consistent with other works in offline PbRL. In online PbRL, an ensemble of reward functions is used to estimate uncertainty for selecting new queries, but we don't do that in offline PbRL so I didn't ensemble the reward function.
See: https://github.com/jhejna/inverse-preference-learning/blob/main/configs/metaworld/mr_iql.yaml#L31 where nothing except the Q function is ensembled.

Thanks for your explaination!


feat: Bump Firebase iOS SDK to 9.4.1

Description
See title.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[ ] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] The analyzer (melos run analyze) does not report any problems on my PR.
[ ] I read and followed the Flutter Style Guide.
[ ] I signed the CLA.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[X] No, this is not a breaking change.

Awaiting the next Firebase iOS SDK release that is tagged and released on cocoapods.


[Swift] add simple heuristic to detect incomplete DLOs during read ops

This is similar to waitForSegmentsToShowUp (cf. #1650) which is called during Close/Commit. Intuitively, you wouldn't expect missing segments to be a problem during read operations, since the previous Close/Commit confirmed that all segments are there.
But due to the distributed nature of Swift, the read request could be hitting a different storage node of the Swift cluster, where the segments are still missing.
Load tests on my team's staging Swift cluster have shown this to occur about once every 100-200 layer uploads when the Swift proxies are under high load. The retry logic, borrowed from waitForSegmentsToShowUp, allows the Registry to skip past this temporary inconsistency.
Tip: View the diff with ?w=1.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "swift/wait-for-dlo-segments-during-read" git@github.com:majewsky/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "swift/wait-for-dlo-segments-during-read" git@github.com:majewsky/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

[Current coverage][cc-pull] is 54.50%

Merging [#1710][cc-pull] into [master][cc-base-branch] will decrease coverage by -13.08%

2 files (not in diff) in ...ge/driver/middleware were modified. more

Partials +4
Hits -4

2 files (not in diff) in ...rage/driver/inmemory were modified. more

Partials +23
Hits -23

5 files (not in diff) in ...istry/storage/driver were modified. more

Misses +807
Partials +25
Hits -860

14 files (not in diff) in registry/storage were modified. more

Misses +3
Partials +56
Hits -59

6 files (not in diff) in registry/proxy were modified. more

Partials +41
Hits -41

9 files (not in diff) in registry/handlers were modified. more

Misses +3
Partials +117
Hits -120

2 files (not in diff) in ...try/client/transport were modified. more

Misses +6
Partials +10
Hits -16

3 files (not in diff) in registry/client/auth were modified. more

Partials +23
Hits -23

3 files (not in diff) in registry/client were modified. more

Misses -4
Partials +70
Hits -70

2 files (not in diff) in registry/auth/token were modified. more

Partials +33
Hits -33

@@             master      #1710   diff @@
==========================================
  Files           121        119      -2
  Lines         10578      10064    -514
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           7149       5485   -1664
- Misses         3429       4111    +682
- Partials          0        468    +468

Powered by Codecov. Last updated by [4ecea4b...b21833b][cc-compare]
[cc-base-branch]: https://codecov.io/gh/docker/distribution/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/docker/distribution/compare/4ecea4b311d968fb789e30a78c8c6510996a9183...b21833b555b8d8e40a536ae10b7ccd164750478c
[cc-pull]: https://codecov.io/gh/docker/distribution/pull/1710?src=pr

Can we merge this? The patch has been running fine in production in my team's Registry for two weeks now.

This seems fine to me.  I'd like someone else with swift knowledge to look at this though @nevermosby @lebauce

Is this good to go? Would like to have this in 2.5 so that I can switch back to the official images in my prod env.

Code LGTM.  The 2.5 release cutoff has already passed.  You can use the distribution/registry image once it's merged rather than maintain your own.


add flat_map to list, deprecate concat_map

add immut/list.flat_map to replace concat_map

Pull Request Test Coverage Report for Build 2669
Details

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.06%) to 78.89%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

immut/list/list.mbt
0
3
0.0%

Totals

Change from base Build 2667:
-0.06%

Covered Lines:
3382

Relevant Lines:
4287

💛  - Coveralls

Is keep concat_map and deprecate it in favor of flat_map a better option? It could serve as a documentation as a guide to use flat_map.
As my experience, sometimes I can't recall flat_map and just got concat_map in my mind.


feat(contract): add convenience methods to EIP712Facet

Added external view functions DOMAIN_SEPARATOR and nonces to EIP712Facet for easier access. Updated deployment script to include new selectors in constructor.
Required for #878.

tests?

They come from ERC20Permit so tests are almost futile unless you insist.


Update Nino's discord invite link as it doesn't works since a long ago

;)

@hyduez can u send me the nino's discord server pls¿
DC: brxnn#9649

click here

done


Some method to handle insecure-registries

For some use-cases it is necessary to set insecure-registries (registries that provide no or untrusted certificates). There was a possibility in Docker Desktop to set these setting. We should provide a way to handle this somehow.

I believe one issue at the moment is that every change you apply inside of the docker wsl instance gets removed with a future update.

see https://github.com/cloudflightio/dockerinwsl#how-to-configure


Tetris

PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #1535

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[ ] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @chinmayjain08 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Performing changes in main readme

Thank you  @chinmayjain08 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

we already have this game on GameZone you can do enhancement if you want !!


Added support for soft updates in DQN algo and agent.

This commit adds soft target updates (already available in SAC) to DQN. The implementation mirrors that of SAC. The default behaviour remains unchanged.

Hey thanks, I like it!  And the strip_ddp business is already inside update_state_dict anyway, clean!


Suggestion: add a command to remove all Moodles on a character.

I tend to use one of several Moodles at a given time when I take different appearances, and I have a "revert" macro for when I return to my default appearance. However, as the plugin currently acts, this revert macro must individually remove all Moodles, as it does not know which appearance I was in (and therefore which Moodle I had) upon execution. This causes scaling issues, as the number of Moodles I'll have to remove increases with each appearance I devise. This may eventually break the macro line cap.
I suggest adding a command to remove all Moodles at once. Anyone using one of multiple options would benefit, and even those who want to maintain a constant Moodle can use the current workflow or re-enable their desired Moodles within the same macro (assuming they fit within the line limit).

W idea, adding that!
It would follow the same command structure as all the other commands:
/moodle remove target moodle|preset all

The all selector should now work for remove, add, toggle on moodles and presets as of update <IP_ADDRESS>


Switch to Bintray/JCenter/JFrog OSS for publishing of artifacts

Due to reported constant problems with uploading to ossrh we need to see and check how can we use the repositories provided by Bintray (JCenter and JFrog OSS).
Checklist/progress/TODO:

[x] Add subplugin for Knotx/knotx-gradle-plugins (jcenter-publish)
[x] Verify connection with Bintray, and the ability to upload packages
[x] Figure out if there exist a possible way of handling snapshots (as this is not available by default in the unpaid plan of Bintray for OSS projects)
[ ] Implement and test Artifactory as a subplugin (plugin that can handle snapshots as well as releases)
[ ] Verify that the developed solution works well in simple and composite Knot.x modules/projects

Connections between Bintray, JCenter, JFrog OSS, and Artifactory
JCenter: artifact repo, like Maven Central but better
JFrog Bintray: provides simple per-user or per-organisation artifact repositories. Packages from these repos can be uploaded to JCenter, and then propagated to Maven Central. Bintray can sign the packages via its own GPG key. No snapshot support for OSS projects (available in paid enterprise plan). Bintray keys are used for interacting with every JFrog solution.
JFrog Artifactory: "universal repository manager", enterprise solution for hosting various artifacts, not only Maven's. Also has a Gradle plugin for magically interacting with these repositories.
JFrog OSS: Artifactory repos dedicated for OSS projects, can be used to host releases as well as snapshots. Requires an opt-in request to be submitted for each individual package for hosting there.
Remarks and risk analysis

We can use Bintray as-is, without the hassle of interacting with OSS Artifactory repos, but only releases would be supported (no -SNAPSHOTs).
Setting up snapshot repository @ JFrog OSS could prove to be difficult due to how we have Gradle subplugins set up. There's no option for using Kotlin DSL in Artifactory Gradle Plugin, which ramps up the difficulty by a few orders of magnitude - we might have to develop some kind of custom DSL/middleware that would fix these compatibility problems (and get rid of difficulties in Kotlin-Groovy interop).

Sources, links, worth-a-read
Gradle Bintray Plugin:
https://github.com/bintray/gradle-bintray-plugin
Snapshots and Bintray:
https://stackoverflow.com/questions/47872069/confused-about-process-to-publish-snapshots-to-bintray
Snapshotting at JFrog OSS:
https://www.jfrog.com/confluence/display/RTF/Deploying+Snapshots+to+oss.jfrog.org
Artifactory plugin JFrog help:
https://www.jfrog.com/confluence/display/RTF/Gradle+Artifactory+Plugin
Source for how we interact with Bintray Gradle plugin:
https://github.com/Cognifide/gradle-aem-plugin/blob/master/gradle/publish.gradle.kts

Ticket for the only outstanding bug in knotx-gradle-plugins: Knotx/knotx-gradle-plugins#5
Some more testing will need to be done after above is fixed, including verifying multi-artifact projects (composite projects). The only tests that I have done have been with knotx-junit5 as a testing ground.

You should reconsider this https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/


Feature stl generation

STLs are generated directly using Trimesh and Manfold3d packages (added to dependencies). Tests and tutorial will be added/improved. Everything regarding Onshape was removed.

The code is ready. Can you review it please? I will create tests afterwards when all needed features are approved.

@Legersky and I have solved the merge conflicts with the current dev branch and we made the two packages trimesh and manifold3d as optional, similarly as we did for the package lnumber.
Would it be possible for you to please add the tests?

Thanks for solving the conflict. Okay, added try-except to check for the installation and return import error in this case. I will do the tests now.

From my side it is ready to merge.

I would like to ask for one more thing: since the method automatically generates many stl files, running the tests and compiling the documentation creates quite a lot of them which is not so nice. The only "solution" coming to my mind now is to accept also a parameter folder_name, so that they could be at least grouped in a subfolder. What do you think? Any other idea?

The folder would have to exist already. If it doesn't exist, the os.path or pathlib has to be imported in used to check/create a folder. Do you want it this way?

Yes, please, since in the tests we cannot guarantee the existence of a folder.

Yes, please, since in the tests we cannot guarantee the existence of a folder.

Done


Volume not working

I bought a Roku owing to the remote being listed in the Fdroid repository. Thank you. Volume controls pop up but don't seem to be working.

Are you using the app with a Roku TV or private listening? If not, then this is the expected behavior.


Idea: Ability to pause / resume conversation

I want to realise feature for pause / resume conversation.
Use case:
For example i have bot with catalog of goods, listed by inline controls.
User see needed item and click "Add to basket". Bot ask quantity of items and save it to storage and pause conversation, for user can continue list catalog from last position.
When user want to add another item - conversation resume and etc.
And the finish line user view him basket and finish order (stopped) or cancel it.
What do you think, guys?

I think that's a great idea and a nice addition 🎉
Feel free to create a PR and some example code so we can test it out.

OK. Will start develop at this night.


⚠ Bofrost.be has degraded performance

In b57eeda, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 893 ms

Resolved: Bofrost.be performance has improved in 42d573d after 6 minutes.


Package.json fix maximum call stack issue upon build.

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Split out babel icons and src to resolve maximum call stack issue.
Refer to issue #4337

hey @danbrianwhite ,
Thanks for the PR. I think that we'd want to avoid having to break up the build command like that -- it doesn't feel natural.
I took a look myself, and I'm able to "fix" the issue by removing this babel plugin we're using: https://github.com/newoga/babel-plugin-transform-replace-object-assign/. This means it is very likely that the root cause of the issue is in the plugin.
@newoga wrote the plugin we're using that appears to be causing the issue so I've pinged him in the other PR for this issue that was opened (but will hopefully be closing too): https://github.com/callemall/material-ui/pull/4374


Drupal and selectBoxIt.js

I was trying to use the selectBoxIt plugin with Drupal. For reference, I have the latest versions of Drupal and jquery installed. In my theme's info file, I have the reference to selectboxit.js before all.js (where I call the function). Also, I used the custom js builder on your site and grabbed core + mobile. I downloaded the minified version. I am running into these errors:
Uncaught TypeError: Object function (j,s){return new b.fn.init(j,s)} has no method 'widget' selectBox.js:2
Uncaught TypeError: Object # has no method 'selectBoxIt'
I tried googling this but nothing I found was relevant. I'm guessing it has something to do with the first error, but I don't know what it could mean.

I am working with Drupal 8 and I'm coming across the following error:
$.widget is not a function(…)
I have listed both jquery and jquery-ui (as it includes widget) as dependencies. Anyone else come across this?


Fix cancel not closing if write error

If there was an error writing the cancel message then cancel wouldn't close the connection. Additionally, if the write did succeed, it was never flushed, so in my debugging tcpdump's it was never actually sent to the server.
I made cancel return either the error from Close or the error from the write/flush. Though this ever is never actually used in watchCancel.

Thank you!


Checks are not being registered

docker-compose.yml contents:
api:
  image: sstarcher/sensu
  command: api
  links:
    - rabbitmq
    - redis

server:
  image: sstarcher/sensu
  command: server
  volumes:
   - './checks:/etc/sensu/check.d/'
  links:
    - rabbitmq
    - redis
    - api

client:
  image: sstarcher/sensu
  command: client
  environment:
    CLIENT_NAME: qa-poker
    CLIENT_ADDRESS: '<IP_ADDRESS>'
    CLIENT_SUBSCRIPTIONS: test
    RUNTIME_INSTALL: http
  links:
    - rabbitmq

uchiwa:
  image: sstarcher/uchiwa
  links:
    - api:sensu
  ports:
    - '80:3000'

rabbitmq:
  image: rabbitmq:3.5-management

redis:
  image: redis

I can confirm that my check makes it into the server's /etc/sensu/check.d directory and is picked up:
server_1    | {"timestamp":"2016-05-25T13:51:05.507991+0000","level":"warn","message":"config file applied changes","file":"/etc/sensu/check.d/check-sensu-website.json","changes":{"checks":{"sensu-website":[null,{"command":"check-http.rb -u https://sensuapp.org","subscribers":["test"],"interval":10}]}}}

But it's invisible to the API:
root@d3177012135b:/# curl -s http://api:4567/clients

[{"socket":{"bind":"<IP_ADDRESS>","port":3030},"name":"qa-poker","address":"<IP_ADDRESS>","subscriptions":["test"],"keepalive":{"handler":"default"},"version":"0.23.2","timestamp":1464184889}]

root@d3177012135b:/# curl -s http://api:4567/checks
[]root@d3177012135b:/#

@tomwadeson The sensu api must also have the sensu checks mounted into it's volume.  Sensu API does not pull the checks from the server they must be duplicated if the server and api are run separately.


Test working branch

Test - do not review or merge.

#hold-off

This is a test PR. Do not review or merge.


WIP - Use AddRange for building Map in NameResolution

This is an experiment. Please don't merge.
I'm trying to avoid building lots and lots of intermediate maps when create the maps for NameResolution.
This only creates MapTrees instead.
I'm also looking into a way to merge two maps without rebalancing like crazy.
I think https://github.com/ocaml/ocaml/blob/trunk/stdlib/map.ml#L240 might be something that could help to go over to real LayeredMaps.

Ok my profiling shows: there is basically no perfomance win here.


How can I get the ngx.var.* in connect? // can it get data of proxied SSL stream?

How can I get the ngx.var.* in connect? For example ngx.var.uri , var.request_body  and so on?

Hi @p1r06u3 ,
Note that CONNECT request has no URI/body information.
It's just a tunnel protocol, used to proxy raw stream(maybe SSL request).
Some variables about CONNECT request can be accessed, for example:

ngx.var.method
proxy_connect module has its own variables, see https://github.com/chobits/ngx_http_proxy_connect_module#variables

For CONNECT request / tunnel details, see https://en.wikipedia.org/wiki/HTTP_tunnel#HTTP_CONNECT_tunneling.

Thanks for your reply~ I am using openresty for forward proxy, but https is difficult.  Then I found this connect tunnel model for https. Now I want to get the bodys . Could you give me some suggestions?

hi @p1r06u3
If you use this module to tunnel https stream, it cannot get https body currently.
This module do proxy stream and not modify the stream data.
But you can develop on this module to get https stream data and decode it via server ssl certificate key, then you can get the body of ssl request.

NOTE that this module cannot parse or modify raw tcp stream (although we know it is https stream, but we dont have server's certificate/key to do something like "man-in-middle attack".).

think it resolved, feel free to reopen if you still have any problem

thanks a lot. Now I write a proxy to solve my needs with goproxy lib, but it's not well at concurrency performance. I think I will optimize performance in later.

Just use Charles proxy for that, MITM.

Just use Charles proxy for that, MITM.

It cann't use Charles, because it is a single tools on computer. I need nginx or a language lib that can be developd  to a proxy platform. Goproxy can support my project that has MITM model and high performence.


Server configuration file?

I'm trying to setup the server without Home Assistant. The reported time is incorrect by several hours and my location is reported as Unknown.
Is there a config file for home address, zip code, time zone, service credentials, etc? Maybe environment variables in the docker-compose file?
I've looked but can seem to find anything.
Thank you!

The timezone can be set by the TZ environment variable, e.g., TZ="America/Los_Angeles".

Thank you! Where are these settings persisted across container shutdowns or restarts?

Yes, they should be.

Setting TZ seems to break the docker image.
My docker-compose.yml
version: '3.3'
services:
    stanfordoval:
        container_name: genie
        environment:
            - PORT=3020
            - TZ="America/New_York"
        #ports:
          #- '3020:3020'
        network_mode: host
        volumes:
            - '/home/texnofobix/docker/genie/data:/var/lib/genie-server'
        image: docker.io/stanfordoval/almond-server

$ docker-compose up
[+] Running 1/1
 ⠿ Container genie  Recreated                                                                                37.4s
Attaching to genie
genie  |
genie  | ><EMAIL_ADDRESS>start /opt/genie-server
genie  | > node dist/main.js
genie  |
genie  | /opt/genie-server/node_modules/@js-temporal/polyfill/dist/index.js:6264
genie  |       throw new RangeError("Invalid time zone: ".concat(stringIdent));
genie  |       ^
genie  |
genie  | RangeError: Invalid time zone: undefined
genie  |     at Object.ParseTemporalTimeZoneString (/opt/genie-server/node_modules/@js-temporal/polyfill/dist/index.js:6264:13)
genie  |     at Object.TemporalTimeZoneFromString (/opt/genie-server/node_modules/@js-temporal/polyfill/dist/index.js:6036:36)
genie  |     at Object.SystemTimeZone (/opt/genie-server/node_modules/@js-temporal/polyfill/dist/index.js:10529:36)
genie  |     at Temporal.Now.timeZone (/opt/genie-server/node_modules/@js-temporal/polyfill/dist/index.js:13463:13)
genie  |     at new ServerPlatform (/opt/genie-server/dist/service/platform/index.js:178:50)
genie  |     at Object.<anonymous> (/opt/genie-server/dist/service/platform/index.js:339:19)
genie  |     at Module._compile (internal/modules/cjs/loader.js:999:30)
genie  |     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
genie  |     at Module.load (internal/modules/cjs/loader.js:863:32)
genie  |     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
genie  | npm ERR! code ELIFECYCLE
genie  | npm ERR! errno 1
genie  | npm ERR<EMAIL_ADDRESS>start: `node dist/main.js`
genie  | npm ERR! Exit status 1
genie  | npm ERR!
genie  | npm ERR! Failed at the<EMAIL_ADDRESS>start script.
genie  | npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
genie  |
genie  | npm ERR! A complete log of this run can be found in:
genie  | npm ERR!     /home/genie-server/.npm/_logs/2022-03-10T13_44_53_446Z-debug.log
genie exited with code 1


Is there any scalability issue?

Very interesting work! I have two questions and hope to get answer:

Does the performance improve as the number of LoRA models increases?
Have you conducted theoretical tests or experiments to validate the concept of LoraHub?

@boyuZh thanks for your interest on our work!

This is indeed a great question! Generally, the performance follows a trend of initially increasing and then stabilizing or even being worse. This is because the limited few-shot examples may not provide sufficient information to adapt the weights if there are too many LoRA modules (e.g., > 100), leading to potential unstable problems.
We hope to do so but honestly we do not gain much insights from the internal analysis. We're still actively exploring it, and you may checkout some related works (presented in the Related work section) for inspiration.

Closed since no more activity.


[question] Validate a set of fields with a single validator

First, awesome project and thanks for putting in the effort to build and maintain it!
I'm running up against a real world validation scenario which I cannot seem to solve using Vuelidate and I was wondering what part I am missing. My use case involves something similar to a login form where I have an email and a password field. Individually they can be validated perfectly using Vuelidate (ex. email is required, password is required, ...).
But now I want to validate the combination of the email and password values to see if that yields a successful login. Thus far I can validate single fields, but I'm left wondering how to write a single validator for two or more fields.
Any suggestions? Should I be looking at field groups?

Aha ... the wonders a weekend can do. I was looking at this the wrong way, simply nesting fields is the key to do what I wanted. For anyone else stumbling upon this:
Say you have a Email and Passwords field and you wanted to validate them both separately (to catch invalid formatted email, to short of a password, ...) and as a whole (to see if a user exists with these credentials). The code for this is simply:
import Vue from "vue"
import Vuelidate from 'vuelidate'
import { required, minLength, email } from 'vuelidate/lib/validators'
import { checkUser } from './validators/check-user.js'

Vue.use(Vuelidate);

new Vue({
  el: "#someid",
  data: {
    login: {
      email: '',
      password: ''
    },
  },
  validations: {
    login: {
      checkUser,
      email: {
        required
      },
      password: {
        required
      }
    }
  });

Here we have login with a nested email and password, in the validations we can use this structure to allow validation of "groups". Notice the checkUser validator (a custom validator to check the email/password combination), any validator you place at this level will get passed both the email and password attributes. And you still have the ability to add validators to the single fields email and password themselves (required in this case).
In your template you can use $v.login.checkUser, for example, to check the validation status of the overall login "group" and $v.login.email.required or $v.login.password.required to check for the status of each field individually.
To mark your Email and Password HTML fields with an error both when an individual error happens (required triggers) and a "group" error happens (checkUser triggers) you can set classes on each field like so:
Email field: v-bind:class="{'has-error':$v.login.email.$error || $v.login.$error}"
Password field: v-bind:class="{'has-error':$v.login.password.$error || $v.login.$error}"
In hindsight very obvious and a shout out to model-based validation as this makes these constructs that much simpler to set up once you make the mental click of not validating DOM input fields, but actual data.


Prepare for 0.1.0 release

Attempt to get Jenkins CI running again (modules and paths need tweaking)
Cherry picked some mostly cosmetic changes from #6

Does not need to be merged. The 0.1.0 release has been created.


Add a viewId parameter to the MarkdownText composable

Add a viewId parameter to the MarkdownText composable.
viewId will be assigned to the underlying Android view TextView so that it can be found by espresso in tests.

Hello @gpouzerate 👋🏼
Thanks for contributing!


game does not contain its children

print(game.ReplicatedStorage) reports the error: TypeError: Key 'ReplicatedStorage' not found in class 'DataModel'
It's considered good practice to use game:GetService() instead but it can be confusing when this doesn't work.

In terms of technically being correct, we might want to add this - but should we though?
I'm wondering if we should enforce best practices instead (i.e., using :GetService)

If we wanted to enforce best practices it would help if it gave an error message indicating that the user should use GetService and maybe the reasons why.

This should actually no longer error after https://github.com/JohnnyMorganz/luau-lsp/commit/48a0abd56d5600c65d416645fdaf9646f8b76720, but we won't provide any autocomplete support currently - not sure how much its worth it to do so, because I'm not sure where to easily find all the direct children of DataModel

Since statically there is no way to find direct DataModel children, I don't think there is much else we can do here.
This will no longer error which is the main issue. The loss of autocomplete is minor IMHO.
This could, however, be supported by #81, as Studio has full knowledge of DataModel children, and we will be able to understand this. So I will close this in favour of that issue.


create ".dx" folder if needed

When running dx edit config for the first time, it will present you with some example config, which is quite nice.
Unfortunately dx crashes once you save the config with the following error:
FATAL: open [...]/.dx/config.yml: no such file or directory
Because the .dx directory does not exist (at least for 99% of first time users this will be the case). This gives a bad first impression.
This PR adds a call to os.MkdirAll for the ConfigDir, which will be a no-op if the directory already exists, but create the directory if needed. The directory will be only accessible to the current user (mode 700), which is in line with the mode 600 used for the actual config file.

Thanks @phil9909, these are both great PRs! will get a new release cut ASAP.


UI: Add clear button

Add clear button to the UI - clears all pixel data from the image.

This issue was moved to flaki/pif-editor#4


fix wrong seo link

seems fixed https://github.com/mtdvio/every-programmer-should-know/commit/52ff13f4b4341b604af7e8a83d0b4233dd0228ff


Aggregate points from carbon cache like whisper

This follows on from #2081 and simplifies the logic used to pre-aggregate the points from carbon cache before using the specified consolidation function.  It also includes a small optimization to use an array comprehension instead of append in a loop to build consolidated.
@olevchyk does this make sense to you?

Codecov Report

Merging #2082 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2082      +/-   ##
==========================================
+ Coverage   75.32%   75.34%   +0.01%
==========================================
  Files          79       79
  Lines        7680     7686       +6
  Branches     1507     1508       +1
==========================================
+ Hits         5785     5791       +6
  Misses       1632     1632
  Partials      263      263

Impacted Files
Coverage Δ

webapp/graphite/readers/whisper.py
92.53% <100%> (+0.22%)
:arrow_up:

webapp/graphite/readers/utils.py
94.21% <100%> (+0.19%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de81a03...8abc452. Read the comment docs.

Yeah this looks much better.


Add autocorrect support for RSpec/ScatteredSetup

I think autocorrection on this cop could be achieved by merging the contents of the two before (or after) with a blank line.
# bad
describe Foo do
  before { setup1 }
  before { setup2 }
end

# good
describe Foo do
  before do
    setup1
    setup2
  end
end

Since this Cop often reports offenses when introducing rubocop-rspec, it would be nice to support autocorrection on this cop, even though it is unsafe.
Note that in supporting autocorrection, I have also made changes to the way offenses are reported. When multiple same hooks are written, all of them used to be considered as offenses. However, when implementing autocorrection this was inconvenient, so only the second and later defined hooks are now considered offenses. Given the way other similar Cop offenses are reported, I believe this is an acceptable change.
# before
before { bar }
^^^^^^^^^^^^^^ Do not define...
before { baz }
^^^^^^^^^^^^^^ Do not define...

# after
before { bar }
before { baz }
^^^^^^^^^^^^^^ Do not define...

This autocorrection gives little consideration to line breaks and spaces because it's not this cop's business, but I believe that this will not be a problem since they will be autocorrected at the same time by other Layout cops.

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Updated documentation.
[x] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have modified an existing cop's configuration options:

[x] Set VersionChanged: "<<next>>" in config/default.yml.

Fixed in #1616


this.addWatchFile() in the load() method of a Rollup plugin does not trigger an update in the loaded module if that module is not a "real" file

Describe the bug
When using a custom rollup plugin that replaces special module identifiers with out-of-band content generated on the basis of that identifier (e.g., import foo from 'special-loader:./module';, where special-loader:./module has a custom Rollup plugin that uses load() to runs a special build on the basis of ./module), Vite will never call the load() method of the plugin for that module again until the dev server is restarted, even if you use this.addWatchFiles() in the plugin to list files as out-of-band dependencies.
Reproduction
https://github.com/lemonmade/vite-example — README has instructions, but the basic gist is to run yarn && yarn dev, then edit worker.js, and note that the updates are never triggered in the actual built file.
System Info
Output of npx envinfo --system --npmPackages vite,@vitejs/plugin-vue --binaries --browsers:
  System:
    OS: macOS 11.3.1
    CPU: (8) arm64 Apple M1
    Memory: 2.27 GB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 15.4.0 - ~/.nvm/versions/node/v15.4.0/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v15.4.0/bin/yarn
    npm: 7.0.15 - ~/.nvm/versions/node/v15.4.0/bin/npm
  Browsers:
    Chrome: 90.0.4430.212
    Firefox Developer Edition: 87.0
    Safari: 14.1
    Safari Technology Preview: 14.2
  npmPackages:
    vite: ^2.3.3 => 2.3.3

Used package manager: yarn

Before submitting the issue, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the docs.
[x] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[x] Provide a description in this issue that describes the bug.
[x] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[x] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.

I assume the fix for this would be similar as https://github.com/vitejs/vite/issues/7024, but nonetheless web workers support has been improved a lot since this issue, so the issue you had with workers may be resolved too.


fix: strong_password check

Fixed #438

Thank you for sending a PR.

We expect all contributions to conform to our style guide, be commented (inside the PHP source files), be documented (in the user guide), and unit tested (in the test folder).
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

Please add test code to prove the bug is fixed.

I will close this since #438 is considered not as a bug.


Add with function implicitly available on all values

This PR adds a with function that is implicitly available on all values, as proposed here.
The general approach is:

Add a private _with function to the standard library, with the same curried signature as an instance function
Add that function decl as an overload choice when calling .with on any value

Example usage:
struct Test {
  var foo: String?
  var bar: String?
}

let value = Test().with {
  $0.foo = "withFoo"
  $0.bar = "withBar"
}

// Prints "Test(foo: Optional("withFoo"), bar: Optional("withBar"))"
print(value)

let tuple: (a: String?, b: String?) = (a: nil, b: nil)

let updatedTuple = tuple.with {
  $0.a = "withA"
  $0.b = "withB"
}

// Prints "(a: Optional("withA"), b: Optional("withB"))"
print(updatedTuple)

struct Foo {
  var bar: String?

  func bar(_ bar: String) -> Foo {
    with { $0.bar = bar }
  }
}

// Prints "Test(bar: Optional("withBar"))"
print(Foo().bar("withBar"))

Will add tests soon. The sample code in the PR description works as expected and prints the listed values.

@swift-ci smoke test

@swift-ci smoke test


Fix 100% cpu usage when running in docker/non-tty terminal

Raise and catch an exception when failing to get terminal attributes.

@heyman LTGY? If so I can merge and make a new release asap.

Looks good as far as I can tell! I also tried running it in a Docker container without tty without being able to reproduce the issue.

I took the liberty to fix test that had broke in this PR.


fix(embedded): guest token expiration should be in seconds not milliseconds

SUMMARY
GUEST_TOKEN_JWT_EXP_SECONDS is expected to be in seconds, but results in much longer expiration due to being multiplied by 1000, making the jwt valid for an unexpectedly long time
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS
confirmed time.time() returns seconds, confirmed pyjwt exp expects unixtime seconds.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@ygelfand are you still able/willing to get this across the finish line? Sorry there hasn't been much activity here. I'll go ahead and set the PR to draft, but you can mark it as ready for review after a rebase takes place, which should also kick-start CI.
I also wonder, would this change meant that when people update, they need to change their config from milliseconds to seconds? If so, we should put an entry in UPDATING.md, and probably consider it a breaking change (if it would cause issues if people don't change their setting)

@rusackas totally forgot about this, this looks to be have been addressed in  54b60ded8e4a75bbd928687120bfcb6d2351a347 (though granted w/o docs update) so I think its fine to close.


Use safe-regex instead of regex for regular expression

Part of #1359
Description
Since the regex crate cannot work without std, we can use safe-regex as an no_std alternative for regular expressions.

For contributor use:

[ ] Added a changelog entry, using unclog.
[ ] If applicable: Unit tests written, added test to CI.
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Updated relevant documentation (docs/) and code comments.
[ ] Re-reviewed Files changed in the Github PR explorer.

Thanks Soares! Looks good, let's just check on the failing tests otherwise this should be an easy one.
test src/ics24_host/identifier.rs - ics24_host::identifier::ChainId::is_epoch_format (line 79) ... FAILED
475
test src/ics24_host/identifier.rs - ics24_host::identifier::ChainId::chain_version (line 56) ... FAILED

The tests are fixed now.


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 16:09:29 on 2023.05.12
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 1, errors out: 0
Original problem ID: 20587
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=20587

Problem has been resolved in 3m 0s at 16:12:29 on 2023.05.12
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 20587


Build(deps-dev): Bump @types/react-dom from 17.0.11 to 17.0.12 (#2959)

Pull request opened by the merge tool on behalf of #2959

Merged in 87423dc836a5c5ad7ea80d1d75f10f7cd3a12248


Object_explorer is not working

Hello,
I'm starting with the Py-StackExchange and when I run the object_explorer it shows me 256 site names from the StackExchange and after returns me this error:
Traceback (most recent call last):
File "object_explorer.py", line 162, in
site, site_def = choose_site()
File "object_explorer.py", line 34, in choose_site
print('%d) %s' % (i, site.name))
File "C:\Python27\lib\encodings\cp850.py", line 12, in encode
return codecs.charmap_encode(input,errors,encoding_map)
UnicodeEncodeError: 'charmap' codec can't encode characters in position 5-16: character maps to
How can I proceed?
I'm running it on Microsoft Windows 8.1

Same issue here.

Another issue (maybe not related) on a Mac and Python 3+
Using the example code for object_explorer the output does not match the example
Should it not show Users object when dir after Users ?, output below:-
...
Site ID: 1  <------
Use function names you would when using the Site, etc. objects.
return:    Move back up an object.
exit:    Quits.
dir:        Shows meaningful methods and properties on the current object.
dir*:    Same as dir, but includes all methods and properties.
code:    Show the code you'd need to get to where you are now.
! before a non-function means "explore anyway."
a prompt ending in []> means the current item is a list.
Stack Overflow> user <------
<bound method Site.user of <stackexchange.site.Site object at 0x103d8bb00>>
Stack Overflow> dir
['all_badges', 'all_nontag_badges', 'all_tag_badges', 'all_tags', 'answer', 'answers', 'api_version', 'app_key', 'badge', 'badge_recipients', 'badges', 'be_inclusive', 'build', 'build_from_snippet', 'cache_options', 'check_filter', 'comment', 'comments', 'domain', 'error', 'force_http', 'impose_throttling', 'include_body', 'include_comments', 'info', 'moderators', 'moderators_elected', 'privileges', 'question', 'questions', 'recent_questions', 'revision', 'revisions', 'root_domain', 'search', 'search_advanced', 'similar', 'stats', 'tag', 'tag_related', 'tag_synonyms', 'tag_wiki', 'tags', 'throttle_stop', 'user', 'users', 'users_by_name', 'vectorise']
Stack Overflow>

@goldiiman , I was able to go about this by providing a API key, this might seem naive but do give it a try.

@goldiiman same issue. After providing an API key, selecting StackOverflow, and trying to get a user, I am not prompted to input a nid(as shown on the wiki). It simply stats that user is a method.


add system.cpu.physical.count and system.cpu.logical.count metrics

ref: https://github.com/open-telemetry/opentelemetry-specification/issues/3556
Closes #98

cc @specs-semconv-approvers @open-telemetry/specs-semconv-maintainers

@tigrannajaryan @jamesmoessis the metrics have been renamed and the description of system.cpu.time and system.cpu.utilization now clarify that there is one dimension per logical CPU. PTAL!

Separate note, this will likely conflict with #154

@mx-psi conflics are resolved.
@tigrannajaryan @jamesmoessis whats your thoughts?

oh shoot, it seems the last force push revered some recommendations form @mx-psi . Let me check.

@tigrannajaryan can you check - added the comments again.

rebased again

resolved changelog conflict

@open-telemetry/specs-semconv-maintainers is something missing?

Looks like a link broke after the reorganization
  ERROR: 1 dead links found!
  [✖] file:///home/runner/work/semantic-conventions/semantic-conventions/docs/general/metrics-general.md#instrument-types → Status: 400

It's still unclear from the description what's the difference between logical/physical and what should be used to calculate time/utilization per core (@mx-psi said that it's logical). I think that important information to cover in the description

What do you have in mind @dmitryax - Something like this on top?
Logical CPU refers to the virtual cores created by the operating system to manage multitasking, while a physical CPU represents the actual physical processor core(s) on the hardware.

... what should be used to calculate time/utilization per core

Isnt that covered here?
system.cpu.time ... Seconds each logical CPU spent on each mode
system.cpu.utilization ... Difference in system.cpu.time since the last measurement, divided by the elapsed time and number of logical CPUs

Something like this on top?

Yes, this sounds descriptive enough.

Isnt that covered here?

I missed that. SGTM

added that part @dmitryax  :)

Works for me too. I rephrased it a bit. Can you check one more time @dmitryax ? ^^

@open-telemetry/specs-semconv-maintainers anything left to do on this PR?

@frzifus
/home/runner/work/semantic-conventions/semantic-conventions/docs/system/system-metrics.md:36: MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]

Fixed

Ideally, we'd like this change to either be generated off YAML or wait until the system metrics are defined in YAML, then merge this PR with that change.


Added Azure.VM.AMA in progress, rule condition does not work as expected

PR Summary

Working towards #1792
Having some issues, created this PR to get some help with troubleshooting.
The current rule is just to be considered as work in progress.
I'm struggling with the condition (not sure if we're going to use the condition like this, but still have to figure out the logic).
Invoke-PSRule: An invalid rule result was returned for PSRule.Rules.Azure\Azure.VM.AMA. Conditions must return boolean $True or $False.
When I add another property to be be matched as well, then Invoke-PSRule executes without this warning, but all outcomes are None.
process {         @(GetSubResources -ResourceType 'Microsoft.Compute/virtualMachines/extensions', 'Microsoft.Compute/virtualMachineScaleSets/extensions' |             Where-Object { $_.Properties.publisher -eq 'Microsoft.EnterpriseCloud.Monitoring' -and $_.Properties.type -eq 'MicrosoftMonitorAgent' })         }
PR Checklist

[x] PR has a meaningful title
[ ] Summarized changes
[ ] Change is not breaking
[ ] This PR is ready to merge and is not Work in Progress
Rule changes

[ ] Unit tests created/ updated
[ ] Rule documentation created/ updated
[ ] Link to a filed issue
[ ] Change log has been updated with change under unreleased section

Other code changes

[ ] Unit tests created/ updated
[ ] Link to a filed issue
[ ] Change log has been updated with change under unreleased section

@bengeset96 The message Conditions must return boolean $True or $False. is returned when an object is returned as a result of the result. Only $True or $False or using $Assert is allowed.
If you are executing something like @(GetSubResources -ResourceType 'Microsoft.Compute/virtualMachines/extensions', 'Microsoft.Compute/virtualMachineScaleSets/extensions' | Where-Object { $_.Properties.publisher -eq 'Microsoft.EnterpriseCloud.Monitoring' -and $_.Properties.type -eq 'MicrosoftMonitorAgent' }) be sure that it is assigned to a variable like:
$extensions = @(GetSubResources -ResourceType 'Microsoft.Compute/virtualMachines/extensions', 'Microsoft.Compute/virtualMachineScaleSets/extensions' | Where-Object { $_.Properties.publisher -eq 'Microsoft.EnterpriseCloud.Monitoring' -and $_.Properties.type -eq 'MicrosoftMonitorAgent' })

Otherwise it will be returned as the rule result.

@bengeset96 The message Conditions must return boolean $True or $False. is returned when an object is returned as a result of the rule. Only $True or $False or using $Assert is allowed.
If you are executing something like @(GetSubResources -ResourceType 'Microsoft.Compute/virtualMachines/extensions', 'Microsoft.Compute/virtualMachineScaleSets/extensions' | Where-Object { $_.Properties.publisher -eq 'Microsoft.EnterpriseCloud.Monitoring' -and $_.Properties.type -eq 'MicrosoftMonitorAgent' }) be sure that it is assigned to a variable like:
$extensions = @(GetSubResources -ResourceType 'Microsoft.Compute/virtualMachines/extensions', 'Microsoft.Compute/virtualMachineScaleSets/extensions' | Where-Object { $_.Properties.publisher -eq 'Microsoft.EnterpriseCloud.Monitoring' -and $_.Properties.type -eq 'MicrosoftMonitorAgent' })

Otherwise it will be returned as the rule result.

Thanks, understandable.
In this case it happends due to -If { Helper function } I assume.
Rule 'Azure.VM.AMA' -Ref 'AZR-000317' -Type 'Microsoft.Compute/virtualMachines' -If { HasLogAnalyticsAgent } -Tag @{ release = 'GA'; ruleSet = '2022_12' } {     $Assert.Fail($LocalizedData.LogAnalyticsAgentDeprecated) }
function global:HasLogAnalyticsAgent {     [CmdletBinding()]     [OutputType([System.Boolean])]     param ()     process {         @(GetSubResources -ResourceType 'Microsoft.Compute/virtualMachines/extensions', 'Microsoft.Compute/virtualMachineScaleSets/extensions' |             Where-Object { $_.Properties.publisher -eq 'Microsoft.EnterpriseCloud.Monitoring' })         }  }
I'll try to troubleshoot further as I'd assume $Assert.Fail() here is valid.

@BernieWhite
Would be truly grateful if you had the chance to review this =)


enhancement - multiple weblink's

Allow users to send an array of objects to allow multiple weblink's

Thanks for the useful update


Popup doesn't work in a shadow root

The Color Picker doesn't appear when it's in a shadow root.
The isOpen class isn't set on picker.
Also, in your website, can you specify the prop settings needed to put the color picker in the always open mode.
Thanks

Thanks for using the library!
What do you mean by using the component in a shadow root? Do you have a repl or a repro repo? ;)
I'll update the doc for the open version

Hi
Thanks for the quick response.
What I'm doing is creating a shadow root/shadow dom and attaching the svelte app to that.
root = parent.attachShadow({mode: 'open'});
new App({target: root, props: {});
See https://developer.mozilla.org/en-US/docs/Web/API/Web_components/Using_shadow_DOM
This allows you to isolate css but will also block you from using document.query on any of the html elements.
If you could help me out I'd appreciate it.
Thanks

Thanks for your reply!
I'll be able to look at it starting next week.

Awesome

Hey @ezenkico !
I understand that you are using the shadow dom to mount a svelte app but I have no idea how. Would you have a simple reproduction repo with an index.html (or a Svelte / React app) file importing the bundled Svelte app?
Thanks!

I am closing this as I cannot reproduce. Reopen it when you have time to give me some insights ;)


pandas ArrowInvalid error message should include column name

I'm trying to write a pandas dataframe to feather using its to_feather method. When a single column's conversion fails (pandas_compat.convert_column), the error message does not include the name of the column that failed. E.g. the message is something like:
ArrowInvalid: Error converting from Python objects to String/UTF8: Got Python object of type int but can only handle these types: str, bytes.
I think it would make debugging easier to add the column name to the error message. Thoughts?

This sounds like a nice improvement. Could you open an issue on JIRA (our feature/bug tracker)?

Sure https://issues.apache.org/jira/browse/ARROW-2626
Should I close this issue as well?

Perfect, thanks. Yep, closing this


feat: add option to get assets in export project

I renamed everything to with_assets
In the AbstractExporter, a temporary root export directory is created so that we can download the assets directly into it with fetch_assets
I removed the video export in Pascal VOC since it hasn't been tested and makes the code harder to read/maintain
I had to remove the Pascal VOC CLI test since the mocked asset["content"] is not downloadable


fix(repo): use es build instead of lib in browser

Closes #2260
Summary

We were using the lib build instead of the es build in the browser property of package.json. This was forcing everything to be included and breaking tree shaking. The test app was 8.08MB when built and analyzed in its current state, but after the es switch it dropped to 2.1MB.

Change List (commits, features, bugs, etc)

change browser package to use es build

Acceptance Test (how to verify the PR)

Pull this branch down locally
create a new directory to hold the built project ie: mkdir -p ~/tmp/pal-build
run yarn build
copy built files to project directory created above: cp -rf package.json umd scss lib es css ~/tmp/pal-build
move to a fresh directory
create a test app: npx create-iot-react-app pal-test
cd into the test app directory:  cd pal-test
install the locally linked version of carbon-addons. This must be either a relative path or an absolute path (the ~ will not be expanded), so continuing with the ~/tmp/pal-build example above it would become yarn add "carbon-addons-iot-react@link:$HOME/tmp/pal-build" (on mac)
build the test application. yarn build
use serve to serve the built project and confirm it works. serve -s build

Optional:
You can compare the build differences by installing source-map-explorer (yarn add source-map-explorer and running it on the built application: yarn source-map-explorer 'build/static/js/*.js'.
Regression Test (how to make sure this PR doesn't break old functionality)

consuming applications still work as expected

Things to look for during review

[ ] Make sure all references to iot or bx class prefix is using the prefix variable
[ ] (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
[ ] UI should be checked in RTL mode to ensure the proper handling of layout and text.
[ ] All strings should be translatable.
[ ] The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
[ ] Unit test should be written and should have a coverage of 90% or higher in all areas.
[ ] All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
[ ] Changes or new components should either write new or update existing documentation.
[ ] PR should link and close out an existing issue

I have a vague memory of PAL components changing this value a few months back and it caused build issues for us. We use a CRA based builds and after consuming the update it broke when did production builds. I don't recall if this was because of changing the browser field or the main field, but, maybe you can review this history of those groups of lines and see if you can find the issue.
I found the issue I was referring to... #2026
Can you confirm that a CRA based app both build in dev and production mode with this change.

That's correct, @stuckless. The fix in #2026 was to add the browser property to fix your build error. This change points that browser property to use the es build of the package instead of lib so that tree-shaking works properly and the bundle size can be reduced greatly for consumers. The detailed steps for approval listed above tests this change against a CRA based app. It built and worked with a BarChartCard, and that's why I included such detailed steps so others can recreate it as a consumer app. Once @bjornalm or @scottdickerson confirms this fix, I'll re-request a review from you.
FYI, we also have an issue slated for September to add this type of build into our CI to catch those types of errors in the future.

I was able to confirm that we could build and start up app for both development and production


Make the build system crossplataform

The actual build system (CMake) is not yet cross platform as it does not compile on Windows. The following platforms should be able to build it:

[X] Linux
[ ] Windows
[ ] MacOS (didn't test it yet)

Your help would be necessary as I don't have yet the all the tools to test the build system (a.k.a test it on a MacOS or any other Unix flavor available).

@luiz_peres, could you please give me a hand to test it on OSX?

I'll leave out the MacOS build until I get one to work with.


Try moving promises build config out of root

Aim here is to see if it's possible, and if so, start moving more.

@yashykt

This seems to work, and gives us a good long term path to getting a more tractable root BUILD file.
Any objections? @markdroth?

I would love to see this happen, but are we sure this actually works?  I'm concerned that the data in the lower-level BUILD file is not actually being picked up by generate_projects.sh, but that it's not causing a problem in this particular case because none of our real production code is actually using promises yet.  Note that the PR does not contain any changes to any of the cmake configs or any of the other build systems.
Maybe a better first candidate for this would be the BUILD rules for src/core/lib/gprpp, since that code is actually used in our production code.

I thought the same, so I made #27401, which does include some load bearing files.
Similarly no change to the CMakefile (which is good - moving these files does not change the output of the build generators).

Long story short: so far as I can tell (and unless @gnossen or @nicolasnoble or @jtattermusch disagree with me) this works. We'll need to start work on leaf directories, and move all of the leaf directory at a time, so I expect this to be very incremental, but otherwise we're good to go.

This should be fine now, yes


Upgraded pe-utils to 2.0.7

This version of pe-utils mainly add a generic derivation in identity-tool to generate edge gw urls from all possible values of LwM2M service address. This should allow snap-pelion-edge gateways to connect with any Pelion cloud and on-prem instance.

@ygoyal18 we are locking in all deb and rpm packages to specific branches today/tomorrow.
pe-utils during this locking procedure will be bumped from 2.0.4 to 2.0.6
See: https://github.com/PelionIoT/distro-pelion-edge/pull/164
New PR for deb packages coming shortly.
Will close this PR when the incoming PR with all locked packages gets created

FYI @costanic @mray190 - 2.0.7 fixes a breaking change which as introduced in pe-utils 2.0.6.


Rename folders and artifacts

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##           master   #2   +/-   ##
===================================
  Coverage       0%   0%
===================================
  Files           1    1
  Lines          41   41
  Branches       13   13
===================================
  Misses         41   41

Impacted Files
Coverage Δ

...jetpack/advancedclientlibs/ClientLibUseObject.java
0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d77ffca...0d7aa58. Read the comment docs.


Return waypoint order with optimization response

You can now export the order of points as a layer.

Translation is still missing.

Apart from the translation, is this still WIP or can this be merged?

It's good to go from my side.


Upgrade to Akka 2.4.9 (closes #117)

Could you bump constructr version with this PR please?
Thanks a lot!

Thanks a lot!


Currently missing BitInt Literal support

It looks like NectarJS is currently missing BigInt Literal support.
Steps to reproduce the issue:
1 - Install latest nectarjs
2 - Run these two commands
❯ echo "0n" > big-int.js
❯ nectar big-int.js

3 - Should see this error message from previous command
[*] Generating source file
[error] Parsing error: Identifier directly after number line 1 column 2 in file big-int.js

Hi @JakeChampion , thank you

I see this has been labelled es5. I figure I should mention that BigInt was added in es2020, which is the 11th edition and not in es5.
Not sure if that changes anything but just in case you thought it was an es5 feature 👍

Yes thx my bad, i was too fast


Using submodules to track internal dependencies

Requested by @cdonovick
@jameshegarty, @phanrahan, and I had discussed using submodules. Our main concern was that they would require an explicit PR to bump the submodule commit whenever a repo pushed changes to master. If the person responsible for initiating this PR did not do it, the flow could be silently broken (that is, if they had bumped the submodule commit, we would've seen the flow break). In our current model, the nightly run would catch an offending master branch that has broken the flow, so if we have a silent breakage, at least it only lasts less than 24 hours.
Using submodules could work, but I believe it would require that we institute and enforce a policy that any changes to a master branch be accompanied by a PR to bump the submodule commit in the CGRAFlow repo.
I'd be open to hearing other solutions that prevent the flow from being broken silently.

I had forgotten about the whole not being able to always point to HEAD in a submodule so I wan to retract that request.  We could potentially use subtrees https://github.com/apenwarr/git-subtree/


release v1.0.1

Parent of #22
Parent of #23
Parent of #26
Parent of #27
Requires #22
Requires #23
Requires #26
Requires #27

closed by https://github.com/pascalpoizat/veca-haskell/commit/293a7b59ee8867666dc86f50a3f56755116a34a0


[api] expose JMX configurations via API

What does this PR do?
Adds an endpoint to the API (I should probably change it to something cleaner) - agent/jmxconfigs where a caller can collect all JMX configurations available after a certain timestamp.
(ie. GET http://localhost:5001/agent/jmxconfigs?timestamp=<sometimestamp>)

Agent log level is now correctly mapped to JMXFetch.
JMXFetch is now launched bare, with no checks configured, it'll collect the configurations via the endpoint. See https://github.com/DataDog/jmxfetch/pull/156

It also adds a basic thread-safe cache, mainly because I wanted a clean interface to iterate over the contents of the cache while remaining thread safe without too much lock/unlock management fuss. The current channel based iteration mechanism isn't very performant compared to other alternatives out there - we can always roll those out if necessary - but since this basic cache should be relatively small in general we should be fine, besides having range to iterate over keys and values just makes it clean.
Motivation
Cleaner interface with JMXFetch, ground work for AutoDiscovery which should now be trivial to complete on the JMXFetch side.

So the main reason I did not use go-cache was because it wasn't available when I started writing this. I think Maxime pulled it in later, and then I didn't change it because I liked to iterate over the actual cache rather than a copy. I can see you rather we don't do that, so I'm happy to switch it back.

As discussed in person, we're going to keep the BasicCache, as it provides the "last touched" attribute that proves so helpful in this particular use-case. Tested manually on JMXFetch 0.18.0 with good results.


Renaming http function to http_request

The name http interferes with another dep we are using
which exposes a http function :(

Sounds good.

thanks!
On Tue, Mar 22, 2016 at 4:10 PM Eric Lindvall<EMAIL_ADDRESS>wrote:

Sounds good.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/papertrail/papertrail-hubot/pull/4#issuecomment-200029833


Keyword for wordlist not detected in -u option when parsing a request file

Hi @joohoi
The tables have turned now haha, now I already confirm that this is fixed, however, if I will do a basic scan like my command:
ffuf -c -w /path/to/wordlist.txt -u https://example.com -H "Host: FUZZ" -mc all -fc 500-599
It cannot read the -u flag

How sloppy of me! It's now fixed.


Set default option value to nil if no default is specified

This sets the default option value to be nil when it is not specified by the user.  This way any options that are not set on the command-line and do not have a default will have a nil value in the table returned by cli:parse.
This way you can do
if cliArg.option then
  ...
end

instead of
if cliArg.option ~= "" then
  ...
end

Passing "" is also legal on the command-line, so the latter case would be ambiguous as to whether or not the user passed a value to option on the command-line.  Furthermore, if you want the default value to be "", then you should be explicit about it and pass it in to cli:add_option.

Flag options now can't be false, right? It's either true (when passed) or nil. We don't support --no-[flag-key] yet so there's no way to actually pass in a false value from the CLI.
I'm not sure if we want this change to affect flags, although I +1 the explicitness. So, maybe we should have add_flag require a default to be specified, but that would not be backwards-compatible so we might just want to stick to defaulting to false in the case of flags.
Thoughts?

What about having a default value for add_flag be optional, and defaulting it to false for backwards compatibility?  That might seem kind of weird though, since usually not specifying a value means nil and not false.
I'm not sure backward compatibility as important in the case of add_flag since both nil and false would both evaluate to the same thing when you do if not flag then versus if flag then.  As long as you're not checking for == false, then everything should work just fine.
If you do ever want to support --no-[flag-key], then specifying --no-[flag-key] on the command-line should return false while specifying --flag-key would return true and have nothing on the command line would return nil.  In this scenario, I think having the default be nil makes a lot of sense.

I think @o-lim is right that practical use is currently if flag then  which works both for nil  and false. So +1 for me.
I also like it because it enables --no-  type flags, which is required for #20. When a config file sets a flag to true, there must be a commandline way of setting it back to false (overriding the configfile).

@amireh if you are worried about backwards compatibility, another way to go is to up the version to 3.0, and maybe add support for --no- flags at the same time.

I have some plans for the 3.0 release and I'll be creating a roadmap/milestone ticket for them soon. We can postpone the --no- flags until then. Also, @Tieske - I have a solution in mind that would satisfy us both for #20 in store for that revision.

I'm not sure backward compatibility as important in the case of add_flag since both nil and false would both evaluate to the same thing when you do if not flag then versus if flag then. As long as you're not checking for == false, then everything should work just fine.

I'm inclined to agree. That, coupled with the fact that there's no way to set a flag to false right now, should make it safe to believe we won't we breaking any existing logic.

FWIW, we can publish a new release for this patch today, I'll wait for #42 to go through first though.


Demo title Add files via upload

Codecov Report

Merging #11 (e6bedde) into master (1a03664) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   85.86%   85.86%
=======================================
  Files          18       18
  Lines         743      743
=======================================
  Hits          638      638
  Misses        105      105

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a03664...e6bedde. Read the comment docs.


Release!

Release version 1.0. Clean up the README if needed, make sure Travis works, create a release on GitHub with executables for various platforms.

Done! https://github.com/mikestaszel/azssh/releases/tag/v1.0


Allow any option for Isotope to be set via optionsForIsotope.

Hi,
I've tried to implement #6 myself.
Also, I've done some refactoring, and gotten rid of all linter warnings.
Unfortunately, I have auto-beautify on, so the formatting has changed slightly.
Hopefully it's not a big deal.
All the test I can imagine are passing.
This is my first pull request ever, and I'm not a professional programmer.
I apologize if something is wrong.

@jorisroling
Let me know if you want me change something about the pull request. I suppose I could make a pull request with the least amount of changes to implement the functionality, if you're not happy with this one?

I think adding:
_.extend( options, this.data.optionsForIsotope );

before:
$el.isotope(options);

should be enough.
What do you think?


Request contains both content-length and 'Transfer-Encoding': 'chunked'

Hi,
I came across an issue using request version 2.79.0.
I want to sent a multipart request containing two elements, the first is a json object with known length, the second is a stream of unknown length.
Therefore I set 'Transfer-Encoding': 'chunked' in the request options:
var options = {
    method: 'PUT',
    uri: 'http://localhost:9002/api/store/...',
    formData: {
      metadata: JSON.stringify(metadata),
      content: part // a stream
    },
    headers: {
      'Transfer-Encoding': 'chunked'
    }
}

However, the server I'm sending the data to raises an Error { [Error: Parse Error] bytesParsed: 1628, code: 'HPE_UNEXPECTED_CONTENT_LENGTH' }.
This is because request internally adds a content-length header to the http request. If 'Transfer-Encoding': 'chunked' is set in the options then request must not add a content-length header.
I did some debugging and found the code that sets the header, it's in request.js line 575: self.setHeader('content-length', length)
If I uncomment this line, then everything works just fine.
I guess that the code needs an additional check to anly set content-length if no 'Transfer-Encoding': 'chunked' is specified.
This is the output of request-debug. There you can see that both headers "Transfer-Encoding" and "content-length" are set:
{
  request: {
    debugId: 2,
    uri: 'http://localhost:9002/api/store/1.1/file/environment/project1_p/zips/2a0d2a70-c210-11e6-a963-b964c3706543.zip',
    method: 'PUT',
    headers: {
      'Transfer-Encoding': 'chunked',
      authorization: 'Bearer myToken',
      'x-request-id': '631613F8-4BAC-4A00-B892-FDA0A2EA3A1D',
      host: 'localhost:9002',
      'content-type': 'multipart/form-data; boundary=--------------------------290886497940693959155150',
      'content-length': 499
    }
  }
}

I'm not sure if this is the only relevant line of code, as content-length header is set at many different code blocks.
Bye,
Daniel

Hi,
A PR has been submitted #2122

@krevindiou Your PR has been marked 'abandoned'. Can you rebase with master and add a comment?


pgweb with docker in README.md

should be usefull add how to run pgweb with docker in README.md

https://github.com/sosedoff/pgweb/wiki/Docker


Initiated the Development of Dashboard UI

Added the final mock ups and started the structuring of the project with creating a custom dark theme

Please fix your codacy issues


Adding Adobe to the Adopters list

Issue #, if available:
Description of changes:  Added Adobe to the list in ADOPTERS.md.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/assign @jlbutler

Thanks so much @eadasiak !
/lgtm


4 walletinfo

Description
This PR adds the connected wallet info next to the wallet address, it shows if the wallet is allowlisted and if it did the checkin
Additional Information

[ ] This PR add a new component batch1.buidlguidl.com\packages\nextjs\components\batch1\AccountInfo.tsx and imports it in batch1.buidlguidl.com\packages\nextjs\components\Header.tsx

Related Issues
Fixes #4
Your ENS/address: yassirakh.eth
Previews of the changes :
A wallet that is allowlisted and did the checkin :

A wallet that isn't allowlisted and didn't do the checkin :

This works @Yassirakh , thank you!!
Left some comments that I think will improve the code

Thanks for the improvement tips, I just pushed the change.

Code looking sharp!! Thanks @Yassirakh


Update attach command and add test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5956/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5957/
Test PASSed.

alluxio-bot, merge this please


Invalid MFA credentials

Great doc, thank you very much!
But what can we do when the negotiation works properly between AAD and AWS (per the test feature in AAD SSO) but AWS replies with the following error?

Is the issue in AWS (as I expect) or in AAD? Is there a way to get more info on this error?
Thanks a lot for any idea you might have.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a6b08461-26fb-d148-a749-9b61217af0f8
Version Independent ID: 1329c651-e8f6-cc68-4205-739dfbbcef4f
Content: Azure AD security for Amazon Web Services (AWS) - Azure Reference Architectures
Content Source: docs/reference-architectures/aws/aws-azure-ad-security.md
Service: architecture-center
Sub-service: reference-architecture
GitHub Login: @doodlemania2
Microsoft Alias: pnp

@FMauroy Thanks for bringing this to our attention. We are actively investigating and will get back to you soon.

@FMauroy The screen which you have mentioned is from AWS and seems that AWS is not allowing the access. I am assuming that you have followed the article to enable Azure AD based SSO for AWS access. In this case , I would first check whether the Azure AD sign in was completed properly or not . You can check the Azure AD signin logs using https://docs.microsoft.com/en-us/azure/active-directory/conditional-access/troubleshoot-conditional-access because the MFA is implemented using Conditional access in this case. If you find that the user's signin did not complete successfully we would find the reason for the same in the logs. In case it was completed then , we would check why AWS is unable to consume the token . this can only be seen in the AWS activity logs. I do not have a test environment with AWS hence I may not be able to provide more insights on that . however if you still do not find the reason for the user who faces this, I would suggest to open a support case for this because there are multiple reasons why this could happen and a HTTP debug trace while accessing will provide more clarity on reasons why this is happening .
Thank you.

@FMauroy Following up to understand whether you got a chance to review our previous comment.

@FMauroy Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly reopen the issue and continue the discussion.


pull request for e2e test at 01/25/2017 21:56:09

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Html repr

This PR supersedes #1820 - see that PR for original discussion. See this gist to try out the new MultiIndex and options functionality.

[x] Closes #1627, closes #1820
[x] Tests added
[x] Passes black . && mypy . && flake8
[x] Fully documented, including whats-new.rst for all changes and api.rst for new API

TODO:

[x] Add support for Multi-indexes
[x] Probably good to have some opt-in or fail back system in case where we (or users) know that the rendering will not work
[x] Add some tests

Hello @jsignell! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file xarray/core/formatting_html.py:

Line 63:26: E222 multiple spaces after operator

I don't really like how the attrs look without the alignment of keys and values. I will think about how to make that more legible

Honestly this is looking super good and ready to merge already!
Thanks @jsignell
The only thing that looks funny to me is the alternating black-gray text coloring below:

Yeah I agree that is a strange part of the original PR. The version in the fiddle doesn't do that, so I'd really like to hear back from @benbovy about whether the fiddle css is more uptodate.

Julia, it's fantastic to see you working on this! Thanks so much!

This looks fantastic! Really great to have you working on this!
Some specific feedback:

Yes, I agree it would be nice to align the Attributes text, maybe this could make use of an HTML table?
Maybe bold would look better than underline for coordinates that are dimensions? I find the underline makes text a little hard to read. Happy to leave this up to you, though.
On my Ubuntu desktop, the "+" icon is bright yellow, which I'm guessing is not what was intended. Maybe it would better to stick with the three circle "data" icon?

What happens if there is a really long variable name? I had a version of the jsfiddle that expanded names when you hovered over them.

This is really nice @jsignell !

I'd really like to hear back from @benbovy about whether the fiddle css is more uptodate.

We did a lot of experiments, even some after starting the implementation in #1820, so I admit this is quite messy. I also did some clean-up and tweaks directly in that PR, so unfortunately there is no fiddle of reference that exactly corresponds to what's in here. Sorry for that!
The html/css in this PR is the cleanest one, I think.
The latest fiddles (for Dataset) are these two ones:

https://jsfiddle.net/Lmqq7yzz/9/
https://jsfiddle.net/1g04ykum/  (@shoyer's  try for handling long variable names)

the only thing that looks funny to me is the alternating black-gray text coloring

In the HTML repr, the width of the space character is less large that for the monospace font used in the text repr, so I originally used this trick to better distinguish between the values in the inline data repr. Now that each value is encapsulated in it's own span, we could tweak the padding instead (or both... I don't have strong opinion on this).

Just one small issue in the gist with the vertical alignment within a variable row, and the height of the icon container (I using Firefox):

Yeah the data preview is also shifted vertically.

I just updated the gist with these changes:

got rid of alternating data colors in preview
fixed icon alignment in row, and rest of data in row
got rid of some not-useful spans
changed from underline to bold for index coords

Is there ever a situation in which dimensions would be expandable? It seems like it is hard-coded to collapsed.
I am trying to generalize the css to reduce the length.

Is there ever a situation in which dimensions would be expandable? It seems like it is hard-coded to collapsed.

I don't think it would ever be expanded. The collapsed icon is just there for visual consistency.

Ok I think I've addressed all the comments. I just updated the gist with the latest output. Tomorrow I'll start adding tests. The css is now ~300 lines and it gets injected everytime the dataset is rendered. I'm not sure if that is considered too long and if it is I don't quite know what to do about it.

The css is now ~300 lines and it gets injected everytime the dataset is rendered. I'm not sure if that is considered too long and if it is I don't quite know what to do about it.

You could consider running the CSS through some sort of preprocessing tool to minify it, e.g., to remove all the spaces. But my guess is that it's probably fine.
It would be informative to measure the size of the output HTML encoded as UTF-8 bytes for some example datasets. For context, a simple line chart from matplotlib is ~20 KB when saved as a PNG image. Anything in that ball-park would be OK, up to perhaps a few hundred KB for really big datasets with lots of variables.

I just gave this a try in Chrome / Google Colab. It's looking great!
Here's the rasm dataset. It weighs in at exactly 20 KB!

The alignment of "Dimensions" line does looks a little off -- would that be easy to fix?
There's also a strange alignment thing with the three circle icon in array repr, which maybe could be moved to the right side?

We probably should be careful to use html.escape() pervasively to protect against malformed data. We can trust user code, but probably should not trust all data -- it should be safe to load and view arbitrary netCDF files in xarray.

Here's what we're currently looking at!

I'm still worried about size, but minifying the css and even minifying the html did not make a big difference. It looks like the html_repr for rasm is 38kb .

It looks like the html_repr for rasm is 38kb .

How are you measuring this?
I see:
>>> len(rasm._repr_html_().encode('utf8'))
19624

Oh I was looking at bytes not len.

Ok I am going to write some tests now. I updated the gist. Do people like the names "classic" and "html" for the display_style options? Another option would be "classic" and "rich".

Or maybe "text" and "html"?
Hopefully "html" will eventually become the classic display :)

I added some tests. I can add more if anyone has a test case that they want to be sure is covered.

Otherwise I think all that is left is adding docs. Also I want to confirm that this should be an experimental feature (off by default).

Oh. The dask version in ci doesn't have _repr_html_. I'll add a version checker to the test.

I am 90% sure this failure is unrelated. Maybe I should rebase now that #3436 has landed?

Well, I rebased. Hopefully it'll pass now. I consider this done unless someone wants more docs or more tests.

nope, it still fails. However, that failure is definitely not related to this PR (it fails to install because the referenced PR in cftime was merged in the meantime).

So maybe one more rebase will do it?

@benbovy just to make double sure, you are happy with this new feature being off by default right?

I would be fine having this be on by default now. Or, we could keep it off until the next major release (0.15).

I'd would rather wait before turning on html display by default. I'd be fine doing so on the next major release if until then we make sure that the rendering will look reasonably good in most front-end situations.
For example, it will really need better integration with jupyterlab dark themes (see below) and would potentially cause issues elsewhere too (nbsphinx, etc.). But we should probably figure that out after this PR is merged.

I've noticed an issue with the alignment of attributes in jupyterlab (1.1.4) (Firefox 69.0.3):

It looks good in the classic notebook.

I've noticed an issue with the alignment of attributes in jupyterlab (1.1.4) (Firefox 69.0.3):

I'm taking a look at the jlab css.

+1 for merging this turned off by default, with a plan to switch it on once
we're tested it on more datasets and platforms
On Thu, Oct 24, 2019 at 8:27 AM Deepak Cherian<EMAIL_ADDRESS>wrote:

@dcherian commented on this pull request.
In xarray/core/options.py
https://github.com/pydata/xarray/pull/3425#discussion_r338641677:

@@ -98,6 +102,9 @@ class set_options:

   attrs, ``False`` to always discard them, or ``'default'`` to use original

   logic that attrs should only be kept in unambiguous circumstances.

   Default: ``'default'``.

display_style: display style to use in jupyter for xarray objects.

 Default: ``classic``. Other options are ``html``.

⬇ Suggested change

 Default: ``classic``. Other options are ``html``.

 Default: ``'text'``. Other options are ``'html'``.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pydata/xarray/pull/3425?email_source=notifications&email_token=AAJJFVQMQKGXPGUFEMZ3ZRTQQG5HNA5CNFSM4JDFFVJKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJDVXPI#pullrequestreview-306666429,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJJFVWYZ27FZ76RZ422M4LQQG5HNANCNFSM4JDFFVJA
.

Fixed the jlab alignment issue. The issue was that jlab has different default css.

Yeah to make it work with the dark theme we'll need to use the jlab css variables I imagine. I think it can be merged with dark mode not supported.

Mmm this still looks weird on my side:

Which version of jupyterlab are you using?

Ok I think it's fixed now

Yes it looks nice!

It isn't too hard to get it working with dark theme, but requires slight tweaks to the colors to align with those provided as vars by jlab.

Awesome. Thanks @jsignell Let's leave dark theme compatibility for a future PR.

Should we expand the .data section of the DataArray HTML repr by default? That would look a little more consistent with the text repr.

Thanks a lot @jsignell ! It is great to see this merged finally!

Thanks @jsignell (and all).  I'm really jazzed about this.

this is awesome! I was so excited about it that I updated my little blog post with the latest xarray master https://predictablynoisy.com/xarray-explore-ieeg
I was pretty annoyed at the gigantic repr that came out of the DataArray, and now it is nice and tidy html!

Cool!
I guess this post about how you use notebooks in your blog is still up to date?
I looks like we'll need to fix a couple of issues (the channel coordinate looks weird), but maybe it is not related to the front-end.
Besides variable names, we probably need to somehow handle overflow for variables that have a long list of dimension labels.

Actually, no that's totally out of date now haha. Thanks for reminding me I should update that

I looks like we'll need to fix a couple of issues (the channel coordinate looks weird), but maybe it is not related to the front-end.

I am opening a PR. I didn't escape dtypes and this dtype is <U5 which html does terribly with

To verify proper escaping, we could validate the generated HTML as XML:
https://stackoverflow.com/questions/13742538/how-to-validate-xml-using-python-without-third-party-libs
This could be a good use case for Hypothesis. Or you could manually build a dataset with variables of every dtype.

I opened a PR and included a small test. It can probably go in while we work on a more complete testing infrastructure.

Besides variable names, we probably need to somehow handle overflow for variables that have a long list of dimension labels.

These are handled in the same way as long variable names, they truncate with an ellipsis and then expand on hover.

These are handled in the same way as long variable names, they truncate with an ellipsis and then expand on hover.

Oh yes I missed it.


Register for all events

Rework registerForEvents call completely.
Start registering for all server events.

Thanks @borisyankov !
I'm concerned about the duplication of registerForEvents plus registerForAllEvents -- particularly of the flags like
    apply_markdown: true,
    include_subscribers: false,
    client_gravatar: true,

They're identical for now, but this feels like the sort of setup that can very easily lead to one diverging from the other, and then to extreme confusion when the observed behavior seems to differ from the flags (because the flags we're actually using are in the other copy of this code.) This is exacerbated because the two copies are in completely separate files, making it very easy while looking at one to never realize the other exists.
I don't have a strong preference on whether we have one or two different functions exposed to the application code, but one way or another I definitely want those flag values to be written down in one shared place. Could have both import them from some "constants" or "defaults" module, or could give one of these modules a non-default export that does most of the work and then both modules' default exports just wrap that, or could put both of these in one module, etc.

Good points.
I did try to merge some work from the api PR, then iterated several times, then reworked this completely and this is the result.

Thanks! I like this direction, moving the specific options we use into the application code.
A couple of comments on specifics:

Let's leave null values in; those translate fine into JSON, and on the Python side into None.
In the commit that moves the options to the application code, another option all_public_streams: false is added. That should be a separate commit, if we want to do it.

Thanks again @borisyankov ! Merged.


Setup Fleek Github Action deployment

We can deploy the frontend soon. Need to figure out the subdomians for ownme.io for the app vs promo page. Or combine them?

we use AWS