Fixed typos in sign-up and sign-in messages

Closes #20
🛠 Fixes Issue: #20
Type of change ✍
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

👨💻 Changes proposed:
In this pull request, I have fixed a typo in the message that appears after the successful sign-up process in the app. The typo was located in the file signupwindow.py in the python folder, specifically on line 37. Additionally, I have corrected the typo in the message that appears when a wrong password or username is entered on the sign-in page. This typo was located in the main.pyw file on line 36.
✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.
[x] My changes have not introduced any new warnings.
[x] I have conducted a self-review of my code.
[x] I am a participant of SWOC'24.

📷 Screenshots
Before:
1.

After:
1.

thanks for contributing @Burhanuddin-2001, keep solving more issues...


ISO file cannot be loaded by VirtualBox

I am trying to load the ISO file I created using Virtual Box, but am encountering errors when I try to add the disk to VirtualBox. I also can't open it with WinRAR. In qemu the file loads and works fine. I haven't tried loading it on real hardware, but I don't think it will work there either.
I also tried to create a UefiBoot disk, but now it doesn't work in qemu(just hangs), VirtualBox allows you to add it, but can't boot from it either.
What is wrong with it?

What errors are you facing with virtualbox?

@bjorn3
For BiosBoot:
Could not get the storage format of the medium 'bootable_biosboot.iso' (VERR_NOT_SUPPORTED).
Result Code: VBOX_E_IPRT_ERROR (0x80bb0005)
Result Detail: -37 (0xffffffdb)
Component: MediumWrap
Interface: IMedium {7d510820-a678-4730-a862-818dcd3fbed0}
Callee: IVirtualBox {d644ad1e-c501-4fc7-9ab6-aa6d763bc540}
Callee RC: VBOX_E_OBJECT_NOT_FOUND (0x80bb0001)

UefiBoot stopped working in qemu(just hangs from the start, nothing is displayed). In VirtualBox the disk is added, but VirtualBox can't boot it and keeps restarting asking for a new disk.

How did you attach the iso to the VM? Did you attach it as cd or as harddrive?

I add the iso in Virtual Media Manager as an optical disk.

@bjorn3,
VirtualBox behaves very strangely with UefiBoot ISO image, as if it does not see it, despite the settings of the virtual machine, where the disk is definitely inserted.
In general, all this seems to be some kind of incorrectly formed ISO.
I tried to do a simple check with isovfy and in the case of the UefiBoot disk it complained
Root at extent 9510959, 156567892 bytes
[0 0]
********Directory has unusual size
isovfy: Short read on old image

Oops, I was stupid and thought it was creating an iso file, but it's actually a disk image. Everything's fine now.


Role Assignments API fails for new roles

👋
When attempting to use the Role Assignments API to create a role assignment for a new role (such as Virtual Machine User Login) - the API returns the following error message:
authorization.RoleAssignmentsClient#Create: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="UnsupportedApiVersionForRoleDefinitionHasDataActions" Message="Assignments to roles with DataActions and NotDataActions are not supported on API version '2015-07-01'. The minimum required API version for this operations is '2018-01-01-preview'."

Whilst I can understand this behaviour, this is a poor user experience when users would expect the role assignment to silently handle calling the new API in the background. Would it be possible to reach out to the service team here?
In the mean time it appears there's support for this new version in the SDK - so we could look into migrating across to that version.
Thanks!

Thanks for the insightful feedback as always @tombuildsstuff, cc @ravbhatnagar from Resource Manager service team. Azure APIs don't automatically transform requests and use updated versions cause semantic consistency between versions isn't guaranteed and we may not get the user's intention right. Also, the old API version is still live and supported for direct (i.e. without transformation) use.
Glad to see you were able to address this in Terraform by upgrading to the later API in https://github.com/terraform-providers/terraform-provider-azurerm/pull/1284.


word-break on small screens

Is there a reason <h3> have a word-break: break-all; on small screens? I feel it makes the headers a little bit harder to read

css in question:
@media (max-width: 599px) {
  .css-51kfyg h3, [data-css-51kfyg] h3 {
      word-break: break-all;
  }
}

I put it there because otherwise headers with long words would add horizontal scroll on the page.
Do you know if there's a way to avoid both problems?

Nothing comes to mind that doesn’t require extra markup. Do you have any example of those headers with long words I can test on?
On Jun 30, 2018, 19:10 +0400, Dan Abramov<EMAIL_ADDRESS>wrote:

I put it there because otherwise headers with long words would add horizontal scroll on the page.
Do you know if there's a way to avoid both problems?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

React.Component page in the API reference on an iPhone.

The long words are all code tags, so changing

Seems like this issue has been fixed. Closing this issue. Thanks :)


arm vs arm64 for Pi 3B+

I am using dnscrypt arm build on my 3B+. I know that the Pixel OS's are 32 bit, but since the 3B+ has a 64 bit cpu, has anyone tried dnscrypt arm64 on the 3B+?

is there any difference in performance ?

It's negligible.


CC0014 Use ternary tries to DirectCast integer to double

#Bug
  if condition then
    return aDouble
  else
    return bInteger
  end if

Current output after fix applied (if it is a code fix bug):
  return If(condition, aDouble, DirectCast(bInteger,Double))

Expected output after fix applied (if it is a code fix bug):
  return If(condition, aDouble, bInteger)

Here is the spec to conversions for VB:
https://github.com/ljw1004/vbspec/blob/gh-pages/vb/conversions.md#numeric-conversions


Shared chest : need default Tree leaves.

Well let's say it's realistic to put a leaf over a steel ingot to get a locked chest or shared locked chest… Ok come on it's a game it's not made to be realistic.
But then, why couldn't we use ANY kind of leaf (maybe even bush leaves) ?
It would really be more coherent to accept the "group" leaves, and we could maybe do the same about the steel ingot and allow any of the group as well.
Thanks in advance for your feedbacks about it

Great feedback, we will make more coherent the craft recipe of locked chests with your proposals

I could help, Let me make a pull request about it tonight ? :)

Of course you can, it will be very helpful for us ! :)
Currently it's a little difficult in our side, many bugs to fix(Classic) and many improves to code (Skyblock) =)

Ok.
Why? Why should we modify the recipe? What's the arguement?

@LeMagnesium I'd just allow any kind of leaves to be used in that recipe (which means the group)
not change the steel ingot thing. I think it would be more coherent

Ok, I looked at the recipe. I was confused when you talked about Default's locked chests, but since shared chests already have a leaves block in their recipes I'm ok with switching to group:leaves.
So there you have it, it doesn't take much time to do : https://github.com/MinetestForFun/server-minetestforfun/commit/88ee617741c4a488e7fdf03dd67493787c1f0f83

Thanks :heart_eyes:


Show author name as link to author's profile

For each content item, represent the author's name as a link redirecting to the author's profile page.
Can be done after profile page is implemented.

Done QA: works fine.
Idea´s for improvement tickets:

Do the same thing for comments. (so link to the profile for the person who made the comment)
Have a "go back" button on profile to go back to the previous page.


Not getting consistent result while overriding clang-tidy check for an particular service

Hi ,
I have a global clang-tidy profile in our monorepo but in a particular service i dont want to use global configuration rather i have different set of checks.
i am getting surprising issues that is if i ran with local clang-tidy configuration and lets say the perticular CPP file dont have any issue then later when i try to run the same file with global config i am not getting any error because of the bazel cache .

I am working with @ananta-code and can provide some additional information. I believe the rule behaves correctly, but the README is misleading for two reasons:

If a .clang-tidy file exists in the root directory of the workspace, clang-tidy will use it regardless of what is specified in the clang_tidy_config. I'm referring to this logic: https://github.com/erenon/bazel_clang_tidy/blob/master/clang_tidy/run_clang_tidy.sh#L22

If a .clang-tidy file also exists in the source code tree, clang-tidy will use it and will ignore the "global" .clang-tidy file, overriding what's specified in the clang_tidy_config. Refer to https://clang.llvm.org/extra/clang-tidy/ under "Configuration files:"

This results in unexpected behavior for users. First of all, it's unclear which .clang-tidy file will be used. The one referenced via clang_tidy_config may be ignored. Secondly, Bazel may not invalidate the cache when the local .clang-tidy file is changed. This is because Bazel is only aware of a single .clang-tidy file – the one referenced in the config. Changes to other config files in the source tree are hidden from Bazel, resulting in seemingly inconsistent behavior.
May I suggest updating the documentation (README) to explain which config will be used. In particular, the only time Bazel honors the clang_tidy_config is when there are no .clang-tidy config files present in source directory or any of its parent directories up to the workspace root. If any are present, they take precedence over whatever was specified through --@com_github_erenon_bazel_clang_tidy//:clang_tidy_config=.


Comparison operators in the summary description are being ignored (in some cases)

YARD version
Ruby version

0.8.4
2.1.1

The bugged docstring
# Creates the HTML element <source> with an optional +<figcaption>+ and a * b > c < d

The output

👏

It took me a while to get to this but there doesn't seem to be a good reason to strip HTML out of a docstring summary at the low level. If raw HTML is used in the summary string, it should be escaped with proper markup formatting anyway, so there's no rendering issue here.


implement deinterlacing for sub-8 bit pixels

closes #140

I don't think the implementation is correct yet, I have to keep working on this still.

I've been testing using this image: https://github.com/image-rs/image-png/blob/master/tests/pngsuite/basn3p01.png
This image has Adam7 interlacing; so I'm expecting these scanlines to start:

Pass 1: 4 lines of [0x0] (4 bits of 0) for the first n * 8 pixels
Pass 2: 4 lines of [0x0F] (4 bits of 1) for the first 4 + n * 8 pixels

However, for the scanlines of pass 2 I'm getting [0xF0] instead which is really strange; are the bits supposed to be reversed, or is this due to the decoder not shifting the bits all the way down because it only received 4 for the scanline?
@HeroicKatora @martinlindhe @Shnatsel

The default Transformation options for Decoder will expand the pixels into full u8 values by scaling them with a factor, here: https://github.com/image-rs/image-png/blob/2955393dbac799586ecc852b35f63a1ba26a0a4f/src/decoder/mod.rs#L309-L311
I suppose that would explain additional trailing zeroes?

@HeroicKatora I'm testing with just IDENTITY: https://github.com/image-rs/image-png/pull/142/files#diff-0bb1608151f4a8d1d056c46f21407090R7

@abonander I see, this is ' 1 bit (2 color) paletted ' image (according to the png suite) so RGB is irrelevant anyways. It wasn't clear to me what the expected result is. With that additional information the behaviour seems less weird.

According to the specification the sample values (1-bit) are packed into the high-order bits in every scanline.
Scanlines that are not aligned to byte boundaries are padded.
The scanlines of the second pass consist of 4 pixels with the same palette index 1. It follows that the 4 pixels of every scanline in the second pass are in the 4 high order bits of a single byte where the low order bits are zero padding.

@HeroicKatora I was looking at mainly the Wikipedia article which doesn't go into detail on scanline layout. I expected samples to start in the low-order bits which is why I was confused.

I see my change has now broken deinterlacing for bit depths > 8, I'll work on that tonight.

I'm close to a working implementation; I missed the bit in the spec how each scanline should start on a byte boundary so I will fix that tomorrow.

@HeroicKatora build is passing now, the failure is an ICE on nightly.

@abonander What's the status on this? There seem to be conflicts in utils.rs from the removal of num-iter but the changes in this PR seem like pure formatting.

@HeroicKatora most of the changes are in utils.rs; the formatting differences are due to changes which I need to rebase onto.
This was failing on nightly due to an ICE which didn't seem related to the change so I was waiting for the build to be rerun when nightly updated.

Ehm, I meant the changes with conflicts, sorry. We've remove the failing nightly build (only the one depending on -Z minimal-versions was failing, the normal nightly did not. so it really wasn't critical for merging and is now alled-failure) so might retest now.

Oh. Of course Travis relies on a possible merge to check a PR.

@abonander Since I didn't realize the conflict of removing num-iter and the pending changes here (and this one should have had priority), can I be of assistance for the rebase?

@abonander I had the time to rebase onto master. You can have a look in this branch. Sorry again for missing the coordination between the PRs here.

The rebase wasn't difficult but thanks anyway.

You missed an instance of use num-iter:: that should be replaced with (start..step).step_by(bits_pp * samp_mul).

Ah no, I just forgot that that got removed, sorry.

@abonander Also, congratulations, you are already one of the top contributors of the crate with this :smile:


[Feature Request] Hide Extra Details

The module automatically adds the entire description of the item that created the effect to that effect's description. This has caused several issues where players spoiled themselves by reading what a skill from a creature does before they shouldn't. It would be nice if there was a toggle to prevent this.

The module automatically adds the entire description of the item that created the effect to that effect's description.

This would certainly be news to me.

Sorry I have so many modules so perhaps I'm mistaken but doesn't this module add this description to the effects?

The "No" is the actual effect description,  the "details" is the description of the skill that made this effect.

If I try to see the effect tooltip any other way then it doesn't show up the "details"

If you have a lot of modules and you suspect there is an issue with a single one of them, the first thing you should do is disable all but that one. Then see if the issue persists.

Unfortunately I have tried. I've been using "Find the culprit!" but every time I run it I've gotten 2 different results "Warpgate" and "Monk's Active Tiles". Which tells me that there must be something wrong with the methodology I'm using to test the issue every time. I'm using the midiqol automation ecosystem so I'm sure one of them might be the culprit but is hard to find since all of them depend heavily on each other and several features break if one of them is disabled.
My best guess was that it was this mod since it only shows up in your mod's tooltip and nowhere else and if I turn off your mod then I can't test if the issue goes away or not. Thank you anyway.

The module Chris's Premades adds that as an optional setting. You would have had to explicitly turn on that setting in module integration.

Thank you for replying to this. Can you tell me where this setting is located? I might be blind but I checked and couldn't find it.

Settings -> Chris's Premades -> Module Integration

Omg that's what VAE stands for... I'll admit, perhaps at some point I knew that but since then I guess I forgot. I can even see you added a setting to selectively disable this setting for NPCs like I want.
Thank you for checking and posting a solution for my dim witted problem. I don't think I would have found it if it wasn't for you.


Unable to debug ADS Extension in VSCode

Started coming across this error while debugging extensions for ADS in VSCode 😕, it happens to me with other projects too (such as SandDance)

Anyone encountered this before? I suspect it has to do with my environment, but all the documentation I see online relating to this error is about scripting errors (I doubt all extensions are now broken 😅 ) I have the standard configuration:

Have running latest version of VSCode, VSCode extensions and Azure Data Studio.
Another thing I noticed is that the source maps are not loading -- do not know if this has an impact:

Current version of nodejs is v14.17.1

@joberume I've seen the missing source map errors as well.  Though I'm not having issues getting breakpoints into my extensions (for example, screenshot below in mssql extension).  As far as I can tell the errors in the above logs aren't related to the extension debugging.
What I generally do when debugging the extension host is to (1) run the main UI process from the CLI using .\scripts\sql.bat and then (2) use the Attach to Extension Host launch target in vscode.  Though I would suspect other methods should work as well.

The problem here as I understand it is that this extension doesn't live in the ADS repo - so he's trying to debug using the ADS debugger in VS Code as documented here : https://github.com/Microsoft/azuredatastudio/wiki/Debugging-an-Extension-with-VS-Code
None of us really use this since pretty much all the extensions we work on live in the ADS repo so we can debug from source. So it's possible that extension was broken at some point with a VS Code merge or something.
@joberume Are you able to try debugging ADS and the build-in extensions from source just to make sure that it's not something on your machine that's an issue here?

Thanks @Charles-Gagnon @kburtram for looking into this. I can confirm that this is not my environment as @dhgrajeda in my team was able to reproduce the same issue on his machine. I'll try the approach you suggested to me offline as a workaround.


add PHP 8 support

@mitulgolakiya 👀

@mitulgolakiya thank for the review
Can we merge this

./composer.json has been updated
Running composer install
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - infyomlabs/laravel-ui-stisla is locked to version 3.x-dev and an update of this package was not requested.
    - infyomlabs/laravel-ui-stisla 3.x-dev requires php ^7.3 -> your php version (8.0.1) does not satisfy that requirement.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

@alphaolomi just merged. I will create a release later tomorrow. you can use master branch as of now. It's equivalent to 3.0


Change default Node IP to link local

Seems the default <IP_ADDRESS> will overlap easily with routers that
use the 10.0.0.x address space as the default address space.
A customer ran into this problem and thus we should avoid using
(by default) something that is likely to conflict.
Internal ref; https://armiot.atlassian.net/browse/IOTNGGW-261

I was wondering could we just define this network with /32 prefix so nothing else would ever get routed there than this specific address.
Then only problem would be this specific address would be non reachable outside the device if it is used in the actual network.
(Just wondered should we go to something nasty like defining network address to be something else than 10.x.x.x like some random 11.x.x.x with /32 prefix, would that then work and have very unlikely to cause problems ?.)

Also idea Kevin proposed of using link local address  sounds like a solution.  (<IP_ADDRESS>/16 )
https://en.wikipedia.org/wiki/Link-local_address

<IP_ADDRESS> sounds good to me, in terms of KaaS any available IP will work.
I agree that we should reduce the subnet and I believe /32 should be ok. The Kubernetes node will get assigned this IP and since all communication with the Node goes through edge-proxy, I don't think it needs to be reachable from other devices on the network. @sk-arm do you see any problem with using a /32 subnet for the kaas0 interface?

Force pushed in the link local address now.

What about the other ones then @sk-arm  @ZakariasL ?
EDGE_PODCIDR = "<IP_ADDRESS>/24"
EDGE_PODCIDR_GW = "<IP_ADDRESS>"

2nd commit resolves that issue, pods can also use link local addresses. Great!

Does https://github.com/PelionIoT/meta-pelion-edge/blob/8b6b67c16969f3045f532b2c94363e69e5d3766f/recipes-containers/kubelet/files/kubelet-config.yaml the contents of that have to match also this?

@ZakariasL  will raise a new PR.

Proper PR in https://github.com/PelionIoT/meta-pelion-edge/pull/356


Add reduplicate stage to host filtering

takes the outputs from czid-dedup and outputs the duplicated reads (not including the original reads)
appending the dedup plus redup files should create the un-deduplicated output file

The code seems fine but why is this needed?

Closing. Need to do this, but for the new host filtering


null <- Ingest test fixtures update

This pull request includes updated ingest test fixtures.
Please review and merge if appropriate.

reverted/updated PR since running this, will not be merging


fela-plugin-validator to support CSSLint rule configuration

Description
https://github.com/rofrischmann/fela/issues/552
Example
Using validator plugin with CSSLint rule configuration
validator({
  useCSSLint: {
    important: false,
  },
})

Versioning

Minor
fela-plugin-validator
Checklist
Quality Assurance

You can also run yarn run check to run all 4 commands at once.

[x] The code was formatted using Prettier (yarn run format)
[x] The code has no linting errors (yarn run lint)
[x] All tests are passing (yarn run test)
[x] There are no flow-type errors (yarn run flow)

Changes
If one of the following checks doesn't make sense due to the type of PR, just check them.

[x] Tests have been added/updated
[x] Documentation has been added/updated
[x] My changes have proper flow-types

Is it backwards compatible with useCSSLint: true?
Otherwise we need a major update :P
Anyways, will check that PR in the afternoon (y)

Yes, it backwards compatible. If you set useCSSLint: true you will use config by default, as before. I did not correct previous tests.


sysbench 1TB historical data, replication performance is pretty slow

What did you do?

Create a changefeed, sink=mysql, pause it.
Workload: "sysbench --db-driver=mysql --mysql-host=xxx  --mysql-port=4000 --mysql-user=root --mysql-db=workload --tables=128 --table-size=30000000 --time=18000 --debug=true --threads=128  oltp_insert prepare"
Resume changefeed
Workload: "sysbench --db-driver=mysql --mysql-host=xxx  --mysql-port=4000 --mysql-user=root --mysql-db=workload --tables=128 --table-size=30000000 --time=18000 --debug=true --threads=128  oltp_insert run"

What did you expect to see?
No response
What did you see instead?

Changefeed cli resume  happened  in 6-16 20:28, during the next 14 hours, replication performance is really too slow:

Log: https://tcms.pingcap.net/dashboard/executions/plan/845391

Versions of the cluster
Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):
(paste TiDB cluster version here)

Upstream TiKV version (execute tikv-server --version):
TiKV
Release Version:   6.1.0-alpha
Edition:           Community
Git Commit Hash:   11b5d4c3d6ca740cc0bf272691fd15ec94345cd9
Git Commit Branch: heads/refs/tags/v6.1.0-nightly
UTC Build Time:    2022-06-15 11:04:15
Rust Version:      rustc 1.60.0-nightly (1e12aef3f 2022-02-13)
Enable Features:   pprof-fp jemalloc mem-profiling portable sse test-engine-kv-rocksdb test-engine-raft-raft-engine cloud-aws cloud-gcp cloud-azure
Profile:           dist_release

TiCDC version (execute cdc version):
# /cdc version
Release Version: v6.1.0-nightly
Git Commit Hash: 7d755affaff9347eda15949155cb83bcdb3d6429
Git Branch: heads/refs/tags/v6.1.0-nightly
UTC Build Time: 2022-06-15 11:04:58
Go Version: go version go1.18.2 linux/amd64
Failpoint Build: false

Puller writes PebbleDB too slow so that upstream incremental scans can't be finished on time. After incremental scans are finally finished, resolved timestamp can be updated and then cdc flushes lots of rows to the downstream sink.

/close


Modules linked, but still getting red border

I'm aware there have been a number of issues on this already, but the solution of running react-native link has not worked for me as it did for others. The result is a red border outlining the area to be blurred.
After running react-native link, I get the following:
rnpm-install info Android module react-native-blur is already linked
rnpm-install info iOS module react-native-blur is already linked

Is there anything else I should be doing?
React-Native: 0.45.0
React-Native-Blur: 3.0.0

Didn't see step 5. Needed to rerun react-native run-ios

That fix it for me as well


[EKSv2]: Rancher should be able to fully communicate with private EKS clusters

What kind of request is this (question/bug/enhancement/feature request):
enhancement
Steps to reproduce (least amount of steps as possible):

Create or register private EKS cluster (a cluster that only has Private Access enabled).

Result:
Error: "Failed to communicate with cluster.
Even if a cluster is created as Public/Private then has public disabled, the agent will connect but health checks will error.
Desire:
Registering a private EKS cluster should work and rancher should be able to communicate with it.
Creating a private EKS cluster should work. This flow will still require the user to use a command to deploy the agent, similar to regular imported clusters, described here:  https://github.com/rancher/rancher/issues/28356.
Notes:
It is possible to import a private cluster through regular import. This is because imported clusters tunnel any communication between rancher and the downstream server through the agent and communicate with the kubernetes service IP (which is private) instead of the public endpoint. The solution for this should probably use this same approach for EKS clusters. Requests should be tunneled and instead of using the public Kube API endpoint, the kubernetes service ip should be used. Part of this is handled in authorizeCluster function located in pkg/tunnelserver/tunnel.go.
This is blocking: https://github.com/rancher/rancher/issues/28356

On 2.5-head - commit id: 395b4fe77
Validated the following use cases:
Use case#1

Deploy an EKS cluster with only Private access enabled.
The cluster comes to Waiting to register state
Import the cluster using import command from Rancher UI ( rancher server is on the same subnet/security group as the EKS cluster).
Eks cluster come sup Active.

Usecase#2

Edit the above created cluster.
Add a nodegroup
Save changes made.
Cluster goes into Updating state and nodes get added and the cluster comes up Active.

Usecase#3

Edit the above cluster. Update the k8s version. Save the changes made.
Cluster goes into Updating state

This enhancement is verified with Rancher server rancher\rancher:master-head version e129f92 and rancher\rancher:master-head version 6ad4dce72
Hosted EKS cases:
Use case#1

Deploy an EKS cluster with only Private access enabled.
The cluster comes to Waiting to register state
Import the cluster using import command from Rancher UI ( rancher server is on the same subnet/security group as the EKS cluster).
Eks cluster come sup Active.

Use case#2

Deploy an EKS cluster with both Private and Public access enabled.
Wait for cluster to become active.
Edit cluster. Disable Private access.
Wait for cluster to update.
Edit cluster. Verify Rancher can still reach cluster.

Use case#3

Deploy an EKS cluster with Public access enabled.
Wait for cluster to become active.
Edit cluster. Disable Public access. Enable Private access.
Wait for cluster to update.
Edit cluster. Verify Rancher can still reach cluster.

Imported EKS cases:
Use case#1:

In EKS console, create a cluster with only Private access.
In Rancher, import cluster using cluster-agent import command.
EKS cluster becomes active.

Use case#2:

In EKS console, create a cluster with Public and Private access.
In Rancher, import cluster.
Wait for cluster to become active.
Edit cluster. Disable Public access. Enable Private access.
Wait for cluster to update.
Edit cluster. Verify Rancher can still reach cluster.

Tested an additional use case for hosted private EKS cluster.

Create a single node Rancher setup in DO (separated from EC2 VPCs and subnets).
In Rancher, deploy an EKS cluster with only Private access enabled.
The cluster comes to Waiting to register state
Import the cluster using import command from Rancher UI (cluster must be reached from the same VPC and subnet)
EKS cluster comes up Active.

Import the cluster using import command from Rancher UI (cluster must be reached from the same VPC and subnet)
EKS cluster comes up Active.

Thank you @aaronRancher I have a similar problem but instead of k3s and EKS being on the same VPC and subnet, they are in difference AWS accounts with VPC peering cross-connected with unrestricted networking. Is there any reason for that not to work in the same procedure as you described? Thanks.

Never mind. I got it it working after mapping the role/user: https://eksctl.io/usage/iam-identity-mappings/#manage-iam-users-and-roles
And in my experience with v2.5.5, I didn't even have to do the manual import command (I am using EKSv3). Thanks.


DASH format: https://en.wikipedia.org/wiki/Dynamic_Adaptive_Streaming_over_HTTP
HLS protocol: https://en.wikipedia.org/wiki/HTTP_Live_Streaming

Thank you for the link you provided, which gave me an idea of the content of the download. I have also been exposed to m3u8 related scenes before;
I still remember that when I encountered this problem, some courses were able to download videos and subtitles successfully, but the last few modules only had subtitles. I am sure of this, because I downloaded it twice, and the log file can also be included in the log file. In the first half, we can see the signs of successful video download.

Thank you for the link you provided, which gave me an idea of the content of the download. I have also been exposed to m3u8 related scenes before;
I still remember that when I encountered this problem, some courses were able to download videos and subtitles successfully, but the last few modules only had subtitles. I am sure of this, because I downloaded it twice, and the log file can also be included in the log file. In the first half, we can see the signs of successful video download.

Subtitles are still downloaded for HLS even if HLS is disabled, this is just behavior I didn’t consider. I can change that to skip subtitles for hls
…
On Sat, Jan 1, 2022 at 3:34 AM caijingwen-vincent @.> wrote: when I add a options --skip-hls , the sources can download completely . Is this a bug of hls? — Reply to this email directly, view it on GitHub <#89 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADREJXTLRIRXFVADKVDJ4ELUT24CTANCNFSM5LCHDQGA . You are receiving this because you were assigned.Message ID<EMAIL_ADDRESS>
Sir, So should I disable Hls and still need to add --skip-hls to download all resources after fixing this BUG ？
Happy new years.

I'll push an update in a little bit that will skip downloading captions if you specify --skip-hls
Also, what did you mean by this? when I add a options --skip-hls , the sources can download completely . Is this a bug of hls?

Beacause I don't know any knowledge about hls . At this moment , when I add a options --skip-hls , the resources about video,assets,subtitle can download completely ; However when I miss the options of --skip-hls , the resources will incompletely , like lack of video ..

Reviewing the log file, it seems like you are telling it to skip lectures, not skip HLS.

--skip-hls will only skip HLS style video
--skip-lectures will make the program not download ANY video files
--download-captions will download subtitles, even if the program doesn't download video
--download-assets will download stuff like PDFs, mp3s, etc

Incoming nerdy stuff, ignore if you don't care
Udemy has 3 ways of distributing video:

A single MP4 file: this type is used when there is no DRM involved, contains both audio and video in a single file
DASH: an XML style manifest, contains information about all video resolutions and audio tracks, as well as any DRM information, often used for video streaming. There are separate audio and video files
M3U8 (HLS): Plain text file list of different video and audio tracks, also contains DRM information, often used for video streaming. There are separate audio and video files

Both HLS and DASH are both Adaptive Bitrate streaming and are often used when breaking an audio or video file into smaller pieces (although sometimes they can still just be a single mp4 file but with separate audio and video files). so the skip-hls option will completely ignore HLS playlists, it wont download the manifest and it wont process the audio/video tracks that are in it.
If you are interested in a better explanation or more information, here are some links:

M3U playlist format: https://en.wikipedia.org/wiki/M3U
DASH format: https://en.wikipedia.org/wiki/Dynamic_Adaptive_Streaming_over_HTTP
HLS protocol: https://en.wikipedia.org/wiki/HTTP_Live_Streaming

Thank you for the link you provided, which gave me an idea of the content of the download. I have also been exposed to m3u8 related scenes before;
I still remember that when I encountered this problem, some courses were able to download videos and subtitles successfully, but the last few modules only had subtitles. I am sure of this, because I downloaded it twice, and the log file can also be included in the log file. In the first half, we can see the signs of successful video download.

Subtitles are still downloaded for HLS even if HLS is disabled, this is just behavior I didn’t consider. I can change that to skip subtitles for hls
…
On Sat, Jan 1, 2022 at 3:34 AM caijingwen-vincent @.> wrote: when I add a options --skip-hls , the sources can download completely . Is this a bug of hls? — Reply to this email directly, view it on GitHub <#89 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADREJXTLRIRXFVADKVDJ4ELUT24CTANCNFSM5LCHDQGA . You are receiving this because you were assigned.Message ID<EMAIL_ADDRESS>
Sir, So should I disable Hls and still need to add --skip-hls to download all resources after fixing this BUG ？
Happy new years.

I'll push an update in a little bit that will skip downloading captions if you specify --skip-hls
Also, what did you mean by this? when I add a options --skip-hls , the sources can download completely . Is this a bug of hls?

Beacause I don't know any knowledge about hls . At this moment , when I add a options --skip-hls , the resources about video,assets,subtitle can download completely ; However when I miss the options of --skip-hls , the resources will incompletely , like lack of video ..

Reviewing the log file, it seems like you are telling it to skip lectures, not skip HLS.

--skip-hls will only skip HLS style video
--skip-lectures will make the program not download ANY video files
--download-captions will download subtitles, even if the program doesn't download video
--download-assets will download stuff like PDFs, mp3s, etc

Incoming nerdy stuff, ignore if you don't care
Udemy has 3 ways of distributing video:

A single MP4 file: this type is used when there is no DRM involved, contains both audio and video in a single file
DASH: an XML style manifest, contains information about all video resolutions and audio tracks, as well as any DRM information, often used for video streaming. There are separate audio and video files
M3U8 (HLS): Plain text file list of different video and audio tracks, also contains DRM information, often used for video streaming. There are separate audio and video files

Both HLS and DASH are both Adaptive Bitrate streaming and are often used when breaking an audio or video file into smaller pieces (although sometimes they can still just be a single mp4 file but with separate audio and video files). so the skip-hls option will completely ignore HLS playlists, it wont download the manifest and it wont process the audio/video tracks that are in it.
If you are interested in a better explanation or more information, here are some links:

M3U playlist format: https://en.wikipedia.org/wiki/M3U
DASH format: https://en.wikipedia.org/wiki/Dynamic_Adaptive_Streaming_over_HTTP
HLS protocol: https://en.wikipedia.org/wiki/HTTP_Live_Streaming

Thank you for the link you provided, which gave me an idea of the content of the download. I have also been exposed to m3u8 related scenes before;
I still remember that when I encountered this problem, some courses were able to download videos and subtitles successfully, but the last few modules only had subtitles. I am sure of this, because I downloaded it twice, and the log file can also be included in the log file. In the first half, we can see the signs of successful video download.

Subtitles are still downloaded for HLS even if HLS is disabled, this is just behavior I didn’t consider. I can change that to skip subtitles for hls
…
On Sat, Jan 1, 2022 at 3:34 AM caijingwen-vincent @.> wrote: when I add a options --skip-hls , the sources can download completely . Is this a bug of hls? — Reply to this email directly, view it on GitHub <#89 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADREJXTLRIRXFVADKVDJ4ELUT24CTANCNFSM5LCHDQGA . You are receiving this because you were assigned.Message ID<EMAIL_ADDRESS>
Sir, So should I disable Hls and still need to add --skip-hls to download all resources after fixing this BUG ？
Happy new years.

I'll push an update in a little bit that will skip downloading captions if you specify --skip-hls
Also, what did you mean by this? when I add a options --skip-hls , the sources can download completely . Is this a bug of hls?

Beacause I don't know any knowledge about hls . At this moment , when I add a options --skip-hls , the resources about video,assets,subtitle can download completely ; However when I miss the options of --skip-hls , the resources will incompletely , like lack of video ..

Reviewing the log file, it seems like you are telling it to skip lectures, not skip HLS.

--skip-hls will only skip HLS style video
--skip-lectures will make the program not download ANY video files
--download-captions will download subtitles, even if the program doesn't download video
--download-assets will download stuff like PDFs, mp3s, etc

Incoming nerdy stuff, ignore if you don't care
Udemy has 3 ways of distributing video:

A single MP4 file: this type is used when there is no DRM involved, contains both audio and video in a single file
DASH: an XML style manifest, contains information about all video resolutions and audio tracks, as well as any DRM information, often used for video streaming. There are separate audio and video files
M3U8 (HLS): Plain text file list of different video and audio tracks, also contains DRM information, often used for video streaming. There are separate audio and video files

Both HLS and DASH are both Adaptive Bitrate streaming and are often used when breaking an audio or video file into smaller pieces (although sometimes they can still just be a single mp4 file but with separate audio and video files). so the skip-hls option will completely ignore HLS playlists, it wont download the manifest and it wont process the audio/video tracks that are in it.
If you are interested in a better explanation or more information, here are some links:

M3U playlist format: https://en.wikipedia.org/wiki/M3U
DASH format: https://en.wikipedia.org/wiki/Dynamic_Adaptive_Streaming_over_HTTP
HLS protocol: https://en.wikipedia.org/wiki/HTTP_Live_Streaming

Thank you for the link you provided, which gave me an idea of the content of the download. I have also been exposed to m3u8 related scenes before;
I still remember that when I encountered this problem, some courses were able to download videos and subtitles successfully, but the last few modules only had subtitles. I am sure of this, because I downloaded it twice, and the log file can also be included in the log file. In the first half, we can see the signs of successful video download.

Ah, okay. I see that now and I understand what the issue is. I've push a new commit to the master branch that includes a few more debug things. It would be helpful if you can start using --log-level DEBUG to any commands and post the log from that, that will help me see what could be happening.

Subtitles are still downloaded for HLS even if HLS is disabled, this is just behavior I didn’t consider. I can change that to skip subtitles for hls
…
On Sat, Jan 1, 2022 at 3:34 AM caijingwen-vincent @.> wrote: when I add a options --skip-hls , the sources can download completely . Is this a bug of hls? — Reply to this email directly, view it on GitHub <#89 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADREJXTLRIRXFVADKVDJ4ELUT24CTANCNFSM5LCHDQGA . You are receiving this because you were assigned.Message ID<EMAIL_ADDRESS>
Sir, So should I disable Hls and still need to add --skip-hls to download all resources after fixing this BUG ？
Happy new years.

I'll push an update in a little bit that will skip downloading captions if you specify --skip-hls
Also, what did you mean by this? when I add a options --skip-hls , the sources can download completely . Is this a bug of hls?

Beacause I don't know any knowledge about hls . At this moment , when I add a options --skip-hls , the resources about video,assets,subtitle can download completely ; However when I miss the options of --skip-hls , the resources will incompletely , like lack of video ..

Reviewing the log file, it seems like you are telling it to skip lectures, not skip HLS.

--skip-hls will only skip HLS style video
--skip-lectures will make the program not download ANY video files
--download-captions will download subtitles, even if the program doesn't download video
--download-assets will download stuff like PDFs, mp3s, etc

Incoming nerdy stuff, ignore if you don't care
Udemy has 3 ways of distributing video:

A single MP4 file: this type is used when there is no DRM involved, contains both audio and video in a single file
DASH: an XML style manifest, contains information about all video resolutions and audio tracks, as well as any DRM information, often used for video streaming. There are separate audio and video files
M3U8 (HLS): Plain text file list of different video and audio tracks, also contains DRM information, often used for video streaming. There are separate audio and video files

Both HLS and DASH are both Adaptive Bitrate streaming and are often used when breaking an audio or video file into smaller pieces (although sometimes they can still just be a single mp4 file but with separate audio and video files). so the skip-hls option will completely ignore HLS playlists, it wont download the manifest and it wont process the audio/video tracks that are in it.
If you are interested in a better explanation or more information, here are some links:

M3U playlist format: https://en.wikipedia.org/wiki/M3U
DASH format: https://en.wikipedia.org/wiki/Dynamic_Adaptive_Streaming_over_HTTP
HLS protocol: https://en.wikipedia.org/wiki/HTTP_Live_Streaming

Thank you for the link you provided, which gave me an idea of the content of the download. I have also been exposed to m3u8 related scenes before;
I still remember that when I encountered this problem, some courses were able to download videos and subtitles successfully, but the last few modules only had subtitles. I am sure of this, because I downloaded it twice, and the log file can also be included in the log file. In the first half, we can see the signs of successful video download.

Ah, okay. I see that now and I understand what the issue is. I've push a new commit to the master branch that includes a few more debug things. It would be helpful if you can start using --log-level DEBUG to any commands and post the log from that, that will help me see what could be happening.

Subtitles are still downloaded for HLS even if HLS is disabled, this is just behavior I didn’t consider. I can change that to skip subtitles for hls
…
On Sat, Jan 1, 2022 at 3:34 AM caijingwen-vincent @.> wrote: when I add a options --skip-hls , the sources can download completely . Is this a bug of hls? — Reply to this email directly, view it on GitHub <#89 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADREJXTLRIRXFVADKVDJ4ELUT24CTANCNFSM5LCHDQGA . You are receiving this because you were assigned.Message ID<EMAIL_ADDRESS>
Sir, So should I disable Hls and still need to add --skip-hls to download all resources after fixing this BUG ？
Happy new years.

I'll push an update in a little bit that will skip downloading captions if you specify --skip-hls
Also, what did you mean by this? when I add a options --skip-hls , the sources can download completely . Is this a bug of hls?

Beacause I don't know any knowledge about hls . At this moment , when I add a options --skip-hls , the resources about video,assets,subtitle can download completely ; However when I miss the options of --skip-hls , the resources will incompletely , like lack of video ..

Reviewing the log file, it seems like you are telling it to skip lectures, not skip HLS.

--skip-hls will only skip HLS style video
--skip-lectures will make the program not download ANY video files
--download-captions will download subtitles, even if the program doesn't download video
--download-assets will download stuff like PDFs, mp3s, etc

Incoming nerdy stuff, ignore if you don't care
Udemy has 3 ways of distributing video:

A single MP4 file: this type is used when there is no DRM involved, contains both audio and video in a single file
DASH: an XML style manifest, contains information about all video resolutions and audio tracks, as well as any DRM information, often used for video streaming. There are separate audio and video files
M3U8 (HLS): Plain text file list of different video and audio tracks, also contains DRM information, often used for video streaming. There are separate audio and video files

Both HLS and DASH are both Adaptive Bitrate streaming and are often used when breaking an audio or video file into smaller pieces (although sometimes they can still just be a single mp4 file but with separate audio and video files). so the skip-hls option will completely ignore HLS playlists, it wont download the manifest and it wont process the audio/video tracks that are in it.
If you are interested in a better explanation or more information, here are some links:

M3U playlist format: https://en.wikipedia.org/wiki/M3U
DASH format: https://en.wikipedia.org/wiki/Dynamic_Adaptive_Streaming_over_HTTP
HLS protocol: https://en.wikipedia.org/wiki/HTTP_Live_Streaming

Thank you for the link you provided, which gave me an idea of the content of the download. I have also been exposed to m3u8 related scenes before;
I still remember that when I encountered this problem, some courses were able to download videos and subtitles successfully, but the last few modules only had subtitles. I am sure of this, because I downloaded it twice, and the log file can also be included in the log file. In the first half, we can see the signs of successful video download.

Ah, okay. I see that now and I understand what the issue is. I've push a new commit to the master branch that includes a few more debug things. It would be helpful if you can start using --log-level DEBUG to any commands and post the log from that, that will help me see what could be happening.

Sure, I am going to rest later, I will reproduce this scene later and upload related debug logs

Subtitles are still downloaded for HLS even if HLS is disabled, this is just behavior I didn’t consider. I can change that to skip subtitles for hls
…
On Sat, Jan 1, 2022 at 3:34 AM caijingwen-vincent @.> wrote: when I add a options --skip-hls , the sources can download completely . Is this a bug of hls? — Reply to this email directly, view it on GitHub <#89 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADREJXTLRIRXFVADKVDJ4ELUT24CTANCNFSM5LCHDQGA . You are receiving this because you were assigned.Message ID<EMAIL_ADDRESS>
Sir, So should I disable Hls and still need to add --skip-hls to download all resources after fixing this BUG ？
Happy new years.

I'll push an update in a little bit that will skip downloading captions if you specify --skip-hls
Also, what did you mean by this? when I add a options --skip-hls , the sources can download completely . Is this a bug of hls?

Beacause I don't know any knowledge about hls . At this moment , when I add a options --skip-hls , the resources about video,assets,subtitle can download completely ; However when I miss the options of --skip-hls , the resources will incompletely , like lack of video ..

Reviewing the log file, it seems like you are telling it to skip lectures, not skip HLS.

--skip-hls will only skip HLS style video
--skip-lectures will make the program not download ANY video files
--download-captions will download subtitles, even if the program doesn't download video
--download-assets will download stuff like PDFs, mp3s, etc

Incoming nerdy stuff, ignore if you don't care
Udemy has 3 ways of distributing video:

A single MP4 file: this type is used when there is no DRM involved, contains both audio and video in a single file
DASH: an XML style manifest, contains information about all video resolutions and audio tracks, as well as any DRM information, often used for video streaming. There are separate audio and video files
M3U8 (HLS): Plain text file list of different video and audio tracks, also contains DRM information, often used for video streaming. There are separate audio and video files

Both HLS and DASH are both Adaptive Bitrate streaming and are often used when breaking an audio or video file into smaller pieces (although sometimes they can still just be a single mp4 file but with separate audio and video files). so the skip-hls option will completely ignore HLS playlists, it wont download the manifest and it wont process the audio/video tracks that are in it.
If you are interested in a better explanation or more information, here are some links:

M3U playlist format: https://en.wikipedia.org/wiki/M3U
DASH format: https://en.wikipedia.org/wiki/Dynamic_Adaptive_Streaming_over_HTTP
HLS protocol: https://en.wikipedia.org/wiki/HTTP_Live_Streaming

Thank you for the link you provided, which gave me an idea of the content of the download. I have also been exposed to m3u8 related scenes before;
I still remember that when I encountered this problem, some courses were able to download videos and subtitles successfully, but the last few modules only had subtitles. I am sure of this, because I downloaded it twice, and the log file can also be included in the log file. In the first half, we can see the signs of successful video download.

Ah, okay. I see that now and I understand what the issue is. I've push a new commit to the master branch that includes a few more debug things. It would be helpful if you can start using --log-level DEBUG to any commands and post the log from that, that will help me see what could be happening.

Sure, I am going to rest later, I will reproduce this scene later and upload related debug logs

You can contact me for full working version of O11 OTT Streamer V2!!! Latest Build!!!
https://t.me/zaddyst

License Offline and install Unlimited servers
Script Autoinstall and Autorestart
O11 v2 supports 5 running modes
Internal remuxer
FFmpeg resident
FFmpeg TS HLS/Direct
FFmpeg MultiTS HLS
FMP4 HL
O11 v2 supports 5 output modes
HLS/Direct
SRT Server
Custom Pipe
UDP/SRT Push
MPEGTS
Ondemand function
Network Params
HTTP/SOCKS5 Proxy
Bind
DNS over HTTPS
Script,Manifest,Media files
Scripts
action=manifest - Manifest script
action=cdm drm=[widevine or playready] cdm=[internal or external] challenge=[drm challenger] pssh=[pssh used to extract needed keys] - Cdm script
action=events - Events
action=channels - Channels
action - Heartbeat


WIP: DO NOT MERGE: [Release] Verify 8.0.1 RC0

@github-actions crossbow submit verify-rc-source-go-* --param release=8.0.1 --param rc=0

Released.


Designs Generated from a Combinatorial Design Need New Sequences

Currently, clicking the "Expand the combinatorial design" button generates a set of ComponentDefinitions where each one has the sequence property of the template ComponentDefinition from which it was derived. Instead, each one of these generated ComponentDefinitions should be given a sequence property that refers to a newly generated Sequence object. This generated Sequence object should have an elements property that is the concatenation of the elements from the Sequences of the definitions for the sub-Components of the generated ComponentDefinition (in accordance with the relevant SequenceConstraints that refer to these sub-Components).

Accordingly, the sub-Components of the generated ComponentDefinition should also have SequenceAnnotations that specify their location on the generated Sequence.

Enumeration seems to have a number of issues.  It not only does not generate correct sequences, but it also does not always generate correct orders.  In the attached example, there is a zero-or-oen promoter and when it is zero, the sequence constraints are lost losing the part order.  See generated instance 222, for example.
Test.zip

Hey Nicholas. I've been taking a look at this issue and I am unable to repeat the error you are getting. The steps I'm following is opening the 'Test.xml' file in SBOLDesigner from the 'Test.zip' listed above. After opening this file I am prompted to chose a design, choosing 'Test'. After opening 'Test' I enumerate the designs, generating a new xml file. After opening this new xml file in SBOLDesigner I find that all of the designs appear to have the correct sequences relating to the enumerated design. Let me know if you get different results and perhaps provide me an exact example where you experience this issue, including all files used.

This file was generated by me.  However, it would be good if Nic could upload his tests that failed.

On Aug 21, 2019, at 11:17 AM, SamuelSauce<EMAIL_ADDRESS>wrote:
Hey Nicholas. I've been taking a look at this issue and I am unable to repeat the error you are getting. The steps I'm following is opening the 'Test.xml' file in SBOLDesigner from the 'Test.zip' listed above. After opening this file I am prompted to chose a design, choosing 'Test'. After opening 'Test' I enumerate the designs, generating a new xml file. After opening this new xml file in SBOLDesigner I find that all of the designs appear to have the correct sequences relating to the enumerated design. Let me know if you get different results and perhaps provide me an exact example where you experience this issue, including all files used.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/SynBioDex/SBOLDesigner/issues/360?email_source=notifications&email_token=AA2YH54AVDIST455J5YFLJLQFV2AZA5CNFSM4H4TIO62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD42OGMA#issuecomment-523559728, or mute the thread https://github.com/notifications/unsubscribe-auth/AA2YH54VIFEZ4TZZCO4RAO3QFV2AZANCNFSM4H4TIO6Q.

This was fixed by PR #367


fix ExportsInfo

What kind of change does this PR introduce?
fixes #15633

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

Thanks


Support metrics

Support collecting metrics via rcrowley/go-metrics. Should support metrics on connection count (new connection counter) at a minimum.

Open question: what other metrics do we think are worthwile?

See #30


[BUG] org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu is flaky

Describe the bug
org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu is flaky
https://build.ci.opensearch.org/job/gradle-check/17145/
https://github.com/opensearch-project/OpenSearch/pull/7969#issuecomment-1582958510
REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu" -Dtests.seed=8B21150333870C73 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=tr -Dtests.timezone=Africa/Kinshasa -Druntime.java=20

org.opensearch.search.backpressure.SearchBackpressureIT > testSearchShardTaskCancellationWithHighCpu FAILED
    java.lang.AssertionError:
    Expected: a string containing "cpu usage exceeded"
         but: was null
        at __randomizedtesting.SeedInfo.seed([8B21150333870C73:BBB02F2B23057755]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
        at org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu(SearchBackpressureIT.java:196)

This should be resolved by #7978

Flaky test failures for testSearchShardTaskCancellationWithHighCpu:

https://build.ci.opensearch.org/job/gradle-check/17118/
https://build.ci.opensearch.org/job/gradle-check/17126/

Sadly, not fixed: https://github.com/opensearch-project/OpenSearch/pull/7988

Tragic... Gonna take a further look.

@PritLadani and @ketanv3, I hope all is well.
I am tagging you since I see you were two of the main authors of the SearchBackpressure changes. I am reaching out about this issue because I believe the issue we are running into right now is a race condition. I have done some digging after the initial change to the threshold time did not work and have come to the conclusion that the most likely cause is that a thread swap causes an issue.
Here is an example of some manual debugging I did to try to identify the issue:
[2023-06-12T13:06:55,561][INFO ][o.o.s.b.SearchBackpressureIT] [testSearchTaskCancellationWithHighCpu] before test
[2023-06-12T13:06:55,561][INFO ][o.o.s.b.SearchBackpressureIT] [testSearchTaskCancellationWithHighCpu] [SearchBackpressureIT#testSearchTaskCancellationWithHighCpu]: setting up test
[2023-06-12T13:06:55,568][INFO ][o.o.p.PluginsService     ] [node_s2] PluginService:onIndexModule index:[byThyomkTYei3-y4BeJ9Gw/tlJ-mcwoQJiKnOOu94hRxQ]
[2023-06-12T13:06:55,569][INFO ][o.o.c.m.MetadataIndexTemplateService] [node_s2] adding template [random_index_template] for index patterns [*]
[2023-06-12T13:06:55,588][INFO ][o.o.s.b.SearchBackpressureIT] [testSearchTaskCancellationWithHighCpu] [SearchBackpressureIT#testSearchTaskCancellationWithHighCpu]: all set up test
[2023-06-12T13:06:55,604][INFO ][o.o.c.s.ClusterSettings  ] [node_s3] updating [search_backpressure.node_duress.num_successive_breaches] from [3] to [1]
[2023-06-12T13:06:55,605][INFO ][o.o.c.s.ClusterSettings  ] [node_s3] updating [search_backpressure.node_duress.cpu_threshold] from [0.9] to [0.0]
[2023-06-12T13:06:55,605][INFO ][o.o.c.s.ClusterSettings  ] [node_s0] updating [search_backpressure.node_duress.num_successive_breaches] from [3] to [1]
[2023-06-12T13:06:55,605][INFO ][o.o.c.s.ClusterSettings  ] [node_s1] updating [search_backpressure.node_duress.num_successive_breaches] from [3] to [1]
[2023-06-12T13:06:55,605][INFO ][o.o.c.s.ClusterSettings  ] [node_s3] updating [search_backpressure.node_duress.heap_threshold] from [0.7] to [0.0]
[2023-06-12T13:06:55,605][INFO ][o.o.c.s.ClusterSettings  ] [node_s0] updating [search_backpressure.node_duress.cpu_threshold] from [0.9] to [0.0]
[2023-06-12T13:06:55,605][INFO ][o.o.c.s.ClusterSettings  ] [node_s3] updating [search_backpressure.search_task.total_heap_percent_threshold] from [0.05] to [0.0]
[2023-06-12T13:06:55,605][INFO ][o.o.c.s.ClusterSettings  ] [node_s1] updating [search_backpressure.node_duress.cpu_threshold] from [0.9] to [0.0]
[2023-06-12T13:06:55,605][INFO ][o.o.c.s.ClusterSettings  ] [node_s1] updating [search_backpressure.node_duress.heap_threshold] from [0.7] to [0.0]
[2023-06-12T13:06:55,605][INFO ][o.o.c.s.ClusterSettings  ] [node_s3] updating [search_backpressure.search_shard_task.total_heap_percent_threshold] from [0.05] to [0.0]
[2023-06-12T13:06:55,605][INFO ][o.o.c.s.ClusterSettings  ] [node_s0] updating [search_backpressure.node_duress.heap_threshold] from [0.7] to [0.0]
[2023-06-12T13:06:55,605][INFO ][o.o.c.s.ClusterSettings  ] [node_s0] updating [search_backpressure.search_task.total_heap_percent_threshold] from [0.05] to [0.0]
[2023-06-12T13:06:55,605][INFO ][o.o.c.s.ClusterSettings  ] [node_s1] updating [search_backpressure.search_task.total_heap_percent_threshold] from [0.05] to [0.0]
[2023-06-12T13:06:55,605][INFO ][o.o.c.s.ClusterSettings  ] [node_s0] updating [search_backpressure.search_shard_task.total_heap_percent_threshold] from [0.05] to [0.0]
[2023-06-12T13:06:55,605][INFO ][o.o.c.s.ClusterSettings  ] [node_s1] updating [search_backpressure.search_shard_task.total_heap_percent_threshold] from [0.05] to [0.0]
[2023-06-12T13:06:55,606][INFO ][o.o.c.s.ClusterSettings  ] [node_s2] updating [search_backpressure.node_duress.num_successive_breaches] from [3] to [1]
[2023-06-12T13:06:55,606][INFO ][o.o.c.s.ClusterSettings  ] [node_s2] updating [search_backpressure.node_duress.cpu_threshold] from [0.9] to [0.0]
[2023-06-12T13:06:55,606][INFO ][o.o.c.s.ClusterSettings  ] [node_s2] updating [search_backpressure.node_duress.heap_threshold] from [0.7] to [0.0]
[2023-06-12T13:06:55,607][INFO ][o.o.c.s.ClusterSettings  ] [node_s2] updating [search_backpressure.search_task.total_heap_percent_threshold] from [0.05] to [0.0]
[2023-06-12T13:06:55,607][INFO ][o.o.c.s.ClusterSettings  ] [node_s2] updating [search_backpressure.search_shard_task.total_heap_percent_threshold] from [0.05] to [0.0]
[2023-06-12T13:06:55,627][INFO ][o.o.c.s.ClusterSettings  ] [node_s3] updating [search_backpressure.search_task.cpu_time_millis_threshold] from [30000] to [50]
[2023-06-12T13:06:55,627][INFO ][o.o.c.s.ClusterSettings  ] [node_s1] updating [search_backpressure.search_task.cpu_time_millis_threshold] from [30000] to [50]
[2023-06-12T13:06:55,627][INFO ][o.o.c.s.ClusterSettings  ] [node_s3] updating [search_backpressure.mode] from [monitor_only] to [enforced]
[2023-06-12T13:06:55,627][INFO ][o.o.c.s.ClusterSettings  ] [node_s0] updating [search_backpressure.search_task.cpu_time_millis_threshold] from [30000] to [50]
[2023-06-12T13:06:55,627][INFO ][o.o.c.s.ClusterSettings  ] [node_s1] updating [search_backpressure.mode] from [monitor_only] to [enforced]
[2023-06-12T13:06:55,627][INFO ][o.o.c.s.ClusterSettings  ] [node_s0] updating [search_backpressure.mode] from [monitor_only] to [enforced]
[2023-06-12T13:06:55,628][INFO ][o.o.c.s.ClusterSettings  ] [node_s2] updating [search_backpressure.search_task.cpu_time_millis_threshold] from [30000] to [50]
[2023-06-12T13:06:55,629][INFO ][o.o.c.s.ClusterSettings  ] [node_s2] updating [search_backpressure.mode] from [monitor_only] to [enforced]
[2023-06-12T13:06:56,506][WARN ][o.o.s.b.SearchBackpressureService] [node_s2] [enforced mode] cancelling task [119] due to high resource consumption [cpu usage exceeded [861.2ms >= 50ms]]
Setting reason to: cpu usage exceeded [861.2ms >= 50ms]
Task is cancelled with reason: null
Caught exception is: cpu usage exceeded [861.2ms >= 50ms]
[2023-06-12T13:06:56,527][INFO ][o.o.c.s.ClusterSettings  ] [node_s3] updating [search_backpressure.node_duress.num_successive_breaches] from [1] to [3]
[2023-06-12T13:06:56,527][INFO ][o.o.c.s.ClusterSettings  ] [node_s1] updating [search_backpressure.node_duress.num_successive_breaches] from [1] to [3]
[2023-06-12T13:06:56,527][INFO ][o.o.c.s.ClusterSettings  ] [node_s0] updating [search_backpressure.node_duress.num_successive_breaches] from [1] to [3]
[2023-06-12T13:06:56,527][INFO ][o.o.c.s.ClusterSettings  ] [node_s3] updating [search_backpressure.node_duress.cpu_threshold] from [0.0] to [0.9]
[2023-06-12T13:06:56,527][INFO ][o.o.c.s.ClusterSettings  ] [node_s1] updating [search_backpressure.node_duress.cpu_threshold] from [0.0] to [0.9]
[2023-06-12T13:06:56,527][INFO ][o.o.c.s.ClusterSettings  ] [node_s3] updating [search_backpressure.node_duress.heap_threshold] from [0.0] to [0.7]
[2023-06-12T13:06:56,527][INFO ][o.o.c.s.ClusterSettings  ] [node_s3] updating [search_backpressure.search_task.total_heap_percent_threshold] from [0.0] to [0.05]
[2023-06-12T13:06:56,527][INFO ][o.o.c.s.ClusterSettings  ] [node_s0] updating [search_backpressure.node_duress.cpu_threshold] from [0.0] to [0.9]
[2023-06-12T13:06:56,527][INFO ][o.o.c.s.ClusterSettings  ] [node_s1] updating [search_backpressure.node_duress.heap_threshold] from [0.0] to [0.7]
[2023-06-12T13:06:56,528][INFO ][o.o.c.s.ClusterSettings  ] [node_s0] updating [search_backpressure.node_duress.heap_threshold] from [0.0] to [0.7]
[2023-06-12T13:06:56,528][INFO ][o.o.c.s.ClusterSettings  ] [node_s3] updating [search_backpressure.search_task.cpu_time_millis_threshold] from [50] to [30000]
[2023-06-12T13:06:56,528][INFO ][o.o.c.s.ClusterSettings  ] [node_s0] updating [search_backpressure.search_task.total_heap_percent_threshold] from [0.0] to [0.05]
[2023-06-12T13:06:56,528][INFO ][o.o.c.s.ClusterSettings  ] [node_s1] updating [search_backpressure.search_task.total_heap_percent_threshold] from [0.0] to [0.05]
[2023-06-12T13:06:56,528][INFO ][o.o.c.s.ClusterSettings  ] [node_s3] updating [search_backpressure.search_shard_task.total_heap_percent_threshold] from [0.0] to [0.05]
[2023-06-12T13:06:56,528][INFO ][o.o.c.s.ClusterSettings  ] [node_s0] updating [search_backpressure.search_task.cpu_time_millis_threshold] from [50] to [30000]
[2023-06-12T13:06:56,528][INFO ][o.o.c.s.ClusterSettings  ] [node_s1] updating [search_backpressure.search_task.cpu_time_millis_threshold] from [50] to [30000]
[2023-06-12T13:06:56,528][INFO ][o.o.c.s.ClusterSettings  ] [node_s3] updating [search_backpressure.mode] from [enforced] to [monitor_only]
[2023-06-12T13:06:56,528][INFO ][o.o.c.s.ClusterSettings  ] [node_s0] updating [search_backpressure.search_shard_task.total_heap_percent_threshold] from [0.0] to [0.05]
[2023-06-12T13:06:56,528][INFO ][o.o.c.s.ClusterSettings  ] [node_s1] updating [search_backpressure.search_shard_task.total_heap_percent_threshold] from [0.0] to [0.05]
[2023-06-12T13:06:56,528][INFO ][o.o.c.s.ClusterSettings  ] [node_s0] updating [search_backpressure.mode] from [enforced] to [monitor_only]
[2023-06-12T13:06:56,528][INFO ][o.o.c.s.ClusterSettings  ] [node_s1] updating [search_backpressure.mode] from [enforced] to [monitor_only]
[2023-06-12T13:06:56,529][INFO ][o.o.c.s.ClusterSettings  ] [node_s2] updating [search_backpressure.node_duress.num_successive_breaches] from [1] to [3]
[2023-06-12T13:06:56,529][INFO ][o.o.c.s.ClusterSettings  ] [node_s2] updating [search_backpressure.node_duress.cpu_threshold] from [0.0] to [0.9]
[2023-06-12T13:06:56,529][INFO ][o.o.c.s.ClusterSettings  ] [node_s2] updating [search_backpressure.node_duress.heap_threshold] from [0.0] to [0.7]
[2023-06-12T13:06:56,529][INFO ][o.o.c.s.ClusterSettings  ] [node_s2] updating [search_backpressure.search_task.total_heap_percent_threshold] from [0.0] to [0.05]
[2023-06-12T13:06:56,529][INFO ][o.o.c.s.ClusterSettings  ] [node_s2] updating [search_backpressure.search_task.cpu_time_millis_threshold] from [50] to [30000]
[2023-06-12T13:06:56,529][INFO ][o.o.c.s.ClusterSettings  ] [node_s2] updating [search_backpressure.search_shard_task.total_heap_percent_threshold] from [0.0] to [0.05]
[2023-06-12T13:06:56,529][INFO ][o.o.c.s.ClusterSettings  ] [node_s2] updating [search_backpressure.mode] from [enforced] to [monitor_only]
[2023-06-12T13:06:56,530][INFO ][o.o.s.b.SearchBackpressureIT] [testSearchTaskCancellationWithHighCpu] [SearchBackpressureIT#testSearchTaskCancellationWithHighCpu]: cleaning up after test
[2023-06-12T13:06:56,543][INFO ][o.o.c.m.MetadataIndexTemplateService] [node_s2] removing template [random_index_template]
[2023-06-12T13:06:56,563][INFO ][o.o.s.b.SearchBackpressureIT] [testSearchTaskCancellationWithHighCpu] [SearchBackpressureIT#testSearchTaskCancellationWithHighCpu]: cleaned up after test
[2023-06-12T13:06:56,563][INFO ][o.o.s.b.SearchBackpressureIT] [testSearchTaskCancellationWithHighCpu] after test

Notice that the statement goes from having a reason to not having one and back
Setting reason to: cpu usage exceeded [861.2ms >= 50ms]
Task is cancelled with reason: null
Caught exception is: cpu usage exceeded [861.2ms >= 50ms]

The ordering of these processes should not allow this if there is thread safe operation.
We can compare this to the log from a different run:
Setting reason to: cpu usage exceeded [802.5ms >= 50ms]
Task is cancelled with reason: cpu usage exceeded [802.5ms >= 50ms]
Caught exception is: cpu usage exceeded [802.5ms >= 50ms]

If you have any knowledge of the thread safety implementations you added it would be appreciated so we can try to diagnose this issue.

Hi @PritLadani, the location of those logging messages were CancellableTask.java L84, SearchBackpressureIT.java L410, and SearchBackpressureIT.java L177 & L195.
Hopefully this helps. I am still running into issues diagnosing the issue so any input from you would be appreciated :)

This seems to be due to multiple threads trying to access a volatile variable CancellableTask.reason at different times, but expecting same value.
Consider a thread has set the value of AtomicBoolean cancelled to true and yet to reach at line 87. Another thread from SearchBackpressureIT#407 reads the values of CancellableTask.cancelled and considers that the task is cancelled and tries to get the cancellation reason, but CancellableTask.reason has not been assigned any value yet.
I think putting this code block in a synchronized block should fix the issue. Can you please try this? @scrawfor99

Thanks @scrawfor99 for working on a previous fix. Reducing the CPU time threshold from 1000 ms to 50 ms should not be the correct fix as this code executes a busy-wait loop to simulate CPU cycles. It keeps running the loop until the threshold is breached and an exception is thrown. We should revert it to 1000 ms.
As @PritLadani rightly pointed out, the race-condition is due to the integration test thread reading the cancellation reason (here) before the server has updated it (here). We need to fix this by making the updates to the fields cancelled, cancellationStartTime, cancellationStartTimeNanos, reason atomic. Instead of adding a synchronized block, I would suggest wrapping these properties in an object and setting it via compare-and-swap.

Hi @ketanv3 and @PritLadani, thank you for following up so quickly. I will try what you suggested. I initially attempted to decrease the threshold since I noticed the optional would be thrown if it did not reach it and attempted a quick fix locally. Since it passed, I assumed that had been the issue.
That did not work though so I did an actual RCA and found the thread issue. I will go ahead and try to correct the thread issue as you suggested.


Optimize the sample code for Streaming documentation

Fix typos in the sample code and simply optimize it to match the output in the docs, link to the docs: https://js.langchain.com/docs/getting-started/guide-chat#streaming
previous output

current output

Ah, a better way is process.stdout.write(token), which doesn't clear the previous command line, but just doesn't wrap the output.

This answer is from chatgpt...


One line If statements

One line If statements, without a THEN, cause indentation.
If (true) Print "This shouldn't indent"
They also seem to cause problems with highlighting in some cases.


Create new jurisdictional admin role with no PII

As an Admin on Doorway,
I want to be able to add a Jurisdictional Admin user that does NOT have access to PII
As a Jurisdictional Admin without Access to PII, I should be able to do the following:

See all listings in my jurisdiction
Create listings in my jurisdiction
Export listings

As a Jurisdictional Admin without Access to PII, I should NOT be able to do the following:

View the applications tab on a listing or any functionality
Create a user in my jurisdiction

Per clients, frontend should display "Jurisdictional Admin - No PII"

this lgtm!!!!


data: JonVojtush

Added initial data file for JonVojtush (me)
Added testimonials for me from LinkedIn (x2)
Moved data file for tanitoluwam.json as it appears to be in the wrong directory

Good spot and great collaboration. I have moved the profile that is in the root of the project here https://github.com/EddieHubCommunity/LinkFree/pull/5573
Please have your PR focused on only your profile changes.

[ ] Bookmark & analyse https://linkfree.io/icons

Please resolve the conflicts in this Pull Request so that we can get this merged

Not sure if you meant to close this PR @JonVojtush ?
You can revert your changes to that other profile file with the command git checkout main -- <FILE-NAME>
But if easier feel free to create a new Pull Request


Document which settings from NuGet.config affect dotnet restore

In the docs it's mentioned that The behavior of the dotnet restore command is affected by some of the settings in the Nuget.Config file. Please consider documenting which settings exactly affect dotnet restore. Because currently I simply have to try what works and what doesn't, which isn't really productive.
For example: NuGet allows using environment variables. But this is not supported through dotnet restore (or at least, I can't seem to get it to work).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0b256dc4-c4ad-c115-f4e2-40310bc3505a
Version Independent ID: 0b993779-65a2-6092-4047-2fc2ec16170b
Content: dotnet restore command - .NET Core CLI
Content Source: docs/core/tools/dotnet-restore.md
Product: dotnet-core
GitHub Login: @mairaw
Microsoft Alias: mairaw

@nphmuller hmm, seems like I stumbled to the same error? ;)

@nphmuller @IsmailHassani Hi, I'm going to start taking a look at this.

Details on what is going on:
dotnet restore is extremely similar to:
dotnet msbuild /t:restore
(this runs with net core’s msbuild)
msbuild /t:restore
(runs with net framework’s msbuild)
Restore Target and Task are implemented in nuget.build.tasks.dll:
https://github.com/NuGet/NuGet.Client/tree/dev/src/NuGet.Core/NuGet.Build.Tasks
Some other docs:
Nuget.config details:
https://docs.microsoft.com/nuget/consume-packages/configuring-nuget-behavior
Details on some other settings:
https://docs.microsoft.com/nuget/consume-packages/managing-the-global-packages-and-cache-folders
The NuGet.config docs have sections.
The sections that are not applicable are:

bindingRedirects
solution
trustedSigners

The bindingRedirects section does not apply to PackageReference, in both dotnet.exe and nuget.exe. dotnet.exe supports only PackageReference.
The solution section is legacy and Visual Studio specific.
The trustedSigners is not applicable because we don’t have support for cross platform verification, so that will be added later.  https://github.com/NuGet/Home/issues/7606


Fix accessing team stats when private access is granted.

The original implementation looks like it's using the org name
instead of the org login name to access collaborator stats.
This breaks if these two strings aren't identical.
The attached change fixed the behaviour for me, not sure if there's a better location (or if there are other locations that might break similarly).
Issue #, if available:
#111
Please confirm that your contribution is made under the terms of the Apache 2.0 license:
Confirming.

Agreed. Pending me applying and running a test.


[doc]Update contact.js with link to stack overflow

Motivation
We are getting a lot of great questions to the slack channel, which will be lost in the future because of the 10k limit of slack.  This puts a link to our stack overflow URL in the hopes that more questions will go there.  a
Modifications
Added a header and a sentence with the link.
Verifying this change

[ ] Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[ ] no-need-doc
(Please explain why)

[ ] doc
(If this PR contains doc changes)

this fixes the issues that were mentioned in PR #11987

@aarondonwilliams Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


Unable to use BaSiCPy with static images

Hello @yfukai,
I am running into an issue when attempting to use the new main branch (BaSiCPy) using static images like I had done previously with the old version (PyBaSiC) (see #81 for example of PyBaSiC usage with static images).
I have run into this error:
ValueError: Images must be 3 or 4-dimensional array, with dimension of (T,Y,X) or (T,Z,Y,X).

When I read in one static image, and convert to numpy, I get a 2D shape.
image_path = "../0.download_data/70117_20230118MM1_Ab Test_V2__2023-01-25T16_44_54-Measurement1/Images/r01c03f01p01-ch1sk1fk1fl1.tiff"

example_image = skimage.io.imread(image_path)
example_image = np.asarray(example_image)
example_image.shape

(2160, 2160)

Since the images are static and do not have a time component, I am unable to use this package now. PyBaSiC used to be able to intake a list of 2D arrays and did amazing with the static images, so I would really like to use the updated BaSiCPy for my future projects.
Is there anything on my end I can do to be able to use BaSiCPy with my static images? Am I missing a step or function?
Thank you in advance for your help!

Hi, thanks @jenna-tomkinson for your interest! The thing is simply that the current package expects the image to be with the dimension  (T,Y,X) or (T,Z,Y,X). This is because I haven't recognized the use case where the user supplies the single-shot image.
Does it make sense to supply the image as np.array([example_image])? We might consider an automatic conversion from a 2D image into this form, but considering the 3D compatibility, I believe this is the simple solution.

Hi @jenna-tomkinson, did it work?

Thanks @jenna-tomkinson, no worry, I was just wondering. I'm almost sure it'll work. Let me close the issue but please feel free to reopen.


Update button guidance - for not being full width on smaller screens

What
Update the guidance to include rationale for why the buttons don't go full width on smaller screens.
Why
A few users have asked why and are interested in the logic behind it.
Further details
Community backlog issue
Tasks

[ ] Draft guidance
[ ] Content review
[ ] Release

@davidhunter08 is the plan still to override the default widths at mobile?

Hi @jonhurrell there are no plans to change the width of Buttons on mobile. This issue was to add guidance as to why we do not use full width buttons on mobile.

Have left a similar post over on https://github.com/nhsuk/nhsuk-service-manual-community-backlog/issues/7#issuecomment-1592862857 but to summarise it:
On 111 online we prefer full width buttons:

For consistency with nhs login and our old codebase
Because it looks neater (just an aesthetic opinion)

But we would yield if there was actual evidence that left aligned was better. Ideally not just opinions and anecdotes, but actual evidence. If we collectively decide there's already enough evidence, and it ends up as guidance, we would probably step in line and stop using full width buttons.


Update 🇩🇪 German/Deutsch translation in KodaDot

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[ ] Bugfix
[x] Feature
[ ] Refactoring

What's new?

[ ] PR closes #<issue_number>
[ ] Requires deployment <rubick/magick_issue>
[ ] <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

[ ] My contribution builds clean without any errors or warnings
[ ] I've merged recent default branch -- main and I've no conflicts
[ ] I've tried to respect high code quality standards
[ ] I've didn't break any original functionality
[ ] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

Can you guys enable the german flag on netlify so i can check if everything is in order? @yangwao

https://open.spotify.com/track/5RYLa5P4qweEAKq5U1gdcK?si=2c787f747abf4f8b

😄
Frank can then check german translations

Can you guys enable the german flag on netlify so i can check if everything is in order? @yangwao

plus, I've merged the upstream branch so pull new stuff :)
At least I've learned to break gh pr checkout in 2 minutes and learned new trick if gh pr checkout is rejected
gh pr checkout 3918 -b 3918-2
deploy should be up in 5 mins I bet

@spacesmutje just a limit set for first time contributors :) should be good now

tbh not sure what's the problem here now, seems that netlify can't build this one?

@petersopko yes, something is going wrong with lint. no idea what it is though.

@petersopko yes, something is going wrong with lint. no idea what it is though.

there were some invalid jsons files (missing commas and stuff), seems to be working now but netlify didn't update the deploy 👀 anyways, can we get some more german native eyes on this one? Cannot verify the quality of the translation.

Will ping Frank again. And look for an additional reviewer

@yangwao can you please check the deploy here / what can be done 😄 I don't see why isn't it redeploying again

At least for now I only see green checkmarks, already a few steps further than this morning :)

@spacesmutje the app is now deployed, please click through it and make sure there aren't any leftovers, here's some examples I found:

I'm wondering whether these things are contained in the translation folder, I think @prachi00 was working on this, right? Do we have all the string captured?

@yangwao can you please check the deploy here / what can be done 😄 I don't see why isn't it redeploying again

you can inspect deploy logs yourself and seems it's deployed well.
https://app.netlify.com/sites/koda-nuxt/deploys/63205cd8e765b10008c9fae7
Seems at 12:35 when you merged main
PR#3918: Update-de.json@bbc8bce
https://github.com/kodadot/nft-gallery/pull/3918/commits/bbc8bceb515ed69183d7dc09b7c53a3072dc607c

Will this stay in English, or is it some mistake?

Seems this one issues did not covered landing

#3805

Seems this one issues did not covered landing

it was just faulty json, it's there now:

you can inspect deploy logs yourself

I know, it was just failed deploy and the new one wasn't showing up until recently :)

Footer is not scaling correctly. German is a language of long words. Might consider to scale the font. Same goes for the search tab, but i think i already saw an open issue.

Also it appears as if the About page is not included/attached to the en.json / de.json? I could not find it in there.
Anyhow, when clicking on it you end up here:

I'am going through it as we speak.

@petersopko i left the classic, simple and creative mint in english on purpose, since Klassisch, Einfach and Kreativmint sounds weird for me. Our audience is most likely used to these terms. But of course I can translate them as well. Just let me know, i will be done with everything in the evening.

I looked through the whole de.json, but can't find the lines of code for the underlined words.

@FrankBevr can you please check ?

Hola everyone,
I got 15 things, which catched my eyes on the deployed Website.
No1
No2
No3
No4
No5
No6
No7
No8
No9
No10
No11
No12
No13
No14
No15
I didnt looked thruh the json file because its soooo long. But if its urgent I will read thruh it immeditly.^^
cheers 🖖

@FrankBevr Thank you for your feedback. I changed creative minting to Kreatives Minting. For the others, it seems that i did something wrong at my last commit, so now it should be up to date.
Since i mentioned earlier that some parts are not showing up in the locales/lang files, i can't translate it 😄


Why Substring cannot make a reference to the original data instead of a copy?

https://github.com/microsoft/referencesource/blob/dae14279dd0672adead5de00ac8f117dcf74c184/mscorlib/system/string.cs#L1302
Why can't Substring just have a reference to the original unmanaged memory? Is there something with GC that would prevent a string referencing another string?

This repo is not very active, so it's not a great place to ask questions like this. A better choice would be the repo for the modern .Net runtime: dotnet/runtime.
That being said, what you're saying would require changing the structure of the string type, which is a pretty fundamental part of the runtime. Instead, .Net decided to add the Span<T> type, which can represent any memory sequence, which means the equivalent operation to Substring, called Slice, works exactly the way you want there.


Adding Mitochondrial Data in Variant-Type Tab

When a variant is mitochondrial , do not return the current predictors tables in the variant-type tab, but instead produce a table with the following predictors:
APOGEE (for protein-coding variants)
* Specifically the APOGEE1 score (discussed on 7/19/23 call - CP)
HmtVar (for tRNA variants) --- https://www.hmtvar.uniba.it/
MitoTIP  (for tRNA variants)

Sample data table here from 7/19/23 call: https://docs.google.com/spreadsheets/d/1IZoDWRYrWxkT-RuKBycwzKmKR7-kPSGfAHoZaoi7Jr0/edit#gid=0


Help I cannot make this work

Hi,
I'm new to the world of Azure Service Bus.
Im struggling with the setup, your instruction state
"azure-sb://owner:bjOAWQJalkmd9LKas0lsdklkdw4mAHwKZUJ1jKwTLdc=@myNamespace/my-application"
but the connection string I get is
"Endpoint=sb://myqueue.servicebus.windows.net/;SharedAccessKeyName=mysharedkeyname;SharedAccessKey=mysharedkey"
I cannot match up any of the requirements from your connection string to the connection string supplied by azure.
Is there a code sample some where maybe?

This code is quite old and doesn't support shared access. However, modern MassTransit I believe has native support for Azure.


Max value of chart

Hello there, I'm using Microchart for Xamarin.Forms. Great tool so far! However, I found an interesting bug:

According to the tutorial, the max value will become the value of the chart with the highest value. In my case, the max value of the chart is that divided by 2. If I increase the 'MaxValue' property to 400, it still does not give me the desired max value.
Is this a known bug? Am I doing something wrong in my code? Please let me know. I'm using 0.8.1-pre.

Could you provide your chart initialization code? Not sure to understand your case...
If you define chart.MaxValue = 400, then your February column should be filled. Now if you define chart.MaxValue = 800, then your February  column should be half filled (like on your screenshot) and so on.

Even if I put the MaxValue to 400, still no result. This is the code I was using:
return new BarChart
{
    Entries = new List<Entry>
     {
         new Entry(200)
         {
            Label = "January",
            ValueLabel = "200",
            Color = SKColor.Parse("#266489")
         },
         new Entry(400)
         {
             Label = "February",
             ValueLabel = "400",
             Color = SKColor.Parse("#68B9C0")
         },
         new Entry(100)
         {
             Label = "March",
             ValueLabel = "-100",
             Color = SKColor.Parse("#90D585")
         }
     },
     LabelTextSize = 30,
     BarAreaAlpha = 255,
     MaxValue = 400
 };

Okay, spotted the error.
I apologize, I'll publish an update very soon. :(

Okay, I found out what the problem was. The animation was not working properly. For a temporary fix, try this:
BarChart barChart = new BarChart{ IsAnimated = false };

Sad that you can't use animation.
I just published a new pre-release which include a fix related to MaxValue.
Is it better now?

I installed the new pre-release and the problem is still there. I figured that the animation cannot play. When loading is done, it shows only the current frame as following:

Do I need to enable something in my project in order to make the animation play?

Some news about the maxVlaue? i'm trying to use it with Donut, to show something like:
maxValue = 100%, achieved= 80%, so the graphic fill just 80% of the donut.

Hum, the use of RadialGaugeChart is more appropriate in this case for me.
Setting a max value to a donut doesn't make sense to me, imagine your have 2 portions with 60 and 50and a max value of 100 ? Do we have to cut the last portion ?

that's right, I was trying to use the wrong chart. and if I need to use in Donut form, I just need to use two portions one with the rest of the other, (100% = 1 portion of 80 and other of 20) this will made the chart I need. Thanks!
And a tip: Microcharts is awesome, but maybe it need more documentation, like what attributes and functions each chart have and so on... (if there is a documentation for that, I apologize, because I didn't find)

Also, there is a Way to show in the chart the MaxValue as a Label or something?

Closing due to inactivity and apparent resolution. @CalvinNunes if you wish to know about the maxValue label as an option, please start a new issue.


Missing CFBundleVersion when using Xcode generate info plist

Issue description
When using GENERATE_INFOPLIST_FILE in Xcode the CFBundleVersion is automatically removed from the Info.plist.
PlistBuddy fails to print current CFBundleVersion.
Bitrise info

+------------------------------------------------------------------------------+
| (4) set-xcode-build-number@1                                                 |
+------------------------------------------------------------------------------+
| id: set-xcode-build-number                                                   |
| version: 1.0.11                                                              |
| collection: https://github.com/bitrise-io/bitrise-steplib.git                |
| toolkit: bash                                                                |
| time: 2022-06-03T15:18:40Z                                                   |
+------------------------------------------------------------------------------+
|                                                                              |
INFO[15:18:40]  * [OK] Step dependency (xcode) installed, available.
(i) Provided Info.plist path: ./xxx/Resources/Info.plist
(i) Build number: 762
---- Current Bundle Version:
/usr/libexec/PlistBuddy -c "Print CFBundleVersion" "${CONFIG_project_info_plist_path}"
Print: Entry, "CFBundleVersion", Does Not Exist
|                                                                              |
+---+---------------------------------------------------------------+----------+
| x | set-xcode-build-number@1 (exit code: 1)                       | 1.81 sec |
+---+---------------------------------------------------------------+----------+
| Issue tracker: https://github.com/bitrise-io/set-xcode-build-number/issues   |
| Source: https://github.com/bitrise-io/set-xcode-build-number                 |
+---+---------------------------------------------------------------+----------+

still an issue

Still a problem.

Still an issue

Still an Issue.
Here is an alternate solution that has worked for us:
https://discuss.bitrise.io/t/set-xcode-build-number-not-works-xcode-13-project/19138/4
More info on agvtool tool here:
https://developer.apple.com/library/archive/qa/qa1827/_index.html

Hi @viktorbenei @ofalvai
We have the same issue, the problem is actual for both Xcode 13 and 14 projects.
Are you planning on any solution?

not tested lately. but still as issue far as I’m concerned