Possibility to show all errors

Added the possibility to bind the property showAllErrors to show all errors

Anything happening on this front?

@spruce I doubt the repo owner will merge this since you've changed homepage + authors on the package file.

@asaf what should I do to get this merged?


Bug in pagination for first page

check first page html tag,
1

so it was rendered wrong, because href should be ?page=1 right?

I've seen a few problems with pagination, definitely something we need to fix

I'll try to fix it soon.

I think it got fixed in https://github.com/pydantic/FastUI/commit/e1203d6b95af18163531ae79b8700fda0c5d37f6

I think it got fixed in e1203d6

I'm using CDN, not sure if it's there yet.
https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>

Yes tested and it's working fine. thx :)


Installing and usage instructions on TrueNAS

Hi,
As the title explains, this app is listed on the app catalog on TrueChats, but there is no documentation related to this on the README project.
TrueCharts link
It wold be great to have a nice support on the main page for that platform.
Kind regards

As Kubernetes is going away on 01.07.2024 I don't think it's wise to spend any time on this.
Just set up jailmaker docker and run this with docker compose. I use it like that and it works well.


[Request] a raml icon

Hi would be nice to have a raml icon.
Their official logo would be hard to make into an icon though...so not sure how this can be done.
But hey, i'm no designer! :smile:

Is this the RAML you're talking about?
If so, that looks incredibly easy... which is why I'm wondering if I've got the wrong "RAML" (which I've never heard of until today).


Fix most of the release_tests

Fixes everything except the MIDI test.
MIDI is not broken - however, it uses a Mixer which breaks other animations that are in it, and I want to resolve that.

+1
On Mon, Aug 27, 2018 at 4:11 PM Tom Swirly<EMAIL_ADDRESS>wrote:

Fixes everything except the MIDI test.
MIDI is not broken - however, it uses a Mixer which breaks other
animations that are in it, and I want to resolve that.
You can view, comment on, or merge this pull request online at:
https://github.com/ManiacalLabs/BiblioPixel/pull/943
Commit Summary

Fix most of the release_tests

File Changes

M bibliopixel/control/rest/rest.py
https://github.com/ManiacalLabs/BiblioPixel/pull/943/files#diff-0
(4)
M scripts/release_test/arguments.py
https://github.com/ManiacalLabs/BiblioPixel/pull/943/files#diff-1
(2)
M scripts/release_test/projects/all_pixel.yml
https://github.com/ManiacalLabs/BiblioPixel/pull/943/files#diff-2
(4)
M scripts/release_test/release_test
https://github.com/ManiacalLabs/BiblioPixel/pull/943/files#diff-3
(10)
M scripts/release_test/tests/remote.py
https://github.com/ManiacalLabs/BiblioPixel/pull/943/files#diff-4
(6)
M scripts/release_test/tests/rest.py
https://github.com/ManiacalLabs/BiblioPixel/pull/943/files#diff-5
(5)

Patch Links:

https://github.com/ManiacalLabs/BiblioPixel/pull/943.patch
https://github.com/ManiacalLabs/BiblioPixel/pull/943.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/pull/943, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6qdJaPMFpDb33dUWmbK7J64X5_Lkks5uVFJVgaJpZM4WObFY
.


WIP: Bugfix and refactor

Lots of stuff:

Added some additional logging.
Removed base.py altogether; this required a bit of refactoring.
Minor improvements to docstrings, including PEP-257.
As a rule, moved lint-hints out to column 81 to distinguish them from comments.
Removed superfluous code, such as the if conditional:

 if response.status_code != requests.codes.ok:
    requests.raise_for_status()

Minor improvements to code (e.g. A=B=None, instead of A=None, and B=None).
Removed unneeded wrappers, e.g.: self.client._convert(response.text) becomes response.json().
Fix dodgy super()s.
Fixes a potential bug, (e.g. access_token == ''):

if self.access_token is None or self.access_token_expires is None:
    self._basic_login()

becomes
if not self.access_token or not self.access_token_expires:
    self._basic_login()

BTW, not (self.access_token and self.access_token_expires) is more concise, but the above reads better.

I think a few more things are needed:

I think there is a bug when > location per account
Refactoring due to removal of base.py isn't necessarily  complete.
Something I forget

After commit 0a034db:
(hass) dbonnes@vm-builder:~/evohome-client/evohomeclient2$ pylint *.py --disable=C0301
************* Module evohomeclient2.controlsystem
controlsystem.py:21:2: W0511: TODO: is systemId set via self.__dict__.update(local_data)? (fixme)
controlsystem.py:10:0: R0902: Too many instance attributes (8/7) (too-many-instance-attributes)
************* Module evohomeclient2
__init__.py:39:4: R0913: Too many arguments (7/5) (too-many-arguments)

------------------------------------------------------------------
Your code has been rated at 9.91/10 (previous run: 9.89/10, +0.03)

Argh! client.locations[0]._gateways[0]._control_systems[0].zones has two copies of every zone!
And I can't work out why!

So the good news is that chasing this bug required me to make extensive use of refresh_tokens and access_tokens on my HomeAssistant component - they performed flawlessly.


How to test mypy plugin?

There are project like pytest-mypy-plugins but they are quite hard to configure in axion environment which requires a plugin to read OAS specifications. Right now entire plugin as introduced via #218 is excluded out of coverage and that's not OK. We ought to have something to measure coverage. Unit testings seems to be out of option due to vast amount of functionality mypy provides like rendering type info.

Currently several of PRs ( #273 #274 #272 #246 ) are using pytest-mypy-plugins with a god amount of success therefore this PR can be considered closed.


luarocks(1) unable to find fbtorch

$ luarocks install fbtorch

Error: No results matching query were found.

Or via LuaRocks site search

my current solution is uploading the rockfile manually and running the following command:
luarocks install --server=http://luarocks.org/manifests/pyk fbtorch

luarocks install --server=http://luarocks.org/manifests/pyk fbtorch
Installing http://luarocks.org/manifests/pyk/fbtorch-scm-1.rockspec...
Using http://luarocks.org/manifests/pyk/fbtorch-scm-1.rockspec... switching to 'build' mode
Cloning into 'fbtorch'...
remote: Counting objects: 17, done.
remote: Compressing objects: 100% (14/14), done.
remote: Total 17 (delta 2), reused 12 (delta 2), pack-reused 0
Receiving objects: 100% (17/17), 7.15 KiB | 0 bytes/s, done.
Resolving deltas: 100% (2/2), done.
git submodule init
git submodule update
cmake -E make_directory build && cd build && cmake .. -DCMAKE_BUILD_TYPE=Release -DCMAKE_PREFIX_PATH="/Users/yike.ke/torch/install/bin/.." -DCMAKE_INSTALL_PREFIX="/Users/yike.ke/torch/install/lib/luarocks/rocks/fbtorch/scm-1"
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
-- The C compiler identification is AppleClang <IP_ADDRESS>20038
-- The CXX compiler identification is AppleClang <IP_ADDRESS>20038
-- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc
-- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- FBCUNN Untested/Unsupported on OSX
-- Found Torch7 in /Users/yike.ke/torch/install
CMake Error at /Library/Python/2.7/site-packages/cmake/data/CMake.app/Contents/share/cmake-3.7/Modules/FindPackageHandleStandardArgs.cmake:138 (message):
REQUIRED_ARGS (missing: FOLLY_INCLUDE_DIR FOLLY_LIBRARIES)
Call Stack (most recent call first):
/Library/Python/2.7/site-packages/cmake/data/CMake.app/Contents/share/cmake-3.7/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
cmake/FindFolly.cmake:23 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
CMakeLists.txt:12 (FIND_PACKAGE)
-- Configuring incomplete, errors occurred!
See also "/tmp/luarocks_fbtorch-scm-1-3933/fbtorch/build/CMakeFiles/CMakeOutput.log".
Error: Build error: Failed building.
ali-186590cc37a5:byteNet-tensorflow yike.ke$

same error.

@loveJasmine @guotong1988 you can use this:
luarocks install https://raw.githubusercontent.com/facebook/fbtorch/master/rocks/fbtorch-scm-1.rockspec

@pyk
use luarocks install https://raw.githubusercontent.com/facebook/fbtorch/master/rocks/fbtorch-scm-1.rockspec
still same error


Event Request Codeunit 10120 Bank Rec.-Post :- PostAdjustmentToGL

Event - OnBeforeModifyCurrencyFactor(),OnAftermodifyCurrencyFactor()

New Code Start
OnBeforeModifyCurrencyFactor (Var BankRecLine2: Record "Bank Rec. Line";Var GenJnlLine : Record Gen. journal line;Var IsHandled: Boolean)
<<New Code End

IF NOT IsHandled THEN >>New Code
GenJnlLine."Currency Factor" := "Currency Factor";

New Code Start
OnAftermodifyCurrencyFactor(Var BankRecLine2 : Record "Bank Rec. Line"; Var GenJnlLine : Record Gen. journal line;Var IsHandled: Boolean)
<<New Code End

Please explain what you are going to do with this event? Events should not alter application behavior if not used, but you want to assign Currency Factor is IsHandled = FALSE? This is wrong pattern. Second evewnt does not make sense with Handled pattern.

Hello,
This is customization made by one the customer, Where the "Currency Factor"is calculating with some other value(as not the actual code below), So now moving to BC we need an event to update that part with customized value
GenJnlLine."Currency Factor" := "Currency Factor";

Yes, The second event is not required.

We are migrating one of the customer DB from 2009 to BC On Prem.

Sorry, this is not an intended way of using events. We do not provide events for individual customers.


Add config for updating max amount of table head layers

adds a config option for adjusting the max amount of table head rows

Demo
~https://user-images.githubusercontent.com/43496356/191370315-9c752b6c-72a7-4610-ae98-89d3b218ddc7.mov~
https://user-images.githubusercontent.com/43496356/191622478-caef0362-e0c0-4110-a24c-34b9bd48a953.mov
Part of #2390

Can we update the max amount of table head layers without closing and reopening the extension?
Again. It feels very much like hiding table columns, which are controlled in the sidebar. Do you see this suggestion as an option in the future?


Parser: refactor and fix parser for unless inside macro

Fixed #9165
Fixed #9166
This PR introduces a new method parse_unless_after_condition like parse_if_after_condition. It is used for parsing {% unless ~ end %}.
And, this PR fixes to disallow elsif branch in {% unless ~ %} ... {% end %}.
Thank you.

Would like a review from @bcardiff or @asterite.

@bcardiff @asterite Please review this.

Sorry, no time this days, but if others review and approve it's fine by me. I know the type grammar parsing is a mess, and I trust you :-)

I trust the parser specs well enough.

Maybe the above @asterite's comment is for #9208 ...?


chore: remove style-loader

we don't seem to use it...

:tada: This PR is included in version 2.153.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add plugin support

Add plugin architecture support for taiko. Taiko should be extensible and plugins should be able to extend taiko's functionality.
More information in https://github.com/getgauge-contrib/taiko-diagnostics/issues/1

This has verified and tested with the version a5565a5


by-class, continuous feature hist in analysis.exploratory

e.g.
fig = plt.figure(figsize=(11, 8))
ax = fig.add_subplot(111)
ax = eda_df[eda_df.class == 1].feature.hist(
                                        ax=ax, bins=100, color="orange", alpha=.5)
ax = eda_df[eda_df.class == 0].feature.hist(
                                        ax=ax, bins=100, color="blue", alpha=.5)
l = ax.set_ylabel("count")
l = ax.set_xlabel("feature")
t = ax.set_title("hist: feature, by class (orange=1, blue=0)")

This is now available here.


Selected and Unselected Totals are not updating

When checking items in the list for potential matching gifts, the total selected and unselected amounts are not updating.

**lurch: add

Tracking W-011389

Included in beta release 3.83 (Beta 9)

Included in production release rel/3.83


This is a combination of 7 commits.

Side nav drawer improvements; split component from MainLayout component; improved animation integrity; nav link active status classes
Side nav auto-close behavior; custom breakpoint hook
Disable open-drawer button on breakpoint
Disable open-drawer button on breakpoint
Remove dated import
Tiny alignment change for close-drawer button
chore: format files from GitHub Action

Description

Fixes # (issue)
Type of change

[ ]  🐛 Bug fix (non-breaking change which fixes an issue)
[ ] ✨  New feature (non-breaking change which adds functionality)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] 📝 Documentation update
[ ] Other 🗒 ______________

How Has This Been Tested?

[ ] Test A
[ ] Test B

Checklist:

[ ] I have performed a self-review of my own code.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] Any dependent changes have been merged and published in downstream modules.
[ ] I have reviewed the Security Best Practices Document.
[ ] I have followed the Naming Conventions Guide for my changes.
[ ] I have ensured that my pull request title is descriptive.

Additional Information:

LGTM


Convert mouse pointer on hover Issue #94

Fixed issue #94 Convert mouse pointer on hover:
Added css for archive-requests.html and license-requests.html files inside base.html
Fixed the issue with the Archive/unarchive button by adding type='button' inside <input> tag.

@ithompson4 I suggested some changes above. I just noticed that we have style tag in many different html files in app. If you can move the <style> tag from all these html files to the base.html

@ithompson4 You can also combine the style tag from xml_upload and license_information to base.html.  I just checked that license_information uses specific ids to modify style.Can you generalise the style by adding a separate class for that? If we can use simple bootstrap tags instead of fixing the margin and font to some pixels, that would be great. Also, squash your commits into single one.

@techytushar, I will squash my commits.
@rtgdk, I will do it. Could it be better to create a new pull request for updates to the xml_upload and license_information files to keep better track of their changes?
Thanks.

@ithompson4 Cool, create a new PR for that.

OK. Once you merge my commit I get the latest updates and continue working on it. Thanks.

@ithompson4  you can work on the master branch. I will merge this with the new PR you will create and then merge the new pr with the master.

@ithompson4 Changes looks good. Thanks! Merging.


upd: preview <IP_ADDRESS>

Items

[ ] Released the minecraft:shooter, minecraft:throwable, minecraft:projectile, minecraft:can_destroy_in_creative, minecraft:hover_text_color item component out of experimental in json formats 1.20.10 and higher
[x] Deprecate minecraft:render_offsets item component in json formats 1.20.10 and higher

Script module

[x] Bump @minecraft/server to 1.3.0 stable ( gametest-upd branch not merged )

@NguyenDuck was this PR finished? Please mark your tasks as completed if so.

I merged this into up so I could work off of the progress for the items. It was not finished.

I'll add the released item components today.


Error: Dictionary changed size during iteration

Describe the bug
I’ve encountered this error twice so far in two days, coincidentally(?) since I upgraded to 0.14.1, and saw it on dbt Cloud. The error is:
Completed with 1 error and 0 warnings: dictionary changed size during iteration
In both cases this happened when doing dbt test --models source:*
(Reference: runs #1683050 and #1678913 in dbt Cloud)
Screenshots and log output
Backtrace:
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/dbt/node_runners.py", line 196, in safe_run
result = self.compile_and_execute(manifest, ctx)
File "/usr/local/lib/python3.6/dist-packages/dbt/node_runners.py", line 134, in compile_and_execute
ctx.node = self.compile(manifest)
File "/usr/local/lib/python3.6/dist-packages/dbt/node_runners.py", line 300, in compile
return compile_node(self.adapter, self.config, self.node, manifest, {})
File "/usr/local/lib/python3.6/dist-packages/dbt/compilation.py", line 221, in compile_node
node = compiler.compile_node(node, manifest, extra_context)
File "/usr/local/lib/python3.6/dist-packages/dbt/compilation.py", line 118, in compile_node
compiled_node, self.config, manifest)
File "/usr/local/lib/python3.6/dist-packages/dbt/context/runtime.py", line 150, in generate
model, runtime_config, manifest, None, Provider())
File "/usr/local/lib/python3.6/dist-packages/dbt/context/common.py", line 496, in generate
return generate_model(model, config, manifest, source_config, provider)
File "/usr/local/lib/python3.6/dist-packages/dbt/context/common.py", line 471, in generate_model
source_config, provider)
File "/usr/local/lib/python3.6/dist-packages/dbt/context/common.py", line 408, in generate_base
"graph": manifest.to_flat_graph(),
File "/usr/local/lib/python3.6/dist-packages/dbt/contracts/graph/manifest.py", line 235, in to_flat_graph
k: v.serialize() for k, v in self.nodes.items()
File "/usr/local/lib/python3.6/dist-packages/dbt/contracts/graph/manifest.py", line 235, in
k: v.serialize() for k, v in self.nodes.items()
File "/usr/local/lib/python3.6/dist-packages/dbt/api/object.py", line 63, in serialize
return copy.deepcopy(self._contents)
File "/usr/lib/python3.6/copy.py", line 150, in deepcopy
y = copier(x, memo)
File "/usr/lib/python3.6/copy.py", line 239, in _deepcopy_dict
for key, value in x.items():
RuntimeError: dictionary changed size during iteration
System information
Which database are you using dbt with?

[ ] postgres
[ ] redshift
[ ] bigquery
[x] snowflake
[ ] other (specify: ____________)

The output of dbt --version:
installed version: 0.14.1
   latest version: 0.14.1

The operating system you're using:
The error occured on dbt Cloud
The output of python --version:
Additional context
Add any other context about the problem here.

Thanks @MartinGuindon!
@beckjake have you seen something like this before? Looks like there's some concurrent mutation of the manifest that happens during a dbt test (and probably other types of invocations too)

Ugh, to_flat_graph again. I'm pretty confident that if we changed the node runners to explicitly initialize the flat graph instead of trying to lazy-load it this would go away, because we'd never be doing a deepcopy while a node is updating information about itself - I assume that's the problem.

ah - so we could fix that by removing
"graph": manifest.to_flat_graph(),

from the context? We should do that as soon as we're able to provide a more sane alternative.
I recall that we memoized the to_flat_graph() response in 0.14.1 -- is it surprising that @MartinGuindon is still seeing this on 0.14.1? Does this mean that two threads are calling into to_flat_graph() at the same time before the flat_graph is cached?

RE: removing it, I'd love to but it's something people actually use.

Does this mean that two threads are calling into to_flat_graph() at the same time before the flat_graph is cached?

Yeah, so we should just build it in before_run or somewhere similar. Anywhere that happens before we start run would be fine, if you have more than zero nodes selected you'll need to call it anyway.

@drewbanin To my knowledge, I've actually never encountered that isssue before upgrading to 0.14.1. Alsp I've had quite a few occurrences in the last 2 days.
Runs #1698615, #1696637, #1696312, #1693258, #1692100, #1691359, #1687687, #1687106,  #1686503... and maybe more, I stopped looking after page 2.

Thanks for that additional info @MartinGuindon - I've tentatively prioritized this for our Louisa May Alcott (0.15.0) release, but we might try to slip this in earlier too. Will follow up here with more info as we have it!

This was fixed in https://github.com/fishtown-analytics/dbt/pull/1750
We're going to cut an 0.14.3 release which includes this fix next week!


Latest code is failing for me

When I back out the latest changes it works fine. but with the latest change it fails with the following error:
File "/usr/local/lib/python2.7/dist-packages/SpeechRecognition-1.2.3-py2.7.egg/speech_recognition/init.py", line 137, in samples_to_flac
with wave.open(wav_file, "wb") as wav_writer:
AttributeError: Wave_write instance has no attribute 'exit'

Same here. OSX

Looks like the latest version broke Python 2 compatibility somehow, I'll look into it.

Fixed in ac9cd56c0b167bc36614872f8ef6ebbc07e0a804!


Agrego cambios que hicimos con los chicos (Pair Programming)

Codecov Report

Merging #8 (4f51f71) into master (34df96c) will increase coverage by 21.73%.
The diff coverage is 94.73%.

@@              Coverage Diff              @@
##             master       #8       +/-   ##
=============================================
+ Coverage     39.28%   61.01%   +21.73%
- Complexity       13       18        +5
=============================================
  Files            12       12
  Lines            56       59        +3
  Branches          0        1        +1
=============================================
+ Hits             22       36       +14
+ Misses           33       23       -10
+ Partials          1        0        -1

Impacted Files
Coverage Δ

src/main/java/edu/fiuba/algo3/modelo/Batalla.java
0.00% <0.00%> (ø)

src/main/java/edu/fiuba/algo3/modelo/Jugador.java
100.00% <100.00%> (+40.00%)
:arrow_up:

...iuba/algo3/modelo/JugadorNoPoseePaisException.java
100.00% <100.00%> (ø)

src/main/java/edu/fiuba/algo3/modelo/Pais.java
100.00% <100.00%> (+23.07%)
:arrow_up:

src/main/java/edu/fiuba/algo3/modelo/Tablero.java
100.00% <100.00%> (+100.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34df96c...4f51f71. Read the comment docs.


add const to mtype.d functions

trivial

Header file?

If there were any issues, it wouldn't link. It links. :-)

It links because all of these methods are virtual.  The C++ header still needs updating.

So far, the DDMD frontend migration has been pretty painless for us

The real fun starts after 2.069.

(@yebblies: Your auto-generation thingamajig certainly is a good step towards avoiding such issues. Not sure whether it is something to go into the compiler, though. I'd expect it to be an external tool.)

An external tool has one critical downside - it won't automatically be available on the autotester.
It also only solves one of the problems.  Walter has already removed a bunch of the C++ interface, and we won't know if it's too much until you guys get to that merge.  Are there any more LDC patches that are ready to upstream?

Ping @WalterBright

added const to mtype.h

Auto-merge toggled on


chore: Move template article out of content path

Maybe there is a better location, but because it's under the content path, it's currently live https://docs.microsoft.com/en-ca/windows/iot-core/poc
Also cause a build warning because of the metadata

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

template.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Single Downloading Notification for Grouped Downloads

@Husnainali02 what is the full question?
Reference the DefaultNotificationManager class java docs on more information on how to handle single group notifications for downloads.


Sidebar icons disappear on startup

the sidebar icons disappear on application launch for:

Project
Restore
Database Navigator
Projects

when mouse hover them, they appear again

This is a glitch in the recent Eclipse platform (4.6.2). I can't fix this but most likely this will be fixed in the next minor Eclipse platform update. DBeaver will has this fix once this will happen.


ci(travis): add build stages

Notable Changes
Add build stages to Travis CI to test multipe enviroments (OS + node)
Commit Message Summary (CHANGELOG)

None

Type

[x] CI

SemVer

[x] Fix (:label: Patch)

Issues

None

Checklist

[x] Lint and unit tests pass with my changes
[x] I have added tests that prove my fix is effective/works
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes are merged and published in downstream modules

Coverage remained the same at 97.26% when pulling fae70afddc3b2b628a107760d5db030d9c1f5346 on ci into 003c3d9028ac731fe3ed6c92eec05a91d7994647 on master.

Coverage remained the same at 97.26% when pulling fae70afddc3b2b628a107760d5db030d9c1f5346 on ci into 003c3d9028ac731fe3ed6c92eec05a91d7994647 on master.


how to set array into elasticsearch

I user this plugin to sync mysql to elasticsearch,but I have some problems。
For example：my field is topics。
mysql format： topics:["girl","beatiful"]
es: topics: "["girl","beatiful"]",this is a string。
but I want is: ["girl","beatiful"],this is a array
please,how to do it?

I apologize for the inconvenience, but this is a usage question, and should be asked at https://discuss.elastic.co.
GitHub is for coding issues and error reporting.


9.2 release

Maybe it is time to release a new version?

Will do when time is there

@sungam3r It is released and I decided to go with a minor as you suggested. Thanks for the patience!

I have already updated the package, everything works.


CircleCI job for automatic deployment and execution of Integration Suite

Automate cloud deployment from circleci.
I have created a new workflow called nightly and a job deploy which runs at the scheduled time, at present, it will run daily around 0:0:0 IST and deploy main branch on the cloud.
The integration test script now depends on env variable which comes from circleci for scheduled workflow.

This looks good, have you added the secret to CircleCI ?

Yes, I have added the variable in CircleCI


Basic Generators: Constant, Range, Reference, Composite

Only include the minimum necessary implementation needed to satisfy the assigned task to this branch. You will have tasks later on to add additional functionality.


Use of undeclared type or module nasm_rs

Trying to build rav1e in MSYS2 / MinGW using media-autobuild_suite fails:
Archived log files: logs.zip
rav1e-git/ab-suite.build.log
CFLAGS: -mthreads -mtune=generic -O2 -pipe
LDFLAGS: -pipe -static-libgcc -static-libstdc++
/opt/cargo/bin/cargo.exe build --release --target=i686-pc-windows-gnu --jobs=4
    Updating git repository `https://github.com/tdaede/nasm-rs.git`
   Compiling rav1e v0.1.0 (file:///H:/development/media-autobuild_suite-master/build/rav1e-git)
error[E0433]: failed to resolve. Use of undeclared type or module `nasm_rs`
  --> build.rs:32:9
   |
32 |         nasm_rs::compile_library_args("rav1easm", &["src/x86/mc.asm"], &[&config_include_arg, "-Isrc/"]);
   |         ^^^^^^^ Use of undeclared type or module `nasm_rs`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0433`.
error: Could not compile `rav1e`.

To learn more, run the command again with --verbose.

Thank you for reporting it, I have a fix for it, let me test it locally and I'll send it for review.

Works, thank you.


fix: Theming issue when application has multiple git branches

Description
Theming API was not considering branches. This PR fixes the issue.
Fixes #13860
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually
JUnit tests

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/ok-to-test sha=88e9e1f


Update env file from CTFd

Need to update environment variables of CTFd container to fill up rathole related creds.
Variables needed:
RAT_API1_HOST
RAT_API1_PORT
RAT_API2_HOST
RAT_API2_PORT
RAT_API_USERNAME
RAT_API_PASSWORD

Done


option: auto enable K8sRequireIPv4PodCIDR in hostscope-legacy mode

Fix: #15345
With hostscope-legacy mode IPAM and a flapping k8s apiserver, there are
possibilities that the PodCIDR the node is using will be overridden by an
auto-generated one from cilium-agent, resulting in interrupted pod traffic.
Refer to #15345 for more details.
This patch fixed the problem by auto enabling K8sRequireIPv4PodCIDR in
this mode, just like what we do in kubernetes mode and cluster-pool mode.
Signed-off-by: ArthurChiao<EMAIL_ADDRESS>

Asked for a review from @cilium/ipam folks.

test-backport-1.8

Unless I am missing something, using kubernetes IPAM mode would likely fix #15345.

Hi @aanm, you are right, using kubernetes IPAM could fix this problem.

The hostscope-legacy mode was created to not depend on kubernetes, that is why we have the kubernetes IPAM mode.

Sorry, I didn't have this knowledge before. Actually I could not clearly tell the difference between hostscope-legacy and kubernetes (I thought it's just a renaming). If I did, I will not open the issue and this PR.
Feel free to close this PR (and the issue) if you're done.

Unless I am missing something, using kubernetes IPAM mode would likely fix #15345.

Hi @aanm, you are right, using kubernetes IPAM could fix this problem.

The hostscope-legacy mode was created to not depend on kubernetes, that is why we have the kubernetes IPAM mode.

Sorry, I didn't have this knowledge before (I thought it's just a renaming). If I did, I would not open the issue and this PR.
Actually I'm still not clear about the difference between hostscope-legacy and kubernetes, as in hostscope-legacy mode, agents also retrieve PodCIDRs from k8s annotations, and fatal immediately if the retrieving failed.

@ArthurChiao that is correct, but those PodCIDRs annotations were previously set by Cilium. And the hostscope-legacy mode is either derived from the CIDR available in the k8s node or automatically generated from the local address, as you probably have seen from the described behavior in #15345

Feel free to close this PR (and the issue) if you're done.

Make sense to me. Thanks! I'm closing this. @aanm


'Using Odyssey.js' footer link should link to Odyssey.js page

Here's a test case: http://bl.ocks.org/anonymous/raw/2fa1cbb11f01d68cef8e

:+1:


where is the robotConnected flag set?

Where is the isRobotConnected Boolean supposed to be set to true?
I can't find any mention of it on the ros or jave side, only the the iiwa_stack/iiwa_ros.cpp has a commented out method that looks related.
It never seems to be set high, although in most cases do receive messages from the iiwa if I manually set it to true.

Thanks for pointing that out, I commit what should fix that.
All this exemplary repo was written quickly in one lazy evening, I honestly never thought someone would ever run this code, so I never test it myself on the robot. Probably is a good idea to do it!
I'll close this after testing

yeah I figured. They're still a great way of quickly understanding what's going on.
I've noticed quite a few extra steps to take with respect to what's in the wiki.
Some more interesting than others.
Thanks for the great work! I'll upload any and all useful code over the coming weeks to the mathworks file exchange and github.


Path resolution fix

When I went through the test in order to fix #813 I couldn't fix one test case where the path of the package was different from the NCX file.
I realized that this was a bug and I separated this cleanup into this pull request fixing the bug.

Hi @tofi86
Just to clarify this issue I want to present this piece of code.
PackageManifest manifest = epack.getManifest();
ManifestItem mi = manifest.getItem(si.getIdref());
String path = mi.getHref();
            path = PathUtil.resolveRelativeReference(epack.getPackageMainFile(), path,  null);

We get a package manifest, we get one item of this manifest, the Href of that item and lastly resolve the relative reference of that item.
To use the navDocEntry to figure out the reference will only work when the package file and the ncx file is in the same directory. This test case test exactly this and this haven't been found because the error OPF-059 is the outcome of such errors.
The directory structure in this test:
OPS/toc.ncx
OPS/toc.xhtml
content.opf

Maybe we should have a test like this as well?

toc.ncx
toc.xhtml
OPS/content.opf

Best regards
Daniel


07/01/2018 21:56 : Create Pull Request for branch master -> prTesting1_2018070121

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Why cancel this design？

i love it.but,
today,it's change.

Try changing window.titleBarStyle in settings to custom?

The custom menu will become default in the release after the next release.


replaced component_type by component_name on JSON param

replaced component_type by component_name on OVF deployment JSON parameter check

Thanks,
It is indeed a mistake I made while creating the nsx components in the zPodLibrary/vmware/nsx , most the nsx components are missing the component_type key/value.
For now this will indeed fix your issue, but I'll also fix the library soon™, so they all get that key in case we use it later on.
Also I'll see if I ever use component_type ... as right now component_name is always the same but this may change with some of the Broadcom VCF renaming scheme.


Improve diagnostic for compile-time checks

Thanks for your great work first. But the original error message is not good for compile-time checks. When I intentionally caused a shape mistake to examples/simple, the message is confusing.
error[E0277]: the trait bound `GraphTensor<(luminal::shape::Const<4>,)>: Matmul<(luminal::shape::Const<5>, luminal::shape::Const<5>)>` is not satisfied
  --> examples/simple/src/main.rs:12:27
   |
12 |     let b = model.forward(a).retrieve();
   |                   ------- ^ the trait `Matmul<(luminal::shape::Const<5>, luminal::shape::Const<5>)>` is not implemented for `GraphTensor<(luminal::shape::Const<4>,)>`, which is required by `Linear<5, 5>: luminal::module::Module<GraphTensor<_>>`
   |                   |
   |                   required by a bound introduced by this call
   |
   = help: the following other types implement trait `Matmul<S>`:
             <GraphTensor<(A,)> as Matmul<(A, B)>>
             <GraphTensor<(A, B)> as Matmul<(B, C)>>
             <GraphTensor<(A, B, C)> as Matmul<(A, C, D)>>
             <GraphTensor<(A, B, C)> as Matmul<(C, D)>>
             <GraphTensor<(A, B, C, D)> as Matmul<(A, B, D, E)>>
             <GraphTensor<(A, B, C, D, E)> as Matmul<(A, B, C, E, F)>>
   = note: required for `Linear<5, 5>` to implement `luminal::module::Module<GraphTensor<(luminal::shape::Const<4>,)>>`

Rust 1.78 has a new feature to support custom diagnostic message https://blog.rust-lang.org/2024/05/02/Rust-1.78.0.html#diagnostic-attributes. Let me have a try.
#[diagnostic::on_unimplemented(
    message = "`{Self}` and `GraphTensor<{S}>` shapes cannot be multiplied",
    label = "Input tensor {Self}",
)]
pub trait Matmul<S: Shape> {
    type Output;
    fn matmul(self, rhs: GraphTensor<S>) -> Self::Output;
}

Now the message is much more readable.
error[E0277]: `GraphTensor<(luminal::shape::Const<4>,)>` and `GraphTensor<(luminal::shape::Const<5>, luminal::shape::Const<5>)>` shapes cannot be multiplied
  --> examples/simple/src/main.rs:12:27
   |
12 |     let b = model.forward(a).retrieve();
   |                   ------- ^ Input tensor GraphTensor<(luminal::shape::Const<4>,)>
   |                   |
   |                   required by a bound introduced by this call
   |
   = help: the trait `Matmul<(luminal::shape::Const<5>, luminal::shape::Const<5>)>` is not implemented for `GraphTensor<(luminal::shape::Const<4>,)>`, which is required by `Linear<5, 5>: luminal::module::Module<GraphTensor<_>>`
   = help: the following other types implement trait `Matmul<S>`:
             <GraphTensor<(A,)> as Matmul<(A, B)>>
             <GraphTensor<(A, B)> as Matmul<(B, C)>>
             <GraphTensor<(A, B, C)> as Matmul<(A, C, D)>>
             <GraphTensor<(A, B, C)> as Matmul<(C, D)>>
             <GraphTensor<(A, B, C, D)> as Matmul<(A, B, D, E)>>
             <GraphTensor<(A, B, C, D, E)> as Matmul<(A, B, C, E, F)>>
   = note: required for `Linear<5, 5>` to implement `luminal::module::Module<GraphTensor<(luminal::shape::Const<4>,)>>`

So I open this issue to persue a more user-friendly diagnoisic messages for compile-time check.

That looks awesome, didnt even know that was possible! I'll look into adding these around where applicable. I think it won't be as straightforward since most operations aren't implemented with custom traits like matmul is, but for the ones where that applies it will be helpful

Do you know if this is possible without a custom trait?

any example? I'm not quite sure what do you mean

As in, this works for matmul because matmul is a trait that gets implemented for valid pairs of tensors. Most operations are elementwise so they require the same shape, like Add. So that's just implemented in the std Add trait but since that's not a luminal trait there's no way to get a custom error message

It's a pity. I'll look into the official forum for the user case.

Ok for now I'll close this since I believe we can't add error messages to non-trait ops. Feel free to open it again if anything else is found.


not able to test subscription purchase in android

Version of react-native-iap
2.4.1
Version of react-native
0.57.8
Platforms you faced the error (IOS or Android or both?)
Android
Expected behaviour
need to get console purchase object after successful purchase
Actual behaviour
in debug mode can't able to purchase subscription
app installed from play store shows subscription but requires real money to purchase
Tested environment (Emulator? Real Device?)
Real Device
Steps to reproduce the behaviour
i m not able to purchase subscription in debug mode to purchase subscription
so not able to console the response in android
in debug mode it says

i have uploaded same version on play store which is in alpha
also i have added some tester to test the subscriptions
if i install app from play store subscriptions are available for purchase but it requires real debit card or credit card to purchase subscription

finally found the solution to test subscription in android
https://stackoverflow.com/questions/44628387/google-play-alpha-release-how-to-test-in-app-purchases


Add support for REJECT instead of DROP as deny action

Description
New feature, allowing you REJECT denied traffic instead of DROP it.
This is useful in cases where you want to notify callers that the
path is disallowed instead of just letting their requests time out.
In tests:

Using DROP action on iptables mode
Using REJECT action on IPVS mode

Related issues/PRs

#4500
#5256

Todos

[x] Tests
[x] Documentation
[ ] Release note

Release Note

None required

/sem-approve

Now it have at least some set of tests but someone how is more familiar with this codebase most probably should look about those and tell if they are good enough? Felix local tests with make test at least pass now (except one but that looks more like issue on my dev environment).
However would be interesting to see what is result of those E2E tests as last time those failed to check-fmt (which is now fixed) on single test code file.

/sem-approve

/sem-approve

/sem-approve

@caseydavenport Oh, there was kind of stupid mistake that I didn't run all those code generation scripts and e2e stopped before it really started. I managed to fix that by enabling Semaphore CI to my fork it looks to be quite tricky to get all tests working in there. So please trigger e2e tests again in here.

/sem-approve

@lwr20 thank you. Calicoctl failure was valid as I had forgot gofmt from there (it is fixed now).
However it it very hard to see that how that "UT/FV tests on new kernel" test failure
Summarizing 1 Failure:
[Fail] _BPF_ _BPF-SAFE_ BPF tests (tcp, ct=false, log=debug, tunnel=ipip, dsr=true) (kubernetes backend) with BPF disabled to begin with [It] should keep a connection up between hosts and remote workloads when BPF is enabled

would have anything to do with this change. Has it it been flaky earlier? Full log can be found from here

@caseydavenport any idea if "UT/FV tests on new kernel" failure can be caused by my changes or if that was just CI hiccup?

"UT/FV tests on new kernel" definitely looks flaky because it failed also on #6899 which only updates documentation.
Anyway, rebased and fixed conflicts with #6862 so new run for CI would be nice.

/sem-approve

@lwr20 thanks. now "UT/FV tests on new kernel" passed so it was CI hiccup earlier. Looks that I did bad rebase last time for calicoctl (it is a bit confusing that make gen-crds is not enough but gofmt -w is needed after that). Fixed that one and rebased to fix conflicts with #6912
So I assume that this will pass CI now and it would be nice to get proper code review for this PR.

ping @lwr20 @caseydavenport Code review please

Rebased, still waiting for code review.

/sem-approve

@mgleung thanks. Rebased and updated based on your feedback.

/sem-approve

@mgleung looks that I forgot re-generate manifests after rebase. Maybe now tests will really start?

/sem-approve

@mgleung Semaphore link here does not work for some reason but based on https://tigera.semaphoreci.com/branches/6a94d48a-8401-4717-9143-d8bd0843945d looks that CI is green 🟢


use index & hint for metadata computation

little bit of tidying as well...  these changes were a little intertwined with the stuff i did toward incremental metadata updates and you may see some relics of that (signature of compute_covidcast_meta(self, table_name='covidcast', use_index=True)).  i can remove if desired.

aw crap, this wasnt in sync, lemme fix it and do another PR

ok that should fix it, but i forgot to run tests, bbiab

(tests do pass)

oh good call. looks good! Merging now.


Clear reconciliation data should also clear facets

When clearing reconciliation data with a click on Reconcile/Actions/Clear reconciliation data, the grid ends-up empty if they were some facets on reconciliation.
Clearing reconciliation data should also clear reconciliation facets
To Reproduce
Steps to reproduce the behavior:

Create a project
Reconcile a column
Facet by reconciliation judment
From the facet, filter by "Matched"
Click on Reconcile/Actions/Clear reconciliation data

Current Results
An empty grid
Expected Behavior
The original dataset, and all facets by judgment gone
Screenshots

Versions

Operating System: MacOs
Browser Version: Chrome 88
OpenRefine 3.5 Beta]

Your request makes sense but it is not so clear to me how we could implement this in a really satisfactory way, to be honest. We could have the UI remove

the facets that are added by default by the reconciliation operation
any of the predefined reconciliation facets
any of the facets which rely on reconciliation data in this column?

The first options can be a tiny bit confusing because they would only remove some of the relevant facets. The last option is probably impossible to implement in a complete way (since we need to analyze user-supplied expressions).
Also I just thought we should be careful about automatically removing facets in general since the facets are not persisted or versioned (the undo/redo history does not affect them) so in theory we could have the situation where a user invests a lot of effort into tweaking some facet configurations, then runs the Clear reconciliation data operation by mistake, but undoing the operation does not restore their facets. This scenario is probably a bit of a stretch though.
Maybe solution 1. or 2. would be good enough actually. (I am sort of dissatisfied by the fact that we would be implementing this logic in the frontend only, probably (since that is where facet configurations are stored). I would ideally like to make progress on the broader issues of facet persistence and versioning, but I should not let that dissatisfaction prevent anyone from working on this.)

Another way of doing it would to not remove facet, but simply disable them. For that we would need a new control on each facet container to enable/disable the filter

Looks like we are just missing the "Reset" on the Facets so that none of the selected columns facets have any selection, i.e. the facets are kept in place, but cleared of selections/reset?  We know the column facets to reset because the Column name is carried through as a property for the "Clear reconciliation data" operation.  We could reset all the selected columns facets after we ensure the Recon object data was cleared from doClearReconData https://github.com/OpenRefine/OpenRefine/blob/master/main/webapp/modules/core/scripts/views/data-table/menu-reconcile.js#L49
and
https://github.com/OpenRefine/OpenRefine/blob/master/main/src/com/google/refine/operations/recon/ReconDiscardJudgmentsOperation.java
Maybe a callback ideally is needed? not sure.


Adding notifications for some Splunk alerts

In regards to https://issues.redhat.com/browse/OSD-7464
@c-e-brumm Looking for management approval.

/lgtm
/approve


Instant-based comparators for Temporal assertions

Compares OffsetDateTime, ZonedDateTime and LocalDateTime
objects using their timeLineOrder() comparator as default.
Check List:

Fixes #1452
Unit tests : YES
Javadoc with a code example (API only) : YES

:eyes:

@puddlejumpr I tool the liberty to push a commit with the changes I was suggesting to do but this is not final and I still want to hear your thoughts.

Integrated thanks @puddlejumpr!


InstructionGenerator to also generate dummy ops

For more accurate Fetch Unit behavior, speculative ops that aren't from a correct path trace provided instruction are desirable. i.e., wrong-path fetched ops (similar ops may be useful for prefetches).
The InstructionGenerator should be enabled to create these dummy ops so that its unique_id is correct and the correct path trace instructions are not lost.
One approach would be to overload the getNextInst(const sparta::Clock * clk) with another signature like getNextInst(const sparta::Clock * clk, bool dummy).
Another approach might be to add a function getDummyInst(const sparta::Clock * clk)
Note from a prior email exchange with Knute:
The use of RISC-V hint instructions or no-ops where the operand number has special meaning.  For example, if you look at
https://github.com/riscv-software-src/riscv-perf-model/blob/d74549339c2d70adae5b3fdd706bc6c44159f4b5/core/InstGenerator.cpp#L94
you can see how you can create a specific instruction + operands that you can use to determine if spec.

For "fake" speculative execution, there are four avenues until we have full execution-driven capabilities:

Do nothing.  Stall fetching, wait for branch resolution and then resume fetch when resolved
Inject no-ops
Read ahead in the trace, then rewind when branch resolved
Fetch real instructions from the original ELF

The main issue with all approaches -- it just ain't accurate w.r.t. load/store addressing and branch targets (on the wrong path).  Each methodology has its perks, but also minuses.
I would request that you focus on avenues 1 and 3 to allow for analysts to see the effects with and without a spec path, even it that path is not representative.
How you can do item 3: the trace reader uses iterators to walk the trace. If you stash that iterator in the instruction object you can restore the trace reader (instruction generator) back to the mispredicted branch (on a redirect):
(from https://github.com/riscv-software-src/riscv-perf-model/blob/d74549339c2d70adae5b3fdd706bc6c44159f4b5/core/InstGenerator.cpp#L161-L164):
            InstPtr inst = mavis_facade_->makeInst(opcode, clk);
            inst->setPC(next_it_->pc());
            inst->setUniqueID(++unique_id_);
            inst->setProgramID(unique_id_);
            inst->setSTFIterator(next_it_);    // <<< add support for this

Update the flushing mechanism to accept the flushing instruction for redirect:
(from https://github.com/riscv-software-src/riscv-perf-model/blob/d74549339c2d70adae5b3fdd706bc6c44159f4b5/core/Fetch.cpp#L109)
    void Fetch::flushFetch_(const uint64_t & new_addr) /// <<< old
    void Fetch::flushFetch_(const InstPtr & flushing_inst) /// <<< new

Finally, after flushing, reset the instruction trace generator with the iterator you stashed in the redirecting instruction.  Something like this:
    inst_generator_->reset(flushing_inst->getSTFIterator());

then resume fetching.

@knute-sifive I want to solve this issue, but I have a few questions.

To my best knowledge, Fetch Unit will fetch multiple instructions in a cycle. https://github.com/riscv-software-src/riscv-perf-model/blob/82504f6f68374d4b335d9de3d5d3890fe55e9838/core/Fetch.cpp#L64 , how do we know these instructions contain branch and set Iterator.
What if we encounter multiple branch before branch resolution, do we need to store all these iterator?
How do we know a branch is resolved?

@egieske, is your team already looking at this (or @zxc12523, are you on that team)?
To answer your questions:

You can use Mavis to determine if an instruction is a branch.  Add this code to class Inst.hpp:     bool isBranch() const { return mavis_info_->isInstType(mavis::OpcodeInfo::InstructionTypes::BRANCH); }

Yes, you store the iterator in the Inst class for each and every branch.  Branches can be executed/resolved/completed out of order.  Fetch needs to account for that
You will need to add a sparta::DataOutPort to the ExecutePipe unit and a sparta::DataInPort to the Fetch unit that will be used to communicate branch resolutions from the Execution stage back to the Fetch stage.  Suggest that Fetch keep a running list of outstanding, unresolved branches it expects to receive from Execute.


Typo in fairseq/tasks/sentence_prediction.py

Maybe this line should be replaced with dictionary,?
Otherwise, the line 149 would make no sense.

They're aliases, as defined here: https://github.com/pytorch/fairseq/blob/f840564da943f3f95bf80e93fd49be6f93d98348/fairseq/tasks/sentence_prediction.py#L203
Various places in fairseq use souce_dictionary and target_dictionary to refer to the input and output dictionaries, so we define them for most tasks (including sentence prediction).


fix(validation): assign defaultOptions before validation init.

What kind of change does this PR introduce? Bug fix
#617

This change is

Codecov Report

Merging #618 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #618   +/-   ##
=======================================
  Coverage   93.88%   93.88%
=======================================
  Files          16       16
  Lines         736      736
  Branches      211      211
=======================================
  Hits          691      691
  Misses         45       45

Impacted Files
Coverage Δ

src/core/src/services/formly.form.builder.ts
97% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada2489...f1b66da. Read the comment docs.


Docusaurus documentation

Already live here: https://cucapra.github.io/seashell/

Cool! Docusaurus is pretty nice. Here are a few comments:

I personally don't love GitHub pages as a deployment option. Can you try using Hooknook to deploy on our own servers?
Does using Docusaurus require us to commit copies of all this boilerplate under the website/ directory? All of that (including the README) looks like it's unmodified stuff from Docusaurus itself, which is pretty crufty. Other documentation generators I've used (e.g., Sphinx or mdbook) work by reading "just" the source files in Markdown or whatever along with a simple configuration.
This PR also removes some design notes we've written before that I still think are relevant but are not exactly user-facing documentation. @rachitnigam, I'll leave it to you: do you think those should get wrapped up in the new documentation infrastructure, or should we leave them in a separate place because of their non-documentation nature?

Yeah, I can look at a hooknook deployment. Since docusaurus supports building a full website, the code under website can be customized for that in the future.

The old docs have been moved to notes/. I didn’t intend on deleting them at all. Seems like they are still live under the Capra domain.

Oh oops! Fooled again by git's diffstat output showing D for moved files…

Website available at: https://capra.cs.cornell.edu/fuse


Sign in page not working over SSL tunnel

Describe the bug
I§m not sure if this is bug or feature.
I'm using SSL tunnel to access teslamate from outside of home network. The gateway server is different machine than docker server running teslamate.
(screenshot from putty on win, the same issue with command line ssh on mac).

When I reach http://localhost:40000/sign_in
I see spinner overlay and sign in is blocked. In console, I see following error:
WebSocket connection to 'ws://localhost:40000/live/websocket?baseUrl=http%3A%2F%2Flocalhost%3A40000&vsn=2.0.0' failed: Error during WebSocket handshake: Unexpected response code: 403

I don't think it's caused by ssh setting. Some anti-XSS protection, maybe?
Thanks for checking.

The logs have the answer to your question ;)
teslamate_1  | [error] Could not check origin for Phoenix.Socket transport.
teslamate_1  |
teslamate_1  | Origin of the request: http://localhost:40000
teslamate_1  |
teslamate_1  | This happens when you are attempting a socket connection to
teslamate_1  | a different host than the one configured in your config/
teslamate_1  | files. For example, in development the host is configured
teslamate_1  | to "localhost" but you may be trying to access it from
teslamate_1  | "<IP_ADDRESS>". To fix this issue, you may either:
teslamate_1  |
teslamate_1  |   1. update [url: [host: ...]] to your actual host in the
teslamate_1  |      config file for your current environment (recommended)
teslamate_1  |
teslamate_1  |   2. pass the :check_origin option when configuring your
teslamate_1  |      endpoint or when configuring the transport in your
teslamate_1  |      UserSocket module, explicitly outlining which origins
teslamate_1  |      are allowed:
teslamate_1  |
teslamate_1  |         check_origin: ["https://example.com",
teslamate_1  |                        "//another.com:888", "//other.com"]

I'll try to make the :check_origin option configurable via en env variable in a future release.

Env variable sounds great, thanks (I use both ways/hosts to access it).


[INLONG-2068][Bug] the class name in dataproxy stop.sh is wrong

Title Name: [INLONG-2068][Bug] the class name in dataproxy stop.sh is wrong
Fixes #2068
Motivation
see  #2068
Modifications
change from org.apache.flume.node.Application to org.apache.inlong.dataproxy.node.Application
Documentation

Does this pull request introduce a new feature? (no)

Codecov Report

Merging #2069 (5ab2077) into master (12b4004) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2069   +/-   ##
=========================================
  Coverage     12.28%   12.29%
- Complexity     1158     1159    +1
=========================================
  Files           413      413
  Lines         35215    35215
  Branches       5542     5542
=========================================
+ Hits           4326     4328    +2
+ Misses        30119    30117    -2
  Partials        770      770

Impacted Files
Coverage Δ

.../producer/qltystats/DefaultBrokerRcvQltyStats.java
45.31% <0.00%> (-0.40%)
:arrow_down:

.../tubemq/corebase/policies/FlowCtrlRuleHandler.java
34.51% <0.00%> (+0.44%)
:arrow_up:

.../inlong/tubemq/corebase/policies/FlowCtrlItem.java
40.00% <0.00%> (+1.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b4004...5ab2077. Read the comment docs.


[stable/fluent-bit] Remove duplicate image.pullSecrets from README.md

Signed-off-by: Noam Lerner<EMAIL_ADDRESS>Is this a new chart
No
What this PR does / why we need it:
Remove duplicated line from fluent-bit's README.md
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[ ] Chart Version bumped (I'm not sure this is necessary for this README.md change)
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

As mentioned in the PR, I don't think the documentation fix warrants a chart version bump.
However, if the owners disagree, I'd be happy to add a version bump.

/assign @towmeykaw

Not needed since this repo will be obsolete soon


It's the Final Namedown! (duh nuh nuh nuuuh, duh na-na-nuuuh)

Orie correctly noted in our last call that we seem to be forcibly applying VC Data Model titles to our specs/objects, when in fact VCs are just one type of data that they may contain. As such, he suggested we avoid commingling those names with things that don't cleanly map to them, and instead pick ones that are more reflective of what this spec and objects do.
To that end, let's have a final namedown to get this thing squared away: I will post a few suggestions as separate comments here, and you can too, and everyone can help us settle this by favoriting the suggestions they prefer below. Try to favorite just one, but if you really can't decide between two, go ahead and favorite both.

Spec name: Conditional Exchange
Required inputs object: Condition Definition
Submission of inputs object: Condition Submission

Spec name: Prerequisite Exchange
Required inputs object: Requirement Definition
Submission of inputs object: Requirement Submission

Qualifying Exchange specification, with Qualification Definition / Qualification Submission objects.

Holdy-to-McVerifierface Prerequisite Validation Exchange specification, with Holdy-to-McVerifierface Prerequisite Definition / Holdy-to-McVerifierface Prerequisite Submission objects.

Prerequisite Exchange specification, with Requirement Definition / Requirement Submission objects.

feels closest to something generic enough to encompass HTML, VC / VP, JWS / JWE / JWT, and PII / Untrusted User Input.

Credential Manifest is for Issuers who are Verifiers before the Create Credentials.
Verifier Prerequisite Exchange spec is for Verifier who want a standard for requesting information from holder.

3 Objects: Manifest, Verifier Requirement Definition, Verifier Requirement Submission

Verifier Prerequisite Exchange specification, with Verifier Requirement Definition / Requirement Submission objects.

Orie's entry into the Final Namedown! (above) is a more descriptive variant that uses a good term from the VC Data Model in the right way, so I urge folks to +1 it.

I think regardless of the name, the answer would ideally be a verifiable presentation request.  I'm not sure how far that has gone with W3C.
In the Hyperledger Indy world it's a concrete request from a verifier that defines what claims from what credentials the holder must provide.  It needs some improvement - notably a way to express, required, optional and alternative claims to prove.  But it does allow for listing the claims wanted, groups of claims (e.g. these must be from the same credential) and restrictions on the source of each claim/group of claims.  Indy supports a presentation/presentation that crosses credentials, which may be hard where selective disclosure is not supported.
We built a demo quite a while ago that builds a decentralized flow by a holder asking an issuer service:

"I want this credential",
the issuer responds with a presentation request
the holder looking in their credential store to see if they could provide a presentation.
If not - recursively repeat the process with issuers of the missing credential to find the graph of credentials
categorize the credentials they have, need and can get (they have the prerequisites) and need and can't yet get (missing prerequisites).
get the credentials needed in the correct order.

I can share the demo if you are interested.
Bottom line from my message - if the verifiable presentation enables a sufficiently rich expression of requirements, it can be sufficient and can be used to automate a workflow.

@swcurran I just talked with Orie about the same sort of thing, and the key understanding here is that these two data format objects are not specifically tied to VC presentations for credential issuance. These are generic requirement sets that could be fulfilled and never result in a credential at all. Also, the Verifier Requirement Definition can contain requirement input descriptors that are not VCs, there are many types of data/formats that you can include in a submission.

calling something a presentation request, but allowing untrusted user input that is not a VC / VP seems like a bad idea to me... thats why its important to define the input data types and output data types, along with existing specifications before naming things... as I understand it, this spec could be used with arbitrary data and html, and have no VC or VP at all... and the spec would allow that.

I don't get the "untusted user input" comment.  If this discussion is not about verifiable credentials, then agree it should not be based on VC/VP terms.

I don't get the "untusted user input" comment. If this discussion is not about verifiable credentials, then agree it should not be based on VC/VP terms.

https://identity.foundation/proof-presentation/#proof-definition---all-features-exercised
{
  "input_selection": [
    {
      "rule": "all",
      "from": ["A"]
    },
    {
      "rule": "pick",
      "count": 1,
      "from": ["B"]
    }
  ],
  "input_descriptors": [
    {
      "type": "data",
      "group": ["A"],
      "field": "routing_number",
      "value": {
          "type": "string",
          "maxLength": 9
      }
    },
    {
      "type": "data",
      "group": ["A"],
      "field": "account_number",
      "value": {
        "type": "integer",
        "maxLength": 17,
        "required": true
      }
    },
    {
      "type": "idtoken",
      "group": ["A"],
      "redirect": "https://acmebank.com/oauth",
      "parameters": {
        "client_id": "dhfiuhsdre",
        "scope": "openid+profile"
      }
    },
    {
      "type": "vc",
      "group": ["B"],
      "schema": "https://eu.com/claims/IDCard",
      "constraints": {
        "issuers": ["did:foo:gov1", "did:bar:gov2"]
      }
    },
    {
      "type": "vc",
      "group": ["B"],
      "schema": "hub://did:foo:123/Collections/schema.us.gov/Passport",
      "constraints": {
        "issuers": ["did:foo:gov1", "did:bar:gov2"]
      }
    }
  ]
}

Note that the current example contains many things which are not VC / VP / JWT.

Ah...got it. We are assuming a trusted communication channel.

@swcurran think of these two objects this way:
Verifier/processor of things: "Setting aside any activity/goal we may be engaged in - which could be anything - provide me with a selection of the following odds and ends, which may include VCs, raw data, JWTs, etc."
Entity who has said things: "Sure, here are some things from those groups of things you said I needed to submit to you"
What the things are they are requiring/submitting is not bound to VCs specifically, or the issuance of a credential, it's just a list of stuff someone is demanding to proceed with some activity, which could be anything.

Yes - agreed it can go beyond VCs.  We have discussed the need to express
non-VCs ways to do it.  Makes it hard to do an API so we were assuming the
VP might be extended vs something different.
On Wed, Feb 12, 2020 at 12:14 PM Daniel Buchner<EMAIL_ADDRESS>wrote:

@swcurran https://github.com/swcurran think of these two objects this
way:
Verifier/processor of things: "Setting aside any activity/goal we may be
engaged in - which could be anything - provide me with a selection of the
following odds and ends, which may include VCs, raw data, JWTs, etc."
Entity who has said things: "Sure, here are some things from those groups
of things you said I needed to submit to you"
What the things are they are requiring/submitting is not bound to VCs
specifically, or the issuance of a credential, it's just a list of stuff
someone is demanding to proceed with some activity, which could be anything.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/decentralized-identity/proof-presentation/issues/10?email_source=notifications&email_token=AAHYRQT2IXQ76Y2TN34GKVLRCRKCFA5CNFSM4KT6DA72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELSHD5A#issuecomment-585396724,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHYRQWKYZGU3G4OKNTNKVLRCRKCFANCNFSM4KT6DA7Q
.

--
Stephen Curran
Principal, Cloud Compass Computing, Inc. (C3I)
Technical Governance Board Member - Sovrin Foundation (sovrin.org)
*Schedule a Meeting: *https://calendly.com/swcurran
https://calendly.com/swcurran

Whatever is done here, it would ideally be compatible with CHAPI (The Credential Handler API). CHAPI essentially supports arbitrary JSON and therefore the transport of just about any sort of data (whether it be VP/VC data or something else). Of course, if it can be represented in JSON it should be fairly easy to be compatible, but it would be good to take into consideration some of this other (not yet settled, but used in existing software) work:
https://gist.github.com/dlongley/74cb42563eb4a983166f6f5fb58282d8
Note that a "Verifiable Presentation" doesn't have to include VCs; it is intended to be a way to present all kinds of things (despite VCs being the only thing in a W3C REC so far) in a way that can have an authentication proof attached to it. We present Authorization Capabilities (zcaps) via a VP, for example.

@dlongley the intention is definitely for this to be JSON, if that's the key bit you're noting for use with CHAPI. The input typing and option selection rules are what differentiate this, so I would like to ensure that we preserve the intent to support those needs, regardless of the final data format prop/value composition.

I guess I was wrong to assume that a "Verifiable  Presentation" always contained VCs... AFAIK CHAPI would be a transport, which this work could support, similar to the universal verifier APIs.

Presentation Exchange specification with Presentation Definition / Presentation Submission objects.
Transport Agnostic with support for HTTP /  CHAPI / DIDComm?

Yep, what Orie said. Should be able to slap this into OIDC, CHAPI, DID Comms, etc., given this is just the payload guts that help people articulate needs and make choices using the selection optionality they are provided with.

Presentation Exchange specification with Presentation Definition / Presentation Submission objects.
Transport Agnostic with support for HTTP / CHAPI / DIDComm?

Two questions:

What are you intending by posting this riff on the names? Are you saying those should be the names?
What was your question about transport agnostic, I didn't understand. My statement was rather simple: these JSON objects don't care whether they are being sent over HTTP, in DID Comm envelopes, over Bluetooth, etc., or which particular cred negotiation scheme (Aries, OIDC Self-Issued, or other) integrates them.

What are you intending by posting this riff on the names? Are you saying those should be the names?

Yes, its a proposal for the names

2. What was your question about transport agnostic, I didn't understand. My statement was rather simple: these JSON objects don't care whether they are being sent over HTTP, in DID Comm envelopes, over Bluetooth, etc., or which particular cred negotiation scheme (Aries, OIDC Self-Issued, or other) integrates them.

My point was to make it clear that these names don't imply a Transport.

@OR13 I'm fine with the names you just proposed. Let's see what other folks think!

I'm fine with the names.  I'd also go with "Presentation Request" and "Presentation" as the more general forms of the "Verifiable Presentation Request" and "Verifiable Presentation" (if we assume those latter terms can only reference verifiable credentials/claims.
Agree that this is a data format that is transport agnostic.  Ultimately, the submission gets turned into a query for stuff you have that will satisfy (some or all of) the request, and in turn, the query results become the response.

I'm also fine with Orie's latest naming recommendations.

I'm fine with the names. I'd also go with "Presentation Request" and "Presentation" as the more general forms of the "Verifiable Presentation Request" and "Verifiable Presentation" (if we assume those latter terms can only reference verifiable credentials/claims.

I would like to refrain from using the term Request, because it invokes the idea that the thing we're working on is related to the actual sending of the packets/data over a channel, like an HTTP request/response. The word Exchange avoids commingling those other concepts with what this body of work defines, so that's why I am advocating for it.

So, are we back to presentation definition?
On Fri, Feb 14, 2020, 10:04 Daniel Buchner<EMAIL_ADDRESS>wrote:

I'm fine with the names. I'd also go with "Presentation Request" and
"Presentation" as the more general forms of the "Verifiable Presentation
Request" and "Verifiable Presentation" (if we assume those latter terms can
only reference verifiable credentials/claims.
I would like to refrain from using the term Request, because it invokes
the idea that the thing we're working on is related to the actual sending
of the packets/data over a channel, like an HTTP request/response. The word
Exchange avoids commingling those other concepts with what this body of
work defines, so that's why I am advocating for it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/decentralized-identity/proof-presentation/issues/10?email_source=notifications&email_token=ACPFKP2YNGX5V3VLWM5NBOTRC3FKZA5CNFSM4KT6DA72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELZWYCQ#issuecomment-586378250,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACPFKP6W2FRMAPSEYAQTWILRC3FKZANCNFSM4KT6DA7Q
.

Hey folks, it sounds like we have some consensus on the following designations: Presentation Exchange specification with Presentation Definition / Presentation Submission objects.
Can you please all +1 this comment or post any explicit disagreements so we can close this out?

Barring any last minute, extremely persuasive arguments, I am inclined to close this out using the Presentation Exchange specification with Presentation Definition / Presentation Submission names going forward. I will be on the call today with Brent to finalize a few of these Issues.

I started with some string changes to the strawman spec to reflect this consensus, and will close this out with these being the new names going forward.


make scvi run faster on test mode

SCVI takes far too long on test mode (over an hour). This speeds it up for testing purposes by decreasing the network size.
Submission type

[ ] This submission adds a new dataset
[ ] This submission adds a new method
[ ] This submission adds a new metric
[ ] This submission adds a new task
[ ] This submission adds a new Docker image
[X] This submission fixes a bug (link to related issue: )
[ ] This submission adds a new feature not listed above

Testing

[X] This submission was written on a forked copy of SingleCellOpenProblems
[ ] GitHub Actions "Run Benchmark" tests are passing on this base branch of this pull request (include link to passed test: )
[X] If this pull request is not ready for review (including passing the "Run Benchmark" tests), I will open this PR as a draft (click on the down arrow next to the "Create Pull Request" button)

Submission guidelines

[X] This submission follows the guidelines in our Contributing document
[X] I have checked to ensure there aren't other open Pull Requests for the same update/change

PR review checklist
This PR will be evaluated on the basis of the following checks:

[ ] The task addresses a valid open problem in single-cell analysis
[X] The latest version of master is merged and tested
[ ] The methods/metrics are imported to __init__.py and were tested in the pipeline
[ ] Method and metric decorators are annotated with paper title, year, author, code version, and date
[ ] The README gives an outline of the methods, metrics and datasets in the folder
[ ] The README provides a satisfactory task explanation (for new tasks)
[ ] The sample test data is appropriate to test implementation of all methods and metrics (for new tasks)

Actually, this doesn't work -- the test runs still take over an hour. Not sure why...

cc @mxposed

Nevermind, I figured it out! The CLI wasn't passing test=True through to the method.

Glad you figured it out! I didn't notice this when looking briefly yesterday

The problem is much less significant now, but this still brings it down from being a 6min outlier to closer to average for task duration. @mxposed are you happy for me to make these changes on train_max_batches and val_max_batches?

Yes, looks good


[COLLATECODE] Attempt to collate code and generate md files.

Coverage remained the same at 80.871% when pulling cd2bf525d95c35282054a923c7e53ea692f124e6 on charlesgoh:altersize-buttons into 66c0f01f789323a82a4a9dd55dc648612e899a31 on CS2103AUG2017-W09-B2:master.


Block proposer

Honest block proposer link in block_proposer.md is local host. 😄
http://localhost/#honest-block-proposer

Where exactly?

Same for wire format link in networking.md.
Todos or not providing a link may be better?

Ah whoops I'm on an iPad and I guess GitHub injects localhost

Those top-level links need to be removed anyways, they're there from the old ToC auto-generator settings.


Version published on NPM is missing the type definitions

Hi @kessler
(Sorry if this is not the right place for this kind of issue)
As the title describes, the version published on NPM is older that the October commit that added types.
Would it be possible to push a new version so that we can use them?
Thanks

yes, I'll take of this on the weekend!
my sincere apologies

Many thanks :)

@merwaaan will be delayed in a few days. As I'm updating the docs as well.


Round corner

Is it possible to draw a round corner for the circle ?

Hi BilalReffas:
I'm afraid I'm not clear on what you're asking here. Can you please provide an example?

@BilalReffas Any further information on your request?

I think he means a round line cap.

The current implementation does not support this feature. Feel free to make modification and submit a pull request.


Automatic reload of schedule to get insertions

The current manual update button seems not intuitive.
At 36c3 there have been no insertions maybe because no one understood that they have to be loaded manually by pressing UPDATE.
A possible improvement would be to load schedule when switching to LIVE.

I have been thinking of scheduling actions driven by the start times on the event schedule.
example: load up cron tab with systemctl --user start videoteam-record.service 5 min before every talk is scheduled to start.  We shouldn't need to do this, but I often manually stop that process, and then stress or forget about starting it.  in the context of this issue, it doesn't matter if stopping recording is a good idea ;)
It sounds like it would also be good to reload the schedule at opportune times.
Conference schedules have 2 flavors of data:
slot: location, time, duration an event will happen.  this is generally very static.
talk: title, presenter... - mostly static, but often filled in at the last minute.   both unplanned: talk cancelled and replaced; and expected: ad hoc that might get data entered into the scheduling database as the person is walking onto the stage.
It seems reasonable to use the slot data to grab the current talk data.

Currently in voc2mix there is a functional way to have insertions which come from the schedule. Just to make that clear. And I think it could have worked at congress too.
voc2mix currently fetches schedule.xml from the local file system. so it has to brought there some how. I would be interested if that did work?
When changing the schedule in-time and file content is polled this could cause a cascade of unnecessary communication. Because core has to load new file and broadcast it to the clients and these clients would instantly update.
Also the currently pre-rendered PNGs should be generated by the core or at least locally at the encoder computer. In this way we would be able to have insertion texts that could be manually entered by the mixer person. But this is another issue.


facetattoo1#10

0x9b720446714A8364CDa80C148Ebb9E8245e57A25

Massive thanks for being our first external submission 🥳
I see your submission to DAOHaus came in two parts, one for a share and one for DGT tokens. I mistakenly voted down the share one 🙈 - making sure the rest of the DAO votes it in though. If it fails, we can resubmit just the Share request on DAOHaus 🤞

Big thanks for the cool project - I'm excited to see results!


Use clang-style USRs for swift decls that are exposed to Objective C

We have an issue where the Swift symbols that are exported to ObjC via the generated ObjC header that the Swift compiler emits, have different USRs when indexed from swift & clang.
The swift side uses Swift-specific USRs while the clang side uses it’s own ObjC USRs, making these symbols and their references seem as if they are different symbols (e.g. for jump-to-definition, callers, etc).
This patch changes the USR generation for @objc swift symbols to use clang-style USRs, so there is a single USR cross-language.

This is a step towards resolving rdar://problem/16271632, but it doesn't yet 'namespace' the generated clang-style USRs with the swift module name (waiting on some clang changes).  This is needed to avoid USR conflicts with symbols from different Swift frameworks.

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test


Does not work with Teensy 3.6

I tried the Library on a Teensy 3.6 and it doesn't work. So I tested some stuff out and got it to work unreliably with the clock frequency lowered to 120Mhz or 96Mhz. I also hooked the DOUT up to my oscilloscope and found out that the CLK frequency was always at 1Mhz at all clock frequencies including 180Mhz and 240Mhz.

I located the problem: Everything works when I initialize the IC with the Teensy 3.6 set to 96Mhz, and then comment out the initialisation commands and setting the Teensy back to 180Mhz. So there is somehow a problem with initialising the STMPE610 when the Teensy is set to 180Mhz(above 96/120Mhz).

we've done quite a refactor, this is likely fixed? please try it and reopen if still an issue

Hello,
I have also tried the 3.5" Feather TFT (Library version 1.1.0) with a Teensy 3.6 and the touch function does not work... With an Feather M0 it works without issues.
I have found this topic here and added the delays:
https://forum.pjrc.com/threads/54982-TEENSY-3-6-ADAFRUIT-3-5-quot-TFT-touch-controller-issue
Now it works some kind of, but there are some issues and it is not 100% reliable.
Please check the libary with a Teensy 3.6.

tanks, please submit a PR with the delays you have added!


Add download links to demo notebooks on readthedocs

Description
When looking at our demo notebooks inside documentation on readthedocs (added for #1279), it would be useful to be able to directly download the notebook.
As an example, see scikit-learn, eg: https://scikit-learn.org/stable/auto_examples/plot_changed_only_pprint_parameter.html#sphx-glr-auto-examples-plot-changed-only-pprint-parameter-py
Done Checklist

[ ] Produced code for required functionality
[ ] Tests written and coverage checked
[ ] Code review performed
[ ] Documentation on Google Docs  (if applicable)
[ ] Documentation in repo
[ ] Version number reflects new status
[ ] CHANGELOG.md updated
[ ] Team demo

We're using nbsphinx plugin to embed notebooks inside docs, and it doesn't appear to support this.
The example above from scikit-learn uses a different plugin https://sphinx-gallery.github.io/stable/index.html which actually bundles files for download, but doesn't support Jupiter notebooks as input.

Another approach might be to just include a link in the notebook that points to itself on github (i.e. update format notebook script to put in the link) and the user can do a "save as" on that?

Adding a link to the notebook itself is a good idea, however I had a look and one problem is that GitHub doesn't allow direct download - clicking such a link opens the notebook source in a browser rather than just downloading it, eg: https://raw.githubusercontent.com/stellargraph/stellargraph/master/demos/basics/loading-networkx.ipynb

Yeah I think we can't get around that unless we also host all our demos somewhere other than github. Maybe something like below is not terrible?:
View the notebook or download via the "Save Link as..." option: loading-networkx.ipynb

I think the ipynb files are already included (maybe by nbsphinx or maybe by nbsphinx-link?) in the Sphinx output; for instance, https://stellargraph.readthedocs.io/en/latest/demos/basics/loading-networkx.ipynb looks correct to me.
We can then probably use use nbsphinx_prolog to insert a download button (https://nbsphinx.readthedocs.io/en/0.6.1/prolog-and-epilog.html). Something involving docname, I guess.

The example above from scikit-learn uses a different plugin https://sphinx-gallery.github.io/stable/index.html which actually bundles files for download, but doesn't support Jupyter notebooks as input (only specially-formatted .py files)

nbsphinx seems to have some sort of gallery support too: https://nbsphinx.readthedocs.io/en/0.6.1/subdir/gallery.html

High priority, want this process to be seamless and possibly pretty straightforward.


Support more strategies for folder notes

This new issue is mainly opened to discuss details of folder note implementations. When the agreement to the exact implementation is established, I may then ask some other questions regarding the build system of this project and try to submit PRs when time permits and you agree to accept the PR.
Functional Support
Currently, folder-note-core has been tested for a while and will soon be used by alx-folder-note. the API has been improved according to your demands. When you are not occupied, please do not hesitate to ask if there are more questions or needs.
UX Proposal
Currently, only the "inside folder, same name" strategy is used and the UI has not yet been optimized for other strategies like "outside folder" or "index name". Treating the folder notes as regular notes is fine for the current strategy, but it may cause problems for other strategies. For example, having duplicate folders and folder notes in the sibling menu when using the "outside folder" strategy.
In my opinion, the different strategies are a matter of storage solution, and when it comes to UI, where folder notes really are doesn't really matter, since they are used to provide additional info for the linked folders, and the folder can be used as the only entry. So here I'm proposing several UI solutions to unify the experience for different strategies and to reduce duplication and confusion.
Breadcrumb
Here, I propose a solution that will keep the current breadcrumb logic, which uses an abstract file item at the end of breadcrumb to represent folder notes like so (an icon in favor of plain text may be better):
.
In this solution, the actual file name is hidden from UI (should not be an issue since the name can be found in the linked folder), and the logic can remain the same as the current one: click to show siblings, right-click to show options for note, and the underlying strategy is no longer relevant: no matter where the note is, it is always shown as folder note item next to the linked folder.
Siblings Menu
Currently, the folder notes are placed in the file sections, treated as regular notes. I think a better solution may be  1. filter folder notes out of the file list
2. check if a folder has any folder note, and have a UI control for folder notes in/under folder item
And for folder note control in the siblings' menu, I currently have three ideas in mind:

insert folder note directly next to folder item (most straightforward, but taking up 2x space)
dedicated icon for a folder with folder note, merge file-menu for note and folder (less hotkey to remember, but the menu can be lengthy)
dedicated button & hotkey for opening file-menu of folder notes (button can be an indicator of the folder with folder note, rather complicated to implement)

Regarding the UI, I'm going to say that hiding anything is a definite no.  Quick Explorer won't ever hide folder notes or pretend that the note and its folder are the same thing.  I'm prioritizing transparency over convenience here, to prevent confusion and support issues.  Concealing the implementation strategy of folder notes provides (at best) a minor optimization in space usage or reading time, and this isn't remotely balanced by the opportunities for confusion created by a lack of transparency.
If one were writing an app like Obsidian from the ground up with this support and insisting all plugins support this model in exactly the same way, it might make sense to conceal such things.  But since QE is not the only plugin or built-in facility users will use to access their notes, it does not make sense to present things in a way that will be inconsistent with their other tools, as this will lead to confusion as the representation of e.g. paths will not match.
In short, while QE will (eventually) support all three folder note strategies, I have no plans to change the UI for any of them.  (The one exception being that while outside-same notes will be previewed on folder selection, they will not be navigated to when the folder is entered, since the file is outside the folder.  While this is somewhat of a disadvantage to that approach, that approach already has so many disadvantages compared to inside-based strategies that one more will make little difference to its usefulness.)
Note that currently, entering a folder navigates immediately to its (contained) folder note, so rather than needing a new button or hotkey to perform the action described in your proposal, it currently suffices to right-arrow, backslash, or enter, alt+enter to access the context menu for a folder note.  It doesn't require learning anything new, just the use of the existing keyboard commands.

Thanks for the explanation! I understand your concern, and do you think that it’s ok to add a icon for folder notes as an indicator? In outside-same strategy, it can be helpful when there are many folders and viewing folder and the note at the same time isn’t an option. Or maybe a sort option to put them in a group at the end of list (of course, when list sorting is supported in the future)? And if it is acceptable, may I open a new issue about those?

If the names of the note and folder are the same, the required uniqueness is the same, whether inside the folder or outside.  While links to the outside-same note are shorter than those to an inside-same note, links from an inside-same note to other files in the same folder do not require a path prefix, nor do any links to that note from others in the same folder.
Since the common uses for folder notes are to provide an overview or index to the folder contents, or to use the folder for images or other attachments. easier linking to the folder's contents is a clear win, as is the fact that Obsidian can be configured to make new notes relative to the current one.  So in most circumstances, these advantages make inside-same or inside-index the superior choices -- and adding a few tweaks to QE's UI for outside-same won't do anything to mitigate the (huge) relative disadvantages of the outside strategy.
This is why I don't see any point to adding extra features for outside-same: in practice I don't expect it to be a popular strategy, so the effort would be wasted if a feature is only useful for that strategy.

Thanks for the kind reminder of obsidian’s relative path resolve strategy, which had been my major concern of using inside-same. I will add it to the comparison table.
Although the new note location can be monkey-patched (which I’ve added to folder-note-core in dev branch recently) and the strategy is now more usable, it’s true that not being included in folder is quite troublesome to handle sometimes (e.g. moving folder out of vault). Considering the overall effort that might be necessary to fully support this strategy in the future, I’ll be focused on adding command for batch conversion between strategies and a more detailed strategy comparison table, letting user to decide their choice.


jira sprint list only shows status In Progress

jira version 1.0.0
For stories/bugs that are in the sprint but are set as Open status, jira sprint list or jira sprint list --current doesn't list those Open/Closed/PENDING/IMPLEMENTED/etc... Status, only listing only In Progress.
This shouldn't be the case, if we are performing jira spring list it should list all spring regardless of its' statuses and if they need to custom search the status a command such as jira sprint list -sOpen or jira sprint list --status Closed should be supported instead.

Hi @leopck, jira sprint list command shows issues regardless of its statuses as long as it is returned by the Jira API. Could you please mention if you are using jira cloud or on-premises installation (with version)?

That's strange... I'm using jira on-premises installation. Currently have Jira sprints with different statuses but jira sprint list only shows In Progress

@ankitpokhrel I have snip a comparison of the output for your reference.

The image on the left (terminal) is only displaying the In Progress as seen from the ID of the full list on the right hand side which is the Jira website itself.

Do you get all the issues back if you query the API directly?
curl --request GET \
  --url 'https://<jira-server>/rest/agile/1.0/sprint/<sprint_id>/issue' \
  --user "hello@ankit.pl:$JIRA_API_TOKEN"

You can get sprint id using jira sprint list.
(Also could you please mention the version of Jira you are using?)

Jira version: v8.20.2#820002-sha1:829506d:prd1phyjdc01
How do I set bearer for the auth because I'm using PAT (Personal Access Token)?

You can use header to pass bearer token.
curl --request GET \
  -H "Authorization: Bearer $JIRA_API_TOKEN" \
  --url 'https://<jira-server>/rest/agile/1.0/sprint/<sprint_id>/issue'

@ankitpokhrel thanks for the command. I just finished comparing the two output and compared against the website version as well. The RESTful API is able to query all the issues and it's the same as the website output. Image below shows that the website the REST API is the same.

That's strange! Are all these issues in the sprint from same project that you configured?

Yes, I did not change the project. This is all from the same project.

I am not able to reproduce this in my installation so its bit tricky to say what's happening. Could you please check if you get same results as before when using project filter in the Jira API?
curl --request GET \
  -H "Authorization: Bearer $JIRA_API_TOKEN" \
  --url 'https://<jira-server>/rest/agile/1.0/sprint/<sprint_id>/issue?jql=project=<project_key>'

@ankitpokhrel yes, it's working as well. Image below shows that the output is the same as the previous REST query and same as the website.

@ankitpokhrel I found what's the issue. Running the debug mode, I discovered the REST API that was used. It was using this API:
https://<jira url>/rest/agile/1.0/board/<id>/sprint/<sprint id>/issue vs https://jira.devtools.intel.com/rest/agile/1.0/sprint/<sprint id>/issue?jql=project=<project-id>
You can see the difference in the output the top command is using https://<jira url>/rest/agile/1.0/board/<id>/sprint/<sprint id>/issue and the second command is using https://jira.devtools.intel.com/rest/agile/1.0/sprint/<sprint id>/issue?jql=project=<project-id>
I'm not familiar with board/, I'm assuming this is board ID. What is this board and board ID?

@ankitpokhrel I just checked the board, this board doesn't list all issues from other status because the board only shows To Do, In Progress and Done.
Is it possible to either support pulling from https://<jira-server>/rest/agile/1.0/sprint/<sprint_id>/issue itself and support a separate command for pulling sprints from a board: https://<jira url>/rest/agile/1.0/board/<id>/sprint/<sprint id>/issue rather than defaulting to using the boards directly?
One reasoning is that not everyone is using the boards for sprints. And you can replicate this issue as well, try to create an issue and assign that issue into a Sprint and go to the board to make sure that the status doesn't exist on the board before changing to that status. The issue won't show up on the https://<jira url>/rest/agile/1.0/board/<id>/sprint/<sprint id>/issue .

@ankitpokhrel I tested this by doing a simple workaround
https://github.com/ankitpokhrel/jira-cli/blob/19ce4b4168b7ac6a98a5b0af8526320bde862781/pkg/jira/sprint.go#L97
I changed this line to this after removing board from the query:
path := fmt.Sprintf("/sprint/%d/issue?startAt=%d&maxResults=%d", sprintID, from, limit)

And now it works! It's not the most elegant solution, I would suggest something like jira sprint list --board for those that only wants to list sprints on a particular board.

Are all these issues in the sprint from same project that you configured?

I meant board here, sorry! When I first created this feature, I didn't realize that sprint can have tickets from different boards but this is something that needs to be fixed. No one complained about this so far and for my usecase I usually have tickets from same board in the sprint.
I will work on the fix. PRs are welcome in the meantime!

@ankitpokhrel I don't mind pushing a PR on this, though i'm not a golang expert but I can try. What solution do you have in mind for this? Just remove the board or have it as an argument e.g. jira sprint list --board <board-id> or just jira sprint list --board?

Hi @leopck, this has been fixed with #475. You can use --show-all-issues flag to view issues from all projects. jira issue list will only show issues from configured project or project selected with -p option.
Note that the Jira behavior doesn't seem consistent here so you might still get results different than that of the Jira UI.


Move shared snforge collector abstraction to separate crate

Closes #1216
Related: https://github.com/software-mansion/scarb/pull/999
Introduced changes

Checklist

[ ] Linked relevant issue
[ ] Updated relevant documentation
[ ] Added relevant tests
[ ] Performed self-review of the code
[ ] Added changes to CHANGELOG.md

Closing since it's heavily outdated


bf16 chapter should be after zfh chapter

The newly-added bf16 chapter (currently Chapter 19) should be moved to be after the Zfh chapter (currently Chapter 24).  It is conceptually another floating-point format and should be after the F/D/Q/Zfh chapters.

I agree.  #1359 was merged without approval; this should've been caught during review.


Can't overwrite scrolls with other patterns

Versions
Minecraft: 1.18.2
Forge: 40.0.34
Hex: Commit 767dd99
Paucal: Commit 8f64bef
Issue
Scrolls cannot be written to if there's already a pattern stored in the scroll.
For example, empty scrolls can be written to (Consideration, pattern, Scribe's Gambit) but after that, it cannot be written to anymore.
The error given in chat is:
operator expected at.petrak.hexcasting.common,items.ItemDataHolder in offhand but got 1 scroll
This bug was encountered on the supporter Hexcasting server.

That's intended behavior.

(The janky mishap message is fixed on the bleeding-edge)


[Fix: http client supports namespaceId.] (#48)

#48

@moremind Can you run ci again? Personal project ci passed.
https://github.com/koonchen/shenyu-client-golang/pull/2

pls change your code,about nacos namespaceId(param named like NameSpaceId), the  nacos source code is use "public"

I'm not sure if this is correct, PTAL @lishuo5263

@moremind PTAL

Codecov Report
Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (10938f5) to head (0ab0a0b).
Report is 8 commits behind head on main.

Files with missing lines
Patch %
Lines

example/consul_client/consul_client.go
0.00%
21 Missing :warning:

example/zk_client/zk_client.go
0.00%
18 Missing :warning:

example/etcd_client/etcd_client.go
0.00%
12 Missing :warning:

example/nacos_client/nacos_client.go
0.00%
8 Missing :warning:

Additional details and impacted files
@@          Coverage Diff           @@
##            main     #49    +/-   ##
======================================
  Coverage   0.00%   0.00%
======================================
  Files          2       4     +2
  Lines        186     385   +199
======================================
- Misses       186     385   +199

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests