[MECHANIC]: Camera Rework

Description of what will be added or updated
Rework the camera to make it easier to use.
Handle corners better.
Currently the camera moves left and right in a circle and zooms in or out.
One possibility is to have the camera move up, down, left, right, zoom in, zoom out.
Additional Information
No response

#100 was merged


[DNM] [WIP] Fix image size

Fixes: #214
@rootfs @gman0 PTAL, let me know it changes looks good, i will test it out.

looks good, is it still DNM?

@rootfs we need to make a decision on minimum volume size on cephfs https://github.com/ceph/ceph-csi/issues/214#issuecomment-468649045
still i need to test this PR.

sure, I'll let @gman0 make the final decision

@Madhu-1 @rootfs for cephfs:

the correct solution would be to handle LimitBytes, because we're not pre-allocating volume space but merely specifying a soft limit for maximum bytes in a directory. Unfortunately, external-provisioner handles only RequiredBytes at the moment: https://github.com/kubernetes-csi/external-provisioner/blob/c42566f2229722b0184e45781be91f1e40b8c86c/pkg/controller/controller.go#L497-L504
keep cephfs handling the size as it was before
a compromise: round up to 1MiB as is done in this PR, but still accept 0 as size

I'd go with option (2) because it's the closest to reality (in regards to ceph and csi spec) we can get with current state of external-provisioner.

@gman0 reverted back the changes for ceph-fs PTAL
tested for rbd and working  fine

@gman0 Mergify is failing can we merge this one manually?


Uploading Teacher Notes into MediaValet (Mastercard Foundation grant)

(Instructions are also here: https://docs.google.com/document/d/1BlWwg6thJtTgKYgxZ8FMD4_48NJmlUZp_7Wb_AILK8k/edit?pli=1#heading=h.b51ndt10u0w5)
Tracking
I’ve set up this spreadsheet with all the simulations relevant to the university level.
https://docs.google.com/spreadsheets/d/1EXHNSlCI8Cxug-avm7L2Qu-KrDcf2f8V/edit#gid=679020387
I’ve already uploaded the document for 2 simulations (Geometric Optics and Density) as a test. I marked this is in the final column. This sheet could also be used by your team for both the data and tracking each sim.
Creating the PDF
Use this template to create a cover page pdf.
https://docs.google.com/presentation/d/1S0skEFvA_oTXoJD9mLLMaQtA1mClQaOVgPL8sT6pidE/edit#slide=id.g147b0c0ee54_0_0
Please make sure that the PDF is clickable- so that the simulation URL goes to the simulation and the about url goes to the simulation about page.
Download the teacher notes PDF for each simulation.
Add the cover page pdf to the teacher notes pdf. (On a Mac I can combine pdfs by using Preview, but I’m not sure how to do this on a windows machine, sorry.)
Name this combined pdf:
sim name_PhET Interactive Simulations
Save it on drive here: https://drive.google.com/drive/folders/14tDJu_U7QHq6rHi9TemcGGiz6nv9LelC
Uploading into MediaValet
Log into Media Valet:
URL: mastercardfdn-elearning.mediavalet.com
For user name and password, ask nancy, katie or emily :)
Add Categories
Click “Add” next to each asset.
Then navigate the tree structure to map the PhET categories to the Media Valet categories:
Physics —> Course Content, Physical Sciences, Physics
Chemistry —> Course content, Physical Sciences, Chemistry
Biology —> Course content, Health Science, Biosciences, Biology
Mathematics simulations —> Course content, Mathematics, Mathematics (General)
Earth Science →Course content, Physical Sciences, Earth Science
NB: You can add multiple categories (eg physics and chemistry) to the same assets.
Add Attributes
Approved for external use: CC BY
Approved for External Use (Creative Commons LINK): https://creativecommons.org/licenses/by/4.0/
Institution (dropdown): PhET
Course Title: Simulation Name
Quality Matters Certification Status: Not applicable
Leave the rest blank.
Add Keywords
Add Keywords from the spreadsheet.
Also add these two keywords:
Interactive; Simulation
Add Description
Add the description about each simulation (take this from the metadata spreadsheet). Add the list of Sample Learning Goals to the description.

Please record time here:

[ ] Tester = , Time =
[ ] Tester = , Time =
[ ] Tester = , Time =
[ ] Tester = , Time =

Thanks Nancy!
I saw that as well and deleted some older tests that I did.
On Tue, Aug 23, 2022 at 1:31 AM, Nancy Salpepi @.***>
wrote:

@JacquiHayes https://github.com/JacquiHayes I believe I was able to
successfully delete an asset following these steps:

In the Browse Tab, hover over the thumbnail of the asset you want
to delete. Icons should appear at the bottom of the thumbnail.
Select the Detailed Info icon
Select the Kebab menu (3 dots)
Select Delete Asset
Refresh page -- the asset should no longer be there

—
Reply to this email directly, view it on GitHub
https://github.com/phetsims/qa/issues/827#issuecomment-1222522464, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AOLUG523XIONVRNOFOUHAQTV2OMLLANCNFSM566XNM2A
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi @JacquiHayes! Currently there aren't any teacher tips posted for Collision Lab on the website. Should I just post that sim as the cover page only?

Did you ask the designers whether the teacher tips are coming?
If not, then the cover page by itself is fine. Thanks!
Am Mi., 24. Aug. 2022 um 02:53 Uhr schrieb Nancy Salpepi <
@.***>:

Hi @JacquiHayes https://github.com/JacquiHayes! Currently there aren't
any teacher tips posted for Collision Lab on the website. Should I just
post that sim as the cover page only?
—
Reply to this email directly, view it on GitHub
https://github.com/phetsims/qa/issues/827#issuecomment-1224342103, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AOLUG52BMTUSZBYTGOBZ5N3V2T6ZXANCNFSM566XNM2A
.
You are receiving this because you were mentioned.Message ID:
@.***>

@JacquiHayes Collision Lab and Build a Molecule were uploaded without the Teacher Tips (unfortunately they weren't made yet).
Let me know if you see any issues!

I logged in and it looks like all 63 relevant documents are there. Nice work!


PutMessageDistributeTime statistics are inconsistent.

Please describe the issue you observed:
The PutMessageDistributeTime statistics result will be printed to store.log, or it can be obtained through mqadmin (sh mqadmin brokerStatus). It is found that the two statistical results are inconsistent.

After confirmation, it is found that the statistical data obtained through sh mqadmin brokerStatus is actually less than 1s.

Please tell us about your environment:
version:4.8.0

Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc):
I will fix this question later.

merged


dataDispatcherDevice : showDispatcherList does not work

jd does not work, probably because with DATA_DISPATCHER_DEVICE_HEADER, we use it to launch command remotely


'exceptionHandling()' is deprecated since version 6.1 and marked for removal in 7.0

Documentation 4.4.0 Section 3.9.1 and 3.9.2
Replace http.exceptionHandling().authenticationEntryPoint(unauthorizedEntryPoint); with
http.exceptionHandling(customizer -> customizer.authenticationEntryPoint(unauthorizedEntryPoint));
and http.exceptionHandling().accessDeniedHandler(accessDeniedHandler);
with http.exceptionHandling(customizer -> customizer.accessDeniedHandler(accessDeniedHandler));

Thanks for letting me know!


Get merged launch link and ID

As it stands, there is no way to get the link to a merged launch. The finishLaunch hook contains some logic to handle these links. However, when merging launches these links are invalid pretty much immediately.
It would be very useful to be able to print this link or even save it to a text file for later use.
Context: I currently link test reports upon test completion via the Slack API. I would like to be able to pass along the link to the Report Portal launch with these messages.

I actually realized that I could theoretically do this by using the method mentioned here.
In that case, if the update that allows adding to an existing launch id is released,  I would be able to print the launch link, but I would need to implement actually saving the link or iD myself. I think many other users would be able to use this feature so it would be nice to release that to the masses.
If after reading this the devs believe this is a duplicate issue, please feel free to comment and close.


Update dependencies

What does this Pull Request do?
Makes the __construct function private, so you must use the create method. We need to start storing the base_uri in our FedoraApi instance as Guzzle is deprecating access to the getConfig() method. So passing in a pre-built Guzzle will no longer allow us to determine the base_uri.
That is why this PR is against the new 2.x branch as this will be a backwards breaking change.

Related GitHub Issue: https://github.com/Islandora/documentation/issues/2220

*** This PR is FIRST in the chain of work ***
Dependant PRs:

https://github.com/Islandora/Crayfish-Commons/pull/63
https://github.com/Islandora/Crayfish/pull/174
https://github.com/Islandora/islandora/pull/936
https://github.com/Islandora-Devops/islandora-playbook/pull/263

What's new?

Makes constructor private as described above
Changes in Github Actions to support Node16
Replaces Mockery with mock-webserver as we can't mock Guzzle response anymore so we needed a different way to test, hence mock-webserver.
Adds type hinting
Moves the tests into their own separate namespace.

Does this change add any new dependencies? no
Does this change require any other modifications to be made to the repository
(i.e. Regeneration activity, etc.)? no
Could this change impact execution of existing code? yes, if it passes in a pre-built Guzzle

How should this be tested?
This has no real change in functionality, but there are dependant PRs that will be listed above.
Documentation Status

Does this change existing behaviour that's currently documented? no
Does this change require new pages or sections of documentation? no
Who does this need to be documented for?
Associated documentation pull request(s): ___  or documentation issue ___

Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@whikloj , step 1 complete. What's next?

We need to tag a 2.0.0 release of Chullo. I'll create a 1.0.0 release of https://github.com/Islandora/islandora-fedora-entity-mapper. Then I'll update the other PRs where necessary.

Weren't those included in https://github.com/Islandora-Devops/islandora-playbook/pull/263? That is what I used to test, so they should be ready to approve, although the islandora one will need composer.json references updated, right?

Actually I have no permissions on https://github.com/Islandora/islandora-fedora-entity-mapper so if someone could setup the committer teams to have access please.

I tagged a 2.0.0 release of chullo though


Local Events Feed (Happenings) - Revision

@jmmastey I made the Ruby changes you suggested to the application views, but did not spend much time on fixing the CSS. I plan to use pmail for that purpose. Ashton has given me similar comments on my CSS there.

I recognize many of these wallpapers.

Hey, sorry this took so long. Added a few notes, but this looks good! Thanks.


Bump libgit2 to v0.99

Also cleans up:

some deprecations to buffer and assert
ownership model was improperly generated for annotated_commit

Includes PRs from LibGit2:

Release 0.99
Release script
azure: fix ARM32 builds by replacing gosu(1)
openssl: fix Valgrind issues in nightly builds
fuzzers: Fix the documentation
azure: fix misleading messages printed to stderr being
tests: iterator: fix iterator expecting too few items
transports: http: fix custom headers not being applied
azure: fix Coverity pipeline
azure: tests: re-run flaky proxy tests
fetchhead: strip credentials from remote URL
azure-pipelines: properly expand negotiate passwords
cred: change enum to git_credential_t and GIT_CREDENTIAL_*
Update link to libgit2 Julia language binding
Return int from non-free functions
HTTP: Support Apache-based servers with Negotiate
internal types: change enums from type_t to _t
merge: Return non-const git_repository from accessor method
Do not return free'd git_repository object on error
refs: refuse to delete HEAD
index: replace map macros with inline functions
Make type mismatch errors consistent

Includes unmerged PRs:

https://github.com/libgit2/libgit2/pull/5384
https://github.com/libgit2/libgit2/pull/5347
https://github.com/libgit2/libgit2/pull/4205

This is on hold until there is a solution to https://github.com/libgit2/libgit2/issues/5427.

Superseded by #1788.


Sprint 6: Design Starters

Crossover Score: /3.0
Fibo, Extends and Data Modeling

This is a check to see how you have absorbed concepts about Fibonacci and how to use for, while, and recursion.

JavaScript and HTML

Using JavaScript introduction and referring to code for Jokes. Show ability in Jupyter Notebook or JavaScript to process a JavaScript data structure into an HTML presentation.

Design

Establish preliminary design ideas for 1st Trimester project. Create a wireframe and basic plan for 1st Trimester project.

2.7+/3.0

Contributed heavily to design
Fibonacci shows knowledge of concepts of for loops, while loops, and recursion
Like that you had screenshot to show that javascript worked


Feat/1331 disables deduplication for incremental

Description
This PR disables deduplication for the test case described by ingestr here: https://github.com/dlt-hub/dlt/issues/971#issuecomment-1983417044
Related Issues

Resolves #1131

Questions
@rudolfix

I could not understand your points 2, 3, and 4 in the issue #1131 . Are they already implemented in this PR?
I am not sure if the last test tests/extract/test_incremental.py::test_deduplication_on_write_disposition_not_merge makes sense at all because on write_disposition="replace" the table is truncated before the load. I included it because the ticket speaks of the merge write disposition so I wanted to test the opposite too. Feel free to drop this commit.
Are the assertions on the incremental's last_value superfluous?
I could not find a way to test that the incremental returns all values without deduplication. Thus, I implemented the tests by making assertions on the loaded data. Is this strategy fine?

TODO after merge

[ ] notify the developers of ingestr

we implemented smarter way to control deduplication: via open and closed ranges for incremental values. with open lower range the deduplication is automatically disabled (no overlap possible). so we do not need risky change of behavior for merge. thx!

@rudolfix amazing. I'm glad you found a different way that needs less changes! The code that's never shipped is the most bug-free ans fastest too! 😄


Dropdown: Clicking in and out of it after having selected an item automatically selects other

https://react.semantic-ui.com/modules/dropdown
Steps
1- Create a Dropdown with any variation of props
2- Fill in the options whichever way you'd like
3- Select an item from the Dropdown (Important! Bug does not happen if you don't make a selection first)
4- Open the Dropdown again, but this time, click out of it without selecting a new item
Expected Result
Nothing to happen. The selected option stays the same and the Dropdown closes.
Actual Result
Another option is randomly selected and component quickly blinks.
Version
0.75.1

I am unable to reproduce this.  Please use the latest version, 0.77.2, and provide a test case linked in the issue template.

It turned out that it did indeed go away whenever I updated to the latest version.
Thanks!


Question on #228

[#228]
Ref: line 7,  "or in this case and even business mistake in programs or you have some [inaudible 00:01:17] programs to the teams". I deleted this text as without the inaudible comments I couldn't understand it. I think the point is made in the rest of the sentence, but if you want me to add something please let me know.

agree


Add user provided timeouts for slow systems

Solution/Idea
Enable a way for user to provide different timeouts in case system is slow and crc takes more time than default.
Proposed changes
Introduced following env variables

CRC_OC_TIMEOUT
CRC_SSH_TIMEOUT
CRC_CLUSTER_STABLE_DURATION

Testing
To increase CRC_OC_TIMEOUT use following
$ CRC_OC_TIMEOUT=40s crc start

Enable a way for user to provide different timeouts in case system is slow and crc takes more time than default.

Honestly, this is not very enticing to me. Either crc works out of the box, or it does not. If it does not, we need to fix it, or to inform nicely the user that their system is not good enough for crc. These env vars would be useful for testing/debugging purpose, but I'd rather not consider them as something some users should always set themselves.

A test build with this patch would be useful in https://github.com/crc-org/crc/issues/3442 to see if it helps with the issue they are having.

Honestly, this is not very enticing to me. Either crc works out of the box, or it does not. If it does not, we need to fix it, or to inform nicely the user that their system is not good enough for crc. These env vars would be useful for testing/debugging purpose, but I'd rather not consider them as something some users should always set themselves.

Yes it is not enticing or a very clean solution but if there is a dirty way to enable user to atleast start the crc I would prefer that instead completely blocking.

A test build with this patch would be useful in #3442 to see if it helps with the issue they are having.

Added, let's wait for feedback.

Honestly, this is not very enticing to me. Either crc works out of the box, or it does not. If it does not, we need to fix it, or to inform nicely the user that their system is not good enough for crc. These env vars would be useful for testing/debugging purpose, but I'd rather not consider them as something some users should always set themselves.

Yes it is not enticing or a very clean solution but if there is a dirty way to enable user to atleast start the crc I would prefer that instead completely blocking.

I would prefer that we are fully sure what their issue is, and this PR is very useful for that, and then we decide about the best way to help them.

/hold

closing this since it didn't helped the user to run the crc on a slow hardware.


[AutoRelease] t2-sql-2023-03-24-99847(can only be merged by SDK owner)

https://github.com/Azure/sdk-release-request/issues/3990
Live test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1034
BuildTargetingString
azure-mgmt-sql
Skip.CreateApiReview
true

issue link:https://github.com/Azure/sdk-release-request/issues/3990


Identify missing import

In the following case:
Traceback (most recent call last):
  File "solution.py", line 1, in <module>
    p = Path("words.txt")
NameError: name 'Path' is not defined

it would be great if a message like:

You're missing a from pathlib import Path import.

I don't know if there exist clean ways to do it, but auto-generating a dict from all __all__s (~once for all) and using it should work.

In the past, I had thought of doing something like this for a few "common" modules, inspired by Thonny does something like this for a few modules, including turtle. The standard library contains over 200 hundred different modules, with possible some changes depending on which Python version is used. In some cases, including NameError, AttributeError, and ModuleNotFoundError, I do refer to a list of these modules [1] to see if the error might be caused by a typo in the module name.  This does catch "by accident" a missing import for the turtle module in the following example:
[3]: t = Turtle()

Traceback (most recent call last):
  Code block [3], line 1, in <module>
    t = Turtle()
NameError: name 'Turtle' is not defined

        Did you forget to import `turtle`?

[4]: why()

    The name `Turtle` is not defined in your program.
    Perhaps you forgot to import `turtle` which is found
    in Python's standard library.
    Note that the name of the module is `turtle` and not `Turtle`.

I will look into doing this for all names listed in [1]. This might leave out some names available from subpackages (such as os.path) but it would be an improvement.
[1] https://github.com/friendly-traceback/friendly-traceback/blob/main/friendly_traceback/runtime_errors/stdlib_modules.py

New version:
Friendly-traceback version 0.4.80. [Python version: 3.8.4]
Type 'Friendly' for help on special functions/methods.

[1]: set_include('why')

[2]: p = Path('words.txt')

    In your program, no object with the name `Path` exists.
    `Path` is a name found in the following modules from the standard library:
    compileall, pathlib, zipfile.
    Perhaps you forgot to import `Path` from one of these modules.

[3]: import pathlib

[4]: p = Path('words.txt')

    In your program, no object with the name `Path` exists.
    The similar name `pathlib` was found in the local scope.

    The local object `pathlib`
    has an attribute named `Path`.
    Perhaps you should have written `pathlib.Path`
    instead of `Path`.

[5]: BEVEL

    In your program, no object with the name `BEVEL` exists.
    `BEVEL` is a name found in module `tkinter`.
    Perhaps you forgot to write

        from tkinter import BEVEL.

I will close this issue after I commit some unit tests.

Note: the newest version does a better job in identifying similar words and no longer suggest that 'pathlib' is similar to 'Path'.


Added support for SVG attributes

Hi Ryan,
I have added the list of all SVG attributes that don't contain dashes and have added them to the list of properties in your index file. I've also added a test for a rect element with both static and computed values. It does not seem to break any existing tests in the babel plugin either.
Cheers,

Awesome, I will take a closer look this evening. I was debating between 2 approaches. The one you did here, and the other detecting which elements were SVG by tag and just defaulting to attributes generally. The latter is the approach Surplus uses. I think what it's going to come down to me is which has the least potential impact on Custom Elements (Web Components). I think it might be fair to just detect Custom Elements as well.
Basically I see there is a limit to this global attribute thing I've started. If someone happens to name a custom element property the same as SVG property unexpected behavior etc..

Yeah, being able to resolve more compile-time without referencing every attribute seems the best (svg element list). So going to spend more time with this, but it is now near the front of the list. I'm doing some big changes in the babel plugin right now. I expect a solution in the next minor version (0.12.0). But it will probably be a week or so.

I ended up going with the approach mentioned in my last comment so I won't be merging this. Thanks so much for the PR. Basic SVG support is available in Solid v0.10.10 with Babel JSX DOM Expressions 0.11.6.

Hi Ryan, thanks for adding the SVG support in. I'll be using it pretty soon ;-)


Accounts created in portal take longer to show up on our extension

They show up quite quickly (<1 minute) in the portal ('All resources') but requires at least 5 minutes or a restart of the extension for the account to show up.

You're saying that Refresh on a node doesn't pick up the new account?

A refresh doesn't seem to pick it up for 4 min.

It takes a while to create one.  I'd say as long as it does pick it up it's fine.  Probably just Azure behavior.


Firewall Manager Feature Swagger Updates for Public Preview

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Can one of the admins verify this patch?

@ravbhatnagar could you please take a look at this PR?

Signing off from ARM side.


Environment from command line updated twice

Seems that in a76772f79 we've introduced duplicate plan environment update from the command line options.
The first is here:
https://github.com/teemtee/tmt/blob/722563c5e63615d7bd2e2ae2a5979d1254fd0f29/tmt/base.py#L1558-L1562
And the second one here:
https://github.com/teemtee/tmt/blob/722563c5e63615d7bd2e2ae2a5979d1254fd0f29/tmt/base.py#L1676-L1677
Seems it does not break anything but we should get rid of the duplication.

Summary from the hacking session discussion:

move the gathering of imported plan environment to an environment property
make sure self._environment is not being accessed directly in tmt code (property should be used)


Trouble installing expert app

When trying to install the expert app. I get a screen that says set up the bot. When I click the button, I get a message something went wrong. Any suggestions on how to debug this?

Hi @ClarkDRC
Thank you for raising the query, can you please share the screenshot of the error you're getting, did the deployment is successful. If yes please double check the manifest file that you're trying to upload to make sure configuration values are updated correctly.

Thank you @ClarkDRC for sharing the screenshot, can you please check if any exceptions logged in application insights, if so please share the same, this error message doesn't help much.

Actually, I just got it installed. But ran into another issue.

@ClarkDRC Please share your email ID to schedule a teams screenshare meeting to troubleshoot the issue. Also let me know your available time.

<EMAIL_ADDRESS>I am free today and tomorrow. What time zone are you in? I am Eastern US.
From: magurrapu @.>
Sent: Friday, April 1, 2022 5:13 PM
To: OfficeDev/microsoft-teams-apps-faqplus @.>
Cc: Dan Clark @.>; Mention @.>
Subject: Re: [OfficeDev/microsoft-teams-apps-faqplus] Trouble installing expert app (Issue #165)
@ClarkDRChttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FClarkDRC&data=04|01|DanClark%40microsoft.com|d9b0bfe905aa49ab978108da14246216|72f988bf86f141af91ab2d7cd011db47|1|0|637844443746246411|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=8LgN8u03rHAI5R1FUH8OTsiZI5RQC805knM540JVHxU%3D&reserved=0 Please share your email ID to schedule a teams screenshare meeting to troubleshoot the issue. Also let me know your available time.

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FOfficeDev%2Fmicrosoft-teams-apps-faqplus%2Fissues%2F165%23issuecomment-1086329205&data=04|01|DanClark%40microsoft.com|d9b0bfe905aa49ab978108da14246216|72f988bf86f141af91ab2d7cd011db47|1|0|637844443746246411|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=AYeuzxxCnDnTV7PkhvtjChHfMDy4%2F7dDlf8LaOPOAm4%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALWEVGYH63FORU3FKNDMHGDVC5RFHANCNFSM5SGXK4LQ&data=04|01|DanClark%40microsoft.com|d9b0bfe905aa49ab978108da14246216|72f988bf86f141af91ab2d7cd011db47|1|0|637844443746246411|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=sW5GN9Z2DyeJKGz1oQ%2BPLoCK%2BH6AxhC%2FExF9nDtJHCY%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

@ClarkDRC The email ID is masked, please send without masking. I am available tomorrow after12 PM EST

Can we meet at 12:30<EMAIL_ADDRESS>

@ClarkDRC As discussed you redeployed the app and it is working fine now. Please let us know if you have any other queries.


Slow pools page load time, unresponsiveness, and lagging when scrolling on MacOs and Windows devices

I've been using the website on various platforms, including MacOs and Windows devices, and noticed that the page load time is a bit slow. Additionally, once the page loads, I'm experiencing some unresponsiveness and lagging.  As reported internally, adding it here for tracking.
Additional info copied from chat:
This shows on the console on local dev environment:
next-dev.js?36dd:32 Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.
    at Image (webpack-internal:///../../node_modules/next/dist/client/image.js:381:22)
    at div
    at div
    at PoolQuickActionCell (webpack-internal:///./components/table/cells/pool-quick-actions.tsx:74:24)
    at cell (webpack-internal:///./components/complex/all-pools-table.tsx:385:192)

RatePretty, PricePretty takes a long time to process
https://files.slack.com/files-pri/T0263JRR934-F04V10G5W2X/image.png

@JoseRFelix perhaps we can pull out the gauge_by_id query into the render function, then process the rest of the pool list data in the useMemo hook as we had? Would prevent a lot of downstream rendering and data processing.
For a while in stage, it was a lot faster than it is now, but we were running into strange issues with Mobx query objects being called from useMemo hook (causing 3-4x more requests than needed)


Don't validate empty urls for importing

Hotfix for syncs to work. There're services which use service_item_id instead of url, it shouldn't be mandatory.
Will check in staging and deploy.
cc @ethervoid @rafatower

Once pass the tests :shipit:

What's the failing scenario? sorry I missed that

@rafatower this breaks GDrive and Dropbox syncs, which use service_item_id.

I see, thanks for the fix.


fix(modals): Replace focus-trap by focus-lock

Replacing non-friendly to browser focus-trap(it emulates and focus change via onKeyDown(TAB)  handler) by transparent focus-lock (observes activeElement change).
💩

focus-lock is 1.5kb lager than focus-trap (with module concatenation enabled)
I am not sure why smooth-ui package size grown, but I have to increase limits to pass CI

🔥

in Safari tabs will not work as before, _ default _ Safari behavior may require you to press Option+Tab to change a focus, as long it distinguish "links" and "buttons". Now it would work as it should.

@theKashey thanks for that! The PR looks completely broken, a little rebase? 🙏

Not a problem

Limit not 19.5
I don't know why I've got +1.5kb :(

Follow up #69


Use enum type to represent the state of the widget

At debug time, the state of the widget is an int value, not intuitive enough. Should use the enumeration type instead.

Done.


Support Comment API

Fixes #106 Create, Edit and Delete Comments

Codecov Report

Merging #127 into master will decrease coverage by 0.54%.
The diff coverage is 77.27%.

@@            Coverage Diff            @@
##           master    #127      +/-   ##
=========================================
- Coverage   88.44%   87.9%   -0.55%
=========================================
  Files          38      40       +2
  Lines         528     562      +34
  Branches        2       3       +1
=========================================
+ Hits          467     494      +27
- Misses         61      68       +7

Impacted Files
Coverage Δ

...thub4s/shared/src/main/scala/github4s/Github.scala
80% <ø> (ø)
:arrow_up:

.../main/scala/github4s/free/algebra/CommentOps.scala
0% <0%> (ø)

...4s/shared/src/main/scala/github4s/HttpClient.scala
100% <100%> (+10.34%)
:arrow_up:

.../shared/src/main/scala/github4s/api/Comments.scala
100% <100%> (ø)

...4s/shared/src/main/scala/github4s/GithubAPIs.scala
100% <100%> (ø)
:arrow_up:

...cala/github4s/HttpRequestBuilderExtensionJVM.scala
100% <100%> (ø)
:arrow_up:

...cala/github4s/free/interpreters/Interpreters.scala
79.72% <50%> (-3.86%)
:arrow_down:

...scala/github4s/HttpRequestBuilderExtensionJS.scala
81.48% <77.77%> (-5.48%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8233d9...d1f0533. Read the comment docs.


Timelock Contracts Deployment Framework

Summary

RFCs: $\emptyset$.
Categories: scripts

Initializing a proper deployment flow for any Timelocked upgradeability among the Movement settlement stack.
Sample uses MCR but it's applicable to any other contract.
Testing
Script runs against upgradeable MCR. Need to implement for the rest.
A generic implementation is likely not possible.
Outstanding issues
Interfacing with all contracts. If there is any modification on their initialization, deployment flow needs to be updated.

@0xPrimata can you list the commands I need to run the tests locally? CI is failing btw


Error when loading relative import

Using ES6 JSPM, while the bundling seems to work and the application runs as expected, there are errors in the browser console with system.js trying to load components already included in the bundle.
For example if I use the skeleton-es2016 and add a test.js:
export class Test {
  test = "hello world";
}

and modify the welcome.js as follow:
import {inject, computedFrom} from 'aurelia-framework';
import {Test} from './test';

@inject(Test)
export class Welcome {
  heading = 'Welcome to the Aurelia Navigation App!';
  firstName = 'John';
  lastName = 'Doe';
  previousValue = this.fullName;

  constructor(test) {
    this.test = test;
  }
...

When bundled, even as the app is running perfectly and accessing the bundled test.js, I will get:
system.src.js:4597 GET http://localhost/~pascalfautre/Muungo/skeleton-es2016/test.js 404 (Not Found)
If I do import {Test} from 'test'; then I don't have any error.

@Scapal Could you tell us what version of SystemJS and JSPM are you using?

JSPM 0.16.15
jspm_packages/system.js: v0.19.6

I found the problem too. Looking at it now. I keep you updated.

@Scapal can set depCache: false in the bundle config and see if the problem goes away. I think depCache causing a conflict here.

@ahmedshuhel it does indeed solve the problem

I am closing it here. It's a SystemJS bug/constraint. It seems like bundle and depCache cannot be used in parallel.


add Options

Thanks @coderhaoxin
LGTM
ping @parnurzeal

1.) Update README.md telling Gorequest is also suppport this. Sth. like below
Sending request would never been fun and easier than this. It comes with lots of feature:

Get/Post/Put/Head/Delete/Patch/Option

2.) List yourself as one of the contributor in "Contributing to GoRequest" section
Then all good :+1:
Thanks for this!

@parnurzeal thx, done!


There are no samples

Vulkan 1.0 documentation has been released but this repo is still empty. Why so?

This repository is for samples contributed by member companies (and possibly others). There are a couple in flight, but the companies are doing some checks with their legal departments regarding copyrights and licenses. As they sort through that process, some samples should start to populate the repo.
I believe there are also some sample programs in the LunarG Vulkan SDK.

There is still a complete lack of samples here.

 We should get this resolved very soon, at which point we will start to populate this repository. For the time being, I recommend checking out the Vulkan resources page which has references to various demos, tutorials and samples.
https://github.com/KhronosGroup/Khronosdotorg/blob/master/api/vulkan/resources.md

"There is still a complete lack of samples here." +1
I think you don't need to put here complex samples with license issues.
I think will be very usefull to have here examples that show how to use the commands described in the specs. Small examples that cover, one by one, the usage a specific command.
An official starting point for everyone looking for code.

The problem is not that we have complex samples that need special licensing. We went through the process of unifying the licensing as much as possible across all Khronos repositories, including setting up the CLA assistant, to make it easier for everyone to contribute. Unfortunately these things take time.
If you are looking for samples that build up a Vulkan app step by step, then I recommend having a look at the https://github.com/LunarG/VulkanSamples repository which is also listed at https://github.com/KhronosGroup/Khronosdotorg/blob/master/api/vulkan/resources.md

Why can't the examples just be released with an existing easy to use licence like any other repository? Such as the Apache 2.0 license that LunarG is using.
This issue was opened since Feb 17th, if this is a holdup on licencing then perhaps that's typical that all we can expect is another delay after delay as with the release of the API. If you need a license, get a lawyer to draft one up it seriously doesn't take this long to sort out the license for publicly available examples especially when there is an abundance of them already used by everyone else (LunarG has the right idea).

Unfortunately it wasn't quite that simple. Even though the end result may be very similar, we had to make sure that the licensing works for all Khronos member companies. My apologies for any inconvenience this has caused.

My worry is for the possibility of issues like these emerging more frequetly in other areas too, as we start to see more and more delays. It doesn't look good for a graphics API that is being built around becoming the new standard.

The repository has been populated with a first set of samples.


feat(RingTheory/Artinian) : prime ideals are maximal in aritinial rings

prime ideals in artinian rings are maximal

I have a short proof using the fact that an artinian ring (e.g. R/p) surjects onto every localization of itself. Since R/p is a domain, it also injects into its field of fractions, so it's isomorphic to a field and therefore itself a field. Notice that branch contains some irrelevant stuff and only MulEquiv.isField is needed. Feel free to extract the relevant part to this PR; if you do so, please also make a IsArtinianRing (R ⧸ p) instance.


service worker does not work on device

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:

I have just enabled the service worker and it seems to be working just fine in the browser, but after I deployed to an Android device, I see the following:
DOMException: Failed to register a ServiceWorker: The URL protocol of the current origin ('file://') is not supported.

Expected behavior:

Service worker should work on a device.
Steps to reproduce:

Related code:
insert any relevant code here

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
insert the output from ionic info here

Thanks for the issue! We'll look into this soon.
Note to team: see #9990 for more info.

This is actually by design. Chrome/Android blocks service workers from http or file protocols
https://github.com/electron/electron/issues/2831
https://bugreports.qt.io/browse/QTBUG-56169
https://www.w3.org/TR/2015/WD-service-workers-20150625/#security-considerations

@mhartington Ok, so this means that it can only work in the browser? Or is there a way to make service workers work when the app is on a device?
I did read before that they only work with HTTPS protocols due to security concerns. But I also found some info about allowing to set a trusted origin (e.g. for chrome extensions).

Or does Ionic also provide some API for adding trusted origins such as registerURLSchemeAsAllowingServiceWorkers()?

At the moment, service workers will only work in the browser, and through https.
registerURLSchemeAsAllowingServiceWorkers is a low level method when building a browser, so not something ionic is in charge of.

I see. So apps cannot take advantage of this. That's quite unfortunate :|

Yes, but maybe there is cordova plugin that can do this or ionic native plugin? That is what I mean.

it is something that has been brought up before in cordova talks.
Not sure if a plugin would work, but maybe modifying the crosswalk webview could....
Either way, it's something that is known and cannot be handled by the framework.
Closing for now.

But isn't Ionic about mobile devices first and foremost?
Ionic advertises its support for service workers and with some pride: http://blog.ionic.io/tag/service-workers/
I've spent most of the day yesterday setting it all app for what turns out to be a disappointment.
Could Ionic make this clear somehow - as the comms are arguably misleading?
Service Workers are a very desirable feature - built with mobile devices in mind. I think it is in cordova's and Ionic (leading players in the field) to pursue this feature and bring it to the platform?
As a stopgap - and correct me if i'm wrong - service workers should work in ionic/cordova hosted app - where the app's code is served from a server on install (and possibly/smartly cached - with service workers).  Perhaps Ionic could provide a bootstrap setup (similar to https://ionicframework.com/getting-started/) for a hosted app where service workers can actually be taken advantage of..? Just an idea

I agree with @remster. That is the only reason I opened this issue, because it was advertised in blog posts. It could help to specify somewhere in the docs that currently, it is only supported in desktop browsers that support service workers.

@remster The service worker will work when running in chrome and as a web app.

Ionic advertises its support for service workers

Yes because Ionic is just web technology, and there for can integrate service worker.
As for adding integration, I have noted in my last comment that it "may" be possible with crosswalk, but this issue is not the place to discuss that.
We will add a note to the docs about how service worker is https only.

Thanks @mhartington , i would suggest adding a disclaimer to the generated code so it's plain and obvious, like this: ``<!-- un-comment this code to enable service worker (Note: doesn't work on mobile devices!'`
With respect to Ionic being just web technology. Ionic's landing page says:

The top open source framework for building amazing mobile apps.
Ionic is the beautiful, free and open source mobile SDK for developing native and progressive web apps with ease.

I'd like to add that service workers + hosted code have a potential of becoming the first class citizen as they open a very neat, single channel upgrade channel that bypasses app stores. Perhaps that serves to support my suggestion for a hosted app bootstrap/tutorial for a hosted app.

Will make a note of it!

Im just thinking is it really necessary to implement service workers in ionic?
What are the uses of service worker?

Push notification.
Network cache
Background sync

Ans:

There is already native push notification plugin which can be more performant and styles than the web push protocol.
I think we can create a wrapper around angular2 HTTP service to act as network cache like storing the requests and responses in the local storage and then use it if the app is online
I don't know is there any implementation of background sync which will  be used to re play the requests that are stored in local storage.

But im looking for is there any framework or plugin to store the request and responses that are done automatically and use them when the app is offline.

Continuation to my previous comment:-
For point3, actually we can use this plugin http://ionicframework.com/docs/v2/native/network/ and handle the network connection and write a custom code for synchronize the requests/responses to server. But will the plugin work when the app is not in foreground.


[Feature Request] Prevent new window resizing on new process

Mozilla made some :censored: decision to :censored: with the size of the window when a new process is created (no longer maximized, resized to some random anti-user-chosen size) if fingerprint-resistance is on. There's no need for them to do that but they do it anyway. Mozilla, almost as bad as Chrome.
Anyway... I'm wondering if addons are informed of process termination and if they can save a flag and change a setting as a result. I'm curious if the addon can be updated to turn off fingerprinting at shutdown and turn it back on after start to work around the window-resize anti-user-choice.

I'm not sure what result you are trying to get based on what you wrote. The extension has an option to auto-maximize new normal and private windows if that is what you are after:

I just installed LibreWolf 130.0-3 for Windows into a sandbox and the settings seems to work for new windows when I try it. When cold starting the browser the initial window doesn't get maximized which is a limitation on how the API I am using works, extensions are loaded after the first window so the browser.windows.onCreated event won't fire for it.  I might be able to put in a workaround for that. Windows created after opening are getting maximized though. If you are something other than 130.0-3 on Windows then I don't have that to test so I can't see what is wrong.


feat(i18n): update zh-CN texts

update libraries and serial-moitor texts.

@Does anyone is here?

thankyou，urish。I will check again。

hi,urish. How can I solve this requested changes probelm?
I have checked my docs and added a new pull requeset.


flutter deactivate ios push pop  do not execute

(base) say@SaylideMacBook-Pro qlink_flutter_app % flutter --version
Flutter 1.17.2 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 5f21edf8b6 (5 days ago) • 2020-05-28 12:44:12 -0700
Engine • revision b851c71829
Tools • Dart 2.8.3

Flitter life cycle is not good
push pop It is not intuitive to monitor alone
···dart
@override
void deactivate() {
print('deactivate');
}

@120011676
Consider to fill out the issue template completely

@120011676
I hope you've solved the issue.
Closing as additional information isn't provided

@VladyslavBondarenko
flutter 监听返回页面 ,经常会用到这个方法:
``dart
void deactivate() {
super.deactivate();
var bool = ModalRoute.of(context).isCurrent;
if (bool) {
print('处理返回页面操作');
}
}
但是这个方法发现在ios上不会执行 ,原因不详

![image](https://user-images.githubusercontent.com/1992933/86109132-9ef81100-baf6-11ea-9bc6-95725a21ff2f.png)

@120011676
with stable 1.17.1 and master 1.20.0-3.0.pre.100 I see the same behavior for iOS 13.5 simulator and Android 9 (API 28) device - deactivate function is called, but ModalRoute.of(context).isCurrent is already false. Is it the same for you?

code
import 'package:flutter/material.dart';

void main() {
  runApp(MaterialApp(
    title: 'Navigation Basics',
    home: FirstRoute(),
  ));
}

class FirstRoute extends StatefulWidget {
  @override
  _FirstRouteState createState() => _FirstRouteState();
}

class _FirstRouteState extends State<FirstRoute> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('First Route'),
      ),
      body: Center(
        child: RaisedButton(
          child: Text('Open route'),
          onPressed: () {
            Navigator.push(
              context,
              MaterialPageRoute(builder: (context) => SecondRoute()),
            );
          },
        ),
      ),
    );
  }
}

class SecondRoute extends StatefulWidget {
  @override
  _SecondRouteState createState() => _SecondRouteState();
}

class _SecondRouteState extends State<SecondRoute> {
  @override
  void deactivate() {
    print('deactivate');
    var bool = ModalRoute.of(context).isCurrent;
    print(bool);
    if (bool) {
      print('处理返回页面操作');
    }
    super.deactivate();
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text("Second Route"),
      ),
      body: Center(
        child: RaisedButton(
          onPressed: () {
            Navigator.pop(context);
          },
          child: Text('Go back!'),
        ),
      ),
    );
  }
}

Why do you need to check ModalRoute.of(context).isCurrent?

@VladyslavBondarenko
1.A page deactivate
2.B page deactivate
3.A  Navigator.push(B)
4.A page deactivate no execute
5.B page Navigator.pop()
6.B page deactivate execute,A page deactivate no execute
I want to know A page Navigator.pop () is back

@120011676

With this code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MaterialApp(
    title: 'Navigation Basics',
    home: FirstRoute(),
  ));
}

class FirstRoute extends StatefulWidget {
  @override
  _FirstRouteState createState() => _FirstRouteState();
}

class _FirstRouteState extends State<FirstRoute> {

  @override
  void deactivate() {
    print('A deactivate');
    super.deactivate();
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('First Route'),
      ),
      body: Center(
        child: RaisedButton(
          child: Text('Open route'),
          onPressed: () {
            Navigator.push(
              context,
              MaterialPageRoute(builder: (context) => SecondRoute()),
            );
          },
        ),
      ),
    );
  }
}

class SecondRoute extends StatefulWidget {
  @override
  _SecondRouteState createState() => _SecondRouteState();
}

class _SecondRouteState extends State<SecondRoute> {
  @override
  void deactivate() {
    print('B deactivate');
    super.deactivate();
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text("Second Route"),
      ),
      body: Center(
        child: RaisedButton(
          onPressed: () {
            Navigator.pop(context);
          },
          child: Text('Go back!'),
        ),
      ),
    );
  }
}

I can see that on 3. A Navigator.push(B) 4. A page deactivate no execute, but A deactivate is executed when you are using Navigator.pushNamed(B).
Is your issue different from https://github.com/flutter/flutter/issues/50147?

@VladyslavBondarenko yes，#50147 The same problem

@120011676
Then I'm closing current one as duplicate, since https://github.com/flutter/flutter/issues/50147 is older and has more participants, follow up on it.
If you disagree please write in the comments and I will reopen it

@VladyslavBondarenko good,ok

@VladyslavBondarenko Now how do you know the page is back?

@120011676
you can use RouteObserver - https://medium.com/flutter-community/how-to-track-screen-transitions-in-flutter-with-routeobserver-733984a90dea

@VladyslavBondarenko Good,tks


Execute custom construct after cdk resources where deployed

Is there an option how one can determine on which point in time a Custom Construct will be executed?
The behavior I am observing at the moment is:
The custom resource is executed first and then all other resources are created, and the CDK Deploy runs. Would be nice if there is an option to determine at which point in time custom constructs are executed, if there is not already.

Hi @marcotesch,
Do you mean to say you have a Custom Resource for which you want to control at what point in the execution of cdk deploy your Lambda function is actually invoked (in relationship to the other resources that are defined?).
If so, you can do so by adding a dependency between the resources:
customResource.node.addDependency(someOtherResource);

If your question is about something else, I'm going to need some more details on what you're trying to accomplish please.

Hi @rix0rrr,
I'm talking more or less about local execution of something after the complete cdk deploy cycle. And my thought was to achieve that with a CustomResource/CustomConstruct.
It's not about execution/invocation of some Lambda Function during the cdk deploy in this case.

Aha. In that case, the deployment of the synthesized CDK application is the last thing that happens during a cdk deploy operation, and you have no opportunity to execute code locally after that completes.
I think your feature request is a duplicate of https://github.com/awslabs/aws-cdk/issues/922.
In any case, for now you can try to emulate this functionality using a shell script that wraps the cdk deploy command, or run whatever  processing you want to during deployment using a custom resource and a Lambda function.

+1 that this is something we should support at the framework level (I would say through a nice wrapper to a custom resource logic which automatically depends on all other resources)

Would be a very common feature to have something like that in the Framework.
Local Execution could be anything, for my use case typescript would be sufficient, but maybe a shell script would work as well, or any supported programming language the cdk should support.


OCM-7141 | ci: Automate 72514/73431/72520/72522/72526

https://privatebin.corp.redhat.com/?5512312fe7a4882e#3NSfDVRVQCCtbEQ4BGnQ8Ycd8kdzKM2PF5EWNUzZry6z
What this PR does / why we need it:
Day2 negative
Which issue(s) this PR fixes
https://issues.redhat.com/browse/OCM-7141
Change type

[ ] New feature
[ ] Bug fix
[ ] Build
[ ] CI
[ ] Documentation
[ ] Performance
[ ] Refactor
[ ] Style
[ ] Unit tests
[ ] Subsystem tests

Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.

/lgtm

/approve

/retest


Tri 2 Week 6

Performance Task Scoring 2
Model and OOP
View and Frontend
I changed the theme, colors, and made the schedule table on the home page.

.9 Model
.95 View
1 CPT


Bump Ruby versions in AppVeyor jobs

Ruby 2.7 is nearing EOL (in 30 days).
In spite of that drop only older rubies from AppVeyor CI config since Ruby 2.7 is the last series of Ruby 2.

@jekyllbot: merge +dev


jQuery call locally

https://github.com/dnnsoftware/Dnn.Platform/blob/97e12a624147667de66a36d72cad8a170154ddcf/DNN Platform/Providers/HtmlEditorProviders/DNNConnect.CKE/Browser/Browser.aspx.cs#L470
https://github.com/dnnsoftware/Dnn.Platform/blob/97e12a624147667de66a36d72cad8a170154ddcf/DNN Platform/Providers/HtmlEditorProviders/DNNConnect.CKE/Browser/Browser.aspx.cs#L477
Please change the jQuery call locally to make it available on intranet servers

Hi Daniel,
I am agree with Mahmoud.
The HTML editor which is used in DNN (CK) calls two JavaScript's from external resource that two following problems occur on the site:

In some countries access to google cdn is limited and those two files don't load quickly on the page.

In the intranet environment, or machines don't access to the internet, editor does not work as those two external files can not be reached.

So please make the editor use local version of JS instead of hosted versions of them.


unicode-output-in-another-language-sloved

when the community report are generated , many part of the report the result are "title": "\u5343\u6210\u5de5\u696d\u682a\u5f0f\u4f1a\u793e like unicode format.
This is caused by not doing ensure_ascii=False in json.dumps.
I solved this by changing the class FileWorkflowCallbacks in file_workflow_callbacks.py.
#816
Checklist

[x] I have tested these changes locally.
[x] I have reviewed the code changes.
[ ] I have updated the documentation (if necessary).
[ ] I have added appropriate unit tests (if applicable).

We have resolved several issues related to text encoding and JSON parsing that are rolled up into version 0.2.2. Please try again with that version and re-open if this is still an issue.


[Feature] Fuzzy search all messages in all chats

Title is self-explanatory. I wish ChatGPT had this, so I'll add it to this project. But there should be a command palette or a search bar that lets you search through all your chats, this would be very useful. I'll work on an initial PR.

Great idea! I'd also be fine with using a 3rd party lib for the command palette if it's good and has a lightweight payload. I bookmarked https://github.com/rohitpotato/svelte-command-palette a while ago but haven't tried it yet. I'm sure there are also other JS libs that do the same thing.

If nobody is working on this so far, I'd love to get started on the feature

Just submitted a first PR


golangci-linter: enable godoc checks for all new commits

bump golanci-lint version in the github action
switch to revive as golint is deprecated
change lingering nolint: golint to revive

@joe-kimmel-vmw explained:

fetch-depth: '0' as otherwise the tooling will only grab a “shallow” clone from the most recent commit, and be unable to distinguish new code from old code
exclude-use-default: false  iirc the godoc linter is an exclude-list by default, and this enables that linter by not using the default exclude list
new-from-rev: <sha> lets you “grandfather” in all the old changes without godoc comments and only apply linter suite to new diffs (which it can distinguish bc we gave it infinite fetch-depth above).

LGTM and probably easiest to merge relatively soon,  while e0cbac... is still the most recent commit.   or alternatively, may want to consult with the team and make sure everyone with work-in-progress is OK to rebase and/or start adding godocs to their open branches.


Factor the OS name normalization into one place

Is this something you'd be willing to accept?  The only functional change is that you get an error slightly earlier on Windows, but otherwise it just de-duplicates the logic that is used to create the OS short name.

Thanks. It deleted the Windows bypass but I can restore it in a follow-up commit.


Minor framework path issue

Hi, thanks for your work on this library. One minor thing you may want to remove ...there's a local framework path reference that was causing me issues on install.

Cheers
Mark

Nice catch and thank you!


Fixes #120

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Other information:

This doesn't appear to fix the problem in #120. If I'm logged out, I can't see http://localhost:3000/pmuir/settings. There are errors.

Ok, commit updated with changes requested.
Good catch on the logged out point - I hadn't thought through that scenario - I added a couple of guards to neatly handle that.


Cannot connect to another peer

I used ipfs-desktop (non-LAN) on two computers, connecting ipfs from one computer to another computer, err:Could not connect to the provided peer. Can you tell me why?

I'm moving this issue to IPFS Web UI so we can improve the message of error by adding the peer address. However, this won't fix the initial issue which is not being able to connect to the peer as that is not related to either IPFS Desktop, nor IPFS Web UI. Nevertheless, please refer to https://github.com/ipfs-shipyard/ipfs-desktop/issues/1042 too!


@react-aria/optimize-locales-plugin does not work on Windows

Provide a general summary of the issue here
When using esbuild and adding the following entry to plugins:
optimizeLocales.esbuild({
  locales: ['en-US'],
})

I get the following error:
X [ERROR] Do not know how to load path<EMAIL_ADDRESS>
    node_modules/react-aria-components/dist/intlStrings.mjs:1:32:
      1 │ import $bK1z9$arAEmodulejs from "./ar-AE.mjs";
        ╵                                 ~~~~~~~~~~~~~

This is due to this line: https://github.com/adobe/react-spectrum/blob/e14088a7edc44422a1135a9412a99cbbc96c1518/packages/dev/optimize-locales-plugin/LocalesPlugin.js#L27
Windows uses backslashes so if you simply concatenate strings you'll get malformed paths. You need to use the node path module.
🤔 Expected Behavior?
It should not throw errors.
😯 Current Behavior
It throws an error because the path is malformed.
💁 Possible Solution
Use path.join or path.resolve.
🔦 Context
No response
🖥 Steps to Reproduce
You just need to run esbuild with the plugin on Windows.
import {build} from 'esbuild';
import optimizeLocales from '@react-aria/optimize-locales-plugin';

build({
  plugins: [
    optimizeLocales.esbuild({
      locales: ['en-US', 'fr-FR']
    })
  ]
});

Version
@react-aria/optimize-locales-plugin v1.1.3
What browsers are you seeing the problem on?
Other
If other, please specify.
Node v21.7.1
What operating system are you using?
Windows 11
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

Thanks for reporting, I think we can solve this using node's pathSep/path.join to handle this for us. Are you willing to submit a PR?


Improve JsonEncoder efficiency

The performance is really bad compared to for an example Gson. We might want to change to that system if we are going to use this in for an example a REST API.

I may be completely out of it here, but should Speedment really handle JSON? I guess there could exist a plug-in that adds toJson() methods to each entity, but it feels strange that the Speedment core would handle this. Not sure which component you use for JSON, but if you would use Gson for example, I see two issues:

The Speedment dependency tree gets bloated
People might have some other (incompatible) version of Gson

That is a good point. The reason we added our homegrown toJson() was that we found that many new users spent more time on formatting their JSON output than they did learning the framework. This was the cast for the Build a Social Network tutorial for an example.
We could just drop the toJson()-method and let the user use Gson or any other library instead. That would clean up the generated entity classes a bit. A problem I see with this however is that you often want to manipulate certain fields before sending them. In Social Network for an example we have the "password" column in the database that we don't want to expose. We also need to inline certain elements retrieved using foreign keys. If we use Gson we would have to create temporary classes for serialization to control the structure of the output.

Yeah, I've seen it. I understand that it's easier to get started with Speedment if things like this exist, but it's not a good enough reason in my point of view. :)
Hmm, true, there are some issues with that. But how about my other suggestion? Using a Speedment plug-in for this? A plug-in that simply adds the #toJson() method, just like it's done today. Then you would only need a dependency on Gson (for example) if you want to utilize that plug-in. This plug-in could be used for in your Social Network tutorial.

I think the best solution for this is to remove this from the runtime module in 2.4.0 Forest and instead supply a plugin that enables you to parse entities into JSON.

This is now fixed in branch develop-modules.


Most pub tests fails in debug mode

How to reproduce this issue:
tools/build.py -mdebug create_sdk
tools/test.py --mode=debug --compiler=none --runtime=vm --arch=ia32 --use-sdk --checked pub
I am racking a new debug builder for pub, pkg and doc - I will temporarily disable running pub in debug mode until this is solved. Let me know if we need anything from infrastructure to enable this.

This issue has been moved to dart-lang/pub#965.


Slash deployment

is there any prerequisites for the slash to be deployed globally? it says so in the logs but i only have it in my local server. this bot is configured to work with slash from before

Hi! If debug mode is disabled, slash commands are deployed to all servers Blanco is a part of.
If it's not showing up in your servers, either not enough time has passed (sometimes it takes a few minutes), or Blanco doesn't have the applications.commands scope, or maybe the bot just needs a restart.

yeah ill give some time. will reopen if something comes up

yo, while waiting for deployment, i tinkered with the dashboard. i managed to get spotify oauth to work but not last.fm and the delete acc button

For Last.fm, ensure your API credentials are correct and that you specified <BASE_URL>/lastfmtoken as your callback URL. Please create a new issue for that and provide any logs and error messages you may have.
I'm currently working on the account deletion - I forgot to include it in 0.4.0 😅 I wasn't expecting anyone else to be deploying Blanco, sorry. It's quiet around here. Thanks for bringing this to my attention!

@neptalu0 Account deletion seems to be working with the new build from d78cc10, can you try redeploying with ghcr.io/jareddantis-bots/blanco-bot:pr-27?

oh im sorry! im using replit for this. i dont know how to use docker! how do i test the pr?

eyyy! we made some progress. you missed the part where unlinking last.fm leads to 400 "unknown service: lasfm" and yeah while it. worked on binding, nowplaying still says log in to last.fm to scrobble as you listen

update on 10am: slash is deployed. i disabled the server and everything works well

update 12:49pm: binding a spotify acc then switching accs later breaks something on spotify_private.py causing /playlists to always return "You have no playlists saved."

update 12:49pm: binding a spotify account then switching/binding to another account later breaks something on spotify_private.py causing /playlists to always return "You have no playlists saved."

@neptalu0 Can you check your App Status under the app settings in Spotify Developer Dashboard? If it says Development mode, unfortunately you'll have to invite users into your Spotify integration using the User Management tab in the same page for Blanco to read their playlists. This is a Spotify-mandated policy.
If it says Granted quota extension, please open a new issue and provide any logs you may have, preferably while Blanco's debug mode is enabled.

oh yeah i was bugged about the development status on spotify apps dashboard and thought it hinders something from the bot. it really is. yeah that was the issue. ill just hide the spotify buttons on nowplaying and webdash

I'll consider exploring Spotify's API to see if there's a way to get someone's public playlists, which shouldn't require the quota extension. I'll also look into the Last.fm unlinking in #28.
In the meantime, you can also comment out the @slash_command(name='playlists') decorator in cogs/player.py to disable the command.

oh also. i tried purging blanco.db, binded an acc, ran /playlists (which worked), then later unbinding the spotify. running /playlists again which should now redirect me to dash still shows previously binded acc's playlists


refactored backend for easier configuration, Added docstrings & applied better debug messages

Here's what I did:

Refactored backend code for better configuration(inspired by django)

added settings.py in root directory (store all your configurations and .env data in it)
added .env.example which contains basic secrets
added routes/routes.py for route constants to be used in main.py

Added proper docstrings to most of the classes, methods and functions
Added system for better debug messages✦

✦ terminal_colors.py class contains color configurations for stdout messages. I used them in debug messages all over backend and made them runnable only when DEBUG in .env is set to True

Hi @Blankscreen-exe whats the status here?

doing a fresh start here


Support DryRun (&/or other ginkgo options)

Describe the solution you'd like
The ability to customize the plugin to accept additional args to ginkgo. My specific use case in mind is to support dryRun but others may be useful too.
Anything else you would like to add:
Two reasons for desiring this:

The reason for desiring this is that if you are setting up a CI flow or otherwise tinkering with scripts you may need tot call out to sonobuoy and want to have realistic behavior but not wait for the long set of tests to complete.
Lots of use cases while developing may require you to investigate what e2e tests exist, which ones you're testing, which ones you're not, etc etc. Looking through the raw codebase for this is nearly impossible and generally I've had to manually run ginkgo to accomplish this. Maybe your conformance tests are failing and you're trying to figure out if these failures are suddenly showing up. Maybe you're curious how many/what alpha storage tests there are so you know what to plan for. etc etc.

If running ginkgo was simple then I wouldn't be so concerned with this, but multiple people on the Sonobuoy channel have asked about this and my description was pretty lengthy. Requires cloning k8s, using that to build the test binaries for your platform, installing ginkgo, and then figuring out the flags.
It would be much simpler to be able to do all this via sonobuoy since it already has the repo, the test binaries, ginkgo, and knows how to communicate your test regexps to ginkgo.

This is an upstream issue now since we want to move to the upstream kube-conformance issue. See #593


Fix signature verification at fork boundary

Motivation
Fix signature verification at fork boundary
Description
Closes #2623
Steps to test or reproduce
./bin/lodestar beacon --network oonoonba

Got through fork boundary


Password in board.cfg should be encrypted [REPLACEMENT ISSUE]

The original issue
Id: 1168
Title: Password in board.cfg should be encrypted

could not be created.
This is a dummy issue, replacing the original one. It contains everything but the original issue description. In case the gitlab repository is still existing, visit the following link to show the original issue:
TODO

In GitLab by @sokril on Nov 8, 2019, 08:20
assigned to @wknet123

In GitLab by @luotian-github on Mar 4, 2020, 12:09
assigned to @JackZxj and unassigned @wknet123

In GitLab by @luotian-github on Mar 4, 2020, 12:09
assigned to @tongjianli and unassigned @JackZxj

In GitLab by @luotian-github on Mar 4, 2020, 12:09
will fix it in 3.0

In GitLab by @luotian-github on Mar 31, 2020, 09:11
will not fix it in 3.0

In GitLab by @luotian-github on Jun 24, 2020, 03:23
to 7.6


Add hide-visually mixin

Hides an element visually while still allowing the content to be accessible to assistive technology.
A great use-case is one I recently came across on Administrate: https://github.com/thoughtbot/administrate/pull/416

:+1: Good call

:+1:

We should have a designer talk on accessibility some Friday.

This has some applicability, such as 'skip to content' actions e.g. 'tabbing' on the gov.uk site. Perhaps that means there's a case for a unhide-visually mixin?
Have you considered using aria-label on elements that simply require a label?

@LkeMitchll Great points; thanks!
So, unhide-visually would easily “undo” the hiding, and a good time for that might be on :focus.

Yea, exactly. It saves having to build some JS or resorting to using display: hidden. It may also be useful when using the @media speech type.
Although if you think there's a better name for it that might be good. 'Unhide' feels a little weird. Not sure.

@tysongach The clip property has been deprecated in favor of clip-path

@corwinharrell Ah, yes! Thanks for bringing that up. I looked into it, but failed to mention that in my original PR comment.
clip is indeed deprecated (https://developer.mozilla.org/en-US/docs/Web/CSS/clip), but it still has insanely good support.
clip-path is the newer property and is intended to replace clip, but it still doesn’t have great support (http://caniuse.com/#feat=css-clip-path). It also doesn’t have as quite of a clear syntax, though it is more powerful.
We could add another line to the mixin, to also include clip-path, in the event that clip gets deprecated in a browser:
@mixin hide-visually {
  border: 0;
  clip: rect(1px, 1px, 1px, 1px);
  clip-path: circle(1px at 1px 1px); // add this
  height: 1px;
  overflow: hidden;
  padding: 0;
  position: absolute;
  width: 1px;
}

:+1: to @LkeMitchll for a show-on-focus mixin to complement this (especially for skip to content links).

Okay!
So, I added clip-path—per my comment above—to be a bit more future-friendly and account for when browsers decide to drop the now-deprecated clip property.
Regarding “un-hiding” content on :active/:focus, I came up with two approaches:

Use two mixins. For example, something like hide-visually and unhide-visually:

@mixin hide-visually {
  …
}

@mixin unhide-visually {
  …
}

// example use
.hide-visually {
  @include hide-visually;

  &:active,
  &:focus {
    @include unhide-visually;
  }
}

http://codepen.io/tysongach/pen/dGmpyw?editors=1100

Use one mixin which defaults to hiding, but you can pass it an argument to unhide:

@mixin hide-visually($toggle: hide) {
  @if $toggle == "hide" {
    …
  } @elseif $toggle == "unhide" {
    …
  }
}

// example use
.hide-visually {
  @include hide-visually;

  &:active,
  &:focus {
    @include hide-visually(unhide);
  }
}

http://codepen.io/tysongach/pen/XXEjKE?editors=1100
Personally, I like Option 2 because it means we don’t have to maintain two mixins which are highly connected to each other (one “undoes” the other’s styles). I also think Option 2 is generally gives more awareness to what is going on (again, one “undoes” the hiding).
I also purposely didn’t bake the :active/:focus pseudo-class selectors into the mixin because I think it limits the possibilities for where this mixin can be used, and it also makes it a bit more unclear as to what the mixin is outputting (which, if we did include these selectors, would be quite a bit).
I went ahead and pushed Option 2 here to this PR, but I’m happy to have a discussion and hear people’s thoughts!

@tysongach I agree on option 2, plus it appears to follow a similar convention to backface-visibility(visible).


23.01 - DHCP Table shows all leases online = false

Describe the bug
Sorry if Issues are not allowed for pre-release but I figured it'd be helpful to know.  The DHCP table shows all leases as "online=false" even when things are online.  We use this pretty extensively to assign static IP addresses to devices plugged into specific ports on our switches... thousands of them.
To Reproduce
Steps to reproduce the behavior:

Go to /api/v1/services/dhcpd/lease?state=active
Observe all leases have the attribute "online=false"

Expected behavior
I would expect the devices that are online and accessible to have the attribute "online=true"
Screenshots or Response
{             "ip": "<IP_ADDRESS>",             "type": "dynamic",             "starts": "2023/04/17 15:09:13",             "ends": "2023/04/17 17:09:13",             "mac": "c8:05:06:00:17:f7",             "online": false,             "hostname": "host1",             "state": "active"         },         {             "ip": "<IP_ADDRESS>",             "type": "dynamic",             "starts": "2023/04/17 15:09:09",             "ends": "2023/04/17 17:09:09",             "mac": "c8:05:06:00:07:d6",             "online": false,             "hostname": "host2",             "state": "active"         },
pfSense Version & Package Version:

pfSense Version: 23.01-RELEASE (amd64)
Package Version: https://github.com/jaredhendrickson13/pfsense-api/releases/download/v1.6.0_devc01a130595fc4edd1b/pfSense-23.01-pkg-API.pkg

Affected Endpoints:

URL: /api/v1/services/dhcpd/lease

Hey!
Issues are definitely welcome for pre-releases! The internal identifier for online DHCP leases may have changed in pfSense so the API is no longer looking for the correct online identifier. Can you run the following command under 'Execute PHP Commands' in the Diagnostics > Command Prompt webConfigurator page and post the output here?
var_dump(system_get_dhcpleases()["lease"]);

Feel free to scrub any sensitive values like IPs or MAC addresses. Mainly looking for what is shown in the online field.
Thanks!

@jaredhendrickson13
Also hitting this issue. I have attached the output of var_dump(system_get_dhcpleases()["lease"]); only showing the online field. Let me know if this is not sufficient and I can massage the output further to include more of it.
output2.txt

@sjafferali thanks for providing that. I'll take a deeper look later today but I think I see the issue already. The keywords used for the online field have changed so the comparison the API makes no longer works. Seems like we'll need to make this a string field rather than a boolean.


Add support for<EMAIL_ADDRESS>

Wagtaill v2.2.2 removed a lot of clutter from templates and moved them to the Media class in forms/widgets. This PR adds support for that version.
Commit with the "regression": https://github.com/wagtail/wagtail/commit/fe99aca27b2537ab92b86a3006fe5ce7cb781f56#diff-3c87c9d60deca4265e87fc74574e7251
Send me a Slack message if you want to discuss a bit about the project being blocked by this (and not in this public PR).

I don't have much to say. If 2 lines get this working and it's what the new version wants, then I approve.

Thanks!


Autoformat code using black

ruff is an up-and-coming linter and quite hot at the moment. Its claim to fame is being extremely fast and unifying many tools in one. It supports the functionality of flake8, isort and black. Might be worth a look, while we are working on this topic.

@Qup42 Thanks a lot for the hint. I read a bit about ruff and I am in favor of using it. Our current format check does:
for PY in $(find src test -name "*.py"); do printf "$PY ... "; black --check $PY && flake8 $PY && python3 -m py_compile $PY && isort -c $PY && echo "OK"; done

How would you replace that?

The command to check would then be ruff format --check && ruff check && python -m compileall src. I've also taken the liberty to add a commit with a ruff config file and a pre-commit hook config.


Can't input a2 and a4

In the current incarnation, the recalculate function is called after a2 and a4 are modified by the user. This results in a2 and a4 being overwritten and the user never getting to see what the desired plot actually looks like.

Fixed in latest commit.


Only insert barrier after assert for tensor conditions

This avoid problems when there are asserts in reduction/scan regions.
Thanks to @peterbell10 for the suggestion.

Actually I realize now asserts should always take a tensor:
def TT_AssertOp : TT_Op<"assert", [MemoryEffects<[MemWrite<GlobalMemory>]>]> {
  let summary = "Device-side assert, as in CUDA for correctness checking";
  let description = [{
    `tt.assert` takes a condition tensor and a message string.
    If the condition is false, the message is printed, and the program is aborted.
  }];
  let arguments = (ins TT_Tensor:$condition, StrAttr:$message);
  let assemblyFormat = "$condition `,` $message attr-dict `:` type($condition)";
}

I'm now wondering how it works within a reduction region. Do we have example somewhere?

Hrm okay, an example can be the kernel in test_side_effectful_reduction. I guess we probably promote scalars to tensor in the frontend. Would it be unreasonable to add support for scalars?

I guess the region verifier isn't strong enough, but really I don't think any op that has a RankedTensor type should be allowed inside a reduction region.

yeah I agree, I don't think there is any reason why the condition has to be tensor. I'll try to fix that part


[Improvement][common] Remove redundant PropertyUtils.class

We are flooded with too many PropertyUtils.class, in my opinion, there is no need, therefore, it is best to keep only the common-model.

pls assigne to me


mgmt-routes not supported

This is a big restriction given that if TMM has a default route then there is no outbound connectivity from the management interface. This includes using the OS::Heat::WaitCondition mechanism necessary in many cases.

Another problem (potential in this case) is that <IP_ADDRESS> is not accessible either after configuring TMM's default route. Also note that the following is not allowed as workaround either:
root@(bigip1)(cfg-sync Standalone)(ModuleNotLicensed:Active)(/Common)(tmos)# create sys management-route <IP_ADDRESS>/32 network <IP_ADDRESS>/32 gateway <IP_ADDRESS>
01020062:3: IP Address <IP_ADDRESS> is invalid, link-local address not allowed.


Compilation warning when using powertools logging utility

What were you trying to accomplish?
Compile a Java lambda using the Powertools logging utility without receiving compilation warnings.
Expected Behavior
No compilation warning when compiling.
Current Behavior
We introduced the powertools logging utility to our lambdas, compiled with Gradle. We're using the AspectJ Weaving Plugin to
bring in the package.
Now, when compiling the Java for each lambda in the project we receive a warning:
[warning] no match for this type name: SqsLargeMessageAspect [Xlint:invalidAbsoluteTypeName]

I’ve found the SqsLargeMessageAspect class defined in the powertools-sqs package - but we’re not using it. I’ve tried including it in the project to see if it helps with the warning, but it doesn’t.
The only other reference I can find to it is in software.amazon.lambda.powertools.logging.internal.LambdaLoggingAspect where it’s declared in a DeclarePrecedence annotation.
Steps to Reproduce (for bugs)

Clone https://github.com/alphagov/di-ipv-core-back
Run ./gradlew clean :lambdas:select-cri:compileJava
Observe warning

Environment

Powertools version used: 1.12.2
Packaging format (Layers, Maven/Gradle): Gradle
AWS Lambda function runtime: java11
Debugging logs

How to enable debug mode**

> Task :lambdas:select-cri:compileJava
/di-ipv-core-back/lambdas/select-cri/build/classes/java/main/uk/gov/di/ipv/core/selectcri/SelectCriHandler.class [warning] no match for this type name: SqsLargeMessageAspect [Xlint:invalidAbsoluteTypeName]
(no source information available)
        [Xlint:invalidAbsoluteTypeName]

1 warning

I'm also facing the same error locally, with 1.12.3.

This has been fixed in v1.13.0


TypeError: cb is not a function

when I want to use react-native-css like this
react-native-css ./styles/css/new.css ./styles/js/style.js

then
/Users/lxxyx/.nvm/versions/node/v5.8.0/lib/node_modules/.react-native-css_npminstall/react-native-css/1.2.29/react-native-css/build/index.js:58
          cb(styleSheet);
          ^

TypeError: cb is not a function
    at /Users/lxxyx/.nvm/versions/node/v5.8.0/lib/node_modules/.react-native-css_npminstall/react-native-css/1.2.29/react-native-css/build/index.js:58:11
    at tryToString (fs.js:414:3)
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:401:12)

I had try sass scss and css
but i got same question.
My OS is mac osx 10.10 and node.js 5.7/5.8(5.7,5.8,4.4LTS got same question)
Thank you

@Lxxyx I will look into this

@Lxxyx this was an oversight from myself, I have pushed a fix. I will add tests that will cover this scenario so that it wont happen in the future.

@Lxxyx<EMAIL_ADDRESS>

@sabeurthabti Ok,Thank you~


non-sudo installation places main binary outside common PATH

I've noticed that batterym.desktop file has Exec set to just batterym and it worked when main app binary installation path was set to /usr/local/bin. But non-sudo installation places app into ~/.local/bin/ which is usually not a part of PATH env var.
Please consider using full path or adding appropriate informational message to README.
Thanks.

Do you mean that with sudo and installation path /usr/local/bin running in command line just batterym will always run an application. But with non-sudo and installation path ~/.local/bin/ it will not always be the case?
What does it depend on then? OS? Where can I read about that?

I mean that /usr/local/bin would most probably be a part of user PATH var almost on every linux distro. And I've never met ~/.local/bin/ to be in PATH without the need to add it to PATH manually.

Perhaps it would be best to put it in $XDG_BIN_HOME if set?


Refactor var and error text fix in pyrsia_central_node

Description

This PR performs a minor refactor on a variable typo in the Pyrsia central node, and fixes a typo in error output text.
Screenshots (optional)
PR Checklist

[x] I've read the contributing guidelines.
[x] I've read "What is a Good PR?"
[x] I've included a good title and brief description along with how to review them.
[ ] I've linked any associated an issue.

Code Contributions

[x] I've built the code cargo build --all-targets successfully.
[x] I've run the unit tests cargo test --workspace and everything passes.
[ ] I've made sure my rust toolchain is current rustup update.

Interesting. In my fork, one of the tests failed, but that same test worked for me locally:
test node_manager::handlers::tests::disk_load_test ... ok

Will see what this does when these actions are triggered 😁 🤞🏻


Petar will help working on our OpenSource projects

Petar will help working on our OpenSource projects

For new organization members
I acknowledge that

[x] I have read and understood the Open Source Guidelines
[x] I agree to act accordingly (with due dilligence) to our guidelines
[x] I have no open questions regarding the topics covered


[Wayf 99] css cleanup

Description
This PR includes the following proposed change(s):

Updated reusable Button component to make handleClick optional and made size prop change sizes depending on "sm, md, lg"
Updated Header Component to use media queries to make everything fit in mobile view
Updated Home component for Button layout
Updated Settings view to roughly style the settings (not final)
Updated SplashScreen to use the Vertically stacked BC logo to make it align better
Added Vertically align Logo to the vite config
None of the styles are final, but hopefully a good base to work off of and refine

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactoring / Documentation
[ ] Updating Testing Framework(s)
[ ] Version change

How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Frontend Development Changes

[ ] N/A
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to project documentation or diagrams that reflect my changes
[ ] New and existing unit tests pass locally with my changes
[x] My code follows Airbnb React Style Guidelines

API Development Changes

[x] N/A
[ ] I have performed a self-review of my own code
[ ] My code follows standards and practices outlined in the BC Government API Development Guidelines
[ ] New and existing unit tests pass locally with my changes
[ ] My changes includes Swagger documentation updates that reflect the changes I am introducing

This looks good overall. Be sure to check your use of px units, these are not responsive. Sometimes px units are great (e.g. PDF output templating); however, most of the time you will want things to respond to changes in the document (em) or parent element (rem) font-size

With regard to the work done in the 'views' directory, in the future, try to separate (into another ticket) those types of changes as the PR title doesn't indicate that those changes are occuring.


Increment versions for azurearcdata releases

Increment package versions for azurearcdata releases

API change check
API changes are not detected in this pull request.


Transparency blending handled differently compared to not using EffectComposer

Description of the bug
When using EffectComposer, transparent blending looks differently compared to using no post effects.
Thus, if you are using the same scene and render it without post effects on mobile and with post effects on tier3-desktops the scene looks quite differently.
Is there any way to work around this?
A pink cube on top of a grey one.
With EffectComposer

Without EffectComposer

To Reproduce
https://codesandbox.io/s/post-processing-and-layers-forked-4p2czd
Expected behavior
Normal Blending with or without EffectComposer should look the same.
Library versions  / OS used

Three: 146
Post Processing: 6.29.1
Windows, Mac, iOS, Android

Thank you - is there a way to render "incorrectly" when using postprocessing so that both render pathes look the same?

I don't think so. The built-in materials in three only convert colors to sRGB inside the shader.s when rendering to the canvas. There is currently no way to force three to do this when rendering to a render target which would be necesssary to emulate the incorrect output.

ok, got it - thank you very much vanruesc.


Use numerators instead of filledNumerator for consistency

So in this case the numerator refers to the amount that's currently being fulfilled, while filledNumerator refers to the total amount that will have been filled. By way of example, if you have an order that's 1/3 filled, then you fulfill another 1/3, then numerator will be 1, filledNumerator will be 2, and denominator will be 3 (and items will all be scaled down to 1/3 of their original amounts during fulfillment, not 2/3rds). Agree that the naming is not great, particularly as the section above uses filledAmount as a representation of the amount being filled (and it's not until the numerator is added back that it represents the whole filled amount).

So in this case the numerator refers to the amount that's currently being fulfilled, while filledNumerator refers to the total amount that will have been filled.

I'd say this was a test for you or the tests to catch a "convincing" PR. It at least failed on tests.
Truth is I missed one line 😅

Closing this one, we can reopen a new one if there's a good way to improve on this section


Extend "click to expand/collapse" action on the whole alert group header?

Hi,
thank you for Karma! When expanding (or collapsing) alerts I wish the area to do so would be bigger instead of the caret only on the right hand side. Perhaps the whole alert group header should be clickable to expand/collapse, what do you think?

IMHO given that the header contains clickable elements having it all clickable would increase the chance of miss-clicks.
I'd rather expand the area around those icons so they are proper buttons.

Good point re: misclicks, increasing the expand/collapse button area SGTM!


Unable to determine reason for read failure/exception

if the reader fails, for example a file that does not exist is passed to FlatFileRecordReader, an exception is logged, but, there is no way to programmatically find the reason for the failure. The exception should be stored in the Job report.

Hi,
Good idea indeed, I'll add the last error in the job report to be able to get it programmatically when the job is aborted or failed.
Regards
Mahmoud

Hi,
I've added the last error (if any) in the job report. you can get access to it programmatically with jobReport.getMetrics().getLastError(). You can give it a try in the 4.1.0-SNAPSHOT version.
Looking forward for your feedback.
Cheers
Mahmoud

I'm preparing to release v4.1 including this fix.
If you have any issue, please file a bug.


ci,internal: update ubi7 -> ubi8

Description of the change: ubi7 -> ubi8 for all ci files.
Motivation for the change: some missed image updates from #1952, which are required in prow CI.

/lgtm


Add tuple range for ParameterInformation.label

VS Code has addressed the issue of using a string label for ParameterInformation by allowing an offset range as a tuple. This should also be incorporated into the LSP.
See  Microsoft/vscode#56337

Addressed in 3.14.


Show values, not types, for pixels

See https://github.com/timholy/Images.jl/issues/224#issuecomment-64386974

Hrm, this issue just came up again. I was able to trace it down to the way I was slicing.
Starting with a Gray Image with data 512x512x192 Array{Gray{UfixedBase{Uint16,16}},3}, if I slice with sliceim(img, "t", 2), I see this issue.  The resulting datatype is:
512x512 SubArray{Gray{UfixedBase{Uint16,16}},2,Array{Gray{UfixedBase{Uint16,16}},3},(UnitRange{Int64},UnitRange{Int64},Int64)}
(btw, that's a mouthful!)
The weird thing is that it almost looks like I'm getting 192 pixel values for every pixel location.  I saw this while println debugging in the REPL.  Notice that the pixel location is only at the top of the list.  I didn't count, but I'd guess that the next time I see a pixel location is 192 rows later.  Shouldn't sliceim be dropping the singleton dimension?
If I slice using img["t", 2], all is well when I view the result.

Ok, I think this is a real issue that's unrelated to this one.  I'll open a new issue.


[LIVE-3636] Support: Add magnitude to TRC transactions specs

📝 Description
test
❓ Context

Impacted projects: ledger-live-common
Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-3636

✅ Checklist

[ ] Test coverage
[x] Atomic delivery
[x] No breaking changes

📸 Demo

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

closed for better branch naming.


Implicit swSrc and swDest based on the Rollup compilation

The previous interface required that you set swSrc and swDest options when using the plugin, just to add them to the globIgnores value so that they're not precached.
The primary motivation behind this PR is to infer all of the relevant input and output files for the current Rollup compilation (which should be all the files associated with the service worker), and implicitly add the corresponding glob patterns that will exclude them to the globIgnores option.
This should lead to a cleaner interface, like:
const workbox = require('rollup-plugin-workbox-inject');

module.exports = {
  input: /*...*/,
  output: /*...*/,
  plugins: [
    workbox({
      globDirectory: 'public'
      globPatterns: [
        'css/**/*.css',
        'js/**/*.js'
      ]
    })
  ]
}

I also fixed a few issues with the previous version's code that I came across while trying out different usage scenarios.

The latest commit adds in prettyBytes and also throws an Error when there is no match for injectionPoint in any output file.


Mark tests requiring network

Is your feature request related to a problem? Please describe.
All Linux distributions I know about (and perhaps even the non-Linux ones) build their packages in the environment which is isolated from the network.
Describe the solution you'd like
This patch add network marker tests which require network, which makes it then trivial to skip all those tests.

Would you make a PR out of this please?

Sorry, I am a maintainer of couple of hundred python-related packages in openSUSE. I just cannot keep git repos for all of them.

Actually, I think I have even better solution in
this patch and then fixing it with one sed command.

Can you rebase your patch on latest main release?

That’s just laziness.

In that case, I'll close this for:

lack of interest,
lack of contribution,


docs: fix typos in animations-overview

Hey Fernando,
Just a few typos on that page.
Keep it up, it's great

Thanks, good catch!


Allow changing background image

It would be nice to have the feature to change background image for the homepage.
Concerns:

[ ] color contrast (maybe a font color option tweak first?)
[ ] brightness/darkness of background image
[ ] shadows on some of the elements

Pull requests welcome :')


Taxon facet: Move from "Sub-topic" to "Subtopic"

[!WARNING]
This shouldn't be merged until just before the new UI is released (feature flag is switched), otherwise it might impact analytics.

This is our preferred spelling and should be reflected across the entire UI.

I did a search and found one usage in application code
Serves me right for case-sensitive searching 🤦 Fixed!


API Authentication

Installation of Oauth or JWT to authenticate users.
Possibility to view a list of registered users connected to a client, to see one in particular, and to be abble to add or delete users.
Time Estimate : 3 days.

Oauth authentication is now implemented and working.

Installed and configured FOSOauthServerBundle.
Created two controllers: SecurityController and UserController.
Modified controllers route to now use /api/ as a prefix for the API (see BileMo_doc.md).
Created 5 entities and their repositories : AccessToken, AuthCode, Client, RefreshToken and User.
Created UserProvider in the Security folder.
Created CreateClientCommand in the Command folder to generate a command line to register a new client.
/register allows users to register.
/users and /users/{id} allows you to see users.
/user/me allows the user to see his informations.
You can delete users with DELETE /users/{id}.
Chose to authenticate using either Authorization code Grant, Implicit Grant or Resource Owner Password Credentials Grant.
Modified config.yml, routing.yml, security.yml and services.yml.
Updated the Documentation, the UML diagrams and the README.

This API is now mostly features complete. The only thing left to do is to add roles to users so only an admin can delete another user. For now, any user can do it.
Then, i will verify that everything is working correctly and that the diagrams, the documentation and the README are correct.
Done in : 5 days.


Mail 'from' option shows no effect

Issue Summary
When I try to sign up I get an error "Failed to send magic link email" and looking in the log it shows an error.
I host the ghost blog at the subdomain blog.domain.de and want to send from<EMAIL_ADDRESS>I have added the "from" attribute to the config but it does not seem to be respected.
Steps to Reproduce

install ghost docker container
map custom production json config with:

  "mail": {
    "transport": "SMTP",
    "from": "'Blog domain.de'<EMAIL_ADDRESS>    "options": {
      "host": "smtp.domain.de",
      "port": 465,
      "secure": true,
      "auth": {
        "user"<EMAIL_ADDRESS>        "pass": "SeCuRePaSsWoRd"
      }
    }
  },

Go to main Paige and Sign up
Getting error message displayed

Ghost Version
latest official docker container
Node.js Version
latest official docker container
How did you install Ghost?
docker
Database type
MySQL 5.7
Browser & OS version
Firefox
Relevant log / error output
Error from container logs:

[2022-08-06 19:40:33] ERROR Failed to send email. Reason: Can't send mail - all recipients were rejected: 553 5.7.1<EMAIL_ADDRESS>Sender address rejected: not owned by user<EMAIL_ADDRESS>
Failed to send email. Reason: Can't send mail - all recipients were rejected: 553 5.7.1<EMAIL_ADDRESS>Sender address rejected: not owned by user<EMAIL_ADDRESS>

### Code of Conduct

- [X] I agree to be friendly and polite to people in this repository

Hello,
I already searched in the forum for an answer to my problem. I added the mail configuration to my config but got this error. So I kindly ask you if it could be a bug (what I don't hope, but my config is how it should be, according to the docs and forum posts). So how could that be?
Thanks for replies.

I am running into the same issue.
The from email is used when inviting a new staff member, but not when someone subscribes...
Any help / guidance would be greatly appreciated

There is a forum thread here: https://forum.ghost.org/t/mail-from-option-shows-no-effect/31857