Install not working

I went to https://nodejs.org/en/download/
Installed latest version of node
ran npm install @inrupt/solid-client
got the following error:
npm : npm ERR! must provide string spec
At line:1 char:1

npm install @inrupt/solid-client

  + CategoryInfo          : NotSpecified: (npm ERR! must provide string spec:String) [], RemoteException
  + FullyQualifiedErrorId : NativeCommandError

Please provide a full list of steps for install in your documentation as what is there does not work. Not to mention your documentation doesn't have a link to node to install it and doesn't mention what version of node is supported.
These are the instructions I used:
https://docs.inrupt.com/developer-tools/javascript/client-libraries/installation

By the time I'm done, you guys are either:
A. Going to do what I originally requested and provide the JS files for everyone without the need for these ridiculous build chains (my opinion, not fact)
B. Have the best damned step by step install guide there is.
Either way, I'm not trying to fight against you, I am trying to make sure that this is easily available to as many Devs as possible.

As replied here, you appear to be on Node.js 12.x which is not supported: https://github.com/inrupt/solid-client-js/issues/1775#issuecomment-1327747117
If you use a version of Node.js that is supported, such as 16.x, then you shouldn't face any issues. Furthermore, if you want help with npm install issues, we'll need the output of:
$ npx envinfo

$ npm install @inrupt/solid-client --verbose

npx is shipped with the recent LTS node.js releases.

As for:

By the time I'm done, you guys are either:

I will kindly remind you that this project has a code of conduct, this applies to everyone involved, even people opening issues: https://github.com/inrupt/solid-client-js/blob/main/CODE-OF-CONDUCT.md

Can you please outline what part of the code of conduct I've gone against? I've offered to help with the install guide as it's missing steps. As for you saying that I appear to be on Node 12.x, I stated at the beginning of this ticket that I went and installed the latest version of Node. In the other ticket I stated that I was highjacking that ticket and instead would start a new ticket.
There is no link to node in your documentation.
There is no indication on the installation page as to what version of node you support.
All you have is a one liner that says to use npm install ...
If you do this, you get the above error.
This is the verbose output:
npm : npm verb cli C:\Program Files\nodejs\node.exe C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js
At line:1 char:1

npm install @inrupt/solid-client --verbose

  + CategoryInfo          : NotSpecified: (npm verb cli C:...\bin\npm-cli.js:String) [], RemoteException
  + FullyQualifiedErrorId : NativeCommandError

npm info using<EMAIL_ADDRESS>npm info using<EMAIL_ADDRESS>npm timing npm:load:whichnode Completed in 0ms
npm timing config:load:defaults Completed in 1ms
npm timing config:load:file:C:\Program Files\nodejs\node_modules\npm\npmrc Completed in 3ms
npm timing config:load:builtin Completed in 3ms
npm timing config:load:cli Completed in 2ms
npm timing config:load:env Completed in 0ms
npm timing config:load:file:C:\Users\steve\OneDrive\Projects\Solid\Solid.npmrc Completed in 0ms
npm timing config:load:project Completed in 3ms
npm timing config:load:file:C:\Users\steve.npmrc Completed in 0ms
npm timing config:load:user Completed in 0ms
npm timing config:load:file:C:\Users\steve\AppData\Roaming\npm\etc\npmrc Completed in 1ms
npm timing config:load:global Completed in 1ms
npm timing config:load:validate Completed in 0ms
npm timing config:load:credentials Completed in 1ms
npm timing config:load:setEnvs Completed in 0ms
npm timing config:load Completed in 11ms
npm timing npm:load:configload Completed in 12ms
npm timing npm:load:mkdirpcache Completed in 1ms
npm timing npm:load:mkdirplogs Completed in 0ms
npm verb title npm install @inrupt/solid-client
npm verb argv "install" "@inrupt/solid-client" "--loglevel" "verbose"
npm timing npm:load:setTitle Completed in 1ms
npm timing config:load:flatten Completed in 3ms
npm timing npm:load:display Completed in 5ms
npm verb logfile logs-max:10 dir:C:\Users\steve\AppData\Local\npm-cache_logs
npm verb logfile C:\Users\steve\AppData\Local\npm-cache_logs\2022-11-25T19_32_30_685Z-debug-0.log
npm timing npm:load:logFile Completed in 5ms
npm timing npm:load:timers Completed in 0ms
npm timing npm:load:configScope Completed in 0ms
npm timing npm:load Completed in 24ms
npm timing arborist:ctor Completed in 1ms
npm timing command:install Completed in 10ms
npm verb stack TypeError: must provide string spec
npm verb stack     at new Edge (C:\Program Files\nodejs\node_modules\npm\node_modules@npmcli\arborist\lib\edge.js:51:13)
npm verb stack     at [_loadDepType] (C:\Program Files\nodejs\node_modules\npm\node_modules@npmcli\arborist\lib\node.js:887:9)
npm verb stack     at [Arborist.Node._loadDeps] (C:\Program Files\nodejs\node_modules\npm\node_modules@npmcli\arborist\lib\node.js:864:23)
npm verb stack     at new Node (C:\Program Files\nodejs\node_modules\npm\node_modules@npmcli\arborist\lib\node.js:256:20)
npm verb stack     at [newNode] (C:\Program Files\nodejs\node_modules\npm\node_modules@npmcli\arborist\lib\arborist\load-actual.js:335:9)
npm verb stack     at C:\Program Files\nodejs\node_modules\npm\node_modules@npmcli\arborist\lib\arborist\load-actual.js:292:68
npm verb stack     at async [loadActual] (C:\Program Files\nodejs\node_modules\npm\node_modules@npmcli\arborist\lib\arborist\load-actual.js:137:25)
npm verb stack     at async Promise.all (index 0)
npm verb stack     at async Arborist.reify (C:\Program Files\nodejs\node_modules\npm\node_modules@npmcli\arborist\lib\arborist\reify.js:153:5)
npm verb stack     at async Install.exec (C:\Program Files\nodejs\node_modules\npm\lib\commands\install.js:145:5)
npm verb cwd C:\Users\steve\OneDrive\Projects\Solid\Solid
npm verb Windows_NT 10.0.22621
npm verb node v18.12.1
npm verb npm  v8.19.2
npm ERR! must provide string spec
npm verb exit 1
npm timing npm Completed in 144ms
npm verb unfinished npm timer reify<PHONE_NUMBER>816
npm verb unfinished npm timer reify:loadTrees<PHONE_NUMBER>820
npm verb unfinished npm timer idealTree<PHONE_NUMBER>821
npm verb unfinished npm timer idealTree:init<PHONE_NUMBER>821
npm verb code 1
You guys are clearly able to build it and get the JS files, but for some reason, you aren't putting them up for people to use. I'm not sure why that is, but if you want the most number of people to use and adopt this, you need to cover the most area. JS files do this. But if you don't want to do it, I can't force you. So, I tried to use your documentation, but that doesn't work. So I have offered to help. I guess the above didn't come across that way. Basically, I'm offering to come up with a step by step guide on how to install, what versions, building it and getting the plain JS files from it if possible.
If you don't want help with any of that, please let me know and I can close off my tickets and sorry for the inconvenience.

You'll find the Node support policy on this page. We'll see if we can make this more obvious from the install page.
However, our documentation doesn't intend to be a NodeJS tutorial, as we only have limited resources so we have to keep a pretty focused scope. We have to assume some level of NodeJS familiarity from developers, so I can only recommend to look up a more general NodeJS tutorial before coming back to install these libraries. Unfortunately, a very granular install guide may not be the most appropriate solution, because the more details we put, the more assumptions we have to make about the underlying system, and basically there are much better npm tutorials online than whatever we would be able to write.
I understand your frustration, but to set appropriate expectations, we will not be changing our build chain to expose the transpiled JavaScript in the near future, as NPM tooling does a much better job at making this available than we would. Your feedback to the documentation is appreciated, and I'll double check the install. If I can't reproduce the problem, I'll close the issue.

I would like to say that if this was C#, I'd use Nuget and would get the binaries. In this case, I'm supposed to use NPM, but, instead of getting the binaries, I have to get the source code and compile to get the binaries myself (the JS files).
For reproducing the issue, use the latest version of Visual Studio and the latest version of Node. Using the Package Manager Console run "npm install @inrupt/solid-client"
I did nothing else.
My main frustration is that this is supposed to be a JavaScript library. By definition that should mean a .js file and that it can be referenced by a script tag or imported. This is not the case and you end up needing a tool chain. I get that you guys use it for you building of the library, but it shouldn't be needed to consume it.
I get you guys are going to change this, but this is a frustration I've had over and over again. I've had issues getting Aurelia, React, Angular and Node working in the past because of these tool chains and I'm getting tired of needing them when all I should need to do is point to a JS file and use it.
Sorry about how this has come across, but I dying to try this stuff out and want to recommend it where I work as an auth alternative, however, if it relies on NPM, we won't be able to use it. This is why I need the plain JS files.

As mentioned in the other issue #1775, node.js 18 isn't yet supported by the SDK, though I'm not sure why npm on windows would be giving you the error it is, you'd have to raise that with them.
I can see you're using node.js 18 from the logs:
npm verb Windows_NT 10.0.22621
npm verb node v18.12.1
npm verb npm v8.19.2

As mentioned in the other ticket we currently only support Node.js 16 and 14, as we need to do a lot of work to bring Node.js 18 features to the SDK, I'm going to close as a duplicate of #1775, but feel free to respond to this issue if you're having further install issues on Node.js 16

I'm ok with this getting closed if you think that's the issue. This does still bring my point even more to light. JS should be thought of as the binary. You wouldn't ask people in a nuget package to get the source and compile it (C#). Same going for any other library. But for some reason, the frontend is different and we are expected to work in TypeScript and use NPM and Node and everything else rather than being given the binary (the JS files). I get that you guys won't be changing this any time soon (if ever), but in order to reach the most number of people I highly suggest talking and thinking about making the plain JS files available for those who don't want to use NPM, webpack... tool chains and want as few dependencies as possible.
Thanks and sorry I came off agressive. My comment about "Have the best damned step by step install guide there is." was meant as "I'm willing to help make this easier for everyone".

@sbuchok on:

You wouldn't ask people in a nuget package to get the source and compile it (C#).

sorry, but that's just not what's happening here: you are just getting javascript files, the key part is that it's multiple files all targeting different module systems: commonjs, ECMAscript modules, and UMD. We also ship a bunch of .d.ts files that are the type definitions that Typescript uses. All this is just packages up into a tarball and delivered via npm. The nuget package manage is much the same: it downloads zip archives from a registry & extracts them.
The only case where compiling is needed is when there's missing platform features (different browsers) or where you're wanting to serve javascript more optimally by reducing the number of files loaded (which was really more of an issue before HTTP/2.0 was a thing).
In theory, you should just be able to use the .mjs files we distribute in our packages directly in the browser, but the problem you face is that the browser needs to find the other imported files, either from the same package or different packages.
I'm generally recommending people look at vite because it's one of the latest bundlers out there that supports ESM, and has hot code reloading and many other great features that make it a good development environment.


Articulate 5.0.1 causes all node URLs except the homepage to return 404 not found

Articulate 5.0.1 causes all node URLs except the homepage to return 404 not found.
Tested using Umbraco.TheStarterKit and OskiStarterKit in Umbraco v12.3.3 and v13.0.0 RC2
After removing Articulate 5.0.1 and rebuilding the solution, node URLs function as expected.

What root nodes do you have then with all of these starter kits? Do you have multiple root nodes? Do you have domains defined for them? There can only be a single root node without a domain assigned in Umbraco.

Have seen same issue on a previous working 5.0.0 site, two root nodes, first node has domain / culture assigned, second node nothing assigned (container for content blocks and settings). Uninstall of 5.0.1 and reverting to 5.0.0 allows rest of site to render. Have not looked into further as yet.

Same issue happening with version 5.0.1 as @gavinfaux

@khraibani exactly the same? 2 root nodes, one domain assigned, or something different?

I ran in to something similar i think.
I have multiple Sites, under one rootnode, and each of them has its own domain

But nothing but the first rootnode gets hit (the "Sites" node).
The "Sites" node has no domain.
It seems that when hitting this part of the code, umbracoRouteValues?.PublishedRequest is null

The comment Ensure it runs AFTER Umbraco  made me bump the value from 100 to 1000.
Seems to do the trick for me.

Hope this helps

@MartinAmsinck Thanks for suggested fix, our site working fine now, PR submitted.
Unsure how to debug/list route order to verify if 1000 is optimal.

@Shazwazza I was running

Umbraco v12.3.6
Articulate 5.0.1
1 root node
I reverted back to version 5.0.0 and its working apart from the categories/tags I will raise that as another issue

@khraibani are you running in Umbraco Cloud? I tweeted about this a while back https://twitter.com/Shazwazza/status/1720142890901684630 and had to ship 5.0.1 to make it work for the virtual routes.

Though, maybe my workarounds (see https://github.com/Shazwazza/Articulate/commit/6d0b672569cc6a7e100575058ff80cb19be566ec, https://github.com/Shazwazza/Articulate/commit/e3d34ba14e5865b866e949425c20058bf73431ea) was resolved by changing the MapDynamicControllerRoute to 1000, not sure

@Shazwazza no its a local version of Umbraco (self hosted) should that make a difference?

Hey there, we encountered this issue today while adding v5.0.1 of Articulate to an Umbraco Cloud site running v13.0.3 of the CMS. Using v5.0.0 instead resolves the issue.

I too had the same issue. I found that the pages were available if I added // after the base domain i.e. https://localhost:44372//Page-name.
This was fixed in the latest Dev version as well as using V5.0.0.
Notes to help debug if needed:
It only started happening after I added a custom SurfaceController.
I confirmed this by creating a clean Umbraco 13.1 build
The site worked correctly with Articulate V5.0.1 without a SurfaceController and with a SurfaceController but not Articulate but with both it returned "404 not found" - the 404 wasn't an Umbraco handled 404 it was a system 404.
For testing the SurfaceController was a pretty empty one as shown below.
`using Microsoft.AspNetCore.Mvc;
using Umbraco.Cms.Core.Cache;
using Umbraco.Cms.Core.Logging;
using Umbraco.Cms.Core.Routing;
using Umbraco.Cms.Core.Services;
using Umbraco.Cms.Core.Web;
using Umbraco.Cms.Infrastructure.Persistence;
using Umbraco.Cms.Web.Website.Controllers;
namespace UmbracoProject1.Controllers
{
public class SampleController : SurfaceController
{
public SampleController(IUmbracoContextAccessor umbracoContextAccessor, IUmbracoDatabaseFactory databaseFactory, ServiceContext services, AppCaches appCaches, IProfilingLogger profilingLogger, IPublishedUrlProvider publishedUrlProvider) : base(umbracoContextAccessor, databaseFactory, services, appCaches, profilingLogger, publishedUrlProvider)
{
}
	public IActionResult Index()
	{
		return Content("Hello world");
	}
}

}`

I've  encountered this issue too and the // after the base url does mean the pages load e.g. https://localhost:44310//articles/latte-art/

We are seeing this same issue with 5.0.1. Our solution was to downgrade to 5.0.0 which has fixed the issue.

Had the same issue Umbraco CMS 13.2.2, Articulate latest version, One root node
once Articulate installed, 404 error for all pages
Question: How to Setup An Articulate Blog Package to An Existing Umbraco Layout
IS there's a process on how to do it somewhere?

really sorry for the accidental delay in getting these shipped as part of releases, I though this was already done 🤦♂🤦♂ 5.0.2 and 5.0.3 are now shipped.
I'm not sure if those 'fix' this issue but hopefully will help some folks, I still need to replicate locally

really sorry for the accidental delay in getting these shipped as part of releases, I though this was already done 🤦♂🤦♂ 5.0.2 and 5.0.3 are now shipped.
I'm not sure if those 'fix' this issue but hopefully will help some folks, I still need to replicate locally

Thanks this is now fixed when using 5.0.3


[BUG] Navbar UI

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
NavBar UI currently:

The EOS icon in the navbar is quite small and is also not aligned with the home, about nav tab properly(for the desktop screen).

Expected Behavior
Navbar UI update:

We can rearrange the Navbar EOS icon and menu tabs to make it look cleaner.

Steps To Reproduce
Need to work on navigation component
https://github.com/EOS-uiux-Solutions/eos-icons-landing/blob/master/src/assets/scss/components/navigation.scss
Anything else?
No response
What browsers are you seeing the problem on?
Chrome

Navbar elements aligned properly in row.
@kbhutani0001 please have a look.

Even the active tab (blue underline) doesn't vanish now.
Before changes

:arrow_double_down:

After changes

:arrow_double_down:


chore(ui): Update yup 1.3.3 dependencies in ui

Description
Version 1.2.0 was published almost 8 months ago.
Update with 2 sprints before next release, especially before feature bashes.
https://github.com/jquense/yup/blob/master/CHANGELOG.md#133-2023-12-14

1.3.3: addMethod: allow Schema without making TypeScript upset
1.3.2: pick and omit with excluded edges
1.3.1: ValidationError extends Error
1.3.0: Allow schema metadata to be strongly typed

Checklist

[ ] Investigated and inspected CI test results
[x] ~Unit test and regression tests added~

Testing Performed

ui-components-tests failure

Step phase test failed after 3m49s
could not watch pod

/test ui-component-tests


replaced regex line with more readable code

Hoping this works, i tested it out in a different file.
Fixes #17

Thanks for contributing! i have edited your pull request to reference the issue that was assigned.


This package for who?

After learning laravel i made a ecommerce, 2 crud with ajax and API but after installing this package I feel like I know nothing, why?

Don't say that. You know about it, just in a different way. People use different things in their own preferred way or the way they have learned to use it. So probably, just the way we use some things might not make sense, but give it a chance, it will eventually grow on you.


.Net framework requirement of Teams client

Cx reported us that they were asked .Net Framework 4.5 during installing Teams desktop client.
We confirmed it happens when trying to install the teams client on OS having .Net framework 3.5. It didn't occur when installing the client on OS having .Net Framework 4.5 or 4.7.
There is no public information about .net framework requirement. So I wonder if we could add the note in the section of Desktop Client of https://docs.microsoft.com/en-us/microsoftteams/get-clients.

Thanks for reporting this! Yes, the Teams installer requires .Net framework 4.5.  I'm updating the article now (change should go live later today).


⚠ Empornium has degraded performance

In ae94f6c, Empornium ($EMP) experienced degraded performance:

HTTP code: 502
Response time: 4771 ms

Resolved: Empornium performance has improved in 2ff47de.


CB-16279: Add an image update step to roll-forward

In this commit I've added a new step to the roll-forward to update the image of the stack to a new one which contains all the required parcels for the cluster.

LGTM, thanks @tiborpopovics


Adding badges to README.md File

pls assign me this issue under GSSOC'23 label
@apoorvaron

Adding Techstacks used in this project. Please assign this issue under gssoc23.

@AmanSingh6574 Sure ! You can work on this

@apoorvaron can you pls add GSSOC'23 label and add level to it

@apoorvaron pls add GSSOC'23 label

@apoorvaron pls add level to the issue


Update documentation

Add info on the new module
Modify instructions for examples (minor changes)

Relates-to: OLPEDGE-2194
Signed-off-by: Halyna Dumych<EMAIL_ADDRESS>

Codecov Report

Merging #347 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #347   +/-   ##
===========================================
  Coverage   89.3547%   89.3547%
===========================================
  Files            66         66
  Lines          1813       1813
  Branches        207        207
===========================================
  Hits           1620       1620
  Misses          111        111
  Partials         82         82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24f491f...fe035dc. Read the comment docs.


composer vendor code context

Rollbar reports invalid code context for vendor dependencies in PHP, such as:
This context will never be resolved since it’s not part of the project repository – vendor/ is managed by Composer and (should) be excluded from VCS. This can be improved a few ways:

Easy - just show the trace with no source option for vendor/ files

Medium – search the packagist API for the vendor// and try to link to the master

Hard – require the user to include their composer.lock to resolve the actual source link

More info: https://app.intercom.io/a/apps/rlisg82q/inbox/inbox/conversation/21560351498

(1) is doable today with a backend code change (we have other cases like this, e.g. for Ruby). 2 and especially 3 would be quite neat.

It looks like we implemented (1) a while ago.


Merge to live 5-30 Part

@Rick-Anderson @scottaddie I think the problem is that I need to squash the commits on those moniker range PRs. The first one is probably blowing up before the second one can repair the damage. I'll see if I can squash them, and that might let this build.


WIP: Add a concept of "changes" to the foxops data model

The intention of this PR is to make the foxops datamodel more aware of the actual changes that are being performed on the incarnation.
It is achieved by adding the concept of a Change, which represents a single update attempt of an incarnation.
Implementation
Before
The previous implementation was using the code in foxops.reconciliation to initialize and update incarnations. The code in that package was responsible to locally clone the incarnation repo, apply the changes using fengine and interact with Gitlab to create merge requests.
Now
The logic for performing changes was moved into a service in foxops.services.change. The future API interface should call methods like these to perform changes:

ChangeService.create_change_direct - for directly applying a change to the main branch
ChangeService.create_change_merge_request - for creating a merge request with the desired change

The change service is not only responsible for performing the change in the incarnation repository, but also to track those changes in the foxops database.
Side Project
I added a LocalHoster implementation of the Hoster interface, to make local testing more efficient.

finally - first time all tests are green 😎
I'm not done yet - I want to spend quite some more time adding additional tests (especially focusing around these "transition usecases", when using the new API implementation with incarnations that were created with the previous API).
And now that I'm thinking about this, I'm questioning the whole approach of implementing compatibility with both "versions of the data" instead of just doing a one-time migration when updating the DB 🤔
Anyways - @timofurrer @giacinti , in case you have any feedback (yeah, the MR is way too biiiiig)... I would be glad to hear it :-)


Staff leave and join alerts

the join and leave logs are only showing up for staff, not the actual players. unless the server crashes then we see them leave. thats the only time though

these logs for example^ we can only see players tagged as staff leave and join. the only time we see players leave and join is if the server gets shutdown/crashes

These join and leave messages are not intended for normal players. These are part of the staff chat. Not a bug.


Small improvements to C++ decompiler testing from CLI

Fixes argument parsing to accept more than one option for specifying
paths.

Return a non-zero exit code (saturated to max value 255, even if more
than 255 tests fail) indicating number of failed tests. This is
helpful when running in a script (like in CI) to detect failures
instead of detecting failures through manual, visual inspection of
output text.

@ryanmkurtz I've separated the commits in an attempt to make review easier and improve probability of acceptance.
Is there anything more I can do to help shape this into something acceptable?

Nope, we just need to review it now.


ACTIVE_CLASSES prevents default/custom styling of dropdown items

Could you please remove "bg-primary" and "text-white" from ACTIVE_CLASSES?
https://github.com/lekoala/bootstrap5-autocomplete/blob/master/autocomplete.js#L73
Those classes override the normal bootstrap dropdown styling. If they are removed it would be easy to customise the dropdown-item styling using the SASS/CSS variables for dropdowns e.g. https://getbootstrap.com/docs/5.3/components/dropdowns/#variables
Thanks!

@benwallis fair point. the goal is to make it work "out of the box" but i added an activeClasses config (check demo.html to see it in action) in https://github.com/lekoala/bootstrap5-autocomplete/releases/tag/1.1.2


tsdx ignores tsconfig.json "extends" keyword

Current Behavior
There's an extends feature in tsconfig which allows configuration inheritance across multiple tsconfig files.  This however isn't recognized in tsdx, which parses tsconfig here:
https://github.com/jaredpalmer/tsdx/blob/4f6de1083393057903a1837fb6658f8058ee832f/src/createRollupConfig.ts#L46-L49
The JSON object is used as-is, instead of drilling up to resolve parent config.
Expected behavior
tsdx should process extends just like tsc does.
Suggested solution(s)
In a quick look through TypeScript's source code I couldn't find the place where extends is handled, but it's possible that TypeScript's exported tsconfig parsing functions might handle extends for us automatically. See https://github.com/microsoft/TypeScript/blob/760393f893358a462b00eef7e8fb92342b0f71ad/lib/typescript.d.ts#L3639-L3647 what what TS offers in its API.  The implementation is here: https://github.com/Microsoft/TypeScript/blob/6487d1ffe0d903b1e55a187ddeb973fe0d445a2f/src/compiler/parser.ts#L717
Additional context
This problem is similar to #483 in that both this issue and that one are caused by parsing tsconfig differently than tsc does.
Your environment

Software
Version(s)

TSDX
<EMAIL_ADDRESS>

TypeScript
<EMAIL_ADDRESS>

Browser
n/a (this is a build issue)

npm/Yarn
<EMAIL_ADDRESS>

Node
v12.13.1

Operating System
MacOS Catalina 10.15.2

great qtn. we'll probably want to handle this.

Hey @sw-yx, what's a "qtn"?

qtn = question

👍 this would be great for typescript monorepos. Some of the tinacms packages use tsdx for builds. Ideally most of the config would be in the root tsconfig.json with the occasional special case in the package's.

Echoing @ncphillips, I originally ended up here at tsdx because my project depends on the https://github.com/reach/reach-ui monorepo that uses extends. I wanted to help get its declaration maps fixed in that monorepo. But without extends support any fix will involve making changes to ~20 different packages' tsconfig.json files, which is not ideal.
Luckily the only rollup settings pulled direct from JSON by tsdx are esModules (which doesn't actually use tsconfig because of #469) and useTsconfigDeclarationDir (once #468 is merged). In other words, currently this issue has no impact... but it will have impact once those other two issues are resolved.

anyone want to tackle this?

anyone want to tackle this?

Oh, I already did haha. @justingrant said he didn't have time for this in https://github.com/jaredpalmer/tsdx/issues/483#issuecomment-581238335 so I coded it up (see above reference). Still need to add a test for the extends case, hence the draft, but will do that in a day or few as I have to focus on some other things

ok. @agilgur5 we're piling up quite a few PR's for jared to review, lets slow down so that we dont swamp him with too much stuff.

Hrmmm. I thought this worked? Maybe a false positive. Let’s fix

Hrmmm. I thought this worked? Maybe a false positive. Let’s fix

@jaredpalmer #483 has a more detailed description, but this is specifically for TSDX-specific options like esModuleInterop. It was already handled by rollup-plugin-typescript2 for most options, but some tsconfig options affect TSDX too.

ok. @agilgur5 we're piling up quite a few PR's for jared to review, lets slow down so that we dont swamp him with too much stuff.

@sw-yx think that might be the first time I've been asked to contribute less 🤔 🤔 🤔

i mean i just want to keep it manageable for jared. its not my name on the repo heheh

On the mention of contributing less, I'm just going to leave this reference to theory of constraints here 😄

This issue drove me absolutely bananas today. Didn’t realize it was happening till I checked out this issue.

@jessekrubin are you sure you were facing this issue? As written above a few times, currently this only affects the esModuleInterop setting, and that actually has a bug (#469), so this issue currently has 0 impact on anything (it only has future impact like #468 )

@jessekrubin are you sure you were facing this issue? As written above a few times, currently this only affects the esModuleInterop setting, and that actually has a bug (#469), so this issue currently has 0 impact on anything (it only has future impact like #468 )

I think so. I have several chained tsconfigs; i thought it would be a cool experiment to move a monorepo I have been working on to use tsdx, but it was not as easy as I had hoped. I can do mo reading/fiddling and get back to you. Maybe its possible that my tsconfig extends spaghetti (family recipe) has a problem in it somewhere... the repo does not have the issue with my current rollup setup tho. I do not know. Configuring stuff is far and away my least favorite thing.

Perhaps I should have been more explicit -- whatever your issue is (you didn't provide a repro or describe it), it can't be this.
As was written above already, extends is parsed properly by rollup-plugin-typescript2, which is used under-the-hood. I'll say for the third time that TSDX's own processing currently has no impact on userland.
Please read the thread before leaving a comment.

i thought it would be a cool experiment to move a monorepo I have been working on to use tsdx, but it was not as easy as I had hoped

There's a few issues around on monorepos, but no one has contributed a PR so far. I don't have any monorepos, so I can't really comment on that.

(family recipe)

this was subtle 😆

As was written above already, extends is parsed properly by rollup-plugin-typescript2, which is used under-the-hood. I'll repeat, more explicitly, that TSDX's own processing currently has no impact on userland.

But what if I am trying to use the babel-loader via extending the tsdx config? uncharted territory?

this was subtle 😆

let me know if you want the recipe. It is quite good, but it makes no sense.

But what if I am trying to use the babel-loader via extending the tsdx config? uncharted territory?

No, that still has no impact. The source of this is literally only 5 LoC as you can see in OP and the PR (which makes it even less LoC).

As this is almost certainly off-topic, if you're having some issue I'd suggest investigating further and if you strongly believe it's a TSDX bug, making a minimal repro to submit as a separate issue. Talking in hypotheticals isn't really productive.
Here's some possible tips for your debugging.

I'm not sure if you meant adding a babelrc file or a tsdx.config.js file, but a babelrc file won't have any impact on tsconfig.json as Babel is only run after the TS has been transpiled (TS -> rollup-plugin-typescript2 -> ESNext -> @rollup/plugin-babel).
If you've added some Babel plugin that also parses tsconfig.json (like @babel/preset-typescript) for some reason, then that's of course a userland issue, not in TSDX.
Same can be said if you're using tsdx.config.js and added your own tsconfig.json parsing somewhere, that would be in userland, not in TSDX.

Repeating here from #483 :

Merged in #489 as I'm now a collaborator. Turns out that ts.parseJsonConfigFileContent is needed to parse extends, but ts.readConfigFile is enough for comments and commas. These are not remotely well documented, so I had to search around other repos to figure out how to do this simply and properly. Can read the PR comments for what I searched through


removed 30-python-best-practices-tips-and-tricks, because it was dele…

…ted by the author

Thanks @Vulwsztyn


When step size is available then adjust total amount (with fee included) by the step size using TradingService#roundByStep

Currently, exchanges with FeeComputation set to CLIENT do not perform the roundByStep() adjustment which my lead to org.knowm.xchange.exceptions.OrderNotValidException: Filter failure: LOT_SIZE (HTTP status code: 400) when performing a trade.
In this pull we call roundByStep using CurrencyPairMetaData#getAmountStepSize().
Do not merge this PR just yet. I will run this code changes for a while to see if it really fixed the OrderNotValidException

Ready to merge, I have ran it for a few days. No major issues.

Ready to merge, I have ran it for a few days. No major issues.


Distinguish between multiline and single line comments

(I'll say first and foremost that I applaud your enthusiasm for this project. I've back-pedaled on my choice to pursue a separate lib; it was too reactionary.)
Consider the following input: /* Hello World */
And the following node that corresponds to the input:
Comment {
  raws: { before: '', inline: true, left: ' ', right: '' },
  type: 'comment',
  parent:
   Root {
     raws: { semicolon: false, after: '' },
     type: 'root',
     nodes: [ [Circular] ],
     source: { input: [Object], start: [Object] },
     lastEach: 1,
     indexes: {} },
  source:
   { start: { line: 1, column: 1 },
     input: Input { css: '/* Hello world */', id: '<input css 2>' },
     end: { line: 1, column: 14 } },
  text: 'Hello world' }

It would be very helpful to be able to distinguish between a multiline comment (one that starts with /*) and a single line comment (//). I'd imagine this is something that stylelint could make use of as well, to determine if a particular comment type is allowed or not.

Just found the node.raws.inline property after another look at the source. Please disregard the issue :)


Passing HashMaps/Dynamic Objects as script function argument.

Hello,
maybe I'm doing something wrong (which is very likely as I'm new to rust), but currently I'm struggling to pass an HashMap or similar to a function as an argument.
I want to render Javascript Templates in Rust, where I want to pass dynamic objects to the render function in order to render the template as HTML.
basically its shoudl look just like:
    let context = HashMap::from([
        ("doesWhat", "rocks in rust"),
    ]);

    script.call("render", context)

or:
 let context = [
        ("doesWhat", "rocks in rust"),
    ];

    script.call("render", &context);

Unfortunately this ends up with:
  --> src/main.rs:13:27
   |
13 |     script.call("render", context);
   |                           ^^^^^^^ the trait `js_sandbox::call_args::CallArgs` is not implemented for `HashMap<&str, &str>`

or
the trait `js_sandbox::call_args::CallArgs` is not implemented for `&[(&str, &str); 1]

I'm also not able to implement the trait, as it is in a private module (js_sandbox::call_args::CallArgs).

The latest version of js-sandbox allows passing multiple parameters, not just one. This in turn means that the syntax needs to be adjusted -- concretely, Script::call() now takes a tuple:
let context = HashMap::from([
    ("doesWhat", "rocks in rust"),
]);

script.call("render", (context,)); // note the trailing comma for 1-tuple

I admit it's not the most beautiful; unfortunately, I cannot "overload" call() by implementing CallArgs also for T: Serializable, as this overlaps with the tuples, and specialization is not supported in current Rust. If this happens a lot, a special method for this case might be added.
But for nicer code, consider also using the #[js_api] macro like in this test.
I also realized that the ReadMe.md was outdated; I forgot to sync it manually with the updated lib.rs. Sorry for that. To make sure this doesn't happen again, I simply automated it via CI.


Fix istioctl install stuck when pilot container is not ready

Please provide a description of this PR:
When trying to upgrade Istio with istioctl, the cmd keeps getting stuck, and no output is being printed.
My environment is like:
kubectl -n istio-system get po
NAME                                    READY   STATUS    RESTARTS   AGE
istio-cni-node-bnhz9                    1/1     Running   0          2d21h
istio-cni-node-j8br4                    1/1     Running   0          2d21h
istio-cni-node-xrx25                    1/1     Running   0          2d21h
istio-ingressgateway-557bdc674f-p8nmb   1/1     Running   0          2d21h
istiod-66d5bfc6b5-5p8vj                 0/1     Running   0          2d18h
ztunnel-6tcl6                           1/1     Running   0          2d18h
ztunnel-97t4z                           1/1     Running   0          2d21h
ztunnel-dnznz                           1/1     Running   0          2d21h

Istiod is running but actually not ready to receive requests, which leads to the situation mentioned when making requests to 15014 port.

@hanxiaop what was the error that was stopping istiod from going ready?  I see ztunnels in the output, anything related to ambient?

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
08657581f82110e229e524c3e94d6913736d522c
link
unknown
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
08657581f82110e229e524c3e94d6913736d522c
link
unknown
/test gencheck

integ-ambient_istio
08657581f82110e229e524c3e94d6913736d522c
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson It's not related to Ambient, but related to general istioctl installation. I was trying to debug pilot, and eventually it became unready, and then I was trying to reinstall it but the installation process was stuck.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
08657581f82110e229e524c3e94d6913736d522c
link
true
/test integ-ambient

unit-tests_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
08657581f82110e229e524c3e94d6913736d522c
link
true
/test integ-ambient

unit-tests_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test unit-tests

integ-security-istiodremote_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
08657581f82110e229e524c3e94d6913736d522c
link
true
/test integ-ambient

unit-tests_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test unit-tests

integ-security-istiodremote_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test integ-security-istiodremote

integ-security_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
08657581f82110e229e524c3e94d6913736d522c
link
true
/test integ-ambient

unit-tests_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test unit-tests

integ-security-istiodremote_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test integ-security-istiodremote

integ-security_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test integ-security

integ-security-multicluster_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
08657581f82110e229e524c3e94d6913736d522c
link
true
/test integ-ambient

integ-security_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test integ-security

integ-security-multicluster_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test integ-security-multicluster

integ-security-istiodremote_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
08657581f82110e229e524c3e94d6913736d522c
link
true
/test integ-ambient

integ-security-multicluster_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test integ-security-multicluster

integ-security-istiodremote_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test integ-security-istiodremote

integ-security_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
08657581f82110e229e524c3e94d6913736d522c
link
true
/test integ-ambient

integ-security-istiodremote_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test integ-security-istiodremote

integ-security_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test integ-security

integ-security-multicluster_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
08657581f82110e229e524c3e94d6913736d522c
link
true
/test integ-ambient

integ-security_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test integ-security

integ-security-multicluster_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test integ-security-multicluster

integ-security-istiodremote_istio
9bf42e1e133198c8dfd37f2b7776b538cc72696a
link
true
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
08657581f82110e229e524c3e94d6913736d522c
link
true
/test integ-ambient

integ-security-multicluster_istio
b42daac9d357083a483c2dcbbbebceaa846fd2d2
link
true
/test integ-security-multicluster

integ-security-istiodremote_istio
9bf42e1e133198c8dfd37f2b7776b538cc72696a
link
true
/test integ-security-istiodremote

integ-security_istio
9bf42e1e133198c8dfd37f2b7776b538cc72696a
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
08657581f82110e229e524c3e94d6913736d522c
link
true
/test integ-ambient

integ-security-istiodremote_istio
9bf42e1e133198c8dfd37f2b7776b538cc72696a
link
true
/test integ-security-istiodremote

integ-security_istio
9bf42e1e133198c8dfd37f2b7776b538cc72696a
link
true
/test integ-security

integ-security-multicluster_istio
9bf42e1e133198c8dfd37f2b7776b538cc72696a
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Helpful IDs and Comments feature

The goal is to highlight IDs with bodies or comments which are useful for identification. Taking a first crack at the basic requirements, but we can move this over to a Google Doc if it becomes too complicated

users should be able to say that an ID w/ body or a comment is useful for identification

the author should be able to do this for their own IDs/comments
you should be able to remove your "helpful" designation

taxon pages should feature helpful IDs and comments on observations of itself or its descendants

open question how far up this percolates. Is it useful above family?

Open Questions:

Should we allow downvoting in any context?
How far up the taxonomic tree do comments/IDs go?

It also occurred to me (this could be a later feature) that we might want the votes to have taxon context. Some descriptions will be great at how to ID a single species ("female are small, males are big"), but other descriptions might be useful for distinguishing species of a clade ("C. alba has a white stripe and C. azurea has a blue stripe").
Maybe the votes on the observation page inherit the context of the obs' current taxon, and and votes recorded on taxon pages inherit that context. That would allow a comment to be high rated for a species and low rated for a genus. Also, if a comment was voted down on a taxon page because the taxon ID was wrong, when it gets moved to a different taxon we can ignore votes in the context of the old taxon.

This would be awesome, especially if linked to taxon (I can look up the
most useful ID comments for any given taxa). Agreed eventually it would be
best to somehow tag more than one species. For instance if I help someone
distinguish red and sugar maple, and the observation turns out to be a red
maple, it would be nice to be able to tag it to sugar maple somehow too
(but not essential)
On Wed, Aug 31, 2016 at 11:25 AM, Patrick Leary<EMAIL_ADDRESS>wrote:

The goal is to highlight IDs with bodies or comments which are useful for
identification. Taking a first crack at the basic requirements, but we can
move this over to a Google Doc if it becomes too complicated

users should be able to say that an ID w/ body or a comment is useful
for identification

[image: screen shot 2016-08-31 at 11 20 08 am]
https://cloud.githubusercontent.com/assets/48566/18134762/8599e2de-6f6d-11e6-9b28-00162a2a13b7.png

the author should be able to do this for their own IDs/comments
you should be able to remove your "helpful" designation

[image: screen shot 2016-08-31 at 11 20 15 am]
https://cloud.githubusercontent.com/assets/48566/18134755/82132abc-6f6d-11e6-9aa8-dbef94c00aa0.png

taxon pages should feature helpful IDs and comments on observations of
itself or its descendants

open question how far up this percolates. Is it useful above family?

Open Questions:

Should we allow downvoting in any context?
How far up the taxonomic tree do comments/IDs go?

It also occurred to me (this could be a later feature) that we might want
the votes to have taxon context. Some descriptions will be great at how to
ID a single species ("female are small, males are big"), but other
descriptions might be useful for distinguishing species of a clade ("C.
alba has a white stripe and C. azurea has a blue stripe").
Maybe the votes on the observation page inherit the context of the obs'
current taxon, and and votes recorded on taxon pages inherit that context.
That would allow a comment to be high rated for a species and low rated for
a genus. Also, if a comment was voted down on a taxon page because the
taxon ID was wrong, when it gets moved to a different taxon we can ignore
votes in the context of the old taxon.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/inaturalist/inaturalist/issues/1129, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AG1tkxfmq4EsqQJEVLNB7EyVSa-Zewlmks5qlZzsgaJpZM4Jxval
.

--
Charlie Hohn
Montpelier, Vermont

I sort of don't want to allow downvoting, but I don't see a better way of getting around over-enthusiastic groups of people, or people voting up things that are funny but not useful. Also a little worried about the usual ratings effect where things with high ratings just get more high ratings b/c they get shown first, but I'm not sure there's a way around that.
Percolation: not even sure this is going to be useful. If I make a really detailed comment about why I think a species of bee fly is that species, that might not even be useful at the genus level, let alone family.

Just posting a link to the User Comments Examples doc which I've transformed into [User Comments Voting Spec] (https://docs.google.com/a/inaturalist.org/document/d/13WlFbcXDTzOjkm-LXZOwQb3RO6Vy5-IbTM6LVaNWCuw/edit?usp=sharing) here:

Interim Solution for Comment Voting

Added some spacing between comments/IDs
Removed "Posted by"
"(Edit | Withdraw..." links show up to the right of the voting UI (see under the "Gentle tickle, eh?..."
Tried to use current UI elements from the ob detail screen

Count Hover
This pop-up shows who voted. Took this style from the current mentions autocomplete dropdown. Might not be necessary for first release.

Downvote Hover
This gives an explanation of exactly what you're voting for...

Upvote Hover

Up/Down Vote Hover Alternative
Here's the bootstrap style of tooltips which is a little more visible. I'm fine with whatever's easier.

Voted State
This is the state if you've voted. In this case, you up-voted.

Working on how these comments are displayed on the taxon page now...

Here's some alternative text for the tooltips...

Identify Tips Tab on Taxon Page

I kinda like "Identify Tips" over "ID Tips" it's more explicit.
The little thumbnail photo to the left of the voting ui links to the observation the comment is referencing
We can do the timestamp however we're doing it in other places.

Let me know if you have any thoughts or comments.

...I'm assuming the comments will be in order of highest voting score to lowest. Also, don't you think we should limit it 20 or something? Otherwise, we'll need some pagination in there.

I think it looks fine.  And yes, limits. Score = up votes - down votes?

Per today's meeting. We will wait to launch Helpful IDs and Comments (labelled "Identify Tips"  in above mock ups) tab with the release of the new taxon page.

looks good to me!

As per a recent iteration meeting - we discussed holding off on releasing UI for the helpful comments and IDs until the new version of observation details and incorporate it there. If the new taxon page is out by then, it will incorporate the helpful ids/comments summary, otherwise everything is released at the same time (it's highly unlikely obs detail would be ready before the new taxon page).


fix: Fix local image building targets

Ⅰ. Describe what this PR did
Fix local image building targets, we can build pilot and gateway images locally on both amd64 and arm64 platforms.
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #599 (ed5b56d) into main (754ec71) will increase coverage by 0.17%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
+ Coverage   37.24%   37.41%   +0.17%
==========================================
  Files          65       65
  Lines        9215     9215
==========================================
+ Hits         3432     3448      +16
+ Misses       5517     5501      -16
  Partials      266      266

see 1 file with indirect coverage changes


[Enhancement] Adjust the cachelib default max parcel memory to avoid too much rejected requets.

What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

@Mergify rebase

@mergify rebase


Dependency reported as not compatible with Python 3 is reported compatible when checked directly

Versions
caniusepython3: 3.3.0
Python: 2.7.11
Actual Output
$ caniusepython3 -p cmsplugin-filer
Finding and checking dependencies ...
[WARNING] Stale overrides: set([u'reportlab', u'extras', u'pyvirtualdisplay'])

You need 2 projects to transition to Python 3.
Of those 2 projects, 1 has no direct dependencies blocking its transition:

  easy_thumbnails (which is blocking cmsplugin-filer)

Ok, so there's one dependency that blocks cmsplugin-filer. When I saw that, I went to pypi page for easy-thumbnails and saw there that it supports Python 3. Let's see what happens if I run a check directly on it:
$ caniusepython3 -p easy-thumbnails
Finding and checking dependencies ...
[WARNING] Stale overrides: set([u'reportlab', u'extras', u'pyvirtualdisplay'])

🎉  You have 0 projects blocking you from using Python 3!

Using an underscore for the dash makes no difference:
$ caniusepython3 -p easy_thumbnails
Finding and checking dependencies ...
[WARNING] Stale overrides: set([u'reportlab', u'extras', u'pyvirtualdisplay'])

🎉  You have 0 projects blocking you from using Python 3!

Expected Output
I would expect that easy-thumbnails would not block cmsplugin-filer since it supports Python 3.

It's probably stale metadata. Can you try running the check against cmsplugin-filer again?

I'm getting the same results as originally. Are you not reproducing the problem at your end?

FYI: It shows green here https://caniusepython3.com/project/cmsplugin-filer

Apparently not stale metadata, see https://www.red-dove.com/pypi/projects/E/easy-thumbnails/package-2.3.json which looks up-to-date.

Hrm. OK, I'll dig deeper then to try and see what's going on. Thanks for the infro, @vsajip and sorry about the false alarm.

With the fix applied:
 (easy_thumbnails *) > ./venv-cpython35/bin/python -m caniusepython3 -v -p cmsplugin-filer
[INFO] 1 top-level projects to check
Finding and checking dependencies ...
[INFO] Fetching project list for 'Programming Language :: Python :: 3'
[INFO] Fetching project list for 'Programming Language :: Python :: 3.0'
[INFO] Fetching project list for 'Programming Language :: Python :: 3.1'
[INFO] Fetching project list for 'Programming Language :: Python :: 3.2'
[INFO] Fetching project list for 'Programming Language :: Python :: 3.3'
[INFO] Fetching project list for 'Programming Language :: Python :: 3.4'
[INFO] Fetching project list for 'Programming Language :: Python :: 3.5'
[INFO] Fetching project list for 'Programming Language :: Python :: 3.6'
[INFO] Fetching project list for 'Programming Language :: Python :: 3 :: Only'
[INFO] Adding 31 overrides:
[INFO]     beautifulsoup (https://pypi.python.org/pypi/beautifulsoup4)
[INFO]     collective.recipe.template (https://pypi.python.org/pypi/collective.recipe.template)
[INFO]     django-social-auth (https://pypi.python.org/pypi/python-social-auth)
[INFO]     dnspython (https://pypi.python.org/pypi/dnspython3)
[INFO]     fabric (https://pypi.python.org/pypi/Fabric3)
[INFO]     filechunkio (https://bitbucket.org/fabian/filechunkio/commits/5a1d0b614e506e5198090a5201770e2524fa8720)
[INFO]     flask-debugtoolbar (https://pypi.python.org/pypi/Flask-DebugToolbar)
[INFO]     flask-mail (http://pythonhosted.org/Flask-Mail/changelog.html#version-0-9-0)
[INFO]     flask-principal (http://pythonhosted.org/Flask-Principal/changelog.html)
[INFO]     flask-security (http://pythonhosted.org/Flask-Security/changelog.html#version-1-7-3)
[INFO]     functools32 (https://pypi.python.org/pypi/functools32)
[INFO]     hashids (https://pypi.python.org/pypi/hashids)
[INFO]     jinja (http://jinja.pocoo.org/docs/switching/#jinja1)
[INFO]     mox (https://pypi.python.org/pypi/mox3)
[INFO]     multiprocessing (http://docs.python.org/3/library/multiprocessing.html)
[INFO]     mysql-python (https://pypi.python.org/pypi/mysqlclient)
[INFO]     ordereddict (http://docs.python.org/3/library/collections.html#collections.OrderedDict)
[INFO]     pil (https://pypi.python.org/pypi/Pillow)
[INFO]     py-bcrypt (https://code.google.com/p/py-bcrypt/)
[INFO]     pycountry (https://pypi.python.org/pypi/pycountry)
[INFO]     pypdf (https://pypi.python.org/pypi/PyPDF2)
[INFO]     pyrss2gen (https://pypi.python.org/pypi/PyRSS2Gen)
[INFO]     pysqlite (http://docs.python.org/3/library/sqlite3.html)
[INFO]     ssh (https://github.com/bitprophet/ssh/)
[INFO]     ssl (http://docs.python.org/3/library/ssl.html)
[INFO]     suds (https://pypi.python.org/pypi/suds-jurko)
[INFO]     trisdb-py (https://github.com/tiepologian/trisdb-py/blob/master/setup.cfg)
[INFO]     unittest2 (http://docs.python.org/3/library/unittest.html)
[INFO]     uuid (http://docs.python.org/3/library/uuid.html)
[INFO]     warlock (https://github.com/bcwaldon/warlock/blob/master/tox.ini)
[INFO]     wsgiref (http://docs.python.org/3/library/wsgiref.html)
[INFO] Checking top-level project: cmsplugin-filer ...
[INFO] Locating cmsplugin-filer
[INFO] Dependencies of cmsplugin-filer: ['django', 'django-sekizai', 'django-filer', 'django-appconf', 'easy-thumbnails', 'django-cms']
[INFO] Checking dependency: django ...
[INFO] Checking dependency: django-sekizai ...
[INFO] Checking dependency: django-filer ...
[INFO] Checking dependency: django-appconf ...
[INFO] Checking dependency: easy-thumbnails ...
[INFO] Checking dependency: django-cms ...

You need 1 project to transition to Python 3.
Of that 1 project, 1 has no direct dependencies blocking its transition:

  cmsplugin-filer


Get UTC offset

How to get UTC offset to determine correct timings for every region. Like you have mentioned New York UTC offset which is -4 in hours. But how can we get UTC offset for every region in this format from latitude and longitude.

You can use this package to UTC offset for every region: https://pub.dev/packages/timezone


patch-add an echo for debugging bump-version.sh

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Remove db_context and connect_db references

Removed all references that were causing issues. There may be more, but we will find them later.


[objc] Enable method/property name customization via ExportAttribute

https://github.com/mono/Embeddinator-4000/pull/482 enables customization of class names surfaced to ObjC by re-using the [Register] attribute.
The same would be useful for method and property names. In Xamarin.iOS/Mac we already have [Export] which could potentially be re-used for this.

Centralizing with https://github.com/mono/Embeddinator-4000/issues/481


Script housekeeping

What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
Scripts should be able to handle eventual whitespaces in filenames.

/assign @fisherxu


Update Assessment Scorecard and Reading Attitude Survey

https://www.figma.com/file/O2igPzMS1fZPzjmOxlo6Mc/TLP-Wireframes?node-id=272%3A7757
Designs are on the bottom right of the "[Master Teacher] Consolidated" page. You can ignore the navigation bar at the top of the design.

/cib update-scorecard-survey

Branch 27-update-scorecard-survey created!


Infinite redirects in single user mode

Describe the bug
When in single user mode, if you have not yet logged in with the browser, a redirect (HTTP 302) loop between / and /users/sign_in occurs. The easiest way to see this is using curl.
To Reproduce
Steps to reproduce the behavior:

curl -D - -L http://main-manyfold-url
See edited curl log below for error

$ curl -D - -L http://main-manyfold-url
HTTP/2 302
date: Tue, 07 May 2024 09:14:29 GMT
content-type: text/html; charset=utf-8
location: https://main-manyfold-url/users/sign_in
cache-control: no-cache
set-cookie: <snip>
x-runtime: 0.037455
cf-cache-status: DYNAMIC
report-to: <snip>
server: cloudflare
cf-ray: 8800199bbfd86a1d-MCI
alt-svc: h3=":443"; ma=86400

HTTP/2 302
date: Tue, 07 May 2024 09:14:29 GMT
content-type: text/html; charset=utf-8
location: https://main-manyfold-url/
cache-control: no-cache
content-language: en
referrer-policy: strict-origin-when-cross-origin
set-cookie:  <snip>
x-content-type-options: nosniff
x-download-options: noopen
x-frame-options: SAMEORIGIN
x-permitted-cross-domain-policies: none
x-request-id: 92848d34-50e0-4571-910f-7f25ca34f33e
x-runtime: 0.028549
x-xss-protection: 0
cf-cache-status: DYNAMIC
report-to: <snip>
server: cloudflare
cf-ray: 8800199c28546a1d-MCI
alt-svc: h3=":443"; ma=86400

HTTP/2 302
date: Tue, 07 May 2024 09:14:29 GMT
content-type: text/html; charset=utf-8
location: https://main-manyfold-url/users/sign_in
cache-control: no-cache
set-cookie: <snip>
x-request-id: 911d97dd-635d-42c8-90e7-853e15b5f9d0
x-runtime: 0.010452
cf-cache-status: DYNAMIC
report-to: <snip>
server: cloudflare
cf-ray: 8800199c788e6a1d-MCI
alt-svc: h3=":443"; ma=86400

HTTP/2 302
date: Tue, 07 May 2024 09:14:29 GMT
content-type: text/html; charset=utf-8
location: https://main-manyfold-url/
cache-control: no-cache
content-language: en
referrer-policy: strict-origin-when-cross-origin
set-cookie: <snip>
x-content-type-options: nosniff
x-download-options: noopen
x-frame-options: SAMEORIGIN
x-permitted-cross-domain-policies: none
x-request-id: 15baf06a-c99d-45f6-9471-feee35180a4a
x-runtime: 0.023633
x-xss-protection: 0
cf-cache-status: DYNAMIC
report-to: <snip>
server: cloudflare
cf-ray: 8800199ca8cb6a1d-MCI
alt-svc: h3=":443"; ma=86400

<snip more redirects>

curl: (47) Maximum (50) redirects followed

Expected behavior
An HTML page is returned.
Additional context

Manyfold Version: 0.65.0 (992508e)
Running in Docker container using docker compose:

services:
  app:
    image: ghcr.io/manyfold3d/manyfold
    ports:
      - 3214:3214
    volumes:
      - ./libraries:/libraries
    environment:
      DATABASE_URL: postgresql://${DB_USER}:${DB_PASSWORD}@db/${DB_BASE}?pool=5
      SECRET_KEY_BASE: ${SECRET_KEY_BASE}
      REDIS_URL: redis://redis:6379/1
    restart: unless-stopped
    depends_on:
      - db
      - redis
    networks:
      - vandam
    links:
      - db
      - redis
  db:
    image: postgres:15
    volumes:
      - pg-data:/var/lib/postgresql/data
    environment:
      POSTGRES_USER: ${DB_USER}
      POSTGRES_PASSWORD: ${DB_PASSWORD}
    restart: unless-stopped
    networks:
      - vandam
  redis:
    image: redis:7
    restart: unless-stopped
    networks:
      - vandam
    volumes:
      - redis-data:/data
networks:
  vandam:
volumes:
  redis-data:
  pg-data:

I noticed this when upgrading to the latest version of Manyfold and my server monitor failed with a "too many redirects" error. To temporarily resolve the issue, I enabled multi-user mode and disable registrations.

That's definitely not right! It might redirect invisibly at first, but it certainly shouldn't be doing it in a loop. I'll investigate.

Ah, yes, curl without cookies will do that, good spot. @staceybellerose are you seeing the same behaviour in your browser too though?

I initially detected the issue from my site monitoring software, Uptime Kuma, after I upgraded all my docker containers. I wasn't able to reproduce the issue in my browser(s).
To test if the Manyfold site was up, I set up an HTTP monitor, pointing at Manyfold's home page. After the upgrades, the monitor immediately failed, and the curl error is what I discovered after testing. After setting multi-user mode, the redirects stopped, so I stopped testing, and re-enabled my monitor.
Is there another way that I can test to verify that Manyfold is up, such as an API/REST call, or should I continue to use this method?

Yep, @matthewbadeau's healthcheck endpoint is the right way to do this. It'll be in the next release! Once you've confirmed that resolves the problem with your monitoring, we can close this I think, because the redirection is intended behaviour, it's just intended for interactive use with a full cookie-capable browser.

@matthewbadeau @Floppy The new /health endpoint works perfectly for monitoring. Thanks so much for the quick work!


Allow MultiPartItem without filename

Description
As discussed here on Stackoverflow, we would send multipart files without a filename. This PR adds an additional property omitFilename in order to send requests without a filename in Content-Disposition.

Type of change :

[X] New feature

Thanks for the fast feedback! 👍

I've tried the suggested multipart entity option but with this option we are missing the 'Content-Disposition: form-data; name="myfile.txt"' part
Sorry, I'm totally with you. I'll add a test-case and update this PR

@a-st no worries ! it may be a little hard to create a test-case, so let me know if you get stuck
I also think that defaulting filename to key name was a mistake :( I really don't like omitFilename - I don't mind introducing a breaking change, so can you look at this option as well ? some existing tests may break, but should be ok to change behavior

I also think that defaulting filename to key name was a mistake :(

Actually I would like to prefer this solution as well. For example the Apache MultipartEntityBuilder does not automatically set filename=name if filename is set to null
MultipartEntityBuilder.create().addBinaryBody("fieldname", "myfilecontent".getBytes(), ContentType.APPLICATION_OCTET_STREAM, null).build();
Maybe we should just remove the fallback logic, because this might be less error prone and there is basically no risk of introducing regression


[AUTHZ][MINOR] Remove incorrect getUri method

:mag: Description
Issue References 🔗

This pull request remove incorrect getUri method in authZ module, This method is currently not applicable in any context, and it is incorrect as it ought to return a List type rather than a String.
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes :bookmark:

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests

Checklist 📝

[x] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

Thanks, merged to master


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 866

Questions ?
Please refer to the Backport tool documentation


Add repo file resource

Is your feature request related to a problem? Please describe.
There is no declarative means to create/read/update/delete a file in/from/in/from a repository in gitea.
Describe the solution you'd like
Add a gitea_file or, alternatively, a gitea_repository_file resource that adds a file to a repository in gitea using https://gitea.com/gitea/go-sdk/src/branch/main/gitea/repo_file.go
Describe alternatives you've considered

Single-purpose operator that uses gitea go api directly
Single-purpose operator that uses gitea API directly

Additional context
Ultimately I need a crossplane provider to be able to add a file to a repository in gitea. The shortest path to that is to add the resource to the gitea terraform provider and then generate the crossplane provider from the terraform provider using terrajet. I already have this terrajet provider so the only piece that's missing is the new resource in the terraform provider.
I am willing to implement this but I would need guidance, as you already know, to approximate the quality of the rest of the gitea terraform provider. I am also willing to implement tests but, again, I would need guidance.

This seems like a more generic problem and something that is very specific to your usecase. might i suggest to checkout https://github.com/arl-sh/terraform-provider-git to have a separation of concerns here?

Ping @juddowilcox ,
did you check out the other provider i mentioned?

Closing due to inactivity


How to access AMD GPU with PyTorch

Using PyTorch we are able to access AMD GPU by specifying device as 'cuda'.
Is this the recommended way to access AMD GPU through PyTorch ROCM?
What about 'hip' as a parameter for device?
from transformers import GPT2Tokenizer, GPT2LMHeadModel

tokenizer = GPT2Tokenizer.from_pretrained('gpt2', device_map="auto")
model = GPT2LMHeadModel.from_pretrained('gpt2', device_map="auto")
prompt = "What is Quantum Computing?"

encoded_input = tokenizer(prompt, return_tensors='pt')
encoded_input = encoded_input.to('cuda')

output = model.generate(**encoded_input, max_length=100)
print(tokenizer.decode(output[0], skip_special_tokens = True))

Is this the recommended way to access AMD GPU through PyTorch ROCM?

Yes, that is the recommended way, which I use, according to https://rocm.docs.amd.com/en/latest/how_to/pytorch_install/pytorch_install.html

What about 'hip' as a parameter for device?

HIP aims to be compatible with CUDA. Many PyTorch projects only care about CUDA, and we are lucky that we can just install the ROCm version of PyTorch and it will still work with 'cuda' as a parameter.

Thanks @danielzgtg, @jithunnair-amd for your response.


geojson custer style and properties

I created a public workspace to compare a grid resolution cluster with openlayers geojson cluster.
https://github.com/GEOLYTIX/mapp/blob/main/workspaces/geojson_cluster.json
The data is GEOLYTIX Retail Points hosted in a public database. https://bit.io/dbauszus/geolytix
https://geojson-cluster.vercel.app/
The geojson layer is defined as cluster with cluster config block. The only supported key is the distance (in pixel) for the cluster source.
"cluster": {
 "distance": 50
},

The cluster aggregation method is now checking whether features have properties to assign.

The properties are required for theming for example. Also for labels.
Without assigning the retailer property on the geojson feature we wouldn't be able to style for the retailer property.

You need to define an icon style.
        "cluster": {
            "clusterScale": 2,
            "icon": {
                "type": "dot",
                "fillColor": "#009"
            }
        },

@simon-leech  Geojson will not recognise the tables object since data is cached and not loaded on zoom change.

I updated the layer hover to check for properties.count > 1 instead of whether the layer.format is cluster.
The layer filter and coordinates will only be sent if the feature.count is more than 1. It doesn't make sense to have a filter and coordinates for a feature identified by an id.

The filter method in the categorized switch click event is now debounced.


perception time: use common timer to remove perception timer

perception/utils/timer is the same as common/time/timer


Customize Form error's

Description
There seems to be no option to customize Form errors. Currently it is a <p> tag.

Feature request:

The html should customizable
The applied classes should be customizable
The applied classes of the input should be customizable

Additional context
No response

You can actually do all of the above. Use the error slot of the FormGroup component: https://ui.nuxt.com/forms/form-group#error-1 if you want to change the html. This example will also show you how to customize the input when an error is present. You can also change the classes through the ui prop or app.config: https://ui.nuxt.com/forms/form-group#config

Thanks, oversaw this :)

I am reopening this: Yes it is possible to customize the error of the FormGroup but it needs to be set to each FormGroup. Having a huge form it would be great if the Form itself has an error-slot.

Why not use the app.config.ts to customize your ui prop globally or even make your own component on top of the FormGroup?

Good ideas, thanks gor the quick response!


Enable multiple sensors for 411i Max

A number of items are not showing up on my 411i Max models. I would be happy to provide info/data dumps to help you make these features work.

I also have a 411i Max and see similar results as @musicjeremy. However, I'm fairly sure the 411i Max only has a PM 2.5 sensor in it. In the Blueair app I also only see PM 2.5 readings. I believe this is functioning as expected.
I think the only integration improvement would be to hide/disable those sensors if the model is 411i Max. If it helps, the device SKU of the 411i Max is 110057.
Great integration, works well!

@nickwest is correct. There's only PM2.5 for the 411i Max. The only reason these sensors are showing up is because they are available on the models the integration was originally written for. I just went into the the entities and disabled them which works well enough. Model handling could be implemented to make sure these entities only show up on supported models but as it is right now it doesn't break anything plus it would be hard to test.

I think 411i max should only have the pm25 sensor in version 1.13.0 (if they were previously added they will still exist but will now have a delete button)

311i Max should also have only PM25.

311i Max should also have only PM25.

updated in v1.14.1

Just grabbed 1.14.1 and PM25 is now Unavailable.
The other 5 sensors (VOC, PM1, etc.) are still there as disabled.  When I enable they show no state nor have an option to be deleted.

Just noticed this in the log:
Error adding entity sensor.air_purifier_pm25 for domain sensor with platform ha_blueair
TypeError: unsupported operand type(s) for *: 'NoneType' and 'int'

Just noticed this in the log:
Error adding entity sensor.air_purifier_pm25 for domain sensor with platform ha_blueair
TypeError: unsupported operand type(s) for *: 'NoneType' and 'int'

1.14.2 fixes a typo that caused that error


Kami Baby Support

Continuing the ticket in the roleoroleo/yi-hack-Allwinner-v2 project.
I would like to test a beta version for Kami Baby.
Serial number is starting with LFUS, firmware version is <IP_ADDRESS>C.
Firmware backup: https://drive.google.com/file/d/1rSXdw0ar4VVb0X1-tJpdtiU8fOVGA9sa/view?usp=sharing
Also, this camera has temperature and humidity sensors, any chance I can read them and expose them to Home Assistant integration?
The camera also has night vision support, will it also work? will it be possible to control it?
Thanks a lot!

Please, try this new beta firmware:
y501gc_0.3.6.tar.gz

Also, this camera has temperature and humidity sensors, any chance I can read them and expose them to Home Assistant integration?

At the momento it's not possible, and without a cam under my hands it's very difficult to develop this feature.

The camera also has night vision support, will it also work? will it be possible to control it?

You can control the enable/disable, but when you enable it the cam will switch on/off automatically.

Hi,
Thank you for the firmware!
I've managed to load it into the camera, but I'm unable to view the rtsp stream or take a snapshot.

Adding the I was able to see the temperature and humidity value with dmesg:
[  133.684747] ----sht3x temperature(26833), humidity(56146)----
root@yi-d203:~/bin#

I Wrote a small script that fetches the temp data from dmesg and publishes it in MQTT:

Ok, I will try to add to the hack.

More than that, the camera also has a light that i would really like to control from HA, I've ran ipc_read while toggling the light switch in app, the strange thing is that I'm getting the same message for both on and off, does it make sense to you?

Probably the message you sniffed is not related to this function but you can try.

If so, I'll try to compile ip_cmd with it and try to run it

It's not necessary, you can load a message from file with ipc_cmd.
Save the file in binary mode with:
echo -ne '\x40\x00 ....' > /tmp/sd/message.bin

can it cause damage to the camera?

I can't be sure but it's never happened to me.
And I have executed many commands...

About the stream, please send me a copy of your buffer /dev/shm/fshare_frame_buf

https://drive.google.com/file/d/1-K7e7LzqW91J6t0hKw_Dx4UXc3wZGa-z/view?usp=sharing

It's not necessary, you can load a message from file with ipc_cmd.
Save the file in binary mode with:
echo -ne '\x40\x00 ....' > /tmp/sd/message.bin
That's great! Thanks!
I didn't work with that message, but now it will be easier to research.

Another update:
The correct message for light on is:
\x01\x00\x00\x00\x08\x00\x00\x00\x22\x40\x01\x00\x01\x00\x00\x00\x01
For light off its:
\x01\x00\x00\x00\x08\x00\x00\x00\x22\x40\x01\x00\x01\x00\x00\x00\x00
The light also has an option to control the brightness and it has a physical button as well.
I'll try to compile the code and implement it as a light entity in HA.
Thanks for all the help.

Another update: The correct message for light on is: \x01\x00\x00\x00\x08\x00\x00\x00\x22\x40\x01\x00\x01\x00\x00\x00\x01 For light off its: \x01\x00\x00\x00\x08\x00\x00\x00\x22\x40\x01\x00\x01\x00\x00\x00\x00
The light also has an option to control the brightness and it has a physical button as well. I'll try to compile the code and implement it as a light entity in HA.
Thanks for all the help.

Great! Keep me updated.
About the stream, try to overwrite the standard binaries with the content of this archive.
It should work, both rtsp and snapshot.
kami_stream_prg.tar.gz

Great! Keep me updated.
About the stream, try to overwrite the standard binaries with the content of this archive.
It should work, both rtsp and snapshot.
kami_stream_prg.tar.gz

Still, doesn't stream either RTSP or snapshot.
Running the RTSP (and h264grabber_h) server with -d 3 gives the following error:
root@kami-baby:~/bin# rRTSPServer -m y501gc -r high -d 3
1695465909804: the size of the buffer is 1786224
1695465909805: mapping file fshare_frame_buf, size 1786224, to b6c11000
1695465909806: closing the file fshare_frame_buf
1695465909806: starting capture main loop
1695466018218: warning - -1 frame(s) lost

h264grabber is not needed anymore to run rRTSPServer.
It seems that rRTSPServer is not able to detect the type of stream.
Please try low res stream.

h264grabber is not needed anymore to run rRTSPServer.
It seems that rRTSPServer is not able to detect the type of stream. Please try low res stream.

Same result with the low res stream.
It doesn't seem to even listen to 554.
Any other logs that could be useful for you?

https://drive.google.com/file/d/1BDX-IPlz9tgViZYksVgZZOIKqz1OoO2E/view?usp=sharing
This is another stream i captured (last one was with nc, maybe it was incorrect?)
Any other way you recommend to capture it?
Thanks!

Ok, try this one:
kami_stream_prg_2.tar.gz

Ok, try this one: kami_stream_prg_2.tar.gz

Seems to be working!
low res is working smoothly (both stream and snapshot).
high res stream is showing a gray screen every 10 secs or so, and snapshot is not working.
But that's good for me :)
Could it be that the high res stream is heavy on the camera resources?
Thank you!

Could it be that the high res stream is heavy on the camera resources?

Maybe but I will check again. High res snapshot should work.
Did you enable swap space?

Oh, I found a problem in the ffmpeg compilation flags.
Try this:
imggrabber.gz

Oh, I found a problem in the ffmpeg compilation flags. Try this: imggrabber.gz

Worked :)
Thank you!

I will add Kami Baby to the next release.

Can you wait for my light control implementation? 🙃

Yes, no problem.
Could you check if temperature and humidity values are available in any ipc message?

Will do 😃

Another small issue with the snapshot service: calling snapshot.sh with watermark=no causes the snapshot to fail.

This is strange.
Did you try 2 or 3 times?
It may happen that the cam is busy and returns error.

Tried multiple times, didn't work.
Also, the high res stream seems very unstable, I'm getting a gray screen every few seconds.
VLC is reporting about a lot of lost frames: around 57 frame for 20 seconds of running.

Sure, I can test it.
It will be compatible with my model?

Hi,
Installed the new version, still seeing some hangs.
Any logs i can supply to help you understand the problem?
Thanks!

Yes, try to run this version with -d 15.
Connect the client and post the output.

See here:
https://drive.google.com/file/d/1gX95aNLal256TpZQGAPFbYJ8GLn5XXRW/view?usp=sharing

Apart from a few lost frames at the beginning there are no errors in the log.
All frames are properly processed.
Please try:

using ffmpeg as a client - ffmpeg -i rtsp://IP/ch0_0.h264 test.mp4
running the daemon without audio.

I will check the code.
Is low res stream ok?

Low res stream seems stable.

If you can, please try a test with the camera close to the router.
Did you enable swap space?

Please, try this binary:
rRTSPServer.gz

If you can, please try a test with the camera close to the router. Did you enable swap space?

I tried testing it close to the router - still it happens - gray screen.
swap space is enabled.

Please, try this binary: rRTSPServer.gz

It seems much more stable, the gray screens are much less frequent.
Thank you

Ok, send me a log of the rtsp server.
Stop the watchdog, stop the server and start the server in debug mode:
killall wd_rtsp.sh
killall rRTSPServer
rRTSPServer -m y501gc -r high -a no -p 554 -d 3

Finally, post the output.

https://drive.google.com/file/d/1Y5CXaQ8jzB_5Ky4cg2dN_XP4Dh5ihNTM/view?usp=sharing

Reopening this, thanks for having the beta, somehow I used the latest release for the baby camera but I don't seem to see the Low Res streams or the Audio Only stream. Only the high res stream and has the same gray screen every ~10s issue.

Please, send me a copy of your frame buffer file fshare_frame_buf


Port moveit_core transforms submodule to ROS 2, unfinished

Do not merge until CI works just fine please.

Failing with the following:
/Users/victor/moveit_research/moveit/moveit_core/transforms/src/transforms.cpp:127:49: error: no viable conversion from 'const geometry_msgs::msg::TransformStamped_<std::__1::allocator<void> >::_transform_type' (aka 'const Transform_<std::__1::allocator<void> >') to 'const geometry_msgs::msg::TransformStamped' (aka 'const TransformStamped_<std::allocator<void> >')
    Eigen::Isometry3d t = tf2::transformToEigen(transform.transform);
                                                ^~~~~~~~~~~~~~~~~~~
/Users/victor/ros2_ws/install/geometry_msgs/include/geometry_msgs/msg/transform_stamped__struct.hpp:39:8: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'const geometry_msgs::msg::TransformStamped_<std::__1::allocator<void> >::_transform_type' (aka 'const Transform_<std::__1::allocator<void> >') to 'const geometry_msgs::msg::TransformStamped_<std::__1::allocator<void> > &' for 1st argument
struct TransformStamped_
       ^
/Users/victor/ros2_ws/install/geometry_msgs/include/geometry_msgs/msg/transform_stamped__struct.hpp:39:8: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'const geometry_msgs::msg::TransformStamped_<std::__1::allocator<void> >::_transform_type' (aka 'const Transform_<std::__1::allocator<void> >') to 'geometry_msgs::msg::TransformStamped_<std::__1::allocator<void> > &&' for 1st argument
/Users/victor/ros2_ws/install/tf2_eigen/include/tf2_eigen/tf2_eigen.h:46:78: note: passing argument to parameter 't' here
Eigen::Affine3d transformToEigen(const geometry_msgs::msg::TransformStamped& t) {

Which is connected to #6

Still getting the following error:
colcon build --merge-install --packages-select moveit_core
Starting >>> moveit_core
--- stderr: moveit_core
In file included from /Users/victor/moveit_research/moveit/moveit_core/transforms/src/transforms.cpp:37:
In file included from /Users/victor/moveit_research/moveit/moveit_core/transforms/include/moveit/transforms/transforms.h:42:
In file included from /usr/local/include/eigen3/Eigen/Geometry:44:
/usr/local/include/eigen3/Eigen/src/Geometry/Transform.h:331:5: error: static_assert failed "YOU_PERFORMED_AN_INVALID_TRANSFORMATION_CONVERSION"
    EIGEN_STATIC_ASSERT(EIGEN_IMPLIES(OtherMode==int(Affine)||OtherMode==int(AffineCompact), Mode!=int(Isometry)),
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/eigen3/Eigen/src/Core/util/StaticAssert.h:33:40: note: expanded from macro 'EIGEN_STATIC_ASSERT'
    #define EIGEN_STATIC_ASSERT(X,MSG) static_assert(X,#MSG);
                                       ^             ~
/Users/victor/moveit_research/moveit/moveit_core/transforms/src/transforms.cpp:127:27: note: in instantiation of function template specialization 'Eigen::Transform<double, 3, 1, 0>::Transform<2, 0>' requested here
    Eigen::Isometry3d t = tf2::transformToEigen(transform);
                          ^
1 error generated.
make[2]: *** [transforms/CMakeFiles/moveit_transforms.dir/src/transforms.cpp.o] Error 1
make[1]: *** [transforms/CMakeFiles/moveit_transforms.dir/all] Error 2
make: *** [all] Error 2
---
Failed   <<< moveit_core	[ Exited with code 2 ]

Summary: 0 packages finished [6.99s]
  1 package failed: moveit_core
  1 package had stderr output: moveit_core
The file /Users/victor/ros2_moveit_ws/None does not exist.

Found related issues at:

https://stackoverflow.com/questions/13956953/convert-an-eigen-affine-transformation-to-an-eigen-isometry-transformation
https://github.com/ros/geometry/issues/101


cannot handle the simplest 3D data

Description
The plugin will fail at the workflow selection step, if the user simply loads a 3d image. 3D array is probably the simplest form of the data or the most common format users may use for. So, it is important to handle simple 3D images.
Expected Behavior
the plugin needs to handle both 3d or 4d data.
Reproduction
https://github.com/AllenCell/napari-aicssegmentation/blob/feature/user-set-parameters/napari_aicssegmentation/core/layer_reader.py#L44

To clarify, by simplest 3D data you mean single-channel 3D images, right?

@jxchen01 can you send me a good 3D image you've used to test?

https://drive.google.com/file/d/1NstCG7oFTStXFUCWytry7UePdLO7sSev/view?usp=sharing
a sample data


Implement no-var .eslintrc rule

Clicked around in Chrome to double check the charts and graphs and Student Report, need to do the same in IE.

IE looks alright too although I wasn't able to open the Student Report PDF in the Windows VM.

Double checked prod, looks good.


Unable to compile the SignalR C++ client on MacOS

Describe the bug
I'm not able to compile the SignalR C++ client on MacOS.
To Reproduce
Steps to reproduce the behavior:

Using the most recent version of the repo and compiled the most recent version of the cpprestsdk
Running
CXX=g++ cmake .. -DCMAKE_BUILD_TYPE=Release -DCPPREST_INCLUDE_DIR=<path_to_cpp_rest_include_dir> -DCPPREST_LIB_DIR=<path_to_cpp_rest_lib_dir>
See errors in the screenshot below

Expected behavior
Successful compilation (library) of the SignalR cpp client.
Screenshots

This is expected right now. We haven't put any effort into the cross-plat build with CMAKE yet, but this is definitely on our radar.

Closing in lieu of https://github.com/aspnet/AspNetCore/issues/8706 which is tracking our cross-plat build integration work.


Add Ability to Strip Components from Blob Files

What:
This change adds a new field to the blob source that lets you specify the number of base directory components you want to strip from the path when extracting the files. This is similar in functionality to the the tar --strip-components argument.
The field will default to 0 so that if it is not set the existing build functionality is unchanged.
Why:
You might be receiving an archive blob from a third party in your build, where you have no prior knowledge of the parent directory name so you can't use the subPath option to specify the root. For example when using Githubs archive API the parent directory's name depends on if the repo is public or private, using Github Enterprise server or not etc. With this change you don't need to know the details but can tell kpack to strip 1 component when extracting and that will put the working dir for the build in the root of the repo archive.
Fixes: https://github.com/pivotal/kpack/issues/957

Looks good! I also ran the test locally and everything is fine. I just did it because the job is pending on github.
Great job @diarmuidie !

Thanks @jjbustamante . Looks like the tests aren't running because I'm a first time contributor:

1 workflow awaiting approval
First-time contributors need a maintainer to approve running workflows

Thanks so much @diarmuidie !


Swipe left on first sensor card to bring dashboard

Description:
User is on first sensor card and swipes left to go back to overview.
Actual:
Nothing happens
Expected:
Show dashboard
iOS card: https://github.com/ruuvi/com.ruuvi.station.ios/issues/1299

Please let's not implement this. You already can go from any sensor card back to dashboard by swiping. All you need for this is abandon outdated 3-buttons navigation and use geasture navigation. It's 2023 outside. I really don't get why you still use it with latest smartphones. @markoaamunkajo @laurijamsa
https://user-images.githubusercontent.com/24788772/221842218-d937ac41-a256-4a0e-9fdc-14c4185600d5.mp4

Compared few applications, and found this gesture is only default on something like Twitter. Let's close this for now, since we don't see the benefit from implementing it.


Possibility to remove png chunk (options and extensions)

What are you trying to achieve?
I try to achieve a replacement of pngcrush by sharp. pngcrush has the ability to remove chunk that are optional. I personnally use : pngcrush -rem alla -remove input.png output.png.
This is an extract of the doc :
-rem chunkname

Name of an ancillary chunk or optional PLTE to be removed. Be careful with this. Please don't use this feature to remove transparency, gamma, copyright, or other valuable information. To remove several different chunks, repeat: -rem tEXt -rem pHYs. Known chunks (those in the PNG spec or extensions document) can be named with all lower-case letters, so -rem bkgd is equivalent to -rem bKGD. But note: -rem text removes all forms of text chunks; Exact case is required to remove unknown chunks. To do surgery with a chain-saw, -rem alla removes all known ancillary chunks except for tRNS, and -rem allb removes all but tRNS and gAMA.

What would you expect the API to look like?
I would expect that the PNG output would produce PNG without optional chunks. Ancillary chunks would be kept only if withMetadata() is used.
I already asked the question to libvips project. It seems possible without changing the libvips.
Ref : https://sourceforge.net/p/pmt/code/ci/pngcrush/tree/pngcrush.c
http://www.libpng.org/pub/png/book/chapter11.html#png.ch11.div.5

Hi, let's continue this at https://github.com/libvips/libvips/issues/1336 as sharp is relying on libvips to access lower-level libpng features.

Yes, sure.


net/http: Malformed HTTP status code

Test code to reproduce the issue can be found at https://github.com/c4milo/gofetch. This one only happens consistently in Go 1.4.x.

Yes, same result.

I just saw it happening in Go 1.5.1. But, I can't reproduce reliably.

That code has many missed error checks.  You're also copying the value of mutexes.
This has enough red flags that this is user error that I'm going to close this report for now. If you have something with complete error checks, no races, and ideally self-containing and easy for me to run and reproduce I can look into it more.


Crash when going to the end

Describe the bug
When we go to the end, the server crashes. We already killed the dragon and explored the end.
Versions:

Minecraft: 1.18.1
Forge: 39.0.76
Progressive Bosses: 3.5.0
InsaneLib: 1.4.3

Steps to reproduce
We already killed the dragon one time and built something in the end.
But some time later, the server crashes when we try to go again to the end.
Expected behavior
No crash
Logs
Crash stacktrace + some extras; https://gist.github.com/Seniorendi/b259fffa1b47ff50c0fcfa4854faba83
Can the issue be reproduced with a mininal set of mods? (E.g. Progressive Bosses + InsaneLib + Tinkers' Construct)
Didn't test, don't really have the time.
I'll test it when I get the time.

Downgrade InsaneLib to 1.4.2

kay


Draft: CNF-10171: Update port for kpi results host

CNF-10171 will be moving the internal kpi results host to be using port 80 instead of 8080
This will align the link on the page to the new port
The server will be temporarily listening on both ports for an interim time until all alignment work (this pr and some others in other components) are completed, at which point the server will stop listening on 8080

/hold

/ok-to-test

/unhold


x/build/cmd/updatecontrib: update to work with module-aware mode

The updatecontrib app does not function when run while Go is configured to have module mode enabled. It should be adapted to run while module mode is enabled.
@golang/release

updatecontrib is no longer used after the change in #53961, and CL 419075 deleted it.
Closing this as obsolete.


How to use?

Do I install this into a pre-existing Strapi installation?
Does it automatically register itself?
I'm not sure how to use this.

yarn build --clean
or
npm run build -- --clean

Hello,
As @heyjaypray says, you can add this plugin to an existing project and run build clearing the cache.
Among the community there are more plugins that you can install to improve your project, here you can find some information about strapi plugins here.