(Bug) #873 ios add to home screen small popup should match design

Description
Move the bottom margin between custom buttons and popup content from the content element to the custom buttons element.
About #873
How Has This Been Tested?
Register/login to the app from ios device/simulator.
You will see addWebApp popup.
Press add Icon
see the small popup for ios with explanations
Checklist:

[x] PR title matches follow: (Feature|Bug|Chore) Task Name
[x] My code follows the style guidelines of this project
[x] I have followed all the instructions described in the initial task (check Definitions of Done)
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have added reference to a related issue in the repository
[x] I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
[x] I have added screenshots related to my pull request ( for frontend tasks)
[ ] I have pasted a gif showing the feature.
[x] @mentions of the person or team responsible for reviewing proposed changes

Screenshot:

@AnastasiiaOdnoshevna need to verify other modals design was not effected


tests - able to load multiple profiles

Currently, we are hardcoding a url in the"retrieve" function of config-test.js.   This means we can only retrieve a single profile.
perhaps we can make use of

jest spyOn https://jestjs.io/docs/en/jest-object#jestspyonobject-methodname for bfe.retrieve or bfeditor.retrieve or whatever it is
jest mock bfe.retrieve or bfeditor.retrieve or whatever it is. https://jestjs.io/docs
redefine retrieve function, do page.reload? (https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#pagereloadoptions)
inline function definition for page.waitForFunction (https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#pagewaitforfunctionpagefunction-options-args)

Required by #55
See also #70

see also improve-testabilitybranch


Update persisted-queries.md

Adds persisted-queries documenattion
Related converetr pull-req repo: https://github.com/ChilliCream/hotchocolate-examples/pull/31

@damikun sorry for the wait. I have put that on my stack now :)

Any plans on this or point that I can rewrite?  :)

@damikun just looked at it yesterday and merge main back in so that it is technically mergeable.

I'm also going to take a look!

Okay, so I restructured the documentation and removed some parts that I felt like didn't belong in there.
Of course these changes can always be reverted! @damikun I'm sorry for changing so much. I hope you don't mind :sweat_smile:
What I did:

Also showcased how it would work with Redis
I removed a bunch of stuff that is already covered by the Relay documentation and just left notes in the appropriate sections (for example about the doc_id)
Reworded some parts and removed some repetitive sections

There are still some todos I will cover:

Blocking non-persisted queries
How queries need to be stored in Redis

I will work on them right now. Just wanted to get this initial change up.
Feedback is appreciated and thanks again for your initial work on this @damikun. Made it much easier for me to iterate on it now! :smile:

@tobias-tengler yes and no :D
we should handle it, further we should be able to handle multiple of them. So if multiple are in the folder we should handle them as well. Lets create an issue for that and work details out on there.

Good rewrite Tobias... You are good in understanding and writing Doc it will be better if you finish it..

Any reason why this was retargeted to develop, while being added to the 11.3 milestone? There aren't any preview features being documented here. I think it can go straight into main...

Notes for StrawberryShake setup with persisted queries

In your .graphqlrc.json, add under extensions > strawberryShake a property called requestStrategy with a value of `"PersistedQuery".
Optionally set the hashAlgorithm property (by default it is "md5")
Configure the output directory were the queries should be written to by adding a property to your csproj called StrawberryShake_PersistedQueryDirectory.

This needs to be an absolute path
Without the MSBuild property, the client generation will fallback to the default request strategy. This can be leveraged to conditionally opt-in/out of persisted queries during local development by adding a condition to the property to it is only defined when desired.
Be careful not to output your persisted queries into a path picked up by your GraphQL config file's documents setting, else Strawberry Shake will consider them new queries to generate code for which will obviously conflict with the original ones.

3.3 caused me issues. GraphQLConfig isn't setup to support an array of globs, so I couldn't do an opt-in and an opt-out setup. So I tried to do a separate subfolder for my defined queries, e.g. Operations/**/*.graphql and then output to PersistedQueries, but the build was passing but not producing any generated code. 🤷🏻 I checked DotNet.Glob docs, not sure whether it's me or what, but there's probably some limitations with the current implementation of graphql config.

@benmccallum I won't cover this in this PR, but I derived an issue from your comment.
If you feel like it, you could also start a PR for the StrawberryShake documentation! :)

I will merge this one an we can refine in follow-up prs.


chore: Setup Dependabot for version updates

What is the purpose of this pull request?

[ ] Documentation update
[ ] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[x] Other, please explain:

What changes did you make? (Give an overview)
Setup Dependabot for non-security PRs, but avoid double building them in CI

I ended up merging #229. ANy differences I should be aware of?

Yes, the other will will cause double builds for the dependabot PRs, and will only open 5 at a time. i'll resubmit this

@xjamundx actually if you want to re-open this, I can just rebase it


Private to only people on my host

As an author, posts I create be private to only friends on my host

Is this not part of the API? I understood this as only sending posts which correspond to friends on the "origin" host for the post. There is a setting in the request for this permission and we are currently allowing the client to specify the origin for a post.
I suppose we do need a way to add friends through the ui, though

yes, we just need a way for you guys to specify who can view it


Var substitution does not work?

Describe the bug
Injecting variables into json files seems not to work. I also set import_var-substitution=true in my docker-compose.yml but the value is set as literal.

To Reproduce

Clone this repository
Remove benchmark.yml (it contains errors) and reduce moped.json to this content:

{
  "id": "moped",
  "realm": "moped",
  "displayName": "MOPED Realm",
  "displayNameHtml": "${env:MY_ENV_VARIABLE}"
}

Configure the docker-compose file as following (I fixed it as well)

version: '3'
services:
  keycloak:
    image: jboss/keycloak:11.0.2
    environment:
      KEYCLOAK_PASSWORD: admin123
      KEYCLOAK_USER: admin
    volumes:
      - ./providers/:/opt/jboss/keycloak/providers/
    networks:
      - keycloak
    ports:
      - "8080:8080"
      - "8787:8787"
    command:
      - "-c"
      - "standalone.xml"
      - "-Dkeycloak.profile.feature.upload_scripts=enabled"

  keycloak-config-cli:
    image: adorsys/keycloak-config-cli:v2.5.0-11.0.2
    depends_on:
      - keycloak
    networks:
      - keycloak
    volumes:
      - ./contrib/example-config:/config
    environment:
      - keycloak_url=http://keycloak:8080
      - keycloak_user=admin
      - keycloak_password=admin123
      - import_var-substitution=true
      - MY_ENV_VARIABLE=test

networks:
  keycloak:

Expected behavior
displayNameHtml should be test instead of ${env:MY_ENV_VARIABLE}
Environment (please complete the following information):

Keycloak Version: 11.0.2
keycloak-config-cli Version: v2.5.0-11.0.2 (as well latest)
Java Version: Running in docker (i.e. 11)

Thats funny. Got this 3 days ago.

I also set import_var-substitution=true

Check: https://github.com/adorsys/keycloak-config-cli/issues/240#issuecomment-720803016
You have to remove the hyphen here.

Thanks @jkroepke it works properly now. I also see the checksum feature. Are there any plans to release that soon?

Are there any plans to release that soon?

I would like to give https://github.com/adorsys/keycloak-config-cli/pull/239 a chances to get it done.
In meanwhile, import.force=true is your workaround until next release.


NewConfigurationFileMechanism

This change is

Review status: 0 of 6 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

webtester-core/src/main/java/info/novatec/testit/webtester/config/adapters/ClasspathPropertiesFileConfigurationAdapter.java, line 49 at r1 (raw file):

        RECOMMENDED {
            public void handleFileNotFound(String path) {
                logger.info(FILE_NOT_ON_CLASSPATH, "Optional", path);

"Optional" >> "Recommended"

Comments from Reviewable

Reviewed 5 of 6 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

Comments from Reviewable


Feature/addword user

Add the word user beside welcome.

@EROSSHINI Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


Update local-accounts.md

as per the user report #7146,  so  i replaced  this  sentence User Account Control: Run all administrators in Admin Approval Mode    with
this new sentence  User Account Control: Admin Approval Mode for the Built-in Administrator account
so this PR must be checked twice or thrice before merging. Also, the style format should be checked.

#sign-off

@e0i .  Please look into this PR #7147

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

Replaced link targets are broken. Closing.


[5.5][SourceKit] Don’t transform type when printing if CurrentType can’t have members

Since 9ba892c we always transform CurrentType in ASTPrinter to be an interface type.
This causes issues when the variable type is a generic parameter type. Previously we had CurrentType set to a PrimaryArchetypeType. With the fix in d93ae06, we are mapping the archetype out of context to a GenericParamType. A GenericParamType, however, can’t have members, so we’re hitting an assertion when creating a TypeTransformContext. Since the entire type transformation in printTransformedTypeWithOptions is only affecting type members, we should be able to safely skip over the transformation if CurrentType can’t have any members.
Cherry-picks https://github.com/apple/swift/pull/36989

@swift-ci Please test


Allow to inspect reward accounts wrt #46

The PR should come with additional tests cases covering this two new cases. See existing scenarios in: https://github.com/input-output-hk/cardano-addresses/blob/master/command-line/test/Command/Address/InspectSpec.hs#L17

done

To consider: allowing to generate these addresses via cardano-addresses.


Javad

add neo4j backend

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add .NET Core 3.1 TFM

Only one warning left.
Do we want to ensure non-null return here?
https://github.com/microsoft/clrmd/blob/fb1fa753c54e35e3468612d8b6f27843c70619f3/src/Microsoft.Diagnostics.Runtime/src/Builders/RuntimeBuilder.cs#L192-L196

(The power and internet is going on and off at my house, so I may not be able to respond further today, depending on the weather situation.)

Do we want to ensure non-null return here?

Interesting, it's surprising the compiler missed that before?  That function is intended to return ClrModule? also the method needs to lock _modules.  Can you replace that function with this:
    private ClrModule? GetModule(ulong addr)
    {
        lock (_modules)
        {
            _modules.TryGetValue(addr, out ClrModule module);
            return module;
        }
    }

Then update everything that calls it to accept ClrModule? (including the constructor for ClrmdArrayType).  That should resolve the problem and fix the concurrency bug of not locking _modules when reading from it.

Even in good weather my network was down for a whole day.

Interesting, it's surprising the compiler missed that before?

.NET Core 2.1 doesn't have the nullable attributes (including NotNullWhen which is causing problems now).


🚨 Analyze repos with fatal infos

New Pull Request Checklist

[ ] I have read the Documentation
[ ] I have searched for a similar pull request in the project and found none
[ ] I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
[ ] I have added the required tests to prove the fix/feature I'm adding
[ ] I have updated the documentation (if necessary)
[ ] I have run the tests without failures
[ ] I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

https://github.com/cfug/dio/actions/runs/4550944656/jobs/8024469534?pr=1773
By adding the info lint level to be fatal, we can match the condition in publish dry-run to avoid failing to publish packages.


Install-WindowsUpdate clashes with BoxStarter

Using BoxStarter to install some Chocolatey packages.
One of the packages installs a Windows Update using Install-WindowsUpdate
The problem is that the package ends up using the BoxStarter version instead of the one from here.

Did some more searching, looks like this has been seen before

https://github.com/chocolatey/boxstarter/issues/293


Allow PHP 8.2

Puhsed version bumbs of webmozart/assert and phpunit/phpunit so the prefer-lowest PHP 8.2 build is also green.

Good morning, thanks for the patch! Now 7.4 fails but since this version isn't used that much anymore i suggest to just drop it?

Should I go ahead and drop PHP 7.4 and PHP 8.0 support?
Sound OK for me.

Not sure why a PHP 7.1 build is still started.

Sorry, you have to delete the https://github.com/bcremer/typed-input/blob/allow-php82/.laminas-ci.json, i had to do an override for 7.4, totally forgot about it :facepalm:

Thank you, i created a release! :handshake:


Add LICENSE for finschia

Add LICENSE for finschia
This license is the same as Finschia/finschia.
https://github.com/Finschia/finschia?tab=Apache-2.0-1-ov-file#readme
https://github.com/Finschia/finschia-sdk/blob/main/LICENSE

According to https://www.apache.org/licenses/LICENSE-2.0.html#redistribution -c
, it is suitable that osmosis-rust writes their copyright and we keep it. How about suggesting writing their copyright to them?


Invalid Mode /test when deploying using 4.2.5

After running sls deploy invalid mode error appears when using 4.2.5, works fine on 4.2.4.
I think it might be due to #187 adding quotes to the bindpath.
Serverless: Trying bindPath D:/Workspace/analysis-api/.serverless/requirements (run,--rm,-v,D:/Workspace/analysis-api/.serverless/requirements:/test,alpine,ls,/test/requirements.txt)
Serverless: /test/requirements.txt

  Error --------------------------------------------------

  docker: Error response from daemon: invalid mode: /test.
See 'docker run --help'.

Environment Info
     OS: win32(10 pro)
     Node Version: 9.5.0
     Serverless Version: 1.32.0
     Docker Version :  18.06.1-ce-win73 (19507)

Same here!

arg.. why does windows have to be so weird :disappointed:
Any thoughts @rob-deans	@kichik @PatrickBuTaxdoo

Is that the complete log with SLS_DEBUG=*? It should have tried a few more options.
If I had to guess, I would say the D: drive is not shared with Docker.

@kichik That is not the complete log but only where it failed. Everything else ran fine.
D: is definitely shared.

It should print all of the different Docker commands it's trying. It seems like the right Docker command is missing for you because they all fail. Either that, or the command is somehow malformed. It would be helpful if can check which variation is the closest to working and what's exactly missing in it.
I assume, based on the error message, that something like the following should work:
docker run --rm -v /D/Workspace/analysis-api/.serverless/requirements:/test alpine ls /test/requirements.txt

Also, please include more details about your system. Docker for Windows or Docker Toolbox? Any other details could help.

Same and debugged.
At ver 4.2.5, project directory becomes encorted by double quoat. (at pip.js)
at Ver.4.2.4 -> projectdir/.serverless/requirements
at Ver.4.2.5 -> "projectdir/.serverless/requirements"
It got the bad effect by child_process.spawnSync quoting and escaping process.
Call child_process.spawnSync with option windowsVerbatimArguments = true, this issue does not reproduced.
After fixing it, next calling 'python.exe' on Docker container.
docker: Error response from daemon: OCI runtime create failed: container_linux.go:348: starting container process caused "exec: \"python.exe\": executable file not found in $PATH": unknown.

I fixed issues on my branch 'fix-issue-274', and it goes well using the serverless command on my pc.

Same here.
Serverless: Docker Image: lambci/lambda:build-python3.6
Error --------------------------------------------------
docker: Error response from daemon: invalid mode: /test.
See 'docker run --help'.

@T-Tmnr @gbrcmg @adanot How are you running sls & docker? Are you using WSL or not. Are you using Docker4Windows, DockerToolbox Or something inside WSL?

@T-Tmnr @gbrcmg @adanot How are you running sls & docker? Are you using WSL or not. Are you using Docker4Windows, DockerToolbox Or something inside WSL?

I'm using Docker for Windows.
Downgrad to 4.2.4 worked for me.

@T-Tmnr @gbrcmg @adanot How are you running sls & docker? Are you using WSL or not. Are you using Docker4Windows, DockerToolbox Or something inside WSL?

I'm using Docker for Windows too.

Seeing this as well.
Serverless: Installing requirements from C:\project_dir.serverless\requirements\requirements.txt ...
Serverless: Docker Image: lambci/lambda:build-python3.6
Serverless: Trying bindPath C:/project_dir/.serverless/requirements (run,--rm,-v,C:/project_dir/.serverless/requirements:/test,alpine,ls,/test/requirements.txt)
Serverless: /test/requirements.txt
Error --------------------------------------------------
docker: Error response from daemon: invalid mode: /test.
See 'docker run --help'.
 For debugging logs, run again after setting the "SLS_DEBUG=*" environment variable.

Stack Trace --------------------------------------------
Error: docker: Error response from daemon: invalid mode: /test.
See 'docker run --help'.
at dockerCommand (C:\project_dir\node_modules\serverless-python-requirements\lib\docker.js:20:11)
at getDockerUid (C:\project_dir\node_modules\serverless-python-requirements\lib\docker.js:162:14)
at installRequirements (C:\project_dir\node_modules\serverless-python-requirements\lib\pip.js:231:42)
at installRequirementsIfNeeded (C:\project_dir\node_modules\serverless-python-requirements\lib\pip.js:451:3)
at ServerlessPythonRequirements.installAllRequirements (C:\project_dir\node_modules\serverless-python-requirements\lib\pip.js:530:29)

From previous event:
at PluginManager.invoke (C:\Users\dev\AppData\Roaming\npm\node_modules\serverless\lib\classes\PluginManager.js:390:22)
at PluginManager.spawn (C:\Users\dev\AppData\Roaming\npm\node_modules\serverless\lib\classes\PluginManager.js:408:17)
at Deploy.BbPromise.bind.then.then (C:\Users\dev\AppData\Roaming\npm\node_modules\serverless\lib\plugins\deploy\deploy.js:123:50)
From previous event:
at Object.before:deploy:deploy [as hook] (C:\Users\dev\AppData\Roaming\npm\node_modules\serverless\lib\plugins\deploy\deploy.js:113:10)
at BbPromise.reduce (C:\Users\dev\AppData\Roaming\npm\node_modules\serverless\lib\classes\PluginManager.js:390:55)
From previous event:
at PluginManager.invoke (C:\Users\dev\AppData\Roaming\npm\node_modules\serverless\lib\classes\PluginManager.js:390:22)
at PluginManager.run (C:\Users\dev\AppData\Roaming\npm\node_modules\serverless\lib\classes\PluginManager.js:421:17)
at variables.populateService.then.then (C:\Users\dev\AppData\Roaming\npm\node_modules\serverless\lib\Serverless.js:157:33)
at runCallback (timers.js:810:20)
at tryOnImmediate (timers.js:768:5)
at processImmediate [as _immediateCallback] (timers.js:745:5)
From previous event:
at Serverless.run (C:\Users\dev\AppData\Roaming\npm\node_modules\serverless\lib\Serverless.js:144:8)
at serverless.init.then (C:\Users\dev\AppData\Roaming\npm\node_modules\serverless\bin\serverless:43:50)
at
Get Support --------------------------------------------
Docs:          docs.serverless.com
Bugs:          github.com/serverless/serverless/issues
Issues:        forum.serverless.com
Your Environment Information -----------------------------
OS:                     win32
Node Version:           8.11.3
Serverless Version:     1.29.2

Hi
I am noob to python & docker so I hope I am not barking up the wrong tree but here goes, after I dug into the code, I think it is the double quotes in bindPath variable for requirements folder when mounting to image so this is failing. I got here after using a few of console.logs to see what commands where being generated.
'''
docker run --rm -v "C:/Users/nylth/code/python/hellow_flask/.serverless/requirements":/test alpine stat -c %u /bin/sh
'''
The docker process exits with code 125 but if I removed the ", it works and docker process returns 0 as expected
'''
docker run --rm -v C:/Users/nylth/code/python/hellow_flask/.serverless/requirements:/test alpine stat -c %u /bin/sh
'''
I believe the problem lies in pip.js line 276
'''
dockerPathForWin(options, path)
'''

Thanks for digging in @naingyelin! What if the path has a space in it?

@dschep I can confirm this command works for path with spaces, if you enclose the whole mount path in " including the :/test, just tested it :)
docker run --rm -v "C:/Users/nylth/code/python/hellow flask/.serverless/requirements:/test" alpine stat -c %u /bin/sh

Ah. Thanks for that @naingyelin. That gives us a path forward!

There is maybe some differences between command-line and spawnSync on Windows.
I explored spawnSync behavior on windows by below code.
testcode.js
const { spawnSync } = require('child_process');
const options = ['arg1', '"arg2"', 'arg 3', '"arg 4"'];
// case1 like docker.js:13
spawnSync('reciever.bat', options, { });
// case2
spawnSync('reciever.bat', options, { windowsVerbatimArguments:true });
// case3 likes pip.js:249
spawnSync('reciever.bat', options, { shell:true });

reciever.bat
echo ALL=%* >> result.txt
echo $1=%1 >> result.txt
echo $2=%2 >> result.txt
echo $3=%3 >> result.txt
echo $4=%4 >> result.txt
echo $5=%5 >> result.txt

Result
rem case1
ALL=arg1 "\"arg2\"" "arg 3" "\"arg 4\""
$1=arg1
$2="\"arg2\""
$3="arg 3"
$4="\"arg
$5=4\""

rem case2
ALL=arg1 "arg2" arg 3 "arg 4"
$1=arg1
$2="arg2"
$3=arg
$4=3
$5="arg 4"

rem case3
ALL=arg1 "arg2" arg 3 "arg 4"
$1=arg1
$2="arg2"
$3=arg
$4=3
$5="arg 4"

Case1: double-quate in arg2 and arg4 are escaped and corrupted. But arg3 is escaped well.
Case2 and case3: arg3 is corrupted.
I tryed to fix this issue on my branch. but can not test on Mac.
https://github.com/T-Tmnr/serverless-python-requirements/tree/fix-issue-274

Awesome @T-Tmnr, could a window user test his change? Install it with npm i T-Tmnr/serverless-python-requirements#fix-issue-274

@dschep I have just tested the build and it works, I am now able to deploy my flask app.
I did encounter issue #226 but just had to regenerate the requirements.txt in bash using wsl
Windows 10 Pro v1803 Build 17134.345
node v8.11.4
Serverless 1.32.0
python 3.7.0
Docker version 18.06.1-ce, build e68fc7a
nvm v1.1.7
npm 6.4.1
pip 18.0

That's great news @naingyelin!
@T-Tmnr, could you open a PR for your change? Also, could you make the change from python.exe to python only for when dockerizePip is set?

FWIW, T-Tmnr's change worked for me as well.

@dschep, I opened PR with modifying about dockerizePip.

My information was "ONLY" bat file.
https://github.com/UnitedIncome/serverless-python-requirements/issues/274#issuecomment-438748776
I try to explore behavior with other command-line application.
Another result is there. Windows bat-file has a darkness...
I make simple application "outarg.exe".
#include <fstream>
#include <iostream>
#include <string>

int main(int argc, char* argv[])
{
	std::ofstream ofs("result.txt", std::ofstream::app);
	for (int i = 0; i < argc; i++) {
		ofs << "argv[" << i << "]=" << argv[i] << "\n";
	}
}

And check spawnSync behavior.

With options ['-v', 'host path:guest_path']
When default.
argv[0]=outarg.exe
argv[1]=case1
argv[2]=-v
argv[3]=host path:guest_path

It does not corrupt!
Docker can recognize option.
When windowsVerbatimArguments or shell option enabled.
argv[0]=outarg.exe
argv[1]=case2
argv[2]=-v
argv[3]=host
argv[4]=path:guest_path

Parameters are corrupted.

With options ['-v', '"host path":guest_path']
When default.
argv[0]=outarg.exe
argv[1]=case1
argv[2]=-v
argv[3]="host path":guest_path

It does not corrupt!
But in this case, docker cannot recognize option correctly.
When windowsVerbatimArguments or shell option enabled.
argv[0]=outarg.exe
argv[1]=case2
argv[2]=-v
argv[3]=host path:guest_path

It does not corrupt and does not have double-quate!
Docker can recognize option.

With options ['-v', '"host path:guest_path"']
When default.
argv[0]=outarg.exe
argv[1]=case1
argv[2]=-v
argv[3]="host path:guest_path"

This case is not in current code.
Modify docker.js to do this quoting, but docker cannot recognize option correctly.
When windowsVerbatimArguments or shell option enabled.
argv[0]=outarg.exe
argv[1]=case2
argv[2]=-v
argv[3]=host path:guest_path

It does not corrupt and does not have double-quate too!
Docker can recognize option.

In docker.js, calling spawnSync with default option.
In pip.js, calling spawnSync with shell option.
If bindPath has space-char, docker.js wants un-quoted bindPath but pip.js wants quoted bindPath.
My solution on fix-issue-274,
https://github.com/T-Tmnr/serverless-python-requirements/tree/fix-issue-274
bindPath keeps quoted and modify spawnSync option on docker.js.
Another solution on fix-issue-274-another,
https://github.com/T-Tmnr/serverless-python-requirements/tree/fix-issue-274-another
bindPath is not quoted and modify docker option to quote on pip.js.
Both solutions fix this issue.

Thanks for the thorough report @T-Tmnr!

@T-Tmnr @gbrcmg @adanot How are you running sls & docker? Are you using WSL or not. Are you using Docker4Windows, DockerToolbox Or something inside WSL?

I'm using Docker for Windows.
Downgrad to 4.2.4 worked for me.

@gbrcmg what is it that you downgraded to 4.2.4?

@T-Tmnr @gbrcmg @adanot How are you running sls & docker? Are you using WSL or not. Are you using Docker4Windows, DockerToolbox Or something inside WSL?

I'm using Docker for Windows.
Downgrad to 4.2.4 worked for me.

@gbrcmg what is it that you downgraded to 4.2.4?

Nevermind. I realize now that you were referring to the plugin version itself.


add docs link to README

Adding https://docs.camunda.io/docs/next/guides/getting-started-java-spring/ to the README.

I think these links are already working!
(If you look at the README source, I used reference-links to centralize the URL, pointed at the current version of the new guide.)

Totally missed that. Awesome!


Issue With Request Inceptor And Redux State

I Am Trying To Get Access Token From Redux State Like This.
I Don`t Know What I Am Doing Wrong But When The Access Code Changes It Doesn't Change In The Request Inceptor. That Is The Old Access Code Is Still Used After Access Code Has Change In Redux State
const { store } = configureStore();

const apiTokenInterceptor = host => client => async action => {
	const state = store.getState();
	const { auth } = state;
	return {
		...action,
		endpoint: getUrl(action.endpoint),
		headers: {
			...action.headers,
			"Content-type": "application/json",
			Accept: "application/json",
			Authorization:` Bearer ${auth.token}`
		}
	};
};

At first glance it looks ok (token is fetched from store on every request to API), could you provide an example on codesandbox?

Closed due to inactivity

I Still Face This Issue, Just That I Found Another Way To Fix My Initial Problem.
I Will Reproduce The Issue  On Codesandbox When I Have Time


Dev to master, README update

This change is

Coverage remained the same at 54.731% when pulling 2d94a15b0dc9a5c14c5a4a2cdb0a6f4751a648aa on dev into 61beb8c2f18551d9e24d2c2ae473fc83cfb6d8e2 on master.

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable


HBASE-26731 Add metrics for active and expired scanners

The test I added verifies the metric, but not the calculation. I looked into adding a more end-to-end test, but it would be a lot of work given where these metrics are counted. Many other metrics don't have any tests at all, so I figured this might be sufficient.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 37s
master passed

+1 :green_heart:
compile
2m  6s
master passed

+1 :green_heart:
checkstyle
0m 41s
master passed

+1 :green_heart:
spotbugs
1m 31s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  9s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 19s
the patch passed

+1 :green_heart:
compile
2m  6s
the patch passed

+1 :green_heart:
javac
2m  6s
the patch passed

-0 :warning:
checkstyle
0m  6s
hbase-hadoop-compat: The patch generated 2 new + 2 unchanged - 0 fixed = 4 total (was 2)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 36s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
1m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

31m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4145/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4145

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 45b5d1882ad6 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e85bf414ab

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4145/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-hadoop-compat.txt

Max. process+thread count
60 (vs. ulimit of 30000)

modules
C: hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4145/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  5s
master passed

+1 :green_heart:
compile
1m  0s
master passed

+1 :green_heart:
shadedjars
3m 55s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 54s
the patch passed

+1 :green_heart:
compile
0m 59s
the patch passed

+1 :green_heart:
javac
0m 59s
the patch passed

+1 :green_heart:
shadedjars
3m 51s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 47s
hbase-hadoop-compat in the patch passed.

+1 :green_heart:
unit
337m 25s
hbase-server in the patch passed.

358m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4145/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4145

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e99c4308e451 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e85bf414ab

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4145/1/testReport/

Max. process+thread count
1677 (vs. ulimit of 30000)

modules
C: hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4145/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 39s
master passed

+1 :green_heart:
compile
0m 51s
master passed

+1 :green_heart:
shadedjars
3m 44s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 19s
the patch passed

+1 :green_heart:
compile
0m 50s
the patch passed

+1 :green_heart:
javac
0m 50s
the patch passed

+1 :green_heart:
shadedjars
3m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 39s
hbase-hadoop-compat in the patch passed.

+1 :green_heart:
unit
340m 24s
hbase-server in the patch passed.

359m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4145/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4145

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3e3c3eb5003c 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e85bf414ab

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4145/1/testReport/

Max. process+thread count
1626 (vs. ulimit of 30000)

modules
C: hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4145/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Training multi-task network with mostly missing labels

Sorry if this is something that's become more obvious with the functional API but I'm trying to train networks with >100 outputs and for each sample I only get labels for a random subset of those outputs (often more than 1 but rarely more than 10). Do I need to use a custom loss to zero out loss contributions from missing outputs or is somehow already handled within the Model class?
Thanks!

You could consider concatenating your outputs into a single output (e.g. if
you have 100 softmaxes, you would get a 3D output (batch_size, 100,
classes)) and use a masking layer + a softmax+categorical_crossentropy
loss.
softmax+categorical_crossentropy will work for 3D outputs (applied to the
last dimension), and your missing outputs (axis #1) would not contribute to
the loss if they are masked.
To pass a mask, you could consider having a custom masking layer connected
to a new model input that would feed with a mask tensor (1s and 0s). The
layer would return its inputs unchanged (the output of your network) but
would add a mask, which would be taken into account by the loss.
On 12 July 2016 at 11:59, Alex Rubinsteyn<EMAIL_ADDRESS>wrote:

Sorry if this is something that's become more obvious with the functional
API but I'm trying to train networks with >100 outputs and for each sample
I only get labels for a random subset of those outputs (often more than 1
but rarely more than 10). Do I need to use a custom loss to zero out loss
contributions from missing outputs or is somehow already handled within the
Model class?
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/fchollet/keras/issues/3206, or mute the thread
https://github.com/notifications/unsubscribe/AArWb8aqdQ8ugN_xL2PAjAm-MjuV10QMks5qU-QpgaJpZM4JKtoo
.

Isn't it better to make one model per output, and share the same parameters ?

@fchollet Would that also work with an MSE loss for multiple regression targets?
Also, do you think something like this work for masking the output values?
Merge([network_outputs, Masking(mask_value=0)(mask_input)], mode=lambda xs: xs[0], output_mask=lambda xs: xs[1])

@sileod For samples with multiple labels I don't think I'd be able to correctly update the parameters when using multiple models. The desired behavior would be to get averaging of gradients from multiple outputs but with more than one model I would instead have to pick an order of sequentialized weight updates.

Isn't it better to make one model per output, and share the same
parameters ?

That's a good idea. It may be easier to manage.

For samples with multiple labels I don't think I'd be able to correctly
update the parameters when using multiple models. The desired behavior
would be to get averaging of gradients from multiple outputs but with more
than one model I would instead have to pick an order of sequentialized
weight updates.

Picking a random order would work. It should not significantly hurt
training.
Also, your code looks good to me. That's the idea.
On 13 July 2016 at 12:39, Alex Rubinsteyn<EMAIL_ADDRESS>wrote:

@sileod https://github.com/sileod For samples with multiple labels I
don't think I'd be able to correctly update the parameters when using
multiple models. The desired behavior would be to get averaging of
gradients from multiple outputs but with more than one model I would
instead have to pick an order of sequentialized weight updates.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fchollet/keras/issues/3206#issuecomment-232463795,
or mute the thread
https://github.com/notifications/unsubscribe/AArWbxhbnwr54cPvGagKeOzSgO8JgsHSks5qVT7ggaJpZM4JKtoo
.

Thanks for the feedback. I'll close this issue while I try both approaches and update later with how they worked out.

@iskandr  can you explain your mask function?
and also, I have a network with N classes and i want to evluate 3 parameters so I want to build 3 different softmax over the last layer which will be concatenation of fc layer with one-hot vector indicates the class. Does it sound reasonable? how can I build the 3 softmax outputs?
Thanks


:lipstick: Add badges

Adds badges to the readme file and includes docs webpage.

Codecov Report

Merging #88 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   76.35%   76.35%
=======================================
  Files          37       37
  Lines        1552     1552
=======================================
  Hits         1185     1185
  Misses        367      367

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4767c80...60a63f3. Read the comment docs.


Port Flakey CI test disable

Porting Rich's disabling of this test to release so we can get a clean CI build:
https://github.com/microsoft/vscode-python/pull/13346

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[ ] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[ ] The wiki is updated with any design decisions/details.

I also tagged the issue to investigate the test failure that this disable was ported to release. Just in case we think a release fix is appropriate there.

Codecov Report

Merging #13350 into release-2020.08 will decrease coverage by 0.02%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release-2020.08   #13350      +/-   ##
===================================================
- Coverage            59.73%   59.71%   -0.03%
===================================================
  Files                  670      670
  Lines                37289    37289
  Branches              5291     5291
===================================================
- Hits                 22276    22267       -9
- Misses               13879    13885       +6
- Partials              1134     1137       +3

Impacted Files
Coverage Δ

src/client/common/utils/platform.ts
64.70% <0.00%> (-11.77%)
:arrow_down:

src/client/datascience/crossProcessLock.ts
79.41% <0.00%> (-11.77%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0.00%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0.00%> (-1.57%)
:arrow_down:

src/client/common/process/proc.ts
14.49% <0.00%> (-0.73%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96119c1...99a1cdb. Read the comment docs.


[9.4] ISPN-10990 Log certain server-side Hot Rod warnings only once

https://issues.jboss.org/browse/ISPN-10990

merged on 9.4.x, thanks


feat(math): implement (I)FFT

Description

This PR implements (I)FFT over dense univariate polynomial.

To do (I)FFT over a polynomial, an evaluation domain must exist, so this PR also implements evaluation domains. Evaluation domain is basically a domain over which finite field (I)FFTs can be performed.

GeneralEvaluationDomain is a wrapper over Radix2EvaluationDomain and MixedRadixEvaluationDomain where it generally tries to build a Radix2EvaluationDomain and falls back to a MixedRadixEvaluationDomain if the radix-2 multiplicative subgroup is too small.

Radix2EvaluationDomain is an EvaluationDomain for performing various kinds of polynomial arithmetic on top of fields that are FFT-friendly. Radix2EvaluationDomain supports (I)FFTs of size at most 2^two-adicity.

MixedRadixEvaluationDomain is an EvaluationDomain for performing various kinds of polynomial arithmetic on top of fields that are FFT-friendly but do not have high-enough two-adicity to perform the FFT efficiently. MixedRadixEvaluationDomain resolves this issue by using a larger subgroup obtained by combining G with another subgroup of size F::Config::kSmallSubgroupBase^F::Config::kSmallSubgroupAdicity, to obtain a subgroup generated by F::Config::kLargeSubgroupRootOfUnity.

I think fix(math): fix calculation of large subgroup root of unity is not a commit for bugfix.

Could you please separate file relocations from commit feat(math): introduce Radix2EvaluationDomain

Plus, you forgot to update include guard macro.

When seeing the commit body of feat(math): introduce bn384_small_two_adicity Fr, it needs to be tagged with test

LGTM


Schema registry 4/N

See #1137 for reference

Hold on, I've made a lot of these changes but I think my last two branches
have misplaced commits. I might just merge them into one last pr.
On Wed, Mar 14, 2018 at 11:34 AM, Matteo Merli<EMAIL_ADDRESS>wrote:

@merlimat commented on this pull request.
In pulsar-broker/src/main/java/org/apache/pulsar/broker/
admin/SchemasResource.java
https://github.com/apache/incubator-pulsar/pull/1381#discussion_r174545638
:

+import javax.ws.rs.Path;
+import javax.ws.rs.PathParam;
+import javax.ws.rs.Produces;
+import javax.ws.rs.container.AsyncResponse;
+import javax.ws.rs.container.Suspended;
+import javax.ws.rs.core.MediaType;
+import javax.ws.rs.core.Response;
+import org.apache.pulsar.broker.service.Topic;
+import org.apache.pulsar.broker.web.RestException;
+import org.apache.pulsar.common.naming.TopicName;
+import org.apache.pulsar.common.schema.SchemaData;
+import org.apache.pulsar.common.schema.SchemaType;
+import org.apache.pulsar.common.schema.SchemaVersion;

+@Path("/schemas")
+public class SchemasResource extends AdminResource {
This handler should go on the v2 admin API
In pulsar-broker/src/main/java/org/apache/pulsar/broker/
admin/SchemasResource.java
https://github.com/apache/incubator-pulsar/pull/1381#discussion_r174546254
:

+@Path("/schemas")
+public class SchemasResource extends AdminResource {

private final Clock clock;

@VisibleForTesting
SchemasResource(Clock clock) {

   super();

   this.clock = clock;

}

public SchemasResource() {

   this(Clock.systemUTC());

}

@GET @Path("/{property}/{cluster}/{namespace}/{topic}/schema")

For existing REST API handlers, we have split the endpoints in 2:

One with the old topic name
One with v2 topic name (no cluster in the name).

I think that for this new feature we could just concentrate on v2 API.
In pulsar-broker/src/main/java/org/apache/pulsar/broker/
admin/SchemasResource.java
https://github.com/apache/incubator-pulsar/pull/1381#discussion_r174546539
:

           .isDeleted(false)

           .timestamp(clock.millis())

           .type(SchemaType.valueOf(payload.type))

           .user(clientAppId())

           .build()

   ).thenAccept(version ->

       response.resume(

           Response.accepted().entity(

               new PostSchemaResponse(version)

           ).build()

       )

   );

}

private String buildSchemaId(String property, String cluster, String namespace, String topic) {

   return property + "_" + cluster + "_" + namespace + "_" + topic;

I think we already added a method to get the schema in TopicName, right?
In pulsar-broker/src/main/java/org/apache/pulsar/broker/
admin/SchemasResource.java
https://github.com/apache/incubator-pulsar/pull/1381#discussion_r174546852
:

       } else {

           throw e;

       }

   }

}

private void validateDestinationExists(TopicName dn) {

   try {

       Topic topic = pulsar().getBrokerService().getTopicReference(dn.toString());

       checkNotNull(topic);

   } catch (Exception e) {

       throw new RestException(Response.Status.NOT_FOUND, "Topic not found");

   }

}

static class GetSchemaResponse {

If this classes will have to be used in the PulsarAdmin Java client, they
should be added in pulsar-common module.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-pulsar/pull/1381#pullrequestreview-103922460,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAh9FtDtudZWOI4D9-5tpC5F8snJJps1ks5teVTBgaJpZM4SqqD8
.

@mgodave which one I should review? this one or #1137 ?

this one, #1137 is just the tracking branch
On Mon, Mar 19, 2018 at 2:24 PM, Sijie Guo<EMAIL_ADDRESS>wrote:

@mgodave https://github.com/mgodave which one I should review? this one
or #1137 https://github.com/apache/incubator-pulsar/pull/1137 ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-pulsar/pull/1381#issuecomment-374360569,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAh9FnG6SKIVsLTF8rDaieRXQotFaDuDks5tgBPogaJpZM4SqqD8
.

@mgodave  there's a file that's missing the license header: ProducerResponse.java

@mgodave there is a conflict with a change that went into master again, sorry.
I had changed getTopicReference() to return Optional<Topic>

retest this please


Display calendar by itself

This is not an issue but more of a question.
Is there a way to display the calendar by itself in a div, where clicking on a single date would change some value in another div?
I dont want a textinput, just the calendar.

http://stackoverflow.com/questions/41107741/eonasdan-datetimepicker-display-calendar-only


Fix crash for unloading plugins base types

The base type was removed first and was not removed from the list of base types
on every other type. This lead to a crash.
fixes #199

Coverage increased (+0.009%) to 92.28% when pulling 1c402f15f18ee042100e5b8c4c5224616fec83c4 on acki-m:bugfix-remove-base-classes-for-derived-classes into 668340d1fe6b9048d29682643a63aa42bebe0f6b on rttrorg:master.


Add NEFTune to improve fine-tuning?

Came across this thread / paper / repo on Twitter yesterday and it seems like a promising approach for getting a little more out of your fine-tuning. Haven't tested for myself just yet, but can report those results unless someone else already has.
I started to implement a version of this on my fork of lit-gpt, but wondering if this is of broader interest? Can make this a PR if so.
links to the work:
https://twitter.com/neeljain1717/status/1712125846553554987
https://arxiv.org/abs/2310.05914
https://github.com/neelsjain/NEFTune
my implementation (EDIT: Tested and works in a basic case)
https://github.com/Lightning-AI/lit-gpt/pull/653/files

Hey @nkasmanoff just curious did you get time to test this?

Hey @sanyalsunny111, TLDR I did for a very simple example, and think it should work for LoRA. If you want to try it, all you'd need to do is specify neftune_alpha in finetune/lora.py (currently default to None)
I updated the link above & corresponding PR.
The simple example:
I fine-tuned Llama2 7B for 50 steps with a LoRA adapter only on the LM head. Using the logs I confirmed that the logic in the PR only adds noise to the embeddings during training, and the result was slightly worse train loss for these extremely early on parts of fine-tuning. Admittedly there's a lot more you'd want to confirm like what performance gains this has during actual training, but I don't have the compute or time budget to check that all out right now.

Great!! Thanks

There's no plan to add this implementation for now, but I'm glad that you were able to easily implement it with Lit-GPT


High quality audio issue

right now i am using android SDK but audio quality is not good.
how can i get mp3 quality level audio.
is there any way to get same to same as music level audio so user can play music and talk both at a time.
my config is here

val options = RoomOptions(
audioTrackCaptureDefaults = LocalAudioTrackOptions(
noiseSuppression = false,
echoCancellation = false,
autoGainControl = false,
highPassFilter = false,
typingNoiseDetection = false,
),
videoTrackCaptureDefaults = LocalVideoTrackOptions(
deviceId = "",
position = CameraPosition.FRONT,
captureParams = VideoPreset169.HD.capture,
),
audioTrackPublishDefaults = AudioTrackPublishDefaults(
audioBitrate = 128_000,
dtx = false,
),

dupe of https://github.com/livekit/client-sdk-android/issues/259


fix(TDI-40301): move synchronized block to fix concurrent access

What is the current behavior? (You can also link to an open issue here)
https://jira.talendforge.org/browse/TDI-40301
What is the new behavior?
Moved synchronized block to the right place for the concurrent access.
Please check if the PR fulfills these requirements

[X] The commit message follows Talend standard
[X] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Pull request test result: success :star:
Sonar results


redirection link in the "Importing Models"

Hello,
it's seem that in the Importing Models page of the burn book, the link to ONNX and Pytorch redirect to burn.dev.
It should be to the section related in the book isn't it ?
Like ONNX link to Import ONNX Model
and Pytorch to PyTorch Model
Best Regards

Thanks for flagging! Just submitted a PR that should fix this 🙂

Yeah this one has been fixed in #1651


chore: initialize pnpm workspaces; add multi-step docker builds

Closed in favor of:

#23
#18
#24


Make Ansible re-usable for other environments

For example environments where become is not needed and where we have real NVMe

Sounds good, the only major thing left now I think is to provide a shared /home between the DAC and Slurm nodes so that copy in/out and slurm job output all work seamlessly. Currently job output lands on the one compute node only, and copy in/out is limited to data on the DAC nodes. I'll hopefully get a new commit added to this request soon to take care of that problem.


Attempt to check Google Play Services

TBD

Tested on both phone that have Google Play Services deactivated and up-to-date phone. Works as expected.


Make highlight element type configurable

Hi (again) =D
Got a request if we could change the  element into a  and noticed that this is hard coded here:
https://github.com/skttl/umbraco-fulltextsearch8/blob/0429fccdd49ff50cc4f3ddff7bed25208dcbca7c/src/Our.Umbraco.FullTextSearch/Services/SearchService.cs#L367
What do you say about making this a option and add this to the FullTextSearchOptions?
Again, I would be happy to create a PR =D

Sounds like a good idea, maybe it should be in the form of a format like %0, then you could override the config with %0 or %0 etc.

Solved in this merge: https://github.com/skttl/umbraco-fulltextsearch8/pull/84


Add block name and other lines to RSpec/ScatteredSetup message

Add block name and other lines to RSpec/ScatteredSetup message
on-behalf-of: @Cofense<EMAIL_ADDRESS>
Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the changelog if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

Failure seems unrelated (frankly I have no idea what this is about):

I opened the following workaround patch.
https://github.com/rubocop-hq/rubocop-rspec/pull/867

Nice, thank you @koic!
@elebow Can you please retrigger the builds?

I forced pushed the branch, and the simplecov error reoccurred.
I rebased on koic:workaround_for_cc_test_reporter_with_simplecov and pushed, and the error is not present.

Awesome, thank you!
@bquorning @Darhazer can you please glance over this and https://github.com/rubocop-hq/rubocop-rspec/pull/867?


Double click to toggle fullscreen

This is a pretty common feature in flash-based video players, and YouTube does it too.
Double clicking does briefly pause (or play) the video. It doesn't bother me but if you like, I can add a short timeout to the click handler so this doesn't happen.

Looks good. But for future reference, I prefer to hold back on updating the manifest until I'm ready to actually release an update.


Subtractive targets in Run/Debug Configurations

When setting a target expression in a Run/Debug Configuration, you are unable to use subtractive patterns. It appears it is an issue with the text field validation because Bazel does support these types of expressions.
For example running bazel on the command line like this properly excludes the targets I want to skip:
bazel test -- //...:all -//my-really-slow-tests/...:all

but setting a target expression of //...:all -//my-really-slow-tests/...:all will display an error message in the CLion Run/Debug configurations. Error: Invalid package name '//...': package name component contains only '.' characters

We don't currently support multiple target patterns for a single run configuration. It works sometimes, but only by accident.
In this case we're treating it as a single target, and our package validation doesn't handle the resulting string.

Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.


OCW-T200

Describe the bug
The watch is detected and enters into the connection mode, but the sending time feature does not work.
To Reproduce
Steps to reproduce the behavior:

Go to application.
Remove any watch assigned.
Set the watch into the connection mode (3 time press the button)
Send the time from the application.

Expected behavior
Time should be sent via the bt connection, no correction of the time happens.
Screenshots
n/a
Desktop (please complete the following information):
unrelated
Smartphone (please complete the following information):

grapehene OS
Casio G-Shock  Smart Sync (latest  v14.2)

Additional context
n/a

Do not have this watch. I will close the issue for now. If somebody has the watch and would like to assist. let me know and I will reopen.


Warn on duplicate Dat

When already imported Dat. This Dat has already been imported. You can find it in your list of Dats

Blocked by https://github.com/datproject/multidat/issues/2 - should be reasonably easy to implement tho

@juliangruber assigning you for now because it's blocked on multidat - do you mind picking this one up? Thanks! :grin:

https://github.com/datproject/multidrive/pull/9

awesome, reviewed & looking great :sparkles:

multidrive now noops when adding an archive twice. Should we still add the check and warn here?

We decided that the warning would be helpful, so adding logic for err.warn = true triggering a warning dialogue

needs https://github.com/datproject/multidrive/pull/10

work started in https://github.com/datproject/dat-desktop/compare/add/warning-on-duplicate-dat?expand=1

blocked by #292

we're detecting duplicates in multidrive now, which works in the case where you clone a dat redundantly. in the case where you share one though, we currently always get the LevelDB error first, because the dat needs to be initialized before we know its key. If we do the duplicate check on the directory as well though, that wouldn't be necessary.

pull request here: https://github.com/datproject/dat-desktop/pull/295


Error: The given key '' was not present in the dictionary.

When using ficdown by the command line I get the following error when it is "Parsing story ...":
Unhandled Exception: System.Collections.Generic.KeyNotFoundException: The given key '' was not present in the dictionary.
at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
at Ficdown.Parser.Player.GameTraverser.ProcessState(StateQueueItem currentState) in /home/rudism/source/Ficdown/Ficdown.Parser/Player/GameTraverser.cs:line 147
at Ficdown.Parser.Player.GameTraverser.Enumerate() in /home/rudism/source/Ficdown/Ficdown.Parser/Player/GameTraverser.cs:line 66
at Ficdown.Parser.FicdownParser.ParseStory(String storyText) in /home/rudism/source/Ficdown/Ficdown.Parser/FicDownParser.cs:line 37
at Ficdown.Console.Program.Main(String[] args) in /home/rudism/source/Ficdown/Ficdown.Console/Program.cs:line 136

I do not understand what the error refers to.

Upps I'm sorry. This error occurs when this happens: [hello people] (?) When no variable is being evaluated.


build overlay cni tgz

Signed-off-by: Evan Baker<EMAIL_ADDRESS>
Reason for Change:

Issue Fixed:

Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests

Notes:

/azp run

/azp run

relevant checks have passed


Sash remains highlighted when double tapped on touch device

Is the intended behavior just to reset on double tap of the sash for touch devices?


npm Install pixi.js - missing bin folder

First and foremost - Thank you for a fantastic library.
Doing npm install does not include the bin folder. Tested with version 4.1.0.
which makes my require and imports fails - cannot find module pixi.js
The package.json also seems to point to the bin folder:
"main": "./bin/pixi.min.js",
I might be wrong, but i would expect all files to be included. If i need to install directly from the release branch, the documentation needs to be updated.
npm install https://github.com/pixijs/pixi.js.git#release -D
Thanks
/Dennis

Hey @ddennis.
Unfortunately, we no longer include the bin folder in our dev or master branches. It was causing issues whenever people trying to make PRs and is generally not a good version control practice. The bin folder is available on the release branch, as you've found out. Alternatively, you can also include directly from our download links, e.g. http://pixijs.download/v4.1.0/pixi.js or build pixi.js locally npm install && npm run build.
We'd definitely welcome a PR for updating documentation that mentions this. Thanks.

I will try to do a PR.
I have tried to figure out how it would be possible to make npm install pixi.js pull from the release branch and not master. But it seems you manually have to npm publish from the release folder
Maybe someone else knows how to fix this.

It should be included because when running the publish commands it also builds everything then publishes:
https://github.com/pixijs/pixi.js/blob/master/package.json#L38
Since bin/ is in the files array, it should already include the bin folder when we publish. If this is not happening, something strange is going on...

There should be an empty .npmignore file, otherwise it uses the .gitignore, see here: https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package
I guess that .gitignore overrides whatever you have in files.

I guess that .gitignore overrides whatever you have in files.

Well that is super dumb, I was under the impression if we had a files array specified in package.json that was the entire whitelist and nothing else was considered...
I'll touch an .npmignore file so we can fix this.

Try it now, just released v4.1.1 that has a blank npmignore.

@englercj Now the bin/ is included. :)


cgltf_result_invalid_json

I ran this bistro scene through the BCn compress  utility and then ran ZetaLab ../Assets/bistro_zeta.gltf but this yields the error:

Any ideas?

Trying to import bistro_zeta.gltf into Blender also fails:

The problem was invalid image URIs in the converted gltf file. It only occured when the images were in a subdirectory ('./bistro-textures' in this case). It just so happened that all my test scenes had the images in the same directory as the gltf file, so I hadn't run into it before.
I pushed a fix. Let me know if the issue persists.

Fixed 👍


Nobody from tech support is picking up

Hi, I've tried calling 3 times, but all 3 times i was waiting in the silence, and then the line just got cut off.
• ANI (Caller's telephone number) - +6 03 4145 6279
• Date of call - 22/04/2022
• Time of call with time zone - between 9.30am - 9.50am
• Options, selected if any - chose the option where i need tech support for emails linked to my organisation's domain
• Experience of call (no answer, got recording then disconnected, etc.) - no answer.

@chungweijian Thank you for your feedback. I'm sorry to hear that. The best way to get your issue resolved is to contact Microsoft Support. If you’re a Microsoft 365 or Office 365 admin, use the information that’s provided at Get support. Otherwise, you can create a support ticket at Microsoft Support for business.
Hope this helps!
Thanks
Sri


Question: Can we use this in Unity?

I have tried importing this in unity but it was giving some error is there any way to use this in unity??

Which version have you tried and how does it fail?
It should target .NET standard 2.0, and I thought Unity supported that.

Yes I used another method by downloading package from nuget and using DLL file in my unity project and it worked BTW thanks for this awesome repo. We are making Circuit simulator game for students using unity  and your documentation is very helpful❤.


Figure out how to handle quantitative States in Description complex comparisons

Currently, we only have one quantitative State: "Laminar L:W Ratio". We ignore this state in the current Description complex comparison query because I don't know how to deal with it.
We need to figure out how to deal with it.

Solved. But at what cost?
Original comparison:
//Test a new specimen Description complex against existing Description complexes using a Jaccard comparison on the States
MATCH
	(specimen:Specimen {name:"68"})-[:DESCRIBED_BY]->(otu1:OTU)-[defined_by:DEFINED_BY]->(characterInstance:CharacterInstance)-[instanceOf:INSTANCE_OF]->(character:Character), (characterInstance)-[hasState:HAS_STATE]->(state:State)
WITH
	//otu1, collect([characterInstance, instanceOf, character, hasState, state]) AS description1
	specimen, otu1, collect(id(state)) AS description1
MATCH
    (otu2:OTU)-[defined_by2:DEFINED_BY]->(characterInstance2:CharacterInstance)-[instanceOf2:INSTANCE_OF]->(character2:Character), (characterInstance2)-[hasState2:HAS_STATE]->(state2:State),
	(specimen2:Specimen)-[]->(otu2)
WHERE
    otu1 <> otu2
WITH
    specimen, otu1, description1,
	CASE otu2.name
		WHEN null THEN specimen2.name
		ELSE otu2.name
	END AS otu2Name,
	collect(id(state2)) AS description2
RETURN specimen.name AS from,
       otu2Name AS to,
       gds.alpha.similarity.jaccard(description1, description2) AS similarity
ORDER BY similarity DESC

New version:
//The same as above, but paying attention to Laminar Ratio values.
//This is a little contrived. I add a 1 to the toList. Then, depending on whether the ratio is within valid range of the OTU,
//I add either a 0 or 1 to the fromList. This approach will run aground as soon as we have more than one quantitative character.
//But it's a start.
MATCH //First, gather data for Description complexes other than the new one
	(toDescription:Description)-[toDefinedBy:DEFINED_BY]->(toCharacterInstance:CharacterInstance)-[toInstanceOf:INSTANCE_OF]->(toCharacter:Character),
	(toCharacterInstance)-[toHasState:HAS_STATE]->(toState:State),
	(toSpecimen:Specimen)-->(toDescription) //only needed to get name of specimen Descriptions
WHERE
	toSpecimen.name <> "68"
WITH
	CASE toDescription.name
		WHEN null THEN toSpecimen.name
		ELSE toDescription.name
	END AS toName,
	COLLECT(DISTINCT id(toState)) + [1] AS toDescriptionSet, //List of all State node ids. A 1 is added representing the Laminar Ratio
	COLLECT(DISTINCT CASE toCharacter.name
        WHEN "Laminar L:W Ratio" THEN toFloat(split(toHasState.value, ":")[0])/toFloat(split(toHasState.value,":")[1])
        ELSE null
    END) AS lamRatiosCrunched //Aggregate the Laminar Ratio values (since they could be a range), crunching them to float values
MATCH //Second, gather data for the new Description complex
	(fromSpecimen:Specimen {name:"68"})-[:DESCRIBED_BY]->(fromSpecimenDescription:Description)-[fromDefinedBy:DEFINED_BY]->(fromCharacterInstance:CharacterInstance)-[fromInstanceOf:INSTANCE_OF]->(fromCharacter:Character),
	(fromCharacterInstance)-[fromHasState:HAS_STATE]->(fromState:State)
WITH
	toName,
	toDescriptionSet,
	lamRatiosCrunched,
	fromSpecimen,
	COLLECT(id(fromState)) AS tmpFromDescriptionSet, //list of State node ids.
	COLLECT(DISTINCT CASE fromCharacter.name
        WHEN "Laminar L:W Ratio" THEN toFloat(split(fromHasState.value, ":")[0])/toFloat(split(fromHasState.value,":")[1])
        ELSE null
    END) AS fromLamValue //The Laminar Ratio of the new specimen, crunched to a float value. This must be aggregated in a list in order for other aggregations to work properly.
WITH
	toName,
	toDescriptionSet,
	fromSpecimen,
	tmpFromDescriptionSet,
	CASE
        WHEN size(lamRatiosCrunched) = 1 AND fromLamValue[0] = lamRatiosCrunched[0] THEN 1
        WHEN size(lamRatiosCrunched) = 2 AND fromLamValue[0] >= lamRatiosCrunched[0] AND fromLamValue[0] <= lamRatiosCrunched[1] THEN 1
        ELSE 0
    END AS lamCompareResult //If the Lam Ratio of the new specimen is legal, this will be 1. If not, 0.
WITH
	toName,
	toDescriptionSet,
	fromSpecimen.name AS fromName,
	tmpFromDescriptionSet + lamCompareResult AS fromDescriptionSet //Add the comparison result to the list of State ids
RETURN fromName,
       toName,
       gds.alpha.similarity.jaccard(fromDescriptionSet, toDescriptionSet) AS similarity
ORDER BY similarity DESC

ahem.

//This approach will run aground as soon as we have more than one quantitative character.
// But it's a start.

This made me lol, but yes... a start

We should circle back to this issue in January.

This may be more urgent to resolve than we originally anticipated. #34

Is this resolved? Can it be closed?

Not a direct solution, but possibly will make things easier, we discussed moving the quantitative measurement from the relationship into the CharacterInstance node.

Coming back to this discussion on multiple fronts: how to enter it into a schema, how to enter data into it, and how it will appear in search.
SCHEMA ENTRY: How to enter it in the schema will depend on solutions for data entry and returning values/identifier in reports/searches. So let's start with those two.
REPORTS/SEARCHES: We want it to appear in reports so that specimen and morphotype values are returned in cells in columns/rows. We also need an identifier to be returned as the column/row header so folks know what those values mean.
DATA ENTRY: Should we allow value ranges (min and max values) for both specimens and morphotypes so coding functions are the same for both? We can train folks to enter only minimum values if there is not a range.


Named values are not supported by batches (gRPC)

The underlying issue is BatchMessage doesn't support named values in C* 3.11/4.0 or DSE and only supports positional values. So even if we correctly support named values in the gRPC spec it can't (easily) be supported in Stargate without significant architectural changes. We couldn't use Message types to execute requests or would have to find some other way around the limiation.
Perhaps the best way to handle this for now is to return an error: "Named values are not supported in batches"
See: https://issues.apache.org/jira/browse/CASSANDRA-10246

Related to: https://github.com/stargate/stargate-grpc-go-client/issues/29


Apicompliance/578 change sheet

Checklist

[ ] tests added
[x] commits conform to the Commit message format
[ ] documentation updated

Squash commit message
master version of enigma enables us to send "custom" requests (even though intended for schema generation). Use this to send the missing "GetConfiguration" request for change sheet action.

Validated GetConfiguration method under changesheet with Version: v0.5.6-6-gaa5c7ee coming from this PR. The changes looks good to me.


App shows "Full vaccination protection in 0 days" on day 14 after the last shot

Avoid duplicates

[X] Bug is not mentioned in the FAQ
[X] Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[X] Bug is not already reported in another issue

Technical details

Device name: not important
Android version: not important
App version: 2.4

Describe the bug
On day 14 after the last vaccination shot was received, the app shows "Full vaccination protection in 0 days".
Here's a screenshot:

Steps to reproduce the issue

Get your second vaccination shot
Wait 14 days or change the system time to 14 days in the future
See that the app shows "Full vaccination protection in 0 days"

Expected behaviour
There shouldn't be the number "0" - this is not how we humans communicate 😁
Additional context

This bug report is based on the information a user shared on Twitter: https://twitter.com/stejormur/status/1409031782448705537?s=20
Please check the behavior under iOS.

Internal Tracking-ID: EXPOSUREAPP-8121

@Ein-Tim
Thanks for reporting. We are already investigating the issue internally.

Corona-Warn-App Open Source Team

@Ein-Tim @heinezen

IMO under iOS the behaviour is correct. For me it shows 2 days while under Android the app shows 1 day.

This is what I got today.

Internal Tracking ID: EXPOSUREAPP-7865 Android with PR https://github.com/corona-warn-app/cwa-app-android/pull/3467 corrected problem of the the vaccination status complete showing one day too early. Unfortunately the countdown was not changed at the same time.
It is clear reading the tests in https://github.com/corona-warn-app/cwa-app-android/blob/release/2.4.x/Corona-Warn-App/src/test/java/de/rki/coronawarnapp/covidcertificate/vaccination/core/VaccinatedPersonTest.kt that the countdown was not changed because in the test data it shows complete status on May 11, followed by immunity on May 12, however on May 11 the test expects 0 days (instead of 1 day) until immunity.

Ich habe das das gleiche Problem. Zertifikat sollte seit gestern, 2021-06-27 gültig sein, ist aber noch immer grau und „erst in 0 Tagen vollständig.” Der gleiche Text wurde auch gestern angezeigt.
CovPass dagegen zeigt das Zertifikat IMHO korrekt als gültigen, vollständigen Impfschutz an.
![](file:///home/matthias/CWA_Problem.jpeg)

@mawis

Please confirm if you are using iOS or Android.
Your screen shot shows a time of 01:08. Please check if you still get the same result later today, June 28, 2021. (I'm thinking it may be a timezone issue.)

We may need a separate new issue for your problem.

As mentioned in https://github.com/corona-warn-app/cwa-documentation/issues/638#issuecomment-869143434 I can confirm that today the tile is still grey (which is correct), the counter decreased to 0 (in both: the tile and the text after tapping on the tile).

@DerVogel2020 @MikeMcC399 Thanks. Your info is forwarded to the internal ticket.

@MikeMcC399 Yes, I'm using the Android app. This morning the certificate changed to blue. Looking at the code, it probably has done so at 2 o'clock (= midnight UTC). So indeed there seems to be an issue with the used timezone.
@DerVogel2020 Looking at the “Verordnung zur Regelung von Erleichterungen und Ausnahmen von Schutzmaßnahmen zur Verhinderung der Verbreitung von COVID-19” it indeed seems to be correct, that the certificate gets valid at the date it now does (the 15th day after the vaccination). But the counter being shown is very confusing then. Telling the certificate gets valid in one day makes me think it's valid the next day. Telling that the certificate is valid in zero days, makes no sense to me at all.
Everything is especially confusing as the media always reported that the certificate gets valid after 14 (not 15) days. Even the following page of the RKI is explaining it incorrectly in that case:
From https://digitaler-impfnachweis-app.de/faq/:

Warum ist der QR-Code als Nachweis für den vollständigen Impfschutz erst nach 14 Tagen gültig?
In Deutschland gelten Personen als geschützt, die mit einem in der EU zugelassenen COVID-19-Impfstoff geimpft wurden und bei denen nach Gabe der letzten Impfstoffdosis mindestens 14 Tage vergangen sind (Ausnahmen bzgl. Genesener siehe https://www.rki.de/SharedDocs/FAQ/COVID-Impfen/gesamt.html).
Wenn Sie zum Beispiel die letzte notwendige Corona-Impfung am 01. Juni erhalten haben, dann ist der vollständige Corona-Impfschutz erst am 15. Juni erreicht.

@mawis
Could you open a new issue for the time zone bug? This has to be tracked separately (and again it has to be checked under iOS too).
Thank you!

@Ein-Tim Done, I opened a new issue of that: #3562

PR: https://github.com/corona-warn-app/cwa-app-android/pull/3567 will also fix this (day 0 will be shown as tomorrow).

As mentioned in https://github.com/corona-warn-app/cwa-documentation/issues/638#issuecomment-869143434 I can confirm that today the tile is still grey (which is correct), the counter decreased to 0 (in both: the tile and the text after tapping on the tile).
Under iOS the counter says "1" and the tile is still grey (both correct).

And today the tile is blue and the counters are gone.👍🏻

FYI: In future it will show on the last day "Morgen/Tomorrow".

CWA Android 2.4.3 has been released and is now in the Google Play Store.

Works for me now!

After confirmation from @DerVogel2020, I assume that this has been fixed.
Closing as fixed.

Dear community, thanks for contributing!

Corona-Warn-App Open Source Team


Various exceptions when shutting down alpha2

A few issues I found while starting and stopping adhearsion alpha2:
https://gist.github.com/165a869be07c65d07d13

So, the generator does have a typo, fixed here: https://github.com/adhearsion/adhearsion/commit/376eef2cc7a6143ab7ac59f7a9259597d78f6c0a
The first exception was craziness in Celluloid, the actor library we're using in Punchblock. I've fixed that problem here: https://github.com/tarcieri/celluloid/pull/25
The second exception is coming from rubygems and I doubt there's anything we can do about that.
As for the last one, can you please expand on "trying to duplicate the bug that locked adhearsion up". Do you mean exception #1? You will find it very hard to reproduce that one, you had a window of about a single processor instruction to get that mutex unlock thing causing a problem. It looks like you have a borked ruby install with no readline. Are you able to start adhearsion properly at all and get a console prompt?

Thanks for those fixes. I was trying to duplicate exception #1, with no luck.
I can start Adhearsion and it will take calls. These exceptions all occurred when shutting adhearsion down (ctrl+c).

Ok, for now, I can't reproduce or find a reason for the last exception, so I'm going to consider it a one-off. If it happens again, I'll re-open this issue.


Update: Adobe.CreativeCloud version <IP_ADDRESS>

Created by 🥟 Dumplings in workflow run #7293.

Log
Submitting WinGet manifests
Found existing pull requests:
New version: Adobe.CreativeCloud version <IP_ADDRESS> - https://github.com/microsoft/winget-pkgs/pull/161277
This task is configured to ignore existing pull requests
Creating manifests
Uploading manifests and making commits
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

(Automated response - build 887.)

Close with reason: Duplicate of #167448;


Add Visual Studio plugin

Coverage remained the same at 65.08% when pulling 709c42e7167a8dc8926f09cd380829b4948b6728 on jjonescz:vs-plugin into 9aa55dfefdd61bd057eda66586b2e9119a5f2a39 on git-time-metric:master.

Thanks for the plugin 👍


Does not work in django v1.8.0

I got this error bellow:
Traceback (most recent call last):
  File "base/seo.py", line 3, in <module>
    from rollyourown import seo
  File "/home/tianyu/.virtualenvs/retie/local/lib/python2.7/site-packages/rollyourown/seo/__init__.py", line 4, in <module>
    from rollyourown.seo.base import Metadata, Tag, KeywordTag, MetaTag, Raw, Literal, get_metadata, get_linked_metadata
  File "/home/tianyu/.virtualenvs/retie/local/lib/python2.7/site-packages/rollyourown/seo/base.py", line 17, in <module>
    from django.utils.hashcompat import md5_constructor
ImportError: No module named hashcompat

Same for Django 1.7:
$ pip freeze | grep -i django
Django==1.7.4

  File "/home/oleg/.virtualenvs/prj/local/lib/python2.7/site-packages/rollyourown/seo/__init__.py", line 4, in <module>
    from rollyourown.seo.base import Metadata, Tag, KeywordTag, MetaTag, Raw, Literal, get_metadata, get_linked_metadata
  File "/home/oleg/.virtualenvs/prj/local/lib/python2.7/site-packages/rollyourown/seo/base.py", line 17, in <module>
    from django.utils.hashcompat import md5_constructor
ImportError: No module named hashcompat

Has anyone manage to have a look at this?

Module hashcompat was removed in Django 1.6. Check this out https://github.com/willhardy/django-seo

To romansalin, what excactly does you comment mean in this. Should I just take your repo instead of this? Can it be installed with pip? Why is this repo not fixed on this issue of being compatible with Django 1.9? I appreciate an answer to this, since I want to decide what to do with my seo.

Anybody got an answer on this issue? Having the same problem with Django 1.8.5
pip freeze | grep Django==
Django==1.8.5

python manage.py syncdb
  File "/Users/saverio/workspace/ontdek/oba/lib/python2.7/site-packages/rollyourown/seo/base.py", line 17, in <module>
    from django.utils.hashcompat import md5_constructor
ImportError: No module named hashcompat

I believe the file in [https://pypi.python.org/simple/djangoseo/] is outdated (has the unfixed code). Pip would take it from there. Try pip install -v -v -v djangoseo (see [http://stackoverflow.com/a/17153977/2158516])

@sabinem, actually it is the fork from this repo, which is no longer maintained. I made there some improves and bugfixes. Currently this package can't be installed with pip, but I'm going to do add it to the pypi. The compatibility with Django 1.9 will be added too.

@romansalin thanks. Any estimation on when will you be able to add it pypi?

@jcastiarena here is the new repo https://github.com/romansalin/django-seo2. I've published this on PyPI, so now you can install django-seo2 via pip:
pip install django-seo2

There is a major bug in the django-seo2 package, but @romansalin has stopped responding and wont publish the fix. Its been broken for almost a year now.
Is there any other forks that have better support?

Any other forks that have fixed the hashcompat issue? It's not working in Django 1.6.5 also


add next-seo + include default SEO config

Description
Adds next-seo and include all default SEO config to apply to all pages.
This is a starting point for all the remaining SEO-related issues (e.g. #24, #115)
Current Tasks

[x] Add next-seo plugin
[x] Include default SEO config
[ ] Cleanup <head> tags that are no longer necessary after next-seo addition

@zainfathoni Lighthouse SEO score is still taking a hit here, since we're not using the valid domain name for canonical link (we hardcoded the domain instead).
We need to be able to dynamically get the domain from Next.JS so that the site_url config is also not necessary.


Hydrogen CLI does not support Yarn v4 with Hydrogen upgrade

What is the location of your example repository?
No response
Which package or tool is having this issue?
CLI
What version of that package or tool are you using?
3.56.3
What version of Remix are you using?
2.8.0
Steps to Reproduce
I'm currently running a fairly unconventional setup that is a mono repo using Turbo, with two Hydrogen projects inside the app directory and is sharing UI and Features from the packages directory.
Recently we upgraded the package manager from yarn v1.22.21 to yarn v4.1.1 for better mono repo support and faster ci/cd times.
I am attempting to upgrade the current hydrogen version for one of the apps, however when doing so it errors saying the global yarn version is still v1.22.21 even after setting the global version to v4.1.1. Another issue is that it is attempting to run yarn install however the command has changed to yarn add
Unfortunately we cannot upgrade with npm due to the use of workspaces in the monorepo and yarn is failing to install via the cli.
Greater support for yarn would be appreciated, but at this stage, i don't mind just knowing exactly all the dependencies needed for upgrading and could manage this manually

Expected Behavior
Upgrade Hydrogen version and its dependencies
Actual Behavior
Installation fails

Thanks for reporting. The list of dependencies to install shows up in the error so I guess that's good enough for now?
@isaacroldan It looks like installNodeModules({packageManager: 'yarn', args: ['dep-name']}) might need to be fixed for Yarn here? What about using add for Yarn if there are no flag-args passed?

@frandiox Yes, that change makes sense.
Although I have to say that the CLI doesn't officially support yarn 2/3/4, it might work, but we only officially support yarn 1.x for now.


[Graphics] Graphics Library for UI

We can either approach to Cairo which is really a good graphics library and widely used, Or we can either make any existing C# graphics library to work on Atomix Platform.

A good thing to do is, to provide a backend (like Cairo), and make wrappers for it that work seamlessly like C# graphics library (System.Drawing).


Upgrading node to v6.14.0

Hi @subhashjha333 . Thanks for contributing. Can you describe why this changes is necessary and how the minor version bump is benefitting ?

@vickramdhawal  The customer have reported few security issues in Dreamweaver in current version of node which has been fixed in v6.12.2. On the top of that node has some additional fixes in v6.14.0. Thus I picked up this for integration.
v6.11.0  contains the vulnerability CVE-2017-15896 as described in https://nodejs.org/en/blog/vulnerability/december-2017-security-releases/.

@subhashjha333 Thanks for this PR!


Accessor macros don't work with names ending in "?"

This works:
class Foo
  getter? bar = false
end

This doesn't:
class Foo
  getter bar? = false
end

IMO both forms should result in the same definitions.

No they shouldn't, because you cannot define a bar?= method.

Well, it would be nice if you'd wait with closing issues a bit more, since it's your opinion only and I'd like to point out that JSON.mapping uses these macros which makes defining question methods impossible.

Yeah my bad, I shouldn't have closed it.

Below IMO should work without any fiddling around (like defining another alias methods for "not working" properties):
require "json"

class Foo
  JSON.mapping({
    bar?: Bool
  })
end

if you want json method? it may be related to #4129.
About getter bar? I don't think that's a good idea, and the root cause is that ivars cannot have punctuations like @bar? = true. IMO getter should stay simple, without edge cases like this, but JSON mapping can have an upgrade like https://github.com/crystal-lang/crystal/issues/4129#issuecomment-285875957.

@bew I missed that one, thanks! consider this as duplicate, closing.


fix(tests): e2e tests returns exit code 1 when failing

Closes #196. Here is the example of failing e2e tests: https://travis-ci.org/jkuri/angular-cli/builds/117273558 and are not ignored.

LGTM. You can merge this if you want.


improving readability

Proposed changes
Currently when providing a name via the UI for a new scenario, if the end user uses a name that has an uppercase letter they are presented with this error message:
Chaos Scenario name can only contain - and alphanumeric characters

This change updates the English text to be more clear to the end user.
Types of changes
What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

[ ] New feature (non-breaking change which adds functionality)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x ] Documentation Update (if none of the other choices applies)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ x] I have read the CONTRIBUTING doc
[ x] I have signed the commit for DCO to be passed.
[ x] Lint and unit tests pass locally with my changes
[ x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x ] I have added necessary documentation (if appropriate)

Dependency

None

Special notes for your reviewer:
This is only an error message update to make the message more helpful for the end user.

no longer care


What should we name the pipeline?

Certainly! How about "CADENCE"? It could stand for "Comprehensive Algorithm for Detecting NeoAntigens with clonal Expression." This name combines the musical concept of cadence with the idea of developing neoantigens, suggesting a structured and creative approach to the pipeline.


transport/owr_transport_agent.c typo

Using the library gst-plugins-good 1.4.5, I found a type in transport/owr_transport_agent.c at line 2400. It is written GST_RTCP_RTPFB_TYPE_RTCP_SR_REQ but in gst/rtp/gstrtcpbuffer.h it is written GST_RTCP_RTPFB_TYPE_RCTP_SR_REQ

That was fixed after 1.4.5 and OpenWebRTC requires a recent version from GIT to work properly.


Wrong generated type for localized text fields

Link to reproduction
Payload > 1.15.0
To Reproduce

Create localized text fields in your config
Run generate:types

Describe the Bug
Take the following config:
export const Documents: CollectionConfig = {
    slug: 'documents',
    fields: [
        {
            name: 'title',
            type: 'text',
            required: true,
            localized: true,
        },
        ...
    ]
}

It is currently generating the following types:
export interface Document {
  id: string;
  title: string;
  ...
}

Which does not work when querying with locale: 'all', eg:
{
  id: '64bb323c17c027b62c619846',
  title: { 'en-CA': 'Terms of Service', fr: 'Conditions de service' },
  ...
}

I would expect them to be something more like:
export interface Document {
  id: string;
  title: string | { [k: string]: string};
  ...
}

Payload Version
1.15.0

The only solution I would support on this is to have a LocaleAllDocument type that is completely separate from the Document type change. The reason we don't want to have title: string | { [k: string]: string}; is because it will be a breaking type change for a lot of frontends that will need to do some extra type narrowing in a ton of places.
I'm converting this to a discussion as it isn't simply a bug. If anyone can think of another solution, we have a similar problem around the depth parameter causing different document structures to be returned than what the types include.
Thanks @qbeauperin!


v1.0.5-rc.6 opens tN files with the blue bar and repo chips scrolled out of view

(this caused Katalon scripts to fail)
tA and tW both open properly in both develop and production
In v1.0.5-rc.6 tN files opens like this:

In v1.0.4 (production)  tN, tA, and tW files open like this:

Tested in TCC tN Test Column Options

Looks good in v1.1.0-rc.3.

Looks good in v1.1.0-rc.3.

Looks good in v1.1.0-rc.3.

Looks good in v1.1.0-rc.3.


1.20.5

Haven't tested 1.20.5-rc1 yet but the changes are pretty trivial so it should still work.

i realized the tags are getting shuffled on every update which isn't ideal but doesn't actually matter lol. also i haven't tested this version specifically but i tested the last release candidate where they made protocol changes so it should be good to merge.


Update walkthrough in line with Deploy setting flag removal

With the completion of #7088, we need to update the walkthrough

This is finished


Best way to locate HTML pages in boxes

Hi,
First, TNX a lot for your great work!
I just downloaded the theme and started playing with it. I have 2 quite "basic" questions:

I want to customize the boxes at the index page and locate there some data tables [for instance]. In addition, I would like to use other HTML page for that (In order to reduce the code at the index page).
What is the best practice for that (Use an iframe maybe?) Do you have an example?

I noticed that every time I choose one of the options in the side bar, it refreshes all page. What is the best way to prevent it?

TNX,
Yigal.

Hello,

The best way to reduce lines of code on a file is to a backend language to include your partial code. For example, using PHP you can say include "visitors_box.php".

There are multiple ways to do that, all of them use AJAX. You may consider libraries such as AngularJS or pjax.

Thanks!


allocate eip to specified namespace

Thank you for your contribution!!!
These new additions are still features of the new version of openelb that have not yet been released, so please submit PR to the refactor branch.


checks if lowerCamel key exists upon missing attr

Priority
Is this PR blocking your next action?
Yes.
What Changed & Why
JSON API spec dictates that keys use dashes, but javascript convention is lowerCamel
The examples all use one word keys so the problem of consuming a two-word key never comes up.
This change checks if a lowerCamel attribute exists on the config model if the first does not.
I could have put the replace line before the initial attrConfig assignment but this avoids doing a replace unless the key is missing the first time around.

Ok, hadn't really thought of this, but suppose it makes sense

Awesome! Thanks!


CookieMonsterData idea

It would be really nice if CookieMonsterData could provide something similar to Game.UpgradesByID or a list of just the upgrades shown available for purchase. In the script that I am making that makes use of "CMD" I went with a more hacky way of getting upgrade Colors because I didn't want to have to iterate over both the upgrades on screen and all of those that exist while trying to match them up. Maybe I will eventually, but it would be nice if I didn't have to on my end.

Looking at the data present in CookieMonsterData it seems that all upgrades that are not visible have a pp of null. You could check for this and then only use upgrades that have a pp that is actually a value?
However, I do think I might change this in the future as it would be a good optimisation to remove the calculation for non-available upgrades.
Another option would be to use Game.UpgradesInStore and take those with a .pool that is not "toggle".
I might consider adding this to CookieMonster, but as we currently don't need it ourselves it might not be a priority.

Yeah, I'll probably wind up just completely rewriting the way I buy upgrades. That bit has a lot of code from the original code mine is based on and I just kinda hacked it to mostly work for my purposes. Those are some good ideas on how to manage it, didn't even know about Game.UpgradesInStore. problem with that route is that I still would have to itterate through the whole list of CookieMonsterData to get pp. But yeah, just filtering out null results and then buying it through Game functions is a much better way than the mess of JQuery I have that I barely understand.

I think if you use Game.UpgradesInStore you don't need to iterate as you can just do CookieMonsterData.Upgrades[UpgradeName].colour to find the colour. With that approach you only need to iterate with over Game.UpgradesInStore which is by default always less than the total amount of upgrades.

 Something to add to the list.

With #898 CookieMonsterData.Upgrades now only shows upgrades currently available in store


IDENTITY clause in column definition not handled

Describe the bug
SQLServer - INDENTITY clause in column definition causes a problem with the entry size
To Reproduce
Steps to reproduce the behavior:
In the ddl:
[cifno] [numeric](10, 0) IDENTITY(1,1) NOT NULL,
puts (1,1) in the size field
Expected behavior
Either ignore the IDENTITY clause or create a separate object entry for the identity value
Screenshots
None
Desktop (please complete the following information):

OS: Windows 11
Browser chrome
Version 01/10/2023

fix prepared in https://github.com/xnuinside/simple-ddl-parser/pull/195, I will comment one more time after version 0.30.0 will be released

@ctimmer just released version 0.30.0. Try it, test was added - https://github.com/xnuinside/simple-ddl-parser/blob/main/tests/dialects/test_mysql.py#L315. If will be needed something new - feel free to open the issue.


Reverse swipe direction

I installed a wordpress plugin which utilizes the Tocca.js. It is called Gesture (https://premium.wpmudev.org/blog/easily-add-touch-gestures-to-your-wordpress-site/). However, I would like to reverse the swipeleft and swiperight actions. I have tried without success.
Thanks.

Please contact the wordpress plugin author I am not responsible of third party tocca.js implementations


update demo working on sample test images

fixes https://github.ibm.com/Watson/developer-experience/issues/180

looks like the test is expecting a "Use a random image"

Yep, I forgot to update the tests. I've fixed it.


Update Travis file for pyChapel to use new testing system.

Based on a similar change to the Chapel master.

@Kyle-B, travis testing passed and it didn't give me the "you're on the wrong job system" message, so I guess this is ready for review.

Looks good.


Add ReplicaAutoBalance param for StorageClass

Hi, I would like to add possibility to configure ReplicaAutoBalance parameter for StorageClass definition.
Signed-off-by: Tomáš Novák<EMAIL_ADDRESS>

@longhorn/qa Could you help verify this PR? Thanks.

@c3y1huang Hi, can you review it? It's been almost 3 weeks since opening and still awaiting review.


Log build errors

Related to https://github.com/babel/babel-library-boilerplate/pull/128

Released in v0.2.1


GH-48: Migrate to fluid-lint-all (resolves #48).

Also updates all dependencies that can be safely updated.

Self-merging dependency update per discussions with Antranig.

Self-merging dependency update per discussions with Antranig.


Add a save() method in TextPage, which knows to save in the same charset as was received in the response.

Will be great if you can add a unit test also.

That will take a bit longer, but I guess there's no hurry anyway

Have written a simple test and merged your pr.
Many thanks, hope HtmlUnit is some help for you.

Thanks, I used HtmlUnit a long, long time ago, and it's grown by leaps and bounds since then. I'm glad I can give it another try