Helios fails to sync (invalid sync committee period)

Hello, I am experimenting with Helios and noticed something that I need to understand and may be a bug.
I would like to use Helios to validate historical data, which means that I am interested in running Helios from the oldest checkpoint possible. Moreover, as time goes by, and more checkpoints are created, I will still want to start from that oldest possible checkpoint.
I started then Helios like this (I am testing changes to the code, so I am building the code)
$ cargo run  -- \
      --network mainnet  \
      --consensus-rpc https://www.lightclientdata.org \
      --execution-rpc $EXEC_RPC_WITH_API_KEY

I ran it in that way to trigger Helios to use the BaseConfig checkpoint
0xc7fc7b2f4b548bfc9305fa80bc1865ddc6eea4557f0a80507af5dc34db7bd9ce

which seems to be for this block at slot 8613568 (from Sep-24-2019 07:15:20 PM +UTC) which looks fine. And I know that in theory, I am be able to run with --checkpoint and use that checkpoint later to fix that as a starting one.
Now, the issue I have is that Helios fails to sync. This happens at "around" (below is the last update I see validated by Helios in my prints) the point where the finality update has
Attested header slot:10152347
Finalized header slot:Some(10152256)

Here are the normal logs:
$ cargo run  -- \
      --network mainnet  \
      --consensus-rpc https://www.lightclientdata.org \
      --execution-rpc $EXEC_RPC_WITH_API_KEY
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.25s
     Running `target/debug/helios --network mainnet --consensus-rpc 'https://www.lightclientdata.org' --execution-rpc 'https://eth-mainnet.g.alchemy.com/v2/<HERE IS MY API KEY>'`
ConsensusClient RPC: https://www.lightclientdata.org
Default checkpoint leaded 0xc7fc7b2f4b548bfc9305fa80bc1865ddc6eea4557f0a80507af5dc34db7bd9ce:
2024-10-11T13:08:47.772539Z  INFO helios::rpc: rpc server started at <IP_ADDRESS>:8545
2024-10-11T13:08:48.938388Z  WARN helios::consensus: checkpoint too old, consider using a more recent block
2024-10-11T13:08:53.951582Z  INFO helios::consensus: sync committee updated
2024-10-11T13:08:54.452449Z  INFO helios::consensus: sync committee updated
2024-10-11T13:08:54.954452Z  INFO helios::consensus: sync committee updated
2024-10-11T13:08:55.465156Z  INFO helios::consensus: sync committee updated
2024-10-11T13:08:55.972255Z  INFO helios::consensus: sync committee updated
2024-10-11T13:08:56.486164Z  INFO helios::consensus: sync committee updated
2024-10-11T13:08:57.000883Z  INFO helios::consensus: sync committee updated
2024-10-11T13:08:57.519062Z  INFO helios::consensus: sync committee updated
2024-10-11T13:08:58.033118Z  INFO helios::consensus: sync committee updated
2024-10-11T13:08:58.549821Z  INFO helios::consensus: sync committee updated
2024-10-11T13:08:59.079259Z  INFO helios::consensus: sync committee updated
2024-10-11T13:08:59.616485Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:00.144696Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:00.687047Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:01.226089Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:01.762875Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:02.312410Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:02.853935Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:03.398686Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:03.975107Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:04.573795Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:05.105404Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:05.627512Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:06.230685Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:06.800106Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:07.364466Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:07.934522Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:08.549117Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:09.127214Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:09.677936Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:10.204541Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:10.734456Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:11.259440Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:11.790895Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:12.316871Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:12.863380Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:13.392050Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:13.919872Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:14.453015Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:14.989828Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:15.570070Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:16.121032Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:16.644695Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:17.188080Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:17.713029Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:18.237662Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:18.764083Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:19.289330Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:19.814826Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:20.339830Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:20.864856Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:21.386316Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:21.934267Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:22.459005Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:22.995888Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:23.527148Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:24.052272Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:24.565964Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:25.090404Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:25.622298Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:26.147243Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:26.675490Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:27.207140Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:27.730732Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:28.259521Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:28.783406Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:29.336588Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:29.900849Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:30.468631Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:31.028030Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:31.593209Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:32.145113Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:32.705123Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:33.272768Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:33.852040Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:34.445757Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:35.031867Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:35.591344Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:36.138531Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:36.685892Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:37.256491Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:37.830011Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:38.377169Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:38.916183Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:39.475376Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:40.035589Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:40.576541Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:41.143514Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:41.707088Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:42.250476Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:42.820803Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:43.397150Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:43.957646Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:44.526665Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:45.085213Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:45.651808Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:46.213737Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:46.776256Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:47.348839Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:47.910653Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:48.469736Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:49.020085Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:49.581192Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:50.141864Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:50.713124Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:51.265271Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:51.816961Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:52.371762Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:53.002831Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:53.561575Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:54.121904Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:54.676716Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:55.232735Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:55.782460Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:56.351774Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:56.929865Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:57.551266Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:58.289911Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:58.896568Z  INFO helios::consensus: sync committee updated
2024-10-11T13:09:59.470696Z  INFO helios::consensus: sync committee updated
2024-10-11T13:10:00.047285Z  INFO helios::consensus: sync committee updated
2024-10-11T13:10:00.646327Z  INFO helios::consensus: sync committee updated
2024-10-11T13:10:01.194848Z  INFO helios::consensus: sync committee updated
2024-10-11T13:10:01.754387Z  INFO helios::consensus: sync committee updated
2024-10-11T13:10:02.319570Z  INFO helios::consensus: sync committee updated
2024-10-11T13:10:02.878364Z  INFO helios::consensus: sync committee updated
2024-10-11T13:10:03.423185Z  INFO helios::consensus: sync committee updated
2024-10-11T13:10:04.086961Z ERROR helios::consensus: sync failed err=invalid sync committee period

If I load a newer checkpoint, I know it works (as I saw recommended in https://github.com/a16z/helios/issues/361) but for my use case this is not ideal. I saw this same issue in Holesky testnet (at a different slot of course as it is a different chain).
My questions are:

why is this failing? Is this a bug of the implementation? was there a change at certain ETH upgrades that "broke" the protocol?
can this be fixed?
Is there any suggested workaround you could find?
Do you know the oldest checkpoint I could use in case there is no workaround?

Thank you in advance for the responses

Yes so the reason for this is that the networking spec defines a maximum number of light client updates you can fetch at once, which Nimbus (the node we use for the consensus rpc that we provide by default) enforces this. This means the maximum age of a checkpoint Helios can fetch is 128 * 27 hours = 144 days. This could be addressed by having Helios make multiple update request calls here. We haven't supported this in the past, since we suggest users start up with a somewhat recent checkpoint (and after first sync, helios caches new checkpoints to use, so as long as clients go online every so often after first sync, you are good). The reason we suggest this is there is a class of attacks known as "long range attacks" or "weak subjectivity attacks" that you become susceptible to if you use very old checkpoint. Fortunately for the light client protocol, these attacks are hard to pull of in practice. It shouldn't be to hard to calculate how many updates you need by finding the expected period (using expected_current_slot and dividing by 32 * 256) and subtracting the bootstrap period (using the bootstrap slot and diving by 32 * 256), which yields the number of periods we need. If it is greater than 128 we can just make multiple calls to get_updates to fetch the full list. Is this something you'd be interested in working on? If not, I can probably get to it soon.

Thank you for the explanation @ncitron
I did the following changes based on your comments and seems to work, but I am not sure if I could be missing some corner cases.
Any place where I could read more on long range attacks/weak subjectivity? It is good for me to understand the potential risks for my intended use.
Once again, thank you for the responses in advance

I think the main change I would make to that is we should provide exactly how many updates we need, rather than just doing the MAX for each time.


Remove automatic retries

Requests to Jellyfish are not currently idempotent, making automatic
retries unsafe. We've seen multiple incidents in production where
a non-200 HTTP status code is generated, but the contract has still been
correctly created, resulting in multiple entities being created.
Change-type: patch
Signed-off-by: Lucian Buzzo<EMAIL_ADDRESS>

@balena-ci I self-certify!


Adding 169-Majority Element.cpp

File(s) Modified: 169-Majority Element.cpp,225- Implement Stack using Queues.cpp
Language(s) Used: cpp
Submission URL: _https://leetcode.com/submissions/detail/690132340/
https://leetcode.com/submissions/detail/693380610/_

Thanks, @shreyasri258!


Multilingual support

We should have the main site in different languages. There's not really much to translate. Leaving this here for future and brainstorming.
I guess we should tackle it the same way we tackled other translations, via Transifex.
Tagging our experts @britttttk and @vswee for a brainstorm session.

i'm in for Arabic Translation but make rtl support pls :D

@kemoantemo shoot me a message on mattermost (ed_flat18). I could use your help to make sure the rtl layout actually makes sense in your language. Demo site is getting RTL-ed.

Raw en-gb readout of website strings can be found at here to help with translations.

@vswee do you have a link to the demo of the site with the translations or a description of the process to implement it?

@huey735 Demo site: https://btcpayserver.flat18.co.uk/
The JSON file at https://experimental-btcpayserver.flat18.co.uk/resource/translation/json/en.json
is generated from looping over the real elements on the demo site. Every element is given a corresponding index to the string in the file and the translation script basically loops back over and replaces the strings from the translation files according to the same index. Today I'll be smartening up the translation script so that it changes only the text in links etc. instead of rewriting them as text.

DONEEEE ❤


Bug 2102086: Bump OCP and UBI versions

The plugin needed the correct OCP and UBI versions for this release.

/bugzilla refresh

/bugzilla refresh

/bugzilla refresh


Support Keycloak as an authentication provider in Toolpad

Summary
Yesterday, a user mentioned using Keycloak as their identity and access management. They use username and password flow but Keycloak supports social logins as well.
Keycloak has a JS adaptor to enable authentication and set up a client. We need to create a custom way to integrate with these providers and enable role-access mapping.
Examples
No response
Motivation
No response
Search keywords: keycloak

Keycloak has a JS adaptor to enable authentication and set up a client. We need to create a custom way to integrate with these providers and enable role-access mapping.

We use auth.js and there already is a keycloak adaptor.

When might this be available so we can start working with Toolpad ?
Thanks!

@consolidatedbilling We should be able to provide it by the end of this month. Assuming you'd use it for roles and permission management, I just wanted to let you know that it will be a paid feature eventually. Refer: RBAC to learn more.


chore: upgrade sort-package-json to v2

upgrade sort-package-json from 1.52.0 to 2.10.0
run lint:package script which changes ordering of package.json

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#327  👈
#326
#325
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mcmxcdev and the rest of your teammates on  Graphite

Merge activity

Apr 29, 9:52 AM EDT: @mcmxcdev started a stack merge that includes this pull request via Graphite.


Allow using STU3 URLs for FHIRcast

We are trying to utilize the medplum client to interact with a third party fhircast hub which implements the STU3 spec where the hub topic can be defined in the body instead of being required on the url itself: https://hl7.org/fhir/uv/fhircast/2024May/2-6-RequestContextChange.html#request-context-change-example. Currently having to manually override the url:
  const { fetch: originalFetch } = window;

  window.fetch = async (...args) => {
    let [resource] = args;

    return await originalFetch(
      resource.toString().replace("fhircast/STU3", fhircastPrefix)
    );
  };

This should be supported if Medplum plans on supporting FHIR cast STU3: https://www.medplum.com/docs/fhircast. If this is already on the road map, apologies!

Hey Sachin,
Sorry about that. We were definitely cheating on our client implementation... I think the confusion arose around some of the earlier examples (before the latest May 2024 revision) containing a string that looked similar to the unique ID that is present in the hub.channel.endpoint but that seems to be an error on our part.
Looks like we should have always supported it issued on hub.url, which is odd because this is definitely overloading hub.url with publish and subscription requests... but looks like that's the spec 😅
So our proposed solution would be to:

Add a way to override fhircastUrl (it will default to our fhircast/STU3)
Make fhircastPublish directly publish to the hub.url (what we will call fhircastUrl in MedplumClient)
Make all FHIRcast methods make requests based off of fhircastUrl rather than the hardcoded fhircast/STU3

No worries @ThatOneBro ! That solution should work for us. Thank you for getting back so quickly.


Error installing on Centos 7

gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/root/.nvm/versions/node/v11.4.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:189:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:254:12)
gyp ERR! System Linux 3.10.0
gyp ERR! command "/root/.nvm/versions/node/v11.4.0/bin/node" "/root/.nvm/versions/node/v11.4.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /root/node_modules/node-opus
gyp ERR! node -v v11.4.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm WARN enoent ENOENT: no such file or directory, open '/root/package.json'
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of erlpack@discordapp/erlpack but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN root No description
npm WARN root No repository field.
npm WARN root No README data
npm WARN root No license field.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/ref):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>install: node-gyp rebuild
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: Exit status 1
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2019-01-04T09_50_54_089Z-debug.log

I'm archiving the repository for lack of interest in maintaining it. Sorry I never got to deal with this issue. Please see @discordjs/opus for an alternative implementation that is based this project but uses more stable Node.js module technology that should break less between Node.js versions.


Integrate llvm-project and bump dependencies

There is a build issue with mhlo. Looking into it.

llvm-project: 59179d72b2e3
mlir-hlo: 17aa92116c0df43aa3dd3824615f9e4a069929fc
tensorflow: 78b08515fe3fa7a7daabcc6251242af7a07a2900

This PR adds interface directories for the target, which caused a build error. https://github.com/tensorflow/tensorflow/pull/56844
For some reason, the binary directory for mhlo is build/third_party/llvm-project/llvm/tools.

//compiler/src/iree/compiler/Codegen/SPIRV/test:vectorize_tensor_pad.mlir.test fails because the generated IRs for boundary check are different. Looking into it.

Now it seems okay, but there are a few tests pending. @GMNGeoffrey do you have any idea?

Force pushed it again to see if it fixes the pending tests issue.

Looks like it's because you have merge conflicts. It can't check out the merge commit because there is no merge commit🙂

After cherry-picking one, now I have an error. It looks like the cherry-picked code breaks something. Looking into it.
within split at /home/kbuilder/.cache/bazel/_bazel_kbuilder/c32aa9ac646722210ccee9c722c31e29/sandbox/processwrapper-sandbox/13672/execroot/iree_core/bazel-out/k8-opt/bin/compiler/src/iree/compiler/Codegen/SPIRV/test/pipeline_matmul_cooperative_ops.mlir.test.runfiles/iree_core/compiler/src/iree/compiler/Codegen/SPIRV/test/pipeline_matmul_cooperative_ops.mlir:1 offset :59:15: error: failed to legalize operation 'vector.transfer_read' that was explicitly marked illegal
        %26 = linalg.matmul ins(%19, %21 : tensor<256x128xf16>, tensor<128x1024xf16>) outs(%25 : tensor<256x1024xf16>) -> tensor<256x1024xf16>
              ^

oh no . @ThomasRaoux and @bjacob any ideas?

Yup, this error is what you get if you take my llvm-project cherry-pick but don't have the corresponding IREE change applied to match it, see the IREE changes in the cherry-pick PR:
https://github.com/iree-org/iree/pull/9890

@bjacob that's a great hint! I think I fixed the issue.


Fix datastore grpc doc class generation for python and ruby

#716 This is due to datastore API's GqlQuery message's comment contains '$' so we have to escape it, otherwise it will cause java's regex failure (throwing IAE exception)
In https://github.com/googleapis/googleapis/blob/master/google/datastore/v1/query.proto#L232,

Key must match regex [A-Za-z_$][A-Za-z_$0-9]*

The original CommentPatterns.PROTO_LINK_PATTERN causes the above [A-Za-z_$][A-Za-z_$0-9] to be parsed as a proto link, using Ruby as an example (similar with Python and NodeJS)
In RDocCommentFixer.java:
  private static String rdocifyProtoMarkdownLinks(String comment) {
    StringBuffer sb = new StringBuffer();
    Matcher m = CommentPatterns.PROTO_LINK_PATTERN.matcher(comment);
    if (!m.find()) {
      return comment;
    }
    do {
      m.appendReplacement(sb, String.format("%s", protoToRubyDoc(m.group(1))));
    } while (m.find());
    m.appendTail(sb);
    return sb.toString();
  }

When m.appendReplacement is called, the second argument contains a '$' in it (because m.group(1) is A-Za-z_$, so that causes appendReplacement to throw IAE.

Current coverage is 81.33% (diff: 100%)

Merging #716 into master will increase coverage by <.01%

@@             master       #716   diff @@
==========================================
  Files           292        292
  Lines         11117      11119     +2
  Methods           0          0
  Messages          0          0
  Branches       1465       1465
==========================================
+ Hits           9042       9044     +2
  Misses         1673       1673
  Partials        402        402

Powered by Codecov. Last update e4f977a...10c9f12

@jmuk Like fuzzing?

oh, not saying that random :)
I'd like to recommend to copy&paste some comments which causes this problem from the production proto files (or write something by ourselves).

Got it. SGTM

@jmuk @bjwatson @geigerj I added unit test cases to test how Python/Ruby/NodeJS CommentFixer should handle '$' to avoid throw IAE. These are not comprehensive test cases for the CommentFixers, because I think this PR should focus on related problems. I filed https://github.com/googleapis/toolkit/issues/722 to add more comprehensive tests. I think @geigerj understands best for these markdown link requirements, so I assigned it to him.

@jmuk I updated the description to add more details how this problem is caused.

@jmuk @bjwatson @geigerj PTAL

OK, makes sense. Comments will help make this clear.
On Nov 7, 2016 10:15 AM, "Song Wang"<EMAIL_ADDRESS>wrote:

@swcloud commented on this pull request.
In src/test/java/com/google/api/codegen/ProtoDocumentLinkTest.java
https://github.com/googleapis/toolkit/pull/716:

+import org.junit.Test;

+public class ProtoDocumentLinkTest {
+

@Test
public void testMatchProtoLink() {
Matcher m;
m = CommentPatterns.PROTO_LINK_PATTERN.matcher("[Shelf][google.example.library.v1.Shelf]");
Truth.assertThat(m.find()).isTrue();
m = CommentPatterns.PROTO_LINK_PATTERN.matcher("[Shelf][]");
Truth.assertThat(m.find()).isTrue();
m = CommentPatterns.PROTO_LINK_PATTERN.matcher("[$Shelf][]");
Truth.assertThat(m.find()).isTrue();
m = CommentPatterns.PROTO_LINK_PATTERN.matcher("[][abc]");
Truth.assertThat(m.find()).isFalse();
m = CommentPatterns.PROTO_LINK_PATTERN.matcher("[A-Za-z_$][A-Za-z_$0-9]");

The reason why [A-Za-z_$][A-Za-z_$0-9] is added as a test case is that it
is a corner case causing the issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/googleapis/toolkit/pull/716, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAcyy7nNMWCEsO08SqP0UDW47XU1dZ1zks5q72rTgaJpZM4Kn5Ml
.

I was thinking of adding comments to library.proto (so that you can make sure everything is fine in the baseline files on every language).
It is actually not safe as unit tests you wrote, but it could reveal errors on other languages too.

If we want to comprehensive unit test cases and comments, it should be done in #722 separately.


JBPM-5175: ClassCastException on Tomcat8

Excluding jboss-transaction-api from webc WAR file.

+1 to merge


some fixes for #246

the ARXML loader did not specify a decimal object for all signals
the C code generator did not work for multiplexor frames because for those the keys of the signal_tree are not always strings (i.e.,
get_signal_by_name() returns None for these)
not setting the --no-floating-point-numbers and --use-float parameters caused an exception for the file I've tested

Andreas Lauser<EMAIL_ADDRESS>on behalf of MBition GmbH.
Provider Information

This Arxml change is causing tests fail.

AssertionError: Decimal('1') != None
Should self.assertEqual(mux_signal_selector.decimal.scale, None) assert be changed for that?

oops. I forgot to run the tests before opening the meta-PR. fixed, thanks for the catch!


Update README.md

Adding legitimate job search website and app.

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is ordered alphabetically
[x] My submission has a useful description
[x] The description does not have more than 100 characters
[x] The description does not end with punctuation
[x] Each table column is padded with one space on either side
[x] I have searched the repository for any relevant issues or pull requests
[x] Any category I am creating has the minimum requirement of 3 items
[x] All changes have been squashed into a single commit

Adding legitimate job searching website.

Hi @imrajeshkumar7492
Thanks for your contribution ;)
We have some problems with Public APIs, so we won't be able to review/add this improvement right now.
Read this issue for more information, please: https://github.com/public-apis/public-apis/issues/3104


Add vjp expval h

Before submitting
Please complete the following checklist when submitting a PR:

[x] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!

[ ] All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.

[x] Ensure that the test suite passes, by running make test.

[x] Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.

[x] Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:
Description of the Change:

lightning.gpu has native support for expval(H) in adjoint method now.
lightning.gpu has offloaded support for dense matrix and cuSparse SpMV in expval(H) calculations.

Benefits:
Possible Drawbacks:
Related GitHub Issues:

Nice work so far!

Hi all, I have updated the bindings, matrix validation, and supports for forward pass SparseH, and tests for forward and adjoint H. I think we are done here for the coming release.


Clarification needed on use of "null" for empty non-required fields

The spec doesn't say anything about null in place of empty arrays/maps in plenty of non-required fields, like in /sync.
It's not clear whether it is acceptable for these fields to be null, or if they should be empty or altogether omitted.

See https://github.com/matrix-org/matrix-doc/issues/2011

See https://github.com/matrix-org/matrix-doc/issues/2011


fine-tuning the mmprojector

Thank you for your outstanding work, which has allowed me to quickly start my fine-tuning process. However, I have the following two questions:

In the LoRA fine-tuning of the LLaVA series, most fine-tuning involves applying LoRA to the LLM while fully fine-tuning the mmprojector. However, in your work, I didn't seem to find parameters for controlling adjustments to the mmprojector.

I have previously tried various fine-tuning codes, including LLaVA-Next, using 4 L20 (48G) GPUs. In these 7B models, my LoRA parameters were set as r=128, alpha=256, maxlength=8096. However, in your project, when I fine-tune llava-interleave-qwen-7b-hf, I can only set r=8, alpha=8, maxlength=1024; otherwise, it results in an OOM error.

Currently we only support full finetuning of mmprojector, while LLM can be fully or LORA finetuned.
This repo is based on huggingface (HF) implementations of all the models. One caveat of HF implementations is that they did not count vision tokens into maxlength, which is different from for example the original implementation of LLaVA. This means that, for example for LLaVA-1.5, maxlength=100 in HF implementation is actually equivalent to maxlength=100 + 576 in the original implementation. This would be the first reason that may have caused OOM if you were using a very large maxlength. In more recent transformers library releases it starts to count vision tokens into maxlength. However I haven't got chance to reflect this update in the repo.

When I'm available (hopefully in the next 2-3 weeks) I will make a major refactor regarding problem 2.

🎉 Thank you for addressing my questions so promptly. I look forward to seeing even more outstanding results from you.

Regarding point 2, I have made the updates, but there could be some caveats that one should be careful about, which is thoroughly discussed in #45.
Closing now. Feel free to reopen if needed.


Conflict iwth some mod

Describe the Bug
minecraft works here

but not here

this is the log
https://mclo.gs/cnkK0hX
if i remove create it works normally. and no errors are show
Reproduction Steps

install mods in picture
hit run

Expected Result
for minecraft not to crash
Screenshots and Videos
No response
Crash Report or Log
No response
Operating System
Windows 10
Mod Version
0.5.1f
Minecraft Version
1.19.2
Other Mods
No response
Additional Context
No response

start by downgrading fabric api to 0.76

start by downgrading fabric api to 0.76

same issue, i hope u didn't come here only to mention that

post the new crash report

my friend, if you do not cooperate when we try to help you, your issue will simply go ignored

my friend, if you do not cooperate when we try to help you, your issue will simply go ignored

i found out what the issue is about it is about porting lib, which i think compact machines uses an old port of it and compact machines need to be updated if i am not mistaken, the troll asked for a new cash report after i already edited it and provided a new one with only 3 mods namely fabric api 0.76 , compact machines and create. also before u mentioned fabric api 0.76 it was already tested with that api and i received same error. because i read other issues before i posted this one and the api was irrelevant here.

hephaestus has the same issue. you need to understand that fabric api 0.76 is the 1 version that is known to work fpr 1.19.2. anything above is known to eventually cause crashes.  there is no point in trying to debug something when in the mix there is a version known to cause issues. hence the request to downgrade fabric api and post the new crash report.

if your pb is resolved, please consider closing this issue.


Moving mouse into/out of terminal prints garbage

OS: Ubuntu 12.04
Terminal: Default, Terminator, UXTerm, probably all
When Slap is open when I move my mouse into/out of the terminal window Slap inserts all sorts of crazy characters, such as '�J[MC�J�O[MC�O[MC�N'
Some notes on the circumstances:
I was SSH'd to a box that had slap on it, and used it there.
It ONLY happens when the terminal window is wider than 191 columns.
I understand that the problem in general is that the terminal is getting mouse events that aren't handled correctly, but hopefully you can find a way to mask them.

Same issue, using MobaXterm terminal. PLEASE help!! Love this editor, would like to actually start using and recommending, but the garbage on mousemove is killing it! Willing to help with any logs/more info as necessary

@wpg4665 (or anyone else with this issue) would you have time for a screenshare session over Google Hangouts? Feel free to add me at<EMAIL_ADDRESS>and we can schedule something over chat.

slap.log gist from screenshare with @secrettriangle
https://gist.github.com/wpg4665/ec316db169deb150ec6b

I'm able to reproduce this issue locally on MobaXTerm. It seems that terminal info is coming through incorrectly. We were able to get different behavior by passing a command-line parameter slap --term=$TERM where $TERM can be vt100, vt101, vt102, vt220, vt240, vt320, vt330, vt340, vt420, vt510, vt520, vt525, linux, screen, xterm, rxvt, and rxvt-unicode. Most of them (with the exception of linux) did not support the mouse at all. The $TERMs prefixed with vt ignored the mouse altogether, so garbage didn't come through, but other keybindings got messed up (e.g. pressing up and down caused slap to output [B and [A). Now that I have a reproducible environment I will be looking at this issue more closely.

Hi, i installed slap yesterday. I use xfce4-terminal on Xubuntu 14.04 LTS. Terminal app is set to xterm emulation. It prints garbage when I reach right side of application, but only when terminal window is wider than 190 columns.
Also probably related is, that help button in top right corner is clickable only when terminal window is smaller than 100 columns.
I didn't noticed any of this issues on my home computer yesterday (same os, settings etc.). I guess it's because it has smaller screen resolution (1024) opposite to full HD in work - leading to smaller number of terminal columns.

This will be fixed with the next release of blessed (tonight). Sorry for the inconvenience.

I've updated to the most recent version of blessed. Can anyone confirm this has been fixed?

Still happening on my setup
Host:
Cygwin
mintty 1.2beta-1
Windows 8.1 64bit
Vagrant 1.6.5
Guest:
Ubuntu Precise 12.04 64bit
NodeJS v0.10.36

@fskreuz, are you positive you're using the latest blessed? I cannot reproduce this at all now. I could before.

@chjj I just cleaned the cache of my npm, uninstalled and reinstalled slap and it still happens. I'm not entirely sure if it's my setup though that's messing with me. Will try later on a PC running Ubuntu natively just to be sure.

Confirmed to still be having the issue as well on slap v.0.1.4
Is there a specific $TERM we should be using??

If I can't reproduce this on any terminal, I can't fix it.
I've tried to reproduce this now on several terminals, but the main issue here was the node.js key parser thinking mouse events were keys. Blessed no longer uses the node.js key parser and reverted to an older one. On top of that, it was modified to specifically filter out mouse events. I don't see how we could ever go to greater lengths to prevent this if it is still happening. Are you absolutely sure you're using the latest blessed?
$ cd /path/to/slap
$ grep version node_modules/blessed/package.json
$ npm ls blessed

Please tell me what the output of the above commands is. If you get something other than v0.0.45, clear your node_modules and do another npm install.

Slap installs with v0.0.45 of blessed (even when doing npm install in slap). Manually installing blessed takes it to v0.0.47 (the latest on Github) and then... still happening.
 Could you try the latest commit to blessed? https://github.com/chjj/blessed/commit/a33525750528a392d5217aca427313f08a1038f7

Also, @fskreuz, what do you mean when you say cygwin? You're running a vm of ubuntu in mintty similar to qemu's vga->curses capability? Or you have Ubuntu running and you're simply ssh'ing into it from your cygwin terminal? Or is that irrelevant and you actually have a display server running on you Ubuntu vm? If so, what terminal are you running on Ubuntu (not your $TERM, the actual terminal).

@wpg4665 what OS are you using? On Linux, I use it with GNOME Terminal, and on OSX, I use iTerm2, both of which work great.
@chjj I was able to reproduce consistently on MobaXTerm... See #issuecomment-68796541

@chjj Tested on a Lubuntu and it works fine there.
Lubuntu:

OS: Lubuntu 14.04.1 LTS
Terminal: LXTerminal 0.1.11
$TERM: "xterm"
NodeJS: 0.10.36
NPM: 1.4.28
Blessed: 0.0.45
no tmux

As for the VM question, the VM is a headless VM. I ssh to the VM via Cygwin. Already switched the $TERM for Cygwin to xterm (from xterm-256color) and still the same result. Must be the Cygwin.

So this only affects windows terminals? Does Putty produce the same results?

@chjj Just tested Putty. Didn't happen there.

Strange considering mobaxterm is based on putty. I guess I'll have to fire up the old windows vm.

I suspect cygwin and mobaxterm are sending mouse events in chunks. That's the only thing that would explain this, which means we need a state machine to parse all keys and mouse events. Not very convenient. This is just a hunch, but it seems like the explanation.

Wow, so I just updated to Mobaxterm Pro v7.5...$TERM = xterm. Absolutely no issues!! =D

Can't reproduce with cygwin 1.7.34.

Oh, I didn't notice you were using mintty. I'll try that.

mintty works fine too.

If nobody else has issues, I'm going to mark this closed. Thanks @chjj!

That sounds perfectly acceptable! Thank you for the work you put in to
fixing this! =D
On Wed, Mar 18, 2015 at 9:05 AM, Dan Kaplun<EMAIL_ADDRESS>wrote:

If nobody else has issues, I'm going to mark this closed. Thanks @chjj
https://github.com/chjj!
—
Reply to this email directly or view it on GitHub
https://github.com/slap-editor/slap/issues/74#issuecomment-82962025.

The latest seems to work already on my setup. :+1:


Quality for JPEG not work

Hello.
                Sharp('dog.jpg')
                    .resize({width: 500, withoutEnlargement: true})
                    .jpeg({quality: 10, progressive: true})
                    .webp({quality: 50, lossless: true})
                    .png({quality: 50, compressionLevel: 8})
                    .toFile(path.join(filepath, fieldname, size, filename),
                        function (err) {
                            console.log(err);
                        });

Original: 44 KB

Quality 10%: 270 KB

How to compress JPEG image?

Hello, the output you've posted here is PNG rather than JPEG, hence the larger size. PNG is lossless and does not have a quality setting.
Did you see the force option on the jpeg(), webp() and png() functions? You'll probably want to set it to force: false for all three if you're specifying all three.

@lovell Thank you very much.
                Sharp('dog.jpg')
                    .resize({width: 500, withoutEnlargement: true})
                    .jpeg({quality: 10, progressive: true, force: false})
                    .webp({quality: 50, lossless: true, force: false})
                    .png({quality: 50, compressionLevel: 8, force: false})
                    .toFile(path.join(filepath, fieldname, size, filename),
                        function (err) {
                            console.log(err);
                        });

Quality 10%: 18 KB


Feature Request: Battery Percentage as a Separate Tile

I would like to start by saying this plugin has been working great for me and has made life a lot more convenient. Thank you for maintaining this plugin!!
I mentioned this new feature in #31: would it be possible to show the battery percentage as a separate tile? I haven't looked into how these plugins are written myself yet, but I use a few other Homebridge plugins that are able to show things like temperature and battery percentage as a separate tile that have no interaction. It's just easier to see at a glance vs. having to view the "settings" for the Roomba tile.

@joshuaseltzer could you link a plugin that shows a battery indicator that you like? I'll duplicate their approach (specifically which service and characteristics they used

@karlvr the only one I know of that does something similar is the official support with Ecobee, which has a tile for temperature. So honestly I’m not even quite sure if it’s possible.

@joshuaseltzer it seems that the approach is to choose a thing HomeKit knows about, like a temperature sensor or a contact switch, and to repurpose that to show the info you want to show.
I'm not familiar with what the different types of controls look like, so I'm always interested in what other Homebridge plugins have done to render something similar.

@joshuaseltzer I've experimented a little bit... I haven't been able to work out what sort of thing to add. We currently expose battery level, but of course HomeKit only exposes it if the value is low. I've experimented with exposing the value as a lightbulb with a brightness... but it means HomeKit thinks there's a light, which causes it to display odd stuff and behave weirdly when you ask it to mess with lights.
So I don't think I can easily progress this. If you can find some screenshots of another HomeKit plugin doing something similar, please post them and reopen this issue.

@karlvr thanks for looking into it. I guess the more I thought about it, yeah it wouldn't quite make so much sense as a separate tile, especially if HomeKit doesn't already have something like that. I figured maybe we could reuse the "temperature" tiles for something like battery, but that seems like more of a hack than anything.
Thanks again for at least considering it!

@joshuaseltzer yeah, I'm pretty new to the Homebridge world, and it does seem that some plugins do manage to hack together a reuse of different services… I use the Tesla Powerwall plugin and it represents the flow of power as fans! Our own contact sensors are a hack!
If we add a temperature sensor then you're going to see a temperature reported in your room that's going to be weird :-/
I guess we live in hope for more generic reusable types from HomeKit.


RegEx patterns

Hello,
Great work on the plugin!
It would be cool if the URLs that are used for data collection could have their own custom RegEx patterns with them. This would then allow there to be more flexibility with where the data comes from so it doesn't need to conform to current constraints when /status is called.
Thanks!

Hi there, this is something that would certainly be possible, though it would likely have to be specific for the intended data source.
Unfortunately, I don't have the time or incentive to implement this myself. You are more than welcome to fork the plugin and attempt this yourself though!

@ixy05 hello, do you find a way ?


multiclock - Added localisation to digi.js and timedat.js

Hi there,
this is my first contribution, so I hope that I did not miss any requirements. If so, please tell me and I will fix my commit respectively.
I really like the multiclock timdat.js clock. However, it is not using the internationalisation mechanism. See also https://github.com/espruino/BangleApps/issues/136
Thus, I adapted the code - trying to change as few things as possible. I also adapted digi.js, which was quite simple. I did not touch txt.js since IMO it is alright to have this as an English skin and it would require a major effort to be adapted for other languages.
One technical remark: In timdat.js, a special date format consisting of day of week, month and day of month is used that is not available as a date pattern. Hence, I decided to build it there. I used this code together with the locales variable from locales.js to generate the dayFirst and withDot arrays:
const dayFirst = [];
const withDot = [];
for (key in locales) {
    const datePattern = locales[key].datePattern[1];
    if (datePattern.includes('.')) {
        withDot.push(locales[key].lang);
    }
    if (datePattern.indexOf('%d') < datePattern.indexOf('%m')) {
        dayFirst.push(locales[key].lang);
    }
}
console.log(withDot);
console.log(dayFirst);

Another possibility would be to add a third datePattern in locales.js if this is something useful in other places as well.
Testing: I've run the sanity check and tested the clock faces with no locale (default en_GB), de_DE and fr_FR.
Kind regards,
neshanjo

This looks great - thank you!


Lingering Python2 reference in linux-setup.sh

if [[ -x "`which python`" ]]
then
 	python -V >/dev/null 2>&1 && ${SUDO}python "${BNPATH}/scripts/install_api.py" ${ROOT} ${SILENT}
fi

Because this snippet is still executed, it causes an error when core_version() is called in install_api.py. Recommend removing snippet.
There error I get is:
Traceback (most recent call last):
  File "/home/user/Downloads/binaryninja/scripts/install_api.py", line 68, in <module>
    while not validate_path(api_path):
  File "/home/user/Downloads/binaryninja/scripts/install_api.py", line 60, in validate_path
    print("Found Binary Ninja core version: {}".format(core_version()))
TypeError: 'str' object is not callable

Thanks. Removed whenever the next dev build comes out. (Not going to trigger a new build since you can just grab it directly if you need it: https://github.com/Vector35/binaryninja-api/blob/dev/scripts/linux-setup.sh )

Thanks. Removed whenever the next dev build comes out. (Not going to trigger a new build since you can just grab it directly if you need it: https://github.com/Vector35/binaryninja-api/blob/dev/scripts/linux-setup.sh )

hi,i meet the same error on windows,how should i do

Just manually create a PTH file that points to your install location. That's essentially all this script does.
https://stackoverflow.com/a/700394

Also to be clear, you shouldn't be running the linux setup on windows. I assume you meant you got that error running the install api script which is what my answer above is about.


added fishing poles and a lure

fixes #18

tbh I'm not sure about the spell id of the glow worm. I don't have a glow worm right now to doublecheck if that's working


Tensorflow 2.1 BERt embeddings - Variable is unhashable if Tensor equality is enabled. Instead, use tensor.experimental_ref() as the key

I'm trying to load the following BERt presaved model from tensorflow hub. As per the previously mentioned page, this is the code that I'm trying to execute
max_seq_length = 128  # Your choice here.
input_word_ids = tf.keras.layers.Input(shape=(max_seq_length,), dtype=tf.int32,
                                       name="input_word_ids")
input_mask = tf.keras.layers.Input(shape=(max_seq_length,), dtype=tf.int32,
                                   name="input_mask")
segment_ids = tf.keras.layers.Input(shape=(max_seq_length,), dtype=tf.int32,
                                    name="segment_ids")
bert_layer = hub.KerasLayer("https://tfhub.dev/tensorflow/bert_multi_cased_L-12_H-768_A-12/1",
                            trainable=True)
pooled_output, sequence_output = bert_layer([input_word_ids, input_mask, segment_ids])

However, as soon as I get to execute the hub.KerasLayer, I'm getting the following exception.
In [10]: bert_layer = hub.KerasLayer("https://tfhub.dev/tensorflow/bert_multi_cased_L-12_H-768_A-12/1",
    ...:                             trainable=True)

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-10-f1fd8e265590> in <module>
      1 bert_layer = hub.KerasLayer("https://tfhub.dev/tensorflow/bert_multi_cased_L-12_H-768_A-12/1",
----> 2                             trainable=True)

~/anaconda3/lib/python3.7/site-packages/tensorflow_hub/keras_layer.py in __init__(self, handle, trainable, arguments, **kwargs)
    111       for v in self._func.trainable_variables:
    112         self._add_existing_weight(v, trainable=True)
--> 113       trainable_variables = set(self._func.trainable_variables)
    114     else:
    115       trainable_variables = set()

~/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/ops/variables.py in __hash__(self)
   1087   def __hash__(self):
   1088     if ops.Tensor._USE_EQUALITY and ops.executing_eagerly_outside_functions():  # pylint: disable=protected-access
-> 1089       raise TypeError("Variable is unhashable if Tensor equality is enabled. "
   1090                       "Instead, use tensor.experimental_ref() as the key.")
   1091     else:

TypeError: Variable is unhashable if Tensor equality is enabled. Instead, use tensor.experimental_ref() as the key.

What am I missing? I'm running all of the above on macOS 10.15 and TF 2.1

The above code runs without any problem on a Win 10 machine

@TheGlobalist
I have tried on colab with TF version 2.1.0 and I am not seeing any error message. Please, find the gist here.Thanks!

@TheGlobalist
I have tried on colab with TF version 2.1.0 and I am not seeing any error message. Please, find the gist here.Thanks!

I'll try this in the evening as I don't have the macOS machine with me now. Thank you! 👍

@TheGlobalist
I have tried on colab with TF version 2.1.0 and I am not seeing any error message. Please, find the gist here.Thanks!

I confirm that this on my local macOS machine doesn't work and gives the above error

Also: if I downgrade to 1.x, the error doesn't happen

@TheGlobalist I am not running into any error if I am running the code in colab. I am using hub 0.7 and Tensorflow 2.1

@TheGlobalist I am not running into any error if I am running the code in colab. I am using hub 0.7 and Tensorflow 2.1

Sorry, maybe I'm missing the point... shouldn't TF be able to run everywhere?
If so, why are we talking about Colab if I'm asking for macOS?

Can you try it with tensorflow 2.2.0rc1 and let me know if the issue still persists. I tried to reproduce it on ubuntu 18.04 and am not running into any error.

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

Closing this issue as it has been inactive for more than 2 weeks. Please add additional comments for us to open this issue again. Thanks!


Strip utm parameters from url after hit has been recorded

Will help to avoid problems with people sharing incorrectly sourced content.

Closing this for now - better done through the GA snippet itself: https://gist.github.com/awavering/0fe0b170b0c449809c3a


Get aerosol optical depth from NASA climatology

Get optical thickness monthly averages (for 1x1 degree grid boxes) from here: https://gacp.giss.nasa.gov/datasets/ and populate for the given day (actual data files here: https://gacp.giss.nasa.gov/data/time_ser/)

@atillmanns The NASA data has average monthly aerosol optical depth (tau) values per year from 1981 to 2009. I assume most of the time we will be calculating WQG for a date more recent than that, so do you think I should calculate monthly average aerosol values across all years, and then for a WQG calculation, we would be using an average aerosol value for that month at the given latitude and longitude?

The historical data from the gacp site seems to have poor coverage over land??
(white areas are missing data)
url <- "https://gacp.giss.nasa.gov/data/time_ser/0907.tau.ascii.gz"

temp_file <- tempfile(fileext = ".ascii.gz")

download.file(url, destfile = temp_file)

f <- gzfile(temp_file)

d <- as.matrix(read.delim(f, sep = "", header = FALSE, skip = 1))

# NA are encoded as -1
d[d < 0] <- NA

image(t(apply(d, 2, rev)))

Created on 2023-11-22 with reprex v2.0.2

 PAH sensitivity meeting

Reopening as the functionality is implemented via #4, but we need to resolve the data source

Is it possible to tell if the data from the NASA/Aeronet site https://aeronet.gsfc.nasa.gov/new_web/data.html has good coverage over Canada and the coastline?  If so, then yes, use this data source.  And monthly averages make sense.

Ok, thanks. I'll investigate the coverage. Do you think using monthly averages over a certain number of years makes sense? Or is it better to get a point-in-time value from the daily measurements? If the latter, there is an API I can query to get point-in-time values, I think.


Support HOTP

Hi,
Thanks for making this!
Is there any chance of adding HOTP support in addition to TOTP?
Cheers

I don't plan to add it. If someone wants to submit a PR it will be considered.


Choose step type colour

It would be neat to have a way to choose your own custom colours for step types.
It could be added to the generator-settings file.
The GUI part could be done similar to the change shortcuts.
The immediate goal for me is to colour Walk & Mine. As these are just white, however i often use them as control steps.

It would be nice if the user was able to customize what they see as being important - I think this would be a valuable addition to the tool. 👍

I'll implement something similar to the shortcut changer.


Cut off response at EOT token

Cut off the response at <|endoftext|>, as whatever is after is totally unrelated to the prompt

should be fixed

thanks!


POST Request

Vulcansql is the best in terms of backend as a frontend engineer I really like but it is missing some of the important methods requests such as POST request which will bring more power to anyone who is not familiar with backend skills as you stated in your previous tweets

@Revaycolizer, thank you for the feedback! As the Data API framework, our goal is to assist data professionals in building queries solely with SQL and delivering data within seconds. We have recently received feature requests similar to yours.
If anyone else thinks it's a critical feature to support. Please upvote this issue to let VulcanSQL Team know the priority.


DX: Be able to restart the front-end development server also provide better visible output (Awaiting support in Aspire)

This issue creates friction for front-end developers, if for some reason the front-end build fails you need to enter the Aspire dashboard and look at the console log - instead of reading the issue in the IDE.
If there's an issue requiring a restart of the front-end build the whole Aspire/proxy etc. needs to be restarted - atm. this is super slow.

Can no longer be commented out as YARP now acts as the CDN


Add 'Learn PowerShell in Y Minutes'

What does this PR do?
Add Resource(s)
For resources
Description
This adds the cheat-sheet styled 'Learn X in Y Minutes' for PowerShell.
Why is this valuable (or not)
It's simple to read, and can help people pick up PowerShell quickly, but also allows people to easily reference back to key concepts and syntax.
How do we know it's really free?
Open source and licensed under CC BY-SA 3.0
For book lists, is it a book?
Checklist:

[x] Not a duplicate
[x] Included author(s) if appropriate
[x] Lists are in alphabetical order
[x] Needed indications added (PDF, access notes, under construction)

Thanks!


stable/nginx-ingress 0.8.1

Is this a request for help?:

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG
Version of Helm and Kubernetes:
platform:GKE
kubernetes: 1.7.3
helm: 2.5.1
Which chart:
name: nginx-ingress
version: 0.8.1
appVersion: 0.9.0-beta.11
What happened:
Installed nginx controller with helm chart from git.
Then created an ingress of class:nginx and got a IP for this ingress when tried to hit this IP I get connection refused if I hit the LB IP of nginx controller it works.
What you expected to happen:
I should be able to hit the IP address of the ingress resource and be delivered to the service
How to reproduce it (as minimally and precisely as possible):
Create an ingress on GKE and try to hit the public IP assigned
Anything else we need to know:

well I was testing using the controller IP and that seemed to work but when using ssl it gets a wrong certificate a self signed one so not sure whats the problem here. Some pointer on how to debug this will be helpful.


Update satellite normalisation params

Pull Request
Description
How Has This Been Tested?

[ ] No
[x] Yes

Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings

in general, the changes feel like what we'd expect given that these new stats ignore nighttime:  Most means are higher and most STDs are lower.


How to configure the kind of a source

Hello. I read in the documentation that it is possible to set the kind of a source. However, I don't understand the vim-syntax how to do it. What is the command to set source-options? I tried
let g:compe.source.buffer.kind = "B"

but it doesn't work. Thank you.

It works fine in my config.
  let g:compe = {}
  let g:compe.enabled = v:true

  let g:compe.source = {}
  let g:compe.source.path = v:true
  let g:compe.source.calc = v:true
  let g:compe.source.buffer = {}
  let g:compe.source.buffer.kind = 'B'

I forgot let g:compe.source.buffer = {}. Thanks you.


feat: Update docs, example cleanup, add docs, release, format, security, validate

1- Update the README.md with:

A high level description of how this module works (not just what it deploys).
Usage is an HCL code snippet of the module block that would be implemented in another Terraform project.
A description and example of any unique configuration required to make this module work.
Re-order and update the Authors and License sections to be consistent with terraform-snowflake-rbac.

2- Add/update the following pipelines:

Add a docs pipeline to be consistent with terraform-snowflake-rbac and update README.md to specify which part of the document is populated via template.
Add a format pipeline to be consistent with terraform-snowflake-rbac.
Add a security pipeline to be consistent with terraform-snowflake-rbac.
Add a validate pipeline to be consistent with terraform-snowflake-rbac.
Update the release pipeline to be consistent with terraform-snowflake-rbac. Be sure to add the .releaserc.json configuration file to the root of the module.

3- Add a CODEOWNERS file to the repository to be consistent with terraform-snowflake-rbac.
4- Update the dependabot.yml configuration file to be consistent with terraform-snowflake-rbac.

This PR is included in version 1.0.0 :tada:


I can do !money and mention a bot

This must not happen
In this cases must show us a message like
"Els bots no tenen monedes! Pobres bots... :("

Fixed in 5572a8869367227ab2c4bfee7154de8b0d266b15


feature: documentation and static code analysis

📲 What
Getting sonarcloud working, and updating the documentation.
🤔 Why
We hadn't configured sonarcloud and jest properly.
🛠 How
More in-depth discussion of the change or implementation.
👀 Evidence

🕵 How to test
Run in the pipeline, will fail due to not meeting the required code coverage.
✅ Acceptance criteria Checklist

[ ] Code peer reviewed?
[x] Documentation has been updated to reflect the changes?
[x] Passing all automated tests, including a successful deployment?
[x] Passing any exploratory testing?
[x] Rebased/merged with latest changes from development and re-tested?
[x] Meeting the Coding Standards?

please remove all binary files

Done. See https://github.com/amido/stacks-webapp-template/blob/981ea66ce2c80282435eaa703f9553b34fd2f6aa/docs/assets/README.md


how to smoothly swipe cards programmatically?

hello, i'm trying to swipe cards programmatically, when i call swipeTopViewToLeft method in a for-loop, my app don't swipe smoothly. i think it is because i call swipeTopViewToLeft method in a very short time, the previous card doesn't finish its animation. so, how can i implement the "swipe programmatically" effect like the gif you post in introduction.
really appreciate your reply.

I was pressing the button manually when I made the GIF recording. To achieve the same effect programmatically, you may want to use NSTimer to schedule swipe animations at consecutive time intervals.


launch command fix

That used to be what was their but too many people block insecure connections and why we changed it to have the https:// prefix. Cuts down on issues.


adding FAQ

added JSON, JOIN, and bulk insert FAQ
@knz – Could I get you to take a quick look at the mentions I made of JOIN here? I wasn't sure if we could remove it as a limitation or not.
@paperstreet – Could I get you to review the JSON/bulk insert mentions? Feel free to loop in anyone else who ought to review.

This change is

A few minor comments. LGTM otherwise.

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

frequently-asked-questions.md, line 149 [r1] (raw file):

## How do I bulk insert data into CockroachDB?

Right now, the best way to bulk insert data is to run [`INSERT`](insert.html) statements in batches of 1,000.

... of hundreds of rows at a time, so that the total payload per INSERT becomes larger than a few kilobytes. However you should still avoid INSERTS of more than a couple megabytes a time.

frequently-asked-questions.md, line 155 [r1] (raw file):

CockroachDB has basic, non-optimized support for SQL `JOIN`, whose performance we're working to improve.

To learn more, see our blog post [CockroachDB's JOIN](https://www.cockroachlabs.com/blog/cockroachdbs-first-join/).

perhaps "our blog post on CockroachDB's JOIN"

Comments from Reviewable

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

Thanks! Sorry for randomizing you with this

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

frequently-asked-questions.md, line 149 [r1] (raw file):
Previously, knz (kena) wrote…
> ... of hundreds of rows at a time, so that the total payload per INSERT becomes larger than a few kilobytes. However you should still avoid INSERTS of more than a couple megabytes a time.

Hard to calculate the size of the rows; did a quick back-of-the-envelope calculation with @paperstreet and figured that 1,000 - 10,000 rows covers most people with a caveat that it depends on the size of the rows. Think that makes a simple recommendation will still making sure we're addressing the concern about size.

frequently-asked-questions.md, line 155 [r1] (raw file):
Previously, knz (kena) wrote…
> perhaps "our blog post *on* CockroachDB's JOIN"

Done.

Comments from Reviewable

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

frequently-asked-questions.md, line 149 [r1] (raw file):
Previously, sploiselle (Sean Loiselle) wrote…
> Hard to calculate the size of the rows; did a quick back-of-the-envelope calculation with @paperstreet and figured that 1,000 - 10,000 rows covers most people with a caveat that it depends on the size of the rows. Think that makes a simple recommendation will still making sure we're addressing the concern about size.

Then add a footnote / remark saying exactly that! "1,000 - 10,000 rows covers most people with a caveat that it depends on the size of the rows."

Comments from Reviewable

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

frequently-asked-questions.md, line 149 [r1] (raw file):
Previously, knz (kena) wrote…
> Then add a footnote / remark saying exactly that! "1,000 - 10,000 rows covers most people with a caveat that it depends on the size of the rows."

Done.

Comments from Reviewable

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Add ability to get the content of a quote

The endpoint /v3/omis/order/<order-id>/quote now accepts full=1 to indicate that the response body has to include the content of the quote as well.
By default we want to return a lighter version.

Codecov Report

Merging #437 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #437      +/-   ##
===========================================
+ Coverage    95.87%   95.89%   +0.01%
===========================================
  Files           94       94
  Lines         3057     3068      +11
  Branches       270      271       +1
===========================================
+ Hits          2931     2942      +11
  Misses          86       86
  Partials        40       40

Impacted Files
Coverage Δ

datahub/omis/quote/serializers.py
100% <100%> (ø)
:arrow_up:

datahub/omis/quote/views.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f112e6...7ad8342. Read the comment docs.

full=1 url feels a bit hacky. Would something like expand that accept boolean be better?

@reupen @elcct thanks for the feedback, all good. That was just me being lazy!
Replaced the param name and started using a serializer now :)


Users falling off the screen in the shapeshifter menu

Hello.
Try with this build

This patch shows the wrong number of pages on the vote

This small issue should be fixed

In this patch, everything was fixed, no errors were found

@RobinRMC

I haven't had the time to test anything, and I still don't. I trust @Tommy-XL and hope it is fixed.

I think the question can be closed, because I decided to check for 126 Dummy and as a result did not notice any bugs


Please add mdcrd (edam:format_3878) format as compatible input in cpptraj building blocks

Done! It will be available in the next release.


problem with vim setup.py

I am having a problem when I use the command vim setup.py. It says:

The program 'vim' can be found in the following packages:

vim
vim-gnome
vim-tiny
vim-athena
vim-athena-py2
vim-gnome-py2
vim-gtk
vim-gtk-py2
vim-gtk3
vim-gtk3-py2
vim-nox
vim-nox-py2
Try: sudo apt install

And when I use python setup.py, it says:

usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
or: setup.py --help [cmd1 cmd2 ...]
or: setup.py --help-commands
or: setup.py cmd --help
error: no commands supplied

How can I run the setup.py file?

@hadi-ghnd This just wants you to edit the "setup.py" file. Choose the editor that you like.

You should run
sudo apt-get install vim

It's not necessary to run python setup.py, just 'make'.  You can refer to Makeflie.

DO YOU fix it? @hadi-ghnd , I have the same problem. The WINDOW


Hi, I don't know how to do it. Can you tell me

importError:No module named object_detection.utils

https://github.com/tensorflow/models
Maybe you not install this.

hi，where is the model config file?

Please check this link
https://github.com/tensorflow/models/tree/master/research/object_detection/samples/configs
On Sun, Oct 15, 2017 at 1:29 PM, by.sun<EMAIL_ADDRESS>wrote:

hi，where is the model config file?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/priya-dwivedi/Deep-Learning/issues/1#issuecomment-336693495,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUHGOAcstoZZAmXgcZdcOdZ1hw3Y0fuJks5ssbtxgaJpZM4OZt2w
.

Thanks . I know the default config files,but I am not sure what prefer params to config.And when I transfer any ckpt to pb file it always raise error 'FailedPreconditionError: Attempting to use uninitialized value FirstStageFeatureExtractor...' ,I don‘t know why?The training process can finish automatically or must be stopped manually?I must use the last ckpt file?

You can start training with default params and adjust based on performance.
As for the error, no idea. Please post on stackoverflow.
On Mon, Oct 16, 2017 at 12:07 PM, by.sun<EMAIL_ADDRESS>wrote:

Thanks . I know the default config files,but I am not sure what prefer
params to config.And when I transfer any ckpt to pb file it always raise
error 'FailedPreconditionError: Attempting to use uninitialized value
FirstStageFeatureExtractor...' ,I don‘t know why?The training process can
finish automatically or must be stopped manually?I must use the last ckpt
file?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/priya-dwivedi/Deep-Learning/issues/1#issuecomment-336793508,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUHGODsAiVUn_VWOfnJIETI_mvFKDrhSks5ssvm2gaJpZM4OZt2w
.

Thanks a lot～

hello，I have some questions about Mask_RCNN_Videos.ipynb .
InvalidArgumentError: NodeDef mentions attr 'identical_element_shapes' not in Op<name=TensorArrayV3; signature=size:int32 -> handle:resource, flow:float; attr=dtype:type; attr=element_shape:shape,default=; attr=dynamic_size:bool,default=false; attr=clear_after_read:bool,default=true; attr=tensor_array_name:string,default=""; is_stateful=true>; NodeDef: Preprocessor/map/TensorArray = TensorArrayV3clear_after_read=true, dtype=DT_FLOAT, dynamic_size=false, element_shape=, identical_element_shapes=true, tensor_array_name="", _device="/job:localhost/replica:0/task:0/device:CPU:0". (Check whether your GraphDef-interpreting binary is up to date with your GraphDef-generating binary.).
[[Node: Preprocessor/map/TensorArray = TensorArrayV3clear_after_read=true, dtype=DT_FLOAT, dynamic_size=false, element_shape=, identical_element_shapes=true, tensor_array_name="", _device="/job:localhost/replica:0/task:0/device:CPU:0"]]
Caused by op 'Preprocessor/map/TensorArray', defined at:
File "D:\anaconda\lib\runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "D:\anaconda\lib\runpy.py", line 85, in _run_code
exec(code, run_globals)
File "D:\anaconda\lib\site-packages\ipykernel_launcher.py", line 16, in
app.launch_new_instance()
File "D:\anaconda\lib\site-packages\traitlets\config\application.py", line 658, in launch_instance
app.start()
File "D:\anaconda\lib\site-packages\ipykernel\kernelapp.py", line 477, in start
ioloop.IOLoop.instance().start()
File "D:\anaconda\lib\site-packages\zmq\eventloop\ioloop.py", line 177, in start
super(ZMQIOLoop, self).start()
File "D:\anaconda\lib\site-packages\tornado\ioloop.py", line 888, in start
handler_func(fd_obj, events)
File "D:\anaconda\lib\site-packages\tornado\stack_context.py", line 277, in null_wrapper
return fn(*args, **kwargs)
File "D:\anaconda\lib\site-packages\zmq\eventloop\zmqstream.py", line 440, in _handle_events
self._handle_recv()
File "D:\anaconda\lib\site-packages\zmq\eventloop\zmqstream.py", line 472, in _handle_recv
self._run_callback(callback, msg)
File "D:\anaconda\lib\site-packages\zmq\eventloop\zmqstream.py", line 414, in _run_callback
callback(*args, **kwargs)
File "D:\anaconda\lib\site-packages\tornado\stack_context.py", line 277, in null_wrapper
return fn(*args, **kwargs)
File "D:\anaconda\lib\site-packages\ipykernel\kernelbase.py", line 283, in dispatcher
return self.dispatch_shell(stream, msg)
File "D:\anaconda\lib\site-packages\ipykernel\kernelbase.py", line 235, in dispatch_shell
handler(stream, idents, msg)
File "D:\anaconda\lib\site-packages\ipykernel\kernelbase.py", line 399, in execute_request
user_expressions, allow_stdin)
File "D:\anaconda\lib\site-packages\ipykernel\ipkernel.py", line 196, in do_execute
res = shell.run_cell(code, store_history=store_history, silent=silent)
File "D:\anaconda\lib\site-packages\ipykernel\zmqshell.py", line 533, in run_cell
return super(ZMQInteractiveShell, self).run_cell(*args, **kwargs)
File "D:\anaconda\lib\site-packages\IPython\core\interactiveshell.py", line 2717, in run_cell
interactivity=interactivity, compiler=compiler, result=result)
File "D:\anaconda\lib\site-packages\IPython\core\interactiveshell.py", line 2821, in run_ast_nodes
if self.run_code(code, result):
File "D:\anaconda\lib\site-packages\IPython\core\interactiveshell.py", line 2881, in run_code
exec(code_obj, self.user_global_ns, self.user_ns)
File "", line 7, in
tf.import_graph_def(od_graph_def, name='')
File "D:\anaconda\lib\site-packages\tensorflow\python\framework\importer.py", line 313, in import_graph_def
op_def=op_def)
File "D:\anaconda\lib\site-packages\tensorflow\python\framework\ops.py", line 2956, in create_op
op_def=op_def)
File "D:\anaconda\lib\site-packages\tensorflow\python\framework\ops.py", line 1470, in init
self._traceback = self._graph._extract_stack()  # pylint: disable=protected-access
InvalidArgumentError (see above for traceback): NodeDef mentions attr 'identical_element_shapes' not in Op<name=TensorArrayV3; signature=size:int32 -> handle:resource, flow:float; attr=dtype:type; attr=element_shape:shape,default=; attr=dynamic_size:bool,default=false; attr=clear_after_read:bool,default=true; attr=tensor_array_name:string,default=""; is_stateful=true>; NodeDef: Preprocessor/map/TensorArray = TensorArrayV3clear_after_read=true, dtype=DT_FLOAT, dynamic_size=false, element_shape=, identical_element_shapes=true, tensor_array_name="", _device="/job:localhost/replica:0/task:0/device:CPU:0". (Check whether your GraphDef-interpreting binary is up to date with your GraphDef-generating binary.).
[[Node: Preprocessor/map/TensorArray = TensorArrayV3clear_after_read=true, dtype=DT_FLOAT, dynamic_size=false, element_shape=, identical_element_shapes=true, tensor_array_name="", _device="/job:localhost/replica:0/task:0/device:CPU:0"]]

please ensure tensorflow version is 1.5. That’s the one I used.
Sent from my iPhone

On Apr 21, 2018, at 4:24 AM, Wei Chen<EMAIL_ADDRESS>wrote:
download https://github.com/tensorflow/models . and copy to the directory of MarkRCNN?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

sorry, I didn't notice the comment "# This is needed since the notebook is stored in the object_detection folder."....


add invitations template functions

adds standard invitation contents and functions to create invitations from templates

I'm not sure what are you trying to do this. We will discuss it later.

@melisabok  can we merge this?

sorry, found a bug, fixing now
(we can talk later about this)

@melisabok ok, I removed the exclusions. I think you're right that they're unnecessary. We can add them back in if they later seem to be needed


Update Add-AppxPackage.md

Docs Build status updates of commit 4999e41:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2022-ps/appx/Add-AppxPackage.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit cd0db84:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2022-ps/appx/Add-AppxPackage.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 345460b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2022-ps/appx/Add-AppxPackage.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Let users to select Image Quality

You can add a drop down at forms to let user select output Image Quality.
You can take a look at here for different Image Quality Possibilities.
https://code.google.com/p/thumbnailator/wiki/Comparison

@keciciler I would include all possible methods for scalr and the thumbnailatr. I hope that's enough ;)


What's the next move?

Im not sure what I'm supposed to do after the read me file. ```

You're suppose to do what comes next. 1st it's step One, then usually almost always comes, step two.


iconv_set_encoding deprecated in PHP 5.6.0

Since PHP 5.6.0, iconv_set_encoding() is deprecated in favour of default_charset.
http://php.net/manual/en/migration56.deprecated.php

Withdrawn.  I will propose another solution.