Support conjugates for scalar functions (with early termination) (WIP)

Instructions:

The PR has to be tagged with at least one of the following labels (*):

feature
bugfix
performance
ui
backward-incompat
release-notes (**)

Remove these instructions before publishing the PR.

(*) Other labels to consider:

testing
dependencies
docker
kubernetes
observability
security
code-style
extension-point
refactor
cleanup

(**) Use release-notes label for scenarios like:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

GH issue: https://github.com/apache/pinot/issues/8488

Codecov Report

Merging #8582 (500717e) into master (f200ec5) will decrease coverage by 44.98%.
The diff coverage is 0.00%.

:exclamation: Current head 500717e differs from pull request most recent head 4d85ce8. Consider uploading reports for the commit 4d85ce8 to get more accurate results

@@              Coverage Diff              @@
##             master    #8582       +/-   ##
=============================================
- Coverage     70.75%   25.76%   -44.99%
=============================================
  Files          1691     1679       -12
  Lines         88606    88287      -319
  Branches      13437    13411       -26
=============================================
- Hits          62690    22750    -39940
- Misses        21534    63355    +41821
+ Partials       4382     2182     -2200

Flag
Coverage Δ

integration1
?

integration2
25.76% <0.00%> (-0.05%)
:arrow_down:

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ot/common/function/scalar/ComparisonFunctions.java
0.00% <0.00%> (ø)

...inot/common/request/context/ExpressionContext.java
85.71% <ø> (-2.86%)
:arrow_down:

...inot/controller/helix/ControllerRequestClient.java
49.00% <0.00%> (-14.00%)
:arrow_down:

...gment/local/function/InbuiltFunctionEvaluator.java
0.00% <0.00%> (-78.88%)
:arrow_down:

...in/java/org/apache/pinot/spi/utils/StringUtil.java
0.00% <ø> (-100.00%)
:arrow_down:

...spi/utils/builder/ControllerRequestURLBuilder.java
0.00% <0.00%> (ø)

.../java/org/apache/pinot/spi/utils/BooleanUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/spi/trace/BaseRecording.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/spi/trace/NoOpRecording.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 1244 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f200ec5...4d85ce8. Read the comment docs.


Change the verb menu to open on hover

From the 25 June 2022 maintainer meeting notes

fixed by #13318


Offers: send invoice request

This PR adds the step of the offers flow where we send the invoice request to the offer creator.
This relies on the addition of this offers RPC call to our ldk-sample fork, if anyone would like to take a look: https://github.com/lndk-org/ldk-sample/pull/6
I left a couple of high level questions inline as well.

Oi, now that I'm working on waiting for the invoice to be returned... I think I coded things a bit backwards here. Feel free to hold off on review while I rethink and rework this a bit. :)


Adds awesome-lua to "other lists"

Really nice looking list! More detail on Love2d was definitely a missing piece of awesome-lua. I added a link from awesome-lua to here: https://github.com/LewisJEllis/awesome-lua#game-development and https://github.com/LewisJEllis/awesome-lua#other-lists

Nice! Thanks


Regexp in cookie store read method returns blank value

Method is https://github.com/simplabs/ember-simple-auth/blob/master/packages/ember-simple-auth-cookie-store/lib/simple-auth-cookie-store/stores/cookie.js#L153
  read: function() {
    var value = document.cookie.match(new RegExp(this.cookieName + name + '=([^;]+)')) || [];
    return decodeURIComponent(value[1] || '');
  },

For me, name in read method returns value 37286, and regular expression is /ember_simple_auth:session37286=([^;]+)/ but my document.cookie don't contain this value and match returns blank
  ember_simple_auth:session=%7B%22authenticator%22%3A%22authenticator%3Acustom%22%2C%22

If I'm removing name from match everything works fine
  read: function() {
    var value = document.cookie.match(new RegExp(this.cookieName + '=([^;]+)')) || [];
    return decodeURIComponent(value[1] || '');
  },

Is this bug, or something wrong in my configurations?

Yes, this was a bug - no idea where that name var came from.


[TW#26167] Class of device not set in inquiry scan

Environment

Development Kit:      [none]
Kit version (for WroverKit/PicoKit/DevKitC): [-]
Core (if using chip or module): [ESP32]
IDF version (git rev-parse --short HEAD to get the commit id.):
//d91c425178d4e37b72178c231b5cc50b7ab157e2
Development Env:		[other]
Operating System:		[Windows]
Power Supply:         [external 3.3V]

Problem Description
Class of device is set on device using HCI-command. Success returned as result. When device shows up in inquiry scan, all fields (mac, name, rssi etc) seems correct, but not the cod - class of device value. It seems not change whatever value is set.
Expected Behavior
Value that was set with esp_bt_gap_set_cod should be published on inquiry scan result for device
Actual Behavior
Codvalue is not set. Does not seem to be changed by esp_bt_gap_set_cod, whatever value is set.
Cod shown 0x14042C
Steps to reproduce

use example btt_spp_acceptor
call esp_bt_gap_set_cod(codevalue, esp_set_cod_type)
run inquiry scan on other device to read out the cod. invalid value is shown - not the value that was set.

Hi @mekm , There are some precautions as follow:

Should call esp_bt_gap_set_cod() before esp_bt_gap_set_scan_mode()
Pay attention to esp_bt_cod_mode_t, refer to the comments in esp_gap_bt_api.h

Please check and test again, thanks.


Suggested Clarification

I'm not certain I'm thinking the right way about the relationship between a layout and the component(s) that are related with it.  As I understand it, this "relationship" can be made via the Default Layout routing, the _imports.razor Centralized Layout selection, or an explicitly Specified selection within the component(s).  This reads to me as though a (related) component "uses a layout" to provide surrounding markup that is always rendered when the related component is rendered, with the specific point of integration being determined by the layout's @Body reference.  If that's right, then saying something along those lines near the start of the article would help in my view..
Assuming this is a reasonable way to think about the relationship, then explaining how the Default Layout and MainLayout get connected with the main page (@page "/") would be helpful.  Does the main page (which is a component) become related to the MainLayout via the Default Layout routing?  If so, I think it would help to say something like that.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d64b8062-f910-a918-c5db-b2b67708602c
Version Independent ID: 56c6cc6e-be94-d164-947c-cb14dbe91a19
Content: ASP.NET Core Blazor layouts
Content Source: aspnetcore/blazor/layouts.md
Product: aspnet-core
Technology: aspnetcore-blazor
GitHub Login: @guardrex
Microsoft Alias: riande

Thanks @CincySteve for this feedback ... I'll take a look at this, but it won't be addressed until 2021. I'm swamped with work 🏃😅 for the next couple of weeks and then out for an extended holiday vacation. I'll return in January to take a look.

Hello @CincySteve ... I'm back from vacation now.

Default Layout routing, the _imports.razor Centralized Layout selection, or an explicitly Specified selection within the component(s)

The guidance on these aspects is here:

The Default layout section shows how to supply the layout in App.razor.
Specifying the layout in the component is covered in the next section, Specify a layout in a component.
Centralizing layouts via _Imports.razor files is in the section after that, Centralized layout selection.

Therefore, I don't see how we're lacking coverage or have poor organization. I don't think introductory remarks are required because the opening comments and example are short and thus quick to consume.
However, there will be work on this topic as part of UE (user experience) updates, so I'll take another look when I circle back around to this. One of the things that I'm focusing on for these UE passes is how each topic structures its content ... ordering of sections ... section titles ... internal cross-links ... etc. I'll take another look when I circle back around to this later. I'm also aware of another issue that was opened in engineering to cover some additional details on how nested components and layouts behave. I'll work that issue before I get to the UE pass, and that update might require introductory remarks along the lines of what you're suggesting here.

This reads to me as though a (related) component "uses a layout" to provide surrounding markup that is always rendered when the related component is rendered, with the specific point of integration being determined by the layout's @Body reference.

I might work a bit more on this aspect when I reach this for the UE pass, but I don't think that there's much difference between what you said and what the topic covers. The topic just happens to use common examples of where reducing boilerplate code would be beneficial to make the same point.

... explaining how the Default Layout and MainLayout get connected with the main page (@page "/") would be helpful. Does the main page (which is a component) become related to the MainLayout via the Default Layout routing? If so, I think it would help to say something like that.

I might be touching this on https://github.com/dotnet/AspNetCore.Docs/issues/21126, where nesting seems to have led to confusion. I'll address this on that issue because the engineering issue (IIRC) speaks to a specific point of confusion about it.
Specifically WRT "the main page (which is a component) become related to the MainLayout via the Default Layout routing" ...
That's covered AFAICT via how the topic describes (and shows) the Router component in the App component. It says it and shows it with the example in the Default layout section.
Thanks for your feedback. I'll work on this topic and review your guidance again for possible updates on the two other issues that I mentioned.

Hello @CincySteve ... I'm back from vacation now.

Default Layout routing, the _imports.razor Centralized Layout selection, or an explicitly Specified selection within the component(s)

The guidance on these aspects is here:

The Default layout section shows how to supply the layout in App.razor.
Specifying the layout in the component is covered in the next section, Specify a layout in a component.
Centralizing layouts via _Imports.razor files is in the section after that, Centralized layout selection.

Therefore, I don't see how we're lacking coverage or have poor organization. I don't think introductory remarks are required because the opening comments and example are short and thus quick to consume.
However, there will be work on this topic as part of UE (user experience) updates, so I'll take another look when I circle back around to this. One of the things that I'm focusing on for these UE passes is how each topic structures its content ... ordering of sections ... section titles ... internal cross-links ... etc. I'll take another look when I circle back around to this later. I'm also aware of another issue that was opened in engineering to cover some additional details on how nested components and layouts behave. I'll work that issue before I get to the UE pass, and that update might require introductory remarks along the lines of what you're suggesting here.

This reads to me as though a (related) component "uses a layout" to provide surrounding markup that is always rendered when the related component is rendered, with the specific point of integration being determined by the layout's @Body reference.

I might work a bit more on this aspect when I reach this for the UE pass, but I don't think that there's much difference between what you said and what the topic covers. The topic just happens to use common examples of where reducing boilerplate code would be beneficial to make the same point.

... explaining how the Default Layout and MainLayout get connected with the main page (@page "/") would be helpful. Does the main page (which is a component) become related to the MainLayout via the Default Layout routing? If so, I think it would help to say something like that.

I might be touching this on https://github.com/dotnet/AspNetCore.Docs/issues/21126, where nesting seems to have led to confusion. I'll address this on that issue because the engineering issue (IIRC) speaks to a specific point of confusion about it.
Specifically WRT "the main page (which is a component) become related to the MainLayout via the Default Layout routing" ...
That's covered AFAICT via how the topic describes (and shows) the Router component in the App component. It says it and shows it with the example in the Default layout section.
Thanks for your feedback. I'll work on this topic and review your guidance again for possible updates on the two other issues that I mentioned.


Update cats-effect to 3.4.1

Updates org.typelevel:cats-effect from 3.3.14 to 3.4.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "cats-effect" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.typelevel", artifactId = "cats-effect" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Codecov Report
Base: 66.72% // Head: 68.29% // Increases project coverage by +1.57% :tada:

Coverage data is based on head (b4c9ee4) compared to base (8d4b3c2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
+ Coverage   66.72%   68.29%   +1.57%
==========================================
  Files          19       18       -1
  Lines         565      552      -13
  Branches       22       22
==========================================
  Hits          377      377
+ Misses        188      175      -13

Impacted Files
Coverage Δ

...io/github/vigoo/clipp/VersionSpecificParsers.scala

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Superseded by #358.


feature: import classes under cursor from tag files

Most of the plugins I've seen for adding imports aren't great. They either require a fair bit of project-specific configuration, or shell out to python for help.
Instead of that, let's implement this by leveraging tag files. universal-ctags is pretty powerful and works quite well with Java source files. It correctly picks out the names of classes and sets the kind field accordingly. We can use the taglist() builtin to find class names.
The tricky part is getting the full package path. Although we could probably get it from the filename field, this won't work in all cases. I think a better bet is to try and lookup the package statement in the file and build the package path ourselves. This will be quite difficult with nested classes, so we might have to leave that to a later date.
We might want to rename the plugin after this is implemented.

Implemented!


refactor!: improve library

This PR:

makes API functions' return values consistent (avoids suppressing errors thrown by execa or returning {})
cleans up the test/ folder
addresses workspace arg handling based on the package manager with corresponding tests
ensures error gets thrown when package manager auto-detection fails to find any
organises util functions into separate files in the utils/ directory
marks addDevDependency as deprecated (either we should provide equivalent removeDevDependency or might be better to delete it entirely) - open to opinions, but knowing this is as simple as addDependency(name, { dev: true }) makes me think if we should get rid of it in a major release
adds includeParentDirs option to detectPackageManager util function, which prevents from bubbling the search up if not set to true explicitly
resolves https://github.com/unjs/nypm/issues/53

@pi0, are segmentation faults when using corepack with npm on ubuntu worth reporting? Will revert to the initial workaround for now anyway.

LGTM

Thanks so much for the time put into this PR dear @DamianGlowala ❤
I have put a few refactors to keep the repo simplified and this mergeable.
There are really nice changes and i don't want to miss them but i couldn't do it without making a breaking change release and we lack proper changelog... therefore i ask you to please next times, consider smaller mergable PRs 🙏🏼


chore: update deps

Overview

PR Checklist

[x] I did below actions if need

I read the Contributing Guide
I added documents and tests.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.42%. Comparing base (7c2d6e8) to head (d566203).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1030   +/-   ##
=======================================
  Coverage   85.42%   85.42%
=======================================
  Files          45       45
  Lines         542      542
  Branches      117      117
=======================================
  Hits          463      463
  Misses         74       74
  Partials        5        5

Components
Coverage Δ

@suspensive/react
97.03% <ø> (ø)

@suspensive/react-query
76.08% <ø> (ø)

@suspensive/react-query-4
0.00% <ø> (ø)

@suspensive/react-query-5
0.00% <ø> (ø)

@suspensive/react-await
100.00% <ø> (ø)

@suspensive/react-image
80.39% <ø> (ø)


Improve examples

Why rms/output (old standard) and not share/results (current standard)?

Why rms/output (old standard) and not share/results (current standard)?

The input maps for dataio here comes from rms/output, just to have some place to grab them from since we don't have a RMS project. The output from dataio will be share/results


Update sentry release action

Sentry release is responsible to let Sentry know that we have a new release. It is running even if the release is failed. It should run just after a successful release.
Acceptance criteria

Run a failed release without sentry release
Run a successful  release with a sentry release

failed release without sentry release action

sentry release just runs after app build

Sentry release should be its own action. It cannot run in macos.

Sentry release happens after Flutter action


In test-suite operation key should be fetched  from operation-server instead of Action-profile

Issue Description :The Request -body of the the service /v1/list-records-of-application of  Response  and Action Profile we are passing the operation key from the Action-profile  so the /v1/list-records-of-application service  is giving response code as 401 for Action and Respose -profile while executing the test-suite run .
A failure in the following scenarios :
OAMLAYER / BASICPART / ACTION-PROFILE / CAPABILITY/OPERATION-NAME / GET / CONTINUOUS INTEGRATION / REQUEST NOTIFIED? - 4 REQUESTS IN THE FOLDER
OAMLAYER / BASICPART / RESPONSE-PROFILE / CAPABILITY/OPERATION-NAME / GET / CONTINUOUS INTEGRATION / REQUEST NOTIFIED? - 4 REQUESTS IN THE FOLDER
Solution : In test-suite operation key should be fetched  from operation-server instead of Action-profile

this issue is duplicated
https://github.com/openBackhaul/ApplicationPattern/issues/820


Websocket

The extension doesn't record websocket traffic.

@millergarym The recorder in it's current form only supports outputting a Lua script for our current cloud service at loadimpact.com, and it unfortunately doesn't support WebSocket.
Our new open source load generator based on JavaScript, k6, however does support WebSocket (see https://docs.k6.io/docs/websockets). For k6 we don't have a dedicated recorder but it supports converting HAR files (from dev console browser recordings) to k6 JS scripts (see https://docs.k6.io/docs/session-recording-har-support).

@robingustafsson unfortunately websocket traffic is not recorded in the HAR file and is not supported by the current har spec.
Is a K6 recorded in the works as I'm happy to contribute (time and skills permitting)
https://stackoverflow.com/questions/29953531/how-to-save-websocket-frames-in-chrome
https://groups.google.com/forum/#!topic/google-chrome-developer-tools/jUOLFqpu-2Y
https://groups.google.com/forum/#!topic/http-archive-specification/_DBaSKch_-s

@millergarym Hm, that's true. At the moment we don't have a dedicated recorder started for k6. We only have this Chrome extension to record HTTP traffic and convert it to Lua, and a plugin for the Fiddler proxy (https://github.com/loadimpact/FiddlerToLoadImpact) that could perhaps be extended to extract WebSocket traffic as Fiddler supports that.
Found an alternative SO page talking about websocket interception from Chrome extension as well: https://stackoverflow.com/questions/22868897/access-websocket-traffic-from-chrome-extension, and it links to https://github.com/gorhill/chromium-websocket-wrapper. So it seems there exists ways to get at the WebSocket traffic from a Chrome extension, so maybe this Chrome extension could be extended to support WebSockets.

Chromium now supports exporting websocket messages to HAR files. https://chromium.googlesource.com/chromium/src.git/+/9683677526bf8e4b9f87e52c1387da551078b0e4


cross platform: fixes output message for ch

This PR also fixes minor ch build issue with clang3.9

LGTM- merging

Well- whenever the CI system allows me too 😄


2 Games with wrong language description in the Info Box.

Hallo
These 2 Games have German Language instead of English.

Leisure Suit Larry 3 (MT32)

Space Quest III (MT-32)

I am not near my MiSTer at the moment, but is this the same fix as in #121, a config change to ensure it loads in German?

Hallo
No, you just have to replace :   Language: English  to  Language: German
in these 2 Files:

Leisure Suit Larry 3 (MT...txt
Space Quest III (MT-32).txt

We have removed these for now, since they are always in German, the English versions don’t seem to work. Will have to chase down why later.


csplit: added core logic for splitting a file on patterns

Close #501
Tested on linux. The core logic of splitting a file seems to be ok.
Remaining tasks:

[x] implement all options
[x] handle some invalid states, especially when using an option
[x] add some more tests

Should I review the code now or are you planning to finish the remaining tasks soon (in which case I will wait until you have finished most likely)?

@Arcterus I will first fix what I have based on your comment on the related issue.

Alright, let me know when you finish. :)

@Arcterus It is now ready to review. There are few edge cases which do not follow the gnu's behaviour (marked as such at the bottom of the test file).

@Arcterus bump

@scampi Hello
I am well aware that this PR is 2 years old. I am a new maintainer on this project and would like to know if you are still interested to land this?
Sorry about that :(

Sorry for the latency. I took over the maintenance.
I moved this PR here:
https://github.com/uutils/coreutils/pull/1672


Fix import of validateVmName()

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1711136
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1711858

Backport of: #467

Pull Request Test Coverage Report for Build 1896

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.007%) to 82.615%

Totals

Change from base Build 1606:
-0.007%

Covered Lines:
3831

Relevant Lines:
4434

💛  - Coveralls


cmd/gofmt: inconsistent behavior on removing unnecessary type names with -s arg

Go version
go version go1.21.5 linux/amd64
Output of go env in your module/workspace:
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/fishy/.cache/go-build'
GOENV='/home/fishy/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/fishy/.gopath/pkg/mod'
GONOPROXY='omitted'
GONOSUMDB='omitted'
GOOS='linux'
GOPATH='/home/fishy/.gopath'
GOPRIVATE='omitted'
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/lib/go-1.21'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/lib/go-1.21/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.21.5'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/home/fishy/test/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build1401412523=/tmp/go-build -gno-record-gcc-switches'

What did you do?
main.go:
package main

import (
	"fmt"
)

type Data struct {
	Foo int
}

type Response struct {
	Item  []*Data
	Items [][]*Data
}

var s = Response{
	Item: []*Data{
		&Data{
			Foo: 1,
		},
	},
	Items: [][]*Data{
		{
			&Data{
				Foo: 2,
			},
			&Data{
				Foo: 3,
			},
		},
	},
}

func main() {
	fmt.Println(s)
}

gofmt -s -d main.go will only suggest removing &Data from Item, but not from Items:
$ gofmt -s -d main.go
diff main.go.orig main.go
--- main.go.orig
+++ main.go
@@ -15,7 +15,7 @@

 var s = Response{
        Item: []*Data{
-               &Data{
+               {
                        Foo: 1,
                },
        },

But removing both are perfectly fine: https://go.dev/play/p/pEfXLBwuwL1
What did you see happen?
gofmt -s is inconsistent as it fail to suggest the same thing when it's under two or more layers of slices.
What did you expect to see?
gofmt -s being consistent.

CC @griesemer, @mvdan.

Assigning to me for 1.24 to make it visible.

Not urgent - we have lived with this for > 15 years.
Good, isolated project for somebody who is well-versed with the AST.

You can give this issue a try, yes. I can give some guidance, but it is assumed that whoever tries with issues like these will do most of the legwork by themselves.


Create a contracts model for each chain that identifies the deployer address

Describe the feature you'd like to request
Creating a separate issue from https://github.com/opensource-observer/oso/issues/1374
We only need to go two levels deep, eg:

contracts_by_deployer_one_level
contracts_by_factory_one_level
contracts_by_deployer_two_levels (union of the above two tables)

Specific user story:

i deploy a factory from my EOA and it deploys contract x, then i give contract x's address and you give me the EOA address

Describe the solution you'd like
A staging model with a schema along these lines:

contract_address
contract_is_factory
created_by_address
create_method (ie, create or create2)
root_deployer_address (null if there is no EOA after scanning two layers deep)

Describe alternatives you've considered
We discussed making a graph database that could be traversed until the root deployer is identified

See also #1140

@ravenac95 I've done the easy part of this -- just the deployers.
I'm not sure I understand how to integrate the factories and create2 data though. Would you mind taking a look?

for example, how should I make sense of the results of this type of query:
select
  d.deployer_address,
  f.factory_address,
  f.contract_address,
  f.originating_address,
  f.originating_contract
from  `oso.stg_zora__factories` f
join `oso.stg_zora__deployers` d
  on f.factory_address = d.contract_address
where originating_contract is not null

OK, refactored version that unions all contracts:
with contract_deployments as (
  select
    deployer_address as root_deployer_address,
    deployer_address as created_by_address,
    contract_address,
    deployer_address as originating_eoa_address,
    transaction_hash,
    'EOA' as creator_type,
    case
      when contract_address in (
        select distinct factory_address
        from `oso.stg_zora__factories`
      ) then 'FACTORY'
      else 'CONTRACT'
    end as contract_type
    from `oso.stg_zora__deployers`
),

factory_deployments as (
  select
    d.deployer_address as root_deployer_address,
    f.factory_address as created_by_address,
    f.contract_address,
    COALESCE(f.originating_address, d.deployer_address) as originating_eoa_address,
    f.transaction_hash,
    'FACTORY' as creator_type,
    'CONTRACT' as contract_type
  from `oso.stg_zora__factories` f
  join `oso.stg_zora__deployers` d
    on f.factory_address = d.contract_address
)

select * from contract_deployments
union all
select * from factory_deployments


Packet drops with externalTrafficPolicy: Cluster in generic-veth chaining mode

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Hey, I use cilium in generic-veth chaining mode with kube-ovn. Kube-proxy replacement is enabled in strict mode.
Everything works as expected. However external traffic to service with externalTrafficPolicy: Cluster forwarded to pods on external nodes always reseted:
11:52:30.232445 IP <IP_ADDRESS>.57196 > <IP_ADDRESS>.80: Flags [S], seq<PHONE_NUMBER>, win 65535, options [mss 1460,nop,wscale 6,nop,nop,TS val<PHONE_NUMBER> ecr 0,sackOK,eol], length 0
11:52:30.232539 IP <IP_ADDRESS>.80 > <IP_ADDRESS>.57196: Flags [S.], seq 499673168, ack<PHONE_NUMBER>, win 32352, options [mss 1360,sackOK,TS val<PHONE_NUMBER> ecr<PHONE_NUMBER>,nop,wscale 7], length 0
11:52:30.232877 IP <IP_ADDRESS>.57196 > <IP_ADDRESS>.80: Flags [R], seq<PHONE_NUMBER>, win 0, length 0

In case if I disable hostLegacyRouting option, I see that external services traffic can reach pods on both local and remote nodes, however in this case any pods on the same nodes can’t reach each-other, packets are just dropped for some reason.
Cilium Version
Client: 1.15.5 8c7e442c 2024-05-10T16:33:07+02:00 go version go1.21.10 linux/amd64
Daemon: 1.15.5 8c7e442c 2024-05-10T16:33:07+02:00 go version go1.21.10 linux/amd64
Kernel Version
Linux srv1 6.6.29-talos #1 SMP Tue Apr 30 14:51:50 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Kubernetes Version
v1.30.0
Regression
No response
Sysdump
cilium-sysdump-20240524-220902.zip
Relevant log output
No response
Anything else?
No response
Cilium Users Document

[ ] Are you a user of Cilium? Please add yourself to the Users doc

Code of Conduct

[X] I agree to follow this project's Code of Conduct

This patch makes everything working in my setup:
diff --git a/bpf/bpf_lxc.c b/bpf/bpf_lxc.c
index<PHONE_NUMBER>..798eb2c0b0 100644
--- a/bpf/bpf_lxc.c
+++ b/bpf/bpf_lxc.c
@@ -1092,7 +1092,7 @@ ct_recreate4:
         * that endpoint.
         */
        if (is_defined(ENABLE_ROUTING) || hairpin_flow ||
-           is_defined(ENABLE_HOST_ROUTING)) {
+           !is_defined(ENABLE_HOST_ROUTING)) {
                /* Hairpin requests need to pass through the backend's to-container
                 * path, to create a CT_INGRESS entry with .lb_loopback set. This
                 * drives RevNAT in the backend's from-container path.
@@ -1114,7 +1114,7 @@ ct_recreate4:
                 */
                ep = lookup_ip4_endpoint(ip4);
                if (ep) {
-#if defined(ENABLE_HOST_ROUTING) || defined(ENABLE_ROUTING)
+#if !defined(ENABLE_HOST_ROUTING) || defined(ENABLE_ROUTING)
                        if (ep->flags & ENDPOINT_F_HOST) {
                                if (is_defined(ENABLE_ROUTING)) {
 # ifdef HOST_IFINDEX
@@ -1250,7 +1250,7 @@ skip_vtep:
                        return ret;
        }
 #endif /* TUNNEL_MODE || ENABLE_HIGH_SCALE_IPCACHE */
-       if (is_defined(ENABLE_HOST_ROUTING)) {
+       if (!is_defined(ENABLE_HOST_ROUTING)) {
                int oif = 0;

                ret = fib_redirect_v4(ctx, ETH_HLEN, ip4, false, false, ext_err, &oif);
@@ -1263,7 +1263,7 @@ skip_vtep:

        goto pass_to_stack;

-#if defined(ENABLE_HOST_ROUTING) || defined(ENABLE_ROUTING)
+#if !defined(ENABLE_HOST_ROUTING) || defined(ENABLE_ROUTING)
 to_host:
 #endif
 #ifdef ENABLE_ROUTING

@borkmann maybe you could help to investigate this?

Oh, after three days of debugging I found that ovn0 device has missing bpf program:
now I added it to cilium-config:
devices: "en+ ovn0"

and everything statred working 🎉
# tc filter show dev ovn0 egress
filter protocol all pref 1 bpf chain 0
filter protocol all pref 1 bpf chain 0 handle 0x1 cil_to_netdev-ovn0 direct-action not_in_hw id 114214 tag<PHONE_NUMBER>0264a5 jited

Is there any way to say "use autodetected device plus another one" in cilium?
Also there is a potencial race condition, because kube-ovn requires cilium to working and starts , and cilium requires ovn0 interface to add bpf program on it.

Closed in favor https://github.com/cilium/cilium/issues/32721


Mkuzak patch 1

Added checklist matrix and checkable checklists

These files are not referenced in the summary, so do not end up in the book. Should we add them?

Not yet, we wanted to migrate them already but don't have a good idea how they fit with the rest of the book.

What if we make them "sub pages" of the checklist for now?


CMake edit from the GEOSadas development

This is a fix from @bena-nasa found during our GEOSadas-to-Git work. Essentially some script in GEOSadas seems to expect the GMIchem_HISTORY___.rc file even though nothing will ever use it. This update just copies that file. I guess?

Agreed, that History file is not used, so it should not interfere with anything.


SCSS file error

I have installed this again but facing issues while importing the scss file into my project.
I have imported using @import "~carbon-addons-infrastructure/scss/index"; but getting the below error. It may be an issue in importing the carbon-components library in scss files. Please look on it.

Can you pls look into this its urgent.
Thanks in advance.

Hi 👋 would you try includePath setting in Sass building tool? Thanks!

I got this issue working.
Thanks...!!!

:+1:


User Creation - both assigned Admin role?

https://docs.microsoft.com/en-us/security/compass/privileged-access-deployment#azure-ad-users-and-groups
Create your device user by following the steps in the create user tutorial.
Enter:
Name - Secure Workstation Administrator Shouldn't this be Secure Workstation User?
User name -<EMAIL_ADDRESS>Directory role - Limited administrator and select the Intune Administrator role. If this is a user account, should it have the Administrator role configured?
Usage Location - United Kingdom
Select Create.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6fc109e7-e2ad-6e3c-598d-36876b40dbfd
Version Independent ID: da56e91b-41ca-2c29-0e8c-bc4d2a36a748
Content: Deploying a privileged access solution
Content Source: compass/privileged-access-deployment.md
Service: security
Sub-service: ****
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@MicrosoftGuyJFlo - Please review.


Openstreetmap toolbox on top of error message.

Describe the bug

When there is a openstreetmap component in the designer and an error is displayed the toolbox of the openstreetmap component and the copyright message are above the error message. See image.

Affects

[x] Designer
[ ] Blocks editor
[ ] Companion
[ ] Compiled apps
[ ] Buildserver
[ ] Debugging
[ ] Other... (please describe)

Expected behavior

The toolbox and copyright message should be below the error message.
Steps to reproduce
Use an openstreetmap component. Make an error message appear. ;-)

I think this just involves some z-index tweaking. It should be a good issue for anyone looking to get started contributing to App Inventor.

I want to work on this issue

@nirvasangani Sure!


Added package-source flag to replace where package comes from

Added package-source flag
moved project-name flag to top level so print-graph returns
stripped out pkg:maven and replaced with regex

webnext test script returns empty dependency tree - need to confirm if that's a bug or not

webnext test script returns empty dependency tree - need to confirm if that's a bug or not

@snykAndrew can you confirm what this means?

mathes@CKK6YXP2NK sbom_to_snyk_depgraph % export SBOM_FILE=/Users/mathes/Downloads/sbom_webnext_test_1.json
mathes@CKK6YXP2NK sbom_to_snyk_depgraph % poetry run python3 main.py --ignore-file=ignore.txt --package-source=npm --project-name=demoTest print-graph
{
"depGraph": {
"schemaVersion": "1.2.0",
"pkgManager": {
"name": "npm"
},
"pkgs": [
{
"id"<EMAIL_ADDRESS>"info": {
"name": "demoTest",
"version": "0.0.0"
}
}
],
"graph": {
"rootNodeId": "demoTest",
"nodes": [
{
"nodeId": "demoTest",
"pkgId"<EMAIL_ADDRESS>"deps": []
}
]
}
}
}

@snykAndrew this doesn't look right.  Can you please post a screenshot of the snapshot in the UI after running Snyk monitor?

I think it is right for this file:
"component": {
"name": "rush-common",
"group": "",
"version": "0.0.0",
"description": "Temporary file generated by the Rush tool",
"purl"<EMAIL_ADDRESS>"bom-ref"<EMAIL_ADDRESS>"type": "application"
},
        "dependencies": [
    {
        "ref"<EMAIL_ADDRESS>        "dependsOn": []
    },


Fix for LngLatAltSerializer so that it produces an array of doubles rather than strings

If you look at the geoJson specifications position data should be given as an array of doubles not strings.
http://geojson.org/geojson-spec.html#geometry-objects
Theres was also the problem that the Double to String conversion in LngLatAltSerializer performed on lng and lat but not alt. So a 3d point ends up with two strings and a double.
I came accorss this problem when I was trying to use geojson generated by this api with MongoDB. MongoDB is designed to work wth the geoJson spec and so cannot create indexes for the generated geoJson as it expects arrays of Doubles not Strings when dealing with locations.
Ive corrected these problems by removing the fastDoubleToString method from the LngLatAltSerializer.

Any action on this PR?

Any action on this PR?

This PR looks good, I ran into a similar issue recently!
@grundid Are you going to merge this?

no tests :( anyway...


Change default Welcome.pdf in PDF View module

Struggled to find any documentation on how to do this.
Helpful Cloudron community led to trying putting a customised Welcome.pdf in customFiles/static/pdfjs/example
Please confirm this is correct or if there is a better option.
Also please provide guidance / documentation on use of templates directory in customFiles.
Great product - thank you !

Template directory currently isn't supported only static
As for the static folder yes you should use that oathing with a new welcome.pdf in that folder
If it doesn't work I'll investigate

Thank you @Frooodle
Yes, the replacement Welcome.PDF at that path is being shown.


Back camera is always failing

Should there be another model for the back camera?

Is there an option to switch to the back camera?

i have the same problem

Did anyone get a solution for this problem?

any solution >>)


User Profile Page Design and Controller

Overview
This branch has the design and controller, routes updates to show the User Profiler.
Requesting Sam  to add the code for the TODO Items shown in the screenshot of the User Profile Page
Screenshots
User Profile Page Skeleton

Click on the user name and you can go to their Profile Page

-->

Great!👌


Schema description of one field overrides descriptions of other fields of same class

Let's take an example of two simple classes:
public class GeoPointDto {

	@Schema(description = "Longitude of geo point ( -180, 180 >")
	private double lon;

	@Schema(description = "Latitude of geo point < -90, 90 >")
	private double lat;
}

public class RouteDto {

	@Schema(description = "Point where the route begins")
	private GeoPointDto startPoint;

	@Schema(description = "Intermediate point of the route")
	private GeoPointDto intermediatePoint;

	@Schema(description = "Point where the route ends")
	private GeoPointDto endPoint;
}

Expected behavior is to have three fields inside RouteDto with different descirption each.
Actual behavior is that all fields has same description = "Point where the route ends" which is the description of third field.
UI:

JSON:
  "components" : {
    "schemas" : {
      "RouteDto" : {
        "type" : "object",
        "properties" : {
          "startPoint" : {
            "$ref" : "#/components/schemas/GeoPointDto"
          },
          "intermediatePoint" : {
            "$ref" : "#/components/schemas/GeoPointDto"
          },
          "endPoint" : {
            "$ref" : "#/components/schemas/GeoPointDto"
          }
        }
      },
      "GeoPointDto" : {
        "type" : "object",
        "properties" : {
          "lon" : {
            "type" : "number",
            "description" : "Longitude of geo point ( -180, 180 >",
            "format" : "double"
          },
          "lat" : {
            "type" : "number",
            "description" : "Latitude of geo point < -90, 90 >",
            "format" : "double"
          }
        },
        "description" : "Point where the route ends"
      }
    }
  }

According to the specification all properties except $ref in the object should be ignored, so I guess it is unsolvable problem for the current OpenAPI Specification. Unless we inline the schema instead of using a reference, which is undesired for a lot of other reasons.
I would say that it is more consistent behavior to always ignore (maybe with a warning) any properties of the  @Schema annotation on the object property when the property type is a reference to another schema. Overriding properties in the referenced schema leads to weird behavior when referenced schema is used multiple times. I understand why current behavior is used as it allows things to kinda work for nested objects used only once... Not sure how to fix this bug with the current specification.
Looks like the restriction on the $ref + other properties was lifted in the latest draft, but it will probably not get adopted by OpenAPI specification any time soon.

Looks like the restriction on the $ref + other properties was lifted in the latest draft, but it will probably not get adopted by OpenAPI specification any time soon.

Looks like it was adopted in 3.1.0: https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.1.0.md#fixed-fields-19

@Cybermite
It's indeed adopted in 3.1.0
Reference: https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.1.0.md#referenceObject

This issue still exists in 2.2.15 at least.

is the issue fixed in OAS 3.1 or do we need to do something different in the code?
public class RouteDto {

	@Schema(description = "Point where the route begins")
	private GeoPointDto startPoint;

	@Schema(description = "Intermediate point of the route")
	private GeoPointDto intermediatePoint;

	@Schema(description = "Point where the route ends")
	private GeoPointDto endPoint;
}

Still a issue. I used this simple workaround
public class GeoPointDto {

	@Schema(description = "Longitude of geo point ( -180, 180 >")
	private double lon;

	@Schema(description = "Latitude of geo point < -90, 90 >")
	private double lat;

	public static class Start extends GeoPointDto {}
	public static class Intermediate extends GeoPointDto {}
	public static class End extends GeoPointDto {}
}

public class RouteDto {

	@Schema(description = "Point where the route begins")
	private GeoPointDto.Start startPoint;

	@Schema(description = "Intermediate point of the route")
	private GeoPointDto.Intermediate intermediatePoint;

	@Schema(description = "Point where the route ends")
	private GeoPointDto.End endPoint;
}

Found the solution at this documentation at section 13.74. How can i define different schemas for the same class?
https://springdoc.org/#properties

See #3561

Following https://github.com/OAI/OpenAPI-Specification/issues/2033, would it be possible to generate something like this?
  "components" : {
    "schemas" : {
      "RouteDto" : {
        "type" : "object",
        "properties" : {
          "startPoint" : {
            "description" : "Point where the route begins",
            "allOf" : [
              "$ref" : "#/components/schemas/GeoPointDto"
            ]
          },
          "intermediatePoint" : {
            "description" : "Intermediate point of the route",
            "allOf" : [
              "$ref" : "#/components/schemas/GeoPointDto"
            ]
          },
          "endPoint" : {
            "description" : "Point where the route ends",
            "allOf" : [
              "$ref" : "#/components/schemas/GeoPointDto"
            ]
          }
        }
      },
      "GeoPointDto" : {
        "type" : "object",
        "properties" : {
          "lon" : {
            "type" : "number",
            "description" : "Longitude of geo point ( -180, 180 >",
            "format" : "double"
          },
          "lat" : {
            "type" : "number",
            "description" : "Latitude of geo point < -90, 90 >",
            "format" : "double"
          }
        }
      }
    }
  }

Following https://github.com/OAI/OpenAPI-Specification/issues/2033, would it be possible to generate something like this?
  "components" : {
    "schemas" : {
      "RouteDto" : {
        "type" : "object",
        "properties" : {
          "startPoint" : {
            "description" : "Point where the route begins",
            "allOf" : [
              "$ref" : "#/components/schemas/GeoPointDto"
            ]
          },
          "intermediatePoint" : {
            "description" : "Intermediate point of the route",
            "allOf" : [
              "$ref" : "#/components/schemas/GeoPointDto"
            ]
          },
          "endPoint" : {
            "description" : "Point where the route ends",
            "allOf" : [
              "$ref" : "#/components/schemas/GeoPointDto"
            ]
          }
        }
      },
      "GeoPointDto" : {
        "type" : "object",
        "properties" : {
          "lon" : {
            "type" : "number",
            "description" : "Longitude of geo point ( -180, 180 >",
            "format" : "double"
          },
          "lat" : {
            "type" : "number",
            "description" : "Latitude of geo point < -90, 90 >",
            "format" : "double"
          }
        }
      }
    }
  }

Unfortunately, there doesn't seem to be a way to have the schema generated like that. The allOf in the @Schema annotation is being ignored.

I also encountered the same problem, I don't know when it can be solved? As for the method mentioned above using subclassing, I feel it is not a good solution.


stochastic calculations inside emcee

Hi,
I have a model for which I am using emcee to sample three parameters.
I have trouble getting good acceptance ratio. I have increased the number of walkers to 2000 and still have the same problem. Funny enough, the first few samples, i.e., first 100 or so, have acceptance ratio around 25-30 % but then it drops to 0.01%. I am initializing the walkers with random values.
Is there any diagnostic or something else one can do to improve the sampling?
thanks in advance
Inti

Hi, @dfm do you have some code at hand where to find examples of setting the random number generator inside emcee to enable the stochastic calculations?
thanks in advance


How to migrate to webpack 4? (help wanted)

I'm quite new to webpack and everything about nodejs but need to migrate a project written with webpack 1 and svg-sprite-loader 0.1.2 to the latest version of them (webpack 4 and svg-sprite-loader 3.7.1).
In the original project, the webpack config was:
exports.loaders = [{
  test: /\.svg$/,
  loaders: ['svg-sprite?' + JSON.stringify({name: 'icon-[name]'})],
  include: /tb-icons\/lib\/svgs/
}]

Then in the .vue files we could use the svgs like <btn icon="menu"></btn>.
But how to transform it to meet the latest version of both svg-sprite-loader 3.7.1 and webpack 4?
Below is the best I can think of after spending hours, but it is still not working.
module.exports = {
  module: {
    rules: [{
       test: /\.svg$/,
        use: [
          {
            loader: "svg-sprite-loader",
            options: {
              runtimeCompat: true,
              include: /tb-icons\/lib\/svgs/
            }
          }
        ]
      }
    ]
  }
}

Sorry it definitely is a very basic question. Any help will be appreciated, thanks!

Could you please create repo with minimal setup to demonstrate your setup (package.json, webpack config, SVG image and piece of your code). If you don't want to create a repository - you can create a gist with multiple files.

@kisenka Thanks for the response!
If you may help, I've setup a repo: https://github.com/zhengkai2001/svg-sprite-loader-help
A little explanation:
I want to use "menu.svg" and "remove.svg" (the are located in "node_modules\tb-icons\lib\svgs") in my customized element Btn and Icon.'
When I inspected them in the browser, they have the correct , , etc. So I guess the problem is my inability :( of configure the loader in the webpack conf file: \build\webpack.base.conf.js .
I know it's still kind of complicated but I tried to make the code minimal ... Thank you so much for your time!

As said I'm quite new to webpack and all the stuff. So if there is a better to do it (use the svg's in the Btn and Icon elements) I'll be happy to learn!
Thank you for your help!!

Thank you so much for looking into this!
Now I realize the problem is probably that I'm using Windows 10 ... I just ran it on my friend's macbook and it was successful just like what you showed.
Do you have any idea about how to make it work on Windows? Or where could the root cause be? Or is there a way to debug (like, showing the internal process step by step in console)?
Thanks again for your kind help!

I still don't understand what problem is. Are there any errors during the build or what?

Sorry I forgot to mention the problem ...

The problem was: The svg's simply didn't display. The build was successful. Also, there was no error in browser's console.

The elements

This happens in all browsers?

I tried Firefox and Chrome, same result.

Try to check this demo on other Windows machine. If error appears I'll find way to debug it on Windows.

Actually I have two Windows laptops (both of them are 64-bit Windows 10 though) ... I ran it on both and got same result.
If you could help resolve this that would be great! Thank you!!

OK, I will check it