KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

This PR adds the GroupMetadataManager to the group-coordinator module. This manager is responsible for handling the groups management, the members management and the entire reconciliation process. At this point, only the new consumer group type/protocol is implemented.
As you will see, the new manager is based on an architecture inspired from the quorum controller. A request can access/read the state but can't mutate it directly. Instead, a list of records is generated together with the response and those records will be applied to the state by the runtime framework. We use timeline data structures. Note that the runtime framework is not part of this PR. It will come in a following one.
For the reviewers, I suggest starting from the GroupMetadataManager.consumerGroupHeartbeat method. From there, you will how the consumer group heartbeat is handled and how all the classes fit together. Then, it is possible to review the classes independently, I suppose.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@jeffkbkim @jolshan Thanks for your reviews. I think that I have addressed all your comments.


staticBaseUrl seem invalid in app.conf

I have deployed my own static file server, but when I modify app.conf, the front-end pages are still using the default static file server at https://cdn.casbin.org.
Is this a bug or is the documentation incorrectly described?

staticBaseUrl is address of the static image when the system initializes the database.

I changed https://github.com/casdoor/casdoor/blob/95ab2472ce84c479be43d6fc4db6533fc738b259/web/src/Setting.js#L34 and recompiled the front-end file and it worked.

@Matrix-0 what's your question? Actually, if you changed all https://cdn.casbin.org/ occurences to something else, then it will not show up any more, right?


Mistake in formal spec definition of function createRUpd

In Figure 50 (Page 63) of the ledger formal spec, the definition of the createRUpd function, the denominator used in the calculation for eta (the ratio between the number of blocks that have been produced during the epoch and expected value of blocks that should have been produced under ideal conditions) has the decentralization parameter d as a factor but in the executable spec this factor is (1-d).
Section 3.8 of the design spec states that the total number of blocks in the epoch is taken as the number of blocks produced in non-OBFT slots, and that (d*n_s) is the number of OBFT slots (thus ((1-d)*n_s) is the number of non-OBFT slots) so, if I am not mistaken, it appears the formal spec is incorrect while the executable spec is correct.

closed by #2332


Añadir nuevo evento: BcnRust Meetup

Nombre o título del evento
Rust for the web
Web del evento
https://www.meetup.com/bcnrust/events/300765894/
Descripción corta
This time we have been collaborating with Mainmatter to prepare this special event called Rust for the web.
We will have two talks and a final panel.
TALK 1: Excitement of Football, Reliability of Rust by Matilda Smeds
TALK 2: To be announced by Gleb Pomykalov
Fecha de inicio
30/05/2024 18:30
Fecha de fin
30/05/2024 20:30
Localización del evento
Barcelona
Imagen de portada
https://secure.meetupstatic.com/photos/event/d/4/0/7/600_520794279.webp?w=384
Redes sociales
https://bcnrust.github.io/, https://twitter.com/bcnrust, https://www.youtube.com/@bcnrust
Detalles
Details
This time we have been collaborating with Mainmatter to prepare this special event called Rust for the web.
We will have two talks and a final panel.
TALK 1: Excitement of Football, Reliability of Rust by Matilda Smeds
Abstract: In this talk Matilda explores architectural choices, stack, and the rollercoaster of experiences along the way, of developing a backend of a football mobile game. Join in to hear about the twists, turns and unexpected delights of building a distributed backend with Rust.
Bio: Matilda Smeds is a seasoned software engineer, who has spent the last three years in the gaming industry. In her current role at Matchday, she leverages Rust to develop a backend for a football mobile game.
TALK 2: To be announced by Gleb Pomykalov
Abstract: To be announced.
Bio: Gleb Pomykalov is an Engineering Director at Workato.
FINAL PANEL
A panel with both speakers will follow the talks. Luca Palmieri will be moderating the discussion.
Moderator bio: Luca Palmieri works as a Principal Engineering Consultant at Mainmatter. He has been part of the Rust community since 2018 and is best known as the author of “Zero to Production in Rust”, the go-to book for backend development in Rust.
As usual, Adevinta will be hosting this event, and we will have drinks and pizzas.
IMPORTANT: Due to Adevinta’s policies, you will be asked for your ID to access their offices, so don’t forget it or you won’t be able to enter. They also ask us for an advanced list of IDs to prepare access, so we would appreciate it if you could FILL OUT THIS FORM.

Gracias a ti @achamorro-dev


ADLPlug: v1.0.0-beta.5 -> v1.0.0

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build adlplug opnplug

@ryantm Fixed, thanks!

@veprbl Thank you!


Inconsistent tag pattern

Hey, just wanted to say that the latest version is missing the v prefix: https://github.com/godzie44/BugStalker/releases/tag/0.2.1
Whereas the previous versions had it, e.g. https://github.com/godzie44/BugStalker/releases/tag/v0.2.0
It is probably best to push v0.2.1 without deleting 0.2.1 in case someone packaged it already 🐻

Fixed, thanks 🙂


Lots of warnings when compiling

User
warning: #import is a deprecated GCC extension [-Wdeprecated]
3 | #import "QString"
|  ^~~~~~

Fixed typo in https://github.com/Rzeps0n/connect4_qt/commit/a0379235fc168a2d8c563807ddb07da3ad3fdda5


config: overridable configuration

overridable configuration for the app
closes #6

I would say we could clean up a bit, review the naming and what config variables go where but it is not blocking for this PR


Make elliptic curve module no std

Make elliptic curve module no std
Description
Description of the pull request changes and motivation.
Type of change
Please delete options that are not relevant.

[ ] New feature
[ ] Bug fix
[ ] Optimization

Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

[ ] This change is an Optimization

[ ] Benchmarks added/run

Codecov Report

Merging #621 (dfc97a6) into main (6d686d3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #621   +/-   ##
=======================================
  Coverage   97.11%   97.11%
=======================================
  Files         114      114
  Lines       26540    26540
=======================================
  Hits        25775    25775
  Misses        765      765

Files
Coverage Δ

math/src/elliptic_curve/edwards/traits.rs
100.00% <ø> (ø)

math/src/elliptic_curve/montgomery/traits.rs
100.00% <ø> (ø)

math/src/elliptic_curve/point.rs
100.00% <ø> (ø)

.../short_weierstrass/curves/bls12_381/compression.rs
95.83% <ø> (ø)

...rt_weierstrass/curves/bls12_381/field_extension.rs
89.30% <ø> (ø)

...urve/short_weierstrass/curves/bls12_381/pairing.rs
99.53% <ø> (ø)

...c_curve/short_weierstrass/curves/bls12_381/sqrt.rs
88.77% <ø> (ø)

..._curve/short_weierstrass/curves/bls12_381/twist.rs
97.80% <ø> (ø)

math/src/elliptic_curve/short_weierstrass/point.rs
99.23% <ø> (ø)

...ath/src/elliptic_curve/short_weierstrass/traits.rs
100.00% <ø> (ø)

... and 1 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


✨ Publication Entry: srlearn

[X] Summary of changes

Add 'srlearn' entry to _data/publications.yml
Entry includes the main requirements: the PDF link and the code
link. Remaining external links (slides, poster, video) will be
added in a future commit when the workshop draws near.

@harshakokel I wasn't sure if the StarAI workshop papers were meant to be in any particular order. Please let me know if there's anything else I can do!

@hayesall,  No order required. This is good.


resolve conflict relations + create form room

it's done. with the manyTooMany relations between user and room.

ok for me


All instructions should mention Entra or Entra ID instead of Azure AD

Module: 00
Lab/Demo: 00
Task: 00
Step: 00
Description of issue
Naming was changed, but not updated in labs.
Repro steps:

Search the lab content for 'Entra', no results.

@dave-007 The lab contents have been updated with changes for Azure AD to Microsoft Entra ID.

Fixed


change goal to 2021 star amount

Change goal amount as to this happeo post:

I'm guessing the last years stars was 1477 since that's the latest update we got from aoc-bot in the slack channel

Also changed the topic template and added the sponsor join code in .env


Remove directives folder from .gitignore files for lit-html and lit-html-server to avoid import error

In version 5.0.4 of @popeindustries/lit-html and @popeindustries/lit-html-server the directives folder, pointed to by the exports map config, was not included in the package, and the import could not be resolved, due to the fact that is is listed in  .gitignore since it is generated. This aims to fix that.
Why it seemed to work while testing the previous branch by linking, I still do not know 😢
Fix

Add empty .npmignore files to keep directives in npm package, but keep them in .gitgnore to keep them out of git.

ref: https://docs.npmjs.com/cli/v8/using-npm/developers#keeping-files-out-of-your-package

Directives could probably be listed in "files" in package.json too, as an alternative. You decide what you prefer.


Various tests-related improvements

Various tests-related improvements
Streamline and document how to run tests
Fix formatting in tests
Add missing tests for taxonomies and taxons
Add missing rspec expectation for product with variants
Add missing requires
Use variables in Variant test rather than interpolation within query string
Standardize on not using connections if "_connection" is not part of field name

(If something in this PR should be changed before it would be accepted, sure let me know. Thanks!)

On it. Will review in the am

Closing this one because the same changes are present (and further improved/modified) in #19.


MEETING

To join the video meeting, click this link: https://meet.google.com/xxq-emdk-pwq
Otherwise, to join by phone, dial +1<PHONE_NUMBER> and enter this PIN: 328 170 797#

Youssef : Products Availability
Raneem : create account
Sharqawy : product price comparison
Abdelrahman : Cart
seif : profile


View Assets

Story
As a crypto-assets holder who needs to prove the ownership of assets, I want to have a simple assets view so I can link anyone to it.
Context
NEAR foundation request:

Indeed, we need to show the balances (either historical, or the current balance) to the auditors already this week. But definitely sound great there will be asset tab on Explorer. It's especially becoming important for stablecoins.

Additional feature would be great for adoption of stablecoins and other assets, is to show them on Explorer transactions: so we and others can pay in stablecoins and share tx link as a proof of payment (currently shows in different units, e.g. here says amount 5,000,000,000 when we paid 5k wrapped USDT - not straightforward to prove the payment amount)

Considerations
We already have discussed that we need support to view assets, and it is currently in the initial exploration/design stage.
Acceptance Criteria
TBD

Our team also needs this, how to build a user balance from Indexer data.


[1.3] Color Control Cluster XML has to be updated as per spec

Description:

[ ]  "EnhancedColorMode" attribute max range is wrong in XML. It should be 3 instead of 0xFF.

[ ]  Bit 0 Feature name has to be updated from “HueAndSaturation” to “Hue or Saturation” in XML.

[ ]  "CoupleColorTempToLevelMinMireds" attribute Max range value is wrong in XML.

[ ]  "EnhancedColorMode" and "DriftCompensation" Attributes eum values are missing in XML.

[ ]  "Options" attribute bit value is missing in XML.

Spec Reference: https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/ColorControl.adoc
XML Reference: https://github.com/project-chip/connectedhomeip/blob/master/src/app/zap-templates/zcl/data-model/chip/color-control-cluster.xml

This can't be done until https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/6174 and https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/6251 are fixed.

"HueAndSaturation" is correct. That's the mode, which uses BOTH values at the same time. The / doesn't mean "Or", and there is no value making it an "Or" now. If anything, it changes the meaning from the spec and common understanding of color models


Added interweave function

Something I needed because map2 discards remaining elements if the lists aren't of equal length.

:+1:


Open at specific month

I use this library as a date range picker. When user select the "from" date much in the past (say 5 months ago), I would like the "to" picker to open at the same month as the "from" value. Currently, the default view shows the current month.
Is this possible?

Hi @pedrokost, this is actually possible because the directive does not listen updates on stat-date. Anyway this could be an interesting feature!

Done! This will be available in the next release, a plunker will follow.

Latest release v0.9.8 is now out.

Check this sample out.

@indrimuska Fantastic!


Set Up Business Rules for Determining Equipment

Tutorial URL: https://developers.sap.com/tutorials/cp-starter-ibpm-employeeonboarding-2-businessrules.html
Please specify the step you are referring to
Step 2 when import Equipment Determination Rules,
An error has occurred. Contact technical support.

My issue is not getting resolved after multiple tries and login/logout. PLease help. It's the same issue at this exact step.


Conformance results for v1.0/IBM Cloud Code Engine

Title

Vendor
IBM Cloud

Product Name / Version
Code Engine

Website URL for Product
https://www.ibm.com/cloud/code-engine

Contact
@norman465 or @smoser-ibm

/hold
It sounds like there are some patches to the conformance tests where the tests are checking specific values rather than acceptable ranges; the author will be back from break in a few weeks and can describe more then.

There is a bug in the list here: https://github.com/knative/specs/pull/94#issuecomment-1128792111
The following tests listed as "Active Tests" should actually be excluded, not included:
TestConfigMapVolume
TestSecretVolume
TestProjectedSecretVolume
TestProjectedComplex
TestProjectedServiceAccountToken

Some description on what we did, for the upcoming discussion in the Conformance team call:

We ran the two commands as layed out in https://github.com/knative/specs/blob/main/docs/examples/serving/cloud_run.md

go test -v -tags=e2e -count=1 ./test/conformance/api/v1/ -disable-logstream=true -test-namespace=qbe92h708ww -alt-test-namespace=qbe92h708ww -tls-test-namespace=qbe92h708ww -namespace=qbe92h708ww -resolvabledomain=true -disable-optional-api=true > ~/conformance-test-api-test.log

go test -v -tags=e2e -count=1 ./test/conformance/runtime/ -disable-logstream=true -test-namespace=qbc7im9tdc5 -alt-test-namespace=qbc7im9tdc5 -tls-test-namespace=qbc7im9tdc5 -namespace=qbc7im9tdc5 -resolvabledomain=true -disable-optional-api=true > ~/conformance-test-runtime-210722.log

That doesn't work out of the Box, because some values are hardcoded in the test

https://github.com/knative/serving/blob/main/test/conformance/runtime/cgroup_test.go requires certain values in
config-defaults, where Code Engine deviates from. But the test is not configurable
https://github.com/knative/serving/blob/main/test/conformance/api/v1/resources_test.go is setting hardcoded resources that are in conflict with the validating-webhook-serving that we run in production, and again the test is not configurable
(FWIW, for us to change these in production would have had customer impact, which seems unreasonable)
The resources have nothing to do woth the API that's under test IMHO, and we believe that we should be able to configure the tests via a flag or config setting.

Furthermore, the test requires A LOT OF rights when running it on K8s. Without having had a deeper look into it,                        it's not clear to us why the tests OOTB need such a lot of access to the resources and what is supposed to be checked with that.

Error from server (Forbidden): replicationcontrollers is forbidden:
Error from server (Forbidden): statefulsets.apps is forbidden:
Error from server (Forbidden): horizontalpodautoscalers.autoscaling is forbidden:
Error from server (Forbidden): cronjobs.batch is forbidden:
Error from server (Forbidden): jobs.batch is forbidden:
Error from server (Forbidden): domainmappings.serving.knative.dev is forbidden

It those access rights would not be needed, we'd be some steps closer to run the test as a regular user and thereore make it more reproducible

Allowing for these kinds of values (e.g. cpu, memory limits) to be set priory to ensure these are predictable for the test makes sense to me. @smoser-ibm do you want to put together a PR to how you envision this to be implemented?

@norman465 ^^

@mchmarny I'll open a PR in the next few days to allow for custom resource specification for conformance tests that need specific resource specifications in order to verify settings (I'm aware of resources_test and cgroup_test). This would allow a deviation from the defaults in config-defaults.

@evankanderson @mchmarny
I finally re-ran the conformance tests based on a v1.8.0 knative using these commands:
go test -v -tags=e2e -count=1 ./test/conformance/api/v1 -disable-logstream=true -test-namespace=vaw30wzxpbk -alt-test-namespace=vaw30wzxpbk -tls-test-namespace=vaw30wzxpbk -namespace=vaw30wzxpbk -resolvabledomain=true -disable-optional-api=true -custom-memory-requests=500M -custom-memory-limits=500M -custom-cpu-requests=125m -custom-cpu-limits=125m

go test -v -tags=e2e -count=1 ./test/conformance/runtime/ -disable-logstream=true -test-namespace=vaw30wzxpbk -alt-test-namespace=vaw30wzxpbk -tls-test-namespace=vaw30wzxpbk -namespace=vaw30wzxpbk -resolvabledomain=true -disable-optional-api=true -custom-memory-requests=500M -custom-memory-limits=500M -custom-cpu-requests=125m -custom-cpu-limits=125m

Additionally, I opened https://github.com/knative/serving/issues/13465.

/assign evankanderson

/lgtm
/approve
Verified that all the tests listed in this comment are PASSING.

/lgtm

/hold cancel


nixos/captive-browser: set chromium's data-dir to a XDG-compliant location

Motivation for this change
To quote the XDG specification:
 There is a single base directory relative to which user-specific
 data files should be written. This directory is defined by the\
 environment variable $XDG_DATA_HOME.

Rather than adding another directory to $HOME, I think that it's better
to follow this standard to avoid a cluttered home-dir.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Probably it is time to refactor the browser option
For example, it is difficult to replace chromium with google-chrome as it would require replicating of all the command line args (and changes in the default value like this PR are to be replicated to all the places where the option does not resort to its default value)
There was a lot of critics and proposals in the initial PR.

This PR has been open for a while now and is IMHO a valid improvement -> merging for now. Also I'm using this change for a few weeks now without any issues.
I'll keep your suggestions for improvements in mind, I actually have (pretty unstable) draft in my git-stash since I wanted to add support for networkd with udhcpc for captive-browser. Will probably file a PR for this during the next weeks :)


New Paper Adding

Hi,
Here is our new CVPR 2020 paper "AdversarialNAS: Adversarial Neural Architecture Search for GANs"
Paper Link: https://arxiv.org/pdf/1912.02037.pdf
Code link: https://github.com/chengaopro/AdversarialNAS
Type is gradient-based.
Thx!

Cool, added.


bulk.query end event

is there an event that gets fired when all records are streamed ? "record" events get emitted for each record, I need something that tell me that all records were returned.
I am using these 2 events-
conn.bulk.query(soql)
.on('record', function(rec) {}
.on('error', function(rec) {}
I tried ,
.on("response", function(rets) {}
.on('close', function(rec) { }
and did not work,

after some research , I found it myself-
it is on('end')
Adding here for the benefit of others.


[SYSTEMML-1619] Remove nightly builds link from download page

Removed 'Nightly Experimental Builds' section from download page which contained link to https://sparktc.ibmcloud.com/repo/latest/ as per Apache Release Policy at http://www.apache.org/legal/release-policy.html#what.

Kept nightly builds link in 'Latest code' tabs of setup at http://systemml.apache.org/install-systemml.html.

LGTM

Thank you Deron for review!  I'll merge and update svn.


Stupid Chat for Tidbyt

Send messages and pictures to your Tidbyt from anywhere.
Visit https://stupid.chat and click Get Started.  You will be assigned a random, unique token for your Tidbyt. Configure your stupid.chat token in the app to link the website to your device. Having done so, you may send messages or images from the stupid.chat website to your Tidbyt.  Tokens are free, you can always visit stupid.chat and generate a new one.

recheck

I have read the CLA Document and I hereby sign the CLA


Pruning image classification models (mlp_mixer)

Thank you for your project. I noticed the presence of the mlp_mixer models in the project. I am curious if sparsification has been implemented on this model or on other image classification models.

We did not evaluate the mlp_mixer model in our experiments. It was there likely due to inheritance from the repository we are borrowing https://github.com/facebookresearch/dropout.


Draft: Feat:transformer factory

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] All commits are signed-off.

Added prototype of transformer factory and associated classes.

Could we eliminate Results class and use AssessmentResults instead?


Support for DPS5015 and CC+CV mode (CurrentLimit)

Hello. I made support for DPS5015. And now it almost usable.
Also CC + CV mode (as in original DPS firmware) which is userful in many cases. I didn't made changes for binary protocol support, but I made full support in text protocol. As for now there are few new commands:
cc - CC mode
cv - CV mode
cl - Current Limit mode (CV unless current less than setting, else CC mode)
u - set voltage (instead of v command)
i - set current
I changed stat, and now it showing complete state.
Also I moved coefficients and offsets for ADC and DAC (only for current yet) into dps-model.h to support different shunt. And described formulas to calculate factor and offset;
Also I added software debounce for power enable button.
I need your help with mode image, I bithacked CV image, to make a little bit different image, because I have no idea how to cook this images.
As for now I have not fixed LCD hanging yet. But as temporary hack I make reinitialization of LCD in "on" CLI command. I will try to fix is this problem.

Do you know if these changed are compatible with the DPH3205? I've been thinking about adding support for it, but I can't really wrap my head around it. How did you go about to add support for the DPS5015, schematic and test?

BTW, Why have you changed all (de facto standard) \n to \r\n (and in some cases to \r)?

All terminal apps, which I ever used do not do carrier return on \n. When I writing unix apps, I always using \n, but for serail ports it is not working for me, and I using \r\n. I not happy with it, but without \r it is looks unusable :)

I have no idea about DPH3205, I have no such device. But you can try :)

Usually terminal programs has configurable line endings... You should find better terminal emulator - for example putty :)

Now I believe that I fixed LCD freeze for DPS5015.
Rolled back \r\n to \n. I found way to use \n EOLs in minicom.
Fixed default device to DPS5005.
Can anybody help me with CL image (like CC and CV at the bottom of screen)?

Also I found a bug which occur only sometimes. When I push to encoder selected value is decremented by 1. Can anybody confirm this bug?

@cleverfox I can fix the CL image for you. I have never observed the encoder bug though.

@kanflo Thank you. I need .h file for "cl" image. As for now I not commited it yet, but it used in sources.

Hello, guys. I made calibration voltage ADC and DACs for my DPS5015. Also I added example of calibration calculations inside dps-model.c for reference.

Question: is configuring this from the device UI supported or do you need to send commands over serial?

I might send an e-mail to cleverfox since I encountered issues with the master branch for the 2.3 PCB version of the 5015. Will be testing the cc branch now. How much of this is merged into master or expected to be?

Everything from the cc branch is scheduled for merge to master. Obviously that did not happen last month so I am hoping for December. I need to get my AAduino Zero crowd funding project launched first.
Out of curiosity, how do you identify your DPS5015 as "2.3"? I have not seen any silk screen markings on my '5005s.

@roger- I believe this is only supported through the text protocol, if memory serves me well...


Gauging interest in doing a large-scale code change migrating everything from Lints -> CertificateLints

In https://github.com/zmap/zlint/pull/699 I introduced the ability to have more than just certificate lints. I now want to finish off this migration by moving all the existing lints to CertificateLints.
The next step will be fully removing the Lint interface, which is potentially a more contentious move since it might break lints folks have already made.
Do we have any concerns with doing the first part of this?

Makes sense to me.

Agreed on the last count. I've written a small tool to convert all the lints to CertificateLint in this project. I can imagine that being useful for folks who have built their own lints separately.
The decision to remove Lint/RegisterLint will be up to the maintainers here.
When I introduced the CertificateLint/RevocationListLint, generics wasn't officially "ready". Maybe before any long term decision is made, we can potentially look into generics for these lints again too?

Migration from lint.Lint to lint.CertificateLint via your tooling is fairly straight forward, and (as you've said) the real issue is how/when/if to remove the lint.Lint interface altogether.

...we can potentially look into generics for these lints again too?

Presuming that that this would be considered during the removal of lint.Lint then it makes sense as it is certainly a breaking change for library consumers. So bundling the consequences together would help reduce friction overall.


Use data.adobe.io for Entity Examples

@asteed's namespace sweep (#179) has produced a couple of interesting findings:
https://ns.adobe.com/entities/address/123
https://ns.adobe.com/entities/geo/111
https://ns.adobe.com/entities/geo/circleid123
https://ns.adobe.com/entities/geo/potsdam
https://ns.adobe.com/entities/geo/shapeid123
https://ns.adobe.com/entities/geo/tokyo
https://ns.adobe.com/entities/identity/1233ce17-20e0-4a2c-8198-2a77fd60cf4d
https://ns.adobe.com/entities/identity/2394509340-30453470347
https://ns.adobe.com/entities/identity/92312748749128
https://ns.adobe.com/entities/identity/id123
https://ns.adobe.com/entities/namespace/11112
https://ns.adobe.com/entities/namespace/12345
https://ns.adobe.com/entities/namespace/33333
https://ns.adobe.com/entities/namespace/4

We should use data.adobe.io as the domain name, as we do in other examples.

Fixed as many of these as I could find as part of PR# 197

@kstreeter @trieloff any issues with PR #197 ? I believe there are a few remaining items once this gets merged

I'd prefer to keep the ns/data changes separate from the name/code change.

@trieloff @cdegroot-adobe I've created a separate PR #207 for addressing the ns/data issues initially listed in the issue.


Clean up embedded python libs when Agent installation changes

What does this PR do?
Remove all custom python modules on upgrade
Tested on Ubuntu and Fedora

This is a pretty big change in behavior. Do we have a plan on how to make sure our customer are warned before upgrading ?
cc @olivielpeau

Agreed, before merging this we need to decide on a plan on:

how to test this change thoroughly on the deb and rpm packages (fresh install, upgrade from v5, upgrade from earlier v6, downgrade)
how to advertise the change to our users, since as you wrote it's a significant change in behavior

The current solution removes previous content of lib/python2.7 before installation

Works for upgrade
Doesn't do anything for uninstallation: leave all the custom libs there
On installation, first or after an uninstallation, clean the libs

It works but it could be better to remove libs when uninstalling

As an alternative, we can keep track of all the files we explicitly install somewhere and then remove all the other files.
Pros:

Cleaner
We would be able to remove all the custom libs on uninstallation
Cons:
less simple than doing rm -rf
Be careful of which list we use when we change the packages we ship

Closing this in favor of https://github.com/DataDog/datadog-agent/pull/2161


Implement delay command for BMP180 peripheral pressure function

@polfeliu here's a preliminary commit.
There are still some issues to reconsider in this implementation, as with the BMP180 pressure function using a delay, it cannot 'return' the pressure variable in the same way. So for Espruino as an example, there needs to be some manner to implement a callback.
For the generic embedded case, there also needs to be a delay callback that is added to the methods to get that back. Also there isn't any time delay implemented at all, as it can vary wildly. So that is going to require more thought.
For the Kubos impl, I think the time.h import should go in the header file rather than the source file. That's a simpler fix.

Add JS support for delays. I've added a name field to a delay in order to use it to name the callback that is required. This will not work for nested delays, nor will it work for more than one delay. Any other callback won't work either. But for the BMP180 this implementation will work.
Embedded C & Kubos changes are next.

I've added the embedded c callback, which is highly abstracted such that you can plug the callback into your custom scheduler as a function pointer. The BMP180.c example shows how the callback is executed.
This still has some issues with regards to variable declarations, because the callback looks for local variables which are not defined.

How do I save variables from the first function and allow you to plug them into the second? If the first function returns a function pointer, there is no more external content sent back.
Going to consider returning a struct which can contain more than one variable of more than one type.

I've moved to a struct architecture for callback state to embedded C, which is going to be more scalable and easier to pass into the callback.

@polfeliu I don't know if you have any more thoughts about the delay spec structure. There are a few examples in this commit for how it will look on different platforms. I'll keep this PR open a bit longer to see if there's any discussion to be had before merging, as this is a bit of a significant change.

Looks good! I look forward to create my own template for stm32 & FreeRTOS

Merging in with some last-minute improvements.


fix: Remove need for noExternal "three" and clean up imported classes as types not values

This will be a much nicer setup

This is great! I'd recommend that we should probably handle the "check" part of the issue you opened before merging this, otherwise another contributor could submit a PR that forgets a type import, and without any CI checks it would then cause any Sveltekit apps to break upon release, correct?

They won't break. It will just spit out a warning that there's an unused import, which is how I found which ones to fix


Missing Examples in REST API Documentation

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
The example response and response schema is missing for some of the code samples in the Enterprise administration Admin stats REST API documentation. For example<EMAIL_ADDRESS>What part(s) of the article would you like to see updated?
Example response and response schema should be added for all the code samples at<EMAIL_ADDRESS>Additional information
No response
### Tasks

@natashamm Thanks so much for opening an issue! I'll triage this for the team to take a look :eyes:

DevOps/mmu094.travis/DevOps/mmu094.travis


B-522 feat(traefik): Add CORS configuration as Traefik middleware

Motivation
I've got a request to configure CORS for the API.
Solution
I use Traefik middleware to inject cors headers. The solution was tested on stage:
curl -i --location --request POST 'https://signup.stage-crypto.worldcoin.dev/insertIdentity' \
      --header 'Content-Type: application/json' \
      --data-raw '[0, "0x0000000000000000000000000000000000000000000000000000000000000000"]'
HTTP/1.1 200 OK
Access-Control-Allow-Origin: *

curl -i --location --request OPTION https://signup.stage-crypto.worldcoin.dev/
HTTP/1.1 500 Internal Server Error
Access-Control-Allow-Origin: *

The OPTIONS request on root context should return an empty body 204 response instead of 500. I think this should be handled on the application level.
https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS
PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Updated the changelog

Codecov Report

Merging #111 (bdc912b) into main (c7e3fa4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   39.57%   39.57%
=======================================
  Files          14       14
  Lines        4725     4725
=======================================
  Hits         1870     1870
  Misses       2855     2855

Flag
Coverage Δ

test
39.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7e3fa4...bdc912b. Read the comment docs.


Use system libraries on linux

With https://github.com/tangrams/tangram-es/blob/master/CMakeLists.txt#L6-L7 I see there is a way to use system libraries in the CMake file, but I can't find any documentation on this, or what options to pass make, because there's another level of indirection there.

Hey! I've added this option to speed up compilation during development. Yeah, we should also document it for also others. You can pass cmake options through the Makefile with
CMAKE_OPTIONS=" -DUSE_SYSTEM_GLFW_LIBS=1 -DUSE_SYSTEM_FONT_LIBS=1" make linux
Or use cmake without the convenience Makefile directly
cmake ..  -DPLATFORM_TARGET=linux -DCMAKE_BUILD_TYPE=Release \
 -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -DUSE_SYSTEM_FONT_LIBS=1 \
 -DUSE_SYSTEM_GLFW_LIBS=1

I'm preparing a PR to add the GL and font library documentation to the linux part of the readme.
What about other libraries like variant? This can also be a system library. I'm not sure what the status is on Ubuntu is, but it's in Debian stretch and will make it to Ubuntu if it's not already there.


Correct placement preferences example

File: compose/compose-file/index.md, CC @gbarr01
This should be:
version: '3.3'
services:
  db:
    image: postgres
    deploy:
      placement:
        constraints:
          - node.role == manager
          - engine.labels.operatingsystem == ubuntu 14.04
        preferences:
          - spread: node.labels.zone

Because: https://github.com/moby/moby/pull/32743

Thanks for the issue report!  Clarifying a bit: the issue is that placement preferences weren't supported until compose version 3.3, whereas the current example specifies version  3.

That's right.


More branding updates for Purview

Docs Build status updates of commit 7e9d9e9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/New-Label.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-Label.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


pythonPackage.python-crontab: init at 2.5.1

Motivation for this change
Add pythonPackage.python-crontab to nixpkgs
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[X] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 103970 1

3 packages built:

python27Packages.python-crontab
python37Packages.python-crontab
python38Packages.python-crontab

Result of nixpkgs-review pr 103970 1

3 packages built:

python27Packages.python-crontab
python37Packages.python-crontab
python38Packages.python-crontab


Invalidate bitmap when view size is changed

This change fixes a bug on Android where the SVG would not be redrawn when the SvgView size changes but the React props did not.
For instance, when a <Svg style={{ width: '100%', height: '100%' }} /> is contained within a View that can dynamically change sizes.

Thanks for this!


[broker][monitoring] add per-subscription EntryFilter metrics

Fixes https://github.com/apache/pulsar/issues/16596
Motivation
add per-subscription EntryFilter metrics for PersistentTopic and NonPersistentTopic.
Modifications
Add the following metrics to Prometheus:

pulsar_subscription_through_filter_msg_count
pulsar_subscription_filter_accepted_msg_count
pulsar_subscription_filter_rejected_msg_count
pulsar_subscription_filter_rescheduled_msg_count

Add the following metrics to admin-api:

throughEntryFilterMsgs
entryFilterAccepted
entryFilterRejected
entryFilterRescheduled

Documentation
Check the box below or label this PR directly.
Need to update docs?

[x] doc-required
(Your PR needs to update docs and you will update later)

[ ] doc-not-needed
(Please explain why)

[ ] doc
(Your PR contains doc changes)

[ ] doc-complete
(Docs have been already added)

@eolivelli @michaeljmarshall PTAL

@michaeljmarshall many thanks for you review! I've resolved all the suggestions, PTAL

@tjiuming - thanks! Do you feel strongly about keeping Msgs in the admin stats output, or can we change it to MsgCount? I like the latter because it matches the prometheus metric exactly then.

@tjiuming - thanks! Do you feel strongly about keeping Msgs in the admin stats output, or can we change it to MsgCount? I like the latter because it matches the prometheus metric exactly then.

it makes sense, and I've resolved them

Thanks @tjiuming! Great work!


Advanced Express - Inconsistent naming of user/username based on local/github Auth type

Describe your problem and how to reproduce it:
In doing the Advanced Express challenges I discovered there are some inconsistencies in the creation of a new user in the local vs. github.  For the former, the user name is stored in the DB as username for the latter it is stored as name.
Relevant sections of code from routes.js:
 myDataBase.insertOne({
                username: req.body.username,
                password: hash
              },

And from auth.js:
 $setOnInsert:{
            id: profile.id,
            name: profile.displayName || 'John Doe',  // <--  This should be username
            photo: profile.photos[0].value || '',
            email: Array.isArray(profile.emails) ? profile.emails[0].value : 'No public email',
            created_on: new Date(),
            provider: profile.provider || ''
          }

Assuming that they are supposed to be equivalent, the field names should be the same.
This was mainly a problem for me when I got to the "Announce New Users" section because I initially couldn't figure out why I was getting undefined from console.log(user ${socket.request.user.user} connected); with a local user.
My thought is to standardize on one or the other and then propagate the change through all of the exercises.
Add a Link to the page with the problem:
https://www.freecodecamp.org/learn/quality-assurance/advanced-node-and-express/announce-new-users

Hello again,

initially couldn't figure out why I was getting undefined from console.log(user ${socket.request.user.user} connected);

Why did you think to search for user within socket.request.user? The code socket.request.user.name is given.

There should be no issue with local vs github, because only the github auth route is setup to direct to the /chat endpoint. Campers are welcome to refactor (and I did when I was testing), but all sections will need to be refactored.
As for standardising this:

There was some discussion/mention of it: https://github.com/freeCodeCamp/freeCodeCamp/pull/39080#issuecomment-674151353

Socket.io is only set-up to work with the GitHub auth routes. Should we refactor in any way to include the /login and /register routes. NOTE: This is not trivial, as Socket.io is setup to expect the user object from GitHub, which is structured differently to the user object from the app.

... it's probably fine to have Socket.io only work with the GitHub auth for now. That's how the original project was structured, and it would take a bit too long to refactor the project now. While it might be something to consider in the future,...

So, I suppose now could be a time to consider it.
Perhaps, I will leave the point for someone with more experience to weigh in on having separate tables for separate registration routes. @scissorsneedfoodtoo ?

Here's the thing:
We're making a chat client, right?  In order to test this we need to connect multiple "users" to the client to see if the messages get sent out.  I only have one GitHub account and I'm not about to make a second one just to test this.  While I CAN log in multiple times from the same account then all I'm seeing is my name sending chats.  The UI we make doesn't differentiate between local-to-the-client messages and came-from-the-server messages.  I'm not even sure it could, without a unique message id?  It seemed logical to me that I should log in with some "local" users in order to test it.
But putting aside the chat aspect of this, it's just good design sense to have a standard set of fields for a user.  If we were to have a "Hello {{username}}!" field elsewhere on the site it would "break" depending on which auth was used.
Honestly, it would probably be better to have a Mongoose Schema for the user, but is maybe overkill for this type of app.
“Practice like you play, because you will play like you practice.”

I agree with @SaintPeter , maybe having a Mongoose Schema for the user would clarify this point. As I was working through the Social Authentication exercises, I was also wondering why the exercise didn't involve a Schema (like the previous node section). It would help the learners keep things consistent.
My fix for the situation was just to add an additional property to $setOnInsert:
username: profile.username || 'No username',
This ensure that at least the Local and Social Auth have the same username reference point, either as the Github username (which will be familiar) or the registered local username.

Thank you for reporting this issue.
This is a standard message notifying you that the issue has become stale, so we are going to close it.
If you think we're wrong in closing this issue, please request for it to be reopened. Thank you and happy coding.


[SMALLFIX] Use static imports for standard test utilities

Use static imports for standard test utilities

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/16776/
Test PASSed.


[ADH-4363] Add SSM principal holder and Spring Security support

Added the SmartPrincipal class providing information about the current logged-in user and the SmartPrincipalHolder  for accessing and setting principals
Added Spring Security support to the smart-web-server module
Added the SmartPrincipalInitializerFilter to inject Spring principal to the SmartPrincipalHolder

@arenadata/java


Check if struct is viable

Right now we don't have any kind of check to see if the offsets are valid. The offsets could collide.

This is automatically checked by the overflow guarantee of Rust. The error message is now a bit ugly, see: https://github.com/etra0/lazy-re/blob/67292400726f987bbbafec023fe089e02026e7ae/tests/ui/invalid-offsets.stderr#L1-L7 so I'll keep this issue open until we manage to write something more understandable.


edited python script to seed test user into database

Purpose
Seeds a test user account into the database to save dev's having to create a new account each time they bring up the containers
Checklist

[ ] I have performed a self-review of my own code
[ ] I have added relevant logging with appropriate levels to my code
[ ] I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
[ ] I have added tests to prove my work
[ ] The product team have tested these changes

Coverage increased (+0.6%) to 76.55% when pulling 6438caa8dd456f8097039fb67e5a0c3d7cba6a88 on seed-test-user-account into a3e0705cb8314f70d6369b0ca61f351829303e46 on master.

Just tested login in the UAT env - it works! Horray!


Versioning

We need to create a versioning system that will allow us to track the changes made in each rendition of our code. While we have done a manual system within the code itself in the past where we manually edit the version number, it would be better if we had it so that either Eclipse or Github automatically increments the version number every time a milestone is reached. This could be at each commit, pull request or main branch merge.

git tags http://git-scm.com/book/en/v2/Git-Basics-Tagging may be a great
way to (or at least help) establish general version numbers in the source.
As far as getting that data into the code, doing a system call to git describe displays tag version and the specific git commit hash. One
pitfall I see is that the robot may not have git binaries installed- I'm
totally unsure whether it does (not).
On Wed, Jan 28, 2015 at 2:10 PM, Tarkan Al-Kazily<EMAIL_ADDRESS>wrote:

We need to create a versioning system that will allow us to track the
changes made in each rendition of our code. While we have done a manual
system within the code itself in the past
https://github.com/Spartronics4915/2014-Aerial-Assist/blob/master/ArcadeDriveRobot/src/org/usfirst/frc4915/ArcadeDriveRobot/Version.java
where we manually edit the version number, it would be better if we had it
so that either Eclipse or Github automatically increments the version
number every time a milestone is reached. This could be at each commit,
pull request or main branch merge.
—
Reply to this email directly or view it on GitHub
https://github.com/Spartronics4915/2015-Recycle-Rush/issues/23.

Addressed by pull request #26.


Dollars to Cents: Javascript version

Make sure that you get this subproject assigned to you before working on it
create a java-script version of dollars to cents
Converting dollars to cents would enable you to practice your fundamental knowledge of programming. Loops, if conditions and a simple algorithm will be used.
Your task is to let the user input a dollar value (float), assuming that it can also accept extra cents (ex. $2.75), and convert it into an integer (in this case, if $2.75 = 275). After this, convert into coins with the sub-type of dollars: penny, nickel, dime and quarter. Use an algorithm that would divide the dollar value to the four coin types, and output few coins as possible.
The challenge: Try this without using any frameworks.
(EX. If you have $0.58, I would have 4 coins: 2 quarters, 0 dimes, 1 nickel and 3 pennies)
User Stories

[ ] User can enter a dollar value
[ ] User can see the total cents from the converted dollar value

Bonus features

[ ] User can see how many were pennies, nickels, quarters and dimes from the total cent

Useful links and resources

Math functions
Loops and iterations
Money values in JavaScript

Example projects

Dollars to cents converter

Hey, I would like to contribute to this issue.

can I work on this?

Hey, I would like to contribute to this issue.

sure go ahead, the project folder is on 1-Beginner -> dollars_to_cents. create js folder and add you files inside the js folder.
if you are adding any images make sure it goes into the .images folder.
good luck

Alright 👍

#46 Added PR please check!


why the task keep running?

hey there,
i create a simple task(using version 0.8),why the task keep running again and again?

Marathon is for long running tasks only. It will always try to keep the configured number of instances running. So if your task finishes, Marathon sees that there should be 1 instance running, but there is none and will start a new one.


Upload startup funds / depreciation policy document

Thanks for tracking it down! Done!

Of course, the document got revised after we uploaded it. 🥲
Might also be useful to include this table.

PhD_Startup Spring 2022 RVSD 08.2022.pdf

Decided to replace the pdf with a link to the corresponding SharePoint. @ulysses4ever agreed to update the website

A stab at that: #18

Merged the above


Video SFU / Conferencing

While developing the video chat solution in peer.school it turned out that multi-peer streaming is not practicable for a large number of participants due to bandwidth and performance (see #63). An SFU (Selective Forwarding Unit) was required that would receive participants video and audio streams and forward those the the participants, reducing the numbers of connections a client has to handle.
The current implementation uses Jitsi for this purpose: https://github.com/jitsi/lib-jitsi-meet
Other solutions might also be worth considering, like mediasoup:

https://mediasoup.org
https://github.com/versatica/mediasoup
https://github.com/mkhahani/mediasoup-sample-app

This should also fix related issues like #65 #34

In addition these might also be possible candidates:
https://github.com/meetecho/janus-gateway
https://www.kurento.org/
https://antmedia.io/

Some performance observations: https://webrtchacks.com/sfu-load-testing/
Another candidate seems to be medooze. Looks like there is an e2e encryted version under way https://github.com/medooze/sfu
In general privacy considerations should be addressed. See also #68

You could consider using multiparty meeting that is based on mediasoup. It scales better than jitsi thank to VP9 codec which reduces up to 40% the bandwidth requirements.
If you are looking to e2ee conference, there is the PERC project by IETF, but is still a draft.

Awesome, thanks @erotavlas-turbo for the details. Indeed mediasoup looks great. I removed the Jitsi feature anyway for now to strengthen the privacy and server-less features. PERC seems to be some time away from becoming a real world option with broad support in modern browsers. BTW, to experiment a bit more with multi user WebRTC scenarios I created a spin off that focuses on the video chat feature: https://brie.fi/ng

Maybe you are interesting at this: jitsi is working on e2ee conference.

Absolutely! Thanks for sharing the info @erotavlas-turbo

Finally, jitsi is actively working on VP9 support.


⚠ Community has degraded performance

In de788cf, Community (https://community.wrk.com/health) experienced degraded performance:

HTTP code: 200
Response time: 288 ms

Resolved: Community performance has improved in 94c3c58.


Loading in interpolated simulation extinction coefficient

We have access to flight data measuring extinction coefficient and this gives us another avenue for model-observation comparison. However, this flight data is on a significantly different resolution than the 2D grid of our simulation data. Thus, we will need to upload data that is already interpolated/ mapped onto the path of the flights. This interpolation was already done and saved to a csv, however this csv has a column for every simulation number. This will need to be reorganized as our current data structure dedicates one row to every simulation number.

@kgohil27 Can you list the column names currently in your csv with the interpolated simulation data?

@kgohil27 , Perhaps if the csv is not bigger than say 100Mb or so, you could just commit it to this repo.  Or,  upload to Azure or to the c3 jupyter notebook space.

@vasanchez16 Currently 121 columns contain interpolated data corresponding to each timestamp during the flight. These variables all have the following format -- ens_<ensemble #><ext. coeff stash code>
I can send you one of the files if you need, let me know

@kgohil27 Sounds good.  Please upload one of the files (are there more than 1?) to either this repo, or the shared c3 jupyter notebook space.


HTML should not be parsed with regex

The middleware's process_response method uses regex to parse the HTML response and inject content.
This is easily broken, leading to the content being injected in the wrong place or not at all.
I will open a PR with unit tests showing this.
See this stackoverflow post as to why parsing HTML with regex is a bad idea.

In fact, you are right.
In principle, I see two options here.

Go back to the tags, which force the user to explicitly specify where to insert the hijack code.
Use somthing like lxml to parse html. (And this approach has even more problems than the current one. Performance and safety.)

As far as I understand, the current approach was inspired by https://github.com/jazzband/django-debug-toolbar.
@matthiask @tim-schilling May I hear your opinions as django-debug-toolbar leaders on this, since a similar situation clearly affects django-debug-toolbar as well.

This logic predates my involvement with the toolbar. It looks like it was originally a version of str.replace, but evolved into a regex to parse it. Avoiding a dependency to inject the content ranks high on my priority list so that removes using an actual parser. Writing a parser is generally out too. The tag approach would be the next tool I'd reach for if this was causing issues for enough people.
I agree that it isn't the most robust approach, but it's been good enough for the toolbar for a few reasons:

Ease of installation. We already have 3 steps for installation (installed apps, middleware and urls). Adding one more would make the toolbar installation even more problematic than it already is for new devs.
We're parsing the document for a very limited scope of use. If we were manipulating the whole document, a parser would be required.
The tag we're looking for is pretty standard and cases of breakage should be solveable by the developer using INSERT_BEFORE.

Keep in mind those opinions are in regards to the django debug toolbar. django-hijack specifically could consider overriding the base admin templates and providing a template tag in the cases of people not using it or using a drop-in replacement.

Thank you for your participation @tim-schilling.
Actually, I don't know what we should do in this situation.
On the one hand I really like the simplicity of installation, on the other hand I see no way to solve this issue without using tags.
I don't even think we should consider the parser option.
It's too complicated and won't be worth the simplicity. We also have to pay for this simplicity with performance.
@codingjoe what do you think?
Maybe there is some other Django magic that would help us, but I don't know it.

Hi @LincolnPuzey,
Thank you for reaching out to us and addressing this. I do agree, this isn't a once size fits all solution and I do see scenarios where this might break. However, as mentioned by @Mogost, we blatantly stole the idea from django-debug-toolbar, probably the most popular Django package out there. I guess what applies to both packages, is that this bit of code is barley every executed on a production system. Again we only inject the notice, if a user was hijacked which by default only superusers can do. That does limit potential exposure to the problem you are describing.
However, yes, especially if you are running a side like stackoverflow, where users share HTML code, you may run into problems. But this is why this is based on a setting that can be adjusted. One option is to set it to something dubious that is unlikely or virtually impossible to guess, something like:
# key being creaded with secrets.token_urlsafe()
HIJACK_INSERT_BEFORE = "<!--// SUPER_SECRET_KEY // -->"

You now have one of two options, you may add this to your base template for the middleware to inject the notification or you don't and add the notification to your template yourself. Something like this:
{% if request.user.is_hijacked %}
<!-- Your custom notification or -->
{% include "hijack/notification" with request=request only %}
{% endif %}

Thanks for your thoughts on this everyone.
I didn't know the code was copied straight from debug-toolbar. However that only ever runs locally in DEBUG mode. I find it hard to trust a middleware that is totally re-writing the response HTML body in production.
My proposed solution would be to split the HijackUserMiddleware  class into two classes:

HijackUserMiddleware which just implements process_request to set the user.is_hijacked flag
HijackUserWithNotificationMiddleware which subclasses above and also implements process_response to inject the response.
bring back a standard template tag like hijack_notification which was previously in the library.

Then beginner users can simply use HijackUserWithNotificationMiddleware middleware for easy installation.
Or more advanced users that want a more robust setup can use HijackUserMiddleware and put the template tag in their base template.

Or, given that the process_request method is not doing much, simply bring back a standard template tag like hijack_notification that looks directly at request.session to determine if to show the notification.

@codingjoe @Mogost  Thoughts on this?

Hi @codingjoe,
You are making a valid point. However, we should also consider the security implications. The notification is a vital part, making sure that it is always visible is important, to avoid that users may perform unintended actions.
The template tag required users to add the tag to all templates. Yes, a base.html template pattern is common, but will all too often forget to add the notification to places like the admin or other 3rd party.
I personally do not share your concern about a middleware altering a request or response. That is quite literally what they are for, as described in the very first sentence here:

Middleware is a framework of hooks into Django’s request/response processing. It’s a light, low-level “plugin” system for globally altering Django’s input or output.

That aside, I still understand your concern, and we should address it properly. I don't believe we need a second middleware. Removing the first one, will achieve your goal. Yes, you won't have the user attribute, but following the general logic, we shouldn't fiddle with every request either, if not necessary.
Adding a template tag, as before seems a bit counterintuitive to me. A simple include should do. In most cases, I'd probably like to include a custom template as well.
Lastly, yes, we are running this code in production, not in debug mode. I agree, there is a difference. However, we do not alter all requests. We only do so for hijacked requests.
Anyhow, I really appreciate the discussion. I hope I am not being too defensive. This isn't as much about protecting our design decisions, as about keeping the code base small. I am pleased to see that a curious developer can understand the code base so quickly and discuss concepts. However, I also believe not everyone will take the time, investigate the inner workings of this package. And for those, I want to make sure we provide the best security possible.
I am on vacation right now, but I will try to find some time next week to write and test some documentation that implements you suggestions.
Best,
Joe

Thank you, @timnyborg, for opening up the PR. It doesn't change the regex implementation, though. In lack of a better solution, both for us nor debug toolbar, I will close the issue for. If someone has a new solution, I'd be happy to revisit this topic. Best Joe


a very badly named PR, almost as if gus wrote it

Add reaction perms

also we already have this...

I dont see it

dfeafbf5fabed59f916fd26a22e3f134e3e6346c

dammit git
y u be behind


fix Apache2 and BSD license issues

See

#41
#39

Some
          But

BSD-licensed
BSD licensed
BSD license
BSD licenses
BSD licensed
license BSD
licenses BSD
licensed BSD
dual-licensed BSD

These are license based, so can be added to the file by using look behind or forward regexp.
Funny thing about license/license US/UK
So we have to duplicate with license
BSD the OS, can also be found with slash
Linux/BSD
So maybe we will have to move terms with multiple meaning to a separate file
Originally posted by @ccoVeille in https://github.com/jargonLint/jargonLint/pull/39#discussion_r1666006064
          This one might cause problem with Apache2 being a web server.
          This one might need combination of license keywords and variations like BSD

Originally posted by @ccoVeille in https://github.com/jargonLint/jargonLint/pull/39#discussion_r1665979819

I don't think this is much of a problem really BSD the OS is not only increasingly uncommon, it's usually expressed in terms that won't coincide with this rule such as FreeBSD and OpenBSD.
On Apache, the webserver Apache 2.0 hasn't had a release in a decade, and as such, I don't think we need to consider it an issue. In the overwhelming majority of cases, Apache 2.0, will refer to the license.
(Note: This could also be a soft rule for the wider repository, that we don't feel the need to take into account decade old and unsupported software)

I agree with you about BSD.
For Apache2 webserver, I would say. we shouldn't touch it when we find it written as "apache2".
But there is no rush to add this one I think

Sure, Apache is not an often miswritten license anyway, unlike the creative commons licenses.

Can we close this? You added the relevant commit here, https://github.com/jargonLint/jargonLint/pull/41/commits/b3062b25779758fdcaa2316d302ef8a648b3a3a5

Can we close this? You added the relevant commit here, https://github.com/jargonLint/jargonLint/pull/41/commits/b3062b25779758fdcaa2316d302ef8a648b3a3a5

Not yet, the idea is to fix apache2 at some point.
I would like to open a PR, but as I said there is no rush about it

But we can merge as is for now.


Remove related pipeline logs during pipeline deletion

This PR ensures related pipeline logs are deleted as well during pipeline deletion. To clean up orphaned log entries, I have used the following query on my postgres db:
DELETE FROM log_entries
USING (
    SELECT l.id
    FROM log_entries l
    LEFT JOIN steps s ON l.step_id = s.id
    WHERE s.id IS NULL
) AS orphaned
WHERE log_entries.id = orphaned.id;

Disclaimer: I'm not responsible for any damage to your database, use the query at your own risk and make a backup before executing it.

To clean up orphaned log entries, I have used the following query on my postgres db

Shouldn't it be done by migration?

I would say no as it can be really (really) time-consuming on huge tables and would delay the server start massively. IMO adding a cli command to woodpecker-server like gitea has it with gitea doctor would be a better choice.

Thanks for clarification.
This is a bug. Bug in what feature? Could you link it here? If this feature was merged in next (not released yet, or RC counts?), then maybe there is no need in migration or tool.

The pipelineDelete API exists for a long time already, even in the last releases. So users that have used it already will have orphaned log entries in the db, and that's what I call a bug. Im going to mark this discussion as offtopic.

How/why users could/can delete pipeline without deleting related workflow entities?
How/why users could/can delete workflow without deleting related steps entities?
How/why users could/can delete step without deleting related logs entities?
Isn't there a bug in the database schema?
Shouldn't an option like cascade be in API instead of hardcoded behavior?

Can you put that logic into deleteStep?

How? DeleteStep does not have the storage client.

As I said the linked deleteStep method does not have access to the storage client. I have refactored it a bit. What do you think?


exec is super slow to run

Hello 👋
I have an issue with exec taking hours to execute.
Here is my table:
| CREATE TABLE "metrics" (                                             |
|   "id" integer not null primary key autoincrement,                   |
|   "translation_progress" real not null,                              |
|   "approval_progress" real not null,                                 |
|   "file_id" integer default null,                                    |
|   "file_path" string not null default '',                            |
|   "source" string not null default 'file',                           |
|   "hash" string not null,                                            |
|   "locale_id" integer not null,                                      |
|   "project_id" integer not null,                                     |
|   "created_at" DATETIME DEFAULT CURRENT_TIMESTAMP,                   |
|   FOREIGN KEY(project_id) REFERENCES projects(id),                   |
|   FOREIGN KEY(locale_id) REFERENCES locales(id)                      |
| )                                                                    |
| CREATE INDEX index_hashed_metrics on metrics(project_id, hash)       |
| CREATE INDEX index_locales_metrics on metrics(project_id, locale_id) |

It joins 2 tables with 100 rows for locales, and 24 for projects.
I'm running a test sql file with 1000s of delete, it's something taking 3s via the CLI but taking hours via db.exec https://github.com/WiseLibs/better-sqlite3/blob/master/docs/api.md#execstring---this  cf:
table-metrics.sql.zip
➜  server git:(feat/clean-metrics) ✗ du -sh table-metrics.sql
964K    table-metrics.sql
➜  server git:(feat/clean-metrics) ✗ time sqlite3 storage/db.sqlite < table-metrics.sql
sqlite3 storage/db.sqlite < table-metrics.sql  0.34s user 0.52s system 31% cpu 2.742 total
➜  server git:(feat/clean-metrics) ✗

Before using this flow, I was doing a db.prepare + run via a transaction or without and it was taking 800ms by id 🤯  with 109 382 ids to remove 🔥
Turns out, exec is just as slow 😢
But as doing it via the CLI shows us it's a bug as it's  possible to be done <3s.
What's weird is inside my process, I clean another table with 274 610 ids to 🔥 , and it's even faster via the CLI and there, exec works fine.
| CREATE TABLE "events_metrics" (                                      |
|   "id" integer not null primary key autoincrement,                   |
|   "metric_id" integer not null,                                      |
|   "event_id" integer not null,                                       |
|   "created_at" DATETIME DEFAULT CURRENT_TIMESTAMP,                   |
|   FOREIGN KEY(event_id) REFERENCES events(id),                       |
|   FOREIGN KEY(metric_id) REFERENCES metrics(id)                      |
| )                                                                    |

It joins the table events (135 689 items) and metrics (25 125 704 items). And this table contains 31 394 852 items.

Since the CLI is faster this most likely comes from a different configuration. E.g. the CLI does not have foreign keys enabled. Try disabling foreign key checks and see what happens.

I didn't think the config could be different 🙈
Yep I tried foreign_keys=0 but while it did improve the speed to be as fast as the cli today, it came with a 🔴  flag, database corrupted :/


Added finished() - issue #21

This fixes issue #21

Adding my :+1: for this, but would name the thing completed rather than finished. This to be symmetric with comple method and to be specific that it's finished and result available (as opposed to failed).

I like your idea for the name change. I'll make the change and push up a patch. Do bad benlau don't seem to be very active for asyncfuture.

@remster, I've updated the documentation and code with completed.


BAM to BW conversion has some bug.

Deletions in alignments do NOT represent 0 coverage.

Top 2 tracks are the bw files for the bottom 2 bams.

fixed


Fix go 1.23 + update go version in the CI

Closes #2660

The same macos tests are also failing in my PR, let's be sad together!


open edX: Set FROM address for bulk email to<EMAIL_ADDRESS>

Steps to Reproduce

Go to bulk email interface in LMS: example
Send a test email to yourself
View the from address of the email

Expected Behavior

The from address should be<EMAIL_ADDRESS>
Actual Behavior

The from address is something like<EMAIL_ADDRESS>
Related Issues

https://github.com/mitodl/ol-infrastructure/issues/327

this issue references settings that need to be set

This should be resolved. Can you confirm @briangrossman ?

@blarghmatey I tried to test, but it looks like it's not sending out messages... here's the queue

Yeah, looks like the issue is the switch to using the<EMAIL_ADDRESS>address as the FROM field. I have to register that as an identity in SES for it to allow it to send.

This should be working now. Relevant changes are in https://github.com/mitodl/ol-infrastructure/pull/349


Currency malformed on deserialization

Take a Currency object and do a serialization roundtrip. The resulting object contains only Code property value, the others are on default values:
var original = Currency.FromCode("CZK");
// Code CZK
// DecimalDigits 2
// EnglishName Czech koruna
// IsObsolete False
// MajorUnit 1
// MinorUnit 0.01
// Namespace ISO-4217
// Number 203
// Symbol Kč
// ValidFrom null
// ValidTo null

var str = JsonConvert.SerializeObject(original);
// "{"Code":"CZK"}"

var result = JsonConvert.DeserializeObject<Currency>(str);
// Code CZK
// DecimalDigits 0
// EnglishName null
// IsObsolete False
// MajorUnit 1
// MinorUnit 1
// Namespace null
// Number null
// Symbol null
// ValidFrom null
// ValidTo null

Using the deserialized result currency to construct a Money does not work well:
var m = new Money(123.45m, result);
// m.Amount stripped to 123

m.ToString();
// throws ArgumentNullException

It looks like a bug. Or am I missing anything? A Money object survives serialization roundtrip without any problems.
Environment:
.NET 6
NodaMoney 1.0.5
Newtownsoft.Json 13.0.1

I can't reproduce this behavior. I'm using the test below.
  var currency = Currency.FromCode("CZK");

  string json = JsonConvert.SerializeObject(currency);
  var clone = JsonConvert.DeserializeObject<Currency>(json);

  clone.Should().Be(currency);
  clone.Namespace.Should().NotBeNull();
  clone.Number.Should().NotBe(default);

You are saying the following properties after deserializing are null which is not possible, because they are structs.
// Number null
// Symbol null
// ValidFrom null
// ValidTo null

On my machine, that test fails on second assertion because of Namespace being null.
I think we're on different version. I use NuGet package NodaMoney 1.0.5 released on 29/8/2018 corresponding to commit 5ee1065. In that version, the Currency struct is marked with DataContractAttribute and it looks like Newtonsoft.Json is using that to (de)serialize Code property only. Maybe you test with master branch; it includes commit 3c0d3e0, in which some serialization changes were made.
Why couldn't those properties be null? Number and Symbol are strings, ValidFrom and ValidTo are nullable dates.


Generate navbar-logo.svg with different text

Is there a way to generate the src/assets/img/navbar-logo.svg with a different text?

The navbar-logo.svg file is just to demonstrate the use of an SVG within the navbar brand element. You would have to make your own SVG image. For reference, the demo image was made using the Kaushan Script font. Hopefully this helps!


Don't save: Add accelerator

When exiting Poedit after changing things in the .po file, the question to save changes comes up.
I pressed "n" out of my habit of answering such windows with the keyboard. May programs offer this, e.g. this one:

Maybe adding a & character in front of the "n" is enough to get it to work as an accelerator key.

Maybe adding a & character in front of the "n" is enough to get it to work as an accelerator key.

It indeed is. Pull request please?

Alright, challenge accepted! I’m working on a pull request.


Added debugging functionality.

Hi,
Not having the option to add breaking points for debugging has been bothering me for quite some time and I think it is unreasonable to have to install a completely new extension about this, so I took the liberty of adding them in the extension.
The implemented changes are trivial overall.

I guess this branch should be merged to master after the dependabot PRs.

Hi @GNikit and thanks for contributing.
The PR looks good. Maybe add some info in the docs (Readme.md) about how to use this feature and also which OS does it support?

Hi @GNikit and thanks for contributing.
The PR looks good. Maybe add some info in the docs (Readme.md) about how to use this feature and also which OS does it support?

So I think this is done, I updated the README, I also updated the way we define the debugger, there is no need to specify the type of the debugger cppdb in package.json. My first attempt was actually using a deprecated way of doing it.
However, I feel that I should mention this to make things clear.
The only thing that I have added is the ability to set breaking points in Fortran files, nothing else.
By adding the dependency on Microsoft's C/C++ ms-vscode.cpptools we can ensure that the users will have the underlying infrastructure to launch C++-like programs, Fortran falls under this category, through the Debug console of VS Code. So there is no explicit dependence of the extension on ms-vscode.cpptools.
I personally don't think that is an issue, but given how this is your extension I feel that I should let you know.


Pickles/dune: stop ignoring some warnings

Let's stop ignoring warnings step by step.
Explain your changes:
*
Explain how you tested your changes:
*
Checklist:

[ ] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

Closes #0000

!ci-build-me


Difference between telegram API layers

In Telegram API
In td_lib used 165 layer, in file MtprotoHeader.cpp used old object initConnection#785188b8
In telegram_api.tl used different object, initConnection#c1cd5ea9.
Сould this difference lead to bans, or some other issues?

No, this can't affect anything.


How to remove outline for Input component for web?

💬 How to remove outline for Input component for web?
UI Kitten and Eva version

Package
Version

@eva-design/eva
2.1.0

@ui-kitten/components
5.1.0

  <Input
    label="Input label"
    autoCapitalize="none"
    autoCompleteType="email"
    textContentType="emailAddress"
    keyboardType="email-address"
  />

Thanks.

I noticed this too. It appears to be a bug in 5.1. When I use 5.0 (and 2.0 for @eva-design/eva), it works as expected in web.

It looks like UI Kitten needs to set the accessible prop to false on TouchableWithoutFeedback here so it won't get outlined when tabbing. When I manually modified<EMAIL_ADDRESS>to set this prop, it worked as expected when tabbing. react-native-web will render a div with data-focusable="true" tabindex="0" by default for TouchableWithoutFeedback, but setting accessible={false} will result in a div without those attributes.
https://github.com/akveo/react-native-ui-kitten/blob/1403fdb993f2b6f3fb46fcddfddb185d5652883a/src/components/ui/input/input.component.tsx#L263-L265

Here are two fixes for the issue in the meantime:

Downgrade to<EMAIL_ADDRESS>(you will also need<EMAIL_ADDRESS>since its mapping structure works with 5.0)
Use patch-package to patch the @ui-kitten/components package in postinstall step. I used it to generate this patch:

@ui-kitten+components+5.1.0.patch:
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index 4f24771..52a4e89 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -173,7 +173,7 @@ let Input = class Input extends react_1.default.Component {
     render() {
         const { eva, textStyle, label, caption, accessoryLeft, accessoryRight, ...textInputProps } = this.props;
         const evaStyle = this.getComponentStyle(eva.style);
-        return (react_1.default.createElement(devsupport_1.TouchableWithoutFeedback, { style: evaStyle.container, onPress: this.focus },
+        return (react_1.default.createElement(devsupport_1.TouchableWithoutFeedback, { accessible: false, style: evaStyle.container, onPress: this.focus },
             react_1.default.createElement(devsupport_1.FalsyText, { style: [evaStyle.label, styles.label], component: label }),
             react_1.default.createElement(react_native_1.View, { style: [evaStyle.inputContainer, styles.inputContainer] },
                 react_1.default.createElement(devsupport_1.FalsyFC, { style: evaStyle.icon, component: accessoryLeft }),

Thanks for this!
I have noticed the tabindex problems too.  It is poor UX to have to hit TAB twice to move between fields.  This fix makes perfect sense, but unfortunately, it does not work for me!  I have the exact same version.  I tried the patch, then reinstalled and tried to manually edit the input.component.js file, re-ran yarn.  Still doesn't work!  I even removed node_modules and reinstalled from scratch, made the edit and restarted.  No love.
Any clue to why I cannot get it to work?  Must be a bundling or cache issue, but I cannot think of what it could be.
And since this little change breaks keyboard usability, I am surprised there is no patch release yet.

Hmm...if by "re-ran yarn" you mean you literally just ran yarn then that could yarn install the package again and override your manual change to input.component.js. Double check you still see the accessible: false prop you have to manually add in input.component.js after you run the app. If not, then something in your build/app start script might be overriding your manual changes.
You could also try to empty cache and hard reload to make sure something isn't being cached locally for expo bundle script. Open chrome devtools and then you can right click the "reload this page" icon and a submenu with "empty cache and hard reload" should appear.
Also, are you in a monorepo structure by any chance? Sub package folders can have their own node_modules folders if they reference different versions of any shared packages that are hoisted at monorepo node_modules root. If one package in the monorepo references a different version of UI Kitten, then you might not be editing the right node_modules path or you might need to edit multiple versions of UI kitten at different node_modules paths.
That's what I can think of off the top of my head. Good luck!

Thanks for the quick reply.  To be more clear:

I created a patch file before reinstalling ui-kitten and/or all
packages.  double check the patch was in place
I started from a fresh repo and manually updated the file with
"accessible: false"
I tried hard-reload
We are not using expo and we are using Parcel for bundling. ICIM
Was working perfectly with UI-Kitten 5.0 & eva 2.0.
Yes, I'm using a monorepo, and I am in the correct folder (for React
web).  I've also tried editing the version of the package in the
native folder,
but it did nothing, which is expected.
I know it is accessing the correct *input.component.js *because I can
make a change and see it when I refresh the browser.

The only thing left, I think, is the other packages.  Are yours different?
We are using:
react & react-dom 17.0.2
react-native-web 0.17.1
--Jerry
On Mon, Aug 16, 2021 at 1:24 PM Scott Schottler notifications-at-github.com
|git-73ry| @.***> wrote:

Hmm...if by "re-ran yarn" you mean you literally just ran yarn then that
could yarn install the package again and override your manual change to
input.component.js. Double check you still see the accessible: false prop
you have to manually add in input.component.js after you run the app. If
not, then something in your build/app start script might be overriding your
manual changes.
You could also try to empty cache and hard reload to make sure something
isn't being cached locally for expo bundle script. Open chrome devtools and
then you can right click the "reload this page" icon and a submenu with
"empty cache and hard reload" should appear.
Also, are you in a monorepo structure by any chance? Sub package folders
can have their own node_modules folders if they reference different
versions of any shared packages that are hoisted at monorepo node_modules
root. If one package in the monorepo references a different version of UI
Kitten, then you might not be editing the right node_modules path or you
might need to edit multiple versions of UI kitten at different node_modules
paths.
That's what I can think of off the top of my head. Good luck!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/akveo/react-native-ui-kitten/issues/1422#issuecomment-899795864,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAXRPEENE3X5WKIWG6QXADT5FXZTANCNFSM44EKFOUQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

Could be - we are on<EMAIL_ADDRESS>You could try downgrading to that version in the fresh repo you setup and see if the patch works. I don't think the react or react-dom versions would matter as much, but we're on 16.14.0

@1jerry @sschottler
I also came into this issue now (using<EMAIL_ADDRESS>and figured it out.
According to the react-native-web documentation it is necessary to set the focusable prop to false (e.g. with patch-package as suggested above).
The accessible prop is not implemented by react-native-web.

In my case, i added outline: 'none', outlineStyle: 'none' to textStyle to remove outline on safari


Fix cargo clippy warnings for ockam_transport_tcp crate

Fix cargo clippy warnings for ockam_transport_tcp crate
Ideally, right after fixing the warnings clippy should be enabled on CI for that crate to avoid new warnings in the future

Assigned to @mattjperez


chore: Switch from edx-sphinx-theme to sphinx-book-theme

The edx-sphinx theme is being deprecated, and replaced with sphinx-book-theme. This removes references to the deprecated theme and replaces them with the new standard theme for the platform.
Testing instructions:

Run make docs and see that the docs are generated properly and use the sphinx-book-theme

Hi @openedx/arch-bom - would someone be able to review this and merge if all looks good? Thanks!

:+1: Conditional approval, for when the unnecessary changes in the requirements/* files are removed.

[x] I tested this: ran make docs
[x] I read through the code
[x] Includes documentation

Hi @xitij2000 - just flagging the feedback here. Thanks!

@xitij2000 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.


Writer Assistant Write to a file

In the writer_assistant.py file, enhance the function by adding a parameter, code, which, when set to False, writes the content to a file. If set to True, it should write the content to a file with a .py extension.

Hey,
I've solved this issue since I find it's easy as part of JWoC and also meanwhile while I am working on the assigned issue.


automatic stitch after cube projection ?

it could be a great add if cube projection unwrap works a little like 3dsmax box mapping, and espescially don't smash all face and try to stitch them logically (ex : cube projection of 1m² on walls of a room)

manually here basics steps for a room :
3dview :

unwrap cube projection, cube size 2 (so as to obtain 1m² unwrap)
select a wall side (set active face > ctrl alt shift F)
switch to uv editor :
starting from active face : V
ctrl L to select all group face
V & repeat until all group is stitch

option to UVW by materials (so, needs settings with material list, one material = one UVW size)

UVW alrorithm is now included


GEOMESA-816 Adding configuration for z3 query threads

Signed-off-by: Emilio Lahr-Vivaz<EMAIL_ADDRESS>

Committed as 6ddddc8f080dae63ac783616778965076aa79505 on master.


Guarantied once delivery aka ExactlyOnce does NOT work when timeout is not explicitly provided

[ExactlyOnce(Timeout=30)] will ensure the message can only be handled within the first 30 seconds.[ExactlyOnce] should ensure message can only be handled indefinitely but it doesn't work as expected because timeout defaults to 0.

Fixed


Switch from the subset branch back to main

When I created these branches ~a year ago, I had lofty goals that we'd be able to turn on "everything" quickly enough that the subset branch would be short-lived and that main could stay faithfully tracking the "everything is included" world, but the reality is much messier.
In an attempt to be extremely pragmatic about the reality, my intention is to delete the existing (now extremely outdated) main branch and simply rename subset to main.  It will then organically grow to include "everything" as we've been doing (and eventually we'll even ditch subset.txt 🤞).

To be clear, this is an explicit Request For Comments -- I don't plan to move on this before next week at the earliest, and will hold as long as anyone has active concerns about doing so.

Your members will have to manually update their local environments. We'll let them know when they visit the repository, or you can share the following commands.
git branch -m subset main
git fetch origin
git branch -u origin/main main
git remote set-head origin -a


Display tweaks III

[ ] limit the precision of recipient performance in bar and line charts to zero decimal points (i.e. 89% instead of 89.0%). Text messages intended for and rendered in the email template should be the decimal point of precision. (Values included in the output message outside of the text message, if any, can also be one decimal point of precision; no such properties at present).

[ ]  add case count values for numerator and denominator to recipient performance in bar and line charts (all months of recipient bars, but only last three months of line chart) - looks like this is done for bar chart but not line chart

[ ]  remove chart title above bar chart and line chart

[ ]  remove axis labels "Performance Level" and "Time" from charts

[ ]  Rotate month labels on x axis to be horizontal

[ ]  change legend to display items in one row, horizontally, rather than a column or chart inset

[ ]  remove border around legend

[ ]  increase font sizes by 3 to 5 points or so

[ ]  display of the goal line should be limited only to bar charts, not the line chart

Check readme, needs format changes for github display

Legend border may be resolved by modifying frameon (bool, default true)

The increased font size looks great for the axis labels and legend, but needs to be dialed back for the performance levels appearing in the bars

Based on local testing of the 156-display-tweaks-iii branch, need the following:

[ ] move the legend to appear below the chart, centered based on the width of the chart
[ ] remove the decimal point for the performance level percentages
[ ] generate images with a blue background based on the background color of the existing email

[ ] in the bar chart only, remove the single decimal value of performance level percentage for comparator bars
[ ] in the bar chart only, decrease the font size of the numerator and denominator by 1 point for the recipient performance level
[ ] in the bar chart only, increase the font size of the percentage for recipient performance by about 3 points, depending on how much space "100" takes up, and increase font size of the comparator performance percentage to match the recipient performance percentage font size


Fix for Issue #242: before_filter does not retain and pass on the new…

… params object.

You have added a changed to the clause that handles the conn.halted == true case. I can't think of a scenario in which we would want this. Without providing either tests for the broken scenario, or at least an example of the problem, I have no easy way of inspecting the change.

@smpallen99 - I just reverted my mix.exs to point to your master - and everything seems to work. I suspect, it might have been an issue between the released version (0.8.2) and your master branch HEAD commit as of this point.
Since its working without my changes, I am going to delete my branch and close this issue.


The document is very ambiguous.

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4f2a0855-e451-65c6-2cf5-9525b688fa2e
Version Independent ID: 62324062-4a87-b494-d0e4-d15bbdf414f1
Content: Create NFS Ubuntu Linux Server volume - Azure Kubernetes Service
Content Source: articles/aks/azure-nfs-volume.md
Service: container-service
GitHub Login: @ozboms
Microsoft Alias: obboms

@TashikMoin Is there anything in particular you would like to see changed to improve the documentation?

@TashikMoin, your feedback has been passed along to the documentation team.  We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


What happens to preferredLocale on non supported browsers?

Does preferredLocale throw on an exception or are there fallbacks?

preferredLocale will not throw an exception and will fallback in various ways.
When checking for a client's supported languages:

It uses the window.navigator API on browsers, which is supported by all (>= IE 4) browsers
It uses the Intl.DateTimeFormat API on Node.js environments, which is supported by Node.js 0.12 and newer
If for some reason neither of these are available, it falls back to using the provided fallback locale as the users' locale

The main functionality makes use of Intl.Locale (Chrome 74/Firefox 75/Safari 14/Node.js 12 or newer). When this API is not available it will match the expected behaviour where possible.
The only difference in behaviour between an environment that supports Intl.Locale and one that doesn't is that unsupported environments will not be able to expand a locale that only has a language code to one that also has a region (e.g en to en-US) as the package does not contain a lookup table of all (~8,000) ISO 639 language codes to match the behaviour of Intl.Locale#maximise. This difference in behaviour is not present when the options.languageOnly parameter is enabled.
However, in reality this is not much of a problem as Intl.DateTimeFormat always provides a language-region locale on Node.js environments and browsers typically include both in window.navigator (e.g ['es-ES', 'en-US', 'es', 'en']) - I have not come across one that only returned a language code.

Wow thank you for this great answer. Good to know about Safari, we still have a ton of users using versions lower than 14, but navigator fallback should be fine (Safari is the new IE). That was going to be my original impl until I found your lib anyways.
Great work on this project!


[Documentation] Add Table to Display Repository Statistics in README.md

Is this a unique feature?

[X] I have checked "open" AND "closed" issues and this is not a duplicate

Is your feature request related to a problem/unavailable functionality? Please describe.
Issue Description:
The issue involves adding a table to display repository statistics, such as the number of stars, forks, issues, and pull requests, directly in the README.md file. This will help contributors and users track the activity and contributions at a glance.
Proposed Solution
Steps to Implement:

Create a table in the README.md file displaying the following repository statistics:

Stars
Forks
Open Issues
Open Pull Requests
Closed Pull Requests

Use markdown syntax to include badges or icons for each statistic.
Add dynamic links to the corresponding sections of the repository for easy access (e.g., link to the "Issues" or "Pull Requests" tabs).

Expected Behavior:
The README.md file will contain a neatly formatted table that displays real-time repository statistics, making the repository's activity more visible and engaging for contributors and users.
Screenshots
Screenshot (for reference):

Do you want to work on this issue?
Yes
If "yes" to above, please explain how you would technically implement this (issue will not be assigned if this is skipped)
No response

I have made the above changes and raised a pull request, please review it and merge the pull request


Set Site Collection readonly using CSOM

Category

[x] Question
[ ] Typo
[ ] Bug
[ ] Additional article idea

Ist there a way to set a site collection readonly in Office 365 using the SharePoint Client API as we know it from from Server API?
In the past we could just do:
public void SetReadOnlyState(string siteCollectionUrl, bool readOnly)
        {
            using (SPSite site = new SPSite(siteCollectionUrl))
            {
                site.ReadOnly = !readOnly;
            }
        }

This is not possible in CSOM. Furthermore Office 365 does not have a possibility to set a site collection read only at all. On premise we can use:
Set-SPSite -Identity "<SiteCollection>" -LockState "<State>"
and set it to Unlock, NoAdditions, ReadOnly and NoAccess.
Office 365 only support NoAccess as LockState parameter. Afterwards the page can not be opened anymore (401). Therefore is not a feasible option.
Site Collection administrators can still use the interface to set a site collection readonly by activating site policies. This method can not be used in csom because it is not possible to create site policies programmatically (https://social.msdn.microsoft.com/Forums/office/en-US/4ce27e31-9fab-459c-acb1-f2320bbbdc24/site-policy-creation-for-making-office-365-sites-read-only?forum=sharepointdevelopment).
So is there currently no possiblity to set a site to read only programmatically in O365?

You can define a sitepolicy on the contenttype hub. That way you only need to activate the policy on any other site, which is possible via csom

Oh thanks for this info. I didn't know you can publish site policies in the hub.
This is an improvement but you still need one manual step for this. Therefore this is not a solution for a multi-tenant solution.

@MrTantum Are you able to use the REST Endpoint?


Implemented sun layout, preloaded more stuff on on the server, fixed path weirdness.

Hey,
Lets stick to the PR model instead of pushing directly to each others repos, that way we can review code.

Okay sorry, I didn't want to close the issue without the commit, so I picked the wrong direction, won't do it again!

No problem! I just want to be able to compare and it's hard to keep track of everything!


waffle.io Badge

Merge this to receive a badge indicating the number of issues in the ready column on your waffle.io board at https://waffle.io/jclif/serinette
This was requested by a real person (user jclif) on waffle.io, we're not trying to spam you.

Changes Unknown when pulling 484f10f5aa1caa17c50a56c25228e5084140df49 on waffle-iron:master into ** on jclif:master**.