Fix flaky upgrade test

For #11620
Instead of checking the 200 code percentage only, check 503 code percentage and connection refused  percentage separately

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: richardwxn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@richardwxn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test e2e-simpleTests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test integ-telemetry-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test e2e-simpleTests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test integ-galley-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-k8s-presubmit-tests-master

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test e2e-simpleTests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test integ-galley-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-v1alpha3.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-bookInfoTests-envoyv2-v1alpha3-master

/test integ-galley-k8s-presubmit-tests-master

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test e2e-simpleTests-master

prow/integ-galley-k8s-presubmit-tests.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test integ-galley-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-v1alpha3.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/integ-telemetry-k8s-presubmit-tests.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test integ-telemetry-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test e2e-simpleTests-master

prow/e2e-bookInfoTests-v1alpha3.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/integ-telemetry-k8s-presubmit-tests.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test integ-galley-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test e2e-simpleTests-master

prow/e2e-bookInfoTests-v1alpha3.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/integ-telemetry-k8s-presubmit-tests.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
0903eb7c2cb7afee744eb06a0efa6ba3d816a81c
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-galley-k8s-presubmit-tests-master

/test integ-telemetry-k8s-presubmit-tests-master

/test integ-mixer-k8s-presubmit-tests-master

@richardwxn if you could leave a small response to my question in the PR I'd appreciate it.  To other reveiwers, if I don't process this review and @richardwxn has answered the left question, feel free to merge.
Cheers
-steve

15% is quite high, isn't it?
Yes it is! Keep in mind that this is a case of low load so as a percentage it looks worse than as an absolute value. Maybe we should actually use a count here instead.
But regardless, we should not see any 503's during upgrade. The fundamental problem is we can't upgrade the control plane in place without 503's and this is what istio/installer is trying to address among other things.

@richardwxn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test e2e-dashboard-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test e2e-dashboard-master

prow/e2e-mixer-no_auth.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-dashboard-master

/test e2e-mixer-no_auth-master

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test e2e-dashboard-master

prow/e2e-mixer-no_auth.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test e2e-mixer-no_auth-master

prow/integ-mixer-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test e2e-dashboard-master

prow/e2e-mixer-no_auth.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test e2e-mixer-no_auth-master

prow/integ-mixer-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test e2e-mixer-no_auth-master

prow/integ-mixer-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio_auth_sds_e2e-master

prow/istio-pilot-multicluster-e2e.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio_auth_sds_e2e-master

prow/istio-pilot-multicluster-e2e.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-pilot-multicluster-e2e-master

prow/e2e-mixer-no_auth.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio_auth_sds_e2e-master

prow/istio-pilot-multicluster-e2e.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-pilot-multicluster-e2e-master

prow/e2e-mixer-no_auth.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test e2e-mixer-no_auth-master

prow/integ-security-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test e2e-mixer-no_auth-master

prow/integ-security-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-pilot-multicluster-e2e.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test e2e-mixer-no_auth-master

prow/integ-security-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-pilot-multicluster-e2e.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-pilot-multicluster-e2e-master

prow/e2e-bookInfoTests-trustdomain.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test e2e-bookInfoTests-trustdomain-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio_auth_sds_e2e-master

prow/integ-security-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-pilot-multicluster-e2e.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-pilot-multicluster-e2e-master

prow/e2e-bookInfoTests-trustdomain.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test e2e-bookInfoTests-trustdomain-master

prow/integ-pilot-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-pilot-multicluster-e2e.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-pilot-multicluster-e2e-master

prow/e2e-bookInfoTests-trustdomain.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test e2e-bookInfoTests-trustdomain-master

prow/integ-pilot-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-pilot-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@utka Can you help review it please?

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: c0d1ngm0nk3y, richardwxn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @costinm

/test all

@richardwxn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/codecov.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-codecov-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/codecov.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-codecov-master

prow/istio-unit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/codecov.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-codecov-master

prow/istio-unit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-unit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test e2e-bookInfoTests-trustdomain-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/codecov.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-codecov-master

prow/istio-unit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-unit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test e2e-bookInfoTests-trustdomain-master

prow/racetest.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/codecov.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-codecov-master

prow/istio-unit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-unit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test e2e-bookInfoTests-trustdomain-master

prow/racetest.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-racetest-master

prow/integ-mixer-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/codecov.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-codecov-master

prow/istio-unit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-unit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test e2e-bookInfoTests-trustdomain-master

prow/racetest.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-racetest-master

prow/integ-mixer-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-k8s-presubmit-tests-master

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-mixer-k8s-presubmit-tests-master

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test integ-mixer-k8s-presubmit-tests-master

prow/istio-pilot-multicluster-e2e.sh
146b78ea9439606b6fbc3bc9f2400262f7033dfe
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-multicluster-e2e-master

[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
This pull-request has been approved by: c0d1ngm0nk3y, richardwxn
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Launcher unable to retrieve mod list

I'm trying to connect to Sunnyvale #1 |Livonia|OG|Loot+|BBP|Raiding|KOTH|Group|Trader but it seems to be unable to retrieve the modlist:
~/git/dayz-linux-cli-launcher $ ./dayz-launcher.sh --server <IP_ADDRESS>:2302 -p 27016
[dayz-launcher.sh][info] Resolving steam
[dayz-launcher.sh][info] Using non-flatpak mode: steam
[dayz-launcher.sh][info] Querying API for server: <IP_ADDRESS>:27016
[dayz-launcher.sh][info] Nothing to do...
[dayz-launcher.sh][info] No mod-ID list, --server address, or --launch parameter set.
[dayz-launcher.sh][info] See --help for all the available options

Looking at the server on battlemetrics it seems to have some junk in the first 2 mod entries which I'm assuming are causing the issue.
I can confirm this server works fine in Windows using the DayZ SA Launcher.

[dayz-launcher.sh][info] Querying API for server: <IP_ADDRESS>:27016
[dayz-launcher.sh][info] Nothing to do...

This happens when the API response with the mod ID data was empty.
As mentioned in the readme, this is a limitation of the third party server API provided by daemonforge.dev that's being used by the launcher for querying the server data. This is nothing that can be fixed here other than not using that API, but that's currently not happening (see the readme), so I'm going to close the issue.
https://github.com/bastimeyer/dayz-linux-cli-launcher/blob/0.3.0/README.md#known-issues
You can however set the individual mod IDs instead of setting the --server parameter and querying the API. The mod IDs can be extracted from other sites like battlemetrics which you've already linked.
Since there's no API endpoint available on battlemetrics.com where you can easily extract the mod IDs by server address+port (which is the reason why daemonforge.dev is being used in the launcher), you need to extract the mod IDs in your web browser's dev tools like so:
Array.from(document.querySelectorAll("#serverPage dd > ul > li > a")).map(a => /\?id=(\d+)$/.exec(a.href)).filter(Boolean).map(m => Number(m[1])).join(" ")

This yields the following mod ID list:
69537698<PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER>

As you already said, there are junk IDs in this list, so you'll have to filter and review them manually.
And since the --launch parameter will only make you connect to the server after launching the game when you've also set the --server parameter (which you need to avoid here), you either have to connect to the server address manually when the game has started, or you'll have to add the -connect=address custom DayZ parameter. Example:
./dayz-launcher.sh --debug modID1 modID2 modID3 -- -connect=<IP_ADDRESS>:2302


Notification-> The Organisation doesnt has Notification preferences in its profile like Individual has. Both need to have their own notification preferences.

Individual has

Organisation hasn't

URL : https://featurenotifications.fightpandemics.xyz/
Steps:

Login as an Individual
Click on Profile and My Profile
Click on Edit button
Notice the Edit Notification option given
Now, again click on Profile, Organisation, Organisation added
Click on Edit button

Actual Result: No Edit Notification  option given
Expected Result: Edit Notification option should be given so that Organisation can set its own preferences

Same solution as #1797

added preference for organisations

note: notification check values are cleared if you toggle the switch to be off, this will be fixed after #1799 complete

Tested

Preferences:


Fail to acquire connection after knex upgrade

Environment
Knex version: 0.2.11
Database + version: pg - 9.6
OS: node 8.2.1
Bug
Update my knex version from 0.14.0 to 0.20.11, after that application fail to acquire DB connection. Below shows error log and knex config
C:\Padda\Work\Source\inj-service\node_modules\knex\lib\client.js:258
        return this.acquireRawConnection().then(async (connection) => {
                                                      ^
SyntaxError: Unexpected token (
    at createScript (vm.js:56:10)
    at Object.runInThisContext (vm.js:97:10)
    at Module._compile (module.js:542:28)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (C:\Padda\Work\Source\inj-service\node_modules\knex\lib\knex.js:2:16)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:4

knex-config.js
'use strict';

const knex = require('knex')({
	client: 'postgres', // Changed to postgresql and tried didn't work
	connection: process.env.DATABASE_URL,
	debug: false,
	pool: {
		min: +process.env.DB_CONNECTION_POOL_MIN || 2,
		max: +process.env.DB_CONNECTION_POOL_MAX || 100
	}
});

module.exports = knex;

Changed knex-config.js to .ts file got error which is mentioned here #https://github.com/knex/knex/issues/2998 I tried all possible solution given here, didn't work. Am i doing something wrong?
Same knex config file was working before update the version

Are you sure you are using node 8.2.1? Sounds like  node is not parsing async () => {} syntax correctly.
Mikaels-MacBook-Pro:Projects mikaelle$ echo 'Promise.resolve().then(async (foo) => {})' > test.js
Mikaels-MacBook-Pro:Projects mikaelle$ nvm use 8
^[[A^[[ANow using node v8.10.0 (npm v6.4.1)
Mikaels-MacBook-Pro:Projects mikaelle$ node test.js
Mikaels-MacBook-Pro:Projects mikaelle$ nvm use 6
Now using node v6.14.4 (npm v3.10.10)
Mikaels-MacBook-Pro:Projects mikaelle$ node test.js
/Users/mikaelle/Projects/test.js:1
(function (exports, require, module, __filename, __dirname) { Promise.resolve().then(async (foo) => {})
                                                                                ^

SyntaxError: Unexpected token (
    at createScript (vm.js:56:10)
    at Object.runInThisContext (vm.js:97:10)
    at Module._compile (module.js:549:28)
    at Object.Module._extensions..js (module.js:586:10)
    at Module.load (module.js:494:32)
    at tryModuleLoad (module.js:453:12)
    at Function.Module._load (module.js:445:3)
    at Module.runMain (module.js:611:10)
    at run (bootstrap_node.js:394:7)
    at startup (bootstrap_node.js:160:9)
Mikaels-MacBook-Pro:Projects mikaelle$

Are you sure you are using node 8.2.1? Sounds like node is not parsing async () => {} syntax correctly.
Mikaels-MacBook-Pro:Projects mikaelle$ echo 'Promise.resolve().then(async (foo) => {})' > test.js
Mikaels-MacBook-Pro:Projects mikaelle$ nvm use 8
^[[A^[[ANow using node v8.10.0 (npm v6.4.1)
Mikaels-MacBook-Pro:Projects mikaelle$ node test.js
Mikaels-MacBook-Pro:Projects mikaelle$ nvm use 6
Now using node v6.14.4 (npm v3.10.10)
Mikaels-MacBook-Pro:Projects mikaelle$ node test.js
/Users/mikaelle/Projects/test.js:1
(function (exports, require, module, __filename, __dirname) { Promise.resolve().then(async (foo) => {})
                                                                                ^

SyntaxError: Unexpected token (
    at createScript (vm.js:56:10)
    at Object.runInThisContext (vm.js:97:10)
    at Module._compile (module.js:549:28)
    at Object.Module._extensions..js (module.js:586:10)
    at Module.load (module.js:494:32)
    at tryModuleLoad (module.js:453:12)
    at Function.Module._load (module.js:445:3)
    at Module.runMain (module.js:611:10)
    at run (bootstrap_node.js:394:7)
    at startup (bootstrap_node.js:160:9)
Mikaels-MacBook-Pro:Projects mikaelle$

Yes i'm using right version of node

@PradeepaSoundar Is switching to a newer version of Node 8 an option for you? Looks like destructuring is not present in older version that you use.

@PradeepaSoundar Is switching to a newer version of Node 8 an option for you? Looks like destructuring is not present in older version that you use.

Node 8.2.1 is the maximum node version i can use, due to some limitations in our deployment environment and also i need to upgrade knex version (0.19.5+). Is there any way i can achieve this?

@PradeepaSoundar Well. If updating Node is completely out of the question, you could submit a PR that would replace all usages of ... operator that are incompatible with Node 8 in offending file against branch 0.20, I'm fine with using older syntax in maintenance branch, as long as it doesn't make it to master (which is dropping Node 8 support soon anyway).
First I would recommend modifying client.js file in node_modules locally to see it if that helps.

@kibertoad Thank you for suggestion. Finally we decide to remove ... operator from knex package and maintain local copy within our project and I'm closing this issue.

@PradeepaSoundar I'm not sure that's a good long-term solution. If you would raise a PR with this change, it could be incorporated within official 0.20 branch.


[PMR-01M] Inexplicable Configuration Presence

PMR-01M: Inexplicable Configuration Presence

Type
Severity
Location

Gas Optimization

PearlMigrator.sol:L50-L52, L55-L56, L58-L63, L107, L285-L289

Description:
The useCustomAdapterParams boolean is present in the configuration of the contract, however, it is permanently set to true within the contract's PearlMigrator::initialize function meaning that it should not be present at all.
Impact:
The severity and category of this exhibit will be revised depending on whether the useCustomAdapterParams should be update-able per the business requirements of the Pearl Finance team.
Example:
/**
 * @dev Initializes the PearlMigrator contract. This function sets up initial state variables and configurations for
 * the contract as part of the UUPS upgradeable pattern.
 *
 * This function can only be called once, as it is an initializer.
 */
function initialize() external initializer {
    __NonblockingLzApp_init(msg.sender);
    PearlMigratorStorage storage $ = _getPearlMigratorStorage();
    $.useCustomAdapterParams = true;
}

Recommendation:
We advise its omission, greatly optimizing the bytecode size and gas cost of the contract.
Alternatively, we advise its configurability via a dedicated function.

The initial idea was to keep it for upgradeability (we could reinitialize the contract with useCustomAdapterParams set to false). However, at this point I don't see that happening in the foreseeable future, hence, I'll remove it.


Added Pattern Matching Library for Url Pattern Rewrites

Signed-off-by: silverstar195<EMAIL_ADDRESS>Commit Message: Added Pattern Matching Library for Url Pattern Rewrites
Additional Description:
Ported code from internal fork.
Risk Level: Low. No impact on current functionality.
Testing:
Unit testing. See files.
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/assign @stevenzzzz

I'll let @htuch jump in here as well.
The major benefit is better and more streamlined user experience. Users do not want to go off and write regex in order to match paths and do rewrites like: /{item_one}/** or /goo/{item_one}/var/** . The easy use of variables and wildcard matching is the goal.

The major benefit is better and more streamlined user experience. Users do not want to go off and write regex in order to match paths and do rewrites like: /{item_one}/** or /goo/{item_one}/var/** . The easy use of variables and wildcard matching is the goal

I'm really not in favor of adding this feature if it could be implemented in terms of regex. Why can't we just document some example regex patterns then? This seems like a lot of complexity for not much benefit?

@htuch as well.
I think the point of introducing this somewhat overlapping new feature is to guarantee a bounded runtime cost for regex usage operation as well as covering a fairly large amount of customer requests on easier path components based regex matching.

I think this is the standard tension between treating xDS as assembler language and as something consumable by humans @mattklein123 @lizan. For the most part, don't benefit from writing regexes for most common cases - usually you're really interested in either some path component match or a suffix match etc. Regexes are a larger foot gun than needed, and if you look at the APIs provided across the industry, glob/wildcards that match these higher-level semantic goals are the norm (AWS, Cloudflare etc. in addition to GCP).
So, the idea here is really to provide an API that expresses the common case, for most Envoy users. It is strictly redundant with regexes (but then again, so is path prefix and path suffix etc.).

@stevenzzzz point is another motivation here - runtime complexity is easier to bound when we have a limited subset of regexes. We know from experience that this limited subset works well, even in multi-tenant systems.
The way I see the use of RE2 here is that it's a simpler choice for now than implementing the engine ourselves. Previous attempts at reuse of another system (blob of Google code) did not perform as well as RE2, but given the syntax, I don't see it as being unfeasible to replace with something simple, fast and easy to reason about directly later.

That said, having just looked at the actual implementation, this is pretty complicated and I'm not super excited about the complexity being brought into Envoy core.
Taking a step back, this is another example of us doing parsing by hand of some regular grammar. Is this the place we start to use ANTLR or something, which is long overdue anyway in other parts of the config ingestion?
If we we're doing all this manual parsing, the implementation and logic here should be fairly short and simple.

/assign edin44

Yeah, let's say we make this an extension point, does that work for everyone? One question I would have then is whether we should just treat it like a regex engine - functionally it would make sense, but it would be a bit confusing as it's not actually regex.
Also, when I look at what was done for the regex engine in https://github.com/envoyproxy/envoy/commit/0a92cc86e7f8b88d5af0eb2e27b5c7ef64719e56, this sets it globally for the proxy. I don't think we want that here - we want to be able to have folks who use both wildcard and REs as needed on different paths.
So, we would have a new path_matcher extension I think. Does this make sense to everyone? CC @markdroth

So, we would have a new path_matcher extension I think. Does this make sense to everyone?

This would be fine with me. I would also be fine with building this in if we can at least introduce a real grammar which would provide legwork for fixing other things also (namely access log config).

So, we would have a new path_matcher extension I think. Does this make sense to everyone?

Works for me as well.

Yeah, I think a path_matcher extension point makes a lot of sense.  I think that's what I suggested originally. :)

Sounds good folks. Will reform this into an extension and circle back.

/wait
on followup

Moved to extension. I opened a new PR here for review and assigned everyone over: https://github.com/envoyproxy/envoy/pull/22214
Will keep this PR (21907) open for reference and abandon when extension changes are complete.

Adding new to series to complete this work. https://github.com/envoyproxy/envoy/pull/22459

Adding PR to series to complete this work. PR contains library for rewrites and matching. https://github.com/envoyproxy/envoy/pull/22468

Closing out for full PR with two extensions: https://github.com/envoyproxy/envoy/pull/22207


Use bind mount to persist mariadb data

Currently when using docker-compose to start the trace.moe system, the mariadb container uses ephemeral docker volumes to store data and it would be lost when "docker-compose down".
The sad situation is that the query log and all the metadata collected during the indexing process will be removed.
A better practice is to persist those SQL data at the host machine. Here comes this PR.
Relevant StackOverflow question: https://stackoverflow.com/questions/39175194/docker-compose-persistent-data-mysql/

You're right, we should use bind mount for sql data. Thank you ;)


/edit url suffix for authors redirects to wrong admin url

Issue Summary
When you are viewing an author page e.g. /author/ghost  and add /edit to it, the redirect goes to /ghost/#/staff/ghost, but should go to /ghost/#/settings/staff/ghost.
Steps to Reproduce

Navigate to an author page
Add  /edit to the url

Result: Page not Found
Ghost Version
4.32.0
Node.js Version
14.18.2
How did you install Ghost?
Dockerized Fresh Setup
Database type
SQLite3
Browser & OS version
No response
Relevant log / error output
No response
Code of Conduct

[X] I agree to be friendly and polite to people in this repository

Hey @xdivby0 thanks for the report - this has now been resolved.


evm: allow setting pre-defined accounts in genesis

This adds the genesis config accounts that allows setting the full values of pre-defined accounts with code and storage.

bot merge

bot merge

bot merge

Apologies, still ironing out some kinks in the bot

bot merge

bot merge


alternateLabel is missing from the output of /cluster

The "alternateLabel" attribute appears in the output of /cluster/resources/images but it is missing from the output of /cluster.
The output of /cluster/resources/images is:
{
"annotations": {
"alternateLabel": "kubernetes/pause:latest",
"label": "6c4579af347b"
},
"id": "k8s-guestbook-node-1.c.rising-apricot-840.internal/6c4579af347b",
"properties": {
The output of /cluster is:
{
"annotations": {
"label": "6c4579af347b"
},
"id": "Image:k8s-guestbook-node-1.c.rising-apricot-840.internal/6c4579af347b",
"properties": {

Note that the "alternateLabel" appears in the output of "/cluster/resources/images".

Closed by pull request https://github.com/google/cluster-insight/pull/26 .


Fix broken test testCommitOnCloseThrowsException_decRefStore

Description
This test was incorrectly hardcoding a segment to delete to force corruption. If a merge occurs randomly before segments are copied the expected segment did not exist failing the test. This will now look for any .si and delete it.
Related Issues
Resolves https://github.com/opensearch-project/OpenSearch/issues/10616
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thanks a lot @mch2 !


Add privacy details to the apple project

fixed: https://github.com/NigelBreslaw/guardian-ghost/pull/1131


Add Safari links

Add links to the Safari extension on the Mac App Store, allowing users of Safari on Mac to be able to import their followers using Sky Follower Bridge.
This version was ported to Safari but maintains exact feature parody with the Chrome version.

Thank you for your PR, @knotbin! I apologize for not noticing your PR earlier; I had already added the Safari link myself. I will close this PR, but I truly appreciate your contribution😊


Feature self updating database

Add periodic callback to call dataset.sync()
Allow drivers to synchronise their meta-data every 15 minutes
Check list
Handy reminders of things to do ahead of merge

[x] Bump version number to reflect change, edit forest/__init__.py
(Use semantic version x.y.z where x is major, y is feature, z is patch)

@CarolineBain instead of a cronjob I have added an event hook to let FOREST drivers sync themselves if they've implemented dataset.sync(). I've hard-coded the periodicity to be 15 minutely to replicate the cron behaviour. It is currently deploying to dev and should solve our stale data problem


Allow emptyDir volumes instead of PVCs

We should add an option in Spec.StorageOptions to deploy Cryostat using emptyDir volumes instead of creating a Persistent Volume Claim. If neither are specified, we can retain the same default of creating a PVC.

@jan-law would you be interested in this one?

Sure!


[Minor] [ML] [PySpark] Fix omissive param setters which should use _set method

What changes were proposed in this pull request?
#11939 make Python param setters use the _set method. This PR fix omissive ones.
How was this patch tested?
Existing tests.
cc @jkbradley @sethah

Test build #56363 has started for PR 12531 at commit 864b9b0.

Test build #56363 has finished for PR 12531 at commit 864b9b0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56363/
Test PASSed.

This keep slipping in somehow! I did a quick search and only found these two as well. LGTM, thanks!

@sethah I know the binary params here were added around the same time as your PR (a bit before I think). Hopefully these will be caught at PR stage in future :)

Merged to master, thanks!


Implement testing for Reminder feature

Reminder and UniqueReminderList now have their own test classes.
ReminderBuilder and TypicalReminders class that help provide scenarios for ease of testing.
DuplicateReminderException was added to help with debugging when such a scenario occurs.

LGTM


Bugfix config remove

It seems like this is just a simple mistake.
create, update and list, all gets their abortSignal from the args.
closes #739

Good catch 👍


primitives: replace primitive Withdrawals with alloy

Should close https://github.com/paradigmxyz/reth/issues/11798

@joshieDo Seems like something is strange (maybe I missed something) but locally when I try to write the vectors for compac-codec tests it seems I've the right ones (reth-codecs Withdrawals) but on the CI here it seems this is not working the same way (generating with the old reth-primitives Withdrawals), maybe due to https://github.com/paradigmxyz/reth/pull/11994 or maybe I did something wrong here :)

Oh because the type name (or path) changed, therefore it doesn't exist on main.
I'll create a PR to handle that

@joshieDo nice thanks

Hey @mattsse is there a reason for this to be closed :)? we should just rebase after https://github.com/paradigmxyz/reth/pull/12125 is merged no?

Yes I believe it was closed by accident

Yes I believe it was closed by accident

@shekhirin No problem :) just rebased

hey @mattsse @joshieDo anything to add here or can we merge?


[Unreal] "Waiting for players to join" screen never goes away.

Very occasionally this loading image shows up on one (or more) my clients:

I can still play the game, but it just obstructs the view.

/cc @kennycoder any ideas?

Found the issue, will fix in the next release.

Bumping in @kennycoder priority queue.

Tried couple of fixes, but still able to replicate this issue - it appears randomly. Further investigation needed but all points to synchronization issue. Going to resume next week.

https://github.com/googleforgames/global-multiplayer-demo/pull/182

Closing as fixed!


Load decorators dynamically from config file

Currently Enroute class define static methods:
class Enroute:
    """Enroute decorator main class"""

    broker = BrokerEnroute
    rest = RestEnroute
    periodic = PeriodicEnroute

It is necessary to load the decorators from the config definition:
...
decorators:
   rest: minos.plugins.rest_aiohttp.RestEnroute
   other: minos.plugins.other.AnotherClass
...

I'm proceeding to close this PR as it is not currently factible to load decorators from the configuration file...


Feature request - Support configure affinity for each component

Is your feature request related to a problem? Please describe.
We just noticed that the harborCluster object doesn't support define affinity objects.
Describe the solution you'd like
Supports affinity and anti-affinity settings in each cluster component spect block.
Describe the main design/architecture of your solution
Add affinity block into the ComponentSpect type.
Additional context
For reliability reasons, we would like to ensure that, for each component, each pod is running into a different node by defining anti-affinity rules.

@cndoit18 is trying to support customize affinity


Update Drupal to 8.9.0

https://www.drupal.org/project/drupal/releases/8.9.0
Since 8.9.0 requires PHP 7.3 this will have implications for the development VM at https://github.com/Islandora-Devops/islandora-playbook

Playbook is installing Drupal 9, so I think this can be closed. Is that okay @kayakr?

Isle-dc/buildkit is still on 8.x


Documenting rollback in faststore

What's the purpose of this pull request?
Document the rollback process
⚠ Warning
This is only valid when we are using VTEX to build the stores, not Netlify

Soooo, I made a commit over Davi commit instead of commenting and don't really liked how it endded up :x
So, if the tech writing team wants to see the original one, it is here
Sorry, @dhasuda

Soooo, I made a commit over Davi commit instead of commenting and don't really liked how it endded up :x
So, if the tech writing team wants to see the original one, it is here
Sorry, @dhasuda


JsonPath.read with InputStreamReader and node to Parse returning empty

JsonPath.read method with the input stream reader is returning empty when the json size is large as 30 MB. The same piece of code works fine with the file of low size in KB and few MBs.
final DocumentContext documentContext = JsonPath.parse(inputStreamReader);
final JSONArray jsonArray = documentContext.read(nodeToSearch);

Here, the size of the jsonArray is Zero.

The JsonPath.read() method reads a JSON document and returns the specified element. When the JSON document is large, the method can run out of memory because it loads the entire document into memory before processing it.
When the size of the JSON document is large, it is better to use the JsonPath.parse() method which reads the JSON document incrementally, instead of loading the entire document into memory.
InputStream input = new FileInputStream("large_json.json");
Reader reader = new InputStreamReader(input);
JsonPath jsonPath = JsonPath.parse(reader);
String item = jsonPath.read("$.path.to.element");

It is documentContext.read(nodeToSearch) not JsonPath.read

Use a different JSON parsing library, such as Gson or Jackson, which may have better support for large files.
Increase the JVM heap size, which may help JsonPath handle larger files.


Add /powertool

Popular feature, but needs to be considered.
I think we need:

Powertool object that contains the ID of the item and the command to run.
A new list entry in the UserConfig that will contain this information
The command

I'll do this one after I add the worlds module.


web: why not use Skia

not uniform?

Personally I prefer native DOM widgets, but might as well support both? Flutter has both DOM and canvas renderers, but even when using the canvas renderer it uses native DOM widgets to maintain accessibility (e.g. text fields actually place an <input> over the canvas)

Maybe we can use the semantic information to populate an invisible DOM tree only for a11y, but still do the rendering in canvas?

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Migrating Ionic to OASP4J 3.0.0

Addresses #11
Changes:

Changed pagination to fit new oasp4j 3.0.0 version.
Added Sampledata to be able to try it out.
Added sorting feature.
Fixed a search bug.
Fixed the login that was being executed twice.

@sjimenez77 I don't have permission to create a new develop branch

Branch develop just created.

Closing for changing branch


does not show tag unless I open the file

vs code Version: 1.45.1
unless  I open the file, the tags in the file does not show in the sidebar

I can confirm.

I can confirm this for vs code version Version: 1.56.2, too.

Nevermind. The extension is only scanning for markdown files that are in the directory you opened with vs code.
But then the first sentence in the extension description is misleading for me:

View your notes without being limited by your file system's hierarchy.

I can confirm and after much testing.

If tags are not formatted properly, lack of inline square brackets for example, nested-tags fails.
If a colon is used in title: without quotation marks, nested-tags fails.

Therefore, please check your formatting as nested-tags will fail if there are errors in your front matter headers.


When lazyLoading is set to true, the searchBy array setting is not honored

this.settings={
text: "Select Emphasis Programs",
enableCheckAll: false,
classes: "comp-multi-select comp-multi-select-lightbg",
primaryKey: "num",
labelKey: "dispValue",
enableSearchFilter: true,
searchBy: ["dispValue"],
lazyLoading:true
}
This is the data object
{
"num":123,
"dispValue":"Some name of the obj"
}
In this settings, if lazyLoading is set to false then searchBy is honored or else it is searching all the keys.

Accepted.


add support for loading single-precision data from GRIB files

@floriankrb - hi Florian, it'd be great if we could load data from GRIB files (like ERA5 / WeatherBench) in single precision (float32) instead of np.float64, which appears to be the current default. Reading float64s and converting to float32 for ML seems rather wasteful. I'd be happy to assist with this if possible. Cheers, ~M

TLDR: yes, we will add this as an option in .to_tfdataset() or .to_pytorch(), or make it the default.
Thanks for the discussion about this. I am adding here a short summary before closing this.
Data is not stored in GRIB files as float64, it is closer to a float10 or float16 (depending on which data, I think, temperature needs less precision than chemical properties). This is an ongoing discussion on how best compress the data inside a GRIB.
When reading the data, if some computation is performed (such as interpolation or other), using float64 can be a requirement. The actual size in memory is not a major issue. Moreover, changing to float 32 here would lead to major developments in the C library, this is not planed until proven useful. On the other hand, turning float64 to float32 on the fly (i.e. as the data is read from GRIB) is fast and easy, it will be implemented into climetlab.
Generally speaking, using less memory to store the data is a good idea, and there are several places where float64 is wasteful. Let's optimize only the places where there is a proven bottleneck.


Support for Alpine Linux

Title, it uses apk as a package manager, and open-rc for services.

I will close this for now:

Alpine is not available by default on the cloud providers I use (Do, Vultr, Hetzner, Scaleway, etc), so it's difficult for me to implement and maintain
Alpine not using Systemd will add (a bit) of complexity vs the rest of the supported distributions.

As what I found, alpine seems to be available on vultr starting few years agao ...


Remove iGEMM solvers

The following solvers need to be removed from the library:

ConvHipImplicitGemmV4_1x1
ConvHipImplicitGemmV4Fwd

@asroy Please update the list if you believe some others can be removed as well

@JehandadKhan, has the work to remove these two solvers started? Who will be creating the PR?

If the iGEMM team does not object I can do it.

@daniellowell, please clarify who is assigned this task so that we can drive this high priority issue to completion.

@daniellowell, following up with my request.

@JehandadKhan please go ahead and remove these solvers, unless @zjing14, @Tejash object
I will remove the kernel part in separate PR.

@asroy PR #274 how has some dead code in RunAndMeasureSolutionBase and GetSolutionBase. Maybe some invokers are never used.
Can we make all removals in a single PR?

@JehandadKhan has #274 addressed this issue or are there still aspects of this issue at large?

The PR has addressed the issue


Cmake flag MFEM_ENABLE_EXAMPLES not work on windows

I noticed that MFEM_ENABLE_EXAMPLES default is off, and I did not change anything.
The folder struct is same as #3413
However ex0-ex33p still exsited in the VS solution explorer.

Yes, the build targets for the examples are always defined. MFEM_ENABLE_EXAMPLES simply controls if these build targets are part of the default build target.

See also the discussion #3182 and feel free to add comments or suggestions there.
I'll close this -- further discussion can continue in #3182.


STM32 decoupling capacitors

See this file:
https://4donline.ihs.com/images/VipMasterIC/IC/SGST/SGST-S-A0004456612/SGST-S-A0004456612-1.pdf?hkey=6D3A4C79FDBF58556ACFDE234799DDF0
Page 109 for Power supply scheme

https://au.element14.com/stmicroelectronics/stm32l476mey6tr/mcu-arm-cortex-m4-80mhz-wlcsp/dp/2855729?st=stm32l476 potential stm32 micro

Not required due to design changes


Tests for Commands

Problem Description
Writing some tests for commands would be helpful during builds and to make sure that there are less bugs going out to the main branch from pull requests.
Proposed Solution
Write tests for all commands that do not require API keys to confirm command functionality as desired for all commands.
Alternatives Considered
No response
Additional Context
No response
Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this feature has not been requested yet.
[X] I have provided enough information for the maintainers to understand and evaluate this request.

@localagi we can work together on this one when we both have time in the near future.

@localagi we can work together on this one when we both have time in the near future.

:thumbsup:

I've seen you test-commands notebook. I'll check what needs to be transferred into quickchecks (build tests).
Linking related issues:
https://github.com/Josh-XT/AGiXT/issues/557
https://github.com/Josh-XT/AGiXT/issues/518
https://github.com/Josh-XT/AGiXT/issues/495
https://github.com/Josh-XT/AGiXT/issues/494 (<< this might be working already)

https://github.com/Josh-XT/AGiXT/actions/runs/5183662111
New tests with the API Client are working great!  Adding command tests after I finish setting up the chain for it, then will add that as well.


Implement smart select

https://code.visualstudio.com/api/references/vscode-api#SelectionRangeProvider

smart select is very helpful

It's been more than a year and I still think this is an important missing usability feature when editing Python code from VSCode.

This was implemented in the 2021.12.1 release of Pylance!
https://github.com/microsoft/pylance-release/issues/266


chainmaker string should allocate your own space

chain_id and org_id should not use user pointer，should malloc

problem fixed


withCachedChildNavigation basically did not cache

Fixes #159. Any ideas on testing this welcome.
Also, I'm unsure if routes can change. If that is the case, we could add logic to clean out the cache of no-longer-used routes.

Thank you :D

Updated!


Assume tests will always be run. Install test deps.

We should probably install blist as well to prevent the warnings around that. Plus I've been told there are problems without it?

@basepi - Good catch! blist has been added.


Apache SSL Support

This change adds a dependency on the ssl certificate cookbook.
Updated apache2 cookbook dependency (fixes POODLE)
If an SSL cert is not present, a self-signed cert will be generated.
Apache will be configured to use both ssl and non-ssl for compatibility.
Added integration tests (and fixed old one).
Updated test kitchen rules to test SSL

I completely missed this PR when I started working out of another branch a few months ago, so I didn't pull it into the changes that were just published.

If you're able to resolve the merge conflicts, I can review it and look at merging it in more quickly.
Notes:

There is a reference to wordpress::package in the default recipe, but I don't see a corresponding recipe.
Using git on Linux distros sounds like a great idea. In the past I've had to add the git community cookbook as a dependency since it doesn't come on all stock images. I haven't had much time to dig into this to investigate.

Any update on this ?
Would love to have SSL support !


Replace the button

Describe the task
The Delete button is not looking good on the prospect page. Make the button look like a icon

Expected behaviour

Use this icon instead of the button

No PR is linked but the icon was implemented on portal hence closing the issue.


Is it possible to make the text selectable

Just like the SelectableText Widget

Each digit is displayed using a separate Text widget, so even if we use SelectableText widgets, the user will only be able to select a single digit at a time. If you think that'll be useful, please share a user story.

Each digit is displayed using a separate Text widget, so even if we use SelectableText widgets, the user will only be able to select a single digit at a time. If you think that'll be useful, please share a user story. Otherwise, this will probably be a "won't fix".

In the current design, each digit is displayed using a separate Text widget (to allow single-digit animation controls), so even if we use SelectableText widgets, the user will only be able to select a single digit at a time. If you think that'll be useful, please share a user story. Otherwise, this will probably be a "won't fix".


Topfiles for nebula/pulsar

Would be endlessly useful for team-specific or grain-specific needs in these modules

https://jira.corp.adobe.com/browse/CSTTEAM-41388

Fixed in #176 and #129


Forgot Password Backend

Issue #75
✨ Forgot Password Feature Implemented on the backend side.

Modified User Model (one resetPassLink attribute added)
Authentication routes updated (two new routes added i.e. /forgot & /reset-password)
Authentication controllers updated (two new controllers added i.e. forgot & resetPassword)
.env example file updated (two new environment variables added i.e. RESET_PASSWORD_JWT_KEY & CLIENT_URL)

Screenshots Time 😅

Mail for the reset link

/auth/forgot API

/auth/reset-password API

As always Good Work @sanjay270899

As always Good Work @sanjay270899

@sanjay270899 You haven't added the Client Side Code where when the user click on forget password then something should happen

@sanjay270899 You haven't added the Client Side Code where when the user click on forget password then something should happen

So the current merge Pull Request won't be considered
Just make a new PR adding the required changes and I will merge that and add corresponding labels

So the current merge Pull Request won't be considered
Just make a new PR adding the required changes and I will merge that and add corresponding labels

@Tejas1510 on Issue #75 only backend label was there, and also, it was of level-3, so I thought that I have to do it in two separate PRs.

@Tejas1510 on Issue #75 only backend label was there, and also, it was of level-3, so I thought that I have to do it in two separate PRs.

Ok Don't Worry I will increase the level of points
You can start working

Ok Don't Worry I will increase the level of points
You can start working


thank you for your "Pull Request" Course

Nice to meet you. Keep going on your tutorial.

Hi @tylerlantern
Nice to meet you too. Did everything go OK with the tutorial? The pull request you've submitted doesn't cover all of the steps in the course—I was wondering whether that's because you got stuck, or because you just skipped through the easy parts?
Hope you enjoyed it :)
sam

I forgot to assign a reviewer. my bad but everything is ok.

Hey @tylerlantern—congrats on submitting a PR at the end of the git course. I hope you enjoyed working through the course, and that you learnt some new tips and tricks for using git.
If you weren't already using git for your code, hopefully this has inspired you to do so. I hope that you enjoy the "Mastering Git" video course as well—you'll soon be able to get git to bend to your will :)
You can now wear this #GitWarrior badge with pride—and Tweet your historic victory!

sam


Alexa skill in Italy

Hi Michael,
Alexa has finally arrived in Italy!
Would you please render the skill available in italy as well, I don't care if it is in english language, as I am using it already in that way, but now that I have converted the account the former skill does not work anymore
thanks

Here we go:

IR Controller Smart Home Skill that allows registration of your TV / other infrared smart home controller devices with Alexa. Your http URLs are translated into natural language smart home operations.
Register your IR Controller smart devices at https://tehpsyc.pythonanywhere.com/
Skill is designed to work with the https://github.com/mdhiggins/ESP8266-HTTP-IR-Blaster schematic and software. It may be possible to use similar HTTP enabled devices as well. The IR Blaster can be easily assembled with parts under $10 and provides full home theater control.

Skill per Casa Intelligente che permette l'utilizzo del tuo Controller Infrarosso Multicanale basato su ESP8266 con Alexa per comandare tutti i dispositivi IR della casa. I comandi impostati come URL http verranno tradotti in operazioni intelligenti basati su comandi vocali.
Registra il tuo IR Controller all'indirizzo https://tehpsyc.pythonanywhere.com/
La Skill è progettata per funzionare con gli schemi, il software e le istruzioni fornite all'indirizzo https://github.com/mdhiggins/ESP8266-HTTP-IR-Blaster
E' possibile utilizzare in alternativa altri dispositivi basati su comanid HTPP.
Il dispositivo supportato e descritto nel link github  può essere facilmente assemblato e programmato con componenti del valore complessivo di circa 10€, e permette di controllare qualsiasi dispositivo IR presente nell'impianto Home Theater di casa o con qualsiasi altro dispositvo che accetti comandi IR.

Hey Michael, did you have the chanche to implement the skill to Italy? It's still not working for me
Matteo

Hi, Any progress on the italian skill?
Is it possible to install the english one?

Hi, I' m also interested in the italian skill. I' m offering my support for the translation too. Please let us know. Thanks

Still not possible to have the skill in Italian? it is a pity!
This is a very useful project, and I'm sure many Italians would take advantage of it

It is sad that there is no answer to this request !!!

Just setup on IFTTT Alexa or Google Assistant webhook in Italian.

Could you please explain more in detail the procedure, how to connect your http-IR-Blater using FTTT and then Alexa ?
The direct integraiton with Alexa cponatin all the commands, with webhoook we need to create command by command …
Is there any other way ?
As you can see there are few people that are interested in the italian version.
Maybe we can help with the translation ... It can be an idea ..
Just let us know

The ESP8266-HTTP-IR-Blaster project
Yes, I have step-by-step instructions for making IFTTT webhooks that work with both Alexa and Google Assistant.  Currently, I use more than 50 IFTTT webhooks that link my Alexa and the IRBlaster together.  Each webhook is a different voice phrase action.  This means my TV now responds to 50 different voice commands; such as Turn On, Pause, Play etc...
The basic idea is that Alexa sends a webpage post link to your IRBlaster.  Then the IRBlaster sends out the IR pulses to the TV.  If you can post a link to your IRBlaster, you can control virtually anything.
Using the mdhiggins setup :), you can view and send links from the browser interface.  This way you can tell if the IRBlaster is actually working before working on the voice part.  If you can get to this stage of the project, then you can build up your IFTTT webhooks.

Goto IFTTT Development website called IFTTT Platform for Business
(it's free)
https://platform.ifttt.com/

Goto Applet
Create a New Applet

The Trigger
Trigger = Amazon Alexa or Google Assistant
Select Say a simple phrase from dropdown

Field label What phrase?
Visible = set by you
Value = tv on (Or replace with Italian equivalent)

Important -- Step 5 -- Language, is only available when using Google Assistant

Field label Language
Visible = set by you
Value = English

The Action
Click Add Action Button
In Search for Service field enter Webhooks
From the dropdown field, select Make a Web Request

Field label URL
Visible = set by you
Value = http://<IP_ADDRESS>:667/msg?code=E0E040BF:SAMSUNG:32

Field label Method
Visible = set by you
Value = Select Post from dropdown list

Field label Content Type
Visible = set by you
Value = text/plain

Field label Body
Visible = set by you
Value = leave blank

After you save the Applet scroll down a bit and turn it on.  Then press the connect button.  After you press the connect button you will be brought over to an Amazon login page so the webhook with be created under you Amazon profile.
On a personal note:  I prefer the Google Assistant webhooks, because it uses more of a natural language.  For example, in Google Assistant I say, OK Google, Turn on My TV.  While for Alexa, I have to say Alexa, Trigger My TV On.  Alexa uses the word Trigger to tell it to use a webhook.  Google just knows it's a webhook.

Thank you very much!
Interesting post. i'm doing some tests about it.
i have some question:
point 7 and 8.
The request looks more a GET than a POST. Is it correct?
point 7.
http://<IP_ADDRESS>:667/msg?code=E0E040BF:SAMSUNG:32
This is a local network address...
So will be Alexa or google that will send the command? Correct?

Any external source requires your external IP address, so Alexa and Google cannot use that as its a local IP address

@mdhiggins any update on having this available for installation on an Italian Alexa device? Is there anything further we could help with?

I'm also available, please involve us to complete it.
We can help.
thanks
Il giorno mar 18 ago 2020 alle ore 12:31 giuliomoro <
<EMAIL_ADDRESS>ha scritto:

@mdhiggins https://github.com/mdhiggins any update on having this
available for installation on an Italian Alexa device? Is there anything
further we could help with?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mdhiggins/ESP8266-HTTP-IR-Blaster/issues/228#issuecomment-675399664,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMDK6CEQ3OEAKYXY6GKEDEDSBJKAHANCNFSM4GBU74EA
.

translate.pdf
I need translation of all these elements and I can try to submit to Amazon for approval

And if anyone can do Spanish let me know, amazon has finally made submitting in other languages not a huge problem

ok this is fine for me i can do the italian version. But from the pdf I
cannot do anything ...
can you give me something to work on ?
thanks
Il giorno mar 18 ago 2020 alle ore 15:35 Michael Higgins <
<EMAIL_ADDRESS>ha scritto:

translate.pdf
https://github.com/mdhiggins/ESP8266-HTTP-IR-Blaster/files/5090677/translate.pdf
I need translation of all these elements and I can try to submit to Amazon
for approval
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mdhiggins/ESP8266-HTTP-IR-Blaster/issues/228#issuecomment-675482175,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMDK6CF6A346LBVCGIQC2IDSBJ7QTANCNFSM4GBU74EA
.

IR Controller Smart Home Skill that allows registration of your TV / other infrared smart home controller devices with Alexa. Your http URLs are translated into natural language smart home operations.
Register your IR Controller smart devices at https://tehpsyc.pythonanywhere.com/
Skill is designed to work with the https://github.com/mdhiggins/ESP8266-HTTP-IR-Blaster schematic and software. It may be possible to use similar HTTP enabled devices as well. The IR Blaster can be easily assembled with parts under $10 and provides full home theater control.

IR Controller Smart Home Skill permette l'utilizzo del tuo Controller
Infrarosso Multicanale basato su ESP8266 con Alexa per comandare tutti i
dispositivi IR della casa. I comandi impostati come URL http verranno
tradotti in operazioni intelligenti basati su comandi vocali.
Registra il tuo IR Controller all'indirizzo
https://tehpsyc.pythonanywhere.com/
La Skill è progettata per funzionare con gli schemi, il software e le
istruzioni fornite all'indirizzo
https://github.com/mdhiggins/ESP8266-HTTP-IR-Blaster
E' possibile utilizzare in alternativa altri dispositivi basati su comandi
HTPP.
Il dispositivo supportato e descritto nel link github può essere facilmente
assemblato e programmato con componenti del valore complessivo di circa
10€, e permette di controllare qualsiasi dispositivo IR presente
nell'impianto Home Theater di casa o con qualsiasi altro dispositivo che
accetti comandi IR.
Il giorno mar 18 ago 2020 alle ore 16:49 Michael Higgins <
<EMAIL_ADDRESS>ha scritto:

IR Controller Smart Home Skill that allows registration of your TV / other
infrared smart home controller devices with Alexa. Your http URLs are
translated into natural language smart home operations.
Register your IR Controller smart devices at
https://tehpsyc.pythonanywhere.com/
Skill is designed to work with the
https://github.com/mdhiggins/ESP8266-HTTP-IR-Blaster schematic and
software. It may be possible to use similar HTTP enabled devices as well.
The IR Blaster can be easily assembled with parts under $10 and provides
full home theater control.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mdhiggins/ESP8266-HTTP-IR-Blaster/issues/228#issuecomment-675525296,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMDK6CAE53RNABQBRPPOARLSBKIJJANCNFSM4GBU74EA
.

I'll also need all the sample commands in whatever Amazon uses for their API in Italian, I assume it would be a direct translation but that's required. Also the short description

Alexa, turn on bedroom TV

-> Alexa accendi la televisione della camera

Alexa, mute bedroom TV

-> Alexa, muta la televisione della camera

Alexa, turn up the volume by 5 on bedroom TV

-> Alexa, alza il volume della televisione della camera di 5.
[though I am not 100% sure this is right, @AlexMun070282 ? ]
Short description:

IR Controller Smart Home Skill

-> Controllo infrarossi Smart Home

Actually you can leave as it is, I think most of the people that are
working with those stuff can understand.
If you want an italian translation for the short description, you can take
this: "Telecomando IR per casa intelligente"
Example phrases are:

Alexa, accendi la TV della camera
Alexa, metti in muto la TV della camera
Alexa, alza il volume di 5 sulla TV della camera

Let me know if you need other support,
Feel free to ping me.
regards Alessandro
Il giorno mar 18 ago 2020 alle ore 16:58 Michael Higgins <
<EMAIL_ADDRESS>ha scritto:

I'll also need all the sample commands in whatever Amazon uses for their
API in Italian, I assume it would be a direct translation but that's
required. Also the short description
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mdhiggins/ESP8266-HTTP-IR-Blaster/issues/228#issuecomment-675530645,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMDK6CH4JUL3FQLZPNQZIQDSBKJKFANCNFSM4GBU74EA
.

Submitted for review we'll see what amazon says

amazing, thanks @mdhiggins

thanks, @mdhiggins https://github.com/mdhiggins
Il giorno mar 18 ago 2020 alle ore 18:00 giuliomoro <
<EMAIL_ADDRESS>ha scritto:

amazing, thanks @mdhiggins https://github.com/mdhiggins
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mdhiggins/ESP8266-HTTP-IR-Blaster/issues/228#issuecomment-675566668,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMDK6CEVS7M6L5MCEAN236DSBKQTLANCNFSM4GBU74EA
.

Failed the first time, resubmitted
The process is very frustrating, for every language I need a local amazon account (so I've had to make about 7 amazon accounts in various languages). And for each local amazon account I need to set up forwarding to a test device that has to issue successful responses to the voice commands. Had a port issue with one of the accounts that caused it to fail.
Biggest problem now is that the person who helped me out by giving me an Amazon India account (you need an Indian phone number to make one) has changed their password so I can't update the test data. Tried a workaround but might fail the review again because of India. If even one region fails they fail the whole update.

Ah damn! I really appreciate the time you are taking to do this, let me know if I can help with anything (note: I am away from my Echo Dot until Tuesday).

If you need to test it in Italian , I’m also available. Regards
Inviato da iPhone

Il giorno 19 ago 2020, alle ore 16:49, giuliomoro<EMAIL_ADDRESS>ha scritto:

Ah damn! I really appreciate the time you are taking to do this, let me know if I can help with anything (note: I am away from my Echo Dot until Tuesday).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

I don't test it, Amazon has to test it to approve it so they handle that

Looks like it got approved and should be live

YES ! great! thanks a lot. Will get to it soon.

tested it in Italian and it seems to work, except that several of the capabilities exposed by https://tehpsyc.pythonanywhere.com/ are not supported by Alexa in Italian (see here), which is very sad :( I guess I will have to abuse the scenes API to circumvent this limitation ...

Yeah nothing I can do about that, amazon has been expanding support though so it should automatically work when they add it


MM-37503 channel sidebar header updates

Summary
This PR polishes up the channel sidebar header when the Global Header (GH) is active.
Given the complexity of the original header and the simplicity of the new header, I've changed to using two separate base components for a cleaner split between before and after GH. The old SidebarHeader component becomes the LegacySidebarHeader and the new component is SidebarHeader. This will make it easier to transition to the permanent GH without a feature flag and keeps the styling of each separate. Unfortunately the legacy header will still need to exist as long as we don't support the GH in mobile view as it provides some mobile-specific structure.
Best to wait until the related PR below (#8509) is merged to master before reviewing code this one as most of the changes in this PR actually come from #8509. Once it is merged, this one should be drastically simpler to review. :P
Ticket Link
https://mattermost.atlassian.net/browse/MM-37503
Related Pull Requests

based off of this PR, which needs to be merged first

Screenshots

Release Note
NONE

Best to wait until #8509 is merged to master before reviewing this one as most of the changes in this PR actually come from #8509. Once it is merged, this one should be drastically simpler to review. :P

Okay, so it didn't become simpler ... I will create a new PR instead.


Do we need to worry about strict provenance?

Right now, HWND and friends are typed as an isize; however, it seems that they are actually pointers. On certain platforms, it is considered invalid to use an *size as a pointer. However, I'm not sure how this is handled on the Windows side of things. Do we need to worry about strict provenance?

Indeed, handles are pointer-sized only, with no more than 32 significant bits. This is true for handles to USER objects (HWND, HICON, ...), GDI objects (HBRUSH, HPEN, ...), and handles to named kernel objects (mutexes, semaphores, files, ...). That's primarily to arrange for Interprocess Communication Between 32-bit and 64-bit Applications, but serves to highlight that handles aren't actually pointers.
They are typed as pointers in the C header files, presumably because fixed width integer types are a somewhat recent (C99) addition to the C programming language, with intptr_t/uintptr_t still only an optional feature.

One complicating factor is structures like OVERLAPPED. The hEvent should by rights be a union of a HANDLE and a c_void pointer. This is because of WriteFileEx that says:

The WriteFileEx function ignores the OVERLAPPED structure's hEvent member. An application is free to use that member for its own purposes in the context of a WriteFileEx call. WriteFileEx signals completion of its writing operation by calling, or queuing a call to, the completion routine pointed to by lpCompletionRoutine, so it does not need an event handle.

It's common to use this free member to pass a pointer to a struct.
There could be similar issues for anything that passes through a HANDLE without actually using it.


Policy Assignment

The scope to assign a policy is either a management group, subscription or resource group. I don't think you can assign a policy to an individual resource.

@frachkid : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@frachkid The scope can be an individual resource. If you look at the REST API for create, we can see that the scope parameter accepts a path like  /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{resourceProviderNamespace}/[{parentResourcePath}/]{resourceType}/{resourceName}.
#please-close


Cursor always null

CoreCursor c = test.db.rawQuery("select name from account_name", new String[]{});

if (c == null) {
   Gdx.app.log("DB", "Cursor is empty");
}

I tried and it's always getting an error
Any help would be apreciated

Nead more information!
How you are initiated the DB?

I just copy and paste your :sqlite_core :sqlite_android :sqlite_desktop
and in each file of android & dekstop I call new DesktopDatabaseFactory() and new AndroidDatabaseFactory()
and in core i call new NativeDatabaseFactory()
alongside with this method

@Override
public void create() {
                Thread thread = new Thread(new Runnable() {
			@Override
			public void run() {
				// change to NativeDatabaseFactory
				try {
					new NativeDatabaseFactory();
					createDB();
				} catch (Exception e) {
					e.printStackTrace();
				}
			}
		});
		thread.start();
}

private void createDB() {
		// Gdx.files.external("testdata/test.db3");
		FileHandle fileHandle = Gdx.files.internal("data.db3");

		Gdx.app.log("DB", "Create DB instance on " + fileHandle.toString());
		TestDB test = new TestDB(DatabaseFactory.getInstance(fileHandle, alternate));

		Gdx.app.log("DB", "DB Start up");
		test.startUp();

              try {
			Thread.sleep(500);
		} catch (InterruptedException e) {
			e.printStackTrace();
		}

		if (fileHandle.exists()) {
			Gdx.app.log("DB", "DB File exists");
		} else {
			Gdx.app.log("DB", "ERROR DB File not exists");
		}

                //read
		Gdx.app.log("DB", "read data");
		String resultString = "";
		CoreCursor c = test.db.rawQuery("select name from account_name", new String[]{});

                // cursor always null because db was never created
		if (c == null) {
			Gdx.app.log("DB", "Cursor is empty");
		}

                test.close();
}

Sorry, I will close this, then I will rework all with native implementation!


Build failed

Describe the bug
When I run bash apollo.sh build  on my PC, it show me this:
tiffer@in_dev_docker:/apollo$ bash apollo.sh build
System check passed. Build continue ...
[WARNING] ESD CAN library supplied by ESD Electronics does not exist. If you need ESD CAN, please refer to third_party/can_card_library/esd_can/README.md.
Running build under GPU mode. GPU is required to run the build.
[INFO] Start building, please wait ...
INFO: Reading 'startup' options from /apollo/tools/bazel.rc: --batch_cpu_scheduling
[INFO] Building on x86_64...
[INFO] Building with --jobs=8 for x86_64
INFO: Reading 'startup' options from /apollo/tools/bazel.rc: --batch_cpu_scheduling
INFO: Found 1802 targets...
ERROR: /apollo/modules/canbus/common/BUILD:5:1: undeclared inclusion(s) in rule '//modules/canbus/common:canbus_common':
this rule is missing dependency declarations for the following files included by 'modules/canbus/common/canbus_gflags.cc':
  'bazel-out/local-dbg/genfiles/external/com_github_gflags_gflags/gflags/gflags.h'
  'bazel-out/local-dbg/genfiles/external/com_github_gflags_gflags/gflags/gflags_declare.h'
  'bazel-out/local-dbg/genfiles/external/com_github_gflags_gflags/gflags/gflags_google.h'.
INFO: Elapsed time: 4.682s, Critical Path: 0.91s
============================
[ERROR] Build failed!
[INFO] Took 6 seconds
============================

I just  follow the step in README file, and I compile this passed before.
After I re-download it and compile again, it show me this.
Can someone tell me how to debug this problem??

Maybe you should read this.

Please delete folder {HOME}/.cache/bazel/bazel{USER}, and run bazel clean.

I had the same issue, with same errors
It turn out I had a directory called apollo , with a directory called apollo.
I went into apollo/apollo/ then went into docker

我也遇到这个问题了， 执行delete folder {HOME}/.cache/bazel/bazel{USER}, run bazel clean后。
bash apollo.sh build --local_resources 2048,1.0,1.0sed: 1: "WORKSPACE": invalid command code W
Must run apollo.sh in dev docker or release docker

Thx.
After tried lianglia's suggest, I solved this problem.
Just delete the bazel folder & rebuild.

Same issue, see attached file for complete log of command bash apollo.sh build.
Please reopen this issue.

log2.txt
Same issue, see attached file for complete log of command bash apollo.sh build.
Please reopen this issue.


maxDate is not working on ios

Issue
When i'm using react-native-datepicker, maxDate properties working correctly in android but is not working on ios.
Code
                              <DatePicker
                                    style={{
                                    width: api.getRealDeviceWidth() * 0.9
                                }}
                                    date={this.state.dob}
                                    mode="date"
                                    placeholder="select date"
                                    format="YYYY-MM-DD"
                                    minDate={'1960-01-01'}
                                    maxDate={'1995-01-01'}
                                    confirmBtnText="Confirm"
                                    cancelBtnText="Cancel"
                                    showIcon={false}
                                    customStyles={{
                                    dateInput: {
                                        borderColor: '#cdcdcd',
                                        borderRadius: 2,
                                        height: 36
                                    },
                                    dateText: {
                                        textAlign: 'left',
                                        width: api.getRealDeviceWidth() * 0.9,
                                        padding: 12
                                    }
                                }}
                                    onDateChange={(date) => {
                                    this.setState({dob: date})
                                }}/>

Environment

react-native -v: 0.40.0
target platform: iOS
operating system: Linux

Same issue for me and also not working for Android. Strangely no matter what date I put it, the maxDate gets the year correct, but the month and day keeps going to Jan 20th.

Same issue here

+1 on this. Doesnt work on both.

keeping format of minDate and maxDate same as that of date picker, solved the problem for me.

I've tried all the above suggestions but none is working for me. Please have a look and fix it.

@kamranyounis12 is right, the dates are compared via simple < and > comparison so you need to supply the dates in identical/comparable formats. I'm passing a native JS new Date() to each.

minDate and maxDate don't work on with mode="time" on Android, there's no implementation for them. I solved it with some simple logic in onDateChange` instead.


Question - behaviour on h264 / h265 packet loss

Hello,
What's the default behaviour when rtp streaming via udp on packet loss, and can it be controlled ?
E.g. in our application, we stream via a lossy unidirectional wifibroadcast link that is protected by FEC but allows for rtp packet loss.
If we lose parts of a h264 frame (e.g. one or more rtp fragmentation units of a frame) we drop it.
But if the next frame is complete, we feed it to the decoder anyways, which might / almost always results in artifacts, but this behaviour is actually preferred in our case.
Can we do that using uvgRtp ?
Also, is there a way to measure the following delay
"first fragment of a fragmented rtp frame is read from the udp port"  -> rtp_receive_hook() is called and/or
"last fragment of fragmented rtp frame is read from the udp port" ->  rtp_receive_hook() is called
Becasue we like to keep an exact track of the latency as frames travel through our display application.
Hope this isn't documented somehwere and I missed it,
Constantin @ OpenHD

Are  RTP H264 type 24 (aggregated NALUs) supported ?

Hm, I am having some weird issue, for some reason uvgRtp seems to always drop the PPS data.
TX: Simple streamer based on libcamera + uvgrtp
RX: QOpenHD application with custom decode.
To analyze, I have some logs - with our current custom / crap rtp decoder (which is what I want to replace with uvgRtp) decode works, and I am getting:
...
Got RTP H264 type [1..23] (single) payload size: 35
Got NALU  39
SPS found
Got RTP H264 type [1..23] (single) payload size: 5
Got NALU  9
PPS found
...
Aka a SPS (size 39) then a PPS (size 9), and ... are key / non-key frames
but with uvgRtp I am getting:
...
Got NALU  38
SPS found
...
I figured out uvgRtp does not always prefix with 0001 - this is why the SPS shows up size 39 with previous, size 38 with uvgRTP.
(And is not an issue)
But for some reason I am never getting the PPS from uvgRTP (or rather any frame sized 9 / 9-1=8 )
Any ideas what's ging on there ?

Debugging a bit more, found out that I get the SPS and PPS when I use a gstreamer tx pipeline AND set
aggregate-mode=1
Aka aggregation seems to be suported in uvgRTP (regarding my earlier question) but for some reason non-aggregated SPS and PPS r.n don't work

Yeah, so for some reason I am not getting 2 successive RTP H264 type [1..23] (single) "frames" (if you count sps / pps as a frame) from uvgRTP as an rx.

Are RTP H264 type 24 (aggregated NALUs) supported ? Aka multiple NALUs (e.g. SPS and PPS) in one rtp packet.

Unfortunately, no, H264 neither STAP nor MTAP aggregate NALUs have not yet been implemented. There is a chance that the STAP reception works by coincidence due to similarity with H265.  I added an issue (#176) for STAP support.
The H264 format in general is the least tested inside our group, since we focus more on H265 and H266 formats.

Hm, I am having some weird issue, for some reason uvgRtp seems to always drop the PPS data in our case. TX: Simple streamer based on libcamera + uvgrtp RX: QOpenHD application with custom decode.
To analyze, I have some logs - with our current custom / crap rtp decoder (which is what I want to replace with uvgRtp) decode works, and I am getting:
... Got RTP H264 type [1..23] (single) payload size: 35 Got NALU 39 SPS found Got RTP H264 type [1..23] (single) payload size: 5 Got NALU 9 PPS found ...
Aka a SPS (size 39) then a PPS (size 9), and ... are key / non-key frames
but with uvgRtp I am getting: ... Got NALU 38 SPS found ...
I figured out uvgRtp does not always prefix with 0001 - this is why the SPS shows up size 39 with previous, size 38 with uvgRTP. (And is not an issue)
But for some reason I am never getting the PPS from uvgRTP (or rather any frame sized 9 / 9-1=8 )
Any ideas what's ging on there ?

Firstly, thank you for bringing this to our attention.
H264 uses three byte start code (001) whereas H265/H266 use four byte (0001), at least that is how I understood it and that might explain the one byte difference.

Debugging a bit more, found out that I get the SPS and PPS when I use a gstreamer tx pipeline AND set aggregate-mode=1
Aka aggregation seems to be suported in uvgRTP (regarding my earlier question) but for some reason non-aggregated SPS and PPS r.n don't work

It is possible that aggregate packet reception works, since the packet structure is essentially the same in h264 STAP as it is h265/h266 aggregate packet (code here).

Yeah, so for some reason I am not getting 2 successive RTP H264 type [1..23] (single) "frames" (if you count sps / pps as a frame) from uvgRTP as an rx. If I embed the SPS & PPS into an aggregation unit (e.g. using a gstreamer tx pipeline) I don't have this issue.

I opened #177 for this bug, we can continue this discussion there.


Barometer (MS5611) Hardware Support

Device, sample and test app.

Implemented in version 1.0.6, checked-in here and released today via NuGet.


Make e2e test run faster

no control plane endpoint IP address
multi-node support
forceful stop VM

Issue #, if available:
Description of changes:
Testing performed:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/test capi-provider-cloudstack-presubmit-unit-test

/check-cla

/easycla

/retest


feat: add support for initial state

This allows you to implement getInitialState in your wizard. This method runs when mounting the wizard.
@freekmurze I chose to implement a method on StepDoesNotExist as this exception was not used before.

I've slightly changed how loading initial state works: https://spatie.be/docs/laravel-livewire-wizard/v1/usage/setting-initial-state


Fixed Error

Fixed error in which the mainMenu question would display twice
Finalized functionality of addEmployee question

conflicts resolved.


update logback and logback-steno versions

minor fixes
remove some unused code
fix host emitter for hocon config

Overall looks good.