DatePicker: Add year change buttons.

Description
We add year change buttons in day selection view to enhance user-experience and fast usage of DatePicker.
https://user-images.githubusercontent.com/78308169/135491984-cf6110e4-8898-4031-a8e4-37f15f4fe045.mp4
How Has This Been Tested?
The year change method was already here, so we can say it's only a visual change.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[ ] I've added relevant tests.

No sorry, its designed like it is and will stay like that for now at least.
The downside of using a component library will always be that every single component might not be exactly as you would want it.


[WIP] Increase spacing on news component

To be updated once the a new version of govuk_publishing_components has been released
This currently uses a branch for some QA checks.
Trello: https://trello.com/c/6bJCf1zv/472-increase-spacing-in-document-list-component
What
This PR bumps the version of govuk_publishing_components to increase the spacing between elements on a document list.
Specific examples can be found in the news section of the /transition page.
Visual Example

Right is current version
Left is new version

Marked this as ready for review so i get a heroku deploy to send to trevor.
Still premature until we get the gem released!

👉 heroku...?
Humm why isn't that app deploying...

@huwd Not sure why it wasn't reporting, but it did actually build a heroku app. I've kicked it off again and it looks like it's appearing here now

No need for this now Depbot exists: https://github.com/alphagov/collections/pull/1500


Add Visual Feedback for Password Copy

Add Visual Feedback for Password Copy
Description
I have added the a tick mark and a short copied message to verify that the message has been copied. A smooth transition has been added to enhance the user experience.
Fixes #2
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Motivation and Context

This is required for better user experience. It was essential for the user to know that if his password has been copied or not.
My commit resolves this issue.
Screenshots (if appropriate):

Checklist:

[x] I have registered myself at Contrihub website.
[x] My code follows the code style of this project.
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] Any dependent changes have been merged and published in downstream modules
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

@chow870 resolve the conflict before try to merge

@Codipk how will I get the write access?


Deprecate old aliases to generate predicates

This was inconsistent with Boost.Geometry.Index and was only there for "backward compatibility".
I want to have the option reclaim these names, hence the deprecation.
This will be ready when all occurrences are replaced.

Why not simply remove it? We don't promise backwards compatibility right now, and can simply update DTK.

I agree. It's not like we have users...

Will do.

I agree - just remove

This is ready for final review/merge.

@dalg24 Do you want to clean the history?


Frequent EXC_BAD_ACCESS crashes, temporarily fixed by clean & rebuild

Description
Lately I've been getting frequent crashes in TCA source code when a related view/reducer becomes active.
The breakpoint usually points to one of a few lines in the scope and pullback methods.

When this happens, a full clean & rebuild always seems to resolve the issue until it inevitably occurs again.
Unfortunately I cannot seem to reliably reproduce the issue, so it's tough to give any useful information.
It does seem to only happen to views/reducers that have been changed since the last build, although I don't want to definitively rule out other situations.
I was wondering if anyone else has encountered this behavior.
I'm using the prerelease branch and navigation beta.
Checklist

[ ] I have determined whether this bug is also reproducible in a vanilla SwiftUI project.
[ ] If possible, I've reproduced the issue using the main branch of this package.
[X] This issue hasn't been addressed in an existing GitHub issue or discussion.

Expected behavior
The app doesn't crash when a related view/reducer becomes active.
Actual behavior
The app crashes when a related view/reducer becomes active.
Steps to reproduce
No response
The Composable Architecture version information
prerelease/1.0
Destination operating system
iOS 16.3.1, iOS 16.4
Xcode version information
Xcode 14.3 14E222b
Swift Compiler version information
swift-driver version: 1.75.2 Apple Swift version 5.8 (swiftlang-<IP_ADDRESS>.2 clang-14<IP_ADDRESS>.100)
Target: x86_64-apple-macosx13.0

@Xythus I think this is unfortunately an incremental compile bug in Swift, especially if you say it's always resolved by a clean. Swift just seems to have more trouble with incrementally compiling these days, especially when it's around generic code like reducers. I'm going to convert this to a discussion since there's not much I think we can do, and because the issue seems to be in the Swift compiler and not in our library.
I'd suggest seeing if you can find a repro in your project (after a clean build that works, figure out what change causes the build to crash) and share that with Apple. Here's hoping this stuff gets better in the next version of Swift!


Q3 2022 sprint

Due date: September 30, 2022
Background
The focus for Q3 will be to add content targeting the "potential client" audience type - i.e. those that may want to hire Compiler.
Tasks

[ ] #6

@thekaveman @angela-tran Let me know if this is the correct use case, but could we use the Github Milestone feature to capture this issue, and add #6 to the milestone?

Closing per @AnthonyRollins suggestion, Milestone created


Problem on es6 import

Hi,
I just need to include trumbowyg in a script.js (with type="module"), so I import simply like this :
import  "../node_modules/trumbowyg/dist/trumbowyg.min.js"
But I have two problem, the first is that a function of jquery is deprecated $.isArray at line 804, so I reccomand you to change with this : Array.isArray and the second problem is about svg button who doesn't appear when I use "import" :

If you have an idea of the problem ?
Edit : It's work when I precise the option "svgPath"
Thanks

I've created an issue for the isArray upgrade, Thanks :)


BiDirectional

Is there any aspirations to make this tool bidirectional, so you can import to SQL from Parquet?

@bkief Yes there is. There is even a branch allowing to insert Strings and 64 Bit integers. https://github.com/pacman82/odbc2parquet/compare/insert.
Since getting all the corner cases right is some work, I thought I let it rest until someone shows interesst in the feature. I guess here we are ;-)
I would really like to know about the use case you have in mind. Would you assume the column names of the table match the ones in the parquet file? Would the parquet file have been created by this tool, or would it have a different source?

Closing this issue since 0.5.10 is released with basic support for insert. If you want let me know if it is already useful to you.


local: add --skip-links to suppress symlink warnings

Give users a way to explicitly acknowledge that symlinks are to be skipped without warnings.
I want an option like this because I sync a drive with tons of symlinks to Google Drive and don't want to be flooded with "Can't follow symlink without -L/--copy-links" messages every single time, which may even bury actually useful/actionable messages.

Of course, --skip-links may not be the most appropriate option name here. Something like --no-warn-skipped-links is more accurate, but more verbose at the same time.

I'll update docs/content/local.md is this idea is approved.

Oh I didn't realize there's already an issue for this 😅 Updated.

That looks great - thank you very much :-)

You're welcome.


drop all old in update.data.R

https://github.com/mpinsky/OceanAdapt/blob/master/R/update.data.R#L14
Instead of unique, just updatedAI <- updatedAI0[1:nrow(oldAI)]. In this case, the rbind() still serves as a formatting check; although it's clearly wasteful and not the most elegant way to ensure names and formats match, so should eventually be changed, too.
@mpinsky We just talked about this, so I turned it into an issue.

@mpinsky Now I remember why I did it this way.
http://www.afsc.noaa.gov/RACE/groundfish/survey_data/data.htm
Do you really want to be going back and downloaded each one of those? I had been doing it that way because the newest .csv's don't contain the entire record.

I see two choices: download them all, or write to the data manager and
verify that the old ones didn't change.
On Monday, August 3, 2015, Ryan Batt<EMAIL_ADDRESS>wrote:

@mpinsky https://github.com/mpinsky Now I remember why I did it this
way.
http://www.afsc.noaa.gov/RACE/groundfish/survey_data/data.htm
Do you really want to be going back and downloaded each one of those? I
had been doing it that way because the newest .csv's don't contain the
entire record.
—
Reply to this email directly or view it on GitHub
https://github.com/mpinsky/OceanAdapt/issues/31#issuecomment-127403310.

--
Please excuse, sent from a device with tiny keys...

OK, sounds good.
If the data manager says "I don't know" or "some of them" or "files A, b, c, ...zz34, z^345 files changed", then we'll have to go download them all anyway.
For the Alaskan data sets, the page looks like it should be very susceptible to automatically downloading everything. These are the data sets that have all the files separate.
I'll think on this for now. I won't be changing my current approach too much at the moment, but I realize now that it could cause problems. What I'm working on right now is a sound and documented approach to adding on the most recent piece of data.

As we discussed today, the approach I would like to take is to download all the data files from each survey, each time we do an update. I do not want us trying to piece old data together with new data.

yep, that's right. working on it right now
On Wed, Aug 26, 2015 at 11:47 PM, mpinsky<EMAIL_ADDRESS>wrote:

As we discussed today, the approach I would like to take is to download
all the data files from each survey, each time we do an update. I do not
want us trying to piece old data together with new data.
—
Reply to this email directly or view it on GitHub
https://github.com/mpinsky/OceanAdapt/issues/31#issuecomment-135282126.


Changes operator name from load -> save to

Describe your changes and why you are making these changes
Change "Load" terminology to "Save to" on UI.
Before:

After:

Related issue number (if any)
https://linear.app/aqueducthq/issue/ENG-1442/rename-load-to-save-in-ui-and-sdk
Checklist before requesting a review

[x] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
[x] I have performed a self-review of my code.
[x] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
[ ] If this is a new feature, I have added unit tests and integration tests.
[ ] I have run the integration tests locally and they are passing.
[ ] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
[x] All features on the UI continue to work correctly.
[ ] Added one of the following CI labels:

run_integration_test: Runs integration tests
skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@hsubbaraj-spiral, is there anywhere on the SDK that uses the word "load" still?


Better HTML Handling

Currently, anything printed to stdout is rendered as HTML. This causes problems in some languages (as per #89).
This PR fixes that by adding a new feature to the Outputter: a toggle-HTML sigil. The Outputter will output as plaintext by default, and only swap to HTML when it sees the sigil.
In order to fix the use-case of creating dynamic HTML elements (as per #83), I added a new magic function: @html(). This works in JS and Python, and prints its first argument surrounded by the sigil.
@show(...), Python's plt.show, R's plot(), and the new @html(...) function all have been altered to use the sigil.
This PR closes #89

The escaping looks to work fine with @html('string') in python, but @show escapes the html in python for me, so the image doesn't show up and instead it's just the html text, and inline plots don't appear correctly:

Although looking into this more, it looks like python plots were broken before this pr. They work fine in master, maybe the python executor doesn't handle this properly? Should look like

import matplotlib.pyplot as plt
import numpy as np

xpoints = np.array([1, 8])
ypoints = np.array([3, 10])

plt.plot(xpoints, ypoints)
plt.show()

@show(...) fixed! I forgot to push those commits; sorry!
Oddly, plt.show seems to work fine for me. What version of Python are you using?

I'm running python 3.10, looking into this a bit more it looks like the output is being split into two separate calls to stdout which is messing it up:

I've just printed that out by adding this to PythonExecutor.ts:
const writeToStdout = (data: any) => {
    let str = data.toString();
    console.log(str);
    // ...

I'm not sure if this is just on my end, but pressing run again after running it the first time causes nothing to be output, and the run and clear buttons disappear. This only happens in notebook mode though.

It's odd that it gets split up. Maybe that's a platform-specific issue that we have to handle w/ buffering?
Weird, I see the same issue with pressing run again. I didn't notice that-- thank you.
When you kill the runtime with the Code Runtime Management command, does the python process disappear?

I did not experience this problem with Python 3.10 (Window 10)

I did not experience this problem with Python 3.10 (Window 10)
if i may ask, are you talking about the splitting issue, or the Notebook Mode re-running issue?

Regarding the splitting issue, @milan338 I think that I fixed it? I'm not sure, but I believe that buffering output until it sees the next toggleSigil will fix that.
I'm trying to fix the re-running issue: it seems that, after the plt.show() block is ran once, stdout stops functioning correctly. I'm fairly certain it's not an issue with flushing the stream, but I'm unsure as to what it is.
I do know that it's an issue with matplotlib specifically. I tested a version without matplotlib, and it works fine:

The plots aren't broken anymore on my end, thanks for the fix. It looks like when the runtime is killed, the process disappears and the run code button returns and the code block can be run again as intended.

It looks like when the runtime is killed, the process disappears and the run code button returns and the code block can be run again as intended.

Great! I was worried that was breaking too. It's wonderful to hear it's working as intended.

I think I've found a fix by changing the matplotlib backen to a non-interactive one like 'agg'. I've submitted a PR for this, the fix works on my end. Other than that, I think this PR is ready to be merged.

It works on my end too. Thank you so much, Milan! I'm just curious, but do you know anything more about the root cause?

I'm still looking into what's causing the issue, I've narrowed it down to plt.plot() on my end, but there's more issues in #108 with showing plots that aren't embedded in the note.

I also see plt.plot() as being the issue.
Since Notebook Mode is relatively new, we could also say that embedding plots is mandatory in Notebook Mode and not break many workflows. Obviously, this isn't a preferred option, but we could use it as a way to get the rest of these fixes (SVG buffering, HTML-escaping, the background process blocking the runtime) out of the door so that users aren't experiencing the bugs.
If we go that route, I could push a co-authored commit by you to this PR so it has the use("agg") fix, then we could leave #108 open and make an issue to note the known problem? Open to discussion on how to get that done / if we should do it :)

Sounds like a good idea, thanks. I think coauthoring the fix into this PR would be best so we're actively tracking the issue in the other open PR. Maybe we shouldn't impose any restrictions right now, just leave it as an open issue and add a description to the settings that toggling embed plots off doesn't work properly with notebook mode yet?

Sounds good 👍

Thank you both so much! Is this PR ready to get merged?

I believe it is 👍 All works fine on my end-- tested Python @show, plt.show(), and @html!

Great!

Can you add an explanation for @html to the Readme?


Chat command - send gold/wood

For some factions such as Legion & KulTiras, you cannot receive resources from any players .
In some situations the entirety of the night elf team cannot trade between themselves .
Issues like this pop up regularly are seem to always be slightly different , no idea of the cause .
A nice QoL change would be a send gold/wood chat command .

I'll do this: https://github.com/AzerothWarsLR/WarcraftLegacies/issues/2095


Additional Spaces

Module: Analyze data with Apache Spark
Lab/Demo: 02
Task: Load data into a dataframe
Step: 09
Description of issue
The code class is the wrong code class as all the rest of the python blocks use language-Python not language-python
Repro steps:

this is how it shows up in the html which is not how it is written in the markdown

 from pyspark.sql.types import *

 orderSchema = StructType([
    StructField("SalesOrderNumber", StringType()),
    StructField("SalesOrderLineNumber", IntegerType()),
    StructField("OrderDate", DateType()),
    StructField("CustomerName", StringType()),
    StructField("Email", StringType()),
    StructField("Item", StringType()),
    StructField("Quantity", IntegerType()),
    StructField("UnitPrice", FloatType()),
    StructField("Tax", FloatType())
    ])

 df = spark.read.format("csv").schema(orderSchema).load("Files/orders/*.csv")
 display(df)

Must have deleted the part about how because it is the wrong class, it seems to be adding an extra space to the front of all the text in the block

Hi @thomasthaddeus perhaps you were interacting with the .md file in Code mode instead of Preview? Those extra spaces are for fixing an issue with leading spaces in Preview mode or HTML and should not be a problem when you copy the code block from those.
Also, enabling syntax highlighting can be done with either Python or python without any differences in the output.
So, for best learning experience I'd recommend doing the lab through its HTML version at https://microsoftlearning.github.io/mslearn-fabric/Instructions/Labs/02-analyze-spark.html

@afelix-95 its still an issue both of these are the same as they were before. I'm looking at the html, the first one is the block i mentioned, the second one is a different block that doesnt have leading spaces.

Heres the code in the sources for both of the previous snapshots.

@thomasthaddeus Thank you for the screenshots and further clarification. Looking again at the code, there was indeed an indentation mistake in the code block of your first screenshot that is omitted in Preview mode but not in the HTML page. It is fixed now.


Pinning should work

currently doesnt
https://github.com/jbenet/go-ipfs/issues/850

Can we get some more info about this? Just based off the references issue and the title I can get to different things.
Files that are pinned using "ipfs pin add -r hash" can not be removed from the webui. Files pinned without -r work fine in the webui.

Agent Version: go-ipfs/0.2.3
Protocol Version: ipfs/0.1.0

Unpinning files from the webui will work after we allow the recursive option to be sent (see #31).
Dropping localStorage is pretty straight forward, though doing so will make it so you can't see any files added via the local daemon (even though the webui only tracked webui files).
Until we have a way to find locally added files the file tab will be blank.

I think files added locally should be noted in the data store somehow

bringing back from a long time ago:

i'd like to have a button like that.

WebUI 2.0.0 is coming soon and it was completely rewritten. Please see #749. We replaced this system with MFS, which allows you to easily delete and add your files.


Sensor Names should be preceaded by Solplanet

Hi, it would be nice if the Sensor Names would be instead of e.g.
Apparent Power -> Solplanet Apparent Power
MPPT 1 power -> Solplanet MPPT 1 Power

As I understand, the main reason for this change is to distinct source of sensors data when we need to select entity (f.ex. on energy dashboard) and we have more than 1 device with the same sensor name. Sensor name could be prefixed with "Solplanet" but it doesn't resolve the problem when we add 2 inverters to home assistant. This case can be resolved with adding new field "Sensor name prefix" on configuration screen, but there is another case which won't be addressed using this method - under single IP address there could be more than one inverter, so every device will get the same prefix.
There is no method (or maybe I don't know it) how to solve it in complex way.
Luckily, Home Assistant has a built-in feature which allows changing the name of the entity.

I agree that this is a solution, but 2 inverters are less common, than having only 1. But I understand your argument, it was just a convenience feature.


Cleanup, USINT reading, compatibility, and BOOL changes

Cleans up some of the formatting

Allows reading of a USINT tag

Adds compatibility for older version of python that don't implement logging module correctly

Changes BOOL evaluation from == 255 to not == 0 to allow reading of BOOL tags in a Micro800

Thanks


Fix, improve and embed API documentation in docs.sui.io

What are the existing URLs containing the issue, if any?
https://docs.sui.io/build
https://playground.open-rpc.org/?uiSchema[appBar][ui:splitView]=false&schemaUrl=https://raw.githubusercontent.com/MystenLabs/sui/main/crates/sui-open-rpc/spec/openrpc.json&uiSchema[appBar][ui:input]=false
How would you describe the issue? (What needs changing?)
We have now:

Duplicate entries, ex. sui_getObject,  sui_getObject

Virtually no context on https://playground.open-rpc.org/ as compared to the previous:
https://app.swaggerhub.com/apis/MystenLabs/sui-api/0.1#/CallRequest

To go to an external site rather than have the API docs embedded as in the Docusaurus-generated site:
https://docs.solana.com/developing/clients/jsonrpc-api

Where should this information land if new? (Learn, Build, Explore, Contribute.)
We need to:

Fix the output
Populate the source files
Embed the contents in docs.sui.io directly

This requesr comes from @longbowlu , who has new API information coming. I've added all relevant parties.
Lu, please take it from here. Thanks!

@Clay-Mysten API are MD files on  https://github.com/solana-labs/solana/blob/master/docs/src/developing/clients/jsonrpc-api.md

I will take a look, there are dups in openrpc.json file, maybe a bug in rpc api doc generation

this PR removes the dups in openrpc.json file, https://github.com/MystenLabs/sui/pull/2668
depends on where the doc site is getting the data from, I might need to merge this into the devnet branch to fix it in the doc site.

Thanks, @patrickkuo !

Adding @bhenhsi as an FYI on this work.


AS3 v3.8.0  in the Docker container does not launch

ISSUE TYPE

Known Issue (internally tracked as #856)

AS3 BUILD/ VERSION

AS3 3.8.0 running in a container

BIGIP VERSION

Any supported version

SUMMARY

When attempting to launch AS3 v3.8.0 from the Docker container (only), AS3 fails during start up. So while the container is functioning properly, there is no AS3 service or endpoints that are available.  If you attempt to send a declaration to AS3 in the container, you receive a 404 “Public URI path not registered” error.
This only affects AS3 running in a Docker container and not the standalone AS3 v3.8.0.  Additionally, the AS3 Container is currently Community Supported only and in the F5Devcentral organization on Docker Hub.  It will move to the F5Networks organization when it is fully supported.
STEPS TO REPRODUCE

Launch AS3 v3.8.0 from the Docker Container, and then attempt to send a GET request to the info endpoint (for example).

EXPECTED RESULTS

AS3 3.8.0 is fully functional and returns AS3 version information.
ACTUAL RESULTS

You receive an error message similar to the following:
{"code":404,"message":"Public URI path not registered: /shared/appsvcs/info","restOperationId":994772,"errorStack":["com.f5.rest.common.RestWorkerUriNotFoundException: Public URI path not registered: /shared/appsvcs/info"
...}

WORKAROUND
If you are not relying on AS3 3.8.0 features, you can use the container with AS3 3.7.0.  Run the same docker command and target 3.7.0 instead of "latest".  For example:
docker run --name as3_container --rm -d -p 8443:443 -p 8080:80 f5devcentral/f5-as3-container:3.7.0

This has been corrected in AS3 version 3.8.1.  Closing this issue.


Add support for workspacerouting managed by external controller

What does this PR do?
Instead of failing a workspace when the routingClass is unsupported, apply an annotation (controller.devfile.io/external_routing) to signify that we expect something else to reconcile the object.
This is to allow an implementation-specific controller to reconcile a workspace routing and have it still be used by the devworkspace controller.
What issues does this PR fix or reference?
Resolves https://github.com/eclipse/che/issues/18520
Is it tested? How?
cat <<EOF | oc apply -f -
kind: DevWorkspace
apiVersion: workspace.devfile.io/v1alpha2
metadata:
  name: theia-failed
spec:
  routingClass: does-not-exist
  started: true
  template:
    projects:
      - name: project
        git:
          remotes:
            origin: "https://github.com/che-samples/web-nodejs-sample.git"
    components:
      - name: theia
        plugin:
          id: eclipse/che-theia/next
      - name: terminal
        plugin:
          id: eclipse/che-machine-exec-plugin/nightly
    commands:
      - id: say hello
        exec:
          component: plugin
          commandLine: echo "Hello from $(pwd)"
          workingDir: ${PROJECTS_ROOT}/project/app
EOF

Message Could not find solver for routing class is logged by workspacerouting controller
Workspace is stuck in "Starting" phase (as no controller for routingClass: does-not-exist exists)
Workspace has annotation controller.devfile.io/external_routing:$ kc get workspacerouting -o yaml | yq '.items[].metadata.annotations'
{controller.devfile.io/external_routing
  "controller.devfile.io/external_routing": "true"
}

Update on the current state of this PR:

I've removed the external routing annotation; instead events are filtered so workspaceroutings with unsupported routingclass are never reconciled by our controller. Deletion events always reach the controller so that finalizers can be cleared
It looks like switching routingClass will not be a problem; we already have it set up so that routingclass in workspacerouting is never changed -- if the devworkspace has an updated routingClass, the old workspacerouting is deleted first.

I'm looking into the timeout and reusability questions separately and will likely file those as a separate PR.

/retest
/test v5-devworkspaces-operator-e2e

This does not seem to be addressed or answered as well.

Are we going to propagate DevWorkspace Operator ServiceAccount to external routing controllers? If no, then possible mutatingWebhooks are going to block external routing controllers. Possible ways I see to solve it:
1.1. DevWorkspace Operator denies to modify only restricted-access workspace related objects which are related to embedded routing classes;
1.2. we declare that workspaceroutings controllers should fail restricted access workspace if they do not brings their specific webhooks;

I'm closing this PR in favor of https://github.com/devfile/devworkspace-operator/pull/219; I initially split them because I thought this PR was near merging but if more work needs to be done we should just use https://github.com/devfile/devworkspace-operator/pull/219


NSpec nuget package dependencies issue

I'm encountering a strange issue using a .Net 4.6.2 console project with NSpec. The packages\NSpec.3.0.4\lib\net451 folder has several older DLL's besides just NSpec.dll, and these are being added as references in my project. One such example is Newtonsoft.Json.dll. Even though I install the nuget package for Newtonsoft.Json <IP_ADDRESS>, the actual referenced DLL is the <IP_ADDRESS>13 DLL sitting in the NSpec package folder.

I checked the NSpec 2.0 nuget package, and it only contains the NSpec.dll file, not all the other dll's I'm seeing currently.

It happened between version 2.0.1 and 3.0.0. I think it might have something to do with adding Microsoft.Extensions.Testing.Abstractions and Newtonsoft.Json to NSpec's project.json file.

Hi there
Newtonsoft.Json, >= 9.0.1, is an expected dependency in recent NSpec versions: JSON is needed to communicate with new test runners.
What looks strange is that package also contains some NuGet.* DLLs, not sure why: we'll double check on that.
Back to your issue:

to which project do you see DLLs added? If that's the test project, well that's ok.
and , to which project you'd like to install Newtonsoft.Json v10? If that's still the test project, maybe you can try adding an app.config to your test project, listing an assemblyBinding like:

    <assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
      <dependentAssembly>
        <assemblyIdentity name="Newtonsoft.Json" publicKeyToken="30ad4fe6b2a6aeed" culture="neutral" />
        <bindingRedirect oldVersion="<IP_ADDRESS>-<IP_ADDRESS>" newVersion="<IP_ADDRESS>" />
      </dependentAssembly>
    </assemblyBinding>

and then launch a reinstall from Package Manager Console:
PM> Update-Package –reinstall -Project YourTestProject

Does that make sense?

Just fixed the .NET Framework example solution, as it was not propertly upgraded to NSpec 3.0.4. As mentioned, I did a package reinstall to start with a clear state.
Then manual editing of app.config was not really needed: I went to Manage Package for Solution and choose to upgrade Newtonsoft.Json to <IP_ADDRESS>. This is what I got from Output window:

Attempting to gather dependency information for package 'Newtonsoft.Json.10.0.1' with respect to project 'test\LibrarySpecs', targeting '.NETFramework,Version=v4.5.2'
Gathering dependency information took 2,4 sec
Attempting to resolve dependencies for package 'Newtonsoft.Json.10.0.1' with DependencyBehavior 'Lowest'
One or more unresolved package dependency constraints detected in the existing packages.config file. All dependency constraints must be resolved to add or update packages. If these packages are being updated this message may be ignored, if not the following error(s) may be blocking the current package operation: 'Newtonsoft.Json 9.0.1'
Resolving dependency information took 0 ms
Resolving actions to install package 'Newtonsoft.Json.10.0.1'
Resolved actions to install package 'Newtonsoft.Json.10.0.1'
Retrieving package 'Newtonsoft.Json 10.0.1' from 'nuget.org'.
GET https://www.nuget.org/api/v2/package/Newtonsoft.Json/10.0.1
Removed package 'Newtonsoft.Json.9.0.1' from 'packages.config'
OK https://www.nuget.org/api/v2/package/Newtonsoft.Json/10.0.1 429ms
Installing Newtonsoft.Json 10.0.1.
Successfully uninstalled 'Newtonsoft.Json.9.0.1' from LibrarySpecs
Adding package 'Newtonsoft.Json.10.0.1' to folder 'D:\WS\NET\NSpec-framework\NSpec\examples\NetFrameworkSample\packages'
Added package 'Newtonsoft.Json.10.0.1' to folder 'D:\WS\NET\NSpec-framework\NSpec\examples\NetFrameworkSample\packages'
Added package 'Newtonsoft.Json.10.0.1' to 'packages.config'
Executing script file 'D:\WS\NET\NSpec-framework\NSpec\examples\NetFrameworkSample\packages\Newtonsoft.Json.10.0.1\tools\install.ps1'...
Successfully installed 'Newtonsoft.Json 10.0.1' to LibrarySpecs
Removing package 'Newtonsoft.Json.9.0.1' from folder 'D:\WS\NET\NSpec-framework\NSpec\examples\NetFrameworkSample\packages'
Removed package 'Newtonsoft.Json.9.0.1' from folder 'D:\WS\NET\NSpec-framework\NSpec\examples\NetFrameworkSample\packages'
Executing nuget actions took 17,64 sec
========== Finished ==========
Time Elapsed: 00:00:22.3482400

I ended up royally screwing up my project and had to revert back to my last commit, so I am close to where I was when I started having issues.
Additionally, when running the test project with a test that uses AspNetCore TestServer, I get the following error:
Context Failure: Could not load file or assembly 'Microsoft.Extensions.DependencyModel, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040), Example Failure: Object reference not set to an instance of an object.
   at Microsoft.AspNetCore.Mvc.Internal.DefaultAssemblyPartDiscoveryProvider.DiscoverAssemblyParts(String entryPointAssemblyName)
   at Microsoft.Extensions.DependencyInjection.MvcCoreServiceCollectionExtensions.GetApplicationPartManager(IServiceCollection services)
   at Microsoft.Extensions.DependencyInjection.MvcCoreServiceCollectionExtensions.AddMvcCore(IServiceCollection services)
   at Microsoft.Extensions.DependencyInjection.MvcServiceCollectionExtensions.AddMvc(IServiceCollection services)

So, I figure, ok, I'll just add the package to the test project, but that leads to ANOTHER failure where I'm notified that Context Failure: Could not load file or assembly 'SimpleInjector.Extensions.ExecutionContextScoping, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=984cb50dea722e99' or one of its dependencies.
At this point, I start adding all the same packages as the main one. (Looking at it now, it appears that the test project is not getting the DLLs from the sub packages that are not "explicitly" defined in the main project. Packags.config adds every sub dependency reference, but the dotnet core csproj files do not.)
Once all the main packages are added to the test project, THAT is when I start getting the Context Failure: Could not load file or assembly 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
While I understand that Newtonsoft.Json is now a dependency, in my opinion, it (along with all other dependency DLLs) should not be internal to the NSpec nuget package. Let Nuget handle adding NSpec's dependencies. As of now, I will have to figure out someway to get the references to point to their correct locations, and not NSpecs internal DLLs.

While I understand that Newtonsoft.Json is now a dependency, [...]

We'll have a look at what is the best practice for this: you might well be right, and hence all non-NSpec DLLs could be removed from package.

@BennieCopeland try with latest release, 3.0.5. All those transitive dependencies DLLs have been removed from package, and at least when testing with our examples, they are not re-added as references, nor are found in *bin* folder.
Newtonsoft.Json remains an explicit dependency, anyway its DLL is not packed with NSpec, so when you install NSpec, nuget will also install Newtonsoft.Json and add it as a package reference to you test project. But, differently than before, its hintpath points to its own package directory, not to a DLL beneath NSpec package directory.
HTH
OT shortly there'll be another smaller upgrade, as currently it seems NSpecRunner fails to run from command line.

@BrainCrumbz Looks good. I created a new project, and it pulled in the Newtonsoft.Json dependency as a new packages.config reference.

Great!
Out of curiosity, what happens to that dotnet issue you opened? Does it still make sense?

Yes. There is still an issue of the test project not getting all the DLL's of the main project. In classic Nuget, when you add a package, it adds explicitly adds its sub dependencies to the packages.config. In .Net Core projects, those sub dependencies are not explicitly added. I think that is causing an issue when referencing a .Net 4.6.2 ASP.Net Core csproj from a standard .Net 4.6.2 Console app. The console app, doesn't see that it needs these 10 other DLL's that are sub dependencies for some top level package.

@BrainCrumbz Is Newtonsoft.Json still required with the new(old) build tools? See: https://github.com/dotnet/cli/issues/4921


Fix automatic build for pull requests

Builds for PRs were failing because they were for non-master branches.  @mmitche  is helping to 'branchify' the netci.groovy to avoid this in the future.

@EMaher This should be done now.

@mmitche Yep.  Thanks for the help!


Keep Sketch Window in Background

On every save the Sketch window gets active, while the editor loses focus.
Expected behavior:
Would be nice if the focus would stay in the text editor, also after saving.
Observed behavior:
On every save in the text editor, the re-rendering happens, and the Sketch window becomes active.
How to reproduce:
Save.
Sketch version:
43.2

Like #48, this is a thing we need Sketch to help us with :( cc @bomberstudios

🎊  I have this working on a branch of skpm! Will submit a PR shortly :)

Awesome!


Debounce window resize events

Everytime a resize event fires on the plotting page you immediately backlog a TON of events to redraw the plots which causes the backend to become overwhelmed.
http://davidwalsh.name/function-debounce
var trigger = _.debounce(function() {
  self.trigger('window:resize');
});
$(window).on('resize', trigger);

Since you're using backbone, I would suggest adopting this
"use strict";
/*
 * projects/public/javascripts/models/WindowModel.js
 */

var WindowModel = Backbone.Model.extend({
  initialize: function() {
    _.bindAll(this, "setSize");
    this.setSize();
    var caller = _.debounce(this.setSize);
    $(window).on('resize', caller);
  },
  setSize: function() {
    this.set({
      width: $(window).width(),
      height: $(window).height()
    });
    this.trigger('resize', this);
  },
  defaults: {
    width: 0,
    height: 0
  }
});

@birdage Thoughts?

@DanielJMaher this is a good idea. how often are we triggering the resize?

bump


docs(bearer) Initial commit plugin

Add Bearer plugin to the hub

Hi @cfabianski: We apologize, but we are not reviewing or merging PRs for new plugins at this time. We will continue to evaluate PRs related to plugins that already exist on the Plugin Hub. We encourage you to host your plugin documentation in your own plugin repo README. Thank you for your continued involvement in the Kong community!


Refactor third set of extension structs

Please note that while we are transitioning from travis-ci to AWS CodeBuild, some tests are run on each platform. Non-AWS contributors will temporarily be unable to see CodeBuild results. We apologize for the inconvenience.
Description of changes:
Move the next 3 extensions into the new structures. For each extension, I:

create the struct
move current send and receive logic into static methods linked to the struct
write static should_send method based on the existing logic in s2n_client_extensions
replace current send and receive methods with calls to s2n_extension_send/recv
remove type + size from what the send method sends

Call-outs:
This is part of a larger task: https://github.com/awslabs/s2n/issues/1817
The existing send/receive methods are left for now, but reference the new methods.
We were sending the ecc_points_format extension from the supported_curves extension's send method. To maintain backwards compatibility with minimal changes, I just continued to send the ecc_points_format from the legacy supported_curves send function.
Testing:
I add unit tests for extensions that didn't already have them. My unit tests for supported groups don't look sufficient, but most of the logic is already tested by s2n_choose_supported_group_test.c and s2n_parse_client_supported_groups_list_test.c.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1894 into master will decrease coverage by 0.15%.
The diff coverage is 83.63%.

@@            Coverage Diff             @@
##           master    #1894      +/-   ##
==========================================
- Coverage   81.51%   81.35%   -0.16%
==========================================
  Files         229      229
  Lines       17014    17229     +215
==========================================
+ Hits        13869    14017     +148
- Misses       3145     3212      +67


Compiler Exception (Bridge 1.15)

Steps To Reproduce
http://deck.net/fd2b13ec316e9d62c7cef0dcd5ec43e6
public class Test
{
    public const String s = "Const";
    public void TestMethod()
    {
        var a = new List<object>{s};
    }
}

//with static too
public class Test
{
    public static int s = 1;
    public void TestMethod()
    {
        var a = new List<int>{s};
    }
}

// this one OK
public class Test
{
    public int s = 1;
    public void TestMethod()
    {
        var a = new List<int>{s};
    }
}

@AndreyZM - Thanks for the report and excellent sample demonstrating how to reproduce the issue. We are working on a fix and will include in the upcoming Bridge 15.0 release.


Suggestion: improved Frenzy calculations

I noticed the current calculations for Lucky and Lucky with frenzy don't seem to include the next upgrade/building bought and how much CPS it produces.
I understand that adding this in the calculations might be confuse some users, perhaps a toggle would be more useful.
Thanks.

The warning includes this already.  It's an option.  I can't predict what one would buy next, so I don't know what to add to Lucky!

Ups... i didn't see it the first time i checked the options and here it is now.
How do i close this suggestion thing ?
BTW thanks for the quick reply. You rock.

Thanks.  You can close it with the close and comment button, or I can close it for you.

Thanks to you, I noticed I need to group that option with the two new options coming up relating to calculation.  =)


Deselect when changing lists

Previously the selected person was not deselected in model even though UI shows the deselection (when switching lists, filtering, finding etc)
Changes in this PR:
Deleting the last person now selects the next last person.
Deselection is done on changing lists, filtering, finding, clearing, or deleting the last person.
Sort and filter are now non-undoable commands
Bugs created from this PR that will be fixed in the future:
Redoing a non-indexed delete command causes a jump to wrong index.
Deleting a person with a smaller index than the currently selected person will cause the unintended person to be selected.

Coverage increased (+0.03%) to 91.74% when pulling cfd28d51527e25fc15d6445a6b480aedc08ee79f on khooroko:Deselect_when_changing_lists into 41a0d296c3cfa9e4853174a3a53e26e2ca5207d6 on CS2103AUG2017-T17-B1:master.

Coverage increased (+0.03%) to 91.74% when pulling cfd28d51527e25fc15d6445a6b480aedc08ee79f on khooroko:Deselect_when_changing_lists into 41a0d296c3cfa9e4853174a3a53e26e2ca5207d6 on CS2103AUG2017-T17-B1:master.


adds support for composed types deserialization in abstractions

related https://github.com/microsoft/kiota/pull/1603

@baywet OkHttp and Serialization checks wont pass since they take a dependency on the changes to abstractions that you've made. If it all builds locally I suggest we allow this to pass.


fix(api): Including source event in the api destined invocation

Coverage Report

Totals

Statements:
95.44% ( 5003 / 5242 )

Methods:
91.26% ( 188 / 206 )


Update how-to-format-your-csv-file-for-data-content-migration.md

Some smaller fixes and some clarifications on what needs to go into the CSV file

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

Suggestions committed, all ok for me

@JoanneHendrickson PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Add Dev and Project labeling / refactoring labeling and annotations

What type of PR is this:

/kind feature
/kind cleanup
What does this PR do / why we need it:
In this PR we:

Correctly name all the labels in a more concise manner (ex. Project Type
is an annotation)
Add Dev and Deploy mode labels to both odo dev and odo deploy
commands so that we can intuitively retrieve what components are in
deploy or dev mode
Somewhat refactors how we do labeling

Which issue(s) this PR fixes:

1/2 of PR's for https://github.com/redhat-developer/odo/issues/5405
PR acceptance criteria:

[X] Unit test

[X] Integration test

[X] Documentation

How to test changes / Special notes to the reviewer:
N/A
Signed-off-by: Charlie Drage<EMAIL_ADDRESS>

@cdrage Can you make this PR a priority? I think it will be helpful for the odo delete PR that I am working on.

You will need to run go fmt ./... to format files correctly:
gofmt ERROR - These files are not formated by gofmt:
./pkg/component/component_test.go
./pkg/component/labels/labels_test.go
./pkg/devfile/adapters/kubernetes/component/adapter_test.go
./pkg/kclient/fake/ingress.go
./pkg/storage/labels/labels_test.go
./pkg/testingutil/deployments.go
./pkg/testingutil/routes.go
./pkg/url/labels/labels_test.go

/test v4.9-integration-e2e

/lgtm

/approve


Dates disappear when sorting by Action "Cancelled" on Transaction pg

see screenshot missing dates...

we dont have cancellation dates - closing


Add keybinding shortcut for "Preserve case" replace option

This PR resolves #107208 with

Adding "togglePreserveCase" command actions for editor and search view with default keybinding of "alt-(cmd)-p"
Adding keybinding label to ReplaceInput and ContextScopedReplaceInput classes.

Related to #107588.

Is there anything I need to do about the failure of VS Code check?

Looks good to me but we are in our endgame week for the next release and I will review and merge it next week.

Thanks! I see.

@roblourens Thank you for reviewing and merging! This is my first decent contribution to OSS. I'm very happy 😃

Congratulations! I hope to see more from you 😁


[1.10.2] Vertical Fluid Conduits Texture Missing

Issue Description:
Fluid and Pressurized Fluid Conduits, when placed vertically becomes invisible. Problem however does not occur when fluids are passing through it, only when empty.
Screenshots Provided:

https://i.zxicar.us/dttxa18_Y4v7.png - Conduit texture in the middle is missing.
https://i.zxicar.us/y3HEGcF_7bKO.png - Ditto, longer vertical conduit line.
https://i.zxicar.us/8RnS3E1Haq9C.png - Problem however does not occur when any conduits are connected to it horizontally.

Affected Versions (Do not use "latest"):

EnderIO: EnderIO-1.10.2-<IP_ADDRESS>_beta
EnderCore: EnderCore-1.10.2-<IP_ADDRESS>-beta
Minecraft: 1.10.2
Forge: forge-<IP_ADDRESS>7

Your most recent log file where the issue was present:
N/A - Not a crash.

Seen this in 112 too, not limited to vertical either, Seen it happen in horizontal ones that have been placed for a while and were visible at the start (Typical that I cant find any doing so now)

Finally seen a conduit being invisible to grab a screenshot.

Some added quirkiness scrolling through the wrench view modes through to power shows the conduit but back to "show all" view it returns to rendering invisible again.

This may help. Possibly.


update example futures pulldown_cmark to v0.9

update example futures pulldown_cmark to v0.9

LGTM. I'll approve once the CI is fixed


Optional integration of mamba?

With mamba, there is now a much faster drop-in-replacement for conda. There is now also a flavor of miniforge with mamba as the default package manager.
From what I can see in your code, the conda command is hard-coded. Could this be made configurable so that a user could switch to mamba? The CLI remains compatible, so conda-manager should continue to work as is.

Unfortunately, this project has been unmaintained for the past 5 years, and I'm not sure its actively used anymore. We eventually hope to integrate similar functionality in Spyder, perhaps with Spyder 6, and so long as mamba is API-compatible, Spyder could potentially prefer mamba if it is present on the PATH or otherwise easily accessible. But that's still pretty hypothetical at this point, since we're still working on the final release and early stabilization of Spyder 5.


Loading all chunks in development mode

When webpack is in development mode, it loads all the chunks in my page as opposed only those needed in development.

It looks like you just deleted/ignored our lovely crafted issue template. It was there for good reasons. Please help us solving your issue by answering the questions asked in this template. I'm closing this. Please open a new issue with filled issue template. Also make sure your issue is not a question. Questions should be posted on Stack Overflow.


Add a Shrines History Guide to help players locate all 120 Shrines in BOTW.

Hints unlock based on correct answers to BOTW trivia questions and credits spent, providing an interactive hint system. This includes trivia prompts, tiered hints, and integration with the in-game credit system.

Shrine history document has been added.


setLocalStorageItem(key, value) Example

Hello, can you please provide an example of how and where to setLocalStorageItem(key, value) within the code? I am unable to setLocalStorage with my token and have tried many different ways to no avail. Your response is very much appreciated. Thanks!

I'm not that familiar with this function. A quick google search came up with this: https://github.com/DevExpress/testcafe/issues/1325 . Hopefully this helps.

@cpeople2 Did u manage to get it work?

@cpeople2 Here is an example I have used.
Given(/^I set a key as true in localStorage$/, async () => {
  let setKey = ClientFunction(() => localStorage.setItem('localStorageKey', 'true')).with({ boundTestRun: testController });
  await setKey();
});


Config Server Provider Config Setting value for Timeout

Is your feature request related to a problem? Please describe.
We currently have a lot of apps running on Tanzu Application Service using the Steeltoe Config Server Provider.  We've noticed at times some apps are failing to retrieve config values from a bound Spring Cloud Config Server service instance.  We finally determined that the bound SC config server service instance was taking too long to respond to the .NET app and the Steeltoe Config Server Provider was dropping the connection.  We determined the Config Server Provider default timeout is set to 6000 ms, which seems low and kind of an arbitrary number.  Should this have been 60 seconds (60000 ms), which aligns with the default timeout for the Java Spring Cloud Client?   To address the issue, all of our application owners had to override the default in their appsettings.json file to something like:
"spring": {   "application": {     "name": "my-app"   },   "cloud": {     "config": {       "timeout": 30000     }   } },
Describe the solution you'd like
Can the default timeout value be set to 60000 to align with the Java Spring Cloud Client default timeout?
Describe alternatives you've considered
None
Additional context
None

Thanks for finding and reporting this... I'll update the default timeout value to 60.


[BUG] The spatial sound WebGL function is not woring with voice

Describe the bug
The voice from other player doesn't apply the spatial sound setting
To Reproduce
Steps to reproduce the behavior:

Go to ' https://webgl.agoraguru.net/Spatial/index.html'
Change all setting values
Speak To and Listen from other client

Expected behavior

Apply setting values to client voice

Screenshots
Desktop (please complete the following information):

OS:  Windows
Browser Chrome
Version 104.0.5112.102

I tried too. its not working.
using agora_gaming_rtc;
using System;
using System.Collections;
using System.Collections.Generic;
using System.Linq;
using UnityEngine;

public class SpatialAudio : SocketBehaviour
{
    static Dictionary<SocketUser, SpatialAudio> spatialAudioFromPlayers = new Dictionary<SocketUser, SpatialAudio>();
    public float radius;
    IAudioEffectManager agoraAudioEffects;
    [ReadOnly]
    public string agoraID;
    // Start is called before the first frame update
    void Start()
    {

    }

    public override void OnNetworkInitialize(SocketUser user)
    {
        base.OnNetworkInitialize(user);
        agoraAudioEffects = AgoraVoiceChatManager.Instance?.GetRtcEngine()?.GetAudioEffectManager();
        spatialAudioFromPlayers[user] = this;
    }
    // Update is called once per frame
    void Update()
    {
        if (!Player.isLocal || Player.test)
            return;

        foreach(SocketUser user in SocketNetwork.GetActiveUsers())
        {
            if (user.isLocal) continue;
            if (spatialAudioFromPlayers.ContainsKey(user))
            {
                SpatialAudio other = spatialAudioFromPlayers[user];
                if (!string.IsNullOrEmpty(other.agoraID))
                {
                    float gain = GetGain(user.transform.position);
                    float pan = GetPan(user.transform.position);
                    agoraAudioEffects.SetRemoteVoicePosition(uint.Parse((string)other.agoraID), pan, gain);
                    TestDebugger.Log($"Gain: {gain}  Pain: {pan} of {user}");
                }else
                {
                    agoraAudioEffects.SetRemoteVoicePosition(uint.Parse((string)other.agoraID), 0, 0);
                }

            }

        }
    }

    internal void CmdSendAudioNetworkAudio(uint uid)
    {
        agoraID = uid.ToString();
        SocketNetwork.SendRPC(nameof(UpdateNetworkAudioUid), viewId, new object[] { agoraID });
    }

    float GetGain(Vector3 position)
    {
        float distaince = Vector3.Distance(transform.position, position);
        return Mathf.Max((1 - distaince / radius),0) * 100f;
    }

    float GetPan(Vector3 position)
    {
        Vector3 dir = position - transform.position;
        dir.Normalize();
        return Vector3.Dot(transform.right, dir);
    }

   [ServerRPC]
    public void UpdateNetworkAudioUid(string uid)
    {
        agoraID = uid;
    }
    private void OnDestroy()
    {
        foreach (var item in spatialAudioFromPlayers.Where(x => x.Value == this).ToList())
        {
            spatialAudioFromPlayers.Remove(item.Key);
        }
    }
}

@lucas-kl , you may have been confused about what the demo is about.  This demo only shows the change for the local user's spatial audio as a API test.  There is no reflection to the remote user's end.  The APIs are manipulating the sound of each remote user at the local client's perception and such change won't apply as the stream to send to other people.

@staqchani You are using non WebGL-supported API SetRemoteVoicePosition here.

@icywind i'm sure it doesn't work on both cases

OK thanks I'm changing my script according to new SDK

Hi @icywind When we will expect to resolve this issue?

Refactor6 fixed Spatial Audio issue.  Please see release section or announcement.


no need for nodemon, Babel already has watch mode

Alright
Another rebase ? (sry I did change this recently without checking PRs...)

done.

Thanks


Add host object to custom timers

The custom timer payloads do not have the host object but need it as it contains the info needed to generate the UUID

So you want them to be POST instead of GET?

Closed in #190


the width of space is only half character

VSCode Version: 1.42.1
OS Version: Ubuntu 18.04

Steps to Reproduce:

the width of space is only half character!

Does this issue occur when all extensions are disabled?: Yes

/needsMoreInfo
What font is used in editor that causes problem?
Is it reproducible it in Insiders build? https://code.visualstudio.com/insiders/

This issue has been closed because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


react-router demo does not work

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
When i click on the buttons in the demo the URL does not change.
Expected Behavior 🤔
When i click on the buttons in the demo the URL changes.
Steps to Reproduce 🕹

Open https://material-ui.com/guides/composition/#routing-libraries
Click the pen icon to "edit in codesandbox".
click the stacked window icon above the embedded browser to "Open in new window".
Click on the links and observe that the routes does not change.

Your Environment 🌎
$ google-chrome --version
Google Chrome 90.0.4430.93
$ uname -a
Linux monika 5.11.17-300.fc34.x86_64 #1 SMP Wed Apr 28 14:21:28 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

tip: the demo uses a memory router by default

Ah, thank you i missed that.


[bug]: DateTimePicker changes date automatically (only for some timezones?)

What version of strapi-design-system are you using?

Strapi Design System version: 1.8.1

What's Wrong?
When selecting a date in the DateTimePicker, that date minus one day is shown in the UI. If you click on the corresponding label, another day is subtracted from the date.
Possibly related to timezones and this PR for the DatePicker. I'm in the GMT+2 timezone.
To Reproduce

Go to the DateTimePicker in Storybook
Select today's date
See that yesterday's date is show in the UI
Click on the 'Publish at' label
See that another day is subtracted in the UI

Possibly related to the users timezone. I'm in GMT+2
Expected Behaviour
I expect the date I pick to be shown in the UI, and for it not to change when I click the label.

Same to me, I'm GMT+8

I opened the same issue in the Strapi repo --> https://github.com/strapi/strapi/issues/17538

There's a fix pending review: https://github.com/strapi/design-system/pull/1241
You can see the fix in action here.


Release 23.11 was tagged before version bumps were made in the source

Release 23.11 was tagged before aa473b3, so version numbers in the program still show as 23.10.

Which platform? Tested on Windows and Linux

$ mediainfo --version
MediaInfo Command line,
MediaInfoLib - v23.11
$ apt info mediainfo
Package: mediainfo
Version: 23.11-1

Fixed now


[Tuning][MI200][LWPTUNA-1] Tuning for SuperBench

release/rocm-rel-5.1 based tuning for SuperBench

@cderb @junliume Was this ported into develop?

@cderb @junliume Was this ported into develop?

Hi @cderb  I think this tuning together with #1500  need to be ported to develop too. Thanks!


legend of subfigures overlapping

I've got some problems with overlapping legends:
sc.pl.umap(adata_pp, color=["treatment", "mixture_assignment"])

Is there something I can do about this?

You can increase the distance between plots by setting wspace=0.3
(default is 0.1). Otherwise you can do:  ncols=1 or  legend_loc='on data.
On Mon, Nov 19, 2018 at 5:12 PM Florian R. Hölzlwimmer <
<EMAIL_ADDRESS>wrote:

I've got some problems with overlapping legends:
sc.pl.umap(adata_pp, color=["treatment", "mixture_assignment"])
[image: grafik]
https://user-images.githubusercontent.com/1200058/48719273-60f9f200-ec1d-11e8-8cab-08434ad02411.png
Is there something I can do about this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/theislab/scanpy/issues/368, or mute the thread
https://github.com/notifications/unsubscribe-auth/AEu_1S9nFS4TDVTF0H3nNSFCtXjAutOUks5uwth2gaJpZM4YpbLy
.

@fidelram Thanks for your help, wspace=0.3 perfectly solves this problem :+1:


Support eol boolean response from endoflife.date

Issue
endoflife.date can return either a datestring or a boolean for the value in eol for a particular cycle. Support that response as well.
See the Rails 7 response as an example.
To reproduce
in the console:
irb(main):001:0> EOL.info('ruby', cycle: '2.6').supported?
=> false
irb(main):002:0> EOL.info('rails', cycle: '7.0').supported?
lib/eol_rb/models/cycle.rb:11:in `parse': no implicit conversion of false into String (TypeError)

        @eol = Date.parse(specs.fetch("eol"))
                          ^^^^^^^^^^^^^^^^^^
	from lib/eol_rb/models/cycle.rb:11:in `initialize'
	from lib/eol_rb/cycle.rb:26:in `new'
	from lib/eol_rb/cycle.rb:26:in `get'
	from lib/eol_rb.rb:43:in `info'
	from ~/.rbenv/versions/3.2.2/lib/ruby/3.2.0/forwardable.rb:240:in `info'
	from (irb):2:in `<main>'
	from bin/console:20:in `<main>'

Working on this!


Windows Server 2016

Any update about the support for Windows Server 2016 (maybe using SharePoint Server 2013 with SP1)?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 171d6bb7-4f08-573b-a2c7-5e78add14340
Version Independent ID: 8c204184-9c39-727c-2ac3-6106be7ce1b8
Content: Hardware and software requirements for SharePoint 2013
Content Source: SharePoint/SharePointServer/install/hardware-and-software-requirements-0.md
Product: sharepoint-server-itpro
GitHub Login: @Techwriter40
Microsoft Alias: kirks

@Luigi, thank you for your comment. At this time, Windows Server 2016 is still not supported. If it changes, I will let you know. thanks .

Thank you @Techwriter40.
It is important due to the questions asked by users in SharePoint Forums.


Adding package rerun failures to auto rerun flaky tests

Proposed changes:

https://pypi.org/project/pytest-rerunfailures/#toc-entry-8

LGTM 🚀


Does not compile my code

Hey there
I'm probably using it wrong. But how actually do I use this package?
$(npm bin)/typedoc --out ./test_doc --mode file --excludeExternals --externalPattern node_modules

Using TypeScript 2.3.2 from $HOME/Development/giuseppe/node_modules/typedoc/node_modules/typescript/lib
Error: $HOME/Development/giuseppe/node_modules/@types/highlight.js/index.d.ts(18)
 Cannot find name 'Node'.

So actually my goal is to just run the type doc over my own source (in the ./src) folder. I don't want it to index or compile node_modules or whatever. But I can't get it to run.
What do I do wrong?
Cheers
Chris
edit: I read the documentation, but whatever I configure, it just fails.

never mind, I got it running :-)

Ok I just found the following out:
When you want to use it from npm itself (npm install --save-dev and then npm run whatever), you get the error. If you install it globally, there are no problems.


Review DataCatalog Summary/Details

Right now in the connectors/data_catalog.py class we're pulling in details at the same time as pulling in summary.. lets split those two apart so that requests are 'lighter'.
NOTE: The dashboard NEEDS the details to be in the summary right now, so that will also have to be refactored as part of this ticket.

seem fine, closing ticket.


When using graphql_query with pytest, an error occurs: Deprecated in Pydantic V2.0 to be removed in V3.0.

Describe the bug
when I use graphql_query with pytest, here is the error message. What I am confused about is that if graphql_query is used alone, this error will not be reported. Please pay attention to this issue. Thank you.
    from graphql_query import Argument, Directive, Field, Operation, Query, Variable
../../../../venv/lib/python3.11/site-packages/graphql_query/__init__.py:5: in <module>
    from .types import Argument, Directive, Field, Fragment, InlineFragment, Operation, Query, Variable
../../../../venv/lib/python3.11/site-packages/graphql_query/types.py:41: in <module>
    class _GraphQL2PythonQuery(PydanticBaseModel):
../../../../venv/lib/python3.11/site-packages/pydantic/_internal/_model_construction.py:90: in __new__
    config_wrapper = ConfigWrapper.for_model(bases, namespace, kwargs)
../../../../venv/lib/python3.11/site-packages/pydantic/_internal/_config.py:120: in for_model
    config_from_namespace = config_dict_from_namespace or prepare_config(config_class_from_namespace)
../../../../venv/lib/python3.11/site-packages/pydantic/_internal/_config.py:271: in prepare_config
    warnings.warn(DEPRECATION_MESSAGE, DeprecationWarning)
E   pydantic.warnings.PydanticDeprecatedSince20: Support for class-based `config` is deprecated, use ConfigDict instead.
Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.5/migration/

Hello, thank for report of this bug!
I will check this problem soon. Can you give an example of a test with this error?

import requests
from graphql_query import Argument, Directive, Field, Operation, Query, Variable

dd = 'str1 str2 str3 str4 str5 str6'

class demo:
    def getData(self, sort_field, reverse, data_type, input):
        get_asset = Query(
            name="get_data",
            arguments=[Argument(name="sort_field", value=sort_field),
                       Argument(name="reverse", value=reverse),
                       Argument(name="data_type", value=data_type),
                       Argument(name="input", value=input),
                       ],
            fields=[
                Field(name="color", fields=[dd]),
                Field(name="count")
            ]
        )
        operation = Operation(type="", queries=[get_asset])
        return operation.render()

    def result(self):
        return {
            "query": self.getData(sort_field='"green",', reverse='false,', data_type='"red",',
                                   input='["a","b","c","d","e","f"],')
        }

print(demo().result())
data = demo().result()

your_url = ''
your_header = {}

# method 1
r = requests.post(url=your_url, json=data, headers=your_header)
print(r.status_code)
print(r.json())

# def test_query():
#     # method 2
#     r = requests.post(url=your_url, json=data, headers=your_header)
#     print(r.status_code)
#     print(r.json())

'''
Replace with your URL, header, and parameters
then apply Method 1 and Method 2 separately.
Method 1 succeeds, while Method 2 results in an error.

Python 3.11.5
pytest 7.4.2
pydantic 2.5.3
pydantic_core 2.14.6
graphql_query 1.2.0
'''

The following PR fixed your problem https://github.com/denisart/graphql-query/pull/32
Available in version 1.3.0 https://github.com/denisart/graphql-query/releases/tag/v1.3.0


BadAckMessage: Auth ack msg too short: 0

What is wrong?
    INFO  06-12 13:10:22        peer  Adding peer: LESPeer <Node(0x053d@<IP_ADDRESS>)>
   DEBUG  06-12 13:10:22        peer  Connecting to <Node(0x94c1@<IP_ADDRESS>)>...
   DEBUG  06-12 13:10:24  lightchain  fetched headers from 1 to 192
    INFO  06-12 13:10:24        peer  Got bad Ack during peer connection
   DEBUG  06-12 13:10:24        peer  Got bad Ack during peer connection
Traceback (most recent call last):
  File "/home/jcarver/code/py-evm/p2p/peer.py", line 654, in connect
    self.cancel_token))
  File "/home/jcarver/code/py-evm/p2p/service.py", line 32, in wait
    return await self.wait_first(awaitable, token=token, timeout=timeout)
  File "/home/jcarver/code/py-evm/p2p/service.py", line 51, in wait_first
    return await wait_with_token(*awaitables, token=token_chain, timeout=timeout)
  File "/home/jcarver/code/py-evm/p2p/cancel_token.py", line 119, in wait_with_token
    return done.pop().result()
  File "/home/jcarver/code/py-evm/p2p/peer.py", line 126, in handshake
    ) = await auth.handshake(remote, privkey, token)
  File "/home/jcarver/code/py-evm/p2p/auth.py", line 59, in handshake
    initiator, reader, writer, token)
  File "/home/jcarver/code/py-evm/p2p/auth.py", line 81, in _handshake
    ephemeral_pubkey, responder_nonce = initiator.decode_auth_ack_message(auth_ack)
  File "/home/jcarver/code/py-evm/p2p/auth.py", line 195, in decode_auth_ack_message
    raise BadAckMessage("Auth ack msg too short: {}".format(len(ciphertext)))
p2p.exceptions.BadAckMessage: Auth ack msg too short: 0

How can it be fixed
:man_shrugging:
#885 fixed a similar-sounding bug. I was running from 0fe47acb737dea65a which includes that merge.
@gsalgado probably has a better idea where to start

It is a Parity node with no matching capabilities:
   DEBUG  06-12 23:32:48        peer  Connecting to <Node(0x94c1@<IP_ADDRESS>)>...
   DEBUG  06-12 23:32:48  lightchain  fetched headers from 0 to 191
   DEBUG  06-12 23:32:48        peer  Could not complete handshake with <Node(0x94c1@<IP_ADDRESS>)>: HandshakeFailure("No matching capabilities between us ([('les', 1), ('les', 2)]) and <Node(0x94c1@<IP_ADDRESS>)> ((('eth', 62), ('eth', 63), ('par', 1), ('par', 2), ('pip', 1))), disconnecting",)

The  Bad ack log msg is from connecting to a different peer -- it is generated by the auth handshake, which happens before the actual P2P handshake. We need to log more info about the peer when we get those bad acks

Ok, I was wrong, it is actually that node that is giving us a BadAck, and that seems to happen only when it has seen our node ID before and knows we don't have matching protocols. When I used my trinity node ID to connect to it, I got a BadAck as well:

INFO  06-13 09:58:31        peer  Got bad auth ack from <Node(0x94c15d1b9e2fe7ce56e458b9a3b672ef11894ddedd0c6f247e0f1d3487f52b66208fb4aeb8179fce6e3a749ea93ed147c37976d67af557508d199d9594c35f09@<IP_ADDRESS>:30303)>

When I used a different node ID and had matching protocols, I was able to connect just fine:

2018-06-13 10:06:36,139 DEBUG: Successfully decoded Status (cmd_id=16) msg: {'protocol_version': 63, 'network_id': 3, 'td':<PHONE_NUMBER>529846, 'best_hash': b'S\xd5\xfdu\xa2\x9c)\xca\x95x<\xf8\xa9\x80\xfb\x94\xdbtU\x9e\x1dX\x06\xcc\xed\xc9\xdba\x0fs\x82\x98', 'genesis_hash': b'A\x94\x10#h\t#\xe0\xfeMt\xa3K\xda\xc8\x14\x1f%@\xe3\xae\x90b7\x18\xe4}f\xd1\xcaJ-'}
2018-06-13 10:06:36,145 DEBUG: Finished (eth, 63) handshake with <Node(0x94c1@<IP_ADDRESS>)>

Finally, with a different node ID and no matching protocols, the first time it does the auth dance and sends us a Hello msg, but the second time it already knows we don't have a matching protocol so it closes the connection before sending any data, which causes the BadAck:

2018-06-13 10:12:42,200 DEBUG: Waiting for 192 bytes from <Node(0x94c1@<IP_ADDRESS>)>
2018-06-13 10:12:42,205 DEBUG: Got msg with cmd_id: 0
2018-06-13 10:12:42,205 DEBUG: Successfully decoded Hello (cmd_id=0) msg: {'version': 5, 'client_version_string': 'Parity/v1.9.2-beta-0feb0bb-20180201/x86_64-linux-gnu/rustc1.23.0', 'capabilities': (('eth', 62), ('eth', 63), ('par', 1), ('par', 2), ('pip', 1)), 'listen_port': 30303, 'remote_pubkey': b'\x94\xc1]\x1b\x9e/\xe7\xceV\xe4X\xb9\xa3\xb6r\xef\x11\x89M\xde\xdd\x0co$~\x0f\x1d4\x87\xf5+f \x8f\xb4\xae\xb8\x17\x9f\xcen:t\x9e\xa9>\xd1G\xc3yv\xd6z\xf5WP\x8d\x19\x9d\x95\x94\xc3_\t'}
2018-06-13 10:12:42,206 DEBUG: Sending msg with cmd_id: 1
2018-06-13 10:12:42,209 DEBUG: Could not complete handshake with <Node(0x94c15d1b9e2fe7ce56e458b9a3b672ef11894ddedd0c6f247e0f1d3487f52b66208fb4aeb8179fce6e3a749ea93ed147c37976d67af557508d199d9594c35f09@<IP_ADDRESS>:30303)>: HandshakeFailure("No matching capabilities between us ([('les', 1), ('les', 2)]) and <Node(0x94c1@<IP_ADDRESS>)> ((('eth', 62), ('eth', 63), ('par', 1), ('par', 2), ('pip', 1))), disconnecting",)
[...]
2018-06-13 10:12:42,209 DEBUG: Connecting to <Node(0x94c1@<IP_ADDRESS>)>...
2018-06-13 10:12:43,164 INFO: Got bad auth ack from <Node(0x94c15d1b9e2fe7ce56e458b9a3b672ef11894ddedd0c6f247e0f1d3487f52b66208fb4aeb8179fce6e3a749ea93ed147c37976d67af557508d199d9594c35f09@<IP_ADDRESS>:30303)>


[ble] update ble advertisement packet format

Update the packet format to be coherent with the current specification.
Summary of Changes
This PR will send CHIP specified BLE advertisement packets. The discriminator is now hardcoded and shall be derived from the factory data in future changes.
fixes https://github.com/project-chip/connectedhomeip/issues/1648

@andy31415 @jelderton ?

@robszewczyk ?


Re-add removed route param

Explanation of Change
By the time https://github.com/Expensify/App/pull/51817 was merged, it was out of sync with main. That PR used route/useRoute(), that had been removed in the meantime in https://github.com/Expensify/App/commit/48a9b37b9fcab6fbd4b875333150060775165b8d.
This change re-adds it to fix the typecheck and ESLint errors.
Fixed Issues
$ https://github.com/Expensify/App/issues/52508
$ https://github.com/Expensify/App/issues/52509
$ https://github.com/Expensify/App/issues/52510
Tests / QA

Create a new account
Go to Settings > Security > Two Factor Authentication
Make sure the right hand panel opens on a page saying "This feature requires you to validate your account."
Click the back button in the panel, make sure the panel closes and you're back on the Security page
Create a workspace
Go to More Features and enable accounting integrations
Go to Accounting > Xero > [Connect] > tap the "Enable two-factor authentication" button
Make sure the RHP opens on a page saying "This feature requires you to validate your account."
Click the back button, make sure the panel closes and you're back on the Accounting page of the workspace

[ ] Verify that no errors appear in the JS console

Offline tests
N/A
QA Steps
Same as test steps above

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/cb32aed5-8b11-4afb-a6b0-c0500b4724e0

MacOS: Desktop

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Hiding and unhiding a pane causes increases width. Paneforge version = 	"1.0.0-next.1"

Describe the bug
When hiding and unhiding a pane using the the if statement in sveltekit, it causes the width to keep on increasing on every subsequent show.
This bug is present in the paneforge and shadcn-svelte 5 version.
https://github.com/user-attachments/assets/c9622c7c-fa8e-474e-9d56-28ccfc1da8cc
Reproduction

Add a pane group and add two panes in it.

https://stackblitz.com/edit/sveltejs-kit-template-default-acvruj?file=src%2Froutes%2F%2Blayout.svelte
Logs
No response
System Info
System:
    OS: macOS 15.1.1
    CPU: (8) arm64 Apple M2
    Memory: 68.56 MB / 8.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.12.2 - ~/.nvm/versions/node/v20.12.2/bin/node
    npm: 10.5.0 - ~/.nvm/versions/node/v20.12.2/bin/npm
    pnpm: 9.12.1 - ~/.nvm/versions/node/v20.12.2/bin/pnpm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Safari: 18.1.1
  npmPackages:
    @sveltejs/kit: 2.8.3 => 2.8.3
    paneforge: 1.0.0-next.1 => 1.0.0-next.1
    svelte: 5.2.7 => 5.2.7

Severity
blocking all usage of PaneForge

Same issue here, it also screws up the resizeability of the panes and behaves very weird.
Works fine on 0.0.6 though.


Tune db connection pool to more diligently reap idle and abandoned connections

This should address potential memory leaks in workers' connection pools. According to the Tomcat docs, these changes to the connection pool should have the following behavior:
Every 30 seconds, an eviction check will be run. Threads that have been idle for more than 60 seconds are eligible for eviction, should they fail validation.
Connections that are considered abandoned will be removed. A connection that has been borrowed for more than 2 minutes without being returned is assumed abandoned and is closed. CWS previously only logged such occurrences.

NOTE: removeAbandonedTimeout should be at least as long as the longest query we expect to run in CWS. In the past, this was the console summary statistics, which could run for much longer than 2 minutes. This has since been remedied, leaving 2 minutes as a generous timeout on connections borrowed from the connection pool.

Will continue to keep an eye on this change & see how it affects performance.
We should also consider taking HikariCP for a spin, as it is recommended by Camunda.


Improved multi-robot rendering capabilities

Improved capability to render multiple robot algorithms on the same episode
Added run_multi_robot.sh script to automate running several different robot algorithms on the same episode
Fixed the environment.yml to install the barebones requirements for creating a conda installation
Updated documentation to docs/
Updated some params allowing for more consistent rendering
Improved performance of legend plotting

This pr does not include any joysticks besides what was already included (sampling & random planner). So yes, this will raise a NotImplementedError unless the other joysticks are installed.

Putting this PR on hold for a while. It improves some non-critical functionality for users and we want to run more tests before merging.

Bumping this PR. It will probably help with a lot of the installation issues from earlier.
@ajdroid wanna run the tests and make sure it looks good

Needed to change the opencv install version to 4.2.* in multi-robot-rendering/environment.yml
Had an issue with the pyopenGL similar to: https://github.com/MPI-IS/mesh/issues/23

File "/usr/lib/python3/dist-packages/OpenGL/raw/GLES2/_types.py", line 5, in
_error_checker = _ErrorChecker( _p, _p.GLES2.glGetError )

Was able to bypass by setting _error_checker=None in that file. Can you reproduce @GustavoSilvera ?

I can confirm that upgrading the opencv to 4.2.* still maintains fully-functional unit tests. But I did not need to perform the _error_checker=None workaround.
I also recently added some changes to address #17 and #18 by simplifying the installation process


Feature Request: Change the rapns_notifications table name

As of now we have to use rapns_notifications as the
table name in the database as this is defined in Rapns::Notification model
It would be nice to change this setting.

Hey thanks.
I just thought it would be a nice feature to have.
E.g. It would be more obvious to people that don't know the rapns gem to have a table called push_notifications or developers might want to use a table prefix in their database.
Great gem anyway. Keep up the good work.


Unit test case for k8s/pvcs file

Closes: RHOAIENG-2160
Description
Unit test case for: frontend/src/api/k8s/pvcs.ts
How Has This Been Tested?
npm run test
Test Impact
coverage:

Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

/lgtm
/approve


Add support for Python 3.13

[ ] get CI to pass
[ ] wait for stable numba release; remove numba line from pyproject.toml

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.384%

Totals

Change from base Build<PHONE_NUMBER>3:
0.0%

Covered Lines:
609

Relevant Lines:
619

💛  - Coveralls


First packaging for ROS2

Hi @olivier-stasse  and @Kotochleb,
I did a first pass on the ROS2 packaging.
I build the non ROS dependent classes in the repos.
A following PR will isolate more code from ROS.

Hi @MaximilienNaveau , I do believe that with the last asked change this PR is ready to be merged.

Thanks a lot @MaximilienNaveau


gi-pango: build failure, missing cairo dependency

Issue description
gi-pango fails to build with the following error:
Failed to load shared library 'libcairo-gobject.so.2' referenced by the typelib: libcairo-gobject.so.2: cannot open shared object file: No such file or directory
Could not resolve symbol "cairo_gobject_context_get_type" in namespace "cairo"

Steps to reproduce
nix-shell -p 'pkgs.haskell.packages.ghc801.ghcWithPackages (ps: with ps; [ gi-pango ])'

(...)

** (process:22156): WARNING **: Failed to load shared library 'libcairo-gobject.so.2' referenced by the typelib: libcairo-gobject.so.2: cannot open shared object file: No such file or directory
Could not resolve symbol "cairo_gobject_context_get_type" in namespace "cairo"
CallStack (from HasCallStack):
error, called at lib/Data/GI/CodeGen/LibGIRepository.hs:136:8 in
haskell-gi-0.18-6bonzHKr6mb9hJdTalDE3q:Data.GI.CodeGen.LibGIRepository
builder for ‘/nix/store/qas2najqaiir02m0ssf7bprf6wpzl20r-gi-pango-1.0.3.drv’ failed with exit code 1
cannot build derivation ‘/nix/store/r5v795lgpqqz31mnd3ppfl0w4vgfw8y4-ghc-8.0.1.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/r5v795lgpqqz31mnd3ppfl0w4vgfw8y4-ghc-8.0.1.drv’ failed
/run/current-system/sw/bin/nix-shell: failed to build all dependencies

Technical details

System: 16.09beta335.7617e7e (Flounder)
Nix version: nix-env (Nix) 1.11.4
Nixpkgs version: 16.09beta335.7617e7e

Workaround
#16998 has an explanation and solution which seems to have already been applied for gi-cairo:
preCompileBuildDriver = ''
  PKG_CONFIG_PATH+=":${cairo}/lib/pkgconfig"
  setupCompileFlags+=" $(pkg-config --libs cairo-gobject)"
  '';

I don't think the fix for this works on Mac OS:
nix-shell -p 'pkgs.haskell.packages.ghc802.ghcWithPackages (ps: with ps; [ gi-pango ])'

(...)

** (process:34263): WARNING **: Failed to load shared library 'libcairo-gobject.2.dylib' referenced by the typelib: dlopen(libcairo-gobject.2.dylib, 9): image not found
Could not resolve symbol "cairo_gobject_context_get_type" in namespace "cairo"
CallStack (from HasCallStack):
error, called at lib/Data/GI/CodeGen/LibGIRepository.hs:141:8 in
haskell-gi-0.20-3qNcFwEKwF5EdLezopx8Mz:Data.GI.CodeGen.LibGIRepository
builder for ‘/nix/store/fhv025rwlpkvkk4shz9kjl12xjnb75p1-gi-pango-1.0.12.drv’ failed with exit code 1
cannot build derivation ‘/nix/store/gsrfrb54slw6rwp6fcs89n8nmdqycc6w-ghc-8.0.2-with-packages.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/gsrfrb54slw6rwp6fcs89n8nmdqycc6w-ghc-8.0.2-with-packages.drv’ failed
/Users/hamish/.nix-profile/bin/nix-shell: failed to build all dependencies


Add "zoomable" legend in comparison/investigation view

Now fully implemented for the visualization view, still missing in comparison pane.

As the comparison pane keeps growing in complexity (we want a tabbed view for the three different subplots in the cluster views + zoomable legends) I needed to move it from jQuery to Alpine.js. Works mostly fine now, but the zoomable legend implementation in the backend is still missing.


When visiting a login page and if user is already authenticated then redirect to the home page

:+1:


Converting else if's to match

I tried to convert these else if's to match. While I was converting, There was no action::Type valued 32 so I used it. You can fix it. This is my first time both using git and committing to a project. Also, I started learning Rust as my first language around 1 month ago. I hope this is helpful. Please check the code carefully before accepting this request. I added comments when I can. Please read and change them too. I had a little trouble finding my way in the code. I think it needs more comments.
Also, there was a commit while I was changing these, I tried to pull the commit too. I hope there is nothing broken. I followed: https://medium.com/@topspinj/how-to-git-rebase-into-a-forked-repo-c9f05e821c8a
And very helpful community from your Discord server.
-Thank you!

@furkan-gnu i wonder if there is a way to do this without looping over all 33+ actions each key press.
Maybe just this?
        match key_stroke {
            _ if key_map.is_bound(key_stroke, action::DOWN) => self.down(),
            _ if key_map.is_bound(key_stroke, action::UP) => self.up(),
            _ if key_map.is_bound(key_stroke, action::RIGHT) => self.right(),
            _ if key_map.is_bound(key_stroke, action::LEFT) => self.left(),
            _ if key_map.is_bound(key_stroke, action::HOME) => self.home(),
            _ if key_map.is_bound(key_stroke, action::JUMP_TO_START) => self.jump_to_start(),
            _ if key_map.is_bound(key_stroke, action::JUMP_TO_END) => self.jump_to_end(),
            _ if key_map.is_bound(key_stroke, action::PAGE_UP) => self.page_up(PAGE_SIZE),
            _ if key_map.is_bound(key_stroke, action::PAGE_DOWN) => self.page_down(PAGE_SIZE),
            _ => unimplemented!(), // TODO something else here
        }

@furkan-gnu i wonder if there is a way to do this without adding a loop over all 33+ actions each key press.
Maybe just this?
        match key_stroke {
            _ if key_map.is_bound(key_stroke, action::DOWN) => self.down(),
            _ if key_map.is_bound(key_stroke, action::UP) => self.up(),
            _ if key_map.is_bound(key_stroke, action::RIGHT) => self.right(),
            _ if key_map.is_bound(key_stroke, action::LEFT) => self.left(),
            _ if key_map.is_bound(key_stroke, action::HOME) => self.home(),
            _ if key_map.is_bound(key_stroke, action::JUMP_TO_START) => self.jump_to_start(),
            _ if key_map.is_bound(key_stroke, action::JUMP_TO_END) => self.jump_to_end(),
            _ if key_map.is_bound(key_stroke, action::PAGE_UP) => self.page_up(PAGE_SIZE),
            _ if key_map.is_bound(key_stroke, action::PAGE_DOWN) => self.page_down(PAGE_SIZE),
            _ => unimplemented!(), // TODO something else here
        }

I didn't know that we could use match like that. Thanks!


Support station icons for position beacons.

Use the settings_json field to support station icons in the call sign registry. Clean up registry code in general, to support the settings dictionary deeper in the stack.

Closed by #14

Closed by #14

Closed with #34


Album covers cache

After clearing app cache album covers are blank in the album tab and on album pages. They show up fine on the Now Playing screen. Refreshing the Library doesn't help. I opened another music app, scrolled through all Albums and that solved it.

I'm not able to reproduce this on my Pixel XL with the O developer preview 2. Can you let me know which device and version of Android you're using as well as reproduction steps?