Update Block-SmbShareAccess.md

updated syntax, Added description to Example and SMB instance

Docs Build status updates of commit 6413ba1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2012-ps/smbshare/Block-SmbShareAccess.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 6757f66:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2012-ps/smbshare/Block-SmbShareAccess.md
:white_check_mark:Succeeded

docset/winserver2012r2-ps/smbshare/Block-SmbShareAccess.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@dariomws306 @get-itips @tseward
Peer review needed for this PR. Thanks.


Make launching dev-mode easier

Let's auto-configure the proxy and use that as backend URL to avoid CORS issues.

I've just implemented this in above commit.


[plot] HistogramAction-> out of memory

On a displayed image: click on histogram, then set axis to log scale -> huge memory consumption (x-axis at least)
image: uint16, 2048x2048
[5206730.893957] silx[43274]: segfault at 0 ip           (null) sp 00007ffc62fa6c78 error 14 in python3.4[400000+3b2000]
[5206885.737407] ipython[43319]: segfault at 7fce9a714b50 ip 00007fcee6dd9055 sp 00007ffdb463e298 error 6 in libc-2.19.so[7fcee6d47000+1a1000]

It seems this is not directly related to the histogram action but to the plotting of histogram with log scale.
This code reproduces the segfault on debian8:
from silx import sx
w = sx.Plot1D()
w.show()
w.addHistogram((4191151, 1890, 522), (0., 63., 127., 191.), fill=True)
w.setXAxisLogarithmic(True)

Note: From what I tested, this issue does not occur on debian 7, nor on macOS with Python3 and matplotlib 2.
Still to investigate further...


Browserfiying the module

Adding the npm module, the Grunt config, and a mockup of the lib-cov module to be able to browserify without errors. Everything seems OK.

ah also need to remove the gpx-parse file from the commit.

You want to remove the browserified file from the repository ? Or juste change the name ?

I think probably remove it as its a generated file.

Unless you have a reason why you want to add it?

Well, yeah I wish it was already included in the repository. So this repository could be included as a git submodule in other projects, and be used out of the box.
For example, in the project I'm working on, I use gpx-parse as a submodule. I want the module to be pulled when I clone the repository, and I want it to be included in my javascript when I run Grunt, without having to know how to browserify this particular repository. Each repository should be built already.
See some examples:

https://github.com/tyrasd/togpx
https://github.com/mapbox/tokml
This is my opinion, of course this is your repository, your choice :-)

How about we put it in a folder called dist?

Perfect for me.

Im not sure I can edit this push so are you able to make the modification to the grunt script to build to a dist folder and commit the browserify file into that folder instead? Ill merge it all then.

Yeah no problem, I'll do theses modifications in few hours. I'm closing this PR, I will open a new one.

No probs. Ill check back later. Thanks again


Implement show_object for OrbitOrthoController

Closing #301 which discussed adding a method to center world objects with the PanZoomController which was then implemented in #326. This issue just tracks that this is yet to be implemented for the OrbitOrthoController and PerspectiveCamera.

Closed by #457


Permission change on git push

My files have 640 permission on local machine. When i push them to git and then pull to production machine it changes to 644. For some reason my shared hosting server then gives Internal Server Error. When permission is changed back to 640 it works fine.
I havent have this problem using command line. I really like Codiad and your plugin which i discovered yesterday. I would love the option that pushed files would have the same permissions as local files.

Never mind got it working.
Its actualy connected to other plugin. If other might have same problem, the solution is to edit Codiad-CompletePlus-master/extensions/snippets/php.json

Sry, I don't understand your solution. Nevertheless if it works for you, I'll close this issue.


Easy (pre)processing params

This supersedes https://github.com/biocore/qiita/pull/859 and also makes the pre and the processing look the same + got rid of confirmation JS boxes.
As in the previous PR fast reviews will be appreciated

Forgot that the first commit of #859  was added to my master and thus here too, removing now.

Coverage increased (+0.25%) to 78.6% when pulling 4ad3216f9b382cf52438d2895e40889cd0c6277f on antgonza:easy-pre-processing-params into d3984140ab3db185920f473710da53c2587aee49 on biocore:master.

Changing history is scary! Anyway, this is ready for final review.

Thanks @antgonza
Just a comment. In the preprocessing modal, no parameters are selected by default, while in the processing one the "Default" parameter set is selected. I would say that it will simplify code and improve consistency if in both cases the "Default" parameter set is chosen (the function submit_preprocess  will be removed, and both modals will work exactly equal).

I'm not sure which one will be the default for preprocessing as there
are sooooo many options. Thus, the idea of having the user select one
and have no default.

It is scary indeed, but someone has to do it!
On (Feb-18-15| 9:27), Antonio Gonzalez wrote:

Changing history is scary! Anyway, this is ready for final review.

Reply to this email directly or view it on GitHub:
https://github.com/biocore/qiita/pull/863#issuecomment-74907057

I would say the default will be the one with golay_12 and not 'rev_comp_mapping_barcodes' (which is the one that has default as name). However I don't think this is blocking, so if other devs are happy as it is right now is :+1: for me to merge.

Looks good, only comment on the GUI is that when you get to the parameter selection screen, it is very unclear what are you actually selecting. It reads at the top choose preprocessing parameters, as a naive user this means nothing to me, even as an experienced QIIME user this means very little. Maybe it would be worth to add a short description (at the bottom of the modal) of what steps will take place and possibly link to the docs for split_libraries_fastq.py and split_libraries.py?
Aside from this, this PR is ready.

Code looks good to me, about to test it on my system.

:+1: when tests pass

Changes Unknown when pulling 16fd7aebb645f2780f25146810eaeacb94edf9e7 on antgonza:easy-pre-processing-params into ** on biocore:master**.

Ready again.

Changes Unknown when pulling b872fb991f14ab2d9ea931b307136075af78248e on antgonza:easy-pre-processing-params into ** on biocore:master**.

:+1:

Can this be merged?


Disambiguation improvements

Hu guys, thanks for this outstanding work!
I was trying your GraphQL demo endpoint  and I had this disambiguation issue. For the query Marc Marquez (the moto racer) I'm getting the wrong document result,  while adding more context (like motorcycle racer) I get the correct result. Assumed that I cannot have for this item in the query more context, but "related wikipedia items" (let's say Valentino Rossi), is it possible to add a related item node embedding for this query?
{
  Get {
    Paragraph(
      ask: {
        question: "Marc Marquez"
        properties: ["content"]
      }
      limit: 1
    ) {
      content
      order
      title
      inArticle {
        ... on Article {
          title
        }
      }
      _additional {
        answer {
          result
        }
      }
    }
  }
}

result:
{
  "data": {
    "Get": {
      "Paragraph": [
        {
          "_additional": {
            "answer": {
              "result": null
            }
          },
          "content": "On November 10, 2017, Marquez was signed to the Detroit Lions' practice squad. He was promoted to the active roster on November 27, 2017. On September 11, 2018, Marquez was waived by the Lions. ",
          "inArticle": [
            {
              "title": "Bradley Marquez"
            }
          ],
          "order": 5,
          "title": "Detroit Lions"
        }
      ]
    }
  }
}

Hi @loretoparisi – sorry for the late response. I must have missed this question.

is it possible to add a related item node embedding for this query?

I'm not 100% sure I understand, can you please elaborate a bit more?

Btw – you might also like to join our Slack channel.

Hi @loretoparisi – sorry for the late response. I must have missed this question.

is it possible to add a related item node embedding for this query?

I'm not 100% sure I understand, can you please elaborate a bit more?

Thanks for your help! So, since using the bare query Marc Marquez the result is wrong, while adding more context (like motor racer) it works ok, I was wondering if it is possible to add this context not as text, but as en embedding representation (let's say using the wikidata property for pilot or motor racer, etc.).

That's an interesting idea @loretoparisi, thanks – I've moved the discussion here.


Clarifying guidance

Clarifying that the guidance for when a user leaves the org that has been documented assumes the user is a cloud only user (AAD & EXO)

Addressing with internal PR 6450 so gets published more quickly

Addressing with internal PR 6450 so gets published more quickly


fix: Fix failures caused by array_prepend

Which issue does this PR close?

Closes #.
Rationale for this change
Added changes to array_prepend to fix the tests that are failing due to the changes in #13362

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@alamb @Omega359 I believe this will probably keep happening from time to time (newer committers being unaware of the dynamic docs for UDFs). I'll open another PR to put this in the HOWTOs to make sure its more obvious despite it being mentioned in the docs for 'Adding new udfs'

There is a big warning at the top of those files but adding notes to howto wouldn't hurt at all.


Dockerfile.arm32v7 references deprecated resin repo on Dockerhub

Description of the issue:
Dockerfile.arm32v7 supplied by generator for IoT Edge python modules is referencing a deprecated base image provided by resin on Dockerhub.  Theis should be updated to support newer images provided by balenalib.
Code sample exhibiting the issue:
Dockerfile.arm32v7

FROM resin/raspberrypi3-debian:stretch

This image reference should be updated to:
balenalib/raspberrypi3-debian:stretch

Thanks for your contribution. The template now uses the official python base image. So I'm going to close this issue.


fix convertToUTF8 and amend testValidateNonUTF8()

here’s the remaining fixes

Actually, I don't understand what this PR does. @mirabilos, what are you trying to resolve?

It correctly handles the cases of incoming latin1 and UTF-8 strings. (I could enhance it to support windows-1252 as well.) #156 which you merged drops this ability, if it is even correct at all.

Could you give me a usecase please? I wonder if we can find a simple solution?

Simply spoken, the mb_{check,detect}encoding functions do not always check the validity of the string in the specified encoding (which is what they should do). Converting between UTF-8 and UTF-16 and back is a good check (although I just looked at the PCRE-based one, which should also work), and converting a string to UTF-8 if it’s latin1 can be done with the mb* conversion function more easily (utf8_encode is legacy, and travels through the entire XML stack). Heck, extending it to actually support windows-1252 would be easy.
Maybe this could be shorted by using the PCRE version. But when I submit something, I prefer solutions I know to work, from production code here.

@mirabilos I fixed the underscore issue with your comment.
The preg_match trick comes from Hoa\String which is a well-tested Unicode string library. So I tend to be confident with this solution. So it removes the needs of encoding to UTF-16 and then encoding back to UTF-8.
Then, is the goal also to remove control characters? Actually, they are valid UTF-8 characters but in sabre/vobject we consider them as invalid. If yes, we can use a regular expression based on Hoa\String\String::getCharWidth which counts the number of column needed to print a char. It takes care of the control characters. We can use this algorithm as a basis.
Note: I was reviewing your PR again. All the mb_* stuff is not necessary if we consider the preg_match trick efficient. Then, your last return statement combined with a preg_replace is valid.

Hrm. I can’t comment in-detail enough right now, but you do raise some important points. Next time I can work on this project, I’ll have a look at all possible callers, and try to figure something out. Thanks for the links also.
Can we just leave this open but 'put back' for now, then?

Oops, forget about the “invalid” label, I mistaken. Now it's in “question”, so it's fine. We keep it open.

It's been a long time since the last activity here. If there are any problems here, drop me a line so we can reopen.


Using bokeh - halts on missing yaml module

Hi. I see that both numpy and bokeh are in the wasm, but when I try using bokeh, pygbag halts with the error:
1202: want='yaml' found : False
PKG NOT FOUND : want='yaml', resume=<function  at 0x1864780>, ex=ModuleNotFoundError("No module named 'yaml'")
Bokeh script works ok after I alter the script to go 'pygbagging', and shows a html file immediately in the browser. Script is simple:
`import numpy as np
import yaml
from bokeh.plotting import figure, show
import asyncio
async def main():
x = np.arange(0, 10, 1)
y1 = x ** 2
y2 = x ** 3
y3 = x ** 4
p = figure(title="Simple line charts", x_axis_label="x", y_axis_label="y")

p.line(x, y1, legend_label="x2", line_width=2, color="red")
p.line(x, y2, legend_label="x3", line_width=2, color="green")
p.line(x, y3, legend_label="x4", line_width=2, color="blue")

show(p)
await asyncio.sleep(0)

asyncio.run(main())`

transfering issue to https://github.com/pygame-web/pkg-porting-wasm
i guess yaml is binary and rely on libYaml


fix #545 Web show mess code when request body gziped

Web show mess code when request body gziped

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


DTS SPI device, DW and quark_se

Ok, this cs-gpios from linux is quite dumb to follow on Zephyr, as it's not the controller which defines it but the spi device. This makes it really counter intuitive.

github really orders patch weirdly indeed.

Ok, this cs-gpios from linux is quite dumb to follow on Zephyr, as it's not the controller which defines it but the spi device. This makes it really counter intuitive.

While its a little counter intuitive, it makes sense from a device / device tree point of view.  Since a SPI device doesn't know anything about the controller its connected to it has no idea how the chip selects are implemented -- this is a function of the controller, and thus should live in the controller node.  Otherwise we'd have to update each binding for every combination of chip selection solutions that might exist for all controllers.

@galak I reverted back to linux style, and remove the fifo stuff. Can you re-review?

Added @MaureenHelm and @dleach02 to be in loop on frdm_k64f changes.
(Removed myself from reviewers as I can't say much on the changes.)

@tbursztyka any plans to address comments?

@tbursztyka any plans to address comments?

Any plans?

this was covered in #10249


⚠ Quirk Club Argentina (API endpoint) has degraded performance

In c7674af, Quirk Club Argentina (API endpoint) (https://us-central1-quirkclub-dev.cloudfunctions.net/api/check/api) experienced degraded performance:

HTTP code: 200
Response time: 9161 ms

Resolved: Quirk Club Argentina (API endpoint) performance has improved in 197831d.


[Bug] Pods stay in Pending state forever

I was trying out latest k3d installed via go get. After k3d create the default traefik and coredns pods would stay in Pending state forever.
I found the following in kubectl describe for the pods:
Events:
  Type     Reason            Age                From               Message
  ----     ------            ----               ----               -------
  Warning  FailedScheduling  22s (x2 over 22s)  default-scheduler  no nodes available to schedule pods

Also kubectl get nodes would output
No resources found.

In the docker logs of the k3d-k3s_default container I also saw repeated messages of the following:
time="2019-05-08T15:04:00.196973262Z" level=info msg="waiting for node k3d-k3s_default-server: nodes \"k3d-k3s_default-server\" not found"
time="2019-05-08T15:04:02.198201809Z" level=info msg="waiting for node k3d-k3s_default-server: nodes \"k3d-k3s_default-server\" not found"
time="2019-05-08T15:04:04.199724009Z" level=info msg="waiting for node k3d-k3s_default-server: nodes \"k3d-k3s_default-server\" not found"
time="2019-05-08T15:04:06.201047753Z" level=info msg="waiting for node k3d-k3s_default-server: nodes \"k3d-k3s_default-server\" not found"
time="2019-05-08T15:04:08.202304466Z" level=info msg="waiting for node k3d-k3s_default-server: nodes \"k3d-k3s_default-server\" not found"
time="2019-05-08T15:04:10.203751445Z" level=info msg="waiting for node k3d-k3s_default-server: nodes \"k3d-k3s_default-server\" not found"
time="2019-05-08T15:04:12.205281191Z" level=info msg="waiting for node k3d-k3s_default-server: nodes \"k3d-k3s_default-server\" not found"
time="2019-05-08T15:04:14.208050701Z" level=info msg="waiting for node k3d-k3s_default-server: nodes \"k3d-k3s_default-server\" not found"
time="2019-05-08T15:04:16.209164570Z" level=info msg="waiting for node k3d-k3s_default-server: nodes \"k3d-k3s_default-server\" not found"

When I tried the latest release (v1.0.2) everything was working again. I did a quick bisect on the commits and it appears that the changes in 9ac81982e245b2b6ba3fc9d564b49917bbcd4f9e cause this behavior.

I think '_' is not allowed in a valid Unix host name.  As a work around, you can try to create the cluster with the -n option.
For a proper fix, I suggest that 1) we change the default cluster name from 'k3s_default' to simply 'default'.  2) For the -n option, we only accept an argument in .valid hostname form.

Working on a pull request to implement the suggestion above.

Kinda embarrassing :sweat_smile:
I'll release a hotfix in a few minutes

Thanks for reporting this. As @andyz-dev suggested, I quickly changed the default name to k3s-default, so that it at least works with the defaults after go get/go install.
Thanks for working on this @andyz-dev , I'll merge your PR asap once I see it ready :+1:

Fixed via PR #35, thanks to @andyz-dev

Thank you @andyz-dev and @iwilltry42 for fixing this so quickly.


[Menu] Add a dividerStyle property

[ ] PR has tests / docs demo, and is linted.

Linted -- but no tests or docs.  I can add this if you think it is justified.

[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Add a dividerStyle property that allows users to customize the style on any Divider children of the Menu.

I'm wondering about this new property. Wouldn't it be better if users were able to provide a style like this:
  <Menu>
    <MenuItem primaryText="Settings" />
    <MenuItem primaryText="Help & feedback" />
    <Divider style={style} />
    <MenuItem primaryText="Sign out" />
  </Menu>

I can add this if you think it is justified.

The Menu component don't have unit test yet. So I definitely think that it would be great to start somewhere. I understand if you don't know enzyme and have any clue where to start.

@oliviertassinari That does seem like the best way to do it!  It is how I initially attempted to style my Divider.  But currently the styles set on a Divider (as you describe) are clobbered by Menu when it clones the Divider.
If I change this behavior, how do you think it should behave if the Divider already has a style set?  Options:

Merge the styles from Menu into the Divider element's existing styles.  Like this: mergedDividerStyles = Object.assign({}, styles.divider, child.props.styles)
Do not modify the Divider element's styles if they are set.  Only use the Menu element's hard-coded style.divider when Divider.props.styles is not set.
Something else?

Note that the two above options have the possibility of changing Material UI's behavior for existing code that sets a style on a Divider.  Adding a new dividerStyle property is 100% backwards compatible.

But currently the styles set on a Divider (as you describe) are clobbered by Menu when it clones the Divider.

True, the first option is basically what we are doing everywhere else in that case. Let's go for it 👍 .

I updated my change to use child.props.style.  (I squashed my old commit in the process.)  Look good?
I'll try to write a couple tests tomorrow, but it may not happen until Tuesday night.

It's ready to go as far as I know!

@gabrielmdeal Thanks.


Fix missing openzwave configs in Docker

Description:
This fixes issue #5328 by copying the config files from build/ before they are deleted.
Related issue (if applicable): fixes #5328
Checklist:
n/a

The config directory before this change:

After applying this patch:

Thanks for the quick fix!


[datasets] Add additional fields description and ExpandJSON Depth

Adding the following field for Honeycomb Datasets:

description
ExpandJSONDepth

These changes are currently be added to the shep API seperately.
Asana Tracking:
https://app.asana.com/0/1202083175313322/1202555362164075

Codecov Report

Merging #185 (47a0a0d) into main (b9d024e) will decrease coverage by 0.32%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
- Coverage   84.62%   84.29%   -0.33%
==========================================
  Files          38       38
  Lines        2926     2968      +42
==========================================
+ Hits         2476     2502      +26
- Misses        357      373      +16
  Partials       93       93

Impacted Files
Coverage Δ

honeycombio/resource_dataset.go
70.23% <60.00%> (-10.20%)
:arrow_down:

client/dataset.go
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.


Remove redundant track during renegotiation

After renegotiation by reinvite two audio tracks remains active, because it add new track to peerConnection but never removes the old one. This commit removes redundant track

This is a good first effort, but I believe that it will end up creating more problems than it fixes. What really needs to be done is that we need better control of when acquire is called. We should track whether the local media is active or the constraints for local media has changed, then call acquire accordingly. When we call acquire, all local tracks need to be removed from the peer connection then all the tracks returned from GUM added.

Closing in favor #571 which was released as part of 0.11.1.


#1 Prefetch Payments for Orders in Admin Grid

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] The commit message is descriptive of the changes within (see https://keepachangelog.com/en/1.1.0/)
[ ] Code conforms to Magento coding standards
[ ] Code is compatible with all currently supported versions of Magento and PHP

PR Type
Performance optimization for Admin Sales grid by prefetching Payments for the whole Orders collection
With a listing of 100 Orders

The number of SQL calls dropped almost by half

| Calls     | Time             | SQL                                                                                |
|-----------|------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| 100x -100 | 148 ms -76 ms    | SELECT `u`.* FROM ( (SELECT `t`.`value`, `t`.`attribute_id`, `t`.`store_id` FROM `catalog_product_entity_int` AS `t` WHERE (entity_id = ?) AND (attribute_id IN (?)) AND (`store_id` IN (?)))UNION ALL(SELECT `t`.`value`, `t`.`attribute_id`, `t`.`store_id` FROM `catalog_product_entity_varchar` AS `t` WHERE (entity_id = ?) AND (attribute_id IN (?)) AND (`store_id` IN (?)))UNION ALL(SELECT `t`.`value`, `t`.`attribute_id`, `t`.`store_id` FROM `catalog_product_entity_datetime` AS `t` WHERE (entity_id = ?) AND (attribute_id IN (?)) AND (`store_id` IN (?)))UNION ALL(SELECT `t`.`value`, `t`.`attribute_id`, `t`.`store_id` FROM `catalog_product_entity_decimal` AS `t` WHERE (entity_id = ?) AND (attribute_id IN (?)) AND (`store_id` IN (?)))UNION ALL(SELECT `t`.`value`, `t`.`attribute_id`, `t`.`store_id` FROM `catalog_product_entity_text` AS `t` WHERE (entity_id = ?) AND (attribute_id IN (?)) AND (`store_id` IN (?))) ) AS `u` ORDER BY `store_id` ASC                                                                                |
| 200x -200 | 20.3 ms -17 ms   | select ... from catalog_category_product where (product_id = ?)                                                                                |
| 100x -100 | 27.1 ms -30 ms   | select main_table.*, ..., if(...) as title, ..., if(...) as price, if(...) as price_type from catalog_product_option as main_table join catalog_product_entity as cpe on cpe.entity_id = main_table.product_id join catalog_product_option_title as default_option_title on default_option_title.option_id = main_table.option_id left join catalog_product_option_title as store_option_title on store_option_title.option_id = main_table.option_id and store_option_title.store_id = ? left join catalog_product_option_price as default_option_price on default_option_price.option_id = main_table.option_id and default_option_price.store_id = ? left join catalog_product_option_price as store_option_price on store_option_price.option_id = main_table.option_id and store_option_price.store_id = ? where (cpe.entity_id = ?) and (default_option_title.store_id = ?) order by sort_order asc, title asc                                                                                |
| 100x -100 | 12.9 ms -16 ms   | select t.* from catalog_product_entity as t where (entity_id = ?)                                                                                |
| 100x -100 | 63.3 ms -13 ms   | select ...ifnull(...) as label, ifnull(...) as position, ifnull(...) as disabled, ..., ifnull(...) as video_provider, ifnull(...) as video_url, ifnull(...) as video_title, ifnull(...) as video_description, ifnull(...) as video_metadata, ... from catalog_product_entity_media_gallery as main join catalog_product_entity_media_gallery_value_to_entity as entity on main.value_id = entity.value_id left join catalog_product_entity_media_gallery_value as value on main.value_id = value.value_id and value.store_id = ? and value.entity_id = entity.entity_id left join catalog_product_entity_media_gallery_value as default_value on main.value_id = default_value.value_id and default_value.store_id = ? and default_value.entity_id = entity.entity_id left join catalog_product_entity_media_gallery_value_video as value_video on value.value_id = value_video.value_id and value.store_id = value_video.store_id left join catalog_product_entity_media_gallery_value_video as default_value_video on default_value.value_id = default_value_video.value_id and default_value.store_id = default_value_video.store_id where (main.attribute_id = ?) and (main.disabled = ?) and (entity.entity_id = ?) order by if(...) asc |
| 100x -100 | 8.35 ms -13 ms   | select ? from catalog_product_website where (product_id = ?)                                                                                |
| 100x -100 | 13.1 ms -12 ms   | select catalog_product_entity.* from catalog_product_entity where (entity_id = ?)                                                                                |
| 114x -15  | 15.6 ms -17 ms   | select stock_source_link.* from inventory_source_stock_link as stock_source_link join inventory_source_item on inventory_source_item.source_code = stock_source_link.source_code where (stock_source_link.stock_id = ?) and (inventory_source_item.sku = ?)                                                                                |
| 100x -100 | 15.5 ms -10 ms   | select ... from catalog_product_entity_tier_price where (website_id = ?) and (entity_id = ?) order by qty asc                                                                                |
| 114x -44  | 20.7 ms -4.58 ms | select ... from inventory_stock_2 where (sku = ?)                                                                                |
| 42x -74   | 25.3 ms +14.3 ms | select sum(?) as quantity from inventory_reservation where (sku = ?) and (stock_id = ?) limit ?                                                                                |
| 100x -100 | 37.6 ms +6.39 ms | SELECT COUNT(*) AS `count` FROM `inventory_source_stock_link` AS `issl` INNER JOIN `inventory_source` AS `is` ON issl.source_code = is.source_code INNER JOIN `inventory_source_item` AS `isi` ON issl.source_code = isi.source_code WHERE (issl.stock_id = ?) AND (is.enabled = ?) AND (isi.sku = ?) AND (isi.status = ?)                                                                                |
| 64x +10   | 17 ms +4.63 ms   | SELECT `u`.* FROM ( (SELECT `t`.`value`, `t`.`attribute_id`, `t`.`store_id` FROM `catalog_category_entity_varchar` AS `t` WHERE (entity_id = ?) AND (attribute_id IN (?)) AND (`store_id` IN (?)))UNION ALL(SELECT `t`.`value`, `t`.`attribute_id`, `t`.`store_id` FROM `catalog_category_entity_int` AS `t` WHERE (entity_id = ?) AND (attribute_id IN (?)) AND (`store_id` IN (?)))UNION ALL(SELECT `t`.`value`, `t`.`attribute_id`, `t`.`store_id` FROM `catalog_category_entity_text` AS `t` WHERE (entity_id = ?) AND (attribute_id IN (?)) AND (`store_id` IN (?)))UNION ALL(SELECT `t`.`value`, `t`.`attribute_id`, `t`.`store_id` FROM `catalog_category_entity_datetime` AS `t` WHERE (entity_id = ?) AND (attribute_id IN (?)) AND (`store_id` IN (?)))UNION ALL(SELECT `t`.`value`, `t`.`attribute_id`, `t`.`store_id` FROM `catalog_category_entity_decimal` AS `t` WHERE (entity_id = ?) AND (attribute_id IN (?)) AND (`store_id` IN (?))) ) AS `u` ORDER BY `store_id` ASC                                                                                |
| 14x -44   | 8.35 ms +1.87 ms | SELECT SUM(isi.quantity) AS `quantity` FROM `inventory_source_stock_link` AS `issl` INNER JOIN `inventory_source` AS `is` ON issl.source_code = is.source_code INNER JOIN `inventory_source_item` AS `isi` ON issl.source_code = isi.source_code WHERE (issl.stock_id = ?) AND (is.enabled = ?) AND (isi.sku = ?) AND (isi.status = ?)                                                                                |

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Performance optimization

What is the current behavior?

Fixes: #1
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information
🙏🏻 Kindly please add information to Release Notes "Optimized by SwiftOtter.com" when the change gets merged.

@rhoerr The issue here is 2-fold, as "By Default" the Tokenbase Plugin is executed each time you load Sales Grid. The downside is that the same collection is applied for the Admin Dashboard order aggregation.
I'll investigate further in my personal time, as the issue turned out to be more complex than I anticipated. There's one thing I'm sure - The module requires optimization, as it significantly affects the Admin grids performance.

Thanks for calling out the dashboard aggregation as well. That would not have occurred to me.
For sure, the performance of the current plugin needs improvement. Thank you.

Resolved by 02a11b7c03a867e7bbd1926200d12646d712800e . I removed the plugin on Order\Collection, and moved the plugin from Order to Order\Payment such that the extension attributes are initialized on reference, but only after the payment object is otherwise loaded.
In testing, fetching 100 orders by REST API on slow hardware:
Before: 12.44s 11.03s 11.17s
After:   9.52s  9.21s  8.47s

So it definitely does help, albeit slightly. For very large collection loads the difference would be more substantial.
Thanks Lukasz


[CP Staging] fix: Chat - Display Name Appears Black and Members Not Ticked in Group Preview

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/42751
PROPOSAL: https://github.com/Expensify/App/issues/42751#issuecomment-2137856613
Tests

Navigate to FAB > Start Chat > Click on the "Add to Group" button associated with the email.
Verify that the display name appears correctly and the selected members are ticked.

[x] Verify that no errors appear in the JS console

Offline tests

Navigate to FAB > Start Chat > Click on the "Add to Group" button associated with the email.
Verify that the display name appears correctly and the selected members are ticked.

QA Steps

Navigate to FAB > Start Chat > Click on the "Add to Group" button associated with the email.
Verify that the display name appears correctly and the selected members are ticked.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome
https://github.com/Expensify/App/assets/85894871/394780cf-f207-4c6b-89bc-577901a03011

iOS: Native
https://github.com/Expensify/App/assets/85894871/fb95dff8-5e14-419a-966c-39753fa682ad

iOS: mWeb Safari
https://github.com/Expensify/App/assets/85894871/dfee25fe-f239-4280-a90f-b9eaddd778a5

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/85894871/4d81d1cc-715c-4d08-9cf7-9e468c828d4d

MacOS: Desktop
https://github.com/Expensify/App/assets/85894871/9a8df568-17f0-4a36-9dcd-a730564bec7e

@Krishna2323 lint and ts checks are failing

@Krishna2323 we have conflicts now 😞

@abdulrahuman5196 could you please prioritize reviewing this one since it fixes a blocker?

Hi, yes. Starting to check it.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/46707890/d0be555f-efbd-4a3c-9fad-f6994d4d8f3e

Android: mWeb Chrome

https://github.com/Expensify/App/assets/46707890/b95bc2e8-c910-4de9-bc9d-187126c7edd5

iOS: Native

https://github.com/Expensify/App/assets/46707890/adb88a44-3a07-477e-b8ee-c78c9dba2512

iOS: mWeb Safari

https://github.com/Expensify/App/assets/46707890/68e8b410-e6c2-4d7e-9ea4-5aa65a0bcfd9

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/46707890/c917b086-7935-483c-a859-f7b87109a9e7

MacOS: Desktop

https://github.com/Expensify/App/assets/46707890/e1beadb6-0c3a-4291-a318-07c8e77cc439

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[improve][pip] PIP-317: Add bookkeeperDeleted field to show whether a ledger is deleted from the bookie while using tiered storage

Releted PR/issue: #20833

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Should I start a vote for this PIP?

Yeah. Please go ahead.

Mailing List discussion thread: https://lists.apache.org/thread/9kjgg06oj384myxqls73dwn840thtrrc
Mailing List voting thread: https://lists.apache.org/thread/5nfm3qkbwqylk1zp77zn9tfokhy212tb

It will be important to add tests about rolling back to the previous version of Pulsar and/or clusters with mixed versions of the brokers (during rolling upgrades).
The old version should not complain about the new field added.

It will be important to add tests about rolling back to the previous version of Pulsar and/or clusters with mixed versions of the brokers (during rolling upgrades). The old version should not complain about the new field added.

Do you mean adding test cases or updrading cluster including this feature?
The change of this feature is mainly to add a field bookkeeperDeleted in org.apache.pulsar.common.policies.data.ManagedLedgerInternalStats.LedgerInfo. The main scope of influence here is the result returned by the external interface for obtaining status, which will not affect the storage of ledger original data on zk.
This feature has been running on our online cluster for over half a year. No problems were found during the initial rolling upgrade process.

It will be important to add tests about rolling back to the previous version of Pulsar and/or clusters with mixed versions of the brokers (during rolling upgrades). The old version should not complain about the new field added.

Do you mean adding test cases or updrading cluster including this feature?
The change of this feature is mainly to add a field bookkeeperDeleted in org.apache.pulsar.common.policies.data.ManagedLedgerInternalStats.LedgerInfo. The main scope of influence here is the result returned by the external interface for obtaining status, which will not affect the storage of ledger original data on zk.
This feature has been running on our online cluster for over half a year. No problems were found during the initial rolling upgrade process.

@dragonls Thanks for driving this improvement.
I have one concern about the compatibility the same with Enrico. The proposal adds one field in the ManagedLedgerInternalStats, which is located on the common package. Can we ensure compatibility when the server upgrades to the new version but the client stays on the old version? It happens in two cases:

During upgrade and some broker in new version but others in old version
Pulsar client in old version which doesn't has the new field.


Monosymmetric Beam Generator

Is your feature request related to a problem? Please describe.
Request for a monosymmetric I-beam generator function.
Describe the solution you'd like
Generate a monosymmetric I-beam with different top and bottom flange thickness and widths.
Describe alternatives you've considered
N/A
Additional context
N/A

Added in commit 9ee1886


⚠ Bofrost.gr has degraded performance

In a653e59, Bofrost.gr (https://www.bofrost.gr) experienced degraded performance:

HTTP code: 200
Response time: 1724 ms

Resolved: Bofrost.gr performance has improved in afe3226 after 8 hours, 16 minutes.


Set temperature between 0 and 1

Right now I can only enter a temperature equal an integer number. If I enter 0.5 for example, the application will crash.
I have a Galaxy Watch 5

Hey @SnowZucc,
Currently the app is configured to accept only plain integer values (without any decimal notation)


Compiling a program with no "main" creates no output

With this program:
-- Main.elm
a = 1

and this command:
$ elm make Main.elm
Success! Compiled 1 module.

The compiler does not display any errors, and it does not output any files.
Ellie: https://ellie-app.com/3q2m6MNfFrna1

Elm version: 0.19
Browser: Chrome
OS: Windows

I've been trying to decide if this intentional. Probably not, but in any case beginners get very confused when it seems like nothing happens but there are no errors!
The 0.18 compiler also does not error, but it does output a file. However since there is no main, other code on the page has no way of accessing the variables defined in the program

Just want to echo the above.
Accidentally deleted my main and experienced this pain. It was pretty confusing.
Super appreciate the project. Especially the great error messages.
-Nic

I also find this very confusing and wasted a bit of time after upgrading from 0.18 to 0.19 and trying to build a skeleton Elm app.
$ elm make --debug --output=elm.js src/Main.elm
Success! Compiled 1 module.

$ cat elm.js
cat: elm.js: No such file or directory

It would probably better to generate an error rather than "Success" when an output file could not be generated due to missing main.

This was kind of tricky to think of a reasonable fix. Here is the current design:

elm make src/Main.elm with

It was pretty tricky to think of a design that made sense for all the different ways you can call elm make. Here is an overview of the current design:
Case 1: elm make src/Main.elm with main defined.
Success! Compiled 1 module.

    Main ───> index.html

Case 2: elm make src/Other.elm with no main defined.
Success! Compiled 1 module.

Case 3: elm make src/Main.elm src/Root.elm with main defined in both.
Success! Compiled 2 modules.

    Main ───┬──> elm.js
    Root ───┘

Case 4: elm make src/Main.elm src/Other.elm with only one main defined.
Success! Compiled 1 module.

    Main ───> index.html

Case 5: elm make src/Other.elm --output=elm.js with no main defined
Success! Compiled 1 module.
-- NO MAIN ---------------------------------------------------------------------

When producing a JS file, I require that the given file has a `main` value. That
way Elm.Root.init() is definitely defined in the resulting file!

Try adding a `main` value to your file? Or if you just want to verify that this
module compiles, switch to --output=/dev/null to skip the code gen phase
altogether.

Note: Adding a `main` value can be as brief as adding something like this:

import Html

main =
  Html.text "Hello!"

Or use https://package.elm-lang.org/packages/elm/core/latest/Platform#worker to
make a `main` with no user interface.

Etc.
The goals here are:

Do something sensible for beginners just calling elm make and wanting to get a result. I think being explicit about saying "Hey, I generated a file!" is helpful for understanding what the compiler is doing.
Be stricter when folks use --output=elm.js or --output=index.html. In that case, the compiler is going to give an error if you do not have a main defined or give a number of files that doesn't make sense.

I don't think it is perfect for detecting "nothing was output" but we ended up feeling like this new design of (1) being explicit and (2) being stricter when --output is specified was a good balance to address all the different perspectives of folks using Elm.

This is great! Thanks for taking the time to really improve the user experience here @evancz!

It would be nice to get a different exit status for this.


JUNIT: Emit multiple failure tags for multiple failed assertions

#include "unit-testing"

Function Test()

	CHECK_EQUAL_VAR(1, 2)
	CHECK_EQUAL_VAR(2, 3)
	CHECK_EQUAL_VAR(3, 4)
End

run with Runtest("Procedure", enableJU=1)
gives
<?xml version="1.0" encoding="utf-8"?>
<testsuites>
        <testsuite package="Procedure" id="0" name="Procedure" timestamp="2021-03-03T14:31:05" hostname="WIN10-THOMAS-PC" tests="1" failures="1" errors="0" skipped="0" disabled="0" time="0.009">
                <properties>
                        <property name="User" value="thomas"/>
IGORFILEVERSION:<IP_ADDRESS>"/>roperty name="System" value="OS:Windows 10 Pro;
                        <property name="Experiment" value="Experiment"/>
                        <property name="UTFversion" value="1.08"/>
SCREEN3:DEPTH=32,RECT=1200,0,2400,1920"/>gorInfo" value="IGORVERS:9.00;
                </properties>
                <testcase name="Test in Procedure (1)" classname="Test" time="0.005">
                        <failure message="3 == 4: is false.  Assertion "CHECK_EQUAL_VAR(3, 4)" failed in line 10, procedure "Procedure"" type="FAIL"></failure>
</system-out>case "Test";CHECK_EQUAL_VAR(3, 4)" failed in line 10, procedure "Procedure"
                <system-err>3 == 4: is false.  Assertion "CHECK_EQUAL_VAR(3, 4)" failed in line 10, procedure "Procedure"</system-err>
                </testcase>
</system-out>case "Test";CHECK_EQUAL_VAR(3, 4)" failed in line 10, procedure "Procedure"
                <system-err>3 == 4: is false.  Assertion "CHECK_EQUAL_VAR(3, 4)" failed in line 10, procedure "Procedure"</system-err>
        </testsuite>
</testsuites>

Only the last assertion made it into the file. This might be a regression.
Desired outcome:

One failure tag per failed assertion
correct failure count in testsuite tag as well

See https://stackoverflow.com/a/9410271 for the spec. The inventors of junit would like to see only a single failure, https://junit.org/junit4/faq.html scroll down to "Why does JUnit only report the first failure in a single test?" but I don't agree with them.

xmllint validates ok with multiple <failure..> tags.


Pass the blocks variation id as a classname to the edit in case it's …

…present

@steffenri We should do this for the grid View as well, no?
Also the linter is failing

@davisagli No need to.


Make all classes inherit from object

If no base is provided, then object should be an implicit base class.

I actually removed this on purpose since it was causing failures...

So it looks like we need to add object to the class bases, but we shouldn't add it before calling the metaclass...
Here's the relevant test case:
class MyMetaClass(type):
    @classmethod
    def __prepare__(metacls, name, bases):
        assert bases == ()
        return dict()
    def __new__(cls, name, bases, classdict):
        assert bases == ()
        return type.__new__(cls, name, bases, classdict)

class MyClass(metaclass=MyMetaClass):
    pass

assert MyClass.__bases__ == (object,)

I added it because I was seeing some test failures :)


feat: add Streamable constructor

I figured I'd just open a PR to start some discussion on an equivalent to Effectable for Stream.
The modification to toChannel is to favor choosing the Stream instance for any custom type which might be both a Stream and an Effect. This felt kinda odd, but I wasn't sure what else to do without larger changes to Stream's representation.

I think this solution is fine :)
If you fix docgen then we can merge this.

@tim-smart Thanks, I've updated the PR with the updated documentation


Use a different flight mode

In the gym env:
env = gym.make("PyFlyt/QuadX-Hover-v1")
how would I change the QuadX drone flightmode to -1?
Thanks :)

Because of the way that Gymnasium is built, there is no obvious way to alter internal attributes which would allow this to happen in the current version of PyFlyt. However, if you have a local instance of PyFlyt cloned and installed from, the relevant line for changing flight modes is here.
I am open to making this part of the options argument if you're willing to create a PR for it. :)

FYI, I've just updated PyFlyt to v0.17.0, which has a flight_mode argument for all the environments now. If you'd like, you should use that so you won't have to modify the source and can use PyFlyt natively with the transform observation wrapper from Gymnasium.


tests: improve :all bottle detection logic

Remove the check on the tap because I have the feeling that it is not always set.
We can skip :all bottles for the time being on any Linux env, as we don't
use :all bottles there.
Change the boolean detection logic, should work better now.

@dawidd6 this fixed the typescript build: https://github.com/Homebrew/homebrew-core/pull/80354/checks?check_run_id=2960911276
The Linux build is now  skipped there.
It did not fix the recursive dependents issue though, so it looks like my logic is still wrong for that ...

@iMichka I'd like this to remain tap-specific, please. Otherwise we're making a pretty big behaviour change for any third-party taps using this.

I'll add the tap-specific checks, now that I got everything fixed and it works like I want. It was easier to me to debug stuff with less parameters that could break things. I'll re-enable the taps check one by one and make sure it does not break anything.

Thanks @iMichka!


[SPARK-45597][PYTHON][SQL][FOLLOW-UP] Minor deduplicate datasource checking logic

What changes were proposed in this pull request?
This PR proposes to deduplicate datasource checking logic.
Why are the changes needed?
For better maintenance and readability.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing test cases should cover them.
Was this patch authored or co-authored using generative AI tooling?
No.

cc @allisonwang-db and @cloud-fan

Merged to master.


fix: update configuration model

Please ensure your pull request adheres to the following guidelines:

[ ] make sure to link the related issues in this description. Or if there's no issue created, make sure you
describe here the problem you're solving.
[ ] when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

If the PR is changing the API specification:

[ ] make sure you add a "Not implemented yet" note the endpoint description, if the implementation is not ready
yet. Ideally, return a 501 status code with a message explaining the feature is not implemented yet.
[ ] make sure you add at least one example of the request and response.

If the PR is changing the API implementation or an entity exposed through the API:

[ ] make sure you update the API specification and the examples to reflect the changes.

If the PR is introducing a new audit type:

[ ] make sure you update the API specification with the type, schema of the audit result and an example

Related Issues
Thanks for contributing!

:tada: This PR is included in version 1.73.4 :tada:
The release is available on:

v1.73.4
GitHub release

Your semantic-release bot :package::rocket:


Addresses resouce is missed

It is also seems missed in AccountsService =)
https://developers.coinbase.com/api/v2#addresses

looks like it's been added in v2
cant't clearly understand the workflow, maybe you could give me a hint?

how to get btc/eth address to deposits funds directly to Coinbase PRO account? (there is no way currently to get pro's wallet address)
how to make deposit properly? deposit CoinbaseAccount first and then DepositCoinbaseFundsAsync to transfer funds to PRO account and be able to place an order?
Do Account and CoinbaseAccount have different wallet addresses?

looks like it's been added in v2
cant't clearly understand the workflow, maybe you could give me a hint?

how to get btc/eth address to deposits funds directly to Coinbase PRO account? (there is no way currently to get pro's wallet address)
how to make deposit properly? deposit CoinbaseAccount first and then DepositCoinbaseFundsAsync to transfer funds to PRO account and be able to place an order?
Do Account and CoinbaseAccount have different wallet addresses?

hey, this resource is for Coinbase not Coinbase Pro so it wouldn't make sense to add. This library interacts with the exchange (Coinbase Pro) only and not regular Coinbase.
If you're looking to deposit from Coinbase to Coinbase Pro

Retrieve your Coinbase account ID from CoinbaseAccountsService
Use the AccountId from above and pass into DepositCoinbaseFundsAsync (in DepositsService) to deposit funds into your Pro account. The docs for this method can be found here: https://docs.pro.coinbase.com/#coinbase

Also, I recommend either testing this on sandbox first or testing with a small amount in case you put in the wrong account ids. I am not sure what the process to recover funds is. Hope this helps

hey, this resource is for Coinbase not Coinbase Pro so it wouldn't make sense to add. This library interacts with the exchange (Coinbase Pro) only and not regular Coinbase.
If you're looking to deposit from Coinbase to Coinbase Pro

Retrieve your Coinbase account ID from CoinbaseAccountsService
Use the AccountId from above and pass into DepositCoinbaseFundsAsync (in DepositsService) to deposit funds into your Pro account. The docs for this method can be found here: https://docs.pro.coinbase.com/#coinbase

Also, I recommend either testing this on sandbox first or testing with a small amount in case you put in the wrong account ids. I am not sure what the process to recover funds is. Hope this helps


Are these datasets duplicates?

dataset-584 and dataset-068 from National Student Clearinghouse Research Center appear to be duplicates?
  {'description': 'Thousands of high schools currently use StudentTracker® reports from the Research Center to measure how many of their graduates go on to college, where they attend, and how many persist to graduation. The reports were designed to help schools to measure their success in preparing students for college, and to evaluate the effectiveness of college access programs and curricula.', 'id': 'dataset-068', 'provider': 'provider-163', 'title': 'College Enrollment', 'url': 'https://nscresearchcenter.org/workingwithourdata/'}

  {'description': 'The National Student Clearinghouse regularly publishes research on student enrollment, movement, and other important student outcomes using student-level data provided exclusively to the National Student Clearinghouse by our nationwide network of postsecondary institutions. These reports are to benefit and better inform the educational community, policymakers, community leaders, and others.', 'id': 'dataset-584', 'provider': 'provider-163', 'title': 'National Student Clearinghouse data', 'url': 'https://nscresearchcenter.org/workingwithourdata/'}

If they are duplicates, please go back through the partitions and substitute instances of dataset-584 with dataset-068, then delete dataset-584.

Also, are these duplicates?

dataset-426
dataset-596


How to use thread-loader in craco?

How to use thread-loader in craco?
module: {
      rules: [
        {
          test: /.js$/,
          include: path.resolve(__dirname, '../src'),
          use: [
            // 'babel-loader',
            {
              loader: 'thread-loader',
              options: {
                workers: 3,
              },
            },
          ],
        },
      ],
    }

But,It won't work
error message: Error: Can't find a 'oneOf' rule under module.rules in the production webpack config!

@Kujo-Jotaro-AAAAA I might some more context to try and recreate this issue. Can you create a demo repo that has this issue, or maybe share your craco config and package.json?


epson-escpr2: fix build problem & 1.1.49 -> 1.2.9

Description of changes
fixes #274840 and updates the package
Not sure why that package at all was using busybox instead of the nativebuildinputs its actually using for unpacking the package source.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 275009 run on x86_64-linux 1

1 package built:

epson-escpr2

Not sure why that package at all was using busybox instead of the nativebuildinputs its actually using for unpacking the package source.

No idea, probably historical reasons :upside_down_face:
Merging as this fixes a build failure, cannot test it currently.
That said, are you interested in adding yourself as additional maintainer? I'm happy to help out with answering questions etc. (technically I still use it), though I don't use it that often anymore (and thus can't test it that often) because the printer in question is at my parent's place.


Refactor conversation-activity-filter

Fixes #4365
Follows https://github.com/sindresorhus/refined-github/pull/4361
Test URLs
This PR
https://github.com/SamVerschueren/vscode-linter-xo/issues/91
Screenshot
NONE

Always try to include as many references to other PRs and issues as possible so that they’re connected. I added https://github.com/sindresorhus/refined-github/pull/4361 to your post

@fregante this is good to go. It works perfectly


chore: Upgrade deps

Shouldn't there also be package.json changes if you've updated deps? And why did files in the dist folder change?

package.json is very allowing with its dependencies. It allows all minors and patches to be installed without requiring modifications. So no update is needed.
The files in the dist folder changed because that is the compiled Typescript. With new dependency code, the built code might also change.


Updated Kirki, "remove" button gone from repeater

http://i.imgur.com/22rJAkI.png
Saving with empty values doesn't remove the row

when will this be released to the version on the plugin repository?

I just use this temp fix, just add this css to your admin
button.button-link.repeater-row-remove:before {
content: 'Remove';
}


main entry is not valid

when i try to launch any code with this module it says Error: Cannot find module '/home/emmanuel_macron/Documents/programinc/gougoule.ch/server/node_modules/duck-duck-scrape/lib/index.js'. Please verify that the package.json has a valid "main" entry
step to reproduce the bug:

install the module
try using the exmple code from the readme.md in javascript nodejs
(sorry for bad english )

Should be fixed in v2.2.3.


How to export a container to a specific folder?

Required information

Distribution: KDE Neon
Distribution version: 5.10.95
The output of "lxc info" or if that fails:

driver: lxc
driver_version: 2.0.8
kernel: Linux
kernel_architecture: x86_64
kernel_version: 4.10.0-35-generic
server: lxd
server_pid: 110246
server_version: 2.0.10
storage: dir
storage_version: ""

Issue description
My machine does not have enough space to run lxc publish centos. So I would like to specify the destination of the copy.
Is there any way to do that?

Nope. "lxc publish" creates a new image in the LXD image store, which is always located at /var/lib/lxd/images/.
The image creation may also require additional disk space while generating the tarball of the container.

OK. So how to export an image directly to an external partition?

Once the image is in the LXD image store, you can do "lxc image export FINGERPRINT ." from wherever you want and it'll write it to your current directory.

It's not works.
~$ lxc image export a2021cb0fc40 /media/demsking/Workspace/
error: multipart: Part Read: unexpected EOF

Can you post the content of /var/log/lxd/lxd.log and the output of "dmesg" right after you get such a failure?
I suspect you're either running out of diskspace when LXD attempts to generate the multipart stream or running out of memory.

I just try again and it's works now!
I don't know what happened :/

@stgraber I attempted to point my images container to my zpool by pointing a sym link from /var/lib/lxd/storage-pools/default/images to /var/lib/lxd/images and I ran a publish normally... then cancelled it because it's filling up my root drive, but it has not cancelled and I cannot find the process with top or ps -awx - any ideas of the proper way to do this?


Alerts agent based on GEE LCL layers

An agent to feed the first alerts workflow. The agent needs to

[ ] Find GADM areas based on bbox or text
[ ] Compute DIST alert statistics for the area
[ ] Create a text description of the result

Based on LCL layers on GEE.

Som insight on getting geojson from tools: this is a lot of tokens for llms, but its hard to shield the llm from tool output.
It's not possible to update state from within a tool. We need to find a way to pass larger amounts of data from tools to the frontend without giving it to the LLM for interpretation. We probably want to pass part of the data as-is to the frontend, and part to the LLM for interpretation.
We can inject the state into the tool using InjectedState , but not update the state (or at least its highly discouraged).
For instance, pass disturbance statistics data to LLM, but send vectorized disturbances directly to frontend. I have not figured out how to solve that, and the vectorized geojson generates quite a lot of tokens.
A related discusison is
https://github.com/langchain-ai/langgraph/discussions/1616
cc @srmsoumya

Ok this was a bit hard to figure out, but there is a simple solution to this actually! 🫏
The @tool decorator has an additional argument: response_format (Literal['content', 'content_and_artifact']).
If this is is et to content_and_artifact, any kind of data can be passed to downstream as artifacts, and they will not be passed to the model. We can leverage this to feed data to the user.

Closing this as the individual items have been ticketed out separately.


[IOTDB-3682] Add DriverScheduler configuration into iotdb-datanode.properties

Coverage decreased (-0.03%) to 47.228% when pulling 55394db6eda09c00dee6613257cfb9966861b701 on IOTDB-3682 into b6ca325434cd85517f2403f51a49d67e4c25273e on master.


SSL: Enable custom transformations that extend the present set of transformations

create_transforms_from_config hardcodes what can be used, and is not extendable
AB#4743

Alternative: add the following

colorjitter misses the hue
verticalflip
rotation
greyscale
gaussianblur


Fixes cannot find config file due to symbolic/soft link.

Hi, I have a problem when my smuggler.py file is symlinked.
So, this is an improvement in my case that can't read the configuration file.
Fix by changing abspath to realpath, this will returns the canonical path of the specified filename, eliminating any symbolic links encountered in the path.
Regards.

Thanks for the contribution. I had initially tried to fix this another way, but I like your 1 liner better.
Thanks!


When handling plugin exit, lookup plugins only during daemon shutdown.

- What I did
The main intent of handling plugin exit is for graceful shutdown
of plugins during daemon shutdown. So avoid plugin lookup during
plugin exits caused by other reasons (eg. force remove)
- How I did it
By avoiding plugin lookup for cases other than daemon shutdown.
- How to verify it
Before this change, docker plugin remove --force caused errors in daemon logs.
DEBU[0450] plugin state changed 3a510f2a39b3805bebb55f20f3bbd92971a9405b0a4bc94b45050a213324bd40 libcontainerd.StateInfo{CommonStateInfo:libcontainerd.CommonStateInfo{State:"exit", Pid:0x0, ExitCode:0x89, ProcessID:""}, OOMKilled:false}
ERRO[0450] libcontainerd: backend.StateChanged(): plugin "3a510f2a39b3805bebb55f20f3bbd92971a9405b0a4bc94b45050a213324bd40" not found
After this change, there are no errors.
Signed-off-by: Anusha Ragunathan<EMAIL_ADDRESS>

LGTM

LGTM


IIIF viewer link from IIIF manifest

As discussed in https://discord.com/channels/…/1313159817388363862 ff., it would be convenient to have a button (or similar functionality) in the author mode that allows to open a IIIF viewer with the images of the document.
This could be based on the presentation manifests (https://iiif.annemarie-schwarzenbach.ch/presentation/). We could include them in a suitable spot in the teiHeader of the document.
But given that the URL is fully deterministic (https://iiif.annemarie-schwarzenbach.ch/presentation/{$type}_{nnnn}json) the interactive element could also be docked elsewhere and the link generated from the document ID. This would allow quick development and deployment as we wouldn't need to get the metadata ready (as is planned for mid January).
Edit: the target URL could be https://uv-v4.netlify.app/#?manifest=https://iiif.annemarie-schwarzenbach.ch/presentation/letter_0011.json. Or we could create a very simple page with an OSD instance that parses the URL param in a similar fashion and displays the images.
@cforney, do you agree that this is a low hanging fruit?

Thanks, great idea! This can easily be done with an OpenFileOperation.
Added a toolbar button in https://github.com/dse-as/oxygen-framework/commit/0eebce92ff307a639e850bad25fa8a04f7f11366 and linked to https://uv-v4.netlify.app/
Let's think again about setting up our own simple viewer page when we find time.

Very good. Can you inform the editors once the new version is out (the Discord channel should be pinged automatically)?


missing twitter reply for @gRegorLove

from @gRegorLove via IRC:

Looks like Bridgy hasn't found this reply tweet yet https://twitter.com/girlvsplanet/status/587735912303329281. Log shows my h-feed was fetched after the original post so I don't think it's the feed being cached. The post was yesterday.

deprioritizing for now. (sorry gregor!) please do let me know if you see more missing replies though!

i took a look at this, and it looks like out was caused by twitter's best effort only search API, at least at the time of that poll. details in #202, https://dev.twitter.com/docs/faq#8650 , https://www.brid.gy/about#missing .


docs: remove buttress service

I would like to start by expressing my admiration for Casbin. The dedication and hard work that have gone into it are truly commendable.
With that respect in mind, I am reaching out to request the removal of the link to my now-discontinued project, Buttress. While it was an honor to be part of the Casbin ecosystem, the project is no longer active or maintained, and its presence might mislead users to outdated or unsupported resources.
To maintain the integrity and relevance of the Casbin ecosystem, I believe removing this link would be beneficial. I have made the necessary changes in this pull request, ensuring that only the specific link is affected and all other aspects of the project remain intact. I am open to any suggestions or discussions regarding this change.
Thank you for your understanding, and for your continued commitment to excellence with Casbin. I appreciate your prompt attention to this matter and look forward to any feedback.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Bugfix SLO API: Update type for group_by to accept either string or array-of-strings

Starting with 8.14.0, the API can now return a list of strings instead of just a string. This causes a crash in the provider when reading from the cluster:
elasticstack % tf plan
elasticstack_kibana_slo.custom_kql: Refreshing state... [id=default/4712ef08-cb91-41ee-be7c-c31b2f02f0e1]

Planning failed. Terraform encountered an error while generating this plan.

╷
│ Error: json: cannot unmarshal array into Go struct field SloResponse.groupBy of type string
│
│   with elasticstack_kibana_slo.custom_kql,
│   on main.tf line 27, in resource "elasticstack_kibana_slo" "custom_kql":
│   27: resource "elasticstack_kibana_slo" "custom_kql" {
│

To be able to handle both old and new APIs, the spec has been updated to accept either a string or a list of strings.
This update was done manually, as the official Kibana API has not yet been updated to reflect this change.
This change only ensures that the provider doesn't crash with the new API, there is no support yet to configure multiple group-by arguments in the schema.
This is also the reason why the change didn't really cause many code changes: We are not actually using the group-by when reading. It is only passed through when creating/updating.

The acceptance tests are passing against 8.14 currently so I expect that if groupBy is specified as a string during creation then it's returned as a string. I'm not sure we're properly exercising this code with the current tests.

At least from the manual tests I did, the API always returns a list.

This sounds like a bug, and looking at the code isn't one that's that hard to fix. I wonder if it's worth updating the schema for group_by to be a []string and fully fixing this attribute whilst we're here?

Wouldn't this break the config for all current users of the provider? Meaning they have to change the config after updating.

At least from the manual tests I did, the API always returns a list.

Can we double check that, at least one of the acceptance tests sets group by and I'd expect it to fail if this were the case right?

But wouldn't this break the config for all current users of the provider? Meaning they have to change the config after updating. Though at some point we have to switch over to a list anyway.

There's been a couple of breaking changes in the past, and this would be relatively simple to adjust to (just wrapping the current value in []). I think in theory we shouldn't shy away from making this change.
Another part of the problem is that the schema suggests group by could be a list, but for 8.13 or lower the provider will have to take only the first item and explicitly set it as a plain string.

Another part of the problem is that the schema suggests group by could be a list, but for 8.13 or lower the provider will have to take only the first item and explicitly set it as a plain string.

Yeah, I think I will make the change. I have to check what the error is if a list is sent when it isn't supported. Otherwise I guess we need to have a validation for <8.14 to only allow one item in the list.
When serializing I could probably make it work for every case by just always using the string if the list has exactly one element (as the new API supports both string and list-of-string)

There's been a couple of breaking changes in the past, and this would be relatively simple to adjust to (just wrapping the current value in []). I think in theory we shouldn't shy away from making this change.

Seems like it isn't enough to just update the config. There also needs to be a state migration. It looks like this is possible in the sdk as well, although it is necessary to copy the whole schema definition.

There also needs to be a state migration

Yea, of course. I'm happy if you want to get this one merged/released and we can fix the rest fixed up in a follow up.


Improving UI of full home page

The UI of home page looks sick and i would like to make it a bit modern and good to eyes. Kindly assign this task to me

@Anamika-garg @ark0078 Thanks for creating the issue in BuddyTrail!!! The issue has been assigned to you.
Before you start working on your PR, please make sure to:

⭐ Star the repository if you haven't already.
Pull the latest changes to avoid any merge conflicts.
Attach before & after screenshots in your PR for clarity.
Include the issue number in your PR description for better tracking.

Level will given at the time of PR merge .Contributors  level will increase based on the quality and quantity of their contributions. The more effort and value you bring, the faster you'll progress. Put forth your best effort to unlock new levels and opportunities!
I'm excited to see your contribution as part of GSSOC EXTENDED 2024! 🎉
Don't forget to follow me on GitHub for more updates.
Happy open-source contributing! 🚀


How to pass a custom EnforcerService or how to make dbcontext available to RequestTransformer

I am trying to retrieve objects from our db, based on ids passed by the request, to the enforcer, so that these objects are passed to a custom function when evaluating a policy.
I have created a CustomRequestTransformer (base class BasicRequestTransformer).
Two of the request values I retrieve within this transformer are the oid of the user and a reference id of a tenant. With these ids I want to be able to get the User and Customer object in our database. So that I can return these objects in the requestValues-object of TransfromAsync and so pass them on to the enforcer in DefaultEnforcerService (line 88).
Is there a way to pass the dbcontext with the CustomRequestTransformer through dependency injection when configuring the DefaultRequestTransformer in the services.AddCasbinAuthorization()?
Or is there a way to pass a custom EnforcerService instead of the services.TryAddScoped<IEnforceService, DefaultEnforcerService>(); within AddCasbinAtuhorizationCore().
Or is there another way to enable this?

@sagilio

At the moment I have found a - not so recommendable - solution, as the following warning is shown on the line
var sp = services.BuildServiceProvider(); >> "ASP0000: Calling 'BuildServiceProvider' from application code results in an additional copy of singleton services being created. Consider alternatives such as dependency injection services as parameters to 'Configure'."
In the DefaultEnforcerFactory we have the option of passing the IServiceProvider, but in DefaultRequestTransformer that option is not available.

Any suggestions?

You can get the DbContext from the HttpContext.RequestServices:

All services be added in the container by the TryAdd function, you can add your custom service before AddCasbinAtuhorizationCore(). Or replace it after AddCasbinAtuhorizationCore().

@sagilio Thank you for this clarification! :pray:


Merge develop into staging, 2024 Feb 08 edition

This merge is mostly to incorporate the fix for #1283.

This was deployed to Staging a little while ago. All tests are passing, and the site is behaving as expected.


Link classes to Github source code

It would be helpful if each Struct, Class, Enum doc has a link to its original source code on GitHub if it has one. I sometimes want to look at the source code, and it is not easy to search for it.

This would be exceptional. @stephentoub any idea on who could pick this up and drive it?

Would this take the place of reference source?
Presumably this would also link to the appropriate release versions.

cc: @jeffhandley, @carlossanlop

It will be helpful tow if the GitHub source has a help icon to go to the doc.

cc @mimisasouvanh @jffriend @gewarren
Could this be done through the mdoc pipeline?

This has been requested many times previously, e.g. https://github.com/MicrosoftDocs/feedback/issues/433, https://github.com/dotnet/dotnet-api-docs/issues/3209, https://github.com/dotnet/dotnet-api-docs/issues/6793.
It's being tracked by this internal work item.

Great news - the core .NET libraries now have links to source code!
Example: https://learn.microsoft.com/en-us/dotnet/api/system.string.chars?view=net-8.0

Wow! This is even more specific by linking each member to its location in the source file!
Thanks a lot for this great work!

From: Genevieve Warren @.>
Sent: Thursday, April 4, 2024 5:20 PM
To: dotnet/docs @.>
Cc: Mohammad Hamdy Ghanem @.>; Author @.>
Subject: Re: [dotnet/docs] Link classes to Github source code (Issue #27938)
Great news - the core .NET libraries now have links to source code!
Example: https://learn.microsoft.com/en-us/dotnet/api/system.string.chars?view=net-8.0
—
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/docs/issues/27938#issuecomment-2037771885, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALQ5MVQH5LMJJQ2XZXVZTVTY3WDXBAVCNFSM5MUBABS2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBTG43TOMJYHA2Q.
You are receiving this because you authored the thread.Message ID: @.***>


Remove version: ImageLine.FLStudio version <IP_ADDRESS>25

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

Close with reason: URL works;


Update dps_bcgw_w.md

Minor spelling correction, removed italics from some notes in 'Am I Ready?' table to improve consistency

Thank you for your feedback and input into our documentation. I will make these and additional changes to our page so the text format is consistent within the table.


Make the play button on the rules page light up when hovered

Currently it just stays grayed out, and a highlight around its edges is the only indication that you have hovered the button. It would be nicer if instead it changed picture, like on the main menu of the game.
I think also if this is possible, the loading screen off the menu should be removed and this same functionality should be used for the menu buttons and logo as well. That way Google will like us better because there won't be any big screen changes when it loads the page...

This has now been added


Rel 0.9.5

What type of PR is this?

enhancement/feature

What this PR does / why we need it:
This PR:

Updates the documentation to better specify how to identify a Device
Updates the Device parameter according to CAMARA_common.yaml: https://github.com/camaraproject/EdgeCloud/issues/123
Changes the API name in YAML according to: https://github.com/camaraproject/EdgeCloud/issues/243
introduces sourceTrafficFilters and modifies trafficFilters into destinationTrafficFilters according to: https://github.com/camaraproject/EdgeCloud/discussions/230

Which issue(s) this PR fixes:
https://github.com/camaraproject/EdgeCloud/issues/123
https://github.com/camaraproject/EdgeCloud/issues/243

When this PR is merged I proposed to move the TI API from WIP to Alpha according to: https://wiki.camaraproject.org/display/CAM/API+versioning

Conclusion, considering:
https://github.com/camaraproject/EdgeCloud/pull/249#discussion_r1638069544
and:
https://github.com/camaraproject/EdgeCloud/pull/249#discussion_r1639421296
A device can have:
Private-1 IP and Port (in the LAN)
Private-2 IP and Port (Core Network)
Public IP and Port (Internet)
UPF must be configured with Private-2 IP and Port.
The API Consumer is aware of "Private-1" and "Public"
"Private 1" = "Private 2" if the Device is a Smartphone directly connected to the network (no FWA or tethering).
In Device we have Public IP and Port that the API Consumer choose according to the Flow of interest from the device. From this the OP can identify Private-2 IP and Port. If the API Consumer decides to use This as identifier we are ok.
If the API Consumer chooses phoneNumber or networkAccessIdentifier we need sourceTrafficFilter to define Private-2 Port. The Problem is that Private-2 Port is not known by the API Consumer.
To cover FWA and tethering we should not use Device, with the many options, but we need to identify the UE just with "Public IP and Port".
Proposal: limit Device to just "Public IP and Port".

@FabrizioMoggio, one query on the above comment. We can limit the device identifier to just "Public IP and Port".
But for the Application server to indicate if the influence is to be done on one port or many ports, the sourceTrafficFilters may be there in which the 'specific source port' or 'all source ports' can be differentiated.

@FabrizioMoggio, one query on the above comment. We can limit the device identifier to just "Public IP and Port". But for the Application server to indicate if the influence is to be done on one port or many ports, the sourceTrafficFilters may be there in which the 'specific source port' or 'all source ports' can be differentiated.

I see, we can't use Device as defined by Commonalities. We need to define our own source identifier parameter. We can name it: SourceDevice. I see two options:

SourceDevice that also includes list of ports. We don't need sourceTrafficFilter

SourceDevice:

Public IP
Phone Number
list of Public Ports

SourceDevice without the list of ports. We need sourceTrafficFilter

SourceDevice:

Public IP
Phone Number

sourceTrafficFilters:

list of Public Ports

I think option 2 with some small changes will be clearer to the user since it demarcates the Device and Traffic attributes.
I feel we can still keep the device format as it is. The name sourceDevice may confuse the user.
Device:
•	Public IP and Public Port
•	Phone Number
(Public port becomes optional for IPv6)
sourceTrafficFilters:
•	list of Ports.
(the list of ports can be applicable to IPv4 and Ipv6)

@babunkj I see you point . My concern on adopting a parameter named Device is that it can be confusing for a Developer working in CAMARA to have a parameter named Device like the one in Commonalities but different.
To everyone: Any idea for a better name, like InfluencedDevice or TI_Device or do we stick to Device with an high level note in the documentation explaining why it is different from the one in Commonalities ?

ist of Ports.

I think the API should be aligned with other APIs for common aspects where the commonality group guidelines can be followed and two different terms should be avoided for the same concept.
So if all the other APIs refers to the term "Device" then we should also follow that while traffic patters can be something which we may define like sourceTrafficFilter or destTrafficFilter etc

@gunjald as a principle, I agree with you but here it doesn't work unless we decide that, to add more ports, the API Consumer needs to invoke the TI API more times, as it they were different users. This is because "Commonalities-Device" already has  sourcePort included, just one though.  An alternative to avoid the API Consumer calling the TI API many times for the same user, is to use sourceTrafficFilters to add more ports. We should explain this very well in the documentation.
Another problem with "Commonalities-Device", is that it also includes PrivateIP  that doesn't always work for the TI API (FWA or Tethering). We should anyway have a TI_Device that is derived from Commonalities-Device with the PrivateIP blocked somehow.

@FabrizioMoggio as I understand there are two issues. First one is the device identification which may itself contain an IP, public or private as you said, and then the second one is the traffic identification.
For the device identification i thin any combination of its public IP or the private IP along with associated ports should be able to determine the same device and as you suggested it could be  TI_Device or something like that but this should be used only for device identification and not for the traffic identification.
For the traffic identification the sourceTrafficFilters or destTrafficFilters can be defined with the option of specifying multiple ports to avoid multiple TI API invocation.
Are you thinking something similar?

Yes I am, I have checked Commonalities-Device. it uses DeviceIpv4Addr:
that has
anyOf:
- required: [publicAddress, privateAddress]
- required: [publicAddress, publicPort]
So PublicIP is anyway mandatory.
Proposal:

we use Device as defined in Commonalities
we add sourceTrafficFilters to provide the option to add more PublicPorts
we add a good explanation in the Documentation :-)

I agree to your proposal. Just one thing. Should we keep destTrafficFilters as well for cases where EAS IP and port information is available for a given device and developer may want to use that?

yes, we also keep destTrafficFilters

I am all good with the proposal :-)

@babunkj is this ok with you?

Yes @FabrizioMoggio . Your proposal to use Device attribute as defined in Commonalities, add sourceTrafficFilters to provide the option to add more ports (let us call it sourcePorts as you had defined now) and give a good explanation in the Documentation is fine.


Run ameba via WSL

I run my VS Code in Windows and using Crystal tools via wsl interface.
Running VS Code in WSL mode is not feasible for me since my project has a large amount of files that make VS Code WSL mode consumes a lot of memory and CPU to watch those files (yes even if those files are explicitly ignored).
Is there anyway to set the absolute path for ameba (like in the VS Code Crystal extension) so I can prefix the command path with wsl to make it works in windows?
I tried to create an ameba.bat with this content, but it doesn't seem to work:
wsl /usr/bin/ameba %*

after some tweaks, this batch file works:
@echo off
wsl /usr/bin/ameba $(wslpath "%1") --format json

closing the issue


Fixed #27225 -- Made FetchFromCacheMiddleware set Age header for cached responses.

https://code.djangoproject.com/ticket/27225

Are you addressing the other comments later or did you miss them?

Later this week

Need additional couple of weeks to complete. Sorry for this, no time - preparing to conference.

@renskiy, do you have time to finish this soon?

@timgraham, Yes I have. This weekend I think.

A super gentle reminder @renskiy. Do you need help?

Closing due to inactivity.