Add URL option for sampling strategies file

Which problem is this PR solving?

Resolve #2015

Short description of the changes

Added a URL option to support downloading a sampling strategies file from a url.

@yurishkuro Thanks for the suggestions. I've made changes to the pull request

top-level question: should there be some local file fallback option if the URL is temporarily unavailable? Because if whichever service provides the strategy for download is down the collector would not be able to start.

How about falling back to default strategies similar to when options.StrategiesFile is empty? Also, we can have a retry mechanism for URL option.

Default strategy is fine. The difference with StrategiesFile not found is in that case it's ok to fail because it likely indicates a mis-configuration, whereas in case of HTTP server not available then failing is counterproductive.

please check why the DCO test is failing:
Commit sha: 932f6e0, Author: Deepak, Committer: Deepak; Expected "Deepak<EMAIL_ADDRESS>but got "Deepak Sah<EMAIL_ADDRESS>
You need to ensure full name in git matches full name in github

please check the linter failures
plugin/sampling/strategystore/static/strategy_store_test.go:130:9: this value of err is never used (SA4006)
plugin/sampling/strategystore/static/strategy_store_test.go:484:11: this value of err is never used (SA4006)

please check the linter failures
plugin/sampling/strategystore/static/strategy_store_test.go:130:9: this value of err is never used (SA4006)
plugin/sampling/strategystore/static/strategy_store_test.go:484:11: this value of err is never used (SA4006)

Fixed the linter issues.


Improve UI for tag filters [IMPROVEMENT]

The current UI implementation of the tag filters, looks inconsistent with overall design theme of the website.

See Current Implementation

Proposed changes

Improve the current UI, so that it easily blends in with the rest of the design, you can infer the proposed changes screenshot for inspirations, or if you have any other ideas, feel free to create a PR.
Before, starting to work on this issue, please comment here and I'll assign this issue to you.

Hi,I would like to work on this .Please assign it to me.

Hey @Abhi067852 ! Thanks for showing your interest in the repository.
I've assigned this issue to you, Go ahead and make a PR. Goodluck ! ✨

Sir, I have created a PR please review it and give suggestions.


Use of contentType inside send_file.

As per the documentation here, the contentType field has been deprecated. However, it is still used here and here.
Currently, if someone saves an image through the gridfs module and use send_file it will leave the mimetype as text/html. Using the recommended method from the documentation of GridFS of putting the mimetype inside the metadata field will also not work.
Therefore, one must either pass contentType='image/base64' to the GridFS.put function or change the mimetype of the response_class object returned by send_file.
This behavior can only be noticed once you look at the sources. Therefore, I suggest moving to using the metadata field instead.
Working example:
from gridfs import GridFS
from flask import Flask
from flask_pymongo import PyMongo

app = Flask("app")
app.config['MONGO_URI'] = 'mongodb://localhost:27017/test'
mongo = PyMongo(app)
fs = GridFS(mongo.db)

filename = "..." # PNG image

fs.put(open(filename, 'rb'), filename=filename)

response = mongo.send_file(filename)

print(response.mimetype)

PyMongo itself does not attempt to set the content_type field on GridFS files -- that's one of the features of Flask-PyMongo when you use save_file. It's not expected that PyMongo would set the field, so if you are writing data to GridFS with PyMongo, you should set the field yourself when you write, or set the content-type on the response, as you suggest.
Regarding the deprecation: it doesn't look like PyMongo has taken any steps to deprecate usage of contentType or md5 or to move them into metadata; as of today, GitHub master on pymongo doesn't have any deprecation warnings for those fields.
Trying to change Flask-PyMongo may prove tricky. Any existing installations may need data migration, or we may have to live with dual reads for a long time (maybe not the worst thing). But the bigger concern is what will happen in PyMongo itself in this regard -- I don't want to duplicate work there, or do something that will cause incompatibility in the future.


Not able to build project with ToolsVersion="15.0"

I'm using the image tagged as "microsoft/dotnet-framework:4.7.2-sdk" into my CI pipeline.
From today when I try to build I'm getting the following error:
Project file contains ToolsVersion="15.0". This toolset may be unknown or missing, in which case you may be able to resolve this by installing the appropriate version of MSBuild, or the build may have been forced to a particular ToolsVersion for policy reasons. Treating the project as if it had ToolsVersion="4.0". For more information, please see http://go.microsoft.com/fwlink/?LinkId=291333
Thanks
G.

@giusepanzuto - any chance you can share your project?  VS 2019 was released yesterday which is more than likely the source of the issue.  To unblock yourself until the issue is resolved, you can use the pervious version - mcr.microsoft.com/dotnet/framework/sdk:4.7.2-20190312-windowsservercore-ltsc2016 tag.

Related to #228
It'd also be helpful to know what your Dockerfile looks like.

@giusepanzuto - any chance you can share your project? VS 2019 was released yesterday which is more than likely the source of the issue. To unblock yourself until the issue is resolved, you can use the pervious version - mcr.microsoft.com/dotnet/framework/sdk:4.7.2-20190312-windowsservercore-ltsc2016 tag.

I confirm, it works correctly with the version 4.7.2-20190312-windowsservercore-ltsc2016, so I think that the issue is caused by the last update.
Unfortunately I cannot share code here, but I can confirm that we have the same issue with all software that are currently using pipeline with this image.
Thank you for the support.
G.

@giusepanzuto - Are you able to provide a simplified version of the project that can repro the issue?  As an example, there are projects in both the tests and samples folder of this repo which are using 15.0 for the ToolsVersion and they do not get such an error.

@giusepanzuto - I understand not wanting to share the project here.  As @mthalman mentioned a standalone repo is preferred.  If you can't figure one out and you are willing to share it with me you can mail me @ msimons@ms.

I'm try to create an example project... in the meanwhile... a difference can be that we use Cake to run the build. The command is:
MSBuild(solutionFile, new MSBuildSettings {
    Verbosity = Verbosity.Minimal,
    Configuration = "Release"
});

Curious if you using a recent version of Cake which supports VS 2019?  It looks like support was added here.

it seams that use the preview version
/Program86/Microsoft Visual Studio/2019/Preview/MSBuild/Current/Bin/MSBuild.exe

Ah yes, I didn't notice that.  Seems like that is going to be an issue.  I would follow up with Cake on this.

Closing since this appears to be an external issue (e.g. Cake).


Experimental Feature: Vector Store

Related product team resources: roadmap card (internal only) and PRD (internal only)
Related product discussion: https://github.com/meilisearch/product/discussions/621
Related spec: https://github.com/meilisearch/specifications/pull/248
Motivation
Meilisearch aims to grow its market share and establish itself in a fast-paced market by using AI to address search needs.
Usage
The proposed solution consists of two API endpoints for storing and retrieving dense vectors in the first iteration.
Refer to the final spec to know the details and the final decisions about the usage.
TODO

[x] Release a prototype
[x] If prototype validated, merge changes into main
[ ] Update the spec

Impacted teams
@meilisearch/docs-team @meilisearch/integration-team

Follow Up
This is the follow up work we need to do to improve the vector store feature of Meilisearch.

[ ] Implement our own HNSW on top of LMDB to avoid having to deserialize it entirely at every search request.
[x] Delete the documents and vectors from the HNSW-related data structures.

[ ] Do it the efficient way (Wait for a new method or implement it myself).

[x] Store the HNSW on possibly multiple LMDB values.

[ ] Measure it and make it faster if needed
[ ] Export the ReadableSlices type into a small external crate

[ ] Remove the _vectors field from the default searchable attributes (as we do with _geo?).
[ ] Correctly compute the candidates by remembering the documents having a valid _vectors field.
[ ] Return the right errors:

[ ] Return an error when the query vector is not the same length as the vectors in the HNSW.
[ ] We must return the user document id that triggered the vector dimension issue.
[ ] Fix the error codes when using the search route.

[ ] Introduce some settings:
We currently ensure that the vector length is consistent over the whole set of documents and return an error for when a vector dimension doesn't follow the current number of dimensions.

[ ] The length of the vector the user will provide.
[ ] The distance function (we only support dot as of now).

[ ] Introduce other distance functions

[ ] Euclidean
[x] Dot Product
[ ] Cosine
[ ] Make them SIMD optimized
[ ] Give credit to qdrant

[ ] Add more tests

Hello everyone 👋
We have just released the first RC (release candidate) of Meilisearch containing this change!
You can test it by using

the release assets
the Meilisearch Docker image

docker run -it --rm -p 7700:7700 -v $(pwd)/meili_data:/meili_data getmeili/meilisearch:v1.3.0-rc.0

If you encounter any bugs, please report them here.
Thanks in advance for your help and your involvement in Meilisearch ❤
🎉 The official and stable release containing this change will be available on July 31st, 2023
⚠ RC (release candidates) are not recommended for production


OS X Yosemite + bash it

I have no idea how https://github.com/Bash-it/bash-it can possibly affect LightTable, but it looks like it does
Here the error message:
Error: Error: Command failed: /Users/andriytyurnikov/.bash_it/lib/helpers.bash: line 76: `bash-it': not a valid identifier
is not ISeqable
    at Error (<anonymous>)
    at cljs.core.seq (file:///Applications/LightTable.app/Contents/Resources/app.nw/core/node_modules/lighttable/bootstrap.js:2833:11)
    at cljs.core.empty_QMARK_ (file:///Applications/LightTable.app/Contents/Resources/app.nw/core/node_modules/lighttable/bootstrap.js:3693:62)
    at eval (file:///Applications/LightTable.app/Contents/Resources/app.nw/core/node_modules/lighttable/bootstrap.js:31483:32)
    at ChildProcess.exithandler (child_process.js:641:7)
    at ChildProcess.EventEmitter.emit (events.js:98:17)
    at maybeClose (child_process.js:735:16)
    at Socket.eval (child_process.js:950:11)
    at Socket.EventEmitter.emit (events.js:95:17)
    at Pipe.eval [as close] (net.js:466:12)

and here is first 80 lines of file mentoned cat /Users/andriytyurnikov/.bash_it/lib/helpers.bash
(I think it is somehow about line#32)
:
# Helper function loading various enable-able files
function _load_bash_it_files() {
  subdirectory="$1"
  if [ ! -d "${BASH_IT}/${subdirectory}/enabled" ]
  then
    continue
  fi
  FILES="${BASH_IT}/${subdirectory}/enabled/*.bash"
  for config_file in $FILES
  do
    if [ -e "${config_file}" ]; then
      source $config_file
    fi
  done
}

# Function for reloading aliases
function reload_aliases() {
  _load_bash_it_files "aliases"
}

# Function for reloading auto-completion
function reload_completion() {
  _load_bash_it_files "completion"
}

# Function for reloading plugins
function reload_plugins() {
  _load_bash_it_files "plugins"
}

bash-it ()
{
    about 'bash-it help and maintenance'
    param '1: verb [one of: help | show | enable | disable ]'
    param '2: component type [one of: alias(es) | completion(s) | plugin(s) ]'
    param '3: specific component [optional]'
    example '$ bash-it show plugins'
    example '$ bash-it help aliases'
    example '$ bash-it enable plugin git'
    example '$ bash-it disable alias hg'
    typeset verb=${1:-}
    shift
    typeset component=${1:-}
    shift
    typeset func
    case $verb in
         show)
             func=_bash-it-$component;;
         enable)
             func=_enable-$component;;
         disable)
             func=_disable-$component;;
         help)
             func=_help-$component;;
         *)
             reference bash-it
             return;;
    esac

    # pluralize component if necessary
    if ! _is_function $func; then
        if _is_function ${func}s; then
            func=${func}s
        else
            if _is_function ${func}es; then
                func=${func}es
            else
                echo "oops! $component is not a valid option!"
                reference bash-it
                return
            fi
        fi
    fi
    $func $*
}

@andriytyurnikov please add steps to reproduce this.

@kenny-evitt it is right there after LightTable start:
OS X Yosemite, with bash as a shell and bash-it installed
(screenshot)[http://cl.ly/image/2V28182e3t0i]
Launching LightTable executable from SpotLight

@andriytyurnikov ahhh – interesting. This seems to be the same issue as #1277. Based on this comment on that issue, this is a problem with Node not ignoring what are technically invalid bash identifiers, e.g. bash-it (because of the hyphen).

Duplicate of #1277


Update PPP layout

Codecov Report
Base: 46.39% // Head: 46.39% // No change to project coverage :thumbsup:

Coverage data is based on head (31e6144) compared to base (3b3f9ea).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #239   +/-   ##
=========================================
  Coverage     46.39%   46.39%
  Complexity      685      685
=========================================
  Files           143      143
  Lines          3479     3479
  Branches        412      412
=========================================
  Hits           1614     1614
  Misses         1723     1723
  Partials        142      142

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


merge from template-arlac77-github

package.json

chore(deps): add ^8.0.1 remove ^8.0.0 (devDependencies.c8)

:tada: This PR is included in version 1.0.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix clustermesh policy with endpoint-routes mode

In endpoint-routes mode, we encode the source identity in the ctx->mark
when locally routing the packet to the destination device for ingress
policy assessment. Previously we only encoded the local cluster
identity in the mark, thereby omitting the original cluster portion of
the identity.
Found by code inspection.
Fixes: 654303a20def ("bpf: Skip ingress policy at egress of source if egress prog is in use")
This unlikely to affect many users as by default users do not typically configure clustermesh + endpoint-routes (or ENI) mode at the same time.

Coverage decreased (-0.05%) to 37.161% when pulling 1dcdd6c5da8965e24c5f302fd77a080cf4448898 on joestringer:submit/identity-clustermesh-fix into 56a9c1fe93686d05e153c025865d2042127da4f1 on cilium:master.

I dropped the older backport labels as this is unlikely to affect existing users due to the unusual combination of configurations.

retest-4.9

retest-4.19

retest-netnext

Kernel-4.9 passed: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.19-kernel-4.9/53/
Kernel 4.19 failed, flake #7721: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Kernel/2678/
I'll rekick the entire CI since I forgot before and the trigger attempts from Nate above don't seem to be working.

test-me-please

VM provisioning failed on net-next, seems like it timed out for some weird reason: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.12-net-next/66/flowGraphTable/

retest-net-next

retest-gke

Looks like this PR needs a rebase to get commit 4ea0ea4c9c9b1e837e99b265fa438d53d12b0ae4 which will fix the Go-related checks / lint action.

test-me-please


Issues building with rust 1.7.0-nightly

I just installed rust nightly and can't get things to build correctly. I read somewhere that nightly has removed a LOT of deprecated things in the last 6 months, so I'm not sure if the README has the correct information regarding building or not.
I really know nothing about Rust, heh.
Thanks!
/Users/jmaddox/.cargo/registry/src/github.com-88ac128001ac3a9a/winapi-build-0.1.1/src/lib.rs:1:1: 1:1 error: can't find crate for `std` [E0463]
/Users/jmaddox/.cargo/registry/src/github.com-88ac128001ac3a9a/winapi-build-0.1.1/src/lib.rs:1 // Copyright © 2015, Peter Atashian
                                                                                ^
error: aborting due to previous error
/Users/jmaddox/.cargo/registry/src/github.com-88ac128001ac3a9a/encoding_index_tests-0.1.4/index_tests.rs:1:1: 1:1 error: can't find crate for `std` [E0463]
/Users/jmaddox/.cargo/registry/src/github.com-88ac128001ac3a9a/encoding_index_tests-0.1.4/index_tests.rs:1 // This is a part of rust-encoding.
                                                                                ^
error: aborting due to previous error
Build failed, waiting for other jobs to finish...
/Users/jmaddox/.cargo/registry/src/github.com-88ac128001ac3a9a/pkg-config-0.3.6/src/lib.rs:1:1: 1:1 error: can't find crate for `std` [E0463]
/Users/jmaddox/.cargo/registry/src/github.com-88ac128001ac3a9a/pkg-config-0.3.6/src/lib.rs:1 //! A build dependency for Cargo libraries to find system artifacts through the
                                                                                ^
error: aborting due to previous error
/Users/jmaddox/.cargo/registry/src/github.com-88ac128001ac3a9a/libc-0.2.4/src/lib.rs:1:1: 1:1 error: can't find crate for `std` [E0463]
/Users/jmaddox/.cargo/registry/src/github.com-88ac128001ac3a9a/libc-0.2.4/src/lib.rs:1 // Copyright 2012-2015 The Rust Project Developers. See the COPYRIGHT
                                                                                ^
error: aborting due to previous error
/Users/jmaddox/.cargo/registry/src/github.com-88ac128001ac3a9a/gcc-0.3.21/src/lib.rs:1:1: 1:1 error: can't find crate for `std` [E0463]
/Users/jmaddox/.cargo/registry/src/github.com-88ac128001ac3a9a/gcc-0.3.21/src/lib.rs:1 //! A library for build scripts to compile custom C code
                                                                                ^
error: aborting due to previous error
/Users/jmaddox/.cargo/registry/src/github.com-88ac128001ac3a9a/getopts-0.2.14/src/lib.rs:1:1: 1:1 error: can't find crate for `std` [E0463]
/Users/jmaddox/.cargo/registry/src/github.com-88ac128001ac3a9a/getopts-0.2.14/src/lib.rs:1 // Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
                                                                                ^
error: aborting due to previous error
/Users/jmaddox/.cargo/registry/src/github.com-88ac128001ac3a9a/rustc-serialize-0.3.16/src/lib.rs:1:1: 1:1 error: can't find crate for `std` [E0463]
/Users/jmaddox/.cargo/registry/src/github.com-88ac128001ac3a9a/rustc-serialize-0.3.16/src/lib.rs:1 // Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
                                                                                ^
error: aborting due to previous error
/Users/jmaddox/.cargo/registry/src/github.com-88ac128001ac3a9a/winapi-0.2.5/src/lib.rs:1:1: 1:1 error: can't find crate for `std` [E0463]
/Users/jmaddox/.cargo/registry/src/github.com-88ac128001ac3a9a/winapi-0.2.5/src/lib.rs:1 // Copyright © 2015, Peter Atashian
                                                                                ^
error: aborting due to previous error
Could not compile `winapi-build`.

To learn more, run the command again with --verbose.

Your rust installation seems broken. How did you install it ?
I'd avoid using homebrew, I've had problems with it in the past.

Closing as this is most definitely a problem with the rust installation.


HSEARCH-2581 follow-up to fix performance issues

https://hibernate.atlassian.net/browse/HSEARCH-2581
Follow-up on #1328.
I'm creating this PR to trigger a build on our CI.
This should fix the problems we've been experiencing on CI lately.

Jenkins, retest this please

Jenkins, retest this please.

Jenkins, retest this please.

Jenkins, retest this please.

The commits look good, I would like to merge this.
But the build is still failing with a similar error:
Caused by: java.io.IOException: Too many open files
	at sun.nio.ch.IOUtil.makePipe(Native Method)
	at sun.nio.ch.EPollSelectorImpl.<init>(EPollSelectorImpl.java:65)
	at sun.nio.ch.EPollSelectorProvider.openSelector(EPollSelectorProvider.java:36)
	at java.nio.channels.Selector.open(Selector.java:227)
	at org.apache.http.impl.nio.reactor.AbstractMultiworkerIOReactor.<init>(AbstractMultiworkerIOReactor.java:142)
	... 65 more

Shall I leave the PR open?
It's possible that we simply have to raise the limits.

I have a theory - I couldn't verify yet - but I suspect the problem is simply caused by the fact that the reactive threads of the async http client aren't shut down aggressively but just "scheduled to close gracefully".
This graceful shutdown happens rather quickly, but it should take at least a full second as the selector needs to wake up first (and has a 1s timeout by default), so we don't notice any leak when debugging a single test yet I see ~2500+ threads over JConsole during the testsuite.
The testsuite takes longer than 1s but since the amount of threads to be shut down quickly raises in the hundreds, the scheduler isn't going to wake them all up as aggressively so this 1s wakeup time becomes longer.. coumpounding the problem.
I think we either find a way to block and wait for the shutdown to have happened, or we just avoid the explosive scheduling issue by setting a lower setting in the testsuite:
elasticsearch/src/test/resources/hibernate.properties :
hibernate.search.default.elasticsearch.max_total_connection 2

@Sanne Interesting.
You commit actually reduces the number of leaked file descriptors for each search factory from 64 to 10. It's better, though I don't understand why 10 times less threads translates into 6.4 times less leaked file descriptors.
On the other hand, setting max_total_connection to 2 means we end up with ours tests only being able to perform 2 concurrent calls to Elasticsearch. Which supposedly was what made performance tests fail on the CI, and is what I tried to solve in my first commit...
So I'm a bit torn here: it seems we end up exactly where we started from, and had some luck with the CI... I'll try to see what those 10 remaining threads are, maybe it can shed some light on the issue...

I just rebased to also implement the improvements in TestElasticsearchClient. Still investigating, but one intersting thing is that the TestElasticsearchClient does not leak threads for some reason: the threads of its RestClient are correctly terminated, while those of the main RestClient (the one used by the SearchFactory) never are. RestClient.close is invoked in both cases, though...

@Sanne Here, everything should be fine now. The build seems to run fine (no timeout) on ci-slave-4, even after I removed my initial commit that raised the number of I/O reactor threads. So I guess the two remaining commits should be enough...

looks good! Testing one last time..

thanks! merged


Make words written in kana show up

A big improvement to #24: I added dictionary entries that will be found when looking up a word written in kana. I think this isn't an ideal solution (I made this mostly to use personally as a stop gap) but I made the PR just in case this is the direction you want to go.
Dictionary was created by exporting the previous version to CSV (delimiter |) and running this python script to generate a new CSV to import back into the database:
output = []
for row in open("export.csv", encoding="utf8").readlines():
    fields = row.strip().split("|")
    fields[1] = str(len(output) + 1)
    output.append("|".join(fields))
    for reading in fields[7].split(","):
        if len(reading) > 0:
            output.append(f"{fields[0]}|{len(output) + 1}|{reading.strip()}|{fields[3]}|{fields[4]}|0|{fields[6]}|{fields[2]}")

open("import.csv", "w", encoding="utf8").write("\n".join(output))

Whoops, looks like something went wrong while uploading the new dictionary.


/bank notsac not working

🐛 Bug Report
Every time bank filter not sacrificed is run it returns the interaction failed

Still works on +b --notsac

🐛 Bug Report
Every time bank filter not sacrificed is run it returns the interaction failed

Still works on +b --notsac

I'm talking about the existing choice not sacrificed at the top of the list

Also tested using --notsac and I get the same error

Also tested using --notsac and I get the same error

it should work now. doing /. I just did it and without adding the —

I think he fixed it

https://user-images.githubusercontent.com/90441459/159126702-808e59b1-3b28-4391-94df-292da72ed4fc.mp4

Still not working...
https://user-images.githubusercontent.com/12814878/159126962-c619b18b-ac82-47b2-a3ee-61bee4ce1f89.mp4

@LuxrayElite are you by chance on birdbot server?

Still not working...
I'm assuming its due to the size of my sacrificed bank that its timing out before it can do all the comparisons
https://user-images.githubusercontent.com/12814878/159126962-c619b18b-ac82-47b2-a3ee-61bee4ce1f89.mp4

try this
copy and paste
+rp checkbank —fix

Still not working, and no I'm not in birdbot server

Still not working, and no I'm not in birdbot server

I believe the skyra command is .servers on main server in old school not channel
if you don't mind (I'm banned from main lol) could you join birdbot one (it had the green avatar) and we can figure this out

Tested with two other users on +lb uniquesac
7th place sean (1316) got an error on performing command
8th place ely josh (1071) was able to perform /bank filter:not sacrificed and get an image returned
image is elyjosh

Bump.
May also be erroring in the new patreon tools commands as I couldn't run /tools patreon sacrificedbank in testing
No longer a patreon so can't test


Set phase for guide editions to 'alpha' by default

This field was first introduced because it's a required field by default in
govuk-content-schemas. It has now become clear that we'll only use it to
indicate to the front-end application whether it should display an alpha/beta
banner. The banner would always be the same across all Service Manual content
so there is no need to display it in the UI. I've set it to 'alpha' initially,
once we decide to migrate to beta we'll need to do it with all persisted guides
locally as well as migrating published guides via publishing-api.
As a part of this effort https://github.com/alphagov/government-frontend/pull/65 will need to be updated to respect the phase field value.

Is there any reason why we're not testing that the default is set when creating editions?

@KushalP I've added a unit test and rebased


My update docs

Hi @justasojourner,
I was able to add my changes on top of yours (after merging yours with mine) by directly editing your latest commit while being diff'd against my last changes.   The merge gave me the choice to override my changes with yours wherever a conflict arose.
Now I have a branch, named update_docs (both on my local machine and my github repository), completely 'synced' with (actually tracking) yours,
Similarly, I also have a new branch, named my_update_docs, stemming from your latest commit but with my latest changes added.
I've also closed my previous pull request.
HTH

As you wish.  But it's incorrect from an academic standpoint.
https://awelu.srv.lu.se/grammar-and-words/punctuation/comma/#:~:text=Use either a comma or,%2C pans%2C and warm clothing
.
On Sun, 14 Feb 2021 at 22:13, justasojourner<EMAIL_ADDRESS>wrote:

@justasojourner commented on this pull request.
In README.md
https://github.com/justasojourner/string_grouper/pull/3#discussion_r575865357
:

 `[foooo, bar, new]`

group_similar_strings(strings_to_group: pandas.Series, **kwargs) -> pandas.Series:
Takes a single series of strings and groups these together by picking a single string in each group of similar strings, and return this as output.

For example the input series: [foooo, foooob, bar] will return [foooo, foooo, bar]. Here foooo and foooob are grouped together into group foooo because they are found to be similar.

For example, the input series: [foooo, foooob, bar] will return [foooo, foooo, bar]. Here foooo and foooob are grouped together into group foooo because they are found to be similar.

comma not needed
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/justasojourner/string_grouper/pull/3#pullrequestreview-590084759,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASWQOUNGZERBJMSQ67T323TS7A4H7ANCNFSM4XTNSWCQ
.


No review needed.


docs: Update misc. broken links

Oops, just saw https://github.com/bank-vaults/bank-vaults.dev/pull/118

Oops, just saw #118

IMHO, we can merge these for the time being, and then work on the larger improvements of https://github.com/bank-vaults/bank-vaults.dev/pull/118. The broken links on our primary documentation reduce the developers' trust in the product.

Makes sense, thanks!

Fixes https://github.com/bank-vaults/bank-vaults.dev/issues/117


Stickiness is ignored with isWholeLine for DeltaDecorationOptions

monaco-editor version: 0.13.0
Browser: Edge
OS: Win 10 16299
Steps or JS usage snippet reproducing the issue:
If I setup two decorations (from the playground example):
var decorations = editor.deltaDecorations([], [
	{ range: new monaco.Range(5,1,5,10), options: { isWholeLine: true, inlineClassName: 'myInlineDecoration', stickiness: 1 }},
	{ range: new monaco.Range(7,1,7,50), options: { inlineClassName: 'myInlineDecoration', stickiness: 1 }},
]);

They behave differently with respect to how the decoration expands around the decoration.  It seems like isWholeLine overrides the stickiness setting, as I was expecting in the first case for the decoration not to continue when I started adding to the line.
Is this expected?  Otherwise it should be called out in the documentation.

Yes, this is expected.
The range + stickiness are the ones that drive typing and growing behaviour.
isWholeLine is only a rendering-time flag for the className option. In conjuction with inlineClassName, isWholeLine doesn't do anything AFAICT.


Finished git exercise

I believe I caught all the errors in the Readme!

Nice work - i'm going to close this PR so others can complete the assignment.


Blocker: Cannot use multiple StyleRoots

I have an NPM react module that at its entry point instantiates the StyleRoot. I wanted to use this module in another project that uses Radium, but the two conflict with one another. In the project that uses my module, if I try to create a StyleRoot it breaks the context of the modules elements. Is there a way we can add a key to the StyleRoot to have the entities work alongside or is there a different solution.
Failed Context Types: Invalid context `_radiumStyleKeeper` of type `StyleKeeper` supplied to `ThemeProvider`, expected instance of `StyleKeeper`.

The project in question is located here.

I got the same issue when using a small component-library I built using Radium and using that library in another project. I did not have multiple StyleRoots but instead only one StyleRoot in my other project and no StyleRoots in the component-library (since it only exported components).
The solution that seemed to work for me was to add Radium as a peerDependency in my component-library instead of a normal dependency.

@Aktof the issue is that you have 2 different versions of Radium in your frontend bundle. So the React.PropTypes.instanceOf(Radium.StyleKeeper) check doesn't work because you have Radium1.StyleKeeper and Radium2.StyleKeeper which are in different locations in memory
If you do as @Cottin says and make Radium a peerDependency of react-mux, then anything that depends on react-mux will have to explicitly list Radium as a dependency. Once you've done this, you'll only have 1 Radium in memory and the warnings will disappear.

I've run into a similar problem:
I have 2 repos - one is a web app and one is a component library. The component library uses Radium and exports a bundled (webpack+babel) file. The web app also uses Radium, so when I go to render one of the components from my component library from within my webapp I get the same error:
Failed Context Types: Invalid context `_radiumStyleKeeper` of type `StyleKeeper` supplied to `MyComponent`, expected instance of `StyleKeeper`. Check the render method of `FooBar`.

I imagine peerDependencies doesn't solve this problem since I'm bundling the component library beforehand and will have a different instance of Radium. Any thoughts?

@amavisca why would you ever want to ship two copies of Radium down to the end user? It would be very wasteful, so I'm not sure why we'd want to encourage that by making StyleRoot duck-typed.

@ianobermiller I don't want to be shipping two copies down to the end user. Looks like I can take advantage of webpack externals to solve my issue. Thanks.

I've running into the same exact issue, as I've been building a component library and when importing those components within another project (using Radium, etc.), I get the error:
warning.js:44Warning: Failed Context Types: Invalid context `_radiumStyleKeeper` of type `StyleKeeper` supplied to `t`, expected instance of `e`.

@FarhadG : https://github.com/FormidableLabs/radium/issues/575#issuecomment-184462379

Thanks for the response, @tptee. I already tried making radium a peer dependency inside of the component library's package.json as follows:
  "peerDependencies": {
    "radium": "0.17.1"
  },

and when I continue with the approach of importing this component into another project, I get the same error. I removed the the Styleroot from these module components and having that instantiated within the projects that use these modules and still no luck... any thoughts?

Thanks for the response, @tptee, however, I continue to get the same warning:
warning.js:36Warning: Failed context type: Invalid context `_radiumStyleKeeper` of type `StyleKeeper` supplied to `Component`

I have a sample-ui-library that uses radium and here's a sample package.json:
  "dependencies": {
    "radium": "0.18.1",
    "react": "~15.2.1",
    "react-dom": "^15.3.1",
  },
  "peerDependencies": {
    "radium": "0.18.1"
  },

and my main project in a separate repo with the following sample package.json:
  "dependencies": {
    "sample-ui-library": "0.5",
    "radium": "0.18.1"
  },

Still getting the same warning, unless I'm missing something. Thanks in advance for your suggestions.

I'll join the choir here. Same problem

I second this!
The same problem pops up in our project which have a common npm linked component library which only specifies radium as a peer dependency. The main project specifies radium as a dependency and both projects contains the exact same version of radium (0.18.1).

I third this!
Also, using Radium 0.18.1, listed as a peerDependency in our UI library, and get the same error message when importing into a project:
Warning: Failed context type: Invalid undefined `_radiumStyleKeeper` of type `StyleKeeper` supplied to `PaginationWidget`, expected instance of `StyleKeeper`.

Fixed! Upon further inspection, I found that listing Radium as a peerDependency wasn't enough. Because I had Radium installed in my library project, for development purposes, even though it was only listed as a peerDependency, webpack was still bundling it, thus I still had two copies of Radium in projects that imported it (see earlier comments in the thread about that). If I removed Radium from my project's node_modules before building it, I got errors. I found this also to be true with React.
The fix: In addition to listing Radium and React as peerDependencies in package.json, I also had to list them both as externals in my webpack config.

@seantcoyote Could you give an example of how to set that up please?
All the documentation I can find on Webpack externals is about injecting external globals into the webpack module loader cache

@Munter From https://webpack.github.io/docs/library-and-externals.html:
"externals allows you to specify dependencies for your library that are not resolved by webpack, but become dependencies of the output. This means they are imported from the environment during runtime."
 Instead they become dependencies for whatever project consumes your library. Then you don't end up with multiple copies of react, react-dom or radium in your end product, and thus none of the ugly Failed context type errors.

@seantcoyote Ah. I don't do a webpack build of my library at all. I only babel transform the source files into browser compatible versions and consume those on my app. So externals only makes sense in a webpack build in the library itself?

Ok, I figured out how to fix this problem.
This bug happens because multiple instances of Radium get included in the webpack build, one from the parent and one from the library. Radium has a proptype check that compares instances instead of properties, which means that the proptype check fails when Radium instance 1 checks props for components that use Radium instance 2.
I solved it by adding new configuration on the parent projects webpack config:
resolve: {
  alias: {
    radium: path.join(__dirname, 'node_modules', 'radium')
  }
}

The above configuration forces webpack to resolve any reference to the Radium module to the same instance, thus solving the instance comparison problem, but also reducing the bundle size, since you only ever need Radium in there once anyway.
I'm closing my #845, since I found a bug in it, and the manual deduplication configuration is preferable over bundling multiple Radium copies.

@ryan-roemer do we want to circle back to this one?


Create page with 'Summit Editor' rules of engagement and email Participants that need support

http://localhost:4000/Logistics/Participants-need-support.html

Done http://owaspsummit.org/Logistics/Summit-Editor.html


Create 0187-repeated-dna-sequences.js

Added a solution for repeated-dna-sequences in JS.
File(s) Added: 0187-repeated-dna-sequences.js
Language(s) Used: JavaScript
Submission URL: https://leetcode.com/problems/repeated-dna-sequences/submissions/984603175/

Fix conflict

Hey @aakhtar3 there seems to be added code to mine. I didn't write it.  Do you want me to keep this code in the file?
var findRepeatedDnaSequences = function (s) {
const seen = new Set();
const res = new Set();
const arr = Array.from(s);
for (let l = 0; l < arr.length - 9; l++) {
    const sequence = s.slice(l, l + 10);

    if (seen.has(sequence)) {
        res.add(sequence);
    } else {
        seen.add(sequence);
    }
}

return Array.from(res);

};

Hey @aakhtar3, this is just a kind reminder. Let me know what should I do with the additional added code.

You can add both solutions

Oh, ok I'll do that.

The conflict is resolved.


[release/1.4] CI: fix "ls: cannot access '/etc/cni/net.d': Permission denied"

Cherry-pick #5078

LGTM


Unable to create a package of the app

Version
Emulator 4.4.x
Windows 10
Describe the bug
Right now, when we are testing the solution for the issue # 1136 we want to package the app on master. However, running the commands for that is throwing an error that we do not find in older branches.
To Reproduce
Steps to reproduce the behavior:

Checkout master
Build the app from source
Package the source: cd packages/app/main & npm run dist -- --win
You will get the error Get $%7Benv.ELECTRON_MIRROR%7D4.1.1/electron-v4.1.1-win32-ia32.zip: unsupported protocol scheme

Expected behavior
Create the packaged version of the current local state of the aplication
Screenshots
Screenshot of the full error:

Have you tried running npm run dist in /packages/app/main?

Oh, I actually know what this is. I can fix this.

Actually, after looking at this, I'm not sure what's causing this. I thought that maybe the environment variable for the electron mirror was accidentally set somewhere, but that's not the case.
It looks like electron-builder is trying to use the correct electron mirror, but it is trying parse the {env.ELECTRON_MIRROR} from main's package.json, instead of seeing that it is undefined and defaulting to the standard mirror.
Can you type set in your terminal and see if the ELECTRON_MIRROR is somehow set? If so, I would try and clear it. Also, I'm not sure this will make a difference, but try what Justin suggested, and run npm run dist instead of calling electron-builder directly.

Hi @tonyanziano , we checked our environment and the {env.ELECTRON_MIRROR} was not declared. We also ran some tests and noticed that the variable in the package.json is returning the textual name of the variable when it's not declared, so it only works when {env.ELECTRON_MIRROR} has been declared and has a value.
We were able to make it work by removing the electron download mirror. We believe this should be removed. If you agree we can make a PR with this change.

Hey @denscollo,
I'll have to check and see if removing the download mirror from the package.json would have side effects in the packaging process, because it is currently used by the build process to download a custom, internal build of Electron from a Microsoft server.


feat(install): unify setup.py, requirements.in, pip

This allows populating setup.py's 'install_requires' directly from 'requirements.in'

setup.py:

read 'requirements.in' instead of 'requirements.txt'
fix requirements read to ignore '@'
add upstream pytorch repo to "dependency_links"

requirements.in:

append "name @" to git packages
fix torch repo URL -> 'https://download.pytorch.org/whl/torch_stable.html'

ALso tweaked some logging and formatting here and there
Signed-off-by: Ben Alkov<EMAIL_ADDRESS>

@reviewers: Interesting, important: https://github.com/pypa/setuptools/issues/1983#issuecomment-584130062
TL;DR - from the setuptools maintainers:

Direct invocations of setup.py install are not the right thing to do, despite the fact that there is a lot of misleading documentation out there indicating that it is.

Testing now...


monaoc.editor.setTheme, bakcground in rules doesn't work

monaco.editor.setTheme('custom-theme', {

    base: 'vs',
    inherit: true,
    rules: [
    { token: 'unsupport.character', foreground: '#FF5050' , background: '#FF9B00'}
    ]
})

of course i have make the rule of 'unsupport.character' by 'setMonarchTokensProvider'
the foreground work, but the background do not work. i check the css, and it just set the color without background.
and i check the source code
is it a bug? or i miss something?

Let's track in #586


[Add]

Details
We can add Search Bar to find buttons, I am Adding Sample Search Bar
Screenshots

Type of Contribution

[ ] Update to an existing Animated Button
[ ] Adding a new Button
[ ] Resolving a bug
[X] Proposal to the Repository
[ ] Changes related to documentation or README.md
[X] Other Changes

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue
[X] I am a GSSoC'23 contributor

We're not planning this


Integration tests fail with sendFramesToEngine error

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
We have a rather big application, and trying to add integration tests to it.
The simple test we have runs, but reports failure with
The following assertion was thrown while executing callbacks for FrameTiming:
'package:flutter/src/widgets/binding.dart': Failed assertion: line 881 pos 16: 'sendFramesToEngine':
is not true.

It happens even though tests seems to be running to the end successfully
Application uses many plugins, notably Everything from firebase.
We also use native splash screen.
This seems to be the bug reported  here
Expected results
I expect the test to report success.
Actual results
══╡ EXCEPTION CAUGHT BY FLUTTER FRAMEWORK ╞═════════════════════════════════════════════════════════
The following assertion was thrown while executing callbacks for FrameTiming:
'package:flutter/src/widgets/binding.dart': Failed assertion: line 881 pos 16: 'sendFramesToEngine':
is not true.
Code sample
Test Case

void main() async {
  final binding = IntegrationTestWidgetsFlutterBinding.ensureInitialized();

  binding.framePolicy = LiveTestWidgetsFlutterBindingFramePolicy.fullyLive;

  group('end-to-end test', () {
    testWidgets('Test',
            (tester) async {
          await application.main();
          await tester.pumpAndSettle(Duration(seconds: 20));

          // Verify the counter starts at 0.
          final Finder finder = find.text('Skip');
          expect(finder, findsOneWidget);
          await tester.tap(finder);
          await tester.pumpAndSettle();

        });
  });
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
══╡ EXCEPTION CAUGHT BY FLUTTER FRAMEWORK ╞═════════════════════════════════════════════════════════
The following assertion was thrown while executing callbacks for FrameTiming:
'package:flutter/src/widgets/binding.dart': Failed assertion: line 881 pos 16: 'sendFramesToEngine':
is not true.

Either the assertion indicates an error in the framework itself, or we should provide substantially
more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
  https://github.com/flutter/flutter/issues/new?template=2_bug.md

When the exception was thrown, this was the stack:
#2      WidgetsBinding.drawFrame.<anonymous closure> (package:flutter/src/widgets/binding.dart:881:16)
#3      SchedulerBinding._executeTimingsCallbacks (package:flutter/src/scheduler/binding.dart:329:19)
#7      _invoke1 (dart:ui/hooks.dart:160:10)
#8      PlatformDispatcher._reportTimings (dart:ui/platform_dispatcher.dart:555:5)
#9      _reportTimings (dart:ui/hooks.dart:107:31)
(elided 5 frames from class _AssertionError and dart:async)

The TimingsCallback that gets executed was:
  Closure: (List<FrameTiming>) => void
════════════════════════════════════════════════════════════════════════════════════════════════════

Test failed. See exception logs above.
The test description was: Test

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.10.0, on macOS 13.4 22F66 darwin-arm64, locale en-CA)
    • Flutter version 3.10.0 on channel stable at /opt/homebrew/Caskroom/flutter/3.10.0/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 84a1e904f4 (2 weeks ago), 2023-05-09 07:41:44 -0700
    • Engine revision d44b5a94c9
    • Dart version 3.0.0
    • DevTools version 2.23.1

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at /Users/abizhanzadeh/Library/Android/sdk
    • Platform android-33, build-tools 33.0.2
    • ANDROID_SDK_ROOT = /Users/abizhanzadeh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1.1)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 73.0.4
    • Dart plugin version 231.8770.15

[✓] VS Code (version 1.78.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.64.0

[✓] Connected device (3 available)
    • Pixel 3a XL (mobile) • 94EAX0DTAC • android-arm64  • Android 12 (API 32)
    • macOS (desktop)      • macos      • darwin-arm64   • macOS 13.4 22F66 darwin-arm64
    • Chrome (web)         • chrome     • web-javascript • Google Chrome 113.0.5672.126

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Thanks for filing this issue. Closing this as duplicate as it seems to be a similar issue to #89651. Kindly follow up with this issue for updates.


mypy-poetry

pipenv substituted by poetry
mypy checker added

Codecov Report

Merging #9 (1d8c43e) into dev (fa791ce) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev       #9   +/-   ##
=======================================
  Coverage   99.21%   99.22%
=======================================
  Files           3        3
  Lines         254      257    +3
=======================================
+ Hits          252      255    +3
  Misses          2        2

Flag
Coverage Δ

unittests
99.22% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crontools/__init__.py
100.00% <100.00%> (ø)

crontools/crontab.py
99.18% <100.00%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa791ce...1d8c43e. Read the comment docs.


fix: :bug: Set the backgroundSize value to "auto" for NativeImageBackground

Set the backgroundSize value to "auto" for NativeImageBackground so that images can be stretched by default
ref #20

The default backgroundSize should be "cover" not "auto"


NEXT: Improve the default SVG images for the Ratings component

Following our recent integration of Zag.js, the Ratings component has been updated to embed default star icons using SVG images. Lucide does not provide an adequate icon for half stars, so we've implemented placeholders for now. These images should be reviewed to ensure the display is high quality and consistent.

Just accidentally I found the same issue for my project. Can we create a ticket on Lucide project?

Hmm but seems like it's here https://github.com/lucide-icons/lucide/pull/180 but in my case I expected filled star.

@stalkerg Lucide updates fairly often and this post was created back in August, so I'm not surprised if they've update since then. We may be able to use their version as a foundation for our embedded SVG, as long as their license allows for this. Otherwise I don't mind drawing some custom art.

but in my case I expected filled star

If I recall correctly you can use fill and stroke independently for their icons.

Did a quick check, they use the ISC License which should suffice for this purpose:

Permission to use, copy, modify, and/or distribute this software for any purpose with or without fee is hereby granted, provided that the above copyright notice and this permission notice appear in all copies.

We can likely provide attributes as a link within the SVG code.

I was able to manipulate the SVG code directly to come up with something that should work.


#22490 Add double-dash single-line comments for Snowflake dialect

Double-dash comments should be colored with grey for Snowflake

Verified


chat bubble icon in sidebar?

^ this to me says something like "logs"

^ versus something like this means comments

Hello @aiqc, Thank you for the issue!
We have plans of adding a logo that looks something like this

I'll add this issue in our todo section for our roadmap!

Addressed by PR #95

Addressed by PR #95


chore: upgrade major dependencies

Proposed change
This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence
Type
Update
Pending

@capacitor/browser
^5.0.0 -> ^6.0.0

peerDependencies
major

@capacitor/browser
^5.0.0 -> ^6.0.0

devDependencies
major

@capacitor/core (source)
^5.0.0 -> ^6.0.0

peerDependencies
major

@capacitor/core (source)
^5.0.0 -> ^6.0.0

devDependencies
major

@capacitor/device
^5.0.0 -> ^6.0.0

peerDependencies
major

@capacitor/device
^5.0.0 -> ^6.0.0

devDependencies
major

@capacitor/preferences
^5.0.0 -> ^6.0.0

peerDependencies
major

@capacitor/preferences
^5.0.0 -> ^6.0.0

devDependencies
major

@commitlint/cli (source)
^18.0.0 -> ^19.0.0

devDependencies
major

@commitlint/config-conventional (source)
^18.0.0 -> ^19.0.0

devDependencies
major

@eslint/eslintrc
^2.1.4 -> ^3.0.0

devDependencies
major

@storybook/angular (source)
^7.5.3 -> ^8.0.0

peerDependencies
major

@storybook/angular (source)
^7.6.16 -> ^8.0.0

devDependencies
major

@storybook/components (source)
^7.5.3 -> ^8.0.0

peerDependencies
major

@storybook/components (source)
^7.6.16 -> ^8.0.0

devDependencies
major

@stylistic/eslint-plugin-ts (source)
^1.5.4 -> ^2.0.0

devDependencies
major

@stylistic/eslint-plugin-ts (source)
^1.5.4 -> ^2.0.0

peerDependencies
major

actions/checkout
v3.6.0 -> v4.1.7

action
major

actions/configure-pages
v4.0.0 -> v5.0.0

action
major

archiver
^6.0.1 -> ^7.0.0

devDependencies
major

azure-devops-node-api
^12.0.0 -> ^13.0.0

dependencies
major
14.0.0

commit-and-tag-version
^9.5.0 -> ^12.0.0

devDependencies
major

eslint-plugin-jest
~27.9.0 -> ~28.6.0

devDependencies
major

eslint-plugin-jest
^27.2.1 -> ^28.0.0

peerDependencies
major

eslint-plugin-unicorn
^51.0.1 -> ^54.0.0

devDependencies
major

eslint-plugin-unicorn
^51.0.0 -> ^54.0.0

peerDependencies
major

github/codeql-action
v2.25.10 -> v3.25.10

action
major

jsonpath-plus
^8.0.0 -> ^9.0.0

peerDependencies
major

jsonpath-plus
^8.0.0 -> ^9.0.0

devDependencies
major

ngx-highlightjs
^10.0.0 -> ^12.0.0

devDependencies
major

ngx-highlightjs
^10.0.0 -> ^12.0.0

dependencies
major

smartlook-client
^8.0.0 -> ^9.0.0

peerDependencies
major

smartlook-client
^8.0.0 -> ^9.0.0

devDependencies
major

tar
^6.1.12 -> ^7.0.0

dependencies
major

uuid
^9.0.0 -> ^10.0.0

dependencies
major

uuid
^9.0.0 -> ^10.0.0

devDependencies
major

org.jetbrains.kotlin.jvm (source)
1.9.24 -> 2.0.0

plugin
major

Related issues

:bug: Fixes #(issue)
:rocket: Feature #(issue)

I think you still have @angular/localize to align:

I think you still have @angular/localize to align:

@angular/localize and @angular-devkit/build-angular have been upgraded but not @design-factory/design-factory

We will have these warnings until design-factory upgrade to Angular18


Zig support for repo map

I've been working on a Zig project and wanted to try out the @codebase repository map support, so I added Zig support for the new repomap feature. Hacked it together and it appears to be functioning correctly. This might be useful when enhancing the repository map implementation.

Hello, the repo-map refactoring is complete: https://github.com/yetone/avante.nvim/pull/628

#663


Heap delete error when entity goes out of scope

I am running this in a test program:
int main()
{
    dds::domain::DomainParticipant dp1(dds::core::null);
    {
        dds::domain::DomainParticipant dp2(0); //Creates a domain participant on domain 0

        dp1 = dp2; //Copies reference to dp2 into dp1, both references now point to the same class instance
    }

    std::cin.get();
}

However as the program exits, after a button is pressed, a break point is hit on line 676 of memory.
// CLASS TEMPLATE _Ref_count
template <class _Ty>
class _Ref_count : public _Ref_count_base { // handle reference counting for pointer without deleter
public:
    explicit _Ref_count(_Ty* _Px) : _Ref_count_base(), _Ptr(_Px) {}

private:
    virtual void _Destroy() noexcept override { // destroy managed resource
        delete _Ptr; <---- This Line
    }

    virtual void _Delete_this() noexcept override { // destroy self
        delete this;
    }

    _Ty* _Ptr;
};

The exception "A heap has been corrupted" is thrown when trying to continue execution.
I built from source using the latest CYGWin on windows 10.

Hi UHSL-Marcus,
I tried reproducing this issue but i didn't get any such error.
With best regards,
Vivek


move Tan, Tanh, Trunc, Cot, Round, iszero functions to datafusion-functions crate

Is your feature request related to a problem or challenge?
As part of https://github.com/apache/arrow-datafusion/issues/9285 move the Tan, Tanh, Trunc, Cot, Round, iszero functions to the new datafusion-functions/math crate in the new structure.
Describe the solution you'd like
Functions are migrated to the new crate and use the new patterns as described in https://github.com/apache/arrow-datafusion/issues/9286 & https://github.com/apache/arrow-datafusion/pull/9216
Describe alternatives you've considered
No response
Additional context
No response

take


Unstructured Sedna Lifelong Learning Architecture

In this PR, unstructured Sedna lifelong learning architecture is achieved.  It surpports the following new features.

Unstructured lifelong learning
Unseen task detection
Online unseen task processing
Offline unseen task training

My comment is addressed in the current version.
/lgtm

For commit history of Sedna repository more readable and cleaner, I suggest to squash the commits by git rebase -i kubeedge/main, to keep the number of commit to 3~5, and to make the commit message more concrete, instead of "update this... imporve that"

/lgtm

/approve


buble, buble-loader. you are silly.

@yyx990803 , you are very nice man but also a very silly one. what else make you think of buble better babel ? I'm really can't understanding. Money or your ambition? As for me , using buble surely make me lose time and energy ! I dont want to see you !


Issue 417 - Added test for fs.promises.rename to rename existing directory

Added test for fs.promises.rename() to rename a directory which already exists.
Link to issue
Any feedback appreciated!

@humphd I've added some new changes, ready to be reviewed

Thanks @bblarney, merged.


Add compile time flag for disabling CV screen

This would be handy for those of us who only want the merged screen

Good idea. On a similar topic I have been thinking we could use some kind of ./configure like step that would set the font, font colors and desired functions. With this config a git pull && make would build the latest and greatest according to one's configuration.

I did some ugly hacks just to remove the CV/CC indicators from the screen since the use-case for my builds are for non-tech users and not having those telltales means less questions to have to answer ;)
I'm also thinking about making the default screen show the set-value and not the actual dac value.  I think when enable-mode is off, then its the set-value that is shown for voltage, but I prefer to always see that  has there been any thought to an option to show it that way?


Move @types/js-yaml to normal dependencies

Description
This PR moves the @types/js-yaml package into a normal dependency in the @astrojs/starlight package.
Because we export TypeScript files directly in the exports field in a package.json file of the @astrojs/starlight package, we need to include all dependencies' @types/* packages in normal dependencies. Otherwise, we get following errors on type check of, for example, astro.config.ts even with skipLibCheck: true in tsconfig.json:
node_modules/@astrojs/starlight/utils/translations-fs.ts:4:18 - error TS7016: Could not find a declaration file for module 'js-yaml'. '/Users/raviqqe/src/github.com/raviqqe/stak/doc/node_modules/js-yaml/dist/js-yaml.mjs' implicitly has an 'any' type.
  Try `npm i --save-dev @types/js-yaml` if it exists or add a new declaration (.d.ts) file containing `declare module 'js-yaml';`

4 import yaml from 'js-yaml';

Hello! Thank you for opening your first PR to Starlight! ✨
Here’s what will happen next:

Our GitHub bots will run to check your changes.
If they spot any issues you will see some error messages on this PR.
Don’t hesitate to ask any questions if you’re not sure what these mean!

In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

One or more of our maintainers will take a look and may ask you to make changes.
We try to be responsive, but don’t worry if this takes a few days.


Bump black from 22.1.0 to 22.3.0

Codecov Report

Merging #144 (3a4bd88) into main (b9f1c88) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #144   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines           22        22
=========================================
  Hits            22        22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9f1c88...3a4bd88. Read the comment docs.


Add a way to fail the process on fail!

 Issue by larsbergstrom
Friday Feb 28, 2014 at 20:41 GMT
For earlier discussion, see https://github.com/rust-lang/rust/issues/12629
This issue was labelled with:  in the Rust repository

It would be nice to have something like an environment variable or a runtime flag we could set that would cause calls to fail! to unconditionally terminate the entire process.
When we are running reference tests and content tests in Servo, we often want failure within a task to take down the whole process, both because our recovery could cause a "false" test success and because our failure recovery (currently) often results in a hung process.
This feature would also be very nice for easily getting a good stack backtrace from an intermittent failure - we can just do ulimit -c unlimited, turn on this flag, and then run the test until a core file is emitted.

This of course is panic! now.


A color issue

Hello blueskythlikesclouds:
Your tools are really amazing. Thanks for your work (-0-)/
I've found some issue when I trying to replace a texture, the tool will automatically reduce every RGB value to the nearest multiple of eight. for example (240,220,200) will change to (232,216,192).
39

Could you specify the texture compression you're saving into? e.g. DXT5, RGB, etc
As it's likely to be the compression

What format are you trying to replace the texture with? PNG?
It'd help if you also mentioned what texture you are trying to replace.

yeah i think that's a compression issue. thanks


minor README file changes to fit more redot design and remove unnecessary godot info

improving redot engine readme with some minor changes like logo and some community links

This is just some minor changes and I know it still needs to be worked on

i dont why this pull request was even mentioned as spam


fix: fix computed type

If not all models define computed properties,  the state returned by useModel  would miss computed properties.
For example:
const modelA = model<StateA>('modelA').define({
  state: {
    a: 1,
  },
  computed: {
    double(s) {
      return s.a + 1;
    },
  },
});

const modelB = model<StateB>('modelB').define({
  state: {
    b: '10',
  }
});

const [state] = useModel(modelA, modelB);

state.double;     // would throw ts error

This PR would fix this issue.

Codecov Report
Base: 83.66% // Head: 83.66% // No change to project coverage :thumbsup:

Coverage data is based on head (73af359) compared to base (1432ec1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   83.66%   83.66%
=======================================
  Files          32       32
  Lines         967      967
  Branches      213      213
=======================================
  Hits          809      809
  Misses        157      157
  Partials        1        1

Impacted Files
Coverage Δ

packages/store/src/__tsd__/computed.tsd.ts
0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


PSA for kube-aws users, skip CoreOS 1745.3.1 and 1745.4.0, go directly to 1745.5.0

CoreOS 1745.3.1 and 1745.4.0 include a networkd bug that causes problems for clusters with mixed instance types (e.g. T2 and M3/4/5). This is fixed in 1745.5.0 (stable).
All the 'current' AWS instance types support jumbo frames (MTU = 9001). This is set via DHCP, however the networkd in these CoreOS versions fails to do that. This leaves the instances with their default MTU. While T2 instance support MTU=9001 they appear to default to MTU=1500. This leaves you with different nodes in the cluster with different MTUs.
Clients of TCP load balancers will get PMTU errors where they will think the PMTU is 8951 or 1500 when it is actually 1450. You'll tend to get MTU hangs or disconnections if connections heads to T2 worker nodes due to the incorrect MTU.
If you have T2 nodes for your control plane, if you upgrade to this versions (1745.3.1 and 1745.4.0) you'll likely see all your workers go to 'NotReady' and appear to stop reporting state to controllers via the API load balancer. In reality the controller MTU has suddenly gone from 9001 to 1500, and it takes a while for the load balancer and worker nodes to work this out. In my experience the workers should recover in about 10 minutes.

Issues with container Linux releases happen quite often. I think we should have a blacklist to avoid others incur in the same problems.

To be fair to Container Linux, the last two issues affecting kube-aws have both been 'sabotage' by upstream projects, in this case systemd, and in the previous (several!) cases by docker.
I do think kube-aws should not default to automatically upgrading instances on any kube-aws update but lock the versions on kube-aws render/up (I think maybe the current 0.10.0 version does that?). Though it could warn users a new version is available.

@whereisaaron yes, you can follow the discussion here: #1209

Update: If you do have clusters with 1745.3.1 and 1745.4.0 and T2 instances (or any other instance type that defaults to MTU=1500) I can report that you can upgrade the control plane to 1745.5.0 successfully. The etcd cluster does upgrade and stay healthy. However, you can expect all the API servers on the controllers to go down for ~20 minutes until the etcd upgrade completes and new controller instances take over and the API load balancer adapts to the new MTU.
At one stage I thought the new controllers were going to timeout getting started, which with kube-aws 0.9.9 would have rolled back through and undone the successful etcd upgrade 😢  (you can only change instance AMI version for the whole control plane as a monolith with 0.9.9, you can't update the AMI for the controller nodes and etcd nodes separately). So it is not without risk, but it did work, albeit with API server down time.

@whereisaaron @jorge07 I greatly appreciate you for sharing your findings.
Yes, a blacklist would be helpful for users who don't subscribe github issues for kube-aws.
Also, I'm such a perfectonist so that I can't help thinking about improving kube-aws not to be affected by this kind of upstream issues 🤔
Can we systematically postpone the etcd node roll if the apiserver got failed due to it?

@mumoshu this is mostly all good. It was just a bit dicey that the time it took the controllers to accommodate to the MTU change was pretty close to the CF success signal signal timeout.
If the newer version of kube-aws lets us target either etcd or controllers for kube-aws update then this wouldn't have been a (potential) problem to deal with this upstream problem. And in my experience 'kube-aws update' did succeed, despite the upstream problems.


Add an agent-wide shutdown hook

This will be useful for ensuring graceful shutdowns and cleanup when the
agent is integrated with other systems.

OK I'll send a PR to the public repo. Closing this one


eventsources being called multiple times after navigating away and returning

Hi,
I have routing something like this:
/admin/orders
/admin/calendar

And an event source in data:
var data = {
  calendarEventSources: [{
    events (start, end, timezone, callback) {
      HTTP.get(...) // calls callback somewhere in here
    }]
}

This works correctly the first time. Navigating to another route (/admin/orders) and coming back (to /admin/orders) calls the events function twice. This adds on after every navigate, so I end up with 5 entries after 5 page mounts.
Is this the right place for calendarEventSources?

I have solved this issue by passing eventSource in config data
 <full-calendar :config="config"/>
data() {             return { config: { eventSource: [...] } }

I have encountered this issue, moving the eventSources into config worked too... But i do have another issue. If i load the events on the page, and change the page to something else, and go back on the calendar page, the events are duplicated... Any1 encountered this issue?
Thanks


Updating examples to RST comments for docs

Earth-2 MIP Pull Request
Description

Updating all examples to use RST comments, files are a lot uglier but docs look nice now
Also update to include .env file for managing env variables.

Closes: https://github.com/NVIDIA/earth2mip/issues/115
Closes: https://github.com/NVIDIA/earth2mip/issues/114
Checklist

[ ] I am familiar with the Contributing Guidelines.
[ ] New or existing tests cover these changes.
[ ] The documentation is up to date with these changes.
[ ] The CHANGELOG.md is up to date with these changes.
[ ] An issue is linked to this pull request.

Dependencies

/blossom-ci


Inline bpmn in color

Inlining was not properly configured.
Rollup did log a warning, however that warning is easy to miss.

Thanks Nico :)

Can 7.1.1 be pushed to npm? Currently npm install bpmnlint doesn't work, I assume due to this error.
internal/modules/cjs/loader.js:818
  throw err;
  ^
Error: Cannot find module 'bpmn-in-color-moddle/resources/bpmn-in-color.json'
Require stack:
- /usr/lib/node_modules/bpmnlint/node_modules/bpmn-moddle/dist/index.js
- /usr/lib/node_modules/bpmnlint/bin/bpmnlint.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:815:15)
    at Function.Module._load (internal/modules/cjs/loader.js:667:27)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/usr/lib/node_modules/bpmnlint/node_modules/bpmn-moddle/dist/index.js:6:26)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Module.require (internal/modules/cjs/loader.js:887:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/usr/lib/node_modules/bpmnlint/node_modules/bpmn-moddle/dist/index.js',
    '/usr/lib/node_modules/bpmnlint/bin/bpmnlint.js'
  ]
}

Give npm some time. It is likely a caching issue. It works on my end:
> npm info bpmn-moddle

<EMAIL_ADDRESS>| MIT | deps: 3 | versions: 75
A moddle wrapper for BPMN 2.0
https://github.com/bpmn-io/bpmn-moddle#readme

@nikku correct, it works when I install it, just https://www.npmjs.com/package/bpmn-moddle is still displaying an old version.
thanks for the quick fix :)


encoding then decoding fails with certain strings

The following string (from ICU4J 4) cannot be encoded and then decoded:
>>> a = u"[\uAC00 \uB098 \uB2E4 \uB77C \uB9C8 \uBC14  \uC0AC  \uC544 \uC790  \uCC28 \uCE74 \uD0C0 \uD30C \uD558]"
>>> a
'[가 나 다 라 마 바  사  아 자  차 카 타 파 하]'
>>> b = mutf8.encode_modified_utf8(a)
>>> b
b'[\xea\xb0\x80 \xeb\x82\x98 \xeb\x8b\xa4 \xeb\x9d\xbc \xeb\xa7\x88 \xeb\xb0\x94  \xec\x82\xac  \xec\x95\x84 \xec\x9e\x90  \xec\xb0\xa8 \xec\xb9\xb4 \xed\x83\x80 \xed\x8c\x8c \xed\x95\x98]'
>>> mutf8.decode_modified_utf8(b)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
UnicodeDecodeError: 'mutf-8' codec can't decode byte 0xed in position 56: 6-byte codepoint started, but input too short to finish.

As a follow up: encoding works correctly. The result is the same that I see in a Dalvik file. It is decoding that doesn't seem to work correctly.

Thanks for the report @armijnhemel, taking a look.

Found two issues, one in the Python implementation and one in c. Working on the fix.

Some other byte strings that cannot be decoded in case you need more things to test with:
b'Lo/\xed\x80\xad;'
b'Lo/\xed\x82\x91;'
b'Lo/\xed\x9d\x80;'

Sorry for the delay, went on a whale watching tour :)
@armijnhemel - can you give the issue_1 branch a try?

Sorry for the delay, went on a whale watching tour :)

Magnificent animals, so I will allow it ;-)

@armijnhemel - can you give the issue_1 branch a try?

Seems to work on my test cases so far.

Currently passing on everything I can find, so it'll be released tomorrow.

Released as 1.0.4, thanks for reporting.


[SPARK-44401][PYTHON][DOCS] Arrow Python UDF Use Guide

What changes were proposed in this pull request?
Add use guide for Arrow Python UDF.
Why are the changes needed?
Better documentation and usability of Arrow Python UDF.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A.

The exact failed tests are not shown. Let me retrigger the tests.

@HyukjinKwon @itholic would you please review?

Merged to master.


Tags (aka Launch) Server side implementation - missing implementaion guide

Issue in ./help/tags/quick-start/implementation-guides.md
Hi team.
An AEP client is scoping the implementation effort for a server side Launch deployment.
A comprehensive tutorial is available in the Tags tutorials section:

Yet when turning into the implementation guides there is no references to the server side case:

Is that just a missing link to the Launch server side implementation (in this case please add the link) or such documentation is not available at all (in this case I would really kindly ask to include such documentation in the Tags online references)?
Thanks and best regards,
Alberto

Thank you for logging this issue. We will review the documentation and update soon.
Tracking internally: https://jira.corp.adobe.com/browse/PLAT-107431


SAMZA-2685: Add job coordinator which does not do resource management

Feature: Adding a job coordinator which does not do resource management. For Samza on YARN, the ClusterBasedJobCoordinator does resource management. However, for Samza on Kubernetes, it is not necessary to have a job coordinator which does resource management, because Kubernetes controllers can take care of resource management.
Changes:

Added a StaticResourceJobCoordinator which handles responsibilities like job model calculation, communicating job model to workers, monitoring input streams which may cause the job model to change, and startpoint fanout.
Added new abstraction layer CoordinatorCommunication for communication between job coordinator and workers. Before, the only communication option was an HTTP endpoint. The new abstraction layer allows us to start decoupling the coordination from the HTTP endpoint. This PR doesn't expose an option to plug in a custom communication layer yet, but there is an interface to start working off of.

Testing:

Added unit tests
Tested a Samza job using this new coordinator in Kubernetes

API changes (all changes are backwards compatible):

Set the config job.coordinator.use.static.resource.job.coordinator to true in order to use the new coordinator.
Set the config job.coordinator.restart.signal.factory to define how to restart the Samza job when an input stream changes which will change the job model. This plug-in is dependent on where the Samza job is running (e.g. Kubernetes). Currently, there is only a no-op implementation of this restart signal.

Note: This PR reuses components like JobModelHelper, JobCoordinatorMetadataManager, StreamPartitionCountMonitorFactory, and StartpointManager across ClusterBasedJobCoordinator and StaticResourceJobCoordinator. I considered consolidating ClusterBasedJobCoordinator and StaticResourceJobCoordinator even further to share code which encapsulates usage of multiple of the above components, but it's not yet clear how to fit the new and old flows together cleanly. There might be further divergence between the coordinators as we iterate on on StaticResourceJobCoordinator, so I felt it would be easier to leave them more decoupled for now. Also, keeping them decoupled reduces risk that a change will impact the existing ClusterBasedJobCoordinator.

This looks like a significant change, do we want a SEP for it?

@kw2542 That's a good point about having a SEP. Do you think it would be reasonable to get some implementation checked in and tried out in Kubernetes a little more before posting a SEP? I do already have some context to put into a SEP now if you think that would be better.
Does anyone else have thoughts on posting the SEP now vs. later?

This looks like a significant change, do we want a SEP for it?

@kw2542 That's a good point about having a SEP. Do you think it would be reasonable to get some implementation checked in and tried out in Kubernetes a little more before posting a SEP? I do already have some context to put into a SEP now if you think that would be better.
Does anyone else have thoughts on posting the SEP now vs. later?

Synced with @mynameborat about this. We will update the existing SEP-20 for Samza on Kubernetes to include this new job coordination flow.

LGTM

Minor comment. Looks good to me!

There are some test failures. Doesn't seem related to your change although I'd just make sure if that is the case.

Minor comment. Looks good to me!

There are some test failures. Doesn't seem related to your change although I'd just make sure if that is the case.

This error has been happening on some other PRs as well, so it's very unlikely related to this change. It is being handled separately.


Script improvement

Update the python script for generating the string file from swift source.
Now, it supports generating string from multiple inputs. The usage is
similar to the Apple's genstrings tool.
Usage: find /path/to/source -iname "*.swift" | xargs python ./genstrings_swift.py -o ./App/en.lproj/ ./App/Source/LocalizationConstants.swift
Fix the bug in python script for merging the string file. When the string
value contains escaped double quotes, it will be excluded from the string
file. For example, following lines will be striped from the final output
/* String with quotes */
"EscapedQuotes" = ""String with quotes"";

Thank you. We try to look into it this week.


Google Earth integration

Is it possible to add a feature to allow the export of positions as Latitude and Longitude into an KML file to open in Google Earth to create a track?  This was a feature of Marinetraffic.com but they have removed it.  Or even a generic export feature to allow people to extract the data to use in other applications?
Thank you.
Ian

This is a wrong repository. Issue should be here:
https://github.com/tananaev/traccar

Sorry - moved!


Be able to kick-off many conversations

I would like to be able to start the conversation between a bot and a user from the bot's side.
Also, I need to be able to do this for many users.

see here
and no reason you can't simply repeat that process for many users.

Thanks. That's interesting.

You can look at these samples showing how you can proactively create a new conversation with a user that your bot have interacted with before:
C#: https://github.com/Microsoft/BotBuilder-Samples/tree/master/CSharp/core-CreateNewConversation
Node: https://github.com/Microsoft/BotBuilder-Samples/tree/master/Node/core-CreateNewConversation


BUG: "You appear to be offline" shows when I'm online

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Closed computer yesterday.
Opened computer today, I'm online with fast and dependable internet.
Opened NewDot. I think I had quit it yesterday
"You appear to be offline" is showing, LHN not loading and chats are sending

Expected Result:
Should show as online
Actual Result:
Shows I'm offline
Workaround:
Unknown
Platform:

Where is this issue occurring?

Desktop App

Version Number: 1.2.12-2
Reproducible in staging?: Y
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: appear offline .txt
Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/194638279-b10e5e88-29f8-470f-bd1f-15d0289f1385.mov
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665078854089259
View all open jobs on GitHub

@MonilBhavsar , will you see if you're able to reproduce?  We might want to add Needs Reproduction label but, with this happening twice, I'd like to avoid it going into the 'needs repro' abyss and not getting addressed.

I'm not able to reproduce the issue.
May be the app went in inactive state and it is causing the issue.
Thanks for attaching the logs. From the logs, it looks like we tried checking for connection but isInternetReachable stayed false.

Log.js:55 [info] [NetworkConnection] NetInfo state change - {"isInternetReachable":false,"isConnected":false,"type":"none","details":null}
Log.js:55 [info] [NetworkConnection] listenForReconnect called - ""

Added Needs Reproduction label and unassigned ya @MonilBhavsar .   Thanks for checking the logs, not sure what else can/should be done about this now

Seems like pretty edge case. We can track and see if someone else experiences this.
The video where offline status is false on the Login page might be related to this issue. cc @grgia

Hey guys, currently experiencing this as well. Just wanted to let you know, can, later on, help track down what goes wrong. Its across all browser

I think its related to some CORS stuff

I was not able to reproduce. Asked for clarification on next steps in the Slack thread.

I looked for this issue this morning and was again unable to reproduce.
Action Performed:
Closed computer yesterday.
Opened computer today, I'm online with fast and dependable internet.
Opened NewDot on web
Results:
Everything appeared to be working as expected.
@hannojg @kavimuru can you both confirm the testing steps and see if you're still able to reproduce?

Friendly bump here. If we're unable to reproduce this then I suggest we close it out.

Ok I'm going to close this out. Please reopen if you can reproduce.


Error: Object reference not set to an instance of an object.

Hi @XeroDays , experiencing an issue with the following error
Error: Object reference not set to an instance of an object.

Works now

@albusaidyy  Thanks for confirming.


JAWS and NVDA form fields dialogue do not show autocomplete clearly

This issue is from a May 2019 external accessibility audit report.
WCAG Reference:

1.3.1 Info and Relationships (Level A)
Issue ID: DAC_4

Summary
When trying to navigate to the autocomplete using form fields dialogue it is not clear.

While in the form fields dialogue menu (‘insert+f5’), the form element announced only as “No search results.” It was therefore challenging to identify which form element should be selected and what the field related to.
While using NVDA, I found that the field was unlabelled which could mean that users are not aware of what they are interacting with. While using VoiceOver for iPhone and Mac while in context, the autocomplete reads information relating to the number of results, but with the form fields rotor, two separate items are located relating to the results and search information which might not be clear to users.

Screen Shot

This may be resolved by HMRC's work https://github.com/alphagov/accessible-autocomplete/pull/339

Form fields are now visible in overview (NVDA Insert + F7 , rotor in VoiceOver)
(Related to the above) Form fields can now be selected directly using relevant form navigation key (e.g. key 'F' in NVDA)

Will be in the 2.0.0 release :)

Confirmed as fixed in a re-test by DAC on 7th October 2019


Getting Java AbstractMethodError for TracerSpanBuilder.startActive()

Hi Team,
I am new to Jaeger and trying simple Kafka producer tracing. However I am getting an error.
I have attached the snapshot of code/error and gradle dependencies.
Can someone please help with this?

I suggest you start with upgrading to the latest versions. OpenTracing 0.22 is 2.5yrs old

And com.uber.jaeger is not being used anymore. Which tutorial are you following?


catch no email and password when connected...

Hi,
I've easily made some portals with your generator, works great and I obtain good looking portals.
I can also  easily connect to my portals with my smartphone and I can see the server is well running on my flipper zero...when I connect to my fake portals I can't get any emails or passwords received by Flipper.
With the portals you can find with evil portal App it works well ...I receive all infos.
Weeks I'm looking to find the bug but found nothing so that's why I ask... ;-)
If you see something that can help me ...
Best regards,
Alex.

Hi man,
Sorry I haven't been around here a lot last week
I see that you found a fix for this in the other thread?
I'll have a look at it myself in the next days as well :)
Thanks for letting me know and enjoy the script!

Hi FlipieHacks, no worries ;-)
Yes, found a personnal solution, tikering html code from Portal provided with EvilPortalMain...
Let me know if you fix the problem from your generator...and thanks a lot for this script !!


[Feature Request] Add "Edit and Continue" feature for debugging

From @Deathhush on August 12, 2017 6:52
It is handy that you can edit the script while break point is hit and then continue execution from there.
It is especially useful when debugging pandas code which has a high bootstrap cost while importing the pandas module.
Copied from original issue: DonJayamanne/pythonVSCode#1164

Python itself doesn't actually support this use-case.

Python itself doesn't actually support this use-case.

What about reloading modules?

You can't effectively reload modules the way you probably want them to.


Added Better Enums.

:)
For slightly easier review: https://github.com/aantron/better-enums
The docs: http://aantron.github.io/better-enums/

Faraz, this solves a recurrent problem many people have with C++ enums. Here's a small Reddit thread with comments to that effect: reddit
The library tracks and implements the C++17 reflection proposal N4428. It's basically the "state of the art" in avoiding repetitive enum conversion and iteration boilerplate – lookup tables and excessive macros.


Unauthorized (401) when calling /api endpoints using default authentication and b.y.o. function app

Describe the bug
I have set up a Blazor SPA Static Web App and linked an existing functions app where all routes except /.auth/* require an authorized user (see staticwebapp.config.json below). This is not using custom authentication at all--just the default authentication and logging in with an invited/registered AAD user.
Even when authenticated all of my /api endpoints return 401 - Unauthorized.
As a test, I opened up all routes to allow anonymous access, and it started working; however, if I then log in using /.auth/login/aad, once I am authenticated all /api endpoints return 401 - Unauthorized even though all routes should allow anonymous access.
I am using an HTTP client initialized in the following way:
var builder = WebAssemblyHostBuilder.CreateDefault(args);
builder.RootComponents.Add<App>("#app");

var baseAddress = builder.Configuration["API_Prefix"] ?? builder.HostEnvironment.BaseAddress;
builder.Services.AddScoped(_ => new HttpClient { BaseAddress = new Uri(baseAddress) });
builder.Services.AddSingleton<State>();
builder.Services.AddBlazorFluentUI();

await builder.Build().RunAsync();

I have confirmed that all cookies are transmitted (including the static web auth cookies) when I make the get/post calls.
Here's my staticwebapp.config.json:
{
  "navigationFallback": {
    "rewrite": "/index.html",
    "exclude": [
      "/images/*.{png,jpg,gif}",
      "/css/*"
    ]
  },
  "routes": [
    {
      "route": "/.auth/*",
      "allowedRoles": [ "anonymous" ]
    },
    {
      "route": "/*",
      "allowedRoles": [ "authenticated" ],
    }
  ],
  "responseOverrides": {
    "401": {
      "redirect": "/.auth/login/aad",
      "statusCode": 302,
      "exclude":  ["/api/*"]
    }
  }
}

possibly Important note: This app worked yesterday, but does not today, with no new deploys (although now I have tested a ton of iterations on the routes and config).
Expected behavior
I expect that /api endpoints do not return 401 when the user is authenticated.
I expect that /api endpoints are always accessible when anonymous routes are allowed.
Device info (if applicable):

OS: Windows 11
Browser: Edge (Chromium)
Version: 93.0.961.52 (Official build) (64-bit)
Visual Studio 2022
.NET 6.0
Function App v4

Additional context
The project is not public, but I can provide access to anyone investigating this issue. I can also provide the link to the deployed and an invite to the app's auth.

Further detail, I unlinked and completely recreated the functions app then re-linked it but that did not resolve things.
I went to using custom auth (AAD B2C) but that also didn’t resolve things.
One thing I did notice is that the first call to API after a long idle takes a long time to spin up, which I expect from a function app/app service, before it returns the 401. The static assets behind the auth barrier load pretty much instantly.
That tells me that the issue is likely on the side of the linked function app as opposed to whatever handles auth for static assets.

Hi @evandigby, Could you please provide us the static web app name and we can take a look to debug!

Hi, I have seen similar behaviour to this on one of my SWAs. I made a new SWA with the same code that did not use BYOF, but have the same issues.
Navigating to /.auth/login/aad via a nav menu button appears reload the app and in the end shows the familiar "Sorry, there's nothing at this address." from the NotFound element in my CascadingAuthenticationState.
The console in the Chrome dev tools shows a "Cross-Origin Read Blocking (CORB) blocked cross-origin response" warning. In the Elements, I see the also familiar div below, but it is not visible on the page:

        An unhandled error has occurred.
        Reload
🗙

I should also note that the same app works just fine with the SWA CLI.

My issue was due to old PWA files (e.g. service-worker.js) in my wwwroot folder. Removing them prevented this problem.

Thanks for confirming @bmaruyama!
@evandigby - could you please confirm if you are still facing this issue? Our team can help you debug if so. If not, we'd like to close this issue. Thanks!


feat(ZN-390): add abstraction over use navigate and use params

useParams takes generic which is route, for example useParams<'foo/:bar'>(), it throws an error if bar is not defined because it means that given component was rendered at route without expected bar in params. It also infers the type of params from the string, for example:
const { baz, bar } = useParams<'foo/:baz/:bar'>(); // baz: string, bar: string

useNavigate returns a function which infers the type of params from url string, for example:
const navigate = useNavigate();

navigate('foo/:bar', { params: { bar: 'baz' } }); // ts error if you omit the parameters
navigate('foo/:bar', { params: { bar: 'baz' }, replace: true }); // it also preserves types of options object expected by original navigate function

This PR also includes adding extra feature into custom test renderer, now it accepts router configuration as shown in src/app/user/User.test.tsx

looks really good! 😁


'types.SimpleNamespace' object has no attribute '_sentry_hub'

Environment
How do you use Sentry?
Sentry SaaS (sentry.io)
Which SDK and version?
Sentry-sdk v1.5.2
I'm facing the same issue as #1290, but with the latest (v1.5.2) version of Sentry-sdk
This is the public link to the issue:
https://sentry.io/share/issue/0464a5d631244872a70b7afacefa01aa/

I cannot recreate this. This seems to work as expected using:
aiofiles==0.8.0
certifi==2021.10.8
httptools==0.3.0
multidict==5.2.0
sanic==21.12.1
sanic-routing==0.7.2
sentry-sdk==1.5.2
ujson==5.1.0
urllib3==1.26.8
uvloop==0.16.0
websockets==10.1

import sentry_sdk
from sentry_sdk.integrations.sanic import SanicIntegration
from sanic import Sanic, text

sentry_sdk.init(
<EMAIL_ADDRESS>    integrations=[SanicIntegration()],
)

app = Sanic(__name__)

@app.exception(ZeroDivisionError)
async def zero(*_):
    return text("0")

@app.get("/")
async def handler(request):
    1 / 0

app.run(port=9999, debug=True)

I'm continuing this issue as I recently pushed an update on my code that triggered two new similar issues at Sentry.
I'm guessing they are "new issues" because they originate from another part of the code: I certainly have a bug that results in an exception at someplace that triggers Sentry out of place. I'm sharing these here in case it helps figure out where.
Unfortunately, Sentry doesn't provide any more details on the origin of the issue so it's hard for me to understand where the problem originates and to go up the ladder until I identify the problem.

https://sentry.io/share/issue/e429706316b141159ae08ed19547ac08/
https://sentry.io/share/issue/61cd71ddba8f49f2be028cb8aa91b9cc/

One of my guesses is that I do quite some work once the request is finished (I commit to the database, run some asynchronous tasks (via Celery). I suspect that the exception occurs once the requests have finished, which causes the with command to have finished, removing that _sentry_hub, that is then expected to be present, but I don't have a grasp of how the code run on this Sanic/Sentry part.

I'm also facing this issue. application is working fine, just test are not running. If i just remove the sentry codes, then test are passed.
code to reproduce the error:
# requirements.txt

pytest==7.0.1
pytest-asyncio==0.18.2
sanic==21.12.1
sanic-routing==0.7.2
sanic-testing==0.8.2
sentry-sdk==1.5.7

# server.py
from sanic import Sanic
from sanic.response import json
import sentry_sdk
from sentry_sdk.integrations.sanic import SanicIntegration

sentry_sdk.init(
<EMAIL_ADDRESS>   integrations=[SanicIntegration()]
)

app = Sanic("test")

@app.route('/')
async def test(request):
    return json({'message': 'hola'})

if __name__ == "__main__":
    app.run(host='<IP_ADDRESS>', port=8000)

# test_sample.py
from server import app

async def test_index():
    _, resp = await app.asgi_client.get('/')
    assert resp.status_code == 200
    assert resp.json == {'message': 'hola'}

$ pytest -vvv

I also started to implement tests and discovered that the _sentry_hub issues goes crazy there. I was planning on updating this ticket but @hrshadhin did the job perfectly! Thanks!

I think this pull request resolve this problem: https://github.com/sanic-org/sanic/pull/2451

Is this still an issue? Was this happening running with an ASGI server?

Using Sanic v22.6.2 and the above code

I'll update today to 22.6.2 and see if I still have these. I'll let you know!

I tried with Sanic v22.6.2 and my tests are passed. issue resolved.

@sl0thentr0py Can we get this issue closed? I will add a PR to update the docs to add the specific version.

Sorry to be THAT guy, but I'm still having issues with Sanic v22.12.0.
Here's one of these:
https://cyril-nicodeme.sentry.io/share/issue/36c0531d78ab462994eae3e0f6f930b6/
Looking on Sentry, I can't provide more details than what is present on the link above, but if you need any, please ask.


Colorspace CIE Lab

Hi Jim,
Here is a branch that contains the CIE Lab color space and the tests that go with it, to go with #260.
Hopefully nobody else was already working on this. I hope I properly followed your suggestions posted in regards to the CIE xyz space, but since the RGB conversions for Lab seem to go through xyz, you may want my branch refactored to use the XYZ functions once those are in. In any case, let me know.
The test values I used were matched against ColorMine.

This is excellent. Very much appreciated! :+1:
I'm impressed with the work done to maintain accuracy. I need to check over some of the other color tests to ensure they are as well done.
I think the best bet would be to merge both this pull request and the XYZ one in its current state and continue on from there. If I merge them would you be able to continue?

Sure, of course - no problem.

Littlebit busy ATM to continue. Ill have more time in a few weeks.
Op 5-jan.-2016 11:42 PM schreef rubensr<EMAIL_ADDRESS>Sure, of course - no problem.

Reply to this email directly or view it on GitHubhttps://github.com/JimBobSquarePants/ImageProcessor/pull/290#issuecomment-169157867.

Ace, I'll merge them in now then. Thanks both of you.


Changed to accept all power max from 18kWh to 27 kWh

Thanks. This is a fix for the code of the PyPy-Package, so we will have to create a new version (tag) and insert that new version into the manifest of the HA-Component (here).

Have to remember what to do, when releasing a new version :-). First I have to change three things:

The version in the setup.py
A new tag
A new release

The the new release is published here:
https://pypi.org/manage/project/clage-homeserver/releases/
And then, this new release can be addressed in HA.


Slack Integration

xss-listener supports only telegram app,
Listener can be support slack or discord etc. (Even facebook messenger bot 😸)

I could probably work on this. Do you want it to be a seperate file, env var or ?

@willyb321 That's your coding taste, sorry for my late respond. I'm OK whatever secrets solution.

Funnily enough, I actually was just looking at this when you responded. I'll hopefully be able to get onto this today.

I hope so, you are the most contributor around me!

I have the bot posting to slack now, will work on allowing interaction with it.

Ok, interaction is happening (see 67d30b69e2e8b7b4871991064c3cb914eaf121b8)

Great, you even added to app.json. We thank you! The community will be grateful.


Waypoint Updater Node (Partial)

Complete a partial waypoint updater which subscribes to /base_waypoints and /current_pose and publishes to /final_waypoints.

Changes checked in to the master.


feat: remove jdk18 from pr-Test and retire jdk18

release jdk19 , no need jdk18 in pr-test job and should set to retired

merge as code-freeze is ended for jdk19