Remove AsList AsDT and replace them with Extension Methods

That will reduce the API surface of the library and clean the types

I'm going to try my hand at this as my first OSS contribution! Please be kind to my pull request.

Hi @jboyer2012 thanks for join the team !!
My fault for don't explain better the idea.
At this time, when you create an engine, and do
 engine.

The intellisense will show ReadFileAsDT ReadFileAsList ReadStreamAsDT ReadStreamAsList ReadStringAsDT readStringAsList
All These methods needs to be removed for 4.0 version and we will provide only
ReadFile ReadStream ReadString
Later the user can call an extension method in the resulting array to get what he wants
var result = engine.ReadFile();
var resultAsList = result.ToList() // The Array already has an extension method in linq to create a List
var resultAsDT = result.ToDataTable() // This is the extension method you need to write, you recieve an Array and return a DataTable

You can check http://www.filehelpers.net/docs/html/M_FileHelpers_CommonEngine_RecordsToDataTable.htm
For a start point, from an old implementation
Thanks

Hi Marcos,
I understand better now. Does this project have an existing namespace for extension methods or will I have to create a new one?

@jboyer2012 At this time because the library is .net 2.0 compatible, there are no extension methods, I suffer it a lot, but no more, 3.1 will be the last version of the library to support .net 2.0
About the namespace, please use FileHelpers to allow better discovery and avoid users to import more namespaces
Thanks !!

Okay, I'll do that. Another question from a design standpoint, since I'm still wrapping my head around how you guys have built the code. I am looking at the RecordsToDataTable method of the RecordOperations class as an example. I notice though a call to CreateEmptyDataTable which uses an IRecordInfo to create the DataTable to populate. Will I need to get an IRecordInfo from the Array (or somewhere else) before I can transform it into a DataTable? How would I receive this in my method, as a parameter perhaps?

@jboyer2012 No problem at all take your time, the core of the library can be a bit old because no linq, no too much generics inside.
You must create a record info via the
https://github.com/MarcosMeli/FileHelpers/blob/master/FileHelpers/Core/RecordInfo.Factory.cs
RecordInfo.RecordInfoFactory.Resolve(Type of the array)
So you get an IRecordinfo
The signature of the method must be:
public static DataTable ToDataTable<T>(this T[] records)
{
      var ri = RecordInfo.RecordInfoFactory.Resolve(typeof(T));

...
}
Cheers

@MarcosMeli I sent a pull request your way for the new extension method. I began to eliminate ReadFileAsDT from the code so that the API is cleaner but I noticed the CsvEngine inherits from FileHelperEngine. Therefore removing the method from FIleHelperEngine breaks Csv Engine. Since you didn't mention CsvEngine or it's DT methods previously I wasn't sure what you wanted to do with these. Are these staying? I'm assuming the DT methods will be removed from FileHelperEngine and CommonEngine. Let me know if this is correct.

Also I added a bit of a hack (which is commented) due to the fact that we are building to target .NET 2.0 in the project. This was to make the "this" keyword in the extension method signature build successfully. I don't like it being there but I didn't want to switch the target framework without consulting you first. So I added the extra code in the FileHelperExtensions file so that the functionality will work and you can decide what to do from there.

@jboyer2012 Thanks a ton !!
Just merged, I will remove the this hack attribute, and maybe we can mark the methods as [Obsolete] for the next version and remove them later.
Now we have the Analyzer http://www.filehelpers.net/analyzer/ so we can create a rewrite that change ReadAsList()  and ReadAsDT to the extension methods
Thanks !!

Another little change I will change the static class for extension methods to avoid it pops up in intellisense near other classes

I will use ExtensionsFileHelpers or something like ? What do you think ?
Cheers

Thanks for merging! Feels good to have my first contribution under my belt. As for the static class, ExtensionsFileHelpers is fine since Extensions is not as likely a word for users to type. I'm fine with that. Once that is done I will pull the changes down to my local. I'll poke around for another issue to take on that I think I can handle. Thanks for all of the help!

Would be great, mark them as Obsoleo and create a new PR :+1:
Glad to have your help !!

You already appear in the credits page :clap:
http://www.filehelpers.net/credits/


could not find function "cur_group_id"

Hi, I got this error when running PADLOC. I have no idea how to fix this. Could you please help me with this? Thanks!
>> Searching GCF_009741465.1 for defence systems
Error in cur_group_id() : could not find function "cur_group_id"
Calls: format_output ... <Anonymous> -> mutate -> mutate.tbl_df -> mutate_impl
Execution halted
ERROR >> errexit on line 387

Hello,
Please check all the required R dependencies are up-to-date. cur_group_id was added in dplyr 1.0
Cheers,
Simon


fatal error: 'ggml.h' file not found

Building from project root or example.
> cargo build # Fail

> cd examples/simple
> cargo build # Fail

leads to the following error:
cargo build
   Compiling llama-cpp-sys-2 v0.1.83 (/llama-cpp-rs/llama-cpp-sys-2)
error: failed to run custom build command for `llama-cpp-sys-2 v0.1.83 (/llama-cpp-rs/llama-cpp-sys-2)`

Caused by:
  process didn't exit successfully: `/llama-cpp-rs/target/debug/build/llama-cpp-sys-2-905f5f3cc6aa6cb5/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-env-changed=TARGET
  cargo:rerun-if-env-changed=BINDGEN_EXTRA_CLANG_ARGS_aarch64-apple-darwin
  cargo:rerun-if-env-changed=BINDGEN_EXTRA_CLANG_ARGS_aarch64_apple_darwin
  cargo:rerun-if-env-changed=BINDGEN_EXTRA_CLANG_ARGS
  cargo:rerun-if-changed=wrapper.h

  --- stderr
  ./llama.cpp/include/llama.h:4:10: fatal error: 'ggml.h' file not found
  thread 'main' panicked at llama-cpp-sys-2/build.rs:197:10:
  Failed to generate bindings: ClangDiagnostic("./llama.cpp/include/llama.h:4:10: fatal error: 'ggml.h' file not found\n")
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

However, building individually llama-cpp-2 & llama-cpp-sys-2 works successfully.
> cd llama-cpp-2
> cargo build # Pass

> cd llama-cpp-sys-2
> cargo build # Pass

What need to be done to have the project built on Mac?
I've tried to explicitly declare --features metal and it doesn't fix the problem.
I've followed steps described in the Hacking section of the readme https://github.com/utilityai/llama-cpp-rs/tree/main?tab=readme-ov-file#hacking

@samuelint i invoke the simple binary from the root of the repo like this:
cargo run --release --bin simple --features metal -- --n-len=2048 --prompt "<|start_header_id|>user<|end_header_id|>\n\nshare 5 reasons rust is better than c++<|eot_id|><|start_header_id|>assistant<|end_header_id|>\n\n" local ~/models/llama-3.2-3b-instruct.Q6_K.gguf

That command works. It seem the problem is the debug build. It only works in release.

hmm interesting, i have no problems with removing the release flag and performing a build rather than a run:
cargo b --bin simple --features metal

@brittlewis12 on which commit is your llama.cpp project?

it appears pinned to 8f1d81a0

@brittlewis12 I had a similar issue when running the simple example on macOS 15.0.1:
cargo run --release --bin simple -- --prompt "The way to kill a linux process is" hf-model TheBloke/Llama-2-7B-GGUF llama-2-7b.Q4_K_M.gguf
   Compiling llama-cpp-sys-2 v0.1.83 (/Users/arrowban/tauri-app/llama-cpp-rs/llama-cpp-sys-2)
   Compiling icu_normalizer v1.5.0
   Compiling clap v4.5.19
   Compiling idna v1.0.1
   Compiling url v2.5.1
   Compiling ureq v2.9.7
error: failed to run custom build command for `llama-cpp-sys-2 v0.1.83 (/Users/arrowban/tauri-app/llama-cpp-rs/llama-cpp-sys-2)`

Caused by:
  process didn't exit successfully: `/Users/arrowban/tauri-app/llama-cpp-rs/target/release/build/llama-cpp-sys-2-0c4fc171384fe637/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-env-changed=TARGET
  cargo:rerun-if-env-changed=BINDGEN_EXTRA_CLANG_ARGS_aarch64-apple-darwin
  cargo:rerun-if-env-changed=BINDGEN_EXTRA_CLANG_ARGS_aarch64_apple_darwin
  cargo:rerun-if-env-changed=BINDGEN_EXTRA_CLANG_ARGS
  cargo:rerun-if-changed=wrapper.h

  --- stderr
  ./llama.cpp/include/llama.h:4:10: fatal error: 'ggml.h' file not found
  thread 'main' panicked at llama-cpp-sys-2/build.rs:197:10:
  Failed to generate bindings: ClangDiagnostic("./llama.cpp/include/llama.h:4:10: fatal error: 'ggml.h' file not found\n")
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

It was fixed after deleting everything with rm -rf llama-cpp-rs and running the instructions again from scratch:
git clone --recursive https://github.com/utilityai/llama-cpp-rs
cd llama-cpp-rs

cargo run --release --bin simple -- --prompt "The way to kill a linux process is" hf-model TheBloke/Llama-2-7B-GGUF llama-2-7b.Q4_K_M.gguf

I'm not sure why it didn't work the first time I tried, but maybe it's because the first time around I cloned the repo without the recursive flag, and after trying cargo run ..., initiated submodules

@arrowban same here on linux


Data

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #287
Special notes for your reviewer:
Release note:

Coverage increased (+1.07%) to 59.569% when pulling c9b305dcd69cefb648e3045272b8f1a038b2b4b6 on lasshpanzer:data into bbd209262e35f116a0200febf3803fe47c40c673 on opensds:development.

Coverage increased (+1.07%) to 59.569% when pulling c9b305dcd69cefb648e3045272b8f1a038b2b4b6 on lasshpanzer:data into bbd209262e35f116a0200febf3803fe47c40c673 on opensds:development.

Coverage increased (+1.07%) to 59.569% when pulling c9b305dcd69cefb648e3045272b8f1a038b2b4b6 on lasshpanzer:data into bbd209262e35f116a0200febf3803fe47c40c673 on opensds:development.

Coverage increased (+1.07%) to 59.569% when pulling c9b305dcd69cefb648e3045272b8f1a038b2b4b6 on lasshpanzer:data into bbd209262e35f116a0200febf3803fe47c40c673 on opensds:development.

Coverage increased (+1.07%) to 59.569% when pulling c9b305dcd69cefb648e3045272b8f1a038b2b4b6 on lasshpanzer:data into bbd209262e35f116a0200febf3803fe47c40c673 on opensds:development.


Update toc_dev_en.yml and fetched_files.yml

To add HMI-FW documents (HS, WM, SM), add these information to "APIs&Services" section.
Signed-off-by: hkojima<EMAIL_ADDRESS>

You should take your documentation source from gerrit not your github repo as this duplicate ApplicationGuide.md from gerrit repo.

I changed "url_fetch" from github to gerrit.
And also "git_name" and "src_prefix" since directory structure is different between github and gerrit.

Great, looks good to me.
Thanks

Oups, testing it and see some creepy html tag in index of homescreen guide and soundmanager:
example:
Table of content
Could you clean them please.

Because "git_commit" set as "master" so currently it refer to "RC1" documentation.
Latest documentation for RC2 have already fix it. So I believe after current HS/WM/SM code review is finished, it will be fix automatically.

Ok, great then :)


[♻ refactor] move dropdown menu & action list components to react aria

It is better to use one library for headless components and react-aria is the best at the moment.
also : fetch action list data only when dropdown is open

I finally decided to only move dropdown menu to react-aria, since action is much more complicated


Types for colorPalette seem wrong

The types for color palettes are a little odd.
type Color = `#${number}`
	|`rgb(${number},${number},${number})`
	|`rgba(${number},${number},${number},${number})`;

type ColorPalette = Color
	| `${Color} ${Color}`
	| `${Color} ${Color} ${Color}`
	| `${Color} ${Color} ${Color} ${Color}`
	| `${Color} ${Color} ${Color} ${Color} ${Color}`;

This makes sense, but in the docs, and in many CSS hex codes, they aren't just numbers.
In the docs, the examples give #9355e8FF #123456FF #BDAF10FF as a valid option, but this throws a TS error because there are numbers and letters.
Changing the color template string to #1 #11 #1 fixes the TS error, but is not actually valid.
Possible Solution
type Color = `#${number | string}`
	|`rgb(${number},${number},${number})`
	|`rgba(${number},${number},${number},${number})`;

This solves my use case, but I'm not sure if there was some logic around needing to be a number?

The ColorPalette definition is also wrong, it can handle more than 5 colors, but I couldn't find a way to define it to arbitrary length in TS.


deprecated async_get_registry

Is your feature request related to a problem? Please describe.
getting this error message:
2022-07-20 20:43:56 WARNING (MainThread) [homeassistant.helpers.frame] Detected integration that uses deprecated async_get_registry to access entity registry, use async_get instead. Please report issue to the custom component author for keyatome using this method at custom_components/keyatome/sensor.py, line 664: registry = await async_get_registry(self.hass)
Describe the solution you'd like
replace the "async_get_registry" by the new solution you better know than me
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Thanks for your feed back.
I m on holidays. I will perform the improvement when I m back ;-)

I've analyzed the modifcation will come soon !

Implementation done with v6.3.0
Thanks @seb-5x

Thanks!
Le ven. 12 août 2022, 07:51, jugla @.***> a écrit :

I've analyzed the modifcation will come soon !
—
Reply to this email directly, view it on GitHub
https://github.com/jugla/keyatome/issues/15#issuecomment-1212752567, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AUTBQCZD7GENOOZNMFC5ZI3VYXQ5PANCNFSM54EYWTEQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Added frequency capping constraints to the personalized offer schema

https://github.com/adobe/xdm/issues/1438
Frequency capping constraints define additional rules based on prior offer proposition, either across all audiences or for a particular profile identity.
What are the schemas that are affected by the issue
https://github.com/adobe/xdm/blob/master/extensions/adobe/experience/offer-management/personalized-content-offer.schema.json
What are examples of products that are impacted by the issue
No impact on the existing products. Frequency capping constraints define additional rules based on prior offer proposition, either across all audiences or for a particular profile identity.

@prabhum2  Could you please review this PR


Add Pika

Project URL
https://github.com/superhighfives/pika
Category
Menubar and Utilities
Description
Pika (pronounced pi·kuh, like picker) is an easy to use, open-source, native colour picker for macOS
Checklist

[x] Edit applications.json instead of README.md.
[x] Only one project/change is in this pull request
[x] Screenshots(s) added if any
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

@pahnev Thank you! 🚀


[Bug] [Relax] Missing IR structure checking and correction

Hi all, I set check_well_formed=True  in the below Relax IR construction and can run mod.show()  to show the IR successfully. It seems the Relax IR passed the legitimacy checking. However, the compilation crashed when executing ex = relax.build(mod, target='llvm'). The crash message shows that
"Argument 0 type mismatch: expected R.Tensor((16,), dtype="float32"), given R.Tuple(R.Tensor((16,), dtype="float32"))"
Based on my analysis, if we replace the code gv1 = R.call_tir(cls.relu, (x), out_sinfo=R.Tensor((1, 512, 64, 64))) (Line 26) with gv1 = R.nn.relu(x) (Line 27) or gv1 = R.call_tir(cls.relu, (x,), out_sinfo=R.Tensor((1, 512, 64, 64), dtype="float32")) (Line 28), the script can run well.
Even if the Relax IR constructor can convert gv1 = R.nn.relu(x) to full information with type based on the context, why didn't it complete the missing type for gv1 (Line 26).
To take a step back, if the Relax IR constructor cannot complete the missing information and we set check_cell_formed=True in the Relax IR construction, we should throw an exception early in mod = Module rather than relax.build().  Early crashes will make the code more robust.
BTW, I prefer the IR constructor can fill in missing information or correct the inconsistent constraints based on IRs' context.
Actual behavior
Traceback (most recent call last):
  File "demo_simple.py", line 26, in <module>
    ex = relax.build(mod, target='llvm')  # crash here!
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/software/tvm/python/tvm/relax/vm_build.py", line 335, in build
    mod = pipeline(mod)
          ^^^^^^^^^^^^^
  File "/software/tvm/python/tvm/ir/transform.py", line 238, in __call__
    return _ffi_transform_api.RunPass(self, mod)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/software/tvm/python/tvm/_ffi/_ctypes/packed_func.py", line 239, in __call__
    raise_last_ffi_error()
  File "/software/tvm/python/tvm/_ffi/base.py", line 481, in raise_last_ffi_error
    raise py_err
  File "/software/tvm/python/tvm/relax/pipeline.py", line 101, in _pipeline
    mod = seq(mod)
          ^^^^^^^^
  File "/software/tvm/python/tvm/ir/transform.py", line 238, in __call__
    return _ffi_transform_api.RunPass(self, mod)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/software/tvm/python/tvm/_ffi/_ctypes/packed_func.py", line 239, in __call__
    raise_last_ffi_error()
  File "/software/tvm/python/tvm/_ffi/base.py", line 481, in raise_last_ffi_error
    raise py_err
tvm._ffi.base.TVMError: Traceback (most recent call last):
  38: tvm::runtime::PackedFuncObj::Extractor<tvm::runtime::PackedFuncSubObj<tvm::runtime::TypedPackedFunc<tvm::IRModule (tvm::transform::Pass, tvm::IRModule)>::AssignTypedLambda<tvm::transform::{lambda(tvm::transform::Pass, tvm::IRModule)#7}>(tvm::transform::{lambda(tvm::transform::Pass, tvm::IRModule)#7}, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)::{lambda(tvm::runtime::TVMArgs const&, tvm::runtime::TVMRetValue*)#1}> >::Call(tvm::runtime::PackedFuncObj const*, tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)
  37: tvm::transform::Pass::operator()(tvm::IRModule) const
  36: tvm::transform::Pass::operator()(tvm::IRModule, tvm::transform::PassContext const&) const
  35: tvm::transform::SequentialNode::operator()(tvm::IRModule, tvm::transform::PassContext const&) const
  34: tvm::transform::Pass::operator()(tvm::IRModule, tvm::transform::PassContext const&) const
  33: tvm::transform::ModulePassNode::operator()(tvm::IRModule, tvm::transform::PassContext const&) const
  32: _ZN3tvm7runtime13PackedFuncObj9ExtractorINS0_1
  31: tvm::runtime::TypedPackedFunc<tvm::IRModule (tvm::IRModule, tvm::transform::PassContext)>::AssignTypedLambda<tvm::relax::transform::CallTIRRewrite()::{lambda(tvm::IRModule, tvm::transform::PassContext)#1}>(tvm::relax::transform::CallTIRRewrite()::{lambda(tvm::IRModule, tvm::transform::PassContext)#1})::{lambda(tvm::runtime::TVMArgs const&, tvm::runtime::TVMRetValue*)#1}::operator()(tvm::runtime::TVMArgs const&, tvm::runtime::TVMRetValue*) const
  30: tvm::relax::CallTIRMutator::Run()
  29: tvm::relax::ExprMutator::VisitExpr(tvm::RelayExpr const&)
  28: tvm::relax::ExprFunctor<tvm::RelayExpr (tvm::RelayExpr const&)>::VisitExpr(tvm::RelayExpr const&)
  27: _ZZN3tvm5relax11ExprFunctorIFNS_9RelayExprERKS2_EE10InitVTableEvENUlRKNS_7runtime9ObjectRef
  26: tvm::relax::ExprMutator::VisitExpr_(tvm::relax::FunctionNode const*)
  25: tvm::relax::ExprMutator::VisitWithNewScope(tvm::RelayExpr const&, tvm::runtime::Optional<tvm::runtime::Array<tvm::relax::Var, void> >)
  24: tvm::relax::ExprMutator::VisitExpr(tvm::RelayExpr const&)
  23: tvm::relax::ExprFunctor<tvm::RelayExpr (tvm::RelayExpr const&)>::VisitExpr(tvm::RelayExpr const&)
  22: _ZZN3tvm5relax11ExprFunctorIFNS_9RelayExprERKS2_EE10InitVTableEvENUlRKNS_7runtime9ObjectRef
  21: tvm::relax::ExprMutator::VisitExpr_(tvm::relax::SeqExprNode const*)
  20: tvm::relax::ExprMutator::VisitBindingBlock(tvm::relax::BindingBlock const&)
  19: tvm::relax::ExprMutator::VisitBindingBlock_(tvm::relax::BindingBlockNode const*)
  18: tvm::relax::ExprMutator::VisitBinding(tvm::relax::Binding const&)
  17: tvm::relax::ExprMutator::VisitBinding_(tvm::relax::VarBindingNode const*)
  16: _ZZN3tvm5relax11ExprMutator22InitVisitBindingVTabl
  15: tvm::relax::ExprMutator::VisitBinding_(tvm::relax::VarBindingNode const*, tvm::relax::CallNode const*)
  14: tvm::relax::ExprMutator::VisitExpr(tvm::RelayExpr const&)
  13: tvm::relax::ExprFunctor<tvm::RelayExpr (tvm::RelayExpr const&)>::VisitExpr(tvm::RelayExpr const&)
  12: _ZZN3tvm5relax11ExprFunctorIFNS_9RelayExprERKS2_EE10InitVTableEvENUlRKNS_7runtime9ObjectRef
  11: tvm::relax::CallTIRMutator::VisitExpr_(tvm::relax::CallNode const*)
  10: tvm::relax::BlockBuilderImpl::Emit(tvm::RelayExpr, tvm::runtime::String)
  9: tvm::relax::BlockBuilderImpl::Emit(tvm::RelayExpr, bool, tvm::runtime::String)
  8: tvm::relax::Normalizer::Normalize(tvm::RelayExpr const&)
  7: tvm::relax::ExprFunctor<tvm::RelayExpr (tvm::RelayExpr const&)>::VisitExpr(tvm::RelayExpr const&)
  6: _ZZN3tvm5relax11ExprFunctorIFNS_9RelayExprERKS2_EE10InitVTableEvENUlRKNS_7runtime9ObjectRef
  5: non-virtual thunk to tvm::relax::Normalizer::VisitExpr_(tvm::relax::CallNode const*)
  4: tvm::relax::Normalizer::VisitExpr_(tvm::relax::CallNode const*)
  3: tvm::relax::Normalizer::InferStructInfo(tvm::relax::Call const&)
  2: tvm::relax::DeriveCallRetStructInfo(tvm::relax::FuncStructInfo const&, tvm::relax::Call const&, tvm::relax::BlockBuilder const&, tvm::arith::Analyzer*)
  1: tvm::relax::CallRetStructInfoDeriver::Derive(tvm::relax::FuncStructInfo const&, tvm::relax::Call const&, tvm::relax::BlockBuilder const&)
  0: tvm::relax::BlockBuilderImpl::ReportFatal(tvm::Diagnostic const&)
  File "/software/tvm/src/relax/ir/block_builder.cc", line 159
TVMError: Argument 0 type mismatch: expected R.Tensor((16,), dtype="float32"), given R.Tuple(R.Tensor((16,), dtype="float32"))

Environment

TVM: 0.17.dev0

Steps to reproduce
import tvm
from tvm import relax
from tvm.script import ir as I
from tvm.script import tir as T
from tvm.script import relax as R

@I.ir_module(check_well_formed=True)
class Module:
    @T.prim_func(private=True)
    #def relu(A: T.Buffer((T.int64(1), T.int64(512), T.int64(64), T.int64(64)), "float32"), B: T.Buffer((T.int64(1), T.int64(512), T.int64(64), T.int64(64)), "float32")):
    def relu(A: T.Buffer((T.int64(1), T.int64(512), T.int64(64), T.int64(64)), "float32"), B: T.Buffer((T.int64(1), T.int64(512), T.int64(64), T.int64(64)))):
        T.func_attr({"op_pattern": 0})
        # with T.block("root"):
        for i0, i1, i2, i3 in T.grid(T.int64(1), T.int64(512), T.int64(64), T.int64(64)):
            with T.block("relu"):
                v_i0, v_i1, v_i2, v_i3 = T.axis.remap("SSSS", [i0, i1, i2, i3])
                T.reads(A[v_i0, v_i1, v_i2, v_i3])
                T.writes(B[v_i0, v_i1, v_i2, v_i3])
                B[v_i0, v_i1, v_i2, v_i3] = T.max(A[v_i0, v_i1, v_i2, v_i3], T.float32(0))

    @R.function
    def main(x: R.Tensor((1, 512, 64, 64), dtype="float32")) -> R.Tensor((1, 512, 64, 64), dtype="float32"):
        cls = Module
        with R.dataflow():
            gv1 = R.call_tir(cls.relu, (x), out_sinfo=R.Tensor((1, 512, 64, 64)))  # crash
            # gv1 = R.nn.relu(x)  # run well
            # gv1 = R.call_tir(cls.relu, (x,), out_sinfo=R.Tensor((1, 512, 64, 64), dtype="float32"))  # run well
            R.output(gv1)
        return gv1

mod = Module
mod.show()

mod = relax.transform.FuseTIR()(mod)
mod = relax.transform.LambdaLift()(mod)
ex = relax.build(mod, target='llvm')

cc @Lunderberg @junrushao @tqchen

Good catch, and I think this is arising from a number of different edge cases.

The StructInfo for R.call_tir is always inferred from the out_sinfo, not from the TIR function's signature.  This is for historical reasons, as TIR functions only recently started holding the annotations that would allow them to perform shape inference.  As a result, no errors are seen during the initial well-formed check.

The default of T.Buffer and R.Tensor is different.  If unspecified, T.Buffer defaults to "float32" datatype, where R.Tensor defaults to DataType::Void, which is used to represent an unknown datatype that might be inferred later in compilation.  There is no equivalent in TIR, which must have a known datatype for each buffer.

There is no rule that would infer the unknown Relax datatype from the mandatory TIR datatype.  As a result, the out_sinfo remains the incomplete R.Tensor(shape), rather than R.Tensor(shape, dtype="float32").

The error is raised during CallTIRRewrite, which rewrites low-level calls from having an implied allocation for the output to having an explicit argument for the output.  Here, this rewirtes the R.call_tir(cls.relu, [x], out_sinfo=R.Tensor([1,512,64,64])) into cls.relu(x, output_allocation), where output_allocation has shape R.Tensor([1,512,64,64]).  This is the first point at which the TIR function's signature is actually inspected.

Currently, when checking whether the constraints required by a subroutine, the constraints must either pass or fail.  There is no mechanism for the subroutine's constraints to be hoisted into the calling scope.  Since "tensor of arbitrary element type" is not a valid argument for "tensor with float32 element type", the check fails.

I think there's a number of improvements that could be made, in order to close each of these loopholes.

Improved well-formed checker.  If out_sinfo is explicitly stated in R.call_tir, then IsBaseOf(inferred_sinfo, out_sinfo) must return true.

Infer the dtype of out_sinfo in R.call_tir.  If out_sinfo is a Tensor, or a Tuple of tensors, and one of those tensors has DataType::Void(), normalize the out_sinfo argument to include the datatype from the PrimFunc.

Improved struct inference for R.call_tir.  Now that PrimFuncs have a known shape for each argument, the output of R.call_tir could be improved.  For backwards compatibility, an explicit out_sinfo argument would still take precedence.  However, if out_sinfo is omitted (which currently would cause an immediate error), it would instead infer the output struct info assuming that the last len(params) - len(args) are output parameters.

Improved normalization in block builder.  If an operator has restrictions on an argument, normalization could expose those constraints to the Relax levels, rather than only marking it as pass/fail.  For example, normalization of an operator whose argument must be DataType::Float(32), but which received DataType::Void(), could produce a binding of new_arg = R.match_cast(arg, R.Tensor(arg.struct_info.shape, "float32")), then use new_arg in its call.

I think all of these would be useful changes to make, but some would have wider impacts than others.  The well-formed checks could be added with the smallest risk of breakage, but also place the greatest load on new developers.  Improved normalization would provide the greatest ease-of-use, but would require the most widespread changes.  @tqchen, since some of these would be much more involved changes, do you have preferences/thoughts on them?

A similar bug occurs as shown below.
Based on what I saw. The well-formed checker commonly corrects the return type and shape. However, when the type of relax function return var is R.Tuple(), the well-formed checker seems not to work.
Actual behavior
Traceback (most recent call last):
  File "/share_container/optfuzz/res/bugs/res_type.py", line 82, in <module>
    mod_outputs = vm['main'](input_0, input_1)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/software/tvm/python/tvm/_ffi/_ctypes/packed_func.py", line 239, in __call__
    raise_last_ffi_error()
  File "/software/tvm/python/tvm/_ffi/base.py", line 481, in raise_last_ffi_error
    raise py_err
ValueError: Traceback (most recent call last):
  8: tvm::runtime::PackedFuncObj::Extractor<tvm::runtime::PackedFuncSubObj<tvm::runtime::relax_vm::VirtualMachineImpl::_LookupFunction(tvm::runtime::String const&)::{lambda(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)#1}> >::Call(tvm::runtime::PackedFuncObj const*, tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)
  7: tvm::runtime::relax_vm::VirtualMachineImpl::InvokeClosurePacked(tvm::runtime::ObjectRef const&, tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)
  6: tvm::runtime::PackedFuncObj::Extractor<tvm::runtime::PackedFuncSubObj<tvm::runtime::relax_vm::VirtualMachineImpl::GetClosureInternal(tvm::runtime::String const&, bool)::{lambda(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)#1}> >::Call(tvm::runtime::PackedFuncObj const*, tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)
  5: tvm::runtime::relax_vm::VirtualMachineImpl::InvokeBytecode(long, std::vector<tvm::runtime::TVMRetValue, std::allocator<tvm::runtime::TVMRetValue> > const&)
  4: tvm::runtime::relax_vm::VirtualMachineImpl::RunLoop()
  3: tvm::runtime::relax_vm::VirtualMachineImpl::RunInstrCall(tvm::runtime::relax_vm::VMFrame*, tvm::runtime::relax_vm::Instruction)
  2: tvm::runtime::relax_vm::VirtualMachineImpl::InvokeClosurePacked(tvm::runtime::ObjectRef const&, tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)
  1: _ZN3tvm7runtime13PackedFuncObj9ExtractorINS0_16Pack
  0: tvm::runtime::relax_vm::CheckTensorInfo(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)
  File "/software/tvm/src/runtime/relax_vm/builtin.cc", line 247
ValueError: Check failed: (DataType(ptr->dl_tensor.dtype) == dtype) is false: ErrorContext(fn=main, loc=return, annotation=R.Tuple(R.Tensor((16, 16), dtype="int32"), R.Tensor((32, 32), dtype="float32")))  expect Tensor with dtype float32 but get int32

Steps to reproduce
import tvm
from tvm import relax
import numpy as np

from tvm.script import ir as I
from tvm.script import tir as T
from tvm.script import relax as R

@I.ir_module
class Module:
    @T.prim_func(private=True)
    def ones(T_full: T.Buffer((T.int64(16), T.int64(16)), "int32")):
        T.func_attr({"tir.noalias": T.bool(True)})
        # with T.block("root"):
        for ax0, ax1 in T.grid(T.int64(16), T.int64(16)):
            with T.block("T_full"):
                v_ax0, v_ax1 = T.axis.remap("SS", [ax0, ax1])
                T.reads()
                T.writes(T_full[v_ax0, v_ax1])
                T_full[v_ax0, v_ax1] = 1

    @T.prim_func(private=True)
    def zeros(T_full: T.Buffer((T.int64(16), T.int64(16)), "int32")):
        T.func_attr({"tir.noalias": T.bool(True)})
        # with T.block("root"):
        for ax0, ax1 in T.grid(T.int64(16), T.int64(16)):
            with T.block("T_full"):
                v_ax0, v_ax1 = T.axis.remap("SS", [ax0, ax1])
                T.reads()
                T.writes(T_full[v_ax0, v_ax1])
                T_full[v_ax0, v_ax1] = 0
    @T.prim_func(private=True)
    def zeros1(T_full: T.Buffer((T.int64(32), T.int64(32)), "int32")):
        T.func_attr({"tir.noalias": T.bool(True)})
        # with T.block("root"):
        for ax0, ax1 in T.grid(T.int64(32), T.int64(32)):
            with T.block("T_full"):
                v_ax0, v_ax1 = T.axis.remap("SS", [ax0, ax1])
                T.reads()
                T.writes(T_full[v_ax0, v_ax1])
                T_full[v_ax0, v_ax1] = 0

    @R.function(private=True)
    def func() -> R.Tuple(R.Tensor((16, 16), dtype="int32"), R.Tensor((16, 16), dtype="int32"), R.Tensor((32, 32), dtype="int32")):
        cls = Module
        A = R.call_tir(cls.zeros, R.tuple(), out_sinfo=R.Tensor((16, 16), dtype="int32"))
        B = R.call_tir(cls.ones, R.tuple(), out_sinfo=R.Tensor((16, 16), dtype="int32"))
        C = R.call_tir(cls.zeros1, R.tuple(), out_sinfo=R.Tensor((32, 32), dtype="int32"))
        return (A, B, C)

    @R.function
    def main_2() -> R.Tuple(R.Tensor, R.Tensor):
        cls = Module
        args: R.Tuple(R.Tensor, R.Tensor, R.Tensor) = cls.func()
        gv1: R.Tensor = args[0]
        gv2: R.Tensor = args[2]
        return (gv1, gv2)
    @R.function
    def main(v3_0: R.Tensor((1, 22, 1), dtype="float16"), v6_0: R.Tensor((1, 37), dtype="float16")) -> R.Tuple(R.Tensor((16, 16), dtype="int32"), R.Tensor((32, 32), dtype="float32")):  # if return value is a tuple, well_form checker cannot correct it!
        R.func_attr({"num_input": 1})
        cls = Module
        with R.dataflow():
            res: R.Tuple(R.Tensor, R.Tensor) = cls.main_2()
            R.output(res)
        return res

mod = Module
mod.show()
mod = tvm.relax.transform.LegalizeOps()(mod)

mod = relax.transform.FuseTIR()(mod)
mod = relax.transform.LambdaLift()(mod)
ex = relax.build(mod, target='llvm')
vm = relax.VirtualMachine(ex, tvm.cpu())

input_0 = tvm.nd.array(10 * np.random.random([1, 22, 1]).astype('float16'))
input_1 = tvm.nd.array(10 * np.random.random([1, 37]).astype('float16'))
mod_outputs = vm['main'](input_0, input_1)

Hmm.  I think this is something that should be catchable by propagating the known struct info, but currently isn't caught.

In main_2, cls.func() returns a tuple with known dtype and static shapes, but is assigned to a variable with unknown dtype and shape.  This is legal, because the set of all R.Tuple(R.Tensor, R.Tensor, R.Tensor) is a superset of the set of all R.Tuple(R.Tensor((16,16), "int32"), R.Tensor((16,16), "int32"), R.Tensor((32,32), "int32")).
In main, even if the return type of cls.main_2() isn't explicitly specified, it gets inferred as R.Tuple(R.Tensor, R.Tensor).
The return type from main may be more specific than the body.  This is intended to ensure that the return type is stable, even if an optimization prevents shape inference from reaching all the way to the end of the function, the function still has accurate annotations.  However, this means that the return struct info may be more a sub-type of the body's struct info.
Whenever the return type is a sub-type of the body's struct info, a runtime assert is inserted.  This is the assert that triggers the error message.

I think this is a limitation in the StructInfo inference, which should catch the IRModule as ill-formed at compile-time, rather than runtime.  However, it would first require a few extra steps of StructInfo inference that aren't currently performed.

If an expression has more specific StructInfo than the variable it is bound to, propagate from the expression to the variable.
If the body of a function has more specific StructInfo than the current return type, propagate from the body to the return type.
If a function has more specific StructInfo than the GlobalVar used to represent it, propagate from the function to the GlobalVar.

For the example, this would let the "int32" type returned by cls.func to be propagated through main_2, and into main.  At that point, it could be recognized as an error to return "int32" in a function that is marked as returning "float32".


chore: Move lemmas about Int.natAbs and zpowersHom

These can be defined earlier for free.
Part of #9411

Thanks :tada:
If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.
bors d+

bors merge


Add contributors to about page

Fixes #272.
Created from:
git log --format='%an' | sort -fu >> about.md

and then massaging the list by hand.

I thought about adding links to Github pages or Web sites for contributors, but that would probably be too difficult to maintain.  I'm sure just keeping the contributor list will be difficult enough.

😎

Great :)


Add rustls to build, removing dependency on openssl

This should resolve the issue on Linux where dynamic linking with openssl sometimes does not work, depending on the system.
Fixes #168

Should the chompfile be modified in any way?

CI is now passing on master, so with the env change mentioned above I believe that should get this one green.


Request: Editor Dark Theme

It looks like you're using CodeMirror for syntax highlighting in the editor. Would it be possible to allow us to select other themes available to CodeMirror? Some of the dark ones they have are much easier on my eyes when using them for long periods.

I like this idea. I'll add it to my todo list.


why the tabs works like this?

Version
Tell us which versions you are using:
"react": "16.3.1",
"react-native": "^0.55.4",
"react-native-router-flux": "^4.0.4",
"react-native-vector-icons": "^5.0.0",
"react-navigation": "^2.12.1"
Expected behaviour
the tabBar title should show normal.

but when in  react-native-router-flux V3 that work normal on android devices
Reproducible demo

        <Stack  key="root" hideNavBar>
            <Scene tabs key="tabbar">
                <Scene key="tab1" initial icon={TabIcon} tabIcon='home'  title='home' navigationBarStyle={{ backgroundColor: '#ffdb42' }}>
                    <Scene key='home' component={Login} hideNavBar />
                </Scene>
                <Scene key="tab2" icon={TabIcon} tabIcon="headphones"  title="music" navigationBarStyle={{ backgroundColor: '#ffdb42' }}>
                    <Scene key="music" component={Music} title="OOXX" />
                </Scene>
                <Scene key="tab3" title="heart" icon={TabIcon} tabIcon="heart"  navigationBarStyle={{ backgroundColor: '#ffdb42' }}>
                    <Scene key='favorite' title='where' component={Login} />
                </Scene>
            </Scene>
        </Stack >
    </Router>

export class TabIcon extends Component {
render() {
return (
<View style={{ justifyContent: 'center', alignItems: 'center' }}>
<Icon name={this.props.tabIcon} size={20} color={this.props.selected ? "yellow" : '#666'} />
<Text style={{ color: this.props.selected ? 'yellow' : '#666', marginTop: 5, fontSize: 12 }}>{this.props.title}

)
}
}

Remove title from your TabIcon and it will should work as expected.
Expo example shows something similar to your code.
https://github.com/aksonov/react-native-router-flux/blob/master/examples/expo/navigation/AppNavigator.js#L99
https://github.com/aksonov/react-native-router-flux/blob/master/examples/expo/components/TabBarIcon.js

thanks  a lot . but how to change tabBarLabel text color?

thanks again.i have find the  attribute activeTintColor  .

Glad it worked - react-navigation have changed a lot - and rnrf also due to it.


[UpdateChecker] Use https

This will make app transport and the iOS 9 SDK much much happier
\c @jpsim

:+1:


Evaluation Metrics

implementation of evaluation metrics involves:

[ ] exact match
[ ]  f1 score
[ ]  rogue score
[ ]  BLEU SCORE


Configure Skylight environment

Context
As an Apply Team member
When I view the Skylight performance monitoring dashboard
I want to see performance monitoring stats per environment (qa, staging, sandbox, production)
In order to make more informed decisions about performance issues

Changes proposed in this pull request
Add SKYLIGHT_ENV environment variable in order to display performance monitoring stats per deployed environment (qa, staging, sandbox, production)
Guidance to review
To test locally, add SKYLIGHT_ENV=[something]  in your .env. Assuming you have Skylight configured correctly (see README) you will see stats appear on the dashboard under the environment you specified
Link to Trello card

Things to check

[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

https://trello.com/c/WRfveHBq/2030-configure-skylight-environment


Not able to get group members

No matter what path I take, I cannot use the graphrbac to go from the current user logged in to the groups they are a member of. I have tried both of the following and the result is always nil. The user I am testing with is a member of 3 groups.
// Get the current users object ID
token, _ := getDeviceToken(cliID, tenantID)
objClient := graphrbac.NewObjectsClient(tenantID)
objClient.Authorizer = autorest.NewBearerAuthorizer(token)
usrobj, _ := objClient.GetCurrentUser(context.TODO())

// Approach 1: Use the GroupsClient.Get function to get the ADGroup object from the user
grpClient := graphrbac.NewGroupsClient(tenantID)
grpClient.Authorizer = autorest.NewBearerAuthorizer(token)
group, _ := grpClient.Get(context.TODO(), *usrobj.ObjectID)
fmt.Println(group)

// RESULT: {{0xc42039c2d0} <nil> <nil> <nil> map[] <nil> <nil> }

// Approach 2: Use the UsersClient.GetMemberGroups function to get the UserGetMemberGroupsResult object
usrClient := graphrbac.NewUsersClient(tenantID)
usrClient.Authorizer = autorest.NewBearerAuthorizer(token)
parm := graphrbac.UserGetMemberGroupsParameters{}
groups, _ := usrClient.GetMemberGroups(context.TODO(), *usrobj.ObjectID, parm)
fmt.Println(groups.Value)

// RESULT: <nil>

Given the lack of documentation around this particular thing, I assumed one of these would work.

No dice
graphrbac.GroupsClient#IsMemberOf: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: Service returned an error. Status=403 Code="Unknown" Message="Unknown service error"

That is an authentication issue. Verify the logged in user has enough permissions to do that operation.

The user logging in is checking that they are a member of a group. What am I missing?

The application might not have enough permissions.
Dcoumentation

@joshgav Is there somebody from the RBAC team we can loop in?

@jillcary I found your alias in the specs repo, is this something you can help with?

Hello, are you referring to the PR for adding User Roles to the sdk here?
I am working on the CLI for the Azure IoT Remote Monitoring Accelerator and we found that User Roles were missing from the current API.

@giampierod sorry for the delay, still trying to find an answer.  Regarding permissions have you seen this?

Hi @jhendrixMSFT. On a similar note, can we get an error that conveys more information. Unknown service error is not that helpful :(.

@tariq1890 this should be somewhat fixed in v10.11.3 of go-autorest.  There is a larger work item here though, I've opened https://github.com/Azure/azure-sdk-for-go/issues/2201 to track it.

Thanks for your response, @jhendrixMSFT . I am assuming the Azure samples point to the latest version of go-autorest?
https://github.com/azure-samples/azure-sdk-for-go-samples
I get the same unknown service error when I try out the graphrbac API calls.

The sample is using v10.11.2 which doesn't contain this fix.

My bad. Thanks for clarifying :).

I have not been able to find a solution to the original issue here.  :(  If this is still an issue please re-open.


Fix NPE when getting isDeviceSecure

Task/Issue URL: https://app.asana.com/0/488551667048375/1207235055389762/f
Description
Fix NPE crash when checking if device supports legacy auth
Steps to test this PR
QA optional

#4510  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @aitorvs and the rest of your teammates on  Graphite


feat: block voting again for same proposal

This commit adds pendingVotes in state (it's lost on refresh), so after voting you can't vote for the same proposal again.
This is simple workaround to make UX better. In the future we probably should have better way to handle it where pending vote gets treated same as real ones with a way to handle cases where pending vote actually doesn't execute (transaction failure etc.)

I got this error with estimate gas with this PR for some reason

Seem to work on https://snapshotx.xyz

Hum actually it work sometimes, not sure if it's related to this PR.

@bonustrack are you trying to vote on cancelled proposal? Those will show up in UI until we merge cancel PR.

Oops good catch, I was doing that.

Can't get a tx onchain for some reason (using EthSig authenticator), tried couple time with the PR or snapshotx.xyz here:
https://goerli.etherscan.io/tx/0xc8f5ff8b332671c752894ee40097549b464b4bdf6f00927efb2f829a5ec63bfd
https://goerli.etherscan.io/tx/0x363f834f0ea8085fa0b521ae58c65cacac371755198f5c8f772459431f477540

@bonustrack nonce manager from ethers.js is broken, it probably bumped nonce for failed transactions and is now stuck. We will have to write our own solution for managing nonces probably.

I've restarted Mana and now it work again. Some related discussion here: https://github.com/ethers-io/ethers.js/issues/972

Can we display results here after user vote?

@bonustrack I didn’t do that because those would be inaccurate (your vote won’t be accounted for yet) unless we want to go all the way right away and implement full optimistic updates like described in PR message.


Increase test coverage

The following is similar to the current test coverage for the library:
----------- coverage: platform linux, python 3.9.7-final-0 -----------
Name                            Stmts   Miss  Cover   Missing
-------------------------------------------------------------
spylib/__init__.py                  3      0   100%
spylib/constants.py                 4      0   100%
spylib/exceptions.py               10      0   100%
spylib/oauth/__init__.py            2      0   100%
spylib/oauth/redirects.py          18      4    78%   61-73
spylib/oauth/router.py             49      8    84%   47, 49, 79-80, 96-98, 101
spylib/oauth/validations.py        29      2    93%   19, 48
spylib/token.py                   171     14    92%   97, 131-132, 140, 157-158, 184, 202, 259, 263, 288, 331-336
spylib/utils/__init__.py            7      0   100%
spylib/utils/domain.py             13      1    92%   9
spylib/utils/hmac.py               17      5    71%   10, 16-19
spylib/utils/httpclient.py         11      1    91%   17
spylib/utils/jwtoken.py            34      7    79%   54-56, 84-87, 92
spylib/utils/misc.py                6      0   100%
spylib/utils/session_token.py      51      0   100%
-------------------------------------------------------------
TOTAL                             425     42    90%

I think it might be useful to write some more tests for the following sections? As it is a little tricky to tell if changes are impacting different parts of the library at the moment.

spylib/oauth/redirects.py
spylib/oauth/router.py
spylib/token.py

Especially the OAuth section, as the current tests are only testing a single run-through of the OAuth process and doesn't check erroneous cases and how they are handled.

I'd suggest to do some clean up first. I believe some stuff related to jwtoken.py needs to go, if not all of it. That's another way to increase code coverage: get rid of code that's not tested ... and not useful!  :wink:


testdata funcscan initial commit

Loooks good! Once this is in please make a another PR with a test samplesheet.csv
For funcscan
sample,fasta
    contig_1,https://raw.githubusercontent.com/nf-core/test-datasets/modules/data/genomics/bacteroides_fragilis/genome/genome.fna.gz

So please replace contig_1 with something like `sample_1, then update the raw.github path.
We should also have a second fasta input, thinking about it :thinking: Maybe you can just copy the fasta file and give it a slightly different name for now, and insert that into the spreadsheet as e.g. sample_2


Extra chart configs

What this PR does / why we need it:
Adds the possibility to make OPA bind itself to another port other than 443
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/assign @tsandall :)

/ok-to-test

/lgtm


[Dropdown] removing "loading" class or "disabled"

Haven't found anything about this in the docs, so I'll ask here. I've got a dropdown that on page load doesn't have any content. As such I disable the element, and give it the loading class. I then fire off .dropdown() on it. That works as expected. But the rub comes when I load contents in after.
If I look at the markup, I can see the content's been loaded, but the click events don't seem to fire off, and I cannot figure out how to remove these states from the dropdown and have it function properly agian.
example:
<select id="foo" class="ui loading disabled search dropdown">
[no options]
</select>
$('#foo').dropdown()

Then I load options into the select with an ajax call, and remove the classes from the select.
<select id="foo" class="ui search dropdown">
[options]
</select>

I've tried $('#foo').dropdown(), $('#foo').dropdown('refresh'), removing the classes manually from the select's parent(which fixes the visual half of the issue).
So if I init a select with loading/disabled on it, and then I want to REMOVE those AND have the click events work (they do not work after I load in contents)... how do I do it? I'm not seeing anything in the docs about this.

Made a test case: http://jsfiddle.net/evgyh06L/
strangely in my example, removing the classes seems to work. I'll have to investigate in my actual usecase to see if I'm missing anything.

As an update, I've figured out the issue.
I'm building this control in a React/redux environment, and populating a list of countries based on content from an api (not using the api settings OF the dropdown, though). What was happening was this:

Render a select with className set to ui search loading disabled dropdown
Set the dropdown with JS on componentDidMount

this is fine, but when the countries are loaded and passed to the component, the select is rerendering. This caused the classnames to be added again, so I ended up with markups like

<select class="ui search dropdown>
...stuff

It's this re-addition of the classes to the select that was breaking everything. Not sure what you can do with this information (if you want to do anything at all), but that's what was causing the issue.

This is just related to using the class name disabled on a dropdown.


Problem when exporting and importing bot as zip

Describe the bug
Hello,
I created a bot with composer but when I export it as a zip and try to import it on another laptop most of my text prompts are gone and replaced with "-", but the flow and dialogs are still there. Any experience or solution for this?
Version

Browser

[ ] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS
What operating system are you using?

[ ] macOS
[x ] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior

Screenshots

Additional context

### Tasks

Could someone help?

@s8labo not sure what's the cause of the missing text prompts. Have you tried manually copying the bot folder into the new machine? This may help as a workaround

Closing due to inactivity. Feel free to reopen


Background white on PHP storm 2016.1.1

In both theme, background for php files is white.

In both theme, background for php files is white. I have the same problem please do something love this theme, and can't wait to update phpstorm. Happy @ZiperRom1 already raised issue  to @abhimanyusharma003

Many thanks for reporting.
Check the new update #de2eaba

It works. Pleasure is all mine. thank you:)

it works, thanks.


remove unused variables

Signed-off-by: giantcroc<EMAIL_ADDRESS>
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

lgtm
/cc @phlax need start a clean process for this case? I guess there are some -Wunused-but-set-parameter warnings left.

/retest

/retest

/retest


Dask core data

core_data should be a function, not a read-only class property.

Ping @djkirkham and @lbdreyer ...

@bjlittle could you provide a bit of justification for this change?

@dkillick Yes, it is just a misuse of @property, and if we don't change it now, it will never be changed.
I believe that we should restrict our use of read-only properties, particularly if they are not writable. Being a read-only property, it's not clear whether this property can be assigned to for the users perspective of the API (and for developers too). Making it a function, then it's clear that it cannot be used as an assignable token. For example, that's why cube.lazy_data is a function and not a read-only property`.
Your not going to be tempeted to do cube.core_data() = data, but you would with cube.core_data = data.
I'm sure that @pp-mo has some strong opinions on this.

Thanks @bjlittle, very insightful. I guessed it was to do with how/when/why we use @property attributes. but it is good to get your reasoning too.

I'm sure that @pp-mo has some strong opinions on this.

Maybe we should merge it before he gets the chance to air them!! :wink: :innocent:

@dkillick Cool ... I think that @pp-mo is strongly in favour of not having read-only properties for the sake of them, and that they should be functions ... but that's me putting words in his mouth :wink:

@dkillick To be honest, my next move is to remove the cube.core_data method ... it's a convenience method on a public API that I believe we can live without. The Cube really is a bit of a god class as it is, and doesn't need further bloat.

Thanks @bjlittle - a nice tidy to the API.

"just one more wafer-thin mint Mr. Creosote"

I think you'll find it's "waffer-thin" :nerd_face:

my next move is to remove the cube.core_data method

My only question about doing that is how, from a cube, will you then access the 'whatever-the-current-data-is-as-it-is' object -- that is, get lazy data if data is currently lazy, or get real data if the data is currently realised?

What's a waffer?

I think you'll find it's "waffer-thin" :nerd_face:

See dictionary wafer ... surely :stuck_out_tongue_winking_eye:

@QuLogic an odd pronunciation of the word "wafer". See this Monty Python clip which started it all off...

I'm sure John Cleese pronounces it really weirdly...

@dkillick A-ha! You confused me with some subtle, cheeky humour ... gets me every time :smile:

Anyway, now that we've got to the bottom of all that, did you have any thoughts on my earlier comment @bjlittle?

@dkillick Yes, okay ... back to being serious (for now) ...
Outside tests, there's actually only a couple of places in the code-base that we use cube.core_data() ... I'm of the opinion that ...
if cube.has_lazy_data():
    data = cube.lazy_data()
else:
    data = cube.data

is no hardship ... what do you think?

only a couple of places in the code-base that we use cube.core_data()

I'm more interested in user-land at this point. I think that as a user I'd like a quick easy (cube?) method to get the data as it currently is. I suspect that if we dangle your suggestion above to users:

they'll go off and write their own utility function to do exactly the above, or
duplicate the above code everywhere, or
not understand the subtlety and end up calling cube.data everywhere and wonder why everything runs terribly.

Much as I'm a fan of removing bloat, I'm not sure cube.core_data() is the wafer (waffer) to not offer (even though I hugely dislike the naming)...

@dkillick ... I'm not suggesting that we also purge DataManager.core_data() nor the use of core_data by the fileformats - that's a convenience to us (iris, under the hood) that seems useful and appropriate.
I can't quite gauge the level of utility to end users ...
... and I so dislike the name of cube.core_data also.


Deleting project that is currently in use results acorn loosing context of all existing local projects.

acorn version v0.5.0-rc3-23-g34eb244+34eb2440
Steps to reproduce the issue:
Have couple of projects created ( hello2, hello3 in my case)
 % acorn project use hello2
 % acorn project
NAME                          DEFAULT   DESCRIPTION
acorn.io/sangee2004/acorn
acorn.io/sangee2004/mytest1
acorn
hello2                        *
hello3
 % acorn project rm hello2
hello2
 % acorn project
NAME                          DEFAULT   DESCRIPTION
acorn.io/sangee2004/acorn
acorn.io/sangee2004/mytest1

At the point , project acorn and hello2 are not seen by acorn anymore.

This issue also manifests in uninstall/install use case.
I was in the context of a project that I had created and then executed the following commands:
acorn uninstall
acorn install
After this , any new project that I created was not listed in  acron project . When I tried to run the app , I realized that we are still in the context of the project that was created before the uninstall.
 % acorn run -n mytest .
  ✗  ERROR:  namespaces "newproj" not found

newproj was the project context  when uninstall was done.

https://github.com/acorn-io/acorn/pull/1111

Tested with acorn version v0.5.0-rc3-48-g7e333e6+7e333e6f
Deleting project that is currently in use , results in project being deleted and acorn project becoming the default project.
bash-5.2$ acorn project
NAME                            DEFAULT   DESCRIPTION
acorn.io/sangee2004/acorn
acorn.io/sangee2004/mynewproj
acorn.io/sangee2004/mytest1
acorn
test1                           *
test3
bash-5.2$ acorn project rm test1
test1
bash-5.2$ acorn project
NAME                            DEFAULT   DESCRIPTION
acorn.io/sangee2004/acorn
acorn.io/sangee2004/mynewproj
acorn.io/sangee2004/mytest1
acorn                           *
test3

Deleting acorn project when it is in use , results in no project being set as default (or acorn which is deleted to still be the default project).
bash-5.2$ acorn projects
NAME                            DEFAULT   DESCRIPTION
acorn.io/sangee2004/acorn
acorn.io/sangee2004/mynewproj
acorn.io/sangee2004/mytest1
acorn                           *
hello2
hello3
test3
bash-5.2$ acorn project rm acorn
acorn
bash-5.2$ acorn project
NAME                            DEFAULT   DESCRIPTION
acorn.io/sangee2004/acorn
acorn.io/sangee2004/mynewproj
acorn.io/sangee2004/mytest1
hello2
hello3
test3
bash-5.2$ acorn run -n testme .
  ✗  ERROR:  namespaces "acorn" not found

Should we not allow acorn project to be deleted ?

User should be allowed to delete the acorn project. It is reasonable to fall back to it if you delete your current project.
The error message in the second scenario could/should be better.


Direct users to better deployment method when zip is too large

Output from my attempted zip deploy. I'm assuming this means the zip is too large to upload?
Do yall know what the size limit is? I'm guessing there is nothing we can do about this, but could we add an error message that suggests using a different deployment method?
11:36:56 staticsite-tutorial: Creating zip package...
11:37:53 staticsite-tutorial: Starting deployment...
Error:
413 Request Entity Too Large

413 Request Entity Too Large
nginx

It was back in October, but I've successfully deployed a 1.4GB folder on a B1 (Basic: 1 Small) app service plan, which resulted in a 250 MB zip file. But no - I don't know the exact upper limit
I assume you're using the standard deployment and not local git deployment? Did you see this message when you deployed?

It only applies for node projects at the moment, but it will exclude the node_modules folder when deploying, which would result in a smaller zip file. You can see more info here: https://github.com/Microsoft/vscode-azureappservice/blob/master/README.md#configuring-zip-deploy

Mine is 1.1GB. I'll remove the node_modules folder and try again, but I'm pretty sure it's a bunch of images and static content that make this site so big.

Ah interesting - well the Kudu repo would be the right place to file an issue about the root problem (I couldn't find an existing issue about large deployments): https://github.com/projectkudu/kudu
I'll leave this issue open to discuss possible warnings or other things we can do from the extension

What is the root problem? That kudu can't handle files of that size? I admittedly don't know how this works under the covers. What is actually doing the file transfer?

I'm pretty sure Kudu is just an ASP.NET app. It's using the basic System.Net.Http.CopyToAsync method and would inherit whatever limitations that has: https://github.com/projectkudu/kudu/blob/master/Kudu.Services/Deployment/PushDeploymentController.cs#L140

This issue has become stale and is at risk of being closed. The community has 60 days to upvote the issue. If it receives 5 upvotes we will keep it open and take another look. If not, we will close it. To learn more about how we handle issues, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this issue has received less than 5 community upvotes and we closed it. Still a big Thank You to you for taking the time to create it! To learn more about how we handle issues, please see our documentation.
Happy Coding!


How to wrap the Playground content?

How am I able to wrap the Playground children with my own ThemeProvider?
Description
I am using theme-ui within my component library, creating my own Playground component and wrapping that with my theme provider isn't ideal as it is then extending the docz theme, which I would prefer not to do.

Disregard, found an example which should fit my use case!


Fix broken link in python repo

Fix broken link flagged by the link checker.

/check-enforcer override


Add functionality to change settings

It should be possible to change settings with this version of the API, so let's implement a way to do so.
Currently getting this error: AttributeError: DynamicClient instance has no attribute 'settings'

added by @mahtin.


ci: fix release

Similar to https://github.com/splunk/pytest-splunk-addon/pull/542

:tada: This PR is included in version 6.0.1 :tada:
The release is available on:

v6.0.1
GitHub release

Your semantic-release bot :package::rocket:


[SPARK-7470] [SQL] Spark shell SQLContext crashes without hive

This only happens if you have SPARK_PREPEND_CLASSES set. Then I built it with build/sbt clean assembly compile and just ran it with bin/spark-shell.
...
15/05/07 17:07:30 INFO EventLoggingListener: Logging events to file:/tmp/spark-events/local-1431043649919
15/05/07 17:07:30 INFO SparkILoop: Created spark context..
Spark context available as sc.
java.lang.NoClassDefFoundError: org/apache/hadoop/hive/conf/HiveConf
	at java.lang.Class.getDeclaredConstructors0(Native Method)
	at java.lang.Class.privateGetDeclaredConstructors(Class.java:2493)
	at java.lang.Class.getConstructor0(Class.java:2803)
...
Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.hive.conf.HiveConf
	at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
	... 52 more

<console>:10: error: not found: value sqlContext
       import sqlContext.implicits._
              ^
<console>:10: error: not found: value sqlContext
       import sqlContext.sql
              ^

@yhuai @marmbrus

Merged build triggered.

Merged build started.

Test build #32182 has started for   PR 5997 at commit 61147e6.

LGTM

Test build #32182 has finished for   PR 5997 at commit 61147e6.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class CreateTableAsSelect(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32182/
Test PASSed.

Thanks for the PR. I am merging it to master and branch 1.4.

What about repl/scala-2.11?

@marmbrus , PR https://github.com/apache/spark/pull/6013 handled it

Awesome, thanks!


Grafana integration

@JaredTan95 @TinyAllen @hanahmily
We have known, Grafana is a beautiful monitoring. @hanahmily used to propose to use it as SkyWalking native UI, after evaluation, we said NO at that moment, because, it wouldn't support component interop very well, no trace and topology supported.
Now, we already SkyWalking native UI and @TinyAllen RocketBot, both are cool.
How about we bring Grafana into our ecosystem?
Of course, still no trace and topology(I assume, need to recheck), at least we could have all metrics.
For supporting that, I think we should

Evaluate how to do integration, is our graphQL APIs powerful enough? If yes, greate. Otherwise, Which kinds of API should we support?
Try to provide a Grafana setting files in the main repo or separated repo.

RocketBot has provided customize feature, this is not required.

原生的ui 和 grafana 还是有差距的


[CI] Perform snapshot based model result test

This PR implement snapshot based testing in CI such that the model output in float32 matches exactly as of Huggingface version.

Hi @simon-mo , what's the status on this PR? I updated it a bit based on the current master (PR here) I do observe different outputs for vllm vs HF for Deci/DeciLM-7b. Example below:
prompt: vLLM is a high-throughput and memory-efficient inference and serving engine for LLMs.
HF: vLLM is a high-throughput and memory-efficient inference and serving engine for LLMs. It is designed to be a drop-in replacement for HuggingFace's Transformers library, and it is compatible with all Transformers models.\nLLM is a high-throughput and memory-efficient inference and serving engine for LLMs. It is designed to be a drop-in replacement for HuggingFace's Transformers library, and it is compatible with all Transformers models.\nLLM is a high-throughput and memory-efficient inference and serving engine for LLMs. It is designed to be a drop-in replacement for HuggingFace's Transformers library
vLLM: vLLM is a high-throughput and memory-efficient inference and serving engine for LLMs. It is designed to be a drop-in replacement for HuggingFace's Transformers library, and is compatible with all of the same models and datasets.\nThe LLM is a high-throughput and memory-efficient inference and serving engine for LLMs. It is designed to be a drop-in replacement for HuggingFace's Transformers library, and is compatible with all of the same models and datasets.\nLLM is a high-throughput and memory-efficient inference and serving engine for LLMs. It is designed to be a drop-in replacement for HuggingFace's Trans

@sahilsuneja1, thanks! I don't have bandwidth to work on this PR at the moment so if you can create another PR based on your fixes that would be awesome. As you can see the primary issue in the CI testing is that it runs out of memory even with --tensor-paralle-size 2 on our CI machine (L4x2), this is quite weird because I was able to run the test locally on the same hardware. If you can take over and iterate that would be appreciated!

Got it, thanks @simon-mo, will do

Found the run history: https://buildkite.com/vllm/ci/builds?branch=simon-mo%3Amodels-snapshot-testing
Where's the OOM error?

Actually I'm going to close this PR because I think snapshot testing is still too brittle (need to update it on model by model basis). We should just get A100 machine to run these tests.

sorry about the back and forth!

No worries!


The use of the 8.8.1 version in the component-based mode

Android Sudio upgrade to the latest 3.1, the corresponding gradle is 3.1.0. when I used the ButterKnife8.8.1 version of the error, I used component-based development in library to use ButterKnife compilation does not pass, I changed to 8.4.0 times Could not get unknown.

hi, what is this solution? Do you know?

You have to use 9.0.0-SNAPSHOT from the code on master for now since the Android Gradle plugin made a breaking API change.

Now whether the main Module and other Module can use R. annotation uniformly. In the component-based mode, library Module will switch between Application and Library at any time, which will cause ButterKnife to be unable to use under Library.


Basic Support Claims index and show page

Context
This is more of a proof of concept, we don't have a claims index and show page designs yet.
Changes proposed in this pull request

Support Claims index and show
Support claims controller methods

Guidance to review

Go onto the review app
Sign in as support user
Go to claims tab
View the claims
Click on a claim
Click the back button

Screenshots

 As a support user, I should see a basic list of all the claims in track and pay


AML VNet integration + model registry

Description
As an InfoSec
I want to ensure that all serve infrastructure is vnet-integrated
So that the infrastructure is standard compliant and the data is secure
Acceptance criteria

[ ] AML in serve is vnet integrated

Questions:

Does the AML workspace need an isolated ACR?
Does this ACR need to be vnet isolated? (if it's only containing images that have dependencies to run a pipeline then I'd perhaps argue not)
How does the AML docker container get built?

Extra DNS zones required in bootstrap
    privatelink.api.azureml.ms
    privatelink.cert.api.azureml.ms
    privatelink.notebooks.azure.net

Branch: https://github.com/UCLH-Foundry/FlowEHR/tree/t-young31/aml_vnet

@damoodamoo , I am moving this back to the backlog.


OpenCL: Unify binary function handling in k.g., add prim support for binary functions

Summary
This PR:

unifies binary function in kernel generator
adds /prim support for fdim, fmax, fmin, fmod, hypot, ldexp,

Tests
Added with kernel generator macro. Added a version without integer only, because most functions do not have int-only overloads, and it's then ambiguous (OpenCL compiler error).
Side Effects
/
Release notes
OpenCL: Added /prim support for fdim, fmax, fmin, fmod, hypot and ldexp.
Checklist

[x] Math issue #1854

[x] Copyright holder: Rok Češnovar, Uni. of Ljubljana
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

I think it makes more sense to have binary functions in elt_function_cl.hpp than in binary_operation.hpp. When we talked about merging both, I meant modifying them so both functions and operations use the same base class. Generating code for function/operation would be a bit more complicated - something like what happens in reductions. Although I am not asking you to merge those, unless you want to.

Oh, ok, misunderstood then. I am not sure I want to merge operation/function here, that seems a bit more complicated and should be taken care of in a separate PR. I can open an issue and take care of that.

Closing this as this needs a complete re-do that is easier to just do from develop.


Update Migrations

Thank you! The database structure looks good to me. I like this a lot better without the morphs. 💉


IOS: "saveFile" throw an error if called not from main thread

Hello.
I am using this code
launch(Dispatchers.IO) {
            FileKit.saveFile(
                baseName = fileName,
                extension = "csv",
                bytes = bites
            )
}

in my ViewModel.
Android part works fine but iOS drops the error saying this should be called from main thread.
I believe main thread safety is library responsibility.
Since saveFile is a suspend function you could easily make it by writing
withContext(Dispatchers.Main) {
...
}

I will look into this now and see if it's as easy as running it in Dispatchers.Main

I'm going to push a fix soon 👌


zrythm: init at 1.0.0-alpha.19.0.1

Motivation for this change
Fixes the conflicts of https://github.com/NixOS/nixpkgs/pull/85553
I can the launch zrythm, but once I create a new project I get a error message:
(zrythm:51107): GLib-GIO-ERROR **: 17:55:25.811: ((null):(null)): g_settings_schema_source_unref() called too many times on the default schema source

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/packaging-zrythm/15530/1

superseded by #144547


Add response as json to callArtisan

fixes https://github.com/NoelDeMartin/laravel-cypress/issues/9

Hi there, thanks for contributing!
This looks good, but I think you are trying to do the following in your tests, right?
cy.artisan('route:list', output => {
    // do something with output here
});

I just run this code and this isn't working, you have to adapt the cypress command counterpart as well. You can see that in this other repository: https://github.com/NoelDeMartin/cypress-laravel/blob/master/src/commands.ts#L154 For example, if you compare with the cy.createUser command, which does return the user object, it's returning the result of the cy calls.
If you are not sure how to do it, let me know and I'll do it myself. I don't think it'd be too difficult.
By the way, I never used Artisan::output() but looking at your code I thought it'd return some object given that you want to use it in your test. But it seems like it's just returns a string. Do you mind telling me why do you need this in your tests? I'm curious about the use-case.

Ah, yes but I am using it with the then chaining like this:
cy.artisan('local:command --json').then((output) => {
    console.log(output);
});

This seemed to make sense to me to, as this is the same as how you would use a fixture or most other Cypress commands, with the chaining. Happy to implement as you prefer.
I am returning JSON as a string in the command. Like this:
app/Console/Commands/LocalCommand.php
        if($options['json']) {
            $this->info($events);
            return 0;
        }

It seems as though under the hood, cy.request can convert this string to an object.

Do you mind telling me why do you need this in your tests? I'm curious about the use-case.

Sure, so our website has "events". I am running a command to seed those events. Then I need to be able to visit the URL of the event just seeded. So returning the JSON from that command gives me an object with the URL.
Then I go to that page, I can also expect other data corresponds with the page layout, for example if the event has two tickets, there are two call to action buttons etc.
I considered using the factories to achieve the above, but we like to abstract out the logic of creating an event to a single command that is reusable.

Thanks for contributing @ianjamieson! Your changes are available in the latest version of the package :). I've also added an example test to the sandbox project: https://github.com/NoelDeMartin/laravel-cypress-sandbox/commit/0e74dd4fdd2c980409244a7bab39f0fa5f060235

Great news, thank you!


[Bug] Pull for Updated Snapshot is greyed out in bottom menu

Insomnia Version: 6.4.1
Operating System: MacOS

Details
I created a new snapshot and pushed. My dev team could not do a pull from the bottom sync menu. It was really confusing! Instead they had to click the top left menu and do the pull there. Should probably update the bottom menu to match

Responding here with a summary from our email thread
Currently, in the new sync beta, each member of the dev team needs to pull the project locally in order to start collaborating. This becomes confusing when migrating from the old sync system because they will have already had the workspace on their machine but it won't be tracking the remote project yet.
When a project is shared with you, it will show up in the main application dropdown below the local workspaces in a new section labelled "Remote Workspaces".

Also I should note that I did another push after they subscribed and he could not pull until he closed Insomnia and re-opened it

Hmm, that's not expected. I will keep an eye out for that issue.


bump gradle-jrebel-plugin from 1.1.2 to 1.1.10

Bumps gradle-jrebel-plugin from 1.1.2 to 1.1.10.

Release notes
Changelog
Commits

FINERACT-963

Yeah sure, LGTM! (Even though I doubt anyone still uses this? See also FINERACT-931.)
I've exceptionally "self merged" this PR, because technically I'm hereby reviewing and approving a change made by Dependabot so with green Travis, we got 4-eyes on this - my 2 eyes, and 1 each from Travis and Dependabot.. :rofl:


Extend the "forgot an await" check from 4.3 to do limited AST analysis to cover more cases

Suggestion

🔍 Search Terms

Promise await async "Did you forget to use 'await'?"
✅ Viability Checklist

My suggestion meets these guidelines:

[X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[X] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

The new always-truthy promise checks are amazing!
They're very much like @typescript-eslint's no-misused-promises.
As I was investigating https://github.com/typescript-eslint/typescript-eslint/issues/3403, one thing I noticed was that it looks like TypeScript does not do any AST interrogation for this feature - it just inspects the type of the expression.
It'd be great if we could extend this feature to do some AST traversal for common cases (logical expressions and ternaries) so that it can catch more errors.
To clarify what I'm asking for:

If an IfStatement's .expression is a BinaryExpression and the .operator is one of BarBarToken, AmpersandAmpersandToken, or QuestionQuestionToken, then TypeScript should recursively check the .left and .right of the node.
if an IfStatement's .expression is a ConditionalExpression, then TypeScript should recursively check the .whenTrue and .whenFalse of the node.

📃 Motivating Example

declare async function isValid(): Promise<boolean>;
declare const user: {isActive: boolean} | undefined;

// As of TS4.3
if (isValid()) {
//  ^^^^^^^^^
// This condition will always return true since this 'Promise<boolean>' appears to always be defined. (2801)
}

// with this proposal, the following would be an error as well:

if (user?.isActive && isValid()) {
//                    ^^^^^^^^^
}

if (user?.isActive || isValid()) {
//                    ^^^^^^^^^
}

if (user?.isActive ?? isValid()) {
//                    ^^^^^^^^^
}

if (user?.isActive ? isValid() : false) {
//                   ^^^^^^^^^
}
if (user?.isActive ? false : isValid()) {
//                           ^^^^^^^^^
}
if (
  user?.isActive
  ? someOtherCondition
  ? isValid()
//  ^^^^^^^^^
  : false
  : isValid()
//  ^^^^^^^^^
) {
}

💻 Use Cases

The current approach is a step in the right direction, but it could cover even more cases!
Workaround is to use @typescript-eslint/no-misused-promises which does these in-depth checks.

The new feature doesn't even for the example provided.
This code doesn't create any error, It seems the promise needs to be a variable.
I don't know this is a bug, or related to this issue you are discussing.
async function foo(): Promise<boolean> {
    return false;
}

async function bar(): Promise<string> {
    if (foo()) {
    //  ~~~~~
    // Error! (But actually nothing!)
    // This condition will always return true since
    // this 'Promise<boolean>' appears to always be defined.
    // Did you forget to use 'await'?
        return "true";
    }
    return "false";
}


Dynatrace data connectors paging not working as expected

Describe the bug
Dynatrace solution data connector paging does not seem to be working. Only the first page of events is ingested.
To Reproduce
Steps to reproduce the behavior:

Connect Dynatrace Runtime Vulnerabilities connector to a Dynatrace tenant with more than 10 reported vulnerabilities.
Wait till data ingested
query data and confirm only 10 events were ingested.

Expected behavior
Page correctly and ingest all available events returned by rest API
** More details **
Current polling config

initial rest request looks like this

api/v2/securityProblems?fields=+riskAssessment&pageSize=10&from=now-5m&to=now

but must look like this for second page

api/v2/securityProblems?nextPageKey=vu8XQiDj3q0SIU59....

currently testing this polling config

this is the raw rest response from same rest endpoint

LAWS only has 11 items since connected

Hi @keyoke, thanks for flagging this, we will soon get back to you on this.

Hello @keyoke, as this is the partner solution, we have connected with solution owners, we will update you once we hear back from them. Thanks.

Hi @v-sudkharat, I built this partner solution at Dynatrace, what I would need to know the correct paging config as the documentation for the codeless connector paging configuration is a little confusing and its hard to find any information for it.
Thanks

@keyoke Could you please refer this link for more information of paging configuration. Link to paging configuration here. Adding image for your reference:

@keyoke Could you please refer this link for more information of paging configuration. Link to paging configuration here. Adding image for your reference:

Thanks I have read the documentation and as mentioned above its not clear and does not work as expected would require clear explanation. Many thanks

@keyoke For more information on this, I assist you to contact Dynatrace support. Dynatrace offers support for this solution.

Ok, I discovered another issue with the polling config, pagingType was incorrectly set to "PageToken", its odd that when deploying this connector no error is raised for the non-existent paging type? As far as I could see this meant that paging was ignored completely. I have set the pagingType to "NextPageToken" and now I see the following when connecting the Data Connector to a data source, my initial assumption was correct that its using an invalid URL when requesting subsequent pages of data.

Here we can see the json response served by the rest endpoint
{     "error": {         "code": 400,         "message": "Constraints violated.",         "constraintViolations": [             {                 "path": "fields",                 "message": "must not be used in combination with nextPageKey query parameter.",                 "parameterLocation": "QUERY",                 "location": null             },             {                 "path": "from",                 "message": "must not be used in combination with nextPageKey query parameter.",                 "parameterLocation": "QUERY",                 "location": null             },             {                 "path": "to",                 "message": "must not be used in combination with nextPageKey query parameter.",                 "parameterLocation": "QUERY",                 "location": null             },             {                 "path": "pageSize",                 "message": "must not be used in combination with nextPageKey query parameter.",                 "parameterLocation": "QUERY",                 "location": null             }         ]     } }
My question to the Microsoft team is how can I configure the sentinel data connector to only include the nextPageToken in subsequent http requests?

Hi @keyoke, we are connecting with our internal team and once we get any information on this, we will update you.

Hello @keyoke, as per discussion with our internal team. Please remove "pageSize" parameter, as default value for "pageSize" is 100. Regarding pagingType we are following with team.

Hello @keyoke, as per discussion with our internal team. Please remove "pageSize" parameter, as default value for "pageSize" is 100. Regarding pagingType we are following with team.

Hello, this does not help as the dynatrace api has max page size of 10 for this endpoint, if I set it to a 100 paging still wouldn't work anyway due to incorrect URL querystring.
Thanks

Hey @keyoke, we are following up with team and once we get response, we will connect with you. Thanks

Hi @keyoke, we are still waiting to hear back from concern team. Thanks

Hi @keyoke, since still you are facing the paging issue, we recommend moving to the new CCP API. It is currently in private preview, but we plan to move to public soon and deprecate the old API. Attached is the new API documentation and if needed we will be happy to assist you in building the connector.
DataConnectorDefinition API.pdf
DataConnector API.pdf
Create a codeless connector for Microsoft Sentinel.pdf

Hi @keyoke, we have reached out to the concerned team, will update you once we hear back from them, thanks!

Hello @keyoke, please refer this API link which has more details for a reference: - https://www.dynatrace.com/support/help/dynatrace-api/environment-api/events-v2/get-events
Please let us know if this helps.

Hello @keyoke, please refer this API link which has more details for a reference: - https://www.dynatrace.com/support/help/dynatrace-api/environment-api/events-v2/get-events
Please let us know if this helps.

No it doesn't help  not sure you understand the problem?
Thanks

Hi @keyoke, are you facing issue while retrieving next page data using "nextPageKey" property? Could you please share the API URL that you are using. Thanks!

Hi @keyoke, are you facing issue while retrieving next page data using "nextPageKey" property? Could you please share the API URL that you are using. Thanks!

initial rest request from the codeless connector looks like this
api/v2/securityProblems?fields=+riskAssessment&pageSize=10&from=now-5m&to=now
When second page is retrieved it must look like this
api/v2/securityProblems?nextPageKey=vu8XQiDj3q0SIU59....
But it does not as the codeless connector uses invalid request which looks like this

Hello @keyoke, as per communication with concern team, they are going to evaluate and have a fix by end of this month. Thanks!

Hello @keyoke, as per communication with concern team, they are going to evaluate and have a fix by end of this month. We will let you know once we will have any updates. Thanks!

Ok many thanks!

hello @v-sudkharat any news about the fix? thanks

Hi @keyoke, we are waiting for the response from concern team about the fix, we will update you once we hear back from them. Thank you for your cooperation.

Hello @keyoke, we received update from concern team, please expect an update by 14-09-2023. Thanks

Hello @keyoke, we received the response from concern team, The fix is now deployed. Please use below paging config for your use case:

please let us know if you are facing any issues. Thanks

Hi @keyoke, hope you are doing well. Just wanted to check if you got a chance to look at the above comment. Thanks!

Hi @keyoke, hope you are doing well. Just wanted to check if you got a chance to look at the above comment. Thanks!

I have made the required changes here and tested but it does not seem to work, has this change been rolled out to all regions?
az sentinel data-connector list --resource-group test --workspace-name testsentinel

Hi @keyoke, hope you are doing well. Just wanted to check if you got a chance to look at the above comment. Thanks!

Hi @v-sudkharat , it does not seem to be working  I made the changes to the connector json, I can see these changes reflected in the generated mainTemplate.json on packaging but the paging behaves exactly as before.

if I run following to check what is deployed by this template the new json property is missing
 az sentinel data-connector list --resource-group test --workspace-name testsentinel

Hi @keyoke, we are checking this issue and also connecting with the concern team, expect an update by 20 Sep.

hello @v-sudkharat any news?

Hello @keyoke, our concern team is working on fixing this issue. Once we receive an update, we will let you know. Thanks!

Hi @keyoke, could you please share your mail id with us? so, the concern team reach out to you to get the information they require. Thanks!

@keyoke, we receive an update from concern team, from logs they can see that they are processing successfully. could you please let us know if you are still facing issue? so, we can share the Information with team. Thanks!

Hi @keyoke, we are checking this issue and also connecting with the concern team, expect an update by 20 Sep. Thanks

Hello it's been some time and have not received any feedback

@keyoke, we receive an update from concern team, from logs they can see that they are processing successfully. could you please let us know if you are still facing issue? so, we can share the Information with team. Thanks!

Hello @v-sudkharat  I see what the issue is the nextpagekey for some reason includes encoded quotes(%22) when you request the next page, only the value should be provided not a quoted string.

this is the raw json response

Hi @keyoke, thanks for sharing the information, could you please share your mail id with us? so, the concern team can reach out to you to get the information they require. Thanks!

Hi @keyoke, thanks for sharing the information, could you please share your mail id with us? so, the concern team can reach out to you to get the information they require. Thanks!

Sure Gareth.Emslie{at}dynatrace.com

@keyoke, thanks!

@v-sudkharat have tested fix applied by MS team, all seems to work. changes applied in link PR

Hi @keyoke, based on last email conversion, just want to know should we start to review the PR? if no, please can you Draft the PR.
Thanks!

@v-sudkharat yes please review PR at your earliest its now working again as expected

Hi @keyoke, thank you for your response, we will review your PR (https://github.com/Azure/Azure-Sentinel/pull/9148) and we will share updates on PR comment chat. Thanks!


Inline editable dropdown issue with Bootstrap

When doing inline editing on the grid with bootstrap theme, on a column of type 'dropdown', a JS error is thrown. Here's an example: https://jsfiddle.net/ShivangGupta/cb6sodL0/
The error is:

I'm new to this library. So, perhaps I'm doing something wrong. But I've looked at many examples, and it seems like a bug. If not, can you please let me know what changes I can do to make it work?
Thanks!

We don't support https at code.gijgo.com. https://code.gijgo.com/1.5.1/js/gijgo.js is invalid url, http://code.gijgo.com/1.5.1/js/gijgo.js is valid. I'm using https://cdn.rawgit.com/atatanasov/gijgo/master/dist/combined/js/gijgo.min.js in my jsfuddle examples which is the latest dev build.
https://jsfiddle.net/user/atatanasov/fiddles/

I'm not sure if the issue is due to the use of HTTPS. On my local machine, I'm using just HTTP, and still getting the same error. Unfortunately, jsFiddle doesn't support resources over HTTP, so I couldn't create the example with HTTP.
I've also tried out the latest dev build that you pointed out (https://cdn.rawgit.com/atatanasov/gijgo/master/dist/combined/js/gijgo.min.js), and it's still not working for me.


docs(router): new expressions flavor in 3.7

Description
KAG-3927

Testing instructions
Preview link:
Checklist

[x] Review label added
[x] Conditional version tags added, if applicable.

We also need a new app/_src/gateway/reference/configuration/configuration-3.7.x.md to modify the entry router_flavor, but I have no idea about how to do it.

We also need a new app/_src/gateway/reference/configuration/configuration-3.7.x.md to modify the entry router_flavor, but I have no idea about how to do it.

This will be updated automatically, as long as you have made the changes directly in kong.conf.default.

We also need a new app/_src/gateway/reference/configuration/configuration-3.7.x.md to modify the entry router_flavor, but I have no idea about how to do it.

This will be updated automatically, as long as you have made the changes directly in kong.conf.default.

Here it is: https://github.com/Kong/kong/pull/12950


update upstream

update upstream
fixes

#1  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @berdim99 and the rest of your teammates on  Graphite


fix(@jest/types): infer each types correctly when the table is a tuple or array

From https://github.com/facebook/jest/pull/13360#discussion_r985275338
Summary
The type of each table wasn’t inferred correctly in cases if the table was passed as a tuple or array. This PR fixes the bug.
Test plan
Type tests adjusted.

Looks right now:


Add documentation to Charmhub

Description
Adding documentation to Charmhub for tls-certificate-interface library placeholder charm.
Checklist

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have made corresponding changes to the documentation.
[ ] I have added tests that validate the behaviour of the software.
[x] I validated that new and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.
[ ] I have bumped the version of any required library.

Empty folders are deleted.


Feature Request - Pull Subdomains from SANS field in TLS Certificates

Hi great tool, I often find that you can pull additional sub-domains via the alternative names field in a cert.

E.g. pull the example.com cert, find the SANS (Alternative Names) Domains, some of those are sub-domains and a handy way to find more sub-domains

I am implementing your request right now. I will be in the next commit.

This feature is in the latest release, so I'm closing the issue. Thank you for the request.

Thanks Jeff, I’ll take a look and add another request soon :-)
On Thu, 15 Mar 2018 at 12:38 am, Jeff Foley<EMAIL_ADDRESS>wrote:

Closed #16 https://github.com/caffix/amass/issues/16.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/caffix/amass/issues/16#event-1522251840, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AMz6wrUltLEdODg54yKPx-4_pLNwYexlks5tebfvgaJpZM4Sq4jI
.