(Request)PLZ integrqte autohide ?

Hello i whould lov it if you could integrate the code at https://github.com/MrOtherGuy/firefox-csshacks/blob/master/chrome/autohide_toolbox.css
I also reduce the urlbar height

That's a good suggestion but I think I'll go with autohiding tab bar.


Improve channel handling

Here are the code changes that were decoupled from the previous pull request.

This change is

Hi @ZeroXLR, it seems to me that the code is functionally similar to the previous code and I also find the previous version easier to read. Is there a specific reason you want this to be merged in?

@veeableful To explain my two intentions:

My first intention is straightforward: there is no need to make a new done channel in every Do(..) call; one should be enough to handle all of them.

My second intention is unfortunately more vague: I was trying to keep callQueue uninitialized before Main(..). My thinking was, we could use this fact to panic if Do(..) is called before Main(..). Right now, doing things out of order causes an infinite loop which is not the best way to signal an error.

I think with this approach, there might be an issue where the done signal the Do() function is waiting for comes from different Do() function if you run multiple of them in goroutines. But your second intention makes sense. I'm wondering if we should just panic by checking if the callQueue is nil in the Do() function.

Regarding done, does it matter if the signals are mismatched? As long as the each signal corresponds to each f func() sent to callQueue, there shouldn't be a problem. If the second Do() blocks for the f of the first Do(), then the first Do() will simply block for the f of the second Do(). At least that is my thinking on the matter.
Regarding the second issue, I am trying to get around checking for nil in every Do() call. After all, the checking only needs to happen once. I could declare an unexported callInMain function variable which Do() calls. This variable is initially set to a function that panics. However, inside Main(), I can initialize it to its real purpose. Do you want me to submit a new pull request with this change?

@ZeroXLR, there might not be a problem but I think the code shouldn't lie. Unless it is proven to fix a problem or noticeably improve the performance, I'd say it's not worth changing a working function. I'm willing to change my mind if it is proven to be a worthwhile change, of course.
I'm having second thoughts about the Do() function actually. I think it's okay as it is since Do() are only needed when calling the SDL functions inside goroutines for which they can reference the examples, and like you say, it's a one-time thing. Plus they can read the comments you have written :)


Console spam

it disappeared when I only kept the ESP function

It is spamming the console because the server is trying to execute console commands to try and detect if you have the admin flag on or not. It is spamming commands like "Noclip" and if your stance changes it will instantly ban you.

它正在向控制台发送垃圾邮件，因为服务器正在尝试执行控制台命令以尝试检测您是否打开了管理员标志。它正在发送垃圾邮件命令，例如“Noclip”，如果您的立场发生变化，它将立即禁止您。

I see. thx a lot  :)


A space should be added after a dot

What article on docs.github.com is affected?
Managing a custom domain for your GitHub Pages site
What part(s) of the article would you like to see updated?
For a better format, there should be a space after the dot that sentence "For more information about how to create the correct record, see your DNS provider's documentation." ends with.
Additional information

Pull request opened as #1100.

Closing this issue as I've now merged the related PR.
Thanks again 👍🏻


stats_prefix.c: Check for NDEBUG before using total_written variable

When using NDEBUG assert macro is ineffective which is caught by latest
clang and reports that total_written is set but unused. Therefore check
for NDEBUG to make sure assert is used only when its effective
Fixes
error: variable 'total_written' set but not used [-Werror,-Wunused-but-set-variable]
size_t size = 0, written = 0, total_written = 0;
^
Signed-off-by: Khem Raj<EMAIL_ADDRESS>

thanks!

I think most/all cases in the code that check for a debug build state actually look for MEMCACHED_DEBUG?

MEMCACHED_DEBUG

how  do we define it ? if it is not based on NDEBUG then we can not use it because libc uses NDEBUG to decide the fate of assert macro, so we better use that

Out in 1.6.10


GE error breaking on GET Profile

Describe the bug
A clear and concise description of what the bug is.
GET https://graph.microsoft.com/beta/me/profile
To Reproduce
Steps to reproduce the behavior:

Go to GE.
Open browser devtools and go to the Network tab.
Submit GET https://graph.microsoft.com/beta/me/profile.
Observe the Run Query button freezes and no response is returned.
Look at the Network tab and see the call to the Profile API. You should see content like this in the response:

{"@odata.context":"https://graph.microsoft.com/beta/$metadata#users('d09d0edb-94c4-4948-a9e4-5dd923777d4b')/profile/$entity","id":"profileId","addresses@odata.context":"https://graph.microsoft.com/beta/$metadata#users('d09d0edb-94c4-4948-a9e4-5dd923777d4b')/profile/addresses","addresses":[],"anniversaries@odata.context":"https://graph.microsoft.com/beta/$metadata#users('d09d0edb-94c4-4948-a9e4-5dd923777d4b')/profile/anniversaries","anniversaries":[],"websites@odata.context":"https://graph.microsoft.com/beta/$metadata#users('d09d0edb-94c4-4948-a9e4-5dd923777d4b')/profile/websites","websites":[],"educationalActivities@odata.context":"https://graph.microsoft.com/beta/$metadata#users('d09d0edb-94c4-4948-a9e4-5dd923777d4b')/profile/educationalActivities","educationalActivities":[],"emails@odata.context":"https://graph.microsoft.com/beta/$metadata#users('d09d0edb-94c4-4948-a9e4-5dd923777d4b')/profile/emails","emails":[{"address":"mmainer@microsoft.com","displayName":null,"type":"main","allowedAudiences":"everyone","createdDateTime":"2020-06-30T16:35:37.9549664Z","inference":null,"lastModifiedDateTime":"2020-06-30T16:35:37.9549664Z"{
  "error": {
    "code": "InternalServerError",
    "message": "The property 'lastModifiedBy[Nullable=False]' of type 'microsoft.graph.identitySet' has a null value, which is not allowed.",
    "innerError": {
      "date": "2020-07-01T17:43:06",
      "request-id": "5d9328f2-0c42-4680-bf4c-b514de34929e"
    }
  }
}{
  "error": {
    "code": "InternalServerError",
    "message": "Unexpected end when deserializing object. Path 'emails[0].lastModifiedDateTime', line 1, position 1143.",
    "innerError": {
      "date": "2020-07-01T17:43:06",
      "request-id": "5d9328f2-0c42-4680-bf4c-b514de34929e"
    }
  }
}

Expected behavior
GE handles this type of error more gracefully by passing through the error.
This was brought up by: https://github.com/microsoftgraph/msgraph-beta-sdk-dotnet/issues/129. They are opening an incident on this issue.
This occurred while signed in with an org account.
Screenshots

AB#6254

@thewahome @ElinorW the task here is to make GE better error reporting.

Closing this as the error was handled outside of GE


losses become nan after epoch 1

I just use the cov-weighting in my training code
it turns out that losses become nan after epoch 1
Would I ask have you ever encountered this condition before?

Hi,
No, I haven't seen that before.
Could it be one of your losses approaches zero in the first epoch? I think that if it does, maybe you could get unstable behaviour at line 56. Potentially, adding a small constant value (1e-8 for example) to the denominator could alleviate those problems.
However, if you do have a loss that approaches zero that quickly, it may not be a very informative loss to begin with?
Regards,
Rick

This is exactly the problem. Thank you.


[Material] Fix TextDirection and selected thumb for RangeSliderThumbShape and RangeSliderValueIndicatorShape

Description
Expose the RangeSlider's TextDirection in the RangeSliderThumbShape's abstract paint() method, and ensure that start and end thumb are non-null when being passed to the thumb and value indicator shape paint methods.
Related Issues
closes https://github.com/flutter/flutter/issues/34360
Tests
This change exposes a parameter for custom subclasses, but does not affect any behavior.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[x] Yes, this is a breaking change (Please read Handling breaking changes). https://groups.google.com/forum/#!topic/flutter-announce/6P4sm0Yr_ng
[ ] No, this is not a breaking change.

Does it make sense to add a test for this? Otherwise LGTM 👍

I can't think of any test of value to add for this since its within the custom painters, and the default painter does not use these params

Sounds good to me.


The code to provide a city block tracker

See title. WIP.

I'm getting this error:
Error while running event TLBE::on_gui_selection_state_changed (ID 60)
__TLBE__/scripts/gui.lua:1560: attempt to index field 'tlbe-tracker-cityblock-size-x' (a nil value)
stack traceback:
	__TLBE__/scripts/gui.lua:1560: in function 'updateTrackerConfig'
	__TLBE__/scripts/gui.lua:1507: in function 'createTrackerConfigAndInfo'
	__TLBE__/scripts/gui.lua:459: in function <__TLBE__/scripts/gui.lua:408>

I'm not quite sure why it is happening. I copied and adapted the code for the area tracker, so I am not sure why it can find the area tracker fields but not the city block fields.

You put the city block GUI inside its own 'flow' (here) and on line 1560 you are reading from the 'main' tracker flow (trackerInfo). So your field is not found (nil) and you call text on it. Causing the error.
 You need to (re)sync it with the main/this repo.
With forks (but in general as well) you should create a 'feature branch' and work in there. So the main/master branch stays clean and is easy to sync.

Ready for review I think.

Thanks for the feedback. I'll work through them when the house is empty of rugrats.

Changing the decimal of the scale is very awkward: delete the 5 and a 0 pops up, so I cannot fill in 1.25 for example.

I've fixed the update function to round to two sf, just like the display function does. This should be fixed by that, but GUIs are eldrich horrors.

Changing the decimal of the scale is very awkward

Yes -- it is a weird interaction of the logic for setting the value into the field and setting the value into the data. I will have a cup of tea and maybe ask in discord, as I'm a little stumped as to how to fix it.

GUIs are eldrich horrors

I'm a bit stuck with this issue of the scale decimal value. I think I need to validate/set the value in some event that is not onTextChanged, as it is "fixing" the number on keypress, which means it gets reformatted on each keypress.

Possible solution pushed.

Agreed. Now, let's see if I can address this without more GUI eldrich horrors being invoked. I've pushed what I hope is a fix.

Also, the game hung on me once, had to force quit

It has hung on me a couple of times also. I have not been able to work out where or why it is hanging. My first thought was some interaction with the vs code plugin. I haven't yet had a hangup when running factorio free-range.

Currently without Internet due to a broken 4g mast in our area...

I would like to include this new tracker in the coming release, which I plan do to soon-ish so others can enjoy all the new additions to the mod.
Can you indicate whether you can spend some time on this PR, or shall I release without the new city block tracker?

Sorry - life happened. What's outstanding for this to be released?

Sorry - life happened

No worries. Same here, so I didn't do a release yet
I think the following issues are still open:

https://github.com/veger/TLBE/pull/52#discussion_r1248771509
https://github.com/veger/TLBE/pull/52#discussion_r1248772062
https://github.com/veger/TLBE/pull/52#discussion_r1248963651
https://github.com/veger/TLBE/pull/52#discussion_r1248968176

I think they are mostly small clean up changes

I think they are mostly small clean up changes

I think they are all now resolved.


tour: Slices (moretypes/18) Image will not render if fmt package is imported

Context: https://tour.golang.org/moretypes/18
User Environment: Google Chrome Version 51.0.2704.103 (64-bit) running on OS X El Capitan Version 10.11.4. Issue is also reproducible on Mozilla Firefox Version 45.0.2
Expected outcome: After figuring out the exercise and running the solution, an image of bluescale values will render.
Actual outcome: The image that is supposed to render in the above exercise will not do so if 'fmt' is imported; instead "IMAGE: " followed by a base64 encoded string is returned.
Steps to reproduce:
1. Import 'fmt'
2. Solve the exercise
3. Run the solution
An example of code that should work (and does if fmt and code using it is removed) is as follows:
package main

import (
    "golang.org/x/tour/pic"
    "fmt"
)

func Pic(dx, dy int) [][]uint8 {

    fmt.Println(dx)

    dySlice := make([][]uint8, dy)

    for outerIndex := range dySlice {
        dySlice[outerIndex] = make([]uint8, dx)

        for innerIndex := range dySlice[outerIndex] {
            dySlice[outerIndex][innerIndex] = uint8((innerIndex ^ outerIndex) * (innerIndex & outerIndex))
        }

    }
    return dySlice
}

func main() {
    pic.Show(Pic)
}

Here is what the output looks like:

As expected, if 'fmt' and any code using it is removed, the image renders:

I cloned this repo, and also used "go get golang.org/x/tour" ./tour
Both scenarios I can import fmt in my exercise, and use Print and Println with the image rendering successfully.
When using the web version, the image does not render when using Print or Println
on local,
go version go1.10.4 linux/amd64
OS: linux mint with all the latest updates,
browser: chromium.
I've done a diff of the files from "go get" and cloning the repo, nothing of note appears, just the .git files and logs
@ALTree not sure which version the web tour is running, could be a clue?


use esbuild to handle spec bundle as replacement for browserify or webpack

who do I replace browserify or webpack with esbuild to handle spec code bundles ?
and with support for typescript and so on.
Current behavior
only support browserify or webpack to handle typescript files
Desired behavior
use esbuild to handle typescript step definitions files
maybe can be integrated with https://github.com/bahmutov/cypress-esbuild-preprocessor
Versions

Cypress version: 9.2.0
Preprocessor version: 4.0.1
Node version: 16.13

Due to personal reasons, the previous maintainers of this package are stepping down and handing the reigns over to me, a long-time contributor to the project and a user of it myself. This is a responsibility I'm very excited about. Furthermore, I'd like to thank @lgandecki ++ for all the work that they've done so far.
Read more about the transfer of ownership here.
The repository has however moved and all outstanding issues are being closed. This is not a reflection of the perceived importance of your reported issue. However, if after upgrading to the new version, you still find there to be an issue, feel free to open up another ticket or comment below. Please make sure to read CONTRIBUTING.md before doing so.


Fix compilation when "nightly" feature is enabled

This commit just removes the references to the already removed sub-crates.

Thanks!


Mention an additional use of applications in the "Why do applications integrate with Azure AD?" section

[Enter feedback here]
Dear,
I think that it is worth mentioning that "Azure AD SP/Applications" can also be used as a 'holder' for a Custom Extension properties (or at least its definition).
Custom Extension Properties can be of

type "Application" : where apps will can a value assigned to that "new" custom extension properties
or
type "User" : where users can have a value assigned to that "new" custom extension properties

Thanks.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 573ed0d7-a678-1542-be5f-e7aa507d1ebc
Version Independent ID: 5b86b9fd-bef6-c86f-9f69-41add4c389b4
Content: How and why apps are added to Azure AD - Microsoft identity platform
Content Source: articles/active-directory/develop/active-directory-how-applications-are-added.md
Service: active-directory
Sub-service: develop
GitHub Login: @rwike77
Microsoft Alias: ryanwi

@YassineSOUABNI Thank you for your query. We will investigate and update the thread.

@YassineSOUABNI  Thanks for the feedback. We will engage the content development team for further investigation, they will verify and perform necessary changes in the document as needed.
@rwike77  Can you have a look at this ?

@YassineSOUABNI Thanks for the suggestion.  I added some info to this article.  #please-close


(#101) Avoid flicker of login/logout/denied buttons

Currently, the 3 login, logout and denied buttons are shown before that 2 of them are hidden, which causes an unpleasant flicker. This happens because the AngularJS code takes time to kick-in.
Adding the "ng-hide" class to them hide them by default. This way, only the correct button will appear, after a short moment.

I believe you are looking to us ng-cloak which does this exactly.  NgHide is made for generally hiding elements.  NgCloak could be applied to the root element on the template to prevent this.
https://docs.angularjs.org/api/ng/directive/ngCloak

Thanks for your answer @bramsk ! As I recall (this was last year), I did try to use ng-cloak. But it did not work because these buttons are part of a fragment that is included quite late in the construction process. At least, this was my theory (I'm not an AngularJS expert!). So this was the only working solution I found.


fix(DEVCOM.LuaJIT): remove version 2.1.19617

Package is no longer available.

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/DevelopersCommunity/cmake-luajit/releases/download/v2.1.1694940244/LuaJIT-2.1.19617-win64.msi
Response status code does not indicate success: 404 (Not Found).
(Automated message - build 748)


initialize SharedState without Default

Would you be open to changing the SharedState API not require use of Default for setting the initial value?  (This would also make it more like the RwLock API.)  In my case, I am using SharedState to wrap an object which I instantiate with a constructor called load because it needs to do filesystem IO.  I could make it implement Default, but I'd prefer not to have a Default implementation that does IO because I want it to be clear that creating new instances of this object should be done sparingly.  So I'd like to have some way to create a SharedState by passing in an initial value that I've already created.
I'd propose an API that better mirror's RwLock's API:
impl<Data> SharedState<Data> {
    pub const fn new(t: Data) -> SharedState<Data>;
}

impl<Data> Default for SharedState<Data> {
    fn default() -> SharedState<Data>;
}

Maybe a problem with that proposal that SharedState::default() is not const which I'm gathering is maybe a use case you want to make easy for Relm users?  If that's the case, maybe also adding pub const fn from_default() -> SharedState<Data> would solve that?  (I'm pretty new to Rust, and not very familiar with const and with when lazy initialized statics are needed.)
An alternative (or additional) proposal would be to leave the existing SharedState::new, and add impl<Data> From<Data> for SharedState<Data>.  Imo, this still leaves SharedState::new as being a bit weird for someone familiar with RwLock, but it would solve my need, and would avoid a breaking change to SharedState::new.
If there's agreement on an API change, I expect I'd be able to make a PR to implement it if that's helpful.

:+1: assuming no one else gets to it before then, I expect to have time to make the PR this coming weekend.


Volume Testing on the FHIR Core client app

Overview
We need to conduct Volume Testing to see how the app scales with a lot of data.  This testing will help highlight the various bottlenecks with the app.
Initial Test Data

300 Households
10 Patients per house hold
30 Tasks per patient

We can gradually increase the data set size as we optimize and improve.
Tasks

[x] Set up backend infrastructure
[x] Set up user assignment data + Gateway configuration
[x] Set up the dummy test data
[x] Conduct volume testing and document results

Device Specs
Phone - Techno Spark 7
RAM - 3GB
ROM - 64GB
Android Version - 11

WiFi - 20Mbps
Number of Households - 1025
Results

Initial Sync - 39:19.84
Loading "Add Household" form -00:02.57
Saving a Household - 0:45.06
Loading "Add HH member" form - 00:02.38
Saving a HH Member - 00:09.51
Load HH profile - 00.11.68
Load the All Households Register - 00:21.83

@Mstjamush Can you explicitly define the time format for the starts shared above? e.g. HH:MM:ss

@ellykits it's in HH:MM:ss format

@Mstjamush  can you share the same results for 10k households please?

@pld Let me generate the HHs and share

Observation on the Search Query:

It uses the same Index to sort by as the register
Removing the index improves the performance as well
Search performance latency is directly proportional to the size of the resulting data set

Opportunities for improvement

Change search index to a non String type index e.g. last updated
Remove the index entirely - search narrows down the records enough
Limit triggering the db search until a minimum limit of characters is input by the user e.g. 3 chars

Ticket to track performance optimizations on the FHIR SDK engine - https://github.com/google/android-fhir/issues/2547

For the form loading, after profiling MWCore made the following observations for the Registration form:

First time load of the Registration form is quite fast. Subsequent attempts take 12 to 13 seconds
Loading the Questionnaire resource from the DB seems to introduce this latency

We can implement a caching mechanism for the resources once loaded the first time and figure out an appropriate cache invalidation mechanism. This can be informed by various factors like we don't expect Questionnaire resources to change frequently during use.

Device Specs
Phone - SAMSUNG A12
RAM - 3GB
ROM - 64GB
Android Version - 12

_WiFi - 20Mbps
Number of Clients - 7661
Results

Loading the Find person Register - 1:36:33.93
Search Find Person Register - 1:13:25.87
Loading Register person form - 0:00:06.7
Saving a Register person - 0:00:07.66
Loading Record ART Number form - 0:00:03.36
Saving a Record ART Number - 0:00:04.39
Loading Clinical Stage and CD4 form - 0:02:21.29
Saving a Clinical Stage and CD4 - 0:00:15.31
Loading Welcome Service Newly Diagnosed form - 0:02:21.26
Saving a Welcome Service Newly Diagnosed - 0:00:06.49
Loading TB/Covid Screening - 0:00:07.61
Saving TB/COVID screening - 0:00:02.61
Loading Vitals Page -0:02:22.26
Saving Vitals - 0:00:06.88
Loading Index Case Testing - 0:01:30.72
Saving Index Case Testing - 0:00:04.67
Loading Guardian Regidtration - 0:02:24.05
Saving Guardian Registration - 0:00:03.37
Loading TB History and Regimen - 0:02:24.61
Saving TB History and Regimen - 0:00:13.27

Device Specs
Phone - SAMSUNG A12
RAM - 3GB
ROM - 64GB
Android Version - 12

_WiFi - 20Mbps
Number of Clients - 7661
Results

Loading the Find person Register - 0:11:42.49
Search Find Person Register - 0:16:47.76
Loading Register person form - 0:00:02.87
Saving a Register person - 0:00:06.14
Loading Record ART Number form - 0:00:02.66
Saving a Record ART Number - 0:00:04.39
Loading Clinical Stage and CD4 form - 0:00:02.91
Saving a Clinical Stage and CD4 - 0:00:3.82
Loading Welcome Service Newly Diagnosed form - 0:00:03.16
Saving a Welcome Service Newly Diagnosed - 0:00:05.16
Loading TB/Covid Screening - 0:00:02.24
Saving TB/COVID screening - 0:00:02.32
Loading Vitals Page -0:00:10.16
Saving Vitals - 0:00:03.62
Loading Index Case Testing - 0:00:02.37
Saving Index Case Testing - 0:00:04.52
Loading Guardian Registration - 0:00:03.05
Saving Guardian Registration - 0:00:02.90
Loading TB History and Regimen - 0:00:04.27
Saving TB History and Regimen - 0:00:02.96

Tests after refactors
Device Specs
Phone - SAMSUNG A12
RAM - 3GB
ROM - 64GB
Android Version - 12

_WiFi - 20Mbps
Number of Clients - 7661
Results

Loading the Find person Register - 0:00:27.05
Search Find Person Register - 0:00:03.65
One character search on Find Person Register - 0:00:02.97
Two character search on Find Person Register - 0:00:02.62
Loading Register person form - 0:00:05.71
Saving a Register person - 0:00:12.73
Loading Record ART Number form - 0:00:02.55
Saving a Record ART Number - 0:00:03.24
Loading Clinical Stage and CD4 form - 0:00:01.99
Saving a Clinical Stage and CD4 - 0:00:2.68
Loading Welcome Service Newly Diagnosed form - 0:00:02.66
Saving a Welcome Service Newly Diagnosed - 0:00:04.88
Loading TB/Covid Screening - 0:00:01.90
Saving TB/COVID screening - 0:00:02.18
Loading Vitals Page -0:00:10.98
Saving Vitals - 0:00:04.78
Loading Index Case Testing - 0:00:03.41
Saving Index Case Testing - 0:00:04.62
Loading Guardian Registration - 0:00:02.88
Saving Guardian Registration - 0:00:03.08
Loading TB History and Regimen - 0:00:03.71
Saving TB History and Regimen - 0:00:03.29

Tests after refactors (Includes cache on forms)
Device Specs
Phone - SAMSUNG A12
RAM - 3GB
ROM - 64GB
Android Version - 12

_WiFi - 20Mbps
Number of Clients - 7584
Results

Loading the Find person Register - 0:00:08.24
Search Find Person Register - 0:00:03.17
Loading Register person form - 0:00:03.94
Saving a Register person - 0:00:07.22
Loading Record ART Number form - 0:00:02.56
Saving a Record ART Number -
Loading Clinical Stage and CD4 form - 0:00:02.29
Saving a Clinical Stage and CD4 -
Loading Welcome Service Newly Diagnosed form - 0:00:02.16
Saving a Welcome Service Newly Diagnosed -
Loading TB/Covid Screening - 0:00:02.01
Saving TB/COVID screening -
Loading Vitals Page - 0:00:02.94
Saving Vitals -
Loading Index Case Testing - 0:00:02.29
Saving Index Case Testing -
Loading Guardian Registration - 0:00:02.40
Saving Guardian Registration -
Loading TB History and Regimen - 0:00:02.84
Saving TB History and Regimen -

Save forms has a questionnaire issue

was this performed on a version of the SDK with this PR included? https://github.com/google/android-fhir/pull/2565/files

Tests after refactors (Includes cache on forms)
Device Specs
Phone - SAMSUNG A12
RAM - 3GB
ROM - 64GB
Android Version - 12

_WiFi - 20Mbps
Number of Clients - 7584
Results

Loading the Find person Register - 0:00:40.43
Search Find Person Register - 0:00:02.87
Loading Register person form - 0:00:03.65
Saving a Register person - 0:00:09.24
Loading Record ART Number form - 0:00:02.27
Saving a Record ART Number - 0:00:02.75
Loading Clinical Stage and CD4 form - 0:00:02.49
Saving a Clinical Stage and CD4 - 0:00:03.53
Loading Welcome Service Newly Diagnosed form - 0:00:03.34
Saving a Welcome Service Newly Diagnosed - 0:00:08.11
Loading TB/Covid Screening - 0:00:02.68
Saving TB/COVID screening - 0:00:19.89
Loading Vitals Page - 0:00:08.42
Saving Vitals - 0:00:03.63
Loading Index Case Testing - 0:00:03.46
Saving Index Case Testing - 0:00:02.12
Loading Guardian Registration - 0:00:03.79
Saving Guardian Registration - 0:00:02.81
Loading TB History and Regimen - 0:00:04.02
Saving TB History and Regimen - 0:00:03.12

@Gental-Giant the issue was fixed

Interesting that load time jumped up so much

Update July 1st 2024

To be tested on main to generate new statistics for comparison

Device Specs
Tecno Spark 7
RAM - 3GB
ROM - 64GB
Android - 11

**_WiFi - 20Mbps
Number of House Holds - 938
```**

**Performance**

- Login (after initial sync) - 0:02:24.09
- Add House Hold launch - 0:00:03.75
- Add House Hold save - 0:00:24.70
- Add HH member launch - 0:00:26.85
- Add HH member save - 0:00:33.38
- WASH Check lauch - 0:00:02.70
- WASH Check save - 0:00:10.75
- Client Baseline Form launch - 0:00:04.58
- Client Baseline save - 0:00:09.35
- Child Routine visit form launch - 0:00:03.31
- child routine visit save - 0:00:08.31
- Immunization form launch - 0:00:02.55
- Immunization save -0:00:07.86
- Sick child asessment form launch - 0:00:03.30
- Sick child assessment save - 0:00:09.78
- HIV Pre-screen form launch - 0:00:02.56
- HIV Pre-screen form save - 0:00:06.01
- Tb screening form launch - 0:00:02.98
- TB screening form save - 0:00:11.43

All the profiling under this ticket are covered so closing this. We can open another ticket once we target a new profiling.


Delete ES docs on django delete

Issue number: N/A
Description of change
This:

adds a context manager that collects and deletes the objects from ES when they are deleted from the db
creates a search app that can be used to test generic logic

Checklist

[ ] Have any relevant search models been updated?
[ ] Have any relevant fixtures (fixtures/test_data.yaml) been updated?
[ ] Have any relevant select-/prefetch-related field lists in the views and search apps been updated?
[ ] Has the admin site been updated (for new models, fields etc.)?
[ ] Has the README been updated (if needed)?

Codecov Report

Merging #1011 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1011      +/-   ##
===========================================
+ Coverage    96.41%   96.44%   +0.02%
===========================================
  Files          206      207       +1
  Lines         5753     5799      +46
  Branches       544      551       +7
===========================================
+ Hits          5547     5593      +46
  Misses         142      142
  Partials        64       64

Impacted Files
Coverage Δ

...ahub/cleanup/management/commands/delete_orphans.py
100% <100%> (ø)
:arrow_up:

datahub/search/deletion.py
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2a7e01...45a3061. Read the comment docs.

Something else to consider is that the interaction search app does have a post_delete signal receiver, so we might need to disconnect some existing signal receiver while a Collector is active as well...

Something else to consider is that the interaction search app does have a post_delete signal receiver, so we might need to disconnect some existing signal receiver while a Collector is active as well...

True :/


Issue #271 annoying popup

Fixes #271

Seems OK for me. Just do that little change I proposed - and an extra test for guide_done? would be awesome :wink:  - and then merge


(#25316) Enable LZMA compression in Python SDK I/O

LZMA compression is standard in python but not one of the compression strategies included in the beam.io.{Read,Write}FromText PTransforms. openwebtext, for example, uses this compression. This PR addresses #25316 .

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Thanks for contribution. Would you mind also add the tests in https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/filesystem_test.py ?
e.g. https://github.com/apache/beam/blob/fd4ea9b6bcebfac1c161805fa8d741cf20cc38eb/sdks/python/apache_beam/io/filesystem_test.py#L339 and other places where compression types are enumerated
Besides, the code format check failure showing following message:
10:13:37 ************* Module apache_beam.io.filesystem
10:13:37 apache_beam/io/filesystem.py:276:62: C0303: Trailing whitespace (trailing-whitespace)
10:13:37 apache_beam/io/filesystem.py:968:0: C0304: Final newline missing (missing-final-newline)

Thanks for contribution. Would you mind also add the tests in https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/filesystem_test.py ?

I would love to. Thanks for the pointer.


Add tests for tasks list

Fixes #155

Pull Request Test Coverage Report for Build 454

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 71.288%

Totals

Change from base Build 448:
0.1%

Covered Lines:
1954

Relevant Lines:
2741

💛  - Coveralls


feat: add support for custom levels

feat(custom-levels): add levels to messageFormatFactory in order to handle pino customLevels

Checklist

[x] run npm run test and npm run benchmark
[x] tests and/or benchmarks are included
[x] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin
and the Code of conduct

nice work!


Tests refactoring - deprecating EvaluationModel

🚀 Feature

Deprecation of old trainer APIs (e.g., checkpoint_callback) and of EvaluationModel in favor of new APIs (e.g., callbacks) and BoringModel. Take PR  #4820 as an example.
This issue should be tackled one file at the time to allow better review process (as discussed with @Borda).
NOTE (1): Every test should use default BoringModel class or inherit BoringModel to add specific features (e.g., different optimizer) as discussed with @williamFalcon.
Motivation

Code refactoring, tests code-base will be cleaner and easier to extend/improve. New users can refer to tests as a documentation for pytorch-lightning usage and common practices.
Pitch
In the end, we will base tests only on BoringModel.

Alternatives

Additional context

Replacing old mixin-based EvaluationModel is essential and very needed, also as mentioned making it per file/case
On the other hand, I would make test API cleaning as a separate issue (if we re-write some test with BoringModel it shall always follow the latest API, but updating just test which already uses BoringModel shall be separate, btw, I think that this is almost fixed) 🐰
Also, it would be nice to do some test pruning - for some simple cases, fuser tested values together, which shall make testing faster as many tests need to instantiate Trainer and Model and run a few steps and SIMPLIFY navigation in tests as now it is a bit jungle... 🌴

Replacing old mixin-based EvaluationModel is essential and very needed, also as mentioned making it per file/case
On the other hand, I would make test API cleaning as a separate issue (if we re-write some test with BoringModel it shall always follow the latest API, but updating just test which already uses BoringModel shall be separate, btw, I think that this is almost fixed) 🐰
Also, it would be nice to do some test pruning - for some simple cases, fuser tested values together, which shall make testing faster as many tests need to instantiate Trainer and Model and run a few steps and SIMPLIFY navigation in tests as now it is a bit jungle... 🌴

I also suggest to add static types to move forward full-coverage of type checking. E.g.,
def foo(bar: str) -> int:
   return len(bar)

It's a function that receives a string and return an int. Mypy will check if this function is used improperly.

FYI, we already have an issue for it #5023 so maybe we can skip it from this issue description...

I also suggest to add static types to move forward full-coverage of type checking. E.g.,
def foo(bar: str) -> int:
   return len(bar)

It's a function that receives a string and return an int. Mypy will check if this function is used improperly.

FYI, we already have an issue for it #5023 so maybe we can skip it from this issue description...

@Borda what is left TODO here?

done :rabbit:


Docker ENV issue

I am working on an app for fun and messing around with docker deployments with now.sh. I have an env file though which when deployed is not accessible through the container. Here is the repo:
https://github.com/knipferrc/fitme
Not sure if its something to do with the express server running, is there a way to remove the express server? The reason its there is because when refreshing on a route I would get an error. I'd like to be able to deploy without needed to hard code all the strings in there before I deploy using my .env.production.local file.

Ended up using serve without docker and everything is working now.


Fix raw templates not being downloaded

Description

This PR fixes an error where raw template files are not being downloaded

Fixes: #2820
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):
How Has This Been Tested?

This was tested by adding a raw template to be downloaded from the UI

@blueorangutan package

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔debian. JID-1096

testing, very risk poor change (downloading/image store only.

Trillian test result (tid-1326)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26195 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3993-t1326-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_02_vpc_privategw_static_routes
Failure
167.82
test_privategw_acl.py

test_03_vpc_privategw_restart_vpc_cleanup
Failure
167.85
test_privategw_acl.py

test_04_rvpc_privategw_static_routes
Failure
224.70
test_privategw_acl.py

LGTM
Tested with  http://download.cloudstack.org/testing/CentOS-7-x86_64-GenericCloud-1511.raw.bz2 (temp abuse of the hosting, due to lack of availability of raw.bz2 images online on plain HTTP)
Works fine, downloaded, unpacked, and eventually Ready.

2 x approvals, automated regression tests fine, manual (fix) tests fine.
Merging based on ^^^


BFDOT aarch64-SVE-NEOV1 support

This PR adds support for the BFDOT instruction for performance comparison compared to BFMMLA on the Neoverse V1 CPU. Additionally, the cpuid APIs have been extended to provide querying of the VNNI/BFDOT/BFMMLA packing factor.

Other than the two minor nits I commented it looks good to me!


Valid code highlight breaks on long conditional (ternary) operator and in many familiar

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
Highlighting of the valid code breaks
Steps to Reproduce

Insert this code to your .php files

<?
/**
 *
 * Extract unique values ( from multidimensional array ) by using specific keys
 * @return array
 *
 */
function array_multi_unique_values($input_array, $v1, $v2 = false, $v3 = false, $v4 = false, $v5 = false, $v6 = false, $v7 = false, $v8 = false)
{
    if (is_array($input_array)) {
        $output_array = [];
        foreach ($input_array as $array) {
            $output_array[] = $array[$v1] . (!empty($array[$v2]) ? ', ' . $array[$v2] : false) . (!empty($array[$v3]) ? ', ' . $array[$v3] : false) . (!empty($array[$v4]) ? ', ' . $array[$v4] : false) . (!empty($array[$v5]) ? ', ' . $array[$v5] : false) . (!empty($array[$v6]) ? ', ' . $array[$v6] : false) . (!empty($array[$v7]) ? ', ' . $array[$v7] : false) . (!empty($array[$v8]) ? ', ' . $array[$v8] : false);
        }
        return array_unique($output_array);
    } else {
        return false;
    }
}

Set file type to PHP if necessary

Expected behavior: [What you expect to happen]
Code being highlighted the same way us on GitHub for example.
Actual behavior: [What actually happens]
It doesn't, here is the example in the screenshot:

Reproduces how often: [What percentage of the time does it reproduce?]
All the time
Versions
Atom Editor v1.13.1
You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.
Additional Information
Linux Fedora 25

Another example:

Thank you for reaching out!
We noticed that this is a duplicate of https://github.com/atom/atom/issues/1667. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


Treasure Pylon not working

Description
Treasure Pylon is not sorting items. Github would not allow me to send a .cfg file so I copied it and changed the extension to .txt.
Attachments Checklist
LogOutput.log
com.chebgonaz.ChebsNecromancy - Copy.txt

Good job renaming the config file and setting up the issue, thanks.
This is a bug I can fix in the next version.

Other problems in the log:
Teleport Everything is not working:
[Error  : Unity Log] MissingMethodException: long ZDOMan.GetMyID()
Stack trace:
TeleportEverything.Plugin+TeleportToPatch.Postfix (System.Boolean __result, Player __instance, UnityEngine.Vector3 pos, UnityEngine.Quaternion rot, System.Boolean distantTeleport) (at <f9cba39a82cc4b4893f9e0a070155dbb>:0)
(wrapper dynamic-method) Player.DMD<Player::TeleportTo>(Player,UnityEngine.Vector3,UnityEngine.Quaternion,bool)
(wrapper dynamic-method) Teleport.DMD<Teleport::Interact>(Teleport,Humanoid,bool,bool)
Teleport.OnTriggerEnter (UnityEngine.Collider collider) (at <2959d3c128e64c61a08dcc9bb6744ec3>:0)


Unprotected Comment Demo on http://www.reactrails.com/

There's a pretty unsavoury comment on the top of the demo page at http://www.reactrails.com/ right now.

+1 Good catch davemo.

I don't see anything. The comments get deleted nightly so I don't have to fix stuff like this.


Unify remote kernel finder with ServerUriStorage

With the introduction of the new remote finder and server picker experience, we might want to revisit how we are registering kernels from remote uris and what we store in ServerUriStorage

ServerUriStorage can contain following info

url list

user provided server urls
third party contributed server urls
local when users explicitly set the server to None from the server picker

currentServerId referring to the currently picked entry
localOnly referring to if we should connect to local only (❓)

Traditional workflow

LocalKernelFinder contributes all local kernels
RemoteKernelFinder checks ServerUriStorage#currentServerId and decides if/how to detect kernel specs/sessions

If the selected entry in ServerUriStorage is local, then it doesn't attempt to scan kernel specs/sessions.

New workflow

UniversalRemoteKernelFinderController creates a UniRemoteKernelFinder for all entries
Each UniRemoteKernelFinder follows the same logic as RemoteKernelFinder, if its uri is local, it contributes empty kernel specs/sessions.

It would be great if we can move local out of the ServerUriStorage and we can simply the RemoteKernelFinder ctor and registrations into

ServerUriStorage only holds server uri infos
Traditional remote kernel finder controller

Hold the currentSelectedUri info
Register/dispose remote kernel finder per currentSelectedUri update

New remote kernel finder controller

Register/dispose all remote kernel finders per ServerUriStorage#getUris

cc @IanMatthewHuff @DonJayamanne

Yeah, the current usage of ServerUriStorage is hacky given how I use it from the new experimental picker. I'm actually kinda intrigued on a concept like the ContributedKernelFinder moving up into the UI layer. From the perspective of the picker I wouldn't want to have to care about the difference between server / local / whatever. All that really matters is there is some thing X that provides kernels. Maybe a UriStorage isn't needed at all? Instead we are just working with a list of KernelSources some are local, or remote, or third party, ect... If something is added to the list it can control its own registration for kernel finding. So you could do something like an extensibility point that let you add kernels directly from another extension, instead of adding servers.

Instead we are just working with a list of KernelSources some are local, or remote, or third party, ect... If something is added to the list it can control its own registration for kernel finding.

We can consider moving off ServerUriStorage and store connection type/info in each ContributedKernelFinder instance and we store the list in memento. On window reload, we then create a list of ContributedKernelFinders from the cached list.

@rebornix lets have a chat about this, I think this is related to  Refactor/simplify Jupyter Connection here https://github.com/microsoft/vscode-jupyter/issues/11904

Write to old format and the new storage format
If users run into issues they opt out of experiment (new stuff is still in old storage as well)
Experiment to use either one storage formats


WIP: Setup screenshot tests

Still a WIP. The tests work locally. The issue seems to be the setup of the emulator on travis. The next step is to consider using Circle CI


feat: Feature Flag Component + Simplify the traversal for composability

Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

When adding feature flags, I sometimes replace an existing component with a new one. Therefore it would be neat if the <FeatureFlagged> component has a way to negate the condition or an else branch ("run this instead if the feature flag is disabled).

For example, we have this code right now:
    {isFeatureFlagActive('search-2-0') ? (
      <Route path="/search" element={<SearchPage />}>
        {searchPage}
      </Route>
    ) : (
      <Route path="/search" element={<SearchPage />} />
    )}

Where isFeatureFlagActive is a helper we build ourselfs.

One though I had was to just add an invert prop that flips things around so that things are rendered when the flag is off
So this:
<FeatureFlagged flag="search-2-0">
  <Route path="/search" element={<SearchPage />}>
    {searchPage}
  </Route>
</FeatureFlagged>
<FeatureFlagged flag="search-2-0" invert>
  <Route path="/search" element={<SearchPage />} />
</FeatureFlagged>

It's a bit more verbose but it feels like we'll also want to be able to invert it in general anyway. Think that would be good enough @Fox32?

Think that would be good enough @Fox32?

I think that is sufficient.
Another option that may reads a bit more fluid could be an unless prop (copied from handlebars). But that would require a bit more complex typing on the props to make sure that you either set if or unless, but not both.

 Open to suggestions for the naming, but thought that we could try and condense this into a single prop with union types rather than prop which is acts an an operator like the inverse prop. We also thought a little bit of something like flag="!my-flag" which we can typecheck, but it's a little unintuitive when it comes to typescript tbh.
This is what it currently looks like:
<FeatureFlagged with="my-flag-that-is-enabled">
  <marquee>DJ Caspa</marquee>
</FeatureFlagged>

And then to render when the flag is disabled
<FeatureFlagged without="my-flag-that-is-disabled">
  <marquee>Slide to the left</marquee>
</FeatureFlagged>

I think that you're right that it would be nicer to condense, kind of stayed away from the unless conjunctive here as it's always something that makes me think super hard about what's happening, and I think without={flagName} is maybe a little clearer and easier to understand?
Thoughts?

Thoughts?

Looks good 👍

Yeah this reads better than invert.
Potential drawback that it is different from prior art (like handlebars and our own optional composability components). Bit no biggie

Ended up extracting ElementCollection to an interface which is now exported, which I think is good form. It also makes it tracked in API reports.


Make the management of the collectd package optional

Sometimes installing packages is done in a different way (eg. epel may
not be enabled by default)
The dependencies still hold.

This doesn't merge cleanly

Rebased (and updated) the changes

@jovandeginste thanks for contributing!


LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210716213831905 to main

LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210716213831905 to main with localized lcls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.002%) to 42.75%

Totals

Change from base Build<PHONE_NUMBER>:
-0.002%

Covered Lines:
26264

Relevant Lines:
55759

💛  - Coveralls


WIP! Pk/app version info

I would appreciate if you already had a look. I will write tests for this still

I will divide this further into its sub problems...


Reportback fixes part 2

Resolves #3760
General visual fixes, also initial progress on getting File Upload buttons to be properly styled across all browsers.
@DFurnes
@sbsmith86 (Shae, this changes up a bit the markup surrounding the upload button, it might change how the cropped image is showcased inside the form post-crop. Let's chat after this gets merged!)
To be continued in Part Trois!

:shipit:


feat(tutorial): complete step 4

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

@kellychurchill TY! PR updated with my missing . :sweat_smile:


fix: silent warning message & wrong exit status check

Just been testing with selene and found two issues.

on_failed was silent again(process %s exited ... message did not show up), so I reverted a change.
Finally I found that the exist status check was not behaving as expected as it exits with exit code 1 and an empty stderr(which should have been fine!) Guess I wasn't paying enough attention previously :sweat_smile:

Maybe related to #77 , idk

Thanks for this, was suspect on those changes I implemented - my bad.

I should have done more testing! My laptop wasn't available at that timing :( It's definitely best to be more cautious next time, so as not to break someone's workflow.


Merge pull request #632 from MicrosoftDocs/main

Deploy November 2022 third publish

Learn Build status updates of commit cc22903:
:warning: Validation status: warnings
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


use diamond types <>

Coverage remained the same at 70.7% when pulling 3d5794a9201256d5922c0dc28d186b862c411c1b on ak_diamonds into a75b706c98c542ded89a771b93b1c3df78ba7f6a on master.

@lbergelson please review

What's the trick to do this automatically?

will tell you once we merge it

:+1:

In IntelliJ, use Analyze | Run Inspection by name ... | Explicit type can be replaced by <>
Then right-click the top level in the inspection window and apply the fix.


Patch 1

Added league and team for Euro 2016 (don't know if I did correctly...)

Did it again from correct cloned repo / sorry for noise


Snapshot integration

Description

This PR adds Snapshot integration for DAOs. When creating a DAO, users can configure a Snapshot ENS name for the DAO, and any proposals created within Snapshot will then be displayed in the DAO proposal list.

Notes
Issue / Notion doc (if applicable)
https://github.com/decent-dao/fractal-interface/issues/1154
Testing

Go to Snapshot  and set up a space with an ENS name.
Within Fractal, create a DAO and set the ENS name used in step 1
Create some proposals in the Snapshot space and verify they show up in the DAO proposals list

Screenshots (if applicable)

@herbig Regarding the ENS name validation, it looks to me like asdf.eth is a registered ENS name, while asdff.eth is not. So the behavior you're describing seems right to me.

@herbig Regarding the ENS name validation, it looks to me like asdf.eth is a registered ENS name, while asdff.eth is not. So the behavior you're describing seems right to me.

Oh shoot, yeah.


Poetry startup uses CPU instead of GPU

Need more info.

I get the same problem. Using docker on WSL.  All rights reserved.
2024-08-21 14:01:00
2024-08-21 14:01:00 This container image and its contents are governed by the NVIDIA Deep Learning Container License.
2024-08-21 14:01:00 By pulling and using the container, you accept the terms and conditions of this license:
2024-08-21 14:01:00 https://developer.nvidia.com/ngc/nvidia-deep-learning-container-license
2024-08-21 14:01:00
2024-08-21 14:01:00 A copy of this license is made available in this container at /NGC-DL-CONTAINER-LICENSE for your convenience.
2024-08-21 14:01:00
2024-08-21 14:01:00 [2024-08-21 12:01:00 +0000] [27] [INFO] Starting gunicorn 22.0.0
2024-08-21 14:01:00 [2024-08-21 12:01:00 +0000] [27] [INFO] Listening at: http://<IP_ADDRESS>:9000 (27)
2024-08-21 14:01:00 [2024-08-21 12:01:00 +0000] [27] [INFO] Using worker: uvicorn.workers.UvicornWorker
2024-08-21 14:01:00 [2024-08-21 12:01:00 +0000] [28] [INFO] Booting worker with pid: 28
2024-08-21 14:01:01 /app/.venv/lib/python3.10/site-packages/torch/cuda/__init__.py:88: UserWarning: CUDA initialization: Unexpected error from cudaGetDeviceCount(). Did you run some cuda functions before calling NumCudaDevices() that might have already set an error? Error 500: named symbol not found (Triggered internally at ../c10/cuda/CUDAFunctions.cpp:109.)
2024-08-21 14:01:01   return torch._C._cuda_getDeviceCount() > 0
2024-08-21 14:01:17 [2024-08-21 12:01:17 +0000] [28] [INFO] Started server process [28]
2024-08-21 14:01:17 [2024-08-21 12:01:17 +0000] [28] [INFO] Waiting for application startup.
2024-08-21 14:01:17 [2024-08-21 12:01:17 +0000] [28] [INFO] Application startup complete.

showing that cuda is present and working, but there is a problem during startup procedure. Notice
2024-08-21 14:01:01 /app/.venv/lib/python3.10/site-packages/torch/cuda/__init__.py:88: UserWarning: CUDA initialization: Unexpected error from cudaGetDeviceCount(). Did you run some cuda functions before calling NumCudaDevices() that might have already set an error? Error 500: named symbol not found (Triggered internally at ../c10/cuda/CUDAFunctions.cpp:109.)
2024-08-21 14:01:01   return torch._C._cuda_getDeviceCount() > 0

in log.
If I access the docker container with docker exec -it <container hash> /bin/bash
and execute nvidia-smi, I can see the correct nvidia smi output with gpu shown there, meaning i have host drivers etc. set up correctly.
Wed Aug 21 12:11:57 2024
+-----------------------------------------------------------------------------------------+
| NVIDIA-SMI 555.58.02              Driver Version: 556.12         CUDA Version: 12.5     |
|-----------------------------------------+------------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id          Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |           Memory-Usage | GPU-Util  Compute M. |
|                                         |                        |               MIG M. |
|=========================================+========================+======================|
|   0  NVIDIA GeForce RTX 2080 Ti     On  |   00000000:01:00.0  On |                  N/A |
<...>

Have you updated your NVIDIA drivers on the host Windows machine?


densityxx is a C++ version of density

Can I have a link in the page of density?
https://github.com/charlesw1234/densityxx

Hello Charles,
First of all, congratulations for your work !
Of course, I’ll add your C++ port in the home page.
Hopefully I’ll be able to continue working on the library later this year, there are a few interesting things under progress in the dev branch.
Have a nice day !
Guillaume

Le 21 févr. 2016 à 13:41, charlesw1234<EMAIL_ADDRESS>a écrit :
Can I have a link in the page of density?
https://github.com/charlesw1234/densityxx https://github.com/charlesw1234/densityxx
—
Reply to this email directly or view it on GitHub https://github.com/centaurean/density/issues/61.

Added a "related projects" section in the README

thanks! I'm trying to use template to speed it up.


Seedcracker is not begining with cracking the seed

I have 63 bits but it's not beginning with cracking the seed in 1.19. I have waited for 1h now and I get no message relating to the seedcracker.

Well, waiting wont make it start. You need to find liftable bits, not normal ones


[AutoPR postgresql/resource-manager] Add PrivateEndpointConnection, PrivateLinkResources swagger

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/7372

(message created by the CI based on PR content)


include center cell?

hey, I was just doing some stuff with Delannoy numbers when I noticed that neighborhoods usually include the center cell. from wikipedia:

The Moore neighbourhood of a cell is the cell itself and the cells at a Chebyshev distance of 1.

The von Neumann neighbourhood of a cell is the cell itself and the cells at a Manhattan distance of 1.

I understand that the center cell doesn't usually hold much value when working with neighborhoods, but it may be a good idea to include it for accuracy. thoughts?

Hey @semibran, good catch! While it might be more accurate this way, it does make things a bit clunkier in the case where a user isn't checking the origin cell.
const full = moore(2, 2)

for (var i = 0; i < full.length; i++) {
  var cell = full[i]
  if (!cell[0] && !cell[1]) {
    // ...
  }
}

Whereas if we exclude it, it can easily be added to the resulting array in the cases where we do want to check for it:
const full = moore(2, 2).concat([0, 0])

One solution for both cases would be to make it opt-in, maintaining backwards compatibility:
// one of:
const full = moore(2, 2, true)
const full = moore(2, 2, { origin: true })

But I personally lean more to documenting the behaviour in the readme as it keeps the code simple. Your call :)

after some extra research (i.e. page 2 of search results. Wow), it looks like sources other than wolfram and wikipedia suggest that the origin cell can be omitted - stuff like "contains 8 or 9 neighbors, depending on whether the center cell is included".
I'd still prefer keeping it for accuracy and simplicity:

the hacky skip conditional i < length / 2 ? i : i + 1 could be omitted
moore(r, d).length would equal (2r + 1) ^ d, and vonNeumann(r, d).length would equal delannoy(d, r); notice that the signatures don't match up there, but that's a discussion for another time :grimacing:

Also, like you said, the origin cell can be easily added to the resulting array, so I think adding an extra parameter would be unnecessary.
I guess either route is fine but including the center cell seems to fit the original definition better. In the end it's your call :))


Add MIT license file, use GNUInstallDirs module, fix cmake directory location

The path to CMake package configuration files needs to include /tinyobjloader/ which was missing before.
The GNUInstallDirs CMake module is being used to set install paths, which will see no logical change most platforms, and, even then, only where the archive or library is placed.
There was no LICENSE file in the repository, so the contents of the MIT License from the top of tiny_obj_loader.h was placed in a file named as such.

PTAL @syoyo.

Super cool! Thank you!


Smoothening with Hann Window

Please review the relevant issue here: https://github.com/NRCan/geo-deep-learning/issues/485


Add Java support for Pull Queues modifyTaskLease

https://ocd.appscale.com:8080/job/Daily Build/2033/

Please merge with https://github.com/AppScale/hawkeye/pull/90


How to run rasa x without docker as background process on Linux?

I installed it on rasa x server. I can run it on background with following command.But ı can not see login password on nohup output.
nohup rasa x &

nohup.out
WARNING: The TensorFlow contrib module will not be included in TensorFlow 2.0.
For more information, please see:
  * https://github.com/tensorflow/community/blob/master/rfcs/20180907-contrib-sunset.md
  * https://github.com/tensorflow/addons
If you depend on functionality not listed there, please file an issue.

2019-05-31 11:57:53 INFO     root  - Starting Rasa Core server on http://localhost:5005
Starting Rasa X in local mode... 🚀
2019-05-31 11:57:55.682861: I tensorflow/core/platform/cpu_feature_guard.cc:141] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
INFO:apscheduler.scheduler:Scheduler started

Rasa version:
Rasa 1.0.3
Rasa X version (if used & relevant):
Rasa 1.0.3
Python version:
Python 3.6.8
Operating system (windows, osx, ...):
Linux Ubuntu

Thanks for raising this issue, @tabergma  will get back to you about it soon.

fyi you can also set the password with the RASAX_PASSWORD env var, so:
export RASAX_PASSWORD=mypassword; nohup rasa x &

should work. Then you can log in at hostname/login?username=me&password=mypassword

@amn41  Unfortunately. 'export RASAX_PASSWORD=mypassword' command did not work.

The environment variable is called RASA_X_PASSWORD. Can you try again?

Thanks @tabergma it solved


[vector-api] HiDPI (Retina) support for WMS single image layers

@fredj and I worked together on this one.
This PR adds HiDPI (Retina) support for WMS single image layers to the canvas renderer. The effect can be seen on devices with a devicePixelRatio > 1 in the wms-image and wms-image-custom-proj examples.
Key features of this PR:

Correction of the transform for HiDPI images
A refactoring of the single image WMS GetMap query logic, including:
Ensuring that the HEIGHT and WIDTH of the image is always an integer
Ensuring that the BBOX of the image properly matches the HEIGHT and WIDTH of the image
Ensuring that the DPI passed to GeoServer is always an integer
A similar refactoring for tiled WMS GetMap query logic, in anticipation of HiDPI for ol.source.TileWMS
Minor clean-ups and garbage reduction

is there support for lower dpi? due to real-time rendering overhead for our WMS service, requesting and handling 1:1 pixel ratio is not optimal. ideally, an option to request a smaller imagewms dimension and then scaling up in openlayer would help performance a lot. is there currently a method to achieve this? looks like hidpi does something similar but just opposite (larger and scaling down). thx


Focus fullscreen window when moving focus between monitors

With return full monitor box for fullscreen windows in idealBB moving focus inside a fullscreen workspace behaves as if there was only the fullscreen window, skipping other windows. Moving focus back it is possible to end up on a different window.
To improve this I'd suggest that when movefocus changes the active monitor and the new monitor has a fullscreen window that fullscreen window should get the focus even if another window would be closer.

fixed in f6067816fb2bbd7dc9a00da6391cc6dcf5991035


Monorepo Migration Mega-issue

Welcome to the (future) home of all PostHog apps :partying_face:
I'm creating this issue to give an overview of the migration process I've put together so far and hope this will give everyone a good idea of what I'll be working on in the coming weeks. The current plan (at a high level) is to publish separate NPM packages for each app, and then create a migration to update all the official plugins on Cloud and Self-host to point to these packages.
This will provide a number of benefits:

Better observability on issues as they will all be centralized
Helper functions can be shared between apps
New apps can be reviewed/added through PR instead of forking
Full E2E testing
Ability to use 3rd-party NPM modules

Preliminary

[x] Sync existing apps
[x] Create manifest.json to mirror PostHog/integrations-repository with all the apps contained in the monorepo
[x] Setup publishing to NPM
[x] https://github.com/PostHog/posthog/pull/12356 (mainly for debugging)

Switch-over

[x] https://github.com/PostHog/posthog/pull/12438
[ ] Update existing app README.md's with note that eventually they will no longer be maintained and all issues should be filed here
[ ] Update docs on submitting a new app
[ ] Update plugin.json fetching on posthog.com
[ ] #8
[ ] Sync existing issues from each repo

Future work

[ ] Full E2E testing
[ ] Module bundling and breaking shared code into a central library of helpers

This is still fairly early on and there's a lot of fleshing-out I still need to do, but I've done enough digging to where I'm happy with this plan at a high level. As always, if there's anything I've missed or any feedback you have on the overall process please don't hesitate to add/edit things!
cc: @yakkomajuri @mariusandra @tiina303 @macobo @timgl @jamesefhawkins

Some thoughts:

I'm not sure what the "dist" folder is for. Apps don't need to be transpiled... and it's even better if we explicitly don't transpile them, and always load the original TypeScript source in the plugin server. That's because the plugin server injects various safeguards into the plugins (infinite loop busters, etc)... which we want to have control over.
Publishing into NPM is one way of getting the apps up, that I just listed as an alternative once, without saying this is what you should go for. I still haven't had the time to review the app subfolders PR (sorry 😅), but if that works, I'm not sure if there's a strong need to use NPM. I'm not against it though, just clarifying my stance...
There's one more thing that's different for NPM vs GitHub -> when upgrading, if it's a GitHub package, we can show a link to the diff between the commits right there. This way you always know what changed when upgrading. Unfortunately you can't see a diff like that between NPM package versions. The most we could do is to link back to the repo with a version/tag range, but that won't work since git tags are global and not meant to tag multiple different packages in a repo... 🤔

@mariusandra Thanks a ton for the thoughts!

I'm not sure what the "dist" folder ...

Would these safeguards be broken by this? (I purposfully haven't done any minification and am targeting modern Node features). The main reason I opted for this wasn't strictly transpilation and was more for bundling - it would be super nice to be able to use third-party NPM packages without having to explicitly allow and include them on the plugin server side. Along with this, having a shared library of helper functions that all plugins can access would be amazing.
If this does break those safeguards I'm fine opting for just publishing the source files directly, but from a DX perspective I would love to have this.

Publishing into NPM is one way of getting the apps up, that I just listed as an alternative once, ...

Totally agree, and while I don't think there's a super strong reason for one or the other (I went back and forth a lot :sweat_smile:), I eventually settled on the NPM route mainly because it felt much easier to manage releases. By using semver's instead of commits it makes it much easier to do things like: show what type of update is available for an app (patch, major, etc) as well as displaying a human-readable version to the user. As things grow, I also like that we can chunk multiple commits into a release rather than every single commit to main counting as a new version.

There's one more thing that's different for NPM vs GitHub -> when upgrading, ...

I'm not too worried about losing this, as I would assume (not sure if we track this) that not a ton of users are checking the raw diffs, but I could be totally wrong. Furthermore, I think using the version to display whether the update is a major/patch/etc would give the user enough context.
Another thing that might be interesting is somehow publishing a changelog showing all the commits in a release. Haven't done any thinking about how this would actually work, but I'd imagine most users would prefer this to a raw diff :shrug:

Would these safeguards be broken by this, even without minification and targeting the latest Node features?. Haven't looked into this area though so don't really haven much context on these.

We'd still re-transpile the compiled source in dist as it is now, and perhaps double add some safeguards. We really want to make sure that you can't take the server down by just writing function processEvent() { for(;;); }. Since we can't trust code that comes from any external source, and we also want to protect users from themselves (accidental endless loop by missing a symbol?), we have no other option than to re-transpile the code and add our safeguards.
The way I look at it is that with the plugin server we're basically building a custom JS runtime (actually just wrapping node), with the raw apps themselves being the input for this runtime. Imagine running plugin-server customerio-app/index.ts the same way you'd run deno customerio-app/index.ts.

The main reason I opted for this wasn't strictly transpilation and was more for bundling - it would be super nice to be able to use third-party NPM packages without having to explicitly allow and include them on the plugin server side. Along with this, having a shared library of helper functions that all plugins can access would be amazing.

I think that's a solved problem, just not implemented. :)
The answer is import maps and CDNs like jspm.org. Take this generated import map.

Now each dependency is just a few JS files that you download, cache and serve with the app in addition to the global imports object.
It's a bit more complicated than that, but definitely doable.

I'm not too worried about losing this, as I would assume that not a ton of users are checking the raw diffs, but I could be totally wrong (not sure if we track this?). Furthermore, I think using the version to display whether the update is a major/patch/etc would give the user enough context.

I use it every time I upgrade an app on cloud to be absolutely sure nothing weird is ending up in production. If I wouldn't have this, I'd probably open the repo manually and check the last commits. Making this a link to a changelog (if set in plugin.json?) or just a link to the the commit history for a github folder will probably be enough.
The danger with npm packages though is that you can publish anything on npm. It doesn't have to be the same code that's on github. Thus to be really sure I'd still somehow like to compare the contents of the packages. However we might even need to build our own diffing tool inside posthog for this. We'd just be diffing two tarballs, and showing users the raw output, similar to the command line npm diff<EMAIL_ADDRESS><EMAIL_ADDRESS>There are existing online npm diffing tools, though I don't know if we could link to them, or are they now a "data processor" that we need to handle?
All solvable problems in any case.

Regarding the dist folder, I still suggest just getting rid of it. You wouldn't commit it to github for a npm package, and it's just another step in another pipeline that can cause problems.
The other thing I'd do is to rename src/packages to just packages. There's no need for the extra nesting, and if any package needs a separate src folder, they're free to add it.

Fair enough, for this first version I'll go ahead and just publish the source directly. I'll keep the rollup stuff on a separate branch to play around with in the future, but for now I agree that keeping things simple is important :raised_hands:

Good work @pauldambra! What was the reason for apps being a separate repo vs being a folder within posthog? Not saying one is right or wrong just keen to understand the rationale

wrong paul @lharries :D
I think this will be much easier to manage and maintain in a separate repo. Otherwise these apps don't feel like separate apps, but part of posthog-core, which is a feeling we'd like to avoid.
Plus, there's a technical reason: if you want to install an app from a folder, you need to download the whole repository as a zip and extract that one folder. You can't just download that one folder as a zip. When we install apos, this is what we do. We also then store the zip inside postgres.
Having a separate apps folder would allow us, if needed to install custom apps from custom folders on custom branches and play around. Having it all on the posthog.com repo would make this immensely slow, as you'd have to download a LOT of data just to get one JS file.

Understood, thanks Marius!

Just saw this and it looks super cool!


Unexpected fields: pattern

'pattern' field doesn't pass a validation since the name of that field is specified as symbol in schema.rb: https://github.com/kevindew/openapi3_parser/blob/master/lib/openapi3_parser/node_factories/schema.rb#L26,
factory.field_configs.keys array doesn't contain 'pattern' string value:
https://github.com/kevindew/openapi3_parser/blob/master/lib/openapi3_parser/node_factory/object/validator.rb#L21

D'oh - thanks for reporting that.
It's fixed in https://github.com/kevindew/openapi3_parser/commit/e3053a35b7feac7159401cad49e40ad9a416ad8f and will go out in next release.


iOS header bottom border should use box shadow instead of solid hairline

Current Behavior

What code are you running and what is happening?
I'm using a StackView. React Devtools shows these properties are how the Header bottom border is rendered on iOS:

backgroundColor: #F7F7F7;
borderBottomWidth: 0.5;
borderBottomColor: #A7A7AA;

Include a screenshot if it makes sense.

Expected Behavior

What do you expect should be happening?
In Apple's official iOS Sketch library, the bottom border is created by creating a shadow of the color rgba(0, 0, 0, 0.3) with an offset of X=0, Y=0.5, no blur, and no spread.
Include a screenshot if it makes sense.

I expected to see shadowColor, shadowOffset, shadowOpacity, and shadowRadius props instead of an approximation with a solid border. shadow props documentation
Your Environment

software
version

react-navigation
2.5.3

react-native
0.56.0

node
10.0.0

npm or yarn
1.8.0

Oops, this was not meant to be posted.


Add cluster fileld in QueueSpec to support multi-cluster-scheduling case

Signed-off-by: w00503381<EMAIL_ADDRESS>

The design doc will be ready soon.

/cc @kevin-wangzefeng


Add documentation article about extractors. [phab:D1976]

Created by fromberger at 2017-10-10 07:15:54:

nbeloglazovgoog wrote at 2017-10-10 07:18:43:
I wanted to kick off extractor doc. Please suggest changes if something is wrong or I need to add something as I wrote based on my best knowledge as outside developer.

salguarnieri commented inline (context lost during migration) at 2017-10-10 22:17:46:
Maybe something like: Compilation Units are captured by link:...[extractors].

salguarnieri commented inline (context lost during migration) at 2017-10-10 22:17:46:
This feels a little out of place. Maybe roll it into the previous paragraph?

salguarnieri commented inline (context lost during migration) at 2017-10-10 22:17:46:
Maybe also mention it tells how to invoke the compiler (if applicable).

salguarnieri commented inline (context lost during migration) at 2017-10-10 22:17:46:
The extractor doesn't really convert the project. I can see a description that says it takes the project as input and outputs Compilation Units. After that description, it might help to have a concrete example from bazel or maven.

salguarnieri commented inline (context lost during migration) at 2017-10-10 22:17:46:
This and the following paragraph sound like the previous two paragraphs, but with more details. Can you merge the previous two paragraphs into these two?

nbeloglazovgoog wrote at 2017-10-11 05:07:25:

Address comments from review.

nbeloglazovgoog commented inline (context lost during migration) at 2017-10-11 05:12:21:
Refrased it as suggested.

nbeloglazovgoog commented inline (context lost during migration) at 2017-10-11 05:12:21:
Changed a little bit, but not much. Currently the structure is the following:
First paragraph: what is extractor
Second: why it is needed
Third: example with maven.
Does it look reasonable?

nbeloglazovgoog commented inline (context lost during migration) at 2017-10-11 05:12:21:
Any other requirements for new extractors?

nbeloglazovgoog commented inline (context lost during migration) at 2017-10-11 05:12:21:
I don't think it belongs to the previous paragraph. The previous paragraph talks about a script that indexes the whole Kythe repo. And I want just to provide a link to all available extractors which is different from "how to index kythe repo itself".

fromberger commented inline (context lost during migration) at 2017-10-11 13:34:05:
For some historical context: The basic interface between the build system and the rest of Kythe is via the CompilationUnit record. That means in practice that Kythe actually comprises two separate indexing passes: One for build/dependency information, one for the code itself.
Obviously using the term "indexer" for both of these would be confusing, so we used the word "extractor" to describe the "build-system indexer" (that term mostly because of how we "extract" compilation data from Bazel).
But at root, there is nothing that requires this step to be handled to be a separate program—a build tool could be instrumented directly to capture this information (e.g., under a flag perhaps). The distinguishing feature of an "extractor" if there is one is only that it emits CompilationUnit messages and their corresponding data. What it takes as input and how it works internally are essentially unspecified by Kythe, by design.

salguarnieri commented inline (context lost during migration) at 2017-10-11 18:04:28:
I'm not sure of specific requirements, especially in the way of the corpus. If it generates valid kindex files, that should be sufficient. fromberger any thoughts?

salguarnieri commented inline (context lost during migration) at 2017-10-11 18:04:28:
Why do you want the link to the list of extractors? I guess I'm just missing the motivation for putting the link here.

salguarnieri commented inline (context lost during migration) at 2017-10-11 18:04:28:
It looks better. Maybe do another pass with fromberger info from above and he can give it a final OK

salguarnieri wrote at 2017-10-11 18:04:28:
Thanks for putting this together. We can add to it over time, but it looks like a good start.
Setting review to fromberger to give a final pass.

nbeloglazovgoog commented inline (context lost during migration) at 2017-10-12 04:24:03:
Motivation is that users might start with this example article. It contains example with bazel extractor and users might want to see what other extractors exist because most likely they don't use bazel. That's why I thought including list to extractors here is appropriate. Otherwise, users have to search the whole kythe.io site to find the list of supported extractors.

nbeloglazovgoog commented inline (context lost during migration) at 2017-10-12 04:24:03:
Thanks for the context. Do you want me to add it to the doc? I understand that there are multiple ways to implement indexers. But I wanted to capture the "standard" approach which seems to be used by C++, Java, Go and JS indexers. All of them have extractors as separate programs/plugins.
I'm happy to add another paragraph that talks about how extractor can be skipped in some cases. Do we have such indexers already? Maybe Typescript such example?

fromberger commented inline (context lost during migration) at 2017-10-12 17:39:25:
I'm torn. On the one hand I see the value of having some more specific documentation for these tools. On the other hand I am not comfortable having a very general statement about the architecture based on what is ultimately a special case.
Writing a more general description of build-system integrations has been on my back-burner for far too long. I think I'd be more comfortable if maybe this focused only on the particulars (e.g., how to extract compilation records from Bazel or Maven) rather than talking in general about the high-level mechanism.

nbeloglazovgoog wrote at 2017-10-13 05:33:46:

Remove high-level info about indexing and keep only extractor-specific parts.

nbeloglazovgoog commented inline (context lost during migration) at 2017-10-13 05:36:47:
Np. Removed high-level description and left only definition of extractor and example with maven. Are you ok with having "adding new extractor" section at the bottom?

nbeloglazovgoog wrote at 2017-10-17 12:14:30:
Friendly ping.

fromberger wrote at 2018-05-21 20:41:57:
As part of the move off Phabricator to GitHub pull requests, I'm abandoning this revision. If someone wants to pursue it further, please start a new issue on https://github.com/google/kythe/issues.
I took a patch of this diff, to ensure we do not lose the content, but it will need to be updated quite a bit before we can land it.

fromberger abandoned revision at 2018-05-21 20:41:57


URL params doesn't seem to work

Trying to change the output format using the format url param, but can't get it to work, only default formatting is returned
curl -v   -F  'content=hj' "https://dpaste.de/api/?format=json"
curl -v   -F  'content=hj' "https://dpaste.de/api/?format=url"
both result in the same output.

Parameters need to be passed via POST
$ curl -v -F 'content=hj' -F 'format=json' https://dpaste.de/api/
{"url": "https://dpaste.de/jS2a", "content": "hj", "lexer": "python"}

Ok I see now the docs says "Available POST data", however the last section on the same page instructs you to alias it as
$ alias dpaste="curl -F 'content=<-' https://dpaste.de/api/?format=url"
http://dpaste.readthedocs.io/en/latest/api.html


option --lang not available in hotword mode !!

--lang fr-FR option is available for
googlesamples-assistant-pushtotalk ... and i could test it in french
but apparantly not for
googlesamples-assistant-hotword
in principle if french is supported for pushtotalk there is no additional work to make it work in hotword mode so i'm surprised ! or did i miss something ?

To change the language used in the hotword sample, the setting will instead appear in the settings of the Google Assistant app for your device.

Thank you, i managed to make it work...but the answers i get through pushtotalk  on the PC seem less performant compared to those from the google home assistant on my android smartphone. May be it's just because the one on the smartphone can interact with a web browser to answer through the opening of various webpages ...
is there a documented way to achieve the same using "kind of extensions" to the assistant-sdk-python ?

You can overload commands using custom device actions if you want additional functionality.

Mmmm yes but apparantly this is designed to allow actions on hardware devices such as switches and so on ... or may be also to launch tasks (scripts, etc...) on the PC but
not really to allow the opening of web pages with info (additional to the one given orally by the answering assistant ) related to the question asked ... as does and is actually the main job of an assistant on any smartphone ...

That's currently what the library provides.
I'm going to close this issue as we've resolved the language switching.


Set up of Webpack and Testing

In this branch I did the following

Add web pack
Add Headers
Install Jest testing

Please do not hesitate to approach me with any questions or concerns you may have @Lul-Abdifan  :smile: Happy Coding:smile:

Hi @Lul-Abdifan,
Excellent Job. I approve this PR.
I will Merge it.