Failed to start <>: yaml: line 148: mapping values are not allowed in this context

Is there an existing issue for this?

[X] I have searched the existing issues

Output of ddev debug test
Expand `ddev debug test` diagnostic information
======= Existing project config =========
These config files were loaded for project t3project-v12: [C:\git\t3project-v12\.ddev\config.yaml]
name: t3project-v12
type: typo3
docroot: public
php_version: 8.2
webserver_type: apache-fpm
webimage: ddev/ddev-webserver:v1.22.7
router_http_port: 80
router_https_port: 443
additional_hostnames: [beispielklinik-v12 hentschel-stiftung-v12]
additional_fqdns: []
database: {mariadb 10.2}
hooks: map[post-start:[map[exec-host:composer install --no-scripts] map[exec:[ -f .env ] && rm .
env] map[exec:ln -s .env-development-ddev .env] map[exec:sudo mkdir -p /var/www/html/public/typo
3] map[exec:sudo mkdir -p /var/www/html/vendor] map[exec:sudo mkdir -p /var/www/html/var] map[ex
ec:sudo chown -R ${DDEV_UID}:${DDEV_GID} /var/www/html/public/typo3] map[exec:sudo chown -R ${DD
EV_UID}:${DDEV_GID} /var/www/html/vendor] map[exec:sudo chown -R ${DDEV_UID}:${DDEV_GID} /var/ww
w/html/var] map[exec:composer install -d /var/www/html] map[exec:test -e "/var/www/html/config/s
ystem/settings.php" && echo "TYPO3 is already installed and configured." || ./vendor/bin/typo3 s
etup] map[exec:./vendor/bin/typo3 backend:lock] map[exec:./vendor/bin/typo3 database:updateschem
a] map[exec:./vendor/bin/typo3 install:fixfolderstructure] map[exec:./vendor/bin/typo3 install:e
xtensionsetupifpossible] map[exec:./vendor/bin/typo3 extension:setup] map[exec:./vendor/bin/typo
3 cache:flush] map[exec:./vendor/bin/typo3 cache:warmup] map[exec:./vendor/bin/typo3 backend:unl
ock] map[exec:echo '*/1 * * * * root TYPO3_CONTEXT=Development/ddev /usr/bin/php /var/www/html/p
rivate/typo3/sysext/core/bin/typo3 scheduler:run' | sudo tee -a /etc/cron.d/typo3] map[exec:sudo chmod 0600 /etc/cron.d/typo3 && sudo service cron start]]]
webimage_extra_packages: [cron]
project_tld: ddev.site
use_dns_when_possible: true
timezone: Europe/Berlin
composer_version: 2
nodejs_version: 16
default_container_timeout: 240
======= Creating dummy project named  tryddevproject-32335 in ../tryddevproject-32335 =========
OS Information: MINGW64_NT-10.0-22631 Nikolas-WS1 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
User information: uid=4096(NH+n.kloeffel) gid=4096 groups=4096
DDEV version:  ITEM             VALUE
 DDEV version     v1.22.7
 architecture     amd64
 db               ddev/ddev-dbserver-mariadb-10.4:v1.22.7
 ddev-ssh-agent   ddev/ddev-ssh-agent:v1.22.7
 docker           25.0.3
 docker type      Docker Desktop For Windows
 docker-compose   v2.24.5
 docker-platform  docker-desktop
 mutagen          0.17.2
 os               windows
 router           ddev/ddev-traefik-router:v1.22.7
 web              ddev/ddev-webserver:v1.22.7
PROXY settings: HTTP_PROXY='' HTTPS_PROXY='' http_proxy='' NO_PROXY=''
======= DDEV global info =========
Global configuration:
instrumentation-opt-in=false
omit-containers=[]
performance-mode=mutagen
router-bind-all-interfaces=false
internet-detection-timeout-ms=3000
disable-http2=false
use-letsencrypt=false
letsencrypt-email=
table-style=default
simple-formatting=false
use-hardened-images=false
fail-on-hook-fail=false
required-docker-compose-version=v2.24.5
use-docker-compose-from-path=false
project-tld=ddev.site
xdebug-ide-location=
no-bind-mounts=false
router=traefik
wsl2-no-windows-hosts-mgt=false
router-http-port=80
router-https-port=443
mailpit-http-port=8025
mailpit-https-port=8026
traefik-monitor-port=10999

======= DOCKER info =========
docker location: -rwxr-xr-x 1 NH+n.kloeffel 4096 1359 Apr 10 10:27 '/c/Program Files/Docker/Docker/resources/bin/docker'
Docker Desktop Version: Docker Desktop for Windows <IP_ADDRESS>021

docker version:
Client:
 Cloud integration: v1.0.35+desktop.11
 Version:           25.0.3
 API version:       1.44
 Go version:        go1.21.6
 Git commit:        4debf41
 Built:             Tue Feb  6 21:13:02 2024
 OS/Arch:           windows/amd64
 Context:           default

Server: Docker Desktop 4.28.0 (139021)
 Engine:
  Version:          25.0.3
  API version:      1.44 (minimum version 1.24)
  Go version:       go1.21.6
  Git commit:       f417435
  Built:            Tue Feb  6 21:14:25 2024
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.6.28
  GitCommit:        ae07eda36dd25f8a1b98dfbf587313b99c0190bb
 runc:
  Version:          1.1.12
  GitCommit:        v1.1.12-0-g51d5e94
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0
DOCKER_DEFAULT_PLATFORM=notset
======= Mutagen Info =========
Mutagen is installed in ddev, version=0.17.2
-------------------------------------------------------------------------------
Name: t3project-v12
Identifier: sync_RWAQNfn7lSK6Ii1xbzCenT6UX3ifGELMY6UzrC3OCVU
Labels:
        com.ddev.config-hash: 727eb6396e5236bb4357175fbe4cf5f093a8ceaf
        com.ddev.volume-signature: npipe-pipe-docker-engine-1714655628
Configuration:
        Synchronization mode: Two Way Resolved
        Hashing algorithm: Default (SHA-1)
        Maximum allowed entry count: Default (2⁶⁴−1)
        Maximum staging file size: Default (18 EB)
        Symbolic link mode: Portable
        Ignore VCS mode: Default (Propagate)
        Ignores:
                /.git
                /.tarballs
                /.ddev/db_snapshots
                /.ddev/.importdb*
                .DS_Store
                .idea
                /public/fileadmin
        Permissions mode: Manual
Alpha:
        URL: C:\git\t3project-v12
        Configuration:
                Watch mode: Default (Portable)
                Watch polling interval: Default (10 seconds)
                Probe mode: Default (Probe)
                Scan mode: Default (Accelerated)
                Stage mode: Neighboring
                File mode: Default (0600)
                Directory mode: Default (0700)
                Default file/directory owner: Default
                Default file/directory group: Default
        Connected: Yes
        Synchronizable contents:
                5465 directories
                22046 files (256 MB)
                0 symbolic links
        Scan problems:
                public/_assets/06549062ccaa6b84814d3613a9f5690d: invalid symbolic link: colon in target (absolute or unsupported path)
                public/_assets/081fa96a07de1dccb64a8a83e1567439: invalid symbolic link: colon in target (absolute or unsupported path)
                public/_assets/0c22fd3d95c93dc31098cc8d4b1d7232: invalid symbolic link: colon in target (absolute or unsupported path)
                public/_assets/18b6909c76a7632d04a605073a3e6d26: invalid symbolic link: colon in target (absolute or unsupported path)
                public/_assets/1ee1d3e909b58d32e30dcea666dd3224: invalid symbolic link: colon in target (absolute or unsupported path)
                public/_assets/1f263c3d6abd7ca7a6f9595af66066f3: invalid symbolic link: colon in target (absolute or unsupported path)
                public/_assets/25187ce505d0e99e19d3d12426b25c59: invalid symbolic link: colon in target (absolute or unsupported path)
                public/_assets/2a58d7833cb34b2a67d37f5b750aa297: invalid symbolic link: colon in target (absolute or unsupported path)
                public/_assets/2f0b886317b0304030bed078eea10822: invalid symbolic link: colon in target (absolute or unsupported path)
                public/_assets/2fb2616bdc5e3f187b0dafa30514c43b: invalid symbolic link: colon in target (absolute or unsupported path)
                ...+69 more...
        Transition problems:
                .env: unable to create symbolic link: symlink .env-development-ddev C:\git\t3project-v12\.env: A required privilege is not held by the client.
Beta:
        URL: docker://ddev-t3project-v12-web/var/www/html
                DOCKER_HOST=npipe:////./pipe/docker_engine
        Configuration:
                Watch mode: Default (Portable)
                Watch polling interval: Default (10 seconds)
                Probe mode: Default (Probe)
                Scan mode: Default (Accelerated)
                Stage mode: Neighboring
                File mode: 0777
                Directory mode: 0777
                Default file/directory owner: Default
                Default file/directory group: Default
                Compression: Default (DEFLATE)
        Connected: Yes
        Synchronizable contents:
                5465 directories
                22046 files (256 MB)
                79 symbolic links
        Scan problems:
                var: scan crossed filesystem boundary
Status: Reconciling changes
-------------------------------------------------------------------------------
======= Docker Info =========
Docker platform: docker-desktop
Using Docker context: default (npipe:////./pipe/docker_engine)
docker-compose: v2.24.5
Using DOCKER_HOST=npipe:////./pipe/docker_engine
Docker version: 25.0.3
Able to run simple container that mounts a volume.
Able to use internet inside container.
Docker disk space:
Filesystem                Size      Used Available Use% Mounted on
overlay                1006.9G     62.7G    893.0G   7% /

 Container ddev-t3project-v12-phpmyadmin  Stopped
 Container ddev-t3project-v12-db  Stopped
 Container ddev-t3project-v12-web  Stopped
 Container ddev-t3project-v12-web  Stopped
 Container ddev-t3project-v12-phpmyadmin  Stopped
 Container ddev-t3project-v12-phpmyadmin  Removed
 Container ddev-t3project-v12-db  Stopped
 Container ddev-t3project-v12-db  Removed
 Container ddev-t3project-v12-web  Removed
 Network ddev-t3project-v12_default  Removed
Project t3project-v12 has been stopped.
Stopped Mutagen daemon
The ddev-ssh-agent container has been removed. When you start it again you will have to use 'ddev auth ssh' to provide key authentication again.
Network ddev_default removed
Existing docker containers:
CONTAINER ID   IMAGE     COMMAND   CREATED   STATUS    PORTS     NAMES
Network ddev_default created

 TIP OF THE DAY
 View officially-supported add-ons by running `ddev get --list`, or include third-party
 add-ons with `ddev get --list --all`

Starting tryddevproject-32335...
Network ddev-tryddevproject-32335_default created
2024/05/07 09:43:25 http2: server: error reading preface from client //./pipe/docker_engine: file has already been closed
 Container ddev-ssh-agent  Created
 Container ddev-ssh-agent  Started
ssh-agent container is running: If you want to add authentication to the ssh-agent container, run 'ddev auth ssh' to enable your keys.
Building project images...
2024/05/07 09:43:28 http2: server: error reading preface from client //./pipe/docker_engine: file has already been closed
Project images built in 1s.
 Container ddev-tryddevproject-32335-web  Created
 Container ddev-tryddevproject-32335-db  Created
 Container ddev-tryddevproject-32335-web  Started
 Container ddev-tryddevproject-32335-db  Started
You have Mutagen enabled and your 'php' project type doesn't have `upload_dirs` set.
For faster startup and less disk usage, set upload_dirs to where your user-generated files are stored.
If this is intended you can disable this warning with `ddev config --disable-upload-dirs-warning`.
Starting Mutagen sync process...
Mutagen sync flush completed in 4s.
For details on sync status 'ddev mutagen st tryddevproject-32335 -l'
Waiting for web/db containers to become ready: [web db]
Starting ddev-router if necessary...
 Container ddev-router  Created
 Container ddev-router  Started
Waiting for additional project containers to become ready...
All project containers are now ready.
Successfully started tryddevproject-32335
Project can be reached at https://tryddevproject-32335.ddev.site https://<IP_ADDRESS>:51444
======== Curl of site from inside container:
HTTP/1.1 200 OK
Server: nginx
Date: Tue, 07 May 2024 07:44:05 GMT
Content-Type: text/html; charset=UTF-8
Connection: keep-alive
Vary: Accept-Encoding

======== curl -I of http://tryddevproject-32335.ddev.site from outside:
HTTP/1.1 200 OK
Content-Type: text/html; charset=UTF-8
Date: Tue, 07 May 2024 07:44:06 GMT
Server: nginx
Vary: Accept-Encoding

======== full curl of http://tryddevproject-32335.ddev.site from outside:
Success accessing database... db via TCP/IP
ddev is working. You will want to delete this project with 'ddev delete -Oy tryddevproject-32335'
======== Project ownership on host:
drwxr-xr-x 1 NH+n.kloeffel 4096 0 May  7 09:42 ../tryddevproject-32335
======== Project ownership in container:
ls: cannot access 'C:/Program': No such file or directory
ls: cannot access 'Files/Git/var/www/html': No such file or directory
Failed to execute command ls -ld C:/Program Files/Git/var/www/html: exit status 2
======== In-container filesystem:
df: 'C:/Program': No such file or directory
df: Files/Git/var/www/html: No such file or directory
Failed to execute command df -T C:/Program Files/Git/var/www/html: exit status 1
======== curl again of tryddevproject-32335 from host:
Success accessing database... db via TCP/IP
ddev is working. You will want to delete this project with 'ddev delete -Oy tryddevproject-32335'
Thanks for running the diagnostic. It was successful.
Please provide the output of this script in a new gist at gist.github.com
Running ddev launch in 5 seconds

Please run cleanup after debugging with 'ddev debug testcleanup'
PS C:\git\t3project-v12>

Expected Behavior
'ddev start' shouldn't produce any error if the project is generally working
Actual Behavior
Above error message is shown, project can't be started
Steps To Reproduce
This is something that is happening regurarly with some projects only. I can fix the issue by running 'ddev delete images' and 'ddev config' and then 'ddev start' won't produce this error but I would like to know

Which yaml file is evaluated at this point?
Why would 'ddev delete images' followed by 'ddev config' fix this?
What do I need to configure to not get this error at all?

Anything else?
No response

Hi @loeffe1,

Which yaml file is evaluated at this point?

There is some syntax problem in your .ddev/config.yaml.
Show this file because it is not easy to read from ddev debug test output.

I think you'll find that your config.yaml hooks stanza has a formatting problem. If you comment it out, it will work (I predict). Then you can start to work on what's wrong with your hooks stanza.
Also, people who work on complex things like you seem to be doing will probably have a better experience using WSL2 instead of traditional Windows, see https://ddev.readthedocs.io/en/stable/users/install/ddev-installation/#__tabbed_1_3

So I took your advice to heart since I had planned switching to the Docker Inside variant for some time now. It seems to run somewhat smoother but I will have to see how much of a performance boost I will actually see. What I consider a bit of a peeve with this variant however, is the fact that folders which are populated within the container, will not show their content in my IDE. So I am left with an empty vendor folder for example. Of course I can define include paths to include sources and can ssh into the container to search within the vendor folder but it just isn't quite as comfortable as before.
Back to the question at hand though - I started and stopped the project a few times now and never received the error. What I don't understand is, if the error is caused by the hooks stanza, why would it only occur sometimes?
In any case, it seems to be working now so I will close this issue. If the error does show up again, I will go through my hooks line by line to find the culprit. Here is the complete config anyway:
name: typo3-v12 type: typo3 docroot: public php_version: "8.2" webserver_type: apache-fpm router_http_port: "80" router_https_port: "443" xdebug_enabled: false additional_fqdns: [] database:     type: mariadb     version: "10.2" hooks:     post-start:         - exec-host: composer install --no-scripts         - exec: '[ -f .env ] && rm .env'         - exec: ln -s .env-development-ddev .env         - exec: sudo mkdir -p /var/www/html/public/typo3         - exec: sudo mkdir -p /var/www/html/vendor         - exec: sudo mkdir -p /var/www/html/var         - exec: sudo chown -R ${DDEV_UID}:${DDEV_GID} /var/www/html/public/typo3         - exec: sudo chown -R ${DDEV_UID}:${DDEV_GID} /var/www/html/vendor         - exec: sudo chown -R ${DDEV_UID}:${DDEV_GID} /var/www/html/var         - exec: composer install -d /var/www/html         - exec: test -e "/var/www/html/config/system/settings.php" && echo "TYPO3 is already installed and configured." || ./vendor/bin/typo3 setup         - exec: ./vendor/bin/typo3 backend:lock         - exec: ./vendor/bin/typo3 database:updateschema         - exec: ./vendor/bin/typo3 install:fixfolderstructure         - exec: ./vendor/bin/typo3 install:extensionsetupifpossible         - exec: ./vendor/bin/typo3 extension:setup         - exec: ./vendor/bin/typo3 cache:flush         - exec: ./vendor/bin/typo3 cache:warmup         - exec: ./vendor/bin/typo3 backend:unlock         - exec: echo '*/1 * * * * root TYPO3_CONTEXT=Development/ddev /usr/bin/php /var/www/html/vendor/bin/typo3 scheduler:run' | sudo tee -a /etc/cron.d/typo3         - exec: sudo chmod 0600 /etc/cron.d/typo3 && sudo service cron start webimage_extra_packages: [cron] use_dns_when_possible: true timezone: Europe/Berlin composer_version: "2" web_environment: [] nodejs_version: "16" corepack_enable: false default_container_timeout: "240"

Some things that may help you with this:

You don't need vendor/bin in your executions, because that's already in the PATH. So you can just use - exec: typo3 backend:unlock for example
If you put all those lines in a single script and use the script it will run faster and be much easier to debug.
If you're using cron, you'll probably like using the cron add-on instead of what you have going, https://github.com/ddev/ddev-cron, ddev get ddev/ddev-cron
If you don't specifically need nodejs 16, then just remove that line and you'll get the default with a slightly faster build.
mariadb:10.2 is very old and out of support. You can most likely use the current default (10.11) or perhaps 10.6 or something. But if your host uses 10.2 still then ... OK!
router_http_port and router_https_port can be removed and they'll pick up the defaults (which you have set anyway, and these can now be set globally)
Is there a reason you have overridden the default_container_timeout?

Thank you so much, both of you! This is really helpful!

Is there a reason you have overridden the default_container_timeout?

No reason, this was just an old copy paste remnant


fix: Onfido back button issue

Details

This PR edits the Onfido web sdk, such that it uses useMemoryHistory. Without it, the back button on Onfido page does not work correctly on web.
Fixed Issues

$ https://github.com/Expensify/App/issues/16020
PROPOSAL: https://github.com/Expensify/App/issues/16020#issuecomment-1474273178
Tests

On Web:

Go to connect bank account, add details and continue to choose documents page
Out of two accepted documents, select any
( I selected passports) Now click small back button below personal Information header.
(back button sends to previous page) Now again select any accepted document button again.
Verify that the back button works as expected.

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

On Web:

Go to connect bank account, add details and continue to choose documents page
Out of two accepted documents, select any
( I selected passports) Now click small back button below personal Information header.
(back button sends to previous page) Now again select any accepted document button again.
Verify that the back button works as expected.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/30054992/226554408-079a09ec-5cae-45d7-a194-a67664457071.mov

Mobile Web - Chrome
Unable to test on Android Chrome because of the following issue:
https://user-images.githubusercontent.com/30054992/226554510-0556cd51-8bd7-429b-9f16-d66042e50070.mov

Mobile Web - Safari
https://user-images.githubusercontent.com/30054992/226554580-6f558931-d0ec-4285-99a5-2b74384c848e.mov

Desktop
https://user-images.githubusercontent.com/30054992/226554665-c22d44fa-e036-4291-9407-d6904eae8a5f.mov

iOS
https://user-images.githubusercontent.com/30054992/226554760-3d0aa70e-bc61-4ad3-916e-cb276795f60c.mov

Android
https://user-images.githubusercontent.com/30054992/226554790-830bd26c-8cb2-4a1b-9f38-863e189d8fbe.mov

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@hayata-suenaga
Something's off on mWeb Android alone, do we have a known issue cc: @allroundexperts
https://user-images.githubusercontent.com/85645967/226650688-efba67bf-1122-44bf-a092-2a3ef16d90f5.mp4
I see a warning on web that say one of the configuration optionuseLiveDocumentCapture is depreceted

Let me know what we can do about this other wise, PR tests well!

Yes. I could not figure out the problems with Android. But it happens
without my changes.
On Tue, 21 Mar 2023 at 8:11 PM, Santhoshkumar Sellavel <
@.***> wrote:

@hayata-suenaga https://github.com/hayata-suenaga
Something's off on mWeb Android alone, do we have a known issue cc:
@allroundexperts https://github.com/allroundexperts
https://user-images.githubusercontent.com/85645967/226650688-efba67bf-1122-44bf-a092-2a3ef16d90f5.mp4
I see a warning on web that say one of the configuration
optionuseLiveDocumentCapture is depreceted
[image: Screenshot 2023-03-21 at 8 34 50 PM]
https://user-images.githubusercontent.com/85645967/226650548-eb434bed-25ba-4ea0-8fb2-4ede67eea352.png
Let me know what we can do about this other wise, PR tests well!
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/pull/16333#issuecomment-1478014990, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AHFJUUDI4WJPK5C2TSTTBKLW5HALRANCNFSM6AAAAAAWCDSTJA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Yes. I could not figure out the problems with Android. But it happens

without my changes.
Things like this should be brought forward also based on our checklist of PR fails(Unable to test) for android mWeb.
The Sooner you bring it faster we can move forward with a resolution.

Thanks for letting me know. Do I need to investigate this?

@allroundexperts I saw you merged main into this PR. has the issue been solved on main?

@hayata-suenaga Not really. I can confirm that this issue is NOT happening when I open https://staging.new.expensify.com. However, on local host, this seems to cause an error even on the main branch. I'm still not able to find the root cause though. My guess is that it might be related to the browser security policy (since android opens localhost on <IP_ADDRESS>).

Yeah please or look whether this has been reported already?

@Santhosh-Sellavel I couldn't find this reported anywhere. The closest I can find is this.

@allroundexperts when you got a moment, could you share the issue in #expensify-open-source channel in slack to see if anyone is encountering the same issue? I'd appreciate it.

I've just asked on bugs channels let's wait until EOD.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.2.89-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.2.89-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


MRTK - Initializing Project tutorial page should list "Enable Virtual Reality Support" (legacyXR) step

Using Unity 2019.4.21f11
In the Step "Select Depth Format: 16-bit" - I believe this needs to be preceded by a "Enable the "Virtual Reality Supported" checkbox" step (legacy XR), which is disabled by default, afaics, in Unity 2019 LTS

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 24d36428-004c-e29f-ac5a-602bcbabdb25
Version Independent ID: 01015fb5-d01b-c738-6671-9a0ca9af000e
Content: Initializing your project and deploying your first application - Mixed Reality
Content Source: mixed-reality-docs/mr-dev-docs/develop/unity/tutorials/mr-learning-base-02.md
Product: mixed-reality
Technology: mr-dev
GitHub Login: @jessemcculloch
Microsoft Alias: jemccull

@paco-ms  Thanks for the feedback.
It has been mentioned to enable "Enable the "Virtual Reality Supported" before the step "Select Depth Format: 16-bit" in the tutorial. Please refer to the below screenshot.

Please let us know if there is anything missing so that we could update.

You are totally right, I missed it (and I had double checked before posting). Thanks.


remove unnecessary filter conversion

the removed code converts file filters from the extension API format, but the function receives them already converted.
fixes #62237
will need to cherry pick to release/1.29

I don't understand, is it converted somewhere else?

Oh I see where they are converted already.

Sorry, I did not mean to do that. I don't know how to undo that.


Fix syntax of passing files to --parameters

Without this it'll give you a very non-descriptive invalid syntax: ./_output/datahubfa17/azuredeploy.parameters.json
error!
What this PR does / why we need it:
I spent quite a bit of time trying to understand this mysterious error message :( I'd have liked to not.

This change is

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@yuvipanda The confusing "@ or not to @" problem was is from a newer azure-cli. We're planning to pin versions to prevent this kind of problem from happening again: https://github.com/Azure/acs-engine/issues/877
@yuvipanda can you try upgrading to the latest version of azure-cli and report back if the problem goes away?

@yuvipanda - we will be closing this PR since there has been no response for over 2 weeks. Please feel free to reopen it.


x64 Bit version broken

When launching x64 bit version with debugging, i get this error: https://i.imgur.com/WFe4fyC.png
Launching x86 works fine. Please fix!
EDIT: Using commit 7ddbf3ce3e9b4e71f7645112054bd1f314d62e3a

+1

I think it's opentk problem, but I don't have any solutions


feat: add displaying default values

Hmmm, maybe needs a better indicator.

That is much better. :)


Resume generator using Claude AI's API

Use Claude's API and create a resume creation code by a person's information or old resume as input.

please assign it to me @Sohammhatre10 !

Sure @agrawal-sneha


DOC: add example to chi2_contingency

Current examples of scipy.stats.chi2_contingency are not very helpful.
I propose to add a real life example based on a well cited study (>500): https://jamanetwork.com/journals/jama/article-abstract/202217
Berger, Jeffrey S. et al. "Aspirin for the Primary Prevention of
Cardiovascular Events in Women and Men: A Sex-Specific
Meta-analysis of Randomized Controlled Trials."
JAMA, 295(3):306–313, :doi:`10.1001/jama.295.3.306`, 2006.

To resolve https://github.com/scipy/scipy/pull/17610#discussion_r1051034735, would you like me to submit a complementary example in odds_ratio, or would you like to do that? The idea is to use the same data but to compute the odds ratio CI and argue that since the upper end of the CI was below 1, the authors of the study were able to conclude that aspirin reduced the odds of ischemic stroke. Here in the chi2 example we would just conclude that that the null hypothesis is rejected and we'd point to odds_ratio for the one-sided conclusion.

Ok yes I can do the PR tmr 👍

Thanks @tupui!


[BUG]: Small reward button on right side on small sidebar size

The screenshots show the objects being large and filling the whole box, but the addon currently doesn't support that.

Hi! Thank you for raising this issue. Could you provide a bit more context, please? 😊 I'm not sure I fully understand what you're referring to. Any additional details would help clarify the problem. Thanks!

Ye sure. The elements in your tasks (ex. Tasks and rewards) are enlarged
and significantly take up more space inside the boxes. The first image is a
reward item I have created and the second is the image you display in your
getting started guide.
[image: image.png][image: image.png]
On Tue, Oct 15, 2024 at 8:47 AM dromse @.***> wrote:

Hi! Thank you for raising this issue. Could you provide a bit more
context, please? 😊 I'm not sure I fully understand what you're referring
to. Any additional details would help clarify the problem. Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/dromse/obsidian-gamified-tasks/issues/76#issuecomment-2413970813,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BMDWJXERHARGKZAYXBGP3X3Z3UMHHAVCNFSM6AAAAABP6LJ6O2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJTHE3TAOBRGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hm, this is an interesting bug. I'll need more information about your setup to investigate further. Could you let me know what OS and device you're using (Desktop, Smartphone)? Also, which theme are you using? Lastly, have you tried resizing the right sidebar? Does the size of the button change when you do?

Please note that on a small sidebar, the button is designed to look this way, so that might be expected behavior.

I am using the default dark theme on Windows. I have tried to make the sidebar larger, but it doesn't react as desired.

Hi, @inwardcartoon85! What version of windows do you use? Does this bug still appear?

I use the latest version of Windows. I believe it's 24H2. No, It seems to be fixed, they are decently sized now! Thank you!

You're welcome! 😄


Update MD file on new branch 2017-31-29_09-11-55

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fix stetho interceptor

Issue

Overview (Required)

When I open stetho, GitHub API fails.
Stetho doc says to use addNetworkInterceptor.

Links

http://facebook.github.io/stetho/#integrations

Screenshot

Before
After

Good catch! Thank you! 🙏

LGTM!


Unchecked terminate() return values

This is a low-severity code quality issue in SoftU2FDriver.cpp. In SoftU2FDriver.cpp, terminate is called, however, the respective return value is not checked. In cases where a client is still attached to the device, this will fail silently.
Affected components:
SoftU2FDriver.cpp:L46
SoftU2FDriver.cpp:L139
Recommendation:
Add check for the return value of termination like in SoftU2FUserClient.cpp, or utilize isInactive to not call terminate on a device that is already inactive
References:
https://developer.apple.com/documentation/kernel/ioservice/1811110-terminate

Fixed by d363fb6


Sharp lib require x64 arch

yarn develop
Error: Cannot find module '../build/Release/sharp.node'

see Sharp doc : http://sharp.pixelplumbing.com/en/stable/install/
Only 64-bit (x64) node.exe is supported.

Sorry @Huaoe but I do not understand, could you please explicate your issue?

It's just a WARNING for others who would try.
I'm on a windows 32 bits and I can't install Sharp lib.
I'll probably migrate to Ubuntu soon ;)

Thank you.


use functools wraps when defining a decorator

I think the metadata like docstrings don't stay intact unless you do this

Hi @MatthewCaseres, could you tell me what's the purpose of having docstrings stay intact in the context of cash flow models? Is something not working as you expected because of that?


Remittance

@Sailias my app has a need to pay out users periodically (as well as collect payments on their behalf which this gem already covers). Would it make sense to add this feature to cryptocoin_payable? I'm envisioning this as just an extra method to each coin adapter that will interact with the correct API (e.g. Blockcypher for btc). And then wrapped in a Rake task.

@mhluska I don't see the need for this to be part of the Gem.  If you are configuring the access keys for the APIs this gem is consuming, I would add the remittance logic outside of this application.  Also keep in mind this Gem accepts payments using your own MPK (in Bitcoin) and a adapter only needs to query the blockchain.  An adapter that can also send payments is not necessary.
I would like to keep all forms of remittance out of this gem and in the hands of the parent application if possible.


Delete panel doesn't wrap around the close icon.

If a project name is a little too long but not long enough to trigger line wrapping it appears behind the close icon.

Maybe we need a dashboard tag then

@jdunkerley I added g-dashboard label and assigned it here!


fixes bug 1251348 - use fanout

Coverage decreased (-0.06%) to 84.773% when pulling 4076715b5845954d6dfad97a5938bfad4cb184db on peterbe:bug-1251348-use-fanout into 1637bc162a104caf36dc00ee42951db6acd9fda6 on mozilla:master.


touchesBegan and touchesEnded

I can't launch the demo because of this error. That's a shame because your segment view seems really promising and nice looking, thanks for sharing it ;)

@PierreLouisBresson Looks like the errors are caused by the change of Swift. Have updated the source code to make the errors away. Thanks for letting me know. :)


cmd/compile: accepts std/go/token as valid package?

goimports inserted a "std/go/token" package for me, which kinda works in some places (go test) but fails in others (trybots of
diff --git a/src/net/http/transport_test.go b/src/net/http/transport_test.go
index 857f0d5928..e5c9f7e37b 100644
--- a/src/net/http/transport_test.go
+++ b/src/net/http/transport_test.go
@@ -35,6 +35,7 @@ import (
        "os"
        "reflect"
        "runtime"
+       "std/go/token"
        "strconv"
        "strings"
        "sync"
@@ -5220,3 +5221,45 @@ func TestTransportRequestWriteRoundTrip(t *testing.T) {
                })
        }
 }
+
+func TestTransportClone(t *testing.T) {
+       tr := &Transport{
+               Proxy:                  func(*Request) (*url.URL, error) { panic("") },
+               DialContext:            func(ctx context.Context, network, addr string) (net.Conn, error) { panic("") },
+               Dial:                   func(network, addr string) (net.Conn, error) { panic("") },
+               DialTLS:                func(network, addr string) (net.Conn, error) { panic("") },
+               TLSClientConfig:        ne)w(tls.Config),
+               TLSHandshakeTimeout:    time.Second,
+               DisableKeepAlives:      true,
+               DisableCompression:     true,
+               MaxIdleConns:           1,
+               MaxIdleConnsPerHost:    1,
+               MaxConnsPerHost:        1,
+               IdleConnTimeout:        time.Second,
+               ResponseHeaderTimeout:  time.Second,
+               ExpectContinueTimeout:  time.Second,
+               ProxyConnectHeader:     Header{},
+               MaxResponseHeaderBytes: 1,
+               ForceAttemptHTTP2:      true,
+               TLSNextProto:           map[string]func(authority string, c *tls.Conn) RoundTripper{},
+       }
+       tr2 := tr.Clone()
+       rv := reflect.ValueOf(tr2).Elem()
+       rt := rv.Type()
+       for i := 0; i < rt.NumField(); i++ {
+               sf := rt.Field(i)
+               if !token.IsExported(sf.Name) {
+                       continue
+               }
+               if rv.Field(i).IsZero() {
+                       t.Errorf("cloned field t2.%s is zero", sf.Name)
+               }
+       }
+
+       // But test that a nil TLSNextProto is kept nil:
+       tr = new(Transport)
+       tr2 = tr.Clone()
+       if tr2.TLSNextProto != nil {
+               t.Errorf("Transport.TLSNextProto unexpected non-nil")
+       }
+}

bradfitz@go:~/go/src$ cd net/http/
bradfitz@go:~/go/src/net/http$ go test -short
PASS
ok      net/http        4.134s

a "std/go/token" package [...] kinda works in some places (go test)

Isn't that a bug? I would think the import path std/go/token should not resolve to the go/token package in standard library.

Note that it only works under $GOROOT/src, so it's not a release blocker. It only affects the standard library.

Hey @bradfitz, am currently on Go tip 943df4f629 and when I try to make this reproduction I get
$ go test -short
# net/http
package net/http_test
	imports std/go/token: cannot find package "." in:
	/Users/emmanuelodeke/go/src/go.googlesource.com/go/src/std/go/token
FAIL	net/http [setup failed]

Could you please try again and see if this is still an issue?

Great, sounds like it's fixed then. Thanks for trying!


Replace the force shortcut with factory

I reported an issue in #20793 where a -fa was defined for the factory shortcut. Two letter shortcuts won't work.
This removes the -f shortcut for --force on the make:model command and defines the -f flag as a shortcut for factory.
As a user I feel like I'd want a factory more than using --force and the more verbose force is common in other CLI tools.
You can see some discussion around it in #20798.
Closes #20793 and #20798.

I am not in favor of this. If we have to remove the f short code, we may need to remove it everywhere in the framework where its referenced.

I am not in favor of this. If we have to remove the f short code, we may need to remove it everywhere in the framework where its referenced.

I couldn't find anywhere in the framework where -f was a shortcut for --force

Looks like f is referenced in #19932.

Looks like f is referenced in #19932.

@browner12 might have more to say on #19932

again, when I made this PR to 5.4, the factory option did not exist, so I simply when with f as the single letter short code.
now that we have a conflict, I agree with @paulredmond that factory will be put to much more use than force, so factory should get the preference for the single letter code.
running other artisan commands, including
php artisan help migrate

shows precedent for force only using the long form and omitting the short code.


Product Scoping - Auto-merge Repo

Clone of Pledge App
Need Auto-Merge feature(PR gets automatically merged after a build process check)
https://auto-merge.vercel.app/

To be discussed with PT by @MohitNSamagra

Deprioritised.


Flutter 3.16.4

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

It gives malware error. To be suppressed.
Microsoft Reviewers: Open in CodeFlow

No Scripts as installer

@Trenly well ok, but older versions were accepted.

@denelon - Thoughts?

But also now I see https://github.com/microsoft/winget-cli/issues/3386 .

I believe this package works because Windows recognizes a batch file (.bat). This wasn't an expected scenario when the portable feature was implemented. It looks like it may have mistakenly been approved previously.

@denelon ok, is this case of use going to be implemented "officially"?

Based on our current policies, we would not try to offer support for running batch files or scripts.
I don't know flutter well enough to understand what the batch file is doing. I'm downloading it now to crack it open and see if there is a reasonable way to keep it in the repository.

It took a while to download and unzip.
It looks like it's essentially downloading the Git repository for the project, and the batch script is setting environment variables and then calling other batch files in a chain. Once all the environment variables are set up it does appear to be calling portable executables, but I don't know if they would work if they were directly mapped without the user running the batch scripts.
If the references to the .bat files were removed from the manifest and linked directly to the portable executables, I'd be willing to let the package in. It might also make sense to have Install Notes to tell users exactly what they would need to do to get the environment setup by calling the batch files themselves.

Automatic Validation ended with:

Exception during executable launch operation System.AggregateException: One or more errors occurred. (An error occurred trying to start process 'C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\flutter.exe' with working directory 'D:\TOOLS'. The specified executable is not a valid application for this OS platform.)  ---> System.ComponentModel.Win32Exception (216): An error occurred trying to start process 'C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\flutter.exe' with working directory 'D:\TOOLS'. The specified executable is not a valid application for this OS platform.    --- End of inner exception stack trace ---    at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions) Exception during executable launch operation System.AggregateException: One or more errors occurred. (An error occurred trying to start process 'C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\dart.exe' with working directory 'D:\TOOLS'. The specified executable is not a valid application for this OS platform.)  ---> System.ComponentModel.Win32Exception (216): An error occurred trying to start process 'C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\dart.exe' with working directory 'D:\TOOLS'. The specified executable is not a valid application for this OS platform.

Automatic Validation ended with:

Exception during executable launch operation System.AggregateException: One or more errors occurred. (An error occurred trying to start process 'C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\flutter.exe' with working directory 'D:\TOOLS'. The specified executable is not a valid application for this OS platform.)  ---> System.ComponentModel.Win32Exception (216): An error occurred trying to start process 'C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\flutter.exe' with working directory 'D:\TOOLS'. The specified executable is not a valid application for this OS platform.    --- End of inner exception stack trace ---    at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions) Exception during executable launch operation System.AggregateException: One or more errors occurred. (An error occurred trying to start process 'C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\dart.exe' with working directory 'D:\TOOLS'. The specified executable is not a valid application for this OS platform.)  ---> System.ComponentModel.Win32Exception (216): An error occurred trying to start process 'C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\dart.exe' with working directory 'D:\TOOLS'. The specified executable is not a valid application for this OS platform.

(Automated response - build 487.)

It took a while to download and unzip.
It looks like it's essentially downloading the Git repository for the project, and the batch script is setting environment variables and then calling other batch files in a chain. Once all the environment variables are set up it does appear to be calling portable executables, but I don't know if they would work if they were directly mapped without the user running the batch scripts.
If the references to the .bat files were removed from the manifest and linked directly to the portable executables, I'd be willing to let the package in. It might also make sense to have Install Notes to tell users exactly what they would need to do to get the environment setup by calling the batch files themselves.

I think that it goes outside the speed of using winget if I would need to set all those environment variables by hand.


add link to user github (append user  to )

Actually appended  link with inner html of username to user


Link "Drop off or send your laptops" to form

Connect to this form: https://forms.gle/Sf3DDRHpDsLfQSyj7

To clarify, the button shown in this screenshot (at the bottom of the page) should link to the form @pydanny mentioned above.

hey,can i work on this

would you like the form to open in the same or another tab?

Sure! Another tab would be great.


breaking API changes

This issue will be used to accumulate a list of proposed breaking API changes to be implemented as a batch (to minimize disruption) before we freeze the API, which may happen when the Bazel team decides how to rename Skylark.
Item: currently, both Function.Call and Builtin.Call do new(Frame), thread.push(frame), call, thread.pop(frame).  User-defined implementations of Callable should also do the same for calls of such functions to appear in stack backtraces.  Rather than require each implementation to do it, we should do it in the skylark.Call wrapper, and disallow direct calls to the Callable.Call interface method by renaming it CallInternal or CallImpl.

Item: change the result type of the Value.Hash method to uintptr---a register-sized integer.

Item: remove the Dict.Set method in favor of Dict.SetKey.


ref_app on Host Starts with LED0 Off

Might need to look into the logic of the simulated host-based LED0.

See also #577


Support of UIPageControl.

Added styling for UIPageControl (pageIndicatorTintColor and currentPageIndicatorTintColor).
It was mostly straightforward, just followed implementation of other controls. But L27-32 of NUIPageControlRenderer.m was required because none of the specified color does not take effect otherwise. It seems new color for each dot takes effect only after once being set as current.

Tests appear to be failing on Xcode 6.x due to the following:
Fetching: activesupport-5.0.0.beta1.1.gem (100%)
ERROR:  Error installing cocoapods:
	activesupport requires Ruby version >= 2.2.2.
The command "gem install cocoapods" failed and exited with 1 during .

@timbodeit Do you have a preferred way of resolving this issue? I can take a shot at tackling this but I have got to admit I am a novice with this whole Travis CI (and CI for that matter).

@Stunner See #325
I'm not exactly sure, why rubygems chose an incompatible beta version of activesupport, but installing via bundler works fine.

Awesome! LGTM.
Thanks for splitting everything up into small, understandable commits :+1:
Unit test coverage for this would be cool, but in my opinion this is good to merge once #325 is.


request: Add optional trpc-panel integration

Wanted to ask if you'd be open to adding an optional dev tool integration. Much like @nestjs/graphql exposes an option for playground: true. I'd love to add an integration for trpc-panel.
Proposal

Add trpc-panel as a (potentially optional/peer) dependency for the published package.
Expose a trpcPanel boolean option in the TRPCModuleOptions.
Right below where the trpc express middleware is added, add the trpc-panel middleware if enabled in the module options.

I'd say it could just be configured to map to the route `${options.basePath}/panel` by default.

This approach works best since it always would be initialized after the latest iteration of the schema file is generated. The alternatives below might technically initialize with a previous iteration of the schema if called before the newer one is generated.
Alternatives
If you don't like this idea, I'd like to request that either:

the appRouter object generated in the autoSchemaFile be declared as an export so that it could be imported and used to register tools like trpc-panel from it.
or alternatively, the appRouter object generated within the nest app itself could be provided as a value for some kind of globally scoped injection token so that we could inject that into a factory/service that would also enable us to initialize tooling like trpc-panel.

Interested in your thoughts, would be happy to help put up a PoC PR for this if you like the idea.

The @nestjs/graphql playground integration makes more sense to me because it is an official playground that will probably continue to be maintained and augmented with every change and update to graphql.
The trpc-panel on the other hand is a community project that has no guarantee to be updated in the feature, I am thinking about a scenario where trpc updates to a new version, and trpc-panel won't update for a couple of months to support the new version, this is problematic since if people are using this integration we will need to couple ourselves to another library release schedule to avoid breaking people's implementation.
I think a "Bring your own integration" makes more sense imo because of that, I can easily export the appRouter object if that will enable you to integrate with trpc-panel.
Wdyt? I've been working on this library for a while and to finally get some feedback on my implementation is amazing, so please don't shy away if you think my opinion is without merit.

Yeah, bringing your own integration definitely is the safer option from a maintenance perspective. It'd obviously also enable people to leverage whichever trpc-panel-like solution they prefer (trpc-openapi, trpc-devtools, etc...).
Just going the export route should definitely work fine enough. We might need to use an async import() to pull in the reference safely after a timeout in scenarios where the router file hasn't been generated yet (otherwise we'd hit a compilation error before it could), but I think that'd be OK.
A more NestJS way might be to ask the user to provide an injectable class in the module options that you'd call somewhat like how things work with context. You could just provide that class right away in the static forRoot for your own injection token. You could then inject that token later and call a method on the provided service instance only once with the combined appRouter after the router file is generated and trpc is running.
Maybe not with this name, but something like:
TRPCModule.forRoot({
  autoSchemaFile: "/src/@generated",
  context: AppContext,
  routerInitialized: TrpcPanelInitializer
}),

Similar to with contexts, you could expect any injectable class passed to something like this to implement an interface for something like:
export interface TRPCRouterInitializer {
  initialized(
    appRouter: CreateRouterInner<AnyRootConfig, ProcedureRouterRecord>,
  ): void;
}

That way we could just use DI to get the express app ref or whatever else we need from within our own class to stand things up more safely in response to the interface method getting called.

It seems that all of them need the runtime appRoute, in terms of DI I was thinking something similar to how the HttpAdapterHost is managed:
  @Inject(HttpAdapterHost)
  private readonly httpAdapterHost!: HttpAdapterHost;

You just inject it with Dependency Injection, and check if it's there:
const httpAdapter = this.httpAdapterHost?.httpAdapter;
    if (!httpAdapter) {
      return;
    }

@hrmcdonald It's been a productive Saturday!
I've added a working solution in v1.3.5, here is the new documentation page for it: https://www.nestjs-trpc.io/docs/integrations
There is also a working example here: https://github.com/KevinEdry/nestjs-trpc/blob/main/examples/nestjs-express/src/trpc-panel.controller.ts
I don't know why but when I merge a PR it closes the issue automatically, can you confirm this works for you?

Ah I see, this approach seems much better than anything I've suggested. I didn't think to grab appRouter from HttpAdapterHost, but AppRouterHost is a nice straightforward way to do that. Will check this out tomorrow to confirm, but this looks great!

Just confirmed, works great!

trpc-panel doesn't work with trpc v11, but this library works https://github.com/aidansunbury/trpc-ui


The ENV is finalized as KUBE_KUBELET_EXTRA_ARGS.

The ENV name is finalized as KUBE_KUBELET_EXTRA_ARGS in https://github.com/kubernetes/kubernetes/pull/59014.
Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

LGTM

/test pull-cri-containerd-node-e2e


custom_attributes in forward mode decorates metrics but not events

Description
In the PR #825 I wanted to add custom_attributes everything emitted to the backend.
The reason of doing this is because the backend decorates all the metrics and events that are attached to a host entity, but in forward mode there is no host entity so the metrics and events are no decorated.
It seemed to work properly but today we found that they decorate Metric but not events.
Let me do a tour:

here we add the custom attributes as extra labels.
They are emitted here
here they are separated into two maps if the label starts que label. or not (calling them labels and extraAnnotations)
So metrics will add the extraAnnotations but events will only emit the labels with no trace of extraAnnotations

I would like to have the context why this is this way and if this is the expected behaviour (and fix it if not).
 The YAML I used is this one:
is_containerized: true
override_host_root: ""
http_server_enabled: true
http_server_host: <IP_ADDRESS>

verbose: 1

license_key: REDACTED
staging: true

is_forward_only: true
is_secure_forward_only: false

custom_attributes:
  attributeAsCustomAttribute: "go run"

All these variables are the expected to have the k8s-events-forwarder container with the patches we do at helm chart level to make it working as expected.
Once the agent is running a simple do a local curl -qXPOST -d @payload.json localhost:8001/v1/data with this payload:
{
  "name": "kube_events",
  "protocol_version": "3",
  "integration_version": "1.6.0",
  "data": [
    {
      "entity": {
        "name": "test-nri-kube-events-7489bb9d67-gcg8p",
        "type": "k8s:test:default:pod",
        "id_attributes": []
      },
      "metrics": [],
      "inventory": {},
      "events": [
        {
          "summary": "Example of payload",
          "category": "kubernetes",
          "attributes": {
            "clusterName": "test",
            "attributeInPayload": "test"
          }
        }
      ]
    }
  ]
}

attributeAsCustomAttribute never appears in the event.

I noticed that the PR  is adding that to v4 emitter, would this apply as well to integrations sending v3 payload?

Validate with @jlegoff if this is the expected behaviour.

We are on it :)

Confirmed by @jlegoff here (internal).


Allow to override host/port for dev server

Is this a bug report?
No
This is related to #3814
We embedded a CRA-created app within another, larger app and would like to be able to adjust the host/port combination the webpack dev server/client use to connect to each other.
Our use case: the CRA-created app is a new frontend for a part of an existing application and requires authentication to access. Authentication is done via a session / cookie and therefore requests from the CRA-created app are required to send the session cookie alongside. This can be achieved in other ways than living on the same host/port combination as the "host" application but just serving it directly from the "host" application is certainly the easiest way when you don't have an existing SSO endpoint.
The problem: We run the dev server alongside the "host" application. We access /static/js/bundle.js via http://localhost:3000/static/js/bundle.js in an HTML file served by the "host" application (e.g. on host/port example.com:80). When accessing that HTML file served by the host application, the JS is loaded successfully. It then tries to connect to the webpack dev server on http://example.com/sockjs-node/... which is not working obviously because the dev server is running on localhost:3000.
We can successfully develop using that setup, just the dev server/hot reloading is not working.
I assume this would need one adjustement in react-dev-scripts to accept an env variable to connect to the dev server. Maybe we also need to adjust something based on an env variable in the dev webpack config.
Is this feature out of scope for CRA or would you be open for a PR?
A minimal reproducible example to show this:

create a new CRA app
run yarn start / npm start
create somewhere a new directory with just an index.html containing the following:

<!DOCTYPE html>

  <meta charset="utf-8">
  <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
  <title>React App</title>

use a static HTML server like serve for that directory and access it.
you'll notice the react app gets served correctly, webpack-dev-server related requests fail because they go to the wrong host/port combination.

There are Advanced Configuration Docs.
Take a look at HOST and PORT.

@miraage I'm aware of HOST and PORT but that doesn't help in this case.
It could be you misunderstood the issue description, I'll try to explain it differently:

CRA-App is started using npm start listening on http://localhost:3000
Host-App is started, listening on http://example.local
Browser accesses http://example.local/cra-app which contains the HTML I posted above
Browser gets bundle.js from CRA dev server (http://localhost:3000/static/js/bundle.js)
After the bundle is downloaded, it tries to establish a websocket (sockjs) connection to window.location.hostname / window.location.port which is in this case example.local and port 80

Therefore the bundle tries to connect to the wrong host/port combination because the dev server only listens on localhost:3000.

Running into the exact same problem where I need to have SocketJS connect to something other than what is found in window.location.

Running into this issue as well with a similar setup. If I just go into "node_modules" and edit webpackHotDevClient.js to fix the websocket port, then it works. You get basically the same thing as the auto-reloading page from "npm start" except servable from a backend app (it also means you can template the index.html with a backend framework).
I think ideally the port (and maybe host) that I modified locally in webpackHotDevClient.js would be configurable.

I would love to know why this is still an issue, as this isn't the only issue open for it.
The logic thrown about in that other issue astounds me; exposing a defaulted port/host combo for this will in no way make weird or otherwise unwanted compromises for end-users. I've worked with enough people where ejecting is the norm, and this is consistently a pain point that nobody seems to want to press CRA about much because they've indicated it won't change.

Just wanted to leave another vote for this feature.
I'm integrating a CRA app into a .NET MVC app, so like others I am running the app from a different port.
This wouldn't even have to be configurable, the port in webpackHotDevClient.js just needs to use the same port as the dev server, then it would continue to work for the 99% of users who don't care about this, and would work for those of us trying to integrate CRA apps into another app.

We are running into this issue as well. In our case, it is because we are running two separate projects on the same domain, and the one using this feature is on a subpath using a reverse proxy. ProjectA runs on http://mysite.local and ProjectB (which uses CRA) runs on http://mysite.local/sub, which is reverse proxied to localhost:9090. I would love to be able to tell webpackHotDevClient to use localhost:9090 as the hostname/port.

For reference webpack-dev-server's client has a nice solution to this: it uses the host/port in the url of the


React Play Password Generator

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

@Angryman18 Great, could you please open an issue for this one?

@Angryman18 Great, could you please open an issue for this one?

how do i do that? im not so good with github yet.

@Angryman18 Great, could you please open an issue for this one?

how do i do that? im not so good with github yet.

Added https://github.com/atapas/react-play/issues/144
please add the relevant details.

@Angryman18 Great, could you please open an issue for this one?

how do i do that? im not so good with github yet.

Added #144
please add the relevant details.

added

@all-contributors please add @Angryman18  for Code

@Angryman18 Thanks for your first contribution to the project. Looking for more to come, yay 😀.
If you are planning to share your contribution experience anywhere publicly, please tag our Twitter handle(https://twitter.com/ReactPlayIO). Also, don't be shy to support the project with a star. Keep going.


Difference between create-react-native-app and Expo?

Sorry if this is not the best forum, but what is the difference between using create-react-native-app and using the Expo toolset?  And why would someone pick one or the other?

Good question, the short answer is that create-react-native-app is the quickest way to start a new React Native project. It uses the Expo client and some of the Expo devtools but not all of them. For example, you don't need to create an Expo developer account to use CRNA and we've found it's faster to get started with CRNA than with XDE (the Expo development app).
Since CRNA projects run in the Expo client, you do have access to most of the Expo APIs such as native maps, audio, OpenGL, and more. There are a couple of exceptions like push notifications that only Expo projects can use, but there are many more similarities than differences between CRNA projects and Expo projects.
CRNA was also designed to give you several paths forward as your app grows. The three paths are:

Use Expo: You actually can open a CRNA project with the Expo XDE app if you want all the features of Expo including push notifications and IPA / APK files for the App Store / Play Store.
Eject to ExpoKit: ExpoKit is a native library that includes React Native and the Expo APIs. This path creates Xcode and Android Studio projects with ExpoKit so that most Expo APIs keep working if you were using them before. You then build IPA / APK files the way you would as any other native app.
Eject to bare React Native: This path gives you a plain React Native project with separate Xcode and Android Studio projects. All modules that come with React Native will work but Expo APIs won't work (use ExpoKit above for that) because this is bare React Native.

Note that when you eject, CRNA won't manage upgrades for you so you're responsible for upgrading React Native.

I notice that the file structure for a CRNA is different than both typical react native and Expo generated apps.  (Especially the roots of the apps are different. (eg: No index.ios.js)  Also the way the root file is setup is different. (eg: CRNA apps don't register their entry component, but instead export them).
Is there any documentation of all of this?
thanks
Phil

Not yet!

In that case I would advise others getting started to do what I did.  Create sample apps in all three environments (React native, CRNA, and Expo).  Then open them all up at the same time in Atom to look at the file structure of each one.  That way when you are flipping between the documentation of all three you will have a reference to what is going on.
cheers

Does one need to eject to ExpoKit in order to use the expo push notifications?

@kristojorg To use Expo Push Notifications you'll need to use Expo's devtools (XDE or exp, docs here: https://docs.expo.io) which will enable your project to send push notifications.
If you eject to ExpoKit, Expo push notifications won't work (as of April 2017) and instead you should use the native iOS & Android APIs to get the device token and send push notifications manually.

@ide Thank ! Somehow the push notifications just started working... before I was getting: The recipient "ExponentPushToken[xxx]" isn\'t associated with any device.
For the record, I am still somewhat confused as to if there is a difference between running a CRNA via command line yarn start:ios and via opening through XDE, and how that relates to push notifications... but I'm glad it is working now!

CRNA projects are designed not to depend a lot on Expo services. For example you don't need an Expo developer account. When you use XDE you now have an Expo account and are developing an Expo project so you can use Expo services.

if eject to expoKit , i cant run command "react-native run-android" ?

@vinhdev With ExpoKit you run your Android project from Android Studio / Gradle / whatever you'd use for a typical Android project. The only react-native CLI command that is supported is react-native link. These are more docs on ExpoKit: https://docs.expo.io/versions/latest/guides/expokit.html

how does expo build app with native android/ios SDKs?

Project created from expo toolkit doesnot have ios file. Should i create file my self? or what is the correct method?

Same question here. Why it does not have index.ios.js and index.android.js? Feel a bit confused while following tutorials online.

You can just start writing code in App.js. If you want to have separate files for each platform, you can make App.ios.js and App.android.js but it's more common to share the files by default.

When installing the new version of react-native and being forced to use Expo, I notice that when making some simple change, the reload is slower.
Are you the same?

Expo shouldn't be slower. If you're using exp or XDE, those set up an exp.direct tunnel URL by default which goes over the internet. This is slower but lets you share your project with collaborators or devices that aren't on the same WiFi network. You can set exp or XDE to use a LAN IP URL instead if all your devices are on the same network and can access each other.

Can we add third party lib which needs to add code in xcode and android studio when using Expo?

@Albinzr  https://www.google.ca/search?q=Can+we+add+third+party+lib+which+needs+to+add+code+in+xcode+and+android+studio+when+using+Expo%3F&oq=Can+we+add+third+party+lib+which+needs+to+add+code+in+xcode+and+android+studio+when+using+Expo%3F&aqs=chrome..69i57j69i64.121j0j7&sourceid=chrome&ie=UTF-8

Am i able to run app on ios if i eject to expokit?

yes

How to handle Expo Xde in case of ubuntu?

@Mythrim you don't need to use the XDE IDE, you can use the command line

Thank you for CRNA and Expo,
Apps that use only Expo can't launch first time with no internet connection, it requires Internet, so the JS bundle and assets are downloaded then the app runs normally, is that situation the same in CRNA apps?
Do CRNA apps run with no Internet in the first launch?

Hello
I'm totally new to react and reactnative, was wondering if someone can provide guidance. I would like to build an iOS and Android app, on a Windows laptop. Is it possible to compile the iOS app this way? If so please provide some insight on this.
Tks
Lawrence

He @lawrenceong001 I have created app using expo. So all I did is followed this  so now I'm able to run my app without emulator/simulator all I need to do was to keep my windows machine and mobile device in the same network.
After that you may need to go with some starter kit / boilerplate so launching starter kit like this is currently a challenge for me too, I'm figuring it out.

Thanks @sohaibjaved44, I was wondering if I can also deploy to Apple  appstore without a Mac too.

so if i had to chose
which one i should chose ?

@Mifayo
In my experience, simply stick to react-native init.
Save yourself from headaches.

According to @anp there is no official tutorial on how to properly eject CRNA to build non-debugging versions for on-device deployment and this obviously hasn't changed for nearly one year. Having spent months on creating app using CRNA and now I have to study code of react-native to get an idea of how to fix the missing index.ios.js/index.android.js-issue? There is no tutorial and that's it?
Is there any ongoing development on supporting CRNA at all? Why care for it at all if ejecting was working some day in the past but no one has taken care of this path working for that long time. Maybe just fix the docs explaining that using CRNA might render wasted time ... won't take a day to add this explanation. And it would help devs from even trying CRNA in the first place. AFAIU it would reduce manpower required to develop Expo App, too ... WinWin for everyone.

@soletan I'm a bit confused about what you're having issues with -- can you open an issue with more details on what you're trying to achieve?

Well, sorry for hijacking this thread most probably.
I was basically having issues with problems mentioned in this thread before regarding missing index.ios.js files in a CRNA, even after ejecting it. I was referring to you due to your instant answer to that post considering the lack of some documentation.
My app still isn't running after ejecting it. The lack of index.js had to be fixed manually. Can't remember having read anything about that in any of the docs. And docs are quite distributed. In one place eject is claimed to ask questions about how I want to build things, but that didn't happen in my case. SO indicates use of react-native upgrade being required. Stumbled over probaby requirement to invoke react-native link in a different place. Eventually I'm stuck with built app claiming to fail due to using Expo APIs. Guess I have to keep gathering more documentations or find a system I'm willing to pollute with quite unstable WSL so I can put several GB of Linux distro on it just to run exp on a Windows computer.
Claiming CRNA to be a good start for creating react-native applications is pretty misleading. Okay, might be a good start, but it's a terrible end as all time saved in the beginning is wasted steps before finish line.

I have a question about Privacy/Security. As mentioned in docs, I need to send my bundle to Expo build it and even my keystore. I wonder to know who is Expo and what kind of trusts do I have.
About the docs, IMO, Expo should not be at the react native quick start section since it is a company that offer support as business model. It`s a joke.

will apple approve CRNA apps? looks like its hot code push through expo xde slug url.

@dsp1589 - yes they will. same thing as other react native apps, and millions of cordova apps, etc.

@soletan - thanks for the info, a new issue for that would be great.
@allanesquina - you also don't need to send your keystore if you want to build it locally - https://github.com/expo/expo#standalone-apps. additionally, just use react-native init if you want. nobody is forcing you to use this.

About the docs, IMO, Expo should not be at the react native quick start section since it is a company that offer support as business model. It's a joke.

I don't understand your argument here, but if you feel very strongly about it please open a PR on react-native with your suggested changes to the getting started guide and your arguments for why this should be done and we can certainly discuss. Either way this thread is not the right place.


Cannot create new ship.

From Reddit: https://www.reddit.com/r/XWingTMG/comments/7a5fmj/hotac_ship_builder_site/
As soon as you press "Start" after putting in a name and callsign, it tries to continue but returns you to the start screen. In the (Chrome) console it spits out:
Unhandled promise rejection Error: Loading chunk 0 failed.
Stack trace:
e@http://hotac-ship-builder.netlify.com/js/vendor/json-url/json-url.js:1:738
 json-url.js:1:45068

Unhandled promise rejection Error: Loading chunk 0 failed.
Stack trace:
e@http://hotac-ship-builder.netlify.com/js/vendor/json-url/json-url.js:1:738

~Apparently effects all browsers?~
Personally tested only on Windows 7/8, on IE11, Chrome and Firefox

Alrighty, I got the repo building. I'm going to try to explore this issue (despite my minimal JS knowledge xD)

Thanks for the bug report. I'll take a look.
This is still totally alpha software. Nominally the "Public alpha" milestone was the point I was working to have a stable version to be announced and released to the public. I'm amazed anyone knew this project existed yet! (but happy you find it useful)
I've just merged the last issue I had on the list for the alpha (fixing the print layout a bit better) so I'll take a look at this :)

I think this is related to the JSON URL library, which does some asynchronously loading which i think may be causing the issue. Strangely I don't get this on my local development machine, so perhaps it is something to do with the javascript aggregation on Netlify. I'll take a look.

Interestingly, this issue doesn't manifest on android chrome, only desktop chrome

But you were able to recreate it? That's good

Yes, I have been able to recreate locally. It also only happens on the first page load. If you link via URL into an existing ship build, the page loads fine, and then if you "Start a new ship" from there, it also works fine. It is only completely new page loads from the root URL which fail.
I'll continue to investigate

Ok, it looks like when clicking the button, it was actually submitting the html form and refreshing the page, which is not supposed to happen unless the button had type="submit". Perhaps because it was the only button in the form some browsers pick it as the default submit?
Regardless, I've prevented the submit action via javascript, so it is now working again :)

BTW - now that I can actually use this, I LOVE this! I definitely going to keep poking around and try to do some simple changes later. :)


Enforce code style

This does following things:

Sync eslint and prettier configs. This means that linting won't show errors for code fixed by prettier.
Make prettier mandatory, else travis builds will fail (added to test script)
Run prettier on all files

Closes #243.

just curious, should we enforce single quotes? looks prettier :p

I usually do, but this project contains a lot of double quotes so I didn't. Will gladly add it though 👍.
Damn, that was a real quick review... 😛

Lol I get notifications for evverything

Actually prettier prefers double quotes, and we should use them for JSX, so maybe we should keep it like that.

cool makes sense

Guess there's no need to publish a new version for this as it actually doesn't change anything except for contributors, so I can just go ahead and merge this, right?

yep


Usage of GRU instead of an LSTM

Hey @ruotianluo, thanks for your implementation!
I was wondering how the performance of the model would change, if a GRU was used instead of an LSTM. Have you tried it before. If you have any information on this, it would be very helpful.
Thanks!

I have once tried using GRU instead of LSTM, for simple soft attention model, the results seems equal.


Setup documentation and deploy it

We will need to have documentation available online. I suggest we go with the standard Python tool for documentation, i.e. sphinx, which can extract and render docstrings.
We will need the following part of documentation

[ ] Introduction and how to install & use the code
[ ] Tutorials: i.e how to use the code in simple cases. This is currently done in notebooks in kernel-tutorials. We could refer to these notebooks in a way or another for tutorials
[ ] API reference, i.e. how to use the code in details. This will be taken from the docstrings

Regarding deployment, the two main options we have are github pages (the doc would live at https://cosmo-epfl.github.io/sklearn-cosmo/ by default) or readthedocs (https://sklearn-cosmo.readthedocs.io/ by default).
If anyone wants to have a go at setting up the documentation, I'm happy to mentor them. Else I'll do something in the next few weeks.

++ readthedocs, highly prefer that medium to github pages

There should be no difference in the generated doc between github pages & readthedocs, since both would be based on sphinx.
Do you have any specific issues with github pages?
I tend to prefer github pages because I had some issues with readthedoc compilation environment for a C++ based project (not really applicable here, but we still have more control over doc deployment with github pages). The big advantage I can see for readthedocs is the automatic generation of project.readthedocs.io/latest/project.readthedocs.io/v0.1.0/project.readthedocs.io/v0.2.0 (i.e. having doc online for multiple version of the project). This can be acheived on github pages but needs a bit more work.


Non-existent CSS variables

Over time we seem to have accrued quite a few references to css variables that don't exist. I stumbled upon this when testing IE11 and noticing the console warnings from the css vars polyfill (there might be an easier way), but here is the current list..

It may be worth researching each case individually, particularly the line-height-sm one just in case we regressed visually without realising. Visual testing is coming at some stage soon.

I'll try and pick this one up, but in case I get distracted in the meantime, you can do this to the css vars polyfill...
    cssVars({
      watch: true,
      onlyLegacy: false
    });

Which in turn will flag issues even on newer browsers.


How much memory need?

How much memory need to brute with config -N -c -C --max-length 6 --min-length 6 ?

Thank for the issue.
I just rewritten the some part of code to fix this issue. Now, in my computer, only take +-20MB of RAM to run.


update TOC and breadrumb toc to point to aspnet.core hub

Internal Review for TOC and Breadcrumb changes
Updating the aspnet (asp.net 4.x) toc to point to the new aspnet.core hub index.yml
This needs to be updated immediately so we can delete the old index.md it references.   As a second PR we will look at adding .NET hub to beginning of breadcrumb.

@scottaddie, I think we have no choice but to use the full URL's when linking across repos.  The short relative ones you checked in don't work and now result in 404.  We also had tested that on the aspnet.core repo hub going the other way and that didn't work either.  So I will revert.  It was good to test again though just in case, thanks.

@scottaddie, Maybe relative URI's across repos don't work just on staging but do in production?  Do you know of an example across repos that works?

@wadepickett It seemed like relative links would work based on what I saw at https://github.com/dotnet/docs/blob/a3321dfeab85b09be07c4a9f64a220c03a95185a/docs/breadcrumb/toc.yml#L427.

@scottaddie,
Good point, if I remove "review" of the link it generates, it is a real URL that resolves to topic.  So I guess the issue is just on staging, not on production.  So...  with your thumbs up, I will push this with your changes, I'll test as soon as its propped.
dotnet breadcrumb example you pointed to:
There are 224 links in there and all of them are for the dotnet repo.  That one will use Toc Href that references /visualstudio/ for example but even for those the topic link (topicHref) points to a topic that is actually on /dotnet/.  See example below.  Maybe you were looking at tocHref and assuming it was topic link.
  - name: Get started
    tocHref: /visualstudio/get-started/csharp/tutorial-wpf
    topicHref: /dotnet/desktop-wpf/getting-started/index


_target is lost on Form updates with 0.7.1

Describe the bug
After updating to Surface 0.7.1 from 0.7.0 the correct _target is no longer sent along with Form change events. This has broken a few of my forms which depend on knowing which inputs have triggered the form change events.
This seems to be due to switching to the JS.push API in this commit https://github.com/surface-ui/surface/commit/6aab9139c66bc242be6d6c58d1c2e7ad646504aa, the traditional way still works as expected.
Here is an open bug by Chris McCord regarding this problem in LiveView.
https://github.com/phoenixframework/phoenix_live_view/issues/1850
I'd expect the target to be sent as per normal.

instead of arriving like this

Your Environment
Surface: v0.7.1
LiveView: v0.17.7
Elixir: v1.13.3

@kernel-io yeah, it's a LV bug. We can't just revert that commit as we need to use JS.push to properly set the target. I'm not sure how complex is to fix that in LV but it seems quite critical so I hope it will be fixed soon. The only workaround I can think of is to maybe pass the phx_change explicitly along with the phx_target using the opts prop.

wonderful idea, I just reverted to 0.7.0, I'll try setting that attribute via opts and update if it doesn't work.

For me it worked (setting opts={phx_target: @myself})

For me it worked (setting opts={phx_target: @myself})

This doesn't resolve the issue that this issue is about, this is about _target not being set on change events, usually it contains the name of the input which triggered the change.

Ahh I see, but is this problem not also linked to the issue of the event itself being sent to the wrong target? But good point!

nope, but I've just run into that issue you are referring to 😆

I'm closing this as it can only be fixed in LV itself. To follow the issue please see https://github.com/phoenixframework/phoenix_live_view/issues/1850.


home-assistant-custom-components.spook: init at 3.0.1

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)

Tested this with my home-assistant instance

24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

If it ships two components, can we expose them as two dedicated component packages, sharing the same src?

If the repo contains two components, can we expose them as two dedicated component packages, sharing the same src?

@mweinelt They aren't supposed to be installed separately, in HACS there's just a single Spook package. spook_inverse is a helper that's meant to be a part of spook. The separate manifest.json is just a hack that makes it possible to provide a helper – it wouldn't be possible otherwise, as the integration_type: "hub" in the core manifest does not let the component provide helpers.
It's just kind of messy. The HACS version does this weird thing where it symlinks spook_inverse to custom_components then restarts hass, which I patched out here. Separating it into two packages is not the intended use, but it's technically possible as the child component doesn't really depend on any code from the parent. Should I try do that or keep it reasonably close to upstream?

@ofborg test home-assistant

Thanks!


bgpv2: Status reporting document

Document recently added status conditions and bgpControlPlane.statusReport.enabled flag.
bgpv2: Status reporting document

/test

/test

/test


Move all lambda functions to use Graviton2 for cost optimisation

Our lambda function defintion from here https://github.com/intuit/Trapheus/blob/master/template.yaml#L178C24-L178C24 needs to be moved to Graviton,
Lambda offers two instruction set architectures in most AWS Regions: x86 and arm64.  Lambda functions powered by Graviton2 are designed to deliver up to 19 percent better performance at 20 percent lower cost.
We should move our functions to explicityly use Graviton2 (see example below)
MyFunction:
  Type: AWS::Serverless::Function
  Properties:
    Architectures:
      - arm64  #  use Graviton2
      -

@stationeros assign this to me,  i will pick this up

@srikanth597  PR for this is already raised here https://github.com/intuit/Trapheus/pull/167/files .

Thanks @srikanth597  for contributing. Do star the repo to show us some support.