[sentry-native] Build error

Host Environment

OS: macOS 12.4
Apple M1 Max

To Reproduce
Steps to reproduce the behavior:

add sentry-native dependency to the vcpkg.json
cmake -DCMAKE_TOOLCHAIN_FILE=vcpkg/scripts/buildsystems/vcpkg.cmake ../build -G  Xcode

Failure logs
config-arm64-osx-dbg-err.log
CMake Error at /opt/homebrew/Cellar/cmake/3.24.0/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find PythonInterp (missing: PYTHON_EXECUTABLE) (Required is at
  least version "2.7")
Call Stack (most recent call first):
  /opt/homebrew/Cellar/cmake/3.24.0/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  /opt/homebrew/Cellar/cmake/3.24.0/share/cmake/Modules/FindPythonInterp.cmake:169 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  /Users/user/projects/vcpkg/scripts/buildsystems/vcpkg.cmake:824 (_find_package)
  external/crashpad/util/CMakeLists.txt:379 (find_package)

config-arm64-osx-dbg-out.log
-- The C compiler identification is AppleClang <IP_ADDRESS>00029
-- The CXX compiler identification is AppleClang <IP_ADDRESS>00029
-- The ASM compiler identification is Clang with GNU-like command-line
-- Found assembler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- SENTRY_TRANSPORT=curl
-- SENTRY_BACKEND=crashpad
-- SENTRY_LIBRARY_TYPE=STATIC
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of long
-- Check size of long - done
-- Found ZLIB: optimized;/Users/user/projects/int_macos_64/vcpkg_installed/arm64-osx/lib/libz.a;debug;/Users/user/projects/int_macos_64/vcpkg_installed/arm64-osx/debug/lib/libz.a (found suitable version "1.2.12", minimum required is "1")
-- Found ZLIB: optimized;/Users/user/projects/int_macos_64/vcpkg_installed/arm64-osx/lib/libz.a;debug;/Users/user/projects/int_macos_64/vcpkg_installed/arm64-osx/debug/lib/libz.a (found version "1.2.12")
-- Configuring incomplete, errors occurred!
See also "/Users/user/projects/vcpkg/buildtrees/sentry-native/arm64-osx-dbg/CMakeFiles/CMakeOutput.log".
See also "/Users/user/projects/vcpkg/buildtrees/sentry-native/arm64-osx-dbg/CMakeFiles/CMakeError.log".

Users/user/projects/vcpkg -D_VCPKG_INSTALLED_DIR=/Users/user/projects/int_macos_64/vcpkg_installed -DVCPKG_MANIFEST_INSTALL=OFF -DCMAKE_OSX_ARCHITECTURES=arm64 -G Ninja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=/Users/user/projects/vcpkg/packages/sentry-native_arm64-osx/debug
    Working Directory: /Users/user/projects/vcpkg/buildtrees/sentry-native/arm64-osx-dbg
    Error code: 1
    See logs for more information:
      /Users/user/projects/vcpkg/buildtrees/sentry-native/config-arm64-osx-dbg-out.log
      /Users/user/projects/vcpkg/buildtrees/sentry-native/config-arm64-osx-dbg-err.log

Call Stack (most recent call first):
  /Users/user/projects/int_macos_64/vcpkg_installed/arm64-osx/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:357 (vcpkg_execute_required_process)
  buildtrees/versioning_/versions/sentry-native/3dff7be1b47155d1580f43be48d8b95761251883/portfile.cmake:34 (vcpkg_cmake_configure)
  scripts/ports.cmake:147 (include)

error: building sentry-native:arm64-osx failed with: BUILD_FAILED
Please ensure you're using the latest port files with `git pull` and `vcpkg update`.
Then check for known issues at:
    https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+sentry-native
You can submit a new issue at:
    https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[sentry-native]+Build+error
Include '[sentry-native] Build error' in your bug report title, the following version information in your bug description, and attach any relevant failure logs from above.
    vcpkg-tool version: 2022-07-21-a0e87e227afb536c62188c11ad029954f28fdb22
    vcpkg-scripts version: 581099d54 2022-08-11 (5 hours ago)

Additional context

Python is installed and available with command python3
Reinstallation of python with brew doesn't help
It builds fine on x86 mac

Linking python3 to python can be used as 💩 workaround
ln -s /opt/homebrew/bin/python3 /opt/homebrew/bin/python
sudo ln -s /Applications/Xcode.app/Contents/Developer/usr/bin/python3 /Applications/Xcode.app/Contents/Developer/usr/bin/python

This issue hasn’t been updated in 1 month, if it is still an issue, please reopen this issue.


refactor: clean up deployer db resources, delete after sync to r-r, delete secrets command

Description of change

Resources are deleted from deployer after they have been successfully synced to r-r.
Deleted the secrets CLI command since it only targeted the deployer cache. The new way is to use resource list
Drop secrets table. Is possible due to the above.

How has this been tested? (if applicable)

Tested with inserting a resource in deployer, and the resource list operation correctly synced them up to r-r. The project could then be deleted without hassle.

Have you tested it through an update of Shuttle ?

My test with inserting an old record mimics the upgrade from an old version (based on what I observed during support week). I would have to go back several months to do it "naturally". To me, this is sufficient.


[TreeView] Enter toggles but doesn't select item

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
When you press enter on an item in TreeView in single-select mode it does not select it (it toggles it, but doesn't select it).
Expected behavior 🤔
The aria docs indicate the following (https://www.w3.org/TR/wai-aria-practices/#keyboard-interaction-24):

Keyboard Interaction
Enter: activates a node, i.e., performs its default action. For parent nodes, one possible default action is to open or close the node. In single-select trees where selection does not follow focus (see note below), the default action is typically to select the focused node.

By default the TreeView component has multiSelect set to false, which seems to indicate it's in single-select mode. In this case I might expect pressing the enter key to cause a node to be selected.
Steps to reproduce 🕹
Steps:

Navigate around a TreeView with the keyboard.
Press enter on an item.

Context 🔦
No response
Your environment 🌎
No response

It is a bug, I can reproduce. Space activates the node, but Enter doesn't.

I'm going to fix it

I don't know how to link a pull request with an issue, but I fix it
https://github.com/mui-org/material-ui/pull/30795

The linked change does cause select to be triggered on enter now. But enter still causes a toggle of the node if it has children. I'm not sure this fix is better and is perhaps worse, as now enter has different behaviour depending on whether the node has children or not.

Enter: activates a node, i.e., performs its default action. For parent nodes, one possible default action is to open or close the node. In single-select trees where selection does not follow focus (see note below), the default action is typically to select the focused node.

See the last highlighted line in particular.
I wonder if the behaviour that would be ideal for a single-select tree is:

Use arrow keys to traverse the tree and open and close nodes
Use enter key to select keys exclusively

Any thoughts?


Dev

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

16 of 17 (94.12%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 89.448%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

contracts/child/modules/CVSStaking.sol
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
908

Relevant Lines:
984

💛  - Coveralls


'WebSocket' object has no attribute 'page_id'

Seems like there's an error in this branch of code:
ERROR:    Exception in ASGI application
Traceback (most recent call last):
File "C:\Users\youngta1\AppData\Local\Continuum\anaconda3\lib\site-packages\uvicorn\protocols\websockets\websockets_impl.py", line 153, in run_asgi
result = await self.app(self.scope, self.asgi_receive, self.asgi_send)
File "C:\Users\youngta1\AppData\Local\Continuum\anaconda3\lib\site-packages\uvicorn\middleware\proxy_headers.py", line 45, in call
return await self.app(scope, receive, send)
File "C:\Users\youngta1\AppData\Local\Continuum\anaconda3\lib\site-packages\starlette\applications.py", line 102, in call
await self.middleware_stack(scope, receive, send)
File "C:\Users\youngta1\AppData\Local\Continuum\anaconda3\lib\site-packages\starlette\middleware\errors.py", line 143, in call
await self.app(scope, receive, send)
File "C:\Users\youngta1\AppData\Local\Continuum\anaconda3\lib\site-packages\starlette\middleware\gzip.py", line 20, in call
await self.app(scope, receive, send)
File "C:\Users\youngta1\AppData\Local\Continuum\anaconda3\lib\site-packages\starlette\exceptions.py", line 58, in call
await self.app(scope, receive, send)
File "C:\Users\youngta1\AppData\Local\Continuum\anaconda3\lib\site-packages\starlette\routing.py", line 550, in call
await route.handle(scope, receive, send)
File "C:\Users\youngta1\AppData\Local\Continuum\anaconda3\lib\site-packages\starlette\routing.py", line 283, in handle
await self.app(scope, receive, send)
File "C:\Users\youngta1\AppData\Local\Continuum\anaconda3\lib\site-packages\starlette\endpoints.py", line 76, in dispatch
await self.on_disconnect(websocket, close_code)
File "C:\Users\youngta1\AppData\Local\Continuum\anaconda3\lib\site-packages\justpy\justpy.py", line 220, in on_disconnect
pid = websocket.page_id
AttributeError: 'WebSocket' object has no attribute 'page_id'

This may happen if you have a window open and you restart the application and then close the window. Since the application has restarted, it does not recognize the old window.


dart-sass 1.50.1 is out and includes arm64 binaries

https://github.com/sass/dart-sass/releases/tag/1.50.1
If trunk updates to use dart-sass 1.50.1, I think trunk will now be usable on arm64!

hmm, I just noticed dart-sass 1.50.0 already had arm64 support. I still get this error when trying to use trunk on linux arm64 though:
[...]
2022-04-22T18:29:38.237973Z  INFO downloading sass version="1.50.0"
2022-04-22T18:29:38.241185Z  INFO finished copying directory path="fonts"
2022-04-22T18:29:38.250793Z ERROR  error
error from HTML pipeline

Caused by:
    0: error from asset pipeline
    1: failed downloading release archive
    2: unsupported architecture
Error: error from HTML pipeline

Caused by:
    0: error from asset pipeline
    1: failed downloading release archive
    2: unsupported architecture

Is it failing on the download after dart-sass but not saying which tool it's trying to download?

It must be wasm-bindgen. Sorry for the noise. Closing.


experimental grpc server for span collection

This PR is an offshoot of a discussion in openzipkin/zipkin-api#57 . There are a number of issues that need to be addressed before consideration of merge:

[ ] Finalize the API and merge it into zipkin-api
[ ] Find a zero-duplication and zero-copy approach for the deserialization of spans on the server side
[ ] Add additional configuration options for configuring the server (i.e. SSL)
[ ] Integration test with GCP
[ ] Performance testing

Also, there is still some discussion about whether the project as a whole wants to support a gRPC endpoint in zipkin-server due to potential bloat. See the discussion in zipkin-api#57 for background.

curios... maybe @trustin or @anuraaga would know.. is there a way to run both normal http and grpc's http on the same port? Currently, we use undertow underneath, but we could consider changing that.

If you use armeria :) Upstream gRPC doesn't support it yet I think, or even if it did it would only be HTTP/2, not HTTP/1.

If you use armeria :) Upstream gRPC doesn't support it yet I think, or
even if it did it would only be HTTP/2, not HTTP/1.

frankly I think we should switch to armeria then. we have several
contributors who are also contributors to armeria. zipkin always tries to
be simplest possible setup and adding ports betrays this. if we are talking
about grpc being shaded anyway we can just make stackdriver use the shaded
one (or potentially convert its storage module also to armeria)

I guess the talking points would be that armeria still isn't GA and has more dependencies. But agree that more ports is annoying and a big reason I love armeria :)

we dont promise any api compat for our server, so not worries. if we did
armeria we would just add grpc endpoint directly to the zipkin-server imho
and not mess with extra modules.
On Sun, Dec 16, 2018, 11:52 AM Anuraag Agrawal<EMAIL_ADDRESS>wrote:

I guess the talking points would be that armeria still isn't GA and has
more dependencies. But agree that more ports is annoying and a big reason I
love armeria :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/pull/2328#issuecomment-447615813,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD615g9RvQRBh3NmUZu5W5YK1v4W-b8ks5u5cORgaJpZM4ZU_jb
.

also good point on the deps of armeria. similar audit would apply to ensure
things still work ;)
FWIW current Cassandra driver supports a range of guava starting at 16
iirc. later it doesnt depend on guava. almost everything else has no
conflicts due to okhttp directly. we would need to watch that zipkin-aws
and zipkin-gcp extensions dont conflict.
On Sun, Dec 16, 2018, 11:59 AM Adrian Cole<EMAIL_ADDRESS>wrote:

we dont promise any api compat for our server, so not worries. if we did
armeria we would just add grpc endpoint directly to the zipkin-server imho
and not mess with extra modules.
On Sun, Dec 16, 2018, 11:52 AM Anuraag Agrawal<EMAIL_ADDRESS>wrote:

I guess the talking points would be that armeria still isn't GA and has
more dependencies. But agree that more ports is annoying and a big reason I
love armeria :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/pull/2328#issuecomment-447615813,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD615g9RvQRBh3NmUZu5W5YK1v4W-b8ks5u5cORgaJpZM4ZU_jb
.

I can look into armeria as an alternative.
The biggest trick here is going to be in the serializer though. We have to use Zipkin’s Proto3Codec instead of relying on the server implementation to deserialize the span payload. I’m not sue if any of the server implementations support the concept of lazy deserialization. If they don’t, then I’ll have to plug into the serialization pipeline.

For the zero copy aspect, it might be simplest to define the client API in zipkin-api as is but use an internal proto here that replaces Span with bytes.  Appears that armeria is choosing not to shade netty in the future - https://github.com/line/armeria/issues/705.
On the plus side, I believe you can run HTTP/1, gRPC, and gRPC-Web all from the same server instance. GRPC-Web only supports unary RPC at present, so would need to provide a unary method for sending spans as well (or alternatively drop streaming support).

@anuraaga - For implementing the Span payload directly as a ByteString, I was looking into implementing io.grpc.BindableService directly and replacing the input parameter. I haven't tried that yet though so if you have a pointer or example then I'd be happy to take it.

to see differences more directly probably add it as a dep on zipkin-server
then build the exec jar. do a jar -tvf|sort before and after and diff
those. I suspect Jackson is already in the main exec jar even if we don't
use it (I think zipkin-aws does)
On Sun, Dec 16, 2018, 2:49 PM Eric Hauser<EMAIL_ADDRESS>wrote:

There are a few more dependencies with armeria:
[INFO] +- com.linecorp.armeria:armeria-grpc-shaded:jar:0.75.0:compile[INFO] |  +- com.linecorp.armeria:armeria-shaded:jar:0.75.0:compile[INFO] |  |  +- com.fasterxml.jackson.core:jackson-annotations:jar:2.9.7:compile[INFO] |  |  +- com.fasterxml.jackson.core:jackson-core:jar:2.9.7:compile[INFO] |  |  +- com.fasterxml.jackson.core:jackson-databind:jar:2.9.7:compile[INFO] |  |  +- io.micrometer:micrometer-core:jar:1.1.0:compile[INFO] |  |  |  +- org.hdrhistogram:HdrHistogram:jar:2.1.9:compile[INFO] |  |  |  - org.latencyutils:LatencyUtils:jar:2.0.3:compile[INFO] |  |  +- io.netty:netty-codec-haproxy:jar:4.1.31.Final:compile[INFO] |  |  |  - io.netty:netty-codec:jar:4.1.31.Final:compile[INFO] |  |  +- io.netty:netty-codec-http2:jar:4.1.31.Final:compile[INFO] |  |  |  +- io.netty:netty-codec-http:jar:4.1.31.Final:compile[INFO] |  |  |  - io.netty:netty-handler:jar:4.1.31.Final:compile[INFO] |  |  +- io.netty:netty-resolver-dns:jar:4.1.31.Final:compile[INFO] |  |  |  +- io.netty:netty-resolver:jar:4.1.31.Final:compile[INFO] |  |  |  - io.netty:netty-codec-dns:jar:4.1.31.Final:compile[INFO] |  |  +- io.netty:netty-tcnative-boringssl-static:jar:2.0.19.Final:compile[INFO] |  |  +- io.netty:netty-transport:jar:4.1.31.Final:compile[INFO] |  |  |  - io.netty:netty-buffer:jar:4.1.31.Final:compile[INFO] |  |  +- io.netty:netty-transport-native-epoll:jar:linux-x86_64:4.1.31.Final:compile[INFO] |  |  |  +- io.netty:netty-common:jar:4.1.31.Final:compile[INFO] |  |  |  - io.netty:netty-transport-native-unix-common:jar:4.1.31.Final:compile[INFO] |  |  +- io.netty:netty-transport-native-unix-common:jar:linux-x86_64:4.1.31.Final:compile[INFO] |  |  - org.reactivestreams:reactive-streams:jar:1.0.2:compile[INFO] |  +- com.google.code.findbugs:jsr305:jar:3.0.2:compile[INFO] |  +- org.curioswitch.curiostack:protobuf-jackson:jar:0.3.0:compile[INFO] |  |  +- javax.annotation:javax.annotation-api:jar:1.3.1:runtime[INFO] |  |  +- com.google.protobuf:protobuf-java-util:jar:3.6.1:runtime
Neither netty or jackson being shaded is less than ideal. Appears that
armeria is choosing not to shade netty in the future - line/armeria#705
https://github.com/line/armeria/issues/705.
On the plus side, I believe you can run HTTP/1, gRPC, and gRPC-Web all
from the same server instance. GRPC-Web only supports unary RPC at present,
so would need to provide a unary method for sending spans as well (or
alternatively drop streaming support).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/pull/2328#issuecomment-447621700,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD619eocVJfmM50scArKKnoLrx0600Zks5u5ez9gaJpZM4ZU_jb
.

I was thinking this would be simplest by having
Public API proto, used by clients
message WriteSpansRequest {
  repeated zipkin.proto3.Span span = 1;
}

service ZipkinService {
  rpc WriteSpans (stream WriteSpansRequest) returns (whatever);
}

while the server actually implements a different, non-exposed proto
message WriteSpansRequest {
  repeated bytes span = 1;
}

service ZipkinService {
  rpc WriteSpans (stream WriteSpansRequest) returns (whatever);
}

The protos are compatible so the clients get the advantage of the generated code and easy-to-populate structs while the server would only see the ByteString and decode straight into a Java span.
It has the downside of duplicate protos but it's probably a lot less complex than a custom BindableService

Got it. Yes, that is a definitely easier and a nice trick. Will give it a shot. Thanks!

yes armeria would imply geting rid of undertow and its deps. undertow was
only added for better perf.
plan sounds fine, but I'm really not keen merging another port to expose.
meaning if helpful for development can separate, but please don't release
us needing to support a second http port perpetually unless the change to
undo that immediately follows.
On Mon, Dec 17, 2018 at 6:28 AM Eric Hauser<EMAIL_ADDRESS>wrote:

So, @anuraaga https://github.com/anuraaga's trick doesn't work - at
least with gRPC Java. The issue is that the marshaller will have already
copied the input stream into a ByteString prior to getting access to it.
So I took the approach of implementing a custom BindableService. This has
the added benefit of removing all dependencies on Protocol Buffers
entirely. Here are the dependencies introduced now:
[INFO] +- io.grpc:grpc-netty-shaded:jar:1.17.1:runtime
[INFO] |  - io.grpc:grpc-core:jar:1.17.1:compile (version selected from constraint [1.17.1,1.17.1])
[INFO] |     +- io.grpc:grpc-context:jar:1.17.1:compile
[INFO] |     +- com.google.code.gson:gson:jar:2.7:compile
[INFO] |     +- com.google.errorprone:error_prone_annotations:jar:2.2.0:compile
[INFO] |     +- com.google.code.findbugs:jsr305:jar:3.0.2:compile
[INFO] |     +- org.codehaus.mojo:animal-sniffer-annotations:jar:1.17:compile
[INFO] |     +- com.google.guava:guava:jar:26.0-android:compile
[INFO] |     |  +- org.checkerframework:checker-compat-qual:jar:2.5.2:compile
[INFO] |     |  - com.google.j2objc:j2objc-annotations:jar:1.1:compile
[INFO] |     +- io.opencensus:opencensus-api:jar:0.17.0:compile
[INFO] |     - io.opencensus:opencensus-contrib-grpc-metrics:jar:0.17.0:compile
[INFO] +- io.grpc:grpc-stub:jar:1.17.1:compile
So this ends up being much less of a dependency burden than armeria - no
netty, protobufs -- with the downside of having the collector run on a
different port. We can keep this version of gRPC in sync with the version
that is being used by zipkin-gcp to avoid any issues.
However, armeria does have the advantage of everything being on the same
port and it would support gRPC-Web out of the box without a proxy. Would
switching to armeria mean that it would eliminate undertow and just use
it for everything? If so, we shoud probably find a path to finalizing the
gRPC API in this PR and moving forward with this experimental version on a
different port. A separate issue could be opened for moving to armeria -
given the size of that change, I would want to make sure there was plenty
of support for it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/pull/2328#issuecomment-447682189,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD61xBtWXssSyhRFKTCIDIxNHiQjwLtks5u5skggaJpZM4ZU_jb
.

PS it isn't fair to put the burden of switching all to armeria on Eric :P I
will spike a PR so in case this happens while I'm away (I'm out tomorrow)
the grunt work is ready.

I started this whole mess so I'm fine rolling up my sleeves on the switch. Just want to make sure there is support behind it.

I think there's some sort of "jury's still out" in general.
The trick is that adding an optional module will likely become
effectively required as there is so much marketing buzz around gRPC.
So, we have to be quite careful how to introduce this. scribe being on
a different port caused a bunch of pain back in the day with people
invariably choosing the wrong port, having to go through work to
figure it out (matters not if docs say use the right port), then going
onto support and moving the concern there, or triple posted issues
etc.
Basically, if we're going to do this, in the case of gRPC, I think we
ought to consider this becoming effectively required, and how to stop
the most type of problems we can't control. We do have a lot of
control over the server and extensions of it as we explicitly give
zero warranty on custom builds. We have little control over config
mistakes even with docs.

ps I'll graciously accept your offer to do the armeria spike if comes
to that. I'll raise an issue on it.

here's the issue for armeria https://github.com/openzipkin/zipkin/issues/2331

@ewhauser wrote:

I would want to make sure there was plenty of support for it.

The Armeria project maintainers including LINE employees like me (@hyangtack and @minwoox as well) would be happy to support Zipkin community for adoption of Armeria and its sustainable development. I believe you don't need to worry too much about the future of Armeria given that it's being used in various critical parts of LINE services.

Agreed. If armeria is the way forward, then this is the better option.
On Sun, Dec 16, 2018 at 9:27 PM Anuraag Agrawal<EMAIL_ADDRESS>wrote:

For the copying issue, just to clarify, using the proto approach makes
ByteBuf -> zipkin.proto3.Span -> byte[] -> zipkin2.Span become
ByteBuf -> byte[] -> zipkin2.Span
and then using Armeria's unsafe option can make it become
ByteBuf -> zipkin2.Span
Proto3Codec needs to be updated to accept ByteBuffer, which is pretty
simple change I think. On the flip side, I think it's not practical for it
to parse the InputStream directly since doing that efficiently would
probably require using the KnownLength class inside of Proto3Codec which
shouldn't have gRPC dependencies.
Of course it depends on the decision of moving to armeria, but if we do,
I'd still recommend using the proto trick + unsafe option.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/pull/2328#issuecomment-447726620,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIBPYlevMan0sbk2a4G6hQKSHDqLdb8ks5u5ys9gaJpZM4ZU_jb
.

Trustin - armeria seems like a great project. More so wanted to make sure
there was support for using it within zipkin-server. There are a lot of
consumers that I don’t want to break; thank you for the offer to help
support with the adoption!
On Sun, Dec 16, 2018 at 9:04 PM Trustin Lee<EMAIL_ADDRESS>wrote:

@ewhauser https://github.com/ewhauser wrote:
I would want to make sure there was plenty of support for it.
The Armeria project maintainers including LINE employees like me (
@hyangtack https://github.com/hyangtack and @minwoox
https://github.com/minwoox as well) would be happy to support Zipkin
community for adoption of Armeria and its sustainable development. I
believe you don't need to worry too much about the future of Armeria given
that it's being used in various critical parts of LINE services.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/pull/2328#issuecomment-447723669,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIBPcM8jeHwTR8aNnQ7R5wclDKRwkanks5u5yXNgaJpZM4ZU_jb
.

I was just looking at the proto. It seems probably unary ListOfSpans style request would make more sense as the initial impl as all infrastructure we have is based on ListOfSpans (Collector, Storage etc). It is nice that all of our impls accept literally the same messages. For example, if our initial method was putSpans(ListOfSpans) then the exact codec we use for normal proto over http/2 could be used to process that message, right?
Starting with just a unary likely also means the largest amount of client support in general. Does that sound right?

Yes. I’m was planning on swapping out in the next rev as streaming is not
yet supported by GRPC-Web.
Re: putSpans and ListOfSpans - I think that’s the right approach. armeria
says it supports gRPC over HTTP/1 so I need to explore how that works. If
it’s similar to GRPC Gateway where you use annotations to define the HTTP/1
mappings, then you could potentially share the code for both
implementations.
On Mon, Dec 17, 2018 at 3:24 AM Adrian Cole<EMAIL_ADDRESS>wrote:

I was just looking at the proto. It seems probably unary ListOfSpans style
request would make more sense as the initial impl as all infrastructure we
have is based on ListOfSpans (Collector, Storage etc). It is nice that all
of our impls accept literally the same messages. For example, if our
initial method was putSpans(ListOfSpans) then the exact codec we use for
normal proto over http/2 could be used to process that message, right?
Starting with just a unary likely also means the largest amount of client
support in general. Does that sound right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/pull/2328#issuecomment-447812182,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIBPbYLSknVTC9k07_TrkYE1zMzu2Ulks5u537lgaJpZM4ZU_jb
.

For inspirational, I took a look at the API provided by OpenCensus trace collector.
They actually use bidirectional streaming in their implementation although there are some nuances in their protocol which do not exist for Zipkin.
I still think implementing unary makes sense since gRPC-Web does not support streaming, but I'll probably perf test both solutions before finishing.

I think streaming is interesting if the client doesn't do any batching so if you try comparing the perf, I'd recommend doing it without batching in the streaming version at least as an option

@anuraaga I don't expect many clients to not do bundling at all as that implies a different internal reporting arch only used for grpc, wouldn't it?
For example, even kafka is a bundle-at-a-time transport. This was done for reasons including that some spans are so small that sending in a single message is wasteful. Also, often people mistakenly assume that sending one span onto a transport is protecting the app from overhead when usually even kafka clients can (and have) crashed an app enqueueing.
I wonder if we can decouple this completely as having two supported ways to do grpc seems tech debt creating not just here but the inevitable "it is streaming on server, so why not also in X (where X is every client library)". I really hesitate strongly about adding more complexity especially in the initial impl as there's already quite a lot of work to do just for unary.
Assuming unary is in, it would seem possible for someone who felt strongly about streaming to add a module to their setup that is a streaming alternate as well.. meaning we can completely defer this whole thing as well the impact discussions which now only stall the work entirely. What I mean is bundling the option for streaming means supporting it and has almost the same impact as supporting it enabled by default. I don't quite feel we should add that burden today considering we still have a lot of other things to do to get this in.

Yeah just going unary seems fine. I think streaming without batching is interesting since HTTP/2 flow control is basically a type of batching - having two layers of batching feels like it should be unnecessary, so it would be interesting to see if it makes things simpler to just use the flow control.

@anuraaga PS I like the idea of re-using http/2 flow-control (and also ping for that matter) in theory, and will also help with whatever infra is needed when we experiment with streaming.

this can be now be rebased in master, which is armeria, avoiding a second http engine

@ewhauser you mind if I mutate your branch?

Of course not. Little backed up at the moment; but feel free to ping me if
I can help
On Tue, Apr 2, 2019 at 4:29 AM Adrian Cole<EMAIL_ADDRESS>wrote:

@ewhauser https://github.com/ewhauser you mind if I mutate your branch?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/pull/2328#issuecomment-478955187,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIBPRWImKtNYlk2uChTxnqxcjP9ZZIgks5vcz8QgaJpZM4ZU_jb
.

ok I rebased this over master and did some refactoring in the last commit.
cc @openzipkin/armeria
A cheap test to show that the service mounted
$ curl -X POST localhost:9411/zipkin.proto3.SpanService/Report -H'Content-Type: application/grpc' -v
*   Trying ::1...
* TCP_NODELAY set
* Connected to localhost (::1) port 9411 (#0)
> POST /zipkin.proto3.SpanService/Report HTTP/1.1
> Host: localhost:9411
> User-Agent: curl/7.54.0
> Accept: */*
> Content-Type: application/grpc
>
< HTTP/1.1 200 OK
< content-type: application/grpc+proto
< grpc-status: 13
< grpc-message: Half-closed without a request
< content-length: 0
<
* Connection #0 to host localhost left intact

here's the change to the proto https://github.com/openzipkin/zipkin-api/pull/59

the jar grew a lot again. will track things I can't control here in https://github.com/line/armeria/issues/1703
cc @trustin @anuraaga
$ du -k zipkin-nogrpc.jar
47396	zipkin-nogrpc.jar
$ du -k  zipkin-grpc.jar
55840	zipkin-grpc.jar

diff zipkin-nogrpc.jars zipkin-grpc.jars
1a2
> 3277212 BOOT-INF/lib/byte-buddy-1.9.12.jar
9a11
> 1424558 BOOT-INF/lib/protobuf-java-3.7.0.jar
13a16
> 1200130 BOOT-INF/lib/proto-google-common-protos-1.12.0.jar
15a19
> 825158 BOOT-INF/lib/grpc-services-1.19.0.jar
16a21
> 766263 BOOT-INF/lib/grpc-core-1.19.0.jar
35a41
> 327600 BOOT-INF/lib/opencensus-api-0.19.2.jar
41a48
> 241622 BOOT-INF/lib/gson-2.8.5.jar
43c50
< 226228 BOOT-INF/lib/zipkin-2.12.9-SNAPSHOT.jar
---
> 226229 BOOT-INF/lib/zipkin-2.12.9-SNAPSHOT.jar
46a54
> 142031 BOOT-INF/lib/armeria-grpc-0.83.0.jar
51a60
> 126747 BOOT-INF/lib/re2j-1.2.jar
53a63
> 113966 BOOT-INF/lib/protobuf-jackson-0.3.1.jar
61a72
> 68840 BOOT-INF/lib/protobuf-java-util-3.6.1.jar
70a82
> 39549 BOOT-INF/lib/grpc-stub-1.19.0.jar
77a90
> 29016 BOOT-INF/lib/grpc-context-1.19.0.jar
89a103
> 14961 BOOT-INF/lib/opencensus-contrib-grpc-metrics-0.19.2.jar
91a106
> 13694 BOOT-INF/lib/error_prone_annotations-2.2.0.jar
98a114
> 7614 BOOT-INF/lib/grpc-protobuf-lite-1.19.0.jar
99a116,117
> 6834 BOOT-INF/lib/zipkin-proto3-0.2.0.jar
> 6684 BOOT-INF/lib/zipkin-collector-grpc-2.12.9-SNAPSHOT.jar
105a124
> 4994 BOOT-INF/lib/grpc-protobuf-1.19.0.jar
108a128
> 3448 BOOT-INF/lib/animal-sniffer-annotations-1.17.jar
109a130
> 2363 BOOT-INF/lib/zipkin-autoconfigure-collector-grpc-2.12.9-SNAPSHOT.jar

note that almost all of the big jars should be unnecessary as our service endpoint is well defined and can parse its own message without the help of google's proto libraries

The way I was trying to do this previously was make the gRPC endpoint optional - similar to how the storage integrations work. Obviously, a tradeoff there.

@ewhauser ack we could do that. I should have mentioned the goal I'm trying for here is to not pollute our maven namespace at all, and embed the grpc listener in the server impl. That way, layered integrations such as zipkin-aws and zipkin-gcp magically can use it without module composition (which would likely lead to more dep clashes)

basically I think almost all of the extra deps are unnecessary which could mean <1MiB overhead in terms of jar size for a pretty sweet feature even if we start by turning it off by default.
We have had some grumbles about how our recent jar hike (prior to this) is slowing people with wan connections, so hoping we can just obviate that.

rebasing this now. then will try with https://github.com/line/armeria/pull/1727

FYI: latest changes in master before this have shrunk the zipkin jar a little bit.
$ du -k zipkin.jar
47104	zipkin.jar

so before the grpc'less grpc here's the before and after
before: 47104k
after:    55360k

@anuraaga while the last commit doesn't quite work, yet. the jar is 3MiB down so far..
before: 47104k
before grpc-less: 56384k
now: 53312k

While there is a little work to do, especially around avoiding tripping up classloader based on docservice, once this works, the overhead to add grpc is roughly 1MiB and no more guava fight (at the moment anyway)
cc @trustin @anuraaga
before: 47104k
before grpc-less: 56384k
now: 48192k (back to below 50Mib!)

let's pick this back up when https://github.com/line/armeria/pull/1727 changes again

@ewhauser I think this is ready to merge. We aren't releasing right away as the project is in the middle of an ASF move. However, the remaining task of perf testing will be easier once merged as people can build off master. The feature is currently disabled under a flag.
I don't expect perf testing to be surprising as this is not much different than vanilla armeria http, but yeah once we have a grpc sender we can hook it up and compare.

The zero copy thing is in a different change, btw, it isn't grpc specific #2435

However, the remaining task of perf testing will be easier once merged as people can build off master.

As long as this PR is up-to-date with master, maybe this is a good opportunity to try out Jitpack for testing pre-merge?

@shakuzen sure.. anyone want to translate this into eric's branch name? "https://jitpack.io/com/github/apache/incubator-zipkin/zipkin-server/2.12.9/zipkin-server-2.12.9-exec.jar"

ps this is up to date with master which means the maven package is org.apache.zipkin
(with much rejoicin)

oops on rebase lost update to zipkin proto 0.2.0

@shakuzen I just now realize how extremely complex our test setup is vs just using wire (which doesn't require a shell out to protoc). I raised a small revision to our proto as I think now's the time https://github.com/apache/incubator-zipkin-api/pull/64

will rebase once the following are in:

reduce dependencies in our service definition https://github.com/apache/incubator-zipkin-api/pull/64
switch to wire https://github.com/apache/incubator-zipkin/pull/2532

ok now using a JVM impl square/wire to compile the protos needed for the integration tests. maybe jitpack works now

jitpack build off last commit is here https://jitpack.io/com/github/ewhauser/zipkin/zipkin-server/experimental-grpc-1.5.0-g94ac6cf-1164/zipkin-server-experimental-grpc-1.5.0-g94ac6cf-1164-exec.jar

I broke the build settings for integration test (cli only, as intellij is fine).. will fix. here's the command to get to the same fail as travis
$ ./mvnw clean verify -pl zipkin-server -o -Dinvoker.skip=true

those who want to test other language reporters against this before release can do the following:
$ curl -sSL https://jitpack.io/com/github/ewhauser/zipkin/zipkin-server/experimental-grpc-1.5.0-g94ac6cf-1164/zipkin-server-experimental-grpc-1.5.0-g94ac6cf-1164-exec.jar > zipkin.jar
$ GRPC_COLLECTOR_ENABLED=true java -jar zipkin.jar

added a commit to unhook this from snapshots. will merge on green

updated description


Correct Default Proxy header description on ProxySettings - Follow-up #391

This is a follow-up from https://github.com/bitcoin-core/gui-qml/pull/391#issuecomment-2030046949.

Currently/ main branch screenshot.

 This PR branch screenshot.

Gentle reminder to #391's reviewers: @johnny9, @GBKS, @D33r-Gee, @MarnixCroes, @stackingsaunter.

Updates:

Addressed @MarnixCroes's feedback, thanks!

tACK d558b05


Breaking changes in 1.6.0

Could not resolve @akveo/ng2-completer relative to [object Object].
node_modules/ng2-smart-table/lib/components/cell/cell-editors/completer-editor.component.d.ts(2,34): error TS2307: Cannot find module '@akveo/ng2-completer'.
node_modules/ng2-smart-table/lib/components/filter/filter-types/completer-filter.component.d.ts(3,34): error TS2307: Cannot find module '@akveo/ng2-completer'.
node_modules/ng2-smart-table/lib/components/tbody/tbody.component.d.ts(29,9): error TS1086: An accessor cannot be declared in an ambient context.
error TS2339: Property 'settings' does not exist on type 'Row'.
error TS2339: Property 'source' does not exist on type 'Row'.
error TS2339: Property 'userRowSelect' does not exist on type 'Row'.
error TS2339: Property 'create' does not exist on type 'Row'.
error TS2339: Property 'grid' does not exist on type 'Row'.
error TS2339: Property 'edit' does not exist on type 'Row'.
error TS2339: Property 'grid' does not exist on type 'Row'.
error TS2339: Property 'delete' does not exist on type 'Row'.
error TS2339: Property 'prepareSettings' does not exist on type 'Row'.
error TS2339: Property 'editRowSelect' does not exist on type 'Row'.

Had to downgrade back to 1.5.0

Same here

Have you installed @akveo/ng2-completer?

BREAKING CHANGE:

ng2-completer dependency replaced by @akveo/ng2-completer. Read details in #1140. This is a temporary measure until the original ng2-completer fixed. We have no plans to support @akveo/ng2-completer.
We no longer have a direct dependency on tslib. Instead it is now
listed a peerDependency. This matches Angular framework.

I installed
npm install @akveo/ng2-completer --save
but I still experience build problem:
ng build --prod
results in the following error:
ERROR in ./node_modules/ng2-smart-table/ng2-smart-table.ngfactory.js
Module not found: Error: Can't resolve<EMAIL_ADDRESS>in 'G:\Source\ShareHolderV2\node_modules\ng2-smart-table'
resolve<EMAIL_ADDRESS>in 'G:\Source\ShareHolderV2\node_modules\ng2-smart-table'
  using description file: G:\Source\ShareHolderV2\node_modules\ng2-smart-table\package.json (relative path: .)
    Field 'browser' doesn't contain a valid alias configuration
    using description file<EMAIL_ADDRESS>(relative path: ./ng2-completer.ngfactory)
      no extension
        Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
      .ts
        Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
      .tsx
        Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
      .mjs
        Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
      .js
        Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
      as directory
<EMAIL_ADDRESS>doesn't exist
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS> @ ./node_modules/ng2-smart-table/ng2-smart-table.ngfactory.js 13:0-70 291:11-33 291:35-61 589:11-33 589:35-61
 @ ./src/app/tag/tag-list/tag-list.component.ngfactory.js
 @ ./src/app/app.module.ngfactory.js
 @ ./src/main.ts
 @ multi ./src/main.ts

Am I missing something or everybody gets above build error?

Downgrade to version 1.5.0 until fix.
-npm uninstall ng2-smart-table
-npm i<EMAIL_ADDRESS>--save

Same here. Is the downgrade to version 1.5.0 the only solution for that problem?

So far no response from the developers. 1.6.0 was mainly an upgrade to Angular 9. If you're not using it, you're probably not missing on anything.

Any update on this as we are also facing the same issue while upgrading our project to Angular 9. Downgrading is not an option as upgrading to Angular 9 is our agenda.

I got 1.6.0 to work in angular 9. Now setFilter doesn't seem to work.

Downgrade to version 1.5.0 until fix.
-npm uninstall ng2-smart-table
-npm i<EMAIL_ADDRESS>--save

and make sure to run -npm i ng2-completer --save

I got 1.6.0 to work in angular 9. Now setFilter doesn't seem to work.

Hi @lenichols how did you manage to get it to work? I'm trying to use 1.6.0 w/ the @akveo/ng2-completer dependency on angular 9 as well. I'm currently getting no errors, but the data table doesn't seem to render on my page.

I think the errors mentioned in the original comment are caused by the hack/workaround to import ɵbo as Ng2SmartTableComponent. For 1.6.0 that workaround no longer seems to be necessary, see my comment in #1097

I got 1.6.0 to work in angular 9. Now setFilter doesn't seem to work.

Hi @lenichols how did you manage to get it to work? I'm trying to use 1.6.0 w/ the @akveo/ng2-completer dependency on angular 9 as well. I'm currently getting no errors, but the data table doesn't seem to render on my page.

Great! to know you could solve this issue. Could you state us the step you followed to solve?

is version "1.6.0" compatible with angular 9 or not?


[tool_crash] ProcessException: Failed to find ".\Microsoft\Edge\Application\msedge.exe" in the search path. Command: .\Microsoft\Edge\Application\msedge.exe, OS error code: 0

Command
flutter run

Steps to Reproduce

...
...
...

Logs
ProcessException: Failed to find ".\Microsoft\Edge\Application\msedge.exe" in the search path. Command: .\Microsoft\Edge\Application\msedge.exe, OS error code: 0
#0      LocalProcessManager.start (package:process/src/interface/local_process_manager.dart:58:7)
#1      ErrorHandlingProcessManager.start.<anonymous closure> (package:flutter_tools/src/base/error_handling_io.dart:664:24)
#2      _run (package:flutter_tools/src/base/error_handling_io.dart:544:20)
#3      ErrorHandlingProcessManager.start (package:flutter_tools/src/base/error_handling_io.dart:663:12)
#4      ChromiumLauncher._spawnChromiumProcess (package:flutter_tools/src/web/chrome.dart:243:53)
#5      ChromiumLauncher.launch (package:flutter_tools/src/web/chrome.dart:221:36)
<asynchronous suspension>
#6      ChromiumDevice.startApp (package:flutter_tools/src/web/web_device.dart:136:17)
<asynchronous suspension>
#7      ResidentWebRunner.run.<anonymous closure> (package:flutter_tools/src/isolated/resident_web_runner.dart:541:9)
<asynchronous suspension>
#8      asyncGuard.<anonymous closure> (package:flutter_tools/src/base/async_guard.dart:111:24)
<asynchronous suspension>

[✓] Flutter (Channel stable, 2.2.3, on Microsoft Windows [Version 10.0.18362.1256], locale fr-FR)
    • Flutter version 2.2.3 at C:\src\flutter
    • Framework revision f4abaa0735 (9 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).

[✓] VS Code (version 1.59.1)
    • VS Code at C:\Users\ART Sider\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.25.0

[✓] Connected device (2 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 89.0.4389.72
    • Edge (web)   • edge   • web-javascript • Microsoft Edge 90.0.818.42 (unsupported)

! Doctor found issues in 2 categories.

Flutter Application Metadata
Type: app
Version: 1.0.0+1
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: stable
Creation framework version: f4abaa0735eba4dfd8f33f73363911d63931fe03

I don't see any related / similar or duplicate issue, so labeling accordingly.

Similar stacktrace from stable/2.5.1:
Thread 0 main threadProcessPackageException: ProcessException: Failed to find "/Users/Fujino/Desktop/<path>/<app_name>/android/gradlew" in the search path.  Command: "/Users/Fujino/Desktop/<path>/<app_name>/android/gradlew
at LocalProcessManager.start(local_process_manager.dart:58)
at ErrorHandlingProcessManager.start.<anonymous closure>(error_handling_io.dart:691)
at _run(error_handling_io.dart:567)
at ErrorHandlingProcessManager.start(error_handling_io.dart:690)
at _DefaultProcessUtils.start(process.dart:425)
at _DefaultProcessUtils.stream(process.dart:444)
at AndroidGradleBuilder.buildGradleApp(gradle.dart:357)
at AndroidGradleBuilder.buildApk(gradle.dart:178)
at BuildApkCommand.runCommand(build_apk.dart:105)
at <asynchronous gap>(async)
at FlutterCommand.run.<anonymous closure>(flutter_command.dart:1125)
at <asynchronous gap>(async)
at AppContext.run.<anonymous closure>(context.dart:150)
at <asynchronous gap>(async)
at CommandRunner.runCommand(command_runner.dart:209)
at <asynchronous gap>(async)
at FlutterCommandRunner.runCommand.<anonymous closure>(flutter_command_runner.dart:288)
at <asynchronous gap>(async)
at AppContext.run.<anonymous closure>(context.dart:150)
at <asynchronous gap>(async)
at FlutterCommandRunner.runCommand(flutter_command_runner.dart:236)
at <asynchronous gap>(async)
at run.<anonymous closure>.<anonymous closure>(runner.dart:62)
at <asynchronous gap>(async)
at AppContext.run.<anonymous closure>(context.dart:150)
at <asynchronous gap>(async)
at main(executable.dart:92)
at <asynchronous gap>(async)


added options and information for siemens questasim simulator support…

… within yaml/simulator.yaml file
Added options:
+incdir+${UVM_HOME}
-L ${QUESTA_HOME}/uvm-1.2
Added comments:
Somewhere in your setup, do not forget to:
properly set UVM_HOME and QUESTA_HOME variables
add the following command: set questasim_version = vsim -version | perl -ne 'if(/Questa/){@t_tmp=split(" ",$_);print($t_tmp[3]."\n")}'

Is there anybody to look at this pull-request?


[e2e]: container schedule main continue-on-error slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/7649270651
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container.schedule.main.continue-on-error.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container.schedule.main.continue-on-error.slsa3.yml
Trigger: schedule
Branch: main
Date: Thu Jan 25 03:02:52 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/7663405798
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container.schedule.main.continue-on-error.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container.schedule.main.continue-on-error.slsa3.yml
Trigger: schedule
Branch: main
Date: Fri Jan 26 03:02:21 UTC 2024
Tests are passing now. Closing this issue.


Removed unused name attribute

Affected Issues

Fixes #141

Proposed Changes

Removed unused attribute

Codecov Report

Merging #142 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #142   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           9      9
  Lines         268    267    -1
=====================================
- Hits          268    267    -1

Impacted Files
Coverage Δ

pybotics/robot.py
100% <ø> (ø)
:arrow_up:

Coverage remained the same at 100.0% when pulling 54ebf7f68ad547042b6f5d02676697cac364b6ac on pyboticsrobot.py32-Unused-attribute-'name'-#141 into b05e764d62d6599eb9c5460df0fe820a30ca6940 on master.

Coverage remained the same at 100.0% when pulling 54ebf7f68ad547042b6f5d02676697cac364b6ac on pyboticsrobot.py32-Unused-attribute-'name'-#141 into b05e764d62d6599eb9c5460df0fe820a30ca6940 on master.

Coverage remained the same at 100.0% when pulling 54ebf7f68ad547042b6f5d02676697cac364b6ac on pyboticsrobot.py32-Unused-attribute-'name'-#141 into b05e764d62d6599eb9c5460df0fe820a30ca6940 on master.


[[FIX]] Validate lone arrow function parameter

Previously, the identifier parsing logic returned early for a lone arrow
function parameter in order to avoid incorrectly extending the
environment record in which the associated arrow function was defined.
This unintentionally circumvented logic which enforced restrictions on
identifier names.
Refactor the parsing logic to enforce the restriction in all cases, but
only alter the environment record when the identifier is not a lone
arrow function parameter.

Coverage remained the same at 100.0% when pulling 129dde3589c205fd4b37ea24be432fe199984fda on jugglinmike:validate-arrow-lone-param into 2366c92b852adeb963ecb812bc32b258288663dc on jshint:master.

Excellent!


Align path names generated for file and S3 backend

This aligns the path names generated for S3 backend to the ones used by
the file backend allowing S3 objects to be used as file backend and
vice versa.
Dirname and Filename generation logic have moved from file backend to
tha backend package.
Added a environment variable (AWS_LEGACY_PATHS) to S3 backend which
cat be set to true to switch to legacy pathnames (to be used with
existing repositories).
See #654 for a discussion about this.
I decided to step in with a very simple proposal on how to solve this. Especially because there are some pull requests for new backend that will use the same path names as S3.
This is probably not the best (or even wanted) solution as it requires S3 users to set a additional environment variable to be able to use their repository but I think it's the easiest one and I wanted to push the discussion forward.
We could provide an additional tool for "one-shot" migrations from "legacy S3" to "new style S3" backend paths so that restic does not have to maintain two different path styles forever.
(Please be lenient with me as I'm in no way familiar with go :smiley: )

Current coverage is 51.09% (diff: 28.57%)

Merging #695 into master will decrease coverage by 0.30%

@@             master       #695   diff @@
==========================================
  Files            95         96     +1
  Lines          7476       7480     +4
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           3843       3822    -21
- Misses         3084       3108    +24
- Partials        549        550     +1

Powered by Codecov. Last update 51cd78e...2644d55

Thanks for the suggestion. I think this is good for new repositories on s3, but since it is a breaking change: How do we handle migration of existing repos?

How do we handle migration of existing repos?

Easiest thing I can think of would be an extra tool that does the migration on S3. I'm happy to provide one (despite being slow) but wanted to make sure you would agree on the idea first.
I'm with you regarding your second point but I think it would be way more work to provide a generic "backend-to-backed" migration system that to just keep the structure aligned where it is possible and of no harm.

I have an idea: What about recording information about the backend in the repo config? E.g., have a field for subdir depth, the name of the backend used to create the repo. It would allow detecting the directory name/structure used and we can implement a migrate command that does the right thing[tm]. Let me think about this for a bit.

Souds good for me. Would also allow the backeds to do further migrations if needed in future.
Would it be okay for you if I submit the non S3 specific parts of this as a separate PR so the file backend structure can be easily used by new backends like !694?

Would it be okay for you if I submit the non S3 specific parts of this as a separate PR so the file backend structure can be easily used by new backends like #648 and #694?

Yes, I think that's a good idea. I propose the following steps:

Extract the functions to construct the path name for a file into generic functions, and pass the number of sub-dirs as a parameter. In the first step, this can be hardcoded per backend (local/sftp -> 1, s3 -> 0). Let's get that PR merged.
Then we'll add infrastructure and a config option to set this parameter, so we can easily override it, so people can use it already.
The last step is adding a field to the repo config.

What do you think?


Lookup field update error

Error: [520] [GAIA_LO04] A value 129 in the field xxx does not exist in the datasource app for lookup, or you do not have permission to view the app or the field.
Hi, I keep getting this error message when updating a lookup field of an app, there is nothing wrong when I update other types of fields.
Can you tell me how to solve this problem?
Thanks a lot.

@990706TJGU
Thanks for reporting!
To investigate the cause, would you give us more information?
Please tell us about the package version, environment, etc. by following the issue template.
(You don't have to close this issue, just update the description of it)
<!-- Thank you for reporting a bug! -->

## Target Package

<!-- Which package do you want to report a bug for? -->

- @kintone/\*\*\* 0.0.0

## Environment

<!-- What environment did you test? -->

- Operating System:
- Browser:
- Node.js version:

## Current Behavior

<!-- What is the current behavior you saw?  -->

## Expected Behavior

<!-- What is the behavior you expected?  -->

Also, we'd like to know which authentication method you use.
https://github.com/kintone/js-sdk/tree/master/packages/rest-api-client#authentication

@990706TJGU
I'll close this issue because it hasn't had any updates for a few months.
But please feel free to reply if you still have any problems.


Response.body(InputStream)

Being able to connect an InputStream to the response would be very helpful.  I've used this regularly in Spark (just returning an InputStream from the handler).  Any chance of adding this?

Sure, why not. Do you want to make a PR?

Sure thing.


use proxy

hi, I am using proxy to make docker connects to docker hub.
the docker itself works fine and can pull images but dockstation can't recognize proxy setting
I set it by docker environment.
what should I do?

no answer yet?

Hi @MetaiR . Sorry I was very busy the last few weeks. I'll try to check and maybe find some fast solution.

Trying to use dockstation on Win10 with "Internet Options" HTTP & HTTPS proxy set.
Same problem.

Hi guys! Please check access to https://firebase.google.com/


gui debugger

game debugger like readme?

oh, that's CatSystem2 self debugger, and need all decrypt Int's Packget ...

Alright, I've started to sort out the information needed to actually setup debug mode if you're interested.
Decrypting the archives isn't required anymore, but some features will work better if the archives are extracted.
I apologize that this info is a bit jumbled, my notes and tests over the last few months have been very scattered and unorganized.
Requirements

cs2_debug_key.dat (contains random data unique to each game) (i)
Locale Emulator, (or Japanese system locale)
Extract scene.dat to a new folder: scene/ (enables script selection+navigation)
Find the <wndmenu> option in startup.xml, set the value to 1. (enable menu bar, required for some features) (iii)
Add these debug keybinds to KEYCUSTOMIZE list in startup.xml (some features can only be accessed with keybinds) (iii)  (TODO: Link xml debug keys from CS2 patcher in this repo)
If you have a Grisaia game,  the startup.xml likely contains an invalid comment that invalidates all settings defined after that point(?)  Look for <!-- with a --> on the next line. Removing the first should fix this.

Archives that DO NOT need to be extracted:
(archives not listed here are unconfirmed)

kcs.int
mot.int
export.int
image.int (some games use slightly different names, they will be defined in startup.xml)
pcm_*.int
bgm.int, bgmv.int
se.int, hse.int

Notes:

(i) These files can be generated with commonly known encryption methods used by CS2, using the V_CODE (1), which can be found in startup.xml and sometimes the cs2.exe binary. (TODO: link info)
(iii) if you already have save data, you may need to delete setup.xml from your game save folder.

Todo

Link to: xml debug keybinds, Locale Emulator, Wiki Pages documenting: Key Files (like the debug file), Debug Mode, Official CatSystem 2 manual (jp), Official CatSystem2 toolset (where you can fiddle wi try a working debug mode)

If you don't mind, I'll also be reopening this issue, just to make the information more accessible until it gets added to the repo's wiki. 🎉

thank you your reply !!  but i had delete these tools. and now i  no time to redownload try it
sorry :(

That's okay, I'll still throw what I've currently got up on the wiki later.  👍
And I apologize, reopening a user-closed issue was a bit rude of me.


Updating grammarSource documentation

When reading grammarSource, I was pretty confused. This PR does a few things:

Removes the passive by monkeys language from grammarSource
Removed this sentence, which I don't think has any meaning: "parsers in network applications might use the socket and so on."
Adds a useful example of what a grammarSource is, because I originally thought it was supposed to be a duplicate of the source code
Cleans up the duplicative description of grammarSource in Locations

I don't think it's unreasonable to say the documentation needs a rewrite. The original Peg.js documentation leaves a lot to be desired. This is my first attempt at making a confusing documentation entry more approachable.

Will review tomorrow.  There are likely lots of doc changes needed, including splitting things up into multiple pages.

This looks good to me.  Can also you please add yourself to the AUTHORS file if you're not already in there?

Done. Also I just realized the name of this flag is confusing, or am I missing something? grammarSource - this makes me think it's the source of the .pegjs file, rather than the input/lexemes being parsed. Is this the right flag name?

It has the same name for those two things because it's the same generated code.  It's confusing, I'll grant you, but the grammar you write is input into the grammar at src/parser.pegjs.


Fix issue where empty partitions caused incorrect behavior

What do these changes do?
Sometimes we can get np.nan values when we are performing mean across rows.
Related issue number
Resolves #118

[ ] passes git diff upstream/master -u -- "*.py" | flake8 --diff

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin/128/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin/147/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin/164/
Test FAILed.

Merged build finished. Test FAILed.


why notes look like this?

What is your question?
so i updated from 1.24.2 to 1.25.0 and i found a weird visual glitch that looks like this

its not a big problem but i just wanted to report this

that's because i switched from sorting the notes every frame to sorting every beat, like in normal psych. if you want the sorting every frame wait until 1.26.0 (tomorrow) or use rendering mode

that's because i switched from sorting the notes every frame to sorting every beat, like in normal psych. if you want the sorting every frame (aka. fixed note sorting) wait until 1.26.0 (tomorrow) or use rendering mode

👆


Missing license

Hi. This library looks very useful.
I am hoping to use this library in another project, but at the moment it is unclear if I am allowed to do that.
If you are okay with others using this library, could you please update the project with licensing information? Ideally that would include a LICENSE file describing your terms, or a copy of a license you are happy with.
On the other hand, if you do not wish others reuse your work, I'll respect that.

+1 @dillonalaird

License Needed ~


Add reverted changes from PR #18302

Add the e2e test suite for the Attention. It only checks CPU FP16, and the reference implementation is FP32.
https://github.com/iree-org/iree/pull/17751
https://github.com/iree-org/iree/pull/18302

Please structure this as two commits: one that is the original changes and one that has any new changes since the last review.
Please also change the PR title to directly reflect what is being added, e.g. "Re-land e2e attention test suite."


Callback for time left until next task.

I'd like to know how much time until the next execution of the task.

Looking through the code, I believe this is the _interval variable.
Is there some way that this can be exposed via a callback?
I would be open to fixing this in a pull request if you give me some pointers.

// I think this would look like
_scheduler = NeatPeriodicTaskScheduler(
      interval: const Duration(seconds: 30),
      name: 'periodic-results-calculation',
      timeout: const Duration(seconds: 5),
      task: _calculateResult,
      onIntervalChanged: (val){
        print(val);
      },
      minCycle: const Duration(seconds: 5),
    );

I believe delay - elapsed in:
https://github.com/google/dart-neats/blob/5119eba0db931caa37c207634f52f12d5ae4f4da/neat_periodic_task/lib/neat_periodic_task.dart#L243-L250
Is time until next time it's supposed to run.
side note: It's possible that var d = delay - elapsed; would actually be better logic. Maybe, + some randomness to reduce racing.
We could expose this as a property on NeatPeriodicTaskScheduler, like _scheduler.nextRun that returns a DateTime.
But until start() have been called, and we've reached the lines above in the loop we don't really have anything to return. We could return DateTime(0) as a dummy value.
It's also not accurate, this is an estimate at best.

NeatPeriodicTaskScheduler isn't aimed at precision scheduling of tasks. It's aimed at scheduling tasks where the state of the task is persisted in GCS, S3, Cloud Datastore, Firestore or a database of sorts. It only requires optimistic concurrency from the state storage.
Indeed the goal, is to reliably scheduled a periodic task that is supposed to run on a daily or weekly basis. And ensuring that the task is retried if it fails, etc.

If you can define good semantics for what this property should return, and write up good documentation for it, I'm open to taking a PR.
Please make an outline of what it could look like here, and then ping me with @jonasfj.

Thanks for taking the time to look at this jonas. I wound up using the default flutter timer and forgot to update the issue.


[MXNET-984] Add Java NDArray and introduce Java Operator Builder class

Description
Just a copy of https://github.com/apache/incubator-mxnet/pull/12772
@andrewfayres @zachgk @piyushghai @nswamy @yzhliu
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

reluctantly agreeing to adding Builders for all APIs with the premise that this design will be revisited before it makes to master.

also please add more unit tests for these builder based APIs


Add the file devcontainer.json

Summary

Changes

Closes:
Task list

[x] For workflow changes, I have verified the Actions workflows function as expected.
[x] For content changes, I have reviewed the style guide.

Testing that functions

Comment


Improve debug logging to expected behavior

The existing code has the following (rather useful) block that is executed during initialization:
if debug = True:
    turn_debug_logging_on()
else:
    turn_debug_logging_off()

Turning debug logging on is useful, but not turning it on shouldn't mean that it must be turned off. By default, such debugging is off anyway!
However, forcing it to be off can be troublesome. For example, I use this component in a smarthome platform, and it has a means to configure logging of it's components, libraries, etc. in a single log file.  The existing code overrules this behaviour.
My experience is that although I have enabled logging for evohomecleint, it doesn't occur unless I also set debug = True, and then I get more logging than I expected.
Here, I am proposing:
if debug = True:
    turn_debug_logging_on()

If debug is not true, then the debugging may still occur according to the expected behavior of logger

@watchforstock
In __init__.py there is:
class EvohomeClient(EvohomeBase):                                                # pylint: disable=too-many-instance-attributes
    """Provides access to the Evohome API"""

    # pylint: disable=too-many-arguments
    def __init__(self, username, password, debug=False, refresh_token=None,
                 access_token=None, access_token_expires=None):
        super(EvohomeClient, self).__init__(debug)

But in the other modules (e.g. controlsystem.py), there is:
class ControlSystem(EvohomeBase):
    """Provides handling of a control system"""

    def __init__(self, client, location, gateway, data=None):
        super(ControlSystem, self).__init__()

Is the second super supposed to include: debug=False?


GH-40547: [R][Docs] Add a non-technical introductory R vignette to the functioning of arrow

I propose a rough first draft of a non-technical introductory R vignette to the functioning of arrow.
As explained in this issue, this vignette provides an overview of how Arrow works in a plain, non-technical language. It aims at giving some simple and useful intuitions, before diving deeper in the documentation. It is specifically intended for newcomers with a limited background in computer science and hence avoids most technical terms.
Feel free to modify in any way you think is appropriate. I will try to add a few elements on how to deal with functions unsupported by acero.

GitHub Issue: #40547

I really like this! I need to find the time to properly review this in detail, so might be a bit delayed looking at it thoroughly, but I'm already a +1 on incorporating this into our docs once we've refined a few of the details.

I've given this a look over at a high level, and I think that there's some really great stuff in here.  I'm not sure this needs to be a separate vignette, and what I think might work well is reworking the "Getting Started" vignette, which is a bit repetitive in places and could be shortened and linked out to the other vignettes, and then incorporating some of this content in there.

Thanks for your patience @oliviermeslin.
What I propose is taking everything from, "### What's so special about Arrow?" up to but not including "### Overcoming the limitations of lazy evaluation" and paste this into the existing "get started with arrow vignette" before the "## Package conventions" section.  I think there are a few tweaks and changes we need to make, but it'll be easier to have this in the right place before feeding back on those.
If you're happy with me reworking what you have here with the existing content, then I'm happy to merge things in, or alternatively, I can provide feedback and walk through the changes to make (though I'm suggesting the former as there are lots of changes I'd like to make to the existing content).
Let me know what you think! :)

@thisisnic Sorry for the delay, I'm very busy these days. I think the easiest way to proceed if that you rework the content in the way you consider appropriate.

Sorry, life got busy - was discussing this with @amoeba earlier today and I think we could incorporate this by taking some of the key elements and making an FAQ actually.  Not sure if I'll get round to it or if someone else wants to, but it's a thought!


batch_size for distributed training

from build_loader function:
for distributed training, batch_size = samples_per_gpu
for non-distributed training, batch_size = num_gpus * samples_per_gpu
Since we need to adjust the learning rate based on the batch size, can we calculate the learning rate based on the above method? For distributed training, do we need to multiply the number of gpus for calculating the batch size? Thank you!
def build_dataloader(dataset,
samples_per_gpu,
workers_per_gpu,
num_gpus=1,
dist=True,
shuffle=True,
seed=None,
**kwargs):
Build PyTorch DataLoader.
"""
In distributed training, each GPU/process has a dataloader.
In non-distributed training, there is only one dataloader for all GPUs.
Args:
    dataset (Dataset): A PyTorch dataset.
    samples_per_gpu (int): Number of training samples on each GPU, i.e.,
        batch size of each GPU.
    workers_per_gpu (int): How many subprocesses to use for data loading
        for each GPU.
    num_gpus (int): Number of GPUs. Only used in non-distributed training.
    dist (bool): Distributed training/test or not. Default: True.
    shuffle (bool): Whether to shuffle the data at every epoch.
        Default: True.
    kwargs: any keyword argument to be used to initialize DataLoader

Returns:
    DataLoader: A PyTorch dataloader.
"""
rank, world_size = get_dist_info()
if dist:
    # DistributedGroupSampler will definitely shuffle the data to satisfy
    # that images on each GPU are in the same group
    if shuffle:
        sampler = DistributedGroupSampler(dataset, samples_per_gpu,
                                          world_size, rank)
    else:
        sampler = DistributedSampler(
            dataset, world_size, rank, shuffle=False)
    batch_size = samples_per_gpu
    num_workers = workers_per_gpu
else:
    sampler = GroupSampler(dataset, samples_per_gpu) if shuffle else None
    batch_size = num_gpus * samples_per_gpu
    num_workers = num_gpus * workers_per_gpu

init_fn = partial(
    worker_init_fn, num_workers=num_workers, rank=rank,
    seed=seed) if seed is not None else None

data_loader = DataLoader(
    dataset,
    batch_size=batch_size,
    sampler=sampler,
    num_workers=num_workers,
    collate_fn=partial(collate, samples_per_gpu=samples_per_gpu),
    pin_memory=False,
    worker_init_fn=init_fn,
    **kwargs)

return data_loader

Since each GPU has a dataloader, the batch size we set in the distributed training case has to be the real batch size / number of GPUs. You may need to manually adjust the learning rate according to the real batch size.


Determine the screen resolution of an application

Hello, I'm sorry for this silly question but I'd like to know if I should determine the screen resolution of the desktop (for example running in Xorg) before to call engo.Run function and then set RunOptions appropriately instead of using fixed constants Width and Height when the game is to be run in window mode or is this procedure a bad coding practice to avoid?

Hello! If you need the information about the monitor before calling engo.Run you can get it through GLFW. Here's the glfw monitor guide. You'd use the width and height of the monitor's VideoMode.

OK thank you very much!


Infinite loop exception

Hey IceRaptor,
I got this mod as part of the updated JK Rarity Table mods. It seems there's a bug that causes an infinite loop when launching a contract. The wait spinner keeps going and the log just fills with the following:
(Filename:  Line: -1)

KeyNotFoundException: The given key was not present in the dictionary.
at System.Collections.Generic.Dictionary`2<int, BattleTech.Framework.TeamOverride>.get_Item (int) <0x0019d>
at IRBT14MadlibsFix.Patches.LanceOverride_RunMadLibsOnLanceDef.Prefix (BattleTech.Framework.LanceOverride,BattleTech.Contract,BattleTech.LanceDef) <0x00079>
at (wrapper dynamic-method) BattleTech.Framework.LanceOverride.RunMadLibsOnLanceDef_Patch1 (object,BattleTech.Contract,BattleTech.LanceDef) <0x00030>
at BattleTech.Framework.LanceOverride/<RequestLance>c__AnonStorey0.<>m__0 (BattleTech.Data.LoadRequest) <0x00082>
at BattleTech.Data.LoadRequest.Finish () <0x0005a>
at BattleTech.Data.LoadRequest.FlushCompleteRequests (single) <0x001ca>
at BattleTech.Data.DataManager.CheckRequestsComplete (single) <0x0007f>
at BattleTech.Data.DataManager.Update (single) <0x00283>
at BattleTech.GameInstance.Update (single) <0x00121>
at BattleTech.UnityGameInstance.Update () <0x0005c>

It's possibly I have a conflict w/ another mod and this works fine by itself, but I wanted to bring it to your attention.

 I'm pretty sure I know exactly what the problem is, but need more context to help diagnose it.

Yes, still seeing it.
I installed ModTek 0.6.1 (see log below), deleted the .modtek folder, and restored "Z_Sab_JK_RarityTables" (v<IP_ADDRESS>-M) and "BT1_4_MadlibsFix" (v0.0.1).
I reloaded my career and started a new contract but the same thing happened (see 2nd log).
ModTek.log:
ModTek v0.6.1 -- 2/3/2019 11:59:25 AM
Building new config.
Copying over DB and building new DB Cache.
Building new Merge Cache.
Building new Type Cache.
output_log.txt:
(Filename:  Line: -1)
KeyNotFoundException: The given key was not present in the dictionary.
at System.Collections.Generic.Dictionary`2<int, BattleTech.Framework.TeamOverride>.get_Item (int) <0x0019d>
at IRBT14MadlibsFix.Patches.LanceOverride_RunMadLibsOnLanceDef.Prefix (BattleTech.Framework.LanceOverride,BattleTech.Contract,BattleTech.LanceDef) <0x00079>
at (wrapper dynamic-method) BattleTech.Framework.LanceOverride.RunMadLibsOnLanceDef_Patch1 (object,BattleTech.Contract,BattleTech.LanceDef) <0x00030>
at BattleTech.Framework.LanceOverride/c__AnonStorey0.<>m__0 (BattleTech.Data.LoadRequest) <0x00082>
at BattleTech.Data.LoadRequest.Finish () <0x0005a>
at BattleTech.Data.LoadRequest.FlushCompleteRequests (single) <0x001ca>
at BattleTech.Data.DataManager.CheckRequestsComplete (single) <0x0007f>
at BattleTech.Data.DataManager.Update (single) <0x00283>
at BattleTech.GameInstance.Update (single) <0x00121>
at BattleTech.UnityGameInstance.Update () <0x0005c>

Thanks for being patient. Could you try https://github.com/IceRaptor/BT1_4_MadlibsFix/releases/tag/REL_1.0.1? I've changed the code to not cause an NPE, but it in this case the madlibs fix won't work because there's no context. This may be okay though - depends on the tags being interpreted.

I just started two different contracts and no exceptions in the log. So far so good.
Thanks for your work on this.


Determine Integration Requirements for Aggie Experts in Site Farm

Site Farm is hosted and developed by IET. It would be beneficial to display Aggie Expert profiles and publications via the Site Farm UI to support departmental pages.
Is should be possible to allow API access to Aggie Experts for this purpose.
Consulting with Shawn DeArmond and Jeroen Post at IET Web Development.

[ ] Compare data fields between Aggie Experts and Site Farm profiles
[ ] Provide API documentation for Site Farm use.

I am assuming that a call like: https://sandbox.experts.library.ucdavis.edu/person/66356b7eec24c51f01e757af2b27ebb8
would provide the json content that would be parsed and consumed on the Site Farm side.

The API returns the JSON, but we volunteered, that for example, we could add additional APIs if they want.  For example, we could format all the bib items into HTML via an API.  Or we could provide them with client tools for that.

@UcDust Just be aware about that potential client-side help.  Something to think about, for us

Met on 10/23:

How to handle (too) many pubs - show only the top 10 ranked? - Most recent?
Favorites i.e. Could users pick which pubs to include?
Refreshing. Nightly? Modified since? On page show?
Roll out in sync between both systems?
Would like to use the Areas of Interest with labels.
Not sure managing pubs on SF side is possible/practical
Leaning JSON over HTML

Shawn will spec expected functionality of a custom endpoint.

Will move forward with design/dev of AE JSON REST API endpoint.

Met with Jeroen 11/28
Custom JSON structure for SF - Array for person and array for bibo
List of all possible elements
Can we provide:
Portrait
Phone
Office hours/location
Address
Edu & Degrees
Top list pubs?
Batch response for list of IDs (whole SF site updates per department)
Modifified since param


Get the temp dir path from env from os.tmpdir()

Replaces https://github.com/airportyh/testem/pull/473

Many thanks!

Thank you. Your change is released in 0.6.36


Add Jest code coverage and Travis CI configuration

CHANGELOG :memo:

added Jest code coverage
updated Travis CI job

LABELS

enhancement

MISC

Codecov code coverage
Travis CI build

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3b706df). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #59   +/-   ##
=========================================
  Coverage          ?   35.59%
=========================================
  Files             ?        7
  Lines             ?      118
  Branches          ?       17
=========================================
  Hits              ?       42
  Misses            ?       75
  Partials          ?        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b706df...c0fccb1. Read the comment docs.


[DRAFT] CUDA Scan implementation

Just an initial skeleton of a scan implementation for CUDA. For brevity I just used the reduce test spec to test my changes. Obviously it would need it's own spec.

@gevtushenko Can you take a look?


Log Errors: Sonoff LAN 2.1.4 running in Home Assistant 0.111.0

Hello @AlexxIT ,
I am using Sonoff LAN version 2.1.4 (local only mode) running in Home Assistant 0.111.0 and have noticed the following errors in my log.
2020-06-11 13:53:06 WARNING (MainThread) [homeassistant.setup] Setup of sonoff is taking over 10 seconds.

2020-06-11 14:40:29 ERROR (MainThread) [custom_components.sonoff.sonoff_local] 1000aa8f2a => Local4 | {'cmd': 'info'}
Traceback (most recent call last):
  File "/config/custom_components/sonoff/sonoff_local.py", line 268, in send
    json=payload, timeout=timeout)
  File "/usr/local/lib/python3.7/site-packages/aiohttp/client.py", line 504, in _request
    await resp.start(conn)
  File "/usr/local/lib/python3.7/site-packages/aiohttp/client_reqrep.py", line 847, in start
    message, payload = await self._protocol.read()  # type: ignore  # noqa
  File "/usr/local/lib/python3.7/site-packages/aiohttp/streams.py", line 591, in read
    await self._waiter
aiohttp.client_exceptions.ServerDisconnectedError: None

2020-06-11 15:27:26 WARNING (MainThread) [custom_components.sonoff.sonoff_local] 1000aa8f2a => Local4 | {'cmd': 'info'} !! Cannot connect to host <IP_ADDRESS>:8081 ssl:None [Connect call failed ('<IP_ADDRESS>', 8081)]

Everything appears to be working correctly but I wanted to mention it in case there is a fix that needs to be made to the component.
Thank you very much for all your work on this!! I am currently using it for 4 Sonoff S55 Switches in my Garden for various things and it works great. :)
Best regards,
Rodney

I hope fixed in https://github.com/AlexxIT/SonoffLAN/releases/tag/v2.1.5

Thank you, Alexx! :)


NSFS | NC |  S3 flow support

Explain the changes

create & delete bucket flows
put/set/delete bucket policy
set bucket versioning
put/set/delete bucket website - wasn't tested
put/set/delete bucket encryption - wasn't tested

Issues: Fixed #xxx / Gap #xxx

TODO: add automatic nc system tests

Testing Instructions:
currently just manual tests -

create account json under /path/to/config_dir/accounts/access_key.json
run nsfs nc - sudo node src/cmd/nsfs /path/to/fs/root_path --config_root=/path/to/config_dir/
alias s3-user='AWS_ACCESS_KEY_ID=access_key AWS_SECRET_ACCESS_KEY=secret_key aws --endpoint https://localhost:6443 --no-verify-ssl s3'
s3-user mb/ls/cp etc
s3-user api put-bucket-policy/put-bucket-versioning/delete-bucket etc

[ ] Doc added/updated
[ ] Tests added

LGTM


[Bug]: Static Value from Example Showing up in Sub Question Query Engine without using Example Data

Bug Description
Receiving KeyError: 'uber_10k'
Error occurs when trying to query sub question query engine. Collection of Sub Question Query Engines were NOT built with any example documents.
Version
0.8.43
Steps to Reproduce
list_of_values = ['a','b','c']
query_engine_tools = []
llm = LlamaCPP(
model_url="https://huggingface.co/TheBloke/Llama-2-13B-chat-GGUF/resolve/main/llama-2-13b-chat.Q4_0.gguf",
temperature=0.01,
max_new_tokens=256,
context_window=3900,
generate_kwargs={},
model_kwargs={"n_gpu_layers": 0},
verbose=True,
)
service_context = ServiceContext.from_defaults(llm=llm, embed_model=embeddings)
for value in list_of_values:
docs = SimpleDirectoryReader(cfg.PATH_TO_DATA+"/"+value).load_data()
vector_index = VectorStoreIndex.from_documents(docs,service_context=service_context)
query_engine = vector_index.as_query_engine()
query_engine_tool = QueryEngineTool(
query_engine=query_engine,
metadata=ToolMetadata(name=f"{value}",
description="Provides information on value" + value)
)
query_engine_tools.append(query_engine_tool)
response_synthesizer = get_response_synthesizer(
response_mode=ResponseMode.COMPACT,
)
final_query_engine = SubQuestionQueryEngine.from_defaults(query_engine_tools=query_engine_tools,
service_context=service_context,
response_synthesizer=response_synthesizer,
use_async=False)
query = "What documents use the word hello?"
final_query_engine.query(query)
Relevant Logs/Tracbacks
/llama_index/indices/query/base.py", line 23, in query
return self._query(str_or_query_bundle)
/llama_index/query_engine/sub_question_query_engine.py", line 141, in _query
qa_pairs_all = [
/llama_index/query_engine/sub_question_query_engine.py", line 142, in <listcomp>
self._query_subq(sub_q, color=colors[str(ind)])
/llama_index/query_engine/sub_question_query_engine.py", line 245, in _query_subq
query_engine = self._query_engines[sub_q.tool_name]
KeyError: 'uber_10k'

llama2 is not great at structured outputs (like the sub-question query engine). In fact, nearly every open-source LLM is not great at this task, very unreliable.
It's likely copying from the few-shot prompt in the question generator
https://github.com/run-llama/llama_index/blob/3147cfc891e9b3738bcfcd7cac7dce6e23588123/llama_index/question_gen/prompts.py#L26

That makes sense! Thank you!


How to include mpr into ohif?

OHIF v2 (master branch) can show MPR by clicking on the 2D MPR in the toolbar, if the series is reconstructable

But How to use MPR in v3. Or is there any other alternative in v3, if yes where is it and how to use it? And I'm trying to install the latest release but facing issues ininstallation. Can someone please guide me.

check out the supported features in v3 https://v3-docs.ohif.org/release-notes

Do you have any idea what the Other plans is or when they will announce

Any update on this? The v3 release note says that VTK Extension + MIP / MPR layout is included, however, branch v3-stable by default does not include MPR tool.

The functionality is there now in code, but the v3 release will come with a MPR button which would convert the active viewport to a 1x3 MPR similar to v2.

When is the next release? can you tell me how to activate the button?

Any latest update on mpr in v3 release? mpr button still does't work in v3.

@mohammedameen028 The icon is added v3-demo.ohif.org

It is already there


Added Red Dead Redemption

VS converted the tab indentation to spaces, let me know if that (or the file rename) should be reverted

It didn't change tabs to space, it already was spaced. It changed CLRF line endings to LF endings, that I do not like (not necessarily what type of line ending is used, but changing it for already existing files).
Also, I don't think it was VS but Git, depending on how you have it configured, it may mess with line endings, it's really dumb feature, check your core.autocrlf settings. But VS did for sure auto removed unsused usings. Also imo unnecessary when doing this type of changes, it just muddies change history.


Hunterised 'gennodejs' package.

Minimal changes.

Released: https://github.com/hunter-packages/ros_gennodejs/releases/tag/v2.0.1-p0


Add fileFormat and testFiles args along

Hey, this PR adds fileFormat as an option. This is because we are using TypeScript, it's very useful to have the option. As well as that, I found that files were not loading in as testFiles were not set in my cypress.json. I've added testFiles as an arg with the default that cypress sets.
I've also added the use of glob. It easily enables me to work with my nested test suite structure without having any effect on the current functionality.

@trentrand Hi, thanks for the feedback :D I've addressed all of your comments just have one question 👍

@SamWyldKW I addressed the last feedback but unfortunately I can't amend this PR because the branch is owned by you.
Do you mind clicking this checkmark so that I can contribution permissions?

I'll push the change and get this merged shortly after!

Hey I have it checked. You should be able to 👍

How strange

@SamWyldKW I lost permission to your branch again so I went ahead and just pushed the commit directly to master.
I've tested it locally and it works great - thank you very much for the contribution!

Published as<EMAIL_ADDRESS>on npm registry and Github packages.


typo: Double word "modified"

Hi, @nschonni the specs files are generated from our source code so we don't accept fixes to them as they would be overwritten.
However, I checked the typos you pointed out and found that some are still present even in the newer versions, I will be fixing the typos from our side so the generated specs do not have these typos. Thanks!


How to deploy on server?

What changes do I need to make to get it up and running on the server.
I've configured the server. I'm also attaching my config file. But somehow I'm not able to access the app on Public IP of my VPS.
(PS: This is my first time hosting)
Here are the exact steps I've followed.
My server's Local IP : <IP_ADDRESS>
I have a public IP Address

I cloned repository at path "/home"
Made changes to Config files (attached below)
I did npm install in both app and sever folders.
npm run build in app folder
redis-server (in first terminal)
npm start (in second terminal) in server folder.
npm start (in third terminal) in app folder.

So technically I should be getting my app at publicip:443 port (tried all the ports, nothing)
Here's my config file (important snippets)
`const os = require("os");
const userRoles = require("../userRoles");
const { BYPASS_ROOM_LOCK, BYPASS_LOBBY } = require("../access");
const {
CHANGE_ROOM_LOCK,
PROMOTE_PEER,
SEND_CHAT,
MODERATE_CHAT,
SHARE_SCREEN,
EXTRA_VIDEO,
SHARE_FILE,
MODERATE_FILES,
MODERATE_ROOM,
} = require("../permissions");
// const AwaitQueue = require('awaitqueue');
// const axios = require('axios');
module.exports = {
// Auth conf
/*
auth :
{
lti :
{
consumerKey    : 'key',
consumerSecret : 'secret'
},
oidc:
{
// The issuer URL for OpenID Connect discovery
// The OpenID Provider Configuration Document
// could be discovered on:
// issuerURL + '/.well-known/openid-configuration'
                    issuerURL     : 'https://example.com',
                    clientOptions :
                    {
                            client_id     : '',
                            client_secret : '',
                            scope                   : 'openid email profile',
                            // where client.example.com is your multiparty meeting server
                            redirect_uri  : 'https://client.example.com/auth/callback'
                    }

            }
    },

`
`// URI and key for requesting geoip-based TURN server closest to the client
turnAPIKey: "examplekey",
turnAPIURI: "turn:numb.viagenie.ca",
turnAPIparams: {
uri_schema: "turn",
transport: "tcp",
ip_ver: "ipv4",
servercount: "2",
},
// Backup turnservers if REST fails or is not configured
backupTurnServers: [
{
urls: ["turn:numb.viagenie.ca"],
username<EMAIL_ADDRESS>credential: "muazkh",
},
],
fileTracker: "wss://tracker.lab.vvc.niif.hu:443",
redisOptions: {},
// session cookie secret
cookieSecret: "T0P-S3cR3t_cook!e",
cookieName: "multiparty-meeting.sid",
// if you use encrypted private key the set the passphrase
tls: {
cert: ${__dirname}/../certs/cert.pem,
// passphrase: 'key_password'
key: ${__dirname}/../certs/privkey.pem,
},
// listening Host or IP
// If omitted listens on every IP. ("<IP_ADDRESS>" and "::")
// listeningHost: 'localhost',
// Listening port for https server.
listeningPort: 443,
// Any http request is redirected to https.
// Listening port for http server.
listeningRedirectPort: 80,
// Listens only on http, only on listeningPort
// listeningRedirectPort disabled
// use case: loadbalancer backend
httpOnly: false,
// WebServer/Express trust proxy config for httpOnly mode
// You can find more info:
//  - https://expressjs.com/en/guide/behind-proxies.html
//  - https://www.npmjs.com/package/proxy-addr
// use case: loadbalancer backend
trustProxy: "",
// This logger class will have the log function
`
`// mediasoup WebRtcTransport settings.
webRtcTransport: {
listenIps: [
// change <IP_ADDRESS> IPv4 to your server's IPv4 address!!
{ ip: "<IP_ADDRESS>", announcedIp: null },
    // Can have multiple listening interfaces
    // change 2001:DB8::1 IPv6 to your server's IPv6 address!!
    // { ip: '2001:DB8::1', announcedIp: null }
  ],
  initialAvailableOutgoingBitrate: 1000000,
  minimumAvailableOutgoingBitrate: 600000,
  // Additional options that are not part of WebRtcTransportOptions.
  maxIncomingBitrate: 1500000,
},

},
// Prometheus exporter
/*
prometheus: {
deidentify: false, // deidentify IP addresses
numeric: false, // show numeric IP addresses
port: 8889, // allocated port
quiet: false // include fewer labels
}
*/
};
`
Also, this is how my multiparty-meeting.service looks like.
[Unit]
Description=multiparty-meeting is a audio / video meeting service running in the browser and powered $
After=network.target

[Service]
ExecStart=/home/pingping/server/server.js
Restart=always
User=nobody
Group=nogroup
Environment=PATH=/usr/bin:/usr/local/bin
Environment=NODE_ENV=production
WorkingDirectory=/home/pingping/server
AmbientCapabilities=CAP_NET_BIND_SERVICE

[Install]
WantedBy=multi-user.target

``

Hi @callmemonky ,
Do you know the internal working of this application.

Hi @callmemonky ,
Do you know the internal working of this application.

Yeah. I'm working on it. Why did you ask?

Hi @callmemonky ,
If you know the internal working of this application then you should not face any issue to deploy it on server .
I would really encourage you to please read the documentation of the technology on which this app is based upon.
Regards

I think it's more of server side things than app working.
I would appreciate you directing me in a right direction..as it will save a lot of time and energy. Plus definitely gonna learn from it.

How do you start your server?
your configured user (nobody) in multiparty-meeting.service is not allowed to listen on privileged ports like 443 or 80
Recommended for this is either to configure unprevileged ports and make a firewallrule
iptables -A PREROUTING -i bond0 -p tcp -m tcp --dport 443 -j REDIRECT --to-ports 4443
iptables -A PREROUTING -i bond0 -p tcp -m tcp --dport 80 -j REDIRECT --to-ports 8080
or allow the configured user access to these ports via systemd config (I don't know how to do this).

@so010 hey Stefan! I ran those commands..didn't work. Can you guide how to deploy?

Hey, @callmemonky.  I have the same problem. I'm using the docker on AWS. This solution https://github.com/edumeet/edumeet/issues/508 seems to have solved this guy's, but it didn't work for me. See if it works for you. Basically what he did, in addition to defining the turn server, was defining the external ip there in announcedIp:

Hey, @callmemonky.  I have the same problem. I'm using the docker on AWS. This solution https://github.com/edumeet/edumeet/issues/508 seems to have solved this guy's, but it didn't work for me. See if it works for you. Basically what he did, in addition to defining the turn server, was defining the external ip there in announcedIp:

Not working.

@so010 hey Stefan! I ran those commands..didn't work. Can you guide how to deploy?

the iptables command depends on how your firewall is configured but "bond0" here is the local network interface which is in your case different I assume, run "ip a" to check your interfaces. It depends as well how your VPS is setting up network for your servers. So if local ip is different from public ip then you need to define public ip for announcedIp.
You can as well check logging.

or allow the configured user access to these ports via systemd config (I don't know how to do this).

This seems to do this (not tested)
https://stbuehler.de/blog/article/2017/06/23/systemd__allow_normal_process_to_bind_to_privileged_port.html
and an alternative:
https://liquidat.wordpress.com/2018/01/04/howto-run-programs-as-non-root-user-on-privileged-ports-via-systemd/

Not Working for me :/

https://github.com/edumeet/edumeet/issues/541 @pierguinzani @callmemonky @so010 @harivyas35 @ibc Help me please!

I can't connect to the video conference -> #541 [...] @ibc Help me please!

Please don't do that again.

logs?

process.env.DEBUG: undefined
config.mediasoup.worker.logLevel: warn
config.mediasoup.worker.logTags: [ 'info', 'ice', 'dtls', 'rtp', 'srtp', 'rtcp' ]
(node:19044) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated

@eshpilevsky, Check if the port used in the application is already being used.

If you can't connect on TCP to port 80 to your VPS is your local issue. Please solve it with your VPS provider.
I've configured the server. I'm also attaching my config file. But somehow I'm not able to access the app on Public IP of my VPS.

If you configure according our documentation and your VPS NAT settings are correct, you should be able to connect to port TCP 80 and 443.
I don't think we can help you more on it, because your issue is likely not bug in our sw. Please open a separate issue with a exact problem statement, and we will try to help.