Need to access underlying ticket struct

Hello @Gramps . Just started using Godot and I'm a big fan of your work. I have a problem though, I want to validate the AuthSessionTicket that getAuthSessionTicket() retrieves. Unfortunately inorder to do that on a server (via steams web api) it seems I need access to the underlying buffer and size variable in the struct. Do you have any existing methods to access these?
https://github.com/Gramps/GodotSteam/blob/49742f8566de8f324a0aae8bd7da6201d5189789/godotsteam/godotsteam.h#L383

Hey there and thank you, sir!  Hmm, I believe those were added in as a pull request a while back but this seems like a good time to dig into and finish the Users stuff!
Looking at the current function, it seems to just pass back the ID.  Since the ticket data struct is mostly just used for internal purposes, you could try modifying the getAuthSessionTicket() function to get the data you want:
Dictionary Steam::getAuthSessionTicket(){
	Dictionary ticket_data;
	if(SteamUser() == NULL){
		return ticket_data;
	}
	uint32_t ticketSize = 1024;
	uint32_t *buffer = memnew_arr(uint32_t, ticketSize);
	uint32_t id = SteamUser()->GetAuthSessionTicket(buffer, ticketSize, &ticketSize);
	// Pass data to TicketData struct for later use
	TicketData ticket = { id, buffer, ticketSize };
	tickets.push_back(ticket);
	// Create dictionary to return this ticket
	ticket_data["id"] = id;
	ticket_data["buffer"] = buffer;
	ticket_data["size"] = ticketSize;
	return ticket_data;
}

This is pretty hacked together and I haven't tested it; however, it does seem to compile OK.  You'll also want to change line 291 in the godotsteam.h file to:
Dictionary getAuthSessionTicket();

Let me know if this works for you.  I don't know too much about cross-play between the Steam web API and the Steamworks C++ stuff but hopefully this works for you!

Thanks for the quick response. I tried your proposed update and it almost worked, but it seems that I didn't actually receive the buffer using GDscript. (Not exactly sure how this works so let me know if it would work in GDNative or C#).
My code:

func _ready():
	_init_steam()
	SESSION_TICKET = Steam.getAuthSessionTicket()
	print(SESSION_TICKET)
	print(typeof(SESSION_TICKET["buffer"]) == TYPE_BOOL)
	Steam.connect("get_auth_session_ticket_response", self, "_get_auth_session_ticket_response")

With an output of this:

{buffer:True, id:10, size:234}
True

Welcome!  Hmm, the buffer might need converted.  I know with the avatar image data that comes back as a buffer it has to be processed to output the image; granted this is way different than image data.  After looking over the stuff for the Steam API authentication, I see why it is set up the way it is as it just keeps an internal list of that data but getting the auth tickets is still useful.
I might have to look at the Steam web API stuff to figure it out a bit better.  I'll dig into this over the weekend and see what I can't find out.

That makes sense. I really don't need to validate the user (plenty of other stuff to do) so no rush but I do think it will be a nice to have eventually.

Fair enough.  Hopefully I'll have time tomorrow evening while compiling Linux versions to really read it over and think of a solution.

Hey there!  Still haven't had much luck pulling the data out but am going to try some new tricks this weekend.  Wanted to let you know I am still plugging away at it when I have time.

Thank you!

Working on some authorization stuff this weekend and hopefully will have a solution for this.  I know there are some callbacks missing so hopefully I can get them all sorted out then.

Hey there!  I added a new function called getAuthSessionTicketID which should return the ticket as a dictionary.  Let me know if that works for you.  If so I'll change the names around with getAuthSessionTicket so they are accurate.

Going to swap the names around in GodotSteam 3.4.2, so keep an eye out for that.  I will close the issue for now unless you find the new function doesn't give you the information you need.

Okay awesome thank you Gramps. Haven't had the opportunity to try this yet.

No problem! Hopefully it does what you require.  If not, re-open the issue and we'll sort it out.


Vimeo bug on pure digit urls

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2021.12.17
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

% youtube-dl -c -i https://vimeo.com/791078894/4616111735 --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-c', '-i', 'https://vimeo.com/791078894/4616111735', '--verbose']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2021.12.17
[debug] Git HEAD: 344d32bf7
[debug] Python version 3.10.9 (CPython) - macOS-11.2.3-arm64-arm-64bit
[debug] exe versions: ffmpeg 5.1.2, ffprobe 5.1.2
[debug] Proxy map: {}
[vimeo]<PHONE_NUMBER>: Downloading webpage
[vimeo]<PHONE_NUMBER>: Downloading JSON metadata
[vimeo]<PHONE_NUMBER>: Downloading JSON metadata
ERROR: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by <HTTPError 404: 'Not Found'>); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "/opt/homebrew/Cellar/youtube-dl/2021.12.17/libexec/lib/python3.10/site-packages/youtube_dl/extractor/common.py", line 634, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "/opt/homebrew/Cellar/youtube-dl/2021.12.17/libexec/lib/python3.10/site-packages/youtube_dl/YoutubeDL.py", line 2288, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File<EMAIL_ADDRESS>line 525, in open
    response = meth(req, response)
  File<EMAIL_ADDRESS>line 634, in http_response
    response = self.parent.error(
  File<EMAIL_ADDRESS>line 563, in error
    return self._call_chain(*args)
  File<EMAIL_ADDRESS>line 496, in _call_chain
    result = func(*args)
  File<EMAIL_ADDRESS>line 643, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)

Description

Hello.

Most of them work well, except this single one:
https://vimeo.com/791078894/4616111735
By inspecting the format of this url, it seems that the last part<PHONE_NUMBER>) by chance is consisted of full digits, without any English letters a-z. The log starts with Downloading webpage, instead of Downloading JSON metadata.

I've searched the bugtracker for similar issues including closed ones

Nonetheless, duplicate of #29690, fixed in git master.

I've searched the bugtracker for similar issues including closed ones

Nonetheless, duplicate of #29690, fixed in git master.

Oh I'm sorry... Thanks for pointing me to that.


add reservation action

in this milestone I add reservation action, where we can book a rocket and cancel the book

Hi team🙋♀,
Good job implementing all the project requirements for this milestone/project.
STATUS APPROVED ✔
Your project is complete! There is nothing else to say other than... it's time to merge it 🔗 🚢
Congratulations! 🎉
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers 🥂 and Happy coding!👏👏👏


Code cleanup using context

The debugs using the caller of method has been extremely useful
in faster debugging and understanding of flow. This commit uses context
to pass in the caller information instead of explicit method names.
The ideal way would have been to use the runtime package Caller function
to get the callers from the function stack instead of passing the method
explicitly. However since the caller tree need not be symmetric it would
make it ugly to retrieve the interested caller. Hencing moving the method
name passing to context which would make it cleaner and more readable.
Signed-off-by: Abhinandan Prativadi<EMAIL_ADDRESS>

@abhinandanpb Thanks makes sense, I was hoping there was something more structured to achieve that result.
There is only 1 error, the rest looks fine to me

LGTM, @sanimej ?

@abhinandanpb Having the caller's name does help to follow the debugs quicker. But using context is probably is not the right thing to do here.. from the context package,
Use context Values only for request-scoped data that transits processes and APIs, not for passing optional parameters to functions.
Using runtime.Callers will be better and also avoids the manual setup of the caller name all over the code. In most cases we are interested only in the immediate caller of the function. But if needed caller stack can be set to the required number. What do you mean by caller tree not being symmetric ?

@sanimej: I agree completely.


how to generate 'tokens_positive'  ann from detector dataset like object365?

I found 'tokens_positive' was used in your ann file. could you please release the code of how to process detect data like coco to get the 'tokens_positive' ann results?

Hi @zhouxingguang,
Apologies for the delayed response. Following MDETR, we use annotations from the referring expressions datasets (RefCOCO, RefCOCO+, and RefCOCOg [36]) for COCO images. Please refer to the implementation details section on page 5 of our paper and Appendix C in MDETR for more details. Also the corresponding scripts to prepare the datasets are available at the MDETR official repo at https://github.com/ashkamath/mdetr/tree/main/scripts/pre-training.
I hope this would be helpful. Do let me know if you have any questions. Thanks


Can't squash commit in interactive rebase editor

git log

The first commit should have squash as an option in the menu, I can set it using the keyboard but not the dropdown.
v11.0.2

Git rebase doesn't let you squash/fixup the last commit (because you would be then modifying a commit outside of your rebase target). If you want to squash into that last commit you need to rebase to its parent.
Its a bug that it even shows up in the dropdown as an option.

Yeah I understand that, I think it should not show up in the last commit's dropdown, and it should show up in the first one, right?

Yup for some reason those 2 are reversed.

@roblourens I can't seem to reproduce this -- but something else looks wrong in that screenshot.  The base commit is missing. Are those the only 2 commits on that branch?

So it looks like it is caused by the missing base commit. But not exactly sure how you are hitting that. Is this a repo I have access to that I can try it?

Sorry, the repo was in /tmp and it's gone now. It was a fairly straightforward setup, but I just tried to set up the same situation, and now it seems to work fine...


UI build fails due to a private dependency

🐛 Bug

Reported by an user ayoola fakoya on slack
Exit code: 128
Command: git
Arguments: ls-remote --tags --heads<EMAIL_ADDRESS>Directory: /home/ayoola/LAI-Echo-App/echo/ui
Output:
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

it is public now :chipmunk: https://github.com/Lightning-AI/lightning-ui

it is public now 🐿 https://github.com/Lightning-AI/lightning-ui

I tried it, it still has the same issue. Moreover, the link you pasted is void.

This the error gotten

yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
info There appears to be trouble with your network connection. Retrying...
error Command failed.
Exit code: 128
Command: git
Arguments: ls-remote --tags --heads<EMAIL_ADDRESS>Directory: C:\Users\Bree\stable-diffusion-deploy\muse\ui
Output:
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

This is the error I get whenever I try to install packages or build.
`yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
info There appears to be trouble with your network connection. Retrying...
error Command failed.
Exit code: 128
Command: git
Arguments: ls-remote --tags --heads<EMAIL_ADDRESS>Directory: C:\Users\Bree\stable-diffusion-deploy\muse\ui
Output:
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.`

hmm not sure...

@Ayo-faks, this error indicates that you likely don't have SSH auth setup on GitHub. This PR removes this requirement.
@aniketmaurya, if you can give linked PR a look, please :)

@Ayo-faks, can you please check if is fixed for you on the latest main commit?


[bug] Resuming dunst notifications even if they were already turned off before locking.

It is a great feature that betterlockscreen blocks dunst notifications during lock time and enables them back at unlock.
However, in the event were the user would have turned of the notifications for some other reason manually, they will be turned back on by betterlockscreen.
One would then have to turn them back off each time he unlocks his screen.
dunstctl is-paused could be used to test if the notifications were blocked initially. betterlockscreen should then do nothing with dunst.

Hey, I see you point and it's planned to merge with https://github.com/jeffmhubbard/multilockscreen/blob/multi-monitor/multilockscreen#L86 which already has that feature :)

I am not sure that we are talking of the same thing.
Looking at the prelock and postlock functions from both multilockscreen and betterlockscreen, it seems to me that they have exactly the same behaviour but are simply doing it in a different way (pkill -u for betterlockscreen and dunst set-paused for multilockscreen).
Both of them behave the same way in this (problematic) case:

I enter a meeting and turn of my dunst notifications manually (for instance, writing dunstctl set-paused true).
I leave the meeting for a while, leaving my computer so I lock it using betterlockscreen. The prelock function pauses the dunst notifications: this does not change anything as they are already off but doesn't harm in any way either.
I come back to keep going with the meeting and unlock my computer. Then, the postlock function will turn dunst notifications back on no matter what. This is not what I expect: I expect the notifications to stay disabled until I enabled them back manually.

I admit that this is an edge case that might not be worth tackling.
The fix would need to keep an internal state between lock and unlock: were_dunst_notifications_already_turned_off_before_locking. The latter variable, if true would prevent turning notifications back in postlock.
If you think that this is relevant, I could work on a PR to do it.
If you prefer your tool to stay simple and ignore this edge case, I would completely get it.
Thank you for the nice work anyway !
PS: I might completely have misunderstood your reply and the fix you mentioned is indeed a fix. But from what I understand this is not the case.

You are right, I didn't see the edge case - I have to look deeper into it as it didn't seem to me that postLock is executed after unlock then after lock is really launched. So for me , it enables the notifications currently right away if you would switch to my pointed solution.
I would like to respect this case in the future when we have a better handling overall for this, as it is very common.

You are right on the fact that postlock seems to be executed right after the lock and not after the unlock.
But, knowing this, what is the point of re-enabling the notifications instantly right after disabling them ?
On multilockscreen, it says that postlock is executed after unlock (https://github.com/jeffmhubbard/multilockscreen/blob/multi-monitor/multilockscreen#L139) but it seems that it is the same behaviour... I would like to check that.

After a few experiments:

betterlockscreen runs postlock directly after lock
Differently, multilockscreen runs its postlock after unlock (so it makes sense)

Thanks for your investigation, this was also what I explored except the part comparing with Multilockscreen. From the first look and code parts I tried I didn't got Betterlockscreen to behave equal so I skipped it for now as I wanted to check first if Multilockscreen would fix this.
So for now after Multilockscreen is merged, we can get back to the original issue storing the dunst-status before locking and checking this in postLock to decide what to do 👍🏻

Hi @GaetanLepage  can you test https://github.com/pavanjadhaw/betterlockscreen/pull/233 this PR?

I'm not sure if this is at all related but I'm sort of experiencing the opposite behaviour; notifications are enabled when the screen is locked regardless of whether I manually enable or disable them beforehand.
Instead of trying to describe the behaviour, I've recorded a short video to demonstrate what's happening.
https://libremedia.video/videos/watch/e524eb88-70da-4a6f-83b3-79c324cf9007

@Amolith #233 was merged with multi-monitor branch. So are you checking master multi-monitor ?

@Amolith @GaetanLepage If you have time and would like to, it would really help us if you could checkout the latest multi-monitor branch and make some testing? :)

I just tested the multi-monitor branch:
I disabled dunst notifications manually first. I then locked the screen and unlocked it.
The notifications were indeed still off -> success !

Thanks for the Feedback 👍🏻

Tested with latest multi-monitor -> done 👍🏻


Add backport failed label

It would be useful to automatically add a label when the backport failed, to make it easier to track which backports need to be handled manually.

That's an interesting idea 💡
Currently the alerting is done via:

the action creating a comment on the pull request
the workflow run error notification if something went really wrong or it was unable to create a comment

Generally the comment can be created in most failure cases, unless:

there are network issues or issues with GitHub APIs
the GITHUB_TOKEN does not have permissions to create a comment
or if there is some bug (e.g. somehow the wrong pull request number is used)

I might have missed some failure cases here, but in general any other cases should be covered by the workflow run error.
Anyways, adding a label can be done for all the same situations as creating the comment, as it also depends on the same properties (GH API, TOKEN, etc). I'd prefer to have it configurable where the default configuration is to not add a label, to keep behaviour the same for other users.
@mjlbach Is this what you had in mind? And how do you feel about the other failure cases? Sadly, this cannot be a catch-all solution.

I think those are fine :) Usually the failure cases I'm running into are still commented (backports applied in the wrong order) and I just want a nice way in the GH ui to take a look at the ones that failed. I realize it wouldn't be a catch-all since failures in the GH API itself are inevitably going to result in some misses.

Hi @korthout,
thanks for creating this action, really helpful.
I find the idea of labelling the PR very useful as well, especially when the cherry-pick fails. Atm, the creation of the comment is the only notification in such cases, and there is no other way to know whether the cherry-pick failed.
Alternatively, if you could add that information to the action's output that would be sufficient as well. One can then react on the result in a subsequent step.
Best,
Alex

I agree @alxgrk. The failure scenarios can be improved, and your alternative sounds like a good idea, enabling more flexibility. Would you be willing to contribute such a solution? If not, I'll pick this up at some point. I'm sure my team would appreciate this as well.

@korthout, created a PR. Wasn't sure how to test it, though - do you have some kind of playground for this project?

Wow! Thanks for this, @alxgrk! I built an E2E testing project for this https://github.com/korthout/backport-action-test 😄 (sadly doesn't cover conflicts yet, but I can do that manually)

There appears to be an issue with GH at the moment
branch 'case1-new-changes' set up to track 'origin/case1-new-changes'.
+ gh pr create --head case1-new-changes --base main --title 'Case(1): Add a changed line' --body 'Adds a changed line' --label 'backport case1-backport-target'
https://github.com/korthout/backport-action-test/pull/210
+ gh pr merge --merge --auto --subject 'case(1): merge pull request'
! Pull request #202 (Case(1): Add a changed line) has diverged from local branch

Clearly, the E2E test created a PR (https://github.com/korthout/backport-action-test/pull/210), but it does not exist. So the CLI struggles because the latest run with changes that looked like this was 202 but doesn't match the same history.
I'll continue the test later when GH has resolved its issue.

@mjlbach With release Backport-action v1.1.0, there's now a workaround available. You can use the outputs to determine whether the backport-action was successful. If it was unsuccessful, you could use an action like Labeler to label your pull request.
I still keep this issue open because I think it's valuable if the action could just label the pull request out of the box, with batteries included.


Deployment script

scripts/.DS_Store git a pesky .dsstore (happens to me all the time)

I think the the .DS_store file is still here, unless github is just acting up


index.md: suit vs suite

suit is a verb (in this context) while suite is a noun (only) :3

Oops. Thanks!


Handle ACL permissions correctly

Currently s3rename does not handle Access Control List permissions resulting in publicly accessible objects becoming private when renamed.
See: https://docs.aws.amazon.com/AmazonS3/latest/dev/acl-overview.html

Could allow specification of Canned ACL (like the AWS CLI does): https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutObjectAcl.html

Fixed in general, although still not clear if bucket ACL dependent ACLs such as public write access are preserved correctly.


[openssl] Build error

wlvm@minint-p8ur1vk:~/Documents/vcpkg$  vcpkg install openssl
Computing installation plan...
The following packages will be built and installed:
openssl:x64-linux -> 3.3.0
Detecting compiler hash for triplet x64-linux...
Restored 0 package(s) from /home/wlvm/.cache/vcpkg/archives in 64.2 us. Use --debug to see more details.
Installing 1/1 openssl:x64-linux...
Building openssl:x64-linux...
-- Using cached openssl-openssl-openssl-3.3.0.tar.gz.
-- Cleaning sources at /home/wlvm/Documents/vcpkg/buildtrees/openssl/src/nssl-3.3.0-961d78b8a1.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /home/wlvm/Documents/vcpkg/downloads/openssl-openssl-openssl-3.3.0.tar.gz
-- Applying patch cmake-config.patch
-- Applying patch command-line-length.patch
-- Applying patch script-prefix.patch
-- Applying patch windows/install-layout.patch
-- Applying patch windows/install-pdbs.patch
-- Applying patch unix/android-cc.patch
-- Applying patch unix/move-openssldir.patch
-- Applying patch unix/no-empty-dirs.patch
-- Applying patch unix/no-static-libs-for-shared.patch
-- Using source at /home/wlvm/Documents/vcpkg/buildtrees/openssl/src/nssl-3.3.0-961d78b8a1.clean
openssl requires Linux kernel headers from the system package manager.
They can be installed on Alpine systems via apk add linux-headers.
They can be installed on Ubuntu systems via apt install linux-libc-dev.
-- Found external ninja('1.11.1').
-- Getting CMake variables for x64-linux
-- Getting CMake variables for x64-linux-dbg
-- Getting CMake variables for x64-linux-rel
-- Configuring x64-linux-dbg
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
Command failed: /usr/bin/bash -c "V=1 ./../src/nssl-3.3.0-961d78b8a1.clean/vcpkg/configure  "/usr/bin/perl" "/home/wlvm/Documents/vcpkg/buildtrees/openssl/src/nssl-3.3.0-961d78b8a1.clean/Configure" "linux-x86_64" "enable-static-engine" "enable-capieng" "no-tests" "no-docs" "no-shared" "no-module" "no-apps" "--openssldir=/etc/ssl" "--libdir=lib" "--disable-silent-rules" "--verbose" "--disable-shared" "--enable-static" "--debug" "--prefix=/home/wlvm/Documents/vcpkg/installed/x64-linux/debug""
Working Directory: /home/wlvm/Documents/vcpkg/buildtrees/openssl/x64-linux-dbg
Error code: 2
See logs for more information:
/home/wlvm/Documents/vcpkg/buildtrees/openssl/config-x64-linux-dbg-err.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_configure_make.cmake:863 (vcpkg_execute_required_process)
ports/openssl/unix/portfile.cmake:106 (vcpkg_configure_make)
ports/openssl/portfile.cmake:79 (include)
scripts/ports.cmake:175 (include)
error: building openssl:x64-linux failed with: BUILD_FAILED
Elapsed time to handle openssl:x64-linux: 1.5 s
Please ensure you're using the latest port files with git pull and vcpkg update.
On Fedora Linux

See #30604 How to report a package build failure.
FWIW - try installing and/or verify the installation of the required system libraries:

-- Using source at /home/wlvm/Documents/vcpkg/buildtrees/openssl/src/nssl-3.3.0-961d78b8a1.clean
openssl requires Linux kernel headers from the system package manager.
They can be installed on Alpine systems via apk add linux-headers.
They can be installed on Ubuntu systems via apt install linux-libc-dev.

See #30604 on how to properly report an issue.


Entity Id's are non-descriptive

I have had this running for some time and struggle with external dashboarding (I.e. Grafana via InfluxDB) due to how the Entity Id's for each device are names. Is it possible to name entities with the device name as a prefix to give more descriptive entity names.
Example, my Inverter's Power entity_id is "sensor.power_17" which gets confused between the other inverters as well as Power Monitoring plugs at home

this should be fixed, you need to enable it via options on the integration.  It will create new entities.  Might need to delete/recreate to get it to actually create.


ignition.config.url isn't supported on VMWare

Description
It should be possible to set the property guestinfo.ignition.config.url (CoreOS config url in the UI) and have the VM use it the same way it would if it was set on the kernel command line.
Instead, even though the property is present, it's silently ignored.
Impact
My clients have to paste a long base-64 value into the guestinfo.ignition.config.data property and set guestinfo.ignition.config.data.encoding to base64 instead of using the shortened url I created for them. We wasted a lot of time trying to figure out why setting the url wasn't working even though there's a property for it.
Environment and steps to reproduce

Set-up: A freshly-created VM from downloading the OVA.
Task: First boot
Action(s):
a. Set CoreOS config url in the UI
b. Boot the VM
Error: Config settings aren't applied (eg static IP)

Expected behavior
Config settings are applied.
Additional information
The VMWare instructions are confusing:

They recommend using vCloud Director which many people don't have.
The only other recommendation is to use the CLI which many people aren't familiar with.
Instead, it's very easy to set the properties from the VM management inferface GUI.

Also, it's not clear whether the namespace should be ignition or still coreos. The names of the properties are still CoreOS.

I just checked and this did not work on CoreOS Container Linux either I guess, because there is zero code in Ignition to support guestinfo.(ignition|coreos).config.url. I'll have a look whether this is easy to fix.
We currently aim at supporting both the coreos and ignition variable prefixes.

Great! Thanks for looking at this.

PR in https://github.com/flatcar-linux/ignition/pull/11

Just as hint: Downloading the Ignition config won't work if you don't use DHCP to assign IP addresses for the VMs because if you configure the static IP addresses via Ignition they are not applied yet in the initramfs. There is a way to use static IP addresses in the initramfs (https://coreos.com/ignition/docs/latest/network-configuration.html#using-static-ip-addresses-with-ignition) but that involves setting kernel command line parameters which are not configurable via guest variables. I haven't tried out if guestinfo.interface.0.ip.0.address works.

The recommended way is adding the kernel command line parameters by hand in GRUB at first boot which is not really nice (https://bugzilla.redhat.com/show_bug.cgi?id=1785122 and https://www.openshift.com/blog/openshift-4-2-vsphere-install-with-static-ips). Somebody else used iPXE for that (https://github.com/ralvares/ipxe)
I think it would be possible to support guestinfo.interface.0.name, guestinfo.interface.0.ip.0.address, guestinfo.interface.0.mac, guestinfo.interface.0.route.0.gateway, and guestinfo.dns.server.0 in Ignition by creating a temporary networkd unit.

That's very good to know, and I'll make a note of it in my own docs. So far, all my deployments have been on networks where DHCP is the default, and a static IP is being used to configure port forwarding to the VM. I'm sure I'll eventually encounter a situation without DHCP, but in that situation it's probably easiest just to use the encoded-data approach rather than trying to use a URL.

Now that the PR is merged, should we close this issue?

Hi,
it's just in Alpha but not in Stable yet. I would keep it open until then.


[camera][gameplay] Force-restart the position of the camera

this issue is currently on standby until we have time enough to work on details


Prompt plugin authors to add Swift Package Manager compatibility to their plugin

When detected that a flutter project is a plugin example app that has a podspec but doesn't have a Package.swift, prompt the user to add Swift Package Manager compatibility and point to documentation with instructions on how to do that.
https://github.com/flutter/flutter/blob/708fe97f9e3a0fd0c176305c5f63a506d6c78777/packages/flutter_tools/lib/src/plugins.dart#L392-L418
https://github.com/flutter/flutter/blob/708fe97f9e3a0fd0c176305c5f63a506d6c78777/packages/flutter_tools/lib/src/project.dart#L269
https://github.com/flutter/flutter/blob/708fe97f9e3a0fd0c176305c5f63a506d6c78777/packages/flutter_tools/lib/src/project.dart#L253-L257
https://github.com/flutter/flutter/blob/708fe97f9e3a0fd0c176305c5f63a506d6c78777/packages/flutter_tools/lib/src/project.dart#L263

I like it!
(Longer term, we'll want to more aggressively reach long-tail plugin developers by warning end users if they are using a plugin without SPM support, so that we can eventually remove Cocoapods, but that would be probably a couple of releases after SPM support is on stable.)


[stable/minio] Default bucket not created

Describe the bug
Setting defaultBucket.enabled to true but no bucket created. Setting an item under buckets does not help either.
Version of Helm and Kubernetes:
Helm: 2.14.3
Kubernetes: 1.15.0
Which chart:
stable/minio:2.5.15
How to reproduce it (as minimally and precisely as possible):
helm install stable/minio --set defaultBucket.enabled=true,defaultBucket.name=myBucket,defaultBucket.policy=none,defaultBucket.purge=false
Using buckets instead doesn't work better.
Anything else we need to know:

Sorry it was related the volume not being bound.


fix docs build

What are the issues this pull addresses (issue numbers / links)?
None
Did you add tests to cover your changes (yes/no)?
No
Did you update the documentation accordingly (yes/no)?
Yes
Did you read the CONTRIBUTING document (yes/no)?
Yes
Summary
Tutorials suddenly stopped building correctly.  Updating docs build process to correct this.

For testing, not meant for merging


Dynamically set the variations when split testing emails

Is there a way to dynamically provide the "subject line" variations.  My allows users to provide the variations at runtime.

@hraynaud can you give an example of what you're looking for? Not quite sure I understand.
An example of testing email subject lines is here: http://vanity.labnotes.org/email.html#subject.

@phillbaker Thanks for getting back to me. I believe this issue, #269 is more or less what I'm trying to achieve.   My application allows an administrator to create emails on-the-fly( using a normal html form) that goes out to users associated with their account.   I'd like to offer admins the ability to A/B test two subject lines when sending out emails.
As I understand the way vanity works I must hardcode the subject variations
ab_test "Invite subject" do
    description "Optimize invite subject line"
    alternatives "Join now!", "You're invited to an exclusive event."
    metrics :open
end

there is no way to do something like ...
ab_test "Invite subject" do
    description "Optimize invite subject line"
    alternatives AdminUser.find(1).subject_lines #pseudocode returning comma delim string.
    metrics :open
end

I hope this clarifies what I'm trying to do.
thanks


Support for custom headers?

In lettre 0.6.0, I found the following in the documentation:
builder.add_header(("X-Custom-Header", "my header"));
However, I've been working with the 0.10.0-beta versions, and can't seem to find equivalent functionality. Am I missing it, or is this capability planned for a future release?

Lettre 0.10 uses hyperx for the typed headers implementation, so what you're probably looking for is the hyperx::header macro. You can find example usage of it here: https://github.com/lettre/lettre/blob/2002a9d75a4f2be43835cfb1d4f9daaf9b20c1ea/src/message/header/content.rs#L10-L13


The value is not set for the parameter number 1.

Just installed 5.2.5 and now I get "The value is not set for the parameter number 1." on every database I try to connect to.  I was asked to select new MS SQL driveres during the install. Clicked download.
I don't appear to have any DB driver now for MS SQL.
I use

com.microsoft.sqlserver
sqljdbc4
4.0

to get the driver for other apps.
Fixed by falling back to 5,2.4

Duplicate of #4636 (see comments for workaround)


IDW fails to execute

This issue was imported from CodePlex
BenWiseman wrote 2014-12-01 at 07:59
As the title says - IDW reliably fails. Currently the error message I'm getting is:
Error: DotSpatial.Topology.KDTree.KeySizeException: The size of the key did not match the size of the tree.
at DotSpatial.Topology.KDTree.KdTree.Search(Double[] key) in g:\TeamCity\buildAgent\work\356b083ef9ef62c7\DotSpatial.Topology\Index\KDTree\KDTree.cs:line 118
at DotSpatial.Tools.InverseDistanceWeighting.Execute(IFeatureSet input, String zField, Double cellSize, Double power, NeighborhoodType neighborType, Int32 pointCount, Double distance, IRaster output, ICancelProgressHandler cancelProgressHandler) in g:\TeamCity\buildAgent\work\356b083ef9ef62c7\DotSpatial.Tools\InverseDistanceWeighting.cs:line
200
at DotSpatial.Tools.InverseDistanceWeighting.Execute(ICancelProgressHandler cancelProgressHandler) in g:\TeamCity\buildAgent\work\356b083ef9ef62c7\DotSpatial.Tools\InverseDistanceWeighting.cs:line 127
at DotSpatial.Controls.ToolManager.BwDoWork(Object sender, DoWorkEventArgs e) in g:\TeamCity\buildAgent\work\356b083ef9ef62c7\DotSpatial.Controls\ToolManager.cs:line 359

mbayles wrote 2015-06-09 at 20:42
Are you able to post your code or files you are using?

Closing it since there is no response much time.


Solve #4

closes #4

@rultor merge

@rultor merge

@l3r8yj Can't merge it. Some CI checks were failed. Apparently, the pull request is not ready to be merged since it has some problems. Please, fix them first.

@rultor merge

@rultor merge

@l3r8yj OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@l3r8yj Done! FYI, the full log is here (took me 1min)


[cf-d 13 part 2] [#172697662] Upgrade CF to v13.2

What
Upgrades CF to v13.2.0
UAA PRs
https://github.com/alphagov/paas-uaa/pull/19
https://github.com/alphagov/paas-uaa-release/pull/22
How to review

Deploy to your dev env
Update UAA WIP commit

Who can review
Not me

Running Lee's updates down my pipeline but looks fine
There haven't been any template changes to UAA AFAICT

One thought that just came to me
We are removing the adapter instances in the same release as we are upgrading, but the adapter instances are quite early on in the manifest.
This means the adapter instances will get removed early in the deployment process.
Do we want to separate this into two releases, one to do the upgrade, and one to remove adapter instances?

Based on the data It seems sensible to seperate them.

Actually, we need that commit in this PR to get the manifest to render.
The adapter instances are removed in the cf-deployment manifest, which doesn't seem to provide a path to a deployment without interruption to log delivery. I guess our only choice is to do it in one release, but with a maintenance window?

Before we merge this, we need to remove the separator commit and those preceding it.
Also https://github.com/alphagov/paas-cf/pull/2334 should be deployed before this is merged


Kinesis Elasticsearch Sink: add support for Elasticsearch 5.x

https://aws.amazon.com/about-aws/whats-new/2017/01/elasticsearch-5-now-available-on-amazon-elasticsearch-service/
We need a third build target to support this to be sure that there will be no complications.

At this point the 2.x sinks do work with a 5.x sink but it would be good to get this properly tested and to use the latests libs supporting this.

@jbeemster are you saying I can give the 2.x sink a shot with an elasticsearch 5.x cluster? Not for production, but it should sort of work? Clarifying because either you mistyped ('2.x sinks do work with a 5.x sink') or I don't get what you mean.

Ahh yes I meant a 5.x cluster.  We do actually are using this in production now without any issues.

Just FYI - couldn't make the 0.8 2.x sink work with an es 5.2.2 cluster - don't have the exact error at hand now, but it failed to find an es node at the given endpoint. It worked when I downgraded that exact endpoint to 2.4.4 and ran it with the exact same configuration file.

Using the transport or http client @gincor ?

transport. I'm almost sure I tried it once or twice with http as well, but not 100%.

migrated to: snowplow/snowplow-elasticsearch-loader#10


clarify how to categorize <20 yr old forests following severe disturbance of forest or unknown land use

my message to Valentyna;
Following up on your answer to question 1, my understanding is that if a forest undergoes severe disturbance (e.g., clear-cut logging, severe fire), the regrowth stands would be considered FF. Is that correct? In the case I described (stand age <20 and the former land use is not recorded in ForC), these could have been severe disturbance to forest land, so it seems LF might not be appropriate? Should these just be classified as Forest Land? Of should we set them aside to look up?

(These cases can be avoided in the first data delivery.)

from V:
You are right, in case previous land use for young forest (<20 yr.) is not known, this area could be affected by severe disturbances. Then, please classify it as FF. If the info on the disturbances is available to be input into the EFDB form, it is good to include.

There are no cases of this in the first data delivery, but we'll eventually need to deal with this.

@teixeirak, I am concerned that the issue is more complicated as I am realizing now that I have not touched the script creating PLOTS in a very long time and it maybe obsolete.... I think it was made to deal with the previous PLOTS version, manually made, so I don't think it is actually filling some of the columns based on HISTORY but based on what is already in PLOTS.....
That is not good.
So for now, I think it is best to manually edit at time of approval.


[TC-441] - hooks up password reset to TP

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/46/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/44/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/84/


Fix spacing issue with our prettier settings

It seems like there is a problem with the prettier configuration: #4

Hi, I just found this issue! I was actually wondering where the printWidth: 5000 option came from. Was that added intentionally, or was the .prettierrc copied from a different project? I'm really curious to know why 5,000 was chosen for this setting. Thanks!

https://prettier.io/docs/en/options.html#print-width

For readability we recommend against using more than 80 characters:
In code styleguides, maximum line length rules are often set to 100 or 120. However, when humans write code, they don't strive to reach the maximum number of columns on every line. Developers often use whitespace to break up long lines for readability. In practice, the average line length often ends up well below the maximum.
Prettier, on the other hand, strives to fit the most code into every line. With the print width set to 120, prettier may produce overly compact, or otherwise undesirable code.
See the print width rationale for more information.

Merged #19 to set the print-width to 80. However, this was not the problem of this issue.
This issue is about investigating why cj had whitespaces added to every lines of his PR when using this repo toolings. Than being said, you didn't seem to have those issues or your PR @ndbroadbent.

@patricklafrance Oh I see, yes I did actually have that as well. I had to manually select the relevant changes. This can be solved by running Prettier on all the files and then committing the whitespace/formatting changes. I can do that now and send another PR

Oh actually this was a line-ending issue. The codebase has CRLF line endings (\r\n), and Prettier is formatting files with LF line endings (\n). So I think is actually a Windows vs. Mac/Linux issue.
I found some Prettier issues about that:

#92 - Prettier change all line break to LF
#5320 - An option to enforce certain line endings (LF / CRLF)
#537 - https://github.com/prettier/prettier/issues/537

This is very confusing.
This comment doesn't seem to be true anymore:

@cphoover prettier will respect the first end of line it sees. If it's a \r\n it's going to replace all the others with \r\n and same for \n.

Because I just ran prettier --write **/*.js, and it replaced all the line endings. I will open another issue on Prettier.
In the meantime, maybe you could add the suggestion from #5320 to the contributing instructions in the README:

Run git config --global core.autocrlf true to use CRLF line endings

I just ran:
$ git config --global core.autocrlf true
$ prettier --write **/*.js

And now Prettier is using the correct line endings.
(I think most JavaScript developers use LF line endings. But up to you!)

Also I forgot to respond to your comment about the width:

It's intentional, since we have pretty large screens at Sharegate I usually prefer a high width instead of taking more spaces top to bottom.

That's fine for me as well! I wouldn't mind if you wanted to set printWidth to something like 100 or 150. But setting it to 5,000 caused the formatting problems, because Prettier will never print code on multiple lines if it can all fit on a single line.

Fix with the following commit https://github.com/sharegate/craco/commit/3e709c6ebdc308e99e01b963732a43e29fddfb79
In short:

Added a few tools to enforce CRLF
Added ESLint linebreak-style
Added husky + lint-staged to run prettier when files are staged
prettier should read .editorconfig "end_of_line" key  in the next release: https://github.com/prettier/prettier/pull/5327

Prettier should already read "end_of_line" in .editorconfig since 1.15.0.

@patricklafrance Awesome, thanks! This should make it much easier for other people to start contributing. I also prefer the 120 chars printWidth, that looks better on my screen as well.

@lydell according to this PR https://github.com/prettier/prettier/pull/5327 it was merged 7 days ago.
I haven't test it thought.

@lydell I should have read the release notes of 1.15.0, you're right the PR made it to 1.15.0!


[AIRFLOW-1057] fixed class name that is changed at docker package version 2.0.0

Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[X] My PR addresses the following AIRFLOW-1057

Description

[X] Here are some details about my PR, including screenshots of any UI changes:
This fixes a wrong reference to a class in the docker package

Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason: just a name change

Commits

[X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Thanks for the contribution. Please follow the commit guidelines. Also, is this backward compatible?

I have now improved the import to cater for those people that use docker-py prior to 2.0.0. It will now first try to import APIClient, but if that fails it imports Client as APIClient.

I've checked this pr it seems ok to me.
Maybe changing the require to be able to install either the docker-py (v1.xx) or docker (v2.xx) would be a good add.

I am not familiar with the docker-py package. The package on pypi has not been updated since November 2016 and the documentation of that package seems to point to the docker package documentation (https://docker-py.readthedocs.io/en/latest/)
I have manually installed the docker package and did not rely on dependencies from setup.py. That's how I found out.
Can someone shed a light on the difference between these two packages?

They are basically the same package. Prior to version 2.x it was called docker-py, and since version 2 they switched to docker.
They actually have issues open on their project to make it more explicit because it's been causing a lot of confusion.

Ok. I'll make the dependency such that it checks if either docker-py or docker is installed. Installing the docker dependency (in setup.py) will pull down the docker package.

ok -- I know where to change the docker package dependency: line 125 of setup.py. Changing that to docker = ['docker>=2.0.0'] will get us install the package docker.
But I am not sure how to validate if docker-py may be installed and rely on that version. I am new to python packaging.

I'm not sure if it's considered good practice, but you can import it in a try except and if it's present it won't throw.

that is now the way I do it. the import tries to import docker and use the APIClient class. If that fails it imports docker and use the class Client as APIClient.
I have also changed the dependency on the docker module rather than docker-py

Codecov Report

Merging #2204 into master will increase coverage by 1.39%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2204      +/-   ##
==========================================
+ Coverage    67.5%   68.89%   +1.39%
==========================================
  Files         142      142
  Lines       10845    10931      +86
==========================================
+ Hits         7321     7531     +210
+ Misses       3524     3400     -124

Impacted Files
Coverage Δ

airflow/operators/docker_operator.py
97.5% <100%> (+0.13%)
:arrow_up:

airflow/utils/state.py
86.66% <0%> (-13.34%)
:arrow_down:

airflow/www/api/experimental/endpoints.py
86.95% <0%> (-9.72%)
:arrow_down:

airflow/bin/cli.py
51.84% <0%> (-1.35%)
:arrow_down:

airflow/operators/sensors.py
67.13% <0%> (-0.36%)
:arrow_down:

airflow/operators/redshift_to_s3_operator.py
0% <0%> (ø)
:arrow_up:

airflow/executors/celery_executor.py
0% <0%> (ø)
:arrow_up:

airflow/hooks/__init__.py
58.82% <0%> (ø)
:arrow_up:

airflow/www/views.py
68.02% <0%> (+0.23%)
:arrow_up:

airflow/models.py
87.27% <0%> (+0.35%)
:arrow_up:

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b55f41f...f22044e. Read the comment docs.

updated the test so is does the same check on which docker package is installed.
I think this is now good to go?

please squash your commits, make sure you follow the commit guidelines for the commit message and then we are good to go.

I think this is now in line with the guidelines -- anything I missed?

I think you are missing

commits all reference JIRA issues in their subject lines

so something like [AIRFLOW-1057] fixed class name that is changed at docker package version 2.0.0

I think it already does have a subject line that is exactly that. Do you mean something else, @avigil-twist ?

you changed the name of this pull request but not the name of the commit itself

got it, @avigil-twist and fixed that now

This PR never got merged as far as I can tell, but the associated issue is marked as RESOLVED https://issues.apache.org/jira/browse/AIRFLOW-1057... is it actually RESOLVED?

Well, @russellpierce, I must say I am note entirely sure either. I have been using my fork for most of the time. I'll check.

Just had a quick look at the code (current master branch https://github.com/apache/incubator-airflow/blob/master/airflow/operators/docker_operator.py) but there we just import Client from docker. So nothing has changed there. I doubt whether this has been fixed then -- this still requires the docker module version < 2.0 to be installed...

Has this stalled again or will it make it to 2.0?

@brokenjacobs This first needs to be fixed; there are a lot of merge conflicts right now.

This PR can be closed. It was fixed on https://github.com/apache/incubator-airflow/pull/3407


Unrecognized option error

Hi,
I'm getting an urecognized option error.
Spark assembly has been built with Hive, including Datanucleus jars on classpath
Error: Unrecognized option '--profile'.
It seems the options aren't being passed to the Main class, instead they are being passed to the Spark submit as arguments.
Have you noticed this before? I'm sure I'm doing something completely boneheaded here.
My profile file looks like :
import os
c = get_config()
SPARK_HOME = os.environ['SPARK_HOME']
MASTER = 'yarn'
c.KernelManager.kernel_cmd = [SPARK_HOME+"/bin/spark-submit",
"--master", MASTER,
"--executor-memory", "2G",
"--class", "org.tribbloid.ispark.Main",
"--jars", "/ISpark/core/target/ispark-core-0.2.0-SNAPSHOT",
"--profile", "{connection_file}",
"--interp", "Spark",
"--parent"]
c.NotebookApp.ip = '<IP_ADDRESS>'
c.NotebookApp.open_browser = False
c.NotebookApp.port = 8888

The only problem I see so far is the outdated --interp option.
This is the profile I'm using and it is functioning properly
c.KernelManager.kernel_cmd = [SPARK_HOME+"/bin/spark-submit",
"--master", MASTER,
"--class", "org.tribbloid.ispark.Main",
"--executor-memory", "2G",
"--jars", GIT_HOME+"/ISpark-server/core/target/scala-2.10/ispark-core-assembly-0.2.0-SNAPSHOT.jar",
"--profile", "{connection_file}",
"--parent"]

hey buddy can you confirm that your environment can run it? I think this is no longer a problem and should be closed in 2 weeks

Hi,
I upgraded to ipython 3 and I don't face the same issue now. I now get:
Exception in thread "main" java.lang.NoClassDefFoundError: play/api/libs/json/Reads
probably a missing dependency. I'll try and see if I can figure it out tomorrow.
Thank you for following up.

Interesting, another guy reports the same error on ipython2, he was using Spark on Scala 2.11, after switching back to 2.10 the error vanished.
I'm afraid I still need some time to port it to Scala 2.11 at the moment. Their REPLs are very different

Thanks for the tip. Searching through the other issue I found that you had pre-built the jars. Using the release jar worked. Closing this issue.

I removed Scala 2.11 but I still faced the same issue with the jars I try and build myself.
[WARNING]  org.scalatest:scalatest_2.10:2.2.4 requires scala version: 2.10.4
[WARNING]  org.scala-lang:scala-reflect:2.10.4 requires scala version: 2.10.4
[WARNING]  com.twitter:chill_2.10:0.5.0 requires scala version: 2.10.4
[WARNING]  org.spark-project.akka:akka-remote_2.10:2.3.4-spark requires scala version: 2.10.4
[WARNING]  org.spark-project.akka:akka-actor_2.10:2.3.4-spark requires scala version: 2.10.4
[WARNING]  org.spark-project.akka:akka-slf4j_2.10:2.3.4-spark requires scala version: 2.10.4
[WARNING]  org.apache.spark:spark-core_2.10:1.3.1 requires scala version: 2.10.4
[WARNING]  org.json4s:json4s-jackson_2.10:3.2.10 requires scala version: 2.10.0

Are these just warnings? You can safely ignore those, all minor versions are compatible with each others

during the build phase I get these warnings but when I try and use the built jar I get the same error as earlier
Exception in thread "main" java.lang.NoClassDefFoundError: play/api/libs/json/Reads

I was using the wrong jar similar to #5


adding encrypt command

Description
Add a description of your changes here.
Is this PR related with an open issue?
Related to Issue #
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] Follows the code style of this project.
[ ] Tests Cover Changes
[ ] Documentation

@mrsmkl , can you confirm if comments were addressed please?

Looks like there's still some debugging left with tests, I'll work on it tomorrow


Dev server don't autodiscover new routes

Describe the bug
If the dev server is running, SvelteKit don't see newly added routes, and result in 404 when navigating to them.
Reproduction

Create a new project (npm init svelte@next my-app + select the Skeleton project, should also be true for demo app)
Install the project (npm install)
Start the dev server (npm run dev)
Add a new page in src/routes (ex: src/routes/test.svelte)
Try to navigate to the route (with the previous example: http://localhost:3000/test)

Logs
// Server console side
09:50:09 [vite] page reload .svelte-kit/dev/generated/manifest.js

// Browser side
404
Not found: /test
Error: Not found: /test
    at render_page (file:///private/tmp/sk/my-app/node_modules/@sveltejs/kit/dist/ssr.js:1318:11)
    at async resolve (file:///private/tmp/sk/my-app/node_modules/@sveltejs/kit/dist/ssr.js:1663:12)
    at async respond (file:///private/tmp/sk/my-app/node_modules/@sveltejs/kit/dist/ssr.js:1614:10)
    at async Immediate.<anonymous> (file:///private/tmp/sk/my-app/node_modules/@sveltejs/kit/dist/chunks/index.js:3458:22)

System Info
System:
    OS: macOS 10.15.7
    CPU: (8) x64 Intel(R) Core(TM) i5-8279U CPU @ 2.40GHz
    Memory: 78.90 MB / 8.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 14.16.1 - /opt/local/bin/node
    Yarn: 1.22.10 - /opt/local/bin/yarn
    npm: 6.14.8 - /opt/local/bin/npm
  Browsers:
    Safari: 14.1.2
  npmPackages:
    @sveltejs/kit: next => 1.0.0-next.139
    svelte: ^3.34.0 => 3.41.0

Severity
serious, but I can work around it
Additional Information
The file .svelte-kit/dev/generated/manifest.js is correctly generated.
But SvelteKit don't seem to reload it (it is only load at here: .svelte-kit//dev/runtime/internal/start.js)
A simple workaround is to stop and restart server every times a new route is created, in DX point of view it's not ideal

Initial Discord message: https://discord.com/channels/457912077277855764/819723698415599626/870925145554952222

I have been, having the same issue. I have tried to downgrade the version but to no avail.

Same issue.

I've had a similar issue, but only when refreshing the page manually or entering the url. Links to the new page/resource seem to work as expected.

same here, seems to be more so for server endpoints consistently
am using Typescript in case that is the common denominator (if maybe other people don't have the issue)

Same here.
Changes to existing routes work fine, and are rendered near instantly, but if I add a new route file it isn't detected and gives a 404 error.
If I exit the dev server and reload it picks up the changes. This occurs with both the Demo and Skeleton projects.
I've search around a bit and tried adding some vite specific changes to set usePolling to true, but to no effect.


Make components headless for Markdown component

Description
Migrate styles from components to themes.
Since component styles in themes inherit styles from other components using mergeStyle etc., duplicate styles should be removed.
Problem Statement/Justification
Move static styles from markdown component to theme.
Proposed Solution or API
No response
Alternatives
No response
Are you willing to participate in implementing this feature and create a pull request include the implementation?
Yes
Additional Information
No response

Closed due to no migration required.


Feature/general shopping list

Hi @Ellon-M  👋
The following milestones were implemented in this PR

[ ] General shopping list view

Should show the list of food that is missing for all recipes of the logged-in user (compare the list of food for all recipes with the general food list of that user)
Should count the total food items and total price of the missing food.

APPROVED! 🏆
Hi @willy836  👋
Your project is complete ✔
There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏


Updated hello-world to the new style of exercise

Removed string manipulation from hello-world exercise to be inline with the new style of hello-world exercise across the site as discussed in #110
Edited model answer, tests and unimplemented answer

I'll pick this up once #110 is resolved 👍

I will be able to get to this on Sunday!

Great, thanks @Nik-Mouz! LGTM 🚢

Was it intended to remove all the info about un-@Ignore-ing tests here?

Yes, though the intent was to bring that information back in a similar place to that used by the Java track now, but that second part never happened.


Rule proposal: Layout rule - Blank line required after contract

For readability, code contracts should be separated from member code with a blank line.
Prefer
    private String GenerateCacheKey()
    {
        Contract.Ensures(String.IsNullOrWhiteSpace(Contract.Result<String>()) == false);

        String handlerTypeName = GetType().AssemblyQualifiedName;
        String proxyTypeName = typeof(T).AssemblyQualifiedName;

        return handlerTypeName + "|" + proxyTypeName;
    }

compared to
    private String GenerateCacheKey()
    {
        Contract.Ensures(String.IsNullOrWhiteSpace(Contract.Result<String>()) == false);
        String handlerTypeName = GetType().AssemblyQualifiedName;
        String proxyTypeName = typeof(T).AssemblyQualifiedName;

        return handlerTypeName + "|" + proxyTypeName;
    }

Originally proposed by rprimrose http://stylecop.codeplex.com/workitem/7088
follow up discussion:
andyr wrote Sep 20, 2011 at 12:39 PM
Approved.

I like it

I'm leaning no, primarily because of its limited overall applicability. It only covers Code Contracts, and not other types of argument validation that have a similar form.

This would also have to made more specific, as the example only shows preconditions. How would object invariants and postconditions be handled? Would they need a blank line before (post conditions) or blank lines around (object invariant)?
While I do see merit in a clear separation, too much is unclear for me at the moment for a final vote.
I would also prefer if such a rule would also handle Debug.Assert precondition checks and may be there are more.

:-1: I do this. However, Contracts are an optional extension, not part of C#. They are discussing adding contracts as a new language thing in C# version 7. https://github.com/dotnet/roslyn/issues/119 If and when it becomes a part of the language, then I think we add this.
It would be perfectly fine to create a separate analyzer for Contracts. There are other Contract rules that I use that I just don't think belong as part of StyleCop.


Updated SERVER_KEY_CREDENTIALS_ID

It was misspelled

When using the Jenkinsfile I found that SERVER_KEY_CREDENTIALS_ID was misspelled and the build failed


sap.m.Wizard event parameter "stepActivate"

OpenUI5 version: any / 1.108
Browser/version (+device/version):
Independend of browser
URL (minimal example if possible):
https://github.com/SAP/openui5/blob/6bffee7df9330780c58604523421413501bda5e0/src/sap.m/src/sap/m/Wizard.js#L917C3-L922C1
Steps to reproduce the problem: 1. 2. 3.
Register on Event "stepActivate" and try to acces the step which is activated now without usage of private attributes
What is the expected result?
Have a nice parameter in the evnt to easily react on the event
What happens instead?
a 1 based index (1 based untypical in JS only common in ABAP) no method/array to use this index
Any other information? (attach screenshot if possible)
The event "stepActivate" gives only the parameter "stepIndex".
As you can see in the coding of the internal handling of this event, this index is only valid on the internal array _aSteps as we only get an index not an ID.
As user of this event I don't get what i should do (in branching case) with this index as I don't see an option to access the step which is currently activated.
Regrads
lhendrik

Hi @lhendrik ,
maybe you are confusing private handler "_handleStepActivated", with the execution of the stepActivated event handler.
On triggering the event you have "index" property, which shows exactly which step is activated.
I have created example for you of the usage of this event here.
I hope that is helpful.
Best regards,
Petya Markova.
(UI5 Developer)

Hi @PetyaMarkovaBogdanova ,
thanks for the quick response, yes I get the index which is a bit useful in normal case but in branching case it does not give usefull stuff. I added a simple example with branching case in your manner (only changing the title, which is just a simple example).
In my use case I want to access the step which is activated.
I added the coding for that, can you give a good advise for the branching case?
Thanks
lhendrik

Hi again, @lhendrik ,
I didn't quite understand where the sample, that you provided, is?
Maybe you can use the steps aggregation like this "oEvent.getSource().getSteps()[oEvent.getParameter("index") - 1]"?
If I still cannot help you, I will forward your question to the team owner of the control to try to.
Best regards,
Petya Markova.
(UI5 Developer)

Hi @PetyaMarkovaBogdanova,
thanks for the quick reaction. My example is just below yours in the same JS bin: here and the branching case is just below your wizard. (i decreased the size of the first wizard to make the second one easier to access or just scroll down in the output).
Yes, i did something similar what you proposed, this works somehow for the normal case but not for the branching case.
See alos the confusing title change for the branching case.
Regards,
lhendrik

Hello @lhendrik ,
I've created an internal incident 17674 to the responsible team. The status of the issue will be updated here in GitHub.
Regards,
Petya Markova.
(UI5 Developer)

Hi @lhendrik ,
If I call  sap.ui.getCore().byId("__xmlview0--Wizard2").getSteps()[oEvent.getParameter("index")] inside onStepActivate2 in the JSBin your provided the correct step is being returned (the activated one) which is "Step 3" in your example. Branching works as expected as you have defined that nextStep="Step2_3" in your first step - the same step which is returned in the event.

Yes, i did something similar what you proposed, this works somehow for the normal case but not for the branching case.

As explained above it actually works for branching - index 2 is returned which corresponds to "Step2_3" in the steps array (remember that the arrays is JS are zero based, so indexes start from 0).

See alos the confusing title change for the branching case

The confusing title change is because you pass oEvent.getParameter("index") to the title string and as I explained above the "2" for the index stands for the step which is on index 2 (which is the third step in the array), not for the second step in the array.
From my analysis everything works as expected here.
If there is something else that we are missing, please describe it and reopen the issue.
Kind Regards,
Elena

Hi @elenastoyanovaa ,
thanks for your quick response and your suggestions. I provided another example, may this can clarify my problems. The aim: Add an element to the step which was activated (onStepActivate). In this example a simple Text is added, if the WizardStep stays empty it is not working as requested.
Please have a look to this example
I provided three cases which can be accessed via the SegmentedButton on the top of the wizards (1. normal, 2. Branching).
a) Index:               oWizard.getSteps()[oEvent.getParameter("index")]
b) Index-1:            oWizard.getSteps()[oEvent.getParameter("index") - 1]
c) Private Index-1: oWizard._aStepPath[oEvent.getParameter("index") - 1]
As you and the documentation mentioned: The index from the event is 1 based. (Arrays in JS are 0 based).
a) is neither working for Normal or Branching case
b) is working for normal case but not for branching case (as the index from the event doesn't fit to oWizard.getSteps()
c) is working for normal and branching case (using private attribute _aStepPath 8similar to the standard implementation mentioned in the first post/issue)
My problem is: i want to manipulate (here add elements) the activated step without accessing private attributes.
May i don't see the solution, do you have any suggestions?
Regrads,
lhendrik

Hi @flovogt ,
i can't see an option to reopen the issue, can you do it again?
Regards,
lhendrik

Hello colleagues,
Could you check the last reply from the reporter as I am not able to understand what is the exact issue?
Kind Regards,
Elena

@lhendrik I had another look at the API docs of sap/m/Wizard.
There is the method getProgressStep() which returns the current active step.
So, this works for me:
 onStepActivate(oEvent) {
   const oWizard = oEvent.getSource();
   const oActiveStep = oWizard.getProgressStep();
   // do whatever you wanna do with the current step
}

This should solve your requirement, isn't?

Hi,
thanks for the suggestion, "getProgressStep" solves my requirement, as it internally does what i need (accessing _aSteps with index -1)[https://github.com/SAP/openui5/blob/48bad639ed25c30810a7ee0bf54d4865e01c5bd7/src/sap.m/src/sap/m/Wizard.js#L451-L453].
I didn't investigated this method as i was fixed on the event parameter (index) and searched for a method to get the step by the index give as event parameter.
Many thanks for your help @elenastoyanovaa @flovogt .
For clarification, therer is a difference between "currentStep" and "progressStepp". In the event "stepActivate" currentStep seem to be the old step and "progressStep" the new one (currently activated):
getCurrentStep
ID of the element which is the current target of the association currentStep, or null.
getProgress
Returns the number of the last activated step in the Wizard.
getProgressStep
Returns the last activated step in the Wizard.
Maybe, the event parameter is a bit confusing, as it is just named index. It seems to deliver the same as the methods "getProgress" and "getProgressStep". Maybe the documentation could be enhanced, making clear that the index from the event is the progress.
Regards,
lhendrik

@elenastoyanovaa could you please have a look at the documentation of the index property in the stepActivate event?
@lhendrik I'll close this issue here. Happy to solve your requirement.


Headliner automation

[ ] convert one episode to Youtube

Nice to have

[ ] Add youtube automation for episodes

can't be done : need to upgrade plan


Keras tensorboard showing nothing but the code runs well

I am using tensorflow 1.0.1 keras 2.0 and python 3.4
When I run my code, it shows no error. However tensorboard show that "No graph definition files were found. "
My tensorboard debug is as follows:
INFO:tensorflow:TensorBoard is in debug mode.
INFO:tensorflow:Starting TensorBoard in directory /home/swx/lk
INFO:tensorflow:TensorBoard path_to_run is: {'/home/swx/lk/=': None}
INFO:tensorflow:Event Multiplexer initializing.
INFO:tensorflow:Event Multiplexer done initializing
INFO:tensorflow:TensorBoard reload process beginning
INFO:tensorflow:Starting AddRunsFromDirectory: /home/swx/lk/=
INFO:tensorflow:Done with AddRunsFromDirectory: /home/swx/lk/=
INFO:tensorflow:TensorBoard reload process: Reload the whole Multiplexer
INFO:tensorflow:Beginning EventMultiplexer.Reload()
INFO:tensorflow:Finished with EventMultiplexer.Reload()
INFO:tensorflow:TensorBoard done reloading. Load took 0.002 secs
INFO:tensorflow:TensorBoard is tag: b'41'
can any one offer some help?
Please make sure that the boxes below are checked before you submit your issue. If your issue is an implementation question, please ask your question on StackOverflow or join the Keras Slack channel and ask there instead of filing a GitHub issue.
Thank you!

[ ] Check that you are up-to-date with the master branch of Keras. You can update with:
pip install git+git://github.com/fchollet/keras.git --upgrade --no-deps

[ ] If running on TensorFlow, check that you are up-to-date with the latest version. The installation instructions can be found here.

[ ] If running on Theano, check that you are up-to-date with the master branch of Theano. You can update with:
pip install git+git://github.com/Theano/Theano.git --upgrade --no-deps

[ ] Provide a link to a GitHub Gist of a Python script that can reproduce your issue (or just copy the script here if it is short).

I had a similar issue.  Mine was resolved by directing the tensorboard callback to save the logs on a local drive instead of the network drive I had been using.  Then it worked fine.  For some reason, Tensorboard cannot access a network location (at least in Windows).  Are you using a network location?

I have the same problem and I'm using a local drive in windows
http://stackoverflow.com/questions/43709728/keras-not-writing-tensorboard-callback


Manage SSL for PostgreSQL

Hello! We are doing some house keeping and noticed that this issue has been open for a long time.
We're going to close it but please do raise another issue if the issue still persists. 😄


nctl/nightly-tests: several script fixes for parsing blocks

Several script changes to support some NCTL functions with feat-2.0.

bors r+

bors merge

bors single on

bors merge p=1


feat(core): report supported features

Mayastor now reports the set of supported features and its version via
gRPC call.
Fixes CAS-972

bors r+


Exit the developer run script immediately if no scene files were found.

Example incorrect usage:
python3 scripts/run_passive_scenes.py --mcs_unity_build_file ~/Development/darpa/ai2thor/unity/MCS-AI2-THOR-Unity-App-v0.4.4.x86_64 docs/source/scenes/agents_preference_expected.json
Loaded provided logging config dictionary
Found 0 files matching docs/source/scenes/agents_preference_expected.json*_debug.json
No matching files found... trying non-debug files
Found 0 files matching docs/source/scenes/agents_preference_expected.json*.json
No matching files found... Exiting

Example correct usage:
python3 scripts/run_passive_scenes.py --mcs_unity_build_file ~/Development/darpa/ai2thor/unity/MCS-AI2-THOR-Unity-App-v0.4.4.x86_64 docs/source/scenes/agents_preference_
Loaded provided logging config dictionary
Found 0 files matching docs/source/scenes/agents_preference_*_debug.json
No matching files found... trying non-debug files
Found 2 files matching docs/source/scenes/agents_preference_*.json
========================================

(etc.)

@brianpippin

when we want to use one or the other

This is a good question, and Rachel and I were actually talking about it on Teams yesterday too. My opinion is that you should use prints for critical error messages that you want to be sure are always seen (since you can disable log messages), and loggers for everything else. This seemed like the former, which is why I went with prints.

Personal preferences aside
https://docs.quantifiedcode.com/python-anti-patterns/readability/putting_type_information_in_a_variable_name.html

Not all anti-patterns are meant to be applied universally, and I disagree with that particular one in some cases. I've worked on software in which we've defined dicts, lists, numpy arrays, and pandas dataframes, and pass them around to lots of different functions. It can be very confusing figuring out which variables are which type without some sort of reference information, like the variable name. (Also, that page seems to recommend using single-letter variable names, which I see as an anti-pattern in itself, outside from for-loop index variables.)
Now, that being said, we've started doing a much better job using type hints throughout our code, which can provide the needed reference information, as long as we remain diligent with the type hinting. I've updated this script to add more type hints and rename filename_list as you requested.


404 Error on sign-in

🐞 Describe the bug
When I try use the sign in button on the ackee login page I get the following error (my server's domain is replaced with example.com in the info below)

<title>404 Not Found</title>

404 Not Found

nginx/1.14.0 (Ubuntu)

Error:
<title>404 Not Found</title>

404 Not Found

nginx/1.14.0 (Ubuntu)

    at Md (https://example.com/ackee/index.js:83:13349)
    at async https://example.com/ackee/index.js:83:13926

This error occurs up no what username/password is typed.
📚 To Reproduce
I setup and installed using the instructions at:
https://docs.ackee.electerious.com/#/docs/Get started#without-docker
I have a reverse proxy that forwards requests from example.com/ackee/ to the ackee app running on localhost:3000.
I suspect this might be a problem with my reverse proxy. But as Ackee suggested checking here I though I'd try that to get an opinion.
💡 Expected behavior
Login to dashboard or error on wrong username/password
🖼 Screenshots

⚙ Environment

Installation: Manually
Ackee version: 3.0.5

📋 Additional context
MongoDB works OK, as i can access its console.
I did receive a warning when using yarn to update dependencies.

yarn install v1.22.10
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[4/5] Linking dependencies...
warning "graphql-tools ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>|| ~3.3.0".
[5/5] Building fresh packages...
Done in 94.91s.

on starting the app with yarn start I do get another warning:

[Ackee] › …  awaiting  Building and writing 'dist/index.html'
[Ackee] › ✔  success   Finished building 'dist/index.html'
><EMAIL_ADDRESS>server
> node src/index.js
[Ackee] › …  awaiting  Connecting to mongodb://localhost:27017/ackee
(node:1977) Warning: Accessing non-existent property 'MongoError' of module exports inside circular dependency
(Use node --trace-warnings ... to show where the warning was created)
(node:1977) DeprecationWarning: Listening to events on the Db class has been deprecated and will be removed in the next major version.
[Ackee] › ✔  success   Connected to mongodb://localhost:27017/ackee
[Ackee] › ▶  start     Starting the server
[Ackee] › …  watching  Listening on http://localhost:3000

nginx's logs report the following (1st line on acess, second line when hitting sign in

<IP_ADDRESS> - - [14/Mar/2021:16:00:17 +0000] "GET /ackee/favicon.ico HTTP/1.1" 200 52852 "https://example.com/ackee/" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.86 Safari/537.36"
<IP_ADDRESS> - - [14/Mar/2021:16:01:25 +0000] "POST /api HTTP/1.1" 404 209 "https://example.com/ackee/" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.86 Safari/537.36"

Thanks a lot for any suggestions!

My guess is that Ackee tries to call the API via example.com/api/ instead of using example.com/ackee/api. I've only ever used it via a sub-domain.


New version! 2.18.0

Version 2.18.0 has been released. This is the last version in the 2.x series before QGIS 3.0 is released in Q1 2017.
Visual changelog: http://changelog.qgis.org/en/qgis/version/2.18.0/

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


[BUG] Brief 404 page error in daff.io/docs when clicking on links

:bug: Bug report
Current Behavior
Clicking on links that direct to another page in docs causes a brief 404 error. This doesn't happen when navigating around in the tree itself, only when a link is clicked.
https://www.loom.com/share/90a5f8aee38944d1afc40398049f5bc6?sid=88aac3ca-b307-4861-a028-ba25a9fea244
Expected Behavior
Clicking on a link that routes to an actual page should not display a 404 error page.
Minimal reproduction of the problem with instructions

Go to /docs/packages/design or /docs/packages/forms
Click on any of the links

What is the motivation / use case for changing the behavior?

Environment

Daffodil version: X.Y.Z
Angular version: X.Y.Z

For Tooling issues:
- Node version: XX
- Platform:

Others:

@xelaint I have seen this locally due to messed up local server docs path config. Have you seen this in prod or just locally?

Just locally. It doesn't happen in next.daff.io


Feature to delete all layers from the edit toolbar

To deletes all drawn features from the "deletableLayers" so the user don't have to click on every feature.
Tests are added to the "EditSpec".

@boeckMt @ddproxy Could you release it?


KOGITO-8445: SWF Diagram Viewer - Orthogonal lines

Hey @romartin;
Could you please review this PR?
JIRA: KOGITO-8445
Thanks!

THanks @LuboTerifaj for great review and feedback! I will let @handreyrc to asnwer your comment above, he's going to fix the issue and report others in a ticket for improvements. Also @handreyrc added new integration tests about control points, which is great, thanks @handreyrc !

Hey @LuboTerifaj and @romartin,
I went through all the points you raised. I agree we still have improvents to be done.
Anyway it's a lot of work to be done in a single PR so I created a new JIRA for them.
WDYT?
Please feel free to add more points you find relevant to be addressed.
JIRA: KOGITO-86810
About the errors presented in the diagram.
One can route to End state from state's declaration and from transition's declaration as well. Only the first case was covered before. I implemented the End node creation from transitions so it is fixed.
BTW I also added IT tests for the control points created by the orthogonal lines.
We are ready for a sencond round!
Thank you guys for looking into it!

Hello @handreyrc ,
I am not sure which issues did you fix, and which are you suggesting to implement in a separate jira.
Could you please clarify it to me?
Please don't report jiras with the issues the reviewer found until we agree on fixing them in separate PR.
Thanks!

Hey @LuboTerifaj,
I fixed only the two items you mentioned there are errors in the diagram.
There is an error in diagram.
Error Message: "Transition from $STATE_NAME has invalid target."
The end node is not shown in the diagram.
It happens if there is "end": true specified in dataConditions, defualtconditions, eventConditions, or onErrors
See book-lending.sw.json, car-vitals-checks-parent.sw.json, filling-a-glass-of-water.sw.json, new-patient-onboarding.sw.json from specification
See currency-exchange-workflow.sw.json, resources/handle-frontend.sw.json, handle-backend.sw.json, callback.sw.json from kogito-examples
There is an error in diagram.
Error Message: "Transition from $STATE_NAME has invalid target."
The end node is not shown in the diagram.
It happens if there is "terminate": true used in workflow.
See loanbroker.sw.json from kogito-examples
Thanks!

Great, thanks @LuboTerifaj for your great work and collaboration here!


Chef 15: Unable to create temp dir on windows system

Signed-off-by: Vivek Singh<EMAIL_ADDRESS>
Description
Windows Powershell command to create temp dir has a minor bug.
Related Issue
https://github.com/chef/chef/issues/8475
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] All commits have been signed-off for the Developer Certificate of Origin.

Nice catch


Enhancement: Individual Shader Options

For week 6, please make it an option where you can enable which shaders to use rather than having both of them on.

I assume you mean just distortion and just the CRT effect? I'll look into it


Correct dns fix from zephyr (reverts our workaround as well)

This is a cherry-pick of a correct fix for DNS problems, which replaces my old workaround.
It will make a merge conflictless once we get Zephyr 3.0 (at least will eliminate this merge conflict).
Issue in Zephyr: https://github.com/zephyrproject-rtos/zephyr/issues/39242
Fix in Zephyr which I'm cherry-picking with this PR: https://github.com/zephyrproject-rtos/zephyr/pull/42321

@mglettig
If we merge this, it makes sense also to cherry-pick it into our Zephyr Fork 2.7.99 (for NRF SDK 1.9.1)


Video play will pause when availabilityStartTime is changed for live stream

What version of Shaka Player are you using?
2.0.6

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
I am using the Demo app and custom app.

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Chrome, Windows 10

What did you do?
I using the Wowza as the live stream server.
When the source stream is dead and active again. The Wowza will changed the availabilityStartTime in .mpd file.
Example:
availabilityStartTime="2017-03-09T17:05:12Z"
to:
availabilityStartTime="2017-03-09T17:08:32Z"

What content did you load?

If standard demo asset, which one?

If custom asset, what manifest and license server URIs?

How did you interact with the content, if at all?

What did you expect to happen?
The Shaka will always pause when the availabilityStartTime is changed. Can you set auto play again?

What actually happened?

This seems like a bug on Wowza.  Changing the availabilityStartTime is not valid.  availabilityStartTime must remain the same value throughout the stream so we can determine when the segments occur.

@KingjZhang, please update Wowza and let us know if that resolves your issue.  Thanks!

@KingjZhang, changing availabilityStartTime is not valid in our view, and we believe this will be resolved by updating Wowza.  I'm going to go ahead and close this issue for now.  If an update does not solve your problem, let us know and we can help investigate.


Advanced routing context for integrations

Currently, an artifact gets routed to a given attached integration if the artifact is from a known type (i.e CycloneDX SBOM), this rigid mechanism has some limitations.
Scenarios
Scenario a) Two SBOM materials defined in a contract are sent to the same dependency-track project,
So for example, if you are attesting two different SBOMs, they are both sent to the project defined during attachment. This means project override.

Ideally, we'd like these to be sent to two different projects.

Scenario b) Single SBOM material entry, but containing different SBOMs
Let's say for example that you have a single CI job that is syncing a set of upstream assets. This means that you are using the same contract but technically running it multiple times for each asset.
In the example below, we are running the same workflowRun 3 times, but in the context of a different asset. This run is attaching the sbom material and overriding the same dependency-track project, because of the same issue described above.

Ideally, we should be able to even though we are re-using the same material entry, attach it some context that then can be used for the final routing. In other words, choose the dependency-track projects based on the asset we are processing.

Solution
There are two three new implementation concepts relevant to this problem annotations, templating and filtering
Annotations
Annotations are a set of arbitrary key/values associated with a given material. These annotations will

Be defined in the contract
Might have a default value
Could be set during attestation, i.e attestation add --name ... --value ... --annotations asset=nginx

Templating
Currently, when you attach an integration, i.e dependency-track, you can choose the a project name that will be automatically created, for example
$ chainloop integration attached add ... --opt projectName=bitnami-asset

We could leverage the new annotations to in practice expand a dynamic project name, for example
$ chainloop integration attached add ... --opt projectName="bitnami-asset-{{.Annotations.Asset}}"

This will make the plugin to template the project name based on an annotation value resulting on pushing to bitnami-asset-nginx, bitnami-asset-apache and so on.
Filtering
With annotations + templating we could solve the scenarios described above, and in fact it's very useful when you have dynamic capabilities in the plugin and an unknown number of inputs.
But there is another feature that builds on top of annotations that could be used to choose what kind of artifacts can be sent to a given attached integration and these are filters.
Filters work similarly to kubernetes labels, insofar during attachment you could pick just the materials that match the criteria.
So let's talk for example the first scenario, where we have multiple SBOMs as part of the same attestation that we want to send to different projects.

In this case we could

annotate the SBOM materials one as controlplane and another as cas

Attach the integration multiple times with different filtering values, for example

chainloop integration attached add ... --opt projectName=controlplane -l component=controlplane
chainloop integration attached add ... --opt projectName=cas -l component=cas

Now, each attachment will be executed only if the annotations on the received materials make sense.
This feature is also useful to forward generic artifact types to given integrations. @gr0 you might be interested in this.

### Tasks
- [ ] Implement annotations
- [ ] Implement templating in Dependency-track
- [ ] Make sure that Chainloop [release process](https://github.com/chainloop-dev/chainloop/blob/main/.github/workflows/release.yaml) uses this feature (scenario a)
- [ ] Re-evaluate filtering in the context of @gr0 priorities

Thank you for documenting these requirements here, Miguel!
As you know, I am developing a system that automatically synchronizes and attests a curated catalog of containerized applications, their corresponding SBOMs, and other evidence materials. I want to use one workflow to run my sync job periodically. Yes, this is a scenario B).
Annotations with templating will definitely help, but we may still need to include root-level annotations to define attestations properly. To clarify, I must include the materials id, name, and version in my sync contracts today to show them later in all notifications at the top or to properly integrate with the Dependency Track instance. By utilizing root-level annotations, we can effectively describe attestations and communicate through integrations.
Regarding filtering, I suggest the following additions:

Org-level integrations. I can attach integrations once across many workflows and parametrize them with annotations and filters.
Throttling integrations through filtering. I want to throttle some integrations. For example, I want to send notifications only for major releases and skip them for minor and patch versions.

Hope it helps.

and other evidence materials. I want to use one workflow to run my sync job periodically. Yes, this is a scenario B).

Thanks for confirming!

Annotations with templating will definitely help, but we may still need to include root-level annotations to define attestations properly. To clarify, I must include the materials id, name, and version in my sync contracts today to show them later in all notifications at the top or to properly integrate with the Dependency Track instance. By utilizing root-level annotations, we can effectively describe attestations and communicate through integrations.

That makes sense. Definitely using annotations to add context to an attestations seems the right way.

Throttling integrations through filtering. I want to throttle some integrations. For example, I want to send notifications only for major releases and skip them for minor and patch versions.

This is interesting, this technically could be done by attaching an integration with a filter  that checks for example a label called upgrade-type is major

Org-level integrations. I can attach integrations once across many workflows and parametrize them with annotations and filters.

I agree, in my head I've had some auto-attach rules that could be defined


WIP: Flexible configuration layout

This refactors the whole plugin to be more dynamic: Instead of a fixed list of theme elements, we present theming as a dynamic list with elements. This was a bit inspired by JENKINS-50346 and the desire to add additional options to each theme elements (where to apply it).
This involves

[x] Refactoring the configuration page
[ ] Migrating the old settings
[ ] Adding the config options to select "what to style" to fix JENKINS-50346
[ ] Adding a testcase for the Configuration-as-Code plugin, to make sure the new layout is properly represented

I'd like to get this in before building the next release, so the Configuration-as-Code configuration is (somewhat) stable...

Ping @jmsizun and @minitux, since you were interested in Configuration-as-Code for this - does this look okay to you? Sorry it's taking me so long, but I really want to get this in before creating a new version (because of the configuration layout change)

Hi, thanks @TobiX for the notification.
I am interested in testing the result on my side, as soon a I understand if I can update my fork with your new branch, or if I must re-create it. :-)
Please go with it if you get no news from my side in the next 2 days.


Registrations exceeded the number

version: 1.4

?

你的问题是什么？

我在docker中使用的时候 Error: Registrations exceeded the number
就是这个

写的很清楚，超过限制

我就开了一个啊

Your registrations (not the node numbers) are over the limit. Probably because you deleted old containers and generated new ones, which all were counted as registrations.


cni: modernize repair controller

Currently this is using some of the old controller methods. Clean up to modern standards.
Should have no use facing behavior except RunAsDaemon is now always true since there isn't a good use case for other modes.
Please provide a description of this PR:

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
9f9285b6527ee11f3817bc670ac76d36109c99f4
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
9f9285b6527ee11f3817bc670ac76d36109c99f4
link
true
/test lint

integ-ambient_istio
9f9285b6527ee11f3817bc670ac76d36109c99f4
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
9f9285b6527ee11f3817bc670ac76d36109c99f4
link
true
/test lint

integ-ambient_istio
9f9285b6527ee11f3817bc670ac76d36109c99f4
link
true
/test integ-ambient

integ-operator-controller_istio
9f9285b6527ee11f3817bc670ac76d36109c99f4
link
true
/test integ-operator-controller

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
9f9285b6527ee11f3817bc670ac76d36109c99f4
link
true
/test lint

integ-ambient_istio
9f9285b6527ee11f3817bc670ac76d36109c99f4
link
true
/test integ-ambient

integ-operator-controller_istio
9f9285b6527ee11f3817bc670ac76d36109c99f4
link
true
/test integ-operator-controller

integ-cni_istio
9f9285b6527ee11f3817bc670ac76d36109c99f4
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
9f9285b6527ee11f3817bc670ac76d36109c99f4
link
true
/test integ-ambient

integ-operator-controller_istio
9f9285b6527ee11f3817bc670ac76d36109c99f4
link
true
/test integ-operator-controller

integ-cni_istio
9f9285b6527ee11f3817bc670ac76d36109c99f4
link
true
/test integ-cni

lint_istio
301c41905c23a4bb4923f21e46657ea8cc01102c
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
301c41905c23a4bb4923f21e46657ea8cc01102c
link
true
/test lint

integ-cni_istio
301c41905c23a4bb4923f21e46657ea8cc01102c
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
301c41905c23a4bb4923f21e46657ea8cc01102c
link
true
/test lint

integ-cni_istio
301c41905c23a4bb4923f21e46657ea8cc01102c
link
true
/test integ-cni

bookinfo-build_istio
301c41905c23a4bb4923f21e46657ea8cc01102c
link
true
/test bookinfo-build

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Highlight the need of a new deployment when scaling

/test dataplane-operator-build-deploy-kutt

/test dataplane-operator-build-deploy-kuttl


GPG key for Release 3.7.0

Greetings!
We are using the GPG key included in Helm release for validating those releases and spotted today that instead of @mattfarina latest release (3.7.0) is signed by @bacongobbler
Was it done on purpose? Who will be signing releases from now on?
Thanks in advance!

@rotskyi Releases can be cut by any of the core maintainers. @bacongobbler is a core maintainer and he cut the release for 3.7.0, even though @mattfarina cut the RCs for 3.7.0. @mattfarina just happens to have been cutting releases of late and we are thankful for him for doing it.
Hope this helps.

In other words, whoever cuts the release check their key.

Thanks for reply! Is there somewhere a list of core maintainers? We are really grateful for releases, guys, just in terms of security we need some signatures to check against 🤔

https://github.com/helm/helm/blob/main/KEYS