Logger - StackTraceUsage.WithCallSite without always using StackTrace

Extracted the callsite optimization from #2527, but excluded the special LoggerCallSite. And changed enum StackTraceUsage into a Flags-enum.
This allows NLog to make optimal use of caller-member-attributes to provide Callsite-information. Just need to figure out how to make a nice way to provide the info besides the fluent LogBuilder-interface.
Resolves partly #532 when using LogBuilder and resolves #2059

Codecov Report

Merging #3431 into dev will decrease coverage by <1%.
The diff coverage is 30%.

@@          Coverage Diff           @@
##             dev   #3431    +/-   ##
======================================
- Coverage     81%     81%   -<1%
======================================
  Files        343     343
  Lines      27573   27640    +67
  Branches    3713    3740    +27
======================================
+ Hits       22272   22286    +14
- Misses      4224    4273    +49
- Partials    1077    1081     +4

Surprised by the special methods in Log.cs. I hope no one are using them as they must be crazy slow with disk-access for file-lookup on every LogEvent.

Surprised by the special methods in Log.cs. I hope no one are using them as they must be crazy slow with disk-access for file-lookup on every LogEvent.

Do you mean Path.GetFileNameWithoutExtension(callerFilePath)?

Ah yes sorry. Thought it tried to find the filename on the disk. But it is "just' removing the file-extension. Not so bad besides doing string allocation and Logger-lookup on every logevent
Sent from my Sony Xperia
---- Julian Verdurmen wrote ----
Surprised by the special methods in Log.cs. I hope no one are using them as they must be crazy slow with disk-access for file-lookup on every LogEvent.
Do you mean Path.GetFileNameWithoutExtension(callerFilePath)?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/pull/3431?email_source=notifications&email_token=ACXZ7HGP7E573HOHBCR7QT3PX32HRA5CNFSM4HPVH35KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWQXGBY#issuecomment-497120007, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACXZ7HEGND2TZF7OFRB5HCDPX32HRANCNFSM4HPVH35A.

Going on a 10 day vacation. So if more changes are needed before merge, then you are welcome to make commit to the branch :)

Have a good holiday!

Replying from my phone. The moving of NET4_5 for caller member attributes. Is to make NET4_0 + NET3_5 binary compatible. One could also add 3 default parameters to the now removed Write-method with the exact same parameters name.
I have not removed the old enum names in attenpt to make it less breaking. But you are welcome to remove all the old aliases.
There is no need for null check as it needs the callerinfo-details to make the lookup (details equals null means no lookup and no assignment of class-name)
Sent from my Sony Xperia
---- Julian Verdurmen wrote ----
Have a good holiday!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/pull/3431?email_source=notifications&email_token=ACXZ7HED4T5RHUGM4OFHNLTPX667PA5CNFSM4HPVH35KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWSEWZA#issuecomment-497306468, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACXZ7HDHICWAH63JDHIMMY3PX667PANCNFSM4HPVH35A.

Replying from my phone. The moving of NET4_5 for caller member attributes. Is to make NET4_0 + NET3_5 binary compatible. One could also add 3 default parameters to the now removed Write-method with the exact same parameters name.
I have not removed the old enum names in attenpt to make it less breaking. But you are welcome to remove all the old aliases.
There is no need for null check as it needs the callerinfo-details to make the lookup (details equals null means no lookup and no assignment of class-name)
Sent from my Sony Xperia
---- Julian Verdurmen wrote ----
@304NotModified commented on this pull request.

In src/NLog/Config/StackTraceUsage.cshttps://github.com/NLog/NLog/pull/3431#discussion_r289130220:

     /// <summary>
     /// Stack trace should be captured without source-level information.
     /// </summary>

   WithoutSource = 1,

   WithoutSource = WithStackTrace,

what's the use of this alias?

In src/NLog/Fluent/LogBuilder.cshttps://github.com/NLog/NLog/pull/3431#discussion_r289131193:

     /// <summary>

     /// Writes the log event to the underlying logger.
     /// </summary>
     /// <param name="callerMemberName">The method or property name of the caller to the method. This is set at by the compiler.</param>
     /// <param name="callerFilePath">The full path of the source file that contains the caller. This is set at by the compiler.</param>
     /// <param name="callerLineNumber">The line number in the source file at which the method is called. This is set at by the compiler.</param>
     public void Write(

       [CallerMemberName]string callerMemberName = null,

       [CallerFilePath]string callerFilePath = null,

       [CallerLineNumber]int callerLineNumber = 0)

+#if NET4_5

       [CallerMemberName]

+#endif

       string callerMemberName = null,

+#if NET4_5

       [CallerFilePath]

+#endif

       string callerFilePath = null,

+#if NET4_5
I'm still a bit confused by this :(
In .net 4, why having this method with 3 parameters? What am I missing?

In src/NLog/Fluent/LogBuilder.cshttps://github.com/NLog/NLog/pull/3431#discussion_r289131348:

         _logger.Log(_logEvent);
     }

-#else

   /// <summary>

   /// Writes the log event to the underlying logger.

   /// </summary>

   public void Write()

maybe i'm missing it, but I think this was better

In src/NLog/LoggerImpl.cshttps://github.com/NLog/NLog/pull/3431#discussion_r289132775:

         {

           bool attemptCallSiteOptimization = targetsForLevel.TryCallSiteClassNameOptimization(stu, logEvent);

           if (attemptCallSiteOptimization && targetsForLevel.TryLookupCallSiteClassName(logEvent, out string callSiteClassName))

           {

               logEvent.CallSiteInformation.CallerClassName = callSiteClassName;

shouldn't we check logEvent.CallSiteInformation for null?

In src/NLog/LoggerImpl.cshttps://github.com/NLog/NLog/pull/3431#discussion_r289133127:

         {

           bool attemptCallSiteOptimization = targetsForLevel.TryCallSiteClassNameOptimization(stu, logEvent);

           if (attemptCallSiteOptimization && targetsForLevel.TryLookupCallSiteClassName(logEvent, out string callSiteClassName))

           {

               logEvent.CallSiteInformation.CallerClassName = callSiteClassName;

or should we use GetCallSiteInformationInternal()?

In src/NLog/Targets/Target.cshttps://github.com/NLog/NLog/pull/3431#discussion_r289134461:

@@ -521,9 +521,9 @@ private void FindAllLayouts()
{
_allLayoutsAreThreadSafe = _allLayouts.All(layout => layout.ThreadSafe);
}

       StackTraceUsage = _allLayouts.DefaultIfEmpty().Max(layout => layout?.StackTraceUsage ?? StackTraceUsage.None);

       if (this is IUsesStackTrace usesStackTrace && usesStackTrace.StackTraceUsage > StackTraceUsage)

           StackTraceUsage = usesStackTrace.StackTraceUsage;

       StackTraceUsage = _allLayouts.DefaultIfEmpty().Aggregate(StackTraceUsage.None, (seed,layout) => seed | (layout?.StackTraceUsage ?? StackTraceUsage.None));

I refactored the Aggregate, those are hard to read
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/pull/3431?email_source=notifications&email_token=ACXZ7HHZPHD3OJJ3S2FIBPTPYASITA5CNFSM4HPVH35KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2FMIXA#pullrequestreview-243975260, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACXZ7HBC6RXXA6DD36ZNSZTPYASITANCNFSM4HPVH35A.

Thanks for the reply!

Btw found this page where the wiki is used for  issue tracking
https://github.com/NLog/NLog/wiki/Unable-to-write-to-NLOG-in-kubernetes-containers
Sent from my Sony Xperia
---- Julian Verdurmen wrote ----
Thanks for the reply!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/pull/3431?email_source=notifications&email_token=ACXZ7HBCPVWQTEO5LUHTORLPYGO2LA5CNFSM4HPVH35KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWWPTMI#issuecomment-497875377, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACXZ7HAAWLNX3OAMORNVVVDPYGO2LANCNFSM4HPVH35A.

converted this to an issue -> https://github.com/NLog/NLog/issues/3446

Regarding the new issue then absolute file path should be used that matches the mounted volumes configured. Kubernetes write permissions should of course be given.
Else good idea to upgrade to latest NLog and check the internal logging (maybe redirect to console if that is working)
Sent from my Sony Xperia
---- Julian Verdurmen wrote ----
converted this to an issue -> #3446https://github.com/NLog/NLog/issues/3446
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/pull/3431?email_source=notifications&email_token=ACXZ7HFOQEH2XC3NPXTA563PYQOETA5CNFSM4HPVH35KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWX4N2A#issuecomment-498058984, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACXZ7HA57H637BAMYEIDHATPYQOETANCNFSM4HPVH35A.

Regarding the new issue then absolute file path should be used that matches the mounted volumes configured. Kubernetes write permissions should of course be given. Else good idea to upgrade to latest NLog and check the internal logging (maybe redirect to console if that is working)

Is this related to this PR?

Nope to the issue created from the rogue wiki page
Sent from my Sony Xperia
---- Julian Verdurmen wrote ----
Regarding the new issue then absolute file path should be used that matches the mounted volumes configured. Kubernetes write permissions should of course be given. Else good idea to upgrade to latest NLog and check the internal logging (maybe redirect to console if that is working)
Is this related to this PR?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/pull/3431?email_source=notifications&email_token=ACXZ7HDTI4RUXPKYJQ2I6Y3PYU7JTA5CNFSM4HPVH35KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWZ5CNQ#issuecomment-498323766, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACXZ7HESNFXVDKUFIQHYN63PYU7JTANCNFSM4HPVH35A.

Sorry for the long delay!


chore(main): release dprint 1.15.7

:robot: I have created a release beep boop
1.15.7 (2024-08-22)
Miscellaneous

software: update installed (1c0a2af)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

dprint-v1.15.7
:sunflower:


[Bug] Convert Viewport Stack or Volume

I used this old one and it works very well.
packages/tools/examples/stackToVolumeWithAnnotations/_setViewports.ts
Then I switched to using this new one.
convertStackToVolumeViewport.ts
convertVolumeToStackViewport.ts
I tested the result:
Viewport Stack

Convert Stack to Volume

Convert Volume to Stack

These dicom files that I tested
psir_HR_SA_MAG - 46.zip

So on the way back to stack it doesn't work? I guess it might be the cacheOptimizations. Can you set that to off?
enableCacheOptimization: true,

So on the way back to stack it doesn't work? I guess it might be the cacheOptimizations. Can you set that to off?
enableCacheOptimization: true,

enableCacheOptimization: false
The result is the same


NAS-130321 / 24.10 / Add '/proc/mounts/ and '/etc/fstab' to nfs

Collect NFS client mounts done from the TrueNAS server.

Jira URL: https://ixsystems.atlassian.net/browse/NAS-130321

Jira URL: https://ixsystems.atlassian.net/browse/NAS-130321

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.


Make PublicKey type property static

Shouldn't the type property of PublicKey child classes be static?
Some places require PublicKey type as a parameter. It would be convenient to use this property without having an instance of a class.
For example, the Ed25119Sig2018 class contains:
  @Equals('Ed25519VerificationKey2018')
  public type = 'Ed25519VerificationKey2018' as const

When I'm creating an instance of ReferencedAuthentication, it requires type as second parameter:
    new ReferencedAuthentication(
      new Ed25119Sig2018({
        id: 'did:sov:SKJVx2kn373FNgvff1SbJo#5',
        controller: 'did:sov:SKJVx2kn373FNgvff1SbJo',
        publicKeyBase58: 'EoGusetSxDJktp493VCyh981nUnzMamTRjvBaHZAy68d',
      }),
      'Ed25519VerificationKey2018'
    ),

Another option could be creating an "enum" structure to avoid copy-pasting string literals.
Maybe, it's already there somewhere and I just haven't found it.

The problem with it being a static property is that we also need it as an instance property. So we would get the same as we have now with message classes where we have a static type and an instance type. The instance type value is the value of the static type so you don't have to declare the value twice. Maybe something like that would work?
However I have to say the implementation of the signature suite classes currently is overly complex and would be better of with some simplification. I made it a lot looser in the new did document implementation (not every verification method has it's own class anymore)

@TimoGlastra, just to verify. Is there overlap between the signature suite implementations mentioned here and the ones I'm working on for the jsonld work?


Do NOT re-sort QuickPickItem when typing

Originally, the quick pick comprises index, actionType, reducer, and selector respectively. I intentionally place index at the top of the list because, you know, it is index.js. However, when start typing, VSCode re-sorts my items so actionType comes before index which I do NOT want that.
I believe auto sorting QuickPickItem is a feature (https://github.com/Microsoft/vscode/issues/15659), hence I'm creating a feature request ticket so that QuickPickOptions has a new field called keepOrder or doNotResort or whatever.
Cheers!

I guess what's being asked for here is to make sure the entries stay stable if they have the same weight after going through the fuzzy sort.

Thanks Daniel for your swift response.
Unfortunately, I would like have my order untouched whether the search term matches label or description.
My extension populat

@ThisIsManta the order must be changed as it's fuzzy sorting and filtering the list. Without sorting, if you had something that matched the label exactly and the description partially the best match may not be at the top. In the example above I would expect the match weights to be the same as they're both matching on the description.

/duplicate #73904


RuntimeError during training

Dear Nvidia AI-IOT team,
I've been trying to train the models using the provided train.py script and the coco dataset downloaded through the provided shell script.
When  Saving checkpoint to densenet121_baseline_att_224x224_A.json.log/epoch_0.pth, I instantly get the following error (0% progress) :
  File "train.py", line 162, in <module>
    scaled_loss.backward()
  File "/usr/local/lib/python3.6/dist-packages/torch/tensor.py", line 198, in backward
    torch.autograd.backward(self, gradient, retain_graph, create_graph)
  File "/usr/local/lib/python3.6/dist-packages/torch/autograd/__init__.py", line 100, in backward
    allow_unreachable=True)  # allow_unreachable flag
RuntimeError: Unable to find a valid cuDNN algorithm to run convolution (try_all at /pytorch/aten/src/ATen/native/cudnn/Conv.cpp:693)

Would you have any pointers on how to fix this ?
Fyi, I am running this script from a docker container based on 10.1-devel-ubuntu18.04, with the following package/module versions:

cuda 10.1
cudNN <IP_ADDRESS>-1
torch 1.5.1+cu101
torchvision 0.6.1+cu101
latest apex release (with the cpp and cuda extensions)
I have also tested these versions from python.

Thanks in advance !
Oliver

Setting torch.backends.cudnn.benchmark = True at the beginning of the script fixed it for me.

Hi OliverGuy,
Apologies for the delayed response.  Thanks for sharing!
Glad to hear you got past this.  Were you able to train successfully?
Best,
John

Hi John,
No problem at all, and thanks for checking back !
I was indeed able to train, and I'm now working on crafting my own coco dataset.
Regards,
Oliver


(simatec) solax added

RE-CHECK!

Automated adapter checker
ioBroker.solax

:thumbsup: No errors found

[ ] :eyes: [W400] Cannot find "solax" in latest repository

Add comment "RE-CHECK!" to start check anew

@Apollon77 ping ;-)

Just a small topics:

Please do admin deps (https://github.com/simatec/ioBroker.solax/blob/1e1ba7d8c70ed74f9c03c4aad8d801cc5f138390/io-package.json#L120) in "globalDependencies" unless you really need that admin version "on the same host as the adapter"
some of your rtoles in io-package and code do not make sense or are invalid  ... e.g. indicators are booleans by definition (see https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/stateroles.md#indicators-boolean-read-only) ... maybe value would fit better
When async7await then please noc allbacks ... that gives chaos!! https://github.com/simatec/ioBroker.solax/blob/master/main.js#L268 (example) - also here long/lat is initialized asny later probably (because no promise is returned when callback is there I think) ... also here and other places https://github.com/simatec/ioBroker.solax/blob/master/main.js#L653
is the data request really needed x:x:20 every minute exactly then? Becaus ethe effect here is that ALL users that use this adapter will reach the solax cloud system at the exact same time (if time is ntp synced as usual today it is even close in ms) ... depeneding on how many this becomes a DDOS against the cloud system! Rethink that because it can give big issues with the solax guys. Same for the second schedule.
Please check and adjust

@Apollon77 Thanks for your feedback. I tried to fix everything in version 0.3.2

@Apollon77
In version 0.3.3 I have adjusted all roles and revised the await functions. Furthermore, the interval is now executed as discussed using setInterval. Now everything should fit for the latest ;-)

why you removed the admin dep?? It is still relevant :-) but please do in "common.globalDependencies"
async unneeded here https://github.com/simatec/ioBroker.solax/blob/master/main.js#L269 because you use no await
you still have await/callback mixes in e.g. https://github.com/simatec/ioBroker.solax/blob/master/main.js#L643
The latter point could be rewitten to

                        const state = await adapter.getStateAsync(`data.${resultID}`);
                        if (state && state.val >= 0) {
                            json[`${resultID}`] = state.val;
                        }

and formally a try/catch around it for error cases

I think you missed that line to remove? https://github.com/simatec/ioBroker.solax/blob/master/main.js#L718

@Apollon77
As discussed in Telegram, I have fixed all async / await problems in version 0.3.4 and removed the remaining bugs as well

welcome

@Apollon77 many thx 🙏 😊


io: fix path handling on Windows by switching to NtCreateFile

Previously we were using kernel32.CreateFileW which had 2 problems:

No way to provide a dir_fd, so we were always opening basename(path), causing us to ignore paths!
Didn't check if the file exists (so tigerbeetle format would overwrite files).

Switch to vendoring Zig's OpenFile, which uses ntdll.NtCreateFile and has neither of these issues. Vendoring was required, since we need to pass in file attributes, which the Zig implementation didn't allow for by default.
Before:
~/g/t/tigerbeetle-7> ./tigerbeetle.exe format --replica-count=1 --cluster=0 --replica=0
info(io): creating "foo"...
info(io): allocating 1.06298828125GiB...
info(main): 0: formatted: cluster=0 replica_count=1

~/g/t/tigerbeetle-7> ./tigerbeetle.exe format --replica-count=1 --cluster=0 --replica=0
info(io): creating "foo"...
info(io): allocating 1.06298828125GiB...
info(main): 0: formatted: cluster=0 replica_count=1

~/g/t/tigerbeetle-7> rm foo

~/g/t/tigerbeetle-7> ./tigerbeetle.exe format --replica-count=1 --cluster=0 --replica=0 /tmp/foo
info(io): creating "foo"...
info(io): allocating 1.06298828125GiB...
info(main): 0: formatted: cluster=0 replica_count=1

~/g/t/tigerbeetle-7> ls -l foo
.rw-r--r-- 1.1G federico  8 May 20:43 foo

After:
~/g/t/tigerbeetle-7> ./tigerbeetle.exe format --replica-count=1 --cluster=0 --replica=0 /tmp/foo
info(io): creating "foo"...
info(io): allocating 1.06298828125GiB...
info(main): 0: formatted: cluster=0 replica_count=1

~/g/t/tigerbeetle-7> ./tigerbeetle.exe format --replica-count=1 --cluster=0 --replica=0 /tmp/foo
info(io): creating "foo"...
error: PathAlreadyExists

~/g/t/tigerbeetle-7> ls -l /tmp/foo
.rw-r--r-- 1.1G federico  8 May 20:44 foo

(the above samples are running through Wine)

Hm, this seems to fail on real Windows systems. I'll double check what's going on tomorrow.


Vimeo videos not playing with chrome desktop Version 89.0

Hi,
getting a strange issue with plyr.js with vimeo videos .Videos are just start playing and then paused .
Here is the video of the issue : http://somup.com/creIh7bjgh
html :

script :
`let config = {};
config['listeners']={
seek:  (e) => {
var currentTime = plyr.currentTime;
var newTime = _getTargetTime(plyr, e);
if (newTime > currentTime) {
e.preventDefault();
		    return false;
		  }
	}

};
let pplayer = new Plyr(document.querySelector('#item_1'),config);`
Environment

Browser:Chrome
Version:89.0
Operating System:MacOS
Version:High Siera

Errors in console :
Unrecognized feature: 'autoplay,fullscreen,picture-in-picture'.  ------  plyr.js?ver=2009:formatted:3414
Uncaught TypeError: this.enter is not a function ----  plyr.js?ver=2009:formatted:2547
Update
this is happening with your own demo : https://codepen.io/pen?template=bKeXNq

Having the same issue.
I can only replicate it on chrome running on macOS.
plyr.polyfilled.min.js:3 Unrecognized feature: 'autoplay,fullscreen,picture-in-picture'.
Browser: Chrome
Version: 89.0
Operating System: macOS
Version: Big Sur 11.1

Same here !

Hi please anyone with any solution here? Need a quick fix urgently

@alexvibealex @cfabrice @jeankhouri Upgrade to the latest version of Plyr 3.6.4 (https://cdnjs.cloudflare.com/ajax/libs/plyr/3.6.4/plyr.min.js) Your issue will be resolved.

@imransiddiq Thank you for the tip! Unfortunately even on 3.6.4 the videos still don't play.

Hello,
I use vue-plyr (with plyr 3.6.4) - not sure if it is vue-plyr or plyr but as mentioned just above, a user found that interacting with the video like muting it, makes it playable... without such interaction, it is not responding to play.

Just a quick question for fellow Vimeo users, is everything working correctly regarding being able to access the controls on mobile?
Discussed here:
#2018

Plyr 3.6.4 is available only on NPM. Not on GITHUB

https://www.npmjs.com/package/plyr/v/3.6.4
https://github.com/sampotts/plyr/tags

And it was published in January 2021

This is fixed in 3.6.4. Sorry, the release on GitHub but is there now. I'm going to add lerna to handle it all eventually.

I believe I am using 3.6.4, also I am still just referring to this issue #2018
Could you confirm whether https://plyr.io/#vimeo is using the latest version?
As I still can't use the controls on mobile after playing has started.

Yes, we are getting the same issue on chrome on android.
After pausing the video the controls are not shown.

Was the original issue with playing vimeo videos fixed? I'm using 3.6.4 and the video does not respond to play unless muted and if I unmute once the video is playing, it stops playing again.

Yes that issue is fixed I confirm but with version 3.6.4 a new issue appear as stated in #2018  after playing the video

@alexvibealex  is any changes on the client code side required? since on the latest version and it's not working in my case

Yes that issue is fixed I confirm but with version 3.6.4 a new issue appear as stated in #2018 after playing the video

Yes, same problem here. Once the video starts, the controls no longer appear on mobile.

Hello everyone.
@cfabrice I am using the latest vue-plyr and plyr (v3.6.4) and experiencing the same problem. Got this console error logs
Uncaught (in promise) NotAllowedError: play() failed because the user didn't interact with the document first. https://goo.gl/xX8pDD
The problem can be reproduced in the Chrome browser only (v89.0.4389.90 for Windows, v89.0.4389.90 for Mac, mobile devices). After some research found that video can play only when muted or when it was clicked directly on the iframe (need to remove plyr overlays).
@sampotts Also after the template checking I see that "allow" attribute is allow="autoplay,fullscreen,picture-in-picture" with the comma separator "," but in the source files I see that it needs to be  iframe.setAttribute('allow', ['autoplay', 'fullscreen', 'picture-in-picture'].join('; ')); -  with the semicolon separator ";". Maybe this is the problem?
Thanks for any information and help

the bug is still happening on 3.6.4 on Chrome windows!

@darkylmnx Are you able to provide a link where I can reproduce the issue? I'm unable to replicate it on Chrome 90.
Please keep this issue about the original issue of playback. The controls issue is #2018.

@darkylmnx Are you able to provide a link where I can reproduce the issue? I'm unable to replicate it on Chrome 90.

@sampotts as you can see on this video, on Chrome 89 on Windows, it doesn't work.
Sometimes when I'm not on incognito mode, it works, just as if previous user-interaction makes Chrome fix the thing.
But it's pretty random.
On Firefox, everything is fine.
Here's a demo video of the issue: https://vimeo.com/529880040/999e116da7
Here's my Chrome version

Here's the CodeSandbox: https://codesandbox.io/s/broken-shadow-v8lls?file=/src/App.vue
I have a Codpen version too: https://codepen.io/darkylmnx/pen/RwKNJbW
Here's a message in the console: plyr@3:3 Allow attribute will take precedence over 'allowfullscreen'.
And with this url as source: https://player.vimeo.com/video/529880040
I get:
vue-plyr.esm.js:4853 Unrecognized feature: 'autoplay,fullscreen,picture-in-picture'.
vue-plyr.esm.js:3149 GET https://vimeo.com/api/v2/video/529880040.json 404 (Not Found)

Has anyone else experienced the following after upgrading to 3.6.4:

Vimeo plays on Chrome as expected.
Now breaks the container on Firefox v88 and Safari v14.1 (MacOS v10.15.7)

Is there CSS updates that need to be implemented with 3.6.4 change?

I'm still getting this issue and am using Mac Chrome 91,  "vue-plyr":"^7.0.0", and "plyr": "^3.6.4",. Has anyone been able to find a fix? The video will play if you mute it, but as soon as you unmute it you can no longer play the video :(

I'm unable to replicate this on Chrome Version 91.0.4472.77 (Official Build) beta (arm64). Vimeo plays back fine, without a console error relating to the allow attribute. Also we no longer use the old syntax, this was fixed a while back to use the new semi-colon separated list:
https://github.com/sampotts/plyr/blob/32444c9851414a1f1947add04e4c3be47b964b0e/src/js/plugins/vimeo.js#L109

I updated to plyr 3.6.7 and all working ok now! Thanks for your help

Forking vue-plyr and updating to v3.6.8 solves the issue for me as well.


Uncaught TypeError: Cannot read property 'type' of undefined

[Enter steps to reproduce below:]

...
...

Atom Version: 1.2.4
System: Mac OS X 10.11.1
Thrown From: atom-react-preview package, v1.1.4
Stack Trace
Uncaught TypeError: Cannot read property 'type' of undefined
At /Users/GuyZa/.atom/packages/atom-react-preview/lib/renderer.js:94

TypeError: Cannot read property 'type' of undefined
    at Renderer.render (/Users/GuyZa/.atom/packages/atom-react-preview/lib/renderer.js:94:60)
    at [object Object].ReactCompositeComponentMixin._renderValidatedComponentWithoutOwnerOrContext (/Users/GuyZa/.atom/packages/atom-react-preview/node_modules/react/lib/ReactCompositeComponent.js:587:34)
    at [object Object].ReactCompositeComponentMixin._renderValidatedComponent (/Users/GuyZa/.atom/packages/atom-react-preview/node_modules/react/lib/ReactCompositeComponent.js:607:32)
    at [object Object].ReactCompositeComponentMixin.mountComponent (/Users/GuyZa/.atom/packages/atom-react-preview/node_modules/react/lib/ReactCompositeComponent.js:220:30)
    at /Users/GuyZa/.atom/packages/atom-react-preview/node_modules/react/lib/ReactServerRendering.js:42:38
    at ReactServerRenderingTransaction.Mixin.perform (/Users/GuyZa/.atom/packages/atom-react-preview/node_modules/react/lib/Transaction.js:136:20)
    at Object.renderToString (/Users/GuyZa/.atom/packages/atom-react-preview/node_modules/react/lib/ReactServerRendering.js:40:24)
    at /Users/GuyZa/.atom/packages/atom-react-preview/lib/atom-react-preview-view.coffee:127:36
    at /Users/GuyZa/.atom/packages/atom-react-preview/lib/atom-react-preview-view.coffee:102:7

Commands
  3x -0:35.3.0 markdown-preview:toggle (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:07.9.0 atom-react-preview:toggle (atom-text-editor.editor.vim-mode.normal-mode.is-focused)

Config
{
  "core": {
    "themes": [
      "atom-dark-ui",
      "one-dark-syntax"
    ]
  }
}

Installed Packages
# User
atom-react-preview, v1.1.4
color-picker, v2.0.14
linter, v1.11.3
minimap, v4.16.2
pigments, v0.19.1
react, v0.12.10
vim-mode, v0.63.0

# Dev
No dev packages

Hey, thanks for the creation of this issue!
Could I please ask you for the source of the component you're trying to load? If not, could you provide some other source that reproduces the same issue?
Thanks

Hey, just released version 2 of the package, please try this again and if you can reproduce it, please attach the source code and we'll have a look.


return endpoints that is in the same namespace as its referred pod

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zackbutcher
If they are not already assigned, you can assign the PR to them by writing /assign @zackbutcher in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
e8a3c0684182931bf78b8b5aa4c40b2f135650cd
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
50f9e7dee315031df2b7a145fb66c877f4cc95ba
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Tabs Color Classes Not working

Ionic Beta 7 and below.
Most of the tabs-X color classes do not work.
Reproduce:
Use Ionic CodePen sample : http://codepen.io/ionic/pen/odqCz
Change tabs class to :

tabs-positive : Works
tabs-default : Works
tabs-secondary : same as default
tabs-primary : same as default
tabs-info : same as default
tabs-success : same as default
tabs-warning : same as default
tabs-danger : same as default
tabs-dark : Works
tabs-light : Works but active tab does not show on Android. See Issue #1694 :

FYI : Many tabs classes are not documented.  See https://github.com/driftyco/ionic-site/issues/194

@calendee You should include this in the head section


Threaded view across folders

Right now I store sent messages in my inbox so they will appear in message threads.
I noticed that other folders can be added to the Unified Inbox, so I enabled 'Unify' on my Sent folder and began storing sent messages there. The problem was that messages were placed in two threads (sent/received) in my Unified Inbox instead of threading together.
Follow-up: if inter-folder threading can be achieved for the Unified Inbox, can it occur at the account level too?

Changing the code to enable threading for all messages in an account is possible. I'm not yet convinced that it's a good idea, though.

@cketti What do you propose as an alternative for people wanting all relevant messages (sent, received & drafts) being visible in the same thread?

@cketti A use-case in favor of enabling threading for all messages in an account is people who (like me) move messages into an "Archive" folder.  If I receive a new message in my "Inbox" folder, then I need to be able to look back on the old messages in a thread (e.g., if the new message doesn't fully quote the previous messages).
Also, since I'd like to try implementing this, could you point out where in the code to start?

This is a demanded feature, no doubt.

@adamsmd We store a local copy of each message. These local copies are collected into threads by MessagingController.collectMessagesInThreads based on a threadId field.
This threadId is the primary key of the threads table. New threadIds are created by LocalFolder.doMessageThreading
What you'd need to do is (and there may be more complications I've not thought of - this is just from a brief look at the code)

Add an option in the database to enable viewing threads by account.
Modify the thread code to calculate threading on a per account basis
Update all the current threads in the database on upgrade, merging where necessary
Modify the display code to display the threads either by folder or by account based n the user option.

In general email clients that I have seen only thread per folder. They often allow you to search for messages in other folders but they do not, by default, drag them in to the current view.
@ildar Demand is nice, but unless a feature is straightforward it'll probably only get done if a developer actively cares about it.

It's gmail's default behavior and actually extremely helpful. I would like to see my own messages in threads in my inbox, too.

Hi, just noticed that current version of GMAIL for android has this feature implemented. I configured gmail for my imap-server and it will display inbox and send mails in an single conversation - very nice. Whish k9 would get this too. I'm still an k9-user as gmail lacks many other features I need.

Please include into the threaded view the replies I sent from SENT folder. It doesn't have to be a "single page" like in GMAIL (when received and sent are collapsed with clickable headers). But please at least select & add into the current "threaded view" for a message - my emails from SENT (with the same subject ignoring "RE:" or "FWD:" prefixes?...)

I'm not yet convinced that it's a good idea, though.

This is a feature anyone switching from gmail or any other popular email client would expect, so from the point of view of ~plans for world domination~ adoption it is a valid feature request.

I agree this would be a useful feature, and one I've come to miss myself. Anyone want to take a stab at it? :)

+1
I miss this feature too. IMHO it is very confusing that my own messages are not shown in a threaded view. Especially new users might think that their message did not get sent?!
Also, this feature request is 3 years old. Is there anything we can do to make it happen (apart from coding it, which I can't)?

Hello all.
First of all, thank you for creating K-9 Mail.
I just installed it because I'm moving away from google services in general.
After using it for a couple of hours, I feel like I really need this feature. At the beginning I thought it was a bug. That all my replays weren't being fetched.
People need to see the entire thread to make decisions, right? Especially when you email clients that take weeks to replay. Then you need to see the history to remember the whole conversation.
Please make it possible.

As a weird corollary to this:
If I view "All Mail" folder (which at least for my mail provider contains both sent and incoming mail) the threading does the right thing.
But if I view Unified Inbox, then I see two half-threads, one of all my outgoing mail in a conversation, and one of all the incoming mail in the same conversation. This is slightly absurd, and IMO clearly qualifies as a bug (by virtue of violating user expectations)

Hello, is this a feature that is expected to be implemented soon?

Seems FairMail already has it even in their free version:
https://f-droid.org/en/packages/eu.faircode.email/

@pseudomonas wrote: If I view "All Mail" folder (which at least for my mail provider contains both sent and incoming mail) the threading does the right thing.

Does not work for me. Sent mails are not shown in conversatuon view, neither in regular inbox, not in unified inbox, nor in all mail.
Still urgently need this feature :-(

"All Mail" is provider specific (most likely just Google) and not all providers have it, therefore it cannot be accepted as a general solution.

just moved from gmail to k-9 and really miss this feature too! it's confusing.

@cketti do you have any specific objection?

Not really objections as such. Per-folder threads are easy to understand and were easy to implement. Having a thread contain messages from multiple folders raises a couple of UX questions:

Should messages from some special folders be excluded?

Trash?
Spam?
Drafts?
Archive?

If not, do these folders we exclude get their own thread view or do they never show threads?
Or should there be a kind of filter in the thread view where the user could choose to e.g. also show deleted messages belonging to the current thread. Then we'd have to figure out how to visually distinguish them from "regular" messages.
I'm sure there are some issues I'm forgetting

It's not an unsolvable problem. But it is quite a bit of work. So far this hasn't been important enough for me to dedicate time to it. Volunteers are welcome. But please come up with an UI/UX concept before trying to change any code.

These are good points. I think there are some options with varying degrees of complexity.

* Should messages from some special folders be excluded?

  * Trash?
  * Spam?
  * Drafts?
  * Archive?

I think excluding trash and spam makes sense. If the user has thrown it away, they probably don't want to see it again. Although I do think it would make sense to show Archived and Drafts. It could also be configurable by the user with some config page with checkboxes. That way the app could have some reasonable default, but let the user customize it if they wish.

* If not, do these folders we exclude get their own thread view or do they never show threads?

I think it would make sense to still show threads in the archive, the same as in the inbox. It could use the same exclusion config.

* Or should there be a kind of filter in the thread view where the user could choose to e.g. also show deleted messages belonging to the current thread. Then we'd have to figure out how to visually distinguish them from "regular" messages.

I think it would be reasonable to overlook the case of showing trashed emails unless there is further demand.

It's not an unsolvable problem. But it is quite a bit of work. So far this hasn't been important enough for me to dedicate time to it. Volunteers are welcome. But please come up with an UI/UX concept before trying to change any code.

I certainly respect the complexity and effort involved.  But I don't think I'm too off base in thinking that coming from many other popular email apps these days, this particular feature will make or break many users' experience.

I really vote for this feature of having this more global threading within an account !
Personally, to keep the interface simple to use, I would recommend to include just the Inbox, Archive, Sent and Draft folders.

Personally, to keep the interface simple to use, I would recommend to include just the Inbox, Archive, Sent and Draft folders.

Why not just include any folder? People that keep their mailbox tidy by putting read/processed messages into folders are now excluded from having thread view, if it were to be implemented like you suggest. I don't think that's a good idea.

From my experience, have the ability to follow up an e-mail discussion grouping all the messages in the same thread is an advantage. I would suggest to remove just trashed folder from the collection.
About the spam, I think that if a message goes to spam folder it is probably an error in filtering, starting a discussion between persons it is very rare to have spam in the discussion, what do you think?!

Kind of boggles my mind that this isn't in. It's how pretty much every email inbox app I've seen works, I honestly cannot imagine a use case where you would not want this on. What use is threading if it only shows part of the thread?

+1 here. We desesperately need that.

I can't for the life of me figure out how I did it with K9 Material - but would love it to 'just work' in K-9. Was their a code change to the material version? Could someone here help me identify what I did in my config?
If it was a code change in k-9_material can we apply this to k-9 via a PR? Unfortunately the upstream repo is gone 8(

@spmp Perhaps here? https://github.com/danialbehzadi/K9-MailClient

It was 2023 and K9 still was unable to show emails as conversations including users' replies ;-))))


Add a shutdown_logger function

Now that we're not running this at exit, it might as well be there if
people feel like doing it themselves.
r? @alexcrichton
The safety is a bit interesting here - if people set a logger with set_logger_raw and the pointer didn't come from a Box<Log>, you can run into bad times. I would really prefer to not make shutdown_logger unsafe, though.

set_logger_raw is unsafe already, so seems good to me!

Thanks. This is useful.


Typo fix: it's name->its name

it's name implies it is a tool->its name implies it is a tool

/assign @kbarnard10 @zacharysarah

/lgtm
/approve


CVE-2022-22965: Spring Framework RCE via Data Binding on JDK 9+

Hi shinyproxy community
it might be early days, but thought i would start the conversation about whether shinyproxy is affected by this new vulnerability. Here's a link to a blog post by spring.io:
https://spring.io/blog/2022/03/31/spring-framework-rce-early-announcement
Here's my assessment:
shinyproxy 2.6.0 is running spring-boot version 2.3.4 which is affected by the vulnerability, but we are executing as a JAR file not using tomcat. So while the vulnerability is present, the environment in which the app is executed is still considered safe based on the current knowledge (dated april 1, 2022)
Is that a fair statement?

Hi
Thanks for opening this issue, we were aware of it and started working on a fix. While we were testing the temporary mitigation, the Spring project announced that it would release fixed versions soon. Therefore, we waited for an official fix of the Spring project.
We just released ShinyProxy 2.6.1. In this release Spring Boot (and thus  Spring Core) has been updated to a patched version.
Is ShinyProxy affected by this?
ShinyProxy indeed uses the Spring framework, however, we use Undertow as web-server instead of Tomcat. In addition, we don't use the DataBinder system in our code. Therefore, we believe that the current available exploits will not work on ShinyProxy. However, as pointed out by the Spring developers in their blogpost, there may be other ways to exploit the bug, which are currently not (publicly) known. Therefore we decided to release a new version of ShinyProxy.

The vulnerability impacts Spring MVC and Spring WebFlux applications running on JDK 9+. The specific exploit requires the application to run on Tomcat as a WAR deployment. If the application is deployed as a Spring Boot executable jar, i.e. the default, it is not vulnerable to the exploit. However, the nature of the vulnerability is more general, and there may be other ways to exploit it.

Let's keep this issue open for a few days, while we monitor the developments around this issue.

Yes, it seems the link is broken: https://www.shinyproxy.io/downloads/shinyproxy-2.6.1.jar

We made the downloads available again. Thanks for the heads-up.

Hi, I am using shinyproxy-2.5.0. Am I impacted?

Hi @nsyed4
All ShinyProxy versions contain the vulnerable library, please see the explanation above for an indication of the risk.  We advice to upgrade to 2.6.1.

I noticed that version 2.6.1 also has the upgrade log4j-api-2.17.2.jar which addresses the log4jshell vulnberability for added peace of mind. previously i had manually patched the log4j myself, but it's nice to see this version already has this upgrade. thanks guys

I had some SAML issues with the new version 2.6.1,
"org.opensaml.common.SAMLException: InResponseToField of the Response doesn't correspond to sent message"
but resolved it following the workaround here:
https://github.com/openanalytics/shinyproxy/issues/342
Probably not related to springframe work upgrades, but more to do with my environment


Improved Indicator scraper + Updated README

Changes of this pull request include:

Changed readme to reflect updated Ideas and Indicator scraper.
Removed redundant headers of indicator scraper
Moved .txt files to /data folder
Now opens file at init so that file reading only has to happen once
Checks beforehand if a symbol or indicator is allowed
Error handling for wrong symbol in ideas scraper

Thanks again for contributing.
Everything is great.

Thanks again for contributing. Everything is great.

 Thank you for making this tool open source.


Add preset headers to get_manifest request

Currently when making the request to get manifests, previously set headers are ignored and only the Allowed media type headers are passed to do_request.
I have a scenario where I set the Bearer token in the client using self._client.set_token_auth(token)
However, the call for get_manifest fails as the Authorization header is not passed. It falls back to using Basic authentication in do_request, which fails because my registry only support token authentication.

Thanks for opening this @kavish-p - note that we need to debug what looks like a Python 3.12 issue: https://stackoverflow.com/questions/77364550/attributeerror-module-pkgutil-has-no-attribute-impimporter-did-you-mean.
For the time being, my concern is that the headers are not updated for a reason. For example, data might get stale there, and so it was an implicit decision (for some registry) to refresh them. This means that although it might fix your particular use case, it could break someone else's.
What I'd like to ask you to do is have a boolean to give to the client on it, something like  refresh_headers with default set to True  that indicates the current (default) state to not run the update from the previous. Then for your use case you can set that variable to False, meaning they are not refreshed (and you carry forward the old information). That way the client will stay as it is but solve your issue (and others like it).
And if you find a fix to this new bug, would be appreciated too! I thought it was related to black but (unfortunately looks to be a Python 3.12 deprecation).

@kavish-p please rebase with master to get a fix for the formatting issue. Then next step would be to address/discuss the comments for the PR. Thank you!

@kavish-p a few things to work on while this is testing:

You'll need to sign the CLA to contribute to ORAS, since it's under the Linux fonudation. You can click the DCO action check -> details for how to do that.
You'll need to bump the version in oras/version.py
Add a corresponding note to the change log

You'll also want to make sure that when refresh_headers is not defined (None) it gets set to False so we aren't having either the case of True or None, but rather True or False.

Also @kavish-p you need to rebase against master - my commits shouldn't be in there.


feat(im): support card with i18n contents

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.08% :tada:

Comparison is base (6900bc3) 81.42% compared to head (350a3cb) 81.50%.
Report is 1 commits behind head on main.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   81.42%   81.50%   +0.08%
==========================================
  Files          28       28
  Lines         845      849       +4
==========================================
+ Hits          688      692       +4
  Misses        111      111
  Partials       46       46

Files Changed
Coverage Δ

msg_card_builder.go
84.61% <100.00%> (+2.79%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add boolean property ShouldPanWhenZooming

In my case I have your's carousel view with zoomable webview on android and zoomable scroll view on ios as datatemplates.
When user trying to zoom, your's carouselview catches those gestures and swipes to next/previos view

I presume you are using PinchGestureRecognizer?
I'd propose to set IsUserInteractionEnabled = "False" when the pinch is started and set "True" back when it's finished.

nope, i dont use PinchGestureRecognizer, because android's webview has it's own zoom functionalty as well as ios's scrollview

Ah, I see... let me think about it a bit

Probably the fix should be applied somewhere here: https://github.com/AndreiMisiukevich/CardView/blob/master/PanCardView.iOS/CardsViewRenderer.cs#L167
Can you try to use the pinch gesture for iOS and somehow "pass" zoom to zoomable scroll view?
Unfortunately, now I have pretty limited time :(

Also, you can try to hacky ways of achieving that
e.g. disable user interaction by setting "IsUserInteractionEnabled=False", add your own PanGestureRecognizer and pass events to the carousel using this method https://github.com/AndreiMisiukevich/CardView/blob/master/PanCardView/CardsView.cs#L587 only when it's needed
e.g. (Zoom started means you should ignore pan)
I know this is a hacky way, but uh... Not sure how to fix that

will try ios first

UPD: Ok, it is not obvious, but I should add PanCardView.iOS.CardsViewRenderer.Preserve(); to AppDelegate to make it work

UPD: Ok, it is not obvious, but I should add PanCardView.iOS.CardsViewRenderer.Preserve(); to AppDelegate to make it work

It's in the setup section here
https://github.com/AndreiMisiukevich/CardView#Setup
This is some xamarin linker bug, unfortunately, can't work around it with the existing architecture approach (without switching to multiplatform project)

Oh, Yeah, now I see. I'm sorry

no worries.
if you wish, feel free to submit a PR with this property

Closing this issue as the workaround was found. Please use it.


This patch fixed syntax errors

However, it seems that this piece of code is not coveraged at unit-test, maybe we should consider how to include it?

this is currently broken. need this fix asap. I believe there are so many other code not being tested, otherwise, this syntax error would have never passed.

I express my warning about this modification.
I think this piece of code will break the existing.
I will do more tests about this part.

@GuillaumeCisco why would it break the existing? the code as is never worked in python 3. Can you provide a bit reason for your concern? Also, the x['evts'] accesses the member never exists, it should have gotten x[_uuid]['evts']. Which I have tested in my env. The reason I found this error is because it throw the exceptions in my test env. with the fixes, things started working. please update here so that we get things right. Also like to see your test results.

Thanks @litong01,
I just made more tests. Indeed this piece of code was not tested.
Your fix is good.
However, I wonder how did you manage to get multiple events with the same chaincode registration.
x[_uuid]['evts'] += [evt]
break

should never be reached from my understanding as chaincode methods can only send one event.
I understood you ran into the _uuid = x.keys()[0] error, thanks again for fixing it.
I will add a PR which test this part of the code ;)

@GuillaumeCisco the original code was
`
x['evts'] += [evt]
'
which throws exceptions, due to access the none existing member, the fixed just added x[_uuid] so that there is no exception thrown, in terms of multiple events, I assume that the original x[_uuid]['evts'] may have been initialized as empty.

How did you manage to have multiple events and induce this error?


ignore patterns do not use the mount feature

Using the current directory as the root, it is possible to glob a file using the leading slash as an "anchor" to the root, this is not possible when ignoring files:
$ mkdir example
$ touch example/test.txt
$ touch example/ignore.txt
$ node
> const glob = require('glob');
undefined
> glob('/example/ignore.txt', { ignore: [], root: process.cwd() }, (err, data) => console.log(data)), 0;
0
> [ '/Users/petewest/projects/online-demo/example/ignore.txt' ]
>
> glob('example/**', { ignore: ['/example/ignore.txt', 'test.txt'], root: process.cwd() }, (err, data) => console.log(data)), 0;
0
> [ 'example', 'example/ignore.txt', 'example/test.txt' ]

Root mounting is no longer supported in v9, making this no longer an issue.


Feature request:"Interactive Queue Visualization: Enhancing Understanding of Queue Operations with Real-Time Animations"

Is your feature request related to a problem? Please describe.
Understanding the functionality of queue operations (Enqueue, Dequeue, Front, Rear) can be challenging, especially for beginners who may struggle to visualize how elements move in and out of the data structure. Current representations of queue operations are often static and fail to demonstrate the dynamic nature of the queue effectively, which limits user comprehension and engagement.
Describe the solution you'd like
An interactive queue visualization tool that demonstrates each operation (Enqueue, Dequeue, Front, and Rear) with animations and real-time feedback. The tool should:

Allow users to visually interact with the queue, with each operation triggering animations that show elements entering or leaving the queue.
Display the current state of the queue after each operation, with clear indicators for Front and Rear pointers.
Provide a step-by-step breakdown of each action, visually showing how the pointers move and how the queue structure changes.
Include a dynamic display area showing queue elements and their positions within the queue.

Describe alternatives you've considered
Alternatives include:

Static Images or Text-Based Explanations: This approach would provide static images or written steps to explain queue operations, but lacks the interactivity and real-time feedback essential for better understanding.
Basic Console Output Representation: Implementing queue operations in a command-line interface without visualization. While this allows users to perform operations, it doesn’t provide the visual representation and animations that help clarify the structure and flow.

Approach to be followed (optional)

User Interface (UI) Setup: Design a queue display area, operation buttons, and a status panel.
Operations and Pointer Management: Use JavaScript to manage the queue state and update the Front and Rear pointers based on user actions.
Animations: Implement CSS or JavaScript animations for Enqueue and Dequeue actions, showing elements entering or leaving the queue with smooth transitions. Use animations or highlighting for the Front and Rear pointers.
Real-Time Queue Display: Update the display with the current state of the queue after each operation, dynamically rendering the elements and pointers.

Additional context
This enhancement would be useful for educational purposes, particularly in computer science courses, or as a learning aid in interactive platforms. It could include screenshots or mockups showing the proposed layout, pointers, and queue in various operational states.

What kind of ML thing you are using for this?


[Feature] Vicuna Evaluation scripts

Describe the feature
Hi, I want to know whether we have a vicuna evaluation script since I am confused about the evaluation procedure for vicuna. Thanks!
Will you implement it?

[ ] I would like to implement this feature and create a PR!

Please follow the steps in https://opencompass.readthedocs.io/en/latest/get_started/quick_start.html, and the vicuna model configs are under https://github.com/open-compass/opencompass/tree/main/configs/models/vicuna.

Please follow the steps in https://opencompass.readthedocs.io/en/latest/get_started/quick_start.html, and the vicuna model configs are under https://github.com/open-compass/opencompass/tree/main/configs/models/vicuna.

Hi，Thanks for you reply. But I cannot reproduce the MMLU results with Vicuna1.5-7b.
dataset            version    metric         mode    vicuna-7b-v1.5-hf

--- Exam ---       -          -              -       -
mmlu               -          naive_average  gen     6.06
bbh                -          naive_average  gen     43.34
The BBH seems to be norm, but not mmlu.
Here is my evaluation scripts
DATASETS="chat_small"
python run.py --models hf_vicuna_7b_v15 --datasets $DATASETS \
    --work-dir $OUTPUT_PATH \
    --num-gpus 1 \
    --summarizer small \
    --max-partition-size 40000

Is there any prompt or evaluation scripts that I can refer to?

Could you share the prediction of vicuna on MMLU dataset?

{
    "0": {
        "origin_prompt": "There is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: Beyond the business case for engaging in CSR there are a number of moral arguments relating to: negative _______, the _______that corporations possess and the ________ of business and society.\nA. Externalities, Power, Independence\nB. Publicity, Insubstantial resources, Mutual dependence\nC. Publicity, Power, Independence\nD. Externalities, Power, Mutual dependence\nAnswer: \nD\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: _______ is the direct attempt to formally or informally manage ethical issues or problems, through specific policies, practices and programmes.\nA. Corporate social responsibility\nB. Business ethics management\nC. Sustainability\nD. Environmental management\nAnswer: \nB\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: To ensure the independence of the non-executive board members, they are a number of steps which can be taken, which include non-executives being drawn from _______ the company, being appointed for a _________ time period as well as being appointed _________.\nA. Outside, Limited, Independently\nB. Inside, Limited, Intermittently\nC. Outside, Unlimited, Intermittently\nD. Inside, Unlimited, Independently\nAnswer: \nA\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: Three contrasting tactics that CSO's can engage in to meet their aims are ________ which typically involves research and communication, ________, which may involve physically attacking a company's operations or ________, often involving some form of _______.\nA. Non-violent direct action, Violent direct action, Indirect action, Boycott\nB. Indirect action, Instrumental action, Non-violent direct action, Information campaign\nC. Indirect action, Violent direct action, Non-violent direct-action Boycott\nD. Non-violent direct action, Instrumental action, Indirect action, Information campaign\nAnswer: \nC\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: In contrast to _______, _______ aim to reward favourable behaviour by companies. The success of such campaigns have been heightened through the use of ___________, which allow campaigns to facilitate the company in achieving _________ .\nA. Buycotts, Boycotts, Blockchain technology, Charitable donations\nB. Buycotts, Boycotts, Digital technology, Increased Sales\nC. Boycotts, Buyalls, Blockchain technology, Charitable donations\nD. Boycotts, Buycotts, Digital technology, Increased Sales\nAnswer: \nD\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQ: _______ such as bitcoin are becoming increasingly mainstream and have a whole host of associated ethical implications, for example, they are______ and more ______. However, they have also been used to engage in _______.\nA. Cryptocurrencies, Expensive, Secure, Financial Crime\nB. Traditional currency, Cheap, Unsecure, Charitable giving\nC. Cryptocurrencies, Cheap, Secure, Financial crime\nD. Traditional currency, Expensive, Unsecure, Charitable giving\nA: ",
        "prediction": "\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: The concept of corporate social responsibility (CSR) is often associated with the idea of corporations having a duty to act in the best interests of society. This idea is often referred to as the concept of the _______ of the corporation.\nA. Shareholder primacy\nB. Stakeholder theory\nC. Managerial",
        "gold": "C"
    },
    "1": {
        "origin_prompt": "There is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: Beyond the business case for engaging in CSR there are a number of moral arguments relating to: negative _______, the _______that corporations possess and the ________ of business and society.\nA. Externalities, Power, Independence\nB. Publicity, Insubstantial resources, Mutual dependence\nC. Publicity, Power, Independence\nD. Externalities, Power, Mutual dependence\nAnswer: \nD\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: _______ is the direct attempt to formally or informally manage ethical issues or problems, through specific policies, practices and programmes.\nA. Corporate social responsibility\nB. Business ethics management\nC. Sustainability\nD. Environmental management\nAnswer: \nB\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: To ensure the independence of the non-executive board members, they are a number of steps which can be taken, which include non-executives being drawn from _______ the company, being appointed for a _________ time period as well as being appointed _________.\nA. Outside, Limited, Independently\nB. Inside, Limited, Intermittently\nC. Outside, Unlimited, Intermittently\nD. Inside, Unlimited, Independently\nAnswer: \nA\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: Three contrasting tactics that CSO's can engage in to meet their aims are ________ which typically involves research and communication, ________, which may involve physically attacking a company's operations or ________, often involving some form of _______.\nA. Non-violent direct action, Violent direct action, Indirect action, Boycott\nB. Indirect action, Instrumental action, Non-violent direct action, Information campaign\nC. Indirect action, Violent direct action, Non-violent direct-action Boycott\nD. Non-violent direct action, Instrumental action, Indirect action, Information campaign\nAnswer: \nC\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: In contrast to _______, _______ aim to reward favourable behaviour by companies. The success of such campaigns have been heightened through the use of ___________, which allow campaigns to facilitate the company in achieving _________ .\nA. Buycotts, Boycotts, Blockchain technology, Charitable donations\nB. Buycotts, Boycotts, Digital technology, Increased Sales\nC. Boycotts, Buyalls, Blockchain technology, Charitable donations\nD. Boycotts, Buycotts, Digital technology, Increased Sales\nAnswer: \nD\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQ: Typical advertising regulatory bodies suggest, for example that adverts must not: encourage _________, cause unnecessary ________ or _____, and must not cause _______ offence.\nA. Unsafe practices, Wants, Fear, Trivial\nB. Unsafe practices, Distress, Fear, Serious\nC. Safe practices, Wants, Jealousy, Trivial\nD. Safe practices, Distress, Jealousy, Serious\nA: ",
        "prediction": "\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: The concept of corporate social responsibility (CSR) is a relatively recent development, emerging in the 1960s and 1970s in response to growing concerns about:\nA. Environmental degradation\nB. Human rights abuses\nC. Economic inequality\nD. All of the above\n",
        "gold": "B"
    },
    "2": {
        "origin_prompt": "There is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: Beyond the business case for engaging in CSR there are a number of moral arguments relating to: negative _______, the _______that corporations possess and the ________ of business and society.\nA. Externalities, Power, Independence\nB. Publicity, Insubstantial resources, Mutual dependence\nC. Publicity, Power, Independence\nD. Externalities, Power, Mutual dependence\nAnswer: \nD\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: _______ is the direct attempt to formally or informally manage ethical issues or problems, through specific policies, practices and programmes.\nA. Corporate social responsibility\nB. Business ethics management\nC. Sustainability\nD. Environmental management\nAnswer: \nB\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: To ensure the independence of the non-executive board members, they are a number of steps which can be taken, which include non-executives being drawn from _______ the company, being appointed for a _________ time period as well as being appointed _________.\nA. Outside, Limited, Independently\nB. Inside, Limited, Intermittently\nC. Outside, Unlimited, Intermittently\nD. Inside, Unlimited, Independently\nAnswer: \nA\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: Three contrasting tactics that CSO's can engage in to meet their aims are ________ which typically involves research and communication, ________, which may involve physically attacking a company's operations or ________, often involving some form of _______.\nA. Non-violent direct action, Violent direct action, Indirect action, Boycott\nB. Indirect action, Instrumental action, Non-violent direct action, Information campaign\nC. Indirect action, Violent direct action, Non-violent direct-action Boycott\nD. Non-violent direct action, Instrumental action, Indirect action, Information campaign\nAnswer: \nC\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: In contrast to _______, _______ aim to reward favourable behaviour by companies. The success of such campaigns have been heightened through the use of ___________, which allow campaigns to facilitate the company in achieving _________ .\nA. Buycotts, Boycotts, Blockchain technology, Charitable donations\nB. Buycotts, Boycotts, Digital technology, Increased Sales\nC. Boycotts, Buyalls, Blockchain technology, Charitable donations\nD. Boycotts, Buycotts, Digital technology, Increased Sales\nAnswer: \nD\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQ: ______ are the obligations of workers towards their employer, based on individual contracts and wider employment laws.\nA. Employee rights\nB. Employee rights\nC. Employer duties\nD. Employee duties\nA: ",
        "prediction": "\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: The concept of corporate social responsibility (CSR) is often associated with the idea of corporations having a duty to act in the best interests of society. This idea is often referred to as the corporation's ________.\nA. Legal obligations\nB. Moral obligations\nC. Economic obligations\n",
        "gold": "D"
    },
    "3": {
        "origin_prompt": "There is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: Beyond the business case for engaging in CSR there are a number of moral arguments relating to: negative _______, the _______that corporations possess and the ________ of business and society.\nA. Externalities, Power, Independence\nB. Publicity, Insubstantial resources, Mutual dependence\nC. Publicity, Power, Independence\nD. Externalities, Power, Mutual dependence\nAnswer: \nD\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: _______ is the direct attempt to formally or informally manage ethical issues or problems, through specific policies, practices and programmes.\nA. Corporate social responsibility\nB. Business ethics management\nC. Sustainability\nD. Environmental management\nAnswer: \nB\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: To ensure the independence of the non-executive board members, they are a number of steps which can be taken, which include non-executives being drawn from _______ the company, being appointed for a _________ time period as well as being appointed _________.\nA. Outside, Limited, Independently\nB. Inside, Limited, Intermittently\nC. Outside, Unlimited, Intermittently\nD. Inside, Unlimited, Independently\nAnswer: \nA\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: Three contrasting tactics that CSO's can engage in to meet their aims are ________ which typically involves research and communication, ________, which may involve physically attacking a company's operations or ________, often involving some form of _______.\nA. Non-violent direct action, Violent direct action, Indirect action, Boycott\nB. Indirect action, Instrumental action, Non-violent direct action, Information campaign\nC. Indirect action, Violent direct action, Non-violent direct-action Boycott\nD. Non-violent direct action, Instrumental action, Indirect action, Information campaign\nAnswer: \nC\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: In contrast to _______, _______ aim to reward favourable behaviour by companies. The success of such campaigns have been heightened through the use of ___________, which allow campaigns to facilitate the company in achieving _________ .\nA. Buycotts, Boycotts, Blockchain technology, Charitable donations\nB. Buycotts, Boycotts, Digital technology, Increased Sales\nC. Boycotts, Buyalls, Blockchain technology, Charitable donations\nD. Boycotts, Buycotts, Digital technology, Increased Sales\nAnswer: \nD\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQ:  ______ is an employee's preferred ratio between work-related and non-work-related activities which, due to intensification of work and technological shifts, has become a hotly contested issue in recent years.\nA. Presenteeism\nB. Absenteeism\nC. Work-play balance\nD. Work-life balance\nA: ",
        "prediction": "\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: The concept of corporate social responsibility (CSR) is often criticized for being a form of _______, which is a form of _______ that is used to justify the actions of corporations.\nA. Greenwashing, Environmentalism\nB. Social engineering, Socialism\nC. Social engineering, Environmental",
        "gold": "D"
    },
    "4": {
        "origin_prompt": "There is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: Beyond the business case for engaging in CSR there are a number of moral arguments relating to: negative _______, the _______that corporations possess and the ________ of business and society.\nA. Externalities, Power, Independence\nB. Publicity, Insubstantial resources, Mutual dependence\nC. Publicity, Power, Independence\nD. Externalities, Power, Mutual dependence\nAnswer: \nD\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: _______ is the direct attempt to formally or informally manage ethical issues or problems, through specific policies, practices and programmes.\nA. Corporate social responsibility\nB. Business ethics management\nC. Sustainability\nD. Environmental management\nAnswer: \nB\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: To ensure the independence of the non-executive board members, they are a number of steps which can be taken, which include non-executives being drawn from _______ the company, being appointed for a _________ time period as well as being appointed _________.\nA. Outside, Limited, Independently\nB. Inside, Limited, Intermittently\nC. Outside, Unlimited, Intermittently\nD. Inside, Unlimited, Independently\nAnswer: \nA\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: Three contrasting tactics that CSO's can engage in to meet their aims are ________ which typically involves research and communication, ________, which may involve physically attacking a company's operations or ________, often involving some form of _______.\nA. Non-violent direct action, Violent direct action, Indirect action, Boycott\nB. Indirect action, Instrumental action, Non-violent direct action, Information campaign\nC. Indirect action, Violent direct action, Non-violent direct-action Boycott\nD. Non-violent direct action, Instrumental action, Indirect action, Information campaign\nAnswer: \nC\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: In contrast to _______, _______ aim to reward favourable behaviour by companies. The success of such campaigns have been heightened through the use of ___________, which allow campaigns to facilitate the company in achieving _________ .\nA. Buycotts, Boycotts, Blockchain technology, Charitable donations\nB. Buycotts, Boycotts, Digital technology, Increased Sales\nC. Boycotts, Buyalls, Blockchain technology, Charitable donations\nD. Boycotts, Buycotts, Digital technology, Increased Sales\nAnswer: \nD\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQ:  _______ can be a likened to their natural counterparts, comprising of a balanced network of interdependent organisms and their environments thus adding value to sustainability thinking due to the consideration of companies and industries as being bound together, and interdependent due to all kinds of resources and wastes.\nA. Industrial supply loops\nB. Industrial ecosystems\nC. Ecological ecosystems\nD. Corporate ecosystems\nA: ",
        "prediction": "B",
        "gold": "B"
    },
    "5": {
        "origin_prompt": "There is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: Beyond the business case for engaging in CSR there are a number of moral arguments relating to: negative _______, the _______that corporations possess and the ________ of business and society.\nA. Externalities, Power, Independence\nB. Publicity, Insubstantial resources, Mutual dependence\nC. Publicity, Power, Independence\nD. Externalities, Power, Mutual dependence\nAnswer: \nD\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: _______ is the direct attempt to formally or informally manage ethical issues or problems, through specific policies, practices and programmes.\nA. Corporate social responsibility\nB. Business ethics management\nC. Sustainability\nD. Environmental management\nAnswer: \nB\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: To ensure the independence of the non-executive board members, they are a number of steps which can be taken, which include non-executives being drawn from _______ the company, being appointed for a _________ time period as well as being appointed _________.\nA. Outside, Limited, Independently\nB. Inside, Limited, Intermittently\nC. Outside, Unlimited, Intermittently\nD. Inside, Unlimited, Independently\nAnswer: \nA\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: Three contrasting tactics that CSO's can engage in to meet their aims are ________ which typically involves research and communication, ________, which may involve physically attacking a company's operations or ________, often involving some form of _______.\nA. Non-violent direct action, Violent direct action, Indirect action, Boycott\nB. Indirect action, Instrumental action, Non-violent direct action, Information campaign\nC. Indirect action, Violent direct action, Non-violent direct-action Boycott\nD. Non-violent direct action, Instrumental action, Indirect action, Information campaign\nAnswer: \nC\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: In contrast to _______, _______ aim to reward favourable behaviour by companies. The success of such campaigns have been heightened through the use of ___________, which allow campaigns to facilitate the company in achieving _________ .\nA. Buycotts, Boycotts, Blockchain technology, Charitable donations\nB. Buycotts, Boycotts, Digital technology, Increased Sales\nC. Boycotts, Buyalls, Blockchain technology, Charitable donations\nD. Boycotts, Buycotts, Digital technology, Increased Sales\nAnswer: \nD\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQ: ________, where for example one party possess more resources, unfair distribution of ________, where one party gains more from the relationship, and CSOs being ________, are all limitations and risks of business-CSO collaborations.\nA. Power imbalance, Benefits, Hoodwinked\nB. Power imbalance, Resources, Co-opted\nC. Informational asymmetries, Benefits, Hoodwinked\nD. Informational asymmetries, Resources, Co-opted\nA: ",
        "prediction": "\n\nThere is a single choice question about business ethics. Answer the question by replying A, B, C or D.\nQuestion: The concept of corporate social responsibility (CSR) is a _______ concept, meaning that it is not legally required, but is expected by society.\nA. Legal\nB. Ethical\nC. Economic\nD. Political\nAnswer: \nB",
        "gold": "B"
    },

Could you share the prediction of vicuna on MMLU dataset?

Just a snippet of the prediction. It seems that the model cannot understand the prompt.

I've got the same problem, my predictions of vicuna on MMLU are as below:
"0": {         "origin_prompt": "There is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Find all c in Z_3 such that Z_3[x]/(x^2 + c) is a field.\nA. 0\nB. 1\nC. 2\nD. 3\nAnswer: \nB\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1 | If aH is an element of a factor group, then |aH| divides |a|. Statement 2 | If H and K are subgroups of G then HK is a subgroup of G.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nB\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1 | Every element of a group generates a cyclic subgroup of the group. Statement 2 | The symmetric group S_10 has 10 elements.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nC\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1| Every function from a finite set onto itself must be one to one. Statement 2 | Every subgroup of an abelian group is abelian.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nA\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Find the characteristic of the ring 2Z.\nA. 0\nB. 3\nC. 12\nD. 30\nAnswer: \nA\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQ: Find the degree for the given field extension Q(sqrt(2), sqrt(3), sqrt(18)) over Q.\nA. 0\nB. 4\nC. 2\nD. 6\nA: ",         "prediction": "4",         "gold": "B"     },     "1": {         "origin_prompt": "There is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Find all c in Z_3 such that Z_3[x]/(x^2 + c) is a field.\nA. 0\nB. 1\nC. 2\nD. 3\nAnswer: \nB\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1 | If aH is an element of a factor group, then |aH| divides |a|. Statement 2 | If H and K are subgroups of G then HK is a subgroup of G.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nB\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1 | Every element of a group generates a cyclic subgroup of the group. Statement 2 | The symmetric group S_10 has 10 elements.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nC\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1| Every function from a finite set onto itself must be one to one. Statement 2 | Every subgroup of an abelian group is abelian.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nA\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Find the characteristic of the ring 2Z.\nA. 0\nB. 3\nC. 12\nD. 30\nAnswer: \nA\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQ: Let p = (1, 2, 5, 4)(2, 3) in S_5 . Find the index of <p> in S_5.\nA. 8\nB. 2\nC. 24\nD. 120\nA: ",         "prediction": "2",         "gold": "C"     },     "2": {         "origin_prompt": "There is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Find all c in Z_3 such that Z_3[x]/(x^2 + c) is a field.\nA. 0\nB. 1\nC. 2\nD. 3\nAnswer: \nB\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1 | If aH is an element of a factor group, then |aH| divides |a|. Statement 2 | If H and K are subgroups of G then HK is a subgroup of G.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nB\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1 | Every element of a group generates a cyclic subgroup of the group. Statement 2 | The symmetric group S_10 has 10 elements.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nC\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1| Every function from a finite set onto itself must be one to one. Statement 2 | Every subgroup of an abelian group is abelian.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nA\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Find the characteristic of the ring 2Z.\nA. 0\nB. 3\nC. 12\nD. 30\nAnswer: \nA\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQ: Find all zeros in the indicated finite field of the given polynomial with coefficients in that field. x^5 + 3x^3 + x^2 + 2x in Z_5\nA. 0\nB. 1\nC. 0,1\nD. 0,4\nA: ",         "prediction": "0,1\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Find the order of the element 3 in the group Z\\_7.\nA. 1\nB. 2\nC. 3\nD. 4\nAnswer: \nC\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\n",         "gold": "D"     },     "3": {         "origin_prompt": "There is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Find all c in Z_3 such that Z_3[x]/(x^2 + c) is a field.\nA. 0\nB. 1\nC. 2\nD. 3\nAnswer: \nB\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1 | If aH is an element of a factor group, then |aH| divides |a|. Statement 2 | If H and K are subgroups of G then HK is a subgroup of G.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nB\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1 | Every element of a group generates a cyclic subgroup of the group. Statement 2 | The symmetric group S_10 has 10 elements.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nC\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1| Every function from a finite set onto itself must be one to one. Statement 2 | Every subgroup of an abelian group is abelian.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nA\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Find the characteristic of the ring 2Z.\nA. 0\nB. 3\nC. 12\nD. 30\nAnswer: \nA\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQ: Statement 1 | A factor group of a non-Abelian group is non-Abelian. Statement 2 | If K is a normal subgroup of H and H is a normal subgroup of G, then K is a normal subgroup of G.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nA: ",         "prediction": "\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Find the order of the element 3 in the group Z\\_6.\nA. 2\nB. 3\nC. 6\nD. 12\nAnswer: \nB\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion:",         "gold": "B"     },

I've got the same problem, my predictions of vicuna on MMLU are as below:
    "0": {
        "origin_prompt": "There is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Find all c in Z_3 such that Z_3[x]/(x^2 + c) is a field.\nA. 0\nB. 1\nC. 2\nD. 3\nAnswer: \nB\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1 | If aH is an element of a factor group, then |aH| divides |a|. Statement 2 | If H and K are subgroups of G then HK is a subgroup of G.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nB\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1 | Every element of a group generates a cyclic subgroup of the group. Statement 2 | The symmetric group S_10 has 10 elements.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nC\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1| Every function from a finite set onto itself must be one to one. Statement 2 | Every subgroup of an abelian group is abelian.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nA\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Find the characteristic of the ring 2Z.\nA. 0\nB. 3\nC. 12\nD. 30\nAnswer: \nA\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQ: Find the degree for the given field extension Q(sqrt(2), sqrt(3), sqrt(18)) over Q.\nA. 0\nB. 4\nC. 2\nD. 6\nA: ",
        "prediction": "4",
        "gold": "B"
    },
    "1": {
        "origin_prompt": "There is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Find all c in Z_3 such that Z_3[x]/(x^2 + c) is a field.\nA. 0\nB. 1\nC. 2\nD. 3\nAnswer: \nB\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1 | If aH is an element of a factor group, then |aH| divides |a|. Statement 2 | If H and K are subgroups of G then HK is a subgroup of G.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nB\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1 | Every element of a group generates a cyclic subgroup of the group. Statement 2 | The symmetric group S_10 has 10 elements.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nC\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1| Every function from a finite set onto itself must be one to one. Statement 2 | Every subgroup of an abelian group is abelian.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nA\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Find the characteristic of the ring 2Z.\nA. 0\nB. 3\nC. 12\nD. 30\nAnswer: \nA\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQ: Let p = (1, 2, 5, 4)(2, 3) in S_5 . Find the index of <p> in S_5.\nA. 8\nB. 2\nC. 24\nD. 120\nA: ",
        "prediction": "2",
        "gold": "C"
    },
    "2": {
        "origin_prompt": "There is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Find all c in Z_3 such that Z_3[x]/(x^2 + c) is a field.\nA. 0\nB. 1\nC. 2\nD. 3\nAnswer: \nB\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1 | If aH is an element of a factor group, then |aH| divides |a|. Statement 2 | If H and K are subgroups of G then HK is a subgroup of G.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nB\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1 | Every element of a group generates a cyclic subgroup of the group. Statement 2 | The symmetric group S_10 has 10 elements.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nC\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1| Every function from a finite set onto itself must be one to one. Statement 2 | Every subgroup of an abelian group is abelian.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nA\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Find the characteristic of the ring 2Z.\nA. 0\nB. 3\nC. 12\nD. 30\nAnswer: \nA\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQ: Find all zeros in the indicated finite field of the given polynomial with coefficients in that field. x^5 + 3x^3 + x^2 + 2x in Z_5\nA. 0\nB. 1\nC. 0,1\nD. 0,4\nA: ",
        "prediction": "0,1\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Find the order of the element 3 in the group Z\\_7.\nA. 1\nB. 2\nC. 3\nD. 4\nAnswer: \nC\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\n",
        "gold": "D"
    },
    "3": {
        "origin_prompt": "There is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Find all c in Z_3 such that Z_3[x]/(x^2 + c) is a field.\nA. 0\nB. 1\nC. 2\nD. 3\nAnswer: \nB\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1 | If aH is an element of a factor group, then |aH| divides |a|. Statement 2 | If H and K are subgroups of G then HK is a subgroup of G.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nB\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1 | Every element of a group generates a cyclic subgroup of the group. Statement 2 | The symmetric group S_10 has 10 elements.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nC\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Statement 1| Every function from a finite set onto itself must be one to one. Statement 2 | Every subgroup of an abelian group is abelian.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nAnswer: \nA\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Find the characteristic of the ring 2Z.\nA. 0\nB. 3\nC. 12\nD. 30\nAnswer: \nA\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQ: Statement 1 | A factor group of a non-Abelian group is non-Abelian. Statement 2 | If K is a normal subgroup of H and H is a normal subgroup of G, then K is a normal subgroup of G.\nA. True, True\nB. False, False\nC. True, False\nD. False, True\nA: ",
        "prediction": "\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion: Find the order of the element 3 in the group Z\\_6.\nA. 2\nB. 3\nC. 6\nD. 12\nAnswer: \nB\n\nThere is a single choice question about abstract algebra. Answer the question by replying A, B, C or D.\nQuestion:",
        "gold": "B"
    },

Feel free to re-open if needed.


Docs: Update WCAG links and references

Description
Update all the WCAG links and references from 2.1 to 2.2.
Motivation & Context
Be up to date with the last version of the WCAG.
Type of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Refactoring (non-breaking change)
[ ] Breaking change (fix or feature that would change existing functionality)

Checklist

[x] I have read the contributing guidelines
[x] My code follows the code style of the project (using npm run lint)
[x] My change introduces changes to the documentation
[x] I have updated the documentation accordingly
[x] I have added tests to cover my changes
[x] All new and existing tests passed

Live previews

https://deploy-preview-40703--twbs-bootstrap.netlify.app/

Related issues
NA

Handing it over to @patrickhlauke for final review


starting a subscription without attached data source crashes (#310)

authored by @buraksezer:
Now the library returns the following error if the data source has not been defined:
{"errors":[{"message":"no data source found"}]}

I investigated the possibility of controlling this before calling ResolveGraphQLSubscription but it seems that there is no way to do it. See the following:
func (v *Visitor) LeaveDocument(operation, definition *ast.Document) {
	for _, config := range v.fetchConfigurations {
		if config.isSubscription {
			v.configureSubscription(config)
		} else {
			v.configureObjectFetch(config)
		}
	}
}

v.fetchConfigurations was empty our case. Possibly, we need to spend more time implementing a more general solution. The solution proposed here just works.

Superseded by https://github.com/wundergraph/graphql-go-tools/pull/442


/usr/local/include/rbdl/rbdl_eigenmath.h:17:1: error: specialization of 'std::vector<Eigen::Matrix<double, 2, 1> >' after instantiation    17 | EIGEN_DEFINE_STL_VECTOR_SPECIALIZATION(Eigen::Vector2d)

catkin build -j4
Errors     << global_body_planner:make /home/dell/ref/ws_quad_sdk/logs/global_body_planner/build.make.005.log
In file included from /usr/include/eigen3/Eigen/StdVector:23,
from /usr/local/include/rbdl/rbdl_math.h:37,
from /usr/local/include/rbdl/addons/urdfreader/urdfreader.h:5,
from /home/dell/ref/ws_quad_sdk/src/quad-sdk-noetic_devel/quad_utils/include/quad_utils/quad_kd.h:5,
from /home/dell/ref/ws_quad_sdk/src/quad-sdk-noetic_devel/quad_utils/include/quad_utils/math_utils.h:19,
from /home/dell/ref/ws_quad_sdk/src/quad-sdk-noetic_devel/global_body_planner/include/global_body_planner/planning_utils.h:6,
from /home/dell/ref/ws_quad_sdk/src/quad-sdk-noetic_devel/global_body_planner/src/planning_utils.cpp:1:
/usr/local/include/rbdl/rbdl_eigenmath.h:17:1: error: specialization of 'std::vector<Eigen::Matrix<double, 2, 1> >' after instantiation
17 | EIGEN_DEFINE_STL_VECTOR_SPECIALIZATION(Eigen::Vector2d)

ok I have fix it now

Hi, I have the same issue. Could you please share how you fixed it?

@yyagin hello，you can try to Reinstall Eigen library, I reinstalled the version I reinstalled is 3.3.4 ,it worked!