False positive for react/style-prop-object

I have a custom component that accepts a style prop that should be a string. The plugin is throwing an error on it saying it should be an object:
<Icon size="32" icon="document" style="primary" />

Using latest stable of the plugin.

You can currently either disable this rule or change your component's API.
It would be possible to add an option to the rule to whitelist components, but that's not so great because you can have multiple components that share the same name in a codebase but with different APIs and you'd want it to flag on the components where style means the usual thing but not on the components where style means something different. I'm not in favor of adding an option that does this.
Also, there are other rules like forbid-component-props that you will have similar problems with.
I think people generally expect style to be an object in a React codebase, so changing your prop name here would likely improve the readability of your code a little. Some good alternatives might be variant, theme, or color.

react-intl's <FormattedNumber> component also has a style prop that isn't a object.  I thought about adding a whitelist but think the "correct" way to solve this is for those components to rename the prop. The style name already has some baggage.

I understand the intent so in that case it's not a bug, that being said couldn't it be made to only lint the style prop of native elements?

Its intention was to also cover custom components that accept a "style" prop, so they can use it to style the root DOM node they might render.

Hm ok I understand! Closing this since it's not a bug


chore Add log about ccr downstream url and db name

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


container name giving into the script

In the section:
https://docs.microsoft.com/en-us/azure/machine-learning/studio/retrain-machine-learning-model#update-the-azure-storage-information
The 6. point "In the left navigation column, click Containers."
I searched a lot, and it is in the Blob menu point. You can not click on Containers directly.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d4bb1f96-723f-1232-bf39-003119b3a702
Version Independent ID: 2cbccabc-8f45-8be0-d703-fee1b2469cc4
Content: Retrain and deploy a web service - Azure Machine Learning Studio
Content Source: articles/machine-learning/studio/retrain-machine-learning-model.md
Service: machine-learning
Sub-service: studio
GitHub Login: @xiaoharper
Microsoft Alias: amlstudiodocs

@gikan76 Thanks for the feedback. We are investigating into the issue and will update you shortly.

@gikan76 The steps in the documentation are now updated through a PR. The change should be live in 24 hours.

@gikan76 The document is now updated to reflect the correct steps as per portal UI.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag @RohitMungi-MSFT in your reply. We will gladly continue the discussion and we will reopen the issue.


Camera compatibility with external mods

Camera Positions Utility Workshop GitHub

OK (Note: collision won't work due to Shicho's design choice)

TotalyFree Camera Workshop GitHub

OK

Cinematic Camera Extended Workshop GitHub

OK

Enhanced Zoom Continued Workshop GitHub

Incompatible

Important notice
Please never report compatibility issues to external mods. Also, this issue is just a memo, and does not guarantee anything.

Hello, I have found out an incompatibility with Camera Positions Utility - its Disable building collision (and maybe some others too, but disable water collisions works fine) is not working when Shicho is On. And unfortunately Shicho does not allow such feature. Would it be possible to either implement that functionality or find a way to not override the functionality of Camera Positions Utility?

I really appreciate your report. However, it's an intended design choice for Shicho; the collision is meant to be disabled in camera view.
The rationale for this choice is because the game's 3D models are never meant to be crafted to exactly collide like the ones in third-person action games. The buildings in this game are basically just bunch of abstract boxes, so the vanilla game is just adding some arbitrary distance (i.e. the distance between camera & building) when the camera moves. So it's never been a 'collision' anyway.

I see, but could it be possible as improvement in future to add checkbox to enable the collision? The reason is that it seems to me that with the enabled collision I can get a better angle for camera shots/screenshots than with it disabled, when it jumps me on the roof. But I guess that some first person camera mod could help here too if it is about camera angle from street level.


Some questions about the paper

How do I understand $E_{Sam}$ and the corresponding $E^{T-I}_{Sam}$ in the paper? Is it constructed using the positional embedding in the transformer like the learnable embedding $E_{Pos}$ etc. mentioned above?

Exactly. They are just random initialized vanilla positional embeddings.

These paired embeddings share the same weights to label the corresponding text paired datasets

These paired embeddings share the same weights to label the corresponding text paired datasets

Thanks Reply!

Thank you very much for your enthusiastic reply. But I still have some questions about pretraining objectives:
Are the two terms in Formula 4 not equivalent? Why?

What is the value of predictions $p_v$ in Formula 5? Is the value of $p_v$ obtained directly through an MLP layer or will it go through an activation function similar to sigmoid?

How is the conditional causal masked mentioned in Formula 6 done? Is it to mask the last 60% of all tokens, and then use BERT to reconstruct the masked tokens in an autoregressive manner ?

The match process is provided in our released code:
https://github.com/invictus717/MiCo/blob/89c91c9dac68125a18a1a966bd80f9e74e584e80/model/mico.py#L44

The causal pretraining process is exactly as you say, which is intuitive and simple.

If you have any further questions, please feel free to reach out.


signInWithWebUI doesn't work inside UINavigationController

Describe the bug
I have a TabBarController which, as soon as a Tab is clicked, instantiates a new UINavigationController with a SignInViewController (UIViewController) as root. When using
Amplify.Auth.signInWithWebUI(for: .apple, presentationAnchor: self.view.window!)
inside this SignInViewController nothing happens and the Debugger gives me this warning:
Warning: Attempt to present <UINavigationController: 0x7f8ba6872e00>  on <myApp.TabBarController: 0x7f8ba600fa00> which is already presenting <UINavigationController: 0x7f8ba783d600>
To Reproduce
Steps to reproduce the behavior:

Create a UITabBarController
Present a UINavigationController with a UIViewController as root modally on top of the UITabBarController
Call Amplify.Auth.signInWithWebUI(for: .apple, presentationAnchor: self.view.window!)
See error/warning

Expected behavior
The Amplify SignIn UI should be displayed on top of the SignInViewController and allow the user to sign in.
Environment(please complete the following information):

Amplify Framework Version: 1.0.1
Dependency Manager: Cocoapods
Swift Version : 5.0

Device Information (please complete the following information):

Device: iPhone 11, Simulator
iOS Version: iOS 13.5
Specific to simulators: /

@mTRx0 Thanks for reporting this. We'll investigate & see what we can find.

@palpatim  Any updates on this, i am having this issue as well and is blocking my current project. Thanks

Amplify.Auth.signInWithWebUI was trying to present on the windows root view controller and it fails if there is already a view presenting. The PR #635 should fix the issue.


Errors when querying ADCS CA database

When using Get-RevokedReques, Get-IssuedRequest, Get-PendingRequest, Get-FailedRequest and specify additional non-capitalized properties, they fail with:
Exception calling "Add" with "2" argument(s): "An item with the same key has already been added."
At C:\Program Files\WindowsPowerShell\Modules\PSPKI\<IP_ADDRESS>\Server\Get-RequestRow.ps1:121 char:13
+             $Row.Properties.Add($colName, $colVal)
+             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
    + FullyQualifiedErrorId : ArgumentException
Exception calling "Add" with "2" argument(s): "An item with the same key has
already been added."
At C:\Program
Files\WindowsPowerShell\Modules\PSPKI\<IP_ADDRESS>\Server\Get-RequestRow.ps1:121
char:13
+             $Row.Properties.Add($colName, $colVal)
+             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
    + FullyQualifiedErrorId : ArgumentException

The issue is caused by improper property filtering, because Select-Object -Unique is case sensitive.


[MB-8067] Load testing SC & TOO Move Details orders, shipments, and service item APIs

Description
This PR is part of the load testing the GHC API work for additional queries for orders, shipments, and service items on the move details page of SC and TOO users.  The PR to add the tasks to the load testing tool is here https://github.com/transcom/milmove_load_testing/pull/71.
Changes are required in the mymove repo to address the move queue queries returning the order id instead of the move id in the payload response.  This was something that stuck around because the initial implementation relied on the orders id more than the move id at the time.  Now the move locator is standardized in our URLs so we can replace the order id in the queue payloads now.
The other change I noticed was that the ListMTOServiceItems endpoint was accessible from the Services Counselor user, which should not be the case.  I added a basic authorization check to return forbidden for Services Counselor because the move will never have any service items until after the TOO approves the move/shipments.
Reviewer Notes
If I have extra time I'll try to add more fidelity to the seed file when it comes to shipments and service items in our generated moves.
Setup
Add any steps or code to run in this section to help others prepare to run your code:
make db_dev_e2e_populate
make server_run
make office_client_run

Verifying the move id is now in the payload instead of the orders id:

Login as the TOO or SC user
Inspect the data returned from the queue for a single move and note the id value (in the react-query developer tools or in the chrome dev inspector)
Check in your local database whether this id matches what is in the database for that move.

Verifying the services counselor can not make requests for service items:

Launch Postman with your GHC API collection and turn on the cookie interceptor
Login to the office app as a Services Counselor user
Return to postman and make an API request to the ListMTOServiceItems endpoint at move_task_orders/:moveId/mto_service_items

Code Review Verification Steps

[ ] If the change is risky, it has been tested in experimental before merging.
[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Screenshots
If this PR makes visible UI changes, an image of the finished UI can help reviewers and casual
observers understand the context of the changes. A before image is optional and
can be included at the submitter's discretion.
Consider using an animated image to show an entire workflow instead of using multiple images. You may want to use GIPHY CAPTURE for this! 📸
Please frame screenshots to show enough useful context but also highlight the affected regions.

Ready to go!

Thanks! I abandoned it when CircleCI stopped working on Friday.


Issue #89 update go

Fixes

sed replace statements in Makefile

Proposed Changes

Update to go 1.21 and upgrade dependencies

#89 addressed


[QUESTION] Disk schedule issue

We are planning to use Longhorn in our production environment soon, for deploying a large number of blockchain nodes. The underlying storage data will be substantial, with all PVs combined expected to exceed 100 TiB.
Our deployment environment consists of bare metal machines, each with about 2 NVME hard drives of 3.8 TiB, configured in Raid0 (although it's also possible not to set them up in RAID). There are 15 such machines in total. We plan to manage them using Longhorn.
I have a question regarding this setup:
Suppose there are two machines, each with only 100 GiB of space available for Longhorn to schedule. If I declare a PVC of 150 GiB, is it possible to use 100 GiB from Machine A and 50 GiB from Machine B to complete the PV allocation?
Is it recommended to configure Raid0, given that there are certain risks associated with it? If not setting up Raid0, would allowing Longhorn to automatically discover the hard drives be a better choice?

For the first question, sorry we don't support cross node volume allocation. For this feature request, you can follow this thread: https://github.com/longhorn/longhorn/issues/1061. We plan to implement this feature in our v2 data engine.
For the second question, I don't think there is any issue when using Longhorn with RAID0.

Thanks  @ChanYiLin ! Is there a specific release schedule for v2's data engine? Looking forward to this feature?  I think we should be able to do a smooth upgrade with the V2 Engine at a later stage, right?

Sorry it might not happen in the near future.
V2 engine will still be flagged as experimental feature in v1.6 (Jan, 2024) with the goal of GA in v1.7(July, 2024)
For volume cross nodes feature, it may be in the release after v1.7.
We don't have a way to upgrade Volume of V1 engine to V2 engine directly.
However there is still an informal way to do so, one can backup the Volume first and then restore it back with V2 engine.
I would suggest to play with Longhorn in testing environment first to see if it fits your needs


How to expose spark-ui as node-port

Hi Team,
Problem- currently ingress creation is a manual process in our k8 cluster. It does not get get created as part of helm so for every spark application UI we had to create a sperate ingress entry pointing to its service name which is not a feasible solution.
Query- can we make SPARK-UI service as node port in k8-operator to get rid of the above problem. Or can you provide any feasible solution to expose the SPARK_UI so that i do not have to create separate ingress entry for each sparkapplication.
I am using spark-operator:3.0.0 version .

You can specify a ServiceType of NodePort, see https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/1100


Transient network errors not retried (FetchError: network timeout)

Although nodejs-common should implement a retry mechanism using retry-request, it seems some network errors are not being retried (or not respecting the maxRetries option), e.g.:
Failed to pull messages from <subscription> FetchError: network timeout at: https://pubsub.googleapis.com/v1/projects/<project-id>/subscriptions/<subscription>:pull
at Timeout.<anonymous> (/app/index.js:54566)
at listOnTimeout (internal/timers.js:549)
at processTimers (internal/timers.js:492)

Environment details

OS: Linux (cos) on GKE; macOS 10.14.6
Node.js version: v10.22.0
yarn version: 1.22.4
@google-cloud/common version: 3.3.2

Steps to reproduce
Steps to reproduce

Make a request while network connection is down.
Notice that it immediately fails without any retry being made.

Thanks!
Note: This might be related to #473 although the kind of error that is not being retried this time seems to be different.

Hello! I've tried to reproduce this, but could not see the immediate failure. From the looks of the error, you're making the request through the Pub/Sub library? It would be good to see the actual code you're using, as we may need to look elsewhere.
To help test this library directly, I wrote some system tests (PR: #612) that check both types of retries we perform (through retry-request): pre-flight (e.g. no network) and response (e.g. 501). It seems to confirm we are attempting to retry requests correctly. (I did catch one bug, but it's not related to pre-flight errors)

Hello, I am using nodejs-common directly to implement a library to interact with Pub/Sub via HTTP/REST (instead of grpc which is used by the official Pub/Sub library).
The error occurs here:
const { receivedMessages = [] } = await this.client.request({
  body: { returnImmediately, maxMessages },
  method: 'POST',
  uri: `subscriptions/${this.name}:pull`,
  json: true,
}).catch((err) => {
  console.error(`Failed to pull messages from ${this.name}`, err);
  return {};
});

the constuctor looks like this:
class PubSub extends Service {
  constructor(options) {
    const config = {
      baseUrl: `https://pubsub.googleapis.com/v1/projects/${options.projectId}`,
      projectIdRequired: false,
      scopes: [
        'https://www.googleapis.com/auth/iam',
        'https://www.googleapis.com/auth/cloud-platform',
        'https://www.googleapis.com/auth/pubsub',
      ],
      packageJson,
    };
    super(config, options);
  }

and is called with:
const client = new PubSub({
  projectId: GOOGLE_PROJECT_ID,
  credentials: {
    client_email: GOOGLE_CLIENT_EMAIL,
    private_key: GOOGLE_PRIVATE_KEY,
  },
  maxRetries: 10,
});

As a workaround I changed the first block of code, which seems to "resolve" the issue. However I would prefer the library handled this kind of transient errors with more care than I do here. 😜
const { receivedMessages = [] } = await retry(async (bail) => {
  try {
    return await this.topic.client.request({
      body: { returnImmediately, maxMessages },
      method: 'POST',
      uri: `subscriptions/${this.name}:pull`,
      json: true,
    });
  } catch (err) {
    // XXX: Temporary workaround to retry on network errors, see issue:
    // https://github.com/googleapis/nodejs-common/issues/610
    if (err.name !== 'FetchError') {
      bail(err);
      return {};
    }
    throw err;
  }
}).catch((err) => {
  console.error(`Failed to pull messages from ${this.name}`, err);
  return {};
});

Thanks for the code. I'm still not able to figure it out! This code passes both offline and online:
const assert = require('assert');
const common = require('@google-cloud/common');

const MOCK_HOST_PORT = 8118;
const MOCK_HOST = `http://localhost:${MOCK_HOST_PORT}`;

const service = new common.Service({
  baseUrl: MOCK_HOST,
  apiEndpoint: MOCK_HOST,
  scopes: [],
  packageJson: {name: 'tests', version: '1.0.0'},
});

// This mocks what retry-request does to calculate the retry delay
function getMinimumRetryDelay(retryNumber: number) {
  return Math.pow(2, retryNumber) * 1000;
}

let minExpectedResponseTime = 0; // (this turns out to be 6000)
let numExpectedRetries = 2;

while (numExpectedRetries--) {
  minExpectedResponseTime += getMinimumRetryDelay(numExpectedRetries + 1);
}

const timeRequest = Date.now();

service.request(
  {
    uri: '/mock-endpoint-no-response',
  },
  err => {
    const timeResponse = Date.now();
    assert(err.message.includes('ECONNREFUSED') === true);
    assert(timeResponse - timeRequest > minExpectedResponseTime);
  }
);

Is there anything you see there that I can change to reproduce the error?

I will try to gather more information, right now I can only add that the error object contains the attribute type: 'request-timeout' in addition to the message I posted.
Do you think it is possible that it is indeed retrying but not respecting the maxRetries option that is passed to Service constructor?

Hey @vieira, it looks like I was not only wrong, but found a bug along the way. So, a belated sorry, but thank you! are in order.
First, I missed how you were passing maxRetries. It should actually be in the config, as opposed to the options passed to the Service constructor:
class PubSub extends Service {
  constructor(options) {
    const config = {
      baseUrl: `https://pubsub.googleapis.com/v1/projects/${options.projectId}`,
      projectIdRequired: false,
      scopes: [
        'https://www.googleapis.com/auth/iam',
        'https://www.googleapis.com/auth/cloud-platform',
        'https://www.googleapis.com/auth/pubsub',
      ],
      packageJson,
+     maxRetries: options.maxRetries,
    };
    super(config, options);
  }

Also, this is actually a different type of retry, which has its own control:
class PubSub extends Service {
  constructor(options) {
    const config = {
      baseUrl: `https://pubsub.googleapis.com/v1/projects/${options.projectId}`,
      projectIdRequired: false,
      scopes: [
        'https://www.googleapis.com/auth/iam',
        'https://www.googleapis.com/auth/cloud-platform',
        'https://www.googleapis.com/auth/pubsub',
      ],
      packageJson,
      maxRetries: options.maxRetries,
+     noResponseRetries: options.noResponseRetries,
    };
    super(config, options);
  }

Although, I wouldn't use that yet, as it will endlessly loop (that bug I mentioned). A PR is coming to correct that.


GPU is not detected properly when using SLURM

Hi,
I get the following error when using merlin-dataloader:
Description of the error:
The error seems to happen because the GPU does not seem to be detected here: https://github.com/NVIDIA-Merlin/core/blob/2fc6889cc5e9c7fbe497622710bea18c3344e824/merlin/core/compat.py#L26 (I verified nvml.device_get_count() always returns 0 in my case even though there is a GPU available). Not sure if this is because I use SLURM or whether this is a general problem?
As the HAS_GPU variable is set to False then. The concat function from merlin.core.dispatch uses pd.concat instead of the cudf version causing the error.
Potential fix:
Replacing this line with HAS_GPU = True fixes the issue and everything works as expected in my case.
Environment info:
OS: Rocky Linux 8.7
Python: 3.10.9
merlin-core: 0.10.0
merlin-dataloader: 0.0.4
cudf-cu11: 23.02
rmm-cu11: 23.02
dask-cudf: 23.02
I installed both cudf + merlin via pip:
python -m pip install cudf-cu11==23.02 rmm-cu11==23.02 dask-cudf-cu11==23.02 --extra-index-url https://pypi.nvidia.com/
python -m pip install merlin-dataloader
Stacktrace:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)

File ~/Programs/anaconda3/envs/merlin/lib/python3.10/site-packages/merlin/dataloader/loader_base.py:282, in LoaderBase.__next__(self)
    280 def __next__(self):
    281     """Get the next batch."""
--> 282     return self._get_next_batch()

File ~/Programs/anaconda3/envs/merlin/lib/python3.10/site-packages/merlin/dataloader/loader_base.py:349, in LoaderBase._get_next_batch(self)
    347 # get the first chunks
    348 if self._batch_itr is None:
--> 349     self._fetch_chunk()
    351 # try to iterate through existing batches
    352 try:

File ~/Programs/anaconda3/envs/merlin/lib/python3.10/site-packages/merlin/dataloader/loader_base.py:298, in LoaderBase._fetch_chunk(self)
    296 if isinstance(chunks, Exception):
    297     self.stop()
--> 298     raise chunks
    299 self._batch_itr = iter(chunks)

File ~/Programs/anaconda3/envs/merlin/lib/python3.10/site-packages/merlin/dataloader/loader_base.py:767, in ChunkQueue.load_chunks(self, dev)
    765             self.chunk_logic(itr)
    766     else:
--> 767         self.chunk_logic(itr)
    768 except Exception as e:  # pylint: disable=broad-except
    769     self.put(e)

File ~/Programs/anaconda3/envs/merlin/lib/python3.10/site-packages/nvtx/nvtx.py:101, in annotate.__call__.<locals>.inner(*args, **kwargs)
     98 @wraps(func)
     99 def inner(*args, **kwargs):
    100     libnvtx_push_range(self.attributes, self.domain.handle)
--> 101     result = func(*args, **kwargs)
    102     libnvtx_pop_range(self.domain.handle)
    103     return result

File ~/Programs/anaconda3/envs/merlin/lib/python3.10/site-packages/merlin/dataloader/loader_base.py:740, in ChunkQueue.chunk_logic(self, itr)
    737 if spill is not None and not spill.empty:
    738     chunks.insert(0, spill)
--> 740 chunks = concat(chunks)
    741 chunks.reset_index(drop=True, inplace=True)
    742 chunks, spill = self.get_batch_div_chunk(chunks, self.dataloader.batch_size)

File ~/Programs/anaconda3/envs/merlin/lib/python3.10/site-packages/merlin/core/dispatch.py:476, in concat(objs, **kwargs)
    474     return dd.multi.concat(objs)
    475 elif isinstance(objs[0], (pd.DataFrame, pd.Series)) or not HAS_GPU:
--> 476     return pd.concat(objs, **kwargs)
    477 else:
    478     return cudf.core.reshape.concat(objs, **kwargs)

File ~/Programs/anaconda3/envs/merlin/lib/python3.10/site-packages/pandas/util/_decorators.py:311, in deprecate_nonkeyword_arguments.<locals>.decorate.<locals>.wrapper(*args, **kwargs)
    305 if len(args) > num_allow_args:
    306     warnings.warn(
    307         msg.format(arguments=arguments),
    308         FutureWarning,
    309         stacklevel=stacklevel,
    310     )
--> 311 return func(*args, **kwargs)

File ~/Programs/anaconda3/envs/merlin/lib/python3.10/site-packages/pandas/core/reshape/concat.py:294, in concat(objs, axis, join, ignore_index, keys, levels, names, verify_integrity, sort, copy)
     90 @deprecate_nonkeyword_arguments(version=None, allowed_args=["objs"])
     91 def concat(
     92     objs: Iterable[NDFrame] | Mapping[Hashable, NDFrame],
   (...)
    101     copy: bool = True,
    102 ) -> FrameOrSeriesUnion:
    103     """
    104     Concatenate pandas objects along a particular axis with optional set logic
    105     along the other axes.
   (...)
    292     ValueError: Indexes have overlapping values: ['a']
    293     """
--> 294     op = _Concatenator(
    295         objs,
    296         axis=axis,
    297         ignore_index=ignore_index,
    298         join=join,
    299         keys=keys,
    300         levels=levels,
    301         names=names,
    302         verify_integrity=verify_integrity,
    303         copy=copy,
    304         sort=sort,
    305     )
    307     return op.get_result()

File ~/Programs/anaconda3/envs/merlin/lib/python3.10/site-packages/pandas/core/reshape/concat.py:384, in _Concatenator.__init__(self, objs, axis, join, keys, levels, names, ignore_index, verify_integrity, copy, sort)
    379     if not isinstance(obj, (ABCSeries, ABCDataFrame)):
    380         msg = (
    381             f"cannot concatenate object of type '{type(obj)}'; "
    382             "only Series and DataFrame objs are valid"
    383         )
--> 384         raise TypeError(msg)
    386     ndims.add(obj.ndim)
    388 # get the sample
    389 # want the highest ndim that we have, and must be non-empty
    390 # unless all objs are empty

TypeError: cannot concatenate object of type '<class 'cudf.core.dataframe.DataFrame'>'; only Series and DataFrame objs are valid

Thanks for your help!
Felix

Hi Felix, Thanks for reporting this issue.
Based on what you described, I suspect there may be an error initializing NVML in your environment. Please can you try executing the following from a python shell or script and share if any errors or warning are printed out?
import pynvml
pynvml.nvmlInit()

Hi Oliver,
Running
import pynvml
pynvml.nvmlInit()

fixed the issue for me. Everything runs as expected now. Thanks!

@felix0097 the helper function we're using to set HAS_GPU is device_get_count from dask/distributed here.
If this is returning zero for you, while running pynvml.nvmlInit() first changes it to return a non-zero value, that suggests there may be a bug in that device_get_count function we're using.

Are you using a Docker image? that might help us figure out how to reproduce this? The device_get_count function looks like it is written with the intention of handling the pynvml init for us.


Meet w/ Security to determine if Arches->HRIA database viable

Need to determine whether Arches will be able to talk directly to the HRIA database to generate Borden Numbers. Ports will need to be opened from both Arches Test -> HRIA Test DB and Arches Prod -> HRIA Prod DB.
Note that this may have dependencies on Arches target environment decision.
If a direct connection is viable the next step will be to discuss this with full HRIA business, DBA and Vendor team.

@BaldeepPal, @TMcFarland-Heritage - I've created this issue for the discussion w/ NRIDS security group. Once a meeting has been set we can document the decision here.

@BaldeepPal - I missed this in the meeting last week. Can we get security on a call to investigate whether we can do this or not?


feat(learn): Message Board User Stories

Signed-off-by: nhcarrigan<EMAIL_ADDRESS>Checklist:

[X] I have read freeCodeCamp's contribution guidelines.
[X] My pull request has a descriptive title (not a vague title like Update index.md)
[X] My pull request targets the master branch of freeCodeCamp.
[X] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Related #39721

Updates wording of test text to second voice
Standardises description
Migrates boilerplate instructions to /learn

@RandellDawson I pushed a commit here that adds the test descriptions to the instructions - let me know your thoughts on this. Once we've ironed out the approach, I can mirror the changes on the Stock Price app.
/cc @moT01

I have tested everything again and like these new changes.  I approve.


fix(element): correctly infer element type for string arrays

Current dependencies on/for this PR:

main

PR #14   👈

This comment was auto-generated by Graphite.


IBM MQ Admin reports too many connections when IBM MQ source connector is used

We have used IBM MQ source connector to push our data to kafka topics.
Connector plugin is hosted in 2 of the Kafka connect instances present as part of our Kafka cluster.
For the configured Queue manager and channel name, we just have one connector in the Kafka cluster.
But in IBM MQ admin we see 120+ connections/instances created for these 2 connect servers.
Because of these many connections, connector fails and is not able to process any of the messages.
Can you kindly help with the solution for this issue?

Hello Team,
Is there any inputs on this issue ?
Also, one more behavior what we have observed is whenever there is deployments and restarts of connect instances on our connect cluster, we could see count of connections against our MQ is raising.
Is there any way to limit connections on MQ or kafka connector side ?
Thanks a lot,
Rashmi

If you follow the instructions here to make GET /connectors/<connector-name>and GET /connectors/<connector-name>/tasks REST calls then you can see what Kafka Connect is doing. You can also check the logs of the Connect pods to see if there is any error output from the MQ connector.

Hi Dave,
Thanks for your inputs. We have checked these REST call and it gives the task. This connector has just 1 task.
State of the task is running. In connect log we do not see any error related to connections.
But from mq side, there were 450 active connections and we had to restart mq channel to reduce or limit the connections.
What could have been the reason for these many active connection on mq side ?
Thanks a lot,
Rashmi

If you need to debug the connector then you can enable debug-level logging by setting the line log4j.logger.org.apache.kafka.clients.producer=DEBUG in connect-log4j.properties. Be aware that this will create very verbose log files, but it should allow you to identify what is causing the large number of connections.

Hello Team,
We have enabled the logger on connector side. Still couldn't get much clue.
Within the connector, this ibm mq client is being used-
com.ibm.mq.allclient-<IP_ADDRESS>.jar.
Is there any way to enable logging from this client ? If yes, could you please help us on
how to configure this inside our connect-log4j.properties. Thanks!
Regards,
Rashmi

late on this game.. we use the same connector and i don't see this behavior.  At the MQ side number of readers in queue are equal to the number of tasks set in connector json. Does all these connections coming from same IP or 2 of these connect instance ?

Hello, we have the same issue.
We have a Kafka Connect cluster with 3 nodes. The connectors have 1 taks but we get 6 connection in the MQ said, after some time the connections increases and we need to restart MQ channel to reduce or limit the connections.
Connector Version: v1.3.1
@rashmidelampady did you solved the issue? I appreciate any advice on this.
Thanks
Jorge

Hello Jorge,
No we couldn't solve the issue. So we have shifted to enterprise confluent
ibm mq connector which is stable.
On Thu, Jan 19, 2023 at 7:17 AM jahtux @.***> wrote:

Hello, we have the same issue.
We have a Kafka Connect cluster with 3 nodes. The connectors have 1 taks
but we get 6 connection in the MQ said, after some time the connections
increases and we need to restart MQ channel to reduce or limit the
connections.
Connector Version: v1.3.1
https://github.com/ibm-messaging/kafka-connect-mq-source/releases/tag/v1.3.1
@rashmidelampady https://github.com/rashmidelampady did you solved the
issue? I appreciate any advice on this.
Thanks
Jorge
—
Reply to this email directly, view it on GitHub
https://github.com/ibm-messaging/kafka-connect-mq-source/issues/90#issuecomment-1396336681,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF7EGPXI55WUGEJGXLASZPDWTCMMZANCNFSM5BMYOANQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Any updates? Look like there are several isssues related this "sticky MQ connection" one. I requested an IBM support PMR to be openned, this issue has a major impact as it "steals" MQ messages from the sourced queue until we force the whole Kafka Connect cluster to shutdown.

fixed in #114


Update account background

Describe your changes
Update account background to image provided in figma
Link the related issue
Closes #2693
Checklist before requesting a review

[x] Is this PR ready for merge? (Please convert to a draft PR otherwise)
[x] I have performed a self-review of my code.
[x] Did I request feedback from a team member prior to merge?
[x] Does my code following the style guide at docs/CODING-STYLE.md?

@miyuki-eto, this is ready for your review.

this doesnt really feel the same as the mock up. i think it should still have the dark background. the idea was for it to look something like this. happy to work with you to get the correct image etc


Testing of data delivery and graphql

Description
The application should be thoroughly tested to ensure no bugs make it out into production.
I will leave it up to @Kpaubert to decide what parts of the applications should be tested in this issue, and how.
Subtasks

[x] Create test folder- and file structure

Ideas for things to test, feel free to replace/add:

[ ] Test GraphQL query resolution
[x] Test data retrieval (perhaps with mocking)

@FredrikAugust Perhaps hold back a bit on the query resolution so we can close this a bit faster, and use that for the next milestone? I would argue the testing for a functional prototype does not require it. Thoughts?

I'm a bit torn, but I do agree that "moving fast" might be a better approach here.
What we're testing here is essentially just if the MetAPI works as we expect – which is only helpful if it somehow stops working.
On the other hand; most of the other functionality is handled by the GraphQL library – returning the correct data from the POCO to the GraphQL "caller" (client).
I think we can omit the part you discussed here, and create a new issue for it which tests some of the more complex field resolvers – and makes sure that they return the expected content. For this however, we should mock the response of the API to prevent sending a lot of requests.
I think we should generally try to avoid side effects in unit tests (incl. sending requests to third-party APIs). If possible, it would be nice if you could disable the tests that call an API by default, and then we can run them manually every once in a while (perhaps also in CI once we release a new release).

Sounds good!
The mocking branch is quite far behind with regards to commits, and as the testing branch (20-data-delivery-test) has some of the logic I would want for setting up mocking, I think I'll scrap the other one (16-initial-mocking-service). I'll look into mocking libraries, choose one that fits , our use (perhaps bogus as you references here).
I removed one of the checks on #16. So my plan is now:

Merge master into the testing branch (20) so it's not too far behind
Implement mocking
Verify that it works using the tests that already exists, just with mocked data
Implement/plan for how to use the mocking functionality in the actual backend

That sounds like a smart plan! :rocket:


[Star Wars] NPC Add More Custom Skill Slots

The NPC Character Sheet currently only has 5 slots for Skills. Many of the NPCs in the published adventures have more than this even when taking into account the built-in:

Cool
Vigilence
Lightsaber
Brawl
Gunnery
Melee
Ranged Light
Ranged Heavy

For example:
Onslaught at Arda I:

Setenna Hase
General Ran Niall
Commander Danel Qurno

I think a reasonable number for the NPC would be somewhere between 8 - 10 instead of 5.

Which Star Wars sheet is this? Please give the exact name, and also edit the title of the issue to include it.

@keithmedlin I assume this is for one of the FFG sheets, but could you specify which exactly?

This issue is impossible to identify to even begin a fix with the information that has been provided. If there's still an issue here, please recreate the issue with more information.


docs(two-column-layout-example): add base example

Summary
This is the main PR for the Autocomplete with a two-column layout example.
All other PRs will be merged into this one once they have been reviewed.
This specific PR scaffolds an example showing how to integrate Autocomplete with a two-column layout and recent searches + query suggestions.
→ Final Codesandbox preview
Stacked PRs

[ ] Add recent searches and query suggestions plugins #908 (this PR)
[ ] Add products plugin #909
[ ] Add categories, brands and faq plugins #910
[ ] Add articles and popular plugins #911
[ ] Add reshape functions and quick access plugin #912
[ ] Add smart preview feature #913
[ ] Add no results state and popular categories plugin #914

Improvements

Debouncing the query
Smart preview on mobile with double tap (it's not working right now)
Better smart preview UX

Known bugs

On mobile, clicking on an item update the input value and it gets cleared right after

Questions

Should we move the indices to the latency app after review?

@FabienMotte The search box still looks very wide, but we can use our pair session to tackle it.

Sure, let's tweak that together

Empty query state

Have we had a chance to fix the bug that occurred after tapping on a Popular Query on a mobile device (I saw it on Chrome iOS)?
Could we display section title on that state?

Recently searched
Popular searches

Overall

Can we reduce the query terms spacing 48px != 40px like in the Figma. Reasoning: Ideally we want to see the top of the first two products result above the keyboard (a few pixels) to inform the end-user that there is more content after scrolling down.
On recent search, I'd suggest we remove the type ahead icon, and make the trash a X icon (like google) -> listing it here to keep the context, but we should ultimately do it at the Recent Search plugin level, and not just here.


CLOB query halts

Hi,
When I try to query data from a CLOB column the driver halts (everything halts).
Queries over other tables with numeric and char data types work without problems, except I get the "maximum number of cursors exceeded" from time to time, but that is survivable. The halting problem, however, isn't.
This is the function:
func fetchJSON(db *ora.Ses, project string) (string, error) {
        stmt, err := db.Prep(`SELECT JSON_CLOB FROM TABLE WHERE PROJECT_NAME` + EqualQuotes(project), ora.S)
        defer stmt.Close()
        if err != nil {
                return "", err
        }
        fmt.Println("prep passes") // this prints

        rset, err := stmt.Qry()
        if err != nil {
                fmt.Println(err) // this does not
                return "", err
        }
        fmt.Println("query passes") // also doesn't print

        var data string
        if rset.Next() {
                data = rset.Row[0].(string)
        }

        return data, nil
}

This is a problem with go 1.7/1.8 and ora v4.
Any ideas?
Edit: I should probably mention that this is a huge CLOB I'm trying to fetch. Last setup that this works with is: ora v3 and go 1.8.

Strange. We'll have to write a test case to reproduce it.
Try running it, and when halts, hit Ctrl-\ (or send SIGHUP to the process), and inspect/copy here the full stack trace - it'll show where each goroutine is blocked.
And try it with the current master, or bisect where it gone awry.

Thank you for the fast reply.

Ok, check the master (fa34ede8c4f1b83b6c6c6565745e8670629a2b5a)
cd $GOPATH/src/gopkg.in/rana/ora.v4
git fetch origin
git branch -m master M
git checkout -b master origin/master
'cause the defLob.go:50 is already commented out :)

If this helps, I'll push this as a new version (v4.1.9)

Did as you said, but still no new commit.
This is what go define looks like in defLob.go:50
func (def *defLob) define(position int, sqlt C.ub2, gct GoColumnType, rset *Rset) error {
        def.Lock()
        defer def.Unlock()
        def.rset = rset
        def.gct = gct
        def.sqlt = sqlt
        if def.lobs != nil {
                C.free(unsafe.Pointer(&def.lobs[0]))
        }
        rset.RLock()
        fetchLen := rset.fetchLen
        env := rset.stmt.ses.srv.env
        rset.RUnlock()
        def.lobs = (*((*[MaxFetchLen]*C.OCILobLocator)(C.malloc(C.size_t(fetchLen) * C.sof_LobLocatorp))))[:fetchLen]
        if err := def.ociDef.defineByPos(position, unsafe.Pointer(&def.lobs[0]), int(C.sof_LobLocatorp), int(sqlt)); err != nil {
                return err
        }
        prefetchLength := C.boolean(C.TRUE)
        return env.setAttr(unsafe.Pointer(def.ocidef), C.OCI_HTYPE_DEFINE,
                unsafe.Pointer(&prefetchLength), 0, C.OCI_ATTR_LOBPREFETCH_LENGTH)
}

cd $GOPATH/src/gopkg.in/rana
rm -rf ora.v4
git clone https://github.com/rana/ora.git ora.v4
?

That's it. It's working now.
Thank you.

Thanks for the test.
I've published as v4.1.9


Solve Issue #10354 by treating Reset like Measure in ConstrainedReset

Summary
fixes #10354 ConstrainedReschedule raises an error with reset
Details and comments
Reset and Measure (mid-circuit) both provide duration data from the backend, but this is untrustworthy. To reflect this, I added UserWarnings in qiskit/transpiler/passes/scheduling/base_scheduler.py.
That Reset reports duration data is not recognized in ConstrainedReschedule, leading to the error in Issue #10354. Thus, I added the same handling for Reset in ConstrainedReschedule as is used for Measure.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Hunter Kemeny seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Hunter Kemeny seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Async / await cleanup

Removed unnecessary async / await keywords. For simple Task and Task<T> methods you only need to await if you're using the or relying on the result of the task, in these cases we can simply return the task that will represent the asynchronous operation. Additionally, I removed some redundant this keywords while I was in here.
Additionally, I added the "Async" suffix to one of the methods that was missing it.

@jcheng31 are you no longer active on this repository? I would love to see this pull request make its way into the master branch. Thank you

Still around, just a bit busy :(
This looks good - thanks for catching the missing Async method name, especially - though could you resubmit with it merging into develop? I'll make sure it goes out with the next release, hopefully by this weekend :)
The redundant thiss were intentional since that's how StyleCop has it out of the box, but I've seen enough good arguments elsewhere as to why they should be dropped; will go and prune them elsewhere as well if they're still lurking around.

@jcheng31, done...thanks

Merged the new request - thanks again :)


Suspected memory leak - model.predict

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Windows 10
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
NA
TensorFlow installed from (source or binary):
binary wheel via PyPI
TensorFlow version (use command below):
v2.0.0-rc2-26-g64c3d382ca 2.0.0
Python version:
3.6.8
Bazel version (if compiling from source):
NA
GCC/Compiler version (if compiling from source):
NA
CUDA/cuDNN version:
NA
GPU model and memory:
NA

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the current behavior
I'm suspecting a memory leak on keras model.predict (running on cpu only).
Performing model.predict in an infinite loop - demonstrates memory leak trend (~400MB in 30min, please see image below).
This trend happens even though I call gc.collect() on every iteration.
In addition - using gc.get_objects() I can see that every iteration leaks exactly 1298 new objects. Using objgraph the leaked objects are:
tuple                          751101      +741
list                           202237      +197
dict                           155046      +137
Tensor                          26665       +27
TF_Output                       26621       +27
Operation                       26686       +27
_InputList                      26686       +27
Dimension                       15675       +16
set                             18103       +15
TraceableStack                  11629       +12
TensorShape                     10845       +11
builtin_function_or_method      10757        +9
OrderedDict                      8799        +9
weakref                         14739        +6
TensorSpec                       3873        +4
Condition                        2926        +3
deque                            2930        +3
_local                           2925        +3
ObjectIdentitySet                2909        +3
ScopedTFGraph                    2909        +3
GroupLock                        2909        +3
FuncGraph                        2906        +3
ObjectIdentityWeakSet            2908        +3
_EagerDefinedFunction            2904        +3
ScopedTFFunction                 2904        +3
_EagerDefinedFunctionDeleter     2904        +3

Describe the expected behavior
Memory shouldn't increase over time when calling gc.collect() nor should there be objects leaks per prediction.
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
import tensorflow as tf
from collections import defaultdict
import gc
import objgraph

mnist = tf.keras.datasets.mnist

(x_train, y_train), (x_test, y_test) = mnist.load_data()
x_train, x_test = x_train / 255.0, x_test / 255.0

model = tf.keras.models.Sequential([
    tf.keras.layers.Flatten(input_shape=(28, 28)),
    tf.keras.layers.Dense(128, activation='relu'),
    tf.keras.layers.Dropout(0.2),
    tf.keras.layers.Dense(10, activation='softmax')
])

model.compile(optimizer='adam',
              loss='sparse_categorical_crossentropy',
              metrics=['accuracy'])

model.fit(x_train, y_train, epochs=5)

model.evaluate(x_test,  y_test, verbose=2)

def mem_stat():

    objs = gc.get_objects()
    print("total objects count", len(objs))

c = 1
while True:
    print("----------- iter", c)

    model.predict(x_test)

    gc.collect()

    print("mem stat after predict:")
    mem_stat()
    objgraph.show_growth(limit=30)
    c += 1

Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

This seems to be related to this Keras issue. It's hard to say though whether the bug is rooted in Keras or TensorFlow.

I have tried on colab with TF version 2.0 ,2.1.0-dev20191125 and was able to reproduce the issue.Please, find the gist here. Thanks!

Hi @ravikyram,
I run your colab notebook and it seems that at least in terms of objects leak - version 2.1.0dev is stable (I can't see addition of python objects per iteration).
Can you please approve? If you believe it solved in 2.1.0 do you think there will be a fix in 2.0 too or should I wait for 2.1.0?
Thanks!

@awaizman1 you are right, the issues seems to be resolved now. Thank you!


Beautify durations displayed on timetrace status

At the moment, the output of timetrace status looks as follows:
+-----------------+--------------------+-----------------+
| CURRENT PROJECT | WORKED SINCE START |  WORKED TODAY   |
+-----------------+--------------------+-----------------+
| make-coffee     | 8h25m26.147239s    | 8h25m26.147239s |
+-----------------+--------------------+-----------------+

Displaying durations like 8h25m26.147239s is precise, but unnecessary und unreadable. It should rather look something like 8h 25min.

Hi @dominikbraun, May i know in which language it is written?

Hi, timetrace is written in Go. For example, this is the place where the table shown above is being printed:
https://github.com/dominikbraun/timetrace/blob/16b10a97b594a7e73145096e84b6fb9672048df2/cli/status.go#L32-L46

Sorry @dominikbraun, i am not much familiar with Go.
I know python only.

Nevermind 😄

How should seconds be handled? if timetrace status is triggered while the duration is still under 1 minute should the time displayed be  for example 12sec or displayed as 0h 0min until the duration is >= 60 seconds? Also if no full hour is reached yet would the output then be 0h 24min or only 24min?

should the time displayed be for example 12sec or displayed as 0h 0min until the duration is >= 60 seconds?

In general, timetrace's smalles unit are minutes. A record started at 12:00:05 will be the same fail as a record started at 12:00:40. But perhaps it would make sense to display the seconds for convenience in this case. Maybe 0h 0m 12s if duration < 60s and otherwise just 0h 1m?

Also if no full hour is reached yet would the output then be 0h 24min or only 24min?

I'd suggest 0h 24m in that case.

I mean probably not many will do a status right away but 0h 0m 12s would then stick to the other conventions. If > 60 seconds I agree dropping the seconds to only have 0h 1min makes sense!
Ok I will have a look at the functions and what needs to be done.

Closed by #20.


Shell script syntax highlighting

How it looks right now:

How it could look like (I've injected Shell Script language manually):

Due to significant changes introduced by JetBrains, my plugin now faces numerous disruptions. After dedicating substantial effort to this project last year, I find myself needing assistance to move forward. If you're interested in contributing or know someone who might be, please feel free to get involved. I am available to provide guidance through the intricacies of the plugin.


Fixed SAML logout for ADFS

This PR. adds some options to the .env file for configuring the logout with SAML. It also sets the correct NameId in the logout request.
This PR enables:

Signed Logout SAML-Assertions (default is disabled)
Sets the correct email address in the logout assertion
Enables the encoding of lowercase URLs (default is disabled)
some little tweaks in the logout process so that it works with ADFS (theses changes must be enabled in the .env file, without any changes in the .env file the logout process is not altered.)

In ADFS you need to have a Rule like this:
c:[Type == "http://schemas.xmlsoap.org/ws/2005/05/identity/claims/emailaddress"]
 => issue(Type = "http://schemas.xmlsoap.org/ws/2005/05/identity/claims/nameidentifier", Issuer = c.Issuer, OriginalIssuer = c.OriginalIssuer, Value = c.Value, ValueType = c.ValueType, Properties["http://schemas.xmlsoap.org/ws/2005/05/identity/claimproperties/format"] = "urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress", Properties["http://schemas.xmlsoap.org/ws/2005/05/identity/claimproperties/spnamequalifier"] = "https://<FQDN_OF_BOOKSTACK>/saml2/metadata");

and in your .env file you need to add the following lines:
SAML2_SP_CERTIFICATE=MIIFtT... (your cert)
SAML2_SP_PRIVATEKEY=MIIJRAIBADANBgkqhkiG... (your private key)
SAML2_SP_NAME_ID_Format=urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress
SAML2_SP_NAME_ID_SP_NAME_QUALIFIER=https://<FQDN_OF_BOOKSTACK>/saml2/metadata
SAML2_RETRIEVE_PARAMETERS_FROM_SERVER=true
SAML2_LOGOUT_REQUEST_SIGNED=true
SAML2_LOGOUT_RESPONSE_SIGNED=true
SAML2_LOWERCASE_URLENCODING=true

Thanks for offering this @theodor-franke.
To be honest it'll probably take some time before I review this deeply, since I know it's going to consume about a day's worth of effort for me to go through each of the 8 added options to understand their functionality so I can assess the backwards compatibility and testing we'll need to add where possible.
At a first glance, This seems like a lot of new options just to fix ADFS SLS. Are all these changes required to make ADFS SLS work? Or could you describe exactly what was failing for ADFS SLS? If this goes beyond I'd prefer to keep the scope limited to just fixing the ADFS SLS issues unless there's significant demand/response to go outside of that.
In regards to the implementation, I have not functionally checked anything, but one thing I've seen from a quick look is that any env() usages outside of the Config/ directory will need to be altered to use the config system instead like the existing options set. Using env() outside this directory can cause issues, especially for those who cache their config for performance.

I only tried this on our coporate ADFS-Server (windows 2016 so I think its called ADFS4.0) and without these fixes the logout would not work.
The first important thing is the Certificate, ADFS requires the logout-assertion to be signed. The other important thing ist that the correct EntityID is set in this SAML-Assertion. I made all  these Settings and not only one big USE_ADFS Setting because I think that other IDP may need these configs as well.
regarding the env() problem: If you think that this is a big problem I will try to find a solution for this. In my opinion this isnt a big deal because you will only ajust these ones and than (hopfully) never touch them again.

I've been trying to get SAML working with ADFS running on Windows Server 2019 and not having much luck. I've combed the documentation and still haven't had much luck. Since I'm running Windows Server 2019, are these new features/settings required? Does anyone have their working setup documented so I could go off something that is known to work? Any help would be appreciated.

I can't share you my Documentation because I dont work anylonger at the place where I installed this. The docs are a great starting point (https://www.bookstackapp.com/docs/admin/saml2-auth/) and if you want you can write me when you have Problems.


fix(kqp): return one result row per key from stream join actor for left semi strategy

Don't forget to merge into 24-3.


it not diplaying contacts

there is no  chat list it showing,, fully empty.. when i newly instaled it works  good,, but next day when i opens it ,, it not showing chat lists.. everything blank

same as #235 . Pls read the previous issues before creating new ones.


chore: use ipfs-or-gateway to fetch Web UI

Uses ipfs-or-gateway to download Web UI
License: MIT
Signed-off-by: Henrique Dias<EMAIL_ADDRESS>

@lidel perhaps you want to use this on IPFS Companion or even improve the package!


Activate test_lock

Which got deactivated by accident.

Successful PR Checklist:

[ ] Tests

[x] (not applicable?)

[ ] Documentation

[x] (not applicable?)

[x] Had a good time contributing?

Codecov Report

Merging #210 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #210   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           21        21
  Lines          943       943
  Branches        99        99
=========================================
  Hits           943       943

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5829e7...d217a7c. Read the comment docs.


fix confusing log in session.py

androguard gives me a confusing log output  when I tried to load a session.
{} already exists, overwriting!

Looking around session.py I found the weird log in line 46. , maybe it's better to print a more detailed log.

Codecov Report

Merging #828 (571ecb8) into master (99e48e7) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #828      +/-   ##
==========================================
- Coverage   76.83%   76.62%   -0.21%
==========================================
  Files          51       51
  Lines       16293    16175     -118
==========================================
- Hits        12518    12394     -124
- Misses       3775     3781       +6

Impacted Files
Coverage Δ

androguard/session.py
55.85% <100.00%> (ø)

androguard/core/__init__.py
73.68% <0.00%> (-16.39%)
:arrow_down:

androguard/cli/entry_points.py
89.22% <0.00%> (-0.61%)
:arrow_down:

tests/test_decompilerjadx.py
85.71% <0.00%> (-0.50%)
:arrow_down:

androguard/core/analysis/analysis.py
77.77% <0.00%> (-0.32%)
:arrow_down:

androguard/core/bytecodes/axml/__init__.py
79.21% <0.00%> (-0.19%)
:arrow_down:

tests/dataflow_test.py
93.78% <0.00%> (-0.16%)
:arrow_down:

androguard/decompiler/dad/basic_blocks.py
81.78% <0.00%> (-0.15%)
:arrow_down:

androguard/core/mutf8.py
84.09% <0.00%> (-0.09%)
:arrow_down:

androguard/core/bytecodes/apk.py
65.17% <0.00%> (-0.07%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99e48e7...571ecb8. Read the comment docs.


Can't test redux-zero with JEST and TypeScript?

Hi!
I'm getting the following error message when I try to write unit tests for files that access the redux-zero store (just by importing the files, not even writing tests).
Test suite failed to run

    TypeError: (0 , redux_zero_1.default) is not a function

      1 | import createStore from 'redux-zero';
      2 | /** create redux-zero store */
    > 3 | const store = createStore({
        |               ^
      4 |     appDimensions: {
      5 |         width: 0,
      6 |         height: 0

      at Object.<anonymous> (src/data/store.ts:3:15)
      at Object.<anonymous> (src/utils/remoteControl.ts:3:1)

This is how you import it with TypeScript:
import * as createStore from "redux-zero";

It's documented here: https://github.com/redux-zero/redux-zero#how

Hi @matheusml ,
When I do this:
import * as createStore from 'redux-zero';

/** create redux-zero store */
const store = createStore({

TypeScript's linter gives me the following error message for createStore:
This expression is not callable.
      Type 'typeof import("/Users/<...>/node_modules/redux-zero/index")' has no call signatures.


Input's drag functionality is too sensitive for small ranges

If I want an integer value in [0,10], then there are only 11 possible values. Instead of using the full width (or half width) of the slider to adjust through this range, InputNumberDrag accepts tiny movements to adjust. It only takes the width of one character to move through the entire input range.
Using InputNumberSlider is much better. Could InputNumberDrag work the same way (or maybe scaled to require less movement)?
Example (or run SlabTest and set these values):
local DrawInput_Basic_Numbers_Clamped_Options =
{
    Text = tostring(DrawInput_Basic_Numbers_Clamped),
    NumbersOnly = true,
    MinNumber = 0,
    MaxNumber = 10,
    Step = 1,
}
if Slab.Input('DrawInput_Basic_Numbers_Clamped', DrawInput_Basic_Numbers_Clamped_Options) then
    DrawInput_Basic_Numbers_Clamped = Slab.GetInputNumber()
end

Thanks for the feedback @idbrii. I'll look into implementing this for the next patch release.


common/conf/ini.h: No such file or directory

Have you compiled it? Perhaps you can refer to the content in this link: https://oceanbase.github.io/miniob/how_to_build/


Navigation & cache issue with tab & navpush

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x ] 3.x
I'm submitting a ...  (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
I have made below changes in cutePuppyPics template
event flow
1)Home ==>2)Page1==>3)Contact(Tab)==>4)Home(Tab)==>5)Home(Tab)
on 4th step none of the life cycle event codes executing.
on 5th step its shows correct view which should appear on 4th step
I have tried to use pop at different pages & lifecycle function but can't fix this cache issue
Expected behavior:
when i click on home tab it must view home tab not page1
Steps to reproduce:
1)Home ==>2)Page1==>3)Contact(Tab)==>4)Home(Tab)==>5)Home(Tab)
Related code:
home.html
<ion-header>
  <ion-navbar>
    <ion-title>Home</ion-title>
  </ion-navbar>
</ion-header>

<ion-content padding>

Welcome to Ionic!

    This starter project comes with simple tabs-based layout for apps
    that are going to primarily use a Tabbed UI.

  <button ion-button full [navPush]="page1">page1</button>
  <button ion-button full [navPush]="page2">page2</button>
  <button ion-button full [navPush]="page3">page3</button>

    Take a look at the src/pages/ directory to add or change tabs,
    update any existing page or create new pages.

</ion-content>

home.ts
`import { Component } from '@angular/core';
import { NavController } from 'ionic-angular';
import { Page1Page } from '../page1/page1';
import { Page2Page } from '../page2/page2';
import { Page3Page } from '../page3/page3';
@Component({
selector: 'page-home',
templateUrl: 'home.html'
})
export class HomePage {
page1 = Page1Page;
page2 = Page2Page;
page3 = Page3Page;
constructor(public navCtrl: NavController) {
console.log("construct 0 home");
}
ngOnInit() { console.log("ngOnInit 0 home"); }
ionViewWillEnter() { console.log("ionViewWillEnter 1 home"); }
ionViewDidEnter() { console.log("ionViewDidEnter 2 home"); }
ionViewWillLeave() { console.log("ionViewWillLeave l1 home"); }
ionViewDidLeave() { console.log("ionViewDidLeave l2 home"); }
ionViewWillUnload() { console.log("ionViewWillUnload l3 home"); }
ionViewCanEnter() { console.log("ionViewCanEnter 3 home"); }
ionViewCanLeave() { console.log("ionViewCanLeave l4  home"); }
ionViewDidLoad() {
console.log("ionViewDidLoad 4 home");
}
}`
Other information:
https://forum.ionicframework.com/t/navigation-cache-issue-with-tab-navpush/99173
 ionic info

global packages:

    @ionic/cli-utils : 1.5.0
    Cordova CLI      : 7.0.1
    Ionic CLI        : 3.5.0

local packages:

    @ionic/app-scripts              : 1.3.7
    @ionic/cli-plugin-cordova       : 1.4.0
    @ionic/cli-plugin-ionic-angular : 1.3.1
    Cordova Platforms               : android 6.2.3 ios 4.4.0
    Ionic Framework                 : ionic-angular 3.4.2

System:

    Node       : v6.11.0
    OS         : macOS Sierra
    Xcode      : Xcode 8.3.3 Build version 8E3004b
    ios-deploy : 1.9.1
    ios-sim    : 6.0.0
    npm        : 3.10.10

Hello, thanks for opening an issue with us. Would you mind posting a repo we could use to reproduce this issue?

its for all app with tab, even if you in conference app.
event flow 1)Schedule(Tab) > 2) Click on any session(Meet and greet) 3)About(Tab) 4)Schedule (Tab)
in 4 th step it will show you session view of 2nd step, it should show list of session or you must need to provide option to cache the view or not.
https://github.com/ionic-team/ionic-conference-app

Hi
Can anyone please check this issue or just inform me if anyone looking at it?
This scenario can be generated in any app with tab.
even id in your conference app as explained, though it doesn't look odd in conference app but
you can imagine scenario where you have 10 different page links on home page & each has 3-5 sub pages and if in that case cache page appear ,it will look odd.
and main issue here you can't detect that cached view from any where, no lifecycle event was fired.

This is exactly issue what I am facing with tabs, ionViewCanLeave works on Back Button, but not for tabs.

Hi
can I get confirmation on this issue whether anyone is looking into it or nor?
or should i need to move back to ionic1, this is serious issue for ionic2/3 all, i don't think it is just my issue ?

Hi Thanks for reply.
I am already using sidemenu but still it gets cached. don't you thing cache should be optional like ionic1?
because it could be problem for all who want to use tab? and it looks really odd when you have 3-4 subpages in each tab ,in conferance app its look ok,doesn't seems to be a issue but if you have 30-40 total pages in app in that case you can't put everything on sidemenu.


CAVPP_Islandora

Mapper dependency: None

Some general links to know:

Development contribution process
"CIC all tasks" list view
"CIC current sprint" status view

Specific to this mapper:

List of collections, by mapper type: https://registry.cdlib.org/admin/library_collection/collection/?mapper_type=cavpp_islandora&repository__id__exact=72
Endpoints: https://glbt.i8.dgicloud.com/oai/request?verb=ListSets

28 published collections

Rikolti MVP project board cheat sheet:

Please @ CDL developers liberally, in the comments.
When picking up an "issue," please indicate:

a) Assignees: self assign;
b) Sprint: select the current sprint cycle;
c) Date started: indicate the start date -- see right side fields

CIC developers will likely need to create PRs (and possibly additional issues). When doing so, please also indicate the following:

a) Repository: Rikolti;
b) Milestone: "4 CIC work" (these details are required in order for them to surface in the Rikolti MVP project board); and
c) link the PR to the associated issue.

When requesting review, please:

a) include a comment & @ CDL developers; and
b) Date delivered: indicate the date delivered (field on the right)

We previously thought this cavpp_islandora legacy mapper was obsolete, but found there is one endpoint dependent on it. Adding this back to the queue, but with a couple of notes.
1: We'd like to propose pushing this up the queue, following the Solr/Blacklight (UCSD) work. (And ahead of the OAC work that's next up.)
2: The legacy mapper cavpp_slandora currently has two endpoints, one of which is obsolete. Only the GLBT HS endpoint (with 28 collections) will need to work with this mapper.
3: Please name this new Rikolti mapper: oai.islandora.glbths
4: Just an FYI/reminder that there is a base oai.islandora mapper that this new oai.islandora.glbths mapper will work with.
Please let me know if you have any questions. Thanks!


Animation Tutorial: analyzer error in code sample

On the Animations Tutorial page under "Simplifying with AnimatedWidget" the following code snippet is provided:
class AnimatedLogo extends AnimatedWidget {
  AnimatedLogo({Key key, Animation<double> animation})
      : super(key: key, listenable: animation);

  Widget build(BuildContext context) {
    final Animation<double> animation = listenable;
    return Center(
      child: Container(
        margin: EdgeInsets.symmetric(vertical: 10),
        height: animation.value,
        width: animation.value,
        child: FlutterLogo(),
      ),
    );
  }
}

On the first line of the build method, this analyzer warning is generated:
A value of type 'Listenable' can't be assigned to a variable of type 'Animation<double>'.
Try changing the type of the variable, or casting the right-hand type to 'Animation<double>'.
dart(invalid_assignment)

Updating that line of code to this solves the issue:
final animation = listenable as Animation<double>;

Is that the right way to do this? If so, can we please update the documentation accordingly?

Hi @maxlapides, I have not been able to reproduce this analyzer warning from the sample code provided in the tutorial.
The code that is included in this tutorial is available here: https://github.com/flutter/website/tree/master/examples/animation
This class implementation is first used in the animate2 sample listed there, and is built on in the following animate3, 4... etc. samples for the different stages of the tutorial.
Are you still experiencing this issue?

@Piinks yes, the issue persists. It's probably because the latest version of the Dart analyzer is stricter than previous versions. Here's what I'm running:
[✓] Flutter (Channel beta, v1.7.8+hotfix.3, on Mac OS X 10.14.5 18F132, locale en-US)
    • Flutter version 1.7.8+hotfix.3 at /Users/maxlapides/flutter
    • Framework revision b712a172f9 (9 days ago), 2019-07-09 13:14:38 -0700
    • Engine revision 54ad777fd2
    • Dart version 2.4.0

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/maxlapides/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = /Users/maxlapides/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 10.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.2.1, Build version 10E1001
    • CocoaPods version 1.7.2

[!] iOS tools - develop for iOS devices
    ✗ Verify that all connected devices have been paired with this computer in Xcode.
      If all devices have been paired, libimobiledevice and ideviceinstaller may require updating.
      To update with Brew, run:
        brew update
        brew uninstall --ignore-dependencies libimobiledevice
        brew uninstall --ignore-dependencies usbmuxd
        brew install --HEAD usbmuxd
        brew unlink usbmuxd
        brew link usbmuxd
        brew install --HEAD libimobiledevice
        brew install ideviceinstaller
    • ios-deploy 1.9.4

[✓] Android Studio (version 3.4)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 37.1.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[✓] VS Code (version 1.36.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.2.0

[✓] Connected device (2 available)
    • SM G960U1 •<PHONE_NUMBER>583398                     • android-arm64 • Android 9 (API 28)
    • iPhone Xs • 4B3A0C53-93BF-4FB6-B989-9154DCCE61B8 • ios           • com.apple.CoreSimulator.SimRuntime.iOS-12-2 (simulator)

Thanks for providing that information. :)

Thanks again for bringing this to our attention! This has been fixed by https://github.com/flutter/website/pull/2842.

No problem! Thanks for taking care of it :)


[WIP] Kubernetes integration

[Work in Progress]
Kubernetes integration into Mantl. This is an integration of kubernetes-ansible.
DNS
We run etcd/skydns on every node. DNS entries are managed by kube2sky. DNS queries are routed through dnsmasq>skydns>etcd on local node to decrease dns network traffic.
Networking
Kubernetes may employ either Flannel or Calico for containter networking.
Calico

Pitfall: Currently calico cannot assign IP to container/pod which has been launched from manifest file. Only pods launched through kalicoctl/kubeapi gets an IP assigned. Track the bug in kubernetes repo and calico-kubernetes repo.

Flanneld

Blocker: flanneld cannot probperly start because of race condition between services. Flannel needs to start before Docker, Etcd must be started before Flannel, but currently it is started as Docker container. Hence the lockdown. Track the issue.

@zogg what is the impact of the calico issue? How often do we deploy via manifest vs. the API.

Related: #643

@jenkins please test it

@jenkins ok to test

Is it possible to run Kubernetes on Mantl, on top of Mesos instead of using the bundled Kubernetes scheduler? (Using the Kubernetes mesos framework)
In which case, it could probably be run from Marathon instead of as a system process?

@eirslett The general feeling is that it is less complex to run kubernetes on its own than by using the k8s-mesos framework. Mantl support for k8s experimental at this point, and we are going to keep it separate from Mesos installs until we can integrate it better.
The idea is to migrate K8s to use calico and consul, so that we have common networking and service discovery for different frameworks.

I was able to successfully run the kubernetes playbook.
but the changes in the etcd and calico roles make them unusable on a non-kubernetes cluster.

@Zogg @avnik we need to get the etcd playbook aligned so the same one is used for kubernetes and calico.

@stevendborrelli The roles are fixed and OK.

etcd playbook does seem to work well in a non-kubernetes mantl cluster. and survives restarts so this fixes #737.
calico is still problematic on a non-kubernetes cluster. no containers can be launched with mesos/marathon when calico is enabled.

we're going to address the calico problems in a separate issue