Set icon before running the unpackaged-scenario tests

Introducing DisplayName/Icon inference logic broke the Toast unit tests, since now it's mandatory to specify the assets before calling AppNotificationManager::Register().
Ran all Toast tests on SV2 after the fix and using the latest lifted DLL. All tests are passing now.

/azp run


Implement bubble sort in Hy

Since someone took the first Kotlin implementation from me, Hy is a Lisp that transpiles to Python: http://docs.hylang.org/en/stable/index.html

So I compared using my cons implementation (which is not efficient) with using list concatenation. Here are timings on 1000 random integers.
With cons:
4.05 s ± 27 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

With list concatenation:
3.43 s ± 26.6 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

Compare this to the current Python implementation:
30.9 ms ± 549 µs per loop (mean ± std. dev. of 7 runs, 10 loops each)

The Racket code took 33262 ms total / 1000 = 33.2 ms/step. Going to mark this WIP until I can figure out how to make this more idiomatic/less slow.

@Amaras You forgot this one :)


old, insecure hashing algorithm

 $this->password = sha1(md5($this->password));
Please use at least bcrypt / password_hash / password_compat.
And there are much more vulnerabilities, most are not even reported here.
You should start from the beginning and use a secure framework like Symfony or Laravel.

You are welcome to contribute to the project.

See #1047


AboutUs: Documentation

1)Update team member names and pictures
2)Update roles and responsibilities
3)Update member's GitHub and portfolio link

Coverage remained the same at 92.234% when pulling a19785e79bc1e4de6a8736e0a19b35ac0927113a on Lenaldnwj:About_Us into 7e66b167d16b73ab1cf5d0fc951e5d7398f22db3 on CS2103AUG2017-T16-B2:master.


Upload CYFToken

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[x] Filename in the lowercase format
[x] Image format: png
[x] Image size: 256 by 256 px

Added t here in lowercase format https://github.com/TrustWallet/tokens/commit/d8afdce11fca4439fe608187dc17e08b4f0fa536
Also, you can use these graphics to say that your ERC20 token fully compatible with Trust Wallet (https://trustwalletapp.com/logo-assets). Tokens will show up automatically once the user receives them.
Feel free to share this on social media and tag Trust Wallet:

Twitter: @trustwalletapp

Facebook: @trustwalletapp


[Impeller] Android Stable

The plan for the Q3 stable release is to enable Impeller by default on Vulkan capable Android devices with a fallback to Skia/OpenGLES on devices that are not Vulkan capable. A flutter tool command line flag and AndroidManifest.xml flag will be availalbe for users to opt-out of Impeller.

[x] https://github.com/flutter/flutter/issues/137108
[x] https://github.com/flutter/flutter/issues/138236
[ ] https://github.com/flutter/flutter/issues/139702
[x] https://github.com/flutter/flutter/issues/142659
[x] https://github.com/flutter/flutter/issues/123671

As of today, the plugin migration is blocked on the 3.22 release going live.

Impeller is now the default on master channel on Vulkan-enabled Android devices, which is what this issue covered, so I will go ahead and close this.


Don't leave all target files open when copying context from stdin

Hi @jessfraz, this just closes target files after write. Previously all target files were being held open for the entire context copy, and I was getting errors about too many open files. Thanks!

thanks!


Add passt (pasta) package for podman

see https://github.com/containers/podman/pull/16141
We should test this in upstream CI.
For fedora it can be installed from the updates-testing repo or this copr (https://copr.fedorainfracloud.org/coprs/sbrivio/passt/)
For ubuntu we could use the deb from here: https://passt.top/builds/latest/x86_64/ (untested)

It should also make its way into Debian unstable relatively soon

It's now in NEW state for unstable: https://ftp-master.debian.org/new/passt_0.0~git20221104.e308018-1.html.

It should also make its way into Debian unstable relatively soon

It's now in NEW state for unstable: https://ftp-master.debian.org/new/passt_0.0~git20221104.e308018-1.html.

Now accepted for unstable and in incoming: http://incoming.debian.org/debian-buildd/pool/main/p/passt/ -- I'll file a Ubuntu sync ticket as soon as the package reaches the pool (which should happen in a few hours).

I can add this package to the F37 podman VM no problem.  The Debian SID package should come in handy in a bit.  The Ubuntu -> Debian switch is still in planning.

The Debian SID package should come in handy in a bit. The Ubuntu -> Debian switch is still in planning.

Yes yes, I mentioned it just because it needs to be in Debian before we can have it on Ubuntu. I didn't file the sync request for Ubuntu yet as I had some authentication troubles with Launchpad, I'll try again in a bit.


How to determine the sending address of a omni transaction?

How can I determine the sending address and reference address of a omni transaction( like c74b91c584be80b8ccd9e54a3e959d7de672985bc60c8c8e2d6e08da6a16d456)?
I try to process it without omnicore. I almost check the protocal of Class A over again and again, and I can not make it.
Can anyone help?
Thanks

Hi @DogRex :
The easy way is looking into the omni explorer: https://www.omniexplorer.info/tx/c74b91c584be80b8ccd9e54a3e959d7de672985bc60c8c8e2d6e08da6a16d456 .
Other way is with omnicore using the command: omni_gettransaction  "put the txid here"

Hi @santos177, thanks for you comment~
Yes, I think you are right, but I'm just studying on the omni protocol, and can not understand some details.
So , my actual question is ... just take this tx as an example,
c74b91c584be80b8ccd9e54a3e959d7de672985bc60c8c8e2d6e08da6a16d456
how does the omni explorer determine the tx is from "1Gc3biG5hsHAoj4ZNAtnT4sCBbtF9sKEEL" to "1FLhMtcsvVFjhdE3LRBdWqR4FeXuFkTM4m"

@santos177 great 👍 . Best regards at the thanks giving day~

I understand. Well, is just watching the outputs: https://chain.so/api/v2/tx/BTC/c74b91c584be80b8ccd9e54a3e959d7de672985bc60c8c8e2d6e08da6a16d456
Here you can see 3 outputs:
output 0, to destination "1FLhMtcsvVFjhdE3LRBdWqR4FeXuFkTM4m".
output 1, to sender "1Gc3biG5hsHAoj4ZNAtnT4sCBbtF9sKEEL"
output 2, nulldata (contains the payload with omni marker 6f6d6e69, type of transaction,amounts, propertyId, etc)
"6f6d6e6900000000000000030000000000000bb8"
Also you can study the parseTransaction function (omnicore.cpp file) and the CTransaction class : https://dev.visucore.com/bitcoin/doxygen/class_c_transaction.html
I hope it helps.

Sometimes the destination is output 0 and sender is output  3
like this https://chain.so/api/v2/tx/BTC/5bc9b6a1028dc207fcbb3ae87bf1a268f297cab6db0c96da2c6203eebbe9a60f

Hi @ngocbd :
Yes, but you have yo look the amount of the outputs, in general the bigger amount is for the sender (as change). The destination contains a very small amount of BTC ( in your example is : 0.00000546).

Hello,
the sender of Class A transactions is the one with the "highest contribution" of BTC, i.e. the address that contributed the most funds for the transaction. For Class B and C it's very simple: the sender is always the first input.
The reference output is the latest one, which isn't change. E.g.:
In[0]: A [< sender]

Out[0]: Payload
Out[1]: A
Out[2]: B
Out[3]: C [< receiver]

Here, it's C, because it's the latest output, which isn't the sender.
In[0]: A [< sender]

Out[0]: Payload
Out[1]: C
Out[2]: B [< receiver]
Out[3]: A

Here, it's B, because the last output is the change output.
In[0]: A [< sender]

Out[0]: Payload
Out[1]: B
Out[2]: A [< receiver]
Out[3]: A

Here, it's an edge case: it's A, because the latest output is skipped, because it's change, but the next output goes still to A, which is valid in this case.


net.minecraftforge.fml.loading.EarlyLoadingException: Could not execute entrypoint stage 'client' due to errors, provided by 'betterend'!

Mod Name
BetterEnd 1.20.1
Mod Homepage
https://www.curseforge.com/minecraft/mc-mods/betterend
Minecraft version
1.20.1
Describe the bug
I have BetterEnd fabric 1.20.1 mod installed and it keep crashing, I couldn't figure out what's the problem
Steps to reproduce

Installs BetterEnd
Launches
Crashes

Logs
crash log: https://pastebin.com/RHXwicW0
debug log: https://gist.github.com/prrhic/135fa62aaeffcc960058f38173941466
Additional context
Couldn't figure out what causes the crash myself

Please read the issue template more carefully. For modpack related issues, use the support channel on our discord server.

Before reporting, please ensure that:

You've installed a minimal set of mods required to reproduce the issue.
Issues with modpacks and excessive amount of mods will not be accepted, as they take a long time to diagnose.
Knowing which mods are causing problems allows us to focus on fixing the issue as soon as possible.
If you're unsure which mods might be at fault, try using binary search - removing half of installed mods
repeatedly until the faulty mod is found.

Please read the issue template more carefully. For modpack related issues, use the support channel on our discord server.

Before reporting, please ensure that:

You've installed a minimal set of mods required to reproduce the issue.
Issues with modpacks and excessive amount of mods will not be accepted, as they take a long time to diagnose.
Knowing which mods are causing problems allows us to focus on fixing the issue as soon as possible.
If you're unsure which mods might be at fault, try using binary search - removing half of installed mods
repeatedly until the faulty mod is found.

nvm i found the solution. Turns out it was the oculus mod, it happens when i update the oculus mod the latest version


Allow undefined in boolean field parsing

I want to get the user's preference on update or not, so I added a --update flag to parsing options:
var argv = yargs.Options('--update', {
  boolean: true
}).argv;

In this case, when user set --update in the arguments, argv.update will be set, and when user miss this flag, false will be put there.  But a more sensible interpretation is that user didn't give a specific preference, neither did my parsing option, in which case undefined seems more favorable. And, in this context, whether to update should be determined by some mechanism like last update time.
I propose that, allow return undefined when default: undefined is specifically set.

addressed in:
https://github.com/chevex/yargs/pull/87


Passing initialisations to NUTS/inference approach

          Can we have a helper function for this or make it part of the output of best_pf?  I don't love reading this or the thought of having to repeatedly write it down.

Originally posted by @seabbs in https://github.com/CDCgov/Rt-without-renewal/pull/117#discussion_r1516011356

This is closed by #169


Downloading prepared genomes outside of bcbio

I was wondering if it is possible to download the genomes used by bcbio outside of bcbio (using wget or similar), so that we can easily incorporate the use of these references in other workflows/pipelines. Being able to download these files automatically would improve reproducibility.
Is it possible to download these files somewhere? (I was unable to find anything in the documentation, other than references to an AWS bucket.)
Or are these files downloaded from various sources and prepped on demand by the installer?

I'd recommend looking at the source of the installer script and/or executing the installer. The URLs can be extracted like this. There is some postprocessing being done as regards indexes and genome annotations. I personally don't see value in providing this functionality explicitly as a service for other workflow systems, though - but of course others may well differ in their opinion.
On a side note, 2k issues processed is just awesome. Thank you @chapmanb and crew.

Of course, I understand the hesitation in providing this as a service. However, I do think it might be a valuable resource, as you are effectively generating a relatively clean reference with matched annotation files (such as dbsnp, known indels etc.).
I find it disappointing that it is quite hard to find a set of reference files (particularly for human references) that work well together without running into issues stemming from differences between references (e.g., different naming conventions).

Julian -- thanks for the question. As Sven-Eric mentioned, everything is available for download so could be used in other contexts. It's no problem if you want to use them for personal projects. However it's not something we'd like to encourage on a large scale right now for a couple of reasons. Downloads cost us money and our small core at Harvard Chan School provides this as a service for the community, so the AWS bills can add up. It also adds an additional support burden if folks start using it in different contexts and run into issues.
I agree entirely with your comment about having organized sets of reference files and that's exactly the kind of community resource bcbio hopes to provide. Maybe we could offer more useful suggestions if we understood your use case and why bcbio as is doesn't work for you. Thanks again for the discussion.

Asked and answered.


[Video Intelligence] Google::Gax::RetryError: running sample snippet.

Hi,
I'm working on samples which use the Video Intelligence API. I tried following a workflow from the example snippet and I receive a Google::Gax::RetryError: which uses project id usable-auth-library. Both are shown below. How should I set the project id?
Error:
Google::Gax::RetryError: GaxError Exception occurred in retry method that was not classified as transient, caused by 7:Google Cloud Video Intelligence API has not been used in project usable-auth-library before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/videointelligence.googleapis.com/overview?project=usable-auth-library then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.
	from /Users/franknatividad/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/google-gax-0.8.2/lib/google/gax/api_callable.rb:349:in `rescue in block (2 levels) in retryable'
	from /Users/franknatividad/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/google-gax-0.8.2/lib/google/gax/api_callable.rb:343:in `block (2 levels) in retryable'
	from /Users/franknatividad/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/google-gax-0.8.2/lib/google/gax/api_callable.rb:342:in `loop'
	from /Users/franknatividad/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/google-gax-0.8.2/lib/google/gax/api_callable.rb:342:in `block in retryable'
	from /Users/franknatividad/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/google-gax-0.8.2/lib/google/gax/api_callable.rb:262:in `block in catch_errors'
	from /Users/franknatividad/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/google-gax-0.8.2/lib/google/gax/api_callable.rb:224:in `block in create_api_call'
	from /Users/franknatividad/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/google-gax-0.8.2/lib/google/gax/api_callable.rb:250:in `block in create_api_call'
	from /Users/franknatividad/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/google-cloud-video_intelligence-0.20.0/lib/google/cloud/video_intelligence/v1beta1/video_intelligence_service_client.rb:247:in `annotate_video'
	from (irb):8
	from /Users/franknatividad/.rbenv/versions/2.3.3/bin/irb:11:in `<top (required)>'
	from /Users/franknatividad/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/cli/exec.rb:74:in `load'
	from /Users/franknatividad/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/cli/exec.rb:74:in `kernel_load'
	from /Users/franknatividad/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/cli/exec.rb:27:in `run'
	from /Users/franknatividad/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/cli.rb:335:in `exec'
	from /Users/franknatividad/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
	from /Users/franknatividad/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
	from /Users/franknatividad/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor.rb:359:in `dispatch'
	from /Users/franknatividad/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/cli.rb:20:in `dispatch'
	from /Users/franknatividad/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor/base.rb:440:in `start'
	from /Users/franknatividad/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/cli.rb:11:in `start'
	from /Users/franknatividad/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/exe/bundle:32:in `block in <top (required)>'
	from /Users/franknatividad/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/friendly_errors.rb:121:in `with_friendly_errors'
	from /Users/franknatividad/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/exe/bundle:24:in `<top (required)>'
	from /Users/franknatividad/.rbenv/versions/2.3.3/bin/bundle:22:in `load'
	from /Users/franknatividad/.rbenv/versions/2.3.3/bin/bundle:22:in `<main>'

Snippet:
require "google/cloud/video_intelligence/v1beta1"

video_intelligence_service_client = Google::Cloud::VideoIntelligence::V1beta1::VideoIntelligenceServiceClient.new
input_uri = "gs://demomaker/tomatoes.mp4"
features = []

# Register a callback during the method call.
operation = video_intelligence_service_client.annotate_video(input_uri, features) do |op|
  raise op.results.message if op.error?
  op_results = op.results
  # Process the results.

  metadata = op.metadata
  # Process the metadata.
end

Gemfile.lock (Using Ruby 2.4.1)
GEM
  remote: https://rubygems.org/
  specs:
    addressable (2.5.1)
      public_suffix (~> 2.0, >= 2.0.2)
    faraday (0.12.1)
      multipart-post (>= 1.2, < 3)
    google-cloud-video_intelligence (0.20.0)
      google-gax (~> 0.8.0)
    google-gax (0.8.2)
      google-protobuf (~> 3.2)
      googleapis-common-protos (~> 1.3.5)
      googleauth (~> 0.5.1)
      grpc (~> 1.0)
      rly (~> 0.2.3)
    google-protobuf (3.3.0)
    googleapis-common-protos (1.3.5)
      google-protobuf (~> 3.2)
      grpc (~> 1.0)
    googleauth (0.5.1)
      faraday (~> 0.9)
      jwt (~> 1.4)
      logging (~> 2.0)
      memoist (~> 0.12)
      multi_json (~> 1.11)
      os (~> 0.9)
      signet (~> 0.7)
    grpc (1.3.4)
      google-protobuf (~> 3.1)
      googleauth (~> 0.5.1)
    jwt (1.5.6)
    little-plugger (1.1.4)
    logging (2.2.2)
      little-plugger (~> 1.1)
      multi_json (~> 1.10)
    memoist (0.15.0)
    multi_json (1.12.1)
    multipart-post (2.0.0)
    os (0.9.6)
    public_suffix (2.0.5)
    rly (0.2.3)
    signet (0.7.3)
      addressable (~> 2.3)
      faraday (~> 0.9)
      jwt (~> 1.5)
      multi_json (~> 1.10)

PLATFORMS
  ruby

DEPENDENCIES
  google-cloud-video_intelligence

BUNDLED WITH
   1.14.6

Hi @frankyn, have you enabled the Video Intelligence API on that project? The key part of the error message is the following:

Google Cloud Video Intelligence API has not been used in project usable-auth-library before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/videointelligence.googleapis.com/overview?project=usable-auth-library then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.

I'm not sure how usable-auth-library was used. I set the GOOGLE_CLOUD_PROJECT id and I enabled the video intelligence API for my project spec-test-ruby-samples.  Is there a parameter to set the project id?

It doesn't look like Video Intelligence has project_id as part of its API. So I assume it is using the project associated with your authentication. How are you authenticating?
Video Intelligence is a GAPIC-only gem, and doesn't offer the same API for authentication as used by other Google Cloud gems.

@blowmage, I thought I had setup my environment correctly, but I didn't define GOOGLE_APPLICATION_CREDENTIALS with a service account. @remi provided me an example and I was able to get passed this error.
Thank you!


Return Anniversary date , contact relationship

I can't get the anniversary event data and contact relationship. Is these features not provided or am i missing something ?

I can't recall at the moment. Can you take a look at the code and if it's not included, submit a PR to add it to the Contact response. Thanks!

I have the same issue. Any progress on this?


Allow markdown content in getting started

This PR fixes #

cc @sandy081 / @mjbvz I pulled the common styles and svg removal logic into markdownDocumentRendered as it was previously duplicated between the extension editor and the release notes editor, and I didn't want to duplicate it again for getting started editor. Lmk if thats OK.

Ok for me, but I would take @mjbvz 's opinion.


feat: check cluster generation download/deploy

TODO: the path to the 3rd gen version endpoint would need to be ajusted to /metadata/.. once this is available.


Fred should be able to create and retrieve case-insensitive project names

https://www.pivotaltracker.com/story/show/115464313

Closing since this is simply a link to the tracker and that exists in the Contributing readme.  We should correctly migrate off tracker if we want to and not have issues that are simply links.


[Feature Request] Support CupertinoPageRoute swipe to back android and ios.

First I want to thank you for the effort to bring us this amazing library, it's really time saving!
I want to know if is it possible to support CupertinoPageRoute for android and ios .
Such as:
Get.toNamed('/country', route: Router.Cupertino);
Swipe back is nice feature, android user very like it.
Thanks.

popGesture: true made it


support updates to the kafka secret

When the secret used by the Kafka source is updated (e.g. the password changes), I believe that we won't pick up the new value until something happens in the system (like a pod in the kafa infra changes) or some other reason causes the Kafka CR to be reconciled. It would be nice if it was a bit more deterministic and the new secret values were picked up immediately.
/cc @lionelvillard

I worked on the KafkaChannel on similar thing, but not on KafkaSource. I won't have time to work on this issue but I would be happy to assist the person doing the coding.


Fix #2530 Setting constant colors for glyphs is non-intuitive

Fix #2530
Adds an explicit "Use Constant Color" checkbox and color selector to all the mentioned renderers.

In the case of the barb rendering, turning on constant color causes the TFE to be hidden. However, for the wireframe, contour, and flow renderer the TFE is not hidden. Is there a reason to not be consistent?

That was something I added when refactoring the GUI because in the barb renderer, when constant color is enabled, the color mapping var is not used at all which is not the case in the other renderers. I changed it to make it consistent, however.

In the case of the barb rendering, turning on constant color causes the TFE to be hidden. However, for the wireframe, contour, and flow renderer the TFE is not hidden. Is there a reason to not be consistent?

That was something I added when refactoring the GUI because in the barb renderer, when constant color is enabled, the color mapping var is not used at all which is not the case in the other renderers. I changed it to make it consistent, however.

@stasj needs to resubmit to resolve issue with 26 files change from transition from master to main.


Namespace is missing

com.android.build.api.variant.impl.LibraryVariantBuilderImpl.

Namespace not specified. Specify a namespace in the module's build file: /Users/builder/.pub-cache/hosted/pub.dev/pushy_flutter-2.0.20/android/build.gradle. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

Hi @farahfarah1 ,
Thanks so much for reporting this issue, and for submitting a PR!
We've merged your PR and published version 2.0.21 to pub.dev.

Please update the Pushy Flutter SDK in your app by editing the pubspec.yaml in the root directory of your project and updating the pushy_flutter package version to 2.0.21:

pushy_flutter: 2.0.21

Run flutter pub get to fetch the new version of our SDK.

Please let us know if there's anything else we can help with.


[ CREATE ] - Jobs Listing Page #31

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed!
Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

Summarise what this PR fixes
This PR creates a new job listing page to be added to the Keiko Corp project.  The issue number and detail is:
[ CREATE ] - Jobs Listing Page #31
<Detail your PR changes/fixes>
What ISSUE NUMBER does this fix?
https://github.com/zero-to-mastery/Keiko-Corp/issues/31
Fixes #

Created a new job listing HTML page with 5 different jobs
Created a new job-listing.css page
Created favicon for web page( which can be reused for other webpages inside of Keiko Corp)
Created a responsive layout for and added new cards for small mobile screens

Checklist:
(Add an x between the brackets to check the items)

[x] I have summarised what this PR fixes above
[x] I have provided the issue ID/URL above
[x] This PR fixes only the issue mentioned above (create separate PRs for separate issues)
[x] I was the first one to claim the issue or I created the issue

Looks great @batistaDev1113
Nice job 🚀

Thank you @MattCSmith !!
Happy to contribute.  I will be on the lookout for more additions!


Add a preloader to the website

Is your feature request related to a problem? Please describe.
As the site takes some time to load so it will be better if we will add a preloader to the website.
Describe the solution you'd like
I want to implement a preloader.
Additional context
Add any other context about the feature request here.

Sure go for it @Ankita297 :)

https://user-images.githubusercontent.com/67833077/111108475-f7851680-857e-11eb-832e-074dae52d46e.mp4

is it okay ? or need same changes ?
like  background color or any other idea ?
If it is okay then i will make the PR .

I can also change the design if you want ?

Uploading Document - Google Chrome 2021-03-15 22-29-36.mp4…

https://user-images.githubusercontent.com/67833077/111193826-9aba4800-85e0-11eb-8c77-967079a5c9fa.mp4


[Spotify 1.2.13] Apps Doesn't Show On UI

🔍 Is there already an issue for your problem?

[x] I have checked older issues, open and closed

ℹ Environment / Computer Info
- Spotify version: 1.2.13
- Spicetify version: 2.36.0

📝 Description
I have installed Spicetify on my spotify under 1.2.13 (with ver 2)
It registers Marketplace & Lyrics plus as installed on my spotify, but the following doesn't show for unknown reasons
I have tried to modify the sidebar configuration with no success
📸 Screenshots

Not related to marketplace and they do show up

We do not support pre-Library X UI anymore. If you need it, downgrade to spicetify version that did not support global navbar


Test mode does not work

Hi, I think the --test mode of himecc doesn't work properly.
Using this trivial grammar file:
grammar Test
{
    options
    {
        Axiom = "expression";
    }
    terminals
    {
        A -> 'a'+;
    }
    rules
    {
        expression -> A ;
    }
}

Running echo "aaa" | himecc --test Test.gram yields
{"errors":[{"type":"UnexpectedToken","position":{"line":1,"column":1},"length":3,"value":"aaa","terminal":{"id":3,"name":"A"},"expected":[]}],"root":null}

But running it with e.g. the .NET runtime works as expected, yielding one A = aaa ASTNode.

Thank you for reporting this.
This is now fixed on master. Note that to make the command work, -n should be passed to echo so that no trailing line ending is used. Otherwise this fails because the input will be aaa\n:
echo -n "aaa" | himecc --test Test.gram


Implement "lookup second hit" for small variants

Is your feature request related to a problem? Please describe.
When users are looking for a second hit for a small variant, it would be nice to easily lookup all small variants in the same gene and structural variants overlapping the gene (or even gene's TAD).
Describe the solution you'd like
Add a button to the small variant results table row that opens a modal with the information. The modal should display a bootstrap pill for selecting for small or structural variants. This should trigger loading the necessary information from the server.
Describe alternatives you've considered
Triggering a query limited to a gene in question would be harder to use.
Additional context

#574

Implementation Proposal
We should add one endpoint for each small and structural variants. The endpoints should accept a case ID, an encoded small variant and a gene identififer. The endpoint shall then perform a query in the case for corresponding small variants in the gene or (respectively) the related structural variants.
Then, add a button to the small variant results display that shows a modal with Bootstrap which request the relevant information.
Affected Components
VarFish server
Affected Modules/Files

variants.*
svs.*

Required Architectural Changes
None
Implementation Sketch

Add endpoints with tests
Add modal for HTML and JavaScript for the implementation


Upgrade dependencies version  - Get Map bugfix

There were the following issues with your Pull Request

Commit: 70a23d64fbebccdd6b174692506cdb0d2d1e2287

Commits must be in the following format: %{type}(%{scope}): %{description}

Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert, build, ci

Commit: 4c9e0fce3dea462ebe8d2b4f9ad78f1978101f5b

Commits must be in the following format: %{type}(%{scope}): %{description}

Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert, build, ci

Commit: 9c34aa5e85fec7a1cc80d2066139491fb2eefa40

Commits must be in the following format: %{type}(%{scope}): %{description}

Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert, build, ci

Commit: c84a8470ca0ccd4dfba43b36f72064b3b6da0e3a

Commits must be in the following format: %{type}(%{scope}): %{description}

Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert, build, ci

Commit: a6792f5b6b630d435b647286ad2922fa1393c8af

Commits must be in the following format: %{type}(%{scope}): %{description}

Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert, build, ci

Commit: 9879a353614eeb47143aaea4e1b6c42d81ba95a6

Commits must be in the following format: %{type}(%{scope}): %{description}

Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert, build, ci

Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md

This message was auto-generated by https://gitcop.com

@gtame thanks for your contribution. unfortunately I'm not willing to merge these commits. Please create an issue first to discuss if we can add a certain feature/improvement to the project. thank you!


Use VSC Api to trust content

For #4122

Codecov Report

Merging #4484 (106742d) into main (b626776) will increase coverage by 0%.
The diff coverage is 85%.

@@          Coverage Diff          @@
##            main   #4484   +/-   ##
=====================================
  Coverage     75%     75%
=====================================
  Files        398     398
  Lines      26033   25985   -48
  Branches    3721    3714    -7
=====================================
- Hits       19556   19545   -11
+ Misses      4960    4919   -41
- Partials    1517    1521    +4

Impacted Files
Coverage Δ

src/client/datascience/notebook/helpers/helpers.ts
69% <75%> (-5%)
:arrow_down:

...tascience/interactive-ipynb/trustCommandHandler.ts
77% <100%> (-1%)
:arrow_down:

src/client/datascience/notebook/contentProvider.ts
81% <100%> (+6%)
:arrow_up:

...nt/datascience/notebookStorage/vscNotebookModel.ts
74% <100%> (-4%)
:arrow_down:

src/client/common/application/notebook.ts
86% <0%> (-3%)
:arrow_down:

src/client/datascience/notebook/notebookEditor.ts
40% <0%> (-3%)
:arrow_down:

src/client/common/process/pythonDaemonPool.ts
83% <0%> (-2%)
:arrow_down:

...datascience/notebookStorage/nativeEditorStorage.ts
79% <0%> (-1%)
:arrow_down:

src/client/datascience/jupyter/notebookStarter.ts
79% <0%> (ø)

... and 19 more

Codecov Report

Merging #4484 (106742d) into main (b626776) will increase coverage by 0%.
The diff coverage is 85%.

@@          Coverage Diff          @@
##            main   #4484   +/-   ##
=====================================
  Coverage     75%     75%
=====================================
  Files        398     398
  Lines      26033   25985   -48
  Branches    3721    3714    -7
=====================================
- Hits       19556   19545   -11
+ Misses      4960    4919   -41
- Partials    1517    1521    +4

Impacted Files
Coverage Δ

src/client/datascience/notebook/helpers/helpers.ts
69% <75%> (-5%)
:arrow_down:

...tascience/interactive-ipynb/trustCommandHandler.ts
77% <100%> (-1%)
:arrow_down:

src/client/datascience/notebook/contentProvider.ts
81% <100%> (+6%)
:arrow_up:

...nt/datascience/notebookStorage/vscNotebookModel.ts
74% <100%> (-4%)
:arrow_down:

src/client/common/application/notebook.ts
86% <0%> (-3%)
:arrow_down:

src/client/datascience/notebook/notebookEditor.ts
40% <0%> (-3%)
:arrow_down:

src/client/common/process/pythonDaemonPool.ts
83% <0%> (-2%)
:arrow_down:

...datascience/notebookStorage/nativeEditorStorage.ts
79% <0%> (-1%)
:arrow_down:

src/client/datascience/jupyter/notebookStarter.ts
79% <0%> (ø)

... and 19 more


Focus rings have different colors depending on user agent

Problem
Looks like the focus rings are different depending on user agent/operational system:

Solution
Focus rings should have a tabler's style for all users:

As a part of this issue, fix focus ring around the logo:

duplicate https://github.com/freeats/freeats/issues/258


HIP atomic is slower than Nvidia

I used AMD MI100 and Nvidia V100, to test a very simple code. A value was added to the different memory using atomic. The test found that the V100 was three times faster than the MI100.Theoretically, V100 is worse than MI100 in all aspects such as memory frequency.Is there any way to solve this problem?
Sample code:
__global__ void kernel(
    const int* __restrict__ A,
    const int* __restrict__ D,
    volatile double* __restrict__ x,
    volatile int* d_graphInDegree)
{
    const int global_id = blockIdx.x * blockDim.x + threadIdx.x;
    int col = global_id / WARP_SIZE;
    const int local_warp_id = threadIdx.x / WARP_SIZE;

    //do something

    while (1 != d_graphInDegree[global_x_id]){};
    xi[local_warp_id] = x_dev[global_x_id];
    for (jj = D[global_id] + lane_id; jj < D[global_id+1]; jj += 64){
        double tmp=0.0;
         //do something
        atomicAdd((double*)&x[rowIdx], tmp);
        __threadfence();
        atomicSub((int*)&d_graphInDegree[rowIdx], 1);
    }
}

How many threads were adding values to how many atomics?  If the latter is 1, you may be benefiting from a cuda compiler optimization that HIP is not making.

How many threads were adding values to how many atomics? If the latter is 1, you may be benefiting from a cuda compiler optimization that HIP is not making.

As you said there are many threads but only one atom, does HIP have any plans to optimize it? Or is there any way to avoid it?

MI-100 must use compare-and-swap to implement double precision atomic add.  Double precision atomic add instructions were added in MI-200.  MI-100 does have a single precision atomic add instruction but it's a bit odd (it can't return the original value) so you must use void atomicAddNoRet(float*, float) to update it.

MI-100 must use compare-and-swap to implement double precision atomic add. Double precision atomic add instructions were added in MI-200. MI-100 does have a single precision atomic add instruction but it's a bit odd (it can't return the original value) so you must use void atomicAddNoRet(float*, float) to update it.

Thank you very much for your answer. My testing revealed just what you said.


hook threading.excepthook

This new hook got added to Python 3.8 in https://github.com/python/cpython/pull/13515

We already catch crashing threads with ThreadingIntegration in a way that works across all Python versions. I don't think this is necessary until Python 3.8 becomes the minimal supported version by this SDK.

Ah, right, thanks :)


Merge surveyor survey with public survey for reusable component

I recreated the surveyor survey to reuse the public survey code. Questions/options are based on a google doc I found in the backend slack channel and probably not final, but here's something.

There's a code conflict that needs to be resolved before it can be merged. Please check this out.

The apt number should be optional on the public survey. It's currently required.

The jsx file should be changed to js file to keep the all the file in the same file type. I don't think it has any conflict with js, but to keep it uniform it would be good.


re-default global max rpc batch size to 1k

PR description
default global rpc max batch size to 1000 for 23.1.0, revisit in 23.1.1
Fixed Issue(s)

Documentation

[ ] I thought about documentation and added the doc-change-required label to this PR if
updates are required.

Acceptance Tests (Non Mainnet)

[ ] I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.

Changelog

[ ] I thought about the changelog and included a changelog update if required.

@garyschulte Why did the ref tests change?

@garyschulte Why did the ref tests change?

overzealous git add picked up the execution-spec-test artifacts, fixed


fix(#29): toISOString is not a function

Wrapping date into date is not a solution

It's not elegant, but it did solve the problem and it's enforcing it the date type, which was not the case before that.

and it's enforcing it the date type

It assumes that the resolver returns date string or number timestamp. Which is incorrect, it should return Date instance and then everything works ok:
https://github.com/19majkel94/type-graphql/blob/tests/tests/functional/scalars.ts#L253

Closing according to discussion in #29


Document new dependencies

Both swift-driver and yams are now needed for bootstrap, so we should document how to set this up.

@swift-ci please smoke test

@swift-ci please smoke test


Ease the declaration of optional dependencies + handle them in maven and ivy publications

Usage (see #603):
ivy"org.slf4j:slf4j-api:1.7.25".optional() // or .optional(true)

Regarding the publications:

Optional dependencies are added to the optional ivy group. Is more work necessary here?
<optional>true</optional> is added to optional maven dependencies

@alexarchambault does this look reasonable to you? If so I'm happy to merge once travis is green

That seems ok, yeah. It's a pity there are no non-regression tests to validate this is all fine (it's easy to make mistakes with this kind of stuff).


0.7.5

Moving from release candidate for 0.7.5rc0 to actual release.

The tag v0.7.5 was accidentally put on a different hash. The content matches exactly githash of this PR.


Add a note to the getting started about canvas

SDK-742

Coverage remained the same at 98.44% when pulling 75310d76e354179d150fb3ecbd49cfadac276e90 on bartvde:app-unit-testing into 52f679c449b8e76685b6ecad1b7ceebe1c8a0f5a on boundlessgeo:master.

I updated the link @CarlyLanglois

Coverage remained the same at 98.44% when pulling f18b49ddba7c8f6471f6dc419e4621f128ab7024 on bartvde:app-unit-testing into 52f679c449b8e76685b6ecad1b7ceebe1c8a0f5a on boundlessgeo:master.


'Error: Update Error' when updating to Dream Launcher 1.40

When trying to update to version 1.40 of Dream Launcher, after 'Stopping Processes', I receive the following:

Please check if there is a file named "error-log.txt" in the "MyDocuments/Electronic Arts/The Sims 3/!DL-TmpCache/launcher-updater" directory. If this file exists, it should contain information about the error. Please post it here if it exists!


New changes to dataset entity

Thanks Sheila. This isn't in the story details, but thinking about what we'll need... Can you change lastReviewedBy and lastReviewedAt to reviewedBy and reviewedAt, and make them arrays too? Also, it looks like the approvedBy and approvedAt fields haven't been set as arrays in the migration.


Gl3 polygon mode fix

This seems to increase stability on osx, still not perfect though...

Which kind of instabilities have you experienced?

Any crash log? What's the complete error code exactly?
It doesn't make sense, because glGetInteger does exactly that behind the curtains..

Signal 134 is SIGABRT, which means something from macOS decided to kill it.
This typically happens with accesses to camera or something else inside the
app. I have no clue what could be causing this, simply put
On Wed, Mar 4, 2020, 09:26 Giuseppe Barbieri<EMAIL_ADDRESS>wrote:

Any crash log? What's the complete error code exactly?
It doesn't make sense, because glGetInteger does exactly that behind the
curtains..
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kotlin-graphics/imgui/pull/137?email_source=notifications&email_token=ADTJ6QFEP2AMLUNGSW2ZL5DRFZXJZA5CNFSM4LBHKMQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENYN3NA#issuecomment-594599348,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADTJ6QARNLJ3XKDYU4PEV6DRFZXJZANCNFSM4LBHKMQQ
.

Yes, glGetInteger does basically the same thing. However, GL_POLYGON_MODE returns two values , according to the GL documentation, as glGetInteger allocates only room for one value and then uses nglGetIntegerv, there is potential for trouble with memory.

Uh, you are right..!
Would you switch it to POLYGON_MODE -> glGetVec2i(GL_POLYGON_MODE)[0] then?

yes, glGetVec2i seems to work just as well on osx :)

Thanks tobias!

demo (and my own application) crashes/exits with error-code 134, about 50% of starts often after a few frames are rendered on osx. With this fix this seems to be less frequent.

Do you still get crashes though?

that was a nice catch though @tobias-dv-lnu

actually there seem to be no crashes on startup of the demo right now. However, memory-related stuff is tricky and behaves seemingly randomly at times... We will keep our eyes open for similar issues :)


help about page waitfor

sometimes,site has cloudflare auth, how can use waitfor to check the page is right way
like: https://newxiaozhan.com

@langziyang  could you please describe what you are trying to achieve with the entire code? I don't understand what problem you are facing

Closing since we can't act on this.


fix: hide "intercept response" checkbox in response view

:tada: This PR is included in version 0.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Setting ShowBothScrollIndicator in ScrollBarView constructor to false causes exception

If you set the ShowBothScrollIndicator in the Constructor to false, refresh throws an Object null exception:
System.NullReferenceException
  HResult=0x80004003
  Message=Object reference not set to an instance of an object.
  Source=Terminal.Gui
  StackTrace:
   at Terminal.Gui.ScrollBarView.CheckBothScrollBars(ScrollBarView scrollBarView, Boolean pending)
   at Terminal.Gui.ScrollBarView.ShowHideScrollBars()
   at Terminal.Gui.ScrollBarView.Refresh()
   at Randomizer.Generator.UITerminal.Views.GeneratorListFrameView.<>c__DisplayClass10_0.<.ctor>b__0(Rect e) in C:\Users\me_la\source\repos\Randomizer.Generator\Randomizer.Generator.Terminal\Views\GeneratorListFrameView.designer.cs:line 47

There is no ShowBothScrollIndicator but only a read only showBothScrollIndicator that has the following sintax:
bool showBothScrollIndicator => OtherScrollBarView != null && OtherScrollBarView.showScrollIndicator && showScrollIndicator;

It's an optional parameter in the constructor:
public ScrollBarView(View host, Boolean isVertical, Boolean showBothScrollIndicator = true);

Works for Horizontal but if IsVertical == true it still throws the exception.

Works for Horizontal but if IsVertical == true it still throws the exception.

I don't think so. I already had added an unit test for IsVertical == true and now in the PR #1355 I added an unit test for IsVertical == false. So, @melance please be more specific.

I had deleted my comment because I realized I still had the old version.  Sorry about that.


resolves #231 refactored utilities module to make it more testable

utilities module coverage = 95% after this update, only gaps are exception handling and environment-specific branches.


Setup npm install of eclairjs-node

Modify package.json to prepare for making us an npm module

Was fixed in ca709e62127c65e9486e606aef46926d16b51d3b


jump to definition doesn't work if code deployed in conda environment other than base

a repost from jupyterlab#16680
Description
When using jump to definition feature, while code was installed in the environment other than base, message No jump targets found is displayed.  Autocompletion works fine.
When the same code is installed in base environment, jump to definition works fine.
Reproduce

Have a project folder with src folder and modules in it and pyproject.toml to provide build instructions and dependencies
Install this project using pip install --editable .
Install nb_conda_kernels extension
Create new environment with conda, call it new_env
Create new notebook, import your module from src
Select new_env kernel for the notebook
Call function from your module, test autocompletion (should work fine)
Attempt to jump to funciton definition, observe No jump targets found

Expected behavior

Module python file should be opened with the function definition to jump to.
This works only if the module was installed in base environment. At the same time autocomplete works fine.
Context

Operating System and version: Linux Ubuntu 22.04
Browser and version: Chrome
JupyterLab version: 4.2.4

It’s be easier to reproduce using the container image that I use with my data science team:
https://hub.docker.com/repository/docker/stellars/stellars-jupyterlab-ds/general
It already has 3 environments: base, tensorflow and torch

this is reposted as per request by @krassowski to move the issue from jupyterlab#16680

This repository has a different bug report template, can you please fill it in?

done, updated the report

I have the same problem. Installing the Jupyter and the plugins solve this issue


Update architecture diagram

What this PR does / why we need it:

Drop/deprecate Kubernetes dashboard for its security risks
Insert vertical network segregation line between seed and shoot
Insert hint about SNI routing that we exclusively do
Fix poor choice of uppercase letters
Realign various misaligned lines/boxes/notes

Which issue(s) this PR fixes:
Requested by @ThormaehlenFred.
Special notes for your reviewer:
/area documentation
/kind cleanup
Release note:
Architecture diagram was updated discouraging the use of the Kubernetes dashboard (among other hints and cosmetic updates).

@vlerenc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name	Commit	Details	Required	Rerun command
pull-gardener-integration	630de16 link	true	/test pull-gardener-integration
Full PR test history. Your PR dashboard. Command help for this repository. Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Due to https://github.com/gardener/gardener/issues/6671
/retest

/milestone v1.56

Thx!


[Feature request]: Set default models per Pattern

What do you need?
I believe it would enhance the results of Fabric if users could assign different default models (LLMs) to specific Patterns. Each LLM excels in different scenarios—some are proficient in coding, others in understanding intent, or in utilizing up-to-date data. Therefore, it's logical to align specific patterns with models that suit them best.
Proposal:

Configurable Default Models: Introduce a configuration file where patterns can be mapped to their preferred default LLM. If a specific model isn't designated, the system defaults to the Fabric default set by the user.
Creator Presets: Allow the Pattern authors to provide a model option. This could be the model they tested their Pattern on, or the best model they have found for their pattern.
Import Creator Presets: Allow the user, through a CLI command, to import the presets providing the user has an API key for those models.
CLI Command: Implement a CLI command to manage this configuration file. Users can add, remove, or update mappings between patterns and default models directly from the command line. This should be retained after updates.
Opt-in: To prevent unexpected charges, this feature should be disabled by default. Users can enable it through a clearly defined setting during setup.

This enhancement would not only optimize the system's performance by leveraging specialized models but also empower users to tailor AI interactions to their specific needs effectively.

this is interesting
I would add that it could be useful to also have the option of different prompts tailored to specific models for each pattern. This way for models with significantly different characteristics the degrading output can be handled graciously.


Multi Nested Grouping

I'm trying to see if there was an easy way to have multiple levels with your group nesting?
data: [{ name: 'Jim', age: 10, gender: 'M'}, { name: 'Joe', age: 20, gender: 'M'},
{ name: 'Jill', age: 10, gender: 'M'}, { name: 'Mary', age: 20, gender: 'M'}];
DDL:

Male

Age > 10

Render Joe & all others

Age <= 10

Render Jim & all  others

Female etc...

Thank You in advance,
Kevin Soltis

I'm implementing a similar component here


Test for UI a11y

https://github.com/reactjs/react-a11y

General pointers:
https://reactjs.org/docs/accessibility.html
https://medium.com/@svinkle/creating-accessible-react-apps-38dc1c2775cf
https://blog.usejournal.com/getting-started-with-web-accessibility-in-react-9e591fdb0d52

Related: https://github.com/edrlab/readium-desktop/issues/88

Spectron and Devtron with a11y support:
https://electronjs.org/docs/all#accessibility
https://electronjs.org/docs/tutorial/accessibility
Spectron:
https://github.com/electron/spectron#accessibility-testing
Devtron:
https://github.com/electron/devtron

This issue should be moved to a next major release

What do you mean ?

DevTron is integrated as a Web Inspector plugin (tab), next to React and Redux dev tools. DevTron includes the same a11y checker as Spectron (frankly, quite out of date and not very helpful).
I added the Axe React accessibility checker, see PR: https://github.com/readium/readium-desktop/pull/589


Reduce the size of the float comparison epsilon

Fixes issues with meshes scaled to low values.

We could probably do something a little more rigorous, but this is definitely an improvement over the previous massive epsilon - looks good to me!


Backend: remove unused XE dependency

This commit removes the now unused dependency to
Xamarin.Essentials which was introduced in https://github.com/nblockchain/geewallet/commit/97d580050c8baac3b0cebc602fa5fb57c92014b8 and went out of use in https://github.com/nblockchain/geewallet/commit/9dd3f9e65ec830850cf12ed1fa91d1799518b3b1.
For future references adding XE to Backend can cause problems with MAUI because it adds Xamarin.Android.Support.V4 as dependency which conflicts with MAUI's AndroidX dependency.

@aarani CI is broken.

@parhamsaremi as you can see, our commitlint plugins are not fool-proof 😆 can you create a PR for conventions that first warns the developer to not put EOF as separator between footer note number and footer note content?

@aarani when addressing commitlint issues, I recommend addressing them all at the same time, not one by one.

For future references

I guess you mean "reference", not references.

I guess you mean "reference", not references.

Fixed


Allow custom PostCSS config

Following my question in #327, I thought I'd try to contribute a potential solution.
This change allows catalog to detect custom postcss config files in a project and skips configuring postcss-loader (at least under the createReactApp scheme) if one is present.

I should clarify that because postcss-loader was receiving an options object. It didn't look for a postcss.config.js file. There's logic in postcss-loader code that bypasses searching for config in that case...

After some reflection, I've come to the conclusion that it is a bad idea to open up this capability in Catalog. I now run my asset building and Catalog server in parallel. With this workflow, Catalog will rerender docs with the updated css on every rebuild. Closing...


Init method improvement

Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@gilv I decided to keep a map of the service name and its client in case the user connects to different services in a single job. I made the method synchronized because all the tasks try to initialize a client at the same time, so the map doesn't get updated.

@djalova this is not what i meant in the issue i opened. What you did is caching per task...but in any case each task do init only once, so this pull request provide no improvement. We need to use Singelton pattern, this will be per JVM ( for many tasks )

@gilv I tested this out and only the first task does the init, the subsequent tasks just pull from the cache.

@gilv Also with a singleton isn't there be an issue if the user accesses 2 different services? For example reading from a public object storage and writing to their private storage would require 2 different instances of an IStoreClient.

Here's the relevant part of the logs
16/12/07 10:59:20 INFO Executor: Using REPL class URI: spark://<IP_ADDRESS>:63214/classes
16/12/07 10:59:41 INFO CoarseGrainedExecutorBackend: Got assigned task 0
16/12/07 10:59:41 INFO CoarseGrainedExecutorBackend: Got assigned task 1
16/12/07 10:59:41 INFO CoarseGrainedExecutorBackend: Got assigned task 2
16/12/07 10:59:41 INFO CoarseGrainedExecutorBackend: Got assigned task 3
16/12/07 10:59:41 INFO CoarseGrainedExecutorBackend: Got assigned task 4
16/12/07 10:59:41 INFO CoarseGrainedExecutorBackend: Got assigned task 5
16/12/07 10:59:41 INFO Executor: Running task 2.0 in stage 0.0 (TID 2)
16/12/07 10:59:41 INFO Executor: Running task 1.0 in stage 0.0 (TID 1)
16/12/07 10:59:41 INFO Executor: Running task 4.0 in stage 0.0 (TID 4)
16/12/07 10:59:41 INFO Executor: Running task 0.0 in stage 0.0 (TID 0)
16/12/07 10:59:41 INFO Executor: Running task 3.0 in stage 0.0 (TID 3)
16/12/07 10:59:41 INFO Executor: Running task 5.0 in stage 0.0 (TID 5)
16/12/07 10:59:41 INFO Executor: Fetching spark://<IP_ADDRESS>:63214/jars/stocator-1.0.8-SNAPSHOT-jar-with-dependencies.jar with timestamp<PHONE_NUMBER>996
16/12/07 10:59:41 INFO TransportClientFactory: Successfully created connection to /<IP_ADDRESS>:63214 after 1 ms (0 ms spent in bootstraps)
16/12/07 10:59:41 INFO Utils: Fetching spark://<IP_ADDRESS>:63214/jars/stocator-1.0.8-SNAPSHOT-jar-with-dependencies.jar to /private/var/folders/5x/v3x7zbnj3lj1rtfmq3_bs7sw0000gn/T/spark-857dc62a-c395-4675-8ea8-4f3fc81a8d8d/executor-c1212fe7-a77f-4a51-b408-dced68dc3ae1/spark-ce085788-3899-459e-98c5-4494d6f653b8/fetchFileTemp6382092271820061866.tmp
16/12/07 10:59:42 INFO Utils: Copying /private/var/folders/5x/v3x7zbnj3lj1rtfmq3_bs7sw0000gn/T/spark-857dc62a-c395-4675-8ea8-4f3fc81a8d8d/executor-c1212fe7-a77f-4a51-b408-dced68dc3ae1/spark-ce085788-3899-459e-98c5-4494d6f653b8/12802680141481137157996_cache to /Users/djalova/IdeaProjects/swift/spark/work/app-20161207105918-0000/0/./stocator-1.0.8-SNAPSHOT-jar-with-dependencies.jar
16/12/07 10:59:42 INFO Executor: Adding file:/Users/djalova/IdeaProjects/swift/spark/work/app-20161207105918-0000/0/./stocator-1.0.8-SNAPSHOT-jar-with-dependencies.jar to class loader
16/12/07 10:59:42 INFO TorrentBroadcast: Started reading broadcast variable 1
16/12/07 10:59:42 INFO TransportClientFactory: Successfully created connection to /<IP_ADDRESS>:63216 after 1 ms (0 ms spent in bootstraps)
16/12/07 10:59:42 INFO MemoryStore: Block broadcast_1_piece0 stored as bytes in memory (estimated size 1802.0 B, free 457.9 MB)
16/12/07 10:59:42 INFO TorrentBroadcast: Reading broadcast variable 1 took 96 ms
16/12/07 10:59:42 INFO MemoryStore: Block broadcast_1 stored as values in memory (estimated size 2.9 KB, free 457.9 MB)
16/12/07 10:59:42 INFO HadoopRDD: Input split: swift2d://deleteThis.bmv3/parts/part-00001-attempt_201612061425_0000_m_000001_1:0+134217653
16/12/07 10:59:42 INFO HadoopRDD: Input split: swift2d://deleteThis.bmv3/parts2/part-00002-attempt_201612061430_0001_m_000002_5:0+65519206
16/12/07 10:59:42 INFO HadoopRDD: Input split: swift2d://deleteThis.bmv3/parts/part-00002-attempt_201612061425_0000_m_000002_2:0+65519206
16/12/07 10:59:42 INFO HadoopRDD: Input split: swift2d://deleteThis.bmv3/parts/part-00000-attempt_201612061425_0000_m_000000_0:0+134217609
16/12/07 10:59:42 INFO TorrentBroadcast: Started reading broadcast variable 0
16/12/07 10:59:42 INFO HadoopRDD: Input split: swift2d://deleteThis.bmv3/parts2/part-00000-attempt_201612061430_0001_m_000000_3:0+134217609
16/12/07 10:59:42 INFO HadoopRDD: Input split: swift2d://deleteThis.bmv3/parts2/part-00001-attempt_201612061430_0001_m_000001_4:0+134217653
16/12/07 10:59:42 INFO MemoryStore: Block broadcast_0_piece0 stored as bytes in memory (estimated size 16.0 KB, free 457.9 MB)
16/12/07 10:59:42 INFO TorrentBroadcast: Reading broadcast variable 0 took 9 ms
16/12/07 10:59:42 INFO MemoryStore: Block broadcast_0 stored as values in memory (estimated size 195.8 KB, free 457.7 MB)
16/12/07 10:59:42 INFO deprecation: mapred.tip.id is deprecated. Instead, use mapreduce.task.id
16/12/07 10:59:42 INFO deprecation: mapred.task.is.map is deprecated. Instead, use mapreduce.task.ismap
16/12/07 10:59:42 INFO deprecation: mapred.task.partition is deprecated. Instead, use mapreduce.task.partition
16/12/07 10:59:42 INFO deprecation: mapred.task.id is deprecated. Instead, use mapreduce.task.attempt.id
16/12/07 10:59:42 INFO deprecation: mapred.job.id is deprecated. Instead, use mapreduce.job.id
16/12/07 10:59:42 INFO ObjectStoreVisitor: Stocator registered as swift2d for swift2d://deleteThis.bmv3/parts/part-00002-attempt_201612061425_0000_m_000002_2
16/12/07 10:59:42 INFO ClientImpl: JOSS / Creating real account instance
16/12/07 10:59:42 INFO ClientImpl: JOSS / * Allow caching: true
16/12/07 10:59:42 INFO ClientImpl: JOSS / Use HTTP client set by client (overrides previous HttpClient settings)
16/12/07 10:59:42 INFO ClientImpl: JOSS / Attempting authentication with tenant name: null, tenant ID: null, username: null, Auth URL: https://identity.open.softlayer.com/v3/auth/tokens
16/12/07 10:59:43 INFO ClientImpl: JOSS / Successfully authenticated
16/12/07 10:59:43 INFO ClientImpl: JOSS / Applying preferred region: dallas
16/12/07 10:59:43 INFO ClientImpl: JOSS / Using TempURL hash prefix source: PUBLIC_URL_PATH
16/12/07 10:59:43 INFO AbstractAccount: JOSS / Use public host: null
16/12/07 10:59:43 INFO AbstractAccount: JOSS / Use private host: null
16/12/07 10:59:43 INFO AbstractAccount: JOSS / Allow Container caching: true
16/12/07 10:59:43 INFO AbstractAccount: JOSS / Allow reauthentication: true
16/12/07 10:59:43 INFO AbstractAccount: JOSS / Setting hash password
16/12/07 11:00:31 INFO Executor: Finished task 5.0 in stage 0.0 (TID 5). 948 bytes result sent to driver
16/12/07 11:00:33 INFO Executor: Finished task 2.0 in stage 0.0 (TID 2). 948 bytes result sent to driver
16/12/07 11:01:14 INFO Executor: Finished task 1.0 in stage 0.0 (TID 1). 1725 bytes result sent to driver
16/12/07 11:01:16 INFO Executor: Finished task 0.0 in stage 0.0 (TID 0). 948 bytes result sent to driver
16/12/07 11:01:17 INFO Executor: Finished task 4.0 in stage 0.0 (TID 4). 948 bytes result sent to driver
16/12/07 11:01:17 INFO Executor: Finished task 3.0 in stage 0.0 (TID 3). 1725 bytes result sent to driver

@djalova I still struggle to understand why cache in has map per stocator init method will improve stocator init from all different tasks that all executed in the same JVM. What exactly you tested that you saw benefit? How many tasks were there and how many workers? What was the number of tasks on each worker node? thanks

@gilv I did this with a single worker running 6 tasks. Before the patch, each task would create its own instance of APIClient. The patch adds a cache to be shared across all tasks created by a single worker. If I were to add a new worker then that worker would have its own cache for its tasks. I tested this by reading from a file with multiple partitions so that each partition would be allocated its own task.

@djalova I think something is wrong here...
In spark-shell I did

sc.textFile("swift2d://contA.service/*).count()
sc.textFile("swift2d://contB.service/*).count()

But in (2) i got results of (1)

Gil, the reason this code gets executed once by each executor worker (i.e. JVM) is this code sniplet in getStoreClient()
if (sClientMap.containsKey(service)) {
  return sClientMap.get(service);
}

I tested this on my environment and confirmed that the code works.  getStoreClient gets called once per task, but the actual body of the function gets executed only once per JVM.

@gilv Good point. I made a mistake and cached by the service name only. I should cache by container and service name. I will fix this soon.


Update framework targets to have 'ProvisionStyle: Automatic'

It must be explicitly added.

Sweet. That answers what I was about to ask 👍🎉


Add support for builtin CONCAT

So, CONCAT is actually a variable argument function. Is this something the catalog supports? If so, can you implement that version? The TPL API becomes: @concat(str1, str2, str2, ...) and the C++ API is something like StringFunctions::Concat(StringVal *result, ExecutionContext *ctx, StringVal **inputs, uint32_t num_inputs). It should be pretty simple to implement.

I'll take a look at this and see

So, CONCAT is actually a variable argument function. Is this something the catalog supports? If so, can you implement that version? The TPL API becomes: @concat(str1, str2, str2, ...) and the C++ API is something like StringFunctions::Concat(StringVal *result, ExecutionContext *ctx, StringVal **inputs, uint32_t num_inputs). It should be pretty simple to implement.

I'll take a look at this and see

@pmenon So I went to look in the catalog and it doesn't look like we support functions with variable argument lenght
https://github.com/cmu-db/terrier/blob/dabbbef03678288cd4a6b4a34284055dbaa3f0c1/src/include/catalog/database_catalog.h#L309-L311
https://github.com/cmu-db/terrier/blob/dabbbef03678288cd4a6b4a34284055dbaa3f0c1/src/include/catalog/database_catalog.h#L333-L335
I think this is probably blocked until that functionality gets added. It doesn't seem like something trivial to add either.

I'm closing this for now to avoid Jenkins builds

I think you'll need to add additional type-checking on these variadics to ensure someone doesn't pass non-strings into CONCAT.
If it's a significant amount of work, I'd prefer creating an issue and punt for later.

I'm not really sure what you mean by this to be honest. I thought that sema_builtin was doing exactly this?

@pmenon I believe I've addressed all your comments except for

I think you'll need to add additional type-checking on these variadics to ensure someone doesn't pass non-strings into CONCAT.
If it's a significant amount of work, I'd prefer creating an issue and punt for later.

I'm still not really sure what this entails.

Don't worry about variadic function type-check for now. Ideally, this checking should be done during function lookup in binding. Having a check during TPL semantic analysis is good for non-SQL use-cases (i.e., UDFs), but moving as much checking earlier in the pipeline is generally the correct approach.

You also need to modify the CONCAT bytecode encoding in bytecodes.h here so that num_inputs is an immediate unsigned 4-byte integer (e.g., like the last operand to `CSVReaderInit here)

Updated

Don't worry about variadic function type-check for now. Ideally, this checking should be done during function lookup in binding. Having a check during TPL semantic analysis is good for non-SQL use-cases (i.e., UDFs), but moving as much checking earlier in the pipeline is generally the correct approach.

Let's open an issue for this once this gets merged.


Stable release is not found when adding library.

I used the script ID provided in the readme: 1Qvk0v7ggfW-TJ84dlYPlDzJG8y-Dif-j9kdA1aWv4wzxE_IOkeV2juLB
It gives me an error Unable to look up library. Check the ID and access permissions and try again.

Note: The beta release ID works.

@mgslone thanks for reporting, the library sharing has been fixed and it should work now.
Please try again and let me know if it works for you.
Andreas


constraints

In the paper, you mentioned the constraints were used. In the code, where can I find them?
Thanks!

Which constraints are you referring to?
The code here uses the BIO constraints, which are the only constraints included in the main results in the 2017 paper.
The code for A* search was implemented in c++ and was not integrated with the rest of the Theano code (which make it hard to run/setup, etc.).

Thanks!

https://github.com/luheng/deep_srl/blob/master/python/neural_srl/shared/inference.py


Optimise ranger image

Can probably free up ~3GB of image space by optimising ranger-egeriavdc to a minimal alpine image.

As part of the optimisation I'm planning to move from mariadb to postgresql as the back-end (to re-use the minimal ~70MB image we already use for sample data rather than the ~300MB image for mariadb)...

There's quite a few improvements possible in the ranger image for sure:

Avoiding building (maven artifacts or elsewhere)
making it easier to add new plugins (ie for gaian)
separating out the database entirely (maybe a seperate container)
separating out the solr index entirely

The image hasn't changed much in about 1.5 years, so we know a lot more know to make it easier to do this.

Will be mostly addressed by #1043 -- suggest separate issues for any further optimisations.


void upgrade not working

after a while the void upgrades stop working.
https://www.reddit.com/r/allthemods/comments/va4l8a/the_functional_drawers_void_upgrade_is_a_bit/

Duplicate #27


[BEAM-3157] Generate BeamRecord types from Pojos

This implements automatic generation of BeamRecordTypes and BeamRecordSqlTypes from pojo types. Work is being done as part of BEAM-3157.
Main piece is RecordFactory which exposes a method to generate BeamRecords from pojos. See RecordFactoryTest for usage examples.
The plan is to integrate this into the Beam SQL framework. Integration into SQL will be done in the future PRs.
Records generation is a major step to simplify conversion of pojo model to BeamRecords. Immediate use case is implementation of Nexmark queries in Beam SQL using existing pojo models.
This can also be used as a starting point for code generation for schema-aware collections.
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @kennknowles @reuvenlax @iemejia
Please take a look

This has been open for over 2 months now. @kennknowles , @iemejia do you see a path to get this merged? Otherwise I will close it

Sorry about that. I think we should merge it. Technically, it has only been lying stale for 12 days... If you would just write less code, then I could get through the reviews! :-)

Any more comments from others? (don't let me LGTM dissuade further debate, please!)

Reviewed 1 of 22 files at r1, 3 of 20 files at r2, 20 of 31 files at r3.
Review status: 11 of 21 files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

sdks/java/core/src/main/java/org/apache/beam/sdk/values/reflect/BeamRecordFactory.java, line 81 at r2 (raw file):
Previously, akedin (Anton Kedin) wrote…
I agree. But there appears to be more than 70 usages of the constructors. I'd prefer to do this in another PR.

Yes, just a drive-by comment on past code.

sdks/java/core/src/main/java/org/apache/beam/sdk/values/reflect/DefaultRecordTypeFactory.java, line 30 at r2 (raw file):
Previously, akedin (Anton Kedin) wrote…
Updated the javadoc with this.
Short version:
This factory creates record types from the list of getters.
Record types are represented by BeamRecordType which essentially is a List<Pair<FieldName, Coder>>. Getters are represented by a List<FieldValueGetter>. So the factory creates former from the latter.
Normally you can do this by mapping java types of the getters to coders using CoderRegistry or even manual mapping. This is what this factory does.
Problem with SQL is that it uses java.sq.Types to describe types of the record. It keeps this information in BeamRecordSqlType in addition to field names and coders.  To map the java.sql.Types to coders we then need a custom mapping, which is done in a SQL-specific implementation of this interface.

I see. LGTM at this juncture.

sdks/java/core/src/main/java/org/apache/beam/sdk/values/reflect/GeneratedGetterFactory.java, line 69 at r2 (raw file):
Previously, akedin (Anton Kedin) wrote…
Hm, haven't really thought about this. Generated code itself doesn't throw but technically nothing stops the underlying getters from doing so. Do you have any ideas on how to handle this better?

This was the fix for DoFnInvoker: https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/StableInvokerNamingStrategy.java
I think we can go with what you have for now anyhow and rethink later if it comes up. Not a big issue for POJOs, etc.

sdks/java/core/src/main/java/org/apache/beam/sdk/values/reflect/package-info.java, line 22 at r2 (raw file):
Previously, akedin (Anton Kedin) wrote…
The parent values package seems to contain mostly value types around PCollection with almost no other logic. Adding a ton of reflection and code-generation code there didn't seem right, they would become noise in the values package.
Haven't thought about @Internal until now, thanks for suggestion. Updated:

Combined org.apache.beam.sdk.values.reflect and org.apache.beam.sdk.values.reflect.field;
Made everything package-private except:

RecordTypeFactory interface. Used in SQL. Marked it as @Internal;
FieldValueGetter interface. Used by the above factory in SQL. Marked as @Internal;
BeamRecordFactory. Is the only functional class accessed outside of the package. Marked as @Internal;

OK, works for me!

Comments from Reviewable

retest this please

tis green!

My excuses @akedin I have totally forgot about this one, and somehow I wasn't receiving any notifications. It is really nicer now.


Memory consumption

This might be more of an v8/node issue, but I'm banging my head on why busboy and other multipart parsers (namely, I've tried formidable and multiparty) seem to make v8 unable to garbage collect uploaded data.
Here's my test case, which can be run locally: https://gist.github.com/silverwind/10f076397348a64a72a5
When uploading a 3.4 GB file, the process first starts out at around 45 MB, then quickly climbs to to size of the uploaded file at 3.5 GB. At this point, the file is written to the disk completely, but the process doesn't go down a bit in memory consumption until killed. At this point, I tried to upload the same file again. My machine with 4 GB + 4 GB swap froze up pretty badly at this point, last I saw it was at around 6.5 GB explicit memory on the node process. I was eventually able to kill the node process, here's how the memory history looked:

Note that the graph above is a bit misleading. The explicit consumption of the node process never went down until killed. I think it's the OS making some on-demand memory available, but that's just a guess.
By the way, this is on io.js 3.0.0, but I assume all versions to be affected.

drumroll turns out that this is most likely an io.js/v8 issue as node 0.12.7 is not affected. Now to narrow it down..

Closing as this isn't an issue with this module.


[vite]: Rollup failed to reoslve import "js-yaml" during npm run build

Fresh clone, followed instructions in the readme. When I run npm run build, I get the following error:
[vite]: Rollup failed to resolve import "js-yaml" from "/home/ori/GitHub/langview/components/web-components/src/index.js".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`
error during build:
Error: [vite]: Rollup failed to resolve import "js-yaml" from "/home/ori/GitHub/langview/components/web-components/src/index.js".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`
    at viteWarn (file:///home/ori/GitHub/langview/demo/node_modules/vite/dist/node/chunks/dep-abb4f102.js:48051:27)
    at onRollupWarning (file:///home/ori/GitHub/langview/demo/node_modules/vite/dist/node/chunks/dep-abb4f102.js:48083:9)
    at onwarn (file:///home/ori/GitHub/langview/demo/node_modules/vite/dist/node/chunks/dep-abb4f102.js:47814:13)
    at file:///home/ori/GitHub/langview/demo/node_modules/rollup/dist/es/shared/node-entry.js:24070:13
    at Object.logger [as onLog] (file:///home/ori/GitHub/langview/demo/node_modules/rollup/dist/es/shared/node-entry.js:25742:9)
    at ModuleLoader.handleInvalidResolvedId (file:///home/ori/GitHub/langview/demo/node_modules/rollup/dist/es/shared/node-entry.js:24656:26)
    at file:///home/ori/GitHub/langview/demo/node_modules/rollup/dist/es/shared/node-entry.js:24616:26

I have verified that I have the correct versions of js-yaml and vite as specified in the codebase. New to Vite, so may be missing some prerequisites. .
Running Pop!_OS.

Great find - there appears to be a missing step in the README  for getting the demo up and running.
In the terminal (in the root of the project directory), before anything else, you'll need to run:
`cd /components/web-components `
`npm install`

 cd ../../demo
npm install
npm run build or npm run dev


fix: don't error on dynamic routes with prerender = false

fixes https://github.com/sveltejs/kit/issues/10332
Instead of always erroring on dynamic routes generated with the static adapter, we only error if the prerender option was not explicitly set. This allows users to have dynamic pages in the project but choose to ignore them, which is useful if they have multiple builds that may use a different adapter.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

[x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Is this only about silencing that exact error? What is stopping people from setting the strict: false option? Is that undesireable for some reason? If we go with this solution the error that is otherwise thrown should probably also mention it.

Is this only about silencing that exact error?

I think it's more about control of whether a route should error if it's not prerendered, which are only some routes but not all routes.

What is stopping people from setting the strict: false option? Is that undesireable for some reason?

I didn't know setting strict: false would disable those prerendering errors, but I think that's undesirable here as it should still error on certain pages that should be prerendered, e.g., those affected by the root layout that sets prerender = true.

If we go with this solution the error that is otherwise thrown should probably also mention it.

I agree. I'll add the information to the error.


FormBuilderTextField does not respect the constructor parameter "enabled"

FormBuilderTextField allows has a constructor parameter enabled, but it is not used. readonly is used instead. This can be seen here. This is inconsistent with the Flutter API for TextField.
Solution: Support enabled to be consistent with the Flutter API for TextField. Deprecate readonly but continue to support it for backwards compatibility.

This is a great idea! It will definitely be considered going forward.
Your positive contribution is greatly appreciated.

Hi @jrnelson333,
I was working on changing the readonly property to enabled but it seems Flutter have in the latest versions included readOnly property in the API for TextField.
What we may need to do therefore is to change readonly to readOnly.
I'm therefore going ahead to close this issue.


Network create and destroy support

Issue Type

Feature request

Molecule and Ansible details
ansible --version
ansible <IP_ADDRESS>
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides
  python version = 2.7.12 (default, Nov 20 2017, 18:23:56) [GCC 5.4.0 20160609]

molecule --version
molecule, version 2.5.0

Molecule installation method: pip
Ansible installation method: pip

Desired Behaviour
Add option to declare docker network and add containers to those networks during platform declaration.
The idea is to have the same features that molecule 1.25.
example:
driver:
  name: docker
  networks:
    - name: foo
      bar: foobar
    - name: some
       bar: other
platforms:
  - name: vito.cont
    groups:
      - redis
    image: geerlingguy/docker-debian9-ansible:latest
    privileged: True
    capabilities:
      - SYS_ADMIN
    volumes:
      - '/sys/fs/cgroup:/sys/fs/cgroup:ro'
    command: '/lib/systemd/systemd'
    networks:
       - foo
       - some

During create and destroy playbooks this data can be used along ansible docker_network to create and destroy networks.
Example of manual implementation

Create: https://github.com/idealista/redis-role/blob/master/molecule/cluster/create.yml#L35
Destroy: https://github.com/idealista/redis-role/blob/d645f349795e0e03b4a31f0b37b9600fe1fcec8f/molecule/cluster/destroy.yml#L21

If it makes sense to you I could try to make a PR. This kind on scenarios are very common while testing services that works on cluster mode.

If it makes sense to you I could try to make a PR. This kind on scenarios are very common while testing services that works on cluster mode.

Sure, feel free to create a PR.
The intent of the create/destroy playbooks is for users to add whatever the like to these.  Sure, we can make molecule.yml abstract common patterns.

I have problems running the test, is there any developer guide ?

No


django-anymail and webtail-django-recaptcha

My form using django-anymail to send through mailgun works fine until I add recaptcha. I see the message going into my error log, but nothing telling my why.

Never mind. I didn't realize my wsgi.py file reverted to dev instead of production

Never mind. I didn't realize my wsgi.py file reverted to dev instead of production


Rename keylight-tutorial.md to NAVEX-IRM-Keylight-Lockpath-tutorial.md

Docs Build status updates of commit d4f2508:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/active-directory/saas-apps/toc.yml
:warning:Warning

Details

articles/active-directory/saas-apps/keylight-tutorial.md
:white_check_mark:Succeeded
n/a (file deleted or renamed)

articles/active-directory/saas-apps/NAVEX-IRM-Keylight-Lockpath-tutorial.md
:white_check_mark:Succeeded

articles/active-directory/saas-apps/toc.yml

Line 1559, Column 15: [Warning: file-not-found - See documentation] Invalid file link: 'keylight-tutorial.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@ryelowNavex, @jeevansd, in Microsoft Docs, file names cannot include capital letters. Also, if a file name is changed, a redirect must be implemented.

@jeevansd,
Can you review the proposed changes? If you want this to proceed without the capital letters (or otherwise revised), please make that appropriate change or explain in a comment.
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@ryelowNavex - we'll let @jeevansd  weigh in (as the official content owner on our side), but we don't use uppercase in our file names, so that will need to change ... and a redirect entry for the old name to the name will need to be added to a .json file (which will need to be handled by @jeevansd in the private repo)...
Thanks!

@ryelowNavex, Creating a PR in our private repo
#please-close


Godot View does not respect layout in flutter android app and always sticks to the top of the screen

I am trying to embed Godot view in my flutter android app. Here is the complete source code
Flutter allows embedding native views. Check here for more info
I am able to embed my godot view properly in my flutter app, but the issue is it always sticks at the top and hide other flutter contents.
Check below video to know what i am talking about
https://github.com/m4gr3d/Godot-Android-Samples/assets/142881488/b50ecd90-89c8-4c68-acfc-dff764f9059b
As you can see in the video, first i had two flutter Text at the top and at the bottom. Once the Godot view loads it completely occupies the First text, there is a Positioned widget from flutter as well which is kind of like position:  absolute property from css and the Godot view does not respect that as well. Also if you check my code i have specifically set the size of my framelayout which also does not work and the Godot view occupies the entire height of 1200 which i had set in my Godot project. The same thing works in Jetpack compose by setting framelayout height manually.
Here is a snippet of my code
My native view in flutter
class MyQrView(
    context: Context, id: Int, creationParams: Map<String?, Any?>?,
    private val activity: FlutterFragmentActivity
) : PlatformView {
    private val linearLayout: LinearLayout
    private val frameLayout: FrameLayout

    override fun getView(): View {
        return linearLayout
    }

    override fun dispose() {}

    init {
        linearLayout = LinearLayout(context)
        linearLayout.layoutParams = ViewGroup.LayoutParams(
            ViewGroup.LayoutParams.WRAP_CONTENT,
            ViewGroup.LayoutParams.WRAP_CONTENT
        )
        frameLayout = FrameLayout(context)
        frameLayout.id = View.generateViewId()

        linearLayout.addView(frameLayout)

        frameLayout.apply {
            frameLayout.layoutParams.height = 300
            val fragmentTransaction = activity.supportFragmentManager.beginTransaction()
            fragmentTransaction.replace(frameLayout.id, GodotFragment())
            fragmentTransaction.commit()
        }
    }

}

To use it in flutter i use something like this
class MyHomePage extends StatelessWidget {
  const MyHomePage({super.key});

  @override
  Widget build(BuildContext context) {
    var width = MediaQuery.of(context).size.width;
    var height = MediaQuery.of(context).size.height;
    return Scaffold(
      body: SafeArea(
        child: Column(
          children: [
            Text(
              "Hello from flutter",
              style: TextStyle(fontSize: 20),
            ),
            Positioned(
              top: 100,
              child: SizedBox(
                width: width,
                height: height / 1.5,
                child: MyQrView(),
              ),
            ),
            Text(
              "Hello from flutter",
              style: TextStyle(fontSize: 20),
            ),
          ],
        ),
      ),
    );
  }
}

The column widget in flutter helps to layout views on below the other which the Godot view does not respect. I have created multiple platforms views previously for android using flutter and have never faced such problem. This seems like a Godot issue to me than a flutter issue. Correct me if i am wrong

I watched the tutorials, but when attempting to run the project in Godot 4.2.1, I encountered difficulties similar to what you demonstrated. However, upon invoking the Godot Screen, the application abruptly halts and shuts down the emulator. Below is the error output:
Launching lib\main.dart on sdk gphone64 x86 64 in debug mode...
√  Built build\app\outputs\flutter-apk\app-debug.apk.
Connecting to VM Service at ws://<IP_ADDRESS>:62352/Unj3fz0AB-g=/ws
D/ProfileInstaller( 4292): Installing profile for com.example.project_001_godot
D/AppCompatDelegate( 4292): Checking for metadata for AppLocalesMetadataHolderService : Service not found
W/oject_001_godo( 4292): Accessing hidden method Landroid/view/View;->computeFitSystemWindows(Landroid/graphics/Rect;Landroid/graphics/Rect;)Z (unsupported, reflection, allowed)
W/oject_001_godo( 4292): Accessing hidden method Landroid/view/ViewGroup;->makeOptionalFitsSystemWindows()V (unsupported, reflection, allowed)
E/godot   ( 4292): USER ERROR: Couldn't load file 'res://project.binary', error code 19.
E/godot   ( 4292):    at: _load_settings_text_or_binary (core/config/project_settings.cpp:783)
I/godot   ( 4292): Godot Engine v4.2.1.stable.official.b09f793f5 - https://godotengine.org
D/HostConnection( 4292): createUnique: call
D/HostConnection( 4292): HostConnection::get() New Host Connection established 0x72aff97fad50, tid 4654
D/HostConnection( 4292): HostComposition ext ANDROID_EMU_CHECKSUM_HELPER_v1 ANDROID_EMU_native_sync_v2 ANDROID_EMU_native_sync_v3 ANDROID_EMU_native_sync_v4 ANDROID_EMU_dma_v1 ANDROID_EMU_direct_mem ANDROID_EMU_host_composition_v1 ANDROID_EMU_host_composition_v2 ANDROID_EMU_vulkan ANDROID_EMU_deferred_vulkan_commands ANDROID_EMU_vulkan_null_optional_strings ANDROID_EMU_vulkan_create_resources_with_requirements ANDROID_EMU_YUV_Cache ANDROID_EMU_vulkan_ignored_handles ANDROID_EMU_has_shared_slots_host_memory_allocator ANDROID_EMU_vulkan_free_memory_sync ANDROID_EMU_vulkan_shader_float16_int8 ANDROID_EMU_vulkan_async_queue_submit ANDROID_EMU_vulkan_queue_submit_with_commands ANDROID_EMU_sync_buffer_data ANDROID_EMU_vulkan_async_qsri ANDROID_EMU_read_color_buffer_dma GL_OES_EGL_image_external_essl3 GL_OES_vertex_array_object GL_KHR_texture_compression_astc_ldr ANDROID_EMU_host_side_tracing ANDROID_EMU_gles_max_version_3_0
D/vulkan  ( 4292): searching for layers in '/data/app/~~E6kxmACb6XgiuVwCnUqCBw==/com.example.project_001_godot-vmeFX-iVbcibaoWswp7Dfg==/lib/x86_64'
D/vulkan  ( 4292): searching for layers in '/data/app/~~E6kxmACb6XgiuVwCnUqCBw==/com.example.project_001_godot-vmeFX-iVbcibaoWswp7Dfg==/base.apk!/lib/x86_64'
I/godot   ( 4292): Vulkan API 1.3.0 - Forward Mobile - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce RTX 2060
D/goldfish_vulkan( 4292): on_vkEnumerateDeviceExtensionProperties: host has ext semaphore? win32 1 posix 0
D/goldfish_vulkan( 4292): on_vkEnumerateDeviceExtensionProperties: host has ext semaphore? win32 1 posix 0
D/goldfish_vulkan( 4292): on_vkEnumerateDeviceExtensionProperties: host has ext semaphore? win32 1 posix 0
D/goldfish_vulkan( 4292): on_vkEnumerateDeviceExtensionProperties: host has ext semaphore? win32 1 posix 0
D/goldfish_vulkan( 4292): on_vkEnumerateDeviceExtensionProperties: host has ext semaphore? win32 1 posix 0
D/goldfish_vulkan( 4292): on_vkEnumerateDeviceExtensionProperties: host has ext semaphore? win32 1 posix 0
D/goldfish_vulkan( 4292): on_vkEnumerateDeviceExtensionProperties: host has ext semaphore? win32 1 posix 0
D/goldfish_vulkan( 4292): on_vkEnumerateDeviceExtensionProperties: host has ext semaphore? win32 1 posix 0
D/goldfish_vulkan( 4292): on_vkEnumerateDeviceExtensionProperties: host has ext semaphore? win32 1 posix 0
D/goldfish_vulkan( 4292): on_vkEnumerateDeviceExtensionProperties: host has ext semaphore? win32 1 posix 0
D/goldfish-address-space( 4292): allocate: Ask for block of size 0x1000000
D/goldfish-address-space( 4292): allocate: ioctl allocate returned offset 0x3f2fff000 size 0x1001000
I/godot   ( 4292):
D/oject_001_godo( 4292): PlayerBase::PlayerBase()
D/oject_001_godo( 4292): TrackPlayerBase::TrackPlayerBase()
I/libOpenSLES( 4292): Emulating old channel mask behavior (ignoring positional mask 0x3, using default mask 0x3 based on channel count of 2)
D/AudioTrack( 4292): createTrack_l(0): AUDIO_OUTPUT_FLAG_FAST denied by server; frameCount 0 -> 1956
D/Godot   ( 4292): OnGodotSetupCompleted
D/Godot   ( 4292): OnGodotMainLoopStarted
E/godot   ( 4292): USER ERROR: Condition "header != String(shader_file_header)" is true.
Exited.

You can follow this, of course it has the same issue highlighted but the original author but I think you should try running it on a real device and not emulator

Ran your project and found no issues, perhaps the Godot engine has been updated? Try syncing the project with Gradle files


session plugin - idletime not working

Summary

Kong version 2.4.1
https://github.com/bungle/lua-resty-session/issues/123
Adding an issue here because they could use some help in identifying a fix, and you all are maintaining the plugin ontop of this library

Steps To Reproduce

use session plugin
choose kong storage
set idletime to anything other than 0 (default)
session will expire after 1 minute (no matter what idletime is)

Additional Details & Logs

Helm deployment

Fixed with #10199


Add images

for use in future blog posts and FAQs

:+1: @anarchivist, feel free to :shipit: if you also :+1:


fix: remove numpy upper bound pin

We are unlikely to ever be affected by breaking changes in numpy because we do not use a large surface area.
See https://iscinumpy.dev/post/bound-version-constraints/#tldr
'Anyone can fix a missing cap, but users cannot fix an over
restrictive cap causing solver errors.'
Fixes https://github.com/spacetelescope/jdaviz/issues/2259

meeseeksdev please backport to master


update readme.md backends

Add LLamaSharp.Backend.Cuda12
Remove the @ of LLamaSharp.Backend.Cuda12 for a :

Thank you for the contribution! There're some badges at the beginning of the readme file. Would you mind updating them together, adding the following line?
[![LLamaSharp Badge](https://img.shields.io/nuget/v/LLamaSharp.Backend.OpenCL?label=LLamaSharp.Backend.OpenCL)](https://www.nuget.org/packages/LLamaSharp.Backend.OpenCL)

Thanks @warquys!


Add language: C#

Please see CONTRIBUTING.md for details on how to create a good PR for this project.
If you are going to work on this, please add a comment to avoid duplication of work.

@andrewhoyer I would like to work on this issue. Please assign it to me.

Done! Thank you for participating!


Fix Array.from static method

Support Symbol.iterator and surrogate pairs.

@falsandtru I've been working on full iterator support for Array.from on the upstream polyfill. You may be interested in checking that out :-) https://github.com/mathiasbynens/Array.from/pull/27

When can I use its upstream polyfills?

Not for a while, we need to add support for polyfills written in using module systems such as commonjs before we will be able to use the upstream polyfill directly. Perhaps we can copy some of the changes in the upstream pull request into our local polyfill? Namely the Safari browser support for Set and Map iteration.

I see, where can I fix the polyfill? Here, or upstream?

Fixing here for now, I can take on the work to push upstream :-)

I'm running the tests on CI for this PR, thanks for the contribution!

Sorry, I misunderstand about iterators. This code is wrong, and is a partial support. How should I do?

I will be attempting to complete my pull-request made upstream by the end of this week. I have two tasks left to do on it:

Get the polyfill working across different realms
Fix the failing tests that are present on master

If you like, you can help by cloning Array.from and running the tests against a browser such safari ios 7, the test no setters are called for indexes fails.

I see, then I close this pr, and wait the upstream fix. I'm very glad. Thanks a lot!

You are more than welcome. Thank you for taking the time to create a pull request, you've been quite active on this project recently, I'm very happy that you find it useful. How have you found contributing to this project? Was there anything in the documentation or contribution guide that you found was confusing or could be worded in a better way? We're are always trying to make contributing easier for members of the community.

I'll create some pr for Android support after several days. Many configs are not defined android versions. Thanks again 👍

@falsandtru Re-running the tests for you now :-)

Hmm, it seems to have caused by conflict between Symbol.iterator and @@iterator. I'll try to fix it.

Probably there are two ways.

Check @@iterator in all polyfills, per polyfill.
Change the Symbol.iterator polyfill to use @@iterator in old firefox.

I recommend the second way that change Symbol.iterator. The first way will make bugs.

I'm trying the first way only for Array.from because the second way is difficult to pass the tests of Symbol.

Fixed. Please run ci with latest 2 commits.

Re-running :-)

Thanks :) If the test for 73227c3 is passed, I recommend that we drop the last commit 767c1e2 for simplicity and consistency with other polyfills.

@JakeChampion Unfortunately, we cannot use the upstream polyfill because it cannot use with Symbol.iterator polyfill https://github.com/mathiasbynens/Array.from/issues/36. So can we use this fix?

@falsandtru I think it would be better to copy the upstream polyfill into the polyfill-service and modify it to work with Symbol polyfills.

However, then we need large changes to work with Symbol polyfills.

Seems like we cannot remove fixes for legacy Firefox support. So I added it https://github.com/Financial-Times/polyfill-service/pull/840/commits/d4d0f9a81032e82462bed2a33f770c97fd9cea2c.


K-th smallest element in array

Have you read the Contributing Guidelines on Pull Requests?
(Yes)
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
(#254 )

Please review sir @HarshCasper @iamrajiv @ankitaggarwal23 @atarax665 @gat786

@siddharth25pandey  sir merge conflict solved

@shivammahajancse Code structure is fine but can't merge the PR due to error at Deployment.
Resolve the PR

@siddharth25pandey done sir


SSKW-27 Login page

Checklist ✅

[x] I have followed the contributor guideline
[x] Tests are included
[x] Documentation is changed or added
[x] Related issue has been created
[x] Commits messages follows commit guideline

resolves #27

There is a problem in naming the assets. Please change the file names to CamelCase mode. In the case of numbers at the end, it is possible to use the minus sign "-".
Don't forget what He-Man said: "Never use spaces when naming folders and files, be a good penguin. Until next time, friends"


Lki/fix nullable properties in genereated ts models

Description

Extend schema to hold nullable information for reference objects in openapi.

We will wait for open api to be updated to support our needs to get rid of null and undefined attributes on non-nullable reference types.