CB-20809 Increase timeout duration and retry number for database back…

…up on long backup entitlement.
JIRA: CB-20809
ISSUE: Database backup times out after 90 min since we set timeout duration to be 90 min.
SOLUTION: Increase timeout duration as well as retry number for database backup if the entitlement CDP_DATALAKE_BACKUP_LONG_TIMEOUT is set to be true.
Before (I hardcoded timeout duration to be 1 min instead of 90 min to do the test):

After:
CDP_DATALAKE_BACKUP_LONG_TIME OUT set be true in the mock:
Backup:

Restore:

CDP_DATALAKE_BACKUP_LONG_TIME OUT set be false in the mock:

Can one of the admins verify this patch?

Just curious, what happened with the scripts that calculate the size of the data and set the timeout based on that?

@lnardai Thanks a lot for checking this! I believe the project that @sxxgrc works on to calculate the size of data is not completed yet since he is still waiting for CB to be merged and then merge the TH side. Santiago please correct me if Im wrong. And for this PR, sorry that I may close it later because this seems not to be the root cause for the issue we see. We wanted merge this into CB-2.68 before but now we needn't and it seems 2.68 has already been merged into master. I will reopen this PR and merge it into master if we still need this improvement. Thank you again!


Please help! Having trouble reproducing the result.

Hello there,
Thanks for contributing such a great work to open community.
I tried case1.1 with openai gpt 3.5.
I only get response in the first step which is the "plan phase", the agent successfully created a plan.
But I failed in second step which is "code phase", the response message is empty.
Any response will be appreciated!
Best,
ZD

Hi, could you please share a screenshot?

it looks like the problem of API, please pull our updated code and try to use with --model gpt-3.5-turbo-1106


refactor: move to Cloudflare workers

Changes this PR makes:
It seems that replit will drop free hosting for discord bots. This means that it's time to move on!
I chose to try moving to Cloudflare Workers because they have a free plan are blazingly fast, have nearly no downtime and it is an opportunity to try the discord interactions via webhook.
This, sadly, has some disadvantages too because it makes difficult for us to implement the /remind me command and, mostly, the predictions logic.
However, I like tricky things, so this is where we're going! I'll be migrating all the commands, one by one, leaving the remind (probably, we'll need to drop it) and the predictions ones to the end.
PS: I'll probably ask @NotReallyEight to help me migrating some commands to conclude earlier 😁

Not really ready but I need a review anyway

holy moly


Any interest in arbitrary saturating numbers?

I wrote up some code for creating numbers that are bounded to given limits, like so:
// Create a number that will never exceed 15
let x = BoundedUint(0, 15);
let y = x + 20;
assert_eq!(x, 15);

It's not particularly clever or efficient code, but it's nice to be able to enforce those sorts of checks transparently when you need them and someone else might want to do the same thing someday.  So if it's useful I'd like to contribute it to somewhere it'll be available, instead of just making yet another tiny random crate.

I think a brand new type would be better served in its own crate, rather than immediately getting slowed down to the maintenance pace of num.

All right, thanks.


[boost-locale] ICU backend missing

I ran vcpkg install boost-locale[icu] boost-regex[icu] boost --triplet x64-windows --recurse  to install the boost-locale library with icu support. However, querying the supported backends via
auto backend_manager = boost::locale::localization_backend_manager::global();
auto bk = backend_manager.get_all_backends();

only returns std and winapi. Seems like it's not properly building it with icu backend. Also it doesn't seem to require linkage to icu binaries.
Environment

OS: Windows10 x64
Compiler: revision

I tried building it locally with
./b2 boost.locale.winapi=off boost.locale.std=off -sICU_PATH="..\icu671" boost.locale.icu=on --with-locale stage -a --address-model=64
But even that does not seem to build it with ICU support.

@pr8x, thanks for reporting this issue.
It seems that the option 'boost.locale.icu' has been set 'ON' for boost-locale https://github.com/microsoft/vcpkg/blob/24e8be5fcfddd0da98b58a63cd918849787fb06f/ports/boost-locale/b2-options.cmake#L12
Also I double check the log file, it looks already set the option to on.
Building target '../build/boost_locale'
Building target '../build/boost_locale'
     Build request: object(property-set)@411 <address-model>64 <architecture>x86 <boost.locale.iconv>off <boost.locale.icu>on <boost.locale.posix>off <link>shared <runtime-link>shared <threadapi>win32 <threading>multi <toolset>msvc <variant>debug
     Command line free features:
     Target requirements: <conditional>@Jamfile<E:\VCPKG\boost_173\vcpkg\buildtrees\boost-locale\src\ost-1.73.0-60f2c445b1\build>%Jamfile<E:\VCPKG\boost_173\vcpkg\buildtrees\boost-locale\src\ost-1.73.0-60f2c445b1\build>.configure <define>BOOST_ALL_NO_LIB=1 <define>BOOST_THREAD_NO_LIB=1 <include>../include&&/E:/vcpkg/boost_173/vcpkg/installed/x64-windows/include <link>shared:<define>BOOST_LOCALE_DYN_LINK=1 <relevant>define:<relevant>link <relevant>threading:<relevant>runtime-link <relevant>threading:<relevant>toolset <tag>@Jamfile<E:\VCPKG\boost_173\vcpkg\buildtrees\boost-locale\src\ost-1.73.0-60f2c445b1>%Jamfile<E:\VCPKG\boost_173\vcpkg\buildtrees\boost-locale\src\ost-1.73.0-60f2c445b1>.tag <threading>multi <toolset>msvc,<runtime-link>shared:<threading>multi

     Building target '../build/has_icu'
         Build request: object(property-set)@415 <address-model>64 <architecture>x86 <target-os>windows <toolset-msvc:version>14.2 <toolset>msvc
         Command line free features:
         Target requirements: <define>BOOST_ALL_NO_LIB=1 <include>../include&&/E:/vcpkg/boost_173/vcpkg/installed/x64-windows/include <library>/boost/locale//icudt/<link>shared/<runtime-link>shared <library>/boost/locale//icuin/<link>shared/<runtime-link>shared <library>/boost/locale//icuuc/<link>shared/<runtime-link>shared <relevant>threading:<relevant>runtime-link <relevant>threading:<relevant>toolset <runtime-link>shared <tag>@Jamfile<E:\VCPKG\boost_173\vcpkg\buildtrees\boost-locale\src\ost-1.73.0-60f2c445b1>%Jamfile<E:\VCPKG\boost_173\vcpkg\buildtrees\boost-locale\src\ost-1.73.0-60f2c445b1>.tag <toolset>msvc,<runtime-link>shared:<threading>multi
...

Yes, the my buildtree has these has_icu_* files as well. But linking with the obj only gives me std and winapi as mentioned above. What am I supposed to do with these rsp files?

It seem icu lib doesn't link correctly, I noticed that link error in config.log:
msvc.link E:\vcpkg\boost_173\vcpkg\buildtrees\boost-locale\x64-windows-static-dbg\boost\build\7b17862d6e014c912b42e5cec9e0a8e2\has_icu64.exe
LINK : fatal error LNK1181: cannot open input file 'icudt.lib'
Hoever I already pass the icu path via '-sICU_PATH'
/E:/VCPKG/boost_173/vcpkg/installed/x64-windows-static/debug/lib ]
Usage requirements from has_icu:  address-model architecture asynch-exceptions cxxstd cxxstd-dialect debug-store debug-symbols deduced-address-model deduced-architecture embed-manifest exception-handling extern-c-nothrow inlining instruction-set link lto lto-mode optimization pch rtti runtime-debugging runtime-link segmented-stacks threading toolset toolset-msvc:vendor toolset-msvc:version variant warnings warnings-as-errors windows-api /E:/VCPKG/boost_173/vcpkg/installed/x64-windows-static/debug/lib
Performing configuration checks
- icu                      : no

@yurybura, do you know more about this issue?

Duplicated to https://github.com/microsoft/vcpkg/issues/3537.
There is a PR https://github.com/microsoft/vcpkg/pull/10943 to fix this issue, @pr8x, could you try the changes and see if it works for you?

I will close this issue and track everything via 3537.


Update custom marshalling sample

Summary
Update custom marshalling sample based on changes to the element marshal modes.
Fixes https://github.com/dotnet/runtime/issues/96564

Snippets build failure is some infrastructure issue. I'm going to merge this as-is.


#2877 cli: better keptn auth messages

Fixes #2877

Preview

Hey @christian-kreuzberger-dtx ,
I have tested and added variable namespacing the message. Apparently we the fallback to default keptn namespace is already handled and we do not need to define it again (tested)
Here is the message when keptn is installed in a custom namespace called testnamespace:


Proposal/base should be a SubSequence

Introduction
Rather than marking prefixes/suffixes as virtual, it would make more sense to inset the proposal before passing it to a base style, because then styles like NormalTextStyle would not need to take virtual characters into account (something it cannot produce on it’s own). Instead, NormalTextStyle could simply merge the proposal it receives and call it a day.
Motivation
The above can be done already, but it’s unnecessarily expensive because it requires re-snapshotting the proposal.

Actually, I’m not sure about this because I don’t think modifiers are limited to prefixing and suffixing. A wrapper could just as well group characters in chunks of three. So NormalTextStyle would still have to filter virtual characters, because limiting the range is not enough. With a proposal modification approach, you would have to introduce something like index runs.


"Please choose one (To quit, press "q/Q")" does not work in Emacs terminal buffer

$ flutter run
Building flutter tool...
Downloading android-arm-profile/linux-x64 tools...                  0.5s
Downloading android-arm-release/linux-x64 tools...                  0.3s
Downloading android-arm64-profile/linux-x64 tools...                0.4s
Downloading android-arm64-release/linux-x64 tools...                0.5s
Downloading android-x64-profile/linux-x64 tools...                  0.3s
Downloading android-x64-release/linux-x64 tools...                  0.4s
Downloading Web SDK...                                              1.2s
Multiple devices found:
Pixel 3 XL (mobile)      • 8AJY0LZ2N  • android-arm64  • Android 11 (API 30)
Lenovo TB 8504F (mobile) • HGAFGRP2   • android-arm64  • Android 7.1.1 (API 25)
Web Server (web)         • web-server • web-javascript • Flutter Tools
Chrome (web)             • chrome     • web-javascript • Google Chrome 81.0.4044.113
[0]: Pixel 3 XL (8AJY0LZ2N)
[1]: Lenovo TB 8504F (HGAFGRP2)
[2]: Web Server (web-server)
[3]: Chrome (chrome)
Please choose one (To quit, press "q/Q"): 0
0

Please choose one (To quit, press "q/Q"): 0
0

Please choose one (To quit, press "q/Q"): 0
0

Please choose one (To quit, press "q/Q"): 0
0

Please choose one (To quit, press "q/Q"): q
q

Please choose one (To quit, press "q/Q"): q
q

I suppose the fact that there is a terminal attached is not sufficient for the single char mode to work? Or perhaps we're not getting the input back we expect - should be easy enough to test.

yeah, I believe that the terminal in this case is line-oriented.

Interesting, do the normal hot reload workflow commands work at all? I think they should share the same underlying logic for dealing with different kinds of stdin

yup, seems to work fine. I seem to recall we had a similar problem when we first added them though, maybe there's special code to handle them?

Yeah, I looked into a bit and we do have some extra handling in the reload commands that is missing from the terminal prompt.

I'm almost certain the issue is just that we're not removing the trailing newline. I'll double check this when I have time to set up emacs, but if you want to try and verify the diff is pretty small.
diff --git a/packages/flutter_tools/lib/src/base/terminal.dart b/packages/flutter_tools/lib/src/base/terminal.dart
index e0e2b4b796..7fe4cb8ab1 100644
--- a/packages/flutter_tools/lib/src/base/terminal.dart
+++ b/packages/flutter_tools/lib/src/base/terminal.dart
@@ -288,7 +288,7 @@ class AnsiTerminal implements Terminal {
         // prompt ends with ': '
         logger.printStatus(': ', emphasis: true, newline: false);
       }
-      choice = await keystrokes.first;
+      choice = (await keystrokes.first).trim();
       logger.printStatus(choice);
     }
     singleCharMode = false;


Helpy IMAP

Finally, IMAP is ready for Helpy.  I have taken the previous work and packaged it as a Rails Engine that you can add to your existing Helpy install, or by getting current with master.  This allows users who are not ready or able to upgrade to master to just add the gem instead, or skip the functionality if its not needed.
closes #810
closes #741
closes #221
closes #179
#148

Hi, first thanks a lot, it's a very nice feature !
I try to test POP or IMAP, and when i launch rake helpy:mailman i have this error

I, [2018-10-30T19:01:15.980424 #5268]  INFO -- : Got new message from<EMAIL_ADDRESS>with subject 'test3'.
#<PG::ConnectionBad: fe_sendauth: no password supplied

same error without SSL for pop and imap.

Hmmm that looks like a Postgres authentication error- not sure why you would be getting that.  Are you able to access and browse Helpy normally?  Is this in production or dev?

Yes, it's on production and i can access Helpy normally.
when i launch rake helpy:mailman

I, [2018-11-03T10:47:24.370438 #17396]  INFO -- : Mailman v0.7.3 started
I, [2018-11-03T10:47:24.370521 #17396]  INFO -- : IMAP receiver enabled (support@xx.net@mail.xx.net).
I, [2018-11-03T10:47:24.394184 #17396]  INFO -- : Polling disabled. Checking for messages once.
I, [2018-11-03T10:47:24.986242 #17396]  INFO -- : Got new message from<EMAIL_ADDRESS>with subject 'test45'.
The PGconn, PGresult, and PGError constants are deprecated, and will be
removed as of version 1.0.
You should use PG::Connection, PG::Result, and PG::Error instead, respectively.
Called from /home/rails/.rvm/gems/ruby-2.4.4@helpy/gems/activesupport-4.2.10/lib/active_support/dependencies.rb:274:in `block in require'
#<PG::ConnectionBad: fe_sendauth: no password supplied

Also when i launch rails s -e production -b xxx-p 3000
=> Booting WEBrick
=> Rails 4.2.10 application starting in production on http://xxx:3000
=> Run rails server -h for more startup options
=> Ctrl-C to shutdown server
The PGconn, PGresult, and PGError constants are deprecated, and will be
removed as of version 1.0.
You should use PG::Connection, PG::Result, and PG::Error instead, respectively.
Called from /home/rails/.rvm/gems/ruby-2.4.4@helpy/gems/activesupport-4.2.10/lib/active_support/dependencies.rb:274:in `block in require'

Any ideas ?
I follow this doc to install helpy https://github.com/helpyio/helpy/wiki/WIP-Install-on-18.04

it does not work in Docker. I tried everything. did anyone test it on Docker?


[Tooltip] add no max width tooltip with the sx prop

Creates an example using the sx prop to create a no max width tooltip.

@chrstnfrrs There is no need to have the same demo similar to the previous one but with the sx prop.


Datadog distribution metric support

Datadog unfortunately has a new metric type called distribution that we'd like to use.
I think the easiest way (for me) would be to allow a custom formatter instead of the standard and Datadog formatters. I can then add a custom metric, and have the custom formatter send it with the |d type. telemetry_metrics already having a metric called "distribution" doesn't help of course.
Can send a PR for this change or some other solution.

@hkrutzer as I understand it, DataDog's distribution is like a histogram but allows aggregation from multiple agents, correct?
In that case, a custom metric + formatter would be indeed a way to go. I suppose the only required change is to make a behaviour here public, and to allow passing a module name as a formatter.

@arkgil correct! I have some code that I will contribute this week.


Removing topology should also remove topology test run histories

This triggers FK reference issue and makes topology deletion failing.
This also applies to HDF-3.0-maint, though we don't expose the feature "test topology run" in HDF-3.0.x version.

#872 will cover this issue.


Debug: iFrame cannot re-render with new song

v1:21 The Spotify Iframe API has already been initialized.


Add missing functionality/methods

Current report (node scripts/validate-interfaces.js):
Missing API interface functions:

[ ] BrowserContext.SetHTTPCredentials
[ ] BrowserContext.StorageState
[ ] ElementHandle.WaitForElementState
[ ] ElementHandle.WaitForSelector

Hi Max,
Great project you have here, I like it a lot. I want to use this in one of my projects, but the pages contain a lot of dropdowns, which I don't know how to handle at the moment without Page.selectOption. Is implementing Page.selectOption currently on your roadmap? If not, can you point me in the right direction for me to implement it?

Hi, if you want feel free to add it yourself as Pull Request, as a reference it might just need a 1:1 wrapper from Playwright for Python and some tests. If you don't feel comfortable, then I can also implement it, probably during end of the week.

Thanks! I will take a stab at if I get the time before the weekend.

I just wanted to inform you that I did not find the time to fix the issue. Sorry about that.

@tutturen FYI a few weeks ago SelectOption was added by @lcmtwn 🚀

@tutturen FYI a few weeks ago SelectOption was added by @lcmtwn 🚀

That is nice! Thanks for letting me know!

That is nice! Thanks for letting me know!


Problem_Statement_17

Given an integer n, return the number of ways you can write n as the sum of consecutive positive integers.
Example :
Input: n = 5
Output: 2
Explanation: 5 = 2 + 3

@vishakha-managoli I am Mahevash Patel 2nd yr student at CCOEW may you please assign this issue to me

Hello, I am Radhika Wadekar from T.Y. CCEW. I would like to work on this issue.

You have been assigned this problem statement. You will be getting 3 days to work on it. All the best.


Error while making the preprocessing/build .

Hey I keep encountering the following error: //usr/lib/x86_64-linux-gnu/libboost_system.so.1.65.1: error adding symbols: DSO missing from command line when I run make -j in preprocessing/build.
Any idea how do I go about this?
Thanks.

Hey my team member helped me out.
The way I solved this was changing the following :
find_package(Boost COMPONENTS filesystem REQUIRED)
To
find_package(Boost COMPONENTS filesystem system REQUIRED)


Can not handle bar character

When parsing a valid d.ts file which contains the following line, typescript-docs crashes.
type verbTense = "present" | "past" | "future"
Reading input file...
Lexing tokens...
Error from lexer: Error: Unexpected character "|" at line 5, column 30
    at Object.error (/usr/local/lib/node_modules/typescript-docs/index.js:683:12)
    at go (/usr/local/lib/node_modules/typescript-docs/index.js:2883:103)
    at /usr/local/lib/node_modules/typescript-docs/index.js:2209:162
    at __do (/usr/local/lib/node_modules/typescript-docs/index.js:2897:23)
    at /usr/local/lib/node_modules/typescript-docs/index.js:635:20
    at /usr/local/lib/node_modules/typescript-docs/index.js:635:24
    at /usr/local/lib/node_modules/typescript-docs/index.js:698:18
    at Object.runPure (/usr/local/lib/node_modules/typescript-docs/index.js:642:14)
    at Object.PS.Language_TypeScript_Lexer.lex (/usr/local/lib/node_modules/typescript-docs/index.js:2895:34)

    at __do (/usr/local/lib/node_modules/typescript-docs/index.js:5409:55)

This library isn't really maintained any more. It only supports an older version of TypeScript, which didn't have union types.


fix(segments): fix the parsing of relative move to

Before this patch, the result of the test would have been```
[
'17,25270',
NaN
]

Thanks!
Released to NPM as v1.0.24.


node: migrate to Homebrew

Deleting node from cask as part of deduplication process . See context here.
Please note that this PR is created to continue case-by-case discussions from thread linked above and if decision is made not to remove the cask, PR will be closed.
cc @MikeMcQuaid

Thanks!


Ability to pass a context object to the serialization methods

Initial Checks

[X] I have searched Google & GitHub for similar requests and couldn't find anything
[X] I have read and followed the docs and still think this feature is missing

Description
Similarly to how .model_validate() accepts a context parameter in order "to dynamically update the validation behavior during runtime", it would symmetrically be useful to pass a context object to .model_dump()/.model_dump_json() in order to dynamically update the serialization behavior during runtime.
I have found myself in need of this feature, yet have been stuck with incomplete workarounds.

In v2, the closest feature is the json_encoders parameter of the model config, which allows us to customize the serialization per type. However, there are 2 problems with this approach:

The most evident one is the fact that the serialization customization is limited to a per-type approach; that's not flexible enough;
The second problem is that using the json_encoders is not dynamic, as it is done through the model config. If one were to dynamically customize the serialization, one would have to modify the model_config.json_encoders temporarily, and that is not what a model config is supposed to be used for; it's not handy, nor is it safe (what if the model is dumped by another process at while the json_encoders have been modified?).

import pydantic

class MyCustomType:
    pass

class MyModel(pydantic.BaseModel):
    x: MyCustomType

m = MyModel(x=MyCustomType())
# temporarily modify the json_encoders
m.model_config.json_encoders = {MyCustomType: lambda _: "contextual serialization"}
print(m.model_dump_json())
#> {"x": "contextual serialization"}
# reset the json_encoders
m.model_config.json_encoders = {}

In v1, the closest feature is the encoder parameter of .json(), which also allows us to customize the serialization per type. While the customization is still limited to a per-type approach, in this case the serialization customization is truly dynamic, in contrary to using json_encoders. However, there is another caveat that comes with it: the custom encoder function is only called after the standard types supported by the json.dumps have been dumped, which means one can't have a custom type inheriting from those standard types.import pydantic
import pydantic.json

class MyCustomType:
    pass

class MyModel(pydantic.BaseModel):
    x: MyCustomType

m = MyModel(x=MyCustomType())

def my_custom_encoder(obj):
    if isinstance(obj, MyCustomType):
        return "contextual serialization"
    return pydantic.json.pydantic_encoder(obj)

print(m.json(encoder=my_custom_encoder))
#> {"x": "contextual serialization"}

Hence why it would make sense to support passing a custom context to .model_dump()/.model_dump_json(), which would then be made available to the decorated serialization methods (decorated by @field_serializer or @model_serializer) and to the .__get_pydantic_core_schema__() method.
import pydantic

class MyCustomType:
    def __repr__(self):
        return 'my custom type'

class MyModel(pydantic.BaseModel):
    x: MyCustomType

    @pydantic.field_serializer('x')
    def contextual_serializer(self, value, context):
        # just an example of how we can utilize a context
        is_allowed = context.get('is_allowed')
        if is_allowed:
            return f'{value} is allowed'
        return f'{value} is not allowed'

m = MyModel(x=MyCustomType())
print(m.model_dump(context={'is_allowed': True}))
#> {"x": "my custom type is allowed"}
print(m.model_dump(context={'is_allowed': False}))
#> {"x": "my custom type is not allowed"}

What are your thoughts on this?
I believe it makes sense to implement the possiblity of dynamic serialization customization. I believe that possibility is not yet (fully) covered with what's currently available to us.
What I'm still unsure of is:

Should that context also be made available to PlainSerializer and WrapSerializer?
In what form should this context be made available? While the decorated validation methods have access to such a context using their info parameter (which is of type FieldValidationInfo), the FieldSerializationInfo type does not have a context attribute;
And ofc, how to implement it.

Affected Components

[ ] Compatibility between releases
[ ] Data validation/parsing
[X] Data serialization - .model_dump() and .model_dump_json()
[X] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - model_construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

Selected Assignee: @lig

I've been waiting for someone to request this feature! I think it's 100% reasonable and would like to see it added.
I'm sure we'll get to this at some point, but PR would be very welcome. I think it might require getting hands dirty with pydantic-core and Rust though.

#7242 could also benefit from this use-case.

I'd also be very interested in this. I have some configuration data that I want to serialise into a few different formats (JSON, YAML, environment variables, CLI flags), and some fields should be omitted from some of the formats, and some may have different behaviour or naming based on the target format and the metadata attached to the field.
For now I've decided to just stick to vanilla dataclasses since I found myself having to essentially reimplement the entire serialisation process myself anyway without Pydantic having any way of including context or dynamically omitting fields (at least without traversing the entire model yourself ahead of time to construct an exclude dict), but I'm definitely sad about losing out on the free, type-checked deserialisation that Pydantic provided.

The third problem with json_encoders is that it is "deprecated and will likely be removed in the future".
Hard +1 on this. There's a symmetry with custom validation that is currently broken by this. A custom validator can e.g. parse a string from the wire to a better structured type using context, but there is no way to serialise it using context to send it back to the wire.

made a PR for this in pydantic-core: pydantic/pydantic-core#1215


Mark non-scoopable systems in trip list

As the star class is given like [M] in the trip list, maybe color the non-scoopable (aka all other star class than OBAFGKM) the star class symbol in red?
So that it is clearly visible when there's a non-fuel gap ahead where you definitely want to start with full fuel tanks.
[M]- default color from HUD
[TTS] - red color from HUD

So create some style information around that line 366 in index.html:
let starClass = "["+(systemInfo.StarClass?systemInfo.StarClass:"?")+"]";

Good call! I like it 👌🏻


Test suite should block non-locally-built images

The integrations tests need backend services to test with; mostly this role is filled by kat-server, but there are a few other stand-alone images in docker/test-*/.  Those are fine.  But there are also a handful of backends that are entirely 3rd-party... those are a problem.
Take an example:
I was looking at the KAT tests today, and saw this bit of YAML getting applied:
    image: docker.io/johnesmet/go-websocket-echo-server:latest

This isn't to pick on John in particular, there have been other images like this from Cynthia and even from Flynn; it's just that the one I came across today happens to be from him.
This image is a problem for several reasons:

It's not clear where the source code is; this amounts to a part of the test suite that can't be edited.
It's an opportunity for someone outside of the Emissary org to break our CI (not that I think John or anyone else would intentionally break it)
If John is compromised, the image could be changed to compromise embargoed secrets.

We've been counting on code review to make sure that all images we use are sourced from emissary.git; clearly this isn't working. It's too easy for a contributor to hack together an image, mean to clean that up later, and then it gets merged. We should set up policies in test clusters to disallow pulling images from registries other than the registry that the test pushes its locally built images to.

This may dovetail with @kflynn's work on not having CI require registry credentials.


Decimal mask not displaying correctly (Input mask.js)

Hello!
I hope all is well,
The decimal type input is not displaying as one would expect, there is an issue regarding the format of the value, it will then save with the incorrect format muddling up the value each time the update form is called
So if i do a fresh install and use a decimal I get the following behavior
On Create

On Grid after create

On update [** Where the issue sits **]

If the user doesn't notice this , it gets saved. and when its saved, it will take the value of 30 000 rather than 300.00
I traced this down to /public/vendor/open-admin/inputmask/inputmask.js
Bad excuse but it was late and I ended up making a change to the min.js and managed to get the issue sorted, but i think this is treating the Symptom rather than the root cause, theres a ternary somewhere in the minified / obfuscated dist code, that returns the element, something going wrong there, if the problem is infact in the JS i will be happy to trace it down again

Please find attached (inputmast.js modified)
Though i don't think it will help much in this case
Uploading inputmask.min.js…
Let me know what I can do from my side!
I will continue cracking at it over the weekend

@NealRyanCruickshank thanks for reporting this issue and supplying a fix. I ended updating the original library which seems to fix the issue. Next to that please also note the field you use should be a field that can handle decimal values. A string field might also work, but that seems a bit out of place.

now fixed in v1.0.27


sway-workspaces: can't scroll on inactive monitor when "all-outputs" = false

If you have multiple monitors and only have the workspaces shown on their respective waybars, then you can't use the scroll wheel to change workspace on the inactive monitor(s).
Setting all-outputs to true allows scrolling on all monitors as expected.
sway version 1.8-dev-ca016689 (Mar 22 2022, branch 'master')
Waybar v0.9.12

Still an issue. (waybar v0.9.24)


Hit entities

idk how to fix it. Idu why it even came up. It's like the other time when two modules were also missing.

looks like something that is broken unrelated to this PR, but it still needs to be fixed (that can be done in another PR)

I would just add tls to the list of fallback

I fixed the tls issue

now idk how to put yours changes on mine

wait it works now. nice


Allow merging configs with union operator | in Python 3.9+

To be consistent with dict behavior in Python 3.9+ and simplify the syntax, it would be nice to be able to use cfg1 | cfg2 as an alternative to OmegaConf.merge(cfg1, cfg2).
Also, cfg1 |= cfg2 should be supported, which I believe has no strict equivalent in OmegaConf right now (?) (since OmegaConf.unsafe_merge() may destroy both configs)
We also want to support merging with other config-like objects, e.g. cfg | {"option": value} should return a copy of the config where option is set to value.

Good idea!

there is a merge_with method in DictConfig which is used as the lower level function for OmegaConf.merge.
It can be used for cfg1 |= cfg2


Dazzle Rework

Poison Touch: Better scaling, mostly numbers.
Shallow Grave: Nothl Protection cooldown to 30 seconds, fixed.
When taking fatal damage under Nothl Protection and Shallow Grave, the target also gains 1 armor and 2% magic resistance for each damage instance. The armor and magic resistance bonuses last for 5 seconds after Shallow Grave ends.
Shadow Wave: Shadow Wave can be cast on an enemy unit. Doing so makes the wave bounce between enemies, dealing damage to them and healing allies that are near them. Allies can be healed multiple times per wave.
When a Shadow Wave deals damage to a Poison Touched enemy, all further enemies that the wave bounces to get affected by the debuff as well.  (full duration)
Shadow Wave heal/damage radius change to 250.
Weave: Every 4 seconds, Sub-Weaves are cast in the original location, over the duration. Units that do not yet have the buff/debuff get it normally. Sub-Weaves instantly shifts the armor of the target. The armor keeps stacking normally until the duration ends.
New scepter effect: Grants a new ability: Resurrection.
Resurrection: Can only be cast on dead allies teammates, used through the player portraits on the top bar. After a 3 seconds delay, the teammate respawns with full health and mana. Resurrected heroes respawn near Dazzle's location. Cannot be used on Disable Help players.
Has global range, 250 mana cost, 100 seconds cooldown.

TALENTS:
Remove:
+175 Shadow Wave bounce distance
+65 Shadow Wave damage radius
-15 Weave CD.
+60 Shadow Wave damage/heal
-15 Nothl Protection CD.
-5 Poison Touch CD.
Shallow Grave costs no mana.
Apply:

Shadow Wave bounces in a 1 second delay between each target. However, each target can be healed again by a bounce if 5 seconds have passed. A maximum of 3 bouncing waves can exist at the same time.
Shadow Wave bounces on allies can heal surrounding allies in the damage radius, and Shadow Wave bounces on enemies can damage surrounding enemies in that radius.
All excess damage stored by Shallow Grave/Nothl Protection is released as a Healing Wave, healing all nearby allies for 50% of excess damage. This wave does not damage enemies.
After Poison Touch's poison has finished setting in, every 120 damage taken slows the target by 3%. Can scale up to 80%.
Enemies that interact in any way a unit that has the Poison Touch debuff get the debuff as well. Interactions are using a skill or an item on the target.
Nothl Protection is now applied on every allied hero in 900 AoE. Nothl Protection triggers automatically on a fatal strike and lasts 1.5 seconds. It needs to recharge for the same duration of Dazzle's own Nothl Protection.
Weave now fully affects buildings as well.

comments/suggestions:

shadow wave/poison touch is really really strong.  Please think it over carefully!
talent 4: would maybe make this scale with target's max health (i.e. 3% slow every 3% of max health taken as damage, or similar. vaguely similar to timber's charm slow).
talent 6 is a bit too similar to WK's wraith aura?

shadow wave/poison touch is really really strong.

Really? I think it's conditional. It's good as a situational occurrence. What are you think is so strong about it?

talent 1: good luck coding that! really cool tho.

Shouldn't be a problem. Indexing in an projectile_extra_data does the job well.

talent 2 is insane on clumped up enemies. its echo slam on super steroids. Please think it over carefully!

I see your point. Maybe just retain the healing aspect, for a possible echo slam healing?

talent 4: would maybe make this scale with target's max health (i.e. 3% slow every 3% of max health taken as damage, or similar. vaguely similar to timber's charm slow).

Good idea.

talent 6 is a bit too similar to WK's wraith aura?

Not quite. Dying in WK's Wraith Aura means you're dead, period, do what you can for the duration. This can actually save you from death, and more than that, in certain situations (Troll is max-speed attacking you? lul) be returned to full health.

Done!


Add a project based on classification model in the repository

Description
I have added a Fake job Listings project based on classification model inside the Classification Model repository.
AIM OF THE PROJECT IS IDENTIFYING FAKE JOB LISTINGS: BUILD A CLASSIFICATION MODEL TO DETERMINE THE LEGITIMACY OF JOB POSTINGS. I have used the Random Forest classifier in this project.
Name: Sibangi Boxipatro
GitHub ID: Sibangi-2911
Email ID<EMAIL_ADDRESS>**Idenitfy yourself: gssoc-extd , hacktoberfest (Contributor)
Fixes # (issue)
#1273 issue number resolved by me as it was assigned to me.
I have added a Fake job Listings project based on classification model inside the Classification Model repository.
Type of change

[ ] Added a new machine learning frameworks, libraries or software.
[ ] Documentation update
[x] No Documentation update required
[x] Added a new Machine Learning Project

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

@sanjay-kv please accept my pull request

@sanjay-kv Please accept my pull request


[#931] Implemented 1

Main changes:

plot_diagnostic_coverage(dax=dict) works, wit optionally user-specified colorbar axes

Issues:
Fixes, in devel, issue #931

Hello @dvezinet! Thanks for updating this PR.


[PE-D][Tester B] Unable to exit the command history without choosing one of the previous commands

When accessing command history, I am unable to exit it. If i press ESC a normal command history like in chrome's search bar would remove the suggestions, but this app chooses it
instead
Behavior differs from normal expectations

Labels: severity.Low type.FunctionalityBug
original: blaukc/ped#10

Fix in UG


Rav1dFrameContext_frame_thread::pal: Make into an aligned Vec

This also adds AlignedVec64 to have the Vec aligned, since a Vec<Align64<T>> would add extra padding between each element since it would align each element, and we only want to align the whole Vec/slice.

@kkysen @rinon I've changed to the custom allocator approach proposed in #744. Please give this another look!

LGTM overall, minor nitpicks aside.

Fixes pal field for #744.


brew list fails due to using Puppet's Ruby

2018-12-23 23:13:48 glaurung STARTING RUN
2018-12-23 23:13:57 glaurung Notice: Compiled catalog for glaurung.dathouse in environment production in 0.78 seconds
2018-12-23 23:13:58 glaurung Error: Failed to apply catalog: Execution of '/opt/brew/bin/brew list --full-name' returned 1: /opt/puppetlabs/puppet/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require': cannot load such file -- active_support/core_ext/object/blank (LoadError)
2018-12-23 23:13:58 glaurung 	from /opt/puppetlabs/puppet/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require'
2018-12-23 23:13:58 glaurung 	from /opt/brew/Library/Homebrew/global.rb:10:in `<top (required)>'
2018-12-23 23:13:58 glaurung 	from /opt/brew/Library/Homebrew/brew.rb:13:in `require_relative'
2018-12-23 23:13:58 glaurung 	from /opt/brew/Library/Homebrew/brew.rb:13:in `<main>'

Works normally though:
glaurung:Downloads ghavil$ /opt/brew/bin/brew list
glaurung:Downloads ghavil$

At least, this is my understanding of the error, I might be misreading it.

hrrrm, I'm still looking at this but, I'm pretty lost, active_support is a dep of Homebrew it seems. However, I can't figure out how this works w/ the cli but fails when Puppet runs it.

Yea, this was an issue I hit for my Mojave install as well. It's something w/ how ruby picks the gem path (where it's using the right ruby but the wrong gems)


Reformat / API Docs / Import Cleanse

Summary

All Routes now import from ... AllRoutes.jsx
All Components now import from AllComponents.jsx
Began API Docs

Description
There is further reformatting to be done like, Rendering Header once on Main load not re-Rendering with every page load.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Reformatted and Walk through feature functionality to ensure new route paths and tooling worked as before.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[JB] My code has been reviewed by at least one peer
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

I'm still getting lots of linter errors on this branch (3 spaces where there should be 2 etc.) do you want me to fix those, Daniel?

Also this branch still requires a username in the user model instead of only an email


feat: support multiple graphql endpoints

Closes #63
When the GraphQL endpoint is explicitly specified using graphql.link('/someGraphqlEndpoint'), the URL is already defined in the handler's endpoint private property. This PR leverages this to support multiple GraphQL endpoints. Therefore, the graphqlUrl option is not necessary when using the graphql.link(...) form.

Hi, I'm really interested by this missing future too which is currently a blocker to continue our tests migration.

@pjean Use below workaround until this PR is merged.
https://github.com/valendres/playwright-msw/issues/63#issuecomment-2220363901


Typescript : Propety 'getVerifiedContractAt' does not exist

I try some test.
I added this to my hardhat.config.ts:
import "hardhat-etherscan-abi"
Then I try to a following test.
import { ethers, waffle } from "hardhat";
import hre from 'hardhat';

    before(async function () {
        bank = await ethers.getVerifiedContractAt(BANK_ADDRESS);
    });

It give me a error ,
Property 'getVerifiedContractAt' does not exist on type 'typeof import("/Users/user-name/ethereum/idle-alphahomora-integration/node_modules/ethers/lib/ethers") & HardhatEthersHelpers'.

26         bank = await ethers.getVerifiedContractAt(BANK_ADDRESS);
                               ~~~~~~~~~~~~~~~~~~~~~

I also try the same test in js, it worked properly.
@poma

const hre = require("hardhat");
vault = await hre.ethers.getVerifiedContractAt(BANK_ADDRESS);

Do not use it ether

I have the same problem. I have created a HH js script that is supposed to cache the ABIs of a series of contracts.
But the function does not exists:
require('hardhat-etherscan-abi');
const hre = require("hardhat");

async function fetchAndSaveABI(contractName, address) {
  const abi = await hre.ethers.getVerifiedContractAt(address);
  // stuff
};

I tried a series of things, without success.

I don't know typescript well enough to fix this. Maybe someone can help?

The issue was that I was trying to create a script in the HH scaffold. But when I converted it into a HH task, then it worked correctly.

Is there a way to extend HardhatEthersHelpers maybe?

Have no idea... they have a discord server with a channel for plugin development, maybe you can ask there: https://discord.gg/unHHhmK92a

Anyone ever find a solution to this?


CPLP-1115 adjust AdministrationService test to new role-assignment semantics

@qxz2mqe Could you please have a look at this PR?
We noticed last week that the administration test project threw errors when building due to missing adjustment for new role-assignment semantics


Switch to GitHub Downloads

This PR changes the Godot download location to GitHub and adds tests that ensure the download URLs for export templates and each platform are generated correctly.
@definitelyokay Before merging, I'd appreciate any edge case scenarios you can think of for the install command that I might have missed. I'll adjust and add tests to cover them.
Closes #24

Ah, thank you! I missed that warning. Since we don't use the variable I removed it for now.
I just checked and unfortunately GitHub has the same file name discrepancies. I'd be happy to work on adding support for installing 3.x versions next.

@garettbass Thanks for your feedback! I just pushed a commit to change the prefix URL. My local testing suggests this is all working as expected.

@definitelyokay Yeah, good to merge 👍


Broken link

Here https://github.com/facebook/react-native/tree/master/ReactAndroid#building-react-native-for-android
This link is broke https://facebook.github.io/react-native/docs/android-building-from-source.html

See the docs on the website.
https://facebook.github.io/react-native/docs/android-building-from-source.html

Fixed in https://github.com/facebook/react-native/pull/19450.


HUD flickering while recording with OBS

Hello !
Thanks for the awesome work put in it ! I don't know why but when capturing ingame with OBS, the hud is flickering. I can provide a video if needed

Hi!
I had a look at this and made some changes to the method I was using to show the overlay.
You shouldn't have any issues with OBS any more :)


[feature] Adding DESTDIR variable to makefiles

Hello,
please consider mergin in the pull request https://github.com/jtpereyda/libdasm/pull/5
It would make packaging of libdasm easier.
Thank you
Michal Ambroz

PR #5 merged and closed


Add trials data interface

Adding data interface for trials table. Inherits from TimeIntervalsInterface, currently opting for padding with NaNs instead of using empty lists for the position/velocity fields

example file here: https://drive.google.com/file/d/1rVlEja713onTChw9qoqypr1d7yuNbT_n/view?usp=sharing

LGTM


Need instructions attached/referenced to explain how to use prerequisite installer in an Air Gap environment. (No Internet AccessO

It would be most beneficial to have instruction linked to this page that explains how to perform the SharePoint prerequisite installation in a Air Gapped environment.  I.e.
I had to search around several forums, YouTube videos etc. to come up with a process to perform the prerequisite installer.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1bb5efc7-7c39-cf26-70ef-a324d215af76
Version Independent ID: add2ba42-a910-ce5f-3767-35834085c2fa
Content: Configure SharePoint for Microsoft Identity Manager 2016
Content Source: MIMDocs/prepare-server-sharepoint.md
Product: microsoft-identity-manager
GitHub Login: @billmath
Microsoft Alias: billmath

The following issue is being closed due to the age. If this is still an issue, please re-submit this. Thank you.
#please-close


Extra 7.4 / 7.04 Requires Clarification

Looks like extra 7.04 is confusing. I assumed it would check the SGs which have no ingress filter enabled.

However this check brings up security groups, which have Ingress set to
Allow port 80 from <IP_ADDRESS>/0
Allow port 443 from <IP_ADDRESS>/0

This is a pretty simple example of a SG for a public-facing Load Balancer.
I reckon it would be nice to clarify the exact algorithm with examples of legit and non-legit groups for this check.

Hi @netflash, thanks for your comment.
As per its description 7.4 [extra74] Ensure there are no Security Groups without ingress filtering being used (Not Scored) (Not part of CIS benchmark)
What that check does is to find SGs with Name=ip-permission.cidr,Values=<IP_ADDRESS>/0, what means that has any port open to the internet, and then it checks if that SG is being used (attached to a NIC) --filters Name=group-id,Values=found-sg --query 'length(NetworkInterfaces)'. You can run bash -x ./prowler -c extra74 to see the exact commands it executes.
Do you think should be the check title somehow different?

@netflash feel free to reopen this issue if you have further questions.

Can this be updated to include what rules failed? Although the CIS concept is valid, so is having something like port 80 or port 443 open to <IP_ADDRESS>. As it stands, the output of the report requires me to go to each security group and evaluate the rules. It would be much more helpful to tell if the result is a false positive if the actual rules showed up in the report.

I don't get it @chizou can you please open a new issue with an example? I can create another check for that particular requirement


Tests don't pass when TS is retargeted to es6 and moduleResolution: node

In theory, every node version we test on supports full es6. However, if tsconfig-base.json is edited to retarget TS's build for ES6 environments, many of our services tests fail - this would seem to indicate a deficiency in our analysis somewhere. :(

This is going to spawn more work items, but since I noticed it, the first step is to setup a CI build targeting es6. Then I'll need to work on getting it green, while opening issues for the missing analysis that allowed those bugs through (since it indicates a difference in behavior between our es5 and es6 emit that we should callout in our analysis) 🙁

Looks like a couple in the compiler are due to TDZ violations in the declaration emitter. I imagine the services ones may be similar (and also doubt our analysis can catch them, since it's all about cross-call sequencing issues).


Add plugins support to talkd dialog

We should be able to make dialog extensible without messing around the original code. We can set this as a dependency injection and setting the original router to support it as importing modules. This needs to be carefully set so we don't open any security breaches such as evals and stuff.
Maybe we could use importlib as described: https://stackoverflow.com/questions/64916281/importing-modules-dynamically-in-python-3-x

Closed and stabilized by #80


Completing the CNN/Dailymail summarization pipeline

This commit adds the following features:

Raw test data generation for the train, dev and test splits for the cnn/dailymail data. This allows for evaluating the performance of the model in a way that is comparable to other models

A script to compute rouge scores using the official pyrouge distribution.

Ensure that you have pyrouge setup on your machine correctly (Will add a pyrouge test script in the future)
The script outputs warnings for empty model predictions. This is because the model did not generate a summary for that example. These were not suppressed since its a useful data point to have.

A bash script that first runs the moses tokenizer on predictions and targets and then computes the rouge score using the aforementioned pyrouge based script.

Just want to explicitly point out the changes made to utils/decoding.py in removing the extra space while generating decodes/targets files, since it was never merged before. Not sure if that might break other things.

I signed it


[Highlight] Highlighting row only in view

Hi,
I have a problem with the row highlight. I'm trying to use SHIFT + KEYS, to highlight the row and do some tests, but the codemirror are highlighting only the view of the row, I needed to highlight all the row, with whitespace and any characters that are on the row.

What can I do?
Regards,
Victor Magalhães.

Does this still occur in the current version? Can you reproduce it in the demos on the website?

Does this still occur in the current version? Can you reproduce it in the demos on the website?

I'm using the ngx-codemirror 1.3.10 and the codemirror 5.49.2. I think the ngx-codemirror no affect in the problem. Maybe the dialog?

Maybe. Can you reduce this to the minimal wrapping/styling that causes it?

I also have an issue with highlighting rows.
I'm using the active-line.js addon, and when I try to highlight characters with SHIFT+ARROW KEYS, it removes the activeLine class from the highlighted lines and doesn't highlight anything.
Anyone come across that?

I think you want a styleActiveLine: {nonEmpty: true} option.

Closing this until a reproduction with plain CodeMirror is available.


Is an port of the M33 available i am using stmL5 ?

I have a NUCLEO-L552ZE board for my development, which uses the arm cortex M33 chip. Is a port of the same available.

Hi @mebiGit - we are working on getting our M33 port up in the next week or two!


Allow navigation from a Person to their list of Appointments

As per our user stories, add a new function to allow our clerk to display all the Appointments that a Contact has. (Note: Contact and Person will be used interchangeably because we've yet to refactor the Person from AB3 to Contact in RT)
Intended usage: given a currently displayed list of Contact details, the user (Mr Surya) can type ga 1 to view all the Appointment instances associated with the Contact with index 1 currently displayed (fun fact: ga is short for "go to appointments").
Intended Input: ga INDEX
MSS

Actor searches for appointments related to a specific contact.
System displays the appointments related to that specific contact.
Use case ends.

Extensions
1a. The given index is invalid.
1a1. System displays an error message.
Use case resumes at step 1.
2a. The list is empty.
Use case ends.

Blocked by #52

Partially resolved by #107


Crash 1.7.10 v9

cant make mekanism work here is the crash report
http://pastebin.com/Qmps355h

Not a Mekanism crash

then what is it?


zep_could memory error： TypeError: ZepCloudMemory() takes no arguments

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
from langchain_community.memory.zep_cloud_memory import ZepCloudMemory

# Set up Zep Chat History
memory = ZepCloudMemory(
    session_id=session_id,
    api_key=zep_api_key,
    return_messages=True,
    memory_key="chat_history",
)

Error Message and Stack Trace (if applicable)
TypeError: ZepCloudMemory() takes no arguments

Description
I follow the doc and write the code
from langchain_community.memory.zep_cloud_memory import ZepCloudMemory

# Set up Zep Chat History
memory = ZepCloudMemory(
    session_id=session_id,
    api_key=zep_api_key,
    return_messages=True,
    memory_key="chat_history",
)

then it raise a error:
TypeError: ZepCloudMemory() takes no arguments

so I click into the class ZepCloudMemory, the source code as below:
try:
    from langchain.memory import ConversationBufferMemory
    from zep_cloud import MemoryGetRequestMemoryType

    class ZepCloudMemory(ConversationBufferMemory):
        # something

except ImportError:
    # Placeholder object
    class ZepCloudMemory:  # type: ignore[no-redef]
        pass

the code from zep_cloud import MemoryGetRequestMemoryType  has a import error.
the code will jump into except block and retuen a class with no constructor.
System Info
python==3.10
langchain-community==0.2.5
langchain-core==0.2.33
zep-cloud==1.0.9

Hello! We're a group of students from the University of Toronto Scarborough, and we're excited to contribute to LangChain. We'd love the opportunity to investigate this bug further.


Confusing first block of notebook

I noticed several issues with the notebook,

The first set of instructions is rather confusing. Are we meant to copy/paste the bash commands into our shell? They are formatted as markdown and so they aren't executable in the notebook.
I had to make the following changes

change '/tmp/gnes-flow-demo' to 'tmp/gnes-flow-demo' (otherwise a directory was created under my user directory).
swap all mentions of ${TEST_WORKDIR} for $TEST_WORKDIR (otherwise the brackets where interested in the shell literally).
add the -p flag to the mkdir command (otherwise an error is returned about 'tmp' not existing).

If these are real issues and not just me misunderstanding I would be happy to open a quick PR?

 I:CLIClient:[bas:__i:124]:waiting channel to be ready...
It's going to stay right here


[Feature request] Holistic Scripting Tools

Having worked extensively with DQMH and AF, the number one thing that's missing for me in SMO is the holistic scripting tools.
These are the things I would like to see in the SMO editor/scripter :

A SMO renaming tool.
An event renaming tool.
Updating VI icons whenever new VIs are created.
- Along with updated banners when new SMOs are created (with unique colours)
"New VI for Data Member Access...", a tool that scripts getting and setting the private data in by-reference modules
When a new Public Method or Private Event message is created:
- If the new user events haven't been registered (for example the first Private Event), script the registration.
- Create the event case that handles the user event
- Create a new case in the SM, and have the new event case link to it
- Ability to add a description when creating the message, which is then added to the 'Send' VI description and the associated SM case.
Have Public Events handled by the TestLauncher VI.

Hey @Tom-McQuillan
There are no repositories for the JKI SMO editor tool and as far as I know, the editor code has never been open sourced.
If JKI is willing to open source the current code base, I'd volunteer to co-manage an effort with you to bring this being this to more than an MVP.

I’m pretty sure that between the three of us, we can make that happen :)
Jim Sent from my mobile.


Cannot get provided feature.

Hi @Pilhyeon:
thanks for your contribution, I cannot download the features provided by you, when I open the google drive link, there is all the files:

I am not sure this is the features that used in your repo, since I do not know how to use these files in the google drive link. Could you please check this or explain it?

I am sorry for the issue.
I guess the link to the features has been unintendedly changed when I updated the link to the pre-trained model.
I fixed the problem, so please try again.
Thanks!

I am sorry for the issue.
I guess the link to the features has been unintendedly changed when I updated the link to the pre-trained model.
I fixed the problem, so please try again.
Thanks!


fix(react): rename useIsMount & update useEffect to useIsomorphicLayoutEffect

Overview

I update useIsMount hook's name to useIsClient
Although I need to think more about the name, I named this hook because it is not an externally exported package, but an embedded hook used to distinguish whether it is a client environment or not.
I update useIsClient hook inside of Suspense.CSROnly from useEffect to useIsomorphicLayoutEffect
Although it is used differently depending on where it is used, useEffect is called at the mount stage, but useLayoutEffect is executed synchronously immediately after rendering, so it is possible to check whether it is in a client state or not first, so this hook is used.
PR Checklist

[x] I did below actions if need

I read the Contributing Guide
I added documents and tests.

@okinawaa @minsoo-web This is test using visualization
AS-IS useEffect in CSROnly
If no useIsomorphicLayoutEffect, We can check red loading... fallback on every time

TO-BE useIsomorphicLayoutEffect in CSROnly
no red loading... fallback on every time. issue resolved

// src/app/react/CSROnly1
'use client'

import { Suspense } from '@suspensive/react'
import Link from 'next/link'
import React from 'react'

export default function Page() {
  return (

      <Suspense.CSROnly fallback={
loading...
}>
        <Custom/>
      </Suspense.CSROnly>

  )
}

const Custom = () => {
  return (

      CSROnly1
      <Link href={'/react/CSROnly2'}>to CSROnly2</Link>

  )
}

// src/app/react/CSROnly2
'use client'

import { Suspense } from '@suspensive/react'
import Link from 'next/link'
import React from 'react'

export default function Page() {
  return (

      <Suspense.CSROnly fallback={
loading...
}>
        <Custom/>
      </Suspense.CSROnly>

  )
}

const Custom = () => {
  return (

      CSROnly2
      <Link href={'/react/CSROnly1'}>to CSROnly1</Link>

  )
}

I think this is cool work! big thanks to @minsoo-web making issue and resolving it 👍👍👍
@okinawaa This is an important improvement, so I hope you approve and merge this Pull Request if there are no further issues.


Create Queues and Queue Subscriptions for Enterprise Messaging

Tutorial URL: https://developers.sap.com/tutorials/cp-enterprisemessaging-queue-queuesubscription.html
Please specify the step you are referring to
Sorry guys, but this completely does not work!
After step 1 the screen looks completely different and there is no way to create a queue!

Hi,
When you subscribe the Enterprise Messaging using the subscription menu, and after that click on the "Go to application" link as mentioned in the tutorial, the Management Dashboard should open showing the messaging clients you have. You click on the client on which you want to work on, you will get to see the overview screen as has been mentioned.
Please let us know, if you are experiencing something different. An attachment will help in resolving the issue, if any.
regards
Pradeep

Thank you for your feedback. We haven't heard from you in a while, so we are closing the issue.
If you still have questions, feel free to reopen the issue.


Discrepancy in Hash Values Due to block.timestamp Handling in Foundry Scripts?

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
0.2.0
What command(s) is the bug in?
forge script
Operating System
Linux
Describe the bug
When executing a Foundry script that interacts with a smart contract on the Amoy network, an inconsistency in hash values has been observed. The script logs a specific hash value; however, querying the contract directly returns a different hash.
Observed Behavior:
The hash value logged by the Foundry script differs from the hash stored in the contract on Amoy.
Expected Behavior:
The hash values from both the script's log and the contract's storage should be identical, assuming consistent block.timestamp usage.
// script run
forge script --chain polygon-amoy script/01_Create_SubscriptionAgreement.s.sol --rpc-url polygon-amoy --broadcast --verify  --skip-simulation

// inside script
vm.startBroadcast(admin);
address[] memory parties = new address[](1);
parties[0] = 0x037f2b49721E34296fBD8F9E7e9cc6D5F9ecE7b4;
IERC20(mmc).approve(rightsAgreement, 10 * 1e18);

IRightsAccessAgreement(rightsAgreement).createAgreement(
    10 * 1e18,
    mmc,
    rightsPolicyManager,
    parties,
    ""
);

vm.stopBroadcast();

The returned in console:

The registered in explorer:

I created a method to get the stored proof and is correctly retrieved and equal to explorer:
cast call 0xe40fd877e9510c5342062f936bca8463337822a9 "agrr(uint256) (uint256)" 3 --rpc-url=polygon-amoy
result:<PHONE_NUMBER>79486255180560820321998590842742970837040172950596646736320943069278

The proof is generated based on the struct and the following code:
T.Agreement({
     active: true, // the agreement status, true for active, false for closed.
     broker: broker, // the authorized account to manage the agreement
     currency: currency, // the currency used in transaction
     initiator: msg.sender, // the tx initiator
     amount: amount, // the transaction amount
     fees: deductions, // the protocol fees of the agreement
     available: available, // the remaining amount after fees
     createdAt: block.timestamp, // the agreement creation time <- removing this works fine
     parties: parties, // the accounts related to agreement
     payload: payload // any additional data needed during agreement execution
});

 /// @dev Generates a unique proof for an agreement using keccak256 hashing.
 function _createProof(T.Agreement memory agreement) private pure returns (uint256) {
        // yes, we can encode full struct as abi.encode with extra overhead..
        bytes memory rawProof = abi.encode(agreement);
        bytes32 proof = keccak256(rawProof);
        return uint256(proof);
}

The broadcast run show the same registered data as explorer too:
{
  "address": "0xe40fd877e9510c5342062f936bca8463337822a9",
  "topics": [
    "0xb649569e5c9bb3f3eb7cc2fd396f5abc452ec3f6f6e2d62638b48d3e7fa599ca",
    "0x000000000000000000000000efbbd14082cf2fbcf5badc7ee619f0f4e36d0a5b"
  ],
  "data": "0x33bc00873025602bc8d236178b5ff91d8411e3dfc839f26183f0a7177c5d3691",
  "blockHash": "0x425e6d4eeef4e7475ae7c912e4b77834a6c067674b55b5f72bb38a5f6b1abd91",
  "blockNumber": "0xdc0c86",
  "transactionHash": "0x252129d93251cce674afe7aa557d41271dd2eef8f8e7f8bbfdb605826512ccbc",
  "transactionIndex": "0x2",
  "logIndex": "0x7",
  "removed": false
}

hey @geolffreym is the screenshot where you say The returned in console: from Traces, that is by running script with -vvvv?

Hey @grandizzy , thats right, i missed the param there..

so there's the presimulation phase, that is before tx to be included hence different block.timestamp, given a contract like
contract Counter {
    event CreatedAt(uint256 ts);

    constructor(uint256 ts) {
        emit CreatedAt(block.timestamp);
    }
}

running forge script script/Counter.s.sol --rpc-url RPC_URL -vvvv --broadcast you will see that's even before a simulation / timestamp different between these stages too
[⠒] Compiling...
No files changed, compilation skipped
Traces:
  [97106] CounterScript::run()
    ├─ [0] VM::startBroadcast()
    │   └─ ← [Return]
    ├─ [56396] → new Counter@0x5b73C5498c1E3b4dbA84de0F1833c4a029d90519
    │   ├─ emit CreatedAt(ts:<PHONE_NUMBER> [1.731e9])
    │   └─ ← [Return] 265 bytes of code
    ├─ [0] VM::stopBroadcast()
    │   └─ ← [Return]
    └─ ← [Stop]

Script ran successfully.

## Setting up 1 EVM.
==========================
Simulated On-chain Traces:

  [56396] → new Counter@0x5b73C5498c1E3b4dbA84de0F1833c4a029d90519
    ├─ emit CreatedAt(ts:<PHONE_NUMBER> [1.731e9])
    └─ ← [Return] 265 bytes of code

==========================

Chain 10

Estimated gas price: 0.000101426 gwei

Estimated total gas used for script: 150618

Estimated amount required: 0.000000015276581268 ETH

==========================

therefore not possible to see in trace the exact value resulted within mined tx. Hope this makes sense

Ok! in my case i am skipping the simulation. Anyway i realized that the returned proof is inconsistent too?
uint256 proof = IRightsAccessAgreement(rightsAgreement).createAgreement(
    10 * 1e18,
    mmc,
    rightsPolicyManager,
    parties,
    ""
);
console.logUint(proof);

presimulation always happens (even if skipping the simulation) take for example this run that won't broadcast tx because of using the default sender
forge script script/Counter.s.sol --rpc-url https://opt-mainnet.g.alchemy.com/v2/p5S0MgJrB48Y_RuVrOcVp3wLnV6Vzd8a -vvvv --broadcast --skip-simulation
[⠒] Compiling...
No files changed, compilation skipped
Traces:
  [97106] CounterScript::run()
    ├─ [0] VM::startBroadcast()
    │   └─ ← [Return]
    ├─ [56396] → new Counter@0x5b73C5498c1E3b4dbA84de0F1833c4a029d90519
    │   ├─ emit CreatedAt(ts:<PHONE_NUMBER> [1.731e9])
    │   └─ ← [Return] 265 bytes of code
    ├─ [0] VM::stopBroadcast()
    │   └─ ← [Return]
    └─ ← [Stop]

Script ran successfully.

SKIPPING ON CHAIN SIMULATION.

Transactions saved to: broadcast/Counter.s.sol/10/run-latest.json

Sensitive values saved to: cache/Counter.s.sol/10/run-latest.json

Error: You seem to be using Foundry's default sender. Be sure to set your own --sender.

The trace is not from the mined tx but from the local presimulation phase.

Don't know Next Step
On Thu, Nov 14, 2024, 5:40 PM grandizzy @.***> wrote:

presimulation always happens (even if skipping the simulation) take for
example this run that won't broadcast tx because of using the default sender
forge script script/Counter.s.sol --rpc-url https://opt-mainnet.g.alchemy.com/v2/p5S0MgJrB48Y_RuVrOcVp3wLnV6Vzd8a -vvvv --broadcast --skip-simulation
[⠒] Compiling...
No files changed, compilation skipped
Traces:
[97106] CounterScript::run()
├─ [0] VM::startBroadcast()
│   └─ ← [Return]
├─ [56396] → new @.***
│   ├─ emit CreatedAt(ts:<PHONE_NUMBER> [1.731e9])
│   └─ ← [Return] 265 bytes of code
├─ [0] VM::stopBroadcast()
│   └─ ← [Return]
└─ ← [Stop]
Script ran successfully.
SKIPPING ON CHAIN SIMULATION.
Transactions saved to: broadcast/Counter.s.sol/10/run-latest.json
Sensitive values saved to: cache/Counter.s.sol/10/run-latest.json
Error: You seem to be using Foundry's default sender. Be sure to set your own --sender.
The trace is not from the mined tx but from the local presimulation phase.
—
Reply to this email directly, view it on GitHub
https://github.com/foundry-rs/foundry/issues/9323#issuecomment-2476907771,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDCWICPTK37GD2OT6NTTSB32ATHBXAVCNFSM6AAAAABRZFHBQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZWHEYDONZXGE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Ok, just to be sure i am following you:

contract OrchestrateRightsAuthorizer is Script {
    function run() external {
        uint256 admin = vm.envUint("PRIVATE_KEY");
        address mmc = vm.envAddress("MMC");
        address rightsPolicyManager = vm.envAddress("RIGHT_POLICY_MANAGER");
        address rightsAgreement = vm.envAddress("RIGHT_ACCESS_AGREEMENT");

        vm.startBroadcast(admin);
        address[] memory parties = new address[](1);
        parties[0] = 0x037f2b49721E34296fBD8F9E7e9cc6D5F9ecE7b4;
        IERC20(mmc).approve(rightsAgreement, 10 * 1e18);
        uint256 proof = IRightsAccessAgreement(rightsAgreement).createAgreement(
            10 * 1e18,
            mmc,
            rightsPolicyManager,
            parties,
            ""
        );

        console.logUint(proof); <- this proof is the result of the simulation?
        vm.stopBroadcast();
    }
}

yep, this is probably same as https://github.com/foundry-rs/foundry/issues/8054

@geolffreym hope this clarifies why the difference, going to close this for now. Thank you

@geolffreym hope this clarifies why the difference, going to close this for now. Thank you

Yep! Thank you @grandizzy @klkvr


from time to time entering a folder displays photos underneath and freezes

sometimes (usually when starting a new session), ractive fails and the display of the photos is below the albums. Then titles/buttons overlap and myphotos freezes.

dirty fix: added try catch and automatic reload of the page


OSD-2620: Create Storage Driver Interface

/test images

/test images

/test images

Some of the tests aren't running because of these changes.
Suggested changes:

Move all files from pkg/s3/ into pkg/storage/s3/ (overwriting client.go is safe)
Delete pkg/storage/s3/s3_test

/lgtm
/approve


hover: init 2020-01-03

Motivation for this change
Add hover command to be able to run flutter mobile apps on desktop.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/116

I don't know much about flutter or hover, but gave it a build and noticed that ./result-bin/bin/app wants libflutter_engine.so but can't find it -- does a path needed to be added to its RPATH or something?

Hi @dtzWill, thanks for testing it :)
It looks like this fixed this app binary, the correct generated binary is only hover

the deps.nix is no longer necessary.
and please squash commits

Thanks @jonringer!
Done

@GrahamcOfBorg build hover

@GrahamcOfBorg build hover

@GrahamcOfBorg build hover

@GrahamcOfBorg build hover

@GrahamcOfBorg build hover

@GrahamcOfBorg build hover

@GrahamcOfBorg build hover

@GrahamcOfBorg build hover

im going out on a limb, and say the zip wasn't meant to support a mac scenario:
Archive:  /nix/store/77xjx6rilnil2c9vh8rgbard1ry924mf-libflutter_engine.zip
  inflating: FlutterEmbedder.framework.zip
mv: cannot stat 'libflutter_engine.dylib': No such file or directory

@jonringer, it looks like there's a zip inside the darwin zip :thinking:

I can open a PR for darwin shortly thereafter.

@GrahamcOfBorg build hover

please squash commits

Done @jonringer

@GrahamcOfBorg build hover

@jonringer @kalbasit, I realized that using buildGoModule with subpackage we don't need flutterEngine lib anymore, cause hover uses docker to cross-build when running the binary :D
This makes things a lot easier and compatible with darwin!

Sorry for realizing that after so many changes :/

@GrahamcOfBorg build hover

@GrahamcOfBorg build hover

@jonringer @kalbasit, I realized that using buildGoModule with subpackage we don't need flutterEngine lib anymore, because hover uses docker to cross-build when running the binary :D
This makes things a lot easier and compatible with darwin!

Sorry for realizing that after so many changes :/

Is that how it's supposed to be installed on Mac? It actually requires Docker to be installed first? Docker does not come pre-intalled on Mac, so I wonder if we need to wrap the binary with a check for Docker.

Yes @kalbasit, The only way I found to make this derivation works is to use this docker param. How can I wrap this docker check?

@GrahamcOfBorg build hover

I almost find that concerning..... that's a lot of implicit assumptions to make about a users system

@jonringer, do you disagree in wrapping with docker? I'm open to suggestions :)

docker is a big hammer, with a big runtime closure:
$ nix-build -A docker
/nix/store/bikmp0s9z7bkrpj7z0q0bmq124c7wdfc-docker-19.03.6
[18:33:25] jon@jon-desktop /home/jon/projects/nixpkgs (expect-post-patch)
$ nix path-info -Sh ./result
/nix/store/bikmp0s9z7bkrpj7z0q0bmq124c7wdfc-docker-19.03.6	 493.4M

generally go packages are less then 10 MBs
$ nix path-info -Sh ./result-bin
/nix/store/y6hsm0z6w0lpzkf5n46715n26jdawgzn-direnv-2.21.2-bin	   5.9M

Sorry @jonringer, I tried to build without docker, but I always stuck in the same... when run hover, It tries to compile go-flutter, which needs libGL and other libs, I already tried to wrap, but it looks like doesn't work :/
Trying to wrap pkgconfig with libs:
  postInstall = ''
    mkdir -p $out/share
    cp -r assets $out/share/assets
    chmod -R a+rx $out/share/assets

    wrapProgram "$out/bin/hover" \
      --prefix LD_LIBRARY_PATH : ${stdenv.lib.makeLibraryPath [ glfw libX11 libXcursor libXinerama libXrandr libXxf86vm libXi libGL]} \
      --prefix PATH : ${pkgconfig}/bin \
      --prefix PKG_CONFIG_PATH : ${glfw}/lib \
      --prefix PKG_CONFIG_PATH : ${libGL}/lib
  '';

Error when `hover run`:

That's why I tried with docker and worked, but if you have any idea, please help me :sweat_smile:

oh, you need to propagate build dependencies so they are available during run. You might be better off using buildFHSUserEnv

@jonringer I'm trying to use buildFHSUserEnv, but it looks like the generated binary when run hover run, does not find flutter that is on my $PATH. Before buildFHSUserEnv this was working, I need to add something more?
Source with buildFHSUserEnv:
{ buildGoModule, buildFHSUserEnv, docker, fetchFromGitHub, glfw, libGL, libX11, libXcursor, libXi,
  libXinerama, libXrandr, libXxf86vm, makeWrapper, stdenv}:
let
  package =  buildGoModule rec {
    pname = "hover";
    version = "unstable-2020-01-23";
    subPackages = [ "." ];

    modSha256 = "019lg3s86965jyqfy83hb52y5rb6g91prsg3ckjxbcnca68lsdja";

    src = fetchFromGitHub {
      rev = "a6f11fe3c4946c9e7cce75360902bd79a077ccf4";
      owner = "go-flutter-desktop";
      repo = pname;
      sha256 = "0pwdzd34zcbyspl7qiwfcrppr6zxp2zliqg9n8s6s3l6k7mffl9j";
    };

    nativeBuildInputs = [ makeWrapper ];

    patches = [
      ./fix-assets-path.patch
    ];
    postPatch = ''
      sed -i 's|@assetsFolder@|'"''${out}/share/assets"'|g' internal/fileutils/assets.go
    '';

    postInstall = ''
      mkdir -p $out/share
      cp -r assets $out/share/assets
      chmod -R a+rx $out/share/assets
    '';

    meta = with stdenv.lib; {
      description = "A build tool to run Flutter applications on desktop";
      homepage = "https://github.com/go-flutter-desktop/hover";
      license = licenses.bsd3;
      maintainers = [ maintainers.ericdallo ];
      platforms = platforms.linux ++ platforms.darwin;
    };
  };
in buildFHSUserEnv {
  name = package.pname;

  targetPkgs = pkgs: [
    libGL
  ];

  runScript = "hover";
}

Error:
hover: Failed to run flutter --version: exit status

@jonringer
Do you think we can merge this PR with docker as the first release?

personally, I'm against using docker at runtime as it kind of conflicts with the ethos of nix.
And I'm not familiar enough with flutter/hover to know the right way to move forward here.

I see :/
Thanks for your time @jonringer !

@jonringer I realized that was my fault, forget it about [this error].
Now I'm stuck again, but using buildFHSUserEnv and not using docker.
It fails when using hover run, cause hover tries to run a go build and can't find libGL dependencies.
Error

Derivation
{ buildGoModule, buildFHSUserEnv, pkgconfig, makeWrapper, fetchFromGitHub,
  libGL, glfw, stdenv, libX11, libXcursor, libXi, libXinerama, libXrandr,
  libXxf86vm}:
let
  pname = "hover";
  version = "unstable-2020-01-23";

  meta = with stdenv.lib; {
    description = "A build tool to run Flutter applications on desktop";
    homepage = "https://github.com/go-flutter-desktop/hover";
    license = licenses.bsd3;
    maintainers = [ maintainers.ericdallo ];
    platforms = platforms.linux ++ platforms.darwin;
  };

  fullPath = stdenv.lib.makeLibraryPath [
    glfw
    libGL
    libX11
    libXcursor
    libXi
    libXinerama
    libXrandr
    libXxf86vm
  ];

  hover = buildGoModule rec {
    inherit pname version meta;

    subPackages = [ "." ];

    modSha256 = "019lg3s86965jyqfy83hb52y5rb6g91prsg3ckjxbcnca68lsdja";

    src = fetchFromGitHub {
      rev = "a6f11fe3c4946c9e7cce75360902bd79a077ccf4";
      owner = "go-flutter-desktop";
      repo = pname;
      sha256 = "0pwdzd34zcbyspl7qiwfcrppr6zxp2zliqg9n8s6s3l6k7mffl9j";
    };

    buildInputs = [ makeWrapper pkgconfig ];

    patches = [
      ./fix-assets-path.patch
    ];

    postInstall = ''
      mkdir -p $out/share
      cp -r assets $out/share/assets
      chmod -R a+rx $out/share/assets

       wrapProgram $out/bin/hover \
        --prefix LD_LIBRARY_PATH : ${fullPath}:$out/lib/hover
    '';
  };

in  buildFHSUserEnv {
  name = "${pname}";
  targetPkgs = pkgs: [
    hover
  ];

  runScript = "hover";

It seems that the env built by buildFHSUserEnv is ignoring the dependencies from hover derivation

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/help-with-buildfhsuserenv/6014/1

using buildUserEnv to create a dev envrionment is getting out of my comfort zone. However, the headers for libX11 are contained in the "dev" output.
[14:08:41] jon@jon-desktop /home/jon/projects/nixpkgs (master)
$ nix-build -A xorg.libX11.dev
/nix/store/q3lrcl2fjcnflv2bxi3v8nwsbpljr2l8-libX11-1.6.8-dev
[14:08:59] jon@jon-desktop /home/jon/projects/nixpkgs (master)
$ tree ./result-dev
./result-dev
├── include
│   └── X11
│       ├── cursorfont.h
│       ├── ImUtil.h
│       ├── Xcms.h
│       ├── XKBlib.h
│       ├── XlibConf.h
│       ├── Xlib.h
│       ├── Xlibint.h
│       ├── Xlib-xcb.h
│       ├── Xlocale.h
│       ├── Xregion.h
│       ├── Xresource.h
│       └── Xutil.h
├── lib
│   └── pkgconfig
│       ├── x11.pc
│       └── x11-xcb.pc
└── nix-support
    └── propagated-build-inputs

this may blow up your closure size, but you might be able to do something like xorg.libX11.all, that should include all runtime, development, and documentation derivations for a given packge

@jonringer Thanks for the help! you were right! go build needs the header files that are on the dev derivation of the libs.
I added all the libs required but it fails with a segmentation fault :(
But if I use an empty nix-shell, it works!
I just to understand why this error outside the shell :thinking:
Error

On a nix shell

Current code
{ buildGoModule, buildFHSUserEnv, pkgconfig, fetchFromGitHub,
  stdenv, libXxf86vm, writeScript, xorg, libglvnd}:

let
  pname = "hover";
  version = "unstable-2020-01-23";

  libs = with xorg; [
    libXi
    libXxf86vm
    libglvnd.dev
    libX11.dev
    libXcursor.dev
    libXinerama.dev
    libXrandr.dev
    libXrender.dev
    xorgproto
  ];

  hover = buildGoModule rec {
    inherit pname version;

    meta = with stdenv.lib; {
      description = "A build tool to run Flutter applications on desktop";
      homepage = "https://github.com/go-flutter-desktop/hover";
      license = licenses.bsd3;
      maintainers = [ maintainers.ericdallo ];
      platforms = platforms.linux ++ platforms.darwin;
    };

    subPackages = [ "." ];

    modSha256 = "019lg3s86965jyqfy83hb52y5rb6g91prsg3ckjxbcnca68lsdja";

    src = fetchFromGitHub {
      rev = "a6f11fe3c4946c9e7cce75360902bd79a077ccf4";
      owner = "go-flutter-desktop";
      repo = pname;
      sha256 = "0pwdzd34zcbyspl7qiwfcrppr6zxp2zliqg9n8s6s3l6k7mffl9j";
    };

    buildInputs = [ pkgconfig ] ++ libs;

    patches = [
      ./fix-assets-path.patch
    ];

    postPatch = ''
      sed -i 's|@assetsFolder@|'"''${out}/share/assets"'|g' internal/fileutils/assets.go
    '';

    postInstall = ''
      mkdir -p $out/share
      cp -r assets $out/share/assets
      chmod -R a+rx $out/share/assets
    '';
  };

in buildFHSUserEnv rec {
  name = pname;
  targetPkgs = pkgs: [
    hover
  ] ++ libs;

  runScript = "hover";
}

If I build the derivation in a nix-shell works too:
 nix-shell -I nixpkgs=../nixpkgs/ -p hover

I realized that this segmentation fault was resulted from cache on $HOME/.cache/go-build, because I added the libglvnd.dev.
I tried to add this lib because I was not finding the GL/glx.h header lib.

Does anybody knows in which lib from nix I can find this GL/glx.h?
I'm feeling that I'm so close to make this work :persevere:

I think mesa.dev should provide this, but on derivation the mesa/include/GL folder does not contain this header, but if I download manually from the source, it contains the header, it's like mesa derivation is removing the header :thinking:

Uow, it looks like on a stable branch(nixos-19.09) mesa.dev has this header file...
Can I import a derivation mesa.dev from a stable release :man_facepalming: ?

Uow, it looks like on a stable branch(nixos-19.09) mesa.dev has this header file...
Can I import a derivation mesa.dev from a stable release man_facepalming ?

no, this is probably a version specific thing or a regression

Yeah, I imagined that..
So I'm stuck on how to get this header lib :/

using nix-locate GL/glx.h, there is one package that stands out: libglvnd.dev.

Thanks @zimbatm, but I tried this lib and result in an error as I said it [here] :pensive: (https://github.com/NixOS/nixpkgs/pull/80075#issuecomment-592831452)

My bad, I read this PR too quickly.
I found pkgs/build-support/add-opengl-runpath/setup-hook.sh which might be interesting. A few programs like tensorflow and blender call addOpenGLRunpath.

@zimbatm, thanks for the tip, I'm trying to use addOpenGLRunpath like blender, but I think I'm doing something wrong:
{ lib, buildGoModule, buildFHSUserEnv, pkgconfig, fetchFromGitHub,
  stdenv, libXxf86vm, writeScript, xorg, libglvnd, addOpenGLRunpath }:

let
  pname = "hover";
  version = "unstable-2020-01-23";

  libs = with xorg; [
    libXi
    libXxf86vm
    libglvnd.dev
    libX11.dev
    libXcursor.dev
    libXinerama.dev
    libXrandr.dev
    libXrender.dev
    xorgproto
  ];

  hover = buildGoModule rec {
    inherit pname version;

    meta = with stdenv.lib; {
      description = "A build tool to run Flutter applications on desktop";
      homepage = "https://github.com/go-flutter-desktop/hover";
      license = licenses.bsd3;
      maintainers = [ maintainers.ericdallo ];
      platforms = platforms.linux ++ platforms.darwin;
    };

    subPackages = [ "." ];

    modSha256 = "019lg3s86965jyqfy83hb52y5rb6g91prsg3ckjxbcnca68lsdja";

    src = fetchFromGitHub {
      rev = "a6f11fe3c4946c9e7cce75360902bd79a077ccf4";
      owner = "go-flutter-desktop";
      repo = pname;
      sha256 = "0pwdzd34zcbyspl7qiwfcrppr6zxp2zliqg9n8s6s3l6k7mffl9j";
    };

    nativeBuildInputs = [ addOpenGLRunpath ];

    buildInputs = [ pkgconfig ] ++ libs;

    patches = [
      ./fix-assets-path.patch
    ];

    postPatch = ''
      sed -i 's|@assetsFolder@|'"''${out}/share/assets"'|g' internal/fileutils/assets.go
    '';

    postInstall = ''
      mkdir -p $out/share
      cp -r assets $out/share/assets
      chmod -R a+rx $out/share/assets
    '';

    postFixup = ''
      addOpenGLRunpath $out/bin/hover
    '';
  };

in buildFHSUserEnv rec {
  name = pname;
  targetPkgs = pkgs: [
    hover
  ] ++ libs;

  runScript = "hover";
}

Output:

is this ready to be reviewed? looks close

@jonringer Unfortunately I was not able to get it working without using the hover docker param, this is where I stuck. But I'm using the docker version (this PR changed files) on my work for months and it's working ok.

If it works well, then I think it's able to be merged.
Smaller closures are a good goal, but it seems like you did a solid attempt to try and reduce it.
Going to let some time for people to comment if they have any strong objections, then I'll come back around and do a review + merge.

Thank you @jonringer!

Just to help having this merge, we finally got a way to make hover (without docker) running reliable in NixOS:
{ lib
, buildGoModule
, buildFHSUserEnv
, dejavu_fonts
, pkgconfig
, fetchFromGitHub
, stdenv
, roboto
, writeScript
, xorg
, libglvnd
, addOpenGLRunpath
, makeWrapper
, gcc
, go
, flutter
}:

let
  pname = "hover";
  version = "0.43.0";

  libs = with xorg; [
    libX11.dev
    libXcursor.dev
    libXext.dev
    libXi.dev
    libXinerama.dev
    libXrandr.dev
    libXrender.dev
    libXfixes.dev
    libXxf86vm
    libglvnd.dev
    xorgproto
  ];
  hover = buildGoModule rec {
    inherit pname version;

    meta = with stdenv.lib; {
      description = "A build tool to run Flutter applications on desktop";
      homepage = "https://github.com/go-flutter-desktop/hover";
      license = licenses.bsd3;
      platforms = platforms.linux ++ platforms.darwin;
    };

    subPackages = [ "." ];

    vendorSha256 = "1wr08phjm87dxim47i8449rmq5wfscvjyz65g3lxmv468x209pam";

    src = fetchFromGitHub {
      rev = "v${version}";
      owner = "go-flutter-desktop";
      repo = pname;
      sha256 = "0iw6sxg86wfdbihl2hxzn43ppdzl1p7g5b9wl8ac3xa9ix8759ax";
    };

    nativeBuildInputs = [ addOpenGLRunpath makeWrapper ];

    buildInputs = libs;

    checkRun = false;

    patches = [
      ./fix-assets-path.patch
    ];

    postPatch = ''
      sed -i 's|@assetsFolder@|'"''${out}/share/assets"'|g' internal/fileutils/assets.go
    '';

    postInstall = ''
      mkdir -p $out/share
      cp -r assets $out/share/assets
      chmod -R a+rx $out/share/assets

      wrapProgram "$out/bin/hover" \
      --prefix LD_LIBRARY_PATH : ${stdenv.lib.makeLibraryPath libs}
    '';

    postFixup = ''
      addOpenGLRunpath $out/bin/hover
    '';
  };

in
buildFHSUserEnv rec {
  name = pname;
  targetPkgs = pkgs: [
    dejavu_fonts
    flutter
    gcc
    go
    hover
    pkgconfig
    roboto
  ] ++ libs;

  runScript = "hover";
}

If @ericdallo can update this PR we probably can get his merged.

Yes, thanks for all the help @thiagokokada, I'll update it

@ericdallo Can you update the commit message? You are using version 0.4.3, not 2020-01-03.

@GrahamcOfBorg build hover

After 7 months and the help of @thiagokokada I think we are good to go here @jonringer :tada:

/marvin opt-in

/status needs_merger

@jonringer Can we have this PR merged?


example_variables_config error

Using the master branch, docker-compose up completes with error, and localhost:8080 comes
up with an error/warning:
Broken DAG: [/usr/local/airflow/dags/example_variables.py] 'Variable example_variables_config does not exist'

Duplicate issue.

Duplicate issue #14

Did this get solved? I'm facing the same issue.


Workflows - Back button on workspace editor reopens Workflows after adding workflow

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v9.0.20-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-internal team
Action Performed:
Precondition:

Workspace is under Control plan.
Workspace has a few members.

Launch New Expensify app.
Go to workspace settings > Workflows.
Tap Add approval workflow.
Go through the setup and tap Add workflow on the confirmation page.
On Workflows page, tap on app back button.
On workspace editor page, tap on app back button.

Expected Result:
App will return to workspace list.
Actual Result:
App reopens Workflows page when tapping on back button on workspace editor page after adding workflow.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/a43ae080-dd69-48ef-9c4a-9fae59da6542

View all open jobs on GitHub

We think this issue might be related to the #wave-control

Production
https://github.com/user-attachments/assets/8f97153b-0c67-4275-8200-4aae79249421

This feature is behind a beta so I am removing the feature flag cc @blazejkustra @DylanDylann

Proposal
Please re-state the problem that we are trying to solve in this issue.
After submitting a new approval workflow, pressing back from the workspace reopens the workflow page again.
What is the root cause of that problem?
When we are creating a new approval workflow, we go from selecting members step -> selecting approver step. At this point, the rhp nav stack is: [select member, select approver]. When we go next again, both screens are removed and replaced with the confirmation page.
https://github.com/Expensify/App/blob/57ef25c998748332864ae98a43579989d6529c22/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx#L186-L188
So, the confirm page will be the only one in the RHP stack. When we submit the confirmation, the app will call goBack with a fallback to the workflow page.
https://github.com/Expensify/App/blob/57ef25c998748332864ae98a43579989d6529c22/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsCreatePage.tsx#L47-L48
Because the confirm page is the only screen in the RHP, the confirm page will be replaced with the fallback route, so there is a duplicate workflow page in the nav stack.
This happens too if we refresh the page while on the confirm page.
What changes do you think we should make in order to solve the problem?

We should remove the fallback route, so till be just goBack().
It's the same as we did when editing the approval.
https://github.com/Expensify/App/blob/57ef25c998748332864ae98a43579989d6529c22/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsEditPage.tsx#L53-L54

@blazejkustra it seems this relates to the navigation bug that we discussed before. Should we want to take over this one with a navigation bug here

@shubham1206agra @bernhardoj You mean that we should remove naviagte function and only use goBack, right?

When we are creating a new approval workflow, we go from selecting members step -> selecting approver step. At this point, the rhp nav stack is: [select member, select approver]. When we go next again, both screens are removed and replaced with the confirmation page.

@tgolen @blazejkustra I believe that this bug has the same RCA as the navigation bug that we discussed in previous PR
@blimpich @shubham1206agra Maybe the navigation in the approval workflow feature will be updated soon and this bug will no longer reproduce. Let's wait for a thought from @blazejkustra

@DylanDylann I agree with Dylan, let's wait with this issue for now.

On hold!

Hold: https://github.com/Expensify/App/issues/47697

Should be resolved now with https://github.com/Expensify/App/pull/47845 merged

@shubham1206agra @bernhardoj are either of you able to reproduce the issue here?

It's not reproducible anymore.

Thanks for confirming, @bernhardoj! Closing this.


Prevent Android cpu suspend and cached app freezer

This PR contains two changes that prevent disconnections:

Use a WakeLock to prevent device from going into suspend mode.
Add dummy service in order to prevent cached app freezer from freezing the replay server.

I'm not quite sure of the purpose of this PR. You've explained the implementation detail but not why this is necessary or what is causing the disconnections. Android has developer features to prevent the screen from going off or from sleeping while applications are running, so this hasn't been a widespread problem. Can you explain exactly what the problem is that you're solving here beyond just 'prevents disconnections'?
Android is an extremely unstable and unreliable platform where almost nothing works as expected - so any Android-specific changes must be required or well justified to outweigh any risk of breaking or causing unexpected crashes/problems if they use features which are unavailable, changed, or broken on some devices.

Cached app freezer stops execution for cached processes and reduces resource usage by misbehaving apps that might attempt to operate while cached. This can happen for the RenderDoc replay server when user simply stopped using RenderDoc for a short period of time because the RenderDoc replay server only produces user perceptible changes when actions are taken on the RenderDoc client.
The WakeLock is a more speculative fix for an issue where the adb command process hangs, which I presume is due to cpu suspend (and the issue has stopped happening ever since the wake lock is introduced in our fork). I can leave that out if you are not comfortable with speculative fixes.

The freezer is disabled when the flag use_freezer is set to false or the developer option is disabled.

You can just turn it off in the developer options.

The WakeLock is a more speculative fix for an issue where the adb command process hangs, which I presume is due to cpu suspend

When does this occur?  Once the server is running the UI will ping it repeatedly which should keep it alive.


Not compatible with latest Quartz (2.3.1)

Quartz 2.3.1 uses Common.Logging 3.0
Common.Logging 3.0 is backward incompatible with Common.Logging 2.x
Additionally, Ninject.Extensions.Quartz makes calls to Common.Logging directly, but doesn't declare the dependency in the nuspec. If a dependency in the nuspec with an upper bound of <3.0 was specified, this would have prevented nuget from upgrading Quartz and Common.Logging
2015-01-16 15:43:35,893 [9] ERROR Topshelf.Hosts.ConsoleRunHost - An exception occurred System.TypeInitializationException: The type initializer for 'Ninject.Extensions.Quartz.NinjectJobFactory' threw an exception. ---> System.MissingMethodException: Method not found: 'Common.Logging.ILog Common.Logging.LogManager.GetLogger(System.Type)'.
   at Ninject.Extensions.Quartz.NinjectJobFactory..cctor()
   --- End of inner exception stack trace ---
  at Ninject.Extensions.Quartz.NinjectJobFactory..ctor(IKernel kernel)
  at DynamicInjector864dfe2094ee485d916d21d981f0c530(Object[] )
  at Ninject.Activation.Providers.StandardProvider.Create(IContext context)
  at Ninject.Activation.Context.ResolveInternal(Object scope)
  at Ninject.Activation.Context.Resolve()
  at Ninject.KernelBase.<>c__DisplayClass15.<Resolve>b__f(IBinding binding)

I took latest source and updated with the latest nuget packages for Common.Logging and Quartz to resolve the issue.

Litterally the only place where logging is used in this library is here: https://github.com/dtinteractive/Ninject.Extensions.Quartz/blob/master/Source/Ninject.Extensions.Quartz/NinjectJobFactory.cs#L52
Also, Common.Logging is not in the .nuspec file.
Because of this, I suggest to completely remove Common.Logging and that single log statement from this library.
I will create a PR for this.

When do you think you will publish the new nuget package?

I've been working on another project I'm trying to release. I'll look into when I can put some time towards this project.

A more interesting question is, why am I getting these emails? :-D
On Mar 10, 2015 10:33 PM, "Mark Huber"<EMAIL_ADDRESS>wrote:

I've been working on another project I'm trying to release. I'll look into
when I can put some time towards this project.
—
Reply to this email directly or view it on GitHub
https://github.com/dtinteractive/Ninject.Extensions.Quartz/issues/5#issuecomment-78198954
.

You're not in the organization anymore, you must have this project watched in github, this is one of the public projects @mgilcrease You will probably have to remove the watch yourself.

Hi @markhuber Can you please help do this update? Or if you grant me permission, I can do the merge and update the nuget package. Thanks!

i really need that nuget fix, when do you think you can publish it on visual studio ?

Anyone have a solution for this problem?

@gautejohan Copy/paste in your own solution. It's just three files and MIT licensed