Fix: Janky popover animation

Details

Fix for the janky animation popover
Fixed Issues

$ https://github.com/Expensify/App/issues/11059
PROPOSAL: https://github.com/Expensify/App/issues/11059#issuecomment-1273160490
Tests / QA Steps

Navigate to any chat
Click on the "+" in the compose box
try to add attachment
verify that the animation is not janky

PR Review Checklist

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

https://user-images.githubusercontent.com/70144379/197249385-a0e2f40b-9c76-4487-a5d4-6d7c6bfcaf2e.mov
Mobile Web - Chrome

https://user-images.githubusercontent.com/70144379/197249395-dfe0ef8e-3e94-4b3d-9fd0-6a331417ac34.mov
Mobile Web - Safari

https://user-images.githubusercontent.com/70144379/197249407-afe211a8-c0ca-4b53-8376-5925f2fadd8e.mov
Desktop

https://user-images.githubusercontent.com/70144379/197249486-0262beb9-9483-4ef4-b79b-80b7a9a0f9a8.mov
iOS

https://user-images.githubusercontent.com/70144379/197249423-6648373a-8b95-4e06-95ff-08108b84a437.mov
Android

https://user-images.githubusercontent.com/70144379/197249439-0e0d3ab2-146e-4341-80f8-e9b8458d025e.mov

Thanks for the changes @Uros787. Code changes look fine, I'll start with the testing and update here.

Here's the checklist.  One item in the checklist is pending as per the above comments. I did before and after tests for Android specifically. I was able to reproduce the issue in my device but it took me a while to get the speed as per the video. With the current fix, I don't see the delay which I could notice in the current build.
🎀 👀 🎀
C+ reviewed

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

https://user-images.githubusercontent.com/3069065/198408195-b5fc40ba-8453-468b-a634-463bf07f08c4.mov
Mobile Web - Chrome

https://user-images.githubusercontent.com/3069065/198408221-3e62a05a-0f27-4c16-9587-4dcfe08c41ed.mov
Mobile Web - Safari

https://user-images.githubusercontent.com/3069065/198408263-9b3aa451-0d24-46e9-a811-14cb8ded6651.mov
Desktop

https://user-images.githubusercontent.com/3069065/198408291-694ca962-d97e-441a-a8f4-886c4e7b7f34.mov
iOS

https://user-images.githubusercontent.com/3069065/198408305-55cc9d30-dcf4-40fe-abe9-5e675b7c4bbe.mov
Android

https://user-images.githubusercontent.com/3069065/198408337-972dc1ae-ff40-451a-9a11-be1aff06714b.mov

Thanks for the changes @Uros787. @AndrewGable All yours.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @AndrewGable in version: 1.2.22-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @Julesssss in version: 1.2.22-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


feat(c3): temperature step as customize

Summary by CodeRabbit

New Features

Added the ability to set a custom temperature step for the Midea C3 device.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 27.02%. Comparing base (7478b6d) to head (cf1d4a6).

Files
Patch %
Lines

midealocal/devices/c3/__init__.py
0.00%
17 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
- Coverage   27.09%   27.02%   -0.07%
==========================================
  Files          79       79
  Lines        6891     6908      +17
==========================================
  Hits         1867     1867
- Misses       5024     5041      +17

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


geolocator_windows missing Nuget.exe

🐛 Bug Report
I am using geolocator_windows. I tried to install it as mentioned here: simply added the package in pubspec.yaml.
But when running on windows this errors:
Launching lib\main.dart on Windows in debug mode...
lib\main.dart:1
Nuget.exe not found, trying to download or use cached version.
CMake Error at flutter/ephemeral/.plugin_symlinks/geolocator_windows/windows/CMakeLists.txt:33 (message):
  Failed to install nuget package Microsoft.Windows.CppWinRT.2.0.210806.1

Exception: Unable to generate build files
Exited (sigterm)

I tried to install nuget but as it seems to be only an exe it is not too clear how this should happen.

Hi @barbalex,
Thank you for submitting this issue, we will have a look at how we can improve this installation process.
As a workaround you could download the nuget.exe binary (which you already did. Save the nuget.exe binary somewhere to disk (personally I keep it in a folder C:\Tools\NuGet\) and add this folder to your PATH environment variable. When NuGet.exe is available on your path you should be able to build.

Hm. I think I found the problem. Though knowing nothing about visual studio I may be wrong.
After removing geolocator_windows I did not manage to get the project starting again. Got many errors, a lot of them mentioning visual studio 2019.
So I opened visual studio and let it run a bunch of updates. Then I restarted and found out that it needed a license and that it had run out. A few clicks later the license seemed to have been renewed (why this dance about a license that seems to cost nothing anyway, microsoft?).
A windows restart and flutter clean followed by flutter pub get later everything works now.
So it seems this was just collateral damage caused by windows build tools. Feel free to close the issue.

Great to hear you managed to get it to work. Thank you for the feedback and I will indeed close the issue. Feel free to leave a comment if you do run into troubles again and I will re-open the issue.


Tags and Instances

Hi to everyone.
I tried to integrate the instance scheduler, according the AWS Implementation guide. I have these errors:

Start and stop tags don't works;
Some instances, for some reason I can't find, are correctly stopped but they don't come up and I have this message all day: (Desired state for instance from schedule "daily-stop" is running, last desired state was running, actual state is stopped)
I can't find Cloud Metrics on CloudWatch.

BTW, thank you for your work!

Tags are only set when the instance is started/stopped by the scheduler. Looking into possible delay between the instance going into a starting state after the call to start the instance has been made
If instances are manually stopped in a running period the manual stopped state is honoured by the scheduler. As shown in the log the last desired state was running, which matches the schedule state, so the instance is not started. The instance will be started at the beginning of the next running period. If you want to enforce the schedule state then use the "enforced" flag with a value True for the used schedule.
The default CloudWatch Metrics settings must be enabled from the metrics parameter in the main template. The default metrics for an schedule can be specified by setting the metrics parameter to True for the specific schedule. See https://docs.aws.amazon.com/solutions/latest/instance-scheduler/components.html   "schedule definitions"

We looked into the issue mentioned in 1) (see above)
We're testing an update that should address the issue if there is a delay between the start/stop of the instance and the instance getting into the desired state.
Please also note that if the instance is already in the desired state (manually started/stopped) at the start/end of a period the scheduler will detect this and will not take any action and by design, will not tag the instances

Hi,
tried again and again to solve the 3rd question about CloudWatch.
Tried to correct, change conf, rebuild... Nothing at all. I'm unable to see custom metrics on my Cloudwatch metrics.
Any suggestion?

We've released several updates to this solution since this issue was created. Please let us know if you are still experiencing this problem.


the command not found after updated macos

Describe the bug
After i updated my macos ventura to version 13.2.1, the command of ni not found in my mac. Hope to fix earlier
Reproduction
https://github.com/antfu/ni
System Info
Macos ventura: v13.2.1

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

You should try install again


feat: remove a key definition of ImportMetaEnv

Description
Even if you want to make the type of ImportMetaEnv strict, you can't because [key: string]: any is specified. However, users should be able to choose whether to make the type strict or not.
/** vite-env.d.ts */

/// <reference types="vite/client" />

interface ImportMetaEnv {
  [key: string]: any // If you want to handle ImportMetaEnv ambiguously, add this by yourself.
  readonly MY_ENV: string;
{

I'll handle the lint error later.

Would you add a document about this here?
https://vite.dev/guide/env-and-mode.html#intellisense-for-typescript

What do you think of this change?

https://github.com/vitejs/vite/pull/19077/commits/43a813542165511d6071d49f315b88cb21226b64


Information regarding bullet penetration

Can't seem to find any information regarding bullet penetration. Is this something you have figured out or still an open question? Thanks again for the wonderful mod!

PMat is the closest I can think of that might control this, but I haven't played with it enough. There are a few tooltips on the PMat dropdowns with my notes.

so it looks like the first Def is what defines the hit effect (wood chips, dirt, etc) and the MatDef defines the actual penetration properties of the material.

Moved to the Material properties page on the wiki


Screen does not update after gfx.commit()

I have my screen updating code in a function and it works fine 95% of the time on the first time it is called, however, if I update some variables and call my refreshDisplay() function. I see a lot of output on the serial monitor but the display never refreshes.
#include <SPI.h>
#include "EPD_WaveShare.h"
#include "MiniGrafx.h"
#include "DisplayDriver.h"
uint16_t palette[] = {0, 1};
EPD_WaveShare epd(EPD2_9, CS, RST, DC, BUSY);
MiniGrafx gfx = MiniGrafx(&epd, BITS_PER_PIXEL, palette);

void refreshDisplay(){
uint32_t getVcc = ESP.getVcc();
float voltage=getVcc*(5.0/3204.0);
gfx.setRotation(0);
gfx.setTextRotation(0);
gfx.fillBuffer(1);
gfx.setColor(0);
gfx.setTextAlignment(TEXT_ALIGN_LEFT);
gfx.drawLine(0, 225, 296, 225);
gfx.drawLine(0, 224, 296, 224);
gfx.setFont(ArialMT_Plain_10);
gfx.drawString(90,286,(String)voltage+"V");
gfx.drawString(1,286, WiFi.localIP().toString());
gfx.setTextAlignment(TEXT_ALIGN_CENTER_BOTH);
gfx.setFont(Dialog_bold_18);
gfx.drawString(gfx.getWidth()/2, gfx.getHeight()/2+30, (String)random(1,10000));
gfx.commit();
}

At the end of setup() I call the refreshDisplay as such:
  gfx.init();
  refreshDisplay();

I'm using the Waveshare 2.9" EPD. Hopefully I am just missing something basic here.  There is no difference in serial output between a cycle that refreshes and one that doesn't.  Sometimes instead of not refreshing, the screen just gets darker and darker until I do a power cycle of the ESP8266.

I honestly didn't have too much time yet to test the 2.9" display intensively. But two things strike me: only call setRotation and init() once in the setup and not with every iteration and see if this has an effect...
Sent from my iPhone

On 8 Aug 2017, at 05:48, mattncsu<EMAIL_ADDRESS>wrote:
I have my screen updating code in a function and it works fine 95% of the time on the first time it is called, however, if I update some variables and call my refreshDisplay() function. I see a lot of output on the serial monitor but the display never refreshes.
#include <SPI.h>
#include "EPD_WaveShare.h"
#include "MiniGrafx.h"
#include "DisplayDriver.h"
uint16_t palette[] = {0, 1};
EPD_WaveShare epd(EPD2_9, CS, RST, DC, BUSY);
MiniGrafx gfx = MiniGrafx(&epd, BITS_PER_PIXEL, palette);
void refreshDisplay(){
uint32_t getVcc = ESP.getVcc();
float voltage=getVcc*(5.0/3204.0);
gfx.setRotation(0);
gfx.setTextRotation(0);
gfx.fillBuffer(1);
gfx.setColor(0);
gfx.setTextAlignment(TEXT_ALIGN_LEFT);
gfx.drawLine(0, 225, 296, 225);
gfx.drawLine(0, 224, 296, 224);
gfx.setFont(ArialMT_Plain_10);
gfx.drawString(90,286,(String)voltage+"V");
gfx.drawString(1,286, WiFi.localIP().toString());
gfx.setTextAlignment(TEXT_ALIGN_CENTER_BOTH);
gfx.setFont(Dialog_bold_18);
gfx.drawString(gfx.getWidth()/2, gfx.getHeight()/2+30, (String)random(1,10000));
gfx.commit();
}
At the end of setup() I call the refreshDisplay as such:
gfx.init();
refreshDisplay();
I'm using the Waveshare 2.9" EPD. Hopefully I am just missing something basic here. There is no difference in serial output between a cycle that refreshes and one that doesn't. Sometimes instead of not refreshing, the screen just gets darker and darker until I do a power cycle of the ESP8266.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Feature: Support multiline extraction in .ts or .html

Is there an existing issue for this?

[X] I have searched the existing issues

Is this a regression?
Yes
Current behavior
            {{transloco('Send us a ' +
                'report')}}

Expected behavior
'Send us a report' key should be recognised and added to pot file... but this is not being recognised.
Please provide a link to a minimal reproduction of the bug
https://stackblitz.com/edit/transloco-keys-manager-mulitline-issue?file=src%2Fapp%2Fapp.component.ts,package.json
cannot provide
Transloco Config
No response
Debug Logs
No response
Please provide the environment you discovered this bug in
Transloco:
Transloco Keys Manager:
Angular:
Node:
Package Manager:
OS:

Additional context
No response
I would like to make a pull request for this bug
No

@akhildhanuka You are welcome to open a PR for it.


Setting .visible(true/false) to a column already visible/invisible has a impact in performance

If a put a .visible(true/false) to a column who is already visible/invisible has a severe impact in performance.
This issue was tested on a +40k row. I suppose all caches are refreshed without checking if it's necessary do it (if I execute a .visible(true) to an already visible column think don't need refresh any cache because the column is already visible).
I need to put this code to check if the column is already visible/invisible to have a decent performance:
var visibilityState = false;
...
(an algorithm who determines if visibilityState is true or false)
...
if (column.visible() != visibilityState) {
column.visible(visibilityState);
}

Use the second parameter available to column().visible() to disable the column width calculations that are being performed. Indeed, if you are doing this in a loop you would really want to do that, and then call columns.adjust() once the loop has finished.
In future, could you post support requests in the DataTables forums please.

True! Thanks! Next time I will use the support forums


Mine Menu changing Send to Copy to clipboard

Sometimes I restart my game and the Send is just changed to copy to clipboard for every comnmand
pls fix this

What version of Mine Menu are you using?

The newest 1.12


Add a button/shortcut to the angle measuring tool to the OrientationPoints Form

We already added a "click on the map to get coordinate" option. No reason we cannot add a shortcut to the angle tool for measuring azimuth.

After feedback with Carson, we want to do more than just open the native ESRI angle tool, we want to use that tool, but force it to only show/extract the "clockwise" result.
In addition, Carson wants us to find a way to "force" the first line to be due North. This might be difficult to achieve, not sure.


Check all comments.

Comment updates made to Country and App classes.

Closing out for now. Will start new issue for one person to review comments and coordinate with team.


Fix typos in docs

Coverage remained the same at 91.299% when pulling 9468e5a1a792ea7f9cbc3212ee8f50debe3520e7 on its_full_of_typos into 99eaaa72303e58e18502dc9f56798f8e7fc7d3b1 on develop.


Python library

If there was a Python library built for the same, to test the flask applications that would be awesome.

Hey @Aryan-Deshpande, thank you for your interest in this project. I'm not sure I understand your question though. Do you mean like a Python library that runs an instance of httpbun for testing? Httpbun is itself written in Golang, so exporting it as a Python library is a little non-straightforward.

Closing this since there's few details for me to even understand what's being requested here. If there's more details in the future, happy to reopen. Thanks!


LTN Manager ALPHA

Describe the Bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'

factorio-current.log

Click on '....'

Scroll down to '....'

See error

Be certain to reproduce the issue on the same save file that you upload.
Save file & Username
Upload the save file where the bug occured. If the file is too large for GitHub, use an alternative file service.
Please also provide your in-game username so I can reproduce the conditions exactly.

Log file
Attach factorio-current.log, found in Factorio's user data directory.

Please provide the save file and tell me how to cause the crash.

Please provide a save file and I'll re-open the issue.


Update tutorials.socially.angular1.step_21.md

Adding clarity about package name prefixing. Based on discussion from issue 958

@cubitworx thank you!
can you please change you commit message to be according to the right format?


TaskList in Markdown Preview

I know there is an extension for previewing checklists: https://github.com/mjbvz/vscode-markdown-checkboxes, but when checking a box in the preview, it leaves the .md file unchecked. It seems like this integration would go in the markdown-language-features extension folder.
After adding the markdown-it-task-lists extension to the renderer, I think adding the checkbox feature would go in here:
https://github.com/microsoft/vscode/blob/df8db3a75a49b85c9636530a3557cdbc639f7bdc/extensions/markdown-language-features/preview-src/index.ts#L321-L354
Adding a check for <input type="checkbox">, getting the line number from getEditorLineNumberForPageOffset, then
if (event.target.tagName === "INPUT" && event.target.type === "checkbox") {
	const offset = event.pageY;
	const line = getEditorLineNumberForPageOffset(offset, documentVersion);
	if (typeof line === 'number' && !isNaN(line)) {
                // Toggle - [ ] <-> - [x]
                // ...
	}
}

Please file this feature request against that extension. VS Code itself targets standard markdown which does not include task lists

@mjbvz is there a way to watch for click events in the VSCode preview window from another extension? Could you point me towards that API and I can try and submit a PR


Add two new HMRA alert types

https://trello.com/c/tiCatwpE/117-add-two-new-alert-types-to-mhra-drug-device-alerts-finder-small
MHRA are removing these remaining alerts away from publications to a
finder.
Related:
https://github.com/alphagov/rummager/pull/530
https://github.com/alphagov/specialist-publisher/pull/581

:shipit:


Add tools to avoid unnecessary AssetEvent::Modified events that lead to rendering performance costs

What problem does this solve or what need does it fill?
Currently there is no way to use this pattern for assets (mainly materials) to avoid unnecessary AssetEvent::Modified events:
if material.property != xxx {
    material.property = xxx;
}

What solution would you like?
I'd like for Assets to provide entity Mut-like API:
impl<A> Assets<A> {
    #[inline]
    pub fn get_mut(&mut self, id: impl Into<AssetId<A>>) -> Option<AssetMut<A>> {
        let id: AssetId<A> = id.into();
        let result = match id {
            AssetId::Index { index, .. } => self.dense_storage.get_mut(index),
            AssetId::Uuid { uuid } => self.hash_map.get_mut(&uuid),
        };
        Some(AssetMut {
            id,
            asset: result?,
            queued_events: Some(&mut self.queued_events),
        })
    }
}

struct AssetMut<'a, A> {
    id: AssetId<A>,
    asset: &'a mut A,
    queued_events: Option<&'a mut Vec<AssetEvent<A>>>,
}

impl<'a, A> AssetMut<'a, A> {
    pub fn into_inner(mut self) -> &'a mut A {
        self.notify_modified();
        self.asset
    }

    fn notify_modified(&mut self) {
        // notify only once
        if let Some(queued_events) = self.queued_events.take() {
            queued_events.push(AssetEvent::Modified { id: self.id });
        }
    }
}

impl<'a, A> Deref for AssetMut<'a, A> {
    type Target = A;

    fn deref(&self) -> &Self::Target {
        self.asset
    }
}

impl<'a, A> DerefMut for AssetMut<'a, A> {
    fn deref_mut(&mut self) -> &mut Self::Target {
        self.notify_modified();
        self.asset
    }
}

This is just a quick snippet from my head, don't know if it even compiles.
What alternative(s) have you considered?
There are two alternatives (that I know of):

store current value in the component and compare to it instead of value in the material
get material twice from the assets (get for checking value and get_mut to change). This is very user-unfriendly because of Option<T> result and also double indexing is bad by itself.

Additional context
This also should sensibly improve performance when devs (like me) are lazy and don't want to create additional components for optimization.
Just as an example in my project on my machine in debug mode (with opt-level = 3 for bevy) constantly mutating materials (approx. 50-100 per frame) drops fps from 120- to 90. In release mode it is still 120 but such a huge drop in debug (I wouldn't even think about consequences if not for this drop) still means that a lot of stuff happens under the hood. From what I understood from the sources, AssetEvent::Modified leads to the material re-extraction to the render world and re-uploading new values to the GPU.

Seems reasonable to , but can you explain the pattern /andwhy you're doing this a bit more clearly? I want to be sure we understand the root cause before designing fixes.
P.S. You may also be interested in #11266, which should help give us more powerful tools for this.

@alice-i-cecile, sure, I'll try to exmplain in more details.
Example
Basic example is following - I have some material with field that needs to be animated (lets assume this shader will dissolve an object in some way):
#[derive(Asset, TypePath, AsBindGroup, Debug, Clone)]
struct DissolveMaterial {
    #[uniform(0)]
    pub dissolve: f32,
}

And I want to animate it:
fn dissolve_materials(
    query: Query<&MeshMaterial3d<DissolveMaterial>>,
    mut materials: ResMut<Assets<DissolveMaterial>>,
    time: Res<Time>,
) {
    let dissolve_by = time.delta_secs();
    for material in query.iter() {
        if let Some(material) = materials.get_mut(&material.0) {
            material.dissolve = (material.dissolve + dissolve_by).clamp(0.0, 1.0);
        }
    }
}

Problem
Now we have a problem - when dissolve field reaches 1.0 it will stop changing and will not visually affect anything. But the mere fact that we call Assets::get_mut causes it to send AssetEvent::Modified event, which will trigger material re-extraction to the render world and re-uploading new uniforms to the GPU (I might be wrong on the latter but it looks like it from the sources):
#[inline]
pub fn get_mut(&mut self, id: impl Into<AssetId<A>>) -> Option<&mut A> {
    let id: AssetId<A> = id.into();
    let result = match id {
        AssetId::Index { index, .. } => self.dense_storage.get_mut(index),
        AssetId::Uuid { uuid } => self.hash_map.get_mut(&uuid),
    };
    if result.is_some() {
        // this will trigger even if we never actually mutate the asset
        self.queued_events.push(AssetEvent::Modified { id });
    }
    result
}

Solution / Requested feature
What I would like to do is the same trick as currently can be done for Components to avoid Changed events (implemention is hiddent in the Mut wrapper, it marks component changed only when DerefMut/AsMut is called):
if let Some(material) = materials.get_mut(&material.0) { // AssetEvent::Modified is not triggered immediately
    let new_dissolve = (material.dissolve + dissolve_by).clamp(0.0, 1.0);
    if material.dissolve != new_dissolve { // also not triggered for immutable access
        material.dissolve = new_dissolve; // but instead is triggered here when actual mutation is happening
    }
}

But, sadly, this will not work because get_mut triggers AssetEvent::Modified immediately.
Workaround 1
Currently we can have a separate component that will store last dissolve value and use it for comparison before get_mut-ing material:
#[derive(Component)]
struct DissolveComponent {
    dissolve: f32,
}

fn dissolve_materials(
    mut query: Query<(&MeshMaterial3d<DissolveMaterial>, &mut DissolveComponent)>,
    mut materials: ResMut<Assets<DissolveMaterial>>,
    time: Res<Time>,
) {
    let dissolve_by = time.delta_secs();
    for (material, mut component) in query.iter_mut() {
        let new_dissolve = (component.dissolve + dissolve_by).clamp(0.0, 1.0);
        if component.dissolve != new_dissolve { // component will not be marked as Changed
            if let Some(material) = materials.get_mut(&material.0) {
                material.dissolve = new_dissolve;
            }
            component.dissolve = new_dissolve; // but will be marked when mutating
        }
    }
}

This works but is somewhat cumbersome, duplicates data (no longer single source of truth) and requires additional component.
Workaround 2
Other way to workaround it will be to index material twice - get for comparison and get_mut for updating:
// immutable access never sends AssetEvent::Modified event
let Some(material_ref) = materials.get(&material.0) else {
    continue;
};

let new_dissolve = (material_ref.dissolve + dissolve_by).clamp(0.0, 1.0);
if material_ref.dissolve == new_dissolve {
    continue;
}

// only now AssetEvent::Modified event will be sent
if let Some(material_mut) = materials.get_mut(&material.0) {
    material_mut.dissolve = new_dissolve;
}

This works but is somewhat cumbersome and requires double indexing.

Ah, I see: it's the set_if_neq problem but for assets :) Thanks for the explanation!

Ah, I see: it's the set_if_neq problem but for assets :) Thanks for the explanation!

I didn't even know about set_if_neq. Now that I searched for it


Package request: Firefox Nighly

Project description

Nighly Builds of Firefox
Metadata
Name: firefox-nightly

homepage URL:
https://www.mozilla.org/en-US/firefox/channel/desktop/#nightly
source URL:
https://searchfox.org/mozilla-central/source
license: mit, bsd, gpl2+ , ...
Mozilla Public License 2.0
platforms: unix, linux, darwin, ...
All

Add a :+1: reaction to issues you find important.

I suggest using https://github.com/nix-community/flake-firefox-nightly instead.


support true color

Category

[x] fzf binary
[ ] fzf-tmux script
[ ] Key bindings
[ ] Completion
[x] Vim
[x] Neovim
[ ] Etc.

OS

[x] Linux
[x] Mac OS X
[x] Windows
[x] Windows Subsystem for Linux
[x] Etc.

Shell

[x] bash
[x] zsh
[x] fish

Would allow fzf.vim to properly display gui vim colorschemes.

Experimental support for 24-bit colors in --color option is in https://github.com/junegunn/fzf/commit/ae274158de38181bca27f2ce54c8b4fc0b688eff. However, I'm running into https://github.com/neovim/neovim/issues/4151 when trying to start fzf with --height option within Neovim terminal. So I can't make Neovim plugin use the option at the moment.

So should this just work? Or is there something that needs to be done to enable this?

Set up your vim or neovim to use true colors (set termguicolors).
Define g:fzf_colors to tell fzf to extract colors from the current color scheme. See https://github.com/junegunn/fzf/wiki/Configuring-Vim-plugin for an example

Related: https://github.com/junegunn/fzf/issues/818

Sorry, didn't mean in vim. What I meant is if I'm running a terminal emulator that supports true color and has it enabled correctly, will fzf automatically run in true color as well (in the terminal, not vim), or do I need to do anything extra to enable it for fzf?

Yep. Colors are customizable via --color.
fzf --color 'fg:#839496,fg+:#93a1a1,bg:#002b36,bg+:#073642' --height 50%

Cool, thanks!


Feature: Notification Query

Add a wrapper for SWbemServices.ExecNotificationQuery
(provides live event notifications which nicely mirrors golang channel semantic)
cc @vl-bizone @kolesnikovae

Have you embedded decoder and mutex into the NotificationQuery on purpose?
Not sure if it's not intended behaviour but: if you call Stop() prior to consume from eventCh, StartNotifications() will never return. It worth to document or eliminate the condition.


Bugfix: negative epochs crash

Fix 1: A parsing error means we just keep the original number around.

(This is just a suggestion, and the maintainers might prefer an alternative solution.)

Since the regex is looking for 19 digits only, this will fix the issue,
as 2^63 has 19 digits but 2^64 has 20 digits. Thus with the range up
to 2^64, we're in the clear.

EDIT: The above was auto-generated with the Github CLI.
Question to @mattgodbolt (and maintainers): What is the behavior you'd like to see?
Fixes: https://github.com/aquanauts/rizzy/issues/2

I think ideally we'd ignore it and "just" print the ASCII unadorned (much as if it wasn't actually a timestamp at all) - is that easy to change? Sorry for causing a conflct (with yourself!) in the merge too!

@mattgodbolt I just reverted to the first commit, which would just keep the original text if it failed to parse as a number. Is this what you meant?
BTW: Which style do you prefer?
"Functional" using map() and unwrap_or:
            replaced = NS_RE
                .replace_all(&replaced, |caps: &Captures<'_>| {
                    let m = caps.get(0).unwrap().as_str();
                    let s: String = m
                        .parse::<i64>()
                        .map(|ts| {
                            let utc_time = NaiveDateTime::from_timestamp(
                                ts / 1_000_000_000,
                                (ts % 1_000_000_000) as u32,
                            );
                            self.format_time(&utc_time)
                        })
                        .unwrap_or(m.to_string());
                    s
                })
                .to_string();

"Procedural" using a match block:
           replaced = NS_RE
                 .replace_all(&replaced, |caps: &Captures<'_>| {
                     match caps.get(0).unwrap().as_str().parse::<i64>() {
                         Ok(ts) => {
                             let utc_time = NaiveDateTime::from_timestamp(
                                 ts / 1_000_000_000,
                                 (ts % 1_000_000_000) as u32,
                             );
                             self.format_time(&utc_time)
                         }
                         // On parsing error (if match is too big for i64), keep the original string.
                         Err(_e) => caps.get(0).unwrap().as_str().to_string(),
                     }
                 })
                 .to_string();

keep original text if it failed.

Yup! that I think is great!

style questions

I'm actually not sure, both have merit...so ! Whichever you think is best :)

(will merge later today if I don't hear back -- we can always change the code if you have further thoughts)

Thanks!
I'd prefer the current version (using a match block).
I think it reads slightly better, and the functional doesn't add any benefit (in this case).

Awesome! Thanks so much!


Test timeouts on nightly build

Tests are occasionally timing out on nightly build, for example, https://github.com/drud/ddev-mongo/runs/6224007011?check_suite_focus=true where we see
# Failed to restart testmongo: container failed to become healthy: err=container 'mongo-express' exited, please use 'ddev logs -s mongo-express' to find out why it failed
It seems that sometimes the increased timeout from https://github.com/drud/ddev-mongo/commit/6b51df4e7512cbdeb76bb9128ada7dbe6c97704b still isn't enough

I haven't been seeing these.


Added frontend urls to constants according to environments

Updating the action to satisfy task.

Update BaseURL constant
Added new BaseUrl type
Updated print statements to use frontend

This is the output from dogfooding these changes


ENH: Adds history loading and saving

Adds saving and loading history from a NeutralNet.
This feature can be used by:
before = NeuralNetClassifier(mymodule)
before.save_history('history.json')
before.fit(X, y)
after = NeuralNetClassifier(mymodule).initialize()
after.load_history('history.json')

Use Cases:

A user wants to continue training a NeutralNet while keeping the history of the previous run. This allows for LRScheduler to work correctly during the second run, since LRScheduler relies on len(history).
After training is finished, the history.json file can be used to analyze the run.

@benjamin-work When a non JSON serializable object is passed to json.dump, it will raise a TypeError with a message similar to: "Object of type 'ndarray' is not JSON serializable". We can adjust this message, but I think the message is enough to tell the user what the issue is.

Yes, the message is already quite good. It would, however, be nice to at least mention somewhere that if the user wants to save the history, they should avoid numpy or torch types. Maybe there should be a mention of this (and generally about this new feature) in the docs/history section.

I updated this PR with documentation in the saving and loading section of docs/user/neuralnet.rst.

Is there a Callback to call save_history in each epoch?

In #246 we reached a tentative agreement that saving history should be added to the Checkpoint callback. I have it on my TODO, but haven't had time to discuss the API and implement yet.

@Atry In the mean time, the following callback would work for saving history per epoch:
class HistorySaver():
    def __init__(self, target='history.json'):
        self.target = target

    def on_epoch_end(self, net, **kwargs):
        net.save_history(self.target)


Links with nested HTML or \n confuse the markdown converter

A couple cases that generate the wrong markup.
1. nested html elements in link
foo bar foo bar

gets converted to
[foo](http://example.com/) bar foo [bar](http://example.com/)

when I would expect
[foo](http://example.com/) [bar](http://example.com/) foo bar

What happens: the walker enters the a and then enters the span again, finding the same text twice. But the proper label text was already consumed, so it consumes until it finds another match. In some cases (like above) it even linkifies the wrong text.
2. line breaks in link
foo
bar

(notice the line break) gets converted to
foo bar

when I would expect
[foo bar](https://example.com/)

What happens: the node textContent is 'foo\nbar' which doesn't match any text in the plaintext.
2b.
 in link
Another similar (but possibly harder to fix) case is
foo
bar

which like 2 doesn't create a link:
foo
bar

In general, since the code can't rely on the browser to properly deal with HTML content, some of these corner cases will probably keep popping up. But this happened in the real world (try copying and pasting the first news entry in the deprecated section here) and it seemed to be significant enough to report.
I will follow up with a PR that suggests potential fixes for 1 and 2 (but not 2b), but this is not my field so it might be far from good.

Thanks for fixing these edge cases, @sorcio ❇! Note that plaintext paste (Ctrl/Cmd + Shift + V, improvements coming) can always be used if future edge cases are encountered.


[Raycast Wallpaper] ...

Extension
https://www.raycast.com/koinzhang/raycast-wallpaper
Raycast Version
1.80.0
macOS Version
15.1
Description
I have Raycast set to auto-change my wallpaper and cycle through Raycast wallpapers every 5 minutes. However, every so often I get an "Error Setting Wallpaper" message. It says: Please make sure you have given Raycast the required permission. To make sure, click the button below and grant Raycast the 'System Events' permission. But I hae given Raycast the required permission and it still automatically changes the Wallpaper as expectd. So not really broken, just kinda annoying. Figured I'd report it anyway.
Steps To Reproduce
Not sure. It just happens randomly during the course of the day. I've uploaded my log here, which was stopped right after I got the error: https://dropover.cloud/8c0e50
Current Behaviour
No response
Expected Behaviour
No response

Thanks for the feedback, have submitted a PR #14711 to fix the issue!

@raycastbot close this issue


Initial implementation of a cache to be used in ocis services

The empty implementation covers the no-cache use case.
Local cache is thread safe and has fixed size. It has an LRU replacement
algorithm.
Shared cache among services is planned but not yet implemented.
Added hrtime library to show more information for the benchmarks

Description
Couple of implementation of caches to be used in ocis services.
Related Issue
Phase 1 of https://github.com/owncloud/ocis/issues/3475
Motivation and Context
Caching might need to be disabled if there are multiple replicas of services because the cache isn't shared among the replicas. The idea is to use the localcache implementation as base, and use the emptycache implementation if we need to disable the cache.
Additional implementations might be added in the future, specially to support a shared cache for the replicas of a service.
How Has This Been Tested?
Added tests as well as benchmarks for both implementations.
The hrtime library has been added to provide additional timings for the benchmarks (min, max, and several percentiles)
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[ ] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

Notes:

For the localcache implementation:

The native implementation for the underlying map used for the cache doesn't seem to keep a constant time for the operations based on the number of items. A bigger cache implies slower operations.
Benchmarks show maximum of milliseconds even though the average is nanoseconds.  As far as I know, our code should run in constant time.
Custom map implementation has been discarded. Although it seems to work better than the native one for really large cache size (1 million of entries), the average (50k entries) was still slower. Taking into account that the interface doesn't really provide a way to reduce the size of the cache other than manually removing the elements, the expectation is to use relatively small sizes (default is 512 entries, but a size greater than 50k isn't expected). As such, code for the custom map won't be used and it isn't provided.
Known behaviors (also commented in the code):

The implementation guarantees the no expired value will be retrieved from the cache
It doesn't guarantee that expired values will be removed from the cache (they might be eventually removed at some point due to the LRU algorithm)
It doesn't guarantee that a valid value will remain in the cache for its ttl value. Valid values might be removed to make space to fresher values.
It doesn't guarantee that expired values will be removed earlier. Valid value might be removed earlier based on the LRU algorithm.

Benchmarks

As commented, the hrtime library has been added to provide additional timings to the benchmarks. To be decided if we want it or we want other alternatives.

TODO:

~Check if we can use a RWLock in the retrieve operation. Currently, the concurrent performance is similar as with writes (store and remove) due to the general lock.~ Discarded
~Review all the text to ensure the implementations are compliant with the behavior described in the interface.~ Done

:boom: Acceptance test Core-API-Tests-ocis-storage-10 failed. Further test are cancelled...

It would be great if wco could use the go micro interface for key value stores for this instead of rolling our own. It does have a noop implementation as well as an in memory implementation and there are implementations for various other backends, including redis, nats, memcached, mysql, file, consul and cockroach ...
I'd prefer contributing to micro instead of having to implement and maintain our own abstraction.

I think the usage is quite different. The implementation of this PR is for a high-performance non-persistent cache. Basically, the idea is to replace our "ocis-pkg/sync/cache" with this, as well as to provide an easy way to switch implementations in case we need to deal with service replicas.
This is just the evolution of "use a map to cache data locally", but with an interface to provide several implementations. If we don't need to deal with service replicas, this local cache implementation will be faster just because we don't need to deal with the network.
The next step would be to provide an implementation to deal with service replicas because the local caches might be de-synced among the service replicas.
The advantage is that, we can switch the implementations easily on each service based on whether the service has replicas or not. If the service doesn't have replicas, we can use the local cache, which will be faster, and if it has replicas, we'll have to use a shared cache.
For the interface, the listing operation is a big problem in terms of performance. We need to either copy the whole structure and iterate through the copy, or lock the structure for the whole operation. If we need to deal with millions of entries it's bound to be slow either way, and concurrency will go down.
As far as I know, the go-micro store interface is designed for a distributed data store, so I assume that a whole service will implement that interface, and you'll have to access to it via the network. In this scenario, caching data locally isn't an option, and you're forced to access to a remote service even if you're the only one accessing that data.
I'm confident both this interface and go-micro store's interface can coexist, but we need to know which data should go where. I think that, if data will only belong to a specific service, we should use this PR's interface, but if the data can be shared among multiple services (user information, for example), we could use go-micro's

there is an in memory and a file implementation for the go-micro store. We could add a store package in ocis-pkg that returns a go micro store implementation. we can then chinge the implementation based on a MICRO_STORE environment variable. Similar to how we currently do it with the ocis-pkg registry.
we can then decide which implementations we want to support.

@jvillafanez can this be closed as https://github.com/owncloud/ocis/pull/4193 got merged?


Support Union narrowing with Ellipsis

Effectively the same as this issue from mypy
Ellipsis is a constant in Python, so we're able to do identity checks on it for narrowing.
This allows supporting using Ellipsis as a sentinel value where None is an accepted input.
basic example:
import types

# crude, but valid in more complex cases, such as a fallback when accessing a store
def get_val(default=...) -> int | types.EllipsisType:
    return default

x = get_val()

if x is not ...:
    reveal_type(x)

reveal_type output:
Pylance: Type of "x" is "int | ellipsis"
mypy(note): Revealed type is "builtins.int"

Moving to pyright, since this is a core type checking issue.


1.18 support?

pls

This mod is now version dependent, so the version v1.1.0 should work on all Minecraft versions
https://modrinth.com/mod/fastdecay/version/F0KjDJ3b


[5.0] setUpBeforeClass() not working - Facades not available

A code similar to this one:
public static function setUpBeforeClass() {
    Artisan::call('migrate');
}

within any unit-test doesn't work. Thrown error is class Artisan not found. This is generally true for all Facades. What to do, as I need to do a task once for each test-class at this stage? Usage of setUp() method is not viable. Thanks.

If you looking for such customisation, you need to write on your own.

Why would we need to?! Its out-of-box feature that comes with PHPUnit. Question is, what could solve the problem, if we wanted quick fix? Why this default feature of PHPUnit doesn't work in Laravel's extended version?

Your architecture must support testing units (i.e., classes or very small groups of classes) independently, not all chained together. Otherwise, you have lots of overlap between tests, so changes to one unit can cascade outwards and cause failures everywhere. http://blog.stevensanderson.com/2009/08/24/writing-great-unit-tests-best-and-worst-practises/

Having it set at setUpBeforeClass() would only load $app once from every test file/class, and that would lets above scenario to happen.
This is not the expected default behaviour for everyone else, and would without a doubt break everyone's else test case.

No official comment?

We do not process support requests here. Ask on the forums.


Verify Addresses without Synchronizer

What is your feature request?
Consider a strongly typed API for wallet addresses, instead of strings.
In addition, consider a factory method that takes in a string, validates it as an address, and emits a valid strongly typed address object (or throws an exception if the address is invalid).
How would this feature help you?
When developing the wallet UI, strings passed around are a weak type and validation of these strings is difficult to do.
Current validation APIs require access to the Synchronizer instance, which has become a bit of a God object and doesn't need to be passed around to most views when using Compose.

I Like this, we should carve out a consistent API that works and reads similarly on both platforms. And that maybe plays well with the FFI stuff

Any option to validate Zcash address, without Synchronizer?

Hi @rafaelekol, There is no progress in this matter yet, but in the current reworking of our wallet, we'll probably need to touch this.


trigger double click before zooming

can you give another sample which has the function of triggering double click first before zooming the image, please?

I've been asked a few times how to add an on/off toggle so maybe I should. It's very straightforward so I'm happy to accept any pull requests if you're up for it.

First off, great plugin. However, I'm trying to disable mobile zoom until a user double taps on the image and I can't get it to work. Have you had any success with that?

I have added a demo with an on/off toggle to the examples: http://i-like-robots.github.io/EasyZoom/
@jhollender Why not simply this?:
$('.easyzoom').one('doubletap', function() {
  $(this).easyZoom();
});

There are lots of double click/double tap custom events available, or you can implement your own.

Thanks for the info. Could you give me an example of how to make it disabled by default and click to enable the zoom? I can't quite get it to function properly.


Add support for local images

This code allows local images to work with this lib.
so no need to use CacheImage component for remote images and Image component from react-native for local images in your app.
now you just use CacheImage for both. Just like react-native-fast-image
eg:
<CachedImage
   source={require('../assets/building-image.jpg')}
 />

<CachedImage
   source={"/data/user/0/com.reactnativeimagecacheexample/cache/images_cache/5da1c490.jpg"}
/>

released on 3.0.0


Adding DecaNewton

Adding Deca prefix for Newton (Force)

Looks good, thanks! Will release shortly.

Nuget 3.56 is out.


Add i586-* builders

This adds i586-unknown-linux-gnu to the list of cross-std builders as well as
adds a whole new set of windows builders for producing the i586-pc-windows-msvc
cross-std.

cc @rillian
I'll set up nightlies once https://github.com/rust-lang/rust/pull/32593 merges as well and I think that this is all Gecko needs for 32-bit MSVC?

As far as I know. Sometimes there's "one more thing".  I'll look forward to trying your nightlies.

@rillian ok we've got nightlies for i586 MSVC now --
https://static.rust-lang.org/dist/rust-std-nightly-i586-pc-windows-msvc.tar.gz

As far as I know. Sometimes there's "one more thing".  I'll look forward to trying your nightlies.

Today's Firefox Nightly for win32 was built with the April 1st rustc targetting i586 MSVC. If that goes well, I'll re-enable execution of rust code in a few days.

Nice! Thanks for the update @rillian!

Execution was re-enabled Friday and we haven't seen any more illegal instructions, so this is working for us. Thanks again for expanding your support!

Glad to hear, and thanks for the update!

Firefox nightly for win32 is now building for i586 with rustc 1.9.0-beta.1.


Vertical JFXTabPane shows rendering artifacts

Configuring a JFXTabPane with side="Side.LEFT" results in unaligned shadows. The yellow band (with default jfoenix css applied) also gives the wrong impression that the selected tab is actually unselected.

Maybe you could attach a screenshot?

Sure, here goes. The tab with the edit icon is the active one, whereas the play tab is the unselected one.

well,it's not supported yet. this configuration is disabled in the latest version of JFoenix (it has no effect on the JFXTabPane). so it's always on the top.

Was this issue closed because it's not supported? If so then this would become a feature request, rather than a bug and should stay open.
If the issue was closed because the feature is not supported and never will then it's OK to close IMHO.

change slider color on selected tab and also change the background color of tab pane by background like this


Keywords must precede the catch-all keyword rule when generating a lexer

Fixed in one of the latest commits.


Add coordinator functionality, streamline scheduling process

Signed-off-by: Elizabeth Barron<EMAIL_ADDRESS>

The GitHub platform does not provide a good way to do DCO sign-offs.
The workaround we have is to Squash Merge in the end because have sign-off from the original commit and that's enough.

I personally think using the pull request workflow to make suggestions and revisions is too valuable to forego it in favor of enforcing DCO-signoffs on commits that will not enter the history of the repository when we squash everything.

Agreed, thank you! I installed the Chrome plugin so hopefully that won't be an issue moving forward. 👍 Thanks @GeorgLink !

@GeorgLink I think I have addressed everything and that it's ready to merge. Would appreciate one final review just to be sure. Thank you so much!

Thanks @ElizabethN for your help with this!


feat: user defined ports and healthcheck-probes

What

User can define their own

containerPort: & targetPort: if user does not provide any values then a default value will be used
livenessProbe & readinessProbe

Removed condition that makes passing resources: limit & request mandatory.

Removed default KEY: "VALUE" pair from Secret & ConfigMap.

Updated condition to control VirtualService creation.

Updated ServiceMonitor yaml to fix below warning comes after successful chart installation.

## [warning]Capturing deployment metadata failed with error: TypeError: Cannot read property 'kind' of null

What is the use of config/override-values.yml file here?
I can see that it's not mentioned in the official folder structure of helm chart. https://helm.sh/docs/topics/charts/

What is the use of config/override-values.yml file here? I can see that it's not mentioned in the official folder structure of helm chart. https://helm.sh/docs/topics/charts/

@nileshgadgi
We are using this override-values.yaml in our checkov github-action.
As per the default HelmChart structure it should not be there, but to follow HelmChart best practices we should create a new override-values.yaml instead of updating the default values.yaml.


Some fixes & Possible QOL improvements?

Hello, wanted to ask about the possibility of implementing the following fixes, all of them regarding San Andreas
1)Being Able to exit arcade minigames when playing, currently you can only do this when playing the game "Duality" on the PS2 Japanese version of the game, you were able to do it in any arcade game
2)When the player pukes upon eating 12 meals in a row, the game should display the following message "You cannot buy any more food at the moment, you will be unwell!" This can be seen if you go into the briefing, this was fixed in the definitive edition IIRC
3)Similar to the point above, when you start the Taxi driver oddjob the game should display a textbox with the message "Stop near a highlighted pedestrian to pick them up then drive them to their destination before the time runs out." this can only be seen in the briefing
Sources

https://youtu.be/q7z96t8D0xQ (6:50)
https://youtu.be/7z6ZjFmkmLI (1:00)

I don't know about 2, but 1 and 3 are definitely script.


Reload doesn't work

Type: Bug
Powershell extension showed the reload button. Clicking it did NOT clear the button. Stopping ADS and restarting it did NOT clear the button. The only way to clear it was to uninstall the extension.
Azure Data Studio version: azuredatastudio 1.49.1 (2f696aa95a13ccabd7e0a4431d1d759e3a7b8cfd, 2024-08-13T18:12:38.831Z)
OS version: Windows_NT x64 10.0.19045
Restricted Mode: No
Preview Features: Enabled
Modes:

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E3-1230 v5 @ 3.40GHz (8 x 3408)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
15.92GB (6.99GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (13)

Extension
Author (truncated)
Version

newdatabase
kev
1.0.0

admin-pack
Mic
0.0.2

admin-tool-ext-win
Mic
0.1.3

agent
Mic
0.49.0

import
Mic
1.6.1

profiler
Mic
0.14.0

query-history
Mic
0.5.3

schema-compare
Mic
1.21.0

sql-database-projects
Mic
1.4.3

schema-visualization
R0t
0.9.1

db-snapshot-creator
sea
0.1.0

simple-data-scripter
sea
0.1.6

vscodeintellicode
Vis
1.3.1

This appears to be related to inconsistent metadata for the Powershell extension.  I'll see if this can be resolved by publishing an updated extension.

Thanks for reporting this issue.  This should now be fixed with the new PowerShell extension published to the Extension Manager.  Please let me know if you see issues with any other extensions.


Populate erros list without open the Errors window

I recently migrated to vim from emacs and I am trying to set syntastic to work with python.
I want to check the file both on open and writes operations but I don't want the Errors window to be opened when I open a file. What options should I set?
So my ideal setup will be a vim screen only showing errors in the lateral of the lines, without the inferior window being opened each time I open a file.
I cannot figure out myself.
Regards.

Automatic opening of the error window is controlled by auto_loc_list (cf. :h 'syntastic_auto_loc_list'), but there is no split mode that behaves differently when checking a file on open vs. checking it on write.
On a side note: you should consider using ALE instead of syntastic, as it's actually maintained and it uses Vim 8 features to run checks asynchronously.


SetRunnableOnUnfocused() and SetWindowClosingHandled() make unfocused window unclosable

MacOS 12.4 (My only tested OS.)
Ebiten v2.3.4
(I don't know if this is expected behavior.)
If you set ebiten.SetRunnableOnUnfocused(false) and ebiten.SetWindowClosingHandled(true) and then focus another window and attempt to close the game with the red X on the title bar without focusing the game, the window will not close until it receives focus again.
This also affects the Dock: right-click and Quit will also not work until it receives focus again (which seems like the bigger issue). Option+right-click to Force Quit works, of course.
Attempting to close it and then focusing the game will cause it to immediately close, as expected.

If Ebiten isn't receiving events from the system while SetRunnableOnUnfocused is false, I understand how changing this probably wouldn't make sense. But if Ebiten can tell that the system is quitting even while unfocused, it seems like running Update() once might make sense. (Perhaps commenting in ebiten.IsWindowBeingClosed() that it should be handled in Update().) Unless that's too much, this is a pretty narrow corner case. I'm happy with a Won't Fix.
Test case:
package main

import (
	"errors"

	"github.com/hajimehoshi/ebiten/v2"
)

type Game struct {
}

func (g *Game) Update() error {
	if ebiten.IsWindowBeingClosed() {
		return errors.New("closed")
	}
	return nil
}

func (g *Game) Draw(screen *ebiten.Image) {
}

func (g *Game) Layout(outsideWidth, outsideHeight int) (int, int) {
	return 200, 200
}

func main() {
	ebiten.SetRunnableOnUnfocused(false)
	ebiten.SetWindowClosingHandled(true)
	ebiten.SetWindowSize(200, 200)
	ebiten.RunGame(&Game{})
}

I think this is a current expected behavior, and Update should not be called unless the window is focused.
A possible fix is to make the window focused when trying to quit. Let me think...


DirectML support

Feature description
DirectML (Direct Machine Learning) is a high-performance, hardware-accelerated API that can leverage the capabilities of modern GPUs and TPUs on Windows platforms. Integrating DirectML would enable Burn to run efficiently on a wider range of hardware, particularly on new Windows PCs that do not have NVIDIA GPUs.
DirectML Repository: https://github.com/microsoft/DirectML
Rust Module:  https://microsoft.github.io/windows-docs-rs/doc/windows/Win32/AI/MachineLearning/DirectML/index.html
Feature motivation
Many new Windows PCs (Copilot+ PCs) do not have an NVIDIA card. Instead, they may come equipped with integrated or alternative GPUs and TPUs, such as those found in devices using Snapdragon processors. Currently, Burn leverages LibTorch, which primarily support CPU, CUDA, and Metal. By integrating DirectML, Burn would become more versatile and accessible to users on Windows platforms, thereby broadening its adoption and usability.

Considering the feature motivation:
You forgot the WGPU back-end. That should leverage DirectX12 even on Snapdragon devices. The TPU should be usable for inference though.


[Null-aware elements] Analyzer implementation

This meta issue tracks all the analyzer implementation work items. Referenced from: https://github.com/dart-lang/sdk/blob/main/pkg/analyzer/doc/process/new_language_feature.md
Work Items

[X] AST enhancements (AstBuilder)
[ ] Element model
[x] Type system updates (should not be affected)
[ ] Summary support
[x] Resolution (should not be affected)

[x] ResolutionVisitor (should not be affected)
[x] ScopeResolverVisitor (should not be affected)
[x] ResolverVisitor (should not be affected)

[x] Index and search (should not be affected)
[ ] Warnings

[ ] ErrorVerifier
[ ] Dead code

[ ] Verify the correct dead code detection due to the changes in flow analysis.

[ ] ExitDetector
[ ] NodeLintRegistry

Hi! As part of triage, we look for updates on all P1 issues. @chloestefantsova, is there anything to update?

Awesome. Thanks for the update. Cool to see this feature cruising along!


It should be possible to scroll on a page even without being in interaction mode

How to reproduce

Be in the Pages session
Have enough items that require scrolling
Try to scroll the page

Describe the bug
Currently it is only possible to scroll while on a page if the interaction mode is activated.
Expected behavior
Scrolling needs to work both in interaction (play) and selection mode.
Operating System
macOS 13.5
Clutch Version
No response
Other
No response

Moved this to our board because I needed a small task and didn't want to take one of the "good first issue"s

Sometimes, we have some friction (it does not scroll immediately) but generally it is working.
Gracias, @joseBasso 🥳
https://github.com/clutch-creator/clutch/assets/22499533/2237db27-d1bc-4c01-ba00-299b3c9934d6

Couldn't replicate locally so I incremented the timeout. We eventually need to come up with a more robust solution that doesn't let other evens flow through but hopefully this helps for now

@joseBasso I didn't feel much difference 🥲

It looks like a bug from chromium 😢 https://bugs.chromium.org/p/chromium/issues/detail?id=1476702
We probably can't afford to wait for a fix so let's try to find a workaround


Magic_wand example on Arduino Nano 33: 'class LSM9DS1Class' has no member named 'setContinuousMode'

@tensorflow/micro
System information
Windows 10
Arduino 1.8.12 IDE
Arduino Nano 33 BLE Sense
Describe the problem
When trying Magic_wand example from https://github.com/tensorflow/tensorflow/tree/master/tensorflow/lite/micro/examples/magic_wand
during compilation, the IDE reports the following error:
arduino_accelerometer_handler.cpp:50:7: error: 'class LSM9DS1Class' has no member named 'setContinuousMode'
   IMU.setContinuousMode();

Please provide the exact sequence of commands/steps when you ran into the problem
I have followed the steps in the documentation to fix v1.0.0 of the driver. LSM9DS1.cpp looks as follows:
int LSM9DS1Class::begin()
{
  _wire->begin();

  // reset
  writeRegister(LSM9DS1_ADDRESS, LSM9DS1_CTRL_REG8, 0x05);
  writeRegister(LSM9DS1_ADDRESS_M, LSM9DS1_CTRL_REG2_M, 0x0c);

  delay(10);

  if (readRegister(LSM9DS1_ADDRESS, LSM9DS1_WHO_AM_I) != 0x68) {
    end();

    return 0;
  }

  if (readRegister(LSM9DS1_ADDRESS_M, LSM9DS1_WHO_AM_I) != 0x3d) {
    end();

    return 0;
  }

  writeRegister(LSM9DS1_ADDRESS, LSM9DS1_CTRL_REG1_G, 0x78); // 119 Hz, 2000 dps, 16 Hz BW
  writeRegister(LSM9DS1_ADDRESS, LSM9DS1_CTRL_REG6_XL, 0x70); // 119 Hz, 4G

  writeRegister(LSM9DS1_ADDRESS_M, LSM9DS1_CTRL_REG1_M, 0xb4); // Temperature compensation enable, medium performance, 20 Hz
  writeRegister(LSM9DS1_ADDRESS_M, LSM9DS1_CTRL_REG2_M, 0x00); // 4 Gauss
  writeRegister(LSM9DS1_ADDRESS_M, LSM9DS1_CTRL_REG3_M, 0x00); // Continuous conversion mode

  // Enable FIFO (see docs https://www.st.com/resource/en/datasheet/DM00103319.pdf)
  writeRegister(LSM9DS1_ADDRESS, 0x23, 0x02);
  // Set continuous mode
  writeRegister(LSM9DS1_ADDRESS, 0x2E, 0xC0);

  return 1;
}

and
int LSM9DS1Class::accelerationAvailable()
{
  //if (readRegister(LSM9DS1_ADDRESS, LSM9DS1_STATUS_REG) & 0x01) {
  //  return 1;
  //}
  // Read FIFO_SRC. If any of the rightmost 8 bits have a value, there is data
  if (readRegister(LSM9DS1_ADDRESS, 0x2F) & 63) {
    return 1;
  }
  return 0;
}

I also tried to use v1.1.0. In that case, no error during compilation and upload, but the Arduino Nano does not seem to run the code properly (no flashing LED, no serial port output).
I have tried both approaches (v.1.0.0 modified, and v.1.1.0 unmodified) several times, including multiple resets and long waits of the Arduino Nano after upload.

I'm running into the same issue.

Tflite Micro has been moved to a separate repository. The example which you are trying can be found here https://github.com/tensorflow/tflite-micro/tree/main/tensorflow/lite/micro/examples/magic_wand.
There has been few changes made to the example. Could you please try with the latest version and let us know the outcome. Thanks!


package.json error

Hi. I'm trying to build an binary that has var xray = require('x-ray'); in the node script.
It is giving me some errors so in trying to do what the README tells me to.
I'm on point Browserify Require Issues but is giving me some errors. This is what I did:
I tried to create a package.json and then I executed nexe on the command line. It shows me this error:

module.js:590
throw err;
^
SyntaxError: C:\Users\danny\dev\MeusProgramas\horoscopo\package.json: Unexpected token : in JSON at position 6
at Object.parse (native)
at Object.Module._extensions..json (module.js:587:27)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object.exports.package (C:\Users\danny\AppData\Roaming\npm\node_modules\nexe\lib\exe.js:962:16)
at Object. (C:\Users\danny\AppData\Roaming\npm\node_modules\nexe\bin\nexe:84:22)
at Module._compile (module.js:570:32)

This is my package.json:
"nexe": {
    "input": "horos.js",
    "output": "horos^$",
    "temp": "src",
    "browserify": {
        "requires": [],
        "excludes": [],
        "paths": []
    },
    "runtime": {
        "framework": "node",
        "version": "6.9.0",
        "js-flags": "--use_strict",
        "ignoreFlags": true
    }
}

What should I do?

By the error message it looks like you have a typo in your package.json

But I have copied the json from the README example as you can see

if that's the whole contents of your package.json you need to add braces around it. e.g.:
{
"nexe": {
...
}
}

Of course. I'm really a beginner :)
Obrigado @anmonteiro

It can be made more explicit in the README for beginners like me to don't fall under this issue

Now I'm trying add x-ray module, and I'm trying to do what is in  Browserify Require Issues.
Should my package.json be like this?
{
    "nexe": {
        "input": "horos.js",
        "output": "horos^$",
        "temp": "src",
        "browserify": {
            "requires": [
                {
                    "file": "horos.js",
                    "expose": "x-ray"
                },
                "x-ray.js"
            ],
            "excludes": [],
            "paths": []
        },
        "runtime": {
            "framework": "node",
            "version": "latest",
            "js-flags": "--use_strict",
            "ignoreFlags": true
        }
    }
}


git push deployment with NodeJs/NPM project ignores files on sync

When doing a git push in order to deploy an application, Kudu doesn't sync some files in node_modules because their creation date is always 26th october 1985. The git push is made to the folder site/repository and the sync is made to site/wwwroot, but as the timestamp of some files in the Node dependencies doesn't change, they are not copied.
Repro steps.

git push to the folder site/repository
npm install --production inside site/repository. It installs the dependencies and some of the files have creation date: 26th october 1985.
Kudu copies the modified files from site/repository to site/wwwroot. As Kudu looks for the files that have different timestamp, it doesn't copy some of them even when they have different content.

The log/error given by the failure.
There aren't errors. Kudu just ignores the files on the sync between site/repository and site/wwwroot.
System and versions

Web Application using Windows.
Node 12.15.0
NPM 6.13.4

This issue is similar to this one, but doing a git push instead of a ZIP deployment.
Related npm issue.

Below is the current copying implementation.   Please file gissue to KuduSync.NET to allow CopyAlways option.  You will need to provide custom deployment as a workaround.
https://github.com/projectkudu/KuduSync.NET/blob/master/KuduSync.NET/KuduSync.cs#L193

Hi
If the problem persists and is related to running it on Azure App Service, please open a support incident in Azure:
https://learn.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request
This way we can better track and assist you on this case
Thanks,
Joaquin Vano
Azure App Service


[UI] [Container] launching new container has unclear error message: "Invalid: Undefined"

Trying to launch a new container (ubuntu:14.04) with command /bin/bash but no specified user (it says "e.g. root" in grey) fails with the unclear error message "Invalid: undefined".
It would be better to have an error like "you must specify a user".

What's happening is if you focus the user field then the value in the model changes from null to empty string, which causes the server to send back:
{
    "actions": {},
    "code": "MinLengthExceeded",
    "detail": null,
    "fieldName": "user",
    "id": "b8b40dc6-d1ef-4453-98f3-2a2564ebec59",
    "links": {},
    "message": null,
    "status": 422,
    "type": "error"
}

So the UI needs to make sure fields that are empty are null in the JSON, or the API needs to accept empty strings as not-defined.

The "Invalid: Undefined" message has been fixed, but the remaining question is whether or not a user must be defined in order to run a command. I've logged a new bug for the remaining question. https://github.com/rancherio/rancher/issues/270


word_wrap always put a new line char to the end of the string

word_wrap always put a new line char to the end of the string besides of the string is multibyte or not.
Tested with: CI 3.1.2 on Windows 8.1 PHP 5.6.17 and Debian 5.5.20

$ grep -ri 'function word_wrap' *
system/helpers/text_helper.php:	function word_wrap($str, $charlim = 76)
system/libraries/Email.php:	public function word_wrap($str, $charlim = NULL)

... which one?
Why does it matter if it's a multibyte string or not?
Why is it a problem if it adds a newline?

The one in the Text helper.
I didn't check the implementation sometimes multibyte causes problems with text related stuff so I mentioned it...
It is a problem because I parse the text further, line by line. I can solve a problem with a trim or with an array pop after I explode the string, but I think that new line char shouldn't be there in the first place.

So it's a problem for your current, isolated use case. Is that the only reason you think it shouldn't be in there?
If you do look at the implementation, you'd see that the newline there is very much intentional. Why should that be changed for everybody else? Do you have any technical arguments for that?

Yes, I created this issue, so it's my problem, you're right... and yes it's isolated beacuse it's the first time in the last 5 year or so when I need this specific function...
I don't have a "technical" reason, only some logical one...
Let's take a use case: you have word_wrap-ed string and then you want to print it out to a fixed size block... what do you do? nl2b (or something like that) but there is an extra new line after the text which isn't fit to the design...

We can't make changes based on somebody's particular design ...


Feature Request: Peer Approvals

I am trying out TEAM, and have found that I cannot raise a request for access if I am an approver for the account I am requesting access to - even though there are other possible approvers.
This means we can't have "peer approvals" - I can't set it up so I can approve a request for one of my colleagues, while they can also approve my access.
It makes sense that I can't approve my own requests, but I should be able to raise a request when I am in the group (or one of the groups) that can approve requests on that account, so someone else can approve it.

On further investigation, it appears as if this should be supported; but isn't because of a bug.
In teamListGroups, the handler will return the members of the first group with any members.
    members = []
    groupIds = event["arguments"]["groupIds"]
    for groupId in groupIds:
        if members:
            return {"members": members}
        members.extend(list_idc_group_membership(groupId))
    return {"members": members}

In my case, the first group returned one entry - me, and the second group would have returned a bunch more.
This code will, on the first time through the groupIds loop, add the members of the first group to the members list. On the second, it will detect that members is not empty, and return before getting the members of the second group. I think you just need to remove the if members: return { ... } bit?

@jarrod-mg  thanks for point this out. Let me know if you still face this issue after this update


Fix gRPC import issue while running only rest

Signed-off-by: Saad Khan<EMAIL_ADDRESS>This PR intends to fix issue #108 .

Modified the gRPC import line in the service.py file to be imported only when both services are running.
Tested the app by removing the gRPC libraries from the system and running both the services individually.

Removed gRPC modules and checked issue is not occurring now. PFB logs:
[saakhan@saakhan hpo]$ python3 -m pip uninstall -r req_test.txt
Found existing installation: grpcio 1.44.0
Uninstalling grpcio-1.44.0:
  Would remove:
    /home/saakhan/.local/lib/python3.8/site-packages/grpc/*
    /home/saakhan/.local/lib/python3.8/site-packages/grpcio-1.44.0.dist-info/*
Proceed (Y/n)? y
  Successfully uninstalled grpcio-1.44.0
Found existing installation: click 8.1.2
Uninstalling click-8.1.2:
  Would remove:
    /home/saakhan/.local/lib/python3.8/site-packages/click-8.1.2.dist-info/*
    /home/saakhan/.local/lib/python3.8/site-packages/click/*
Proceed (Y/n)? y
  Successfully uninstalled click-8.1.2
Found existing installation: protobuf 3.19.4
Uninstalling protobuf-3.19.4:
  Would remove:
    /home/saakhan/.local/lib/python3.8/site-packages/google/protobuf/*
    /home/saakhan/.local/lib/python3.8/site-packages/protobuf-3.19.4-py3.8-nspkg.pth
    /home/saakhan/.local/lib/python3.8/site-packages/protobuf-3.19.4.dist-info/*
Proceed (Y/n)? y
  Successfully uninstalled protobuf-3.19.4
[saakhan@saakhan hpo]$ ./deploy_hpo.sh -c native --rest

###   Installing HPO as a native App

### Installing dependencies..........

### Starting the service...

2022-10-03 14:22:10 - INFO - hpo-service - Starting HPO service
2022-10-03 14:22:10 - INFO - rest_service - Access REST Service at http://localhost:8085
^C2022-10-03 14:22:20 - INFO - hpo-service - Shutting down HPO service

[saakhan@saakhan hpo]$ ./deploy_hpo.sh -c native --both

###   Installing HPO as a native App

### Installing dependencies..........

### Starting the service...

2022-10-03 14:22:35 - INFO - hpo-service - Starting HPO service
2022-10-03 14:22:35 - INFO - rest_service - Access REST Service at http://localhost:8085
2022-10-03 14:22:35 - INFO - grpc_service - Starting gRPC server at http://<IP_ADDRESS>:50051

Test is failing ... looks like you need to check if there is a param first before checking the content
if len(sys.argv) == 1 and sys.argv[1] == "BOTH":


Include more information? (Specifically payout info)

I realize this is going to be a PITA now, but it'd be great to see more information per list - most specifically what payouts are for each entry.

Pull Requests are welcome. And mostly payouts are something which is decided based on the severity of the bug, though It'd be nice to show minimum payout info.


Change “Mark All” to icon + “All”

Maybe “✔ All”?

Bug Report Dump (Auto-generated)

Version 1.12.0 (1063)
Device: iPhone 7 Plus (iOS 11.0.3)
TestFlight: false

For the swipe cell? Why would we want to change it?

Nah the button in nav bar. “Mark All” just looks wordy now.
Sent with GitHawk

I think an emoji would be out of place as well, but we can try!

Haha ya I meant use an image icon, not the literal check emoji 😄
Sent with GitHawk


Refactored 'spo storageentity set' to use the getRequestDigest helper solving #80

Refactored 'spo storageentity set' to use the getRequestDigest helper solving #80

Coverage decreased (-0.0003%) to 99.888% when pulling df08c41efe262e66f38eb0be55a6267e9dd51d73 on waldekmastykarz:requestdigest-spo-storageentity-set into 5c1f8fb89f5ee65caff041fc5eda28f98e6b6c9c on SharePoint:dev.

Merged manually


(Log4net) Warn if 'Debug', 'Info', ... methods are invoked with exception only

The Debug, ... methods have an override that allows to provide a message and an exception.
So if such method gets invoked with an exception only, we should report an issue and give a hint to invoke the override instead.
Relevant:

Debug
Info
Warn
Error
Fatal

To consider:

Debug(ex)
Debug(ex.ToString())


feat[CL]: Implement SwapExactAmountIn

Closes: #3159
What is the purpose of the change
Adds SwapExactAmtIn as well as all logic/tests that depends on this
Implements CalcIn

Just going to refactor this to be all of SwapIn

@p0mvn decided to make it so that if priceLimit is not set (aka it is set to ZeroDec) then we use min or max value depending on swap direction. I felt like this makes things much simpler to deal with. If you are good with that change then this should be good to merge.

@p0mvn all comments addressed. While applySwap still is in SwapInAmtGivenIn/Out, I also moved it to updatePoolForSwap. We can remove it from SwapInAmtGivenIn/Out once we fully deprecate it's use


Story around hal re-exports

In arduino_mkrzero, I just copied the same structure of pub use etc that existed in the other board libraries.
However now I'm actually trying to use them in an application I'm running into difficulties. Theatsamd_hal and embedded_hal modules aren't actually exported, only their contents which behaves oddly. You can see in this search that the only OutputPin type exported by the board library is arduino_mkrzero::prelude::_embedded_hal_digital_OutputPin.
The problem goes away if the user includes embedded_hal directly in their own Cargo.toml but if that's the expected case then the re-exports are still useless.
Any suggestion? The simplest solution would be to drop all the re-exports and the user is expected to import the embedded_hal crate themselves in order to use the board crate. Or we could pub use atsamd21_hal as hal (i.e. NOT a glob import) and then users could access arduino_mkrzero::hal::digital::OutputPin.
In short the current solution doesn't really suit our (users') needs and we should think about a better one :)
Either that or I'm using the board library wrong in which case I suggest that the documentation be improved to make things clearer.

With my recent messing around with the 2018 edition, I think these glob imports confuse rust a bit and make it harder to reason about what is in which namespace, so I'm in favor of tidying things up.
I propose eliminating all glob exports, except in prelude modules that are re-exporting eg: embedded_hal::prelude::*.
I think the board crates should re-export atsamd_hal as hal. For clarity, I think atstamd_halshouldpub extern crate embedded_hal;rather thanpub extern crate embedded_hal as hal;(as it does currently), so that consumers can refer to the traits ashal::embedded_halrather than the harder to intuithal::hal` that we currently have.
I also propose that the configured hal export the pac crate as target_device to help minimize conditional feature checks downstream.  I think we could also export it with its native crate name for potentially more advanced uses, but I don't think it is strictly required.

Going back to first principles, what is the advantage to re-exporting at all? In all of my code I ended up importing the embedded_hal crate via cargo anyway, would this be able to eliminate that?


What can we do for JSON-RPC?

Apparently Ethereum nodes use JSON-RPC. Could we make these calls typesafe? Could we generate typesafe RPC client and server code?

@carnesen Any chance you could write up your approach in a blog post?

Oh, I was suggesting you publish it on your blog if you have one.  I guess these days Medium is the thing.  But we're happy to give you our feedback if you send us a draft, and tweet about it :-).  You can also come talk to us on Slack.


Multiple warnings in C temporal_interpolation function

As Issue #332 showed, there are many Warnings in the C temporal_interpolation function, mostly to do with casting of argument types, e.g.:
warning: passing argument 9 of ‘temporal_interpolation’ makes pointer from integer without a cast [enabled by default]
E                    err = temporal_interpolation(particle->lon, particle->lat, particle->depth, time, Kh_zonal, particle->cxi, particle->cyi, particle->czi, particle->cti, &tmp1, LINEAR);

While not problematic per se, they make it more difficult to track down real errors in kernels, so better to fix these warnings

Fixed in #337


[OpenShift] markdown execute snippet rendering

Making note of this quick starts related issue from here so we can keep an eye on it
https://github.com/openshift/console/issues/9723

Openshift fixed this here: https://github.com/openshift/console/pull/11572
I have a PR out for a similar issue with copy snippet: https://github.com/patternfly/patternfly-quickstarts/pull/186


Documentation for "policy and telemetry features" outdated?

Bug Description
The Istio docs for Concepts -> Traffic Management -> Sidecars has the following paragraph:
https://istio.io/latest/docs/concepts/traffic-management/#sidecars
"You can specify that you want a sidecar configuration to apply to all workloads in a particular namespace, or choose specific workloads using a workloadSelector. For example, the following sidecar configuration configures all services in the bookinfo namespace to only reach services running in the same namespace and the Istio control plane (currently needed to use Istio’s policy and telemetry features):"
apiVersion: networking.istio.io/v1alpha3
kind: Sidecar
metadata:
  name: default
  namespace: bookinfo
spec:
  egress:
  - hosts:
    - "./*"
    - "istio-system/*"

Do we still need to include the Istio control plane namespace (e.g. istio-system/*) for Istio's policy and telemetry features?
If I understand correctly, Mixer was used to provide policy and telemetry, but that is deprecated and was moved into the envoy proxy.
From old istio v1.6, Sidecar reference https://istio.io/v1.6/docs/reference/config/networking/sidecar/:
"For example, add host istio-system/istio-telemetry.istio-system.svc.cluster.local if telemetry is enabled, istio-system/istio-policy.istio-system.svc.cluster.local if policy is enabled, or add istio-system/* to allow all services in the istio-system namespace. This requirement is temporary and will be removed in a future Istio release."
But in latest docs Sidecar reference, there is no longer mention of need to include istio-system for policy and telemetry.
So I'm wondering if it's still required. If not, then https://istio.io/latest/docs/concepts/traffic-management/#sidecars should be updated.
Version
istio.io/latest/docs

Additional Information
No response

It should no longer be required. And we should update the docs.

It should no longer be required. And we should update the docs.

By default, envoy report trace to zipkin.istio-system, we should remind end-users in this scenario.

i think that cluster is part of bootstrap  though. However, any extension
providers will need to be taken into account. Maybe we should do that
automatically though...
On Wed, Dec 8, 2021, 7:25 PM zirain @.***> wrote:

It should no longer be required. And we should update the docs.
By default, envoy report trace to zipkin.istio-system, we should remind
end-users in this scenario.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/36435#issuecomment-989474157, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXNB64YHP2KGKFEHFDDUQAOT3ANCNFSM5JUHQNRA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

that would be a trick like mesh Gateway in VirtualService, and seems non-const.

I'm confused.
My original question was:

Do we still need to include the Istio control plane namespace (e.g. istio-system/*) for Istio's policy and telemetry features?

To which @howardjohn replied:

It should no longer be required. And we should update the docs.

But the docs update was
https://github.com/istio/istio.io/pull/10587/files#diff-e4e9e2ab753066efb664791ebc4e5014ba9fea0d88f0fbfd324a3f78cb5a3a02R599

to only reach services running in the same namespace and the Istio control plane (needed by Istio’s egress and telemetry features):

I would have thought that the istio control plane was not needed at all?