feat(API): add ForceFlush and Shutdown to API

Signed-off-by: secustor<EMAIL_ADDRESS>Supersedes https://github.com/open-telemetry/opentelemetry-js-api/pull/172

Which problem is this PR solving?
This PR exposes the shutdown and forcedFlush functions defined by the TraceProvider specs.
Providing these methods allows to gracefully shutdown instrumentations without data loss. Currently this is only possible with usage of SDK specific implementations see
Fixes # (issue)
Short description of the changes
Adds ForceFlush and Shutdown methods to the TraceProvider interface.
Both are optional to be backwards compatible.
Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A

Checklist:

[ ] Followed the style guidelines of this project
[ ] Unit tests have been added
[x] Documentation has been updated

Worth noting that this is not in the specification. There have been efforts in the past to have it added that haven't gone anywhere.
Personally I think this is a great feature for something like lambda so you can shut down without reference to the SDK

I'm not sure where the documentation should be added. Can somebody point me in the right direction?

The tsdocs you added are a good place to start. I wouldn't add the website docs until this PR is accepted and merged

I don't see the added methods in src/api/trace.ts. How are they expected to be called?
The user would use getTraceProvider to retrieve the provider then use shutdown or forceFlush.

It would also be great to see the implementations added to the SDK in the same PR so the implementation can be validated with the API. This is the main reason the API was moved back to the main repo.
👍

It would also be great to see the implementations added to the SDK in the same PR so the implementation can be validated with the API. This is the main reason the API was moved back to the main repo.

The BasicTracerProvider already implements both methods, so no changes are needed in the SDK from my point of view.

@legendecas i see the label but is there a spec issue? Can we add it to the description?

I found a closed discussion on this: https://github.com/open-telemetry/opentelemetry-specification/issues/1287.

@legendecas @dyladan As this discussion is closed, what would be next steps be?
Create a new discussion or issue and bring forth this use case?

I think the next step for us to proceed with API change here is that (re-)open an issue/PR at the specification repo and define the API change in the spec first. Generally speaking, we can not land API feature changes (that are not specific to JavaScript/TypeScript) without spec normative change first.


Ignoring traffic lights or having them green all the time.

Is there a way either to have the auto-pilot client ignore the traffic lights or have the traffic lights be green all the time? Thanks in advance!

@Seth-Park, what is the purpose you are exactly looking this for?
In a way having the traffic lights green all the time is equivalent to having no traffic lights at all. So, why not just do that and remove all the traffic lights from the map in the UE4 Editor?

It's already  possible to control traffic lights from Python API.


llvm_{38,39}: unconditionally set triples, not just w/musl

Follow-on to same changes made to other versions:
See #42454, #42456.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

Maybe start here since (I think?) these are lowest impact? I think Darwin builder might be able to give us feedback now... let's see! :)

@GrahamcOfBorg build tests.cc-wrapper-libcxx-39 tests.cc-wrapper-clang-39

Success on aarch64-linux (full log)
Attempted: tests.cc-wrapper-libcxx-39, tests.cc-wrapper-clang-39
Partial log (click to expand)
Selected multilib: .;@m64
checking whether compiler builds valid C binaries... ok
checking whether compiler builds valid C++ binaries... ok
checking whether compiler uses NIX_CFLAGS_COMPILE... ok
checking whether compiler builds valid C++ binaries... ok
checking whether compiler uses NIX_LDFLAGS... ok
checking whether compiler uses NIX_CFLAGS_COMPILE... ok
checking whether compiler uses NIX_LDFLAGS... ok
/nix/store/m58wwvfkcz2iapfdm1764mcj6ad0nap5-cc-wrapper-test
/nix/store/qcahmamwkzidc98vj73ibys42w8p4w8b-cc-wrapper-test

Failure on x86_64-darwin (full log)
Attempted: tests.cc-wrapper-libcxx-39, tests.cc-wrapper-clang-39
Partial log (click to expand)
[ 24%] Building CXX object lib/MC/CMakeFiles/LLVMMC.dir/MCSchedule.cpp.o
[ 24%] Building CXX object lib/MC/CMakeFiles/LLVMMC.dir/MCSection.cpp.o
[ 24%] Building CXX object lib/MC/CMakeFiles/LLVMMC.dir/MCSectionCOFF.cpp.o
[ 24%] Building CXX object lib/MC/CMakeFiles/LLVMMC.dir/MCSectionELF.cpp.o
building of '/nix/store/qmsa2jjfh06cbgzv4yfy3zdy012q3xgq-llvm-3.9.1.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/68widzyibfv7c9fg92x84pw1mfp6wyrs-clang-3.9.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/jd312hjd66zfzbzfbbd1kwgicckmsz4z-clang-wrapper-3.9.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/bdr5f8nydz92skgmqf6y4zdyqjsz7x79-stdenv-darwin.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/f7ll2xdmbqc52c8cfk4xcbsfrcna3r3x-cc-wrapper-test.drv': 1 dependencies couldn't be built
error: build of '/nix/store/f7ll2xdmbqc52c8cfk4xcbsfrcna3r3x-cc-wrapper-test.drv' failed

Well didn't have fork failure, but timed out d'oh haha.

Success on x86_64-linux (full log)
Attempted: tests.cc-wrapper-libcxx-39, tests.cc-wrapper-clang-39
Partial log (click to expand)
Found candidate GCC installation: /nix/store/imfm3gk3qchmyv7684pjpm8irvkdrrkk-gcc-7.3.0/lib64/gcc/x86_64-unknown-linux-gnu/7.3.0
Selected GCC installation: /nix/store/imfm3gk3qchmyv7684pjpm8irvkdrrkk-gcc-7.3.0/lib64/gcc/x86_64-unknown-linux-gnu/7.3.0
Candidate multilib: .;@m64
Selected multilib: .;@m64
checking whether compiler builds valid C binaries... ok
checking whether compiler builds valid C++ binaries... ok
checking whether compiler uses NIX_CFLAGS_COMPILE... ok
checking whether compiler uses NIX_LDFLAGS... ok
/nix/store/gjw0rkb1d9k8dradlcz0svpkq0m7v7vl-cc-wrapper-test
/nix/store/1m65mm7n3l8iw00gckq808asxx9vpmlv-cc-wrapper-test

This (and same changes to other versions) was requested to be made more general than musl,
will be merging this first since these (I think) have the smallest "impact".


Add request.auth.claims and source.principal, update source.user and request.auth.principal

Add request.auth.claims and source.principal
Update source.user and request.auth.principal

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
Assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/cc @diemtvu

/cc @qiwzhang

https://github.com/istio/istio/issues/4689
https://github.com/istio/istio/issues/5040

/lgtm
/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: qiwzhang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
Assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/cc @linsun

@linsun, the PR needs your approval before it can be merged. Can you please review it? Thanks!

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: linsun, qiwzhang
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [linsun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


add the *.VC.db to unreal engine ignore

Reasons for making this change:
as of visual studio 2015 update 2 this file stores the intellisense database.
this file is generated by visual studio and shouldn't be included in a repository, particularly because for an unreal project this file seems to start at around 300MB.
*.VC.db has already been added to the standard visual studio ignore here

@calben thanks!

Note this was a duplicate entry. c.f. https://github.com/github/gitignore/pull/2741

Oh jeez, I'm just now seeing this comment that it was a duplicate entry.
No idea how that happened- sorry!


Update Validator Registration contract and associated Unit Tests

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Can I get clarification on the necessity of these additional helper functions? Don't fully understand the benefits of modifying the initial implementation

@ansermino Which ones?

I see what you're saying. When I first checked out their contract, the commit that updated it to spec wasn't pushed yet so it was still outdated. Seeing that their implementation of the contract at the time was a bit more up to date than that of this repository, I'd decided to update their existing code independently.
I just checkout out the file again today and it's up to spec. The differences mostly arise from independent development and the similarities of course come from adhering to specification. @ansermino

Are any further changes needed?

Apologies for the delay, and thank you for your patience on this PR. I promise this sluggishness is only due to the time of year.
I double checked the gas costs in comparison to the other implementation and we are looking good. My only concern is that the data being logged does not match that of the vyper spec contract nor the prysmatic implementation.
For this implementation I get:
Eth1Deposit(previousReceiptRoot: null, data: 0xce6211443eee5b3dc4bff91a3c11038fffcf72b8cdfab76e8545cd9e782025a6, totalDepositcount: 0)

The spec and prysmatics give me:
Eth1Deposit(previous_receipt_root: 0x0000000000000000000000000000000000000000000000000000000000000000, data: 0x0000000773594000000000005c29be30ce6211443eee5b3dc4bff91a3c11038fffcf72b8cdfab76e8545cd9e782025a6, deposit_count: 0)

(Note: I have fixed the timestamp to 1000 to produce comparable results).
I haven't had the chance to dive into this too deeply but should do so in the next 24hrs. Please let me know your thoughts

@ansermino Yikes I didn't know there was a way to cross-examine spec behavior like that. Could you let me know how you executed the spec contract so that I can debug?

@aunyks I loosely followed this guide. You can save the spec under contracts/validator_registration.v.py and then replace artifacts.require('ValidatorRegistration'); with artifacts.require('validator_registration.vyper'); after running truper. Don't forget to fix the timestamp. I also had issues catching the events, tbh forcing the tests to fail was the most painless solution for me. You could also just swap in the prysmatic implementation for a more familiar landscape.
Having tested toBytes and mergeBytes in isolation I don't see any obvious causes.

I think this may have been a false alarm, after resetting my environment I am getting consistent result. Please let me know if you can confirm this @aunyks

@ansermino Yea when setting the timestamp to 1000 I'm getting the same values as those you said were given by the spec.


hrt_base_ochuman_256x192.pth is not a checkpoint file

OSError: models/base/hrformer/hrt_base_ochuman_256x192.pth is not a checkpoint file
when running:
python tools/train.py --cfg experiments/OCHuman/interformer_ochuman_hrt_192_p3_b8.yaml

Nearly identical error:
OSError: models/base/hrformer/hrt_base_coco_384x288.pth is not a checkpoint file
When running: torchrun --nproc_per_node=1 tools/ddp_train.py --cfg experiments/coco/interformer_coco_hrt_288_p2_b4.yaml
Did you manage to solve it?

Please git pull the lateset version, and download the models from here.


Unclear risk report tile

Avoid duplicates

[x] Bug is not mentioned in the FAQ
[x] Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[x] Bug is not already reported in another issue

Technical details

Device name: OnePlus 8T
Android version: 11 (Lineage OS 18.1-20211205-microG-kebab)
App version: 2.14.1

Describe the bug
A red risk warning should disappear 14 days after exposure. However, in the current version the risk tile remains red and still shows the date of exposure on day 15 after exposure. The number count of risky exposures disappears though. On day 16 after exposure the tile goes back to green (if there haven't been any other exposures).
Example screenshot: Exposure Dec 4th 2021. Time of screenshot: Dec 19th 2021. On Dec 18th, the first line in the risk tile still showed "1 exposure with high risk". Since Dec 19th, the first line is empty:

Steps to reproduce the issue
Have a red risk warning and wait until day 15 after exposure.
Expected behaviour
The risk tile either turns green on day 15 or remains red and keeps the number of risky exposures. The current behavior is confusing for users since you don't know for sure whether there still is a risk or not. The color suggests there is, but the text suggests there isn't. This should be unequivocal
Possible Fix
No idea :)
Additional context

Hi @deesnook 👋
This seems to be a duplicate of #4407, or?
Please check and close this issue if you also think it's a duplicate (-:
Thank you & have a nice Sunday!

You're absolutely right, it is a duplicate. I somehow overlooked the other issue. Sorry!


Fix failing test when stopwatch frequency isn't exactly 10^7

@karolz-ms reported a failure in the OperationTelemetryCanRecordPreciseDurations test on a physical machine where stopwatch ticks did not match timespan ticks. In that case, we need to allow for some epsilon in the test.
I also modified the implementation to use Math.Round when converting to TimeSpan ticks which gives a further, slight accuracy improvement in those cases.

Hi @pharring, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Paul Harrington). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Tested the fix on my hardware--works!


Fix ss3migrate

SS3 Asset Migration Task:

Make destination directories when required.
Allow absolute path for src assets dir.
Improved logging (list any dirs that failed to write to at the end, log individual success/failure, etc).
Improve comments.
Improve migration task to work without CDN modules.

@JoshuaCarter seems like there's some further changes that can be pulled back here? Just wanted to highlight it so we didn't forget :)

No contest from me @JoshuaCarter, I think that's a solid approach. Happy for this to be merged.

@nglasl done :)


Make new release

As compiling requires a developer certificate, I think you should make a release. There is thumbnail support now, so not releasing means people cannot use the new feature.

Let's see what comes first. The 2-year awaited release of JXLook 0.1.5. Or the JPEG XL support in macOS Sonoma pre-announced today:
macOS 14 will support JPEG XL

This is too late, chrome and firefox already dropped jpeg XL support, so its not going anywhere. Also we could always compile from source with a $99 apple developer license

An Apple developer license is not required to build JXLook. More on that below…
Firefox
As I am a Firefox user, this caught my attention:

firefox already dropped jpeg XL support

The Internet is confused about this due to people testing JPEG XL images with the released version of Firefox. From Experimental features in Firefox:

Note that, as shown below, the feature is only available on Nightly builds (irrespective of whether the preference is set).

The preference referred to is image.jxl.enabled which is set to false by default, including in Nightly builds. I suspect that note was added due to people setting that preference to true in other builds of Firefox and concluding JPEG XL support is broken or dropped.
The Firefox bug tracking this is Implement support for JPEG XL (image/jxl), which is still open. Recently the keyword parity-safari was added.
Another consideration is web standards. Back in January, Mozilla concluded that we are neutral on JPEG-XL.
To be certain I was not providing incorrect information I downloaded the latest Firefox Nightly build, set the above preference to true and opened a JPEG XL image. Screenshot attached at the bottom of this comment.
My own conclusion is that Firefox has not dropped support and is watching on the sidelines, waiting to see which new image format gets adopted.
Chrome
Indeed Chrome has pulled support for JPEG XL over lots of objections.
On August 7th Phoronix posted Google May Reconsider JPEG-XL Image Support Within Chrome.
I would think it would take a lot for Chrome to reverse course.
macOS
Of course the recent interesting news is this from the Safari Technology Preview 173 Release Notes:

JPEG XL support on macOS Sonoma adds a new image format with an improved compression algorithm for better image quality at smaller file sizes than JPEG, but with the same progressive loading capability.

JXLook
I'm not running the macOS Sonoma Beta, but from what I've read it is looking like the need for JXLook will be going away due to the native support in macOS. Nonetheless there are people in the world who are trapped running older versions of macOS. If use of JPEG XL picks up they would benefit from JXLook.
The open JXLook pull request #27 contains various enhancements such as updating libjxl to v0.82.0 and support for HDR including enabling EDR. See that PR for details.
I too ran into the problem with the Xcode build failing due to certificate signing. This is still true with the above PR as I preserved the existing Xcode project settings.
To get the build to work change the Signing Certificate Xcode setting from Development to Sign to Run Locally in all three projects as shown here:

This is how I pulled the PR for that test:

Cloning and checking out PR:
low-batt@gag jxlook-signing$ git clone git@github.com:yllan/JXLook.git
Cloning into 'JXLook'...
remote: Enumerating objects: 808, done.
remote: Counting objects: 100% (44/44), done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 808 (delta 40), reused 40 (delta 40), pack-reused 764
Receiving objects: 100% (808/808), 13.11 MiB | 10.47 MiB/s, done.
Resolving deltas: 100% (413/413), done.
low-batt@gag jxlook-signing$ cd JXLook/
low-batt@gag JXLook (main=)$ gh pr checkout 27
remote: Enumerating objects: 58, done.
remote: Counting objects: 100% (24/24), done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 58 (delta 21), reused 21 (delta 21), pack-reused 34
Unpacking objects: 100% (58/58), 3.39 MiB | 3.04 MiB/s, done.
From github.com:yllan/JXLook
 * [new ref]         refs/pull/27/head -> hdr
Switched to branch 'hdr'
low-batt@gag JXLook (hdr)$

The latest Firefox Nightly build displaying a JPEG XL screenshot I made from Big Buck Bunny:


Server is starting

Is there an existing issue for this?

[X] I have searched the existing issues

Used image version
(latest) 679be21256f4d4599d1172abd638e320601fa9485991486db9f5fb9a54f9e787
Used docker compose file or docker command
Here is my docker file
version: "3"
services:
  enshrouded:
    image: mornedhels/enshrouded-server:latest
    container_name: test_server
    hostname: test_server
    restart: unless-stopped
    stop_grace_period: 90s
    ports:
      - 15636:15636/udp
      - 15637:15637/udp
    volumes:
       - ./save_data:/opt/enshrouded
    environment:
       - SERVER_NAME=Test Server
       - SERVER_PASSWORD=Atestpassword
       - UPDATE_CRON=*/30 * * * *
       - PUID=4711
       - PGID=4711

And then I am just starting it with a simple docker compose up -d
What you expected to see, versus what you actually saw
The server starts correctly and I can join the server, but I copied the saved data over from my computer to the server because I was hosting it for a few days, but whenever I join the server is reset back to no progress, like it is a brand new server.
Looking through save_data/server/logs/enshrouded_server.log I see some relevant errors, so I have included them below.

When a client connects to the server there is a bunch of messages about successfully connecting and then a single line that looks like an error, [session] Unable to find machine for peer 0
After the [ecss] Send BuildingZones message there is about a dozen messages saying [ecss] Could not add component %hash% for entity 1367 and then about a dozen messages saying [ecss] Could not remove component %hash% for entity 1367
[savexxx] SAVE 0 bases 0 entities size 1,719

As I said, the container itself seems to be working fine I am just unable to load my existing save data.
Logs from the container
This is the same as what I was seeing in the log file except it also had information about updating the server which all succeded. I can get a copy of it but it would be kind of annoying so I was hoping you wouldn't actually need it haha

Hey @LvInSaNevL, hm that could be a permission issue.
What are the logs after the savexxx one? Something like that?
[server] Save Serialization took 45.08 ms over 4 Ticks
[server] Saved
[savedata]
Compression of Blob 0x00000539::SRSG took 150.00 us

If it's a permission issue, try chown -R 4711:4711 ./save_data

Yeah thats right, but I did set permissions (I believe), here is the output from ls -l save_data/
-rw-r--r--   1 4711 4711
9 Feb 11 22:12 current_version
-drwxr-xr-x 8 4711 4711 4096 Feb 11 22:12 server

I also got a copy of docker compose logs here for you

hm, try to stop the server, copy your save file chown it again and start the server.
If that doesn't work, try an ID from a local user.

Yeah me either, but when I grabbed the file permissions this morning the server was shut down. When I get home this afternoon I'll change it back to my working user and try again.

Okay I still cannot get this to actually work. I even went and completely remade the entire project
I am noticing at the very beginning of the logs I am seeing errors that look like this
INFO reaped unknown pid 49 (exit status 0)
INFO reaped unknown pid 53 (exit status 0)
INFO reaped unknown pid 70 (exit status 0)
INFO reaped unknown pid 68 (exit status 0)
INFO reaped unknown pid 72 (exit status 0)

Could it maybe be an issue with your container?

These you can ignore. It just tells, that there were child processes which finished. steamcmd and wine are starting many child processes. So all fine there.
So what are your exact steps to setup the server?
Here is what I would do:

stop and remove old one

docker compose down
delete save_data

start container and wait for all files to be available (enshrouded needs to run at least 5 minutes)
check files

save_data/server/savegame/3ad85aea
save_data/server/savegame/3ad85aea.backup

stop container
overwrite 3ad85aea & 3ad85aea.backup (if you don't have the .backup, delete it)
change permissions on those savefiles to your used PUID PGID (if not specified 4711)
start container and wait for enshrouded to start

Hmm okay, I didn't think about replacing just the actual save game file, I was replacing the entire server directory. I'll give that a shot too

Hey @LvInSaNevL, did you fix your problem?

I closed the issue, due to inactivity. If you still have problems, feel free to reopen the issue.

Hey sorry to re-open this issue but I am having the issue again. We had to restart the server this weekend and I have not been able to get the server to come back up with our data. The server loads and we can log in but it is just a new world.
I have attached a copy of the most recent logs. In this case, I started a new server from scratch and copied over the save file into the file structure. But I have also tried using our old server, and copying over the whole save_data folder, but I was getting the same result.
enshrouded.log

Hey, do you have a clean backup of your savefile? Enshrouded changed the savefile strategy. To be sure:

stop the server
clear the whole savegame folder (make a copy if you need it)
add your world from the backup (3ad85aea file) to the savegame folder
check the permission (PUID & PGID)
start the server
after start, the enshrouded should add a 3ad85aea-index file and rotating savefiles (0-9)

Hey I tried a few times to get this to work, its still just starting a new world every time.
I do see this in the logs though, which shows it not loading any data
2024-04-24 17:57:38.036 supervisord: enshrouded-server VoxelSaveSize: 0
2024-04-24 17:57:38.070 supervisord: enshrouded-server [ecss] writeEntitySerializationContext:
2024-04-24 17:57:38.071 supervisord: enshrouded-server [ecss]   Templates: 1 (97 bytes) Components: 4 (1,344 bytes)  Size: 1,441
2024-04-24 17:57:38.071 supervisord: enshrouded-server [ecss]   Entities: 1 (0 children)
2024-04-24 17:57:38.083 supervisord: enshrouded-server [savexxx] SAVE 0 bases 0 entities size 1,754
2024-04-24 17:57:38.083 supervisord: enshrouded-server [server] Save Serialization took 49.27 ms over 4 Ticks
2024-04-24 17:57:38.083 supervisord: enshrouded-server [server] Saved

I am also able to join and once youre connected it works fine. I just cannot get it to load data from a save


Update credit_card_validations

The currently specified version of credit_card_validations is not compatible with ActiveModel >= 5.0, so I updated to the most recent version, which is.
In order to do this, I had to remove the Laser card test, because Laser cards are no longer supported by credit_card_validations since they have been withdrawn from the market.

Hey thanks for this PR!
It seems like this commit will deserve a major version bump then. I planned to do a full-review of the validators and never done it... is it the only validator that broke? Thanks again!

In any case, I'm merging this so people can use the GH repo as long as I haven't released anything...

Well, all the other tests passed.

thx @franckverrot :)


Bows don't show perks

Basically just the title. Using Edge 105.0.1343.42 (also in Chrome 105.0.5195.127).

Great, thanks!


No OpenID Server Found

I have setup everything correctly but when i press the login button on steam it gives me this error:

"No OpenID Server found at http://steamcommunity.com/openid/id/76561198131586617" (Feel free to add me!)

Everything is sent correctly by steam even tho your link is messed up. Normally its just http://steamcommunity.com/openid/.
Make sure you dont have that domain overriden or blocked by your hosting provider.

Same here :/

Could you try a fresh install of v3.0 and tell me if the issue persists?
Thanks!

Sorry for not replying but i have been busy.
And i have found the problem being the host i had :D


update kubecon ad

Build failed because of:
No cached entry, and can not fetch: openstreetmap Error: ESOCKETTIMEDOUT
No cached entry, and can not fetch: mapbox Error: ESOCKETTIMEDOUT
No cached entry, and can not fetch: mapserver Error: ESOCKETTIMEDOUT
No cached entry, and can not fetch: geoserver Error: ESOCKETTIMEDOUT
No cached entry, and HERE Global B.V. has issues with logo: here.svg, Failed to launch the browser process!
Inconsistency detected by ld.so: dl-tls.c: 493: _dl_allocate_tls_init: Assertion `listp->slotinfo[cnt].gen <= GL(dl_tls_generation)' failed!

TROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/master/docs/troubleshooting.md


Add CPU load tracking

When none of RAPL or PowerGadget is available, the mode will use CPU load to estimate the CPU Power.
TODO:

[ ]  Add test
[x] Check that it works when in RAPL mode and file is read protected we switch to this mode.
[ ] Fix test error "AttributeError: 'OfflineEmissionsTracker' object has no attribute '_country_name'" in Github Action
[ ] Add support for process mode (See https://stackoverflow.com/questions/41206809/psutil-measuring-the-cpu-usage-of-a-specific-process )
Tests to do:

[ ] Test on a VM
[ ] Test under container LXC
[ ] Test under Docker
[ ] Test under Windows
[x] Test under Linux with RAPL
[ ] Test under Linux without RAPL

Will close https://github.com/mlco2/codecarbon/issues/333

Here is how to test:
git switch use-cpu-load
codecarbon monitor

If you have RAPL, the log will display a comparison between RAPL and the new estimation based on CPU load:
------------------------
[codecarbon INFO @ 19:09:11] Energy consumed for RAM : 0.000312 kWh. RAM Power : 11.692474365234375 W
[codecarbon DEBUG @ 19:09:11] Done measure for RAM - measurement time: 0.0005 s - last call 6.13 s
[codecarbon INFO @ 19:09:11] Energy consumed for all GPUs : 0.000959 kWh. Total GPU Power : 19.64000343421216 W
[codecarbon DEBUG @ 19:09:11] Done measure for GPU - measurement time: 0.0031 s - last call 6.13 s
[codecarbon DEBUG @ 19:09:11] RAPLFile(name='Processor Energy Delta_0(kWh)', path='/sys/class/powercap/intel-rapl/intel-rapl:1/energy_uj', max_path='/sys/class/powercap/intel-rapl/intel-rapl:1/max_energy_range_uj', energy_delta=Energy(kWh=0.00012791769844518533), power=Power(kW=0.0750830161810631), last_energy=Energy(kWh=0.015906780571247607), max_energy_reading=Energy(kWh=0.018203517614746884))
[codecarbon DEBUG @ 19:09:11] RAPLFile(name='Processor Energy Delta_1(kWh)', path='/sys/class/powercap/intel-rapl/intel-rapl:0/energy_uj', max_path='/sys/class/powercap/intel-rapl/intel-rapl:0/max_energy_range_uj', energy_delta=Energy(kWh=0.00012790536065753963), power=Power(kW=0.07507577435041182), last_energy=Energy(kWh=0.015906798529039753), max_energy_reading=Energy(kWh=0.018203517614746884))
[codecarbon DEBUG @ 19:09:11] get_cpu_details {'Processor Energy Delta_0(kWh)': 0.00012791769844518533, 'Processor Power Delta_0(kWh)': 75.0830161810631, 'Processor Energy Delta_1(kWh)': 0.00012790536065753963, 'Processor Power Delta_1(kWh)': 75.07577435041182}
[codecarbon DEBUG @ 19:09:11] get_static_cpu_details {'Processor Energy Delta_0(kWh)': 0.00012791769844518533, 'Processor Power Delta_0(kWh)': 75.0830161810631, 'Processor Energy Delta_1(kWh)': 0.00012790536065753963, 'Processor Power Delta_1(kWh)': 75.07577435041182}
[codecarbon DEBUG @ 19:09:11] _get_power_from_cpus - DONT MATCH Processor Energy Delta_0(kWh) : 0.00012791769844518533
[codecarbon DEBUG @ 19:09:11] _get_power_from_cpus - MATCH Processor Power Delta_0(kWh) : 75.0830161810631
[codecarbon DEBUG @ 19:09:11] _get_power_from_cpus - DONT MATCH Processor Energy Delta_1(kWh) : 0.00012790536065753963
[codecarbon DEBUG @ 19:09:11] _get_power_from_cpus - MATCH Processor Power Delta_1(kWh) : 75.07577435041182
[codecarbon INFO @ 19:09:11] Delta energy consumed for CPU with intel_rapl : 0.000256 kWh, power :<PHONE_NUMBER>3147492 W
[codecarbon INFO @ 19:09:11] Energy consumed for All CPU : 0.004449 kWh
[codecarbon DEBUG @ 19:09:11] Done measure for CPU - measurement time: 0.0010 s - last call 6.13 s
[codecarbon DEBUG @ 19:09:11] CPU load 180 W x 4.2% = 18.0 for whole machine.
[codecarbon INFO @ 19:09:11] Delta energy consumed for CPU with cpu_load : 0.000031 kWh, power : 18.000000000000004 W
[codecarbon INFO @ 19:09:11] Energy consumed for All CPU : 0.004480 kWh
[codecarbon DEBUG @ 19:09:11] Done measure for CPU - measurement time: 0.0019 s - last call 6.13 s
[codecarbon INFO @ 19:09:11] 0.005751 kWh of electricity used since the beginning.
[codecarbon DEBUG @ 19:09:11] last_duration=6.129475831985474
------------------------

Is the  "Test under Linux with RAPL" done?

Is the "Test under Linux with RAPL" done? @benoit-cty

Yes, it's the only one that works for sure.


[do not review, testing] CI Chunks

Issue #

Description of changes

New/existing dependencies impact assessment, if applicable

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Closing, no longer needed


Hardcoded locale in config.php doesn't show up on Options page

Install a new instance of Habari with a hardcoded $locale = 'de' in config.php. The installer will show translated German strings, and so will Habari after a successful install. The Options page (Einstellungen), however, shows 'en-us' for locale (Gebietsschema), not 'de' as it should.
As long as the config $locale line is not commented/removed, changing the locale via the Options page does not affect anything.

It also doesn't affect the dropdown atop the installer. 'en-us' is selected initially regardless of the hardcoded one.

Related: #251


Test custom events

The new events which the plugin emits are not tested anywhere. It would be wise to add some tests which just ensure that the events are bound properly and get fired when the code is executed.
Otherwise there is no way to guarantee that the events exist for when people want to use them to customise aspects of the plugin.

Hey David,
We talked at the freenode chat of CakePHP about this issue. I got something like this:
$eventManager->expects($this->at(0))->method('dispatch')
            ->with($this->logicalAnd(
                    $this->isInstanceOf('Cake\Event\Event'),
                    $this->attributeEqualTo('_name', 'Component.Manager.beforeFilter')
            ))
            ->will($this->returnValue($this->getMock('Cake\Event\Event', null, [], '', false)));

This seems to work pretty well...

Ah yes. Much better than my attempt this afternoon.

That's what I thought ;) Well, I think there are many ways to do this... It depends on what you're testing... A flow, or a single event. When you want to test a single event you might like this:
        $eventManager->expects($this->once())->method('dispatch')
            ->with($this->logicalAnd(
                    $this->isInstanceOf('Cake\Event\Event'), $this->attributeEqualTo('_name', 'Component.Manager.startup')
            ))
            ->will($this->returnValue($this->getMock('Cake\Event\Event', null, [], '', false)));

@davidyell What about this? https://github.com/cakemanager/cakephp-cakemanager/blob/develop/tests/TestCase/Controller/Component/ManagerComponentTest.php


Fix 404 error for Google Objective-C Style Guide

guide's code has been switched to github.

Thanks!


Closes #907 - Rewrite the README.release.md to a template for a task list #907

What changed
Converted the Lists to Checkboxes/Task List
Closes #970
Before

After

Coverage remained the same at ?% when pulling fc78f1f9b69558a52d4cd11610d910662a9dcb36 on pavitra14:Issue907 into eed3a2a13f5b4b6a9adc0055d772862ab0152025 on nmstate:master.

Thank you, this looks nice. A nice bonus would be to look into https://help.github.com/en/github/building-a-strong-community/configuring-issue-templates-for-your-repository and make it an actual template that could be selected when creating new issues. You will have to test this on your fork and then use the generated files to create the PR for this repo. The README.release.md should then only contain some reference to using the tamplate to create a new issue and a reference where to find the template.

@tyll Just confirming if I understood correctly,
So I will need to create a new PR with the template and Add more commits to this PR for this readme to contain just references to the new template.

@tyll Just confirming if I understood correctly,
So I will need to create a new PR with the template and Add more commits to this PR for this readme to contain just references to the new template.

@pavitra14 you would need to

go to your nmstate for at https://github.com/pavitra14/nmstate
follow the instructions at https://help.github.com/en/github/building-a-strong-community/configuring-issue-templates-for-your-repository to setup an issue template using the new README that you added in this PR
Get the template from your fork and change this PR to store the template at the right place
Update the README to mention the issue template

We are trying this document format in #916. I will give feedback :-)

The section at https://github.com/nmstate/nmstate/pull/912/files#diff-a239ee76e414afea86b41ea5d9a8b8efR3 about creating Jira tickets for missing steps can be removed now, since the task list is used to track progress.
Also it seems a checkbox for creating the changelog is missing.

When you are done, please squash the commits together (check the git doc if you need help) and adjust the commit message to follow https://github.com/nmstate/nmstate/blob/master/commit-template.txt

I tried rebasing to squash the commits, it seems like there was a issue with the head :/

I tried rebasing to squash the commits, it seems like there was a issue with the head :/
Let me rebase the HEAD from start

What is your git setup/problem? Usually it should work like this:
git fetch upstream
git rebase -i upstream/master

For this you need to have added the upstream repo as upstream remote.

Yes I did the same.
My git version :
git version 2.21.1 (Apple Git-122.3)

You can squash the commits while merging.

Yes I did the same.
My git version :
git version 2.21.1 (Apple Git-122.3)

You can squash the commits while merging.

Good. There are two commits in this PR, please squash them, so that there is only one commit. Also please reword the commit message to follow the template I linked.

Hi, here is my feedback:

Currently, we need to group up the tasks. Some of them are trivial like "Click save draft" or "Click on publish release".
PyPi release should be a task too.

Currently, we need to group up the tasks. Some of them are trivial like "Click save draft" or "Click on publish release".

Like merging them into one?

Currently, we need to group up the tasks. Some of them are trivial like "Click save draft" or "Click on publish release".

Like merging them into one?
* [ ]  Click `Save draft` and seek for review, Once approved click `Publish release`

In my opinion it would be nice to do something like.

[ ] Tag the release and save it a s a draft.
[ ] Verify the release.

Instructions to verify it. (Not as a task list)

[ ] Publish the release.

Somewhat like this?

Somewhat like this?

Yes, that is quite better. But we need to do that with a lot of tasks. Please, review the document.

I actually use README.release.md all the time for the release process.
I do not understand why documentation should be pushed back so deep.
Some of the steps there are not even github related.
Could you please explain the reasoning for moving that documentation?

I actually use README.release.md all the time for the release process.
I do not understand why documentation should be pushed back so deep.
Some of the steps there are not even github related.
Could you please explain the reasoning for moving that documentation?

It allows to create a new issue from this template with all the steps as tasks, see for example #916

Merged. Thanks for the help.


Sharing the image id that was built V0

Task name:  DockerV0
Description: Share the imageId that was built in the common env variable
Documentation changes required: N
Added unit tests: Y
Attached related issue: https://github.com/microsoft/azure-pipelines-tasks/issues/14650
Checklist:

[x] Task version was bumped - please check instruction how to do it
[x] Checked that applied changes work as expected

/azp run

/azp run


strong mode's return type inference breaks in analysis_server

Ironically, this fails in our own type:
abstract class CoercionInfo extends StaticInfo {
  // ...
  toErrorCode() => new HintCode(name, message);

Invalid override. The type of CoercionInfo.toErrorCode (() → dynamic) is not a subtype of StaticInfo.toErrorCode (() → ErrorCode). lib/src/task/strong/info.dart, line 70

The error doesn't appear right away--it seems caused by my editing files. My guess is we're losing the "implicit return type" flag, since it's not tracked in the type system.

CC @leafpetersen
I haven't looked into this but a few ideas: Analyzer's element model already has a few special types that behave like dynamic (e.g. CircularTypeImpl), but otherwise preserve additional info, so we could make one for implicit dynamic that is distinct from explicit dynamic. Another option would be to always check in the AST whether a type is implicit (the AST should let us verify the absence of a TypeName in a reliable fashion.)

BTW, that's just speculation on my part. It could be that something totally different is going wrong.

Another option would be to always check in the AST whether a type is implicit (the AST should let us verify the absence of a TypeName in a reliable fashion.)

We discard AST structures, so there's no guarantee that we'd have an AST to look at when we need the information. That's why we added the flag to the element mode. If it turns out that the flag is not being preserved, that's a bug we need to fix.

Hmmm, is that the case? It looks like we have the AST available to us in the InferInstanceMembersInUnitTask task:
void internalPerform() {
    //
    // Prepare inputs.
    //
    CompilationUnit unit = getRequiredInput(UNIT_INPUT);
    TypeProvider typeProvider = getRequiredInput(TYPE_PROVIDER_INPUT);
    //
    // Infer instance members.
    //
    if (context.analysisOptions.strongMode) {
      InstanceMemberInferrer inferrer = new InstanceMemberInferrer(typeProvider,
          typeSystem: context.typeSystem);
      inferrer.inferCompilationUnit(unit.element);
    }
    //
    // Record outputs.
    //
    outputs[RESOLVED_UNIT9] = unit;
  }

We aren't using it yet (instead we get the .element) but we could, right?

Yes. If you've explicitly asked for it, then it won't go away. The problem arises if you were using Element.computeNode().

In general I don't think we've paid enough attention to making sure that we're working correctly with the analyzer's incremental resolution mode.  My guess here would be that there might be a missing dependency in InferInstanceMembersTask for the incremental case, or else that whatever is driving the incremental resolution is not set up to recompute all of the right things for us.

ah, that makes sense. So it's possible we're skipping the task entirely. That would definitely explain this behavior.

Not much figured out yet, but a few notes so far:
I can break when we're about to generate the invalid method override. hasImplicitReturnType is true, and the element looks fine, other than having a dynamic as its return type
From the analysis_server logs, it appears to be running both steps in the right order for this compilation unit. I see:

1449709583798:Task:/Users/jmesserly/src/dart/sdk/pkg/analyzer:InferInstanceMembersInUnitTask for source /Users/jmesserly/src/dart/sdk/pkg/analyzer/lib/src/task/strong/info.dart
1449709588725:Task:/Users/jmesserly/src/dart/sdk/pkg/analyzer:StrongModeVerifyUnitTask for source /Users/jmesserly/src/dart/sdk/pkg/analyzer/lib/src/task/strong/info.dart

All of the tasks we ran on info.dart look fine and seem to have been run in the correct order. The first one being BuildDirectiveElementsTask. (I wouldn't have necessarily expected it to start there.)

progress! I've got a simple, debuggable, fast iteration repro in dart_test.dart:

  void test_library_cycle_override_inference_incremental() {
    enableStrongMode();
    Source lib1Source = newSource(
        '/my_lib1.dart',
        '''
library my_lib1;
import 'my_lib3.dart';
''');
    Source lib2Source = newSource(
        '/my_lib2.dart',
        '''
library my_lib2;
import 'my_lib1.dart';
''');
    Source lib3Source = newSource(
        '/my_lib3.dart',
        '''
library my_lib3;
import 'my_lib2.dart';

class A {
  int foo(int x) => null;
}
class B extends A {
  foo(x) => null;
}
''');
    AnalysisTarget lib1Target = new LibrarySpecificUnit(lib1Source, lib1Source);
    AnalysisTarget lib2Target = new LibrarySpecificUnit(lib2Source, lib2Source);
    AnalysisTarget lib3Target = new LibrarySpecificUnit(lib3Source, lib3Source);

    computeResult(lib1Target, RESOLVED_UNIT);
    computeResult(lib2Target, RESOLVED_UNIT);
    computeResult(lib3Target, RESOLVED_UNIT);
    CompilationUnit unit = outputs[RESOLVED_UNIT];
    ClassElement b = unit.declarations[1].element;
    expect(b.getMethod('foo').returnType.toString(), 'int');

    // add a dummy edit.
    context.setContents(
        lib1Source,
        '''
library my_lib1;
import 'my_lib3.dart';
var foo = 123;
''');

    computeResult(lib1Target, RESOLVED_UNIT);
    computeResult(lib2Target, RESOLVED_UNIT);
    computeResult(lib3Target, RESOLVED_UNIT);
    unit = outputs[RESOLVED_UNIT];
    b = unit.declarations[1].element;
    expect(b.getMethod('foo').returnType.toString(), 'int',
        reason: 'edit should not affect member inference');
  }

fails:
FAIL: ComputeLibraryCycleTaskTest | test_library_cycle_override_inference_incremental
  Expected: 'int'
    Actual: 'dynamic'
     Which: is different.
  Expected: int
    Actual: dynamic
            ^
   Differ at offset 0
  edit should not affect member inference

Bingo. We aren't clearing the ClassElement.hasBeenInferred flag, but we are mutating the original MethodElementImpl (same ID) to have "dynamic" again as its return and parameter types. I'll see if I can figure out where the mutation is happening & if there's a logical place to update the hasBeenInferred flag.
I'm not entirely sure why the hasBeenInferred flag exists, as we're already processing this inference on a per-compilation unit level. So I'm not sure how we'd see the same type twice (except it cases like this, when we need to re-resolve). Maybe I can figure it out from the changelog.

Ah, it goes back to the original CL. Which used to have this comment:
https://codereview.chromium.org/1306313002/diff2/20001:40001/pkg/analyzer/lib/src/task/strong_mode.dart
The comment is gone now, so I'm not sure if the original concern is gone as well? @bwilkerson @leafpetersen do y'all have any recollection of this? I'll keep digging in the meantime

FYI -- removing that flag fixes the bug & all existing tests pass.

Ah ... the issue is we'll do extra work because we're jumping up and inferring the supertype & mixins & interfaces. That's a bit sketchy. Hmmm.

https://codereview.chromium.org/1513143004/

Ah ... the issue is we'll do extra work because we're jumping up and inferring the supertype & mixins & interfaces. That's a bit sketchy.

I don't know why the comment is gone. I think the concern is still valid, and you just ran into the "potential" problem it was referring to. It is indeed sketchy to store this kind of state in the element model, but we do need to prevent duplicated work. We need a better solution...


Accessing slot contents

Is there a simple way to access component's slot contents?
For what I know the only way is to access it is to get eg. this._slotContents.default.textContent.
I'd like to propose creation of instance property called $slots which will contain contents of slots.
For example
console.log(this.$slots);
//Would print
Object {
    default: 'This is the default slot',
    someNamedSlot: 'This is a named slot'
}

I'm aware I can do everything with props but in many cases the slot syntax is just, at least for me, more natural and elegant.
What do you think about this?
I'm not familiar with VueJS source at all, otherwise I would make a PR.

It's intended to implement. Please see #1726

@KKSzymanowski, you could create a plugin which will save those slots content as you expect. Seems quite a specific feature.

@miljan-aleksic For me it feels more like a part of the core, but if, as @ktsn said, it's intended to be implemented I will close this and wait patiently for this functionality.
Thanks.


Able to cache additional directories

refer: #43
Add option to persist specific directories for caching using the cache-directories option in Swatinem/rust-cache.

@robjtede @jonasbb any updates?

Thank you for the PR. Since there seems to be demand for exposing more of the Swatinem/rust-cache surface I might make sense to look over the inputs and see what else is useful.
I try to make a new release during the weekend.


sh checker for ksh93 on AIX shows fizsh shell like behaviour

This issue refers to syntax_checkers/sh/sh.vim. The issue considers 3 topics errorformat, login shell vs. shebang shell, and shellredir. It is not yet an option to use shellcheck on AIX because it is somewhat hard to build it.
A command-line check of a broken.sh script using the shells
bash  (version 5.0.0(2)-release)
ksh93 (Version M 93t+ 2009-05-01)
ksh   (Version M-11/16/88f)
has the output
./broken.sh: line 6: syntax error: unexpected end of file
./broken.sh: syntax error at line 6: `{' unmatched
./broken.sh[3]: 0403-057 Syntax error at line 3 : `{' is not matched.

Two items have to be added to the errorformat!
let errorformat =
     \ '%f: line %l: %m,' .
     \ '%f: syntax error at line %l: %m,' .
     \ '%f[%l]: %m'

If I am using ksh as my login shell and inside broken.sh bash as shebang shell, syntastic sh checker works.
If I am using ksh as my login shell and inside broken.sh ksh93 as shebang shell (#!/usr/bin/ksh93), syntastic sh checker works, but it uses the login shell ksh instead the shebang shell ksh93 to run the check
SyntasticMake: called with options: {'errorformat': '%f: line %l: %m,%f: syntax error at line %l: %m,%f[%l]: %m', 'makeprg': 'ksh -n ./broken.sh'}
If I am using ksh93 as my login shell and inside broken.sh ksh93 as shebang shell (#!/usr/bin/ksh93), syntastic sh checker does not work.
SyntasticMake: called with options: {'errorformat': '%f: line %l: %m,%f: syntax error at line %l: %m,%f[%l]: %m', 'makeprg': 'ksh93 -n ./broken.sh'}
ksh93 runs the check. That is correct but the vim shellredir option is set to '>'. After change it with
set shellredir=>%s\ 2>&1
syntastic sh checking works.

Two items have to be added to the errorformat!

I have updated errorformat to match ksh93 messages.

If I am using ksh as my login shell and inside broken.sh ksh93 as shebang shell (#!/usr/bin/ksh93), syntastic sh checker works, but it uses the login shell ksh instead the shebang shell ksh93 to run the check

Syntastic only recognizes bash, zsh, and sh in the shebang, then fall back to the login shell.  It's a half-assed attempt, but there is no point in trying to use the actual shebang for checks because there is no guarantee random shells will produce errors in a known format (as you already found out).  You can override this by setting:
lset g:syntastic_sh_sh_exe = 'ksh93'

(but you don't get autodetection).

That is correct but the vim shellredir option is set to '>'.

The default is Vim's doing, and syntastic doesn't try to find out if it's appropriate or not.  It's up to you to make sure you have a working system() and that calling it doesn't lose error messages.  Syntastic is a Vim script (and a dead one at that), not a full OS.  It won't try to accommodate everything you could possibly throw at it. shrug


68 update header

Hey, I know we said to make it smaller, but working on it I thought making it disappear was pretty coo, what do you think @gaeVG ?

Don't we lose navigation if the menu ends up disappearing? If not, why not, it enlarges the interface.

Don't we lose navigation if the menu ends up disappearing? If not, why not, it enlarges the interface.

Yes we do. I could make it reappear on the scroll up.
Like you scroll down it disappears, you scroll up it reappears. Instead of making it reappearing only when you reach the top of the window.
What do you think?

@gaeVG PR up to date, ready to be tested!
You'll see I've created a custom hook for the scrolling in case we would wanna reuse it. This way we would'nt have to rescuscribe to an event listener that would cost us in performances.

Yes we do. I could make it reappear on the scroll up.
Like you scroll down it disappears, you scroll up it reappears. Instead of making it reappearing only when you reach the top of the window.
What do you think?

It can work indeed, it looks natural to slightly raise the page to recover the header.

@gaeVG PR up to date, ready to be tested! You'll see I've created a custom hook for the scrolling in case we would wanna reuse it. This way we would'nt have to rescuscribe to an event listener that would cost us in performances.

I like the idea of custom hooks, but I don't know if it should be put in a hooks folder in the src folder; to me it's not strictly speaking a component and should not be in that folder. It reminds me of the handleResponse.js and switchOptions files in the utils folder which would belong there. I don't know what you think 🤗

@gaeVG PR up to date, ready to be tested! You'll see I've created a custom hook for the scrolling in case we would wanna reuse it. This way we would'nt have to rescuscribe to an event listener that would cost us in performances.

I like the idea of custom hooks, but I don't know if it should be put in a hooks folder in the src folder; to me it's not strictly speaking a component and should not be in that folder. It reminds me of the handleResponse.js and switchOptions files in the utils folder which would belong there. I don't know what you think 🤗

You're right, I forgot this folder, it's corrected!


Export property groups

This PR merely exports the property groups as specified by the stylelint-config-clean-order module.
By exporting the groups we allow the person implementing this config to overwrite the order/properties-order rule.
Overwriting that rule, opens up possibilities to do numerous things. For example:

Disable the emptyLineBefore option to not force empty lines between the groups (that's what I was after).
Change the severity of the properties-order rule, which would solve #20

Example implementation of a stylelintrc file that modifies both options mentioned above.
const propertyGroups = require('stylelint-config-clean-order/src/groups');

const propertiesOrder = propertyGroups.map((properties) => ({
  noEmptyLineBetween: true,
  properties,
}));

module.exports = {
  extends: [],
  rules: {
    'order/properties-order': [
       propertiesOrder,
       {
         severity: 'error',
       },
    ],
}

Hello Boaz, thanks for the PR! I'm not actually fond of providing this kind of low-level API for customization but I guess it doesn't hurt to support it. It would be perfect if stylelint configs can accept props of some kind but until that time, I think this is the most suitable way for deep customization.

Change the severity of the properties-order rule

You need to also include these lines to do that and it makes it a little bit verbose but it works.
https://github.com/kutsan/stylelint-config-clean-order/blob/c246f2028c8c10ca403cb532d0703a278198c30a/src/index.js#L85-L87
Just one little thing; would it be better to export it from src/index.js like below?
module.exports = config
module.exports.propertyGroups = propertyGroups

That way we can use it like this:
const { propertyGroups } = require('stylelint-config-clean-order'); // No need to import from `src/groups`.

const propertiesOrder = propertyGroups.map((properties) => ({
  noEmptyLineBetween: true,
  emptyLineBefore: 'never',
  properties,
}));

What do you think?

Hey @kutsan
I noticed you made some changes and a new release yesterday.
I've pulled your changes back to my fork and applied the changes you requested.
Now we can import the property groups like so
const { propertyGroups } = require('stylelint-config-clean-order');

This is published with v5.2.0.


Use correct user-agent for internal analytics.

This change will use the x-goog-api-client headers as following examples:

for bigtable: "gl-cpp/GNU_7.3.0-ex-2011 gccl/v0.9.0+306647f4"
for storage: "gl-cpp/GNU_7.3.0-ex-2011 gccl/v1.0.0+306647f4"

and use user-agent headers as follows:

for bigtable "gcloud-cpp/v0.9.0+306647f4"
for storage: "gcloud-cpp/v1.0.0+306647f4 libcurl/7.60.0 OpenSSL/1.1.1b zlib/1.2.11 c-ares/1.14.0"

These user-agent and x-goog-api-client headers allows our internal analytics pipeline to pick up requests from this library.
also fix #2203
w.r.t. how to store static string values, now I'm having static std::string, following to the existing code.
Caveat: Some versions of MSVC report the incorrect version in __cplusplus, so the version of the c++ standard is not perfect.

This change is

Please hold off merging this. I want to make sure that our internal pipeline correctly picks up the requests before merging.

No worries, in any case, you probably want to fix the CI builds first.

@coryan PTAL
I updated the PR and the PR description for also using x-goog-api-client headers. This is consistent with most of the client libraries for other languages which are sending both x-goog-api-client and user-agent headers.
I think we can remove the do not merge label now.

The integration test is failing. I assume I'm adding the x-goog-api-client header in a wrong place in the code, I'll fix this.

Oh, If we add a custom header like x-goog-api-client when using the V2 signed URL, we should also add the same header to the signed blob. The SignedUrlV2 integration test passed locally with the last change.

@coryan Kokoro Ubuntu test failed, but according to the log, I assume it's just a sporadic error. Is it possible to just re-run Kokoro Ubuntu test?
The log says:
[    ERROR ]  storage_bucket_samples get-bucket-policy-only
================ [begin run_example.6O9dj0] ================
./storage_bucket_samples get-bucket-policy-only cloud-cpp-test-bucket-15660-8595-27602
Standard C++ exception raised: Permanent error in GetBucketMetadata: EasyPerform() - CURL error [35]=SSL connect error [UNKNOWN]

I think we should fix the flake too though.

I restarted the flaky build and created #2660 to track the flakiness.


rattler-build incorrectly includes some files from libarrow when it is a host dependency

I'm not certain whether this is a bug in rattler-build or something that the libarrow package is doing that is fundamentally incompatible with the specs of rattler-build, so please let me know if I should refile this issue upstream.
That said, here is what I currently observe. Using this recipe:
recipe:
  version: 1.0.0

source:
  path: .

outputs:
  - package:
      name: example
    build:
      script:
        content: "echo bar"
    requirements:
      host:
        - libarrow

I expect the resulting package to be a metapackage. However, instead what I observe when I unpack it is the following:
$ rattler-build build --experimental --no-build-id
$ cd output/linux-64
$ cph x example-1.0.0-hb0f4dca_0.conda
$ find example-1.0.0-hb0f4dca_0/share -type d -links 2
example-1.0.0-hb0f4dca_0/share/gdb/auto-load/home/nfs/vyasr/local/testing/rattler_build_tests/libarrow_gdb_file/without_cache/output/bld/rattler-build_example_1721617935/host_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib
$ ls $(find example-1.0.0-hb0f4dca_0/share -type d -links 2)
libarrow.so.1700.0.0-gdb.pyhost_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/libarrow.so.1700.0.0-gdb.py

Evidently a file from libarrow is being repackaged. I also see a bunch of paths related to libarrow inside the info directory, but I assume that is because the info is capturing information about the host environment in the build and therefore there's nothing to really worry about there. Please let me know if that seems incorrect too.
In the case of this file, my guess is that the cause of its inclusion is somewhere in the arrow-cpp-feedstock's activation script. I haven't dug much further, but my guess is that its usage of _la_placeholder="replace_this_section_with_absolute_slashed_path_to_CONDA_PREFIX" is somehow incompatible with paths/env vars that rattler-build is not expecting to be replaced and is resulting in a nested replacement preventing the file from being properly excluded from the list of files in the package. As I said above, though, I'm not sure if this is an issue in rattler-build or something that needs to be fixed in the arrow feedstock to make it compatible with rattler-build.

Unfortunately conda-build exhibits the same behavior. I think this is something that should be fixed in the arrow-cpp-feedstock.
A workaround for this issue is to exclude these files from the package using the build.files section. This worked on my machine:
recipe:
  version: 1.0.0

source:
  path: .

outputs:
  - package:
      name: example
    build:
      script:
        content: "echo bar"
      files:
        include:
          - "**"
        exclude:
          - share/gdb/**/libarrow.so*-gdb.py
    requirements:
      host:
        - libarrow

Major point to rattler-build: it didn't even occur to me to test this with conda-build because I'm averse to how long it would have taken :joy: Thanks for verifying that.


Error 500 when I create a new issue

I deployed the project on Vercel with the APP_ID, PRIVATE_KEY and WEBHOOK_SECRET .
But I have this error, on a new issue in the vercel function console :
[POST] /api/webhooks 11:50:17:08
Function Status: 500
Edge Status: 500
Duration: 98.17 ms
Init Duration: N/A
Memory Used: 109 MB
ID: h5zq6-1632304217080-76d3ef406435
User Agent: GitHub-Hookshot/915fca4

fs{/sha}",
"trees_url": "https://api.github.com/repos/...",

Any idea ?

I don't understand how you can run bot:build and bot:start on Vercel.

You don't need to run bot:build and bot:start at all. They are only for debugging.
make sure you have set all the environment variables

Closing due to inactivity

I am facing this same issue, @maximousblk can you help me. I have set all the ENV except the client_secret and the client_id

GITHUB_CLIENT_ID and GITHUB_CLIENT_SECRET are required to communicate with the github api otherwise it will throw error

So I added GITHUB_CLIENT_ID and GITHUB_CLIENT_SECRET in vercel's environment variables now I am getting status 200 to the events that I have not yet written logic to. But getting status 500 on the default function that should create a comment in issue when it is opened.

Does this means there is something wrong in my setup I am doing this for the first time.

can you create a new with more details about your setup?


Audio Failure

Ive seen similar issues to this on different versions but i cant seem to fix it on version 2.3.1
Unhandled Exception.
ExceptionCode=C0000005
Address=00007FFB4D71A036 (00007FFB4D700000 +<PHONE_NUMBER>01A036)
and
Failed to start audio capture. Thread aborted before starting to loopback capture. message=IAudioClient::Initialize failed: hr = 0x88890008

I had to uncheck steam audio. Then use sound from my pc.


Can not run multiple videos in Android device.

Steps to Reproduce

I have a dashboard where multiple videos will be played simultaneously.
It works smoothly on iOS devices.
But on an Android device, only one video plays at a time. If I start another video, then the previous video that was playing stops.

Screenshot

Logs

Logs

@md-siam
Please note that when you open an issue, try to use new issue template and fill out requested details so that we'll have enough details to work with.
You haven't shared a code sample so we don't know how are you rendering videos. Are you using video_player plugin ?
Please provide minimal code sample and flutter doctor -v too.

Closing this as resolved.


Error: Stack "{stack}" did not have an output with name "{name}LambdaFunctionQualifiedArn"

functions:     ThumbnailGenerator:     name: ThumbnailGenerator     handler: handlers/thumb-generator.handler     lambdaAtEdge:       distribution: cloudfrontDistribution       eventType: origin-request
When I look in the cloudFormation stack the lambda function clearly exists with the expected name but for some reason serverless keeps complaining about ThumbnailGeneratorLambdaFunctionQualifiedArn. I've tried renaming the function, using the name property, not using the name property, I've tried going in the source code and modifying line 143 of index.js in the plugin package to try hard coding all possible configurations of the lambda name that I can think of. None of them seem to be connecting...
Halp?

So after some digging I've discovered:

The function in this package: index.js:274 _getFunctionsToAssociate requires the lambda ARN with version number. I'm not sure how I'm supposed to provide this, there is no Serverless documentation for appending lambda ARN with version number to the Resources: Outputs: ... directive. Right now I literally have my ARN:version_number hard coded in your package code which is the only way I can seem to get it to almost work.

Lambda@edge requires function versioning. I can't find any Serverless documentation for automating this process either. Obviously I can version and deploy the function by clicking through the AWS interface, but I really want this all to happen automagically.

@aquaticpond in a previous response that it looks like you have since deleted, you said:

So after some digging I've discovered:

The function in this package: index.js:274 _getFunctionsToAssociate requires the lambda ARN with version number. I'm not sure how I'm supposed to provide this, there is no Serverless documentation for appending lambda ARN with version number to the Resources: Outputs: ... directive. Right now I literally have my ARN:version_number hard coded in your package code which is the only way I can seem to get it to almost work.

Lambda@edge requires function versioning. I can't find any Serverless documentation for automating this process either. Obviously I can version and deploy the function by clicking through the AWS interface, but I really want this all to happen automagically.

Have you followed the instructions on the project's README? It gives a complete working example. If you try that and are still unable to get it working, please provide a complete serverless.yml file that replicates the problem (or, better, a complete zip of a simple example project that replicates the issue). Until we have that, there's not much else we can do.


[TASK] Attestation reader improvements

Currently attestation reader reverts the getattestation call when subject field is not abi encoded address.
It should handle the case when address is directly stored without abi encoding (e.g abi encoding packed)
Also it should return 0 address when subject is not address type

Done


Provide max character / max line limits

Will make #17 simpler as single line inputs will be a common use-case, and adds ways for such limits to extend to other use cases (e.g. username length limits)

Nice idea, in velo I just hacked single line inputs by disabling editing on enter: https://github.com/StaffEngineer/velo/blob/b75fa7c770ed5bb78652dcb508382c64152d7e4b/src/ui_plugin/systems/keyboard.rs#L150, this is a proper fix 👍


moufiltr: Mirror mouse movement

Make the driver more interesting by mirroring mouse events, so that left movement becomes right, up movement becomes down, and so on.
Using MOUSE_MOVE_ABSOLUTE(1) with negation instead of MOUSE_MOVE_RELATIVE(0) to allow bitmask operations.

Gentle reminder.

I closed this PR unintentionally.  I apologize. I am reopening the PR.

@JakobL-MSFT Anything holding back reviewing this PR?


updated MD workflow metainfo

@ladinesa this should be the same that you already saw in the NOMAD repo, but maybe just take a quick look.
small question: should we be using single quotes throughout? I feel like it keeps going back and forth, but maybe it's just me..

@ladinesa this should be the same that you already saw in the NOMAD repo, but maybe just take a quick look.
small question: should we be using single quotes throughout? I feel like it keeps going back and forth, but maybe it's just me..

if they switched to double quotes in nomad then we switch to double quotes.

small question: should we be using single quotes throughout? I feel like it keeps going back and forth, but maybe it's just me..

if they switched to double quotes in nomad then we switch to double quotes.

I think this is coming from Ruff, and they did not specify anything about quotation (thought I was googling and it is easy to set this up).
We have now the VSCode with the Ruff extension, so I am guessing we are going to face a lot of situations in which a bunch of code is going to be reformatted. Is it not better to ask Ahmed for help here, @ladinesa, or should it be our responsability?

ok, well, I will not worry about it for now.
so...Can I merge this?

small question: should we be using single quotes throughout? I feel like it keeps going back and forth, but maybe it's just me..

if they switched to double quotes in nomad then we switch to double quotes.

I think this is coming from Ruff, and they did not specify anything about quotation (thought I was googling and it is easy to set this up).
We have now the VSCode with the Ruff extension, so I am guessing we are going to face a lot of situations in which a bunch of code is going to be reformatted. Is it not better to ask Ahmed for help here, @ladinesa, or should it be our responsability?

yes, it is simply defining it in the ruff format file. we should apply the same style that is used in nomad.

ok, well, I will not worry about it for now.
so...Can I merge this?

can you please also use the schema from the plugin in the h5md parser? thanks. also, please determine if new tests are necessary.

can you please also use the schema from the plugin in the h5md parser?

Sorry, what do you mean exactly?

can you please also use the schema from the plugin in the h5md parser?

Sorry, what do you mean exactly?

change all the from nomad.datamodel.metainfo.simulation.workflow import * to from simulationworkflowshchema import *

can you please also use the schema from the plugin in the h5md parser?

Sorry, what do you mean exactly?

change all the from nomad.datamodel.metainfo.simulation.workflow import * to from simulationworkflowshchema import *

Ah got it. Yes, I will do that shortly, thanks.


Update readme.md

git clone command corrected for https

Hi, man. There is no error. Please read https://docs.github.com/en/repositories/creating-and-managing-repositories/cloning-a-repository for usage of "git clone"

Hi Dynmi. Thanks for your response. I'm already aware of the ssh clone. That's why I wrote git clone command corrected for https
I'm suggesting this pull request because by default cloning is done by https. To clone by ssh the user should add ssh keys in  GitHub account. That's where some people get in trouble. However cloning by https(which is default in github) is much more straightforward.

Fine.
Merged. Thanks for your contribution!


Issue/369/run3 pho sim production

Changes to address Lustre issue #410 and various other production-motivated changes.

PS. New release: Run3-phoSim-v2

Thanks Phil.  New release installed, tested and we're up and running again!


Fix get youtube transcript error

File Organizer 2000 is an Obsidian plugin that includes an AI Chat, similar to chatGPT. One of the functionalities it has is that it can retrieve YouTube transcripts. And users can extract information about it. It works quite well. However, at times it mentions that it could could not retrieve the transcript. Although it actually does. We don't want this type of message to appear:
I currently don't have access to the transcript for the YouTube video with the ID "SwQhKFMxmDY". If you have any other requests or need assistance with something else, feel free to let me know!
It should only appear when it was actually really not retrieved.
There are two solutions that are acceptable. Either:

don't show that message
show a message mentioning it was successfully retrieved

should still appear when it was not retrieved

Additional Information
I will provide you with an openAI key to run the server
Instructions on how to self-host can be found on our github readme
Setup Instructions for Developers
Install Obsidian: Ensure Obsidian is installed if not already available.
Install Plugin: Clone the project into your vault (see loom video).
Additional Developer Notes
Ensure thorough testing of this new feature to maintain the plugin's reliability and user experience.
You'll need to clone the project inside a vault you created (Dev in this example). In the "plugins" folder as seen below

Where to clone the repo:
https://www.loom.com/share/c9b4cb3decf14662bba0393d20953576
Reach out for any questions

/attempt #245

I keep getting this Failed to load plugin "fileorganizer2000". Tried installing node_modules and running dev command.

/attempt #245

@neo773 @iamhvsharma is any of you still tackling this issue?

Yes I am working on it!!!
Understanding the codebase as of now!

/attempt #245


deps: bump atlas (issue with current version of atlas due to an argum…

…ent change in NewDriver)
Signed-off-by: MasseElch<EMAIL_ADDRESS>

@alexsn Sorry to bother you, your initial setup of the CI ran the integration tests on master in every PR. Is there any special reason for that (I am not sure I know why this is done).

@alexsn Sorry to bother you, your initial setup of the CI ran the integration tests on master in every PR. Is there any special reason for that (I am not sure I know why this is done).

The migration step was added by me to check that migrating from the master version to the new version is safe and keeps BC (on an existing database). Please, keep it as it prevented a few issues in the past.


Minor login issue

I just found some other minor issues regarding the login functionality. Don't merge yet! Thank you.


"other" filter for party returns no legislators

wherefore art thou, Bernie?

Related: There are some ambiguous party affiliations in the API dataset, see gist: https://gist.github.com/c859fdd384031f08bdb1
Should we make a determination on some of these? Surely Manchin can be switched to Democrat, but the others may not be as clear-cut. We should also take another look at the import process for the sake of future data integrity.

Front-end issue fixed in ff28b21


DBZ-1068 Support capture instances with captured_column_list defined

Hey @grzegorz8, I'm unsure where we are with this one. Your last comment above seems to indicate you're planning to still do some changes on this?

Hey @grzegorz8, howdy? Any thoughts on ^^^?

Hey @grzegorz8, just checking in on this one. Any plans on your side to wrap it up? Thanks!

Basically it works, but the there is still one ugly thing: SqlServerStreamingChangeEventSource.java line 285.

Hey @grzegorz8, just seeing your reply. On

SqlServerStreamingChangeEventSource.java line 285.

Do you have a reference (actual link)? The class has changed a bit, so I'm not sure which part you specifically mean. And, related to that, are you still interested in wrapping this up, or should someone else take over?

I mean this code piece:
            // If a column was renamed, then the old capture instance had been dropped and a new one
            // created. In consequence, a table with out-dated schema might be assigned here.
            // A proper value will be set when migration happens.
            currentTable.setSourceTable(schema.tableFor(currentTable.getSourceTableId()));

in SqlServerStreamingChangeEventSource.java:migrateTable

And, related to that, are you still interested in wrapping this up, or should someone else take over?

I give up :(

FWIW, for the past week I have been using a Debezium JAR built from the v0.9.5.Final tag + this PR's changeset, and all has gone well so far in usage against some capture instances that only track a subset of their source tables' columns. I am not anticipating any upcoming column renames, though. 😄

Hi folks, can anyone tell why this PR doesn't go to master?

@marcelojscosta Hi, it seems generally there is one thing incomplete - https://github.com/debezium/debezium/pull/748#issuecomment-492526200
Please feel free to continue on this work, we'd be more than happy to accept it.

@jpechane is it really something that avoids this PR it to be merged on master?
Does it seem something more related to improvement, maybe a new JIRA/Issue?
In any case, could you share your toughs about how this could be improved?

HI @jpechane!
I work with @marcelojscosta at Via Varejo. We are planning to use this branch in production, and we did a little change to connect Sql Server by instance name.
We would like to help in this PR, how can we contribute? Open a new PR? Continue on grzegorz8:DBZ-1068-captured-column-list-support branch? @grzegorz8
Regards, Mello.

@joaomello Hi, thanks for the offer! The best approach would be to create a new branch and PR off the current one and rebase it on the recent master.
Then please take a look at https://github.com/debezium/debezium/pull/748#issuecomment-496529861 and write a test case covering the comment. If it really proves to be the issue it needs to be handled before being merged.

One thing worth noting: while we were working with this, we found that we had to add the names of the untracked columns to the connector's column.blacklist configuration. If you don't, all of the table's columns will be present in the event schema, but the untracked columns will have null values. IMO that had the potential to lead to confusion for people consuming those messages (i.e.: is it really null? or just untracked?), so we chose explicit blacklisting. My gut says that having only tracked columns in the events' schemas is the preferable behavior, but that would mean an increase in the scope of this PR which might not be worth holding things up over.

@woodlee Yes, only tracked columns should be in schema. I think for start we can ask user to manually update column.blacklist and a follow-up Jira can do it automatically.

@joaomello, thanks for picking this one up. Are you planning to wrap this one up soon? This seems to be a great feature to get implemented in this connector (I would think lot others must be interested too since this seems to be a common practice in the industry to pick and choose at column level for CDC.
@jpechane , Thanks for pointing me to the right direction.

Hello,
Any status on this issue?
We plan to use this feature in production.Would be really helpful if this could be implemented

Hey @udaya2899, tbh. this one fell a bit through the cracks. So IIRC, it's mostly done, by now it really needs a rebase and then we should take another look at what might be missing. Would you perhaps be interested in taking this up and send a new PR based off of current master?
@grzegorz8, apologies for letting this one become so stale. I hope we can finally wrap up his one.

@gunnarmorling I ran into this issue and I would be willing to help in anyway. Any updates? Seems the code changes are already in place? Would really love to see this fixed before going to production. Thanks!

@gunnarmorling I ran into this issue and I would be willing to help in anyway.

Hey @andritch, If you got some bandwidth to help out with this one, that'd be great. The first thing would be to take this branch, rebase it to current master and create a new PR from there. Also there's probably one open issue (see https://github.com/debezium/debezium/pull/748#issuecomment-532097513), which needs addressing. I haven't looked into the details of this in quite a while, so I can't say much about the specifics from the top of my head. Your help for driving this home would definitely be welcomed.

Hey all, going to close this one in favour of the rebased PR https://github.com/debezium/debezium/pull/1758. The basic implementation is in place, follow-up work is tracked via DBZ-2495 (the open issue around column renaming described above as well as the need for having to explicitely exclude filtered columns on the connector side). Thanks!


Secret keys are generated externally

Mirrors https://github.com/nhsx/COVID-19-app-Android-BETA/issues/14 in iOS app.
https://github.com/nhsx/COVID-19-app-iOS-BETA/blob/370a51857b8a680925adc85bfc2e08936a2fd77d/Sonar/Networking/ConfirmRegistrationRequest.swift#L55-L57

As mentioned in the other issue, I don’t think secretKey is the private key that goes with the returned private key. If I remember correctly from the design document, the private key remains on the server and is ultimately what allows the server to match the signed broadcast identifiers to the original installation ID on the server.

As mentioned in the other issue, I don’t think secretKey is the private key that goes with the returned public key. If I remember correctly from the design document, the private key remains on the server and is ultimately what allows the server to match the signed broadcast identifiers to the original installation ID on the server.

As (now) mentioned in the other issue: the problem is worse than originally reported.  secretKey is the key used to prove ownership of the ephemeral key pairs, but since secretKey is known to the server then the server is able to forge signed messages for an arbitrarily chosen fake ephemeral key pair.

For more information on the technical and security design, please read the report at https://www.ncsc.gov.uk/report/nhs-covid-19-app-privacy-security-report

For more information on the technical and security design, please read the report at https://www.ncsc.gov.uk/report/nhs-covid-19-app-privacy-security-report

Already read it.  Please read and understand the security flaw as described in https://github.com/nhsx/COVID-19-app-Android-BETA/issues/14

@edent on Pg5 of that paper :

These are not the only security and privacy promises we make, but seem to be the most important
to explain early in the app’s development.

Assuming integrity of the central server is not great, if it is compromised in the middle of a peak of an outbreak, it means devices will have +20 days of encounter information which may need to be discarded as untrusted,

For those that haven't already seen it, there's an NCSC blog post about the security questions raised.
https://www.ncsc.gov.uk/blog-post/nhs-covid-19-app-security-two-weeks-on

I'm pasting this message in every active GitHub issue, so you may receive duplicate notifications.
Today, I'm happy to announce that NHSX has released the full git commit history for the Isle of Wight Beta apps.

Android - https://github.com/nhsx/COVID-19-app-Android-BETA
iOS - https://github.com/nhsx/COVID-19-app-iOS-BETA

As discussed, we have redacted API keys, sensitive domain names, and some of the developers' personal details. I am still waiting on final approval to publish the server-side code.
I would like to personally thank the community for your comments, bug reports, and vulnerability disclosures. They all went into helping the development process.
The beta trial of this app has now ended and we've moved to the next phase of app development. It is our intention to publish the source code of future apps as the binaries are released to the public.
Once again, thank you for being part of this.
Terence Eden
Head of Open Technology - NHSX


Mobile responsiveness for the landing page

HI @kaxada , @Ruth-ikegah @iamkingsleey ,i'll like to work on making the landing page responsive if the design exists. if not and u want me to continue, i can do that as well

anyone working on this? if not I'd like to

anyone working on this? if not I'd like to

Hi, i am

I'd love to join you guys to work on it  as well

duplicate of https://github.com/badging/badging/issues/80


🔄 Removed Inline & Internal CSS for about 🔗📂

Related Issue
Closes: #310
Description of Changes
Externalized CSS for About, FAQ, and Guest PHP pages. Cleaned up codebase for better maintainability and performance. Your collaboration is valued! 🌟📝🚀
Checklist:

[x] My code adheres to the established style guidelines of this project.
[x] I have conducted a self-review of my code.
[x] I have included comments in areas that may be difficult to understand.
[ ] I have made corresponding updates to the project documentation.
[x] My changes have not introduced any new warnings.

@apoorvaron Review for this file and will work changes like this for others

@apoorvaron Please Check


Don't stop processing sections if task is past hide_future

If the top task in a section has a due date past hide_future,
the tasks after it do not get a Next tag. Let's fix that.
Signed-off-by: Christopher Obbard<EMAIL_ADDRESS>

hm it doesn't work; if there are three cards: one with no date, one with date after hide_future and one with no date, the no date cards both end up with Next. A forth card does not end up with a label though ;-)
I can live with that, i don;t really have time to do a workaround right now, but i guess one way could be to use a counter instead of a boolean; skip the rest of that section once the counter >= 1 ?

hm it doesn't work; if there are three cards: one with no date, one with date after hide_future and one with no date, the no date cards both end up with Next. A forth card does not end up with a label though ;-)
I can live with that, i don;t really have time to do a workaround right now, but i guess one way could be to use a counter instead of a boolean; skip the rest of that section once the counter >= 1 ?

It got annoying so I fixed it; now all cases seem to work properly with hide_future

Hi there. Thanks for your support on this. Due to the major overhaul this change can't be merged any more, but in the latest version all tasks will still get a label if a previous (top) task in a section has a due date that's past the hide_future flag.
Closing this one for now.


Please tag releases, or provide an SDIST archiv on Pypi.

Thanks.
your library supports an integration in Home Assistant, I would like to use your library in my Gentoo Overlay for Home Assistant, hope you don't mind.

Therefore I would need a release file either at Pypi in SDIST format, or as a tar.gz on github. I cannot use the library in wheel format. Normally, when no SDIST can be found at Pypi, I would take the source from Github. This was not possible in this case, because you do not tag releases here. A release on Github is OK, but a Pypi SDIST tar.gz release would be preferred, because this could take use of Gentoo's mirror system and updates download stats. Most of the other (~1100) integrations I use for the repo have both. If something goes wrong with one version, I would have the change to try the other. This could avoid holdups if other libraries depend on it.
Please add a tag for 0.1.6. As soon as you add a tag, Github builds a usable source archive. Make sure that release points in Github are on the commit which was used for the release in Pypi.
If you build an SDIST for Pypi, make sure that all files needed for building are included. A common mistake is a missing requirements.txt or README.md which the is opened by setup.py during compile process.
One or more of the requirements of this library are pinned to a specific version. Hard pinning may work now, but will lead to problems if an other integration updates it's requirements. To avoid future issues it would be good if this library would change its pinning to allow any higher version and just set a minimum version. Especially when you pin very common libraries like aiohttp or requests-oauthlib.
Thanks a lot for your work.

\B.

I prefer the simplest way: just create a new release, is that ok?
I'm afraid if I push a SDIST to pypi, I have to bump the version.


Change borderCapStyle and borderJoinStyle defaults to be compatible with SKIA canvas

Setting these defaults prevents errors when using annotations in the skia canvas context. See Issue for more details: https://github.com/chartjs/chartjs-plugin-annotation/issues/938

Change LGTM, but it seems the CI fails

Change LGTM, but it seems the CI fails

I'll have a looko.

I think i need help with this. test-integration works locally for me, but i'm on mac. Not sure why it would be failing on ubuntu.

I think i need help with this. test-integration works locally for me, but i'm on mac. Not sure why it would be failing on ubuntu.
Edit: Actually, it looks like test-integration succeeded, but then the process failed with no further messages.

Actually, i'm getting the same build failure on the master branch. Can you check?

I will look into it this weekend

@mlohbihler LGTM. May be you can try the branch against SKIA canvas to check if it is working as expected.

@mlohbihler the failed test has ben fixed in https://github.com/chartjs/chartjs-plugin-annotation/pull/902. Therefore after merging of that, we could re-run the failed job

@mlohbihler the failed test has been fixed in #902. Therefore after merging of that and rebase this branch, we could re-run the failed job

@stockiNail nice. Thanks for this.

@mlohbihler if you will rebase and push again, we can go on. Take your time. Thanks a lot!

@mlohbihler if you will rebase and push again, we can go on. Take your time. Thanks a lot!

Build checks are passing now, but i guess with the (net zero) playing around i did i lost my approval. Re-requested.

Apologize if I hadn't time before to have a look.
The changes are adding options not used by those annotations therefore I would prefer to change only the setBorderStyle (reverting the current changes of PR) as following:
export function setBorderStyle(ctx, options) {
  if (options && options.borderWidth) {
    ctx.lineCap = options.borderCapStyle || 'butt';
    ctx.setLineDash(options.borderDash);
    ctx.lineDashOffset = options.borderDashOffset;
    ctx.lineJoin = options.borderJoinStyle  || 'miter';
    ctx.lineWidth = options.borderWidth;
    ctx.strokeStyle = options.borderColor;
    return true;
  }
}

Let me know what you think

That change seems to work for me. Note that there are other instances of these properties getting set. Not sure if they can be removed too. E.g. see https://github.com/mlohbihler/chartjs-plugin-annotation/blob/0bce23d13a8db9aa9c58a80e5fc2929b4dfbab71/src/types/box.js#L40

That change seems to work for me. Note that there are other instances of these properties getting set. Not sure if they can be removed too. E.g. see https://github.com/mlohbihler/chartjs-plugin-annotation/blob/0bce23d13a8db9aa9c58a80e5fc2929b4dfbab71/src/types/box.js#L40

@mlohbihler the joinStyle and capstyle are used for setting on canvas only in the point that you have changed.
The other istances are only in the options defintions of the annotations in order to enable the options settings from the user.


[release-1.22] Address CVE-2022-41717

Bump golang.org/x/net to v0.4.0
The issue was addressed:

on master with https://github.com/kubernetes/cloud-provider-openstack/pull/2064
on v1.25 with https://github.com/kubernetes/cloud-provider-openstack/pull/2078
on v1.24 with https://github.com/kubernetes/cloud-provider-openstack/pull/2080
on v1.23 with https://github.com/kubernetes/cloud-provider-openstack/pull/2081

Which issue this PR fixes(if applicable):
CVE-2022-41717
Special notes for reviewers:
The issue was addressed:

in v1.26 with https://github.com/kubernetes/cloud-provider-openstack/commit/52858db8131938f661f5201be2e3418094eed62b
in v1.25 with https://github.com/kubernetes/cloud-provider-openstack/commit/702d53ad9c7c7a2a1b4b1e054ef44e886b5d7b3b

Release note:

NONE

/ok-to-test


Replication volume limit

Volume limit for CRR has been updated to 10 volumes. Please change: "You can set up a maximum of five volumes for replication within a single subscription per region." for "You can set up a maximum of ten volumes for replication within a single subscription per region.".

@beagam : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"


Color Identification using OpenCV

Related Issue
Color detection in images using OpenCV
√ DevIncept Participant
√ Contributor
Closes: #27
Describe the changes you've made
I have added a new project that detects colors in  a given image with their proportions using a pie-chart as well as finds those images from a lot which has the mentioned color that we require.
Type of change
What sort of change have you made:
It is a new feature to this repo.
Bug fix (non-breaking change which fixes an issue)

√ New feature (non-breaking change which adds functionality)
Code style update (formatting, local variables)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
How Has This Been Tested?
Describe how have you verified the changes made
I have written code in jupyter notebook to test the code on a particular image and return a pie chart with proportion of its colors. Also I have tested the code by bringing out the images with color we ask for.
Checklist:
√My code follows the guidelines of this project.
√I have performed a self-review of my own code.
√I have commented my code, particularly wherever it was hard to understand.
√I have made corresponding changes to the documentation.
√My changes generate no new warnings.
√I have added test cases that prove my fix is effective or that my feature works.

First of all read the README and CONTRIBUTING GUIDELINES of the project. Then you would know the project structure and changes you have to make. @vishvarana

Renamed according to snake_case and updated README according to the format.

I have to make a different branch right? Rest all is done I guess.
Please let me know I am new to this

I am opening a new pull request and closing this one because of conflicts

But you should never close issues or PR from your end. Not everyone would take it positive. Just letting you know so that you don't do it in future. Instead you could had said it to me to close it. @vishvarana


Update CRYSTAL documentation and example

Dear Togo,
Some very small updates to the documentation. Mainly to change notation --dim_fc2 to --dim-fc2.
Best wishes,
Antti

Merged. Thanks.


chore: unstable tests

DO NOT MERGE

@sebbi08 why is this no draft? and where is the WIP label? :)

No WIP / Draft as we need the pipelines to run

No WIP / Draft as we need the pipelines to run

pipelines run for Drafts and also when the WIP label is set.
-> Draft is for not confusing others with this PR, it makes your "DO NOT MERGE" unnecessary
-> WIP is to disable mergify, you do not need it for this PR


JSON Arrays

I'm having a problem with passing in a JSON array into a JSON column.  For some reason it makes it to runQuery on clients/server/postgres:34, but I'm not sure what happens after that.
I'm seeing the bindings turn the [{"key":"value"},{"key":"value2"}]  into {{"key":"value"},{"key":"value2"}}, so I'm guessing its trying to wrap the object into an invalid syntax.  Do you happen to know where this happens at?  I've spent the last couple hours looking but I'm not sure what happens after runQuery.

@badave @matthew-dean You can use the bookshelf-json-columns plugin, it makes that job easier.


PoolStringArray.empty() returns "False" when its empty

Godot version: Godot Engine v3.2.stable.official

OS/device including version: Win7 OpenGL ES 3.0 Renderer: GeForce GTX 1080/PCIe/SSE2

Issue description: PoolStringArray.empty() returns False when its empty

Steps to reproduce:
	var nstr = ""
	print(nstr) #will not print! why?
	var strarr = nstr.split(" ",true,0)
	print(strarr) #prints [] an empty array
	print(strarr.empty()) #prints "False", claims to have contents

Output:

[]
False

So, I was working on some Text processing and some of the lines were just empty. Strangely asking the returned PoolStringArray whether it was empty retuned False consistently. I managed to trace it to the String.split() function, which under certain arguments produces an empty array that is confused about its contents.
when compiling this report, I also noticed that print("") prints nothing. I was convinced that print() always concludes with a new line. Hence there is printraw() which doesnt.
Greetings

I tried it and it's working as expected for me on 3.2.2 stable on Fedora 32.

print(nstr) #will not print! why?

This will print an empty line. Try to print("nstr: ", nstr) and you should see it.

var strarr = nstr.split(" ",true,0)
print(strarr) #prints [] an empty array
print(strarr.empty()) #prints "False", claims to have contents

You set allow_empty to be true. That means that there is an empty String and that strarr isn't an empty PoolStringArray but an PoolStringArray with one element, which is an empty String. Use var strarr = nstr.split(" ", **false** ,0) and it should work as you would expect.

Indeed, it's as @Leleat describes. The confusion comes from the fact that empty strings are not visible when printed (but they still exist and are valid).


[hidapi] Update to 0.14.0

Changes:

Updated hidapi to 0.14.0
Added new feature pp-data-dump, to make the build of the new pp_data_dump.exe developer tool optional

Checklist:

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[x] The "supports" clause reflects platforms that may be fixed by this new version
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

Thank you!