"Best Practices" page in docs website

This issue is based on feedback provided by Simson Garfinkel.
We should be more careful about showing bad practices in our documentation, even for educational purposes.
My thinking is to:

add a best practices documentation page
pass through the docs to identify bad practices

make adjustments if possible to address them
otherwise add disclaimers and link to the best practices docs

typical-workflow covers "best practices documentation page"
but there are still some bad practices: Histogram comparisons, mostly?


Optimizer support for INSERT INTO SELECT

This PR is for the Peloton's partial INSERT INTO SELECT support.  #136 and #700 are related issues, and the old/new optimizers have not been providing this feature.
This PR allows the users to specify any SELECT queries that Peloton currently supports with INSERT.  However, it does not yet allow the users to specify the columns that the selected values are stored into, e.g. INSERT INTO table_a (col_a, col_b) SELECT ....  Meanwhile, the user can get around this by changing the column order in SELECT.
This is my first go for the new optimizer, so it needs to be reviewed from one of the new optimizer authors.

Coverage increased (+0.06%) to 72.536% when pulling e5881739289fbffb28a5f253498d3fb1cebc00a8 on seojungmin:optimizer-insert into 7dc10d41fade8aee46517e7a89f8a200a79b68b4 on cmu-db:master.

@hzxa21 can you have a look and comment on this PR, in your spare time?  This is urgent.

Sure. I will look at this today.

@hzxa21 I commented it wrong last time.  I should have said that "not urgent".  I am sorry about this, and it does not have to be today.

I will merge.

Coverage increased (+0.07%) to 72.536% when pulling 6fbd716737638ceae46e76df1704539a003c7add on seojungmin:optimizer-insert into fed8d6ae15dc56368e6046132db788aad612ac4f on cmu-db:master.


test: add jest example/test

resolves https://github.com/nuxt/test-utils/issues/218

Was this an issue that was already solved?

You may need to build first with pnpm prepack.

Works with a .cjs file of jest, will see if I can get it working with .ts config as well

Opened: https://github.com/nuxt/test-utils/pull/225/

I think there's already an eslint config 🤔

I think there's already an eslint config 🤔

top level, yes.
It's not inheriting it all the way in, ends up using my defaults

Ah, I think that's okay. We want the examples to be separately cloneable, and we run the autofix from the top.

Oh okay 👌

Yeah, I ended up adding an import for it manually.
jest and its sandbox doesn't like a lot of things

Yeah, I ended up adding an import for it manually.
jest and its sandbox doesn't like a lot of things

https://github.com/nuxt/test-utils/pull/224#issuecomment-1796140588

Now Windows fs error:

That's from my commits? I didn't test on windows but let me know if you have a hard time

That's from my commits? I didn't test on windows but let me know if you have a hard time

No, just testing on my local, but both seem almost identical, I'll check with your changes.

can you test in your local adding .npmrc (root folder) with shell-emulator=true and changing the script to "test": "NODE_OPTIONS=--experimental-vm-modules jest"?
The error on my local Windows laptop:
test/server.e2e.spec.ts
  ● setup

    TypeError: The argument 'filename' must be a file URL object, file URL string, or absolute path string. Received 'file:\\\D:\work\issues-repos\test-utils-pr-
224\node_modules\.pnpm\nuxt@3.8.1_@types+node@20.8.10_eslint@8.53.0_rollup@3.29.4_typescript<EMAIL_ADDRESS>
      91 |     });
      92 |   }
    > 93 |   ctx.nuxt = await kit.loadNuxt({
         |              ^
      94 |     cwd: ctx.options.rootDir,
      95 |     dev: ctx.options.dev,
      96 |     overrides: ctx.options.nuxtConfig,

      at Function.createRequire (../../node_modules/.pnpm/jest-runtime@29.7.0/node_modules/jest-runtime/build/index.js:1618:23)
      at module.exports (../../node_modules/.pnpm/jiti@1.21.0/node_modules/jiti/dist/jiti.js:1:639)
      at createJITI (../../node_modules/.pnpm/jiti@1.21.0/node_modules/jiti/dist/jiti.js:1:250383)
      at Object.<anonymous>.module.exports (../../node_modules/.pnpm/jiti@1.21.0/node_modules/jiti/lib/index.js:14:10)
      at setup (../../node_modules/.pnpm/nuxt@3.8.1_@types+node@20.8.10_eslint@8.53.0_rollup@3.29.4_typescript@5.2.2_vite@4.5.0/node_modules/nuxt/dist/index.mjs:3052:28)
      at normalizedModule (../../node_modules/.pnpm/@nuxt+kit@3.8.1_rollup@3.29.4/node_modules/@nuxt/kit/dist/index.mjs:2141:37)
      at installModule (../../node_modules/.pnpm/@nuxt+kit@3.8.1_rollup@3.29.4/node_modules/@nuxt/kit/dist/index.mjs:2439:95)
      at initNuxt (../../node_modules/.pnpm/nuxt@3.8.1_@types+node@20.8.10_eslint@8.53.0_rollup@3.29.4_typescript@5.2.2_vite@4.5.0/node_modules/nuxt/dist/index.mjs:3696:7)
      at loadNuxt (../../node_modules/.pnpm/nuxt@3.8.1_@types+node@20.8.10_eslint@8.53.0_rollup@3.29.4_typescript@5.2.2_vite@4.5.0/node_modules/nuxt/dist/index.mjs:3783:5)
      at Module.loadNuxt (../../node_modules/.pnpm/@nuxt+kit@3.8.1_rollup@3.29.4/node_modules/@nuxt/kit/dist/index.mjs:2584:19)
      at loadFixture (../../dist/index.mjs:93:14)
      at Object.setup2 (../../dist/index.mjs:154:7)

same error with latest changes here reverting "@nuxt/test-utils": "workspace:*" to use "@nuxt/test-utils": "latest" on my local


Car stream is not working for Mi Note 3

I have tried  Android Auto 2.9 and 3.0 both with car stream 1.8.3, please help .
It is showing tap on last button when i am trying to play .

Have you modified the package name with APK Editor? Have you checked if unknown sources are activated?

I did not modify the package name because not aware about APK editor

That's a crucial point to get it working

I tried everything as instructed on main page.. still it is not working.
Using Apk editor and changed the name of the packager of carstreamer, able to produce new app with different packager name .ans also using old version of Android APK 2.9.57... and using latest car streamer.
Observed, on infotainment last button does not show Car Streamer option except return to Maruti Suzuki option.

Hi, can anyone assist with the Sarangf's problem? I am having the same issue. I am a first time user of Car Stream.
I have Uninstaller AA 3.0 and installed AA 2.9. I have done the developer settings in AA and changed the package name of Car Stream with APK Editor Pro.
I have Car Stream version 1.8.3 installed but  the Car Stream button does not appear on the screen when I click on the last button on AA, it only shows "Return to Sync".
Please help...

The Car Stream icon is now appearing in the AA audio menu but when you click on it, you get the message to click on the last button to access YouTube.
When you click on the last button then it does not appear there.

Google killed 3rd party apps. Only solution is to roll back Google Play Services. But it's very tricky.


Update tungstenite and tokio-tungstenite

Not sure if you wanted to upgrade but I am debugging an issue in my app and did the upgrade to be able to test so created a PR in case this is something that is desirable to upstream.

cargo-machete requires has a higher MSRV so the job failed but I didn't add deps.


[Automation] Generate Fluent Lite from TypeSpec deviceregistry

[Automation] Generate Fluent Lite from TypeSpec deviceregistry

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure.resourcemanager:azure-resourcemanager-deviceregistry


galaxy slayer zed Q animation not right and the shadow emotion isnt right if you W Q and running animation not like the normal skin

          galaxy slayer zed Q animation not right and the shadow emotion isnt right if you W Q

Originally posted by @meeezaezaa in https://github.com/R3nzTheCodeGOD/R3nzSkin/issues/1#issuecomment-1636827070

#1


Registration process - Update Required attribute to allow optional for SubmitDocumentTypeIds in RegistrationSettings

Description
As an Operator, we discovered that we don’t necessarily need documents to be submitted during registration.
We manage all the documents during the sales process before the Portal registration process.
We want to make the document submission step optional.
Acceptance Criteria

[ ] As an operator, I can make documents both required or optional based on my environment variables
[ ] If optional, customers should be able to submit registration without adding documents
[ ] If optional, no error message is displayed when clicking the submission button
[ ] if required, an error message should be displayed when clicking the submission button
[ ] Whether optional or required, registration can be submitted on the Frontend side

Additional Information
In portal BE file src/registration/Registration.Service/BusinessLogic/RegistrationSettings.cs We have to update Required attribute to handle null or empty value for SubmitDocumentTypeIds  and handle the null or blank array for this variable.

Hello @jjeroch, can you confirm that we can make the "Submit document" step in the registration process optional?
We don't want to use it given the current Cofinity-X registration process, but it is required by the Portal backend.
Please give us a thumbs up so our teams can start collaborating on the technical solution!

Acceptance Criteria

@dhiren-singh-007 Can you add the suggestion of @evegufy to the acceptance criteria?

Whether optional or required, registration can be submitted on the Frontend side

Hi @ntruchsess : Did you get a chance to look into this ?

The ticket is getting analysed internally now. Feedback will be provided shortly. Please also share if you contribute to this ticket with code or not. This is currently not clear. If you contribute, please share already your idea to solve the issue.

Thanks @jjeroch for the update. I am happy to contribute .I will share the PR.

@jjeroch @ntruchsess : Can you please check this PR .
https://github.com/eclipse-tractusx/portal-backend/pull/853
I also analyzed if any api will be obsolete if we enable this flag.
I found that there is no api using the flag SubmitDocumentTypeIds  . All document api are generic and expecting the different parameters only.


YARN-11704. No need to apply extra 'AND' placement constraint for non tags in PlacementConstraintManager.getMultilevelConstraint

Description of PR
After applying the placement constraint allocator in our internal cluster, I found some hotpoint that will effect the scheduling performance as the allocation time metric value increase a lot.
After dumping the flamegraph, the hotpoint is that the SingleConstraintAppPlacementAllocator.checkCardinalityAndPending, this should be optimized by like cache or other ways. But the unnecessary nested AND placement constraint may be a small improvement for this case.
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

PTAL @slfan1989 This is a small improvement for placement constraint mechanism

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 38s

trunk passed

+1 :green_heart:
compile
0m 36s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
0m 32s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
0m 33s

trunk passed

+1 :green_heart:
mvnsite
0m 37s

trunk passed

+1 :green_heart:
javadoc
0m 36s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
1m 12s

trunk passed

+1 :green_heart:
shadedclient
20m 26s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 26s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
0m 26s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 23s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
0m 27s

the patch passed

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 28s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

-1 :x:
spotbugs
1m 10s
/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
20m 34s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
89m 53s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 26s

The patch does not generate ASF License warnings.

174m 10s

Reason
Tests

SpotBugs
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Possible null pointer dereference of allConstraints in org.apache.hadoop.yarn.server.resourcemanager.scheduler.constraint.MemoryPlacementConstraintManager.getMultilevelConstraint(ApplicationId, Set, PlacementConstraint)  Dereferenced at MemoryPlacementConstraintManager.java:allConstraints in org.apache.hadoop.yarn.server.resourcemanager.scheduler.constraint.MemoryPlacementConstraintManager.getMultilevelConstraint(ApplicationId, Set, PlacementConstraint)  Dereferenced at MemoryPlacementConstraintManager.java:[line 281]

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6940/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6940

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 89d5e4192f9f 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c8f4673f2b6c98c22534a6cebb19009497f318b2

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6940/1/testReport/

Max. process+thread count
951 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6940/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Change format for standard picklist values being deployed

Critical Changes
Change from standard value set deployment from unpackaged to add_standard_value_set_entries task.
Changes
Issues Closed
#34

@mkolodner running a test dev_org flow to confirm this works.  With this change, we cannot remove (deactivate) the picklist values.  This is a best practice per HUB post.  Would need to build documentation to ask for deactivation.  I think Case Reason is the only one this affects.

As annoying as it is, I understand why we can't deactivate values--I saw the Hub discussion. (It would be nice, though to have a way to have the scratch orgs not require that manual work every time.)
I was just running a dev org test to see about the email address change and for some reason the flow looked like it ran with no errors, but my org had none of the OCC app in it. I've killed that scratch and am running another too see if it repeats. But that was weird.

I noticed NPSP does this for contact roles with the config folder so I'll add it there.  Running a test flow to confirm and will merge.


no files

There aren't any files in the files property in package.json

thanks for the heads up

should be fixed


Strip white space around interaction URLs

We have ~240 URLs that fail link checking because of Invalid URI.  A short
investigation revealed that ~220 of these have trailing white space on the URL
which will cause URI.parse to throw URI::InvalidURIError before they get a
chance to be link checked.  (They may have other problems as well)
We already have code to strip white space in links_controller and
local_authorities_controller, but this is only called when a URL is edited.
homepage_urls are not affected by this problem.

💭


i have problem about restore checkpoint!

hi!
i have problem about restore checkpoint.
It stopped learning, so I tried to restore but got an error.
help! T^T
restore is True
Found folder! restoring
Traceback (most recent call last):
  File "train.py", line 122, in <module>
    learning_rate_scheduler=scheduler)
  File "/home/ailab/HGL-pytorch/utils/pytorch_misc.py", line 226, in restore_checkpoint
    training_state = torch.load(training_state_path, map_location=device_mapping(-1))
  File "/home/ailab/anaconda3/envs/r2c/lib/python3.6/site-packages/torch/serialization.py", line 368, in load
    return _load(f, map_location, pickle_module)
  File "/home/ailab/anaconda3/envs/r2c/lib/python3.6/site-packages/torch/serialization.py", line 549, in _load
    deserialized_objects[key]._set_from_file(f, offset, f_should_read_directly)
RuntimeError: unexpected EOF, expected 4859355 more bytes. The file might be corrupted.
terminate called after throwing an instance of 'c10::Error'
  what():  owning_ptr == NullType::singleton() || owning_ptr->refcount_.load() > 0 ASSERT FAILED at /opt/conda/conda-bld/pytorch_1549628766161/work/c10/util/intrusive_ptr.h:350, please report a bug to PyTorch. intrusive_ptr: Can only intrusive_ptr::reclaim() owning pointers that were created using intrusive_ptr::release(). (reclaim at /opt/conda/conda-bld/pytorch_1549628766161/work/c10/util/intrusive_ptr.h:350)
frame #0: c10::Error::Error(c10::SourceLocation, std::string const&) + 0x45 (0x7f3920592cf5 in /home/ailab/anaconda3/envs/r2c/lib/python3.6/site-packages/torch/lib/libc10.so)
frame #1: THStorage_free + 0xca (0x7f38d72a68ea in /home/ailab/anaconda3/envs/r2c/lib/python3.6/site-packages/torch/lib/libcaffe2.so)
frame #2: <unknown function> + 0x12c11d (0x7f39208d011d in /home/ailab/anaconda3/envs/r2c/lib/python3.6/site-packages/torch/lib/libtorch_python.so)
<omitting python frames>
frame #17: __libc_start_main + 0xf0 (0x7f39266a8830 in /lib/x86_64-linux-gnu/libc.so.6)

Aborted (core dumped)

It seems that you loaded an uncompleted file. Could you check the saving path of your checkpoint to make sure whether the checkpoint is saved?

Hi, I want to know how many GPU memories do you use for successfully running this code? @jaeyun95


CodingWondersSoftware.DISMTools.Stable version 0.4.2

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Since the manifest file was updated with WingetCreate, it still retains the 1.5 manifest schema version


Fixer "Method argument space" and no space after typehint

Hello,
The fixer "Method argument space" don't add space (if missing) between the type hint and the variable. I try with both 1.10 and 2.*@dev.
function foo(array$bar)
{
}

It would nice to fix this sample code.
I can't find an explicit rule about the need for this space in PSR-2 (§4.4) but all the samples have it.
So it could be a new fixer?

:+1: for new fixer

:+1:

Please, take a look at #1349

Great! Thanks a lot!


Refactor label filter

In this PR, we make the following changes:

go from label_filter to label_filters -- this allows us to define multiple filters, which must ALL match
add a new filter condition, for not-equals
allow leader election to operate on filtered backends, thus making leader election and filters no longer mutually exclusive (the mutual exclusivity was not documented)

this covers our main use case -- utilize only backends in the current region and the current az (the default case), or utilize only backends in the current region and NOT the current az (in case of AZ failover).
as well, we refactor the specs for labels to use a factory to create the labels, vs creating hashes manually and being forced to specify a bunch of attributes we don't care about.
to: @jolynch @scarletmeow @nwadams
cc: @jtai

LGTM, thank you for cleaning up the code!

lgtm

👍 lg2m
I am curious about how we're going to allow users to combine the label filters going forward. In this iteration it's a logical and over all the filters, but I am curious how much complexity other options would be (such as or, negation, etc ...). For this PR an and sg2m.


User Needs to stay logged-in

User needs to stay logged in until and unless the user manually logs out

Resolved


Enhancement: Migrate existing Document List workflow with React Query

Describe the Current Behavior/Feature:
Given we now have access to a library like React Query in the project, think we could optimize our data flow similar to how Contact List was done with the useContactList hook. It'll also help concentrate where the functions would be for Document List.
Proposed Behavior/Feature:
Similar to how our data flow for Contact List has been moved from React Context to a custom hook with React Query, a similar process would be done for Documents List.

I think it's a good idea to move the documents over to react query hooks. However, I think I made a bad move when I created the documents list itself (see the permissions issues), so I'm not sure if it's worthwhile to move that object over to react query. The documents list functionally acts as an index, but it doesn't work well. I'm not sure how indexes are supposed to work in solid, but we may be able to look over type indexes for some answers.

Was wondering if we should rework the documents structure first if that was the case.


Error when receiving paidMediaPurchased

Error when receiving Vjik\TelegramBot\Api\Type\Payment\PaidMediaPurchased with a payload
development.ERROR: Not found key "paid_media_payload" in result object. {"exception":"[object] (Vjik\TelegramBot\Api\ParseResult\NotFoundKeyInResultException(code: 0): Not found key "paid_media_payload" in result object.
{
"update_id": 1585xxxxx,
"purchased_paid_media": {
"from": {
"id": 13136xxxxx,
"is_bot": false,
"first_name": "X",
"last_name": "X",
"username": "xxxxxxxxxx",
"language_code": "en"
},
"payload": "12345"
}
}

Is docs non-actual?
https://core.telegram.org/bots/api#paidmediapurchased
Here field is called "paid_media_payload"...

Seems incorrect.   That json above is a raw request capture… is just “payload” outside of the purchased_paid_media object.
The PR I submitted fixes it.

Done by #122

@injektion Thanks for issue! Version 0.4.4 with your fix is released.


Missing fields in CreateTransferRefund interface

Hi,
It's specified in the documentation that you can send the fields DebitedFunds and Fees to the api for a partial transfer refund.
I figured out that the fields are missing in the interface CreateTransferRefund that you find here.

Hello @lachauj,
Thanks for the feedback. It will be added in the following weeks.


Configuration and manual issues

Can you say where cronModule section must be placed? in application.config.php or in cronModule.global.php or in module.config.php of my module? How i can add several jobs?

Best would be to place it in cronModule.global.php or module.config.php of your module.
You can add multiple jobs by adding arrays to the jobs array in configuration.

There is an error in your cronModule.config.php.dist. cronModule section missed.

Fixed it.


Check if profiles_url is disabled rather than exists

It is safer to ensure that when comparing against the PROFILES_URL in settings, that the url is set to disabled rather than if it exists. This allows greater control over calls using profiles_url.

@jamesfneyer I accidentally marked this as 'accepted' - but it does need changes.


ecto.gen.migration doesn't pass through migrations_path option to mix ecto.migrate

Both commands have migrations_path option:
https://github.com/elixir-ecto/ecto_sql/blob/master/lib/mix/tasks/ecto.gen.migration.ex#L20
https://github.com/elixir-ecto/ecto_sql/blob/master/lib/mix/tasks/ecto.migrate.ex#L25
The call is here: https://github.com/elixir-ecto/ecto_sql/blob/master/lib/mix/tasks/ecto.gen.migration.ex#L84
It should pass that option for consistent behaviour.

Can you please send a PR? :)

Ok, will do :D

Great, thanks!


9 implementing corrections first from code review

Codecov Report

Merging #10 (fa61672) into master (b549d1b) will increase coverage by 2.09%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master       #10      +/-   ##
===========================================
+ Coverage   97.90%   100.00%   +2.09%
===========================================
  Files           6         8       +2
  Lines         478       917     +439
===========================================
+ Hits          468       917     +449
+ Misses         10         0      -10

Impacted Files
Coverage Δ

...oDoListExercise-Model/EmployeesRepository.class.st
100.00% <100.00%> (ø)

source/ToDoListExercise-Model/Note.class.st
100.00% <100.00%> (+8.69%)
:arrow_up:

source/ToDoListExercise-Model/NoteBuilder.class.st
100.00% <100.00%> (ø)

...ce/ToDoListExercise-Model/NotesRepository.class.st
100.00% <100.00%> (ø)

...istExercise-Tests/EmployeesRepositoryTest.class.st
100.00% <100.00%> (ø)

...ce/ToDoListExercise-Tests/NoteBuilderTest.class.st
100.00% <100.00%> (ø)

source/ToDoListExercise-Tests/NoteTest.class.st
100.00% <100.00%> (ø)

...oDoListExercise-Tests/NotesRepositoryTest.class.st
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b549d1b...fa61672. Read the comment docs.


Plugin can not work in some symbols, just like ) (  > ; space

As titled said

A part of me wants to say this is by design. @whcn Try entering Visual mode first. Put your cursor on "<", hit v, then Ctrl-n.


Use includes with acts_as_ordered_taggable?

Trying to use acts_as_ordered_taggable combined with a includes() but it throws error when doing this. Cant figure how to do this in the correct with to limit the amount of queries done for a view.
## article.rb

class Article < ActiveRecord::Base
  acts_as_ordered_taggable
end

## select

articles = Article.all.includes(:tags)

articles.first # ERROR THROWN

## error

ActsAsTaggableOn::Tagging Load (2.3ms)  SELECT "taggings".* FROM "taggings" INNER JOIN "tags" ON "tags"."id" = "taggings"."tag_id" WHERE "taggings"."context" = $1 AND "taggings"."taggable_type" = 'Workout' AND "taggings"."taggable_id" IN (9232, ..., ..., ..., 9911)  ORDER BY taggings.id  [["context", "tags"]]
  ActsAsTaggableOn::Tag Load (2.4ms)  SELECT "tags".* FROM "tags" WHERE "tags"."id" IN (84, 1, 5)  ORDER BY taggings.id
Completed 500 Internal Server Error in 678ms (ActiveRecord: 21.0ms)

PG::UndefinedTable - ERROR:  missing FROM-clause entry for table "taggings"
LINE 1: ... "tags" WHERE "tags"."id" IN (84, 1, 5)  ORDER BY taggings.i...

Might have something to do with this line: https://github.com/mbleigh/acts-as-taggable-on/blob/8e64c3d4a81cfbb8af621228eae36a65c1f94501/lib/acts_as_taggable_on/taggable/ownership.rb#L45


CLN: remove test_suite runner from test files

I don't think those are used any longer

Coverage remained the same at 83.377% when pulling e81ee52c4f842086f29c81e22852e1db152b8ec9 on jorisvandenbossche:clean-test-suite into eae4dcbedb0756f658f9982825d5fa23b0061b2a on Toblerity:master.


trying to compile permissionsdispatcher-processor:2.0.1

Error:Could not GET 'https://jitpack.io/com/github/hotchemi/permissionsdispatcher-processor/2.0.1/permissionsdispatcher-processor-2.0.1.pom'. Received status code 401 from server: Repository not found or unauthorized

Sorry I just published to jcenter.


Activation Bug

I noticed while creating some activation commands that there is currently no way to change the unable button text as it's been replaced with the attribute buttons. Attached a screenshot below.

You can work around by editing <sectionname>.movebutton in the Localization file.

Okay, I'll try that for now


chore: Fix severe dependency updates

I'm manually updating some of the dependencies that have been flagged as security issues by GitHub.

Oh and to answer your QA question, I would totally rely on the tests here. For more major upgrades I have occasionally cruised around staging or production as things roll out but I have a high confidence that if CI is green then it's good to deploy.

@jonallured Thanks for the review!
I updated the PR to be less explicit about versions. 👍


Improve error handling in the UI.

Code comment: TODO: We have to be better about communicating errors from connector api response such as insufficient permissions with github gh:116 id:33
in file: lib/services/imdoneio-client.coffee:193 has been modified.
Issue Comment Bot - @imdone. Get TODOBOTs to do your work at imdone.io

TODO: We have to be better about communicating errors from connector api response such as insufficient permissions with github gh:116 id:41
lib/services/imdoneio-client.coffee:225
@imdone comment-bot. Get TODOBOTs to do your work at imdone.io

TODO: We have to be better about communicating errors from connector api response such as insufficient permissions with github gh:116 id:33
lib/services/imdoneio-client.coffee:225
@imdone comment-bot. Get TODOBOTs to do your work at imdone.io

TODO: Handle the case where there is no project found. id:41 gh:116
lib/services/imdoneio-store.coffee:71
@imdone commenter. The developer's task board. imdone.io

TODO: Do something with this error id:40 gh:116
lib/services/imdoneio-store.coffee:68
@imdone commenter. The developer's task board. imdone.io

TODO: Do something with this error id:43 gh:116
lib/services/imdoneio-store.coffee:100
@imdone commenter. The developer's task board. imdone.io

TODO: Do something with this error id:48 gh:116
lib/services/imdoneio-store.coffee:126
@imdone commenter. The developer's task board. imdone.io

TODO: Handle errors by unauthenticating if needed and show login with error id:99 gh:116
lib/views/product-detail-view.coffee:106
@imdone commenter. The developer's task board. imdone.io

TODO: If we get a forbidden error, then emit auth failure. id:26 gh:116
lib/services/imdoneio-client.coffee:78
@imdone commenter. The developer's task board. imdone.io

TODO: We have to be better about communicating errors from connector api response such as insufficient permissions with github id:32 gh:116
lib/services/imdoneio-client.coffee:227
@imdone commenter. The developer's task board. imdone.io

TODO: We need to show an error here if service can't be reached or login fails id:86 gh:116
lib/views/login-view.coffee:74
@imdone commenter. The developer's task board. imdone.io

TODO: Handle the case where there is no project found. id:41 gh:116
lib/services/imdoneio-store.coffee:72
@imdone commenter. The developer's task board. imdone.io

TODO: If we get a forbidden error, then emit auth failure. id:26 gh:116
lib/services/imdoneio-client.coffee:78
@imdone commenter. The developer's task board. imdone.io

TODO: Do something with this error id:40 gh:116
lib/services/imdoneio-store.coffee:69
@imdone commenter. The developer's task board. imdone.io

TODO: We have to be better about communicating errors from connector api response such as insufficient permissions with github id:32 gh:116
lib/services/imdoneio-client.coffee:227
@imdone commenter. The developer's task board. imdone.io

TODO: Do something with this error id:48 gh:116
lib/services/imdoneio-store.coffee:125
@imdone commenter. The developer's task board. imdone.io

TODO: Do something with this error id:43 gh:116
lib/services/imdoneio-store.coffee:102
@imdone commenter. The developer's task board. imdone.io

TODO: We need to show an error here if service can't be reached or login fails id:86 gh:116
lib/views/login-view.coffee:61
@imdone commenter. The developer's task board. imdone.io

TODO: Handle errors by unauthenticating if needed and show login with error id:99 gh:116
lib/views/product-detail-view.coffee:108
@imdone commenter. The developer's task board. imdone.io

Issue closed with imdone.io by removing a comment.

https://github.com/imdone/imdone-atom/blob/75fb7b259089bcca763ede7cbb11e75763fae6a5/lib/views/product-detail-view.coffee#L108-L113


TypeError: null is not an object (evaluating 'this.toastInstance._root.showToast')

Using "native-base": "^2.3.3"
My App:
const Client = () => (
  <ApolloProvider client={client}>
    <I18nextProvider i18n={i18next}>
      <Root>
        <App />
      </Root>
    </I18nextProvider>
  </ApolloProvider>
);
export default Client;

Using android.
The case happens when a i started my app, click in back button until minimize the app, then open app, after this, happens the error.

@patrickalbani NativeBase is on 2.4.2
Also share your package.json along with your code snippet

Upgrade version, still the same.
My package.json:
{
	"name": "xxx",
	"version": "0.0.1",
	"private": true,
	"scripts": {
		"start": "node node_modules/react-native/local-cli/cli.js start",
		"test": "jest"
	},
	"dependencies": {
		"apollo-cache-inmemory": "^1.1.2",
		"apollo-client": "^2.1.0",
		"apollo-link": "^1.0.5",
		"apollo-link-context": "^1.0.2",
		"apollo-link-error": "^1.0.2",
		"apollo-link-http": "^1.3.0",
		"graphql": "^0.11.7",
		"graphql-tag": "^2.5.0",
		"i18next": "^10.2.1",
		"jwt-decode": "^2.2.0",
		"moment": "^2.19.3",
		"native-base": "2.4.2",
		"prop-types": "^15.6.0",
		"react": "16.2.0",
		"react-apollo": "^2.0.1",
		"react-i18next": "^7.2.0",
		"react-native": "0.52.0",
		"react-native-auto-scroll": "^0.0.1",
		"react-native-aws3": "^0.0.8",
		"react-native-camera": "^0.12.0",
		"react-native-communications": "^2.2.1",
		"react-native-fast-image": "^2.2.4",
		"react-native-fcm": "^10.0.3",
		"react-native-i18n": "^2.0.10",
		"react-native-material-design-searchbar": "^1.8.0",
		"react-native-material-dialog": "^0.7.1",
		"react-native-permissions": "^1.0.6",
		"react-native-signature-capture": "^0.4.9",
		"react-native-splash-screen": "^3.0.6",
		"react-native-vector-icons": "^4.4.2",
		"react-navigation": "^1.0.0-beta.21",
		"recompose": "^0.26.0"
	},
	"devDependencies": {
		"babel-eslint": "^8.0.3",
		"babel-jest": "21.2.0",
		"babel-preset-react-native": "4.0.0",
		"eslint": "^4.12.1",
		"eslint-config-airbnb-base": "^12.1.0",
		"eslint-plugin-import": "^2.8.0",
		"eslint-plugin-jest": "^21.7.0",
		"eslint-plugin-react": "^7.5.1",
		"eslint-plugin-react-native": "^3.2.0",
		"i18next-conv": "^6.0.0",
		"jest": "21.2.1",
		"react-test-renderer": "16.0.0"
	},
	"jest": {
		"preset": "react-native"
	}
}

I have reproduced as well.
Steps to reproduce

Create project referring to Setup with React Native.
Use Toast component as shown in bellow Screenshot.
Run react-native run-android.
Press Toast button then press OKay in the lower right.
Press hardware back button to minimize the app and then reopen it.

Screenshot of emulator

package.json
{
  "name": "nb1790",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "start": "node node_modules/react-native/local-cli/cli.js start",
    "test": "jest"
  },
  "dependencies": {
    "native-base": "^2.4.2",
    "react": "16.3.1",
    "react-native": "0.55.3"
  },
  "devDependencies": {
    "babel-jest": "22.4.3",
    "babel-preset-react-native": "4.0.0",
    "jest": "22.4.3",
    "react-test-renderer": "16.3.1"
  },
  "jest": {
    "preset": "react-native"
  }
}

same issue on reopen app
version : "native-base": "2.3.3"

Same here @2.4.3

Fixed with 2.5.0

null is not an object (evaluating 'this.toastInstance._root.showToast'), stack: value@700:5249 <unknown>@1365:995 __tryOrUnsub@1369:5256 error@1369:4648 _error@1369:2029 error@1369:1724 notifyError@1426:1066 _error@1428:1141 error@1369:1724 _error@1369:2029 error@1369:1724 _error@1369:2029 error@1369:1724 f@1467:6929 value@94:1505 value@93:9873 value@93:6578 <unknown>@93:14368 value@27:1855 value@20:4857 <unknown>@20:2368 value@20:4111 value@20:2340

I'm getting the error in v2.8.1
I have my components wrapped inside

If I call the Toast from Redux, may I wrap the <Provider> inside <Root> too?

Ok - I'm getting this same error with native-base v2.12.1 and I do have <Root> as my top-level component (@roadev fyi my <Root> is wrapping my redux <Provider> component).
Happens both on Android and iOS devices.

We're having the same issue as @grahammcculloch. Maybe this issue should be reopened?

Same issue with native-base v2.12.0.  So far only on Android 8+.  Here is the top level render method:
      <Root>
        <StyleProvider>
          <Provider store={store}>
            <RootNavigator />
          </Provider>
        </StyleProvider>
      </Root>

I see the same issue too. I'm on "native-base": "^2.12.1". Root is my top level component.

Same issue. @abhiram-n Did you find any solution or workaround on this?

@yogini-bende i sometimes see it as an error report in the sentry. do you know in which cases it happens. do you have still this issue in 2.13.0

This is my showToast function, where I am calling toast from native-base.
export default function showToast(   msg,   sidebarColor = "#73A500",   type = "SUCCESS" ) {   Toast.show({     buttonText: "",     text: (       <Text         style={{           flexDirection: "row"         }}       >         {type === "NETWORK" ? (           <FontAwesome             name="exclamation-circle"             size={20}             style={{ color: sidebarColor, alignSelf: "center" }}           />         ) : (           <Ionicons             name="ios-checkmark-circle"             size={20}             style={{ color: "#73A500", alignSelf: "center" }}           />         )}         <Text style={{ alignSelf: "center" }}>           {"  "}           {msg}         </Text>       </Text>     ),     type: "success",     position: "top",     duration: 5000,     textStyle: [       {         textAlign: "left",         color: "#6D6D6D"       },       commonStyles.font_13     ],     style: {       backgroundColor: "white",       borderLeftColor: sidebarColor,       borderLeftWidth: 5,       borderBottomColor: "grey",       borderBottomWidth: 1,       marginTop: APP.RUNNING_ON_ANDROID ? 25 : 0     }   }); }
and this is the function where I am using that showToast method,
handleFirstConnectivityChange(connectionInfo) {     if(connectionInfo.type === NETWORK_STATUS.NONE || connectionInfo.type ===      NETWORK_STATUS.UNKNOWN) {       showToast("There is no internet connection", "#FDBF39", "NETWORK");     }   }
handleFirstConnectivityChange is throwing this error and no workaround is working. I have even tried to upgrade native-base to 2.13.0 , but no luck.
Can you suggest something @BatDroid

@yogini-bende I believe I got around this by hiding the toasts in componentWillUnmount:
  componentWillUnmount() {     if (Toast.toastInstance != null && Toast.toastInstance.root != null) {       Toast.hide();     }   }

Same issue. @abhiram-n Did you find any solution or workaround on this? I am also using "native-base": "^2.12.1"

I am also seeing the same issue with v2.13.8. My top level component is already wrapped with .
I am seeing this only when I go back in react navigation stack to the component where Toast is being used.

I am also facing this issue with v2.12.1. I've wrapped my top level component with <Root>. Any update on this @SupriyaKalghatgi ?

Same issue, also wrapped in a , also on native base 2.13.8.

I am too getting this issue on native-base 2.13.8. Could someone share the workaround for this?

I am using Root as top level component.
This issue only seems to occur when I ask the user for permissions. (permissions alert/popup seems to be outside root or interfering with root causing this issue)

I'm getting it too with the same use case as @pango89

Yep I am also seeing this in Sentry logs:
Error:
null is not an object (evaluating 'this.toastInstance._root.showToast')

package.json
...
"expo": "^38.0.0",
"native-base": "^2.13.12",
...

App.js render method:
        <BugsnagErrorBoundary FallbackComponent={ErrorFallback}>
          <AppearanceProvider>
            <Provider store={store}>
              <PersistGate loading={this._renderLoading()} persistor={persistor}>
                <Root>
                  <StyleProvider style={getTheme(appTheme === 'light' ? customThemeLight : customThemeDark)}>
                    <View style={styles.container}>
                      <StatusBar barStyle="light-content" backgroundColor={Colors.statusBarBackgroundColor} animated={true} />
                      <AppNavigator
                        ref={ref => this._appNavigator = ref}
                        screenProps={{
                          appTheme,
                          navigationStatePersisted: this._navigationStatePersisted
                        }}
                        {...this.getPersistenceFunctions()}
                        renderLoadingExperimental={() => this._renderLoading()}
                        theme={appTheme === 'light' ? 'light' : 'dark'}
                      />
                    </View>
                  </StyleProvider>
                </Root>
              </PersistGate>
            </Provider>
          </AppearanceProvider>
        </BugsnagErrorBoundary>

try this:
import React, {useCallback, useRef} from "react";
// Solution based on the one here: https://github.com/GeekyAnts/NativeBase/issues/985#issuecomment-411379940
import {Container as ContainerNB, NativeBase, Toast as ToastNB} from "native-base";
import {useFocusEffect} from "@react-navigation/native";

class Toast extends ToastNB {}

const Container = ({children, ...props}: NativeBase.Container & {children: any}) => {

  const toastInstance = useRef();

  useFocusEffect(useCallback(() => {
    if (toastInstance.current && toastInstance !== (Toast as any).toastInstance) {
      (Toast as any).toastInstance = toastInstance.current;
    }
  }, []));

  return <ContainerNB {...props}>
    {/*Needs to be first*/}
    {children}
    {/*// @ts-ignore*/}
    <Toast
      ref={c => {
        if (c) {
          (Toast as any).toastInstance = c;
          toastInstance.current = c;
        }
      }}
    />
  </ContainerNB>;
};

Fixed with 2.5.0

I am using native base "native-base": "^2.13.14", still not fiexd


Fix whistlecane naming schemes for Every Compat

All info here
https://github.com/MehVahdJukaar/WoodGood/issues/423

Go to the gardens_of_the_dead:textures/block/ and look for whistlecane files for textures. Take a good look at a good look at their filenames. That is the problem
Every Compat replace the ID of these textures via Model files using the ID of these wood block (included stripped_log). these ID are used. If the filename is recorrected to whistlecane_stem or whistlecane_steam_top, then the texture will correctly show up on the block.
and i already have a solution for the missing "stripped_log" textures. the log/stem texture will be used in place of "stripped_log" texture

I've updated the whistlecane block texture names to whistlecane_stem and whistlecane_stem_top in version 2.0.2 for Minecraft 1.19.2.
I don't see why this needs to be fixed on my end for Minecraft 1.20.1 though. Apart from not having a stripped variant, I'm using the same naming scheme as vanilla bamboo blocks, so I'd consider this an issue with Every Compat.


Update nuget packages

I have updated the nuget packages to the latest versions.
NJsonSchema had some interface changes, I'm not sure that I have replaced everything correctly.
I also updated the SignalR version in the Core project, the newer version is part of the aspnet core framework, which can't be referenced in a netstandard project, that's why I changed the targetframeworks. (I couldn't find a workaround to reference the newer version of SignalR without this change.)
The output of the new version is the same, except for this part (undefined):
export interface Person {
    firstName: string | undefined;
    lastName: string | undefined;
}

export interface Event {
    Type: string | undefined;
}

But according to the C# classes this seems OK to me.

Any updates on this?

Ref: https://github.com/RicoSuter/SigSpec/issues/2#issuecomment-585999397
Cant we use .NET Core 3.0 for more compatibility?

@TomSmith27 are there things here we still need to merge?

Looks like this updates to .NET core 3 which could be useful to do however there are conflicts because of the updates i made

Do you still want to merge this PR?
Can you fix the conflicts?


Recover Vault

Not able to check in depth as 3tap has some issue
https://github.com/bithyve/bitcoin-keeper/assets/107177634/a80ffcb4-254b-45ab-957f-e0632239d9bd

The flow does not exist


correctly apply selected kernel to configuration profile on server create

Resolves Issue #51

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
GitHub Users Who Are Not Authorized To Contribute
The following GitHub users do not appear to have signed a CLA:

@ckmorris

Please sign the CLA here.

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.


About the use case of security key

I see the security use case(U2F) in the page https://docs.opentitan.org/doc/security/use_cases/.
Is there any open source code for this use case with OpenTitan?
Thank you.

Hi @bling206, not at the moment. We are currently working on the hw and lower firmware layers. We don't have a timeline yet on any reference code.

Please feel free to open if you have any other questions related to this issue. Thanks!


Prisma generate failed

Describe the bug
Prisma migration failed with the error: request to https://binaries.prisma.sh/all_commits/f352a33b70356f46311da8b00d83386dd9f145d6/debian-openssl-1.1.x/migration-engine.gz.sha256 failed, reason: socket hang up
Link to the blitz that caused the error
https://stackblitz.com/~/github.com/tomrbroderick/chicken-event-service
Steps to reproduce
Go to pr.new for the repo
Expected behavior
Repo loads up correctly
Parity with Local

[X] I have run the project in my local machine and I could not reproduce the issue.

Screenshots
No response
Platform
Version = 1.67.0
Hash = 69b9b1602da27b7f44e9800c223182ce1a037ea8
WebContainer = 3c06ff333fff62d153837b0d0df85b8ed07b008f

Browser name  = Chrome
Full version  = 100.0.4896.127
Major version = 100
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.127 Safari/537.36
performance.memory = {
  "totalJSHeapSize": 95891497,
  "usedJSHeapSize": 67858325,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}

Additional context
No response

:wave: @tomrbroderick Can you provide a repro in an public repo?

Not sure if running Prisma is possible inside WebContainer

https://github.com/prisma/prisma/issues/7185
https://github.com/prisma/prisma/issues/7187

Have the same issue with Lucia Auth, which uses Prisma under the hood. Check out my issue here: https://github.com/pilcrowOnPaper/lucia-auth/issues/186
There you will find a reproduction link. I hope that Prisma will work anytime soon.

Prisma is tracking Stackblizt/Webcontainer compatibility here now: https://github.com/prisma/prisma/issues/17710
With a Chrome extension to enable CORS for our engine download endpoint you can download the engines now, and since 4.10.0 also run prisma generate! Most other CLI commands that use the Migration Engine still crash though (as it uses a binary engine) and the default Prisma Client also crashes as it uses a Node-API library (which is still too much like a binary for this environment).
We also have Prisma Data Platform with the Data Proxy, but there for now we arr again hitting CORS and preflights limitations. I can overcome these with an elaborate local setup (Chrome extension + local SSL proxy to simiulate a working preflight request) - but I will hopefully be able to make all that much easier soon. I'll keep you updated.

Wow, that's pretty cool. Thanks for giving an update on the progress! Very exciting and and awesome work @janpio 👏

Just an FYI @janpio We have experimental support for a CORS proxy which is currently behind a feature flag so at some point when this goes live there is no need for using a Chrome extension.
Can you give an update on WebContainer compatibility for Prisma? Is this being actively worked on that there's Wasm-based alternatives for the native addons? @Brooooooklyn is also working on a WASI target for napi-rs and there's also https://github.com/toyobayashi/emnapi from @toyobayashi that has Wasm support. Those two are potentially useful when you have native addons you'd like to compile to Wasm.
It'd be really nice if users could use Prisma in WebContainer and both of our user bases could mutually benefit from it. Is there something that we can help with?

A built-in proxy would indeed help a lot.
We are currently working on a Workers compatible version of Prisma Client that will use a Wasm module, but the problem with other CLI commands that use the schema engine will not be solved via that. That engine currently also needs to talk to databases via TCP socket connections, so we are a bit in a pickle here how to move forward.

Oh I see. Potentially what you could do for the TCP socket is to use TCP over WebSocket maybe. This is not something that we currently support out of the box and definitely something we want to add but I don't know when that will be. Neon does something similar where they have a driver that uses a WebSocket / TCP proxy for the TCP connection instead. This works well in WebContainer today. So maybe the engine can then use another driver which is WebSocket based?

I am aware of Neon and their serverless driver, but that would require a server side component to open and hold those Websocket connections. We have something similar on an HTTP level with Prisma Accelerate which actually works just fine on Stackblitz 👍
The problem here is that migrations (which the schema engine is responsible for) via these "proxies" are a hard problem to solve and also not something that is usually needed for the default use cases of Prisma Accelerate. (With Neon for example you are also expected to do the migrations via a direct TCP socket connection.)
But we'll get there, sooner or later some way.

Ok, thanks for the update @janpio 🙏 Makes sense.

There are multiple Bolt users who have reported this error in the Discord server. Has there been any progress on this since Jan @d3lm?


[SPARK-35995][INFRA][3.2] Enable GitHub Action build_and_test on branch-3.2

What changes were proposed in this pull request?
Like branch-3.1, this PR aims to update GitHub Action build_and_test in branch-3.2.
Why are the changes needed?
Currently, GitHub Action on branch-3.2 is working.

https://github.com/apache/spark/commits/branch-3.2

Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A

cc @gengliangwang

cc @viirya since you are online

Test build #140591 has started for PR 33194 at commit 53f160e.

Thank you, @viirya . Merged to branch-3.2.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45102/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45102/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45102/

@dongjoon-hyun I'm afraid this tries to test master branch.

https://github.com/apache/spark/runs/2974710349

Checking out the ref
  /usr/bin/git checkout --progress --force -B master refs/remotes/origin/master
  Updating files:  99% (17767/17781)
  Updating files: 100% (17781/17781)
  Updating files: 100% (17781/17781), done.
  Reset branch 'master'
  Branch 'master' set up to track remote branch 'master' from 'origin'.
/usr/bin/git log -1 --format='%H'
'6c4616b2ac75f30db63c49ab91a784285b147b11'

The commit 6c4616b2ac75f30db63c49ab91a784285b147b11 is on the master branch.
We should also modify https://github.com/apache/spark/blob/9b0971c40ebbc5309f6684edfef3f7e219c9a4b2/.github/workflows/build_and_test.yml#L91 and the following similar places.
Also, I think, if we would update https://github.com/apache/spark/blob/9b0971c40ebbc5309f6684edfef3f7e219c9a4b2/.github/workflows/notify_test_workflow.yml#L37 in  notify_test_workflow.yml file, it would be helpful for PRs against branch-3.2.

Test build #140591 has finished for PR 33194 at commit 53f160e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140591/

Oh, thank you for checking. Let me dig that, @ueshin !

I'm working at #33197.


Error: @vitejs/plugin-legacy does not support library mode.

Describe the bug
I have created the ionic vue project using vite.
Following are my configs:

When I tried to build (npm run build) the project. I am facing the following error:

Reproduction
npm run build
Steps to reproduce

System Info
System:
    OS: Linux 6.2 Ubuntu 22.04.3 LTS 22.04.3 LTS (Jammy Jellyfish)
    CPU: (8) x64 Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz
    Memory: 15.44 GB / 31.23 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 16.20.1 - ~/.nvm/versions/node/v16.20.1/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v16.20.1/bin/yarn
    npm: 8.19.4 - ~/.nvm/versions/node/v16.20.1/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 117.0.5938.149
  npmPackages:
    @vitejs/plugin-legacy: ^4.0.2 => 4.1.1
    @vitejs/plugin-vue: ^4.0.0 => 4.2.3
    vite: ^4.4.11 => 4.4.11

Used Package Manager
npm
Logs

<EMAIL_ADDRESS>build
vite build debug

vite v4.4.11 building for production...
✓ 0 modules transformed.
✓ built in 12ms
Could not resolve entry module "debug/index.html".
error during build:
RollupError: Could not resolve entry module "debug/index.html".
at error (file:///home/contrive/Documents/scansdk/node_modules/rollup/dist/es/shared/node-entry.js:2245:30)
at ModuleLoader.loadEntryModule (file:///home/contrive/Documents/scansdk/node_modules/rollup/dist/es/shared/node-entry.js:24695:20)
at async Promise.all (index 0)
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Maybe try out some solutions in https://github.com/vitejs/vite/issues/1639? Also seems like this is expected without babel to transpile into older ES versions

plugin-legacy doesn't support lib mode as shown in the error.
Duplicate of #1639


libvirt kube-up.sh nodes never ready

I am following the libvirt-coreos guide here: https://kubernetes.io/docs/getting-started-guides/libvirt-coreos/
When I use kube-up.sh nodes never become ready, however the vms are started and the master is running.
Here is the output from kube-up.sh
root@bumblebee:/data/kubernetes# rm ~/.kube/config
root@bumblebee:/data/kubernetes# ./cluster/kube-up.sh
... Starting cluster using provider: libvirt-coreos
... calling verify-prereqs
... calling kube-up
KUBE_MASTER_IP: <IP_ADDRESS>
KUBE_MASTER: kubernetes-master
--2017-01-14 09:19:19--  https://alpha.release.core-os.net/amd64-usr/current/coreos_production_qemu_image.img.bz2
Resolving alpha.release.core-os.net (alpha.release.core-os.net)... <IP_ADDRESS>, <IP_ADDRESS>
Connecting to alpha.release.core-os.net (alpha.release.core-os.net)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 304 Not Modified
File ‘./cluster/../cluster/../cluster/libvirt-coreos/coreos_production_qemu_image.img.bz2’ not modified on server. Omitting download.

Pool kubernetes refreshed

TLS assets generated...
Network kubernetes_global created from ./cluster/../cluster/../cluster/libvirt-coreos/network_kubernetes_global.xml

Network kubernetes_pods created from ./cluster/../cluster/../cluster/libvirt-coreos/network_kubernetes_pods.xml

Vol kubernetes-node-1.img created

Pool kubernetes refreshed

Domain kubernetes-node-1 created from /tmp/tmp.hYxpMaK013

Vol kubernetes-node-2.img created

Pool kubernetes refreshed

Domain kubernetes-node-2 created from /tmp/tmp.SygUlVLVmF

Vol kubernetes-node-3.img created

Pool kubernetes refreshed

Domain kubernetes-node-3 created from /tmp/tmp.CEMKYOPRt4

Vol kubernetes-master.img created

Pool kubernetes refreshed

Domain kubernetes-master created from /tmp/tmp.feuy17i3Rq

Cluster "libvirt-coreos" set.
User "libvirt-coreos" set.
Context "libvirt-coreos" set.
Switched to context "libvirt-coreos".
Wrote config for libvirt-coreos to /root/.kube/config
Wait for cluster readiness
Nb ready nodes: 0 / 3
.......

root@bumblebee:/data/kubernetes# virsh -c qemu:///system list
 Id    Name                           State
----------------------------------------------------
 25    kubernetes-node-1              running
 26    kubernetes-node-2              running
 27    kubernetes-node-3              running
 28    kubernetes-master              running

Master node:
root@bumblebee:/data/kubernetes# ssh<EMAIL_ADDRESS>Last login: Sat Jan 14 09:22:52 UTC 2017 from <IP_ADDRESS> on pts/0
Container Linux by CoreOS alpha (1284.2.0)

core@kubernetes-master ~ $ journalctl -u kubelet
-- No entries --

core@kubernetes-master ~ $ cat /etc/os-release
NAME="Container Linux by CoreOS"
ID=coreos
VERSION=1284.2.0
VERSION_ID=1284.2.0
BUILD_ID=2017-01-10-0545
PRETTY_NAME="Container Linux by CoreOS 1284.2.0 (Ladybug)"
ANSI_COLOR="38;5;75"
HOME_URL="https://coreos.com/"
BUG_REPORT_URL="https://github.com/coreos/bugs/issues"

core@kubernetes-master ~ $ systemctl list-unit-files | grep kube
opt-kubernetes.mount                   static
kube-addons.service                    disabled
kube-apiserver.service                 disabled
kube-controller-manager.service        disabled
kube-scheduler.service                 disabled

Config:
root@bumblebee:/data/kubernetes# cat ~/.kube/config
apiVersion: v1
clusters:
- cluster:
    certificate-authority-data: ...
    server: http://<IP_ADDRESS>:8080
  name: libvirt-coreos
contexts:
- context:
    cluster: libvirt-coreos
    user: libvirt-coreos
  name: libvirt-coreos
current-context: libvirt-coreos
kind: Config
preferences: {}
users:
- name: libvirt-coreos
  user:
    client-certificate-data: ...
    client-key-data: ...

I don't think I am missing anything obvious, any help would be appreciated.
Thanks

Sorry wrong repo duh...

@muteor, I'm following the same example. Were u able to get this working?

@catena I did https://github.com/kubernetes/kubernetes/pull/40274


 Smaller icons look much better without blurring

This PR also tries to keep the icons' aspect ratio so that icons don't look comedically stretched

Can you show screenshots before this change?

Sure, here are the same icons from before:

Thanks™


[frontend server] Compilation fails on flutter web but succeeds on macos

See original issue: https://github.com/flutter/flutter/issues/82637
Not sure if the error is in the frontend server or in the creation of flutter_ddc_sdk_sound.dill though.
Small repro in flutter:
import 'package:flutter/material.dart';

void main() {
  runApp(MaterialApp(home: Home()));
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Container(
        color: Colors.blue,
        child: Popup(),
      ),
    );
  }
}

class Popup extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Center(
      child: BackdropFilter(
        filter:
            ColorFilter.mode(Colors.black.withOpacity(0.55), BlendMode.darken),
        child: Container(
          width: 50,
          height: 50,
          color: Colors.red,
        ),
      ),
    );
  }
}

/cc @johnniwinther

The web sdk:
abstract class ColorFilter { { [...] }
class ImageFilter { [...]}

as defined here:
https://github.com/flutter/engine/blob/6c272cba3fee6bc687ff8c44780b1bb656bc20c0/lib/web_ui/lib/painting.dart#L350-L355
https://github.com/flutter/engine/blob/6c272cba3fee6bc687ff8c44780b1bb656bc20c0/lib/web_ui/lib/painting.dart#L399-L424
The vm sdk:
class ColorFilter implements ImageFilter { [...] }
abstract class ImageFilter { [...] }

as defined here:
https://github.com/flutter/engine/blob/6c272cba3fee6bc687ff8c44780b1bb656bc20c0/lib/ui/painting.dart#L2979
https://github.com/flutter/engine/blob/6c272cba3fee6bc687ff8c44780b1bb656bc20c0/lib/ui/painting.dart#L3214
So getting a The argument type 'ColorFilter' can't be assigned to the parameter type 'ImageFilter'. when compiling to web and not when compiling to the VM makes perfect sense. The platforms should probably be updated so they agree.

The good news is that except for stuff in dart:_internal, dart:ui having PlatformViewRegistry in the VM platform and not in the web platform and overlooking the supertype NativeFieldWrapperClass1 in the VM platform this appears to be the only such difference (output from script I just created):
Missing classes in lib dart:_internal
In second but not in first: [VMLibraryHooks, Lists, VMInternalsForTesting, ClassID]
Missing classes in lib dart:ui
In first but not in second: [PlatformViewRegistry]
Class(Vertices) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(PictureRecorder) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(Canvas) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(Picture) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(Scene) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(TransformEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(OffsetEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ClipRectEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ClipRRectEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ClipPathEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(OpacityEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ColorFilterEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ImageFilterEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(BackdropFilterEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ShaderMaskEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(PhysicalShapeEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(SceneBuilder) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(EngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(Shader) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(Gradient) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ColorFilter) in dart.ui from (2) has these extra supertypes: [ImageFilter (dart:ui)]
Class(Codec) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ImageShader) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ImmutableBuffer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ImageDescriptor) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(FragmentProgram) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(Path) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(StringAttribute) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(SpellOutStringAttribute) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(LocaleStringAttribute) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(SemanticsUpdateBuilder) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(SemanticsUpdate) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(Paragraph) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ParagraphBuilder) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]

The good news is that except for stuff in dart:_internal, dart:ui having PlatformViewRegistry in the VM platform and not in the web platform and overlooking the supertype NativeFieldWrapperClass1 in the VM platform this appears to be the only such difference (output from script I just created):
Missing classes in lib dart:_internal
In second but not in first: [VMLibraryHooks, Lists, VMInternalsForTesting, ClassID]
Missing classes in lib dart:ui
In first but not in second: [PlatformViewRegistry]
Class(Vertices) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(PictureRecorder) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(Canvas) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(Picture) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(Scene) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(TransformEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(OffsetEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ClipRectEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ClipRRectEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ClipPathEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(OpacityEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ColorFilterEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ImageFilterEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(BackdropFilterEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ShaderMaskEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(PhysicalShapeEngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(SceneBuilder) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(EngineLayer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(Shader) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(Gradient) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ColorFilter) in dart.ui from (2) has these extra supertypes: [ImageFilter (dart:ui)]
Class(Codec) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ImageShader) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ImmutableBuffer) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ImageDescriptor) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(FragmentProgram) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(Path) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(StringAttribute) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(SpellOutStringAttribute) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(LocaleStringAttribute) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(SemanticsUpdateBuilder) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(SemanticsUpdate) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(Paragraph) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]
Class(ParagraphBuilder) in dart.ui from (2) has these extra supertypes: [NativeFieldWrapperClass1 (dart:nativewrappers)]

Looks like the problem is in the flutter sdk, will reassign the original issue https://github.com/flutter/flutter/issues/82637 to flutter web team. Closing this as not related to dart sdk.


Remove back arrow and add a tooltip to editor logo

Related to: #13047

cc @urbanphes

love it.

Oooops 😅

@rubenmoya We're going to maintain the same behavior in both cases, using the tooltip.

So, just to be clear, tooltip without arrow in the layers/layer view, and arrow without tooltip in the dataset/show view, right?

hey @rubenmoya we never want the arrow :)
thanks dude


Re-write Rust SDK

This PR
Re-writes the OpenFeature Rust SDK based on the spec.
This PR brings the following major improvements compared to existing code:

A singleton of OpenFeature is implemented as per spec 1.1.1. The application author should call get_client to get an instance. No more manual creation.

EvaluationDetails and ResolutionsDetails has been refined to use enum to store the reason and error code, per spec.

Evaluation functions is now strongly typed. Meaning the user should call get_int_value to get an i64 value. This is required by the spec 1.3.1.

Evaluation functions get_xx_value becomes async as suggested by the spec 1.4.11.

Meaningful doc strings for public types and traits. Content selectively copied from the spec.

See Follow-up tasks for what has not been done.
Related Issues
Fixes:

#6
#12
#13

Notes
Why re-writing?
I tried to patch existing code but ended up re-writing it. The main reason was that too much code needed to be changed to make both spec and Rust compiler happy.
For example, the old resolution function takes a type parameter T: Clone that makes it non object safe, which breaks the requirements of singleton (lazy_static), async and more. The provider author can never put this T value in a cache because it has Clone constraint that implies Sized etc etc.
There are some other pain points and I cannot recall now. Still, the existing code inspired me in a lot of ways. Just I was a bit lazy to patch everything and re-writing would be easier.
Follow-up Tasks

Implement more evaluation functions get_xx_details.
Implement hooks as per #5.
Re-scan the spec and ensure everything is compliant.
Use Clippy to guarantee the code quality (by running some selective rules).
Address other issues in #9.

Hey @sheepduke, could you please sign off your commits? It's a requirement from the CNCNF before we can merge.
To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~12 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin main

I'm biased b/c I wrote this code, but you might like the pattern we used in the java-sdk where each test is annotated with a specification that it covers. It helps uncover which areas we're not covering yet.
https://github.com/open-feature/java-sdk/blob/main/src/test/java/dev/openfeature/sdk/FlagEvaluationSpecTest.java#L69

@justinabrahms My apologies. Your request changes have been overwritten by my force-update to resolve the signing issue. :-(
Could you please kindly re-request it, or let me know what have you changed?
I am rather curious that how did you add the specification to the tests.

The main thing we need to change is the renovate file being deleted.
As for spec tests, there's a python script in the repo which parses them and validates. Something for later, but you could probably make your life easier by commenting the relevant spec until we get something statically verifiable.

Thanks for sharing the info. I have added this JSON file back and created an issue to track it:
https://github.com/open-feature/rust-sdk/issues/16
I have re-requested your review. :-)

Ahh. Bit of confusion. I'll update the ticket. Renovate keeps our dependencies up to date. The json thing I mentioned was something else.


Support run puppeteer inside docker

Bug description
Hello,
I'm trying to run puppeteer inside a chromium instance on a Docker Container without success (I've provided the log outp).
The docker commands:
docker build --platform=linux/amd64 . -t  e2e-alpine
docker run -p 3000:3000 --platform linux/amd64 -it e2e-alpine
It builds and it runs. When I trigger the endpoint that calls the chrome launcher (code of the launcher below) it shows the error I've shared as well.
Any suggestion?
CODE
  const browser = await launch({
    headless: true,
    args: [
      "--window-size=1920,1080",
      "--window-position=1921,0",
      "--disable-gpu",
      "--disable-dev-shm-usage",
      "--disable-setuid-sandbox",
      "--no-sandbox",
    ],
    executablePath: "/usr/bin/chromium-browser",
  });

Package.json
{
  "name": "test-e2e",
  "version": "1.0.0",
  "description": "",
  "main": "teste2e.js",
  "type": "module",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1",
    "start": "node src/index.js"
  },
  "keywords": [],
  "author": "",
  "license": "ISC",
  "dependencies": {
    "body-parser": "^1.20.1",
    "dotenv": "^16.0.3",
    "express": "^4.18.2",
    "puppeteer-stream": "^2.1.1",
    "puppeteer":"19.3.0"
  }
}

DOCKERFILE
FROM alpine

RUN apk add --no-cache \
    chromium \
    nss \
    freetype \
    harfbuzz \
    ca-certificates \
    ttf-freefont \
    nodejs \
    yarn

ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true \
    PUPPETEER_EXECUTABLE_PATH=/usr/bin/chromium-browser

RUN apk add npm
RUN yarn config set PUPPETEER_SKIP_CHROMIUM_DOWNLOAD true
RUN yarn config set ignore-scripts true

ENV DEBIAN_FRONTEND noninteractive
WORKDIR /app
COPY package.json /app
COPY . /app
RUN yarn install
CMD ["yarn", "start"]

Puppeteer version
19.3.0
Node.js version
LTS
npm version
LTS
What operating system are you seeing the problem on?
Linux
Configuration file
No response
Relevant log output
/app/node_modules/puppeteer-stream/node_modules/puppeteer-core/lib/cjs/puppeteer/node/BrowserRunner.js:299
            reject(new Error([
                   ^

Error: Failed to launch the browser process!
qemu: uncaught target signal 5 (Trace/breakpoint trap) - core dumped
qemu: uncaught target signal 5 (Trace/breakpoint trap) - core dumped
[1127/174844.482648:ERROR:scoped_ptrace_attach.cc(27)] ptrace: Function not implemented (38)
Assertion failed: p_rcu_reader->depth != 0 (/qemu/include/qemu/rcu.h: rcu_read_unlock: 101)

TROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md

    at onClose (/app/node_modules/puppeteer-stream/node_modules/puppeteer-core/lib/cjs/puppeteer/node/BrowserRunner.js:299:20)
    at ChildProcess.<anonymous> (/app/node_modules/puppeteer-stream/node_modules/puppeteer-core/lib/cjs/puppeteer/node/BrowserRunner.js:290:24)
    at ChildProcess.emit (node:events:525:35)
    at ChildProcess._handle.onexit (node:internal/child_process:291:12)

Please see our guides on Docker: https://pptr.dev/guides/docker/

It still not covers running in docker. I pulled docker image into my Dockerfile and face absolutely same error while running on CI

@oleghalin Please see my comment, maybe it will suit you https://github.com/puppeteer/puppeteer/issues/7746#issuecomment-1333677725


Support mocking using constructor arguments

With regards to Mockito feature https://github.com/mockito/mockito/pull/935
I didn't see any way to use Mocking.mock that would allow me to specify the constructor to use.

Could you include an example use case?

Ah, I realize the useConstructor method has changed.


inconsistent Button-placement for multiple children

When adding multiple children to the button the placement is dependent of the order of the children.

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Same placement, independent from the order.
Current Behavior

Placement differs slightly. There is a problem with the inheriting display of the label. We could not inherit the display-prop (behavior like the html5-button-component).
Steps to Reproduce (for bugs)
https://codesandbox.io/s/y0vv1243w9
Context

I stumbled over that when working with custom icons implemented like the examples. (used Fontawesome5-icons, like in this sandbox).
Your Environment

Tech
Version

Material-UI
1.0.0-beta.25

React
16.2.0

browser
chrome 63.0.3239.108

Seems this is caused by the default ButtonBase.js style from this line:
https://github.com/mui-org/material-ui/blob/cccf34cd72ac8f63d43476dd8d837134dc8fc0e4/src/ButtonBase/ButtonBase.js#L13
Though I'm not sure this is something we should update here, as we can always override the default styling if needed, see this example: https://codesandbox.io/s/pwnm1n11p0 (where class button's display property is set to inline-block in this case).


Choices of the Eventarc channel location only propose one European region

Is your feature request related to a problem? Please describe.
As of now, when configuring the Eventarc channel location the only European region we can select is europe-west4.
However there are now numerous regions in Europe where Eventarc is available: https://cloud.google.com/eventarc/docs/locations#europe
Will it be possible to choose among those regions.
Describe the solution you'd like
Being able to choose among all available European regions
Describe alternatives you've considered
No response
Additional context
No response

Thanks for reporting this issue!
I'm not restricting regions or providing the list myself, it is done by Firebase itself. Have you seen other Eventarc regions in other extensions? Maybe they haven't opened those regions for Firebase Extensions yet?

Thank you for your response. The answer to your question "Have you seen other Eventarc regions in other extensions?" is "No". I'm going to open a ticket with Firebase support.


darwin-menu: Capitalize menu items to style match.

This capitalizes the menu items to be consistent with how all other
menu items are capitalized on almost all applications across Mac native
menus.

Merged. Thanks, @brockwhittaker.


⚠ Bofrost.de has degraded performance

In 8723039, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 2520 ms

Resolved: Bofrost.de performance has improved in 6048a74 after 10 minutes.


Use concurrent skiplist map for NettyRequest arguments

Summary
Map for header and query parameter in NettyRequest should be case-insensitive. Start using concurrent skiplist map with CASE_INSENSITIVE_ORDER from String.
Test
Added unit test

Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 15.94%. Comparing base (52ba813) to head (a5dba9c).
Report is 125 commits behind head on master.

Files with missing lines
Patch %
Lines

.../main/java/com/github/ambry/rest/NettyRequest.java
0.00%
1 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (52ba813) and HEAD (a5dba9c). Click for more details.
HEAD has 2 uploads less than BASE

Flag
BASE (52ba813)
HEAD (a5dba9c)

3
1

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2927       +/-   ##
=============================================
- Coverage     64.24%   15.94%   -48.31%
+ Complexity    10398     3044     -7354
=============================================
  Files           840      864       +24
  Lines         71755    73672     +1917
  Branches       8611     8866      +255
=============================================
- Hits          46099    11746    -34353
- Misses        23004    61081    +38077
+ Partials       2652      845     -1807

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


60 seconds execution time on an Electron app

Expected Behavior
Execution time is less than 1 second when no particular app is on desktop
Execution time is still less than 1 second when a particular app is on desktop
Actual Behavior
Execution time is less than 1 second when there is no particular app on desktop
Execution time is constantly 60 - 61 seconds for multiple runs on different machines when a particular app is on desktop
Steps to Reproduce the Problem

Open our app (an internal app that cannot be disclosed)
Execute pywinauto.Desktop(backend='uia').windows()
Wait

Short Example of Code to Demonstrate the Problem
pywinauto.Desktop(backend='uia').windows()
Specifications

Pywinauto version: 0.6.8, atspi branch
Python version and bitness: Python 3.7.7
Platform and OS: Windows 10 Pro, 20H2, 19042.928

More Details

I did a profiling on that line of code. And profiler tells that 60 seconds are spent on uia_element_info._get_elements() method and in that method there is a method call self._element.FindAll(tree_scope, cond) which relates to comtypes. I have read issue #256 and found the a FindFirst workaround of FindAll method. But my situation is different. I actually want all windows of the desktop, so I cannot use FindFirst strategy. Besides, when using pywinauto.Desktop(backend='uia').windows(), the tree scope is "children", so with only a few windows in desktop, it shouldn't take that long.
I also found that when that electron app is opened in the desktop, no matter how many of how few other apps' windows opened in the desktop, the execution time of that line of code stays constantly at 60 - 61 seconds.
When I have two windows of that particular app opened, the execution jumps to 120 - 121 seconds.
When that python file is executed, "Ctrl + C" doesn't exit the script execution. It still waits 60 seconds and then show Keyboard Interruption! (some process is blocking the script?)
While the script is being executed (or hanging), quitting that app immediately finishes the script execution. (also blocking?)
On some machine, only the first execution takes 60 s, and subsequent executions run very fast (less than 1 second). But on some other machine, every execution takes 60 s. (environment issue?)

Although it looks more like a problem on our app but not your project, I still want to get some helps or insights on debugging this issue. Any suggestion is appreciated!

Update: used this gist to find by title, however no luck. This call pywinauto.windows.uia_defines.IUIA().iuia.RawViewWalker.GetNextSiblingElement(self._element)  takes too long when it starts to get our electron app and failed with TimeoutError.


Compatibility with Catalina ?

Hi heestand,
Thanks for the fix regarding the swift version, it still won't build, here are the errors, I have linked to the source files:
Screenshot of the errors with permalinks to source files

https://github.com/heestand-xyz/PixelKit/blob/12d5c2c184d23d20db5fecc8438bc6e156a616ac/Source/PIX/PIXs/Effects/Multi/Blends/BlendsPIX.swift#L38

https://github.com/heestand-xyz/PixelKit/blob/12d5c2c184d23d20db5fecc8438bc6e156a616ac/Source/PIX/Extensions/ResultBuilders.swift#L11

https://github.com/heestand-xyz/PixelKit/blob/12d5c2c184d23d20db5fecc8438bc6e156a616ac/Source/PIX/PIXs/Effects/Single/Blur/BlurPIX.swift#L76

https://github.com/heestand-xyz/PixelKit/blob/12d5c2c184d23d20db5fecc8438bc6e156a616ac/Source/PIX/PX.swift#L146
And this that still tries to compile even with the safeguards (no idea how it's possible, I will thoroughly check my xcode project)

Sorry it's very ugly 😅, do you think it will be possible to remediate those issue to be compatible with an older SDK than Big Sur?
Thanks

Thanks for collecting the errors, I can take a look at them in the beginning of next week.

I've now added Swift 5.5 checks in the repo, so now it runs on Xcode 12.2.
The update is in tag 2.0.7. I hope it works with your setup.

Perfect thanks!
I will test it tomorrow

It works, playing with it I ❤  the idea.
I'm I right to assume that StateObject is interchangeable with ObservedObject?

Awesome! Yes, you can pass PIX objects via @ObservedObject and store them in @StateObject in SwiftUI.


Can not setup absolute paths

Tried to follow this guide https://github.com/alan2207/bulletproof-react/blob/master/docs/project-configuration.md#absolute-imports but it is not working for me.
I have jsconfig.json:
{
  "compilerOptions": {
    "baseUrl": ".",
    "paths": {
      "~/*": ["./*"]
    }
  }
}

however when i type import something from "~/ no suggestion appeared. An if i save like "~/somerealfile" i got compiler errors later
BTW, i have suggestions on @... like @babel, @storybook etc
asked on reddit might help

somehow started to work by itself https://www.reddit.com/r/vscode/comments/19f58lv/comment/kq97a1w/?context=3
Materials:
https://code.visualstudio.com/docs/languages/jsconfig
https://nextjs.org/docs/app/building-your-application/configuring/absolute-imports-and-module-aliases

jsconfig.json
{
    "compilerOptions": {
      "baseUrl": ".",
      "paths": {
        "~/components/*": ["./app/components/*"]
      }
    }
  }

Well, not working still.
The problem is in conflict between tsconfig and jsconfig. It is working, when i delete tsconfig and only use jsconfig.
However if i use only tsconfig the path suggestions not working
tried vscode settings:
"files.associations": {
    "*.jsx": "javascriptreact"
  },
  "javascript.suggest.paths": true,
  "typescript.suggest.paths": true,

without success

needed to include jsx in tsconfig.json:
"include": [
    "next-env.d.ts",
    ".next/types/**/*.ts",
    "**/*.ts",
    "**/*.tsx",
+  "**/*.js",
+  "**/*.jsx"


Test Mona Reactor

Test out mona reactor for walking up to an object and having it trigger an animation as an starter template

https://docs.monaverse.com/create/building-spaces/adding-interactivity/reactor-introduction

Reactor test on 4 legged robot model


ONVIF is not working

ONVIF is getting disabled on every reboot.

the issue is not happening on another device, so this has to be a device related issue.


Add datamodel-code-generator link in pydantic document site.

Question
@samuelcolvin
I want to add a link of datamodel-code-generator to the pydnatic document site.
Where should I put the link?
link:
https://github.com/koxudaxi/datamodel-code-generator
https://koxudaxi.github.io/datamodel-code-generator/
Related issues
https://github.com/samuelcolvin/pydantic/issues/643
https://github.com/samuelcolvin/pydantic/issues/1452

Yes, great.
I would put it under the pycharm plugin.
Maybe one day we'll need a new sub-menu with add-ons, plugins and extensions. But for now a new item in the main menu is fine.
Thanks so much.

@samuelcolvin
Thank you very much :smile:


hi

hi

Thanks for reporting - this issue is under review. This is a Microsoft Internal DevOps Bug ID # 432823

@liz551 Can you please provide more information if you have any feedback on any of the documents or this was the test issue created.

@liz551 As there was no response. We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


fix: Proactively trigger handler final cleanup when a migration fails

What this PR does
Currently, when a migration fails we signal the target pod to cleanup, and then we rely on a domain change event from the informer to unmount all the volumes (containerdisks, etc...).
If the domain was never created (just for example: using FuncTestForceLauncherMigrationFailureAnnotation), the virt-handler is informed of the stale client connection only once the watchdog timeout expires (30 seconds).
This delay can cause some tests to fail, for example "old finalized migrations should get garbage collected".
This can be avoided by re-enqueueing the vmi object when the handler is acknowledged
that the migration has failed.

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Release note

NONE

What this PR does
Currently, when a migration fails we signal the target pod to cleanup, and then we rely on a domain change event from the informer to unmount all the volumes (containerdisks, etc...). If the domain was never created (just for example: using FuncTestForceLauncherMigrationFailureAnnotation), the virt-handler is informed of the stale client connection only once the watchdog timeout expires (30 seconds).

Let me try to describe it little bit better. The problematic part is SignalTargetPodCleanup, here we need to distinguish 2 flows:

A domain is not yet detected on the target (The migration did not started)
A migration is already started / domain detected.

In the first case the virt-launcher straight panics. Therefore no event will be send to the handler causing it to wait for some other trigger to reconcile this launcher again.
In the second case the monitor exits and we wait for notification to happen (unclear if there is case where we don't send it) and then we kill the domain and wait again (this most likely produces event).

This delay can cause some tests to fail, for example "old finalized migrations should get garbage collected".

This is not merely a test fix imho, https://github.com/kubevirt/kubevirt/pull/5425 still could apply here with sufficient luck(well, the opposite).

/lgtm

@xpivarc @fossedihelm Hey folks, I have a few questions:

Does the purpose of the re-enqueue is to speed up the call to processVmCleanup?

Yes, and properly react to something that the handler already knows.

How does the suggested improvement affects tests stability?

Several failures have been observed regarding the test "old finalized migrations should get garbage collected".
Basically, there we expect target pod to move to Succeeded status in 10 seconds, but since the handler does not react fast it could happen that we reach the timeout before the watchdog timeout expires, and hence a failure.

IIUC the client connection is classified as stale in case the gRPC Ping() returns error, does it mean that calling the client connection close in processVmCleanup is redundant in such a case?

In this case I think yes

/retest

@acardace PTAL

/lgtm


support renaming (snake, pascal, etc) like serde/strum does

Thanks for raising this issue! I'm not quite sure how you'd want to use this - could you maybe give an example of the kind of code you'd like to be able to write, that you can't currently?


[storage] temporary fix for issue #11505

What's the long term plan?

What's the long term plan?

@jiacfan
Change the fields of AccessPolicy to optional in next major release.