[WIP] Adapt MKDocs to contain common styles and components for all Traefik Labs documentation sites

This is WIP

[ ] Add static CSS and JS
[ ] Add new Menu (according to design)

Pre-reqs to test this change:

Install Python 3 or higher

[DEV] Testing this change consists in:

On the theme directory:

Build the theme: npm run build;
Generate the binary: python3 setup.py sdist bdist_wheel;
Copy the whl file from the dist folder somewhere into the docs directory.

on the docs directory:

Update the requirements.txt to look like this, we are going to comment the theme lib, because we will install it manually below, this is a bit different from what we have today because the mkdocs is newer so it has other dependencies:

mkdocs>=1.1
pymdown-extensions>=7.0
mkdocs-bootswatch==1.0
# mkdocs-traefik-labs==6.1.7
mkdocs-markdownextradata-plugin==0.2.0
markdown-include==0.5.1
mkdocs-exclude==1.0.2
markdown>=3.2
mkdocs-material-extensions>=1.0

Update the Dockerfile to look like this:

# Latest requirements need this to build some plugins
FROM python:3.7-alpine

ENV PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/root/.local/bin

COPY requirements.txt /mkdocs/
WORKDIR /mkdocs
VOLUME /mkdocs

RUN apk --no-cache --no-progress add gcc musl-dev \
  && pip3 install --user -r requirements.txt

# Copy the binary manually so you can install it locally (for development purposes only)
COPY ./path/to/theme_binary-0.0.0-py3-none-any.whl /mkdocs/
# Install the theme locally
RUN pip3 install --user ./path/to/theme_binary-0.0.0-py3-none-any.whl

ℹ I think there will be better ways of testing this theme, but I couldn't find a better one for now

Once everything is working and you need to publish it:

Make sure you have an account at the Python Package Index (PS: I don't know if anyone can push versions there, as I was the one that pushed the first version with this name, we need to investigate that)
Go to the theme directory:

Build the static assets with npm run build
Generate the artifacts with python3 setup.py sdist bdist_wheel
Follow this guide to upload the assets to the Index.

[After Publish] Testing this change consists in:

on the docs directory:

Update the requirements.txt to look like this, here we need to set the theme lib to the one we will use, it will be downloaded from PyPi in the make image step (make serve also runs make image):

mkdocs>=1.1
pymdown-extensions>=7.0
mkdocs-bootswatch==1.0
mkdocs-traefik-labs==<version-you-want-to-use>
mkdocs-markdownextradata-plugin==0.2.0
markdown-include==0.5.1
mkdocs-exclude==1.0.2
markdown>=3.2
mkdocs-material-extensions>=1.0

Update the Dockerfile to look like this:

# Latest requirements need this to build some plugins
FROM python:3.7-alpine

ENV PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/root/.local/bin

COPY requirements.txt /mkdocs/
WORKDIR /mkdocs
VOLUME /mkdocs

RUN apk --no-cache --no-progress add gcc musl-dev \
  && pip3 install --user -r requirements.txt

Closing this in favor of #2.

Closing this in favor of #2.


Refactor newPointHeap

Simple refactoring based on PR feedback.  No new code, mostly just deleting unnecessary code based on refactor.

+1


“The method 'cast' was called on null” during transaction.update

Steps to Reproduce

Perform an update using transaction.update, see code sample below. Following coding sample from https://www.youtube.com/watch?v=DqJ_KjFzL9I
Run in emulator
Trigger onTap event for update
UX and Firestore update successfully, but error is thrown anyway
NOTE: exact same code and setup DOES NOT throw an error on 0.9.6 but DOES on any subsequent releases. I have created a question in stackoverflow and it seems others are running into the same issue (https://stackoverflow.com/questions/55464038/how-to-fix-the-method-cast-was-called-on-null-during-transaction-update)

import 'package:cloud_firestore/cloud_firestore.dart';
import 'package:flutter/material.dart';

class TodoListWidget extends StatelessWidget {

  TodoListWidget({this.firestore});

  final Firestore firestore;

  @override
  Widget build(BuildContext context) {
    return StreamBuilder<QuerySnapshot>(
      stream: firestore.collection('todo').snapshots(),
      builder: (BuildContext context, AsyncSnapshot<QuerySnapshot> snapshot) {
        if (!snapshot.hasData) return const Text('Loading...');
        final int messageCount = snapshot.data.documents.length;
        return ListView.builder(
          itemCount: messageCount,
          itemBuilder: (_, int index) {
            final DocumentSnapshot document = snapshot.data.documents[index];
            return ListTile(
              title: Text(document['subject'] ?? '<No subject retrieved>'),
              trailing: Text(document['completed']?.toString() ?? '<No completed retrieved>'),
              onTap: () => Firestore.instance.runTransaction((Transaction transaction) async {
                final DocumentSnapshot freshSnapshot = await transaction.get(document.reference);

                await transaction.update(freshSnapshot.reference, {
                  'completed': !freshSnapshot.data['completed'],});
              }),

            );
          },
        );
      },
    );
  }
}

Logs

flutter run --verbose
flutter-run-verbose.txt

flutter analyze
Analyzing maas_app...

   info • Unused import: 'package:maas_app/model/rank.dart' • lib/model/user.dart:2:8 • unused_import
   info • Unused import: 'dart:async' • lib/pages/home_page.dart:3:8 • unused_import
   info • Unused import: 'package:maas_app/widgets/rank_list_widget.dart' • lib/pages/home_page.dart:6:8 •
          unused_import
   info • Unused import: 'package:maas_app/widgets/user_list_widget.dart' • lib/pages/home_page.dart:8:8 •
          unused_import
   info • The method '_updateTodo' isn't used • lib/pages/home_page.dart:115:3 • unused_element
   info • The method '_deleteTodo' isn't used • lib/pages/home_page.dart:123:3 • unused_element
   info • The method '_showTodoList' isn't used • lib/pages/home_page.dart:167:10 • unused_element
   info • Unused import: 'package:maas_app/model/rank.dart' • lib/widgets/user_list_widget.dart:3:8 •
          unused_import

8 issues found. (ran in 3.9s)

flutter doctor -v

Williams-MacBook-Pro:maas_app wready$ flutter doctor -v
[✓] Flutter (Channel stable, v1.2.1, on Mac OS X 10.14.4 18E226, locale en-US)
    • Flutter version 1.2.1 at /Users/wready/dev_tools/flutter
    • Framework revision 8661d8aecd (7 weeks ago), 2019-02-14 19:19:53 -0800
    • Engine revision 3757390fa4
    • Dart version 2.1.2 (build 2.1.2-dev.0.0 0a7dcf17eb)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/wready/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = /Users/wready/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.2, Build version 10E125
    • ios-deploy 1.9.4
    • CocoaPods version 1.6.1

[✓] Android Studio (version 3.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 33.4.1
    • Dart plugin version 182.5215
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[✓] Connected device (1 available)
    • iPhone Xʀ • 6FF03A48-8AE5-41B1-ABD6-8C60CF29F642 • ios • com.apple.CoreSimulator.SimRuntime.iOS-12-2
      (simulator)

• No issues found!

I experience the same error as well. It occurs on transaction set, delete, and update for me.

Hi,
Firebase has a new home here https://github.com/FirebaseExtended/flutterfire please raise there a new issue and reference this one.
Thanks


v2.13

https://github.com/redouane59/twittered/pull/328
https://github.com/redouane59/twittered/pull/324
https://github.com/redouane59/twittered/pull/331

I'd appreciate if this would get merged soon, otherwise the OAuth flow is broken. Thanks for fixing this though!

I'd appreciate if this would get merged and published soon, otherwise the OAuth flow is broken because of #328. Thanks for fixing this though!

Hey @steebchen , I would like to wait for @PhantomYdn to solve https://github.com/redouane59/twittered/issues/326 before releasing this new version. But if during this week-end he doesn't have time to implement it, I will release this version without this feature.

Maybe would make more sense to release now with the fix and then put #326 into the next version. That's just my 2 cents though, don't want to infere too much with your planning. I'd just appreciate if I can upgrade to the newer version to the bugfix for oauth :)

Maybe would make more sense to release now with the fix and then put #326 into the next version. That's just my 2 cents though, don't want to infere too much with your planning. I'd just appreciate if I can upgrade to the newer version to the bugfix for oauth :)

Done :)

Thanks so much! This helps us a lot in our project :)

You're welcome !


fix: Add actor information to event data

Description

Adds actor information to the event data documentation

Testing required outside of automated testing?

[ ] Not Applicable

Screenshots (if appropriate):

[ ] Not Applicable

Rollback / Rollforward Procedure

[ ] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This issue has been resolved in version 1.177.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Could not find types for ____ Future versions of sanity-codegen will allow you to type them separately

Currently if SanityCodegen finds a reference type that isn't used anywhere, it'll create an empty interface. A typical example of this happening is when using a sanity plugin that defines a new type such as the sanity code input plugin.
This solution works but I think there's room for improvement. Please leave suggestions!

Maybe we could have a method to manually config or point to the the correct typings inside the sanity-codegent.config.ts?
eg the autocomplete-tags creates a tags
currently the code gen returns
Could not find types for: "Tags". Ensure they are present in your schema. Future versions of sanity-codegen will allow you to type them separately.
[SanityCodeGen]: types written out to ~/studio/schema.d.ts)

// interface Tags = {}

so maybe instead we could define the tags to tell the codegen that the tags have been manually defined
import { SanityCodegenConfig } from 'sanity-codegen'

const config: SanityCodegenConfig = {
  schemaPath: './app/schema.ts',
  outputPath: './schema.d.ts',
  overrideTypes:{
    Tags:"./tags.d.ts" // unsure if there is better method of doing it here?
  }
}

Maybe we could have a method to manually config or point to the the correct typings inside the sanity-codegent.config.ts?
eg the autocomplete-tags creates a tags
currently the code gen returns
Could not find types for: "Tags". Ensure they are present in your schema. Future versions of sanity-codegen will allow you to type them separately.
[SanityCodeGen]: types written out to ~/studio/schema.d.ts)

// interface Tags = {}

so maybe instead we could define the tags to tell the codegen that the tags have been manually defined
import { SanityCodegenConfig } from 'sanity-codegen'

const config: SanityCodegenConfig = {
  schemaPath: './app/schema.ts',
  outputPath: './schema.d.ts',
  overrideTypes:{
    Tags:"./tags.d.ts" // unsure if there is better method of doing it here?
  }
}

I'm able to work around this by defining these types in a sanity-custom.d.ts:
/// <reference types="@sanity-codegen/types" />

declare namespace Sanity {
  namespace Schema {
    interface Code extends Sanity.Document {
      _type: 'code';
      filename?: string;
      code?: string;
      syntax: string;
    }
  }
}

Then, in my generated-sanity.d.ts file, it knows what Sanity.Schema.Code is :)

@good-idea Just wondering if you are still using this method as I've attempted to do the same today and am not having much luck so far. I'm using sanity-plugin-tags and trying to type the simple records it returns (an array of objects with keys of value and label).
My generated schema.d.ts file contains these document and field schemas (simplified for clarity):
export interface CaseStudy extends SanityDocument {
  _type: "caseStudy";

  /**
   * Technology tags — `technologyTags`
   *
   *
   */
  technologyTags?: TechnologyTags;
}

export type TechnologyTags = Tags;

/**
 * This interface is a stub. It was referenced in your sanity schema but
 * the definition was not actually found. Future versions of
 * sanity-codegen will let you type this explicity.
 */
type Tags = any;

In the same directory as the generated schema.d.ts file, I have added schema-custom.d.ts with the following contents based on your reply above:
/// <reference types="@sanity-codegen/types" />
declare namespace Sanity {
    namespace Schema {
        export type Tag = {
            label: string;
            value: string;
        }

        export type Tags = Tag[];
    }
}

Perhaps expecting this to "just work" is a bit optimistic but I'm new to Typescript (and VSCode, the editor I'm using) so unsure what else I need to do to make this work – in any case, as it stands, the technologyTags field of my caseStudy document still comes out as any.
Do I need to add some sort of import/reference from the generated file to the custom one, or vice-versa? Or am I causing problems declaring inside a namespace in the custom file, when the generated one doesn't (as far as I can tell) use a namespace?
@ricokahler If you have any inside info in this regard, it would be welcome!
Any tips on getting this over the line would be very much appreciated!

Just realised that the solution above must be using the alpha branch since the stable branch doesn't use namespaces. At the moment I'm importing from the generated defs file and manually overriding with custom types, but still looking for a more elegant solution...


Deprecate node 0.X support

In the future it would be good to stop testing against these old versions (in the CI). This allows the removal of the user-home dependency which is stuck in version 1.1.1 and replace it with the native os.homedir function. Other than that there's not much of a benefit.

This would be far-future (like 2018+) but I don't think it's necessary for 1 platform feature.  I'll also be switching out the library for a different one so it isn't "stuck".

fwiw I think one of our projects had issues with user-home (cc @doowb).  might be worth considering homedir-polyfill

Yeah, homedir-polyfill was designed specifically for supporting older versions of node that don't have os.homedir. I went through the implementation in libuv to ensure the logic was as close to the same as possible and uses os.homedir if it's available. We've been using it for a while now and I don't recall any issues.

As of node 10.10, the allowedNodeEnvironmentFlags global is available so there will be no need for this module in the future.  This will continue to live on for older node versions but I'm going to close this.


feat: Update to v7 JavaScript SDKs

This PR:

Keeps up to date with v7 (which is currently in beta) so it's not a huge jump
Ensures the underlying SDKs support all the features required in the Electron SDK

This is now waiting on this PR and a release so I can attach the minidumps to events!

The tracing test failure is blocked by this getting into a release


Comma separated selector doesn't return elements in DOM order

Hi there,
Great library — appreciate the effort on this.
I'm running into a small issue where the order of selectors determines the order of the returned nodes. e.g;
$dom->find( 'h1,h2,h3,h4,h5,h6' )
Unexpectedly returns all
 tags, then
 tag, and so on.
I have a document where the dom nodes are ordered such as:

I need to get all header tags in the order they appear in the DOM but instead I'm getting h1, h2, h2, h2, h3.
Is there perhaps something I'm doing wrong on my end or is this a bug?
Cheers,
Phil

So I've just resorted to the following as a workaround in case anyone else comes across this:
$headings = $dom->find( 'h1,h2,h3,h4,h5,h6' )->toArray();
usort( $headings, function ( $a, $b ) {
    return ( $a->id() < $b->id() ) ? - 1 : 1;
} );

So I've just resorted to the following as a workaround in case anyone else comes across this:
$headings = $dom->find( 'h1,h2,h3,h4,h5,h6' )->toArray();
usort( $headings, function ( $a, $b ) {
    return ( $a->id() < $b->id() ) ? - 1 : 1;
} );


DEV 8587.2 Reduce the time for which Admiral checks whether RabbitMQ service is up from 180 to 30 seconds, if Admiral is installing RabbitMQ on the same machine as Admiral.

https://github.com/Shippable/pm/issues/8587

this is done, closing


Jitpack compatibility & coroutine fix

Drop Gradle until Jitpack supports 7.4.0
Make sure loggingCoroutineScope is included in FileLoggerTree initializer.

Many thanks for fixing the build!


cache dubbo provider version

// Describe your PR here; eg. Fixes #issueNo
fix #1381 the no.2 question
cache dubbo version and update dubbo plugin test case
Make sure that:

[x] You have read the contribution guidelines.
[x] You submit test cases (unit or integration tests) that back your changes.
[x] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #1453 (7f02223) into master (5e4ca6a) will decrease coverage by 2.81%.
The diff coverage is 75.30%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b68b4...7f02223. Read the comment docs.


Mapster fail to use user-defined explicit or implicit conversion operators from target type

From this SO question.
Given the type Id:
public class Id
{
    private readonly Guid _guid;

    public Id(Guid id) => _guid = id;

    public static implicit operator Id(Guid value) => new(value);
    public static implicit operator Guid(Id value) => value._guid;

    public override string ToString() => _guid.ToString();
}

Despite the implicit conversion Mapster fail to map a Guid to an Id:
public class PocoWithGuid
{
    public Guid Id { get; init; }
}

public class PocoWithId
{
    public Id Id { get; init; }
}

var guid = Guid.NewGuid();

var pocoWithGuid1 = new PocoWithGuid { Id = guid };
Console.WriteLine(pocoWithGuid1.Id);    // 9c29424a-3c7b-4982-b301-84cc7ac41bc6

// Guid to Id fail
var pocoWithId1 = pocoWithGuid1.Adapt<PocoWithId>();
Console.WriteLine(pocoWithId1.Id);      // 00000000-0000-0000-0000-000000000000

var pocoWithId2 = new PocoWithId { Id = new Id(guid) };
Console.WriteLine(pocoWithId2.Id);      // 9c29424a-3c7b-4982-b301-84cc7ac41bc6

// Id to Guid works
var pocoWithGuid2 = pocoWithId2.Adapt<PocoWithGuid>();
Console.WriteLine(pocoWithGuid2.Id);    // 9c29424a-3c7b-4982-b301-84cc7ac41bc6

Demo code available here.

@Orace Which version of Mapster are you using?

@andrerav, the last one available on NuGet: 7.3.0

Could you try the latest prerelease please?

@Orace  @andrerav
This is #537
Id Detect as Record
adapt Guid to Id is Not possible

Could you try the latest prerelease please?

@andrerav, It fails with 7.4.0 too.


Android-Required label appears when create request even People must tag expenses is disabled

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.46-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Precondition:

User is an employee of Collect workspace on Old Dot
"People must tag expenses" option is disabled by Admin

As employee navigate to Workspace chat> +> Request money> Manual
Add amount> Click Next
Take a note of Final confirmation page

Expected Result:
Since Admin has disable "People must tag expenses" option - Employee should not see Required label on Tag section
Actual Result:
"Required" label is present on Tag section when Employee create request, even "People must tag expenses" is disabled by admin
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/73fb1d75-74a3-49c4-9624-b5ac675bb7dd
View all open jobs on GitHub

We think that this bug might be related to #wave6
CC @greg-schroeder

I'm unable to repro, I'm thinking it might have been a delayed notification being sent to the Android client after you disabled the tag requirement in the workspace on OldDot. The code for that page also hasn't changed in a while.
https://github.com/Expensify/App/assets/2229301/f4d9afc1-8255-408c-884f-51449adb45c2

Can't repro on v1.4.47-6 either, closing for now.


Add an if statement

It'd be great to have an if statement so decisions can be made - I have a use case where I need to decide whether to return the current object or one of its children based on some information in that object. I guess the standard Haskell syntax of if ... then ... else ... would would well, or a bool function (not sure if the Data.Bool catamorphism order of arguments is the most logical here, bool cond truecase falsecase feels like it'd be more familiar.)

There's support for that, but looks like I didn't document it in the readme!
$ echo '{"1":1, "a":2}' | jl '\x->if x.1 = 1 then "yay" else "boo"'
"yay"

Added docs to the README.

Fantastic, thanks Chris!


Compose.yaml edits won't save

⚠ Please verify that this bug has NOT been reported before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
Trying to edit container name. When I click Save I get:

👟 Reproduction steps
Edit any compose file and click Save.

👀 Expected behavior
No error
😓 Actual Behavior

Here is my compose.yaml
services:
  dockge:
    image: louislam/dockge:latest
    restart: unless-stopped
    container_name: dockge
    cap_drop:
      - ALL
    security_opt:
      - no-new-privileges=true
    environment:
      # Tell Dockge where is your stacks directory
      - DOCKGE_STACKS_DIR=/opt/stacks # this is the container side
    network_mode: bridge
    ports:
      - "5001:5001"
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
      - data:/app/data
      - /home/me/stacks:/opt/stacks
volumes:
    data:

Dockge Version
1.4.2
💻 Operating System and Arch
Debian 12
🌐 Browser
LibreWolf 133.0.3-1
🐋 Docker Version
27.4.1
🟩 NodeJS Version
No response
📝 Relevant log output
dockge  | 2024-12-26T22:20:31Z [SERVER] INFO: Welcome to dockge!
dockge  | 2024-12-26T22:20:31Z [SERVER] INFO: NODE_ENV: production
dockge  | 2024-12-26T22:20:31Z [SERVER] INFO: Server Type: HTTP
dockge  | 2024-12-26T22:20:31Z [SERVER] INFO: Data Dir: ./data/
dockge  | 2024-12-26T22:20:31Z [DB] INFO: Database Type: sqlite
dockge  | 2024-12-26T22:20:31Z [SERVER] INFO: Connected to the database
dockge  | 2024-12-26T22:20:31Z [SERVER] INFO: Listening on 5001
dockge  | 2024-12-26T22:20:33Z [AUTH] INFO: Origin is not set, IP: ::ffff:<IP_ADDRESS>
dockge  | 2024-12-26T22:20:34Z [SERVER] INFO: Socket connected (direct)
dockge  | 2024-12-26T22:20:34Z [AUTH] INFO: Disabled Auth: auto login to admin

It seems the CAP DROP ALL is the issue leading to:
dockge  | 2024-12-27T01:01:38Z [DB] INFO: Database Type: sqlite
dockge  | 2024-12-27T01:01:38Z [SERVER] INFO: Connected to the database
dockge  | Can't take lock to run migrations: update `knex_migrations_lock` set `is_locked` = 1 where `is_locked` = 0 - SQLITE_READONLY: attempt to write a readonly database
dockge  | If you are sure migrations are not running you can release the lock manually by running 'knex migrate:unlock'
dockge  | 2024-12-27T01:01:38Z [DB] ERROR: Database migration failed
dockge  | 2024-12-27T01:01:38Z [SERVER] ERROR: Failed to prepare your database: update `knex_migrations_lock` set `is_locked` = 1 where `is_locked` = 0 - SQLITE_READONLY: attempt to write a readonly database
dockge exited with code 0

Open to suggestions on specific CAP ADD to resolve this. Thank you.


add to cart button completed

This pull request is for :- "ADD TO CART" BUTTON DESIGN #207

I am interested in working on this issue under Hacktoberfest 2023. Kindly assign this issue to me.
@NtemKenyor


Missing fields in PackageRecord

PackageRecord contains exposes alot of data related to the package, it currently does not expose any of these fields. For users of library I would be really nice to be able to access them. It is also missing methods to initialize a PackageRecord.

Closed by #406


Add benchmark for IcebergSplitReader

Fixes https://github.com/facebookincubator/velox/issues/8754
Benchmark results: https://gist.github.com/agrawalreetika/1b8a7c8bfd4fa3645661d37411189a0c

@agrawalreetika Some build failure: https://github.com/facebookincubator/velox/actions/runs/9219989514/job/25617117781?pr=9849

@yingsu00 As discussed, I have moved the benchmark from Parquet to dwrf format.
While re-runing the benchmark, I observed when readBatchSize>=10k position delete data is not getting filtered and the expected result is not matching in those cases.

@Yuhta Could you please try to import the PR now? It's building fine on my local Mac with the same build options. Now I did rebase it to latest to check if that was causing some issue.

@agrawalreetika There is build error: https://github.com/facebookincubator/velox/actions/runs/9547363706/job/26329689337?pr=9849

@Yuhta Could you please let me know, why builds are not getting triggered automatically on this PR? As I see here it says its waiting for approval from a maintainer.

@agrawalreetika It needs approval if it is your first PR on this repo

I tried the Ubuntu build on my machine, It went fine. @Yuhta Could you please approve the build now on this?


fix(web): don't inject route outside of createStore

useRoute cannot be used outside of a Vue component (it's enough to put it inside of the createStore). Quiet the warning about inject in the wrong context.

@britmyerss not entirely sure of the behavior so you might want to click test this one

bors r+


Multi-Select + Autocomplete

I know you already have a component for typeahead, and for selection, but I found I needed to combine the two, so I built a component that mixes both to create a sort of "Tag" interface.

If you'd accept a PR, I can convert into re-com style hoc
https://gist.github.com/Conaws/0c191c29f9e9f3781efa4b3535d28e7f # # #

Looks terrific.  We'd love a PR

@Conaws any update on this?

I had some trouble getting figwheel running on the latest master branch -- so hesitant to push a pr, but I updated the gist and added all the relevant css classes, so if you're cool passing in an option map rather than using the re-com style options you can copy the code from here
https://gist.github.com/Conaws/0c191c29f9e9f3781efa4b3535d28e7f

As of 2.12.0 both a multi-select and tag-dropdown component have been added, which while not identical to the above example I believe should cover all the same use cases.

As of 2.12.0 both a multi-select and tag-dropdown component have been added, which while not identical to the above example I believe should cover all the same use cases.


fix: forced reset and clear command not working due to excess whitespaces

fix: forced reset and clear command not working due to excess whitespaces

Codecov Report

Merging #263 (1f41664) into master (06d852c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #263   +/-   ##
=========================================
  Coverage     74.79%   74.79%
  Complexity      573      573
=========================================
  Files            83       83
  Lines          1956     1956
  Branches        183      183
=========================================
  Hits           1463     1463
  Misses          435      435
  Partials         58       58

Impacted Files
Coverage Δ

...seedu/address/logic/parser/ClearCommandParser.java
71.42% <100.00%> (ø)

...seedu/address/logic/parser/ResetCommandParser.java
71.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06d852c...1f41664. Read the comment docs.


[feature] duration in the past and future

Can I implement duration in the past as an additional option? @EvanHahn
I will add an extra option for the feature for both the past and future. While calling the function, the option will be like that:
options = {
  ...
  adverb_of_time: true
}

Then I will add extra keys for the past and future according to languages as shown below.
dictionary = {
  ...
  en: {
    ...
    past: "in %s",
    future: "%s ago"
  }
  ...
}

@EvanHahn. Thank you for your response. I completed the feature. You can check the file and commits using the GitHub fork repo here.
The example codes below the timeAdverb title. Also, I added a code snippet for testing in test/humanizer.js

Thanks. I'll take a look at this.

Added it to the readme in 6afef107949bea4fc6edf5b2b0cd91cbbc646a3c.
Thanks!


Revert "Merge pull request #1261 from default0/explicit-flow-order"

This reverts commit d5bdf96a887646be92e670bd30fd4cda4c588718.
Easiest path forward for now, there are a lot of osu!-side changes to be done.

@default0 can you please re-open a PR for this so we can reconsider it in more detail?


Attempt to optimize Zulip import performance with lazy loading

This is work on #9953.  @andersk can you try doing your flame graph on top of this branch?  I'm curious what replaces the python-twitter and apns imports.
(You can use tools/fetch-rebase-pull-request <PRID> to check this out)

http://web.mit.edu/andersk/Public/zulip/manage-py-10233.svg

The first commit was merged, and I'm not sure whether the second one is useful, so closing.


Migrate generated Svelte icons from SvelteComponentTyped to SvelteComponent

Prerequisites

Version: 0.268.0
Are you running from source/main: no
Are you using a released build: yes
Operating system: macOS 12.6.5
Bits: 64-bit

Step to reproduce

Try to copy an existing icon's base type definition:
import type { SvelteComponentTyped } from 'svelte';
import { type IconProps, type IconEvents, Link2Icon } from 'lucide-svelte';

const data: { example: string, icon: SvelteComponentTyped<IconProps, IconEvents, {}>, /* ... */ }[] = [
  { example: 'abc', icon: Link2Icon }, /* ... */
]

Note the deprecation from SvelteComponentTyped, with the following message:

@deprecated Use SvelteComponent instead. See PR for more information: https://github.com/sveltejs/svelte/pull/8512

Attempt to use SvelteComponent instead:
-import type { SvelteComponentTyped } from 'svelte';
+import type { SvelteComponent } from 'svelte';
-{ example: string, icon: SvelteComponentTyped<IconProps, IconEvents, {}>, /* ... */ }
+{ example: string, icon: SvelteComponent<IconProps, IconEvents, {}>, /* ... */ }

Actual behavior
A TypeScript error is outputted as a result of performing step 3.
Any message or error

Type 'typeof Link2Icon' is missing the following properties from type 'SvelteComponent<IconProps, IconEvents, {}>': $$prop_def, $$events_def, $$slot_def, $capture_state, and 6 more.ts(2740)

Resources

Migration guide

EDIT: I see that this was noted here as well: https://github.com/lucide-icons/lucide/pull/1388#issuecomment-1605775698

On an unrelated note, could a TypeScript type that all icons can extend from be added as well? Perhaps something like the following:
export type LucideIconComponent = SvelteComponent<IconProps, IconEvents, {}>;

On second thought, the same error also appears to happen with SvelteComponentTyped

Thanks for reporting!


Add Trinsic implementation

Adds implementation reference for Trinsic

Test Suite Results
eddsa-2022 (create)
  Data Integrity (issuer)
    Trinsic
      ✓ "proof" field MUST exist at top-level of data object.
      ✓ if "proof.id" field exists, it MUST be a valid URL.
      ✓ "proof.type" field MUST exist and be a string.
      ✓ "proof.type" field MUST be "DataIntegrityProof".
      ✓ "proof.cryptosuite" field MUST exist and be a string.
      ✓ "proof.created" field MUST exist and be a valid XMLSCHEMA-11 datetime value.
      ✓ "proof.verificationMethod" field MUST exist and be a valid URL.
      ✓ "proof.proofPurpose" field MUST exist and be a string.
      ✓ "proof.proofValue" field MUST exist and be a string.
      ✓ The "proof.proofValue" field MUST be a multibase-encoded base58-btc encoded value.
      ✓ if "proof.domain" field exists, it MUST be a string.
      ✓ if "proof.challenge" field exists, it MUST be a string.
      ✓ if "proof.previousProof" field exists, it MUST be a string.
  eddsa-2022 (issuer)
    Trinsic
      ✓ The field "cryptosuite" MUST be `eddsa-2022`
      ✓ "proofValue" field when decoded to raw bytes, MUST be 64 bytes in length if the associated public key is 32 bytes or 114 bytes in length if the public key is 57 bytes.
      ✓ "proof" MUST verify when using a conformant verifier.
eddsa-2022 (verify)
  Data Integrity (verifier)
    Trinsic
      ✓ If the "proof" field is missing, a "MALFORMED_PROOF_ERROR" MUST be raised.
      ✓ If the "proof" field is invalid, a "MALFORMED_PROOF_ERROR" MUST be raised.
      ✓ If the "proof.type" field is missing, a "MALFORMED_PROOF_ERROR" MUST be raised.
      ✓ If the "proof.type" field is not the string "DataIntegrityProof", an "INVALID_PROOF_CONFIGURATION" error MUST be raised.
      ✓ If the "proof.verificationMethod" field is missing, a "MALFORMED_PROOF_ERROR" MUST be raised.
      ✓ If the "proof.verificationMethod" field is invalid, a "MALFORMED_PROOF_ERROR" MUST be raised.
      ✓ If the "proof.proofPurpose" field is missing, a "MALFORMED_PROOF_ERROR" MUST be raised.
      ✓ If the "proof.proofPurpose" field is invalid, a  "MALFORMED_PROOF_ERROR" MUST be raised.
      ✓ If the "proof.proofPurpose" value does not match "options.expectedProofPurpose", a "MISMATCHED_PROOF_PURPOSE_ERROR" MUST be raised.
      ✓ If the "proof.proofValue" field is missing, a "MALFORMED_PROOF_ERROR" MUST be raised.
      ✓ If the "proof.proofValue" field is invalid, a "MALFORMED_PROOF_ERROR" MUST be raised.
      ✓ If the "proof.created" field is missing, a "MALFORMED_PROOF_ERROR" MUST be raised.
      ✓ If the "proof.created" field is invalid, a "MALFORMED_PROOF_ERROR" MUST be raised.
      ✓ If the "proof.proofValue" field is not a multibase-encoded base58-btc value, an "INVALID_PROOF_VALUE" error MUST be raised.
      ✓ If the "options.domain" is set and it does not match "proof.domain", an "INVALID_DOMAIN_ERROR" MUST be raised.
      ✓ If the "options.challenge" is set and it does not match "proof.challenge", an "INVALID_CHALLENGE_ERROR" MUST be raised.
  eddsa-2022 cryptosuite (verifier)
    Trinsic
      ✓ MUST verify a valid VC with an eddsa-2022 proof
      ✓ If the "proofValue" field, when decoded to raw bytes, is not 64 bytes in length if the associated public key is 32 bytes in length, or 114 bytes in length if the public key is 57 bytes in length, an INVALID_PROOF_LENGTH error MUST be returned.
      ✓ If a canonicalization algorithm other than URDNA2015 is used, a INVALID_PROOF_VALUE error MUST be returned.
      ✓ If a canonicalization data hashing other than algorithm SHA-2-256 is used, a INVALID_PROOF_VALUE error MUST be returned.
      ✓ If the "cryptosuite" field is not the string "eddsa-2022", an INVALID_PROOF_CONFIGURATION error MUST be returned.
eddsa-2022 (interop)
  ✓ Trinsic should verify Trinsic

Tests passed 38/38 100%
Tests failed 0/38 0%
Failures 0
Tests skipped 0
Total tests 38

@tmarkovski Some of the verifier and interop tests are failing for Trinsic. The problem seems to be that the value for proof.verificationMethod in the Trinsic issued VC contains a distorted hash fragment. This is what it looks like:
{
  "@context": [
    "https://www.w3.org/2018/credentials/v1",
    "https://w3id.org/security/data-integrity/v1"
  ],
  "id": "urn:uuid:a97efacb-b22b-41a6-b6a6-09a653d1b477",
  "type": [
    "VerifiableCredential"
  ],
  "issuer": "https://trinsic.id",
  "issuanceDate": "2020-03-16T22:37:26.544Z",
  "credentialSubject": {
    "id": "did:key:z6MktKwz7Ge1Yxzr4JHavN33wiwa8y81QdcMRLXQsrH9T53b"
  },
  "proof": {
    "type": "DataIntegrityProof",
    "created": "2023-08-11T20:58:28.6438842Z",
    "proofPurpose": "assertionMethod",
    "verificationMethod": "did:key:z6MkqbpLSbqnY1pxVyhBCDYcFsv4ZgGgqP32kzNrf5deWVPU#0��A\u001a�]\u0012�u��`\u0003�8k���\ri��\t6L��P�",
    "cryptosuite": "eddsa-2022",
    "proofValue": "z2ocoVJhukv2UpAUHzHxH9jGPxtBBWoJgtw2cESssF5vzzHsvo8N9PvGRrfvhsDi9X9fvcUeDadHbF3CaqnEDFuFx"
  }
}

@JSAssassin Thanks for the in-depth check. Do you ming sharing how you reproduce this? I'm running the eddsa-2022 tests against as is, and unable to get this result.

@JSAssassin Nevermind. It turns out my latest changes never made it to our prod environment.
The tests are passing against prod now, and that includes the test credential you mentioned.

POST /credentials/verify
curl --location 'https://interop.localhost:7266/vc-api/credentials/verify' \
--header 'Content-Type: application/json' \
--data-raw '{
  "verifiableCredential": {
    "@context": [
      "https://www.w3.org/2018/credentials/v1"
    ],
    "id": "urn:uuid:1f276d06-af06-431d-b021-d79d898c0293",
    "type": [
      "VerifiableCredential"
    ],
    "credentialSubject": {
      "id": "did:key:z6MktKwz7Ge1Yxzr4JHavN33wiwa8y81QdcMRLXQsrH9T53b"
    },
    "issuer": "did:key:z6MkgND5U5Kedizov5nxeh2ZCVUTDRSmAfbNqPhzCq8b72Ra",
    "issuanceDate": "2020-03-16T22:37:26.544Z",
    "proof": {
      "@context": [
        "https://w3id.org/security/data-integrity/v1"
      ],
      "type": "DataIntegrityProof",
      "proofPurpose": "assertionMethod",
      "proofValue": "z2oC1eweiTgVYvY6tyeEFUQD6bFfYqLdBN55Rqnn6VUcHLCMjDrzBGtYfn4aSMixTABTHqk2XRgZP6YZxcSMGeB8K",
      "verificationMethod": "did:key:z6MkgND5U5Kedizov5nxeh2ZCVUTDRSmAfbNqPhzCq8b72Ra#z6MkgND5U5Kedizov5nxeh2ZCVUTDRSmAfbNqPhzCq8b72Ra",
      "created": "2023-08-11T21:21:49.896Z",
      "cryptosuite": "eddsa-2022"
    }
  },
  "options": {
    "checks": [
      "proof"
    ]
  }
}'

Results in:
{
    "valid": true
}

Hey @tmarkovski, just a heads up that the W3C VCWG, just last week, adopted the eddsa-2022 test suites for our final push for global standardization (feature freeze in Sept 2023 -- next month) and call for implementations starting in October 2023.
Would you be ok with us adding Trinsic's implementation to the set of official implementations participating in the eddsa-2022 tests? Feel free to provide the same PR as this one, on this other implementations repository here: https://github.com/w3c/vc-test-suite-implementations/tree/main/implementations
In a similar vein, now that you have issuer and verifier endpoints, we could integrate Trinsic into the CHAPI Playground as an issuer / verifier. See here for more info: https://chapi.io/
You'd show up in this list:

Interested? We'd love to add you to the list of supported issuers and verifiers.

Thanks @msporny, I made a PR against the other repo.
Integrating into CHAPI would be great. How do we go about adding this? In fact, we also just added a CHAPI interface for our holder wallets as well, though it will be a week or so until that's publicly available.

Thanks @msporny, I made a PR against the other repo.

Excellent, thank you! Merged and tests are already showing Trinsic passing! :tada:
https://w3c.github.io/vc-di-eddsa-test-suite/#Data Integrity (issuer)

If you don't mind me asking, what's the difference in the two repositories between w3c-ccg and w3c org?

The w3c-ccg repository contains test suites that have not been promoted to the official W3C VCWG yet... things like the did:key test suite, status-list-2021, VC API tests, credential refresh tests, and other things that are pre-standards / experimental. It is important to have those things around so we can get as much interop as we can before we take those specifications onto the global standards-track... and, until last week, there used to be only one implementation repository... but that changed when the W3C VCWG officially adopted a number of the CCG test suites into the VCWG. A few VCWG members said that they'd object if we mentioned some of the work incubating in the CCG, so we were forced to create two repositories.
So, in summary, the CCG implementations list contains links to pre-standards, experimental test suites, and the VCWG implementations list contains links to only the standards-track VCWG test suites.

Integrating into CHAPI would be great. How do we go about adding this?

I'm cc'ing @gannan08 @bigbluehat @brianorwhatever and @mlemmer who will be able to help you through that process. You can start here:
https://github.com/credential-handler/chapi-playground-test-suite/
and these instructions might be helpful to you:
https://github.com/credential-handler/chapi-playground-test-suite/blob/main/configs/README.md
I'll leave it to the folks above to help you through that process.

In fact, we also just added a CHAPI interface for our holder wallets as well, though it will be a week or so until that's publicly available.

Also excellent news! We'd love to list you on the CHAPI Playground as a compatible wallet. Just let us know when you've got the release out there so that we can add you to the list on the website.

@tmarkovski Thanks for getting the issues fixed. I can confirm that majority of the eddsa tests are now passing for Trinsic. I'll be merging the PR shortly.
Just noting that since you've added the vc-api tag to your implementation config, your issuer and verifier will also run against the following two test suites: https://github.com/w3c-ccg/vc-api-issuer-test-suite and https://github.com/w3c-ccg/vc-api-verifier-test-suite. Not sure if that is what you intended. Currently, the issuance and verification are failing within those test suites for Trinsic. On successful issuance, the test expects a 201 status code but we're getting a 200 instead. And Trinsic's verifier is failing to verify a VC with Ed25519Signature2020 proof type, which is the test VC we use in the vc-api test suites:
{
  '@context': [
    'https://www.w3.org/2018/credentials/v1',
    'https://w3id.org/security/suites/ed25519-2020/v1'
  ],
  type: [ 'VerifiableCredential' ],
  credentialSubject: { id: 'did:key:z6MkhTNL7i2etLerDK8Acz5t528giE5KA4p75T6ka1E1D74r' },
  id: 'urn:uuid:42a03a70-088b-4525-adab-e2bda48baa14',
  issuer: 'did:key:z6MkrgWkBKh5tK6VPEEwUbduZZ2iKTF358siSm9xq1YUvNas',
  issuanceDate: '2023-08-14T13:44:13Z',
  proof: {
    type: 'Ed25519Signature2020',
    created: '2023-08-14T13:44:13Z',
    verificationMethod: 'did:key:z6MkrgWkBKh5tK6VPEEwUbduZZ2iKTF358siSm9xq1YUvNas#z6MkrgWkBKh5tK6VPEEwUbduZZ2iKTF358siSm9xq1YUvNas',
    proofPurpose: 'assertionMethod',
    proofValue: 'zh9Bkmye5K8aJfpkFSDFdqFFHrgTgcKc1GLVT4obFBYXLDrEptaWvWz36eDPd3LjEvQNe9hP6Gv9WDCxnFdg2e8a'
  }
}

@tmarkovski We did use ed25519 as the default signature in many suites. This is mostly because it's the most widely implemented key and signature suite out there. Additionally speaking interopability tests in some suites will pass the VC issued from one implementation to another vendor's implementation. So if you don't support their did method, proof, assertionMethod, etc. those tests will fail. The ed25519 tag should be optional though if you're not in the ed25519 suite. It sounds like we might have the wrong tag somewhere if that is the case. Could you link to the test suites in question?

@aljones15 The vc-api-verifier test suite implicitly requires support for verifying Ed25519Signature2020. This is what I understand to be the case. This isn't a big issue, the difference between eddsa-2022 and Ed25519Signature2020 is minimal, I was just clarifying that's the case.

@JSAssassin I did intend that, but my changes to the prod instance referenced in this implementation is just slightly behind. You checked in between I updated this PR and deployed my changes to prod 😄 I initially didn't plan to include vc-api, but it seemed like a very small effort to bring that in as well. Test should be passing now.

@tmarkovski  Thanks, I can confirm that the vc-api issuer tests are now passing.

I'll see if adding Ed25519Signature2020 will be possible to make sure the verify test passes, though this seems a bit off pattern. It doesn't seem like the tag Ed25519Signature2020 is optional then, is that correct? In other words, I can't claim to be compliant with vc-api just by using eddsa-2022?

The tag Ed25519Signature2020 is not required to be specified for the vc-api tests, however your verifier requires to be able to verify a VC with Ed25519Signature2020 proof type to pass the vc-api verifier tests since currently the mock VC data being sent to the verifiers uses the Ed25519Signature2020 proof type .
Adding the Ed25519Signature2020 tag to your issuer/verifier configs will also run the implementation against the ed25519signature2020 test suite - https://github.com/w3c/vc-di-ed25519signature2020-test-suite.

@JSAssassin Thank you for the explantaion. It doesn't seem there's a good path forward without supporting Ed25519Signature2020 one way or the other. I'll add support for that and report back, so we can merge all changes together. I appreciate your patience.

We do want to eventually support multiple cryptosuites for verifiers in the VC Verifier API tests, and pick the cryptosuite based on implementation (and not just require one). We're supposed to be testing the VC Verifier API in those tests (not necessarily which cryptosuite an implementation is using), so that's where we want to go eventually.
Unfortunately, we're not there today and had to pick a cryptosuite that was most widely implemented. We'll want to discuss how to select the cryptosuite properly for the VC Verifier API tests (we can key off of the tags that people have). The only complexity is the NxN interop tests we do -- some verifiers won't be able to interop w/ some issuers based on the cryptosuites the issuers use. We'll get there eventually.

@JSAssassin Implementation is now updated with support for vc-api, eddsa-2022 and Ed25519Signature2020 for both issuers and verifiers.


Docs reference non-existent "exclude.txt"

From README.md, this link is a 404:

This action excludes several files and directories from the deploy by default. See the exclude.txt for reference.

Came here to say this


Consider timed balance in the transaction pool

This PR uses the timed balance instead of the maximum balance when considering whether transactions are valid to include in the pool.
This likely would have prevented the issue that stalled the current testnet.
Checklist:

[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them:

Is this missing some code being pushed? Getting
File "src/lib/network_pool/transaction_pool.ml", line 329, characters 13-39:
Error: Unbound value Currency.Amount.of_balance

@es92 yea, sorry. Can you try again now?

Fast! That ones working now, still getting a
File "src/lib/network_pool/transaction_pool.ml", line 328, characters 10-242:
Error: This expression has type Currency.Balance.t option
       but an expression was expected of type Currency.Balance.t

Ah I think you just pushed that, trying now..

Success! Thanks so much!


Support nginx acquired when at the front of the true IP to users

Support nginx acquired when at the front of the true IP to users
system/Input.php

Why did you remove all the visibility on the methods? Also why is a change needed for nginx? I have been using nginx without any issues.

http://stackoverflow.com/questions/1627901/remote-addr-not-getting-sent-to-django-using-nginx-tornado
i download codeigniter 2.1.0 on codeigniter website ,then edit Input.php replace the codeigniter repository, i think top website can understanding what i mean !

So the only real change is you added - HTTP_X_REAL_IP
I think the problem is you sent a pull request to the develop branch which has had this file changed a lot. So ideally you need to pull develop, make your change, then send another pull request. This one has to many changes to cleanly merge in.

yes, only change added HTTP_X_REAL_IP, i'll send another pull request ,thank you so much~

Thanks. Will close this one.


[FORMATTING] grant formatting issues

Input data
Which SQL and options did you provide as input?
grant select on t to r;

grant select, insert, update, delete on t to r;

Expected Output
grant select on t to r;

grant select, insert, update, delete on t to r;

Actual Output
grant
select
	on t to r;

grant
select
,
	insert,
update,
delete on t to r;

Usage

How are you calling / using the library? npx sql-formatter -l postgresql file.sql
What SQL language(s) does this apply to? postgres
Which SQL Formatter version are you using? 12.2.0

Thanks for reporting.
Unfortunately this is another issue that's unlikely to get fixed with the current formatter architecture.


Clean up detection descriptions

Required items, please complete
Change(s):

Updated multiple Description field for 125 analytics

Reason for Change(s):

Most changes are to remove unexpected newlines. Detections are using literal block scalars, but many descriptions seem to have been written for folded block scalars. Some typos and spelling fixed also.

Version Updated:

Yes

Testing Completed:

No - description changes only

Checked that the validations are passing and have addressed any issues that are present:

Yes

@microsoft-github-policy-service agree

Hi @v-shukore @v-atulyadav
The remaining pipeline failures are not a result of changes that I made. Can you please advise how to proceed?


RPC behavior and folder structure

If it is intended that the RPC responses be compliant with Bitcoin Core, serializable Model based formatters for the output structure can be created.
Project structure:
Currently a folder Controllers is in the Project root. As these controllers will only be used by the RPC feature, can we move the Controllers into the RPC folder? This would allow us to group RPC response formatters under the RPC folder as well.

Yes we probably need to move Controllers.
Things to consider, at a later stage the mempool and store (and RPC) might become standalone features in their own nuget package, my initial intention was to place controllers in their respected features, this will be hard to achieve in the case of rawtransaction as its served from both store and mempool.
For now I support your plan for moving controllers to a folder under RPC
@NicolasDorier may want to be involved

Yes, I can see reorganizing under the individual features once possible.
All of the current controllers rely on FullNode, so perhaps creating a FullNodeController base class is a good step toward segregating the controllers based on dependencies.

I wanted to move them. Problem is that weird MVC rules (which can probably be override given enough time spent on it), enforce the controller folder structure by convention.

place controllers in their respected features, this will be hard to achieve in the case of rawtransaction as its served from both store and mempool.

I think we can eventually vary the capabilities of the RPC controllers based on which features have been injected. If there's no store, getrawtransaction can just check the mempool and vice-versa.

weird MVC rules

The controllers were picked up in the new folder, perhaps this restriction has been eliminated in .Net Core.

I think we can eventually vary the capabilities of the RPC controllers based on which features have been injected.

Yes that we the plan.
The plan is to have modular design so people can create plugins. Indeally we would inject controllers at runtime.
I have not managed to do it though..

@nicolasdorier @derrick- have a look at how I'm registering controllers located in different assemblies here: https://github.com/stratisproject/Breeze/blob/master/Breeze/src/Breeze.Api/MvcBuilderExtensions.cs
Does this help?

@bokobza where have you find how to do ? I spent hours disassembling MVC Core libraries to know how to do it, and failed.

@nicolasdorier la chance du débutant!
I guess I got lucky with my search (not always the case). 😀


Don't allow Create Torrent window to open from Prefs window

Currently, you can alternate clicking Create New Torrent and Preferences to create a stack of prefs and new torrent windows as deep as you want, and move between them using the back and forward buttons.

You don't even have to alternate, I just kept clicking preferences or spammed cmd+,, but maybe this is what you meant. Anyway good catch 👍


The example does not work

The example when it is run, gives the following error:
• Could not deduce (Backprop Net) arising from a use of ‘^^.’
      from the context: Reifies s W
        bound by the type signature for:
                   runNet :: forall s.
                             Reifies s W =>
                             BVar s Net -> BVar s (R 784) -> BVar s (R 10)
        at app/Main.hs:(48,1)-(52,20)
    • In the first argument of ‘(#>)’, namely ‘(n ^^. weights1)’
      In the first argument of ‘(+)’, namely ‘(n ^^. weights1) #> x’
      In the second argument of ‘($)’, namely
        ‘(n ^^. weights1) #> x + (n ^^. bias1)’
   |
55 |     y = logistic $ (n ^^. weights1) #> x + (n ^^. bias1)
   |                     ^^^^^^^^^^^^^^

Ah, how are you running it?
I did notice that since the LTS has moved on, you need to explicitly specify hmatrix-backprop-<IP_ADDRESS> in the stack call at the top.  But with that change it should build fine.  The error you are showing, however, seems to suggest you're using backprop-0.2; the example is only compatible with backprop-0.1, so the blog post is a bit out of date.  I should probably mark that, so thanks for the heads up!
In the meanwhile, the official backprop website might have a better introduction, if you are looking to get started :)

Even with the version 0.1, the error is still the same
    • Could not deduce (Backprop Net) arising from a use of ‘^^.’
      from the context: Reifies s W
        bound by the type signature for:
                   runNet :: forall s.
                             Reifies s W =>
                             BVar s Net -> BVar s (R 784) -> BVar s (R 10)
        at app/Main.hs:(48,1)-(52,20)
    • In the first argument of ‘(#>)’, namely ‘(n ^^. weights1)’
      In the first argument of ‘(+)’, namely ‘(n ^^. weights1) #> x’
      In the second argument of ‘($)’, namely
        ‘(n ^^. weights1) #> x + (n ^^. bias1)’
   |
55 |     y = logistic $ (n ^^. weights1) #> x + (n ^^. bias1)
   |                     ^^^^^^^^^^^^^^

--  While building package fallacyOfCommon-<IP_ADDRESS> using:

Thanks for the link; let me also look at it.

Are you running it using the stack shebang?
$ ./thefilename.hs

The stack shebang at the top makes the script itself an executable that can be called from the command line.  This ensures the proper versions of everything are loaded.

I was building it using stack instead.  The shebang is there but when I try to execute from the console $ ./Main.hs, it first give permission denied error and if I use sudo, it just gives command not found.

Ah, yeah, i believe you'd have to set the file as executable if you want to execute it directly
$ chmod u+x Main.hs

I could probably work on the usability aspects of these scripts a bit more admittedly :)


PLAT-107424: Reduce the number of DOM elements in VirtualList

Checklist

[x] I have read and understand the contribution guide
[ ] A CHANGELOG entry is included
[ ] At least one test case is included for this feature or bug fix
[ ] Documentation was added or is not needed
[ ] This is an API breaking change

Issue Resolved / Feature Added / Resolution
To remove the div with role attribute, the itemRenderer was renamed as placeholderRenderer in https://github.com/enactjs/enact/pull/2770. So all theme libraries should be updated align to that API.
Additional Considerations
We don't need to handle the needsScrollingPlaceholder. In other theme library, it was already deprecated.
Links
PLAT-107424
Comments

I'm seeing this warning in sampler. please check.
Warning: Each child in a list should have a unique "key" prop.

Check the render method of `VirtualListBasic`. See https://fb.me/react-warning-keys for more information.
    in Spottable (at useThemeVirtualList.js:370)
    in VirtualListBasic (at VirtualList.js:78)

I think we need a key in SpotlightPlaceholder.

I'm seeing this warning in sampler. Please check.
Warning: Failed prop type: ui:ScrollerBasic: prop type `scrollContentRef` is invalid; it must be a function, usually from the `prop-types` package, but received `undefined`.
    in ui:ScrollerBasic (at Scroller.js:75)
    in Scroller (at I18nDecorator.js:182)


Add support for postgresql for the standalone topology (in addition to h2)

#86 also resolves #91.


Incompatible type string

https://github.com/burzum/cakephp-html-purifier/blob/3.0-beta1/src/Lib/Purifier.php#L50
array('HTML.AllowedEleme...rializerPath' => CACHE) of type array<string,mixed|string|true> is incompatible with the type string expected by parameter $config of Burzum\HtmlPurifier\Lib\Purifier::config().

Can you please paste a whole stack trace? How can I reproduce it issue...?

How can I reproduce it issue...?
Purifier::config(
    'JvoPurifier',
    [
        'HTML.AllowedElements' => 'h1,h2,b,i,u,p,ol,ul,li,a,br',
        'HTML.AllowedAttributes' => 'a.href',
        'AutoFormat.RemoveEmpty' => true,
        'Cache.SerializerPath' => CACHE,
    ]
);

But second parameter of config method are declared as string (line 50), in that method you can also use array (line 65)

@salines line 50 doesn't matter at all this is just a doc block - that is wrong - but doesn't cause any runtime errors. The only thing complaining here is probably phpcs. The 2nd arg has no strict type. I'll fix the doc block but this is not really a problem.

Yes, it's an issue related to php-doc params, but tools like the scrutinizer show a Bug message and our client is worried.
Danke.


[BEAM-11770] bump google-cloud-pubsub to 1.111.0

bump google-cloud-pubsub to 1.111.0

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java_Examples_Dataflow PreCommit

Run Website PreCommit

R: @iemejia
Could you review this PR?

I am not familiar with the consequences of dependency upgrades for Google related dependencies, so in the future for google related dependencies please choose as a reviewer like @kennknowles @chamikaramj or @suztomo
Can someone of you please help review this one or forward this to someone who can. Thanks!
Oh and thanks for your this and all the other recent contributions @masahitojp !

Run Java Postcommit

@masahitojp Would you try running the command below?
sh sdks/java/build-tools/beam-linkage-check.sh origin/master beam-11770

https://cwiki.apache.org/confluence/display/BEAM/Dependency+Upgrades#app-switcher (this has outdated command line parameter. It now takes 2 git branches.)
If there's no new conflict, it looks good to me (I'm not a committer though).
Note that there's back-and-forth (#13765 and #13972) of GCP dependencies in the last couple of weeks. They might interfere this PR; thank you for your patience.

Hi @suztomo
I tried the command.

sh sdks/java/build-tools/beam-linkage-check.sh origin/master beam-11770

but I got a below errors :cry:
Failed to generate the baseline file. Check the build error above.
Checking linkage for origin/beam-11770
Previous HEAD position was 3930d12d47 Merge pull request #13981: [BEAM-11124] bump joda-time to 2.10.10
HEAD is now at 45ba4c5888 [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Running linkage check (validate) for beam-sdks-java-core
using baseline build/linkagecheck/baseline-beam-sdks-java-core.xml
Error: Baseline file not found
Running linkage check (validate) for beam-sdks-java-io-google-cloud-platform
using baseline build/linkagecheck/baseline-beam-sdks-java-io-google-cloud-platform.xml
Error: Baseline file not found
Running linkage check (validate) for beam-runners-google-cloud-dataflow-java
 using baseline build/linkagecheck/baseline-beam-runners-google-cloud-dataflow-java.xml
Error: Baseline file not found
Running linkage check (validate) for beam-sdks-java-io-hadoop-format
 using baseline build/linkagecheck/baseline-beam-sdks-java-io-hadoop-format.xml
Error: Baseline file not found

Do you know what is causing it? (openjdk version "1.8.0_282")

Check the build error above.

Do you see any error above the line?
On Wed, Feb 17, 2021 at 06:45 Masato Nakamura<EMAIL_ADDRESS>wrote:

Hi @suztomo https://github.com/suztomo
I tried the command.
sh sdks/java/build-tools/beam-linkage-check.sh origin/master beam-11770
but I got a below errors 😢
Failed to generate the baseline file. Check the build error above.
Checking linkage for origin/beam-11770
Previous HEAD position was 3930d12d47 Merge pull request #13981: [BEAM-11124] bump joda-time to 2.10.10
HEAD is now at 45ba4c5888 [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Running linkage check (validate) for beam-sdks-java-core
using baseline build/linkagecheck/baseline-beam-sdks-java-core.xml
Error: Baseline file not found
Running linkage check (validate) for beam-sdks-java-io-google-cloud-platform
using baseline build/linkagecheck/baseline-beam-sdks-java-io-google-cloud-platform.xml
Error: Baseline file not found
Running linkage check (validate) for beam-runners-google-cloud-dataflow-java
using baseline build/linkagecheck/baseline-beam-runners-google-cloud-dataflow-java.xml
Error: Baseline file not found
Running linkage check (validate) for beam-sdks-java-io-hadoop-format
using baseline build/linkagecheck/baseline-beam-sdks-java-io-hadoop-format.xml
Error: Baseline file not found
Do you know what is causing it? (openjdk version "1.8.0_282")
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/13994#issuecomment-780501401, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAG7PFWCDCIDIFYKWD4NI3S7OT4TANCNFSM4XWLXX2Q
.

I tried and got the same error. Digging further. https://gist.github.com/suztomo/b5a33361ad83c5e5c9054b393ac496c1

@masahitojp It seems that beam-linkage-check.sh has not been migrated properly when this repository moved build script from Gradle to Kotlin. (Your observation helped me to identify the problem. Thank you!)
I raised a pull request to fix the problem https://github.com/apache/beam/pull/14006. Give me and Beam committers some moment.

@masahitojp I rebased your branch and ran the tool
https://gist.github.com/suztomo/0ba02d93aa0b2f5d9701c50f7d7fd81f It seems that proto-google-cloud-pubsub-v1 needs to have a newer version. Would you check it?

@suztomo Thank you for your great contribution!!

It seems that proto-google-cloud-pubsub-v1 needs to have a newer version. Would you check it?
I checked it. I can't say anything, but I think it's preferable to update it

https://github.com/apache/beam/blob/b8dd9cb4dfbcacda3b50baa440a0f3642b230990/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L607
maybe　, In other words, I think it will affect this trend.

Note that there's back-and-forth (#13765 and #13972) of GCP dependencies in the last couple of weeks.

I think it would be good to put it on hold until this work is finished.  😢

Run Java PreCommit

The current master branch depends on 16.3.0 (#13990)
In other words, there was no longer any affect on us.

Note that there's back-and-forth (#13765 and #13972) of GCP dependencies in the last couple of weeks.

#13990 is merged, and this PR is restarted, especially since it does not seem to be causing any problems in testing.

Now I've changed the purpose of this PR.
what

bump google-cloud-pubsub to 1.110.3, because we follwed dependencies in google_cloud_platform_libraries_bom sets version.

The current master branch depends on 16.3.0 (#13990)
https://storage.googleapis.com/cloud-opensource-java-dashboard/com.google.cloud/libraries-bom/16.3.0/artifact_details.html
^ It depends on com.google.cloud:google-cloud-pubsub:1.110.3
Since this is newer than the current master(1.108.6 ) , I think it's better to update
why(background)
The apache beam specifies the versions of the following packages

com.google.cloud:google-cloud-pubsub

But this package has dependencies with the following packages but this one is specified by google_cloud_platform_libraries_bom

com.google.api.grpc:proto-google-cloud-pubsub-v1
com.google.api.grpc:grpc-google-cloud-pubsub-v1

The dependencies of this package are difficult to understand for people who don't know about it, so there is a possibility that the dependencies will be broken unintentionally in the future. For this reason, I thought it would be better for me to unify them into google_cloud_platform_libraries_bom
^ It depends on com.google.cloud:google-cloud-pubsub:1.110.3
Since this is newer than the current master(1.108.6 ) , I think it's better to update
results of sh sdks/java/build-tools/beam-linkage-check.sh origin/master beam-11770
Success
https://gist.github.com/masahitojp/6a292e3d8ff5506383fca3a44805bafb
(Thanks to your support @suztomo )

Could you re-review this PR?
R: @TheNeuralBit @iemejia


Checking out a PR doesn't refresh comment actions

Have a PR that has a suggested change in it
Do not check out the PR
Open the file with the suggestion from the PRs view
See the suggestions and leave the file open
Now check out the PR
The action to accept the suggestion doesn't appear on the comment even though the PR is now checked out.

 I'm not seeing the accept suggestion button even though I'm checked out to the PR. Am I doing something wrong?

@andreamah the screenshot actually has the accept action visible in it. It's the gift icon in the comment title actions.


ICommandDispatcher.CollectSuggesetions(...) has a typo

The title says it all.
https://github.com/aspnet/DotNetTools/blob/9b598446caa060374081b27c00f4c357d064c680/src/Microsoft.Repl/Commanding/ICommandDispatcher.cs#L15

Good catch, thanks!

This should be fixed by #507


SharedMatrix: Op resubmission replaces IFluidHandle with serialized form

Describe the bug
There is a short window of time where setting IFluidHandles into SharedMatrix cells seems to initially work, but the handles later are converted to their serialized form?
To Reproduce
During reconnection, setCell() with an IFluidHandle.  Later, retrieving the cell value returns the serialized from { type: "__fluid_handle__", url: ".." }.
Only reproduces during this narrow reconnection window.

Fixed by #5813.


[Android][iOS][Dev-tool] Can  support loop?

Describe the bug

To Reproduce

Environment

Expected behavior

Screenshots

Additional context

If it doesn't exist in the document, then it doesn't support.


How to use the models made from training

Hi, how do I use the models that ImageAI created from its training? The 100 models I made from training were ResNet type models.
Here is a screenshot of the 100 models I created from training with the path displayed: https://imgur.com/a/lsh62j3
I keep getting this exception:
Using TensorFlow backend.
WARNING:tensorflow:From C:\Users\Owner\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow\python\framework\op_def_library.py:263: colocate_with (from tensorflow.python.framework.ops) is deprecated and will be removed in a future version.
Instructions for updating:
Colocations handled automatically by placer.
Traceback (most recent call last):
File "C:\Users\Owner\Desktop\maybe.py", line 9, in
detector.loadModel()
File "C:\Users\Owner\AppData\Local\Programs\Python\Python37\lib\site-packages\imageai\Detection_init_.py", line 185, in loadModel
model.load_weights(self.modelPath)
File "C:\Users\Owner\AppData\Local\Programs\Python\Python37\lib\site-packages\keras\engine\network.py", line 1166, in load_weights
f, self.layers, reshape=reshape)
File "C:\Users\Owner\AppData\Local\Programs\Python\Python37\lib\site-packages\keras\engine\saving.py", line 1030, in load_weights_from_hdf5_group
str(len(filtered_layers)) + ' layers.')
ValueError: You are trying to load a weight file containing 107 layers into a model with 116 layers.
Here is the code I used to produce my models:
from imageai.Prediction.Custom import ModelTraining
model_trainer = ModelTraining()
model_trainer.setModelTypeAsResNet()
model_trainer.setDataDirectory(r"C://Users//Owner//Desktop//Pieces")
model_trainer.trainModel(num_objects=3, num_experiments=100, enhance_data=True, batch_size=32, show_network_summary=True)
Here is the code in which I tried to use the models I made:
from imageai.Detection import ObjectDetection
import os
execution_path = os.getcwd()
detector = ObjectDetection()
detector.setModelTypeAsRetinaNet()
detector.setModelPath( "C:\Users\Owner\Desktop\Pieces\models\model_ex-100_acc-0.383333.h5")
detector.loadModel()
detections = detector.detectObjectsFromImage(input_image=os.path.join(execution_path , "easier.jpg"), output_image_path=os.path.join(execution_path , "imagenew.jpg"), minimum_percentage_probability=30)
for eachObject in detections:
print(eachObject["name"] , " : ", eachObject["percentage_probability"], " : ", eachObject["box_points"] )
print("--------------------------------")
Note: When I download the "resnet50_coco_best_v2.0.1.h5" file and use that model in object detection, it starts trying to identify "teddy bears", which are classes of objects I never trained my pictures on.

Also, using the sample model_json and idenprof.h5 dataset on your medium post, this picture outputs a result of 63% doctor when it is a chef...Am I doing something wrong?

Hi, how do I use the models that ImageAI created from its training? The 100 models I made from training were ResNet type models.
Here is a screenshot of the 100 models I created from training with the path displayed: https://imgur.com/a/lsh62j3
I keep getting this exception:
Using TensorFlow backend.
WARNING:tensorflow:From C:\Users\Owner\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow\python\framework\op_def_library.py:263: colocate_with (from tensorflow.python.framework.ops) is deprecated and will be removed in a future version.
Instructions for updating:
Colocations handled automatically by placer.
Traceback (most recent call last):
File "C:\Users\Owner\Desktop\maybe.py", line 9, in
detector.loadModel()
File "C:\Users\Owner\AppData\Local\Programs\Python\Python37\lib\site-packages\imageai\Detection__init__.py", line 185, in loadModel
model.load_weights(self.modelPath)
File "C:\Users\Owner\AppData\Local\Programs\Python\Python37\lib\site-packages\keras\engine\network.py", line 1166, in load_weights
f, self.layers, reshape=reshape)
File "C:\Users\Owner\AppData\Local\Programs\Python\Python37\lib\site-packages\keras\engine\saving.py", line 1030, in load_weights_from_hdf5_group
str(len(filtered_layers)) + ' layers.')
ValueError: You are trying to load a weight file containing 107 layers into a model with 116 layers.
Here is the code I used to produce my models:
from imageai.Prediction.Custom import ModelTraining
model_trainer = ModelTraining()
model_trainer.setModelTypeAsResNet()
model_trainer.setDataDirectory(r"C://Users//Owner//Desktop//Pieces")
model_trainer.trainModel(num_objects=3, num_experiments=100, enhance_data=True, batch_size=32, show_network_summary=True)
Here is the code in which I tried to use the models I made:
from imageai.Detection import ObjectDetection
import os
execution_path = os.getcwd()
detector = ObjectDetection()
detector.setModelTypeAsRetinaNet()
detector.setModelPath( "C:\Users\Owner\Desktop\Pieces\models\model_ex-100_acc-0.383333.h5")
detector.loadModel()
detections = detector.detectObjectsFromImage(input_image=os.path.join(execution_path , "easier.jpg"), output_image_path=os.path.join(execution_path , "imagenew.jpg"), minimum_percentage_probability=30)
for eachObject in detections:
print(eachObject["name"] , " : ", eachObject["percentage_probability"], " : ", eachObject["box_points"] )
print("--------------------------------")
Note: When I download the "resnet50_coco_best_v2.0.1.h5" file and use that model in object detection, it starts trying to identify "teddy bears", which are classes of objects I never trained my pictures on.

Please note that ImageAI is yet to support training custom models for object detection.  The model you trained is for prediction and not detection., which means you will be using the CustomImagePrediction class instead of ObjectDetection

Also, using the sample model_json and idenprof.h5 dataset on your medium post, this picture outputs a result of 63% doctor when it is a chef...Am I doing something wrong?

The model is not always 100% correct, and considering a doctors and chefs do have outfits with very similar color and structure, this may a occur a number of times.

Please note that ImageAI is yet to support training custom models for object detection. The model you trained is for prediction and not detection., which means you will be using the CustomImagePrediction class instead of ObjectDetection

When will ImageAI support training custom models for object detection? can you give us some rough idea?
And you guys are doing very well.

Kindly follow this thread for more on this. #8

@OlafenwaMoses  Ok.


Error while parsing gtf

Description of the bug
Hello,
I am getting the follwoing error when i run tf activity pipeline
Command output:
[1] "Reading genes.gtf elements of type gene"
[1] "Found 0 features"
Command error:
[1] "Reading genes.gtf elements of type gene"
[1] "Found 0 features"
gene_id is not a valid field
I am using Rat ensembl GTF.
Another issue is I am not able to use narrowPeak files. I had to rename them to broadPeak in order to process them.
Command used and terminal output
nextflow run nfcore/pipelines/tfactivity/dev/workflow \
            --input samplesheet.csv \
            --outdir ./results \
            -profile  singularity \
            --counts hisat.counts_for_tfactivity.csv \
            --counts_design rnaseq_design.csv \
            -config genome.config \
            --genome rat-ensembl-rn6-r102 \
            --taxon_id 10116

Relevant files
No response
System information
No response

Hey, could you provide more detailed error information? E.g. the .nextflow.log file? It's very hard to find out where in the pipeline this error occurred without more information.

error.log
Hi @nictru ,
Attached is the nextflow.log
Thanks!


Asynchronous UART API triggers Zephyr assertion on STM32WB55

Describe the bug
Zephyr assertion is triggered by UART reception when asynchronous API is used.
The event flow is as described below:

System timer ISR starts handling IDLE timeout (submitred from UART driver as delayed work).
In the sys_clock_announce (work) timeout is removed from the timeouts system queue and then interrupts are being reenabled (k_spin_unlock).
UART (IDLE) interrupt comes here and ISR reschedules delayed work (k_work_reschedule->unschedule_locked) and this reschedule causes attachement of timeout to the system timeouts queue (timeout associated with this work is already being handled by system timer).
Then control returns to the timer ISR (sys_clock_announce) and there is called timeout function t->fn(t) which calls work_timeout where K_WORK_DELAYED_BIT flag is cleared (for the timeout being in the meantime added to the system timeouts queue) and then work associated with timeout is submitted do the system work queue (this work in executed as uart_stm32_async_rx_timeout and it doesn't change anything because work timeout cannot be effectively cancelled because K_WORK_DELAYED_BIT flag is cleared).
After short time another UART IDLE interrupt occurs and ISR tries to reschedule again IDLE timeout (delayed work) and this cannot be done properly because K_WORK_DELAYED_BIT flag is already cleared and because of this timeout is not removed from the timeouts queue (z_abort_timeout is not called).
In the next step k_work_reschedule calls schedule_for_queue_locked which calls z_add_timeout which requires that timeout being added cannot be already in the system timeouts queue and this causes crash (assertion is triggered).

Please also mention any information which could help others to understand
the problem you're facing:

target MCU: STM32WB55
Reverting LPUART and LPTIMER interrupts priorities make problem gone (hides it)

To Reproduce
Steps to reproduce the behavior:

Configure LPUART driver to use asynchronous API and implement appropriate user code.
Try to send relatively big amout of data from host to device (frames of about 400 bytes, delay between frames few milisesonds , serial speed 115200).
Zephyr assertion (__ASSERT(!sys_dnode_is_linked(&to->node), "")) can be observed triggered from z_add_timeout function.

Expected behavior
Assertion should not be triggered.
Impact
showstopper
Logs and console output
Environment (please complete the following information):

OS: Linux
Toolchain: Zephyr SDK
Commit SHA: 9315aef26d79197ccdc293a72a9f8491b0b7b18b

Additional context
MCU is setup to use LPUART with LSE as a system clock, TIMESLICING is not configured.

This seems that PM activation, let  the stm32 enter low power stop 0, 1, 2  modes and will also stop the DMA clocks.
Testing the tests/drivers/uart/uart_async_api/ on the lpuart of the stm32wb55 with PM_CONFIG=y, some testcases like
test_chained_write or - test_long_buffers fail.
When preventing the system  to enter low power stop mode  (with uart_stm32_pm_policy_state_lock_get) during  DMA transfers (on uart_stm32_dma_tx_enable and uart_stm32_dma_rx_enable) will make the transfer complete ( uart_stm32_pm_policy_state_lock_put when disabling)
See https://github.com/FRASTM/zephyr/pull/new/wb55_uart_async_pm

from step 4 to 5 do you see that (re-starting) the data->dma_rx.timeout_work comes  (in step 5) after the previous work has already expired  (expires too early from step 4)

@FRASTM
Does it mean that it is a more generic problem?
I mean - Zephyr allows to change already handled timeout in system timer ISR.

Any progress for that?
I observed similar problem associated with using delayed work from interrupt.
We use separate HW timer and ISR for timer interrupt and depending on interrupt priority problems are visible (when timer interrupt priority is higher than LPTIM interrupt) or not.

It may be related to #51872.

It may be related to #51872.

@r2r0, if you're confident, I propose to close this issue. Tbh, we'll won't do nothing on current issue until #51872 is fixed.
Issue could be re-open later if required

Need to be checked if fix for #51872 also resolves this issue.


Possibly speed up dev-dependency installs?

I've probably been watching too many Travis builds lately, but it seems like at least half (and sometimes most) of the two to five minutes taken by non-browser jobs is just installing through NPM. With several times as many jobs in our build matrix as Travis allows us to run at once, this can really slow each build down a lot. Mocha installs quickly enough as a dependency of other projects, it's all those dev dependencies that make its own CI installs (and local development installs) sloooow.
Caching may or may not be a viable strategy to speed any of that up -- obviously we want to reinstall cleanly if anything that could affect it changes, and obviously running on so many different environments there isn't going to be a whole lot of opportunity to share an install between multiple jobs even in the same build. I suppose all the Node 8 environments could be sped up by sharing an NPM cache (not the install itself but the cache NPM uses to install from), but that still leaves the variety of non-browser Node test jobs...
However, not all of our dev dependencies are actually needed by all jobs. Could we perhaps make them optional dev dependencies and install them where they're needed? Is optional dev dependencies a thing?
Here's what I believe are prematurely pessimizing our installs by being downloaded in all of them:

watchify appears to be referenced nowhere in our codebase except package.json; unless I've missed something, we can just remove it
eslint and eslint-* are only used in the lint job to my knowledge
the following are only used in browser jobs, to my knowledge:

browserify
browserify-istanbul (in my browser coverage branch/PR)
karma
karma-*
os-name? the one place I know it's being used is to determine whether to use Phantom or Chrome in a non-Sauce browser test
rimraf? the one place I know it's being used is to clean the build, which is done before browser tests and before publishing
through2

the following are only used in the PhantomJS browser job, to my knowledge:

phantomjs
karma-phantomjs-launcher

karma-sauce-launcher is only used in Sauce browser jobs, to my knowledge
karma-chrome-launcher is used if somebody runs the browser tests locally on Mac, but not in CI as far as I can tell
the following are used in CI, extensively with my coverage enhancements, but might not be needed locally unless you want to generate coverage reports:

coveralls
istanbul-combine
nyc

Obviously, whatever makes these get pulled in for the relevant CI would also need to happen for local uses of them in order for us to be able to not download them by default...
And if there's no optional dev dependencies, then removing them from package.json may be dubious anyway (they'd be depended upon but untracked...).
Anywho, I figured I'd throw the idea out there and see if anybody wants to look into it further. It would be awesome to bring the install time down, both locally and to speed up CI builds; but it would depend on really being able to get this all correct...

You could make package-<task>.json files and have a script rename the appropriate one to package.json.

@ScottFreeCode As far as caching is concerned, both Travis and AppVeyor are smart enough to disregard the cache when dependencies have changed. Travis does it by default, AppVeyor can be settings can be tweaked as follows:
cache:
  - node_modules -> package.json

@kunagpal is this behavior by any chance version-range aware? It would be really awesome if we'd reinstall in situations like:

mocha depends on X version ^1.0.0, X releases 1.1.0
mocha depends on X version 1.0.0<EMAIL_ADDRESS>depends on Y version ^2.0.0, Y releases 2.1.0

It'd be even cooler if it would also not reinstall if we change a field in package.json that does not affect dependencies.
AppVeyor might not be as crucial as there are fewer jobs in its matrix to begin with, for what it's worth.

@ScottFreeCode To add to the point made earlier, the package.json specification in appveyor.yml is only limited to the family of dependencies. So, bumping the Mocha version, changing the License, et cetera, would not invalidate the nom cache. I haven't really experimented with what happens in the case of non-strict dependency versions. One possible way here would be to use precise dependency versions, but I feel that has been avoided with Mocha for the reasons of convenience(?).

To add to the point made earlier, the  package.json  specification in  appveyor.yml  is only limited to the family of dependencies. So, bumping the Mocha version, changing the License, et cetera, would not invalidate the nom cache.

:+1:

I haven't really experimented with what happens in the case of non-strict dependency versions. One possible way here would be to use precise dependency versions, but I feel that has been avoided with Mocha for the reasons of convenience(?).

I'm actually not sure whether we're using dependency version ranges on purpose or not, but I think it's worth noting that we'd need some kind of shrinkwrap or lock to deal with version ranges in dependencies' dependencies even if Mocha were using precise versions... unless the same functionality that ignores non-dependency changes to package.json also looks at the resulting dependencies that would actually be installed, including dependencies' dependencies, rather than just at what's specified in our file(s).
(I'm also not certain what all the pros and cons are of different possible behaviors with regard to dependency versions. Might need some discussion with the team. I can imagine outdated dependencies in CI causing us problems, but I can also imagine dependencies changing in CI as third-party updates occur potentially making it hard to track down problems too.)

In my opinion, stale dependencies bring with them a greater baggage as opposed to newer dependencies. Since Mocha already uses Greenkeeper (albeit suboptimally), failures related to changes can be tracked down with relative ease.
This is slightly off topic, but including a shrinkwrap is a good idea, and will also require taking a look at https://github.com/greenkeeperio/greenkeeper-lockfile.

Different approach suggestion, did you test how long it takes to install the deps with yarn instead of npm?

There were some attempts to try switching to Yarn a while back, but I don't know if anyone timed it.
Is my understanding correct that most of the performance gains boasted by Yarn and by NPM 5 require saving a (system level) cache?
We also have in the past needed to ensure that we test installing Mocha's production dependencies with the version of NPM that is bundled with the supported versions of Node, but I don't know for sure if that's still necessary. (I believe it used to ensure we didn't include dependencies that used ^ in their version ranges... or was it ~?... but I'm fairly sure we dropped support for the version of Node that had that limitation in 3.x, and don't know if there are any remaining potential backwards/forwards compatibility issues with NPM.) Just something we'd want to double-check before relying on a newer package manager (whether Yarn or NPM 5).

Unfortunately at this point I don't know much about this, but have seen the difference on a few projects and the difference in install time was around 10x. The only thing I had to do was switch from npm install to yarn. With a complex project like this you might want to use a temp package.json file that has all of the current package versions locked, e.g. =1.3.0 to create your new yarn.lock, then switch back to the original packge.json. I can try this whenever I have some free time.
A quick DDG search led me to this: https://docs.travis-ci.com/user/caching/#yarn-cache so you would be able to take advantage of caching with Yarn on Travis.

Not sure if this interjection is in context or not known already but isn't
it advised to put the package.json.lock file in Travis (or deployment)
rather than a temp file?
On Aug 4, 2017 11:19 PM, "Alessandro Dal Grande"<EMAIL_ADDRESS>wrote:

[image: Boxbe] https://www.boxbe.com/overview This message is eligible
for Automatic Cleanup<EMAIL_ADDRESS>Add cleanup rule
https://www.boxbe.com/popup?url=https%3A%2F%2Fwww.boxbe.com%2Fcleanup%3Fkey%3Dp%252B8nHPEIWcdsurRnysyXTtfE%252FmCMseoHAdWLKhYyfgo%253D%26token%3DTYxYBnECMjlcIu9N1kOdzTYhFUxDcmJftg1d1n8PsuQnWXJkw7kW9dvbrIuRrGCgkb1wlCqbHdAYKxKmuC9QtplrZ%252B7NZDmQICGuh3j1CvissxAwStK3j1zHyoc8cReDi0roF2JWMNC4r1kgcQg3Vw%253D%253D&tc_serial=31867441234&tc_rand=712407100&utm_source=stf&utm_medium=email&utm_campaign=ANNO_CLEANUP_ADD&utm_content=001
| More info
http://blog.boxbe.com/general/boxbe-automatic-cleanup?tc_serial=31867441234&tc_rand=712407100&utm_source=stf&utm_medium=email&utm_campaign=ANNO_CLEANUP_ADD&utm_content=001
Unfortunately at this point I don't know much about this, but have seen
the difference on a few projects and the difference in install time was
around 10x. The only thing I had to do was switch from npm install to yarn.
With a complex project like this you might want to use a temp package.json
file that has all of the current package versions locked, e.g. =1.3.0 to
create your new yarn.lock, then switch back to the original packge.json.
I can try this whenever I have some free time.
A quick DDG search led me to this: https://docs.travis-ci.com/use
r/caching/#yarn-cache so you would be able to take advantage of caching
with Yarn on Travis.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mochajs/mocha/issues/2891#issuecomment-320310552, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAxH_OWbE2Gn-BflOmqJrIrw8BVvPVjxks5sU1g9gaJpZM4N9ama
.

Definitely worth looking at, then; I'd be curious to see how Yarn and NPM 5 compare, given that the list of big improvements in NPM 5 was eerily similar to the list of advantages of Yarn over (previous versions of) NPM (or at least, it seemed that way going off of the general marketting buzz).
Something else that just crossed my mind -- we also could really use a solution specifically for PhantomJS and anything else that the global cache is only going to be storing, in effect, a downloader that still pulls the bulk of the package from the internet each time it's locally installed. I'm pretty sure PhantomJS alone takes up at least a tenth and probably more like a quarter of the Mocha dev install time.

About PhantomJS, it seems that phantomjs-prebuilt can use the binary from disk, without downloading. Not sure about which kind of version is currently installed in Travis though.
If you don't change the package.json file often, another way would be to have a prebuilt Docker image and download that on Travis, completely skipping the package install part.

Travis notes that their cache is downloaded from an external storage solution, so it might not help too much if most of the time is spent downloading binaries.


Tip: Adding a plug-in instant messaging like Toastr

I'm submitting a feature request

I believe that the inclusion of a plug-in instant messaging could help many people

Hi @romulotorres, we do not have such plans now, but we'll be glad if you could provide a PR.
As an example you could use this component https://github.com/akveo/ng2-admin/tree/master/src/app/theme/components/baFullCalendar.

add toastr as a requirement into package.json
load js lib like this https://github.com/akveo/ng2-admin/blob/master/src/app/theme/components/baFullCalendar/baFullCalendar.loader.ts
init jquery plugin like this https://github.com/akveo/ng2-admin/blob/master/src/app/theme/components/baFullCalendar/baFullCalendar.component.ts#L19

Let me know if you have any questions.

Hello nnixaa. Thanks for your reply.
I tried to add Toastr in the project but have not had success.
I used this plugin:
https://www.npmjs.com/package/angular2-toaster
I created a folder "baToastr" , creating the files as the theme of default, but could not use that way.
The plugin does not need a jquery call, like the calendar , you indicated .
I also tried to add the plugin directly in app.component but received the following message :
"No Toaster Containers Have Been initialized to receive toasts."
My beginner's knowledge in angular 2 are not yet sufficient to accomplish my needs . Could you give me a little help with that?

Ps:  I will be glad for provide a PR if I do this ;)


CI: switch from Travis-CI to GitHub Actions

hopefully this can run before being merged the first time, but maybe not ...

whoop, slightly premature, at minimum we need to update README.md travis build image

ok, we got a bunch of failures, because -race isn't supported on i386
https://github.com/nsqio/go-diskqueue/runs/3581182654


Update license

Purpose

Update license

Codecov Report

Merging #13540 into next-release will decrease coverage by <.01%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             next-release   #13540      +/-   ##
==================================================
- Coverage           64.62%   64.62%   -0.01%
  Complexity            659      659
==================================================
  Files                2110     2110
  Lines               93134    93134
  Branches            12238    12238
==================================================
- Hits                60190    60184       -6
- Misses              28053    28057       +4
- Partials             4891     4893       +2

Impacted Files
Coverage Δ
Complexity Δ

...a/org/ballerinalang/bre/bvm/WorkerDataChannel.java
79.62% <0%> (-3.71%)
0% <0%> (ø)

...va/org/ballerinalang/channels/ChannelRegistry.java
94.59% <0%> (-2.71%)
0% <0%> (ø)

...ain/java/org/ballerinalang/net/websub/hub/Hub.java
69.53% <0%> (-1.57%)
0% <0%> (ø)

...java/org/ballerinalang/bre/bvm/BLangVMStructs.java
51.66% <0%> (+1.66%)
0% <0%> (ø)
:arrow_down:

...llerinalang/stdlib/socket/tcp/SelectorManager.java
71.79% <0%> (+1.7%)
0% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06220fe...77ae203. Read the comment docs.


tool: how to customize the templates?

if developers want to customize the templates, like:

add a README.md which describes the servicename, rpc, protocols, etc.
add a handler_test.go for unit testing.
etc.

So far, the templates are defined in go code under tool/internal/pkg/tpl, developers can do this only by fork and changing code.

Kitex tool is designed for framework code generation ( sort of protoc-gen-grpc for Kitex framework ). Since it's designed for certain use, generating code with customized templates is beyond it's ability.


receive: Make max backoff configurable

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes
This change retains the default configuration out of the box but allows configuration of max backoff for forward requests between receivers behind a flag.
What motivates this change is that we have seen, under load and in certain events (hashring change, cluster upgrade, rollouts, etc) that a receiver can quickly hit the max backoff of the default 30s and during that time, we get a flood of retries.
Initial tests seem to show that in certain circumstances and envs, we are able to keep error rate much lower during these disruptions with a lower max backoff

Verification

cc @fpetkovski

Thinking about this a bit more, should we reduce the max backoff instead to avoid exposing a flag? The current one is not that good anyway and I am not sure if people will know how to configure this setting.

Right, my only worry is that change the default/existing behaviour and there is something or unintended consequences that we are overlooking but I am not a maintainer, so if you are comfortable I am too :)
How do you think we should tweak it then?

Yeah that's a valid point.
My thoughts were to clamp the max to something like 3s. We could also leave the hidden flag so if people run into issues they can revert back to 30s.