feat(entries): Add the ability to list user's entries

BEGIN_COMMIT_OVERRIDE

[x] Using a noko personal token, we can access to the account
information, and list the user's entries.
[x] Install and configure faraday
[x] Install pry for debugging

Closes #3
END_COMMIT_OVERRIDE

At this point, I cannot see the information on the terminal output when executing noko_cli
I did try in the irb then require 'noko_cli then execute  NokoCli::Entries.new.list to list the entries and I can see them in array of hashes format.
So, I do need to find a way to manage the output, maybe something like a table https://github.com/piotrmurach/tty-table

After using the tty-table, the output it's not an array anymore, for that reason I do need to figure out how to test this action.

I faced a StringIO issue because the StringIO class used in the test doesn't include the ic-something method, I had to open the class and add that method to have the tests running and passing, more info here


🐛 [Bug] RuntimeError: [Error thrown at core/conversion/conversionctx/ConversionCtx.cpp:147] Building serialized network failed in TensorRT

The error gives you an explanation of what happens and how to try to avoid it. It says you are running out of memory so its unable to find a kernel that works and to try increasing the workspace size. Change the value of the setting max_workspace_size to provide tensorrt more memory.

Thanks, Now it seems to compile fine.But it still doesn't work properly. I don't know what the reason is, it doesn't show the error.

You can try increasing logging verbosity to see what is happening at runtime by adding a context
with torch_tensorrt.logging.debug():
    model(input_data, input_data)


HostSecurityConfiguration options - Can't login

I've watched the video that showed how this works - the video (https://vimeo.com/125427106) shows a hardcoded type user and a ADFS claim.  I just want to use a user in Asp.net Identity that I previously assigned to the role "ModifyUsers" when initially using localsecurityconfiguration.
Once I switch the option SecurityConfiguration to HostSecurityConfiguration, when I login I'm redirected to the login screen again, a la an Authorization issue.
When debugging in Visual Studio, I can see the identity (ClaimsIdentity) has claims with the role's I defined for this test user.  What am I missing?
I've even tried changing the NameClaimType to "http://schemas.xmlsoap.org/ws/2005/05/identity/claims/name" - how the username comes over as a claim.

The user needs to be in the admin role -- it's any role that you've configured via SecurityConfiguration.AdminRoleName

Sorry, i should have mentioned I did that from the beginning.  I've set the AdminRoleName or used the default and added the user to whatever it is set to.  Any other possibilities?

I'd make sure the right claim type is being used -- "role" vs "http://schemas.microsoft.com/ws/2008/06/identity/claims/role"

Any update?

Sorry, I'll get back to that project soon, just in the middle of another one right now.

I ran into this issue, and it boiled down to the user's roles not making it back to the app/relying party. The following checks helped me get those roles and thereby get login working:

Ensure Identity Server Scopes include "roles".
Ensure the Identity Server Client configuration allows "roles".
Ensure that the app/relying party's OpenIdConnectAuthenticationOptions.Scope includes "roles".
Ensure that HostSecurityConfiguration.RoleClaimType is set to the correct claim type. If you do not change System.IdentityModel.Tokens.JwtSecurityTokenHandler.InboundClaimTypeMap then you will want to set RoleClaimType to "http://schemas.microsoft.com/ws/2008/06/identity/claims/role" to match what Microsoft maps "role" claims to by default. If you override InboundClaimTypeMap by setting it to say new Dictionary<string, string>() then "role" is the claim type Identity Server provides by default and is what you would want to set RoleClaimType to.
Finally and most obviously, ensure that HostSecurityConfiguration.AdminRoleName is set to the role your admin users are being assigned to, e.g. "UserAdmin".

I dont follow. My configuration looks like:
public partial class Startup
{
    public void Configuration(IAppBuilder app)
    {
        ConfigureAuth(app);
        app.Map("/idm", idm =>
        {
            LogProvider.SetCurrentLogProvider(new TraceSourceLogProvider());

            IdentityManagerServiceFactory factory = new IdentityManagerServiceFactory
            {
                IdentityManagerService = new Registration<IIdentityManagerService, DerivedAspNetIdentityManagerSvc>()
            };

            factory.Register(new Registration<DerivedIdentityDbContext>(r => new DerivedIdentityDbContext()));
            factory.Register(new Registration<DerivedUserManager>());
            factory.Register(new Registration<DerivedUserLogin>());
            factory.Register(new Registration<DerivedUserStore>());
            factory.Register(new Registration<DerivedRoleManager>());
            factory.Register(new Registration<DerivedRoleStore>());

            idm.UseIdentityManager(new IdentityManagerOptions
            {
                Factory = factory,
                SecurityConfiguration = new HostSecurityConfiguration()
                {
                    HostAuthenticationType = Constants.CookieAuthenticationType,
                    RequireSsl = false,
                    ShowLoginButton = false,
                    RoleClaimType = "http://schemas.microsoft.com/ws/2008/06/identity/claims/role"
                }
            });
        });
    }
}

I cant login that way. There is a claim in my userclaims table with claimtype "role" and claimvalue "IdentityManagerAdministrator" (the default value for the manager) just as the identitymanager saves it.
However if I set HostSecurityConfiguration temporarily to LocalhostSecurityConfiguration and visit the identity manager once and set it back I can still login unless I try it in incognito mode.

I just ran into this same issue and where the confusion for me was that I still needed to add the code to the login method that was in the Login.aspx page. Since I'm using the template that VS gave me (Webforms), it already gave me the boilerplate code of logging the user in. Since you created yours from scratch the disconnect came from me not knowing where to place my code for Owin authentication.
    protected void LogIn(object sender, EventArgs e)
    {
        if (IsValid)
        {
            // Validate the user password
            var manager = Context.GetOwinContext().GetUserManager<ApplicationUserManager>();
            var signinManager = Context.GetOwinContext().GetUserManager<ApplicationSignInManager>();

            // This doen't count login failures towards account lockout
            // To enable password failures to trigger lockout, change to shouldLockout: true
            var result = signinManager.PasswordSignIn(Email.Text, Password.Text, RememberMe.Checked, shouldLockout: false);

            switch (result)
            {
                case SignInStatus.Success:

                    var claims = new Claim[] {
                        new Claim("role", "Admin")
                    };

                    var id = new ClaimsIdentity(claims, "Cookies");

                    Request.GetOwinContext().Authentication.SignIn(id);

                    IdentityHelper.RedirectToReturnUrl(Request.QueryString["ReturnUrl"], Response);
                    break;
                case SignInStatus.LockedOut:
                    Response.Redirect("/Account/Lockout");
                    break;
                case SignInStatus.RequiresVerification:
                    Response.Redirect(String.Format("/Account/TwoFactorAuthenticationSignIn?ReturnUrl={0}&RememberMe={1}",
                                                    Request.QueryString["ReturnUrl"],
                                                    RememberMe.Checked),
                                      true);
                    break;
                case SignInStatus.Failure:
                default:
                    FailureText.Text = "Invalid login attempt";
                    ErrorMessage.Visible = true;
                    break;
            }
        }
    }

I'm not basing my claims on name and role but rather just on role because I wanted anyone with Admin status to be able to access the IdentityManager.  My code for the HostSecurityConfiguration was pretty much the same as yours except I omited the NameClaimType. I hope this helps anyone else that was also having difficulty integrating this into their template code created by VS.

That way you assign the admin role to every logged in user...
IdentityManager.AspNetIdentity 1.0.0-beta5-1 still gives me the same results.


ReloadPrompt example not functional

Hi there!
I've been going through the docs and got the pwa in react working, even if the sw it's pretty barebones it installs and activates as inteded, the issue I have is following the ReloadPrompt.tsx example within the docs . I tried to add a button to skipWaiting once the user chooses to install the new version but the current example does nothing of the sort.
I am having issues with this specifically:
 const {
    offlineReady: [offlineReady, setOfflineReady],
    needRefresh: [needRefresh, setNeedRefresh],
    updateServiceWorker,
  } = useRegisterSW({
    onRegistered(r) {
        // eslint-disable-next-line prefer-template
        console.log('SW Registered: ' + r)
    },
    onRegisterError(error) {
        console.log('SW registration error', error)
    },
  })

  const close = () => {
    setOfflineReady(false)
    setNeedRefresh(false)
  }

For starters, the function updateServiceWorker appears to be an empty promise, even if we call it nothing happens, secondly, the close function whenever we call it, it sets the value of need refresh to false but immediately logs that the SW got registered again and shows the prompt, I tried to encapsulate that within a useEffect so it would only run once but to no avail.
It detects corerctly when it needs to refresh whenever detects a new version, but reloading or using the updateServiceWorker function don't seem to do the trick.
Thanks!

you should call updateServiceWorker only when needRefresh is activated, otherwise the call does nothing.

Hey, thanks for the quick response.
But this is precisely what the example does (I ommited some code but it's verbatim the same as the example).
{ needRefresh && <button className="ReloadPrompt-toast-button" onClick={() => updateServiceWorker(true)}>Reload</button> }
When we needRefresh, the button appears correctly, I already tested that and the SW detects the new changes and is waiting for a reload, but then calling updateServiceWorker right here does nothing.

Check if you have some warning/error on the console about the service worker.
You can clone this repo and run pnpm install && pnpm run build, then pnpm run examples and select react + generateSW + prompt + no check for updates and open https://localhost, check that App ready to work offline is shown, then stop the server and rerun pnpm run example, select again the same options on the cli and once started F5 on the page again to check if working.

maybe it is related to #171: uninstall vite-plugin-pwa and install it again, you should use 0.11.8 version, we have fix some side effects.

Updating to 0.11.8 did the trick, thanks!


fix: division by zero bug in pdf partition

This PR resolves #1699

when check annotation within element first check if the annotation has an area > 0
if not the annotation is not considered part of the element and no need to compute the overlap over self ratio (so avoids division by zero)

This PR adds a unit test to the check_annotation_within_element function. Additionally the file provides in the issue ticket can be used as a test.

i think i am also fixing this: https://github.com/Unstructured-IO/unstructured/pull/1665 😅

i think i am also fixing this: #1665 😅

ah, in that case could you just cherry pick the tests to your PR then I can close this one

duplicates #1665


B 21042 prime create 3rd address

Agility ticket
PR 1
PR 2

Test coverage on client failed.
Last run: Mon 30 Sep 2024 05:35:47 PM UTC
Refer to this report to see coverage details for the client app.
Documentation for test coverage can be found at this link.

The difference in changes is in the prime_v3 generated swagger file. New generated changes are lines >=954

The difference in changes is in the prime_v3 generated swagger file. New generated changes are lines >=954

Found the PR that deleted them.
https://github.com/transcom/mymove/pull/13718#pullrequestreview-2373745167


Clean-up drafts of WebGL1 vs WebGL2

@foolip or @ddbeck - can I just get a super quick LGTM on this. It only affects the drafts of the WebGL & WebGL2 files. It'll make creating the actual WebGL stuff easier.

@petele merged! Just note that we'll update these drafts weekly (@tropicadri is working on that) so any manual changes risk being reverted unless other PRs land that use the BCD keys.

@petele merged! Just note that we'll update these drafts weekly (@tropicadri is working on that) so any manual changes risk being reverted unless other PRs land that use the BCD keys.

Got it - thanks. I'll work on it tomorrow, so hopefully I won't run into that issue.

#1502 has the workflow for updating weekly, waiting for review.


Fixed issue #52

Description
Executable used to run REST API tests is not cleared by using make clean
Fixes #52
Type of change
Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

Codecov Report

Merging #53 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   78.89%   78.89%
=======================================
  Files           7        7
  Lines         199      199
=======================================
  Hits          157      157
  Misses         35       35
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce01187...0375b2a. Read the comment docs.


Kythe: some minor style and performance fixes.

Codecov Report
Base: 93.01% // Head: 93.01% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (25b536d) compared to base (b89b343).
Patch coverage: 40.00% of modified lines in pull request are covered.

:exclamation: Current head 25b536d differs from pull request most recent head 8121c41. Consider uploading reports for the commit 8121c41 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1754      +/-   ##
==========================================
- Coverage   93.01%   93.01%   -0.01%
==========================================
  Files         352      352
  Lines       25511    25510       -1
==========================================
- Hits        23728    23727       -1
  Misses       1783     1783

Impacted Files
Coverage Δ

verilog/tools/kythe/indexing_facts_tree.cc
75.00% <ø> (-0.56%)
:arrow_down:

verilog/tools/kythe/indexing_facts_tree_context.h
100.00% <ø> (ø)

verilog/tools/kythe/kythe_facts_extractor.cc
35.08% <0.00%> (ø)

verilog/tools/kythe/scope_resolver.cc
83.33% <0.00%> (ø)

verilog/tools/kythe/kythe_facts_extractor.h
100.00% <100.00%> (ø)

verilog/tools/kythe/scope_resolver.h
91.66% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


/bin/sh -> ${stdenv.shell}

Motivation for this change
Use ${stdenv.shell} in pkgs/build-support and pkgs/servers.
Address a subset of https://github.com/NixOS/nixpkgs/issues/183, #1424.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Manually merged to master.


Browser caching works with interception enabled, but the documentation says it shouldn't

The documentation states:

NOTE Enabling request interception disables page caching.

However, this doesn't appear to actually be the case. I await chromePage.setRequestInterception(true) and log out cache activity:
    chromePage.on("response", resp => {
      console.log(
        "Received: " +
          resp.fromCache() +
          " " +
          resp.status() +
          " " +
          resp.url()
      );
    });

When I crawl the same page twice, my log reveals that cache is being used on the 2nd load for some resources (and for whom I res.continue() with no mutation), despite interception enabled:

Received: true 200 https://pro.fontawesome.com/releases/v5.1.0/css/all.css
Received: true 200 https://fonts.googleapis.com/css?family=Roboto:300,400,500

Am I mis-interpreting things, or should the documentation be updated to reflect that page caching will work w/ interception?

Similar stuff: #2905, pr#1154
Maybe the documentation should elaborate how the system is working?

On 1.12.2 setting request interception enabled does indeed disable caching for me. (unfortunately I don't really want it to 😢  )

Would it be possible for #2905 be re-opened, so that we can have both caching and request interception?


The AI suggested data for buildings keep appearing even with all buildings uploaded in the database

Description
For unkown reasons the AI suggested data keep appearing and overlying even that the buildings were validated and uploaded some changesets ago.
All green data shown in the attached screenshoot is already validated and uploaded in the OSM database.
This issue could produce duplicated data in the database
Screenshots

Version
2.2.2.
What browser are you seeing the problem on? What version are you running?
EDGE Version 120.0.2210.91 (Official build) (64-bit)
The OS you're using
Win10
Steps to reproduce
https://rapideditor.org/rapid#background=Bing&datasets=fbRoads,msBuildings&disable_features=boundaries&map=17.76/-18.43877/-64.93078&overlays=osm-gps&poweruser=true
The browser URL at the time you encountered the bug
https://rapideditor.org/rapid#background=Bing&datasets=fbRoads,msBuildings&disable_features=boundaries&map=17.76/-18.43877/-64.93078&overlays=osm-gps&poweruser=true
The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)
No response

Quick update on this - @Bonkles has been working on improving our internal conflation service to better handle issues talking to the OSM API.  We think this is the cause of seeing buildings that already exist in OSM.


Chinese document display error

Search before asking

[x] I searched the issues and found no similar issues.

What happened + What you expected to happen
If I directly access the Chinese link mentioned in the project README: https://alibaba.github.io/yalantinglibs/zh/guide/coro-rpc-intro.html
There is a problem with the Chinese documentation page

Reproduction way
https://alibaba.github.io/yalantinglibs/zh/guide/coro-rpc-intro.html
Anything else
Enter from the English interface and switch to the Chinese display correctly
Maybe you could simply delete the Chinese entrance？
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Yes, it's a known problem, but we are not familiar with web front end, hope some body can help to solve this problem.

There is a workaround way: change the language to English and then back to Chinese, the web page will recover normal.

ok, maybe I can help to fix this bug

it seemed because ".VPSidebar" is using position:fixed, and it use a fixed size of width in @media

Please try to fix it.

Could you please try to fix it?

I can also try to fix it. But I think the web page code is inside the folder zh/guide of the website, but you make them marked in .gitignore and i can not find where the error is.

have a try, I'm not familiar with vitepress and I'm reading the doc...

Could you please try to fix it?

I can also try to fix it. But I think the web page code is inside the folder zh/guide of the website, but you make them marked in .gitignore and i can not find where the error is.

https://github.com/alibaba/yalantinglibs/tree/doc/website

Sorry, i just saw the website but forget the doc, I'll try to fix it.
See who is faster (lol)

Could you please try to fix it?

I can also try to fix it. But I think the web page code is inside the folder zh/guide of the website, but you make them marked in .gitignore and i can not find where the error is.

https://github.com/alibaba/yalantinglibs/tree/doc/website

Get it, thx.
I'll try to fix it.

@SoTosorrow
the website is built by vitepress
and you can build the website in your own computer
Before build the website,
git, yarn, node are required.

clone the repo

git clone https://github.com/alibaba/yalantinglibs.git

checkout doc branch

cd yalantinglibs
git checkout doc

clone doxygen-awesome-css (for Doxygen)

https://github.com/jothepro/doxygen-awesome-css.git

install dependencies for vitepress

yarn install

generate website

bash gen_doc.sh

the script will copy all markdown files and images to website folder
then use yarn docs:build and doxygen Doxyfile generate html

the config of vitepress is website/.vitepress/config.ts
the config of doxygen is Doxyfile and Doxyfile_cn

the config of vitepress is website/.vitepress/config.ts the config of doxygen is Doxyfile and Doxyfile_cn

Get it

Did you fix the bug? I think it might be a bug from vitepress...
Anyway it seems correct in my fork website: https://luzhixing12345.github.io/yalantinglibs/
and directly get https://luzhixing12345.github.io/yalantinglibs/zh/guide/coro-rpc-intro.html

By the way, I fix this bug by simply copying the correct html page, so if someone who generates the docs/ as website build, the same bug will appear
I hope someone can solve this bug from the root

Did you fix the bug? I think it might be a bug from vitepress... Anyway it seems correct in my fork website: https://luzhixing12345.github.io/yalantinglibs/ and directly get https://luzhixing12345.github.io/yalantinglibs/zh/guide/coro-rpc-intro.html

I haven't finished it yet. This is the first time I use doxygen and vitepress. I used to use vue/vanilla-js to write the web front page.
It's strange that Chinese and English are inconsistent in the sidebar, and it may be a bug

I just discovered the css problem. The label whose id is VPContent on the zh/guide page is missing the class has-sidebar. If you add it, you can fix the style problem.
such as zh/guide/coro-rpc-intro.html

I just discovered the css problem. The label whose id is VPContent on the zh/guide page is missing the class has-sidebar. If you add it, you can fix the style problem.
such as zh/guide/coro-rpc-intro.html

@qicosmos @PikachuHyA @luzhixing12345 there is a simple way, i can provide a script (append on gen_doc.sh) to complete missing styles after generate html, It will not affect other files for now.

there is a simple way, i can provide a script (append on gen_doc.sh) to complete missing styles

please submit PR and I will update the website after PR merged. thanks

I completed a version first, traversing the html files under docs/zh and modifying the missing class. It runs normally locally. I will submit a PR later, you can take a look.

there is a simple way, i can provide a script (append on gen_doc.sh) to complete missing styles

please submit PR and I will update the website after PR merged. thanks

I completed a simple version first, traversing the html files under docs/zh and modifying the missing class. It runs normally locally. I will submit a PR later, you can take a look.

run failed on MacOS 13.1？

run failed on MacOS 13.1？

https://unix.stackexchange.com/questions/663369/invalid-command-code-using-sed-to-replace-characters-inline

New problem: click the left menu item, the page not refresh!

New problem: click the left menu item, the page not refresh!

This should be the original problem, I did not click to refresh before

Did you fix the bug? I think it might be a bug from vitepress... Anyway it seems correct in my fork website: https://luzhixing12345.github.io/yalantinglibs/ and directly get https://luzhixing12345.github.io/yalantinglibs/zh/guide/coro-rpc-intro.html

Should I submit a PR as an interim version of the docs...?

Did you fix the bug? I think it might be a bug from vitepress... Anyway it seems correct in my fork website: https://luzhixing12345.github.io/yalantinglibs/ and directly get https://luzhixing12345.github.io/yalantinglibs/zh/guide/coro-rpc-intro.html

Should I submit a PR as an interim version of the docs...?

I still think it is a bug of vitepress, because it is normal to enter or jump from the en version, and the zh version has these problems,you copy the en html to replace the zh html and then no these bug.
Theoretically, what is generated is consistent of zh and en

你修复了这个错误吗？我认为这可能是 vitepress 的一个错误......无论如何它在我的 fork 网站上似乎是正确的： https: //luzhixing12345.github.io/yalantinglibs/并直接获取https://luzhixing12345.github.io/yalantinglibs/zh/指南/coro-rpc-intro.html

我应该提交 PR 作为文档的临时版本......？

我还是觉得是vitepress的bug，因为en版的进入或者跳转都是正常的，而zh版有这些问题，你复制en html替换zh html就没有这些bug了。 理论上生成的zh和en是一致的

Agree. There may be a bug in docs:build, and this issue should probably be handed over to vitepress

Did you fix the bug? I think it might be a bug from vitepress... Anyway it seems correct in my fork website: https://luzhixing12345.github.io/yalantinglibs/ and directly get https://luzhixing12345.github.io/yalantinglibs/zh/guide/coro-rpc-intro.html

Should I submit a PR as an interim version of the docs...?

I still think it is a bug of vitepress, because it is normal to enter or jump from the en version, and the zh version has these problems,you copy the en html to replace the zh html and then no these bug. Theoretically, what is generated is consistent of zh and en

Agree. There may be a bug in docs:build and this issue should probably be handed over to vitepress.

New problem: click the left menu item, the page not refresh!

I will try to solve it later, it may be the Chinese support problem of vitepress, I will try to modify the configuration of vitepress instead of using shell. In addition, does the problem of sed on mac need to be fixed?

I think the problem on mac has been solved.
Please help to fix the current problem.

Should I submit a PR as an interim version of the docs...?

@luzhixing12345

modify the configuration of vitepress

@SoTosorrow
feel free to submit PR to docs branch

I think the problem on mac has been solved. Please help to fix the current problem.

I tried to upgrade the version of viteepress and modified the config.ts, and the problem of style and refresh did not reappear in my local. I will submit the pr after I confirm the configuration is correct.

I tried to modified the config.ts, and the problem of style and refresh did not reappear in my local.

run on local with yarn docs:dev has no such problem
however, when I deploy the release version with yarn docs:build, the problem occurred.
weird

I tried to modified the config.ts, and the problem of style and refresh did not reappear in my local.

run on local with yarn docs:dev has no such problem however, when I deploy the release version with yarn docs:build, the problem occurred. weird

I did not use yarn docs:build, but directly ./gen_sh.sh and take the generate docs. mayebe you can just forget the yarn build?

I tried to modified the config.ts, and the problem of style and refresh did not reappear in my local.

run on local with yarn docs:dev has no such problem however, when I deploy the release version with yarn docs:build, the problem occurred. weird

I never using yarn docs:build alone, I just directly run ./gen_doc.sh (it is already include the yarn build),
I put my generate file to my server
there is the link http://<IP_ADDRESS>:9000/docs/zh/guide/struct-pack-intro.html

I tried to modified the config.ts, and the problem of style and refresh did not reappear in my local.

run on local with yarn docs:dev has no such problem however, when I deploy the release version with yarn docs:build, the problem occurred. weird

Did you run yarn docs:build/dev again after bash ./gen_doc.sh?

can you deploy the website to GitHub Page?
https://pages.github.com/
then we can test the website by https://SoTosorrow.github.io/yalantinglibs/

can you deploy the website to GitHub Page? https://pages.github.com/
then we can test the website by https://SoTosorrow.github.io/yalantinglibs/

Done, you can check it.

Done, you can check it.

good job
I think I delete some code by mistake.
could you submit a new PR (including all html files) to docs branch ?

Done, you can check it.

good job
I think I delete some code by mistake.
could you submit a new PR (including all html files) to docs branch ?

Yes, have submit on #226

👏👏👏👏

👏👏👏👏

you can run gen_doc.sh again to check if it works correctly in your environment.
I can also optimize the gen_doc.sh or supplement the documentation later if you need
by the way, Do these changes of config need to be merged into the main branch?

@luzhixing12345 you can check the doc for current version, all these problems I think it is actually the reason of the config syntax does not match the version of vitepress.

by the way, Do these changes of config need to be merged into the main branch?

Done.


Actually Perform the Cleanup of Checks

Summary
It was discovered that the cleanup of Checks was not implemented. This PR adds this missing functionality.
Closes #393

Checklist

[x] Keep pull requests small so they can be easily reviewed.
[x] Categorize the PR by setting a good title and adding one of the labels:
bug, enhancement, documentation, change, breaking,
as they show up in the changelog
[ ] Update the documentation.
[x] Update tests.
[x] Link this PR to related issues.

@tobru I've requested your review as I updated the GoLand instructions in the docs.

@ccremer I think codeclimate's duplicate code issue is not worth the effort, because the core part of the deduplication logic is already extracted to a common place. The part which is supposedly duplicated is the code that prepares the data structures to leverage the deduplication function. Because of Go's type system, it looks like an exact copy, yet it isn't.
WDYT?

It strikes me as weird that the diff-coverage did not increase at all, since I've added tests that cover code not tested before 🤔  Is integrationtest coverage perhaps not reported correctly?

Because of Go's type system, it looks like an exact copy, yet it isn't.

In CodeClimate UI, you can mark this issue as invalid or wontfix with your reasoning. then it becomes green and should be saved for later PRs as well.

It strikes me as weird that the diff-coverage did not increase at all, since I've added tests that cover code not tested before :thinking: Is integrationtest coverage perhaps not reported correctly?

I'd recommend to run make integration-test once in current master branch and then compare with your PR. you could also run all integration tests with GoLand with Coverage enabled to see which parts of the code gets executed and which not. It's possible that some other integration test is going through the same code locations already, but it still shouldn't be 0% I guess...
Be aware that code coverage in Goland is not calculated the same as gotest but it may give some clue.

In CodeClimate UI, you can mark this issue as invalid or wontfix with your reasoning. then it becomes green and should be saved for later PRs as well.

I'm afraid, I don't have these privileges.

I'd recommend to run make integration-test once in current master branch and then compare with your PR.

It increases form 30% to 38%.

you could also run all integration tests with GoLand with Coverage enabled

For controllers/check.go, it increases from 0% to 60%.
I think that's a good-enough ratio :)

The coverage is indeed strange...
well, what matters is that we have a working test case :)


Drag file and drop in editor causing crash in linux wayland

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.67.0-insider 345f572e37ca69dc143c9fecb5f851fba9fcce8c
OS Version: Arch Linux, GNOME 42, Wayland

Steps to Reproduce:

Launch VSCode with code-insiders  --ozone-platform=wayland
Open a folder
Drag a file from left explorer bar to the main editor.
VSCode window disappears.

https://user-images.githubusercontent.com/28442838/162031117-c6e2df25-abb0-490c-bf29-f54469797c9c.mp4
log.txt
The last bit of the log seems to similar to https://github.com/microsoft/vscode/issues/146349

The bug is caused by a change in GNOME 42 and will resolve with https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2335

Thanks for tracking the root issue, closing as the issue is not from core.

@deepak1556 Looks like this is actually a bug here? The gnome commit says they are reverting that change for now until all clients are updated. In the future it will cause problems


Bump minor version

This PR bumps the version numbers so they match the next release.
Please verify the version numbers are correct, and update the CHANGELOG manually.
Checklist

[ ] Version numbers are correct
[ ] CHANGELOG.md has been updated

Closing since this release was skipped.


Use the X.509 typography instead of "x509"

Looks like we started using the "x509" typography everywhere, but shouldn't we use "X.509" instead as started in RFC 5280 😅
I went with a quick PCRE which replaces all occurrences of x509 except when it is used in the context of openssl x509
perl -pi~ -n -e 's/(?<!openssl )x509/X.509/g' content/en/**/*.md && rm content/en/**/*.md~

Since I could not find a proper way of fixing .spelling so that it would only check spelling for non-generated documentation, I went with a quick PCRE:
perl -pi~ -n -e 's/(?<!openssl )x509/X.509/g' content/en/**/*.md && rm content/en/**/*.md~

It replaces all occurrences of x509 except when it is used in the context of openssl x509.

/hold
/lgtm

/lgtm

/cancel hold

/hold cancel


Add support for binary and varbinary columns

SqlBulkInsert needs a byte[] column to be able to insert into a binary or varbinary column

I've merged this and released on NuGet as 3.8.3

:+1:


[DOC] Create a new article about "how to use bpmnVisualizationR"

The bpmnVisualization has been renamed, so the former article is no more accurate

based on https://medium.com/@process-analytics/using-bpmn-visualization-in-r-91ab92bd5a8d
due to the renaming to the package, the code is obsolete.
add a warning in the old article and point to the new one

I suggest that we adapt the code example of the previous article as a more advanced getting started article.
Its goal would be to create the same rendering of the image of the README of the repository as also suggested in #157. This will create a fresher content and will reuse documentation content.


RENAME HEADERS

some headers are included as #include <QtAVPlayer/headername> instead of #include "headername"

<QtAVPlayer/headername>
it is qt standard to include public headers, from module.

I know that, from your source code it is not important to do that since the module doesn't exist yet.

could not understand where is the issue here

#include <QtAVPlayer/headername> won't compile because QtAVPlayer does not exist yet, just change all the includes to #include "headername" in all your sources because the header files exist in the same directory , it is tedious work but it is worth it.

do you use files outside of the module?
when you build the module, all files will be installed by syncqt

do you use files outside of the module? when you build the module, all files will be installed by syncqt

That is not the issue, the issue is that you can't #include <QtAVPlayer/headername> during building , that can only be done after building the module , replace all #include <QtAVPlayer/headername> with #include "headername" in all your sources because the header files exist in the same directory

first you need to build the module. after that you can use headers outside.
Inside module it works correctly, otherwise nothing would be built.

first you need to build the module. after that you can use headers outside. Inside module it works correctly, otherwise nothing would be built.

you have already included the #include <QtAVPlayer/headername> in the module that's what i am requesting you to replace with #include "headername" in all your sources because the header files exist in the same directory

for instance look at qavframe.h
#ifndef QAVFRAME_H
#define QAVFRAME_H
#include
#include
#include
#include <QtAVPlayer/qtavplayerglobal.h>
extern "C" {
#include <libavutil/frame.h>
}
you can't include #include <QtAVPlayer/qtavplayerglobal.h> and it doesn't compile just replace it with #include "qtavplayerglobal.h"

show me the error what you received and how you used it.

the error is simple #include <QtAVPlayer/qtavplayerglobal.h> not found but when i replace with #include "qtavplayerglobal.h" it compiles successfully, the problem with you is that you have already installed QtAVPlayer so the error will never appear, now put yourself in the shoes of a person compiling the project for the first time , just compile time errors , quite discouraging isn't it? It is also not good idea to do so.

if it is not found, means something went wrong.
there are some CI github actions, https://github.com/valbok/QtAVPlayer/pull/192/checks
as you can see even on empty, clean env it is compiled and tested.
Because when you call "make" of module, it will call syncqt which will copy all public headers to the module's path.
maybe you forget to call make install if you build with standalone Qt.


build(knapsack): fixing knapsack deploy

Description
fixing the knapsack build when using the NX commands
Test Steps

[ ] run npx nx run knapsack:build
[ ] run npx nx run knapsack:serve
[ ] verify the site comes up!

General Tests for Every PR

[ ] npm run start still works.
[ ] npm run lint passes.
[ ] npm run stylelint passes.
[ ] npm test passes and code coverage is not lower.
[ ] npm run build still works.

:tada: This PR is included in version 8.2.1 :tada:
The release is available on:

v8.2.1
GitHub release

Your semantic-release bot :package::rocket:


adding i4i, im4gn, is4gen and storage maps

Adding the i4i, im4gn, is4gen machine types to the block device manager for the use of things like the below.
- cloud_properties:
    instance_type: i4i.large
    use_instance_storage: true
  name: ds.i4i.large
- cloud_properties:
    ephemeral_disk:
      size: 25000
      type: gp3
    instance_type: i4i.large
  name: i4i.large

Tested manually through bosh director of using zookeeper with both instance types above
Unit tests all passed locally.
Tested with basic test with zookeeper.
./bin/test-unit ran and passed.
To use the use_instance_storage properly you have to add the map per instance type and pulled them from here - https://aws.amazon.com/ec2/instance-types/i4i/ and here https://aws.amazon.com/ec2/instance-types/i4g/.

Example below.
instance_groups:
- name: zookeeper
  azs: [z1, z2, z3]
  instances: 1
  jobs:
  - name: zookeeper
    release: zookeeper
    provides:
      conn: {shared: true}
    properties: {}
  - name: status
    release: zookeeper
    properties: {}
  vm_type: ds.i4i.large
  stemcell: default
  persistent_disk: 10240
  networks:
  - name: default`

The only thing I've not been able to verify is the arm vm types through my tests.  Currently looking for a better way to do this or verify seeing that there's other arm machines already in the mix.
Test below with a i4i.large.

Seeing that graviton/arm is a bit of a pain or non issue, should I add these to the PR or stick to i4i and leave it there?

Bosh does not support ARM, Someone at some point got it working but it has never been contributed upstream.
https://itq.eu/first-ever-cloud-foundry-running-on-arm/

I can just pull those VMs, I wasn't 100% sure, I saw previous arm vms in there and thought that was a bit weird so i figured that maybe someone had done it so I started digging around.

I pulled the graviton machines to avoid confusion.


Update ingress-basic.md

Fixed procedure to uninstall helm ingress-nginx.

@demcost : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@demcost : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thank you for the feedback!
The uninstall command is consistent with the name used for the install command.
We have added a task to our backlog to consider changing the name for both and will prioritize accordingly.
#please-close


Add-Migration Does Nothing

I added Microsoft.EntityFrameworkCore.Tools to my project, used the Package Manager Console, selected the Default Project which contains my context and typed "Add-Migration Initial".
Nothing happens, I just get a new command prompt, nothing is created, no error messages displayed.

Possible duplicate of #10298
Can you share details of dotnet/ef tools versions? Project type?

Microsoft.EntityFrameworkCore.Tools v2.0.1
.NET Core v.2.0.0
Project Type: class library .NET Core

Adding the work around line "true" mentioned in #10298 to the project file got me an error message finally (cannot find appsettings.json).

Another issue noticed though, I have to have the project with the DatabaseContext selected as the startup project in order to get the migration tool to not fail with a "could not load assembly" error.  I've never needed to do this in the past.

i got the same issue please can anyone help me?

@dmuino1986 Update EF Core pacakges to version 2.0.2.

thanks bricelam it work


HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths.

Whenever the blocks of the file are read from the file system, they are cached into the block-cache if cache-on-read configuration is enabled. This configuration is enabled by default. However, with the time-based priority caching, we may not want to cache the blocks of the cold file.
In this PR, we add checks to avoid the caching of cold data files and cache the blocks of hot data files.
Change-Id: Ia07d791a841640e468c3ba33acebba81dbecbbc2

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 13s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
2m 38s
HBASE-28463 passed

+1 :green_heart:
compile
0m 40s
HBASE-28463 passed

+1 :green_heart:
shadedjars
5m  8s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 26s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 28s
the patch passed

+1 :green_heart:
compile
0m 44s
the patch passed

+1 :green_heart:
javac
0m 44s
the patch passed

+1 :green_heart:
shadedjars
5m 12s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
the patch passed

_ Other Tests _

-1 :x:
unit
11m 33s
hbase-server in the patch failed.

31m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5905

JIRA Issue
HBASE-28467

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 096b39352138 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 4dee5324ae

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/1/testReport/

Max. process+thread count
1746 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 50s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
4m 51s
HBASE-28463 passed

+1 :green_heart:
compile
3m 10s
HBASE-28463 passed

+1 :green_heart:
checkstyle
0m 43s
HBASE-28463 passed

+1 :green_heart:
spotless
0m 52s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 50s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 59s
the patch passed

+1 :green_heart:
compile
3m  6s
the patch passed

+1 :green_heart:
javac
3m  6s
the patch passed

+1 :green_heart:
checkstyle
0m 43s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
6m  8s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
1m 17s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 47s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 22s
The patch does not generate ASF License warnings.

40m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5905

JIRA Issue
HBASE-28467

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 561c5a2beed6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 4dee5324ae

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 54s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
4m 49s
HBASE-28463 passed

+1 :green_heart:
compile
1m  3s
HBASE-28463 passed

+1 :green_heart:
shadedjars
6m 55s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 55s
the patch passed

+1 :green_heart:
compile
0m 57s
the patch passed

+1 :green_heart:
javac
0m 57s
the patch passed

+1 :green_heart:
shadedjars
6m 31s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 28s
the patch passed

_ Other Tests _

-1 :x:
unit
17m  2s
hbase-server in the patch failed.

45m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5905

JIRA Issue
HBASE-28467

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux aed7ea3fd1ab 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 4dee5324ae

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/1/testReport/

Max. process+thread count
1857 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
3m 51s
HBASE-28463 passed

+1 :green_heart:
compile
2m 50s
HBASE-28463 passed

+1 :green_heart:
checkstyle
0m 38s
HBASE-28463 passed

+1 :green_heart:
spotless
0m 48s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 49s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m  8s
the patch passed

+1 :green_heart:
compile
2m 39s
the patch passed

+1 :green_heart:
javac
2m 39s
the patch passed

-0 :warning:
checkstyle
0m 45s
hbase-server: The patch generated 3 new + 7 unchanged - 0 fixed = 10 total (was 7)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
5m 30s
Patch does not cause any errors with Hadoop 3.3.6.

-1 :x:
spotless
0m 49s
patch has 36 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
2m  3s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

33m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5905

JIRA Issue
HBASE-28467

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 343af69b743f 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 4dee5324ae

Default Java
Eclipse Adoptium-11.0.17+8

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/2/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
81 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 20s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
3m  2s
HBASE-28463 passed

+1 :green_heart:
compile
1m  1s
HBASE-28463 passed

+1 :green_heart:
shadedjars
6m 54s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 28s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m  2s
the patch passed

+1 :green_heart:
compile
0m 57s
the patch passed

+1 :green_heart:
javac
0m 57s
the patch passed

+1 :green_heart:
shadedjars
6m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 31s
the patch passed

_ Other Tests _

-1 :x:
unit
14m 49s
hbase-server in the patch failed.

38m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5905

JIRA Issue
HBASE-28467

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux cc84187b8e74 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 4dee5324ae

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/2/testReport/

Max. process+thread count
1765 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
3m 34s
HBASE-28463 passed

+1 :green_heart:
compile
0m 54s
HBASE-28463 passed

+1 :green_heart:
shadedjars
6m 45s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 30s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 14s
the patch passed

+1 :green_heart:
compile
1m  4s
the patch passed

+1 :green_heart:
javac
1m  4s
the patch passed

+1 :green_heart:
shadedjars
5m 57s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 32s
the patch passed

_ Other Tests _

-1 :x:
unit
18m 34s
hbase-server in the patch failed.

43m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5905

JIRA Issue
HBASE-28467

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 89676b529209 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 4dee5324ae

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/2/testReport/

Max. process+thread count
2076 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
4m  4s
HBASE-28463 passed

+1 :green_heart:
compile
3m  9s
HBASE-28463 passed

+1 :green_heart:
checkstyle
0m 47s
HBASE-28463 passed

+1 :green_heart:
spotless
0m 58s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 54s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 37s
the patch passed

+1 :green_heart:
compile
2m 53s
the patch passed

+1 :green_heart:
javac
2m 53s
the patch passed

+1 :green_heart:
checkstyle
0m 41s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
6m 24s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
0m 52s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  3s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

36m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5905

JIRA Issue
HBASE-28467

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 51880eafed52 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 4dee5324ae

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/3/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 51s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
4m 22s
HBASE-28463 passed

+1 :green_heart:
compile
1m  9s
HBASE-28463 passed

+1 :green_heart:
shadedjars
7m 42s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  6s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

+1 :green_heart:
shadedjars
7m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
the patch passed

_ Other Tests _

-1 :x:
unit
23m  1s
hbase-server in the patch failed.

52m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5905

JIRA Issue
HBASE-28467

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6da0461684b9 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 4dee5324ae

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/3/testReport/

Max. process+thread count
2009 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
2m 23s
HBASE-28463 passed

+1 :green_heart:
compile
0m 37s
HBASE-28463 passed

+1 :green_heart:
shadedjars
5m 37s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 22s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 23s
the patch passed

+1 :green_heart:
compile
0m 37s
the patch passed

+1 :green_heart:
javac
0m 37s
the patch passed

+1 :green_heart:
shadedjars
5m 36s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 22s
the patch passed

_ Other Tests _

-1 :x:
unit
11m 37s
hbase-server in the patch failed.

31m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5905

JIRA Issue
HBASE-28467

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f59ff1d82aa0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 4dee5324ae

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/4/testReport/

Max. process+thread count
1861 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
24m 53s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
14m 58s
HBASE-28463 passed

+1 :green_heart:
compile
3m 32s
HBASE-28463 passed

+1 :green_heart:
checkstyle
1m  9s
HBASE-28463 passed

+1 :green_heart:
spotless
1m 30s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
3m  0s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 20s
the patch passed

+1 :green_heart:
compile
3m 24s
the patch passed

+1 :green_heart:
javac
3m 24s
the patch passed

+1 :green_heart:
checkstyle
0m 48s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
10m 51s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
1m  4s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

87m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5905

JIRA Issue
HBASE-28467

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 8a16125214fc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 4dee5324ae

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/4/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
2m 48s
HBASE-28463 passed

+1 :green_heart:
compile
0m 39s
HBASE-28463 passed

+1 :green_heart:
shadedjars
5m 38s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 22s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 23s
the patch passed

+1 :green_heart:
compile
0m 39s
the patch passed

+1 :green_heart:
javac
0m 39s
the patch passed

+1 :green_heart:
shadedjars
5m 36s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 22s
the patch passed

_ Other Tests _

-1 :x:
unit
11m 36s
hbase-server in the patch failed.

32m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5905

JIRA Issue
HBASE-28467

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 8a48a24527f0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / c3923459ef

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/5/testReport/

Max. process+thread count
1874 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  1s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
5m 50s
HBASE-28463 passed

+1 :green_heart:
compile
3m 27s
HBASE-28463 passed

+1 :green_heart:
checkstyle
0m 41s
HBASE-28463 passed

+1 :green_heart:
spotless
0m 52s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 55s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  5s
the patch passed

+1 :green_heart:
compile
3m 21s
the patch passed

+1 :green_heart:
javac
3m 21s
the patch passed

+1 :green_heart:
checkstyle
0m 44s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
6m 33s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
1m 19s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 19s
The patch does not generate ASF License warnings.

43m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5905

JIRA Issue
HBASE-28467

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 63c283a453a6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / c3923459ef

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/5/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  3s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
5m 41s
HBASE-28463 passed

+1 :green_heart:
compile
1m 13s
HBASE-28463 passed

+1 :green_heart:
shadedjars
6m 59s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 56s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

+1 :green_heart:
shadedjars
6m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 29s
the patch passed

_ Other Tests _

-1 :x:
unit
17m 16s
hbase-server in the patch failed.

46m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5905

JIRA Issue
HBASE-28467

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 496c592ebd70 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / c3923459ef

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/5/testReport/

Max. process+thread count
1840 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 58s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
5m 13s
HBASE-28463 passed

+1 :green_heart:
compile
3m 31s
HBASE-28463 passed

+1 :green_heart:
checkstyle
0m 42s
HBASE-28463 passed

+1 :green_heart:
spotless
0m 52s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 57s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 12s
the patch passed

+1 :green_heart:
compile
3m 23s
the patch passed

+1 :green_heart:
javac
3m 23s
the patch passed

+1 :green_heart:
checkstyle
0m 40s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
6m 25s
Patch does not cause any errors with Hadoop 3.3.6.

-1 :x:
spotless
1m 18s
patch has 1 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
2m 48s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

42m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5905

JIRA Issue
HBASE-28467

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 5609af4872ee 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 7527a74ef1

Default Java
Eclipse Adoptium-11.0.17+8

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/6/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
80 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/6/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
2m 42s
HBASE-28463 passed

+1 :green_heart:
compile
0m 37s
HBASE-28463 passed

+1 :green_heart:
shadedjars
5m 37s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 24s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 25s
the patch passed

+1 :green_heart:
compile
0m 39s
the patch passed

+1 :green_heart:
javac
0m 39s
the patch passed

+1 :green_heart:
shadedjars
5m 38s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 23s
the patch passed

_ Other Tests _

-1 :x:
unit
315m  7s
hbase-server in the patch failed.

340m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5905

JIRA Issue
HBASE-28467

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3d6b4d6a738d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 7527a74ef1

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/6/testReport/

Max. process+thread count
4666 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5905/6/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


How to change contentContainerStyle global?

How to change contentContainerStyle for Content component for the whole of my project?
Now I need to add the prop contentContainerStyle to any Content in each screen.

You can create your own CustomContent from Content with the required contentContainerStyle and use it wherever you need in your project

@shivrajkumar
Ok, thank you. This solution is suitable for me.


Custom username can weaken TOTP authentication

Hi,
I noticed that OpenVPN correctly uses the Certificate CN as username for authentication. However the TOTP-plugin seem to use the user-provided username. An 'disgruntled employee' attacker could steal someone's certificate and use his personal TOTP-code to authenticate.  I believe in the logs it will still show 'ChessSpider'  as username, making this an impersonating attack. (Unless someone notices the used totp username)
E.g. imagine disgruntled_employee stole my certificate, he can login using his own totp.
openvpn    | Tue May 30 15:08:18 2017 us=171846 [ip]:65211 VERIFY OK: depth=1, CN=vpn.example.com
openvpn    | Tue May 30 15:08:18 2017 us=175749 [ip]:65211 VERIFY OK: depth=0, CN=ChessSpider
.......
openvpn    | AUTH-PAM: BACKGROUND: received command code: 0
openvpn    | AUTH-PAM: BACKGROUND: USER: disgruntled_emplyee

I believe the script /etc/pam.d/openvpn needs to be this:
bash-4.3# cat /etc/pam.d/openvpn
# Uses google authenticator library as PAM module using a single folder for all users tokens
# User root is required to stick with an hardcoded user when trying to determine user id and allow unexisting system users
# See https://github.com/google/google-authenticator/tree/master/libpam#secretpathtosecretfile--usersome-user
auth required pam_google_authenticator.so secret=/etc/openvpn/otp/${COMMON_NAME}.google_authenticator user=root

# Accept any user since we're dealing with virtual users there's no need to have a system account (pam_unix.so)
account sufficient pam_permit.so

The current version uses ${USER} , and I changed it to ${COMMON_NAME} (on line 5). I haven't been able to test this yet, but it should be a valid variable after finding out all environment variables by starting openvpn with verb 7 in server-side ```openvpn.conf```` .
I'll continue looking at it tomorrow,
Cheers,

As a side-note, I have also been looking at a way to make openvpn check if the certificate CN matches the user-supplied username. But I haven't found that yet.
If it does by default then this attack is mitigated (I so far only theorized it). But yeah, it doesn't seem so as it goes to the PAM-step after verifying the certificate.

The bypass sounds plausible based on what you described, but I don't use TOTP directly to comment any more beyond that. I would be interested in seeing a test case (see the /test/tests/otp directory) for this bypass.

Yeah no worries. I also wonder what would happen if the user chooses as username:
foobar secret=None nullok #
or something similar, which should expand to:
auth required pam_google_authenticator.so secret=/etc/openvpn/otp/foobar secret=None nullok #.google_authenticator user=root
The nullok option allows users to login without having setup totp ( see https://github.com/google/google-authenticator-libpam )
but again just thinking out loud. I'll do some testing tomorrow.

Hi, just reporting back.
I think my TOTP I described previously is not possible. This is because ${USER} is being replaced by the username inside the module as opposed to (when parsing) the service-definition. So that's a good thing!  I guess it may be possible use usernames like .../.../whatever but there doesn't seem to be a '.google_authenticator' file on the system which accepts any and all verification codes. Maybe there's stuff possible with inserting null bytes but at the end of the day the bug needs to be fixed.
I managed to fix the problem by changing the openvpn.conf to:
plugin /usr/lib/openvpn/plugins/openvpn-plugin-auth-pam.so "openvpn login COMMONNAME verification PASSWORD"
This overrides the default 'login' to return COMMONNAME instead of  USERNAME. See https://github.com/OpenVPN/openvpn/blob/master/src/plugins/auth-pam/README.auth-pam:

For example:
plugin openvpn-auth-pam.so "login login USERNAME password PASSWORD"
tells auth-pam to (a) use the "login" PAM module, (b) answer a "login" query with the username given by the OpenVPN client, and (c) answer a "password" query with the password given by the OpenVPN client.

The /etc/pam.d/openvpn file can stay the same.
I'll have a quick look at the tests too, but I also want to get this VPN up and running as I do like the image you made 👍  Quick, to the point and properly documented

Steps to reproduce:
Setup basic infra

docker run  --net=none --rm -t -i --log-driver=none -v `pwd`/data:/etc/openvpn --rm kylemanna/openvpn ovpn_genconfig -u udp://vpn.jamious.com -2  -C 'AES-256-CBC' -a 'SHA384'
docker run -e EASYRSA_ALGO=ec -e EASYRSA_CURVE=secp384r1 -e EASYRSA_KEY_SIZE=4096 -e EASYRSA_CRL_DAYS=3650 -v /dev/random:/dev/random -v /dev/urandom:/dev/urandom -v `pwd`/data:/etc/openvpn --rm -it kylemanna/openvpn ovpn_initpki

Create user ChessSpider

docker run --log-driver=none  -e EASYRSA_ALGO=ec -e EASYRSA_CURVE=secp384r1 -e EASYRSA_KEY_SIZE=4096 -v /dev/random:/dev/random -v /dev/urandom:/dev/urandom -v pwd/data:/etc/openvpn --rm -it kylemanna/openvpn easyrsa build-client-full chessspider
docker run --log-driver=none -v pwd/data:/etc/openvpn --rm -t kylemanna/openvpn ovpn_otp_user chessspider
docker run --log-driver=none  -v pwd/data:/etc/openvpn --rm kylemanna/openvpn ovpn_getclient chessspider > chessspider.ovpn

Create user disguntled_employee

docker run --log-driver=none  -e EASYRSA_ALGO=ec -e EASYRSA_CURVE=secp384r1 -e EASYRSA_KEY_SIZE=4096 -v /dev/random:/dev/random -v /dev/urandom:/dev/urandom -v pwd/data:/etc/openvpn --rm -it kylemanna/openvpn easyrsa build-client-full disgruntled_employee
docker run --log-driver=none -v pwd/data:/etc/openvpn --rm -t kylemanna/openvpn ovpn_otp_user disgruntled_employee
docker run --log-driver=none  -v pwd/data:/etc/openvpn --rm kylemanna/openvpn ovpn_getclient disgruntled_employee > disgruntled_employee.ovpn

Start & Connect

Start the OpenVPN service with the above config
Connect w/ certificate of ChessSpider and in the login-box of OpenVPN enter disgruntled_employee and its generated TOTP code.
You should see something like the output below

debug log before changes:
openvpn    | Wed May 31 11:16:23 2017 [ip]:59081 VERIFY OK: depth=1, CN=vpn.example.com
openvpn    | Wed May 31 11:16:23 2017 [ip]:59081 VERIFY OK: depth=0, CN=chessspider
openvpn    | Wed May 31 11:16:23 2017 [ip]:59081 peer info: IV_VER=2.4.2
openvpn    | Wed May 31 11:16:23 2017 [ip]:59081 peer info: IV_PLAT=win
openvpn    | Wed May 31 11:16:23 2017 [ip]:59081 peer info: IV_PROTO=2
openvpn    | Wed May 31 11:16:23 2017 [ip]:59081 peer info: IV_NCP=2
openvpn    | Wed May 31 11:16:23 2017 [ip]:59081 peer info: IV_LZ4=1
openvpn    | Wed May 31 11:16:23 2017 [ip]:59081 peer info: IV_LZ4v2=1
openvpn    | Wed May 31 11:16:23 2017 [ip]:59081 peer info: IV_LZO=1
openvpn    | Wed May 31 11:16:23 2017 [ip]:59081 peer info: IV_COMP_STUB=1
openvpn    | Wed May 31 11:16:23 2017 [ip]:59081 peer info: IV_COMP_STUBv2=1
openvpn    | Wed May 31 11:16:23 2017 [ip]:59081 peer info: IV_TCPNL=1
openvpn    | Wed May 31 11:16:23 2017 [ip]:59081 peer info: IV_GUI_VER=OpenVPN_GUI_11
openvpn    | Wed May 31 11:16:23 2017 [ip]:59081 PLUGIN_CALL: POST /usr/lib/openvpn/plugins/openvpn-plugin-auth-pam.so/PLUGIN_AUTH_USER_PASS_VERIFY status=0
openvpn    | Wed May 31 11:16:23 2017 [ip]:59081 TLS: Username/Password authentication succeeded for username 'disgruntled_employee'
openvpn    | Wed May 31 11:16:24 2017 [ip]:59081 Control Channel: TLSv1.2, cipher TLSv1/SSLv3 ECDHE-ECDSA-AES256-GCM-SHA384
openvpn    | Wed May 31 11:16:24 2017 [ip]:59081 [chessspider] Peer Connection Initiated with [AF_INET][ip]:59081
openvpn    | Wed May 31 11:16:24 2017 MULTI: new connection by client 'chessspider' will cause previous active sessions by this client to be dropped.  Remember to use the --duplicate-cn option if you want multiple clients u

Fix
Change the openvpn.conf line on the server-side to:
plugin /usr/lib/openvpn/plugins/openvpn-plugin-auth-pam.so "openvpn login COMMONNAME verification PASSWORD"
Debug log after fix (note it still shows disgruntled_employee but will in fact use the commonname):
openvpn    | Wed May 31 11:19:54 2017 [ip]:61002 VERIFY OK: depth=1, CN=vpn.example.com
openvpn    | Wed May 31 11:19:54 2017 [ip]:61002 VERIFY OK: depth=0, CN=chessspider
openvpn    | Wed May 31 11:19:54 2017 [ip]:61002 peer info: IV_VER=2.4.2
openvpn    | Wed May 31 11:19:54 2017 [ip]:61002 peer info: IV_PLAT=win
openvpn    | Wed May 31 11:19:54 2017 [ip]:61002 peer info: IV_PROTO=2
openvpn    | Wed May 31 11:19:54 2017 [ip]:61002 peer info: IV_NCP=2
openvpn    | Wed May 31 11:19:54 2017 [ip]:61002 peer info: IV_LZ4=1
openvpn    | Wed May 31 11:19:54 2017 [ip]:61002 peer info: IV_LZ4v2=1
openvpn    | Wed May 31 11:19:54 2017 [ip]:61002 peer info: IV_LZO=1
openvpn    | Wed May 31 11:19:54 2017 [ip]:61002 peer info: IV_COMP_STUB=1
openvpn    | Wed May 31 11:19:54 2017 [ip]:61002 peer info: IV_COMP_STUBv2=1
openvpn    | Wed May 31 11:19:54 2017 [ip]:61002 peer info: IV_TCPNL=1
openvpn    | Wed May 31 11:19:54 2017 [ip]:61002 peer info: IV_GUI_VER=OpenVPN_GUI_11
openvpn    | AUTH-PAM: BACKGROUND: user 'disgruntled_employee' failed to authenticate: Authentication failure
openvpn    | Wed May 31 11:19:54 2017 [ip]:61002 PLUGIN_CALL: POST /usr/lib/openvpn/plugins/openvpn-plugin-auth-pam.so/PLUGIN_AUTH_USER_PASS_VERIFY status=1
openvpn    | Wed May 31 11:19:54 2017 [ip]:61002 PLUGIN_CALL: plugin function PLUGIN_AUTH_USER_PASS_VERIFY failed with status 1: /usr/lib/openvpn/plugins/openvpn-plugin-auth-pam.so
openvpn    | Wed May 31 11:19:54 2017 [ip]:61002 TLS Auth Error: Auth Username/Password verification failed for peer

I'm not really sure how to set this up in a test-case that suits your requirements.

I can confirm this wrong behaviour.
Yesterday I generated a common test users with otp and by accident entered the wrong one while connecting once, and was surprised by the authentication working.
What would be the best way to minimise this risk?

please see the comment above yours and the instructions underneath the "Fix" header to fix this problem :)

@ChessSpider thanks for the solution.
since I'm merely using the -2 parameter, and avoiding touching the container config elsewhere, it would be preferable to fix this upstream.
Hopefully it will happen.
thanks for the comment

seems to be this line
https://github.com/kylemanna/docker-openvpn/blob/master/bin/ovpn_genconfig#L382
I can do a PR if it helps

i've created PR https://github.com/kylemanna/docker-openvpn/pull/338

So has/will this ever be fixed in master? :)

So has/will this ever be fixed in master? :)

When someone read the CONTRIBUTING.md file and sends an appropriate pull request.

Seriously? It's a security risk with an elaborate description and a one
line fix, open for a year, with a pull request pending, and this is your
response?
Just say thanks for the free security research and fix it.
On Mon, 11 Jun 2018, 18:42 Kyle Manna<EMAIL_ADDRESS>wrote:

So has/will this ever be fixed in master? :)
When someone read the CONTRIBUTING.md file and sends an appropriate pull
request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kylemanna/docker-openvpn/issues/272#issuecomment-396307755,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACEWNKB1ENzd9KJJ6xWVmxG_lmYDPfedks5t7p4DgaJpZM4NqdJn
.

Seriously?

Yes, seriously, TOTP is a feature I've never used and has caused issues throughout the years.  My fix would be remove it and simply be done.
When I get time, maybe I'll get around to it.  In the meantime, if anyone wants to do what's necessary, concise and well documented PRs are always welcome.

So has/will this ever be fixed in master? :)

When someone read the CONTRIBUTING.md file and sends an appropriate pull request.

If I take @FernandoMiguel PR and recreate it with a new PR following the contribution guidelines as you stated, could it be merged if all tests are passed? We (company) would really like to use OTP+certificate password. But of course, we need the OTP to function correctly.

@ChessSpider @FernandoMiguel
With the response from Kyle that you guys had I understand if you've washed you hands of this project. However, I am hoping that you can help me. I have made the change to my openvpn.conf file (commented out the old line and inserted your new line):
# Enable OTP+PAM for user authentication
# plugin /usr/lib/openvpn/plugins/openvpn-plugin-auth-pam.so openvpn
plugin /usr/lib/openvpn/plugins/openvpn-plugin-auth-pam.so "openvpn login COMMONNAME verification PASSWORD"
reneg-sec 0

However, I can still authenticate with any username that I use in openvpn client.
Wed Aug 12 13:19:12 2020 <IP_ADDRESS>:8254 VERIFY OK: depth=1, CN=ca.myvpn.host
Wed Aug 12 13:19:12 2020 <IP_ADDRESS>:8254 VERIFY OK: depth=0, CN=user1
Wed Aug 12 13:19:12 2020 <IP_ADDRESS>:8254 peer info: IV_VER=3.git:released:3e56f9a6:Release
Wed Aug 12 13:19:12 2020 <IP_ADDRESS>:8254 peer info: IV_PLAT=android
Wed Aug 12 13:19:12 2020 <IP_ADDRESS>:8254 peer info: IV_NCP=2
Wed Aug 12 13:19:12 2020 <IP_ADDRESS>:8254 peer info: IV_TCPNL=1
Wed Aug 12 13:19:12 2020 <IP_ADDRESS>:8254 peer info: IV_PROTO=2
Wed Aug 12 13:19:12 2020 <IP_ADDRESS>:8254 peer info: IV_LZO_STUB=1
Wed Aug 12 13:19:12 2020 <IP_ADDRESS>:8254 peer info: IV_COMP_STUB=1
Wed Aug 12 13:19:12 2020 <IP_ADDRESS>:8254 peer info: IV_COMP_STUBv2=1
Wed Aug 12 13:19:12 2020 <IP_ADDRESS>:8254 peer info: IV_GUI_VER=net.openvpn.connect.android_3.2.2-5027
Wed Aug 12 13:19:12 2020 <IP_ADDRESS>:8254 peer info: IV_SSO=openurl
Wed Aug 12 13:19:12 2020 <IP_ADDRESS>:8254 PLUGIN_CALL: POST /usr/lib/openvpn/plugins/openvpn-plugin-auth-pam.so/PLUGIN_AUTH_USER_PASS_VERIFY status=0
Wed Aug 12 13:19:12 2020 <IP_ADDRESS>:8254 TLS: Username/Password authentication succeeded for username 'joebloggs'
Wed Aug 12 13:19:12 2020 <IP_ADDRESS>:8254 Control Channel: TLSv1.3, cipher TLSv1.3 TLS_AES_256_GCM_SHA384, 2048 bit RSA
Wed Aug 12 13:19:12 2020 <IP_ADDRESS>:8254 [user1] Peer Connection Initiated with [AF_INET]<IP_ADDRESS>:8254
Wed Aug 12 13:19:12 2020 user1/<IP_ADDRESS>:8254 MULTI_sva: pool returned IPv4=<IP_ADDRESS>, IPv6=(Not enabled)
Wed Aug 12 13:19:12 2020 user1/<IP_ADDRESS>:8254 MULTI: Learn: <IP_ADDRESS> -> user1/<IP_ADDRESS>:8254
Wed Aug 12 13:19:12 2020 user1/<IP_ADDRESS>:8254 MULTI: primary virtual IP for user1/<IP_ADDRESS>:8254: <IP_ADDRESS>
Wed Aug 12 13:19:12 2020 user1/<IP_ADDRESS>:8254 PUSH: Received control message: 'PUSH_REQUEST'
Wed Aug 12 13:19:12 2020 user1/<IP_ADDRESS>:8254 SENT CONTROL [user1]: 'PUSH_REPLY,block-outside-dns,dhcp-option DNS <IP_ADDRESS>,dhcp-option DNS <IP_ADDRESS>,route <IP_ADDRESS>,topology net30,ping 10,ping-restart 60,ifconfig <IP_ADDRESS> <IP_ADDRESS>,peer-id 0,cipher AES-256-GCM' (status=1)
Wed Aug 12 13:19:12 2020 user1/<IP_ADDRESS>:8254 Data Channel: using negotiated cipher 'AES-256-GCM'
Wed Aug 12 13:19:12 2020 user1/<IP_ADDRESS>:8254 Outgoing Data Channel: Cipher 'AES-256-GCM' initialized with 256 bit key
Wed Aug 12 13:19:12 2020 user1/<IP_ADDRESS>:8254 Incoming Data Channel: Cipher 'AES-256-GCM' initialized with 256 bit key

Any suggestions?

I've honestly not touched this project in 3 years.
if you didnt mention me, i wouldnt even have notice the comments.

I am facing the same error as @nayneyT, were you ever able to solve this issue?


Playoff stats

Adds playoff records and rankings to the records page. At this time only playoff records, not toilet bowl records, are being added.

Still need to add consolation data (teams who make the playoffs but get eliminated), as well as IQ data.


Reduce STAmount public interface (RIPD-867):

The STAmount class includes a number of functions which serve as thin
wrappers, which are unused or used only in one place, or which break
encapsulation by exposing internal implemenation details. Removing
such functions simplifies the interface of the class and ensures
consistency.

getSNValue and getNValue are now free functions
canonicalizeRound is no longer exposed
Removed addRound and subRound
Removed overloads of multiply, mulRound, divide and divRound

:+1:  Tiny quibble, but basically flawless, and all that cruft gone forever.  Brilliant!

:+1: Code looks good. Compiled/npm/unittest unity/non-unity on mac/linux. Compiled unity/nonunity windows.
I am having trouble getting npm tests to run on windows, but I don't want to hold this PR up.

@seelabs: by trouble, you mean with this specific PR? Or with other branches too? I had to do npm install to get some updated dependency (lodash, I think) before things would succeed.
@rec: I will address the concerns you and Vinnie brought up.

@nbougalis: No, not specific to this PR. I'm getting the same errors on develop. I just wanted to flag that npm test have not been run on windows for this PR (something I would normally do).

@nbougalis Finally got npm tests working on windows. Confirmed this PR does pass.

I have addressed the comments and squashed down.

Conflicts with earlier numbered changes - try in next release push!

You can now try to rebase!

Wilco - thanks.


Improve Javac error parsing

Ref #520
This is an improvement over the status quo of forked Javac error parsing,
but likely not a complete fix.
"Normal" Java error messages look like:
/path/a.java:100:1: error message
        if (x.isBar) {
              ^
  symbol: xxx
  location: xxx

However, under certain circumstances javac reports compiler errors are reported as:
/path/a.java:100:1: error message
symbol: xxx
location: xxx
if (x.isBar) {

Current parsing assumes existence of ^ as well as indentation before "symbol" etc.
Ultimately a better way of handling forking probably is to define our own small commandline app, like forked tests are done.

To validate this pull request against other sbt modules, please visit this link.

If I can unblock the customer I am working with, I'd like to get this in soon.
It's difficult to estimate how complicated the commandline app approach would be, but I'm thinking it would be weeks away not days. I'll probably create a issue for it, and kick it till later.

Good, this is good to go on my side.

Thanks guys.


Design for pinned/frozen column

😯 Problem to Solve
This is a development configuration freezing the first/last column (or first/last n columns) in a table. This is helpful when a table is very wide and the first column should remain visible when horizontally scrolling.
💁 Proposed Solution
🤔 Open Questions

Have we enabled horizontal scrolling?
Do we need to be able to enable pinning for last columns?

It's not unheard of, but is this something we need?
https://material.angular.io/components/table/overview#sticky-rows-and-columns

Should there be an interactive version of this feature (so the end user can "pin/freeze" a column)?
What is the visual design when horizontally scrolling? Do non-frozen columns go behind frozen columns? If so what happens to parts of the table that are transparent (e.g. what stops you from seeing the non-frozen column text and hover visual through the transparent parts of the frozen column?) See SLE PR for old table for example of this.

🖼 References/Prior Art
https://user-images.githubusercontent.com/109235103/205920352-456669aa-0586-466c-9792-9088c1d9a2dd.mov

Not prioritizing against current client requirements.


eigenvalue computation is wrong sometimes

#[cfg(test)]
mod tests {
    use linalg::matrix::Matrix;

    #[test]
    fn eigentest() {
        // Let's consider the real, symmetric matrix
        // ⎡ 85 -30⎤
        // ⎣-30  40⎦.
        //
        // Example 2 in §8.3 of Otto Bretscher's _Linar Algebra with
        // Applications_, 3rd ed'n. mentions that the eigenvalues are 100 and
        // 25.
        //
        // NumPy agrees:
        //
        // ```
        // in [11]: a
        // Out[11]:
        // array([[ 85, -30],
        //        [-30,  40]])
        //
        // in [12]: linalg.eig(a)
        // Out[12]:
        // (array([ 100.,   25.]), array([[ 0.89442719,  0.4472136 ],
        //         [-0.4472136 ,  0.89442719]]))
        // ```
        //
        // Unfortunately, rusty-machine does not agree (as of 13 April's
        // 296d04dc7).

        let a = Matrix::<f64>::new(2,2,vec![85., -30., -30., 40.]);

        let eigenvals = a.eigenvalues();
        let (eigenvals_redux, eigenvecs) = a.eigendecomp();

        // The `eigenvalues` and `eigendecomp` methods agree with _each other_
        for i in 0..2 {
            assert_eq!(eigenvals[i], eigenvals_redux[i])
        }

        // But ...
        println!("λ₁, λ₂ = {:?}", eigenvals);

        assert!((eigenvals[0] == 100.) || (eigenvals[1] == 100.));
        assert!((eigenvals[0] == 25.) || (eigenvals[1] == 25.));

        //---- linalg::matrix::decomposition::tests::test_eigendecomp stdout ----
	// λ₁, λ₂ = [85, 40]
        // thread 'linalg::matrix::decomposition::tests::test_eigendecomp'
        // panicked at 'assertion failed: (eigenvals[0] == 100.) ||
        // (eigenvals[1] == 100.)', src/linalg/matrix/decomposition.rs:736
    }

}

Thanks for spotting this! I don't find it that surprising...
I made a bit of a mess as I wrote this up. It should be a lot easier now that we have MatrixSliceMut (though some other helper methods may be needed).
I'll take another look at this when I have time but it would definitely help to have you explore it. I can't find the exact source I used to get the algorithm (still looking, sorry!). But I believe it's a double-shifted implicit QR algorithm. Feel free to completely rewrite it if you want - I think the performance of the current implementation is pretty subpar too...

The bug occurs because the matrix is 2x2 and the current implementation doesn't handle this case. To fix this we could check if the matrix is 2x2 and if so explicitly compute the eigenvalues.
I welcome other solutions though!

Oh, thanks, I can probably pull-request that tomorrow morning.

That would be awesome! Probably redundant source..
The code doesn't need to be tidy - the whole thing should undergo a cleanup soon anyway. (If you want to be the guy to make that happen I wont object!).
Are you still planning on giving SVD a go afterwards?

PR #47 closes this issue.