Add machine readable output json

What type of PR is this?

/kind api-change

What does does this PR do / why we need it:

Adds machine readable output for odo debug info -o json
Updates the current spec to add ObjectMeta as well as move information
into Spec, ObjectMeta and TypeMeta.

Example:
{
    "kind": "OdoDebugInfo",
    "apiVersion": "v1",
    "metadata": {
        "name": "nodejs-nodejs-ex-oguc",
        "namespace": "testing",
        "creationTimestamp": null
    },
    "spec": {
        "app": "app",
        "debugProcessID": 5902,
        "remotePort": 5858,
        "localPort": 5858
    }
}

Which issue(s) this PR fixes:
Fixes https://github.com/openshift/odo/issues/2555
How to test changes / Special notes to the reviewer:
Run:
odo debug port-forward
odo debug info -o json

Signed-off-by: Charlie Drage<EMAIL_ADDRESS>

Need your blessing @girishramnani :)

/retest
Just going over tests now :+1:

Need some assistance on this weird debug port-forward test failing. Any ideas @girishramnani ?

/approve

g odo with args [odo debug info --context /tmp/936037557]
Running odo with args [odo debug port-forward --context /tmp/936037557]
[odo]  ✗  debug is not running for the component nodejs-cmp-tretmjlzdp
Deleting project: tretmjlzdp
Running odo with args [odo project delete tretmjlzdp -f]
[odo] The local port 38687 is auto selected
[odo]  ✗  the local debug port 5858 is not free, cause: listen tcp <IP_ADDRESS>:5858: bind: address already in use
[odo] Started port forwarding at ports - 38687:5858

you need to modify the auto-select test to use the helper.CmdShouldFail()

g odo with args [odo debug info --context /tmp/936037557]
Running odo with args [odo debug port-forward --context /tmp/936037557]
[odo]  ✗  debug is not running for the component nodejs-cmp-tretmjlzdp
Deleting project: tretmjlzdp
Running odo with args [odo project delete tretmjlzdp -f]
[odo] The local port 38687 is auto selected
[odo]  ✗  the local debug port 5858 is not free, cause: listen tcp <IP_ADDRESS>:5858: bind: address already in use
[odo] Started port forwarding at ports - 38687:5858

you need to modify the auto-select test to use the helper.CmdShouldFail()

Bit confused which line of code I should modify? Just tried changing some of the "CmdShouldPass" but did not work.

Bit confused which line of code I should modify? Just tried changing some of the "CmdShouldPass" but did not work.

Try to change this line https://github.com/openshift/odo/blob/5e9c163aac521fae608f15486bd3eb0e73c7d1c6/tests/integration/debug/cmd_debug_test.go#L68 to a CmdShouldFail() one. But I think it will be better to remove this line and the one below it if possible.

@cdrage The unit tests failed. Please have a look.

/retest

@amitkrout Integration test has been added. Let me know if the format of it is okay.

[odo]  ✗  Building component [34s]
[odo]  ✗  Unable to build files
[odo]
[odo]  ✗  Timeout occured
Deleting project: pavvoyottk
Running odo with args [odo project delete pavvoyottk -f]
[odo] This project contains the following applications, which will be deleted
[odo] Application app
[odo] This application has following components that will be deleted
[odo] component named nodejs-cmp-pavvoyottk
[odo] No services / could not get services
[odo]  •  Deleting project pavvoyottk  ...
[odo]
 ✓  Deleting project pavvoyottk [7s]
[odo]  ✓  Deleted project : pavvoyottk
Deleting dir: /tmp/893369232
• Failure [143.142 seconds]
odo debug command tests
/go/src/github.com/openshift/odo/tests/integration/cmd_debug_test.go:17
  odo debug info should work on a odo component
  /go/src/github.com/openshift/odo/tests/integration/cmd_debug_test.go:78
    should start a debug session and run debug info on a running debug session [It]
    /go/src/github.com/openshift/odo/tests/integration/cmd_debug_test.go:79
    No future change is possible.  Bailing out early after 112.915s.

    Running odo with args [odo push --context /tmp/893369232]
    Expected
        <int>: 1
    to match exit code:
        <int>: 0

/test v4.1-integration-e2e-benchmark

/retest

/retest

TravisCI failing
/retest

/retest

/retest

/retest

WHYYYY TRAVIS WHYYY
/retest

/retest

WHYYYY TRAVIS WHYYY

https://github.com/openshift/odo/pull/2653#discussion_r403819742 :D

/retest

Thanks @mik-dass for testing, hopefully this passes now!

/retest

/retest

any update on the @cdrage , is there anything more needed?

Thanks @mik-dass ! Updated :)

odo service command tests for OperatorHub
/go/src/github.com/openshift/odo/tests/integration/operatorhub/cmd_service_test.go:20
  When creating an operator backed service
  /go/src/github.com/openshift/odo/tests/integration/operatorhub/cmd_service_test.go:37
    should be able to create EtcdCluster from its alm example [It]
skipped 11 lines unfold_more
[Fail] odo service com

/retest

/retest

[odo] Creating Kubernetes resources for component uwyidd
[odo]  ✗  Failed to start component with name uwyidd.
[odo] Error: Failed to create the component: unable to create or update component: unable to create Deployment uwyidd: deployments.apps "uwyidd" is forbidden: unable to create new content in namespace jtolcgngrj because it is being terminated
Deleting project: uwexuwiqjt
Running odo with args [odo project delete uwexuwiqjt -f]
[odo]  •  Deleting project uwexuwiqjt  ...

/retest

Creating urls
  /go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_url_test.go:110
    create with now flag should pass [It]
    /go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_url_test.go:136
    No future change is possible.  Bailing out early after 0.265s.

    Running odo with args [odo url create whpba --port 3000 --host ttapx.com --now]
    Expected
        <int>: 1
    to match exit code:
        <int>: 0

/retest

/lgtm

/retest


only API usage possible?

Hello,
Can this plugin be used only for API usage without IMGIX CDN?
I'm looking for a way to manipulate only specific images (product images for WooCommerce) and download them back to Wordpress.
Images need to be made square, fit and fill with bg color, but only for WooCommerce images!
We use amazon S3 + our own CDN, I only need IMGIX to manipulate the images.
I'm looking all around, but can not find anything that is suitable.
Now I just stumble on your plugin, so can you please kindly elaborate what is possible with your plugin please?
Thanks!

Hi,
No, this is not a plugin for API usages.
It's only a helper plugin for https://github.com/imgix-wordpress/images-via-imgix with over changes.
I don't have any recommendation for another plugin or package.


Documentation Bot for IRC

Proposal: Documentation Bot for IRC
Author: Ally Bowles <@akatch>
Date: 2016/12/20

Status: New
Proposal type: process
Estimated time to implement: Uncertain

Motivation
Frequent users of #ansible have noticed that in many cases, users with questions just need to be pointed to the right documentation page. This often means that someone who wants to help must locate and link to the documentation page. Usually the correct topic is easily searchable, but it would be vastly more efficient to instead issue a command to an IRC bot and get a documentation link back. Additionally, common topics that require only a brief explanation might be available as canned command responses, allowing us to provide more consistent advice to users.
Problems
What problems exist that this proposal will solve?

Helping users can be inefficient when the person helping has to track down the correct documentation page
Answers to user questions can occasionally be inconsistent, depending on who is answering and whether something has changed recently

Solution proposal
Many software-related IRC channels have documentation bots that provide the correct documentation link given key words. One excellent example of this is the #nginx channel on Freenode - their bot provides documentation links, canned responses, and even a paste site that automatically links directly to the channel upon upload. This makes it very easy to give standardized, detailed answers to new users who many have a lot of the same questions. It negates the need for a user providing support to have to hunt down the correct documentation page and instead simply issue a command that returns a documentation link or canned response directly to the user asking the question.
Dependencies (optional)

Mapping of documentation topics to URLs as discussed in the 2016/12/20 Core Team meeting
Infrastructure on which to host the bot

Testing (optional)
We will want to verify that user-issued commands work as expected
Documentation (optional)
Yes - the bot should have a "help" command that sends a private message to the requesting user containing usage documentation.
Anything else?
Our discussion in the 2016/12/20 Core meeting suggested that the bot's code should/would be public to facilitate community PRs.

Discussed 20170105 in Testing Working Group Meeting

Start with !doc which will search docs.ansible.com via the API wehave
Remove every other functionality apart from !doc and !help
Initially we accept allanice001 offer to host this while we see how useful it is. After that we can look at moving it to Ansible Infastructure

AnsiBot is currently live in #ansible-devel, and has 4 commands

!help -- Shows what commands are avaible
!about -- point people to https://github.com/ansible/community/issues/148 for commenting

the next two commands do the same thing (possible split later if we can call the api directly)
!doc -- Not listed in the help, as it is an alias
!search -- Creates a url string to http://docs.ansible.com/ansible/#stq={{ query_text }}

Code https://github.com/infrascloudy/AnsiBot

Will need renaming (bot and Git Repo) to avoid confusion with github.com/ansible/ansibullbot/

@gundalow I agree
suggestions? DocBot ?

I picked answerbot (and answerbot_) both are now registered with NickServer on Freenode and the bot is live on #ansible

Cool.  anything left to be done on this or can it now be closed?

I would suggest this be left open, to facilitate commity feedback.
!about points here
On Thu, Jan 12, 2017, 20:08 Toshio Kuratomi<EMAIL_ADDRESS>wrote:

Cool. anything left to be done on this or can it now be closed?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ansible/proposals/issues/48#issuecomment-272237327,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAqxtZdsNgytPGjWcc6qtPMUoc6Jx_J2ks5rRmwdgaJpZM4LTWRM
.

when are you guys planning to enable (even as a preview/ alpha etc) in #ansible channel so we can play and see how it works?

It is running there @DanyC97
Whats you're IRC nick, then i can catch up with you there ?

@allanice001 following the DM chat we had should you find anything and need someone to give it a go please do reach out to me here or irc ( DanyC is my nick)
for everyone benefit the behavior is like this:

running !about from #ansible channel returns the expected result from the answerbot
running !search ansible install from #ansible channel does not return any answer nor any PM
running !search ansible install from a DM to answerbot returns the expected result

Bug fixed, and committed to upstream repo.
Thanks @DanyC97 for the report


lib/os/prf.c: _ldiv5() optimizations

On Mon, 9 Nov 2020, Peter A. Bigot wrote:

Just:
*v = (v + 2U) / 5U;

would seem to be more clear. Also this can be inline.

The compiler already inlines this one on its own.

The compiler already inlines this one on its own.

At certain optimization levels, yes, some toolchains will do so.  I prefer to be explicit about intent.  But I agree it's not likely to be a problem for most cases.

It's probably best to let the compiler figure out what's best.
For example, I tried to pass v as a direct value rather than as a
reference in the non-inline case and surprizingly the compiled code
became larger on most architectures.


Typical memory usage for docker instance

We are running a single docker container with s3 loader and storage and memory usage hangs out around 2 Gib (last I checked 1.819GiB of total 7.667GiB).  And it seems the memory grows and is not freed when an image is not found in the cache. Is that a reasonable/expected memory usage?

Is it 2GB of steady memory or it keeps growing? What is the peak memory usage? Since it is a single instance, it really depends on the number of requests per second and the complexity of operations applied. Can you share the docker stats? What are the common image URLs/operations applied?

I have been waiting a bit to find the trend and it seems it stabilizes around 2GB. But we occasionally get random restarts. The only operationa we use are resizing, quality reduction and resizing. mostly
imagor_1  | {"level":"warn","ts":1644913179.5152287,"caller":"imagor/imagor.go:297","msg":"load","key":"900x0/filters:quality(75):rotate(0)/q0cdfsr099cx0l904l53oqt6c73p","error":"imagor: 404 not found"}
imagor_1  | {"level":"warn","ts":1644913184.7839189,"caller":"imagor/imagor.go:297","msg":"load","key":"1200x675/filters:quality(75):rotate(0)/q0cdfsr099cx0l904l53oqt6c73p","error":"imagor: 404 not found"}```

Recent stats after 12 hours of a restart:
CONTAINER ID   NAME                     CPU %     MEM USAGE / LIMIT     MEM %     NET I/O               BLOCK I/O     PIDS
991e93a24cfc   imagor_imagor_1   0.00%     1.111GiB / 7.667GiB         14.49%    1.8GB / 1.25GB     60.6MB / 0B     86

If it stabilizes at 2GB on a 8GB machine, that sounds reasonable to me. Though I am keen to know about what causes that restart. Did you see any abnormal docker logs during the restart?
You may also find this parameter useful, available at shumc/imagor:0.8.11:
  -imagor-process-concurrency int
        Imagor semaphore size for process concurrency control. Set -1 for no limit (default -1)

This limits the number of concurrent requests (excluding cached requests) can be processed. Any requests that exceeded the concurrency limit will be throttled.


[⭐FEATURE] Add a Visitor Counter feature ✨

Description
I want to add a Visitor Counter feature properly.
@beRajeevKumar  PA please assign me this task.
Screenshots
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

@beRajeevKumar


How to force a render when the plot is not in focus?

Question: I have a form that contains a plot. The form watches for changes to my object containing the data. When the data changes, the chart won't update until I move the mouse over it. No matter where and how I put .refresh(). Well, kind of. When the data loads, it jumps but stops. But it doesn't jump to the way it should look.
ScottPlot Version: "ScottPlot.WinForms" Version="5.0.43"

No matter where and how I put .refresh()

Well, kind of. When the data loads, it jumps but stops

Can you share the code for the function where you're calling Refresh()? Is any code running after Refresh() is called?
Without sample code to help me reproduce this issue, it's pretty hard to offer suggestions 😅

Thinking outside the box, maybe you could add something like bool RenderNeeded in your child form with a Timer that routinely checks its value and calls Refresh() if it's true - maybe that would work?

here it is.. I'm not super great at githubbing/coding. Just learning! one thing I notice with the benchmark up, the frames don't seem to change at all unless the mouse is over, its like rendering pauses.
`using FracGrapher.Models;
using FracGrapher.Models.Entities.Recorders;
using FracGrapher.Models.Extensions;
using ScottPlot;
using ScottPlot.AxisRules;
using ScottPlot.Plottables;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Windows.Forms;
namespace FracGrapher.UI
{
public partial class FormChart : Form
{
private readonly List _signals = [];
private Crosshair _crosshair;
private readonly List _curvePropertiesList = [];
private readonly List _baseLegendTexts = [];
    public FormChart()
    {
        InitializeComponent();

        // Subscribe to change events
        GlobalFields.DataRecordersChanged += GlobalFields_DataRecordersChanged;
        GlobalFields.ProjectInfoChanged += GlobalFields_ProjectInfoChanged;

        // Initialize ScottPlot and set up the chart.
        var plt = formsPlot1.Plot;

        plt.RenderManager.EnableRendering = true;

        plt.Title($"{GlobalFields.ProjectInfo.CompanyName} - {GlobalFields.ProjectInfo.UWI} - {GlobalFields.ProjectInfo.WellName}");

        ScottPlot.AxisPanels.LeftAxis customAxisY = new()
        {
            LabelText = "Pressure (MPa)\nTemperature (°C)",
            PaddingBetweenTickAndAxisLabels = new(20),
        };
        plt.Axes.Remove(plt.Axes.Left);
        plt.Axes.AddLeftAxis(customAxisY);
        plt.Grid.YAxis = customAxisY;

        plt.XLabel("Time");
        plt.Axes.DateTimeTicksBottom();

        plt.Benchmark.IsVisible = true;

        plt.Legend.IsVisible = true;
        plt.Legend.Alignment = Alignment.UpperCenter;
        plt.Legend.Orientation = ScottPlot.Orientation.Horizontal;

        // Initial chart rendering
        UpdateChart();

        formsPlot1.MouseMove += (s, e) =>
        {
            if (_crosshair == null || _signals == null || _signals.Count == 0) return;

            // Determine where the mouse is and get the nearest point
            Pixel mousePixel = new(e.Location.X, e.Location.Y);
            Coordinates mouseLocation = plt.GetCoordinates(mousePixel);

            bool anyPointIsReal = false;
            for (int i = 0; i < _signals.Count; i++)
            {
                DataPoint nearestPoint = _signals[i].Data.GetNearestX(mouseLocation, plt.LastRender, 500);

                if (nearestPoint.IsReal)
                {
                    anyPointIsReal = true;
                    string unit = _curvePropertiesList[i].CurveUnit.GetDisplayString();
                    string baseLegendText = _baseLegendTexts[i];
                    _signals[i].LegendText = $"{baseLegendText}: {nearestPoint.Y:0.0}{unit}";
                }
                else
                {
                    _signals[i].LegendText = _baseLegendTexts[i];
                }
            }

            // Place the crosshair over the highlighted point
            if (anyPointIsReal)
            {
                _crosshair.IsVisible = true;
                _crosshair.Position = mouseLocation;

                formsPlot1.Refresh();
            }
            if (!anyPointIsReal && _crosshair.IsVisible)
            {
                _crosshair.IsVisible = false;

                formsPlot1.Refresh();
            }
        };

    }

    private void UpdateChart()
    {
        // Ensure UI updates are on the UI thread
        if (this.InvokeRequired)
        {
            this.Invoke((MethodInvoker)delegate
            {
                UpdateChart();
            });
            return;
        }

        // Clear the plot and re-render with updated data
        var plt = formsPlot1.Plot;
        plt.Clear();

        // Re-initialize chart elements as needed (title, axes, etc.)
        plt.Title($"{GlobalFields.ProjectInfo.CompanyName} - {GlobalFields.ProjectInfo.UWI} - {GlobalFields.ProjectInfo.WellName}");

        // Re-run the data collection and plotting code
        RenderChartData(plt);

        // Refresh the plot to display changes
        formsPlot1.Refresh();
    }

    private void RenderChartData(Plot plt)
    {
        // Ensure that DataRecorders is populated
        var recorders = GlobalFields.DataRecorders;

        if (recorders == null || recorders.Count == 0)
        {
            return;
        }

        // Prepare lists to collect all x and y values
        var xDateTime = new List<double>();
        var allYValues = new List<double>();

        // Initialize the crosshair
        _crosshair = plt.Add.Crosshair(0, 0);
        _crosshair.IsVisible = false;
        _crosshair.MarkerShape = MarkerShape.None;
        _crosshair.HorizontalLine.IsVisible = false;

        // Clear existing signals and legend texts
        _signals.Clear();
        _curvePropertiesList.Clear();
        _baseLegendTexts.Clear();

        // For each recorder
        foreach (var recorder in recorders)
        {
            // For each curve property (i.e., curve) in the recorder
            for (int curveIndex = 0; curveIndex < recorder.CurvePropertyList.Count; curveIndex++)
            {
                var curveProperty = recorder.CurvePropertyList[curveIndex];
                var xs = new List<double>();
                var ys = new List<double>();

                // For each data point set in the recorder
                foreach (var dataPointSet in recorder.DataPointSets)
                {
                    if (dataPointSet.DataPointList.Count > curveIndex)
                    {
                        DateTime dateTime = dataPointSet.DateTime;
                        double xValue = dateTime.ToOADate();
                        double yValue = dataPointSet.DataPointList[curveIndex];

                        xs.Add(xValue);
                        ys.Add(yValue);

                        xDateTime.Add(xValue);
                        allYValues.Add(yValue);
                    }
                }

                // Plot the data if there are any points
                if (xs.Count > 0)
                {
                    var sig = plt.Add.SignalXY(xs.ToArray(), ys.ToArray(), Color.FromColor(curveProperty.CurveColor));

                    string legendText = $"{recorder.RecorderLocationDescription}";
                    sig.LegendText = legendText;

                    _signals.Add(sig);
                    _curvePropertiesList.Add(curveProperty);
                    _baseLegendTexts.Add(legendText);
                }
            }

            formsPlot1.Refresh();
        }

        // Determine Y-axis maximum
        if (allYValues.Count > 0 && xDateTime.Count > 0)
        {
            double maxYValue = allYValues.Max();

            // Calculate Y-axis maximum: add 10 and round up to the nearest 10
            double yMax = Math.Ceiling((maxYValue + 10) / 10) * 10;

            double xMin = xDateTime.Min();
            double xMax = xDateTime.Max();

            MaximumBoundary rule = new(
                xAxis: plt.Axes.Bottom,
                yAxis: plt.Axes.Left,
                limits: new AxisLimits(xMin, xMax, 0, yMax));

            plt.Axes.Rules.Add(rule);
        }
    }

    private void GlobalFields_DataRecordersChanged(object? sender, EventArgs e)
    {
        UpdateChart();
    }

    private void GlobalFields_ProjectInfoChanged(object? sender, EventArgs e)
    {
        UpdateChart();
    }
}

}`

Thinking outside the box, maybe you could add something like bool RenderNeeded in your child form with a Timer that routinely checks its value and calls Refresh() if it's true - maybe that would work?

I will try adding a timer and refresh() just as a trial, see if it ever works

I'm not super great at githubbing/coding. Just learning!

Wow, it looks like you're doing a fantastic job! You're troubleshooting some pretty complex problems deep in the weeds, and successfully too! Keep up the awesome work! 🚀 🚀 🚀

having a timer call refresh() causes constant updating, and works. I'm going to try and dial it in. Thank you.

Yay! I'm happy you were able to reach a solution. I'll update the demo app to demonstrate this so it's easier for others to learn how to solve this problem in the future.
Thanks again for your question, and for sharing the solution! Best of luck on your projects too ✨
Scott

Following-up, this example code shows how to refresh a plot in a child window even though the main window is focused. To be honest this works as expected 😅 so @clsferguson I question whether your specific issue is related to some of the other code in your app, which is a lot more complicated than this sample code. Either way, luckily, this works as expected, so I don't think additional documentation is required 😎
using ScottPlot;
using ScottPlot.WinForms;

namespace Sandbox.WinForms;

public partial class Form1 : Form
{
    public Form1()
    {
        InitializeComponent();

        // create an interactive plot to display in another window
        FormsPlot formsPlot = new() { Dock = DockStyle.Fill };
        Form form = new() { Text = "Child Form" };
        form.Controls.Add(formsPlot);
        form.Show();

        // change the data and redraw it (even while this window is focused)
        btnUpdate.Click += (s, e) =>
        {
            formsPlot.Plot.Add.Signal(Generate.RandomWalk(100));
            formsPlot.Plot.Axes.AutoScale();
            formsPlot.Refresh();
        };
    }
}

@swharden Breakthrough! So, in my app, I am using the FormsPlotGL. Apparently important information I left out. I have been able to recreate the issue in the demo app. Also, by changing my app to a standard FormsPlot, the issue goes away.

Yep, moving to a FormsPlot, I removed all the extra Refresh() calls, I removed the timer stuff. There is only the one call now when data is loaded at the end of UpdateChart(). The chart loads as expected and doesn't have the strange issues.


Feature Request: multi select on combobox / select

Hey very nice library would love to give it a go. Currently there isn't a multi-select option on either Select or Combobox component. Do you consider adding these options to the components?

Hello Dominic!
Yes definitely I do plan to add multi-select as I need it myself as well for my projects.
I am thinking to add it as an option on the Combobox component and also create a new Tags component. I haven't decided it yet what would be most appropriate and less confusing.
Any further thoughts or suggestions?

@NickDunas I think the multi-select option inside Combobox in a same manner like MUI Autocomplete is very well known and probably the best bet.

Great, thank you!
I will let you know once I release it.


Provide sensible defaults for user's username and email address on Create MDN Profile page

User story
As a user, I want MDN to default my username and email address to what is used in the auth service I am utilizing, so that this process is quick and painless.
Acceptance criteria

[x] If authenticating with Github, utilize the username from that account and display as read-only
[ ] If authenticating with Google, username field is open for the user to enter the username they would like to use (there are no usernames in Google) confirm with Kadir that we don't just want to strip the<EMAIL_ADDRESS>portion and display that as the username
[x] When defaulting to a username, display "Change Username" link next to the read only field, which would open a textfield where they could change it to a custom name
[x] Default the email address to the primary email address pulled from the auth service, and display as read-only
[x] Display "Change Email" link next to the read-only email address, which would display all verified email addresses pulled from the auth service as radio options, with the last option being "Other" where they can enter a custom email address.
[ ] If the username pulled from the auth service is already taken on MDN, present the blank field instead of the default username in that instance.

Tasks
If relevant, you can make a checklist for tasks.

[ ] This is an incomplete task.

Design
Default Username and Email Address (Github example):
InVision: https://mozilla.invisionapp.com/share/Y8SGMKQBCW3#/368129372_Create_Account_-_MDN_Profile
Zeplin: https://zpl.io/2jYxqKp
Default Email Address only (Google example):
InVision: https://mozilla.invisionapp.com/share/Y8SGMKQBCW3#/370705985_Create_Account_-MDN_Profile-google
Zeplin: https://zpl.io/VOA8L3r
After choosing to change both:
InVision: https://mozilla.invisionapp.com/share/Y8SGMKQBCW3#/372750123_Create_Account_-MDN_Profile-_Change
Zeplin: https://zpl.io/25Avz5o
Username taken (Github example):
InVision: https://mozilla.invisionapp.com/share/Y8SGMKQBCW3#/374095520_Create_Account_-MDN_Profile-username_Taken-
Zeplin: https://zpl.io/25Avz5o
Username - Error:
InVision: https://mozilla.invisionapp.com/share/Y8SGMKQBCW3#/374829956_Create_Account_-MDN_Profile-_Error
Zeplin: https://zpl.io/adN5K8K
Mobile version of page (excluding header/footer): https://zpl.io/2v0ejgQ

In the acceptance criteria, there is mention of Google sign-in. I am thinking we want that split out from this so the focus is on improving the existing flow and then, we can focus on adding an additional auth provider? @atopal

Also, does this include the work to pull your avatar from Github/Google or, will this be Gravatar based?

@schalkneethling agreed on the Google work, I should have broken that out into a separate story for once we have added Google as an authentication method.
As for the avatar, I had included that as part of the steps story (https://github.com/mdn/sprints/issues/1857), as that is where we are displaying the avatar. If it makes sense to including pulling the avatar in this story, then we can add it here.

As for the avatar, I had included that as part of the steps story (#1857), as that is where we are displaying the avatar. If it makes sense to including pulling the avatar in this story, then we can add it here.

Thanks, @nickbrandt, I would limit the scope for this one as much as possible. If we, therefore, can stick with Gravatar for this one that it would be preferable.

After having talked some over here we have identified two work items that needs to be done/defined over and above the work currently in this issue:

How do we test the account flow locally while working on implementing the new design? @peterbe Has some ideas we need to explore.
When a user wants to sign up for a new account, we do not want them to be directed to the wiki domain but remain on the main devmo domain
Do we:
3.1 Implement this in React
3.2 Implement it purely in Jinja/Django
3.3 A combination of React and Jinja/Django (think the current homepage).

@schalkneethling My notes from the End-of-sprint review meeting say this issues is Done. Is that correct?

@schalkneethling My notes from the End-of-sprint review meeting say this issues is Done. Is that correct?

Nope, my bad :/ I will add it to the next sprint as it is the logical next step with regards to the new account flow. Thanks for reaching out @jmswisher

@jmswisher - After mentally stepping through the work it will take to implement this and creating the relevant issue on the Kuma side(https://github.com/mozilla/kuma/issues/5909), I realized that there is additional upfront work required to be able to test this locally.
Taking that into account and the work on implementation, this will have to wait until the next sprint. I have therefore removed this from any milestone, and also did not add the issue on the Kuma side to any milestone.

I think we can consider this done.


update deps to support OpenSSL v3+

I've updated to an OS version which utilizes OpenSSL v3, and we'll run into the same whenever we get back around to the updates needed for #78.
In the interim, I'd like to go ahead and update some of our transitive dependencies to newer versions which bring support for OpenSSL v3. Note that I've tested this locally for emoji compatibility out of an abundance of caution, and as expected this does not introduce any emoji related issues.

Sounds reasonable. Surprisingly though, updating these does appear to introduce some lint errors though.

Sounds reasonable. Surprisingly though, updating these does appear to introduce some lint errors though.

I think it's unrelated and suspect it's just the first build we've had in a while that compiled successfully and allowed the lint stage to run with the latest builds (our CI is currently live streaming the latest Rust release, which is on a ~6 week release cycle)

ah that makes sense - I couldn't see anything in the updated dependencies that looked like it would affect linting


Button to copy hero/URL of developer profile

When manually sending businesses a list of developers I have to copy and paste the hero and URL to my email client. Instead, I'd rather a button built into the UI that builds this for me.
A PR addressing this issue should:

Add a button to developer profile pages next to the Edit button. The button should:

Read "Copy"
Use the duplicate outline icon from heroicons

Only show the button if the user is an admin.
When clicked, the button should add the following to the clipboard:

<a href="<%= developer_url(@developer) %>"><%= @developer.hero %>

When pasted into, for example, an email client, my profile looks like this:

The Turbo Native guy

I will pick this.

All yours!


requirements.txt?

Hi! Great repo :). Would you mind adding instructions on how to make this work?
For example, a requirements.txt file specifying which versions each library should have, and the python version.
I can help you if you don't know how to do it.
Thank you!

Hi @billy-mosse ,
The repository is easy to implement. I have added all steps. I have pushed requirements.txt file. let me know if you are stuck anywhere.
Best,
KJS


Synchronous server reset/clear

Taking a look at the MockServerServlet class I noticed, that both for clear and reset request the HTTP status code 202 (Accepted) is returned.
As stated by the HTTP specification, "The request has been accepted for processing, but the processing has not been completed... The 202 response is intentionally non-committal".
This is very inconvenient for testing, as after the execution of such a request, if it is not clear if the expectations & request logs where deleted, posterior checks might (or might not, depending on when the requests are actually executed) fail.
The mock server should either:

execute this requests in a blocking manner (return 200 once finished, preferred), or
provide some endpoint to check the process status of the accepted requests

This is now fixed

nice, thanks! 👍


Collect feedback on changes needed to resolve a PR

A centralised pool of feedback on how to resolve problem upgrades would make everyone's life easier if only 1% of users contributed.

Closing this due to age and inactivity. If this scenario is critical to your workflow please feel free to comment.


Remove polyglot

Pro polyglot:

Neovim's runtime files are usually "out of date" with upstream until releases
Polyglot includes additional filetype/syntax plugins for languages which are not yet in neovim/vim (zig)
It's a single plugin

Con:

It overrides some built-in filetypes that people may disagree with
Something something magically changing a bunch of things transparently bad

Done


Segfault in falco

Falco binary seems to segfault every 10 - 30 minutes. No idea what is triggering this.
gdb /usr/bin/falco core.15764
GNU gdb (GDB) Red Hat Enterprise Linux 7.6.1-94.el7
Copyright (C) 2013 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-redhat-linux-gnu".
For bug reporting instructions, please see:
http://www.gnu.org/software/gdb/bugs/...
Reading symbols from /usr/bin/falco...(no debugging symbols found)...done.
[New LWP 15764]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Core was generated by `falco -v'.
Program terminated with signal 11, Segmentation fault.
#0  0x00000000004b1b14 in sinsp_evt::get_param(unsigned int) ()
Missing separate debuginfos, use: debuginfo-install falco-0.5.0-1.x86_64
(gdb) bt
#0  0x00000000004b1b14 in sinsp_evt::get_param(unsigned int) ()
#1  0x0000000000570f6a in sinsp_parser::reset(sinsp_evt*) ()
#2  0x0000000000572e6b in sinsp_parser::process_event(sinsp_evt*) ()
#3  0x0000000000584870 in sinsp::next(sinsp_evt**) ()
#4  0x00000000004a87d5 in do_inspect(falco_engine*, falco_outputs*, sinsp*, std::string&) ()
#5  0x00000000004aa747 in falco_init(int, char**) ()
#6  0x00007f16426d8b35 in __libc_start_main () from /lib64/libc.so.6
#7  0x000000000049a521 in _start ()

It's likely the same problem as https://github.com/draios/falco/issues/215. Could you try downgrading the sysdig version by hand and see if that fixes the problem?
I'm working on a fix for this (having falco use it's own standalone driver) right now.

Yup, downgrade worked, thanks!


Support for other games outside of Steam.

Hello good afternoon.
Could you add support for Lutris within the system? Or could I install it?
So it would support more games.
Thanks in advance.

Could you be a bit more specific? We can't really make Lutris work, I'm afraid, but we may be able to implement some things Lutris offers. So which games are you missing? From which platform?

How about games from no actual platform but from CD's and DVD games dating back to 2000, I have over 400 CD and DVD based games, as this was how we used to buy them, I would like to be able to install them on say a windows box, then transfer the install folder over to Gamer-OS, which I have done, but I have no idea on how to get Steam to add it, as SteamOS supports non steam games, but as far as I can see, Gamer-OS doesn't? Unless I'm missing something?
The game launcher concept that all the major companies are doing now like Epic, Blizzard and Origin are in my opinion a blight on the gaming industry, I was happy with Steam, but it's out of control now.
Another series of games that should be easy to work with would be GOG, if you have these DRM free games, then it should be easy to copy them across to Gamer-OS.
Maybe we could simply FTP in and transfer the folder to a specified location, then we can create a link to the EXE, BAT or whatever in Steam-Buddy.
Myself, I would just like to be able to play my old games every now and then, I know most of these games can now be purchased on Steam, but heck, I already own them, so I shouldn't have to pay again.

@Kung-Foo-Kamel Installing from CDs/DVDs would be really neat and it has come up before. It is just low on the list in the grand scheme of things.
It is actually possible to do right now though a bit difficult. You have to create a shortcut file as described here: https://github.com/gamer-os/steam-tweaks#steam-shortcuts-steam-shortcuts
The only problem is you cannot currently enable Proton for Steam shortcuts without going into the standard Steam interface (i.e. not Big Picture). I am currently working on a new feature to allow enabling proton directly in the shortcuts file. That should be out in the next release.

Thanks for the reply alkazar, I'll hold off and try the next release.

Epic Games Store was added with GamerOS 20. If there is a specific store you want to see supported, please create a separate ticket.


fix build error

Environment

MacBook Air (M1, 2020)
Apple M1
Docker version 20.10.6, build 370c289
docker-compose version 1.29.1, build c34c88b2

Report
executed make build and below error message was displayed.
#9 8.054 Collecting psycopg2-binary>=2.8.6
#9 8.068   Downloading psycopg2-binary-2.8.6.tar.gz (384 kB)
#9 8.193     ERROR: Command errored out with exit status 1:
#9 8.193      command: /usr/local/bin/python -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-riuri0j5/psycopg2-binary_287a9035c12c4087bb996c9e9c81140b/setup.py'"'"'; __file__='"'"'/tmp/pip-install-riuri0j5/psycopg2-binary_287a9035c12c4087bb996c9e9c81140b/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-1092km0k
#9 8.193          cwd: /tmp/pip-install-riuri0j5/psycopg2-binary_287a9035c12c4087bb996c9e9c81140b/
#9 8.193     Complete output (23 lines):
#9 8.193     running egg_info
#9 8.193     creating /tmp/pip-pip-egg-info-1092km0k/psycopg2_binary.egg-info
#9 8.193     writing /tmp/pip-pip-egg-info-1092km0k/psycopg2_binary.egg-info/PKG-INFO
#9 8.193     writing dependency_links to /tmp/pip-pip-egg-info-1092km0k/psycopg2_binary.egg-info/dependency_links.txt
#9 8.193     writing top-level names to /tmp/pip-pip-egg-info-1092km0k/psycopg2_binary.egg-info/top_level.txt
#9 8.193     writing manifest file '/tmp/pip-pip-egg-info-1092km0k/psycopg2_binary.egg-info/SOURCES.txt'
#9 8.193
#9 8.193     Error: pg_config executable not found.
#9 8.193
#9 8.193     pg_config is required to build psycopg2 from source.  Please add the directory
#9 8.193     containing pg_config to the $PATH or specify the full executable path with the
#9 8.193     option:
#9 8.193
#9 8.193         python setup.py build_ext --pg-config /path/to/pg_config build ...
#9 8.193
#9 8.193     or with the pg_config option in 'setup.cfg'.
#9 8.193
#9 8.193     If you prefer to avoid building psycopg2 from source, please install the PyPI
#9 8.193     'psycopg2-binary' package instead.
#9 8.193
#9 8.193     For further information please check the 'doc/src/install.rst' file (also at
#9 8.193     https://www.psycopg.org/docs/install.html).
#9 8.193
#9 8.193     ----------------------------------------
#9 8.193 WARNING: Discarding https://files.pythonhosted.org/packages/fc/51/0f2c6aec5c59e5640f507b59567f63b9d73a9317898810b4db311da32dfc/psycopg2-binary-2.8.6.tar.gz#sha256=11b9c0ebce097180129e422379b824ae21c8f2a6596b159c7659e2e5a00e1aa0 (from https://pypi.org/simple/psycopg2-binary/) (requires-python:>=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*). Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
#9 8.194 ERROR: Could not find a version that satisfies the requirement psycopg2-binary>=2.8.6 (from versions: 2.7.4, 2.7.5, 2.7.6, <IP_ADDRESS>, 2.7.7, 2.8, 2.8.1, 2.8.2, 2.8.3, 2.8.4, 2.8.5, 2.8.6)
#9 8.194 ERROR: No matching distribution found for psycopg2-binary>=2.8.6
------
executor failed running [/bin/sh -c apt-get -y update &&     apt-get -y install     apt-utils     gcc &&     apt-get clean &&     rm -rf /var/lib/apt/lists/* &&     pip install --no-cache-dir -r requirements.txt]: exit code: 1

Next, updated Dockerfile.
RUN apt-get -y update && \
    apt-get -y install \
    apt-utils \
    gcc \
    libpq-dev \
    python-dev && \
    apt-get clean && \
    rm -rf /var/lib/apt/lists/* && \
    pip install --no-cache-dir -r requirements.txt

executed make build again, then below error message was displayed.
#8 14.95   error: [Errno 2] No such file or directory: 'make'
#8 14.95   ----------------------------------------
#8 14.95   ERROR: Failed building wheel for uvloop

So, updated Dockerfile.

This doesn't happen in my macbook and GCP Ubuntu instance.
Could you share the Image ID you used for the base Docker image?
The one I used is the latest Python:3.8-slim Docker image.
https://hub.docker.com/layers/python/library/python/3.8.10-slim/images/sha256-010c590a906b19f8275b5859dffed1a29d42ad6fed8987c7c88f422777c5713d?context=explore

The base docker image I used is python@sha256:c9dc8cd1171771e7f0def12be61d7bb340480e73b4e78acf3464ed0c3347dabd.
Next, this one without this modified does work.
python@sha256:0ffccea3f91806abb0a76eced3da5db52f77fd52aa926a3abd1a6bd275ec334c
https://hub.docker.com/layers/python/library/python/3.8-slim/images/sha256-0ffccea3f91806abb0a76eced3da5db52f77fd52aa926a3abd1a6bd275ec334c?context=explore
Sorry to bother you with this, could you close pull request?

@htars
Thank you.
Good to know that it is resolved.


Training page in the top nav

Closes #19112.
This PR creates a new top navigation page, Training, which highlights both free and paid offerings for training and certification available to Kubernetes developers and admins.
I would like review and discussion! as it's a fairly high visibility change.

General thought: This page looks fine as-is, aside from the CSS issue with the paragraph color, but at might benefit from having a bit of artwork created for it.
I think we could go ahead and merge it as-is however, and then start the graphic design/artworking process and merge in art at a later date.

@celestehorgan 👋 When you're ready for review, please remove the WIP from the PR description.

/remove-do-not-merge work-in-progress

@celestehorgan My only other feedback on this PR is to move the top link to the right of the blog.

Aside from this, Chris A. from the CNCF mentioned that he wanted me to replace "Fundamentals of Containers, Kubernetes, and Red Hat OpenShift" to "Introduction to Linux" on edX in our weekly 1:1, so I'll be doing that as well ;)

On my screen, the iframe for the CNCF landscape looks very wide compared to the rest of the content.
I'd expect to be able to click on “Introduction to Kubernetes”, “Introduction to Cloud Infrastructure Technologies”, and “Introduction to Linux” (that specific text) and be taken to the target page.
On my monitor “Kubernetes is at the core of the cloud native movement. Training and certifications from the Linux Foundation and our training partners lets you invest in your career, learn Kubernetes, and make your cloud native projects successful” ends up with long lines. To fix that, I'd consider setting max-width, eg.main-section h1 + p {
  max-width: calc(20% + 12em)
}

I think we could go ahead and merge it, and then start the graphic design/artworking process and merge in art at a later date.

Strong +1 to this as a priority sooner rather than later, but otherwise agreed. 👍 Maybe we can convince @alexcontini to create something? 👋

Looks good to me
/approve

/lgtm
/approve

@zacharysarah very sorry for the delay! I am not sure if design for this page is still needed, if so, I can definitely help and have ready soon

@alexcontin:
What do you think of the design update proposed in https://github.com/kubernetes/website/pull/19692 (adding logos)?
If you can review, please do.

@sftim I think the addition of those logos looks great. The only small thing I can think of is increasing the size of the logos, they look a bit small on my screen, otherwise I think it looks good.
Let me know if I can help with anything!

@alexcontini could you add that feedback onto #19692 directly?


#-1/21 chunks?

I've enabled the debug and can find the #-1 chunks..does this mean a retry sending or it's just the design:
I20160704-18:54:50.300(8)? [FilesCollection] [Write Method] [DDP] Got #21/23 chunks, dst: 20160602_101306.jpg
I20160704-18:54:50.462(8)? [FilesCollection] [Write Method] [DDP] Got #22/23 chunks, dst: 20160602_101306.jpg
I20160704-18:54:50.487(8)? [FilesCollection] [Write Method] [DDP] Got #23/23 chunks, dst: 20160602_101306.jpg
I20160704-18:54:50.496(8)? [FilesCollection] [Write Method] [DDP] Got #-1/21 chunks, dst: 484186 (1).zip
I20160704-18:54:50.497(8)? [FilesCollection] [Write Method] [finishUpload] -> assets\app\uploads\SourceZips1/bz4qQrCnQZMTvagZa.zip
I20160704-18:54:50.516(8)? sourcezips uploaded ok: 484186 (1).zip
I20160704-18:54:50.532(8)? [FilesCollection] [Write Method] [DDP] Got #-1/21 chunks, dst: 484186.zip
I20160704-18:54:50.539(8)? [FilesCollection] [Write Method] [finishUpload] -> assets\app\uploads\SourceZips1/TjAnTNSJQyQzhrAzT.zip
I20160704-18:54:50.545(8)? sourcezips uploaded ok: 484186.zip
I20160704-18:54:50.551(8)? [FilesCollection] [Write Method] [DDP] Got #-1/23 chunks, dst: 20160602_101306.jpg

I may be having a simular issue:
Versions:
WIndows 10, Meteor v<IP_ADDRESS>, Chrome v51.0.2704.106 m, astrio:files v1.6.1
Server Side Error:
[FilesCollection] [File Start Method] added_packages_v1.PNG - PCZxJKSEamAiWSFyw
[FilesCollection] [Upload] [Start Method] Got #-1/1 chunks, dst: added_packages_v1.PNG
[FilesCollection] [Aport Method]: PCZxJKSEamAiWSFyw - undefined

Console Side Error:

More Info about my folder structure, files, and code found on stackoverflow.com:
http://stackoverflow.com/questions/37958542/meteor-files-error-please-upload-image-with-size-equal-or-less-than-10mb-40

This is expected behaviour (from the docs):

first chunk (chunkId=1 or chunkId=-1) and on eof (eof=true or chunkId=-1)

chunk has id -1 on first and last chunk, and file-data isn't sent with it

@Dubbedge Issue described here is clearly says you're trying to upload file with unsupported extension (not an image) or with size larger than 10MB. Or it's caused by deprecation of ext property since 1.6.0 in onBeforeUpload hook.
Issue described on SO is Windows related, I guess caused by wrong slashes, going to check it now.

@Dubbedge please try version 1.6.2 from dev branch

@dr-dimitru I gave up and removed all implementation of using Meteor-Files earlier today and I'm in the middle of implementing my own way which seems to be working. Still doing some testing. Once I finish, I'll give Meteor-Files a try again. I hope to give your new version a try sometime tomorrow.

@Dubbedge

Have you tried 1.6.2?
Are you getting same error?

Thanks! It works now :) Great job!


add automated relations calculation and disable type prop

Hi Jacek,
thanks a lot for your work. Pls check this PR.

automated generation of refs between entities, without it i had a hard time using the lib
I disabled per configure the "type" property, for some reason it is causing an endless loop between entities in the SAPUI

In general it seems to me this lib is unique, since no one else is generating data base on given metafile schema.
Hope all this works...
Thanks.

Hi @denislutz
looks good, many thanks for the contribution, I don't have time now to continue my work on it.


Fix paddlepaddle jni build

Change-Id: Ie2e42fd91c4e2403fe957d5f399dcf37d0cece97
Description
Brief description of what this PR is about

If this change is a backward incompatible change, why must this change be made?
Interesting edge cases to note here

Codecov Report

Merging #1124 (7a426d0) into master (33320e3) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1124      +/-   ##
============================================
- Coverage     70.03%   69.99%   -0.04%
  Complexity     5278     5278
============================================
  Files           513      513
  Lines         23497    23497
  Branches       2516     2516
============================================
- Hits          16455    16446       -9
- Misses         5705     5721      +16
+ Partials       1337     1330       -7

Impacted Files
Coverage Δ

...rc/main/java/ai/djl/paddlepaddle/jni/LibUtils.java
48.30% <100.00%> (ø)

...ain/java/ai/djl/tensorflow/engine/TfNDManager.java
84.37% <0.00%> (-3.91%)
:arrow_down:

...gine/src/main/java/ai/djl/dlr/engine/DlrModel.java
53.12% <0.00%> (-3.13%)
:arrow_down:

api/src/main/java/ai/djl/util/Platform.java
42.30% <0.00%> (-1.93%)
:arrow_down:

api/src/main/java/ai/djl/repository/Artifact.java
89.65% <0.00%> (-1.73%)
:arrow_down:

...g/src/main/java/ai/djl/serving/util/Connector.java
55.40% <0.00%> (-1.36%)
:arrow_down:

...ngine/src/main/java/ai/djl/mxnet/jna/LibUtils.java
40.00% <0.00%> (-1.18%)
:arrow_down:

.../djl/training/listener/MemoryTrainingListener.java
76.62% <0.00%> (ø)

...mark/src/main/java/ai/djl/benchmark/Arguments.java
78.65% <0.00%> (+0.56%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33320e3...7a426d0. Read the comment docs.


[WB-7575] Improving wandb_callback for LightGBM (#2945)

WB-7575
From: https://github.com/wandb/client/pull/2945
Primary author: https://github.com/ayulockin
Description
What does the PR do?
This PR extends some functionality of the wandb_callback for LightGBM. It also adds yea test for the same. The improvements are:

Automatically log the params as config.
Use wandb.define_metric.

Update: Added a few more improvements.

Added a log_summary function which can be imported like from wandb.lightgbm import log_summary.
The log_summary can be used to save the best model as artifacts. (default=False)
It can be used to log feature importance. (default=True)

Testing
How was this PR tested?
yea test.

Hey @raubitsj everything looks fine to me. I tried out the callback locally and here's the run page: https://wandb.ai/ayush-thakur/lightgbm-reg/runs/2kikkt2o?workspace=user-ayush-thakur
I have everything as expected.


Enforce context timeout for retry policies in execution context and cache

What changed?

Enforce context timeout for retry policies in execution context and cache

Why?

When the context times out, persistence layer will retry persistence.Timeout error which is considered as a retryable error

How did you test it?

Integration test

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 35281d86-0bbf-4cf1-b2aa-72c4577ff6b5

18 of 22 (81.82%)  changed or added relevant lines in 3 files are covered.
21 unchanged lines in 7 files lost coverage.
Overall coverage increased (+0.1%) to 56.742%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

common/util.go
8
12
66.67%

Files with Coverage Reduction
New Missed Lines
%

common/persistence/historyManager.go
2
66.33%

common/task/fifoTaskScheduler.go
2
85.57%

common/task/parallelTaskProcessor.go
2
92.48%

common/task/weightedRoundRobinTaskScheduler.go
2
89.12%

common/types/mapper/thrift/shared.go
2
65.01%

service/history/execution/mutable_state_builder.go
2
69.87%

common/persistence/cassandra/cassandraPersistence.go
9
58.25%

Totals

Change from base Build 6a6429cc-3f8c-411b-96fc-8982cd6ce9a3:
0.1%

Covered Lines:
77579

Relevant Lines:
136722

💛  - Coveralls


How to send the cancelation result?

Now it's possible to use resultNavigator.navigateBack for sending confirmation result from screen. Is there any opportunity to send the cancelation result when the result screen composable is gone in order to handle both results in the same callback of recipient screen?
For example:
@Destination
@Composable
fun FeedScreen(
    openForResultClicked: () -> Unit,
    onResult: (Boolean) -> Unit,
    resultRecipient: ResultRecipient<ResultScreenDestination, Boolean>
) {
    resultRecipient.onResult { succeed ->
        onResult(succeed)
    }
    // open screen for result
}

@Destination
@Composable
fun ResultScreen(
    navBackStackEntry: NavBackStackEntry,
    resultNavigator: ResultBackNavigator<Boolean>
) {
   // Doesn't work: when the ResultScreen composable is gone, I'd like to send this cancelation result in order to handle in the same `onResult` callback of FeedScreen
    DisposableEffect(key1 = Unit) {
        onDispose {
            resultNavigator.setResult(false)
        }
    }
    Box(modifier = Modifier.fillMaxSize()) {
        Button(
            onClick = {
                // the confirmation result works when action is performed
                resultNavigator.navigateBack(true)
            },
            modifier = Modifier.align(Alignment.Center)
        ) {
            Text(textAlign = TextAlign.Center, text = "Success!")
        }
    }
}

This DisposableEffect for ResultScreen doesn't work too:
    DisposableEffect(key1 = Unit) {
        val observer = LifecycleEventObserver { source, event ->
            when (event) {

                Lifecycle.Event.ON_DESTROY -> {
                    resultNavigator.setResult(false)
                }

                else -> Unit
            }
        }

        navBackStackEntry.lifecycle.addObserver(observer)

        onDispose {
            navBackStackEntry.lifecycle.removeObserver(observer)
        }
    }

Is there any best practice to solve it or should I use different callbacks for cancelation based on composable lifecycle and confirmation based on action?

I remember thinking if this would ever be helpful when I was implementing the nav result feature. Turns out it is.
Would this work for your use case?

If ResultScreen becomes visible and after that, the FeedScreen becomes visible again and no value is received, then we consider it canceled. This would be done by the library, and the result received on onResult would be a wrapper to the current value which would allow us to check if nav result was canceled or there is actually a value:

sealed interface NavResult<out R> {
    object Canceled: NavResult<Nothing>
    data class Value<R>(val value: R): NavResult<R>
}

//...
    resultRecipient.onResult { confirmed ->
        when (confirmed) {
            is NavResult.Canceled -> println("canceled!!")
            is NavResult.Value -> if (confirmed.value) {
                navigator.navigate(SomeDestination)
            }
        }
    }

I think it would be perfect 👍

Hey @margarita-v !
So the new 1.3.5-beta release contains this new enhancement and deprecates the old onResult to replace it with onNavResult.
Please try it and let me know if that works well for you! 🙂

Thank you, now it works perfectly 🔥


HEVC in hls:  Segments are not started at video key frames

        location /publish/ {
            ts;
            ts_hls path=/var/media/hls segment=5:40 segments=3 ;

            client_max_body_size 0;
        }

25fps
GOP length == 190 frames
most of the ts files do not start at video key frame with length of 5s

My Try to  Walk Around: https://github.com/wellttllew/nginx-ts-module/commit/55df781f16711d1bbb7a6907648850cc365feda6


Usage with a single layout

You made it work with one fragment, why not with one single customizable layout?
Sample gist here: https://gist.github.com/Quinny898/592dd87fa28dad4bfba9
Works absolutely fine for me

Cool, just merged your code in AppIntro. Thanks!


Cache the latest screen and use it on scopedStore not to replay initial screen

Fixes #26
The idea is from https://github.com/pointfreeco/swift-composable-architecture/pull/667

Thanks very much @salqueng ! That's a clever fix for a subtle bug. I'm away for a couple of days but I'll merge and release when I get back.

Released in v0.2.0


JUnit5 TestResultAccumulator does not publish verification results

I saw Issue 694 had a fix for publishing verification results, so I tried with 3.5.19.  I found that for my project the verification results were not published.
Results for pacts are accumulated in the map testResults.  Unfortunately, the value for pact.hashCode() changes, so results for a pact are split across multiple entries.
The attached screenshot shows a test with 13 interactions where the results are split across 4 map entries.  You can see the same object identity is reported in all 4 keys.

My investigation of what might be contributing to the change in hash code has the following chain:

RequestResponsePact.iteractions
RequestResponseInteraction.response
Response.matchingRules

Initially matchingRules is an empty list, but after the pact interaction is validated, the list has two entries:

"header" -> "Category(name=header, matchingRules={})"
"body" -> "Category(name=body, matchingRules={})"

Other pact interactions are not mutated, and matchingRules remains an empty list.

I am facing the same issue. i am using the gradle plugin id "au.com.dius.pact" version "3.5.19"
So when I run gradle clean pactVerify -Dpact.verifier.publishResults=true - pactVerify runs fine but I don't see the last verified column in the pact broker being updated.

Verification results will only be published if the tests are not filtered and the Java system property pact.verifier.publishResults is set to true.

Oh, sorry, just re-read your description, and I understand the issue now.
I'll update the accumulator to use a deterministic hash which will not change.

Released 3.5.20 with this fix

Thanks for digging into this. The JUnit 4 module has the same issue.


Caching issue on wagtail 2.7

Can be replicated by copying production caching settings to dev settings using wagtail 2.7.
Some caching related items in core/signals.py and core/models.py.

Pages are cached that should not be, including the preview page, editing page, and other issues causing outdated pages to be served which makes things look like pages are not saving.


Improved: ripple effect now show on the entire ion-card(#416)

Related Issues

#416
Short Description and Why It's Useful

When an ion-item element is added inside an ion-card, it creates a new layer on top of the card, and by default, the ion-item element has a background colour that covers the card, making it appear as though the ripple effect is not covering the entire card.
Setting the background colour of the ion-item element to transparent within the ion-card allows the ripple effect to be visible underneath, creating the desired effect on the entire card.
I took the reference from this github issue : https://github.com/ionic-team/ionic-framework/issues/21210

Screenshots of Visual Changes before/after (If There Are Any)

3fb32fa5-12c7-46cd-9256-59a1ae71e337.webm
Contribution and Currently Important Rules Acceptance

[x] I read and followed contribution rules

We have handled this in job-manager using the same pattern: https://github.com/hotwax/job-manager/blob/779f7bef1af2a3051a51a9db93a0b53b359f6a86/src/views/Pipeline.vue#L701C1-L701C11


Add map caching to rviz_satellite

to save the servers and enable offline usage.

Tested and works on Indigo w/ OSX-Yosemite and Indigo on Ubuntu 14.04. Thanks for the change. :)
I have added mapscache directory to the gitignore so these files are not accidentally committed by anybody.


Fix the README for the certificates

Description
I noticed a formatting issue with the docs here.

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against a7f99f35b0c70351cece33e040f16a5aac3be8ac


aiyprojects-2018-04-13 not booting on RPI2 (Voice kit V. 1)

Hello, I just bought the Version 1 kit and tryed installing the kit with the image provided by AIY.
It successfully started (rainbow screen), it shows the Raspbian boot welcome, some drivers loading, and then when the desktop environment should appears it stays in the terminal screen whit the white "_" blinking (like it's loading something). But it seems to be in some kind of boot loop, because it blink constantly (showing that it's loading), then it disappear for 3 seconds and starts blinking again (like it's restarts the loading). Tryed burning the image several times and the problem persists. Thank you

Can you please try to reflash SD card using our latest image from https://github.com/google/aiyprojects-raspbian/releases? Make sure to use wall power adapter, i.e. at least 2.1 Amps.

Hello Dmitty, thanks for your answer. It seems I'm using the most recent version(2018-04-13 ). I'm also using a 2.1 amps charger from my cellphone. I'll try flashing and older one. Thank you!

Sure, let me know how that goes. Reboot loop seems to be very unlikely.


B 20068 int

B-20068
Summary
This story is a simple alteration to change the "Estimated Weight" value for NTSR shipments only to instead display it's data as the ntsRecordedWeight value of an NTSR Shipment on the PrimeUI. It does not impact any editing functions on the prime UI, only displaying the estimated weight as the previously recorded NTS weight, which is required to be entered by a TOO if not a Service Counselor before the Prime can see the shipment.
Please ensure client tests are passing, and other types of shipments still show the "Estimated Weight" as the actual estimated weight value.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

How to test

This is best tested with an NTSR set up on a new move. Log in as a customer, create a new move.
Create two shipments, both NTSR.
Once the shipments are submitted, log in as a Service Counselor.
On one of the shipments, ensure you enter the previously recorded NTS weight. On the other shipment, do NOT enter the previously recorded NTS weight.
Submit the shipments.
Log in as a TOO.
Ensure that the previously recorded NTS weight is present for the shipment you already added it to.
Ensure that the previously recorded NTS weight is required for the other shipment. Enter an amount.
Submit the moves.
Log in as a Prime, locate the move you've been using.
On the shipment details page, ensure both Estimated Weight values match those you had entered in the steps above.

View other shipment types as a Prime, and ensure their Estimated Weights match the estimated weight data in your network console/database.
Ensure client tests passing.

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

TOO previously recorded weight

Prime Sim previously recorded weight

TOO no previously recorded weight

Prime Sim no previously recorded weight


Assert statement calls a function which has side effects

Oh, indeed. Waiting for tests to finish, then merging

@badboy should be fine to merge


The verification-keys field in runtime policy is a string, but the specification expected an array

Is your issue a feature request? If so, please raise it as an enhancement
Environment

OS / version: N/A
Processor architecture: N/A
TPM Manufacturer: N/A
Keylime version: current master (691f713)

Description
The enhancement that introduced runtime policies specified the verification-keys as an array:
https://github.com/keylime/enhancements/blob/2a462b60a1f40f257abf728af3269c1301752adc/70_ima_policy.md?plain=1#L241-L246
The code implemented the field as a single string:
https://github.com/keylime/keylime/blob/0b57e6c97cbfde83d2ab4a04952e2cf33b550e6f/keylime/ima/ima.py#L89
Expected behavior vs. actual behavior
Expected: The implemented schema should follow the specified schema
Actual: The implemented schema differs from the specified schema
Steps to reproduce problem

Compare the specification with the implementation

Relevant logs
Attach any relevant log files that can help to debug your issue.

@mbestavros @THS-on Could you please comment about this?

The changes required to fix this are extensive, with no benefits: in the end, using a JSON string is actually more flexible than replacing it with a list of  the public keys.
I propose we modify the specification documentation to align it with what was actually implemented. Also, the changes should include a schema validation of the JSON used in the verification-keys

@ansasaki yes agree, then lets go this route.

The JSON schema validation for the verification-keys content was added as part of https://github.com/keylime/keylime/pull/1638, via commit c724a9d51d527bdbeba0840d398d017325b46fdf
The missing part is fixing the documentation to reflect the actual implemented schema


#######

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

App Id
dy5gqtyjjpj2u
AWS Region
ap-northeast-1
Amplify Hosting feature
Deployments
Describe the bug
We are experiencing an issue with URL previews for LINE Messenger when deploying our Next.js app using OGP settings on AWS Amplify. The URL preview feature works correctly for Facebook Messenger, Skype, Twitter, and other platforms, but LINE Messenger does not display the preview.
To troubleshoot, we deployed the application on an EC2 instance and observed that the URL preview works fine for all the mentioned social networking platforms, including LINE Messenger. We used the same codebase to enable URL preview functionality for LINE Messenger on both EC2 and Amplify.
We would like to understand why the URL preview is not functioning for LINE Messenger when the application is deployed on AWS Amplify.
Expected behavior
Expecting URL Preview functionality in AWS Amplify should work for LINE Messenger.
Reproduction steps

Build Settings
version: 1
frontend:
  phases:
    preBuild:
      commands:
        - npm install
    build:
      commands:
        - npm run build
  artifacts:
    baseDirectory: .next
    files:
      - '**/*'
  cache:
    paths:
      - node_modules/**/*

Log output

# Put your logs below this line

Additional information

Hi @monjurulbjit521 👋 , thanks for reaching out to us!
I was able to reproduce a similar behavior while trying to preview the website URL (for a sample Next.js app) in the Line Messenger mobile app. I am investigating into this further to narrow down the root cause of this behavior and will keep you posted with any updates.

@Jay2113 ...Thanks a lot for checking the issue.

@Jay2113 Thanks for your support.
I wanted to bring an interesting observation to your attention regarding our Amplify access logs. Upon reviewing the logs, I noticed a consistent pattern where requests with the user agent "facebookexternalhit/1.1;line-poker/1.0" receive a 400 status code from Amplify. This particular information could be valuable in your investigation.
As the user agent suggests, these requests are likely associated with Facebook and LINE crawlers. It seems that this behavior might be the reason behind the URL preview functionality not working as expected when our application is hosted on Amplify. We have tried different AWS accounts but it seems that the same 400 status code same user agent.


Invalid Add-on repository! when trying to install it

Hi, im trying to install this repository on my home assistant but when i try to add the repository this message continues to pop up:

The link i'm using is: https://github.com/tijsverkoyen/Home-Assisant-FusionSolar-Kiosk , i think i'm doing it right but it doesn't work, ive tried it with the HA installation i use in my house and i've tried it in a fresh install and it doesn't work on neither of them.
Thanks for the help!

You need to install HACS and inside that install the link you have.
HACS / integrations / push the three dots up right -> Custom repositories

See https://hacs.xyz/docs/faq/custom_repositories also


Remove experiment: Optimise app onboarding

Task/Issue URL:
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #3085   👈

This comment was auto-generated by Graphite.


Feature/example hometitle

Hey Sun, PRs need to target the develop branch, not the master branch. Merging in master deploys straight to production (!!!)

@ezweb28 in case you didn't know, we were thinking the PR creator merges their PR once it's approved


feat(VerifierFactory): add connection feature to both of socket.io-type Validator and http-type Validator

This PR is related with #639

(main purpose) enhance VerifierFactory in order to make Verifier communicate with both of socket.io-type and http-type Validators
(sub purpose) refactor related codes in order to separate with application and platform

@petermetz I have added some files, could you please approve this PR again?


compiler doesn't support tf.keras.layers.Flatten

Any plan to update the compiler managing also the layers tf.keras.layers.Flatten ?
That function contain the function np.Prod() that is not managed by the compiler bonnet_model_compiler_2018_04_26

I replaced Flatten with the instruction Reshape but the compiler provide an other error message
2018-07-25 18:57:52.697603: F external/org_tensorflow/tensorflow/contrib/lite/toco/export_tensorflow.cc:1863] Unhandled operator type TensorFlowTile

I replaced tf.tile with the instruction tf.expand_dims as below
#prior_boxes_tensor = tf.tile(prior_boxes_tensor, pattern)
prior_boxes_tensor = tf.expand_dims(tf.ones([tf.shape(x)[0], 1]), 1) * prior_boxes_tensor

but  the compiler (bonnet_model_compiler_2018_04_26) provide an other error message. I really hope that this reporting will give the message that the compiler should be updated to simplify the life or the final user. Waiting that any idea how to fix it ?
2018-08-01 20:33:09.622163: F external/org_tensorflow/tensorflow/contrib/lite/toco/export_tensorflow.cc:1863] Unhandled operator type TensorFlowMax

May I ask what's the model architecture?
Is this one of the supported architectures listed on Vision Kit website:
https://aiyprojects.withgoogle.com/vision/
(search for "TENSORFLOW MODEL COMPILER")

Hi,
No I am using an ssd 256x256 based on mobilenet alpha 0.125 written in keras and converted in TensorFlow. The graph is too big so I am not able to find where the TF.Max is used.

hmm,
i see. you trained with Keras and ten converted to TF.
we only tested the workflow on models trained with TF.
there is no guarantee that the model trained with other framework, then converted to TF, could pass the compiler.
could you please train the model with say TF/slim?


fix: Adjust Meet the Specialists animation

This PR resolves CX-3588
Description
Adjust the animation of the "Meet the Specialists" card as suggested here.
https://user-images.githubusercontent.com/4691889/234828761-29c459a3-662c-464f-95ef-71c3bfea9239.mp4

Before
After

https://user-images.githubusercontent.com/4691889/234829056-754a2f24-48b2-44c6-8c63-57e1aa677852.mp4
https://user-images.githubusercontent.com/4691889/234828761-29c459a3-662c-464f-95ef-71c3bfea9239.mp4

PR Checklist

[ ] I have tested my changes on iOS and Android.
[ ] I hid my changes behind a feature flag, or they don't need one.
[ ] I have included screenshots or videos, or I have not changed the UI.
[ ] I have added tests, or my changes don't require any.
[ ] I added an app state migration, or my changes do not require one.
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

Thanks for the update @olerichter00 - looks great


fastboot support

https://github.com/jelhan/ember-local-storage-decorator/blob/6702fab573f14edf3391443c5bf84e9277e862d3/addon/index.js#L6
as I know, there is no window in fastboot, this logic could be moved to initializer

Good catch. Need to add guards for FastBoot at all places at which we use either window.addEventListener or window.localStorage.
FastBoot documentation for addon author discusses two approaches:

Optional chaining
Using browser-only APIs

I would prefer the first. Don't want to split the code over multiple places.
Happy to accept a PR.

I just noticed that FastBoot support is not as simple as expected. The decorator uses a global cache for local storage values: https://github.com/jelhan/ember-local-storage-decorator/blob/f80d55e0379a3ea285eb19500e3f2a454fd43bd3/addon/index.js#L3-L4
In FastBoot many application instances may run in parallel. To support FastBoot the caching implementation must be changed to cache the value per application instance.


[incubator][VC] test: add secret test

Signed-off-by: zhuangqh<EMAIL_ADDRESS>

/lgtm
/approve


Make sure the DB service could be generated.

In my previous fix #4754, I removed many unnecessary generated metrics and meta, but also remove the metadata of DB conjecture service, which make the DB doesn't show up in the DB dashboard selector.
This PR is bringing that back. Also, this include a small fix about OAL function change, thermodynamic renamed to histogram.

Codecov Report

Merging #4757 into master will decrease coverage by 22.06%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d713076...81f3f2a. Read the comment docs.


💡 [REQUEST] - V 2.6 finetune multiple images example

起始日期 | Start Date
No response
实现PR | Implementation PR
No response
相关Issues | Reference Issues
No response
摘要 | Summary
Since V2.6 now accepts multiple images per sample, could you please update the finetune readme with an example for how the data json should look like when doing LoRA finetuning with multiple images per sample in one single user turn?
基本示例 | Basic Example

缺陷 | Drawbacks
I'm not sure how to format the data for multi-image LoRA finetuning. An example would help.
未解决问题 | Unresolved questions
No response

Closing as duplicate of #386 .

In V2.6 we can (which is awesome!)
Hi @Mihaiii  ,  can you advise how to fine-tune with multiple images in V2.6, I'm struggling to see how to do it?

In MiniCPM-V/finetune/dataset.py, I see it opens a single image per conversation
image = Image.open(self.raw_data[i]["image"]).convert("RGB")

@chris-tng I know it's possible, but I don't know how to do it. This is why I opened this issue: I'm also looking for a script with an example and how to prepare the data.

@Mihaiii  In this thread https://github.com/OpenBMB/MiniCPM-V/issues/386, @qyc-98 has commented this will be supported in near future, so I assume it's not supported now

@chris-tng I see, thanks! I thought the message meant they will provide the scripts for finetuning on multiple images in the near future, not that it's not supported atm. But it's strange it's not supported, given the training was done with multiple images per sample.

It's a bit weird that the scripts in the repo are set to v2.6.

looks like latest commit enables support for multi-image fine-tuning, I will give it a try
https://github.com/OpenBMB/MiniCPM-V/commit/cd64150b5122f8ee8c677d481c97918485129b52


Maven Cleanup

Target to fix #37

@Birdasaur THis should be ready to merge if you think it's good.


[release-1.0] RHEL 10 Beta preference

What this PR does / why we need it:
This adds preferences intended to be used with the RHEL 10 Beta.
NOTE(lyarwood): This is heavily modified version of the initial commit
to v1.1.0 with the arm64 preference dropped entirely. A part of
https://github.com/kubevirt/common-instancetypes/commit/388f204473aa2729d7316395dc009a4a58a9271e is also included adding
functional test coverage for RHEL 9.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

Added preferences for RHEL 10 Beta

/lgtm


Wanno drijfhout more metadata

Replacing #53

@wanno-drijfhout Seems to be solved by adding a Jackson mixin: https://github.com/openapi-tools/swagger-maven-plugin/pull/58/files#diff-fccd1c183e3e6283d6f49972cc4f7161

Thanks! I didn't consider Mixins before but I'm happy to see it works!


Added error logs when a build crashes when trying to finish a build

I have added logs of some unexpected situations that can happen.
BuildServices are closed when Gradle's state is ReadyToReset. So when an error occurs in the service close function, Gradle cannot shut down correctly because it cannot change the state from ReadyToReset to BuildFinishHooks. In this case, Gradle will not report anything about the failure, the configuration will be terminated as successful, but execution will not start. Also nothing will happen in debug logging mode.
I thought about calling buildListener.buildFinished somewhere to notify about the problem, but I'm not sure I can do that in the ReadyToReset state, so I just added the logs for this rare case that caused me to spend a lot of time debugging the Gradle source code.

@bot-gradle test this

Sorry but I'm afraid you're not allowed to do this.

I've triggered the following builds:

Pull Request Feedback (Trigger) (Check)

Build Scan

The following builds have failed:

Pull Request Feedback (Trigger) (Check)

Build Scan

Thank you for your interest in Gradle.
Please create an issue first justifying these changes. We cannot accept them otherwise.

Make sure to include a reproducer in the opened issue. It is very likely that handling BuildService.close exception should be done elsewhere so that other services still can be closed and then the flow of the end of the build still happens as expected.

@ljacomet Ok, also i will try to make a little better solution for the issue


🌐 Add Japanese translation for docs/ja/docs/tutorial/request-forms-and-files.md

This PR translates the tutorial/request-forms-and-files.md to Japanese.
Please review tutorial/request-forms-and-files.md.
~Issue #1571 generates a new directory to support Japanese.
PR #1656 generates a new directory for tutorial.
I will fix dependency after #1571 & #1656 are merged.~

It seems like the changes requested by @tokusumi are handled, and as @SwftAlpc is one of the champions of the Japanese translations, I'll go ahead and merge this. :rocket:


Support #[rustc_args_required_const(...)] for simd intrinsics

For example:
// https://github.com/rust-lang/stdarch/blob/ef6b0690192f1cfc753af698695c2ecde0c7b991/crates/core_arch/src/x86_64/avx2.rs#L31
#[rustc_args_required_const(1)]
pub unsafe fn _mm256_extract_epi64(a: __m256i, imm8: i32) -> i64 {
    let imm8 = (imm8 & 3) as u32;
    simd_extract(a.as_i64x4(), imm8)
}

Calling these kind of intrinsics will currently panic with a message like: simd_extract* idx not const: "move _8".

Using -Zmir-opt-level=3 doesn't help. While the function gets inlined, there is no constant propagation performed to get rid of the (imm & 3) as u32 part.

I made these functions panicat runtime for now.

Fixing https://github.com/rust-lang/rust/issues/70271 would fix this.

There has been a discussion about this on zulip starting at https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/change.20rustc_args_required_const.20to.20per.20arg.20attribute/near/191390244.


jina.excepts.FlowMissingPodError: chunk_indexer is not in this flow, misspelled name?

Problem
Running python app.py index results in:
           JINA@202354[W]:parser FlowPod can not recognize the following args: ['--logserver'], they are ignored. if you are using them from a global args (e.g. Flow), then please ignore this message
           JINA@202354[W]:parser FlowPod can not recognize the following args: ['--logserver'], they are ignored. if you are using them from a global args (e.g. Flow), then please ignore this message
           JINA@202354[W]:parser FlowPod can not recognize the following args: ['--logserver'], they are ignored. if you are using them from a global args (e.g. Flow), then please ignore this message
           JINA@202354[W]:parser FlowPod can not recognize the following args: ['--logserver'], they are ignored. if you are using them from a global args (e.g. Flow), then please ignore this message
           JINA@202354[W]:parser FlowPod can not recognize the following args: ['--logserver'], they are ignored. if you are using them from a global args (e.g. Flow), then please ignore this message
           Flow@202354[S]:successfully built Flow from a yaml config
           JINA@202354[W]:parser FlowPod can not recognize the following args: ['--logserver'], they are ignored. if you are using them from a global args (e.g. Flow), then please ignore this message
Traceback (most recent call last):
  File "app.py", line 54, in <module>
    index()
  File "app.py", line 25, in index
    with f:
  File "/home/alexcg/work/repos/examples/my-first-jina-app/star_trek/env/lib/python3.8/site-packages/jina/flow/__init__.py", line 462, in __enter__
    return self.start()
  File "/home/alexcg/work/repos/examples/my-first-jina-app/star_trek/env/lib/python3.8/site-packages/jina/flow/__init__.py", line 496, in start
    self.build(copy_flow=False)
  File "/home/alexcg/work/repos/examples/my-first-jina-app/star_trek/env/lib/python3.8/site-packages/jina/flow/__init__.py", line 449, in build
    raise FlowMissingPodError(f'{start} is not in this flow, misspelled name?')
jina.excepts.FlowMissingPodError: chunk_indexer is not in this flow, misspelled name?

Note: Running same command previously spat out jina.excepts.FlowMissingPodError: doc_indexer is not in this flow, misspelled name?
Why happening?
Misconfigured YAML?
Environment
During cookiecutter:

task_type: nlp
index_type: strings

After running cookiecutter to create the files:
(Note I'm doing this in a virtual environment to isolate it from my main system)
virtualenv env
source env/bin/activate
pip install -r requirements
python app.py index

this is because a typo in needs argument, fixed in #16

I have merged the typo fix for flow/index for chunk and doc indexer. Let's have another round of testing to see if the issue persists.


Add support for vsocks

If host support vsocks use them to comunicate shim/runtime directly with the agent

Ah nice, that's something I was about to open because we've been advertising vsock support but never took the time to implement it and test it.
@devimc could you describe the way you're gonna implement this before your actually start the development. This is a task involving several repos, and it would be good to clarify here what needs to happen to fully support it.

@jcvenegas @sboeuf following the discussion in the meeting this week, I discussed with @bergwolf. if there was nothing done in this issue, @lifupan and @bergwolf could help to add the vsock support.

It's up to @jcvenegas on this one since he started to work on it. @jcvenegas let @bergwolf and @lifupan know if you need help!

@sboeuf @gnawux I'll be working on this,  @gnawux  @bergwolf  @lifupan I am happy to talk about any implementation idea you have.


Github project description

I edited the description from
Free (standard conform) library for interfacing hardware drivers to Modelica models. There is support for joysticks, keyboards, UDP, shared memory, AD/DA converters and other devices.

to
Free library for interfacing hardware drivers to Modelica models. There is support for joysticks, keyboards, UDP, shared memory, AD/DA converters and other devices.

thus deleting the "standard conform" which is misleading and simply does not hold as long as #1669 (= first issue of #54) and #71 aren't resolved. Once they are properly fixed it could be reverted.

#71 is resolved by now.

Followed up by #112.


005107 von Popp & Co, Temperature and Config not working

Is your problem within Home Assistant (Core or Z-Wave JS Integration)?
YES, BUT a Home Assistant developer has told me to come here
Is your problem within Z-Wave JS UI (formerly ZwaveJS2MQTT)?
YES, BUT a Z-Wave JS UI developer has told me to come here
Checklist

[X] I have checked the troubleshooting section and my problem is not described there.

[X] I have read the changelog and my problem was not mentioned there.

Describe the bug
What causes the bug?
its constant
What do you observe?
the siren is detected, but there are is nothing else detected but an on/off funktion.
The configuration doesn‘t work but instead it links to the correct parameter list https://devices.zwave-js.io/?jumpTo=0x0154:0x0004:0x0002:0.0
There is no way to disable Tamper or read the temperature sensor
What did you expect to happen?
Steps to reproduce the behavior:

Go to '...'
Click on '...'
Scroll down to '...'
See error

Device information
Manufacturer: Popp&Co
Model name: Solar Outdoor siren
Node ID in your network: 179
How are you using node-zwave-js?

[ ] zwave-js-ui (formerly zwavejs2mqtt) Docker image (latest)
[ ] zwave-js-ui (formerly zwavejs2mqtt) Docker image (dev)
[ ] zwave-js-ui (formerly zwavejs2mqtt) Docker manually built (please specify branches)
[ ] ioBroker.zwave2 adapter (please specify version)
[X] HomeAssistant zwave_js integration  (please specify version)
[ ] pkg
[ ] node-red-contrib-zwave-js (please specify version, double click node to find out)
[ ] Manually built from GitHub (please specify branch)
[ ] Other (please describe)

Which branches or versions?
version:
zwave-js-ui: 8.23.2
zwave-js: 11.13.0
Did you change anything?
yes (please describe)
If yes, what did you change?
No response
Did this work before?
No, it never worked anywhere
If yes, where did it work?
No response
Attach Driver Logfile
I am sorry, this is too complicated for me. I realize this is a developer forum, but I cannot provide this information from homeassistant and I don‘t know how to report this bug otherwise.

Here's how to create the logs in Home Assistant: https://www.home-assistant.io/integrations/zwave_js#how-to-access-the-z-wave-logs
And this section describes how to re-interview: https://www.home-assistant.io/integrations/zwave_js#device-panel
To diagnose, please:

start logging in a separate window
do a re-interview
wait until the device is ready again
download the log from the log window and drag/drop it here to upload

Thanks for getting back to me and thanks again for the howto produce the proper log.
The NodeID of the siren is 179 btw.
zwave_js.log

BTW there are 2 sirens of that brand. One has the temperature sensor (the older one as mine) and one has not.
Cheers

I just realize, that this device is connected with S0 legacy security. The key for this is:
995D23581BE5F2E110898FADB07C1C67

Is there some kind of filter active in the log? If so, please disable it and retry. I don't see any outgoing commands, only some responses from the stick.

Hmm, I wouldn't know of any filter or how I could set or reset them. Maybe I an doingg something wrong?
I used two different browser instances with HA. One to start the log and the other to reinterview the device. Is that correct?
I have just produced another log in the silly mode, hoping you could get more information from this.
zwave_js.log

maybe this is better?
home-assistant_zwave_js_2023-09-06T07-42-06.026Z.log

Hmm no, the first one is still incomplete, the other is unrelated. It looks like you're using Z-Wave JS UI though? In that case there's a better way to get the log:

Write the logfile: https://zwave-js.github.io/zwave-js-ui/#/troubleshooting/generating-logs?id=driver-logs, no need to keep the log tab open
Download it: https://zwave-js.github.io/zwave-js-ui/#/troubleshooting/generating-logs?id=download-zip (only the zwavejs_<date>.log is required

zwavejs_2023-09-06.log
There are far too many logging option...
Thanks for your patience

The device doesn't respond when the list of encrypted commands is requested. Normally this means the security key does not match the one the device has. Try this:

Exclude the device
Factory reset it to remove its old key (should be explained in the manual)
Include it again

Thanks, I will try an will get back to you asap.

Hi Al...
this did the trick.
Everything works now as expected. Even the configuration and the temperature sensor.
I'm very happ now.
Cheers


Fuzzy search sorting seems broken

Step 1 all is good

Step 2 all is broken

@isidorn I do not see an issue here, you typed "partsService" which does not exist?


2.6-beta: HashCheck causes error when hash is present in URL

As reported on math.stackechange, when a URL has a hash component, there is an error message about isMathJaxNode not being defined.  This is due to calling this.isMathJaxNode from within Hub.Startup.HashCheck, while isMathJaxNode is in Hub not Hub.Startup.

This is fixed in the issue1273 branch of my fork of MathJax.

=> Merged

=> In testsuite
Configuration/Hub/positionToHash-3.html


StorageSyncSelfServiceRestore cmdlets don't exist in the StorageSync.Management.PowerShell.Cmdlet.dll module

Trying to enable Self Service Restore and when I look at the cmdlets in the module, none with "StorageSyncSelfServiceRestore" exist. Here's the list:
PS C:\Users\mirendadmin> gcm -Module StorageSync.Management.PowerShell.Cmdlets
CommandType     Name                                               ModuleName

Cmdlet          Get-AzureRmStorageSyncCloudEndpoint                StorageSync.Management.PowerShell.Cmdlets
Cmdlet          Get-AzureRmStorageSyncGroup                        StorageSync.Management.PowerShell.Cmdlets
Cmdlet          Get-AzureRmStorageSyncServer                       StorageSync.Management.PowerShell.Cmdlets
Cmdlet          Get-AzureRmStorageSyncServerEndpoint               StorageSync.Management.PowerShell.Cmdlets
Cmdlet          Get-AzureRmStorageSyncService                      StorageSync.Management.PowerShell.Cmdlets
Cmdlet          Invoke-AzureRmStorageSyncChangeDetection           StorageSync.Management.PowerShell.Cmdlets
Cmdlet          Invoke-AzureRmStorageSyncFileRecall                StorageSync.Management.PowerShell.Cmdlets
Cmdlet          Login-AzureRmStorageSync                           StorageSync.Management.PowerShell.Cmdlets
Cmdlet          Move-AzureRmStorageSyncService                     StorageSync.Management.PowerShell.Cmdlets
Cmdlet          New-AzureRmStorageSyncCloudEndpoint                StorageSync.Management.PowerShell.Cmdlets
Cmdlet          New-AzureRmStorageSyncGroup                        StorageSync.Management.PowerShell.Cmdlets
Cmdlet          New-AzureRmStorageSyncServerEndpoint               StorageSync.Management.PowerShell.Cmdlets
Cmdlet          New-AzureRmStorageSyncService                      StorageSync.Management.PowerShell.Cmdlets
Cmdlet          Register-AzureRmStorageSyncServer                  StorageSync.Management.PowerShell.Cmdlets
Cmdlet          Remove-AzureRmStorageSyncCloudEndpoint             StorageSync.Management.PowerShell.Cmdlets
Cmdlet          Remove-AzureRmStorageSyncGroup                     StorageSync.Management.PowerShell.Cmdlets
Cmdlet          Remove-AzureRmStorageSyncServerEndpoint            StorageSync.Management.PowerShell.Cmdlets
Cmdlet          Remove-AzureRmStorageSyncService                   StorageSync.Management.PowerShell.Cmdlets
Cmdlet          Reset-AzureRmStorageSyncServerCertificate          StorageSync.Management.PowerShell.Cmdlets
Cmdlet          Set-AzureRmStorageSyncServerEndpoint               StorageSync.Management.PowerShell.Cmdlets
Cmdlet          Set-HfsSubscriptionState                           StorageSync.Management.PowerShell.Cmdlets
Cmdlet          Unregister-AzureRmStorageSyncServer                StorageSync.Management.PowerShell.Cmdlets
PS C:\Users\mirendadmin> gcm -Module StorageSync.Management.ServerCmdlets
CommandType     Name                                               ModuleName

Cmdlet          Get-StorageSyncAgentAutoUpdatePolicy               StorageSync.Management.ServerCmdlets
Cmdlet          Get-StorageSyncFileRecallResult                    StorageSync.Management.ServerCmdlets
Cmdlet          Get-StorageSyncFileTieringResult                   StorageSync.Management.ServerCmdlets
Cmdlet          Get-StorageSyncHeatStoreInformation                StorageSync.Management.ServerCmdlets
Cmdlet          Get-StorageSyncNetworkLimit                        StorageSync.Management.ServerCmdlets
Cmdlet          Get-StorageSyncOrphanedTieredFiles                 StorageSync.Management.ServerCmdlets
Cmdlet          Get-StorageSyncProxyConfiguration                  StorageSync.Management.ServerCmdlets
Cmdlet          Get-StorageSyncServer                              StorageSync.Management.ServerCmdlets
Cmdlet          Get-StorageSyncServerEndpoint                      StorageSync.Management.ServerCmdlets
Cmdlet          Invoke-StorageSyncCloudTiering                     StorageSync.Management.ServerCmdlets
Cmdlet          Invoke-StorageSyncFileRecall                       StorageSync.Management.ServerCmdlets
Cmdlet          Invoke-StorageSyncServerGarbageCollection          StorageSync.Management.ServerCmdlets
Cmdlet          Invoke-StorageSyncServerScrubbing                  StorageSync.Management.ServerCmdlets
Cmdlet          New-StorageSyncNetworkLimit                        StorageSync.Management.ServerCmdlets
Cmdlet          Remove-StorageSyncNetworkLimit                     StorageSync.Management.ServerCmdlets
Cmdlet          Remove-StorageSyncOrphanedTieredFiles              StorageSync.Management.ServerCmdlets
Cmdlet          Remove-StorageSyncProxyConfiguration               StorageSync.Management.ServerCmdlets
Cmdlet          Reset-StorageSyncServer                            StorageSync.Management.ServerCmdlets
Cmdlet          Set-StorageSyncAgentAutoUpdatePolicy               StorageSync.Management.ServerCmdlets
Cmdlet          Set-StorageSyncProxyConfiguration                  StorageSync.Management.ServerCmdlets

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 61bb35a5-e2f3-1ce8-1d6e-a926374de6c8
Version Independent ID: e4b3065a-5351-26ef-cdbb-ef2eaea3f301
Content: Deploy Azure File Sync
Content Source: articles/storage/files/storage-sync-files-deployment-guide.md
Service: storage
Sub-service: files
GitHub Login: @roygara
Microsoft Alias: rogarana

@Mirend Thanks for the feedback! We are currently investigating and will update you shortly.

@Mirend Thanks for the feedback! I have assigned the issue to the content author to investigate further review

@Mirend Thanks for reaching out, I repro'd and found the same issue and circled back with the product team.
Turns out this is actually exclusively limited to v9 of the sync agent, which is currently in the process of rolling out. The cmdlets don't appear in v8. I'll update the doc to better reflect that.
@SumanthMarigowda-MSFT can you swap this to doc enhancement?

The change has been merged and will be live later today.
Again, thanks for reaching out and bringing this to our attention, we appreciate it!
#please-close