feat: proxyevm module

Effects

[ ] Soft update
[x] Breaking change
[ ] Chain fork related

Major Reviewer
@yoosah

Background

Summary

Checklist

[ ] Backward compatible?
[ ] Test enough in your local environment?
[ ] Add related test cases?

Plain ERC20 token transfer consumes 1.2M gas units, while direct EVM call consumes 300K
Test code: https://github.com/xpladev/xpla/blob/test/proxyevm/integration_test/integration_test.go#L795-L892
Solidity bytecode: https://github.com/xpladev/xpla/blob/test/proxyevm/integration_test/misc/token.sol.bin

Update

Gas usage captured in Antehandler as: https://github.com/xpladev/xpla/commit/2c9bb1cfdd0c22d1c5cc79432794ffb5f33e2f7d
Almost no difference in Antehandler

Tx from EVM directly (thru 8545) vs  Tx from Proxy EVM directly (thru 9090)

EVM ante handler
SetUpContext consumed 0
MempoolFee consumed 0
MinGasPrice consumed 7702
ValidateBasic consumed 23093
SigVerification consumed 30782
AccVerification consumed 30782
GasConsume consumed 61075
CanTransfer consumed 84168
GasConsume 2 consumed 114536
Increment sender seq consumed 123278
GasWanted consumed 138669
Event emission consumed 138769

Cosm ante handler
Limit simulator consumed 0
Count tx consumed 3429
RejectExtentionOption consumed 3429
MempoolFee consumed 3429
Min gas fee consumed 11131
ValidateBasic consumed 11131
Tx timeout height consumed 11131
ValidateMemo consumed 16533
Consume Gas for tx size consumed 25895
Deduct Fee consumed 40797
Set pub key consumed 52029
Validator sig count consumed 57431
Sig gas consume consumed 85604
Gas fee check 2 consumed 87375
Inc fee check consumed 98856
Ibc ante fee check consumed 98856
Gas fee check 3 consumed 114247

With the low gas limit (around 300000), it's enough in Antehandler, so the tx submited
But the gas deplete when EVM call complete and processing with the state db
Debug trace:

github.com/cosmos/cosmos-sdk/baseapp.newOutOfGasRecoveryMiddleware.func1
    github.com/cosmos/cosmos-sdk@v0.45.9/baseapp/recovery.go:55
github.com/cosmos/cosmos-sdk/baseapp.newRecoveryMiddleware.func1
    github.com/cosmos/cosmos-sdk@v0.45.9/baseapp/recovery.go:39
github.com/cosmos/cosmos-sdk/baseapp.processRecovery
    github.com/cosmos/cosmos-sdk@v0.45.9/baseapp/recovery.go:28
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).runTx.func1
    github.com/cosmos/cosmos-sdk@v0.45.9/baseapp/baseapp.go:632
    runtime.gopanic\n\truntime/panic.go:838
github.com/cosmos/cosmos-sdk/store/types.(*basicGasMeter).ConsumeGas
    github.com/cosmos/cosmos-sdk@v0.45.9/store/types/gas.go:99
github.com/cosmos/cosmos-sdk/store/gaskv.(*Store).Get
    github.com/cosmos/cosmos-sdk@v0.45.9/store/gaskv/store.go:43
github.com/cosmos/cosmos-sdk/store/prefix.Store.Get
    github.com/cosmos/cosmos-sdk@v0.45.9/store/prefix/store.go:68.                    <- from here
github.com/cosmos/cosmos-sdk/x/params/types.Subspace.GetIfExists
    github.com/cosmos/cosmos-sdk@v0.45.9/x/params/types/subspace.go:118
github.com/evmos/ethermint/x/evm/keeper.Keeper.GetParams
    github.com/evmos/ethermint@v0.19.3/x/evm/keeper/params.go:14
github.com/xpladev/xpla/x/proxyevm/keeper.msgServer.CallEVM                             <- also from here
    github.com/xpladev/xpla/x/proxyevm/keeper/msg_server.go:55
github.com/xpladev/xpla/x/proxyevm/types._Msg_CallEVM_Handler.func1
    github.com/xpladev/xpla/x/proxyevm/types/tx.pb.go:205
github.com/cosmos/cosmos-sdk/baseapp.(*MsgServiceRouter).RegisterService.func2.1
    github.com/cosmos/cosmos-sdk@v0.45.9/baseapp/msg_service_router.go:113
github.com/xpladev/xpla/x/proxyevm/types._Msg_CallEVM_Handler
    github.com/xpladev/xpla/x/proxyevm/types/tx.pb.go:207
github.com/cosmos/cosmos-sdk/baseapp.(*MsgServiceRouter).RegisterService.func2
    github.com/cosmos/cosmos-sdk@v0.45.9/baseapp/msg_service_router.go:126
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).runMsgs
    github.com/cosmos/cosmos-sdk@v0.45.9/baseapp/baseapp.go:760
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).runTx
    github.com/cosmos/cosmos-sdk@v0.45.9/baseapp/baseapp.go:717
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).DeliverTx
    github.com/cosmos/cosmos-sdk@v0.45.9/baseapp/abci.go:282
github.com/tendermint/tendermint/abci/client.(*localClient).DeliverTxAsync
    github.com/tendermint/tendermint@v0.34.21/abci/client/local_client.go:93
github.com/tendermint/tendermint/proxy.(*appConnConsensus).DeliverTxAsync
    github.com/tendermint/tendermint@v0.34.21/proxy/app_conn.go:85
github.com/tendermint/tendermint/state.execBlockOnProxyApp
    github.com/tendermint/tendermint@v0.34.21/state/execution.go:320
github.com/tendermint/tendermint/state.(*BlockExecutor).ApplyBlock
    github.com/tendermint/tendermint@v0.34.21/state/execution.go:140
github.com/tendermint/tendermint/consensus.(*State).finalizeCommit
    github.com/tendermint/tendermint@v0.34.21/consensus/state.go:1659
github.com/tendermint/tendermint/consensus.(*State).tryFinalizeCommit
    github.com/tendermint/tendermint@v0.34.21/consensus/state.go:1568
github.com/tendermint/tendermint/consensus.(*State).enterCommit.func1
    github.com/tendermint/tendermint@v0.34.21/consensus/state.go:1503
github.com/tendermint/tendermint/consensus.(*State).enterCommit
    github.com/tendermint/tendermint@v0.34.21/consensus/state.go:1541
github.com/tendermint/tendermint/consensus.(*State).addVote
    github.com/tendermint/tendermint@v0.34.21/consensus/state.go:2155
github.com/tendermint/tendermint/consensus.(*State).tryAddVote
    github.com/tendermint/tendermint@v0.34.21/consensus/state.go:1953
github.com/tendermint/tendermint/consensus.(*State).handleMsg
    github.com/tendermint/tendermint@v0.34.21/consensus/state.go:856
github.com/tendermint/tendermint/consensus.(*State).receiveRoutine
    github.com/tendermint/tendermint@v0.34.21/consensus/state.go:763

out of gas in location: ReadPerByte; gasWanted: 120000, gasUsed: 120952: out of gas

High gas usage occurs in evmKeeper.EstimateGas which only proxyEVM tx passes

Gas usage captured in Antehandler & kpper as: https://github.com/xpladev/xpla/commit/351ed231d2486c78ed2e9b7d5c5e3d2aa092f0be

Cosm ante handler
Limit simulator consumed 0
Count tx consumed 3429
RejectExtentionOption consumed 3429
MempoolFee consumed 3429
Min gas fee consumed 11131
ValidateBasic consumed 11131
Tx timeout height consumed 11131
ValidateMemo consumed 16533
Consume Gas for tx size consumed 25905
Deduct Fee consumed 40837
Set pub key consumed 52069
Validator sig count consumed 57471
Sig gas consume consumed 85644
Gas fee check 2 consumed 87415
Inc fee check consumed 98896
Ibc ante fee check consumed 98896
Gas fee check 3 consumed 114287
keeper, GetTxIndexTransient 114387
keeper, Address processing 114387
keeper, GetParams 122076
keeper, msg.Fund processing 122076
callEVM, head of call evm 123847
callEVM, in commit 123847
callEVM, after gas estimation 1108773
callEVM, after call evm 1195750
keeper, after evm execution 1195750
keeper, after add attr1 1195750
keeper, after add attr2 1195750
keeper, after add contract res 1195750
keeper, after after event emission 1195750


Unable to download closed captions!

I tried to download some closed captions on the pureflix website, but the program always has this error:
12:32:36.560 Output file #0 does not contain any stream
It only recognizes the video and audio in the m3u8 file, but the closed captions is not recognized. Is there any way to make it work to download sub captions?
I am using this software --> M3U8X to download closed captions, but I would like to use only yours to do the whole process.

I’ll test if I'm free.

Pure Flix memberships are not yet available in your area.

What area can watch content? And could you send me an account name and password<EMAIL_ADDRESS>

U.S.A
Proxy/VPN required if you live outside the U.S.

I sent you the credentials in the email.
U.S.A
Proxy/VPN required if you live outside the U.S.

ok

I have fixed some logical problems with the external audio track or subtitle track, but there is a tricky problem:
The websit's subtile's timestamps is relative :
01.vtt:
WEBVTT
X-TIMESTAMP-MAP=MPEGTS:900000,LOCAL:00:00:00.000

00:00:01.466 --> 00:00:05.466
THEME SONG: Let's
go to Pa-ha-ha-ha-ha

02.vtt:
WEBVTT
X-TIMESTAMP-MAP=MPEGTS:6300000,LOCAL:00:00:00.000

00:00:02.800 --> 00:00:05.900
The nativity is an
artistic representation

Now my program cannot concat such subtitles correctly. I have to re-adjust the timestamps through X-TIMESTAMP-MAP, then concat them to complete subtitle. So I plan to take time to fix this bug on Saturday or Sunday.
Thanks for your feedback.

BUG FIXED. v2.7.2.

There are still some hard to solve problems, please wait for the updated version.


chore: Update requirements.txt with pypi dependencies

This PR includes the following changes:
Added requirements.txt:
Created a requirements.txt file to specify the project's dependencies.
Updated README.md:
Added instructions on how to install dependencies using requirements.txt.

Re-did this due to some changes but thank you for raising this!


Find a way to pin workflow/action versions

Since workflows and actions call each other, it makes this difficult.  We may need to have them check out the .github directory somewhere locally at the pinned ref and operate on local paths.
While I’d like to be able to support mods that don’t have kspbuildtools as a submodule, I think I’d also be ok with requiring that if you wanted to pin the workflow versions.
But all the major actions out there support pinning for reusable workflows - how do they do it?  Do we just create a branch for each release and replace all the refs…?

I'd suggest separating them into different repositories,
KSPModdingLibs/actions for all re-usable actions
KSPModdingLibs/workflows for all re-usable workflows

https://github.com/dariocurr/checkout-called this is worth looking at.


pdpmake: 1.4.3 -> 2.0.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/pdpmake/versions.
meta.description for pdpmake is: Public domain POSIX make
meta.homepage for pdpmake is: https://github.com/rmyorston/pdpmake
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.0.1 in filename of file in /nix/store/aiyvq0h0f5hjxd1a7rf2n48mas6zqyr4-pdpmake-2.0.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

pdpmake

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/aiyvq0h0f5hjxd1a7rf2n48mas6zqyr4-pdpmake-2.0.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A pdpmake https://github.com/r-ryantm/nixpkgs/archive/aca1f582a55b78c0ac8e52ac3b8629469d00e610.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/aca1f582a55b78c0ac8e52ac3b8629469d00e610#pdpmake

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/aiyvq0h0f5hjxd1a7rf2n48mas6zqyr4-pdpmake-2.0.1
ls -la /nix/store/aiyvq0h0f5hjxd1a7rf2n48mas6zqyr4-pdpmake-2.0.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

pdpmake

Maintainer pings
cc @eownerdead for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge


Support for HS256 algorithm for JWT

I would like to request support for HS256, the most common symmetric algorithm.
In my case my infrastructure shares resources with backend and frontend, and it would be ideal to use a single shared key with rotation. As for the implementation, it would probably be straightforward, since even the endpoint to get the public key wouldn't be necessary anymore.
Looking forward to any comments about this.

Can you please better describe the issue? How can you share a symmetric key between the frontend and the backend?

I am using SST with Next.js so my Backend and Frontend are in AWS. A way to share the key would be by using NEXT_PUBLIC env variables to share it to the client so the JWT can be signed. And since the private key resides in AWS I can use it on my API Gateway to validate the JWT. Probably the only downside is that I would have to deploy my Frontend every time my key is rotated.
Another approach I was thinking about recently is to check the Session on my API Gateway instead of using JWT. But this will need a DB request which would be nice to be able to avoid that.
I am not an expert so let me know what you think about this approach and if it makes sense, if not I'll be happy if you can give me any advice.

Still not clear to me. HS256 is a symmetric algorithm so if you send the key to the frontend you are defeating the purpose of the signature itself.
Symmetric cryptography can be used when the key is kept secret on the server. Better Auth already does that with the session cookie signature. The sole purpose of the jwt plugin is to allow for other servers to validate the jwt by retrieving the public key via a request to the jwks.
What is your usecase?

Sorry you are right, the part of sharing the key to the client doesn't make sense. In that case would be enough to store the key as a regular env variable so it'd life on the Next.js server securely. That said, Better Auth could sign the JWT with the symmetric key and from the API Gateway validate the JWT without the need to retrieve the public key doing a request. In that way I'd avoid to do a request to the internet and instead retrieve the key from Secrets Manager or something similar on AWS.
Not sure if my idea is not good or not a common practice, and may be it is just better to stick with the asymmetric key or validate the session. Please let me know.

It is a good idea. Symmetric cryptography makes sense as long as we make it possible to provide a static key to the plugin.
This is a feature request, and we would need some time to process it. Meanwhile you can create your own plugin, or feel free to contribute to this repo by extending the jwt plugin 😉

JWT plugins is made for JWKS support. Which is designed to work with asymmetric key pairs.


Update sbt-typelevel, ... to 0.6.6

About this PR
📦 Updates

org.typelevel:sbt-typelevel
org.typelevel:sbt-typelevel-mergify
org.typelevel:sbt-typelevel-site

from 0.6.3 to 0.6.6
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.typelevel" }
}]

labels: sbt-plugin-update, early-semver-minor, semver-spec-patch, version-scheme:early-semver, commit-count:n:2

Superseded by #60.


feature(es6): es6-ifies code

and tests, and tests don't break
closes #30

Codecov Report

Merging #89 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #89   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          23     20    -3
  Branches        2      2
=====================================
- Hits           23     20    -3

Impacted Files
Coverage Δ

src/api/index.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408f181...ac37991. Read the comment docs.


Unable to use breeze-plymouth

Issue description
Trying to use breeze-plymouth makes nixos-rebuild fail:
  output ‘/nix/store/l3xipkcs93ddcd9lsfjrknymn1z538k6-extra-utils’ is not allowed to refer to path ‘/nix/store/7mni656sr2prhx5qj1cwpgk7hkdf68lz-plymouth-0.9.2’

Cc: @ttuegel
Steps to reproduce
boot.plymouth.themePackages = with pkgs; [ kde5.breeze-plymouth];

Then we get the error above.
Technical details

NixOS: 17.03.git.0353b9662aM (Gorilla)
Nix: nix-env (Nix) 1.11.6
nixpkgs: 17.03.git.2f06667cdaM

I'm aware of this issue. Unfortunately, I've never been able to get even plain plymouth working on my development machine; something about graphics drivers. The proximate cause is some reference not being removed as necessary. It's rather hard to debug as-is because there isn't a single package one can build to test this issue. So, a good first step might be factoring out the appropriate stage (I think it's stage-2) into a standalone package.

@ttuegel, plymouth works fine on 2 different machines here. I'll take a look at it during Feb - I was just hoping there was a quick solution...

I'm still getting this bug on May 14. Did you end up figuring out anything about what's going on here, @peterhoeg ?

No, I haven't looked at it at all and I simply disabled plymouth instead.

Yeah, I'm in the same boat. Just wanted to make sure I hadn't missed out on something you forgot to post. Thanks for the update. :-)

I fixed this a few months ago, so this issue can be closed.

Indeed, plymouth works now with the breeze theme. Nice, thanks @michaelpj !


Update README.md

I was struggling with this for several hours and some current issues are also based on similar problems. Because there is no easy way to find the right answer and this is the only documentation document I could find, I think it's important to add this information here.

Although I appreciate the PR, I feel those attributes are very mongoDB specific. They control the (de)serialization between BSON and .net. This library is concerned with (de)serialization between jsonapi and .net.
Although it may be a common use case to go jsonapi<->.net<->BSON the documentation for the second transformation probably belongs more in the BSON serialisation library than here


Dotenv doesn't work on Windows

I haven't quite diagnosed this, but on Windows using PostgreSQL, this works:
diesel setup --database-url=postgres://postgres:myadminpass@localhost/my_db

But if I put DATABASE_URL=postgres://postgres:myadminpass@localhost/my_db in .env and run diesel setup it prints:
>diesel setup
Creating database: localhost:5432
could not translate host name "postgres" to address: Unknown host

That... doesn't seem right.

Is this only the case with diesel_cli? Otherwise you should probably also open an issue at https://github.com/slapresta/rust-dotenv :)

Am 21.01.2017 um 17:44 schrieb Tim<EMAIL_ADDRESS>I haven't quite diagnosed this, but on Windows using PostgreSQL, this works:
diesel setup --database-url=postgres://postgres:myadminpass@localhost/my_db
But if I put DATABASE_URL=postgres://postgres:myadminpass@localhost/my_db in .env and run diesel setup it prints:

diesel setup
Creating database: localhost:5432
could not translate host name "postgres" to address: Unknown host

That... doesn't seem right.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Yeah I'm not sure. I'll build a little test app to try it.

Actually scratch that, it does work. The problem was I also had an actual environment variable set and that apparently takes precedence over .env. It was set to postgresql://localhost:5432/. Seems like a bug in the URL parser.
In any case, this was a bit hard to diagnose. A simple way to make it a lot easier would be to print the URL that it is trying to connect, at least for diesel setup, and ideally fix the URL parsing.
Looks like this is the code.
Looks like it splits on / and gets the last component, which is why it failed. Why not do proper URL parsing? Here is some nice code I have lovingly crafted using Servo's url parsing crate.
/// Split a postgres URL into the address part and the database name, and appends "postgres" to the
/// end for some reason (TODO: seems weird; why?)
///
/// # Examples
///
/// ```
/// assert_eq!(split_pg_connection_string("postgres://user:pass@domain:port/database".to_string()),
///            Ok(("database".to_string(), "postgres://user:pass@domain:port/postgres".to_string()));
/// assert_eq!(split_pg_connection_string("postgres://user:pass@domain:port/database".to_string()),
///            Err(?));
/// ```
//#[cfg(feature = "postgres")]
fn split_pg_connection_string(database_url: &str) -> Result<(String, String), String> {

    let mut pg_url = Url::parse(database_url).map_err(|_| "URL parse error".to_string())?;

    if pg_url.scheme() != "postgres" && pg_url.scheme() != "postgresql" {
        return Err("Scheme must be postgres or postresql".to_string());
    }

    let database = {
        let path: Vec<_> = match pg_url.path_segments() {
            None => return Err("Scheme cannot have paths (this should never happen)".to_string()),
            Some(x) => x.collect(),
        };

        if path.len() != 1 || path[0].is_empty() {
            return Err("You must specify a single path element, e.g. postgres://.../database".to_string())
        }
        path[0].to_owned()
    };

    pg_url.set_path("postgres");

    Ok((database, pg_url.into_string()))
}

Also it would be nice if diesel setup reported the URL it tries to connect to.

Just encountered this where diesel was choking on use of localhost in the DATABASE_URL without a good error message, only displaying "Can't connect to local MySQL server through socket '/tmp/mysql.sock' (2)". By randomly fiddling with things I noticed it started working when I changed this to <IP_ADDRESS> instead. I'm able to connect to the mysql server using another tool, Sqlectron using either <IP_ADDRESS> or localhost which is what I expected with diesel also.
Any particular reason why diesel wouldn't support localhost?

@jcramb There is not much we can do here as we parse the connection string only in such a way that we extract hostname, username, password, database and port. After that everything is passed to libmysqlclient, where this error originates from. So that's not diesel does not support localhost but your version of libmysqlclient does not support it.


Generated images without movable objects

Hi, great work for your job!
Why are there no foreground objects such as cars in the pictures  I generated?
By the way,I have no openai account so i can't generate updated_description_.pkl file, so i just use original 12Hz_.pkl as WorldDreamer's input, is that the reason?

The visualization you show and the box projection at inference time are not executed at the same time. It is possible that the visualization is correct but the box is not actually projected onto the canvas.
Maybe you can check the code in the following function to see if it is executed correctly.
https://github.com/PJLab-ADG/DriveArena/blob/ba7dd86b606b92710e111e55fa639ebf6ebe0ed4/WorldDreamer/dataset/map_utils.py#L121

@jokester-zzz thank you very much! I have solved this problem. Due to mismatched opencv version, cv2.line may raise an tuple error, so by try: except: judgment, it may skip draw lines!

Congratulations on solving the problem! And it reminds me to add some instructions there😆

@dyy0205 Hi, may i ask what version of sumo do you use? I just struggling with an error caused by sumo. the deail is described in this issue. Any suggestion would be grateful. Thanks a lot.


feat: make only 2 filters active by default

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[x] Feature
[ ] Refactoring

Context

[x] Closes #5545
[ ] Requires deployment <>

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[x] I've tested it at </bsx/collection>
[x] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

https://user-images.githubusercontent.com/128157824/230698150-ec93b8a1-6d40-43d1-b28b-3576573e9628.mp4

pay 10 usd

😍 Perfect, I’ve sent the payout
💵 $10 @ 32.8 USD/KSM ~ 0.305 $KSM
🧗 DzUbHCk3Fr3XdCPNKo7uCJvtBH7YfgiFbn4Gr3VmCMiFy1C
🔗 0x11696114cb68026658a5686d765f9568cd6ea4dd5e6676844cd8f47258bb3aae
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


Error creating project with eslint

Version
3.0.0-beta.6
Steps to reproduce
Run vue create myproject and select eslint   standard
What is expected?
Project created
What is actually happening?
Vue CLI v3.0.0-beta.7
✨  Creating project in /home/leonardo/projects/vue/testpwa.
🗃  Initializing git repository...
⚙  Installing CLI plugins. This might take a while...

yarn install v1.6.0
info No lockfile found.
[1/4] Resolving packages...
[2/4] Fetching packages...
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
success Saved lockfile.
Done in 59.48s.

🚀  Invoking generators...
 ERROR  TypeError: api.genJSConfig is not a function
TypeError: api.genJSConfig is not a function
    at api.render.files (/home/leonardo/projects/vue/testpwa/node_modules/@vue/cli-plugin-eslint/generator.js:88:46)
    at Generator.resolveFiles (/home/leonardo/.config/yarn/global/node_modules/@vue/cli/lib/Generator.js:129:13)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:182:7)

Upgrade please.

@yyx990803 手动创建项目时还是会出现这个问题，版本 v3.0.0-beta.9


ENH: Simplify eddymotion.estimator.EddyMotionEstimator.fit

Simplify eddymotion.estimator.EddyMotionEstimator.fit: break down different parts into separate methods.
Fixes:
src/eddymotion/estimator.py:43:9: C901 `fit` is too complex (23 > 10)

raised by ruff.
Remove the C901 error exception rule from the ruff linter whitelist.
Fixes #142.

Did not make these class members because the class does not have instance variables, and it is suggested them to be static, which does not make sense to me.
Some of these may better fit into a utils.py module, but that is beyond the scope of this PR/can be done in a separate PR as the need becomes more apparent.

Doc build failure is unrelated:
https://github.com/nipreps/eddymotion/actions/runs/8493247406/job/23267121635?pr=149#step:5:488

@arokem @oesteban @effigies it is probably worthwhile considering merging to avoid conflicts should other commits get into the way.


Module updates not working anymore

In the admin, if you enable 'Package updates' and go the the tab 'Updates' of the gallery (Packaging/GalleryUpdates/ModulesUpdates), there is an error.
It seems to try to download a package but fails and displays the html source.
Note: I replaced the gallery url by the correct one (https://gallery.orchardproject.net/api/FeedService) but I don't know if it causes the error.
The url of the downloads (in the 'Gallery' tab) is also weird because it shows wrong urls (http://orchardgallery.azurewebsites.net/Download/...) and I don't know why it is using this base url that isn't configured anywhere in the settings.

after my debug, found that "The specified package could not be found..."


CORE-14685 Add ledger and notary code owners

I have pushed two extra rules for the token selection stuff - as the last rule in a codeowners file takes precendence, this shold given @owenstanford  the last word on token selection code.


Map bool to Nullable bool gets null

I have an object called OfferContact and it is a nested object of another object. Now we have source object with these values: IsCall:true,
IsSMS:true,
IsEmail:true
IsNonMandatory:false,
IsLine:false,
CalledTime:00:00:00
Then, we map it using .Adapt

However, from the mapping result, IsSMS gets null value, while other attributes are mapped correct.
I ended up configured using MapWith and now problem has been solved.

But may I know why other fields were mapped without issue but only IsSMS gets null?

Hi,
I think this is a duplicate issue.
I opened a similar issue (#338), infact i had a property called CodeEU with the last letters in upper case and this is the only property that is not mapped.

Hi,
I think this is a duplicate issue.
I opened a similar issue (#338), infact i had a property called CodeEU with the last letters in upper case and this is the only property that is not mapped.

I see... Yea, I have another class with property that has last letter in uppercase and cannot be mapped too..
Hope it can be fixed soon.. thanks for the info!


No functionality in Finder to get questionairre ID or to, from a questionnaire ID, get other data points

In PR #62


Danger Rules

Did you save this somewhere? Danger JS

Check SemVer bump of PR
** If major, require a changelog edit
** If minor/patch, warn for a missing changelog edit ("Does it affect user interaction/experience?" then make a changelog edit)
Warn/Require lockfile being up to date?
Warn if PR is not assigned to someone for review
Require PR is linked to 3 or less issues
Warn if PR is linked to 2 or 3 issues
Warn if PR is not linked to any issues
Require testing when it should
If testing is required, then documentation probably is too
View in Slack

Once I figure out how to get danger and GH actions secrets to work with forks I can take this. https://spectrum.chat/danger/javascript/having-issues-to-get-danger-to-work-with-gh-actions~6dbe81db-44f7-49cf-9eea-4cb611170c9e?m=MTYxMzg3NTc0NjYzNg==


AutoUpdate property default value is false, not true

I believe the AutoUpdate property default value is false, not true.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b30b2bf4-ae84-3700-152f-3a349d221087
Version Independent ID: 2e5a66a7-bdc1-e7b4-5923-cde9a6486310
Content: AutoUpdate Property - Business Central
Content Source: dev-itpro/developer/properties/devenv-autoupdate-property.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Thanks for catching this. Will be fixed with the next doc refresh.


Check if Range (rfc7233) is supported before downloading, some servers don't support that

https://datatracker.ietf.org/doc/html/rfc7233

closing with : commit


Support dotnetcore 2 and connection count display fix

Hi @afzaal-ahmad-zeeshan, thanks for demo - simplest I've found so far for setting up a tcp-server in DotNet - I've made a couple of tweaks to support DotNet Core 2 if you're interested.

Awesome, thank you very much for reviving this repository! 👍


AnimatePresence and initial={false}

I have a issue with latest version 0.14.2 where initial now is supported https://github.com/nandorojo/moti/pull/102
If you are using react native tab navigation and open a tab where the elements should be hidden on mount. What happens is that it will run the animation going from "opacity .75" to "opacity 0" while the screen is mounted. The specific screen is mounted when visited. Expected behaviour is that it should not run the animation because of initial={false}. I also tried addeding animateInitialState={false} to the Something element, but that did not change anything.
const editMode = false;

<AnimatePresence initial={false}>
  {editMode && (
    <Something
      from={{ opacity: 0 }}
      animate={{ opacity: 0.75 }}
      exit={{ opacity: 0 }}
      transition={{
        type: 'timing',
        duration: 250,
      }}
    />
  )}
 </AnimatePresence>

Styles (style-components)
import styled from 'styled-components/native';

const Something = styled(MotiView)`
  position: absolute;
  background-color: #000000;
  border-radius: 10px;
  top: 0;
  bottom: 0;
  left: 0;
  right: 0;
`;

The styles has nothing to do with it, i just pasted it anyway

Hi @nandorojo.
Do you have a idea if this is bug in Moti or somewhere else? I can try to see if i can reproduce this issue in expo.

Thanks for the issue. I’m having a little trouble following. Can you make a snack (on iOS) reproducing, and explain what should have happened?
Can you also confirm the same happens with styled components?

As far as I know, the initial={false} is meant for items that exist on the first render. However, since edit mode is initially false, this won’t apply.
The purpose of this prop is to let you use a different key on the child of animate presence, and trigger an exit animation any time the key changes.

I have used Framer Motion a lot and the as far as i know the initial={false} with AnimatePresence will always disable the animations on first render meaning that it go straight to the initial={{ opacity: 0 }} like this example. But with the above example Moti will on first render animate from animate to exit because the editMode is false. This is not the expected behaviour compared to Framer Motion. But maybe you went with a bit different API here? I will try to create a snack with this issue later today
<AnimatePresence initial={false}>
  {isVisible && (
    <motion.div
      initial={{ opacity: 0 }}
      animate={{ opacity: 1 }}
      exit={{ opacity: 0 }}
    />
  )}
</AnimatePresence>

Interesting. But what would the from prop be there for then?
If you can repro it with both then I can investigate. But the purpose was to match their behavior.

I see it as
initial={false}:
Elements visible should go straight to animate prop.
Elements not visible should go straight to exit prop.
initial={true}
Elements visible should animate from from prop to animate prop.
Elements not visible should animate from animate prop to exit prop.

So for case 1) why are you setting the from prop at all?

I also don’t think that’s exactly right re: the first one.
I think if the child key changes, then it animates out and the next one animates in. But the first time, it doesn’t animate in.

Found the issue 🙄, it was error 40 🤣. My initial state was true, meaning that it was in first render true and then false just after since i got a useEffect that turned it into false.
const [editMode, setEditMode] = useState(true);

Thx for helping 👍


[pigeon] run_test.sh assumes macOS

In trying to enable the custom package tests in flutter/packages on Linux—they were originally run only on macOS for historical reasons, but we should be allowing for custom tests for any of our supported platforms I had to exclude pigeon because run_tests.sh tries to run iOS tests, assuming it's on a macOS host. The script should allow for running the relevant subset of Linux; there's no reason someone fixing an issue with the Java generator to need to be on a macOS machine, for instance.
This should be easy to do as part of migrating test logic to run_test.dart, since those tests can just be added to the list or not depending on the host platform.
/cc @gaaclarke

/cc @tarrinneal

Fixed as part of the elimination of run_test.sh.


Rename action files for consistency

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is 100%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 786927a...32b7407. Read the comment docs.


Update CHANGELOG.md

Pull Request (PR) description

Rearrange entries in the the change log.

This Pull Request (PR) fixes the following issues

Task list

[x] Added an entry under the Unreleased section in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in resource directory README.md.
[ ] Resource parameter descriptions added/updated in schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

Merging #445 into dev will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##            dev   #445   +/-   ##
===================================
  Coverage    96%    96%
===================================
  Files        20     20
  Lines      2704   2704
  Branches     10     10
===================================
  Hits       2607   2607
  Misses       87     87
  Partials     10     10


Unable to Install or Run

First let me say thank you for making this program! I had my own version of this program for Infinitas 1st Style that served my needs well. But I had difficulty updating for Infinitas 2020 and I haven't updated yet. (What was a static array of score data on the stack in Infinitas 1 turned into a dynamic data structure on the heap in 2020. So I can't just grab a static range anymore like I can for the rival data or the songlist.)
I don't know how you solved that problem? Or if you only dump the live/current score and can't handle existing scores like I was trying to? But either way I endorse this program. I personally prefer ReadProcessMemory() over dll hooking and I think you're doing it right. Also you've got more features and a method to update the offsets automatically from an authority. Love it!
ACTUAL ISSUE:
Anyways infinitas_statfetcher depends on the Dot Net Desktop Runtime and this isn't mentioned in the ReadMe. After installing the runtime I was told that basically 5.0.5 was too new and that 3.1.0 was needed. If you could maybe statically compile that dependency in there or include a link to the installer either would be helpful.

Infinitas keeping track of historical scoring data in memory never occured to me actually, I just built it to dump the current score, its metadata, and whatever more I wanted to keep track of.
Seems like I didn't have .NET Native on my system so when I built it statically it was in the intermediate language and still needed the framework.
I could reproduce and subsequently fix the issue on a virtual machine with a fresh install, which is available as the latest release now.
On the topic of runtimes, I should probably migrate to .NET 5, I just picked the first console project template on the list when I started this project.
Thanks for reminding me of the readme actually, I haven't updated it in a while.

Thank you for the quick fix! I'd try it right now but the server is down. I'm going to share this program with my friends who play.
Just in case you're interested:
Dumping all scores should be easiest on the songwheel. Because at that time we know that the exscore, miss count, and lamp for every song and chart has to be readily available. (Even if the player has scores on songs they can't see.) I took this data, made an arcade-style csv, and used that for what you normally use that for.
The problem I ran into with the 120hz update is that the data structure now looks something like: {data for 21 songs, 64 bytes of padding, data for 40 songs, skip 196 bytes, data for 12 songs, skip 512 huge bytes} etc. And of course these arbitrary numbers changed for each run of the program. So probably this stuff is being stored in something like a std::vector and I'm going to have to find the pointers. I don't know if you'll succeed or invent a different and easier way? But there you go.

Interesting, I might look into that for fun some time.

I figured it out now, it is storing everything in a hashmap with linked lists. The start and end of that hashmap is present in static memory so it's fetchable.
Latest release saves and outputs what's found in that structure into the file tracker.tsv

You're the best! Congrats on all the new features btw.


Sometimes post editor stops writing

I just updated my blogs to Ghost 0.7. You'll have done a great job with this version, congratulations!
I'm here because while I was writing a few post sometimes, a letter doesn't work, like if my keyboard doesn't have enough battery(its a ghost bug, I've checked it), for example if the "o" gets wrong you can write any one. So you have to refresh the page.

This sounds like the keyboard shortcuts for the content management screen (c creates a new post, o or enter opens the selected post, etc) are sometimes not being disabled correctly when transitioning to the editor.
Have you noticed any particular routes through the admin area or sequence of actions that cause the problem?

This has just been reported again in Slack.
I have a feeling it's related to the search bar. I've not been able to prove it yet but I think the issue may be that occasionally when leaving the content management screen whilst the search bar is focused the removeShortcuts method is being called before keymaster has been switched back to the default scope.

Great! The problem that I'm talking about was caused while I'm writing the post. I've to install the new version to see if the bug is solved. But I hope so :)


Update to use latest typings from popper.js

The typings in popper.js were updated recently, causing issues. I believe this fix is sufficient and so does the update's author but I would like to verify with someone if this is the right step.

I do have the same problem and your fix works. Would love to see this merged :)

Please hold off on this PR; see my comment here: https://github.com/FezVrasta/popper.js/pull/367#issuecomment-322680526
@madebyherzblut In the meantime, you should enable the --allowSyntheticDefaultImports compiler flag.

I'll close this one but a link to a PR with a reverse commit in popper.js would be good

@adidahiya --allowSyntheticDefaultImports doesn't fix this for me, see https://github.com/FezVrasta/popper.js/pull/367#issuecomment-324120105. Basically latest version of react-popper doesn't pass typechecks with TypeScript.


Editor suggested OS enums contain an underscore which is incorrect

Godot version
3.3.2.stable
System information
Ubuntu 21.04
Issue description
When using the functions OS.get_system_dir(), OS.get_native_handle() or OS.get_video_driver_name(), the suggested valid enum values all begin with _OS.*:

However, when using one of these, you get a Parser Error: Identifier not found: _OS error when running the project.
Steps to reproduce
In a script, type  OS.get_system_dir(, OS.get_native_handle( or OS.get_video_driver_name(, and select one of the suggested values. Run the project.
Minimal reproduction project
N/A: This is an editor issue. A project is easily fixed by removing the underscore.

Duplicate of #35469, #37184.

Closing per @kleonc's comment.


Security: parameterize Arweave.crypto.{encrypt|decrypt} PBKDF2 iterations

From node-driver.ts, NodeCryptoDriver.encrypt:
const derivedKey = crypto.pbkdf2Sync(
  key,
  (salt = salt ? salt : "salt"),
  100000,
  32,
  this.hashAlgorithm
);

Specifies a hardcoded 100,000 iterations. However, OWASP recommends 310,000 iterations for PBKDF2-HMAC-SHA256:
The work factor for PBKDF2 is implemented through an iteration count, which should set differently based on the internal hashing algorithm used.

PBKDF2-HMAC-SHA1: 720,000 iterations
PBKDF2-HMAC-SHA256: 310,000 iterations
PBKDF2-HMAC-SHA512: 120,000 iterations

source: https://cheatsheetseries.owasp.org/cheatsheets/Password_Storage_Cheat_Sheet.html#pbkdf2
The default should not be change for backward compatibility with Smartweave contracts, however new contracts should be given the option to use a more secure setting to allow for future-proofing.

does the same problem exist in the existing webcrypto interface?
i think the whole node-crypto webcrypto duality will eventually be removed in favour of a unified webcrypto interface. ref => https://nodejs.org/dist/latest-v18.x/docs/api/webcrypto.html


All the documentation and download links are unresponsive.

I am trying to build android project on this API and I am having a hard time figuring what to do as there is barely any source out there for it and the documentation links are all unresponsive.
Please help as I have a deadline for an interview to make this project.
You can give recommendations on how and where to get started. Started like from scratch how to add its dependency when there seems to be none.
Please Help.

All the documentation you need is available in our README. There you can find how to use and how to build the library.


Toolchain Download SPI

@bot-gradle test QFL

OK, I've already triggered the following builds for you:

QuickFeedbackLinux build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test QFL

OK, I've already triggered the following builds for you:

QuickFeedbackLinux build

@bot-gradle test QFL

OK, I've already triggered the following builds for you:

QuickFeedbackLinux build

@bot-gradle test QFL

OK, I've already triggered the following builds for you:

QuickFeedbackLinux build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test qfl

OK, I've already triggered the following builds for you:

QuickFeedbackLinux build

@bot-gradle test QFL

OK, I've already triggered the following builds for you:

QuickFeedbackLinux build

@bot-gradle test QFL

OK, I've already triggered the following builds for you:

QuickFeedbackLinux build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@melix Thanks for taking a look!
I think your changes for JvmVendorSpec should be included in here indeed, for the reasons you stated.
For JvmImplementation, I am not sure. We would like to work on expanding the JavaToolchainSpec in a later version, and right now that field feels like a mistake and not something we would expand the usage of.
I understand that for now it would mean that selecting a GraalVM version (both number and CE vs EE) would not be possible.

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

For JvmImplementation, I am not sure. We would like to work on expanding the JavaToolchainSpec in a later version, and right now that field feels like a mistake and not something we would expand the usage of.
I understand that for now it would mean that selecting a GraalVM version (both number and CE vs EE) would not be possible

That's a bit of a problem. Currently even if this API is integrated, there's no way I can use it to solve the simplest use case. I understand the concerns, though. FWIW, we're getting more and more reports of folks who don't understand why their builds fail and have to disable toolchain detection.

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test QFL

OK, I've already triggered the following builds for you:

QuickFeedbackLinux build

@bot-gradle test QFL

OK, I've already triggered the following builds for you:

QuickFeedbackLinux build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test QFL

OK, I've already triggered the following builds for you:

QuickFeedbackLinux build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

@bot-gradle test RFM

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test RFM

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test RFM

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test and merge

OK, I've already triggered a build for you.


Use target port of Service in NodePortLocal to configure Pod reachability

Currently we use container ports of a Pod to program iptables rules to make the Pod
reachable through a port in the Node. But container ports are not mandatory and multiple
services can use different target ports for the same pod. Hence adding a change in
NodePortLocal implementation, where target ports of all services would be used to
program iptables rules and annotate pods.
To implement this, target ports are being obtained from all the Services selecting a Pod,
in the function handleAddUpdatePod().
Necessary changes in the tests have been added.
Fixes #1912

/test-all

/test-networkpolicy

/test-e2e

/test-all

/test-e2e
/test-networkpolicy

/test-e2e
/test-networkpolicy

@monotosh-avi I see that the e2e tests were consistently failing before your last push. Were you able to identify the root cause?

@monotosh-avi I see that the e2e tests were consistently failing before your last push. Were you able to identify the root cause?

@antoninbas it looked like there was some problem with the test setup.
fixtures.go:341: Error when tearing down test: error when deleting 'antrea-test' Namespace: Delete "https://<IP_ADDRESS>:6443/api/v1/namespaces/antrea-test": dial tcp <IP_ADDRESS>:6443: connect: no route to host
I do see the similar issue with other tests too., e.g. https://jenkins.antrea-ci.rocks/job/antrea-e2e-for-pull-request/2747/console.
I didn't face this issue when I ran the tests in my local set up.

@monotosh-avi could you rebase main. Some fixes went in to address known stability issues with the test jobs. I want to make sure that the test failures were because of them and not something else. It may be a good opportunity to squash your commits too (the squashed commit must be signed). Thanks!

@monotosh-avi could you rebase main. Some fixes went in to address known stability issues with the test jobs. I want to make sure that the test failures were because of them and not something else. It may be a good opportunity to squash your commits too (the squashed commit must be signed). Thanks!

@antoninbas  rebased and squashed commits.

/test-all

Another --- FAIL: TestFlowAggregator/IPv4/RemoteServiceAccess (13.40s) failure
/skip-e2e


Crash with minecraft 1.11.2

Game crashes when trying to create new world:
Crashlog: https://paste.ee/p/pqUnJ
Forge: build 1.11.2 - <IP_ADDRESS>5
Minecraft: 1.11.2
TickDynamic:
TickDynamic-1.11.2-0.5.2
If you need anything else, then please let know.

Fixed in 0.5.3


Ability to add custom labels

Describe the problem
I need to add some custom labels to the resources deployed by the chart
Describe the solution you'd like
Allow user to add custom labels via chart values
Describe alternatives you've considered
No response
Screenshots
No response
Additional context
No response

I forget to add the labels to pods and reopen a MR for that purpose


[SPARK-17803][TESTS] Upgrade docker-client dependency

SPARK-17803: Docker integration tests don't run with "Docker for Mac"
What changes were proposed in this pull request?
This PR upgrades the docker-client dependency from 3.6.6 to 5.0.2 to enable Docker for Mac users to run the docker-integration-tests out of the box.
The very latest docker-client version is 6.0.0 but that has one additional dependency and no usage yet.
How was this patch tested?
The code change was tested on Mac OS X Yosemite with both Docker Toolbox as well as Docker for Mac and on Linux Ubuntu 14.04.
$ build/mvn -Pyarn -Phadoop-2.6 -Dhadoop.version=2.6.0 -Phive -Phive-thriftserver -DskipTests clean package

$ build/mvn -Pdocker-integration-tests -Pscala-2.11 -pl :spark-docker-integration-tests_2.11 clean compile test

Can one of the admins verify this patch?

Jenkins add to whitelist

Jenkins test this please

Test build #66444 has started for PR 15378 at commit 25e106b.

Test build #66445 has started for PR 15378 at commit 25e106b.

Test build #66444 has finished for PR 15378 at commit 25e106b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66444/
Test PASSed.

Test build #66445 has finished for PR 15378 at commit 25e106b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66445/
Test PASSed.

Merged build finished. Test PASSed.

Yay easier testing for developers :) +1

Thanks @JoshRosen


Preserve workspace UI state when duplicating workspace

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.61.0
OS Version: windows 7

Steps to Reproduce:

create a worksapce
enable or disable some extensions for this workspace
save workspace as or duplicate workspace to a new workspace
open the new workspace
extensions enabled state and disabled state is not synchronized

We have code to migrate over workspace settings when entering a workspace and the current workspace is a folder:
https://github.com/microsoft/vscode/blob/4ed0329e9c5e12e2c7c59697facc96020b0768ab/src/vs/workbench/services/workspaces/browser/abstractWorkspaceEditingService.ts#L332-L335
We also have code to migrate workspace storage:
https://github.com/microsoft/vscode/blob/4ed0329e9c5e12e2c7c59697facc96020b0768ab/src/vs/workbench/services/workspaces/electron-sandbox/workspaceEditingService.ts#L167
Not sure why this would not work then, @sandy081 please chime in.

Hm, I see, we probably do not trigger this when you are in a workspace and you save it or duplicate it. Since the workspace file contains the settings, they are properly duplicated. But the UI state is not. Maybe we can migrate those over too...

Actually I cannot reproduce the issue at least when using "File > Save Workspace As..." and we do migrate settings and state in that case:
https://github.com/microsoft/vscode/blob/4ed0329e9c5e12e2c7c59697facc96020b0768ab/src/vs/workbench/services/workspaces/electron-sandbox/workspaceEditingService.ts#L167
@featherfly can you provide exact steps for the scenario where you save a workspace as?

my vscode version is update to 1.62.0
i try it again
save workspace as it work ok
duplicate workspace the ui state is not sync (click duplicate workspace , extensions panel in the auto opend vscode is not sync the ui state)

Ok thanks, yeah that is expected the way it is implemented.

@bpasero  Can I take a look at this? I've been searching for opportunities to collaborate in Open Source

Please see https://github.com/microsoft/vscode/wiki/How-to-Contribute

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!


Can be used on nrf51

Can be used on nrf51 with zephyr and gcc-arm-none-eabi?

Hi, @aibeb, we haven't tested wamr on nrf51, but we have enabled wamr on stm32 board with Zephyr, which may be similar to your requirements. The samples can be found in:
core/iwasm/products/zephyr/simple/
which is a standalone wasm vm to run a simple wasm app
samples/gui/wasm-runtime-wgl/
which builds wasm vm, app manager and littlevgl lib together to run wasm app developed with ui APIs wrapperred by ourselves, most of the littlevgl lib code is built into wamr but not wasm app;
and samples/littlevgl/vgl-wasm-runtime/
which builds wasm vm and app manager together to run wasm app developed with littlevgl lib, most of the littlevgl lib code is built into the wasm app but not wamr.

@wenyongh
I used "core/iwasm/products/zephyr/simple/" to do the test, it seems that the memory does not meet the demand.
[ 96%] Linking C executable zephyr_prebuilt.elf Memory region         Used Size  Region Size  %age Used            FLASH:       80828 B       256 KB     30.83%             SRAM:      535608 B        32 KB    1634.55%         IDT_LIST:          56 B         2 KB      2.73%

Your total memory size is 32KB? It may be too small to run the wasm app. But you can have a try:
(1) Decrease the global heap size:
in main.c, modify global_heap_buf size from 512KB to 20KB;
(2) Decrease the app heap size and stack size:
in main.c, modify
wasm_runtime_instantiate(.., 8 * 1024, 8 * 1024, ..) to
wasm_runtime_instantiate(.., 4 * 1024, 2 * 1024, ..)
The stack is for interpreter to store operands, if it is too small, stack overflow exception may be thrown;
The app heap is to allocate memory for wasm app.
(3) Decrease the default main thread size:
in main.c, modify DEFAULT_THREAD_STACKSIZE from 6K to 3K
(4) Decrease the memory page size of wasm app, by default specified by WASM spec, each memory page size is 64K, but you can decrease it to 8K to have a try:
in core/iwasm/runtime/vmcore-wasm/wasm.h
Note that if the wasm app's footprint is large enough, this may cause potential issues.

@aibeb it seems that your nRF51 has 32Kb RAM.
This is good news as there are 16Kb variants, and those would be very limited.
Wasm3 engine can run even on 16Kb version, but it's much more practical with 32Kb.
There's a PlatformIO example, but you should be able to integrate into your build environment without issues.


Update client3:akka-http-backend, ... to 3.8.0

Updates

com.softwaremill.sttp.client3:akka-http-backend
com.softwaremill.sttp.client3:core

from 3.5.2 to 3.8.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sttp.client3" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.softwaremill.sttp.client3" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #480.