Project resourceQuotas don't get cleared on the BE side

Rancher Server Setup

Rancher version: 2.6-head

User Information

What is the role of the user logged in? Admin

Describe the bug
It seems like sending either Project object properly formatted with the resourceQuotas doesn't clear it up the value on the BE side.
Same goes if we cleared both CPULimit and ConfigMap, for which we can send either an empty object {} (which imo it should work) or the limit prop as null and it doesn't clear it up.
Starting scenario

Clearing configMaps

Payload sent on PUT request

Payload received on PUT request

To Reproduce

Create a project with two resourceQuotas: configMaps and CPULimit
Hit Create
Edit the recently created project and remove configMaps
Hit Save
Check same project again

Result

configMaps resourceQuota doesn't get cleared up

Expected Result

configMaps should be cleared from the UI

Screenshots
Check bug description
Additional context
Check original PR from UI team here
FYI @gaktive @nwmac @richard-cox : This is a blocker for https://github.com/rancher/dashboard/issues/5173

@Jono-SUSE-Rancher As requested here's a 2.6.6 issue that needs a lil triaging

Thanks @richard-cox.
@samjustus - Can you take a look at this with Neo, specifically seems like something Ricky or Michael might be interested in. Let me know if it doesn't fall to you guys and we can shift it over to T2 if needed.

https://github.com/rancher/rancher/issues/35688
@richard-cox same as this right?

@samjustus I believe they are similar, but this issue description along with the "Additional context" provides more detail on what is going on.

Closed. Duplicate of https://github.com/rancher/rancher/issues/35688


Issue extra closed div

Iam working on a project which needs your awesome validator:) But there is a problem it is not working properly when i dont include the extra closed div. But this extra closed div conflicts with my code so, is there an other way to do this? So short summary when i click submit it shows me no errors, but when i include this extra closed div it will but my page is completely distorted. So thats not what i want....
Maybe there is an other solution?
Kind regards,

I don't know, I can't really help you. It sounds like there's a problem somewhere else on your page.


Structure of repository

The structure is somewhat confusing and not self-explanatory. Maybe it could be improved and better documented?

We did some clean up and added documentation on the structure of the repository


Recent versions of Cog fail to initialize /predictions: TypeError: Unsupported input type List[Path] for parameter

With cog version 0.9.24 and later, I cannot call the /predictions endpoint because it fails to get initialized.
My environment is a conda environment on Ubuntu 24.04 LTS, but Python is a little outdated at 3.8. However I can replicate this on a Windows host as well.
/health-check returns the following (this output and stack trace from version 0.13.0):
Error while loading predictor:

Traceback (most recent call last):
  File "/opt/conda/envs/my-conda-env/lib/python3.8/site-packages/cog/server/http.py", line 159, in create_app
    InputType, OutputType = cog_config.get_predictor_types(mode=Mode.PREDICT)
  File "/opt/conda/envs/my-conda-env/lib/python3.8/site-packages/cog/config.py", line 138, in get_predictor_types
    return get_input_type(predictor), get_output_type(predictor)
  File "/opt/conda/envs/my-conda-env/lib/python3.8/site-packages/cog/predictor.py", line 298, in get_input_type
    **get_input_create_model_kwargs(signature),
  File "/opt/conda/envs/my-conda-env/lib/python3.8/site-packages/cog/predictor.py", line 218, in get_input_create_model_kwargs
    validate_input_type(InputType, name)
  File "/opt/conda/envs/my-conda-env/lib/python3.8/site-packages/cog/predictor.py", line 205, in validate_input_type
    raise TypeError(
TypeError: Unsupported input type List[Path] for parameter `images`. Supported input types are: str, int, float, bool, cog.File, cog.Path, cog.Secret, or a Union or List of those types.

My predict() call is defined as follows (modified for brevity, ellipses aren't present in code):
from typing import List, Iterator
from cog import BaseModel, BasePredictor, Path, Input, __version__ as cog_version

...

class Output(BaseModel):
    """
    Represents the output of a prediction.
    Note that COG only supports simple data types like string, number, float, or boolean
    Ref https://github.com/replicate/cog/blob/main/docs/python.md#output

    Attributes:
        result (str): The result of the prediction.
        metadata (str): The metadata (container and model version information etc) associated
        with the prediction.
    """

    result: str
    metadata: str

...

class Predictor(BasePredictor):
    def predict(
        self,
        images: List[Path] = Input(description="List of image URLs to process"),
        output_contours: bool = Input(
            description="Output contours in JSON format", default=True
        ),
        threshold: float = Input(
            description="Threshold for prediction confidence - Only report predictions above this level",
            default=0.8,
        ),
    ) -> Iterator[Output]:
        ...

I have tried making it just a Path, a str, a Union of those types with List with my Predictor logic updated to handle a single images or a list of input images, and the error all comes up the same.
The predict signature doesn't seem too different from the one used in test python/tests/server/fixtures/input_union_string_or_list_of_strings.py with the exception of the usage of the Input but unfortunately the error is still present with or without that.
Think I've checked everything I can think of, any thoughts or help would be greatly appreciated.

Hi, thanks for reporting the issue. I've just tried to put together a minimal case to reproduce this issue using cog v0.13.0 and using Python 3.8 and the snippet you've provided but so far I've been able to run cog predict successfully, as well as cog run python3 -m cog.command.openapi_schema to generate the output schema.
Lastly I ran cog build and started the HTTP server.
cog build
docker run -d -p 5001:5000 --platform=linux/amd64 cog-my-model
curl http://localhost:5001/health-check
{"status":"READY","setup":{"started_at":"2024-11-12T21:44:53.844786+00:00","completed_at":"2024-11-12T21:44:54.324370+00:00","logs":"","status":"succeeded"}}

Would you be able to put together a concrete failing example to help us debug? Thanks.

I'm going to close this for now. I'm afraid we need more info to help move this along. Will re-open when we have a reproducible example.


OOM issue during evaluation

Thank you for your amazing work.
I met OOM issue during trying to reproduce the result of llama3.1-8B.
Below is my change in configuration:
run.sh
GPUS="1" #  2 also can't work
ROOT_DIR="benchmark_root" # the path that stores generated task samples and model predictions.
MODEL_DIR="meta-llama" # the path that contains individual model folders from HUggingface.
ENGINE_DIR="." # the path that contains individual engine folders from TensorRT-LLM.
BATCH_SIZE=1  # increase to improve GPU utilization
template.py
'llama3': "<|begin_of_text|><|start_header_id|>user<|end_header_id|>\n\n{task_template}<|eot_id|><|start_header_id|>assistant<|end_header_id|>\n\n",
config_model.sh
llama3.1-8b)
MODEL_PATH="${MODEL_DIR}/Meta-Llama-3.1-8B"
MODEL_TEMPLATE_TYPE="llama3"
MODEL_FRAMEWORK="hf"
;;
And below is my cmd:
docker run --gpus '"device=1,2"' --net=host -v /data2:/workspace -it cphsieh/ruler:0.1.0 bash
bash run.sh llama3.1-8b synthetic
The error is:
torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 62.54 GiB. GPU 1 has a total capacty of 79.26 GiB of which 23.11 GiB is free. Process 3987923 has 56.13 GiB memory in use. Of the allocated
memory 49.56 GiB is allocated by PyTorch, and 6.08 GiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting max_split_size_mb to avoid fragmentation.  See documen
tation for Memory Management and PYTORCH_CUDA_ALLOC_CONF
Hope you can take a look.

Have you tried using vLLM?

Hi @hsiehjackson , I tried vllm. But when I using vllm==0.4.0.post1, there would be this issue https://github.com/vllm-project/vllm/issues/6689, after upgrading vllm version, there would be other issues like: AttributeError: module 'cv2.dnn' has no attribute 'DictValue'
So I wonder which env can llama3 work

@mengniwang95 I update our default docker container. Can you try whether cphsieh/ruler:0.2.0 can work?


Cannot update Jason to 1.3.0

https://github.com/primait/auth0_ex/blob/97c3daa9fdd5fd19ec08227fac5bba6ed731fbba/mix.exs#L38
I sugget to relax Jason version to 1.2 or update to 1.3

Thanks for the issue!
This is addressed by https://github.com/primait/auth0_ex/pull/52 , which should get merged soon :slightly_smiling_face:

Released with version 0.3.0-rc.1.3


Add onSizeChange event as a prop

See #89
I need this so that I can properly control my flex layout when the banner ad loads. I need to know the size of the ad, because this affects the other views in the container.

This is great!
I did a fork and it's exactly what we need.
When will this get merged?

Just rebased onto latest commit from master

v2 of the library will include this property. You can track its development here: https://github.com/sbugert/react-native-admob/pull/165


Tutorial for portable consent feature - alpha release

Based on this Portable consent state proposal, this doc covers how to portable consent works and how to build portable consent in an app built with XMTP using XMTP SDKs.
Preview: https://junk-range-possible-git-consent-xmtp-labs.vercel.app/docs/tutorials/portable-consent
This is a first iteration that will likely see frequent updates as we move toward beta and production releases.
We will link to this doc from all SDKs repos that have the portable consent feature implemented.

The repo shows that setting enableConsentList variable is needed before accessing contact features.
eg.
aliceClient = await Client.create(alice, {
  env: 'local',
  enableConsentList: true,
})

According to the code on the item: Get a conversation’s consent state the consent is not a function but a property.

Instead of:
const state = await conversation.consentState();
Should be:
const state = conversation.consentState

@fabriguespe consentState() is a function on conversation.

Instead of:
const state = await conversation.consentState();
Should be:
const state = conversation.consentState

@fabriguespe consentState() is a function on conversation.

Not according to these tests made by @rygine
eg
expect(conversation.consentState).toBe('allowed')
expect(aliceClient.contacts.consentState(bob.address)).toBe('allowed')

@fabriguespe this is the react native sdk in the mobile sdks its a function.

In order to access contact features on the repo, it is necessary to set enableConsentList to true.

this is no longer true. it didn't make much sense to have an enable/disable flag for consent. developers can choose to use it or not.

enableConsentList

I see, in that case, lets add Tabs, to differentiate the JS SDK from the React Native?


[Bug]: duckdb+parquet DB isn't saving the parquet files for persisted DB until application is killed

What happened?
I am writing a flask application, so in between requests, the ChromaDB instance is torn down and thus should be persisted.
This was the case for version 0.3.21
Now that I am on 0.3.26, the files in the index folder are properly persisting after text is added to the DB.
However, the parquet files in the top of the persist directory, aren't being created until the entire application is torn down.
So in order to use the database, I must shut down the application and restart it.
Versions
Chroma v0.2.36, python 3.9
Relevant log output
No response

Hi @JackLeick, I don't know if that's the expected behaviour but you could solve this issue by calling persist method on the Chroma client so the files in the top folder are persisted to disk. I tested this with this simple example. The file sizes on disk are different when you comment / uncomment the line with client.persist().
import chromadb
from chromadb.config import Settings

client = chromadb.Client(Settings(chroma_db_impl="duckdb+parquet", persist_directory="test-collection"))
collection = client.get_or_create_collection("test-collection")

collection.add(
    documents=["Another one"],
    ids=["5"]
)

client.persist()

input("Press key to continue...")

Thank you. I added an explicit persist. Here's what I have debugging through the code:
db = Chroma.from_documents(...)   # After this line, I see the index folder created, but no parquet files.
db.persist()
gives the following error: ValueError: You must specify a persist_directory oncreation to persist the collection.
But everything is being added to my persist directory, 'db'. When the application is killed, the parquet files show up in my specified persist directory.
That seems like a bug, definitely not expected behaviour

Upon further experimentation, I found that regardless if persist_directory is in the Settings object, you still need to pass it to the client init().
The following does NOT produce the error, and works as expected:
settings = Settings(chroma_db_impl='duckdb+parquet', persist_directory='db', anonymized_telemetry=False)
db = Chroma(embedding_function=embedding_function, client_settings=settings, persist_directory='db')

I'd think that if you set the directory in the Settings object, you shouldn't be passing it in again, and so this seems incorrect.

@JackLeick hmmmm that is odd. I'll take a look. glad you found a solution

I think the issue is actually within the LangChain Chroma wrapper, upon further investigation. Admittedly, there was weird behaviour beyond the persist directory error, such as the index files being saved, before the parquet files, so there might be something here, but I don't want to send anyone down a rabbit hole.
I'd think if the instance is persisted, all files should be persisted at once, so it still feels like there's still some odd behavior there.

@JackLeick there is some bad logic inside the chroma integration iirc - not sure who to git blame =D

@jeffchuber there are certainly several issues with the Chroma wrapper inside Langchain. Apart from the persist directory mentioned in this issue there are other problems:

The embedding function is optional when creating an object using the wrapper, this is not a problem in itself as ChromaDB allows that, there is a default function, however, in the wrapper if embeding_function is None no default embeddings will be used, the documents will be added without embeddings which would be useless for a vector database.

if ids is None:
            ids = [str(uuid.uuid1()) for _ in texts]
        embeddings = None
        if self._embedding_function is not None:
            embeddings = self._embedding_function.embed_documents(list(texts))
        self._collection.upsert(
            metadatas=metadatas, embeddings=embeddings, documents=texts, ids=ids
        )

A solution for this problem would be to define the default embedding function in the constructor.

Another issue is that the embedding function expected by the wrapper is different from the one being used in ChromaDB. The embedding function expected must implement a method called embed_documents which is not supported by default by the SentenceTransformer models. This can be easily solved by using the desired SentenceTransformer inside a HuggingFaceEmbeddings object, not a big deal but I guess could be better explained.

I will add these comments in the Langchain repository.

@jeffchuber checking Langchain code again I think the embedding function part may be correct although not very easy to read in their code, they're passing None to upsert so they will be computed :)

hi @jeffchuber, I was looking at this issue and my conclusion is that the code is messy when you try to use ChromaDB in Langchain instantiating chroma objects. I think the reason for that is that you're expected to use class methods instead. The main advantage is that no Settings is required and the code is much simpler and easier to understand. The examples in the documentation shows this:
# create the open-source embedding function
embedding_function = SentenceTransformerEmbeddings(model_name="all-MiniLM-L6-v2")

# load it into Chroma
db = Chroma.from_documents(docs, embedding_function)

And the confusion about the persistence is simplified:
# save to disk
db2 = Chroma.from_documents(docs, embedding_function, persist_directory="./chroma_db")
db2.persist()
docs = db.similarity_search(query)

# load from disk
db3 = Chroma(persist_directory="./chroma_db")
docs = db.similarity_search(query)
print(docs[0].page_content)

Personally, I don't like very much how this is implemented in the class but if you "forget" about the wrapper implementation details and use the class methods it looks much less confusing.

Chroma with 0.4 has now dropped duckdb and the messiness around atExit. Closing this issue.


[WIP] Add finalizer support to service controller to ensure cleanup on delete

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #53451
Special notes for your reviewer:

Finalizers are only added to services that want a load balancer; however, the controller will handle removing the finalizer regardless if it's a load balancer type or not if the finalizer is present (just in case).
The service cache wasn't needed anymore since we process service deletions with finalizers; not after they have been deleted. The services cache job was to keep the service prior to deletion. Since I removed that I took this opportunity to move to the rate limiting queue with an exponential backoff retry policy to reduce the complexity in this controller while keeping the same functionality.
I moved from update status to patch so we didn't have to update the whole service.

Release note:

Add finalizer support to service controller to ensure cleanup on delete

@prydie before I start on all the tests I think i'd prefer moving this upstream to get feedback on the implementation. That way I can save some time if any major changes need to take place.
That OK with you?

@jhorwit2 Sounds reasonable to me. Go for it.


Compatibility with zeek 3.x version

Tried to build this with zeek 3.2.0 but it seems it needs an update. can you please check ?

Same issue now with 4.0.0, any change this will be maintained going forward?

This is done in version 2.0.0


Add fzf

Because it's needed by kubectx and kubens.

Superseded-by #76

Not quite, the new versions still requires fzf.


Update tune_gemm.py to save benchmarking results in a file

Update tune_gemm.py to save benchmarking results in a file

Why do we need to save benchmark results in a file?

It can be useful to save the benchmark results. In my case I need use the benchmarked results to provide some analysis and instead of copy-paste the output, a file might come in handy. However, I think here are some problems:

Appending to the original output file will break the existing workflow, because the output file is in a yaml format that can be directly used for the benchmarking with all the tuned output, but appending these results will just break the yaml format and make the file not useable (unless you have them appended as comment and I didn't notice).
Making them as csv format (or any other format that can be directly consumed) might be better.

@yiqian1 I think Jingning's comment makes sense. Can you save the output of benchmark in another file?

Thanks for the feedback. I've changed the format of benchmark output file to CSV.


:hankey: Fudge the no-bookable clinic to the bottom of the results.

Just fudging it. It's a prototype afterall...

Mmmm i like fudge.


Manage contexts

I'm interested in adding a new set of subcommands like:

context create
context update
context delete
context list

But I would like to solicit input of how the inputs should be supplied, with special consideration for sensitive writeOnly values.

We're trying to keep a clear boundary between the scope of our Terraform provider, and spacectl. The latter is supposed to do things that are not a great fit for the former. Since managing the lifecycle of resources like contexts is generally handled by IaC, I'd be curious to learn what your use case is @abennett? Why would you need to create contexts from the CLI as opposed to writing a bit of Terraform?

Hey, @marcinwyszynski!
Our AWS roles that Spacelift uses are configured without the ability to mutate IAM as an additional risk mitigation. To compensate for this, I have written an accompanying CLI that goes through the following steps:

Create AWS session credentials with greater privileges
Detach the cloud integrations
Create a new context with the session creds
Attach them to the stack
Wait for a SIGINT whilst I apply
Detach context
Delete context
Reattach cloud integrations

I suppose it is a bit niche, and I am pretty satisfied with my custom solution if we wanted to avoid exposing contexts in spacectl.

I also have a use for interacting with contexts via the API, I have intentionally decoupled a particular piece of configuration from terraform as it's not clean or easy to manage it there. So I have a small script to add an environment variable and update it, the rest of the context is managed with terraform though.
@marcinwyszynski I think your point is totally fair, but it would be nice to have the spacectl tool be able to do it, even it's not the best way for most use cases.
As an aside, I don't see why read only sorts information couldn't be available, I would get a lost of use out of it and it would save a lot of time clicking about the UI.


⚠ ClamAV has degraded performance

In 98ccde0, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 57 ms

Resolved: ClamAV performance has improved in b7a7866.


axes_reset doesn't clear the cache.

I'll fix this if I get to it, but in case anyone else has time, go for it. I'd also appreciate input here on the design question below.
The Issue
In utils.reset we don't clear the cache, so even if it is cleared,  lockouts persist until cache expires.
We don't want to reset the whole cache if we're clearing doe just one username, but I'm not sure on the best approach
Approach 1
Add cache key revocation in an AccessAttempt post_delete signal. This would require closer coupling the cache key logic and the AccessAttempt, which I'm fine with since the cache is used to retrieve AccessAttempts and the decoupling is what caused the issue. The con is that since signals are async, the management command will return before the full cleanup is done which may be misleading to the caller as there will be a delay. We could attach another signal and wait, but that's kinda gross.
Approach 2
Keep the cache logic separate from AccessAttempt and do a looped delete instead of bulk delete in reset, for an ip or username specific reset, deleting the cache keys as we loop. the filtered data shouldn't be too big so It shouldn't be too much of a performance hit.

After typing it out I'm for Approach 2.  The separation of logic here seems bug prone, but if we only delete in reset, we should be ok.

Correct me if I'm wrong, but I believe Approach 1 is already present in the code. From axes/signals.py:
@receiver(post_delete, sender=AccessAttempt)
def delete_cache_after_delete(instance, **kwargs):  # pylint: disable=unused-argument
    cache_hash_key = get_cache_key(instance)
    get_axes_cache().delete(cache_hash_key)

Oh! I didn't see that you are correct, I'll have to dig into why this isn't working on my end.


How to handle Ngrx loading when browser back button..it will hit again replacing the state Object

M calling service in my component
For example
m calling service ngInit to assign the state as well
ngInit() {
here  based on some condition dispatch the Action assign in the state objects
dispatch action(customer Id)
}
In that page m having sub pages as well when i click navigate another page and come back previous page again,using browser back button or click back button.
NgOnit again called to replace the state object
Expected:when i come previous page to parent page instead of hitting the service again  i will get state to assign my component
How to avoid calling ngInit() ?
kindly give me the solution for that behavior

Please do not use Github for "how-to" requests - take them to https://gitter.im/ngrx/platform. Thanks!


Type signatures break when augmented across modules

🔎 Search Terms
"incompatible augmentation", "augmentation across modules"
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about module augmentation across packages

(Using codesandbox since Playground doesn't let you emulate multiple files/packages.)
⏯ Playground Link
https://codesandbox.io/s/flamboyant-feistel-m2rs99?file=/src/index.ts
💻 Code
// package-a
declare global {
  interface ReadableStream<R = any> extends AsyncIterable<R> {
  }
}
export declare const readableStreamToDataURL: (value: Uint8Array | ReadableStream<Uint8Array>) => Promise<string>;

// package-b
import { readableStreamToDataURL } from "package-b";
declare function writeFileToSomewhere(path: string, contents: string): void;

interface ReadableStream<R = any> extends AsyncIterable<R> {}
export const writeFile = async (path: string, value: string | Uint8Array | ReadableStream<Uint8Array>) => {
  if (typeof value !== "string") {
    value = await readableStreamToDataURL(value);
  }

  return writeFileToSomewhere(path, value);
};

🙁 Actual behavior
Augmenting a global type (ReadableStream) in one package doesn't seem to import the type in the other package.
Making the same augmentation in both packages breaks type checking if each package uses its augmented type as a function parameter.
[0] src/bridge.ts:45:43 - error TS2345: Argument of type 'Uint8Array | ReadableStream<Uint8Array>' is not assignable to parameter of type 'Uint8Array | ReadableStream<Uint8Array>'.
[0]   Type 'ReadableStream<Uint8Array>' is not assignable to type 'Uint8Array | ReadableStream<Uint8Array>'.
[0]     Type 'ReadableStream<Uint8Array>' is missing the following properties from type 'ReadableStream<Uint8Array>': locked, cancel, getReader, pipeThrough, and 2 more.
[0]
[0] 45     value = await readableStreamToDataURL(value);
[0]                                              ~~~~~

Additionally, the error message is unhelpful.  TypeScript is treating the types independently, but gives them both the same name.  ReadableStream (defined in 'package-a') is missing the following properties from type ReadableStream (defined in 'package-b') would be a better error message.
🙂 Expected behavior
Global augmentations in an imported package affect local types.  I shouldn't have to augment the type in two places.
However, since the augmentations are identical, I expect the type checking to pass even if they are defined independently.
Additional information about the issue
No response

This isn't an augmentation, it's a lexical shadowing of the other name. Allowing you to shadow global names is an intended feature of modules.

I'm not sure I understand.
If the types are identical, why are they breaking?  What's the right way to handle this?  Would I need to make e.g. ReadableSteam2019 and publish it as its own module that both the other modules import (or get lib.d.ts to change its definition)?

The types aren't identical, though; the one in package-b defines a local interface named ReadableStream because package-b is a module, and that declaration is effectively the empty interface + AsyncIterable. It's effectively the same thing as if you had written const Array = 1234; the name is now a local declaration, it didn't merge with anything.

Global augmentations in an imported package affect local types. I shouldn't have to augment the type in two places.

I looked back at my codebase and it seems this is working now.  The only reason I tried to define it in two places was because global inside the first wasn't propagating to both when I tried it.

ReadableStream (defined in 'package-a') is missing the following properties from type ReadableStream (defined in 'package-b') would be a better error message.

I still think the errors could be clearer.


Interface errors only show single missing method

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.7.1 darwin/amd64

But should apply to all.
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/zwass/dev/go"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.7.1/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.7.1/libexec/pkg/tool/darwin_amd64"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/4k/2q3ctn7d5_xb03_zsb3v6lgr0000gn/T/go-build228408602=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"

But should apply to all.
What did you do?
https://play.golang.org/p/Op7-5uXv2G
What did you expect to see?
tmp/sandbox622717221/main.go:13: cannot use test literal (type test) as type foo in assignment:
	test does not implement foo (missing foo, bar, baz methods)

Error indicating each of the missing methods. The existing error message makes it seem as though adding the bar method is sufficient to fix the error. The format doesn't necessarily matter, but the error message should indicate all of the missing methods.
What did you see instead?
tmp/sandbox622717221/main.go:13: cannot use test literal (type test) as type foo in assignment:
	test does not implement foo (missing bar method)

Error indicating a single missing method (no indication of why bar happens to be the method highlighted).

According to this: https://groups.google.com/forum/#!searchin/golang-nuts/Show$20all$20compiling$20errors|sort:relevance/golang-nuts/2Am5aqmIGxs/cP4PGn7c8XQJ
go build -gcflags="-e" should display all compiler errors but it still won't do it for this specific case. I think the behaviour there should be changed?

The current MissingMethod function really only return one missing method: https://golang.org/src/go/types/lookup.go?s=1550:1668#L227

@yaxinlx Just FYI, go/types is not used by the compiler, so that's no the reason why there's only one missing method shown (but go/types has the same "problem").
This is not so much an error but perhaps a "would like to have".

Duplicate of https://github.com/golang/go/issues/8095.
Closing this issue in favor of the older #8095 issue unless someone else thinks otherwise.


Fix issue with customer/bank references parsing

Fix the issue for the statement like this:
2001010101DR12,34FCHGTRF SVC//200101ZCPB123456
Some information here

NOTE: avoid newline is needed because "." character is any symbol except line terminators, when we use "[^...]" notation, line terminators are included in the match.
Fixes #96

I'm not 100% certain if this will cause issues for existing users but it seems like a good fix. It's really hard to properly parse such a terribly defined (or implemented) standard unfortunately :(


icon styles: svgSymbols / svg_templates

The svgSymbols mapp mod has become quite a long in the teeth.
The type icons should be retired once the styleParser has been reviewed and merged.
There are currently following type symbols.
dot
target
triangle
square
diamond
semiCircle
markerLetter
markerColor
circle
template
SVG icons hosted in the public directory should be made available for these.
The styleParser method can replace the type declarations with the matching svg.
It must still be possible to create an icon from a custom function. Memoization is crucial is this is to happen inside the theme method.
The template type icons should be created with the styleParser.

The svg_templates plugin method shouldn't be a plugin method. This method should always be executed when a mapview is created. But svg_templates should not be loaded twice in the case of multiple mapviews in a document.
With the svgSymbols being retired it doesn't make sense to have the type: template if there is only a single type.
It must still be possible to create a custom templates from a function.
There should be an interface to define custom templates and colour substitutes.
The templates should render without any colours being substituted.

The next step will be to create svg templates for each type.
These default templates could be imported as string from svg files in the public folder if possible.
The target: type needs to be translated into base icon dot (with shadow) and additional icon array items which do not have a shadow.
A translation method will be required for each of the type icons.
It may be necessary to flatten icon arrays where an array type target is in an icon array.


Marlo fails after 124 missions. Possibly out of TCP ports.

https://gist.github.com/jeweljames/788a8517ea76b02fa8a40970ee934398
Reported on Gitter (18/12/2018).
oth Minecrafts seem to running a mission while one agent host (called from Python) is waiting on second to turn up and the second agent host is saying that all ports are in use. Which would indicate that previous missions are not finishing. Are you calling reset() before the step() function returns "done"?

The agent host opens ports to allow Minecraft mod to connect back and send observations and video. The port range is 10000 to 11000 and all these are tried and all seem to be in use, causing "All ports in use" error.

Possibly due to repeated close() before mission is done. Safer to call reset() and safer still to wait for mission to complete (step() return done == True).

@AndKram Got it. would you also suggest that a new environment with a newly generated join token be created each time an episode needs to be run? or can the join token be reused?
I would like to learn what the abstraction behind join_token is, to understand the best way to do this.

join tokens are for a particular game but it's best to reuse them for missions, just doing a reset(). There's a example https://github.com/crowdAI/marLo/blob/master/examples/test_random_3game_mission.py that runs all the training missions but I would add an inner loop to that to repeatedly run the same mission multiple times (say 20 to 100) as then resets are very much faster. A new "internal server" is allocated in Minecraft when running a different world which is both costly and not without stability issues.

This error persists even after making sure that close is called only after step returns done as True.
I also ran the run_episode function from https://github.com/crowdAI/marlo-multi-agent-starter-kit in a loop and the error can be reproduced .
@AndKram Thanks for the explanation.

MarLo close() actually does nothing to close the AgentHost but it should be de-allocated by the Python garbage collector if the Env is garbage collected. The AgentHost destructor closes the TCP ports in use but that appears not to happen for you? I'd suggest using reset() instead of close(). You should only call init() once on a MarLo Env as close() does not really close the AgentHost. You could add a "del self.agent_host" to close() and it would be re-created  with "self.agent_host = AgentHost()" in env.init().
class MyEnv(marlo.Env):
def close():
del self.agent_host


Issue with asm_riscv docs

The docs say that various extensions are currently supported, but they do not appear to be.

@rsammelson Thanks, think the docs should be more accurate now.  Feel free to let me know if there's more issues with them.


Install fails

Intriguing package! Unfortunately getting started is a bit hard.
Although the docs (https://github.com/jruizgit/rules/blob/master/docs/py/reference.md) only tell us to install Redis I presumed a pip install durable was in order.
On PyPi I find 2 packages durable and durable_rules. Both fail to install.
Finally, the section "First App" is almost empty, but for a beginner probably the most relevant.
durable:
DEPRECATION: --no-install, --no-download, --build, and --no-clean are deprecated.  See https://github.com/pypa/pip/issues/906.
Downloading/unpacking durable
  Could not find any downloads that satisfy the requirement durable
Cleaning up...
No distributions at all found for durable
Storing debug log for failure in /Users/mjm/.pip/pip.log

durable_rules:
DEPRECATION: --no-install, --no-download, --build, and --no-clean are deprecated.  See https://github.com/pypa/pip/issues/906.
Downloading/unpacking durable-rules
  Downloading durable_rules-0.31.16.tar.gz
  Running setup.py (path:/private/var/folders/wd/dw1f3w9x0xv2nm57vcs7z3g00000gn/T/pycharm-packaging0.tmp/durable-rules/setup.py) egg_info for package durable-rules

Downloading/unpacking werkzeug (from durable-rules)
Installing collected packages: durable-rules, werkzeug
  Running setup.py install for durable-rules
    building 'rules' extension
    clang -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -Isrc/rules -I/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c src/rulespy/rules.c -o build/temp.macosx-10.10-x86_64-2.7/src/rulespy/rules.o
    src/rulespy/rules.c:2:10: fatal error: 'rules.h' file not found
    #include <rules.h>
             ^
    1 error generated.
    error: command 'clang' failed with exit status 1
    Complete output from command /Users/mjm/Dropbox/Devel/Rules/venv/bin/python -c "import setuptools, tokenize;__file__='/private/var/folders/wd/dw1f3w9x0xv2nm57vcs7z3g00000gn/T/pycharm-packaging0.tmp/durable-rules/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" install --record /var/folders/wd/dw1f3w9x0xv2nm57vcs7z3g00000gn/T/pip-2LrYKg-record/install-record.txt --single-version-externally-managed --compile --install-headers /Users/mjm/Dropbox/Devel/Rules/venv/bin/../include/site/python2.7:
    running install

running build

running build_py

creating build

creating build/lib.macosx-10.10-x86_64-2.7

creating build/lib.macosx-10.10-x86_64-2.7/durable

copying libpy/durable/__init__.py -> build/lib.macosx-10.10-x86_64-2.7/durable

copying libpy/durable/engine.py -> build/lib.macosx-10.10-x86_64-2.7/durable

copying libpy/durable/interface.py -> build/lib.macosx-10.10-x86_64-2.7/durable

copying libpy/durable/lang.py -> build/lib.macosx-10.10-x86_64-2.7/durable

running build_ext

building 'rules' extension

creating build/temp.macosx-10.10-x86_64-2.7

creating build/temp.macosx-10.10-x86_64-2.7/src

creating build/temp.macosx-10.10-x86_64-2.7/src/rulespy

clang -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -Isrc/rules -I/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c src/rulespy/rules.c -o build/temp.macosx-10.10-x86_64-2.7/src/rulespy/rules.o

src/rulespy/rules.c:2:10: fatal error: 'rules.h' file not found

#include <rules.h>

         ^

1 error generated.

error: command 'clang' failed with exit status 1

----------------------------------------
Cleaning up...
Command /Users/mjm/Dropbox/Devel/Rules/venv/bin/python -c "import setuptools, tokenize;__file__='/private/var/folders/wd/dw1f3w9x0xv2nm57vcs7z3g00000gn/T/pycharm-packaging0.tmp/durable-rules/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" install --record /var/folders/wd/dw1f3w9x0xv2nm57vcs7z3g00000gn/T/pip-2LrYKg-record/install-record.txt --single-version-externally-managed --compile --install-headers /Users/mjm/Dropbox/Devel/Rules/venv/bin/../include/site/python2.7 failed with error code 1 in /private/var/folders/wd/dw1f3w9x0xv2nm57vcs7z3g00000gn/T/pycharm-packaging0.tmp/durable-rules
Storing debug log for failure in /Users/mjm/.pip/pip.log

Hi mjmare, thanks a lot for your interest in 'durable_rules'. Yes it should be 'pip install durable_rules' (durable was the name of the old package). However, as I kept all my focus on performance benchmarks, I haven't finished the Python package. Please give me a couple of days. I'll let you know when it is ready.

Hi Jesus
Thanks for working on the project since a rules engine in python is really needed IMHO. There are some other projects but they seem abandoned or are very hard to understand. That’s why durable is so interesting. Hope you can work out the kinks. To make it more accessible to mere mortals like me, I hope you can provide a tutorial (distinct from the reference doc, which, currently, is a bit dense for me).
Kind regards
Marcel

On 05 Apr 2015, at 23:58, Jesus Ruiz<EMAIL_ADDRESS>wrote:
Hi mjmare, thanks a lot for your interest in 'durable_rules'. Yes it should be 'pip install durable_rules' (durable was the name of the old package). However, as I kept all my focus on performance benchmarks, I haven't finished the Python package. Please give me a couple of days. I'll let you know when it is ready.
—
Reply to this email directly or view it on GitHub https://github.com/jruizgit/rules/issues/5#issuecomment-89861963.

Hi Marcel, I have uploaded a working build to PiPy (along with a wheel for OS X). I love Python, but packaging is so tricky... I updated the setup step in the doc. I'll work on adding a step by step tutorial. This might help you getting started:
Now that your cache ready, let's write a simple rule:

Start a terminal
Create a directory for your app: mkdir firstapp cd firstapp
In the new directory sudo pip install durable_rules (this will download durable_rules and its dependencies)
In that same directory create a test.py file using your favorite editor
Copy/Paste and save the following code:

from durable.lang import *
with ruleset('test'):
    @when_all(m.subject == 'World')
    def say_hello(c):
        print ('Hello {0}'.format(c.m.subject))

    @when_start
    def start(host):
        host.post('test', {'id': 1, 'sid': 1, 'subject': 'World'})

run_all()

In the terminal type python test.py
You should see the message: Hello World

Note: If you are using Redis To Go, replace the last line.
d.runAll([{'host': 'hostName', 'port': port, 'password': 'password'}]);

On my local install (python3, brew installed redis, durable rules 0.31.23) I get this traceback:
Traceback (most recent call last):
File "/Users/mjm/Dropbox/Devel/Rules/test.py", line 1, in
from durable.lang import *
File "/Users/mjm/Dropbox/Devel/Rules/venv3/lib/python3.4/site-packages/durable/lang.py", line 1, in
import engine
ImportError: No module named 'engine'

Hi Marcel, thanks for trying this again. I'm sorry it still doesn't work. May I ask a few more questions?

I assume you did pip install durable_rules, did the package compile and install without errors?
If you do ls /Users/mjm/Dropbox/Devel/Rules/venv3/lib/python3.4/site-packages/durable, what do you see? Do you see engine.py in the directory?
Do you have python 2.7 installed? I'm surprised to see the package under python 3.4 (as right not it is only supported for 2.7)

Thanks,

On 15 Apr 2015, at 22:42, Jesus Ruiz<EMAIL_ADDRESS>wrote:
Hi Marcel, thanks for trying this again. I'm sorry it still doesn't work. May I ask a few more questions?
I assume you did pip install durable_rules, did the package compile and install without errors?
Yes, no errors
If you do ls /Users/mjm/Dropbox/Devel/Rules/venv3/lib/python3.4/site-packages/durable, what do you see? Do you see engine.py in the directory?
init.py  pycache engine.py interface.py lang.py

Do you have python 2.7 installed? I'm surprised to see the package under python 3.4 (as right not it is only supported for 2.7)
You’re correct: it was python3. I have now installed python2 and it works.

Will experiment further.
Marcel

Cool, the package has all the right files and it is installing it correctly. For now only Python 2.7. Please let me know if you have any other questions.


fix: fail using biome v1.8.0

related: https://github.com/mongolyy/reviewdog-action-biome/pull/50
Fix this :)
https://github.com/mongolyy/reviewdog-action-biome/actions/runs/9412832575/job/25928410675?pr=52#step:4:17
Should it be fixed in this branch?
renovate/biomejs-biome-1.x-lockfile

@skanehira
Thanks for your contribution.
I would like to make this action a compatible response to the changes in biome 1.8.
In other words, I want this action to work whether you are using biome 1.8 or higher or not!
When biome 2 is released, I'd like to make this action version 2 as well, and make the changes you have written!
I am currently working on #50.
I hope to have this issue resolved by the end of the week!

@mongolyy I got it :)
Thank you:)
I'll close this PR

@skanehira
Thank you!
#50 has been merged and v1.4.0 has been released for Biome v1.8.0.
https://github.com/mongolyy/reviewdog-action-biome/releases/tag/v1.4.0
Try it and let me know if you have any problems.


Add jsonDependencyReport task

Fixes https://github.com/gradle/gradle/issues/21894
Context

Added jsonDependencyReport task to project-report plugin to output project dependencies in JSON format.
Contributor Checklist

[x] Review Contribution Guidelines
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[x] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[x] Provide unit tests (under <subproject>/src/test) to verify logic
[x] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[x] Ensure that tests pass sanity check: ./gradlew sanityCheck
[x] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation

I highly doubt we will want to support functionality like this natively within Gradle. In particular, we have no way of managing a JSON schema between Gradle versions, like we do with Java types -- i.e. deprecations and a "schema" (Java interfaces). The JSON used by the HTML and generated by JsonProjectDependencyRenderer was never intended to be stable in any manner, and we will likely want to keep it that way.
That's not to say we shouldn't support this sort of functionality within third-party plugins. We definitely think this should be possible -- our Java/Groovy/Kotlin API should 100% be able to support these sorts of use-cases. If you find that the existing internal JSON-generating code relies on internal APIs which make a non-internal generator impossible, then it is possible we can introduce public APIs to fill those gaps.

In regards to the linked GitHub dependency graph issue -- this is being actively worked on internally. A solution to this issue is being prototyped actively.

Sorry for the late reply.
According to Justin we will not add this feature so closing this PR.

Would this be the same as the build scan output?

Would this be the same as the build scan output?

No, a build scan has way more information about executed tasks, performance, test results, etc.


Cache Purge for Menus and Widgets

Hello,
I was wondering how users have been handling the caching when changes are made to the header/footer menus and also to widgets such as Latest Posts that are site-wide.
Thank you!

We have plugin hooks to purge all cache on theme change: https://github.com/cloudflare/Cloudflare-WordPress/blob/master/cloudflare.loader.php#L67-L68
I think in similar fashion we should do on header/footer menus change, I haven't tested it, but I assume it could be already the case. If not feel free to make a PR for purging cache on menus change.

please join the conversation  https://github.com/cloudflare/Cloudflare-WordPress/issues/275#issuecomment-804823964, closing as a duplicate.


az aks get-credentials not returning access-profile

I am using Azure-CLI version 2.0.24, however az aks get-credentials is not working.
I am getting the following error:

'ManagedCluster' object has no attribute 'properties'
Traceback (most recent call last):
File "/home/xiou/lib/azure-cli/local/lib/python2.7/site-packages/knack/cli.py", line 193, in invoke
cmd_result = self.invocation.execute(args)
File "/home/xiou/lib/azure-cli/local/lib/python2.7/site-packages/azure/cli/core/commands/init.py", line 319, in execute
six.reraise(*sys.exc_info())
File "/home/xiou/lib/azure-cli/local/lib/python2.7/site-packages/azure/cli/core/commands/init.py", line 292, in execute
result = cmd(params)
File "/home/xiou/lib/azure-cli/local/lib/python2.7/site-packages/azure/cli/core/commands/init.py", line 169, in call
return super(AzCliCommand, self).call(*args, **kwargs)
File "/home/xiou/lib/azure-cli/local/lib/python2.7/site-packages/knack/commands.py", line 109, in call
return self.handler(*args, **kwargs)
File "/home/xiou/lib/azure-cli/local/lib/python2.7/site-packages/azure/cli/core/init.py", line 328, in default_command_handler
result = op(**command_args)
File "/home/xiou/lib/azure-cli/local/lib/python2.7/site-packages/azure/cli/command_modules/acs/custom.py", line 1329, in aks_get_credentials
access_profiles = mc.properties.access_profiles
AttributeError: 'ManagedCluster' object has no attribute 'properties'

2.0.26 solved it for me on Win10

In that case, I will close this.  @rajshakerp if you are still encountering a problem, please open a new issue.


Merge two functions in taming

The functions for unconstrained Markowitz and long-only have like 99% overlap. I suggest to add a flag like
long_only = False
in the parameters and merge them into one function.

Fixed this in the "synthetic returns" branch


Enable Flipper for custom Xcode configurations

Fixed Flipper not recognizing app when using custom Xcode configuration names.

Summary
This fixes the problem that renaming the "Debug" Xcode configuration causes Flipper to not work. Despite using the recommended :configurations parameters and instructing Cocoapods that it was a debug build (see #34332), it still wouldn't recognize the app due to missing C preprocessor flags, specifically it was missing -DFB_SONARKIT_ENABLED=1.
Changelog

[General] [Fixed] - Flipper now supports custom Xcode build configuration names
Test Plan
I applied the PR change to 0.68.2 (which work similarly but code was refactored since then). I then used patch-package to test the change and the fix worked on 2 separate projects.
Patch-package change equivalent:
diff --git a/node_modules/react-native/scripts/react_native_pods.rb b/node_modules/react-native/scripts/react_native_pods.rb
index f2ceeda..2ea57d6 100644
--- a/node_modules/react-native/scripts/react_native_pods.rb
+++ b/node_modules/react-native/scripts/react_native_pods.rb
@@ -180,7 +180,7 @@ def flipper_post_install(installer)
     # Enable flipper for React-Core Debug configuration
     if target.name == 'React-Core'
       target.build_configurations.each do |config|
-        if config.name == 'Debug'
+        if config.debug?
           config.build_settings['OTHER_CFLAGS'] = "$(inherited) -DFB_SONARKIT_ENABLED=1"
         end
       end

Screen shot of Xcode after the patch has been applied, for RN v0.68.2:

Hi @scarlac, thanks for the PR. Could you also update the ruby tests, please?

@cipolleschi I tried updating the tests but it started to go beyond what I can reasonably test. The limitation of the mocks is that they don't implement the config.debug? method and adding it in requires either simply hard-coding it based on a name, which won't improve tests, or reimplementing the Xcodeproj functionality quite extensively:
Xcodeproj's build_configuration.rb implements ?debug, which calls resolve_build_setting, which calls resolve_variable_substitution, which calls expand_build_setting, and it goes on.
On top of that, I don't know how to modify the cocoapods debug mappings in the current tests.
Do you have any specific test in mind that you want added?

@scarlac Thanks for trying. My opinion on tests is that we should test what we own, not other parts. We don't own the implementation of the debug? property, therefore I don't think we should worry about how it is implemented.
What I would do is to:

Go to the InstallerMock.rb
Update the BuildConfigurationMock:

class BuildConfigurationMock
  attr_reader :name
  attr_reader :build_settings
+  @is_debug

- def initialize(name, build_settings = {})
+ def initialize(name, build_settings = {}, is_debug = false)
    @name = name
    @build_settings = build_settings
+  @is_debug = is_debug
  end

+ def debug?
+    return @is_debug
+  end
end

Go to flipper-test.rb
Update the prepare_mock_installer to accept the is_debug parameter and pass it to the build config.
Update the test_postInstall_updatesThePodCorrectly to pass the proper parameter to the prepare_mock_installer function
Potentially add another test_postInstall_whenConfigIsNotDebug_doeNotUpdateThePod to make sure that when debug? returns false, we don't change anything.

What do you think?
PS: Danger fails because the changelog must have the square brackets. So it should be:
[General] [Fixed] - Flipper now supports custom Xcode build configuration names

@cipolleschi I added the test. It needs to check for the config name, because if it uses debug? in the test then it will always succeed due to the mock both being initialized with the value, and just simply checking that same value again. We need to match on the config name and then then build_settings (which was being done already).
The new dummy config is called CustomConfig.
The tests will already make sure that "Release" and "Debug"'s build_settings are correct (empty or has FB_SONARKIT_ENABLED, respectively) so I don't think we need another test.
I fixed the change log message as well.


[AI Agent idea] Story Wizard

Description
An AI agent that can generate awesome stories
Additional Information
No response

/assign @Vivek-GuptaXCode


Submit Abstract and Give Talk at WikiConference North America -  How to Create Wikimedia Working Groups for GLAMs

As a BHL Wiki Founding Member, I want to discuss how to create working groups for GLAMS so that the broader community can understand:

Group formation timeline
Experience and activities
Results
Supporting others interested in starting a Wikimedia Working Group.

Abstract Linkhttps://wikiconference.org/wiki/Submissions:2024/How_to_create_Wikimedia_Working_Groups_for_GLAMs

Added abstract link this is in TESTING. May need to work on some presentation materials for @GiFontenelle. Let us know.


Workaround for #52, release bindings in .NET Core on non-Windows systems

Comment at #52

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Publish 8.7-20240213015211+0000

Publish 8.7-20240213015211+0000

@bot-gradle test and merge

The merge queue build has started. Click here to see all failures if any.


deactivate on mobile

is there any possibility to deactivate the scrolling on viewports below 768px? because after that my layout changes and the scrolling is not needed anymore.

You could use the destroy method like this:
(function($){
	$(window).resize(function(){
		if($(this).width()>768){
			$(selector).mCustomScrollbar(); //apply scrollbar with your options
		}else{
			$(selector).mCustomScrollbar("destroy"); //destroy scrollbar
		}
	}).trigger("resize");
})(jQuery);

Is this what you need?

something like that yes. but i made it with an other approach now:
var handleMediaChange = function (mediaQueryList) {
        if (mediaQueryList.matches) {

        }
        else {
            $(".googlemap .gmapoverlay").mCustomScrollbar({
                theme: "minimal"
            });
        }
    }

    var mediaQueryMatch = window.matchMedia("(max-width: 767px)");
    mediaQueryMatch.addListener(handleMediaChange);
    handleMediaChange(mediaQueryMatch);

Yes window.matchMedia is better as it matches CSS media queries. There are also alternative ways to detect mobile/phone, for example web.wurfl.io or mobile-detect.js.

I've also added more info and examples in plugin's FAQ

page is not moving when scroll bar is reached end of div in android browser.


Revert removal of attribution from README.md

Please revert PR  #19 removal of the detailed list of organizations in the Thanks section of the README.md file.
The organizations deserve attribution for their long-standing work in both the CoC and the README. The README is one of the first documents a developer will see when visiting the repo. Appropriate recognition and thanks should be prominent in the README for all community members to view easily (without having to click through to a website).

Fixed, thanks!


Not signed in, but the following is displayed: "You cannot fork a repository you own"

Gitea version: 1.4.1

Git version: ?

Operating system: Debian 8.10

Can you reproduce the bug at https://try.gitea.io:

[x] Yes (provide example URL) : https://try.gitea.io/gitea/gitea
[ ] No
[ ] Not relevant

Log gist:

Description

I open a website of a Gitea-Repo e.g. https://try.gitea.io/gitea/gitea
and I'm not signed in
I move the mouse over the Fork-Button on the right top corner
or
I click on the Fork-Button on the right top corner

then I get the message "You cannot fork a repository you own".
But in fact, I'm not signed in and I don't own it!
I expected a message like "You have to sign in to fork a repo"
Screenshots

Edit:
It would be great if the behavior is identical to the neighboring buttons "Watch" and "Star".
When I press one of those two buttons I'm asked to sign in.


Remove check that breaks adding shipping method

This form could be rendered without $sm(e.g. you add a new shipping method), but it still should show shipping-method-specific fields, otherwise you can't even standard methods(e.g. flat rate). This check prevents rendering shipping-method-specific fields.

I'm a little confused by this one - is this fixing a bug, or is it to allow for some dynamically added shipping methods in the checkout?

Yep, it's fixing a bug - you can't add a Flat Rate in the newest version because the fields that are needed are not present on the form.
When you add a new shipping method, the rendered form must include fields specific to the method that you're adding. If you have that isset-check, it will only render the method-specific fields when you edit a method, but not when you add one. A lot of methods, including standard ones(Flat Rate) have fields that are required/non-nullable in the database, so they must be present on the form even if the they are empty.

./packages/community_store/src/CommunityStore/Shipping/Method/Types/FlatRateShippingMethod.php
baseRate is non-nullable here, so when you add a shipping method, this file should be rendered for Flat Rate:
./packages/community_store/elements/shipping_method_types/flat_rate/dashboard_form.php
baseRate field is defined here. If this form is not rendered when you add a new shipping method, you won't be able to add a flat rate. This form is not rendered if this isset-check is present, it'll only show a couple of standard fields(name, ..)

Ahh, I see, it was a typo from when I did a bit of PHP8 work, so fairly recent.
Thanks for this - I've pushed up a fix. The check still needed to be there, but was just the wrong variable name,.


Thanks
George

Thanks for the catch! It's a silly typo... I will fix it immediately.
Thanks,
Zongyi


Replace terraform ValuePointer function with custom pointer conversion function

When converting a terraform model value to Go pointer, if the value is unknown set it to nil

Fixes #124


Support auto-configuration of the Datastore emulator

Currently, we support the Datastore emulator by allowing the client to configure host and port via the spring.cloud.gcp.datastore.emulator-host property. However, it remains the user's responsibility to start and stop the emulator.
The proposal is to add the spring.cloud.gcp.datastore.emulator=true property to automatically configure the emulator, start, and stop it. LocalDatastoreHelper from google-cloud-java can be used to accomplish it.
See discussion here.

I created the issue on google github here and I will submit the PR accepting a custom port.

@meltsufin google cloud lauched the release if my modification accepting port on the datastore emulator:
https://github.com/googleapis/google-cloud-java/releases/tag/v0.88.0

@lucasoares Would you be interested in a contributing a PR for it?

@meltsufin I can help with that but I'm not a spring contributor.. To do that I will need to change datastore client's version, but spring use the google client BOM in spring-cloud-gcp-dependencies and it will not let me change only the datastore version. What I should do in this case?
After that will be the easy part :)
If I continue with this contribution I will try to enter in some community chat to ask ppl questions like that. Thank you.


FLW-868 Make OnFinality nodes default one

Codecov Report

Merging #259 (69c3ab2) into develop (7920849) will increase coverage by 1.35%.
The diff coverage is 47.93%.


[BUG] contact us submission allows single-letter input

Description
contact us submission allows single-letter input This leads to unhelpful and incomplete feedback.
Steps to Reproduce
A minimum character limit should be enforced to ensure meaningful responses.
Expected Behavior
The form should enforce a minimum character limit (e.g., 10 characters) to ensure users provide more detailed and meaningful message.
Actual Behavior
Users can submit feedback with only a single letter, resulting in incomplete and non-actionable responses.
Additional Information
No response
Browser
Chrome
Checklist

[X] I have checked the existing issues.
[X] I have read the Code Of Conduct
[X] The changes don't break the code
[X] Please attach screenshots and videos of the development work once done

I would like to work on this issue, please assign me

Hey @ananyag309  I'm assigning this issue to you. Please submit it within 3 days. As a mentor, I can only assign the 'Level 1' label the project admin will decide the rest.


Add: ATN Islamic TV [BD]

Channel Name
ATN Islamic TV
Alternative Names (optional)
No response
Network (optional)
No response
Owners (optional)
No response
Country
BD
Subdivision (optional)
No response
City (optional)
No response
Broadcast Area
c/BD
Languages
Ben
Categories (optional)
Religious
NSFW
FALSE
Launched (optional)
No response
Closed (optional)
No response
Replaced By (optional)
No response
Website (optional)
No response
Logo
https://www.jagobd.com/wp-content/uploads/2016/02/atnislamictv.jpg?x50681
Notes
No response

Please update your request:

category name should be in lowercase
language code must be in lowercase

https://github.com/iptv-org/database/blob/master/CONTRIBUTING.md#channels


The original images of Image A and Image B in figure 1

Thanks for your excellent work!
Could you kindly provide the original images of Image A and Image B in Figure 1?  Your results look very impressive, and I would like to verify the accuracy of my reproduction. It would be immensely helpful if you could share the original images, allowing me to make a detailed comparison with the results in your paper.

Hi, thanks for your interest in smooth diffusion. I have uploaded the images to images/interpolation, namely dog1.png and dog2.png. Remember to use null-text inversion and set the text prompt to a realistic dog if you want to reproduce the results of stable diffusion shown in the paper.
We are still working on the code and demo and will release them soon.

Thanks!


How to check a column existence in controller

I want to check a column existence in my code.
This functionality works truly in migrations but not in controllers.
What I tried
As mentioned in the knex docs, the hasColumn method belongs to the schema. I added const Schema = use('Schema') to the controller but I faced this error,

Cannot find module 'Schema'

What should I do?

You can use Database.schema.hasColumn.
Also you can use the forum or discord server in future to get quick replies on generic questions, which are not yet classified as bugs

Closing since no answer from issue reporter.


Possibility to change node shape when plotting signal?

Hi pygsp team,
I was trying to find a way to change the shape of a node, is that possible? I cannot seem to find the functionality to do so. I did find the way to change vertex size and color, but not the shape of the nodes. I have two types of sensors in my network and I would like to show that clearly in my figures.
Kind regards and thanks in advance!
Stefan

The PyGSP uses matplotlib for plotting. Hence you can do any customization with matplotlib directly.
For example:
from matplotlib import pyplot as plt
import pygsp as pg
graph = pg.graphs.Sensor()
fig, ax = plt.subplots()
graph.plot(ax=ax)
del ax.collections[1]
ax.scatter(*graph.coords.T, marker='s')

Depending on the amount of customization required, it might be easiest to plot the graph with matplotlib. After all, it's just a scatter with a set of lines.

Hi @mdeff , thanks for your response. There is only one issue, since this procedure removes the signal colours from the plot. How could this procedure take place while still showing a signal plotted on the graph?

ax.scatter(*graph.coords.T, c=mysignal, marker='s')
You can do anything matplotlib can (e.g., changing marker size, colormaps, etc.). See matplotlib's doc.


Allow whitelisting certain actions

Thanks for making this! Great use case.
We'd like the ability to "trust" certain actions. For example<EMAIL_ADDRESS>is maintained by github, a group I trust to not inject malicous code out of the blue.
Other actions we arent so trusting of, and would like to see a failed workflow for non-sha-pins (The existing behavior).
PR -> https://github.com/zgosalvez/github-actions-ensure-sha-pinned-actions/pull/5

The PR is now at #9, awaiting review.

Could really use this for GHE reusable workflows.

#16


Update data-pick.php

A quick fix for PHP 8.X for this error.
production.ERROR: Call to a member function isNotEmpty() on null {"userId":1,"exception":"[object] (Error(code: 0): Call to a member function isNotEmpty() on null at /opt/librenms/html/plugins/Weathermap/data-pick.php:329)

Thanks!


feat: Add typings for async interface released for Django 4.1

Those are the async methods added to Django in the 4.1 release.

Looks great, thank you!!

Thanks! :)
Can we get a release for this?

Sorry for the delay, still haven't gotten around to automating releases
should be released in the latest version: 0.16.0


Gods with images should be ranked higher

All gods with a picture should be ranked higher. Maybe it's a matter of updating the generate script to check the ranking based on the presence of the file/picture field?

This has been fixed


connectionTimeout not working properly

Environment
HikariCP version: 2.3.7
JDK version     : 1.8.0_172
Database        : SQL Server/ JTDS
Driver version  :  1.3.1
Play version: 2.4.6

-----------------------------------------------------------------------------------------
We use HikariCP with Play! 2.4.6. The application ran fine before, but throw SQLTimeoutException due to increase load.
A request timed out after 23607ms , but the Hikari connectionTimeout is set to 10000ms.
Shouldn't the connection acquire timeout after 10000ms?
I haven't been able to reproduce this problem locally. And ConnectionTimeout is set to HikariCP correctly I confirm.

**Play's HikariCP config**
play.db.pool=hikaricp
db.default.url=${database.jdbc.url}
db.default.driver="net.sourceforge.jtds.jdbc.Driver"
db.default.hikaricp.autocommit=true
db.default.hikaricp.maximumPoolSize=25
db.default.hikaricp.minimumIdle=10
db.default.username=${username}
db.default.password=${password}
db.default.hikaricp.connectionTimeout = 10000
db.default.hikaricp.connectionTestQuery="select 1"
db.default.hikaricp.readOnly = true
db.default.hikaricp.poolName = current
db.default.hikaricp.disableJMX = false
db.default.hikaricp.registerMbeans= true

db.central.url=${database.jdbc.url}
db.central.driver="net.sourceforge.jtds.jdbc.Driver"
db.central.hikaricp.autocommit=true
db.central.hikaricp.maximumPoolSize=15
db.central.hikaricp.minimumIdle=10
db.central.username=${username}
db.central.password=${password}
db.central.hikaricp.connectionTimeout = 10000
db.central.hikaricp.connectionTestQuery="select 1"
db.central.hikaricp.readOnly = true
db.central.hikaricp.poolName = central
db.central.hikaricp.disableJMX = false
db.central.hikaricp.registerMbeans= true

Below Log :
java.sql.SQLTimeoutException: Timeout after 23607ms of waiting for a connection.
        at com.zaxxer.hikari.pool.BaseHikariPool.getConnection(BaseHikariPool.java:227) ~[com.zaxxer.HikariCP-2.3.7.jar:na]
        at com.zaxxer.hikari.pool.BaseHikariPool.getConnection(BaseHikariPool.java:182) ~[com.zaxxer.HikariCP-2.3.7.jar:na]
        at com.zaxxer.hikari.HikariDataSource.getConnection(HikariDataSource.java:93) ~[com.zaxxer.HikariCP-2.3.7.jar:na]
        at play.api.db.DefaultDatabase.getConnection(Databases.scala:143) ~[com.typesafe.play.play-jdbc_2.11-2.4.6.jar:2.4.6
]

Typically, HikariCP has extremely accurate timeouts, +/-2ms.  However, HikariCP threads, like all Java threads, are subject to the OS scheduler.
Under sufficient load all threads will begin to experience CPU starvation.  In the case, approximately 13ms delay.  If, as you say, this timeout occurs due to increasing load, it is hardly surprising.
Having said that, I would be remiss if I did not also mention that running the latest version of HikariCP is always recommended. v2.3.7 is very old, and many fixes and improvements have been made since.

@brettwooldridge  Thanks for your response.  We will update the version later.
But I have a confusion for this SQLTimeoutException.
If delay, my understand is that timeouts should be accurate timeouts, +13ms.  But it is amazing for exception Timeout 23607ms, it is much larger than connectionTimeout config.
Could you give me some advice for finding the cause?  Thanks.

@DamilyLi There can only be one cause, as far as I am concerned: over-committed CPU.
I strong suggest enabling monitoring for the pool and collecting metrics.  Additionally, also collect metrics from the application server itself.  If you graph a histogram if CPU usage, and compare it with the timestamps of timeouts in the logs, as well as the histogram of active connections in the pool, you will almost certainly find that the timeouts occur when the CPU usage is max'ed out at 100%.


Pigs dont eat corn or onions

And they should
forge 1.18.2

onions are from farmers delight, i have no power over them

Corn at least?


Create documentation on Gaia Storage

Documentation in https://github.com/blockstack/gaia
Tagging @yknl for reviews

Sent a PR with my review.

This looks good to me!

Let's do review, changes & discussion via a pull request in the future!
Marking this as accepted.


Ingress Template Generation Issue

Whilst playing with this in AWS using ALB, I was trying to enforce SSL redirection directly in the ingress configuration.
I looked at some changes and cannot see any obvious issue.
Below are the two types of configuration I have tried:
ingress:
  enabled: true
  annotations:
    kubernetes.io/ingress.class: alb
    alb.ingress.kubernetes.io/scheme: internet-facing
    alb.ingress.kubernetes.io/target-type: ip
    alb.ingress.kubernetes.io/certificate-arn: redacted
    alb.ingress.kubernetes.io/listen-ports: '[{"HTTP":80},{"HTTPS":443}]'
    alb.ingress.kubernetes.io/actions.ssl-redirect: '{"Type":"redirect","RedirectConfig":{"Protocol":"HTTPS","Port":"443","StatusCode":"HTTP_301"}}'
  hosts:
    - host: redacted
      paths:
        - path: /*
          serviceName: ssl-redirect
          servicePort: use-annotation
        - path: /*

and also
ingress:
  enabled: true
  annotations:
    kubernetes.io/ingress.class: alb
    alb.ingress.kubernetes.io/scheme: internet-facing
    alb.ingress.kubernetes.io/target-type: ip
    alb.ingress.kubernetes.io/certificate-arn: redacted
    alb.ingress.kubernetes.io/listen-ports: '[{"HTTP":80},{"HTTPS":443}]'
    alb.ingress.kubernetes.io/actions.ssl-redirect: '{"Type":"redirect","RedirectConfig":{"Protocol":"HTTPS","Port":"443","StatusCode":"HTTP_301"}}'
  hosts:
    - host: redacted
      paths:
        - path: /*
          backend:
            serviceName: ssl-redirect
            servicePort: use-annotation
        - path: /*

Both generate similar configuration to the following:
# Source: netbox/templates/ingress.yaml
apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
  name: prod-netbox
  labels:
    helm.sh/chart: netbox-2.3.0
    app.kubernetes.io/name: netbox
    app.kubernetes.io/instance: prod
    app.kubernetes.io/version: "v2.9.3"
    app.kubernetes.io/managed-by: Helm
  annotations:
    alb.ingress.kubernetes.io/actions.ssl-redirect: '{"Type":"redirect","RedirectConfig":{"Protocol":"HTTPS","Port":"443","StatusCode":"HTTP_301"}}'
    alb.ingress.kubernetes.io/certificate-arn: redacted
    alb.ingress.kubernetes.io/listen-ports: '[{"HTTP":80},{"HTTPS":443}]'
    alb.ingress.kubernetes.io/scheme: internet-facing
    alb.ingress.kubernetes.io/target-type: ip
    kubernetes.io/ingress.class: alb
spec:
  rules:
    - host: "redacted"
      http:
        paths:
          - path: map[backend:map[serviceName:ssl-redirect servicePort:use-annotation] path:/*]
            backend:
              serviceName: prod-netbox
              servicePort: http
          - path: map[path:/*]
            backend:
              serviceName: prod-netbox
              servicePort: http

This issue seems to be present in v2.1.0, v2.2.0, and v2.3.0.
It's possible I am doing something wrong, but it's a little tricky finding documentation for this. I had looked in the template here:
https://github.com/bootc/netbox-chart/blob/master/templates/ingress.yaml
...but that didn't seem to provide any clues.
My thought is that this line might be somehow returning true:
{{- if kindIs "string" . }}
I am not familiar enough with Helm to suggest a fix.

Unfortunately this functionality is not yet in any released version of the chart; it was added after I released 2.3.0. It will be present in the 3.0.0 release later today.

Unfortunately this functionality is not yet in any released version of the chart; it was added after I released 2.3.0. It will be present in the 3.0.0 release later today.

Oh fantastic! I'll be first to try it!


Update DOM so that  has various 'on*' props

Fixes #45

Simply rerunning codegen with react-html-attributes resulted in these changes (added on* properties to form). It doesn't seem like they changed anything that would require changes in codegen, only the missing properties were added.

Oh right, sorry. Looks good.


Documentation - Clarified REDIS_URI instruction

@shiva-sc there is no JIRA associate because it don't change the product, I only improved quickly the existing documentation. You review is just to see if you agree with my propose change.


Add LINQBridge to NuGet

It would be great to get this on NuGet as many of my projects' only remaining
/lib/ folder reference is this DLL.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 23 May 2011 at 4:53

Original comment by azizatif on 23 May 2011 at 9:32

Changed state: Accepted
Added labels: Component-Scripts, Type-Enhancement
Removed labels: Type-Defect

Original comment by azizatif on 23 May 2011 at 9:32

Changed title: Add LINQBridge to NuGet

any news on this?

Original comment by<EMAIL_ADDRESS>on 20 Mar 2012 at 11:21

Original comment by azizatif on 16 Apr 2012 at 9:23

Original comment by azizatif on 17 Apr 2012 at 8:12

Added labels: Milestone-Release1.3

This issue was closed by revision 8c4aad8f7699.

Original comment by azizatif on 18 Apr 2012 at 4:14

Changed state: Fixed


Helm installation of ingressgateway is inconsistent in the docs

Problem
If you try to install istio gateway with helm, as described in the docs, you will get an error saying that the referenced selector was not found
Steps to reproduce the issue

Install istio with istio gateway using helm as described in the docs

helm repo add istio https://istio-release.storage.googleapis.com/charts
helm repo update
kubectl create namespace istio-system
kubectl create namespace istio-ingress
kubectl label namespace istio-ingress istio-injection=enabled --overwrite
helm install istio-base istio/base -n istio-system
helm install istiod istio/istiod -n istio-system --wait
helm install istio-ingress istio/gateway -n istio-ingress --wait

Create a gateway:

apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: istiogateway
  namespace: my-namespace
spec:
  selector:
    istio: ingressgateway
  servers:
    - port:
        number: 80
        name: http
        protocol: HTTP
      hosts:
        - "*"

Then, if you launch istioctl analyze, you will get this error
Error [IST0101] (Gateway my-namespace/istiogateway) Referenced selector not found: "istio=ingressgateway"

Solution
Just replace istio-ingress with istio-ingressgateway
# ... install everything else
helm install istio-ingressgateway istio/gateway -n istio-ingress --wait

Request
Update the docs regarding the helm installation in order to be consistent.
2nd Request
The default istioctl installation installs everything in istio-system. Would it be better for consistency to also update the docs regarding the helm installation to do the same?
Version
1.13.3

istio: ingressgateway is just a label selector, not a magic constant. Just like you would expect every Kubernetes Service yaml to have the same labels, IMO it's the same here.
That being said you are not the first to say that so maybe we need to ramp up the docs explaining thid

I ran into the same problem.

This is likely not a documentation error, but an actual bug in istioctl analyze, see #38148.

still an issue


Correction for raw affiliation INRIA, Virtual Plants INRIA Team; UMR AGAP, INRA-SUPAGRO-CIRAD, CIRAD, Avenue Agropolis, TA-A108/03 34398 Montpellier Cedex 5, France

Correction needed for raw affiliation INRIA, Virtual Plants INRIA Team; UMR AGAP, INRA-SUPAGRO-CIRAD, CIRAD, Avenue Agropolis, TA-A108/03 34398 Montpellier Cedex 5, France
raw_affiliation_name: INRIA, Virtual Plants INRIA Team; UMR AGAP, INRA-SUPAGRO-CIRAD, CIRAD, Avenue Agropolis, TA-A108/03 34398 Montpellier Cedex 5, France
new_rors: 02kvxyf05;00txxwv34;05kpkpg04;02w4exq36
previous_rors: 02kvxyf05;00txxwv34;05kpkpg04
works_examples: W2119589580
contact: fae9f92f62eecfca853861147f237877:44eb588c936d9d3999b66c6e9568d9eedef3 @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-18. The new affiliations should be visible within the next 7 days.


Added lgas

Added lgas for Abia, Adamawa, Akwa-Ibom, Anambra states in Nigeria, West Africa

Added some states lgas in Nigeria

Please review this request


Code for attention score visualization

Hello, will the code for attention score visualization be made public? I didn't find it in the code, thanks

Great!!!, Thanks

It's done now, the visualisation code is working great! This issue can be closed.


[$500] LHN reflects wrong hint when user sents message after an attachment

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
step 1: open workspace from user A
step 2: add user B to the work space
step 3: send attachment from user A
step 4: send message from user B
step 5: observe LHN tab hint from user A
Expected Result: LHN tab hint shows the message
Actual Result: LHN tab hint shows attachment
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.65-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/943e8beb-0207-4148-9f4a-cfbcbe362757
https://github.com/Expensify/App/assets/43996225/1dc0d5cb-12a1-467f-88f5-220874c198e4
Expensify/Expensify Issue URL:
Issue reported by: @lidiyakelay
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693315853678109
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0163d7b176bbb6f038
Upwork Job ID:<PHONE_NUMBER>227767296
Last Price Increase: 2023-11-03

It is reproducible on lastest main

This would be fixed by this PR
I think we can hold this issue

@allroundexperts do you agree with this?

This would be fixed by this PR
I think we can hold this issue

Putting this on hold while we wait for https://github.com/Expensify/App/pull/26850/files

Ok! It looks like https://github.com/Expensify/App/pull/26850 has been deployed to prod. @kavimuru / @lidiyakelay can you check to see if this behavior persists?

bump @kavimuru / @lidiyakelay

bump @kavimuru / @lidiyakelay

@johncschuster SORRY!! for the late reply. This issue doesn't seem to be occurring anymore.
https://github.com/Expensify/App/assets/59802743/1904dce0-63ba-4197-bd80-eaceaf5a5754

@johncschuster but this seems to be still occurring on mobile app

bump @johncschuster

friendly bump @johncschuster

Thank you for the bump, @lidiyakelay! (And, sorry for missing them!)
Ok, it sounds like this behavior is still reproducible on mobile after #26850 was deployed. Is that about right? If so, I'll triage this out.

@johncschuster Can you please remove the HOLD part from the title

Not overdue. Still looking for proposals.
@johncschuster Please remove the HOLD

Oh sweet! Thanks for calling that out, @s77rt! I'll go fishing for proposals.

I tried to reproduce it on mobile and it works 🤔, if anyone can reproduce it could you please send a video? Maybe I didn't try correctly 🙏🏼

I don-t reproduce either

Did you test on mobile? Based on https://github.com/Expensify/App/issues/26997#issuecomment-1759672176 and https://github.com/Expensify/App/issues/26997#issuecomment-1771675495 the bug may only be reproducible on mobile

@samilabud and @ShogunFire, did you attempt to reproduce on a physical mobile device or in a dev environment? I'm not sure if this can only be reproduced on a physical device, but it'd be good to confirm.

Hi @johncschuster, confirming I have tested in the dev environment in the current version.

Issue not reproducible during KI retests. (First week)

Not overdue. Needs reproduction confirmation

Same ^

@s77rt, what are your thoughts on bumping this to Weekly while we wait?

Issue not reproducible during KI retests. (Second week)

@johncschuster I think we can just close this for now

Not overdue. We can close this since it does not seem reproducible

Issue not reproducible during KI retests. (Third week)

@johncschuster Let's close this

@johncschuster ^

Issue not reproducible during KI retests. (Fourth week). Are we good to close?

@johncschuster ^

To be closed ^

Issue not reproducible during KI retests. (Fifth week)

Looks like we can close this one. Thanks, everyone!


Adding CICD task to generate rustdocs both manually or as pipeline job

This PR added two jobs rebuild-all-rustdoc and republish-all-rustdoc to manually trigger a (re-)publishing rustdocs of all versions specified in RUSTDOCS_DEPLOY_REFS.
When manually triggered, additional variable REPUBLISH_ALL_RUSTDOCS need to be set to true. This pipeline shows that the two new jobs run successfully (I have the running condition set on PR # for testing).
This should be run at least once by ops staff after a merge to master.
Currently only rustdocs of master and monthly-2021-09+1 are deployed because running cargo +nightly doc with monthly-2021-08 and prior reports error on prost-derive crate.
@TriplEight @rcny Could you have a look at this PR? Thanks

@TriplEight I have gotten the latest master change and merge to this branch, and checked the rustdocs publication process works (see this workflow, particularly on the build-rustdoc and publish-rustdoc jobs).
If you have time this week, please review and see if the PR is good to merge. So I can then publish the Substrate rustdocs for monthly-2021-10 and monthly-2021-11-1 tags. Thanks.

@jimmychu0807 for what do we need this?

@jimmychu0807 for what do we need this?

@bkchr This PR makes:

Make the repo rustdocs support multiple versions. For Substrate there are multiple versions of rustdoc deployed and that specific index page linked to, is also built as part of this CI workflow.

Guys: I think we should not host anything but master here on the repo. Why? It's BIG in the git size to host them!! Instead we should host all versioned archives in https://github.com/substrate-developer-hub/rustdocs and only maintain the active master here.

https://github.com/paritytech/substrate/tree/gh-pages IMHO should be copied locally, and some git surgery done to completely prune it from the history before starting it once again with only master /target/doc copied over via CI, nothing else.
We can use https://docs.substrate.io/rustdocs/ to link to pages appropriately.

@NukeManDan to be fair
$ git rev-list --disk-usage --objects HEAD..gh-pages
277437609

Is not that much, but only compared to 7.5 GB.
I assume this PR was done in assumption to store the state of the documentation and host it straight away from the gh-pages branch. But for a fatter repo we might re-thing this approach.

I think it is better to host the rustdoc in Substrate repo. It should be less maintenance in the long-run, and it is good the rustdoc sits closing to the src code.

let me think about this, bot.


printf_buffered(), buffering for putchar_

printf from <stdio.h> provides buffering via some other internal functions.
It would be nice, if this repo offered a printf  variant, which operates on a user provided buffer to reduce the calls to putchar_.
Example:
void puts_(const char * data, int length)
{
    // handle data block wise, instead of char wise like in putchar_
}

char buffer[10];
printf_buffered(buffer, sizeof(buffer), "0123456789+2");  // <-- calls puts_(buffer, 10); puts(buffer+10, 2);
printf_buffered(buffer, sizeof(buffer), "abc");          // <-- calls puts_(buffer, 3);

Of course, one could also implement this kind of buffering inside putchar_, but at least if built without LTO, the performance would be quite a bit better for the printf_buffered.

This library's scope will not expand to also cover stream buffering. While it is certainly useful to have - if you want this...

You can achieve this using fctprintf() - simply use a function which applies such buffering.
Write a library depending on libprintf, which utilizes either fctprintf(), or sprintf_() into its buffer,  to implement printf_buffered().


Use C++11 override keyword

C++11 introduced the keyword-like override and final terms for virtual functions to specify when a function is overridden.
CATCH has quite a lot of virtual functions and can benefit to use this new feature.
Pros:

Safety. A method declared override with a different signature than a base class virtual method will not compile. This is a good protection against typos and when changing the method signature during refactoring.
Documentation. It is a good for the programmer and the reviewers to quickly distinguish between first declared virtual functions and overriden ones.

Cons:

Only for C++11. But for older C++98 compilers, #define override to nothing can be used to compile anyway.

See my commit:
https://github.com/prapin/Catch/commit/94a5b621c806be93a88a418ec1dfe7e6c9cc5221

override and final aren't keywords in C++11/14, they're context sensitive. You're allowed to have variables, parameters, types, functions named "override", so hiding them with the preprocessor is not likely to work.
It would, of course, be possible to add a CATCH_OVERRIDE macro, that expands to nothing in C++98/03 and to override in C++11/14.
Not that I think there'd be much gain. As a Catch user, you don't see the implementation of Catch so its internals are of no concern. It could help developers of Catch a bit, though.

I've been using the <PREFIX>_OVERRIDE approach in my day-job code-base for a couple of years (slightly different: it uses the pre-C++11 VC++ extension to do that same thing - but also suppresses the warning about it at the same time).
I might consider this, although as @rollbear says its not a huge gain - but it does risk breaking on compilers I don't test on.

FYI I've started doing this now. I've not rolled it out to all virtual overrides, but will increase coverage over time (and I've realised there's a lot more virtual than I'd thought!)

I tried compiling Catch under g++ with -Wsuggest-override, but got no warnings, so I am going to assume that overrides are currently all present and close this.
However, there is also a good point in that the contribution documentation could use some notes about C++98 compatibility and conditional compilation for various compilers for PRs.


repo_utils: Call git set remote-url

This will cause git repos on-disk to be updated to point at the correct
remote based on config.ceph_git_base_url
Signed-off-by: Zack Cerza<EMAIL_ADDRESS>

no tests ?


PreviewModelDialog

Hi!
I am having a problem with this library, I have about 500 skins, but I cannot fully display them all through the library, how much display is the library supporting? I'm using MemoryPluginVersion.inc version. Thanks!

Increase your "str" buffer size.


Expressions

JAVA-3879
Tracking PR.
This PR may be used to track anything that needs to be done prior to this expressions branch being merged into master.

We need to document the server version requirement for each methods in the new API. This requirement depends on the MQL used by the implementation of a method, and the implementation is allowed be changed in the future only in such ways that either don't increase the server version requirement, or increase it up to the least supported server version.

Rebased, minor no-conflict re-order and squash of one commit, and reworded commit messages to include JIRA and PR numbers.


[snet-liquidity-providers] strategy: snet-liquidity-providers

This strategy returns the liquidity pool balances of the voters for the SingularityNET project.

@ChaituVR
Fixed two comments and provided a description for the other. Please take a look.

@ChaituVR
Updated the blocknumber change.
Also in
#203
and
#204

@ChaituVR
We have custom staking contract and we decide the users' voting power by calling a get method in the contract.
How will snapshot.js will retrieve the past data based on the blocktag for this scenario?
Are you storing the data for the users anywhere in a DB?
reg:

ex: if I vote with 1 VP and in future, I may buy 100 VP and change the results)

if the user has already voted with 1VP, won't it be persisted in the DB and won't the user loses his ability to vote for the proposal thereafter?
Even if the user buys more tokens after voting, it should not impact the proposal because he has already cast his vote.

@ChaituVR
The checks have been merged. Could you get this merged?


Add unit tests for abstract Bundler::Fetcher::Base class

@homu r+

:pushpin: Commit 51ad73a has been approved by segiddins

:zap: Test exempted - status


Multiple monitors acts weirdly under Plasma 6 Wayland

Describe the bug
With a dual monitors setup, connecting to a Windows 10 client in fullscreen displays correctly on the monitor where the mouse is active and the second monitor flickers and shows the actual dual windows scaled to the single monitor. Hovering the mouse on the problematic monitor makes the issue alternate between the monitors.
Note that this issue doesn't happen under a Plasma 6 X11 session. Also doesn't happen under a Gnome Wayland session.
To Reproduce
Under a Plasma 6 Wayland session, connect to a Windows client with the multimon argument and more than 1 monitor.
Expected behavior
Expect to see the Windows desktop scaled correctly on all monitors like under a X11 session.
Screenshots
Below is a video since screenshots are not showing the issue.
Application details

FreeRDP version 3.4.0 (n/a)
xfreerdp3 /d:xx.xx /u:xxxxx /p:xxxx /cert:ignore /v:<IP_ADDRESS> /audio-mode:2 -clipboard /multimon /prevent-session-lock
Output of xfreerdp /buildconfig

Build configuration: BUILD_TESTING=OFF WINPR_HAVE_AIO_H=1 WINPR_HAVE_EXECINFO_BACKTRACE=1 WINPR_HAVE_EXECINFO_BACKTRACE_SYMBOLS=1 WINPR_HAVE_EXECINFO_BACKTRACE_SYMBOLS_FD=1 WINPR_HAVE_EXECINFO_HEADER=1 WINPR_HAVE_FCNTL_H=1 WINPR_HAVE_GETLOGIN_R=1 WINPR_HAVE_GETPWUID_R=1 WINPR_HAVE_INTTYPES_H=1 WINPR_HAVE_POLL_H=1 WINPR_HAVE_PTHREAD_MUTEX_TIMEDLOCK_LIB=1 WINPR_HAVE_PTHREAD_MUTEX_TIMEDLOCK_LIBS= WINPR_HAVE_PTHREAD_MUTEX_TIMEDLOCK_SYMBOL=1 WINPR_HAVE_STDBOOL_H=1 WINPR_HAVE_STDINT_H=1 WINPR_HAVE_STRNDUP=1 WINPR_HAVE_SYSLOG_H=1 WINPR_HAVE_SYS_EVENTFD_H=1 WINPR_HAVE_SYS_FILIO_H= WINPR_HAVE_SYS_SELECT_H=1 WINPR_HAVE_SYS_SOCKIO_H= WINPR_HAVE_SYS_TIMERFD_H=1 WINPR_HAVE_TM_GMTOFF=1 WINPR_HAVE_UNISTD_H=1 WINPR_HAVE_UNWIND_H=1 WITH_AAD=ON WITH_ABSOLUTE_PLUGIN_LOAD_PATHS=ON WITH_ADD_PLUGIN_TO_RPATH=OFF WITH_ALSA=ON WITH_BINARY_VERSIONING=ON WITH_CAIRO=OFF WITH_CCACHE=ON WITH_CHANNELS=ON WITH_CLANG_FORMAT=ON WITH_CLIENT=ON WITH_CLIENT_AVAILABLE=1 WITH_CLIENT_CHANNELS=ON WITH_CLIENT_CHANNELS_AVAILABLE=1 WITH_CLIENT_COMMON=ON WITH_CLIENT_INTERFACE=OFF WITH_CLIENT_SDL=ON WITH_CLIENT_SDL_AVAILABLE=1 WITH_CUPS=ON WITH_DEBUG_ALL=OFF WITH_DEBUG_CAPABILITIES=OFF WITH_DEBUG_CERTIFICATE=OFF WITH_DEBUG_CHANNELS=OFF WITH_DEBUG_CLIPRDR=OFF WITH_DEBUG_CODECS=OFF WITH_DEBUG_DVC=OFF WITH_DEBUG_EVENTS=OFF WITH_DEBUG_KBD=OFF WITH_DEBUG_LICENSE=OFF WITH_DEBUG_MUTEX=OFF WITH_DEBUG_NEGO=OFF WITH_DEBUG_NLA=OFF WITH_DEBUG_NTLM=OFF WITH_DEBUG_RAIL=OFF WITH_DEBUG_RDP=OFF WITH_DEBUG_RDPDR=OFF WITH_DEBUG_RDPEI=OFF WITH_DEBUG_RDPGFX=OFF WITH_DEBUG_REDIR=OFF WITH_DEBUG_RFX=OFF WITH_DEBUG_RINGBUFFER=OFF WITH_DEBUG_SCARD=OFF WITH_DEBUG_SCHANNEL=OFF WITH_DEBUG_SDL_EVENTS=OFF WITH_DEBUG_SDL_KBD_EVENTS=OFF WITH_DEBUG_SND=OFF WITH_DEBUG_SVC=OFF WITH_DEBUG_SYMBOLS=OFF WITH_DEBUG_THREADS=OFF WITH_DEBUG_TIMEZONE=OFF WITH_DEBUG_TRANSPORT=OFF WITH_DEBUG_TSG=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_TSMF_AVAILABLE=0 WITH_DEBUG_URBDRC=OFF WITH_DEBUG_WND=OFF WITH_DEBUG_X11=OFF WITH_DEBUG_X11_LOCAL_MOVESIZE=OFF WITH_DEBUG_XV=OFF WITH_DSP_EXPERIMENTAL=OFF WITH_DSP_FFMPEG=ON WITH_DSP_FFMPEG_AVAILABLE=1 WITH_EVENTFD_READ_WRITE=1 WITH_FAAC=OFF WITH_FAAD2=OFF WITH_FFMPEG=ON WITH_FREERDP_DEPRECATED=OFF WITH_FREERDP_DEPRECATED_COMMANDLINE=OFF WITH_FUSE=ON WITH_GFX_H264=ON WITH_GPROF=OFF WITH_GSM=OFF WITH_ICU=ON WITH_INTERNAL_MD4=OFF WITH_INTERNAL_MD5=OFF WITH_INTERNAL_RC4=OFF WITH_IPP=OFF WITH_JPEG=ON WITH_KRB5=ON WITH_KRB5_NO_NTLM_FALLBACK=OFF WITH_LAME=OFF WITH_LIBRARY_VERSIONING=ON WITH_LIBRESSL=OFF WITH_LODEPNG=OFF WITH_MACAUDIO=OFF WITH_MACAUDIO_AVAILABLE=0 WITH_MANPAGES=ON WITH_MBEDTLS=OFF WITH_NATIVE_SSPI=OFF WITH_NEON=OFF WITH_OPENCL=OFF WITH_OPENH264=OFF WITH_OPENSC_PKCS11_LINKED=OFF WITH_OPENSSL=ON WITH_OPUS=OFF WITH_OSS=ON WITH_PCSC=ON WITH_PKCS11=ON WITH_PLATFORM_SERVER=ON WITH_POLL=ON WITH_PROFILER=OFF WITH_PROXY=ON WITH_PROXY_APP=ON WITH_PROXY_EMULATE_SMARTCARD=OFF WITH_PROXY_MODULES=ON WITH_PULSE=ON WITH_RDTK=ON WITH_SAMPLE=ON WITH_SANITIZE_ADDRESS=OFF WITH_SANITIZE_ADDRESS_AVAILABLE=1 WITH_SANITIZE_MEMORY=OFF WITH_SANITIZE_MEMORY_AVAILABLE=1 WITH_SANITIZE_THREAD=OFF WITH_SANITIZE_THREAD_AVAILABLE=1 WITH_SDL_IMAGE_DIALOGS=OFF WITH_SDL_LINK_SHARED=ON WITH_SERVER=ON WITH_SERVER_CHANNELS=ON WITH_SERVER_INTERFACE=ON WITH_SHADOW=ON WITH_SMARTCARD_EMULATE=ON WITH_SMARTCARD_INSPECT=OFF WITH_SMARTCARD_PCSC=ON WITH_SOXR=OFF WITH_SSE2=OFF WITH_SWSCALE=ON WITH_SYSTEMD=ON WITH_THIRD_PARTY=OFF WITH_UNICODE_BUILTIN=OFF WITH_URIPARSER=OFF WITH_VAAPI=OFF WITH_VAAPI_AVAILABLE=1 WITH_VALGRIND_MEMCHECK=OFF WITH_VALGRIND_MEMCHECK_AVAILABLE=1 WITH_VERBOSE_WINPR_ASSERT=ON WITH_VIDEO_FFMPEG=ON WITH_VIDEO_FFMPEG_AVAILABLE=1 WITH_WAYLAND=ON WITH_WEBVIEW=ON WITH_WEBVIEW_QT=OFF WITH_WINPR_DEPRECATED=OFF WITH_WINPR_TOOLS=ON WITH_WIN_CONSOLE=ON WITH_X11=ON WITH_XCURSOR=ON WITH_XEXT=ON WITH_XFIXES=ON WITH_XI=ON WITH_XINERAMA=ON WITH_XRANDR=ON WITH_XRENDER=ON WITH_XV=ON
Build type:          None
CFLAGS:              -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -g -ffile-prefix-map=/build/freerdp/src=/usr/src/debug/freerdp -flto=auto -Wall -Wpedantic -Wno-padded -Wno-cast-align -Wno-declaration-after-statement -fPIC -Wall -fvisibility=hidden -Wimplicit-function-declaration -Wredundant-decls -g -fno-omit-frame-pointer
Compiler:            GNU, 13.2.1
Target architecture: x64

Windows 10

Environment (please complete the following information):

OS: Linux
Version/Distribution: Arch Linux
Architecture: amd64

https://github.com/FreeRDP/FreeRDP/assets/12200405/9255f45e-fceb-4d9c-b5b3-a684cea3e91d
PS: Found a reddit with kind of the same issue : https://www.reddit.com/r/Fedora/comments/16ol9ln/rdp_multiple_monitors_on_wayland/

well, sounds like a KDE/plasma issue, keeping it open as reference for now.

Does this also happen when using sdl-freerdp ... instead of xfreerdp ...? xfreerdp isn't quite suited for running on Wayland.

@danir-de still using xfreerdp quite heavily on wayland (XWayland) and don´t see a problem ;)
even draws more smooth than on original X11 settings.
but only regularily use dual monitor setups. (there have been quite a number of issues with kde and xfreerp/multimonitor a few years back, but they solved it in kwin as far as I remember)
maybe the same issue again with XWayland ?

Same issue for me.
Arch linux up to date.
KDE plasma 6.1.5
Session: wayland
The problem exist : xfreerdp and xfreerdp3

I cannot confirm at the moment. I had to switch back to windows for working now since i cannot get freerdp to connect to my work-pc and i am currently spending my freerdp time-budget for finding the cause for this problem and why sdl-freerdp with wayland worked exactly once for me and not once since then.

The problem still exists.  (Arch Linux up to date)

unless someone can point out why this is our bug I consider this a plasma bug as the same works well on other window managers / desktop environments.
so please stop  the me too things (does not really help) and answer that question ;)