Double redirect for WordPress subscription from gmx.net

New Issue Checklist (tick off like this: [x])

[x] I checked existing issues (open and closed) for possible duplicates
[x] I can reproduce the problem on the latest stable version (not nightly!)
[x] The issue is not about adding entries to the default blacklist

What is your browser?

[x] Firefox
[ ] Chrome

What is your operating system?

[ ] Linux
[ ] Mac
[x] Windows

Description (please include examples/screenshots where applicable)
I recently wanted to subscribe to a WordPress blog and received an email with the following confirmation link (note that I changed my keys and email address for privacy, but tried to keep the URL patterns intact):
https://deref-gmx.net/mail/client/RV25X0rqGXk/dereferrer/?redirectUrl=https%3A%2F%2Fpublic-api.wordpress.com%2Fbar%2F%3Fstat%3Dgroovemails-events%26bin%3Dwpcom_email_click%26redirect_to%3Dhttps%253A%252F%252Fsubscribe.wordpress.com%252F%253Fkey%253D0fb618e5ec04dd36ee50f42cc85f7f10%2526email%253Dmy.email%252540example.com%2526locale%253Den-gb%2526activate%253De42d67dde1422d2e8daadf2410888f5c%26sr%3D1%26signature%3D607ead5199c17060251242bfc204cff5%26user%3D0%26_e%3Da20suJIlGIgilTlOlZYIWcpjGIy32mNSbic1zFZ2IdQOmWF1CYGOibijjhyJNTXcgpmcCbZxIJWyUyyii6GIGyEJ6VfV1OI9NcflBu6b1nIIZGaGyYY3jIcbwIcb9ni5GIbcDbjQI9WiIi9lmw51IIbbBwbRt4lQyxiWFNejjhVlW1WZNcYhw2EsmdTIJNViW3II3In14wiSIi1lNTiWvMh6TAIINSice9afdIHYxhisvwkJIv9TZ3s29399iaIC6Cda3jTDztMbzUxMynIplw5eiV2CmbjIQwUbfFWbnvd16nWIX2NUvVtImddnD94iZLXyFE2jNhIwy2ROtp11MxFCiMNYJaJS9nOOU01C9YkblyVdFain6bIXIvtiiFjSgLR9WbNwINnJZifl9MvtwvxlfVi0aXWCcMMeOHe21YMLsicDLMysjXNNGl1cGOI6ZQG0sl5pxOtVVuFy5C9ZJpiYAzWiIsvGRlWycZidTiRREisXQJWMAMb21UCGb2Rticw6Yb6EiCcZFmFitOYiLmAmr6bWGsnQIJNm5bJLolbW%26_z%3Dz
This got converted by Skip Redirect to this:
https://public-api.wordpress.com/bar/?stat=groovemails-events&bin=wpcom_email_click&redirect_to=https://subscribe.wordpress.com/?key=0fb618e5ec04dd36ee50f42cc85f7f10&email=my.email%40example.com&locale=en-gb&activate=e42d67dde1422d2e8daadf2410888f5c&sr=1&signature=607ead5199c17060251242bfc204cff5&user=0&_e=a20suJIlGIgilTlOlZYIWcpjGIy32mNSbic1zFZ2IdQOmWF1CYGOibijjhyJNTXcgpmcCbZxIJWyUyyii6GIGyEJ6VfV1OI9NcflBu6b1nIIZGaGyYY3jIcbwIcb9ni5GIbcDbjQI9WiIi9lmw51IIbbBwbRt4lQyxiWFNejjhVlW1WZNcYhw2EsmdTIJNViW3II3In14wiSIi1lNTiWvMh6TAIINSice9afdIHYxhisvwkJIv9TZ3s29399iaIC6Cda3jTDztMbzUxMynIplw5eiV2CmbjIQwUbfFWbnvd16nWIX2NUvVtImddnD94iZLXyFE2jNhIwy2ROtp11MxFCiMNYJaJS9nOOU01C9YkblyVdFain6bIXIvtiiFjSgLR9WbNwINnJZifl9MvtwvxlfVi0aXWCcMMeOHe21YMLsicDLMysjXNNGl1cGOI6ZQG0sl5pxOtVVuFy5C9ZJpiYAzWiIsvGRlWycZidTiRREisXQJWMAMb21UCGb2Rticw6Yb6EiCcZFmFitOYiLmAmr6bWGsnQIJNm5bJLolbW&_z=z
...which led to a site saying "Sorry, but the provided signature isn't valid."
After disabling Skip Redirect, the correct link that ended up in my browser window looked as follows:
https://public-api.wordpress.com/bar/?stat=groovemails-events&bin=wpcom_email_click&redirect_to=https%3A%2F%2Fsubscribe.wordpress.com%2F%3Fkey%3D0fb618e5ec04dd36ee50f42cc85f7f10%26email%3Dmy.email%2540example.com%26locale%3Den-gb%26activate%3De42d67dde1422d2e8daadf2410888f5c&sr=1&signature=607ead5199c17060251242bfc204cff5&user=0&_e=a20suJIlGIgilTlOlZYIWcpjGIy32mNSbic1zFZ2IdQOmWF1CYGOibijjhyJNTXcgpmcCbZxIJWyUyyii6GIGyEJ6VfV1OI9NcflBu6b1nIIZGaGyYY3jIcbwIcb9ni5GIbcDbjQI9WiIi9lmw51IIbbBwbRt4lQyxiWFNejjhVlW1WZNcYhw2EsmdTIJNViW3II3In14wiSIi1lNTiWvMh6TAIINSice9afdIHYxhisvwkJIv9TZ3s29399iaIC6Cda3jTDztMbzUxMynIplw5eiV2CmbjIQwUbfFWbnvd16nWIX2NUvVtImddnD94iZLXyFE2jNhIwy2ROtp11MxFCiMNYJaJS9nOOU01C9YkblyVdFain6bIXIvtiiFjSgLR9WbNwINnJZifl9MvtwvxlfVi0aXWCcMMeOHe21YMLsicDLMysjXNNGl1cGOI6ZQG0sl5pxOtVVuFy5C9ZJpiYAzWiIsvGRlWycZidTiRREisXQJWMAMb21UCGb2Rticw6Yb6EiCcZFmFitOYiLmAmr6bWGsnQIJNm5bJLolbW&_z=z
Looks like Skip Redirect decoded too many characters of the original URL, but I'm not sure this can be easily avoided, unless there is a universal "stop decoding here" marker (in this case I could imagine it being the first decoded https://).

This looks like an actual problem, but I don't know when I will have time to look into it. You can try to blacklist public-api.wordpress.com

Thanks for the update. Meanwhile, I have come across another example:
Original URL:
https://deref-gmx.net/mail/client/dJcqFOKsYML/dereferrer/?redirectUrl=http%3A%2F%2Flink.indiegogo.com%2Fclick%2Fe9edebf7b68c712005fefc17%2Fw01Z1aNBrUa20bRXRYGTjmZ5oMYTVVG9OvcdJGQnUmbcdhjZlGcd2TTZ55dYHpVWeRgh30MaUQodVZLYzMTeNFhLXThD1VpV6BNlzSmRMl1qNrcZTXT1ZMWMMV03Rl3MTWcO0O1ZjhYvFbl2YbbLRfjuclRR3lzgzV9Wodhj2bwvURTm1TpQb3YNy1wl1W93JbbaL3HDjEvZaQFZTL3ZVGvWkldY35VW50SFhmZeWWxRZ5WMQWnSbbF3GM0WdTkHNR2phzhNH5%2Fb0855176af4c4b3Bf4330f73383e34d8b
Should redirect to:
http://link.indiegogo.com/click/e9edebf7b68c712005fefc17/w01Z1aNBrUa20bRXRYGTjmZ5oMYTVVG9OvcdJGQnUmbcdhjZlGcd2TTZ55dYHpVWeRgh30MaUQodVZLYzMTeNFhLXThD1VpV6BNlzSmRMl1qNrcZTXT1ZMWMMV03Rl3MTWcO0O1ZjhYvFbl2YbbLRfjuclRR3lzgzV9Wodhj2bwvURTm1TpQb3YNy1wl1W93JbbaL3HDjEvZaQFZTL3ZVGvWkldY35VW50SFhmZeWWxRZ5WMQWnSbbF3GM0WdTkHNR2phzhNH5/b0855176af4c4b3Bf4330f73383e34d8b
...but doesn't (I don't know the actual destination URL as the server re-directed me to a generic error page).

In other news, I tried to add the first example to the tests but I think I failed to use your function correctly as the result doesn't match what I had reported.

The GMX redirect page is definitely skipped. It is one of the main reasons I started working on this extension...

I don't think I will find the time to look into the double decode problem anytime soon, so I'll just close. If someone else wants to pick it up, please re-open. Regarding the second example, I get redirected to what you posted, but then indiegogo redirects to its homepage. I got the URL you get initially redirected to by using Chrome's DevTools (ctrl-shift-i).


Allow to pass http2.ServerOptions

Fix #201

let's hold this, perhaps we can solve this issue with https://github.com/restatedev/sdk-typescript/issues/220 instead, without changing the listen() signature

Superseded by #221


Usage examples

See https://github.com/brain-score/language/tree/mschrimpf/examples/examples for rendered.

[x] Scoring model on benchmark
[x] Score each layer of a model on a benchmark
[x] Comparing two models
[x] Comparing two humans

Addressed the first point.
For the second whichever PR is merged last should update the naming.


feat: create Presentations using raw Credentials

Description of change
Please write a summary of your changes and why you made them.
Links to any relevant issues
Be sure to reference any related issues by adding fixes issue #.
How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Definition of Done checklist
Add an x to the boxes that are relevant to your changes.

[ ] I have followed the contribution guidelines for this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I have successfully tested this change in a docker environment

 feat: create Presentations using raw Credentials


link problems to raw terminal output

VSCode Version: 1.18.0
OS Version: Ubuntu 16.04

VSCode's problem matcher is really limited right now (especially for multi-line messages). One thing that would improve the situation quite a bit would be to allow moving between the output and the reporter, i.e. to jump to the line in the raw output where the problem matched.
The cherry on top would be to allow for patterns that don't register anything but would add hyperlinks to the console output (to file/lines). We could this way easily browse backtraces in the raw output, without necessarily changing the reporting system.

This dups https://github.com/Microsoft/vscode/issues/21928 which is blocked by https://github.com/Microsoft/vscode/issues/23263

#21928 is really the "cherry on top". The gist of this feature request was to be able to jump to the specific output line in the terminal, from the problem (in the problem view) that was matched there.


Semi-outdated handling of API requests

Your theme does not automatically append the CRSF token to API requests. Both of the default FOSSBilling themes do as does our API wrapper. It's very likely things built for FOSSBilling will assume such behavior and then not work correctly in Tide which is something I personally have run into.
I'd suggest replacing the old jQuery code that makes API requests with code that utilizes the wrapper as the wrapper will add the token automatically and it will also create a spinner for long running requests which is something Tide largely lacks

Thank you, will take care of it.

any update?


Min Max date in $mdpDatePicker service

Not able to  set min max date...It always takes the current date!

@jfreak can you please provide a codepen of the issue?

http://codepen.io/jfreak/pen/jqBdyR

I think you are confusing the service and the directive..
If you want to use the service, here's the correct syntax
$mdpDatePicker($scope.currentDate, {
    minDate: minDate,
    maxDate: maxDate,
    dateFilter: dateFilter,
    targetEvent: ev
}).then(function(selectedDate) {
    $scope.currentDate = selectedDate;
});;

minDate and maxDate if set, can be either a iso date string or a date object
dateFilter if set, should be a function

Thanks, It worked..


ARROW-11465: [C++] Parquet file writer snapshot API and proper ColumnChunk.file_path utilization

8130

 Quality gate: Failed
20 Issues

 1 Vulnerabilities
 19 Code issues

Details

 Quality gate: Failed
8 Issues

 1 Vulnerabilities
 7 Code issues

Details

 Quality gate: Failed
 Everything looks good
Details


Move mkdocs action/workflow into docs group

Feature Request / Improvement
I was trying to set up mkdocs on this repo and found the existing setup a little unintuitive -- in most cases I use mkdocs as a docs extra in whatever dependency manager I am using (PDM or Poetry).
I can work on adding this as an extra so there isnt some extra hidden workflow in requirements.txt inside of an mkdocs folder

@jayceslesar yes, please! I just ran into this problem recently


Remove any cookies/state after resetting authentication of ExchangeServiceBase

This prevents an old authentication from being reused by proxy firewalls like TMG.

Hi @MikeN123, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, AZPRBOT;

looks good thanks for the contribution.


Implement Error for RustStringRef

With the latest versions of Swift, using Result<_, String> causes two errors:

'RustString' is not convertible to 'any Error'
Thrown expression type 'RustString' does not conform to 'Error

The solution to both errors is for RustStringRef to declare conformance to the Error protocol.
See: Swift Documentation - Error

Just needs an integration test.
Potential approach
Bridge a function here that returns -> Result<(), String>, somewhere in here https://github.com/chinedufn/swift-bridge/blob/de059024732fa2f8135a9fe1232b727d96794af6/crates/swift-integration-tests/src/result.rs#L3-L81
Then add a test case that calls that function somewhere inside here https://github.com/chinedufn/swift-bridge/blob/de059024732fa2f8135a9fe1232b727d96794af6/SwiftRustIntegrationTestRunner/SwiftRustIntegrationTestRunnerTests/ResultTests.swift#L10
On the test case document that (I'm paraphrasing) around the time of Swift x.y returning -> Result<(), String> started giving errors like Thrown expression type 'RustString' does not conform to 'Error'. And that we solved that by implementing Swift's Error protocol for RustStringRef. And that confirms the the Error protocol is implemented.
Then confirm that if you comment out the extension RustStringRef: Error {} line then tests fail.

@jnbooth Do you still work on this?

Implemented in https://github.com/chinedufn/swift-bridge/pull/296


Alternative quick setup menu

🎉 New feature
Summary
Closes #1252
Alternative to #1536
Test it
Run ign gazebo -v 4
https://user-images.githubusercontent.com/1587438/181843751-fd9a421b-c0e7-42fb-8a2d-edcc79b7faf5.mp4
Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

I rebased this PR on top of #1536, so now it includes the worlds added there:

I'm still reviewing


Various exceptions when entering multi-root workspace

Steps to Reproduce:

have a folder "foo" with 2 children folder "a" and "b"
open folder "foo"
drag and drop the folders "a" and "b" from outside into the explorer
confirm to add to the workspace

Watch the dev console spam:
[Extension Host] debugger listening on port 5870
/Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/electron-browser/extensionHost.js:145 [Extension Host] debugger inspector at chrome-devtools://devtools/bundled/inspector.html?experiments=true&v8only=true&ws=<IP_ADDRESS>:5870/06c72ab8-efab-43a2-b588-aa4d6756aff0
log.js:200   ERR Cannot read property 'activateByEvent' of null: TypeError: Cannot read property 'activateByEvent' of null
    at ExtensionService._activateByEvent (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/electron-browser/extensionService.js:364:54)
    at ExtensionService.activateByEvent (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/electron-browser/extensionService.js:354:29)
    at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/mode/common/workbenchModeService.js:125:41
    at Emitter.fire (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/event.js:103:38)
    at WorkbenchModeServiceImpl.ModeServiceImpl._getOrCreateMode (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/editor/common/services/modeServiceImpl.js:118:39)
    at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/editor/common/services/modeServiceImpl.js:111:30
    at Promise_ctor.CompletePromise_then [as then] (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.js:1581:49)
    at WorkbenchModeServiceImpl.ModeServiceImpl.getOrCreateModeByFilenameOrFirstLine (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/editor/common/services/modeServiceImpl.js:108:36)
    at TextFileEditorModel.getOrCreateMode (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/textfile/common/textFileEditorModel.js:409:32)
    at TextFileEditorModel.BaseTextEditorModel.createTextEditorModel (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/common/editor/textEditorModel.js:73:29)
    at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/textfile/common/textFileEditorModel.js:369:30
    at CompletePromise_ctor.CompletePromise_then [as then] (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.js:1581:49)
    at TextFileEditorModel.doCreateTextModel (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/textfile/common/textFileEditorModel.js:367:75)
    at TextFileEditorModel.doLoadWithContent (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/textfile/common/textFileEditorModel.js:346:25)
    at TextFileEditorModel.loadWithContent (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/textfile/common/textFileEditorModel.js:292:25)
    at TextFileEditorModel.handleLoadSuccess (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/textfile/common/textFileEditorModel.js:270:25)
    at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/textfile/common/textFileEditorModel.js:265:57
    at Object.notifySuccess [as _notify] (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.js:1185:59)
    at Object.enter (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.js:867:30)
    at Promise_ctor._run (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.js:1083:29)
    at Promise_ctor._completed (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.js:1051:18)
    at IconvLiteDecoderStream.<anonymous> (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/editor/common/model/textModel.js:46:21)
    at emitNone (events.js:111:20)
    at IconvLiteDecoderStream.emit (events.js:208:7)
    at endReadableNT (_stream_readable.js:1056:12)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)
extensionHost.js:230 [Extension Host] Provided debugging port 5870 is not free, using 5871 instead.
(anonymous) @ extensionHost.js:230
_tickCallback @ internal/process/next_tick.js:188
Promise resolved (async)
(anonymous) @ extensionHost.js:224
Promise_ctor @ winjs.base.js:1656
ExtensionHostProcessWorker._tryFindDebugPort @ extensionHost.js:223
ExtensionHostProcessWorker.start @ extensionHost.js:93
ExtensionHostProcessManager @ extensionService.js:128
create @ types.js:164
InstantiationService._createInstance @ instantiationService.js:106
InstantiationService.createInstance @ instantiationService.js:67
ExtensionService._startExtensionHostProcess @ extensionService.js:320
ExtensionService.startExtensionHost @ extensionService.js:300
startExtensionHost @ workspaceEditingService.js:152
notifySuccess @ winjs.base.js:1185
enter @ winjs.base.js:867
_run @ winjs.base.js:1083
_completed @ winjs.base.js:1051
argDone @ winjs.base.js:1828
Promise.then.errors.(anonymous function) @ winjs.base.js:1853
notifySuccess @ winjs.base.js:1185
enter @ winjs.base.js:867
_run @ winjs.base.js:1083
_completed @ winjs.base.js:1051
CompletePromise_then @ winjs.base.js:1581
enter @ winjs.base.js:762
_run @ winjs.base.js:1083
_setCompleteValue @ winjs.base.js:1067
notifySuccess @ winjs.base.js:1185
enter @ winjs.base.js:916
_run @ winjs.base.js:1083
_error @ winjs.base.js:1056
(anonymous) @ async.js:602
(anonymous) @ extfs.js:37
(anonymous) @ /Users/bpasero/Development/Microsoft/monaco/node_modules/graceful-fs/polyfills.js:284
(anonymous) @ original-fs.js:152
extensionHost.js:236 [Extension Host] debugger listening on port 5871
extensionHost.js:145 [Extension Host] debugger inspector at chrome-devtools://devtools/bundled/inspector.html?experiments=true&v8only=true&ws=<IP_ADDRESS>:5871/b6bf586c-d30a-4e62-8253-5b317d05f5b9
log.js:200   ERR Reviver for 'mainThreadWebview' already registered: Error: Reviver for 'mainThreadWebview' already registered
    at WebviewEditorService.registerReviver (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/parts/webview/electron-browser/webviewEditorService.js:105:23)
    at MainThreadWebviews (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/api/electron-browser/mainThreadWebview.js:61:29)
    at create (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/types.js:164:14)
    at InstantiationService._createInstance (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/platform/instantiation/common/instantiationService.js:106:35)
    at InstantiationService.createInstance (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/platform/instantiation/common/instantiationService.js:67:29)
    at ExtensionHostProcessManager._createExtensionHostCustomers (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/electron-browser/extensionService.js:180:59)
    at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/electron-browser/extensionService.js:129:39
    at Object.notifySuccess [as _notify] (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.js:1185:59)
    at Object.enter (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.js:867:30)
    at _Base.Class.derive._creator._run (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.js:1083:29)
    at _Base.Class.derive._creator._completed (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.js:1051:18)
    at Object.notifySuccess [as _notify] (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.js:1185:59)
    at Object.enter (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.js:867:30)
    at Promise_ctor._run (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.js:1083:29)
    at Promise_ctor._completed (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.js:1051:18)
    at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/electron-browser/extensionHost.js:279:29
    at Emitter.fire (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/event.js:103:38)
    at Socket.<anonymous> (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/parts/ipc/node/ipc.net.js:90:46)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at addChunk (_stream_readable.js:263:12)
    at readableAddChunk (_stream_readable.js:250:11)
    at Socket.Readable.push (_stream_readable.js:208:10)
    at Pipe.onread (net.js:594:20)
errors.js:42 WARNING: Promise with no error callback:36
errors.js:43 {exception: Error: Reviver for 'mainThreadWebview' already registered
    at WebviewEditorService.registerRevive…, error: null, promise: _…e.C…s.d…e._creator, handler: undefined, id: 36, …}
errors.js:45 Error: Reviver for 'mainThreadWebview' already registered
    at WebviewEditorService.registerReviver (webviewEditorService.js:105)
    at MainThreadWebviews (mainThreadWebview.js:61)
    at create (types.js:164)
    at InstantiationService._createInstance (instantiationService.js:106)
    at InstantiationService.createInstance (instantiationService.js:67)
    at ExtensionHostProcessManager._createExtensionHostCustomers (extensionService.js:180)
    at extensionService.js:129
    at Object.notifySuccess [as _notify] (winjs.base.js:1185)
    at Object.enter (winjs.base.js:867)
    at _Base.Class.derive._creator._run (winjs.base.js:1083)
    at _Base.Class.derive._creator._completed (winjs.base.js:1051)
    at Object.notifySuccess [as _notify] (winjs.base.js:1185)
    at Object.enter (winjs.base.js:867)
    at Promise_ctor._run (winjs.base.js:1083)
    at Promise_ctor._completed (winjs.base.js:1051)
    at extensionHost.js:279
    at Emitter.fire (event.js:103)
    at Socket.<anonymous> (ipc.net.js:90)
    at emitOne (events.js:116)
    at Socket.emit (events.js:211)
    at addChunk (_stream_readable.js:263)
    at readableAddChunk (_stream_readable.js:250)
    at Socket.Readable.push (_stream_readable.js:208)
    at Pipe.onread (net.js:594)
log.js:200   ERR Unknown actor mMainThreadTextEditors: Error: Unknown actor mMainThreadTextEditors
    at RPCProtocol._doInvokeHandler (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/node/rpcProtocol.js:138:23)
    at RPCProtocol._invokeHandler (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/node/rpcProtocol.js:130:54)
    at RPCProtocol._receiveRequest (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/node/rpcProtocol.js:88:50)
    at RPCProtocol._receiveOneMessage (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/node/rpcProtocol.js:71:26)
    at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/node/rpcProtocol.js:17:92
    at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/node/rpcProtocol.js:175:21
    at Emitter.fire (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/event.js:103:38)
    at Socket.<anonymous> (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/parts/ipc/node/ipc.net.js:90:46)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at addChunk (_stream_readable.js:263:12)
    at readableAddChunk (_stream_readable.js:250:11)
    at Socket.Readable.push (_stream_readable.js:208:10)
    at Pipe.onread (net.js:594:20)

The first exception reproduces in stable. The second one (mainThreadWebview @mjbvz) seems new.

I believe the webview one was addressed by f2a2f39

Sort of confirmed over here, too.  I think I recreated it even more easily though. I just have a single file.
If I save a workspace, then I trade my REPL functionality for the above warning.
If I remove the workspace file, then I can run my code again 😃


Update home page content

[ ] update html meta tags - description, title
[ ] check that the stylesheet is linked properly in the HTML file
[x] add website title to nav and footer
[ ] determine hero section content - bg image, headline, and subtitle
[ ] determine page content - maybe some kind of preview or image directing the user to each section (Spotify and Ticketmaster)? May be redundant but would keep the page from looking too sparse if we can't think of anything else

I added a logo as the site title and updated our footer


Replace slot-based virtual memory allocation with bitmap allocator

The current method of mapping a virtual memory address to a physical address involves mapping individual pages using slots, with a guard page between each virtual address. It is not possible to create a virtual memory mapping that spans multiple pages.
This new virtual address allocator allows dynamic allocation of virtual addresses that can span multiple 4K or 2M pages using a bitmap to keep track of virtual pages that are in use.
This simplifies the development of future capabilities and in particular simplifies parsing of variable size structures such as those used in the files of a firmware file system.

Thanks a lot, this is a great addition and simplification of internal interfaces.


Compatibility with @monaco-editor/react

Trying this out with @monaco-editor/react and getting this error:

import React, { useCallback, useEffect, useRef } from "react";

import { AutoTypings, LocalStorageCache } from "monaco-editor-auto-typings";
import Editor, { useMonaco } from "@monaco-editor/react";

const defaultCode = `import React from "react";

function App() {
  return (

Hello World!

  );
}

`;

export default function App() {
  const monaco = useMonaco();
  const editorRef = useRef(null);

  const onMount = useCallback(
    (editor, monaco) => {
      // here is the editor instance
      // you can store it in `useRef` for further usage
      editorRef.current = editor;
    },
    [editorRef]
  );

  const onChange = useCallback((value, event) => {
    //
  }, []);

  useEffect(() => {
    if (monaco) {
      monaco.languages.typescript.typescriptDefaults.setCompilerOptions({
        jsx: monaco.languages.typescript.JsxEmit.React,
        moduleResolution:
          monaco.languages.typescript.ModuleResolutionKind.NodeJs,
      });

      monaco.languages.typescript.typescriptDefaults.setDiagnosticsOptions({
        noSemanticValidation: false,
        noSyntaxValidation: false,
      });

      if (editorRef.current) {
        AutoTypings.create(editorRef.current as any, {
          sourceCache: new LocalStorageCache(),
          onlySpecifiedPackages: true,
          preloadPackages: true,
        });
      }
    }
  }, [monaco]);

  return (
    <Editor
      height="100vh"
      theme="vs-dark"
      defaultPath="app.tsx"
      defaultLanguage="typescript"
      defaultValue={defaultCode}
      onChange={onChange}
      onMount={onMount}
    />
  );
}

:heavy_plus_sign: Same thing

Probably because your useEffect don't listen to editorRef.

Just ran into this same issue. I think #6 should fix it since I need to pass my own instance of monaco. In my case I'm in NextJS and need to load it in a specific way.

Reopened since this was auto-closed. I merged #6 and updated some dependencies, can you please check and verify that using v0.2.0 of monaco-editor-auto-typings solves this issue? Thanks!

I'm using "monaco-editor-auto-typings": "^0.2.0"  and  "@monaco-editor/react": "^4.3.1" and got the same error

Finally got it worked !!! :satisfied:
has been enough to specify monaco instance in Options (see code below)
 const handleEditorMount: OnMount = (monacoEditor, monaco) => {

    monaco.languages.typescript.typescriptDefaults.setCompilerOptions({
      target: monaco.languages.typescript.ScriptTarget.ES2016,
      allowNonTsExtensions: true,
      moduleResolution: monaco.languages.typescript.ModuleResolutionKind.NodeJs,
      module: monaco.languages.typescript.ModuleKind.CommonJS,
      noEmit: true,
      typeRoots: ["node_modules/@types"]
    })

    monaco.languages.typescript.typescriptDefaults.setDiagnosticsOptions({
      noSemanticValidation: false,
      noSyntaxValidation: true,
    })

    const autoTypings = AutoTypings.create(monacoEditor, {
      sourceCache: new LocalStorageCache(), // Cache loaded sources in localStorage. May be omitted
      monaco: monaco
    });
  }

I'll close this then for now, if any other issues occur feel free to open a new issue.


Memory leak in the rendering pipline

What you were trying to do
Normally playing the game with water reflections set to "sky only" (default setting I assume).
What actually happened
The game needs constantly more memory as the field chunksOpaqueReflection field in RenderQueuesHelper grows constantly in size.
The method renderChunks of WorldRendererImpl is the only method I could find that removed entities from that list. The method renderChunks  gets however only called byWorldReflectionNode if the reflectiveWater config option is set.
The list gets filled multiple times with the same chunks again and again.
The expected max size specified by the  MAX_LOADABLE_CHUNKS  constant of RenderableWorldImpl gets thus easily topped. (Btw. I think it would have been better to not have this constant: 1. It is less code. 2. It can not lead another developer to wrongly assume that the queue has a size limit(was that the intention?). 3. The CPU overhead for growing the list is minimal (in the worst case twice as many assignments to array positions need to be made), while on the other size the list is not larger as it needs to be on systems that have less memory.)
Maybe the queue could be cleared before it gets filled again?
When this issue gets fixed, it should be checked if the other piplines have potentially the same issue.
How to reproduce

Start the game from the IDE with"water reflections" set to "sky only"
Set a breakpoint and have a look at the size of the  chunksOpaqueReflection field in RenderQueuesHelper

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/37349433-memory-leak-in-the-rendering-pipline?utm_campaign=plugin&utm_content=tracker%2F5279&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F5279&utm_medium=issues&utm_source=github).

@emanuele3d  @tdgunes it would be great if you could have a look as it is code you wrote.

Thank you @flo for reporting this problem.
The code you are referring to is older than our GSOC-based interventions over the past few months and even older than the refactoring of the rendering engine I have been working on over the past 18-24 months.
The particular chunk list you are referring to and others like it were introduced before my time, either by begla or immortius I imagine.
tdgunes did refactor the renderChunks method somewhat however and it is entirely possible that we introduced a problem without realizing.
In this context it'd be good to verify if this is a recently introduced problem or have been silently there for much longer. And is the issue noticeable only via debugging or does it result into filling the whole memory over a relatively short amount of time?
In any case, we'll look into it. Can we add some appropriate labels to this issue and assign it to me and tdgunes?

@Cervator: I'm not sure this is about 3D-Wizardry: more about chunks management in some kind of collection. But I guess those collections are compiled and maintained for the benefit of rendering so... :smile:

The game needs more and more memory, I don't know fixing this issue will completely fix it or if it is just contributing to it. I found the issue through a memory snapshot however, so it's not something minor. (view distance moderate = potentially 131313 chunks = about 2000 = chunks, 50 frames per second would give 100000 entries per second. Each entry say 4 bytes would give 400 kbytes per second = 24 mbytes per minute = about 1.4 GB/hour, of coures maybe not all chunks may have reflection but still).

Ok, we'll take a look. Thanks @flo!

3D wizardly related architecture then? :D
The labels aren't an exact science, better too many than too few :-)
(and thanks for the detailed issue, @flo)

Thanks @flo for reporting this issue. As @emanuele3d points out, I think it shouldn't be related with the what we are doing recently in the rendering engine. I briefly check to see what causes it. I sort of validate it with YourKit, but I am very novice in this matter.  Let me first post the related parts:
WorldReflectionNode.java
public void process() {
    ...
    if (renderingConfig.isReflectiveWater()) {
        ...
        // by `chunks.poll()`, it's removed from the queue in this method.
        worldRenderer.renderChunks(renderQueues.chunksOpaqueReflection, ...
        ...
    }
}

RenderableWorldImpl.java
/**
 * Updates the currently visible chunks (in sight of the player).
 */
@Override
public int queueVisibleChunks(boolean isFirstRenderingStageForCurrentFrame) {
       ...
       if (isChunkVisibleReflection(chunk)) {
           renderQueues.chunksOpaqueReflection.add(chunk); // Only addition to the queue
       }
       ...
}

I wonder why in RenderableWorldImpl.java addition to the queue is not dependent on the reflective water config. What do you think about that? All other queues are guaranteed to be removed because there are not dependent on any config. But why this is different in the first place?

This is again something I'm waaay not qualified to talk about, but the one thing that came to mind is an old memory of @begla talking about how reflection is expensive as each layer of reflection ends up needing a whole other rendering pass. Could this be a leftover of some older approach where at one point the reflection piece was "left in" on a first pass just so it could do its thing on a second or later pass? But then we refactored/broke something later and didn't correctly handle or clean up how reflection was set up.
I see a isFirstRenderingStageForCurrentFrame boolean right there, was what made me think of it. And we're bound to have places still where we have a weird mix of old and new code, or even old, really old, and new code
Chance are I'm totally off and should go back to logistics, but I wanted to try throwing an idea in there :D

I just took an in-depth look at the relevant code. In my opinion the quickest solution is as simple as having
if (sceneVisibleInReflections && isChunkVisibleReflection(chunk)) {
    renderQueues.chunksOpaqueReflection.add(chunk);
}

Longer term I'd like the whole RenderableWorldImpl class to become a number of "caching nodes" in the dag, processed before the rendering nodes, although right now I can't quite see how this can be achieved - it's hard to think how RenderableWorldImpl can be split into nodes.
Regarding the question "why is this queue different in the first place": it looks like a straightforward bug that was either there when this code was initially written or that was introduced somewhere along the line. Perhaps it was never detected probably because Terasology crashes or is shut down before memory consumption becomes an issue. Also, the chunkOpaqueShadow queue is an example of a queue dependent on the rendering config.
I don't have the time right now to do the fix as I want to go through the steps @flo suggested to make sure the fix does the job. @tdgunes, if you have an itch to deal with this go ahead and do it - just let me know if you do. Otherwise I'll take care of it sometimes this week I hope.


Remove Section on Accelerated Mode

Accelerated Mode was deprecated in 2.3 and removed in 2.5. It should either be removed from the book or at least noted it is not available in newer versions

Good catch! That chapter is due for a little more updating, now that I don't see Ansible 1.x in the wild almost ever; anyone running 2.3 or earlier should have updated by now, and new installs are on 2.7 or 2.8 at least.
I've updated that part of the book, removed the Accelerated mode section, and updated some of the other wording surrounding transport methods.
Thanks for filing the issue, and I will also credit you for helping with the fixes!


csharpier does not respect editorconfig specific c# rules

Issue
Csharpier fails to adhere to the specified guidelines for .cs files.
.editorconfig
root = true

[*]
charset = utf-8
tab_width = 2
indent_size = 2
indent_style = space
insert_final_newline = true
trim_trailing_whitespace = true
max_line_length = 200

[*.{cs}]
indent_size = 4
tab_width = 4

Bonus: We do use [*.{cs,csx}] and [*.{cs}] sometimes. It would be nice if the "more specific" rule takes precedence. eg [.{cs}] is used ultimately for formatting.
But probably an override mechanism is necessary: base editor config rules + override with [*.{cs,csx}] + override with [*.{cs}], which results in formatting with indent_size = 4
Example:
[*]
charset = utf-8
tab_width = 2
indent_size = 2

[*.{cs,csx}]
indent_size = 3
tab_width = 3

[*.{cs}]
indent_size = 4
tab_width = 4

This example results in formatting with indent_size = 4
Input:
namespace X;

public class Resolver
{
    private const int SinglePhase = 1;

    public int Resolve(object source)
    {
        if (source is not string)
        {
            return default;
        }

        return 0;
    }
}

Output:
namespace X;

public class Resolver
{
  private const int SinglePhase = 1;

  public int Resolve(object source)
  {
    if (source is not string)
    {
      return default;
    }

    return 0;
  }
}

Expected behavior:
Csharpier does not change Input. Formatting Input results in Input

I've narrowed this down to CSharpier not working with braces in the glob, which means a pattern like this will not work [*.{cs}], but [*.cs] does.
For this example
[*]
charset = utf-8
tab_width = 2
indent_size = 2

[*.{cs,csx}]
indent_size = 3
tab_width = 3

[*.{cs}]
indent_size = 4
tab_width = 4

According to the editorconfig spec, the most recent rule is what should be used. Which would result in an indent size of 4.
Which means for this example, indent size of 3 should be used for *.cs files even though the last rule isn't as specific. I imagine trying to code for most specific rule would be problematic.
[*]
charset = utf-8
tab_width = 2
indent_size = 2

[*.{cs}]
indent_size = 4
tab_width = 4

[*.{cs,csx}]
indent_size = 3
tab_width = 3

I agree sticking to the editorconfig specification is the way to go


custom strategies and indicators

What if you allow others to add their own indicators and custom strategies and give them default or custom strategy on .env

@AhmedElkanany
This bot is designed to use its own strategy, not intend to add other strategies.
And if you will suggest some feature, please describe how you would implement the feature.
A simple sentence like this won't give me any idea.
Please close the issue if your question is answered.


Documentation should explain how to install router

It currently doesn't specify how to use the custom router in the parent application. The config documentation has links in it twice.

#6 https://github.com/PrinceCornNM/emberfire-account/pull/6


Uploaded SVGs with <?xml /> tag fail to load on page

Link to reproduction
No response
Payload Version
3.0.0-beta.73
Node Version
22.6.0
Next.js Version
15.0.0-rc.0
Describe the Bug
Recently upgraded my project to 3.0 beta. Noticed that SVG images being served by Payload are not loading correctly on my page.
If I hit the URL directly in the address bar, it works fine. Seems to be an issue only when using image tags?
Payload returns 200, Safari will actually let you inspect the DOM of the returned SVG, but it won't show an image preview.
Chrome says that no data was returned but the Content-Length response greater reflects the size of the expected SVG.
I noticed a comment on Discord that mentions similar SVG problems. This person found that removing <?xml version="1.0" encoding="utf-8"?> from the SVGs fixed the issue.  My results are consistent -- removing that line results in the SVG loading without issue.
Reproduction Steps

Upload an SVG containing the line <?xml version="1.0" encoding="utf-8"?> at the top to a Payload collection.
Use an <img /> tag with the src set to the file URL.
Notice that the image fails to load on the page.
Remove <?xml version="1.0" encoding="utf-8"?> from the SVG file
SVG file loads without issue

Adapters and Plugins
No response

I'm having the same issues. Even with the Image Component from next i'm not able to display SVGs. Removal of "" fixes the issue for me aswell.

This is due to the package file-type not supporting SVGs
(cf. https://www.npmjs.com/package/file-type)

This package is for detecting binary-based file formats, not text-based formats like .txt, .csv, .svg, etc.

It might not be an easy fix, but it's worst mentionning that @payloadcms/storage-s3 does not have that issue.
Most production apps won't use on disk storage anyway. And you can very easily have a Minio running locally if can't use an actual S3 bucket.

I also ran into this.
Using a plugin "fixed" it for me.
Thanks, @theo-lubert.


On Windows 10, export freezes if a speech interrupts another speech

I am using Windows 10 64 bit, Desktop
If interrupt is true, the exported app will freeze when it tries to interrupt. Godot itself does not freeze though.
However if interrupt is false, it does not freeze; the new speech just plays after the current one is finished.
I have included a simple project file that has 3 nodes: A button that turns TTS interrupt on and off, a LineEdit to input text, and a Button that triggers TTS to speak.
Godot-TTS.zip

Give V0.5.4 a shot. I tweaked the underlying TTS logic to recreate the
player whenever speech is interrupted. Now I can spam your test project
with lots of TTS and it seems to handle interruption without freezing.
Please let me know if that works for you--WinRT is the platform I have
the hardest time testing on. Thanks for the report!

Yes it works great on Windows now, thank you!
Oh onto another thing though. I notice that windows doesn't send a "done" signal. If you know anyway to implement it I could try, since I use windows. However I'm not sure what coding API you're using with windows to make the DLL. I'm not even sure how to make DLL's but I could try to learn haha.

Sounds like another issue, but you may be able to get this working
yourself and submit a PR. The "done" signal is sent in TTS.gd--I just
poll the synth to see if it is speaking in _process, with a bit of
logic. You can actually see my ugly print statements there where I
tried to get this working on Android--forgot I left those in. :) I also
just ensured that the TTS node always runs even if the game is paused,
so you may want to grab it from master and replace it in your downloaded
addon to see if that fixes things.
If you can get that working and submit a PR, that'd be helpful.
Otherwise, if you can identify the logic error in _process, that'd
help too. Maybe is_speaking is broken subtly?
Thanks.

Actually, I'm pretty sure I figured out your other issue. Forgot to
indicate in the underlying TTS library that WinRT can now detect when
speaking, which is needed for the signal to send.
I'll have a new version up in the next couple hours that should fix
this. Watch the releases page.

Yes, I downloaded the newest version and it works perfectly! Thank you so much!

You're welcome. Mind if I ask what you're doing with this? Nice to see
more folks using my work, and I'm always curious what for.


File Input is not working when the file is open

                         Excel File                         <input type="file" width="120" name="file" multiple="multiple" id="fileXLS" accept=".xls,.xlsx">

                         <input class="file-path validate" type="text">

File is not selected and file-path field is empty when the selected file is open somewhere else.

Please follow the contributing guidelines


Fix version to the newest.

Changing the version to match the newest changes made to ZTP.

py27: commands succeeded
coverage: commands succeeded
flake8: commands succeeded
docs: commands succeeded
congratulations :)
Local tox passes.


Metadata registration bugs

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
There are some tiny bugs related to the metadata registration:

Lack of checking the group existed when applying a property.
The update time is absent when creating schemas.
Some required fields lack validations when creating schemas.

Use case
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

please assign to me

There are some check rules for schema.proto
https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/database/v1/schema.proto#L39

name is required
tags contains one item at least

https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/database/v1/schema.proto#L45
name and type are required.
https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/database/v1/schema.proto#L55
All fields are required except for updated_at
https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/database/v1/schema.proto#L67
There are one item at least
https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/database/v1/schema.proto#L89
All fields are required.
https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/database/v1/schema.proto#L101
All fields are required expect for interval, fields and updated_at.
https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/database/v1/schema.proto#L118
metadata, source_measure  and field_name are required.
https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/database/v1/schema.proto#L144
All fields are required except for analyzer and updated_at.
https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/database/v1/schema.proto#L184
All fields are required.
https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/database/v1/schema.proto#L194
All fields are required except for updated_at.

property.proto checking rules:
https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/property/v1/property.proto#L30
All fields are required.
https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/property/v1/property.proto#L38
All fields are required except for updated_at.


res.status === 204 is not included in res.ok ?

I send a DELETE request to the server, and it return 204, without any content

fetch(url, {
  method: 'DELETE'
})
.then(function(res){
  alert(res.status) //204
  if(res.ok)
    alert('OK') // never called
  }
})

followup

Do you get the same behaviour if fetching from https://getstatuscode.com/204 with the GET method? I've tried that and it appears to be working fine

notice that I was using DELETE method, and I tried to hit  https://getstatuscode.com/204 , it returns 403

any updates on this one? it throws JSON end input error if server returns null body status i.e 204. Are they converting response to JSON internally or something ?

any updates on this one? it throws JSON end input error if server returns null body status i.e 204. Are they converting response to JSON internally or something ?


CHAOS-6966 Pod JVM method latency

Pod JVM method latency docs and fault diagram
Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6752a19f6570a5e12f3a2715--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6752aadd3290f0e4e324aa6f--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://67572e1677edf21a9679d64b--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://675fc54432b0a0a2244c1d7a--harness-developer.netlify.app


Updating Phylum Integration

Description of the change
Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues
Checklists
Development

[ ] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests
[ ] All tests related to the changed code pass in development

Code review

[ ]  This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers mentioned in a comment
[ ] Changes have been reviewed by at least one other engineer
[ ] Issue from task tracker has a link to this pull request

hrmm, something is up with the circleci build process because the git key its using for authentication doesn't work, I'll need to look at that before I merge this down :/


Leave the tenant owners to handle namespaced CRDs in their own namespaces

Describe the feature
Leave the tenant owner appropriate RBAC privileges to handle namespaced CRDs in the owned namespaces. Currently, we assign the pre-defined admin ClusterRole to the tenant owner, limited to its namespaces only.
However, this role prevents the tenant owner to handle, e.g. create/get/list/patch/delete namespaced custom resources. For example, the owner cannot create CI/CD applications and projects, typically defined as custom resources:
$ kubectl auth --as=alice --as-group=capsule.clastix.io can-i get applications.argoproj.io -n oil-utils
no
$ kubectl auth --as=alice --as-group=capsule.clastix.io can-i get appprojects.argoproj.io -n oil-utils
no

What would the new user story look like?
Two options come in my mind:

We can define a new ClusterRole for all the Tenant owners, eg. capsule:tenant-admin, to use instead of the pre-defined admin. This ClusteRole will have permissions */* so any custom resource API is permitted for any Tenant. This may be not the best option.

We can add another field in the Tenant manifest where to specify, with more safe granularity, the additional permissions per Tenant. For example, in the tenant oil manifest:

apiVersion: capsule.clastix.io/v1alpha1
kind: Tenant
metadata:
  name: oil
spec:
  additionalAuthzRules:
  - apiGroups:
     - argoproj.io
    resources:
    - applications
    - appprojects
    verbs:
     - create
     - get
     - list
     - watch
     - update
     - patch
     - delete

When the tenant above is created, the Capsule controller generates "aggregate" ClusterRoles from the specs above, eg.:
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: aggregate-oil
aggregationRule:
  clusterRoleSelectors:
  - matchLabels:
      capsule.calstix.io/aggregate-oil: "true"
rules: []

and
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: capsule-tenant:argoproj.io
  labels:
    capsule.calstix.io/aggregate-oil: "true"
rules:
- apiGroups:
  - argoproj.io
  resources:
  - applications
  - appprojects
  verbs:
  - create
  - get
  - list
  - watch
  - update
  - patch
  - delete

More details on Aggregated ClusterRoles.
Expected behavior
The ability to install custom resources in owned namespaces open more application scenarios for Capsule:
$ kubectl auth --as=alice --as-group=capsule.clastix.io can-i get applications.argoproj.io -n oil-utils
yes
$ kubectl auth --as=alice --as-group=capsule.clastix.io can-i get appprojects.argoproj.io -n oil-utils
yes

$ kubectl auth --as=joe --as-group=capsule.clastix.io can-i get applications.argoproj.io -n oil-utils
no
$ kubectl auth --as=joe --as-group=capsule.clastix.io can-i get appprojects.argoproj.io -n oil-utils
no

Another benefit from option (2) is give the cluster admin more control on Tenants by assigning them capabilities according to their business profile. For example, tenants who have not bought CI/CD option will not be able to use it.

It makes sense to me, what we could do here is to don't bump up the API Version since we're adding a feature that is not breaking change.
I would suggest the following spec, WDYT?
Just a single remark about the spec field name: additionalAuthzRules could sound involved in authentication, so what about to use instead aggregatedClusterRoles? So we can document it using the provided Kubernetes doc.

Hi guys,
and why don't you want to use
  labels:
    rbac.authorization.k8s.io/aggregate-to-admin: "true"

in CRD clusterRoles?
this would add permissions for all tenant users

@MaxFedotov this is an option and currently our workaround too :)
However, consider we would give the ability to install custom resources by tenant according to their business profile. Instead, by adding an aggregatedClusterRoles to the single tenant we can have a more fine control on the tenant behaviour. No breaking changes to the APIs, just an additional control.

@bsctl Understood :) But then to keep it backward compatible, it should allow everything if nothing is specified?

I would say no, just the Namespaces resources would be manageable due to the Capsule RoleBinding.


Handle more kinds of overflow triggers for addendum code

Sometimes when you have a PDF, it has space to list multiple names, but they don't each have a discrete box.
E.g., you can separate the names with a comma, and fit 1, 2, or 3 names, depending on how long they are.
In that scenario, we could trigger an addendum when the length of the list as a string is over a certain length. and we'd want to break the list of names at a full name, not halfway through someone's name.
Addendum doesn't really handle this yet:

It doesn't have a concept of calculating the list as a string, it just knows about strings or lists, not strings turned into lists.
If something is treated as a string, we don't have a way to cut off the list at an appropriate place. It will just be based on a whole word, but that might be just someone's first name, or even just part of their first name.

Maybe we need the ability to define the addendum being triggered in a code block, rather than forcing people to use the overflow_trigger method? or maybe a combined approach?
maybe: overflow_calculation_method = "trigger"?
we don't really need to mess around with the "safe value" function, we can make people have their own way to print out what they want.


Fix patch bug

Description
Add support for not creating a new branch for a patch release. This was needed  by storage as they have multiple SDKs with the same release tag so in theory they can release all their libraries together using the single branch. Also fixed another bug in the script.

Thank you for the review.


feat: inform server if widgets are available

Closes #977 . Clients that do provide widgets should add a hasWidgets: true field to their initializationOptions for the LSP server. /CC @gebner

Thanks!

@gebner Feel free to complain if I merged this too soon and the editors won't be adapted until the next nightly. We can always revert.


Adding environment options

It would be great if one could set the environment in which to run the migrations.
For example in rails, one has to do:
rake db:migrate RAILS_ENV=testing
so it would be cool to add this to sails-db-migrate.
grunt db:migrate SAILS_ENV=testing
What do you think?

This is already supported using the NODE_ENV environment variable.
$ NODE_ENV=testing grunt db:migrate:up

Does that work for you?


[4.0][migrator] Do proper lookup and avoid prefixing typeof(of:) if the only found name is the stdlib one.

master: https://github.com/apple/swift/pull/9688
rdar://32229317

@swift-ci Please test

Explanation: Migrator pass adds 'Swift.' prefix for 'type(of:)' uses unnecessarily. It should onlt add it when lookup for 'type' at that position finds something other than the stdlib function.
Scope: Affects a migrator pass
Radar: rdar://32229317
Risk: Very low, changes only affect a migrator pass

@swift-ci Please test macOS


vsock: Add VM groups in sibling communication

Restrict the VMs a given VM can communicate with by introducing VM groups. A group is simply a name assigned to the device in the configuration. A VM can communicate with another VM only if their devices are assigned the same group name.
While implementing this, I discovered that optional parameters were not being correctly handled in the yaml config file. One needed to provide all the fields (even the optional ones) in the config file otherwise the application paniced. So, I have included a fix for this too.

So, IIUC for now we support only 1 group per VM, right?
Maybe better to clarify that in the documentation.
In the future, it will be nice to support multiple groups per VM, so one VM for example could be used as a proxy between multiple VMs.
It is not needed to implement it for this PR, but it might be a next idea. Do you think it is feasible?

Used unwrap_or for setting the default value of group in parse_vm_params. Also fixed a few minor things in tests.

So, IIUC for now we support only 1 group per VM, right?

Yes.

In the future, it will be nice to support multiple groups per VM, so one VM for example could be used as a proxy between multiple VMs.
It is not needed to implement it for this PR, but it might be a next idea. Do you think it is feasible?

I think I might be able to implement it in this PR itself. How do we accept multiple groups in the --vm CLI argument (because we are already using comma as a delimiter for key=value pairs)?

Added support for multiple groups.

Can we support multiple group=name?
e.g. --vm guest-cid=4,group=name1,group=name2,...

This looks a bit inconvenient, so for now I'm using + as the delimiter for assigning multiple groups like this --vm guest-cid=4,group=name1+name2. But let me know if you think it would be better to do it the way you suggested.

Added support for multiple groups.

Yeah :-)

Can we support multiple group=name?
e.g. --vm guest-cid=4,group=name1,group=name2,...

This looks a bit inconvenient, so for now I'm using + as the delimiter for assigning multiple groups like this --vm guest-cid=4,group=name1+name2. But let me know if you think it would be better to do it the way you suggested.

I think + should be fine!

Addressed all the review comments.


[e2e]: generic workflow_dispatch branch1 default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/11905494995
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.workflow_dispatch.branch1.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.workflow_dispatch.branch1.default.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Tue Nov 19 03:20:59 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/11926001245
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.workflow_dispatch.branch1.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.workflow_dispatch.branch1.default.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Wed Nov 20 03:16:14 UTC 2024
Tests are passing now. Closing this issue.


Expose initial and effective config for debugging purposes

Exposes config at port as an HTTP server at localhost:55555, paths:

/debug/configz/initial
/debug/configz/effective

The first shows the initial configuration used by the collector the second the configuration actually in use by the collector. If the configuration is reloaded due to some update triggered by a config source the endpoint is briefly unavailable until the updated configuration is reloaded.
The exposed port is controlled by the env var SPLUNK_CONFIG_SERVER_PORT - if it is explicitly set to the empty string, e.g. SPLUNK_CONFIG_SERVER_PORT="" it disables the HTTP server.
On the effective configuration, it performs a simple attempt to redact all string values for which the key contains strings like "token", "secret", etc. This covers all components currently in use by the collector a more generic solution is desirable.

Do we want to upstream this too?

My idea at this moment is to add a mechanism for the insertion of custom zPages and use it to add these pages but I'm not sure yet about the best path to add this support on the zPages extension.

My idea at this moment is to add a mechanism for the insertion of custom zPages and use it to add these pages but I'm not sure yet about the best path to add this support on the zPages extension.

@pjanotti I'm interested in this for a different use case but have some ideas if you want to discuss sometime.


RFP - Simple DNSCrypt

Simple DNSCrypt is a simple management tool to configure dnscrypt-proxy on Windows-based systems.
https://github.com/bitbeans/SimpleDnsCrypt/releases/latest

package pushed
https://chocolatey.org/packages/simplednscrpt/0.4.0

Package approved, please close this issue
https://chocolatey.org/packages/simplednscrpt/


Guild compare with range selector > total of runs throws an error

When using $ guild compare :x with x a number of runs greater than $ guild runs --all | wc -l
We get the following output :
guild: could not find a run matching ':X' Try 'guild runs list' for a list.
So when the range selector is greater then the total of runs, Guild treats it as a run id and throws an error. In case that is the correct behavior, the message should mention an index out of range cause.

Thank you for the report! I agree this should be clearer.

No longer an issue with 0.7


Dumbass

Here's an annoying issue you can't delete.  Check wgat he said first...

What did he say?

Max was rude in twitter. Check his account for the reddit replies.  Hmmm

He probably deleted.. well from now on he lost my respect


fix(web): Don't show that a root prop has a value overridden

Domain and Secrets are props attached to the root and are not set directly, therefore, we were telling a user they had overridden them which was misleading

No icons in place for props directly connected to the root

bors merge


ngMock $httpBackend does not support numeric timeouts

ngMock's $httpBackend service appears to support promised-based timeouts, but not numeric ones.  Example test demonstrating the issue:
it('should abort requests after numeric timeout', inject(function($timeout) {
  hb.expect('GET', '/url1').respond(200);

  hb('GET', '/url1', null, callback, null, 200);
  $timeout.flush(300);

  expect(callback).toHaveBeenCalledWith(-1, undefined, '');
  hb.verifyNoOutstandingExpectation();
  hb.verifyNoOutstandingRequest();
}));

I found something similar, for those looking, where $timeout.flush(5000) didn't timeout my $httpBackend requests that were created to have a 5 second timeout. The asnyc defer of $httpBackend was my issue. When config.timeout is defined, the reason it doesn't get called is that $timeout.flush(5000) actually creates the real request where the $httpBackend creates it's own $timeout.
Solution = to force $httpBackend to setup it's own $timeout's with the config.timeout value, call $timeout.flush(0)... followed by your "ok let 5 seconds pass" $timeout.flush(5000). Now your callback will have been called with -1.
   //any deferred tasks, like the $httpBackend's own calls to setup $timeout's, will get created here
   $timeout.flush(0);

   //our API call should timeout here
   $timeout.flush(timeToPretendPassed);


make api for swagger

need to add endpoint like /api/swagger that will return raw OpenAPI swagger file
related to https://github.com/blockscout/frontend/issues/2070

Works on staging: curl https://stats-sepolia.k8s-dev.blockscout.com/api/v1/docs/swagger.yaml

https://github.com/blockscout/blockscout-rs/pull/1007
and
https://github.com/blockscout/blockscout-rs/pull/1027


ReSharper Ultimate EAP6

Hi, I love your addon, it's really greate :+1: !!
Could you enable it to run with the latest and greatest version of Resharper EAP6?
Thank you!!

doesn't count anymore. but support for #72 resharper 2016.1 would be awesome!


[bug] = When I input Chinese, the small digits on the link disappear

Question
When I input Chinese, the small digits on the link disappear. When I input English, the small digits don't disappear.
Animation demonstration

Testing environment
Obsidian Sandbox and close all plugins.
Obsidian version
v1.3.4

I think this might be addressed with the update in the recent beta. Please install the current beta with BRAT. If you still have an issue, please let me know by reopening this issue.


DOC: Buttons

For button dropdowns, provide examples for how to set links, where it says:

duplicate of another issue


Add run export

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

could someone from @conda-forge/core review/merge this ?

It looks like this pr never bumped the maintainers. Let’s try that first.
@conda-forge/libogg

I think the lone maintainer is no longer super active.

Would you be willing to help maintain, @jschueller? 🙂

yes, sure

I'm sorry guys. There has been a change in the family situation lately and I have collected quite a backlog of e-mails in which the automated mails have received the lowest priority. That, and I've mainly switched from Python to Node.js as tech stack, so I haven't been keeping up with the developments in the conda environment as well as I should.
I can of course blindly merge all PRs without checking their quality, but I am not up to speed with the latest changes (as in, I have no idea what run_exports really does, even after quickly skimming the docs about it).  Since most of you are part of the core conda team, I trust that blindly merging PRs should not be such a big risk, but the question remains if this is desired behaviour of a repo maintainer.

No worries @dschreij. These things happen. There's no expectation that any maintainer would own their feedstocks indefinitely. Feel free to remove yourself if you'd like. Hope all is well in the real world 🙂
@jschueller, could you please send a PR to add yourself and I'll happily merge 😄

Thanks @jakirkham. Things are definitely well! We have a son now which is taking up the bulk of my time, hence my limited availability (but not motivation) for open-source related activities. It's good to know that I can be removed as a maintainer, as I often feel now that I have not a lot of added value in being one of some projects. Especially for c libraries which are not my forte. I'll see if I can make a shortlist soon of projects for to which I think I can contribute, and will remove myself from others.

Glad to hear that! 😀 Congrats on your new son! 👶 Completely understandable 🙂
Also don’t feel obligated to remove yourself from recipes. Was only mentioning it as option should you want it 🙂
Thanks again for all your work adding these recipes in the first place 😀


List of "recommended" regions not clear

[Enter feedback here]
The documentation talks about recommended regions couple of times, but there is no list of  "recommended" regions. Please either include the regions or include a link to a doc that has the information.
Foundational services: Available in all recommended and alternate regions when a region is generally available, or within 90 days of a new foundational service becoming generally available.
Mainstream services: Available in all recommended regions within 90 days of a region's general availability. Mainstream services are demand-driven in alternate regions, and many are already deployed into a large subset of alternate regions.
Strategic services: Targeted service offerings, often industry-focused or backed by customized hardware. Strategic services are demand-driven for availability across regions, and many are already deployed into a large subset of recommended regions.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9ef6739c-50e6-e80b-cfc1-4d7d5b5d35e8
Version Independent ID: 72c38d9b-b8b1-92d4-3937-12de08c35918
Content: Azure services that support availability zones
Content Source: articles/availability-zones/az-region.md
Service: azure
GitHub Login: @awysza
Microsoft Alias: rarco

The list of regions at its category (recommended, other) is an important information for our customers to plan their regional footprint accordingly.
We are aware that the information is visible as part of the Azure Portal and Azure CLI allows query, e.g. by executing az account list-locations --query "[].{DisplayName:displayName,PhysicalLocation:metadata.physicalLocation,Category:metadata.regionCategory}" -o table. Both ways have the caveat that it does not contain a complete list of regions.

@ravkash
Thanks for your feedback! We will investigate and update as appropriate.


Build config and encoding test issue

@yegor256 during build, if default java encoding is not specified build fails with message:
Failed tests:
RsXSLTTest.convertsXmlToHtml:53 default charset during testing must be UTF-8
Expected: "UTF-8"
but: was "windows-1251"
We can update config to be sure that tests run successfully and nothing is broken.
For this we need to add configuration of maven-surefire-plugin:
This will work correctly:
....

org.apache.maven.plugins
maven-surefire-plugin
2.15

-Dfile.encoding=UTF-8

...
P.S. If charset used in all project (for encoding and decoding character streams) is defined by java configuration, its incorrect, it must be defined during init of framework tools. Reason: server can be run in different encoding (different from UTF-8), and as result - some problems can rise up although test during build are successful. So its new Bug :)

@YamStranger it's by design, check "Important" paragraph at the end of Quick Start section, in README.md

@yegor256 only @YamStranger can close this issue, since he opened it

@davvd it's invalid one


More customizable initialization in yii.js

I found this issue during writing tests for yii.js.
Currently the yii.js is initialized right when the DOM is ready and applies all functionality:
jQuery(function () {
    yii.initModule(yii);
});

and:
init: function () {
    initCsrfHandler();
    initRedirectHandler();
    initScriptFilter();
    initDataMethods();
}

First of all, the user might not need all provided functionality. Let's say he doesn't need "data methods" functionality or "script filter" functionality, but still needs to automatically add CSRF or perform redirects after AJAX.
There is no way to configure that, we either get all or nothing.
Also there is no "destroy" functionality (because it's not a jQuery plugin I guess), so the only way to deactivate something is to deeply investigate the code and understand what it does and then deactivate proper event handlers, etc. This is not user-friendly at all. And I'm not sure if it's possible to deactivate code registered with $.ajaxPrefilter (unless it's done in the callback itself under certain conditions).
So the proposal is to add more flexible initialization and destroy functionality to temporarily deactivate something and initialize again.

How would you do it? That's BC breaking for sure, right?

@samdark At least we can have properties like enableCsrfHandler, enableRedirectHandler and so on, then wrap these init function calls with if (pub.enableSomeFeature) { } kind of checks and give them default true values to prevent BC break. Hovewer setting them can be a problem, see #13295. I thought about passing them through data attributes or decoupling this part from yii.js:
jQuery(function () {
    yii.initModule(yii);
});

and initialize it along with other widgets maybe.
Requires more deeper thinking. But in case of some radical changes we can always defer this issue to 2.1.

@samdark At least we can have properties like enableCsrfHandler, enableRedirectHandler and so on, then wrap these init function calls with if (pub.enableSomeFeature) { } kind of checks and give them default true values to prevent BC break. Hovewer setting them can be a problem, see #13295. I thought about passing them through data attributes or decoupling this part from yii.js:
jQuery(function () {
    yii.initModule(yii);
});

and initialize it along with other widgets maybe.
Requires more deeper thinking. But in case of some radical changes we can always defer this issue to 2.1.

Yes, using data attributes sounds great.


6277 dashboard grid is editable tile jump

Closes #780
Summary

Dashboard Grid (dashboard,isEditable) : Tiles on dashboard grid is jump (animated) while rending the page.

Change List (commits, features, bugs, etc)
src/components/Dashboard/DashboardGrid.jsx
src/components/Dashboard/snapshots/DashboardGrid.story.storyshot
Acceptance Test (how to verify the PR)

Click on Dashboard (dashboard,isEditable) link, Dashboard tiles should be rendering static without animation

@davidicus please review the PR#803 related the defect #780

My observation regarding this defect:
Actually jumping of tile is not defect rather it is a animation feature which is related to shouldAnimate property, disabling this property stop jumping animating the tile. In this Dashboard (isEditable) link, knob can be added to enable/disable tile animation.
For me this is not a defect.

@scottdickerson I am not really seeing any ugliness. It def just snaps and doesn't animate anymore but doesn't look messed up to me.

@lukefirth @amymillett @scottdickerson is this a preference that we can get a consensus on?

I accidentally deleted my original comment instead of the broken gif I had in it. The animation does not look too horrible in the preview link, not sure if I am looking at the right thing, but I think we should defer to @scottdickerson preference here. @sunilkotiyaibm If there is a way to disable animation on load that would be preferable to just disabling it. @lukefirth opinions?

I'll be dumb- @davidicus would you mind re-adding your gif? :)

@sunilkotiyaibm any update here for Scott's request?

Hi @davidicus , @psdixit<EMAIL_ADDRESS>is working this issue, I have discussed the scott concern with @psdixit. I will ask him to update on this PR.

Hi @davidicus I did some changes on PR #803 based on your previous comments. Please review the same and provide your valuable input.
Thanks,
PS Dixit

closing in favor of #894


CLTV and low s

Might want to pull in newly-backported change bitcoin/bitcoin#7021.

Merged this into my fortestnet branch, https://github.com/jtoomim/bitcoinxt/pull/1. I'll start deploying it soon. We might be done with the repeated forking, so it might be too late for us to test out CLTV with Core without setting up a node that's connected to Core nodes and not any other XT nodes. That could be arranged, but I probably won't be taking the time to do it myself.

The BIP65 tests need to be updated for the regtest chainparams changes in BIP101.  Here's a commit 50d09a202cfd6876b99c1ee76d16a13e8fa4bfa7 with the required changes.

Were you not telling the truth when you said on bitcoin-development that there was no consensus for this funds freezing feature?
Why would you adopt this complex, failure prone, BlockStream backdoor with a broken deployment system into BitcoinXT? I don't understand. Are you trying to help them win?

There was indeed no consensus about the rollout mechanism (soft fork vs hard fork). The opcode itself is quite harmless.
The nature of Bitcoin is that the majority wins. It does not have anything to do with unanimous consensus as so often suggested or implied (by Blockstream and their friends). So XT has no choice in the matter. Whilst miners support Core it has to accept changes to the protocol even if they are badly thought out.

OK, this seems OK now. @gavinandresen ok with you?

Could you comment on this:

Wouldn't it be better to bump the version for BIP(101+65) to have clearly defined behaviour?

See https://github.com/bitcoinxt/bitcoinxt/issues/93

I'm getting some of these on testnet in my debug.logs after having merged low-S:
2015-11-17 21:39:13.179994 ERROR: CScriptCheck(): c23a8b6f3972d414f035a7006f86ea9d30ddcbbf2cfd5fce863f5ab18dd551af:0 VerifySignature failed: Non-canonical signature: S value is unnecessarily high
2015-11-17 21:39:13.181559 ERROR: AcceptToMemoryPool: ConnectInputs failed c23a8b6f3972d414f035a7006f86ea9d30ddcbbf2cfd5fce863f5ab18dd551af
Looks like it's doing its job. (This doesn't mean it's flagging the right transactions, and it doesn't mean that it's not flagging the wrong transactions; it just means that it's flagging some transactions. I'm not looking into this too deeply.)

Whilst miners support Core it has to accept changes to the protocol

It's my understanding that in your preferred vision of the world that users get forced software update; but that isn't the world of Bitcoin Core.  CLTV is in a freestanding update that does effectively nothing else (there is a windows specific database corruption bugfix; but that is presumably irrelevant to miners).

@gmaxwell you know what he means. He doesn't literally think the  blockstream/federal reserve/putin/21co are conspiring for CLTV. He was just responding to a "the sky is falling" comment above him.

It's my understanding that in your preferred vision of the world that users get forced software updates; but that isn't the world of Bitcoin Core. CLTV is in a freestanding update that does effectively nothing else (there is a windows specific database corruption bugfix, and some other minor twiddling; but that is presumably irrelevant to miners).

Whoah, that's a lot to unpack. :fearful:

I ran into an issue in my testnet testing that I think is related to this PR. I don't really know what happened, but here's my leading hypothesis:

XT forked off of Core. Core was broadcasting OP_CLTVs (both valid and invalid), and XT included them on its fork.

I upgraded some of my XT nodes to include BIP65 support, making some of the transactions in the chain invalid.

The Core branch's PoW exceeded XT's, triggering a reorg.

4 (unclear): Some of my XT nodes may have had an OOM event causing a crash, or they may have crashed for another reason, or they may have not crashed at all until the bug in question occurred.

During reorg and/or during startup 288 block verification, an invalid CLTV transaction is discovered inside a block. Somehow, this causes the first line of DisconnectBlock() to fail:
assert(pindex->GetBlockHash() == view.GetBestBlock());

Weird things: sipa says that reorgs shouldn't check signatures, so it shouldn't notice an invalid CLTV, but he thinks that startup validation might find a difference. Looking at the log files, this error seems to happen during reorg, not during startup verification.
I downgraded all of the nodes that were encountering this issue to 0.11.0C (no BIP65 support), and the issue went away. I no longer have any nodes that are encountering this issue on testnet, unfortunately.

@gmaxwell You know perfectly well what I mean - no, supporting CLTV is now not optional no matter how many times you repeat that utterly ridiculous claim. It is not acceptable that a miner builds on top of an invalid block and produces something that will be rejected - avoiding that is the entire point of running a full node, and so XT has to merge this patch set, regardless of whether we think it's a good idea or not.
The fact that you continue to insist that miners can pick'n'mix what they check just goes to show how badly you've lost the plot. It isn't like that.

Optional for you? who knows. If a tree falls in a forest that no one uses does it make a sound? To the extent it is, it's not because Core forced you... to the extent that it becomes mandatory for you it will be because the deployed network did so.
You made a statement about miners being forced, and yet pose no mechanism of action for that to be possible.  As I pointed out: You're the guy with the forced automatic upgrade aspirations, not Core.  Miners could chose to not take this feature, -- and you sure tried to submarine it at the 11th hour. It was not tied to anything else.
Perhaps you'd have more success if you thought less in terms of plots.

https://gist.github.com/jtoomim/06f6054eafeae08f8717
There's some voluminous extracts from the logfile of one machine that had the problem described 22 hours ago. Here's one of the money sections:
2015-11-17 21:35:56.509442 UpdateTip: new best=000000000016b2f5e0e30da6fda9b798cf8dbded94f3457b3113678b20eda9e9  height=605145  log2_work=66.751811  tx=7208708  date=2015-11-16 14:48:52 progress=0.999947  cache=44.7MiB(109697tx)
2015-11-17 21:35:59.765015 - Disconnect block: 1705.08ms
2015-11-17 21:35:59.845904 ERROR: CScriptCheck(): 990ce5372f9113d88b9038cc138e75e2c959d382790ec2d3409746a9d184e0ee:0 VerifySignature failed: Non-canonical signature: S value is unnecessarily high
2015-11-17 21:35:59.846809 ERROR: AcceptToMemoryPool: ConnectInputs failed 990ce5372f9113d88b9038cc138e75e2c959d382790ec2d3409746a9d184e0ee
2015-11-17 21:36:04.200315 send version message: version 70010, blocks=605145, us=<IP_ADDRESS>:18333, peer=11
2015-11-17 21:36:04.200500 sending: version (106 bytes) peer=11
2015-11-17 21:36:04.200911 Added connection peer=14
2015-11-17 21:36:04.201544 Added connection peer=15
2015-11-17 21:36:04.201735 socket no message in first 60 seconds, 1 0 from 13
2015-11-17 21:36:04.201843 disconnecting peer=13
2015-11-17 21:36:04.202461 Added connection peer=16
2015-11-17 21:36:04.202714

************************
EXCEPTION: St9bad_alloc
std::bad_alloc
bitcoin in ProcessMessages()

2015-11-17 21:36:04.203492 ProcessMessages(block, 748705 bytes) FAILED peer=3

There's one instance of an St9bad_alloc without a previous Non-canonical signature message, but most of bad_allocs come immediately after a high-S.
I remember seeing an assert failed message noting main.cpp:1825 (the first line of DisconnectBlock in my fortestnet branch), but I can't find that in my logfiles. It may have only gotten dumped to stderr and not to debug.log.

std::bad_alloc means you ran out of memory. Is this testing with glibc malloc or jemalloc?

It looked like I had about 1.5 of 4 GB of physical RAM used, and about 4 GB of swap unused at that general time. I was not looking at the moment it crashed, though.
These machines should all be using glibc malloc.

I suspect if the node was doing tons of re-orgs or otherwise dealing with the mess on testnet then it fragmented its heap and puked. Perhaps the next release should have both CLTV+low-s+jemalloc? How big would a patch be to make it use that malloc, any idea?

My suspicion is that there's an assert error in DisconnectTip that is causing the parent thread to go into shutdown mode and that causes any malloc attempts by child threads to return bad_malloc. I have not seen these nodes using a lot of RAM.
Another error, probably the same, which happened during a very small reorg:
https://gist.github.com/jtoomim/0b558a65a7702c250d0c

A log from another of my servers (which was not mining) which crashed on a reorg triggered by the same block:
https://gist.github.com/jtoomim/e537f4dd6db51e7d74a4
It's odd that I had 6 servers running the same version, and only two crashed on this block.
The block that triggered the reorg was 000000009ed9704cc64dd32c2a8061eba0f507c79cd56944ed481f42541e0d7f. I don't know which block it was that was being disconnected.

The Bitcoin code is probably not 100% exception safe, so once you take an exception I'd expect the node to be in a partly messed up state after that especially if it was a malloc error.
@gavinandresen Any ideas?

Clarifying: I think the malloc error is second. I think the assert failure is first, but the assert failure seems to not show up in debug.log.

During a reorg, an ATMP allocation error occurs in DisconnectTip, and would lead to UpdateTip never being called.  This is a totally corrupt situation which would cause an assert failure on a future call to DisconnectBlock, if not some earlier problem.  So I'm satisfied there is no problem outside of the out-of-memory condition.
@jtoomim are you satisfied that you understand how you ran out of memory?  Were you not running with a limited mempool?

ATMP?
No, I am not satisfied that I've been getting OOM. I was running with a limited mempool (400 MB estimated real usage or less), and to wit I've never seen any of these nodes show more than about 40% of their physical RAM in use. All of the nodes have at least 4 GiB of physical RAM, and one of the machines that ran into the issue has 14 GiB. As I said earlier, I think it is more plausible that the assert failure was first, and that the std::bad_alloc happens because a different thread tries to make an alloc after the unhandled exception and it is disallowed.

Why would making an allocation after an exception be disallowed?
Are you running a 64 bit or 32 bit build?

Sounds like it is not out-of-memory, but a violation of the implicit assumption that the blockchain your node saved to disk is a valid chain.
The assumption got violated because the chain was saved with one version of the code (that understood OP_CLTV to be a no-op) but then re-used (via a long re-org) with a newer version.
This might be a "won't fix" bug -- the effort required to create a reproducible test case is pretty high, and the likelihood of this actually happening on the main network is probably low. Then again, finding out where the code assumes that blocks/transactions on disk are valid under current rules and changing that code to be more robust in case the validation rules change would be spiffy (assuming it doesn't have a performance impact).

That sounds very plausible Gavin. If true, it also shows the dangers of this redefine-a-nop rollout strategy. It complicates the code considerably to have to handle the case where an opcode has changed meaning (vs, was guaranteed to never appear in the chain before).

ATMP = AcceptToMemoryPool
Reorg validation aside, I'm unclear what proximate cause, other than out of memory, is proposed for the observed std::bad_alloc exception.


Update README.md

Coverage remained the same at 53.846% when pulling 8c3e2d0bc79f5d1044d52e9d971510845749d9fd on waldekmastykarz-patch-1 into 59ed69f9999619b9b2980b767697da46c49054c8 on main.


Third-party SMS app not backed up

I use Signal messenger as my default sms app, but sms backup+ doesn't recognize it and no message is backed up.
How can I fix this?
Android version: 6.0.1
Phone model: Sony Xperia Z5 premium dual

Bump.  Same issue.

Not supported: #841


No Header View ( Pre , next , view month, week )

Hello ,
I have installed the fullcalender   . Calender  header view , only can see title and cannot see the pre, next, month , week next year etc.
Kindly advice me .
Thank you

Hello @sathivel1985, sorry for the late response, can you show me how you create the calendar?

No activity for 2 weeks so I'm closing this issue.


Updating call to core config for SaaS connector tests

Closes #1281
Code Changes

[x] Changed way the core config is called in the SaaS connector tests

Steps to Confirm

[ ] Ran SaaS integration tests

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
Documentation Updated:

[ ] documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
[ ] documentation issue created (tag docs-team to complete issue separately)

[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[ ] Update CHANGELOG.md

@galvana the code changes make sense to me here, but all of the tests are still failing. Is there another issue to fix those?

@ThomasLaPiana it looks like there's an issue when the SaaS connector tests are run via nox -s "pytest_ops(saas)". The tests pass when calling pytest -m integration_saas inside of nox -s dev -- shell. Looking into what the difference is.

@galvana thank you! great find and fix


Request : make SWS notes fast

I notice that the SWS notes functions can get quite slow. Even simply writting things in the SWS notes is lagging in my project at this point.
I use them a lot, they are very cool. But if I use "Script: cfillion_Duplicate tracks (preserving SWS track notes).lua" with folders (lots of tracks, 50+), the limit of current SWS notes start to show. The action takes half a minute to do its work. Heavy lifting it seems... But maybe it could be made lighter ?
So I guess my request would be to think about making SWS notes a bit faster in the long run, for people like me that have started to use them as a very important tool. Not only to mark a few things ("change this, eq that, sample this"), but rather as an elaborate track tagging system, notes that can influence the actions of external scripts.
SWS notes are VERY powerful. Make them go... faster please :p.
xxxxxxxx
louis

It does look like the Duplicate Tracks script is sub-optimal. It is quadratic, but it could be made faster (n*logn worst case). I'm just a newcomer, but I'll see what I can do about it. I'm thinking about bulk operations. I dare not change the stored data structure for faster lookups.

That would be absolutely awesome. Any improvement, even little, could have drastic positive impact, in the context of very very big Reaper projects, with extensive use of SWS notes. Thanks for answering :) ! xxx Louis

Bulk operations seem problematic, I'm not sure if we could return an array to a Lua script from C++.
My second idea is we could keep the track notes array sorted by GUID at all times, and we could use binary search for lookups instead of linear search. This would speed up all existing scripts.
A hashtable would be even better, but I'm not sure if that's doable.
Anyway, I'll keep experimenting. (:

Thanks guys for being commited to solving this bug... All the specifics are way way over my head, but be sure your work is highly appreciated.
xxxxx
louis


Reland Native ios context menu (#143002)

Reland of https://github.com/flutter/flutter/pull/143002, which was reverted in https://github.com/flutter/flutter/pull/148237 due to unresolved docs references. Not sure why those weren't caught in presubmit.
dartdoc:stdout: Generating docs for package flutter...
dartdoc:stderr:   error: unresolved doc reference [TextInput.showSystemContextMenu]
dartdoc:stderr:     from widgets.MediaQueryData.supportsShowingSystemContextMenu: (file:///b/s/w/ir/x/w/flutter/packages/flutter/lib/src/widgets/media_query.dart:579:14)
dartdoc:stderr:     in documentation inherited from widgets.MediaQueryData.supportsShowingSystemContextMenu: (file:///b/s/w/ir/x/w/flutter/packages/flutter/lib/src/widgets/media_query.dart:579:14)
dartdoc:stderr:   error: unresolved doc reference [showSystemContextMenu]
dartdoc:stderr:     from services.SystemContextMenuController.hide: (file:///b/s/w/ir/x/w/flutter/packages/flutter/lib/src/services/text_input.dart:2554:16)
dartdoc:stderr:   error: unresolved doc reference [hideSystemContextMenu]
dartdoc:stderr:     from services.SystemContextMenuController.show: (file:///b/s/w/ir/x/w/flutter/packages/flutter/lib/src/services/text_input.dart:2509:16)

please merge this

Reason for revert: Failures in post submit https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8748025189669617649/+/u/run_test.dart_for_web_canvaskit_tests_shard_and_subshard_3/stdout


Add a lot more sites

There obviously many duplicates, sorry for that
Unsplash, Nohat, Pexels, PixaBay, PNGIMG (png), StockSnap, allthefreestock, altphotos, goodfreephotos, morguefile, desirefx, icons8 / 2, gfxmountain, all-free-download, freepik / Drive, creativity103, photos8, reshot, creativecommons, DreamsTime, OpenAccess, LibreStock, FreeImages, PixelMob, StorySet, behance, barnimages, gratisography, freeillustrations, kaboompics, picjumbo, negativespace, burst, barnimages, skuawk, undraw, rawpixel, drawkit, cgispread, unblast, freedesignfile, argfx, skitterphoto, copyrightfreephotos, libreshot, themeisle, pxfuel, depositphotos, foodiesfeed (Food), Illustrations, Objects, Humaaans, blush, cupcake, magdeleine, littlevisuals, picography, stickpng, lifeofpix, diverseui (Human Faces), designerspics, travelcoffeebook, publicdomainarchive, twnsnd, moveast, focastock, jeshoots, isorepublic, digitalcollections, flickr / Downloader, startupstockphotos, shutteroo, photostockeditor, photober, freerangestock, stockified, snappygoat, realisticshots, pickupimage, jaymantri, freelyphotos, crowthestone, cc0, photoeverywhere, freejpg, getrefe, titania, opendoodles, thestocks, sitebuilderreport, avopix, openverse, drawkit, 3D Illustrations, 3dbay, pixeltrue, marker-illustrations, free-gophers-pack, vecteezy, warrenphotographic (Animals), freenaturestock (Nature), 4freephotos, niceillustrations, NS-illustration-pack, manypixels, fresh-folk, iwaria, stockvault, slon.pics, pikwizard, aerophotostock, freestocks

Vectors
vectorportal, publicdomainvectors, vecteezy, 123freevectors, freevector, freevectors, free-vectors, vector4free

also check https://fmhy.net/img-tools#download-images if you want


Using 1.6, now I am losing the last character of the filename

Thanks for looking at the previous issue with it losing the first character of the filename... but now it's losing the last character.
My action:
env:
    AZURE_WEBAPP_PACKAGE_PATH: '.'

- name: Copy test data to blob storage container
  uses<EMAIL_ADDRESS>  with:
    connection_string: XXX
    container_name: dataloader
    source_folder: '${{ env.AZURE_WEBAPP_PACKAGE_PATH }}/TestData'
    destination_folder: sample
    clean_destination_folder: true

I have a file under the TestData folder named "Xx-Yyy-Z Data.xlsx"
It uploads to the container, but the name is "Xx-Yyy-Z Data.xls" - missing the final "x".

Thanks, it is happening to all the files :/ This appears to be a regression I added in a rush to get the empty folder issue fixed.

okay, I found the issue and fixed it in v1.7 (rolling out momentarily).
I confirmed the following results after the fix:
No Destination Folder Test

Yellow highlight is only file uploaded, no target

Ignore MyTargetFolder for now, that is result from the next test.

Destination Folder Test

Yellow highlight is destination folder
green highlight is content


Schur qp

This PR adds Qp and PCD functionality to the Navier Stokes solver class.

This looks great. I need to go through the actual construction of the blocks more closely. You may want to go ahead and add some of the tests to the nosetests line in .travis.yml so they get run automatically.


Add Search Indexes

This PR adds indexes to support the new fulltext search feature.
Closes #68

Need to re-evaluate the index type. Might go with tsvector instead.


merge redundant objects

If you want to see a pretty awful svg try to export one from openstreetmap
I uploaded an example at jsfiddl
You will see lines like this:
<image id="image5" width="5" height="5" xlink:href="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAIAAAACDbGyAAAABmJLR0QA/wD/AP+gvaeTAAAAPklEQVQImWP8//9//+c1DAwMDAwMhbwhLP2f1xzYu//q29vawqoMzgxMDAwMV9/ehpNMDAwM2sKqcJIRTT8Aqx0ZstcgmXUAAAAASUVORK5CYII="/>
<image id="image8" width="5" height="5" xlink:href="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAIAAAACDbGyAAAABmJLR0QA/wD/AP+gvaeTAAAAPklEQVQImWP8//9//+c1DAwMDAwMhbwhLP2f1xzYu//q29vawqoMzgxMDAwMV9/ehpNMDAwM2sKqcJIRTT8Aqx0ZstcgmXUAAAAASUVORK5CYII="/>
<image id="image11" width="5" height="5" xlink:href="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAIAAAACDbGyAAAABmJLR0QA/wD/AP+gvaeTAAAAPklEQVQImWP8//9//+c1DAwMDAwMhbwhLP2f1xzYu//q29vawqoMzgxMDAwMV9/ehpNMDAwM2sKqcJIRTT8Aqx0ZstcgmXUAAAAASUVORK5CYII="/>

<!-- it goes on like this for 97 lines... -->

its just the exactly same object 97 times. These 97 objects could be compared and merged into one. Replaced by references and so on. I'm sure this alone would reduce the file size to around 99%

So this would be some kind of high-level gzip.