Change Location Temporarily Closed text

Some of our online meetings that used to meet at a physical location, are now going back inside AND keeping the online meeting at the same time. Not as a hybrid meeting, but rather two separate meetings.
For the online instance, it seems to be confusing people to see the text "location temporarily closed" since it's only this instance of this meeting that is not meeting in person. The location is open for other meetings.
Perhaps it could be changed to "Not meeting in person", or "This meeting is not meeting in person"(And take out the temporarily word).
I would still have the address crossed and greyed out if type is TC regardless of whether the URL and/or phone field had data.
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

I've moved this issue to the spec. The TSML plugin and TSML-UI both adhere to this for the type names.
Some history on this type; it was created on Mar 12, 2020 originally phrased Temporary Closure.
It was changed on April 11 to Location Temporarily Closed.
There's a proposal underway to deprecate this type entirely and use a new attendance field for this, not have it be a meeting type at all.
Once that gets resolved, the plugin and TSML-UI will both follow whatever new rules are adopted.

Hey @Grateful-Viv,
For the use case your comment described in the first paragraph, I think many are making these two different meeting entries.
Given this, for the online instance, I think you should be able to remove the Location Temporarily Closed tag from that meeting, no? You may to then change the meeting address to an approximate location (city and state)
If I’m understanding you correctly, your list should then show two meetings, one in person and one online.
Am I misunderstanding?

@tech2serve
We did make two meetings, one for the online which has TC as the type and the URL/Phone number entered. The other is the physical address meeting. But the complaint came through today the one that is online is confusing because it says location temporarily closed, rather than the meeting is not meeting in person.
I made a notation in the online meeting that there are two meetings, one at the location and this one that is online. See screenshots.
Yes, it's splitting hairs, but that's what I deal with often.

Is the reason to make them two separate meetings so that they're not labeled "Hybrid?"

Is the reason to make them two separate meetings so that they're not labeled "Hybrid?"

No. In this example, the Desire to Stop meeting is NOT a hybrid meeting. It's two separate meetings. But for some reason, they are getting thrown off by the Location Temporarily Closed text from the online meeting. Hopefully, the note I added will clarify things.
We do have a couple of hybrid meetings, and those have TC type removed, proper URL/Phone fields filled out, along with with any notes in there regarding safety protocols.
See for example:
https://sussexaa.org/meetings/friday-night-rehoboth/
https://sussexaa.org/meetings/love-service/

Why have the TC type applied to the online meeting? You’re not trying to tell me their regular meeting at (fill in the blank church) isn’t available any more. The meeting is a separate meeting and is in person.
You don’t need to have the TC type applied unless you’re trying to tell me the regular in-person meeting isn’t taking place.
Since you have two different meetings, that is moot.

These are a separate meetings - each doing their own discussion, running at their own pace, at theoretically, different locations (one is online and the other is at a physical address). It seemed to make sense to add a second meeting to the already online meeting since they're different meetings.
Hybrid meetings are not separate. You can go there in person or you can go there online, but it's the same meeting.
If I were to follow your thinking, what would you do different if this was a hybrid meeting vs a separated physical meeting and online meeting?

These are a separate meetings - each doing their own discussion, running at their own pace, at theoretically, different locations (one is online and the other is at a physical address). It seemed to make sense to add a second meeting to the already online meeting since they're different meetings.

This is why I don’t understand why you’d use the TC type for either of these meetings. They are separate and distinct, and operating as designed.

Hybrid meetings are not separate. You can go there in person or you can go there online, but it's the same meeting.

Correct.

If I were to follow your thinking, what would you do different if this was a hybrid meeting vs a separated physical meeting and online meeting?

Leave them as one entry in the database. Make sure the conference_url is filled out, and also make sure their is a complete physical address. And I would leave the “Location Temporarily Closed` unchecked as there are no restrictions for attending this meeting.

Leave them as one entry in the database. Make sure the conference_url is filled out, and also make sure their is a complete physical address. And I would leave the “Location Temporarily Closed` unchecked as there are no restrictions for attending this meeting

So you'd handle hybrid and the meeting that isn't hybrid the same way?

Leave them as one entry in the database. Make sure the conference_url is filled out, and also make sure their is a complete physical address. And I would leave the “Location Temporarily Closed` unchecked as there are no restrictions for attending this meeting

So you'd handle hybrid and the meeting that isn't hybrid the same way?

I’m not sure I understand the specifics leading up to this question.
What I am saying is that if a meeting is online only, it doesn’t require the TC type to be used unless there was a location associated with it that isn’t presently available. At that point, the meeting is no longer hybrid.
Now, let’s say that meeting location reopens and people can again attend in person. The admin should remove the TC type, and make sure the address is complete (not approximate) with the street, city and state. At that point, as long as the conference_url is still entered, the meeting should be handled as a hybrid. It will have one entry in your database.
In your situation, you have two distinct meetings and I’m not seeing any reason to use TC for either of them.

So you would have two meetings listed? One has the conference URL info. The other has the physical address. Neither has TC checked?
This conversation is getting hard to follow.
Maybe we could do a quick zoom meeting.

If the meetings are indeed two different and distinct meetings, then yes, I would have two entries in the database with unique names.
To help differentiate, does your online and in-person meeting have the same chair person? Is there a camera in the physical room so that the people in the building can speak with, see and listen to someone connected virtually? If the answers are "no", then I'd say they are two distinct meetings, and there should be two separate meetings (with different names).
As far as entering them, the online meeting should have the conference_url and an approximate location (city and state). The in-person meeting should not have the conference_url and it should be populated with a complete address (street, city and state).

Two different meetings. Two different chairs. Two different discussions.
Not hybrid. No camera.
In-person meeting has physical location that is properly linked to map. No TC.
Online meeting has conference URL. Also has TC type enabled. I don't think that should come off. The text could be changed to say the meeting is not in-person, instead of the location temporarily closed. I know what it was originally, and people were confused and that's why it changed, but it would actually be less confusing to say the meeting is not meeting in-person, rather than the location is closed.
The only time I have TC off for an online meeting is if it's hybrid, which this is not.

Two different meetings. Two different chairs. Two different discussions.
Not hybrid. No camera.
In-person meeting has physical location that is properly linked to map. No TC.
Online meeting has conference URL. Also has TC type enabled. I don't think that should come off. The text could be changed to say the meeting is not in-person, instead of the location temporarily closed. I know what it was originally, and people were confused and that's why it changed, but it would actually be less confusing to say the meeting is not meeting in-person, rather than the location is closed.
The only time I have TC off for an online meeting is if it's hybrid, which this is not.

All I can really say is that is not how we're designing it (which is based on a lot of discussion and feedback). I'll add a couple more thoughts.
The meeting list is primarily intended to be a snapshot in time, at this moment right now. It isn't meant for historical tracking. Just because an online meeting grew out of a physical location that was closed because of the pandemic doesn't mean its listing should show the meeting location as closed, unless that closure is temporary and you intend to reopen it, thus making it a hybrid meeting once that occurs. In the case you're describing, it sounds like this isn't the situation. I see no reason to continue to have TC associated with the online meeting.
Think of it this way. Regardless if the label displays "location temporarily closed" or "temporarily suspended" (or something else), the intention of this metadata is to alert the user that if they show up to the meeting location because it was an in-person meeting yesterday (think more literally vice several months ago), they will find the doors locked or the meeting location otherwise unaccessible. This doesn't apply to a meeting that has moved completely and permanently online, and the reason for the inactive state should be described in the notes.
The entire TC type is (long term) going away, or at least changing. Some descriptor, such as "inactive", is probably the direction we're going. There are a number of reasons for this change, but the overall intent is to simplify the messaging to the newcomer that the meeting they're considering isn't actually available to them right at this moment. There is a pretty strong push to remove these from the active list entirely, but a full consensus hasn't been reached yet and we still understand the need for temporary closures stemming from events like building remodels, summer schools, seasonal flooding, etc. So we're maintaining support for that.
But with an online meeting that doesn't rely upon a physical address (short of an approximate location for affiliation), adding the TC type is more likely to confuse the newcomer. I don't see where it adds any value outside of the situation where the meeting will soon return to an in-person format at the physical location.

A lot of these meetings once met at a physical location. In fact most of them did.
We used TC to indicate the location closed.
If it stayed closed and no online meeting occurred then as far as we’re concerned the meeting is inactive, which is something I’ve been asking for for a while as a flag.
If the meeting became online, we still used TC and then entered the URL. Many of these groups have been paying rent all this time in order to hold their space. It’s just that they’re currently meeting online, but it’s been useful to see address displayed as greyed-out and crossed-out to let people know that there’s a placeholder for if and when it returns in person.
This is completely different from meetings that got created as an online meeting only and never had a physical presence. In those cases we enter the county and the state and no physical street address. There’s no TC involved in this one either.
TC was removed if the meeting became hybrid or if they were turned in person to the location.
You’re suggesting now that I remove the TC and also remove the address?

You’re suggesting now that I remove the TC and also remove the address from all online meetings?

In short, yes, as long as the meeting is purely online or is hybrid (and the meeting venue has reopened). If the meeting is online but still has a physical venue that you expect to reopen soon, then it is reasonable to leave the TC type checked.
In our experience, most areas are rapidly reopening meetings which means they're removing "Location Temporarily Closed". For those meetings that also have the online details filled out, these meetings should be considered hybrids, unless the address is approximate (i.e., city and state only) If the meeting is shifting from online to in-person, the conference details should be removed, and the meeting should be treated as once again in-person if the address is complete (i.e., street, city and state).
The next couple paragraphs are my attempt to further share our thinking outside of our group for the purpose of practicing how well we can communicate our intentions :-) I'm hoping this makes sense to you (not necessarily if you agree with it, just simply if you can follow our logic):
We're still working with this for TSML v3.11. As you're aware I think, we're adding an attendance_option to better characterize meetings as "in_person", "hybrid" or "online". This field also has the option of reflecting the meeting as temporarily inactive, but we're still working on the best way to do this automatically in order to simplify the UX for the admin.

My current thinking is that if the admin answers "no" to the question about the meeting being in-person, and conference url is filled out, then we're left with two scenarios:

A specific street address is provided. In this case I think the plugin should still treat the meeting location as temporarily closed, and the meeting should be flagged as such.
Only an approximate location is provided. In this case, the plugin should treat the meeting as purely online.

Perhaps this description will help explain the direction we're going?

If the meeting is online but still has a physical venue that you expect to reopen soon, then it is reasonable to leave the TC type checked.

Reopen soon is very subjective. Some are jumping at it, and others are being very cautious. I think we'll have a better picture by mid-summer. In the meantime, I'd hate to remove the TC for them.
As far as meetings that are either hybrid or purely online, there is no TC type checked.
As far as your scenario described with "no" to the meeting being in-person and conference URL filled out and a specific street address filled out, maybe consider that instead of treating this as "location temporarily closed" instead to  "meeting is not meeting in-person".  The reason for this is the location could be open for other meetings, but this particular meeting is not meeting in person.

If the meeting is online but still has a physical venue that you expect to reopen soon, then it is reasonable to leave the TC type checked.

Reopen soon is very subjective. Some are jumping at it, and others are being very cautious. I think we'll have a better picture by mid-summer. In the meantime, I'd hate to remove the TC for them.

Agreed.

As far as meetings that are either hybrid or purely online, there is no TC type checked.

Yes. And that is the point I was trying to make earlier. If you have a meeting that is online, and there is no intention of it having a corresponding physical meeting, leave the TC off. It doesn't add any value.
I suspect there will be meetings that had been in person prior to the pandemic. They shuttered last year (TC'd), then went online (ONL and TC'd), and now the group has decided to skip reopening the physical meeting and instead will just keep the group online. In this case, it makes total sense to me to remove the street address and the TC type, and make the meeting online only.

As far as your scenario described with "no" to the meeting being in-person and conference URL filled out and a specific street address filled out, maybe consider that instead of treating this as "location temporarily closed" instead to "meeting is not meeting in-person". The reason for this is the location could be open for other meetings, but this particular meeting is not meeting in person.

I think we're probably going with "inactive" for the label displayed to the end user for just this reason.

Yes. And that is the point I was trying to make earlier. If you have a meeting that is online, and there is no intention of it having a corresponding physical meeting, leave the TC off. It doesn't add any value.

Agreed. And I got that point from the beginning.

I suspect there will be meetings that had been in person prior to the pandemic. They shuttered last year (TC'd), then went online (ONL and TC'd), and now the group has decided to skip reopening the physical meeting and instead will just keep the group online. In this case, it makes total sense to me to remove the street address and the TC type, and make the meeting online only.

That makes total sense. I know of several that seem to like their zoom more than going in-person.

I think we're probably going with "inactive" for the label displayed to the end user for just this reason.

Not sure I follow. Inactive would only apply to suspended meetings that are not meeting anywhere as far as we’ve been told. Is that what you mean? Because my scenario was for the TC and online that used to meet someplace, but the meeting “temporarily” moved online. I know when this all started we didn’t think temporarily would be over a year.

Not sure I follow. Inactive would only apply to suspended meetings that are not meeting anywhere as far as we’ve been told. Is that what you mean? Because my scenario was for the TC and online that used to meet someplace, but the meeting “temporarily” moved online. I know when this all started we didn’t think temporarily would be over a year.

We're still working through how to keep this simple for the admin while still keeping it comprehensible.
More to follow.


Tweaked github actions + Updated dependencies

Codecov Report

Merging #95 (5a3328f) into master (b0f8e64) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   86.22%   86.22%
=======================================
  Files           4        4
  Lines         305      305
=======================================
  Hits          263      263
  Misses         42       42

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f8e64...5a3328f. Read the comment docs.


Fix  issue 20665 - std.concurrency.spawn should document not working with delegates

Improved compiler error message and amended documentation to document the limitation.

std/concurrency.d(595): Error: static assert:  `__traits(compiles, spawn(F, T...)(F fn, T args) if (isSpawnable!(F, T))(dg1, 1))` is false

@thewilsonator I have modified this PR to reject only delegates that are not shared or immutable and documented that behavior. Since I deviated from the original fix, I think someone else shoud merge this.

std/concurrency.d(520): Error: static assert:  "Cannot spawn a delegate that is not `shared` or `immutable`"
generated/linux/debug/64/publictests/std_concurrency.d(107):        instantiated from here: `spawn!(void function(Tid) @system, Tid)`

Apparently, is(void delegate(int) shared == shared) yields false due to: https://issues.dlang.org/show_bug.cgi?id=1983 .

I gave up on improving the error message. I updated the documentation. Delegates that mutate unshared data are still going to fail with a non-perfect error mesage, but at least the thing is documented now.
@thewilsonator I think that we can merge this now.


Unclear reference to numbered steps

The page refers to numbered steps, but the page does not state what those steps are.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 432a9f06-8b6d-e0a6-74e0-8ab82657bf51
Version Independent ID: 1cdd58c1-2acd-f82a-a75f-401667b6737a
Content: Checking Flags in the Device Object - Windows drivers
Content Source: windows-driver-docs-pr/kernel/checking-flags-in-the-device-object.md
Product: windows-hardware
Technology: kernel
GitHub Login: @tedhudek
Microsoft Alias: tedhudek

Good eye @henke37, thanks for the report.
It's possible that this was referring to https://docs.microsoft.com/en-us/windows-hardware/drivers/kernel/power-irps-for-individual-devices (see the text description of steps 3 and 4, below the image).  These steps mention the driver failing an IRP.  Do think that would make sense?  If so, I can add a link.
Over the years the ordering of pages in this documentation has changed, so it is possible that these pages were next to each other long ago.

I honestly have no idea if that's the correct page.

Hi @henke37 - I looked a bit closer and I don't think it's that page after all.  So I have no idea what it is referring to!
Is the phrasing blocking you from doing something?  I am tempted to simply remove it.

Nah, it's not blocking me.

Ok, just removed it - thx for the heads-up!


Add Checkstyle plugin (do not fail)

I've set not to fail build (too many files to fix indentation) #63

I think we should fail the build if the style is not correct.
Could you please add a section to readme about this?

yeah, we should.
but should I change ~80 files with wrong indentation in this PR?

yes please, it would be changed anyway.


feat: Migrate trie account type and state root functions from alloy

Migrated trie account type Account and state root functions from alloy-rs/alloy.
Originally I tried to export them form reth to alloy-rs/alloy, but it's better to do that here.
ref: https://github.com/alloy-rs/alloy/pull/1717#pullrequestreview-2470928440

it would be easier if we upstream this to alloy-trie entirely
the trieaccount type + state root functions
could you please open these changes as a pr to alloy-trie
then we import alloy-trie in alloy-genesis and to the from impl there

I wonder why alloy-primitives 0.8.14 is used in the test despite specifying 0.8.5 in Cargo.toml 🤔
https://github.com/alloy-rs/trie/actions/runs/12141835115/job/33856483337
error: rustc 1.79.0 is not supported by the following package:
<EMAIL_ADDRESS>requires rustc 1.81
Either upgrade rustc or select compatible dependency versions with
`cargo update <name>@<current-ver> --precise <compatible-ver>`
where `<compatible-ver>` is the latest version supporting rustc 1.79.0

I wonder why alloy-primitives 0.8.14 is used in the test despite specifying 0.8.5 in Cargo.tom

this has to do with the lockfile

this has to do with the lockfile
fixed on main

Thanks 🙏

@rkrasiuk Introduced ethereum feature gate: https://github.com/alloy-rs/trie/pull/65/commits/7f97f9ce6cdd1e92886ad1b50477a94d639e46fc
Currently, CI is passing except for miri


redirecting to another controller

hi, is it possible to redirect to another uri/controller?
so if the auth token is expired redirect to auth controller

You would use basic PHP redirecting. See http://stackoverflow.com/questions/768431/how-to-make-a-redirect-in-php


fix: addSheet setContext called twice

fix: addSheet setContext called twice when clicking the add sheet button quickly

LGTM

lgtm


extract common part in delete and mark assignment command

Codecov Report

Merging #276 (b6e503c) into master (2e0b51b) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #276      +/-   ##
============================================
+ Coverage     75.92%   75.97%   +0.05%
  Complexity      683      683
============================================
  Files            94       94
  Lines          2002     1998       -4
  Branches        226      223       -3
============================================
- Hits           1520     1518       -2
+ Misses          415      414       -1
+ Partials         67       66       -1

Impacted Files
Coverage Δ

...dress/logic/parser/AddAssignmentCommandParser.java
100.00% <ø> (ø)

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

...ress/logic/commands/AddAssignmentToAllCommand.java
89.47% <100.00%> (ø)

...ddress/logic/commands/DeleteAssignmentCommand.java
100.00% <100.00%> (ø)

.../address/logic/commands/MarkAssignmentCommand.java
100.00% <100.00%> (+11.76%)
:arrow_up:

...rc/main/java/seedu/address/model/ModelManager.java
90.00% <100.00%> (+0.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e0b51b...b6e503c. Read the comment docs.


PR: React Storybook Support

Do you mean React Storybook?
My search found this:
https://github.com/D1plo1d/react-storyboard
http://guigrpa.github.io/storyboard/
https://github.com/storybooks/react-storybook

Yea, my bad. Meant storybook 😂

I don't think anything is needed from this boilerplate. If anyone wants to use it
npm i -g getstorybook
getstorybook

This will automatically add storybook in the existing repo. The user may want to use different plugins and its better to leave it on him.
Just adding in the readme should work.

@amilajack I added storybook support by running getstorybook in the root of the project. Later, when I had to display images, I added following rule to webpack configuration
{
        test: /\.(png|jpg|gif)$/,
        use: [
          {
            loader: 'file-loader',
            options: {}
          }
        ]
      }

I am confused about CSS. When I add a story that involves a component which uses CSS modules of this project, storybook does not work.
What rule do I need to add to make storybook compile CSS modules?

I fixed the issue by adding following rule for CSS.
{
        test: /\.css?$/,
        use: [
          {
            loader: 'style-loader'
          },
          {
            loader: 'css-loader',
            options: {
              modules: true,
              sourceMap: true,
              importLoaders: 1,
              localIdentName: '[name]__[local]__[hash:base64:5]'
            }
          }
        ]
      }


Tree View nested inside of Accordion panel becomes expanded automatically upon panel open

Describe the bug
When the Tree View is nested inside of an Accordion panel having each Tree View node set to not be expanded ([clrExpanded]="false"), every Tree View node becomes visually expanded one the second time that a user clicks to expand the panel that the Tree View is nested within.  Interestingly, this behavior does not occur the first time that a user opens the parent accordion panel.
When
How to reproduce
https://stackblitz.com/edit/clarity-light-theme-v2-fsfysf
Steps to reproduce the behavior:

Go to https://stackblitz.com/edit/clarity-light-theme-v2-fsfysf
Click on the second panel title (i.e. 'Item 2').  This expands the panel and displays the (expected) collapsed Tree View nodes.
Click on the second panel title (i.e. 'Item 2') again.  This closes the panel.
Click on the second panel title (i.e. 'Item 2') for the third time.    This expands the panel and displays the (unexpected) expanded Tree View nodes.
Notice that even though the Tree View nodes are displayed as expanded, their 'expanded' property is still false.

Expected behavior
Each Tree View node having an expanded property should stay collapsed until its respective angle icon is clicked.  Tree View nodes should not be expanded if it resides inside of an accordion panel that gets opened, closed, then opened again.
Versions
App

Angular: ^8.0.0
Node: [e.g. 8.10.0]
Clarity: ^2.0.0

Device:
Happens on any device running Google Chrome.

Type: MacBook, PC
OS: iOS, Windows
Browser chrome
Version 78

Additional notes
Add any other notes about the problem here.

Work around is adding *clrIfExpanded to the <clr-accordion-content> but it seems like theres a little animation glitch where the drawer opens up bigger as if it thinks the tree is expanded then it shrinks back

Work around is adding *clrIfExpanded to the <clr-accordion-content> but it seems like theres a little animation glitch where the drawer opens up bigger as if it thinks the tree is expanded then it shrinks back

Thanks!  I can confirm that this is a work-around and also confirm the slinky effect / animation glitch side effect behavior with using this directive to prevent the unintended expansion of the Tree View nodes.


[Bug] [Performance] TTFT regression from v0.5.4 to 0.6.2

Your current environment

The output of `python collect_env.py`
Collecting environment information...
WARNING 09-27 15:24:15 _custom_ops.py:15] Failed to import from vllm._C with ModuleNotFoundError("No module named 'vllm._C'")
/home/ray/default/vllm/vllm/connections.py:8: RuntimeWarning: Failed to read commit hash:
No module named 'vllm.commit_id'
  from vllm.version import __version__ as VLLM_VERSION
PyTorch version: 2.4.0+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A

OS: Ubuntu 22.04.5 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: Could not collect
CMake version: version 3.30.3
Libc version: glibc-2.35

Python version: 3.10.14 (main, May  6 2024, 19:42:50) [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-6.5.0-1022-aws-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: 12.1.105
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA A100-SXM4-40GB
GPU 1: NVIDIA A100-SXM4-40GB
GPU 2: NVIDIA A100-SXM4-40GB
GPU 3: NVIDIA A100-SXM4-40GB
GPU 4: NVIDIA A100-SXM4-40GB
GPU 5: NVIDIA A100-SXM4-40GB
GPU 6: NVIDIA A100-SXM4-40GB
GPU 7: NVIDIA A100-SXM4-40GB

Nvidia driver version: 535.183.01
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.8.9.0
/usr/lib/x86_64-linux-gnu/libcudnn_adv_infer.so.8.9.0
/usr/lib/x86_64-linux-gnu/libcudnn_adv_train.so.8.9.0
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_infer.so.8.9.0
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_train.so.8.9.0
/usr/lib/x86_64-linux-gnu/libcudnn_ops_infer.so.8.9.0
/usr/lib/x86_64-linux-gnu/libcudnn_ops_train.so.8.9.0
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Address sizes:                      46 bits physical, 48 bits virtual
Byte Order:                         Little Endian
CPU(s):                             96
On-line CPU(s) list:                0-95
Vendor ID:                          GenuineIntel
Model name:                         Intel(R) Xeon(R) Platinum 8275CL CPU @ 3.00GHz
CPU family:                         6
Model:                              85
Thread(s) per core:                 2
Core(s) per socket:                 24
Socket(s):                          2
Stepping:                           7
BogoMIPS:                           5999.99
Flags:                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon rep_good nopl xtopology nonstop_tsc cpuid aperfmperf tsc_known_freq pni pclmulqdq monitor ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid mpx avx512f avx512dq rdseed adx smap clflushopt clwb avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves ida arat pku ospke
Hypervisor vendor:                  KVM
Virtualization type:                full
L1d cache:                          1.5 MiB (48 instances)
L1i cache:                          1.5 MiB (48 instances)
L2 cache:                           48 MiB (48 instances)
L3 cache:                           71.5 MiB (2 instances)
NUMA node(s):                       2
NUMA node0 CPU(s):                  0-23,48-71
NUMA node1 CPU(s):                  24-47,72-95
Vulnerability Gather data sampling: Unknown: Dependent on hypervisor status
Vulnerability Itlb multihit:        KVM: Mitigation: VMX unsupported
Vulnerability L1tf:                 Mitigation; PTE Inversion
Vulnerability Mds:                  Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Meltdown:             Mitigation; PTI
Vulnerability Mmio stale data:      Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed:             Vulnerable
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass:    Vulnerable
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; Retpolines; STIBP disabled; RSB filling; PBRSB-eIBRS Not affected; BHI Retpoline
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Not affected

Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] nvidia-nccl-cu12==2.20.5
[pip3] pyzmq==26.2.0
[pip3] torch==2.4.0
[pip3] torchvision==0.19.0
[pip3] transformers==4.45.1
[pip3] triton==3.0.0
[conda] numpy                     1.26.4                   pypi_0    pypi
[conda] nvidia-nccl-cu12          2.20.5                   pypi_0    pypi
[conda] pyzmq                     26.2.0                   pypi_0    pypi
[conda] torch                     2.4.0                    pypi_0    pypi
[conda] torchvision               0.19.0                   pypi_0    pypi
[conda] transformers              4.45.1                   pypi_0    pypi
[conda] triton                    3.0.0                    pypi_0    pypi
ROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: 0.5.4
vLLM Build Flags:
CUDA Archs: Not Set; ROCm: Disabled; Neuron: Disabled
GPU Topology:
GPU0    GPU1    GPU2    GPU3    GPU4    GPU5    GPU6    GPU7    CPU Affinity    NUMA Affinity   GPU NUMA ID
GPU0     X      NV12    NV12    NV12    NV12    NV12    NV12    NV12    0-23,48-71      0               N/A
GPU1    NV12     X      NV12    NV12    NV12    NV12    NV12    NV12    0-23,48-71      0               N/A
GPU2    NV12    NV12     X      NV12    NV12    NV12    NV12    NV12    0-23,48-71      0               N/A
GPU3    NV12    NV12    NV12     X      NV12    NV12    NV12    NV12    0-23,48-71      0               N/A
GPU4    NV12    NV12    NV12    NV12     X      NV12    NV12    NV12    24-47,72-95     1               N/A
GPU5    NV12    NV12    NV12    NV12    NV12     X      NV12    NV12    24-47,72-95     1               N/A
GPU6    NV12    NV12    NV12    NV12    NV12    NV12     X      NV12    24-47,72-95     1               N/A
GPU7    NV12    NV12    NV12    NV12    NV12    NV12    NV12     X      24-47,72-95     1               N/A

Legend:

  X    = Self
  SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
  NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
  PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
  PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
  PIX  = Connection traversing at most a single PCIe bridge
  NV#  = Connection traversing a bonded set of # NVLinks

Model Input Dumps

V0.6.2 engine args
Initializing an LLM engine (v0.6.1.dev238+ge2c6e0a82) with config: model='meta-llama/Llama-2-7b-chat-hf', speculative_config=None, tokenizer='meta-llama/Llama-2-7b-chat-hf', skip_tokenizer_init=False, tokenizer_mode=auto, revision=None, override_neuron_config=None, rope_scaling=None, rope_theta=None, tokenizer_revision=None, trust_remote_code=False, dtype=torch.float16, max_seq_len=4096, download_dir=None, load_format=LoadFormat.AUTO, tensor_parallel_size=1, pipeline_parallel_size=1, disable_custom_all_reduce=False, quantization=None, enforce_eager=False, kv_cache_dtype=auto, quantization_param_path=None, device_config=cuda, decoding_config=DecodingConfig(guided_decoding_backend='outlines'), observability_config=ObservabilityConfig(otlp_traces_endpoint=None, collect_model_forward_time=False, collect_model_execute_time=False), seed=0, served_model_name=meta-llama/Llama-2-7b-chat-hf, use_v2_block_manager=False, num_scheduler_steps=1, multi_step_stream_outputs=False, enable_prefix_caching=False, use_async_output_proc=True, use_cached_outputs=True, mm_processor_kwargs=None)

V0.5.4 engine args
Initializing an LLM engine (v0.5.4) with config: model='meta-llama/Llama-2-7b-chat-hf', speculative_config=None, tokenizer='meta-llama/Llama-2-7b-chat-hf', skip_tokenizer_init=False, tokenizer_mode=auto, revision=None, rope_scaling=None, rope_theta=None, tokenizer_revision=None, trust_remote_code=False, dtype=torch.float16, max_seq_len=4096, download_dir=None, load_format=LoadFormat.AUTO, tensor_parallel_size=1, pipeline_parallel_size=1, disable_custom_all_reduce=False, quantization=None, enforce_eager=False, kv_cache_dtype=auto, quantization_param_path=None, device_config=cuda, decoding_config=DecodingConfig(guided_decoding_backend='outlines'), observability_config=ObservabilityConfig(otlp_traces_endpoint=None), seed=0, served_model_name=meta-llama/Llama-2-7b-chat-hf, use_v2_block_manager=False, enable_prefix_caching=False)

🐛 Describe the bug
TLDR
We are seeing TTFT regression when upgrading from v0.5.4 to v0.6.2, tldr, on a low QPS/batch size workload, in particularly 15% to 30% TTFT regression on multiple GPUs (A10G, A100) with a small model like llama2-7b-chat-hf
We didn't run more tests on other models, other hardwares, and benchmarks are done with default args mostly:
with benchmark_latency.py
We proxy the TTFT w/o an OpenAI server by running the benchmark_latency.py with ouput_len=1.
Example command:
python benchmark_latency.py   \
--model meta-llama/Llama-2-7b-chat-hf   \
--tensor-parallel-size 1   \
--input-len 512   --output-len 1  \
--batch-size 1   \
--num-iters-warmup 30   \
--num-iters 100

On A10G (avg latency)

vllm==0.5.4: 120ms
vllm==0.6.2: 150ms

On A100:

vllm==0.5.4:  37ms
vllm==0.6.2:  50ms

With benchmark_serving.py
We also profiled with openai server with ShareGPT on a fixed seed at QPS=1. (Reporting 30 requests stats but did run with more requests and the metrics has rather low variance)
Server Command:
vllm serve meta-llama/Llama-2-7b-chat-hf --swap-space 16 --disable-log-requests

Client Command:
python benchmarks/benchmark_serving.py --model meta-llama/Llama-2-7b-chat-hf --dataset-path /tmp/ShareGPT_V3_unfiltered_cleaned_split.json --request-rate 1 --num-prompts 30 --seed 10

On v0.5.4 (✅ )
============ Serving Benchmark Result ============
Successful requests:                     30
Benchmark duration (s):                  31.64
Total input tokens:                      9643
Total generated tokens:                  4572
Request throughput (req/s):              0.95
Input token throughput (tok/s):          304.76
Output token throughput (tok/s):         144.49
---------------Time to First Token----------------
Mean TTFT (ms):                          28.01
Median TTFT (ms):                        27.01
P99 TTFT (ms):                           78.94
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          13.90
Median TPOT (ms):                        13.80
P99 TPOT (ms):                           17.90
---------------Inter-token Latency----------------
Mean ITL (ms):                           14.10
Median ITL (ms):                         13.54
P99 ITL (ms):                            36.50
==================================================

On v0.6.2 (⚠ )
============ Serving Benchmark Result ============
Successful requests:                     30
Benchmark duration (s):                  31.12
Total input tokens:                      9643
Total generated tokens:                  4572
Request throughput (req/s):              0.96
Output token throughput (tok/s):         146.89
Total Token throughput (tok/s):          456.71
---------------Time to First Token----------------
Mean TTFT (ms):                          29.86
Median TTFT (ms):                        31.47
P99 TTFT (ms):                           68.44
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          12.80
Median TPOT (ms):                        12.91
P99 TPOT (ms):                           13.88
---------------Inter-token Latency----------------
Mean ITL (ms):                           13.07
Median ITL (ms):                         12.66
P99 ITL (ms):                            31.47
==================================================

Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

cc @comaniac  @simon-mo @KuntaiDu  lmk if there's anything you need more info - happy to look into this as well.

@KuntaiDu v0.5.4 was released on Aug 5th. Do we have the TTFT data by that time so that we could directly compare against the nightly benchmark results here?

There are a lot of performance differences between these versions. For example:

MQLLMEngine (use zeromq and multiprocessing instead of asyncio in the LLMEngine)
Async output processing

In general, these optimizations slightly sacrifice TTFT in exchange for MUCH better TPOT under heavy load. So I am not surprised to see some slight regression on TTFT for low
You can try disabling these with:

--disable-frontend-multiprocessing
--disable-async-output-proc

However, I would not recommend doing this.

Ok probably expected in this case then. @rickyyx you could verify with Robert's suggestion and feel free to close this issue if that's the case.


Fail the automerge task when a problem occurs e.g. bad credentials

Tiny one, closes https://github.com/rhd-gitops-example/services/issues/110
Tested by using good/bad credentials. With the good credentials it continues to pass and with the bad ones, merge-pr gets to:
+ '[' pull_request = push ']'
+ '[' pull_request = pull_request ']'
+ git config --global --add hub.host github.ibm.com
+ git config --global user.name a-roberts
+ git config --global user.email myemail
+ cd git-source
+ export HUB_VERBOSE=true
+ HUB_VERBOSE=true
+ hub merge https://github.ibm.com/AROBERTS/gitops-example-dev/pull/2
$ git config --get-all hub.host
> GET https://github.ibm.com/api/v3/user
> Authorization: token [REDACTED]
> Accept: application/vnd.github.v3+json;charset=utf-8
< HTTP 401
{"message":"Bad credentials","documentation_url":"https://developer.github.com/enterprise/2.19/v3"}
> GET https://github.ibm.com/api/v3/repos/AROBERTS/gitops-example-dev/pulls/2
> Authorization: token
> Accept: application/vnd.github.v3+json;charset=utf-8
< HTTP 401
{"message":"Bad credentials","documentation_url":"https://developer.github.com/enterprise/2.19/v3"}
Error getting pull request: Unauthorized (HTTP 401)
Bad credentials

Checking this...


Complete Test Data

Get a minimal set of data, to simulate a complete pipeline run.

Thank for creating this issue @bosterholz. I suggest that we do not upload the test data to our github repo. Instead we could later create a bootstrap script which downloads the data from dropbox and runs the necessary tests (e.g unit, BDD, ... tests).

@bosterholz  Currently the cucumber tests are executed with the following data:
https://github.com/metagenomics/bioPipeline/tree/master/features/data
If you agree with this set, please close this Issue. Otherwise please update  the data files and also the feature test: https://github.com/metagenomics/bioPipeline/blob/master/features/nextflow.feature .

Currently, the test files produce only one real hit. There should be at least one hit of each category. I will expand the test files, to fit this criteria.


completion: Add completion for keg-only brewed curl when available

As curl bundled with macOS does not include _curl definitions, one way to make _curl available is to install curl from Homebrew.
However, since curl from Hombrew is keg-only, its function path needs to be explicitly included.

Cool workaround. My only worry is that any call to brew is fairly expensive.

brew --prefix is just shell, and intentionally so. We should be fine.

Nice, glad to see that's been improved since I looked at this last (admittedly quite a while ago)


When used the cancel of calibration plugin class, there is crash!!!

debug the error:
A command cannot be sent if another command with the same command_id is still processing! Ignoring command 241
Mavsdk: Callback called from mavlink_commands.cpp:337 took more than 1 second to run.
when i comment the line:226:
 _parent->send_command_async(command, nullptr);

then work ok!
I want to know why send a nullptr callback before send a normal cancel calibration command?
thanks!

@bkueng

Reading through the code, this seems like a bug indeed. I think this line should not be there.
@SSSnow: Would you mind opening a PR with that change?

@SSSnow: Not sure I understood correctly: will you open a PR with your bugfix? You deserve the credit with the commit :blush:


Force torrent check option

I noticed that after Windows (7) shutdown and start PicoTorrent started automatic check of some torrents (not all).
I wonder if there is an option to force check of particular torrent? Part of the torrent has been downloaded by uTorrent, but import option is not a way for me, since I have too many torrents in uTorrent and going to transfer them one by one.
Maybe using some command line magic?

I noticed for myself (IIRC) that I could force a re-check when the torrent was not at 100%, but now my torrent is downloaded at 100% and I cannot force a re-check. Win7 sp1 x64 client.

Hi! There's no command line trick, sorry. I'll add a permanent option to force recheck in the next version. Thanks for your patience!

Fixed in #522


eqx.Module interaction with optax

Hi,
I've noticed the following behaviour, which I believe is not intended. Not sure if there's any workarounds (or if I'm simply doing things wrong), but here we go:
The function optax.multi_transform expects as a second parameter a PyTree specifying the names for each leaf to link them with the corresponding optimizer. E.g.:
model_mask = jtu.tree_map(..., model)
optimizer = optax.multi_transform({
	'n': optax.sgd(1e-3),
	'w': optax.adam(1e-3)
}, model_mask)

However, if we specify a __call__ function for our model class, optax will treat model_mask as a generating function (I believe), resulting in an error. Is there a workaround for this? Or what I'm trying to achieve should be done in an entirely different way?
Thank you

Yup, this is an unfortunate design choice on Optax's part: at the time Optax was conceived, folks weren't using objects that could be both pytrees and callables. (Then Equinox came along!)

Perfect, thank you!

Perfect, thank you!


text reactions: Allow custom text reactions to messages.

Emoji reactions are a popular way to react to messages, but there are often cases where you can't find an exact emoji to respond to a message.  At least one other chat product (I can't remember which one) supports the concept of text reactions, where you can type a little bit of text to respond to a message, and it gets shown below the message similar to emoji reactions.  This is also an idea that we've independently brainstormed at times, and we have had our own customers ask about them.
It's possible that the "/poll" widget will satisfy the biggest use case for text reactions, so we should be a little cautious about building these.  On the other hand some of the work that went into building the poll widget--such as the submessage infrastructure--will make this feature easier to build now.

@zulipbot claim

Closing as we don't currently plan to work on this idea. Thanks, @showell !


Azure Pipelines Docker Agent downloads prerelease version of azure-pipelines-agent

In step 5 of the Linux Dockerfile setup, the following code from the start.sh  script always grabs the most recent version of azure-pipelines-agent even if it is a prerelease. I have run into bugs with the prerelease version. It would be helpful if this script downloaded the "Latest Release" version as indicated on the github page, instead of downloading the "Prerelease" version.
https://github.com/Microsoft/azure-pipelines-agent/releases
  AZP_AGENTPACKAGE_URL=$(echo "$AZP_AGENT_RESPONSE" \
    | jq -r '.value | map([.version.major,.version.minor,.version.patch,.downloadUrl]) | sort | .[length-1] | .[3]')

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b31d4f6c-d16d-2ba1-1294-6aa94e328046
Version Independent ID: 88aec599-4410-697d-1002-1c41b1c17bb6
Content: Running a self-hosted agent in Docker - Azure Pipelines
Content Source: docs/pipelines/agents/docker.md
Product: devops
Technology: devops-cicd-agents
GitHub Login: @steved0x
Microsoft Alias: sdanie

I don't know if this is similar enough but is it possible for the docker image to be built with a specific version of the agent instead of having it downloaded at runtime?

@ms-lolo , if you want to specify the agent version in the docker image, you can set the AZP_AGENTPACKAGE_URL in the start.sh file. You just have to set the variable below where it is currently being set.
AZP_AGENTPACKAGE_URL="https://vstsagentpackage.azureedge.net/agent/2.166.4/vsts-agent-linux-x64-2.166.4.tar.gz"

@egrubbs so then if I do that I can move this download logic to my docker build step? And I would just need to keep checking back for new versions and any breaking changes and such?

@ms-lolo That's correct.

Perfect thank you :) will give this a try as soon as possible!

@egrubbs say today I bake my own local copy of vsts-agent-linux-x64-2.166.4.tar.gz into my docker image, start it up, on the day 2 my agent updates itself, then on the 3rd day the container restarts itself (from a reboot on the host side for instance), what would happen? would vsts-agent-linux-x64-2.166.4.tar.gz be loaded again or would it load the version I had on day 2?

@frankfuu The start.sh script is specified as the CMD in the Dockerfile, so it runs every time the container starts. If you install the agent in the start.sh, it will go back to the version before the upgrade. If you use RUN or COPY in the Dockerfile to install the initial version, then the upgrade will remain after you restart the container.

Thank you kindly @egrubbs. I wonder why Azure Pipelines team decided to go with the former approach? I've had issues with slow downloads of the vsts-agent-linux-x64-xxx.tar.gz files when I wanted to fire up temporary agents and the solution you provided might be a way forward for us.


Discrepancy between order that should be placed and the order that is actually places (maker.py)

There seems to be an issue in: https://github.com/xeroc/python-graphenelib/blob/master/grapheneexchange/exchange.py
When a bot that implements basestrategy calls self.sell() this get's called:
print(" - Selling %f %s for %s @%f %s/%s" % (amount, quote, base, price, base, quote))
self.dex.sell(market, price, amount)

output:
 - Selling 0.000150 SILVER for BTS @3677.763500 BTS/SILVER
2016-04-17 14:23:41.220941 | Order: 1.7.232305 is 51.499% away from feed

order info:

{
	'expiration': '2016-04-24T14:22:40',
	'deferred_fee': 14676,
	'id': '1.7.232305',
	'sell_price': {
		'quote': {
			'asset_id': '1.3.0',
			'amount': 55166
		},
		'base': {
			'asset_id': '1.3.105',
			'amount': 1
		}
	},
	'for_sale': 1,
	'seller': '1.2.107199'
}

 {
 	'total': 0.55166,
 	'rate': 5516.6,
 	'amount': 0.0001,
 	'type': 'sell',
 	'amount_to_sell': 0.0001,
 	'orderNumber': '1.7.232305'
 }

This issue can be closed, just realised that silver has a precision of 4, that's why 0.00015 becomes 0.0001.


trim querydb dependencies: fix testDistro.sh

Querydb shipped a number of frontends in it's regular classpath, which
is causing problems with the usual suspects log4j/slf4j (see error below).
The main culprit is probably ghidra which ships an older version of log4j
in a fat jar.
Loading base CPG from:
/home/mp/Projects/shiftleft/joern/workspace/c/cpg.bin.tmp
java.lang.NoSuchMethodError: 'java.lang.ClassLoader[]
org.apache.logging.log4j.util.LoaderUtil.getClassLoaders()'
        at
org.apache.logging.log4j.core.impl.ThreadContextDataInjector.getServiceProviders(ThreadContextDataInjector.java:83)
        at
org.apache.logging.log4j.core.impl.ThreadContextDataInjector.initServiceProviders(ThreadContextDataInjector.java:73)
        at
org.apache.logging.log4j.core.impl.ThreadContextDataInjector.getProviders(ThreadContextDataInjector.java:285)

would like to be more helpful, but the only answer i have is "not sure" @mpollmeier


Errors after upgrading rust-analyzer > 2022-12-19

Hello everyone,
I recently starting using rust-tools and rust-analyzer with neovim. At the time of my installation the latest rust-analyzer version was 2022-12-19. Everything worked fine until the next version came up. After I upgraded it via Mason I started getting this error:
Error executing vim.schedule lua callback: ...ker/start/rust-tools.nvim/lua/rust-tools/inlay_hints.lua:216: bad argument #1 to 'sub' (string expected, got table)
stack traceback:
        [C]: in function 'sub'
        ...ker/start/rust-tools.nvim/lua/rust-tools/inlay_hints.lua:216: in function 'render_line'
        ...ker/start/rust-tools.nvim/lua/rust-tools/inlay_hints.lua:260: in function 'render'
        ...ker/start/rust-tools.nvim/lua/rust-tools/inlay_hints.lua:170: in function 'handler'
        ...l/Cellar/neovim/0.8.2/share/nvim/runtime/lua/vim/lsp.lua:1383: in function ''
        vim/_editor.lua: in function <vim/_editor.lua:0>

Downgrading to MasonInstall rust-analyzer@2022-12-19 brings back the functionality. Latest version of rust-analyzer that I tested was 2023-01-02 and it still shows the same error.
Let me know if I am missing something or if I need to provide further information.

Fixed in https://github.com/simrat39/rust-tools.nvim/commit/a47f5d61ce06a433998fb5711f723773e3156f46

Thanks. I can confirm that the fixed that that got merged works for me!

I'm encountering this error again (except on line 211 instead of 216) on rustc 1.68.0


Maybe have Colaboratory Notebook version for the training of models?

I set something up here.  Nice having GPU support in the cloud for those of us with slow processors at home.
maybe include it in the repo?  I almost did a pull request for this.  It would need to be cleaned up and documented better.  Let me know what you think?
https://colab.research.google.com/drive/1vG_cfKEGzdwX64wrBbf9egq2gWijk8Id

There's already an issue tracking this, see https://github.com/ml5js/ml5-data-and-training/issues/8! It would be great if you could contribute to thos @scottleedavis!


topic/use stable memory instead of heap - remove upgradable from snapshot_indexers,relayer,lens to use stable memory

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 62.685%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
4287

Relevant Lines:
6839

💛  - Coveralls


Remove sections from taxonomy sidebar response

The data structure returned by the taxonomy sidebar helper is unnecessarily nested, and the notion of "sections" does not map to our usage (it would always be an array of 1 item, with a title that repeats the current content title).
NB: This is an API-breaking change, so should get a major version bump.
Trello
https://trello.com/c/EJXC60k1/429-add-more-like-this-results-to-side-navigation-in-frontend-apps

LGTM


How to disable SSL pinning in flutter app

Hi,
I am using latest version of flutter(1.5) and dart(>2.0). I came across some  app security testing  and they are requesting to disable the SSL pinning in my app.
I research it but all solution leads to enable.
Can any one help me to disable it.
Thanks
Prashant.

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.

I need to bypass SSL. Any solution?

Could everyone who still has this problem please file a new issue with the exact descriptions what happens, logs and the output of 'flutter doctor -v'  please.
All system setups can be slightly different so it's always better to open new issues and reference related issues.

Hi,
I am using the version of flutter(1.20.1). I came across the same issue the security team is requesting to disable the SSL pinning in my app. but I do not enable the SSL pinning. So how we can disable default SSL pinning from the flutter app.
Here are the dependencies used in App -
dependencies:   flutter:     sdk: flutter   cupertino_icons: ^0.1.2   flutter_bloc_pattern: ^0.0.1+1   provider: ^4.3.1   flutter_spinkit: "^4.1.1"   google_fonts: ^0.2.0   flutter_echarts: ^1.3.5   number_display: ^2.3.0   charts_flutter: ^0.9.0   horizontal_data_table: ^1.0.5+5   search_widget: ^1.0.2   lottie: ^0.5.1   dio: ^3.0.10   xml: ^3.5.0   fluttertoast: ^7.0.2   shared_preferences: ^0.5.8   firebase_crashlytics: ^0.1.4+1   carousel_slider: ^2.2.1   expandable: ^4.1.4   get_it: ^4.0.4   rxdart: ^0.24.1   flutter_secure_storage: ^3.3.3   local_auth: ^0.6.1   webview_flutter: ^0.3.24   flutter_webview_plugin: ^0.3.11   passcode_screen: ^1.2.0   percent_indicator: ^2.1.7+4   url_launcher: ^5.7.6   firebase_messaging: ^7.0.3
And here are the Screenshot shared by the VAPT(Security) team.

Thanks

Could everyone who still has this problem please file a new issue with the exact descriptions what happens, logs and the output of 'flutter doctor -v' please.
All system setups can be slightly different so it's always better to open new issues and reference related issues.

This is not a system-specific issue but something in the APK build. The decompiled APK code shows SSL checks and the security team has asked to disable it.


The future of Keycloak Operator CRs

This has to be merged after https://github.com/keycloak/keycloak-k8s-resources/pull/11

Just a small note. Before merging, I would like a review from a Storage team member to double check the statements are true.

cc @keycloak/storage-x

I think this is accurate but would wait for confirmation from @hmlnarik

I think this is accurate but would wait for confirmation from @hmlnarik

@hmlnarik Ping? :)

@ahus1 Thanks for the review! From my perspective it is clear now that we want to provide CRs for KC business objects, and that we need to provide a similar functionality to the old Operator – i.e. the capability to manage Realms, Clients, ... This is what the users and customers expect. Now, whether it will be really strictly typed CRDs, ConfigMap or some "free-form" CRDs, it's IMHO an implementation detail, as long as it is possible to manage the business objects from K8s environment. And in the blog post we're not stating the CRDs will look the same as with the old Operator.
Does it make sense?

@hmlnarik Can you please confirm the recent changes look good to you?


Preview image is not displayed in safari

I am used react-player in light mode with preview image, and I have a problem with preview image it is not displayed in safari in other brothers everything ok

Sorry i find problem in my code.


Peter Stulpner Tutorial Solution, building package in ROSbuild

Hey, pretty good first attempt, are their ways of using launch file arguments to make the whole thing more concise?
You should also visualize the whole system in ROS rqt to see that it is working as you expect

Hey, cheers haha took a bit of figuring out when you say using launch file arguments do you mean update my current launch file to see if I can make it more concise? I had an idea to have the push nodes as just one node and duplicate in the launch file but I don’t think that makes two topics?
From: Jack<EMAIL_ADDRESS>Sent: 09 April 2020 17:47
To<EMAIL_ADDRESS>Cc: Peter<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [JmcRobbie/JuniorTutorial] Peter Stulpner Tutorial Solution, building package in ROSbuild (#2)
Hey, pretty good first attempt, are their ways of using launch file arguments to make the whole thing more concise?
You should also visualize the whole system in ROS rqt to see that it is working as you expect
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJmcRobbie%2FJuniorTutorial%2Fpull%2F2%23issuecomment-611437529&data=02|01||b3a9ca5ce53f4f223e1608d7dc6b0950|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637220224578480872&sdata=Dl9SzpfdDR4YuxG7f9%2BaYKyMwUISNRHV6QnnmaJJNw8%3D&reserved=0, or unsubscribehttps://eur05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMQLCOREN33VKQL2JUW43W3RLWKTRANCNFSM4MEOB62Q&data=02|01||b3a9ca5ce53f4f223e1608d7dc6b0950|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637220224578480872&sdata=3B3HSOOhSmb1qSnK%2FAC8XFjaolkd78bfq%2FmbvJcIJUw%3D&reserved=0.

@peterstulpner  https://answers.ros.org/question/277622/roslaunch-command-line-args/ take a look at this for inspiration. Your two publisher nodes are essentially the same except for using different numbers.

Awesome cheers, Ill push a new version soon :)
From: Jack<EMAIL_ADDRESS>Sent: 09 April 2020 18:16
To<EMAIL_ADDRESS>Cc: Peter<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [JmcRobbie/JuniorTutorial] Peter Stulpner Tutorial Solution, building package in ROSbuild (#2)
@peterstulpnerhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpeterstulpner&data=02|01||c09f2a8980bc44aa078c08d7dc6f0367|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637220241656515568&sdata=v2vosCmjlUPuUjtP4ggUTWOAn99r%2BoZHf5HXLwbTJZo%3D&reserved=0 https://answers.ros.org/question/277622/roslaunch-command-line-args/https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fanswers.ros.org%2Fquestion%2F277622%2Froslaunch-command-line-args%2F&data=02|01||c09f2a8980bc44aa078c08d7dc6f0367|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637220241656525562&sdata=WUgSvwgyZ4ljrLD6EeyPFQLC339Ov8c%2FcvB06EqS5VI%3D&reserved=0 take a look at this for inspiration. Your two publisher nodes are essentially the same except for using different numbers.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJmcRobbie%2FJuniorTutorial%2Fpull%2F2%23issuecomment-611449481&data=02|01||c09f2a8980bc44aa078c08d7dc6f0367|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637220241656525562&sdata=38%2BKJUaztYWJQkK1zUrzMXknl24xI4TTea5crHlQU%2FI%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMQLCOVHXP352MKULKQVQETRLWN6JANCNFSM4MEOB62Q&data=02|01||c09f2a8980bc44aa078c08d7dc6f0367|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637220241656525562&sdata=dsdMDt8N45RyuZNxzWqs6FBQJ3VMd58%2FVBDsWpXKqaA%3D&reserved=0.


Move static BMSByte data from UDPPacketSequence

Version Number and Operating System(s)
Develop branch (all operating systems)
Expected behavior
The static data field should be per-networker and not global
Actual behavior
It is a global variable and so it does not work well with multiple threads
Steps to reproduce
No steps required

Now in the develop branch


Fix dependabot examples

Why:
Closes #23383

What's being changed (if available, include any code snippets, screenshots, or gifs):

Fix deprecation warning message
GH Action should use just main version

Check off the following:

[ ] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[ ] For content changes, I have completed the self-review checklist.

@Rotzbua Thanks so much for opening a PR! I'll get this triaged for review :zap:


Amaranth and forastero?

Is there an easy way to combine the two tools? Amaranth has simulation support but it would be great to use forastero+cocotb as it's a richer solution. I could just use amaranth to generate verilog and test on that but better integration would be much nicer.

This is a really interesting question - I'm not very familiar with Amaranth and its simulation engine, but I'd be interested to find out. Forastero leverages cocotb primarily as a simulator interface, it might be possible for Amaranth to just interface directly rather than through the intermediate layer.
Would this be something you'd be able to help us investigate?

I'm not sure how much time I can put in but I'll look into it a bit to try and at least get some estimates on level of effort. The amaranth simulation engine does have some nice features and it's pretty clean for basic testing and for formal verification. I'll poke at it a bit over the next week or so and see what I come up with.


Move to use python logger

Currently, all the output uses print(...). I would like to move then to use logger class provided by python which can allow for different levels such as DEBUG, INFO etc...
Example of places where print should be replaced:
https://github.com/benwoo1110/testcase-maker/blob/ba1e18bcaa0c2aa11af6f2d37fecb6d2d64120ec/testcase_maker/generator.py#L77

Hi! Please do consider assigning this task to me. I would like to work on it.

Sure, assigned to you.


CI: Extract duplicated InChI compilation step into composite action

https://github.com/IUPAC-InChI/InChI/blob/951cd6681237770e1428b097fd778180a8b49f19/.github/workflows/ci.yml#L24-L32

Closing with 4f218c2caa5cf61ba97464ff1b3febf425db45c9.


error fetch in use react-native

(node:4224) PromiseRejectionHandledWarning: Promise rejection was handled asynchronously (rejection id: 55)
Error: connect ECONNREFUSED <IP_ADDRESS>:34712
at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1097:14)
::ffff:<IP_ADDRESS> - - [20/Jun/2019:11:13:01 +0000] "POST /symbolicate HTTP/1.1" 500 - "-" "okhttp/3.12.1"
(node:4224) UnhandledPromiseRejectionWarning: Error: connect ECONNREFUSED <IP_ADDRESS>:34712
at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1097:14)
(node:4224) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 56)
(node:4224) UnhandledPromiseRejectionWarning: Error: connect ECONNREFUSED <IP_ADDRESS>:34712
at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1097:14)
(node:4224) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 57)

Please provide more description and reproducible demo code so we can investigate further. I'll re-open it once we have enough information. Thank you


[BUG] "The request signature we calculated does not match the signature you provided." error on AOS benchmark query step

Describe the bug
I am using the OSB 1.1.0 to run Amazon OpenSearch benchmarks, it can create, ingest index, but got error at the query step.
I found the search api call in OSB is using GET method, but in the documentation https://docs.aws.amazon.com/opensearch-service/latest/developerguide/searching.html#searching-dsl, it says:
The _search API accepts HTTP GET and POST for request body searches,
but not all HTTP clients support adding a request body to a GET request. POST is the more universal choice.

Similar issue: https://stackoverflow.com/questions/69869225/why-do-i-get-the-request-signature-we-calculated-does-not-match-the-signature-y/69913289#69913289
So I am wondering if we need update search call with POST method?
 Check your AWS Secret Access Key and signing method. Consult the service documentation for details.\\n\\nThe Canonical String for this request should have been\\n\'GET\\n/target_index/_search\\n_source=%7B%27exclude%27%3A%20%5B%27target_field%27%5D%7D\\nhost:search-parallel-cluster-test-1-at6awh3ezbtu6ulpzfhe24ajxq.us-east-1.es.amazonaws.com\\nx-amz-date:20231016T193340Z\\n\\nhost;x-amz-date\\n7fb889f588571c30fb35ec33f6f8dd197646ddce965897a634974f5f2966ac83\'\\n\\nThe String-to-Sign should have been\\n\'AWS4-HMAC-SHA256\\n20231016T193340Z\\n20231016/us-east-1/es/aws4_request\\n296da7b40dee9447d15005b57776c2f80ca412c3d08f1cff9fe1ab7dba193a8f\'\\n"}'

More Context (please complete the following information):

Workload

https://github.com/opensearch-project/k-NN/blob/main/benchmarks/osb/workload.json
https://github.com/opensearch-project/k-NN/blob/main/benchmarks/osb/procedures/no-train-test.json

Service: AOS
Version 2.9

Additional context
Add any other context about the problem here.

@IanHoang I tested the opensearch-py client with a simple python script and found out that this is an issue with OSB only, as the below script ran successfully
from opensearchpy import OpenSearch, RequestsHttpConnection, AWSV4SignerAuth
import boto3

host = '<DOMAIN-NAME>' # cluster endpoint, for example: my-test-domain.us-east-1.es.amazonaws.com
region = 'us-east-1'
service = 'es' # 'aoss' for OpenSearch Serverless
credentials = boto3.Session().get_credentials()
auth = AWSV4SignerAuth(credentials, region, service)

client = OpenSearch(
    hosts = [{'host': host, 'port': 443}],
    http_auth = auth,
    use_ssl = True,
    verify_certs = True,
    connection_class = RequestsHttpConnection,
    pool_maxsize = 20
)

print(client.info())

index_name = 'test-index'
print("Creating index")
print(client.indices.create(index_name))

q = 'miller'

query = {
    'size': 5,
    'query': {
        'multi_match': {
            'query': q,
            'fields': ['title^2', 'director']
        }
    }
}

response = client.transport.perform_request("GET", f"/{index_name}/_search", body=query)

# response = client.search(
#     body = query,
#     index = index_name
# )

print('\nSearch results:')
print(response)

print("Deleting Index")
print(client.indices.delete(index_name))

@junqiu-lei Is this still an issue you're experiencing?

I don't see this issue in latest version OSB @IanHoang


raft: add DisableProposalForwarding option

this allows users to disable followers from forwarding proposals to the
leader.
Contributing guidelines
Please read our contribution workflow before submitting a pull request.

@smetro Can you explain your use case and motivation for doing this (I can guess I why, but we need to keep the record here). Also we need to document the option better. So users know when they want to enable this feature.

The use case is that when a node in my Raft cluster receives a client request I add an HLC timestamp to the request before passing the data to node.Propose(). That timestamp needs to be computed by the Raft leader so that it remains monotonically increasing (I maintain monotonicity after a failover by advertising these HLC timestamps from the leader to the followers, so that a new leader starts from a valid HLC timestamp). If a follower adds the timestamp and forwards it to the leader, the leader can't update the timestamp before creating the AppendEntry request.

Will close/reopen to try to retrigger the 'continuous-integration/travis-ci/pr', since I've removed whitespace from the commit message.

Will close/reopen to try to retrigger the 'jenkins-cov', since https://github.com/coreos/etcd/issues/7980 is closed.

I am fine with merging this after providing an example use case in the comment. thanks!

Thanks, I added a comment trying to explain the use case, please let me know what you think.

LGTM. Can you squash the two commits into one?

Thanks, I have squashed them.


[KARAF-4997] Generator: merge dependency information

In the generator, feature dependencies added from POM entries are
checked against existing dependency information (e.g. from
pre-existing feature.xml stubs). Matching entries are preserved and
the information merged: this allows versions to be determined from the
POM, and dependency/prerequisite flags to be defined in feature.xml.
Signed-off-by: Stephen Kitt<EMAIL_ADDRESS>

R: @jbonofre


Fluttertts not working in ios

Steps to reproduce
I am using fluttertts package in my project which takes data from firebase and pass to fluttertts.
It is working fine for android devices and its emulator but not working fine for ios emulator and ios devices
I am using ios 17.2 emulator for this
My minimum ios platform is set to 12.0 like this  platform :ios, '12.0'
I had created a new project for testing fluttertts and my emulator and it works fine with it
Expected results
I want fluttertts to speak all words and sentences.
Actual results
But fluttertts is only speaking dot, comma, exclamatory dot or some other symbols
Code sample
Code sample
import 'dart:async';
import 'package:cloud_firestore/cloud_firestore.dart';
import 'package:flutter/material.dart';
import 'package:flutter_tts/flutter_tts.dart';

class Transliterate extends StatefulWidget {
  final String _storyID;
  final String o_text;
  final FlutterTts flutterTts ;

  Transliterate(this._storyID, this.flutterTts, String o_text) : o_text = o_text;

  @override
  _TransliterateState createState() => _TransliterateState();
}

enum TtsState { playing, stopped, paused, continued}

class _TransliterateState extends State<Transliterate> {
  CollectionReference stry = FirebaseFirestore.instance.collection('stories');
  String? txt;
  String? language;
  double volume = 0.5;
  double pitch = 1.0;
  double rate = 0.5;

  TtsState ttsState = TtsState.stopped;

  get isPlaying => ttsState == TtsState.playing;
  get isStopped => ttsState == TtsState.stopped;
  get isPaused => ttsState == TtsState.paused;
  get isContinued => ttsState == TtsState.continued;

  Future _speak() async {
    await widget.flutterTts.setVolume(volume);
    await widget.flutterTts.setSpeechRate(rate);
    await widget.flutterTts.setPitch(pitch);

//for testing
    // FlutterTts flut = FlutterTts();
    // String text = "एका जंगलात एक छोटं जलाशय होतं त्यामध्ये एक बेडूक राहत होता त्याला एकटेपणा जाणवत होता त्यासाठी.";
    // await flut.setLanguage("mr-IN");
    // await flut.setVolume(0.5);
    // await flut.setSpeechRate(0.5);
    // await flut.setPitch(1);
    // await flut.speak(text);
    // print(text);

    if (language == "Gujarati") widget.flutterTts.setLanguage("gu-IN");
    if (language == "Bengali") widget.flutterTts.setLanguage("bn-IN");
    if (language == "Telugu") widget.flutterTts.setLanguage("te-IN");
    if (language == "Marathi") widget.flutterTts.setLanguage("mr-IN");
    print(language);
    await widget.flutterTts.awaitSpeakCompletion(true);
    var result = await widget.flutterTts.speak(txt!);
    if (result == 1) setState(() => ttsState = TtsState.playing);
  }

  Future _stop() async {
    var result = await widget.flutterTts.stop();
    if (result == 1) setState(() => ttsState = TtsState.stopped);
  }

  Future _pause() async {
    var result = await widget.flutterTts.pause();
    if (result == 1) setState(() => ttsState = TtsState.paused);
  }

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.19.5, on macOS 14.4.1 23E224 darwin-arm64, locale en-IN)
    • Flutter version 3.19.5 on channel stable at /Users/shankarnath/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 300451adae (12 days ago), 2024-03-27 21:54:07 -0500
    • Engine revision e76c956498
    • Dart version 3.3.3
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/shankarnath/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.88.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.86.0

[✓] Connected device (3 available)
    • iPhone 15 Pro (mobile) • 820360F1-C137-4187-A687-FDDD4C9FF3FE • ios            • com.apple.CoreSimulator.SimRuntime.iOS-17-2 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 14.4.1 23E224 darwin-arm64
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 123.0.6312.107
    ! Error: Browsing on the local area network for Pravindra’s iPhone. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)
    ! Error: Browsing on the local area network for iPhone. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)

[✓] Network resources
    • All expected network resources are available.

• No issues found!

flutter_tts is a third-party plugin. Any issues you face using it should be reported on their repo https://github.com/dlutton/flutter_tts
Closing from here
Thank you


Where is the server source code itself?

Hi,
Where is the server source code itself that this API interacts with?
Thanks.

It's private.

Is there any reason for keeping it private?
What do we don't want to leak to the outside world?


support for multiple client_id

On SessionController#create a new client_id is generated for a every successful login. But the docs states:

Client: This enables the use of multiple simultaneous sessions on different clients. (For example, a user may want to be authenticated on both their phone and their laptop at the same time.)
link

I'm missing something or how is suppose to use this param ?
TIA

@kascote Did you figure this out?

After you signed in, server returns headers. Just use access-token, client and uid. Or you meant something else? I don't get your question.

@kascote , The issue is that I am not able to keep multiple sessions alive. If I login from my laptop  and then login using my phone, I get logged out from the laptop. At any time, I can have only one session alive for the user.
How do you allow user to be authenticated from phone and laptop simultaneously?

@ashwinputhige
I don't really know why it's not working for you, but look at demo here. It's working fine.

Not sure if it can help you
https://github.com/lynndylanhurley/devise_token_auth/issues/680

Seems like we have a solution for this, so closing for now.


Make default resubmit blank

Codecov Report

Merging #41 (ecba3d9) into master (ab8b430) will decrease coverage by 0.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   61.32%   60.92%   -0.40%
==========================================
  Files         115      115
  Lines        9861     9861
==========================================
- Hits         6047     6008      -39
- Misses       3814     3853      +39

Impacted Files
Coverage Δ

assemblyline/odm/models/submission.py
84.09% <100.00%> (ø)

assemblyline/common/backupmanager.py
60.16% <0.00%> (-16.19%)
:arrow_down:

assemblyline/datasource/alert.py
88.46% <0.00%> (-3.85%)
:arrow_down:

assemblyline/odm/randomizer.py
95.75% <0.00%> (+0.47%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab8b430...ecba3d9. Read the comment docs.


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 3.0.54 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Bug Report]: veinminer is breaking blocks in areas protected by worldguard

Spark link
https://spark.lucko.me/eD8f9hzTd4
Server Version
1.20.1
Server Platform
Paper
Describe the bug
One of the players on my server discovered that he can collect ores with the veinminer pickaxe in protected areas with RG FLAG BUILD, RG FLAG BLOCK BREAK and RG BLOCK PLACE DENY from world guard...
Steps to reproduce

go to server
protect area protect area with world guard refusing build access and refusing blockbreak access (/rg flag  build deny) (/rg flag  blockbreak deny)
enchant 5 pickaxes, each with different veinminer, example veinminer I, veinminer II, Veinminer III, veinminer IV and veinminer V.
place a piece of ores, around 4 ores to 7 iron/coal ores and break.

It won't break them all, but it will break a protected block
Additional context
No response
Agreements

[X] I have searched for and ensured there isn't already an open issue regarding this.
[X] I ticked all the boxes without actually reading them
[X] My version of Minecraft is supported by CrazyCrew.

Try https://discord.com/channels/182615261403283459/196107873397374976/1152032473732087808

I couldn't open the link sent


Fixed S3 Delete bug due to read-after-delete inconsistency

Previously, we would repetitively list->delete until the list came back empty. This did not work for >1000 objects since S3 does not guarantee read-after-delete consistency. The result was an error from S3.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:jchorl/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:jchorl/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

[Current coverage][cc-pull] is 52.46%

Merging [#1806][cc-pull] into [master][cc-base-branch] will decrease coverage by 6.86%

@@             master      #1806   diff @@
==========================================
  Files           120        120
  Lines         10468      10471     +3
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           6211       5494   -717
- Misses         3424       4237   +813
+ Partials        833        740    -93

[][cc-pull]

Powered by Codecov. Last updated by [5f7f871...55a8c69][cc-compare]
[cc-base-branch]: https://codecov.io/gh/docker/distribution/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/docker/distribution/compare/5f7f871d8fb8af84fab624953a587c2b4140e920...55a8c6937165fe0cb4d0e93f02aa185114df6377
[cc-pull]: https://codecov.io/gh/docker/distribution/pull/1806?src=pr

Closing for #1807


Replacing StaticMember with isStatic field in Attribute and Operation

Codecov Report

Merging #80 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage    94.6%   94.59%   -0.02%
==========================================
  Files          95       94       -1
  Lines         797      795       -2
==========================================
- Hits          754      752       -2
  Misses         43       43

Impacted Files
Coverage Δ

lib/org/chromium/webidl/ast/MemberData.js
100% <ø> (ø)
:arrow_up:

config/files.js
100% <ø> (ø)
:arrow_up:

lib/org/chromium/webidl/ast/Operation.js
100% <100%> (ø)
:arrow_up:

lib/org/chromium/webidl/Parser.js
95.49% <100%> (+0.04%)
:arrow_up:

lib/org/chromium/webidl/ast/Attribute.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4801f0...d5a0230. Read the comment docs.


Update remote names

Update remote names in the docs. Resolves #125.

@tomvothecoder This is ready for review. Hopefully I haven't mixed up any <fork-origin> and <upstream-origin> references. I ran git grep origin and git grep upstream in docs/source and it looks like I updated everything that needed to be updated.
(Note that #127 will make more substantial changes to the release steps)


cnl::floor

floor operation is now in cnl::_impl::fp::floor
Would it make sense to define that in cnl::floor rather than under _impl::fp?
I have actually uses for floor operation in fixed-point code and digging that out from cnl::_impl::fp::floor is a bit ugly.
    template<class Rep, int Exponent>
    constexpr inline Rep floor(fixed_point<Rep, Exponent> x) {
        return Rep { (_impl::to_rep(x)) >> -Exponent };
    }

Now that the rounding work is progressing, is this functionality available through conversions?


APT whitelist request for docbook-simple in trusty

docbook-simple is used to build the documentation for neomutt and mutt (email clients)
This package used to be approved (my builds succeeded yesterday).

My build works again today.  Sorry for the noise.


Is it planned to increase the max file size from 100KB?

Currently, I have difficulties with a couple of more than 100 KB files I'd really need to use the extension for. I tried to look for other alternatives but I have other essential ones which have a dependency on it.

Cannot uninstall 'Lua' extension. 'WoW API' extension depends on this.

Oops, just found the preload setting. I missed it.


Translation fails silently when the key contains a dot '.' character

Hey,
firstly thanks so much for this package, saved me a headache.
As to the issue i can elaborate, add tests, reproducement scenarios and contribute later, but I want to point out that it seems to be when i tried using your package for some longer texts having them as keys, like full sentences, whenver there was a . in the key it would fail.
Example:
index.ts:

{t('A long sentence with some words, divided with a comma')}

{t('A long sentence with some words. Divided with a dot')}

gb.json:
{
  "A long sentence with some words, divided with a comma": "Comma translation",
  "A long sentence with some words. Divided with a dot": "Dot translation"
}

Outputs:
Comma translation
A long sentence with some words. Divided with a dot

While I expected:
Comma translation
Dot translation

The problem is especially concerning that there is no error message, not in the console, not anywhere about not finding the key, or that the key in the JSON contains what I might assume are disallowed characters. I also guess that the dot is reserved for drilling down the objects in the JSON, right? I didn't find that mentioned in the documentation and it left me confused.

Hi zmilonas,
Thank you for reaching out.
Yes, you refer nested keys with a dot: "nested.key" for {nested: { key: "value" }. If there is no value for a key, the module returns the key so you dan see where you are missing translations.
I updated the documentation to clarify this behaviour.
Cheers!