fix: git remote SSH url for Azure | BE

Description
Users were not able to add Git SSH URLs from some providers. This fixes the BE aspects of this issue.

Fixes #12891
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested using JUnit test cases
Manual testing from UI

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

@abhvsn The failing case is already covered here - https://github.com/appsmithorg/appsmith/blob/08aab73cba60e24f1dc44787742982b1a6616c55/app/server/appsmith-server/src/test/java/com/appsmith/server/helpers/GitUtilsTest.java#L61

@abhvsn The failing case is already covered here -
https://github.com/appsmithorg/appsmith/blob/08aab73cba60e24f1dc44787742982b1a6616c55/app/server/appsmith-server/src/test/java/com/appsmith/server/helpers/GitUtilsTest.java#L61

Shouldn't we do the same for isRepoPrivate method?

#12891

The failing case is git@ssh.dev.azure.com:v3/hubglobalnz/HubGlobal/AppSmith. This is covered in the test that was added.

@abhvsn The failing case is already covered here -
https://github.com/appsmithorg/appsmith/blob/08aab73cba60e24f1dc44787742982b1a6616c55/app/server/appsmith-server/src/test/java/com/appsmith/server/helpers/GitUtilsTest.java#L61

Shouldn't we consider the updated regex for other methods in utils class?

The failing case is git@ssh.dev.azure.com:v3/hubglobalnz/HubGlobal/AppSmith. This is covered in the test that was added.

/ok-to-test sha=08aab73

/ok-to-test sha=426b120


Set Timeout on checking for new next.js update

Feature request
Is your feature request related to a problem? Please describe.
My app fails to load sometimes because of my bad network; it keeps checking for update and nothing comes up.
Describe the solution you'd like
Add a setTimeout to maybe 10s, and state newer versions could not be fetched due to the faulty/bad connection.
Describe alternatives you've considered
I usually turn off my network totally.
Additional context
Null.

For those that want to contribute, check this out: https://github.com/zeit/next.js/blob/73a55d7a921f93b1f2b677755a1432675de64c1d/server/index.js#L120

Closing as I've figured the fix in Canary(bumping update-check to 1.5.2) as they added a timeout over there :vulcan_salute:

Cool one. Thanks, @timneutkens :tada:


Missing keys in model

https://github.com/microsoft/azure-devops-python-api/blob/451cade4c475482792cbe9e522c1fee32393139e/azure-devops/azure/devops/v6_0/pipelines/models.py#L67
The documentation for creating a pipeline is missing several required keys in the pipeline configuration.

E                   Parameter name: Path

Duplicate of https://github.com/microsoft/azure-devops-python-api/issues/432


Reagents need prices for cargo

Even if we don't balance it having support now would be good.

For reference, this should look something like a price per unit on the reagent type. That way when cargo sell something it takes into account the container cost as well as the total value of the units within.

99% of reagents should also not have a price because uhhh chem dispenser oversupply moment

we support this


Add contrib action for OHI release (NR-83896)

There is a workflow that is common for all the OHIs that it would be useful to have standardized in a single action.
This contribution enables an action and a script to run locally that includes all the actions that are common to the release of an OHI.
This PR is in draft as I must have the code uploaded to be able to test it in antoher repository. Test was a success: newrelic/nri-kafka#207

Notes
To test the script of this branch, instead of the command from the readme that pointes to the main v1 tag, you can test with curl -L https://raw.githubusercontent.com/newrelic/release-toolkit/feat/contrib/ohi-release/contrib/ohi-release/run.sh | bash

Blocked by #139

Rebased :)


Improve Docker image domain resolution

The logic should be something on the lines of:

TL;DR: The hostname must contain a . DNS separator, a : port separator, or the value localhost before the first /. Otherwise the code assumes you want the default registry, Docker Hub. [docker.io]

Ref: https://stackoverflow.com/a/37867949
As an extra detail, the laituri package should expose the Docker image name parsing as a function in such a way that at least the domain could be resolved when used (other parts and the exact structure are left to the implementer.)
Might also consider the term domain as it can also contain the :port, registry_address maybe?

Fixed by #19, released in v0.3.0.


switching to use UBI 8 base image

Switching to use UBI 8 as the base image.
Tested this running as a container in OpenShift for both check container and check operator
fixed #241

Thanks @acornett21!


Video framerate bug in new version

Hello, I installed the new version today and I noticed that my broadcast is progressing very fast. As a result of my reviews, I realized that the video frame rate is 1000 FPS instead of 60.00 FPS.

Please attach the log file.

Closed due to inactivity.


Problem with "insecure origins".

When we try to access the "Notification API" or devices such as a camera or microphone, we get the following error messages.
Notification API:
The Notification API may no longer be used from insecure origins. You should consider switching your application to a secure origin, such as HTTPS.
Devices:
TypeError: Cannot read property 'enumerateDevices' of undefined

Hi @peerem!
Can you add information about the operating system you're using and share some example code?
I have looked into the problem a little bit and here is what I found.
I checked https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts for more information about the secure context. According to their documentation window.isSecureContext is used to determine whether the document is loaded in a secure context.
On macOS, I can determine that the Security Context is secure window.isSecureContext === true.
The problem seems to be, that when you try to get permission as seen in this example MDN Notification API Example, there's nothing that can open a dialog for the user to accept notifications.
The path forward seems to be to integrate the native notification APIs on the OS level.
For macOS that would start here: https://developer.apple.com/documentation/usernotifications?language=objc
Similarly, other APIs might have to be implemented in a similar way.
Alternatively, there might be a way to integrate a permission dialog like this one from Firefox. That is tbd though.

Something for our roadmap.

Accidentally closed ticket.

We are currently testing it under Windows, as there are still known problems under Linux and MacOS that have already been reported. We are testing the move from Chromely to Photino to eliminate the http and SignalR layers in the communication between browser and app.
The Notification API is a nice to have, but we also have built-in toasts in case someone declines notifications. Access to the camera and microphone are essential.
We finished our code as Blazor WebAssembly first, but handling many peer-to-peer connections requires multithreading. Everything works fine as a Blazor Server, except that the Notification API is not integrated in the CEF (used by Chromely). Access to the camera and microphone can easily be activated as parameters.
Here are the Typescript lines of code that work without any problems in the "normal" browser, but cause problems here:
Ask for notification permissions:
    public async requestPermission()
    {
        await Notification.requestPermission().then(permission => this.notificationsAllowed = permission == 'granted');
    }

Look for available devices:
    public async hasConnectedDevices(type: MediaDeviceKind): Promise<boolean>
    {
        var result: boolean = false;

        try
        {
            const devices = await navigator.mediaDevices.enumerateDevices();
            result = devices.filter(device => device.kind === type).length > 0;
        }
        catch (ex)
        {
            result = false;
            HF.logToConsole(ex, true);
        }

        return result;
    }

We found this when we did a quick search, but aren't experts on WebView2(Core?):
https://docs.microsoft.com/en-us/dotnet/api/microsoft.web.webview2.core.corewebview2permissionkind?view=webview2-dotnet-1.0.774.44

Adding a helpful link for development: https://docs.microsoft.com/en-us/microsoft-edge/webview2/reference/win32/icorewebview2?view=webview2-1.0.774.44#add_permissionrequested

My company is also evaluating Photino.NET and we have a very similar requirement, but for us, as the application is going to be installed as a kiosk application, it would be ideal if the browser could be configured to have all permissions allowed - without prompting the user.

We have just released v2 of Photino, however this did not yet make it into v2.
We are still keeping this on our ToDo list for features.


Manual Merge - Adding Coingecko and CMC listing #20595

I'm submitting a ...
[ ] bug report
[X ] feature request
[ ] question about the decisions made in the repository
[] question about how to use this project
Automerge error for pull request - Adding Coingecko and CMC listing #20595
Other information
I am adding coingecko and coin market cap listing.
Can you please assist me with this?

merged


Set long_description in setup.py

This fixes a warning reported by make dist-check:
Checking dist/csp-0.0.1.tar.gz: PASSED with warnings
WARNING  long_description_content_type missing. defaulting to text/x-rst.
WARNING  long_description missing.

This shouldnt be required as it will pick it up from pyproject.toml.

https://github.com/Point72/csp/pull/107


Visibility section, list of books

Includes now all books from #243 . Still one PR for the two sections. Do you want me to redo it?

Well, now this PR duplicates all the parts of #286, so we can't have both. I'll close the other one.

These LGTM. Over to @ThanosBaskous


[Bug] Positional Mode does not work on this branch

Describe the bug
This module does not work for me. I install it and it appears to never load. The never has any rotated modules. However, if I remove this and install the barnabycolby/MMM-Carousel that one works just fine with the same configuration. Very odd, any ideas why?
Configuration
{
module: "MMM-Carousel",
config: {
transitionInterval: 10000,
ignoreModules: ["clock"],
mode: "positional",
bottom_right: {enabled: true, ignoreModules: [], overrideTransitionInterval: 15000}
}
}

I'm not sure. 99% of the changes I've made have been associated with the "slides" mode, but I very well could have broken something in the process.  If you are just using the positional rotations, you may be better off sticking with barnabycolby's version until I have an opportunity to test.
Is there a specific feature from my fork you were trying to get working (navigation buttons, etc)?

No not really any specific reason to use your module other than the fact that it had a few more features. I don't plan on using those features now so I am ok with the barnabycolby version at this time.

Hi,
Same problem her, regardless the configuration, barnabycolby's module is working but I cannot manage to run your's.
Maybe a problem from Electron that I have rebuild for MMM-AssistantMk2 ?

Hi, Same here, but even the barnabycolby version meets the issue.
Btw, thanks for always being active on this project.

I'm having this issue as well. I'm pretty sure the barnabycolby version has the same issue as well.
here is my config
module: "MMM-Carousel",
position: "bottom_center",
config: {
        transitionInterval: 20000,
        ignoreModules: ["clock", "updatenotification", "alert"],
        mode: "positional",
        bottom_center: {enabled: true}
}

@mlcampbe I added a position to your config, than it works for me:
  {
    module: "MMM-Carousel",
    position: "bottom_center",
    config: {
      transitionInterval: 10000,
      ignoreModules: ["clock"],
      mode: "positional",
      bottom_right: {enabled: true, ignoreModules: [], overrideTransitionInterval: 15000}
    }
  },

That doesn't match the documentation. I'm not that into the code so I'm not sure if we should update the documentation or this is a buggy behavior.

@KristjanESPERANTO
Thank you. Sorry. Didn't know that "ignoreModules: []" was required

I'm closing this issue. The missing position can be dealt in issue #37.


Create singly linked list

Write a menu driven program to perform the following operations on a Singly Linked list.

Insert 2. Insend 3. Insat 4. Delete 5. Reverse 6. Search 7. Sort 8. Count 9. Display 10. Exit

the code won't work until you frame it properly, give proper indentation and let me know!


fix ECS instance detection when loading credentials from instance metadata

Fixes #199
Also improves deserialization and overall from_instance_metadata function structure.
Note: this changes the behavior of the deserialization in that it will error if any of the expected fields are missing, while it would pass them only if present without erroring with the previous implementation. (I believe this is the proper thing to do as it seems these fields are always supposed to be returned by the corresponding queries, and it would be a silent fail otherwise.)

@Ten0 thank you for the contribution, I'll make sure to merge and publish a new version promptly

Note: we're currently using the fork in production, so this works.

up

up


Six suggested improvements

One year after discussing, finally I managed to access GitHub to make the suggested changes.
Unfortunately, some files are marked by Git as completely changed, although I updated only a few lines - I still did not find out why and when this happened and how I can prevent this. (I guess that it is related to line breaks.)
Suggested Changes (ordered by the five commits)

ContainsIgnoreCaseValidationMatcher: this is a bug. The change is just a few characters in line 31 - I don't know why Git thinks that I have replaced the whole file.

TestCase: some suggestion to add variables that can be used in logging.

RandomStringFunction: Here I just removed one "System.out.println" line - again the file is marked as completely replaced :-(.

A slight modification in five classes related to Groovy scripts. These changes enabel to have a combination of file based scripts and inline scripts. This is helpful if there are reusable parts that should be applied in multiple Groovy scripts (such as helper methods, making use of context variables), but still it is intended to keep the main Groovy script directly in the test case.

I included parameter TestContext in the methods of interface TestActionListener. This has no immediate impact, but it is helpful when you want to include more logging information in some custom logger - we use this and the second improvement in order to make the log more readable in case of parallel execution of tests. (For performance reasons, we run always 20 threads in parallel, and the default logging is completely unreadable in such a case - we needed to include in each log line information about the test case which this line refers to.)

In TestContext, I used ConcurrentHashMap rather than LinkedHashMap to store context variables. LinkedHashMap is not thread safe. If a test case has parallel actions, and one thread adds a variable leading to an increase of capacity of LinkedHashMap, while another thread tries to read variables, this leads sporadically to a "Unknown variable" exception. This is fixed by using the thread safe ConcurrentHashMap.

These changes are included in our Citrus test (based on Citrus 1.3.1). It would be gread to include them in version 1.4, so that we can reduce our customizations (and others can use them as well).
No further changes are planned in the near future ;-).

Closed as contributions were merged manually, thanks again!


[C++] as-of-join backpressure for large sources

Describe the enhancement requested
Add backpressure support to as-of-join in order to handle large sources. This is a merge into master of (at least most of) https://github.com/westonpace/arrow/pull/21/files
Component(s)
C++

cc @westonpace @icexelloss

@rtpsw Do you remember what the patch is supposed to do? What about "large sources" doesn't work before the PR and how does the PR fixes that? It has been a while and I don't quite remember and the original PR doesn't seem to have too much context either.

In Acero it's the sending nodes that push data rather than the receiving nodes that pull it, so a large source can blow up the as-of-join queues (and other data structures) by pushing faster than some other source, whose lagging prevents the as-of-join node from clearing entries from memory. With this PR, as-of-join would use backpressure to hold up the faster source in order to keep memory usage within bounds.

What you are describing seems like the backpresure feature implemented in this PR:
https://github.com/westonpace/arrow/commit/45791de8311b0c2e2525e72f4c4746cc3b4364e3
What does this PR do/improve that is not in the first "AsofJoin backpresure" PR?

Turns out we hadn't added https://github.com/westonpace/arrow/commit/45791de8311b0c2e2525e72f4c4746cc3b4364e3 anyways.  So I've combined both "AsofJoin backpressure" and "backpressure for large sources" into a single PR.
As for the difference:
The first PR (asofjoin backpressure) added backpressure to the asof join node.  However, when run on large sources, it tended to crash.  The main problem was the "can't shutdown plan from the process thread" problem, which has already been solved on master.  So that is why it seemed that "backpressure for large sources" wasn't adding much.
However, "backpressure for large sources" added unit tests to reproduce the issue, and these are valuable, so I've included them.

Thanks for the explanation. +1 for combing these two PR together then.


Semantic tokens range protocol spec is unclear about how to determine range client should invalidate

Background
I recently discovered an issue in Visual Studio for Windows 'Razor LSP' scenario where large ranges of semantic tokens can 'disappear' as the user scrolls when polling is disabled.
This issue seems to arise from different interpretations of a language server protocol spec ambiguity.
The Ask
Can we please clarify the spec to indicate what is the correct behavior when:

An LSP server returns tokens in response to textDocument/semanticTokens/range that don't fall within the requested range.
and
The tokens outside the requested range are an incomplete set, for which, a more complete answer has previously been returned.

Example
Consider this Razor C# case:
@{
Console.WriteLine();

...

Console.WriteLine();
}

In the current Razor LSP server:

The client can request the range encompassing the first line and the LSP server returns just those tokens.
The client then requests the range encompassing just the last two lines, and the LSP server returns those tokens and an additional token spanning the @{ at the start of the C# block, outside of the requested range.
Note that no semantic tokens between the @{ and the start of the requested range were returned.

When invalidating the viewport the VS Windows LSP client seemingly innocuously assumes that all semantic tokens 1) in the requested range OR in the range encompassed by the maximum extent of the union of the set of new tokens, and the invalidated range, should be cleared.
Since the Razor response omitted any semantic tokens between @{ and the start of the requested range, all of those tokens are then cleared erroneously.

The candidate fix for VS simply ignores all semantic tokens returned that fall outside of the requested range: https://devdiv.visualstudio.com/DevDiv/_git/VSLanguageServerClient/pullrequest/394818

@gundermanc isn't the underlying problem that a server returns a large range however the tokens in that range are  incomplete or incorrect. So I propose that we clarify the spec in a way say:

if the server extends the range the tokens in that range must be complete and correct.

This ensures that the client doesn't need to adjust the result.

Sounds good, thank you


Update servers timeouts and max header sizes [health, metrics]

fixes #283
Tests updated.  I will update tests with the backoff re-dial to prevent issues from GHA step-by-step.

bors r+


AD-153 - [Bug SLI Dashboard] Add Component Assignment Triage Time metric

Description

[Bug SLI Dashboard] Add Component Assignment Triage Time metric
Small improvements like deleting bugs from db table that changed project or jira type

Issue ticket number and link
AD-153

/lgtm


Set poll interval is not specified in cpa cr

Description
Fix nephe controller crash if poll interval is not specified and webhook is disabled.
Changes
Add a check to see if the field is not specified, explicitly set to default 60 sec.

/nephe-test-e2e-kind

/nephe-test-e2e-kind


fix the population of ngc.Members in gcKick()

fix the loop populating the members list of a new group chat so
that, if the user being kicked is not found, the resulting members
list is identical to the old one, which is the expected behaviour.
this fixes https://github.com/companyzero/zkc/issues/30.

@marcopeereboom @martelletto is this one waiting on something or should one of us merge it?

@jcvernaleo, I don't think this PR is blocked by anything. Should I just go ahead and merge it, or does the merge need to be done by someone else?

@martelletto Assuming you have write permission, I think we've usually had the person who opened the PR merge once it is approved.  So I think you can just go ahead and merge it.

@jcvernaleo Got it. I've merged the branch. Thank you for the clarification.


HotReload not working

Hello,
HotReload, no longer works with the new version of xamarins.Forms 4.2
Cordially

Yes, this is XF issue https://github.com/AndreiMisiukevich/HotReload/issues/118

should downgrade version to fix it ?
Thanks

I think, yes

Aparrently they fixed the issue on HotReload itself, so an auto-fix will not happen here :/

@akamud hm. Interesting. @StephaneDelcroix said that it will be available in the next HotReload version.
Perhaps it's some kind of workaround with changing names in XAML :)
We can apply this fix I think.
Do you develop for Mac/UWP/Tizen? Just wonder why you decided to stay with this plugin :)

I still use this for three reasons:

I prefer having tools that are not attached to any IDE... for that reason I use the Observer with a Cake script.
I've been using Rider primarily on Mac.
I use the Vim plugin (which I'm very dependent of) and that doesn't work on new releases. I still use VS4Mac 8.1, which doesn't have HR.

I totally understand your point, if you decide to archive this I'll probably do a fork and work on these fixes when I have the time for the reasons I mentioned above.

@akamud if you decide to become a maintainer, feel free to contact me ;) It will be easier to support both haha)

@AndreiMisiukevich make sure you clear the Namescope of the object you're reloading, that should fix it

@AndreiMisiukevich make sure you clear the Namescope of the object you're reloading, that should fix it

Thank you very much! I'd like to say "Feel free to make PR", but I already should be thankful for the hint 😆  🤣

I'd like to say "Feel free to make PR"

I unfortunately do not depend on, or use, this project, but nice try

Can't use HotReload in UWP platform

@XamarinTounsi there are dozens of issues, which are explained this limitation.
Read it: (you CAN use HotReload on UWP, but you will have to use two machines. @MagicAndre1981 is an expert in this question)
https://github.com/AndreiMisiukevich/HotReload/issues/87#issuecomment-508484626

Yes i used two machine, before upgrading to  4.2, HotReload work well

@XamarinTounsi Did you update your app to use latest HR version?

Yes i updated it

@XamarinTounsi any errors in the application output?

no error

but if you right now rollback to the previous XF version (without rolling back hot reload), It will work, right? Can you try?
I am trying to understand what is the reason

I had much error when i rollback to previous xamarin version, HotReload work well in android platform

Well... then I will need your assistance)
On Tue, Oct 15, 2019 at 14:18 XamarinTounsi<EMAIL_ADDRESS>wrote:

I had much error when i rollback to previous xamarin version, HotReload
work well in android platform
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/AndreiMisiukevich/HotReload/issues/119?email_source=notifications&email_token=ACNH4DTZNNITDHOQA3G3XJDQOWRI7A5CNFSM4I5CMWMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBIMFAQ#issuecomment-542163586,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACNH4DR2RLDM74ASIS552I3QOWRI7ANCNFSM4I5CMWMA
.

--
Andrei Misiukevich
Lead Software Engineer at ISsoft Solutions
*mobile: *+375 29 <+375%2017%20389%200100>303 40 07   Email:
<EMAIL_ADDRESS>Skype: csi.andreymisyukevich
Minsk, *Belarus *(GMT+3)

How can I help you ?

Can you contact me on Skype ?
csi.andreymisyukevich
On Tue, Oct 15, 2019 at 14:36 XamarinTounsi<EMAIL_ADDRESS>wrote:

How can I help you ?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/AndreiMisiukevich/HotReload/issues/119?email_source=notifications&email_token=ACNH4DRGRQUT34GC5OXIDMTQOWTL3A5CNFSM4I5CMWMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBINQOA#issuecomment-542169144,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACNH4DVLHAF2J4ILG4QYXYLQOWTL3ANCNFSM4I5CMWMA
.

--
Andrei Misiukevich
Lead Software Engineer at ISsoft Solutions
*mobile: *+375 29 <+375%2017%20389%200100>303 40 07   Email:
<EMAIL_ADDRESS>Skype: csi.andreymisyukevich
Minsk, *Belarus *(GMT+3)

I invited you ;)

@MagicAndre1981 does HR still work for you on UWP?

@MagicAndre1981 does HR still work for you on UWP?

1.5.3 works for me. Layout gets updated on tablet via remote debugging

Hi @MagicAndre1981 , are you using xamarin version  <IP_ADDRESS> ?

Hi @MagicAndre1981 , are you using xamarin version <IP_ADDRESS> ?

I use <IP_ADDRESS>8463

@MagicAndre1981 sorry for disturbing you continuously :) but you know a lot about windows reloading lol )


Not Real Issue but Question

Hi @danzimmerman
I came across this while searching for handling param_set command from the GCS to a Teensy 3.5.  Have to tell you, nice job on getting it working.  Will help a great deal.
Been working on mine for a couple of months now.  I am pretty much able to send message to the GCS without any issue but having 1 last challenge maybe you can help me with.  Have you had any luck with setting parameter values from the GCS to the Teensy?  I am seeing that the message is sent but not seeing the message come through on the Teensy (since I am debugging and have the Message ids printed :).
Any suggestions would be appreciated.
Thanks
Mike

After reading your blog again I resolved the problem and am now able to get the message.  I had to change comp id to 1 and all is well with the world.  With the help of you sketch I can updated my implementation to finish command long handling,  set params and clean up some other code.
Really want to thank you again for your efforts on this.  Wish I found it a lot sooner
Mike

Glad you got it working and this was helpful! Are you using the Blue Robotics QGC build or the official, general-purpose one?

Sorry, just saw your message, was working on the code.
Is the Blue robotics QGC build any better?
I am working with generic c_version1 library, probably should switch over to v2 but started with v1 and have gps and ahrs data flowing nicely to APM planner.
Still have problems with just doing a single set parameter change.  The only way to do it seems to be clicking on the write button from the tuning window.  If I just click on set nothing comes across.  Wouldn't be so bad but I don't see the updated value for a single parameter.  If I have more that one that I upload I always just see the last one with the original value.  My problem is just don't see how's its done.  The protocol description is rather useless for an actual implementation.  Struggling with the proper command ack format.  Right now just sending an ack with an accepted.  Know I am missing something just don't know what.  This is actually the last piece of the puzzle.
Mavlink is like pulling teeth.

Hi Dan
I just loaded your example onto a T3.5 just to test and play around with the messages.

On the APM plannerI had to update the capabilities message to include the mavlink2 protocal enum.  But I am still getting a strange error that there is a baud rate mismatch between the T3.5 and the ground station.  Strange, both are set at 115200.
On QGCS I am able to connect no problem but it does not seem to want to arm.  Gives me a can not arm message.  Strange.
Just thought you would like to know.

Thanks for the info.
I just tried this with both Blue Robotics QGC version 3.2.4 and the newly downloaded official version QGC 3.3.2 on a Teensy 3.2 and didn't have a problem. Arm/disarm seems to work okay there. I also tried adding MAV_PROTOCOL_CAPABILITY_MAVLINK2 to the capabilities message:

to see if that was the issue. Arm/disarm still seems to still work in both versions of QGC that I have.

When you say you're using the  c_version1 library, did you download my sketch by itself and use your local copy of the library, or did you clone the whole repository and compile including the submodule mavlink_c_v2 library linked from the repository?
I don't know what to say about your baud rate error. I downloaded APM planner 2.0.24 (on Win 10) and tried it and it connects to the Teensy's COM port okay. It doesn't seem to actually --work-- though, but I don't know APM planner and how to get it running.

Ok,  still couldn't get it to connect to standard QGC.  However, I downloaded the BlueROV QGC.  Connected and armed without a problem using your sketch.
I did get it to connect to APM planner by changing the baud rate to 57600 but nothing came through.  So for the heck of it I changed the library to mavlink version 1, yes I know.  But guess what.  It connected at 57k and 115k no problem.  Also, was receiving data across the link.  Only thing couldn't do was arm the system which also requires changing the mode.
Will keep working at it, to see what I can come up with.


Fixing the quickstart example

As referenced in #883, here is a PR which fixes the quickstart example and makes it more self-contained.
Unsure if better to do this or just strip down to getting it working (i.e. use anyhow::Result) and leave the setup and dependencies to the user. Figured I'd do more rather than less here and can take out later.

Could you rebase this? I like the additions you made here relative to the other README quickstart fix I merged but I was reading these PRs bottom-top.

Thank you again. We are currently working to revamp the quickstart to touch on more things and be more of a guide to getting started.


Active ICsp connection cause Connect-HPOVMgmt to fail

With an active ICsp connection, attempt to connect to OneView 1.20 using the Connect-HPOVMgmt call fails due to the "$global:cimgmtSessionId" variable contains the ICsp connection sessionId.  This results in the error "You are already logged into $Appliance. Please use Disconnect-HPOVMgmt to end your existing session, and then call Connect-HPOVMgmt again."
Following is the response from OneView regarding this issue:-
"ICsp built their library from the HP OneView library, so they need to change the variable and method it uses to check for connection to an appliance. This is not an HP OneView PowerShell library issue."

Updated bindings to remove session conflicts with HP OneView library.
fixed in commit dacbc3fb9e5e4b186116e5ae8f4d224faa8551e3

Thank you very much for fixing the Connect-HPOVMgmt issue!  OneView is able to create a connection with an active ICsp connection with the HPICsp 1.01 module.  However, the Disconnect-HPICMgmt returns the following failure with the HPICsp 1.01 module.  Please let me know if you would like a new issue submitted for this:
Send-HPICRequest : The remote certificate is invalid according to the validation procedure.
At C:\Users\ng\HPCS\CI\Common\HPICsp\HPICsp.psm1:996 char:9

    Send-HPICRequest $loginSessionsUri DELETE $global:cimgmtICspSessionId

    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Send-HPICRequest

Disconnect-HPICMgmt : Unable to logoff.  Please verify connectivity to appliance and retry command.

No need for another issue - I've checked in a fix ebbced42a95373741b1cd79771d1259120bd3d6d

I have verified the Disconnect-HPICMgmt failure no longer occurs with your latest fix.  Thank you very much for fixing this issue!

You are welcome.  Let us know if you come across anything else.


Update class-and-style.md

if you do not have the single quote around the class when using the tenary operate then vuejs complains the it can not find that class. I ran in to the is problem yesterday.

It does work, as you'll see in this fiddle. It sounds like you simply don't have a property called activeClass defined, but rather are trying to use a class literally called activeClass.


[Workspaces] Fix Steam repositioning

Summary of the Pull Request
Moved logic to the common library so that WorkspacesSnapshotTool and WorkspacesWindowArranger use the same code to identify apps for snapshotting and repositioning.
Follow up for https://github.com/microsoft/PowerToys/pull/34948 and https://github.com/microsoft/PowerToys/pull/34627

PR Checklist

[ ] Closes: #xxx
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

/azp run


Bootstrap Version

I hope there is bootstrap UI for this. Thank you!

Can you make a PR for the Bootstrap version?


reduce build size for read-only support

Our team is developing a custom firmware update feature with a custom bootloader. We are not using mbed OS; however, we are investigating the use of littlefs, as a filesystem abstraction to manage storage on a SPI-connected flash chip. Our main application will use the full read and write features of littlefs, but we are trying to reduce the size of our separate bootloader app by building in only those portions of littlefs needed to read from the filesystem. So far, after a bit of basic hacking, we've only been able to reduce our bootloader application size by a few hundred bytes.
If perhaps some build flags were put into place that would produce build of a subset of the library that would support only read operations, is it feasible to expect the size difference to be more than just a few hundred bytes? If so, might this be added as a feature?

Hi @matthewjrichey, from previous experiments I would guess building littlefs readonly would get you to about 1/3rd the code size. Most of the code cost comes from managing writes.
If you remove the writing if statements from lfs_file_flush and lfs_file_sync, the compiler should be able to garbage collect the write functions and give you a more accurate prediction.
Unfortunately this is relatively low priority for me at the moment, but I'd be happy to take in a PR.

I've been wondering the same thing. I'll have a look to see if I can get the build size down. If anyone else has tried this, it would be great to hear from you.

Just an FYI, @KRekha3 was able to modify littlefs for readonly and the resulting size was ~5KiB: https://github.com/ARMmbed/littlefs/issues/183


[DCC_Tabbed_Sheet] v1.5.5

Changes / Comments

New Feature: Add easily selectable action die to the header area, so it can be selected from any tab

Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[X] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[X] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


Getting the odata string

Sorry if this is in the documentation and I have missed it, but is there anyway to get the query string that the client generates?
Thanks.

You can add an OnTrace handler to the ODataClientSettings you pass when constructing the client.
var client = new ODataClient(
    new ODataClientSettings
    {
        BaseUri = Uri.Parse(@"http://www.example.com/odata.v4"),
        OnTrace = (format, args) => Console.WriteLine(String.Format(format, args)),
    });

var results = client.For<EntityA>()
                             .Filter(aa => aa.Column == 2)
                             .Expand(aa => new { aa.Others, aa.Something })
                             .FindEntriesAsync();
// Two requests shown in console
// http://www.example.com/odata.v4/$metadata
// http://www.example.com/odata.v4/EntityA?$filter=Column%20eq%202&$expand=Others,Something

Ok thanks.
Is there anyway to get this info without doing a server request.  So the client is used like a query generator?

I believe GetCommandTextAsync should do the job.


Wrap meta information in  tags

I have a site that uses this theme, and I wanted to verify my ownership of it so I could use Google's search console. Google supplied a custom meta tag so I put it into layouts/partials/custom_head.html; however, I still failed Google's validation. Then, I realized that the output of layouts/partials/head.html is not wrapped in  tags.
Once I added wrapped the output of head.html in <head> and </head>, I was able to verify my site.

I wonder, can you put the head tag inside the customization file? This looks like breaking change for everyone who already does that.

Okay, so are you asking me to put it in layouts/partials/head.html?

@welcome-me I don't know for sure how other people use it either :) I'm just trying to think critically about what could break.
Since nobody complained about this in the recent years, I assume it wasn't a problem or people were able to get around it.
From theoretical point of view, it's better to have the tag being customized in the customization file, since you may want to customize also that tag's attributes. That won't apply to head, because it has no attributes, but in general it sounds like more flexible way.
Just by checking the demo page's source, there IS proper head tag.

Your PR looks logical, but how come the demo does have the head? Won't adding the head duplicate the tag?

Bear with me, I'll check this out at the weekend.

I'm a little confused. I'm not seeing a  trash after the  tag in the source for the example site. 🤔

@welcome-me That is truly confusing because I do see head tag there. I can't see an explanation for getting different results here. I'm checking https://zjedi.github.io/hugo-scroll/ via desktop Chrome

I expect that the browser console is showing that there because those tags are supposed to be in the head tag. If you right click the page and click view the source, I think it will show that the head tag is not in the output we're generating for the browser.

Aha, I am using inspect element. So the browser gives two different results based on inspection method. I still don't get it :) Do browsers just figure out there should be wrapping head tag when inspect element is used?

Based on the below Stack Overflow answer and your experience with your browser inspector, it looks like the page is correctly parsed without the head tags. In fact, it looks like that's part of the HTML5 spec!
However, it is also true that implicit HEAD tags are required for verifying site ownership with Google. I don't know why we wouldn't want a three line change that increases compatibility with website analysis tools.
Does that make sense?
Is it necessary to write HEAD, BODY and HTML tags? - Stack Overflow
https://stackoverflow.com/questions/5641997/is-it-necessary-to-write-head-body-and-html-tags


Not working on mobile devices

Not working on mobile devices.

Same on 2.8.0 version from android. When typing /e2ee import, no pop-up to enter the private key appears.

Here is some information about this from another issue:
https://github.com/quarkslab/mattermost-plugin-e2ee/issues/12


Multiple issues / code smelles

Hello,
I ran a static code analysis and I found 16 minor issues.
I made 2 screenshots with al the issues and I hope it will help.

Hi is this issue still open?
I would like to work on this.
Can you please assign me.
Thankyou!

Hi, is this issue still open to work?
If its is then can you please assign me. I would like to work on this.
Thankyou!


Unable to start the app packaged as darwin-dmg or darwin-pkg

Hover doctor
macOS Catalina 10.15.5
$ hover doctor
hover: Hover version v0.42.0 running on darwin
hover: Sharing flutter version
Flutter 1.20.0-7.3.pre • channel beta • https://github.com/flutter/flutter.git
Framework • revision e606910f28 (2 days ago) • 2020-07-28 16:06:37 -0700
Engine • revision ac95267aef
Tools • Dart 2.9.0 (build 2.9.0-21.10.beta)
hover: Flutter engine commit: https://github.com/flutter/engine/commit/ac95267aef5175b3f6c3387d502070c68f588ad5
hover: Finding out the C compiler version
Apple clang version 11.0.3 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin19.5.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
hover: Sharing the content of go.mod
module test_dmg/go

go 1.14

require (
	github.com/go-flutter-desktop/go-flutter v0.41.2
	github.com/pkg/errors v0.9.1
)
hover: Sharing the content of hover.yaml
application-name: ""
executable-name: ""
package-name: ""
license: ""
target: lib/main_desktop.dart
branch: ""
cache-path: ""
opengl: ""
engine-version: ""
hover: Sharing the content of go/cmd
go/cmd/main.go	go/cmd/options.go

Steps to reproduce
flutter create test_dmg
cd test_dmg
hover init
hover --docker build darwin-dmg
hover --docker build darwin-pkg

Error output 1
Start /go/build/outputs/darwin-dmg/test_dmg 1.0.0.dmg. It should open a Finder window (see screenshot below).
It unpacks the .app which can not be run. The OS says: "You can’t open the application “test_dmg 1.0.0” because it may be damaged or incomplete."

Error output 2
Start /go/build/outputs/darwin-dmg/test_dmg 1.0.0.pkg. It should open an installer window (see screenshot below).
When the installation process is complete, the OS says: "The installation failed".

The good news
/go/build/outputs/darwin-dmg/test_dmg 1.0.0.app works. The app seems to be not aware of the dpi of the screen and shows as a blurry upscale, but still.

See #499 for an example of working MacOS package.
The main problem here, probably, is the absence of the main Info.plist descriptor for the .app package.


Run npm build after install

@baugarten, can you explain a little bit about the goal here?  Are you wanting to install from github or something?  When you install from NPM you get it pre-transpiled.  I do sometimes forget to build my packages before publishing, but really I need to use a pre-publish script in that case.


App crash on debug/release mode (after some time)

Steps to Reproduce
Hi, I'm running on a problem that only occurs when i (developer/user) try to launch the app days (for me was 1-2 weeks later) after installing it on iOS devices (eg.: my iPhone 7).
The first time that happens I thought that was an error/bug in the code, but then I made a little test and
installed 2 apps, one default created when I create a new project and other by me, on my device in debugger mode and release mode, and the results were the same.
Logs
The logs that I can get are the device (iPhone 7) logs retrieved by the Xcode.
1- Default App
Analyzing flutter_app...
No issues found! (ran in 1.3s)

2- Developed App
Analyzing legislactionapp...
No issues found! (ran in 1.6s)

[✓] Flutter (Channel beta, v1.0.0, on Mac OS X 10.14.1 18B75, locale en-PT)
    • Flutter version 1.0.0 at /Users/daniel/Development/flutter
    • Framework revision 5391447fae (2 weeks ago), 2018-11-29 19:41:26 -0800
    • Engine revision 7375a0f414
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at /Users/daniel/Library/Android/sdk
    • Android NDK at /Users/daniel/Library/Android/sdk/ndk-bundle
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = /Users/daniel/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[!] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    ✗ Verify that all connected devices have been paired with this computer in Xcode.
      If all devices have been paired, libimobiledevice and ideviceinstaller may require updating.
      To update with Brew, run:
        brew update
        brew uninstall --ignore-dependencies libimobiledevice
        brew uninstall --ignore-dependencies usbmuxd
        brew install --HEAD usbmuxd
        brew unlink usbmuxd
        brew link usbmuxd
        brew install --HEAD libimobiledevice
        brew install ideviceinstaller
    • ios-deploy 1.9.4
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 31.1.1
    • Dart plugin version 181.5656
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[✓] Connected device (1 available)
    • Pixel • FA6C80302414 • android-arm64 • Android 9 (API 28)

! Doctor found issues in 1 category.

The logs that I can get are the device (iPhone 7) logs retrieved by the Xcode.

Did you intend to add such logs?

Not sure if its crucial or if are readable, but here they are:
ios_logs.zip

UP

Are you still seeing this with dev or master channel builds?
The files in the ios_logs.zip are 6-9 weeks older than when you posted the comment (2018-10-09
-2018-10-29).
Are you sure they are even related?

I have same problem on release mode app. Apps can't be open after more than (3 days).

@opannapo can you provide information about how to reproduce?
How do you build?
What plugins are you using?
What is the output of flutter doctor -v (on the machine where you built the app)?

@zoechi & @Kigstom
I've found best answers on apple developer forums.
That is because of Developer Certificate (Free - Valid for 7days).
check it out : https://forums.developer.apple.com/thread/51527

@zoechi & @Kigstom
I've found best answers on apple developer forums.
That is because of Developer Certificate (Free - Valid for 7days).
check it out : https://forums.developer.apple.com/thread/51527#157434

Good morning....,
that is what I'm facing..., and it must be the default specs for a 'free dev certificate'.
So i can conclude that the actual 'issue' was not the problem, but a, irresponsibility from my(dev) part not reading the notes properly.
I'm sorry and thank you all for your time and patience.

Sounds like this is solved and can be closed.
Please just add a comment if you think it should be reopened.


Bump min server version to v5.26.0

Summary
Upgrading min_server_version to 5.26.0 so that autocomplete functions correctly.  Dylan found an issue with 5.24 where /jira connect gets replicated by the number of instances installed.
Ticket Link
N/A

Codecov Report

Merging #681 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
+ Coverage   32.09%   32.11%   +0.01%
==========================================
  Files          51       52       +1
  Lines        5263     5266       +3
==========================================
+ Hits         1689     1691       +2
- Misses       3380     3381       +1
  Partials      194      194

Impacted Files
Coverage Δ

server/mock.go
100.00% <100.00%> (ø)

server/subscribe.go
66.31% <0.00%> (-0.22%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2526c6...58efa2d. Read the comment docs.

@jfrerich I added a point to the thread with @hanzei.
Also, I'm having issue bringing up a cloud servers right now. Looking at this code change, I'd say we're okay merging this without functional testing for now.

@hanzei or @jfrerich I'm still having issues bringing up a cloud servers right now. Can you please merge this and I can do functional testing post-merge.


json_inject giving runtime error when given empty string

Currently, when running something similar to
json_inject(payload, sizeof(payload), "");
gives a runtime error of
./cee-utils/json-actor.c:1723: unexpected (null).
We might want this to give back an empty string or an empty array/object string.

Should we reopen this issue at https://github.com/cee-studio/cee-utils? @cee-studio/orca

Yes.
On Thu, Jul 1, 2021 at 6:54 AM Lucas Müller @.***>
wrote:

Should we reopen this issue at https://github.com/cee-studio/cee-utils?
@cee-studio/orca https://github.com/orgs/cee-studio/teams/orca
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cee-studio/orca/issues/640#issuecomment-872267432,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYXSFKK2GABANPUZQQQOULTVRXQTANCNFSM46MQYZZA
.


Feature/bibliography autocomplete

This PR:

Adds a bibliography autocomplete to the footnote inline
Refactors common autocomplete settings to mep.common.admin to reduce code clutter
Pins django-grappelli to a Django 1.11 version

Codecov Report

Merging #174 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #174      +/-   ##
===========================================
+ Coverage     98.5%   98.53%   +0.02%
===========================================
  Files          121      122       +1
  Lines         5348     5387      +39
===========================================
+ Hits          5268     5308      +40
+ Misses          80       79       -1


search app: clicking an x on a number search range will not delete the search criteria

on rbk-dev, select number of comments, set the serach range to 2-7. THis will reflect correctly on the search summary on top of the result list. Clicking x on that criteria only reset the range, but did not remove it from being displayed in the search list.

This problem seems to disappear on rbk-dev. @jrchudy did you fix this somehow?

As rbk-dev is doing hourly updates, strange behaviour can happen when a test is performed concomitant with the update process.

@shinyichen can you please review this issue and close it if this problem disappears in regression testing?

This is the same thing I documented in the test cases. I still see the problem there.

The hourly update on rbk-dev is broken, so the fix will be visible once the update process will be restored.

Available now for test also on rbk-dev.


x/crypto/acme: CreateOrderCert returning Order's status ('valid') is not acceptable for finalization

What version of Go are you using (go version)?

$ go version
go version go1.15.2 linux/amd64

Does this issue reproduce with the latest release?
The build that is seeing the error is using:
golang.org/x/crypto (git) - 06a226f Use boolean tag (0x01) for boolean type.

and I don't see any fixes related to acme since that.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/toaster/.cache/go-build"
GOENV="/home/toaster/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/opt/gopath/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/opt/gopath"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build034489393=/tmp/go-build -gno-record-gcc-switches"

What did you do?
After calling WaitOrder for the order to be ready and authorizations to succeed, we call CreateOrderCert with the order's FinalizeURL and a freshly created CSR. We only call CreateOrderCert once.
What did you expect to see?
I expect it to ignore this error when calling the finalize URL and continue to fetch the certificate since the order is Valid.
What did you see instead?
CreateOrderCert is returning:
403 urn:ietf:params:acme:error:orderNotReady: Order's status ('valid') is not acceptable for finalization

I imagine this is because of some retry logic that is not accounting for the fact that it's already valid. This just started happening today, I'm not sure if something changed on Let's Encrypt's end either.

The problem with ignoring this error with something like:
if e, ok := err.(*Error); ok && e.ProblemType == "urn:ietf:params:acme:error:orderNotReady" {
	// ignore error if valid
}```
is that we don't have the order to fetch the certificate. `CreateOrderCert` doesn't have the order's URI to re-fetch the order's status, so should this be up to the caller do handle this?

CC @rolandshoemaker, @x1ddos, @FiloSottile per owners.

Let's Encrypt will only set the status of an order to 'valid' if the certificate has already been issued. It's plausible if you are doing parallel validations of identical name sets you may be running into orders that are being reused at the server side. Are you checking if Order.CertURL is not empty if WaitOrder returns an order with a 'valid' status?

Oh sorry I misread the initial issue. This seems like expected behavior, if WaitOrder returns a valid order you should be using FetchCert rather than CreateOrderCert.

@rolandshoemaker I'm not doing parallel validations or fetches. I'm doing validations and then calling CreateOrderCert. Before calling CreateOrderCert the order is not valid. The issue is that CreateOrderCert is internally retrying the authorization call but not realizing that the "error" ("Order's status ('valid') is not acceptable for finalization") is an okay response.

CreateOrderCert doesn't do anything fancy, all it does is POST the finalization request, poll for the order status to change to 'valid', and fetch the resulting certificate. You will only get the 'wrong status' error if a. you've already called CreateOrderCert for the finalization URL before, or b. there is an issue on Let's Encrypt's end in computing order statuses.
Note that if you are creating two orders with the same set of names Let's Encrypt will reuse the order which would cause this exact problem (this is regardless of the CSR you use in CreateOrderCert). For example if you try to create two orders for ["example.com", "b.example.com"] before calling CreateOrderCert on the first order then Let's Encrypt will return the same order object, so you'll only be able to call CreateOrderCert once, the second time will return the error you are seeing as the order will have already been finalized.

CreateOrderCert doesn't do anything fancy, all it does is POST the finalization request, poll for the order status to change to 'valid', and fetch the resulting certificate.

I see inside of the POST for the finalization request that it has some retry logic. Is there any way I can debug what happened in there for future occurrences?

Oh hrm, I guess another possible explanation here is that LE is timing out internally, causing a 500 status code to be returned to the client but still actually completing the issuance. Since we receive a 500 we retry the call, resulting in the unexpected status error because the finalization actually happened despite us never seeing it happen.
I'm still not sure adding a case to ignore the error and refetch the order is the correct solution to this problem, since it introduces a somewhat complex codepath that relies on matching against a textual error that is specific to Let's Encrypt's implementation. I think I'm still of the opinion this is better handled in user applications.


Feature: follow up of adding legend

follow-up of #62
maybe we need:

add edges details
be able to turn it off
be able to use pyvis' template
?

About the changes in #62 now we have two identical templates which one of them is always used, the templates difference is some JS and CSS codes,

For consistency reasons it will be better to merge these two into one template and use a template variable to add additional codes
It also can be a good idea to have some other output types (multi-selectable by user), e.g. dotfile, SVG, png, pdf, ps, ...
as a dotfile is a good common file format between graph analysis softwares it is better to make this type the bridge between other types (so we can have more options for generation, analysis and conversion of output types - e.g. we can use Graphvis or even Latex)


Trim memory consumption

I suspect there are memory leaks here and there; do full pass to trim gpu memory consumption

Fixed


Add support for PUBLIC FINAL/ABSTRACT

The following combinations are possible:
FUNCTION_BLOCK PUBLIC FINAL SomeFB
FUNCTION_BLOCK INTERNAL FINAL SomeFB

FUNCTION_BLOCK PUBLIC ABSTRACT SomeFB
FUNCTION_BLOCK INTERNAL ABSTRACT SomeFB

METHOD PUBLIC ABSTRACT METH : BOOL
METHOD PRIVATE ABSTRACT METH : BOOL
METHOD PROTECTED ABSTRACT METH : BOOL
METHOD INTERNAL ABSTRACT METH : BOOL

Closed with #34.


Brainstorm questions for Monday's GC Brokerage Meeting

Describe the issue
There is a meeting scheduled for Monday with a rep from GC to discuss brokerage
Which Sprint Priority is this issue related to?
Policy Stream
Goal - Provide an assessment of the operational service of the GC Brokerage
Additional context
Add any other context, attachments or screenshots
Definition of done
List of questions established for Monday's meeting

Met with Pat from GC on Monday.


(SERVER-1142) Sanely handle auth and param parsing for clojure routes

Previously clojure routes were unauthenticated if legacy auth was
enabled because it was presumed that all routes would be handed down
into puppet for auth via auth.conf. As that is not the case, this commit
separates the jruby request handler from a new clojure request wrapper.
The jruby request handler is applied to all ruby routes, and conditional
authentication is applied to that handler. The new clojure wrapper
unconditionally applies authentication and parses the request for
params.
The legacy routes service also needed a corresponding change to account
for the changes to get-wrapped-handler and root-routes.
Additionally, this commit defines schemas for some of the existing and
all of the new functions in master-core.

This looks good to me, I just had one tiny nitpick :+1:

:+1: with just the one question about whether there's another way to do the wrapping the of clojure-request-wrapper logic around the whole route sub-tree w/o having to wrap it around each sub-handler individually.  If there's no sane way to do that, I'm good with just using what you've already done.

@camlow325 so there is comidi/routes->handler that takes a route tree and returns a handler. that would be easy to wrap with the clojure wrapper, but i didn't see an obvious way to take that handler and pass it to comidi/context to rejoin the other route subtree.

Travis failed with:
lein test :only puppetlabs.services.jruby.jruby-pool-int-test/test-restart-comes-back
FAIL in (test-restart-comes-back) (jruby_pool_int_test.clj:308)
After a TK restart puppetserver can still handle requests
expected: (= (clojure.core/deref call-seq) [:init-bonus-service :start-bonus-service :stop-bonus-service :init-bonus-service :start-bonus-service])
  actual: (not (= [:init-bonus-service :start-bonus-service :stop-bonus-service] [:init-bonus-service :start-bonus-service :stop-bonus-service :init-bonus-service :start-bonus-service]))

... and then a bunch of other errors.
Maybe a race condition in that test?   Doesn't seem related to this PR, and only failed in one cell.

@KevinCorcoran I think @haus said that test has been failing intermittently on other PRs so I doubt the changes on this one are related.  I'm good with this PR being merged whenever you are.  WDYT?

@camlow325 I haven't looked at the code, but if you and @jpinsonault are :+1: then :shipit:


Increasing Accessibility of Reference Section: Show the items in sorted order

Increasing Access
Currently, in the reference section, all the reference items are listed in an arbitrary order, which makes it difficult to search for a particular item manually, and thus reduces the accessibility to the site.

Most appropriate sub-area of p5.js?
Reference
Feature request details
These items must be sorted alphabetically before being displayed. The behavior can be handled in the src/templates/pages/reference/index.hbs easily.

I would like to work on this issue.

Hi @EshaanAgg I'm the steward for reference page. Sorting the functions in reference page will actually help in searching out for a particular function. However I think the current page is in order of relevance for example: describe element() function is after describe (). If this is not an issue we can definitely go for sorting. Tagging @limzykenneth for further discussion

The order currently is probably related to the order in which the relevant inline documentation are defined in the source file. I think sorting it alphabetically would be great and this should probably be done on render to avoid having to modify any data.


Adopt mockito-kotlin, thereby getting mockito 2

Fixes #262

Codecov Report

Merging #269 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #269   +/-   ##
=========================================
  Coverage     76.56%   76.56%
  Complexity      379      379
=========================================
  Files            29       29
  Lines          1660     1660
  Branches        148      148
=========================================
  Hits           1271     1271
  Misses          292      292
  Partials         97       97

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 737fa9c...c752d0b. Read the comment docs.


Is there any document available that guides how to use the Virtualizer component?

🙋 Documentation Request
I used useListBox to implement a ListBox component but it doesn't support virtualized list.
I noted that the ListBox component from Spectrum supports this feature and a Virtualizer component is used inside it. But I can't find any guide about the Virtualizer component in https://react-spectrum.adobe.com/.
It's better to provide a document to guide how to use the Virtualizer combine with other hooks.
I'm sorry if I missed any document about this.
🧢 Your Company/Team
No response

Not yet, but we'll be working on docs soon.

@devongovett But can be used or is not ready yet? I'm trying to use the  with react with Tanstack Virtualizer but it just don't work :/


Improve docs with TypeDoc

Mainly based on changes from Reto here, but skip Docusaurus and TypeDoc installation as discussed:
https://github.com/ERC725Alliance/erc725.js/pull/23

I removed the docs folder because all the rst files / content are now within the source as TypeDoc comments
I generated Markdown files with:

npx typedoc --out /docs-website/docs/tools/erc725js/technical-reference src/index.ts --includeVersion --hideInPageTOC true --sort visibility

and added the generated sources to docs portal: https://github.com/lukso-network/docs-website/commit/221c6b4647f747d51b6d87a19e2355af3451fff9
https://docs.lukso.tech/tools/erc725js/technical-reference/README
To do:

make process less manual
fix links (set right remote url when generating docs)
add more examples

We can add more .md files in this repo, they can be "picked up" by typedoc when we generate the docs.
Or we can create them in the docs repo directly, there is already a couple of files:
https://github.com/lukso-network/docs-website/tree/main/docs/tools/erc725js
The content of the "technical-reference" folder is the output of the typedoc script.
There is also a WIP for an article in this folder:
https://github.com/lukso-network/docs-website/commit/32d9b8ea352323468d498e9aab3a079bb947dbb2

We should add them to this repository, in a docs folder. Ideally in a way that they can also be read directly on github.
There’s also some documentation in the files that were deleted, that should be transferred to markdown files first.
On 8. Jul 2021, 18:01 +0100, Hugo Masclet @.***>, wrote:

We can add more .md files in this repo, they can be "picked up" by typedoc when we generate the docs.
Or we can create them in the docs repo directly, there is already a couple of files:
https://github.com/lukso-network/docs-website/tree/main/docs/tools/erc725js
The content of the "technical-reference" folder is the output of the typedoc script.
There is also a WIP for an article in this folder:
@.***
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

I merge this into feature/docsso that I can continue working on it.


add username+password authorization into trino client (fixes #829)

add username+password authorization into trino client (fixes #829)

it is like presto client works now:
https://github.com/pinterest/querybook/blob/1e3d01e8a8177f7c4a0031b681f4e1e8d95b3f76/querybook/server/lib/query_executor/clients/presto.py#L12

@czgu could you look at this PR, please?


in Meteor 1.3 unexpected token < error at loading themes and modes

Hi! I'm using this package for a year. Now it not work fine!. My code:

var editor = ace.edit('editor');
editor.setTheme('ace/theme/monokai');
editor.getSession().setMode('ace/mode/javascript');
At that moment console shows:
unexpected token <: theme-monokai.js
cannot read property cssClass of undefined: share-ace.js
unexpected token <: mode-javascript.js
Thanks!

This is due to the fact that ace is not loaded in meteor 1.3 previously to the ace.js file required by sharejs. See my pull request to get it working with meteor 1.3.

See #67.

Ok nice!. Now How I can incorporate changes into my project?

@jortegamo You can clone my fork and use it as an local package or wait until the pull request is tested and accepted. by mizzao.

Thanks! Its my first time with a pull request.


move PR template out of subdirectory

Fixes #13

From what I understand from the docs, it should be possible to have the template in a PULL_REQUEST_TEMPLATE/ folder but I agree the template doesn't to be working here so let's give this change a go.

I think having the templates there works but only via URL query, not by letting the user choose through the web interface. See e.e.g
https://github.com/appsmithorg/appsmith/issues/826#issuecomment-703093426
https://github.com/sustainable-computing-io/kepler-model-db/issues/5#issuecomment-1715668199


Installation will abort when using Command Shell

I was trying to install ntp from Command Shell but this is what happening. As you can see it will be aborted.
# sudo apt install ntp

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

Reading package lists...
Building dependency tree...
Reading state information...
The following additional packages will be installed:
  libopts25
Suggested packages:
  ntp-doc
The following NEW packages will be installed:
  libopts25 ntp
0 upgraded, 2 newly installed, 0 to remove and 0 not upgraded.
Need to get 609 kB of archives.
After this operation, 1826 kB of additional disk space will be used.
Do you want to continue? [Y/n] Abort.

If i use putty it will not abort by it self
$ sudo apt install ntp
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following additional packages will be installed:
  libopts25
Suggested packages:
  ntp-doc
The following NEW packages will be installed:
  libopts25 ntp
0 upgraded, 2 newly installed, 0 to remove and 0 not upgraded.
Need to get 609 kB of archives.
After this operation, 1,826 kB of additional disk space will be used.
Do you want to continue? [Y/n]

It's not really interactive terminal yet. Just add -y switch to your command and it will work.


[WIP] Implement Sidecar connection pool setting

Design
https://docs.google.com/document/d/1bIuwv0E98kyn8VZ_CDVGcZziIHyr3-ACiTmPqGgp5uY
API https://github.com/istio/api/pull/1754

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
0b8f7cfd732c9bc83f220ac00816badcdba169d6
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

not stale
On Sun, Dec 13, 2020, 9:10 PM Istio Policy Bot<EMAIL_ADDRESS>wrote:

🧭 This issue or pull request has been automatically marked as stale
because it has not had activity from an Istio team member since 2020-11-13.
It will be closed on 2020-12-28 unless an Istio team member takes action.
Please see this wiki page
https://github.com/istio/istio/wiki/Issue-and-Pull-Request-Lifecycle-Manager
for more information. Thank you for your contributions.
Created by the issue and PR lifecycle manager.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/28877#issuecomment-744170414, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXIUXH72S3PDIGVDSGLSUWM3PANCNFSM4TVCL44Q
.


Change "panned" to "pinched" in print call

In an example of the mainview.addPinchGesture(target: self, action: "userAction") call, the print() statement had been copied down from the addPanGesture() call above, and not changed to reflect the new functionality.

Thanks 👍


KCL Query tool (Rust ver.)

Enhancement
According to the content in the Roadmap #29 , use Rust to rewrite the KCL query tool

#59 merged


AST: Don't drop inferred available attributes containing just unavailable

Fixes a regression from https://github.com/apple/swift/pull/71922.
Resolves rdar://124073829

@swift-ci please smoke test

@swift-ci please smoke test


Handle quotes in PATH

Fixes #4323 and adds tests

If I'm understanding this correctly, this change does not handle entries that use quotes around the path separator, which is the specific case that quotes are required for. For example, PATH=C:\ruby\bin;"C:\stuff;other stuff\bin".

@indirect correct, but it fixes the issue that was reported ;)

@segiddins so now we're just knowingly waiting for the first person who has a path containing File::PATH_SEPARATOR, because it will be completely broken for them. :joy: :sob:

@indirect but no more broken than it is now. this is an improvement without regression. feel free to add a disabled test for the other scenario or hold up this PR until someone contributes that other half

@segiddins yeah, yeah. I'm :+1: on this once the tests pass.

Ought to pass now

@homu r+

:pushpin: Commit bd0f564 has been approved by segiddins

:zap: Test exempted - status


Fixing 2439: Improve Copy Option Usability

Description
Fixes  2439
This Makes our Copy Option to be more usable, now the options are compatible with the DuckDB syntax and simultaneously keep our original syntax.
We support multiple ways of expressing Boolean value (0/1; on/off; true/false), and also support both empty space and equation sign between the name of option and the value of option.
We also support omitted boolean option value, which would be set to true as default.
Contributor agreement

[x] I have read and agree to the Contributor Agreement.

The corresponding DOCS update PR: https://github.com/kuzudb/kuzu-docs/pull/265


Creating Mockup for the project

https://www.figma.com/file/nffiCq2fx4Bs0UOi3QQqkZ/SWE-Project?node-id=0%3A1&t=0rZrogBrmMai5vpT-1

I currently work on the design.

I added mock up designs.


v5.0.0-beta.1 - makeStyles : TypeError: Cannot read property 'drawer' of undefined

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
This piece of code was working on v4 :
// Used to work in v4 : import { makeStyles } from '@material-ui/core/styles';
import {makeStyles} from '@material-ui/styles';

// A style sheet
const drawerWidth = 150;
export default makeStyles(theme => ({
    root: {
        display: 'flex',
    },
    appBar: {
        zIndex: theme.zIndex.drawer + 1,
        transition: theme.transitions.create(['width', 'margin'], {
            easing: theme.transitions.easing.sharp,
            duration: theme.transitions.duration.leavingScreen,
        }),
    },
    appBarShift: {
        marginLeft: drawerWidth,
        width: `calc(100% - ${drawerWidth}px)`,
        transition: theme.transitions.create(['width', 'margin'], {
            easing: theme.transitions.easing.sharp,
            duration: theme.transitions.duration.enteringScreen,
        }),
    },
    menuButton: {
        marginRight: 36,
    },
    hide: {
        display: 'none',
    },
    drawer: {
        width: drawerWidth,
        flexShrink: 0,
        whiteSpace: 'nowrap',
    },
    drawerOpen: {
        width: drawerWidth,
        transition: theme.transitions.create('width', {
            easing: theme.transitions.easing.sharp,
            duration: theme.transitions.duration.enteringScreen,
        }),
    },
    drawerClose: {
        transition: theme.transitions.create('width', {
            easing: theme.transitions.easing.sharp,
            duration: theme.transitions.duration.leavingScreen,
        }),
        overflowX: 'hidden',
        width: theme.spacing(7) + 1,
        [theme.breakpoints.up('sm')]: {
            width: theme.spacing(9) + 1,
        },
    },
    toolbar: {
        display: 'flex',
        alignItems: 'center',
        justifyContent: 'flex-end',
        padding: theme.spacing(0, 1),
        // necessary for content to be below app bar
        ...theme.mixins.toolbar,
    },
    content: {
        flexGrow: 1,
        padding: theme.spacing(3)
    },
}));

When trying to run my app using npm start , I got this :

Expected Behavior 🤔
It should work as the only required change was to fix the import for v5 (as described here)
(and theme object still has the needed field : https://next.material-ui.com/customization/default-theme/#main-content )
Steps to Reproduce 🕹

Steps:

Git clone my repository : git clone https://github.com/jy95/yt_gaming_library.git
Checkout the branch "updates" : git checkout updates
Run the app : npm start

Context 🔦
Trying to move my codebase to v5 ;)
Your Environment 🌎

`npx @material-ui/envinfo`

  System:
    OS: Windows 10 10.0.19042
  Binaries:
    Node: 12.14.0 - D:\Program Files\nodejs\node.EXE
    Yarn: Not Found
    npm: 6.13.6 - D:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 91.0.4472.124
    Edge: Spartan (44.19041.1023.0), Chromium (91.0.864.67)
  npmPackages:
    @emotion/react: ^11.4.0 => 11.4.0
    @emotion/styled: ^11.3.0 => 11.3.0
    @material-ui/core: ^5.0.0-beta.1 => 5.0.0-beta.1
    @material-ui/data-grid: ^4.0.0-alpha.33 => 4.0.0-alpha.33
    @material-ui/icons: ^5.0.0-beta.1 => 5.0.0-beta.1
    @material-ui/lab: ^5.0.0-alpha.40 => 5.0.0-alpha.40
    @material-ui/private-theming:  5.0.0-beta.1
    @material-ui/styled-engine:  5.0.0-beta.1
    @material-ui/styles: ^5.0.0-beta.1 => 5.0.0-beta.1
    @material-ui/system:  5.0.0-beta.1
    @material-ui/types:  6.0.1
    @material-ui/unstyled:  5.0.0-alpha.40
    @material-ui/utils:  5.0.0-beta.0
    @types/react:  16.9.55
    react: ^17.0.2 => 17.0.2
    react-dom: ^17.0.2 => 17.0.2

This is because there is no default theme in @material-ui/styles anymore.
You need to use ThemeProvider in the root of your application and make sure that the useStyles is called below .

Weird :

@material-ui/styles use the v5 : https://github.com/jy95/yt_gaming_library/blob/updates/package-lock.json#L2061
ThemeProvider is at the root of my app : https://github.com/jy95/yt_gaming_library/blob/updates/src/components/Root.js#L70

Even when I move this line const classes = basicStyle(); (from line 37 to 68), it didn't change anything.

This is a mistake because basicStyle is not called under  .
https://github.com/jy95/yt_gaming_library/blob/2ee0562ab84eb17ade55ab57348e216e26a1c7b7/src/components/Root.js#L37
here is one way to solve it, move <ThemeProvider> in Root to HOC
function Root() {
  return (
    <div className={classes.root}>
      ...
    </div>
  )
}

function withThemeProvider(Component) {
  function WithThemeProvider(props) {
    const theme = createTheme({
      palette: {
        type: themeSettings.currentColor,
      },
    }
    return (
      <ThemeProvider theme={theme}>
        <Component {...props} />
      </ThemeProvider>
    )
  }

  return WithThemeProvider
}

export default connect(
    mapStateToProps,
    mapDispatchToProps
)(withThemeProvider(Root));

Hi, I'm getting a similar problem in my project. I'm using the latest material-ui v5 versions, and have put ThemeProvider at the highest level, and I believe the correct imports:
https://github.com/Pioreactor/pioreactorui/blob/0482c8ec8e959573fc4db536a615abfccfe543fa/client/src/App.jsx#L3
https://github.com/Pioreactor/pioreactorui/blob/0482c8ec8e959573fc4db536a615abfccfe543fa/client/src/components/SideNavAndHeader.jsx#L2
But I'm getting an error in my Sidebar component, note that it is within the ThemeProvider.

@CamDavidsonPilon I checked, the code looks fine but your package.lock is not. please delete your package.lock and node_modules then npm install again. (it works on my machine)

Excellent - that worked! Thanks, team, material-ui is my fav!


Warnings while running the test scripts

Hello!  I am getting these warnings while running the test scripts.
As a result, the final images are quite grayish and not looking well too.
Can you help with this, I am using the code without any changes.
@fsalv @EscVM Could you please have a look at it.  See above for specific issues. Use expect_partial() on the load status object, e.g. tf.train.Checkpoint.restore(...).expect_partial(), to silence these warnings, or use assert_consumed() to make the check explicit. See https://www.tensorflow.org/guide/checkpoint#loading_mechanics for details.

Hi @pankhurivanjani!
mmmm here something is really going bad :)
Could you give more information on what you've done and what you're trying to achieve? It really seems that the Checkpoint class is not able to resolve some objects.

Hi @EscVM,
We're not quite sure either. We've been running multiple experiments, trying to figure out what could be going wrong.
And to further complicate, we don't have direct GPU access, we are having to submit our jobs through HTCondor, a High Performance pipeline for submitting our job to GPU and then observe the errors only via logs.
About 2 days back, we had tried training your model without changing the code for 50 epochs. But for some reason, there was no new checkpoint created. We weren't quite sure about this.
Late yesterday, we tried running only 3 epochs, but we changed the value passed to evaluate_every inside trainer_rams.fit() function from 400 to 1. This resulted in getting a checkpoint file. Upon executing test using this modified checkpoint, we obtained a prediction and it didn't give any of these warnings.
Would you know anything around why this could be happening? We are not able to understand if it's due to the evaluate_every parameter or something else.

Forgot to add the image, this is our result obtained after 3 epochs and evaluate_every =1

As you can check in line 165 of training.py script, evaluate_every simply triggers the test procedure. Moreover, if the test PSNR is lower than the previous test, the code saves the network's weights. That's it.
Why don't you iterate with the code with a Colab session? You could quickly check if you're missing something.

I don't mean to hijack this issue, but I noted another issue where the user is not using a GPU even. I can confirm Google Colab can be used for training, with 25 epochs taking approx 4-5 hours


ERROR: schema "ztest_schema1" already exists error solved when reruning integration tests.

After the first execution of integration tests, i faced with ERROR: schema "ztest_schema1" already exists.
By adding "DROP EXTENSION IF EXISTS hstore CASCADE;" before creating hstore extension, this problem solved for me. (I think because of failure on creating existing hstore extension this error propagates!)
If it is a case, by this pull request the problem will be solved.

Coverage remained the same at 15.92% when pulling 27aa94d17869851e737a029ab7ac46c2b6cf882a on psycho-ir:master into a133bc4d1eb5cd1e5f23f9182ed478e0cdb5fa58 on zalando:master.


Option to sort certain completion items at the bottom (or at the top) of the list

Pyright language server provides dunder methods of a class, which hides the other more important items like functions and class attributes. Can we add an option to sort items so they are at the bottom? Maybe let us use regex to define things we want at the top or at the bottom.

GH-234 should solve this. You can apply the diff and play around with it. But basically, it should sort completion items in the order that the language server (i.e. Pyright) wants them.

GH-234 should solve this. You can apply the diff and play around with it. But basically, it should sort completion items in the order that the language server (i.e. Pyright) wants them.

@lithammer Thank you, this works very well :)

@lithammer Thank you, this works very well :)

@lithammer Thanks a lot for the fixes. I mainly use your code snippets in the PR so it should be working fine now.

@lithammer Thanks a lot for the fixes. I mainly use your code snippets in the PR so it should be working fine now.


Get current logging level.

For some operations it is good to know the current logging level.
For example, if you do string concatenation in your logging statements that are in sections of code that get called a lot, Javascript does the relatively-expensive string concatenation even if the current logging level won't actually output the string.
I think something like log.getLevel() would be useful so you could do the expensive operation only when needed.

:+1:

@dmwyatt you make a good argument. How implementing it and make a pull request?

+1

+1

+1 need it as well to init my plugin, which is done by setting the level at the moment. But I don't want to override the current level. Better would be an init / initPlugins method for that, but getting the current log level would provide me a work around.

Hi @marcelboettcher; that sounds interesting, can you send me some more details on what you're trying to do, and why you need to log level to do so? There is a PR in for this now anyway, but I'd be interested to take a closer look if there's something that you need better support for to manage your plugin initialization.

Hey @pimterry, at the moment I need to set the log level after defining the plugin to register it, right? It just does not feel right to set any level for that reason as I want to stick to the level, which is set for a good reason.
Am I mixing things up here?
Looking forward to you bringing light into the darkness. Thx, Marcel

Ah, I see, interesting. Yep, that makes sense. Once we've got the current level tracked though (as in the new related PR) this gets easier.
Would your issues be solved with an initPlugins() method, which basically just reset the level to the current level? I.e. equivalent to calling log.setLevel(log.getLevel()).
Alternatively, thoughts on moving from setting a .methodFactory field to instead have a .setMethodFactory() method, which automatically reset the levels for you to initialize your plugin? Neater, given that we need to do this, but not backward compatible unfortunately.

yes, initPlugins() would solve that, but your approach with .setMethodFactory() is much cleaner. You should still support the property .methodFactory for backward compatible, but mark it as depricated.

Slightly different use case for me. Something like log.isDebug() which returns true is debug messages are going to the console.
This is for debug code that is computational expensive, so I don't even want to execute it, instead of executing and then throwing it away.
This would be similiar the Java logback interface http://logback.qos.ch/apidocs/ch/qos/logback/classic/Logger.html

@Stexxen with #77 you would do the following:
if (log.getLevel() <= log.levels.DEBUG) {
    // Do your computational expensive code
}

ahhh ok, just to check, would <= in this situation mean DEBUG+TRACE or DEBUG+INFO+ERROR?
i.e are the levels Big Endian/Little Endian.
Might still be worth a wrapper function, as it would not be 100% clear when another developer reviews the code.

@Stexxen in this situation <=  means DEBUG+TRACE cf. https://github.com/pimterry/loglevel/blob/master/lib/loglevel.js#L116
This is true that this comparison is not 100% clear but it's generic and thus keeps the library code smaller. Personally I just need the "get current level" functionality and could live with a not perfectly clear condition since the context around would disambiguate the purpose.

@madarche True.
and thanks for the src link.
S.


Hardware requirements

After installation has completed, on 'python app/run.py'
RuntimeError: This version of jaxlib was built using AVX instructions, which your CPU and/or operating system do not support. You may be able work around this issue by building jaxlib from source.
It would be useful to include a warning about  this hardware requirement in the installation instructions.
I am using an AMD Athlon(tm) II X2 270 Processor, which we agree is oldish!

Hi @BrianBut are you using Windows, Mac or Linux, and which version?
Currently we have only fully tested on MacOS and there is an outstanding issue #24 for Windows

The problem was that the AMD Athlon II has fewer accelerated capabliities than most CPUs:
The installation runs perfectly on a machine with AMD A9-9425 RADEON R5, 5 COMPUTE CORES 2C+3G.
lscpu indicates it has the avx flag set, which the AMD ll does not.
I used Ubuntu 21.04 on the PC with an AMD ll cpu and Ubuntu Ubuntu 20.04.3 LTS on the machine with AMD A9-9425. Both builds were in a conda shell specifying Python 3.9.5.

Hi @BrianBut thank you very much for the details; I'd like to suggest we leave this issue open for others to see, and if we have more feedback we can include a note in the repo. Thanks for sharing your experience!


Redefining let constants generates several warnings.

Excessive warnings are generated by the following method:
https://github.com/rspec/rspec-core/blob/d598ecbc53d8a611a76753c98b903ee7f35c0439/lib/rspec/core/memoized_helpers.rb#L284-L300
e.g.
#!/usr/bin/env rspec --warnings

RSpec.shared_context "Shared Context" do
	let(:x) {10}
	let(:y) {10}
end

RSpec.describe "x & y" do
	include_context "Shared Context"

	let(:y) {10}

	it "should add up" do
		expect(x + y).to be == 20
	end
end

Output
/Users/samuel/.rvm/gems/ruby-2.6.0/gems/rspec-core-3.8.0/lib/rspec/core/memoized_helpers.rb:291: warning: method redefined; discarding old y
/private/var/folders/3x/tvygzl0s65520b6t4tzqbt980000gn/T/538a20f0-3a9d-431d-9ccb-0ffd9d4efeb6:5: warning: previous definition of y was here
/Users/samuel/.rvm/gems/ruby-2.6.0/gems/rspec-core-3.8.0/lib/rspec/core/memoized_helpers.rb:298: warning: method redefined; discarding old y
/Users/samuel/.rvm/gems/ruby-2.6.0/gems/rspec-core-3.8.0/lib/rspec/core/memoized_helpers.rb:298: warning: previous definition of y was here
.

Finished in 0.00322 seconds (files took 0.0975 seconds to load)
1 example, 0 failures

Thanks!


@addTagHelper works with assembly name, not the namespace

@addTagHelper works with assembly name, not the namespace
customer comment:
Hi, thanks a lot for detailed tutorial! May I just ask you to highlight somehow that @addTagHelper works with assembly name, not the namespace? It is really easy to miss. Just spent a few hours trying to understand why my helper is not working until found the answer on SO. |#6049
Moved from

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 19ecfbee-8b84-9ef2-65b6-8c2542f6370f
Version Independent ID: 9a0cbaa2-65c9-1618-1003-5fd2e7f6192f
Content: Author Tag Helpers in ASP.NET Core
Content Source: aspnetcore/mvc/views/tag-helpers/authoring.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Hit this exact issue almost a year ago. Couldn't figure out the cause at the time. Adding a prominent note about the restriction towards the beginning would be a great addition.


Help

after i compile in Pysilon it says WARNING: Failed to remove contents in a temporary directory 'C:\Users\User\pysilon-malware\pysilon\Lib\site-packages~-l'.
You can safely remove it manually.
OS- windows 11

i tried re installing python to 3.11.6 and now i cant even launch pysilon

https://babycub.catto.pics/aab4dead

just wait for it it is not an error

it's just an error that means nothing, the compiler works fine even if you get that error, make sure you have antivirus disabled tho or you won't  be able to generate the .exe

Doesn't Matter.
After the compiling of the exe has been started, wait for 5-10 Mins.
Then, the directory containing the "source_prepared.py" file should automatically be popped up on your screen.

Close this issue, if your problem has been rectified

Hey, just use the ModdedPysilon version, it covers every bug and it make sure your discord account never get banned.
Leave me a star if you like my project ;)


After run_optical_flow, the marker position will be misaligned

As shown in the first image, z4-R6 is on the rightmost marker, but after run_optical_flow, z4-R6 is even to the left of z4-R4 from the x-coordinate of the start position, which means that there is a misalignment of the marker at the beginning of the trace.

In .h5 file,the z4-R6 marker position is (345,539), but after run_optical_flow it starts at 340 in x axis. Same thing with z4-R4, marker position is (308,539), but trajectory starts at 343.

Resolved with latest commits. Unittest included.


Faster fuzz test: teach the fuzz test programs to handle directories [1.1.0]

Instead of invoking the fuzz test programs once for every corpora
file, we invoke them once for each directory of corpora files.  This
dramatically reduces the number of program invokations, as well as the
time 90-test_fuzz.t takes to complete.
fuzz/test-corpus.c was enhanced to handle directories as well as
regular files.

This is a backport of #5776 to 1.1.0.
I just did a trial run on my laptop, and a run of 90-test_fuzz.t before this change took 110s, and with this change 3s...  speaking of dramatic speed increase (frankly, I thought something went wrong for a moment)

-1 to force vote/discussion.  This is not a bugfix, it is making the tests go faster.

It's also a test, not the published API and ABI...  and I would ask you to consider those who run these tests as part of a release, and how the fuzz tests can take time on a machine (Windows, specifically) that's busy building on a number of configs at the same time (when I do a release with Matt, I run tests on Windows cmd (i.e. "native"), cygwin and mingw, both 32 and 64 bit).  It is time consuming, and it's been tempting more than once to simply skip the fuzz tests, which is kind of counter productive...
(I have this fresh in mind from just a couple of days ago, when we released 1.1.0i)
However, you wanted a discussion (assuming on openssl-project).  The ball's in your court, please engage.

Considering the discussion showed a fairly unanimous opinion, are you going to change your -1, @richsalz?

oh sorry, I thought I had done that.  Yes, consider that -1 removed.

Cool, thanks.  Since there hasn't been any further changes since @bernd-edlinger approved, I'll merge with that.

Merged.
df5caeff335877b25a02c40a84935c7c4584e396 .travis.yml: with fast fuzz testing, there is no point avoiding it
0bdcf53fec5245bfc9ce27e438f4f5150f2c1d08 Faster fuzz test: teach the fuzz test programs to handle directories


Architecture documentation

I was wanting to know more about how Gaia runs, is there anything that explains where state is saved, or if it is HA or has plans to be. I didn't see any links to some more info on where credentials for checking out git repos are saved and such. I like all the readme links that do exist but if there is link to further operation instructions I guess I missed it.
Thanks, sounds like a promising project.

Welcome @camerondavison 🤗 Thanks for your nice words!
You are absolutely right. We got basically no documentation and that is the part where I'm currently working on. I've just published today our new docs website https://docs.gaia-pipeline.io.
There is still a lot missing like how to operate Gaia and if it's HA etc...
I hope that we can fix that soon 🤗
So for now, I hope I can answer a few of your questions. Gaia uses currently bbolt as storage solution. It is basically a key/value store where all data is saved locally on space as one file. Gaia does not support HA currently but hopefully in the future. 😄
Credentials for the git repository are also stored in this "database".

Cool glad it is working in progress. I think just labeling things that are work in progress in the docs is good for people to know if there is an aim to solve it or not. Thanks for the quick update. Just as an FYI we use vault for secrets so it would probably be nice to allow for something like that to be configured either talking directly to a secret manager or in a flat for instead of in a database


Automated cherry pick of #8756: fix: support create 512mb server sku

Cherry pick of #8756 on release/3.5.
#8756: fix: support create 512mb server sku

Codecov Report

Merging #8757 (e16e541) into release/3.5 (e3fe6c4) will increase coverage by 1.81%.
The diff coverage is 0.28%.

@@              Coverage Diff               @@
##           release/3.5   #8757      +/-   ##
==============================================
+ Coverage         6.03%   7.84%   +1.81%
==============================================
  Files              795     246     -549
  Lines           124282   33641   -90641
==============================================
- Hits              7503    2640    -4863
+ Misses          116114   30740   -85374
+ Partials           665     261     -404

Flag
Coverage Δ

aFlag
7.84% <0.28%> (+1.81%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apigateway/handler/misc.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/domainresource.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/modelbase.go
4.51% <0.00%> (-0.08%)
:arrow_down:

pkg/cloudcommon/db/namevalidator.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/orderby.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/virtualresource.go
0.00% <0.00%> (ø)

pkg/cloudprovider/securitygroup.go
0.00% <ø> (ø)

pkg/compute/regiondrivers/aliyun.go
0.33% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/regiondrivers/base.go
1.03% <0.00%> (-0.04%)
:arrow_down:

pkg/compute/regiondrivers/esxi.go
6.38% <0.00%> (-36.48%)
:arrow_down:

... and 501 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bd992b...e16e541. Read the comment docs.


Adding business rules for IE

Adding the business as defined in IE

@colmharte Some validations are failing: please check this spot in the logs for what's wrong: https://github.com/eu-digital-green-certificates/dgc-business-rules-testdata/pull/30/checks?check_run_id=3027670657#step:4:1180
The fix is pretty simple, although I do see that the log is less than helpful - I might be able to fix that in the short run.

@colmharte If you merge from main (or rebase on main), then the actual difference should show up in the logs.