 For example the below is valid:
type X struct{}
func (x *X) A() {...}
var x *X
x.A()

This extends to interfaces, creating the issue of typed nil interfaces. See typed-nils-in-go-2 for further context. I would like to see this situation removed in Go2 as typed nil interfaces are a source of bugs and offer no meaningful additional functionality.
Proposed Changes
I propose some changes to the Go2 language spec that would mean banning nil receivers, resulting in banning typed nil interfaces.
Make every method with a pointer receiver nil-pointer panic (at the beginning of the method) on a nil receiver. Implicitly that means if this == nil {panic NilPointer} is added at the beginning of every method. Note this is already implicitly added to most methods (those that use the receiver), just further down the method on the first use the receiver. Compared to the current specs, this would result in:
type X struct{}
func (x *X) A() {...}
var x *X
x.A() // this would now nil-panic (before any logic from A is executed)

Follow this up with another change, when assigning a (typed) pointer to an interface, check its value. If nil, set the interface value as the untyped nil. Note this means the specific type of the pointer unrecoverable. As an example:
type X struct{}
var x *X
i interface{}
i = x
isNil := i == nil  // currently isNil == false, I propose isNil == true
_, ok := i.(*X) // currently ok == true, I propose ok == false

This means if an interface is a typed pointer, it doesn't have to check if the pointer is nil or not, it is non-nil by design, hence the typed nil interface problem is gone.
Other considerations
I imagine others gophers will identify many others issues, these are some I am aware and would like to share upfront:
Optional nil receivers
Methods optionally allowing nil receivers are no longer allowed:
func (x *X) ... {
  if x == nil {
    return nil
  }
  // do something else

Instead a pointer type would be required, type XPtr struct {*X}, which would do the nil check.
Type assertions in nil types
By design, type assertions from nil pointer types are no longer supported. I don't think it is a common (or advisable) pattern, but it will still break the existing libraries using it. Where genuinely needed a pointer type could be used to wrap the pointer: type XPtr struct {*X}.
Methods not using the receiver
Methods do not have to use the receiver. The current spec does not distinguish between the two ways these may be defined (with/without named receiver): func (x *X) ... or func (*X) .... I suggest using this ambiguity and defining them differently in Go2, while the named receiver is just a normal method (and can't be called on a nil typed pointer) the unnamed one may be called on typed nil and does not have the implicit nil check. Note however that because interfaces are never typed nils, once called from an interface it will always be called with a non-nil receiver.
Methods as functions
Consider the below situation:
type X struct {}
func (x *X) A() {...}
var x *X
f := x.A // what to do with this? I suggest panic here

A method on a nil typed pointer is being assigned to a function variable.  For this reason I think it is better to change the language spec to have this panic on the assignment.
Compiler considerations
Note these considerations are not affecting the language spec, but I think they may make this changes more appealing.
This proposal means interfaces holding pointers do not have to check if the pointer they hold is nil valued. But that is largely useless if the first thing all methods do is check if the value of the pointer is nil. It would be much better if the nil check where performed by the caller (and still NilPointer panic if nil), improving performance by reducing the number of nil checks (among other things, methods would not need to make that check when calling other methods on themselves).
Also related, when assigning a pointer to an interface the value has to be checked for nil (which is not required currently). While this makes assigning to an interface more expensive, it is likely the compiler can optimize away many of these checks as the nil-ness of the pointer may be known at compile time.

And what about this?
https://play.golang.org/p/d8_dxaLJBRn
Are we really going to allow the assignment operator to panic, or is it just going to be disallowed to assign like this? Would this mean that go vet will flag every time I don't nil-check before I pass a pointer value into a function that takes an interface argument?
Especially with functions like fmt.Println which take interface{} arguments, does this mean I can't pass any typed nils in to them, instead it'd panic?

@deanveloper the example in your playground is interesting.
I imagine (*X).DoSomethingshares the implementation with (x *X) DoSomething(i int), meaning it would have to enforce panic on nil, yes.
It is still just a function, it simply starts with check and panic on the first argument if nil.

You are exclusively talking about pointers. But there are more types that can be assigned (and compared to) nil, namely funcs, chans, []s and maps. One implication of this, for example, would be that a nil sort.Ints no longer would be a valid sort.Interface.
In the end, I don't even think this proposal really helps or reduces complexity. Say, I have a function
type Barer interface {
    Bar()
}

type ConcreteBarer int

func (b *ConcreteBarer) Bar() {
    // …
}

func Foo(x Barer) {
    x.Bar()
}

Under your proposal, to make this correct we'd have to either

Add a nil-check to Foo against x
Or add a nil-check to every caller of Foo using a *ConcreteBarer

Whereas to make it correct now, you'd have to

Add a nil-check to (*ConcreteBarer).Bar

In the end, you'll still have to have nil-checks everywhere. You either have to have them in the receiver, or you have them in the caller, or you have them in the callee. At least right now, if *ConcreteBarer can work with a nil-pointer, you can leave out the nil-check.
Personally, I find the current contract pretty clear: If I take an interface, I expect that to be a valid value implementing that. I don't care what that value is and I don't want to. The implementer of the interface knows best what values are valid. Ultimately, if a message call panics, that just means the implementation wasn't valid (and note that it will always be possible for methods to panic, so you can't ever include that). With this change, the contract becomes much harder, because it isn't clear whether I have to check that it's a valid interface-value (i.e. not nil) or the caller has to check that it's a valid value of the type implementing the interface (which might be nil, if that's a pointer).

Something to consuder is that this would be pretty hard to implement in some kind of go1to2 transpiler... Although it is possible, so I don't think it should be a barrier to add a language feature, but it is something to think about.
Also, remember that nil maps are significant and can be used. Consider the following:
https://play.golang.org/p/Pupjh2tZo_u

sort.IntSlice is not nulable, the fact that it contains a nil []int is irrelevant (it is just a parameter of a struct!).

No, it is not. It is a defined type with underlying type []int and you can totally assign nil to it. sort.IntSlice(nil) is a valid implementation of sort.Interface. So you should talk about what sort.Sort(sort.IntSlice(nil)) does, if it should panic and if not, why not. Currently it works fine.

which makes them more complex as defined in my original post.

Not really, they are far less complex, TBQH. nil-maps allow reading-accesses without panic, which pointers don't. nil-slices allow range, slicing len and cap without problems - they are indeed pretty much identical to non-nil-slices, except that they compare true to nil. nil-channels allow sending, receiving and selects, with well-defined semantics (blocking forever).
ISTM that the rules for pointers are far simpler than for most of the other types - the only operation that is special about pointers is dereferencing and that works if and only if they are not nil. The other types allow more special operations that each have their own peculiar semantics when working on a nil-value.

But I don't think relying on this property significant (and if you are using it you should probably not anyways).

But as I pointed out - it is. Currently, code doesn't need to check for nil when passing well-behaved implementations as interfaces and code doesn't need to check for nil when being passed well-behaved implementations. Under your proposal, at least one (if not both) needs to happen.
i.e. pretty much all Go code out there is relying on this property, by not cluttering everything with nil-checks.

If not convinced just note the below code:

Type assertions on concrete types check whether the dynamic type is identical to the asserted one. []int an sort.IntSlice are different types - but that doesn't change the fact that sort.IntSlice has underlying type []int and thus is a slice-type that can be nil.

@Merovius regarding the Barer example, there is only one place that nil *ConcreteBarer has to be checked - when Barer is first assigned a *ConcreteBarer. Calling x.Bar() requires no nil check - x is already an interface. It's type has to be resolved to a *ConcreteBarer (as it already does without my proposal, of course), but once that happens it doesn't have to check if it is nil - it isn't by design, there are no more typed nil interfaces!
Not only there are no more nil checks, but they are almost certainly fewer. Say ConcreteBarer.Bar requires the receiver to be non-nil (for example by accessing some parameter on itself). Under the current go spec, it must nil-check the receiver before accessing it. With my proposal, again the pointer is non-nil by construction, and the check can be removed. Depending on your implementation and how many methods ConcreteBarer.Bar calls on itself it may even check for nilnes many times. With my proposal only once, and in fact a smart compiler might often remove that one also, after all (&ConcreteBarer{}).Bar() needs no nil receiver check!
The exception I do acknowledge is when ConcreteBarer.Bar doesn't access the receiver. When cast to an interface my proposal simply disallows it (by design), you need a non-nil pointer to access any functionality. In this case there would be once additional nil check, and one additional memory allocation. Or you can wrap it in a type ConcreteBarerPtr struct {*ConcreteBarer}, in which case you get the exact same functionality. See Methods not using the receiver in my original post for a little more details on this.

sort.IntSlice is not nulable, the fact that it contains a nil []int is irrelevant (it is just a parameter of a struct!).

@Merovius I stand corrected, what I meant is for sort.IntSlice to be defined as type IntSlice struct {data []int} and not type IntSlice []int as it currently is (so yes, library change, plus initialization now use {} not ()). Note this is how I define my XPtr in the original post, and the appropriate pattern to handle all similar situations must be handled.

Not really, they are far less complex, TBQH. nil-maps allow reading-accesses without panic, which pointers don't. nil-slices allow range, slicing len and cap without problems - they are indeed pretty much identical to non-nil-slices, except that they compare true to nil. nil-channels allow sending, receiving and selects, with well-defined semantics (blocking forever).

@Merovius slice read/write, map read/write, channel send/receive, len, cap, (...?) are all functions in the runtime, not methods on these types. My proposal changes nothing on functions, these remain unchanged.

regarding the Barer example, there is only one place that nil *ConcreteBarer has to be checked

Yes, and my point was exactly that currently there is also only one place that nil has to be checked - in the method. Except that currently, that check is only needed if nil is not a valid value - and the person needing to do the checking is exactly the person implementing the type. In your proposal, the check (whether at the caller or callee site) always has to happen.
You are strictly increasing the amount of nil-checks needed. For every nil-check in a method you can leave out, you have to add a nil-check at all usage sites.

it isn't by design, there are no more typed nil interfaces!

"typed nil interfaces" are not a thing. You mean interfaces with dynamic value nil. I'm not trying to just nitpick - being reasonably precise is important to ensure we talk about the same things and don't unnecessarily talk past each other.

Say ConcreteBarer.Bar requires the receiver to be non-nil (for example by accessing some parameter on itself). Under the current go spec, it must nil-check the receiver before accessing it.

I don't think this argument holds. If think checking the receiver for nil in a method is required for safety, then it's also required for safety to check an interface value for nil before calling any methods on it. In practice, we do neither - we simply accept a certain level of lack of type-safety (also, we usually can't do anything but panic anyway). But if you want that type-safety, you have to actually enforce it everywhere.

Depending on your implementation and how many methods ConcreteBarer.Bar calls on itself it may even check for nilnes many times. With my proposal only once

Only if you assume any concrete pointer type is only used exactly once. In practice, that's certainly not the case. For example, there are many assignments of *bytes.Buffer to io.Writer. And even more usages of an io.Writer interface. Each of these - by your argument of type-safety - would need to be nil-checked.
I don't believe there is a plausible scenario for a concrete type to have more methods than usages.

The exception I do acknowledge is when ConcreteBarer.Bar doesn't access the receiver.

Slice, map and channel types all allow accessing a nil-receiver just fine.

I stand corrected, what I meant is for sort.IntSlice to be defined as type IntSlice struct {data []int} and not type IntSlice []int as it currently is (so yes, library change, plus initialization now use {} not ()).

Also, range, slicing, indexing, len and cap don't work anymore. So this is now effectively becoming a proposal to disallow declaring methods on any non-struct type.
It is my impression that your thinking is heavily influenced by classes in OO-languages, in that methods are closely associated with pointers to struct. But that's not how the Go type system works. TBQH I think it's easier to just accept that - because then it also becomes obvious why thinking about "typed nil interfaces" is such a fallacy. An interface value is defined by the methods it implements. It does not make sense to compare it to nil and expect that to have any relationship to the dynamic type (whether pointer, slice, map…). If you intentionally forget anything about the dynamic type of an interface and purely concentrate on the method set, the question of "is the dynamic value nil" is about as natural as the question "is the dynamic value an integer type storing 23".
It's simply an unfortunate accident of history that the zero-value of interface-types, the zero-value of pointers, and of maps, slices, channels and funcs are all denoted by the same identifier. But they really are different values.

slice read/write, map read/write, channel send/receive, len, cap, (...?) are all functions in the runtime, not methods on these types.

The argument is, that the behavior of non-pointer types for nil-values is far more complicated to reason about than the behavior of pointer-types for nil-values. Thus it doesn't make sense to exclusively focus on the pointer case, as the non-pointer case has far more questions to answer. I find sort.IntSlice a pretty good illustration of that, as it's methods are 100% natural, without any nil-checks and still a completely valid implementation with the correct, expected behavior when used on a nil-receiver. i.e. it illustrates that nil-receiver are not, in general, a problem and there are cases where they work completely naturally. So you need to at least explicitly say a) whether you want e.g. sort.Interface(sort.IntSlice(nil)) == nil, b) if so, yield that this means any slice used that way need to be checked for nil or sort.Interface needs to check its argument for nil before using it and c) if that equality doesn't hold, explain why it's a problem to have interface{}((*int)(nil)) != nil, but not a problem to have interface{}(([]int)(nil)) != nil.

So you need to at least explicitly say a) whether you want e.g. sort.Interface(sort.IntSlice(nil)) == nil

yes. As I said before sort.IntSlice would have to be modified for sorting to still work. Alternatively and much easier simply change (in sort package) func Sort(data Interface) to:
func Sort(data Interface) {
  if data == nil {return} // this is new
  // the rest is unchanged
}

b) if so, yield that this means any slice used that way need to be checked for nil or sort.Interface needs to check its argument for nil before using it

Calling any method in sort.Interface requires the type to be resolved (as it does in current go), and panics if the type is the zero value (also as it does in current go, sort.Interface(nil).Len() panics). The type (whichever it is) that it resolves to does not need nil checking. In your example, you can guarantee that it is a non-nil sort.IntSlice (underlying type []int)

It is my impression that your thinking is heavily influenced by classes in OO-languages

Unlikely because I come from Maths not CS, I barely did any formal OO classes :laughing:. But who knows where the influence lies...
Thanks for the great feedback today, @Merovius . Looking forward to resume this very soon

just to verify we are on the same page, by 'nil check' I mean a runtime check that panics with nilPointer on nil. That is what you mean too, right?

No, I'm talking about if foo == nil { … } code. AFAIK what you are talking about doesn't exist - if you dereference a nil-pointer, the process gets a SIGSEGV and the runtime translates that into a panic. So the generated code assumes optimistically that pointers aren't nil and lets the regular hardware/kernel mechanisms catch it.
I'm concerned with actual code - that is, how would the way we write Go have to change to maintain correctness. I don't see any reason to touch how nil/pointers/interfaces interact at all, except to reduce the number of comparisons to nil in correct code.

LoopFoo has no direct requirement on x being non-nil, it doesn't have to check it. But Foo does need to check it, and it gets called 100 times. Thus in this scenario current go would do many more checks that my proposal.

As I said, these checks don't exist. But FTR, even if they would - I highly doubt it would matter in practice. CPU branch predictors are very good and with modern architectures this wouldn't actually incur any cost except in extreme edge cases.

Alternatively and much easier simply change (in sort package) func Sort(data Interface) to:

Yes, that's the second half of my b) :) But it's good to get a definitive "yes" from you that you intend to also have this apply to non-pointers. :)

Unlikely because I come from Maths not CS

FTR: Me too ;)

AFAIK what you are talking about doesn't exist - if you dereference a nil-pointer, the process gets a SIGSEGV and the runtime translates that into a panic. So the generated code assumes optimistically that pointers aren't nil and lets the regular hardware/kernel mechanisms catch it.

Oh. I was under the wrong assumption on that, and it does mean the runtime nil-check reductions my proposal promised are not real (as there are no such thing as runtime nil checks! 😞). That reduces the advantages of this proposal only to removing the interfaces with dynamic value nil issue, but makes some code trickier (see sort.IntSlice part) and makes what would have previously been a nil panic on a specific method and type a nil panic on an untyped nil (thereby making it likely harder to debug). And on top of that it is a significantly backwards-incompatible change.
Overall I think it is time to acknowledge this introduces more problems than it solves. Thanks for the feedback @Merovius . 👋


Allowing for upcasting past the maximum spell slot level

Currently, when using the Cast activity to cast a spell, the maximum level of the spell is the maximum level of the spell slots you have.
The issue is with abilities like the Twinned spell metamagic option, you could upcast spells higher than your maximum spell slot level. It is currently not possible to do so. Casting Command as a level 2 Sorcerer and twinning it makes it the same as if you casted it at 2nd level, which you don't have spell slots for yet.
Support for upcasting up to certain actor properties like the proficiency bonus could also be great. Also, support for upcasting using class resources other than spell slot and/or Sorcery Points could be a nice addition to the versatility of the feature.

This is a feature we would like to be able to make us of in a premium module as well (Drakkenheim).
It gets more complicated cus there are in some examples two resources involved; spell slots and an item's limited uses. The spell slot determines an initial level, and expending uses then increases the level beyond this (possibly beyond what level of slots is normally available).


[Web Portal] home page

#2513

Coverage decreased (-0.01%) to 52.932% when pulling 5048a7cebee43da6a53b8d5b6f9b22a5dc0723ec on qinsu/home into 2cf8c6c45f75d59ddaa0d41d87aaa56f84ca359b on master.

Coverage decreased (-0.01%) to 52.932% when pulling 5048a7cebee43da6a53b8d5b6f9b22a5dc0723ec on qinsu/home into 2cf8c6c45f75d59ddaa0d41d87aaa56f84ca359b on master.

Coverage decreased (-0.01%) to 52.932% when pulling 5048a7cebee43da6a53b8d5b6f9b22a5dc0723ec on qinsu/home into 2cf8c6c45f75d59ddaa0d41d87aaa56f84ca359b on master.

Also, please resolve merge conflicts


Implement ghpc_stage function to stage files into deployment

Add function ghpc_stage(path string) -> string,
during ghpc create the staged files (directories) will be placed into dedicated directory within deployment folder and relative path (from any deployment group) will be the result.
Usage:
Useful for referencing files by relative path and moving deployment folder.
vars:
  ...
  # hello.sh is a local file at $(pwd)/hello.sh
  script_path: $(ghpc_stage("hello.sh"))
  ...

deployment_groups:
- group: primary
  modules:
  ...
  - id: script
    source: modules/scripts/startup-script
    settings:
      runners:
      - type: shell
        destination: hello.sh
        source: $(vars.script_path)

  - id: workstation
    source: modules/compute/vm-instance
    use: [network, script]
    settings:
      machine_type: n2-standard-2

Limitations:

Currently ghpc_stage function can only be used in vars block.
Attempt to use it directly in module settings would lead to create-time error:

Errors (e.g. invalid path) can't not be attributed to the position in the blueprint yaml file yet.

The value for ghpc_stage evaluated and actual staging are done during create. Changes to the terraform.tfvars will not affect it, unless ghpc create is called again. E.g.:

vars:
  a: "path.txt"
  b: $(ghpc_stage(vars.a))
  # changes to vars.a after create will not change the value of vars.b

Details:
$ tree ~/tmp/t2/
/usr/local/google/home/orlov/tmp/t2/
├── d
│   └── j.txt
├── f.txt
└── tst.yaml

$ cat ~/tmp/t2/f.txt
content-of-f-txt

$ cat ~/tmp/t2/d/j.txt
content-of-d-j-txt

$ cat ~/tmp/t2/tst.yaml
...
vars:
  fp: $(ghpc_stage("f.txt"))
  djp: $(ghpc_stage("d"))/j.txt

deployment_groups:
- group: primary
  modules:
  - id: f
    source: modules/network/pre-existing-vpc
    settings:
      network_name: $(file(vars.fp))
      region: us-central1

  - id: dj
    source: ./modules/network/pre-existing-vpc
    settings:
      network_name: $(file(vars.djp))
      region: us-central2

$ ./ghpc create ~/tmp/t2/tst.yaml --out=/tmp/

$ tree /tmp/tst/.ghpc/
/tmp/tst/.ghpc/
├── artifacts
│   ├── DO_NOT_MODIFY_THIS_DIRECTORY
│   └── expanded_blueprint.yaml
├── previous_deployment_groups
└── staged
    ├── d_8277e0910d
    │   └── j.txt
    └── f.txt_8a7cbf1fec

$ cat /tmp/tst/primary/terraform.tfvars
...
djp = "../.ghpc/staged/d_8277e0910d/j.txt"

fp = "../.ghpc/staged/f.txt_8a7cbf1fec"
...

$ ./ghpc deploy /tmp/tst
...
The subnetwork: content-of-d-j-txt could not be found in project: zzz and region: us-central2.
...
The subnetwork: content-of-f-txt could not be found in project: zzz and region: us-central1.

This review does not focus on the implementation details, but the user experience. My first thought is that it is very good that we support HCL functions in the Toolkit, but they are not yet very well documented for users. Additionally, ghpc_stage doesn't manifest to the user any differently than an HCL function, so I'm not sure that it will be obvious where to look for the behavior of functions (esp. for users not familiar with Terraform). We will have to do a good job of documenting the file staging and how ghpc_stage values resolve in a blueprint.
An function-less alternative that I think you and the code reviewer might consider as more intuitive:
vars:
...

local_files:
  file1: path/to/file
  dir1: path/to/dir

deployment_groups:
- group: grp0
  modules:
    id: mod0
    settings:
      script: $(local_files.file1.content)
      folder_path: $(local_files.dir1.path)

You could imagine other attributes like abspath, basename, md5sum, zip and so on. Even if these were implemented in our deployments as HCL functions, the behavior seems more self-explanatory and create-time validation could be performed. For example, md5sum attributes would be rejected when pointing to a directory. Other ideas:

validator that notices when the path of the blueprint contains local_files not staged
validator that warns when absolute paths are used in local_files (in my view is a bad practice).


Trying to force content mode LTR to RTL in DSkit

I'm trying to make the app support more than one language and regarding this, I want to make my app support (Rtl) specific languages

Could you explain why you think this relates to dskit?


Time Bar Graph issue with specific time/date

Expected Behavior

To draw the graph with "2019-03-10T02:00:00" on the x-axis with the other values also visible
Current Behavior

Does not seem to draw the specific date/time "2019-03-10T02:00:00". It will draw the graph correctly if that specific date is not included into the x-values. It does not even draw the date/time on the x-axis.
Possible Solution

May be an issue with Moment.js
Steps to Reproduce (for bugs)

https://codepen.io/anon/pen/QeyYWW
Environment

Chart.js version: 2.8.0 dist/Chart.bundle.min.js
Browser name and version: Chrome 75.0.3770.142

The issue turned out to be because of daylight savings

+1

@kingenelson thanks for circling back on this. @benmccann @simonbrunel since you've done a lot on the timescale, do you know what might be causing this?

Not sure, but it works if I pass in milliseconds for the x values (e.g.<PHONE_NUMBER>000,<PHONE_NUMBER>000,<PHONE_NUMBER>000), which might be a good workaround and is probably the better thing to do long-term anyway

Don't work with milliseconds

hi @kingenelson ,  do you have any luck on this ?

I also have this issue causing the dot of the line not sitting in the grid line.
The dot line has the DST hour.
Thanks,
A

Closing as resolved


07/19/2018 00:36 : Create Pull Request for branch prTesting_2018071900 -> master

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Higlass as a dependency not compatible with webpack 5 using Node 16

Steps to reproduce

Use Node 16 (and therefore npm 8 where peerDependencies are always installed)
Create a package.json with both higlass and a package requiring webpack 5
Due to unminified-webpack-plugin: ^2.0.0, it will always install webpack 4 on the root level of node_modules

Observed behavior

With node_modules/webpack being of version 4, it breaks some scripts which rely on it being on version 5.

Expected behavior

It should not at all install unminified-webpack-plugin as dependency, but probably devDependency?

Here, unminified-webpack-plugin is tagged to version ^2.0.0. One could either upgrade to ^3.0.0 (which is webpack 5 only), or move it to devDependencies. Is there a reason why it is included in dependencies instead?

No reason. If you a moment, would you be interested in submitting a PR to fix it?

Actually, would you mind trying the pkerpedjiev/webpack5 branch if you have a moment?


Fixed outdate variable name

leveldb::Options::cache  ==> leveldb::Options::block_cache

I signed it!

@googlebot rescan

Thx for the PR @1Feng. Didn't process your PR (my bad) and this was already fixed in 6a6bdafc.


DX9 ImGUI viewport is blurry

Maybe 0.5 texel offset is missing? DX9 needs this.
I know we don't need DX9, but it's not removed yet.
Maybe we can just ignore it.

What am i looking at? Seems like normal antialiased shape. ImGui backends handle 0.5 offset when needed.

Seems like normal antialiased shape

I don't have antialiasing.

This is broken for DX11 too. Priority raised.

You really should provide more details. I am unable to reproduce it. Even with DPI scale artificially set to 2.0f viewport is still sharp.

Try 125% scale on Windows.

Looks fine to me.

The blurriness of viewport depends on actual viewport size. By scaling viewport I can make it blurry or sharp. Can you try a few different sizes? I also suggest you to use just gray box on black background for testing.

Provide exact steps how to reproduce... Come on, you are developer. You should know how to make a proper bug report

Run Editor with DX11 API and system viewports, with Windows DPI scale equal 125%, with screen resolution equal to 1920x1080.
Place gray box.
Resize window so the client rect aka rect in SceneTab::ResizeMainViewport is { 309, 75, 1195, 462 }.
textureSize should be equal to { 1107, 483 }. Box edges should be slightly blurry.

I have a suspicion what causes this defect.
In SceneTab::ResizeMainViewport we get rect already downscaled by DPI and then we upscale it again to get texture size. We may lose some stray pixel there.


5.3| Fix to support rawk8s 1.19+ mutation certs

Updated certificates generation needed for communicating kube-api server.
added subjectAltName to the server.conf file.

@xB-2048 @rshmiel


Update documentation re. shards

As per Ex-shards documentation, "since ex_shards uses shards, make sure that shards is started before your application"
Failure to do so results in this error:
** (Mix) Could not start application MyApp: MyApp.start(:normal, []) returned an error: shutdown: failed to start child: Together.Supervisor
    ** (EXIT) shutdown: failed to start child: Together.Store
        ** (EXIT) an exception was raised:
            ** (CaseClauseError) no case clause matching: {:error, {:noproc, {:gen_server, :call, [:shards_sup, {:start_child, [MyApp.Together.Store.Shards, []]}, :infinity]}}}
                lib/together/store.ex:3: Together.Store.start_link/2
                (stdlib) supervisor.erl:365: :supervisor.do_start_child/2
                (stdlib) supervisor.erl:348: :supervisor.start_children/3
                (stdlib) supervisor.erl:314: :supervisor.init_children/2
                (stdlib) gen_server.erl:365: :gen_server.init_it/2
                (stdlib) gen_server.erl:333: :gen_server.init_it/6
                (stdlib) proc_lib.erl:247: :proc_lib.init_p_do_apply/3

Thanks @calebdel


[QBD] Handle the initial connection for QBD

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/49697
PROPOSAL:
Tests

Prerequisites: Turn on Beta quickbooksDesktopOnNewDot on your account
In Web/Desktop

Sign in on an account that enabled beta quickbooksDesktopOnNewDot
Go to any Workspace
Enable Accounting if it hasn't enabled
Go to Workspace's Accounting
Verify that the QuickBooks Desktop connection is available
Click on "Connect" button
Verify that it shows "QuickBooks Desktop setup" page
Verify that the setup link is shown

In mWeb/Native apps

Sign in on an account that enabled beta quickbooksDesktopOnNewDot
Go to any Workspace
Enable Accounting if it hasn't enabled
Go to Workspace's Accounting
Verify that the QuickBooks Desktop connection is available
Click on "Connect" button
Verify that it shows "Can't connect from this device" page

[x] Verify that no errors appear in the JS console

Offline tests

Unable to test in offline
QA Steps

Same as above

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/18c7c378-e990-43a0-b7d4-7a8edfcce67c

Android: mWeb Chrome

https://github.com/user-attachments/assets/ed416bdf-36e7-43c3-967d-930a95da0fe8

iOS: Native

https://github.com/user-attachments/assets/cccacdac-93ab-4235-8eed-48e4848c757f

iOS: mWeb Safari

https://github.com/user-attachments/assets/1447cd93-b0b0-4a97-8851-3837e278eaac

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/cdd10529-b1be-4072-abe5-de3368381214

MacOS: Desktop

https://github.com/user-attachments/assets/4a537efc-12b8-45e3-9a9a-3422119fb083

@hoangzinh this is going in the right direction. Once the PR will be ready, I'll trigger an ad hoc build so Design team can review it.

@Expensify/design feel free to test if everything looks good!

Happy to test. I can't find quickbooksDesktopOnNewDot on Betaify. Maybe I'm looking in the wrong place?

Happy to test. I can't find quickbooksDesktopOnNewDot on Betaify. Maybe I'm looking in the wrong place?

Log in with an @expensifail.com account, you'll already have all the permissions.
The beta's code hasn't been deployed to prod yet, so it might explain why you didn't find the beta.

This illustration looks a bit tight to the headline and a tad big:

Can we align it a tad more closely with the mock?

Otherwise this looks good

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


OpenAIEmbeddings: retry_min_seconds/retry_max_seconds parameters

Description: new parameters in OpenAIEmbeddings() constructor (retry_min_seconds and retry_max_seconds) that allow parametrization by the user of the former min_seconds and max_seconds that were hidden in _create_retry_decorator() and _async_retry_decorator()
Issue: #9298, #12986
Dependencies: none
Tag maintainer: @hwchase17
Twitter handle: @adumont

make format ✅
make lint ✅
make test ✅

cc @hwchase17

The ratelimit is imposed by OpenAI (or Azure). So this won't remove it. But
instead of retrying every 4 sec for example, you can override the default
values. For example in my case when I trigger an  RateLimitError , the
message indicates I have to wait 40 sec, so I set the min to 40sec. Like
that I know it won't retry until 40 sec.
Alex
On Thu, Dec 7, 2023 at 1:30 PM Andrés F. Murillo @.***>
wrote:

This does not seem to solve the rate limit error when using chromaDB and
ada002 to embed. I still got the same RateLimitError (even though the
requests we were doing were well below our ratelimit). Using Chroma default
embedding function "all-MiniLM-L6-v2" seems to work.
—
Reply to this email directly, view it on GitHub
https://github.com/langchain-ai/langchain/pull/13138#issuecomment-1845260908,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACRLWXT6IT6F5BATC3UKRDYIGZHTAVCNFSM6AAAAAA7E5U5WSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBVGI3DAOJQHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hello Alex,
Thank you for your response. Yes, I had tried that with previous verions of langchain and openai (following your suggestion before this commit was merged). Nevertheless, in this case I don't get the message indicating the time to wait. I even overode the default values with 60 second as minimum and still did not work.

Hello folks. Updating to the last update solved the rate limit error i was getting when using ada for embeddings.


SPARK-15816: SQL server based on Postgres protocol

1. Describe the feature
Looks like a promising feature for Kyuubi to have
https://issues.apache.org/jira/browse/SPARK-15816
2. Motivation
3. Describe the solution
4. Additional context

A related project https://github.com/maropu/spark-sql-server


Small oauth2 sso fix

Description
Small oauth2 sso fix - variable name wrapped in quotes
Waltz Version
No response
Steps to Reproduce

...
Expected Result
No response
Actual Result
No response

ready to merge


Fortran runtime error when crop code not found in DETAIL.CDE

FIND_IN_FILE() is generating a Fortran runtime error when the specified crop code is not found in DETAIL.CDE. I need to investigate further to isolate the problem.

@palderman we can also have @fabiooliveira72  take a look.


Improve Tool Tips

Tool Tips could be useful to make sure that ppl can easily understand a data hunch. Here are a few examples and redesign suggestions:

This tool tip could be:

Hunch: The category should be () Europe
Comment: Turkey is historically part of Europe
Author: Haihan

This tool tip could be:
> Hunch: The value should be ~2200
> Comment: This contains test values from the weekend.
> Author: Alex


redis auth???

how can i config redis??
redis://auth:pasword@xxx:6379 ?

Doesn't support yet.

expected time for support?

Have no plan.

好的。射射你。不想写英语了。心好累。还有resultdb taskdb 求顺便加下前缀吧。懒得开多一个库，

What prefix? redis? Only taskdb is supported for redis.

mysql的数据库创建的时候加下表前缀。不然我把taskdb和resultdb都放在同一个库放不了~表名冲突了

Take a look at this issue: https://github.com/binux/pyspider/issues/188

https://github.com/binux/pyspider/pull/276 support redis auth.
This issue can be close.

yes thank you @littlezz


suggestion

What feature do you want to get added on the base engine?
i think playable characters would be cool to see added. plus it would also help with modders who dont know how to add playable characters
To test your sight, and reliability, please select the option of what should NOT be requested.
Stage Editor, 6K+ support, and winning icons.

this was already declined, they're not hard to add anyways

we don't want it here


Capital queries - "attribute" and "where" mismatch returns null instead of an IllegalArguementException

code logic flows differently to how presumed by tester. have split this test into two distinct tests. one for when there is no where specified by user, which means it runs all in world query and one which looks at what happens when there is a mismatch


support of sugarss

demo
  "cssModules": {
    "extensions": [
      "sss"
    ],
    "parser": "sugarss",
  }

Thanks! I'll take a look at this ASAP.


Implement reversion of nodes after editing via searcher.

Pull Request Description
Add functionality to revert a node that was changed during editing through the searcher.
Note that currently, nodes are not edited by the searcher, except upon confirmation, Thus this functionality results in a no-op at the moment.
Important Notes
[ci no changelog needed]
Checklist
Please include the following checklist in your PR:

[x] The documentation has been updated if necessary.
[x] All code conforms to the
Scala,
Java,
and
Rust
style guides.
All code has been tested:

[x] Unit tests have been written where possible.
[x] If GUI codebase was changed: Enso GUI was tested when built using BOTH
./run ide dist and ./run ide watch.

Actually, as I've checked the aborting editing... do not revert the expression at the moment. I think this is a regression. So we actually can check if this branch fixes it.

After checking, it appears that this is not fixed by this PR at the moment. Only the source code is reverted, the view logic was not changed and seems not to revert right away, only after some other update triggers a re-evaluation of the view expression.

Actually, as I've checked the aborting editing... do not revert the expression at the moment. I think this is a regression. So we actually can check if this branch fixes it.

After checking, it appears that this is not fixed by this PR at the moment. Only the source code is reverted, the view logic was not changed and seems not to revert right away, only after some other update triggers a re-evaluation of the view expression.

The tracking issue is filed here: https://www.pivotaltracker.com/story/show/182926584
This should be fixed in a later stage of the user story that reworks some of the related functionality.


Upgrade Confluent platform to 3.0.1 release

Good news everyone! Confluent 3.0.1 is out!
After bumping the version, we should also include a new integration test to make sure that identical schemas with different names no longer cause issues when using the Confluent Avro Converter. However, Confluent hasn't yet released a new Docker image for the 3.0.1 release of Schema Registry (issue created here), so no integration tests (new or existing) can be run with the new version of the platform just yet. We should probably block for now on them releasing updated Docker images before updating to 3.0.1 so that we can have some kind of reliable sanity check to make sure that everything works as expected.

Thanks! :)

this one is complete


Add tests for QuickPickItemButton API

For testing could the QuickPick object have a triggerItemButton function that is not in the API interface and triggers the code for handling button clicks in the renderer? (Maybe that function could only be added when running in 'test' mode? If that's easily detectable.)
Originally posted by @chrmarti in https://github.com/microsoft/vscode/issues/130519#issuecomment-896522711

I think that testing this will be really flaky... so I've decided to not do this for now.


Redis error in CF

I followed the http-cassandra sample and deployed a dataflow-server on Cloud Foundry. Created two services, Redis and Rabbit from CF Marketplace and bound to the app. I am able to connect the shell to the server endpoint. However, when registering the http module

module register --type source --name http --uri maven://org.springframework.cloud.stream.app:http-source-rabbit:1.0.0.BUILD-SNAPSHOT --force

I get the following error "Cannot get Jedis connection; nested exception is redis.clients.jedis.exceptions.JedisConnectionException: Could not get a resource from the pool". I have bound to Redis service version 2.8.23
Is this an incompatibility issue and if yes, how can I make the cloud foundry dataflow server work with this particular version?

Hi, @linusviking:
Thanks for reporting this.
I believe 1.5.x release of the PCF Redis-tile builds upon 3.0.x OSS Redis release. Which version of the Redis-tile are you using?
There isn't any strong correlation for SCDF and Redis. Since this error relates to unsuccessful connection attempt with your Redis instance, can you bind and use this instance for any other app? Are you able to connect to this instance from redis-cli?

Thanks @sabbyanandan
The managed Redis service instance in my org is reporting version 2.8.23. I am able to bind to this service instance from a test app. Is there a way I change the jedis version in SCDF code?

What version of jedis are you using?  SCDF is using jedis 2.7.3.  Is there a deeper stack trace you can post.  Generally speaking Jedis claims that 2.7.3 is fully compatible with redis server 2.8.x and 3.0.x.  See https://github.com/xetorthio/jedis

I tested using the local spring cloud data flow server against redis-server 2.8.23 and the module register command worked.  There maybe something more subtle going on since in the case of cloud foundry it is the buildpack that is creating the connection factory whereas in the local data flow server it is done using spring boot autoconfiguration.
Here is one thing to try
and then add the following to the environment before launching the Data Flow Server on CF.
$ cf set-env my-dataflow-server JBP_CONFIG_SPRING_AUTO_RECONFIGURATION '{enabled: false}'
Also look at your test app to discover the actual HOST/PORT of the redis server host/port which will be in the VCAP_SERVICES environment variable.
Then set additional env-vars for spring.redis.host and spring.redis.port so that boot will create the connection factory.   Not sure if a password env-var is needed.
refresh the app and restart in CF.

Thanks @markpollack - I am able to see the redis host/port my test app is bound to. Could you please say what'd be the cf set-env syntax for spring.redis.host and spring.redis.port?

@linusviking: The error message is so generic it could be that the server cannot connect to it, maybe the connection pool limit is reached, or there's indeed some incompatibility issue. Could you tail the server logs, redo the register command and share the entire stacktrace, please?

@sabbyanandan @markpollack The issue has been resolved. It was a redis service broker issue in my org's CF instance. Thanks for your guidance.


Fix Codespaces configuration

Signed-off-by: Jinbo Wang<EMAIL_ADDRESS>
Fix #21301 - Fix the error when installing docker cli.
Add Java related configuration.

thanks for the PR
Hi @joshfree our vs code folks helped us to fix this codespace integration, would you please help dispatch this to someone and reviewed? Personally I'd really like this codespace support, esp when we doing some light pr review, it is very convenient

Looks good - just need to get the build passing!

/azp run java - cosmos - ci.spark


chore(Dependencies) : update jsoniter-scala-core, ... from 2.20.7 to 2.30.3

About this PR
📦 Updates

com.github.plokhotnyuk.jsoniter-scala:jsoniter-scala-core
com.github.plokhotnyuk.jsoniter-scala:jsoniter-scala-macros

from 2.20.7 to 2.30.3
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.plokhotnyuk.jsoniter-scala" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.github.plokhotnyuk.jsoniter-scala" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:early-semver, commit-count:1

Superseded by #730.


Conditionally install typing dependency only for python < 3.5

For #77.
I kept the dependency to typing for python < 3.5 instead of removing it altogether as it was easy to do, so that the package will not break for users on old python versions. Consequently, shoud I change the version to 1.4.10 instead of 1.5.0 ?

Thanks for this!
Yes, I think maybe do 1.4.10. I was thinking of moving to Python 3.6 so I could use f-strings in the code, but maybe it's better to maintain backwards compatibility. That would require a version bump.

I changed to 1.4.10. For the f-strings, maybe moving directly to Python 3.6 is a bit aggressive, but the decision is up to you anyway 😃  !
I think this is ready to merge, thank you !


Willnilges/servo calibration

Closes #27. I corrected the description, and then changed the wording to something that I thought was a little clearer.

Oops, my fork was behind, and this was already fixed 🤦🏻

np, if you want to redo the wording feel free to reopen with just that change 👍


nixos/networkd: fix networking.networkd.static test

Motivation for this change
Commit ca58bd0a50f38de43b401df716806c0f83479a8e broke the test networking.networkd.static. This happened because the test sets networking.defaultGateway. This is implemented by adding the gateway to the list of routes using mkDefault. The routes are then overridden by an empty list in the newly added code. Replace mkDefault with id so the two lists are merged and everything (hopefully) works as expected.
See https://github.com/NixOS/nixpkgs/pull/144590 for a more context.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg test networking.networkd.static networking.networkd.routes

@ofborg test networking.networkd.dhcpOneIf networking.networkd.dhcpSimple networking.networkd.link networking.networkd.privacy networking.networkd.virtual networking.networkd.vlan networking.networkd.wlanInterface

not 100% sure this is the perfect solution, but the scripted setup sets default gateways even harder and other link types also set their search domains with higher priority than standard option definitions. might be better to give genericNetwork an override argument for just the routes, but that's a larger problem.


[ZEPPELIN-1046] bin/install-interpreter.sh for netinst package

What is this PR for?
Implementation of bin/install-interpreter.sh for netinst package which suggested in the discussion.
Some usages will be
# download all interpreters provided by Apache Zeppelin project
bin/install-interpreter.sh --all

# download an interpreter with name (for example markdown interpreter)
bin/install-interpreter.sh --name md

# download an (3rd party) interpreter with specific maven artifact name
bin/install-interpreter.sh --name md -t org.apache.zeppelin:zeppelin-markdown:0.6.0-SNAPSHOT

If it looks fine, i'll continue the work (refactor code, and add test)
What type of PR is it?
Feature
Todos

[x] - working implementation
[x] - refactor
[x] - add test

What is the Jira issue?

Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
Put link here, and add [ZEPPELIN-Jira number] in PR title, eg. [ZEPPELIN-533]

How should this be tested?
Outline the steps to test the PR here.
Screenshots (if appropriate)
Questions:

Does the licenses files need update?
Is there breaking changes for older versions?
Does this needs documentation?

One more feature request for this, with downloading an interpreter, creation/insertion of relevant entry in conf/interpreter.json

Both suggestions are nice addition, and there is also a refactoring on TODOs so I guess it's WIP now.
👍  for making it part of the release, as discussed<EMAIL_ADDRESS>

@prabhjyotsingh I think that's good idea.
If this script runs before start Zeppelin, right after download and unarchive, Zeppelin will auto create conf/interpreter.json with all installed interpreters.
If this script runs after conf/interpreter.json created, it'll not update conf/interpreter.json. And i think it make sense while conf/interpreter.json might customized by user at this time, and user may not want to tough/add something into it.
I think we'll have better way to install interpreter once Zeppelin have dynamic interpreter loading capability (https://issues.apache.org/jira/browse/ZEPPELIN-598)
@felixcheung I have removed hardcoded list and updated to read list from text file conf/interpreter-list.

It's ready to review and merge.
Tried updated create_release.sh script. zeppelin-0.6.0-bin-all.tgz is about 498M while zeppelin-0.6.0-netinst.tgz will be about 208MB.

@Leemoonsoo Could you rebase and resolve conflicts?

@minahlee addressed your comments

Thanks for the effort @Leemoonsoo, @AhyoungRyu I've tested this branch and it works like a charm! I left few more comments, once they are addressed it's good to merge :)

Thanks @minahlee for the review. Addressed your comments!

Merging if there is no more discussion


[localize] XLIFF serializer should update instead of replace

When we write out XLIFF XML files after extraction, we always generate a completely fresh XML document from our internal data model.
However, this means any extra XLIFF nodes/attributes that may have been added to the document by the translation process (e.g. state="needs-translation") but that isn't part of our internal data model will be lost.
So, when there is an existing XLIFF document, we should update it rather than replace it to preserve these external changes.

I could try and give this one a go, if that is OK for you. Do you have any hints or remarks before I try myself at a PR? This is what I have in mind:

In or around XliffFormatter.encodeLocale try to load existing file (again...), build a map by trans-unit id attributes.
If file does not exist, initialize new document with basic elements (will be written later).
For each name

Get or create trans-unit for name.
Translation exists for name? Get or create target in trans-unit, add/replace element content with translation. Option 1: Always create target element without content or with source content. Option 2: Do not alter element content when target state is one of x, y,...
desc exists for name? Get or create note in trans-unit, add/replace element content with desc. Do not remove obsolete note elements.

Delete each trans-unit that has an id that does not correspond with a name in our set of messages, i.e. remove obsolete translations.


Don't add whitespace if no existing configure args

Signed-off-by: Adam Brousseau<EMAIL_ADDRESS>

We had an odd bug on our builds where a single configure arg was prefixed with a whitespace. This caused some parsing of that arg to fail. This fix will only add the whitespace if args already exist.


change module name to support v2

Change module name support v2 also fix issue #174

Thanks @nipeharefa I was about to take care of this today... Now I don't have to ;). I'm approving this, and will likely release a 2.1.1 via the v2.1.1 tag.


Integration Test - Release - 2021/10/04 01:40:41

Auto create for integration test. IssueCommandFlow

#pri1

Just type '#pri3'

#pri2

#pri3

#assign PRMergerTest1

#assign NonAllowedUser

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

#reassign PRMergerTest2

#reassign NonAllowedUser

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

#please-close

GitHub user PRMergerTest2 has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.


Nvidia not getting detected on systems using nvidia-container-toolkit

Upon installation of harbor I have noticed that the Nvidia GPU is not being used, based on the output of harbor cmd -h which does not include any compose files for Nvidia and the readings from nvtop. The reason for this seems to be the command docker info | grep -q "Runtimes:.*nvidia" which gives false return value because the nvidia-container-runtime is not installed. However nvidia-container-runtime is apparently deprecated by Nvidia and 'nvidia-container-toolkit' is the only needed component for running containers with Nvidia GPU acceleration. For this reason the detection of the Nvidia GPU should use different mechanism, e.g. command nvidia-container-toolkit -version.
Link to Nvidia detection code from harbor.sh in question:
https://github.com/av/harbor/blob/f25978a445099884f248f1a2c70fd70d734f1636/harbor.sh#L206C5-L209C7

Hi, thank you for trying out Harbor and for such a detailed bug report!
Just fixed it in v0.1.17, switching to the nvidia-container-toolkit detection.
I think the drawback will be that it will fail to detect the case when the toolkit is installed, but have not been configured with:
sudo nvidia-ctk runtime configure --runtime=docker

but I didn't test that

Thank you for the virtually immediate reply and fix! Your speed of developing this software is incredible.
As for the configuration, I never configured the docker this way you and Nvidia container toolkit documentation suggests. Instead I only used the docker with the flag --gpus all and everything worked as expected.
I will test both the fix and the outcome of using sudo nvidia-ctk runtime configure --runtime=docker on my configuration and report back to this issue.

I am sorry it took me so long, but I have  the results. I have tested the v0.1.17 on a systems with and without configured 'nvidia-container-toolkit' (that is 'nvidia-container-toolkit' is installed on both but on the first it is configured a runtime and on the second it is only installed) and 'harbor' works on both without issues, tested with default setup ('ollama' + 'webui').

That's awesome, thanks for a thorough test!

I'm closing this for now, but please feel free to re-open if there'll be anything to revisit


svg_loader: Fix calculation when stroke-width unit is percentage

When stroke-width unit is percentage, loader refer to the normalized diagonal of viewport.
+) Add Width type so as not to affect existing types.
https://svgwg.org/svg2-draft/painting.html#StrokeWidth
https://svgwg.org/svg2-draft/coords.html#Units
example)
<svg width="100" height="50" xmlns="http://www.w3.org/2000/svg">
   <rect x="15" y="15" width="70" height="20" fill="none" stroke="#F00" stroke-width="10%"/>
   <rect x="15" y="15" width="70" height="20" fill="none" stroke="#00F" stroke-opacity=".3" stroke-width="10"/>
</svg>

related issue: https://github.com/thorvg/thorvg/issues/2131

I found that this should also apply for the "r" attribute.


[SIDECAR] determine how the API behaves when fetching different entities that get migrated in 2.0

We need to determine how some of the API endpoints behave fetching data through the 2.0 boundary. The data scenarios are:

Account that was created in 1.x but not updated in 2.0
Account that was created in 1.x and updated in 2.0
Account that was created in 2.0
Package that was created in 1.x but not updated in 2.0
Package that was created in 1.x and updated in 2.0
Package that was created in 2.0

Ways to access data:

Fetch state_get_item for account/contract
"state_get_account_info"
"state_get_entity"
"state_get_package"
"query_global_state" (?)

As per @zajko ;

I'm blocked on the API discovery ticket by the bug Karan is working on (or at least is aware of - the one that prevents the node to upgrade from 1.x to 2.x with addressable entities enabled).

My general findings:

Regarding accounts

JSON RPC API "state_get_account_info" returns "Account" entity for non-migrated accounts. It returns "Account migrated to an addressable entity" error for migrated account. This is inconsistent with how "state_get_item" works, we might want to reconsider that.
JSON RPC API "state_get_item" with Key::Account (which is BinaryRequest::Get(GetRequest::State(GlobalStateRequest(Item(Key::Account))))) returns  Account for not migrated and a pointer to the addressable entity for migrated:

  {
    "jsonrpc": "2.0",
    "id": 124,
    "result": {
        "api_version": "2.0.0",
        "stored_value": {
            "CLValue": {
                "cl_type": "Key",
                "bytes": "1101df2cbf6601a1243bcbad13499d6f813e6eab23fc5b63e19eb428757675b13cbc",
                "parsed": "entity-account-df2cbf6601a1243bcbad13499d6f813e6eab23fc5b63e19eb428757675b13cbc"
            }
        },
        "merkle_proof": "<redacted>"
    }
  }

JSON RPC API "state_get_item" with Key::AddressableEntity(EntityAddress::Account) returns nothing for 1.x accounts, and AddressableEntity for migrated (which is expected)

state_get_entity for "entity_identifier": {"AccountHash":"account-hash-*"} returns Account when account is not migrated
state_get_entity for "entity_identifier": {"AccountHash":"account-hash-*"} returns AddressableEntity when account is migrated

"query_global_state" returns Account for not migrated and a Stored value "reference" to addressable antity for migrated (as for "state_get_item" with Key::Account

Regarding contracts

"query_global_state" with hash of contract returns Contract entity for non-migrated BUT the structure differs slightly fomr the response of v1 - in v1 the entry point structure was flattened:
v1 response:

   "entry_points": [
        {
          "name": "counter_get",
          "args": [],
          "ret": "I32",
          "access": "Public",
          "entry_point_type": "Contract"
        },
    (...)

v2 response:
     "entry_points": [
                 {
                     "name": "counter_get",
                     "entry_point": {
                         "name": "counter_get",
                         "args": [],
                         "ret": "I32",
                         "access": "Public",
                         "entry_point_type": "Called"
                     }
           },
      (...)

Bugs and eyebrowraisers that I found

(eyebrowraiser/bug(?)) I couldn't figure a way to migrate a contract. Is that event possible? Trying to call an entrypoint of a contract created in v1 results in a "The deploy was invalid: no such entry point" error
(bug) When trying to deploy a session wasm on an account that was created in 1.x I get a runtime exception. This does not happen if I just start a 2.0 node that runs with 2.0 created users. The error: "Unexpected variant of a stored value"
(eyebrowraiser) state_get_item for entity_account returns the AddressableEntity without the named keys. On the other hand, state_get_entity (either using “acocunt-hash-” or “entity-account-” keys yiela AddressableEntity with named keys


Add Flink accumulators

This PR adds accumulators to Flink BeamSink. They will provide some more insights to the user.
It also updates the readme.

looks good after adjusting the naming of the counters.

Fixed your comment. Thank you for the review!

:+1: Looks good to me!

:+1:


gamma shape parameter should always be float

here it's fine
https://github.com/igarnier/prbnmcn-stats/blob/60f23e00f153fc3a5bfa8a46211ae9a1c1c3d664/src/stats_intf.ml#L124
but here it isn't
https://github.com/igarnier/prbnmcn-stats/blob/60f23e00f153fc3a5bfa8a46211ae9a1c1c3d664/src/pdfs.ml#L84

Ah yes, I agree it's a bit sad. Implementing a general version (for arbitrary shape parameters) would require either

significant efforts to reimplement a numerically stable \Gamma function
using existing code (such as in Owl)
I wanted to go the second route but it's also a non-trivial amount of work to extract away the relevant portion of code (more precisely, their bindings to the Cephes C library).

oh i did not imagine this could be actually problematic... what about gsl? wrong license?

https://en.cppreference.com/w/c/numeric/math
the c stdlib apparently also has the gamma function and its log

The GSL is GPL-licensed (makes sense, it's a GNU project after all!). The glibc is LGPL licensed which should be fine if we only link. On the other hand, it'll probably mean that potential windows users won't be able to use the library anymore?


feature(retry): Delete retry mechanism

We should make rpc  fail quickly to prevent a retry storm.

@kevwan  PTAL


Add support for greater-than or lower-than

Hello,
First of all, thanks a lot.
It would be great if it was possible to add a few directives to show/hide elements which when screen is greater (or less) than a breakpoint. In angular material 1 there used to be directives like :hide-gt-sm or :show-lt-lg, it was very usefull.
Thanks a lot.

Hello no-more,
I will investigate how to do it and I mention if I can do it. ; )
you're welcome!

Hi,
Thanks for taking care of my request. I may have an idea for an easier implementation of this, instead of creating several components, a single one which could accept a list of size to display, for example "SM,MD" or "SM;MD" or "['SM','MD']" (I don't know which format is the best) would display when screen size match SM or MD.
Thanks.

Hi,
I'll try with your example:

 Mi element to show

 Mi element to hide

And with customized measures minimum and maximum : =>

Mi element to show

Mi element to show

Thank you for your contributions!  ; )

Hi,
I have already developed new features. Upgrade to version 0.1.1. I hope you find them useful. ; )
a greeting.


test spi loopback with dma fails on nucleo_f746zg

Describe the bug
When running the test in test/drivers/spi/spi_loopback on nucleo_f746zg in DMA mode, the test fails.
I tried running it on nucleo_f411re and nucleo_f413zh also, both pass.
I tried those specifically since they're both using dma v1, same as f746zg.
To Reproduce
Steps to reproduce the behavior:

go to tests/drivers/spi/spi_loopback
in the boards subdirectory, create a nucleo_f746zg.overlay file with the same content as nucleo_f411re.overlay
copy the contents of nucleo_f411re.conf to nucleo_f476zg.conf
run west build -b nucleo_f746zg
connect miso to mosi
west flash
see the test fail (buffer contents are different - only zeros instead of same content).

Expected behavior
Test passes
Environment (please complete the following information):

OS: Linux
Toolchain: Zephyr SDK

Additional context
From my debugging so far, it seems to be a timing issue. If I run this without optimizations at all (not the default), sometimes it works. If I use default optimization and add LOG_INF anywhere, it also works.
I'll update if there are any more updates from my debugging.

@avigreen1978 Txs for reporting this bug. Can you try to play with SPI pin slew-rate to see if this has an impact ?
nucleo_f411re and nucleo_f413zh are somewhat faster than nucleo_f746zg, this might explain different behavior.

I tried to raise the slew rate for all pins to very-high-speed for all except sck which default is very-high-speed, didn't help. (also tried high-speed for all except sck, didn't help).

Update: the bug is related to the enabling of the D-Cache in f7 soc.c init function.
For some reason, when D-Cache is disabled everything works perfectly.

Hi @avigreen1978,
The problem is probably cache coherency: because DMA 'bypass' Cache mechanism.
See some explanation here: https://community.st.com/s/question/0D50X00009XkhUW/hint-dma-and-cache-coherency
See also AN4839 https://www.st.com/content/ccc/resource/technical/document/application_note/group0/08/dd/25/9c/4d/83/43/12/DM00272913/files/DM00272913.pdf/jcr:content/translations/en.DM00272913.pdf

@ABOSTM Txs.
So, as mentioned in these links, we have 2 options then:

Deal with cache coherency on rx/tx (as done in i2s_ll_stm32.c)

+: Quick and easy to implement
-: Depends on handling of __DCACHE_PRESENT which doesn't look quite well done today

Set dma buffers on DTCM (as done in eth_stm32_hal.c)

+: Automatically handled
-: Harder to implement and requires all impacted boards to declare the DTCM zone

This issue is fixed by #27911

The same test also fails on nucleo stm32f767zi.
The irq of the Transfer complete for the Rx channel never comes.

More than  #27911  the test config requires the CONFIG_SPI_STM32_UNALIGNED_DMA=y
for example in a tests/drivers/spi/spi_loopback/boards/nucleo_f746zg.conf


Store Rank Commands

Aria Rank Commands issues: /glow | /pos doesn't work, is the command /position. | /pokestats doesn't show any stats, it just shows "Your stats:" and is blank.
Nova Rank Commands issues: /glow | /pos doesn't work, is the command /position. | /pokestats doesn't show any stats, it just shows "Your stats:" and is blank. | /head is supposed to be /skull. | /mobhead doesn't work. |
Jade Rank Commands issues: /glow | /pos doesn't work, is the command /position. | /pokestats doesn't show any stats, it just shows "Your stats:" and is blank. | /head is supposed to be /skull. | /mobhead doesn't work. | /ender is /enderchest. | /weathervote doesn't work.
Rune Rank Command issues: /glow | /pos doesn't work, is the command /position. | /pokestats doesn't show any stats, it just shows "Your stats:" and is blank. | /head is supposed to be /skull. | /mobhead doesn't work. | /ender is /enderchest. | /weathervote doesn't work. | /logmessages is /logmessage. | /condense & /uncondense don't work. | /ext doesn't work. | /repairhand is /repairitem hand |
Omen Rank Command issues:  /glow | /pos doesn't work, is the command /position. | /pokestats doesn't show any stats, it just shows "Your stats:" and is blank. | /head is supposed to be /skull. | /mobhead doesn't work. | /ender is /enderchest. | /weathervote doesn't work. | /logmessages is /logmessage. | /condense & /uncondense don't work. | /ext doesn't work. | /repairhand is /repairitem hand | /breeding doesn't work.

breeding is disabled due to multiple exploits
glow is being worked on with much better extensibility.
pokestats has been forwarded to pixelmon team as non-working
/mobhead is no longer functional, and is replaced by skull.
/uncondense is no longer functional

Yes, I'm aware. The reason I made the ticket is because they are still listed in the store ranks but they either don't work, aren't available anymore or they aren't listed as the correct command, and they need to be removed/edited.

@Rasgnarok Should be able to fix some of these on the webstore, and we can also take a look at what other permissions are redundant/need to be fixed, such as /position.

Aria Rank Commands issues:
/glow coming back this month
fixed /pos
/pokestats needs Pixelmon report
Nova Rank Commands issues:
/glow coming back this month
fixed /pos
/pokestats needs Pixelmon report
replaced /head and /mobhead by /skull
Jade Rank Commands issues:
/glow coming back this month
fixed /pos
/pokestats needs Pixelmon report
replaced /head and /mobhead by /skull
fixed /enderchest
/weathercote coming back this month
Rune Rank Command issues:
/glow coming back this month
fixed /pos
/pokestats needs Pixelmon report
replaced /head and /mobhead by /skull
fixed /enderchest
/weathercote coming back this month
fixed /logmessage
removed /uncondense
removed /ext
fixed /repairitem hand
Omen Rank Command issues:
/glow coming back this month
fixed /pos
/pokestats needs Pixelmon report
replaced /head and /mobhead by /skull
fixed /enderchest
/weathercote coming back this month
fixed /logmessage
removed /uncondense
removed /ext
fixed /repairitem hand
will look into /condense (needs separate ticket on Gitlab @WisconsinWinters)
removed /breeding, replaced with kit hourglasses


Use correct md code fence

Preview:
cargo build --release --example parselog
vim | target/release/examples/parselog

thanks!


how to edit alpha splash text/version text/HUD?

title

Same as any other version. Splashes would be in GuiMainMenu or in splashes.txt (which doesn't exist until later), so it's the latter. Version text is set in Minecraft.java and HUD text is set in GuiIngame.java.
Closing as this doesn't relate to RMCP itself. You should join the Modification Station Discord if you want to get more dedicated help as this is not the place for this.


feat(list): update php config directives

Signed-off-by: Felipe Zipitria<EMAIL_ADDRESS>Fixes #2650 .
We need to figure it out if we want some of the words that might be prone to FP like engine, extension, from and precision.
Need to review also where the mssql config is now 🤔

This could be enhanced a bit more using the links from https://www.php.net/manual/en/funcref.php and following all the book\.*\.php links. My xpath is a bit rusty, but probably can be done with no problem.
One example is the https://www.php.net/manual/en/book.apcu.php has ini configuration in https://www.php.net/manual/en/apcu.configuration.php. Then we extract from the configuration page all the ini settings as we did with the others.

With this I can have the list of books: xidel https://www.php.net/manual/en/funcref.php -e '//a/extract(@href, "book\.(.+)\.php", 1)[. != ""]'. But that is the far I can get with only xpath for now.

This is ready to go, IMHO.

I like it. It's almost perfect. 😉 I think we should remove last_modified, I can see that being sent a lot in plaintext, API's, et cetera, and give false positives.

Thanks for the review!


fix Top Collection buttons

Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

(please remove design and QA checks below if not needed)
Needs Design check

@exezbcz please review

Needs QA check

@kodadot/qa-guild please review

Context

[x] Closes #10267
[ ] Requires deployment <worker/stick/speck>

Before submitting pull request, please make sure:

[ ] My contribution builds clean without any errors or warnings
[ ] I've merged recent default branch -- main and I've no conflicts
[ ] I've tried to respect high code quality standards
[ ] I've didn't break any original functionality

Optional

[ ] I've tested it at </ahp/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Did your issue had any of the "$" label on it?

[ ] Fill up your DOT address: Payout

Community participation

[ ] Are you at Koda Ecosystem Telegram?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

i think changing the neobutton css directly affected too many items across app, can you come up with a different solution?

@FG-HJ you requested a new review but I don't see any new changes , forgot to push ?

@FG-HJ there should not be changes in the pnpm-lock.yaml file in your PR


Can't get it work with android emulator on VS 2017 15.9.9

Hello,
firstly thank you for your effort making this plugin. It is what I always missed while developing with Xamarin Forms. Unfortunately I can not get it running. So far I did following steps:
-In my .Net Standard typed project in the Android project I opened the references and installed xamlator nuget package.

Then I started my emulated device and after starting typed from Extras->Android->adb cmd "adb reverse tcp:8488 tcp:8488" (also tried typing first then starting the emulator device
I added the additional lines in the OnCreate class.
I build the project and started debugging without erros but nothing happened modifying xaml and saving it.

Am I missing some steps? Did I something wrong?
Yours

XAMLator can't be installed in the .net standard shared project, it has to be installed in the native project, the Android application in your case.
The visual studio addin is WIP in #16, it will be soon submitted to the market place

Hello ylatuya,
thanks for the fast reply.
For my understanding you mean when I want to use this tool, I need to choose as project template Xandroid-XAML-App (Xamarin.Forms) and not the Cross-Platform template where I install it in the Android project?
Yours

You can use the .netstandard approach instead of the shared project one. If you look at the sample app in XAMLator, it's also using .netstandard project to share code, but the XAMLator nuget is added to the application projects,  XAMLator.SampleApp.Android, XAMLator.SampleApp.iOS, etc... instead of XAMLator.SampleApp.

Hi @ylatuya, Is the https://www.nuget.org/packages/XAMLator/2<IP_ADDRESS> ready for Windows ?
Thanks

@ylatuya: I tried the provided Samples but it also not working with them. Seems that something is wrong with my IDE configuration. I just wait until the nuget package releases.

We will release the Visual Studio for Windows extension soon, are you testing with the extension installed compiling the code or without the extension?. Without the extension will not work.

@jsuarezruiz , I didn't have the extension installed. Is there a extension from the CI build that we can download before it is published in the marketplace ?
Besides hot-reload (which we are excited for), will XAMLator help us with the location of the errors where XAML may be failing / causing issues ? I think that's a very important need for Xamarin Forms development  community. Thanks for everything. Can't  wait longer... :)

@jsuarezruiz

I installed the nuget Xamlator package under the android project
I start my emulated Android device
add LoadApplication(new App());
#if DEBUG
XAMLator.Server.PreviewServer.Run();
#endif in main activity
Extras->Android->adb cmd "adb reverse tcp:8488 tcp:8488" typed
start debugging, does not work

This won't work on Windows until we publish the Visual Studio plugin.
Closing this as duplicate of #16

@ylatuya , @jsuarezruiz - can you please advice us when will this extn be available for VS 2019 on windows? Thanks


Copy the k8s config file to the controller

Create an ansible task/playbook that copies the k8s config into the ~/.kube folder on the controller.

Tried to also add the contents of the config file to the password store but it seems that the passwordstore Ansible plugin doesn't like having such a complex text. Even though I've transformed the dictionary to string have had problems with the quotes and the double quotes.

# Doesn't work as the contents is a multiline json. Fails with fatal: [vm20220316-t02]: FAILED! => {"msg": "Unexpected templating type error occurred on ({{ query('passwordstore', pass_provider + '/' + ansible_hostname + '/kube_cfg create=True userpass=' + get_config)[0] }}): can only concatenate str (not \"dict\") to str"}
# - name: "Add k8s config to passwordstore"
#   set_fact:
#     kube_config: "{{ query('passwordstore', pass_provider + '/' + ansible_hostname + '/kube_cfg create=True userpass=''' + k8s_config.stdout + ''') }}"
#   when: passwordstore_enabled | bool


Optionally skip intro

Netflix' HMTL5 player displays a "skip intro" button on the bottom right when watching series. Is this possible to implement?

i dont think that it is possible the skip the intro on a lets call it "video" basis.
This would - if it is possible - a general preference so that all intros are skipped.

It might be possible to do this by using event listener to key actions, etc.,
but I´d not prefer going down that road.
Another option could be (as I tried to implement this once), to provide a new context menu item for the video , that starts the video after the intro timestamp we received from the API.
As said, tried to implement this once, didn't work for I don't know reasons.
Any help appreciated: https://github.com/asciidisco/plugin.video.netflix/issues/34

Closing this, as any further discussion should happen in issue #34


Add Dockerfile

Pull request checklist
Description

Add Dockerfile containing Packer v1.7.4 and the python-packer code.
Screenshots (if appropriate):
Types of changes

[ ] This change requires a documentation update
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] Lint and unit tests pass locally with my changes.
[ ] All new and existing tests passed.

@abhi1693 can you add a hacktoberfest-accepted label to this PR?


Ruff: Add and fix RUF015

Add and fix RUF015 rule https://docs.astral.sh/ruff/rules/unnecessary-iterable-allocation-for-first-element/

It looks like there has not been any activity here for a while. In order to keep the list of pull requests in a manageable state, we are closing this one for now. If we are making a mistake here, please reopen the pull request, and leave us a note 😄


feat: Port CategoryTheory.Limits.Shapes.Multiequalizer

[ ] depends on: #2767

This PR/issue depends on:

leanprover-community/mathlib4#2767
By Dependent Issues (🤖). Happy coding!

It looks like the simpNF linter still has a lot of complaints. Any help would be much appreciated!

This PR/issue depends on:

leanprover-community/mathlib4#2767
leanprover-community/mathlib4#2791
By Dependent Issues (🤖). Happy coding!


Fix the image stretchy by using percentage 4 width

https://trello.com/c/R9iWiP01/603-images-are-still-being-stretched-at-larger-screen-sizes-in-the-image-gallery

This all looks good code-wise. Does the fix the stretchy image? And do you need to remove the * 0.8 now on padding-top or does that tie in with the 80%?

the .8 seems to be fine and it gets rid of the stretchy image. feel free to merge

Yeah, looking good to me :+1:


Adds default scopes for all UAA user tokens

When CF ships with notifications, users will need a couple new scopes to
be able to manage their notifications preferences. We are including
these scopes here so that all future users will have them.
[#83221726]

Merged as of 3cc17b057966756af7511f1a26f49109e1158bd2


Build Error: EntityFramework.Relational.FunctionalTests

FTY, I'm receiving the following compilation error when building EntityFramework-2014.sln:
Error CS0433: The type 'AsyncLocal' exists in both 'System.Threading.ExecutionContext, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'System.Threading, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'	EntityFramework.Relational.FunctionalTests.ASP.NET Core 5.0	TestSqlLoggerFactory.cs 19
However, after running 'build initialize', I was able to build the EntityFramework.sln just fine. :)

Closing, feel free to reopen if you have further questions


[POST-RELEASE][WEB] Updated iconography documentation reflecting the depracated class changes

Signed-off-by: Shijir Tsogoo<EMAIL_ADDRESS>

This was added to new website. No need to merge.


deleted extraneous files to use with Projects

deleted extraneous files to use with Projects

deleted extraneous files to use with Projects


Get DNS-IPv6 from current system resolvers

Allow IPv4 and IPv6 to get from resolv.conf.
Filter out commets by grepping "nameserver" from beginning of line. No additional comment filter need.
Replace multiple grep with single sed.

Shouldn't we get IPv6 resolvers only if IPv6 support is enabled?

Shouldn't we get IPv6 resolvers only if IPv6 support is enabled?

Yes, I was also thinging about.
I will change the PR.

By the way:<PHONE_NUMBER>0 and 134744072 are also valid IPv4 addresses, also without dots. Try it: https://01002004010/ or ping 134744072 it is google DNS <IP_ADDRESS>


Variations between Windows Versions

How do these features vary for the different release versions of Windows 10? i.e, what should we expect to get or not get when an endpoint is running 1909 vs 1803?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 001a64c5-bdea-ae9f-578e-a785bca20d23
Version Independent ID: b521d32a-cf9f-8b6a-0411-fd77537673e1
Content: Overview of endpoint detection and response capabilities - Windows security
Content Source: windows/security/threat-protection/microsoft-defender-atp/overview-endpoint-detection-response.md
Product: w10
Technology: windows
GitHub Login: @mjcaparas
Microsoft Alias: macapara

Hello @DeanGross ,
some of the response actions depend on the Windows version, more details are in the appropriate articles:
Take response actions on a machine
Take response actions on a file
Live response is available since 1903

@DeanGross - Thank you for submitting feedback.
From our understanding, the issue you raised has been answered by MaratMussabekov so we will close this issue.
Thank you for your contribution to make the docs better! Much appreciated!


Correct name of GitlabAPI Test

JUnit ignores GitlabAPIT because of wrong naming. Fixes naming issue.

Hello, I am not sure whether the project uses Maven or Gradle? When using Maven, the configured failsafe plugin will pick up all tests ending in IT automatically, so they are run not during mvn test but after the jar is packaged and before install.


Confirmation on Eureka behaviour about the API level detail

Hello
We have a situation where we wanted to use Eureka service registry and discovery. We are able to use the service discovery and we can able to get the service instance host name detail with following code taken from Spring.io
This will return us host detail for the given service but we would like to know what different REST API expose by that service and how we can call that REST API using service registry reference dynamically. Please let us know if any mechanism to find individual REST API from service registry and call those REST API.
@Component
class DiscoveryClientExample implements CommandLineRunner {
@Autowired
private DiscoveryClient discoveryClient;

@Override
public void run(String... strings) throws Exception {
    discoveryClient.getInstances("photo-service").forEach((ServiceInstance s) -> {
        System.out.println(ToStringBuilder.reflectionToString(s));
    });
    discoveryClient.getInstances("bookmark-service").forEach((ServiceInstance s) -> {
        System.out.println(ToStringBuilder.reflectionToString(s));
    });
}

}

If you are using spring-cloud-netflix, that is the right place to ask questions. Eureka has metadata you could use, but generally, if you ask for "photo-service", your client should know how to use it.

Thanks,
We are trying to use  Netflix Eureka as a service registry to register our services on Pivotal Cloud Foundry. Not sure which is correct place to ask this question.
Yes agree Eureka has metadata information but it does not expose the REST API level detail for individual service in metadata.
It contain detail such as "registrar_uri", "instanceId", "zone" etc those are mostly the service registry detail and not the service level detail.
The 'photo-service' is just an example. Yes client should be aware of the service but just looking for option to dynamically identify the service API from registry and call the API, if possible.

to dynamically identify the service API from registry and call the API, if possible.
I don't think eureka is the right thing for that.

Thanks Spencer for confirmation !!
Hi All - Request to please update here, if anyone is aware of any other way/tool to dynamically call API other than eureka on PCF, or else will close this issue in few days. Thanks all in advance.


assignment 2 completed

Drift Video
code smells because of test folder provided

Metric
Value

alert_status
:white_check_mark: OK

bugs
0

code_smells
9

reliability_rating
A (0 Bugs)Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)Note: A being best, E being worst

vulnerabilities
0


QG checks Release 23.12

QG checks
Please keep this issue open until QG is concluded and will be managed by the Issue Creator!
We will inform you about finding and proposals in separated issues.
The checks are focusing on mandatory aspects of our current Release Guidelines.
Please keep this issue open until QG is concluded!
Helm Chart Version: 1.10.15 (still only available as -SNAPSHOT)
App Version: 1.10.15 (still only available as -SNAPSHOT)
TRG 1 Documentation

[x] TRG 1.01 appropriate README.md
[x] TRG 1.02 appropriate install instructions either INSTALL.md or in README.md
[ ] TRG 1.03 appropriate CHANGELOG.md

TRG 2 Git

[x] TRG 2.01 default branch is named main
[x] TRG 2.03 repository structure
[x] TRG 2.04 leading product repository
[x] TRG 2.05 .tractusx metafile in a proper format

TRG 3 Kubernetes

[x] TRG 3.02 persistent volume and persistent volume claim is used when needed

TRG 4 Container

[x] TRG 4.01 semantic versioning and tagging
[x] TRG 4.02 Using an aligned base image
[x] TRG 4.03 image has USER command and Non Root Container
[x] TRG 4.05 released image must be placed in DockerHub, remove GHCR references
[x] TRG 4.06 notice file for DockerHub has all necessary information

TRG 5 Helm

[ ] TRG 5.01 Helm chart must be released
[x] TRG 5.02 Helm chart location in /charts directory and correct structure
[x] TRG 5.04 CPU / MEM resource requests and limits and are properly set
[x] TRG 5.06 Application must be configurable through the Helm chart
[ ] TRG 5.07 Dependencies are present and properly configured in the Chart.yaml
[ ] TRG 5.08 Product has a single deployable helm chart that contains all components
[ ] TRG 5.09 Helm Test running properly
[ ] TRG 5.10 Products need to support 3 versions at a time
[ ] TRG 5.11 Upgradeability

TRG 6 Released Helm Chart

[ ] TRG 6.01 Released Helm Chart

TRG 7 Open Source Governance

[ ] TRG 7.01 Legal Documentation
[ ] TRG 7.02 License and copyright header
[ ] TRG 7.03 IP checks for project content
[ ] TRG 7.04 IP checks for 3rd party content
[ ] TRG 7.05 Legal information for distributions
[ ] TRG 7.06 Legal information for end user content
[ ] TRG 7.07 Legal notice for documentation

Chart doesn't have default resource management config, but the examples in the comments and the explanation looks good to me

Release created: https://github.com/eclipse-tractusx/knowledge-agents-edc/releases/tag/v1.10.15
The Helm test workflow + upgrade step should be worked on (see #129 + comment).
I didn't postpone the release, sine the charts heavily rely on (are a quite close copy) of the tractusx-edc Charts


Ability to revert back to original firmware?

Once your new firmware is flashed, is it possible to revert back to factory firmware via DFU?  I'm guessing yes, but would like to know for sure whether bridges get burned.
Given the amount of aftermarket firmware available for the Behringer FCB1010, it's great to see similar doors opening for the Melo Audio unit.  I'm in the midst of a heavy playing schedule, but would like to dip my two into the waters if safe to do so without bricking the devices.

Short answer:
Yes, and I have done it many times to my own device.  However I have no idea if there's any variations on the hardware out there at this point.  So if you're relying on it for your current playing, I wouldn't at this stage.  More testing is needed.
Longer answer:
There's two memories of interest, the flash that's holding the firmware and the EEPROM that holds the configuration. For the standard melo firmware both need to be correct for it to boot.
The flash is programed with a derivative of the STM32 DFU firmware. Unless something is loaded that intentionally over-writes the bootloader area of flash (which there are locks that need to be overridden to do, so it would have to be intentional),  then you'll always be able to reload the flash.
The EEPROM is a little bit more susceptible to problems.  My investigations have shown the current melo firmwares only use the first 128 bytes of the EEPROM, so I'm using the free space above that.  I've also include the capability to backup your EEPROM and restore the original.  So in theory (and tested on my own device), you can swap between the firmware without losing settings of either...
But there's still some risk there as it hasn't been tested widely yet.

I have a lull in the action after July and will definitely make time to play with this at that point.  In particular, I find the ability to send only 0 or 127 to a CC# to be highly limiting.

Great, will be excellent to get some feedback.  Hopefully by then much more testing will have been carried out.

Hi,  I am not sure how to backup and restore the firmware thru dfu-util could you give the exactly cmd?
In man dfu-util there are some examples, but not sure how it applies to this project:
   Using dfu-util with a DfuSe device
       Flashing a .dfu (special DfuSe format) file to the device:
         $ dfu-util -a 0 -D /path/to/dfuse-image.dfu

       Reading out 1 KB of flash starting at address 0x8000000:
         $ dfu-util -a 0 -s 0x08000000:1024 -U newfile.bin

       Flashing a binary file to address 0x8004000 of device memory and ask the device to leave DFU mode:
         $ dfu-util -a 0 -s 0x08004000:leave -D /path/to/image.bin

The EEPROM is a little bit more susceptible to problems. My investigations have shown the current melo firmwares only use the first 128 bytes of the EEPROM, so I'm using the free space above that. I've also include the capability to backup your EEPROM and restore the original.

Can you please clarify if this project is using the EEPROM ?  You told me in another issue that it is not.
And also, what would be the steps to back it up  using dfu-util ?

An early version of this project (you'll note that comment was from almost a year ago), used the EEPROM to store the settings in the way described.  This was dumped in favor of the flash in order to store the much larger number of commands as I described in that other thread.
There is no code in either this firmware, or the DFU bootloader that can interact with the EEPROM in any way.  I do see there is an out of date comment in the features list stating that it has SYSEX messages to backup and restore the EEPROM. These were all removed when the code was removed that interacted with the EEPROM.

Hi, I am not sure how to backup and restore the firmware thru dfu-util could you give the exactly cmd?
Download the firmware:
dfu-util -a 0 -D generated-20220424-163714.dfu

I've not used it to create a backup, but I see no reason why you couldn't.  You can download all the MeloAudio firmwares from their website, so I never needed to.