How to remove attached files when there are more than one?

<%= form_for @post do |form| %>
<%= form.label :images_files %>
<%= form.attachment_field :images_files, multiple: true %>
<% end %>
How do i remove images for this case?  I'm using  append :true .
class Image < ActiveRecord::Base
belongs_to :post
attachment :file
end
class Post < ActiveRecord::Base
has_many :images, dependent: :destroy
accepts_attachments_for :images, attachment: :file, append: true
end
Controller:
def post_params
params.require(:post).permit(images_files: [])
end

This is out of the scope of the Refile gem. There are plenty of ways to remove records, the easies being a link to a controller action which call destroy on it, but what you go with depends on what you need.

@jnicklas could it be possible to handle multiple deletion on refile?
Perhaps something like this:

define an attr_acessor for attachers (Post in this case)
add after_update callback to delete selected attachments (Images)

User still have to handle how to the attachment list and gather which ones to delete.
If you think its doable I can send a PR with an initial draft.

@whereismushfiq I guess you want to remove images by editing the parent Post?
I thought accepts_attachments_for was a wrapper around accepts_nested_attributes_for and it would accept the parameter allow_destroy: true. But it doesn't seem to be the case.
I solved it by adding accepts_nested_attributes_for
accepts_attachments_for :images
accepts_nested_attributes_for :images, allow_destroy: true

= simple_form_for @post do |f|
  = f.simple_fields_for :images do |c|
    = c.input :_destroy, as: :boolean
  = f.button :submit

params.require(:post).permit(
  :name,
  :_destroy,
  images_files: [],
  images_attributes: [:id, :_destroy]
)

I have been trying to do this with rails forms in an edit action and managed to get it to sort of work with a nested route but unfortunately it destroys all images. Any help would be appreciated.
      <%= image_tag attachment_url(image, :file, :fill, 450, 200, format: "jpg") %>
      <%= link_to "Image", attachment_url(image, :file) %>
      <%= link_to "Remove", event_image_path(@event, image.id), :method  => :delete, :confirm => "Are you sure?" %>
    <% end %>

Thanks guys. I actually did the same thing as max. Used nested route and
added a remove button.
Sincerely,
MUSHFIQ
On Fri, Oct 30, 2015 at 8:18 PM, Max Plisskin<EMAIL_ADDRESS>wrote:

I have been trying to do this with rails forms in an edit action and
managed to get it to sort of work with a nested route but unfortunately it
destroys all images. Any help would be appreciated.
<%= image_tag attachment_url(image, :file, :fill, 450, 200, format: "jpg")
%>
<%= link_to "Image", attachment_url(image, :file) %>
<%= link_to "Remove", event_image_path(@event <https://github.com/event>,
image.id), :method => :delete, :confirm => "Are you sure?" %>
<% end %>

—
Reply to this email directly or view it on GitHub
<https://github.com/refile/refile/issues/344#issuecomment-152677660>.

@whereismushfiq
Cool. Were you able to get it to only delete the files individually or did it delete all of them?

I did that a month ago. As far as I remember i could delete one by one.
Could you do the same? I can check my code if you need that.
On Saturday, October 31, 2015, Max Plisskin<EMAIL_ADDRESS>wrote:

@whereismushfiq https://github.com/whereismushfiq
Cool. Were you able to get it to only delete the files individually or did
it delete all of them?
—
Reply to this email directly or view it on GitHub
https://github.com/refile/refile/issues/344#issuecomment-152693769.

--
Sincerely,
MUSHFIQ


[firebase_auth] and [firebase_messaging] IOS 17.2.1 onBackgroundMessage crush app

Bug report
Describe the bug
When receiving push notification when app killed in ios 17.2.1 the app is crushing when sending push with data and content_available true
Steps to reproduce

Send push notification by rest api sample json :

 {
  "to": "token",
  "notification": {
      "body": "test 1",
      "title": "FCM Message"
  },
  "content_available": true,
  "priority": "high",
  "data": {
      "link": "fifo_link",
      "key2": "value2"
  }
}

push notification displayed immediatly after it the app crush

Error :
0   CoreFoundation                	0x1a860a69c __exceptionPreprocess + 164 (NSException.m:249)
1   libobjc.A.dylib               	0x1a08bfc80 objc_exception_throw + 60 (objc-exception.mm:356)
2   CoreFoundation                	0x1a868f490 +[NSException raise:format:] + 112 (NSException.m:0)
3   FirebaseAuth                  	0x103558e94 +[FIRAuth auth] + 76 (FIRAuth.m:445)
4   Runner                        	0x102980f34 -[FLTFirebaseMessagingPlugin application:didReceiveRemoteNotification:fetchCompletionHandler:] + 96 (FLTFirebaseMessagingPlugin.m:446)
5   Flutter                       	0x10412c8f4 0x104104000 + 166132
6   UIKitCore                     	0x1ab56f880 -[UIApplication pushRegistry:didReceiveIncomingPushWithPayload:forType:withCompletionHandler:] + 292 (UIApplication.m:14658)
7   PushKit                       	0x215d724a0 __74-[PKPushRegistry remoteUserNotificationPayloadReceived:completionHandler:]_block_invoke + 128 (PKPushRegistry.m:287)
8   libdispatch.dylib             	0x1b05136a8 _dispatch_call_block_and_release + 32 (init.c:1530)
9   libdispatch.dylib             	0x1b0515300 _dispatch_client_callout + 20 (object.m:561)
10  libdispatch.dylib             	0x1b0523998 _dispatch_main_queue_drain + 984 (queue.c:7813)
11  libdispatch.dylib             	0x1b05235b0 _dispatch_main_queue_callback_4CF + 44 (queue.c:7973)
12  CoreFoundation                	0x1a855501c __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 16 (CFRunLoop.c:1780)
13  CoreFoundation                	0x1a8551d28 __CFRunLoopRun + 1996 (CFRunLoop.c:3149)
14  CoreFoundation                	0x1a8551478 CFRunLoopRunSpecific + 608 (CFRunLoop.c:3420)
15  GraphicsServices              	0x1ebad24f8 GSEventRunModal + 164 (GSEvent.c:2196)
16  UIKitCore                     	0x1aa97562c -[UIApplication _run] + 888 (UIApplication.m:3685)
17  UIKitCore                     	0x1aa974c68 UIApplicationMain + 340 (UIApplication.m:5270)
18  Runner                        	0x102524be4 main + 64 (AppDelegate.swift:13)
19  dyld

After a long research i discover that when receiving push notification the code like this in file FLTFirebaseAuthPlugin.m :
#if TARGET_OS_IPHONE
#if !__has_include(<FirebaseMessaging/FirebaseMessaging.h>)
- (BOOL)application:(UIApplication *)application
    didReceiveRemoteNotification:(NSDictionary *)notification
          fetchCompletionHandler:(void (^)(UIBackgroundFetchResult result))completionHandler {
  if ([[FIRAuth auth] canHandleNotification:notification]) {
    completionHandler(UIBackgroundFetchResultNoData);
    return YES;
  }
  return NO;
}
#endif

This lines crushing the app , reason cus firebase not configure cus it only configure at main.dart.
When the app killed and receiving push this code is calling.
for "hack" solution i delete this lines and copy the firebase messaging library.
  if ([[FIRAuth auth] canHandleNotification:notification]) {
    completionHandler(UIBackgroundFetchResultNoData);

Expected behavior
App should not crushed
Add any other context about the problem here.

Flutter doctor
[✓] Flutter (Channel stable, 3.16.4, on macOS 14.2 23C64 darwin-arm64, locale
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.3)
[✓] IntelliJ IDEA Community Edition (version 2021.3.2)
[✓] VS Code (version 1.85.1)
[✓] Connected device (3 available)
flutter dependencies :
  firebase_app_check: ^0.2.1+4
  firebase_auth: ^4.14.0
  firebase_core: ^2.22.0
  firebase_dynamic_links: ^5.4.4
  firebase_messaging: ^14.7.4
  firebase_storage: ^11.5.1

Send push notification by rest api sample json :

@saharvx9  Please use nodejs admin SDK script to send notifications that is used in the plugin example and check if using it, you get same behavior or not.

Send push notification by rest api sample json :

@saharvx9 Please use nodejs admin SDK script to send notifications that is used in the plugin example and check if using it, you get same behavior or not.

We are using the sdk of firebase admin and same result,the json was for testing and its the same
i will show u the code of node js :
import * as admin from "firebase-admin";
const messaging = admin.messaging();

const options = {
  contentAvailable: true,
  priority: "high",
};

const sendToDevices = async (
  title: string,
  body: string,
  devices: string[],
  data = {}
) => {
  const notification = { body, ...(title && { title }), "sound": "default" };
  return await messaging.sendToDevice(devices, { notification, data }, options);
};

Hi @saharvx9, are you only seeing this issue with iOS 17.2.1? Are other versions of iOS affected?

Hi @saharvx9, are you only seeing this issue with iOS 17.2.1? Are other versions of iOS affected?

Mostly in 17.2.1,
I checked in 17.1.0 too and it happened

@saharvx9
I see that in your payload, you are sending content_available, but in plugin example, the flag is used as below:
https://github.com/firebase/flutterfire/blob/82af6c2f40160a9e2f74e2d48652003fa48bb161/packages/firebase_messaging/firebase_messaging/example/scripts/send-message.js#L32C7-L32C30
ie, contentAvailable instead of content_available.
Also, please try only using minimal flutterfire dependencies like firebase_core and firebase_messaging latest versions in order to confirm if the crash occurs using bare minimum code and setup.

contentAvailable

@darshankawar it change it to contentAvailable and still it crushed.
I did change to last version of firebase messaging and core and still same issue, this code is still in the last version of firebase_messaging why its necessary to check it? . a lot of projects using just in push notification, and my occur like happened to me crushes.

Thanks for the update @saharvx9
We tried using the plugin example and running on iOS 17.2.1 version but it didn't crash. See video:
https://github.com/firebase/flutterfire/assets/67046386/83e9ceb3-71f2-4afc-8266-8b31b2eddbba
Also, revisiting the issue,

When receiving push notification when app killed in ios 17.2.1

Per documentation, if the app is killed, we need to manually reopen it. Can you try the same and check if following it, the crash still occurs or not ?


Chore remove ck hash set and reduce ck hash map usage

What problem does this PR solve?
remove ck hash set and reduce ck hash map usage
None
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[ ] No.
[ ] Yes.

Does this need documentation?

[ ] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run buildall


Request money - Text input isn't auto focused after screen transition ends

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/27294
Action Performed:

Go to https://staging.new.expensify.com/
Press FAB >> Request money >> Distance
Choose Start & End locations >> Next

Expected Result:
Verify that the text input is auto focused after screen transition ends
Actual Result:
Text input isn't auto focused after screen transition ends
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.70-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/5f5d42d8-cf57-4eb8-99ce-d75c0882f788

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
Text input isn't auto focused after screen transition ends when creating / editing a waypoint in the distance request waypoint editor
What is the root cause of that problem?
The screen transition end doesn't always fire except at the top level of the stack.
What changes do you think we should make in order to solve the problem?
We are now using a new approach to autofocus text inputs according to https://expensify.slack.com/archives/C01GTK53T8Q/p1694660990479979
Implement these changes in AddressSearch.
What alternative solutions did you explore? (Optional)
None.

This works well in my end.
What's wrong with you?
Thanks.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Text input isn't auto focused after screen transition ends
What is the root cause of that problem?
We are using onEntryTransitionEnd on ScreenWrapper component.
https://github.com/Expensify/App/blob/95c9e4743f44ca42ece2c6ac56259b911d5feafc/src/pages/iou/WaypointEditor.js#L163
onEntryTransitionEnd is only fired for the top card in the stack, and therefore does not fire on the new top card when popping a card off the stack.
What changes do you think we should make in order to solve the problem?
We need to add useFocusEffect hook and remove onEntryTransitionEnd from ScreenWrapper in WaypointEditor component.
const focusTimeoutRef = useRef(null);
useFocusEffect(useCallback(() => {
    focusTimeoutRef.current = setTimeout(textInputRef.current.focus, CONST.ANIMATED_TRANSITION);
    return () => {
        if (!focusTimeoutRef.current) {
            return;
        }
        clearTimeout(focusTimeoutRef.current);
    };
}, []));

What alternative solutions did you explore? (Optional)
NA

Based on the provided code, it seems that the problem is related to the use
of the useFocusEffect hook and the onEntryTransitionEnd function in the
ScreenWrapper component of the WaypointEditor component. To solve this
problem, the following changes should be made:
Remove the onEntryTransitionEnd function from the ScreenWrapper component.
This function is no longer needed if we're using the useFocusEffect hook.
Import the useFocusEffect hook from the appropriate library or module.
Add the useFocusEffect hook inside the WaypointEditor component and wrap it
around the code that involves focusing on the textInputRef.current element.
Thanks.
Kevin

Message ID: @.***>

But I don't want get pay via a upwork.
So sorry.
Kevin
On Thu, Sep 14, 2023 at 12:53 PM Dev 3606 @.***> wrote:

Based on the provided code, it seems that the problem is related to the
use of the useFocusEffect hook and the onEntryTransitionEnd function in the
ScreenWrapper component of the WaypointEditor component. To solve this
problem, the following changes should be made:
Remove the onEntryTransitionEnd function from the ScreenWrapper component.
This function is no longer needed if we're using the useFocusEffect hook.
Import the useFocusEffect hook from the appropriate library or module.
Add the useFocusEffect hook inside the WaypointEditor component and wrap
it around the code that involves focusing on the textInputRef.current
element.
Thanks.
Kevin

Message ID: @.***>

This is a duplicate of https://github.com/Expensify/App/issues/27202.

Thanks a lot.
On Thu, Sep 14, 2023 at 1:22 PM Sasha Kluger @.***>
wrote:

Closed #27450 https://github.com/Expensify/App/issues/27450 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/issues/27450#event-10375058709, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A2P3B7EELJGVYZ5XRWGTCKDX2M4O5ANCNFSM6AAAAAA4YIDVWU
.
You are receiving this because you were mentioned.Message ID:
@.***>

This is a duplicate of #27202.

@sakluger This deals with the screens for picking the waypoints, while #27202 deals with the screen for picking the target workspace, so I'd say they're different.


Traefik Implementation Link is Broken

In the implementations docs, our Traefik link currently targets https://doc.traefik.io/traefik/routing/providers/kubernetes-gateway/. It looks like that link no longer works. Maybe https://doc.traefik.io/traefik/master/routing/providers/kubernetes-gateway/ and/or https://traefik.io/blog/getting-started-with-traefik-and-the-new-kubernetes-gateway-api/ would be better to link to. Not sure if this is a problem with our docs or something that accidentally changed on Traefik side.
/kind documentation
cc @santode

I'll take a look tomorrow and if needed do a PR to fix

We had an issue on Thursday with our docs, which was related. The issue since then is fixed and we don't need to make changes :)

/close


Give subtitles a black outline for better visibility on white backgrounds

I know there's a shadow but the top of the letters still blend in with white backgrounds too much. There needs to be just enough black outline to not have them blend in with white or very light backgrounds and the default subtitle configuration would be perfect.  Perhaps remove the shadow and just add the outline?
I don't know if subtitles will be configurable in the future but with a slight outline, that will be enough for most people to read in all situations without wanting to change it.

There was just an outline before but I switched to shadow to match MX Player style. Now I doubt that too as it's harder sometimes to read the subtitles. I may indeed switch back to outline.
However you should be able to customize subtitles already: https://github.com/moneytoo/Player#how-do-i-change-subtitle-font-size-or-color

Yes, please go back to outline. I don't know what MX Player is doing but they have it all wrong. What matters is that people can actually read the subtitles no matter what is playing. Also, the caption section on my device is quite limited. I would have to enable a black background to make them more visible and I would just prefer an outline instead. I don't think you're going to add a subtitle configuration page so an outline would be the next best thing for all users.


Does not work when attributes (props) are on multiple lines

When my JSX component has many props, it sometimes better to use multi-line, and tagalong stop working there.
It works well if everything stay on one line.
https://user-images.githubusercontent.com/1083478/168279128-413ed240-f8ce-4ba1-af1a-d213de068f14.mov

What mapping are you using to append to the <Component line? It seems I hadn't added A to the list of mappings to attach to, so that might have been what causes the problem, but I can't tell from the recording whether you type a or A. Could you try it now and see if you still have this issue?

You're correct, I use A to append and it's fixed. Thank you very much! <3

A thing I still noticed as a potential issue is if the cursor is outside the tag, A still doesn't work, because it tries to "see" the tag at the cursor position before the jump. But I think there's nothing I can do about it, since it depends on when Vim throws these events. I'll do some thinking, but I feel it's also a bit of an edge case and maybe I'll just write it in the docs as a "known issue".

I think using A outside of the tag, then slowly navigate back to the tag is NOT the popular choice if one wants to change the tag. So I agree that leaving it as edge case is OK, IMHO.


Looks like you have a jQuery dependency?

Just included, but I'm getting an error.  Looking through the code, looks like a pretty firm JQuery dependency, is that correct?  If so, might be useful to note that on the front page, for those using angular-bootstrap they may be JQLite only.
I wonder whether you could achieve everything you're doing with JQLite, which would suit me very well.  I totally understand if that's not something that's important to you though.

You're right--sorry about that. I forgot that angular-bootstrap folks might only have jQLite.
I added a note on the front page about it. I looked into using just jQLite but there are just too many non-trivial pieces missing that I need, unfortunately: .on(), .width(), .outerWidth(), .offset(), .animate(), etc.
Sorry about that. Thanks for trying it out, though, and thanks for the suggestion.


Use a_start and b_start variables in HashDiff.lcs

These vars were already created at line 13 but they weren't used before.
This also fixes warnings when running script which uses hashdiff with ruby warnings turned on.

Thanks for the catch @keram, it will improve the performance a lot :+1:


jsonify idea

Here is a new way to generate JSON-LD markup using hugo's jsonify function.
Create a object structure by adding data to a scratch map and then use jsonify to display it as valid json... no json errors!
See what you think!
I kind of simplified your breadcrumb code.. but it also has some complexities.

Thanks! I'll have a closer look later (bit busy now)

I don't think its possible to merge what I have done, and your existing json. If you wanted to keep it all together I can have a go at transforming your existing code - if jsonify is how you want to move forward.
Do you know what the error is? The actual json that I created seems to pass.
On my websites I personally use multiple html tags for different json-ld purposes, so I can turn them on/off depending on the page type, and append page specific json-ld e.g. product information directly from the page layout.

It's fine for me to split up the json (can be handy indeed) + using jsonify is smart /OK with me.
BTW, I based the current setup on how Yoast does it — see also Schema - Overview
Current output using validator.schema.org:

Your output gives this error:

Sean, super thanks — amazing work! Now using future-wd/hugo-seo (and hugo-responsive-images): @hyas/seo (and @hyas/images)


D455 shows reddish color in RGB image when there is sunlight

The new D455 shows red color in the image when there is sunlight. See the attached picture. This was taken around 3pm with the camera facing West. Is there a setting that needs to be changed, or, is it a hardware issue?
(This does not happen with D435 and D435i)

Hi @MartyG-RealSense Is the SDK 2.36.0 needed only for realsense-viewer? Can D455 streams be recorded using 2.34 SDK?

When support is introduced for a camera in the SDK, it applies to the SDK in general and not just the Viewer program on its own.  Having said that, the D455 is able to be recognised and correctly named as a D455 in the Viewer in some earlier versions than 2.36.0 (including yours).  I just tested it myself in SDK 2.35.2.
The continuously generating errors in 2.34.0 are still a good reason to upgrade though - if you look in the bottom log window of the image that you provided, you can see that you were experiencing this error yourself.
I ran some tests in the Viewer with my D455 and found that I could recreate your image if the Hue setting in the RGB controls was increased to 100 or more.  So I suggest checking in the Viewer what your Hue is set to when you get that pinky-purple tint.  I found that if the Hue is changed then that value persists even if you close the Viewer and re-launch it, until you change the value again..

Hi, @MartyG-RealSense We did some more testing with SDK 2.36 and D455 and D435i. It looks like changing Hue changes color, but at Hue=0, D455 still shows colorization. It is better indoor, but once you face it outdoor, colorization happens. See the following pictures. Last one is D435i. It looks to me something wrong with the unit I have. What do you think?
D455 indoor Hue=0

D455 Outdoor Hue=0

D455 Outdoor Hue=60

D435i Outdoor Hue=0

A key difference between the RGB imager of the D435i and the D455 is that the D455 RGB imager has a fast global shutter for the first time whilst the D435i and all other 400 Series models have a slower rolling shutter on its RGB imager.  So you could try increasing the RGB exposure value.  In photography, that slows the capture timing down.  That would test whether the faster shutter is causing a weird exposure related effect.

I had a discussion with my manager about this case.  RealSense support are aware of the issue and are investigating it.

I would ask for some more data from your side, if possible.
It looks your specific example MAY be due to a bad IR-cut filter.
Do you see any of these adverse effects indoors away from IR light?

@agrunnet please let me know what data you need from our side. We haven't noticed this issue indoors. It happens only if we point the camera outside where this sunlight as in the above pictures. The picture with the trash can above looks ok, but not the ones facing outside.

@vijujames We we’re able to reproduce your scene And see the same effect. No more info needed from you as we look into this. Thanks for bringing it to our attention.

I have also experience this issue outdoors in direct sunlight. It seems to happen above a certain amount of light or camera exposure level, and always comes out from the lower right corner of the camera sensor. Maybe the sensor is becoming over saturated?
@vijujames a temporary workaround might be to place a neutral density filter in front of the color sensor. This will reduce the amount of light hitting the sensor without significantly affecting color. The filters do come in square sheets that can be cut to size.

@sam598 and @vijujames Yes, this has now been confirmed as a sensor saturation issue that happens for very bright scenes with low exposure times and is due to a sensor shutter efficiency limitations. We are actively looking at ways to mitigate this, but it cannot be eliminated entirely in just Firmware and camera settings. The best way to reduce this is to use ND filter (aka. sun glasses). A polarizer has also been seen to help a lot, especially for strong light reflecting off of surfaces.

@agrunnet This happens even on a cloudy day, how do you suggest an ND filter is fitted?

Yes.

@sbargon it is possible to purchase ND filters as square sheets, which you can then cut to size. For example:
https://www.bhphotovideo.com/c/product/38380-REG/Norman_810551_810551_Neutral_Density_Pack.html
In terms of mounting them to the camera, the easiest solution is tape but that is far from ideal. If you have access to a 3D printer someone could design a filter holder that wrapped around from the back of the camera to the front. This would be a less destructive path.
@agrunnet if the sensor is very sensitive is there any concern about sunlight permanently damaging the pixels? Obviously any extremely bright or magnified light source can cause damage, but in "every day outdoor use" is there any concern? Also since they use the same sensor, what about the IR cameras?

@sam598 thanks for the great link.
And to answer your question, no there is no permanent damage at all.

The new D455 shows red color in the image when there is sunlight. See the attached picture. This was taken around 3pm with the camera facing West. Is there a setting that needs to be changed, or, is it a hardware issue?
(This does not happen with D435 and D435i)

Hi ！I test the code below with a 75FPS, could you show your result? Thanks very much!
Test Program
// include the librealsense C++ header file
#include <librealsense2/rs.hpp>

#include <opencv2/opencv.hpp>

#include <chrono>

using namespace std;
using namespace cv;

int main()
try
{
    //Contruct a pipeline which abstracts the device
    rs2::pipeline pipe;

    //Create a configuration for configuring the pipeline with a non default profile
    rs2::config cfg;
    //Add desired streams to configuration
    cfg.enable_stream(RS2_STREAM_COLOR, 480, 270, RS2_FORMAT_BGR8, 90);

    //Instruct pipeline to start streaming with the requested configuration
    pipe.start(cfg);

    //Sensor Settings
    auto sensor1 = pipe.get_active_profile().get_device().query_sensors()[1];
    sensor1.set_option(RS2_OPTION_ENABLE_AUTO_EXPOSURE, 1);
    auto sensor2 = pipe.get_active_profile().get_device().query_sensors()[1];
    sensor2.set_option(RS2_OPTION_AUTO_EXPOSURE_PRIORITY, 0);

    // Display in a GUI
    const auto window_name = "Display Video";
    namedWindow(window_name, WINDOW_AUTOSIZE);

    //用于计时
    //show time
    auto start = chrono::system_clock::now();
    int frame = 0;

    while (waitKey(1) < 0 && getWindowProperty(window_name, WND_PROP_AUTOSIZE) >= 0)
    {
        rs2::frameset data = pipe.wait_for_frames(); // Wait for next set of frames from the camera

        //获取彩色图像帧
        rs2::frame color = data.get_color_frame();

        //保存彩色图像
        Mat image(Size(480, 270), CV_8UC3, (void *)color.get_data(), Mat::AUTO_STEP);

        // Update the window with new data
        imshow(window_name, image);

        frame++;
        //one loop end
        auto end = chrono::system_clock::now();
        auto duration = chrono::duration_cast<chrono::microseconds>(end - start);
        double timecost = double(duration.count()) * chrono::microseconds::period::num / chrono::microseconds::period::den;

        cout << frame / timecost << " FPS" << endl;
    }

    return 0;
}
catch (Exception ex)
{
    cout << "Error!!!" << endl;
    cerr << ex.msg << endl;
}

Hi @FrankCreen    Please post your question as a new issue using the New Issue button at the link below and do not post it on multiple D455 cases if the question is unrelated to that case.   Thank you.
https://github.com/IntelRealSense/librealsense/issues/

Hi, is there any updates on this issue? @MartyG-RealSense

Hi, is there any updates on this issue? @MartyG-RealSense

+1 @dingyu20's comment above.
As I wrote here, I also have the same issue, and I have been waiting for a more supportive follow-up from Intel RealSense (@MartyG-RealSense) while using it without color, but nothing heard since then.
Based on my experience (also @sbargon's post above), it's not an issue only under bright sunlight, but is rather constantly happening under general outdoor scenarios making it unusable outdoor at all.
Except this issue, I like D455 which is well integrated and built for robotic applications, so I really hope that Intel RealSense team now comes back with more reasonable supports soon rather than referring to the CTO's post and a potential solution with a ND filter. E.g.:

any upcoming firmware/hardware update
provide a ND filter and a bracket (at least describing where to buy it and how to attach to D455 if that's something acceptable by customers)

+1 @dingyu20's comment above.
As I wrote here, I also have the same issue, and I have been waiting for a more supportive follow-up from Intel RealSense (@MartyG-RealSense) while using it without color, but nothing heard since then.
Based on my experience (also @sbargon's post above), it's not an issue only under bright sunlight, but is rather constantly happening under general outdoor scenarios making it unusable outdoor at all.
Except this issue, I like D455 which is well integrated and built for robotic applications, so I really hope that Intel RealSense team now comes back with more reasonable supports soon rather than referring to the CTO's post and a potential solution with a ND filter. E.g.:

any upcoming firmware/hardware update
provide a ND filter and a bracket (at least describing where to buy it and how to attach to D455 if that's something acceptable by customers)

@dingyu20  @hanmekim   I will refer your comments to Intel.   Thanks very much for your ongoing patience,

@dingyu20  @hanmekim   I will refer your comments to Intel.   Thanks very much for your ongoing patience,

There is a document detailed about this issue, which is located on the FW page:  https://dev.intelrealsense.com/docs/firmware-releases
Documentation
Specification Clarification - October Release (link to PDF attached)
Refer to the Intel RealSense product documentation (PDF) included in the archive for the latest device and documentation errata, specification clarifications and changes.

Hi!
I have the same problem and let me elaborate on this issue.
I'm founder of a multispectral camera company and we had this exact issue with some filter producers back in 2017. Their filters advertised as "stabldge" (you can search the name of the company) but in reality their products weren't. I'm 100% sure Intel using the same filters to block out the NIR because it has the same problem. The NIR light bleeds through horizontal-vertical edge of the filter and causes this problem.
http://midopt.com/wp-content/uploads/2016/04/MidOpt_StablEDGE-Theory-Curves_2_web.jpg
This is a production issue and intel must recall and replace all of the affected units like we had to.
Intel; You can't solve this issue with firmware update.
I'm returning my D455 and I'll advise my customers NOT to buy them.
Regards

FYI, I tried a ND filter as shown below. Beside extra $50.45 (a ND filter inc. shipping) and its ugly looking, I found that can't be a solution at least in my case (a moving platform). Basically, it increases the exposure time eliminating the color issue, but consequently it becomes easier to get motion blur. I bought a D435i instead to give it a try, but not sure yet because of its rolling shutter (RGB). Definitely, I wouldn't recommend D455 for outdoors.

Why is this closed?
Returning the mine, it id not only the tint, the light adaption is absolutely slow. Unusable.
https://www.facebook.com/groups/RealSenseExperts/permalink/2292731394193698/
I added a video in the Realsense group.

We happen to have the same issue with out D455s, in desert environment, (the drawing are done over the human, it doesn't change the color or anything in the image)

Hi @WingRS  For information about this D455 phenomenon, please download Intel's Specification Clarification PDF document using the link below and read the D455 RGB Camera In Bright Sunlight on the final page of the document.
https://www.intelrealsense.com/download/13629/

Has anyone tried to remove the lens in from of the RGB camera to see what happens? D415 and D435 don't have this issue and they have no lenses in front of the cameras.
Please let me know your thoughts.

Hi @nievesbrunet   The lenses of RealSense camera sensors are not designed to be removed and doing so risks breaking the sensor.  The OmniVision OV9782 'global shutter' RGB sensor on the D455 is also a different component to the OmniVision OV2740 'rolling shutter' one on the D415, D435 and D435i models.

Because they are faulty and should be refunded and recalled. Their filter
documents is just a absurd tale.
On Tue, 8 Mar 2022, 20:21 Maria Nieves Brunet, @.***>
wrote:

Thank you @MartyG-RealSense https://github.com/MartyG-RealSense. Any
other advice? I'm using an ND4 filter, and can still see some pinkish color
on the right side of the image. Thank you.
—
Reply to this email directly, view it on GitHub
https://github.com/IntelRealSense/librealsense/issues/7155#issuecomment-1062173423,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AITQOVAB3XOKWYP7BHZWXBDU66ZERANCNFSM4QHYEMJQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

@nievesbrunet   If you are already using an ND filter and the camera is in a scene with bright sunlight then Intel provide additional advice about use in sunlight at the link below.
https://dev.intelrealsense.com/docs/tuning-depth-cameras-for-best-performance#section-use-sunlight-but-avoid-glare

Hi @jcremona  For this particular RGB color hue issue, Intel advises that only the RGB sensor should have the filter attached to it.
It is fine to add ND filters over the IR sensors too though if you wish to do so, though ensure that both the left and right sensors have a filter fitted.

After adding an ND8 filter, I still get a reddish colour on the left side (the filter helps but not enough). Also, the white lines have a strange effect, where they look like they are shifted or duplicated. Does anyone have a suggestion or possible explanation as to why this is happening?

@jcremona I don't have an explanation, but I have seen a similar issue. Even after using the ND filter, the magenta shade persists. We had to switch to a different camera for our project.

In addition to adding an ND filter, Intel's official guidance about this D455 characteristic recommends that increasing the FPS speed may help to reduce the saturation effect further.

Hello @MartyG-RealSense , thanks for the new information about the FPS. I tried and it works well but we checked the increasing of the frame lost in the Realsense Viewer. As we can solve the problem only increasing the FPS, it looks like that is a problem that can be solve by software. Is it Intel working in a firmware to help us to have the same result as the observed when increasing the fps but with less frame rate? Tks!

Hi @matheusSynkar   As mentioned by other RealSense users above and in Intel's official guidance on page 8 (the final page) of the PDF document at the download link below, adding a Neutral Density (ND) filter over the camera lenses on the outside of the camera can help to reduce the impact of this issue.
https://www.intelrealsense.com/download/13629/?_ga=2.41245793.2144105902.1660733096-1041004708.1589641371
The phenomenon is not a bug but rather a characteristic of the D455 hardware and there are no plans to address it in firmware.  As it is a hardware related effect, it was addressed in later D455 cameras that are now manufactured.

Hi @MartyG-RealSense , Thank you for the fast response. I understood your point but in our tests with the d455 we cold remove completely the issue increasing to 90fps without uses of ND filter. In our point of view, it was solved by software and can be replicated in a firmware update.
I am attaching some imagens of the tests made without ND filters.

The improvement in the recently produced D455 units is due to a hardware change, so altering the firmware driver would not correct the issue on older D455 models when using lower FPS speeds such as 30.  I do understand that this is disappointing.

Sorry for my persistence. I can't see why it wouldn't be possible to capture the same 90FPS and delivering 30FPS or 15FPS on the USB port. The camera system could discard the frames or looking at a more elegant solution, it would be possible to use the same shutter speed used at 90FPS for lower FPS.

I will raise your question with my Intel RealSense colleagues.  Thanks very much for your patience!

Hi @matheusSynkar  My colleagues suggest using manual exposure instead of auto-exposure and setting a shorter exposure time.   An example of a shorter time for RGB exposure would be '78' instead of '156'.
In cases where the RBG FPS needs to be increased to deal with a shutter related problem, setting FPS to a minimum value of '6' (or 5 in the case of the D455 model) and a manual exposure of '78' can be an alternative to using a high FPS on auto-exposure.

Hello @MartyG-RealSense , Thank you for the helping to correct this issue.
I tried the configuration as your colleague suggested. Please check the images below. As you can see, we have the same results in manual and automatic exposure. I think the minimum exposure time is not enough to correct the problem but with higher FPS the problem disappears.
15FPS

30FPS

60FPS

90FPS (It was necessary to reduce the image due to the data transfer capability of the device)

I think the best is return the camera as the first ones are faulty, the
proof the revised ones have not such issue.
Just return or complaint by a faulty product, there is enough info to proof
that in this github
I returned 2 because that, intel should be recalled.
On Tue, 25 Oct 2022, 14:28 matheusSynkar, @.***> wrote:

Hello @MartyG-RealSense https://github.com/MartyG-RealSense , Thank you
for the helping to correct this issue.
I tried the configuration as your colleague suggested. Please check the
images below. As you can see, we have the same results in manual and
automatic exposure. I think the minimum exposure time is not enough to
correct the problem but with higher FPS the problem disappears.
15FPS
[image: 15fps]
https://user-images.githubusercontent.com/107000971/197785704-d1cd6aa9-cb6c-4e08-9f5c-2237d1382183.png
30FPS
[image: 30fps]
https://user-images.githubusercontent.com/107000971/197785713-ab14fae5-9549-47a9-8710-f949b366a85a.png
60FPS
[image: 60fps]
https://user-images.githubusercontent.com/107000971/197785721-a854cbb3-1ddf-4b7d-bedc-63c9d26e34ac.png
90FPS (It was necessary to reduce the image due to the data transfer
capability of the device)
[image: 90fps]
https://user-images.githubusercontent.com/107000971/197785735-585fee96-586b-4ade-8dfe-5d3da62f16b9.png
—
Reply to this email directly, view it on GitHub
https://github.com/IntelRealSense/librealsense/issues/7155#issuecomment-1290553584,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AITQOVGHKZPIOHHTXH5BJOLWE7OBVANCNFSM4QHYEMJQ
.
You are receiving this because you commented.Message ID:
@.***>

Hi @matheusSynkar  Please send me an email at<EMAIL_ADDRESS>with your contact details included in the message.

@MartyG-RealSense was there an over all solution to this "closed" case, that I missed?

Hi @ArcadeHustle  This issue was not a bug but a characteristic of the camera hardware.  https://github.com/IntelRealSense/librealsense/issues/7155#issuecomment-991084290 has a link to guidance about reducing the effect

So a bug in the BOM none the less ;) that is unfortunate. Will there be a new revision of hardware with a different sensor? It is a bit unfortunate to learn about this post investment into several cameras in the model line.
Can we expect a new model with a different sensor?
Akin to what Luxonis is doing here by using IMX378? https://www.luxonis.com/blog/lens_color_filtering_enhancement

Whilst it is a hardware design characteristic and not a fault, D455 units manufactured after early 2022 have a design tweak that addresses the issue.  So any D455 purchased now should have that revision.

@MartyG-RealSense is there a way to query the hardware to check when it was manufactured?

I don't believe so, but another way to check would be to look at the supported IMU frequencies in the RealSense Viewer's Motion Module section.  2022 D455s had a changed IMU component that supports frequencies of '100' Accel and '200' Gyro.  Pre-2022 models with the original IMU component do not have these speeds and instead support '63' Accel and '200' Gyro.  So if your camera supports 100 Accel, it should be a modern unit.

Thanks! That is useful information.

Hello, have there been any updates on this? I am using an Intel Realsense D455 for an outdoor robot and I am seeing purple in the corner. Seems worse on concrete. Thank you.

@JoeGames21 the update is, stop using Realsense, move to Luxonis. Don't look back.
https://discuss.luxonis.com/blog/1302-ov9782-lens-color-filtering-enhancement

Hi @JoeGames21  This pink / purple RGB color hue issue was not a bug but a characteristic of the D455 camera hardware.  A RealSense team member advises at https://github.com/IntelRealSense/librealsense/issues/7155#issuecomment-691356656 why it occurs.
Whilst it is a hardware design characteristic and not a fault, D455 units manufactured after early 2022 have a design tweak that addresses the issue.  So any D455 purchased now will have that revision.
For further information about this D455 phenomenon, please download Intel's Specification Clarification PDF document using the link below and read the D455 RGB Camera In Bright Sunlight section on the final page of the document.
https://www.intelrealsense.com/download/13629/
The guidance suggests use of an ND filter product as a potential solution, or increasing the RGB's FPS speed (for example, 60 FPS at 848x480 resolution).

@MartyG-RealSense Thanks for responding. Does that mean if I bought a new D455 that the purple issue will be gone? Is there a way to update my current camera, or do I have to get the ND Filter product you recommend? Thank you!

The filter is a physical product so it would have to be purchased and attached to the outside of the camera.  Rubber bands wrapped around the camera casing should be sufficient to hold the filter in place.
I would recommend trying the filter before purchasing a new D455, as I could not guarantee how the camera will perform in your specific environment's lighting conditions.
First though, please try increasing FPS to 60 to see if it resolves the issue without the need to purchase a filter.

@JoeGames21 , we proved with visual evidence that the issue can be solved by software but Intel appears don't want to correct it. The way is move to other supplier as @MAVProxyUser suggested.

Whilst it is a hardware design characteristic and not a fault

I wasn't going to comment anymore, but this phrasing is deeply troubling.
The D455 was and still is marketed as an indoor/outdoor camera. It is not useable outdoors. Full stop.
This is 100% a fault of the camera and not a design choice. It is disingenuous to suggest otherwise, and makes it sound like Intel is trying to rewrite history to avoid having to replace purchased units.

Thank you for all of your replies! Which Luxonis can match the D455 performance? And how reliable is the SDK for robotics? We spent a lot of money on the Intel and it has been integrated with our systems and codebase. It performs very well except this purple issue. We really liked D435 before and were very happy with Intel... What changed between cameras?
For now, we ordered some Starwave filters which seem to work good. No purple, for now... https://starwavelabs.com/products/starwave-labs-nd-filter-for-intel-realsense-d455 - Can we expect any updates from Intel or should we have to buy more filters in the future for all our cams?


Improve help icons in settings

We currently use a couple of different help icons in the settings: ? for links, and i for tooltips (no link). Both are illustrated below:

We should make the following changes to simplify and improve this:

[ ] Convert all i settings icons into ? icons.
[ ] Increase the contrast of the ? icons in both light and dark mode. 0.6-0.7 opacity should be reasonable; we can try both and discuss the screenshots.
[ ] The "Add new code playground" ? icon should not be blue. From a technical perspective, it should be using the shared help_settings_link component.

CZO discussion thread

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

Hi @alya , I have made a PR to solve the first two tasks, have a look at it, it passed all the tests.
Here are the results:

I have started working on the third task, might make a PR soon regarding that issue.

Thanks! The questions marks should all look the same -- we don't want to use question marks with a filled in background.

@alya Hi Alya, @shirleyzhang2 and I are working on this task together as our first issue in Zulip. I generated a PR #20487 here, which I believe can satisfy with your requirements. 😊

Hi @alya I have made a PR "Improved Icons" #20506 to solve this issue. Please review it and let me know about any other modifications in it.

I am still working on this issue and the referenced PR is #20506 .

Yes, I'm still waiting for the review of the PR: #20487.

@zulipbot claim

@zulipbot claim

@AayushSolanki I have an open PR #20506 which resolves this issue.
It would be great if you could work on any other issue please :)

@AayushSolanki I have an open PR #20506 which resolves this issue.
It would be great if you could work on any other issue please :)

alright @Rishabh-792

alright @Rishabh-792

Is this issue still active? I would like to contribute

I believe PR https://github.com/zulip/zulip/pull/20487 should be linked to this issue

Hey @alya , is this issue still open?

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

Just adding a note that we've merged much of the changes proposed here (updated above), and we're not sure if we want to do the rest. I've added notes on some good follow-ups here: https://github.com/zulip/zulip/pull/21353#issuecomment-1074581180

Hello, @timabbott I would like to work on this issue. Please assign it to me.

Hello, @timabbott I would like to work on this issue. Please assign it to me.

You can claim it with @zulipbot claim if no one is already assigned.

@zulipbot claim


Implement log-out

Implement log-out

Hello, @tomkaX
I'd like to work on this issue if it's still open.
Thanks.


Featured Duration One Week

Featured objects should be seen only one week.

requirements

Featured services can be seen if they are selected in one week. Admin dashboard includes all featured services list even if they are old.


question about the index page

hello, thanks for your great work. i'm using it on my blog.
and i have a question about the" welcome " page.
I don't know how to modify it . Can you give me some advice.
I want to delete the welcome page as bellow.
Welcome
This is the Edition template from CloudCannon. Edition is perfect for documenting your product, application or service. It’s populated with example content to give you some ideas.
ChatApp is a fictional chat application for sending messages and media to others. Teams and friend groups would use ChatApp to stay up to date if it existed.

hello  liusanchuan :D
The "welcome" page is an index.md file and should not be deleted. Would you like to test it?
I'm sorry for not giving you an accurate answer.


Tokenomics renaming

Purpose
Renaming for Tokenomics update.
Changes

Baker/baking renamed to validator/validation in UI.
Default name for key file is now validator-credentials.json.
Hide finalization commission rate in validator flows.

Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the
hard-to-understand areas.
[x] (If necessary) I have updated the CHANGELOG.

Transaction elements still show as Configure baker and Configure delegation.

I can make an empty pool update and then I get this error:
Error: Finalization reward commission rate is not within the allowed range.

Transaction elements still show as Configure baker and Configure delegation.

I fixed the baker transactions... But Configure delegation shouldn't be changed AFAIK.

I can make an empty pool update (on testnet with singleton intervals) and then I get this error:
Error: Finalization reward commission rate is not within the allowed range.

Yes, I figured out why it only happened on testnet, I used the incorrect range :upside_down_face:


(WIP) Build support package and collector image from cPaaS drivers

Description
The ultimate target for this PR is to be able to create a support package and a collector image that use the drivers built in cpaas, particularly in this patch: https://code.engineering.redhat.com/gerrit/c/rhacs/+/309821
The way the support package works right now is:

We pull the image holding the drivers from cPaaS, extract them and push them to a GCP bucket acting as a cache.
We pull the drivers back form the GCP bucket cache and compress them using the same script use to create the regular support package.
Finally we push the support package to a separate GCP bucket.

The collector image works in a similar manner:

We pull the drivers back form the GCP bucket cache
We use those drivers in place of the regular ones to build a -cpaas-latest flavor of the collector image.
We run integration tests on RHEL VMs (only platform supported by cPaaS ATM) in offline mode to ensure the drivers used are the ones embedded in the image.

TODO:

Merge the gerrit patch and configure it to run daily.

Checklist

[ ] Investigated and inspected CI test results
[ ] Updated documentation accordingly

Automated testing

[ ] Added unit tests
[ ] Added integration tests
[ ] Added regression tests

If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.

Closed in favor of #816 and openshift/release#31936

Closed in favor of #816 and openshift/release#31936


Crashing when saving checkpoint to file

Every time I train a model it crashes when saving the checkpoint
`Epoch 0, global step 499: val/loss_simple_ema was not in top 1
Summoning checkpoint.
Traceback (most recent call last):
File "H:\Anaconda\envs\dreambooth\lib\site-packages\torch\serialization.py", line 379, in save
_save(obj, opened_zipfile, pickle_module, pickle_protocol)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\torch\serialization.py", line 499, in _save
zip_file.write_record(name, storage.data_ptr(), num_bytes)
MemoryError
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "H:\Anaconda\envs\dreambooth\lib\site-packages\torch\serialization.py", line 380, in save
return
File "H:\Anaconda\envs\dreambooth\lib\site-packages\torch\serialization.py", line 259, in exit
self.file_like.write_end_of_file()
RuntimeError: [enforce fail at ..\caffe2\serialize\inline_container.cc:300] . unexpected pos<PHONE_NUMBER> vs<PHONE_NUMBER>
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "main.py", line 836, in
trainer.fit(model, data)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\trainer\trainer.py", line 740, in fit
self._call_and_handle_interrupt(
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\trainer\trainer.py", line 685, in _call_and_handle_interrupt
return trainer_fn(*args, **kwargs)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\trainer\trainer.py", line 777, in _fit_impl
self._run(model, ckpt_path=ckpt_path)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\trainer\trainer.py", line 1199, in _run
self._dispatch()
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\trainer\trainer.py", line 1279, in _dispatch
self.training_type_plugin.start_training(self)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\plugins\training_type\training_type_plugin.py", line 202, in start_training
self._results = trainer.run_stage()
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\trainer\trainer.py", line 1289, in run_stage
return self._run_train()
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\trainer\trainer.py", line 1319, in _run_train
self.fit_loop.run()
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\loops\base.py", line 145, in run
self.advance(*args, **kwargs)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\loops\fit_loop.py", line 234, in advance
self.epoch_loop.run(data_fetcher)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\loops\base.py", line 145, in run
self.advance(*args, **kwargs)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\loops\epoch\training_epoch_loop.py", line 216, in advance
self.trainer.call_hook("on_train_batch_end", batch_end_outputs, batch, batch_idx, **extra_kwargs)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\trainer\trainer.py", line 1495, in call_hook
callback_fx(*args, **kwargs)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\trainer\callback_hook.py", line 181, in on_train_batch_end
callback.on_train_batch_end(self, self.lightning_module, outputs, batch, batch_idx)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\callbacks\model_checkpoint.py", line 309, in on_train_batch_end
self.save_checkpoint(trainer)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\callbacks\model_checkpoint.py", line 400, in save_checkpoint
self._save_last_checkpoint(trainer, monitor_candidates)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\callbacks\model_checkpoint.py", line 670, in _save_last_checkpoint
trainer.save_checkpoint(filepath, self.save_weights_only)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\trainer\trainer.py", line 1913, in save_checkpoint
self.checkpoint_connector.save_checkpoint(filepath, weights_only)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\trainer\connectors\checkpoint_connector.py", line 472, in save_checkpoint
self.trainer.training_type_plugin.save_checkpoint(_checkpoint, filepath)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\plugins\training_type\training_type_plugin.py", line 294, in save_checkpoint
return self.checkpoint_io.save_checkpoint(checkpoint, filepath)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\plugins\io\torch_plugin.py", line 37, in save_checkpoint
atomic_save(checkpoint, path)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\utilities\cloud_io.py", line 68, in atomic_save
torch.save(checkpoint, bytesbuffer)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\torch\serialization.py", line 381, in save
_legacy_save(obj, opened_file, pickle_module, pickle_protocol)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\torch\serialization.py", line 225, in exit
self.file_like.flush()
ValueError: I/O operation on closed file.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "H:\Anaconda\envs\dreambooth\lib\site-packages\torch\serialization.py", line 379, in save
_save(obj, opened_zipfile, pickle_module, pickle_protocol)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\torch\serialization.py", line 499, in _save
zip_file.write_record(name, storage.data_ptr(), num_bytes)
MemoryError
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "H:\Anaconda\envs\dreambooth\lib\site-packages\torch\serialization.py", line 380, in save
return
File "H:\Anaconda\envs\dreambooth\lib\site-packages\torch\serialization.py", line 259, in exit
self.file_like.write_end_of_file()
RuntimeError: [enforce fail at ..\caffe2\serialize\inline_container.cc:300] . unexpected pos<PHONE_NUMBER> vs<PHONE_NUMBER>
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "main.py", line 838, in
melk()
File "main.py", line 818, in melk
trainer.save_checkpoint(ckpt_path)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\trainer\trainer.py", line 1913, in save_checkpoint
self.checkpoint_connector.save_checkpoint(filepath, weights_only)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\trainer\connectors\checkpoint_connector.py", line 472, in save_checkpoint
self.trainer.training_type_plugin.save_checkpoint(_checkpoint, filepath)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\plugins\training_type\training_type_plugin.py", line 294, in save_checkpoint
return self.checkpoint_io.save_checkpoint(checkpoint, filepath)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\plugins\io\torch_plugin.py", line 37, in save_checkpoint
atomic_save(checkpoint, path)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\pytorch_lightning\utilities\cloud_io.py", line 68, in atomic_save
torch.save(checkpoint, bytesbuffer)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\torch\serialization.py", line 381, in save
_legacy_save(obj, opened_file, pickle_module, pickle_protocol)
File "H:\Anaconda\envs\dreambooth\lib\site-packages\torch\serialization.py", line 225, in exit
self.file_like.flush()
ValueError: I/O operation on closed file.`

You really can't have any other program open, worked with 0.6gb usage (3090)


Feat/ci publish packages

Fixes #148

The Stages in the publish packages workflow:

Check - Check packages and dependencies for errors
Format - Check format
Test - Test the packages
Clippy - Run clippy to check for errors
Publish - Publish packges to crates.io

The next steps:

Add CRATES_TOKEN secret to Github secrets
Try a release

Thanks. Will merge it and gave it a try on master


Added support for CollectSourceInformation flag in runsettings

@Shyam-Gupta,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Data type auto-assigning when importing from CSV to an existed table

Please add data type auto-assigning when importing from CSV to an existed table. Table rows data types will be used by default.
Additional context
The ticket is based on https://github.com/dbeaver/dbeaver/issues/9756

Not all column types are indicated correctly in Column mapping.
SQLite

MySQL

But the import works correctly inspite of it, when the exact column for import is marked

verified


Update googlemaps-snake-bot-bookmarklet

Delete the dollar symbol before the javascript when pasting

This is only for when you put it in

This is only for when you put it in


Nullable properties in XSD

The properties (and their values) that control the C# 8 nullable features should be mentioned in the XSD.
@jcouv I see a list of values in that doc, but is there help text available for each of -nullable:{enable|disable|safeonly|warnings|safeonlywarnings}? We'd probably just want to copy it into the XSD.

safeonly and safeonlywarnings are no longer a thing

I used a simplified version of your text. I don't think we have text formatting available to us in the xsd file.

Reactivating as per https://github.com/dotnet/project-system/issues/6345 this has regressed.

This will be resolved by the internal PR AB#250249.

Validated


Noaaweather

Description:
Add sensor to get weather measurements from US NOAA/National Weather Service
Related issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Not yet submitted
Example entry for configuration.yaml (if applicable):
sensor:
  - platform: noaaweather
    name: Kailua NWS conditions
    latitude: 21.4131155
    longitude: -157.7573696
    monitored_conditions:
        - temperature
        - textDescription
        - dewpoint
        - windChill
        - windSpeed
        - windDirection
        - windGust
        - barometricPressure
        - seaLevelPressure
        - precipitationLastHour
        - relativeHumidity
        - visibility
        - cloudLayers

Checklist:

[X] The code change is tested and works locally.
[X] Local tests pass with tox. Your PR cannot be merged unless tests pass
[X] There is no commented out code in this PR.
[X] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[X] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[X] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[X] Tests have been added to verify that the new code works.

Hello @rewsssiestedbo,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:

9b1a56f45a434a4f5a768fb37e0fd74467a1f15e - This commit has something that looks like an email address (hadev@bush03.localhost). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

If you only made a single commit you should be able to rungit commit --amend --author="Author Name<EMAIL_ADDRESS>
(substituting Author Name and<EMAIL_ADDRESS>for your actual information) to set the authorship information.
If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:

You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.

Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! :heart:

Hello @rewsssiestedbo,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:

9b1a56f45a434a4f5a768fb37e0fd74467a1f15e - This commit has something that looks like an email address (hadev@bush03.localhost). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

If you only made a single commit you should be able to rungit commit --amend --author="Author Name<EMAIL_ADDRESS>
(substituting Author Name and<EMAIL_ADDRESS>for your actual information) to set the authorship information.
If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:

You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.

Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! :heart:

Hi @rewsssiestedbo,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

This needs to be considered along with the weather platform PR in #23647.  I think there should be consistent naming and methodology.  I propose NWS since it the sub-agency of NOAA that provides the data.  I have no strong position here however.
There are also several different methods that were chosen in our approaches.  For example, here, the HA condition is derived through some rules from the long text description while the weather platform PR uses the icon url provided in the nws data.  These will sometimes give inconsistent results.  I like the icon url approach as it is straightforward, but I'd like to hear if there is a benefit to your approach that I haven't considered.
Another example is that you use the raw metar code as the fallback for missing or low quality data.  The weather platform PR does not use a fall back at all currently and in fact will use data marked as poor quality.  I planned on falling back to the previous observation in this case, to be introduced in a future PR.  We should align on a common fallback methodology.
I propose that we work together to iron out these differences, starting with the above two points, but I will read your PR in more detail.

This needs to be considered along with the weather platform PR in #23647. I think there should be consistent naming and methodology. I propose NWS since it the sub-agency of NOAA that provides the data. I have no strong position here however.
There are also several different methods that were chosen in our approaches. For example, here, the HA condition is derived through some rules from the long text description while the weather platform PR uses the icon url provided in the nws data. These will sometimes give inconsistent results. I like the icon url approach as it is straightforward, but I'd like to hear if there is a benefit to your approach that I haven't considered.
Another example is that you use the raw metar code as the fallback for missing or low quality data. The weather platform PR does not use a fall back at all currently and in fact will use data marked as poor quality. I planned on falling back to the previous observation in this case, to be introduced in a future PR. We should align on a common fallback methodology.
I propose that we work together to iron out these differences, starting with the above two points, but I will read your PR in more detail.

Yes, we should work together on this.   I have no particular concern about using nws instead of noaa,  If I recall, the only reason I went with noaa it seemed less likely to have a conflict with some other countries weather service abbreviation, and there was already the NOAA Tides sensor.
As far as using the icon URLs versus parsing the text description, it was not clear to me whether the icon URLs are at all stable long term.   Overall the documentation on the observation values returned is fairly sparse, so it is not clear whether they have any commitment to keeping the icon URLs stable.   The text description values have been stable for a long time, but not guaranteed either.   If my code is coming up with different results from yours, I may have just interpreted something differently or made a different arbitrary choice:  there is certainly not a one to one mapping to the HA condition values.
Finally, about dealing with missing information in responses.  I initially just had the code to avoid updating a condition if the response was missing a value for that condition.   However, for a few stations I was monitoring (PHNG and PHNL show this), there would be long periods with no valid temperature value (for example) in the temperature field, but with an updated value in the METAR record.   It is not clear to me why this happens, but it is not unusual for there to be multiple observation records without valid values for a number of conditions, but with valid values in the METAR record.
I'll try to take a look are your PR and see how best to align.

I've noticed too that sometimes some stations are better than others.  The closest station to me is always sunny or cloudy, but never rainy.  My nearby stations will only be missing/contain poor quality data for the current observation, however.
I think your metar fall back is the right approach for your case, but adds quite the complexity to the HA code base.  It seems to me like it would be better to have these decisions unified in one module(or a new pypi library) rather than spread across two platforms.  I need to think about the path forward, but one suggestion is to co-create a new pypi library that does all the data cleansing and presents HA with a very clean API.
For the icon, the big upside I see is that they publish a list of icons.  So if they change the icon names and they continue to publish this list, it will be easy to maintain.  Your method could be a nightmare if it ever changes.  You'd have to deduce the new structure of the text.

I've noticed too that sometimes some stations are better than others. The closest station to me is always sunny or cloudy, but never rainy. My nearby stations will only be missing/contain poor quality data for the current observation, however.
I suspect that the closest station to you does not have a rain gauge.   There are clearly a number of different types of stations:  those at airports that are fully staffed with weather related personal and full sets of instruments; fully automated stations at smaller airports, which may or may not have a full set of instruments; stations run by organizations other than the NWS, which only have the instruments they care about.  An example of the last case is GGWPW, which appears to have temperature, dewpoint, wind speed and direction and some precipitation detector.  It appears to have no cloud detection, so it will never return cloudy, and I'm not sure if it ever gives anything other then Clear plus a wind indication.
I think your metar fall back is the right approach for your case, but adds quite the complexity to the HA code base. It seems to me like it would be better to have these decisions unified in one module(or a new pypi library) rather than spread across two platforms. I need to think about the path forward, but one suggestion is to co-create a new pypi library that does all the data cleansing and presents HA with a very clean API.
I tend to agree with you here.   When I started I assumed that I could simply take the values and deal with unit conversion and be done.  The complexity that is there now is a result of the incremental increases that came from realizing how messy the data really is.  Creating an independent modules for getting the observation data and dealing with the mess can simplify the HA specific code enormously.
Given the organization of the NWS APIs, it would probably be best to have an observation station object model and an independent forecast object model, since the observations are dependent upon particular stations, while the forecast are for a specific grid point area, and they update at different rates.
For the icon, the big upside I see is that they publish a list of icons. So if they change the icon names and they continue to publish this list, it will be easy to maintain. Your method could be a nightmare if it ever changes. You'd have to deduce the new structure of the text.

Note that the translation to the HA weather code values was the last thing I added, and is only used as an option, since the NWS text descriptions have much more content than the HA codes, and I would rather have the direct NWS text.
Any thoughts on how to get started on creating the separate (from HA) module(s)?
For the forecast data, had you looked at using the NDFD API instead of the one you are using?   It would be somewhat more complex to handle the XML responses, but it provides much more data, including precipitation amounts, dewpoint, cloud cover, etc.

After reading through your PR again, it seems like the inconsistencies are mainly the ones I already mentioned, so I don't think we need a separate library for this.  The biggest decision is to coalesce on the name in my mind.  I will look into implementing a metar fallback in my PR.  Do you have a reference for the qc code info you used?

For the forecast data, had you looked at using the NDFD API instead of the one you are using? It would be somewhat more complex to handle the XML responses, but it provides much more data, including precipitation amounts, dewpoint, cloud cover, etc.

I did look at it, but it again adds huge complexity.  The weather.gov API is very simple and clean.

After reading through your PR again, it seems like the inconsistencies are mainly the ones I already mentioned, so I don't think we need a separate library for this. The biggest decision is to coalesce on the name in my mind. I will look into implementing a metar fallback in my PR. Do you have a reference for the qc code info you used?

I was never able to find any documentation on the qc codes.  The comments in sensors.py are a result of reverse engineering/review of the results from a number of different stations over a few months.
For the HA conditions, it appears that the differences in the results from using the icons versus the text are for:

"lightning" versus "lightning-rainy", since I chose to have "Thunderstorm in vicinity" be treated as "lightning", and other values as "lightning-rainy".
"pouring" versus "rainy", since the NWS icons for rain and heavy rain are the same, but the text is different.
"hail" - I just added this, since it is not in the documentation page for a weather component, but is in the demo code.

As far as the name, it makes sense to use nws.

For the forecast data, had you looked at using the NDFD API instead of the one you are using? It would be somewhat more complex to handle the XML responses, but it provides much more data, including precipitation amounts, dewpoint, cloud cover, etc.

I did look at it, but it again adds huge complexity. The weather.gov API is very simple and clean.

I added the metar fallback logic into the upstream pynws library with a new class. My implementation was simply to check for missing values in the observation.  For missing values, replace with metar values, if available.  I only put in the metar fallback for the weather platform variables (temperature, pressure, etc.) so far, but it is written in a way that should be straightforward for other variables if they are contained in the metar report and can be parsed with the metar library.
I'm willing to consider more complex logic in the pynws library, too if warranted.

Closing to wait for integration of nws weather component, and then integration of the sensor code with that component.


Replace base64 with plain body

At the moment, badges with icons such as these:

… contain svg-logos in the base64-coded form in the attribute of <image /> tag:
<svg xmlns="...">
  <!-- some code -->
  <image xlink:href="data:image/svg+xml;base64,HUGE+DATA"/>
  <!-- some code -->
</svg>

But it is possible to embed one svg-image into another svg-image as plain body. For example:
<svg xmlns="...">
  <!-- some code -->
  <svg><!-- plain body of injected svg --></svg>
  <!-- some code -->
</svg>

Test it with the example in the wild: https://commons.wikimedia.org/wiki/File:English_language.svg
In this case, child svg inherits properties of parent svg, but you can override them:
<!-- now -->
<image x="5" y="3" width="14" height="14" xlink:href="data:image/svg+xml;base64,HUGE+DATA"/>
<!-- will be -->
<svg x="5" y="3" width="14" height="14" viewBox="..."><!-- plain body --></svg>

You even can remove xmlns="http://www.w3.org/2000/svg" attribute from child svg!
Using this tip you can replace the huge base64 code with simple, short and readable plain code.
But of course, it breaks the current algorithm for generating the badges. What do you think?

That's a very interesting option! We could special-case data:image/svg+xml to include the SVG inline.

bump

It is already possible to embed image into tag, just make sure to replace double quotes with single ones. Here I replace gitter logo with appveyor:
https://img.shields.io/gitter/room/nwjs/nw.js.svg?logo=data%3Aimage%2Fsvg%2Bxml%2C<svg+xmlns%3D'http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg'+width%3D'40'+height%3D'40'+viewBox%3D'0+0+40+40'><path+fill%3D'%23FFF'+d%3D'M20+0c11+0+20+9+20+20s-9+20-20+20S0+31+0+20+9+0+20+0zm4.9+23.9c2.2-2.8+1.9-6.8-.9-8.9-2.7-2.1-6.7-1.6-9+1.2-2.2+2.8-1.9+6.8.9+8.9+2.8+2.1+6.8+1.6+9-1.2zm-10.7+13c1.2.5+3.8+1+5.1+1L28+25.3c2.8-4.2+2.1-9.9-1.8-13-3.5-2.8-8.4-2.7-11.9+0L2.2+21.6c.3+3.2+1.2+4.8+1.2+4.9l6.9-7.5c-.5+3.3.7+6.7+3.5+8.8+2.4+1.9+5.3+2.4+8.1+1.8l-7.7+7.3z'%2F><%2Fsvg>

More info here - https://codepen.io/tigt/post/optimizing-svgs-in-data-uris

Should I consider this bug fixed, @thekondrashov?

Feel free to reopen if you'd like to discuss further.

The image as mentioned by techtonik is not working, neither in chrome nor in safari. It shows an error error on line 1 at column 652: Unescaped '<' not allowed in attributes values. Is this a known issue, or was it introduced by a certain change?

@MetalArend yes, it became broken after some Chrome version (or maybe GitHub?). See https://github.com/badges/shields/issues/507#issuecomment-254944913 for fixed examples.

Cool, thanks! :)


Add gearInvalid to gearState

I noticed that when getting out of the car, candash will unhide the blindspot markers, because gearState will change from park to invalid, and the blindspot markers are only hidden while in park.
Additionally, the P would stay highlighted when gear is invalid.
This adds gearInvalid support for gearState, which will ensure blindspot markers stay hidden when the car turns off, and greys out the P as well to indicate the car is off.

Tested on model 3 parked with nearby objects:
https://photos.app.goo.gl/VxkHAEc7w6Mk7zH67

in park: bs hidden
in drive: bs shows
in park and leave seat: bs remains hidden and P greys out


Bottom line hiding text when set full screen mode

Scenario: When not set full screen mode working fine
I don't want to show draggable text editor so i set full screen mode for disable draggable.
Now effect is when we type text working fine before last line of the height of text editor. When we type last line of editor last line showing half of the line not fully how we can resolve

Not set controller full screen mode Above image working good

When we set controller full screen mode hiding text below of text box

also here, any solution?

Any solution

@tneotia  Hi any update?

any update?

any solution


Reactive value generation

Fixes #1099

OK, this patch is bigger than expected, so can you give me until tomorrow evening to look it over?

Sure.
On Tue, 21 Dec 2021, 21:51 Gavin King, @.***> wrote:

OK, this patch is bigger than expected, so can you give me until tomorrow
evening to look it over?
—
Reply to this email directly, view it on GitHub
https://github.com/hibernate/hibernate-reactive/pull/1103#issuecomment-999085968,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEIQ5LZSFLRC3KHBUN6I33USDSGBANCNFSM5KQDIFMQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

So I think we need to find some way of removing the inheritance from ValueGeneration.
That's a problem I had not noticed.

Yeah, I agree, but I cannot think of a better solution right now.

Right, neither can I.

Maybe having abstract classes instead of interfaces is slightly better in this scenario: 2998ff0f5f3ff82d1d787fbb836a5ef8b27c4442

Because it lets you redeclare the method final, you mean?

Yes

I'm also going to add the @Incubating annotation to clarify that's a temporary solution.
This way people people have at least a workaround for this feature.

I'm also going to add the @Incubating annotation to clarify that's a temporary solution.
This way people have at least a workaround for this feature.

That's a good idea.

Done. I'm going to merge it as it is if there is no strong opposition

My only question was: does it break in-memory impls of ValueGeneration, or do they still work?

How can I test it? All our tests are passing ...

Well, the @CurrentUser annotation is our test for that.

Sorry, I mean @GeneratorType(type = LoggedUserGenerator.class, when = GenerationTime.ALWAYS)

I've moved the code around but I don't think I've changed anything of the original logic (not on purpose at least).
The core of the change is the method ReactiveAbstractEntityPersister#generateValue.
If a user will use the new reactive classes, Hibernate Reactive will call the reactive methods. Implementations of ValueGenerator will still work.
We test the new classes via GeneratedProperty*Test but we also have a test for ValueGenerator via TimestampTest because it tests the use of the annotations @CreationTimestamp and @UpdateTimestamp (they use a valuegenerator underneath). Maybe adding a direct test for ValueGenerator would be wise though.
The drawback of allowing an implementation of ValueGenerator is that a user can access the ReactiveSession, something that normally would be hidden.
Overall I think our tests cover most cases (I was pleasantly surprised when I've seen the test suite fails when I've started to work on this) but  if you have some other test in mind, let me know.

Merged.
This should be good enough for now.


How do I make the Appbar hide when I press the RESENTS button in the flutter

Hi !
How do I make the Appbar hide when I press the RESENTS button in the flutter as in Java on Android Studio ??
the images below show the difference...
In Java ..

But in Flutter ...

@HansMuller Is this something you'd like to support as a future feature? If not, I'd like to close this as we've redirected to Stack Overflow.

There aren't any current plans to support this feature. It sounds reasonable but AFAIK it's not part of the Material Design spec.

Hi @alshamynet
It doesn't seen to match Material Design Spec
For custom implementation, This platform is not meant for assistance on personal code.
Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you"


Reviving sphinxcontrib-ansi

That is a tracking ticket for actions needed for bringing back the project to being actively maintained:

[x] @ssbarnea pypi project ownership
[x] @ssbarnea added as core on github. I still need admin as current permissions do not allow me to control webhooks or configuration access to branches. Related to https://github.com/sphinx-contrib/github-administration/issues/13
[x] review and eventually merge current PRs
[x] configure github actions pipelines
[x] bring CI to green on current versions of sphinx
[x] configure RTD integration https://readthedocs.org/projects/sphinxcontrib-ansi/
[ ] team up with others, collective maintenance is better

@ssbarnea
Are there any other contributors that want to work on this project (except me) ?

@jenisys Nope. I send you an invite https://github.com/sphinx-contrib/ansi/invitations

@ssbarnea
Could you resent the invitation as maintainer?
It was probably expired when I noticed it last time.
In addition, some things needs fixing, like:

namespace module: must be solved differently by now
Some ANSI escapes are currently not expected at leads to exceptions (like mentioned in #9)


Remove argue.js to improve performance by almost 40%

I was evaluating the QPS performance on GRPC on Java/Node.js for an internals project, when I was surprised by low QPS numbers for Node.js dug in I found that big chunk of time was spent in argue.js call to fill in default and optional function parameters (see below for number and flame graph of profile output) so I have modified the code to fill in the default and optional parameters.  Results for Node.js QPS benchmark can be reproduced using this benchmark driver.
 The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

I signed it!

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

This is ok to test.

I think you mean "without" in the second series of benchmark ?

Also we're kind of unlikely to release another 1.3 package at that point; do you think you could do that change either against master or the 1.4 release branch ?

1.4.x is fine with me if you manage to get it there. Master would be the default if you can't.

Ping @kprakasam. Can you recreate this change against v1.4.x or master?

I am testing against 1.4.x, I'll send the PR today or tomorrow latest

I sent a new pull request for v1.4.x branch.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thank you. I'll close this one and use the new one instead.


Add old versions to the products available in cart download

For some datasets there are multiple versions of the products available. We should make it possible to download the old versions as part of the shopping cart process.
The OPUS search criteria will always be based on the most recent version.
See
pdsf.associated_parallel(..., rank=something)
to get access to the different 'version ranks' of a file or volume.
A version rank is an integer that encodes the version number or status of a volume or product. The latest version is 999999. In lien resolution translates to 990400. For other than the latest version, the rank is an encoded form of the version number, e.g., _v2.1 = 201000.
Each PdsFile object has a property version_ranks that returns the sorted list of all versions of this volume or file.

See also issue #288, which also requires use of ViewMaster routines.

Prior version  downloads are now available on the Detail page.

Idea from Mark 1/25/2022: Instead of specifying versions by number, allow a download of the version that was present "on a specific date" and separately anything that has changed "after a specific date".


Automated Latest Dependency Updates

This is an auto-generated PR with latest dependency updates.

Closing for #4283


Potential Write GUID optimization

I was looking at the implementation for writing GUIDs, and I was wondering if adding a separate lookup table would improve anything.
Right now you're taking each byte of the GUID and multiplying it by two to get the proper offset into the lookup table.  By splitting the lookup into two parts (first nibble, second nibble) you could do all the lookup without the additional math.
Any possibility of improvement there?
static readonly char[] WriteGuidHighLookup = new char[] { '0', '0', '0', '0'... };
static readonly char[]  WriteGuidLowLookup = new char[] { '0', '1', '2', '3'... };

// bytes[0]
buffer[6] = WriteGuidHighLookup[visibleMembers.B00];
buffer[7] = WriteGuidLowLookup[visibleMembers.B00];
...

// or alternatively all the high nibbles first if there
// is overhead for looking up in a different array.
buffer[6] = WriteGuidHighLookup[visibleMembers.B00];
buffer[4] = WriteGuidHighLookup[visibleMembers.B01];
buffer[2] = WriteGuidHighLookup[visibleMembers.B02];
...

Interesting idea, let's try some microbenchmark for that: https://gist.github.com/Tornhoof/825f881687a79294376404ef4d0a994f
Jil is the original method, Veleek is your first suggestion, Veleek2 is your second one.

BenchmarkDotNet=v0.10.5, OS=Windows 10.0.15063
Processor=Intel Core i7-4790K CPU 4.00GHz (Haswell), ProcessorCount=8
Frequency=3906242 Hz, Resolution=256.0005 ns, Timer=TSC
  [Host]     : Clr 4.0.30319.42000, 64bit RyuJIT-v4.7.2046.0
  DefaultJob : Clr 4.0.30319.42000, 64bit RyuJIT-v4.7.2046.0

Method
Mean
Error
StdDev

Jil
19.25 ns
0.0020 ns
0.0018 ns

Veleek
18.08 ns
0.0398 ns
0.0372 ns

Veleek2
18.86 ns
0.0524 ns
0.0437 ns

So in a dedicated microbenchmark environment your idea might be a few % faster, but as the individual runtimes are already reaching the limits of microbenchmarking, I replaced the single invocations with a loop of 1000 invocations. The output looks like this then:

Method
Mean
Error
StdDev

Jil
19.11 us
0.0041 us
0.0030 us

Veleek
18.46 us
0.0078 us
0.0065 us

Veleek2
19.95 us
0.0062 us
0.0055 us

The difference is now much closer and I have no idea why Veleek2 is suddenly slower.

Okay, so a little bit faster, but maybe not worth it.  The slowdown in Veleek2 probably has to do with the fact that it has to load the byte value from the GuidStruct twice instead of just once.
Running the benchmarks on my machine gives slightly better results - ~20%.

Method
Mean
Error
StdDev

Jil
29.29 ns
0.6356 ns
0.9896 ns

Veleek
23.24 ns
0.1770 ns
0.1656 ns

Veleek2
27.10 ns
0.3796 ns
0.3550 ns


Utilize has_view_permission to let users with view permissions see the history

Problem Statement
Currently, a user with view permissions can see the model instance itself, but not the history.
Describe the solution you'd like
A user with view, but not change permissions, to be able to view the history.
Describe alternatives you've considered
Additional context

What I am proposing / working on in PR #529 might address this.

I have a PR I am submitting now that adds a settings attribute SIMPLE_HISTORY_ENFORCE_HISTORY_MODEL_PERMISSIONS. When set set to True, permissions assigned
to history models are assigned and evaluated explicitly and do not implicitly use the permissions from the concrete model.
This adds flexibility to allow/disallow access to history models by model.

Linking the PR mentioned in the comment above, as it seems to resolve this issue. Please undo if that's not the case!


Data loader token length?

Hello, my finetune data has a median of 6000 tokens and 9000 max tokens. what data loader is torch tune using and do I need to specify sequence length for the data set?
How do I calculate memory use in this case?
Thank you!

TorchTune is using PyTorch's standard DataLoader: https://github.com/pytorch/torchtune/blob/83c06d422ebf686b418faf84f1cc346ea8c4902b/recipes/lora_finetune_single_device.py#L301
As of now, you don't need to specify sequence length in the dataset. We still need to add support for truncating past the maximum sequence length.
Your peak memory usage will likely consist largely of the model instead of the data in your case with 9000 max tokens.

Thanks for the pointer! Looking forward to torchtune's future development


Best matc tie-breaker

During the conversation filtering, an indication of "best" match indicating if multiple matches have been made during the filtering process, must be build.
The resulting value should then be used as tie-breaker in the situation where multiple conversations are remaining at the end of the filtering process.

HTTP - Best match score could be calculated as follows

+1 for method match
+1 for url-path
+1 for each query match
+1 for each header match
+1 for body match

the conversation with the highest score wins..


panlint: support minus sign and simple expressions in squarebrackets

Fixes #142
Fixes #143

@jrha feel free to propose more unittests 😄