Do not enforce type Symbol for argument mod

Hej!
I noticed that as soon as options are specified in the YAML header of a file, it is not possible anymore to weave in a module such as Main. The problem is that during parsing and merging of the header arguments mod is converted to a Symbol in https://github.com/mpastell/Weave.jl/blob/master/src/config.jl#L112, but https://github.com/mpastell/Weave.jl/blob/master/src/run.jl#L57 requires mod to be a Module.
As an example, for a simple file test.jmd such as
---
options:
  out_path: test.md
  doctype: github
---

This is a test.

the command
weave("test.jmd", mod = Main)

fails with the error message
ERROR: MethodError: no method matching eval(::Symbol, ::Expr)
Closest candidates are:
  eval(::Module, ::Any) at boot.jl:328
Stacktrace:
 [1] #run#29(::String, ::Symbol, ::String, ::Dict{Any,Any}, ::String, ::Nothing, ::String, ::Symbol, ::Bool, ::typeof(run), ::Weave.WeaveDoc) at /home/david/.julia/packages/Weave/L0NNS/src/run.jl:57
 [2] (::getfield(Base, Symbol("#kw##run")))(::NamedTuple{(:doctype, :mod, :out_path, :args, :fig_path, :fig_ext, :cache_path, :cache, :throw_errors),Tuple{String,Symbol,String,Dict{Any,Any},String,Nothing,String,Symbol,Bool}}, ::typeof(run), ::Weave.WeaveDoc) at ./none:0
 [3] #weave#16(::Symbol, ::Symbol, ::Symbol, ::Dict{Any,Any}, ::Module, ::String, ::Nothing, ::String, ::Symbol, ::Bool, ::Nothing, ::Nothing, ::Nothing, ::Array{String,1}, ::String, ::typeof(weave), ::String) at /home/david/.julia/packages/Weave/L0NNS/src/Weave.jl:121
 [4] (::getfield(Weave, Symbol("#kw##weave")))(::NamedTuple{(:mod,),Tuple{Module}}, ::typeof(weave), ::String) at ./none:0
 [5] top-level scope at none:0

This PR fixes that issue (and replaces getvalue with the equivalent get) - however, I'm wondering whether a mod option in the header should be handled differently. It seems "sandbox" is the only valid option since everything else will fail due to the same issue? Maybe one should explicitly check if it is set to "Main"?

Coverage decreased (-0.2%) to 81.877% when pulling d5d954f60f836df681890c0876643a096be9203d on devmotion:mod into c9a814759dba764931582f7dc91e0d92633a7e4d on mpastell:master.

Thanks! Probably it would be good to check whether it is set to sandbox as that is the only valid "non-module" option. It is possible to use other modules that Main. The only possibly useful situation I can think of is to use the same sandbox module for several documents.
Could you make the change?

With the latest commit the following behaviour is enforced:

For the file test.jmd
---
options:
  out_path: test.md
  doctype: github
  mod: sandbox
---

This is a test.

the module specified on the command line is used, i.e.,
weave("test.jmd")

and
weave("test.jmd", mod = :sandbox)

run in a sandbox module whereas e.g.
weave("test.jmd", mod = Main)

uses the Main module.

For the file
---
options:
  out_path: test.md
  doctype: github
  mod: sandbox
---

This is a test.

a sandbox module is used, regardless of the setting of mod on the command line.

For the file
---
options:
  out_path: test.md
  doctype: github
  mod: sandbox2
---

This is a test.

the header option is ignored and the module that is specified on the command line is used.


Update URLs in package.json

The URLs in the package.json which link to the repository lead to a page that no longer exists, updated URLs to reflect the current repository in the package.

Commit a986e94 should be the only one that is considered. All other commits before it were accidentally pushed to this branch, thus all commits coming after a986e94 are reversions of the prior commits.


port git-status-cache to linux, macintosh

Might this project port to linux and the mac?
git and much around it is portable: dotnet core, libgit2sharp, powershell core, etc. I just set up posh-git from its master branch on linux and it seems very slow in my VM environment. It looks like a port of GitStatusCachePoshClient would probably make a big difference.

@BernMcCarty can you enable $GitPromptSettings.Debug = $true and share what you're seeing for timings?

Hopefully this is what you were looking for:
VERBOSE: 00067:Getting status
VERBOSE: 00369:Parsing status
VERBOSE: 00371:Status: ## master...origin/master
VERBOSE: 00375:Status:  M BuildInf/Install-NvcPoshModules.ps1
VERBOSE: 00379:Status:  M BuildInf/LoadPoshGit.ps1
VERBOSE: 00390:Building status object
VERBOSE: 00484:Finished

@dahlbyk sadly no, not at the moment.  Right now I am only using this version of posh-git on an Ubuntu guest of a Windows 7 virtualbox host.  The host machine is pretty good but the .vdi is on over on an unimpressive spinny disk, so performance is wanting generally.  I started to try to bring GitStatusCachePoshClient into the equation to try to get some better performance before I even realized that it was windows only.

👍 thanks for clarifying. I'll defer to @cmarcusreid as to how hard it would be make this work x-plat, but at least the libgit2 portion of it should work fine cross-platform.
Down with spinning rust!

I don't currently have plans to implement cross-platform support, but it'd be a welcome contribution!
Most of the logic is platform agnostic. I think there are two pieces to figure out:
1.) The file sytem watcher (ext/ReadDirectoryChanges/) uses raw Windows APIs.
2.) The cache executable and PowerShell module communicate over named pipes.

I'd like to share some of my knowledge.
For the platform agnostic parts, we have some stable alternatives:

The file system watcher: https://facebook.github.io/watchman/
The named pipes. https://man7.org/linux/man-pages/man7/fifo.7.html & https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man2/mkfifo.2.html. But I think it more reasonable to communicate with standard RESTful API instead of named pipe. It's easy to understand, standardized, easy to debug, and accessible cross-platform.

I'm considering rewriting GitStatusCache with C#.

"Using Watchman and the sample hook script" in https://github.blog/2022-06-29-improve-git-monorepo-performance-with-a-file-system-monitor/

TIL! We should add a note about this to the posh-git readme.
TL;DR, upgrade to Git 2.37+ and:
git config --global core.fsmonitor true
git config --global core.untrackedcache true

(If you set core.fsmonitor true on a slightly older version, Git and posh-git get confused.)

@dahlbyk be careful to enable it globally if you have many repos in your machine. I believe the builtin fsmonitor would launch 1 background process for each repo. The solution I mentioned would only launch a centralized background process.
BTW, I also think it boring to setup fsmonitor. I use microsoft scalar, it has a scalar register command for that. You can install it by install the latest version of microsoft maintained git.


spiral matrix: added exercise.

Implemented Spiral Matrix for #48in24

@ErikSchierboom Any feedback is welcome)

Thanks!


[Custom]:  Word Ladder II to Top DSA interview questions

Issue Summary
Word Ladder II
Issue Description
Given two words (beginWord and endWord), and a dictionary's word list, find all the shortest transformation sequences from beginWord to endWord. Each transformed word must exist in the word list.
Proposed Solution (Optional)
No response
Priority
High - Requires urgent attention
Category

[ ] Enhancement
[ ] Refactor
[ ] Security
[ ] Design
[ ] Other

Additional Context (Optional)
No response

@shriyadindi, Please only open four PRs and issues at a time, or they will not be considered for evaluation.


Documentation not matching at the official website

It looks like the official documentation of Deepgram API usage https://developers.deepgram.com/docs is not updated to the latest version of the API. Please check the content.

This should be fixed now.
Pre-recorded:
https://developers.deepgram.com/docs/python-sdk-pre-recorded-transcription
Live:
https://developers.deepgram.com/docs/python-sdk-streaming-transcription
If you have any issues with the official documentations, please let me know. Feedback is welcome!

Thanks for the Update!


Example not ideal WRT SizeChanged event

The example on the page uses the SizeChanged event to detect changes in Tablet mode.
However, if the window is maximized then no SizeChanged event is raised when switching to/from tablet mode.
I have not yet found a better trigger event.
Best, Lars

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 333bde8d-7b85-7b21-b37d-d05bcc7b6f18
Version Independent ID: 6167298e-f6ba-2c3f-8cfe-b799c4517bc2
Content: UIViewSettings Class (Windows.UI.ViewManagement) - Windows UWP applications
Content Source: winrt-api-build/xml/Windows.UI.ViewManagement/UIViewSettings.xml
Product: uwp
Technology: winrt-reference
GitHub Login: @Karl-Bridge-Microsoft
Microsoft Alias: kbridge

Hi @chrisgull, thanks for letting us know about this issue. I replaced the snippet with code from the latest related sample and added a link to that sample. Hope this helps.

Awesome!


Revert "cilium, recorder: rebuild upon wildcard mask change"

This reverts commit 935d816a59ec9af92b41e9ba1f4d8412c66cc83b (PR #15633) as we believe it to be causing #15737.

test-1.16-netnext

@nbusseneau Let's test it for sure, but I would find it highly surprising if this really was the root-cause. The recorder logic is only used when --enable-recorder=true is passed to the cilium agent, which (to my knowledge) we are not enabling in CI right now.

Yea I used the wrong SHA while doing git revert, oops. Fixing.

test-1.16-netnext

Yea I used the wrong SHA while doing git revert, oops. Fixing.

Ah! In that case, I believe you might also have to revert #15680 because it uses the packages introduced by reverted commits.

If this is just a draft for testing, ok. Otherwise NAK.

test-1.16-netnext

test-1.16-netnext

Not culprit.


Proto API

Create a proto API for all necessary services:

SessionService (authentication within the local network)
DownloadService (download management)
ContentService (media library management)

Ready & merged


Is this still being developed?

Need to know if I should make pull requests or just fork.

Fork it, I don't think its managed.

Yes, fork if needed. I am not managing this anymore.
so 8. 9. 2018 v 15:44 odesílatel Najam<EMAIL_ADDRESS>napsal:

Fork it, I don't think its managed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ReshNesh/pixlserv/issues/14#issuecomment-419647176,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABJkMfEk-aBzRvlCwJslcxFvQ3d7qqZ3ks5uY9fbgaJpZM4EaoPF
.


Fix shutdown logging

Fix for https://github.com/kubernetes-sigs/aws-alb-ingress-controller/issues/786

/ok-to-test

/lgtm

/approve


Support allowNonTransactional config for ProducerConfigurationMessageHandler

Producers for batch processing may not need transactions.
Could you provide allowNonTransactional config to ProducerConfigurationMessageHandler and KafkaTemplate?

This is a reasonable request.
In the meantime, there are two workarounds:

Use the multi-binder support to configure two binders; one transactional and one not.

Use a customizer with a bit of reflection:

@SpringBootApplication
public class Kbgh990Application {

	public static void main(String[] args) {
		SpringApplication.run(Kbgh990Application.class, args);
	}

	@Autowired
	StreamBridge bridge;

	@Bean
	ApplicationRunner runner() {
		return args -> this.bridge.send("notTx", "foo");
	}

	@Bean
	ProducerMessageHandlerCustomizer<?> customizer() {
		return (handler, destinationName) -> {
			if (destinationName.equals("non.tx.topic")) {
				((KafkaProducerMessageHandler<?, ?>) handler).getKafkaTemplate().setAllowNonTransactional(true);
				new DirectFieldAccessor(handler).setPropertyValue("allowNonTransactional", true);
			}
		};
	}

}

spring.cloud.stream.kafka.binder.transaction.transaction-id-prefix=tx-
spring.cloud.stream.kafka.binder.required-acks=all
spring.cloud.stream.bindings.notTx.destination=non.tx.topic

@garyrussell
Thank you for your consideration
I will apply the workaround you gave as a guide, and will switch when options are added later.


PowerToys Run Does Not Launch on Latest Windows Insider Release

Environment
Windows build number: Microsoft Windows [Version 10.0.19635.1]
PowerToys version: 0.18.1
PowerToy module for which you are reporting the bug (if applicable): "PowerToys Run"

I have UAC off (EnableLUA=0).
Steps to reproduce

Install PowerToys
Trigger PowerToys Run (alt+space)

Expected behavior
For PowerToys Run to launch
Actual behavior
Nothing happens.  I tried changing the shortcut, disabling and re-enabling Run, and still nothing.

I get the same result

I cannot open it either

See #3650
I ended up downgrading back to 0.18.0.  Disabling Admin and restarting seemed to work for a few people.

does not open

For those who can still not run PowerToys Run, please see https://github.com/microsoft/PowerToys/issues/3650


Replication starts again while restarting the container

Hi Team
replication start from first while restarting the running container

Can you please add more details what you are seeing and what you want to report as a bug? It's not really clear for me, thanks.


Onkyo Zone2/Zone3 issue

Home Assistant release with the issue: 0.70.1

Last working Home Assistant release (if known): NA
Operating environment (Hass.io/Docker/Windows/etc.): Hass.io & Docker

Component/platform: homeassistant/components/media_player/onkyo.py

Description of problem: Everything of my main zone works perfectly. However, Zone 2 can't be discovered and Zone 3 can be discovered but doesn't reply to service call.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
media_player:
  - platform: onkyo
    host: <IP_ADDRESS>
    name: onkyo Receiver
    sources:
      dvd: 'PC'
      video2: 'TV'
      video1: 'PS4'
      video3: 'Xbox'
      video6: 'Box'
      network: 'Music'

Traceback (if applicable):
I'm using NR3030, I can't setup volume for both zone2 and zone3 on my onkyo mobile app.
In further, I get some error message from line 191 of the onkyo.py file (that line says: self._volume = volume_raw[1] / self._max_volume). Then I have an assumption that HA should not get status of volume updated from zone2 and zone3. After delete this line, the problem seems been solved.
I'm a beginner of python, I can't judge if my assumption and solution is right or not, so just report this issue for developers to check.

Additional information:

@snikch Do you like to help here?

Same problem on my end.

@syssi Yep, I'll jump in.
@BarcodeQH or @bittles if you run HA with debug logging for the Onkyo component, can you please let me know what output you get?
This should get you the logging set to debug for just the onkyo component.
logger:
  logs:
    homeassistant.components.media_player.onkyo: debug

As a bit of background, it was me that wrote the "Auto detect" for the Onkyo component. I have an RZ-800 and NR-646 and tested with both those devices.

@snikch Thank you for the help!
Here's the log (with the standard onkyo component):
home-assistant.log
Here's the custom components I modified based on the standard onkyo component.  Everything goes very well with it at least for my case.
onkyo.txt
I removed the auto-zone determination part - at begin I think this is the reason for my zone2's disappear, but it didn't help
Then I tried to use shell command to call zone2 directly and found the answer is always very slow, it can take 1-5 mins.
After that I noticed the error message about update volume, and I tried to delete that line. After I did that my zone2 comes back normally and no delay anymore.
I have all my speakers connected to the main zone, zone2 is just like a HDMI output for me. When I try to use onkyo's mobile app set a volume for zone 2, I always get a notification from the receiver "Zone 2 out fixed".
My guess is:
HA is trying to get volume status update from onkyo zone2 when it starts. But the receiver can't answer this eiscp command when there's no speaker connected to zone2. Things blocked here, and all other call can only get answer after the volume status update call is timeout. Then HA give up the zone2 and make it invisible. Similar story for zone3
In further, I tested with my modified components file and found the set_volume_level command won't block anything (just get a notification "Zone 2 out fixed"). Problem is only for volume query command.
Please let me know if I can help with more test.

@BarcodeQH thanks for that info, that's great. Did you have this working previously or have you just installed the component? (trying to figure if the auto zone discovery has caused a regression).
I think what's happening with the volume is that since it can't be set, the query for the volume is returning info in a format that the Onkyo component isn't expecting. It will be a string response in volume_raw[1] whereas it's expecting a number type of some sort (either integer or float).
If you put your onkyo component back to its original state, and then add in a debug line before the line where the exception occurs (i.e. after volume_raw is instantiated but before line 310 where the exception happens) then we'll see what the value is that's coming back.
This will likely do it, although somebody with more python experience might have a better way.
_LOGGER.debug("Volume Type: %s", type(volume_raw[1]))
_LOGGER.debug("Volume Value: %s", volume_raw[1])

Once you confirm its type (strictly not necessary, I'm just interested) we can wrap the volume assignment in a type check:
if type(volume_raw[1]) is int or type(volume_raw[1]) is float:
  self._volume = volume_raw[1] / self._max_volume

Also, that's a baller receiver. V nice.

@BarcodeQH Can you mute or unmute the sound for that zone? Just looking into which features to support when the zone is set to HDMI.

Turns out this was the same for my Zone 3 since it's just a pre-out. That makes it easy to test.

Good work guys! :-)

@snikch sorry for my late reply
I tested both cases (zone2 for HDMI-out, zone3 for pre-out) at my side with the new component. Both Zone2 and Zone3 can be discovered, the volume control bottoms (mute/volume up/volume down/volume bar) are removed. And other features (power on/off, change source) just work very well, no delay.
Thank you for helping solve this issue!


FIX: Typescript error for react 17 or above

PR Fixes:

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I assure there is no similar/duplicate pull request regarding same issue

only tsconfig.json was changed.
other files are formatted by husky during commit stage as mentioned in the readme.md

can u use --no-verify option and create one with minimal changes?


Warn when a deprecated option is used.

Example:
$ bin/jshint --verbose -  <<< "
/*jshint indent: 2 */
function a() {
  return 1;
}
a();
"
stdin: line 2, col 1, The 'indent' option has been deprecated and will be removed in the next major release of JSHint. (I004)

1 error

Coverage increased (+0.01%) to 96.57% when pulling 3c506d1a355d9bb58c8da47f30dd33db08a36e35 on nicolo-ribaudo:deprecated-optinons into e47168f5aa9576819830554f1b37dc0d49b76d31 on jshint:master.

This is a nice idea, but it is a backwards-breaking change. We should revisit it for JSHint 3.0

Fixes #1346

I think this pr can be close, as deprecated options will be removed in JSHint 3 (so this will be unuseful)

@jugglinmike in v3 are we just giving deprecated warnings or actually removing those options completely?
@nicolo-ribaudo it has some value because it would be better to error/warn that the option doesn't exist and why than the generic invalid option..

in v3 are we just giving deprecated warnings or actually removing those options completely?

There are many options that have been documented as "deprecated" for many months. We'll remove those completely in JSHint 3.0. Anything that we've only recently documented as deprecated (predef comes to mind, but there may be others) will trigger a notice but continue to function in the next major release.


Add  mappings

Add four <Plug> mappings to you to customize key mappings like below.
imap <c-k>a <Plug>(JavaComplete-Imports-Add)
imap <c-k>r <Plug>(JavaComplete-Imports-RemoveUnused)

you can also map on normal mode in same way.
nmap <c-k>a <Plug>(JavaComplete-Imports-Add)
nmap <c-k>r <Plug>(JavaComplete-Imports-RemoveUnused)

If I say in correctly, you should do mapping to <plug> with <buffer> like below.
imap <buffer> <c-k>a <Plug>(JavaComplete-Imports-Add)
imap <buffer> <c-k>r <Plug>(JavaComplete-Imports-RemoveUnused)

:metal:

probably AddI should be Add. will fix

please do not map keyboard ,using (command names )
let people decide which keyboard collection to use themself

sorry i have no attention on the file changes

Please look the chage carefully. I'm not mapping into keyboard. And please read :help <Plug>

how fast you reply i have just say no attention

Please, can you explain, what advantages it give us?

How you define mappings of imports#AddI ? like below?
inoremap <leader>ia <esc>:JCimportAddI<cr>

For example, <leader> should be backslash character if you doesn't modify mapleader.
Then try below. at the first move the cursor into |, and type o\ia.
public class Foo {
	public static void main(String[] args) {|
	}
}

Then, cursor should move to top of the line.
public class Foo {
	public static void main(String[] args) {
|
	}
}

Because typing <esc> key reset the indentation in the line. And we must know two interface JCimportsAdd/JCimportsAddI. But user don't have to know which interface is a command to add imports on insert mode. And you will be able to change implementation of the calling of imports#Add if you provide <Plug> mapping. For example, adding arguments. Rename function.

as i know i have add  two maping
inoremap <leader>ia <esc>:JCimportAddI<cr>
nnoremap <leader>ia <esc>:JCimportAdd<cr>
``
if mapping like this is there any bug?

i have try with my mapping,the cursor will not change to other please,what is your mapping of this plugin?

I see, looks like this is better and cleaner way to call commands in insert mode, right?

Combination of <esc> and a is not perfect for all situations.

@mattn  thi pic you show also appear in my pc
if i type F4 in a new line the cursor will change to the beginning of the blank line

sorry  it will not appear

you need to type o before.

There is issue for such method. When you in insert mode and have several result for class name, options are not visible. For example for List or Date.

really when i use F4 in new line will change to the beginning  and change to nomal mode

Most of advantage is that it's possible to avoid to everyone to know this confusing behavior by this way.

@mattn so any thought about issue I have wrote?

@artur-shaik fixed.


Test all newline combinations in round trip tests

Refocusing this to be about testing both LF and CRLF with CodeFormattingOptions, since #256 will effectively "fix" the tests not passing.

The round trip tests assume that the C# file they're written in (thanks to @"" strings) is the same as Environment.NewLine. The file's line endings are \r\n since the file was created on Windows, so the tests fail on platforms other than Windows.
Test cases should be normalized, and potentially tested against both \n and \r\n.

In this case, I'm specifically referring to the round-trip tests, which do a character-for-character check to see that the tokenizer and parser will give back exactly what they were given (so long as they were configured to be in verbatim mode).
Honestly, reading over ParserRoundTripTest makes me want to just trim the whole thing down; there's a decent amount of code there that's just for pretty printing string differences that would be better written as a single line of FluentAssertions.

Ah, OK. I thought about baselines, I believe RTVS normalized baseline files to just LF.

They could also be converted to DataTests at the same time, though there are so many test cases that it might look really silly in the test explorer. 😛

Refocusing this to be about testing both LF and CRLF with CodeFormattingOptions, since #256 will effectively "fix" the tests not passing.

Doesn't have to be done this sprint


upload django 1.11+ compatible release on pypi

subj

Sorry. It took me this long to publish this to PyPi
https://pypi.python.org/pypi/django-usersettings2/0.1.6


RetroMCP failed to start the game while opening with zulu JDK

This information alone is not enough to solve the issue

The issue is this

Closing due to lack of info


Optimize BaseNDArray.equals

https://github.com/deeplearning4j/nd4j/blob/b017281653dd0f37a826c6aed5d33480299defc6/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ndarray/BaseNDArray.java#L3854
Equals method uses the NDArrayIndex iterator + getDouble operations.
This could easy be optimized: for example, that component of the equals method could become a native operation (pairwise reduce), ideally with a short-circuit condition to exit on the first non-equal element.

I'll just make it a native op.

Hypothetically it's implemented here: https://github.com/deeplearning4j/nd4j/pull/1112
But reduce3 has some issues itself, both on CUDA and CPU: https://github.com/deeplearning4j/nd4j/issues/1135
Some of them i've already fixed, but still not there yet.


Running on a Mac

Docker running, directory shared, changed to project directory, ran given command in Terminal and I get the message : Unable to find image 'waldekm/spfx:latest' locally

Closing due to lack of response.


Remaining wepoll items.

Meta issue tracking remaining work to do on the wepoll windows implementation. This description will be updated over time.
Original PR: #1034. Original issue #1024.

[ ] Dealing with WSAStartup, #1046.
[ ] benchmark new implementation vs. old.
[ ] ensure wepoll licensing requirements are met (copy license file).
[ ] document ownership of pointers being passed around the system.
[ ] ensure memory is not leaked on error here.
[ ] Ensure all old Windows related issues are fixed with the new implementation.
[ ] A SourceFd (EventedFd) equivalent for Windows.
[ ] Document interaction with RawSocket (do not read / write directly).

[ ] Ensure all old Windows related issues are fixed with the new implementation.

@Thomasdezeeuw I added your item to the OP. Do you have permission to edit the OP directly?

Yes, but didn't know that.

@Thomasdezeeuw no worries 👍

about memory leak on #1042

And we probably need to make a notice that the socket can NEVER be used in other place simultaneously with Mio. Because we simulated ET behavior by intercepting all operations that users could do.
If they use the socket in the place where Mio cannot observe (like RawSocket), the polling behavior will be undefined.

I would like to add: the current locking scheme is too granular.
It makes little sense to use separate locks for the update_queue and the iocp HANDLE; it's likely to hurt performance and introduce subtle bugs. One example I could find:
https://github.com/tokio-rs/mio/blob/211223e92865e5ae276333cc91673d764bbc386d/src/sys/windows/selector.rs#L368-L370
        self.update_sockets_events()?;

        self.active_poll_count.fetch_add(1, Ordering::SeqCst);

^-- By calling update_socket_events() before incrementing active_poll_count, it's possible that another thread doesn't call update_socket_events() (because it looks like there are no active polls) when it should (because there actually is another thread that's about to block).
This is just an example, which could be easily fixed by reversing the two operations. But in general I think it'd be better to use a single lock to protect both the completion port and the associated state. Then you release this lock just before calling GetQueuedCompletionStatusEx() and immediately acquire it again right after GetQueuedCompletionStatusEx() returns.
This might require integrating parts of miow into mio, which seems like a good idea either way.

I would like to add: the current locking scheme is too granular.
It makes little sense to use separate locks for the update_queue and the iocp HANDLE; it's likely to hurt performance and introduce subtle bugs. One example I could find:
https://github.com/tokio-rs/mio/blob/211223e92865e5ae276333cc91673d764bbc386d/src/sys/windows/selector.rs#L368-L370
        self.update_sockets_events()?;

        self.active_poll_count.fetch_add(1, Ordering::SeqCst);

^-- By calling update_socket_events() before incrementing active_poll_count, it's possible that another thread doesn't call update_socket_events() (because it looks like there are no active polls) when it should (because there actually is another thread that's about to block).
This is just an example, which could be easily fixed by reversing the two operations. But in general I think it'd be better to use a single lock to protect both the completion port and the associated state. Then you release this lock just before calling GetQueuedCompletionStatusEx() and immediately acquire it again right after GetQueuedCompletionStatusEx() returns.
This might require integrating parts of miow into mio, which seems like a good idea either way.

Is the pull #1055 making sense to you now?

@Thomasdezeeuw I'll start working on this issue, please assign it to me.

Update of what has been done so far: all items which are commented out are resolved.
//Dealing with WSAStartup, #1046. (solved in #1029)
benchmark new implementation vs. old. //TODO
ensure wepoll licensing requirements are met (copy license file). //TODO
document ownership of pointers being passed around the system. //TODO
ensure memory is not leaked on error here. //WIP
//Ensure all old Windows related issues are fixed with the new implementation.
A SourceFd (EventedFd) equivalent for Windows. //TODO
Document interaction with RawSocket (do not read / write directly). //TODO
Concurrent polling & registering, see #1053 .//TODO
Find source of possible polling delay, see #1051 (comment). //TODO
// Fix issues found by additional tests added in #1070:
// #1073.
#1074. - //WIP
// #1078.
// #1079.
// #1080.

//Dealing with WSAStartup, #1046. (solved in #1029)
//benchmark new implementation vs. old.  https://github.com/tokio-rs/tokio/issues/1918
//TODO: Mio will be benchmarked through Tokio. Will open a Tokio issue to create a benchmark.
//ensure wepoll licensing requirements are met (copy license file). #1188
//document ownership of pointers being passed around the system. #1185
//ensure memory is not leaked on error here. #1190
//Ensure all old Windows related issues are fixed with the new implementation.
// A SourceFd (EventedFd) equivalent for Windows. #1187
//Document interaction with RawSocket (do not read / write directly). #1186
//Concurrent polling & registering, see #1053 .
//Find source of possible polling delay, see #1051 (comment). #1189
// Fix issues found by additional tests added in #1070:
// #1073.
// #1074.
// #1078.
// #1079.
// #1080.

@Thomasdezeeuw this issue can be closed. All items have either been resolved or are tracked by other opened issues.


Component: Accordion

This is draft PR that will be used during a mob programming session.

Accordion was contributed by @SEBNori


Error output for runtime type errors is confusing

Steps to Reproduce
Run a program containing the follow (somewhat naive) code:
class MyHomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return new Scaffold(
        appBar: new AppBar(
          title: new Text('Type example'),
        ),
        body: new Column(
          children: buildContents(),
        ));
  }
}

List buildContents() {
  var l = new List();
  l.add(new Text('Text 1'));
  l.add(new Object()); // This could be any non-Widget added by mistake.
  l.add(new Text('Text 2'));
  return l;
}

This produces hundreds of lines of output:
Launching lib/main.dart on Android SDK built for x86 in debug mode...
Initializing gradle...                                       1.0s
Resolving dependencies...                                    0.8s
Running 'gradlew assembleDebug'...                           8.3s
Built build/app/outputs/apk/debug/app-debug.apk (30.4MB).
Installing build/app/outputs/apk/app.apk...                  1.6s
I/FlutterActivityDelegate( 6791): onResume setting current activity to this
I/flutter ( 6791): ══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
I/flutter ( 6791): The following assertion was thrown building MyHomePage(dirty):
I/flutter ( 6791): type 'List<dynamic>' is not a subtype of type 'List<Widget>' where
I/flutter ( 6791):   List is from dart:core
I/flutter ( 6791):   List is from dart:core
I/flutter ( 6791):   Widget is from package:flutter/src/widgets/framework.dart
I/flutter ( 6791):
I/flutter ( 6791): Either the assertion indicates an error in the framework itself, or we should provide substantially
I/flutter ( 6791): more information in this error message to help you determine and fix the underlying cause.
I/flutter ( 6791): In either case, please report this assertion by filing a bug on GitHub:
I/flutter ( 6791):   https://github.com/flutter/flutter/issues/new
I/flutter ( 6791):
I/flutter ( 6791): When the exception was thrown, this was the stack:
I/flutter ( 6791): #0      MyHomePage.build (file:///Users/mit/tmp/test45/lib/main.dart:41:21)
I/flutter ( 6791): #1      StatelessElement.build (package:flutter/src/widgets/framework.dart:3678:28)
I/flutter ( 6791): #2      ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3625:15)
...

Full details in: https://gist.github.com/mit-mit/2e59b8ccc73e1f8f9cc6f00374ef71fb
Specific issues:

It's hard to see where the error occurred. Can we mention main.dart:41:41 next to the typing error at the top?
Contains the somewhat scary message 'Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.'
Do we need all those lines of stack output? Seem like just the first line has any value for these cases?
Can we omit the 'EXCEPTION CAUGHT' and 'The following assertion was thrown' parts, and just say 'main.dart line 41 failed a runtime type check' or something simpler like that?

It's hard to see where the error occurred. Can we mention main.dart:41:41 next to the typing error at the top?

Usually, doing that would point the error at something useless like the source for _AssertionError or Object.noSuchMethod or some internal method of RenderObject or some such. It's rare that the exception is actually thrown from the exact line that has the problem.
We could special-case type errors if we had a way to recognize them, though I fear that would often result in us pointing the finger inside framework code.
This specific error is one I would have expected the analyzer to catch. You shouldn't ever see this exception if the code is analysis-clean as far as I can tell. If we could recognize this specific exception we could maybe suggest checking the analyzer first?

Contains the somewhat scary message

Why is that message scary? It was supposed to be reassuring, by telling people that it was probably not their fault, and that they should report it.

Do we need all those lines of stack output? Seem like just the first line has any value for these cases?

Fixing https://github.com/flutter/flutter/issues/4174 should improve that, but in the general case we don't know what the error is or whether the stack will be useful, so it's hard to know whether to include it or not. In this case, sure, the first line is the only one that matters. But that's very rarely the case. Often the stack is actually quite useful for diagnosing the issue.

Can we omit the 'EXCEPTION CAUGHT' and 'The following assertion was thrown' parts, and just say 'main.dart line 41 failed a runtime type check' or something simpler like that?

The purpose of those lines is to separate the output from the many other lines of output that are common when debugging (e.g. other exceptions). I think it's valuable to have the exception very well delineated. Can you elaborate on why the header is not simple? (It's not redundant; both of those lines contain information that varies from error to error.)

(The reason I would except the analyzer to catch it is because it's statically detectable. children expects a List<Widget>, so buildContents should have its return type inferred as List<Widget>, not List<dynamic>, IMHO. Then where the list is constructed, it should infer Widget as the type argument, and when you add the Object, the analyzer should say that doesn't work. Maybe the analyzer isn't yet that clever, though.)

Moving this one back to milestone 3; @a-siva promised to investigate yesterday.

I don't really understand what's wrong with the message. It seems great to me. It has lots of information and points you right to the cause.

As mentioned above, I think there are two usability issues. cc @InMatrix also in case he has opinions:
1) Unspecific error message.
As Siva mentioned, we know when we throw the TypeError what the exact reason is. But we don't state that, we show a generic framework assert.
And to make things words, we include this misleading bit:
I/flutter ( 6791): Either the assertion indicates an error in the framework itself, or we should provide substantially
I/flutter ( 6791): more information in this error message to help you determine and fix the underlying cause.
I/flutter ( 6791): In either case, please report this assertion by filing a bug on GitHub:
I/flutter ( 6791):   https://github.com/flutter/flutter/issues/new

2) Too much information
Yes, the message has lots of information, but that is not always a good thing. There are almost 250 lines of stack output, but it looks like just a single one (the first) has any relevance.

@mit-mit I agree with both issues you identified.
I'd like to collect issues related to unhelpful error messages for my incoming summer intern who's interested in improving them for Flutter. It looks like we don't have a label for error message-related issues. Should we create a label for this type of issue? Otherwise, I'll collect issues I'm aware of in a doc.

As Siva mentioned, we know when we throw the TypeError what the exact reason is. But we don't state that, we show a generic framework assert.

We should the exact message:

I/flutter ( 6791): type 'List<dynamic>' is not a subtype of type 'List<Widget>' where
I/flutter ( 6791):   List is from dart:core
I/flutter ( 6791):   List is from dart:core
I/flutter ( 6791):   Widget is from package:flutter/src/widgets/framework.dart

I don't understand what is missing?

Too much information

Yes, the message has lots of information, but that is not always a good thing. There are almost 250 lines of stack output, but it looks like just a single one (the first) has any relevance.

How do we know which line is relevant? See my comment above: https://github.com/flutter/flutter/issues/16260#issuecomment-379352186

I/flutter ( 6791): type 'List<dynamic>' is not a subtype of type 'List<Widget>' where
I/flutter ( 6791):   List is from dart:core
I/flutter ( 6791):   List is from dart:core
I/flutter ( 6791):   Widget is from package:flutter/src/widgets/framework.dart

I don't understand what is missing?

This part is Okay for this snippet, as long as there is only one List in question. If the user touched two List objects from the last known good state, the user then needs to check both until finding the problem.

Too much information

At lease in this case, the lines below the first 6 lines about type mismatch did not provide actionable information to the user. Showing them by default and all at once is overwhelming and can cause unnecessary anxiety. This also pushes the more relevant first few lines way up in the output window, and the user now needs to scroll back several screens to see them. A better experience might be showing more details only when the user requests to see more, similar to having a --verbose option in a command. In a modern IDE, we can also consider showing the first few lines of the stack trace and provide an UI affordance (e.g., ...) to expand the message.

At lease in this case

That's the key problem. We have no way to distinguish this case from the other (potentially more common) case I listed above.
I agree that IDEs should not scroll past these messages, but that seems like an IDE issue, rather than an issue with the framework?

That's the key problem. We have no way to distinguish this case from the other (potentially more common) case I listed above.

Maybe I misunderstood https://github.com/flutter/flutter/issues/16260#issuecomment-380973043, but from that it looks like type errors caught by Dart trigger a TypeError, so is it not just a matter of catching that?

Some thoughts:

re: IDE stacktrace collapsing

We do do this already in IntelliJ (however, depending on the stack trace prefix, we may not catch all places we should collapse).

re: the Either the assertion indicates an error in the framework itself... message

I'm not sure why we need this? As a user, this would be a confusing message to receive. We could just remove this and assume that the exception message and stacktrace will provide specific enough info to be actionable.

re: the repeated List is from dart:core, List is from dart:core messages

This is also confusing to me to see; it seems like it's trying to point out an issue, when  - after understanding it and re-reading it - it's clearer that there's no issue. I'm guessing that this is trying to de-dupe class with the same name but loaded from different libraries. I think to improve this we could remove all lines about which libraries the classes are from, unless there are classes with the same names form different libraries.

Maybe I misunderstood https://github.com/flutter/flutter/issues/16260#issuecomment-380973043, but from that it looks like type errors caught by Dart trigger a TypeError, so is it not just a matter of catching that?

I could be wrong but I believe the exception in https://github.com/flutter/flutter/issues/16260#issuecomment-379352186 is also a TypeError. This is the case where I'm saying we can't distinguish between this case and that case, and where different parts of the stack are important.
I suppose what we could do is filter out framework stack lines for TypeErrors? That might work pretty well. Should we update this bug to be specifically about doing that?
(Specifically, any sequence of stack lines that are from package:flutter or dart:* and are between two other lines that are also from package:flutter or dart:* would be either omitted or replaced by an ellipsis, unless some global debugDumpFullStacksInExceptions flag was set.)

re: the Either the assertion indicates an error in the framework itself... message

I'm not sure why we need this? As a user, this would be a confusing message to receive. We could just >remove this and assume that the exception message and stacktrace will provide specific enough info to >be actionable.

This message is included in any exception where we're not confident that the error is the user's fault. There are many exceptions (including TypeError exceptions) where the error is actually our fault, and we want the user to file a bug rather than bang their head against the framework.
What we could do is hide this message in the case where the top line in the stack is from non-framework code, though. That would make sense. Should we update this bug to be specifically about doing that?

re: the repeated List is from dart:core, List is from dart:core messages

The actual exception text comes from the compiler. I agree that it could be clearer. To have that changed we should probably file a bug on the Dart SDK.

What we could do is hide this message in the case where the top line in the stack is from non-framework code, though. That would make sense. Should we update this bug to be specifically about doing that?

I think minimizing the times the user sees the message would be great.

The actual exception text comes from the compiler. I agree that it could be clearer. To have that changed we should probably file a bug on the Dart SDK.

I'll file one and reference this issue.

Ok, I've updated this bug accordingly.
[ ] Filter stacks in Flutter so that any sequence of stack lines that are from package:flutter or dart:* and are between two other lines that are also from package:flutter or dart:* are either omitted or replaced by an ellipsis, unless some global debugDumpFullStacksInExceptions flag is set.
[ ] Hide the message saying this could be a framework bug if the first stack frame is not in the framework.

Moving out of bucket5 since there is no committed assignee; please don't hesitate to move these to a specific milestone if there is someone who is committed to working on it by that milestone.

I've split out the specifics into https://github.com/flutter/flutter/issues/18412 and https://github.com/flutter/flutter/issues/4174.


Deployment fails with node v18.18.0

See 3c5e0ab210da30efce3dc11095bd15358c7c5daa
Node v18.18.0 includes an update to npm 9.7.2:
https://github.com/nodejs/node/commit/4a6177daad59ec5bb4c29f10822d5a98655efe1a
That update removes the node-gyp executable. Without it, we get the following error when deploying the Heroku app:
Failed to auto-install node-gyp. Please run "yarn global add node-gyp" manually.

I'm not sure how do to the recommended step because this runs remotely in Heroku's servers (i.e. I don't think adding it as a step in the GitHub workflow will suffice).
For now, this has been worked around by limiting node to v18.17.1.

There is a very ominous note here: https://devcenter.heroku.com/articles/cli-style-guide#native-dependencies

Native dependencies
The Heroku CLI does not support native dependencies. They will break when we update the node version. Also, native dependencies typically require the use of node-gyp, which requires Python, and generally is likely to have problems compiling on all user environments, especially Windows.

I'm not sure how this can be true, as... like the entire ecosystem depends on this stuff.


Fix #107 + also check for station alternate names

Just pushed a fix to the development branch that fixes the currently broken station redirect (as per #107):
Functional again:
Something like: https://irail.be/route/Antwerpen/Mechelen
New: taking station alternate names in consideration!
The following should work too: https://irail.be/route/Antwerpen/Malines
@pietercolpaert: You should probably set debug to false on the deployed version as well, since https://irail.be/route/Antwerpen/Mechelen currently shows the debug page

Thanks! pulled on production!


Check for not passing nil to encoder

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Windows: OCI process struct and console size to uint

Signed-off-by: John Howard<EMAIL_ADDRESS>Convergence closer to OCI compliance - this modifies the Process struct definition in the hacked OCI spec used on Windows to match the existing structure from https://github.com/opencontainers/runtime-spec/blob/master/specs-go/config.go#L30-L54, but also adding the initialConsoleSize field which is required on Windows submitted to OCI as https://github.com/opencontainers/runtime-spec/pull/563.
As a result of https://github.com/opencontainers/runtime-spec/pull/563#r78852905, have changed the docker codebase to use uint instead of int for the console size throughout.
There is one further update which will be required (and simplify the code by no longer needing to cast from uint to int in the Windows libcontainerd files) after https://github.com/Microsoft/hcsshim/pull/67 is merged, and a revendor of https://github.com/Microsoft/hcsshim is done in docker.
There are no functional changes in the PR.

@mlaventure @tonistiigi @stevvooe PTAL. Thanks.

all green, merging

@jhowardmsft @mlaventure @tonistiigi @thaJeztah this commit broke backward compatibility - old users cannot post anymore an [2]int and get cannot unmarshal array into Go value of type container.Box. There should be some sort of backward compatibility

we should check API version for this https://github.com/docker/docker/commit/537744#diff-49c513a9f9836642d75d7f8478e8f521R316

@runcom, yes it was in one of my comment.
But, if I'm not mistaken, the Windows support is only going to be considered "stable" once Windows Server 2016 RTM is released.

Oh, damned. Just realized this is part of the common HostConfig struct :sweat:

Oh, damned. Just realized this is part of the common HostConfig struct

:) wanna take a peek at this? I'm going ahead and fix it if I can

Ugh. I can fix unless you have something already in progress @runcom?

Oh hang on, there's no need to fix this, unless it's broken Linux? Windows compatibility doesn't matter.

Oh hang on, there's no need to fix this, unless it's broken Linux? Windows compatibility doesn't matter.

@jhowardmsft it's broken on linux as well :( I'm trying to find some time to fix this tomorrow morning - buried into something

Don't worry - I'll fix shortly. Sorry for not thinking about that.


Global storage doesn't work on Windows

If I access it on windows, the value of 'context.globalStoragePath' will be:
\home\admin.local\share\code-server\globalStorage\vscodevim.vim
If I access it on linux, the value of 'context.globalStoragePath' will be:
/home/admin/.local/share/code-server/globalStorage/vscodevim.vim

The code-server always runs on linux, so when I access it with a windows browser, the path separator of 'context.globalStoragePath' is wrong

From https://github.com/cdr/code-server/issues/1551#issuecomment-691373522

The storage path needs to use the format of the remote host, not the client host. Or there needs to be some kind of conversion.


Add SOURCES.rst to document data sources being used

Signed-off-by: Shivam Sandbhor<EMAIL_ADDRESS>

Fixes https://github.com/nexB/vulnerablecode/issues/296

@sschuberth how is this for a start ? https://github.com/sbs2001/vulnerablecode/blob/document_sources/SOURCES.rst


Increase frequency of corona_data_collector

For now I assume that three times a day should suffice.
Also, if it is possible to add a method by which we can initiate a run (won't happen very often) that would be really useful too.

done, it runs daily at 2:00, 10:00, 18:00, 22:00
I added a Jenkins job that allows you to run manually, will send the details privately


Fix/markdown import to update asset links

Fix for: #1237
Loom: https://www.loom.com/share/5f101648d7dc46d59d9283267216ba1c

I notice in the loom video that in the imported note the path has a mix of back and forward slashes. Can we normalize to all forward / slashes?

This might be the case for windows only, should I replace all \ with '/' then?


Recording docs

I created pre-launch recording documentation for the business development team to share with interested parties: https://www.notion.so/livepeer/Recording-documentation-c7049315147842e39b3b2d3e5cc61e3f.
I still need to write a PR for the changes that will happen on livepeer.com/docs in both the guides and reference sections.

I created pre-launch recording documentation for the business development team to share with interested parties: https://www.notion.so/livepeer/Recording-documentation-c7049315147842e39b3b2d3e5cc61e3f.
I still need to write a PR for the changes that will happen on livepeer.com/docs in both the guides and reference sections.


Issue via pip install

New conda environment with
channels:
- pytorch
- conda-forge
- defaults
dependencies:
- python=3.8.6
- pip

Gives the following issue while running with pip install wildtime==1.1.3
Collecting pytorch-tabular==0.7.0 (from wildtime==1.1.3)
  Using cached pytorch_tabular-0.7.0.tar.gz (2.0 MB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [3 lines of output]
      error in pytorch_tabular setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; .* suffix can only be used with `==` or `!=` operators
          PyYAML>=5.1.*
                ~~~~~~^
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

+1


Do the builtin JQL functions work?

I have seen the following code:
    @Nonnull
    @Override
    public List<QueryLiteral> getValues(@Nonnull QueryCreationContext queryCreationContext, @Nonnull FunctionOperand functionOperand, @Nonnull TerminalClause terminalClause) {
        return ImmutableList.of();
    }

so it does not work, am i right?

Hi, they do work.
Function likely implements ClauseQueryFactory, which produces lucene query instead of QueryLiterals.
Keep in mind that build-in function names are prefixed with "my_".

Many useful JQL functions like "issuesInEpics" are implemented in the library. Is there a guiding for how to use it in Jira. Now I cannot use it in Jira advanced search.

What's the correct way to write the following JQL of issue in my_issuesInEpics("issue = LKRQ-3236")? It's no error but does not work in expectation.

@lifei you might need to re-index your Jira instance to use functions that are related to issue links (including epics and sub-tasks).

I have same experience. Jira was reindexed many times after we installed plugin. When i for example specify invalid link type:
issue in my_hasLinks("a") it correctly write "Unable to find link type with name "a"" on screen. But if i specify valid search, for example issue in my_hasLinks() or issue in my_hasComments() i get "No issues were found to match your search" everytime. Jira Core 7.13.0. Can you imagine the production Jira instance where there is no comment on any ticket? 😊

I think, I know what the issue is.
Can you try searching like “groovyFunction in ...” instead of “issue in ...”
Monday, 25 February 2019, 21:38 +0300 from<EMAIL_ADDRESS><EMAIL_ADDRESS>
I have same experience. Jira was reindexed many times after we installed plugin. When i for example specify invalid link type:
issue in my_hasLinks("a") it correctly write "Unable to find link type with name "a"" on screen. But if i specify valid search, for example issue in my_hasLinks() or issue in my_hasComments() i get "No issues were found to match your search" everytime. Jira Core 7.13.0. Can you imagine the production Jira instance where there is no comment on any ticket? 😊
—
You are receiving this because you commented.
Reply to this email directly,  view it on GitHub , or  mute the thread .

@lexek  It works like a charm! Thank you very much.

Thank you very much! I'll try it soon.


Simple Example

Hello sir,
I would like to ask you if you have any simple example of how to use this library. like switch ON and OFF of any pin of shift register.

Thank you, will be nice

Documentation was added in bfc9f387afa272f2fdbd6b780677add071996595. Please feel free to open another issue if you have any further questions.

Thank you for the good explanation, I have one question. in the note is written
For each additional shift register in the chain:
Connect the data chaining pin, labeled Q7’ or Q7’ Out on most 8 bit registers, of the current register to the Data pin of the next register in the chain.
Ground: Connect the GND pins on the shift register and Arduino.
What happen to the Latch Pin and SPI Clock Pin of the additional shift register, we leave those pins open or we connect them in parrallel with the same pins of first shift register? like in the image below

Your diagram is correct. You need to connect the latch and clock pins of all registers in the chain. I will clarify the documentation later.

hello Sir I get this error msg
c:\Users\Emugwaneza\Documents\Arduino\libraries\SPIShiftRegister\src\SpiShiftRegisterChain.cpp: In member function 'void SpiShiftRegisterChain::allocateMemory()':
c:\Users\Emugwaneza\Documents\Arduino\libraries\SPIShiftRegister\src\SpiShiftRegisterChain.cpp:78:34: error: no matching function for call to 'max(int, unsigned int&)'
78 |         _dataArray = new byte[max(4, _dataLengthBytes)];
|                               ~^~~~~~~~~~~~~~~~~~~
In file included from C:/Users/Emugwaneza/AppData/Local/Arduino15/packages/esp32/tools/esp-x32/2405/xtensa-esp-elf/include/c++/13.2.0/algorithm:61,
from C:\Users\Emugwaneza\AppData\Local\Arduino15\packages\esp32\hardware\esp32\3.1.0-RC1\cores\esp32/Arduino.h:188,
from c:\Users\Emugwaneza\Documents\Arduino\libraries\SPIShiftRegister\src\SpiShiftRegisterChain.h:5,
from c:\Users\Emugwaneza\Documents\Arduino\libraries\SPIShiftRegister\src\SpiShiftRegisterChain.cpp:1:
C:/Users/Emugwaneza/AppData/Local/Arduino15/packages/esp32/tools/esp-x32/2405/xtensa-esp-elf/include/c++/13.2.0/bits/stl_algo.h:5805:5: note: candidate: 'template<class _Tp, class _Compare> constexpr _Tp std::max(initializer_list<_Tp>, _Compare)'
5805 |     max(initializer_list<_Tp> __l, _Compare __comp)
|     ^~~
C:/Users/Emugwaneza/AppData/Local/Arduino15/packages/esp32/tools/esp-x32/2405/xtensa-esp-elf/include/c++/13.2.0/bits/stl_algo.h:5805:5: note:   template argument deduction/substitution failed:
c:\Users\Emugwaneza\Documents\Arduino\libraries\SPIShiftRegister\src\SpiShiftRegisterChain.cpp:78:34: note:   mismatched types 'std::initializer_list<_Tp>' and 'int'
78 |         _dataArray = new byte[max(4, _dataLengthBytes)];
|                               ~^~~~~~~~~~~~~~~~~~~
C:/Users/Emugwaneza/AppData/Local/Arduino15/packages/esp32/tools/esp-x32/2405/xtensa-esp-elf/include/c++/13.2.0/bits/stl_algo.h:5795:5: note: candidate: 'template constexpr _Tp std::max(initializer_list<_Tp>)'
5795 |     max(initializer_list<_Tp> __l)
|     ^~~
C:/Users/Emugwaneza/AppData/Local/Arduino15/packages/esp32/tools/esp-x32/2405/xtensa-esp-elf/include/c++/13.2.0/bits/stl_algo.h:5795:5: note:   template argument deduction/substitution failed:
c:\Users\Emugwaneza\Documents\Arduino\libraries\SPIShiftRegister\src\SpiShiftRegisterChain.cpp:78:34: note:   mismatched types 'std::initializer_list<_Tp>' and 'int'
78 |         _dataArray = new byte[max(4, _dataLengthBytes)];
|                               ~^~~~~~~~~~~~~~~~~~~
In file included from C:/Users/Emugwaneza/AppData/Local/Arduino15/packages/esp32/tools/esp-x32/2405/xtensa-esp-elf/include/c++/13.2.0/bits/specfun.h:43,
from C:/Users/Emugwaneza/AppData/Local/Arduino15/packages/esp32/tools/esp-x32/2405/xtensa-esp-elf/include/c++/13.2.0/cmath:3699,
from C:/Users/Emugwaneza/AppData/Local/Arduino15/packages/esp32/tools/esp-x32/2405/xtensa-esp-elf/include/c++/13.2.0/math.h:36,
from C:\Users\Emugwaneza\AppData\Local\Arduino15\packages\esp32\hardware\esp32\3.1.0-RC1\cores\esp32/esp32-hal.h:30,
from C:\Users\Emugwaneza\AppData\Local\Arduino15\packages\esp32\hardware\esp32\3.1.0-RC1\cores\esp32/Arduino.h:36:
C:/Users/Emugwaneza/AppData/Local/Arduino15/packages/esp32/tools/esp-x32/2405/xtensa-esp-elf/include/c++/13.2.0/bits/stl_algobase.h:303:5: note: candidate: 'template<class _Tp, class _Compare> constexpr const _Tp& std::max(const _Tp&, const _Tp&, _Compare)'
303 |     max(const _Tp& __a, const _Tp& __b, _Compare __comp)
|     ^~~
C:/Users/Emugwaneza/AppData/Local/Arduino15/packages/esp32/tools/esp-x32/2405/xtensa-esp-elf/include/c++/13.2.0/bits/stl_algobase.h:303:5: note:   template argument deduction/substitution failed:
c:\Users\Emugwaneza\Documents\Arduino\libraries\SPIShiftRegister\src\SpiShiftRegisterChain.cpp:78:34: note:   deduced conflicting types for parameter 'const _Tp' ('int' and 'unsigned int')
78 |         _dataArray = new byte[max(4, _dataLengthBytes)];
|                               ~^~~~~~~~~~~~~~~~~~~
C:/Users/Emugwaneza/AppData/Local/Arduino15/packages/esp32/tools/esp-x32/2405/xtensa-esp-elf/include/c++/13.2.0/bits/stl_algobase.h:257:5: note: candidate: 'template constexpr const _Tp& std::max(const _Tp&, const _Tp&)'
257 |     max(const _Tp& __a, const _Tp& __b)
|     ^~~
C:/Users/Emugwaneza/AppData/Local/Arduino15/packages/esp32/tools/esp-x32/2405/xtensa-esp-elf/include/c++/13.2.0/bits/stl_algobase.h:257:5: note:   template argument deduction/substitution failed:
c:\Users\Emugwaneza\Documents\Arduino\libraries\SPIShiftRegister\src\SpiShiftRegisterChain.cpp:78:34: note:   deduced conflicting types for parameter 'const _Tp' ('int' and 'unsigned int')
78 |         _dataArray = new byte[max(4, _dataLengthBytes)];
|                               ~^~~~~~~~~~~~~~~~~~~
exit status 1
Compilation error: exit status 1

I think I see where this is coming from, but I cannot reproduce it. Can you provide me with a small bit of code that should show the error?
My test code looks like this and compiles fine. Let me know if it does not for you:
#include <SpiShiftRegisterChain.h>

SpiShiftRegisterChain chain(3,2);

void setup() {}

void loop() {
  chain.toggleBit(3);
  delay(1000);
}

Once I can reproduce the error on my end it should be an easy fix.

I used this example
#include <SPI.h>
#include <SpiShiftRegisterChain.h>
const int latchPin = 10;
const int dataLengthBytes = 4;
SpiShiftRegisterChain shiftRegister(latchPin, dataLengthBytes);
void setup() {
SPI.begin();
shiftRegister.setBitOn(0);    // Turn on the 1st bit and write data
shiftRegister.setBitOff(1, false);   // Turn off the 2nd bit without writing
shiftRegister.writeData();    // Apply all changes at once
delay(1000);
shiftRegister.toggleBit(0);   // Toggle the 1st bit and write data
delay(1000);
}
void loop() {
// Your main code here
}

Interesting, that also compiles fine on my machine. I think you may just have stricter compiler settings about automatic type conversion than I do. I can work on a fix but I'll need you to check it since I cannot reproduce. It might not be up before Monday though.

I use ESP32S3 board not arduino AVR board
that is the reason it gives me the error.
I think it is only compatible with arduino avr board only

I was able to reproduce the issue by compiling for ESP32. I have not used that board but based on my research the code should still work. I created a new release 671de19f104f097b233b8d49783f8d3f22e6ab6d that should fix the compiler error you were getting. Let me know if this works.

The compiler error is fixed but the the example is not working how it supposed to work on esp32.
if you have esp32 board try to run this code
#include <SPI.h>
#include <SpiShiftRegisterChain.h>
const int latchPin = 10;
const int dataLengthBytes = 4;
SpiShiftRegisterChain shiftRegister(latchPin, dataLengthBytes);
void setup() {
SPI.begin();
shiftRegister.setBitOn(0); // Turn on the 1st bit and write data
shiftRegister.setBitOff(1, false); // Turn off the 2nd bit without writing
shiftRegister.writeData(); // Apply all changes at once
delay(1000);
shiftRegister.toggleBit(0); // Toggle the 1st bit and write data
delay(1000);
}
void loop() {
// Your main code here
}

I don't have an ESP32 to test on but I was able to look up some info and it should be compatible as is. Did you try running on an Arduino to make sure your shift register setup is correct? On ESP32 will need to use the VSPI pins. I'll get an ESP32 and see how it goes.

yes shift register setup is correct, for me I use esp32s3 board, I don't know if it use VSPI pins as ESP32

I have acquired an ESP32 S3 dev board and confirmed that the library works with it. I ran the example above and it works. However all that example does is set bit 0 (i.e. the first bit of the first chained register) to high and the rest to low. It may be useful to try a continuously changing output to see it in action. You can set the loop function to something like this:
void loop() {
    shiftRegister.toggleBit(0);
    shiftRegister.toggleBit(3);
    delay(1000);
}

This will change the state of bits 0 and 3, as counted from the first output of the first chained register, every second.
Here is my wiring diagram. Make sure you use the same pins, or whichever pins are VSPI on your module.

I'm using the same diagram and I use latchPin =10 in the code.
for example I want to switch on bit 3
#include <SpiShiftRegisterChain.h>

const int latchPin = 10;
const int dataLengthBytes = 3;

SpiShiftRegisterChain shiftRegister(latchPin, dataLengthBytes);

void setup() {
SPI.begin();

}

void loop() {

   // shiftRegister.setBitOn(3, true);
    shiftRegister.toggleBit(3);
}```

I don' t know why nothing happen on the bit 3

When I try to use
```#include <SPI.h>
#include <SpiShiftRegisterChain.h>

const int latchPin = 10;
const int dataLengthBytes = 3;

SpiShiftRegisterChain shiftRegister(latchPin, dataLengthBytes);

void setup() {
SPI.begin();

}

void loop() {
  shiftRegister.toggleBit(0);
    shiftRegister.toggleBit(3);
    delay(1000);
}```
 I think this should blink bit 0 and bit 3, but it is mixing blinking from bit 0 to bit 23 and OFF.

The set up is ok, it is working with other shift register library


What is "conv2alg.txt" for ?

Hi,
I got an interesting problem, though solved, i am still curious about the usage of "conv2alg.txt".
And I reproduce it with an example.
import ios
import numpy as np

graph=ios.models.nasnet_large()
graph.sequential_schedule()

seq = 0
for i in range(10):
  latency = ios.ios_runtime.graph_latency(graph, batch_size=1, repeat=6)
  print(f' Sequential schedule: {np.mean(latency):.3f} ms')

The story is that I first run the above code, "test.py" on a PC with a GTX1060. Then, I copy the "test.py" and "conv2alg.txt" to another PC with a RTX3080. When I run the code on the latter PC, amazing things happen. The output inference latency is very high (around 40ms), which is obviously not correct. After trying everything, I remove "conv2alg.txt" and problem solved (the output latency changes to around 17ms which is the same as the latency I have saw before).
I checked the repo and it seems "conv2alg.txt" has something to do with ios runtime, but I am not sure. Would you please tell me what's happening here? THX!

Hi @ikaroso,
What you observed is expected. The 'conv2alg.txt' file contains the mapping from the convolution key (nchw, kernel size, strides, padding) to the algorithms used by cudnn.
When we first run IOS, we will benchmark and choose the best algorithm for each convolution configuration, and store the mapping in the file. In subsequent runs, the file will be used instead of re-benchmarking for stability.
When you use one cache on another gpu, the algorithm might not be the best choice on that gpu, thus the performance would drop.

Hi @yaoyaoding ,
Yeah, thx for your reply and it makes sense.  I still got a lot to learn.
Thank you very much.


fix linting in Go 1.19 (for release-4.12)

@eranra yes, this will pass in release-4.12 when this PR is also merged: https://github.com/netobserv/flowlogs-pipeline/pull/342


Bleach brave soul

Pls i need extract charects is game, pls android extract for unity

Hello, I want to help with my feedback.
There is a bleach game for android your program presents files in .byte format, but we can not visualize, is there any forecast so we can extract the models and textures from this game?

First, I only understand your last sentence.
I won't help anyone solve the problem caused by encryption.


Getting error "Cannot read property 'listen' of undefined at TransitionAnimationEngine.listen"

Hi, I'm getting this error when calling tour service start method
I'm initializing the service in a lazy loaded module with anchors located in other modules like this
this.tourService.initialize([
      {
        anchorId: 'vehicle.start',
        content: 'Some content',
        title: 'First',
        route: '/resources/vehicle/new'

      },
      {
        anchorId: 'worker.start',
        content: 'Other content',
        title: 'Second',
        route: '/resources/manpower/new'

      },
      {
        anchorId: 'job.start',
        content: 'Other content',
        title: 'Third',
        route: '/jobs/new'

      }
    ]);

I've also subscribed to the events$ observable on the service which fired a "start" event and three "anchorRegister" events as expected.
This is the complete error I get
ERROR TypeError: Cannot read property 'listen' of undefined
at TransitionAnimationEngine.listen (browser.js:4251)
at InjectableAnimationEngine.AnimationEngine.listen (browser.js:5626)
at AnimationRenderer.listen (animations.js:720)
at DebugRenderer2.listen (core.js:15428)
at listenToElementOutputs (core.js:10571)
at createViewNodes (core.js:13704)
at createEmbeddedView (core.js:13614)
at callWithDebugContext (core.js:15051)
at Object.debugCreateEmbeddedView [as createEmbeddedView] (core.js:14363)
at TemplateRef_.createEmbeddedView (core.js:11689)

Try updating all the @angular packages to the latest version.  (At the minimum they all need to be the same version.)  Except for @angular/cdk and @angular/material which need to match each other, but aren't in sync with the other @angular packages.
You can do this automatically from the command line by running npm update in the project directory.

I ran an npm update and I still have the same issue. right now I'm using these versions
    @angular/cdk: "^5.2.4",
    @angular/core": "^5.2.9",

Are you using @angular/animations in any other parts of your app?  i.e. using another ui library like material that leverages the animations?
The error seems to be coming from the animations library, but I've never seen it before and I'm not sure what could be causing it.  The problem might be in how you are importing the various modules.

There is a library for toasts  angular2-notifications that I'm importing in the root module that depends on animations.
Here is my root module imports
 imports: [
    BrowserModule,
    BrowserAnimationsModule,
    SharedModule.forRoot(),
    SimpleNotificationsModule.forRoot(),
    TourMatMenuModule.forRoot()
  ]

I'm sorry, I'm out of ideas.  Those imports look right.

Thanks @isaacplmann, I've found the solution for this issue. The problem was that I didn't  include the <tour-step-template></tour-step-template> in the component I'm routing to. The error was really misleading.

Thanks @isaacplmann, I've found the solution for this issue. The problem was that I didn't include the <tour-step-template></tour-step-template> in the component I'm routing to. The error was really misleading.

You are right @islam56naser. It works. :)

For anyone still facing this issue the important part is that include the <tour-step-template></tour-step-template> in the lazy module component. The documentation just suggests that it is only needed in the app.component.ts


chore: reuse the stack code from react navigation 5

The code for the stack is almost the same as v5, with the only differences being the types and the navigation object. To avoid making same changes in 2 places which error-prone, I decided to reuse the same code. Due to the differences, it's not possible to just use it as a dependency, so I followed this approach:

Copy the source files on post install and apply patches to make it work with React Navigation 4
When we need to make changes, we can make them in v5 repo and update the version here, most of the time it wouldn't need any extra work
If we need to make v4 specific changes, we can change the code in vendor/ and then re-generate the patch with yarn patch

Can you give me some clues about how can I review this?

This approach appears to be super confusing. Is that copying changes across repos that bad?


E5108: Error executing lua vim/_editor.lua:341:

Describe the bug
When nvim starts i get this error message:
Error detected while processing LspAttach Autocommands for "":
E5108: Error executing lua vim/_editor.lua:341: LspAttach Autocommands for ""..s
cript nvim_exec2() called at LspAttach Autocommands for "":0: Vim(echomsg):E114:
Missing quote: "Error in packer_compiled: ...m/site/pack/packer/start/packer.nvi
m/lua/packer/load.lua:118: LspAttach Autocommands for ""..LspAttach Autocomman
ds for "*": Vim(append):Error executing lua callback: ...pack/packer/opt/lspsag
a.nvim/lua/lspsaga/symbol/init.lua:199: attempt to index field 'data' (a nil valu
e)
stack traceback:
[C]: in function 'nvim_exec2'
vim/_editor.lua:341: in function 'cmd'
...m/site/pack/packer/start/packer.nvim/lua/packer/load.lua:179: in funct
ion <...m/site/pack/packer/start/packer.nvim/lua/packer/load.lua:175>
[string ":lua"]:1: in main chunk
[C]: in function 'nvim_exec_autocmds'
.../com.termux/files/usr/share/nvim/runtime/lua/vim/lsp.lua:1531: in func
tion '_on_attach'
.../com.termux/files/usr/share/nvim/runtime/lua/vim/lsp.lua:1358: in func
tion 'cb'
vim/_editor.lua:263: in function <vim/_editor.lua:262>
I did nit change anything and it work correctly before. I have LspSaga installed with
packer and this config:
use ({
'nvimdev/lspsaga.nvim',
after = 'nvim-lspconfig',
config = function()
require('lspsaga').setup({
lightbulb = { enable = false, },
})
end,
})
Steps to reproduce
nvim
Expected behavior
i expect nvim to start without error messages
Neovim version (nvim -v)
NVIM v0.9.0 Build type: Release LuaJIT 2.1.0-beta3
lspsaga commit
what do you expect me to put in this field?
Terminal name/version
termux

packer issue with lazy load by using event = 'LspAttach use other event or after instead of

Hi Raphael,Thanks for your response.1. I use packer not lazy2. i used 'after = 'nvim-lspconfig' '3. I changed it to: requires =  "neovim/nvim-lspconfig"The problem continues...Regards,FrankPS why did you remove the documentation out of the github repo? It is a pain for people without a internet connection.-------- Original message --------From: Raphael @.>Date: Sat, Jul 29, 2023, 01:58To: "nvimdev/lspsaga.nvim" @.>Cc: Frank Laranja @.>, Author @.>Subject: Re: [nvimdev/lspsaga.nvim] E5108: Error executing lua vim/_editor.lua:341: (Issue #1216)
packer issue with lazy load by using event = 'LspAttach use other event or after instead of
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

it's packer issue . so use after event like BufReadPost .when you do edit conig file you need PackerCompile to make it take effect.

that suggestion doesn't work either :(-------- Original message --------From: Raphael @.>Date: Tue, Aug 1, 2023, 07:24To: "nvimdev/lspsaga.nvim" @.>Cc: Frank Laranja @.>, Author @.>Subject: Re: [nvimdev/lspsaga.nvim] E5108: Error executing lua vim/_editor.lua:341: (Issue #1216)
it's packer issue . so use after event like BufReadPost .when you do edit conig file you need PackerCompile to make it take effect.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


print 'Sending %d bytes' % len(bytes) invalid syntax

I tried running your application blocking-server/slowpoetry.py with python 3.4 but when I execute:
python blocking-server/slowpoetry.py poetry/ecstasy.txt
it says invalid syntax on line 62 but when I checked I think it's correct. maybe python version difference? It would really help if you would also create similar program for python3 as well?

It must be yes, I never tried running this under Python 3.

The Python 3 equivalent would be print('Sending {0:d} bytes'.format(len(bytes))) but porting to Python 3 is probably going to require a lot more than that.


Accern data

Added Accern.cs file to read the accern news data from the data folder into a Accern object
Added the AccernDataSplitter project to split the huge accern data gzip files into small chucks of indicidual months
Would be happy to make any suggested changes.

Closing for now lets review when higher priority or PR submitted by Accern.


Carthage build failing for Xcode 8 beta 2

Cartfile: github "soffes/Crypto" "swift3"
Build Error:
** BUILD FAILED **

The following build commands failed:
	Ld .../Library/Developer/Xcode/DerivedData/Crypto-eedcgimieppepedcolqgjjntalol/Build/Products/Release-appletvos/Crypto.framework/Crypto normal arm64
(1 failure)
.../Carthage/Checkouts/Crypto/Crypto/String+Crypto.swift:65:73: warning: missing '.self' for reference to metatype of type 'UInt8'
/Users/davidkeegan/Development/Library/KGNCache/Carthage/Checkouts/Crypto/Crypto/String+Crypto.swift:65:73: warning: missing '.self' for reference to metatype of type 'UInt8'
.../Carthage/Checkouts/Crypto/Crypto/String+Crypto.swift:65:73: warning: missing '.self' for reference to metatype of type 'UInt8'
.../Carthage/Checkouts/Crypto/Crypto/String+Crypto.swift:65:73: warning: missing '.self' for reference to metatype of type 'UInt8'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
A shell task (/usr/bin/xcrun xcodebuild -project .../Carthage/Checkouts/Crypto/Crypto.xcodeproj -scheme Crypto-tvOS -configuration Release -sdk appletvos ONLY_ACTIVE_ARCH=NO BITCODE_GENERATION_MODE=bitcode CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES clean build) failed with exit code 65:
** BUILD FAILED **

The following build commands failed:
	Ld .../Library/Developer/Xcode/DerivedData/Crypto-eedcgimieppepedcolqgjjntalol/Build/Products/Release-appletvos/Crypto.framework/Crypto normal arm64
(1 failure)

Hmm, it seems to be building for me now...

Back again, seems to be an issue when the repos are nested.

Just noticed the issue seems to be with Release-appletvos, if I just build --platform iOS then I can build it.

Looks like this may be a dup of #18

I updated Crypto for Xcode 8b6


Swap order of operands for std::mem::copy

https://github.com/FuelLabs/sway/blob/850e0de4434d412f458692760fd0de019ed03687/sway-lib-std/src/mem.sw#L18
Rust's std::ptr::copy uses source then dest, instead of the more C-link dest then source. https://doc.rust-lang.org/std/ptr/fn.copy.html

cc @otrho @AlicanC

I'm all for following Rust here which was always my intention. I probably just missed this.
I can make the change if there are no objections.

Note: This was initially an intrinsic so I was copying std::intrinsics::copy, but that's src-first too: https://doc.rust-lang.org/std/intrinsics/fn.copy.html


Extract gzip header into a crate? Maybe other metadata?

In my zopfli implementation, it would be useful to have your gzip into_header and do_finish footer) code, but without the actual compression logic. The C implementation of zopfli was actually kind of lazy and doesn't set the mtime or OS codes in the gzip header, so that adds weight in my mind that a crate would be useful for people who don't want to implement it themselves!
Mostly opening this to get your opinion-- do you think it'd be worthwhile to extract this into a separate crate, and would you accept a PR that used that crate in this library?

Maybe some of the other formats' metadata generation too, but I'm not as familiar with those.

Yeah I'd be fine to extract this out to a separate type in the module at the very least, and perhaps yeah another crate. This may also end up interacting with https://github.com/alexcrichton/flate2-rs/pull/43 as well!

I've started a crate here based on the code in flate2 as I needed it for the deflate crate. I don't know if it's usable for flate2 due to the extra dependency on crc-32 (as depending on miniz/zlib for crc functionality wouldn't make sense), though it may be of interest for other crates.
Also let me know if there is anything lacking when it comes to attribution, not sure if what's there right now is sufficient.

Thanks for the update @oyvindln! I may not update flate2 just yet due to the extra deps, but it may be of interest to @carols10cents

A small update:
The dependencies for gzip-header are now cleaned up. I avoided enum-primitive as it wasn't really needed, so crc is the only dependency now. The latest version of the crc crate have also removed the dependency on lazy_static and only depends on build_const and the internal crc-core crate.

I can confirm it would be very nice to export a method to render the gzip header and the CRC writing when you have to use the Compress struct. I have seen the crate mentioned above but it really is a matter of a couple lines of change to make it nice and then whether it is coming flate2 directly or is re-exported is not really important.
Namely GzBuilder::into_header is currently private and there is no other way to generate a header currently? Any reason this has to be private? You can hardcode the header if you need but it would be nice to have this public.
Another thing is the code writing the CRC bytes from https://github.com/alexcrichton/flate2-rs/blob/master/src/gz/write.rs#L99-L114 . Could the byte slice creation be a public method of the Crc struct instead?
I can do a PR for both if that's acceptable

The current interface hasn't ever been designed to be exposed, it's just grown organically over time. Given a once-over to make sure it's feasible to expose publicly it seems plausible to expose it.


Update maintainers.md for xDnsServer

Pull Request (PR) description
Adds @indented-automation to maintainer list for xDnsServer
This Pull Request (PR) fixes the following issues
N/A
Task list

[x] This PR changes documentation

This change is

@gaelcolas Can you merge this one and give @indented-automation permission?


Unable to get Knip to respect tsconfig compilerOptions.paths

After extensive testing and reading through Knip's documentation, I have been unable to find any more than a workaround for the following issue. In checking to see if this issue has been reported before, the closest I could find was https://github.com/webpro/knip/issues/388, but that seems to be a bit different. Apologies if there was another report that I missed.
I haven't managed to create a minimal reproduction, but please let me know if that would be necessary here. Unfortunately I'm unable to link to the source files as this is a company project.

My project consists of three workspaces:

root, which contains the Knip config and the other two workspaces.
workspace-1, which contains several exports used by both workspace-1 and workspace-2.
workspace-2, which uses some exports from workspace-1, but which shares none of its own exports with other workspaces.

Here is a simplified representation of the folder structure:
root
├── workspace-1
│   ├── src
│   │   ├── entry-1.tsx
│   │   ├── foo.tsx
│   │   └── shared
│   │       └── bar.ts
│   └── package.json
├── workspace-2
│   ├── src
│   │   ├── entry-2.tsx
│   │   └── baz.ts
│   ├── package.json
│   └── tsconfig.json
├── knip.ts
└── package.json

workspace-2 uses exports from workspace-1 by way of the following config in workspace-2/tsconfig.json:
{
  "include": ["src"],
  "compilerOptions": {
    "baseUrl": "src",
    "paths": {
      "*": ["../../workspace-1/src/*"]
    }
  }
}

workspace-1/src/shared/bar.ts contains an enum like the following:
export enum Plants {
  TREE = "tree",
  BUSH = "bush",
  FLOWER = "flower",
}

The exported Plants enum is imported in both workspaces:

workspace-1/src/foo.tsx imports the Plants enum and uses it as a type but does not access any of the enum members.
workspace-2/src/baz.ts imports the Plants enum and accesses all of the enum members.

When I run Knip, the Plants enum members get reported as unused:
><EMAIL_ADDRESS>knip /file/path/root
> knip

Unused exported enum members (3)
TREE    Plants  workspace-1/src/shared/bar.ts
BUSH    Plants  workspace-1/src/shared/bar.ts
FLOWER  Plants  workspace-1/src/shared/bar.ts
 ELIFECYCLE  Command failed with exit code 9.

Is there any way to configure Knip to respect the compilerOptions.paths setting in workspace-2/tsconfig.json so that the enum members aren't reported as unused?
I have scoured the Knip docs and tried every seemingly related suggestion I could find, including the suggestion to not explicitly set compilerOptions.baseUrl, to no avail. The only suggestion that has actually silenced the report is prepending the exported enum with /** @public */, but that feels like more of a workaround than a solution.
Apologies for the long post. If I can provide clarification, please just let me know. Thank you!

Apologies for the time lost, I need to document this. You're not the first to face this strictness of Knip, and it's indeed not clear what's off.
My guess is that workspace-1 doesn't have workspace-2 listed as a dependency in package.json (and/or vice versa). The setup you're explaining works in both realms of TypeScript and the package manager separately. Yet when it comes together in Knip, it's (currently) more restrictive in the sense that internal workspaces should be listed in package.json, and the import specifiers should use those package names (and not rely on TS path aliases to cross workspace boundaries).
Overall, I'm inclined to think path aliases shouldn't be used to cross workspace boundaries. Happy to hear counter arguments.

Thank you for the quick feedback, and no problem.
You are indeed correct that the workspace dependency is configured in tsconfig.json only, not in package.json. I have now tested:

Adding the dependency relationship to package.json in workspace-1 and workspace-2 (both individually and together).
Replacing the TS path alias with the package name in the import specifier in workspace-2/src/baz.ts (where Plants is being imported).

TypeScript seems pleased with these changes, but I'm afraid that the output from Knip remains the same.
It seems clear to me now that we would need a minimal reproduction in order to investigate further. I think it is unlikely I'll find that time to prepare that anytime soon, but if I'm wrong then I'll come back with an update.
No problem to close this issue so it doesn't hang around open in your queue.

Just to be sure:

Did you re-install dependencies? So the symlinks are there in node_modules.
Maybe try without the * in compilerOptions.paths?

We can leave this open until I've documented it somewhere.

Did you re-install dependencies? So the symlinks are there in node_modules.

Yes, I reinstalled dependencies after adding the workspace dependency configuration to package.json.

Maybe try without the * in compilerOptions.paths?

Oh, I'm glad you asked. I just tried this, and the result is not what I expected.
When I remove the * line from compilerOptions.paths and then run Knip, the output includes a long list of "Unlisted dependencies" that doesn't appear when the * line is present. This change in output suggests that actually Knip has been respecting the tsconfig compilerOptions.paths all along.
It seems there is something about enums, or about the specific enum in my project, that causes the enum members to be reported as unused despite the workspace dependency configuration that otherwise seems to function as expected.

Maybe try without the * in compilerOptions.paths?

Oh, I'm glad you asked. I just tried this, and the result is not what I expected.
When I remove the * line from compilerOptions.paths and then run Knip, the output includes a long list of "Unlisted dependencies" that doesn't appear when the * line is present. This change in output suggests that actually Knip has been respecting the tsconfig compilerOptions.paths all along.

There's two notes I should make here:

For module resolution, the compilerOptions.paths are required. I made this suggestion for you to verify whether it would help with the original issue. But it would mess up everything else relying on those paths. Should've added that right away.
later in the process, after the module resolution is done and dependency graph is created, Knip assigns unused things to workspaces, based on workspace package.json#name and package.json#[dev]dependencies, which it is currently unable to do in your situation, because of this.

It seems there is something about enums, or about the specific enum in my project, that causes the enum members to be reported as unused despite the workspace dependency configuration that otherwise seems to function as expected.

Based on the above, I don't think enums are the issues here.

For module resolution, the compilerOptions.paths are required. I made this suggestion for you to verify whether it would help with the original issue. But it would mess up everything else relying on those paths. Should've added that right away.

Ah I see, makes sense. I think we have been able to confirm that modifying compilerOptions.paths had no effect on the original issue, so good thing we tried that.

later in the process, after the module resolution is done and dependency graph is created, Knip assigns unused things to workspaces, based on workspace package.json#name and package.json#[dev]dependencies, which it is currently unable to do in your situation, because of this.

Well, following your advice, I have added the workspace dependency to package.json and have modified the enum's import specifier to use the package name instead of the TS path alias. With these two changes in place, I have tested running Knip both with compilerOptions.paths in its original state and with compilerOptions.paths modified as discussed in point 1. In all cases the report from Knip indicates the enum members as unused.
If I ever manage to put together a minimal reproduction, then I'll be sure to let you know.

Closing this. Feel free to open a new issue with a minimal reproduction.
Related/potential fix: #611


Issue 13327 - Clarify manifest constant grammar

https://issues.dlang.org/show_bug.cgi?id=13327
This also fixes a DDOC macro usage issue introduced by https://github.com/D-Programming-Language/dlang.org/pull/775/

I would just make "can be omitted" link to AutoDeclaration.

LGTM, but looks like it needs a rebase.

Rebased.


Remove broken PyPI package

https://pypi.python.org/pypi/Logentries/0.2 is broken
It hosts a LogentriesLogger==0.2.1 package instead of the expected logentries package
Which is available at the apparantly canonical https://pypi.python.org/pypi/LogentriesLogger/ location.

Should be fixed now.

can you create another package at LogentriesLogger that depends on Logentries?
Maybe with the readme with a big "moved!" url?

Yeah sounds like a good idea. Iv created an issue on github and mentioned
you about the issue
On Tue, Feb 24, 2015 at 4:54 PM, Thomas Grainger<EMAIL_ADDRESS>wrote:

can you create another package at LogentriesLogger that depends on
Logentries?
Maybe with the readme with a big "moved!" url?
—
Reply to this email directly or view it on GitHub
https://github.com/logentries/le_python/issues/20#issuecomment-75795458.


Fixes/node configuration warning dialog text

This PR fixes issue #94145 Incorrect text in the Node Configuration Warning dialog

The translation files should not be modified, the translations will be updated on Weblate.

Oh, thank you, @KoBeWi!

You'll need to squash the commits into 1.

Got it. Thank you!

You'll need to squash the commits into 1.

✅ git rebase to a single commit is done.

Thanks! And congrats for your first merged Godot contribution :tada:

Thanks! And congrats for your first merged Godot contribution 🎉

Great! :)
That was a pleasure :)
GODOT is awesome! 👏


Fix HeaderExchangeChannel close potential bug

Fix HeaderExchangeChannel close potential bug
'channel != null' must be satisfied, simplify hashCode and equals

What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[ ] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #11834 (a227b25) into 3.2 (96dfd20) will decrease coverage by 2.63%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #11834      +/-   ##
============================================
- Coverage     69.14%   66.52%   -2.63%
+ Complexity      339        2     -337
============================================
  Files          3277     1665    -1612
  Lines        153764    66580   -87184
  Branches      25654     9559   -16095
============================================
- Hits         106324    44294   -62030
+ Misses        38052    17983   -20069
+ Partials       9388     4303    -5085

see 1892 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Example program binary crashes qemu with "qemu: fatal: Lockup: can't escalate 3 to HardFault (current priority -1)"

The following example compiles just fine on win 10 with latest stable rust distribution:

#![no_main]
#![no_std]

use panic_halt as _;

use cortex_m_rt::entry;
use cortex_m_semihosting::{debug, hprintln};

#[entry]
fn main() -> ! {
    hprintln!("Hello, world!").unwrap();

    // exit QEMU
    // NOTE do not run this on hardware; it can corrupt OpenOCD state
    debug::exit(debug::EXIT_SUCCESS);

    loop {}
}

but gives the following error when run:
Running `qemu-system-arm -cpu cortex-m3 -machine lm3s6965evb -nographic -semihosting-config enable=on,target=native -gdb tcp::3333 -S -kernel target\thumbv7m-none-eabi\debug\app`
Timer with period zero, disabling
qemu: fatal: Lockup: can't escalate 3 to HardFault (current priority -1)

R00=00000000 R01=00000000 R02=00000000 R03=00000000
R04=00000000 R05=00000000 R06=00000000 R07=00000000
R08=00000000 R09=00000000 R10=00000000 R11=00000000
R12=00000000 R13=ffffffe0 R14=fffffff9 R15=00000000
XPSR=40000003 -Z-- A handler
FPSCR: 00000000
error: process didn't exit successfully: `qemu-system-arm -cpu cortex-m3 -machine lm3s6965evb -nographic -semihosting-config enable=on,target=native -gdb tcp::3333 -S -kernel target\thumbv7m-none-eabi\debug\app` (exit code: 3)

any idea why ?

Closing as I found the solution to my own ignorance  :
arm-none-eabi-gdb -q -x openocd.gdb target\thumbv7m-none-eabi\debug\app
is the command to be run in a second terminal in order to correctly connect to qemu!


[clkmgr] Make jitter enable a multi-bit signal for redundancy.

Fixes #8980
Signed-off-by: Timothy Chen<EMAIL_ADDRESS>

So the goal is to make it hard to disable jitter once it is enabed. Does it mean only the Off value disables it, and all others keep it enabled? Also, the jitter enable output is single bit, so it is not deemed so susceptible to attack?

So the goal is to make it hard to disable jitter once it is enabed. Does it mean only the Off value disables it, and all others keep it enabled? Also, the jitter enable output is single bit, so it is not deemed so susceptible to attack?

o shoot you're right, i'm using the wrong kind of decode here for that definition. Thanks for catching it. Yeah technically the output is also vulnerable..but at this point I didn't want to change the IO of clkmgr unless i HAVE to. So i'll chalk it up to an improvement for later.

@matutem thanks for catching this. I've updated this one more time, do you mind having a look?


build(deps): update fastlane plugins and gems versions

This PR resolves []
Description
Bumps fastlane deps

#nochangelog

Warnings

:warning:

✅ No changelog changes

  Generated by :no_entry_sign: dangerJS against e9116746498188d255a342b0057c893415072bdc


Add support to package a standalone executable

If it is useful for others, we used this approach to load aws-azure-login into an environment with limited Internet access, where we couldn't directly use yarn to download all of the dependencies.

pkg doesn't work well with puppeteer. I've tried this. The only way to make it work is to ship the chromium binary along with the was-azure-login bin, or set puppeteer environment variables and use an already installed Chrome/Chromium instance. I'll happily reopen if you can demonstrate a working standalone binary build. Thanks!

pkg doesn't work well with puppeteer. I've tried this. The only way to make it work is to ship the chromium binary along with the was-azure-login bin, or set puppeteer environment variables and use an already installed Chrome/Chromium instance. I'll happily reopen if you can demonstrate a working standalone binary build. Thanks!


Error At least one email address must be verified to do that. occur in Danger

Solved email dormancy issue for bot accounts