Viktor's CI tart :)

Git commit: author, commit message, PR title
Byte-level: printable ASCII characters only, file mode bits (chmod +x)
Syntax errors: source code, templates
Unit and functional tests, e2e tests
Static analysis, magic number, copy-paste detector
Coding Standards, EditorConfig adherence

from https://github.com/szepeviktor/debian-server-tools/blob/master/webserver/Continuous-integration-Continuous-delivery.md
Is it too paranoid?

Hello @szepeviktor
Thanks for your suggestions.
This pipeline is just an example. However, you are more than welcome to improve the example with your suggestions. I would love to review any PR.
This is how I normally check CS for Java projects:
name: Google Java Format

on:
  push:
    branches:
      - dev

  pull_request:
    branches:
      - '*'

jobs:
  formatting:
    runs-on: ubuntu-latest

    permissions: write-all

    steps:
      - if: github.event_name != 'pull_request'
        uses: actions/checkout@v3
      - if: github.event_name == 'pull_request'
        uses: actions/checkout@v3
        with:
          ref: ${{ github.event.pull_request.head.ref }}
      - uses: axel-op/googlejavaformat-action@v3
        with:
          skipCommit: true
          args: "--skip-sorting-imports --replace"
          githubToken: ${{ secrets.GITHUB_TOKEN }}
      - name: Commit
        run: |
          if [ -n "$(git status --porcelain)" ]; then
            git gc
            git config user.name "GitHub Actions"
            git config user.email ""
            git commit -m "Google Java Format" --author="${GITHUB_ACTOR}<EMAIL_ADDRESS>-a
            git push
          fi

I checked your repo. It is a cool feature checking for non ASCII characters. I see you are working in PHP. I have used this rule of PHP CS fixer solving this in the past: https://cs.symfony.com/doc/rules/naming/no_homoglyph_names.html


On Hover Effect for Join us on Discord Button on home page

Description:
I'd like to suggest adding an "on hover" effect to the "Join Us On Discord" button the on home page in the project. This feature would enhance the user experience by providing visual feedback when a user hovers their mouse pointer over a button. It can make the project look more interactive and engaging.
Implementation Suggestions:
If you have any ideas on how this feature can be implemented or if you're willing to contribute to the implementation, please share your thoughts.
Screenshots:
The image I have provided is a recent image where there is no hover event on the button

Additional Context:
If you wish to add this feature I am willing to work on this feature so you can assign it to me.

hi @martinjagodic can you assign it to me

Thanks I'll work on it

@martinjagodic  when should I expect review on the pull request

@Shreyashingale I can't promise anything. This is an open source project so PRs are reviewed depending on the availability of the team. Currently, we are a bit booked so please be patient. Also, PRs are merged based on the value they bring to the code.

@martinjagodic  Ok, Thanks for the reply in the meantime I'll look for other issues in the repo.


dominance analysis given a correlation matrix

Describe the solution you'd like
I'd like to do a dominance analysis given a correlation matrix.
I do not have the whole dataset.
Describe alternatives you've considered
An alternative would be to refresh my R knowledge and work with https://github.com/clbustos/dominanceAnalysis or ask a colleague to dig out an Excel file we used three years ago.
Additional context
I love python and would love to use this library instead of the alternatives listed above.

We have updated the library to perform Dominance Analysis given a Correlation Matrix or a Co-Variance Matrix.

Thank you so much!


DNS Validation with ZoneEdit

It will be fantastic to include DNS validation with ZoneEdit. This public DNS service provides API endpoint to create and delete TXT records. A very simple and useful integration. ZoneEdit offers limited-scope authentication tokens for API, which is great for security. Here is overall guide how to use dynamic API https://support.zoneedit.com/en/knowledgebase/article/dynamic-dns and here is article for TXT records using API https://support.zoneedit.com/en/knowledgebase/article/changes-to-dynamic-dns

For the API result codes, the XML output returned is up to the requestor to parse and handle:

NOACCESS or NO_AUTH
The authentication failed. This not only happens if the username/password is wrong, but also if the request is for a hostname/domain that isn’t under the user’s account.

NOSERVICE
Dynamic DNS is not turned on for this domain. Each domain must have its own DynDNS flag enabled individually (by the user) in their member settings.

ILLEGAL INPUT
Self-explanatory. The client sent data that is outside the allowed set for a DynDNS update.

TOOSOON
Not enough time has elapsed since the last update. You need to wait at least 10 minutes between updates. It limits the number of DYNAMIC DNS updates for the same hostname within a short period of time. This includes any update operation against the same hostname (both CREATE and DELETE).

NOERROR or OK
Everything works fine.


fix unexpected EOF when compression is enabled

when compression is enabled in a Proxy, it may fail with io.UnexpectedEOF and return HTTP 500 to the client.

Codecov Report
Base: 77.02% // Head: 76.86% // Decreases project coverage by -0.16% :warning:

Coverage data is based on head (8856363) compared to base (7a75cc8).
Patch coverage: 64.70% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
- Coverage   77.02%   76.86%   -0.17%
==========================================
  Files         103      103
  Lines       11523    11536      +13
==========================================
- Hits         8876     8867       -9
- Misses       2149     2165      +16
- Partials      498      504       +6

Impacted Files
Coverage Δ

pkg/filters/responseadaptor/responseadaptor.go
68.69% <50.00%> (-0.68%)
:arrow_down:

pkg/filters/requestadaptor/requestadaptor.go
75.46% <66.66%> (-1.32%)
:arrow_down:

pkg/filters/proxy/compression.go
85.00% <100.00%> (+0.38%)
:arrow_up:

pkg/filters/validator/basicauth.go
77.41% <0.00%> (-1.39%)
:arrow_down:

pkg/cluster/cluster.go
60.10% <0.00%> (-1.06%)
:arrow_down:

pkg/object/mqttproxy/broker.go
74.79% <0.00%> (-1.01%)
:arrow_down:

pkg/object/autocertmanager/autocertmanager.go
93.46% <0.00%> (-0.82%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


preview-window set to "0,hidden" will trigger the preview command even if I don't toggle-preview

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[x] Linux
[ ] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[ ] bash
[x] zsh
[ ] fish

Problem / Steps to reproduce
When I execute fzf --preview 'touch trigger' --preview-window=0,hidden --bind ctrl-p:toggle-preview, fzf will execute the preview command.
But when I change the preview window size to 1 will not execute the preview command until I manully toggle the preview (fzf --preview 'touch trigger' --preview-window=1,hidden  --bind ctrl-p:toggle-preview).
In conclusion, fzf has different hidden window behaviors when its window size is 1 or 0.
I tested fzf-0.35.0 not having this problem.

I tested fzf-0.35.0 not having this problem.

Bisecting suggests: 23d8b78ce12a6d9182a3e576de96123eb4ad176d

I also noticed a change in behavior with this bisect commit, when you have two hotkeys to switch previews, it used to be switching to the new preview, now it closes the old preview first and you have to press the hotkey again.
# @junegunn
# Try this command with 23d8b78 and the previous commit, note the difference in toggling the preview
fzf --bind "?:toggle-preview+change-preview:echo question mark" --bind "tab:toggle-preview+change-preview:echo tab"

fzf has different hidden window behaviors when its window size is 1 or 0.

fzf running preview command in the background when the size of the window is zero is an old, lesser-known documented feature. Zero is treated differently.
https://github.com/junegunn/fzf/commit/6a75e30941af50a7197ef5e96c07a8605aec9a53
However, I didn't think someone would combine 0 with hidden. What's the use case?
@LangLangBart The new behavior feels correct to me. change-preview only changes the command template of the previewer, it shouldn't affect the status of the preview window.

However, I didn't think someone would combine 0 with hidden. What's the use case?

My neovim plugin fzf_utils uses neovim's built-in floating window as the previewer. It combines '0' with 'hidden', and the previewer not presented util I press key to toggle the previewer.


custom.css

Hi,
Can you add to the next update something like:
{% do assets.addCss('theme://css/slideme.css',100) %}
That will be nice.
Beste regards
Ocean

Maybe you meant {% do assets.addCss('theme://css/custom.css',100) %} ? You've got it in 1.0.4 release


GH-1121: Fix KTU.getSingleRecord()

Fixes https://github.com/spring-projects/spring-kafka/issues/1121
getSingleRecord() didn't work if the consumer was subscribed to
multiple topics that had records.
Change the assert to ensure there is just one message for the
requested topic and seek any records that were retrieved for other
topics.
cherry-pick to 2.2.x

... and cherry-picked to 2.2.x


[feature] Implement skip-fmt input

Hi,
It'd be useful to have skip-fmt (similar to skip-plan) input. If it's true then terraform fmt --check is not execute so it does not check the code formatting and, as result, does not fail a workflow run.
Please see screenshot

Alrighty, new skip-fmt option is now live in the v3.1.0 and v3 tags.  Hope it does the trick for you.


[Issue] 500 CNAME Cross-User Banned

Attempting to make a request to a bin returns a Cloudflare error. I've created additional bins and it results in the same error.

having the same issue here.

+1

Apologies, this was a temporary misconfiguration that has since been resolved.


ATV-10 | Build production image

This PR should make the production image build locally and with the pipeline.
Refs ATV-10

Codecov Report

Merging #3 (4f3ea4c) into main (15f371b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage   74.57%   74.57%
=======================================
  Files           9        9
  Lines         118      118
  Branches        8        8
=======================================
  Hits           88       88
  Misses         25       25
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15f371b...4f3ea4c. Read the comment docs.


Spec pipeline orchestration

translateVpc: combinationally returns bool, ppc
sendPpc: returns bool on accept, puts inst in fetch-buffer in next cycle
doFetch: combinationally returns bool, inst
decExec: (combinationally returns bool)
translateVAddr: combinationally retuns bool, paddr
memSend: returns bool on accept, puts data in mem-device in next cycle
memRecv: callback returning bool, data
commit: update all registers

token-buffer -> translateVpc -> (buffer) -> sendPpc -> fetch-buffer -> doFetch -> buffer -> decExec ->
buffer -> translateVAddr -> (buffer) -> memSend -> mem-device -> memRecv, commit -> update-regs, token-buffer

// Both buffers are under our control (e.g. translateVAddr)
If(left buffer is not empty && right buffer is not full)
then
  let res <- doAction (left buffer); //
  If(res is valid)
  then
    deq from left buffer
    enq (res) into right buffer //
  fi
fi

// Right buffer is not under our control (e.g. sendPpc)
If(left buffer is not empty)
then
  let res <- doAction (left buffer);
  If(res is valid) // only if right buffer is not full
  then
    deq from left buffer
  fi
fi

Make the state regs async fifo instances


Merge Request

@LinxuanHu I have added some more details in the documentation file. Please accept the request.
@pratibha77118 Hope, we are finally done, right?

@tirthbha I do have pulled the merge request.

all requests have been merged

ALWAYS SUBMITTING AT THE LAST HOUR. KEEPS THINGS INTRESTING


Slowdown by vcpkg msbuild integration

When we use vcpkg for our projects (solutions says 108 projects) our pipeline runs ~6 minutes longer (39 -> 45 minutes) while the vcpkg.json file is "empty" (no dependencies). Imo 6 minutes for doing nothing is quite long. It seems that vcpkg is called in 103 Projects, so it needs 3,5 Seconds per projects. When looking at the logs it seems that most of the time it waits for the file lock (~2.5 - 3 seconds), but the reported total elapsed time is ~15.9 us ... (#16850). So when the file is locked another tool must run at the same time. Why needs vcpkg so long to run and is there a way to reduce the file locked time?

I have no idea about this, @vicroms, could you please help take a look?

This hurts us as well. IIRC, @ras0219-msft wrote something about this on Slack the other day. I think concurrent build is disabled when using manifest mode because of the file lock...?

Is there any known workaround for this? This is the only downside since our adoption of vcpkg.

For CMake, you can explicitly disable the manifest install step via -DVCPKG_MANIFEST_INSTALL=OFF (https://github.com/microsoft/vcpkg/blob/master/docs/users/manifests.md#vcpkg_manifest_install).
As a workaround, could you try:
file(TIMESTAMP "${CMAKE_CURRENT_LIST_DIR}/vcpkg.json" vcpkg_json_timestamp)
if(VCPKG_JSON_TIMESTAMP_PREV STREQUAL vcpkg_json_timestamp)
    set(VCPKG_MANIFEST_INSTALL OFF CACHE STRING "" FORCE)
else()
    set(VCPKG_MANIFEST_INSTALL ON CACHE STRING "" FORCE)
endif()

project(...)
set(VCPKG_JSON_TIMESTAMP_PREV "${vcpkg_json_timestamp}" CACHE STRING "" FORCE)

This should only run the install when the timestamp changes. If you try this out, please let us know if this workaround solves the problem to your satisfaction :)

thanks @ras0219 it solved the problem here.


(GH-87) Moved to using limited output.

Old implementation caused promotional message, and chocolatey banner to get mixed into the works. If upgrading Chocolatey, cause problems as the version caught is a string with "vX.X.X" and in the where clause is attempted to be converted to a .net version type.
Limiting the output reduces it to only the packages, leaving out any banners.
Spent a while thinking of how to test this, as point 5 states - but nothing could come to mind without mocking the call to choco and writing its own response, at least from what I can think of.
An example of the fixes below
<#

PS C:\Users\lg\Documents\Git\cChoco> choco list -lo
Chocolatey v0.10.7
chocolatey 0.10.7
erlang 19.3
rabbitmq 3.6.10
3 packages installed.

#>

 function Get-ChocoInstalledPackage {
    $res = choco list -lo | ForEach-Object {
        $Obj = $_ -split '\s'
        [pscustomobject]@{
            'Name'    = $Obj[0]
            'Version' = $Obj[1]
        }
    }
    Return $res

 }

 Get-ChocoInstalledPackage

 <#

 Name       Version
----       -------
Chocolatey v0.10.7
chocolatey 0.10.7
erlang     19.3
rabbitmq   3.6.10
3          packages

 #>

 function Get-ChocoInstalledPackage {

 Return (choco list -lo -r | ConvertFrom-Csv -Header 'Name', 'Version' -Delimiter "|")

 }

 Get-ChocoInstalledPackage

 <#

 Name       Version
----       -------
chocolatey 0.10.7
erlang     19.3
rabbitmq   3.6.10

 #>

Closes #87.

Merged into development at https://github.com/chocolatey/cChoco/commit/c7d4976c2cf6daf16721b5ce519d8112c7f0a1f4

Thank you for your contribution!


pythonPackages.launchpadlib: fix tests by using pytestCheckHook

Motivation for this change
This fixes hydra-unstable.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 113710 run on x86_64-linux 1

1 package built:

hydra-unstable

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

hydra-unstable:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/development/tools/misc/hydra/common.nix:133:5:
    |
133 |     license = licenses.gpl3;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
autoconf is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/tools/misc/hydra/common.nix:81:3:
   |
81 |   buildInputs =
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
automake is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/tools/misc/hydra/common.nix:81:3:
   |
81 |   buildInputs =
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
libtool is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/tools/misc/hydra/common.nix:81:3:
   |
81 |   buildInputs =
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/tools/misc/hydra/common.nix:81:3:
   |
81 |   buildInputs =
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
perl is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/tools/misc/hydra/common.nix:81:3:
   |
81 |   buildInputs =
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
subversion is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/tools/misc/hydra/common.nix:81:3:
   |
81 |   buildInputs =
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/tools/misc/hydra/common.nix:81:3:
   |
81 |   buildInputs =
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
Unused argument: darcs.
Near pkgs/development/tools/misc/hydra/common.nix:3:23:
  |
3 | , top-git, mercurial, darcs, subversion, breezy, openssl, bzip2, libxslt
  |                       ^

/rebase master

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 113710 run on x86_64-darwin 1

3 packages marked as broken and skipped:

python39Packages.breezy
python39Packages.check-manifest
python39Packages.launchpadlib

13 packages built:

breezy (python38Packages.breezy)
cabal2nix
dep2nix
devpi-client
nix-prefetch-bzr
nix-prefetch-scripts
nix-update-source
python37Packages.breezy
python37Packages.check-manifest
python37Packages.launchpadlib
python38Packages.check-manifest
python38Packages.launchpadlib
vcstool

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

nix-prefetch-bzr:

Package is missing a license
Near pkgs/tools/package-management/nix-prefetch-scripts/default.nix:22:5:
   |
22 |     meta = with lib; {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/tools/package-management/nix-prefetch-scripts/default.nix:13:5:
   |
13 |     installPhase = ''
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

python37Packages.breezy:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/development/python-modules/breezy/default.nix:39:5:
   |
39 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

python37Packages.check-manifest:

Add a checkPhase for tests, or at least pythonImportsCheck.
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python38Packages.check-manifest:

Add a checkPhase for tests, or at least pythonImportsCheck.
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md


custom fields in json response

Hi Yajra,
How can I send additional data with the json-response. I have a small blood-pressure app (bp.aria-network.com) and I need the average for the columns with sys,dys and puls. I figured it out with javascript but I don't get all the data in one ajax request. If i use pagination i get the average only for the page, if I use scroller I get 78 out of 100, but not the average of all records. So I decided to get the average and some other calculations serverside. I tried to hack your classes but I figured out I won't be able to recreate this should there be an update. Any possibilities to add custom fields, like your draw, recordsfiltered and recordsTotal, to the response. If not,where is it best to start hack your classes

Hi @dabonzo,
We have a ->with('key', 'value') api that you can use to attach additional data in the response. I think I don't have a demo of it yet but the are similar issues here the you can use as ref.
A quick ref: https://github.com/yajra/laravel-datatables/issues/277

Thank you @yajra, this is exactly what I asked for. Great package btw. and every day I find something very usefull

How i use the variables that i send to the view? i want a tfoot with all sums and counts

@mariani10 Did you solve it? the problem same to me.

var api = this.api() ;
var customKeyName = api.ajax.json().customKeyName;


[Bugfix] Fix Phi-3 Long RoPE scaling implementation

When evaluating our fine tunes of Phi-3, we noticed a big difference in the logits outputted by Huggingface transformers and vLLM.
The most significant cause of this was a deviation in the positional embedding implementation of vLLM. Since Microsoft contributed their Phi-3 implementation to Huggingface transformers, I believe that is the reference implementation to follow:-
https://github.com/huggingface/transformers/blob/9ba9369a2557e53a01378199a9839ec6e82d8bc7/src/transformers/models/phi3/modeling_phi3.py#L153
The above link shows how Phi-3's rotation matrix is scaled. I've added similar code to vLLM's Phi3LongRoPEScaledRotaryEmbedding and removed the hardcoded mscale factors.
After these changes, the attention outputs of Huggingface and vLLM are exactly the same.

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

LGTM once the CI passes, make sure to run formatting with ./format.sh


Chat created with graph api is opening random chat in Microsoft teams (web)

When we create a Microsoft Teams chat with 'Create Chat api' we get Chat URL in response. When we open the URL it opens a random chat in teams rather than newly created chat.  Below is the recording
https://user-images.githubusercontent.com/102144967/159443375-17f2b5e4-7929-47e8-a865-3cf45eb520bb.mp4

We are looking into this issue, we will update you.

We have tried this issue on Windows machine, and it is working fine. It is opening the correct group chat. Attaching a video for your reference. Have you tried this in Mac Machine?
https://user-images.githubusercontent.com/81138249/159536259-c72719cc-a3d6-4826-8522-8c146ee2f159.mp4

@kaursimransidhu1 - Could you please provide the above asked details?

Hi,
I tried in Mac OS.
Please try when no other teams tab is open, and teams is opened for the first time when you go to webUrl of chat. If Teams is already opened in any other tabs then it works fine, the issue is for the very first opening of teams only.

@kaursimransidhu1 - We tried this in Mac OS, it is working fine in Mac OS as well. We checked in this version -  Version: 12.3(21E230).
Could you please confirm if you are getting this issue in other Mac machines as well? Also please share the version details.

Hi @Meghana-MSFT ,
as i mentioned pls try to close all teams open tabs and open the URL such that it is the first tab of teams opening in the chrome window, then issue will happen, if there are already 1-2 or more tabs open of teams web client then it will open correct chat, issue is happening when we are opening teams as well for the first time with the web URL

Hi @Meghana-MSFT ,
as i mentioned pls try to close all teams open tabs and open the URL such that it is the first tab of teams opening in the chrome window, then issue will happen, if there are already 1-2 or more tabs open of teams web client then it will open correct chat, issue is happening when we are opening teams as well for the first time with the web URL

As I have already mentioned in my previous comment, we closed all Teams tabs and kept only graph explorer tab open.

Hi,
As you can see in the recording, I am facing the issue clearly. So if you can reproduce and help, that will be great.
My mac version is 11.6.4
Thanks
Simran

We are checking this internally, we will update you.

Hi, any update on this ?

I will check with team and get back to you.

We have raised a bug for this, currently we do not have any updates. We will let you know if there is any.

@s1mran - Could you please let us know if you are still facing this issue? As this seems to be a client error.

@s1mran - We have confirmed with engineering team and looks like it is the Teams client issue.
Can you please try updating the Teams client and check it once?


Load Images from embedded resources for Desktop Applications

Desktop apps should be able to show toast notifications with embedded resource images.
Right now every image that is used in a toast notifiction has to be stored on disk for usage with file:///
But many applications pack their images within embedded resources:
<ItemGroup>
<EmbeddedResource Include="Images*" />
</ItemGroup>
Loading images from embedded resources (e.g. resource:///) would eliminate the need for desktop apps to store their images on disk for toast notifications.
The same question also appeared some time ago on Stack Overflow:
https://stackoverflow.com/questions/41570815/using-image-from-app-package-in-win10-toast

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0a6e0613-f0ef-682b-376c-0e56077f8c63
Version Independent ID: 7a9667c6-af0e-9ef8-f999-ce942cb02c9e
Content: image - Windows UWP applications
Content Source: winrt-related-src/schemas/tiles/toastschema/element-image.md
Product: uwp
GitHub Login: @mcleblanc
Microsoft Alias: markl

Hi - Thanks for taking the time to let us know about this. Due to the sheer volume of feedback in our repo, we're currently prioritizing new issues. I'm going to close this but if it's still impacting you or others, feel free to leave a comment and we can keep it open and dig in. Alternatively, you can submit a new issue or pull request with the latest details. Thanks so much and apologies for the delayed communication here.


Show song in free play

What is your question?
Im new to modding, I added a song in my mod that I made, but how do I make it appear on freeplay?

add it in your mod's weeks.json.
it needs to match with the folder name in mods/data

Thanks


New TPLink component does not work with declarative config. Discovery not working on different subnets.

Home Assistant release with the issue:

0.89.1
Last working Home Assistant release (if known):
0.88
Operating environment (Hass.io/Docker/Windows/etc.):

Docker, Hassio Tested
Component/platform:

https://www.home-assistant.io/components/tplink/
Description of problem:
TPLink declarative configuration not working. Discovery is limited to the same subnet. I have created a new docker instance with a baremetal config and still see the error. No devices show up as entities.
Note: The hass instance is running on the 10.0.1.x subnet and my IOT/TP-Link devices are on 10.0.8.x
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
tplink:
  discovery: true
  light:
    - host: <IP_ADDRESS>

Traceback (if applicable):
2019-03-10 21:55:27 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/helpers/entity_platform.py", line 257, in _async_add_entity
    if entity.unique_id is not None:
  File "/usr/src/app/homeassistant/components/tplink/light.py", line 82, in unique_id
    return self._sysinfo["mac"]
TypeError: 'NoneType' object is not subscriptable

Additional information:
I have also tested this with switches and neither are working as expected and throw the same error.

If tplink discovery uses mDNS (which it probably is), then this is a problem with your network setup. You need to enable multicast UDP traffic over the two subnets, otherwise there's no way to get the discovery to work.

tplink not working with different error.
Log Details (ERROR) Mon Mar 11 2019 11:56:55 GMT-0700 (Pacific Daylight Time) Error while setting up platform tplink Traceback (most recent call last):   File "/usr/local/lib/python3.7/site-packages/homeassistant/helpers/entity_platform.py", line 127, in _async_setup_platform     asyncio.shield(task, loop=hass.loop),   File "/usr/local/lib/python3.7/asyncio/tasks.py", line 769, in shield     inner = ensure_future(arg, loop=loop)   File "/usr/local/lib/python3.7/asyncio/tasks.py", line 592, in ensure_future     raise TypeError('An asyncio.Future, a coroutine or an awaitable is ' TypeError: An asyncio.Future, a coroutine or an awaitable is required

The latter error is a bug. We should change async_setup_platform to be a coroutine.
CC @rytilahti

tplink uses a custom protocol for discovery, but it would be possible to make the broadcast address it's using configurable to support other subnets: https://github.com/GadgetReactor/pyHS100/blob/master/pyHS100/discover.py#L34
The nonetype error is caused by the fact that it hasn't been able to fetch the system information from the device, which indicates that there is no connectivity between the networks. Can you try if pyhs100 works in console?
The third error is something, maybe related to what @MartinHjelmare said, but I'm not sure about that.

This should be a coroutine:
https://github.com/home-assistant/home-assistant/blob/5eab86986e6c56325e9e70d72a9ddbfca53b19ec/homeassistant/components/tplink/light.py#L32
This too:
https://github.com/home-assistant/home-assistant/blob/5eab86986e6c56325e9e70d72a9ddbfca53b19ec/homeassistant/components/tplink/switch.py#L27

tplink not working with different error.
Mon Mar 11 2019 11:56:55 GMT-0700 (Pacific Daylight Time)
Error while setting up platform tplink
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/homeassistant/helpers/entity_platform.py", line 127, in _async_setup_platform
    asyncio.shield(task, loop=hass.loop),
  File "/usr/local/lib/python3.7/asyncio/tasks.py", line 769, in shield
    inner = ensure_future(arg, loop=loop)
  File "/usr/local/lib/python3.7/asyncio/tasks.py", line 592, in ensure_future
    raise TypeError('An asyncio.Future, a coroutine or an awaitable is '
TypeError: An asyncio.Future, a coroutine or an awaitable is required

Met same error here, can't populate tp-link switches and lights.

Discover sometimes works for me, sometimes not, so i just manually set them... However, this new "version" doesn't allow custom "names".
i.e. this should work:
tplink:
  switch:
    - host: <IP_ADDRESS>
      name: custom name for switch

otherwise, I have to re-write ALL of my automatons 👎

@marc-gist you can rename your devices with the app or with the pyhs100tool, this option was removed to simplify the code. That discovery is not working every time is obviously not a good sign and should be fixed, maybe the 3 second timeout is too short

I also have my TP-Link plugs on a different subnet and neither autodiscover or manual configuration are able to see my devices.
Here's my 0.89 configuration.yaml (not working)
tplink:
  discovery: false
  switch:
    - host: <IP_ADDRESS>
    - host: <IP_ADDRESS>
    - host: <IP_ADDRESS>
    - host: <IP_ADDRESS>

and here's my 0.88 configuration.yaml (working)
switch:
  - platform: tplink
    host: <IP_ADDRESS>
  - platform: tplink
    host: <IP_ADDRESS>
  - platform: tplink
    host: <IP_ADDRESS>
  - platform: tplink
    host: <IP_ADDRESS>

Logs:
2019-03-16 13:16:47 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry TP-Link Smart Home for tplink Traceback (most recent call last): File "/usr/local/lib/python3.7/site-packages/pyHS100/smartdevice.py", line 116, in _query_helper request=request, File "/usr/local/lib/python3.7/site-packages/pyHS100/protocol.py", line 47, in query sock = socket.create_connection((host, port), timeout) File "/usr/local/lib/python3.7/socket.py", line 727, in create_connection raise err File "/usr/local/lib/python3.7/socket.py", line 716, in create_connection sock.connect(sa) OSError: [Errno 113] No route to host The above exception was the direct cause of the following exception: Traceback (most recent call last): File "/usr/src/app/homeassistant/config_entries.py", line 283, in async_setup result = await component.async_setup_entry(hass, self) File "/usr/src/app/homeassistant/components/tplink/__init__.py", line 120, in async_setup_entry await hass.async_add_executor_job(_fill_device_lists) File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run result = self.fn(*self.args, **self.kwargs) File "/usr/src/app/homeassistant/components/tplink/__init__.py", line 110, in _fill_device_lists if dev.is_dimmable: # Dimmers act as lights File "/usr/local/lib/python3.7/site-packages/pyHS100/smartplug.py", line 131, in is_dimmable return "brightness" in self.sys_info File "/usr/local/lib/python3.7/site-packages/pyHS100/smartdevice.py", line 185, in sys_info return defaultdict(lambda: None, self.get_sysinfo()) File "/usr/local/lib/python3.7/site-packages/pyHS100/smartdevice.py", line 195, in get_sysinfo return self._query_helper("system", "get_sysinfo") File "/usr/local/lib/python3.7/site-packages/pyHS100/smartdevice.py", line 119, in _query_helper raise SmartDeviceException('Communication error') from ex pyHS100.smartdevice.SmartDeviceException: Communication error

I've reverted back to 0.88 and my plugs are working again so they are definitely reachable from Home Assistant

Should we split off the first part of this issue's topic into another issue? They don't seem very related, but I do think both are important.
I just recently upgraded and losing the ability to declare names for my switches is an order of magnitude loss of functionality for me. I set static IPs for all my switches such that I can declare their names and functionality (automations & scripts) in Home Assistant. Now that other people in my house can rename the switches and silently break functionality, it seems silly to even attempt to control them through Home Assistant.
This has changed Home Assistant's role from being able to control specific unique devices to possibly being able to control some kind of device somewhere in my house. That's a huge bummer.

@kneath I agree with you... however, had a discussion with Dev's on Discord and I now understand their reasons for this.   I also still disagree 🙁 with them... but hopefully the implement the ability for any component to set the name/id via config.  There is still so much good in HA I'm sticking with it.

on PI and Unraid still getting following errors in v 0.90.0 and 0.90.1
Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/lib/python3.5/asyncio/tasks.py", line 239, in _step
    result = coro.send(None)
  File "/usr/local/lib/python3.5/dist-packages/homeassistant/helpers/entity_platform.py", line 257, in _async_add_entity
    if entity.unique_id is not None:
  File "/usr/local/lib/python3.5/dist-packages/homeassistant/components/tplink/light.py", line 82, in unique_id
    return self._sysinfo["mac"]
TypeError: 'NoneType' object is not subscriptable

configuration.ymal is:
tplink:
  discovery: true
  light:
    - host: <IP_ADDRESS>
    - host: <IP_ADDRESS>
    - host: <IP_ADDRESS>
    - host: <IP_ADDRESS>

Looks like other users are running into this too.
https://www.reddit.com/r/homeassistant/comments/bbtz2p/tplink_bulbs_and_naming/

@bgulla that reddit discussion is related to naming of devices, this issue is about the discoverability of devices on different subnets (which should be reported to upstream, the only way to fix that is to allow specifying a custom subnet for discovery and then adapt homeassistant to allow passing that via config or config flow).
@balvant813 I removed your comment as the description is already in #22313.

Do you have more info on how to identify another subnet for discovery?
On Sat, Apr 13, 2019 at 1:55 AM Teemu R<EMAIL_ADDRESS>wrote:

@bgulla https://github.com/bgulla that reddit discussion is related to
naming of devices, this issue is about the discoverability of devices on
different subnets (which should be reported to upstream, the only way to
fix that is to allow specifying a custom subnet for discovery and then
adapt homeassistant to allow passing that via config or config flow).
@balvant813 https://github.com/balvant813 I removed your comment as the
description is already in #22313
https://github.com/home-assistant/home-assistant/issues/22313.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/issues/21916#issuecomment-482779433,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACkoMwJ9ODIUj_HV8IPxQraJ_aiEKOqBks5vgXFqgaJpZM4bnjuQ
.

--
Brandon

@bgulla that needs to be fixed first in the upstream, but the basic idea would be to allow it to select the broadcast target (see https://github.com/GadgetReactor/pyHS100/blob/master/pyHS100/discover.py#L34), then assuming you know your subnets you can simply use the broadcast address for the given network (instead of using <IP_ADDRESS>).

@rytilahti As per my comment above, this issue used to be about two different things (since edited) — the dns discovery and the declaritive naming of devices. Unfortunately, all issues filed about declarative naming were closed as duplicates of this one. Should we create a new issue for the declarative naming? Or is this more of a “sucks for you” type of situation? It’s a huge bummer that’s really leading me to head toward downgrading several versions to this date. In actuality, I have removed all logic from HA and moved to the Kasa app because of side effects of this change, which is... not where I want to be.

@rytilahti As per my comment above, this issue used to be about two different things (since edited) — the dns discovery and the declarative naming of devices. Unfortunately, all issues filed about declarative naming were closed as duplicates of this one. Should we create a new issue for the declarative naming? Or is this more of a “sucks for you” type of situation? It’s a huge bummer that’s really leading me to head toward downgrading several versions to this date. In actuality, I have removed all logic from HA and moved to the Kasa app because of side effects of this change, which is... not where I want to be.

You can manually setup still via "host" (need IP address of each device, so need to reserve/static setup).
as any declaration of names/entity_id is no longer supported vi yaml configuration.  You can change entity_id in the UI after the initial run.  There after, the entity_id's will remain the same.
Are you having some other issue?

I’m not really sure what you mean by “host” — could you provide a link or more explanation? I do have all of my devices on static ips.
Changing the entity_id doesn’t really work for... I dunno, all of the reasons. The new discovery service is flakey at best (try to use a device that doesn’t connect at hass startup due to bad wifi, or try to rename a device after it’s been discovered, or delete a device after resetting it, or...). So, since I can’t get reliable names (via name => ip delcarative config), I cannot control my devices with home assistant at all. I cannot tell you the exact issue other than all of my automations with tp-link are non-functional (or at best, 10% functional) after this non-declarative update.

@kneath first of all, there has never been a dns-based discovery for these devices, but if you have a dns server (e.g. on your router providing dns for your plugs) using those in the config should work just fine. What exactly you mean with declarative config? Configuring the hosts manually inside your configuration file? If so, that should still work just fine.
There may be some edge cases when the devices are not available during the homeassistant's startup, though, as there is no way to signal to homeassistant to retry the initialization (how it was done before by raising a PlatformNotReady exception). This is something I think should be fixed not for each integration separately, but once and for all integrations. If someone knows how to deal with this, please let me know and/or feel free to create a PR.

I have no luck in discovering TPLINK bulbs via HA (since .90). Switches/Plugs are discovered by HA but I have to manage naming etc in core_entity.yaml. For the bulbs, names etc are managed via Kasa app. To much complexity in managing devices! I have decided not to install any new TP-Link devices anymore.
Balvant
From: Teemu R<EMAIL_ADDRESS>Sent: Monday, April 15, 2019 12:32 AM
To: home-assistant/home-assistant<EMAIL_ADDRESS>Cc: Balvant Patel<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [home-assistant/home-assistant] New TPLink component does not work with declarative config. Discovery not working on different subnets. (#21916)
@kneathhttps://github.com/kneath first of all, there has never been a dns-based discovery for these devices, but if you have a dns server (e.g. on your router providing dns for your plugs) using those in the config should work just fine. What exactly you mean with declarative config? Configuring the hosts manually inside your configuration file? If so, that should still work just fine.
There may be some edge cases when the devices are not available during the homeassistant's startup, though, as there is no way to signal to homeassistant to retry the initialization (how it was done before by raising a PlatformNotReady exception). This is something I think should be fixed not for each integration separately, but once and for all integrations. If someone knows how to deal with this, please let me know and/or feel free to create a PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/home-assistant/home-assistant/issues/21916#issuecomment-483103860, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AhNZMzfj9ISOLFqVaBTcGPXom_WW9d3jks5vhAC_gaJpZM4bnjuQ.

@rytilahti I apologize for using incorrect terminology. As to your assumption that you can still declaratively link specific hosts (IP addresses) to names in yaml, that is no longer the case. The only option for managing names/devices is now to use the discovery tool in the web UI in connection with the Kasa app. This currently has a lot of bugs (like I listed above), but more importantly, is just fundementally against how I use home assistant.
I’m kind of bummed this got derailed with all this back and forth. I have seen lots and lots of people stumble on the removal of this declarative naming. A lot of those people got redirected to this issue, and then in this issue told it wasn’t about declarative naming. It would be really great to have a way to write (in yaml) the names of my switches so that all my automations and config are self-contained to home-assistant and not split between yaml, home assistant web ui, and Kasa, and were reliable and easy to debug. My whole reason for using home assistant was to take control of my devices, not to use more 3rd party apps like Kasa.
That’s the last I’ll say on this, for now I’m downgrading home assistant and pinning it to an old version that lets me do this. Because right now it’s just become a web UI for viewing my Kasa configuration.

@balvant813 so the discovery is just fine with the plugs&strips? Maybe the problem is #20994 that is already fixed in master? About renaming the devices, see below.
@kneath you can do renaming from the homeassistant's ui, or with pyhs100 console tool. If the renaming as done within the UI is not something you like for some reason, that's something that needs to be fixed homeassistant in general, not separately for every single integration -- the exact reason for having a unique ids for devices is that it will makes things like renaming possible.
IIRC not having a separate setting to overload the names was even requested by the core devs, if someone wants to go and dig around the PRs and commits to verify, feel free to do. Or if you want, you can always open a PR to add that feature back to see if it will get accepted, I don't personally care about that.

All- This issue has gotten off topic and I have created a new ticket that focuses on the networking bug rather than the 'omg i cant rename this in homeassistant, gimmie my FOSS money back'. New Issue


4.2.4 exe installer is tripping Microsoft SmartScreen filter

Obviously, I can bypass and it installs fine, but it's not great.

Sure. From 4.2.4 release notes:
Note: we have re-registered all certificates to the Rider Soft LTD company. Windows executables are signed with the Symantec Code-Sign certificate. Windows 10 may warn about this certificate during one or two weeks - that's ok.

My apologies, didn't really read the release notes or dig into it  and just clicked update.  Just wanted to make sure you were aware =)


PDF.js not showing the color image in the PDF

Hi,
Attached PDF has a color image which is not displaying properly in PDF.js (in mozilla)
When i download the PDF i can see the color image in Page 1
Please let me know which property of the PDF/Image causing this issue

Unfortunately GitHub doesn't support attaching PDF files, can you please provide a like to the file?

Unfortunately GitHub doesn't support attaching PDF files, can you please provide a link to the file?

here is the URL http://www.rightprospectus.com/documents/Osterweis/SEMI_Osterweis.pdf

It's interesting that Preview is not showing this image at all.

JPEG with CMYK colorspace

This is a regression from commit https://github.com/mozilla/pdf.js/commit/e8f0700bfaa875817f3f460b64435c5b80943e0d, i.e. PR #4528.

Currently we are using the stable version V1.1.215
Can we do some change in the code and fix this issue ourself?

You can use the patch from #6366 and apply it manually if waiting for the next release it not an option.

Not able to access this Patch

Could you please provide the patch that we can apply to Version V1.1.215 and fix this issue

To get the current patch:
git fetch
git diff 3fa5f6cc3b30bb4808ea6c7fa86d702501e9af53^! -- src/core/image.js

Could you please tell me, when I can expect the next stable release of PDF.js with this issue fixed

IIRC we will release a new version on September 21.

Thanks timvandermeij,
Can you please provide the link where i can download the latest stable version on September 21

All releases are tracked here: https://github.com/mozilla/pdf.js/releases

Sorry for keep asking more details here. The next stable release coming on Sep 21 is V1.1.366
Could you please tell me which is the change set number, which has the fix for issue 6364?


Trireme-Kubernetes deployments disrupts long-lived connections of some existing pods

We see once in a while that upon deployment of Trireme-Kubernetes, some existing pods in the cluster will fail to send//receive upon already established connection.
For example, we can see this on Kube-DNS that will have its existing connection  to Kubernetes API broken, which will trigger a restart of the pod. (upon which the connection will be established again successfully)

This is actually a Trireme-Lib issue:
https://github.com/aporeto-inc/trireme-lib/issues/462


Server Crashes on Starting

https://pastebin.com/C7JxFfAR (fml-server-latest)
https://pastebin.com/Ugkfd0MA (Crash report)
I don't know if i'm just an idiot and glossed over something while reading about the mod or there is a incompatibility with the new forge. just trying to make a server for fun with friends and really wanted this mod to work it's one of the few that didn't work when i popped it in so hoping for a fix. i have run this by itself without other mod installed.

Your logs appear incomplete, thought the error is still visible. This mod depends on both Mantle and Tinkers Construct, ensure you have the latest versions of each for your version of Minecraft.

Closed due to no response.


Trying to fix tide by adding explicit job name

Why we need this PR
Tide isn't working
Changes made
Adding explicit job name to github worklow... just a try 🤷🏼♂

/override ci/prow/4.12-openshift-e2e
/override ci/prow/4.13-openshift-e2e
/override ci/prow/4.14-openshift-e2e
/override ci/prow/4.15-openshift-e2e
/override ci/prow/4.16-openshift-e2e

will probably only have effect after merge


Analysis warning correction

After running Product > Analyze, there are some issues appearing with potential leak, this branch corrects those issues

@fredhdroz Thanks for this - merged into development and will merge to master shortly after reviewing another change


fixed unorderable types error

Coverage remained the same at 97.336% when pulling c700373aadf42c767299b41424a937a087c2e463 on tgehrs:unorderable-types-fix into bb368201761b2381bb982c875f47c55d441e9578 on sidecars:master.


fix(v1): generate unions of options list values

Reads the list option and defines the type of a union of those literal values. This should be probably tested.
Let me know if there's any other place where lists can be specified.

@ricokahler added test.
Just one small comment: I've set the order of list items in the structure and in the matching test object is different because the order of the list options is not respected, but always consistently returned as they are sorted by hash here. I guess this is the expected behaviour.


Fix apiserver golint errors

Description
This changeset fixes golint errors found in apiserver. The custom linter flags are removed from apiserver Makefile and the global defaults will be used instead.
Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

TBD

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

cc @dimitri-nicolo


Installing 34 on Travis fails

For example: https://travis-ci.org/wpoely86/Lmod/jobs/229668239
This is with Lua 5.3.4 and luarocks 2.4.2
$ luarocks install luaposix

Installing https://luarocks.org/luaposix-34.0-1.src.rock

build-aux/luke package="luaposix" version="34.0-1" PREFIX="/home/travis/lua_install/lib/luarocks/rocks/luaposix/34.0-1" LUA="/home/travis/lua_install/bin/lua" LUA_INCDIR="/home/travis/lua_install/include" CFLAGS="-O2 -fPIC" LIBFLAG="-shared" LIB_EXTENSION="so" OBJ_EXTENSION="o" INST_LIBDIR="/home/travis/lua_install/lib/luarocks/rocks/luaposix/34.0-1/lib" INST_LUADIR="/home/travis/lua_install/lib/luarocks/rocks/luaposix/34.0-1/lua"

lua: build-aux/luke:120: attempt to concatenate a nil value (local 'found')

stack traceback:

	build-aux/luke:120: in upvalue 'check_executable_in_path'

	build-aux/luke:197: in local 'block'

	build-aux/luke:432: in function 'std.functional.dropuntil'

	build-aux/luke:197: in function <build-aux/luke:197>

	(...tail calls...)

	build-aux/luke:432: in function 'std.functional.dropuntil'

	build-aux/luke:210: in function <build-aux/luke:210>

	(...tail calls...)

	build-aux/luke:220: in function 'luke.configure.config_ldoc'

	build-aux/luke:244: in upvalue 'build_modules'

	build-aux/luke:254: in function 'luke.main'

	build-aux/luke:618: in main chunk

	[C]: in ?

thanks for the heads up; I think this is a simple matter of removing the ldoc references from the release lukefile, if you want to try patching while you wait for me to get back to a computer and fix it later today.
alternatively, please depend on v33.4.0 for a short while.
I'll follow up here after I push a fix.

I believe this issue is fixed in git-master now.
I've also pulled the 34.0 release from luarocks, pending some enhancements needed to get luaposix with luke building on macOS Yosemite.  Please open a new issue if you encounter this again (or any other problems).

Yes, it's fixed. Thanks.


Speed Upgrade is a downgrade to gas efficiency

A machine with eight speed and eight gas upgrades consumes the same amount of gas per operation as a machine with zero speed and zero gas upgrades. A machine with eight speed and zero gas upgrades will consume ten times the gas per operation as a machine with no upgrades. Likewise, a machine with eight speed and eight gas upgrades will consume ten times the gas per operation as a machine with zero speed and eight gas upgrades.
From the Mekanism wiki:

HINT: (For machines that use gasses) Machines consume gasses based on how long they are running. that means using speed upgrades will increase the gas efficiency.

--
Furthermore, a gas-using factory will consume gas twice on the final tick of processing, due to the gas tank being depleted once in the for process in tier.processes loop, and again when recipe.operate() is called during the final tick. This adds up to a 5% increase in gas costs when eight speed upgrades are installed.

I'm pretty certain that hint from the Mekanism wiki predates the addition of Gas Upgrades, so its likely just out of date and needs to be removed.
No comment on the 'consume twice' note.

The wiki is out of date on many things.  Speed upgrades cause energy and material usage to spike.
Efficiency and speed upgrades counter each other, so if you have equal numbers you get the increased speed at the original gas use.  Same goes with energy upgrades.  Ideally you'll want to do the material and energy efficiency upgrades at the same time or even before the speed upgrades.  Throw a chunk load upgrade (new, and not mentioned in wiki yet) in one machine in the chunk and who cares if it works at max speed or not? While you're out it can slowly process through everything.


When creating two clones with separate text in the animated text extension in quick succession they will show the same text

I could not think of a better way to describe it than just the title. Here's an example project
https://raw.githubusercontent.com/snowboyz0825/snowscodestuff/main/SB3s/Bug%20example%202.sb3

Your clone ID variable isnt "sprite only". When the clones create and initialize, the variable has already changed and its too late

Your clone ID variable isnt "sprite only". When the clones create and initialize, the variable has already changed and its too late

...I'll see myself out lmao


prod/ODWithWLS

This is the latest version of the hyper-k od. This includes the most recent hyper-k geometry as well as fixes to the photocoverage code.

Thanks for this @mahditaani (& co) We're planning to start reviewing this PR soon, so can you let us know if it's ready to go?
(Note that there are conflicts that need fixing anyway)

@mahditaani I've done the merge, but can't push it to your branch. So can you pull the merge commit from my branch? Something like
#make sure you're on the right branch
git checkout prod/ODWithWLS
#grab my changes
git remote add tom git@github.com:tdealtry/WCSim.git
git pull tom prod/ODWithWLS
#push them to your repo
git push origin prod/ODWithWLS

@tdealtry I tried to run this and while the code compiles it does not build an OD geometry (aborts when you try to run OD_10k.mac). I am looking into this to see what the issue is.

Thanks for this @mahditaani & @federiconova I'll have a proper look tomorrow (github actions have sponged all my time today... but look to have something working now. Will close/open this PR to trigger a build)

Doing another close/open to check if the permissions for uploading to the validation website are fixed

Ok, so no idea what's happened there. It seems to have run the validation on WCSim/develop rather than mahditaani/prod/ODWithWLS. I think I've got a fix, so will do another close/open (but of course it could be that a close/open by me isn't the same as a push by you...)
On the plus side, the action is now much faster, now we're not simulating dark noise for a long time in the validation

I'm happy the validation is correctly working on your branch now, but the output is still different to what's expected unfortunately... will delve next week

Thanks for all this work @mahditaani and the rest of the OD group!


fix(Global Search): remove is_hidden param from search operation

fix(Global Search/Tagging): regenerated services with latest API definition
PR summary
removed an internal search parameter: is_hidden
Integration Tests Results:

PR Checklist
Please make sure that your PR fulfills the following requirements:

[ ] The commit message follows the Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Just need to see clean int test results before merging.

Integration Tests Results:

:tada: This PR is included in version 0.30.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Discussion: Should we use config instead of the "node label"

When we install the hwamei stor, the user must to use "node label" to select the node enabled
Should we change it to the config file , like  https://github.com/rancher/local-path-provisioner#configuration
Benifit:

The config can be declared in the helm values.
We can use "auto policy" in config file, like " all free disk" , so that the use donot need to write the config mannaly.
Remove the Step in Installtion to make install simpler

@yankay Thanks for your suggestion,

When we install the hwamei stor, the user must to use "node label" to select the node enabled

We realize that this operation brings some complexity to the user experience.

Should we change it to the config file , like https://github.com/rancher/local-path-provisioner#configuration

As for the config file method you mentioned, we will consider it in the subsequent discussion and optimization.


Eval/testing/perf test

This PR re-enables and adds tests related to SDK performance, including:

Adds a test which runs 1000 evaluations locally to test evaluate performance.
Adds a test which runs 10 evaluations against a toy evaluator that hangs for half a second.

Both tests are parameterized to test against both the PF and non-PF code proxies that evaluate uses internally for kicking off evaluations. Since PF isn't capable of parallelism and it has a massive startup cost to new jobs, it has much laxer standards than the other.

API change check
API changes are not detected in this pull request.


Expected type in NSMutableArray + SWutility.h button

Expected type error when dragging podfiles manually into xcode project

Just solved but wanted to post answer in case anyone else runs into same issue.
Just add
#import <UIKit/UIKit.h>
into the NSMutableArray+SWUtilityButtons.h file


ftp: 2 identical files in downloads/ & protein IDs

There seem to be 2 identical files?
allNames.tsv | 2023-02-05 20:57 | 217K |
gene_IDs_names.tsv | 2023-02-05 20:57 | 217K |
Also, should we add  a protein ID column for completion? The protein ID is the gene name but with the first letter uppercase.

I think we can close it.


Bump identity apps console version

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7665451864

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7665451864
Status: failure


crypto::secretstream::Stream: Implement push/pull_to_slice methods

Hi! This PR introduces two new methods to the public API for crypto::secretstream::Stream, as well as moving around some of the internals.
The two new methods are Stream<Push>.push_to_slice() and Stream<Pull>.pull_to_slice(). These work much like the similar push_to_vec and pull_to_vec methods, except they accept an &mut [u8] rather than an &mut Vec<u8>, and it is this slice to which the resulting ciphertext/plaintext is read. The motivation for this change is to allow users to directly read messages from a secretstream into their own buffer types. For example, if a user is decrypting a plaintext that they want to zero after use, they might prefer to write directly to a buffer implementing Zeroize, or using a hardened memory region allocated with sodium_malloc, rather than first writing the plaintext to a vector.
These methods check at runtime that the slice is of sufficient length, and return an Err if it is not.
Internally, the PR creates new private methods push_impl_ptr and pull_impl_ptr, which are very similar to push_impl and pull_impl, but which take a mutable pointer directly, rather than taking a vector and then using as_mut_ptr to attain a mutable pointer. Otherwise the functionality is the same as the previous implementations. push_impl and pull_impl are rewritten to rely on these new methods, but can (hopefully!) be fairly simply seen to have identical functionality.
This is one of my first larger PRs to an external repo, so I would greatly appreciate any feedback :) Cheers!

Closing due to deprecation of the library.


Model compression of Generalizing Lottery Tickets

Hello, I have a question:
Lottery Tickets (a pruning method) should reduce the number of parameters.
However, I do not see any computation reduction in current implementation. The size of model checkpoint after each pruning iteration keeps the same, and the model only use 0 to mask these weights.

Hi @authwork ,
The current implementation prunes the network by freezing the parameters to zero, in effect reducing the number of varying (non-frozen) parameters. This is how most academic papers implement pruning.
To observe computation reduction, you can use hardware that exploits the sparsity of network to improve performance, or you can create a neural architecture from scratch, which is a replica of the pruned network (with 0 weights removed). I believe that the latter will be a non-trivial task.
The model size remains the same since we save the zero weights as well during checkpointing.

@varungohil Many thanks for your answer.
Then, I have one more question in the following code:
for name, params in model.named_parameters():
        if "weight" in name:
            weight_copy = params.data.abs().clone()
            mask = weight_copy.gt(threshold).float()
            zeros += mask.numel() - mask.nonzero().size(0)
            total += mask.numel()
            masks.append(mask)
            if random != 'false':
                masks = permute_masks(masks)

Why it is model.named_parameters(), but not only the trainable parameters?
I mean, the non-trainable parameters can be already regarded as the frozen/pruned parameters.

Hi @authwork,
This is a programming choice to simplify code, primarily because PyTorch offers this named_parameters() method.
For iterating only over trainable parameters, we would need to store them which would increase the memory required by the program. Further, this would add to code complexity.  To keep things simple, we iterate over all parameters.


Fd 007.3 google app styling

Issue Title: FD-007.3-GoogleAppStyling
Github #FD-007.3
Created by @KilowattDot
Description

Created the YNA Member application
Couldn't get the Form to be attached to the Google Form due to it being an react act so we'll have to be build the backend for this
Application features a scroll bar to cutdown on the length.
Responsiveness designs applied

Testing Instructions

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (development)
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Release Notes

Decisions

Technical Details

Links

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Fixed all errors. Please review.  @Young-N-Ambitious/frontend

@Sydnee510 @Young-N-Ambitious/frontend . My branch is up to date with the original. Please review once more.


Unknown field for Candidate: finish_message

Description of the bug:
During regular use, some requests to Gemini are returning this error instead of the response (Python project running in Docker):
chat-app-1  | 2024-09-17 14:34:44.282 Uncaught app exception
chat-app-1  | Traceback (most recent call last):
chat-app-1  |   File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/exec_code.py", line 88, in exec_func_with_error_handling
chat-app-1  |     result = func()
chat-app-1  |   File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 590, in code_to_exec
chat-app-1  |     exec(code, module.__dict__)
chat-app-1  |   File "/app/chat.py", line 135, in <module>
chat-app-1  |     if item.text:
chat-app-1  |   File "/usr/local/lib/python3.10/site-packages/google/generativeai/types/generation_types.py", line 454, in text
chat-app-1  |     if candidate.finish_message:
chat-app-1  |   File "/usr/local/lib/python3.10/site-packages/proto/message.py", line 906, in __getattr__
chat-app-1  |     raise AttributeError(
chat-app-1  | AttributeError: Unknown field for Candidate: finish_message

Actual vs expected behavior:
By reading the code from #527, I assume the expected behaviour would be to raise another error with the intended message
Any other information you'd like to share?
No response

This is the partial response that was returned that triggered this bug:
GenerateContentResponse(
    done=True,
    iterator=None,
    result=protos.GenerateContentResponse({
      "candidates": [
        {
          "finish_reason": "SAFETY",
          "index": 0,
          "safety_ratings": [
            {
              "category": "HARM_CATEGORY_SEXUALLY_EXPLICIT",
              "probability": "NEGLIGIBLE"
            },
            {
              "category": "HARM_CATEGORY_HATE_SPEECH",
              "probability": "NEGLIGIBLE"
            },
            {
              "category": "HARM_CATEGORY_HARASSMENT",
              "probability": "NEGLIGIBLE"
            },
            {
              "category": "HARM_CATEGORY_DANGEROUS_CONTENT",
              "probability": "HIGH"
            }
          ]
        }
      ],
      "usage_metadata": {
        "prompt_token_count": 121385,
        "candidates_token_count": 1,
        "total_token_count": 121386
      }
    }),
)

It looks like the safety violation should have triggered an error with a finish message, but the finish_message attribute is not present in the candidate instance, thus leading to the AttributeError: Unknown field for Candidate: finish_message bug

I faced the similar issue. Turns out that I was giving a prompt which was triggering a safety mechanism in the Gemini model. You have observed "finish_reason": "SAFETY" in response, indicating that the content generation was blocked due to safety concerns.
can you try simple prompt and send request again.

Hi @gabrielmdesidera, I'm encountering the same error. May I know how you get partial response when an exception occurs?

Hi, i have the same issue, and i tried to add this parameters in my code :
safety_settings={
                HarmCategory.HARM_CATEGORY_SEXUALLY_EXPLICIT: HarmBlockThreshold.BLOCK_NONE,
                HarmCategory.HARM_CATEGORY_DANGEROUS_CONTENT: HarmBlockThreshold.BLOCK_NONE,
                HarmCategory.HARM_CATEGORY_HATE_SPEECH: HarmBlockThreshold.BLOCK_NONE,
                HarmCategory.HARM_CATEGORY_HARASSMENT: HarmBlockThreshold.BLOCK_NONE
            }

I always got the same error.

https://github.com/google-gemini/generative-ai-python/pull/571


Setting title on FastAdapterBottomSheetDialog will/does not work.

Why do we have title setters in FastAdapterBottomSheetDialog class when the functionality will not work? Below code is taken from android source code:
public BottomSheetDialog(@NonNull Context context, @StyleRes int theme) {
        super(context, getThemeResId(context, theme));
        // We hide the title bar for any style configuration. Otherwise, there will be a gap
        // above the bottom sheet when it is expanded.
        supportRequestWindowFeature(Window.FEATURE_NO_TITLE);
    }

If we want to set title on a bottom sheet dialog, we may need to include a text view (for the title) in the custom view.

Feel free to open a pr that removes the setTitle methods inside the FastAdapterBottomSheetDialog. The code of the FastAdapterBottomSheetDialog used the FastAdapterDialog as an base.

Please open a PR.


feat: add plugin for flake8

Steps:

[x] Add flake8 entrypoint
[x] Handle ignore comments
[ ] Handle pyproject config
[ ] Update docs

Useful resource: https://flake8.pycqa.org/en/latest/internal/checker.html


print_result: add support of lists

It is now possible to print a list with a nice formatting.
Something like:
historyDataList          :
dataNumber           : 0
consumption          : 0.6610000000000003
cost                 : 0.0
averageSettingTemp   : 28.5
averageInsideTemp    : 26.52083396911621
averageOutsideTemp   : 30.18181800842285
dataNumber           : 1
consumption          : 0.08200000000000002
cost                 : 0.0
averageSettingTemp   : 28.5
averageInsideTemp    : 26.29166603088379
averageOutsideTemp   : -255.0

instead of:
historyDataList          : [{'dataNumber': 0, 'consumption': 0.001, 'cost': 0.0, 'averageSettingTemp': 28.5, 'averageInsideTemp': 26.0, 'averageOutsideTemp': -255.0}, {'dataNumber': 1, 'consumption': 0.001, 'cost': 0.0, 'averageSettingTemp': 28.5, 'averageInsideTemp': 26.0, 'averageOutsideTemp': -255.0},...

Any objection to this PR?
It is used for https://github.com/lostfields/python-panasonic-comfort-cloud/pull/11 to have a nice output.

it's great, but please look at my comment in #11 since I want a model transformation to make it ore future proof against api changes by panasonic.
maybe like it's done at https://github.com/lostfields/python-panasonic-comfort-cloud/blob/master/pcomfortcloud/session.py#L240 or something.

I can't find any comment in #11 except "overall this looks great :-)" https://github.com/lostfields/python-panasonic-comfort-cloud/pull/11#issuecomment-520308358

this PR was included in #11 right?

Exact. I close it.


Live-reloading config via Admin API fails due to the "one work_dir per HTTP server" rule

Repro for Caddy v2.8.4 and this module v1.0.5:
$ CADDY_ADMIN="localhost:2019" caddy run &

$ curl<EMAIL_ADDRESS>-H "Content-Type: application/json" http://localhost:2019/config/
{"error":"loading new config: loading http app module: provision http: server srv0: setting up TLS connection policies: loading client cert verifiers: position 0: loading module 'revocation': provision tls.client_auth.verifier.revocation: The same work dir ./crl was defined for multiple servers"}

Hm interesting. I will have a look at it on Monday. Might be a timing issue

A first code analysis did not reveal any issue. In theorie the cleanup should be called before another provision. I will try to debug this in the next days. How many servers did you have configured ? Only 1?

How many servers did you have configured ? Only 1?
Yes, that's only one server. I can try making a minimal config for reproduction.

yeah a minimal config could help. Currently i try to reproduce it and i already got a problem related to opening ports during reloading: Not related to revocation in general. I wonder if the provision/cleanup of modules in caddy is broken.
Which operating system are you on?


Readme update

README is missing instruction for running sample plugin #42

@philibm @transformationAdvisor-sdk Could you have a look at this please. Just a readme update so should be quick.

@geoghegk Hey Kieran, regarding
The `INSTALL_PATH` is the directory called `sampleData` in the `resources` folder and `DATA_DIR` is the `sample` directory in the `resources` folder.

The original idea behind those to arguments was to show a developer how to specify arguments in their plug-in. But the value of those arguments aren't actually used. All the data ('sample' and 'sampleData' directories) are already packaged in the jar file. So they're really dummy arguments - the value doesn't matter since it's not used but the user need to specify something. Maybe this is confusing so we could update the sample code to actually use the provided arguments the way you've documented.

@philibm I understand that. Are you looking at the wrong commit by any chance? I originally added the line: "The INSTALL_PATH is the directory call..." but then removed it when I discovered the sample wasn't actually using the values. Please check the latest change. I think it has cleared up any confusion for users.


Accessing non-default namespace service with mTLS enabled always results in "upstream connect error or disconnect/reset before headers" / 503 error

Describe the bug
Installed 1.0.6 via Helm chart with mTLS enabled.  First deployed httpbin and sleep sample services to default namespace, and verified (using curl) that requests sleep --> httpbin work as expected.  Next, created an auto-injected sidecar namespace called "foo" and deployed the same httpbin and sleep services to this new namespace.  Retried curl operations between sleep (primary container) and httpbin, but all requests failed with 503 Service Unavailable error with message "upstream connect error or disconnect/reset before headers".  However, when curl'ing via sleep "istio-proxy" container with certificate options, the request completes successfully.  It only fails when requests originate from non-proxy container.
Used both mesh-wide mTLS policy and *.local DestinationRule (confirmed OK via istioctl authn tls-check), as well as service-specific Policy and DestinationRule.  Neither fixed the errors.  Tried resetting Pilot as well, but no luck.  Only applications deployed to "default" namespace seem to work.  Confirmed in Kiali that default namespace service requests show the "security" badge.  Not seeing any errors in istio-proxy logs (even with trace-level debugging enabled), and istioctl proxy-config cluster (JSON output) details appear correct.
I confirmed that the same sample applications (httpbin, sleep) work as expected when deployed to default namespace.
Expected behavior
Curl requests from primary sleep container to httpbin service should be successful.
Steps to reproduce the bug
Download release 1.0.6 (https://github.com/istio/istio/releases/) and run Helm install:
helm install --name istio --namespace istio-system --set global.mtls.enabled=true,kiali.enabled=true,grafana.enabled=true,tracing.enabled=true ./istio
Create "foo" namespace:
kubectl create ns foo
kubectl label namespace foo istio-injection=enabled
Deploy sample httpbin and sleep applications:
kubectl apply -f <(istioctl kube-inject -f samples/httpbin/httpbin.yaml) -n foo
kubectl apply -f <(istioctl kube-inject -f samples/sleep/sleep.yaml) -n foo
Once pods are running, check service access between sleep and httpbin as follows:
kubectl exec <SLEEP_POD_ID> -c sleep -n foo -- curl https://httpbin.foo:8000/ip -v
Version
istioctl version
Version: 1.0.6
GitRevision: 98598f88f6ee9c1e6b3f03b652d8e0e3cd114fa2
User: root@464fc845-2bf8-11e9-b805-0a580a2c0506
Hub: docker.io/istio
GolangVersion: go1.10.4
BuildStatus: Clean
kubectl version
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.2", GitCommit:"cff46ab41ff0bb44d8584413b598ad8360ec1def", GitTreeState:"clean", BuildDate:"2019-01-10T23:35:51Z", GoVersion:"go1.11.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.4", GitCommit:"c27b913fddd1a6c480c229191a087698aa92f0b1", GitTreeState:"clean", BuildDate:"2019-02-28T13:30:26Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}
Installation
Via Helm chart from locally-cloned Git repo with 1.0.6 release tag (see specific deploy command above).
Environment
EC2, 5-node cluster
lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.5 LTS
Release:	16.04
Codename:	xenial
Cluster state
Attached istio-dump.tar.gz.
istio-dump.tar.gz
kubectl get nodes
NAME                     STATUS   ROLES    AGE     VERSION
k8sdemo1.cenx.localnet   Ready    node     2d18h   v1.13.2
k8sdemo2.cenx.localnet   Ready    master   2d18h   v1.13.2
k8sdemo3.cenx.localnet   Ready    node     2d18h   v1.13.2
k8sdemo4.cenx.localnet   Ready    node     2d18h   v1.13.2
k8sdemo5.cenx.localnet   Ready    node     2d18h   v1.13.2

Please note the issue only occurs when mTLS is enabled.  When mTLS is NOT enabled in this same cluster, services are able to communicate without error for any namespace (not just default).
I have also tried this same test with latest 1.1-rc2 and also tried without using the Helm chart (ie. just kubectl apply CRDs + auth-demo YAML).

I am surprised that it is not working.  I have a “4 point” debugging strategy.  Let's try the following to get more information.
Point 1 is the app itself. Verify that your service really exposes the URL you are trying by doing kubectl exec  -c istio-proxy -- curl localhost:80/
// 80 is the targetPort
Point 2 is the sidecar of the app. You have global.mtls.enabled=true. You can simulate an mTLS request coming into example-backend like this:
PODNAME=...
SERVICE=httpbin
NS=foo
SVCPORT=80
PATH=/example-backend/info
PODIP=$(kubectl get pod $PODNAME -o jsonpath='{.status.podIP}')
kubectl exec $PODNAME -c istio-proxy -- curl -v https://$SERVICE.$NS.svc.cluster.local:$SVCPORT/$PATH --resolve "$SERVICE.$NS.svc.cluster.local:$SVCPORT:$PODIP" --key /etc/certs/key.pem --cert /etc/certs/cert-chain.pem --cacert /etc/certs/root-cert.pem --insecure

If this works go on to point 3 by running the same test from the sidecar of frontend.
Point 4 is what you have already tried.  We need to see what is happening earlier.
Use kubectl get virtualservice,destinationrule --all-namespaces to make sure there isn't some configuration that is performing unexpected configuration.

Thank you for your recommendations to troubleshoot this issue.  I ended up entirely re-creating my cluster (via kubeadm), and re-deployed istio using the 1.0.6 Helm chart package.  I've just retried my simple sample sleep --> httpbin test using a namespace "foo" and it now appears to be working correctly:
kubectl exec sleep-69f8fcfdf6-kfpr8 -c sleep -n foo -- curl http://httpbin.foo:8000/ip
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0{
"origin": "<IP_ADDRESS>"
}
100    28  100    28    0     0   1866      0 --:--:-- --:--:-- --:--:--  1866
I will continue to test this out, and will use a more complex stack that includes Ambassador as well, just to make sure it's all working as expected...

OK, so after further testing I can confirm that the issue lies with deploying an operator that copies all secrets from "default" to any created / new namespace automatically.
I'm not yet sure why this is causing a problem, but once I deployed the operator, and recreated my test scenario, the service interaction started to fail between sleep --> httpbin.
$ kubectl exec sleep-69f8fcfdf6-mcn5k -c sleep -n foo -- curl http://httpbin.foo:8000/ip
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100    57  100    57    0     0   4384      0 --:--:-- --:--:-- --:--:--  4384upstream connect error or disconnect/reset before headers
$ kubectl get secret -n foo
NAME                  TYPE                                  DATA   AGE
default-token-nqqzs   kubernetes.io/service-account-token   3      3m2s
istio.default         istio.io/key-and-cert                 3      3m3s
myregistrykey         kubernetes.io/dockerconfigjson        1      3m3s
So this is interesting...

I suspect that the copied secrets are preventing Istio from creating secrets.
I predict that if you delete the secrets Istio will recreate them correctly.
Try:
kubectl -n <NAMESPACE> get secret istio.<SERVICEACCOUNT> -o yaml | grep cert-chain.pem | awk '{ print $2 }' | base64 --decode | openssl x509 -text -noout > before.txt
kubectl -n <NAMESPACE> delete secret istio.<SERVICEACCOUNT>
kubectl -n <NAMESPACE> get secret istio.<SERVICEACCOUNT> -o yaml | grep cert-chain.pem | awk '{ print $2 }' | base64 --decode | openssl x509 -text -noout > recreated.txt
diff before.txt recreated.txt

You can also try the same thing with "root-cert.pem" instead of "cert-chain.pem".

I'm curious about why do you want to copy the istio generated secrets to other namespace? Why not let istio to do this for you?

Copying the Istio secrets via the operator was as unintended side-effect -- the operator was originally used to copy other secrets between namespaces (eg. docker registry secret, for example), which was beneficial for my company's product stack deployment.  However, this interfered with the normal operation of Istio unintentionally.


Setting a goal for planner

Hi @MihirDharmadhikari thank you for great work.
I wonder that is it possible to set a navigation point for planner like geometric location ( lat, lon ) and stoping the planner when arrive ?

Hello @celikemir,
As gbplanner is an exploration planner it does not accept a goal to navigate to in unmapped space. However, if you have the robot explore and then want to plan to a point in the mapped space, you can use the functionality explained here.
Best,
Mihir

Hello,
There is a function in the code here that accepts a goal point and can plan a path to it in the known map. You can use this function for your task.
Best,
Mihir


generatePkcePair() cannot run in browser environment

Describe the bug
openid-client is a Nodejs library that is not mean to run in browser environments. Since it is technically possible that RP's generate their PKCE pairs on the frontend, our implementation of PKCE pair generation should not depend on openid-client.
To Reproduce

npm i @opengovsg/sgid-client in a React project.
import { generatePkcePair() } from @opengovsg/sgid-client in a .jsx/.tsx file.
Run const { codeVerifier, codeChallenge } = generatePkcePair()
App crashes, with the following error message in console:

Expected behavior
generatePkcePair() should run successfully and return <codeChallenge, codeVerifier> pair.

As discussed in https://github.com/opengovsg/sgid-client/pull/52, the team currently does endorse maintaining session details on the frontend, therefore as of now the team does not plan to support PKCE pair generation in the browser environment. If the user decides to do session management on frontend regardless, refer to https://www.npmjs.com/package/pkce-challenge.


:sparkles: Add a condition of clock sync.

Summary
Add a condition to represent whether the clock of hub and agents are synced.
Related issue(s)
Fixes #

/assign @qiujian16

/approve
/lgtm


Adds Enterprise Kapacitor docs

This PR is based of the kapacitor-enterprise branch so it should wait till #1168 is merged. Then I'll rebase off master and update this PR.
There is an issue with two Introduction options being present on the sidebar, I tried to fix it but not sure what I did wrong with the hugo headers.

Looks good! The sidebar behavior was just a case issue - the introduction identifier in index.md is all lowercase.


The length of the audio after noise reduction is shortened

Hello, I am looking for a fast noise reduction model, yours just meets my requirements, thank you for your efforts.
I'm using this model to do preprocessing for my speech recognition model. My processing process is to receive part of the audio through websocket, then denoise, then perform VAD, and then splicing the entire audio for speech recognition processing, so I perform denoising. Noisy audio is only part of an entire sentence.
My requirement is that multiple segments of audio after voice segment noise reduction can be spliced together perfectly, but after I use real_time_processing_tf_lite.py to process the sound, there will be blank parts in the spliced audio, causing the sound to freeze.
In the figure below, the upper part is the audio before processing, and the lower part is the audio after processing. It can be seen that the audio after processing is the same length as the audio before processing, but the part with waveform is shorter, so the two parts after processing Audio cannot be stitched together directly.
Can multiple segments of noise-reduced audio be spliced together perfectly? I'm new to coding and I'm not very familiar with it. Can you help me realize it?

Assuming you haven't changed the parameters in the code, so the block length is still 512 and the block shift is still 128 (75% overlap):
The enhancement process does not start at the start of the input audio, but zeros at about the length of 3 block lengths = 384 samples, and the input audio will slowly shift in and out of the input buffer 128 samples at a time, hence the extra silence at the start:

If you slice your audio without any overlapping, the reconstructed audio will have blank parts per sliced audio length. So try overlapping in your slicing, which can reduce the effect of the blank parts.

Here comes another problem
I tried cutting a complete wav into multiple segments and overlapping them, compared with directly inputting the entire wav file
If I execute real_time_processing_tf_lite.py every time
Generate new input_details_1, input_details_2, output_details_1, output_details_2, then my output waveform is always different from the input complete wav.
If I keep multiplexing input_details_1, input_details_2, output_details_1, output_details_2 as global variables, then if I capture the sound from the microphone and input continuously, after too much sample data, it seems that the final waveform will have a lot of noise
I understand that this program real_time_processing_tf_lite.py is used to process a long wav file, if I want to read the audio stream from the microphone and continuously perform noise reduction,
How should I modify it so that the noise reduction results of each short audio are consistent with the noise reduction results of the entire long audio?

用Pyaudio或者sounddevice实现，每次还是喂给模型512，每次替换512里面的256即可。


There is a vulnerability in spring  5.1.10.RELEASE ,upgrade recommended

https://github.com/baidu/brcc/blob/7785480fd3b90e62198c237623cec47d6dfab2e8/brcc-sdk/pom.xml#L32-L37
CVE-2020-5398  CVE-2020-5421
Recommended upgrade version：5.1.18.RELEASE

upgrade version to 5.1.18.RELEASE


Support undefined link syntax

:

and
(:)

and
()

Should be supported.
All above expressions should be equivalent to either:
(1: 1 1)

or
(1: 0 0)

or
(0: 0 0)

For Doublets, (should be configurable by LiNo interpreters, not the parser).

It can be useful to build short sets or nested structures that just have the same root, no matter which root.
:
  1
  2

() is now supported, it is essentially empty link with no id and values. The same goes for (:) and :.

It can be useful to build short sets or nested structures that just have the same root, no matter which root.
:
  1 2
  3 4

May be transformed to:
x: x x
x (1 2)
x (3 4)

This syntax conflicts with: #21

I think it is better to use line that ends with : and indentation as it described in #21


Split View into VBox and HBox

The layout prop for View is bad. Also it doesn't work, because it can't be changed after the first render.
We should remove View and replace it with two elements: VBox and HBox.

Done in #169


Add files via upload

Hey there!, Thanks for submitting a PR to this repo :smiley:
Please complete the following checklist for your PR to be approved. Mark the items by adding an x.
Example:  - [ ] Mark me as completed
To mark: - [x] Mark me as completed

[x] My Pull Request adheres to the Contribution guidelines.
[x] I have added problem.md and solution files in the appropriate folder
[x] In problem.md I have provided a correct link to the problem.
(In case you are not adding a problem, you can freely mark this as complete)
[x] My solution passes all the testcases within the given constraints.
[x] I have properly indented and documented my solution using comments.

If any of the above is unmarked, please make the necessary changes and then mark them so that you're PR can be approved and merged.
(Only completed checklist PRs will be reviewed)

I have updated it with comments in solutions. Could you please reconsider these?

@ArjunBhandari-666  Yeah now it looks good 👍 .
Also I'm really sorry I forgot to mention this earlier, could you please move this Math and strings problems folder into the Misc folder since the main folders are only for problems from their respective websites 😅

Yes sure, hold up!

I'm new to GitHub and I'm using a super old lappy, with Intel atom rn, so I can't clone a repo and I can't delete files in the web interface
Pardon me, but I'll be issuing a new PR
Please ignore all the old ones, I'm sorry!

@ArjunBhandari-666  That's alright, no worries 😄. I have merged your PR #429  👍
Closing this.


Missing data for format string 'open WAL %s'

See https://github.com/prometheus/tsdb/blob/e0aca4bee9ae472d1c164c5562eed2a4bf4c700a/db.go#L880: there is no value given for the %s, so it appears literally in the log output.

Oops, but luckily it is an easy fix. We just need to pass the folder name to %s.
Do you want to send a PR for that @ankon ?

I tried in #126, by looking at the surrounding code and guessing a bit that the directory parameter given in is probably more useful than the specific {dir}/wal calculated in the function :)