Update KafkaIO's docstring to match current implementation

Updating KafkaIO's documentation. It mentioned the KafkaIO.readAll() method, which never existed.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@ahmedabu98 is this ok to merge?

Yup, merging now


Remove inbound listeners

Another attempt at https://github.com/istio/istio/pull/21978/files

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
b827f07f93106d0c8c6845927a90fbe457ecc29b
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
4b325f2526384472e072ec7b5abecb78c12a5a84
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lambdai how will the get matched? If iptables is disabled?

There are examples creating standalone listener. These listener should be appended to the listener list.

 ingress:
  - port:
      number: 9080 # binds to proxy_instance_ip:9080 (<IP_ADDRESS>:9080, if no unicast IP is available for the instance)
      protocol: HTTP
      name: somename
    defaultEndpoint: <IP_ADDRESS>:8080
    captureMode: NONE # not needed if metadata is set for entire proxy


Line numbers in output should be one-based

If the check fails, record.Line is printed to stdout (Program.cs:142).  This property is zero-based (Inspection.cs:27).  But the output should be one-based instead as line numbers typically start at 1.

Thanks @krahlro-sick for reporting the issues #4, #5 and #6! I fixed them and bumped the version to the pre-release 1.0.0-pre2.


Once more the question on Apollo Kernel: is it really a indispensable dependence for real-car-running-on-road test environment?

In the open course give by @storypku titled as "Apollo-6.0-Infrastructure", the following description was given:

I checked the mentioned document and the relevant ones referred by it, but can't find any descriptions on the Apollo Kernel. Hence, I still can't figure out the problem: is it really a Indispensable dependence for real-car-running-on-road test environment?
Any hints will be highly appreciated?
Regards,
HY

Hi there,
Since Apollo kernel was based on an rather old  kernel, and many have reported errors in building it. So we removed the kernel installation section from Apollo Software Installation Guide. On real car running road test, RT kernel is indeed required. Am I right? @jinghaomiao @Capri2014

This issue is going to be closed. Should we have Apollo Kernel updated and ready, we will have everyone know. Please stay tuned.


Style checks on the Cron Job

It feels like the style checking mechanisms in our CI are not in sync with the Cronjob. I think it makes sense not to test for style in our Cronjob but the fact that they disagree is worrying. Worthy to investigate.
https://github.com/RasaHQ/whatlies/runs/1034192166

I think this issue could be closed now because it turned out the black was to blame (#186).


No way to supply initContainers in prometheus-operator

FEATURE REQUEST
Add initContainers to make it possible to initialize e.g. storage with hostPath to be able to set appropriate permissions.
Version of Helm and Kubernetes: helm, v2.11.0, kube, v1.12.1
Which chart: prometheus-operator, v0.1.12
What you expected to happen: be able to supply initContainers in similar way containers supplied.
This is what we have today:
{{- if .Values.prometheus.prometheusSpec.containers }}
  containers:
{{ toYaml .Values.prometheus.prometheusSpec.containers | indent 4 }}
{{- end }}

This is what needs to be added:
{{- if .Values.prometheus.prometheusSpec.initContainers }}
  initContainers:
{{ toYaml .Values.prometheus.prometheusSpec.initContainers | indent 4 }}
{{- end }}

Could it be closed?


Add Dokka plugin to exclude @Internal code from documentation

This PR introduces a new module dokka-extract-internal-plugin. It is a custom Dokka plugin to extract from documentation information about the @Internal code.
Dokka has several extension points at different stages of generating documentation. This new plugin injects a “transformer”(a term native to Dokka) at the stage when all code from source sets was collected and translated to internal Dokka representation Documentable. This “transformer” extends class which does all the “messy” job of different processing of modules, packages, types, etc. leaving to us only overwriting the criteria by which we should suppress(exclude) some Documentable’s.
Dokka automatically loads this plugin if it is present on the classpath. If your project already has Dokka, this plugin can be added via
dependencies {
    dokkaPlugin("io.spine.tools:spine-dokka-exclude-internal-plugin:${version}")
}

This repo is no longer only about Javadoc tools. Now it is doc-tools because more than one documentation tool is involved. So the REAMDE also was updated.

Close


Amend/resolver config cm

Reasons for change:

git-resolver-config-cm was not populating values that are necessary to auth with github. Amendments in this PR resolve the issue through manual customisation of the git-resolver-config template

the config map can now be managed via a values.yaml file on the cluster repo to configure

associated tekton-git secret with git-resolver-config-cm which will provide the github username and password upon creation of the secret via declaration on cluster repo values.

@msvticket

Do it the same way as for feature-flags-cm.yaml. That way upstreams changes will be imported. But I noticed that recent changes has broken the mechanism used for feature-flags-cm.yaml. So either fix that in this PR or wait for #51 to be merged.
Also you should update chart version.

@msvticket I am on this now and happy to bring changes over from https://github.com/cdfoundation/tekton-helm-chart/pull/51 for you to review together.
However, there are no changes to the git-resolver-config-cm.yaml to template the values (like feature-flags).
data:
    {{- toYaml .Values.featureFlags | nindent 2 }}

Can you add this to upstream please or inform me on how to do this?

@msvticket I am on this now and happy to bring changes over from #51 for you to review together.
I agree and will change amend git-resolver-config-cm.yaml to how feature-flags is.
However, there are no changes to the git-resolver-config-cm.yaml to template the values (like feature-flags).
data:
    {{- toYaml .Values.featureFlags | nindent 2 }}

Can you add this to upstream please or inform me on how to do this?

You can do it using kustomize. It's configured in charts/tekton-pipeline/kustomization.yaml

cool. Was already doing something like that already. Will push changes soon. Thanks :)


Use Common Protection API

Is your feature request related to a problem?
Different mods can handle protection differently, but if we standardize this under a common api we would have less protection-breaking exploits.
Describe the solution you'd like.
Implement https://github.com/Patbox/common-protection-api inside of the Factions mod
Describe alternatives you've considered.
I am planning to work personally on this and submit a pr, I need to study this mod's code more before working on it tho.
Other
No response

We use multiple types of events for claim protection to allow for individual permissions like using storage blocks and this API doesn't support that. Unless the API is updated we can't use it

This api is intended for mod-to-mod compatibility, as by itself it doesn't block anything. Main idea of it is for mods to check if they can do something, without requiring direct support (for example Universal Shops uses it to check for chest protection, Universal Graves for blocking creation in claims and like).


[spotweb] Own settings file

Spotweb
Where can i put my ownsettings.php file to use in this spotweb add-on?
Grtz
Modparts

Dear modparts, my understanding is that spotweb's dev consider that the ownsettings.php is deprecated (https://github.com/spotweb/spotweb/wiki/Frequently-asked-questions#i-have-upgraded-spotweb-but-now-i-get-an-error-about-needing-to-run-installphp)
There is therefore no designed way to do that in the addon
Are there benefits over performing a new install? I don't use the app myself so I don't see the impact. Thanks

Hello alexbelgium, Well I use the ownsettings.php file so NZBGet uses my Categories and Path's when i click on the green arrow inside spotweb to send a file to NZBGet.
this is the code in my ownsettings.php file:
<?php
$settings['ssloverride'] = true;
unset($settings['sabnzbd']['categories']);

# vertaal de categorieen uit spots (zie SpotCategories.php) naar sabnzbd categorieen
$settings['sabnzbd']['categories'] = Array(
        0    => Array('default'     => "Films",                # Default categorie als niets anders matched
                     'd11'        => "TV-Series",
                     'z3'         => "Erotiek"),
        1    => Array('default'    => 'Muziek'),
        2    => Array('default'    => 'Games'),
        3    => Array('default'    => 'Software')
    );

below a screenshot of 1 Category in NZBGet:

It should be easy to implement, I'll check in the next days!

I've pushed a new version allowing import of your settings. You need to place them in /config/addons_config/spotweb/ownsettings.php then restart the addon.
Could you please test and tell me how it goes ? Thanks

Thanx @alexbelgium,
I'm going to try it, i will let you know if everything works finebut this will take a little time because it takes a day or 3 to rztrieve the database.


Document telemetry captured along with comments

Make it easy to identify what information is captured.

[ ] Add comments to describe the event names
[ ] Add comments to each property

Prescribed solution

Update src/client/telemetry/index.ts
Example (or do feel free to do better):

    /*
    Telemetry event sent with details of Jedi Memory usage.
    memory - Memory usage of Process in kb.
    limit - Upper bound for memory usage of Jedi process.
    isUserDefinedLimit - Whether the user has configfured the upper bound limit.
    restart - Whether to restart the Jedi Process (i.e. memory > limit).
    */
    [EventName.JEDI_MEMORY]: { memory: number; limit: number; isUserDefinedLimit: boolean; restart: boolean };

Talk w/ PMs about maybe adding a marker in the comment to make it easy to programmatically extract details.

Telemetry items without comments:

[EventName.ENVFILE_VARIABLE_SUBSTITUTION] L.518:
https://github.com/microsoft/vscode-python/blob/e2b626b45ebf2ddeeb4a017fafdbe4109e5aafb4/src/client/telemetry/index.ts#L517-L518

[EventName.PYTHON_INTERPRETER_ACTIVATE_ENVIRONMENT_PROMPT] L.833 (but it is also defined on L.838 and has a comment there, so maybe move the comment up? the selection key has no comment either)
https://github.com/microsoft/vscode-python/blob/e2b626b45ebf2ddeeb4a017fafdbe4109e5aafb4/src/client/telemetry/index.ts#L832-L838

[EventName.INSIDERS_PROMPT] L.848:
https://github.com/microsoft/vscode-python/blob/e2b626b45ebf2ddeeb4a017fafdbe4109e5aafb4/src/client/telemetry/index.ts#L847-L848

[EventName.PYTHON_LANGUAGE_SERVER_TELEMETRY] L.951 and [EventName.PYTHON_EXPERIMENTS] L.952
https://github.com/microsoft/vscode-python/blob/e2b626b45ebf2ddeeb4a017fafdbe4109e5aafb4/src/client/telemetry/index.ts#L950-L952

[EventName.PYTHON_EXPERIMENTS_DOWNLOAD_SUCCESS_RATE] L.959:
https://github.com/microsoft/vscode-python/blob/e2b626b45ebf2ddeeb4a017fafdbe4109e5aafb4/src/client/telemetry/index.ts#L958-L959

[EventName.SIGNATURE] L.1033:
https://github.com/microsoft/vscode-python/blob/e2b626b45ebf2ddeeb4a017fafdbe4109e5aafb4/src/client/telemetry/index.ts#L1032-L1033


build(blockifier): add l2_gas_price to blockinfo

This change is

crates/gateway/src/rpc_objects.rs line 94 at r3 (raw file):
Previously, dorimedini-starkware wrote…
add the TODO here as well? (guessing it's related to the below discussion)

Added. This is a part of the mempool project. @elintul FYI


update readme to add the need for firebase-tools

I added a couple of lines to the readme that the firebase cli is needed

I signed the google permission thing

Well firebase-tools is in the dev dependencies in package json so I don't know why it did not install for me, but that negates the need for my suggestion of adding it to the read me, so closing.

firebase-tools is only installed locally. That makes it available in npm scrips (like npm run build and such)). But to be able to use it on the command line you need ./node_modules/.bin/ added to your PATH. Maybe that's missing on your setup?  (see this)
I'd be open to the idea of adding 2 npm scripts like npm run setup (which would run firebase use --add) and npm run deploy (which would run firebase deploy). Otherwise we could also remove firebase-tools from the dev-dependencies and keep your PR too :) (it seems more common for firebase developers to install the firebase CLI globally tbh)


Thanks!

Thanks!, I'm on it.


chore(IE8): add Object.freeze sham

Object.freeze is used in various places in our code and is not
polyfilled by polyfill.io (because not doable): https://github.com
/Financial-Times/polyfill-service/issues/232
So we "sham" it, which means that the API is here but it just returns
the object.
IE8 support still waiting for https://github.com/Financial-Times
/polyfill-service/pull/485#issuecomment-145880032

LGTM :+1:

LGTM


Support for EmitDefaults during JSON Serialization via toProto3Json()

The proto3 spec states:
A proto3 JSON implementation may provide the following options:

Emit fields with default values: Fields with default values are omitted by default in proto3 JSON output. An implementation may provide an option to override this behavior and output fields with their default values.

An example of this for the protoc-gen-go plugin is EmitDefaults option:
https://pkg.go.dev/github.com/golang/protobuf/jsonpb#Marshaler
I think it would be great if we could achieve this same functionality via the protoc-gen-dart plugin.
As far as I can tell, this functionality is not currently supported by this plugin.  Please confirm if that is the case.  If this functionality is not currently supported, I would like to look into adding it, as I think it could be a useful feature for other uses of the plugin as well.
Steps to reproduce:

Create a proto file:

syntax = "proto3";

message Money {
  string currency_code = 1;
  int64 units = 2;
  int32 nanos = 3;
}

Run protoc with the dart_out option to run the protoc-gen-dart plugin
protoc --dart_out=lib/src/generated -Iprotos protos/money.proto
Construct a message with the units field populated:

  final Money amount = Money.create()
    ..currencyCode = "USD"
    ..units = $fixnum.Int64.parseInt("1")
    ..nanos = 750000000;
  var json = jsonEncode(amount.toProto3Json());
  print('Serialized JSON: $json\n');

Observe that the serialized JSON contains this field:
{"currencyCode":"USD","units":"1","nanos":750000000}
Construct a message without the units field:

  final Money amount = Money.create()
    ..currencyCode = "USD"
    ..nanos = 750000000;

Observe that the serialized JSON does not contain this field:
{"currencyCode":"USD","nanos":750000000}

For our use case, this is problematic, because we'd like to store the serialized JSON into a jsonb field in Postgres, and with so many potentially missing fields, they jsonb queries can get very cumbersome.
Again, we're willing to contribute to the project to provide serialization of fields with default values as an option, but want to double check this isn't already available in the plugin, and just hadn't figured out how to do it.

Note: While testing a solution for this, I found that this package actually doesn't follow the spec as it is intended.  The spec states that: 'Fields with default values are omitted by default in proto3 JSON output'.  It also states that 'For strings, the default value is the empty string.'.  This package, on the other hand will emit the JSON key as long as the field was set.
Example 1 (currencyCode is set to 'USD', serialized JSON contains this key as expected):
  final Money amount = Money.create()
    ..currencyCode = 'USD' // String type
    ..units = $fixnum.Int64.parseInt("1")
    ..nanos = 750000000;

Output 1:
Serialized JSON: {"currencyCode":"USD","units":"1","nanos":750000000}

Example 2 (currencyCode is set to the Default value '', serialized JSON should not emit this key according to the spec, but it does):
  final Money amount = Money.create()
    ..currencyCode = '' // String type
    ..units = $fixnum.Int64.parseInt("1")
    ..nanos = 750000000;

Output 2:
Serialized JSON: {"currencyCode":"","units":"1","nanos":750000000}

Example 3 (currencyCode is never set, serialized JSON is as expected, and does not emit this key):
  final Money amount = Money.create()
    ..currencyCode = '' // String type
    ..units = $fixnum.Int64.parseInt("1")
    ..nanos = 750000000;

Output 3:
Serialized JSON: {"units":"1","nanos":750000000}


Introduce duplicate handling

potential duplicates could be shown together or highlighted or it could be a separate menu point.
you could find them by comparing email addresses or URLs.
this is because apparently people have entered their business in more than one page that we are getting data from
-> could be a growing problem

Duplicate of #131


Concurrency/Mutex Question

HI,
The line referenced below creates a mutex of global-scope that is only used in the runValidation function meaning that it essentially get shared across all running instances of the function.
Before i open a PR to move the mutex inside the runValidation function was there a reason behind making it global.
https://github.com/pb33f/libopenapi-validator/blob/696235ecd56ed0a28e34f28ae1e8ab3bf69eb0aa/validator.go#L319

Thanks @daveshanley - Is it safe to assume that the validator "as a whole" is reentrant; ie if I've built  and cached) a validator can I hit that instance concurrently from different go-routines

Thats the goal, yes :)

Thanks  for the response .. closing this issue


add 'run on gke' section

Add 'Run on GKE' section to new documentation

I have added the 'Run on GKE' section to new documentation as you suggested @pvlugter

This is a good start. The new operator has support for automatically provisioned Cloud SQL databases (ie, when you deploy a stateful store, it will provision a database for you), so at some point we should add how to configure that to here, but definitely not in this PR.


Is @persistent support possible?

I love this package, though, i have to use some workarounds when i need persistent parameters.
Is it even possible to have stored entity in @persistent annotated property  instead of id?
/** @var Book @persistent */
public $book;

public function renderDetail(Book $book)
{
  $book; // instanceof Book
  $this->book; // integer
}

Would it be possible to have instance of Book as well in $this->book?

Persistent parameter and method parameters have no common ground in this.
What's your goal?

Btw, I'm looking for a maintainer. Would you like to take over this project?


Revert "Build iOS apps using Swift Packages"

Reverts flutter/flutter#68361
Well that didn't last long.  microbenchmarks_ios workspace is corrupted?
[STDERR]            xcodebuild: error: The workspace named "Runner" does not contain a scheme named "Runner". The "-list" option can be used to find the names of the schemes in the workspace.

Merging to green the build.


Receipt testing

Run receipt testing (~monthly) to verify that notebooks are not producing out of date advice (future proofing)

Verify Jupyter Cell Output (cell testing)
Verification for correctness
Track any new deprecation warnings

Other considerations:

Compare output to NCL

Close in favor of #37


Don't use torch._six

This is a private API which is gone after https://github.com/pytorch/pytorch/pull/94709
🚨 Issue number
Fixed https://github.com/hpcaitech/ColossalAI/issues/2774
📝 What does this PR do?
Use inf from torch, rather than from torch._six
s/from torch._six import inf/from torch import inf/
💥 Checklist before requesting a review

[x] I have linked my PR to an issue (instruction)
[x] My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
[x] I have performed a self-review of my code
[x] I have added thorough tests.
[x] I have added docstrings for all the functions/methods I implemented

⭐ Do you enjoy contributing to Colossal-AI?

[x] 🌝 Yes, I do.
[x] 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

Awesome, thanks!


Failing on [Meraki] Device Name Missing

I am getting '[Meraki] Device Name Missing' on load
Loading output:
Loaded plugin 'homebridge-meraki-control'
[12/28/2020, 7:50:48 AM] Registering platform 'homebridge-meraki-control.Meraki'
[Meraki] Initializing Meraki platform...
[Meraki] didFinishLaunching
[Meraki] Device Name Missing

Config:
[
    {
        "platform": "Meraki",
        "devices": [
            {
                "device_name": "Meraki MR52",
                "host": "https://foo.meraki.com",
                "apiKey": "foo",
                "organizationId": "foo",
                "networkId": "foo",
                "wlanControl": 1,
                "refreshInterval": 10,
                "manufacturer": "Manufacturer",
                "modelName": "Model",
                "serialNumber": "Serial Number",
                "firmwareRevision": "Firmware Revision"
            }
        ]
    }
]

Meraki API Device Json Output
  {
    "name": "Meraki MR52",
    "serial": “foo”,
    "mac": “foo”,
    "networkId": “foo”,
    "model": "MR52",
    "address": “foo",
    "lat": foo,
    "lng": foo,
    "notes": “foo”,
    "tags": [],
    "lanIp": "192.168.x.x”,
    "configurationUpdatedAt": "2020-12-28T14:42:38Z",
    "firmware": "wireless-27-5-10",
    "url": “foo”
  }

Your config is wrong, use name instead device_name
[
    {
        "platform": "Meraki",
        "devices": [
            {
                "name": "Meraki MR52",
                "host": "https://foo.meraki.com",
                "apiKey": "foo",
                "organizationId": "foo",
                "networkId": "foo",
                "wlanControl": 1,
                "refreshInterval": 10,
                "manufacturer": "Manufacturer",
                "modelName": "Model",
                "serialNumber": "Serial Number",
                "firmwareRevision": "Firmware Revision"
            }
        ]
    }
]
``` `

Sorry I changed to device_name for troubleshooting. I changed back to name and I get the same results.

Are U using HOOBS?

Yes version 3.3.1

This is specific HOOBS problem, if U can move to Homebridge and Config-UI-X for 100% compatibility.
https://github.com/homebridge/homebridge-raspbian-image/wiki/How-to-migrate-from-HOOBS-to-Homebridge

You are right. I tested without HOOBS and it worked with no issues.

You are right. I tested without HOOBS and it worked with no issues.

I close this as solved.

I close this as solved.


[Bug]: S3 storage created even after failed validation

Description
I tried to create an S3 storage with CloudFlare R2. The first 5 attempts failed due to the URL already having the bucket name and the bucket name being appended to the URL again. The 6th attempt succeeded at validation. However, when I went back to the S3 Storages screen, I could see 6 storages, 5 not valid and 1 valid. The correct experience here should be that if validation fails, it should not create a storage at all.
Thoughts? Comments? Criticisms?
Minimal Reproduction (if possible, example repository)
Create an S3 storage with incorrect credentials and then fix them and hit create again. You should have more than one on the S3 Storage list page.
Exception or Error
No response
Version
v4.0.0-beta.134

Ah, good catch. Fixing in the next version!


changes label_from_text to use :visible_text instead of :text

Using b.text_field(label: /some text/) threw a deprecation warning about using :text instead of :visible_text.  Updating the label_from_text function to use :visible_text fixes this issue.

We should only do that in case of regular expression. Can you confirm that we still use text: selector when we pass string to label: selector?

@p0deje the label_from_text function is not being called when using label: ''something'. So, :visible_text is only used the :label is called with a regular expression.
@jkotests I would agree that the deprecation warning itself might not be as expected. The difficulty being that the deprecated function received new, non-deprecation, functionality. However, I don't think that's relevant for this case, where you want to select an input element by the text of a label.
Then again, if you want to drag this distinction over to the :label selector, there should be different selectors, like :label and :visible_label. But once you start doing that, you can continue with :label_title and :label_custom_attribute. I don't think that's the goal of this selector. All in all, I think it's okay to say, "When using a regular expression on the :label selector, you look for :visible_text on that label". But it's your call, I just wanted to get rid of the deprecation spam :-)

The changes seem reasonable to me, but since we're slightly changing the behavior, do you mind adding a test for it? Something around these expectations and this HTML file.

Added specs for the changed behaviour.

So, I agree that it is the wrong error message, but the reason there is a deprecation notice there is because we're looking to change the behavior. Presumably browser.text_field(label: /With text/) passes now, and will fail when we update the code.
So, either it needs a different deprecation warning, or we need to make a change to how we are locating elements with labels.

I think the right answer is to create a :visible_label key, even though that might be a pain.
I so want to spend some time simplifying this location code in general, this is all kind of... inelegant. :-/
@jkotests how close did you get with what you were working on earlier this year?

@titusfortner, I got pretty close. Still a bit inelegant with lots of areas for improvement, but there are less branches in the code.
What blocked me from pushing was a failing spec for an element going stale during lookup (element_spec.rb). Looking at the failing test again, it looks like the existing code doesn't completely handle the scenario either - see Issue #718.
I can revert my changes that minimized the usages of the Selenium locators, which should fix this failing spec. We won't get as much performance gains, but at least the simplified code could be made available.

I have some other ideas to improve performance, we just really need to reduce the conditionals and branching. :)

In general, I expect people will be using :text over :visible_text for locating any element. :text can be more performant and it is easier to write. Therefore, I think :label should also default to :text (ie non-visible text).
To allow for backwards compatibility, what if we allow :label to accept a Hash argument (just like any other element locating)?
browser.text_field(label: /some text/)                  #=> matches against label's non-visible text
browser.text_field(label: {visible_text: /some_text})   #=> matches against label's visible text

This would avoid needing to add extra locators. It would also allow locating the label by any supported locator.

Hmm, I'm not sure how I feel about nested hashes here. Let me post an alternative PR and we can see if it makes sense to maintain.

Closing because PR https://github.com/watir/watir/pull/746 fixes the issue in a different (more streamlined manner)


Can I use material UI and Bootstrap UI combined?

How to use material date picker and file input in a dynamic form
As there is no option for file input in the material theme I am not able to add file input.
while adding bootstrap theme material theme is not working

Yes possible.


Armatures not exported with parent type "Bone"

Describe the bug
I am not sure if this is a bug or the nature of the glTF format. I can't export mechanical armatures (no deformation, just parent relations to bones) correctly. Re-importing the file replaces the armature with an empty. Also other tools (https://sandbox.babylonjs.com/) don't recognize this skeleton.
The provided Blender file contains two skeletons (one with parenting and one with deformation). But only the second one can be imported back or used by Babylon.js.
To Reproduce
Steps to reproduce the behavior:

open Blender
add an armature
add a mesh object
parent the object to the bone of the armature
Export to glTF with default settings.

Expected behavior
I expect, that i can re-import/use this armature of the exported model.
.blend file/ .gltf
armatures.zip
Version

OS: GNU/Linux
Blender Version: 2.92.0-ab9952e55fe1-linux64

I think this behaviour is ok.
There is no "bone" in glTF, only nodes. Nodes are used as bone when there is a corresponding weight information linked to it.
When using "Parent to bone", there is no weight, so bone is, in glTF, a regular node.
Except using extra custom info to store info in glTF, and using it again when importing, I can see at first any way to perform it. But this is only a workaround that will work when exporting from Blender and re-importing it again with Blender.
Not sure this is something really useful.
Any thought?

Except using extra custom info to store info in glTF, and using it again when importing, I can see at first any way to perform it...

I'd be nervous about this; it may lead to other software adopting the custom info in inconsistent ways. Might be possible to have the exporter write a skin referencing these nodes as joints, without a mesh weighted to them. I'd need to look more closely at the spec and validator to say if that's allowed. But even that could get messy, because if any bones in the armature are weighted to parts of the mesh, the mesh must include those extra bones in its joint index offsets. 😕

Thank you.
i found a workaround for my case. If i add one simple mesh with deformation weights, the whole skeleton of my model (40 bones) gets exported and imported as expected without blowing up the file size with weight data.


Dark theme text unreadable

Is it an actual bug?
Yes
Did you check if the bug has already been reported?
Yes
Describe the bug
The text is unreadable in dark mode when adding a new task. It is dark grey, nearly black.
To Reproduce

turn on dark mode
press N to start adding a new task

Expected behavior
The text should be white
Screenshots

Desktop (please complete the following information):

OS: MacOS 12.21
Version of sleek: 1.1.8
Source: Github

@mshuflin could you please take a look at https://github.com/ransome1/sleek/releases/tag/v1.1.9 if this fixes it for you?
Thanks for reporting it.

@ransome1 It is working as expected now. Thanks for fixing that!


Question for RBW Aligner

would you mind describing the format of the alignments more specifically?
::alignments 0-1.1.1 1-1.1.2 3-<IP_ADDRESS>.2.1 4-<IP_ADDRESS>.1.1 5-1.1

It's the standard AMR alignment format from the docs, which is {token number}-{Gorn Address}
The AMR3 docs have a full description of it here.

Thank u for your relply! It really helps!
But, is there a good way to get the alignment from the penman_graph (after aligned) ?

I'm not sure what you're asking.  After you align the graph it will have the alignment string in the metadata (as you show above) and the surface alignments (ie... node~e.2) in the graph.
The penman_graph object comes from the penman library so you might look in that lib if you need to manipulate that object or extract other information.  If you just want access to the string do something like
align_string = penman_graph.metadata['alignments']

I find it in the Penman Docs. Thank u for ur kind suggestions! It really helps!
alignment = surface.alignments(penman_graph)


Fix typos

Just fixed some typos that I noticed during setup

I’m perfectly fine with the license change. Thanks for sharing your work!

Just one note, after merging this you will need to regenerate docs. I’ve tried doing this too, but probably my mdbook version is too different and it produces too many changes.

Up until now I did all these things locally and have not set up github actions yet.
I will re-generate the docs with the next PR tomorrow, thank you.


Fixed ESLint errors

#2698  👈
#2695
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatChen and the rest of your teammates on  Graphite


Build does not work

I have tried to make a build, but it failed. I tried as described in install.md (https://github.com/omapsapp/omapsapp/blob/master/docs/INSTALL.md).
Im running on Ubuntu 18.04 and configured the repository as opensource build.
Building only the generator_tool did not work. Find attached the log.
I put also errors in the file that i could find (except those in the last 100 lines iof the log). errors i found.txt
log omaps.txt

`-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads - not found
-- Found OpenGL: /usr/lib/x86_64-linux-gnu/libOpenGL.so
Doing nothing, because we know nothing about developer frameworks dir
-- Looking for dlfcn.h
-- Looking for arc4random_buf - not found
-- Looking for off_t - not found
-- Looking for size_t - not found
You have called ADD_LIBRARY for library shaders without any source files.


Refator OS installation progress

Add the progress milestones definition into task options, now all milestones value are defined in single place, thus avoid the potentially divergence.
Prepare the milestone URIs which can be directly referenced by install scripts
Refine the milestones definition, add Pre/Post OS configuration milestones.

jenkins: depends on https://github.com/RackHD/on-http/pull/591
@pengz1 @lanchongyizu

BUILD on-tasks #2024 : ABORTED

** BUILD build-config-setup  #1856: SUCCESS

** BUILD unit-tests  #11866: SUCCESS

** BUILD Install-Ubuntu-14-04  #479: SUCCESS

** BUILD SmokeTest-FIT  #516: SUCCESS

** BUILD SmokeTest-CIT  #710: SUCCESS

** BUILD Install-CentOs-6.5  #501: ABORTED

** BUILD on-taskgraph #2117: SUCCESS

** BUILD build-config-setup  #1857: SUCCESS
** BUILD unit-tests  #11867: SUCCESS

** BUILD on-http #3308: SUCCESS

** BUILD build-config-setup  #1858: SUCCESS
** BUILD unit-tests  #11868: SUCCESS

:+1:

BUILD zon-core #41 : FAILURE

*** BUILD zon-core #44 ***

BUILD zon-core #45 : FAILURE

BUILD zon-core #46 : FAILURE

BUILD zon-core #47 : SUCCESS


chip-tool: add more flexibility in PAA root folder selection

Problem
chip-tool currently can only select a PAA root folder by command line argument. This presents an integration problem in various existing certification tools since a large amount of calls in several scripts would need to be changed. Instead there is a need for more flexibility in specifying PAA root folder which only requires a backwards compatible change to chip-tool.
Proposed Solution
The following to be applied to chip-tool if --paa-trust-store-path is not given:
if ~/paa-root-certs exists use that
else if environment variable PAA_ROOT_CERTS exists use that

Assigned to @kpschoedel, he may have time within the next few days. Otherwise we will reassign.
I would recommend against ~/paa-root-certs -> this can be achieved by having PAA_ROOT_CERTS environment variable set to ~/paa-root-certs in the shell's profile by default, which would avoid special casing.

yes, PAA_ROOT_CERTS should be sufficient


goToIndex inconsistent behaviour

Describe the bug
Not sure if related to https://github.com/dohooo/react-native-reanimated-carousel/issues/185 but with a similar setup to what's described in that issue, it seems like goToIndex works nicely going backwards but e.g. calling goToIndex(1) from index 0 goes to index 2 in the array and animates in the wrong direction...you can briefly see this happening in this gif
To Reproduce
Steps to reproduce the behavior:

Render a carousel like:
<Carousel
width={300}
height={150}
data={[1, 2, 3]}
onSnapToItem={(index) => console.log(index)}
renderItem={({ item }) => (
<Image
style={{ width: 300, height: 150 }}
source={{
uri: 'https://images.unsplash.com/photo-1648737154547-b0dfd281c51e?ixlib=rb-1.2.1&ixid=MnwxMjA3fDF8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8&auto=format&fit=crop&w=1740&q=80',
}}
/>
)}
/>
Add call carouselRef.current.goToIndex(1) programmatically or with a button and note that it goes to final index with the incorrect animation

Additional context
React native web

@dohooo Any update on this issue?

@dohooo Any update on this issue?

Also While changing the index programmatically. its just changing the Item to what ever index is.
It should animate the card to left or right just like if we manually swipe the card.

Also While changing the index programmatically. its just changing the Item to what ever index is.
It should animate the card to left or right just like if we manually swipe the card.

Is that what you mean? Add animation when you switch to any index by programmatically?

Try this code.

@dohooo this still doesn't work for me...has this behaviour with 3 data points:
scrollTo({ count: 1 }) from index 0 goes to index 1
scrollTo({ count: 1 }) from index 1 goes back to index 0
scrollTo({ count: 0 }) from index 1 just stays on index 1

though i can just use the ref.current.next vs ref.current.prev which work perfectly - cheers!

In my case, I want to use dynamic index everyTime so i cannot use scrollTo function because it takes static count.
Is there any alternative to scroll to specific index??

@dohooo Any update on this feature request? Please


Variations Support

Adding support for variations in terrain_textures.json would be nice to not have hundreds of yellow lines to have variated textures.
Some info about it:
https://compass.minecraft.partners/hc/en-us/community/posts/360037639334

Coming soon to the lastest update 1.2.8


Update README.rst to add MIT license badge

Codecov Report
All modified lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:loudspeaker: Thoughts on this report? Let us know!.


Add created and last login timestamp to admin/users

And first/last name

If it's okay while you're in there adding properties:
.firstName
.lastName
.displayName (new!)
We might use displayName in feed


You have missing dependencies

Description
What steps will reproduce the problem?

when the spyder starts, the reminder occurs in a window.
 This problem is already fixed.
To get the new version with the fix, please open Terminal and run the following commands:
conda remove --force spyder
conda install -c conda-forge spyder

Please do that and let us know if it works for you.

Hey @mengqh321, thanks for reporting. This problem is already fixed.
To get the new version with the fix, please open Terminal and run the following commands:
conda remove --force spyder
conda install -c conda-forge spyder

Please do that and let us know if it works for you.

Hi Carlos,
Thanks a lot. This problem has been resloved following your instructions.
But it seems occupy to much CPU% when it starts after the reinstallation.
Thanks very much for your help!
Best wishes,
Qinghui Meng
At 2021-01-11 06:54:26, "Carlos Cordoba"<EMAIL_ADDRESS>wrote:
Hey @mengqh321, thanks for reporting. This problem is already fixed.
To get the new version with the fix, please open Terminal and run the following commands:
conda remove --force spyder
conda install -c conda-forge spyder
Please do that and let us know if it works for you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi Carlos,
Thanks a lot. This problem has been resloved following your instructions.
But it seems occupy to much CPU% when it starts after the reinstallation.
Thanks very much for your help!
Best wishes,
Qinghui Meng
At 2021-01-11 06:54:26, "Carlos Cordoba"<EMAIL_ADDRESS>wrote:
Hey @mengqh321, thanks for reporting. This problem is already fixed.
To get the new version with the fix, please open Terminal and run the following commands:
conda remove --force spyder
conda install -c conda-forge spyder
Please do that and let us know if it works for you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Great!

Great!


Implement new topbar

Move "Rollup Explorer" to first position

Both

can we increase the spacing between the links? and the spacing between the summary titles as well?
can we make the link text bolder?

Desktop

can we highlight the entire rectangle instead of underlining the text when hovering?
can we set the unfold icon to rotate 180 degrees compared with the fold icon, instead of moving it down a little?
can we align the divider aligned with link text?

Mobile

can we exchange the fold and unfold icon?

Uncertain But Concerned

can we remove the outer orange border and add box shadow and apply a lighter background color? [Desktop]
can we remove the outer gray border and make the divider between the summary title full screen?  [Mobile]

applied unified page header on blog/team page

Suggestion:
Reverse the arrow when the drop down is expanded such that the arrow points up vs when the drop down is unexpanded the arrow points down

can we highlight the entire rectangle instead of underlining the text when hovering?

Thanks, looks even better now! :)
can we highlight the entire rectangle instead of underlining the text when hovering? -> this is still pending as far as I see, and in particular, at least on desktop, it's still possible to tap a row such that the menu will be dismissed - instead of navigating to the target; e.g.:

I think this is ready to deploy as is. @OrestTa I see your point with regards to feedback, but let's go for the 80/20 to deploy here ASAP. https://zksync.io/ also changes the text color, and if folks find it confusing on desktop they can just hit return.


grew windows CI timeout

see @jcwchen advice in issue #2481

with windows-2022 I encountered this error in step "Install onnx-mlir" in Windows-CI.yml
-- Build files have been written to: D:/a/1/onnx-mlir/build
ninja: error: 'C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/DIA SDK/lib/amd64/diaguids.lib', needed by 'Release/bin/onnx-mlir.exe', missing and no known rule to make it

any suggestions how to overcome this are welcome

Building llvm from scratch with windows-2022 in this PR might help.

ok, I changed $mlir_tag to not use the windows-2019 artifacts but then it fails building llvm-project:
[183/4217] Building IntrinsicsLoongArch.h...
FAILED: include/llvm/IR/IntrinsicsLoongArch.h D:/a/1/llvm-project/build/include/llvm/IR/IntrinsicsLoongArch.h
cmd.exe /C "cd /D D:\a\1\llvm-project\build && D:\a\1\llvm-project\build\bin\llvm-min-tblgen.exe -gen-intrinsic-enums -intrinsic-prefix=loongarch -I D:/a/1/llvm-project/llvm/include/llvm/IR -ID:/a/1/llvm-project/build/include -ID:/a/1/llvm-project/llvm/include D:/a/1/llvm-project/llvm/include/llvm/IR/Intrinsics.td --write-if-changed -o include/llvm/IR/IntrinsicsLoongArch.h -d include/llvm/IR/IntrinsicsLoongArch.h.d"

it looks like llvm-min-tblgen.exe fails but I don't know what goes wrong or how to overcome that

Sorry I should confirm it earlier and thank you for trying it out.

no problem

I guess the least thing we can do right now is simply increasing the timeout a bit?

ok, I reverted the vmImage upgrade from this PR - please approve if you agree with the change
I would love if you can find another solution to make the Windows CI run faster - it is typically the slowest of the CI pipelines and therefore slows down onnx-mlir development

Jenkins Linux amd64 Build #12689 [push] grew windows CI timeout ... started at 14:05

Jenkins Linux s390x Build #12712 [push] grew windows CI timeout ... started at 15:05

Jenkins Linux ppc64le Build #11705 [push] grew windows CI timeout ... started at 15:14

Jenkins Linux amd64 Build #12689 [push] grew windows CI timeout ... failed after 1 hr 9 min

Jenkins Linux s390x Build #12712 [push] grew windows CI timeout ... aborted after 1 hr 29 min

Jenkins Linux ppc64le Build #11705 [push] grew windows CI timeout ... aborted after 1 hr 29 min


Validate app engine project IDs

In new app engine wizard, show some sort of error when user has typed an illegal App Engine Project ID such as one that contains spaces.
First, figure out if App Engine has documented this anywhere. A quick google search doesn't find it so I'm not sure what is and is not illegal.

From the Developers Console when using a period
Project name has invalid characters. Enter letters, numbers, quotes, hyphens, spaces or exclamation points.


Add support for setup/teardown commands

Fixes #25

Thanks for adding this feature!  Unfortunately, it's not yet doing what I hoped for.
bench 'stack clean; stack build' gives time                 6.467 s
bench --before 'stack clean' 'stack build' gives time                 381.9 ms
I would expect the latter to be about the same as the former, maybe ~0.3 s less because it doesn't include the cleanup time.  I think < 400 ms means that most runs of stack build find that nothing needs to be rebuilt.
Looking at the Criterion docs, maybe perRunEnvWithCleanup would do what I want?  I can test that later this week.  I'm not sure how likely it is that other users of bench would want the behavior in this PR, or other variations.

@bergey: I will use perRunEnvWithCleanup.  I just misunderstood what envWithCleanup did and I think most users will want the clean up between each run

I had to make a few more changes to get this to compile.  With those changes, it does what I hoped.

Whoops!  I thought I had built the branch before pushing.  Thanks for the fix, which I've included now


Most recent OSRS update broke plugin

Xp drops no longer display damage, and runelite displays "incompatible" error over

There is a pull request that fixes this already. I'll most likely get to it tomorrow


Interfacebuilder failed to render

Hi,
i have a Problem with the current version.
The Interfacebuilder can't render the ViewController where the EHHorizontalSelectionView is in.
I tried removing the class from the IB Object and it worked again.
Please help.
kind regards, Felix
pathToStoryboard/Main.storyboard: error: IB Designables: Failed to render and update auto layout status for ViewController (XXX-XXX-XXX): Failed to load designables from path (null)

i made a workaround subclassing EHHorizontalSelectionView
`import UIKit
import EHHorizontalSelectionView
@objc class HorizontalSelectionView: EHHorizontalSelectionView {
}`


Feature request: auto start Tmux

Can you add a Tmux module to auto launch Tmux at startup like this one: https://github.com/sorin-ionescu/prezto/tree/master/modules/tmux ?

The auto launch code from Prezto that is mentioned does not work in MacOS, as discussed in https://github.com/sorin-ionescu/prezto/issues/62.

I'm also okay without adding this functionality.

Got it, thank you guys for resolving my issue with an explanation!


Padding & margin tweaks need to be made

I plan on cleaning up the padding so that things display more uniformly. This looks off to me:

Fixed!


[Autocomplete] types break when having multiple default values

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example: https://codesandbox.io/s/wrong-types-in-autocomplete-with-multiple-default-values-b5qtpu
Steps:

Use an Autocomplete component with the following props
a. multiple
b. options passing an array of objects
c. defaultValue passing an array of objects of the same type as the options
See type errors.

Current behavior 😯
Functionality works as expected.
Type error thrown: Type 'T[]' is not assignable to type 'readonly T[][]'.
Expected behavior 🤔
No type error should be thrown, since the passed values are correct. It should not expect an array of arrays.
Context 🔦
The goal is to have an array of default values that has the same type as the array of options.
Your environment 🌎

npx @mui/envinfo
  System:
    OS: macOS 12.0.1
  Binaries:
    Node: 16.10.0 - ~/.nvm/versions/node/v16.10.0/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 7.24.0 - ~/.nvm/versions/node/v16.10.0/bin/npm
  Browsers:
    Chrome: 107.0.5304.110
    Edge: Not Found
    Firefox: Not Found
    Safari: 15.1
  npmPackages:
    @emotion/react: ^11.10.5 => 11.10.5
    @emotion/styled: ^11.10.5 => 11.10.5
    @mui/base:  5.0.0-alpha.105
    @mui/core-downloads-tracker:  5.10.13
    @mui/material: ^5.10.13 => 5.10.13
    @mui/private-theming:  5.10.9
    @mui/styled-engine:  5.10.8
    @mui/system:  5.10.13
    @mui/types:  7.2.0
    @mui/utils:  5.10.9
    @types/react: ^18.0.25 => 18.0.25
    react: ^18.2.0 => 18.2.0
    react-dom: ^18.2.0 => 18.2.0
    typescript: ^4.8.4 => 4.8.4

tsconfig.json
{
  "compilerOptions": {
    "target": "es5",
    "lib": [
      "dom",
      "dom.iterable",
      "esnext"
    ],
    "allowJs": true,
    "skipLibCheck": true,
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "strict": true,
    "forceConsistentCasingInFileNames": true,
    "noFallthroughCasesInSwitch": true,
    "module": "esnext",
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "noEmit": true,
    "jsx": "react-jsx"
  },
  "include": [
    "src"
  ]
}

@wormple12 It looks like TypeScript is inferring the type incorrectly. The whole Film[] is getting inferred as T type and thus T[] gets evaluated to Film[][]. As a workaround you can explicitly define generic types to component:
<Autocomplete<Film, true>
  multiple
  options={options}
  defaultValue={multipleDefaultValues}
  isOptionEqualToValue={(o, v) => o.title === v.title}
  getOptionLabel={(o) => o.title}
  renderInput={(params) => <TextField {...params} />}
/>;

OR, inline the default values:
<Autocomplete
  multiple
  options={options}
  defaultValue={[options[0], options[1]]}
  isOptionEqualToValue={(o, v) => o.title === v.title}
  getOptionLabel={(o) => o.title}
  renderInput={(params) => <TextField {...params} />}
/>;

@samkevin1 Yes you can try it out. I am not expert in TypeScript, but I think this is a limitation of TypeScript.

yeah I was taking a look but couldn't find a solution. It could be a limitation of TypeScript, but there should be some workaround to make it work properly.

Hi @ZeeshanTamboli and @samkevin1, can I make a pr for this issue? Seems like I find out how to fix it.

@fenghan34 yeah go for it

FYI: It seems that this implementation was released in https://github.com/mui/material-ui/releases/tag/v5.10.16. Thank you all.


[2328] Update support online chat link

Context
🚢
Changes proposed in this pull request
🚢
Guidance to review
🚢

 update chatbot link


validation - dataset

in the validation of datasets, the edit button next to the "assignments" is not clickable

#163


[dv,flash_ctrl] Initialize data for flash_ctrl_read_word_sweep

Write to the locations that will be read to avoid errors and to have non trivial data values. This fixes some occasional failures.

The failures are unrelated. Merging this.


Vulnerability roundup 84: hunspell-1.7.0: 1 advisory

search, files

[ ] CVE-2019-16707 CVSSv3=6.5 (nixos-20.03)

Scanned versions: nixos-20.03: 82b5f87fcc7. May contain false positives.

See also: #73651

20.03 is Frozen and EOL.
As such, issue is closed.


[ES Temperature] Not detecting temperature in "37ºC"

Describe the bug
I run all recognizers over "Temperatura 37ºC". 0 results in Temperature, but also in number.
To Reproduce
This simple code shows "Found 0 results".
            string txt = "Temperatura 37ºC";
            var results = Helpers.ParseAll(txt, "es-es").ToList(); // Get ALL recognizers on the text

            Console.WriteLine("Found {0} results.", results.Count);

Where Helpers.ParseAll is the very same ParseAll in your samples (here: Recognizers-Text/.NET/Samples/SimpleConsole/Program.cs), just moved into a Helpers class.
Expected behavior
Since [number]+ºC is a standard way of writing Celsius degrees, it should be recognized.
Platform (please complete the following information):

Platform:  .NET Core 3.1
Environment: Console app
Version of package: 1.8.2

Technically this is not a correct case as that's the upperscript o, not the degree symbol. But we do understand that in informal cases this can be a common usage (in PT too). It should be easy to extend support if it doesn't introduce any negative side effect.

Yes indeed, I'm working with lots of real world cases and "º" (upperscript) is almost the only one used out there, since "°" (ALT+0176) is way too unknown to people. So yes, extending the support to upperscript will make it much more usable.
Thank you.


Split misc_part3 into two CI jobs to speed up CI times

Fixes #1413.
Once merged, we should adapt the branch protection rules for main to reflect the new job names.

Running the tests again, but the initial runs indicates that the overhead by the split is considerable and that the savings are moderate. I'll post numbers after at least a second run.

Alright, here are the run times (for compactness I put the new numbers and the old numbers in the same table, the trials are of course independent):

Trial
Time 2D [min]
Time 3D [min]
Total time [min]
misc_part3 [min]

1
75
98
173
130

2
71
132
203
148

3
56
99
155
145

4
51
122
173
149

5
71
97
168
148

6
-
-
-
145

7
-
-
-
160

Summary of the table:

It seems like from this PR we will get an increase of the total CI time on average by roughly 20 minutes.
The maximum duration one has to wait for all jobs to finish (assuming they run in parallel and are started simultaneously) is decreased by between ~20 minutes (worst case) and 50 minutes (best case).

My personal conclusion is thus to merge this, since in many cases it seems to considerably speed up CI cycle time.


Add pico proxy to the ISAAC launchfile

Actually this should even be in the astrobee repo as well. If the haz cam is meant to take pictures, it should as well decode properly the depth right away. We need to do that for ISS work, and I don't know if we will ever install isaac on the ISS. Having pico_proxy only for isaac looks of limited value to me.

ISAAC is already installed on the ISS. I don't think the obstacle detection requires pico_proxy, so the default Astrobee software doesn't need it?

I am not sure what the default astrobee software does with the depth camera.

This was done in the latest ISAAC release for the ISAAC3 activity. This was tested in the lab and in space


[Bug]: Output of bazel lint //... is truncated, can't see linters errors in terminal

What happened?
When running bazel lint //... the output of the command seems truncated e.g.
...
Analyzing: 141 targets (0 packages loaded, 0 targets configured)
[0 / 1] [Prepa] BazelWorkspaceStatusAction stable-status.txt
From //lib/aws_utils:aws_utils:
INFO: Analyzed 141 targets (0 packages loaded, 0 targets configured).
[1 / 2] checking cached actions
...
...

In the output above the From //lib/aws_utils:aws_utils line I believe should be followed by the linting errors produced by linting that target. In practice, it seems like the output is overwritten / hidden. If I check bazel-bin/lib/aws_utils/flake8.aws_utils.aspect_rules_lint.report I can find the linting error and go and fix it. The issue I found though is that sometimes even the From //path/to/target line is ommited so it becomes difficult even knowing which targets contain linting errors as you would have to go through all the *.report files generated by the linting tool and check which ones are empty and which ones are not.
I was wondering, is there any way to stop this truncation from happening and have the bazel lint //... command have the behaviour where on each run it prints all the linting errors of all targets?
Version
Development (host) and target OS/architectures: Ubuntu 18.04
Output of bazel --version: aspect 5.9.7
Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: aspect_bazel_lib 1.38.0, aspect_rules_lint 0.12.0
Language(s) and/or frameworks involved: The linting is configured with only flake8 as a linter for Python 3.12
How to reproduce
No response
Any other information?
No response

Found that adding build --color=no to .bazelrc fixes this issue. An issue still remains that the output of the bazel lint //,,, command is quite large as it contains all the bazel build output as well.


EasingDoubleKeyFrame docs should mention the default easing function

I noticed that in a XAML app, if you create an animation with an EasingDoubleKeyFrame but don't specify an easing function via the EasingFunction property, the system applies a default Bezier curve. This was unexpected since you would expect a linear ease in this case.
Please document what the default easing function will be if you do not supply one.

Thank you @bschoepke for bringing this to our attention.
@jwmsft can you please respond?

@stmoy can you help update the docs?

I've updated the EasingDoubleKeyFrame doc.


[WIP] JSON table init upgraded to JSON table sync.

Tables that are initialized with JSON files in the table_init folder will now sync properly if the JSON file is changed after initialization. Any lines that are either added or removed from the JSON file will be updated to the corresponding table whenever site is rebooted.

gdude has a better idea.


"Error: socket hang up" on local CMS fetch

My react-static project resides in http://mywebsite and I'm trying to fetch from a local CraftCMS install: const projects = await axios.get('http://craftapi/projects?page=1')
But I get an error saying Error: socket hang up
Is it some CORS issue? I tried using this approach https://github.com/nozzle/react-static/issues/380 but to no avail. Is there another way?

This can be caused by quite a few things, most of which would have nothing to do with react-static.

CORS errors generally will show up in your (browser) console, and displayed as such.
why are you redirecting to a local installation? You can use localhost for now, and later add logic to use the public address in production.


Release v0.41.2 does not have an installer, release page is odd.

Microsoft PowerToys version
0.41.2
Running as admin

[ ] Yes

Area(s) with issue?
Installer
Steps to reproduce
Go to download the release.
✔ Expected Behavior
To find an installer.
❌ Actual Behavior
There is no installer, release page is vastly different from other releases.
Other Software
No response

That's not a release yet. But from this codepoint we will release the version

That is very weird, I got a full blown release email and all.

Yeah I also. @dedavis6797 Why exactly did you do this?

H

I got it too

The release page is definitely odd.

I got it too

The release page is definitely odd.

It's a tag not a release

It's a tag not a release

You could possibly see how we might get confused with it being in the releases section, and having received a release email. Every tag so far as I can tell has corresponded to a release.

GitHub literally says it is a "release"

@crutkas @dedavis6797 Can we please remove this tag/release. It just creates confusion

We accidentally released it and pulled it back for the weekend. It will be live Monday ~10AM PST time zone.


Change dup to clone

dup is a shallow copy, not very good when you're trying to do a deep merge of an object. A nested hash from the original was being changed on the copying method of easy_merge and unmerge.

clone not working how i hoped. give me a bit to make some more changes.

now it's working

Marshal.dump and load don't work 100% of the time. According to ruby doc: Some objects cannot be dumped: if the objects to be dumped include bindings, procedure or method objects, instances of class IO, or singleton objects, a TypeError will be raised.
So... This is not 100% safe

Better to be not 100% safe than 100% not actually working, imo.
That said, I agree, I wasn't thrilled with the implementation as it was. It was a stopgap that worked in my case where I was seeing data loss. As time allows, I may go back an implement the clone in the manual way. Or you're welcome to. Another solution is to find a deep-clone gem and use it as a dependency.
Which would you prefer?


[bug] WebView not consistent with that in Safari in MacOS

Describe the bug
The webview in tauri doesn't support nullish coalescing operator (?.), yet my Safari browser supports it.
This is from the dev tool of latest Tauri:

This is from the dev tool of Safari:

The syntax error is from svelte (https://github.com/sveltejs/kit/issues/5130), which made it impossible to use the dev mode in tauri.
Reproduction

Install tauri
Choose vite + svelte
Run tauri dev

Expected behavior
The web page is displayed.
Platform and versions
Environment
  › OS: Mac OS 10.13.6 X64
  › Node.js: 16.15.1
  › npm: 8.11.0
  › pnpm: 7.5.1
  › yarn: 1.22.15
  › rustup: 1.24.3
  › rustc: 1.61.0
  › cargo: 1.61.0
  › Rust toolchain: stable-x86_64-apple-darwin

Packages
  › @tauri-apps/cli [NPM]: 1.0.0 (outdated, latest: 1.0.3)
  › @tauri-apps/api [NPM]: 1.0.2
  › tauri [RUST]: 1.0.3,
  › tauri-build [RUST]: 1.0.3,
  › tao [RUST]: 0.12.1,
  › wry [RUST]: 0.19.0,

App
  › build-type: bundle
  › CSP: unset
  › distDir: ../dist
  › devPath: http://localhost:5173/
  › framework: Svelte

App directory structure
  ├─ node_modules
  ├─ public
  ├─ src-tauri
  ├─ .vscode
  └─ src

Stack trace
No response
Additional context
I wonder if it's an intrinsic limit of the webview or some of its flags need to be switched on in order for it to support new JS features?

Contrary to Safari, which has auto updating capabilities effectively back porting newer versions to older macOS releases, WKWebView is an OS component and updates to it are therefore tied to OS updates. Our version testing indicates your Webview corresponds to Safari 11.1.2, so has not been updated since July 9, 2018. You should update your macOS version 😄

I ran into same issue

Is there a way for us to upgrade the webview (not OS) for the end user to ensure compatibility?

Nope


Read record_task_history parameter in scheduler.scheduler

We're trying to do something like this:
class MyJob(luigi.task):
    def complete(self):
        scheduler = luigi.scheduler.CentralPlannerScheduler()

        history = scheduler.task_history
        if isinstance(history, luigi.task_history.NopHistory):
            return False

        params = {k: str(getattr(self, k)) for k, _ in self.get_params()}
        tasks = history.find_all_by_parameters(self.task_family, **params)
        return any(any(e.event_name == "DONE" for e in t.events) for t in tasks)

When we run luigi.scheduler.CentralPlannerScheduler() from ipython, it uses DbTaskHistory however when complete() is invoked via the worker, it uses NopHistory.
Perhaps there's a nice way to build in this sort of functionality too.

Commit looks good to me.
I'm not sure about your code... why can't you just use a dummy file on disk instead?

It mimics one of the patterns we commonly used before we started porting jobs to luigi.  This came about for jobs which don't have file outputs (ex. batch updating model parameters in couchbase.)  It feels cleaner to use the existing history data, avoiding the need to set up new folders on a distributed filesystem for each job and permutation of job arguments.

Ok. I guess generalizing that a bit would be to factor it out into a separate Target class that takes a Task as an argument, but it doesn't really matter too much.

config_path is deprecated. But I can fix in a separate commit


Add hamburger toggle state and mutation

This is something we use in 99% of sites, so it'd save some time to include state: { menuOpened: false } and
mutations: {
        'TOGGLE_MENU': state => {
            state.menuOpened = !state.menuOpened
        }
}

in src/store/index.js.

When we add this, let's do it as OPEN_MENU and CLOSE_MENU. I think the best practice is to have the component that runs the mutation be in charge of the toggle logic.

Added in 4b1072a


Update Gradle Version Plugin to 0.13.0

Current coverage is 55.00% (diff: 100%)

No coverage report found for master at ad5668b.

Powered by Codecov. Last update ad5668b...d04e12b

Current coverage is 55.00% (diff: 100%)

No coverage report found for master at ad5668b.

Powered by Codecov. Last update ad5668b...79416df


Added missed required option to readme

AFAIK the version parameter is optional as long as you’ve added electron-prebuilt to your devDependencies, because it will use its version.
Checking the README confirms my thoughts:

download all supported target platforms and arches of Electron using the installed electron-prebuilt version (and cache the downloads in ~/.electron)

Maybe this behaviour should be better documented.

Ok got it. Looks like it doesn't work when dependency has empty version

The version behavior is described in a few locations:

the command line usage
the example
the API docs

That being said, I would happily review a PR that clarifies the docs. I don't see a need for this particular PR.

OK. But bug exists when user didn't specify version in package.json, e.g.
"electron-prebuilt": "",
then empty string returns false and code stop working. Checking key in object will fix it. See last commit.

That may be valid, but setting the version to a blank string is a really bad idea.
Please rename the PR and write a testcase for this change, and I will reopen this issue.


[core] optimize getRectRelativeToOffsetParent function

Remove duplicate code.
The return value of isHTMLElement(offsetParent) has already been retrieved, so there is no need to compute it again

Thank you!


[$1000] Wrong number of replies is displayed when a reply is flagged as offensive

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Sign in with user A
Send a comment to user B
Click "Reply in thread" icon
Send a reply comment
From user B, open the thread
Click on "Flag as offensive" icon for user A's reply
Choose any reason
Go back to the report

Expected Result:
Correct number of replies is displayed i.e. "2 Replies" in this case
Actual Result:
Wrong number of replies is displayed i.e. "3 Replies" in this case
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number:  1.3.22-0
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/881df58f-9165-49a3-863d-f3de15607041
https://github.com/Expensify/App/assets/43996225/9cbb3701-2238-424e-af40-7425bc6f1017
Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685619366271189
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016d1d283fd8c2b42e
Upwork Job ID:<PHONE_NUMBER>213250048
Last Price Increase: 2023-06-14

I've pushed back on this one in the Slack thread: https://expensify.slack.com/archives/C049HHMV9SM/p1686116010341579?thread_ts=1685619366.271189&cid=C049HHMV9SM
I'm not quite sure this is a bug as it makes sense to me that we count the Concierge message as a reply in the thread.

Alright, I got clarification in Slack. I can reproduce the issue.

I think this needs to handle in the backend as prop childVisibleActionCount which we are using to show as number of replies received from backend.

@roryabraham based on @Pujan92 comment above, does this need to be worked on internally?

Thanks for the tag! So this one sounds a little different - is it due to the system message? Is it specifically for flagged messages? We should definitely include system messages in the count, but this bug is that - even including system messages - we're still one too high. It's counting the original, as a reply, maybe.
Hm or maybe it's counting both whispers - the whisper to the reporter AND the whisper to the reportee - which no one should be able to see both of. Okay sorry @pecanoro going to cc you here as well. Are whispers counted in the child action count, even if the current user can't see them?

Are whispers counted in the child action count, even if the current user can't see them?

No idea, when I implemented whispers/welcome messages, threads were not a thing so I guess whoever implemented threads didn't take it into account. We were going to remove welcome messages from threads I think, did that happen?

Sorry I missed this one earlier. It appears to me like it will probably need to be a back-end fix, but it's a bit complicated since the value of childVisibleActionCount is actually different on a per-user basis. Getting close to the end of my day here, will strive to make progress on this one tomorrow.

Sorry, have been heads-down on this due to deploy fires. Going to make this a weekly, internal since that feels appropriate for this issue.

We noticed this same bug for other types of messages here so I am bumping this to daily since ideally, we should fix this for SNH. I think the problem is probably the query that computes childVisibleActionCount

@roryabraham SNH is at the start of next week. Do we expect to get a fix for this one this week?

Oh well, it seems @aldo is fixing it here https://github.com/Expensify/Auth/pull/8159 so because of that, I am going to reassign it so he can get credit for the contributions!

@adeel0202 I just sent you the offer via Upworks: https://www.upwork.com/jobs/~012218104f422ffcc4

Payment sent.


Application failed with multiple EOF exceptions from different channels

locast2tuner 0.1.37 on Darwin 20.4.0
While watching channels (locast2tuner running via terminal on Mac) through Plex this afternoon, player failed at various times.  I tried to find something in the Plex logs just to see if I could narrow down a cause and made various Plex configuration changes between restarts of locast2tuner, but there didn't seem to be anything worthwhile to add to this issue.
My gut feeling is that it was network related as my wife mentioned getting kicked out of online meetings multiple times this afternoon, which hasn't happened since we upgraded our Internet plan.  We have the highest Xfinity home plan, but increasing speed doesn't necessarily make their network more stable -- so I'm sure this isn't reproducible.
Ideally, some exception handling could be added that would retry about 5 or 10 times, maybe a second apart which should be inside cached times for whatever is playing, then log the error but not kill the application.  Of course, feel free to close as could not reproduce if there's really nothing that fits within the application logic.
mod.rs
559:            Ok(r) => r.bytes().await.unwrap().to_vec(),

May 19 15:03:50.460 INFO Serving https://sea.locastnet.org/proxy/sea/king_src270243638.ts (6 s) in 5.6220093s
thread 'actix-rt|system:0|arbiter:8' panicked at 'called `Result::unwrap()` on an `Err` value: reqwest::Error { kind: Body, source: hyper::Error(Body, Custom { kind: UnexpectedEof, error: IncompleteBody }) }', src/http/mod.rs:559:38

May 19 15:15:37.934 INFO Serving https://sea.locastnet.org/proxy/sea/kcpqstadium162146255.ts (10 s) in 9.654999s
May 19 15:15:47.855 INFO Stream 790cf59 - playing: segment "https://sea.locastnet.org/proxy/sea/kcpqstadium162146255.ts"
May 19 15:15:48.014 INFO Stream 790cf59 - added segment "https://sea.locastnet.org/proxy/sea/kcpqstadium162146263.ts"
May 19 15:15:48.014 INFO Serving https://sea.locastnet.org/proxy/sea/kcpqstadium162146256.ts (10 s) in 9.575001s
thread 'actix-rt|system:0|arbiter:3' panicked at 'called `Result::unwrap()` on an `Err` value: reqwest::Error { kind: Body, source: hyper::Error(Body, Custom { kind: UnexpectedEof, error: IncompleteBody }) }', src/http/mod.rs:559:38

May 19 16:02:49.028 INFO Serving https://sea.locastnet.org/proxy/sea/kcpqstadium162146538.ts (10 s) in 9.596008s
May 19 16:02:58.862 INFO Stream b4927e0 - playing: segment "https://sea.locastnet.org/proxy/sea/kcpqstadium162146538.ts"
May 19 16:02:59.003 INFO Stream b4927e0 - added segment "https://sea.locastnet.org/proxy/sea/kcpqstadium162146546.ts"
May 19 16:02:59.003 INFO Serving https://sea.locastnet.org/proxy/sea/kcpqstadium162146539.ts (10 s) in 9.619995s
thread 'actix-rt|system:0|arbiter:3' panicked at 'called `Result::unwrap()` on an `Err` value: reqwest::Error { kind: Body, source: hyper::Error(Body, Custom { kind: UnexpectedEof, error: IncompleteBody }) }', src/http/mod.rs:559:38

May 19 16:54:27.921 INFO Serving https://sea.locastnet.org/proxy/sea/kctscreate162146847.ts (10 s) in 9.553986s
May 19 16:54:37.998 INFO Stream 16c5710 - playing: segment "https://sea.locastnet.org/proxy/sea/kctscreate162146847.ts"
May 19 16:54:38.181 INFO Stream 16c5710 - added segment "https://sea.locastnet.org/proxy/sea/kctscreate162146856.ts"
May 19 16:54:38.181 INFO Serving https://sea.locastnet.org/proxy/sea/kctscreate162146848.ts (10 s) in 9.294006s
May 19 16:54:47.717 INFO Stream 16c5710 - playing: segment "https://sea.locastnet.org/proxy/sea/kctscreate162146848.ts"
May 19 16:54:47.847 INFO Stream 16c5710 - added segment "https://sea.locastnet.org/proxy/sea/kctscreate162146857.ts"
May 19 16:54:47.847 INFO Serving https://sea.locastnet.org/proxy/sea/kctscreate162146849.ts (10 s) in 9.627991s
thread 'actix-rt|system:0|arbiter:5' panicked at 'called `Result::unwrap()` on an `Err` value: reqwest::Error { kind: Body, source: hyper::Error(Body, Custom { kind: UnexpectedEof, error: IncompleteBody }) }', src/http/mod.rs:559:38

This looks like a transient error and we should terminate the steam I think
or retry a few times. The interesting thing here is that the http request
to locast succeeds, but it's apparently incomplete. Not sure why that
happened though. I'll have a look tomorrow and see what we should do here.
On Wed, May 19, 2021, 19:52 Jeff @.***> wrote:

locast2tuner 0.1.37 on Darwin
While watching channels (locast2tuner running via terminal on Mac) through
Plex this afternoon, player failed at various times. I tried to find
something in the Plex logs just to see if I could narrow down a cause and
made various Plex configuration changes between restarts of locast2tuner,
but there didn't seem to be anything worthwhile to add to this issue.
My gut feeling is that it was network related as my wife mentioned getting
kicked out of online meetings multiple times this afternoon, which hasn't
happened since we upgraded our Internet plan. We have the highest Xfinity
home plan, but increasing speed doesn't necessarily make their network more
stable -- so I'm sure this isn't reproducible.
Ideally, some exception handling could be added that would log the error
but not kill the application, but feel free to close as could not reproduce
if there's really nothing that fits within the application logic.
May 19 15:03:50.460 INFO Serving https://sea.locastnet.org/proxy/sea/king_src270243638.ts (6 s) in 5.6220093s
thread 'actix-rt|system:0|arbiter:8' panicked at 'called Result::unwrap() on an Err value: reqwest::Error { kind: Body, source: hyper::Error(Body, Custom { kind: UnexpectedEof, error: IncompleteBody }) }', src/http/mod.rs:559:38
May 19 15:15:37.934 INFO Serving https://sea.locastnet.org/proxy/sea/kcpqstadium162146255.ts (10 s) in 9.654999s
May 19 15:15:47.855 INFO Stream 790cf59 - playing: segment "https://sea.locastnet.org/proxy/sea/kcpqstadium162146255.ts"
May 19 15:15:48.014 INFO Stream 790cf59 - added segment "https://sea.locastnet.org/proxy/sea/kcpqstadium162146263.ts"
May 19 15:15:48.014 INFO Serving https://sea.locastnet.org/proxy/sea/kcpqstadium162146256.ts (10 s) in 9.575001s
thread 'actix-rt|system:0|arbiter:3' panicked at 'called Result::unwrap() on an Err value: reqwest::Error { kind: Body, source: hyper::Error(Body, Custom { kind: UnexpectedEof, error: IncompleteBody }) }', src/http/mod.rs:559:38
May 19 16:02:49.028 INFO Serving https://sea.locastnet.org/proxy/sea/kcpqstadium162146538.ts (10 s) in 9.596008s
May 19 16:02:58.862 INFO Stream b4927e0 - playing: segment "https://sea.locastnet.org/proxy/sea/kcpqstadium162146538.ts"
May 19 16:02:59.003 INFO Stream b4927e0 - added segment "https://sea.locastnet.org/proxy/sea/kcpqstadium162146546.ts"
May 19 16:02:59.003 INFO Serving https://sea.locastnet.org/proxy/sea/kcpqstadium162146539.ts (10 s) in 9.619995s
thread 'actix-rt|system:0|arbiter:3' panicked at 'called Result::unwrap() on an Err value: reqwest::Error { kind: Body, source: hyper::Error(Body, Custom { kind: UnexpectedEof, error: IncompleteBody }) }', src/http/mod.rs:559:38
May 19 16:54:27.921 INFO Serving https://sea.locastnet.org/proxy/sea/kctscreate162146847.ts (10 s) in 9.553986s
May 19 16:54:37.998 INFO Stream 16c5710 - playing: segment "https://sea.locastnet.org/proxy/sea/kctscreate162146847.ts"
May 19 16:54:38.181 INFO Stream 16c5710 - added segment "https://sea.locastnet.org/proxy/sea/kctscreate162146856.ts"
May 19 16:54:38.181 INFO Serving https://sea.locastnet.org/proxy/sea/kctscreate162146848.ts (10 s) in 9.294006s
May 19 16:54:47.717 INFO Stream 16c5710 - playing: segment "https://sea.locastnet.org/proxy/sea/kctscreate162146848.ts"
May 19 16:54:47.847 INFO Stream 16c5710 - added segment "https://sea.locastnet.org/proxy/sea/kctscreate162146857.ts"
May 19 16:54:47.847 INFO Serving https://sea.locastnet.org/proxy/sea/kctscreate162146849.ts (10 s) in 9.627991s
thread 'actix-rt|system:0|arbiter:5' panicked at 'called Result::unwrap() on an Err value: reqwest::Error { kind: Body, source: hyper::Error(Body, Custom { kind: UnexpectedEof, error: IncompleteBody }) }', src/http/mod.rs:559:38
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/wouterdebie/locast2tuner/issues/52, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABKABUPITQ3AMWTI6NTQPTTORML5ANCNFSM45FY5GZA
.

I recall many times troubleshooting similar networking issues with an application I made that about half the airplanes built in the last 10 years use to talk to "ground systems" and there's almost never a way to find an exact cause.  One of the symptoms was always items that didn't download completely (EOF exceptions when parsing) even though there were other indicators that the connection was still established and responsive.  Ultimately, I usually ended up picking a configurable retry window (with a little bit of fixed or variable time between tries) then either ended that processing attempt or bubbled up an exception.
For what it's worth, as of this morning (overnight and 3 hours of watching locast programming this morning) locast2tuner has been running fine after the last error reported above.


KAFKA-5110: Check for errors when fetching the log end offset in ConsumerGroupCommand

@vahidhashemian I'd appreciate a review if you have time.

@hachikuji Sure, I couldn't easily tell from the code how the issue can be reproduced. Also, the patch seems to come with some code refactoring too, so I'm not sure if the added unit test is supposed to fail with the existing code. Could you please clarify? Thanks.

@vahidhashemian Thanks. The main addition here is the error checking in fetchLogEndOffset. We're actually not sure what caused the trace that Dustin provided on the JIRA, but it seems pretty clear that we were missing the error check, so we're hoping to get more info with this patch. And yeah, I couldn't help myself adding a couple minor refactors (mainly I was trying to eliminate some of the uses of TopicAndPartition).

retest this please

retest this please

Closing this since it seems obsolete.


glTF 2.0 animations not correct

Godot version
3.3.2.stable.mono.official
System information
Windows 10
Issue description
glTF 2 Animations not playing correctly from Blender 2.9 export.  Some bones are not positioned properly and it doesn't look right.  In comparison, an ESCN export of the same model looks exactly as it does in blender.
Steps to reproduce
I've attached a zip file containing my humanoid blender model and a simple godot project which has a side-by-side of the glTF 2 vs ESCN export playing the 'running-loop' animation.
Minimal reproduction project
Godot glTF 2 Animation Bug.zip

I'm trying to verify that https://github.com/godotengine/godot/pull/48375 is a fix for this, but I'm not sure.

@fire It looks like the problem is that some keyframes are omitted in the output of the animation

Please disable

It has been reported several times that the animation optimizer loses important keyframes.

@Tyler-Yocolano Does disabling the optimizer fix this for you? Also, does this occur in Godot 4.x, or only Godot 3.x?


Added site.go to support website monitoring, updated readme

Added ability to monitor a website using the spinner application.
Updated readme file to include usage and examples.

Thanks, @chrisjbowen


jets login prompt message when likely ci env

This is a 🐞 bug fix.
This is a 🙋♂ feature or enhancement.

[ ] I've added tests (if it's a bug, feature or enhancement)
[ ] I've adjusted the documentation (if it's a feature or enhancement)
[ ] The test suite passes (run bundle exec rspec to verify this)

Summary
When users are running jets deploy in a CI pipeline and they run jets login $TOKEN and TOKEN is not set, this provides a more helpful message.
How to Test
Use a test script like this
prompt.sh
#!/usr/bin/env bash
# force non-TTY with exec
exec jets login

Version Changes
Patch

Released in jets 6.0.5


Negative Temperature

Hello,
I've created a Temperature accessory for my home automation system. It should read current temperature from a txt file (that's a way I prefer). Every time the temperature goes below zero, every iOS app throws an error and refuses to show the temperature. I already changed minValue in both my accessory and in HomeKitTypes.js
Here's the part that reads temperature from my *_accessory.js
},{
cType: types.CURRENT_TEMPERATURE_CTYPE,
onRead: function(callback) {
console.log("Reading temperature outside");
fs = require('fs')
fs.readFile('/home/username/hktmp.txt', 'utf8', function (err,data) {
if (err) {
return console.log(err);
}
console.log(data);
var inttemp = parseFloat(data);
console.log(inttemp)
callback(inttemp);
})
},
perms: ["pr","ev"],
format: "float",
initialValue: 24,
supportEvents: false,
supportBonjour: false,
minValue: -100,
maxValue: 100,
manfDescription: "Temperature"
},{
Console log, after parseFloat, throws out a correct value of negative temperature.
And the fragment I changed in HomeKitTypes.js
Characteristic.CurrentTemperature = function() {
Characteristic.call(this, 'Current Temperature', '00000011-0000-1000-8000-0026BB765291');
this.setProps({
format: Characteristic.Formats.FLOAT,
unit: Characteristic.Units.CELSIUS,
maxValue: 100,
minValue: -100,
minStep: 0.1,
perms: [Characteristic.Perms.READ, Characteristic.Perms.NOTIFY]
});
this.value = this.getDefaultValue();
};
Any idea what else can be going wrong here?

For me it is simply working to change the min value to -100

Okay, so I've take a look at @TheNoim commit and my file was the same. So I've rewritten my _accessory.js file. It now reads temperature from a sensor through Domoticz API and parse the response with RegExp. It looks like this:
var Accessory = require('../').Accessory;
var Service = require('../').Service;
var Characteristic = require('../').Characteristic;
var uuid = require('../').uuid;
var request = require("request");

// here's a fake temperature sensor device that we'll expose to HomeKit
var FAKE_SENSOR = {
  getTemperature: function() {
    console.log("Getting the current temperature!");
    request("http://<IP_ADDRESS>:8080/json.htm?type=devices&rid=xxx", function(error, response, body) {
    				var regtemplate = new RegExp(/-?\d+\.\d+/g);
    				var regtemp= body.match(regtemplate);
    				console.log('RegExp result:');
    				console.log(regtemp[5]);
				var floattemp = parseFloat(regtemp[5]);
				console.log('called back:');
				console.log(floattemp)
				FAKE_SENSOR.currentTemperature = floattemp;
    				return FAKE_SENSOR.floattemp;
    		});
  }
}

// Generate a consistent UUID for our Temperature Sensor Accessory that will remain the same
// even when restarting our server. We use the `uuid.generate` helper function to create
// a deterministic UUID based on an arbitrary "namespace" and the string "temperature-sensor".
var sensorUUID = uuid.generate('hap-nodejs:accessories:temperature-sensor');

// This is the Accessory that we'll return to HAP-NodeJS that represents our fake lock.
var sensor = exports.accessory = new Accessory('Test Temperature Sensor', sensorUUID);

// Add properties for publishing (in case we're using Core.js and not BridgedCore.js)
sensor.username = "C1:5D:3A:AE:5D:FA";
sensor.pincode = "031-45-154";

// Add the actual TemperatureSensor Service.
// We can see the complete list of Services and Characteristics in `lib/gen/HomeKitTypes.js`
sensor
  .addService(Service.TemperatureSensor)
  .getCharacteristic(Characteristic.CurrentTemperature)
  .on('get', function(callback) {

    // return our current value
    callback(FAKE_SENSOR.getTemperature());
  });

// randomize our temperature reading every 3 seconds
setInterval(function() {

  FAKE_SENSOR.getTemperature();

  // update the characteristic value so interested iOS devices can get notified
  sensor
    .getService(Service.TemperatureSensor)
    .setCharacteristic(Characteristic.CurrentTemperature, FAKE_SENSOR.currentTemperature);

}, 3000);

Negative temperatures shows fine now, but there's another issue. When I open any of my HomeKit apps, the temperature is at minValue until the request is finished and temperature is updated to the correct value. It creates a problem when I'm asking Siri for the specific temperature. She always answers with minimal value. Is there maybe a way to force the HomeKit protocol to wait for request result?

Your getTemperatur() method starts an async process with a callback, you expect the answer is already there when you call the on('get', function() {...} ) callback.
However, your value is never RETURNED as the line
return FAKE_SENSOR.floattemp; is in a routine that doesn't take the return value anywhere.
Accidentally it works sometimes because you set FAKE_SENSOR.currentTemperature = floattemp in your routine that is taken later on by .setCharacteristic(Characteristic.CurrentTemperature, FAKE_SENSOR.currentTemperature); if there was a get event sometimes before.
Please read some material about async calls and callbacks in JavaScript.
http://callbackhell.com/


FSI ignores Errors in #loaded scripts

After reporting https://github.com/Microsoft/visualfsharp/issues/1392 I figured I'd try to reproduce https://github.com/fsharp/FSharp.Compiler.Service/issues/586 again without using FSharp.Compiler.Service. And lo and behold here is how it works (or should I say fails):
Repro steps
test.fsx
#load "other.fsx"

Other.func()

and
other.fsx
let func = (fun () ->
    printfn "This shouldn't work"
) )

open fsi
#load test.fsx

Expected behavior
other.fsx(3,3): error FS0010: Unexpected symbol ')' in implementation file

Actual behavior
> #load "test.fsx";;
[Loading C:\PROJ\visualfsharp.issues\loadWithError\other.fsx
 Loading C:\PROJ\visualfsharp.issues\loadWithError\test.fsx]
This shouldn't work

namespace FSI_0003
  val func : unit -> unit

namespace FSI_0003

Known workarounds
No known workaround
Related information

F# 4.0 (Microsoft (R) F# Interactive version 14.0.23413.0)
Windows 10
VS 2015

fsi.exe test.fsx works ie errors out as expected. That's why I initially assumed it would be an FSharp.Compiler.Service only bug. see https://github.com/fsharp/FSharp.Compiler.Service/issues/586

Fixed


Clarify Licensing

There's currently no license info for this project.

Thanks for the heads up. I've added the license text now. It's public domain.


Fixed proxy auth

This should fix https://github.com/scrapinghub/splash/issues/559. https://github.com/scrapinghub/splash/pull/348 fixed proxy auth for proxies set with request:set_proxy, this PR fixes it for proxies set using proxy argument as well.

Current coverage is 87.70% (diff: 100%)

Merging #561 into master will increase coverage by <.01%

@@             master       #561   diff @@
==========================================
  Files            42         42
  Lines          5535       5539     +4
  Methods           0          0
  Messages          0          0
  Branches        757        758     +1
==========================================
+ Hits           4854       4858     +4
  Misses          511        511
  Partials        170        170

Powered by Codecov. Last update c6bacaa...2c5aedd

Tests in this PR don't expose the bug, they pass without the fix. What fails is auth in case of HTTPS proxying, but I haven't added a HTTPS proxy to mockserver, so tests which should fail are skipped.
I checked the changes on a real https proxy (Crawlera); it was not working before the fix, but started to work after it.


Bump to Fedora 39

This brings Go 1.21. Go 1.21 no longer ships .a libraries, so the corresponding clean-up is removed.
Python is upgraded to 3.12, which breaks j2cli; this switches to the packaged python3-jinja2-cli instead. The latter has progressed since j2cli was created, and should support all the j2cli features needed in Submariner (more precisely, for OVN).
The official GitHub client is available as a package, install that instead of the upstream tarball.

The switch to jinja2 breaks OVN deployments; that can probably be worked around externally. The best solution would be to migrate OVNKubernetes to jinja2 as well, but before we’d be able to use that we’d have to fix the deployment issues we run into when trying to use newer versions of OVNK...


FEATURE REQUEST: Daily Net Worth Chart

I recently tried out PocketSmith - cool app but not for me.
But one of the things I loved about it was that their net worth chart was a daily one (with projected net worth). I'm not sure if it's possible, but it would be really cool to have this option.

We're starting to track all enhancements in Trello.
I've added this request here. Thank you!


Postman plugin and theme

Describe the bug
The section of postman plugin is without the theme and some of our documentation didn't get the postman code in mdx.
Expected behavior
The postman plugin should display the theme in all languages as shown in the demo version of the website and the url should be automatically completed.
Current behavior
The Ruby, C#, PHP, Java and Powershell are without the default theme and present the code in black and white.
Some mdx files generated by the plugin do not contain the code that postman should manage.
Steps to reproduce
Live example

Install Docusaurus;
Install and config the plugin/theme of Open Api;
Generate the docs;
Start Docusaurus.

Screenshots

Context
We need the requests working for the users, as well as the styling for a homogeneous look.
Your Environment

Version used: I tried with v1.6.1, v1.7.2 and v2.0.0;
Environment name and version: Microsoft Edge, node.js 18.1.0, python 3.10.6;
Operating System and version: desktop;
Link to your project: private.

I found out today that the issue with the postman code not being generated is due to the (.pdf ) in some endpoints like the one below:
/api/empresas/docs/{ambiente}/{codModelo}/{cnpjInteressado}/{ano}/{serie}/{numero}.pdf
What could I do?  How to proceed?
The issue with the theme not being applied(first gif above) still persists.

Hi @gii-pan, for the languages missing the theme/highlighting, have you already defined them in additionalLanguages?
Example: https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/blob/main/demo/docusaurus.config.js#L139
Concerning the .pdf issue, can you explain why those operations/paths end in a file extension? I am not familiar with that use case. Thanks!

@gii-pan Did you ever figure out a solution or workaround to your .pdf issue?