Extend known slice with Go 1.23 compiler directives

This PR modifies known slice.
Added:

//go:binary-only-package
//go:debug
//go:wasmimport

Removed:

//go:binary: https://go.googlesource.com/go/+/refs/tags/go1.23.3/src/go/build/doc.go#73.
//go:buildsomethingelse: https://go.googlesource.com/go/+/refs/tags/go1.23.3/src/go/build/constraint/expr.go#190
//go:name: https://go.googlesource.com/go/+/refs/tags/go1.23.3/src/cmd/compile/doc.go#201

(cc) @ldez
related to https://github.com/Antonboom/nilnil/actions/runs/12358099538/job/34487829213

//go:buildsomethingelse: go.googlesource.com/go/+/refs/tags/go1.23.3/src/go/build/constraint/expr.go#190
//go:name: go.googlesource.com/go/+/refs/tags/go1.23.3/src/cmd/compile/doc.go#201

I don't think these two cases are actual directives that are supported by the compiler. They're just examples in the documentation.
Do you have examples of them actually in use or supported by the compiler?
Can you reduce the PR to only //go:binary-only-package?

//go:buildsomethingelse: go.googlesource.com/go/+/refs/tags/go1.23.3/src/go/build/constraint/expr.go#190
//go:name: go.googlesource.com/go/+/refs/tags/go1.23.3/src/cmd/compile/doc.go#201

I don't think these two cases are actual directives that are supported by the compiler. They're just examples in the documentation.
Do you have examples of them actually in use or supported by the compiler?
Can you reduce the PR to only //go:binary-only-package?

Thank you for your feedback. I'm not completely clear on which lines should be adjusted. Could you please comment directly on the PR to specify the lines to be removed? This will help me make the correct updates more efficiently. Thank you!
Anyway:

//go:debug usage in a wild https://sourcegraph.com/search?q=context:global+//go:debug+lang:go+&patternType=standard&sm=1
go:wasmimport usage https://sourcegraph.com/search?q=context:global+//go:wasmimport+lang:go+&patternType=standard&sm=1


openai migration on Windows WSL error. instructions are wrong

The migration guide section for Windows using WSL does not function properly. After running 'curl -fsSL https://docs.grit.io/install | bash' within the source code directory, the new bash instance does not have 'grit' included in the path variable. I am using an Ubuntu WSL image.
UPDATE
Did some more diagnosing, turns out the pipe command does literally nothing for the user. Why are you piping the output of a curl statement without accessing the piped output in your bash command after the pipe? You made the terminal print the file into the void. The curl command literally produces the text from the file, not a file. You need to pipe this crap into a file, then run that file in the new bash instance.
curl -fsSL https://docs.grit.io/install > grit_install_script.sh | bash
./grit_install_script.sh
In addition, you need to include the install location in the user path variable, because this is what happens if you don't:
downloading grit 0.1.0-alpha.1731963650 x86_64-unknown-linux-gnu
installing to /home/ryan/.grit/bin
  grit
everything's installed!
ryan@IAmDevloper:/mnt/r/Google Drive/Code/Repositories/offline/openAI desktop user helper$ grit install
Command 'grit' not found, did you mean:

So add this command after the execution:
export PATH=$PATH:$HOME/.grit/bin to append the install location
after this, you do not need to do grit install it is redundant at this point. The problem with your script is you needed grit installed in order to run the grit install command, which makes a cyclic dependency.
Original post excerpt:

Automatic migration with grit on Windows
To use grit to migrate your code on Windows, you will need to use Windows Subsystem for Linux (WSL). Installing WSL is quick and easy, and you do not need to keep using Linux once the command is done.
Here's a step-by-step guide for setting up and using WSL for this purpose:

Open a PowerShell or Command Prompt as an administrator and run wsl --install.
Restart your computer.
Open the WSL application.
In the WSL terminal, cd into the appropriate directory (e.g., cd /mnt/c/Users/Myself/my/code/) and then run the following commands:curl -fsSL https://docs.grit.io/install | bash
grit install
grit apply openai

Then, you can close WSL and go back to using Windows.
Originally posted by @rattrayalex in https://github.com/openai/openai-python/discussions/742

Looking inside the script file, it is apparent that the script should already set the path variable. I guess I just forgot to refresh the shell after running the downloaded script.
    # * early-bound: export PATH="/home/myuser/.myapp:$PATH"
    # * late-bound:  export PATH="$HOME/.myapp:$PATH"
        export PATH="$_install_dir_expr:\$PATH"


Proposal: Extend this repo's scope to include OPML

I think we should also provide good example representations of podcast collections / item recommendation lists in OPML, not only in RSS or custom JSON.
What is OPML
OPML (Outline Processor Markup Language) comes from the same person as RSS 0.92 / 2.0 - Dave Winer.
As its long name suggest, OPML a XML dialect to describe outlines – but became more popular as as simple way to list RSS feeds, e.g. a blog roll or to transfer your subscriptions from one podcast app to another.
This is a separate section 'subscription lists' in the OPML spec:

http://dev.opml.org/spec2.html#subscriptionLists

As already mentioned in another discussion there is also a JSON representation:

http://scripting.com/2016/10/11/convertOpmlToJson.html
http://scripting.com/code/opmltojson/?url=http://www.bbc.co.uk/podcasts.opml

I can also recommend to export your subscriptions via OPML, convert it to CSV via http://opml2csv.com and sort them in your favourite spreadsheet tool, as I did in Sep 2018, see below [1].  :-)
Broadcasters / Podcast networks already provide their list of podcasts als OPML e.g. http://podcasts.files.bbci.co.uk/podcasts.opml [via BBC radiolabs Blog]
Reasoning
As of today nearly every podcast app supports import and export of subscriptions, but all other information like how many episodes you listened are lost. We should extend OPML and document common practises like we do with RSS.
This is not thought as apposing proposal to the linked issues, but should be seen as an extension to the existing proposals to make it easier for users and app developers to implement ans use these ideas.
TBC…
Misc
Related: https://github.com/Podcastindex-org/podcast-namespace/issues/240 https://github.com/Podcastindex-org/podcast-namespace/issues/363
[1]

I would also like to propose the namespace to be used in OPML for the basis of the channels tag work.


Devsite 665 table

Implementation fo table using spectrum css

Related Issue

Motivation and Context

How Has This Been Tested?
Implementation
https://devsite-665-table--adobe-io-website--adobe.hlx.page/photoshop/index-new
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

the table looks different from the spectrum template. also, i think that we don't need any specific CSS, as spectrum should provide all borders and colors:

markup looks different (e.g. td instead of th used in thead)
border colors too dark
column heading fonts look different
center table on page and add margin

suggestion: remove all custom CSS and use spectrum classes only

also in mobile sizes, the table doesn't go into scrolling mode with nice margins/padding


DALI backend does not report statistics.

Hi @huntrax11,
Sorry for the late response. Thank you for reporting this missing functionality. This PR when is ready should provide what you need.


Pile up pipeline support resources

Build a knowledge repository:
The official dev guide
The discussion on ProjectAction
Replacing constructors with databound setters
Anything relevant about supporting Pipeline

DevGuide
https://github.com/jenkinsci/pipeline-plugin/blob/master/DEVGUIDE.md
Project Actions
https://jenkins.io/blog/2016/05/25/update-plugin-for-pipeline/
Relevant video
https://www.youtube.com/watch?v=azyv183Ua6U

Agreed that this is just collecting resources things and taking notes as we go.
WE will use for the blog post #9

Jenkins World 2016 - No, You Shouldn't Do That! Lessons from Using Pipeline https://www.youtube.com/watch?v=lLZwTMFf9GI

I think we got pipeline support down by now :)


Terminal Bell on Windows (ref #131)

The terminal bell on Windows is always on, regardless of setting. Issue was already persistent a while ago, however that issue seems to be closed without a fix. See #131 .

Which shell are you using? WSL or something else?

WSL / Ubuntu


Unable to start node-red on windows 10

I'm currently embedding node-red in out product and it does work very well, expect on windows. As part of the trouble-shooting I've installed node-red (0.12.4) via npm on a vanilla Windows 10 VM, rebooted it just in case, and.. can't get it to run.
When I start node-red from the command-prompt, it just sits there looking sad after saying 'started flows'. No errors, or security prompts or anything like that. Do you know of a way to get it working?

That screenshot shows a perfectly running instance of node-red to me. Why do you think it isn't running?

 I mistook our
behaviour from that of node-red proper.
On Thu, Dec 17, 2015 at 3:54 PM, knolleary<EMAIL_ADDRESS>wrote:

That screenshot shows a perfectly running instance of node-red to me. Why
do you think it isn't running?
—
Reply to this email directly or view it on GitHub
https://github.com/node-red/node-red/issues/772#issuecomment-165474563.


v9.0.11 introduces sparse array regression

🐛 Bug Report
#879 looks like an awesome fix -- thank you! -- but it has a side-effect of breaking sparse arrays created with delete.
I'm a comfortable immer user but relatively new to contributions. If someone has the time to coach, I would be glad to iterate on #879. Thanks for your time
To Reproduce
const produce10 = require("immer-v9.0.10").default;
const produce19 = require("immer-v9.0.19").default;

/**
 * @returns {number[]}
 */
const initialState = () => [];

[
  ["v9.0.10", produce10],
  ["v9.0.19", produce19],
].forEach(([version, produce]) => {
  console.log(`Testing ${version}`);

  console.log("Produces [<empty>, 42]");
  // Create sparse array with insertion
  const stateA = produce(initialState(), (draft) => {
    draft[1] = 42;
  });
  console.info(stateA);
  expect(stateA[0], undefined, "Panic!"); // actually empty, but we expect undefined
  expect(stateA[1], 42, "Panic!");

  let iterateForEach = 0;
  stateA.forEach(() => {
    iterateForEach += 1;
  });
  expect(iterateForEach, 1, "Array.forEach does not iterate empty elements");

  let iterateForLoop = 0;
  for (let i = 0; i < stateA.length; i++) {
    iterateForLoop += 1;
  }
  expect(iterateForLoop, 2, "Delete does not alter array length");

  console.log("Produces [<empty>, <empty>]");
  // Create sparse array with delete
  const stateB = produce(stateA, (draft) => {
    delete draft[1];
  });
  console.info(stateB);
  expect(stateB[0], undefined, "Panic!"); // actually empty, but we expect undefined
  expect(stateB[1], undefined, "Panic!"); // actually empty, but we expect undefined

  iterateForEach = 0;
  stateB.forEach(() => {
    iterateForEach += 1;
  });
  expect(iterateForEach, 0, "Array.forEach does not iterate empty elements");

  iterateForLoop = 0;
  for (let i = 0; i < stateB.length; i++) {
    iterateForLoop += 1;
  }
  expect(iterateForLoop, 2, "Delete does not alter array length");

  console.log(`${version} success`);
});

/**
 * @param {any} left
 * @param {any} right
 * @param {string} reason
 * @returns {void}
 */
function expect(left, right, reason) {
  if (left !== right) {
    throw new Error(reason);
  }
}

{
  "name": "sparse-test",
  "version": "1.0.0",
  "description": "Sparse array regression in ImmerJS",
  "main": "index.js",
  "scripts": {
    "test": "node index.js"
  },
  "author": "Bever1337<EMAIL_ADDRESS>  "license": "MIT",
  "dependencies": {
    "immer-v9.0.10"<EMAIL_ADDRESS>    "immer-v9.0.19"<EMAIL_ADDRESS>  }
}

Observed behavior
delete creates dense arrays with undefined values
Expected behavior
delete creates sparse arrays
Environment
We only accept bug reports against the latest Immer version.

Immer version:
[X] I filed this report against the latest version of Immer
[ ] Occurs with setUseProxies(true)
[ ] Occurs with setUseProxies(false) (ES5 only)

Random thoughts I had about sparse arrays/elisions that might inform this request:

Immer does not cast elisions when creating sparse arrays
elisions are primitive/immutable/non-referential
redux serializability middleware does not complain about elisions.
elisions can be cloned with structured clone algorithm
JSON parsing will cast elisions to null (interesting but only relevant as an example of how JS treats holes)

To be fair I don't think Immer very intentionally supports sparse arrays. Especially not as something to be distinguished from undefined entries. Likewise we don't support assigning arbitrary fields to an array like array["hello"] = "world" even though that is technically valid JS.
Imho using delete on an array is an anti-pattern, and just happenstancily "works" because an array is an object under the hood. But as you noticed yourself, it behaves quite inconsistently in the rest of the language.
I recommend to use a more idiomatic alternative instead to remove elements from arrays, like  assigning undefined / null, splicing, or if your data structure is intentionally very sparse and acts more like a lookup map, you should probably be using Map instead.

@mweststrate That makes a lot of sense, and thank you for your time! I commented on the other PR that also extends array patches for adding and removing items. Unfortunately for me :wink:, it is a much better direction and I'm excited for it to land. Sparse arrays are uncommon, can't be represented with JSON/JSON patches, and don't work in ReduxJS. As an immer user, I'm not strictly tied to ReduxJS or a state that can be serialized into JSON, but the common use-case is better here.

Imho using delete on an array is an anti-pattern, and just happenstancily "works" because an array is an object under the hood.

I wouldn't call it happenstance that an array is an object 😛 Everything is an object in JS! What's the justification for claiming all sparse arrays are anti-pattern? I'm not sure I see how that fits into the conversation.

anti-pattern

Anti pattern, because it doesn't solve any problem that isn't solved more idiomatically otherwise, behaves unpredictable with other standard functions and libraries, and afaik de-opts from a lot of performance optimisations (that is true for delete on objects as well, but for objects there are valid use cases, although I'd still consider it something that is very rarely needed)


Sitemap.aspx is not longer accepted by Google Search Console

Open Google Search console and add new sitemap: domain.com/sitemap.aspx
Error: can't fetch (type unknown)
url sitemap.aspx is available in browser ans is a valid xml format
Tested the url in several sitemap validators and all pass
When you save the sitemap.aspx in sitemap.xml the sitemap is accepted and show the indexed pages
Steps to reproduce
List the steps to reproduce the behavior:

Open Google Search console
Add sitemap
domain.com/sitemap.aspx
Save

Error log
can't fetch (unknown type)
Affected version
DNN 9.2.2
DNN 9.3.2

can this be saved as an XML instead of aspx I believe that is the issue here as it has been a long time problem for versions ever since it was created in DNN as far back as I can remember.  This would be a good one to resolve.

Hmm, I never had an issue submitting sitemap.aspx not sure if google changed something recently I don't have any new site right now to submit but all my existing sites are using sitemap.aspx and get refreshed correctly.

i can do it through the google webmaster site. but never using DNN

Try a new DNN9 website and add your sitemap.aspx in Google Search Console. You wil see it's not accepted.
And yes sitemaps that were added in the past keep working on sitemap.aspx.
The problem only exist for new websites.

@thabaum

The format inside the file I believe is just like an XML file.

Yes not only the format but the mime-type too. I think what happens is that google now supports multiple sitemap formats and wrongly relies on the file name instead of the returned mime type to decide the type of sitemap.

For those who know more about it than me, could url routing (like used for service routes) be used in a similar fashion to point requests for SiteMap.xml to SiteMap.aspx transparently?
Something along the lines of:
RegisterRoutes(RouteCollection routes)
{
    routes.MapPageRoute(
        "sitemap",
        "sitemap.xml",
        "~/sitemap.aspx"
    );
}

I know Sacha Trauwaen made the open url rewriter module which (among some other nice additions) took care of this: https://github.com/sachatrauwaen/OpenUrlRewriter

@valadas I'm not sure if routing would work without trying it but this could be done using a URL Provider extension. I'm going to be doing something similar soon for a portal level robots.txt file.  I'll take a look at this if this is still open when I look at the robots and see if it would work in a similar way.

Rewrite is a workaround option but I hoped it could be fixed in DNN core.
I assume many DNN users have this problem and the sitemap functionality is quite essential to get your DNN website indexed the right way

I only just now found this thread, I was the one posting this on the Google Forum (since GSC does not have a real support). I will update my question there with the remark about file extension.
Thank you @EPTamminga for the rewrite solution/workaround.

Will this:

create an .xml file and if so where do I place it in web.config.  please forgive me but I am a newbie

@EdwardGraham See my comment with my instructions placed here on 19 nov.

I saw that and my question was where to put it in the web.config

In the <system.webServer> section.
Just google on “how to add redirect rule in web config” and you will find several instructions.

EPT Thank you it goes right under the    and seems to be working now off to google to try and register the site
Thank you

While there is a workaround, given that Google Search Console is quite popular and a lot of solutions use .xml sitemaps, I think we should look at adding .xml support out of the box for this.
Please go ahead and assign it to me, I will take a look at a potential resolution for it in the coming weeks that doesn't require new core dependencies.

Thank you!
-----Original Message-----
From: Mike Smeltzer<EMAIL_ADDRESS>To: dnnsoftware/Dnn.Platform<EMAIL_ADDRESS>Cc: EdwardGraham<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Sent: Tue, Mar 24, 2020 12:48 pm
Subject: Re: [dnnsoftware/Dnn.Platform] Sitemap.aspx is not longer accepted by Google Search Console (#3277)
While there is a workaround, given that Google Search Console is quite popular and a lot of solutions use .xml sitemaps, I think we should look at adding .xml support out of the box for this.Please go ahead and assign it to me, I will take a look at a potential resolution for it in the coming weeks that doesn't require new core dependencies.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Awesome @mikesmeltzer Assigned to you and triaged.

Looks like Google Search Console does accept sitemap.aspx again

Looks like Google Search Console does accept sitemap.aspx again

Thanks for the info, glad this is no longer an impediment.

Yes I was just successful in submitting the sitemap as well

Awesome, so was this a google bug and we close this issue or do we keep this because someone wanted to still implement a solution?

IMO it would not be bad to server with with an XML extension, to prevent future issues

We could add a standard rule in de web.config that is used in the install pack

I think it should serve both... I thought it did in the past.  So if you type Sitemap.xml or Sitemap.aspx it would show the same file since... they are exactly the same.
Why not just create an alias for it?

Well, it is a bit more complex than an alias, xml is a static file that does not go through the normal pipeline of dynamic files. So we would need some kind of url handler to catch that url and pipe it through some dynamic handling code.

I personally would not support the addition of an additional alias to this file.  It should have one name, if we want to change to sitemap.xml we can, but that would be a breaking change for others.  There is no impact with regards to it being sitemap.aspx.

I personally would not support the addition of an additional alias to this file. It should have one name, if we want to change to sitemap.xml we can, but that would be a breaking change for others. There is no impact with regards to it being sitemap.aspx.

True, but Google expects the xml extension apparently (not completely unreasonable IMO). So I think it would be good to avoid issue in the future in case Google would change their "policy" again?

A rule in web.config solves this case? No need to change sitemap.aspx?

Per the guidelines in google here https://support.google.com/webmasters/answer/183668?hl=en
There is not a requirement to have it named .xml, the format has to be one of many supported but the name isn’t noted as a requirement.
Adding a redirect to web.config depends on an optional IIS component and could be a breaking change. It also adds a second redirect manager to all requests

If the .xml extension is really needed, why not put a button that generates the file? and if it already exists, warns the user and asks if he wants to replace

why not just add "Sitemap: https://www.exampledomainhere.com/sitemap.aspx" into your robots.txt ?

why not just add "Sitemap: https://www.exampledomainhere.com/sitemap.aspx" into your robots.txt ?

There was a period (a couple of months) where Google Search Console did not accept the .aspx extension. In the end of March 2020 and onward GSC accepted it again.


Editor unable to find node module and other build artifacts.

This may not be the right place to post this issue, but I have to start somewhere.
I am just starting with Bazel, so this might be a simple config change I need to do and have missed or overlook.
I can not figure out how to get the editors VS Code and Vim to find both the node_modules installed by pnpm and the build artifacts produced from running Bazel build. This prevents me from using code compilation in the editors, and I get errors on all imports.
For example when I open apps/alpha/src/main.ts from aspect-build/bazel-examples then I get these error in my editors.
VS Code

Vim

Is it possible to have the same editor experience when using Bazel with the aspect-build/rules_ts as when not using Bazel and just building will the code with the standalone typescript compiler tsc?

The solution is to run pnpm install in the root of the project and then Iðm able to use it in both editors.


fix: added the missing link

fix:#1503
added the link to the [Keptn Lifecycle Toolkit README file]
now its workiing fine
Signed-off-by: Nitishupkr<EMAIL_ADDRESS>

@StackScribe a quick merge on this would be fantastic. Thanks.


Using GPG

I noticed that GPG was missing in version 2.0.20 and an issue, #107,  that created to point this out. Which resulted in a fix via #109.
Based on the fix I have two questions.
1). The fix basically included an extra line to install gnupg directly inside Dockerfile. However, the build.sh already has a check to install gnupg if the environment flag is set.
After trying to build the docker image locally, I noticed that it does try to install it, however it fails with the following error:
#14 4.050 ERROR: unable to select packages:
#14 4.052   gnupg-2.4.4-r0:
#14 4.052     breaks: world[gnupg=2.4.3-r1]

To me it seems the fix should actually just change the version to 2.4.4-r0, as this seems to be the version is is available for alpine 3.18. Instead of fixing by including and apk add command.
2.) When will there be another releases that has this fix available? It seems I could use the dev.275 tag for the image, hower these dev versions don't have the variants where the various providers are excluded.

I think you are right, could you make a PR for it and test the dev version, and I will create a release after?


Overhaul lifting mechanism

Only defcalls should be liftable. RefTerm is not supposed to be liftable.
By that, we can discard the features related to lifting metas.
Also, we have a much simpler model of universes.

Why is RefTerm not supposed to be liftable?

@tsao-chi Consider Lean: only global definitions are allowed to be universe polymorphic, not local variables.

@ice1000 Is it a design choice?

@tsao-chi You can say that. I'm sure it has a fairly simple semantics. Allowing rank-n universe polymorphism will make the semantics much more complex, and will be hard to implement (bc holes can be lifted too, hence we need un-lifting to have complete unification).
The original design of the "crude but effective stratification" mechanism we used does not have local lifting. Let's stick to expert's opinion.


Refactor 30 lines occurring 6 times in index.js

I've selected for refactoring 30 lines of code which are duplicated in 1 file(s) (1, 2, 3, 4, 5, 6).  Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Code Once guideline rating! 👍
Here's the gist of this guideline:

Definition 📖
Do not copy code.
Why❓
When code is copied, bugs need to be fixed in multiple places. This is both inefficient and a source of regression bugs.
How 🔧
Avoid duplication by never copy/pasting blocks of code and reduce duplication by extracting shared code, either to a new unit or introduce a superclass if the language permits.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲  next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! :shipit: :sparkles: :100:

Fixed


feat: add webhooks for consumer/tls/upstream

Please answer these questions before submitting a pull request

Why submit this pull request?

[ ] Bugfix

[x] New feature provided

[ ] Improve performance

[ ] Backport patches

Related issues

New feature or improvement

Describe the details and related test reports.

Add webhooks for consumer/tls/upstream.
TODO

[x] add webhooks
[ ] add e2e test cases
[ ] update helm chart

Codecov Report

Merging #667 (d2430ad) into master (6a8658d) will decrease coverage by 0.52%.
The diff coverage is 11.27%.

:exclamation: Current head d2430ad differs from pull request most recent head 15f7e21. Consider uploading reports for the commit 15f7e21 to get more accurate results

@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
- Coverage   34.77%   34.24%   -0.53%
==========================================
  Files          60       63       +3
  Lines        5916     6027     +111
==========================================
+ Hits         2057     2064       +7
- Misses       3608     3712     +104
  Partials      251      251

Impacted Files
Coverage Δ

pkg/api/validation/apisix_consumer.go
0.00% <0.00%> (ø)

pkg/api/validation/apisix_tls.go
0.00% <0.00%> (ø)

pkg/api/validation/apisix_upstream.go
0.00% <0.00%> (ø)

pkg/apisix/apisix.go
67.50% <ø> (ø)

pkg/apisix/nonexistentclient.go
41.79% <0.00%> (-0.64%)
:arrow_down:

pkg/api/validation/apisix_route.go
21.42% <10.00%> (-0.11%)
:arrow_down:

pkg/api/validation/utils.go
32.43% <35.29%> (-13.73%)
:arrow_down:

pkg/api/router/webhook.go
100.00% <100.00%> (ø)

pkg/apisix/schema.go
64.70% <100.00%> (+1.44%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a8658d...15f7e21. Read the comment docs.

I just found that there is already basic validation in CRDs, so could you provide some cases that can not be validated in CRD, then I will replace the logic in webhooks with yours.

@fgksgf you can just fix the lint error. then we can move forward.

@fgksgf you can just fix the lint error. then we can move forward.

I just didn't figure out why the linter report the error:

There is no lint errors when I run make lint locally.

@fgksgf I think, it's a GitHub Action's bug.
I have trigerd it on my fork using same env. It can be pass. https://github.com/tao12345666333/ingress-controller/runs/3684766821?check_suite_focus=true

We can skip the lint error.
WDYT? @gxthrj @tokers

We can skip the lint error.
WDYT? @gxthrj @tokers

Agree, we already have our own lints.

Yes, I have checked the lint too, it can pass.
If there is no other need to modify, we can merge this PR. cc @tao12345666333 @tokers @lingsamuel

+1 can't repro. I triggered it again, let's see if it will pass. If not, we may need to create an ignore rule.

+1

ApisixRoute v2beta2 version was introduced in #698
The corresponding check was not covered in this PR.
Let's merge this PR first, and then increase the coverage of v2beta2 in subsequent PRs.


Can't update VS Code - access denied on Code.admx file

Note there is a related issue at: #150287. I can work around the issue by running the update as admin/granting access to the file but filling the issue as that's probably not what should happen.

VS Code Version: 1.67.1
OS Version: Windows 11 - 22H2 - 22621.450

Steps to Reproduce

Update VS Code from the prompt in VS Code

Expected
Update, no issue.
Actual
Error message "Access is denied" to the code.admx file (details below). I'm not running VS Code.

Extra Information
Error Message
There was an error while Opening file handle: "C:\Users\andster\AppData\Local\Programs\Microsoft VS Code\policies\Code.admx":
Failed to create file handle: Access is denied.
Please verify there are no Visual Studio Code processes still executing.
Log
vscode-inno-updater-1659735052.log
Not running a code.exe process
There are no Visual Studio Code processes still executing and no handles to the file are open (not that you'd expect it to help as the issues seems to be a missing ACL).
PS C:\tools\SysInternals> .\handle.exe |findstr /i "Code.admx"
PS C:\tools\SysInternals>
PS C:\Users\andster> Get-Process code.exe
Get-Process : Cannot find a process with the name "code.exe". Verify the process name and call the cmdlet again.
VS Code info
Version: 1.67.1 (user setup)
Commit: da15b6fd3ef856477bf6f4fb29ba1b7af717770d
Date: 2022-05-06T12:37:03.389Z (3 mos ago)
Electron: 17.4.1
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.70.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

The problem

Closed as a dupe of #157341. I didn't realize the old issue was the same version as mine.

I think 1.70 includes changes to address this going forward. Pinging @joaomoreno


removed the swirls image from background

pseudo element is not removed. Only background property is removed.
Issue-#39


Added

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@AftabAnsari10662 : Thanks for your contribution to the Azure documentation! The author, @naziml, has been notified to review your proposed change.

@jomolnar Request you to review the PR.

@AftabAnsari10662 The author, @naziml, is assigned to review the content.

@AftabAnsari10662, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

#sign-off


fixed code to display.sort by MOD abbreviation

Thanks @azurebrd ! yes, it works or XB too.

great !


When saving a new .ipynb, kernel reverts to Python

Steps to reproduce:

Create a new blank notebook, selecting the .ipynb option.
Run some code.
Save the file.
Note when the editor refreshes, the kernel selector shows Python and the run button is no longer responsive.

+1 saw a user run into this today

This appears to be fixed as of extension version 1.0.360602.


Landing page

Description
Please include a summary of the change and a link to which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Test A
[ ] Test B

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

There is a merge conflict. Git pull from master may show conflicts in your local branch. Modify it and if you could do one more push, we will be able to merge it.


add reference for two new ref docs to FRAME lectures

Adds reference to the content added in https://github.com/paritytech/polkadot-sdk/pull/3362

@kianenigma please keep in mind that this will not released in Hong Kong content, but in the next one.

yup sounds good, that is the intention.


Added another bronze sponsor

Added Ability Connect's logo to bronze sponsor.

Sorry, forgot to also update mobile mode for the sponsors, also fixed the issue we were facing on devfolio registration link not appearing on mobile mode.


Minimal example does not work without minor fix

Hey guys, it looks like you need to add ruclip to list of dependencies to run the minimal example.

Yep. The same problem after 4 month. We need use pip install ruclip

We add this dependence and updated the minimal example.


dwarf-fortress-full package is mentioned in dwarf-fortress/default.nix but doesn't appear to be available

A package called dwarf-fortress-full is mentioned here:
https://github.com/NixOS/nixpkgs/blob/7c66a902ce342036a63146a9b7ebd92d9d9ad287/pkgs/games/dwarf-fortress/default.nix#L7-L8
And appears to be exported here:
https://github.com/NixOS/nixpkgs/blob/7c66a902ce342036a63146a9b7ebd92d9d9ad287/pkgs/games/dwarf-fortress/lazy-pack.nix#L19-L24
I'm on NixOS version 18.03 and just ran nixos-rebuild switch --upgrade, but this package doesn't appear to be available (I can't find it on the nix-package website either https://nixos.org/nixos/packages.html#dwarf-fortress). I don't know enough about the nix packaging system to know why this might be.

cc @Baughn  and @volth if you guys are still maintaining this package :)

Yeah, I noticed the documentation failure.
I've been on vacation for the last couple of weeks, but I still have some improvements in mind for this thing. I'll fix the bug while I'm at it.

Docs are improved; check master :-)

This seems to be resolved as dwarf-fortress-packages.dwarf-fortress-full exists.


python main_test.py failed

Thank you so much for your great repo.
I followed the instruction and created a conda environment and run
python main_test.py
I got the following error messages:
(reinvent.v3.0) xzhang@R1124G1:~/projects/Reinvent$ python main_test.py
Traceback (most recent call last):
File "main_test.py", line 7, in
from unittest_reinvent.running_modes import *
File "/home/xzhang/projects/Reinvent/unittest_reinvent/running_modes/init.py", line 1, in
from unittest_reinvent.running_modes.create_model_tests import *
File "/home/xzhang/projects/Reinvent/unittest_reinvent/running_modes/create_model_tests/init.py", line 1, in
from unittest_reinvent.running_modes.create_model_tests.test_create_model import TestCreateModel
File "/home/xzhang/projects/Reinvent/unittest_reinvent/running_modes/create_model_tests/test_create_model.py", line 9, in
from unittest_reinvent.fixtures.paths import MAIN_TEST_PATH, SMILES_SET_PATH
File "/home/xzhang/projects/Reinvent/unittest_reinvent/fixtures/paths.py", line 5, in
with open(os.path.join(project_root, '../../configs/config.json'), 'r') as f:
FileNotFoundError: [Errno 2] No such file or directory: '/home/xzhang/projects/Reinvent/unittest_reinvent/fixtures/../../configs/config.json'
Could you please help me? Thanks

Thanks for your interest in REINVENT.
To use the unit tests you need to create config.json file with setting certain paths. This is also described in the readme.
SMILES_SET_PATH should be the file located in : Reinvent Community
Please, let us know if that is not the case.

Thank you for your reply.
Do you mean that based on config/example.config.json, create a config.json file? But I don't have OpenEye license, could you tell me how to modify the example.config.json. Many thanks!

@xuzhang5788  I would only assign a path to the "MAIN_TEST_PATH" variable. Simply copy the rest of the contents of the example into the config/config.json
@GuoJeff I suspect we would need to think of some more intuitive example of how to set up the config/config.json file. This seems to confuse a lot of people.


[GHSA-g4rg-993r-mgx7] Improper Neutralization of Special Elements used in a Command in Shell-quote

Updates

CVSS
Severity

Comments
https://nvd.nist.gov/vuln/detail/CVE-2021-42740
https://github.com/substack/node-shell-quote/commit/5799416ed454aa4ec9afafc895b4e31760ea1abe
https://github.com/substack/node-shell-quote/blob/master/CHANGELOG.md#173
https://www.npmjs.com/package/shell-quote

gi

Hi @MyTrueWallet, do you have a justification for this change?


Website main content scales too wide, hard to read

We should define a max widget to the main content. Very long lines are hard to follow.

Same as https://github.com/flutter/flutter/issues/10084 , I think


[Plugin] Upgrade fstream version to fix vulnerability

Versions of fstream prior to 1.0.12 are vulnerable to Arbitrary File Overwrite.
Upgrade fstream to 1.0.12 to fix vulnerability.

Coverage increased (+0.01%) to 53.229% when pulling 0d98500242ac99d309d1bae80d6d63ffc5db17b8 on xiongyf/fix-fstream-vulnerability into 1064bf216abbd72555f8d68c28d801b41442c43c on master.

Coverage increased (+0.01%) to 53.229% when pulling 0d98500242ac99d309d1bae80d6d63ffc5db17b8 on xiongyf/fix-fstream-vulnerability into 1064bf216abbd72555f8d68c28d801b41442c43c on master.

Coverage increased (+0.01%) to 53.229% when pulling 0d98500242ac99d309d1bae80d6d63ffc5db17b8 on xiongyf/fix-fstream-vulnerability into 1064bf216abbd72555f8d68c28d801b41442c43c on master.


[Search] Update release date in changelog

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

/check-enforcer override


[SPARK-18500][SQL] Make GenericStrategy be able to prune plans by itself after placeholders are replaced.

What changes were proposed in this pull request?
This pr adds a functionality to GenericStrategy to be able to prune bad physical plans by itself after their placeholders are replaced.
How was this patch tested?
Added a test to check if the strategy can prune plans by itself.

@marmbrus Could you review this pr please?

Test build #68831 has started for PR 15927 at commit 89bf202.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68831/
Test FAILed.

Jenkins, retest this please.

Test build #68836 has started for PR 15927 at commit 89bf202.

Test build #68836 has finished for PR 15927 at commit 89bf202.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68836/
Test FAILed.

Jenkins, retest this please.

Test build #68846 has started for PR 15927 at commit 89bf202.

Test build #68846 has finished for PR 15927 at commit 89bf202.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68846/
Test PASSed.

Merged build finished. Test PASSed.

Test build #68852 has started for PR 15927 at commit fb30fa1.

Test build #68852 has finished for PR 15927 at commit fb30fa1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68852/
Test PASSed.

Test build #69520 has started for PR 15927 at commit 75d4012.

Test build #69520 has finished for PR 15927 at commit 75d4012.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69520/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins, retest this please.

Test build #69533 has started for PR 15927 at commit 75d4012.

Test build #69533 has finished for PR 15927 at commit 75d4012.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69533/
Test PASSed.

cc @ueshin

I'd close this for now.


Use reversed shuffled list in validator duties retrieval

Would it make sense to keep a reverse shuffled list to speed this even more?
If the shuffled array looks like [3,0,2,1] the reverse array would be [1,3,2,0]. Given a validator index you could get its postion in the shuffled array in O(1) time. From there with modulos you can figure out the slot, committee and index.
Would that be worth it the extra memory? At 250_000 validators x 8 bytes = 2MB
Originally posted by @dapplion in https://github.com/ChainSafe/lodestar/issues/2717#issuecomment-869968368

@dapplion to clarify, what do you mean by "reversed" exactly?  Should the reversed array in your example by [1, 2, 0, 3]?

@dapplion to clarify, what do you mean by "reversed" exactly? Should the reversed array in your example by [1, 2, 0, 3]?

So it's not literally reversed, but an array showing the position of validator {i} in the shuffled list.

After this many months, I don't believe this is necessary or won't provide tangible benefits


Batch Mode to order by batch timestamp first and then by scorecard timestamp

Having 2 people do data entry for the same round simultaneously can be a pain, but batch mode could be enhanced to make it much easier.
Say we have Batches A and B and scorecards 1-6. Person A enters scorecard 1, then Person B enters scorecard 2, then alternating so A does the odds and B does the evens. Batch A is submitted after entering scorecard 5 and Batch B after scorecard 6.
Currently: When both batches are submitted, the scorecards are ordered by submission timestamp, i.e. 1-6. But Person A has 1,3,5 in their pile and Person B has 2,4,6 in their pile.
Suggestion: The scorecards are first ordered by the submission timestamp of the batch, and then scorecards within that batch are ordered by the submission timestamp of the scorecard. This would now order the scorecards as 1,3,5,2,4,6. Now Person B can stack their scorecards directly on top of Batch A and the order will be preserved. Alternatively, if Person B now wanted to double check their scorecards whilst Person A started entering Batch C, all of the scorecards within their batch would be kept together.
This will make double checking much much better for batch entry, which means it will be a huge improvement to being able to enter data simultaneously across multiple devices. Imo this could be a crucial change for large competitions and major championships.

We don't store batch submission time, but that wouldn't help entirely since people may be submitting batches more often than once per whole pile, so it's the same issue just less granular.
What we could do however, is to change the order in double-check such that we first group by the scoretaker, then by timestamp.

That sounds like a much cleaner solution! That wouldn't necessitate needing to switch to batch mode to make use of this feature either.

Just a thought - does scoretaker refer to the account that's logged in? In the UK we will have a couple of laptops both logged into the UKCA account, so if there could be a way to distinguish between them that would be super useful to us!

Closing this now as it isn't quite relevant, and made a new issue #196 to capture it more accurately.

Closing, as this is tracked in #133.


Stage health status showing unhealthy despite being synced to correct sha

The status is unhealthy because the Application is not synced to revision 6d13e269dc243335bf098f505d1e12214a301fe5. I can't find where this revision is coming from.
The freight for the stage shows ec31f4da8e81e8b8b5446c9d0a56559cfcfff5f5, which is what the Application is synced to.
Screenshots inside!

Live Kargo `Stage` manifest inside!
apiVersion: kargo.akuity.io/v1alpha1
kind: Stage
metadata:
  name: test
  namespace: kargo-demo
  uid: 54ed2308-b87b-4010-8cd1-fb29efdbdafb
  resourceVersion: "68748"
  generation: "4"
  creationTimestamp: 2023-09-19T16:33:09Z
  labels:
    argocd.argoproj.io/instance: kargo-stages
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: >
      {"apiVersion":"kargo.akuity.io/v1alpha1","kind":"Stage","metadata":{"annotations":{},"labels":{"argocd.argoproj.io/instance":"kargo-stages"},"name":"test","namespace":"kargo-demo"},"spec":{"promotionMechanisms":{"argoCDAppUpdates":[{"appName":"kargo-demo-test","appNamespace":"argocd"}],"gitRepoUpdates":[{"kustomize":{"images":[{"image":"nginx","path":"stages/test"}]},"repoURL":"https://github.com/morey-tech/kargo-demo/","writeBranch":"stages/test"}]},"subscriptions":{"repos":{"git":[{"branch":"main","repoURL":"https://github.com/morey-tech/kargo-demo/"}],"images":[{"repoURL":"nginx","semverConstraint":"^1.24.0","updateStrategy":"SemVer"}]}}}}
spec:
  subscriptions:
    repos:
      git:
        - repoURL: https://github.com/morey-tech/kargo-demo/
          branch: main
      images:
        - repoURL: nginx
          updateStrategy: SemVer
          semverConstraint: ^1.24.0
  promotionMechanisms:
    gitRepoUpdates:
      - repoURL: https://github.com/morey-tech/kargo-demo/
        writeBranch: stages/test
        kustomize:
          images:
            - image: nginx
              path: stages/test
    argoCDAppUpdates:
      - appName: kargo-demo-test
        appNamespace: argocd
status:
  availableFreight:
    - id: c7b360e96c684f446fa41821eae101f6a9a4bbdc
      firstSeen: 2023-09-20T14:59:22Z
      commits:
        - repoURL: https://github.com/morey-tech/kargo-demo/
          id: ec31f4da8e81e8b8b5446c9d0a56559cfcfff5f5
          branch: main
          message: "fix(kargo): switch to valuesObject"
      images:
        - repoURL: nginx
          tag: 1.25.2
      qualified: true
    - id: b81563ef088ab61aeefc01af49b7ae3560c815ee
      firstSeen: 2023-09-20T14:56:57Z
      commits:
        - repoURL: https://github.com/morey-tech/kargo-demo/
          id: 7a2245e561eb2b5aff8db86e8235f2a0635415a9
          branch: main
          message: "fix(kargo): remove escapes"
      images:
        - repoURL: nginx
          tag: 1.25.2
      qualified: true
    - id: 544a0c7f81a56f9167a117e5719ac0874fd73a1a
      firstSeen: 2023-09-20T14:54:44Z
      commits:
        - repoURL: https://github.com/morey-tech/kargo-demo/
          id: daad8ed5511f72a70eed7e84c2ecef4c7455c0ac
          branch: main
          message: "fix(kargo): map to empty string"
      images:
        - repoURL: nginx
          tag: 1.25.2
      qualified: true
    - id: bb61527632d6199d49895c7c80036d5dfb18787d
      firstSeen: 2023-09-20T14:49:10Z
      commits:
        - repoURL: https://github.com/morey-tech/kargo-demo/
          id: 0a64e58cc067594e407586ee38de7b8eb4117587
          branch: main
          message: "fix(kargo): parameter is map"
      images:
        - repoURL: nginx
          tag: 1.25.2
      qualified: true
    - id: e578fa506e2226bad4aeb38f5c816ee930dd989b
      firstSeen: 2023-09-20T14:46:55Z
      commits:
        - repoURL: https://github.com/morey-tech/kargo-demo/
          id: e0b42c63115a0e63c51a65d90851f2ec54fbb432
          branch: main
          message: "feat(kargo): enable argocd deep-links"
      images:
        - repoURL: nginx
          tag: 1.25.2
      qualified: true
    - id: bb33a5fcd71235feaf9d8025e4a475d542b9f074
      firstSeen: 2023-09-20T14:43:45Z
      commits:
        - repoURL: https://github.com/morey-tech/kargo-demo/
          id: 29d0fd8ed88ad4c0b9695fcf06f7daba26e94d3e
          branch: main
          message: "fix(stage): write test to test branch"
      images:
        - repoURL: nginx
          tag: 1.25.2
      qualified: true
    - id: b84805de51c0410525e916130cd1bde754040d13
      firstSeen: 2023-09-20T14:33:34Z
      commits:
        - repoURL: https://github.com/morey-tech/kargo-demo/
          id: d4da2a80004bd34cd6379a7e63474126010fd38f
          branch: main
          message: "feat(test): add h2 heading"
      images:
        - repoURL: nginx
          tag: 1.25.2
      qualified: true
    - id: 489940670ccb6a1d0e96d9ed06b0a0b428ee1fcf
      firstSeen: 2023-09-20T14:27:28Z
      commits:
        - repoURL: https://github.com/morey-tech/kargo-demo/
          id: 78e9f589f090a5c6f4b60a443078d0460e00ae6e
          branch: main
          message: "feat(stages): test subscribed to git"
      images:
        - repoURL: nginx
          tag: 1.25.2
      qualified: true
    - id: b73f9d1afaca87254b64e64e5439557e86dcba79
      firstSeen: 2023-09-19T16:33:10Z
      images:
        - repoURL: nginx
          tag: 1.25.2
      qualified: false
  currentFreight:
    id: c7b360e96c684f446fa41821eae101f6a9a4bbdc
    firstSeen: 2023-09-20T14:59:22Z
    commits:
      - repoURL: https://github.com/morey-tech/kargo-demo/
        id: ec31f4da8e81e8b8b5446c9d0a56559cfcfff5f5
        branch: main
        healthCheckCommit: 6d13e269dc243335bf098f505d1e12214a301fe5
        message: "fix(kargo): switch to valuesObject"
    images:
      - repoURL: nginx
        tag: 1.25.2
    qualified: false
  history:
    - id: c7b360e96c684f446fa41821eae101f6a9a4bbdc
      firstSeen: 2023-09-20T14:59:22Z
      commits:
        - repoURL: https://github.com/morey-tech/kargo-demo/
          id: ec31f4da8e81e8b8b5446c9d0a56559cfcfff5f5
          branch: main
          healthCheckCommit: 6d13e269dc243335bf098f505d1e12214a301fe5
          message: "fix(kargo): switch to valuesObject"
      images:
        - repoURL: nginx
          tag: 1.25.2
      qualified: false
    - id: b81563ef088ab61aeefc01af49b7ae3560c815ee
      firstSeen: 2023-09-20T14:56:57Z
      commits:
        - repoURL: https://github.com/morey-tech/kargo-demo/
          id: 7a2245e561eb2b5aff8db86e8235f2a0635415a9
          branch: main
          healthCheckCommit: 152d43f0fee9d85a32589069a58e85d650b135f9
          message: "fix(kargo): remove escapes"
      images:
        - repoURL: nginx
          tag: 1.25.2
      qualified: false
    - id: 544a0c7f81a56f9167a117e5719ac0874fd73a1a
      firstSeen: 2023-09-20T14:54:44Z
      commits:
        - repoURL: https://github.com/morey-tech/kargo-demo/
          id: daad8ed5511f72a70eed7e84c2ecef4c7455c0ac
          branch: main
          healthCheckCommit: db51e64adafefcb11de135e1d65a7f05bec68f0c
          message: "fix(kargo): map to empty string"
      images:
        - repoURL: nginx
          tag: 1.25.2
      qualified: false
    - id: bb61527632d6199d49895c7c80036d5dfb18787d
      firstSeen: 2023-09-20T14:49:10Z
      commits:
        - repoURL: https://github.com/morey-tech/kargo-demo/
          id: 0a64e58cc067594e407586ee38de7b8eb4117587
          branch: main
          healthCheckCommit: 0b5ab95b3acd0af52598e894c338c3f171c18e9d
          message: "fix(kargo): parameter is map"
      images:
        - repoURL: nginx
          tag: 1.25.2
      qualified: false
    - id: e578fa506e2226bad4aeb38f5c816ee930dd989b
      firstSeen: 2023-09-20T14:46:55Z
      commits:
        - repoURL: https://github.com/morey-tech/kargo-demo/
          id: e0b42c63115a0e63c51a65d90851f2ec54fbb432
          branch: main
          healthCheckCommit: 1e20405209d0831c70c0191d53eaff301e30c985
          message: "feat(kargo): enable argocd deep-links"
      images:
        - repoURL: nginx
          tag: 1.25.2
      qualified: false
    - id: bb33a5fcd71235feaf9d8025e4a475d542b9f074
      firstSeen: 2023-09-20T14:43:45Z
      commits:
        - repoURL: https://github.com/morey-tech/kargo-demo/
          id: 29d0fd8ed88ad4c0b9695fcf06f7daba26e94d3e
          branch: main
          healthCheckCommit: 0118dffc84eb9778f1beed198a4556f767f3dd2f
          message: "fix(stage): write test to test branch"
      images:
        - repoURL: nginx
          tag: 1.25.2
      qualified: false
    - id: b73f9d1afaca87254b64e64e5439557e86dcba79
      firstSeen: 2023-09-19T16:33:10Z
      images:
        - repoURL: nginx
          tag: 1.25.2
      qualified: true
  health:
    status: Unhealthy
    issues:
      - Argo CD Application "kargo-demo-test" in namespace "argocd" is not
        synced to revision "6d13e269dc243335bf098f505d1e12214a301fe5"
    argoCDApps:
      - namespace: argocd
        name: kargo-demo-test
        healthStatus:
          status: Healthy
        syncStatus:
          status: Synced
          revision: ec31f4da8e81e8b8b5446c9d0a56559cfcfff5f5

Live Argo CD `Application` manifest inside!
apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  annotations:
    kargo.akuity.io/authorized-stage: kargo-demo:test
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"argoproj.io/v1alpha1","kind":"Application","metadata":{"annotations":{"kargo.akuity.io/authorized-stage":"kargo-demo:test"},"name":"kargo-demo-test","namespace":"argocd"},"spec":{"destination":{"namespace":"kargo-demo-test","server":"https://kubernetes.default.svc"},"project":"default","source":{"path":"stages/test","repoURL":"https://github.com/morey-tech/kargo-demo/","targetRevision":"main"}}}
  creationTimestamp: "2023-09-19T16:31:40Z"
  generation: 248
  name: kargo-demo-test
  namespace: argocd
  resourceVersion: "70381"
  uid: d7921ddd-ab4a-4f9b-bf04-ee0a76a22a7e
spec:
  destination:
    namespace: kargo-demo-test
    server: https://kubernetes.default.svc
  project: default
  source:
    path: stages/test
    repoURL: https://github.com/morey-tech/kargo-demo/
    targetRevision: main
status:
  controllerNamespace: argocd
  health:
    status: Healthy
  history:
  - deployStartedAt: "2023-09-19T16:33:22Z"
    deployedAt: "2023-09-19T16:33:22Z"
    id: 0
    revision: 896845d99fc3b566c02fc1068fe98e6ebb52238e
    source:
      path: stages/test
      repoURL: https://github.com/morey-tech/kargo-demo/
      targetRevision: main
  - deployStartedAt: "2023-09-20T14:43:55Z"
    deployedAt: "2023-09-20T14:43:55Z"
    id: 1
    revision: 29d0fd8ed88ad4c0b9695fcf06f7daba26e94d3e
    source:
      path: stages/test
      repoURL: https://github.com/morey-tech/kargo-demo/
      targetRevision: main
  - deployStartedAt: "2023-09-20T14:47:04Z"
    deployedAt: "2023-09-20T14:47:05Z"
    id: 2
    revision: e0b42c63115a0e63c51a65d90851f2ec54fbb432
    source:
      path: stages/test
      repoURL: https://github.com/morey-tech/kargo-demo/
      targetRevision: main
  - deployStartedAt: "2023-09-20T14:49:14Z"
    deployedAt: "2023-09-20T14:49:14Z"
    id: 3
    revision: 0a64e58cc067594e407586ee38de7b8eb4117587
    source:
      path: stages/test
      repoURL: https://github.com/morey-tech/kargo-demo/
      targetRevision: main
  - deployStartedAt: "2023-09-20T14:54:54Z"
    deployedAt: "2023-09-20T14:54:55Z"
    id: 4
    revision: daad8ed5511f72a70eed7e84c2ecef4c7455c0ac
    source:
      path: stages/test
      repoURL: https://github.com/morey-tech/kargo-demo/
      targetRevision: main
  - deployStartedAt: "2023-09-20T14:57:04Z"
    deployedAt: "2023-09-20T14:57:05Z"
    id: 5
    revision: 7a2245e561eb2b5aff8db86e8235f2a0635415a9
    source:
      path: stages/test
      repoURL: https://github.com/morey-tech/kargo-demo/
      targetRevision: main
  - deployStartedAt: "2023-09-20T14:59:24Z"
    deployedAt: "2023-09-20T14:59:25Z"
    id: 6
    revision: ec31f4da8e81e8b8b5446c9d0a56559cfcfff5f5
    source:
      path: stages/test
      repoURL: https://github.com/morey-tech/kargo-demo/
      targetRevision: main
  - deployStartedAt: "2023-09-20T15:01:19Z"
    deployedAt: "2023-09-20T15:01:19Z"
    id: 7
    revision: ec31f4da8e81e8b8b5446c9d0a56559cfcfff5f5
    source:
      path: stages/test
      repoURL: https://github.com/morey-tech/kargo-demo/
      targetRevision: main
  operationState:
    finishedAt: "2023-09-20T15:01:19Z"
    message: successfully synced (all tasks run)
    operation:
      initiatedBy:
        username: admin
      retry: {}
      sync:
        revision: ec31f4da8e81e8b8b5446c9d0a56559cfcfff5f5
        syncStrategy:
          hook: {}
    phase: Succeeded
    startedAt: "2023-09-20T15:01:19Z"
    syncResult:
      resources:
      - group: ""
        hookPhase: Running
        kind: ConfigMap
        message: configmap/kargo-demo-content unchanged
        name: kargo-demo-content
        namespace: kargo-demo-test
        status: Synced
        syncPhase: Sync
        version: v1
      - group: ""
        hookPhase: Running
        kind: Service
        message: service/kargo-demo unchanged
        name: kargo-demo
        namespace: kargo-demo-test
        status: Synced
        syncPhase: Sync
        version: v1
      - group: apps
        hookPhase: Running
        kind: Deployment
        message: deployment.apps/kargo-demo unchanged
        name: kargo-demo
        namespace: kargo-demo-test
        status: Synced
        syncPhase: Sync
        version: v1
      revision: ec31f4da8e81e8b8b5446c9d0a56559cfcfff5f5
      source:
        path: stages/test
        repoURL: https://github.com/morey-tech/kargo-demo/
        targetRevision: main
  reconciledAt: "2023-09-20T15:18:43Z"
  resources:
  - kind: ConfigMap
    name: kargo-demo-content
    namespace: kargo-demo-test
    status: Synced
    version: v1
  - health:
      status: Healthy
    kind: Service
    name: kargo-demo
    namespace: kargo-demo-test
    status: Synced
    version: v1
  - group: apps
    health:
      status: Healthy
    kind: Deployment
    name: kargo-demo
    namespace: kargo-demo-test
    status: Synced
    version: v1
  sourceType: Kustomize
  summary:
    images:
    - nginx:1.25.2
  sync:
    comparedTo:
      destination:
        namespace: kargo-demo-test
        server: https://kubernetes.default.svc
      source:
        path: stages/test
        repoURL: https://github.com/morey-tech/kargo-demo/
        targetRevision: main
    revision: ec31f4da8e81e8b8b5446c9d0a56559cfcfff5f5
    status: Synced

Okay, I found the issue.
        healthCheckCommit: 6d13e269dc243335bf098f505d1e12214a301fe5

This commit SHA is for the stage/test branch, used for the writeBranch of the promotion mechanism. And since the Application isn't set to target that branch, the health check fails.

Interestingly, after pushing a new commit to main, the stage auto-updated and shows healthy. Despite the application not being synced to the health check commit (689486687a3c9928e0d07e8880e1538c2649a7bd) of the current freight (with commit id 6380a90784c45eacf9f3defe609d59a371e6bc69, which is what it is synced to).

Do you have manifests that reproduce this?

Do you have manifests that reproduce this?

I've included the Stage and Application manifests in the description of the issue. However, I haven't tested reproducing this yet.

Interestingly, after pushing a new commit to main, the stage auto-updated and shows healthy. Despite the application not being synced to the health check commit (689486687a3c9928e0d07e8880e1538c2649a7bd) of the current freight (with commit id 6380a90784c45eacf9f3defe609d59a371e6bc69, which is what it is synced to).

The manifests didn't look like they reflected this.

Ok... so initial issue was explained... current issue is the opposite... looks healthy, but shouldn't be?
I'll look into this.

Found it...
What revision the App is synced to only factors into health if we can match the App's repo URL to a repo URL in a freight. i.e. We only factor this in if we know what revision we really want the App synced to.
There's no match here because... wait for it...
You subscribed to https://github.com/morey-tech/kargo-demo/, but the repo URL in your App is https://github.com/morey-tech/kargo-demo. (One has a trailing slash and the other doesn't.)
There is an established method of canonicalizing repo URLs that should be applied before all comparisons and it's been missed here. It's likely been missed in other places as well.
I'm going to close this issue and open a more general one about making sure this is accounted for everywhere.

Superceeded by #838


Kubernetes httpsEntrypoint for Ingress

What version of Traefik are you using (traefik version)?
v.1.1.2-alpine Docker image.
What is your environment & configuration (arguments, toml...)?
Kubernetes 1.5.1
What did you do?
I wanted to specify a https entryPoint (instead of the default http) for my service in Ingress.
What did you expect to see?
That this is possible.
What did you see instead?
This is not possible.

Could you be a little more specific about what you are trying to do.  What configuration have you provided? what is not working?
As far as I understand you want to proxy to a port where a https service is running, I think this should be possible IIRC just ensure the service port is 443...

Sorry, I was mistaken, my traefik had only a http entry point defined. Closing!


OrbStack 1.6.3 not working on hackintosh

Describe the bug
🌲 vmgr | time="06-26 22:27:58" level=fatal msg="panic: new machine: Intel CPUs older than Skylake (6th generation) or newer than Ice Lake (10th generation), the newest CPU ever shipped in an Intel Mac, are not supported"
Check logs for more details.
My Hardware:
                    'c.
                 ,xNMM.          ------------------
               .OMMMMo           OS: macOS Monterey 12.7.5 x86_64
               OMMM0,            Host: Hackintosh (SMBIOS: MacPro6,1)
     .;loddo:' loolloddol;.      Kernel: 21.6.0
   cKMMMMMMMMMMNWMMMMMMMMMM0:    Uptime: 9 days, 23 hours, 52 mins
 .KMMMMMMMMMMMMMMMMMMMMMMMWd.    Packages: 168 (brew)
 XMMMMMMMMMMMMMMMMMMMMMMMX.      Shell: fish 3.7.1
;MMMMMMMMMMMMMMMMMMMMMMMM:       Resolution: 1920x1080@2x
:MMMMMMMMMMMMMMMMMMMMMMMM:       DE: Aqua
.MMMMMMMMMMMMMMMMMMMMMMMMX.      WM: Quartz Compositor
 kMMMMMMMMMMMMMMMMMMMMMMMMWd.    WM Theme: Graphite (Light)
 .XMMMMMMMMMMMMMMMMMMMMMMMMMMk   Terminal: iTerm2
  .XMMMMMMMMMMMMMMMMMMMMMMMMK.   Terminal Font: JetBrainsMonoNF-Regular 12
    kMMMMMMMMMMMMMMMMMMMMMMd     CPU: Intel i7-6850K (12) @ 3.60GHz
     ;KMMMMMMMWXXWMMMMMMMk.      GPU: AMD Radeon RX 5700 XT
       .cooc,.    .,coo:.        Memory: 22293MiB / 98304MiB

To Reproduce
No response
Expected behavior
No response
Diagnostic report (REQUIRED)
No response
Screenshots and additional context (optional)
No response

Same here.  MacPro 6,1, Intel Xeon E5-2673 v2, Macos Sonoma 14.2.1
v1.5.1 works fine, 1.6.1 and 1.6.3 fails on start CPU checking.

Same here, but I think it is the intended behavior. OrbStack gave up support for unofficial hardwares.
From https://github.com/orbstack/orbstack/issues/1204#issuecomment-2136433530:

11th generation and newer are not supported. Apple has never shipped an Intel CPU after 10th gen, so this is only possible on Hackintoshes. Since Hackintoshes are not officially supported at all by Apple, we have no plans to support them either.

@onegray

Same here. MacPro 6,1, Intel Xeon E5-2673 v2, Macos Sonoma 14.2.1
v1.5.1 works fine, 1.6.1 and 1.6.3 fails on start CPU checking.

Yes, that's no longer supported as per the error message.

@cassiuscai

CPU: Intel i7-6850K (12) @ 3.60GHz

Was this working with v1.6.2? If so, we can add support for it again.
It looks like this is a Broadwell-based CPU despite being 6th gen, but we can add it to the supported model list if it does work.

@cassiuscai

CPU: Intel i7-6850K (12) @ 3.60GHz

Was this working with v1.6.2? If so, we can add support for it again.
It looks like this is a Broadwell-based CPU despite being 6th gen, but we can add it to the supported model list if it does work.

Nope, It works on v1.5.1

Ah, then sorry, I don't think we'll be supporting it anymore as per the error message.

AMD

The macOS hypervisor doesn't support AMD because the virtualization extensions are completely different. It's not possible for any hardware-accelerated VM apps to work on AMD CPUs, unless they have their own hypervisor which I don't think is allowed on modern macOS.

Skylake is supported. As I explained above, this specific CPU model (i7-6850K) is actually based on Broadwell even though it's 6th generation, and Broadwell isn't supported.

It is speculated from the logs that OrbStack implements CPU judgment through the Go language, and the core should be unix.Sysctl("machdep.cpu.brand_string") tried to insert dylib using DYLD_INSERT_LIBRARIES, but was unsuccessful
package main

import (
	"fmt"
	"github.com/shirou/gopsutil/v3/cpu"
)

func main() {
	cpuInfo, err := cpu.Info()
	if err != nil {
		fmt.Println("Error:", err)
		return
	}

	for _, info := range cpuInfo {
		fmt.Println("CPU Model:", info.ModelName)
	}
}

#include <stdio.h>
#include <string.h>
#include <sys/sysctl.h>
#include <dlfcn.h>

typedef int (*sysctl_t)(int *, u_int, void *, size_t *, void *, size_t);

static sysctl_t original_sysctl = NULL;

__attribute__((constructor))
static void customConstructor(int argc, const char **argv) {
    printf("Hello from dylib!\n");

    original_sysctl = (sysctl_t)dlsym(RTLD_NEXT, "sysctl");
    if (original_sysctl == NULL) {
        fprintf(stderr, "Failed to find original sysctl\n");
    } else {
        printf("Original sysctl found\n");
    }
}

int sysctl(int *name, u_int namelen, void *oldp, size_t *oldlenp, void *newp, size_t newlen) {
    printf("own sysctl called!\n");
    if (original_sysctl == NULL) {
        fprintf(stderr, "Original sysctl not initialized\n");
        return -1;
    }

    if (namelen == 2 && name[0] == CTL_HW && name[1] == HW_MODEL) {
        if (oldp != NULL && oldlenp != NULL) {
            const char *fake_model = "Fake CPU Model";
            size_t len = strlen(fake_model) + 1;
            if (*oldlenp >= len) {
                strcpy(oldp, fake_model);
                *oldlenp = len;
                return 0;
            }
        }
    }

    return original_sysctl(name, namelen, oldp, oldlenp, newp, newlen);
}

run
gcc -dynamiclib -o libfakecpu.dylib fakecpu.c
 DYLD_INSERT_LIBRARIES=./libfakecpu.dylib go run main.go

It is speculated from the logs that OrbStack implements CPU judgment through the Go language, and the core should be unix.Sysctl("machdep.cpu.brand_string") tried to insert dylib using DYLD_INSERT_LIBRARIES, but was unsuccessful
package main

import (
	"fmt"
	"github.com/shirou/gopsutil/v3/cpu"
)

func main() {
	cpuInfo, err := cpu.Info()
	if err != nil {
		fmt.Println("Error:", err)
		return
	}

	for _, info := range cpuInfo {
		fmt.Println("CPU Model:", info.ModelName)
	}
}

#include <stdio.h>
#include <string.h>
#include <sys/sysctl.h>
#include <dlfcn.h>

typedef int (*sysctl_t)(int *, u_int, void *, size_t *, void *, size_t);

static sysctl_t original_sysctl = NULL;

__attribute__((constructor))
static void customConstructor(int argc, const char **argv) {
   printf("Hello from dylib!\n");

   original_sysctl = (sysctl_t)dlsym(RTLD_NEXT, "sysctl");
   if (original_sysctl == NULL) {
       fprintf(stderr, "Failed to find original sysctl\n");
   } else {
       printf("Original sysctl found\n");
   }
}

int sysctl(int *name, u_int namelen, void *oldp, size_t *oldlenp, void *newp, size_t newlen) {
   printf("own sysctl called!\n");
   if (original_sysctl == NULL) {
       fprintf(stderr, "Original sysctl not initialized\n");
       return -1;
   }

   if (namelen == 2 && name[0] == CTL_HW && name[1] == HW_MODEL) {
       if (oldp != NULL && oldlenp != NULL) {
           const char *fake_model = "Fake CPU Model";
           size_t len = strlen(fake_model) + 1;
           if (*oldlenp >= len) {
               strcpy(oldp, fake_model);
               *oldlenp = len;
               return 0;
           }
       }
   }

   return original_sysctl(name, namelen, oldp, oldlenp, newp, newlen);
}

run
gcc -dynamiclib -o libfakecpu.dylib fakecpu.c
 DYLD_INSERT_LIBRARIES=./libfakecpu.dylib go run main.go

To replace library functions you need either DYLD_FORCE_FLAT_NAMESPACE=1 environment variable (not recommended, as it may break other things if the app already contains functions with equal names) or DYLD_INTERPOSE in the code of your libfakecpu.dylib. Here is how we do it:
#define ADD_PREFIX(func) intercept_##func
struct interpose {
  const void *replacement, *replacee;
};
#define DYLD_INTERPOSE(func) \
  __attribute__ ((used)) \
  __attribute__ ((section ("__DATA,__interpose"))) \
  static struct interpose _interpose_##func = {&ADD_PREFIX(func), &func};

__attribute__ ((visibility ("default")))
int ADD_PREFIX(posix_spawnp)(pid_t *pid, const char *file,
                 const posix_spawn_file_actions_t *file_actions,
                 const posix_spawnattr_t *attrp,
                 char *const argv[], char *const envp[])
{
   // our implementation of posix_spawnp...
}
DYLD_INTERPOSE(posix_spawnp)


checkboxStyle not working.

Hello, i have problems with checkboxStyle, its not working... I need to change chechbox image size to 60x33, but its not working. Any of styles is not working, even if im not using image as checkbox..
<CheckBox 		    checkboxStyle={{height: 33, width: 60}}                     labelBefore={true}                     label='AUTO STREAM IMAGES'                     containerStyle={styles.checkbox}                     labelStyle={styles.label}                     checkedImage={require('../../img/checkboxbig_ok.png')}                     uncheckedImage={require('../../img/checkboxbig.png')}                      />

@lukasz-gorski try with checkBoxStyle instead of checkboxStyle

@lukasz-gorski with the latest release the API has been changed to checkboxStyle


Fix incorrect help link, edit error message and make priority and category case insensitive

Closes #122
Closes #126
Closes #145

Codecov Report
Base: 56.45% // Head: 56.45% // No change to project coverage :thumbsup:

Coverage data is based on head (d92fb93) compared to base (6f20c8d).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #162   +/-   ##
=========================================
  Coverage     56.45%   56.45%
  Complexity      544      544
=========================================
  Files           112      112
  Lines          2285     2285
  Branches        280      280
=========================================
  Hits           1290     1290
  Misses          897      897
  Partials         98       98

Impacted Files
Coverage Δ

...in/java/seedu/address/logic/parser/ParserUtil.java
46.42% <0.00%> (ø)

src/main/java/seedu/address/ui/HelpWindow.java
0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


PowerBI Dashboard - No conversation details

Hello,
if I open the template with the actual Desktop PowerBI and enter the AppInsight AppID, I can see data in Overall Usage and Demographics, but e.g. in Conversations Drill Down I get not the messages. What should I do to get as well the detailed messages?

Hi David, is this using the Enterprise Template? What version of the Bot Builder SDK is it using?
We have an updated being published shortly, which should have the correct telemetry configured to work with the Power BI sample.

I dont't know if it helps, but I'm located in Germany. But I have EN set-uped in Windows 10.  Further, I get DataFormatErrors for the field  Data.

I think the label "question" is wrong. i think it could be a bug or the documentation (HowTo set-up with Virtual Assistant) is missing.

The Power BI sample is released with Virtual Assistant updates in the 4.2 SDK (see #438 for details and #448 for latest fixes). Try testing with that.
You may still see a problem with the conversationalai date problem (en-gb is reported as well), but the EventTelemetry table will be populated using the schema from 4.2.

I deployed the newest VA at my private (Pay-As-To-Go) Azure account. But now I get an error message. (I tried to connect with the Azure account from my work with AppInsight ID, and it works.) So I assume I need to do with my private Azure account to use PowerBI to collect the AppInsight Data, right? What? Thank you.


Update mfa-connect-to-exchange-online-powershell.md

Per Issue #4867

Docs Build status updates of commit 45a2862:
:clock10: Full build: the average full build time is 12 min(s) 8 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 45a2862:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/mfa-connect-to-exchange-online-powershell.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


fix: filter head title when it is styled using html tags

This PR filters unescaped HTML tags in the head title.
Background
Currently, head title can be styled using HTML tags:
For example,
# Composable Vue

However, because it is also directly fed to the browser tab title like this:
https://github.com/slidevjs/slidev/blob/3afc764ffa628f06d7bd11fbd4f5a751e3777e9a/packages/client/setup/root.ts#L18-L20
So the literals would straight show up in the browser tab, being something like Composable..., which is obviously not very ideal.
Solution
This PR utilizes the regular expression to filter unescaped HTML tags in the head title when calling useHead.
The regular expression being:
const REGEX_HTML_TAGS_IN_MARKDOWN = /(?<!\\)<(.*?)[^\\]>/g

Note that escaping using slashes would be allowed by this regular expression. For instance, markdown \ would mean literal .

Having second thought about using regex lookbehind. This can cause serious incompatibility issues for Safari users. 🤔

Not sure, probably better to specify the title yourself explicitly:
---
title: Whatever you want
---

# Whatever

Not sure, probably better to specify the title yourself explicitly:
---
title: Whatever you want
---

# Whatever

Yeah, that seem to make the most sense for now. Tho, having it filtered automatically would be a smoother experience out of the box, imo.
I'll leave it as it is now, may come back to this pr later. If you think this is unnecessary, please go ahead and close this PR, it would be no problem at all.
👏This project is a brilliant idea by the way.

Yeah, this could be overkill when time I might just want to have html tags or type genetics in the title. Being able to specify the title could be better to me.
Meaning:
# Talk about `<details/>`

# What is Readonly<T> in TypeScript

Thanks for the contributions anyway!

# What is Readonly<T> in TypeScript

Just to be clear, in your second example, I think you may have to do escaping like # What is Readonly\<T\> in TypeScript to be able to properly render it.


Upgrade metapackages, shared framework, and installers to netcoreapp2.2

Part of #1120.
This upgrades the following to netcoreapp2.2

Microsoft.AspNetCore.{App,All} (packages)
Microsoft.AspNetCore.{App,All} (shared runtime)
LZMA
Symbols packages

oops wrong button, should have done squash and merge instead of rebase and merge.


refactor: plugin platform code cleanup

Description of changes

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[x] yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #10384 (3e88cf5) into master (714f2fa) will increase coverage by 0.01%.
The diff coverage is 64.86%.

@@            Coverage Diff             @@
##           master   #10384      +/-   ##
==========================================
+ Coverage   46.57%   46.59%   +0.01%
==========================================
  Files         703      703
  Lines       35246    35237       -9
  Branches     7134     7133       -1
==========================================
  Hits        16417    16417
+ Misses      17042    17035       -7
+ Partials     1787     1785       -2

Impacted Files
Coverage Δ

...ify-cli/src/plugin-helpers/scan-plugin-platform.ts
21.10% <45.71%> (+3.24%)
:arrow_up:

packages/amplify-cli/src/plugin-manager.ts
17.64% <72.00%> (+0.25%)
:arrow_up:

...es/amplify-cli/src/plugin-helpers/verify-plugin.ts
100.00% <100.00%> (ø)

...li/src/domain/amplify-usageData/getUsageDataUrl.ts
100.00% <0.00%> (+12.50%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


F#689 snapshot popup css error

Description

Related Issue :

#689
How Has This Been Tested?

Check if snapshot success/popup isn't broken when dataset name is long
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project. it will be added soon
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document. it will be added soon
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Additional Context

run build
deploy to 2


🐛 Fix API version in IPAM webhooks

This PR updates leftover Provider API versions in webhooks from v1a4 to v1a5.

/test-integration

/test-centos-integration

Now that, I see it carefully, it seems this was a mistake all together. This should be versioned according to IPAM api version not CAPM3 api version. Would you like to change all of them in this PR?

I changed ipam api version to v1alpha1, since @furkatgofurov7 is on vacation.

/test-integration
/test-centos-integration

/test-integration

/test-integration

/test-integration

/test-integration

/test-integration

/test-centos-integration

/cc @jan-est @maelk

/lgtm


Removed superagent

no issue

Migrate default scheduling adapter to use Got via the request proxy
SchedulingDefault is the only module that was using superagent so remove it as a dependency

Thanks 👍 Will review asap :)

@vikaspotluri123 the changes look good to merge. Let's just change the json:true flag more liberal one, to avoid unintended consequences. Good  job :+1:

Done! 🎉

Hm.. now the test's are broken. Wonder if that has to do with clearTimeout removal :thinking:

Looked into it, it's because axios didn't like the Object that was being passed as part of the body, which is weird since it should accept an object as the payload according to the error message 😕

Weird, but seems like that's how it's supposed to be used, the same notation is used in slack service.
Think it's good to go into master :tada: Thanks @vikaspotluri123!


Fetch necessary ecephys session data from ReferenceDataRecord

User story
As a user, I want a complete session.json.
Acceptance criteria

[x] Given the pk identifier for modules used in a stream, fetch data from ReferenceDataRecord table

Sprint Ready Checklist

[x] 1. Acceptance criteria defined
[x] 2. Team understands acceptance criteria
[x] 3. Team has defined solution / steps to satisfy acceptance criteria
[x] 4. Acceptance criteria is verifiable / testable
[x] 5. External / 3rd Party dependencies identified
[x] 6. Ticket is prioritized and sized

Notes
Create models for the EphysLogging module in RDR table. Can either do one large model for all models, or separate by type (ex: ManipulatorModule, DomeModule, etc etc)

closed by #38


Added new material: @https://github.com/Pau1fitz/react-spotify

@boyney123 looks like the build is failing for both PRs.
Any ideas?

Hey @Pau1fitz thanks for the PR 👍
Yeah I think its Netlify not liking http content, I will raise an issue and look into it, for now I think this looks fine! Good job


Larger files trigger this failure: ValueError: 1398490 exceeds max_bin_len(1048576)

It looks like msgpack limits the size.
py36-msgpack-0.6.1
FreeBSD 12.

https://github.com/codilime/veles/pull/447


SW-2911 / SW-2947 / SW-2953 Show storage locations in seed bank details view

allow clicking on a location name to see accessions view

Note, Jiras SW-2911 / SW-2947 / SW-2953 are handled in this one PR because the fixes are very much intertwined.

@karthikbtf  Is there an org on staging that I can be added to that has seed banks with sub-locations? (I'm not seeing sub-locations on vercel deployments.)

If someone clicks on a Sub-Location from “Locations > Seed Banks > <seedbank> > Sub-Locations,” we will want to show the column and filter for “Sub-Locations” in the Accessions table (if it’s not already being shown). Alternative is to show column and filter for “Sub-Locations” by default with the release of this feature. (Same note added to SW-2948.)

If someone clicks on a Sub-Location from “Locations > Seed Banks > <seedbank> > Sub-Locations,” we will want to show the column and filter for "Seed Banks" and “Sub-Locations” in the Accessions table (if it’s not already being shown). Alternative is to show column and filter for "Seed Banks" and “Sub-Locations” by default with the release of this feature. (Same note added to SW-2948.)
Edit: Added "Seed Banks."

@chudo76 just curious if you are not seeing this in the vercel build or just calling out requirements..

@chudo76 just curious if you are not seeing this in the vercel build or just calling out requirements..

@karthikbtf I had to turn on the columns in staging to figure out that the Accession table was being filtered by Sub-Locations. Just looking at the PRD now and although it's not called out, I think we would need to adjust setting so that column and filter are on for Seed Bank and Sub-Location to show that it is filtered by Sub-Location (if the user hadn't had those columns turned on prior).
It's noted on SW-2948 so it can be addressed as a separate issue. I'm going to ask to tweak the design so that the link to the filtered Accessions page is on the "Active Accessions" number instead of the sub-location name.

@chudo76 just curious if you are not seeing this in the vercel build or just calling out requirements..

@karthikbtf I had to turn on the columns in staging to figure out that the Accession table was being filtered by Sub-Locations. Just looking at the PRD now and although it's not called out, I think we would need to auto-adjust the user's setting so that column and filter are on for Seed Bank and Sub-Location to show that it is filtered by Sub-Location (if the user hadn't had those columns turned on prior).
It's noted on SW-2948 so it can be addressed as a separate issue. I'm going to ask to tweak the design so that the link to the filtered Accessions page is on the "Active Accessions" number instead of the sub-location name.

Got it.. I didn’t realize I had the columns already enabled.. thought they just showed up. Will make the enhancements.
Btw there are no designs for this.. driven by Eng and design can give feedback/suggestions. This is a starting point.
I can make the number the link, makes sense here. Also any thoughts on the Sub-Locations title? Seems redundant maybe? The table column headers seem descriptive enough?

Got it.. I didn’t realize I had the columns already enabled.. thought they just showed up. Will make the enhancements. Btw there are no designs for this.. driven by Eng and design can give feedback/suggestions. This is a starting point. I can make the number the link, makes sense here. Also any thoughts on the Sub-Locations title? Seems redundant maybe? The table column headers seem descriptive enough?

I think "Sub-Locations" title is fine. We can change the column header label from "Sub-Location" to "Name" and that would remove redundancy (and probably makes sense anyway since it looks like PRD is saying we'd want people to be able to edit the name.)

Looks good to me! Seebank and sublocation Columns on accessions page don't show yet, but guess will be implemented later

yes that will be separate


Question about texture.

Hi~ Thanks for your great work! It is fantastic!
Here I have several questions:
According to the readme:

see samples for source code. The first uses simple monochromatic diffuse lighting calculated per-vertex and interpolated with Gouraud shading; the others use per-pixel (deferred) lighting and texture calculations.

Seems like if the one wants to get texture calculations involved, he/she must use the deferred mode (pixels = dirt.rasterise_deferred)?
And I tried to switch the dirt.rasterise, it told me that some keyword arguments do not exist.
So, I am a little confused.
I want to ask is there an online reference manual for these details? Because I think there is not much description of these technical details in the paper, and the content provided by readme in this repo is a little rough.
Sorry for my first attempt, the problem may be a bit stupid! Anyone can help.
Thanks in advance.

Sadly there is no documentation aside from what is at the top of each function, and the samples. I might write a proper guide, sometime.
Yes, you need rasterise_deferred for anything with texture.

Sadly there is no documentation aside from what is at the top of each function, and the samples. I might write a proper guide, sometime.
Yes, you need rasterise_deferred for anything with texture.

If this is the case, I will keep looking forward to it! thank you very much! Your patient response is very encouraging. Hope this project keeps getting better! Thanks again!
Best,
Frank


Error: Method 'addPostFrameCallback' cannot be called on 'SchedulerBinding?

Can we remove the warning from the package?
../../Developer/flutter/.pub-cache/hosted/pub.dartlang.org/animations-2.0.2/lib/src/open_container.dart:631:24: Warning: Operand of null-aware operation '!' has type 'SchedulerBinding' which excludes null.

'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart' ('../../Developer/flutter/packages/flutter/lib/src/scheduler/binding.dart').
SchedulerBinding.instance!
^
../../Developer/flutter/.pub-cache/hosted/pub.dartlang.org/animations-2.0.2/lib/src/open_container.dart:665:24: Warning: Operand of null-aware operation '!' has type 'SchedulerBinding' which excludes null.
'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart' ('../../Developer/flutter/packages/flutter/lib/src/scheduler/binding.dart').
SchedulerBinding.instance!

me too

Agreed. Please remove warnings from flutter packages.

@gitHubAdminUser
This is similar to https://github.com/flutter/flutter/issues/103561. Check this issue comment for your reference and this document to try various solutions.
Closing as duplicate.


Add ability to skip session limitable on a per record basis

This just adds the ability to skip session limitable on a per record or instance basis. Our app has had this forked from the old devise_security_extensions gem for a long time and as we're switching over to devise-security so that we can upgrade rails it felt like a good time to see about getting this merged in.
The use case for our app is this is a client/account setting, so we need some way to bypass this based on a record instance's logic.

Pull Request Test Coverage Report for Build 213

0 of 0   changed or added relevant lines in 0 files are covered.
24 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-14.2%) to 78.212%

Files with Coverage Reduction
New Missed Lines
%

lib/devise-security/routes.rb
2
71.43%

lib/devise-security/hooks/paranoid_verification.rb
2
33.33%

lib/devise-security/rails.rb
3
66.67%

lib/devise-security/models/database_authenticatable_patch.rb
7
23.53%

lib/devise-security/models/paranoid_verification.rb
10
47.37%

Totals

Change from base Build 208:
-14.2%

Covered Lines:
140

Relevant Lines:
179

💛  - Coveralls

@surjay Can you add some documentation on how your session limitable bypass feature works? I'd appreciate it if we can find how to integrate our versions of session limitable to work together.

@surjay Can you add some documentation on how your session limitable bypass feature works?
I'd appreciate it if we can find how to integrate our versions of session limitable to work together. #79

Sure thing. At a basic level the idea is a record or instance can override the check by defining that method. For example, you could have the following model:
class User < ActiveRecord::Base
  devise :session_limitable
end

class ModifiedUser < User
  def skip_session_limitable?
    true
  end
end

ModifiedUser instances would then skip the session limitable check.  That's a very basic example, the actual use case we have is something like this:
class User < ActiveRecord::Base
  devise :session_limitable

  belongs_to :account

  def skip_session_limitable?
    # lots of logic based on account settings and subscriptions, etc. for external users
    # bypass for internal/support users, etc
  end
end

My use case is to "impersonate" users to provide support, without requiring the user's password or resetting their password.
My impression is that your implementation requires persisting the skip_session_limitable? flag/logic in the database, which is not applicable in my use case, as it'll allow the user themselves to log multiple times. Is my understanding correct?

My use case is to "impersonate" users to provide support, without requiring the user's password or resetting their password.
My impression is that your implementation requires persisting the skip_session_limitable? flag/logic in the database, which is not applicable in my use case, as it'll allow the user themselves to log multiple times. Is my understanding correct?

My case could require persistence. The method override could really contain any kind of logic you want so its left more up to the application logic to determine how to handle that.  It could be a db field, it could just be model overrides or a config setting.
It could also possibly work with a virtual attr_accessor field on the model or something similar where you could theoretically do something like:
class User
  attr_accessor :skip_session_check

  def skip_session_limitable?
    skip_session_check.present?
  end
end

# then in a controller somewhere
current_user.skip_session_limitable = true
sign_in(current_user) # or set_user or whatever you have going on.

I think that'd probably work as well.  There is also the bypass devise flag when signing in:
sign_in(current_user, bypass: true)
That'll skip warden callbacks. Perhaps that could be another way for you to 'impersonate' a user.

My case could require persistence. The method override could really contain any kind of logic you want so its left more up to the application logic to determine how to handle that. It could be a db field, it could just be model overrides or a config setting.

Due to reloading the user from the database on each request by warden, it does require some sort of persistence if you need per-session bypass. The model by design doesn't have access to the session.

It could also possibly work with a virtual attr_accessor field on the model or something similar where you could theoretically do something like:
class User
  attr_accessor :skip_session_check

  def skip_session_limitable?
    skip_session_check.present?
  end
end

# then in a controller somewhere
current_user.skip_session_check = true
sign_in(current_user) # or set_user or whatever you have going on.

I think that'd probably work as well. There is also the bypass devise flag when signing in:
sign_in(current_user, bypass: true)
That'll skip warden callbacks. Perhaps that could be another way for you to 'impersonate' a user.

I attempted implementing it that way and it doesn't really work, because it bypasses all warden callbacks, not just the session limitable one, hence why I'm in favor setting this via an option from the controller. After all devise is supposed to do user session authentication, rather than authorization. Authorization makes sense to be implemented at the model/user instance level.
@oniofchaos any input on your side, as a maintainer? I think this has become more of a philosophical question really. I also think both patches could be accepted with a simple skip = record.skip_session_limitable? || options[:skip_session_limitable] in the non-fetch callback and skip = record.skip_session_limitable? || warden.session(options[:scope])['devise.skip_session_limitable'] in the fetch callback.
so whichever option is present the session limitable is skipped. If we can agree on such an implementation I'd be happy to rebase my changes on top of @surjay's changes and allow the possibility to skip session limitations based on either model-attached flag or a session/controller attached flag.

also think both patches could be accepted with a simple skip = record.skip_session_limitable? || options[:skip_session_limitable] in the non-fetch callback and skip = record.skip_session_limitable? || warden.session(options[:scope])['devise.skip_session_limitable'] in the fetch callback.

I agree with this approach. I can see where both could be useful in different scenarios. @olbrich @natebird thoughts?

Any consensus on this?

Any updates on this guys?

@surjay We need to rebase this on the recent updates to session limitable

@surjay I updated the underlying implementation of session limitable in master, let's take a look at this again now that it's been rebased and see if we can get this working.

Once you get @surjay PR in, I'll rebase on top. Hopefully we can get both functions inside the same release.

@surjay @kirichkov I updated the underlying implementation of session limitable in master, let's take a look at this again now that it's been rebased and see if we can get this working.

Sounds good, are we wanting me to make additional changes or what?

@surjay make sure this branch still does what you need with the latest changes.

@surjay make sure this branch still does what you need with the latest changes.

Preliminary testing looks good. I don't see anything in your changes that would affect this small addition.

@surjay can you merge in latest master?

@surjay can you merge in latest master?

Yep, done.


Suggestion: Do not clone properties if ticket properties is empty

Some people want tickets to not override train properties, i.e. to use it only as a check to board trains. Is it possible to check whether the ticket properties are empty, and if so, not clone the properties onto the train?
See image attachment for an example of empty properties.

Reference: Relevant file and line
https://github.com/bergerhealer/TrainCarts/blob/ea6ce1a4e15b173fbb7df1b256325a74b13dd4e0/src/main/java/com/bergerkiller/bukkit/tc/tickets/TicketStore.java#L388

Strange thing is though, the load() keeps the original properties the train has when those keys aren't in the yaml. So with an empty settings block, the properties should be left unchanged. What properties are observed to be reset or change?

Oh really, I didn't dig any further, so I wasn't aware of this. Someone else in Discord was mentioning that they didn't want tickets overwriting their train properties, so I thought this wasn't a thing yet.

Update: It shouldn't have gotten reset in the first place, so now it's declared a bug.
Most properties are not wiped, but it has been noticed that some are wiped, so those need to be patched.

Should be fixed in latest dev builds, closing this.


fix(session-replay-browser): handle exceptions when creating an events manager

Summary

A Jenkins error was reported in https://amplitude.atlassian.net/browse/AMP-108769. It was caused by the unhandled idb open error. This PR handles it when creating the events managers. The events manager creation fails when the idb store creation fails, and it skips adding the events manager so no replays will be captured then.
Checklist

[ ] Does your PR title have the correct title format?
Does your PR have a breaking change?:

Do we know when this happens?

@jackson-amplitude For example, when there is no enough disk space to open a new idb store.

Do we know when this happens?

@jackson-amplitude For example, when there is no enough disk space to open a new idb store.

our storage footprint should be small. maybe worth a quick check to see if idb has any diagnostics that we can log (don't spend too much time though).

https://amplitude.atlassian.net/browse/AMP-108769

@jackson-amplitude Out of disk space is one of the possible reasons. Other reasons could be opening idb in incompatible browsers or simply an idb bug. People usually report this issue with no other diagnostic information. The solutions are often to restart the browser or so. So I think catching and logging the error in the console is the best we can do for it.