ANR Input dispatching timed out

Hi First of all thanks for the great lib, it's amazing.
I just got a crash report which never has been reported before. I'm posting the thread dumps at the end.
What could be the reason for that?
Thanks
JNI: CheckJNI is off; workarounds are off; pins=0; globals=296
DALVIK THREADS:
(mutexes: tll=0 tsl=0 tscl=0 ghl=0)
"main" prio=5 tid=1 NATIVE
  | group="main" sCount=1 dsCount=0 obj=0x418b0de0 self=0x417c5958
  | sysTid=30341 nice=-6 sched=0/0 cgrp=apps handle=1074430340
  | state=R schedstat=(<PHONE_NUMBER>9<PHONE_NUMBER> 11452 ) utm=1156 stm=109 core=1
  #00  pc 0017452c  /system/lib/libskia.so (SkDQuad::subDivide(SkDPoint const&, SkDPoint const&, double, double) const+28)
  #01  pc 0016b624  /system/lib/libskia.so (SkOpSegment::subDivide(int, int, SkDCubic*) const+524)
  #02  pc 001630d4  /system/lib/libskia.so (SkOpAngle::setSpans()+172)
  #03  pc 0016e0ac  /system/lib/libskia.so (SkOpSegment::findNextOp(SkTDArray<SkOpSpan*>*, int*, int*, bool*, SkPathOp, int, int)+404)
  #04  pc 0017341c  /system/lib/libskia.so (Op(SkPath const&, SkPath const&, SkPathOp, SkPath*)+1388)
  #05  pc 0001e98c  /system/lib/libdvm.so (dvmPlatformInvoke+112)
  #06  pc 000500a9  /system/lib/libdvm.so (dvmCallJNIMethod(unsigned int const*, JValue*, Method const*, Thread*)+484)
  #07  pc 00027d68  /system/lib/libdvm.so
  #08  pc 0002f46c  /system/lib/libdvm.so (dvmMterpStd(Thread*)+76)
  #09  pc 0002c950  /system/lib/libdvm.so (dvmInterpret(Thread*, Method const*, JValue*)+188)
  #10  pc 0006391d  /system/lib/libdvm.so (dvmInvokeMethod(Object*, Method const*, ArrayObject*, ArrayObject*, ClassObject*, bool)+400)
  #11  pc 0006bedf  /system/lib/libdvm.so
  #12  pc 00027d68  /system/lib/libdvm.so
  #13  pc 0002f46c  /system/lib/libdvm.so (dvmMterpStd(Thread*)+76)
  #14  pc 0002c950  /system/lib/libdvm.so (dvmInterpret(Thread*, Method const*, JValue*)+188)
  #15  pc 000635d1  /system/lib/libdvm.so (dvmCallMethodV(Thread*, Method const*, Object*, bool, JValue*, std::__va_list)+340)
  #16  pc 0004b911  /system/lib/libdvm.so
  #17  pc 0004f293  /system/lib/libandroid_runtime.so
  #18  pc 0005003f  /system/lib/libandroid_runtime.so (android::AndroidRuntime::start(char const*, char const*, bool)+374)
  #19  pc 00001063  /system/bin/app_process
  #20  pc 0000f2cc  /system/lib/libc.so (__libc_init+100)
  #21  pc 00000d80  /system/bin/app_process
  at android.graphics.Path.native_op(Native Method)
  at android.graphics.Path.op(Path.java:171)
  at android.graphics.Path.op(Path.java:153)
  at com.heinrichreimersoftware.materialintro.view.InkPageIndicator.onDraw((null):-1)
  at android.view.View.draw(View.java:14730)
  at android.view.View.getDisplayList(View.java:13590)
  at android.view.View.getDisplayList(View.java:13637)
  at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3229)
  at android.view.View.getDisplayList(View.java:13511)
  at android.view.View.getDisplayList(View.java:13637)
  at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3229)
  at android.view.View.getDisplayList(View.java:13511)
  at android.view.View.getDisplayList(View.java:13637)
  at android.view.View.draw(View.java:14432)
  at android.view.ViewGroup.drawChild(ViewGroup.java:3255)
  at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3073)
  at android.view.View.draw(View.java:14741)
  at android.view.View.getDisplayList(View.java:13590)
  at android.view.View.getDisplayList(View.java:13637)
  at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3229)
  at android.view.View.getDisplayList(View.java:13511)
  at android.view.View.getDisplayList(View.java:13637)
  at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3229)
  at android.view.View.getDisplayList(View.java:13511)
  at android.view.View.getDisplayList(View.java:13637)
  at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3229)
  at android.view.View.getDisplayList(View.java:13511)
  at android.view.View.getDisplayList(View.java:13637)
  at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3229)
  at android.view.View.getDisplayList(View.java:13511)
  at android.view.View.getDisplayList(View.java:13637)
  at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3229)
  at android.view.View.getDisplayList(View.java:13511)
  at android.view.View.getDisplayList(View.java:13637)
  at android.view.HardwareRenderer$GlRenderer.buildDisplayList(HardwareRenderer.java:1633)
  at android.view.HardwareRenderer$GlRenderer.draw(HardwareRenderer.java:1512)
  at android.view.ViewRootImpl.draw(ViewRootImpl.java:2743)
  at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:2608)
  at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2231)
  at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1208)
  at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6279)
  at android.view.Choreographer$CallbackRecord.run(Choreographer.java:788)
  at android.view.Choreographer.doCallbacks(Choreographer.java:591)
  at android.view.Choreographer.doFrame(Choreographer.java:560)
  at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:774)
  at android.os.Handler.handleCallback(Handler.java:808)
  at android.os.Handler.dispatchMessage(Handler.java:103)
  at android.os.Looper.loop(Looper.java:193)
  at android.app.ActivityThread.main(ActivityThread.java:5299)
  at java.lang.reflect.Method.invokeNative(Native Method)
  at java.lang.reflect.Method.invoke(Method.java:515)
  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:831)
  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:647)
  at dalvik.system.NativeStart.main(Native Method)

This library doesn't use any native code end I don't see how this should be related to material-intro. I would assume that is a platform bug so you should report it in the official AOSP bug tracker.

I've been using your library for many months and i really love it.
I've always had only 3 slides but since I added the fourth slide I started to have these ANR as well.
I noticed that doesn't matter what slide it is but if I exceed the 3 slides on many devices this happens (including one of my test smartphone).

So when exactly does this bug happen? Again, this library doesn't use an JNI code so the stack trace above is kinda useless for me. Can you attach some small sample project or can you confirm this bug is happening with the sample app?
Also are you using native code in your application?

I've created a new project and I've only included this library (in addition to appcompat).
I created only one Activity and I added 4 slides.
The problem occurs on my test device using version 1.6 of the library but not with the latest 1.6.2.
The problem is that in my app there is the version 1.6.2 of the library but the  bug occurs.

Well, I have 6 slides in my app and this error still occurs from time to time. I'm on version 1.6.

@TheMaxCoder, @FIndustries I need further information to isolate the error:

Are you using any native code or JNI in your specific application?
Please attach steps to reproduce the behavior on the latest library version 1.6.2.
I don't maintatin older versions of the library.

I'm not using any native code or JNI in my application.
Create a simple project where you add 4 or more pages. With the latest version of the library in my test device it happens occasionally when I keep going back and forth between the pages (Even though I put less than 4 pages): https://drive.google.com/open?id=0B5AjODTu84xCQXNYTnZoaUJpVlU (This problem also occurs during normal use)
Here you are: http://imgur.com/a/heBoL

I can confirm this error aswell, but I have 5 pages in use.

I'm also not using any native code.
I haven't found a way to reproduce the error yet. But I have some reports in my Google Play Developer Console.
Devices I know for sure are Galaxy S3&S4 Mini with Android 4.4.

Very very strange bug... To be honest, I have no idea what causes the bug as material-intro uses no native code.
I have no experience with native Android development so if anyone of you can find the code that causes the issue please post a PR!


Example in section Quickstart Examples doesn't work

Environment Details

Helidon Version: 0.10.0
Helidon SE
JDK version: 1.8.0_181
OS: macos 10.13.6
Docker version (if applicable):

Problem Description
Following by Quickstart Examples I have such output:
2018.09.18 13:44:28 INFO io.netty.util.internal.PlatformDependent Thread[main,5,main]: Your platform does not provide complete low-level API for accessing direct buffers reliably. Unless explicitly requested, heap buffer will always be preferred to avoid potential system instability.
2018.09.18 13:44:28 INFO io.helidon.webserver.netty.NettyWebServer Thread[nioEventLoopGroup-2-1,10,main]: Channel '@default' startup failed. Startup failure routine initiated.
WEB server is DOWN. Good bye!
It happens whenever I run mvn package or directly run the generated example via intellij idea.
 You can change the port in src/main/resources/application.yaml.

@spericas yes, you are right, port 8080 was already in use. Maybe it would be better to adjust the INFO message to something like this: "Port 8080 is already in use"?

I'm closing this issue and opening one for the enhancement.


Unexpected string encoding change from UTF-8 to UTF-16 when using Ecto.Query

Hi, can anyone help me with Ecto? I am having what appears to me to be pretty odd with string encodings. This is weird because it is very unexpected behavior from my pont if view as a developer.
EXPECTED BEHAVIOR
I want to build a query which includes the character "á", which has different encodings depending on whether it is UTF-8/UTF-16 using Ecto.Query and run it.
query = from "questions", select: fragment("correct"), where: fragment("subject = 'Matemática'")

I should get some rows as a result.
ACTUAL BEHAVIOR
If I run the query, I get a Postgres error related to encoding.
iex(13)> Repo.all query
** (Postgrex.Error) ERROR 22021 (character_not_in_repertoire): invalid byte sequence for encoding "UTF8": 0xe1 0x74 0x69
[debug] QUERY ERROR source="questions" db=0.5ms
SELECT correct FROM "questions" AS q0 WHERE (subject = 'Matem�tica') []
    (ecto) lib/ecto/adapters/sql.ex:436: Ecto.Adapters.SQL.execute_and_cache/7
    (ecto) lib/ecto/repo/queryable.ex:130: Ecto.Repo.Queryable.execute/5
    (ecto) lib/ecto/repo/queryable.ex:35: Ecto.Repo.Queryable.all/4

SOME DEBUGGING I DID
This is bad because it should just work. Let's do some debugging, say, let's
see what comes out from Ecto:
{raw_query, []} = Ecto.Adapters.SQL.to_sql :all, Repo, query
File.write "raw_query.sql", raw_query

Then I load the "raw_query.sql" file on Sublime and I see that it is NOT in UTF-8. It shows up validly as "ISO 8859-1", and we see that because the "á" in "Matemática" is encoded as 0xe1 in the byte-by-byte representation:
5345 4c45 4354 2054 5255 4520 4652 4f4d
2022 7175 6573 7469 6f6e 7322 2041 5320
7130 2057 4845 5245 2028 7375 626a 6563
7420 3d20 274d 6174 656d [e1] 74 6963 6127
29

Let's validate against using "á" not going through Ecto:
File.write "raw_term", "Matemática"

When I open the "raw_term" file, I get the following, which is UTF-8:
4d61 7465 6d[c3] [a1]74 6963 61

Here, "á" is encoded by 0xC3 0xA1.
So, I don't know why, but Ecto is somehow "rendering" the query in "ISO 8859-1": if I print the string directly to a file, I get the UTF-8 representation, but if I use it within a query, Ecto will turn it into "ISO 8859-1".
Back to the query. If I do it without Ecto, it works:
iex(13)> Repo.query "SELECT correct FROM \"questions\" AS q0 WHERE (subject = 'Matemática')"
[debug] QUERY OK db=1.9ms queue=0.1ms
SELECT correct FROM "questions" AS q0 WHERE (subject = 'Matemática') []
{:ok,
 %Postgrex.Result{columns: ["correct"], command: :select,
  connection_id: 10112, num_rows: 4,
  rows: [["false"], ["false"], ["false"], ["false"]]}}

So I am really guessing Ecto is changing the encoding to "ISO 8859-1".
MORE INFO
For more information on the "á" character and its code points encodings etc, see:
http://www.fileformat.info/info/unicode/char/00e1/index.htm
SEED FOR THE DATABASE
The seed for the table I am querying against is:
drop table if exists questions;
create table questions (correct TEXT, subject TEXT);
insert into questions values (false, 'Matemática');
insert into questions values (false, 'Matemática');
insert into questions values (false, 'Matemática');
insert into questions values (false, 'Matemática');
insert into questions values (false, 'Outro assunto');
insert into questions values (false, 'Outro assunto');
insert into questions values (false, 'Outro assunto');
insert into questions values (false, 'Outro assunto');

ps. I am not sure my understanding of encodings is right. This was the first time I dealed with it.

When you open up an issue, we ask for a bunch of information to be filled. Please send this information, otherwise we can't help you.

Elixir version:
➜  ~ elixir -v
Erlang/OTP 19 [erts-8.2] [source] [64-bit] [smp:8:8] [async-threads:10] [hipe] [kernel-poll:false]
Elixir 1.4.0
PostgreSQL version:
➜  ~ psql -d xx -c 'select version()';
version
PostgreSQL 9.6.1 on x86_64-pc-linux-gnu, compiled by gcc (GCC) 6.2.1 20160830, 64-bit
(1 row)
Dependencies: (ecto, phoenix_ecto, postgrex)

postgrex 0.13.0 (Hex package) (mix)
locked at 0.13.0 (postgrex) e101ab47
ok
ecto 2.1.1 (Hex package) (mix)
locked at 2.1.1 (ecto) fa8bdb14
ok
phoenix_ecto 3.0.1 (Hex package) (mix)
locked at 3.0.1 (phoenix_ecto) 42eb486e
ok

operating system:
Arch Linux
➜ uname -a
Linux x 4.8.13-1-ARCH #1 SMP PREEMPT Fri Dec 9 07:24:34 CET 2016 x86_64 GNU/Linux

I checked your info. Everything seems to be correct. Could it be that the file for that particular query is with wrong encoding? For example, go back to the query that fails and do inspect query before running it against the repository. What does it return?

This was all run from IEX, so I don't think the file containing the query has the incorrect encoding.
I will try this on a clean phoenix install again and see if I get any different behavior.
iex(4)> query = from "questions", select: fragment("correct"), where: fragment("subject = 'Matemática'")
#Ecto.Query<from q in "questions",
where: fragment(<<115, 117, 98, 106, 101, 99, 116, 32, 61, 32, 39, 77, 97, 116, 101, 109, 225, 116, 105, 99, 97, 39>>),
select: fragment("correct")>
iex(5)> inspect query
"#Ecto.Query<from q in "questions", where: fragment(<<115, 117, 98, 106, 101, 99, 116, 32, 61, 32, 39, 77, 97, 116, 101, 109, 225, 116, 105, 99, 97, 39>>), select: fragment("correct")>"

From the printed query we can see that it is not valid UTF-8 since we see it as a binary fragment. What happens if you just type "Matemática" in IEx?

Fresh new phoenix repo.
➜  weird_bug_ecto iex
Erlang/OTP 19 [erts-8.2] [source] [64-bit] [smp:8:8] [async-threads:10] [hipe] [kernel-poll:false]
Interactive Elixir (1.4.0) - press Ctrl+C to exit (type h() ENTER for help)
iex(1)>  "Matemática"
"Matemática"
iex(2)>

But the query also fails to inspect in the fresh new Phoenix repo?!

I am packaging this as a repo and will push to github in a second. So it gets fully reproducible.

Don't worry, I can reproduce the issue. :)

As a quick fix, you can write your query this way:
query = from "questions", select: fragment("correct"), where: fragment("subject = ?", "Matemática")

The query inspects as a binary in the new phoenix repo.

Thank you for the bug report and information to reproduce the issue. It has been fixed in master!
:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:

@josevalim Obrigado pela ajuda incrivelmente rápida.

@josevalim How does this get pushed down to the phoenix_ecto package so I can update my project?

You can specify Ecto directly as a dependency as:
{:ecto, github: "elixir-ecto/ecto", branch: "v2.1", override: true}

@josevalim - Is there a similar bug on insertion too?
https://github.com/msp/cenatus-ltd/commit/1f71391ad665931436d9357ab79e5757cb0274cb
1) test authorized routes creates resource and redirects when data is valid (non UTF8) (CenatusLtd.ArticleControllerTest)
     test/controllers/article_controller_test.exs:32
     ** (Postgrex.Error) ERROR 22021 (character_not_in_repertoire): invalid byte sequence for encoding "UTF8": 0xc3 0x2d
     stacktrace:
       (ecto) lib/ecto/adapters/sql.ex:571: Ecto.Adapters.SQL.struct/7
       (ecto) lib/ecto/repo/schema.ex:467: Ecto.Repo.Schema.apply/4
       (ecto) lib/ecto/repo/schema.ex:205: anonymous fn/13 in Ecto.Repo.Schema.do_insert/4
       (ecto) lib/ecto/repo/schema.ex:684: anonymous fn/3 in Ecto.Repo.Schema.wrap_in_transaction/6
       (ecto) lib/ecto/adapters/sql.ex:620: anonymous fn/3 in Ecto.Adapters.SQL.do_transaction/3

``

Is this fixed in 2.2.1? I am running into this error occasionally.

I'm also getting this error when trying to store encrypted fields in ecto, using this:
http://blog.danielberkompas.com/elixir/security/2015/07/03/encrypting-data-with-ecto.html

Yes, it is fixed in v2.2.0-rc.0 onwards. It has also been backported to v2.1 branch but we have not released a 2.1 patch that includes it.

Hi, @fishcakez how we can get this patch in 2.1?

You can use the 2.1 branch. It is unlikely we will do a new 2.1 release.

Hi, well at this point dont know if its about ecto or the adapter...
I attach a demo proyect, i apretiate any hint.
running on
Erlang/OTP 20 [erts-9.0] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:10]
Elixir 1.5.2
MSSQL
CREATE TABLE tests (id int NOT NULL, [name] varchar(60) NOT NULL)
INSERT INTO tests VALUES (1, '"príeba áctúalizar"')
then
mix phx.new try_c --no-html --no-brunch --database mssql
mix phx.gen.json Tests Test tests name:string
try_c.zip
and
http://localhost:4000/api/tests
get this...


[enhancement]: HKSV For Floodlight Cam

Describe the solution you'd like
Hello, I have found that the only version of your plugin that works for my camera is the v2.2.7-test.0 version, so far the only problem I am having is that in Eufy Security app I am only see 5 second video recordings, it would be nice if I could view recordings right in the home app using HomeKit Secure Video  like in version 2.2.0-beta.1 while keeping the camera working, if you have any ways to do this please respond, Thank You!

Also, talking through the floodlight camera is not working if you could look in to that it would be great.

looking for tester on 2.3.2 (hksv)

Does not have unbridge camera
It's not working with our floodlight camera.

If you can fix these issues that would be great, thank you!

It would be good if you could just take the HKSV module from 2.3.2 (hksv) or 2.2.0-beta.1 and put it in version 2.2.7-test.0

I went from 2.3.0 to try 2.3.2 - although HKSV is enabled in config settings - I always lose HKSV in Home app.
Only way I can get HKSV to work is rollback to 2.3.0

what camera are you using?

Floodlight Pro Cam Tn8423

The problem I'm having it because this plugin is not working on floodlight cam v1

Could I please hear back from the developers on this one

Hello, anybody there?

We're starting to get lonely on this thread.

hey @JEMcats, I'm working on this plugin during my spare time which is rare atm.

Just adding here for info. Tried v2.3.3 and 2.3.4 hksv versions for Floodlight Pro Cam
I can get camera to add (sometimes requires full cached camera/hub reset) but still no HKSV recording options in Home app - even though enabled in Plugin Settings.
I can always get HKSV to work in the v.2.3.0 version and it always works fine on this version.

It's definitely showing up as a HomeKit secure video camera but it's not recording because the eufy camera is set to record and if i turn off motion detection it never triggers the HomeKit recording

@spikehed Can you send a screenshot of how you configured your eufy cam?


Disalignment between DVS image and 3D annotation

Hi, thank you for great effort to build DHP dataset.
I met disalignment issue when visualizing the data.

As shown in the picture, the 2d keypoints projected from 3d gt label disalign with the DVS image. In this case, the label drifts a bit right for figure 1, and drifts left for figure 2. I'm sure it's not the problem about the visualization tools, since official jupyter script encounters this issue as well.
Could you tell me what cause this phenomenon?

Apologies for my late reply.
Many thanks to your exhaustive explanation!

Hi, thank you for great effort to build DHP dataset.
I met disalignment issue when visualizing the data.

As shown in the picture, the 2d keypoints projected from 3d gt label disalign with the DVS image. In this case, the label drifts a bit right for figure 1, and drifts left for figure 2. I'm sure it's not the problem about the visualization tools, since official jupyter script encounters this issue as well.
Could you tell me what cause this phenomenon?

Hi，
Is the visualization done by processing H5 files? Could you please share your visualization method or code? Thank you

Hi, thank you for great effort to build DHP dataset.
I met disalignment issue when visualizing the data.

As shown in the picture, the 2d keypoints projected from 3d gt label disalign with the DVS image. In this case, the label drifts a bit right for figure 1, and drifts left for figure 2. I'm sure it's not the problem about the visualization tools, since official jupyter script encounters this issue as well.
Could you tell me what cause this phenomenon?

Hi，
Is the visualization done by processing H5 files? Could you please share your visualization method or code? Thank you


Run number environment variable not documented

The docs provide information on defining Run Number format, but "Variables, predefined" does not document reading the Run Number environment variable within a script. It is unclear what environment variable to read to reference the Run Number, which is an important part of signing generated artifacts with correlation IDs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9ffebdc8-521c-44b5-cde4-4abdc1bd6f18
Version Independent ID: dc0effda-6d93-62aa-64c5-4e6f283b0826
Content: Predefined variables - Azure Pipelines
Content Source: docs/pipelines/build/variables.md
Product: devops
Technology: devops-cicd
GitHub Login: @steved0x
Microsoft Alias: sdanie

nudge @steved0x any guidance here?

@msebolt @steved0x (ping)

I've updated Variables, predefined and added a FAQ question to Run (build) number.


Kubernetes Install Instructions Need Helm Chart

I'm on this page and assuming I have a cluster configured with an ingress, I'm looking for a helm chart than installs all pre-reqs + direktiv.
Is such a thing available?

At this stage we have separated the database, Linkerd and Knative. Linkerd is not required and needs generated certificates to work. The database is excluded because it could be any Postgres, e.g. from cloud providers. Although we should add that as an optional dependency in our helm chart. Knative does not have helm charts so we can not add this as dependency. So the answer is no, if you are looking for one helm command installing everything. There is a quick copy&paste though: https://docs.direktiv.io/installation/summary/#direktiv


SVG is namespaced under HTML

On http://higlass.io right now the exported SVG source looks like:
<a0:svg
    xmlns:a0="http://www.w3.org/1999/xhtml"
    xmlns:xlink="http://www.w3.org/1999/xlink"
    xmlns="http://www.w3.org/2000/svg">
    <a0:g>
...

This does not render as graphics in the browser, but do a search and replace for a0: and it does work:
<svg
    xmlns:a0="http://www.w3.org/1999/xhtml"
    xmlns:xlink="http://www.w3.org/1999/xlink"
    xmlns="http://www.w3.org/2000/svg">
    <g>
...

(This is probably the root cause of #173.)

an important note: this bug shows up only when the HiGlass runs inside Firefox. In Chrome, exported SVGs do not have this "a0:" prepended to tags.


PARQUET-565: Use PATH instead of DIRECTORY in get_filename_component

Fixes support for CMake<=2.8.11

Thank you. Do you get the sense that supporting older cmake versions is worthwhile? I don't know what kind of bugs have been fixed or other divergence between >= 3.2.x and old versions.

I would support it for now as long as we support Linux distributions that old (i.e. ones that ship with gcc 4.7+). As long as we do not need any special features, it should work. Otherwise there are always ways to get a newer CMake version but that would make complicated to build parquet-cpp initially on a slightly older system. (All under the assumption that there are not serious problems in CMake < 3.0).


Removing api method-name as GET url param from POST requests.

Since the Last.fm relaunch all POST methods having the API method-name added too as GET param will fail with "Error 13: Invalid method signature supplied".
Removing "method" as GET-param in POST requests fixes this particular problem after relaunch.

yes this is a valid PR. i did the same changes on my local to get the authentication going. please merge this pr :)

@mborho It's merged, thank you!


Write sparse files in restorer

What is the purpose of this change? What does it change?
The capacity to write sparse files has been added to the restorer. Files aren't necessarily as sparse as they can be, since the code for detecting runs of zeros isn't exhaustive, but long runs of zeros have a good chance of being detected.
In a short test, I restored a pair of disk images and found that one only took up half the disk space that it used to. The other one was 13% smaller. Restoring it took the same wall-clock time that it took with current master.
See the commit message for some benchmark results.
Was the change discussed in an issue or in the forum before?
Closes #79. Closes #2378, which tried to do the same thing in a different way. I redid the work since the restorer was just rewritten and I came up with a different heuristic for detecting zero blocks.
Checklist

[x] I have read the Contribution Guidelines
[x] I have added tests for all changes in this PR
[ ] I have added documentation for the changes (in the manual)
[x] There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
[x] I have run gofmt on the code in all commits
[x] All commit messages are formatted in the same style as the other commits in the repo
[x] I'm done, this Pull Request is ready for review

I just read @cdhowie's comment over at https://forum.restic.net/t/sparse-file-support/1264/17 and I disagree with it. That "the presence of SEEK_HOLE would indicate that some programs likely use this functionality" is true, but ordinary application should be using it only as an optimization. Any application that relies on the holes in a file being at specific locations is so tied to a particular filesystem that it cannot work with a general-purpose backup tool anyway, unless the disk image is backed up instead of the files.
Case in point: if the application's requirement is anything other than that the file is completely stored, with all the zeros written out, then it won't work with the current version of restic.

Also, I just double-checked that restoring an all-zeros file works with Linux writing to an NTFS partition. It does. The file is not sparse, but it has the right size and is all zeros.

FWIW, I am not in favour of proposed implementation. I believe restic should preserve original file "sparsiness" (which requires repository format change, unfortunately). For example, files may be intentionally preallocated with zeros to "reserve" space on filesystem to avoid running out of space when writing files with actual data.

That's a good point. Since a format change isn't likely to happen anytime soon, would this implementation + a flag to turn it on/off be an option as a stopgap measure?

This is something for @fd0 to decide, but personally I would prefer a proper solution. Repository format change to support sparse files does not have to break compatibility with older clients. Even if the format change does break older restic version, that may be acceptable too, if the format change is guarded by a feature flag.

As far as I understand current code, this fragments filesystem even more.
I agree with @greatroar that nobody should rely on exact hole position. So it should be probably ok to restore holes not at exact positions (at least for now until proper hole information is not stored).
At the same time I don't like idea of having holes not aligned to filesystem block size. Plus I don't like optimization from latest commit (about early stopping prevents having to do a zero-length). I think that it's bad even for VM usage just because it creates 'block' of zeros in hole.
Here is an example with 16GB sparse file (without single byte of data):
% truncate -s 16G ~/tmp/test.img
% sudo filefrag -e ~/tmp/test.img
Filesystem type is: ef53
File size of /home/dion/tmp/test.img is<PHONE_NUMBER>4 (4194304 blocks of 4096 bytes)
/home/dion/tmp/test.img: 0 extents found

Backup-restore:
% cd ~/tmp; restic backup -q test.img
% /tmp/restic/restic restore latest --target ~/tmp/restore

And restored file:
% sudo filefrag -e ~/tmp/restore/test.img |head -n 20
Filesystem type is: ef53
File size of /home/dion/tmp/restore/test.img is<PHONE_NUMBER>4 (4194304 blocks of 4096 bytes)
 ext:     logical_offset:        physical_offset: length:   expected: flags:
   0:      127..     127:   19212415..  19212415:      1:        127:
   1:      255..     255:   19212543..  19212543:      1:
   2:      383..     383:   19212671..  19212671:      1:
   3:      511..     511:   19212799..  19212799:      1:
   4:      639..     639:   19212927..  19212927:      1:
   5:      767..     767:   19213055..  19213055:      1:
   6:      895..     895:   19213183..  19213183:      1:
   7:     1023..    1023:   19213311..  19213311:      1:
   8:     1151..    1151:   19213439..  19213439:      1:
... 32K lines ...

So I've got 32 thousands of small 'holes' instead of one big hole. It even takes ~8 secs here to dump this...
So I think that we at least should be able to restore multiple adjacent zero blobs as one hole.

When I repeat this, I also get a more fragmented file: 24258 extents versus 25. However, the 8s figure isn't saying much out of context. In my run, restore speed is a factor 100 better than with dense restore: 2.09s vs. 3m20.56s. To simulate what happens when we actually use the file, I ran sha256sum:
$ time sha256sum /tmp/restore-dense/tmp/test.img
07d217ebccc55480b7afa191674ec5da87f2d14efbc04dbc7e40efe345f16776  /tmp/restore-dense/tmp/test.img

real	1m17.382s
user	1m13.928s
sys	0m1.920s
$ time sha256sum /tmp/restore-sparse/tmp/test.img
07d217ebccc55480b7afa191674ec5da87f2d14efbc04dbc7e40efe345f16776  /tmp/restore-sparse/tmp/test.img

real	1m17.524s
user	1m13.449s
sys	0m4.072s

The system time is up by 2x, but the wallclock time is the same. I then copied the files into /dev/null:
# First the original, as a baseline.
$ dd if=/tmp/test.img of=/dev/null bs=4096
4194304+0 records in
4194304+0 records out
17179869184 bytes (17 GB, 16 GiB) copied, 6.19832 s, 2.8 GB/s
$ dd if=/tmp/restore-dense/tmp/test.img of=/dev/null bs=4096
4194304+0 records in
4194304+0 records out
17179869184 bytes (17 GB, 16 GiB) copied, 190.28 s, 90.3 MB/s
$ dd if=/tmp/restore-sparse/tmp/test.img of=/dev/null bs=4096
4194304+0 records in
4194304+0 records out
17179869184 bytes (17 GB, 16 GiB) copied, 5.89015 s, 2.9 GB/s

That's a factor 32 faster and on par with the completely sparse file, despite the additional fragmentation.
This is on Linux/amd64 with an ext4 fs on an old spinning disk.
All this is not to say that there's no room for improvement. I can try to implement the Truncate dance.

I think that it's better to wait for @fd0 feedback to understand chances about merging this in any form.

I already did it. Restore speed is unchanged here, so I think the 8s you were observing was just the time to fetch the backup from the repo.

WriteAt should not need synchronization:

Clients of WriteAt can execute parallel WriteAt calls on the same destination if the ranges do not overlap.

Regarding the prefix-only heuristic, it's a speed hack, but if we want to preserve sparsity information, the whole point is of course moot. I'll close this PR.


2022-05-11 Meeting Agenda

Sorry a bit late with the issue.
Time: 21:00 UTC / 17:00 EST / 14:00 PST
Click here to join the meeting
Agenda
No items have been brought to our attention, possible talking points.

.NET Foundation Website?
Other Business

Please add additional agenda items in the comments below.

Meeting Notes

Set up a poll in the Slack channel for time alternatives for the meeting. Should we alternate times every other month?
Mattias and Rob to attend project committee to define boundaries between the committees
Projects are starting to offboard. Martin is complete, Prism is started. There might be one other project in the pipeline.
Sponsorship benefits are ongoing and will be released soon.
Projects benefits. What benefits can projects use? It would be good if project maintainers could come up with support they need.

Trademark search?
Azure credits
Technical writers to help with the websites
A legal FAQ for maintainers, our agreements, infringements, etc.

Sitefinity and American Eagle website transition is signed
Are there any plans for a maintainer's wiki?
New membership website is in the works
How can we open up membership more widely to students and non-technical people

We've had designers and writers help out with projects
Having an active GitHub account may not be a good indicator
If we have voting members we need to verify they are a real person
How do other Foundations deal with this
Apache only accepts nominated members
Other groups have student and other classes of members
Can a member projects be sponsors? Needs to scale and be simple.
Automated ways like verifying PRs, issues, nuget packages, etc.

Action Items

Set up a poll in the Slack channel for time alternatives for the meeting.
Feed the membership ideas back to to the membership committee

With the automated way of checking members, be useful to see the full applicant details including their response to questions and see something like "ticks/crosses" against the automated metrics. That way for the easy cases a membership committee can just hit the "Approve" button quickly. It won't cover more edge cases but will simplify the easier cases where the applicant has done a lot of open source development.


Draft GH Action Deployment Workflow Error.

Placing this as I can consistently see this error for against my MacOs.
<!-- IMPORTANT: Please be sure to remove any private information before submitting. -->

Does this occur consistently? Yes
Repro steps:

1. Download extension.
2. Try to run: Draft GH Action Deployment Workflow

Error which happens in the end:
Action: aks-draft-extension.runDraftWorkflow
Error type: Error
Error Message: Failed to list subscriptions: AggregateAuthenticationError: ChainedTokenCredential authentication failed.
CredentialUnavailableError: EnvironmentCredential is unavailable. No underlying credential could be used. To troubleshoot, visit redacted:url
CredentialUnavailableError: ManagedIdentityCredential: Authentication failed. Message ManagedIdentityCredential - No MSI credential available
CredentialUnavailableError: ERROR: AADSTS700082: The refresh redacted:key expired due to inactivity. The redacted:key issued on redacted:id01T17redacted:id8553181Z and was inactive for redacted:id.
Trace ID: redacted:id
Correlation ID: redacted:id
Timestamp: redacted:id redacted:id55Z
Interactive authentication is needed. Please run:
az login --scope redacted:url

CredentialUnavailableError: Error: Unable to execute PowerShell. Ensure that it is installed in your system. To troubleshoot, visit redacted:url

Version: 0.1.2
OS: darwin
OS Release: 22.6.0
Product: Visual Studio Code
Product Version: 1.80.1
Language: en

<details>
<summary>Call Stack</summary>

getAsyncResult extension.js:2:5283530
getAsyncOptions extension.js:2:5288637
sort extension.js:2:5291355

</details>

Interesting -  this need az cli to be logged in at the background


[#562][DotNet] Add Azure Storage Blobs tests to the test solution

Addresses # 562
Description
This PR adds the Azure Storage Blobs tests to the new Integration test project.
Detailed Changes

Added Microsoft.Bot.Builder.Azure.Blobs dependency to the Integration.csproj.
Moved CosmosDbBaseTests and CosmosDbStorageItem to the Storage folder, allowing reusing all the tests related to classes that implements IStorage.

The base tests have been renamed and marked as Fact, so, when other classes inherit from it, it will inject automatically all the tests for a specific Storage.
Added support for testing multiple Storage cases (e.g default config or with TypeNameHandlingNone in the JsonSerializer).

Updated all CosmosDb related classes to support the new test structure change, multiple Storage configurations, and new added tests.
Added new Blobs Storage and Azure Blob Storage tests with similar tests and fixture configuration as for CosmosDb. Also, detects if the Blobs service is up and running.

Testing
The following images show the new Storage Blobs tests added to the Integration project, alongside the folder structure.

Closed in favor of #144


[api] Implement Analysis module

Closes #9
This implements the tiny Analysis namespace.

Addressing the comment in Module.kt on L101:
The bytes returned from the function call are really strange. Some of them are negative and a lot of them are null. Maybe this isn't the right way of extracting the string?


GridField should respect pagination and filtering on save

In many cases, you're either editing a record, or you're paging through related data on the same editing view. For example, on a page with a "related documents" GridField, you're either editing page content, or editing details on a related document (in the GridField detail form).
But: In some cases those two activities overlap, particularly when the GridFields have inline editable fields which are saved "through" the same record. In this case, it's important that the GridField view you're currently looking at is retained, incl. sorting, filtering and pagination. It doesn't inspire confidence in a system if the editable row you've just entered and saved just disappears because it happens to be on the second page.
You could call this an issue on the module providing GridFieldEditableColumns, but I think this should work for all GridField views.
This kind of state management complexity makes me want to rewrite the whole edit view as a client-side app where you just transfer data rather than view content, but that's ... slight scope creep.
An alternative way to solve this is by allowing per-row saving.
Related issues:

Navigating back from a record in a GridField doesn't respect selected pagination
GridField search doesn't update pagination
Retain list view state when returning from edit view

Acceptance criteria

When you save a record within the Gridfield, the state is remembered. e.g.
You can use the pagination to go to the next record.
If it's trivial to back port this to CMS4 and it doesn't require new API, fix it in CMS4

Notes

There's a potential edge case where you are filtering or sorting on a specific value. Saving the record changes its order on the list or exclude from the results sets. We can live with this edge case, as long as you are still viewing the same record after your save.
Related issue https://github.com/silverstripe/silverstripe-admin/issues/1454

Another semi-related issue https://github.com/silverstripe/silverstripe-admin/issues/886

FYI I've suggested building on #9190 to fix this by getting grid field state pushed into the URL via the history API, and have it be managed by GridField itself rather than selected components.

With the latest improvements to GridField state in 4.12.0 this issue now sticks out like a sore thumb. As if you click the back arrow from a record, the pagination/filter is remembered, but if you save that record and then click the same back arrow the pagination/search is reset.
Presume this is on your radar @GuySartorelli 😊

Any progress on this? I'm happy to try to dog into this if someone can give me some pointers?

From my understanding, this line is wrong as it results in always adding an empty state to the form submission:
https://github.com/silverstripe/silverstripe-framework/blob/ca542a386b2b9afaad07fea3f2c3b48325dbc5e4/src/Forms/GridField/GridFieldDetailForm_ItemRequest.php#L418
GridState itself is already a HiddenField, so simply adding the state solves the problem, at least partially:
$actions->push($gridState);

Only partially as this will only save the state of the current GridField, but none of the other (parent) GridFields. I am not sure how to best solve this. From my testing it seems to be most feasible to remove the hidden field at all and modify the form's action to include all current GridField states as query parameters. This seems to work pretty well:
@@ -291,6 +291,9 @@ class GridFieldDetailForm_ItemRequest extends RequestHandler
             $cb($form, $this);
         }
         $this->extend("updateItemEditForm", $form);
+
+        $form->setFormAction($this->getGridField()->addAllStateToUrl($form->FormAction()));
+
         return $form;
     }

@@ -415,7 +418,6 @@ class GridFieldDetailForm_ItemRequest extends RequestHandler
             }

             $gridState = $this->gridField->getState(false);
-            $actions->push(HiddenField::create($manager->getStateKey($this->gridField), null, $gridState));

             $actions->push($this->getRightGroupField());
         } else { // adding new record

Only "pretty well" as there is a different handling in escaping spaces (I assume depending on the kind of http method). Restoring the a grid filter may result in a wrong unescaping, changing "john doe" to "john+doe".

Two dumb questions:
Does PHP need to know grid state at all? Or it this all handled in react anyway? If we only need to know state in the front-end, how about storing it in e.g. local storage? If we need it in the backend, then the hidden field is a good solution, as long as the current state doesn't include any parent state data (see next question).
I thought grid state was saved in the session using a unique key per gridfield, e.g. 'gf_xyz'? If that's the case parent gridfield state shouldn't be affected by pushing the state of the current field, right?
The query string is not a good solution as its length is restricted to 1024 characters afaik.

Does PHP need to know grid state at all? Or it this all handled in react anyway?

The GridField is only partially implemented in react (it notably does not work in a pure react form) - and the navigation within a gridfield results in a fresh react component (state and all) being completely reinstated. React does not and currently can not handle a gridfield state.

The query string is not a good solution as its length is restricted to 1024 characters afaik.

There is no theoretical limit to the URL or the query parameter in the standard (see RFC 2616/3.1.2) but some practical limits in browsers and webservers. In former times Internet Explorer (what else) forces a limit of 2083 characters (see in RedirectorPage).
I do agree that the query param is not a perfect solution. When using a different solution there a several aspects to consider from my point of view:

It should be possible to use multiple windows of the same application with different grid field states (filtering one model admin by "x" and another one by "y"). Therefore local storage is not an option. I see a similar issue when using the session, we would need to namespace this per tab/window somehow.
Using session storage can solve this issue, it needs to be considered whether opening an new tab/window should retain the current grid field state (which I would accept from a user's perspective).


DBZ-4814 exclude spatial_ref_sys

https://issues.redhat.com/browse/DBZ-4814

@ani-sha, @Naros, any idea why no build seems to have run for this one?

any idea why no build seems to have run for this one?

That's an excellent question and one for which I have no answer.  The original contributor isn't new so therefore the actions should have been queued up.  I did see that Github Actions did have a small incident report a few hours ago so perhaps that might be why?

I did see that Github Actions did have a small incident report a few hours ago so perhaps that might be why?

Ah yeah, that could be it. Seems I should not just have merged, because now there's this failure: https://github.com/debezium/debezium/runs/5759229201?check_suite_focus=true. Did that PR build for you locally, @zalmane?

it did. let me try rebasing and build again locally.
On Wed, Mar 30, 2022, 21:34 Gunnar Morling @.***> wrote:

I did see that Github Actions did have a small incident report a few hours
ago so perhaps that might be why?
Ah yeah, that could be it. Seems I should not just have merged, because
now there's this failure:
https://github.com/debezium/debezium/runs/5759229201?check_suite_focus=true.
Did that PR build for you locally, @zalmane https://github.com/zalmane?
—
Reply to this email directly, view it on GitHub
https://github.com/debezium/debezium/pull/3357#issuecomment-1083481377,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANAS5QIS5UFBUDWOQ7MG7TVCSNCHANCNFSM5SB36WRA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@gunnarmorling I rebased and it actually now fails on the same test. It seems to stem from the change to line 60 in PostgresSchema.
I change it to config.getTableFilters().dataCollectionFilter() as you had suggested in the ticket. Seems it is throwing a NullPointerException in that test.
Thoughts?

@zalmane Got the error, checking.


Context menu position issues within CSS transform

I have a component that I insert into different views and use the context menu in that component. It works great when it's in the main view on any of my pages but when I add the component to a modal window the placement of the menu is pretty far off and in some cases the menu goes below the fold of the page and the user can't even see all of the menu items. I'm not even sure where to begin on this...

I think that's being caused by the way I'm using css to position the context menu.  The context menu is set to position: absolute and then the top and left properties are set relative to the window.  This works fine as long as there isn't another parent element of the context menu that has position: relative.  When that happens the top and left properties offset the context menu based on the top left corner of that element, instead of the window.
There are a couple workarounds, but no great solution yet:

Don't style any parent elements of the context-menu element with position:relative.
Add margin-top and margin-left properties to the .angular2-contextmenu class that are the exact opposite value of the top/left corner of the element that has position:relative.

I'll think about a better way to do this.  Probably having javascript calculate the values would work.

Oh, another workaround is to have one global context menu in a template at the root of your app and then use the contextMenuService to trigger it like this.

As of right now I don't control the css of the modal window at all. I use ng2-boostrap for my frontend stuff. I'd prefer not to do a global menu if I can help it but I'll def take a look at your third suggestion.
https://valor-software.com/ng2-bootstrap/#/

It looks like .modal-dialog is the culprit.
.angular2-contextmenu {
  margin-top: -30px;
}

That should take care of the vertical positioning, but it's hard to offset margin: auto for the horizontal position.  You'll probably need to use javascript to calculate the left edge of the .modal-dialog element.  Or you could submit a PR for me... 😀

One way I could think of would be being able to declare it's container and then setting it's positioning based off that container?

I like that solution. I'd want it to default to the plain css solution
since that is more performant and works for most users. I won't be able to
implement it for a while but would be happy to review a pr.
On Jan 19, 2017 6:12 PM, "Jason Redd"<EMAIL_ADDRESS>wrote:

One way I could think of would be being able to declare it's container and
then setting it's positioning based off that container?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/isaacplmann/angular2-contextmenu/issues/42#issuecomment-273928543,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0lQJqR38JHN5yrN4KCLdkWEFoSDPOHks5rT-3kgaJpZM4Lok-E
.

I just came across this same scenario in my app, so fixing this bug has been moved up my priority list.

This should be fixed in 0.7.3.
It's actually not position: relative but transform that causes the issues.  A lot of frameworks use transform: translate3d(0px 0px 0px) to force the browser to use the GPU.  When the <context-menu> element is inside one of those elements, the top and left properties are calculated based on the transformed element instead of the body.

I have a positioning issue with the context menu. It is displaying in such a way that its top half is getting underneath the browsers addressbar and it is not visible. Looks like its top-margin calculation is going wrong. Any suggestions as to how I can go about addressing it?

@kotrao what are the css properties on the parents of the <context-menu> element?  Specifically, do any of the parent elements have a transform property?  Or position: relative?
Also, is the context menu tall enough that it would go off the bottom of the viewport if positioned normally?

Please see below for the hierarchy of parents. Also I have only 4 lines in my context menu. Right now, context menu  is using mouse click position as bottom right. As a result it is being cut off by browser address bar.

 ....something else...

                               **
                                        ....4 items in the menu..
                               **

Thanks for the html - that let me reproduce it.  See if version 0.7.5 fixes the problem.

You definitely fixed the issue when the context menu is inside of modals... The issue is, with the update, it's broken the modal in the regular view...

Ok, send me the html structure like @kotrao did.  I'll try to reproduce your issue.

I may have fixed your issue with version 0.7.7.  I wasn't getting the styles from any stylesheets when I calculated the position of the context menu.

Nope wasn't fixed on my side. The menu that I have the context menu on is around 5 components deep in my dom. I'm using angular2 . It works fine in version 0.5.3...

Hi Isaac. Thanks for the great component.
This issue is affecting me too.
Because .col-* classes in Bootstrap have position: relative I had to add this override:
.col-xs-1, .col-sm-1, .col-md-1, .col-lg-1, .col-xs-2, .col-sm-2, .col-md-2, .col-lg-2, .col-xs-3, .col-sm-3, .col-md-3, .col-lg-3, .col-xs-4, .col-sm-4, .col-md-4, .col-lg-4, .col-xs-5, .col-sm-5, .col-md-5, .col-lg-5, .col-xs-6, .col-sm-6, .col-md-6, .col-lg-6, .col-xs-7, .col-sm-7, .col-md-7, .col-lg-7, .col-xs-8, .col-sm-8, .col-md-8, .col-lg-8, .col-xs-9, .col-sm-9, .col-md-9, .col-lg-9, .col-xs-10, .col-sm-10, .col-md-10, .col-lg-10, .col-xs-11, .col-sm-11, .col-md-11, .col-lg-11, .col-xs-12, .col-sm-12, .col-md-12, .col-lg-12 {     position: inherit; }
Everything seems to be OK for now, but presumably at some point I'll probably hit the use-case the authors were guarding against.
I'd be OK with the idea of having a single global context-menu as long as it were possible to define the contextMenuItem templates in the components that would trigger it. Having a collection of context menus at the root of the application always loaded and waiting to be triggered does not appeal though.

Yeah, that's a hacky workaround - sorry about that.  I have an idea for a solution that will dynamically add context menus to the root as needed - which will avoid all these annoying css conflicts.  I'll update all the related issues once it's ready - maybe a week from now.

Awesome, thanks Isaac!

Should be fixed by the move to ngx-contextmenu.  Please open an issue there if this doesn't work.

Confirmed and my ugly hack removed. Thank you so much!


IOS doesn't receive Dynamic Links on first install (No pre-install link matched for this device)

Description
Referencing an old issue that was closed by the bot: #7406
#7406
We are seeing an issue where the deferred dynamic link is not picked up when using the Skip app preview for ios.
In the console is: (No pre-install link matched for this device)
Can we reopen this old issue or look into this properly as its affecting us and undocumented.
Reproducing the issue
Steps to reproduce:

App not installed previously
Tap Dynamic Link
Device show App Store page for app
From Xcode build and run app
Wait for console error "No pre-install link matched for this device"

Firebase SDK Version
firebase_dynamic_links: ^5.0.15,  firebase_core: ^2.5.0
Xcode Version
14.2.0
Installation Method
CocoaPods
Firebase Product(s)
DynamicLinks
Targeted Platforms
iOS
Relevant Log Output
No response
If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet

Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet

Replace this line with the contents of your Podfile.lock!

I'm stuck on this as well. I'm using a custom domain. If I use the firebase default domain it works fine.
There are a few issues related to this and they keep getting closed. It's a valid issue.

Sorry for the trouble. I've raised this issue to the FDL team, and I'll let you know once I got an update.

Thanks @rizafran, much appreciated!

The Firebase Dynamic Links service will be shutdown on August 25, 2025.  In the meantime, only critical or security issues will be fixed in the SDK.
More at https://firebase.google.com/support/dynamic-links-faq


add suport for previous pops on props change

this caused a problem for me when using recompose - i had to have access to existing props on the callback, and they were'nt there...

Current coverage is 100.00%

Merging #123 into master will not affect coverage as of f7d4e4e

@@            master    #123   diff @@
======================================
  Files           42      42
  Stmts          312     312
  Branches         0       0
  Methods          0       0
======================================
  Hit            312     312
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of f7d4e4e

Powered by Codecov. Updated on successful CI builds.

Agree with this PR. (Except null, I prefer undefined as it allows to use default values)
BTW I've never used this HOC,
in local projects I use modified version of this HOC.
With next additions:

In most cases I need to do something in componentWillReceiveProps if something has changed, so I use shallowEqual on selected props. Like

doOnPropsChange(
  ['someProp', 'someOtherProp'],
  (props) => { do something }

The next problem is state change, for example

withState('someState', 'setSomeState', blabla),
doOnPropsChange(
  ['someProp', 'someOtherProp'],
  ({ setSomeState }) => {
    setSomeState(blublu);
  }
)

As state is coming from parent this causes additional render. In some of my cases this causes desynchronization of overall component state. So I added ability to prevent first render.
withState('someState', 'setSomeState', blabla),
doOnPropsChange(
  ['someProp', 'someOtherProp'],
  ({ setSomeState }) => {
    setSomeState(blublu);
    return PREVENT_RENDER_ONCE; // exported symbol
  }
)

The problem that this PREVENT_RENDER_ONCE should be called explicitly as only user know has the state changed or not.
I can't say that I like my solution, It can give unpredictable result with PREVENT_RENDER_ONCE logic, I feel it can be more easier, so let's discuss what we can do with current HOC.

My local version
import { Component } from 'react';
import pick from 'lodash/pick';
import shallowEqual from 'recompose/shallowEqual';
import createHelper from 'recompose/createHelper';
import createElement from 'recompose/createElement';

export const PREVENT_RENDER_ONCE = Symbol('Prevent redraw on current call');

const doOnPropsChange = (depdendentPropKeys, callback, BaseComponent) => {
  const pickDependentProps = props => pick(props, depdendentPropKeys);

  return class extends Component {
    lastCall_ = undefined;

    componentWillReceiveProps(nextProps) {
      if (!shallowEqual(
        pickDependentProps(this.props),
        pickDependentProps(nextProps)
      )) {
        this.lastCall_ = callback(nextProps, this.props);
      }
    }

    shouldComponentUpdate() {
      / / A BIG PROBLEM: If callback returns PREVENT_RENDER_ONCE but where were no setState this shows old result
      if (this.lastCall_ === PREVENT_RENDER_ONCE) {
        this.lastCall_ = undefined;
        return false;
      }

      return true;
    }

    render() {
      return createElement(BaseComponent, this.props);
    }
  };
};

export default createHelper(doOnPropsChange, 'doOnPropsChange');

Like @istarkov said, we're probably going to remove this from the next version, and point people to either rx-recompose or normal React classes, instead.

Thanks for the PR, though! Closing for the above reasons


feat: Adds token container documentation

Description

Documents the new container attribute on token requests and responses
Documents default container values per token type
Documents how to search by the container attribute, including wildcard searches.

Testing required outside of automated testing?

[x] Not Applicable

Screenshots (if appropriate):

Rollback / Rollforward Procedure

[x] Roll Forward
[ ] Roll Back

Reviewer Checklist

[] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.59.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Theme Disappearing/Deleted After Update

I have a custom theme in the extensions folder. After updating this folder is always deleted. I assume this is because I didn't get this theme from the store and created and placed it myself. I really didn't want to go through the hassle of getting my personal theme in the store, but I also don't want to have to re-copy the thing over after every update.
Is there a way to avoid my theme from getting delete every update? Is there a better place to put my personal theme than the extension folder?

@umbraesoulsbane What do you mean by updating? Updating VS Code or updating the them extension? If it is updating the extension, how are you updating it?

Updating vs code. The theme is custom so it only updates when I open files and change them. :)


Adding power-iaas service, and variables.

So this should get us the service that we get the service_instance_id (or as it's called in ibm terraform provider the cloud_instance_id) from correct? If so should probably call your new module here https://github.com/openshift-powervs/installer/blob/add-ipi/data/data/powervs/main.tf#L6 and then plug in the service instance id here https://github.com/23TNC/installer/blob/add-ipi/data/data/powervs/main.tf#L9 ?

I didn't add this service as a module and integrate it, because we will need to continue using the existing hand built service.  This is because the networking still needs to be set up programmatically for this service.

@23TNC ah that makes sense.

One other thing I noticed -- can you sign your commits and include a description? we'll most likely squash all this down into one huge commit later and put all our signoffs, but good practice and just in case we don't. (cc @mjturek @bpradipt @Karthik-K-N )

@mjturek please rebase

@23TNC looks like it still needs a rebase. i can't merge it as-is.
also please do edit the summary (via the web ui) and manually add the signoff and summary for this commit. i believe that's what will show up in the commit history
after that, LGTM except the variable names not all matching, but I'll fix that in another PR after we decide on a convention (powervs vs ibmcloud, when & where)


iterative inference

Hi,
could you share an inference script for batch image iterative interactive segmentation without a graphical interface? For example, using images and manual scribble-prompts in the MedScribble dataset, evaluating dice scores between predicted and ground truth segmentations through multiple interactions. The first interaction is prompted using a box, followed by multiple corrections prompted with points or scribbles.
This would help me better understand the overall model setup and inference process. Thank you very much!

Hi,
Thanks for reaching out! For the evaluation in the paper using manual scribbles from MedScribble, we did not make iterative predictions. We just made one prediction for each image using the set of positive and negative scribbles (for each image) as input.
For the experiments with simulated interactions though, we did simulate iterative interactive segmentation for each example.
I've added a new section to the Google Colab tutorial to show example code for iterative inference (see Scribbles > Iterative Inference). There's also an example of batched inference under Inference > Bounding Boxes > Batched Inference

Hi, I've added the code for generating clicks to the repo here. See notebooks/prompt_generator.ipynb for example usage of the prompt generator code and iterative inference.


Unable to position the calendar in desired position of the window

I wanted to display the calendar above the text input box, and hence forth unable to override the style top property.

I made openSelectorTopOfInput : true, and it works

not working for me

Try option appendSelectorToBody: true


version: post-release bump

Signed-off-by: Lars Holm Nielsen<EMAIL_ADDRESS>

Coverage remained the same at 97.002% when pulling 37282f1185c3d288c404e0f6cbd215d7ac3221dc on lnielsen:postrel into 632d933b1e43ead3b5506522e09c6d2f9dc2c55d on inveniosoftware:master.


Adjust JDK15+/J9/Windows builds to pick up correct openssl

Update to https://github.com/AdoptOpenJDK/openjdk-build/pull/2339 to pick up the correct OpenSSL build

Pushed another update into here as the original logic was flawed (I'd added it to a >=11 isntead of >11 section.
I'm going to force this through without two approvals as it's a build break fix (FYI @karianna)


Update jsdom to 8.x

Changelog: https://github.com/tmpvar/jsdom/blob/master/Changelog.md

All tests pass when I bring in the changes from https://github.com/facebook/jest/pull/716/files

If only we could open source all of the Facebook JS code. We have thousands of tests and they are all depending on clowny behavior in jsdom. jsdom is getting more awesome with every release, but when they become more compliant, we have to go in and fix hundreds of tests! That's unfortunate and it'll take a little bit of time to make this (seemingly) simple update :) We are working on it!

Hah, I've been having to do monkey patching of my own internally... I feel your pain.

The need for this PR is alleviated via https://github.com/facebook/jest/pull/745.

@facebook-github-bot import

I'm going to merge #873 which will split up the environments. We'll make it easier for the future to customize the env, as well. I think I'm gonna bump the jsdom version for this.


Any reason why debug is still using "ms 0.7.2" version

Any reason why debug is still using ms 0.7.2 version?
"dependencies": {
"ms": "0.7.2"
node security scanner is complaining that this dependency is vulnerable to CVE-2015-8315, https://nodesecurity.io/advisories/46 although its a false- positive detection since fix is implemented beginning at 0.7.1 and up.
Thanks!
Ron

@guerilla7 that advisory says at the top: Patched: >0.7.0 and 0.7.2 is both greater than 0.7.0 and the latest version of ms published to npm.


Change text on 'About' screen in all languages

AboutActivity currently says "Bugs at Bugzilla", which might have worked once upon a time but now redirects to http://phabricator.wikimedia.org which is a bit too general. Perhaps it might be better to link to the GitHub 'issues' page here instead?

Sure! Good catch.

Fixed

It seems to be fixed only in the English version. Searching for "https://bugzilla.wikimedia.org/enter_bug.cgi?product=Commons App", currently still has 49 results.
I also noticed that the main README.md does not mention where people can help with the localization of the app.
I suggest reopening the issue, until both things are resolved.

@tobias47n9e : The URL in your post does not seem to work in my browser, maybe it is linked to your session or something? A manual search does not show any recent bug. Woiuld you mind posting a screenshot?
By the way, localisation is non-existent right now.
I really hope this gets fixed soon: https://translatewiki.net/wiki/Thread:Support/Former_WMF_app_now_community-maintained,_where_to_crowdsource_localization%3F
There is an issue about that: https://github.com/nicolas-raoul/apps-android-commons/issues/62
Meanwhile the string manually could be removed manually, I guess.

@nicolas-raoul This is the link to the search:
https://github.com/nicolas-raoul/apps-android-commons/search?utf8=✓&q="https%3A%2F%2Fbugzilla.wikimedia.org%2Fenter_bug.cgi%3Fproduct%3DCommons%2520App\
The link immediately redirects to "https://phabricator.wikimedia.org/"
Here is a screenshot of the German version with the wrong name for the link and the URL mentioned above:

Done :-)
find . -type f -print0 | xargs -0 sed -i 's/Bugzilla/Github/g'
find . -type f -print0 | xargs -0 sed -i 's/https:\/\/bugzilla.wikimedia.org\/enter_bug\.cgi?product=Commons%20App/https:\/\/github.com\/nicolas-raoul\/apps-android-commons\/issues/g'


fix(stepper-icon): misalignment of icon

Icon is misaligned when using icon overrides:

This is handled by https://github.com/angular/material2/pull/12947 already.

@crisbeto Oh great!!!


Footer doesn't show buildnumber

In v1.2, the footer shows IPT Version 2.3-SNAPSHOT-r${buildNumber}. Any idea why the buildNumber is not populated?

Seems corrected in production


feat(interview-prep): Converting and Transfering Rosetta problems

Checklist:

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #XXXXX

The CI is broken due to unrelated changes to the PR. We will rebase this soon.

@raisedadead Okay.

@raisedadead Thanks for the help.
@scissorsneedfoodtoo Here is the next set of problems. Can you please review this?

@NitronR, thanks for your patience. Sure, I'll look at this now.

The multiple code blocks in the comments would have been difficult to figure out, so I hope you don't mind that I pushed my changes to your branch.
Everything LGTM. We just need one more review before merging this. Could you take a look if you have some time @thecodingaviator?

@scissorsneedfoodtoo Thank you for the review and fixing the problems.
@thecodingaviator Thank you for reviewing this, I have done the changes. Please let me know if anything else can be improved.

@NitronR just a little FYI: You can click add to batch and commit everything from there. Saves time.

Thanks for more amazing ports @NitronR, and thank you @thecodingaviator for your thorough review. Everything LGTM :+1: :+1:

I'm wondering if we should try and make sure to add guide pages and forumTopicId's when we merge these.

@moT01 Sure. How can I create those?


Can't set externalClusters

Just as title, the helm chart does not support setting externalClusters field, the field can be seen in docs:
https://cloudnative-pg.io/documentation/1.24/database_import/

The chart is responsible for filling in the externalClusters section based on your recovery configuration. I don't want to expose it.
https://github.com/cloudnative-pg/charts/blob/3c5dd5d9997592aeb1391b4d11ed2284d68dba31/charts/cluster/templates/_bootstrap.tpl#L43-L90
Import is not yet supported. There is a PR that adds support for it, but I probably won't get around to merging that soon.
If you need import, I would suggest you interact with the operator directly.


The meaning of auxiliary_loss

Hello,I want to inquire about the meaning of auxiliary_loss and auxiliary loss term.

Hello,
this piece of code is just something we experimented with when developing DiffSBDD.
We have always turned it off in our final experiments (e.g. here).


Vite build not generating the php_{locale}.json file

Running vite build does not generate the php_{locale}.json file and in turn doesn’t allow vite to compile the vue components.
At the start of running vite build the file does show up in the logs, but is nowhere to be found afterwards
Vite config:
import { defineConfig } from "vite";
import laravel from "laravel-vite-plugin";
import vue from "@vitejs/plugin-vue";
import i18n from "laravel-vue-i18n/vite";

export default defineConfig({
    plugins: [
        vue(),
        laravel({
            input: [
                "resources/sass/_main.scss",
                "resources/js/app.js",
<EMAIL_ADDRESS>                "node_modules/normalize.css/normalize.css",
            ],
            refresh: true,
        }),
        i18n(),
    ],
    base: "./",
    resolve: {
        alias: {
            vue: "vue/dist/vue.esm-bundler.js",
        },
    },
});

[commonjs] Could not load /project/lang/php_en.json: ENOENT: no such file or directory, open '/project/lang/php_en.json'
transforming (87) resources/js/components/KanbanBoard.vue

did this happened on vite build or on just vite?
Thanks.

Just vite build, vite works just fine

Can you create a test repo that replicates this problem?


[Fix] deprecation warnings numpy 1.25.0

Deprecation

The default behavior of numpy.linalg.lstsq will be changed, to fix this, set a parameter for rcond

set to rcond = None in granger

Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ensure you extract a single element from your array before performing this operation.

fixed in gpfa, icsd, phase analysis

changed import from numpy.testing.utils to numpy.testing
Comment out  example in doc string of icsd unittest, pytest is trying to run this as a docstest
replaced np.matrix with ndarray in KCSD

Thanks @rjurkus for your help approval on point 1, rcond = None .


Update bundle for 0.12.0

Signed-off-by: Janki Chhatbar<EMAIL_ADDRESS>

Discussed on the community call today that we should drop the bundle support since it's broken, and we'll properly re-add it in the future when it's needed.


bug fix : controller use before declare

nice. what is the bug exactly? is it related to the audio not working? FYI, just put out a new release yesterday https://github.com/vimeo/vimeo-unity-sdk/pull/9

error message:
NullReferenceException: Object reference not set to an instance of an object
the controller is null in this line
                 controller.audioSource = audioSource.GetComponent<

AudioSource>();
moving the code block below
controller = gameObject.AddComponent();
sovlved the problem.
On Fri, Feb 9, 2018 at 12:25 PM Casey Pugh<EMAIL_ADDRESS>wrote:

nice. what is the bug exactly? is it related to the audio not working?
FYI, just put out a new release yesterday #9
https://github.com/vimeo/vimeo-unity-sdk/pull/9
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/vimeo/vimeo-unity-sdk/pull/10#issuecomment-364500666,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACwKE1OOTGnW6W6W02YpYMK_3EV_TsNHks5tTH-cgaJpZM4SAQQm
.

Thanks a lot for this! The issue has been fixed in this pull request.
Also, it should now create an AudioSource if there is no one attached to the screen GameObject


feat!: x/drip module

x/drip is a module that allow a specific set of addresses, decided by governance, such as smart contracts, daos or any other entity to distribute native tokens at every block together with standard juno staking rewards
TODOs:

[x] Tests
[x] ICTest
[x] Move drip to v17 upgrade handler
[x] Docs

drip drip for tha 6m$ fam, works with tokenfactory ye?
Sent from Proton Mail via Nokia 3310
On Tue, Jun 6, 2023 at 21:27, Andrea Di Michele @.***(mailto:On Tue, Jun 6, 2023 at 21:27, Andrea Di Michele < wrote:

x/drip is a module that allow a specific set of addresses, decided by governance, such as smart contracts, daos or any other entity to distribute native tokens at every block together with standard juno staking rewards
TODOs:

Tests
Docs

You can view, comment on, or merge this pull request online at:
https://github.com/CosmosContracts/juno/pull/709
Commit Summary

e7c06e9 first version of the drip module
fcff3f4 check if sender is allowed
ef6bc6b drip: remove x/params dependency
2d7a83b genesis test
88c3285 types tests
0fc2708 Merge branch 'main' into dimi/drip
a89ac6b update drip to v16

File Changes
(36 files)

M app/keepers/keepers.go (15)
M app/keepers/keys.go (2)
M app/modules.go (7)
A proto/juno/drip/v1/genesis.proto (20)
A proto/juno/drip/v1/query.proto (27)
A proto/juno/drip/v1/tx.proto (59)
A x/drip/README.md (7)
A x/drip/client/cli/query.go (60)
A x/drip/client/cli/tx.go (66)
A x/drip/genesis.go (26)
A x/drip/genesis_test.go (113)
A x/drip/integration_test.go (90)
A x/drip/keeper/grpc_query.go (31)
A x/drip/keeper/grpc_query_test.go (259)
A x/drip/keeper/keeper.go (59)
A x/drip/keeper/keeper_test.go (71)
A x/drip/keeper/msg_server.go (65)
A x/drip/keeper/msg_server_test.go (360)
A x/drip/keeper/params.go (31)
A x/drip/module.go (187)
A x/drip/types/codec.go (50)
A x/drip/types/codec_test.go (32)
A x/drip/types/errors.go (14)
A x/drip/types/events.go (11)
A x/drip/types/expected_keepers.go (22)
A x/drip/types/genesis.go (22)
A x/drip/types/genesis.pb.go (544)
A x/drip/types/keys.go (18)
A x/drip/types/msg.go (75)
A x/drip/types/msg_test.go (82)
A x/drip/types/params.go (79)
A x/drip/types/params_test.go (51)
A x/drip/types/query.pb.go (537)
A x/drip/types/query.pb.gw.go (153)
A x/drip/types/tx.pb.go (1003)
A x/drip/types/tx.pb.gw.go (171)

Patch Links:

https://github.com/CosmosContracts/juno/pull/709.patch
https://github.com/CosmosContracts/juno/pull/709.diff

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

@dimiandre I think you should add the contract to this repository

@dimiandre I think you should add the contract to this repository
x/drip/keeper/msg_server_test.go:13:12: pattern testdata/reflect.wasm: no matching files found (typecheck)
//go:embed testdata/reflect.wasm

I still need to rewrite all tests. That's a refuse from feeshare copy paste

@Reecepbcups we good!


Allow for "chaos" interpretation of expressions

Currently, we handle all operations in bit-precise manners, including shifts, adds, memory reads, etc. It might be a good idea, for specifications like "check that registers were correctly saved" to allow leaving some of these operations undefined, replacing them with uninterpreted functions.
This probably can be implemented by simply generalizing the hook mechanism for expressions: https://github.com/draperlaboratory/cbat_tools/blob/7d58dc86de8d6d3edcf72b79735b05cc207d623a/wp/lib/bap_wp/src/environment.mli#L72, say by adding an additional Interp cond_type.

We tried this, in PR #209 but did not observe a significant speedup.


Is it possible to ignore certain tags

I'm trying to exclude the conversion of links and images when converting from markdown to raw. Is there a settings flag I can set to disable it? Or maybe in the remark config?
Thank you for your work, the plugin is really handy

Yes, check out the remarkable config here - https://github.com/jonschlinkert/remarkable under disable 😄 hope that helps!


Avoid atty and bump MSRV to 1.63

This is https://github.com/slog-rs/term/pull/45 with an extra commit bumping the MSRV. I think this is necessary to match is_terminal's MSRV - https://github.com/sunfishcode/is-terminal/blob/main/Cargo.toml#L16.
CI passes on my fork: https://github.com/rkd-msw/term/actions/runs/5714633882

@Techcable , any plans for a 2.10.0 with this fix in?

@Techcable , any plans for a 2.10.0 with this fix in?

@Techcable any update on this?

@dpc Hi, I see you're also listed together with @Techcable as owners. Might either of you please be able to release a new version with this PR integrated so the security warnings can go away for the crates which depend on this? Thank you! ❤

Hi @rkd-msw , @mattledden , @Keavon -- I've released a new version 2.9.1 with this fix included.
I was hoping to include PR #44 , but I realized this was important to get out first.
Please let me know if you need anything else :)

Thank you!


How to update api.yaml and keep main.py route logic?

Let's say I currently have the api.yaml and added route logic to main.py (no longer just "pass"):

# generated by fastapi-codegen:
#   filename:  api.yaml
#   timestamp: 2020-06-14T10:45:22+00:00

from __future__ import annotations

from typing import Optional

from fastapi import FastAPI, Query

from .models import Pets

app = FastAPI(version="1.0.0", title="Swagger Petstore", license="{'name': 'MIT'}",)

@app.get('/pets', response_model=Pets)
def list_pets(limit: Optional[int] = None) -> Pets:
    """
    List all pets
    """
    # Added logic
    return db.pets.get().limit(limit)

I now realize I want to add another search parameter offset so I make the necessary changes in api.yaml and run fastapi-codegen --input api.yaml --output app

The output I receive:
@app.get('/pets', response_model=Pets)
def list_pets(limit: Optional[int] = None, offset: Optional[int] = None) -> Pets:
    """
    List all pets
    """
    pass

Versus the output I would like:
@app.get('/pets', response_model=Pets)
def list_pets(limit: Optional[int] = None, offset: Optional[int] = None) -> Pets:
    """
    List all pets
    """
    # Added logic
    return db.pets.get().limit(limit)

Is it possible to get this behavior?

@ddehueck
Thank you for creating this issue.
if you know the rule then you can resolve the problem by the custom template option  -t, --template-dir
Example template:
https://github.com/koxudaxi/fastapi-code-generator/tree/master/tests/data/custom_template/security

Hi @koxudaxi thanks for the response! I do see I can update the template and add code that will always be a part of the template but I don't think that's quite what I'm looking for.
The rule I have in mind would be: if operation already exists in main.py keep route logic (don't replace with pass) but rebuild function definition. This ways it's easy to add new paths and parameters to an existing file.

I run into the same problem. Oftentimes, the schema is a living thing that we want to evolve, and code generation is a great way to keep the code and schema in sync.


Style customizer: import/export & copy/paste

There's still some minor UI issue to be fixed (the dialog buttons are not in c5 style), but everything should be working.
Preview of these new features:

What about including this PR in concrete5 8.5?

My apologies for not reviewing this sooner – we've been slammed with fixing some other pressing things, and it's easy to let certain updates like this languish. I think it's just too late in the development cycle to get it into 8.5.0. But there will be at least an 8.6.0 (coming much sooner than it took for 8.5.0) that we can get this in.
I've love for some other reviews to come in, too, since this is such a big feature that touches so many files.

I have manually merged this into the 8.6.x-dev branch. It will be available in concrete5 8.6.


Deprecate the tap_common directory and makefile references to tap-v1.

Hello @potaito and @simonegu ,
This PR deprecates the ROMFS/tap_common/ directory per the discussion in PR #10532 and also deprecates all makefile references to tap-v1*.
Please let me know if there are other deletions that should be accomplished within this PR, or if I've deleted anything that should not have been eliminated given the objectives of this PR.
Thanks!
-Mark

You probably need to remove tap-v1 from jenkins :)

https://github.com/PX4/Firmware/pull/10187

Thanks @dagar! I have removed the additional files indicated in your PR.

@dagar, would you be willing to help me with a hint on this CI error?

Hm it's still trying to build tap-v1_default

even though @mcsauder removed it from the jenkins file :confused:

@mcsauder @potaito Jenkins only trusts executing the jenkinsfile from the origin repo. Because your PR is not a branch in the PX4 repo, rather it is from your fork, it will ignore the changes to the Jenkinsfile until merged over.

Thanks @lamping7 , that makes sense.
@potaito or @simonegu , I don't have privileges to push branches up to the repo, would one of you be willing to check out my branch and push up a new branch branch/PR to PX4/Firmware from it?
Let me know what you need from me!

@dagar Ah I did not realize that it's not clear. It's fine to remove everything.

Thanks everyone!


Update dependencies to support doc-gen4

[x] update dependencies to include doc-gen4
[ ] generate stub documentation and point website to it

Will integrate doc gen into CI after we finish writing the first version of the docs

The command lake -R -Kenv=doc build SampCert:docs will build the documentation (it takes a minute) which you can view at .lake/build/doc/index.html (as per the doc-view4 instructions, to see them locally you should use a local webserver in that directory).
I will wait until I understand the CI story to point leanprover.github.io/SampCert/ to a hosted version of these, like Mathlib they should (probably) not be hosted in this repository.


Incorrect default value for cms_label_prefix listed in docs

Describe the bug
The docs state that the default value for cms_label_prefix is netlify-cms/, but it seems to me it is only cms/.

Hi @fkohrt, that value is for PR labels (not branch names prefix). See:
https://github.com/netlify/netlify-cms/pull/3947

Closing the issue. Feel free to comment if you have additional questions

Hi @fkohrt, that value is for PR labels (not branch names prefix). See:
https://github.com/netlify/netlify-cms/pull/3947

Closing the issue. Feel free to comment if you have additional questions

Oops, my bad!

Oops, my bad!


Item Description over ride

Is your feature request related to a problem? Please describe.
Yes... To long of a item in the legend
Describe the solution you'd like
would like a "override" on the description when leveraging metrics mode and selecting all hosts.. The Item should have the ability to make a item show in the legend as a shorter description
Currently it lists Host:Item in my case the Item is pretty long..

You can use replaceAlias() function. See example dashboard Legend overrides.

Also, there's related feature request #619


fix(getTransactionHash): add fee and version to calculation

Description of the Changes
Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.
Checklist

[ ] Changes have been done against master branch, and PR does not conflict
[ ] New unit / functional tests have been added (whenever applicable)
[ ] Test are passing in local environment
[ ] Docs have been updated
[ ] PR title is follow the standard-version convention: <type>(optional subject): <description>, e.g: fix: minor typos in code

This change is

:tada: This PR is included in version 1.0.0-dev.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update README.md

Summary of Changes
Include a summary of changes then remove this line
Tests
What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line
Documentation
What documentation did you add or modify and why? Add any relevant links then remove this line
CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

[ ] PR passes make test

Codecov Report

Merging #146 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   83.26%   83.26%
=======================================
  Files          56       56
  Lines        2791     2791
  Branches      295      295
=======================================
  Hits         2324     2324
  Misses        378      378
  Partials       89       89

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bb9fa4...3e3ab3e. Read the comment docs.

yeap, just didn't create another bitly link. I verify it with inconigdo mode.


IGNITE-16683 Enable jdbc tests

Branch has already been merged to main, according to the comments in the issue. I'm closing the PR.


Web Editor Duplicates User

After following the install instructions everything seems to work just fine. When I use the /lp user info command, it shows assignment into the correct group. When I check the permission info, it shows the correct luckperms.* (wildcarded) permission.
Now when I launch the web editor, the same user is listed twice with double the permissions. So it looks like everything is configured correctly but the web interface is querying and outputting a duplicate row.

Try updating to the latest from https://luckperms.net this issue was fixed (or should've been)

Doh! I just installed the plugin from a hosting repository - didn't see the code was just updated last week. Thanks!


Clearing the Console on the Mac Terminal makes the Flutter Tooling hang

I am on a macOS High Sierra 10.13.3 using the default Terminal.app using zsh. The Flutter tools connect to a remote application on an iOS device when invoked with flutter run. I can interact with the application via the service protocol like normal (for example, a hot-reload with r). Clearing the console makes the tooling hang up and unresponsive to further keystrokes. I used CMD+K on the Mac.

Related: https://github.com/flutter/flutter/pull/50034

If the screen is cleared with CMD+K, then it is not related to that PR. That only has to do with the "c" button clearing Flutter's output.


Split tests in Travis and use Node 6

Would get better logs in Travis. And Node 4 is a bit dated...

Oh, wow, travis had react-create-class cached so tests passed, though we removed this dependency =(... Need to update tests


Document how to manually invalidate cache

Hello, thanks for this code and the great blog post explaining it! This has been very helpful for setting up decent GitHub actions with Conda environments.
I'm wondering if you might be able to explain here, or add to the documentation, the process for manually triggering a new build via the CACHE_NUMBER variable?  That is, how is this variable incremented to invalidate the cache?  Does this require changing the variable value in the workflow script (therefore requiring a new commit), or can it be done externally somehow when running the workflow?  I think the latter might be possible using the repository secret variables, but I might be missing how to do it with the regular environment variables in the workflow as designed.  Thanks!

For instance here's a comment on using secrets: https://github.com/actions/cache/issues/2#issuecomment-673493515.

In the regular environment variable case, yes you'd have to edit the workflow file and make a commit.


Unit and functional test Dev workflow using Saucelabs

Added Github actions workflow for Unit and Functional test using Saucelabs.
Added Saucelabs configuration
Updated browserlist and increased max event emitters on test runner helper.
Created standalone npm script for each browser to create separate GH Actions VM environments to avoid timeouts.

Description
Run unit and functional tests on push.
Related Issue

Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All tests pass and I've made any necessary test changes.
[ ] I've updated the schema in extension.json or no changes are necessary.

@jonsnyder I made the following changes:

Updated browserlist and increased max event emitters on test runner helper.
Created standalone npm script for each browser to create separate GH Actions VM environments to avoid timeouts.


Need to be fixed artifactID before release in Jenkins Artifactory

Description
Need to be fixed artifactID before release in Jenkins Artifactory
GitHub repository: https://github.com/jenkinsci/zos-devops-plugin
Hosting request: https://github.com/jenkins-infra/repository-permissions-updater/issues/2904
Submitter checklist for adding or changing permissions

Always

[x] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[x] Add link to resolved HOSTING issue in description above

For a new permissions file only

[x] Make sure the file is created in permissions/ directory
[x] artifactId (pom.xml) is used for name (permissions YAML file).
[x] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[x] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[ ] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[ ] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[ ] Make sure to @mention the users being added so their GitHub account names are known if they require GitHub merge access (see below).
[ ] All newly added users have logged in to Artifactory and Jira at least once

Reviewer checklist (not for requesters!)

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[ ] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
[ ] If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

The shortName doesn't match this proposal yet, please update it too.
Also, has this plugin been released yet?

Thanks @NotMyFault ! I fixed the short name and also added jenkinsfile for the build.
No, .hpi haven't uploaded yet in Jenkins Artifactory.

I'd recommend you rename the repository and the file here too, to make it easier locating it in the future.

@NotMyFault, I understand your recommendation, but I corrected the name of the packages, removed the hyphen from there and from imports too, because it is undesirable to use it there. Because of this, we had to change the artifactID, but the plugin name and the repository name must be left in their current form - zos-devops-plugin, because. fully conveys its meaning - this plugin is developed and expands the possibilities for z/OS systems.


Pre-antepenultimate controllers review.

With this review I'm down to literally one page of uncommitted code that needs to be fleshed out for animation.controller - the "last step"
However, I fear that the changes here are pretty abstract to you as so far we still haven't seen the target code, which is still in flux...
Let me explain what's going on, just to make sure it's on the record.

Basically, I ripped apart four shoddy classes and made three better ones of them.  Some renaming occurred.
The following explanation is basically true of "before this change" as well as "after this change" but "after" does more of it with fewer weird classes.

Final names are still up for grabs.  Particularly the fact that the base type is Controls so I talk about a Controls is irksome.  (But there are many control items in it... needs to be resolved...)

We're continuing to use the same basic hierarchy - there's an abstract fundamental class Controls that handles incoming data of any type, and emit data of any type...
...but all the interesting Controls we've written so far are ExtractedControls which take an incoming message dictionary msg from the source, a dictionary which may have all sorts of crap in it we don't care about, and extract an OrderedDict omsg with only certain fields in a certain order, normalized.
So the workflow is

msg - "some sort of dict" from the original source (MIDI, keyboard, internet, etc)

for example, for MIDI it is mainly just vars(msg)

-> "extractor" which emits the ordered omsg

this is where you throw away the extra crap and normalize the rest.
An extractor is defined entirely by data.
You can't override any methods on the extractor (this is a positive).  It's very flexible - if you want something else, inherit from Controls.

-> routing

This routes the message to set a specific attribute on the target object
This is where we use the fact that the message dictionary is ordered

We pop off successive elements from the message "from the left side"
e.g. in dict(port='xxx', channel=1, type=control_change, control=2, value=127) it might be matched by xxx.1.control_change.2
you can use omit to drop some parts - by default omit is port and channel, so the last one would be matched then by control_change.2

blah blah blah
BTW, we don't really have to use OrderedDict, which isn't totally cheap.  We could be passing around tuples or lists instead with almost exactly the same logic - we'd just have to keep the naming information elsewhere and we only use that in one place - but as far as the base logic goes, the omsg is just a list.
I plan to do that later, but OrderedDict is really convenient for right now.
On the other hand, this sort of information is likely coming in at a comparatively slow rate - say 100Hz at the most.  The cost of building 100 OrderedDicts a second isn't worth losing sleep over.

Ah, and one more comment.  :-D
Basically, the way I wrote this was to make it really slick for MIDI (which is pretty generic as interfaces go), and then saw what it did to keyboard.
Well, I think it ended up being really clear - both the control adaptor and the demo client code are about as small and clear as you could really imagine.
And actually - I will be able to make it a littel smaller.  :-o
I really don't need the extractor at all, so in the end stage I'll just make this a Source!


Mapping host-specific reads

Hi there,
I apologise if this is not applicable to the Issues section. My group and I are currently using the metagenomics pipeline for Illumina sequencing on CZ ID. We mainly work with wildlife specimens in resource-scarce settings and CZ ID is proving fantastic. My issue is trying to include host-specific reads into the final output. At the beginning of the workflow I state that the host is unknown but I still do not get any reads mapping to potential hosts (the most recently data I uploaded originated from wild Lemniscomys and Mastomys mice).
Is there a solution or something I could change in the parameters? Or the pipeline is exclusively designed towards potential pathogens with no read mapping against non-human host genomes?
Thank you so much and looking forward to your reply.
Stefano

Hi Stefano, you would probably get a better answer by emailing<EMAIL_ADDRESS>Thanks!


Failed to store branch

i'm use seata version with 0.9.0
io.seata.core.exception.RmTransactionException: Response[ TransactionException[Failed to store branch xid = <IP_ADDRESS>:8091:2025768540 branchId =<PHONE_NUMBER>] ]

can you provide seata-server log.

I suspect that the lockKey is too long.

@jsbxyyx Has been verified, it is indeed because the lockKey is too long

https://github.com/seata/seata/issues/1904


preference loss sign is inverted and leads to negative loss

Summary
In testing cases where there is no alpha/NLL loss used, the loss becomes negative, which is probably not the intended behavior. see https://github.com/huggingface/trl/blob/main/trl/trainer/dpo_trainer.py#L1234

Hardware Type:
[ ] run make test to ensure correctness
[ ] run make checkstyle to ensure code style
[ ] run make test-convergence to ensure convergence

I believe the issue lies here: https://github.com/linkedin/Liger-Kernel/blob/0bb6c72d03f0fc570b9e954c42b723ab7e0c315f/test/utils.py#L514.


suggestion

please add free tx/rx massage for using at emergency

Arbitrary text tx/rx has been released with v0.83


refactor: use tracing's structured logging

#4143
Semi-automated with  https://github.com/aatifsyed/synsert/blob/5f7d39c1ff1ae47d2b028b045378197036a71fa1/examples/tracing.rs
Change checklist

[x] I have performed a self-review of my own code,
[ ] I have made corresponding changes to the documentation,
[ ] I have added tests that prove my fix is effective or that my feature works (if possible),
[ ] I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

$ git diff main | cat | rg '@@' | wc -l
182

So many call sites

I'll look into tracing docs and get back to you here.

@aatifsyed what do we do with this draft?