[Issue report] chromiumos_image_r86r1-rpi4b not work HDMI audio on RPi4, but fixed

Describe the bug or issue
chromiumos_image_r86r1-rpi4b not work HDMI audio on RPi4
But, I tried to change cmdlist.txt, then worked HDMI audio
Describe your setup

RPi 4B with 8GB RAM
chromiumos_image_r86r1-rpi4b

To Reproduce
I add string "snd_bcm2835.enable_compat_alsa=1" to cmdlist.txt.

chronos@localhost ~ $ sudo mount /dev/mmcblk0p12 /mnt
chronos@localhost ~ $ cat /mnt/cmdline.txt
coherent_pool=6M smsc95xx.turbo_mode=N dwc_otg.lpm_enable=0 console=serial0,115200 earlyprintk=serial0,115200 log_level=7 root=/dev/mmcblk0p3 rootfstype=ext2 rootwait ro cros_debug cros_secure elevator=deadline snd_bcm2835.enable_compat_alsa=1
chronos@localhost ~ $

But worked only left microHDMI.

Same happened with me. Just flashed that build today, and no sound on HDMI, only analog output works. Where can I find cmdlist.txt?

cmdlist.txt was found on mmcblk0p12 partition.
But this partition not mount.

login
Ctrl-Alt-T open a shell tab
type "shell" to run bash
mount EFI partition, "sudo mount /dev/mmcblk0p12 /mnt"
backup old cmdlist.txt, "sudo cp /mnt/cmdlist.txt"
edit cmdlist.txt "sudo vi /mnt/cmdlist.txt"

how to check audio device.
on bash shell.
execute "aplay -l"
chronos@localhost ~ $ aplay -l
**** List of PLAYBACK Hardware Devices ****
card 0: ALSA [bcm2835 ALSA], device 0: bcm2835 ALSA [bcm2835 ALSA]
  Subdevices: 3/3
  Subdevice #0: subdevice #0
  Subdevice #1: subdevice #1
  Subdevice #2: subdevice #2
card 0: ALSA [bcm2835 ALSA], device 1: bcm2835 IEC958/HDMI [bcm2835 IEC958/HDMI]
  Subdevices: 1/1
  Subdevice #0: subdevice #0
card 0: ALSA [bcm2835 ALSA], device 2: bcm2835 IEC958/HDMI1 [bcm2835 IEC958/HDMI1]
  Subdevices: 1/1
  Subdevice #0: subdevice #0
card 1: b1 [bcm2835 HDMI 1], device 0: bcm2835 HDMI 1 [bcm2835 HDMI 1]
  Subdevices: 2/2
  Subdevice #0: subdevice #0
  Subdevice #1: subdevice #1
card 2: Headphones [bcm2835 Headphones], device 0: bcm2835 Headphones [bcm2835 Headphones]
  Subdevices: 2/2
  Subdevice #0: subdevice #0
  Subdevice #1: subdevice #1
chronos@localhost ~ $

My environment , left microHDMI is "card1, device0"
play sound file, "aplay sound.wav -D hw:1,0"
chronos@localhost ~ $ aplay Downloads/dq.wav -D hw:1,0
Playing WAVE 'Downloads/dq.wav' : Unsigned 8 bit, Rate 11025 Hz, Mono
chronos@localhost ~ $

If you use headphone output, "aplay sound.wav -D hw:2,0"

I have tried, but not works.
Could anyone help me？

It looks your modify cmdlist.txt was failed.
my cmdlist.txt is follows
coherent_pool=6M smsc95xx.turbo_mode=N dwc_otg.lpm_enable=0 console=serial0,115200 earlyprintk=serial0,115200 log_level=7 root=/dev/mmcblk0p3 rootfstype=ext2 rootwait ro cros_debug cros_secure elevator=deadline snd_bcm2835.enable_compat_alsa=1

I am so confused by cmdlist.txt or cmdline.txt.

sorry, it's typo. filename is cmdline.txt

this seems to work

chromiumos_image_r86r2-rpi4b worked fine on left microHDMI port.
right microHDMI port is video only,


Add data validation with pandera for data pipeline

Create a validation step for the following data sources:

calendar
betting
defense
injury
players
projections
salary
weather
stats

completed data validation step. d1a3fac78941cda6856d5d5b88cdcb18a16c4371


Typescript error TS1209: Ambient const enums are not allowed when the '--isolatedModules' flag is provided

Issue Summary
Hello,
I initially opened an issue on the fast-reflexes/better-react-mathjax and I was redirected here.
Here's my problem:
When running a type-check, I have the aforementioned type error with the DIRECTION enum in FontData.d.ts.
The error is resolved by changing the declaration from declare const enum to declare enum
My TypeScript version is 4.7.4, with the isolatedModules flag activated.
Steps to Reproduce:

Having a typescript project with the isolatedModules, my version of TS is 4.7.4
Having mathjax as a dependency. In my case, I had fast-reflexes/better-react-mathjax, which relies on mathjax
run a typecheck

Here's an explanation from the typescript documentation about why ambient const enums are not compatible with the isolatedModules flag
Technical details:

MathJax Version: 3.2.2
TS version: 4.7.4

Thanks for the report.  I'll look into the effects of making that change, and whether to dump the enum entirely in favor of a constant object instead (would make it more consistent with other constants in MathJax).


Add upper version bound to readme pip install instructions

Our notebooks (for colabfold) just broke due to the release of jax 0.3.0. This pull requests adds upper version bounds to the readme pip install instructions to avoid downstream breakage through new jax releases

Thanks for reaching out! And sorry for the breakage. (Was it due to using JAX internal symbols/APIs?)
But I don't understand the reasoning behind this PR: if you want to pin your project to tested JAX versions, why would that mean changing the JAX install instructions? Perhaps instead the change should be in the ColabFold README.md's install instructions? That is, maybe the CoalbFold README should say something like pip install --upgrade "jax[cuda]==<version> ..."?


你好，请问有训练的相关代码吗？

We have the training codes and will release them soon. Currently, I am busy and working on the NSFC application. You may come back one month later to check the codes. If the codes still are unavailable, please remind me to release them.

Thank you for your speedy response.
Hope you are doing well.

Hello，i have run the code in the test folder, but it show me "ImportError: cannot import name 'ChannelGroupConv' from 'PCONV_operator' ". Whether some code don't upload to github?


HERE’S!!* WAY TO WATCH Aston Villa vs Brighton LIVE 𝐒𝐭𝐫𝐞𝐚𝐦𝐬 Free ON TV CHANNEL 30 december 2024

01 minutes ago — Aston Villa vs Brighton LIVE: Premier League team news with Marcus Rashford set to return to squad
Aston Villa vs Brighton LIVE: Premier League team news with Marcus Rashford set to return to squad
Ruben Amorim is looking for his third win in the league since taking over in November
Aston Villa host Brighton United in the Premier League this evening, with the home side desperate for three points as they look to rise from 14th in the table.
Ruben Amorim’s team has fallen to embarrassing defeats to Bournemouth and Wolves over the last two matches, and the Portuguese has just two wins in the league so far during his tenure.
And United face a Brighton side who have found form in recent weeks, with consecutive 4-0 wins followed by a 3-0 victory over Aston Villa last time out.
After a mixed start to the season, the Magpies find themselves in seventh ahead of kick-off, with the potential to move into fifth if they grab three points tonight.
And with the recent form of both sides, Brighton have rarely had a better chance to earn a first league win at Old Trafford since 2013.
Predicted line-ups
Man Utd XI: Onana; Mazraoui, Yoro, Maguire, Martinez, Dalot; Mainoo, Casemiro; Garnacho, Diallo; Hojlund.
Brighton XI: Dubravka; Trippier, Schar, Burn, Hall; Tonali, Guimaraes, Joelinton; Gordon, Murphy, Isak.
Aston Villa host Brighton United in the Premier League this evening, with the home side desperate for three points as they look to rise from 14th in the table.
Ruben Amorim’s team has fallen to embarrassing defeats to Bournemouth and Wolves over the last two matches, and the Portuguese has just two wins in the league so far during his tenure.
And United face a Brighton side who have found form in recent weeks, with consecutive 4-0 wins followed by a 3-0 victory over Aston Villa last time out.
After a mixed start to the season, the Magpies find themselves in seventh ahead of kick-off, with the potential to move into fifth if they grab three points tonight.
And with the recent form of both sides, Brighton have rarely had a better chance to earn a first league win at Old Trafford since 2013.
Aston Villa vs Brighton LIVE - early team news, how to watch and kick-off time
Live updates from Old Trafford as Man United take on Brighton United in their final game of 2024.
Aston Villa will be hoping to halt a run of three successive defeats when they welcome Brighton United to Old Trafford in the Premier League this evening, kick-off 8pm.
United, who have lost three of their last four clashes with the Magpies, suffered a third defeat in the space of just eight days on Boxing Day, losing 2-0 to Wolves at Molineux.
United, as a result, find themselves 14th in the table ahead of tonight's game, meaning they are now closer to the bottom three than the Champions League qualification places.
In a bid to avoid being sucked even closer towards the relegation battle, Ruben Amorim's troops will have to get the better of a Brighton side that will arrive in M16 in sparkling form having won each of their last four matches across all competitions. They beat Aston Villa 3-0 on Boxing Day.
Isak is the one to watch
It goes without saying that United need to keep a very close eye on Brighton striker Alexander Isak this evening.
The Swede heads into tonight's game in red-hot form, scoring seven goals in his last five Premier League matches.
He has 11 league goals so far this season and nine of them have been plundered since the start of November. Furthermore, he has scored in eight of his last 10 league outings.
Aston Villa vs Brighton – LIVE!
Man Utd today host Brighton in their final Premier League of 2024. It has been a mixed year for the Red Devils, who have largely laboured despite winning the FA Cup earlier this summer. Indeed, new manager Ruben Amorim is struggling to turn the season around and has lost his last two Premier League games in charge of the club.
While it would be foolish to suggest the United boss is under any kind of pressure as things stand, there is little doubt it’s not quite working out just yet. Now, they meet a Brighton side bang in form and one who look capable of challenging for Champions League qualification once more.
OLD TRAFFORD, MANCHESTER — Aston Villa will seek to end a turbulent 2024 on a positive note when they host Brighton in the Premier League.
The Red Devils beat rivals Manchester City to lift the FA Cup in May but poor Premier League form either side of that saw Erik ten Hag pay with his job.
Ten Hag's successor Ruben Amorim warned of a hard road ahead and so it has proved, with United losing five of their past seven games across all competitions and conceding 16 goals in the process.
By contrast, Brighton have hit a rich vein of form, winning three Premier League games in succession with star striker Alexander Isak scoring five of their 10 goals during the ongoing streak.
Things could get worse before they get better for Aston Villa and Ruben Amorim, who welcome in-form Brighton United to Old Trafford for their final Premier League game of 2024.
The Red Devils have endured a disappointing festive period – exiting the Carabao Cup at the hands of Tottenham, losing 3-0 at home to Bournemouth, and then suffering a 2-0 defeat to lowly Wolves on Boxing Day to drop to 14th. To add insult to injury, Man Utd will be without captain and chief creator Bruno Fernandes after his sending off at Molineux.
Amorim has suggested his side "just need to survive" at the start of what he believes will be a "long journey" and there is more danger to come. They start 2025 with trips to Liverpool, in the Premier League, and Arsenal, in the FA Cup, but up first is the visit of Brighton on Monday night.

bgf
✅🟢 STREAM PLAY NOW ▶
✅🟢 PLAY NOW ONLINE

.
✅🟢 STREAM PLAY NOW ▶
✅🟢 PLAY NOW ONLINE
xswq


Generated Python 3 modules has syntax errors, causing a fall back to Python 2 modules

I'm assuming recent changes have made the code generator output two versions of the code, one for Python 2 and another for Python 3.
However, the Python 3 generated code contains a recurring pattern where a parent class's init method is called with a malformed parameter list starting with a comma (__init__(, arg1, arg2, etc), causing a syntax error. Here are some examples:
https://github.com/Azure/azure-sdk-for-python/blob/72d71b30af36e65b333e2225ce8732afa53a4ec4/azure-mgmt-monitor/azure/mgmt/monitor/models/rule_email_action_py3.py#L43
https://github.com/Azure/azure-sdk-for-python/blob/72d71b30af36e65b333e2225ce8732afa53a4ec4/azure-mgmt-monitor/azure/mgmt/monitor/models/rule_webhook_action_py3.py#L42
https://github.com/Azure/azure-sdk-for-python/blob/72d71b30af36e65b333e2225ce8732afa53a4ec4/azure-mgmt-monitor/azure/mgmt/monitor/models/diagnostic_settings_category_resource_py3.py#L46
The __init__ module of azure.mgmt.monitor.models uses a massive try/except block to import all the _py3 modules, and if a SyntaxError or ImportError is caught it imports the Python 2 modules instead.
I'm not privy to how the code generator works and may be missing something, but IMO a cleaner way to test the version of Python IMO would be to use an if statement like import sys; if sys.version[0] >= '3': instead of the try / except. That way automated testing could ensure that no import errors or syntax errors occur at all.
On a different note it's a pleasant surprise to see a major cloud provider supporting Python 3 type annotations in its SDK. :)

Hi @TimSimpsonR
I noticed that this morning as well :(. I'm on it, this has to be fixed asap.
PS: I wanted annotations for a while :). And async/await is coming ;)

Fix in progress:
https://github.com/Azure/autorest.python/pull/54

Released on PyPI, thanks for the report!


Allow to store in notes unicode, like cyrillic

bug / improvement
Allow to store in notes unicode, like cyrillic, et cetera

@volandku Thanks for your PR!
Does the string not get escaped correctly / what output do you get?
What version of PHP are you using?
json_decode should restore any saved string correctly.

@volandku Just pinging again here to ask what exactly isn't working.
If something is off, would be great to have this fixed in the next release :muscle:

Well, I dont remenber for now ))
Seems that result in cyrillic didn`t store at all or stored in wrong format in DB

@volandku Ok, thanks for getting back to me.
I'll close this off for now, as I can't reproduce this, but please do open it again with some example code if it happens again to you! :smiley:


[FEATURE REQUEST] Ability to include previous budgets in reports

Is your feature request related to a problem? Please describe.
Not related to a current problem
Describe the solution you'd like
Add an additional filter in reports that allows you to select and view previous budgets that have been archived after a fresh start along with your current/active budget.  This would allow a more fluid view of data for those that like to complete a fresh start at the beginning of every year.
Describe alternatives you've considered
Currently you have to switch between budgets to view reports for that specific budget
Additional context
I see this working primarily in the Net worth report, but could work in income/expense as well. Any new or unused accounts and categories would just be blank as they are now

We use Trello to track Feature Requests so that users can vote on what they'd like to see next. This is crucial for us since there are so many requests and so little time amongst those of us who work on the Toolkit.
Your feature request has been added here and will need to be manually sorted.
This issue can now be closed.


google drive refused to connect

When i try to open the addon in google docs it shows a little side window showing a grey screen saying, 'drive.google.com refused to connect'.

full code on the image is located here

This is a known issue for Google add-ons when you're logged in to multiple Google accounts. See this troubleshooting item in our docs: https://github.com/evbacher/gd2md-html/wiki#drivegooglecom-refused-to-connect


[SEO] Add meta tags

This PR adds some meta tags for SEO purposes.

Looks great, two minor fixes then I'm happy for this to be merged 🚀

Thanks, @jhancock532. I've addressed your comments. Let me know if you're happy with the changes.


No styles in the editor

It doesn't even seem to generate html tags, like  or , almost seems like the buttons just do nothing

what buttons do you mean?

It doesn't even seem to generate html tags, like
or , almost seems like the buttons just do nothing

HTML tags will be generated in cms response. Look at this picture:

what buttons do you mean?

Clicking those does nothing.
It should be generating a  tag with a class of bold, or just  (not sure which one). It does not do that

Yes, this version support only formulas...

if your configuration is not supposed to support those features (for whatever reason), why are the buttons for them added to the build?

Good question, yes ) in next version it is been fiixed

When will the next version be made? Thanks

I'll let you know


Problems to get relationships from vmware

vcenter 6
Manageiq Euwe-1
I was able to add my vmware into my manageiq, but I receive no data to "relationships".
Error - 7 Minutes Ago
undefined method `name' for nil:NilClass

[----] E, [2017-02-15T10:59:39.523950 #2763:d27134] ERROR -- : MIQ(ManageIQ::Providers::Vmware::InfraManager::Refresher#refresh) EMS: [Vcenter], id: [1] Refresh failed
[----] E, [2017-02-15T10:59:39.524145 #2763:d27134] ERROR -- : [NoMethodError]: undefined method `name' for nil:NilClass  Method:[rescue in block in refresh]
[----] E, [2017-02-15T10:59:39.524220 #2763:d27134] ERROR -- : (druby://<IP_ADDRESS>:42705) /var/www/miq/vmdb/gems/pending/VMwareWebService/MiqVimInventory.rb:2350:in `block (2 levels) in getMoPropMulti'
[----] E, [2017-02-15T10:59:39.524289 #2763:d27134] ERROR -- : MIQ(ManageIQ::Providers::Vmware::InfraManager::Refresher#refresh) EMS: [Vcenter], id: [1] Unable to perform refresh for the following targets:
[----] E, [2017-02-15T10:59:39.524374 #2763:d27134] ERROR -- : MIQ(ManageIQ::Providers::Vmware::InfraManager::Refresher#refresh)  --- ManageIQ::Providers::Vmware::InfraManager [Vcenter] id [1]
[----] E, [2017-02-15T10:59:39.542708 #2763:d27134] ERROR -- : MIQ(MiqQueue#deliver) Message id: [1901], Error: [undefined method `name' for nil:NilClass]
[----] E, [2017-02-15T10:59:39.542882 #2763:d27134] ERROR -- : [EmsRefresh::Refreshers::EmsRefresherMixin::PartialRefreshError]: undefined method `name' for nil:NilClass  Method:[rescue in deliver]
[----] E, [2017-02-15T10:59:39.543031 #2763:d27134] ERROR -- : /var/www/miq/vmdb/app/models/ems_refresh/refreshers/ems_refresher_mixin.rb:50:in `refresh'

Double checked my user permissions in vcenter and seems to be ok. I also tested in the previous version(darga) and everything works fine.
Any clues?
Thanks

@albertocrj this sounds like the issue fixed here https://github.com/ManageIQ/manageiq/pull/13706
Can you try the euwe branch or cherry-pick https://github.com/ManageIQ/manageiq/commit/6f261f425c79661370e8a411ea1eb1fb998c055d and see if that fixes your issue?

@agrare You're right, I tried the lastest euwe version and the problem seems to be fixed.
I think that you can go ahead and close this issue.

Awesome thanks for confirming @albertocrj !

@albertocrj FYI this is now in euwe-2 that was recently released http://manageiq.org/blog/2017/03/Announcing-Euwe-2/


Map asset names to owner address

It would be a nice feature to be able to type an asset name into the address input box and have freewallet automatically lookup the asset owner address and populate the field with the address.
ie... I type in JDOG in the address slot and it is automatically changed to 1Lfm6jXgCQi8LvjpgFHa2F4hdr1uJVa5t4

added this feature at some point


Clojure Language Support

Thanks for the contributions to the opensource community. Are you planning a clojure support for vert.x in the future? If no, why not?

@timur-han it is not planned at the moment because there is no contributor otherwise it would be welcomed


Broken HTTPS on https://reactjs.org

I'm currently seeing an security certificate error on https://redux.js.org in Google Chrome Version 60.0.3112.113.

(edit: incorrect url)

The docs site doesn't work in HTTPS. It's hosted by GitHub, so they don't have a cert for js.org.

@timdorr JS.ORG is using Cloudflare and they provide "Universal SSL" - so it is easily possible to get HTTPS.
Back then when the "redux" subdomain was added to JS.ORG, SSL support was an opt-in. But you didn't took the option. Now it is the default, but owners of "old" subdomains have to make a PR to change it.
The reason for so little enforcement is that pages may show mixed-content warnings if e. g. paths to CSS  where set absolute or other non-HTTPS content was included.
So switching would be easy but it has to be triggered by you. Just file a PR that removes the comment in that line
I'm writing to you because @jlebensold asked me on twitter why you don't have HTTPS

Hmm, looks like we also need to update that URL, since the rackt org (since disbanded) has been typosquated. Thanks for the heads up!


Atom is lossing contributions and users due to third-party Electron-based IDEs

I think that the existence of third-party IDEs based on Electron is killing Atom, because they are improving many things that later don't get implemented into Atom. Wouldn't be great to have a only IDE with all the improvements?
I think that doing rebrandings of Atom to add some functionality is not as great as some development teams (cough MS) can think. Maybe would be better to join all the efforts here?
The only doubt I have is: Is my issue on-topic? I post here because there isn't Gitter account on the Atom repository.

This kind of feedback is probably best on Discuss, the official Atom message board. In my opinion, this is a discussion around "what is the meaning of open source"? And I'm not sure that can be answered in a concrete fashion. Issues is generally best for questions that can be solved or answered ... and I'm pretty sure a lot of these other efforts just aren't under Atom's control :grinning:
Let me know if I'm not understanding and thanks so much for caring about Atom! :green_heart:

@lee-dohm: Sorry, I didn't knew the existence of Discuss. I'll use it.
You're right, really, this isn't a just solve it issue. Also, this has nothing (or so few) to do with atom. However would be great to hare dev feedback.
You understood very well. About caring about atom... Really I simply said what I think, I'm new to Atom and I haven't so much experience as developer nor as GitHub user.
Thank you!
Message for all the paranoid users here: I approve the closing of this issue.

I'm new to Atom and I haven't so much experience as developer nor as GitHub user.

Welcome to Atom and GitHub! Let me know if there is anything that I can do to help :grinning:

@lee-dohm: Here nothing, among other things, because would turn this more off-topic yet. However I'm sure that we will meet again on Discuss.
Thank you very much! :smile:


Geofenceapi.org integration

Here's my first crack at integrating with GeofenceAPI.org.
The idea here is that someone who's creating a GeoJSON document can import their work directly into GeofenceAPI.org in just one step.

I have intentionally only done a small amount of work here to demonstrate the integration and solicit feedback.
@tmcw in reference to https://github.com/mapbox/geojson.io/issues/526

besides the inline comment about unused vars, this looks pretty good!

@tmcw Per your comment, I just removed what i think are more unused lines via https://github.com/mapbox/geojson.io/pull/527/commits/3be77a9e08587cd7c7b0ce4d06856d116caf7a66
On my end, as I move forward, I will "harden" the landing page I created today unit & integration tests and also streamline the user's experience one they land.
At this stage, I will commit to being extremely careful to keep it working and available via my chatroom tool and/or github if someone reports a glitch.
What else can I provide to you in advance of us merging & deploying?

It's ready @tmcw

👍 merging, thanks!

🎉

@tmcw I'm shutting the service down since it hasn't proven viable to keep running. I tried to create a revert but GH prevented it. Let's knock the link out for Geofenceapi.


Updated the Source Code and Configuration Management page to reflect the change set packaging approach

@raghumark123 Let's add a few more details as per our chat

I have updated as per our latest conversation. Please review.


Schedule Patching operations added

Schedule Patching operations added

Hi @SiddharthChatrolaMs, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (sichatro). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@SiddharthChatrolaMs Could you please squash all commits into one? We are trying to move to a model where there is one commit per check in.

Could you please squash all commits into one? We are trying to move to a model where there is one commit per check in.
This time it will be harder. Is it ok to do it from next time onwards?

@SiddharthChatrolaMs Please update project.json per the latest in the AutoRest branch

@azuresdkci retest this please

@markcowl: Done. Please merge now.


A bug due to missing lock release

The lock impl->lock is missed to release at Line 492, should it be a bug?
https://github.com/awslabs/aws-c-common/blob/1143dd566748e3d30f301d592911a2743205420c/source/logging.c#L489-L495

Yes

This should be fixed now.


Check all axiomatisation relations in  FBbt-edit and FBb_ext files is in RO

[ ] Check axioms in fbbt files against RO and move anything missing to RO.
[ ] Remove all axioms except old style OBO ID + xref mappings

NOTE - This is really necessary to clean up pipeline, but could potentially cause headaches for loading to FlyBase....  even though (AFAIK) relations axioms loaded in FlyBase are completely unused.

I think this is all done now


Wording of alias_info_popup tip RELENG_2_2

I noticed this while comparing alias popup behavior between 2.2.5-DEVELOPMENT and 2.3
Might as well fix the grammar here for 2.2.5
This tip does not exist in 2.3 because the popup works more nicely there and so this text is not needed.
Therefore this change does not need to be ported forward to master.

merged, thanks!


OSD-18595 don't delete the cluster private domain zone on cleanup

Check to see if the custom domain is the same as the cluster's private domain and if so, only delete the vpce's custom domain record (not the entire zone)

Codecov Report

Merging #217 (c798b57) into main (dd64056) will increase coverage by 1.63%.
Report is 3 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   38.72%   40.35%   +1.63%
==========================================
  Files          31       25       -6
  Lines        1986     1866     -120
==========================================
- Hits          769      753      -16
+ Misses       1125     1021     -104
  Partials       92       92

Files
Coverage Δ

controllers/vpcendpoint/cleanup.go
11.00% <0.00%> (-1.24%)
:arrow_down:

... and 6 files with indirect coverage changes

/lgtm

/retest
/lgtm


fix(pinia): passing getters on inspectorStateUpdated

fix: #121
Deserialize the getters from Pinia's inspector-state:send payload.
to be:
https://github.com/vuejs/devtools-next/assets/22590005/c7ff849d-eb51-4249-9d3a-3930468b4fdc

Thanks.


Quality Assurance: Message popover doesn't exit after scrolling.

Reproduction
Press the down chevron button of a message, opening up the message popover and then scroll up or down. The message popover doesn't exit.
E.g. The popover doesn't belong to (no topic) but rather lorem ipsum.

Fixed!


Prepare for 1.0.0

Documentation

[x] Project has a LICENSE file with an open source license
[x] Project has basic documentation (CHANGELOG, README, CONTRIBUTING, CODE_OF_CONDUCT, usage and examples)
[x] The name is easy to remember, gives some idea of what the project does, and does not conflict with an existing project or infringe on trademarks
[x] The issue queue is up-to-date, with issues clearly organized and labeled

Code

[x] Project uses consistent code conventions and clear function/method/variable names
[x] The code is clearly commented, documenting intentions and edge cases
[x] There are no sensitive materials in the revision history, issues, or pull requests (for example, passwords or other non-public information)
[x] Use of SemVer, CHANGELOG standards
[x] Automated tests

People

[x] Someone is committed to managing community interactions (responding to issues, reviewing and merging pull requests)
[x] At least two people have administrative access to the project

Closing this as I will always keep an eye on this repo. But I have some ideas on how to get other people involved in all the other repos as well. Remind me next week. ;)


Adds the portuguese language without region

I added the portuguese translation, also tested on my project it worked.
First I have added with region BR which is the current translation, but to follow the project current pattern I removed the region resulting on version-pt instead of version-pt-rBR.
I commited to the master because I don't know this project patterns.
Thanks.

@Hodes Thanks for your new language.
npm 1.4.6 already published.


Handle role-based ghost joins/leavs

When people get a role in a discord guild other rooms are visible for them. Joing / leaving a ghost in a matrix room based on that doesn't seem to be handled currently

merged


Add invalid feedback for collection version description

Why was this change made?
Fixes #1574
How was this change tested?

Which documentation and/or configurations were updated?

thanks for the screen shot!


Rename everything... :) gui:: -> sfw::, gui::Main -> sfw::GUI, GUI.hpp -> Main.hpp, ...

Also Cross -> CheckMark (#18), if I'm at it...

Hmm. Did not swap the names of the two top-level headers, as I really like (the perfect) #include "sfw/GUI.hpp" the way it is now... (In fact, the entire product should be rebranded to sfw::GUI now...)
And I also really like the main object now being called sfw::GUI (instead of the old gui::Main)...
Which precludes calling the GUI object's sources GUI.hpp/.cpp, unfortunately...
The saving grace is that it pretty much never needs to be included explicitly anyway.


Duplicate event: EurekaInstanceCanceledEvent

Describe the bug
An application that actively unregisters from eureka fires EurekaInstanceCanceledEvent twice.

The REST endpoint for unregister is executed. The first event is fired, as handleCancelation was added directly to the overridden cancel method. The original cancel method delegates to internalCancel which again was overridden by spring and handleCancelation was added there too.
I think it should be save to remove the overridden cancel method and only keep internalCancel.
WDYT?

is it causing a problem?

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

is it causing a problem?

You can workaround the duplicated event using an own collection to track the active instances.
But it's not nice, that the event is fired twice.

After tracking it, it appears to be a duplicate event caused by #1376.

https://github.com/spring-cloud/spring-cloud-netflix/issues/1376

I think this could be done with one of cancel and internalCancel removed.
(Perhaps cancel?)
WDYT? 🤔


Feature request: support for Map

Can the property, get, and set methods for object variables be extended to work for Map data structures?
let selection = new Variable(new Map())

// User selects the `false` value
selection.set(false, true)

selection.get(false)
// -> true

So I think the way we would do this is when we get or set properties, if
the target value/ object has a get and set, we would use them instead
of direct property access within a variable. (Basically duck -typing). I
think that seems very reasonable,I will go ahead and add that.
On Apr 5, 2016 11:18 AM, "Kevin Crawford"<EMAIL_ADDRESS>wrote:

Can the property, get, and set methods for object variables be extended
to work for Map data structures?
let selection = new Variable(new Map())
// User selects the false valueselection.set(false, true)
selection.get(false)// -> true
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/kriszyp/alkali/issues/5

I am not entirely sure this fix is the best way, since we are actually producing different behavior for determining what keys result in different property children variables. This fix bases this on the object type, but that could change. It might be preferable to actually have a separate constructor for this behavior, but this should work for the case of directly adding a Map on instantiation.


Better hash algorithm in FingerprintTrustManagerFactory

FingerprintTrustManagerFactory checks if a certificate is trusted by comparing its SHA-1 hash to a list of pre-configured ones:
https://github.com/netty/netty/blob/0cde4d9cb4d19ddc0ecafc5be7c5f7c781a1f6e9/handler/src/main/java/io/netty/handler/ssl/util/FingerprintTrustManagerFactory.java#L85
Unfortunately, nowadays SHA-1 is considered insecure. The issue was reported by LGTM.
I see the following ways to fix it:

Update FingerprintTrustManagerFactory to use a stronger algorithm such as SHA-512. Unfortunately, most likely it'll break applications that pass a SHA-1 hash to the class.
Deprecate FingerprintTrustManagerFactory and add a new implementation that use a stronger algorithm.
Updated FingerprintTrustManagerFactory to determine a hash algorithm based on a length of a hash passed to the constructor. If a caller passes a SHA-1 hash, the class can also print a warning.

Please let me know if one of the options above is fine (or, you see a better option), and I'll open a pull request.

SHA-512 is an overkill and not useful for this purpose. SHA-256 or SHA-384 is the way to go.

@trustin @normanmaurer What do you think?

As far as I understand how FingerprintTrustManagerFactory is meant to be used, I think it's better to deprecate it, and add a new implementation that uses a stronger hash function, or allow the hash function to be configured. Maybe the configurable implementation can be extracted into a new super-class of FingerprintTrustManagerFactory.

I agree with @chrisvest here...

I don't see a reason to introduce a new TrustManagerFactory implementation class. We could deprecate the public constructors in favor of builders and static factory methods. e.g.
FingerprintTrustManagerFactory f =
  FingerprintTrustManagerFactory
    .builder("SHA256") // Always require the algorithm name
    .fingerprint("deadbeef...")
    .fingerprint("cafecafe...")
    .build();

The public constructors could call the internal constructor that passes the message digest function, e.g.
@Deprecated
public FingerprintTrustManagerFactory(String... fingerprints) {
    this(FingerprintTrustManagerFactory::sha1Fingerprint, fingerprints);
}

// Called by the builder or the legacy public constructors.
// The example uses Java 8 Function but we can define a dedicated interface if necessary.
FingerprintTrustManagerFactory(
    Function<? super X509Certificate, byte[]> fingerprintFunc,
    String... fingerprints) {
    ...
}

We could also consider implementing more versatile TrustManagerFactory by extracting the verification logic out of the TrustManagerFactory, e.g.
SomeTrustManagerFactory
  .builder()
  .add(CertificateMatchers.fingerprint("SHA256", "deadbeef..."))
  .add("bar.foo.com", CertificateMatchers.strict())
  .add("*.foo.com", CertificateMatchers.any());
  .build();

I like the idea with a builder and deprecating only the public constructor suggested by @trustin
FingerprintTrustManagerFactory f =
  FingerprintTrustManagerFactory
    .builder("SHA256") // Always require the algorithm name
    .fingerprint("deadbeef...")
    .fingerprint("cafecafe...")
    .build();

If no objections, I'll implement this logic then.


docs: add See also for description of pause and unpause

make them reference to each other.
Signed-off-by: Chen Hanxiao<EMAIL_ADDRESS>

LGTM - @fredlf @jamtur01

LGTM


Error with 'true' and True

Problem when access /admin/auth/user/
Error:
File "/usr/local/lib/python3.10/site-packages/django/contrib/admin/templatetags/admin_list.py", line 182, in _boolean_icon     "admin/img/icon-%s.svg" % {True: "yes", False: "no", None: "unknown"}[field_val] KeyError: 'true'
Same problem occurs on /admin/password_change/
ValidationError at /admin/password_change/ ['“true” value must be either True or False.']

Hey @dsin thanks for reporting this, i've fixed the issue on the latest (v0.0.7) version.
I recommend you start a database from scratch with the new version, otherwise you will need to go on to your D1 database and update all boolean fields to be small ints.
For example in that change password case, you need to open your auth_user table and update the fields is_superuser, is_staff and is_active to be either 1 or 0.
Let me know if the new version fixes your issue.


404 uploading a chart

I'm running charts-syncer on Kubernetes to sync (for now) one chart. It's able to pull the chart from the source but when it tries to upload it to the target I get the following error.
I0427 20:06:06.387271       1 sync.go:105] Uploading "airflow-12.2.0" chart...
I0427 20:06:06.387338       1 cache.go:54] cache hit { op:has, id:87daf0bc278305a910719eff7d264dccc2168344, filename:airflow-12.2.0.tgz }
I0427 20:06:06.387390       1 cache.go:54] cache hit { op:has, id:87daf0bc278305a910719eff7d264dccc2168344, filename:airflow-12.2.0.tgz }
I0427 20:06:06.387737       1 cache.go:97] cache hit { op:store, id:87daf0bc278305a910719eff7d264dccc2168344, filename:airflow-12.2.0.tgz }
E0427 20:06:06.558504       1 sync.go:107] unable to upload "airflow-12.2.0" chart: unexpected status: 404 Not Found
Error: 4 errors occurred:
unexpected status: 404 Not Found
unexpected status: 404 Not Found
unexpected status: 404 Not Found
unexpected status: 404 Not Found

I'm guessing it's a problem with the specified target URL, repo name, or credentials but I don't see any indication of which. Any ideas on where/how I can figure this out?

My config.yaml currently has the following. (I've tried lots of combinations here.)
target:
  repo:
    kind: OCI
    url: https://kendrider.jfrog.io/artifactory/charts-helm-local
  repoName: charts-helm-local
  containerRegistry: "kendrider.jfrog.io"
  containerRepository: "default-docker-local"

My secrets.env has the correct credentials.
I've verified the Kubernetes configmap and secret correspond to the above.
I've also verified I can do the following command.
curl -u${TARGET_REPO_AUTH_USERNAME}:${TARGET_REPO_AUTH_PASSWORD} -T test.tgz https://kendrider.jfrog.io/artifactory/charts-helm-local/test.tgz

The problem was with the package type I chose when creating the repository in Artifactory. It should be Docker rather than Helm.


IDC deployment configuration issues

Slim is now available in the IDC dev tier, and there are some hopefully small configuration issues that would be good to resolve to avoid confusion, and make presentation consistent with the radiology viewer:

annotations toolbar should be hidden, since this is a read-only view of the data
study selector button should be disabled, since the user will get to the viewer from the portal
IDC logo should be added as in OHIF viewer

This probably is worth to discussing at the next meeting. we have two possibilities:

we fork Slim and we apply these modifications (I would avoid it)
we need a system in Slim to configure "extensions" (e.g. a config file) and refactor some parts. We were briefly discussing this yesterday for https://github.com/MGHComputationalPathology/slim/issues/37. The decision was to avoid to give any API/extensions capabilities for the moment, but in light of this, we should probably reconsider it.

P.S.: I would also put any work for https://github.com/MGHComputationalPathology/slim/issues/37 in standby until we take a decision on the extendibility and configurability of Slim.

There's also this error that pops up every time on SM load, which would be good to eliminate.

@hackermd  - @wlongabaugh and most of the team feel strongly that the study list selector should be removed from the upper left corner. Can this be removed, if other items in the list cannot be addressed immediately?

On that note, there is already a fork of Slim under IDC here https://github.com/ImagingDataCommons/slim that has a cherry-picked commit, so maybe for now we can make those customizations in the IDC fork, and then when the upstream is ready, synchronize the fork with the main repo? I am just thinking how we can expedite public release of Slim functionality, while not confusing the users with the items listed in this issue.

@wlongabaugh and most of the team feel strongly that the study list selector should be removed from the upper left corner before we can push the Slim capability into the user-facing production tier. Can this be removed, if other items in the list cannot be addressed immediately?

Yes, we can make this configurable easily. Will merge #47 later today and then start addressing these smaller issues.

On that note, there is already a fork of Slim under IDC here https://github.com/ImagingDataCommons/slim that has a cherry-picked commit, so maybe for now we can make those customizations in the IDC fork, and then when the upstream is ready, synchronize the fork with the main repo? I am just thinking how we can expedite public release of Slim functionality, while not confusing the users with the items listed in this issue.

I would avoid cherry picking into the fork if possible. I can prioritize this issue and make a new release within the next days.

I would avoid cherry picking into the fork if possible.

I agree. @wlongabaugh did the cherry-picking into that fork to address #36 in absence of the solution in the master. We are aiming for production tier release around Wednesday next week. If a more robust solution can be ready in time that does not require cherry-picking, definitely we should use it.


Use Value -> Proto method to avoid duplicate code

Fixed with https://github.com/sajari/sajari-sdk-php/commit/56a043a3afc8260b58567cb9d689a319e0d73f9d#diff-9ec7b489631d30b095d0f4fa2599dc76


CloudFormation does not handle resource AWS::IAM::ManagedPolicy when having any provider: IAM auth rules on schema

Note: If your question is regarding the AWS Amplify Console service, please log it in the
AWS Amplify Console repository

Which Category is your question related to?
Graphql api generated by amplify
Amplify CLI Version
7.6.26
What AWS Services are you utilizing?
Auth, lambda, api (graphql)
Provide additional details e.g. code snippets. Be sure to remove any sensitive data.
If my schema has any { allow: private, provider: iam } auth rules and I run amplify mock, the terminal starting mock api up displays message Mock does not handle CloudFormation resource of type AWS::IAM::ManagedPolicy. Skipping processing resource AuthRolePolicy<policyId>.
When I try to connect to the api from amplify generated lambda that has been given Query, Mutation, Subscription permissions to the api, I get Unauthorized error. The only way I can connect to the api from my lambdas, is setting the needed models publicly available.
Expected behaviour
I would expect { allow: private, provider: iam } auth rules to be handled by amplify, just like the docs say amplify does handle them.

Hey @anttironty :wave: thanks for raising this! Can you share the steps you took to grant access to the API for the function, and also the code snippet calling the API?

Hey @josefaidt, thank you for the quick follow up.
I followed your documentation here: https://docs.amplify.aws/guides/functions/graphql-from-lambda/q/platform/js/
I created the function by running amplify add function, when the cli asked Do you want to configure advanced settings? I selected yes. Then I selected yes to Do you want to access other resources in this project from your Lambda function?
When asked the categories I want the function to have access to, I selected api -> <my api name>. Then I selected Query, Mutation, Subscription as the operations I want my function to be permitted to use on the api.
Code that calls the api is pretty much exactly as here on your documentation: https://docs.amplify.aws/guides/functions/graphql-from-lambda/q/platform/js/#mutation
I use axios, url is from GRAPHQLAPIENDPOINTOUTPUT env variable, api key is from GRAPHQLAPIKEYOUTPUT env variable. Api key is valid as my calls work if I have {allow: public} as the auth rule.
Also, I can confirm that I have had generateGraphQLPermissions set to true at cli.json from the beginning.

Hey @anttironty thank you for the clarification! To further clarify, are the requests being signed as documented in the example here? https://docs.amplify.aws/guides/functions/graphql-from-lambda/q/platform/js/#signing-a-request-from-lambda

Hey @anttironty thank you for the clarification! To further clarify, are the requests being signed as documented in the example here? https://docs.amplify.aws/guides/functions/graphql-from-lambda/q/platform/js/#signing-a-request-from-lambda

Yep, they are.
if (apiKey) {
        req.headers["x-api-key"] = apiKey;
    } else {
        const signer = new AWS.Signers.V4(req, "appsync", true);
        signer.addAuthorization(AWS.config.credentials, AWS.util.date.getDate());
 }

Code comparable to this snippet from docs example is present. Altough it seems like apiKey always exists and thus code inside the else statement never gets executed (atleast when mocking).

Hey @anttironty upon further inspection the mock-related question is an existing feature request documented here https://github.com/aws-amplify/amplify-cli/issues/9100, and to your previous comment, yes that snippet has an if block that will not sign the request if your API also has an API key attached to it. To mitigate issues with private IAM auth when deployed, please remove the conditional to check for an API key

Closing due to inactivity, @anttironty if you are still experiencing this issue please reply back to this thread and we can re-open to investigate further 🙂


Put clickable URLs from quickstart in console

Feel free to close this one, but having the URLs clickable from your terminal is really helpful and I think it really shows the magic of how fast you can get up and running with keystone.

Yes! This is an excellent idea!
We do actually have this kind of output, but it's disabled by default on the demo project because we've got DISABLE_LOGGING=true set in the package.json:

Oh that is even better :)


KEVM semantics cannot update Haskell backend submodule

A commit which updates the Haskell backend (https://github.com/kframework/k/pull/1830) causes the hkg/totalSupply-spec.k proof on KEVM to go from about 100s to 170s on my machine. This is affecting other proofs as well.
* 42c0b1531 - !!! (44976006) deps/k: 449760069 - Update dependency: haskell-backend/src/main/native/haskell-backend (#1830)
| testset: prove-smoke - Fri Mar 26 20:49:15 UTC 2021
| 0  0.60s    0.02s     0.55s     3348KB     rm    -rf                                             deps                           .build
| 0  1.47s    0.95s     0.54s     58616KB    git   submodule                                       update                         --init        --recursive
| 0  246.42s  2048.49s  2347.27s  3059360KB  make  deps                                            RELEASE=true
| 0  31.26s   207.96s   6.54s     2728340KB  make  build-haskell                                   -j8                            RELEASE=true
| 0  166.89s  352.96s   8.22s     3854948KB  make  tests/specs/erc20/hkg/totalSupply-spec.k.prove  TEST_SYMBOLIC_BACKEND=haskell
|
* 8842ac60b - !!! (4a180596) deps/k: 4a180596e - nix: Add ncurses to runtime dependencies for tput (#1871)
| testset: prove-smoke - Fri Mar 26 20:41:48 UTC 2021
| 0  0.54s    0.00s     0.52s     3184KB     rm    -rf                                             deps                           .build
| 0  1.46s    0.95s     0.55s     66596KB    git   submodule                                       update                         --init        --recursive
| 0  236.13s  2011.09s  2101.76s  2801192KB  make  deps                                            RELEASE=true
| 0  30.18s   202.95s   6.90s     2783132KB  make  build-haskell                                   -j8                            RELEASE=true
| 0  98.84s   260.68s   7.08s     3411720KB  make  tests/specs/erc20/hkg/totalSupply-spec.k.prove  TEST_SYMBOLIC_BACKEND=haskell

Reproduction steps (in KEVM repo against _update-deps_kframework_k branch - https://github.com/kframework/evm-semantics/pull/980):
make deps RELEASE=true
make build-haskell -j8 RELEASE=true
make tests/specs/hkg/totalSupply-spec.k.prove TEST_SYMBOLIC_BACKEND=haskell KPROVE_OPTS=--bug-report

I've attached the input kore file for the proof (generated with KEVM set to latest K), which shows the same performance issue.
kevm-bug-totalSupply.tar.gz

Ok, it looks like some recent performance updates came through, which reduces the runtime to 130s. Still not as fast as before, but better than the regression:
* eb7b27775 - deps/k: a95346219 - Update dependency: haskell-backend/src/main/native/haskell-backend (#1885) - RV Jenkins (HEAD -> _update-deps_kframework_k, upstream/_update-deps_kframework_k)
| testset: prove-smoke - Tue Mar 30 14:09:47 UTC 2021
| 0  0.59s    0.01s     0.56s   3200KB     rm    -rf                                             deps                           .build
| 0  3.37s    1.25s     0.81s   86536KB    git   submodule                                       update                         --init        --recursive
| 0  489.03s  1315.70s  75.74s  3001376KB  make  deps                                            RELEASE=true
| 0  32.69s   232.50s   7.70s   2892916KB  make  build-haskell                                   -j8                            RELEASE=true
| 0  130.59s  302.39s   7.36s   3854972KB  make  tests/specs/erc20/hkg/totalSupply-spec.k.prove  TEST_SYMBOLIC_BACKEND=haskell

However, it appears there is now a test failing that was passing before on this branch: https://github.com/kframework/evm-semantics/pull/980
Specifically:
make deps RELEASE=true
make build-haskell -j8 RELEASE=true
make tests/specs/erc20/ds/approve-failure-spec.k.prove TEST_SYMBOLIC_BACKEND=true

fails with:
 hkore-exec: [35530278] Warning (WarnRetrySolverQuery):
    (DebugAttemptEquation) while applying equation at /home/dev/src/evm-semantics-pr/.build/usr/lib/kevm/include/kframework/abi.md:182:10-182:71:
    (DebugEvaluateCondition) while evaluating predicate:
    The SMT solver initially failed to solve the following query:
      Decide predicate:
        /* Sfa */
        \not{_PREDICATE{}}(
            /* Sfa */
            \and{_PREDICATE{}}(
                /* Sfa */
                \equals{SortBool{}, _PREDICATE{}}(
               ...
               ...
                 Lbl'-LT-'generatedCounter'-GT-'{}(
                    /* Created: Kore.Step.Rule.Expand.maybeNewVariable */
                    /* Fl Fn D Sfa */
                    Var'Unds'DotVar1:SortInt{}
                )
            )
        )
Created bug report: kore-exec.tar.gz
[Warning] Compiler: Variable 'G' defined but not used. Prefix variable name
with underscore if this is intentional.
        Source(/home/dev/src/evm-semantics-pr/tests/specs/infinite-gas.k)
        Location(161,30,161,31)
[Error] Critical: Haskell Backend execution failed with code 1 and produced no
output.
Makefile:360: recipe for target 'tests/specs/erc20/ds/approve-failure-spec.k.prove' failed
make: *** [tests/specs/erc20/ds/approve-failure-spec.k.prove] Error 113

I've attached the generated bug-report: kore-exec.tar.gz

Some more information about the performance regression:
 Test                                                  | eb7b27775-haskell time | 6cc2fda1-haskell time | (eb7b27775-haskell/6cc2fda1-haskell) time
-------------------------------------------------------+------------------------+-----------------------+-------------------------------------------
 tests/specs/functional/storageRoot-spec.k             | 71.26                  | 398.34                | 0.17889240347441887
 tests/specs/functional/lemmas-spec.k                  | 55.84                  | 80.35                 | 0.6949595519601743
 tests/specs/examples/sum-to-n-spec.k                  | 77.88                  | 111.78                | 0.6967257112184648
 tests/specs/functional/infinite-gas-spec.k            | 44.21                  | 48.85                 | 0.9050153531218014
 tests/specs/functional/merkle-spec.k                  | 31.84                  | 34.49                 | 0.9231661351116265
 tests/specs/functional/lemmas-no-smt-spec.k           | 33.42                  | 33.33                 | 1.002700270027003
 tests/specs/benchmarks/storagevar00-spec.k            | 350.57                 | 329.78                | 1.0630420280186792
 tests/specs/benchmarks/overflow00-overflow-spec.k     | 516.82                 | 481.93                | 1.072396406117071
 tests/specs/benchmarks/storagevar03-spec.k            | 310.15                 | 270.2                 | 1.1478534418948927
 tests/specs/benchmarks/storagevar02-overflow-spec.k   | 502.89                 | 425.71                | 1.1812971271522867
 tests/specs/benchmarks/storagevar02-nooverflow-spec.k | 553.45                 | 466.21                | 1.1871259732738466
 tests/specs/benchmarks/storagevar01-spec.k            | 470.21                 | 389.91                | 1.2059449616578184
 tests/specs/erc20/hkg/totalSupply-spec.k              | 132.66                 | 102.02                | 1.3003332679866693
 tests/specs/erc20/ds/totalSupply-spec.k               | 2232.35                | 213.44                | 10.458911169415291

All of these proofs pass (but the above approve-failure proof does not pass). But we can see that ds/totalSupply-spec.k has about a 10X slowdown. I've attached the kore-exec generated bugreport for that one.
kevm-bug-totalSupply.tar.gz

There are two separate tasks here:

Retrieve the actual error message from tests/specs/erc20/ds/approve-failure-spec.k. Something caused the backend to exit without printing the final configuration. There is a warning, but that would not cause the backend to exit without producing any output.
Profile the slower tests, starting with tests/specs/benchmarks/storagevar03-spec.k. Look for common elements. Don't jump to tests/specs/erc20/ds/totalSupply-spec.k, which is probably too slow to profile easily.

approve-failure-spec.k: I believe the bug report actually contains the error in error.log, but I don't know why it wasn't included in the output as well; I ran the spec and got the same error (this time printed in the console).
kore-exec: [47119029] Error (ErrorDecidePredicateUnknown):
    Failed to decide predicate:
        /* Sfa */
        \not{_PREDICATE{}}(
            /* Sfa */
            \and{_PREDICATE{}}(
                /* Sfa */
                \equals{SortBool{}, _PREDICATE{}}(
                    /* Fl Fn D Sfa Cl */ \dv{SortBool{}}("true"),
                    /* Fl Fn D Sfa */
                    Lbl'Unds-LT-'Int'Unds'{}(
                        /* Fl Fn D Sfa */ VarSPENDER:SortInt{},
                        /* Fl Fn D Sfa Cl */
                        \dv{SortInt{}}("1461501637330902918203684832716283019655932542976")
                    )
                ),
                /* Sfa */
                \equals{SortBool{}, _PREDICATE{}}(
                    /* Fl Fn D Sfa Cl */ \dv{SortBool{}}("true"),
                    /* Fl Fn D Sfa */
                    Lbl'Unds-LT-Eqls'Int'Unds'{}(
                        /* Fl Fn D Sfa Cl */ \dv{SortInt{}}("0"),
                        /* Fl Fn D Sfa */ VarSPENDER:SortInt{}
                    )
                )
            )
        )
    with side condition:
        /* Spa */
        \and{_PREDICATE{}}(
            /* Spa */
            \equals{SortBool{}, _PREDICATE{}}(
                /* Fn Spa */
                Lbl'Unds'andBool'Unds'{}(
                    /* Fn Spa */
                    Lbl'Unds'andBool'Unds'{}(
                        /* Fn Spa */
                        Lbl'Unds'andBool'Unds'{}(
                            /* Fn Spa */
                            Lbl'Unds'andBool'Unds'{}(
                                /* Fn Spa */
                                Lbl'Unds'andBool'Unds'{}(
                                    /* Fn Spa */
                                    Lbl'Unds'andBool'Unds'{}(
                                        /* Fn Spa */
                                        Lbl'Unds'andBool'Unds'{}(
                                            /* Fn Spa */
                                            Lbl'Unds'andBool'Unds'{}(
                                                /* Fn Spa */
                                                Lbl'Unds'andBool'Unds'{}(
                                                    /* Fn Spa */
                                                    Lbl'Unds'andBool'Unds'{}(
                                                        /* Fn Spa */
                                                        Lbl'Unds'andBool'Unds'{}(
                                                            /* Fn Spa */
                                                            Lbl'Unds'andBool'Unds'{}(
                                                                /* Fn Spa */
                                                                Lbl'Unds'andBool'Unds'{}(
                                                                    /* Fn Spa */
                                                                    Lbl'Unds'andBool'Unds'{}(
                                                                        /* Fl Fn D Spa */
                                                                        Lbl'Unds-LT-Eqls'Int'Unds'{}(
                                                                            /* Fl Fn D Sfa Cl */
                                                                            \dv{SortInt{}}("0"),
                                                                            /* Fl Fn D Sfa */
                                                                            VarACCT'Unds'ID:SortInt{}
                                                                        ),
                                                                        /* Fn Spa */
                                                                        Lbl'Unds-LT-'Int'Unds'{}(
                                                                            /* Fl Fn D Sfa */
                                                                            VarACCT'Unds'ID:SortInt{},
                                                                            /* Fn Spa */
                                                                            Lbl'UndsXor-'Int'Unds'{}(
                                                                                /* Fl Fn D Sfa Cl */
                                                                                \dv{SortInt{}}("2"),
                                                                                /* Fl Fn D Sfa Cl */
                                                                                \dv{SortInt{}}("160")
                                                                            )
                                                                        )
                                                                    ),
                                                                    /* Fl Fn D Spa */
                                                                    Lbl'Unds-LT-Eqls'Int'Unds'{}(
                                                                        /* Fl Fn D Sfa Cl */
                                                                        \dv{SortInt{}}("0"),
                                                                        /* Fl Fn D Sfa */
                                                                        VarCALLER'Unds'ID:SortInt{}
                                                                    )
                                                                ),
                                                                /* Fn Spa */
                                                                Lbl'Unds-LT-'Int'Unds'{}(
                                                                    /* Fl Fn D Sfa */
                                                                    VarCALLER'Unds'ID:SortInt{},
                                                                    /* Fn Spa */
                                                                    Lbl'UndsXor-'Int'Unds'{}(
                                                                        /* Fl Fn D Sfa Cl */
                                                                        \dv{SortInt{}}("2"),
                                                                        /* Fl Fn D Sfa Cl */
                                                                        \dv{SortInt{}}("160")
                                                                    )
                                                                )
                                                            ),
                                                            /* Fl Fn D Spa */
                                                            Lbl'Unds-LT-Eqls'Int'Unds'{}(
                                                                /* Fl Fn D Sfa Cl */
                                                                \dv{SortInt{}}("0"),
                                                                /* Fl Fn D Sfa */
                                                                VarORIGIN'Unds'ID:SortInt{}
                                                            )
                                                        ),
                                                        /* Fn Spa */
                                                        Lbl'Unds-LT-'Int'Unds'{}(
                                                            /* Fl Fn D Sfa */
                                                            VarORIGIN'Unds'ID:SortInt{},
                                                            /* Fn Spa */
                                                            Lbl'UndsXor-'Int'Unds'{}(
                                                                /* Fl Fn D Sfa Cl */
                                                                \dv{SortInt{}}("2"),
                                                                /* Fl Fn D Sfa Cl */
                                                                \dv{SortInt{}}("160")
                                                            )
                                                        )
                                                    ),
                                                    /* Fl Fn D Spa */
                                                    Lbl'Unds-LT-Eqls'Int'Unds'{}(
                                                        /* Fl Fn D Sfa Cl */
                                                        \dv{SortInt{}}("0"),
                                                        /* Fl Fn D Sfa */
                                                        VarCALL'Unds'DEPTH:SortInt{}
                                                    )
                                                ),
                                                /* Fl Fn D Spa */
                                                Lbl'Unds-LT-'Int'Unds'{}(
                                                    /* Fl Fn D Sfa */
                                                    VarCALL'Unds'DEPTH:SortInt{},
                                                    /* Fl Fn D Sfa Cl */
                                                    \dv{SortInt{}}("1024")
                                                )
                                            ),
                                            /* Fl Fn D Spa */
                                            Lbl'Unds-LT-Eqls'Int'Unds'{}(
                                                /* Fl Fn D Sfa Cl */
                                                \dv{SortInt{}}("0"),
                                                /* Fl Fn D Sfa */
                                                VarSPENDER:SortInt{}
                                            )
                                        ),
                                        /* Fn Spa */
                                        Lbl'Unds-LT-'Int'Unds'{}(
                                            /* Fl Fn D Sfa */
                                            VarSPENDER:SortInt{},
                                            /* Fn Spa */
                                            Lbl'UndsXor-'Int'Unds'{}(
                                                /* Fl Fn D Sfa Cl */
                                                \dv{SortInt{}}("2"),
                                                /* Fl Fn D Sfa Cl */
                                                \dv{SortInt{}}("160")
                                            )
                                        )
                                    ),
                                    /* Fl Fn D Spa */
                                    Lbl'Unds-LT-Eqls'Int'Unds'{}(
                                        /* Fl Fn D Sfa Cl */
                                        \dv{SortInt{}}("0"),
                                        /* Fl Fn D Sfa */ VarVALUE:SortInt{}
                                    )
                                ),
                                /* Fn Spa */
                                Lbl'Unds-LT-'Int'Unds'{}(
                                    /* Fl Fn D Sfa */ VarVALUE:SortInt{},
                                    /* Fn Spa */
                                    Lbl'UndsXor-'Int'Unds'{}(
                                        /* Fl Fn D Sfa Cl */
                                        \dv{SortInt{}}("2"),
                                        /* Fl Fn D Sfa Cl */
                                        \dv{SortInt{}}("256")
                                    )
                                )
                            ),
                            /* Fl Fn D Spa */
                            Lbl'Unds-LT-Eqls'Int'Unds'{}(
                                /* Fl Fn D Sfa Cl */ \dv{SortInt{}}("0"),
                                /* Fl Fn D Sfa */ VarSTOPPED:SortInt{}
                            )
                        ),
                        /* Fn Spa */
                        Lbl'Unds-LT-'Int'Unds'{}(
                            /* Fl Fn D Sfa */ VarSTOPPED:SortInt{},
                            /* Fn Spa */
                            Lbl'UndsXor-'Int'Unds'{}(
                                /* Fl Fn D Sfa Cl */ \dv{SortInt{}}("2"),
                                /* Fl Fn D Sfa Cl */ \dv{SortInt{}}("256")
                            )
                        )
                    ),
                    /* Fn Spa */
                    Lbl'UndsEqlsEqls'Int'Unds'{}(
                        /* Fl Fn D Sfa */ VarSTOPPED:SortInt{},
                        /* Fn Spa */
                        Lbl'Unds-LT--LT-'Int'Unds'{}(
                            /* Fl Fn D Sfa Cl */ \dv{SortInt{}}("1"),
                            /* Fl Fn D Spa */
                            Lbl'UndsStar'Int'Unds'{}(
                                /* Fl Fn D Sfa Cl */ \dv{SortInt{}}("20"),
                                /* Fl Fn D Sfa Cl */ \dv{SortInt{}}("8")
                            )
                        )
                    )
                ),
                /* Fl Fn D Sfa Cl */ \dv{SortBool{}}("true")
            ),
            /* Spa */
            \equals{SortGeneratedCounterCell{}, _PREDICATE{}}(
                /* Fl Fn D Sfa */ Var'Unds'DotVar0:SortGeneratedCounterCell{},
                /* Fl Fn D Spa */
                Lbl'-LT-'generatedCounter'-GT-'{}(
                    /* Created: Kore.Step.Rule.Expand.maybeNewVariable */
                    /* Fl Fn D Sfa */
                    Var'Unds'DotVar1:SortInt{}
                )
            )
        )

The frontend version cited (where the proof fails) includes commit ec02c41d2ff5b970729cd980269a11b686e1e614 of the Haskell backend. It was working with commit 684f9a8bc6502e0b119f2b0574e1202876be07a0.

The first commit on which the proof fails is 9460590a964dbb25464f452094c0461635bf62de.

If simplifying the side-condition causes the proof to fail, it could be the case that we had a lemma which was relying on the side-condition being un-simplified, and need to adjust it to assume that the side-condition now is simplified. So it may not be a problem in the backend, per-se.
Is that also the first commit that the slowdown on the other proofs happens? If so, it could be the same story.

No, it's definitely a backend problem. The salient feature is that none of the concrete terms in the side condition are evaluated.

On https://github.com/kframework/kore/pull/2526 approve-failure passes again.
But, this spec is also affected by a bad performance regression. On 684f9a8 it takes ~15m while on the fix PR it jumps to ~43m.

Now that https://github.com/kframework/kore/pull/2526 has been merged, approve-failure should pass again.
Regarding the performance regressions, I've profiled almost all of the problematic specs, and there seem to be two main issues:

hashWithSalt (self time ~7%, total time ~13%), the calls are mainly coming from SideCondition.andCondition which takes up ~23% of total time. The storagevar specs are the ones affected by this
Id.compare (self time ~8%, total time ~8%) and also Inj.== (self time ~5%, total time 12%); I think that a good amount of these calls are coming from NormalizedAc.== (total time ~19%), which gets called by isSimplified and Simplified.<>, and also from SideCondition.generateNormalizedAcs (total time ~19%). The two totalsupply specs are the ones affected by this.

I think we should try using a HashMap in InternalMap to avoid some of the expensive calls to Key.==.

The problem with SideCondition.andCondition is that the function itself is linear in the size of the SideCondition (it takes apart both its arguments and rebuilds the result from the beginning) but also we call SideCondition.andCondition a linear number of times, so in total this is quadratic. We need to rewrite andCondition so that it doesn't need to disassemble its arguments.

The failing test (and performance regression) was fixed enough for the update to go through. There is still a large regression though in this update to K https://github.com/kframework/evm-semantics/pull/980:
 Test                                                  | 1134fd70-haskell time | 5e346827-haskell time | (1134fd70-haskell/5e346827-haskell) time
-------------------------------------------------------+-----------------------+-----------------------+------------------------------------------
 tests/specs/functional/storageRoot-spec.k             | 58.04                 | 401.32                | 0.14462274494169242
 tests/specs/functional/lemmas-spec.k                  | 48.46                 | 81.57                 | 0.594090964815496
 tests/specs/functional/infinite-gas-spec.k            | 37.96                 | 48.93                 | 0.7758021663601063
 tests/specs/examples/sum-to-n-spec.k                  | 95.44                 | 115.01                | 0.8298408834014432
 tests/specs/functional/merkle-spec.k                  | 29.96                 | 35.55                 | 0.8427566807313643
 tests/specs/functional/lemmas-no-smt-spec.k           | 32.76                 | 34.39                 | 0.9526025007269554
 tests/specs/erc20/hkg/totalSupply-spec.k              | 122.61                | 103.76                | 1.181669236700077
 tests/specs/benchmarks/storagevar00-spec.k            | 403.41                | 334.45                | 1.2061892659590374
 tests/specs/benchmarks/overflow00-overflow-spec.k     | 615.59                | 493.27                | 1.247977780931336
 tests/specs/benchmarks/storagevar03-spec.k            | 351.81                | 276.27                | 1.2734281680964274
 tests/specs/benchmarks/storagevar02-overflow-spec.k   | 570.7                 | 433.83                | 1.3154922435055207
 tests/specs/benchmarks/storagevar02-nooverflow-spec.k | 629.57                | 477.44                | 1.318636896782842
 tests/specs/benchmarks/storagevar01-spec.k            | 539.53                | 398.05                | 1.3554327345810826
 tests/specs/erc20/ds/approve-failure-spec.k           | 1473.22               | 859.81                | 1.7134250590246685
 tests/specs/erc20/ds/totalSupply-spec.k               | 1516.38               | 220.79                | 6.867974093029576

It looks like ds/totalSupply is the only real sufferer, but on my own machine this means that proofs run 4 at a time go from taking 1640s to 2280s.


Add option to choose between https and ssh protocol

Add option in .env file
Also fix errors by empty repositories

Very cool, thanks! 👍


feat: 🎸 add tooltip context support to tooltip trigger

✅ Closes: https://github.com/adobe/react-spectrum/issues/6802
✅ Pull Request Checklist:

[x] Included link to corresponding React Spectrum GitHub Issue.
[x] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[x] Filled out test instructions.
[x] Updated documentation (if it already exists for this component).
[x] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Wrap TooltipTrigger with <TooltipContext.Provider> or <Provider values={[[TooltipContext, props]]}>
See that Tooltip now receives props as expected according to established slot props pattern
NOTE: slot is added to TooltipTrigger, not Tooltip

🧢 Your Project:

We got a chance to discuss it today as a team. Unfortunately, we found some edge cases that lead us to the conclusion this is not the direction we want to go right now.
Mostly this pertains to nested TooltipTrigger's, which we see most frequently like this:
<TooltipTrigger
  <DialogTrigger
    <Button
    <Dialog
      <TooltipTrigger
        <Button
        <Tooltip
      </TooltipTrigger
    </Dialog
  </DialogTrigger
  <Tooltip
<TooltipTrigger

Some of the issues that arise are:

useContextProps internally calls mergeIds through mergeProps, this will result in all the Tooltips sharing ids and duplicate ids being in the rendered DOM
useContextProps also internally chains all events together through mergeProps, meaning the open/close state can end up confused with the two tooltips open state being linked
this is passing Tooltip props on the context to TooltipTrigger, not Tooltip which is not consistent with our other components

I'm going to close this, thank you for starting a discussion on the topic and providing concrete examples and implementation to ground the discussion.
Our recommendation, for now, is to create your own design system context and merging logic to apply props to the Tooltip.

@snowystinger There is an alternative approach if you want to consider it. If we introduced a unexported InternalTooltipContext that was used to pass props from TooltipTrigger to Tooltip then the currently exported TooltipContext would behave as expected. The Tooltip would just need to consume both contexts. But I believe that this would address the same fix I'm looking for and the nested issue you've raised

@snowystinger I've pushed this commit showing the alternative approach that I believe works for all scenarios discussed: https://github.com/ArrayKnight/react-spectrum/commit/b7bd0d41550939324bc85bf94de8b27191b8be9e
If you feel like this is a viable option, we can reopen the PR for approval

@snowystinger Any chance you've had time to review the alternative approach?

Thanks for your patience, I've not had time to review this yet. Thanks for making a new suggestion, one of us will try to find time soon to have a look.


Spending money on GitHub actions: what would be the scale?

Please share any additional details on this topic
OQS has requested the ability to run ARM builds on GitHub. The first step of this is having a budget estimated so it can be requested; the second step is to get the orgs into the ARM runner beta.
Detail what actions or feedback you would like from the TAC
An estimated spend and decision on how broadly this should be used. I don't know how much, if anything, is spent at CircleCI, for comparison.
How much time do you need for this topic?
5 minutes or less

FWIW, input here.
Please consider in your budgeting exercise that the project should be able to grow and more contributions & support for more platforms means more PRs, means more CI resources.
For OQS our goal has been to stay "lean and mean"/ecologically responsible (e.g., to test some platforms only in downstream sub projects as opposed to every sub project or do do weekly tests instead of "merge-at-main" CI, etc.) -- but this required work and discipline that someone needs to provide also going forward.

Please consider in your budgeting exercise that the project should be able to grow and more contributions & support for more platforms means more PRs, means more CI resources.

Yup. My hope is that with the exception of ARM runners, we are able to keep PQCA on the free plan at GitHub.

Within PQCP we have some requirements from the arm implementations to use AWS. I don't believe github arm runners meet their requirements.
More details at https://github.com/pq-code-package/mlkem-c-aarch64/issues/34

This has been approved by the governing board.


Fix indent in quickstart chart template

What this PR does / why we need it:
In case of enabling monitoring for quickstart chart, wrong indent root to invalid yaml generate as below
---
# Source: pipecd/templates/configmap.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: pipecd
...
    --- # <- this line was wrong
apiVersion: v1
kind: ConfigMap
metadata:
  name: pipecd-grafana-dashboards

cause enable to apply pipecd's configmap and make pipecd-server, pipecd-ops (which requires pipecd configmap to start) failed to rolled out.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

Nice catch!
/lgtm

Let me merge this to release the new version.
/approve

/changelog


Fix a pesky bug in marshalls.cpp/encode_variant

Fixes #7556 - running game from editor on LLVM builds.
Yay :star:! Achievement got: Fix a paranormal bug.
(Note: this doesn't need cherrypicking, as the commit that initially got the code there is 13cdccf23b)

Nice catch!


Feature Additive Expert Ensemble

I'm trying to implement the Additive Expert Ensemble algorithm, but keep facing an error:

the NaiveBayes estimator (base_estimator instance) returns probabilities whose sum is 0;
therefore, line 172 of naive_bayes.py leads to a division by zero "y_proba[int(key)] = value / sum_values" ;

Any idea why this could be happening? (given that this file was not changed and I only use the classifier's predict method)
Changes proposed in this pull request:

Implementation of Additive Expert Ensemble algorithm [1]
[1] Kolter and Maloof. Using additive expert ensembles to cope with Concept drift. Proc. 22 International Conference on Machine Learning, 2005.

@scikit-multiflow/scikit-multiflow-repo-admins

Hello @AndreFCruz
I suspect that do_naive_bayes_prediction is returning {0:0.0} which can happen if the observed distribution is empty, which shouldn't be in this case given that you are training on 100 samples before the error. Could you share an MWE?
Additionally to this, the code is not properly protected against division by zero. I will submit a fix after figuring the issue you are reporting (i.e. why is the sum zero?)

Thanks for the feedback, I think I found a couple bugs on my code.
I made a couple changes (e.g. guarding against predictions when experts aren't yet trained), and now I only see the error once in the beginning (which is still odd given that it's after pretraining):

Here is a MWE:
from skmultiflow.bayes import NaiveBayes
from skmultiflow.evaluation import EvaluatePrequential
from skmultiflow.data import WaveformGenerator

stream = WaveformGenerator()
stream.prepare_for_use()
evaluator = EvaluatePrequential(show_plot=True,
                                pretrain_size=200,
                                max_samples=5000)

from skmultiflow.meta import AdditiveExpertEnsemble
ensemble = AdditiveExpertEnsemble(max_estimators=5, base_estimator=NaiveBayes())

evaluator.evaluate(stream=stream, model=ensemble)

I think the problem lies somewhere in this portion of the code from the file utils.py. Following up the sum_values variable in the naive_bayes.py file.
if attribute_observers:
    for att_idx in range(len(X)):
        if att_idx in attribute_observers:
            obs = attribute_observers[att_idx]
            votes[class_index] *= obs.probability_of_attribute_value_given_class(X[att_idx], class_index)

Thanks for the info @AndreFCruz and @xfontes42
I looked in detail and found that:

The zero value is indeed generated by do_naive_bayes_prediction, but not by an empty observed distribution. The actual reason is the zero variance when the attribute observers have not seen enough data. However, this is the expected behavior in do_naive_bayes_prediction.
The issue is not triggered by the model trained in the first 200 samples but by a new expert model introduced in the ensemble. Since this new model has not seen enough data then it returns zero votes as explained above.
Taken this into consideration, the bahiour of NaiveBayes is correct and we just need to address properly the division by zero. I will commit a fix in the predict_proba of NaiveBayes to properly handle this when normalizing the votes.

Note: During this analysis I noticed that the WaveformGenerator yields class labels as float when they should be int. This has no impact on the reported issue but I will address it as well in a fix commit.
Once again thanks for the report.

The fix is available in the master branch (f7bad21abd5a7fc15f150c180eb70916a81013bf)

Thanks,
I still have a couple thing I'd like to improve on this implementation of AdditiveExpertEnsemble, so I'll close this PR and open non-draft PR soon.


Apktool x decompiling issue on Instagram.apk

Information

Apktool Version (`apktool-x 7.2.2a arm64) -
**Operating System (Android)
APK From? (Playstore, ROM, Other) -

Stacktrace/Logcat
Exception in thread "main" java.lang.NullPointerException
	at brut.androlib.res.data.value.ResStyleValue.serializeToResValuesXml(ResStyleValue.java:58)
	at brut.androlib.res.AndrolibResources.generateValuesFile(AndrolibResources.java:516)
	at brut.androlib.res.AndrolibResources.decode(AndrolibResources.java:267)
	at brut.androlib.Androlib.decodeResourcesFull(Androlib.java:132)
	at brut.androlib.ApkDecoder.decode(ApkDecoder.java:108)
	at brut.apktool.Main.cmdDecode(Main.java:166)
	at brut.apktool.Main.main(Main.java:81)
I: Using Apktool 2.2.2-Black on Instagram.apk
I: Loading resource table...
I: Decoding AndroidManifest.xml with resources...
I: Loading resource table from file: /data/data/per.pqy.apktool/1.apk
I: Regular manifest package...
I: Decoding file-resources...
I: Decoding values */* XMLs...

Include stacktrace here

Steps to Reproduce

apktool

Frameworks
If this APK is from an OEM ROM (Samsung, HTC, LG). Please attach framework files
(.apks that live in /system/framework or /system/priv-app)
APK
If this APK can be freely shared, please upload/attach a link to it.
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything?
.Yes
If you are trying to install a modified apk, did you resign it?
Are you using the latest apktool version?
Yes.

@harshkuttu, "Apktool X" and "Apktool 2.2.2-Black" is not an @iBotPeaches development department that I'm aware of.

There is a another build of Apktool, somewhere out there made by the guys at "Slimrom". They need a special build due to adding "black" qualifiers into Android. If my memory is right, they re-used IDs that a future version of AOSP used, thus we couldn't use those fixes.
v2.2.2 was released on - 2017.01.23, so pretty old. Without an application and an old build, not much I can do here.
Please try a newer version and I can re-open if this issue persists.

@iBotPeaches, there is a free Android App called "Apktool X" that Isn't available on the Play Store and is a free app.
If your curious about it and, would like a copy of it to examine, i would be more than happy to provide you with a link (here or via email) then please let me know.
Personally, I had tried it out a few times and it's not that bad at all but, I've always preferred doing Apktool specific tasks via the PC myself.
~Ibuprophen

I have over 100 bugs by myself to fix, I'd rather just ignore Apktool X because I don't what it is and its not official. Too many bugs to go searching for more online :)

Not a problem at all My Friend!
Understood and please let me know if you need anything looked into. I'm very good at researching things and am familiar with the Metadata system as well.
Thank you for your developments! :-)
~Ibuprophen
xda-developers RC

I don't think apktool X is a original project. The package name per.pqy.apktool is first used by me. I guess the guy who develops apktool X doesn't know how to cross compile openjdk and aapt for android, so he has to reuse my package id  ^_^ .


[dv_base_reg] Extend search by name functions

This is in preparation for the alias register implementation in #10982 and allows to search a register or field by alias or generic name.
Signed-off-by: Michael Schaffner<EMAIL_ADDRESS>

Thinking about this a bit more, a better approach might be to create an associative array, keyed by aliases, as part of the register block creation. That way, the commonly-called get_reg_by_name function would be almost unchanged (an array lookup, falling back to super.get_reg_by_name() on failure). You could hang it off lock_model for example.

Thinking about this a bit more, a better approach might be to create an associative array, keyed by aliases, as part of the register block creation. That way, the commonly-called get_reg_by_name function would be almost unchanged (an array lookup, falling back to super.get_reg_by_name() on failure). You could hang it off lock_model for example.

Let me explain a bit background for this update.
We want to define very generic names for close source CSRs and the actual design implementation will be in close source.
This is the usage we need in DV.
// in this open-source seq, we could access this CSR via a generic name as follows. (actual CSR name isn't available in open source)
class base_vseq;
  csr_wr(ral.a_block.generic_name_csr, 1);

// in the close source
class close_source_vseq extends base_vseq;
  // actual_name_csr is the same csr as generic_name_csr, but we prefer to use the actual name which is more meaningful.
  csr_rd(ral.a_block.actual_name_csr, rdata);

ral.a_block.actual_name_csr and ral.a_block.generic_name_csr are actually identical. Both will be pointed to the same object (actual_name_csr is pointed to generic_name_csr). And the generated RAL models in open source and close source are almost the same, except the close source one has some alias pointers.
This PR allows user to use either name to get the object.

Right, makes sense. I guess I'm just a bit sad to see so much of the core UVM functionality duplicated, which is why I was wondering about building an associative array to memoize the lookup. I'm not completely convinced that this would be better though (it might run faster, but I guess there's the same amount of code to check in).

Right, makes sense. I guess I'm just a bit sad to see so much of the core UVM functionality duplicated, which is why I was wondering about building an associative array to memoize the lookup. I'm not completely convinced that this would be better though (it might run faster, but I guess there's the same amount of code to check in).

Agree. UVM should improve the register lookup.

That's an excellent idea! Let's do that.

the alias_lookup table is a good idea. we could construct the table while invoking set_alias_name
class dv_base_reg_block:
  string alias_lookup[string];

class dv_base_reg:
  function void set_alias_name (string alias_name);
     dv_base_reg_block reg_block;
    `downcast(reg_block, get_parent())
     reg_block[alias_name] = get_name();

     this.alias_name = alias_name;
  endfunction: set_alias_name

But I don't think we use get_reg_by_name a lot. it won't really impact the performance too much. I'm fine to get in with the current approach.

Thanks for the good discussion and suggestions!
I believe @weicaiyang's suggestion should work well - the set_alias_name functions will only be used during the build phase.
Let me give this a try.

I have updated the classes accordingly - PTAL.


runing ann-visualizer, Error

I want to visualizer about YOLO v2, but runing the ann-visualizer, Error.
enviorment: ubuntu 16.10, python3.6, tensorflow1.3.0, Keras2.0.5
Look forward to your reply!
python yolov2_Visualizer.py
Using TensorFlow backend.
Traceback (most recent call last):
File "/home/tianao/anaconda3/lib/python3.6/site-packages/graphviz/backend.py", line 124, in render
subprocess.check_call(args, startupinfo=STARTUPINFO, stderr=stderr)
File "/home/tianao/anaconda3/lib/python3.6/subprocess.py", line 286, in check_call
retcode = call(*popenargs, **kwargs)
File "/home/tianao/anaconda3/lib/python3.6/subprocess.py", line 267, in call
with Popen(*popenargs, **kwargs) as p:
File "/home/tianao/anaconda3/lib/python3.6/subprocess.py", line 707, in init
restore_signals, start_new_session)
File "/home/tianao/anaconda3/lib/python3.6/subprocess.py", line 1333, in _execute_child
raise child_exception_type(errno_num, err_msg)
FileNotFoundError: [Errno 2] No such file or directory: 'dot'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "yolov2_Visualizer.py", line 25, in
ann_viz(network, title=""); File "/home/tianao/anaconda3/lib/python3.6/site-packages/ann_visualizer/visualize.py", line 204, in ann_viz
g.view();
File "/home/tianao/anaconda3/lib/python3.6/site-packages/graphviz/files.py", line 203, in view
cleanup=cleanup)
File "/home/tianao/anaconda3/lib/python3.6/site-packages/graphviz/files.py", line 176, in render
rendered = backend.render(self._engine, self._format, filepath)
File "/home/tianao/anaconda3/lib/python3.6/site-packages/graphviz/backend.py", line 127, in render
raise ExecutableNotFound(args)
graphviz.backend.ExecutableNotFound: failed to execute ['dot', '-Tpdf', '-O', 'network.gv'], make sure the Graphviz executables are on your systems' PATH

It seems like graphviz is not installed on your system. Can you double-check the installation of graphviz?

Use
sudo apt-get install graphviz

to install graphviz

I have the same problem... but I have graphviz installed on the system and I also set the system path.
Any idea?


Param expression lacks necessary reference information

In some cases, Surelog replaces parameters with expressions assigned to them. However, there are situations where it's impossible to tell what objects are being referred to.
Code:
module other
  #(parameter int Width = 1)
  (input logic[Width-1:0] in, output logic[Width-1:0] out);
   assign out = in;
endmodule;

module dut (input logic[7:0] in, output logic[7:0] out);
   other #(.Width($bits({in}))) oth(.in(in), .out(out));
endmodule

Corresponding UHDM (with some parts cut out):
\_module: work@dut (work@dut) dut.v:7:1: , endln:9:10
  |vpiDefName:work@dut
  |vpiName:work@dut
  ...
  |vpiModule:
  \_module: work@other <EMAIL_ADDRESS>dut.v:8: , parent:work@dut
    |vpiDefName:work@other
    |vpiName:oth
<EMAIL_ADDRESS>    |vpiPort:
    \_port: (in), line:3:27, endln:3:29<EMAIL_ADDRESS>      |vpiName:in
      |vpiDirection:1
      |vpiHighConn:
      \_ref_obj: (in), line:8:41, endln:8:43
        |vpiName:in
        |vpiActual:
        \_logic_net: (work@dut.in), line:7:30, endln:7:32, parent:work@dut
      |vpiLowConn:
      \_ref_obj:
        |vpiActual:
        \_logic_net: (work@dut.oth.in), line:3:27, endln:3:29<EMAIL_ADDRESS>          |vpiName:in
<EMAIL_ADDRESS>          |vpiNetType:36
          |vpiRange:
          \_range: , line:3:16, endln:3:25
            |vpiLeftRange:
            \_operation: , line:3:16, endln:3:21
              |vpiOpType:11
              |vpiOperand:
              \_sys_func_call: ($bits), line:3:16, endln:3:21
                |vpiName:$bits
                |vpiArgument:
                \_operation: , line:8:25, endln:8:29, parent:$bits
                  |vpiOpType:33
                  |vpiOperand:
                  \_ref_obj: (in), line:8:26, endln:8:28
                    |vpiName:in
              |vpiOperand:
              \_constant: , line:3:22, endln:3:23
                |vpiConstType:9
                |vpiDecompile:1
                |vpiSize:64
                |UINT:1
            |vpiRightRange:
            \_constant: , line:3:24, endln:3:25
              |vpiConstType:9
              |vpiDecompile:0
              |vpiSize:64
              |UINT:0
    |vpiPort:
    \_port: (out), line:3:55, endln:3:58<EMAIL_ADDRESS>      |vpiName:out
      |vpiDirection:2
      |vpiHighConn:
      \_ref_obj: (out), line:8:51, endln:8:54
        |vpiName:out
        |vpiActual:
        \_logic_net: (work@dut.out), line:7:52, endln:7:55, parent:work@dut
      |vpiLowConn:
      \_ref_obj:
        |vpiActual:
        \_logic_net: (work@dut.oth.out), line:3:55, endln:3:58<EMAIL_ADDRESS>          |vpiName:out
<EMAIL_ADDRESS>          |vpiNetType:36
          |vpiRange:
          \_range: , line:3:44, endln:3:53
            |vpiLeftRange:
            \_operation: , line:3:44, endln:3:49
              |vpiOpType:11
              |vpiOperand:
              \_sys_func_call: ($bits), line:3:44, endln:3:49
                |vpiName:$bits
                |vpiArgument:
                \_operation: , line:8:25, endln:8:29, parent:$bits
                  |vpiOpType:33
                  |vpiOperand:
                  \_ref_obj: (in), line:8:26, endln:8:28
                    |vpiName:in
              |vpiOperand:
              \_constant: , line:3:50, endln:3:51
                |vpiConstType:9
                |vpiDecompile:1
                |vpiSize:64
                |UINT:1
            |vpiRightRange:
            \_constant: , line:3:52, endln:3:53
              |vpiConstType:9
              |vpiDecompile:0
              |vpiSize:64
              |UINT:0
    ...
    |vpiParamAssign:
    \_param_assign: , line:2:19, endln:2:28<EMAIL_ADDRESS>      |vpiRhs:
      \_sys_func_call: ($bits), line:8:19, endln:8:30
        |vpiName:$bits
        |vpiArgument:
        \_operation: , line:8:25, endln:8:29, parent:$bits
          |vpiOpType:33
          |vpiOperand:
          \_ref_obj: (in), line:8:26, endln:8:28, parent:$bits
            |vpiName:in
            |vpiActual:
            \_logic_net: (work@dut.in), line:7:30, endln:7:32, parent:work@dut
      |vpiLhs:
      \_parameter: (work@dut.oth.Width), line:2:19, endln:2:28<EMAIL_ADDRESS>        |vpiName:Width
<EMAIL_ADDRESS>        |UINT:1
        |vpiTypespec:
        \_int_typespec: (Width), line:2:15, endln:2:18<EMAIL_ADDRESS>          |vpiName:Width

We assign the $bits expression to Width, which is used in oth.in's range. In UHDM, Width in oth.in's range is replaced with the $bits expression, but the ref_obj in it doesn't specify which in is being referred to. This causes an ambiguity, as it could be either dut.in or oth.in.
Even if the signal names were different, the lack of a vpiActual makes it difficult to figure out what the reference points to.
Note that in the param_assign in dut the ref_obj does have a vpiActual pointing to dut.in, which makes it unambiguous.

Short answer, it cannot be the local signal as it would be a self-reference definition, it has to be the signal in the parent module

Anyhow Surelog was not computing the actual constant value (It was not traversing the concat op and was not binding the signal properly), it does now, so it becomes a moot point.

Fixed by #1401


Saving Parcels output directly in zarr format

With this PR, we are implementing directly saving Parcels trajectory output data in zarr format. With the merging of #1165 in v2.3.1, it was already possible to store the output after conversion to a zarr file; after this PR there is no need for conversion at all.
Advantages are:

No need for converting the pickled dumps to file at the end of a simulation (with all the memory issues like #1091)
No need for explicit ParticleFile.export() call
Directly analyse the Parcels output during a simulation
Much simpler (hence easier-to-maintain) code

Only major disadvantage so far is that zarr folders are not as 'transportable' as netCDF files.  This is currently not picked up by any tests cause the set zarr as dependency, auto-detect zarr, and only test zarr in all the tests.
I myself don't have zarr installed, which is why I spotted the error.
I can't fix it anymore due to time and cause I also didn't look on the zarr implementation. But may be good to have a look on here (@erikvansebille ).