Follow symlinks while packaging code for execution on AWS Batch

More context in #176

Hey Savin - Thank you for all the help. I tested the change and here is how it goes:
My test script:
    @step
    def start(self):
        self.data = random.randint(0, 100)
        self.next(self.process)

    @step
    def process(self):
        self.data /= 100
        self.next(self.symlink_check_local)

    @step
    def symlink_check_local(self):
        with open("xxx/xxx/symbolic_links/test_symlink.sl", "r") as f:
            symlink_txt = f.readlines()
        print(symlink_txt)
        self.next(self.symlink_check_batch)

    @batch(cpu=1, memory=1000)
    @step
    def symlink_check_batch(self):
        print(os.system("ls"))
        print(os.system("ls symbolic_links/"))
        with open("symbolic_links/test_symlink.sl", "r") as f:
            symlink_txt = f.readlines()
        print(symlink_txt)
        self.next(self.end)

    @step
    def end(self):
        print(self.data)
        print("🏁🏁🏁🏁🏁🏁🏁🏁🏁")

Here is the command:
python xxx/xxx/hello_metaflow.py --package-suffixes '.py,.json,.sql,.sl,.txt' run | tee out.txt
So the symlink was in xxx/xxx/symbolic_links/test_symlink.sl, and it was pointing a file in the root directory called test.txt written hello world text in it.
Here is the shortened output:
Metaflow 2.0.3.post2+gitb4a2eeb executing MockFlow for user:kemalty
Validating your flow...
    The graph looks good!
Running pylint...
    Pylint not found, so extra checks are disabled.
Following Links...
Following Links...
2020-04-10 15:13:01.768 Workflow starting (run-id 194):
2020-04-10 15:13:02.304 [194/start/1366 (pid 42637)] Task is starting.
2020-04-10 15:13:05.868 [194/start/1366 (pid 42637)] Task finished successfully.
2020-04-10 15:13:06.582 [194/process/1367 (pid 42645)] Task is starting.
2020-04-10 15:13:10.483 [194/process/1367 (pid 42645)] Task finished successfully.
2020-04-10 15:13:11.226 [194/symlink_check_local/1368 (pid 42652)] Task is starting.
2020-04-10 15:13:13.623 [194/symlink_check_local/1368 (pid 42652)] ['Hello symlink...\n']
2020-04-10 15:13:14.704 [194/symlink_check_local/1368 (pid 42652)] Task finished successfully.
2020-04-10 15:13:15.456 [194/symlink_check_batch/1369 (pid 42662)] Task is starting.
2020-04-10 15:13:16.267 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] Task is starting (status SUBMITTED)...
2020-04-10 15:13:20.665 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] Task is starting (status RUNNABLE)...
2020-04-10 15:13:22.867 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] Task is starting (status STARTING)...
2020-04-10 15:13:26.197 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] Task is starting (status RUNNING)...
2020-04-10 15:13:32.074 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] Setting up task environment.
2020-04-10 15:13:44.618 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] Downloading code package.
2020-04-10 15:13:44.618 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] Code package downloaded.
2020-04-10 15:13:44.618 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] Task is starting.
2020-04-10 15:13:44.619 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] INFO
2020-04-10 15:13:44.619 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] __init__.py
2020-04-10 15:13:44.619 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] configs
2020-04-10 15:13:44.619 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] data
2020-04-10 15:13:44.619 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] experiment_main.py
2020-04-10 15:13:44.619 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] hello_metaflow.py
2020-04-10 15:13:44.619 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] job.tar
2020-04-10 15:13:44.619 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] metaflow
2020-04-10 15:13:44.620 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] project_root.py
2020-04-10 15:13:44.620 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] sql
2020-04-10 15:13:44.620 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] src
2020-04-10 15:13:44.620 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] symbolic_links
2020-04-10 15:13:44.620 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] test
2020-04-10 15:13:44.620 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] 0
2020-04-10 15:13:44.620 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] test_symlink.sl
2020-04-10 15:13:44.620 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] 0
2020-04-10 15:13:44.620 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424] <flow MockFlow step symlink_check_batch> failed:
2020-04-10 15:13:44.621 [194/symlink_check_batch/1369 (pid 42662)] [28f3b894-9b70-48f8-a832-d3261c5d2424]     Internal error
a832-d3261c5d2424] FileNotFoundError: [Errno 2] No such file or directory: 'symbolic_links/test_symlink.sl']
2020-04-10 15:13:47.752 [194/symlink_check_batch/1369 (pid 42662)] Task failed.
2020-04-10 15:13:47.752 Workflow failed.
2020-04-10 15:13:47.752 Terminating 0 active tasks...
2020-04-10 15:13:47.752 Flushing logs...
    Step failure:
    Step symlink_check_batch (task-id 1369) failed.

So it works fine in local 👍
However, you can see here that the symlinked file is not moved to the batch environment. It is not in the root folder, or in the symlink folder.
As an idea, maybe Metaflow can benefit from the Docker/git kind of approach when moving files. So by default, it moves all the files, with exceptions listed in .metaflowignore?

Ah I missed a case. Let me push out a fix.

@kemalty Given that this PR is not a blocker right now for your use case, we are going to punt it at the moment. This needs a bit more thought around packaging (particularly around traversing circular links).

@savingoyal Can you elaborate on your thoughts regarding packing and traversing circular links?
I ended up making this change to my local package to resolve importing some remote code before realizing this PR even existed. I was planning on creating a PR with this exact code change.

@GregHilstonHop It's not straightforward to detect and traverse circular links. That was the reason for punting this PR.

@savingoyal Understood. For clarity, if we enable symlink following the desired behavior is to detect and not travese circular links correct? Perhaps some exception is raised?

I would like to upvote support for this functionality. I currently have a Flow subclass in its own file that I would like to use across multiple flows and thought I was being smart by storing it in a central location in my repo and then symlinking to it only to find out Metaflow doesn't handle this.
Is there another suggested method that Metaflow supports that doesn't require having multiple hard copies of the same file in multiple directories alongside with their accompanying Flow files for something like subclassing?

I would like to upvote support for this functionality. I currently have a Flow subclass in its own file that I would like to use across multiple flows and thought I was being smart by storing it in a central location in my repo and then symlinking to it only to find out Metaflow doesn't handle this.
Is there another suggested method that Metaflow supports that doesn't require having multiple hard copies of the same file in multiple directories alongside with their accompanying Flow files for something like subclassing?

@dpatschke Did you figure out a way around this as I was thinking to do the same thing??
@savingoyal Any roadmap for re-looking at this? I could possibly help with the fix.

@JSpenced @dpatschke @GregHilstonHop @kemalty I'm happy to let you know that the latest version of Metaflow (2.5.2) follows symlinks in packaging 🎉 We added a bit extra logic to detect symlink cycles which otherwise would have made it hang


Tests: Add test cases for column_stats to test the data validations.

Hi Rowan,
Please check this out:
https://app.codecov.io/gh/UBC-MDS/EDAhelper/blob/master/src/EDAhelper/column_stats.py
The red ones are the lines not covered by any tests.  I have checked your test script and found that they are really not covered.  Can you add test cases?  Then we can have 100% test coverage.
Thanks.
Regards,
Steven

Just for the avoidance of doubt, if your code is checking that the columns argument should be a list, tuple or array, then your test case should be try to pass a number to it, and column_stats should throw an error.

Completed writing new test cases, reviewed by Steven


multiple language in same code block is supported?

When I write, is there a way to write multiple languages separated by tabs in the code block at the same location as this site?

No not that I know of. This isn't a native feature of Jekyll. You'd need some sort of plugin to do this.

Thanks for the advice.


What's wrong with training process?

I have tested on both GTX1070 and now is GTX1080 ti that with 12G momery still got core dumped:
  Tacotron Parameters       29.016 Million.
Tacotron training set to a maximum of 150000 steps
No model to load at ../data/logs-Tacotron-2/taco_pretrained

Generated 20 test batches of size 32 in 2.318 sec
[1]    3494 killed     python3 train.py --base_dir ../data

Just got this... Does the training pramars set too big??? ( default should slow down I think)

I had the same issue with my GTX1070 its was a problem with the CUDA installation for me, I think the tacatron 2 with default Hparams fits in the GTX1080 ti, for the GTX1070 i had to modify hparams output_per_steps=2 and use 16khz 16-bit (making the changes for that in the hparams to).

@tomasmartins  The default params are setting to high, the original author may using 2 more GPUs for parallel training but it is not possiable for normal people.


Language used is not detected

Describe the bug

I have created many repositories which consist mostly of javascript, it is more than 3 months since I uploaded but almost all my repository's languages are not detected, I don't have any prior knowledge to fix it. Can anyone help me with this?
Expected behaviour

Related discussion

Additional notes

Is there a reason you neglected to fill out the issue template?

sorry, I didn't find the issue template so I directly created an issue regarding my problem. Is there any particular template that I need to follow?

@raikiran07 I've updated the OP with the template's fields.

thanks for your help, I got the solution

This is the option you really wanted 😉


Editor does not show content on init

My text area is populated with data via php..
<textarea id="submission_content" maxlength="5000" name="content" placeholder="Content goes here" required>{{ $submission->content }}</textarea>
I init the editor like this..
var submissionContent = new SimpleMDE({         element: $("#submission_content")[0],         hideIcons: ["image", "heading"],         spellChecker: false,         placeholder: "10 to 5000 characters"     })
When the page loads the editor looks empty of content. However, when you focus into the editor the content appears.

@retzion
You need do this.
setTimeout(function() {
  simplemde.codemirror.refresh();
}.bind(simplemde), 0);

This is not a simplemde-markdown-editor problem.

Works great. Thanks.

But i think need add default refresh codemirror on initialization same way

@prostoandrei Would you mind submitting a PR that does this? It wouldn't hurt and it'd fix this strange bug for everyone.

Nevermind, this will be fixed in the next release.

@WesCossick ok. I will be glad to help in the future.

This is still happening to me. Using 1.11.2 and the content only loads when I click the editor.

@Polsaker please submit a new issue for this and reproduce the error using JSFiddle.

I take it back.. This worked only on desktop browsers..
setTimeout(function() {   simplemde.codemirror.refresh(); }.bind(simplemde), 0);
On mobile devices, however, the issue still persists. When a view is loaded the editor is blank (even though there is content inside it). When I focus into the editor, the content is revealed.
I have updated to ver 1.11.2

What mobile devices are you using?

False flag. The only browser having an issue is Chrome's mobile emulator (not a real device). I believe I had the old script cached or something. I also removed the following method and it all works fine now. Thank you.
setTimeout(function() {   submissionBackground.codemirror.refresh() }.bind(submissionBackground), 0)

got this from our QA..
On Android, the entered text is sill not appearing until I click into the field. On iOS, the entered text appears if I scroll down the page.

@prostoandrei your fix is not working for me in a React app where the textarea is being updated by local state:
<textarea className="input-field" id="editor" ref="editor" value={this.state.selectedItem.content} onChange={(event) => this.updateItem(event, 'content')}></textarea>

This issue is still persisting. I can confirm after checking on version 1.6.2 with Chrome Version 58.0.3029.96 (64-bit) on Mac

Issue is still there on latest version of SimpleMDE on Chrome 58.0.3029.110 (64-bit) - Windows 10

I have multiple instances on one page and need an initialValue on all of them.
I have read multiple threads including this one and have come up with the following code:
const simplemde = {};

$('textarea').each(function(key, element) {
    simplemde[element.id] = new SimpleMDE({
        element: element,
        toolbar: ['bold', 'italic', 'link'],
        spellChecker: false,
        initialValue: 'Test'
    });
});

Object.values(simplemde).forEach((value) => {
    setTimeout(function() {
        value.codemirror.refresh();
    }.bind(value), 0);
});

But this does not work for me. It still only shows the initialValue for the first once and the others need to be clicked to be seen.
Any ideas?

@jacklinwood I also ran into the exact same issue though I do not store my editors in a single array. I fixed my problem by increasing the timeout to 200 milliseconds.
Code of my solution:
setTimeout(function() {
	simplemde.codemirror.refresh();
}, 200);

I am not too familiar with JS internals so I am not sure if setting the timeout to 200 milliseconds will fix your issue as well


MSL: Fix '--msl-multi-patch-workgroup' out of bounds reads when dispatching more threads than control points

We had been working aound this by using:
[computeEncoder dispatchThreads: threadGridDims threadsPerThreadgroup: threadsPerThreadgroup];
instead of:
[computeEncoder dispatchThreadgroups: threadgroups threadsPerThreadgroup: threadsPerThreadgroup];
as we had experienced flickering and undefined behaviour with dispatchThreadgroups when the last threadgroup did not have enough data to fill all threadsPerThreadgroup and would result in writes passed the end of the output buffer and some off by one issues.
But it appears that the dispatchThreads version is less widely supported (in terms of tvOS and others) so I'm adding bounds checks on the compiler side to be able to use the dispatchThreadgroups version safely.
Edit: currently removed the changed which fixed the out of bounds writes based on PR feedback (only leaving fix for out of bounds reads)

@HansKristian-Work tests are green after removing the change to output indices, feel free to merge when you are ready


Avalonia

Upgrade Avalonia version？

Wahat version?

Avalonia released the latest version 0.12

Does it not work with latest Dock ?

It doesn't compile

Will be released soon on NuGet

https://www.nuget.org/packages/Dock.Avalonia/0.9.12


Improved Russian translation

New value and fix commas.

@WebVPF loving the clean-up and translation work you're doing! Keep it up!


appliance/postgresql: Implement postgres daemon manager

This is a concrete implementation of state.Postgres that configures/manages a Postgres daemon based on requests from the state machine. The unit tests cover all normal functionality, for expediency of shipping there are error cases that are not currently covered.

LGTM pending minor comments


Invalidate multiple property mappings structured ingest(3.1)

[x] @joeferner
[x] @diegogrz
[x] @mwizeman @sfeng88
[ ] @joeybrk372 @rygim @jharwig @EvanOxfeld

CHANGELOG
Fixed: Structured ingest tool shows error when trying to map a property to more than one column.

Would it be better to filter to list to not show properties in the first place?

I did consider filtering them, but decided that it might be better to have all properties viewable instead of hiding them if they're trying to make a choice. Ideally I would have liked to have the property select component display disabled options but that was a bigger change because it currently doesn't support that.

okay, fair enough. Can you adjust some alignment? Left align the text in input with the error, and add some margin-bottom so the checkbox line has more room.


OpenAPI transaction metadata docs don't warn about PII

Context
If a developer submits personally identifiable information (PII) to the blockchain there's no way to reverse it and the repercussions could be significant.
Essential Information
The OpenAPI docs around transaction creation, while thorough, don't warn about submitting PII metadata to the blockchain.
I'm wondering if this is something worth adding given the potential impact? Perhaps there are other docs around transaction metadata where this should reside too?

Thanks for the suggestion @mikestead. I think we should note the PII issue in the OpenAPI docs.
ADP-646

Thanks for the suggestion @mikestead. I think we should note the PII issue in the OpenAPI docs.
ADP-646

Addressed in #2437.

Addressed in #2437.

Great thanks for actioning that so quickly

Great thanks for actioning that so quickly


Same enviroment variable for all lemur environments

Hi,
is there a way how to ensure all lemur environments get same additional environment variables?
My idea is to use systemd env generator /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator (which combines all *.conf files from  ~/.config/environment.d/ into stdout) and provide this environment to all.
for sway example it could be done this way:
#! /bin/sh
set -a
eval $(/usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator)
set +a
exec sway

but how to achieve same thing for TTY shell enabled by include_tty_shell = true ?
Maybe related to #196. Custom "tty sessions" could be then just wrapped also into the script like sway above.

Hmm, one option could be to wrap the sway int user shell and assume the user shell handler initialization of all environment variables:
#! /bin/sh
exec $(echo $SHELL) -c "exec sway"

tty shell lemurs environment just launches user shell, so same env. variables there.
I am curious if there is a better way...


Add support for SDJWT  trustedIssuer and credential SchemaId Validation

Is this a regression?
No
Description
SDJWT is similar flow as JWT so need to support  similar to JWT
{
"connectionId": "{{VERIFIER_CONNECTION_ID}}",
"proofs": [
{
"schemaId": "{{baseUrl}}/schema-registry/schemas/{{SCHEMA_ID}}",
"trustIssuers": [
"did:prism:invalidddddđ"
]
}
],
"options": {
"challenge": "11c91493-01b3-4c4d-ac36-b336bab5bddf",
"domain": "https://prism-verifier.com"
},
"credentialFormat": "SDJWT",
"claims": {
"emailAddress": {},
"givenName": {},
"country" :{}
}
}
Please provide the exception or error you saw
No response
Please provide the environment you discovered this bug in
No response
Anything else?
No response

Related with https://github.com/hyperledger/identus-cloud-agent/issues/1438


vender: add vender and explicit set protoc-gen-grpc-gateway version

fix https://github.com/philips/grpc-gateway-example/issues/16

Two minor comments:

Since go1.7 golang.org/x/net/context is part of the Go runtime as context . IMHO the imports should be changed. Then the context package could be removed from vendoring.
There are still several "vender" typos.


content-box and border-box definitions swapped?

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details

https://developer.mozilla.org/en-US/docs/Web/CSS/box-sizing
I think that content-box and border-box definitions are swapped!
Acceptance criteria:
[] mark as resolved

I added examples in the text to hopefully help clarify.


[QUERY]how to use dall-e-2 in 1.0.0-beta.8?

Query/Question
how to use dall-e-2 in 1.0.0-beta.8?
i want to use dall-e-2 .but  client.getImageGenerations(deploymentOrModelName, imageGenerationOptions) doesnot support dall-e-2 ,how to solve this?

@mssfang PTAL

any solutions?

Hi, @fengsuxing Sorry to replay it late. I just get back from my vocation.
We do support DALL-E ("dall-e-2" or "dall-e-2") in the SDK.  Wondering which region of Azure source you are using?

@mssfang in 1.0.0-beta.8, client.getImageGenerations(deploymentOrModelName, imageGenerationOptions)  doesnot support "dall-e-2".if you think it supports,please give me an example on how to Call  getImageGenerations using dall-e-2?

@fengsuxing You can try to use this sample in the repo
 OpenAIClient client = new OpenAIClientBuilder()
      .credential(new KeyCredential("your-openai-key-here"))
      .buildClient();

For Azure Resource, you can create DALL-E-3(dall-2 is in preview)
https://learn.microsoft.com/en-us/azure/ai-services/openai/concepts/models#dall-e-models


Update Kingmaker features data entry for branch parity

This won't be the "final" update to these, but most notably it refolders them and includes traits for the various tactics. The intent of this PR is mostly to avoid divergences in the data entry by avoiding having two versions of the compendium.

I think I did it correctly, but the build process is failing because it doesn't include the other files. Should I add the sheet to this?

Data Entry question, but if/once everything else has folders, how deep do we want to nest them?
If we do nest this deep, kingdom/kingdom-features should probably just be kingdom/features but I don't know if we should make the user open up two folders when the max number of folders will be around 6 anyways. Definitely a data entry question.

I really do think it should be kept to top level folders, otherwise the PR is fine by me.


Add property like useAutoStartUpAfterRefresh to disable listeners start on ContextRefresh event

Following discussion on stackoverflow: Spring AMQP Listener starts when autoStartup = false
Recently faced a weird issue with Spring AMQP @RabbitListener.
Listener was declared like this, so autostartup was set to false
@RabbitListener(id = "MqMessageHandler", queues = "${rabbitMQ.in-queue-name}", autoStartup = "false")
public void receiveMessage(Message message) {

After application is fully initialized and i get a response from some other service, i'm manually starting the listener like this
MessageListenerContainer mqMessageHandler = registry.getListenerContainer(HANDLER_ID);
mqMessageHandler.start();

But it appears that listener is still starting on context initialization.
Digging a bit in the code i found this piece of code inside RabbitListenerEndpointRegistry
	/**
	 * Start the specified {@link MessageListenerContainer} if it should be started
	 * on startup or when start is called explicitly after startup.
	 * @param listenerContainer the container.
	 * @see MessageListenerContainer#isAutoStartup()
	 */
	private void startIfNecessary(MessageListenerContainer listenerContainer) {
		if (this.contextRefreshed || listenerContainer.isAutoStartup()) {
			listenerContainer.start();
		}
	}

That means that listener will be started once ContextRefreshed event is fired.
I'd expect the condition to be
this.contextRefreshed && listenerContainer.isAutoStartup()
so && instead of || and then it should work as expected.
Does anybody knows if the condition is correct, and my assumptions are wrong?
Spring AMQP version is 2.3.1 but the same i saw in 2.3.10
As a workaround for now i'm registering listener manually like this
		MessageListenerContainer mqMessageHandler = registry.getListenerContainer(HANDLER_ID);
		if (Objects.isNull(mqMessageHandler)) {
			SimpleRabbitListenerEndpoint endpoint = new SimpleRabbitListenerEndpoint();
			endpoint.setQueueNames(inQueueName);
			endpoint.setMessageListener(this.mqMessageHandler);
			endpoint.setId(HANDLER_ID);

			registry.registerListenerContainer(endpoint, factory);
			mqMessageHandler = registry.getListenerContainer(HANDLER_ID);
		}
		mqMessageHandler.start();

Indeed, it is fine in your example. I'll will try to debug a bit more to find the root cause of my issue, and will update the description.

Correct; it is called from start() (which is called by the application context SmartLifecycle processing before the refreshed event is published).
If you are seeing it being called twice, please get a stack trace for the second call, so we can see what is calling it.


Is there a way to customize djoser url

My question is that is there any way to customize the djoser url. Like i want to use users/profile instead of users/me

I think a quick solution is to overwrite me action and basically replace the default url using url_path parameter.
That way internally the action is still me, which is important for determining serializer and permission.
    @action(["get", "put", "patch", "delete"], detail=False, url_path='profile')
    def me(self, request, *args, **kwargs):
        return super().me(request, *args, **kwargs)

Even though it'd be rather easy to allow a customization of this resource using settings, I don't think it's a good idea to allow it as users/me is a popular convention for REST API and users/<anything else> sounds like another resource.


Forward slash in css is ignored creating invalid names

Forward slash \ should  escape the next character in CSS file
Source: Repository
Branch: Main
Renderer: ReactUnityUIDocument
Example:
.button {
    color: white;
    background-color: rgb(59 130 246);
}

.hover\:button:hover {
    background-color: rgb(212, 0, 231);
}

Should be used as:
<button className="button hover:button">
     Text
</button>

Expected result: Button should change color on hover
Actual result: Nothing happens

Our CSS parser is an ad-hoc parser and there can be bugs like this, unfortunately. This one is fixed on main branch now. But I doubt this is the end of Tailwind related bugs. Let's collect Tailwind bugs under this issue.

I hope this is the last one for a while.
Property font-size: 100% results in size of the text to be 1px. Instead of 16px.

Also fixed.

::before and ::after are considered elements with computed size (font size seems to be directly related to their size) even if they are empty.
Tailwind uses them to remove some default HTML styling form browser.
In browser
With before and after:

Without

In Unity

_before, _text and _after have computed height of 20

By default in HTML width of the element is assumed "0" unless it has some content. For example text. Then this text decides the size of that content.
Here whereas height is somewhat correct, width is assumed to be the width of the screen. This is easily fixable with styling, but might cause some issues for pure conversions from some examples

Border radius (and maybe other properties?) Do not accept rem as a unit.
So eg: border-radius: 0.25rem doesn't work, whereas identical in function border-radius: 4px works as intended. Those two styles should behave identicaly

@Muchaszewski  some of these are inevitable differences between web and ReactUnity. Web has several different layout modes such as inline, block, flex, grid, table etc. For web the default is block/inline layout. ReactUnity only has flex.  And ReactUnity's implementation of flex is also different from web. Also we have different defaults. For example the flex-direction is column by default. ReactUnity uses the defaults of Yoga, the layout engine we use.
Tailwind isn't aware of that and so that is why you are having problems. The before/after issue can be solved by setting the buttons flex-direction to row. And as you said you have incorrect width because element's width is stretched by default. You can change defaults in your CSS as:
* {
  flex-direction: row;
  align-items: start;
  justify-content: start;
}

We could also code different layout modes in the future but this is the least priority right now. Although web has so many different layouts, most of them can be emulated with flexbox layout. There are cases when each layout has its advantages though. For example, inline/block layout is best when text is more prevalent, or table layout is good for showing tabular data. For now, users will need to be aware that 1-to-1 conversion from web to ReactUnity is not possible and they need to watch out for layout differences.
One thing we can fix is setting the width/height to 0 if text content is empty. I will check how it works.
As for border-radius, I will fix it. I think it can because it is a shorthand and our shorthand implementation is not too good to accept different units yet. Separate properties may work.


Car Collisions issue after export

I've attached a video as I'm not entirely sure how to explain this one.. but basically, the collision either shifts downwards or gets bigger when you export the car model.
I've had this issue with more than the vehicle provided, so it's not just tied to this model. - I'm assuming people/I didn't notice it on other vehicles that are higher off the ground.
https://onslaught.ca/s/jpvqyAjm.mp4
I didn't provide the XML's in this one as it was apparently too big to upload.
CarColIssue.zip

Euh, I personally didn't download it but it does look like the same model!
I was also testing on 2.0 + Blender 3.6.2
Similar to my other issue(#737 ), some people got it and some people didn't, not too sure why. I'm hoping Alex gets the issue and can investigate. But I'll assume for the time being that collisions aren't being calculated properly on export. I could be way off tho.

The new version of Codewalker seems to have resolved this issue. CW Dev45

Skill issue


docker build --net=host

docker -g /data/docker -H unix:///var/run/docker.sock -H tcp://<IP_ADDRESS>:14040 -b none
docker build can't use host network, how to resolve it

If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
For more information about reporting issues, see CONTRIBUTING.md.
You don't have to include this information if this is a feature request
(This is an automated, informational response)

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

This is a duplicate of #10324
And there is a pr #20987 work on this


Not using Long Polling?

Hello
I enjoyed reading your blog post and it lead me to this repository. Thanks for providing a very interesting solution.
I do have one question though.
In my research of the AWS SDK for SQS, it seems that to enable Long Polling, the ReceiveMessage function needs to be called with the ReceiveMessageInput.WaitTimeSeconds parameter set to a non-nil and non-zero integer.
https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/sqs-example-enable-long-polling.html (scroll down to the "Enable long polling when a message is received" section)
https://docs.aws.amazon.com/sdk-for-go/api/service/sqs/#ReceiveMessageInput
As you are not setting ReceiveMessageInput.WaitTimeSeconds I think you are actually using short polling in your package
https://github.com/qhenkart/gosqs/blob/master/consumer.go line 151
		output, err := c.sqs.ReceiveMessage(&sqs.ReceiveMessageInput{QueueUrl: &c.QueueURL, MaxNumberOfMessages: &maxMessages, MessageAttributeNames: []*string{&all}})

Maybe this was by design for performance?
Thanks again, Mark.

@MarkSonghurst Thank you for your message and issues. I am pleased you took the time to take a look at the code and make an issue here.
There are two ways the documentation explains that long polling can be enabled](https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/sqs-example-enable-long-polling.html)

Modifying the Queue parameter (either on creation or after creation as the documentation explains)
As a one time parameter for a specific message (I'm fairly certain this option did not exist when I designed this library)

Docs:

You can do this(enabling long polling) by setting the ReceiveMessageWaitTimeSeconds parameter of a queue or by setting the WaitTimeSeconds parameter on a message when it is received.

In the Readme file in this repo. I go over the provisioning of the Queues, including setting up the WaitTimeSeconds to enable Long Polling as a default functionality of the queue.
While the SQS/SNS API allows for provisioning, it's a bit outside of the realm of this package is it's more of a driver to interface with existing SQS queues. In the project I developed this for, provisioning was handled separately via terraform, and was a one time set up for an environment.
To be honest, I'm not sure why AWS decided to make short polling the default instead of long polling. Their docs heavily suggest that everyone should use long polling. It's worth noting that every polling request to an SQS queue has a (very very small) financial cost, so short polling would also be 20 times more expensive than long polling


chore: 5944 - systematically using "upToDateProduct"

What

When products are being updated by the user, we keep a stack of all pending changes, in order to maintain an up-to-date product while the changes are uploaded to the server.
In some pages, in some rare widgets, we still used the latest downloaded product without applying the pending changes on top.
That's solved in this PR. Not really fixing a specific created issue, more like "hey I changed the product name and it's not immediately reflected on the edit packaging page, how come?"

Fixes bug(s)

Closes: #5944

Impacted files

edit_ocr_page.dart: replaced "widget.product" with "upToDateProduct"; used "barcode" getter
knowledge_panel_page.dart: replaced "widget.product" with "upToDateProduct"
nutrition_page_loaded.dart: replaced "widget.product" with "upToDateProduct"
product_image_gallery_view.dart: replaced "widget.product" with "upToDateProduct"
product_image_swipeable_view.dart: replaced "widget.product" with "upToDateProduct"

Codecov Report
Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 6.54%. Comparing base (4d9c7fc) to head (9be9b7a).
Report is 527 commits behind head on develop.

Files with missing lines
Patch %
Lines

..._app/lib/pages/product/edit_ocr/edit_ocr_page.dart
0.00%
7 Missing :warning:

...h_app/lib/pages/product/nutrition_page_loaded.dart
0.00%
5 Missing :warning:

...ib/pages/product/product_image_swipeable_view.dart
0.00%
2 Missing :warning:

...e_panel/knowledge_panels/knowledge_panel_page.dart
0.00%
1 Missing :warning:

...oduct/gallery_view/product_image_gallery_view.dart
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5951      +/-   ##
==========================================
- Coverage     9.54%   6.54%   -3.00%
==========================================
  Files          325     438     +113
  Lines        16411   24797    +8386
==========================================
+ Hits          1567    1624      +57
- Misses       14844   23173    +8329

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add support for AWS services

Context
Adding support for some commonly used AWS services like S3, SQS & SNS. Some customers have asked for this multiple times.
Alternatives
No alternative other than end users having to implement these.
Has the feature been requested before?
Yes
Please provide a link to the issue.
If the feature request is approved, would you be willing to submit a PR?
Yes / No (Help can be provided if you need assistance submitting a PR)
Yes

Added support for AWS services as part of the first cut of this repo.


Is that a Bug?

Hi le-yuan:
When I was operating the step
"python HGT_workflow_distant.py Nanorana_parkeri_SimID.faa",
I got a problem,which show below:
Taxid by BLAST: 7917
Taxid by BLAST: 13616
Alien index: 299.19
This is a HGT event
Accession_id: AAP36269.1
Evalue: 1.16e-130
Traceback (most recent call last):
File "~/HGT/HGTphyloDetect/main/HGT_workflow_distant.py", line 222, in
main()
File "~/HGT/HGTphyloDetect/main/HGT_workflow_distant.py", line 196, in main
taxid2name = ncbi.get_taxid_translator([ranks2lineage['phylum'], ranks2lineage['class'], ranks2lineage['superkingdom']])
~~~~~~~~~~~~~^^^^^^^^^^
Traceback (most recent call last):
File "~/HGT/HGTphyloDetect/main/HGT_workflow_distant.py", line 222, in
main()
File "~/HGT/HGTphyloDetect/main/HGT_workflow_distant.py", line 196, in main
taxid2name = ncbi.get_taxid_translator([ranks2lineage['phylum'], ranks2lineage['class'], ranks2lineage['superkingdom']])
~~~~~~~~~~~~~^^^^^^^^^^
KeyError: 'phylum'
Please tell me how to deal this problem. THANK YOU VERY MUCH!
BEST WISHES

After I changed the script in HGT_workflow_distant.py in order to ignore the problem "KeyError:'phylum'",I have found that when I got into the next step,it would be interrupted often by the problem like this"This is gene 3------------------
XP_018426332.1
Yes, blast file already exists, nice!
Attention: please check the gene accession id!"
Please tell me how to deal with it.Thanks!


Added an example for the manim colormap

Changelog / Overview
Added an example for the manim colormap

Motivation

Explanation for Changes

Testing Status

Further Comments

Checklist

[ ] I have read the Contributing Guidelines
[ ] I have written a descriptive PR title (see top of PR template for examples)
[ ] I have written a changelog entry for the PR or deem it unnecessary
[ ] My new functions/classes either have a docstring or are private
[ ] My new functions/classes have tests added and (optional) examples in the docs
[ ] My new documentation builds, looks correctly formatted, and adds no additional build warnings

Reviewer Checklist

[ ] The PR title is descriptive enough
[ ] The PR is labeled correctly
[ ] The changelog entry is completed if necessary
[ ] Newly added functions/classes either have a docstring or are private
[ ] Newly added functions/classes have tests added and (optional) examples in the docs
[ ] Newly added documentation builds, looks correctly formatted, and adds no additional build warnings

see here https://manimce--1242.org.readthedocs.build/en/1242/reference/manim.utils.color.Colors.html#colorexample


Update nx_actions.py, fixing a typo on example

Change parser.NXActionResubmit to parser.NXActionResubmitTable, according to correct OpenFlow action:
actions += [parser.NXActionResubmitTable(table_id=10)]

Coverage decreased (-0.002%) to 68.095% when pulling faffcb80d429d6aee7d8ad31d428ab8c952767ec on DiegoRossiMafioletti:patch-1 into 6f906e72c92e10bd0264c9b91a2f7bb85b97780c on osrg:master.

Coverage decreased (-0.002%) to 68.095% when pulling faffcb80d429d6aee7d8ad31d428ab8c952767ec on DiegoRossiMafioletti:patch-1 into 6f906e72c92e10bd0264c9b91a2f7bb85b97780c on osrg:master.


Send fetch requests for all page dict lookups in parallel

When adding page dict candidates to the lookup tree, also initiate fetching them from xref, so if they are not yet loaded at all, the XHR will be sent
We can then await on the cached Promise without making the requests pipeline
This has a significant performance improvement for load-on-demand (i.e. with auto-fetch turned off) when a PDF has a large number of pages in the top level /Pages collection, and those pages are spread through a file, so every candidate needs to be fetched separately
PDFs with many pages where each page is a big image and all the pages are at the top level are quite a common output for digitisation programmes
I would have liked to do something like "if it's the top level collection and page count = number of kids, then just fetch that page without traversing the tree" but unfortunately I agree with comments on #8088 that there is no good general solution to allow for /Pages nodes with empty /Kids arrays
The other alternative for fixing this use case is to simply not validate the last page at all, so pages can be loaded on demand. But that validation was added for good reasons, and this would also result in a bad experience if you didn't read the document from the front.

I also have a further commit that makes these PDFs render really fast but by using some "looks likely" measures of whether it's a PDF with everything in the top level, I will try and discuss that and see if you want it too.

Thanks for the patch; based on an initial look I've got some overall questions/comments here.

When adding page dict candidates to the lookup tree, also initiate fetching them from xref, so if they are not yet loaded at all, the XHR will be sent

This patch will thus trigger data-loading eagerly, rather than lazily as currently done, which seems like it might lead to unnecessary data-loading in some cases. Hence my immediate worry is how this will affect things, and thus if this is actually a good idea in the general case!?

This has a significant performance improvement for load-on-demand (i.e. with auto-fetch turned off) when a PDF has a large number of pages in the top level /Pages collection, and those pages are spread through a file, so every candidate needs to be fetched separately

The more important question is how it'll affect performance of the normal use-case, i.e. where the entire PDF document is loaded, since that's what e.g. the Firefox PDF Viewer does and this use-case is thus more important to us?

PDFs with many pages where each page is a big image and all the pages are at the top level are quite a common output for digitisation programmes

Given that no such PDF document was provided here, testing this becomes somewhat difficult.

This patch will thus trigger data-loading eagerly, rather than lazily as currently done, which seems like it might lead to unnecessary data-loading in some cases

It looks like the last page is always requested when loading a document (since this change https://github.com/mozilla/pdf.js/commit/d0c4bbd8287a58856c04b0e1201f64ddccf57199) which means we're always traversing almost the entire /Pages tree serially at the moment. (Indeed, that was the symptom I was trying to fix with this proposal.)
If the data isn't already loaded then this will cause all those /Pages and /Page nodes to be requested immediately via XHR instead, yes. My understanding is that when using streaming/auto-fetch, the data is already loaded by the time loadDocument is called and xref.fetchAsync won't cause another XHR, but maybe I've missed something.

Given that no such PDF document was provided here, testing this becomes somewhat difficult.

The samples I have are 50MB+ (and customer data, but they're from a public portal, I can probably get permission to share), do you want attachments that large?

This is the other alternative
https://github.com/mozilla/pdf.js/compare/master...richard-smith-preservica:pdf.js:rcs/assume-all-pages-in-top-level-when-likely?expand=1
But this is potentially opening up incorrect reading of weird PDFs (that had exactly 27 entries in /Pages.Kids and a /Count of 27 but they aren't actually 1:1) which you might be worried about.

It looks like the last page is always requested when loading a document (since this change d0c4bbd) which means we're always traversing almost the entire /Pages tree serially at the moment.

Yes, but since the patch wants to change the timing of this data-loading it's consequently important that we consider this properly to avoid any possible surprises later. (Especially since the patch seems targeted at a special case of "bad" PDF documents, i.e. those with large single-level /Pages trees.)

My understanding is that when using streaming/auto-fetch, the data is already loaded by the time loadDocument is called and xref.fetchAsync won't cause another XHR, but maybe I've missed something.

I don't believe that there's necessarily any such guarantees in general, it might not be the case with e.g. linearized PDFs.

This is the other alternative
https://github.com/mozilla/pdf.js/compare/master...richard-smith-preservica:pdf.js:rcs/assume-all-pages-in-top-level-when-likely?expand=1
But this is potentially opening up incorrect reading of weird PDFs (that had exactly 27 entries in /Pages.Kids and a /Count of 27 but they aren't actually 1:1) which you might be worried about.

Sorry, but I don't think that's really an option here:

This doesn't validate the data properly, as you already mentioned. This alone is enough (as far as I'm concerned) for that solution to be feasible.
It adds more "complexity" to a part of the code-base that's crucial to the correct function of the library.
Finally, it introduces unconditional asynchronicity for the "is page"-check.

Currently it appears that the patch doesn't even work though, I'll leave some inline comments below.

This doesn't validate the data properly, as you already mentioned. This alone is enough (as far as I'm concerned) for that solution to be undesirable.

That's fair enough which is why I split the two suggestions.
There is definitely a valuable use case here ("I want to quickly render something for a large PDF with all the /Pages at the top level"). If there's a better way to allow for that and not try to load the last page before rendering anything when disableAutoFetch is specified (for example using the condition in that suggestion as a validation rather than calling getPageDict at all in checkLastPage in that scenario) that would be fine too.
I joined the Matrix room too which might be better for that kind of unstructured chat? Or I could add an issue (I think others in a similar area were closed already) to add a discussion thread on here?

The risk with this patch, as I see it, is that it's trying to optimize for a "pathological" case of bad PDF documents with a very long single-level /Pages tree, perhaps at the expense of correctly structured PDF documents where the /Pages tree has multiple levels.
This could thus regress performance for proper PDF documents, when disableAutoFetch = true is set, by triggering more data-loading than necessary when trying to load a specific page.

If there's a better way to allow for that and not try to load the last page before rendering anything when disableAutoFetch is specified (for example using the condition in that suggestion as a validation rather than calling getPageDict at all in checkLastPage in that scenario) that would be fine too.

I unfortunately cannot imagine any way of doing that that would be generally safe, given all the ways real-world PDF documents can be (and often are) broken.

/botio test

This could thus regress performance for proper PDF documents, when disableAutoFetch = true is set, by triggering more data-loading than necessary when trying to fetch a specific page.

We're already guaranteed to attempt to load the last page, so all of the entries added to nodesToVisit will be inspected already. I don't think this patch results in any additional being loaded, though it does mean it happens more intensively.
If you want to restrict the scope, it could make sense to only do this preload for items in the top level /Pages container - it's probably reasonable to assume that if your PDF has a /Pages tree, rather than all the pages in the top level, the tree is structured and located in a way that makes the existing one-by-one load okay.

Those tests seem to have failed as a result of different anti-aliasing in rendering 🤔 unsure how this could have changed that

Cool, I'll push something tomorrow

/botio test


Thank you

I created this issue to say thank you, thank you for your contribution to the hackintosh user community, you have worked so hard on this repo. I use it on Thinkpad T430 everything works very well and stable, just need create a new SSDT-PM. Could you consider integrating YogaSMC into this EFI? I tried it but YogaSMC only works with Voodoops2controller from acidanthera. When switching to Voodoops2controller from acidanthera, the trackpad does not work well. Looking forward to your response.

Thanks for your feedback. I've tried implementing YogaSMC but it crashes the system during boot. Unfortunately, the TrackPad works really really bad with the new Versions of VoodooPS2Controller.kext, so it's pretty much unuseable for the T430/T530 at this point. So it's not going to happen.
If you need Fan Speeds and Stats, Adding SMCProcessor and SMCSuperIO.kext that come with VirtualSMC and installing https://github.com/CloverHackyColor/HWMonitorSMC2 should allow that.

I learned that yogaSMC depends on new VoodooPS2 to work, it won't start with VoodooPS2Controller by RehabMan. This happened to me too.

This is not the standard Rehabman Version! This is a modified and fixed version made compatible with OpenCore so it runs. OpenCore wouldn't even boot using the Rehabman-Version.
Like I said: TrackPad does not work well with the Acidanthera Version. So, if you need YogaSMC, implement it yourself, since I don't need it, but I need a working Trackpad! I can hear how slow or fast the Fans are running - so I don't need a monitoring plugin to tell me that.


Issue: Light bulb Moments 💡 Navigating this Site/Repo

Title

Navigating this Site/Repo
Elevator Pitch

At the very least, the navigation section in the README needs updating.
Justification

How does one know how to navigate the site and repo? The README has an outdated navigation section that is pulled into the site.
Unformed Thoughts

The section probably shouldn't reference the files and folders. There might also be need for two navigation sections: one for the README, and one for the site's navigation page... The section currently reads:
## Navigating this Repository
There are three folders and seven files at the top of this repository. The five most relevant files contain (and are called) [_A Glossary_](https://github.com/Ismael-KG/A-History-of-Research-Ethics/blob/a936ef6798379a8ab01a8a63bd0957d540032b33/A%20Glossary.md) – which will hold strange terms used throughout the timeline –, [_A Template for Stories_](https://github.com/Ismael-KG/A-History-of-Research-Ethics/blob/a936ef6798379a8ab01a8a63bd0957d540032b33/A%20Template%20for%20Stories.md) – which should be copied and pasted into new files containing stories –, [_About this Timeline_](https://github.com/Ismael-KG/A-History-of-Research-Ethics/blob/a936ef6798379a8ab01a8a63bd0957d540032b33/About%20This%20Timeline.md) – maintaining the text that is shown when you open the Timeline for the first time -, and [_Protocols_](https://github.com/Ismael-KG/A-History-of-Research-Ethics/blob/1cb0f503b550e452d04b868ae1cf274731be4849/Protocols.md), which includes Protocol 1: Code of Conduct.

The three folders contain:
* **Stories** that I am generally happy with. They can definitely gain from a review and further detail, but they are not a priority.
* **Stories in Progress**, which are new and unpublished. This is where ideas for further stories will appear.
* **Published but needs improving** are the stories I wrote between mid-September and 16-Oct and which were not even written as stories! They are excerpts from a much longer text I wrote using HackMD. These are the ones that might gain from "easy fixes." Perhaps a link to some media will help, or comments with further resources.

[ ] Update "navigate this repository" in README
[ ] Create a tip-for-navigation section for the github.io site
[ ] Make conceptualisation issues for all WIP-stories so there are links to send potential contributors to as per this comment in PR #46

Issues for all legacy stories now made. Just missing issues for stories-in-progress stories.


--tray start-in-tray, --width, --height not working in Windows

i'm a nativefier noob so i'm not sure if that is the intended effect... i can't get start-in-tray to work at all, nor the width or height. the "start-in-tray" modifier especially messes with the entire operation and ends up making a subfolder for the app called start-in-tray.

You might be that you are using
nativefier https://example.com/  start-in-tray instead of
nativefier https://example.com/ --tray <<< the correct command
--tray enables the tray option
putting start-in-tray after the website url will create a folder named start-in-tray

Can you provide the exact command you are using?

nativefier "https://<IP_ADDRESS>:8741/" --n X --i X --width X --height X --tray start-in-tray
if i try just --tray, it doesn't even have the option to go in tray at all, but if i write start-in-tray it goes to tray when clicking the close button but it doesn't start in tray at all

@kariyna what OS are you using? Windows? Which version?

I have confirmed @kariyna initial bug on my Mac. I will have a fix son.

@TheCleric sorry for the late reply. i'm using windows 10. i thought it might have something to do with the particular URL i was trying to access but since then i've tried creating multiple apps with different URLs but its always the same result, it never starts in tray.

I will have a fix for the tray issue shortly, but the width and height may be a little more complicated.
Width and height DO work, but have a big caveat to them that may be unexpected. Each app maintains a cache of the window state (position, width, etc.) between executions. This state is maintained even across builds (as long as the app name stays the same). So what happens is if you generate the app without a width/height or change its width/height, that size gets saved. And when you build next time with a new width/height, then the cache will be found and reused. For many users this is the desired behavior (in the sense that they don't want to have to fiddle with window sizes after every update (for a distributed app).
So here's a few options for you in this instance:

If you want to delete the current saved state that is present, it should be in %APPDATA%\<app_name>-nativefier-<random_6_digit_code>\window-state.json
If you want to LOCK the width at a certain value (i.e., no resizing allowed), set the --width, --maxWidth, and --minWidth to the same value as the locked width, and --height, --maxHeight, and --minHeight to the same value as the locked height.
If you don't want the app to keep this window state between builds, you can use the --portable flag to keep all settings in the app folder, but be aware that there are some things to be aware of when using this flag: https://github.com/nativefier/nativefier/blob/master/API.md#portable


Writing full page component

We have an exiting PWA, there are some routes that render components using RNW.
Is it possible to write an NPM module that is a full page size component and import in an existing PWA and run it using RND?
Or, differently put how to integrate with an existing PWA such that few pages render with RND?

While it's certainly a possibility, due to the massive bundle sizes produced from this project I don't think it's going to be a priority to support incremental adoption for the time being.

How big are the bundle sizes right now?

Hello world clocks in at around....500kb....gzipped (lol)

Will bundle sizes eventually be smaller?

Hopefully yeah, I think the biggest win could come from metro adding DCE/tree shaking, but it would be also cool if we could investigate if it would be possible to do tree shaking across a web worker

Why not make the production build with webpack? Dev experience can still be great using metro.

Webpack would need to understand the haste @providesModule annotations because that's how this project selectively overrides core components

Found this tool for building react-native apps with webpack: https://github.com/callstack/haul


Added new Contributor Ritwik Mehta

This commit adds new CodeforCause Contributor -Ritwik Mehta.

Done as requested Mam.

Made the changes in the string.


[NERDTree] "Press ? for help" appear in the wrong buffer

Hi! First, let me thank you a lot for your awesome GUI, even if it is still in development/beta, it looks really cool (I tried first Nyaovim, and was a bit disappointed x) ).
Now, when I open neovim, I have automatically NERDTree opened, but there is a little graphic issue when using Oni:

When I write on the buffer, it replaces these letters, so it really looks like a graphical issue as it is not in the buffer. I have updated to the latest npm package for oni, and for neovim and NERDTree too
(By the way, I am on Linux Mint 18)
Here is my .vimrc if you need https://github.com/Ilphrin/.vim/blob/master/vimrc

Hi @Ilphrin ! Thanks for the kind words!
Yes, this definitely looks like a rendering bug. I believe I hit this on Windows too on startup - it seems like the beginning of the first line is always problematic. It might be we're missing or not handling one of the neovim msgpack-RPC actions correctly.

 When i'll have time, i'll try to give some help on Oni, this really deserves more hands =D
BTW, when i run Ctrl+L it is refreshing the page and the glitch doesn't appear anymore, as my NERDTree is has a plugin to be launched in every tab and on startup, maybe it is because the browsers draws too soon the content? (Just suppositions, I don't know a thing about what's is happening!)

Awesome, would be great to have the help! :)
I just checked out this issue... It looks like it was a bug that was caused by a couple of contributing factors:

On startup, we would tell Neovim that we had a fixed size screen (80 cols x 40 rows), and then we would always resize to the proper size based on the font afterwards
During resize, Neovim sends a CLEAR action via the msgpack-rpc API. For that action, the cursor position wasn't being reset - so after clearing, it would just start rendering the first line whereever the cursor had been previously. So that was the root problem, and easy to fix.

Should be addressed now by PR #115


Generate without symbols

Hi.
I set the config to use symbols to generate the passwords but sometimes I want to generate passwords without symbols because of website limitation.
pass has an option --no-symbols but gopass does not seem to have it.
Could you please add this cli option?
Thanks.

Hi,
thanks for reporting this issue. Actually there is a symbols flag which can be set to true or false.
Right now there is a small issue with that flag, but I'll submit a PR to fix it in a second.

@dominikschulz so if the config is set to use symbols, how can you override this from the command line, does passing -s which "double sets" symbols toggle it back off when the config file has it enabled?

I think an additional couple of tests in https://github.com/justwatchcom/gopass/blob/master/pkg/action/generate_test.go around the symbols behavior would be excellent as currently it appears there isn't any testing of that functionality.

Good idea. We'll add some.
As for your question @dragon788 : The command line switch will override the config option.
See https://github.com/justwatchcom/gopass/blob/master/pkg/action/generate.go#L122 for the implementation.


Fix clippy

Remove clippy warning messages
Add #[allow(clippy...)] in places where it might be better not to fix

TODO
recommended changes by cargo fmt on my local and github differs on sqlite3/src/lib.rs. Should check for the reason
=> just upgrade the rust toolchain

recommended changes by cargo fmt on my local and github differs on sqlite3/src/lib.rs. Should check for the reason

I upgraded my rust toolchain and that went away

I found that tests::test_sequential_write is super slow on my local mac. Maybe we should reduce the max_iterations and separate the tests to use different files(test.db)

Update the long running test tests::test_sequential_write to iterate 1000(from 10_000).
Also multiple tests seem to be tightly coupled together by using the same file(test.db). I've updated those tests to use independent files.

Should we include cargo test into make test ?

Should we include cargo test into make test ?

good idea imo

@jussisaurio I'll add the cargo test to make test when max_iteration is updated to have shorter running time.

@seonWKim Can you rebase this on top of main so that we get a clean run on the CI (I fixed some issues in main)?

Hi @penberg rebased to main 🚀


add feature for fixed client IP Address？

If I want to set up a network, I really want to fix the client's ip address.
Would you please add this feature？
Like this：
http://backreference.org/2009/11/15/openvpn-and-iroute/

No, sorry


More lenient lookups cross-linking

When using backticks, ddox will cross-link between symbols within the same module. But to cross-link to a symbol in a different module, the fully-qualified name must be used. This can lead to excess verbosity in the documentation, so it would be really nice if non-fully-qualified symbols (if not found in the current module) are still looked up in other modules (at least if they're not ambiguously found in more than one other module).

That could lead to some surprising results, if, for example, a local variable has the same name as a symbol of a foreign module*. At least without semantic analysis there would be no way to tell which of the two is meant.
But maybe instead of just searching for any symbol, a good approximation would be to follow the import statements in the documented module/container (I think the JSON output contains those). That should cover most cases and due to the anti-hijacking semantics should be safe from making the wrong guess.
* To be fair, the same rule is already used when looking up base classes/interfaces, so if this is implemented in improved form, that code should also use the improved approach.

That could lead to some surprising results, if, for example, a local variable has the same name as a symbol of a foreign module*. At least without semantic analysis there would be no way to tell which of the two is meant.

Yea, that's why I was thinking:

Only look in other modules if it's not found in this one.

If it's not in the current module, but IS in several other modules, then just dont bother linking unless there's some goos way to know which is correct.

The other way around is now implemented: A fully qualified name will have its module path prefix stripped in the documentation (hovering over the link will still show the FQN).
Another safe improvement would of course be to follow import statements, which are included in the JSON output (not sure whether that has always been the case).


Add definitionChanged test into EntitySpec

Description
I am back to contribution after 6 years. We plan to contribute to cesium with my colleague. I added a unit test for this issue first, but it did not fail. I think the issue is fixed with a side effect in the past.  It is better to merge the test with the code. That is why I opened this PR.
Issue number and link
Fixes #2562
Testing plan

Author checklist

[x] I have submitted a Contributor License Agreement
[x] I have added my name to CONTRIBUTORS.md
[ ] I have updated CHANGES.md with a short summary of my change
[x] I have added or updated unit tests to ensure consistent code coverage
[ ] I have update the inline documentation, and included code examples where relevant
[x] I have performed a self-review of my code

Hi @ggetz,
We signed the CLA but the CLA check action still fails.

This looks good to me! Thanks for confirming the issue and authoring a unit test @ateshuseyin.


Next chunk of Firestore work

Again, reviewing one commit at a time will probably be easiest.

Very confused by the GeoPoint failure. Will look into that. I've deliberately used values that are exactly representable in doubles, so that shouldn't be a problem.

I'm really confused as to why the equality tests are failing for GeoPoint, and only on Linux. Will try to reproduce on a local box.

Have reproduced GeoPoint failure locally on Linux (but still not on Windows). Weird. Delving deeper.

Yay - fixed the issue. Have blogged about it:
https://codeblog.jonskeet.uk/2017/10/08/diagnosing-a-linux-only-unit-test-failure/
It's a very weird issue, and I want to try to find the coreclr bug to check I'm addressing it appropriately.


Submission issues

Change request.form to request.json, form doesnt get the data because its given through json = {...}, not for post because files are given... why is this not the same !?
Return bad request when encountering invalid keys in request.json for post (already returns 400 because files arent given in tests) and patch
Filtering on get /submissions with an unknown parameters should return 400
Filtering on get /submissions with an not existing uid or project_id should return 200 and [] instead of 400
Get /submissions submission_id returned is https://api/id
Change the returned data from patch /submissions/id

Keeping request.form, cant use both, files are needed so for conisistency we will be using this since its does the same


Use debian jessie raspbian

A debian jessie version of raspbian has now been released and we should use this as the basis for the next version of musicbox.

Worth noting in particular that the default boot behaviour is to start a desktop GUI and automatically log in as 'pi' user. This systemd magic can be disabled as seen at https://github.com/raspberrypi/rc_gui/blob/master/raspi-config#L671

Yep, that would be great :)

Has any work been done on this yet? Perhaps we can add a separate branch to the official repository so that members of the community can contribute towards this goal?

I've been stabbing at it every so often (for about 6 months!?...wow) and my local branch ended up in a mess. I've (finally) got 3 days of holiday coming up and I'll push the sane bits I find. I've been meaning to do it for ages, I just need prodding -  thanks.

A small side note, there seems to also be a lite raspbian prebuilt image for jessie, which might serve as a nice base if not going the debbootstrap route.

AFAIK, using the minimal prebuilt Raspbian Jessie image is the current plan.

Hi.  I realise this is a dormant issue, but I was wondering if it's still the plan to move to the Jessie Lite image as a base.  I saw a commit on the develop branch a week or so ago switching from pip-installed mopidy and extension components to proper packages (https://github.com/pimusicbox/pimusicbox/commit/fda1bef6a5dea3d9179485cda042104fb98c29d6) but another a few days ago going back to pip because the packages for Wheezy are too old (https://github.com/pimusicbox/pimusicbox/commit/68c2d6b48da85d3eb74f27a333288dd4b224fbb3).
This kind of thing might be easier if the image were based on a current version of the underlying distro.  I would also expect it to be less effort to wrap anything we want to use that's not currently shipped as a .deb in a rudimentary stdeb-produced package if we were targetting Jessie (and Stretch in due course).
I do think there's a lot of merit in shipping PiMusicBox as a plug-and-play system image rather than a metapackage on top of Raspbian.  My ideal of the build process would be a completely automated:

download the raspberrypi.org current official Lite image
chroot into it
purge anything we really don't want/need
hook up some extra apt repos
install all the stuff we need, including our own scripts and default config, as .deb packages
clean up, unmount, compress

Has someone already tried this and discovered I'm being hopelessly naive?

Yes it would be a lot easier but have been many changes in Raspbian since the release of pimusicbox 0.6 and just sticking our existing file changes on top of the latest Raspbian lite image does not produce anything useful. I've did some (maybe all, I don't remember) of the fixes in the 1.0 branch.
What you've described is the plan, the deb part is described in another issue on here somewhere. It's then trivial to automate it for use with Travis (via Docker and QEMU). With the exception of maybe using pi-gen rather than the actual base Raspbian lite images. I've done some of this in my local branch which I need to push (and ideally cleanup).
Most recently, I've just been trying to get a new image out quickly to finally support all the new Raspberry Pi versions. And give a bit of breathing space to then continue working on v1.0. The quickest way to do that (without having to test the world) is to just build on the v0.6 image. Sadly,as those commits show, it's a bit of a mess.

Thanks for the swift reply.  I wouldn't expect blasting the 0.6 scripts onto a Jessie image to work; my point was more that basing off Jessie should provide a way to support newer hardware (#257) and get access to a more current set of upstream packages.
I've not used pi-gen but it looks like an elaborate wrapper around debootstrap, which I have.  Are you thinking its "Stage 1" absolutely minimal system would be cleaner and smaller than "Stage 2" which apparently is Raspbian Lite?  Although if 800MB is "Lite" I don't need to worry about my diet ;-)
I did see the "everything should be .deb" issues (#16, #308) and I definitely think that's worth doing - IMLE mixing pip with distro packages frequently ends in tears.  My ulterior motive is that I want to do some integration with mopidy-ircontrol and not mess around managing dependencies by hand.
There are always going to be different priorities (eg personally I don't care about supporting Pi 1, or 1GB SD cards, or Spotify, since I have none of those things) so for many users getting newer versions onto a known-good base is clearly the right thing to do.
I'll take another look at the 1.0 branch an see if I can build anything useful off it.

I think we are on the same page here and have the same goals. I don't think
you can even buy SD cards that small these days!
That branch is as good as dead, it was just a first attempt at migrating
the scripts (and the custom settings, some of which no longer apply/makes
sense). I'm away right now but I will (try again to) push the local stuff I
have when I return.
On 5 Mar 2017 5:14 p.m., "duncangibb"<EMAIL_ADDRESS>wrote:

Thanks for the swift reply. I wouldn't expect blasting the 0.6 scripts
onto a Jessie image to work; my point was more that basing off Jessie
should provide a way to support newer hardware (#257
https://github.com/pimusicbox/pimusicbox/issues/257) and get access to
a more current set of upstream packages.
I've not used pi-gen but it looks like an elaborate wrapper around
debootstrap, which I have. Are you thinking its "Stage 1" absolutely
minimal system would be cleaner and smaller than "Stage 2" which apparently
is Raspbian Lite? Although if 800MB is "Lite" I don't need to worry
about my diet ;-)
I did see the "everything should be .deb" issues (#16
https://github.com/pimusicbox/pimusicbox/issues/16, #308
https://github.com/pimusicbox/pimusicbox/issues/308) and I definitely
think that's worth doing - IMLE mixing pip with distro packages frequently
ends in tears. My ulterior motive is that I want to do some integration
with mopidy-ircontrol and not mess around managing dependencies by hand.
There are always going to be different priorities (eg personally I don't
care about supporting Pi 1, or 1GB SD cards, or Spotify, since I have none
of those things) so for many users getting newer versions onto a known-good
base is clearly the right thing to do.
I'll take another look at the 1.0 branch an see if I can build anything
useful off it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pimusicbox/pimusicbox/issues/324#issuecomment-284244281,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA5DqPEhM1Mmao7SWx5pCH1LH_Y5aMVYks5riu1rgaJpZM4GGjxk
.

I'm also interested in this. I'd like to use my Pi both for MusicBox and RetroPie, but it does not seem possible at the moment because RetroPie requires Jessie. I understand it's not that easy. Is it still on the roadmap?

It's been on hold during 0.7 development but that's coming to an end
(finally). Yes, it's next up, perhaps the next actually image release will
be stretch but the software should be compatible with jessie too.
On 25 Aug 2017 1:02 a.m., "xavierpeich"<EMAIL_ADDRESS>wrote:

I'm also interested in this. I'd like to use my Pi both for MusicBox and
RetroPie, but it does not seem possible at the moment because RetroPie
requires Jessie. I understand it's not that easy. Is it still on the
roadmap?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pimusicbox/pimusicbox/issues/324#issuecomment-324789167,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA5DqD1-QLIu88FXmxlRL7kqCMUwnInsks5sbg71gaJpZM4GGjxk
.

Is there any news on this? Also I'd be happy to help out, though I am still a novice when it comes to building images for RPI.

Well I guess it's outdated as we will obviously leapfrog jessie and go straight to stretch. Is there something in particular you need jessie/stretch for?

s/jessie/buster/ by now. This would also allow us to choose between a pure debian and a raspian.


Add dockerfiles for the conda package builds

I'm not 100% sure what the procedure to add new docker images is.  I figure I need to get the images added to docker hub under tvmai and then use the tags for those images in the Jenkinsfile.
I've tested the commands to ensure that building the docker images and running the builds in them works, but I can't upload the built images to the tvmai docker hub myself.
@tqchen

This current failure seems like a fluke.

Don't merge this, I discovered some problems in the resulting packages.  I'll fix those problems and add some automated testing of the resulting packages.

Ok now it seems to be good.  There are some major changes that I'll explain after.  The main point is that this introduces new Dockerfiles for the build and those have to be cached.  I think I can't do that part myself.
Once that is done, I will update the Jenkinsfile so that the packages are actually built as part of the tests so we know they are good and don't keep breaking :)
As for the changes, the tvm, topi and nnvm python packages are now a single package.  This is because the there are some parts of tvm that depend on topi.  It doesn't change the way the source is organized, only that there is a single conda package for all of them.
I've bumped the conda version to 0.6.0dev1 since I want to make sure that there will not be old topi/nnvm packages left behind to conflict with the new ones.  This will fix itself when 0.7.0 comes around.
This also enables support for Metal in the OS X builds.

Can I get a review of this?  It is done now. @tqchen

@mshawcroft please https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly

THanks, @abergeron , this PR is now merged


New Android code specification requires cleanup

https://github.com/pffy/android

field naming conventions

remove versions from Android resource value XML

remove comments from arrays_pnra.xml... causing trouble with R.java (break it up, you two)

fix layouts to meet: https://github.com/pffy/android#resource-layouts

remove public METHOD getKey, no longer needed


Error: The match is locked. How would you update a match?

        { matchGames.map((m) =>

            { m?.opponent1?.id } vs { m?.opponent2?.id }
	    <input name="" type="number" value="" />
	    <input name="" type="number" value="" />
	    <button onClick={() => {

              m.opponent1.score = 3;
              if(m.opponent2)
                m.opponent2.score = 2;

              manager.update.match(m)

              render();
            }}> Submit Score </button>

        )}

So, I want to update the scores as a manager/organizer. It says it's currently locked. or Where should I be handling the matches?

So, I found out that I was trying to update a match with one of the opponents BYE in it. Here is the change, I made just so anyone would find it helpful.

              if(m.status === Status.Locked) {
                console.log(m.status);
                return;
              }

              let score1 = opponent1[index]?.current.value || 0;
              let score2 = opponent2[index]?.current.value || 0;

              await manager.update.match({
                id: m.id,
                opponent1: { id: m.opponent1.id, score: score1, result: score1 > score2 ? 'win' : 'loss' },
                opponent2: { id: m?.opponent2?.id, score: score2, result: score2 > score1 ? 'win' : 'loss' }
              })

              const data = await manager.get.tournamentData(1234);

              render();

The BYE could be in both opponent1 and opponent2 so I suggest you do the following change:
              if(m.status === Status.Locked) {
                console.log(m.status);
                return;
              }

              let score1 = opponent1[index]?.current.value || 0;
              let score2 = opponent2[index]?.current.value || 0;

              await manager.update.match({
                id: m.id,
-               opponent1: { id: m.opponent1.id, score: score1, result: score1 > score2 ? 'win' : 'loss' },
+               opponent1: { id: m?.opponent1?.id, score: score1, result: score1 > score2 ? 'win' : 'loss' },
                opponent2: { id: m?.opponent2?.id, score: score2, result: score2 > score1 ? 'win' : 'loss' }
              })

              const data = await manager.get.tournamentData(1234);

              render();

Okay sure. Thanks for the update!


tools: create //tools/config_validation:textproto2yaml helper

Commit Message: tools: create //tools/config_validation:textproto2yaml helper
Additional Description: A helper than can convert textproto files to yaml, and format them as // .. validated-code-block:: yaml fragments.
Usage example:
bazel run //tools/config_validation:textproto2yaml -- --as_fragment \
  envoy.config.bootstrap.v3.Bootstrap \
  $PWD/tools/testdata/config_validation/input.textproto

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@sergiitk my reservation with this PR is that im strongly discouraging use of code-block validated or otherwise for config snippets in the docs - encouraging instead the use of literalinclude and full boostrap configs
the reasons being:

a full (bootstrap) config is almost always more useful to an enduser (ie avoids yaml indent hell)
in Envoy CI boostrap yaml config files are more fully validated (they are run through a server start in addition to protobuf validation)

@phlax It seems that the failing presubmit is irrelevant to this change I'm making. Let me know if there's anything else I can to do to help with reviewing this.

/retest

will review more thoroughly tomorrow...

Yes, a bit busy at the moment. I'll try to get back to this next week.

Planning to follow up on this tomorrow.

Unfortunately, validate_fragment.py evolved way to far for this PR to be useful. Most of the refactoring I had is now useless because message parsing / yaml loading is moved to https://github.com/envoyproxy/pytooling/blob/0a6f245fb0f7424e22d9e8dfa6339c944c5584ca/envoy.base.utils/envoy/base/utils/abstract/protobuf.py.
Now it might make more sense to start over and redo this using new APIs provided in envoy.base.utils. I'm going to need to find more time to come back to this.


Falsey fields cause apply to patch resources when they haven't changed

Bugs should be filed for issues encountered whilst operating cert-manager.
You should first attempt to resolve your issues through the community support
channels, e.g. Slack, in order to rule out individual configuration errors.
Please provide as much detail as possible.

Describe the bug:
RoleBinding.cert-manager-cainjector:leaderelection has subjects.apiGroup set to an empty string. Similarly, Deployment.cert-manager-cainjector has spec.template.metadata.annotations set to a null value. These two patterns occur in other resources too.
I'm using https://github.com/jetstack/cert-manager/releases/download/v0.11.0/cert-manager.yaml as reference.
When applied, this causes kubectl to consider these resources always modified, so they get configured every time instead of unchanged.
Please see https://github.com/kubernetes/kubernetes/issues/66450#issuecomment-554560301 for a lot more info.
Expected behaviour:
This may be an issue on k8s, but until it's fixed, we could remove these empty annotations and fields.
Steps to reproduce the bug:
Just apply https://github.com/jetstack/cert-manager/releases/download/v0.11.0/cert-manager.yaml in sequence in a fresh environment. Use -v 8 to see the patch commands.
Anything else we need to know?:
Environment details::

k8s Client v1.14.3
k8s Server v1.13.11-gke.14
On GKE
Installing using static manifests

/kind bug

Thanks for raising this - makes sense to me. Let's remove these fields - the 'source' for these files is deploy/charts/, so we should be good to amend them here!
/area deploy
/good-first-issue


Add null check before accessing packetWriteMap

Fixes #951
This PR is ready for review.
Risk
This PR makes no API changes.
Summary

Added a null check before accessing offending variable

Changelog
Bug Fixes

Prevent NPE during a router service shutdown

CLA

[x] I have signed the CLA

Codecov Report

Merging #957 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             develop     #957      +/-   ##
=============================================
- Coverage      42.55%   42.55%   -0.01%
  Complexity      3735     3735
=============================================
  Files            434      434
  Lines          23098    23099       +1
  Branches        2698     2699       +1
=============================================
  Hits            9829     9829
- Misses         12623    12624       +1
  Partials         646      646

Impacted Files
Coverage Δ
Complexity Δ

...om/smartdevicelink/transport/SdlRouterService.java
7.19% <0%> (-0.01%)
9 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d329a1...0f3746a. Read the comment docs.


Make RecordEnricher extend RecordTransformer

Address #13049
Another attempt after #13086 and #13704

Make RecordEnricher extend RecordTransformer
Integrate RecordEnricherPipeline into CompositeTransformer
Add API RecordTransformer.getInputColumns() to return the required input columns, and simplify IngestionUtils.getFieldsForRecordExtractor()

Incompatible
RecordTransformer is moved to pinot-spi module: org.apache.pinot.spi.recordtransformer
RecordEnricher is moved from org.apache.pinot.spi.recordenricher to org.apache.pinot.spi.recordtransformer.enricher

Codecov Report
Attention: Patch coverage is 36.60714% with 71 lines in your changes missing coverage. Please review.

Project coverage is 55.51%. Comparing base (59551e4) to head (09c5d51).
Report is 1428 commits behind head on master.

Files with missing lines
Patch %
Lines

...ache/pinot/segment/local/utils/IngestionUtils.java
18.75%
23 Missing and 3 partials :warning:

...rdtransformer/enricher/RecordEnricherRegistry.java
0.00%
12 Missing :warning:

...local/recordtransformer/ExpressionTransformer.java
0.00%
8 Missing :warning:

.../local/recordtransformer/CompositeTransformer.java
75.86%
6 Missing and 1 partial :warning:

...gment/local/segment/creator/TransformPipeline.java
20.00%
3 Missing and 1 partial :warning:

...a/manager/realtime/RealtimeSegmentDataManager.java
40.00%
3 Missing :warning:

...nricher/function/CustomFunctionEnricherConfig.java
0.00%
2 Missing :warning:

...spi/recordtransformer/enricher/RecordEnricher.java
0.00%
2 Missing :warning:

...l/realtime/converter/RealtimeSegmentConverter.java
0.00%
1 Missing :warning:

...ocal/recordtransformer/ComplexTypeTransformer.java
66.66%
1 Missing :warning:

... and 5 more

:exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (09c5d51). Click for more details.
HEAD has 48 uploads less than BASE

Flag
BASE (59551e4)
HEAD (09c5d51)

integration
7
0

integration2
3
0

temurin
12
2

java-21
7
2

skip-bytebuffers-true
3
1

skip-bytebuffers-false
7
1

unittests
5
2

java-11
5
0

unittests2
3
0

integration1
2
0

custom-integration1
2
0

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14601      +/-   ##
============================================
- Coverage     61.75%   55.51%   -6.24%
- Complexity      207      704     +497
============================================
  Files          2436     2114     -322
  Lines        133233   111550   -21683
  Branches      20636    17718    -2918
============================================
- Hits          82274    61926   -20348
+ Misses        44911    44723     -188
+ Partials       6048     4901    -1147

Flag
Coverage Δ

custom-integration1
?

integration
?

integration1
?

integration2
?

java-11
?

java-21
55.51% <36.60%> (-6.12%)
:arrow_down:

skip-bytebuffers-false
55.48% <36.60%> (-6.27%)
:arrow_down:

skip-bytebuffers-true
55.45% <36.60%> (+27.73%)
:arrow_up:

temurin
55.51% <36.60%> (-6.24%)
:arrow_down:

unittests
55.51% <36.60%> (-6.24%)
:arrow_down:

unittests1
55.51% <36.60%> (+8.62%)
:arrow_up:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Issues with search input on blocks page

Which network is that happening?
Mainnet, Sepolia
Which Explorer is that Bug happening?
Staking
🙂 Expected behavior
When in light mode, the search text is in color that is in good contrast with the background, for example gray.900.
🫠 Actual behavior
When in light mode, the search text is the same color as the background and it's not visible.
🧪 Minimal test case

Open the staking app
Switch to light mode
Go to /blocks page
Type some text in the search input

📄 Extra information
No response

Additionally, I think we should also change the placeholder text for the search from Search to Search by producer to make it clear what type of text you need to insert in the search input.

Hi, @brunomenezes , please let me know if this was the issue you mentioned about the blocks search on our last call.


Invoke does not trigger before/after tasks

Deployer version: 7.0.2
Deployment OS: MacOs

task('invokeSomething', function() {
    invoke('anotherTask');
});

task('anotherTask', function() {
    writeln('Another Task');
});

task('beforeTask', function() {
    writeln('Before Task');
});

before('anotherTask', 'beforeTask');

This is new v7 logic.

You mean thats the desired behaviour?
Is there a way to trigger a task inside another task with before and after logic?

Not right now. I'm thinking of adding param to enable it.
invoke('task', hooks: true);


After updating python now I am having issues with Spyder

After updating python to solve an earlier issue I am now receiving this launch error when I try to open spyder. The error prevents me from even opening the application.
Problem Description
Traceback (most recent call last):
File "/anaconda3/bin/spyder", line 7, in
from spyder.app.start import main
File "/anaconda3/lib/python3.6/site-packages/spyder/app/start.py", line 27, in
from spyder.config.main import CONF
File "/anaconda3/lib/python3.6/site-packages/spyder/config/main.py", line 22, in
from spyder.config.user import UserConfig
File "/anaconda3/lib/python3.6/site-packages/spyder/config/user.py", line 26, in
from spyder.utils.programs import check_version
File "/anaconda3/lib/python3.6/site-packages/spyder/utils/programs.py", line 18, in
import subprocess
File "/anaconda3/lib/python3.6/subprocess.py", line 136, in
import _posixsubprocess
ImportError: dlopen(/anaconda3/lib/python3.6/lib-dynload/_posixsubprocess.cpython-36m-darwin.so, 2): Symbol not found: __Py_set_inheritable_async_safe
Referenced from: /anaconda3/lib/python3.6/lib-dynload/_posixsubprocess.cpython-36m-darwin.so
Expected in: flat namespace
in /anaconda3/lib/python3.6/lib-dynload/_posixsubprocess.cpython-36m-darwin.so
What steps will reproduce the problem?

What is the expected output? What do you see instead?
Paste Traceback/Error Below (if applicable)

PASTE TRACEBACK HERE

Package Versions

Spyder:
Python:
Qt:
PyQt:
Operating System:

Dependencies

PASTE DEPENDENCIES HERE

Thanks for reporting. This is a duplicate of #6876 which apparently is a problem with Python itself, and there isn't much we can do about it. Therefore, you can solve it for now by downgrading to Python 3.6.4 with conda install python=3.6.4.

This is supposed to be fixed by downgrading to Python 3.6.4, but you that version was giving you issue #6335, so I don't know how to help you further. In any case, both problems are not related to Spyder directly, but they are Python problems.
@mingwandroid, have you seen the problem above with Python 3.6.5 in macOS?

Ups, I didn't see @CAM-Gerlach's comment before publishing my own. @dantheman3232, please follow his advice.
@mingwandroid, sorry for the unnecessary ping.

Ups, I didn't see @CAM-Gerlach's comment before publishing my own. @dantheman3232, please follow his advice.

I actually said the same thing you did above in my comment before I saw the issue I linked to, heh.

No problem; we need to stop building python.app the way we are building it. Frequently when we bump Python versions we forget to update python.app and this is really bad. I will try to get time scheduled to address this properly.

Just want to update that I had the same error, so it seems been have forgotten, but it was fixed via conda update python.app


PHP: Bumps of March 2023

This PR:

Update Composer from version 2.5.1 to 2.5.4 and also make use of makeBinaryWrapper instead of makeWrapper .
Bump PHP 8.1 bugfix release (News: https://www.php.net/archive/2023.php#2023-03-16-1)
Bump PHP 8.2 bugfix release (News: https://www.php.net/archive/2023.php#2023-03-16-2)

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Ah, composer probably blocked the automatic port, so I leave it up to you @drupol :wink:

Will take care of this now


Intervl2.5

📚 The doc issue
Repetition Detection: We use an LLM combined with a specialized prompt to identify repetitive samples. These samples are then subjected to manual review, and those scoring below a threshold (e.g., 3) are removed to maintain data quality.
How do you identify duplicate samples using LLM? Why not use a method like Kmeans clustering for screening? It's very difficult for LLM to handle an entire dataset at one time.
Suggest a potential alternative/fix
No response

Thank you very much for your question.
The following is my personal understanding. We process data in units of samples, and mainly focus on the local situation where words or sentences are repeated. Due to the next word training method of LLM, LLM is more sensitive to the format of this data and is better able to identify repeated problems.
K-means clustering may be more inclined to classify samples with similar features and focus on the overall characteristics of the samples. Therefore, the field to which the samples belong, the information they contain, etc. may interfere with the classification results more.
Of course, this is just my understanding. You can actually test it. Maybe a good clustering processing method is more effective.

Hello, perhaps there are some ambiguities in the wording of our technical report. What we actually intend to filter and discard are the repeat patterns within the sample, not the repetitions between samples.

Thanks


Git diff icon doesn't show

I use spaceline.lua
My statusline in modified file in git folder:

Expect:

hmm which git plugin do you used .

nothing changed of get git diff count code.. works fine with vim-signfy

hmm which git plugin do you used .

I use vim-fugitive

nothing changed of get git diff count code.. works fine with vim-signfy

I 've just installed vim-signfy, It works. Thank you

Aha. so default git diff provider only support vim-gitgutter vim-signify gitsigns. so you need write a git diff provider the n use it.


Slow Intellisense (vs code last version) on mac

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: Version: 1.70.2 (I tried both Universal and M1 chip version)
Commit: e4503b30fc78200f846c62cf8091b76ff5547662
Date: 2022-08-16T05:38:59.695Z (2 days ago)
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 21.6.0
OS Version: Monterey 12.5 M1 chip

Steps to Reproduce:

Open a typescript file
Try to use intellisense
wait 1 min to have it...

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

yes as I wrote on the first comment, but it seems to be a repository issue, everything works smooth on another repo, so you can close this (sorry about that, I should think about this before xD)


ppo output to this.result for api exposure

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
this changes ppo output to this.result for exposure through the api

What is the current behavior? (You can also link to an open issue here)
ppo result is undefined in api output when indicator data is requested

What is the new behavior (if this is a feature change)?
ppo will follow the standard and give results through the api when requested

Other information:
console.log(this.indicators.ppo.result);
  { shortEMA: 0.06888827751422255,
    longEMA: 0.06853998108689652,
    macd: 0.0003482964273260336,
    ppo: 0.5081653391244092,
    MACDsignal: 0.00018784157245120353,
    MACDhist: 0.00016045485487483008,
    PPOsignal: 0.2745353395994594,
    PPOhist: 0.23362999952494978 }

thanks :)


Added link support to all templates

It's a shame the left/right links aren't supported on styles apart from the social one.
This PR adds support to the other styles.

Looks like the tests failed as the older templates were expected. If this is a valuable PR, I'll update the tests, too.

I'm curious why this hasn't been merged yet; I'd really like to see this added.
Specifically, I'm using Shields.io to replace <StillMaintained.com> in my projects, with badges like the following:

I'd really like to be able to able to link the word ‘feature frozen’ to a README section below, with something like ?link=%23feature-freeze.

@thegecko The tests fail. Uncoincidentally, the template fails to parse. I am not sure why, but it seems this patch as is cannot work.

Could you please indent the contents of {{?…}}…{{?}} please? It would gain in readability.

@espadrine This looks better

Chrome has a display bug for your code:

The bug is filed at https://code.google.com/p/chromium/issues/detail?id=352912. It is seemingly inconsistent with Firefox and Safari.
As a result, the only way to get cross-platform results is to put fill=#fff, which explains this: https://github.com/badges/shields/pull/598#discussion_r50480144.

Do you want me to add the fill=#fff back in to match the social template or will it fail the tests? Perhaps The dirty fix should be implemented for all templates including the social one?

It would still be erased by SVGo. We simply need Google to fix their software, and when it's been released in the wild for a month, I'll merge this.

@thegecko @espadrine Any movement on SVGo or the current merge conflict?

As this can't be merged and the problem persists, let's track this via #1079.
@espadrine has rebased this work onto master in this working branch.


[Bug] cannot login web console

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened

StreamPark Version
1.2.3
Java Version
1.8
Flink Version
1.14.5
Scala Version of Flink
2.12
Error Exception
如图

Screenshots
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Maybe you can have a try as following:

check the browser console log, if error log message appear?
clear the table  t_user && reinsert the data of this table which script name is mysql-data.sql.