[BUG] cannot import name 'url' from 'django.conf.urls'

Is there an existing issue for this?

[X] I have searched the existing Issues

Current Behavior
following the "quick start" info from the homepage and going around bug #2007 by manually installing pytz with
pipenv install pytz

Comes the next problem:
demo> ./manage.py createdb
Traceback (most recent call last):
  File "/home/tsw/git/mezzazine_vanilla/myproject/./manage.py", line 14, in <module>
    execute_from_command_line(sys.argv)
  File "/home/tsw/.local/share/virtualenvs/mezzazine_vanilla-ZPLJQPDu/lib/python3.9/site-packages/django/core/management/__init__.py", line 425, in execute_from_command_line
    utility.execute()
  File "/home/tsw/.local/share/virtualenvs/mezzazine_vanilla-ZPLJQPDu/lib/python3.9/site-packages/django/core/management/__init__.py", line 401, in execute
    django.setup()
  File "/home/tsw/.local/share/virtualenvs/mezzazine_vanilla-ZPLJQPDu/lib/python3.9/site-packages/django/__init__.py", line 24, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/home/tsw/.local/share/virtualenvs/mezzazine_vanilla-ZPLJQPDu/lib/python3.9/site-packages/django/apps/registry.py", line 91, in populate
    app_config = AppConfig.create(entry)
  File "/home/tsw/.local/share/virtualenvs/mezzazine_vanilla-ZPLJQPDu/lib/python3.9/site-packages/django/apps/config.py", line 223, in create
    import_module(entry)
  File "/usr/lib64/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 850, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "/home/tsw/.local/share/virtualenvs/mezzazine_vanilla-ZPLJQPDu/lib/python3.9/site-packages/mezzanine/boot/__init__.py", line 18, in <module>
    from mezzanine.boot.lazy_admin import LazyAdminSite
  File "/home/tsw/.local/share/virtualenvs/mezzazine_vanilla-ZPLJQPDu/lib/python3.9/site-packages/mezzanine/boot/lazy_admin.py", line 2, in <module>
    from django.conf.urls import include, url
ImportError: cannot import name 'url' from 'django.conf.urls' (/home/tsw/.local/share/virtualenvs/mezzazine_vanilla-ZPLJQPDu/lib/python3.9/site-packages/django/conf/urls/__init__.py)
demo>

Expected Behavior
The database is created with the command manage.py createdb
Steps To Reproduce
follow the quick start from homepage. Work around #2007 by also installing pytz
Environment
- Operating System: linux
- Python version: 3.9.9
- Django version: 4.0.0
- Database engine and version: I'm guessing the "quick start" from homepage defaults to sqlite? didn't get that far.
- Mezzanine version: 5.0.0

Anything else?
I'm guessing this comes from the fact that django has deprecated django.conf.urls.url in version 3.1 (https://docs.djangoproject.com/en/3.2/ref/urls/#url) and django.urls.re_path() should be used instead. Of course migrating to the new path format might be even better as it is much nicer to read (https://docs.djangoproject.com/en/4.0/ref/urls/)

Please trying installing with mezzanine with:
pip install mezzanine==5.0.0

That'll install Django==3.2.10 which still uses django.conf.urls

Please trying installing with mezzanine with:
pip install mezzanine==5.0.0

That'll install Django==3.2.10 which still uses django.conf.urls

Nope, didn't help.
I already started adding support to Django 4.0.0 by making a small pr to filebrowser-safe here: https://github.com/stephenmcd/filebrowser-safe/pull/136
I have other changes already that atleast get the project started with Django 4.0.0 but would like to see the first one checked before committing more time to this.

Mezzanine is still using django.conf.urls in a few places in addition to filebrowser so I would hold off and stick with django3.2.10 as mezzanine5.0.0 has only just been released. (this is assuming you just want to get a site up and running).
Obviously pull requests, I'm sure are welcome to bring Django4 in

@skru yeah, I have a old site I want to upgrade and might as well take a few extra steps to get to the latest Django at the same time :D
filebrowser pr is done and tests are running, but the last step of CI looks like it tries to do a new release which obviously fails.
I'll try to get a similar pr to this repo in the near future.

Yeah, mezzanine==5.0.0 installs django v 4.0.  It works then installing django==3.2.10  Thanks


Closes: #1

fixed bug that allowed users to make unsat usrname
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

The username bug has been fixed.


Create Web Interface

Description
We need to develop a web interface for the Arc Pinned Tabs to HTML Bookmarks Converter. This will allow users to easily upload their StorableSidebar.json file, have it converted to a bookmarks file, and then download the result, all through a user-friendly web page.
Objectives

Create a simple, responsive web interface
Implement file upload functionality for StorableSidebar.json
Process the uploaded file using our existing Python script
Generate and offer the bookmarks file for download
Ensure security and privacy of user data

Tasks
1. Set up Web Framework

Choose and set up a Python web framework (e.g., Flask or FastAPI)
Create a basic project structure

2. Develop Frontend

Create an HTML template for the main page
Implement a form for file upload
Add JavaScript for asynchronous file upload and download
Style the page with CSS for a clean, responsive design

3. Implement Backend

Create route(s) to handle file upload
Integrate existing Python script for processing StorableSidebar.json
Implement error handling for invalid uploads or processing errors
Create route to serve the generated bookmarks file for download

4. Security and Privacy

Implement CSRF protection
Ensure uploaded files are processed in memory and not stored on the server
Add rate limiting to prevent abuse

5. Testing

Write unit tests for new backend functionality
Implement integration tests for the full upload-process-download flow
Perform cross-browser testing for the frontend

6. Deployment

Set up a production-ready server (e.g., Gunicorn)
Configure a reverse proxy (e.g., Nginx)
(Optional) Containerize the application using Docker

Proposed File Structure
arc-bookmarks-web/
├── app/
│   ├── __init__.py
│   ├── routes.py
│   ├── converter.py  # Existing script logic
│   └── templates/
│       └── index.html
├── static/
│   ├── css/
│   │   └── style.css
│   └── js/
│       └── main.js
├── tests/
│   ├── test_routes.py
│   └── test_converter.py
├── requirements.txt
└── run.py

Acceptance Criteria

Users can upload StorableSidebar.json through a web interface
The file is processed server-side using our existing Python script
Users can download the resulting bookmarks file
The web interface is responsive
All new code is covered by unit and integration tests
The application is deployed and accessible online

Additional Considerations

Implement logging for better debugging and monitoring
Add analytics to track usage (ensure compliance with privacy laws)
Create user documentation for the web interface

Resources

Flask Documentation
FastAPI Documentation
MDN Web Docs: File API

@ivnvxd, if you haven’t already started working on that feature, I’ll take care of it. 😄

@CovertDuck Of course you can take on this feature 👍


Not applying semantic highlighting after switching the grammar

Hi,
I've installed the package from Atom's Settings View, restarted Atom, and then switched the grammar of an open JavaScript file to "JavaScript (Semantic Highlighting)", just like the "Usage" section of the README says.
However, I don't see semantic highlighting applied to my code. Here's an example:

I noticed that Atom seems to actually be truly using your highlighter -- changing from "JavaScript" to "JavaScript (Semantic Highlighting)" does modify colors a bit (ie, "true" goes from a shade of green to a shade of blue). But as you can see in the image, colors don't feel like they should, like I see in your screenshots :(
What did I do wrong?
Thanks,
Bruno

This is happening to me as well. It started when I upgraded to ATOM version 0.169.0

It was happening to me before 0.169.0. I believe I was using 0.166.0.

Same here :( I really miss this highlighting.

Also seeing this. 0.172.0

Now on 0.174.0 the package triggers some deprecation notices:
Deprecated calls
language-javascript-semantic (2 deprecations)
The atom.syntax global is deprecated. Use atom.grammars instead.
Called 1 timeCreate Issue on language-javascript-semantic repo
Atom.Object.defineProperty.get - /Applications/Atom.app/Contents/Resources/app/src/atom.js:316:11
Object.activate - /Users/bfreis/.atom/packages/language-javascript-semantic/lib/main.coffee:13:9
The atom.syntax global is deprecated. Use atom.grammars instead.
Called 1 timeCreate Issue on language-javascript-semantic repo
Atom.Object.defineProperty.get - /Applications/Atom.app/Contents/Resources/app/src/atom.js:316:11
Object.activate - /Users/bfreis/.atom/packages/language-javascript-semantic/lib/main.coffee:13:62

FOUND IT! This will temporarily fix your problem.
Go to settings and turn off the Shadow Dom.
http://blog.atom.io/2015/01/05/enable-shadow-dom.html
Looks like this is enabled by default, the semantic highlighting scss file will need to be updated to pierce the shadow dom.

Awesome! Thanks for the tip! Now it's working.
Looks like it won't be possible to disable Shadow DOM anymore on 1.0.0, though.

What changes are necessary for this to work with Shadow DOM?

@p-e-w I love this highlighting, my screen is the coolest in the office.
This article on upgrading.  Is the only thing I have found with any ideas on how to fix.
Looks like the selectors you use to give the elements colors need to be updated to use the ::shadow  selector which will pierce the shadow dom boundary. I believe this is only selectors that descend from the editor.
Looking at the source code of this repo. I am unsure how to accomplish this.  Though, my spider sense tells me that this line needs to be updated.
If you don't have the time and can point me in the right direction. I will put in some work.

Thanks, so it might be as simple as prefixing that line with ::shadow?

Hope this get fixed soon. I love the package but turning off shadow DOM breaks linter package which I have come to depend on heavily.

+1. Could anyone open a pull request for that?


Make tiff

@asjohnston-asf After make_tiff was replaced by gdal.Translate in https://github.com/ASFHyP3/hyp3-isce2/commit/d87f650b3d6f11cb2eab1f54fb64e68e6131257c, do we still need this PR?

Closing since these changes were incorporated in PR #45.


Permission System

come up with a permission system
maybe:setting to use either discords permissions or role-based permissions
maybe: have only 2 ranks: bot user and bot admin

Added in fe4d542456
Will leave the issue open incase I or someone has a better idea for a permission system

How can set userrole to none ?
I don't want users to be able to use bot
I want only staff can use the bot

@akbari6776 in your case you can set the user role and the staff role both to the role that determines staff on your server


Improve concurrent requests performance

Some endpoints like /entities use a cache to keep LRU entities but it is not effective when more than one request are querying the same ids or pointers.
We should add certain logic with promises to avoid multiple calls to the DB for same ids/pointers.

Discussed with the team on how to solve this. There's no simple solution to the current behavior. Complex solution would be some sort of serialization of the requests, where each request queries the DB for entities it needs and that it's not being currently fetched by other requests. Whatever comes next removes other entity ids already queried in prior ones. But then, it's another complex problem what to do in case a query finishes before the prior ones. Should it wait? On which ones?
This service is already clever enough to get from DB the cache misses. As soon as entities are fetch they're added to the cache. So it's very efficient already.
The access pattern we would normally see here doesn't seem to be a problem as it is. And, as per the dashboard, the cache seems to be doing a good job.
So closing this as as not an issue currently and the solution could be worse than the current behavior.


[Snyk] Security upgrade golang from 1.20 to 1.22

This PR was automatically created by Snyk using the credentials of a real user.Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Changes included in this PR

Dockerfile.protoc

We recommend upgrading to golang:1.22, as this image has only 77 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Some of the most important vulnerabilities in your base image include:

Severity
Priority Score / 1000
Issue
Exploit Maturity

614
Improper Verification of Cryptographic Signature SNYK-DEBIAN12-GNUTLS28-6159410
No Known Exploit

614
Information Exposure SNYK-DEBIAN12-GNUTLS28-6159418
No Known Exploit

514
CVE-2023-7008 SNYK-DEBIAN12-SYSTEMD-6137714
No Known Exploit

514
CVE-2023-7008 SNYK-DEBIAN12-SYSTEMD-6137714
No Known Exploit

514
Out-of-bounds Read SNYK-DEBIAN12-TAR-3253526
No Known Exploit

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Approved


Add support for the AI Wifi switch (babai.switch.bb101s)

It's a cheap switch which made in China, please add it if possible.
Model : babai.switch.bb101s

The device should now be supported as of version 0.9.18


[FEATURE] Add beforeAll, afterAll, beforeEach, afterEach decorators for jest

Testdeck Version
Version: 0.3.3
Description
It would be nice have a beforeAll, afterAll, beforeEach, afterEach decorators for use this functions in test suites

We have something similar, see

beforeEach/afterEach: https://testdeck.org/pages/guide/advanced_suite#instance-lifecycle-hooks---
beforeAll/afterAll: https://testdeck.org/pages/guide/advanced_suite#static-lifecycle-hooks---

see also the notes on inheritance and lifecycle hook chaining:

https://testdeck.org/pages/guide/inheritance#static-lifecycle-hook-chaining
https://testdeck.org/pages/guide/inheritance#instance-lifecycle-hook-chaining


Broken auto prefixing

Hello!
I'm using Linaria, which uses Stylis under the hood for auto prefixing.
Linaria is a zero-runtime CSS in JS, works by transforming it to CSS variables.
CSS variables are generated.
After some updates my build become broken, it generates line like:
-webkit-box-pack:var(--b10wbfel-0);-mjustify;-webkit-justify-content:var(--b10wbfel-0);justify-content:var(--b10wbfel-0);

note that -mjustify; which is incorrect.
After hours of investigating I've narrowed issue to Styles, exactly this lines
https://github.com/thysultan/stylis/blob/0990417cefe8a4d01115613ccf44f5ae86040cd5/src/Prefixer.js#L78-L79
First (inner) replace generates string
-webkit-box-pack:var(--b10wbfel-0);-ms-flex-pack:var(--b10wbfel-0);

Second (outer) replace generates this broken line
-webkit-box-pack:var(--b10wbfel-0);-mjustify;-webkit-justify-content:var(--b10wbfel-0);justify-content:var(--b10wbfel-0);

because regular expression /s.+-b[^;]+/ (which I assume should match space-between value) matches s-flex-pack:var(--b part of first string.

I think this library should take into account, that there can be variables in place of values, with any variable name, and they should not match regular expressions.

PRs are welcome.

PRs are welcome.

Of course, if I were fluent in CSS and differences in browser ._.
This library's code looks like maintainers put a significant efforts into its minimal size, and it is not always obvious what was ment by one thing or another. Regarding this issue, it is only my guess, that regular expression /s.+-b[^;]+/ ment to match space-between, but I'm not 100% sure. There are no any comments in the code, no any explanation and so on.
I dare say that this library is not very friendly for external contributors, who are unfamiliar with existing code base and chosen solutions.

I apologize, if my messages may looks like demands or requirements. They are not :) I just maybe a bit frustrated, but mostly on Linaria library, whose developers have chosen Stylis without proper investigation and without opt-in way to disable vendor prefixing. I'm sure this library is great, as well as Linaria, they maybe just don't fit each other completely, with a way Linaria works. And of course I understand that open source is not paid work.

Well, Stylis is a popular choice for CSS-in-JS libraries. A dependent can't ever predict all the interactions with its dependencies so I wouldn't blame Linaria maintainer here for not doing "a proper investigation". This looks like a bug and nothing more than that - those will always happen in the software.

And of course I understand that open source is not paid work.

Yeah, this ☝ I don't have great incentives to work on fixing this right now - my mind is just elsewhere. If your company cares about fixing this they could sponsor Sultan/me/Stylis to get this job done.


crystal build --cross-compile should generate a helpful target script

Feature Request
Problem statement

{shards|crystal} build --cross-compile --target ... produces an incomplete solution

Compounding factors

Creaky, brittle, manual steps should be avoided
The doc for cross-compilation is also currently out-of-date (missing libevent)

Solution

It's genericide-able :) by dropping a target-specific script into ./bin

Linux
#!/usr/bin/env bash
set -euo pipefail
warn() { echo >&2 "$@"; }
die() { warn "$@"; exit 1; }
help() {
  die "$(cat<<HELP
Usage: $0 {command} ...

Commands

   install-depends

   link TARGET
HELP
)

"
}

linux::link() {
  set -x
  exec "${CC:-cc}" "$1.o" -o "$1" -lpcre -lrt -lm -lgc -lunwind -levent ${CFLAGS-}
}

_sudo() {
  local SUDO
  if [ $UID = 0 ]; then
    SUDO=
  else
    SUDO=${SUDO:-sudo}
  fi
  set -x
  exec $SUDO "$@"
}

_apt() {
  _sudo env DEBIAN_FRONTEND=noninteractive apt-get "$@"
}

#### Distro-specific code

debian::install-depends() {
  _apt update
  _apt -y --no-install-recommends \
    build-essential libevent-dev libpcre3-dev libgc-dev libunwind-dev
}

debian::link() {
  linux::link "$@"
}

ubuntu::install-depends() {
  debian::install_depends "$@"
}

ubuntu::link() {
  linux_link "$@"
}

# fedora::install-depends() {
#   _sudo dnf install -y ...
# }
#
# fedora::link() {
#   linux::link "$@"
# }
#
# ...

#### Main

# Detect distro ID
REGEX=(
  '/^ID=/!d'
  's/^ID=//'
  's/'\''\(.*\)'\''/\1/'
  's/"\(.*\)"/\1/'
)
if ID=$(IFS=';'; sed "${REGEX[*]}" /etc/os-release 2>/dev/null); then
  :
elif [ -n "$(command -v lsb_release 2>/dev/null)" ]; then
  ID=$(lsb_release -is | tr A-Z a-z)
fi

# Validate distro ID
[ -n "$ID" ] || die 'Error: Unknown Linux distro'

# Validate CLI args and dispatch to distro-specific function
CMD="${1-}"; shift || true
case "$CMD" in
  install-depends) ;;
  link)            [[ -e "${1-}" ]] || help ;;
  *)               help ;;
esac
CMD="${ID}::${CMD}"
command "$CMD" || die "Unsupported Linux distro $ID"
"${CMD}" "$@"

and then macOS, Windows, FreeBSD, {{your_os_here}} ...
Long-term solution

Vendor static libraries and cross-platform linker (lld?)

Problems

hosts x targets = N^2
Needs continuous builds against libraries' upstream stable
Disk space

Possible partial solution

S3-backed sccache

Could you please describe the problem more specifically? I don't follow what you mean with "incomplete".
Judging from the example solution for linux I might guess that you're missing a method to automatically install library dependencies?
But I'm pretty sure that's way out of scope for the compiler to worry about.

/ping @steakknife Could you add some information?


Add Runme badge

One ask, @degrammer, can we please change the badge's text to Run this Markdown? Danke!

New badge text: Run this Markdown


do not serialize string value using cache redis store

Sometimes we need to share data through Redis or other database cross-platform.
However Laravel Cache facade will serialize anything except number using Redis-store.
It might be better to skip serialize string like Json/Html for cross-platform considerations.
https://github.com/laravel/internals/issues/608
Also added test for object/array serialization.

Would break all existing Redis cache deployments.


feat: add create-preact to list of options in create-vite

Description
Re: https://github.com/vitejs/vite/pull/17649#issuecomment-2227098546
Alternatively, I'm happy to merge this into #17649 to land them together, if that's preferable.

No, thank you ❤


Release 0.24

To set up release 0.24.0, we should bump the version from 0.24.0-SNAPSHOT to 0.24.0 and update the performance figures.

Merged into main.


Installer build break

Installer jobs are causing the nightly builds to fail. I don't have the perms to see or diagnose the problems.
Execution error: script returned exit code 1

May also be due to a network glitch that has also killed some of the testing jobs https://github.com/AdoptOpenJDK/openjdk-build/issues/1683#issuecomment-617063871

Seems to be across all platforms and JDK versions, including next

It looks like you are talking about jobs such as https://ci.adoptopenjdk.net/view/Failing Builds/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-linux-ppc64le-hotspot/486/console
The linked installer job is https://ci.adoptopenjdk.net/job/build-scripts/job/release/job/create_installer_linux/9597/ which appears to have completed successfully

It looks like the associated test jobs, such as https://ci.adoptopenjdk.net/job/Test_openjdk11_hs_sanity.openjdk_ppc64le_linux/202/console failed though

01:49:48  getJtreg:
01:49:48      [mkdir] Created dir: /home/jenkins/workspace/Test_openjdk11_hs_sanity.openjdk_ppc64le_linux/jvmtest/openjdk
01:49:48       [echo] Getting Jtreg from https://ci.adoptopenjdk.net/job/jtreg/lastSuccessfulBuild/artifact/jtreg-4.2.0-tip.tar.gz
01:54:59       [exec] curl: (28) Operation timed out after 300967 milliseconds with 0 out of 0 bytes received
01:54:59
01:54:59  BUILD FAILED
01:54:59  /home/jenkins/workspace/Test_openjdk11_hs_sanity.openjdk_ppc64le_linux/openjdk-tests/TKG/scripts/build_test.xml:58: The following error occurred while executing this line:
01:54:59  /home/jenkins/workspace/Test_openjdk11_hs_sanity.openjdk_ppc64le_linux/openjdk-tests/openjdk/build.xml:196: The following error occurred while executing this line:
01:54:59  /home/jenkins/workspace/Test_openjdk11_hs_sanity.openjdk_ppc64le_linux/openjdk-tests/openjdk/build.xml:42: exec returned: 28
01:54:59
01:54:59  Total time: 5 minutes 1 second
01:54:59  1
01:54:59  compile.mk:42: recipe for target 'compile' failed
01:54:59  make[1]: *** [compile] Error 1
01:54:59  make[1]: Leaving directory '/home/jenkins/workspace/Test_openjdk11_hs_sanity.openjdk_ppc64le_linux/openjdk-tests/TKG'
01:54:59  makefile:60: recipe for target 'compile' failed
01:54:59  make: *** [compile] Error 2
[Pipeline] }

Correct. My assumption is that it's the installer as the build itself completed successfully.
Looking at some of the test failures, it looks like there might have been a network glitch last night on the jtreg side so it could be that the job died halfway through due to the internet dropping out https://ci.adoptopenjdk.net/view/Test_openjdk/job/Test_openjdk11_j9_sanity.openjdk_x86-64_linux/206/console

Ah. Just seen you commented the exact same thing 😄

@sxa Could we kick off a new respin of nightlies to verify it was just a glitch?

JDK11 pipeline is still running at the moment, so I was going to kick off 8 but they haven't failed in the same way ... The tests appear to have been ok on there

it's not the installer jobs. this was broken by https://github.com/AdoptOpenJDK/openjdk-build/pull/1668

The above revert does not appear to have fully resolved this as https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-linux-ppc64le-hotspot/517/consoleFull still shows the failure despite the above revert going in

Regarding this issue, the builds look a lot happier this morning. Thanks for the help on this

For reference, the revert of https://github.com/AdoptOpenJDK/openjdk-build/pull/1687 resolved this


Bug(scope): Transloco loads nested scopes in a wrong way.

Is there an existing issue for this?

[X] I have searched the existing issues

Which Transloco package(s) are the source of the bug?
Transloco
Is this a regression?
No
Current behavior
I have nested scope:
i18n
    foo
        bar
            en.json

To load and translate via code I use translocoService:
    translocoService.load("foo/bar/en");
    translocoService.translate("foo.bar.test")

However, when I try to translate, I get an error -   Missing translation for 'foo.bar.test'. Using debugger I found out that at this line of the TranslocoService the following translations is returned:
{
   "fooBar.test": "some text"
}

As it is seen instead of "foo.bar.test": "some text" transloco created "fooBar.test": "some text".
Expected behavior
Transloco must create "foo.bar.test": "some text" instead of "fooBar.test": "some text".
Please provide a link to a minimal reproduction of the bug

Transloco Config
No response
Please provide the environment you discovered this bug in
Transloco: 4.0.0
Angular: 13.3.5
Node: 17.3.0
Package Manager: 8.3.0
OS: Ubuntu 20.04.3 LTS

Browser
Firefox 95.0.1

Additional context
I've started to use transloco recently, so, I am not sure if this is a bug.
I would like to make a pull request for this bug
No

I think, that the problem is in these lines: https://github.com/ngneat/transloco/blob/master/libs/transloco/src/lib/transloco.service.ts#L531  and  https://github.com/ngneat/transloco/blob/master/libs/transloco/src/lib/transloco.service.ts#L792
From https://github.com/ngneat/transloco/blob/master/BREAKING_CHANGES.md scopeMapping property was removed from TranslocoConfig in v.3, so, scopeMapping[scope] || toCamelCase(scope); has no sense, as it will always go toCamelCase().

@PavelTurkish  did you get any solution on this ?  I am facing the same issue

@PavelTurkish thanks for the quick response. I am stuck in similar situation. I am thinking to go with camelCase approach  because there are going to hundreds of such subfolders. so it will be difficult to in maintaining foo.bar structure.

@cs-pratap-nikam You are welcome to suggest a solution and open a PR 👍

@shaharkazaz I added a new pull request for this here: https://github.com/ngneat/transloco/pull/738

@cs-pratap-nikam @JordanW9232
After revisiting this issue, from what I see, when providing 'nested/scopes/admin-page' you get 'nestedScopesAdminPage'. what's the issue here? if you want it any other way you can provide an alias.
Any thoughts? if not I'm closing this.

@cs-pratap-nikam @JordanW9232
After revisiting this issue, from what I see, when providing 'nested/scopes/admin-page' you get 'nestedScopesAdminPage'. what's the issue here? if you want it any other way you can provide an alias. Any thoughts? if not I'm closing this.

I know you can just change it with an alias, but having it generate like "nestedScopesAdminPage" by default makes zero sense. In your scenario, nested/scopes/admin-page would make way more sense to generate like "nested.scope.adminPage". Telling people "change it if you want" is not a solution.

@JordanW9232 makes zero sense in your opinion, if you ask someone else you might hear a different answer, Otherwise this issue would have had a lot more traffic.
As stated here depending on the nesting of the scopes, things can get pretty ugly pretty fast, this goes for the camel case strategy as well.
The camel case strategy is what Transloco provides OOTB, I think this is easily resolved with a pure helper function that gets a scope path and returns the scope definition:
export function translocoScope(scope: string) {
  return {
     scope,
     alias: // You define whatever you want
  }
}

I think that scopes are flexible enough for you to get the variation you want with very little effort.


542 report problem

Adding agency and content model to loader
@marcincichon  and @ollietreend

good to go @RobertWDLowe


Clinic Schema Diagram

For this feature me and my partner did the following

Created a new database based on the ERD
Created the tables based off the ERD diagram
Made sure that the necessary tables linked with the required foreign key
Used gitflow
Added a readme

@Chimoneg27  @rloterh, It has come to my attention that you have made a new one after requesting a code review. I would like to advise you that it is not a good practice to push new changes during a review as it can make it difficult for the reviewer to keep up and may require them to redo their review with the new changes. I recommend updating your code as much as possible before requesting a review, and after you have requested a review, please wait until you receive feedback before making any further changes. 🙏

@Chimoneg27 @rloterh, It has come to my attention that you have made a new one after requesting a code review. I would like to advise you that it is not a good practice to push new changes during a review as it can make it difficult for the reviewer to keep up and may require them to redo their review with the new changes. I recommend updating your code as much as possible before requesting a review, and after you have requested a review, please wait until you receive feedback before making any further changes. 🙏

Noted.


Reference https://github.com/lukeshay/astro-aws in the AWS deploy docs

I created a couple of packages to help with deploying Astro to AWS. It would be cool if they were referenced in the docs. Let me know if that is possible.
Thanks!

Hi @lukeshay! We don't typically document third-party integrations in our own docs, but I looked and noticed that your integrations aren't listed at https://astro.build/integrations ... which is where they should be!
Here's a link to docs with some instructions for making sure that your packages are picked up by our script and included there. (Maybe adding one of the keywords we search for will help.) There's also a link where you can file an issue directly to get your packages added if the automatic method doesn't seem to be working.
https://docs.astro.build/en/reference/publish-to-npm/#integrations-library
So, I'm going to close this as a docs issue, and will let you and the https://github.com/withastro/astro.build repo finish this one off!  🙌


EFCore.BulkExtensions.PostgreSql - BulkUpdate leaves open DB connection after execution.

I experienced a problem with BulkInsertOrUpdateAsync and BulkUpdateAsync methods for DbContext. They leave open connection to DB after execution which led to connection pool exhaustion and crushed my application. I think they should automatically close connection after execution as other EF Core and the library methods.
Using version 7.0.1 with EFCore 7.0.5 and .Net 6
My code:
await _dbContext.BulkInsertOrUpdateAsync(entities, new BulkConfig
            {
                UpdateByProperties = new List<string>() { "DeviceId" }
            });

Logs (with deleted sensitive data):
2023-04-11 12:47:40.266 +03:00 [DBG] Creating DbCommand for 'ExecuteNonQuery'.
2023-04-11 12:47:40.266 +03:00 [DBG] Created DbCommand for 'ExecuteNonQuery' (0ms).
2023-04-11 12:47:40.266 +03:00 [DBG] Opening connection to database '***' on server ''.
2023-04-11 12:47:40.266 +03:00 [DBG] Opened connection to database '***' on server '***'.
2023-04-11 12:47:40.266 +03:00 [DBG] Executing DbCommand [Parameters=[], CommandType='"Text"', CommandTimeout='30']
CREATE TABLE "monitoring"."device_activity_snapTempf008abfa" AS TABLE "monitoring"."device_activity_snap" WITH NO DATA;
2023-04-11 12:47:40.280 +03:00 [INF] Executed DbCommand (14ms) [Parameters=[], CommandType='"Text"', CommandTimeout='30']
CREATE TABLE "monitoring"."device_activity_snapTempf008abfa" AS TABLE "monitoring"."device_activity_snap" WITH NO DATA;
2023-04-11 12:47:40.282 +03:00 [DBG] Closing connection to database '***' on server '***'.
2023-04-11 12:47:40.282 +03:00 [DBG] Closed connection to database '***' on server ''.
2023-04-11 12:47:40.282 +03:00 [DBG] Opening connection to database '***' on server ''.
2023-04-11 12:47:40.283 +03:00 [DBG] Opened connection to database '***' on server '***'.
2023-04-11 12:47:40.316 +03:00 [DBG] Creating DbCommand for 'ExecuteNonQuery'.
2023-04-11 12:47:40.316 +03:00 [DBG] Created DbCommand for 'ExecuteNonQuery' (0ms).
2023-04-11 12:47:40.316 +03:00 [DBG] Executing DbCommand [Parameters=[], CommandType='"Text"', CommandTimeout='30']
INSERT INTO "monitoring"."device_activity_snap" (***) (SELECT *** FROM "monitoring"."device_activity_snapTempf008abfa") ON CONFLICT ("device_id") DO UPDATE SET ***;
2023-04-11 12:47:40.321 +03:00 [INF] Executed DbCommand (5ms) [Parameters=[], CommandType='"Text"', CommandTimeout='30']
INSERT INTO "monitoring"."device_activity_snap" (***) (SELECT *** FROM "monitoring"."device_activity_snapTempf008abfa") ON CONFLICT ("device_id") DO UPDATE SET ***;
2023-04-11 12:47:40.325 +03:00 [DBG] Creating DbCommand for 'ExecuteNonQuery'.
2023-04-11 12:47:40.325 +03:00 [DBG] Created DbCommand for 'ExecuteNonQuery' (0ms).
2023-04-11 12:47:40.325 +03:00 [DBG] Executing DbCommand [Parameters=[], CommandType='"Text"', CommandTimeout='30']
DROP TABLE IF EXISTS "monitoring"."device_activity_snapTempf008abfa"
2023-04-11 12:47:40.332 +03:00 [INF] Executed DbCommand (7ms) [Parameters=[], CommandType='"Text"', CommandTimeout='30']
DROP TABLE IF EXISTS "monitoring"."device_activity_snapTempf008abfa"

Note: this open connection should be closed automatically when DbContext is disposed after processing the request, although its still unexpected behaviour. However it may lead to connections leak in other cases, my was using this method in the Quartz job.

In PostgreSqlAdapter Connection is explicitly opened and closed only in Insert method which is also called from Merge(used for Update).
You think when Conn. is internal that explicit call to context.Database.OpenConnection(); should be also at the end of Merge even thought there was no explicit Open there ?

This is not the only place where the connection opens. When I was debugging it I found out that method CheckHasExplicitUniqueConstrainAsync  in Merge calls context.Database.OpenConnection(); and don't close. I think this is the source of the problem. And after that any EF Core command inside this method or in my code doesn't close connection automatically because it was created explicitly.

Fixed with 7.0.4


Repair API sort tests

Related Issue(s):

#262

Description:
Edit to four tests of the sort extension. The timezone Z character was not being included with the .replace command. So it was removed and Z is appended to the datetime string.
PR Checklist:

[ ] Code is formatted and linted (run pre-commit run --all-files)
[ ] Tests pass (run make test)
[ ] Documentation has been updated to reflect changes, if applicable
[ ] Changes are added to the changelog

Hi @jamesfisher-gis. So sorting is working as usual with the API - outside of the tests?

Yes. There is no issue with the sorting logic. The issue was that the tests had updated so that a datetime object was being subtracted from a datetime string yielding this error and a failed test., for example
FAILED api/test_api.py::test_app_sort_extension_get_asc - TypeError: unsupported operand type(s) for -: 'str' and 'datetime.timedelta'

I have updated the tests so that it always uses a datetime object


Feature wanted: ability to store multiple fields into one database attribute

Bug report
What I did
Use 2 table fields type to store each time one item with simple key/value values, in a single settings Model attribute (json field on db side).   Set ˋmax` to 1 to allow only one row on for each.
For example :

[   // Table
    'name'            => 'options_a',
    'label'           => 'Options A',
    'type'            => 'table',
    'entity_singular' => 'option À ', // used on the "Add X" button
    'columns'         => [
        'name'  => 'Name',
        'desc'  => 'Description',
        'price' => 'Price'
    ],
    'max' => 1,/ maximum rows allowed in the table
    'min' => 0, // minimum rows allowed in the table,
    'fake' => true,
    'store_in' => 'settings'
]

[   // Table
    'name'            => 'options_b',
    'label'           => 'Options B',
    'type'            => 'table',
    'entity_singular' => 'option B ', // used on the "Add X" button
    'columns'         => [
        'foo'  => 'Foo',
        'bar'  => 'Bar',
    ],
    'max' => 1,/ maximum rows allowed in the table
    'min' => 0, // minimum rows allowed in the table,
    'fake' => true,
    'store_in' => 'settings'
]

What I expected to happen
Stored value in simple JSON object

{
  "options_a":{"name":"Rubber", "description":"lorem","price":15},
  "options_b": { "foo":"Ipsum","bar":"dolor"}
}

What happened
Stored each value as array

{
  "options_a":[{"name":"Rubber", "description":"lorem","price":15}],
  "options_b": [{ "foo":"Ipsum","bar":"dolor"}]
}

Also No "add XX" input must be displayed
What I've already tried to fix it
As the main goal of using table in this situation is have a cleaner UI/UX without any blade custom I looked for fieldset support but only dirty solutions was found, even in #3283.
Grouping fields is a must have when creating a lot a fields form, without requiring custom templating.
I didn't find where values as casted to array but if I manually update json in DB, then backpack cannot proper reload value in table cells when editing the entry using UI.
single row table mean we want to store flat value, not array value
Is it a bug in the latest version of Backpack?
yes, 4.1
Backpack, Laravel, PHP, DB version
When I run php artisan backpack:version the output is:

Hey @rroblik ,
Thanks for reaching out.
I wouldn't quite call this a "bug". It's the way web forms work, so it's the way Backpack works - you can only have one field with a certain name per page. So you can't add two "settings" fields. I know this isn't news to you - I see you've found quite a nifty solution with our fake fields, even though they weren't designed to be used that way. What I think would help you is this idea here, basically being able to define the exact place it would be saved: 'store_in' => 'settings.option_a'. It's something we're considering for the next version of Backpack, so if you think it's a good idea please give a thumbs up or reply there too.

I didn't find where values as casted to array

Indeed, when you use Backpack's fake fields, Backpack will "force" casting it to JSON (even if settings is not in your $casts), just to make it easier for people who have forgotten to do so.

To help you take your project further now, though - maybe this helps:
Solution A) You can add an accessor an mutator on that model, to customize how settings gets saved.
Solution B) Alternatively, you can use model events in your CrudController's setupCreateOperation() and/or setupUpdateOperation()` methods, to customize the Model at certain points. For example:
public function setupCreateOperation()
{
    // this will only get triggered inside the Create operation because that's where we've defined it
    // but if your setupUpdateOperation() calls setupCreateOperation(), it'll run there too;
    // alternatively, you can use different events: Product::creating() and Product::updating()
    Product::saving(function ($entry) {
        // TODO: merge request()->input('option_a') and request()->input('option_b') to a single JSON array and
        // store it on $entry->settings, basically customizing the save process
    });
}

I'm going to close the issue since I don't think this is a bug, I think you have a few solutions for this (I would do B, to be honest), and there's an issue  would help deal with this in an easier manner in the future. Let me know if you think I'm wrong or I misunderstood you issue - like all people, I can be wrong all the freakin' time 😀
Cheers!

@tabacitu Thanks for the complete (and quick) answer.
I was on my mobile phone to redact this issue ; so I will add some information now with real code example because maybe there is a misunderstood 😄
Code snippets
# AppCrudController.php

# ...
protected function setupCreateOperation()
{
CRUD::addField([
      'name' => 'git_app',
      'label' => 'Git app',
      'type' => 'table',
      'columns' => [
        'pid'  => 'Project ID',
        'pipeline_token'  => 'Pipeline Token'
      ],
      'store_in' => 'ci_settings',
      'store_as_json' => true,
      'fake' => true,
      'min' => 1,
      'max' => 1,
      'orderable'  => false
    ]);
    CRUD::addField([
      'name' => 'git_src',
      'label' => 'Git sources',
      'type' => 'table',
      'columns' => [
        'pid'  => 'Project ID',
        'path'  => 'Project Path',
      ],
      'store_in' => 'ci_settings',
      'store_as_json' => true,
      'fake' => true,
      'max' => 1,
      'min' => 1,
      'orderable'  => false
    ]);
    CRUD::addField([
      'name' => 'ci',
      'label' => 'CI settings',
      'type' => 'table',
      'columns' => [
        'deploy_app_ref'  => 'App reference',
        'deploy_token'  => 'Deploy token',
      ],
      'store_in' => 'ci_settings',
      'store_as_json' => true,
      'fake' => true,
      'max' => 1,
      'min' => 1,
      'orderable'  => false
    ]);
  }

# Models/App.php
# ...
class App extends Model
{
  # ...
  protected $fillable = [
    'ci_settings',
  ];

  protected $casts = [
    'ci_settings' => 'array',
  ];

  protected $fakeColumns = [
    'ci_settings'
  ];

}

# migration
class CreateAppsTable extends Migration
{
  /**
   * Run the migrations.
   *
   * @return void
   */
  public function up()
  {
    Schema::create('apps', function (Blueprint $table) {
      #...
      $table->json('ci_settings')->nullable();
      #...
    });
  }

 # ...
}

UI result :

Database
ci_settings field value in database :
{"git_app":"[{\"pid\":\"12\",\"pipeline_token\":\"ptoken\"}]","git_src":"[{\"pid\":\"666\",\"path\":\"foo\/bar\"}]","ci":"[{\"deploy_app_ref\":\"deploy\",\"deploy_token\":\"dtoken\"}]"}

That the main point : my data should NOT be array [] ; because I forced max to 1.
The optionnal point is (in orange on picture) : the "Add" button shouldn't be displayed is such field configuration

I will look at your "workaround" ; solution B seems good but I want to do such "formatting" at the lower level possible (maybe solution A in fact)...
Thanks

Hmm... it looks like we have a bug here indeed: the "+ Add" button shouldn't be visible when you've reached the max (inside a table field). I've added a separate issue about it here - https://github.com/Laravel-Backpack/CRUD/issues/4076 so we deal with that. Thank you 🙏

However, I still don't think we should convert the array of arrays into a single array, when there's only one item. It's useful in your particular use case, but it'll be VERY confusing for other devs and in other scenarios. The result of that field should always be the same type - an array of arrays.
Think about it this way... what happens when there's a table with multiple entries possible... but then the admin removes some of them and reaches ends up with just one entry? Should the data type change to a simple array then? No, cause you'd be changing the data type in the db 😀
Don't get me wrong, I understand why it makes sense from your point of view, as a developer of this application. I agree, it would've been cool for you if table worked that way and switched data types depending on how many entries there are. But from other developers' point of view, what you're proposing is unexpected.
I think the confusion here is rooted in the fact that you're using table in a way that wasn't intended - to accept ONE entry, instead of multiple. And then merging three table fields into one. But... it's entire "raison d'etre" is to accept multiple entries. And I don't we should change data type for when it's used in a different way than intended, sorry.
Feel free to convince me otherwise if you think I'm wrong. It happens 😀

Maybe we can think about a simple table_single field type ; derivated from table : same UI (with #4076 fix ;)) but different behavior : single row of data. Best of 2 worlds !

Hey guys! 🌞
I just have one question:

if you don't need a table, why use a table ?

I mean, don't get me wrong, but from the table you are just using the "interface". It's not just the "Add" button, you have "reorder" buttons to re-order a single element too. Does it make sense at all? Why not setup the fields directly ??
CRUD::field('table_1_header')->type('custom_html')->value('
Header for my fields all in the same row
');
CRUD::field('table1_field1')->type('text')->wrapper(['class' => 'col-md-4'])->fake(true);
CRUD::field('table1_field2')->type('text')->wrapper(['class' => 'col-md-4'])->fake(true);

CRUD::field('table_2_header')->type('custom_html')->value('
Header for my fields all in the same row
');
CRUD::field('table2_field1')->type('text')->wrapper(['class' => 'col-md-4'])->fake(true);

You will endup with this in your database:
{"table1_field1":"hey","table1_field2":"oi","table2_field1":"sup ","table2_field2":"dup"}
Is there any problem using them like this @rroblik that I am missing ??
Thanks for the feedback,
Pedro

@pxpm you're totally right it look like the cleanest possible option.
2 notes :

OOB I can't have nested values in the final JSON, like {"table1":{"field1":"hey","field2":"oi"}} (that what I "need" to "group" related data under a same JSON key)
(personnal opinion) I don't like this line CRUD::field('table_1_header')->type('custom_html')->value('
Header for my fields all in the same row
'); ; calling an html tag a "field" is not verry sexy ; but maybe later we will have a CRUD::HtmlElement or so function !

Anyway I will try to mix @pxpm answer with @tabacitu  B (or A) solution, to get best of two world !
I will update this issue after, just for sharing.
Thanks

Hey @rroblik thanks for the feedback, I don't like it much either, but I convinced myself that the field is custom_html and it is what it is, a custom html field... it works to don't worry much about it and usually gets the job done 🙃
You can also split the ci_settings in the three columns you need in the database so each one stores the corresponding values and use an acessor for ci_settings model attribute, adding it to $appends. That way you would still call $model->ci_settings and get the result of your acessor where you combine the three other model attributes in the array form you need.
Or .. keep everything inside the same column as I said first and use the acessor / appends technique to return the results parsed the way you need them.
It also seems reasonable to me that a custom field like table_from_array, a sligth variation of the table field (strip the add more, orders etc) and could go something along this lines:
CRUD::field('db_column')->type('table_from_array')->structure(
    [
        'table_1' => [
            'fields' => [
                [
                    'name' => 'table1_field1'
                ],
                [
                    'name' => 'table1_field1'
                ],
            ],
            'label' => 'table 1 title',
        ],
        'table_2' => [
            'fields' => [
                [
                    'name' => 'table2_field2'
                ],
                [
                    'name' => 'table2_field2'
                ],
            ],
            'label' => 'table 2 title',
        ],
    ]
)

Where the tables would be the keys and fields the values to save in the db. Note that in table field you can only use text fields, while in repeatable https://backpackforlaravel.com/docs/4.1/crud-fields#repeatable-1 you can use almost all crud fields, so take that into consideration if you endup choosing one to start working as base.
Best,
Pedro


fix(gvisor): cleanup tests, consistent return values

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-udig

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:
Currently, gVisor tests are failing because they were not updated after the latest change. This PR fixes the tests and cleans up another return value, making it clear whether a parser encountered a fatal error or it simply doesn't know a syscall or an event yet.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: LucaGuerra
Once this PR has been reviewed and has the lgtm label, please assign gnosek for approval by writing /assign @gnosek in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 25946fbbd82de2fc8c20852febd5f4f5ba8799c7

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Suggest replacing using Foo by using Foo: Foo

I had using Libdl in ThreadPinning.jl but in the code I was always referencing functions explicitly as Libdl.dllist(...). It would be great if the package could recommend in this case - where no export is actually used implicitly - to change using Libdl to using Libdl: Libdl. This way, there are no (unused) functions flying around that could be used implicitly in the future.
(Of course, I can't speak to how difficult that would be, because I haven't looked at the implementation of the package.)

The way the implementation currently works is that it sees using Foo in the code, says "hey Foo, that's name that's in global scope, surely it's coming from another module", and then it queries Base.which(ThreadPinning, :Foo), and sees: oh Foo is coming from Foo great, let's tell them to import that.  So it would be quite trivial to allow. We can definitely turn that on if folks prefer; I thought perhaps it would be annoying.

I'd welcome a PR to do this; removing that bit of code is trivial, but what would be slightly more work is to update the sorting so that using Foo: Foo comes before using Foo: Abc, since we probably want the package import to come first in the list.  I think to do that, we'd want to change this line. That's where we sort the names within a given module, so it probably should check if either key equals nameof(v1) (or v2, they should be the same I think) and sort that one first. (Then we'd also need to update the tests!).

I think removing the filtering wasn't quite enough bc in some cases we don't add the using Foo: Foo still. However I expect https://github.com/ericphanson/ExplicitImports.jl/pull/8 will fix it, as I've reworked the logic there and am careful to add using statements to the list of names


fix Issue 21834 - std.numeric.gcd can't handle negative values

This is a pretty lame restriction.  Parameters should always be transformed to an unsigned value.

Eh... you can't signed and unsigned types as parameters for gcd, that seems like another oversight.

please merge this when you're satisfied with it.

please merge this when you're satisfied with it.

If you're happy with the new signature...
On reviewing this morning, I'd feel more sure if there was a mixed types test added to verify it is handled correctly.
I'll have a small dig around the git history as well to add a few more comments, as why DigitalMars uses Eulers algorithm is beyond me.

@thewilsonator @berni44 - rebased on top of other PR refactoring/fixes and added more tests.


feat(tutorial): complete step 5, Rochester

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

https://github.com/3DNinja/carbon-tutorial.git

carbon-tutorial-3DNinja
Looks good.  I've marked your step 5 as complete.
Our records show you have completed all 5 steps.

carbon-tutorial-3dninja.mybluemix.net


Add Philips Hue Filament (default power on state) support

Edit: Now, https://github.com/zigpy/zha-device-handlers/pull/728 needs to be merged before this as some "Giant filament" bulbs seem to come with firmware where the manufacturer name is Signify [...] instead of Philips.
Adds support for all Hue filament bulbs.
Two models (LWO001 and LWV001) are tested. The rest is very likely to have the same signature.
(Other non-filament Hue White bulbs will probably also have this signature, but they are not part of this PR)

Pull Request Test Coverage Report for Build 453745671

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.482%

Totals

Change from base Build 453670052:
0.0%

Covered Lines:
3184

Relevant Lines:
3814

💛  - Coveralls

This needs a rebase

This needs a rebase

I attempted to do it for you but it looks like you may have the allow edits by maintainers off...

I attempted to do it for you but it looks like you may have the allow edits by maintainers off...

Codecov Report

Merging #687 (01f61fb) into dev (41398b0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #687   +/-   ##
=======================================
  Coverage   82.95%   82.95%
=======================================
  Files         175      175
  Lines        3920     3920
=======================================
  Hits         3252     3252
  Misses        668      668

Impacted Files
Coverage Δ

zhaquirks/philips/zhadimmablelight.py
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41398b0...01f61fb. Read the comment docs.

Codecov Report

Merging #687 (01f61fb) into dev (41398b0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #687   +/-   ##
=======================================
  Coverage   82.95%   82.95%
=======================================
  Files         175      175
  Lines        3920     3920
=======================================
  Hits         3252     3252
  Misses        668      668

Impacted Files
Coverage Δ

zhaquirks/philips/zhadimmablelight.py
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41398b0...01f61fb. Read the comment docs.

Rebased the PR now.

Rebased the PR now.


Feature: Pinned Dependency checks support for Azure DevOps Pipelines

Is your feature request related to a problem? Please describe.
Pinned dependency checks only check shell scripts and GitHub workflows and misses out on many open source repositories that implement their CI builds using ADO Pipelines.
Describe the solution you'd like
Pinned dependencies checks should collect the same pinning checks it does from GH workflows from ADO Pipelines yaml files.
Describe alternatives you've considered
NA
Additional context
Add any other context or screenshots about the feature request here.

This could be good to consider as progress is made on #4177. Can you share an ADO pipeline example?

This could be good to consider as progress is made on #4177. Can you share an ADO pipeline example?

agree that this would be a good pair, even though the implementation is different.
the work that is done in #4177 is aimed at supporting ADO as a source repository. the work that is suggested in this feature is supporting ADO pipeline when parsing the "runtime" for pinned dependencies.
Today this is using the GitHub Action linter golangci-lint-action and in implementing this feature one would have to consider an alternative that would support ADO pipelines (which are actually quite similar)
ADO pipeline samples:
https://github.com/SonarSource/sonar-scanner-msbuild/blob/master/azure-pipelines.yml


Doc |  Create a "Contributing" section

Describe the Feature

✅ Extend and update the current contribute section.
✅ Check it's name currently calle "Contribute" to  "Contributing" if needed.
✅ Includes guidelines to collaborate with binbash projects.

The CONTRIBUTE.md file in RefArch V1, here, can be used as a base. In any case, this file has to be improved.
As a spin-off of this activity, a new task should be created in each repository, to create/enhance/update the CONTRIBUTE.md file in each repository.
Expected Behavior
The process to contribute has to be clear to someone reading the docs as well to someone working with a binbash repository.
Use Case
Un usuario dispuesto a contribuir, debe tener una idea clara de cómo hacerlo. Además, las normas y requisitos deben ser lo suficientemente claros para evitar retrasos y otros problemas.
Describe Ideal Solution
A clear and concise description of what you want to happen. If you don't know, that's okay.
Alternatives Considered
n/a
Additional Context
Here it is an interesting CONTRIBUTE.md generator: https://generator.contributing.md/
And notes https://contributing.md/

@juanmatias 1st version has been included => https://github.com/binbashar/le-ref-architecture-doc/blob/master/CONTRIBUTING.md Not closing this issue since we can probably improve it sgnificantly.
CC: @binbashar/leverage-ref-architecture-aws-admin @binbashar/leverage-ref-architecture-aws-dev


Fixes#8038: Change how status is handled after running workflow

Describe your changes:
Fixes #8038
It is changed how we display the status at the end of running a workflow.
When the debug level is DEBUG, we display the OLD style with what is stored on each status:

When the debug level is not DEBUG, we display a simple summary with the errors in case there are any:

Type of change:

[x] Improvement

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My PR title is Fixes <issue-number>: <short explanation>
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
[x] I have added tests around the new logic.

@nahuelverdugo can we expand the Failure status to include the error and optionally stack trace. It will be easier for us to debug. cc @pmbrull

@nahuelverdugo can we expand the Failure status to include the error and optionally stack trace. It will be easier for us to debug. cc @pmbrull

We were talking about that today. We can add some kind of verbosity that we want to show, but that would imply sending that parameter somehow from the UI too. I don't mind adding it or opening an issue to add it. What do we want to do?

@pmbrull @nahuelverdugo so the ask is simple
Expand Failure to not just the name but add other states
failed {
name: {fqn}
error: {simple error}
stackTrace: {stackTrace}
}

@pmbrull @nahuelverdugo so the ask is simple Expand Failure to not just the name but add other states failed { name: {fqn} error: {simple error} stackTrace: {stackTrace} }

We agreed exactly on that.

@nahuelverdugo makes sense. Shall we change the call to failure and remove the previous call. I would say
self.status.failed(entityName, errorMessage, stackTrace:optional) ?


Support for Sprockets 3

In Rails <IP_ADDRESS> app.assets is not present and preprocessor is not registering. This PR adds support for new configure API.

Just noticed that there was at least 2 PR for this issue. :laughing:

In the end wrote the fix differently, but thank you anyway for your contribution!


Consider testing the library - huge challenge

Describe the Feature
Actually the issue tracker is full of bugs, giving context to reproduce can be tricky and very special versioning issue arise.
This library rely on many other in order to share, it's tricky to write automating tests but I'm pretty sure it's a nightmare to do a complete manual testing of the app considering the number of packages and cases.
But social sharing is very important for any app with commercial goal so a solution need to be found.
It's pretty annoying that in 2020, maintainers of this package need to fix bugs like base64 encoding or Flipper version AFTER a release because testing such a complex library is a very complex task.
Possible Implementations
Right now I'm working with UI Automator to make end 2 end tests. While it's pretty doable on a simulator or real device I own, it's a challenge to automate this in a device farm (which is the goal because we need to test many configurations).
Here is the list of challenges and questions I would like to discuss with you.
Writing test itself is not so hard when writing for one device, I'm pretty sure there will be issues with different devices, ios/android versions, etc...

Install apps
On android it's doable by uploading apk directly on devices (IG, messenger, facebook, whatsapp, etc...).
For iOs I have no clue how to install apps on devices.
I also have no idea atm how to configure those apps without a carrier. Whatsapp for exemple require a mobile number.
Maybe we can upload configuration files on the devices ?

Test on simulators:
With github actions, it will be free to test for android and ios.  It's my next step.

Test on real devices:
As you all know, when you launch in prod, some specific issues arise related to manufacturers. We need to use devices farms.
Device farms are damnly expensives. Now Github is a microsoft property and considering the high number of stars for this lib, it might be possible to ask them for app center credits.

Related Issues

install apps on iOs sim and devices
install pre configured dependant apps
device farm cost
exploring more devices

Hi, @Fr33maan I agree with, currently, we are planning to port the project to TS on #805  to accomplish better support on the APIS, but without tests, we would still a lack on the tests of each PR.
Now we don't have any native/js tests implemented, but we are able to run both ios and android build on CircleCI. Also, we have support to apply Detox E2E tests on our CI since we can build iOS and Android. 🚀
But we have some challenges to cover the application with tests, personally  I think using an E2E would be great, but to achieve that we will definitely need some changes in our native implementation #741.
I would be happy to discuss that and see other examples to implement that, one package that currently uses an E2E approach is datetimepicker, maybe this can be a start point to implement that approach on rn-share.

Hi @MateusAndrade, while I see the build on CircleCI as a good first step to insure code quality, I would like to speak about testing only.
The lib does not appear to have critical bugs on the JS side, even if writing unit tests on the JS side is obviously a good idea, I'm purely speaking about compatibility issues with other apps on both android and iOS.
If we look at the issues right now, 90% of them are happening on the native side.
But if you want to speak about unit tests, yes, unit testing the native part of your module would be a great thing for all the contributors team.

The issue you are referring about testID is not a big deal for us. You can overcome the lack of testID by targeting elements with text. It's what I'm doing right now to test the lib. I use UI Automator which is pretty well working actually.
You cann see it there -> The test file on my repo

If you look at what I've done, I have serious doubt about compatibility between different versions of android. For exemple, on the gmail test, I have to close the keyboard and then press back (2 times, don't know why), not sure if the keyboard will be opened on another android version / manufacturer. Only tests on farms will tell the truth.
The tests are slow to run, around 8 seconds for each unit. Comparing to jest unit tests, it's really huge.
It's tedious to develop such tests but the reward is enormous, no more incompatibilities.
The actual goal for my end to end tests is pretty simple, displaying on the screen the native libraries (gesture, webview, udp, linear-gradient, share) to be sure they are not crashing the app.
While it's pretty straight forward for most of the lib I use, react-native-share is a very special flavor because of the dependencies on other applications.

I think the first thing to discuss here is the strategy to install preconfigured apps on both android and iOS. I'm not an expert in native, much more in JS, but I would be happy to do some researches if I have some help.


ansible-lint: 648 failure(s), 0 warning(s) on 18 files

Describe the Issue
ansible-lint is a code quality tool that can help spot bad practices and technical debt in Ansible content. It is often used in delevery pipelines. This role fails its scrutany.
Expected Behavior
ansible-lint passes with exit code 0 and no worrying output.
Actual Behavior
Finished with 648 failure(s), 0 warning(s) on 18 files.
Control(s) Affected
NA
Environment (please complete the following information):

Ansible Version: all
Host Python Version: all
Ansible Server Python Version: all
Additional Details:

Additional Notes
Possible Solution
Fix the code to comply with modern standards.
As a temporary workaround we can skip specific rules or tags by adding them to your configuration file:
.config/ansible-lint.yml
skip_list:  # silences the warnings and errors completely
  - command-instead-of-module  # Using command rather than module.
  - command-instead-of-shell  # Use shell only when shell functionality is required.
  - fqcn-builtins  # Use FQCN for builtin actions.
  - no-changed-when  # Commands should not change things if nothing needs doing.
  - package-latest  # Package installs should not use latest.
  - risky-shell-pipe  # Shells that use pipes should set the pipefail option.
  - var-spacing  # Jinja2 variables and filters should have spaces before and after.
  - yaml[line-length]  # Violations reported by yamllint.

601 fqcn-builtins


Correct grammar in CONTRIBUTING.md

@G07cha, please review. Answer "Approved." or something, if you agree with the changes.

Awesome, but hold on! First of all, make sure someone else hasn't previously found this bug, and, if no related issues are found, let's gather as much information as possible.

if no related issues are found, let's gather as much information as possible.

let's gather as much information as possible

lets

@qaisjp, are you sure? I've just googled it, and they say it's a contraction from "let us", and should be written "let's". Could you please provide a proof?

Ah, that's embarrassing, I misread the context.

Actually I think that for grammar check we should find native english speaker.

Native english speaker here

@shockone, sublist still messed up becouse no newlines added after each point

@G07cha, fixed.


net: dhcpv4: check msg len is correct

check if dhcpv4 msg len is correct and drop it otherwise
Signed-off-by: Ehud Naim<EMAIL_ADDRESS>

The reason for this patch is that one of our customerד sent packet with wrong hlen and zephyr still answer the packet.
And it seem the zephyr  should dropped it


Creating a namespace(using API) in a project where resource quota is set, does not inherit values from default, if few resources are not specified

Rancher versions:
rancher/server or rancher/rancher: master
Steps to Reproduce:

Create a project with resource quota set and defaultnamespaceresourcequota
creating a namespace(using API) in the project
It does not inherit values from default, if the resources are not specified.
Ex: If defaultnamespaceresourcequota is set with the below:

{"limit":{"pods": "2",
"services": "2",
"replicationControllers": "2",
"secrets": "2",
}}

and create a new namespace with just
{"limit":{"pods": "2"}}
The namespace is created with just {"limit":{"pods": "2"}}. The default values are not inherited for other resources not specified.

@soumyalj if user passes custom resource quota, we are going to error out on missing fields, not inherit from the project default. Default quota is meant to be set only when quota field is completely missing on the namespace.

Tested with master build from Sep 13

Create a project with resource quota set and defaultnamespaceresourcequota
Create a namespace(using API) in the project
It errors out with a message as expected.

Ex: If defaultnamespaceresourcequota is set with the below:
{"limit":{"pods": "2",
"services": "2",
}}
and create a new namespace with just
{"limit":{"pods": "2"}}


Support gym env in Gymnasium's make

Description
With this PR, Gymnasium can load environments that are registered in gym, but not in Gymnasium.
The environment will still be a gym.Env instance.
Type of change
New feature
Checklist:

[ ] I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes

Are you able to give any examples where this would happen? Also I'm pretty sure it won't return a valid gymnasium.Env instance, it will be gym.Env. Right now it's effectively the same thing, sure, but this won't be the case in the future as we add/change features. And even now, I'm pretty sure it could result in situations where isinstance(gymnasium.make(...), gymnasium.Env) == False, which is very much not a good thing.

Are you able to give any examples where this would happen?

Yes, you can try with ALE, or commenting env registration in Gymnasium (in envs.__init__.py).

Also I'm pretty sure it won't return a valid gymnasium.Env instance, it will be gym.Env. Right now it's effectively the same thing, sure, but this won't be the case in the future as we add/change features. And even now, I'm pretty sure it could result in situations where isinstance(gymnasium.make(...), gymnasium.Env) == False, which is very much not a good thing.

Yes, this is true. I don't think it is a good idea to keep this feature for a long time, especially if we will do changes in the env API.
I added a dummy wrapper, that at least makes true isinstance(env, gymnasium.Env) == False (but false isinstance(env.unwrapped, gymnasium.Env) == False).

I added a dummy wrapper

I don't think this is a good idea, all we're doing is pushing the problem one step down. I'm also wondering why the type checker isn't complaining about this, but it is what it is.
If we want this kind of compatibility, it can't be a wrapper per se, but a proper GymEnv(gymnasium.Env) which takes in a gym.Env in the constructor, and properly routs all the properties/methods.
Overall I'm pretty doubtful about the utility of this feature, but I guess it's been discussed somewhere outside?

I don't think this is a good idea, all we're doing is pushing the problem one step down. I'm also wondering why the type checker isn't complaining about this, but it is what it is.

I think we both misremembered. In the original passive environment checker we had this check that the environment has a gym.Env however we encouraged me to remove it to minimise error.
Therefore, surprisingly, this works fine without raising any error even with the passive environment checker active.
But I think we should apply the gymnasium wrappers not the gym wrappers. So you should be able to remove the Wrapper on the gym.make then have the returned environment as the env_creator stripped of the wrappers automatically applied to the environment, i.e., passive environment checker, order enforcing, etc. This should allow an environment have still have wrappers that are automatically used with the environment applied. I hope this makes sense
Also could the warning be after the gym.make has passed to say, "Environment has been loaded from Gym, please register the environment in the Gymnasium as well."

An alternative implementation
try:
    import gym

    if env_id in gym.envs.regstration.registry:
        gym_env_spec = EnvSpec(**dataclasses.asdict(gym.spec(env_id)))

        return gymnasium.make(gym_env_spec)

An alternative implementation

I did something in this direction, without losing the nice features in make (e.g. default version, module loading).
So, right now, the spec is extracted from the gym.registry and then the environment is created with Gymnasium wrappers and control.

Also could the warning be after the gym.make has passed to say, "Environment has been loaded from Gym, please register the environment in the Gymnasium as well."

Done

proper GymEnv(gymnasium.Env) which takes in a gym.Env in the constructor, and properly routs all the properties/methods.

I removed the base Wrapper; but I don't see the utility of adding this GymEnv. Yes, right now, isinstance(env.unwrapped, gymnasium.Env) is False, but the make function gives two warnings about it, thus this should not be a surprise. Where do you think this would be helpful?

Overall I'm pretty doubtful about the utility of this feature, but I guess it's been discussed somewhere outside?

We discussed this on Discord; I think it can be useful for helping people migrating to Gymnasium while envs are not supporting it yet. My idea is to remove this feature in the future.

After more discussions with @RedTachyon, we have agreed that the best options is to use the namespace to indicate the environment should be loaded from gym, i.e., gymnasium.make("gym/CartPole-v1") that allows users to use original gym environments in gymnasium along with external third-party environments that makes it clear where the environment is being loaded from.
In addition, this makes loading environments simpler
## in gymnasium.make
if ns == "gym":
   import gym as legacy_gym
   env = legacy_gym.make(id)
   return GymCompatibility(env)

Here an additional wrapper (GymCompatibility, name to probably change) is applied to the outside of the environment that converts the observation and action spaces to the gymnasium versions. Currently, as there is no difference between the gym and gymnasium spaces, we should be safely convert the spaces.
The advantage of this approach is that it makes it clear where the environment is being loaded from (allowing future API to be supported as well, i.e., dm_env) and all of the gym wrapper magic is kept with a simple conversion wrapper that can be updated over time.
The limitation of this approach is that custom spaces are not supported. However if we use the singledispatch to implement this, users can add their own functions for custom spaces to add compatibility.

@younik FYI Mark and I are planning to take a slightly different approach for this functionality, soon I'll either make a PR or do a more detailed write-up of what we want to do.

we basically need to keep this feature for the foreseeable future

If this is true, then this feature should not be added. We cannot ensure for the long term to be able to translate a gym.Env to gymnasium.Env.
My points were: adding/deleting this feature doesn't change anything about the API, and will be transparent when all third-party envs will migrate to Gymnasium. If this doesn't happen, it is third-party libraries' "fault" that is not updated, and simply that environment will not be supported in the future.
About typing, again, my idea was to remove the feature as soon as we cannot ensure that gym.Env and gymansium.Env share the same API (and likely, far before this happens). I also don't like it conceptually, but pragmatically, as a user I need this functionality, otherwise I will simply not use Gymnasium because every well-known benchmark is in gym.

gymnasium.make("gym/CartPole-v1")

This will not work for envs loaded during make, you will need to handle something like gymnasium.make("gym/ALE/Breakout-v5"), but anyway, the code will break when ALE will migrate to Gymnasium.
Anyway, consider the above points and choose what looks best to you.


Add pan gesture to AnimationTree's StateMachine editor

This PR fixes #41135.
The magic number "8" is used in many pan gesture handling code, e.g. in GraphEdit, ScrollContainer and the Polygon 2D UV editor.
Tested on the current master and 3.2 branch.

Thanks!

Cherry-picked for 3.2.4.


Feature/postgresql common

Includes PR of @muxator https://github.com/Pita/ueberDB/pull/99
Share code between postgres and postgres_pool (https://github.com/Pita/ueberDB/issues/114)
Add writeCallback to remove method
This patch is already used on https://framapad.org/
This PR (in fact the @muxator commits) should fix https://github.com/ether/etherpad-lite/issues/3511  on PostgreSQL >= 9.5
Ping @ldidry

@Pita , @JohnMcLear, could this be merged, please?


Fix unsafe uses of Callable.is_null()

Callable.is_null() is not equivalent to !Callable.is_valid() and doesn't guarantee the call is valid. It might not cause issues generally but there are cases when this would cause issues, so best to be safe. One major case when this will fail is when the object has been freed.
https://github.com/godotengine/godot/blob/6118592c6d88350d01f74faff6fd49754f84a7d0/core/variant/callable.h#L90-L92
https://github.com/godotengine/godot/blob/6118592c6d88350d01f74faff6fd49754f84a7d0/core/variant/callable.cpp#L152-L158

Restored some Object related ones that should use is_valid but can't due to classes not being registered yet, missed a comment about it in the code

Thanks!

Thank you!


Updates deprecated alias run_server and removes restrictions on dataframe add track workflow

Updates deprecated alias Dash run_server to Dash run
removes restrictions on df add track workflow that prevented "out of the box" bigWig files from computing properly

Users can now convert their BigWig data to a dataframe and load it directly into the library without having to change their headers or datatypes.

are there any limits on the size of bigwig that can be loaded? it is still using truncate?
one interesting feature of bigwigs is they do have different  "zoom levels" built in and the higher zoom levels have way less data, it would be cool if we could plot those directly from the data frame

probably good to go otherwise though, will just go ahead with merge


Add all diagnostics and make warnings into errors

Is this pull request associated with an issue(s)?
No
Description
Updates for the build image toolchain to do what the title says.

🚀 [bumpr] Bumped! New version:v0.3.49 Changes:v0.3.48...v0.3.49


Fixes broken link for RuckSack website

Broken link, had to fix it 😜  Great work with the podcast as mentioned before. Keep them coming. Cheers!

Thanks!


Add new non-variadic versions of _d_newarraym*T

The old versions can be deleted once the compiler has been updated

Once this is merged the compiler can be updated to use them: https://github.com/D-Programming-Language/dmd/pull/4303

Anyone?  This is blocking my work on cleaning up varargs, which is blocking ddmd.  I recommend viewing with whitespace ignored.

I should have looked here earlier.  FYI - GDC passes the length and ptr as separate parameters, not that it makes a difference.
this https://github.com/D-Programming-GDC/GDC/blob/e6130a9c04e308ec5e5e238d6355061f682b7b34/libphobos/libdruntime/rt/lifetime.d#L978

Hahaha, is it just me or is your version ABI-compatible with this version on every dmd platform except win64?

Why would you think that? :)

Fond memories of "%.*s".


AO-12194: Distro for new opensuse releases

SLES's new versions (and openSUSE) uses /etc/os-release for the releases information.

Codecov Report

Merging #99 into master will decrease coverage by 0.13%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   82.36%   82.23%   -0.14%
==========================================
  Files          34       34
  Lines        3788     3793       +5
==========================================
- Hits         3120     3119       -1
- Misses        568      573       +5
- Partials      100      101       +1

Impacted Files
Coverage Δ

v1/ao/internal/host/host.go
70.17% <ø> (ø)
:arrow_up:

v1/ao/internal/host/sys_linux.go
46.15% <0%> (-6.79%)
:arrow_down:

v1/ao/internal/reporter/reporter_grpc.go
67.12% <0%> (-0.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0458d2...cd21b8f. Read the comment docs.


Added management of order actions

Fixed eventListener. Splitted in two local listeners and changed naming
Added actions for changing actions (payment, shipping) of Orders

Needs https://github.com/elcodi/elcodi/pull/510 to be merged and tagged.


Review Governance literature and current trends

Review Governance literature (private and public sector) and current trends on topics such as Guardrails and scalable Governance.

Created a section for litterature review on the governance study folder.


Increase count of python method lines requires for a docstring

Python doctsrings were required on all methods, which was strict and encouraged unnecessary 1-liner docstrings that only echo the method name. Increase the threshold to not require it for short methods.
Also cleaning up the overly verbose statemanager.py, which had more lines of comments than code, many of which were echoing well-named method names, or copy/pasted and incorrect.

👍


OpenXR mesh settings update

Overview
The OpenXR preview API had a late-breaking change, so this brings us up to date with the latest.
Also updates the asmdef to be usable with an OpenXR package preview.
Changes

Follow-up to https://github.com/microsoft/MixedRealityToolkit-Unity/pull/9786

/azp run


Merge OpenCL Revisions

Tested against x1 Nvidia GPU & x1 AMD GPU so far. Compiled with gcc 7.3 & 9.X, respectively.

Compilers added to original comment.


AOT throws exception when using the custom control

Describe the bug
Hi Team,
I have prepared the sample with the custom control by using the AOT support. In Custom sample, I have used the ComboBox ItemsSource and assigned the Observerable String to ItemsSource. So, When AOT is enable, it throws exception when it is empty or assigned any items to ItemsSource.
Please find the image below,

Attached the sample and exception below,

CustomSampleAOT.zip
Steps to reproduce the bug

Open the Sample.
Ensure the AOT is enabled in the project.
Now, run the sample.
Note: Exception is thrown in AOT sample.

Expected behavior
Sample should run smoothly without any issue.
Screenshots
No response
NuGet package version
Windows App SDK 1.6.3: 1.6.241114003
Packaging type
Packaged (MSIX)
Windows version
No response
IDE
Visual Studio 2022
Additional context
No response

What's the returned value from InnerItemsSource if you try to read it back?


Review existing agile documents for shareability

Goal
In effort to prevent dead-end documents (docs that are created, are valuable, but end up orphaned simply because they were not visible or on a well-worn path); review existing agile docs in Google docs and other silos, and assess each document for:

is it valuable to the public?
is it valuable to other agile practitioners in gov?
does this document still need to exist?

is it in progress?  draft
a valuable (meaningful) artifact?  write up of a shareable agile pattern
or the equivalent of a digital sketch that is not actionable and can be discarded)  a draft superseded by another version/fork

Acceptance

fewer dead-end documents exist

Notionally

more valuable content lives online (and is thus iterate-able online)
more clarity on what agile documents that exist (and who they are for)
more understanding about how information is (and isn't shared)

Closing as stale, on the assumption that the need will resurface if it still exists.


Update Tiramisu to Aroma

it says tiramisu on the website, but not on the guide, which shows the better option

lol i forgot about the landing page. thanks

Welp, nothings happened with this except for they used this in another pull request that actually got merged so :/


Refactor twig component syntax

Hi!
Thanks again for getting this rolling! The regex was working great, but it didn't give us any opportunity to give the user a good error if they make a small mistake. This is an attempt to rewrite the logic without regex. It's possible I've missed something (though tests pass). And probably a lot more edge case tests could be added & probably we should try to "mess up" Twig syntax a bunch of times to make sure we get good errors (and ideally write tests for those errors).
This also adds the concept of a "default" block:
<t:successAlert type="{{ alertType }}">

It's a small world after all

    <t:successAlert type="success">Inception!</t:successAlert>

    <t:block name="some_other_block">
        Not used
    </t:block>
</t:successAlert>

In this case, the content that is NOT inside the <t:block (so the
 tag + the embedded <t:successAlert type="success">Inception!</t:successAlert>) become part of a new block called default:

    {% block default %}{% endblock %}

🔥

Woooow Thanks for your work on this Ryan! 🚀 After your comment on getting better errors on small developer mistakes, I was spinning my head. And I came to the same conclusion as you: regex is not the way to go, and we need to reproduce what the twig Lexer does!

Sorry, I just push on the previous branch just before your opened this PR.


Fix hide-comments-faster

Thanks for contributing! 🍄

LINKED ISSUES: Fixes #3867

TEST URLS: see test comment below

SCREENSHOT: -

Edit: this also fixes a bug where if the "Hide" drop-down is opened then closed by clicking outside, it will subsequently always appear on top of the main drop-down when clicking the "..." button. Seems like the d-none class had no effect anymore, so I replaced it by v-hidden.

Test comment

Test comment

Perfect! I'll release a hotfix soon

Perfect! I'll release a hotfix soon


Alternate aliases - ability to add multiple aliases, at least in the future

Modify format to allow this in the future
Then, move to later milestone to actually build UX for it


Feature request- Auto populate option

Which version of the plugin are you using?
[X] Data Populator for Sketch
[✓] Data Populator for Adobe XD
Is your feature request related to a problem? Please describe.
I am retriving data from a remote json but the data is not auto populating. It would be helpful if it auto populates. As the remote json regularly updates itself.
Describe the solution you'd like
It would be helpful if the data auto updates itself from the remote json rather than clicking populate button to update it again and again.
Describe alternatives you've considered
Addition of the feature of auto populate

@GodDevs i understand what you want to achieve, but not why. can you explain a bit more detailed?

@nitrada The remote api which is being used in my project updates regularly. So after hosting the website its not possible to update the data and again host the website. So it would be helpful if you remove the populate button or, after adding the {placeholder template} the data should automatically come in the placeholder just like the preview below the placeholder title.
It that way the data will be fetched from the api everytime the website opens and placeholder will always be updated.

what kind of data request triggers would you expect then for auto populate – on opening the document? time-based?
data populator is not really capable of "listening" to changes in the data coming from the API as we're using the REST paradigm (client requests, server responds). it sounds a bit as if you're wishing for something like "streaming data" via eg websocket, but that's a whole different chapter and currently not planned 😄


Add Github page/tutorial

We should have a simple no-frills tutorial for this build tool.
Ideally, a gh-pages branch would fulfill this role and offer a nice/free place to host.

Sticking with README for now.


How to train model with 1 GPU?

Dear @Ze-Yang,
Thank you for your great work!
I attempt to re-train your model with my 1 GPU.  Therefore, I reduce the batchsize and learning rate down to 4 times and increase max iteration and stepsize up to 4 times. Here is my results when I test my model with 1 shot:

The results seem lower than yours about a few percentages. May you show me it is ok or not? If not, could you tell me how I can reproduce your result with my only 1 GPU.
Hope to hear from you soon!
Sincerely,
Duynn

It seems that your base-class performance is far lower than mine, I think it's abnormal. You can try to decrease the max_iter and stepsize proportionally and see if the base class performance can reach our result. I think it should exist a suitable hyperparameter that can reproduce our results. You need to explore it by yourself. Note that the linear lr adjustment strategy does not guarantee the same results, it is just an approximation. Good luck.

Dear @Ze-Yang,
Thank you very much for your answers!
I try to test your model uploaded on onedrive such as "split1_pretrain.pth" but the results for testing following the command "python test.py -d VOC --split 1 --setting incre -p 1 --save-folder weights/VOC_split1_pretrain --load-file weights/split1_pretrain.pth" as follows:

And the results in your paper:

Is it right? If so, hope you can check it?
Best regards!

Hi, I have checked again the model I uploaded. The result is 73.14% as below for split1, a little bit higher than the result in the original paper. You can ignore it as it is just due to randomness. Thanks.
AP for aeroplane = 0.7927
AP for bicycle = 0.7413
AP for boat = 0.7251
AP for bottle = 0.5741
AP for car = 0.8250
AP for cat = 0.8665
AP for chair = 0.5313
AP for diningtable = 0.7419
AP for dog = 0.8025
AP for horse = 0.7972
AP for person = 0.7929
AP for pottedplant = 0.5064
AP for sheep = 0.6713
AP for train = 0.8332
AP for tvmonitor = 0.7699
Mean AP = 0.7314

Hi @Ze-Yang,
Is it the result of Python and Could you share your annotation. I official use the labels of PASCAL but I can't get this result from your model? I only get about 43% of mAP.

It's unlikely that you get a different result with me. The annotation is exactly the official PASCAL VOC test 2007. Please check whether you modify the code and the dataset annotations as well. Thanks.

Hi @Ze-Yang,
I don't know why but I have re-downloaded your code and annotations of pascal to make sure that there is no misunderstanding and run your model again. However, the testing result was still the same just like this:

Hi @Ze-Yang,
I am really sorry for this inconvenience!
Actually, I don't know why I just received the lower results. I try to re-setup my environment and download the code but I cannot figure out what is going on.
If it is possible, may you send me your models (before incre and after incre) to test it again on PASCAL VOC 2007 with my environment so that I could find out my problem clearly?
Sincerely,

FYI, here's the model (link expires in 7 days) for 1shot after incre. The model before incre is exactly the one I released on onedrive. Hope that it helps.

Hi @Ze-Yang,
Thank you very much for your kind support!
I am happy that I have found my problem.
The problem is that there is a conflict between cuda and pytorch with card architecture. So I change sm-61 to sm-60 to be suitable to my card. However, pay attention that I just install my env in the first time just by pip and run your code but there is no error or warning. This is dangerous. Finally, I change my env to conda and this env warn me up with the conflict so I found my problem!
Sincerely!

Great to hear that. Actually I emphasize the check of gpu architecture in the installation section as shown below. I am not sure why pip does not prompt out the conflict but it'd better carefully follow the instructions in README.md next time. It would always save you a lot of time spending in debugging. Thanks.


Don't need to pattern match on {:maybe, type} in upcoming Ecto release

With the given change https://github.com/elixir-ecto/ecto/pull/4265 you don't have to pattern match on {:maybe, type} anymore. I don't think it will hurt if you leave it as is but just wanted to give you a heads up.

Thanks for the heads up. I'll keep this open to remind me to go yank once that lands.


Error panel UI tweak

I updated the panel heading to disallow text selecting (make it more like a proper app).  You can still select text in the actual error area.  I also made the heading toggle on double-click (same behavior as single-click on the heading-fold button.  Please merge if you think this is cool.

:candy: sweet. Released with 4.6.7 :rose:
Tip: I personally toggle with ctrl+; followed by enter


Replace fork() with posix_spawnp()

Improves performance when felix has a medium/large VM size.

@Lukasa I'd like to get this into master soon so that we can let it bake with the FVs for the rest of the week.
I haven't tested the RHEL install instructions yet.

LGTM: I'm happy to merge for now and see how the tests feel about it.


findElementWithRelativeId missing #

Hi @volkanceylan
The function findElementWithRelativeId is missing of '#' in jQuery search
I fixed it

Thanks a lot, it's suprising how it didn't get noticed before though.


Reference error

Whenever I build project it gives error  "ReferenceError: HotSpotPlugin is not defined" .I added plugin in cordova project then i made respective changes in config.xml but error is still their.How to resolve this?

refering to the usage doc the call you be something like this:
cordova.plugins.hotspot.createHotspot(ssid, mode, password, successCB, errorCB)

Please check when you call the plugin.
you probably need to add
document.addEventListener("deviceready", function () { ...

its solved
thank you


Define a list of accepted categories

We should define a list of accepted categories and perhaps also cryptos?

What exactly do you want?
What are the categories?

@gcmartins11  Look at the already known categories find a common category for example we don't need Shopping and E-commerce which is basically the same. Make the list in data folder. Just call it categories.json and define an array. Go change data.json to reflect that.