Failed authentications are logged to level Warning

PR for issue #31968
Replaces PR #31983 to comply with gitea's error definition
Failed authentications are now logged to level Warning instead of Info.

Do we need to backport?

Do we need to backport?

I don't think so. It's not a bug.


.button-icon doesn't render as intended on firefox

flexed buttons don't play well on firefox.

@creuter thanks for catching this. We should have caught this one earlier. Seems like flexbox doesn't work for buttons in Safari and Firefox so in this PR (https://github.com/thoughtbot/empties/pull/8) I have added a wrapper div inside of the button.

This should be fixed per https://github.com/thoughtbot/empties/commit/4e95173bdc07244015807a9c913a7956156712df


Support user-specific configs

These are just preliminary thoughts
There could be six ways to configure Project Manager (top is the most general):
flowchart BT

project --> defaults
pu["project user"] --> project
hpg["host path glob"] --> defaults
upg["user@host path glob"] --> hpg
wt["working tree"] --> pu
wt --> upg

defaults is just what is built into Project Manager itself, all the module defaults. These apply everywhere and is already supported.
project is configuration committed to the repo (by default this is in  $PROJECT_ROOT/.config/project/, and this is already supported).
working tree is specific to the particular working tree it’s in. This isn’t yet supported. It could default to $PROJECT_ROOT/.config/project/local/ and should not be committed. This is probably the next most useful case.
project user is specific to a user & a project. This isn’t yet supported. It should be committed and would ideally just be conditionalized config within project, but maybe just stored in like $PROJECT_ROOT/.config/project/user/$VCS_USER/ (where VCS_USER is some VCS-specific identifier, like git config user.email). If a user prefers to not commit their configuration, this can generally be approximated with either working tree or user@host path glob configurations.
path glob (host & user@host) is a pretty flexible last case (that isn’t yet supported). It should be stored in /etc/project-manager/ or $XDG_CONFIG_HOME/project-manager/, respectively. It applies its configuration based on the working tree directory, relative to HOME. It mostly subsumes working tree, but with some tradeoffs. E.g., a key of "Projects/personal/some-project" would exactly match that one project directory (same as working tree in that project directory), while "Projects/personal/**" would match projects at any depth in $HOME/Projects/personal/. Other patterns like "**/some-project would match project directories with that name at any location (within the user’s home directory), and "**" applies as broadly as possible. The tradeoffs with working tree are that path glob can match multiple working trees and the configuration is resilient to deleting and re-creating the working tree, but the configuration isn’t stored with the project and user@host path glob does not play well with working trees that are shared by multiple users (which is why the paths are relative to home, and why host path glob exists – but host path glob has permission complexities). And another benefit over working tree is that path glob can easily be added to a NixOS, nix-darwin, or Home Manager configuration that is shared between hosts (which can approximate an uncommitted project user config, as alluded to above).

Comparing to Git scopes:

defaults is akin to Git’s defaults,
working tree is akin to --worktree (or --local),
user@host path glob is akin to --global,
host path glob is akin to --system, and
project & project user have no equivalent in Git scopes, as Git explicitly tries to prevent you from committing configuration.

There also need to be options to project-manager in order to:

run only with committed configs (defaults, project, and project user)
run without any user configs (defaults and project)
run “as” another user (defaults and project, plus project user of some named user)

These are useful for narrowing down where various hard-to-reproduce failures come from – reducing “works on my machine”.


redesign motive section in about us page!

planning to Add an illustration and redesign the heading!

refrence #289

@abhijeet007rocks8 @DhairyaBahl i would like to work on this!


Fuzzing Bug

after install..fuzz_wordlist.txt is empty...
download it manually...fuzzing still not running..

ok its fixing a problem with interlace
interlace
Traceback (most recent call last):
File "/usr/local/bin/interlace", line 5, in
from Interlace.interlace import main
File "/usr/local/lib/python3.10/dist-packages/Interlace/interlace.py", line 6, in
from Interlace.lib.core.output import OutputHelper, Level
File "/usr/local/lib/python3.10/dist-packages/Interlace/lib/core/output.py", line 4, in
from colorclass import Color
File "/usr/local/lib/python3.10/dist-packages/colorclass/init.py", line 11, in
from colorclass.codes import list_tags  # noqa
File "/usr/local/lib/python3.10/dist-packages/colorclass/codes.py", line 4, in
from collections import Mapping
ImportError: cannot import name 'Mapping' from 'collections' (/usr/lib/python3.10/collections/init.py)
change in codes.py : from collections import Mapping to from collections.abc import Mapping

Try installing interlace manually plz


VT Results tooltip presentation

Not every key:value is going to be present in every query result, but this is the following preferred order for VT results when they are returned. When results are returned in arrays (i.e. detected_, undetected_, etc... turn them into table formats with date sorted most recent first. Hashes returned in arrays should be limited in the table display to a maxlength of 15, and should also be followed by an external link back to VirusTotal search with that hash.
====
asn:
as_owner:
country:
verbose_msg:
Alexa category:
Alexa domain info:
Webutation domain info:
BitDefender category:
Forcepoint ThreatSeeker category:
BitDefender domain info:
detected_urls:
detected_urls:
undetected_urls:
detected_downloaded_samples:
undetected_downloaded_samples:
detected_referrer_samples:
undetected_referrer_samples:
resolutions:
response_code:

Looks good. closing


Add getRange function

The function returns the range of arguments for which the converter is valid.
This PR must be accepted first: https://github.com/JPETTomography/j-pet-framework/pull/251

@kkacprzak Please, have a look if this is enough for your purposes. It does not pass the tests, cause it uses getRange function which is still not accepted in the j-pet-framework repo.

ok. Done.

Cool. Any idea why the tests are not running?

@kkacprzak  Cause this https://github.com/JPETTomography/j-pet-framework/pull/251  hasn't been merged yet.

const class jpet_common_tools::JPetCachedFunction1D}’ has no member named ‘getRange’

@kkacprzak Please review this mentioned PR. I have done it, but it would be good to have a double review before merging.

please retest this

retest this please

Tests passed. @wkrzemien, @kkacprzak, are we ready to merge?

@alekgajos  definitely yes ;)


No remote is found - Probably an authentication problem?

Hi,
I am using Git-Credential-Manager-Core to manage the git authentication. It generates the PAT without me controlling the scopes.
I don't get errors in the logs - just that no remote by that name exists (but it does):
[Debug<PHONE_NUMBER>.065s] azdo_component> Manual personal access token option chosen.
[Debug<PHONE_NUMBER>.669s] PAT token is not provided
[Debug<PHONE_NUMBER>.68s] Looking for git repository
[Debug<PHONE_NUMBER>.68s] Git repository found, initializing review manager and pr tree view.
[Debug<PHONE_NUMBER>.709s] azdo_component> Manual personal access token option chosen.
[Debug<PHONE_NUMBER>.661s] PAT token is not provided
[Debug<PHONE_NUMBER>.662s] Review> Validate state in progress
[Debug<PHONE_NUMBER>.662s] Review> Validating state...
[Debug<PHONE_NUMBER>.665s] No remote with name 'origin' found.
[Debug<PHONE_NUMBER>.665s] No remote with name 'upstream' found.
[Debug<PHONE_NUMBER>.665s] FolderRepositoryManager> Displaying configured remotes: origin, upstream
[Debug<PHONE_NUMBER>.679s] No GitHub remotes found
[Debug<PHONE_NUMBER>.696s] Review> no matching pull request metadata found for current branch master
[Debug<PHONE_NUMBER>.697s] Review> no matching pull request metadata found on GitHub for current branch master
[Debug<PHONE_NUMBER>.649s] Review> Queuing additional validate state
[Debug<PHONE_NUMBER>.649s] Review> Validating state...
[Debug<PHONE_NUMBER>.653s] No remote with name 'origin' found.
[Debug<PHONE_NUMBER>.653s] No remote with name 'upstream' found.

I am unable to "sign in" in the tab because the only option is to "sign out" (which does nothing).

I use mac OSX with the latest vscode.
Wdyt?

Can you share what orgUrl and projectname you have specified?

Hi,
Thank you so much - Would love to help to get this working. I envy Github users having PR work done directly in VS code so just let me know how I can help.
I just got v0.15 updated and I got an option to enter a custom PAT. (did that, correct scopes).
Still I see no PRs - here is the info you requested:
Project Name: Wescover Platform
Url: https://wescover.visualstudio.com
Here is the new log from v0.15:
[Debug<PHONE_NUMBER>.5s] AzdoRepository> projectName is Wescover Platform
[Debug<PHONE_NUMBER>.5s] AzdoRepository> orgUrl is https://wescover.visualstudio.com
[Debug<PHONE_NUMBER>.575s] azdo_component> Manual personal access token option chosen.
[Debug<PHONE_NUMBER>.542s] PAT token is not provided
[Debug<PHONE_NUMBER>.553s] Looking for git repository
[Debug<PHONE_NUMBER>.555s] Git repository found, initializing review manager and pr tree view.
[Debug<PHONE_NUMBER>.555s] AzdoRepository> projectName is Wescover Platform
[Debug<PHONE_NUMBER>.555s] AzdoRepository> orgUrl is https://wescover.visualstudio.com
[Debug<PHONE_NUMBER>.706s] azdo_component> Manual personal access token option chosen.
[Debug<PHONE_NUMBER>.847s] AzdoRepository> projectName is Wescover Platform
[Debug<PHONE_NUMBER>.848s] AzdoRepository> orgUrl is https://wescover.visualstudio.com
[Debug<PHONE_NUMBER>.341s] AzdoRepository> Auth> Successful: Logged userid: <<redacted>>
[Debug<PHONE_NUMBER>.532s] AzdoRepository> Auth> Successful: Logged userid: <<redacted>>
[Debug<PHONE_NUMBER>.019s] Review> Validate state in progress
[Debug<PHONE_NUMBER>.019s] Review> Validating state...
[Debug<PHONE_NUMBER>.023s] No remote with name 'origin' found.
[Debug<PHONE_NUMBER>.023s] No remote with name 'upstream' found.
[Debug<PHONE_NUMBER>.023s] FolderRepositoryManager> Displaying configured remotes: origin, upstream
[Debug<PHONE_NUMBER>.03s] No GitHub remotes found
[Debug<PHONE_NUMBER>.043s] Review> no matching pull request metadata found for current branch master
[Debug<PHONE_NUMBER>.044s] Review> no matching pull request metadata found on GitHub for current branch master

What does git remote -v prints?

Here:
origin  https://wescover.visualstudio.com/DefaultCollection/Wescover%20Platform/_git/wescover-around (fetch)
origin  https://wescover.visualstudio.com/DefaultCollection/Wescover%20Platform/_git/wescover-around (push)

I have published v0.0.16 which shopefully should fix this problem.  Please try it out and let me know. You will need to enter a PAT token if it asks again.

Thank You!
That seems to do it. That domain inclusion by suffix makes sense. We use the old URL structure still.
Btw. It did not ask from the PAT again.
I am playing with the extension and will report any feedback.
Again - If I can help in anyway let me know!


Update Styles of Internal Landing Pages

Two things were changed in the internal landing pages at /dashboard, /lecture and /quizzes.

Content is now centered and a bit wider to look better on larger screens and windows.
Content borders were changed to be more noticeable on those pages.

Let me know if those changes look good.

The styling was also just added to all the internal admin pages and can be viewed at /admin.

Changes look good. Definitely adds to the professionalism of the project. I am merging it in.


What is the use for sleepTime

Nice script, thank you for sharing it, however I'm wondering why is there a 100ms sleep at the end of each iteration ? Is it somehow required for the script to work ?

The sleepTime helps to throttle the rate at which emails are processed to keep it from running into API quotas:
https://developers.google.com/apps-script/guides/services/quotas


Operator Guide Refactor

This Pull Request focuses on enhancing the structure and organization of the operator guide. It aims to break down the existing content into smaller, more manageable pages. This restructuring will significantly improve readability for users and maintainability for our team. As the staking guide evolves and becomes more complex, this modular approach will allow for easier updates and scalability.

@ImmaZoni, made a few minor changes, hope you don't mind!


Adding effects and board generators

Pull Request Test Coverage Report for Build 29

91 of 99 (91.92%)  changed or added relevant lines in 11 files are covered.
29 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-7.4%) to 82.083%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

repository/IngSoft2-Model/BoardGenerator.class.st
0
8
0.0%

Files with Coverage Reduction
New Missed Lines
%

repository/IngSoft2-Model/Player.class.st
3
88.89%

repository/IngSoft2-Model/GameEnded.class.st
9
0.0%

repository/IngSoft2-Model/Game.class.st
17
75.31%

Totals

Change from base Build 18:
-7.4%

Covered Lines:
197

Relevant Lines:
240

💛  - Coveralls

Pull Request Test Coverage Report for Build 29

91 of 99 (91.92%)  changed or added relevant lines in 11 files are covered.
29 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-7.4%) to 82.083%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

repository/IngSoft2-Model/BoardGenerator.class.st
0
8
0.0%

Files with Coverage Reduction
New Missed Lines
%

repository/IngSoft2-Model/Player.class.st
3
88.89%

repository/IngSoft2-Model/GameEnded.class.st
9
0.0%

repository/IngSoft2-Model/Game.class.st
17
75.31%

Totals

Change from base Build 18:
-7.4%

Covered Lines:
197

Relevant Lines:
240

💛  - Coveralls


jenkinsx-quickstart-nuxeo-poc to 1.0.12

Promote jenkinsx-quickstart-nuxeo-poc to version 1.0.12

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-x-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Matters of the Hart - Incorrect Landing Marker Used

During Matters of the Hart, the player's ship may land too far away from Valerie's Cache, which causes issues with Cora's follower package.
Details
00101D8D - This is the ship landing marker that should be used.
Intermittent issue that I have not been able to determine the cause. If you land at the incorrect marker, then Cora and Lillian will not be following you. If you then fast travel to Valerie's Cache from the incorrect landing marker, your ship is no where near there and Cora will just appear. When that happens, she will hang around while you are fighting the Syndicate instead of returning to the ship.
I did attempt to change the marker from ShipLandingMarker_40m_Small [FURN:001D6E5E] to ShipLandingMarker_60m_Medium [FURN:0017DE66]. At first this seemed to fix the issue but when I removed this change and landed again to test it, I landed at the correct marker so I don't think this change actually made a difference. I can't find any other landing markers other than the Syndicate Ship markers, so I'm not sure what marker is being used when landing in the incorrect spot. This may be something that needs to wait for the CK to find the incorrect marker.
I also tried finding a reference near the incorrect marker, but they are all temporary so it didn't help to locate the incorrect marker.
Game Version
1.10.32
Language
English (EN)
Have you recreated this issue on a new game?
Yes, I can recreate this issue.
Reproduction Steps
Do the Matters of the Hart quest and land at Valerie's Cache. Sometimes you land too far away from the cache. It's intermittent.

I had this issue again and took a screenshot of the incorrect marker. I was in a Starborn Guardian ship.

You can see it is 521M away from Valerie's Cache and Lillian does not follow you. I reloaded a save prior to landing several times and landed in the incorrect spot every time. So I tried changing 00101D8D from ShipLandingMarker_40m_Small [FURN:001D6E5E] to ShipLandingMarker_60m_Medium [FURN:0017DE66] but it didn't work, so then I tried changing it to ShipLandingMarker_80m_Large [FURN:00007145] and now it works, so I think this is the fix for it.
Fix attached:
MattersOfTheHartShipLandingFix.zip


only "from", "st" and "type" is received in typing indicator event

Not sure if this would be the correct fix. But I was having issue due to this.

Can you share what data is actually received in the event?  It seems like we should probably be getting more than event.st and event.from_mobile.  It doesn't really make sense to return empty string as a threadID, for instance.

Sorry, can't seem to reproduce this issue right now. I'll try to post data as soon as I get that issue again.

Ok, feel free to reopen when you're able to reproduce it.


riscv: Enabling IRQ vector table makes Zephyr unbootable

Describe the bug
Enabling IRQ vector table (CONFIG_GEN_IRQ_VECTOR_TABLE=y) for RISC-V causes the firmware image to become unbootable because the IRQ vector table is placed in the ROM_START section and, since #49810, the ROM_START section precedes the vectors section, which contains the start-up code:
https://github.com/zephyrproject-rtos/zephyr/blob/8563744997a057780a30b5566de8acfe699b3f9d/arch/common/CMakeLists.txt#L27-L31
See also https://github.com/zephyrproject-rtos/zephyr/pull/49810#issuecomment-1235684318
To Reproduce
scripts/twister -v -N -M --arch riscv -s tests/kernel/gen_isr_table/arch.interrupt.gen_isr_table.riscv_direct

Expected behavior
vectors section comes before the IRQ vector table section.
Impact
RISC-V images are unbootable with CONFIG_GEN_IRQ_VECTOR_TABLE=y
Logs and console output
No output (hangs on boot)
Environment (please complete the following information):

OS: Ubuntu 20.04
Toolchain: Zephyr SDK 0.15.0
Commit SHA: a5ee862ff0b857ff98357bf5f4e9cd1568c178f3

Additional context
The affected test (arch.interrupt.gen_isr_table.riscv_direct) will be disabled for now, with a reference to this issue.
This issue should eventually be fixed by placing the vectors section through the zephyr_linker_sources(ROM_START ...), as done in the ARM architecture port, such that its order can be adjusted using the SORT_KEY parameter.

cc @msierszulski @carlocaione @tgorochowik @kgugala @pgielda

Hi @stephanosio, can you please assign me to this issue? I will start working on it as soon as possible.

Hi @stephanosio, can you please assign me to this issue? I will start working on it as soon as possible.

Done. Thanks.


[dip-1] add trade_ids in PaymentObject

The motivation is to support passing trade_ids in Off Chain / Travel Rule protocol, such that mapping among trade_id, reference_id and on chain transfer can be mapped.
Please see details in https://docs.google.com/document/d/1DNaRzSjHGU7HD8xrEbU_cg3JY5apQI5VQcIpHM44EAI/edit?usp=sharing

per conversation, please move this to an issue -- we could consider this another dip though too or at least leave it in a draft state


Show / hide save icon

Is there a way to show or hide the save icon?

No there isn't a way to do that yet, however I do plan on allowing that in a newer version soon.


calling scope.$apply only when digest cycle is not in progress

calling scope.$apply only when digest cycle is not in progress

How about $scope.evalAsync @ramana-chavakula ?


What are the steps to build the tunneler

Hi @dkmstr ,

What are the steps to build the tunneler?
https://github.com/dkmstr/openuds/tree/master/guacamole-tunnel

It build a war : transport.war
/target$ ls
classes  generated-sources  maven-archiver  maven-status  transport  transport.war  war
Now Do I need to deploy this transport.war using tomcat?

I created an internal user using internal DB and associated the group for it and able to login. Is this enough?

Do I need to install the Actor in the VM from which I need to create a VDI ? Or where exactly I need to install the Actor?

After doing all these do I need to install any plugin in my client machine to access the HTML5 RDP from browser?

Thanks,
Harry

@dkmstr Could you check this please ?


Create docker-publish.yml to publish docker image to GitHub container registry

Can we do this via Goreleaser?


Ideal PV devices are not supported

One cannot define resistance_series = 0 or resistance_shunt = numpy.inf as "ideal" device parameters in pvlib.pvsystem.singlediode(). See the error below for example.
Is this feature valued enough for me to make a PR that adds this capability?
Input:
import sys
print("Python version: %s.%s.%s" % sys.version_info[:3])

import numpy as np
print("Numpy version: " + np.version.version)

import scipy as sp
print("Scipy version: " + sp.version.version)

import pvlib

i_ph_A = 2.13643772
i_rs_A = 2.10905501e-05
n_mod_V = 9.91331584
r_s_Ohm = 3.63866316
r_s_Ohm = 0.
g_p_Mho = 2.45880685e-03

pvlib.pvsystem.singlediode(i_ph_A, i_rs_A, r_s_Ohm, 1./g_p_Mho, n_mod_V)

with output:
Python version: 3.6.1
Numpy version: 1.12.1
Scipy version: 0.19.0
/Users/markcampanelli/anaconda3/lib/python3.6/site-packages/pvlib/pvsystem.py:1943: RuntimeWarning: divide by zero encountered in true_divide
  I = -V/(Rs + Rsh) - (nNsVth/Rs)*lambertwterm + Rsh*(IL + I0)/(Rs + Rsh)
/Users/markcampanelli/anaconda3/lib/python3.6/site-packages/pvlib/pvsystem.py:1943: RuntimeWarning: invalid value encountered in double_scalars
  I = -V/(Rs + Rsh) - (nNsVth/Rs)*lambertwterm + Rsh*(IL + I0)/(Rs + Rsh)
Out[1]:
OrderedDict([('i_sc', nan),
             ('v_oc',<PHONE_NUMBER>5555131),
             ('i_mp', nan),
             ('v_mp', 0.02227117920245893),
             ('p_mp', nan),
             ('i_x', nan),
             ('i_xx', nan)])

Update: Sufficiently large values of resistance_shunt cause numerical issues as well. I'm not sure about the computational overhead to detect large Rsh issues and then possibly swap in the infinite shunt resistance approximation as appropriate.
Very small, yet strictly positive, resistance_series values seem to be better behaved in pvlib.pvsystem.singlediode(), which appears to rely heavily on pvlib.pvsystem.i_from_v().  I have not explored the "edge" behavior of pvlib.pvsystem.v_from_i(), but that is apparently called in pvlib.pvsystem.singlediode() to get Voc.
My concern here is that sometimes parameter fitting routines return resistance values that are at/near these edge cases.

I support these additions. Perhaps we set a threshold above which Rsh is considered as Inf. Mark can you post a set of parameters which give trouble with high Rsh?
Sent from my iPhone
On May 10, 2017, at 7:02 PM, Mark Campanelli <notifications<EMAIL_ADDRESS>wrote:
Update: Sufficiently large values of resistance_shunt cause numerical issues as well. I'm not sure about the computational overhead to detect large Rsh issues and then possibly swap in the infinite shunt resistance approximation as appropriate.
Very small, yet strictly positive, resistance_series values seem to be better behaved in pvlib.pvsystem.singlediode(), which appears to rely heavily on pvlib.pvsystem.i_from_v(). I have not explored the "edge" behavior of pvlib.pvsystem.v_from_i(), but that is apparently called in pvlib.pvsystem.singlediode() to get Voc.
My concern here is that sometimes parameter fitting routines return resistance values that are at/near these edge cases.

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/pvlib/pvlib-python/issues/324#issuecomment-300653372, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFJNL7gVnfi7t6TUEU-2fNFzLUABd_3rks5r4l4dgaJpZM4NXYRV.

Solving the single diode equation is a lot easier when there is an infinite shunt resistance.  I would suggest implementing a simpler solver to handle that case, if the general solver has trouble.

I agree this would be a useful feature. A threshold seems reasonable.
Also relevant: #298, #268, #266, #260. We're waiting on a test case for #298.

In my own code I compute the explicit ideal model first (depends on
I_from_V vs. V_from_I case), then replace values at those indices that
produce a lower absolute residual for the implicitly computed model. It is
perhaps not the most efficient, but it does not require arbitrary
thresholds. I would provide benchmarking if I pursued that path for this PR.
Will: Thanks for the other issue references. Hope to review soonish.
Cliff: I think Rsh=1.e10 in the previous dataset should generate an exp
overflow in the Voc computation. However, the function seems to still
return reasonable values.
On Thu, May 11, 2017 at 09:38 Will Holmgren<EMAIL_ADDRESS>wrote:

I agree this would be a useful feature. A threshold seems reasonable.
Also relevant: #298 https://github.com/pvlib/pvlib-python/pull/298, #268
https://github.com/pvlib/pvlib-python/pull/268, #266
https://github.com/pvlib/pvlib-python/pull/266, #260
https://github.com/pvlib/pvlib-python/pull/260. We're waiting on a test
case for #298 https://github.com/pvlib/pvlib-python/pull/298.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pvlib/pvlib-python/issues/324#issuecomment-300829014,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABEr84_LQjgEWIGdZSBwvDgfgc9RXNEoks5r4ytpgaJpZM4NXYRV
.

--
Please check out this site: www.thestoryofstuff.com

I haven't forgotten about this. I think I may have a new solution here that covers both the typical and edge cases cleanly, efficiently, flexibly with respect to various input dimensions, and with surprisingly little code (leveraging numpy's ufunc's). My only question is how well the new algorithm converges for devices with very high series resistance (in the current computation given voltage) and/or low shunt resistance (in the voltage computation given current).
At the risk of appearing lazy here, can anyone point me to the specific unit tests around computing I-V curves?

These are probably the most relevant:
https://github.com/pvlib/pvlib-python/blob/master/pvlib/test/test_pvsystem.py#L357-L379
There are some other tests in test_pvsystem.py that calculate these parameters, but they don't push the algorithm to its limits.

@wholmgren Thanks for the unit test ref's. I need some guidance on how to set up my local fork to allow me to run unit tests with pytest. Currently, I use pip to do a re-install of my local fork before I can run the unit tests against any code change using pytest pvlib/test/test_pvsystem.py from the root of my fork. This is far from ideal. How do I run unit tests when pvlib-python is not pip installed?

Just to confirm: you ran pip install -e . from your cloned pvlib-python directory? As far as I know, that's the right thing to do. If you want to separate a clean pvlib from your development pvlib, then you probably should use conda environments or python's own virtual environments. I could have misunderstood something, though.

Yeah, it looks like I missed the -e part. I will give that a try. Thanks
yet again.
On Thu, Jun 8, 2017 at 12:42 Will Holmgren<EMAIL_ADDRESS>wrote:

Just to confirm: you ran pip install -e . from your cloned pvlib-python
directory? As far as I know, that's the right thing to do. If you want to
separate a clean pvlib from your development pvlib, then you probably
should use conda environments or python's own virtual environments. I could
have misunderstood something, though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pvlib/pvlib-python/issues/324#issuecomment-307191824,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABEr8-rsceFfAH0smsmCy6WgjNa4ox15ks5sCEB-gaJpZM4NXYRV
.

@wholmgren pvlib.pvsystem.i_from_v() indicates that it returns "current : np.array". However, test_i_from_v() takes python scalars as input arguments and returns a numpy.float64, not a numpy.ndarray. Is numpy.float64 considered a subtype of np.array? More generally, what is the difference between numpy.array and numpy.ndarray?

The numpy array type is ndarray, not array. The array function creates ndarray objects. So, the i_from_v docstring should read "current: np.ndarray or np.float64"
numpy.float64 is not a subtype of np.ndarray:
>>> isinstance(np.float64(5), np.ndarray)
False

Thanks for clarifying. These types behave a bit strange under the simplest of operations:
print(type(np.array(1.)))
print(type(np.array(1.) + np.array(1.)))

returns
<class 'numpy.ndarray'>
<class 'numpy.float64'>

Yeah, I've never fully understood the type or broadcasting rules for numpy scalar or scalar-like arrays. The important thing for our function is that if you put scalars in, you get a scalar-like thing out, and if you put arrays in, you get arrays out. Other pvlib functions also guarantee that if you put a Series in, you get a series out, but this one does not.

Draft PR created: https://github.com/pvlib/pvlib-python/pull/340


Backup Upload Failed

Output of bench version
erpnext 13.x.x-develop
frappe 13.x.x-develop
nextcloud_integration 0.0.1

Steps to reproduce the issue

Install according to Readme
set settings, save
backup now

Observed result
Got an Email to "Send Notifications To" with back log, see below.
There are no files uploaded/backed up.
Expected result
Successful backup
Stacktrace / full error message
Error message: Traceback (most recent call last):
 File "/home/erpnext/erpnext-test/env/lib/python3.9/site-packages/urllib3/connectionpool.py", line 670, in urlopen httplib_response = self._make_request(
 File "/home/erpnext/erpnext-test/env/lib/python3.9/site-packages/urllib3/connectionpool.py", line 426, in _make_request six.raise_from(e, None)
 File "", line 3, in raise_from
 File "/home/erpnext/erpnext-test/env/lib/python3.9/site-packages/urllib3/connectionpool.py", line 421, in _make_request httplib_response = conn.getresponse()
 File "/usr/lib/python3.9/http/client.py", line 1347, in getresponse response.begin()
 File "/usr/lib/python3.9/http/client.py", line 307, in begin version, status, reason = self._read_status()
 File "/usr/lib/python3.9/http/client.py", line 268, in _read_status line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
 File "/usr/lib/python3.9/socket.py", line 704, in readinto return self._sock.recv_into(b)
 File "/home/erpnext/erpnext-test/env/lib/python3.9/site-packages/urllib3/contrib/pyopenssl.py", line 318, in recv_into raise SocketError(str(e)) OSError: (104, 'ECONNRESET') During handling of the above exception, another exception occurred: Traceback (most recent call last):
 File "/home/erpnext/erpnext-test/env/lib/python3.9/site-packages/requests/adapters.py", line 439, in send resp = conn.urlopen(
 File "/home/erpnext/erpnext-test/env/lib/python3.9/site-packages/urllib3/connectionpool.py", line 724, in urlopen retries = retries.increment(
 File "/home/erpnext/erpnext-test/env/lib/python3.9/site-packages/urllib3/util/retry.py", line 403, in increment raise six.reraise(type(error), error, _stacktrace)
 File "/home/erpnext/erpnext-test/env/lib/python3.9/site-packages/urllib3/packages/six.py", line 734, in reraise raise value.with_traceback(tb)
 File "/home/erpnext/erpnext-test/env/lib/python3.9/site-packages/urllib3/connectionpool.py", line 670, in urlopen httplib_response = self._make_request(
 File "/home/erpnext/erpnext-test/env/lib/python3.9/site-packages/urllib3/connectionpool.py", line 426, in _make_request six.raise_from(e, None)
 File "", line 3, in raise_from
 File "/home/erpnext/erpnext-test/env/lib/python3.9/site-packages/urllib3/connectionpool.py", line 421, in _make_request httplib_response = conn.getresponse()
 File "/usr/lib/python3.9/http/client.py", line 1347, in getresponse response.begin()
 File "/usr/lib/python3.9/http/client.py", line 307, in begin version, status, reason = self._read_status()
 File "/usr/lib/python3.9/http/client.py", line 268, in _read_status line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
 File "/usr/lib/python3.9/socket.py", line 704, in readinto return self._sock.recv_into(b)
 File "/home/erpnext/erpnext-test/env/lib/python3.9/site-packages/urllib3/contrib/pyopenssl.py", line 318, in recv_into raise SocketError(str(e)) urllib3.exceptions.ProtocolError: ('Connection aborted.', OSError("(104, 'ECONNRESET')")) During handling of the above exception, another exception occurred: Traceback (most recent call last):
 File "/home/erpnext/erpnext-test/apps/nextcloud_integration/nextcloud_integration/nextcloud_integration/doctype/nextcloud_setting/nextcloud_setting.py", line 26, in start_taking_backup self.backup_to_nextcloud(upload_db_backup)
 File "/home/erpnext/erpnext-test/apps/nextcloud_integration/nextcloud_integration/nextcloud_integration/doctype/nextcloud_setting/nextcloud_setting.py", line 58, in backup_to_nextcloud self.check_for_upload_folder()
 File "/home/erpnext/erpnext-test/apps/nextcloud_integration/nextcloud_integration/nextcloud_integration/doctype/nextcloud_setting/nextcloud_setting.py", line 135, in check_for_upload_folder response = self.session.request("PROPFIND", self.upload_path, headers={"Depth": "0"}, allow_redirects=False)
 File "/home/erpnext/erpnext-test/env/lib/python3.9/site-packages/requests/sessions.py", line 530, in request resp = self.send(prep, **send_kwargs)
 File "/home/erpnext/erpnext-test/env/lib/python3.9/site-packages/requests/sessions.py", line 643, in send r = adapter.send(request, **kwargs)
 File "/home/erpnext/erpnext-test/env/lib/python3.9/site-packages/requests/adapters.py", line 498, in send raise ConnectionError(err, request=request) requests.exceptions.ConnectionError: ('Connection aborted.', OSError("(104, 'ECONNRESET')"))

Might be related:
https://stackoverflow.com/questions/43165341/python3-requests-connectionerror-connection-aborted-oserror104-econnr

@knudeh I just ran this on v12 and it works. I will try it on v13 soon and let you know if I had a similar problem.

It's also not working here.
Output of bench version
ERPNext: v13.0.2 (version-13)
Frappe Framework: v13.0.3 (version-13)
Nextcloud Integration: v0.0.1 (HEAD)

Stacktrace / full error message
Error message: ./xxxx.frappe.cloud/private/backups/20210422_121022-xxxx_frappe_cloud-database.sql.gz - Failed while uploading Site Config ./xxxx.frappe.cloud/private/backups/20210422_121022-werock1_frappe_cloud-site_config_backup.json - Failed while uploading DB Traceback (most recent call last): File "/home/frappe/frappe-bench/apps/nextcloud_integration/nextcloud_integration/nextcloud_integration/doctype/nextcloud_setting/nextcloud_setting.py", line 28, in start_taking_backup raise Exception Exception

Additional information
Installed via Frappcloud

Follow-up:

moved nextcloud to a differnet server, might be unrelated

some bench update inbetween

got a differnet error:
File "/home/erpnext/erpnext-test/apps/frappe/frappe/utils/backups.py", line 443, in take_dump frappe.utils.execute_in_shell(command, low_priority=True) TypeError: execute_in_shell() got an unexpected keyword argument 'low_priority'
Removed ", low_priority=True" and got successful backup

Checked "Backup Files"
File "/home/erpnext/erpnext-test/apps/frappe/frappe/utils/backups.py", line 329, in backup_files frappe.utils.execute_in_shell( TypeError: execute_in_shell() got an unexpected keyword argument 'low_priority' and backup failed again

frappe/frappe/utils/init.py
310  def execute_in_shell(cmd, verbose=0, low_priority=False):

I repaired the nextcloud long time ago for my version 13 installation, can you try my version?
https://github.com/thejoe8495/nextcloud-integration


Define interfaces for the plugins

[X] URL Filter
[X] Fetcher
[X] Parser
[X] URL Normalizer
[ ] Extractor
[ ] Generator

PS
this is incomplete list

Status Update :
We have defined URLFilter and URLNormalizer.
The remaining will be done once we started integrating Nutch's plugins using plugin frawework

@thammegowda, where can I find the code for the completed issues, maybe I could use that as example before starting development of new plugin ? Is there a commit linked to the issue number ?

We dont have a proper documentation at the moment (Adding to my todo list to work on it, thanks for reporting).
Meanwhile: here is how I added a new plugin: https://github.com/USCDataScience/sparkler/pull/100
If you need to define a plugin, the interfaces+baseclasses here could be examples: https://github.com/USCDataScience/sparkler/tree/master/sparkler-api/src/main/java/edu/usc/irds/sparkler
TODO: update the wiki with proper docs.

Quick Quesiton,
What is the parser extension point?

@micheladennis  Sorry, there was no extension point added to Parser at the moment.
This video might help to add a new plugin https://www.youtube.com/watch?v=Ib8OwmoRj-Q


Automated cherry pick of #1537: add ldapcli rpm

Cherry pick of #1537 on release/2.11.0.
#1537: add ldapcli rpm

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11.0@d037d7f). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/2.11.0   #1539   +/-   ##
================================================
  Coverage                  ?   7.67%
================================================
  Files                     ?     411
  Lines                     ?   62919
  Branches                  ?       0
================================================
  Hits                      ?    4828
  Misses                    ?   57681
  Partials                  ?     410

Flag
Coverage Δ

#aFlag
7.67% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d037d7f...ebc86e9. Read the comment docs.

/approve
/lgtm


Feature/configuration dashboard

Goal of PR
Please describe exactly what the goal of your PR is (and link to any relevant issues)
Implementation
Describe how that goal was achieved through the submitted implementation.
Manual Testing
Describe how the new functionality can be tested manually.
Automated Testing
Describe the automated testing you included which covers any and all new functionality.
Submission Checklist

[ ] Based on correct branch: feature submissions should be on develop, hotfixes should be on master

[ ] The code passes our eslint definitions, unit tests, and
contains correct TypeFlow annotations.

[ ] Submission contains tests that cover any and all new functionality or code changes.

[ ] Submission documents any new features or endpoints, and describes how developers
would be expected to interact with them.

[ ] Author has agreed to our contributor's agreement.

reply

wow, this is a big PR.....it'll take some time to go through it


The firmware was uploaded but nothing's happening.

I have followed the guide on how to configure the hardware of linorobot, and got past the point of uploading firmware onto the Teensy 4.0 (everything up to this point is successful). However, once I try and drive it around and enter the keys to move it forward and backward nothing happens. I have looked at the troubleshooting guide, but I am very confident I am using the Teensy 4.0.

Could you describe what's your setup like (OS, ROS2 Distro)? Are you running any of the OS on a VM?

I am using Ubuntu 20.04.1 and ROS2 Foxy. I am able to get to the point on the terminal where it shows me the keys and how to operate it. The motors are spinning when I am using the calibration software and in the right orientation.

Is the Teensy’s LED flashing even without pressing any keys?

It isn't flashing.

The LED is on when this command is run ros2 run micro_ros_agent micro_ros_agent serial --dev /dev/ttyACM0.

Could you try uploading a simple microros 'hello world' firmware using this https://github.com/linorobot/micro_ros_platformio. Use the same platformio config as linorobot2.
It's supposed to publish an incrementing number on micro_ros_arduino_node_publisher topic.

Thank you for your advice! We've managed to upload the "hello world" firmware. Unfortunately, the nodes are not being set up and the topics are not advertised as shown in these screenshots. We appreciate any advice on how to proceed

.

Looks like you have one more device in the /dev/ttyACM* port. Can you confirm that you are assigning the correct serial port?

I am still having the issue. Where the calibration when run using screen /dev/ttyACM0. I get the wheels to spin forward, I get the encoders values etc. However when I try and run telop nothing is happening, it doesn't even move forward.  Is it possible I am configuring it wrong?

I've updated the firmware recently, could you pull and try the latest version?

Will do so, and let you know. Is it possible that the reason for the robot to not move after the calibration is likely due to micro_ros not communicating with the teensy board. Because as far as I can see the calibration doesn't require micro_ros.

yes could be related to this https://github.com/linorobot/linorobot2_hardware/commit/5220465a93f59b0763719397de1c76aa076b1e59

hey @Shromm-Gaind. Did my previous answer resolve your issue? Could you try uploading the most recent firmware

I have done so, but teleop_twist_keyboard still doesn't work. I think it is just micro_ros, but when I run the agent, there are no bugs or problems.

are you running teleop_twist_keyboard from the same machine where the agent resides?

Yes

does the Teensy's LED flash (fast rate) when you press a control key from teleop_twist_keyboard

No, should it?

Just curious aside from the robot's Teensy controller, are there any USB device connected to the robot's computer? If so, could you remove everything except the Teensy controller? Just to ensure there's no serial port clash or anything.

No, there are no other serial connections

Alright, it seems that the agent is not picking up the Twist msgs. The Teensy's LED is supposed to flash when Twist commands are received. Could you do this simple agent test https://github.com/linorobot/micro_ros_platformio and check if you're able to echo the data.

I believe that it might be my Teensy having some problem at this point. I have a spare one at my uni. Will try that out and let you know.

Alright, let me know how the agent test go. Thanks

I have managed to solve the issue, I did replace the teensy, but that did not work as expected. But, I swapped from using a Intel Nuc to a raspberry pi 4 and it seems to work.

I should have checked earlier if the Nuc was compatible, my fault. Thanks a lot with the help though.

Thanks! Closing this for now


Data must be string or a buffer error when used with Docker

317b166889313b430e3c0c1a83a1fe432f39018f introduced a bug on L14.
babel-cli uses this, and when run outside a Docker container, there are no issues. However, when run in a Docker container, it causes it to fail. See the following:
2017-04-18T21:34:13.275287181Z crypto.js:74
2017-04-18T21:34:13.275330167Z   this._handle.update(data, encoding);
2017-04-18T21:34:13.275333714Z                ^
2017-04-18T21:34:13.275336783Z
2017-04-18T21:34:13.275339442Z TypeError: Data must be a string or a buffer
2017-04-18T21:34:13.275342154Z     at Hash.update (crypto.js:74:16)
2017-04-18T21:34:13.275344873Z     at Object.<anonymous> (/app/node_modules/v8flags/index.js:14:81)
2017-04-18T21:34:13.275348204Z     at Module._compile (module.js:571:32)
2017-04-18T21:34:13.275351214Z     at Object.Module._extensions..js (module.js:580:10)
2017-04-18T21:34:13.275353766Z     at Module.load (module.js:488:32)
2017-04-18T21:34:13.275356293Z     at tryModuleLoad (module.js:447:12)
2017-04-18T21:34:13.275358778Z     at Function.Module._load (module.js:439:3)
2017-04-18T21:34:13.275361353Z     at Module.require (module.js:498:17)
2017-04-18T21:34:13.275363884Z     at require (internal/module.js:20:19)
2017-04-18T21:34:13.275367458Z     at Object.<anonymous> (/app/node_modules/babel-cli/lib/babel-node.js:3:18)

Bumping into the same...

We are seeing the same error running gulp inside of a docker container on Shippable.

So your users are all undefined? I'll get a patch out shortly, but you might not like it

Containers do not have defined users as far as I know.

Published a fix as 2.1.1 that defaults user to an empty string.  @techwizrd thanks for the quick, detailed report.

You're welcome. Thanks for the quick fix!


PRESETS Not working as expected

Lastest buids of API and Echo-Sonos
I've setup a number of presets. Instead of using the default names for presets, I want to use my own names.
My understanding is that Preset is the default behavior.
Now if I issue the command "ask sonos to play PRESET" some work and others don't.
They all work if I issue the command "ask sonos to play preset PRESET" but that gets to be a mouthful. I'd rather not to have to say preset, just the preset name.
 Please read my first post to see my problem. Thanks!

Do you have advanced mode turned on in your settings?  If not, then the solution should follow the old behavior where everything is considered a preset.  In that case, you want to make sure that your PRESETS slot contains all of your desired values or the Alexa service translation will lose accuracy.
If Advanced Mode is turned on then there are two ways to invoke PRESETS, one by saying "play preset...", and another by changing your current music service to "presets" and then simply saying "play PRESET".

@jplourde5  Yes I have advanced mode turned on. I do have PRESETS slots of all my desired values.
I've set preset as the default behavior in settings. I verify I am in preset mode by issuing command "Alexa, ask sonos to change music to presets"
For example if I use the Developer Console Test page and type in the command I can see the Lambda Request.
  It seems to be "Room".  If that is not right, try saying "Ask Sonos to change room to XXXX.
If that doesn't fix it, look at the values in DynamoDB and see what it has for service and room.

@jplourde5 When you say actual name of room, what do you mean? I am just trying to call a PRESET that groups some rooms together. In the above examples the rooms are master bedroom and maser bathroom.
I notice the first try the intent is "name": "PlayPresetIntent",
The next try the intent name is "name": "MusicIntent",

Try "Alexa, Ask Sonos to change room to Master Bedroom"
And then try again.
In Advanced Mode, Presets is not the default and you would normally need to say "Alexa, Ask Sonos to play preset xxx".  However, if Presets is your current music service, it should work without having to say "presets".  The one odd thing that I see with:
"intent": {
"name": "MusicIntent",
"slots": {
"Room": {
"name": "Room"
},
"Name": {
"name": "Name",
"value": "master eagles"
Is that the room name is set to "Room".  "Room" should be showing as Master Bedroom, Master Bath, etc., and I'm wondering if you have a blank value stored in the defaults used by Advanced mode. I understand that Presets specify their own rooms, but I'm just wondering if the "Room" value is breaking something.

@jplourde5 Setting room to master bedroom had no effect. I don't see a blank value.

Tried "ask sonos to play master seventies rock" with same results.
"intent": {
"name": "PlayPresetIntent",
"slots": {
"Preset": {
"name": "Preset",
"value": "70s rock"
},
"Room": {
"name": "Room"

@jplourde5 I took a look at what happens when I try and set room to ROOM. Something looks wrong to me here.
"ask sonos to change room to master bedroom"
"intent": {
"name": "ChangeRoomIntent",
"slots": {
"Room": {
"name": "Room"
}
If I try "ask sonos to change service to library" I get the result I would expect.
"intent": {
"name": "ChangeServiceIntent",
"slots": {
"Service": {
"name": "Service",
"value": "library"
}

@jplourde5 I turned off advanced mode in options.js and uploaded files.
I tried "ask sonos to play master seventies rock"
Same results as before:
"intent": {
"name": "PlayPresetIntent",
"slots": {
"Preset": {
"name": "Preset",
"value": "70s rock"
},
"Room": {
"name": "Room"
}

@jplourde5
If I add preset then it works. "ask sonos to play preset master seventies rock"
"intent": {
  "name": "PlayPresetIntent",
  "slots": {
    "Preset": {
      "name": "Preset",
      "value": "master 70s rock"
    },
    "Room": {
      "name": "Room"
    }

The PlayPresetIntent should have already been there.
{
"intent": "PlayPresetIntent",
"slots": [
{
"name": "Preset",
"type": "PRESETS"
},
{
"name": "Room",
"type": "ROOMS"
}
]
},
And you should have a PRESETS slot definition that includes "master 70s rock" as well as any other preset names that you have, and the preset names will need to match the spelling of your actual presets.
Here is what happens.

You utter something to the Echo and it sends it to the Alexa cloud solution

It tries to match what you uttered to something in your PRESETS slot values or makes a best guess at what you said if it can't find something that looks close

It passes what it arrives at for the the preset value to your Lambda function

The Lambda function passes the preset value to the node-sones-http-api solution spelled exactly as it was passed from the Alexa function

The spelling has to match exactly the spelling of your preset in the n-s-h-a or the preset will not play

What could easily be happen is that the Alexa solution is not getting your spelling right.  Check your history in the Alexa app on your mobile device and see what it is arriving at for the spelling.

First thanks for your help. This is a complicated problem and I am trying to give you detailed information on the problem.
I do have slot definitions setup for each and every preset name. Each preset slot name matches the spelling of an actual presets.json.
Slot Name = Preset.json name
Slot name, "master 70s rock" has a json file name "master 70s rock.json" as are all other presets setup.
For testing purpose I am using the Amazon Developer Console > Test > Service Simulator. Using the Service Simulator I can see exactly what the "Lambda Request" sent to the api is.
I am copying and pasting the Preset Name to the Amazon Developer Console Test's "Enter Utterance" field to ensure that utterance is spelled correctly and matches the Slot Name and json file name.
For a test I enter the commands in the Amazon Developer Console Service Simulator.
There is a Slot Name "master 70s rock" in Custom Slot Types PRESETS. There is a also a "master 70s rock.json" file.
Enter Utterance:
ask sonos to play master seventies rock
The Lambda Request response:
"intent": {
"name": "PlayPresetIntent",
"slots": {
"Preset": {
"name": "Preset",
"value": "70s rock"
},
"Room": {
"name": "Room"
}
There can be no mistake that "play master seventies rock" was asked, as it is typed in, not spoken. The Lambda Request, for whatever reason, drops master and passes on the value "70s rock" instead of "master 70s rock"
It makes no difference if I use the simulator or speaking into Amazon Echo device. The results are the same. Some work, others don't. The ones that work, always work and the ones that don't, always don't.
My first post has examples of what works and what does not. Each of the presets had a slot entry and a json file named the same.
Again if I just add the word preset to the command then they all work. But if I have PRESETS set as default then I should not have to say play preset PRESET.
I don't think it's just a spelling error but something seems to be wrong in the Interaction Model.
Thanks for your help.

I just tried another test. I removed all the slot names except those that start with master. When there is only these entries then all master presets work.

So here is what I've discovered.
 I suspect that it could be getting confused by some of the similarities in the names.

Yea I'm think your right. Either I just add preset to the command or mess around with names that are going to work.

I have found a solution that works for me so far. I only use presets and the library services. I am using Amazon Prime for steaming music so can't use the API search features like available if I had Spotify.
My solution was to add "PlayPresetIntent play {Preset}" to the Alexa Skills Interactive model Sample Utterances. Now presets work the way I wanted. I ran a few test and all else seems to be working correctly. I am not sure if this change would effect Streaming Music Search or not as I can't test that, but Library still worked correctly searching for artist or album.
If I run into something that this change effects I'll post back here.

@GregRocket, thanks for closing the loop.  @jplourde5 - does this change break anything for you?  My rpi is packed away in a box somewhere while I do some remodeling work, so I can't test this.

@rgraciano Preset have been working perfectly now. I can also just drop a new preset.json file into the preset directory and the preset becomes instantly available. No need to add the preset to the Custom Slot Types PRESETS in developer console.

@GregRocket, I was actually concerned about the other stuff - whether or not this might break some of the advanced mode features.  The Alexa interpreter seems to work in mysterious ways

@rgraciano Yes, my concern also. But presets work so good now, the way they should. Library function works properly as does pause, resume, volume etc. The only thing I can not test is a streaming radio service such as spotify search function.

It shouldn't break anything.  I thought that the PlayPresetIntent was already there.  It was when I last checked.  Were any other changes made?

@jplourde5
Line 135 PlayPresetIntent play preset {Preset} was there I added PlayPresetIntent play {Preset} just below this line. No other changes were made.

I think that will break everything else and why I included an advanced mode. The play intent will use presets if advanced mode is turned off.

@jplourde5 By everything else do you mean streaming radio services like Spotify? I only use the library search and presets modes and they work fine. Also I use Amazon music but that as you know has no search feature.

In my earlier testing the Alexa code would get confused about whether it was the play preset or play music service intent that was being called because they both start the same way, "Play xxx"


How to use  Albumentations？can you give me an example？

configs/albu_example/mask_rcnn_r50_fpn_1x.py

@PanJianning How to use some augmentions  in albumentations?

@PanJianning How to use some augmentions in albumentations?

Why don't you just look at the examples？

configs/albu_example/mask_rcnn_r50_fpn_1x.py

@PanJianning  I want to know why the ap is lower with ablu data aug than without ablu? very appreciate for your reply

how to add the albumentations into voc0712.py, I know that I need to add albu_train_transforms list before the train_pipeline, But i'm not sure to modify the train_pipeline.
I see the mask_rcnn_r50_fpn_albu_1x_coco.py, there are keymap and meta_keys,should i delete them?

configs/albu_example/mask_rcnn_r50_fpn_1x.py

@PanJianning I want to know why the ap is lower with ablu data aug than without ablu? very appreciate for your reply

Do you have the answer? I have the same problem.

configs/albu_example/mask_rcnn_r50_fpn_1x.py

@PanJianning I want to know why the ap is lower with ablu data aug than without ablu? very appreciate for your reply

Do you have the answer? I have the same problem.

this should depends on your dataset

configs/albu_example/mask_rcnn_r50_fpn_1x.py

@PanJianning I want to know why the ap is lower with ablu data aug than without ablu? very appreciate for your reply

Do you have the answer? I have the same problem.

this should depends on your dataset

configs/albu_example/mask_rcnn_r50_fpn_1x.py

@PanJianning I want to know why the ap is lower with ablu data aug than without ablu? very appreciate for your reply

Do you have the answer? I have the same problem.

this should depends on your dataset

Thank you for your reply。I use a medical image data set, why would this cause this situation？So should I use data augmentation？

configs/albu_example/mask_rcnn_r50_fpn_1x.py

@PanJianning I want to know why the ap is lower with ablu data aug than without ablu? very appreciate for your reply

Do you have the answer? I have the same problem.

this should depends on your dataset

configs/albu_example/mask_rcnn_r50_fpn_1x.py

@PanJianning I want to know why the ap is lower with ablu data aug than without ablu? very appreciate for your reply

Do you have the answer? I have the same problem.

this should depends on your dataset

Thank you for your reply。I use a medical image data set, why would this cause this situation？So should I use data augmentation？

you can analysis your dataset and choose which aug should be effective.

configs/albu_example/mask_rcnn_r50_fpn_1x.py

@PanJianning I want to know why the ap is lower with ablu data aug than without ablu? very appreciate for your reply

Do you have the answer? I have the same problem.

this should depends on your dataset

configs/albu_example/mask_rcnn_r50_fpn_1x.py

@PanJianning I want to know why the ap is lower with ablu data aug than without ablu? very appreciate for your reply

Do you have the answer? I have the same problem.

this should depends on your dataset

Thank you for your reply。I use a medical image data set, why would this cause this situation？So should I use data augmentation？

you can analysis your dataset and choose which aug should be effective.

Ok, thank you very much

Why don't you just look at the examples？

because the link is 404.

Why don't you just look at the examples？

because the link is 404.

@muyuuuu Try to check on configs/albu_example/mask_rcnn_r50_fpn_1x.py

How we can specify different pipeline for train and val set with albumentation?


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/69028

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/69066


Array Printout

Array Printout B.01.01.WP07
Name of Class
ArrayPrintout
What
Returns a recursive array structure of the entire B-Tree data structure for parsing use in the GUI.
Requirements

Each node will have an array of length 3 to return

Keys array of length _NumKeys
Contents array of length _NumKeys
Children array of length _NumKeys + 1

Each child will be another of the same array
Leaf nodes will have an empty children array

I will also be creating a unit test for this afterward.

Update to the structure and approach of this issue.
Status Update System B.01.01.WP07
What
Output status updates to GUI for maintaining visuals with each action taken within the tree for each overarching action.
Requirements
Threaded
It should be on an independent IO Stream like object to support parallel GUI and tree updates simultaneously. The buffer needs to hold an entire stream of updates from the beginning to the end of the action to enable slower reading of updates for user-friendly adjustable speeds of updates.
Node Identification
The nodes each need unique IDs when created. To promote faster and more accurate updates on the GUI processing. The GUI side can likely use a dictionary structure for node updates. Using unique IDs as keys. These IDs will be tracked in each node object.
The actions reported will include:
These will be string statuses to specify what type of update message should be displayed and if a node has been updated.
Insert
Initial status upon Insert action sent by tree object.
Searching
Indicating it is searching the node with ID. It will be sent when InsertKey is called on a node. Thus, with all previous node status updates, it will show the path the search takes through the tree.
Inserted
Indicates whether the Key was not found and inserted or found and not inserted.
Split
Indicates that the node with ID has split and created the node with AltID.
Delete
Initial status upon Delete action sent by tree object.
Searching
Indicating it is searching the node with ID. It will be sent each time Delete is called on a node. Thus, with all previous node status updates, it will show the path the search takes through the tree.
Deleted
Indicates whether the Key was found and deleted or not found.
Merge
Indicates a node with ID ate node with AltID.
Search
Initial status upon Search action sent by tree object.
Searching
Indicating it is searching the node with ID. It will be sent each time Search is called on a node. Thus, with all previous node status updates, it will show the path the search takes through the tree.
Found
Indicates whether the Key was found or not found.

Found how to implement just need to go over it with the team. It is working with all insertions.


Add e2e test for ics27 host params

Summary
Add an e2e test for modifying ics27 host params. Should ensure the host is enabled and packets can be received. Should ensure only allowed messages can be executed and non-allowed messages cannot be executed. Once the host is disabled, packets should not be capable of being received.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

Use gov v1 message when #3520 is merged.

I would like to take this one on.
It seems like some of the test is already present, but it is missing testing that the disabled host is actually effective (packets do not flow), so the plan I have is to extend the existing TestHostEnabledParam test:

Ensure the host is enabled (this already exists in the test)
Ensure it works to create interchain account before disabling (this is tested elsewhere obviously, but this would be for the logical flow of proof that disabling the host works is the reason for the change in effect. I also see this this approach done other places in the e2e tests, but happy to skip this step if you think it is unnecessary)
Disable the host (this already exist in the test)
Ensure the host is disabled (this already exists in the test)
Ensure that it does not work to create a new interchain account

That would be fantastic; Thank you, @gjermundgaraba!
The steps you propose sound fine to me. I think I would suggest in step 5 to try to send a message to the host instead of trying to create a new interchain account. That should also exercise in OnRecvPacket the check we are interested in. Afterwards you can verify that the message did not execute (e.g. funds were not transferred). And if you want to go the extra mile, you could check that the error in the acknowledgement is what it should be supposed to be (for this you can take as inspiration this code by courtesy of @srdtrk in the PR to add queries to ICA, where the acknowledgement is retrieved from the events).
If you try to register a new interchain account, the test could fail here, unless you register the interchain account with a different owner address. Alternatively you could also just skip step 2 and then try to register the interchain account after disabling host functionality.
I think both test flows would work, so I leave it up to you to decide which one you prefer. :) If you have any questions, let us know!

I've got a solution going in a branch, but I am hesitant to pollute the PR list until the PR you mentioned has been merged because I had to copy some of the utility code to do fetch the event and attribute (QueryTxsByEvents).
I can just wait until that has been merged if that is coming in soon. If not, I could also open the PR as is, and if that would get merged first I can open a PR to fix the conflict that would appear in the aforementioned PR.
https://github.com/gjermundgaraba/ibc-go/commit/38aa8a5c7140579a0406ae31c5d492356e9efe01

I've got a solution going in a branch, but I am hesitant to pollute the PR list until the PR you mentioned has been merged because I had to copy some of the utility code to do fetch the event and attribute (QueryTxsByEvents).
I can just wait until that has been merged if that is coming in soon. If not, I could also open the PR as is, and if that would get merged first I can open a PR to fix the conflict that would appear in the aforementioned PR.
gjermundgaraba@38aa8a5

Awesome! We should be merging #5785 this week, so I will comment here once that's done and you can open the PR. Thanks for the quick implementation!

Hope you've gotten the e2e running locally to at least check things out! This is tricky first time around but the README.md in the e2e folder should have most of what you need.

Yes, the README was pretty easy to understand! I've managed to get them running both from the Makefile and directly in the IDE for debugging.


Add: +skim as pdf viewer

This PR added settings to use Skim.app as a PDF viewer for LaTeX export.

Excellent, thanks!


[config] Eliminate config builder and use only dynamic config builder

This will contain a series of commits:

Move from config-builder to dynamic-config-builder in LibraSwarm (and all our tests)
Eliminate config-builder from the code and rename dynamic-config-builder to config-builder
Merge generator with config-builder as it is only used there now

Making this a draft to perform tests

This is the last commit that involves any serious refactoring.... everything from here on should be able to cleanly build on top of this.

@bors-libra r+

:pushpin: Commit 8a25ec4 has been approved by davidiw

:hourglass: Testing commit 8a25ec48d9a2be2a64ec64fa9c56b17e8fa19c6e with merge fdeed4bec8c4cc789131c989fedf8585dea8fd9b...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra r=mimoo

:pushpin: Commit 6b5b47c has been approved by mimoo

:hourglass: Testing commit 6b5b47c85f0d00c8805b309458bbd9a25feb39cd with merge 827bce52cef541e82faf08f2d4615bc7a50ace76...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: mimoo
Pushing 827bce52cef541e82faf08f2d4615bc7a50ace76 to master...


Italy country code is wrong

Italy country code in version 3.2.0 is wrong. The correct value is +39 not +41

Yes i also saw this

Yes. I had to downgrade it to 3.1.0

Absurd bug, please fix it!
A temporary fix is to change by hand the number here:

Stop and run app again. It works, but I fear it can be overwritten at each pub get

Same here.

It is fixed, not yet released though https://github.com/vanshg395/intl_phone_field/pull/293

they need to fix this

Same problem

The issue is still not resolved.


[BEAM-10135][BEAM-10136] Refactor jdbc external transform registrar

During writing kinesis for cross-language it was suggested to emplace all classes connected to cross-language in one file. I do the same here for jdbc.
R: @chamikaramj

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Run Python 3.8 PostCommit

"During writing kinesis for cross-language it was suggested to emplace all classes connected to cross-language in one file"
I think Java generally recommends keeping classes in separate files, doesn't it ? I think either way should be fine as long as x-lang framework is concerned.

"During writing kinesis for cross-language it was suggested to emplace all classes connected to cross-language in one file"
I think Java generally recommends keeping classes in separate files, doesn't it ? I think either way should be fine as long as x-lang framework is concerned.

@chamikaramj In general yes, but most of beam connectors have huge files with nested classes instead of splitting them to separate packages and small files. In the case of external transforms it's a bit more elegant because ExternalTransformRegistrar has to override function knownTransforms() which assumes there can be more than one transform under it. The builders actually should also be in separate files from the registrar.
But I agree that it's not that necessary to put everything into one file, so if you prefer it to be like it is now then I'll close this PR.

We can merge this.
BTW I'm curious, have you tested the jdbc.py against Dataflow ? If not can you try that ?
Instructions for running x-lang wrappers against Dataflow are here - https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples/kafkataxi

BTW I'm curious, have you tested the jdbc.py against Dataflow ? If not can you try that ?
Instructions for running x-lang wrappers against Dataflow are here - https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples/kafkataxi

I tried to run this test using the setup from kafkataxi but I wasn't successful. Now when I think about that it could not be possible to use testcontainers with dataflow. I'll try it on bigquery or a tunneled postgres this week.

I'm not sure whether the e-mail notifications are sent without mentioning so just to be on the safe side that you get one: @chamikaramj

Was there an error ? Could you file a JIRA ?

@chamikaramj  I'll try to run it again this week just to be sure. If I'm not successful then of course I'll create an issue.


Logging

Put very rough logging in

@dcmckayibm what are you thinking here.

It will be for the next release

Eli Arbel will do this. Will add him as assigned once I get his github name and get him added to Qiskit

@gadial will help in guiding him

To clarify what I meant by this issue is some centralized way to keep track of the fit parameters which can then be data mined at a later point in time.
E.g. consider that we run a bunch of T1 experiments, each time save the date/time, qubit, T1 values. At a later date we would want a way to plot all T1's for Qx in some date range. Chris suggested pandas could be used for the plotting.
To start we need some type of centralized file and a config file that points to the location of this file.

Hi Dave, thanks for clarifying. What I initially thought was needed here is a more general logging capability, i.e something which gives visibility into the code while it runs as well as outputting info for debug purposes.
What you are suggesting is a different use-case, which looks very useful. I will look into it and think about a framefork to support this type of logging. Most likely we can piggyback on the logging framework which is already there, maybe making the configurability aspect of it a bit more convenient.

I opened a PR to a branch on my fork giving a rough outline of what I envisioned logging would look like. I'm not sure sure it can piggy back on the current logging framework because I'm thinking of something that makes structured output.

https://github.com/Qiskit/qiskit-ignis/pull/149

Hi Dave, please check out the "Ignis Logging" PR. It has the log writer and reader classes implemented. Comments are welcome.


Revert "Python library docs (#1905)"

This reverts commit d1e6ee46a43aa7b9ab0f41c2a9e38e94e2e38964.

this was an old pull, that was rewritten and rebased onto develop, and was not intended to be in master.
changes pending against develop can be seen here: https://github.com/linode/manager/pull/2085

Coverage increased (+0.03%) to 79.117% when pulling a6366825e380abdbc9632f828663d078101ccade on mparke:revert-docs-changes into d1e6ee46a43aa7b9ab0f41c2a9e38e94e2e38964 on linode:master.


Downloading the model and performing inference only

Is there an easy way to download the model generated by Databricks in the blog post, instead of retraining?
In fact, for a number of reasons, it still might not be so easy to retrain (access to Databricks, or to Standard_ND96asr_v4 instance).
Also, what is the recommended instance type for inference only, ie. calling the generate_response function?
Thank you very much for the hard work.

wrote an email to support.
see #3

We’ve released the model here: https://huggingface.co/databricks/dolly-v1-6b


Issue 68 show feedback add comment students

Thanks @damienBAUDET for this PR. I like the way you integrated feedback into the component. I usually rely on alert pop-ups, but your way is much nicer: it makes sense to show the message closest to the action (right next to the comment field, in this case).
Is there a reason why you reverted the commit related to translations? Maybe my commit crossed yours. I'll look into a better strategy to avoid these conflict. Meanwhile, I think it's necessary to rebase your branch on master before pushing anything.
One last thing before merging your PR: I'd like to translate the confirmation message you added, and I took this opportunity to merge all translations strings into the en.json, fr.json, es.json, including those stored in vue-i18n-locales.generated.js until now (it used to store JS translation strings, but it's probably easier to have both JS and Blade translations in the same place).
I included the latest message "Your comment has been saved" in these three files.
Can you try and rebase your branch, and then make the confirmation message translatable, like so:
{{ $t('Your comment has been saved') }}
I think it should work. Please let me know!


GEODE-7919-fix-flaky: shut down threads after tests

CI failures yesterday: MembershipIntegrationTest > secondMembershipCanJoinUsingTheSecondLocatorToStart
It’s failing in both JDK8 and JDK11:
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/IntegrationTestOpenJDK8/builds/4#A
org.apache.geode.distributed.internal.membership.gms.MembershipIntegrationTest > secondMembershipCanJoinUsingTheSecondLocatorToStart FAILED

    java.lang.AssertionError:

    Expected size:<2> but was:<1> in:

    <[<IP_ADDRESS>(1:locator)<ec><v0>:41002]>

        at org.apache.geode.distributed.internal.membership.gms.MembershipIntegrationTest.secondMembershipCanJoinUsingTheSecondLocatorToStart(MembershipIntegrationTest.java:144)

Looks like in a number of tests we expect to see two members in the view but see only one. I ran the test a couple hundred times in IntelliJ and was able to reproduce the failures.
I added a couple methods to the test to shut down locators and memberships because that was a difference I saw introduced with GEODE-7919. But really I think that masks the problem. If you comment out the innards of those two new routines and give this test a couple hundred runs it'll repro the assertion failure.
Next step is to dig in to that actual failure and decide if it is "merely" a race condition w/ locator or member startup. If it's an "ok" race condition we can fix it with…Awaitility!
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[x] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[x] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

Sadly, what started as a test-bed for deterministic tests now looks much like all the others—I just added the first Awaitility calls. 😞


Add initial Mainframe Semantic Conventions

Area(s)
area:new
Is your change request related to a problem? Please describe.
For a consistent representation of mainframe telemetry using OpenTelemetry, Semantic Conventions supporting the platform are essential. The Mainframe SIG has made progress in agreeing first proposals for mapping mainframe concepts into the OpenTelemetry Semantic Conventions, and would like to now bring forward for further refinement with the Semantic Conventions SIG.
Describe the solution you'd like
As an initial input, add new model enhancements for the following mainframe aspects:

z/OS attributes

Registry:

zos.*
zos.smf.id - 4-char Systems Measurement Facility (SMF) ID commonly used for system identification
zos.sysplex.name - The name of the SYSPLEX to which the system belongs too.

Transaction Processing Systems (TPS) resources and spans

For CICS and IMS.
Alignment with non-mainframe transaction processing systems required
Registry:
tps.*

tps.system - Type of Transaction Processing System
tps.region.id - Runtime environment within the Transaction Processing System
tps.transaction.id - ID of the transaction initiated by a user or system request
tps.transaction.owner - ID of the user owning the transaction
tps.task.id - ID of the task created to run the transaction
tps.program.name - Program name executed by the task
tps.unit_of_work.id - Unit of work executed by the program

Mainframe attributes

Registry:

mainframe.*
mainframe.lpar.name - The name of the Logical Partition (LPAR) on which the system runs on.

Over time, we aim to extend the content under mainframe.*, zos.* and tps.* with metrics and events, and additional attributes. In addition, we look at adding definitions extending the name space system.* and adding enhancements for virtualisation.*.
Describe alternatives you've considered
Alternative for tps: Include under name space zos, e.g. such as zos.cics.* or zos.ims.*
Alternatives mainframe: Include concepts under hw and host namespaces, and potentially a new namespace for io to represent the I/O subsystems.
Additional context
No response

We will add a couple of PRs with the input to the Semantic Conventions over the next couple of days to discuss the proposals.


[BEAM-2071] AttributeError in dataflow_metrics

r: @aaltay
Should run ValidatesRunner for dataflow first

Merging this to prevent more test failures, please add a permanent fix soon.


Issue 187#: Long duration test for data service

add long duration test for data service with random read, write and free.
fixed one issue in MultiBlkId iterator
add/update api comments for data service

Testing:
a few hundred iterations run for the mixed io load (num_io=300) test case and passed. --- which included in conan build test.
Long duration run for a few hours and still running.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ddff069) 69.00% compared to head (acce729) 69.19%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage   69.00%   69.19%   +0.19%
==========================================
  Files          93       93
  Lines        7581     7576       -5
  Branches      968      966       -2
==========================================
+ Hits         5231     5242      +11
+ Misses       1899     1881      -18
- Partials      451      453       +2

Files
Coverage Δ

src/include/homestore/blk.h
72.34% <100.00%> (+0.60%)
:arrow_up:

src/include/homestore/blkdata_service.hpp
100.00% <ø> (ø)

src/lib/blkalloc/blk.cpp
71.42% <100.00%> (ø)

... and 12 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add Unknown variant to chunk

This PR implements the Unknown chunk variant discussed in #4

Thank you!  This all looks good, so I'm going to go ahead with merging it and releasing a new version.


init archived message filter criteria

Description
new search filter on archived massages

Codecov Report

Merging #1683 (2ca54e8) into main (7e569d8) will increase coverage by 11.46%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main    #1683       +/-   ##
===========================================
+ Coverage   17.50%   28.97%   +11.46%
===========================================
  Files          70       90       +20
  Lines        1702     2019      +317
  Branches      168        0      -168
===========================================
+ Hits          298      585      +287
- Misses       1394     1419       +25
- Partials       10       15        +5

Impacted Files
Coverage Δ

...urce/DataHub.WebApi/Clients/EDI/ArchivedMessage.cs
0.00% <0.00%> (ø)

...e/DataHub.WebApi/Clients/EDI/ArchivedMessageDto.cs
0.00% <0.00%> (ø)

...ebApi/Clients/EDI/ArchivedMessageSearchCriteria.cs
0.00% <0.00%> (ø)

...taHub.WebApi/Clients/EDI/ArchivedMessagesSearch.cs
0.00% <0.00%> (ø)

...Hub.WebApi/Clients/EDI/MessageSearchCriteriaDto.cs
0.00% <0.00%> (ø)

.../source/DataHub.WebApi/Clients/EDI/SearchResult.cs
0.00% <0.00%> (ø)

...Hub.WebApi/Controllers/MessageArchiveController.cs
0.00% <0.00%> (ø)

... and 21 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


tweaks to ref-based rnaseq tutorial

The HISAT2 wrapper has been updated since this tutorial was made, so I changed the parameter descriptions to match. I also got different results when performing the mapping so I adjusted the answers to affected questions as well.
I added htseq_count and rseqc to tools.yaml file (the latter for the "infer experiment" tool referred to in the library determination step)
ping @malloryfreeberg
P.S. I am teaching this module on Monday, a merge before then would be much appreciated

thanks @mvdbeek, made the changes :)

Looks good for me too!


Development using nodemon src/server.js does not run Webpack client build to allow ES6+ syntax

To start dev mode the app uses nodemon like nodemon src/server.js
If we want to use ES6+ syntax in src/server.js then webpack.base.config.js  uses babel-loader.
However babel-loader does not seem to work in development. If I use ES6 import statements in server.js and run npm run dev then I get errors like:

import express from 'express';
^^^^^^
SyntaxError: Cannot use import statement outside a module

But if I run npm build:client and npm build:server there are no errors. This is because Webpack does not get a chance to build server.js before it runs nodemon src/server.js. I don't know how to solve it.

./server.js file is not transpiled by webpack in this setup, I don't think it's really necessary. Webpack is used here only for transpiling/bundling the client code. Also please see the info regarding using ECMAScript modules in node.js here https://nodejs.org/api/esm.html

Then that means server.js and setup-dev-server.js cannot be written in ES6+ code. I solved it by installing babel-node and then changing the package.json script to "dev": "cross-env NODE_ENV=development nodemon --exec babel-node src/server.js",

You can use ES6+ in node.js without transpiling, as you can see ./server.js is written with async/await and other cool stuff.  Basically you're transpiling node.js files only for ES modules support.


Harmonize znode writing code in RTR and Worker.

Throw most exceptions rather than suppressing them, which should help
detect problems. Continue suppressing exceptions that make sense to
suppress.
Handle payload length checks consistently, and improve error message.
Remove unused WorkerCuratorCoordinator.announceTaskAnnouncement method.
Max znode length should be int, not long.
Add tests.

Tough call between bug vs improvement, will call it a bug since the old behavior could mask errors on createPathIfNeeded during the worker's "start", leading to MMs that are up but actually failed to create their task and announcement paths.

:+1:

Minor request for debug logging instead of complete suppression, otherwise :+1:  at author's discretion.

@drcrallen @xvrl adjusted

:+1:


ApnSender.Send throws an Exception when Bad DeviceId is provided.

If you provide a bad DeviceId, the Apple API responds with {"reason":"BadDeviceToken"}
This currently fails to deserialize to a ApnsError type and throws a deserialization exception.

"The JSON value could not be converted to CorePush.Apple.ReasonEnum. Path: $.reason | LineNumber: 0 | BytePositionInLine: 26."

https://github.com/andrei-m-code/net-core-push-notifications/blob/master/CorePush/Apple/ApnSender.cs#L103

Additionally, when succeed  is true, there is no response content but the code tries to deserialize an empty string and throws this exception.

The input does not contain any JSON tokens. Expected the input to start with a valid JSON token, when isFinalBlock is true. Path: $ | LineNumber: 0 | BytePositionInLine: 0.

thanks @vyrotek I'll look into it

Fixied in v4.1.0

Thank you!


Multi page does not work on iOS with jsPDF

I'm using htm2canvas with jsPDF. It works fine on all platforms if I am outputting a single page.
If I make a two page document (using either html2canvas's pagesplit option, or jsPDF's addPage), it fails silently on iOS only. The PDF does not open after it is saved by jsPDF. Other platforms work properly.
Is there a workaround, or is a fix needed?

@nsbasic do you have a jsfiddle example of how you've integrated html2canvas and jsPDF?  I'm trying to do the same, but running into huge hurdles with html2canvas and how it renders (or doesn't) the images I have on my page.  Just curious how you're doing it.

I'm not doing any images - just styled DIVs with text in them.

Html2canvas is ok in ios 7 system? I can run it in ios 7 system


'disabled' attribute on input element is not functioning on v4.4.0 and above

Environment
System:

OS: macOS 10.15.1
CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Memory: 6.28 GB / 32.00 GB
Shell: 5.7.1 - /bin/zsh

Binaries:

Node: 12.6.0 - /usr/local/bin/node
Yarn: 1.16.0 - /usr/local/bin/yarn
npm: 6.9.0 - /usr/local/bin/npm

npmPackages:

babel-plugin-styled-components: ^1.5.1 => 1.10.6
styled-components: ^4.4.0 => 4.4.0

Reproduction
<Input       name='mobile'       onChange={(e) => this.handleChange(e)}       value={this.state.mobile}       disabled={true}       readOnly={'readonly'}       type='tel'       maxLength={11} />
Steps to reproduce
just use it
Expected Behavior
this  element should be disabled
Actual Behavior
this  element has no disabled attribute on it .

Looks fine to me, probably something with your custom Input component I see there. https://codesandbox.io/s/styled-components-base-1rs7o


Cope with unsigned SSM Agent RPM

🗣 Description
This pull request:

Addresses an issue where dnf refuses to install the unsigned SSM Agent RPM
Removes Fedora 33 from the molecule testing

💭 Motivation and Context
dnf now refuses to install the unsigned SSM Agent RPM, and Fedora 33 seems to be hosed right now...it can't even perform a dnf update because of GPG key issues.  Both these issues must be overcome in order to get this PR approved and merged so that we can build a new FreeIPA AMI for the COOL.
🧪 Testing
All pre-commit hooks and molecule tests pass.  I am in the process of building a new FreeIPA image using this branch and will update this paragraph after testing.
🚥 Types of Changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (causes existing functionality to change)

✅ Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Whatever it takes to move forward, right? I think an issue should be created to at least keep the fedora33 issues on the radar.

I created #9.


registerFileUrl with existing data?

I stumbled upon one thing yesterday. I am currently adapting monaco-editor-wrapper to the latest releases (WIP).
Instead of registerExtensionFile which required a string input, we now have this: registerFileUrl. In case of existing data (=string input; no file url), I build a data url on the fly. Do you see a problem with this approach or should we add an alternative here directly. WDYT?

I think the data url is fine. It's the only things that is guarantee to work everywhere (css files, fetch, fonts...)
blob urls can probably be used instead (but be careful, sometime vscode applies transformation on urls and blob url are not exactly regular urls)
do you see any downside of using data url?

I guess we can provide a way to provide a file content instead of its url and create the data-url ourselfves, but I don't really want to encourage that usage either.

I will support this in the wrapper, because I support both ways before, but let's leave it out here.


Allow to compile Q# projects that don't contain any Q# source files

Right now, the Q# command line compiler expects to get a list of Q# source files and will fail otherwise. It may make sense however, to allow to compile projects that do not have any source files, but merely contains references that are processed by a compiler extension. We hence probably should be more permissive and just give a warning if no source files are passed as arguments.

After some consideration, we may not want to support this. I'd be happy to reconsider if there is a strong enough reason to support this, but will close this for now.


Proof of concept load performance improvement

🚀 Pull Request
Attempts to address performance slowdowns highlighted here #6075

Initial benchmark results are interesting. not all straightforward. I'm going to run that again ...

WHOOPS sorry, I did that to the wrong PR