Error 400: Invalid value for field 'resource.rateLimitOptions'

What happened?
Customer updated Cloud Armor rules but bumped into this error:
Error 400: Invalid value for field 'resource.rateLimitOptions': ''. Rate limit options must be specified if the action is 'fairshare', 'rate_based_ban' or 'throttle'. It cannot be specified for any other actions, invalid

Example
Example of a rule being updated:
{
    action: "deny(403)",
    description: `Block requests if their reCAPTCHA Enterprise score is <= ${minimumScore} for ${path}`,
    priority: getPriority(),
    match: {
      expr: {
        expression: `request.path == '${path}' && token.recaptcha_action.score <= ${minimumScore}`,
      },
    },
}

Output of pulumi about
Customer tried with latest @pulumi/gcp v7.2.2.
Additional context
This maps to this upstream TF issue:
https://github.com/hashicorp/terraform-provider-google/issues/12739
The upstream issue was closed due to inactivity, not because a fix was made.
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Hi Ringo, thanks for raising the issue. I just tested the following program and it ran successfully:
"""A Google Cloud Python Pulumi program"""

import pulumi
import pulumi_gcp as gcp

path = "my-path"
minimumScore = 0.5

policy = gcp.compute.SecurityPolicy(
    "policy",
    rules=[
        gcp.compute.SecurityPolicyRuleArgs(
            action="deny(403)",
            description=f"Block requests if their reCAPTCHA Enterprise score is <= {minimumScore} for {path}",
            match=gcp.compute.SecurityPolicyRuleMatchArgs(
                expr=gcp.compute.SecurityPolicyRuleMatchExprArgs(
                    expression=f"request.path == '{path}' && token.recaptcha_action.score <= {minimumScore}"
                )
            ),
            priority=1000,
        ),
        gcp.compute.SecurityPolicyRuleArgs(
            action="allow",
            description="default rule",
            match=gcp.compute.SecurityPolicyRuleMatchArgs(
                config=gcp.compute.SecurityPolicyRuleMatchConfigArgs(
                    src_ip_ranges=["*"],
                ),
                versioned_expr="SRC_IPS_V1",
            ),
            priority=2147483647,
        ),
    ],
)

I am using pulumi-gcp version 7.2.2.
Can you help me reproduce this issue the customer is having?

I also ran the following example from the upstream issue successfully. Perhaps this was fixed upstream?
"""A Google Cloud Python Pulumi program"""

import pulumi
import pulumi_gcp as gcp

path = "my-path"
minimumScore = 0.5

policy = gcp.compute.SecurityPolicy(
    "policy",
    rules=[
        gcp.compute.SecurityPolicyRuleArgs(
            action="redirect",
            description=f"Redirect to reCAPTCHA on malice",
            preview=True,
            priority=500,
            redirect_options=gcp.compute.SecurityPolicyRuleRedirectOptionsArgs(
                type="GOOGLE_RECAPTCHA"
            ),
            match=gcp.compute.SecurityPolicyRuleMatchArgs(
                expr=gcp.compute.SecurityPolicyRuleMatchExprArgs(
                    expression="evaluatePreconfiguredExpr('scannerdetection-v33-canary',['owasp-crs-v030301-id913102-scannerdetection','owasp-crs-v030301-id913101-scannerdetection']) || evaluatePreconfiguredExpr('rfi-v33-canary', ['owasp-crs-v030301-id931130-rfi']) || evaluatePreconfiguredExpr('sqli-v33-stable', ['owasp-crs-v030301-id942251-sqli','owasp-crs-v030301-id942420-sqli','owasp-crs-v030301-id942431-sqli','owasp-crs-v030301-id942200-sqli','owasp-crs-v030301-id942460-sqli','owasp-crs-v030301-id942101-sqli','owasp-crs-v030301-id942421-sqli','owasp-crs-v030301-id942260-sqli','owasp-crs-v030301-id942330-sqli','owasp-crs-v030301-id942190-sqli','owasp-crs-v030301-id942180-sqli','owasp-crs-v030301-id942340-sqli','owasp-crs-v030301-id942432-sqli']) || evaluatePreconfiguredExpr('rce-v33-canary') || evaluatePreconfiguredExpr('cve-canary')"
                ),
            ),
        ),
        gcp.compute.SecurityPolicyRuleArgs(
            action="deny(403)",
            description=f"Block requests if their reCAPTCHA Enterprise score is <= {minimumScore} for {path}",
            match=gcp.compute.SecurityPolicyRuleMatchArgs(
                expr=gcp.compute.SecurityPolicyRuleMatchExprArgs(
                    expression=f"request.path == '{path}' && token.recaptcha_action.score <= {minimumScore}"
                )
            ),
            priority=1000,
        ),
        gcp.compute.SecurityPolicyRuleArgs(
            action="allow",
            description="default rule",
            match=gcp.compute.SecurityPolicyRuleMatchArgs(
                config=gcp.compute.SecurityPolicyRuleMatchConfigArgs(
                    src_ip_ranges=["*"],
                ),
                versioned_expr="SRC_IPS_V1",
            ),
            priority=2147483647,
        ),
    ],
)

@VenelinMartinov I can't reproduce this too. I'll check with the customer if they bumped into this again in the meantime.

Looks like the TF issue might be unrelated.
There was another bit from the user which helped me repro this:
alright just deleting all the rules manually in the UI and then running pulumi up again fixed it, I think it had to do with changing a rule that already existed to a different type

Here is the program:
import pulumi
import pulumi_gcp as gcp

path = "my-path"
minimumScore = 0.5

throttle_enabled = pulumi.Config().get_bool("throttle_enabled", True)

policy = gcp.compute.SecurityPolicy(
    "policy",
    rules=[
        gcp.compute.SecurityPolicyRuleArgs(
            action="throttle" if throttle_enabled else "deny(403)",
            description=f"Block requests if their reCAPTCHA Enterprise score is <= {minimumScore} for {path}",
            match=gcp.compute.SecurityPolicyRuleMatchArgs(
                expr=gcp.compute.SecurityPolicyRuleMatchExprArgs(
                    expression=f"request.path == '{path}' && token.recaptcha_action.score <= {minimumScore}"
                )
            ),
            rate_limit_options=gcp.compute.SecurityPolicyRuleRateLimitOptionsArgs(
                conform_action="allow",
                exceed_action="deny(403)",
                rate_limit_threshold=gcp.compute.SecurityPolicyRuleRateLimitOptionsRateLimitThresholdArgs(
                    count=10, interval_sec=10
                ),
            )
            if throttle_enabled
            else None,
            priority=1000,
        ),
        gcp.compute.SecurityPolicyRuleArgs(
            action="allow",
            description="default rule",
            match=gcp.compute.SecurityPolicyRuleMatchArgs(
                config=gcp.compute.SecurityPolicyRuleMatchConfigArgs(
                    src_ip_ranges=["*"],
                ),
                versioned_expr="SRC_IPS_V1",
            ),
            priority=2147483647,
        ),
    ],
)

steps:

pulumi up
pulumi config set throttle_enabled false
pulumi up
Observe error

Filed as https://github.com/hashicorp/terraform-provider-google/issues/17275 in upstream GCP TF provider.


About Environment

Dear Authors,
My environment is torch 2.0.1+cu117. Could I use this environment to run your code?
Thanks.

Hi @AmingWu ,
I've never tried this environment before. It seems that the code does not have strict requirements on the exact version of Torch or CUDA, so you can give it a try. Feel free to share your results with me.
Best regards,
Authors


remove the MPL2.0 license pkg

Summary by CodeRabbit

Bug Fixes

Simplified error handling in the message cloning process, improving clarity and performance when encountering issues.

Chores

Removed unnecessary dependencies, leading to a cleaner and more efficient project structure.

@jkralik maybe we should add the licence scanner (fossa) that we have in other repositories here, hopefully it can be setup in such way to mark MPL as problematic. Because I'll forget about it in a week and we use the multierror package in other repositories, so I can easily see myself re-adding it in the future. 🤓


Add example queries and short welcome tour

Add a short welcome tour to the console that brings the user to a few
example queries.

@mwylde I feel like it could use a final modal at the end, kinda of saying congratulations, and maybe linking to more resources. What do you think?

That's a great idea — could definitely link to the sql docs and the tutorials.


Dataset Evaluation

Hi,
You describe a dataset in the paper called Pics used for evaluation.
Can you please share this dataset?
Thanks in advance.

@orhir Hi, this dataset is from Picsart and probably will not be publicly available.
The dataset is just used for evaluation and our method requires no training data. Hence, you can evaluate on your own dataset if you want.


gradle 8.3, bin, supporting java-21 via its kotlin dependency

permits to remove hardcoded kotlin version again, like mentioned in #5130.

tested with java-21, still good.

@BenjaminAmos am i allowed to ping you here as well?

To clarify the title here, this will probably only support Java 20. Running on Java 21 will likely need Gradle 8.4 (which is not yet released). It's still an improvement.

should we adjust the title in that case @BenjaminAmos ?

am running java-21.


Bug: Git(lab) groups

The current setup doesn't allow the use of gitlab groups. Gitlab groups result in the following ssh string:

ssh://<user_name>@<my_instance>.gitlab.host:<group_name>/<project_name>/<repo_name>/app name>.git

In configure_app.yml the repo string is created using the different vars supplied. When adding the colon to the git_server var the git module takes it as part of the DNS name this failing to resolve it. The Ansible Git module does support the use of the colon and I have verified this works by putting the full string in there manually. I do not yet understand why it doesn't work when merging strings.
 repo: "{{ item.git_server | default(git_server) }}/{{ item.git_project | default(git_project) }}/{{ item.app_name }}.git"

failed: [localhost] (item={'app_name': '<my_app>'}) => {"ansible_loop_var": "item", "changed": false, "cmd": "/usr/bin/git clone --origin origin 'ssh:********@<my_instance>.gitlab.host:<group_name>/<project_name>/<my_app>.git' /tmp/gitt", "item": {"app_name": "<my_app>"}, "msg": "Cloning into '/tmp/git'...
ssh: Could not resolve hostname <my_instance>.gitlab.host:<group_name>: Name or service not known
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.", "rc": 128, "stderr": "Cloning into '/tmp/gitt'...
ssh: Could not resolve hostname <my_instance>.gitlab.host:<group_name>: Name or service not known
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
", "stderr_lines": ["Cloning into '/tmp/git'...", "ssh: Could not resolve hostname <my_instance>.gitlab.host:<group_name>: Name or service not known", "fatal: Could not read from remote repository.", "", "Please make sure you have the correct access rights", "and the repository exists."], "stdout": "", "stdout_lines": []}

Figured it out. I had to remove the ssh:// at the start of the git_server var. Now it clones just fine.


Use I18n for static texts

Use I18n for static texts
Add spanish and english locale files

As I needed to use a simple discussion in Spanish, I decided to add Internationalization on a forked version of the gem, I hope this helps to improve it.
I wonder if I should figure out how to create a generator so that users can copy the locale files to edit them in their projects. Let me know if that's the case and I'll work on it.

This is great! Thanks @yonnyquiceno 🤘
I think it's fine if we don't have a generator. It'll be easy enough for someone to copy the existing locale files and modify it for their language.


Log levels also in 'request' type log entries

It would be nice if the request log would also contain a default "level", e.g. level: DEBUG or level: INFO or whatever. Is there a way to do so?

actually u can access the request log directly and do whatever you want with it.
    app = Flask(__name__)
    json_logging.ENABLE_JSON_LOGGING = True
    json_logging.init_flask()
    json_logging.init_request_instrument(app)

    logger = logging.getLogger("test-logger")
    logger.setLevel(logging.DEBUG)
    logger.addHandler(logging.StreamHandler(sys.stdout))
    logger.addHandler(logging.handlers.RotatingFileHandler(
        filename="./output.log",
        maxBytes=5000000,
        backupCount=10
    ))
    request_logger = json_logging.get_request_logger()
    request_logger.addHandler(logging.handlers.RotatingFileHandler(
        filename="./output.log",
        maxBytes=5000000,
        backupCount=10
    ))


Translate complete

Five lines are all translated.

Codecov Report

Merging #97 (ecbbdc8) into main (6a761ca) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #97   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           19        19
  Lines         2745      2831   +86
  Branches       580       592   +12
=========================================
+ Hits          2745      2831   +86

Flag
Coverage Δ

unittests
100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/classes/importer.ts
100.00% <ø> (ø)

src/constants.ts
100.00% <ø> (ø)

src/classes/game-settings.ts
100.00% <100.00%> (ø)

src/classes/macros.ts
100.00% <100.00%> (ø)

src/classes/month.ts
100.00% <100.00%> (ø)

src/classes/moon.ts
100.00% <100.00%> (ø)

src/classes/season.ts
100.00% <100.00%> (ø)

src/classes/simple-calendar-configuration.ts
100.00% <100.00%> (ø)

src/classes/simple-calendar.ts
100.00% <100.00%> (ø)

src/classes/year.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a761ca...ecbbdc8. Read the comment docs.

Awesome, thanks so much again!


Improve SpringData custom repository implementation support.

Lookup and register custom implementations of SpringData repository fragments.
interface OrderRepository extends CrudRepository<Order, String>, OrderRepositoryCustom {
  // ..
}

@Component
class OrderRepositoryImpl implements OrderRepositoryCustom {
  // ..
}

Investigate how far it is possible to move away from the default Impl postfix towards reading the repositoryImplementationPostfix value if set.
Check if it is required to have the @Component annotation on the actual custom implementation or if there's a way around it.

Rollbacked due to error on Java 11 builds (on 20.1 and master).


Group form fix

group form fields will be cleared after successful group edit/creation
students added as group members will disappear from the list of available students

Coverage remained the same at 46.926% when pulling 87c9d5b9cc0e0e68e0d3a04bc2ebad9b681fedce on group_form_fix into 8984ab3097679f09d9647ab4517fa4807da76d13 on master.


EXPLAIN HOW FRESNEL OVERLAY IS UGLY

??? BEST VISUALS DUDE

looks bad on DME, will probably look bad on players


Evaluating Trained Models

I was wondering how the trained models are intended to be evaluated. I don't believe that the paper states how many samples were used to compute the metrics. The code appears to give some indication but the testing functionality seems broken.
Assuming we train a model via:
python main.py +experiment=planar dataset=planar ++hydra.run.dir=<HEAD>/planar_debug

I would expect that we evaluate it on the test set via:
python main.py +experiment=planar dataset=planar general.test_only=<HEAD>/planar_debug/checkpoints/planar/last.ckpt

Unfortunately, this functionality is broken and gives this stack trace:
Traceback (most recent call last):
  File "/fs/gpfs41/lv11/fileset01/pool/pool-krimmel/DiGress/src/main.py", line 244, in <module>
    main()
  File "/fs/pool/pool-krimmel/miniconda3/envs/digress/lib/python3.9/site-packages/hydra/main.py", line 94, in decorated_main
    _run_hydra(
  File "/fs/pool/pool-krimmel/miniconda3/envs/digress/lib/python3.9/site-packages/hydra/_internal/utils.py", line 394, in _run_hydra
    _run_app(
  File "/fs/pool/pool-krimmel/miniconda3/envs/digress/lib/python3.9/site-packages/hydra/_internal/utils.py", line 457, in _run_app
    run_and_report(
  File "/fs/pool/pool-krimmel/miniconda3/envs/digress/lib/python3.9/site-packages/hydra/_internal/utils.py", line 223, in run_and_report
    raise ex
  File "/fs/pool/pool-krimmel/miniconda3/envs/digress/lib/python3.9/site-packages/hydra/_internal/utils.py", line 220, in run_and_report
    return func()
  File "/fs/pool/pool-krimmel/miniconda3/envs/digress/lib/python3.9/site-packages/hydra/_internal/utils.py", line 458, in <lambda>
    lambda: hydra.run(
  File "/fs/pool/pool-krimmel/miniconda3/envs/digress/lib/python3.9/site-packages/hydra/_internal/hydra.py", line 132, in run
    _ = ret.return_value
  File "/fs/pool/pool-krimmel/miniconda3/envs/digress/lib/python3.9/site-packages/hydra/core/utils.py", line 260, in return_value
    raise self._return_value
  File "/fs/pool/pool-krimmel/miniconda3/envs/digress/lib/python3.9/site-packages/hydra/core/utils.py", line 186, in run_job
    ret.return_value = task_function(task_cfg)
  File "/fs/gpfs41/lv11/fileset01/pool/pool-krimmel/DiGress/src/main.py", line 176, in main
    cfg, _ = get_resume(cfg, model_kwargs)
  File "/fs/gpfs41/lv11/fileset01/pool/pool-krimmel/DiGress/src/main.py", line 31, in get_resume
    model = DiscreteDenoisingDiffusion.load_from_checkpoint(resume, **model_kwargs)
  File "/fs/pool/pool-krimmel/miniconda3/envs/digress/lib/python3.9/site-packages/pytorch_lightning/core/module.py", line 1520, in load_from_checkpoint
    loaded = _load_from_checkpoint(
  File "/fs/pool/pool-krimmel/miniconda3/envs/digress/lib/python3.9/site-packages/pytorch_lightning/core/saving.py", line 62, in _load_from_checkpoint
    checkpoint = pl_load(checkpoint_path, map_location=map_location)
  File "/fs/pool/pool-krimmel/miniconda3/envs/digress/lib/python3.9/site-packages/lightning_fabric/utilities/cloud_io.py", line 51, in _load
    return torch.load(f, map_location=map_location)  # type: ignore[arg-type]
  File "/fs/pool/pool-krimmel/miniconda3/envs/digress/lib/python3.9/site-packages/torch/serialization.py", line 809, in load
    return _load(opened_zipfile, map_location, pickle_module, **pickle_load_args)
  File "/fs/pool/pool-krimmel/miniconda3/envs/digress/lib/python3.9/site-packages/torch/serialization.py", line 1172, in _load
    result = unpickler.load()
  File "/fs/pool/pool-krimmel/miniconda3/envs/digress/lib/python3.9/pickle.py", line 1212, in load
    dispatch[key[0]](self)
  File "/fs/pool/pool-krimmel/miniconda3/envs/digress/lib/python3.9/pickle.py", line 1717, in load_build
    setstate(state)
  File "/fs/pool/pool-krimmel/miniconda3/envs/digress/lib/python3.9/site-packages/torch/nn/parallel/distributed.py", line 881, in __setstate__
    self.process_group = _get_default_group()
  File "/fs/pool/pool-krimmel/miniconda3/envs/digress/lib/python3.9/site-packages/torch/distributed/distributed_c10d.py", line 707, in _get_default_group
    raise RuntimeError(
RuntimeError: Default process group has not been initialized, please make sure to call init_process_group.

I am using torch==2.0.1+cu118 and pytorch-lightning==2.0.4, as specified in the requirements.
So how are we actually supposed to evaluate the model? I think some instructions in the README would be valuable. Thanks for your help!

I found that it is possible to avoid the exception by commenting out the lines here:
https://github.com/cvignac/DiGress/blob/7a36a84103a6e4b732953459515a479f12e8ff3b/src/main.py#L153
However, it is still unclear to me how many samples we should use to faithfully reproduce the results from the paper. The config experiments/planar.yaml says 40, while general_default.yaml says 10k. The former would lead to large variances in the evaluation results, while the latter would take quite long to evaluate (roughly 10 hours on an H100, I believe).

I get the same problem, it seems that if you train the model using the distributed way(via ddp), you can not load the checkpoint by directly using from_checkpoint and everything must go through the Trainer.
line 155 only retrieve the configuration, if you have the exact hydra setup with when you training the model it should be fine.
another comment on this issue: I am wondering is there a stable branch when there is no distributed traininng???I would be more convenient since I want to tweak the samping method and evaluating matrics. Thanks in advance.


Menu designer doesn't open on new item

When a new item is created, the authorisations don't find the parent ID.

Fixed, along with screen designer. Added parameterIDs and parameterName to allow for setting of parameters when the detail screen changes.


Causing cascading worldgen lag Problem

Version: 1.12.2
Mod version: Thaumcraft-1.12.2-6.1.BETA13
Problem: it can cause the lag when you playing
it seem the this problem has the solution below:
https://www.reddit.com/r/feedthebeast/comments/5x0twz/investigating_extreme_worldgen_lag/?ref=share&ref_source=embed&utm_content=body&utm_medium=post_embed&utm_name=ed7b244b28db485aa0e244a3d3a6b4eb&utm_source=embedly&utm_term=5x0twz

So we can expect the cascading worldgen lag still won't be fixed? I am using Thaumcraft-1.12.2-6.1.BETA26.jar, and still experience this lag.

I am as well, I thought it was Recurrent Complex, and Doom Dungeons but it ended up actually being Thaumcraft, newest version. Have you tried rolling back to an older release? I think I'm going try that because the server is on a very nicely spec'd Dell R710 and never encountered this until now.


Cargo error

cargo install metaboss
Updating crates.io index
Downloaded metaboss v0.42.0
Downloaded 1 crate (1.6 MB) in 5.68s
Installing metaboss v0.42.0
Updating crates.io index
error: failed to compile metaboss v0.42.0, intermediate artifacts can be found at /tmp/cargo-installyfT9LC.
To reuse those artifacts with a future compilation, set the environment variable CARGO_TARGET_DIR to that path.
Caused by:
failed to select a version for the requirement spl-pod = "^0.1.1"
candidate versions found which didn't match: 0.3.0, 0.2.2, 0.1.0
location searched: crates.io index
required by package metaboss v0.42.0
perhaps a crate was updated and forgotten to be re-vendored?
Version:
rustc --version
rustc 1.79.0 (129f3b996 2024-06-10)
cargo --version
cargo 1.79.0 (ffa9cf99a 2024-06-03)

cargo install metaboss Updating crates.io index Downloaded metaboss v0.42.0 Downloaded 1 crate (1.6 MB) in 5.68s Installing metaboss v0.42.0 Updating crates.io index error: failed to compile metaboss v0.42.0, intermediate artifacts can be found at /tmp/cargo-installyfT9LC. To reuse those artifacts with a future compilation, set the environment variable CARGO_TARGET_DIR to that path.
Caused by: failed to select a version for the requirement spl-pod = "^0.1.1" candidate versions found which didn't match: 0.3.0, 0.2.2, 0.1.0 location searched: crates.io index required by package metaboss v0.42.0 perhaps a crate was updated and forgotten to be re-vendored? Version: rustc --version rustc 1.79.0 (129f3b996 2024-06-10) cargo --version cargo 1.79.0 (ffa9cf99a 2024-06-03)

Run install with --locked: cargo install metaboss --locked

Actually fixed it already by changing git cloning, editing toml file to spl-pod = 0.1.0 and cargo install .. Kept issue open in case you might want to edit toml file and push updates to fix this issue


Fix isFile method to be able to check remote files too.

This pull request change use of PHP is_file function that can't work with remote files to file_get_contents reading only first byte, so now we can check also if file exist on remote paths

The Filesystem class is intended to work with local files only, not remote ones.

Yep, big 👎 from me here. If you need to interact with remote stuff, use flysystem.

Closing this as it also breaks the test suite.


Display online players in a pinned message that updates

Show number of players online and names of them. Update the pinned message with https://core.telegram.org/bots/api#editmessagetext and https://core.telegram.org/bots/api#pinchatmessage

Allow to disable this function in cunfig.yml

Will use chat description for now instead


Matplotlib package badge

:clipboard: Description

Which service is this badge for e.g: MatPlotLib python package
What sort of information should this badge show?
The name of the package as well as its logo in a static format

:link: Data
Where can we get the data from?

All required data are available from the official website in Matplotlib

:microphone: Motivation
Most python packages have their own badges such as pandas, numpy, plotly and Keras however this important package does not have a badge.
it will be very useful to add it as most of the developers use this package and hence there is a need to be implemented.

What sort of information should this badge show?
The name of the package as well as its logo in a static format

Thanks for reaching out but going to close this. Shields provides the ability for users to create freeform static badges via our static badge builder, but we very much by design do not provide pre-canned static badges. Folks are free to use our static badge builder to serve whatever use case they see fit, as would be the case here


forever.js:692, in the 0.15.1, never change

when i use restart 0, all process restart........
it should be ===, not ==
but in the release tar, it is ==

but in master branch , it is ===

so i am confuse

This was fixed and released in 0.15.2


after pulled llama by Ollama run  it error

Describe the issue
Issue:
Command:
llava:latest          	e4c3eb471fd8	4.5 GB	2 minutes ago

Log:
PASTE THE LOGS HERE.

ollama version 0.1.3
after running lava , it thrown error as following

Screenshots:
You may attach screenshots if it better explains the issue.

even though llava:13b  same error


removed bg of navbar & favicon logo

Removed white background from navbar and favicon focusly logos.

thanks for accepting the pr! @Utkarshn10 will try to contribute more in the future!


Adjust DKG result submission timeout

We need to adjust the resultSubmissionTimeout parameter in the WalletRegistry contract. See discussion

The referenced discussion gets resolved so I am going to copy here what we have agreed on to reference it easier:
These are the numbers of DKG retries we need to execute for non-attributable protocol:

1 malicious member: 100 retries worst case, 50 retries average case. (P = (99 choose 99) / (100 choose 99) = 0.01)
2 malicious member: 4950 retries worst case, 2475 retries average case.
3 malicious member: 161700 retries worst case, 80850 retries average case.

This is quite a lot and I think we should agree that if there is even one malicious member in the group, it is better not to create this group at all because it will require multiple retries during the signing:

1 malicious member, 99 honest members, P = (99 choose 51) / (100 choose 51) = 0.49
2 malicious members, 98 honest members, P = (98 choose 51) / (100 choose 51) = 0.23757575757
3 malicious members, 97 honest members,  P = (97 choose 51) / (100 choose 51) = 0.11393939393

So let's assume we do not allow for any malicious behavior during DKG but we take into account inactivities after the announcement phase. If we allow for 5 retries of the protocol we need 5 x (1 + 5 + 150 + 5) + 15x100 = 2305 blocks, which is about 7.5h assuming 15 blocks delay for a result publication.
We should also add the time needed to confirm the event informing about DKG started.


Chapter layer prevent button to be enable

Go to http://mediaelementjs.com/examples/?name=chapters
Click on play.
Don' move the mouse outside the player or hover the CC button.
You cannot click on pause button or seek head.
It is because the <div class="mejs-chapters has a height of 100%
Same trouble on mobile after a full screen mode/

@sebmasterid Closing old issues. If you'd like to reopen this, let us know. Thanks!


_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m 21s
the patch passed

+1 :green_heart:
compile
1m 27s
the patch passed

+1 :green_heart:
javac
1m 27s
the patch passed

-1 :x:
shadedjars
0m 10s
patch has 7 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 20s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m  0s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
2m 45s
hbase-rest in the patch passed.

23m 54s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1325

Optional Tests
unit javac javadoc shadedjars compile

uname
Linux 4c6e94f213bd 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master /<PHONE_NUMBER>

Default Java
2020-01-14

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/testReport/

Max. process+thread count
3602 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 35s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 42s
master passed

+1 :green_heart:
compile
1m 15s
master passed

+1 :green_heart:
shadedjars
5m 19s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 37s
the patch passed

+1 :green_heart:
compile
1m 15s
the patch passed

+1 :green_heart:
javac
1m 15s
the patch passed

+1 :green_heart:
shadedjars
5m 11s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 32s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 45s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
3m  4s
hbase-rest in the patch passed.

32m  1s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1325

Optional Tests
unit javac javadoc shadedjars compile

uname
Linux afb6c8c1a78c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master /<PHONE_NUMBER>

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/testReport/

Max. process+thread count
4372 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
prototool
0m  1s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 35s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 42s
master passed

+1 :green_heart:
checkstyle
0m 32s
master passed

+1 :green_heart:
spotbugs
3m 49s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 15s
the patch passed

-0 :warning:
checkstyle
0m 20s
hbase-rest: The patch generated 10 new + 152 unchanged - 3 fixed = 162 total (was 155)

-0 :warning:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
whitespace
0m  0s
The patch 1 line(s) with tabs.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
11m 22s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.

+1 :green_heart:
hbaseprotoc
1m 27s
the patch passed

+1 :green_heart:
spotbugs
4m  8s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 25s
The patch does not generate ASF License warnings.

41m 58s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1325

Optional Tests
dupname asflicense cc hbaseprotoc prototool hadoopcheck xml spotbugs hbaseanti checkstyle

uname
Linux ca91a2ef51c7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master /<PHONE_NUMBER>

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-rest.txt

whitespace
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/artifact/yetus-general-check/output/whitespace-eol.txt

whitespace
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/artifact/yetus-general-check/output/whitespace-tabs.txt

Max. process+thread count
93 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


BIA-972] Adjust FinancialAid.sql

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Something I noticed is that on [edfi].[Student] and [tpdm].[Candidate] the reference to [edfi].[Person] is done with [PersonId] and [SourceSystemDescriptorId]. I don't know if [SourceSystemDescriptorId] should be added to the inner join, in addition to [PersonId].
I think it's worth checking with someone who has more knowledge about this.
 I don't know if [SourceSystemDescriptorId] should be added to the inner join, in addition to [PersonId]. I think it's worth checking with someone who has more knowledge about this.
ALTER TABLE [tpdm].[Candidate]  WITH CHECK ADD  CONSTRAINT [FK_Candidate_Person] FOREIGN KEY([PersonId], [SourceSystemDescriptorId])
REFERENCES [edfi].[Person] ([PersonId], [SourceSystemDescriptorId])
GO

ALTER TABLE [edfi].[Student]  WITH CHECK ADD  CONSTRAINT [FK_Student_Person] FOREIGN KEY([PersonId], [SourceSystemDescriptorId])
REFERENCES [edfi].[Person] ([PersonId], [SourceSystemDescriptorId])
GO

Based on the conversation with Steven Arnold on Slack, we can include it if we want or we can leave it as it is. It doesn't really affect us from the starter kit perspective. So, I'll go ahead and approve it.


b.e30_beta02.BLT1850.ne30_t232.111

Purpose:
Turns on most of the new sea ice physics.

Description:
This is basically everything but the wave-ice interaction with the same coupled configuration as 104. I have done runs to assess each independently and there will be tuning required later.

Case directory:

Locally (if still available):
/glade/campaign/cesm/cesmdata/cseg/runs/cesm2_0/b.e30_beta02.BLT1850.ne30_t232.111

On github:
https://github.com/NCAR/cesm_dev/tree/b.e30_beta02.BLT1850.ne30_t232.111

Sandbox:

Locally (if still available): /glade/work/dbailey/cesm3_0_beta02

On github:

Diagnostics:

Diags (if available):
https://webext.cgd.ucar.edu/BLT1850/$CASE/

Output:

Raw output on derecho (if still available): /glade/derecho/scratch/hannay/archive/$CASE/
CAM Climos: /glade/campaign/cgd/amp/amwg/climo/$CASE

Contacts:
@dabail10

Extra details:

@gustavo-marques Here are the diags:
Let me know if you need any further diagnostics


why the connection is disabled but we can connect the  VPN server?

ss://Y2hhY2hhMjAtaWV0Zi1wb2x5MTMwNToyelhJSWlrQzRCOXE@<IP_ADDRESS>:52105/?outline=1
This is the access key I set,  when I add it to outline client ,it show "connected", but when I open chrome or any browser, I can not see anything and or the http request is blocked.

Make sure you can accsess your server's service.
Your server ip is leak, delete the server.
change ip,try again.

Thank you for reaching out! If this is still an issue for you, please contact us at support.getoutline.org and include the GitHub issue number so that we can better support your needs.
If you haven’t already, check out the Outline Support Site at support.getoutline.org for access to help articles and more.


[MSVC] write_json fails with std::unordered_map<std::uint32_t, std::string>

Hi! Great library, I just hit a little snag (skimmed through docs/tests but couldn't see this mentioned).
Example (v2.5.3, VS v17.9.6)
std::unordered_map<std::uint32_t, std::string> uint32_string;
(void)glz::write_json(uint32_string); // fails to compile
std::unordered_map<std::string, std::uint32_t> string_uint32;
(void)glz::write_json(string_uint32); // works

Error
glaze/json/write.hpp(515): error C2027: use of undefined type 'glz::quoted_t<_Ty1>'
        with
        [
            _Ty1=const unsigned int
        ]
C:\git\b2\build2-glaze\libglaze\include\glaze/json/read.hpp(32): note: see declaration of 'glz::quoted_t<_Ty1>'
        with
        [
            _Ty1=const unsigned int
        ]

This should totally work. It looks like MSVC introduced an error with their latest release. I added your test case here #939, which passes, and there were already similar tests that have been passing.
I can upgrade my version of MSVC to this latest version and test myself. Will get back to you soon.

So, I was able to successfully build and run the code using MSVC v17.9.6 (the latest). What header files are you including to use Glaze? It might be a header include issue. Or, it might be some other setup problem on your side.

Interesting... These are my includes (in this order):
#include <glaze/binary/read.hpp>
#include <glaze/binary/write.hpp>
#include <glaze/core/common.hpp>
#include <glaze/json/read.hpp>
#include <glaze/json/write.hpp>

Yeah, integer keys need quoted.hpp because the keys must be quoted. And quoted acts as a special wrapper, so it exists in its own header.
This will likely be improved/refactored in the future, but for now using numeric keys needs quoted.hpp to be included. I usually recommend using glaze/json.hpp for general JSON usage, but it does include more headers than you need. I'm going to close this issue as I don't intend to make a specific change to address this complexity, but expect that it will be improved in the long term. C++20 modules support when added should also remove the need for partial includes.


critical vulnerability log4j in Docker image

Cybersecurity at NERSC has flagged the Docker image of api-umbrella as exposing "a critical vulnerability related to log4j".
Suggestions
Sorry, I don't have any.  :(
References
Critical Apache Log4j Vulnerability Updates

Hi I would like to work on this issue can you let me know how i can solve this issue.


Rails 5 api app fails on users/sign_out, undefined method respond_to

I generated a new Rails 5.0.1 app with the --api flag (also skipped ActionCable, Spockets and Javascript, if that matters).  With Devise 4.2, the sign out action has this problem:
Started DELETE "/users/sign_out" for ::1 at 2017-01-31 08:15:31 -0800
Processing by SessionsController#destroy as JSON
Parameters: {"session"=>{}}
Completed 500 Internal Server Error in 23ms (ActiveRecord: 0.0ms)
NoMethodError (undefined method 'respond_to' for #SessionsController:0x007f8b7c308d10
Did you mean?  respond_to?
respond_with
responder
responder?
responder=):
devise (4.2.0) app/controllers/devise/sessions_controller.rb:76:in 'respond_to_on_destroy'
devise (4.2.0) app/controllers/devise/sessions_controller.rb:63:in 'verify_signed_out_user'

Devise was meant to be used with normal Rails controllers.
There has been discussion on previous issues about using Devise with Rails API, like https://github.com/plataformatec/devise/issues/4275

I think you should override default destroy method implementation in your own SessionsController


Ability to Cancel Sleeping Mat

Minecraft version & Mod Version:
1.12
Single player or Server:
Server
Describe problem (what you were doing / what happened):
Crash log (if any):
We need a way to cancel Sleeping Mat. On servers that take multiple people to end night Sleeping Mat leaves you stuck in place through the rest of night if no one else sleeps for whatever reason.

I will add in 1.6.1 so that you can sneak to cancel the sleeping.

Update is out https://minecraft.curseforge.com/projects/cyclic/files/2451410


Feature/Build Preprints Discover Page with Ember-OSF widget [EOSF-558]

Ticket
https://openscience.atlassian.net/browse/EOSF-558
❗ For Devops - need to setup system variables for Keen private and public projects, as well as a google analytics project for preprints: process.env.PREPRINTS_GOOGLE_ANALYTICS_ID, process.env.PREPRINTS_PRIVATE_PROJECT_ID, process.env.PREPRINTS_PRIVATE_WRITE_KEY, process.env.PREPRINTS_PUBLIC_PROJECT_ID, process.env.PREPRINTS_PUBLIC_WRITE_KEY
❗ TODO - REMOVE PINNED EMBER-OSF COMMIT ONCE DISCOVER-PAGE COMPONENT MERGED.
❗ Depends on https://github.com/CenterForOpenScience/ember-osf/pull/205
Purpose
Builds the entirety of the preprints discover page with the Ember-OSF discover-page widget.  A lot of code has been moved to Ember-OSF - mostly components and helpers that can be shared with registries.  A lot of code from the discover controller has been added to the discover-page widget in Ember-OSF.  Accommodates themed pages.  Facets specific to preprints have been componentized and are passed into the discover-page widget (search-facet-provider and search-facet-taxonomy). Analytics is now more generic.
Changes
The discover page is now built like this:
{{discover-page
    activeFilters=activeFilters
    clearFiltersButton=clearFiltersButton
    consumingService=consumingService
    detailRoute=detailRoute
    discoverHeader=discoverHeader
    facets=facets
    fetchedProviders=model
    filterMap=filterMap
    filterReplace=filterReplace
    lockedParams=lockedParams
    page=page
    provider=provider
    q=q
    queryParams=queryParams
    searchButton=searchButton
    searchPlaceholder=searchPlaceholder
    showActiveFilters=showActiveFilters
    sortOptions=sortOptions
    subject=subject
}}

For QA - noticeable changes. There shouldn't be many differences, main change is that page is being built with a component (that also builds registries discover). Needs thorough testing of Discover Page as well as checking navigation from Discover Page to other pages.

Analytics labels are now more generic - previously an event might be sent to look like this:

{
   action:"click",
   category: "link",
   label: "Preprints - Index - Add preprint"
}

Now we remove "Preprints" from the label:
{
   action:"click",
   category: "link",
   label: "Index - Add preprint"
}

The reason is that some analytics are being fired from Ember-OSF now.  Instead of having the label designate which service we are using, we are sending preprints to preprints buckets and registries to registries buckets.
Other changes

Query parameters combined with OR instead of AND (since this is how we're actually searching)
Lucene search turned back on.
Help button added on search bar for Lucene search
If invalid search query like (a:), more lucene search help appears (like SHARE)
Number of searchable preprints added under search bar
Sort by button formatting has changed and now says Modified date
Whitelisted providers
if no query params, there are no empty query params in URL.
better margins on search results in xs screens

Hm, these tests pass locally.

Oops, I didn't have global gitignores setup on my new machine and missed that.  Thanks - my intent was to remove more code here than I added!


Create Doubly_linked_list.cs

Fixes issue:

Changes:

Thank you for contributing @ARsh-ALgo
Keep it up


remote-app-iframe template requires an 'assets' folder because we can't deploy a 'configuration only' static client extension

WE need to look at switching the iframe client extension over to 'runtime configuration' and make it a job instead of a 'static' workload.

See https://issues.liferay.com/browse/LXC-152


C# Build Net6 library and tests using cmake

What does this implement/fix? Explain your changes.
This enables running the (somewhat limited) C# test classes using ctest.
It requires that the dotnet executable is present and that net core 6.0 framework can be compiled and run.
Builds a solution in Code/JavaWrappers/csharp_wrapper that comprises a library project for the rdkit wrapper and an xunit project for the tests.
Works on both Linux and Windows
Any other comments?
Unlike Java I have not separated out each class into a separate ctest.  Rather, all tests are run in a single test.  I can change that if you want.  On windows a configuration argument is required for ctest.  Not sure if that is expected.  Passing --verbose to ctest gives the test report:
>ctest -R CSharpTests -C Release --verbose
UpdateCTestConfiguration  from :C:/gareth/src/rdkit/out/build/x64-csharp-release/DartConfiguration.tcl
Parse Config file:C:/gareth/src/rdkit/out/build/x64-csharp-release/DartConfiguration.tcl
 Add coverage exclude regular expressions.
UpdateCTestConfiguration  from :C:/gareth/src/rdkit/out/build/x64-csharp-release/DartConfiguration.tcl
Parse Config file:C:/gareth/src/rdkit/out/build/x64-csharp-release/DartConfiguration.tcl
Test project C:/gareth/src/rdkit/out/build/x64-csharp-release
Constructing a list of tests
Done constructing a list of tests
Updating test list for fixtures
Added 0 tests to meet fixture requirements
Checking test dependency graph...
Checking test dependency graph end
test 164
    Start 164: CSharpTests

164: Test command: "C:\Program Files\dotnet\dotnet.exe" "test" "RDKitDotNetCore.sln" "-l:console;verbosity=normal"
164: Test timeout computed to be: 1500
164:   Determining projects to restore...
164:   All projects are up-to-date for restore.
164:   RDKitDotNetCoreWrapper -> C:\gareth\src\rdkit\Code\JavaWrappers\csharp_wrapper\swig_csharp\bin\Debug\net6.0\RDKitDotNetCoreWrapper.dll
164:   RDKitCSharpTest -> C:\gareth\src\rdkit\Code\JavaWrappers\csharp_wrapper\RdkitTests\bin\Debug\net6.0\RDKitCSharpTest.dll
164: Test run for C:\gareth\src\rdkit\Code\JavaWrappers\csharp_wrapper\RdkitTests\bin\Debug\net6.0\RDKitCSharpTest.dll (.NETCoreApp,Version=v6.0)
164: Microsoft (R) Test Execution Command Line Tool Version 17.8.0 (x64)
164: Copyright (c) Microsoft Corporation.     Passed    4.49 sec

The following tests passed:
        CSharpTests

100% tests passed, 0 tests failed out of 1

Total Test time (real) =   4.57 sec

fwiw, it worked fine for me and csharp tests passed in a fedora39 container with the dotnet-sdk-8.0 package installed.

fwiw, it worked fine for me and csharp tests passed in a fedora39 container with the dotnet-sdk-8.0 package installed.

Thanks for that feedback!

I have a couple of observations.

After this PR was merged, my Linux build pipeline does not build all the C# artifacts it used to with RDK_BUILD_SWIG_CSHARP_WRAPPER=ON. More specifically, it does not build RDKit2DotNet.dll anymore, it only builds RDKFuncs.so.
Basically, #7326 has broken existing C# build workflows, which will only have a chance to potentially work if RDK_BUILD_DOTNET_CSHARP_TESTS is set to ON.
I don't think this makes sense. Either building the tests should not be optional and the RDK_BUILD_DOTNET_CSHARP_TESTS switch should not exist at all, or one should be able to get a functional build also with RDK_BUILD_DOTNET_CSHARP_TESTS=OFF.
When I set RDK_BUILD_DOTNET_CSHARP_TESTS=ON, the Linux build fails with an error:

[100%] Generating RDKitDotNetLib, SYMBOLIC

Welcome to .NET 7.0!
---------------------
SDK Version: 7.0.201

Telemetry
---------
The .NET tools collect usage data in order to help us improve your experience. It is collected by Microsoft and shared with the community. You can opt-out of telemetry by setting the DOTNET_CLI_TELEMETRY_OPTOUT environment variable to '1' or 'true' using your favorite shell.

Read more about .NET CLI Tools telemetry: https://aka.ms/dotnet-cli-telemetry

----------------
Installed an ASP.NET Core HTTPS development certificate.
To trust the certificate run 'dotnet dev-certs https --trust' (Windows and macOS only).
Learn about HTTPS: https://aka.ms/dotnet-https
----------------
Write your first app: https://aka.ms/dotnet-hello-world
Find out what's new: https://aka.ms/dotnet-whats-new
Explore documentation: https://aka.ms/dotnet-docs
Report issues and find source on GitHub: https://github.com/dotnet/core
Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli
--------------------------------------------------------------------------------------
MSBuild version 17.5.0-preview-23061-01+040e2a90e for .NET
/usr/share/dotnet/sdk/7.0.201/NuGet.targets(399,5): error MSB3202: The project file "/scratch/toscopa1/src/rdkit/Code/JavaWrappers/csharp_wrapper/swig_csharp/RDKitDotNetCoreWrapper.csproj" was not found. [/scratch/toscopa1/src/rdkit/Code/JavaWrappers/csharp_wrapper/RDKitDotNetCore.sln]

Build FAILED.

/usr/share/dotnet/sdk/7.0.201/NuGet.targets(399,5): error MSB3202: The project file "/scratch/toscopa1/src/rdkit/Code/JavaWrappers/csharp_wrapper/swig_csharp/RDKitDotNetCoreWrapper.csproj" was not found. [/scratch/toscopa1/src/rdkit/Code/JavaWrappers/csharp_wrapper/RDKitDotNetCore.sln]
    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:01.69
make[2]: *** [Code/JavaWrappers/csharp_wrapper/RDKitDotNetLib] Error 1
make[1]: *** [Code/JavaWrappers/csharp_wrapper/CMakeFiles/RDKitDotNet.dir/all] Error 2

Maybe this depends on my Linux dotnet version being outdated, or maybe on something else.
Anyway, apparently I will not have a chance to update dotnet to version 8 on my (outdated, I know, but not yet EOL) CentOS 7 workstation:
https://github.com/dotnet/runtime/issues/83428
so I will need to set up a Docker build.
As I do not currently have time to do this, for the time being I'll just revert #7326 locally to get a functional C# build on all platforms using mono.

@ptosco Sorry this has messed up your workflow.
Enabling the old mono build if RDK_BUILD_DOTNET_CSHARP_TESTS is OFF seems like an easy solution to your problem.  Or I can just reenable mono for Linux regardless of the RDK_BUILD_DOTNET_CSHARP_TESTS setting.  That may be better as I can continue to maintain the mono library build. I should have time to do a PR over the weekend.
If you are interested in the dotnet tests I can change the dotnet version to 6 (the tests run fine on dotnet 6).  Unfortunately, installing both dotnet 6 and 8 together on Ubuntu requires manually fixing some paths, which is why I went with 8.

Thank you, @jones-gareth! Don’t bother changing the dotnet version, I can do it locally if needed.


enhancement in development

enhancement in development:

manage config files in one file
move scrollama.js from dev to build, just to keep it DRY
use uglify in rollup
add rollup-plugin-filesize so that we can notify the size of every building
use cross-env to avoid building crash in windows

This is great thanks! I'll take a look and merge today.


Adding quotes on Table Owner

@dlavineway
Any explanation? What is the problem? Why is the fix needed?

If the user profile has a ‘/‘ in the name the statement fails

On Feb 19, 2016, at 1:52 PM, Frank Brückner<EMAIL_ADDRESS>wrote:
@dlavineway https://github.com/dlavineway
Any explanation? What is the problem? Why is the fix needed?
—
Reply to this email directly or view it on GitHub https://github.com/zendframework/zf1/pull/672#issuecomment-186376331.

:: David Lavineway
All e-mail to or from this address is recorded and is subject to archival, monitoring and/or review, by and/or disclosure to, someone other than the recipient. This communication, including its attachments, if any, is confidential and intended only for the person(s) to whom it is addressed, and may contain proprietary and/or privileged material. Any unauthorized review, disclosure, copying, other distribution of this communication or taking of any action in reliance on its contents is strictly prohibited. If you have received this message in error, please notify us immediately so that we may amend our records. Then, please delete this message (and its attachments, if any) without reading, copying or forwarding it to anyone.

@ezimuel
Can you look at this?

@dlavineway can you provide a unit test for that? We cannot merge without it, thanks!


AutoMoq: Fixes mocking get-only interface properties with recent Moq version.

This should fix https://github.com/AutoFixture/AutoFixture/issues/434
It is my first time contributing to this project, and first time looking at its source. So I'm sure there's some feedback. :)
Before this fix, get/set properties would get mocked by MockVirtualMethodsCommand and later overwritten by Moq's SetupAllProperties() in StubPropertiesCommand. Because of a breaking change of Moq now also setting up get-only properties, I had to swap both commands.
So now SetupAllProperties in StubPropertiesCommand is ran, and then MockVirtualMethodsCommand is ran.
Because MockVirtualMethodsCommand also mocks get/set properties, which overrides the stub, I have black-listed get/set properties from being mocked in MockVirtualMethodsCommand.

@dcastro AFAIK you are the author of this integration. If you have free time, it would be cool if you could also review this PR and let us know whether you are fine with it. Thank you in advance 😉

Damnit. I wanted to change it but totally forgot. Guess the coffee hadn't kicked in yet.  ;)
I'll see if I have some spare time during the weekend. Else I'll fix it monday. Such a small thing...
On 4 Aug 2017, at 14:30, Alex Povar <notifications<EMAIL_ADDRESS>wrote:
@zvirja commented on this pull request.

In Src/AutoMoq/MockVirtualMethodsCommand.cshttps://github.com/AutoFixture/AutoFixture/pull/788#discussion_r131377365:

@@ -115,6 +116,14 @@ private static IEnumerable GetConfigurableMethods(Type type)
? type.GetInterfaceMethods()
: type.GetMethods();

       // Skip properties that have both getters and setters to not interfere

       // with other post-processors in the chain which initialize them."

       var getSetMethods = type.GetProperties()

                               .Where(p => p.GetGetMethod() != null &&

                                           p.GetSetMethod() != null)

                               .SelectMany(p => new[] {p.GetGetMethod(), p.GetSetMethod()});

Thanks for that fix, it looks better now 👍 I think that these filters are internal to the class, so it's fine to rely that the subsequent filter will skip all the setters and extra safety is not required.
Thought it would be more clear what I improved
It's often a dilemma what to keep in the history. Usually, I try to not pollute the history with intermediate decisions if I think they bring no value (e.g. I change name of the variable - nobody will be interested how it was initially named). In this case it could be considered the from different perspectives, that's why I suggested to rebase - do what you feel is better 😉
BTW, the variable name getSetMethods is no longer valid as only get methods are present there..
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/AutoFixture/AutoFixture/pull/788#discussion_r131377365, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADmzrw0hWqy_1da3eh_KZx7FgH-fS9Jfks5sUw7RgaJpZM4Op4u0.

@nphmuller Don't worry, we are still waiting for the @dcastro review, so we have time. In any case, if no other comments appear and you become missing, we can always push commits to your branch (if enabled) or even merge without fix :wink:

LGTM, however let's see what @dcastro and other @AutoFixture/core members think as I don't know this area too much.

I don't hold strong opinions on how the Auto-mocking Glue Libraries work*, as long as we're not introducing breaking changes.

* I wrote though AutoFixture.AutoFakeItEasy and AutoFixture.AutoFoq, so I may be able to be of more help regarding these two.

Apologies for the delay 😱.
Looks good to me! This is exactly what I had in mind way back then, including the modification to MockVirtualMethodsCommand to avoid overwriting the setups done by StubPropertiesCommand. Well done!

@dcastro Thank you for the spent time!
@moodmosaic @adamchester Could you please also review whether you are fine, so we can proceed?

@moodmosaic I've just noticed your opinion above. I believe we are fine as no breaking API changes are being introduced here. Therefore, I'm going to proceed and merge this one. Let me know if you have some final concerns 😉

@nphmuller Thanks for your contribution 🥇 Will be published soon.
P.S. I've slightly tuned comments in your commits, so don't be surprised 😉

@zvirja No problem.
And thank you all for maintaining this awesome project. I've read a bit about the governance change and how you all handled it. Great job!

Thanks :)


index.js file would be appreciated when used with a bundler like web pack

why are you using this with webpack? This module should really not be used.
Il 29 feb 2020, 02:33 +0100, Sukant Pal<EMAIL_ADDRESS>ha scritto:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

@mcollina I have an some code that needs to run on Node.js and should bundle with webpack for running in the browser. The only way to access performance.now on Node.js is with the perf_hooks module (right?). However, I need a dummy module for webpack.

You should be not depending on this module. It’s just a placeholder for a node core module. Remove it from package.json and add some config to map it to nothing.


Improve readability of attribute documentation

For some attributes, the displayed documentation is almost unreadable.
Rendered in phx_live_storybook:

The same documentation generated by ExDoc:

Some suggestions:

Documentation column

Render Markdown
Remove max-width: 16rem - this is far too small
Remove style white-space: pre-line;

Column Default

Add style white-space: break-spaces;
Not styling per se, but the Value field cannot be edited when the value is a map

I could indeed improve CSS, but I think that whatever I do, this won't render well in a table.
What do you think of truncating the doc to the first paragraph, and then click on it to expand full doc in a modal window?
There are also some redundant information: ExDoc generate documentation for default values, but this information is already visible in the next column

An expand option could work. Perhaps reveal it in an extra row below the current one.

I was thinking along these lines:

Fixed in #535
(sorry for delay!)


feat: Create reactive composers for common presenter tasks

Fixes #303

Create base presenter interfaces and implementations
Create reactive composers
Replace common logic throughout presenters

To be merged after #308

@mejariamol Review last commit

@arp95 @Shailesh351 @shreyasnbhat @rohanagarwal94 Please review last commit

Please resolve conflicts.

@arp95 @Shailesh351 @shreyasnbhat @rohanagarwal94 Please review

@arp95 @Shailesh351 @shreyasnbhat @rohanagarwal94 Please help with timely reviews and support your co-developers.


Will this work on a Snapdragon 685?

Work fine

So this shouldn't make a bootloop and a no display?

So this shouldn't make a bootloop and no display?

yes i guarantee that

@ImmortalSaul Hello

Hello?

Im surprised, it worked

Selamat

Okay i feel no difference of performance


fix: upgrade dependencies

Summary

Closes #79
Closes #80
Closes #81
Closes #82
Closes #83
Closes #84
Closes #85
Closes #86

:tada: This PR is included in version 1.4.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


IsEquivalentTo FormatException for large double numbers

Nuget Package
Json.More.Net
Package Version
2.0.2
Operating System
None
.Net Target (if relevant, please specify the version in the description)
.Net (5 or after)
A clear and concise description of the bug.
a.IsEquivalentTo(b) fails with FormatException if double value doesn't fit in decimal.
What did you expect?
true or false
Please add test code or steps to reproduce the behavior.
RoslynPad reproducable:
#r "nuget: Json.More.Net, 2.0.2"

using System.Text.Json;
using Json.More;

var str = "{\"a\": 1.0332671e+36, \"b\":2.1292569e+29}";
var json = JsonSerializer.Deserialize<JsonElement>(str);

json.Dump();

var a = json.GetProperty("a");
var b = json.GetProperty("b");

a.IsEquivalentTo(b).Dump();

Is there any other information you'd like to share regarding this bug?
I'm not entirely sure how one should go about comparing these values..
decimal, double, string comparison fallbacks via TryGet?
adding a dependency like https://github.com/tompazourek/Rationals might be overkill for this issue?
Code of Conduct & Contributor Guidelines

[X] I agree to follow this project's Code of Conduct and Contribution Guidelines.

The docs explicitly state that using decimal was a design decision.  (Yes, it's in the JSON Schema section.)  This entire suite follows this philosophy that precision in JSON is more important than range.  You can find a bit more on this in this blog post.

I could be open to this, but I would want it across the suite, not just in JsonSchema.Net.  That means it would need to be Json.More.Net to be used everywhere.
I'd also want it IConvertible so that it can easily be converted to native numeric types.

with the addition of NaN, +Inf, -Inf to cover the possibility of the "Inf", "NaN" formattings

This I don't agree with.  It should model JSON, not .Net's notion of JSON.  These values are not numbers.

Considering the issue i encountered was in Json.More.Net, not the Schemas, i'd imagine it needs to be that deeply integrated.
I'll start with prototyping that type so you can validate it, and then we can look where to implement it?

Let's start there.  Introducing the type to that lib isn't a breaking change, but integrating it into the others will be.  That can be done later.

exactly, this just extends on the idea to convert the string on-demand to the required precision.
It's just that in this exact case, the demanded precision isn't known, and hidden inside the library's equality function with no way to extend or override it easily as developer.
If the comparison can use the full-precision type to do the equality check, that shouldn't break anything. (except for already broken cases?)

I'd also want it IConvertible so that it can easily be converted to native numeric types.

Isn't that slightly dangerous? Some internal marshal calls might think it's an actual native type with GetTypeCode() ..
Wouldn't TypeConverters and implicit or explicit operators be cleaner?


this just a binary and a seemingly unused python file

GitHub is for sharing source code not sketchy binaries that probably malware...

Firstly, it's no malware. I also once submitted it to microsoft to check it so one doesn't get a warning when downloading it. Secondly, you still have the possibility to download the python file to use the script - it's the same code, just not compiled.


Annual growth effects

This PR annualises the growth effects branch and adds variability as well.
Variability: only the autoregression version is implemented!
Annual growth effects: note that the current in-component annualisation, combined with the sequential running of the modules, does not play nicely with the persistence of damages. I have implemented this as follows (but am open to other suggestions).
For 2015-2020, no damages persist.
For 2021-2030, the persistence of damages is determined by the damages in 2020.
For the rest of the timeperiod, the persistence of damages is determined by what happened yearly in the previous timestep, meaning 2021 (dam) --> 2031 (gdp), 2051 (dam) --> 2076 (gdp), and
2200 (dam) --> 2250 (gdp), etc.
Note that because GDP was annualised, the additional downstream components (AdaptationCosts and TotalAdaptationCosts) have been annualised as well. This also means that lots of interpolation that was required previously in the damage components, has now been removed.

Hi @jrising and @P-Wlich, my apologies for this being such a big PR to review; a lot of changes were required to make this model version working.
Especially looking at the EquityWeighting (because it is large) and GDP (because of the growth changes mostly taking place here) components would be useful.

The implementation of GDP persistence is a draft, feel free to comment on this.

Closed this PR because it did not commit into the right branch. New PR opened for the correct branch is PR #52.


Which whisper implementation you used?

Hi @kadirnar,
Have you used insanely-faster-whisper in your projects? It seems the fastest whisper implementation and it would be great if we could have it.
Best,
Behrooz

WhisperPlus library is faster than insanely-faster-whisper library. You should use hqq optimization.

Thank you. Can you provide me with any concrete example of using hqq optimization?


Adding fix for SSL verification in v0.5.0

Hello! I'm using version 0.5.0 of chef-api with Ruby 1.9.3 and an AWS OpsWorks server. I ran into an issue with connecting to the server with SSL verification enabled and using Amazon's provided PEM file. Turns out the issue is because the PEM they provide only has a Certificate, not both a Certificate and Key, so the connection is failing around this line when a key cannot be parsed.
This PR is to replace the cert and key parsing lines with a single line leveraging the ca_file field for the PEM instead which seems to be a more reliable way of connecting with a non-standard PEM. I've only made the change to v0.5.0.

This may also fix this issue (#40)?

In 0.9.0 almost 2 years later I still have the issue :(

@tas50 What is necessary to have this change merged? Our Chef server admins will not provide me with the servers private/public key pair simply so that I can use this API and I imagine this would be the case generally. Users should only need to pass the trusted certificate in order to create an SSH connection.


[TimeSeriesInsights] Fix timeSeriesIdPropertyName is not parsed properly

Fix #1657: timeSeriesIdPropertyName is not parsed properly
Fix #1658: When creating a new Standard Environment, --data-retention-time is not properly documented

add to S169

/azp run


licensing

does the fact that there are dlpoly exes in this repo have an effect on the use of an MIT license?

I have removed dlpoly from the programs dir in commit https://github.com/symmy596/Advanced_Practical_Chemistry_Teaching/commit/fea1237b5586d788082f012acc97f19cdeeca1f1. This means that now the MIT license is valid and the uk government can't really sue us...


[LF] - refactored code and added enhancements

Author: Louis Ferreira
Date: 08/08/2024
Changes made:

Refactor code into seperate projects
Added Razor Class Library and moved all App_Plugins files to that project (keeps umbraco project clean)
Added new templates for:
RedirectToParent - allows the node link to send editor to parent (e.g. Reuseable Content node)
RedirectToRoot - allows the node link to send editor to home/root (e.g. Settings node)
Changed ModelBuilder to output to Shared project, and generate on build
Added launchUrl to start with Umbraco back office when launched from VS
Moved .editorConfig file to root so it applies to all projects in solution

Nice work 🙂

Thanks for sharing this Louis. For anyone else seeing this, @louisferreira wanted to share how they would structure the project rather than the more basic way I did it.

Awesome work @louisferreira - great to compare with the baseline


Ceph reports "too many PGs per OSD" in Deis 1.6

In testing Deis 1.6, my cluster reports:
     health HEALTH_WARN
            too many PGs per OSD (1536 > max 300)

This seems to be a new warning in the Hammer release of Ceph, which we're shipping in Deis 1.6. This got me thinking - perhaps we aren't calculating placement group usage properly, and this is contributing to the various issues we're seeing with Ceph performance (particularly on platform start).
I posted a message to the Ceph mailing list asking for clarification: http://lists.ceph.com/pipermail/ceph-users-ceph.com/2015-May/001222.html
We're using the default 12 pools:
root at ca-deis-1:/# ceph osd lspools
0 rbd,1 data,2 metadata,3 .rgw.root,4 .rgw.control,5 .rgw,6 .rgw.gc,7 .users.uid,8 .users,9.rgw.buckets.index,10 .rgw.buckets,11 .rgw.buckets.extra,

So, I think the calculation is something like:
12 pools * 128 = 1536
12 pools * 32 = 384
12 pools * 16 = 192
It seems that the placement group documentation is unclear. If we should shoot for 300 PGs per OSD, then it seems like we should use a pg_num of 16, since even 32 would result in more than 300 per OSD.
However, if this computation is based on the resources of the host, it'll be harder to choose a default value.

@carmstrong if you change pg_num you need to update pgp_num too
http://ceph.com/docs/master/rados/operations/pools/

if you change pg_num you need to update pgp_num too

Yeah I know :) Just listed it as pg_num so this is easier to follow. We set them both together: https://github.com/deis/deis/blob/e6a078b4119887b4de73e8a6d04291b7cdeb823b/store/gateway/bin/boot#L40-L59

It sounds like we should indeed try lowering the number of PGs here, and shoot for 300/host. This may be useful: http://ceph.com/pgcalc/


How to disable debug log?

Grows exponentially compared the commands being entered. Is there a way to disable the log, or at least reduce the log level from info?

Hmm, are you seeing the log growing unbounded? In theory, it is configured so that that shouldn't happen so I'd be surprised if this is happening.

That's good to know. My concern was more that it's just very noisy, and (for me / general use cases?), not helpful in most cases. On a system with a slow disk (raspberry pi types) there's a noticeable slowdown.


shingle.json

I'm sorry, but I can't accept this.  You can't just add a bunch of duplicates in the tags section like that.  Also the "retweet" icon is really not a very descriptive icon for this feature.


CNDB-11630: Minimal port of CASSANDRA-18049 and additional fixes around rolling logs

What is the issue
I noticed Python DTests failing with:
failed on teardown with "Failed: Unexpected error found in node logs (see stdout for full details). Errors: [[node1] 'WARN  [RMI TCP Connection(2)-<IP_ADDRESS>] 2024-11-05 04:26:00,950 Slf4jExceptionHandler.java:50 - Cannot get access to vectorizedMismatch. The following command line args are required: --illegal-access=permit --add-exports java.base/jdk.internal.ref=ALL-UNNAMED --add-exports java.base/jdk.internal.util=ALL-UNNAMED. exception: java.lang.reflect.InaccessibleObjectException: Unable to make public static int jdk.internal.util.ArraysSupport.vectorizedMismatch(java.lang.Object,long,java.lang.Object,long,int,int) accessible: module java.base does not "exports jdk.internal.util" to unnamed module @73a1e9a9']"
This happens even with JDK11.
https://jenkins-stargazer.aws.dsinternal.org/job/ds-cassandra-build-nightly/1460/testReport/junit/dtest-offheap-bti.fqltool_test/TestFQLTool/tests_stage_2___dtests___dtest_offheap_bti___dtest_offheap_bti_40___test_unclean_enable/
It seems when we updated chronicle in 4fee8631 we missed to add the recommended by Chronicle exports for JDK11+:
https://chronicle.software/chronicle-support-java-17/
We updated chronicle in CASSANDRA-18049
We may want to consider what was done there more than the versions bump, in additional to export/open internals
What does this PR fix and why was it fixed
The patch ports partially CASSANDRA-18049
Not pinning particular versions for the transitive dependencies as that will mean upgrading dependencies  which we do not want to do in a patch release The option we use for deciding how often to roll Audit log segments is now deprecated and the tools emit a warning about that. Make a note about the switch of the default roll of Audit segments options to its new name so it does not emit warnings and update the docs so people know they can still use the old options but they need to change them soon. Old ones not recommended for new deployments. Also, we should change it with main-5.0
If the reviewer approved we leave the old options, we need to add a patch for cassandra-dtest to skip below warning while checking the test logs for warnings/errors:
WARN  [RMI TCP Connection(2)-<IP_ADDRESS>] 2024-11-08 14:55:32,932 Slf4jExceptionHandler.java:50 - You've configured your queue to use a deprecated RollCycle (net.openhft.chronicle.queue.RollCycles.HOURLY) please consider switching to net.openhft.chronicle.queue.rollcycles.LegacyRollCycles.HOURLY, as the RollCycle constant you've nominated will be removed in a future release!
Checklist before you submit for review

[ ] Make sure there is a PR in the CNDB project updating the Converged Cassandra version
[ ] Use NoSpamLogger for log lines that may appear frequently in the logs
[ ] Verify test results on Butler
[ ] Test coverage for new/modified code is > 80%
[ ] Proper code formatting
[ ] Proper title for each commit staring with the project-issue number, like CNDB-1234
[ ] Each commit has a meaningful description
[ ] Each commit is not very long and contains related changes
[ ] Renames, moves and reformatting are in distinct commits

LGTM, but i think you want to include the CASSANDRA-19656 changes.

Disable chronicle analytics (CASSANDRA-19656) was added
DTest patch was not needed as after the add-exports warning was handled, I noticed the tests did not fail  anymore and I found out that there is already a patch committed to ignore that warning - like https://github.com/datastax/cassandra-dtest/commit/5ff6625c59beb0b1ef5c2c29fa5a636568331cd1 and https://github.com/datastax/cassandra-dtest/commit/c629c81b7854539de0cdd151c362873097f824d2
Let's see what CI will tell.
This PR fixes immediate known issues, but we need follow up ticket to revise for any other breaking changes between the version to which we updated CASSANDRA-18049 and the one we currently have in main

The DatabaseDescriptorRef has failed so I fixed it by not adding the chronicle property to CassandraRelevantProperties. This is done anyway in main-5.0. It started asking me for loading also org.apache.cassandra.metrics.TableMetrics$MetricsAggregation which is not loaded in 5.0 and I did not have the time to troubleshoot that now. Setting straight the system property for now works fine.

CI seems fine now from the perspective of this patch. @michaelsembwever , can you take a look again, please?

DTest patch was not needed as after the add-exports warning was handled, I noticed the tests did not fail anymore and I found out that there is already a patch committed to ignore that warning - like https://github.com/datastax/cassandra-dtest/commit/5ff6625c59beb0b1ef5c2c29fa5a636568331cd1 and https://github.com/datastax/cassandra-dtest/commit/c629c81b7854539de0cdd151c362873097f824d2

Yes.  No changes are needed in dtests or apollo-dtests for this patch.

LGTM.  Questions regarding whether we missed comments/docs upstream remain, but are not blocking this PR.

Questions regarding whether we missed comments/docs upstream remain, but are not blocking this PR.

No questions, the topic was cleared here - https://github.com/datastax/cassandra/pull/1415#discussion_r1838150639
Also, one follow-up ticket opened - #11705
Thank you for the reviews!


🐛 BUG: Reload Window Required After Creating Layout or Component for Intellisense to Recognize

Describe the Bug
Every time I create a new layout or component and attempt to use it I have to ctrl+shift+p -> Reload Window to refresh VSCode in order for Intellisense to recognize it and not give an error.

If I either close VS Code and reopen or I ctrl+shift+p -> Reload Window the component or layout will immediately be available and work correctly.

Steps to Reproduce

npm create astro@latest
open blank project
create a new layout (MainLayout.astro for ex.)
create a second layout (AnotherLayout.astro for ex.)
attempt to use  in MainLayout.astro
sometime this second layout is recognized without issue.....
create a third layout (MainHead.astro for ex.)
attempt to use  in MainLayout.astro and it will not be recognized by intellisense and give an error.
delete  tag
reload window
use  tag in MainLayout.astro and it will be recognized and work correctly.

If you try to use the quick fix to import the component, does it work?

Yes the quick fix will bring up a window to allow you to import it.

I also just noticed while trying to test this that it looks like the first one I create will work and import correctly after opening a new project but successive ones will not.
I opened VSCode, created layout QuickFix.astro and went to put it in MainLayout.astro and intellisense worked correctly. Making the second layout called AnotherQuick.astro and trying to insert in Mainlayout.astro gave the same bug as reported. I was able to test the quick fix on  and get it to import. Screenshot is from a third layout showing quick fix pop-up.

I believe this is a bug in https://github.com/volarjs/typescript-auto-import-cache, thank you for the issue!

Is there a way to maybe disable the typescript auto import cache in VS Code?

I have the same problem, it seems to happen only on linux.

Happens on Windows as well. I also want to add that Astro files still show as suggestions even when they are deleted until the next reload/restart of the extension, it doesn't add the import statements if you do click or press enter on the bugged suggestion.

For what it is worth: it is enough for me to run "Astro: reload project" to get it working again. That's a lot quicker than reloading the whole window.

The latest version of the extension should improve the problem here somewhat, however there are still some issues remaining. Apologies for the inconvenience, it was a tough nut to crack!

Same problem on windows. (astro extension v2.8.4)


Unnamed camera on Marathon

Screenshots

I guess it's name should be something like Sec Med Office based on those already named.


Save Command line logs

Is it possible to start the WinAppDriver.exe and store it's output to a specific log file?

yes in commandline just redirect the logs to a file
WinAppDriver.exe > logs.txt


Adjust PopupMenu item id creation to avoid duplicate ids

fix #57829 by adjusting the id creation

Also adjusted it in add_submenu_item

Thanks!


Refactor TizenRenderers

Common

Merge InitializeRenderer and DestroyRenderer into constructors and destructors.
Inline GetWindowHandle.
Code cleanups.

Ecore Wl2

Combine SetupDisplay and SetupEcoreWlWindow into a single function SetupEcoreWl2.
Combine SetupEglWindow and SetupEglSurface into a single function SetupEGL.
Remove unnecessary private methods.
Add additional error descriptions for EGL errors.

Evas GL

Let SetupEvasWindow return bool to make the calling order consistent with Ecore Wl2.

The refactoring is neat and great! :+1:
And.. What motivated you to do this? I wonder what's bothering you :smile:

@bwikbs I was writing TizenRendererWayland (just for fun), and wanted to make the code style consistent across the renderers. :)

@swift-kim
You really hate efl!!!  :smile:


Add User/Admin functionality

When app is deployed and user visits for the first time it should prompt the user to first register and then take them to the setup page
After one user has been registered, no other user should be able to register (a single admin per dashtag site)