Introduce platform support

As the FDB community is officially discontinuing the Windows build(see apple/foundationdb#5135 for more info), we should clarify our posture towards platform like Windows, Apple Silicon and so on.
One way to handle this can be to introduce platform support tiers, like in Rust:

Tier 1 targets can be thought of as "guaranteed to work", meaning that the bindingtester is running on it to check correctness,
Tier 2 targets can be thought of as "guaranteed to build", meaning that CI are running some tests on it.

What do you think about this?

I agree.
About windows, might be great to find a way to have it tier 2 at some point.

I agree. About windows, might be great to find a way to have it tier 2 at some point.

I agree, we should include a Tier 3 with platforms that we would live to have in Tier 2.
I think we can start with something like this:

Tier 1: linux x86_64,
Tier 2: macos x86_64
Tier 3: windows x86_64, apple silicon

Closed in #15


cmd/go: vet incorrectly flags loop variable captured by func literal in GOPATH mode

Go version
go version go1.22.9 darwin/amd64
Output of go env in your module/workspace:
n/a

What did you do?
I wrote the follow unit test in GOPATH mode.
package looptest

import "testing"

func TestLoopSemantics(t *testing.T) {
	values := []string{"1", "2"}
	for _, x := range values {
		t.Run(x, func(t *testing.T) {
			t.Parallel()
			t.Log(&x)
		})
	}
}

Then I ran go vet on the package.
What did you see happen?
$ go vet looptest
# looptest
# [looptest]
src/looptest/loop_test.go:10:11: loop variable x captured by func literal

What did you expect to see?
No issues.
In Go 1.22+, the compiler uses the new loop semantics, even in GOPATH mode. This is proven by running the test, which gives output like so. (The exact address is different each time of course, but the important part is that x has a different address in each test case.)
$ go test looptest -v
=== RUN   TestLoopSemantics
=== RUN   TestLoopSemantics/1
=== PAUSE TestLoopSemantics/1
=== RUN   TestLoopSemantics/2
=== PAUSE TestLoopSemantics/2
=== CONT  TestLoopSemantics/1
=== CONT  TestLoopSemantics/2
=== NAME  TestLoopSemantics/1
    loop_test.go:10: 0xc000032350
=== NAME  TestLoopSemantics/2
    loop_test.go:10: 0xc0000323d0
--- PASS: TestLoopSemantics (0.00s)
    --- PASS: TestLoopSemantics/1 (0.00s)
    --- PASS: TestLoopSemantics/2 (0.00s)
PASS
ok      looptest        0.498s

Therefore, go vet should not have applied this check at all.

Related Issues

Go vet misses closure using variable from outer loop #32876 (closed)
cmd/vet: -rangeloops check only checks last statement in range loop body #21412 (closed)
cmd/vet: rangeloop: inspect all go/defer statements prior to a loop back edge #30649 (closed)
cmd/vet: don't report "loop variable captured" error for versions >= go1.22 #63891 (closed)
cmd/vet: complains about captured range var that's actually a field name #13236 (closed)
cmd/vet: warn about capturing loop iterator variables #16520 (closed)
x/tools/cmd/vet: not always warning about capturing range variable in function literal #8732 (closed)
cmd/go: always pass a GoVersion to cmd/vet #65612 (closed)
spec: less error-prone loop variable scoping #60078 (closed)

Related Documentation

Go 1.22 Release Notes > Tools > Vet > References to loop variables

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

CC @golang/tools-team

CC @adonovan @timothy-king
It sounds like the loopvar analyzer needs to be made aware of this behavior in GOPATH mode.
@matloob can you clarify the semantics here? Should we assume the effective language version in GOPATH mode is the runtime version?

My understanding is that in the absence of a go.mod file the go tool uses Go 1.16 semantics.  So the warning is correct when not using modules.

@ianlancetaylor I think we intended to limit GOPATH mode to Go 1.16 at first, but when we decided to keep GOPATH mode around for people who are for one reason or another not using modules, we decided to let the language version float forward, since otherwise you couldn't use generics ever, for example. The behavior of the 'go test' confirms that. Or at least, 'go test' and 'go vet' clearly disagree here.

Ah, thanks.

This was previously reported as #65612 in the command-line-arguments context, but it's the same underlying issue for GOPATH. We fixed this in 1.23 with https://go.dev/cl/593156, explicitly setting the go version to the toolchain version when outside of a module.
We considered backporting the change to Go 1.22 but decided not to because it didn't seem to be a serious problem that prevented a program from working at all (and Go 1.22 already had issues with not passing in -lang to the compiler that we wanted to fix at the same time, and would change the behavior for building programs).

Thanks @matloob, I'd missed (or forgotten) that context.
I think it's reasonable not to backport this fix for 1.22 GOPATH mode. Therefore, closing as a dupe.


Refactoring object converter class

Refactored the object converter class by fixing the following

Declaration redundancy
Java language level migration aids (For loops to foreach)
Performance issues
Probable bugs
Spellings

@Vishanth Would you mind resolving the conflicts in this pull request?
Thanks

@imesh Will do the needful.
Regards.

@imesh Sorry the changes removed while working on another task. Will redo this and send a fresh PR.

Resent in PR https://github.com/apache/stratos/pull/294


Documentation

Tested with tls-crypt, it`s all works, I can share some configs, if you need to add this small part to Readme.md

in the backend code we are ready to use only tls-auth key, and so rendered client config will have only this type of auth

Tested with tls-crypt, it`s all works, I can share some configs, if you need to add this small part to Readme.md

Hello. Please share your configs with me.


VERSION CONTROL V2.0

These are my current settings as of 9 May 2018.

My settings as of 9 May 2018.


POST Params paring issue

I was trying to extract POST parameters from requests and failed. What I've tried
#In Router
app.router.add_route('/add', add, method='POST')

#In Function
# Add url to database
def add(request):
    #try:
        db = request.mongo
        url = request.match_dict['url']
        key = request.match_dict['key']

And I'm getting error
File "in.py", line 41, in add
    url = request.match_dict['url']
KeyError: 'url'

Any idea how to get things functional?

Try This
def basic(request):
test=request.query['name']

Try this
def basic(request):        test = request.form['name']

And how to get POST parameters ? Nothing to work


Update location of the custom DAU definition

🚀 Deployed on https://6363ee20247777006b76bad2--cozy-fox-0defec.netlify.app


Logical definitions: protons, elemental oxygen, hydride

Hello,
We are not always using the same term to refer to protons:
For 'acetylcholine:proton antiporter activity' we have in the logical definition:
'antiporter activity'
and (imports some acetylcholine)
and (exports some 'elemental hydrogen')
For 'proton transport' we have
transport
and ('transports or maintains localization of' some proton)
and for 'sialic acid:proton symporter activity' we have
'symporter activity'
and (imports some hydride)
and (exports some 'sialic acid')
Are these all equivalent? Is there a preferred one ?
@cmungall @dosumis
Thanks, Pascale

I have added this to today's ontology call, but if there are no comments/objections I will change all to 'proton' since this is the term used in the class labels.
Thanks, Pascale

OK all agreed to use 'proton' on the Nov 20, 2017 editors' call.


OnSend Addin Support for Office 365 Desktop Clients

When can we expect On Send Add in support for Office Outlook Desktop clients ?

@sourabhkrishna Thanks for your question. I'll check with the team and get back to you.

@sourabhkrishna This feature is now available on Mac and Windows for those in the Office Insider program on the Insider Fast track. It should soon be more broadly available but we can't provide exact dates at this time. I hope you are able to try it out on those clients and share your feedback!
I'll close this issue now but if you have any further questions about this, let us know and we can reopen it.
Thanks again for your interest in this feature.


[CI] Humble source build fails

The humble source build on humble branch fails for some time now:
https://github.com/ros-controls/ros2_controllers/actions/workflows/humble-source-build.yml?query=branch%3Ahumble
But the scheduled one (tagged with branch=master) succeeds?

ERROR:colcon.colcon_core.entry_point:Exception loading extension 'colcon_core.environment_variable.powershell_command': cannot import name 'OVERRIDE_OPT' from 'em' (/usr/local/bin/em.py) The Python package 'empy' must be installed and 'em' must not be installed since both packages share the same namespace
Traceback (most recent call last):
File "/usr/local/lib/python3.10/dist-packages/colcon_core/entry_point.py", line 120, in load_entry_points
extension_type = load_entry_point(entry_point)
File "/usr/local/lib/python3.10/dist-packages/colcon_core/entry_point.py", line 168, in load_entry_point
return entry_point.load()
File "/usr/local/lib/python3.10/dist-packages/pkg_resources/init.py", line 2465, in load
return self.resolve()
File "/usr/local/lib/python3.10/dist-packages/pkg_resources/init.py", line 2471, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
File "/usr/local/lib/python3.10/dist-packages/colcon_powershell/shell/powershell.py", line 17, in
from colcon_core.shell.template import expand_template
File "/usr/local/lib/python3.10/dist-packages/colcon_core/shell/template/init.py", line 19, in
raise e from None
File "/usr/local/lib/python3.10/dist-packages/colcon_core/shell/template/init.py", line 10, in
from em import OVERRIDE_OPT
ImportError: cannot import name 'OVERRIDE_OPT' from 'em' (/usr/local/bin/em.py) The Python package 'empy' must be installed and 'em' must not be installed since both packages share the same namespace

Seems to be fixed in the meantime


DRILL-7152: During histogram creation handle the case when all values…

… of a column are NULLs.
Please see DRILL-7152 for a description of the issue.  It was caused because all the column's values are NULLs and the t-digest code-gen functions tried to generate an output for an empty t-digest since it does not store any NULL values.  The fix is to check the t-digest size() first before trying to create the output.

@gparai could you please review ?  Thanks.

@amansinha100 please take a look at the Travis failure. Otherwise, changes LGTM.


Add Scraper for Mass Appeals 128 Decisions

Massachusetts has a website dedicated to Massachusetts Appeals Court Summary Dispositions Pursuant to Rule 1:28
These decisions issued after February 25, 2008, may be cited for its persuasive value but, because of the limitations noted above, not as binding precedent.
See https://128archive.com
Currently there are 14,261 decisions that would be good to add to our db.

This has been finished.


Update Browserslist config with future support

Support for IE11 -ms-* vendor prefixes came up recently on Slack following https://github.com/alphagov/govuk-frontend/pull/3720/commits/478af395c7b18e27be79183acff6afd497c084c2
Based on thinkings from @36degrees in The future of browser support in GOV.UK Frontend (internal) I've put a draft PR together of some Browserslist config changes we might want to make
Up for discussion as part of:

https://github.com/alphagov/govuk-frontend/issues/2718

I've included separate Browserslist environments for JavaScripts, Stylesheets and Node.js:
# This list builds on the GOV.UK service manual's browser testing recommendations
# https://www.gov.uk/service-manual/technology/designing-for-different-browsers-and-devices

> 0.1% in GB and not dead
last 6 Chrome versions
last 6 Firefox versions
last 6 Edge versions
last 2 Samsung versions
Firefox ESR
Safari >= 12
iOS >= 12.1

[javascripts]
> 0.1% in GB and supports es6-module
last 6 Chrome versions
last 6 Firefox versions
last 6 Edge versions
last 2 Samsung versions
Firefox ESR
Safari >= 12 and not Safari < 11
iOS >= 12.1 and not iOS < 11

[stylesheets]
> 0.1% in GB and not dead
last 6 Chrome versions
last 6 Firefox versions
last 6 Edge versions
last 2 Samsung versions
Firefox ESR
Safari >= 12
iOS >= 12.1
ie 11

[node]
node 18

For example:

Environment [stylesheets] restores Internet Explorer 11 to maintain -ms-* vendor prefixes
Environment [javascripts] removes Safari 9-10 that fails 'noModule' in HTMLScriptElement.prototype

Should we add Babel in future this will help keep transforms/polyfills to a minimum

Out of curiosity, why does the JavaScript configuration specify:
Safari >= 12 and not Safari < 11
iOS >= 12.1 and not iOS < 11

and not just
Safari >= 12

Thanks for taking a look @querkmachine
It was a safety net for the > 0.1% in GB returning older Safari releases (see their Query Composition notes)
You'll see it unintentionally bringing in Safari on iOS 8.1-8.4, 9.3 etc where only Safari 9+ actually supports ES2015 modules, but worse still only Safari 11+ supports nomodule scripts
So by narrowing it down to > 0.1% in GB and supports es6-module we still need to filter out Safari 10.3 on iOS

Revised to lower Safari 12 to Safari 11 to match our "cut the mustard" check:
'noModule' in HTMLScriptElement.prototype


Vanilla converted diamond tools and weapons are undesirable due to durability loss.

There is currently no good reason to convert to dungeons gear versions of diamond items as they take a massive durability decrease.
Take the diamond sword as example, you need to use 1 diamond to convert it, gaining sharpness I is a fair trade for the additional cost but losing 1311 points of durability unfortunately makes this conversion worthless to do.
if you bring the converted diamond tools & weapons up to their original vanilla durability levels it would make the conversions worth the additional resources and a more compelling choice.
additionally the conversions for the gold axe/sword & the stone sword give too much durability , gold being 32 & stone 131 points in vanilla.
iron is the only balanced items being on par with vanilla at 250 points.

I suggest watchign #105 . It won't directly fix this issue, but it will allow you to make corrections yourself so that the durability is where you want it. Be aware, for now, there is no intention to actually replace the vanilla diamond tools.


Will wak get added to toybox?

Hey there, thank you for your time and effort.
wak looks very promising, will it be added to upstream toybox?

@firasuke, Thanks for noticing wak. It doesn't have much publicity. How did you discover it?
The toybox version of wak (wak/toybox/awk.c) was added to toybox late June or early July and updated Sep 3 to the almost-latest version. It's in toybox/toys/pending/awk.c with tests in toybox/tests/awk.test. I don't know when or if Rob will "promote" it to the toybox/toys/posix folder. For now, you need to use make menuconfig when building toybox and select awk in the pending menu. If it gets into the posix folder, it will be built into toybox by default. I hope to convince Rob to promote it soon, but we'll see how that goes.
BTW there's a little documentation on the development of it here: https://www.raygard.net/awkdoc/ . I don't think I have a link to that in the README.md file yet. I'll beef up the README soon, I hope. I have some valuable feedback from Nelson H. F. Beebe that I need to attend to, also.

Oh, I checked version 0.8.11 and I noticed it wasn't there, so it was added later, interesting..
I was searching for possible alternatives to mawk and I found wak, the only concern I have is about its performance, could it be improved to be on par with mawk?
Thanks for your time and effort!

Toybox releases have been a bit irregular lately, Rob Landley has had some issues with moving to a different state and hassles with changing laptops I think.
I intend to try to improve its performance, but it may never get close to as fast as mawk. One of the main goals has been to keep wak as small as I reasonably can, as Rob would prefer. In fact, I believe he thinks it is already too big. It will be a challenge to significantly improve its performance while not making it much larger than it is. I tend to think of its performance more in comparison with busybox awk rather than other implementations, as toybox is intended, I think as a replacement for busybox. I think wak is already faster than busybox awk.
How did you find wak?

Toybox releases have been a bit irregular lately, Rob Landley has had some issues with moving to a different state and hassles with changing laptops I think.
I intend to try to improve its performance, but it may never get close to as fast as mawk. One of the main goals has been to keep wak as small as I reasonably can, as Rob would prefer. In fact, I believe he thinks it is already too big. It will be a challenge to significantly improve its performance while not making it much larger than it is. I tend to think of its performance more in comparison with busybox awk rather than other implementations, as toybox is intended, I think as a replacement for busybox. I think wak is already faster than busybox awk.
How did you find wak?

Oh interesting. I tried wak and it seems like a solid replacement for gawk/mawk. My only complaint is the performance, as currently it is 2-3 times slower than gawk, and up to 8-10 times slower compared to mawk which is a lot.
I have high hopes though, keep up the great work!
Closing..


AttributeError: module 'nest' has no attribute 'Create'

import matplotlib.pyplot as plt import nest neuron = nest.Create("iaf_psc_alpha")
AttributeError: module 'nest' has no attribute 'Create'
I am running in colab.
pip install pynest-api
import sklearn
import scipy
import nest

Hi @Dipendra7, this does not look like a Sonnet issue. Please report a bug/ask a question on the issue tracker of pynest-api.


A quick fix for oscuring cards for nsfw content.

The download cards in page were not obscured when opening a link
directly(e.g. lbry://jacki2).

This change broke the functionality I guess.


Removed unnecessary space before ? in README.md header

Thanks for fixing.  Not sure how we overlooked that :-)


Tagforce TMS

I've used this tool , but cant seem to find anything to open Tag Force TMS files.
cutin-chara-amunael01-base.zip

TMS files are models. You'd need another tool to read or convert those to a usable format. Maybe a MaxScript for 3DS Max could be written for them.
I'm not much of an expert in models myself but it seems like a relatively simple format to decipher (lots of floats, probably verticies and normals). I could try some things out (convert floats to OBJ and hope for the best) but again, I'm a total noob when it comes to model formats.
In any case, this is something that will need to be done with a separate tool. A good place to ask around would probably be ZenHAX forum.

I have tried to asked there but no luck either. Thank you tho.


Night Life Coordination Example App broken

Describe your problem and how to reproduce it:
The recipe box demo website does not work because it is using a deprecated yelp api.
Add a Link to the page with the problem:
http://whatsgoinontonight.herokuapp.com/
(view network log when searching)
Tell us about your browser and operating system:

Browser Name: Chrome
Browser Version: N/A, server side issue
Operating System: Ubuntu 18.04

If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):

I think you are looking at the nightlife coordination app project - and not the recipe box.

Just to clarify, the recipe box demo is here: https://codepen.io/freeCodeCamp/full/dNVazZ/
However, it's true that the nightlife coordination project is currently broken due to the Yelp v2 API being discontinued in favor of Yelp Fusion. Is this another project we should get working before the release of Next, @QuincyLarson?

@scissorsneedfoodtoo Yes - we should find a nightlife coordination project built by someone that uses Yelp Fusion and link to that instead. Could you look around and see if you can find such a project? If not, we may need to retrofit the existing code to use Yelp Fusion.

Bump.


Separate generation of domains

Generate each domain into a separate module to:

improve compile times
lessen verbosity of types and functions that have the domain name prefixed

Depends on #11

Got around the inaccurate dependencies specified by the protocol through:

collecting dependencies for each domain
forming a graph from the dependencies
obtaining strongly connected components
to overcome cyclic dependencies, generating each component into a single module


Issues while trying to detect and connect to a ChromeCast

I use SharpCaster to cast the media to a Chromecast, but most of the time, the Chromecast could not be found. Worse, when the Chromecast is found, SharpCaster could not connect to the device (Timeout or Socket exceptions are thrown).

Are you using Sharpcaster on a desktop? Do you know if those computers have multiple network cards? If you have installed VMWare Workstation, VirtualBox or Hyper-v this happens automatically and it has problems to find the device.
I haven't seen any problems on connecting to the device if it has been found. Would be really interested in these scenarios. Especially if you have any clues how to reproduce the problem.

Need more information to be able to do anything about this issue


v1.15.0

What's New?
Enhancements

Support for the Unified Push protocol (thanks @Garland-g)
New Notification Providers settings page

You'll be able to manage all of the different providers for notifications (i.e. Firebase, Background Service, or Unified Push)
Better tools to manage your Firebase configuration

Editing a message will be disabled for messages older than 15 minutes
Adds the ability for the app to remember the reply-state for chats (thanks @cameronaaron)
Adds troubleshooting tool to clear the last opened chat "state"

This is useful for users who run into the bug where the app will get stuck opening the same chat

Adds support for setting custom headers during the setup process
Adds support for using custom headers when connecting to the server's websocket via the background service

Fixes

Fixes app crash when background service is enabled and your password includes a % in it
Fixes issue sending links on macOS Sonoma+
Fixes issue where the app would not exit from the chat list, when using the Material or Samsung themes
Improved background service error handling
Fixes issue where Firebase tokens would not be revoked when resetting the app.
Fixes issue loading FindMy devices from the server

closes #2847 https://github.com/BlueBubblesApp/bluebubbles-app/issues/2845
https://github.com/BlueBubblesApp/bluebubbles-app/issues/2838
https://github.com/BlueBubblesApp/bluebubbles-app/issues/2837
https://github.com/BlueBubblesApp/bluebubbles-app/issues/2811
https://github.com/BlueBubblesApp/bluebubbles-app/issues/2274
https://github.com/BlueBubblesApp/bluebubbles-app/issues/2642


Typo in Table 1 from Paper

Hello,
Thank you for the awesome work. While going through the paper, I found that in Table 1, there seems to be a typo in the following statement "Entries in gray are trained trained for 400 epochs more than ViL."
I wanted to bring this to your attention. If this was intentional, would you mind clarifying the meaning of "trained trained?"
Thank you! I attached a screenshot of it as well.

Hi, thanks for reading it carefully and pointing that out.
It's not intentional, just a case of repetition blindness :)
Well fix that in the next version.


Configure Azure Pipelines

his pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: omolewa-gtbhub sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Get Document ID copied to clipboard

cf. https://issues.redhat.com/browse/ENTESB-14896
#2198 introduced UUID added to the Document ID while Document name is shown in UI. In order to put the mapping into Camel Route, user need a Document ID string to handle multiple source documents. Add some way to copy Document ID to their clipboard.

Looks cool - I think Extended document name should be Document ID

Ok

How do you copy to the clipboard the Document ID?
I don't see the option running AtlasMap in VSCode

How do you copy to the clipboard the Document ID?
I don't see the option running AtlasMap in VSCode


[Bug]: marker views not propagating press events from their children

Mapbox Implementation
Mapbox
Mapbox Version
10.16.4
React Native Version
0.73.1
Platform
iOS
@rnmapbox/maps version
10.1.19
Standalone component to reproduce
import Mapbox from '@rnmapbox/maps'
import React, {
  createRef
} from 'react'
import {
  Image,
  Pressable,
  ViewStyle,
} from 'react-native'

import Images from '@/constants/images'

type Props = {
  style?: ViewStyle,
}

export const mapRef = createRef<Mapbox.MapView>()
export const cameraRef = createRef<Mapbox.Camera>()

const POIMap = ({
  style = {},
}: Props) => {

  return (
    <Mapbox.MapView
      style={{
        flex: 1,
        width: '100%',
        height: '100%',
      }}
      onPress={() => console.log('pressing the map')}
    >
      <Mapbox.Camera
        ref={cameraRef}
        defaultSettings={{
          centerCoordinate: [0,0],
          zoomLevel: 9,
        }}
        minZoomLevel={1}
        maxZoomLevel={18}
      />
      <Mapbox.MarkerView
        key={'MarkerView'}
        id={'foobar'}
        coordinate={[2.1901266872462024, 41.378911532404516]}
        isSelected={false}
      >
        <Pressable
          style={{
            width: 44,
            height: 44,
            alignItems: 'center',
            justifyContent: 'space-around',
          }}
          onPress={() => console.log('pressing the marker view')}>
          <Image
            style={{
              width: 44,
              height: 44,
              marginVertical: 8,
            }}
            resizeMode="contain"
            source={Images.poiKinds.mapPin.inactive.eat}
          />
        </Pressable>
      </Mapbox.MarkerView>
    </Mapbox.MapView>
  )
}

export default POIMap

Observed behavior and steps to reproduce

Map shows the child of the MarkerView rendered nicely. However when clicking upon the marker, no event seems to be propagated. No logs come out for the onPress event of the Pressable component used as a child of the MarkerView.
Expected behavior
The console log of 'pressing the marker view' should be seen in the logs. It is not.
Notes / preliminary analysis
I've tried using a PointAnnotation but cannot get an  component from ReactNative to render at all when using that as a child of the PointAnnotation.
Have tried all sorts of things. This is very frustrating. Any help would be greatly, greatly appreciated!
Additional links and references
No response

I have a similar issue on iOS, on android it seems to be working normally

Also the onPress on MapView, onTouchMove and onTouchEnd don't work, while onTouchStart does
On MarkerView, the onPressIn and onPressOut work, but onPress doesn't
Seems to be a general event propagation issue on iOS.
Also using rnmapbox/maps, version 10.1.11 with default mapbox version, react native version 0.72.6

This is only happening on iPhone XS for us. Same for you all?

This is only happening on iPhone XS for us. Same for you all?

A potential solution is to temporarily use onPressOut.

I am also having this issue on rnmapbox/maps version 10.1.27, react native version 0.71.0 and it's only happening on iOS, not Android. I'm currently using onPressIn as a workaround but hoping this'll get fixed soon! 🤞
Simple code example:
 <Mapbox.MarkerView
    id={id}
    coordinate={coordinate}
    anchor={{ x: 0.5, y: 1 }}
    allowOverlap
  >
    <Pressable onPress={onPress}> // this `onPress` never gets triggered
      {...other content}
    </Pressable>
  </Mapbox.MarkerView>


Cell type wheel visualise the data wrongly

Cell type search result page not working correctly. No gene heat map showing on the right, after clicking on any cell in the left wheel.
Cell Type wheel in staging environment (not correct):

Cell type wheel in public environment (correct):

Steps to reproduce:

Open Single Cell Expression Atlas on staging environment: https://wwwdev.ebi.ac.uk/gxa/sc/home
Select liver (organ/organism part) on the gene search from the home page: https://wwwdev.ebi.ac.uk/gxa/sc/search/metadata/liver

If we search for a species, like Gallus gallus that is also displays wrongly. Gallus gallus should not show up on the 2nd (organism) level. We tested this with other species as the search term and the result was similar.


Use postman-to-openapi package in the postman

Hello @joolfe
Is there any way to use this package in the postman app?
I tried some solutions but nothing works for me.
Any ideas on how to use this package in the postman.
Sorry for creating an issue😔

Hi @rishipurwar1,  you mean to execute the library forma postman script section? What si exactly what you are trying to do?

Yes! I want to execute this library from the test script section.

@joolfe Yes! I want to execute this library from the postman test script section.
I want to make a collection so, we can generate an OpenAPI from the postman collection using this library right from the postman.

I'm afraid that you cannot import libraries from postman script, you can only import the sandbox libraries in a postman script, you can have a look here.
As a workaround you can copy and paste all the library code (also dependencies code) inside a postman script section and try to make it work but I think is not going to be easy, just an idea.

@joolfe Thanks for your help.
One thing I want to ask that which type of file inputs is allowed?
For Example: copy the postman collection JSON data and paste it as a string or a collection JSON URL stored on a DB?
Is any of the two methods allowed?


Enable PR format checker

Add initial PR format checker.
ONE-vscode-DCO-1.0-Signed-off-by: SaeHie Park<EMAIL_ADDRESS>

Oh,, it runs!

Oh,, it runs!

Made a branch in this REPO...
I'll rebase after #33 lands

https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks
@seanshpark Maybe this is related?

Maybe this is related?

Seems so, it's reasonable... :)

For history, for #20


Basepath Problem

This issue is about swagger spec and base path behavior.
Using this library if you set it to "/" (meaning root), it's appending a "/" to the end of the url resulting in http(s)://host:port/apiRoute//... it should be http(s)://host:port/apiRoute/...
Instead if it's not simply "/", and something like "/basepath/" it's correct to append a "/" on the end if it doesn't exist.
I don't have this issue with swagger-ui itself, hence I though I should bring it up.

Should be able to close now - addressed in #58

I see that the problem is addressed and solved, may I know when will it be available in release? I see that the packages downloaded via bower still have the old version. Thanks.


[Feature request] riverAccordion

Context
We often stack our river to create a product features et narrative. This leads to long pages that spread small amount of incremental information over lots of scroll and many demos. By condensing the content of multiple river into an accordion we could create a stronger condensed narrative.
Here is an example of both approach side by side:

@simmonsjenna has been exploring similar UX for the homepage section

Design suggestion
The component relies structurally on up 4 text+image internal units (with a minimum of 2, 1 being a regular river) and an active state rotation setting focus on one unit at the time. It would not be proper accordion that the extent that it would have a single active element at any time.

Similarly to the riverStoryScroll we could combine multiple rivers
Create a variant of the river with multiple image+content internal units
Create a net new component

Component props:
Each props would apply equally to all units:

Autoplay (default: true - 5s)
Link (default: false)
Status icon (default: true) = + or - depending on active item
Description (default: false)
leadingIcon (default: false)

Timing/urgency
Homepage is likely going to need a quick build with very specific styling led by brand refactoring thus will be custom built. I suggest that this should inform the definition phase in parallel.

Triaged at planning on 28th October.

@simmonsjenna will present the pattern at a11y office hours

Some ambiguity around motion and auto-scrolling behaviours

@jesussandreas will review the existing designs for accuracy and provide a design file diffing any changes
Primer Brand able to take on this request in Q2

@rezrah Following up with my notes from the A11y Design pairing session with @ericwbailey and @janmaarten-a11y:

Advice: simplify by getting rid of the definition lists and let the buttons themselves be the enumeration
Suppress tab focus on child links when in collapsed state (e.g. when tabbing through and the item is not expanded, the child links like "Download GitHub Mobile" are still getting focused)

We also discussed autoplay and how that might be approached. I think we should leave autoplay out of this component and revisit it in the future if needed due to the complexities it introduces.

Hellooo, here's the reviewed design for us to apply on other pages.
It follows patterns that are close to the river container in order to ensure it feels part of the component ecosystem.
Figma

Screenshots.


Victim/nemesis for each player

Victim = The player the selected player beats the most
Nemesis = The player the selected player loses to the most
This could be either as a raw score or as a percentage of games played (if this was used, there would have to be a minimum games played threshold).

Would it be worth doing a first cut of this client side?

Hmmm up to you, I think there's a cool opportunity to add a Badge object to the schema for the other issue and we can reuse that for victim/nemesis but I'm cool with either approach

Well I was thinking because the player stats page already goes through all of the player’s matches to get the W-L record, that for loop could be combined with the min/max ELO one and then this as well to get all statistics at once. That way it wouldn’t be any less efficient. This would only be a temporary thing anyway, though, eventually we’d make it DB-based.

Yeah that makes sense - I'm cool with it if you were feeling inspired to do it like that. For the profile pages it'll be the same like you said,  however displaying the info on the ladder page clientside will be more complex to keep the iterations down

I wasn’t actually thinking of putting the info on the ladder page. What did you have in mind for that?

New columns or icons next to the names that signify who is currently a nemesis of who I reckon, but that can be a future thing

This issue is more so for the backend implementation of this now, as the client-side implementation has been done.


Elasticserarch v7.15.2 seems unsupported

call_filtering.sh script at least only return error 400's for the actual filtering operations.
The way it's said in the README about use 6.5+ is bad, if 7+ is not supported or I misunderstood it.

exactly the same issue here, running ES 7.17.7-78


multiple images

plugins / other scheme should be able to have multple photos

Multiple images would add more maintenance and overhead.
Definitely could consider it as a feature enhancement, but I don't feel its essential at the moment


[5.7] Container bindMethod improvement

resubmit of https://github.com/laravel/framework/pull/23767

Ton of other changes here.

@taylorotwell , @GrahamCampbell ,
It happened after
@GrahamCampbell GrahamCampbell changed the base branch from 5.6  to master  36 minutes ago
Should I create PR to master brunch?


[e2e]: docker-based workflow_dispatch main default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/4750154220
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Thu Apr 20 03:20:50 UTC 2023

Blocked by https://github.com/slsa-framework/slsa-verifier/issues/561

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/4761084908
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Fri Apr 21 03:21:01 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/4770646802
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Sat Apr 22 03:20:43 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/4776172967
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Sun Apr 23 03:20:43 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/4782133852
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Mon Apr 24 03:21:04 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/4793312919
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Tue Apr 25 03:20:38 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/4804520556
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Wed Apr 26 03:20:24 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/4815622571
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Thu Apr 27 03:20:50 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/4826687124
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Fri Apr 28 03:21:06 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/4836628990
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Sat Apr 29 03:20:00 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/4842223097
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Sun Apr 30 03:20:09 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/4848110249
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Mon May  1 03:21:30 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/4855070415
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Mon May  1 21:26:38 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/4857264651
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Tue May  2 03:20:35 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/4867971920
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Wed May  3 03:20:41 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/4878757302
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Thu May  4 03:20:04 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/4889621021
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Fri May  5 03:20:34 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/4899453990
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Sat May  6 03:20:06 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/4905068019
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Sun May  7 03:20:28 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/4911059641
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.docker-based.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Mon May  8 03:21:05 UTC 2023


BTS-668 | List code, error, errorNum, errorMessage, and extra attributes for subsequent cursor batches

Backport of https://github.com/arangodb/arangodb/pull/15752

[ ] https://jenkins.arangodb.biz:3456/view/Documentation/job/arangodb-ANY-examples/1713/


[SPARK-40467][SS] Split FlatMapGroupsWithState down to multiple test suites

What changes were proposed in this pull request?
This PR proposes to split the FlatMapGroupsWithStateSuite into three pieces:

GroupStateSuite <- test the functionality with (Test)GroupState implementation
FlatMapGroupsWithStateWithInitialStateSuite <- test E2E cases which are specific to initial state
FlatMapGroupsWithStateSuite <- all other cases (E2E cases which don't leverage initial state)

The change is pure extraction - it's cut and paste and no additional code change has been introduced.
Why are the changes needed?
This would help to maintain the test suite FlatMapGroupsWithStateSuite as it's quite huge.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Refactored test suites.

Thanks! Merging to master. (The last commit only removed unused imports.)


[WIP] Allow deletion of groups with users belonging to other groups

Allow deletion of groups when all users within the group also belong to other groups.
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1264967
https://www.pivotaltracker.com/n/projects/1613907/stories/131568585

@miq-bot add_label enhancement

@lpichler, @gtanzillo - please review

@miq-bot add_label euwe/yes
@miq-bot add_label blocker

@miq-bot add_label fine/yes

@lpichler, @jrafanie - please review again

@lpichler , @jrafanie - requested changes made

Euwe backport details:
$ git log -1
commit 6dd942b66aa0f67a74acfc181ddd3c293bd8fdb7
Author: Joe Rafaniello<EMAIL_ADDRESS>Date:   Wed May 24 13:48:04 2017 -0400

    Merge pull request #15041 from lgalis/allow_not_empty_group_deletion

    Allow deletion of groups with users belonging to other groups
    (cherry picked from commit 828b50b82e5a7dedb2394e4db942bf1357360e6c)

    https://bugzilla.redhat.com/show_bug.cgi?id=1322396

Fine backport details:
$ git log -1
commit caa1b85a0d0ff8f73790a565843fc9866ec06aec
Author: Joe Rafaniello<EMAIL_ADDRESS>Date:   Wed May 24 13:48:04 2017 -0400

    Merge pull request #15041 from lgalis/allow_not_empty_group_deletion

    Allow deletion of groups with users belonging to other groups
    (cherry picked from commit 828b50b82e5a7dedb2394e4db942bf1357360e6c)

    https://bugzilla.redhat.com/show_bug.cgi?id=1460307


CASSANDRA-19429 4.1 remove capacity calls when unnecessary

Thanks for sending a pull request! Here are some tips if you're new here:

Ensure you have added or run the appropriate tests for your PR.
Be sure to keep the PR description updated to reflect all changes.
Write your PR title to summarize what this PR proposes.
If possible, provide a concise example to reproduce the issue for a faster review.
Read our contributor guidelines
If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:
<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

I think all the method calls like getCapacity() != 0 and getCapacity() == 0 should be replaced by a method in the DatabaseDescriptor class that is clear and easy to use whether a cache is enabled or not. We should avoid using getCapacity method to check such a condition. This is true for the trunk, 5.x, 4.x


Consider adding google cloudbuild as supported CI provider

We are moving from travis to google cloudbuild as CI and we would love to keep Codecov. Cloudbuild has a list of environment variables, see here,  which seem to be sufficient to run Codecov when comparing them to the environment variables from other supported CI providers, see here.

I'm going to close this out due to age, but if this is still a need, please open a feature-request on our community boards


Improve performance around Axis(3) limits

Seems like performance slows quite a bit if many plots are added in sequence to an Axis. Because each plot triggers a resize_limits!, first of all the limits have to be recomputed for all previous plots when a new one is added, and this also triggers tick changes, which trigger layout changes, etc. So all in all this can be quite slow. This PR adds an option to disable the reset_limits! call, which should mainly be interesting for workflows where all plots are added in one go, without a person looking at the progress. So for example this should probably be used in AlgebraOfGraphics @piever .
Also, I noticed dynamic dispatch in the code path that computes the limits in the first place and tried to fix that. I'm not sure if the logic is perfectly right with regards to NaNs, that behavior can be a bit tricky to pin down. For example, what if there's a NaN only in one dimension of a point, do we skip that whole point or use the remaining components. This PR does the latter.
Here's some examples how the PR improves performance:
Many plots in sequence
Before: 4.999897 seconds (206.07 M allocations: 6.235 GiB, 14.02% gc time)
After: 0.255500 seconds (2.88 M allocations: 151.533 MiB)
f = Figure()
ax = Axis(f[1, 1])
ax.reset_limits_on_plot = false # new feature
@time for i in 1:500
    lines!(ax, randn(1000) .+ 5i)
end
ax.reset_limits_on_plot = true # new feature
reset_limits!(ax)
f

Single plot
Before:  0.176131 seconds (10.00 M allocations: 305.179 MiB)
After: 0.012864 seconds (92 allocations: 4.203 KiB)
f = Figure()
ax = Axis(f[1, 1])
lines!(cumsum(randn(1_000_000)))
@time reset_limits!(ax)
f

Type of change
Delete options that do not apply:

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Checklist

[ ] Added an entry in NEWS.md (for new features and breaking changes)
[ ] Added or changed relevant sections in the documentation
[ ] Added unit tests for new algorithms, conversion methods, etc.
[ ] Added reference image tests for new plotting functions, recipes, visual options, etc.

Compile Times benchmark
Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:
using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))

using
create
display
create
display

GLMakie
–
–
–
–
–

master
–
–
–
–
–

evaluation
–
–
–
–
–

CairoMakie
10.55s (9.78, 11.72) 0.75+-
21.77s (20.06, 23.68) 1.37+-
3.27s (2.99, 3.65) 0.23+-
18.47ms (16.85, 19.99) 1.15+-
22.00ms (20.94, 24.10) 1.35+-

master
10.25s (9.90, 10.73) 0.34+-
21.13s (20.23, 22.13) 0.75+-
3.17s (3.02, 3.26) 0.09+-
17.98ms (17.09, 18.56) 0.53+-
21.16ms (20.78, 21.59) 0.30+-

evaluation
+2.84%, 0.3s invariant (0.51d, 0.37p, 0.55std)
+2.95%, 0.64s invariant (0.58d, 0.30p, 1.06std)
+3.07%, 0.1s invariant (0.57d, 0.32p, 0.16std)
+2.66%, 0.49ms invariant (0.55d, 0.33p, 0.84std)
+3.84%, 0.84ms invariant (0.86d, 0.15p, 0.82std)

WGLMakie
–
–
–
–
–

master
–
–
–
–
–

evaluation
–
–
–
–
–

I still think we should only update limits on display, before we add the workaround of disabling limit calculation to all kind of 3rd party libraries... This could be quite the easy change, no?

How does the Axis know it's being displayed?

Adding something like
update_state_before_display!(figlike) # or some better name

Here: https://github.com/JuliaPlots/Makie.jl/blob/master/src/display.jl#L62=
And overload that function appropriately for figure, scene, axis etc, so that it gets called for all axes in a figure.

I think compute on display is reasonable, display is already non-pure (I/O).
One problem I can think of is: do people use reflection (to read axis limits) before display in order to do something? I hope the answer is no

In that case they could always call reset_limits! themselves I guess?

Wouldn't update on display be an issue when plotting in the repl? I.e. starting with fig = Figure() in the REPL you'd display immediately and need another display or reset_limit! at the end to update limits.
Another option to throttle these kind of updates would be to generalize screen.render_tick from GLMakie to all backends and use it as a trigger. That would reduce things to one update per frame but it would require some bookkeeping to decide what needs to be updates.

Could we do it such that in the plot! call we check if any parent Scene of the Axis is currently displayed? If yes, we reset limits. If not, we don't (most programmatic cases).
And additionally the update_state_before_display! thing that Simon suggested.

I've changed the implementation to update_state_before_display! and reset if the Axis scene or any of its parents are open.
However, there's still the problem of all the functions that can save a scene. save, record, colorbuffer, VideoStream, are there more? Do all of them need a separate update_state_before_display! inserted?

Most of them should use backend_display / backend_show under the hood... I can take a look if you want

Problem is that that's already Scene, and we don't have the back link to Axis

Tests pass now, question is if all the places to call update_state_before_display! make sense.

Guess it would be good to check the docs before merging this ;)


eth module: eth_encode_tx()

Create function
int eth_encode_tx(const transaction_t *tx, uint8_t *result, size_t *result_size)
Params:

transaction_t tx - description of a transaction
uint8_t *result - buffer that will contain RLP encoded transaction. The buffer must be allocated by the user
size_t *result_size - size of the supplied buffer. On success, encoded transaction length will be set by the call.

Return value:

0 - success
-1 - error

closed in #50


Modify versioning script to use github token

Proposed changes
Add --token to cargo release to push back to gh.
Types of changes
What types of changes does your code introduce to thin-edge.io?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[x] I ran cargo fmt as mentioned in CODING_GUIDELINES
[x] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Hi, is there a configuration option somewhere to tell cargo release where to publish to? I had a look but I couldn't find any.
We would run it when a PR is closed.  Is it then causing another commit to bump the version?

Hi, is there a configuration option somewhere to tell cargo release where to publish to? I had a look but I couldn't find any.

publish is to release to crates.io, as we don't want to do it at the moment we are using --no-publish switch to disable it. There is no option to tell it where to publish, it's always crates.io.

We would run it when a PR is closed. Is it then causing another commit to bump the version?
This is exactly right. You can have a look at https://github.com/makr11st/workflow-test tags and commits how it would look like.

LGTM but I like to wait for itsyitsys opinion


[Samples] Byte-io sample fails on execution :ballerina-0.970.0-beta1-SNAPSHOT

Byte-io sample fails
openjdk version "1.8.0_162"
ubuntu 16.04
command
./ballerina run examples/byte-i-o/byte-i-o.bal
Iterating through directory content
./tmp/dst
./tmp/src
File Details, test.txt 2018-04-17T14:50:25Z
Folder deleted successfully
examples/byte-i-o/byte-i-o.bal
error: ballerina.runtime:CallFailedException, message: call failed
	at .:main(byte-i-o.bal:69)
caused by error, message: failed to open file: file not found: ./files/ballerina.jpg
	at ballerina.io:openFile(<native>)

You have to run the command inside byte-i-o/

Fixed instruction

verified running the sample from within the byte-io


Add Warnings for ValidationCE

It would be nice to be on par with Chessie, which also has warnings support, which are not necessarily errors.

I think we would want to encode that into a new DU type with Ok | Warn | Error but that might be outside the scope of this library since we're only dealing with the FSharp.Core Result type. I know Chessie does it with Ok of 'a * 'Msg list | Error of 'Msg list but I don't really like how that's done.

Would have thought Ok would contain ('value * 'warning list * 'info list) and Error just 'error list?

You can do that but I don't like it since you're not using the type system to your advantage.
I'd say come up with a version that works and submit a PR so we can discuss the implementation if you find that pattern useful.

The reasoning for not choosing a DU is that, warnings/info are not necessary a failure or should cause the system to fail, only errors would. i.e I would want to be able to get the Ok value, and simply log out or gather the warnings or infos and pipe it elsewhere? Whereas error would cause a fail?
type Validation<'successValue, 'err, 'warn>  =
	| Ok of 'successValue * 'warn list
    | Error of 'err

I think that having warnings etc. should be somehow outside of the library concern. Like, what if I also want Info or Critical etc?.
One can always come up with their own way of tagging en error and just use it:
type Severity<'a> =
    | Critical of 'a
    | Warning of 'a

let (xxx : Validation<MySuccess, Severity<MyError>>) = ....

Yeah since I haven't seen a PR for this and you could always build/layer your needs on top of this library I'm going to close this.


About the number of detect boxes

I would like to ask whether the focalnet-dino and vit-det detectors used in the paper only select the first 100 detection boxes？Thank you.

Hi, the COCOapi calculates precision and recall for a given number of maximum detections. The most common used maximum number for Average Precision (AP) is 100. We can also save some memory and computation by selecting the 100 highest-scoring boxes from 300 boxes.

When using the vitdet-h detector on the lvis dataset, only the first 100 boxes are used? Is this also true on the uvo dataset?

Hi, the COCOapi calculates precision and recall for a given number of maximum detections. The most common used maximum number for Average Precision (AP) is 100. We can also save some memory and computation by selecting the 100 highest-scoring boxes from 300 boxes.

Hi, the COCOapi calculates precision and recall for a given number of maximum detections. The most common used maximum number for Average Precision (AP) is 100. We can also save some memory and computation by selecting the 100 highest-scoring boxes from 300 boxes.

When using the vitdet-h detector on the lvis dataset, only the first 100 boxes are used? Is this also true on the uvo dataset?


Update tutorial-nsx-t-network-segment.md

Corrected VMware product names.

@rvandenbedem : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"


Suggestions for instruction clarifications for running in docker in Windows.

I just got this installed in Windows using Docker.
The instructions were a bit unclear since the instructions for installing the Nvidia stuff is Linux based. I mistakenly thought I needed to run the container and install all the Nvidia stuff in the container. . It might help other people like me who aren't so clever to know that those are Linux-specific instructions for installing the Nvidia drivers and adding instructions for installing the Nvidia drivers under Windows.
For Windows, you can install the Nvidia drivers (though I'm not sure which ones I installed that worked for this, because I've had them installed for a while. I have the basic drivers and CUDA. I'm guessing it's using the CUDA drivers.) and then run it with the GPU as per the instructions, it worked like a charm.
Also, just want to say, really nice work. I've tried installing a few of these local LLMs and this was by far the easiest for me to install (despite the above issues) and it works really well. I couldn't be happier.
I've been working on a game that uses LLMs and the cost of running with OpenAI was going to be higher than I'd like, so I've been waiting for a local version I could use instead and you guys have delivered. I'm really excited about this.

I'm inclined to close this one now that we have a native Windows version available that supports both Nvidia and AMD GPUs.  For most users, that's going to be a far better option than WSL2.  WSL2 still works and we'll continue to support it for folks who want to use it, but the simple flow is just run OllamaSetup.exe and as long as you've installed the Nvidia or AMD driver for your GPU, and have a supported GPU, it should just work.


400 Bad Request - using namedQuery with GET and

I have been attempting to use HotChocolate.PersistedQueries.FileSystem for GET requests, but I always get a 400 response when I make a GET request with the parameter ?namedQuery=foo
If I make a POST request with the following request body, I get the expected results.
{
    "namedQuery": "foo"
}

To Reproduce

Using latest stable HotChocolate 10.5.2 (main branch)
Open the Examples -> AspNetCore.StarWars project
Add a project to the solution and project reference to AspNetCore.StarWars:

<ProjectReference Include="..\..\src\Core\PersistedQueries.FileSystem\PersistedQueries.FileSystem.csproj" />

In the Startup.cs, change the GraphQL setup to use peristed queries:

            // Add GraphQL Services
            services.AddGraphQL(sp => SchemaBuilder.New()
                .AddServices(sp)

                // Adds the authorize directive and
                // enable the authorization middleware.
                .AddAuthorizeDirectiveType()

                .AddQueryType<QueryType>()
                .AddMutationType<MutationType>()
                .AddSubscriptionType<SubscriptionType>()
                .AddType<HumanType>()
                .AddType<DroidType>()
                .AddType<EpisodeType>()
                .Create(),
                b =>
                {
                    b.UsePersistedQueryPipeline();
                });

            services.AddReadOnlyFileSystemQueryStorage("./queries");

Add a folder+file '\queries\foo' at the root of the AspNetCore.StarWars project.
Put the following query in the foo file:

{
  hero {
    name
    appearsIn
  }
}

Run the AspNetCore.StarWars project.

Expected behavior
The response from both a POST request and a GET request for the same named query SHOULD return the same response, no?
Additional context
I was also seeing this in previous 10.4.x versions, but unsure how far back it goes.

This might be a documentation error. If you use id it should work just fine.
curl -X POST \
  https://localhost:44356/graphql \
  -H 'Content-Type: application/json' \
  -H 'cache-control: no-cache' \
  -d '{
    "id": "foo"
}'

Hi @michaelstaib,
No sorry, that doesn't work. That responds with a 404.
With namedQuery, it at least gets handled by the HttpGetMiddleware, but there's no provision for matching a parameter id that I can see:
        private const string _namedQueryIdentifier = "namedQuery";
        private const string _queryIdentifier = "query";

        protected override bool CanHandleRequest(HttpContext context)
        {
            return string.Equals(
                context.Request.Method,
                HttpMethods.Get,
                StringComparison.Ordinal) &&
                    HasQueryParameter(context);
        }

        private static bool HasQueryParameter(HttpContext context)
        {
#if ASPNETCLASSIC
            return context.Request.Query[_queryIdentifier] != null
                || context.Request.Query[_namedQueryIdentifier] != null;
#else
            return context.Request.Query[_queryIdentifier].Count != 0
                || context.Request.Query[_namedQueryIdentifier].Count != 0;
#endif
        }

I think the problem is further down the pipeline...

@michaelstaib although, the id parameter DOES work with a POST

So, the issue is with HTTP GET requests. I will issue a fix for this week.

@michaelstaib thanks.
I debugged a bit further through and it is this code in QueryRequestBuilder.cs that is throwing an exception because the querySource parameter is null:
        public IQueryRequestBuilder SetQuery(string querySource)
        {
            if (string.IsNullOrEmpty(querySource))
            {
                throw new ArgumentException(
                    AbstractionResources.QueryRequestBuilder_QueryIsNullOrEmpty,
                    nameof(querySource));
            }

            _query = new QuerySourceText(querySource);
            return this;
        }

This one is fixed.

[ ] we should create an explicit test that refers to this issue.

Added notes to the Slack channel for v10 -> v11 migration on why I think this still isn't working.

This is fixed now .... look at:
https://github.com/ChilliCream/hotchocolate/blob/aa8d21485e87aae0b3d59e61e418e83bffa9cb6f/src/HotChocolate/AspNetCore/src/AspNetCore/Serialization/DefaultHttpRequestParser.cs#L50

Thank you @michaelstaib, that has indeed fixed the issue that was blocking us from using v11

awesome :)


fix(cli): add task retry

Closes #19729
Describe your proposed changes here.

[ ] CHANGELOG.md updated with a link to the PR (not the Issue)
[ ] Well-formatted commit messages
[ ] Rebased/mergeable
[ ] Tests pass
[ ] http/swagger.yml updated (if modified Go structs or API)
[ ] Feature flagged (if modified API)
[ ] Documentation updated or issue created (provide link to issue/pr)
[ ] Signed CLA (if not already signed)

When is this intended to be utilized? retry is already cidban option under task run -> influx task run retry


"prov_data" object breaking render

Issue

Please provide us with the following information:

This issue is for the sample

    - [ ] 1-1) Sign-in with Azure AD
    - [ ] 1-2) Sign-in with Azure AD B2C
    - [ ] 2-1) Acquire a Token and call Microsoft Graph
    - [x] 3-1) Protect and call a web API on Azure AD
    - [ ] 3-2) Protect and call a web API on Azure AD B2C
    - [ ] 4-1) Deploy to Azure Storage and App Service
    - [ ] 4-2) Deploy to Azure Static App Service
    - [] 5-1) Call a web API using App Roles
    - [ ] 5-2) Call a web API using Security Groups
    - [ ] 6-1) Call Microsoft Graph using on-behalf-of flow
    - [ ] 6-3) Call a web API using Conditional Access Auth Context
    - [ ] 6-4) Sign-in with Hybrid SPA flow

This issue is for a

    - [x] bug report -> please search issues before submitting
    - [ ] question
    - [ ] feature request
    - [ ] documentation issue or request

Minimal steps to reproduce
Follow the sample instructions all the way to the end.

Any log messages given by the failure
Error raised in Chrome:
bundle.js:62221 Uncaught Error: Objects are not valid as a React child (found: object with keys {at, prov, altsecid}). If you meant to render a collection of children, use an array instead.
at throwOnInvalidObjectType (bundle.js:62221:13)
at createChild (bundle.js:62470:11)
at reconcileChildrenArray (bundle.js:62729:29)
at reconcileChildFibers (bundle.js:63141:20)
at reconcileChildren (bundle.js:66427:32)
at updateHostComponent (bundle.js:67151:7)
at beginWork (bundle.js:68789:18)
at HTMLUnknownElement.callCallback (bundle.js:51421:18)
at Object.invokeGuardedCallbackDev (bundle.js:51470:20)
at invokeGuardedCallback (bundle.js:51532:35)
throwOnInvalidObjectType @ bundle.js:62221
createChild @ bundle.js:62470
reconcileChildrenArray @ bundle.js:62729
reconcileChildFibers @ bundle.js:63141
reconcileChildren @ bundle.js:66427
updateHostComponent @ bundle.js:67151
beginWork @ bundle.js:68789
callCallback @ bundle.js:51421
invokeGuardedCallbackDev @ bundle.js:51470
invokeGuardedCallback @ bundle.js:51532
beginWork$1 @ bundle.js:74545
performUnitOfWork @ bundle.js:73678
workLoopSync @ bundle.js:73591
renderRootSync @ bundle.js:73560
recoverFromConcurrentError @ bundle.js:72968
performConcurrentWorkOnRoot @ bundle.js:72869
workLoop @ bundle.js:121117
flushWork @ bundle.js:121091
performWorkUntilDeadline @ bundle.js:121375
bundle.js:65964 The above error occurred in the  component:
at td
at tr
at tbody
at table
at div
at http://localhost:3000/static/js/bundle.js:46805:5
at div
at div
at IdTokenData (http://localhost:3000/static/js/bundle.js:804:98)
at div
at http://localhost:3000/static/js/bundle.js:43675:5
at AuthenticatedTemplate (http://localhost:3000/static/js/bundle.js:26553:5)
at Home (http://localhost:3000/static/js/bundle.js:2198:65)
at Routes (http://localhost:3000/static/js/bundle.js:114743:5)
at Pages
at PageLayout (http://localhost:3000/static/js/bundle.js:1464:26)
at MsalProvider (http://localhost:3000/static/js/bundle.js:26435:5)
at Router (http://localhost:3000/static/js/bundle.js:114676:15)
at BrowserRouter (http://localhost:3000/static/js/bundle.js:113485:5)
at App (http://localhost:3000/static/js/bundle.js:79:5)

Expected/desired behavior
Table with all the claims data

Library version

Browser and version

Chrome

Mention any other details that might be useful
File : @\1-call-api\SPA\src\components\DataDisplay.jsx
In the "IdTokenData" Component, in the tokenClaims array there is a an object that is different from all the other objects which is in array (= "arr") where arr[0] = 'prov_data' and arr[1] is an additional array which breaks the render at line 77.
My Temporary solution:
replace "tableRow" definition in lines 73-81 with this:
const tableRow = Object.keys(tokenClaims).map((key, index) => {
return (

{tokenClaims[key].map((claimItem) => {
if (typeof claimItem !== 'string') return '';
return {claimItem};
})}

);
});
(added type check for the claimItem).

Thanks! We'll be in touch soon.

Good catch; thanks for the feedback @theOtherYonatan will add this to the backlog.


deploy/operator_group.yaml: remove targetNamespaces

remove targetNamespaces in deploy/operator_group.yaml, as this is no longer supported in 0.8.0
fix #1106
What type of PR is this?
(Not sure if bug or documentation?)
/kind bug

/kind chore
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
fixes #1106
How to test changes / Special notes to the reviewer:

Thanks @johanneskastl. Can you fix the DCO check by signing the commit?

Thanks @johanneskastl. Can you fix the DCO check by signing the commit?

Done, both signed off and GPG-signed.


[WISH][UI Layers Browser] Add server UI layers

Currently, only Playground ManiaApp layers are visible in the UILayers Browser.
Could be nice to also have gamemode layers (CurrentPlayground -> Interface -> UIConfig -> [0] -> UILayers) and also the server controllers layers (iirc, there is an hidden function in openplanet for this) :grin:

could probably add game mode layers (but how to test?)
there are no server controller layers. There are only server controler pages, which don't have source code and other things. They are visible under scene explorer

but how to test?
You can try on the servers "Physics Controller", "LMS" or "F247"

there are no server controller layers
yeah, CGameNetwork::GetManialinkPages() returns only Pages and not scripts


Add authors list?

I'm not sure what the policy for this is. Angular 2 JS/TS doesn't seem to have this, at least I couldn't find it. Other Dart packages do. Flutter has an AUTHORS file, Angular Dart 1.0 has authors inside pubspec.

Closes as per #109


Version 1.0.8 is broken in ext_localconf.php

Hello!
You current version is broken.
When checking the include of jquery, you create an instance of \TYPO3\CMS\Core\Configuration\ExtensionConfiguration and then directly access the key "get['disableJquerySource']" of your class object.
You should use "get('indexed_search_autocomplete ', 'disableJquerySource')" instead.
TYPO3: 9.5.20

Hello,
thank you for reporting this issue!
It is fixed in the new version 1.0.9.


scale function for x, y axis.

D3 brush has a function to attach xscale, yscale function: brush.x().y(). I want to change Lasso's source code to support this function. However, I am not quit sure which line I should change. Is there any easy way to do that? I was trying to just change dragstart(),
d.lassoPoint = {
	cx: x(Math.round(new_box.left-offset_box.left + new_box.width/2)),
	cy: y(Math.round(new_box.top-offset_box.top + new_box.height/2)),
	edges: {top:0,right:0,bottom:0,left:0},
	close_edges: {left: 0, right: 0}
};

but it doesn't work.

Can you file this issue under v4 and provide an example where it would be beneficial to use a scale like this? Right now, the lasso calculates point locations based on their position in the DOM
https://github.com/skokenes/d3-lasso


Dependency vulnerability

The mime dependency has a RegEx Denial of Service vulnerability when I run npm audit and I was wondering if you guys had any plans of changing this.

url-loader 1.0.1 depends on mime ^2.0.3, which shouldn't be vulnerable according to broofa/node-mime#167. Are you on 1.0.1?

@hipstermojo please update you url-loader to latest versin


test: add missing option to e2e test

Description of changes

Issue #, if available

Description of how you validated changes
packages/amplify-e2e-tests/src/__tests__/apigw.test.ts failed before the change, passed after.
Checklist

[ ] PR description included
[x] Tests are changed or added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Let me test it on my end, I will get back to you


Handle mixed akka/pekko protocol names

Resolves: https://github.com/apache/incubator-pekko/issues/108
Currently in draft

There is also https://github.com/apache/incubator-pekko/blob/00c6bac1a70d2e0dc0408a4699d136d599855462/remote/src/main/scala/org/apache/pekko/remote/transport/PekkoProtocolTransport.scala#L76

incubator-pekko/remote/src/main/scala/org/apache/pekko/remote/transport/PekkoProtocolTransport.scala

Thanks pushed, lets see if it breaks anything

is the intention to add some akka protocol tests in this PR or maybe in a follow up PR?

The intention is to add the tests in the same PR, hence why its a draft.

@mdedetrich what would you think of merging this soon more or less as is but we document it as experimental. Then we can release v1.0.2 with this and see if we can crowdsource the testing. Alternatively, we add it to main only, for now and release v1.1.0-M1 and again see if we can get people to test with it.

@mdedetrich what would you think of merging this soon more or less as is but we document it as experimental. Then we can release v1.0.2 with this and see if we can crowdsource the testing. Alternatively, we add it to main only, for now and release v1.1.0-M1 and again see if we can get people to test with it.

Not really confident merging this as is because @He-Pin said that the issue is more complicated and we also need to do port roll-over to.

Ports are configurable already. For now, mixed cluster users can use Akka port numbers. They can even use Akka ports after the whole cluster is Pekko. We can add support for mixed port numbers later.

I think this PR is bettered targeted at main branch. We can backport it when we have something that we are confident in. We can merge experimental or partial impls to main.

I think this PR is bettered targeted at main branch. We can backport it when we have something that we are confident in. We can merge experimental or partial impls to main.

@He-Pin Brought up an interesting point in that this may only be needed in 1.0.x because there is a presumption that once you migrate from an Akka cluster to a Pekko one running 1.0.x, there is no reason that the feature would be needed in 1.1.x (even though we are technically "breaking users").
Given this and the fact that there is a community agreement that all migration (from Akka) related features should land in Pekko 1.0.x I think leaving this to target 1.0.x is the right decision.

I disagree about having this as a v1.0.x only feature. We've already had users who have tried to switch to Pekko from a version of Akka newer than v2.6. In the real world, we will have Akka users who reach the size where they need to pay license fees. If we add this feature, there is no reason not to keep it for a while. And if we then agree that it is useful to support this for a while (maybe 2 years as an example) then that makes it tidier to develop this on main branch - especially since we can release milestone versions.

I disagree about having this as a v1.0.x only feature. We've already had users who have tried to switch to Pekko from a version of Akka newer than v2.6. In the real world, we will have Akka users who reach the size where they need to pay license fees. If we add this feature, there is no reason not to keep it for a while. And if we then agree that it is useful to support this for a while (maybe 2 years as an example) then that makes it tidier to develop this on main branch - especially since we can release milestone versions.

I'm not disagreeing about it being in both versions, I am just saying that it has to land in 1.0.x as agreed upon and if it's going in 1.1.x as well then it makes sense for the feature to be complete and tested before the 1.1.0 full release otherwise we will have feature gaps

I want to see this in 1.1.0-M1. It makes it easier for people to try it out. M1 is also a release that we can caveat. A 1.0.3 release would be expected to have well tested, working code. This change still feels experimental but worth experimenting with nonetheless.

@mdedetrich noone seems to object to a 1.0.3-M1. Can we merge this? If we end up with an urgent 1.0.x bug fix issue, we could revert this again - but the likelihood is that the next 1.0.x release will be 1.0.3-M1. It would be nice to have these changes in a snapshot for some pre 1.0.3-M1 testing.

@mdedetrich noone seems to object to a 1.0.3-M1. Can we merge this? If we end up with an urgent 1.0.x bug fix issue, we could revert this again - but the likelihood is that the next 1.0.x release will be 1.0.3-M1. It would be nice to have these changes in a snapshot for some pre 1.0.3-M1 testing.

Sure, changed it to review status. It just needs a review.


Case intereferes with the link and activity lights on the PI

There is a capacitor on the bottom and the two LEDs on the top of a PI 4 Model B that interfere with it sitting properly in the case. The holder for the PI should be shifted closer to the wall with the USB breakout on it.
Focus the holding parts of the chassis around the screw terminals for better support.

Fixed by moving the mounting to only be where the screw holes are.

I also fixed an issue where the GPIO soldering was interfering with the mounting on the other side.


Discussing caveat: "Is starting at / and crawling sufficient?"

"Is starting at / and crawling sufficient? Might there be unreachable sections of your site?"

I think for most well-structured sites this should not be an issue since you can hopefully get to every page that ever existed by just clicking through the web of links...
However, for my use case, I want react-snapshot to render a static page that is not linked from anywhere. The page is a variation of one of my form pages, but it only contains the form, not the site layout (header, footer, etc.). (Unfortunately) I use this by embedding this page in another website in an iframe. This is why it doesn't need to be linked anywhere in the main site (it should not be crawled, but it does need to exist statically).
I know the premise of react-snapshot is to be zero-configuration so I'm not sure that my use case will be supported, but do you have any ideas how this might look?

Yeah I think that's common enough. I'm thinking that "zero configuration" should maybe mean "no configuration beyond command-line args". So you could do
react-snapshot / /form?with=params
Alternatively, we could look for something in package.json but... that feels unnecessary

For this configuration, are command line args a bit "ugly" in that usually react-snapshot is called inside a package.json script?
"build": "react-scripts build && react-snapshot / /form?with=params"

Which looks like your pushing knowledge of your routes upstream (i.e. out of src up into package.json).
Maybe there's smarter ways / tricks to avoid putting it straight in package.json - e.g. make a local bin/react-snapshot:
#!/bin/bash
react-snapshot / /form?with=params

And then the package.json script becomes:
"build": "react-scripts build && bin/react-snapshot"

Would you solve it like that, or does it not really bother you putting the cmd line args in package.json?

I don't mind it, but to be honest, a bit of config isn't maybe too bad:
/* package.json */
{
  ...,
  "react-snapshot": [
    "/",
    "/form?with=params"
  ]
}

That way at least each line is nicely tracked by version control...

Yeah that would be nicer, especially with, say, 10 paths.
Not that this affects me, but being hard-coded in package.json means that you can't have extra paths that are unknown at compile time (e.g. extra paths created from an array of products).
Not sure if that's something to consider.

Yeah but those should be found by crawling your product index file, right?

Yep it was a contrived example of a set of paths that might need to be generated at runtime based on other data - I don't actually have that case.

Maybe a more realistic example would be if you had paths like /module1/form, /module2/form, ..., /moduleN/form (say these are forms that you embed for a set of N teaching modules)
If N was unknown at compile time then you couldn't put these paths in package.json. Even if N was known, if it was equal to 100 or 1000, then you'd have a massive package.json that could be solved by the extra path config coming from a JS file using a loop.
Anyway, again, I don't need this for my use case so I don't want to overcomplicate the discussion - it just depends how flexible you'd like this configuration to be.

Sorry for dropping this for a while. I think in the case you describe, it probably makes more sense to make like a index page for all the URLs you can't otherwise reach, call it like __index.html or something. If you put a hidden link on your homepage, or point react-snapshot at it directly in package.json, the crawler will find it and cache all those routes.
I think that's better than having an executable config.


The search should not change the sorting

Description of new feature
Doing a search should not automatically change the sorting of the genes.
Motivation for new feature
It's confusing

We forgot to log this one


Any  winui 3 app does not work on windows 10

Fresh installed Windows 10, downloaded from  MS site.  All SDK dependencies installed. Net  6 installed.  Any winui 3 app just does not start, both packaged and unpackaged.  Any suggestion where start to search?

Have you installed the Runtime ?
Current releases

Have you installed the Runtime ? Current releases

Yes.

Have you installed the Runtime ? Current releases

Yes. Also .msix packages are self contained, no?

WindowsAppRuntimeInstall.exe, which must return 0 for each package

Have you installed the Runtime ? Current releases

Yes. Also .msix packages are self contained, no?

WindowsAppRuntimeInstall.exe, which must return 0 for each package

Yes everything is installed correctly. But leave apart unpackged apps. Why .msix bundles do not work?

@Petrarca181 would you be able to share a crash dump? Which app are you trying to run?

Have you installed the Runtime ? Current releases

Yes. Also .msix packages are self contained, no?

Self Contained is not working and will be available in WASDK v1.0.X

@Petrarca181 would you be able to share a crash dump? Which app are you trying to run?

My personal app i'm writing.  But also just create new blank app and pack, same result.
https://www.mediafire.com/file/ggharbzaj7zfkdu/dumps.zip/file

Little update: after some  test i noticed  that  apps created with Single Projeckt MSIX   does not work.  If I port me app to the old template  everything works fine.


Strange readings during large spikes

Hello!
Firstly; thank you for making this!
I just wanted to get your thoughts on something we've seen.  Under normal operation it feels like the value being output is spot on, however when we get large spikes, it no longer makes sense.
Take this example:

You can see we get a large ramp up of messages; during which time the exporter is saying the lag in seconds is 270k (75hrs) which as yo can see from the graph - just isn't possible.
Any ideas what's going wrong?

It may be worthwhile to reduce the lookup-table-size configuration if you experience these kinds of spikes regularly. That will give the lag-seconds calculation a "shorter memory" to draw upon, although that may result in the reporting of spikes more frequently.
I wonder what the median of the lag_seconds metric across a topic would look like with this dataset.

On second thought, decreasing the lookup-table-size won't help.  I'll have to do some experimentation with large increases like these to see if there's an elegant way to minimize their inaccuracy.
In the meantime, I'm curious if using a median across a topic's partitions would provide a more reasonable metric for you. In Prometheus you can calculate median using the quantile operator quantile(0.5, ...).

I've thought about this issue a little more.
The problem is that in situations when regular consuming throughput is a fraction of the potential throughput a consumer can accommodate then the prediction will not be accurate at all because it hasn't observed the consumer consuming at its highest throughput.
For example,

Normal consuming operation.  Consumer stays up-to-date by consuming 1000 1K records per second (~1MB/s)
Consumer fails. The backlog on partitions grows by 1000 records per second.
Every second the consumer is offline adds a second to the lag prediction, but the consumer is actually capable of consuming 100000 records per second.
After 100 seconds the lag is determined to be 100 seconds, but it actually takes the consumer only 1 to catch up.

Some ideas when consuming throughput is 0:

Capture the maximum throughput observed during the lifetime of Kafka Lag Exporter and use that in the prediction calc.
Allow the user to configure the maximum throughput directly.

Hello @seglo
any update on this issue?
Thanks

@hisabimbola Not yet. I'll need some time to work on it, but I've been fairly busy. If you, or anyone else is interested in working on it I would welcome a PR. Here are some modified starting requirements from what I mentioned earlier
When consuming time lag time lag increases by a "large amount":

Configure a threshold of when to use the max throughput. This could be a constant for some constant multiple of time lag, or just a constant value. When this threshold is exceeded do one of the following:

Capture the maximum throughput observed during the lifetime of Kafka Lag Exporter and use that in the prediction calc. If the exporter never observes an abnormal spike in records then it may never record a realistic max.
Allow the user to configure the maximum throughput directly as a constant.

We would like to know which progress you are facing related with this issue

Unfortunately, I don't have much time to work on what I proposed earlier in this thread. If it's something you're interested in submitting a PR for I can work with you (or anyone else) on that.


Cache seeddata

Instead of constantly going to disk to read .json files, ping an api over and over, or hit the same db repeatedly, the seedRepository should do one of the following:

load each seeddata into memory at startup, OR
once a seeddata file / options has been loaded, store it in memory.

Because seeddata should be static, there's no need to generate it each and every time.

how long should the cache persist for? there also should be a command to force a refresh of it


Allow updating attributes through Stack#add

You can now update the common attributes of a resource through Stack#add, as in:
stack = Humidifier::Stack.new
stack.add('SG', Humidifier::EC2::SecurityGroup.new, deletion_policy: 'Retain')

Fixes #45

Coverage remained the same at 100.0% when pulling 5dd421742524c3fcba0eea821c09c4331023ca37 on allow-updating-attributes into 39de4c56d02b6f5b580c748a9aab6056e57c76f0 on master.

:+1:


Document process for adding new localized strings

Scenario: You'd like to add a new diagnostic message in the CLI, and don't know where to start.
From existing pull requests, it looks like it's as simple as adding an entry in diagnosticMessages.json.

Is that is?
What part(s) of the build process interact with that?
What are the guidelines for doing so?
How do those strings become localized (are pull requests or features blocked on external localization teams, and if so how long is the ETA for localization)?

Add the message to https://github.com/Microsoft/TypeScript/blob/master/src/compiler/diagnosticMessages.json, run jake generate-diagnostics and use the name of the generated message, that is it.
We have a script that will send the new strings added nightly to our loc team, and they will merge in the new localized strings independently. the time depends on multiple factors, but usually within a week or two the string should be localized in all languages. but you do not need to worry about this, I can take care of that. If a message is not localized in a specific language, the text will show in English.


alt+click on directory should recursively collapse directories

VSCode Version: 1.8.0
OS Version: OSX 10.12.2

Steps to Reproduce:

Open several directories within a project
alt+click on parent does not collapse them all

I know this is a minor issue, but it is very difficult to navigate larger projects with all directories displaying as open.

This issue has already been reported. Please use the search function next time before reporting an issue and/or this time if you are curious about the progress of the issue.

Found it.  The title of the other issue seemed like it was just for expanding, but I see it's for both now.  Thanks!


Pause DSR approvals until error acknowledgment/resolution

As a support rep, I want to be prevented from approving new subject requests when a previous request as resulted in an error, so that I don't create a backlog of errored requests. I want to re-enable privacy request approvals after the source of an error has been fixed or removed, so that I can process a backlog of queued requests.
AC

When a DSR is in ERROR state, approvals are disabled for NEW request but one can REPROCESS as needed
Once DSR is in the COMPLETED state,  approvals are enabled for NEW request

New things to be finalized

What to do with auto-approvals? Do we need an additional notification criteria?

Language attempt 1 - Your privacy requests are paused. Please review your most recent privacy requests and connections. After addressing this, please reprocess the privacy requests.
@conceptualshark please help me!


[hotfix][table] Introduced UnresolvedFieldReference &  ResolvedFieldReference expressions

What is the purpose of the change
Splits FieldReferenceExpression into UnresolvedFieldReferenceExpression and FieldReferenceExpression. The latter should use indices of input and field within input as a reference rather than simply always looking up field by name.
Proper use of the FieldReferenceExpression is not part of this PR.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@KurtYoung @twalthr Could you have a look?

One minor comment: maybe rename the commit message because ResolvedFieldReference does not exist.

Thank you @dawidwys , LGTM, I created a JIRA to track blink aggregation Expressions refactor: https://issues.apache.org/jira/browse/FLINK-11983


Improve GitHub CI caching

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closing - will be included in the next release


added the discord link to the Readme.md

Added a link to join the discord community

Thanks for doing this!  Happy to help. Let me know if there's more to do. 😊


some question about haze Removal

Thanks for good work.but I have a question,why you do not use norm layer in  DuRN-US network in haze removal and use bacthnorm in rain steak removal?

Hi, thank you for your interest in our work.
The haze effects make the average intensity of an image higher, but I think they don't really degrade the image that hard. In other words, it is easier to recover an image to a good extent from the haze effects, than from other factors (e.g., motion-blur, rain-streak, raindrop, etc.).
For this reason, I think a CNN trained for haze removal doesn't really suffer from the internal covariate shift problem (batch norm paper link) that much, and thus no need to normalize the layers' outputs.

hello，How much is the batchsize chosen for RESIDE? I only have a 1080ti，I find it is not converge.

Hi, sorry for the late reply.
My batchsize is 48 for 4-GPUs(1080ti).
Setting batchsize = 10 for single 1080ti should be totally fine for training.


standardising and tracking reference data

Reference tracking
As with tracking taxonomic metadata, reference data sourcing and handling could also be more formalised and integrated.

Link to reference databases
match data references to database entries, obtain DOI?

This could be tricky with references data in spreadsheets requiring some developed fuzzy matching to db entries but could be a very effective way of both bolstering reproducibility, by providing direct links to the data sources, but also improve our ability to track duplication of datapoints through compendiums.

Useful package: https://cran.r-project.org/web/packages/RefManageR/RefManageR.pdf


[theme] "Preferences: Color Theme" command for workspace

Simply an additional command that works exaclty as Preferences: Color Theme but set the theme for just the current workspace.
Otherwise you have to do it from the workspace settings without preview, or use the preview and change the global theme to then set it manually for workspace and resetting the global one.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!