Build version failing if not using the latest version

Describe the bug
Build stage failing because we are running v1.7.1 with the following error
[Container] 2024/07/01 10:33:08.069367 Running command if [ "$ACCELERATOR_CHECK_VERSION" = "yes" ]; then
                if [ "$PACKAGE_VERSION" != "$ACCELERATOR_PIPELINE_VERSION" ]; then
                  echo "ERROR: Accelerator package version in Source does not match currently installed LZA version. Please ensure that the Installer stack has been updated prior to updating the Source code in CodePipeline."
                  exit 1
                fi
              fi

It seems to be that if we are not using the version specified in the following file that we can't get past this stage. https://github.com/awslabs/landing-zone-accelerator-on-aws/blob/13f3ebc58a162c90525ea81f69778f695e4c3cdb/source/package.json
To Reproduce
Run the pipeline while LZA is sat at version 1.7.1.
We have upgraded to 1.8.0 which fixes this issue but now hit another CDK error https://github.com/awslabs/landing-zone-accelerator-on-aws/issues/501
Expected behavior
Pipeline should progress through to the next stage.
Please complete the following information about the solution:

[x] Version: v.1.7.1
[x] Region: eu-west-2
[x] Was the solution modified from the version published on this repository? No
[x] Have you checked your service quotas for the services this solution uses? No service quota issues.
[x] Were there any errors in the CloudWatch Logs? Error posted above.

Screenshots
If applicable, add screenshots to help explain your problem (please DO NOT include sensitive information).
Additional context
Add any other context about the problem here.

Not the actual error. It's just a debug statement

@amitsmlaws as we have upgraded all of our LZA's I can't dig in to what the actual error will be now. I will close this and raise a new one if it happens the next time a new version comes out.


LICENSE file is missing on pypi

To help packaging, especially legal review, it would be nice to have the LICENSE file included in pypi distribution.

@tigerfoot Thanks the the issue, we added it in the revamp, should be up when we push the next release

Closing as the license is stated on Pypi and the new license.txt will be included in future releases.


Inserted values contain single quotes, ccjsqlparse was down.

version:
jsqlparse-1.4 or jsqlparse 3.2
sql like this:
insert into table (id, col_name) values (1, 'this's value');

version:
jsqlparse-1.4

This is an invalid SQL statement.
You will need to quote the inner single quote correctly or use concatenation and Chr();

This is an invalid SQL statement.
You will need to quote the inner single quote correctly or use concatenation and Chr();

sorry, there missing a backslash
sql like this:
insert into table (id, col_name) values (1, 'this's value');

ok thx, my usage is wrong


untrust https/TLS not be allowed

untrust https/TLS not be allowed

closing in favor of the PR https://github.com/taskrabbit/elasticsearch-dump/pull/118


Attribute functions have a bug

Line 688, 707, 729 and 755 of the main file have a bug where they are accessing the attribute values array rather than the names array. Meaning these functions don't work. Setting them to access attr[0] instead of 1, fixes this issue!

I haven't had time to verify this, but thank you very much for the report!

I haven't had time to verify this, but thank you very much for the report!


Run either verdict-bundle jar or verdict docker image

Allow the VERDICT plugin to run either a verdict-bundle jar or a
verdict docker image.  Being able to run a docker image is a big
improvement for configuration and portability.
Note if you are running OSATE and Docker on Windows, you must do two
things to allow the VERDICT plugin to communicate with Docker Desktop:

Go into General Settings in Docker Desktop, enable the checkbox
next to "Expose daemon on tcp://localhost:2375 without TLS", and click
the "Apply & Restart" button.

Set the environment variable DOCKER_HOST to tcp://localhost:2375 to
tell the VERDICT plugin to connect to the daemon using its TCP port
instead of its Unix file socket.

We have pushed the verdict docker image to Docker Hub using the name
"gehighassurance/verdict".  This is the same name you should enter
into the VERDICT plugin's preferences if you want to run the docker
image.  The VERDICT plugin will use a Docker Java API to pull the
image's latest tag from Docker Hub (only if the image isn't already in
your docker's local registry), start a Docker container to run the
desired verdict-bundle command, and display any output from it.  If
you remove the docker image name or don't enter anything for the
image's name, the VERDICT plugin will run the verdict-bundle jar
instead.  Currently you still need to fill out every field in the
VERDICT plugin's preferences even if you just want to run the docker
image, but we will make the verdict-bundle jar fields unnecessary
later once people have tested running the verdict docker image on
their machines.
Here are some specific code changes in this pull request:
Build the Docker verdict image differently since we no longer put
prebuilt aadl2iml, kind2, and soteria_pp binaries in source control.
Move the Dockerfile up two directories to let it send the aadl2iml and
soteria_pp source directories to the Docker daemon.  Modify the
Dockerfile to build these binaries using an ocaml/opam2 builder image.
Could also have built the verdict bundle jar in the Dockerfile too,
but there is no Maven cache in the Docker builder image so it's
quicker and easier to build the verdict bundle jar on developer
machines or a Travis CI build server first.
Add the new Docker Java API's dependencies to the VERDICT plugin's
classpath and MANIFEST.MF.  Make the plugin's pom copy only the jars
needed for docker-java-api dependencies into the lib directory and
remove the lib directory during Maven's clean phase.
Add a field editor to BundlePreferences to prompt for the docker image
name and save the value if any value is entered into the field.
Modify CRVHandler to call new VerdictBundleCommand class, pass
canonical output path instead of absolute output path, and catch
IOException.
Modify MBASHandler to call new VerdictBundleCommand class and catch
IOException.  Note we still pass GraphVizPath setting in case
VerdictBundleCommand has to call the verdict-bundle jar.
Add a new VerdictBundleCommand class that will run either the
verdict-bundle jar with the Ant Exec API or the verdict docker image
with the Docker Java API.  Give it a fluent API to configure all the
parameters needed to run the command.  Ensure the Ant Exec API sets
any environment variables that need to be defined when running the
verdict-bundle jar.  If given an output file, ensure Docker binds the
output file's parent directory when running the docker image since
Docker can bind only directories, not files.
Since we don't call VerdictHandlersUtils' run method anymore,
systematically eliminate all unneeded lines of code from
VerdictHandlerUtils by marking everything private so that Eclipse can
tell us whether it's used and then deleting it until everything unused
is gone.
Fix unused import warnings in Aadl2CsvTranslator.

Have rebased to include most recent changes on master branch and tested on both DeliveryDrone (CRV) and DeliveryDrone_BusBindings (MBAS) successfully.  Will merge pull request now and add more documentation to a README later.


feat: support for docker containerization

In this PR, we have added a Dockerfile that can be utilized to containerize the eva database, and several hugging face udfs to add functionality to the database. For example, the following models were registered as UDFs and tested: ehcalabres/wav2vec2-lg-xlsr-en-speech-emotion-recognition, jonatasgrosman/wav2vec2-large-xlsr-53-english, etc.

The models in the notebook look useful. Thanks for sharing.


Does not work with IE or Microsoft Edge

As the title itself explains the issue, PDF is not displayed with IE or Microsoft Edge; it just says "Loading, please wait" and nothing happens then.
Are there any workarounds to make it compatible with IE & Edge?

Tested this in IE11 and it doesn't load the PDF; however, if you set the document mode to 10 then it loads. I also tried setting it to 9 and 8 with no luck.

does not work on IE11


Correct broken link for Konrad Rosenberg

Konrad Rosenberg, Segmentation Team Member (scroll down)4. Hiring an in-house segmentation team

Thanks!


Updated geojson snippet

The previous snippet for geojson diagrams did not render at all. This fixes that.

Previously :red_circle:

Now :green_circle:

```geojson
{
  "type": "Polygon",
  "coordinates": [
      [
          [-90,30],
          [-90,35],
          [-90,35],
          [-85,35],
          [-85,30]
      ]
  ]
}
```

Output: :red_circle:
{
  "type": "Polygon",
  "coordinates": [
      [
          [-90,30],
          [-90,35],
          [-90,35],
          [-85,35],
          [-85,30]
      ]
  ]
}

```geojson
{
  "type": "FeatureCollection",
  "features": [
    {
      "type": "Feature",
      "id": 1,
      "properties": {
        "ID": 0
      },
      "geometry": {
        "type": "Polygon",
        "coordinates": [
          [
              [-90,35],
              [-90,30],
              [-85,30],
              [-85,35],
              [-90,35]
          ]
        ]
      }
    }
  ]
}
```

Output: :green_circle:
{
  "type": "FeatureCollection",
  "features": [
    {
      "type": "Feature",
      "id": 1,
      "properties": {
        "ID": 0
      },
      "geometry": {
        "type": "Polygon",
        "coordinates": [
          [
              [-90,35],
              [-90,30],
              [-85,30],
              [-85,35],
              [-90,35]
          ]
        ]
      }
    }
  ]
}

Why:
Closes [issue link]

What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Thanks @sugatoray! I'll get this triaged for review.


#[pyclass] with __call__ raises ValueError with inspect.signature

I implemented the PyNRICContainer struct in Rust with the following methods __iter__, __next__ and __call__. I have also annotated PyNRICContainer with the #[pyo3(text_signature=...)] macro with an appropriate text_signature. The __call__ method is not allowed to have a text_signature annotation but I annotated it with a #[pyo3(signature=...)] annotation. The error I got from passing the callable object into the function signature of the inspect module (i.e. inspect.signature(pycallableobj)) is a ValueError that reads ''callable <builtins.PyNRICContainer object> is not supported by signature'"
Here are the codes:
#[pyclass(name = "PyNRICContainer")]
#[derive(Debug)]
#[pyo3(text_signature = "(cls, value, values, config, field)")]
pub struct PyNRICContainer {
    #[pyo3(get, set)]
    boolean: bool,
}

#[pymethods]
impl PyNRICContainer {

    #[new]
    pub fn new() -> PyResult<PyNRICContainer> {
        Ok(PyNRICContainer { boolean: true })
    }

    pub fn __iter__(slf: PyRef<'_, Self>) -> PyRef<'_, Self> {
        slf
    }

    pub fn __next__(mut slf: PyRefMut<'_, Self>) -> IterNextOutput<PyRefMut<'_, Self>, &'static str> {
        if slf.boolean {
            slf.boolean = false;
            IterNextOutput::Yield(slf)
        } else {
            IterNextOutput::Return("No Longer Iterable.")
        }
    }

    #[pyo3(signature="(cls, value, values, config, field)")]
    pub fn __call__(value: &PyString, values: &PyDict, config: &PyAny, field: &PyAny) -> PyResult<PyNRIC> {
        let v: String = value.extract()?;
        PyNRIC::new(v)
    }

}

My question is, how to make callable objects compatible with the inspect.signature function? Or rather, is there a way to force the __call__ method implemented in rust to have a text_signature?

I took a brief look at this, and my conclusion is that __call__ for a native type like in PyO3 isn't currently supported by inspect.
The error comes from: https://github.com/python/cpython/blob/d01cf5072be5511595b6d0c35ace6c1b07716f8d/Lib/inspect.py#L2616
None of the options supported by that method seem applicable for the __call__ method. I think this probably needs upstream support.

Hi @davidhewitt, thank you for spending your time and looking at this issue.
Can I ask what do you mean by upstream? Do you mean pyo3 or is there a dependency to which I should raise an Issue to?
👍😂

"upstream" in this case would the Python interpreter itself, i.e. CPython at https://github.com/python/cpython


language code for showing everything

use case is if a targeting category is sensitive, we can see the ads even if they're in some weird langauge code

l3-3T

that's Tom's suggestion, not stealing credit :)


Does it support lrc lyrics?

Does it support these synced type of lyrics? Example: Example lrc lyrics

Yes. You need to parse these lines to LyricsLine.Default objects.
Input format doesn't actually matter. You only need to provide text, line start and line end timestamps.

But to have wave fade effect you need to provide syllable timestamps for each word


physics in demo scene: dropping objects makes them fall to the floor and vanish

it's surreal! try it out
(reproduced on Windows Mixed Reality headset, Dell Visor, running on Windows 10)

Ah yeah, need to add a collider to the terrain.

I reproduced this with my Rift and Vive, btw


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from  to before v4.19.198",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=a7a7b2848312cc4c3a42b6e42a8ab2e441857aba"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "a7a7b2848312cc4c3a42b6e42a8ab2e441857aba",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "atm: nicstar: Fix possible use-after-free in nicstar_cleanup()\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.19.198 by commit a7a7b2848312cc4c3a42b6e42a8ab2e441857aba. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1001397


Fix 298 - Metalink

@huard I have merge this PR to the branch fix-298-metalink. We can then work on that branch.


removing the authors file

Hey all,
Git does a much better job of tracking who the authors of OpenRC are than the authors file does, and legally I don't believe we are required to have an authors file.
I would like to remove this file in a release or two if there are no objections.

the license says "Copyright (c) 2007-2015, the OpenRC authors".  there is no legal entity named "the OpenRC authors", so the AUTHORS file lists the legal entities (i.e. people).
should be easy to autogenerate it from git history.

Why do we need to generate it at all though since this information can be retrieved by anyone who wants it from git history?


Message allocation fails

Running with the debugger shows that we receive Simulation Message pointers that are not stack aligned.

This was due to a double free of the SimuationMessage object when calling transmit.


is there anyway to load PBF tiles in an mbtiles archive offline?

I tried to load Mbtiles file into mapview but failed, nothing is dipsplayed on the map.
        mapView = (MapView) findViewById(map);
        // offline usage
        Timber.plant(new Timber.DebugTree());
        File file = new File(Environment.getExternalStorageDirectory() + "/osmdroid/MbTilesBacNinh.mbtiles");
        Timber.e("File exist? : " + file.exists());
        SimpleRegisterReceiver simpleReceiver = new SimpleRegisterReceiver(this);
        XYTileSource mbtilesRender = new XYTileSource(
                "mbtiles",
                0, 18,  // zoom min/max <- should be taken from metadata if available
                256, ".png", new String[]{});

        IArchiveFile[] files = {MBTilesFileArchive.getDatabaseFileArchive(file)};
        MapTileModuleProviderBase moduleProvider = new MapTileFileArchiveProvider(simpleReceiver, mbtilesRender, files);

        MapTileProviderArray mProvider = new MapTileProviderArray(mbtilesRender, null,
                new MapTileModuleProviderBase[]{moduleProvider}
        );
        mapView.setTileProvider(mProvider);
        mapView.setUseDataConnection(false);
        GeoPoint geoPoint = new GeoPoint(21.049034, 105.873479);
        IMapController mapViewController = mapView.getController();
        mapViewController.setZoom(15);
        mapViewController.setCenter(geoPoint);

Is there any problem with my code? Can anyone please give me an update example which give me the example of the newest version of osmdroid library?
If I use private XYTileSource FourUMapsTileSource = new XYTileSource("4uMaps", 0, 18, 256, ".png", new String[]{});, as below:
 mapView.setTileSource(FourUMapsTileSource);
mapView.setUseDataConnection(false);
geoPoint.setCoords(21.049034, 105.873479);
IMapController mapViewController = mapView.getController();
mapViewController.setZoom(15);
mapViewController.setCenter(geoPoint);

everything will be ok. However, I want to load mbtile without knowing the map's source. Is it possible?

@kingfisherphuoc
I have the same problem I can use an example file from http://geoodk.com/mbtiles_howto.html and then everything is ok but it doesn't work if I use other files eg. from https://www.mapbox.com/help/define-mbtiles/

The default tile provider should just load them.  I'll take a look at it
On Jun 8, 2017 7:20 AM, "Grzegorz Orczykowski"<EMAIL_ADDRESS>wrote:

@kingfisherphuoc https://github.com/kingfisherphuoc
I have the same problem I can use an example file from
http://geoodk.com/mbtiles_howto.html and then everything is ok but it
doesn't work if I use other files eg. from https://www.mapbox.com/help/
define-mbtiles/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/osmdroid/osmdroid/issues/610#issuecomment-307074822,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB4kGaKKAozqqhnsSyUFOzx_eZd1rEboks5sB9j_gaJpZM4Nqrjw
.

@spyhunter99 thanks it would be great. I'm looking forward to results of your investigation.

@grzesiek2010 so yes, the default tile provider chain should load them, assuming they are available and stored in at least one of the offline tile storage locations, the default is /sdcard/osmdroid but it may also be on an external sdcard. See the notes on the Configuration class and the wiki change log.
more over, mbtile does not support multiple tile sources per file, so esscentially osmdroid will load any and all tiles from all mbtile archives

I'm using 4umaps mbtiles for offline usage. Is there a way that I can load show 4umaps (instead of default map source) online?

@spyhunter99 I can confirm that everything is ok if I use this mbtiles file http://geoodk.com/mbtiles_howto.html the I can copy it to /sdcard/osmdroid as you said and it works (this file works with my code as well as I mentioned above). The problem is with some particular files like https://www.mapbox.com/help/define-mbtiles/ it doesn't work if I copy this file to /sdcard/osmdroid.
Have you tested my files?

just pulled down the dc-baltmore mbtiles set from https://openmaptiles.org/downloads/#country
looking at the database, i don't seen any issue why it wouldn't load, except for the fact that the table "tiles" is usually a real time. It's a "view" in this case. Not sure if thats the cause or not. I do this in the logs quite a bit which leads me to believe that this is the root cause

--- SkImageDecoder::Factory returned null

this may be related to #615

digging deeper, the android bitmap factory only seems to read the first 64 bytes of the image before given up. So i'm guessing that there's something funky with out the image is encoded or it's an android issue. I don't think there's too much i can do about this one.

@spyhunter99

Not sure if thats the cause or not. I do this in the logs quite a bit which leads me to believe that this is the root cause

--- SkImageDecoder::Factory returned null
I can confirm that I can see the same logs.
I've compared those files and those wrong files have pbf format in metadata table I can't see the same in the metadata table of that one which works well.

suggestion, capture one of the tiles from the the mbtiles database that does not work and save it as a separate file, then try to open it with photo editing towards. PBF format is probably not supported by the android image decoder. I believe PBF is the raw open street maps data, points and ways. It may be possible to hack something together with mapsforge to render that data to a image tile but it's probably a bit of work

@spyhunter99
If I use the correct file (http://geoodk.com/mbtiles_howto.html) I can export one tile to png file and see the result I'm also able to view the image directly in DB Browser:

if I do the same using pbf format it's not possible:

That confirms it then. Pbf outputs are not supported by android bitmap
factory because it is not a bitmap.  Pbf is more of a vector tile format
than an image.  Not to sure what else I can do
On Jun 19, 2017 1:25 PM, "Grzegorz Orczykowski"<EMAIL_ADDRESS>wrote:

@spyhunter99 https://github.com/spyhunter99
If I use the correct file (http://geoodk.com/mbtiles_howto.html) I can
export one tile to png file and see the result I'm also able to view the
image directly in DB Browser:
[image: dbbrowser1]
https://user-images.githubusercontent.com/3276264/27297362-d6768b60-5524-11e7-8f41-d616583bd0c0.png
if I do the same using pbf format it's not possible:
[image: dbbrowser2]
https://user-images.githubusercontent.com/3276264/27297365-d8440d6e-5524-11e7-9386-fdbdf2ab51c5.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/osmdroid/osmdroid/issues/610#issuecomment-309509071,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB4kGTK2LGtw0LkuGef9kd6ZqtF3IBD1ks5sFq8EgaJpZM4Nqrjw
.

going to close for now, . pbf support is not trivial.

@grzesiek2010 @kingfisherphuoc @spyhunter99 hi mate, has this problem been solved? I migrated from mapsforge-vtm maps and encountered the same problem. best wish.

Hi, @CodeK1988 nothing has changed here and vector (pbf) tiles are still not supported.

@grzesiek2010 Thanks for the reply bro.I have re-downloaded the map file. Yes, it is a bitmap map engine that does not support vector map data.

But I think it is still possible, but I don’t know how to deal with the logic of pbf decode. Mapbox supports both mbtiles files. But it's not open source and doesn't support full offline support.


Bugfix/fix cases formats

looks like your build errors are also more than just a failing test or two 👀

Looks good other than those two notes though


i3d+vggish results

Hello professor,
When I reproduced your ‘i3d+vggish’ model, I found that i can not achieve the same results compared with the original paper. I don't know if there is something wrong with my settings.
Thinks

Could you please show me some detailed results?

Thanks for rely.
i list my final results below, it was captured from the 17 epoch. By the way, i didn't change the configrations in anet_c3d_pdvc.yml and anet_i3dvgg_pdvc.yml in the training procedure.
Validation results of iter 165006: Bleu_1:0.14397184343673516 Bleu_2:0.07563979885710821 Bleu_3:0.03841529336432101 Bleu_4:0.018592074153146686 METEOR:0.07360392698576934 ROUGE_L:0.14248773409982254 CIDEr:0.2695501870140006 Recall:0.49363335351742516 Precision:0.5138465188800716 soda_c:0.05815482000571441 para_Bleu_1:0.4600347481728046 para_Bleu_2:0.2734444234216087 para_Bleu_3:0.16531830682605833 para_Bleu_4:0.10265513451045642 para_METEOR:0.14629477337476632 para_ROUGE_L:0.28967922834328586 para_CIDEr:0.17420500091591917
overall score of iter 165006: 0.13175874699148377

The results are normal since all scores you mentioned above are based on incomplete validation videos (5313 out of 5747). Around 434 videos got a METEOR of 0.
The METEOR on 5313 videos are 0.0736039 * 5747/5313 = 7.96


Resource group deletion takes time, but operations on deleted resource groups are permitted even after deletion

Resource group deletion takes time, but operations on deleted resource groups are permitted even after deletion. Step to reproduce:

Delete a Resource group with some entities in it.
Create another Resource group with same entities.

Create some entities in newly created resource group.
After some time Resource group vanishes.
Is this expected behaviour ? Is there a way to check if resource deletion is in progress with same name that we are trying to create again ?>

@vaibhavkulkar
Are you still facing the issue? If so, can you post replied to the following clarifications:

Did you create the second resource group (step 2) with the same name as the resource group deleted in step 1?
Can you elaborate what you mean by "Create another Resource group with same entities"?
How does the RG created in step 2 vanish? Did you delete that one as well?

Hello @vaibhavkulkar
Do you still need help on this? Let me know and I would be happy to help.
Note: As part of repository cleaning effort, this issue will be closed by Nov 11 if no response is received from submitter and/or not further action is required.


Can't understand Documentation

Trying to setup server on my parrot os
$ ./boringproxy-linux-x86_64 server -admin-domain penskoolskull.bpdemo.brng.pro
2021/07/25 07:25:29 Starting up
2021/07/25 07:25:35 penskoolskull.bpdemo.brng.pro: obtaining certificate: [penskoolskull.bpdemo.brng.pro] Obtain: [penskoolskull.bpdemo.brng.pro] solving challenges: penskoolskull.bpdemo.brng.pro: no solvers available for remaining challenges (configured=[tls-alpn-01] offered=[http-01 dns-01 tls-alpn-01] remaining=[http-01 dns-01]) (order=https://acme-v02.api.letsencrypt.org/acme/order/135505371/11990717921) (ca=https://acme-v02.api.letsencrypt.org/directory)
can anyone help to setupmy server !!

Hey @testatskool it looks like you're trying to run your own server, but using a domain you don't control. You'll need to understand how DNS works in order to use boringproxy effectively. If you want something simpler I'd recommend using ngrok or CloudFlare Tunnel.


Client fetches query although the server already prefetched it

I closely followed the setup as described here:
https://supabase-cache-helpers.vercel.app/postgrest/ssr/react-query
I have the following function in a lib dir:
export const getCompanyById = (client: TypedSupabaseClient, id: number) => {
  console.log(
    `getCompanyById called from ${typeof window === "undefined" ? "server" : "client"} for id: ${id}`
  );
  return client
    .from("companies")
    .select("id, name")
    .eq("id", id)
    .throwOnError()
    .single();
};

I do this in my page.tsx:
export default async function DashboardPage() {
  const supabase = createClient();
  const queryClient = new QueryClient();
  const { companyID } = await useUser(supabase);
  await prefetchQuery(queryClient, getCompanyById(supabase, companyID));
  return (
    <HydrationBoundary state={dehydrate(queryClient)}>
      <Suspense fallback={<DashboardSkeleton />}>
        <DashboardContent />
      </Suspense>
    </HydrationBoundary>
  );
}

and have this in my dashboard content view:
  const { data: company, isLoading: isLoadingCompany } = useQuery(
    getCompanyById(supabase, companyID)
  );

Even with this setup, I can see the client still calling for companies even though the server prefetched them. This is my provider:
"use client";

import { useState } from "react";
import {
  isServer,
  QueryClient,
  QueryClientProvider,
} from "@tanstack/react-query";
import { ReactQueryDevtools } from "@tanstack/react-query-devtools";
//TODO: https://tanstack.com/query/latest/docs/framework/react/guides/advanced-ssr#initial-setup

function makeQueryClient() {
  return new QueryClient({
    defaultOptions: {
      queries: {
        staleTime: 60 * 1000,
      },
    },
  });
}
let browserQueryClient: QueryClient | undefined = undefined;

function getQueryClient() {
  if (isServer) {
    return makeQueryClient();
  } else {
    if (!browserQueryClient) browserQueryClient = makeQueryClient();
    return browserQueryClient;
  }
}
export const ReactQueryClientProvider = ({
  children,
}: {
  children: React.ReactNode;
}) => {
  const queryClient = getQueryClient();
  return (
    <QueryClientProvider client={queryClient}>
      <ReactQueryDevtools initialIsOpen={false} />
      {children}
    </QueryClientProvider>
  );
};

Is there anything I am missing here?

Hey! Does the same happen with just react query?


[Template PHPStan compiler] Improved template error messages

There are several messages wich are not very user friendly. Let's start with "Access to an undefined property Latte\Runtime\FilterExecutor::$xxx." Not very helpful, right?
I suggest something like this (you can change text if you will of course)
Undefined filter xxx.
💡 Register it in parameters > latteFilters. See https://github.com/symplify/symplify/tree/main/packages/phpstan-latte-rules#configuration

Looks good. I've added few DX comments :+1:

There should be non-empty check on $tip, otherwise it's missleading class name.

What about ImprovedErrorMessage? :)

Before piling new PRs, we should resolve this one first.

Before piling new PRs, we should resolve this one first.

I know, I know... I just... kind of lost motivation because of phpstan rules applied on source code :)
For example here I need nullable string $tip, but it is not allowed
Also you didn't reply to my suggestions O:-)

Making strong contracts is hard, but it's worth for the future maintaince :)
I would simply reuse PHPStan API, as the errors are built there already.

Also smaller PRs are better for review and instant merge. There was too many various changes at once.
Let's close then for lack of motivation.


[Managed-Gitops] Add metrics.

This PR is to add few new metrics for Gitops-Service monitoring. Few metrics we need for adding new panels in RHTAP SLO dashboards are missing, hence updating MonitoringStack configurations as mentioned in this doc.
Jira Ticket
https://issues.redhat.com/browse/GITOPSRVCE-751

@jparsai does the list of forwarded labels already includes all the labels you need?
https://github.com/redhat-appstudio/infra-deployments/blob/main/components/monitoring/prometheus/base/monitoringstack/monitoringstack.yaml#L45

@jparsai does the list of forwarded labels already includes all the labels you need? https://github.com/redhat-appstudio/infra-deployments/blob/main/components/monitoring/prometheus/base/monitoringstack/monitoringstack.yaml#L45

Hello @yftacherzog, Yes, they all have prometheus lable and its value is openshift-monitoring/k8s, as expected according to this doc
Here is a screenshot for your reference. Do I need any more labels?

@jparsai does the list of forwarded labels already includes all the labels you need? https://github.com/redhat-appstudio/infra-deployments/blob/main/components/monitoring/prometheus/base/monitoringstack/monitoringstack.yaml#L45

Hello @yftacherzog, Yes, they all have prometheus lable and its value is openshift-monitoring/k8s, as expected according to this doc
Here is a screenshot for your reference. Do I need any more labels?

I meant, I suppose there's a set of labels that you're going to require for those metrics once they're forwarded. For them to be available for you in AppSRE Grafana alongside the metrics, they need to be on that list I mentioned.
Can you check to see if you have all the labels you need?

Yes @yftacherzog all labels I need from these metrics are already there.

/lgtm

/approve

/test appstudio-e2e-tests

/test appstudio-e2e-tests


Implement Adversarial Texture Attack on Object Trackers

Description
This pull request implements the Adversarial Texture attack on object trackers by Wiyatno and Xu, 2019 (https://arxiv.org/abs/1904.11042) in PyTorch compatible with ART's PyTorchGoturn object tracking estimator. This implementation supports segmentation masks of foreground objects to train adversarial textures that are robust against being partially covered by the tracked or other objects.

[ ] add tests
[ ] add notebook

Fixes #1326
Type of change
Please check all relevant options.

[ ] Improvement (non-breaking)
[ ] Bug fix (non-breaking)
[x] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Codecov Report

Merging #1353 (67555d3) into dev_1.9.0 (5254b27) will decrease coverage by 11.08%.
The diff coverage is 10.74%.

@@              Coverage Diff               @@
##           dev_1.9.0    #1353       +/-   ##
==============================================
- Coverage      90.76%   79.67%   -11.09%
==============================================
  Files            232      233        +1
  Lines          18842    19023      +181
  Branches        3081     3095       +14
==============================================
- Hits           17101    15156     -1945
- Misses           988     3187     +2199
+ Partials         753      680       -73

Impacted Files
Coverage Δ

...ion/adversarial_patch/adversarial_patch_pytorch.py
12.22% <0.00%> (-71.92%)
:arrow_down:

art/estimators/object_tracking/pytorch_goturn.py
0.00% <0.00%> (-85.19%)
:arrow_down:

...adversarial_texture/adversarial_texture_pytorch.py
15.38% <15.38%> (ø)

art/attacks/evasion/__init__.py
100.00% <100.00%> (ø)

art/estimators/object_tracking/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

art/estimators/object_tracking/object_tracker.py
0.00% <0.00%> (-100.00%)
:arrow_down:

art/attacks/evasion/carlini.py
6.71% <0.00%> (-88.30%)
:arrow_down:

...s/extraction/functionally_equivalent_extraction.py
14.19% <0.00%> (-78.40%)
:arrow_down:

art/attacks/evasion/decision_tree_attack.py
23.28% <0.00%> (-76.72%)
:arrow_down:

... and 24 more

Closing to change base branch to development_object_tracking_attack_dev and continuing in #1430.


Documentation on the switch expression is missing

This page is about the switch statement. Is it going to be expanded to include documentation about switch expression (https://docs.microsoft.com/en-us/dotnet/csharp/whats-new/csharp-8#more-patterns-in-more-places) or is it going to be a separate page?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77d9cc47-5caf-184a-0ad6-cb968850be7a
Version Independent ID: f058bf17-04e9-9e23-05c7-66c1864445ad
Content: C# switch statement
Content Source: docs/csharp/language-reference/keywords/switch.md
Product: dotnet-csharp
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

I would gather it would be a different page under that same parent. Considering they are different selection mechanisms and it discusses Switch Expression vs Switch Statement.
@BillWagner has a project tracking C# 8.0 updates. I'll add this issue to that project and let @BillWagner  take it on from here.
Thanks!

GitHub is acting weird. I can't set backlog as the milestone..

I set the milestone to November. I want to update all the reference pages between now and .NET Core 3.1.

It is end of December and no documentation on switch expression! Come on guys, you could better.

@KUTlime currently the switch expression is briefly explained at the "What's new in C# 8.0" page:
https://docs.microsoft.com/en-us/dotnet/csharp/whats-new/csharp-8#switch-expressions
What, if any, do you think is missing there?

@pkulikov You just said it - briefly.
What is missing:

example with use of ternary operator
example with use of when condition
example with pattern matching
discussion when to use it and why
runtime benefits if any

I know how to do it. I'm trying to say that this could be helpful for newcomers to C# 8.0. The switch expressions are more or less equal to the switch statements. The switch expression deserves their own page with more examples and a structure as the switch statement page.

@KUTlime thank you!
I wonder what made you put the example with use of ternary operator first? Why particularly this operator?

Officially, I chose from-the-most-simple-use scenario ordering.
Unofficially, last two hours, I was analysing a weir problem in VS when switch expression and ternary operator was used. This brought me to this page. The problem was caused by R# and solved by update to the R# latest version but for a brief moment, I was convinced that ternary operator can't be used together with switch expression simply because of the fact that I wasn't able to find any proof that I'm wrong or vice versa.

By the way, the following C# 8.0 pattern matching tutorial contains examples with the switch expression:
https://docs.microsoft.com/en-us/dotnet/csharp/tutorials/pattern-matching
In particular, it covers:

example with use of when condition
example with pattern matching

I'm starting to work on this, and it's exposing some flaws in the current organization of the language reference.  I'd like feedback on the following ordered set of thoughts:

The new information really doesn't belong on this page. The switch expression is different than the switch statement:

Most obviously, it is an expression, not a statement.
The syntax has many differences. => instead of : and break
The switch arms must be expressions (not statements, or blocks)

This article is already rather long. I'm concerned with making it much longer by adding the information on switch expressions.
The obvious location for a new article on switch expressions would be an Expressions section. But, there isn't one. All expressions are in the Operators section.

That leads me to this conclusion:
Is this the right time to rename the  "Operators" section "Expressions", and add the new article there?
I propose "Yes".
If so, which of the sub-sections should be named  expressions instead of  operators?
I propose renaming these:

Member access expressions
?: expression
await expression
default expression

Should there be others? Should some be dropped?
/cc @pkulikov for input.

@BillWagner I agree mostly with you and have had the similar thoughts about expressions.

Is this the right time to rename the "Operators" section "Expressions", and add the new article there?

Yes, however I suggest to rename the section to Operators and expressions (or Expressions and operators). What do you think?
As for renamings, I don't think ?: should be renamed, as it's widely known as "ternary operator", also "C# conditional operator" is more checked in Google than "C# conditional expression".
As for the member access, I think it should be "Member access operators and expressions", because invocation () is more an expression, but range .. is commonly referred as an operator.
With other two I agree and have some more, so:

await expression
default expression
stackalloc expression
nameof expression

What do you think?
As soon as we agree on renamings, I would like to submit the corresponding PR. There we can discuss the remaining minor details if any, and after it's merged, there are no blocks for the switch expression. Is that fine with you?

What do you think?

I like your additions @pkulikov

submit the corresponding PR. There we can discuss the remaining minor details if any, and after it's merged, there are no blocks for the switch expression. Is that fine with you?

Great plan. I agree. I'll start working on a draft, and then rebase once I've seen your PR.


Home page UI

These changes are not required since already merged through PRs of new UI-related tasks from GitHub & there are chances of creating conflicts in the code. Hence closing the PR.


📝 Overhaul Documentation

Summary
Overhauls documentation. Changes things to industry standards, improves existing documentation, adds tutorials, and adds example code. Closes #164
Motivation
Our userbase has limited knowledge about programming. In order for them to understand how the API works, it needs to be very well documented with explanations and examples. This has the added bonus of making it easier for anyone reading the source code to understand how the library works.
Todo

[X] Struct members are documented
[x] Chassis class example code
[x] PID example code
[x] Timer example code
[x] Util example code
[x] Pose example code
[x] driveCurve example code
[x] trackingWheel example code
[x] Tutorials Overhaul

Test Plan

[x] Code Compiles
[x] Doxygen renders example code properly
[x] Doxygen recognizes function parameters and classes
[x] Tutorials are rendered properly

Download the template for this pull request:

[!NOTE]
This is auto generated from Add Template to Pull Request

via manual download<EMAIL_ADDRESS>via PROS Integrated Terminal:

curl -o<EMAIL_ADDRESS>https://nightly.link/LemLib/LemLib/actions/artifacts/1475185864.zip;
pros c fetch<EMAIL_ADDRESS>pros c apply<EMAIL_ADDRESS>rm<EMAIL_ADDRESS>

LGTM


Questions about mel spectrogram feature extraction

On L36: https://github.com/MihawkHu/DCASE2020_task1/blob/master/task1a/10class/extr_feat_2020_nodelta_scaled.py#L36 why do you add 1.e-8 to the spectrogram features and then take the log of it?
Also from L39-L41 of that same file I see you also normalize the features between the min and max of the features. Is this necessary to do and what is the reason for doing this?
best,
Brian

Hi,
Thanks for your interest. We added 1.e-8 to the spectrogram features to avoid the possible clash when performing log operation over the zero value. We scaled and normalized each feature to between 0 and 1. You can refer to our report for the detail experimental results. https://arxiv.org/pdf/2007.08389.pdf. It's not necessary and it has better empirical results.

Thanks. On L34: (https://github.com/MihawkHu/DCASE2020_task1/blob/master/task1a/10class/extr_feat_2020_nodelta_scaled.py#L34)
you essentially extract the spectrogram features (2D array of frequency vs time bins). For most of the audio files the dimensions are: 128 (frequency bins) x 431 (time bins). The problem for me is that I am trying to store all of the features in a numpy array and it turns out that not all of the audio files have the same 2D dimensions, some of the files lead to different dimensions that are not 128 x 431.
Any suggestion on how to deal with that? My solution has been to take a mean and collapse the entire time dimension:
np.mean(librosa.feature.melspectrogram(stereo[:], sr=sr, n_fft=num_fft, hop_length=hop_length, n_mels=num_freq_bin, fmin=0.0, fmax=sr/2, htk=True, norm=None).T,axis=0)
But by doing that I don't think it is a spectrogram anymore. Those reduced features seem to be okay, but surely I must be losing something?

Hi, in our experiments we did not meet the problem you mentioned. The frequency bin is assigned by you so it should be equal to each other as 128. The time bin is corresponded to the total length of each audio clip. Cuz each audio clip is fixed to 1s in this data set, so it should be 431 for all if you use the same window length and hop length as us. Could you let me know which one you found has the different feature size?

Hi,
I resolved the different feature size issue, apparently one of my wav files did not download correctly. I do have several questions regarding training and feature extraction.

I see that for your testing data, you also compute the delta and delta-delta of the mel specgrogram for testing/validation only: https://github.com/MihawkHu/DCASE2020_task1/blob/f662825bf924677b0e4e38bc0b61985d8412b936/task1a/10class/resnet/train_resnet.py#L59

Do you train on these features as well or is it just for evaluation? Does evaluating/training with these additional channels make performance better? On L81 of the same file, you also say:
"# Due to the memory limitation, in the training stage we split the training data". I'm assuming I don't have to do those splits if I don't have memory limitations?

You say in your paper that the final input tensor size is 423 x 128 x 3. I'm assuming those 2 extra channels are the deltas and delta deltas in the previous question?

Right now, I am starting off simple with a 2 layer CNN architecture and 2 fully-connected layers. I am training on mel spectrograms of dim: 128 x 431 (10 million trainable parameters) with scaling between [0,1]. After about 20 epochs my training/test accuracy is completed stalled at 10% and I'm trying to debug whether my feature input of 128 x 431 is the problem and needs deltas/delta deltas, if I need to use your LR warm restart routine, or something else.

For your first questions, the evaluation data is only used for evaluation, never for training the model.
For your second question, you dont need to split the training data if you dont have the memory limitations on your machine.
For your third question, yes the two extra channels are the delta and delta-delta.
For your forth question, I'm not sure what's the problem with your training. It looks like the model does not get converged. You can double check the training settings, like optimizer, learning rate and input/output.

Thanks Hu for the reply. I was able to fix convergence, it looks OK now. From your experience does the delta and delta-delta features help with improved accuracy over jut 1 channel (128 x 431)?

In our experiments delta and delta-delta did bring some gains to model performance. But you can still use only 1 channel if you want to have smaller model input.

Hu,
I see that in your (https://github.com/MihawkHu/DCASE2020_task1/blob/f662825bf924677b0e4e38bc0b61985d8412b936/task1a/10class/extr_feat_2020_nodelta_scaled.py) file, it only extracts and output features for 1 channel: 128 x 431 spectrogram without the extra features, hence the name "no delta scaled".
I am running with these features and I only get 45% accuracy on the test set. I am assuming that the2 extra channels with the delta and delta-delta features are required to get the 70% average accuracy results for your baseline Resnet results in your paper, which would mean those 2 extra channels are extremely important.
If I understand correctly, are you getting the 2 extra channels using this routine?
https://github.com/MihawkHu/DCASE2020_task1/blob/f662825bf924677b0e4e38bc0b61985d8412b936/task1a/10class/resnet/DCASE_training_functions.py#L64
I'm a bit confused by that routine, it looks like it uses mixup data augmentation, but I want to get the 2 channels without any data augmentation, unless of course the mixup augmentation is the feature responsible for the good performance.

Hi,
To save the disk space we only extrated and dumped the logmel features without delta and delta-delta. The delta and delta-delta are computed on the fly during the training stage. You can refer to this line here, https://github.com/MihawkHu/DCASE2020_task1/blob/master/task1a/10class/fcnn/DCASE_training_functions.py#L98, where delta is computed. Yes this Generator class also carries out some data augmentation techniques that can be performned on the fly, including
mixup: https://github.com/MihawkHu/DCASE2020_task1/blob/master/task1a/10class/fcnn/DCASE_training_functions.py#L147
random cropping: https://github.com/MihawkHu/DCASE2020_task1/blob/master/task1a/10class/fcnn/DCASE_training_functions.py#L137
spec-augment: https://github.com/MihawkHu/DCASE2020_task1/blob/master/task1a/10class/fcnn/DCASE_training_functions.py#L130.

Hi,
Do you use mixup for all of your results? You had a bunch of columns in your paper referring to whether the data augmentation was used or not, but I didn't see a column for mixup so I wasn't sure which results included mixup or not.
-Brian

Hi,
In our conference paper https://arxiv.org/pdf/2011.01447.pdf and challenge technique report https://arxiv.org/pdf/2007.08389.pdf, Mixup is used for every experimental items in result tables. Particularly we set mixup as a default method, and according to our experimental experience, Mixup is very important for the model training.

I was re-reading your paper and if I understand correctly you're using the two-stage classifier for your results. I mistakenly though your results were for the 10-class classifier.
Can you explain how your 3-class classifier and 10-class classifier give you a final accuracy score? Do you train a 3-class (indoor, outdoor, transportation) model and also train a 10-class model independently and combine scores in some way? Or for each audio file you use both classifiers or something?

Hi,
Thanks for your interests in our paper. Particularly, we trained 10-class classifiers and 3-class classifiers independently. The codes are presented in https://github.com/MihawkHu/DCASE2020_task1/tree/master/task1a/10class, and https://github.com/MihawkHu/DCASE2020_task1/tree/master/task1a/3class. The training stages are very similar to each other. You can refer to our paper for details of how we performed the two-stage procedure. In our paper we also listed the detail results of single system and two-stage system.
In the given evalution scripts, https://github.com/MihawkHu/DCASE2020_task1/blob/master/task1a/eval_hybrid.py,  it's from our hybrid two-stage system. We have provieded each pretrained single model, you can refer to the tensorflow1 version models here, https://github.com/MihawkHu/DCASE2020_task1/tree/master/task1a/10class/pretrained_models for 10-class classifiers, and here https://github.com/MihawkHu/DCASE2020_task1/tree/master/task1a/3class/pretrained_models for 10-class classifiers.

Okay so if I understand correctly, for each test sample, you output prediction probabilities for the 10-class classifier and the 3-class classifier and then you multiply them in a certain way and then take the max probability to get the final prediction? I.e. getting the classification performance requires a bit of post-processing?
Lastly, your CNN networks are they pre-trained on systems or you train them from scratch?

Hi,
Your understandings are totally correct. I'm not sure I fully understand your second question. Our provieded pre-trained models are CNN models trained from the scratch, based on the methods we discussed in our paper.


accessible slick as tablist widget

the proposed changes here re-work the accessible slick carousel as an implementation of the aria tabpanel widget (note: this applies where dots: true in options).  specifically

.slick-dots assigned role=tablist
slick dot buttons (child elements of .slick-dots > li or, the elements listening for the click event) are assigned the following attributes concerning a11y:

role=tab
id=slick-slider-control[_.instanceUid][slickDotCounter] where slickDotCounter is the (zero-based) index of this slick dot (out of the total number of slick dots)
aria-controls=slick-slide[_.instanceUid][controlledSlideIndex] where controlledSlideIndex is the (zero-based) slide index of the slide it advances to (e.g., if single item slick, dot aria-controls corresponds 1-1 to slick slide indices; if multiple items, dot aria-controls corresponds to every first slide in each "segment" [segment here meaning a set of slick slides displayed at one time on advancing through the carousel])
aria-selected='true' || null depending on whether the slide / slide group it controls is active / has focus
aria-label="x of [total]" where x is (one-based) index of current slick dot, within the total set
tabindex=0 || -1 depending on whether this slick dot is currently selected / active

slick slide elements are assigned the following attributes that have to do with a11y:

role=tabpanel
id=slick-slide[_.instanceUid][_.instanceUid][slideIndex] where slideIndex is (zero-based) index of this slick slide within the set belonging to this slick instance
aria-describedby=slick-slide-control[_.instanceUid][controllingDotIndex] where controllingDotIndex is the (zero-based) index of the slick dot associated with this slick slide _if there is a slick dot associated with this slide (will not be the case in multiple items)

on advancing to a new slide (slide group, in multiple slide instances), "focusable" child elements of the new current slide are made focusable (tabindex=0) by tabbing once again (in inactive slides, these elements have tabindex=-1) [used to set focus to the new current slide, this is NO LONGER the case]
arrow key handler added to slick dots (where accessibility is true) so that, when one of the tabs has focus, user can traverse slick slides by hitting the right and left arrow keys

demo on jsfiddle // accessibility: true
http://jsfiddle.net/cielt/bjg4p066/36/
:arrow_up: note: for ease of checking this, the demo fiddle slides have content with a link in them, which should receive focus on tabbing once the slide has changed
any questions please let me know.  thanks!
notes
accessible js "widgets", focus management, relevant aria- attributes:

wai-aria spec for tab (and tabpanel)
on accessible widgets

accessible tabpanel examples:

accessible tabpanel
another accessible tabpanel

I was writing the same solution untill I saw this Pull Request
Nice fix! :)

thanks @sboerjan :)  please shout any thoughts / ideas you have -- would love to know what implementation details feel sound to other devs / users.

Nice work @cielt !! I was about to start writing a solution for the slick-dots and I found your PR. I hope this will be included very soon on the next version.

@marcoborsoi: great -- encouraged to know that you were thinking along these lines.  would love to hear any further suggestions that may occur to you as we figure out these design patterns.  cheers!

I was going through slick and planning to make a PR with many of the same edits.  Glad to see it's already being suggested!  Nice work here

thanks, @scottaohara!  please shout if any thoughts / suggestions :)

This is great. How can I toggle these accessible features on and off for specific sliders? Currently it affects all the sliders I initialise.
Thanks!

@Gofilord why would you want a slider to be inaccessible?

@Gofilord: :arrow_up: i was wondering that too ;) but, fair enough, since it is an option ... have you tried including accessibility: false in your slick settings when you create your slider?  this should free you of the behaviors introduced in this PR.  let me know if that doesn't work for you.

@scottaohara Sometimes this accessibility PR creates issues. For me - I had an auto sliding gallery at the top of the page. When I scrolled down and a new slide moved it, the whole page jumped up to where the slider is. I couldn't fix it, and it only happened with this upgraded accessibility slider; not with the standard one.
@cielt I have tried setting the accessibility to false, but it didn't help. However, I have found a solution:
I included both the standard slick and the accessible one. Then, in the accessible file, I changed the $.fn.slick to $.fn.accessibleSlick, so now I can apply the accessibility only to the sliders I want.
I know it's not very efficient because you have to include a library twice, but it fixes the jumping.

@Gofilord: i understand your issue now, and appreciate that one would not want all of these accessibility features 'on' across the board in this case.  i'm not sure that i have a good solution yet, but in case it helps i'll offer my rationale for having done things as i have, and try to explain what's going on:
re the page jumping to the auto sliding instance when its current slide changes: if accessibility === true, i set focus to the newly current slide after the update.  this is a convention that is part of the accessible "tablist" design pattern, wherein, on selecting a new "tab", focus is then set to its corresponding tabpanel.  thinking through the UX for a screenreader this focus is meant to guide a user to content, newly revealed as a result of a selection.
that said, if one has a carousel on autoplay, and configured to behave thus (accessibility: true) and is elsewhere on the page then the next time a slide advances it will then receive focus and the browser will move (jump) to that part of the page because as far as it knows, this is where the current element of interest is.  there are no scenarios i can think of, in which a user would want browser focus to be hijacked  (and, possibly, for the window to jump to that content, if he is no longer interacting with it) every time the carousel updates.
arguably, a carousel on autoplay is inherently not accessible -- since the user does not have full control over the interaction, and it is hard to communicate the continually updating content in a non-intrusive manner to screen reader users.  i revisited this article on the challenges of making carousels accessible and am struck by a number of requirements not yet covered in this work.  some of this accessibility (e.g., button size, slick dots coming ahead of slides in HTML) involves style and markup decisions that are best left to those implementing a specific instance in a given context but it would be good to provide a foundation in the plugin that enables as much accessibility as possible (thinking about how to handle this given the scope of work here ...).
in response to your question, specifically -- about how to fix the page jump issue -- i would refine my earlier note and ask, have you tried setting accessibility: false for every slick instance that has autoplay: true?  just now i tied marking up a scenario in which multiple slick instances live on a page, and if the autoplay ones are set to accessibility: false the page should not jump:
http://jsfiddle.net/cielt/4zr1osak/11/
change the setting, and you'll experience that jump issue you described.
this is an important caveat for this setting here and bears highlighting -- appreciate your calling attention to it.  trying to work out how far to go with this (e.g., should accessibility be overridden by default if autoplay is true?  should focusHandler be updated to respond differently for accessible slick?) but, in the mean time, i hope you have some clarity about your issue.
any questions / suggestions please let me know.  thanks!

@cielt Thanks for the elaborate explanation and all the help.
Setting accessibility: false actually does solve my problem, turns out I had a typo.

@Gofilord: excellent 👍

The issue I'm seeing in testing this PR and an issue I was working on a fix for as well, is that by setting tablist on _.$dots and tab on the li.button and not on the li itself, means that the role model is incorrect and the selected state is not indicated.
I took your PR and did the following to fix:

Instead of focusing on the slide, I add a tabindex: 0 to the slide container div allowing focus
removed aria-hidden: true/false from the _.$dots.li
changed the $(this).find('button').first().attr({ to tabindex:0
added CSS for focus states on buttons

Now, when you tab to the dots, the screenreader reads:

"tab control, 1 of 6 tab",  "2 of 6 tab, selected", "3 of 6 tab", etc.

as you focus on the dots individually.
Demo: https://jsfiddle.net/jasonday/b5bqk68j/32/

Hey All,
I am having problems with the accessibilty of the slider too.
Any new information about the changes done in this pull request and if and when they would be available in a release?
@cielt Slick has the option "pauseOnFocus". It works when focusing an element within a slide, but it doesn't when focusing the next / previous buttons. Do you know if that's intended like this?
Thanks
Jan

It'd be optimal if the slider was paused while focused on the next/previous buttons.  Otherwise the context of what the buttons control could change, if there were no adequate announcements of that change to the user.

Yo! Apologies that so long has passed without this being addressed. I'd like to see about getting at least some of these changes merged in.
Re: Slide Focus Scroll Jump
Would disabling the focus when autoplay is true work? Other possible alternatives I can think of are 1. disabling the focus when slider is off screen; or 2. hijack/prevent page scroll when focusing
I'm sympathetic to the "just set a11y to false" argument, but it seems a shame to disable all those a11y features over the scroll jumping dilemma.
Thanks!
@cielt @Gofilord

@cielt thanks for rebasing. What's your feeling on the focus jump issue?

@scottaohara you have any thoughts on the focus jump issue?

@leggomuhgreggo i liked your idea of disabling the autoplay if the slider was off screen.  I think this would be a good first step in solving the issue.
But I'd take it a step further.
As autoplay content can be quite annoying and could be considered a compliance failure pertaining to WCAG standards, for both keyboard users and users with cognitive issues, I would suggest a button to toggle autoplay is inserted as the first DOM element of the slider (or before the slider if that would create an issue with the functionality/layout of the slider) whenever autoplay is enabled by default.  This would at least give users a permanent option to disable/re-enable the autoplay so they could interact with the slider at their leisure.

Hi all,
many thanks for the work & input here(!)  Apologies for my delay in getting to much of this feedback.  In order, roughly, re what's new to me ...
@jasonday: the mechanics of selection and navigation are based on what i've read and understood to be conventions for this kind of UI component.  i have no doubt that there is room to improve on the tablist implementation here, and there may be behavioral adjustments, as you point out, that make it work better in context as a carousel.  will review your suggestions on the PR -- and thanks!
@janwidmer @scottaohara: re slick behavior where autoplay, pauseOnFocus and accessibility all are true, and arrows and dots (dots being a premise of this whole tablist setup), that's slightly tricky to me, figuring out how the prev / next arrows fit in with the tablist pattern.  tbh i don't know what works best for screen readers and autoplay with all of the above settings but agree that for keyboard-only users the pause on arrows behavior would be an improvement, so will see about implementing this.
@Gofilord @leggomuhgreggo: re the problematic jump, where an autoplay slick instance has accessibility set to true and is autoplaying outside of the viewport, as noted earlier, autoplay is at odds with a11y because it wrests control from a user, imposes potentially disruptive animation, etc..  The focus() here is intended mostly to assist screen reader users (who likely wouldn't perceive the visual jump -- they are being made aware of what the browser is calling out to them by aural means).  But agreed that this makes for disruptive UX for sighted users and the suggestion of disabling the focus() when a slick instance falls outside of the viewport makes sense to me.  Will add this here.
As suggested by @scottaohara even better to disable the autoplay where carousels are not on the page (for non-sighted and sighted users alike) but it does get tricky knowing when to re-activate for the screenreader (autoplay!).  Sounds like handling this would make for a solid future PR?
@leggomuhgreggo @scottaohara: i noted that the changes in master were merged in for a reason and didn't want to undo here, but your points are well taken.
As i understand it, TODOs include

[ ] check #2078
[ ] pause autoplay-ing slick where the focus is on an prev / next arrow and pauseOnFocus is true
[ ] in accessible autoplay-ing slick, only focus() when instance is in viewport

Thanks!

@scottaohara I definitely see the logic in having a button to add that autoplay control, but I'm apprehensive about additional elements because it adds complexity to the API (enable bool, etc.), and risks a more heavily opinionated structure to contend with. I actually like the idea, the more I think about it, but I think it'd need to be hidden except for screen readers by default and probably should be it's own PR, subsequent to this one.
To me, the simplest (and ideal for the short term) solution would be to simply disable the focus when autoplay: true.
The alternative of having a check to see if the slider is offscreen probably a little bit closer to satisfying all use cases, but I think it'd be hard to find an elegant way to do that, and I feel like "why add the additional complexity, when autoplay isn't exactly compliant in the first place."
@cielt Thanks for the bang up job regrouping on this!
We're fixin to release 1.7.0 soon. I'd love to get the tabbed widget enhancement in there. I think at a minimum it needs to have a "focus jump" solution and solid testing to make sure tabbing and focusing are working as expected. Definitely not out of the question :)
Thanks!

@cielt nice!
Here're some test cases using this branch. And here're the tests using the current master if there's any question of an issue being related to this PR.
I went through quickly and didn't notice anything, but it'd be awesome if someone with more a11y expertise could go through and make sure things are working as expected.
Thanks!

@leggomuhgreggo thanks for this! 👍 will have a close look myself as soon as i can (realistically, in a day or 2) and make sure it holds solidly through allthecases.  will also seek to get more feedback -- especially re the screenreader UX.  carousels are often decried for being at odds with accessible UX but the goal here is to remove barriers where we can, and layer on some semantic cues and predictability in behavior that will improve access for all users, especially those relying on assistive technologies.
i'm sure you're aware, but wanted to highlight some challenges here, stemming from:

lack of 100% agreement about the conventions of how role=tablist (tab, tabpanel) key controls should work and, by extension, a solid mapping of this behavior to the components of slick carousel.  the informing examples here, by my assessment, make sense and, in practice, afford a meaningful interaction with the widget as implemented (examples cited at the beginning of this thread);

inconsistency in how different screen readers mediate interaction with the role=tablist (tab, tabpanel) and aria, etc. attributes generally.

Both open questions bear further discussion but, in the absence of authoritative and complete precedents, here's what i'm thinking in my approach to this:

do the proposed updates add predictable keyboard driven behavior, improve navigation mechanics and access to the controls and content of the carousel for keyboard-only users?
=> to a great extent, all keyboard users can check and weigh in on this point by using our keyboards only and verifying that the carousel is entirely accessible in this way

do the proposed updates present to screen readers content substantively enhanced, according to a pattern recommended by the spec? do they help purposefully manage focus to convey interaction with the tabs-like interface, and improve the means of navigating and interacting with the carousel for screen readers?
=> the literature and basic screenreader testing is a good start, but i would love for more a11y specialists and experienced screen reader users to weigh in.

Will do some testing and let you know what i find out.  Thanks!

Dope! Really appreciate your helping lead these efforts @cielt. Pumped to hear how things go.
Thanks!

I'll jump in and do some testing across a few different devices &
screenreaders and report back. I believe I tested my original pull request
in NVDA/Firefox, Window Eyes/IE, and Voiceover/Safari (ipad). I don't have
JAWS currently, so it would be great if someone could help out there.
On Mon, Jun 19, 2017 at 4:14 PM, leggomuhgreggo<EMAIL_ADDRESS>wrote:

Dope! Really appreciate your helping lead these efforts @cielt
https://github.com/cielt. Pumped to hear how things go.
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kenwheeler/slick/pull/2119#issuecomment-309560651,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAtp67_AqWQ2Ydqsx7fsJx_EETlem9Ltks5sFta4gaJpZM4HZZwI
.

huzzah -- thanks @jasonday! 👏   will see if i can track down some help with JAWS.

Just checkin in. Squeaky wheel gets the oil, yada yada

Always has :oil:
Apologies, it's been a minute.  Only small updates as yet:

one UX discrepancy / snag is that, with the auto focus happening in accessibility: true, if the carousel is partially off screen, the auto focussing brings the current slide back into the viewport, potentially causing a jump for sighted users.  it's the same symptom we tried fixing for autoplay: true

from my (quite novice) testing with Voiceover + Safari, the aim of making content within the tabpanels (i.e., slick slides) reachable.  would love additional opinions, though.

in hopes of understanding semantic / access gains (or losses) from the tablist framing, i reached out to a couple of screen reader users but haven't heard back.  i will ping them again and see if i can track down some more, but not sure how soon i can get enough to go on.

All i got at the moment.  It may be some time so, for your planning purposes, getting answers soon seems optimistic.  But seems important to verify that these changes are actually on the right track for a11y.
Thanks for touching base!

@cielt I tested this in NVDA/Firefox, JAWS/IE as well as VoiceOver and personally I find it much more useable compared to the demo carousels on the main site.   Perhaps the single most important fix is the removal of aria-live from the container.  My experience with this carousel is it's gets too noisey and conflicts with parent containers with aria-live already present.
My recommendations (and anyone feel free to add):

Include default focus state for all actionable elements (outline, etc)
When focus auto-updates after "prev/next", it should be to the tab panel itself instead of the inner content (a bit confusing given focus moves to the inner link)

Great work!  Hopefully this will be merged.

@miconley: thanks a million for the feedback & SR testing assist!  The removal of aria-live was introduced in a separate PR [#2843] but agreed it should be deployed with discretion.
Couple of updates:

where accessibility: true, set focus to the newly current .slick-slide[role=tabpanel]
if prev / next arrow button has focus, will pause an autoplay-ing carousel with pauseOnFocus: true (this is independent of the accessibility option, but agree the behavior makes sense)
where accessibility: true, if prev / next arrow button has focus, the < > key controls are enabled

Please lmk if any questions / suggestions.  Thanks!

@cielt dude nice work! You think this is good for a merge?

@leggomuhgreggo: just wanted to add a brief update to the README.  Will gladly hear out concerns / suggestions from anyone who's got them, but here's the current final snapshot of what i'm proposing.  Thanks!

@cielt helll yeee. Did some testing. Looks good. Merged. Will get the release out soon. Thanks to everyone who helped with this enhancement!

Excellent, @leggomuhgreggo!  Echoing thanks to all here for your suggestions & help with this! 👏👏

So awesome to see this, great work @cielt 🍻

Thanks for the great work.. any idea, if those changes will land in a release prior to 2.0?

@janwidmer it will be in a release that's coming out in the next couple days

@janwidmer: Very good to know.  Thanks so much for putting the current build to the test with true a11y specialists -- and following up!  I can appreciate that aria- attributes should be used sparingly and intentionally and believe that contributors have made their best efforts to do this.  These attributes must have been included for a reason but it seems that they are almost competing with (or at least extra on top of) other attributes serving specifically to implement slick as tablist which was the original focus of this PR.
Would be very interested to hear what folks think.  i do not see any open PRs proposing feature:a11y updates at the moment but if this sounds like a solid way forward, would encourage creating one.
Thanks!

@cielt of course the contributors have made their best effort and that's really nice. The current state is already a massive improvement regarding a11y.
I would also be interested in other folks thoughts since the whole a11y topic is sometimes very subjective..


Warning when starting a node: warning_lightningd_sync: "Still loading latest blocks from bitcoind"

I'm trying to setup GleenLight by following the instructions here https://blockstream.github.io/greenlight/getting-started/schedule/, but I keep getting this warning when I am starting the node (using python script). It's there for more than a week already.
warning_lightningd_sync: "Still loading latest blocks from bitcoind."

Here's my node-start.py which results into an error:
from glclient import TlsConfig, Scheduler, Signer, clnpb

# Read seed from seed-secret.bin
with open('seed-secret.bin', 'rb') as f:
  seed = f.read()

# Read cert
with open('client.crt', 'r') as f:
  cert = f.read()

# Read key
with open('client-key.pem', 'r') as f:
  key = f.read()

# Creating a new `TlsConfig` object using your developer certificate
tls = TlsConfig().identity(cert, key)

signer = Signer(seed, network="bitcoin", tls=tls)
signer.run_in_thread()

# Read cert
with open('device-cert.crt', 'r') as f:
  cert = f.read()

# Read key
with open('device-key.pem', 'r') as f:
  key = f.read()

node_id = signer.node_id()
network = "bitcoin"
tls = TlsConfig().identity(cert, key)

scheduler = Scheduler(node_id, network, tls)
node = scheduler.node()

info = node.get_info()
peers = node.list_peers()

print(info)
print("peers:")
print(peers)

invoice = node.invoice(
    amount_msat=clnpb.AmountOrAny(any=True),
    label="label",
    description="description",
)

print("invoice:")
print(invoice)

Also, the process is hanging indefinitely at this line invoice = node.invoice(, not sure if that's intended

I'm currently working to reproduce the issue.

Are you using glclient from the main-branch or did you install from PyPI?
Are you sure you registered your node on bitcoin and not on testnet?

You can use the device-certificate for both the signer and the node.
Could you try again with the following script?
from glclient import TlsConfig, Scheduler, Signer, clnpb

# Read seed from seed-secret.bin
with open('seed-secret.bin', 'rb') as f:
  seed = f.read()

# Read cert
with open('device-cert.crt', 'r') as f:
  cert = f.read()

# Read key
with open('device-key.pem', 'r') as f:
  key = f.read()

# Creating a new `TlsConfig` object using your developer certificate
tls = TlsConfig().identity(cert, key)

signer = Signer(seed, network="bitcoin", tls=tls)
signer.run_in_thread()

node_id = signer.node_id()
network = "bitcoin"
tls = TlsConfig().identity(cert, key)

scheduler = Scheduler(node_id, network, tls)
node = scheduler.node()

info = node.get_info()
peers = node.list_peers()

print(info)
print("peers:")
print(peers)

invoice = node.invoice(
    amount_msat=clnpb.AmountOrAny(any=True),
    label="some-label",
    description="description",
)

print("invoice:")
print(invoice)

Thanks @ErikDeSmedt. That seems to fix the hanging issue

However its still showing this:
warning_lightningd_sync: "Still loading latest blocks from bitcoind."

Hi @ilearnio :wave:
The warning is normal and nothing to be concerned about. The nodes on Greenlight are started on demand, and, while we do start the nodes in the background to let them sync up with the blockchain, chances are that at the next time the user comes back there will almost always have been a new block, meaning the node is syncing again, and printing this warning. The warnign goes away after some minutes of running, and will reappear the next time the node is started.
As for the hanging issue, that is usually because you have issued a command requiring a signature (invoice signs the invocie with the node_id) and there is no signer currently connected. We are seeing a bit of flakiness in signer connections, which may also cause sporadic missing signers, but we are working on a fix for that too.


Fix instagram-auth sample

Misplaced promise syntax on cookieParser rather than getToken

good catch. Thanks @romanalexander !


Change process run_as attribute to user_context

As per https://github.com/ocsf/ocsf-schema/discussions/238 the goal of this PR is to disambiguate the use of the user context in the process object. Based on the feedback on that discussion the field name has been changed, made recommended, and the description updated.
Note that the user profile has not been updated as proposed, after looking at the description of the user profile there probably does not need to be any additional clarity around that being the session user rather than the user context of the process.

I thought that we are going to use the existing user attribute?

The user attribute in the user profile? That would restrict options and not solve the ambiguity. The user we're identifying in this case is a property of the observable rather than a characteristic of a class.

No, not the user in the profile -- my question is, why not use the process.user? Note, process.user and the user defined in the profile are two different user objects.

It was requested that it not be called user in the comments below the voting on the discussion:

In this case, the user is a member of the process object, which provides the context and the role. What's the benefit to create yet another User attribute.
IMO the existing name run_as (the user that the process runs as) is a better choice than user_context. If you want to have the user in the attribute name, then we should rename run_as and run_as_user.
Using the context word in an attribute name could be confusing -- there is a group called Context. The main user is in the Context group, and now we are adding a second context user?

I'm in agreement actually about just using user, that is clear to me that it's the user context under which the process is running. The run_as suggests impersonation (from the Windows world) which we don't want. @paveljos and @AWSSecEng you both had concerns about using user as the name. Do you think the ambiguity concern could be mitigated by an appropriate caption and description instead of creating a new object?

Actually, the run_as is impersonation and it is applicable only to Start Process activity events.

@rroupski as per our discussion today the field name in the process object has been updated to user


CharacterBody3D with base script template lags on collision

Godot version
4.0.2.stable (7a0977ce2)
System information
Windows 10, Intel Core i5-9600K, Radeon Pro 580X, Vulkan
Issue description
Everything starts lagging when the player collides with the platform for some reason after I use the base template script, even though it doesn't lag at all in other user demos I've tested. It only seems to lag when I add the script for some reason.
https://github.com/godotengine/godot/assets/106000036/36f3c484-6c3f-4176-9be9-7855475c7a35
The video, for some reason, also lags when the player isn't on the platform, (something must have been up with OBS) but it does lag as the video shows when the player is on the platform
Not sure if there's a simple step to fix this but I've been having this problem since I installed version 4 recently and couldn't find any solution on line, no matter how many keywords I add.
Steps to reproduce
Create a MeshInstance3D and assign a StaticBody and CollisionShape. Create a CharacterBody3D and assign a MeshInstance and CollisionShape. Give the CharacterBody a script, use the Basic Movement template, add camera, test scene.
Minimal reproduction project
scene.zip

I found out that the problem was the CollisionShape. Just for future reference, if this happens to anyone else, remember to choose CapsuleShape for the CollisionShape instead of making it from the mesh. This seems to cause an issue and make everything lag when colliding with other objects.

@brickedware making the shape from the mesh makes it too complex - this is a known already reported issue. Unless you really really need to make it from the mesh, using built-in shapes is in general a good rule of thumb (is this documented prominently enough in the physics docs pages though?)


Billig form updates [ITK approved]

Approved 28.02.19 by email from ITK. No need to contact swedbank regarding the changes, as they were mostly visual.


didChangeAppLifecycleState loop

🐛 Bug Report
didChangeAppLifecycleState goes into a loop after location request. Only on some devices, but definitely reproduced on any xiaomi redmi note 9
It can be avoided by forceAndroidLocationManager: true
Configuration
Version: 7.4.0
Platform:

[ ] :iphone: iOS
[x] :robot: Android

Please check https://github.com/Baseflow/flutter-geolocator/issues/717#issuecomment-822654900, same behavior here with activity result cycle

same issue for me on Xiaomi device

Thanks to @hoanglm4 this issue should now be fixed. I will close the issue but feel free to leave a comment when you run into the issue again.

this issue is exactly what happened to me. This issue also happen on Xiaomi Redmi 9T #1056


feat: expose FileRegistry

#127

Since this was not the intended use case, I just changed it to be exposed in the internal __volar__ property.
On the other hand, Vue Langauge Tools 2.0 will be migrated to the TS plugin, and ts-type-explorer seems to be based on the TS plugin as well, so it may not need access to Volar's internal API to support this. You might consider using the extension install package from https://github.com/vuejs/language-tools/discussions/3789 or the repo master branch to try this out.


how to enable authetnication in skype for business  channel

the exiting authentication OAuthPrompt is not showing card in skype for business. so please guid me how to enable implement authentication in skype for business

The Microsoft Bot Framework team prefers that how to questions be submitted on Stack Overflow. The official Bot Framework Github repo is the preferred platform for information on submitting on submitting bug fixes and feature requests.


[Bug] Crops doesnt seem to give money or anything

I have just updated to the new Jobs 4.9.0, and it seems that crops wont work. It wont even display on the job information. Players wont get anything from breaking crops.
CROPS-7:
  income: 1.5
  points: 1.5
  experience: 3.0

Server Type (Spigot/Paperspigot/etc): Paper
Server Version (using /ver): git-Paper-368 (MC: 1.13.1)

Meg kell változtatni a CROPS-t a WHEAT anyaghoz.

Ohhh,, I'm idiot... sorry..


Remove per process restart keys

Fixes https://github.com/remind101/empire/issues/861
We only added the per process restart keys with the idea of supporting emp restart <process>, but this creates too many parameters for some applications that have a lot of processes.

👍