Libdoc markdown

Would be great if the libdoc tool could also generate markdown format so that library documentation is easy to put up on GitHub, thanks

This would be very hard to implement as it basically would require implementing HTML to Markdown converter or would only work if you write library docs using Markdown too. In that case it would probably be better to implement a separate tool instead of enhancing Libdoc. Personally I fail to see the benefits of Markdown output because you can so easily host HTML files on GitHub (via GitHub pages) and elsewhere. Do you @claytonneal have some more use cases for this functionality? Would you be interested to implement this yourself if the idea itself is accepted?
Notice that Markdown as an input format for Libdoc wouldn't be too complicated to implement. It would also have a clear use case to allow writing library docs using Markdown.

Ok read a bit about GitHub pages, seems nice! Will give it a go!

Libdoc producing Markdown is not going to happen.


FEATURE: Tensorboard Scalars: Simple Way of Setting y axis to start at 0

I have a number of scalars that I plot in tensorboard that are non negative values (ie accuracy, etc). It would be cool if there was a quick way to have the y axis start at 0 rather than allocating unused space in the negative y direction.

If there anyone working on this issue? If there is no one, can I try this one?

I'm migrating this to https://github.com/tensorflow/tensorboard/issues/77. @chris-chris you're welcome to contribute on this. If you're still interested, let's discuss on the new issue at tensorboard/77.


CloudTrail Trails logging for ALL AWS Regions

Hi,
I have created a CloudTrail trail in EU-Frankfurt (eu-central-1) which logs to a CloudWatch Logs LogGroup in the same AWS Region, ALL the activities from ALL AWS Regions. This is possible as stated from the official AWS Documentation.
From the AWS_CIS_Foundations_Benchmark PDF (https://d0.awsstatic.com/whitepapers/compliance/AWS_CIS_Foundations_Benchmark.pdf), page 88, it is stated that we need to have Metrics, Alarms, and SNS Endpoints configured to that specific LogGroup in order to be compliant. It does not specify any AWS Region where to have this, or that we are commited to have it in every region of the AWS Account.
After a quick review from the code of the Prowler script, I found it to search for metrics of a CloudWatch Logs Group in a specific region:
METRICFILTER_SET=$($AWSCLI logs describe-metric-filters --log-group-name $CLOUDWATCH_GROUP $PROFILE_OPT --region $REGION --query 'metricFilters' | grep AccessDenied)
This is a problem since the CloudTrail trail is seen from any AWS Region. It is propagated even if you create it in a single AWS Region. However, the same is not true for CloudWatch Logs, Metrics, and Alarms, since they are tied to a single AWS Region.
I am running the script to audit the entire AWS Account, and I would not like to specify an AWS Region when running the Prowler script (-r option).
I think it would be better to specify the CloudTrail's CloudWatch Logs LogGroup AWS Region in advance before launching the Prowler script so we do not get the following errors:
WARNING! CloudWatch group found but no metric filters or alarms associated
I have already configured all the Metrics, Alarms, and SNS Endpoints to monitor all the activities from ALL the AWS Regions, and I am still getting the above errors.
Can you help me with this please?
Cheers,
Gabriel

Hi @GaboP87, well spotted and thanks for your research on it. What I can do is to search in all regions if specific metric filters and alarms have been set and if found, not show any warning message. What do you think?

Hi @toniblyx, I think it would be nice to:

First: check for the existence of the CloudTrail trail from any AWS Region (it is already done since it would be visible from any AWS Region if you set the trail to log API Calls for the entire AWS Account)

Second: scan ALL the AWS Regions to check for the existence of the CloudWatch Log Group, the necessary Metrics, Alarms, and SNS Endpoints. If none of them are found in any AWS Region, send the correspondent FAILED (WARNING!) message:
WARNING! CloudWatch group found but no metric filters or alarms associated in any region
Otherwise, log the check as PASSED (OK!), and maybe specify in which AWS Region they are found:
OK! the metric and its associated alarm were found in the eu-central-1 region

Let me know if you understood what I ment with this.
Cheers,
Gabriel

👍

If you look at the definition of a trail then it has a region in the field
eg
arn:aws:logs:REGION:ACCOUNT:log-group:TRAILNAME:*

You should probably parse the region from the output and not just the trail name, and then use that as part of the following calls, so you direct it to the right region

Hi @GaboP87 @pchaganti @sweharris thanks for your comments. I think have fixed and tested the issue. Can you give it a look please? If something else is wrong please feel free to reopen the case.
Sorry to address this late :)

So looking at check31 I can see some issues.  These issues probably apply the other sections as well.
If there is more than one trail defined then the  CLOUDWATCH_GROUP=$($AWSCLI cloudtrail describe-trails $PROFILE_OPT --region $REGION --query 'trailList[*].CloudWatchLogsLogGroupArn' --output text | awk -F: '{ print $7 }') command may only show the first entry
eg
% $AWSCLI cloudtrail describe-trails $PROFILE_OPT --region $REGION --query 'trailList[*].CloudWatchLogsLogGroupArn' --output text | awk -F: '{print $7}'
infra/cloudtrail-111111111111-us-west-2

% $AWSCLI cloudtrail describe-trails $PROFILE_OPT --region $REGION --query 'trailList[*].CloudWatchLogsLogGroupArn'
[
    "arn:aws:logs:us-west-2:111111111111:log-group:infra/cloudtrail-111111111111-us-west-2:*",
    "arn:aws:logs:us-west-2:111111111111:log-group:CloudTrail/DefaultLogGroup:*"
]

For some reason the output is all on one line, with a TAB separator, rather than multiple line...
% $AWSCLI cloudtrail describe-trails $PROFILE_OPT --region $REGION --query 'trailList[*].CloudWatchLogsLogGroupArn' --output text
arn:aws:logs:us-west-2:111111111111:log-group:infra/cloudtrail-111111111111-us-west-2:* arn:aws:logs:us-west-2:111111111111:log-group:CloudTrail/DefaultLogGroup:*

You may need to tr '\011' '\012' before the awk to make it return both values.
eg
% $AWSCLI cloudtrail describe-trails $PROFILE_OPT --region $REGION --query 'trailList[*].CloudWatchLogsLogGroupArn' --output text | tr '\011' '\012' | awk -F: '{print $7}'
infra/cloudtrail-111111111111-us-west-2
CloudTrail/DefaultLogGroup

I wonder if this is a change in the aws CLI tool or maybe this has been an error all along.  Dunno!  I'm using
% pip list | grep awscli
awscli (1.11.189)

CLOUDWATCH_LOGGROUP_REGION is being set correctly.  Good.
METRICFILTER_SET is set wrong
$AWSCLI logs describe-metric-filters --log-group-name $group $PROFILE_OPT --region $CLOUDWATCH_LOGGROUP_REGION --query 'metricFilters' | awk '/UnauthorizedOperation/ || /AccessDenied/ {print $1" "$2}'
"filterPattern": "{

That's because the output line looks like
        "filterPattern": "{ ($.errorCode = \"*UnauthorizedOperation\") || ($.errorCode = \"AccessDenied*\") }",

The whole JSON for that section looks like
    {
        "filterName": "111111111111_unauthorized_api_calls_metric",
        "metricTransformations": [
            {
                "metricValue": "1",
                "metricNamespace": "CISBenchmark",
                "metricName": "111111111111_unauthorized_api_calls_metric"
            }
        ],
        "creationTime":<PHONE_NUMBER>831,
        "filterPattern": "{ ($.errorCode = \"*UnauthorizedOperation\") || ($.errorCode = \"AccessDenied*\") }",
        "logGroupName": "infra/cloudtrail-111111111111-us-west-2"
    },

Because this variable is set wrong, we then fail the HAS_ALARM_ASSOCIATED
If I manually set it right then the thing doesn't look right at all...
HAS_ALARM_ASSOCIATED=$($AWSCLI cloudwatch describe-alarms $PROFILE_OPT --region $CLOUDWATCH_LOGGROUP_REGION --query 'MetricAlarms[].MetricName' --output text | awk 'BEGIN {IGNORECASE=1}; /UnauthorizedOperation/ || /AccessDenied/;')

Wouldn't match the awk statement because you're checking on MetricName and so should be looking for the<PHONE_NUMBER>11_unauthorized_api_calls_metric value.  Alarms don't have details like "accessdenied" in them.   This specific alarm looks like
        {
            "EvaluationPeriods": 1,
            "AlarmArn": "arn:aws:cloudwatch:us-west-2:111111111111:alarm:111111111111_unauthorized_api_calls_alarm",
            "StateUpdatedTimestamp": "2017-11-20T18:34:12.602Z",
            "AlarmConfigurationUpdatedTimestamp": "2017-11-14T20:26:21.698Z",
            "ComparisonOperator": "GreaterThanOrEqualToThreshold",
            "AlarmActions": [
                "arn:aws:sns:us-west-2:111111111111:alarm-ops"
            ],
            "Namespace": "CISBenchmark",
            "StateReasonData": "{\"version\":\"1.0\",\"queryDate\":\"2017-11-20T18:34:12.596+0000\",\"statistic\":\"Sum\",\"period\":300,\"recentDatapoints\":[],\"threshold\":1.0}",
            "Period": 300,
            "StateValue": "INSUFFICIENT_DATA",
            "Threshold": 1.0,
            "AlarmName": "111111111111_unauthorized_api_calls_alarm",
            "Dimensions": [],
            "Statistic": "Sum",
            "StateReason": "Insufficient Data: 1 datapoint was unknown.",
            "InsufficientDataActions": [],
            "OKActions": [],
            "ActionsEnabled": true,
            "MetricName": "111111111111_unauthorized_api_calls_metric"
        },

Hi @sweharris, I'm working on it and I have fixed the first part with tr '\011' '\012' I missed that part on my tests, thanks! I haven't PR that change yet. I'll do it in a moment.

Ok @sweharris I get the second part of your comment about METRICFILTER_SET and HAS_ALARM_ASSOCIATED, what do you think is the best way to check it? I think also the way it is checking currently is a bit inconsistent since depends on how you name your alarms. I'd like to add a generic name or filter though. Section 3 is probably the less helpful for me since there are other tools that can handle alarms or alerts in case of API or configuration changes but still useful for a proper security assessment. Thanks.

For METRICFILTER you might be able to do something like
METRICFILTER_SET=$($AWSCLI logs describe-metric-filters --log-group-name $group $PROFILE_OPT --region $CLOUDWATCH_LOGGROUP_REGION --output text | awk '/UnauthorizedOperation/ || /AccessDenied/ {print $3}')

That assumes the "--output text" format doesn't change.  Currently it appears to look like
METRICFILTERS<PHONE_NUMBER>831<PHONE_NUMBER>11_unauthorized_api_calls_metric      { ($.errorCode = "*UnauthorizedOperation") || ($.errorCode = "AccessDenied*") } infra/cloudtrail-111111111111-us-west-2

So the third field is the metric name.
You can then search for that in the alarm output
HAS_ALARM_ASSOCIATED=$($AWSCLI cloudwatch describe-alarms $PROFILE_OPT --region $CLOUDWATCH_LOGGROUP_REGION --query 'MetricAlarms[].MetricName' --output text | grep  $METRICFILTER_SET)

It might work :-)
You may need to take into account that multiple metrics might match the search pattern...

Ok, I think I get it @sweharris.
check31(){
  ID31="3.1,3.01"
  TITLE31="Ensure a log metric filter and alarm exist for unauthorized API calls (Scored)"
  textTitle "$ID31" "$TITLE31" "SCORED" "LEVEL1"
  CLOUDWATCH_GROUP=$($AWSCLI cloudtrail describe-trails $PROFILE_OPT --region $REGION --query 'trailList[*].CloudWatchLogsLogGroupArn' --output text| tr '\011' '\012' | awk -F: '{ print $7 }')
  if [[ $CLOUDWATCH_GROUP ]];then
    for group in $CLOUDWATCH_GROUP; do
      CLOUDWATCH_LOGGROUP_REGION=$($AWSCLI cloudtrail describe-trails $PROFILE_OPT --region $REGION --query 'trailList[*].CloudWatchLogsLogGroupArn' --output text | awk -F: '{ print $4 }')
      #METRICFILTER_SET=$($AWSCLI logs describe-metric-filters --log-group-name $group $PROFILE_OPT --region $CLOUDWATCH_LOGGROUP_REGION --query 'metricFilters' | awk '/UnauthorizedOperation/ || /AccessDenied/ {print $3}')
      METRICFILTER_SET=$($AWSCLI logs describe-metric-filters --log-group-name $group $PROFILE_OPT --region $CLOUDWATCH_LOGGROUP_REGION --output text | grep METRICFILTERS | awk 'BEGIN {IGNORECASE=1}; /UnauthorizedOperation/ || /AccessDenied/ {print $3};')
      if [[ $METRICFILTER_SET ]];then
        for metric in $METRICFILTER_SET; do
          #HAS_ALARM_ASSOCIATED=$($AWSCLI cloudwatch describe-alarms $PROFILE_OPT --region $CLOUDWATCH_LOGGROUP_REGION --query 'MetricAlarms[].MetricName' --output text | awk 'BEGIN {IGNORECASE=1}; /UnauthorizedOperation/ || /AccessDenied/;')
          HAS_ALARM_ASSOCIATED=$($AWSCLI cloudwatch describe-alarms $PROFILE_OPT --region $CLOUDWATCH_LOGGROUP_REGION --query 'MetricAlarms[].MetricName' --output text | grep  $metric)
          if [[ $HAS_ALARM_ASSOCIATED ]];then
            textOK "CloudWatch group $group found with metric filter $metric and alarms set for Unauthorized Operation and Access Denied"
          else
            textWarn "CloudWatch group $group found with metric filter $metric but no alarms associated"
          fi
        done
      else
        textWarn "CloudWatch group $group found but no metric filters or alarms associated"
      fi
    done
  else
    textWarn "No CloudWatch group found for CloudTrail events"
  fi
}

I have tried even with multiple metrics matching the same and it seems to work. Can you give it a try and let me know? I'd fix the rest of section 3 accordingly. Unless you want to send a PR ;)
Thanks!

I'm sorry but I've just had a family emergency and am now out of the office until next year.  That means I'm unable to test this 'cos I don't have access to the AWS account credentials from home (and rightly so :-)).
The code logic looks correct (if my understanding of AWS structures is right!) but I can't run any tests.  Sorry I can't be further help!  Thank you for the changes; they look good.

@sweharris I have added your code for check31 and it works fine in my accounts, thanks! I think check32 to check314 should have similar improvements, any PR would be appreciated ;)

That the same code logic appears 14 times tells me there's a need for refactorisation of this whole section.  Possibly create a __check3 function that takes a few parameters and does the consistent logic.  Then check31 would just call __check3 with the right values.
Probably also some caching of results, since you call the same API calls dozens of times (how many times is $AWSCLI cloudtrail describe-trails $PROFILE_OPT --region $REGION --query 'trailList[*].CloudWatchLogsLogGroupArn' --output text called?  By my count 27 times.)  Caching these type of results will reduce API calls and so increase speed, reduce cost, reduce errors...
This is a pretty large rewrite, and I'm not sure I have the spare time.   Fortunately you now have the pattern, so aren't dependent on me as a blocker!

Thanks @sweharris I'll give it a try :)


CI cache: API error (429 Too Many Requests)

https://github.com/ngi-nix/ngipkgs/actions/runs/7025704296/job/19117044773?pr=100#step:8:490

https://github.com/DeterminateSystems/magic-nix-cache#usage-notes

Usage Notes
The GitHub Actions Cache has a rate limit on reads and writes.
Occasionally, large projects or large rebuilds may exceed those rate-limits, and you'll see evidence of that in your logs.
The error looks like this:
error: unable to download 'http://<IP_ADDRESS>:37515/<...>': HTTP error 418
       response body:
       GitHub API error: API error (429 Too Many Requests): StructuredApiError { message: "Request was blocked due to exceeding usage of resource 'Count' in namespace ''." }

The caching daemon and Nix both handle this gracefully, and won't cause your CI to fail.
When the rate limit is exceeded while pulling dependencies, your workflow may perform more builds than usual.
When the rate limit is exceeded while uploading to the cache, the remainder of those store paths will be uploaded on the next run of the workflow.

Not ideal, but we must pick our battles.

Not applicable anymore since Magic Nix Cache was removed in https://github.com/ngi-nix/ngipkgs/pull/181/files#diff-7b2a967de7060a238e49a57908f83e860b8cb53a0b0991c3d0d275857c1014d4L20


Update: Puppet.pdk version <IP_ADDRESS>

Removing old versions to reduce clutter
Microsoft Reviewers: Open in CodeFlow

/azp run


Further improve caching by checking only relevant coordinates for certain datasets?

When I add a timestep to a model, the cached surface elevation data (AHN) gets invalidated and it downloads the data again. This could be a smarter check I feel. Modifying the time dimension should not invalidate the AHN cache, as it only concerns spatial data and does not have a time component (in our implementation anyway).
So, would it be possible to define the relevant coordinates to check whether certain cached datasets should be invalidated? For example,
Only spatial coordinates:

surface elevation (AHN)
layer models (REGIS, GeoTOP)
...

Spatial + time:

surface water features?
...

I agree that it feels like there could be a smarter check. At the moment the relevant data arrays are stored in a dataset and saved to a netcdf file together with a pickle.
I think there are two ways to do this:

In the cache function, before we write the dataset to a netcdf file, we can strip the coordinates from the dataset that are not used in the data variables.
In the functions that create the dataset such as get_ahn, get_regis we can strip all the coordinates from the returned dataset that are not used in the data variables. This is a bit more explicit.

In both cases the cache function should be modified in such a way that we only check if the coordinates in the cached dataset are the same as in the given dataset. I see no problems as long as there are no functions in which coordinates are used to create a data array but not used for the dimensions of that data array.


Missing AxisVisual and ArrowVisual implementation

Implementation of AxisVisual and ArrowVisual is missing for ogre (empty classes) and ogre2 (no implementation).

These methods currently work for ogre1 and ogre2 on melodic so I looked into the issue. The class is empty because it is implemented in the base class (BaseAxisVisual and BaseArrowVisual) using calls to createConeVisual and createCylinderVisual.

oh I missed that. Thanks for looking into this. I think I just tested ogre2 at the time and it was not working. It's mainly missing a few hooks to return a valid pointer. Done in pull requests #87

Thank you for the support.

pull request #87


Fancy Zones does not resize Pot Player.

ℹ Computer information

PowerToys version: v0.33.1
PowerToy Utility: Fancy Zones
Running PowerToys as Admin: True
Windows build number: 19042.867

📝 Provide detailed reproduction steps (if any)

Install PotPlayer
try using it with fancy zones.

✔ Expected result
What is the expected result of the above steps?
PotPlayer should resize to the desired zones.
❌ Actual result
What is the actual result of the above steps?
PotPlayer Doesn't resize to the desired zones, It just snaps to the top left corner of the zone with the same size it had.

To install, winget install potplayer for v210209
I can't repro this, it snaps for me

yes updated pot player to the latest and the problem is fixed.


New Release?

Hello , any news about the new release ? will it be out soon ?

The update after a day is to wait for a year to update, ...


How to use command python tools/train.py configs/xxxx.py

Dear mmdetection users, I am used to use mmdetection v1.0.0 and now I am struggling to use mmdetection v2.x.x. In the old version, I can use the command python tools/train.py configs/xxxx.py to train my model. In newer version, I find the implementation codes have become more complicated. Can I use the old command to train a model? Thank you very much.

You can still use python tools/train.py config  to train models.

I follow the tutorial to start a train.
from mmcv import Config, mkdir_or_exist
from os.path import abspath
cfg = Config.fromfile('./configs/mask_rcnn/mask_rcnn_r50_fpn_1x_coco.py')
from mmdet.apis import set_random_seed
Modify dataset type and path
cfg.dataset_type = 'CocoDataset'
cfg.data_root = 'data/'
cfg.data.test.type = 'CocoDataset'
cfg.data.test.data_root = 'data/'
cfg.data.test.ann_file = 'coco/annotations/instances_train2017.json'
cfg.data.test.img_prefix = 'coco/train2017'
cfg.data.train.type = 'CocoDataset'
cfg.data.train.data_root = 'data/'
cfg.data.train.ann_file = 'coco/annotations/instances_train2017.json'
cfg.data.train.img_prefix = 'coco/train2017'
cfg.data.val.type = 'CocoDataset'
cfg.data.val.data_root = 'data/'
cfg.data.val.ann_file = 'coco/annotations/instances_train2017.json'
cfg.data.val.img_prefix = 'coco/train2017'
modify num classes of the model in box head
cfg.model.roi_head.bbox_head.num_classes = 80
If we need to finetune a model based on a pre-trained detector, we need to
use load_from to set the path of checkpoints.
cfg.load_from = 'checkpoints/faster_rcnn_r50_caffe_fpn_mstrain_3x_coco_20210526_095054-1f77628b.pth'
cfg.load_from = None
Set up working dir to save files and logs.
cfg.work_dir = './tutorial_exps'
The original learning rate (LR) is set for 8-GPU training.
We divide it by 8 since we only use one GPU.
cfg.optimizer.lr = 0.02 / 8
cfg.lr_config.warmup = None
cfg.log_config.interval = 10
Change the evaluation metric since we use customized dataset.
cfg.evaluation.metric = 'mAP'
We can set the evaluation interval to reduce the evaluation times
cfg.evaluation.interval = 12
We can set the checkpoint saving interval to reduce the storage cost
cfg.checkpoint_config.interval = 12
Set seed thus the results are more reproducible
cfg.seed = 0
set_random_seed(0, deterministic=False)
cfg.gpu_ids = range(1)
We can also use tensorboard to log the training process
cfg.log_config.hooks = [
dict(type='TextLoggerHook'),
dict(type='TensorboardLoggerHook')]
We can initialize the logger for training and have a look
at the final config used for training
print(f'Config:\n{cfg.pretty_text}')
from mmdet.datasets import build_dataset
from mmdet.models import build_detector
from mmdet.apis import train_detector
Build dataset
datasets = [build_dataset(cfg.data.train)]
Build the detector
model = build_detector(cfg.model)
Add an attribute for visualization convenience
model.CLASSES = datasets[0].CLASSES
Create work_dir
mkdir_or_exist(abspath(cfg.work_dir))
train_detector(model, datasets, cfg, distributed=False, validate=True)
The following error occurs.
RuntimeError:
An attempt has been made to start a new process before the
current process has finished its bootstrapping phase.
    This probably means that you are not using fork to start your
    child processes and you have forgotten to use the proper idiom
    in the main module:

        if __name__ == '__main__':
            freeze_support()
            ...

    The "freeze_support()" line can be omitted if the program
    is not going to be frozen to produce an executable.

Could you tell me what is wrong? I am using version 2.23.0 and pytorch 1.11

pytorch： 1.8.1+cu111
mmDet： 2.25.3
cuda 11.1
I had the same exact problem and other posts Suggestions didn't work for me.

Dear mmdetection users, I am used to use mmdetection v1.0.0 and now I am struggling to use mmdetection v2.x.x. In the old version, I can use the command python tools/train.py configs/xxxx.py to train my model. In newer version, I find the implementation codes have become more complicated. Can I use the old command to train a model? Thank you very much.

Have you solved it？

I have fix the issue，reflecting on my lack of familiarity with torch.
solution：
cfg.data.workers_per_gpu = 0
if occur further error：
RuntimeError: Index put requires the source and destination dtypes match, got Long for the destination and int for the source.
solution：
please change “np.long” to “np.nt64” at the class  “KittiTinyDataset”.


[Map] DM-GreatGreenIsle

Hash: 964ad3dd5ee6730f86ff2c3de1124e7d616a901f
Current name: DM-GreatGreenIsle
The author's email name is Nick Lowman
Possibly use this as map author name?

Updated as suggested


Meter-524  Fix sigar_proc_port_get by updating tcp/udp table calls me…

Use a non-deprecated call in iphlpapi to pull proc/port connection data.

Looks good to me. I'm actually using sigar in a local project too, so this could be useful. Do you know if it still works under Win XP?

Not sure.  According to MSDN the original calls were deprecated in Vista, and I guess finally removed at some point.  I am testing on 2012 R2.   There are some other issues in there I am going to address as well...loving the windows hell ;)

LGTM!  The MSDN documentation indicates that the GetExtendedTcpTable() and GetExtendedUdpTable() functions should work on Windows Server 2008 and 2003 (SP1), we probably want to make sure... :)


GuardCluase also matches if-with-body that contains a return

@arturbosch
I thought opening a PR was better than opening an Issue.
Although, I didn't properly test it yet - I'm new to gradle and Spek.
If you prefere, I can open an issue instead...
What I want -
to consider an if with a body as guard clause as well.
I've added a test-case to demonstrate.
In my company, we almost disabled ReturnCount because it catches guard-clauses, and then I saw guard-clauses - and was disappointed it applies only to ifs without a body.
Our code-style convention don't allow if's without body.

tests fail because my example code (which i copy-pasted from previous it) - did not compile.
I'll fix that, and the rest of the cases while I'm at it.
please wait with review...

OK
I've fixed my tests,
migrated all tests but the last one from lint() to compileAndLint().
Hope checks pass this time.

Thanks!

Thanks @arturbosch
for the good comments and support!


Newest packages (2.2.6) are missing from package repo

Problem encountered on https://dotnet.microsoft.com/download/linux-package-manager/ubuntu18-04/runtime-current
Operating System: Linux Ubuntu 18.04 - x64
Asp 2.2.6 packages are missing from repo

Working now...


Support of implicit flow

I am searching in the documentation but I cannot find any reference regarding implementation of an implicit flow, using the implicit grant type.
The way I used to overcome this, is to access the user object from the session and not the request in the @oauth.tokensetter decorated function (since there was no grant token issued before) but I am concerned that this workaround might create security holes.
@oauth.tokensetter
def save_token(token, request, *args, **kwargs):
    user_id = request.user.id if request.user else session.user.id
    tokens = OAuthToken.find(OAuthApplication.client_id == request.client.client_id,
                             OAuthToken.user_id == user_id,
                             _join=OAuthApplication)
    # make sure that every client has only one token connected to a user
    for t in tokens:
        db.session.delete(t)
        logger.info("Deleted token for user {} before saving a new one.".format(user_id))
    application = OAuthApplication.find_one(client_id=request.client.client_id)
    scopes = token['scope'].split()
    token = OAuthToken(application_id=application.id, user_id=user_id,
                       access_token=token['access_token'], scopes=scopes)
    db.session.add(token)
    return token

Same question here..

Again, same question.

same issue

Same...

Same here

Same here, too...

After nearly two weeks of attempting to implement implicit grant in its pure form, I wish to conclude that Flask-OAuthlib is not designed for implicit grant at all.
I had issue with response_type in authorize(), which was set implicitly to 'code' and at authorization end point (at oauth.handler decorator), I could not find a work around to make decorator return uri+token post authorization by user. I would like to know if some one has any solution.  I can really use any sort of help/guidance.

@gsverma How did you get it to work?

@gsverma Would be really great to hear how you got this to work? \cc @lepture

Hi @mikeywaites and @asteinlein! Greetings. Sorry about the delay, I'll definitely update regarding OAuth Provider (implicit grant) implementation using OAuthLib this weekend. Got caught up on another task.

Hi, I know this is an old issue, but what is the status with the implicit flow? Is is supported (I cannot see any examples anywhere)?

@othane check out https://github.com/lepture/authlib


HTTPS proxy not working

When the HTTPS connection through Proxy Server, pages can't be displayed.
It cause DMM.com's Login pages can't be displayed, either.

It works pretty fine with my proxy and ver. 4.2.3. Check your proxy please.

@smdhz  What's Your Operating System ?
maybe only have problem with Windows 7

it really has little diffrent between win7 n win10 for me. but not the problem you meet.
i use <IP_ADDRESS> n prot 433 for https n it works for win10 with this way https will not go trough a proxy.
but it not works for win7 at my office.


Add requirements to README

Add a section to the README documenting the requirements for ringpop-node.
This should help people run into trouble when trying to npm install on a newer version of node1.

LGTM

The change to the readme looks good and can be merged, but shall we also specify the version in the package.json under the engines section

I'm not completely sure if 0.10.x is the right version. I was unable to do an install of the dependencies with the following versions:

0.10.0
0.10.1
0.10.2
0.10.3

All seem to have troubles with our package json dependencies section where the ^ is used to ask for compatible versions of packages. Versions that worked for me are the following:

0.10.26
0.10.32

Even though the problem is not with node but rather with nvm I wonder if we should specify a higher version of node to make sure that nvm install works. We can also figure out which version of nvm has support for ^ versions but I couldn't easily find when support was added<EMAIL_ADDRESS>has support (shipped with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(shipped with<EMAIL_ADDRESS>does not have support.

Ah thanks @thanodnl for looking into this.
Should we specify ^0.10.32 then (that is the version we typically test with anyway)?
Maybe I should do a sanity check of versions above 0.10.32.

Travis tests run on v0.10.45 successfully so I'm just gonna merge this.

LGTM!

Merged in commit ee72383.


Antipattern: YOLO Software Architecture

Building software these days has way too many rules. I don't follow rules I don't agree with or understand - I prefer to do whatever gets the job done. That's pragmatic, that is.
The term YOLO Architecture refers to, essentially, the complete lack of consistency, guidance, or rules within a software system. Or at least, the lack of enforcement or application of whatever rules might ostensibly exist or be given lip service.
The result of a YOLO approach to architecture is, invariably, the Big Ball of Mud architecture, basically by definition.

https://www.dictionary.com/browse/yolo

Done


Correct typo on disclaimer

Correct the spelling of "dependant" on the disclaimer:
....."is entirely dependant on the accuracy of the information and the data"....

Fixed in master. Will be part of the Feb 15th release.


Failed to parse in Docker

Unable to install package inside docker, in normal environment the same package installs without problems.
docker run -it --rm -v $(pwd):/io python:3.10 /bin/bash

pip install uv

root@2610453f5764:/io# uv pip install package_name-1.0.0.dev56+g18c683a2-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
error: Failed to parse: `package_name-1.0.0.dev56+g18c683a2-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl`
  Caused by: Expected one of `@`, `(`, `<`, `=`, `>`, `~`, `!`, `;`, found `+`
package_name-1.0.0.dev56+g18c683a2-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl

I think you need uv pip install ./package_name-1.0.0.dev56+g18c683a2-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.

Thank you, it really works. But why?

We can probably improve this though.

Thanks!

Gonna re-open because I want to fix our logic here.


@alloy => Adds long tap gesture for bidding error details 📱

Adds a tap gesture recognizer to the error details label that will display an alert with the technical details, including the API response HTTP status code (if any), body length, and UTF8-encoded body string (if any).
I've produced an intentional error to generate the screenshot below:

Tests pass locally.
Fixes #454.

/cc @dblock @alessandra-castillo

Nice! :+1:

:bow:

Thanks Ash!!


Add box-shadow css

It's introduced in 7.2 via enableSWCSupport flag. But this is slated to change in 8.0 where it might be moved under another feature flag which would be independent of SWC support allowing usage of CSS features without necessarily using Web components.

Done https://github.com/jardicc/vscode-uxp-validator/releases/tag/v1.2.0


Cleanup

This pr is for various cleanup items:

Remove xUnique
Remove included .xcscheme file (Xcode will instead auto-generate it on project creation)
Remove drone files
Remove TrueColors files (we are no longer using/maintaining it)
Clean up self.
Update README

@vokal/ios-developers review please

Everything else LGTM


Error: Unexpected token <

I'm submitting a ...  (check one with "x")
[x ] Bug report => search github for a similar issue or PR before submitting
[ ] Feature request
[ ] Other, please describe

Tell about your platform

Trumbowyg version : 2.20.0
Vue.js version : 2.6.10
Browser name and version : Chrome
This package version : 3.4.2

Current behavior

Unexpected token <
Expected behavior

Minimal reproduction of the problem with instructions

Once I load it as a plugin on another Vue component it throws that Unexpected token <

well this is not helpful, please provide a re-production on codesandbox

Closing due to no activity, feel free to re-open


Add posting to GitHub

This allows Callisto to post the build Summary directly to GitHub.
Posting to slack is not supported anymore.
Changes
Buildkite supports building both platforms simultaneously by splitting the workload to different servers. Because we don't want duplicate build warnings & errors Callisto now runs in two steps.
Step 1
Each build parses the output from fastlane and saves the information in a .buildreport file. This file is then uploaded to Buildkite because it's marked as build artifact/annotation - this is defined somewere in buildkite.yml
Step 2
After both builds finished (doesn't matter if on different or the same machine) the .buildreport files are read. This works because buildkite provides us the artifacts files - again defined somewhere in buildkite.yml.
Callisto then filters duplicate build messages and splits them by platform. The resulting message is then posted (or updated if necessary) to GitHub as a comment.

@Patrick-Kladek I think this one is already included in our CI setup - can we merge this also here into master?

@schwmi yes can be merged. Did you encounter any bugs until now?
I also extend the PR Description. Does it make sense or do you need additional information?

Thanks for the description 👍


Fixed exception on PgType usage

Codecov Report
Attention: Patch coverage is 6.89655% with 27 lines in your changes missing coverage. Please review.

Project coverage is 45.73%. Comparing base (cf1fef2) to head (ba71b96).

Files
Patch %
Lines

...le/src/main/java/tech/ydb/table/values/PgType.java
0.00%
18 Missing :warning:

...in/java/tech/ydb/table/values/proto/ProtoType.java
0.00%
9 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #288      +/-   ##
============================================
- Coverage     45.83%   45.73%   -0.11%
  Complexity     1616     1616
============================================
  Files           299      300       +1
  Lines         11790    11818      +28
  Branches       1145     1147       +2
============================================
+ Hits           5404     5405       +1
- Misses         5975     6002      +27
  Partials        411      411

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Ubuntu was making my laptop super slow so i decide to reset it. After that it is not working anymore. I can not uninstall it. I really need it now. I use it just to connect to a server via shh and work in remote.

Please use the following bug reporting template to help produce issues which are actionable and reproducible, including all command-line steps necessary to induce the failure condition. Please fill out all the fields! Issues with missing or incomplete issue templates will be closed.
If this is a console issue (a problem with layout, rendering, colors, etc.), please post to the console issue tracker.
Important: Do not open GitHub issues for Windows crashes (BSODs) or security issues.  Please direct all Windows crashes and security issues to<EMAIL_ADDRESS> Ideally, please configure your machine to capture minidumps, repro the issue, and send the minidump from "C:\Windows\minidump".\
See our contributing instructions for assistance.
Please fill out the below information:

Your Windows build number:  (Type ver at a Windows Command Prompt)

What you're doing and what's happening:  (Copy&paste the full set of specific command-line steps necessary to reproduce the behavior, and their output. Include screen shots if that helps demonstrate the problem.)

What's wrong / what should be happening instead:

Strace of the failing command, if applicable:  (If some_command is failing, then run strace -o some_command.strace -f some_command some_args, and link the contents of some_command.strace in a gist here).

For WSL launch issues, please collect detailed logs.

My build number is Microsoft Windows [Versione 10.0.18363.657].
I'm using a Dell Inspiron 15 7000.

You can just install openssh in windows if you only need to use ssh

can I then work on my terminal?

Yes, you can. That's what I'm doing too since wsl isn't working on my computer.

Thanks a lot.
Indeed I'm also working now with the power shall.


Unexpected token function

node src/camera.js ../tornado/data.py
I got error:
async function startBrowser () {
      ^^^^^^^^
SyntaxError: Unexpected token function
    at Object.exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:513:28)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
    at Function.Module.runMain (module.js:575:10)
    at startup (node.js:160:18)
    at node.js:449:3```

Hi @nkuflk, what version of Node are you using?

Hello, @mplewis my node version is v6.2.0

You will need to upgrade to at least Node 7.10.1 to use this script. That's the first version that supports async functions natively.
Hope this helps! Sorry for the inconvenience.

@mplewis Thanks a lot. That is helpful for me.


Using files from assets instead of external urls for fixed versions

Is it possible to move external files from _https://github.com/vb64/django.admin.geomap/blob/main/django_admin_geomap/templates/geomap/osm/base.html_
<!-- Pointer events polyfill for old browsers, see https://caniuse.com/#feat=pointer -->
<link rel="stylesheet"<EMAIL_ADDRESS>type="text/css" />
<script<EMAIL_ADDRESS>
<script src="https://code.jquery.com/jquery-3.5.1.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.5.0/js/bootstrap.bundle.min.js"></script>

to assets, because it is fixed versions and it is blocked by "Content-Security-Policy" by default.
This requires to add exemptions for fixed versions URLs on all servers.

Of course, it is possible.
But we need to figure out the best way to do it in order to maintain backward compatibility with existing installations.
Do you have any suggestions?


allow node text to be copied

I think this behavior would be nice.  Leaves the drag action only on the nodes themselves, and lets you use the text selection tool on node text.

Don't pull this yet.  One of the changes I merged into my fork broke this enhancement.

OK, should be fixed again now.


Enhanced readme

Added Yarn to install instructions
Added link to the MIT licence
Changed readme extension from .markdown to .md

Closing this since the changes are minor and the repo seems to be no longer maintained.


Is it possible to provide a file containing only all positive GTs?

The 01-04 file of the training dataset contains all positive, negative and similar GTs, how to get only positive GTs?

You could refer the code in “https://github.com/ChrisDud0257/HGGT/tree/master/PosNegGTSR/basicsr/data/posneggtpos_dataset.py
", that's how we only find out positive GTs in the training progress.

Or just refer to the code in "https://github.com/ChrisDud0257/HGGT/blob/master/PosNegGTSR/scripts/metrics/calculate_multigt_labeled_psnr_ssim.py", that's how we select the positive GTs in the assessment progress.


Error while trying to run the deploy.ps1 script

This issue is for a: (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce
running the deploy script (deploy.ps1) cause an error

Any log messages given by the failure
this is the error that the script provides:
ERROR:
status:"Failed"
error: :"DeploymentFailed"
message: "At least one resource deployment operation failed. Please list deployment operations for details. Bad Request - Request Too Long, HTTP Error 400. The size of the request headers is too long"
trying to check what's happen in the deploy i found the following problems:

seems that there are two errors:

adtEventHubRoute with the following status message:
Bad Request - Request Too Long, HTTP Error 400. The size of the request headers is too long

azDtEventGridRoute with the following status message:
Bad Request - Request Too Long, HTTP Error 400. The size of the request headers is too long

@lucadibiagio try rerunning with the ../deploy.ps1 in my pull request #14

Hey There,
I have recently made some major changes fixing up a few bugs and issues related to this repo. Feel free to try this again and see if you get the expected outputs.
If there's no reply in 1 week, I'll close off this issue. But feel free to open a new one and I'll get to it ASAP.


test: behaviors-message_on_lock_failure (2024-03-07 00:27:48.454507+00:00)

automatic test cleanup


Select control, reactiveforms and display value

Is your feature request related to a problem? Please describe.
I have a reactive form with one control that has to be filled with an object of a type Club:
interface Club{
  name: string;
  url: string;
}

I create a list of clubs, and fill the select with it:

        <mdc-select formControlName="club" label="Club" [helperText]="clubHelper" [outlined]="true" [floatLabel]="true" fxFlex="76%">
          <mdc-menu>
            <mdc-list [avatar]="true">
              <mdc-list-item *ngFor="let club of clubs" [value]="club">
                {{ club.name }}
              </mdc-list-item>
            </mdc-list>
          </mdc-menu>
        </mdc-select>
        <mdc-select-helper-text #clubHelper [validation]="true">
          Club is required
        </mdc-select-helper-text>

The problem is that when I select a club from the picker, the formcontrol property is filled property but the selector placeholder is being shown as empty as it doens't know how to represent a "Club".
Describe the solution you'd like
To be able to tell the mdc-select wich property of the binded object should use to represent it without needed to change the formControlName property value
Describe alternatives you've considered
To create two forms properties: club and clubName, and use formControlName = "clubName", and every time an item is selected traverse the list of clubs to find the one with the name and fill the club property of the form manually.

Sounds similar to what occurs with the Lazy Loaded mdc-select example? Investigating

@gpulido Just released v5.0.1. Mind trying to see if resolved with #2060 ?

@trimox  I have reviewed it, and unfortunattely that doesn't solve my use case.
The idea is that if I have for example an array of clubs:
Club : {
name: string,
description: string,
imageUrl: string
}

And I'm using a form to fill a new Contender:
Contender: {
  club: Club,
  name: string
}

If I have a formControl binded to the contender.club property I could just create a select with the list of clubs, that will show the {{club.name}} on the picker but after selecting one of the items (that is a Club) it could be associated to eh formacontrolName.
That part is working (the association) the problem is that the underlining mdc-form-field doesn't know how to show the Club, so it would be nice if we can tell the field which property (or expression) based on the assoiated element (a Club in this case) is used to show the text on the field.
The way I'm solvint it now is to create another "formfield" binded to the club.name property and then after each selection search for the "Club" that match the club.name to associate it to the contender. It works for basic cases, but if there are two clubs with the same name (for example) only the first would be found.
I hope it is more clear now.
Thanks for the support.
Gabriel

Hello, thanks por taking a look. If there is anything that I could test / review let me know.

@gpulido Think we're good to go.
Sample


Community app merged, but not showing in mobile app for installation

I submitted a new app which was merged a few weeks ago (#1199), but I'm unable to locate it in the mobile app to install to my device. I've seen several other PRs that have been merged since and are visible in the mobile app. Is there anything addtional I need to do to make it available for installation?

@alewando Have you signed up for the Beta list yet? I can search for Langton in the mobile app and see your app there.

They may just do it in batches or something. It just depends. Sure things come up as well. Getting added to beta will help seeing it quicker.
As for feedback, that's sort of what beta is for, is hoping it can be caught before released to everyone. But there is a new apps app that when it is available on the app it shows up on that app. I don't know if the Tidbyt api endpoint it hits the beta or not, haven't checked. my guess it is not the beta.

Ok, thank you. I will close this issue then.


golang: recommend glide instead of godep

fixes #775

LGTM as an excision of the existing and deprecated godep recommendation.
Will glide things like updating vendored deps require in-particular project guidance as they did with godep[1]? Or are the external docs fit for purpose there?
[1] https://github.com/coreos/docs/issues/775#issuecomment-207116463

I'll volunteer to write a "Using Glide" document based on my experience using it for a few projects (including Dex).

@s-urbaniak we can probably pull something from here?
https://github.com/coreos/rkt/blob/master/Documentation/hacking.md#managing-dependencies
On 13 July 2016 at 07:09, Eric Chiang<EMAIL_ADDRESS>wrote:

I'll volunteer to write a "Using Glide" document based on my experience
using it for a few projects (including Dex).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/coreos/docs/pull/854#issuecomment-232257774, or mute
the thread
https://github.com/notifications/unsubscribe/ACewN9J664xpjzFfObQFmq4vdcqXTwD7ks5qVHLvgaJpZM4JGDyc
.

@jonboulle Yes, the whole "Managing dependencies" chapter actually is not rkt-specific, except that we don't "like" declaring version ranges in glide.yaml, also https://github.com/coreos/rkt/blob/master/scripts/glide-update.sh turned out to be a good starting point for other projects.

@jonboulle this looks good to me.  The lack of a replacement for Using Godep seems like it might be a problem, but if the consensus is that we don't need a replacement doc this looks good to merge. 👍


Updating Index in Azure Cognitive search

I was wondering if we can update index/knowledge base? I have a customer scenario where customer has setup testing of chatbot in a couple of phases. In each phase a different number of pdf files are indexed into the knowledge base (Azure Cognitive Search). I could not find any option to do that!
I tried to delete previously indexed files and put new set of files under /data and ran azd deploy but nothing changed.
Going forward I will delete the index and run azd up to see if it creates a new index.
But I was wondering if we have a feature which allows us to deal with data management in an easier way?

Please read the FAQ question about this and let us know if you have further questions:
https://github.com/Azure-Samples/azure-search-openai-demo#faq


Poly/Poly collision is missed during RubeGoldberg test world run

Don't know why yet, other polygon collisions seem to work. There also may be a quirk around the polygons against edges - need to devise another world for that.

How it's meant to work:

Looks like the polygon does move but it doesn't flip...

It was clipped by the falling beam, not actually hit. Which is odd. I've moved it and tweaked some object properties and everything appears to work now.


Morphing overwrites the user's input on active element

Hi!
In #1195, ignoreActiveValue: true was reverted, which was the correct decision. The idea is that, even for the active element, the source of truth is the value attribute that's returned in the HTML used for morphing.
However, this breaks situations where you have an <input type="search"> that autosubmits as you type:
https://github.com/hotwired/turbo/assets/121003/5b372fcd-fa0b-4807-a962-9d6d19063ee3
Here's what happens:
A) User typesapple and pauses
B) A Stimulus controller submits the form
C) WHILE the Ajax request is happening, the user types df (so now the box has appledf)
D) The Ajax request finishes, and the new HTML contains value="apple" because that value was submitted. This causes the df to be lost on the input.
This continues a conversation from #1194 with @seanpdoyle - https://github.com/hotwired/turbo/issues/1194#issuecomment-1957435564 -  who originally set ignoreActiveValue: true in part to help solve this problem.
I'm not sure what the solution is. In LiveComponents, we solve this with an approach that is probably too heavy-handed for Turbo: by tracking input changes that happen after the Ajax request starts and making sure to preserve those during morphing.
Cheers!

As pointed out in that PR, did you try adding data-turbo-permanent to the input when focusing and removing the attribute when unfocusing? Like data-action="focus->element#makePermanent blur->element#makeNotPermanent"

As pointed out in that PR, did you try adding data-turbo-permanent to the input when focusing and removing the attribute when unfocusing? Like data-action="focus->element#makePermanent blur->element#makeNotPermanent"

Hi! I was more looking for "what is the proper way to handle this situation". And... maybe this is it? Maybe the idea is:

When a new page is morphed, if the user has been actively typing into an input, their new text might be replaced. To avoid, this, you can mark the input as permanent when its focused by... etc, etc.

If that's the case, should we provide an attribute for this? data-turbo-preserve-focus-value? It's a little wordy... but the hope is to allow for both situations:
A) In my form, the user hits "Enter" to submit and I redirect and re-render a clear form. So I want the focused input to have its value cleared (current behavior)
B) My form is auto-submitting as the user is typing and I DO want to keep the value in the form, even if it differs from the server.

It's simpler than that. When you focus the input, if you add the data-turbo-permanent attribute, Turbo knows that this element does not have to be touched when morphing. Therefore, it won't lose focus and the value won't change either. You just have to make sure to remove the attribute when blurring. With that you can easily cover case B. Honestly, I see it unlikely that the team would want to add something like that, since that means maintaining an API for a case that can be easily solved with Stimulus.

Then, at least for now, let's go with this as the official solution 👍

I like the idea to set data-turbo-permanent on the focused element! However in order to work, it seems that it also needs to be set on the same element of the replacement HTML? The server can not set it because it doesn't know the focused element – resorting to custom JS in turbo:before-frame-render that copies data-turbo-permanent feels a bit hacky but works. I've posted about it over there: https://discuss.hotwired.dev/t/form-that-changes-on-user-input-without-losing-focus/6117, feedback welcome.


PVGViewModels with duplicate unique ids removed

Adding objects with the same unique ids crashes UITableView
with NSInternalInconsistencyException.
E.g.
Terminating app due to uncaught exception
 'NSInternalInconsistencyException', reason: 'Invalid update: invalid number of rows in section 0.
 The number of rows contained in an existing section after the update (13) must be equal to the
number of rows contained in that section before the update (9), plus or minus the number of rows
inserted or deleted from that section (7 inserted, 6 deleted) and plus or minus the number of rows
moved into or out of that section (0 moved in, 0 moved out).'

Looks great, can be merged and added to a new version for my part.

 Very very annoying.

LGMT, merge on green lights.


Add support for ESLint v9

Goal

A new @rightcapital/eslint-config package will target ESLint v9, provide various configurations for different usages, and receive future updates.
The existing @rightcapital/eslint-config-* packages will continue to support ESLint v8, but we may deprecate them in favor of the new @rightcapital/eslint-config.

Changes

Packages:

@rightcapital/eslint-config(new package), targets ESLint v9, almost have the same rules with @rightcapital/eslint-config-*, with following differences:

Migrated deprecated rule no-new-symbol to no-new-native-nonconstructor
Added sensible preset for files (likes overrides in ESLint v8) in recommended config, this would hugely reduce users config to apply different rules for different files. (It already makes the ESLint config in this repo clearer.)

Removed legacy packages (we may deprecate them on npm later):

@rightcapital/eslint-config-base
@rightcapital/eslint-config-javascript
@rightcapital/eslint-config-typescript
@rightcapital/eslint-config-typescript-react

E2E tests:

specs/eslint-configs-legacy: renamed from specs/eslint-configs, target ESLint v8, test configs for @rightcapital/eslint-config-*.
specs/eslint-configs: target ESLint v9, test the new @rightcapital/eslint-config.

Docs:

Updated usage instruction. (preview)

As 1.i.b. mentioned, the ESLint config in this repo has been migrated to the new @rightcapital/eslint-config and ESLint v9.

This resolves #128.

Consider adding support for .gitignore or .eslintignore?

We may add this in later versions. This PR aims to bring ESLint v9 support with least changes to features as possible.


[Bulk] Broken Link fixes

Global effort to fix broken links
@stevemunk
The C+E Skilling team is fixing broken links on learn.microsoft.com for the rest of H2. This effort will eliminate potential accessibility, security, and usability issues. This PR includes only link fix/remove and does not change other content. I'd very much appreciate your timely review and feedback on the link changes I've suggested. Thanks!

Learn Build status updates of commit 7bcf62b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingMaps/coverage/transit-coverage/europe.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit dc1fb48:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingMaps/coverage/transit-coverage/europe.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/middle-east.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 72a34fd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingMaps/coverage/transit-coverage/europe.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/middle-east.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/north-america.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 4d4dfcd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingMaps/coverage/transit-coverage/europe.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/middle-east.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/north-america.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 212cd8f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingMaps/coverage/transit-coverage/europe.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/middle-east.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/north-america.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/south-america.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 0b692e9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingMaps/coverage/transit-coverage/europe.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/middle-east.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/north-america.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/south-america.md
:white_check_mark:Succeeded
View

BingMaps/retired/navteqna.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 711489e:
:warning: Validation status: warnings

File
Status
Preview URL
Details

BingMaps/coverage/transit-coverage/south-america.md
:warning:Warning
View
Details

BingMaps/coverage/transit-coverage/europe.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/middle-east.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/north-america.md
:white_check_mark:Succeeded
View

BingMaps/retired/navteqna.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/south-america.md

Line 166, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit c28b50b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

BingMaps/coverage/transit-coverage/south-america.md
:warning:Warning
View
Details

BingMaps/coverage/transit-coverage/europe.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/middle-east.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/north-america.md
:white_check_mark:Succeeded
View

BingMaps/retired/navteqna.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/south-america.md

Line 164, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 167, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 375e52d:
:warning: Validation status: warnings

File
Status
Preview URL
Details

BingMaps/coverage/transit-coverage/middle-east.md
:warning:Warning
View
Details

BingMaps/coverage/transit-coverage/south-america.md
:warning:Warning
View
Details

BingMaps/coverage/transit-coverage/europe.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/north-america.md
:white_check_mark:Succeeded
View

BingMaps/retired/navteqna.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/middle-east.md

Line 27, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 31, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.

BingMaps/coverage/transit-coverage/south-america.md

Line 164, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 167, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit ed64283:
:warning: Validation status: warnings

File
Status
Preview URL
Details

BingMaps/coverage/transit-coverage/middle-east.md
:warning:Warning
View
Details

BingMaps/coverage/transit-coverage/south-america.md
:warning:Warning
View
Details

BingMaps/coverage/transit-coverage/europe.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/north-america.md
:white_check_mark:Succeeded
View

BingMaps/retired/navteqna.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/middle-east.md

Line 27, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 37, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 52, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.

BingMaps/coverage/transit-coverage/south-america.md

Line 164, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 167, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 7d32f8e:
:warning: Validation status: warnings

File
Status
Preview URL
Details

BingMaps/coverage/transit-coverage/middle-east.md
:warning:Warning
View
Details

BingMaps/coverage/transit-coverage/south-america.md
:warning:Warning
View
Details

BingMaps/coverage/transit-coverage/europe.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/north-america.md
:white_check_mark:Succeeded
View

BingMaps/retired/navteqna.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/middle-east.md

Line 27, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 37, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 52, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 56, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.

BingMaps/coverage/transit-coverage/south-america.md

Line 55, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 71, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 98, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 168, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 171, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 7bb282f:
:warning: Validation status: warnings

File
Status
Preview URL
Details

BingMaps/coverage/transit-coverage/middle-east.md
:warning:Warning
View
Details

BingMaps/coverage/transit-coverage/south-america.md
:warning:Warning
View
Details

BingMaps/coverage/transit-coverage/europe.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/north-america.md
:white_check_mark:Succeeded
View

BingMaps/retired/navteqna.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/middle-east.md

Line 27, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 37, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 52, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 56, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.

BingMaps/coverage/transit-coverage/south-america.md

Line 55, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 71, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 98, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 107, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 166, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 171, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 174, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Hi @stevemunk, thank you for your feedbacks. While I was working, I noticed that most of the external website domains do not support (secure connection) https. Do you want me to remove those links from articles?

Hi @stevemunk, thank you for your feedbacks. While I was working, I noticed as well that most of the external website domains do not support (secure connection) https. Do you want me to remove those links from articles?

@DhurataJ: I tested every link that I commented on, and I marked each with either a suggestion to change it to https, or a comment saying that it does not support secure connections (This site does not support https). For those that don't support secure connections, just leave them as is. Do not remove the links. Those that do support secure connections need to be changed to https.

Hi @stevemunk, thank you for your feedbacks. While I was working, I noticed as well that most of the external website domains do not support (secure connection) https. Do you want me to remove those links from articles?

@DhurataJ: I tested every link that I commented on, and I marked each with either a suggestion to change it to https, or a comment saying that it does not support secure connections (This site does not support https). For those that don't support secure connections, just leave them as is. Do not remove the links. Those that do support secure connections need to be changed to https.

Thanks, Steve for following up and clarification in that matter. Suggestions applied to those that needed to be changed to https.

Thanks @stevemunk for following up and clarification in that matter. Suggestions applied to those that needed to be changed to https.

Learn Build status updates of commit 5e9d404:
:warning: Validation status: warnings

File
Status
Preview URL
Details

BingMaps/coverage/transit-coverage/europe.md
:warning:Warning
View
Details

BingMaps/coverage/transit-coverage/middle-east.md
:warning:Warning
View
Details

BingMaps/coverage/transit-coverage/south-america.md
:warning:Warning
View
Details

BingMaps/coverage/transit-coverage/north-america.md
:white_check_mark:Succeeded
View

BingMaps/retired/navteqna.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/europe.md

Line 30, Column 11: [Warning: file-not-found - See documentation] Invalid file link: '[http://www.obus.at](https://www.salzburg-ag.at/)'.

BingMaps/coverage/transit-coverage/middle-east.md

Line 27, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 37, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 52, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 56, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.

BingMaps/coverage/transit-coverage/south-america.md

Line 55, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 71, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 98, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 107, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 166, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 171, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 174, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit e369410:
:warning: Validation status: warnings

File
Status
Preview URL
Details

BingMaps/coverage/transit-coverage/europe.md
:warning:Warning
View
Details

BingMaps/coverage/transit-coverage/middle-east.md
:warning:Warning
View
Details

BingMaps/coverage/transit-coverage/south-america.md
:warning:Warning
View
Details

BingMaps/coverage/transit-coverage/north-america.md
:white_check_mark:Succeeded
View

BingMaps/retired/navteqna.md
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/europe.md

Line 30, Column 11: [Warning: file-not-found - See documentation] Invalid file link: '[http://www.obus.at](https://www.salzburg-ag.at/)'.

BingMaps/coverage/transit-coverage/middle-east.md

Line 27, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 37, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 52, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 56, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.

BingMaps/coverage/transit-coverage/south-america.md

Line 55, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 71, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 98, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 107, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 166, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 171, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 174, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Lexer bug : Cannot evaluate numbers in directory in from clause

For instance if i try
select * from Modulo12

the parser directory_name cannot evaluate it since it evaluates to lexer token ID, which does not have digits in it.
The trick is to write up the lexer token orders to not break the other tests. And then after fixing this writing some tests with directories with numbers in them.

commit d1c96d1aa4126461aa49a40fb242138b700666e9 fixes it.


Color for lock UNLOCKED.

Hi,
I would like to make the lock state UNLOCKED more obvious in the UI. Right now when the lock is LOCKED we can define a color, but when it is UNLOCKED the icon is just grey.
In order to clearly see when a lock is UNLOCKED I would like to be able to define a color for the UNLOCKED state.
By default I imagine green when it is LOCKED and red when it's UNLOCKED.
Thanks a lot for your help and the great work !
Mushroom is really a game changer !

There already is an issue about lock state color https://github.com/piitaya/lovelace-mushroom/issues/335. I agree that red/green can be better 😉

Great, I haven't seen it. Thanks

Hi All,
I see in the current release we do now have color added to Locks.  I think that is great.  But I am in disagreement with danch99 as to what color should represent locked vs unlocked.   To me RED means stop, thus a locked door means you cannot go forward.  Green means go.  You can go through an unlocked door.  I would prefer the colors swapped.  I would like to go further to suggest this paradyne be carried forward to other cards.  For example an open cover (like a Garage door) should show as Green as you can go through them, and Red when the door is closed as you are are stopped from going through the door as it is closed.  An alarm card shows Red when it is alarmed (as you cannot go through the house), and Green with disarmed as you can freely go through the house. Having a consistent color interface would augment useability in my opinion.
If others disagree with my stop/go Red/Green concept, perhaps the ability to set whatever color you want for each state would be a secondary option.
In any case thanks to you and your growing number of helpers for making the Mushroom suite of cards.  They are absolutely the best thing to come to Lovelace.  A final question if you don't mind....  How did you come up with the name "Mushroom" ?
Thanks for all,
fj

Hi 🙂
Thanks for your feedback. I don't have a lock so I don't known what is the best solution about colors 😅
Your can customize the lock colors in your theme.yaml file
--mush-rgb-red: 244, 67, 54;
--mush-rgb-pink: 233, 30, 99;
--mush-rgb-purple: 156, 39, 176;
--mush-rgb-deep-purple: 103, 58, 183;
--mush-rgb-indigo: 63, 81, 181;
--mush-rgb-blue: 33, 150, 243;
--mush-rgb-light-blue: 3, 169, 244;
--mush-rgb-cyan: 0, 188, 212;
--mush-rgb-teal: 0, 150, 136;
--mush-rgb-green: 76, 175, 80;
--mush-rgb-light-green: 139, 195, 74;
--mush-rgb-lime: 205, 220, 57;
--mush-rgb-yellow: 255, 235, 59;
--mush-rgb-amber: 255, 193, 7;
--mush-rgb-orange: 255, 152, 0;
--mush-rgb-deep-orange: 255, 87, 34;
--mush-rgb-brown: 121, 85, 72;
--mush-rgb-grey: 158, 158, 158;
--mush-rgb-blue-grey: 96, 125, 139;
--mush-rgb-black: 0, 0, 0;
--mush-rgb-white: 255, 255, 255;

# customize the lock colors here
--mush-rgb-state-lock-locked: var(--mush-rgb-red);
--mush-rgb-state-lock-unlocked: var(--mush-rgb-green);
--mush-rgb-state-lock-pending: var(--mush-rgb-orange);

You can also theme the card using card mod (if you want to customize a card locally)
type: custom:mushroom-lock-card
entity: lock.door
card_mod:
  style: |
    :host {
          --rgb-state-lock-locked: var(--rgb-red);
          --rgb-state-lock-unlocked: var(--rgb-green);
          --rgb-state-lock-pending: var(--rgb-orange);
    }

Thanks Paul.
A question on this...   If I wanted to add this to my theme yaml code
where would it go?  I have multiple themes. My configuration.yaml file
has this entry:
themes: !include_dir_merge_named themes
I have a /config/themes directory and that is where the Mushroom
directory is (along with directories for my other themes).
Do I create a Themes.yaml file in the root of the themes directory and
put your code below there?
Thanks,
fj
On 4/25/2022 1:31 PM, Paul Bottein wrote:

Hi 🙂
Thanks for your feedback. I don't have a lock so I don't known what is
the best solution about colors 😅
Your can customize the lock colors in your |theme.yaml| file
--mush-rgb-red:244, 67, 54;
--mush-rgb-pink:233, 30, 99;
--mush-rgb-purple:156, 39, 176;
--mush-rgb-deep-purple:103, 58, 183;
--mush-rgb-indigo:63, 81, 181;
--mush-rgb-blue:33, 150, 243;
--mush-rgb-light-blue:3, 169, 244;
--mush-rgb-cyan:0, 188, 212;
--mush-rgb-teal:0, 150, 136;
--mush-rgb-green:76, 175, 80;
--mush-rgb-light-green:139, 195, 74;
--mush-rgb-lime:205, 220, 57;
--mush-rgb-yellow:255, 235, 59;
--mush-rgb-amber:255, 193, 7;
--mush-rgb-orange:255, 152, 0;
--mush-rgb-deep-orange:255, 87, 34;
--mush-rgb-brown:121, 85, 72;
--mush-rgb-grey:158, 158, 158;
--mush-rgb-blue-grey:96, 125, 139;
--mush-rgb-black:0, 0, 0;
--mush-rgb-white:255, 255, 255;
customize the lock colors here
--mush-rgb-state-lock-locked:var(--mush-rgb-red);
--mush-rgb-state-lock-unlocked:var(--mush-rgb-green);
--mush-rgb-state-lock-pending:var(--mush-rgb-orange);
You can also theme the card using card mod (if you want to customize a
card locally)
|type: custom:mushroom-lock-card entity: lock.door card_mod: style: |
:host { --rgb-state-lock-locked: var(--rgb-red);
--rgb-state-lock-unlocked: var(--rgb-green); --rgb-state-lock-pending:
var(--rgb-orange); } |
—
Reply to this email directly, view it on GitHub
https://github.com/piitaya/lovelace-mushroom/issues/351#issuecomment-1108848051,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS5E4DRJOUW7C5AJQDJM7IDVG3JFNANCNFSM5TUC2S6Q.
You are receiving this because you commented.Message ID:
@.***>

Hi 🙂 Thanks for your feedback. I don't have a lock so I don't known what is the best solution about colors 😅 But Mushroom allow theme support to fit most of usage 🙂
Your can customize the lock colors in your theme.yaml file
--mush-rgb-red: 244, 67, 54;
--mush-rgb-pink: 233, 30, 99;
--mush-rgb-purple: 156, 39, 176;
--mush-rgb-deep-purple: 103, 58, 183;
--mush-rgb-indigo: 63, 81, 181;
--mush-rgb-blue: 33, 150, 243;
--mush-rgb-light-blue: 3, 169, 244;
--mush-rgb-cyan: 0, 188, 212;
--mush-rgb-teal: 0, 150, 136;
--mush-rgb-green: 76, 175, 80;
--mush-rgb-light-green: 139, 195, 74;
--mush-rgb-lime: 205, 220, 57;
--mush-rgb-yellow: 255, 235, 59;
--mush-rgb-amber: 255, 193, 7;
--mush-rgb-orange: 255, 152, 0;
--mush-rgb-deep-orange: 255, 87, 34;
--mush-rgb-brown: 121, 85, 72;
--mush-rgb-grey: 158, 158, 158;
--mush-rgb-blue-grey: 96, 125, 139;
--mush-rgb-black: 0, 0, 0;
--mush-rgb-white: 255, 255, 255;

# customize the lock colors here
--mush-rgb-state-lock-locked: var(--mush-rgb-red);
--mush-rgb-state-lock-unlocked: var(--mush-rgb-green);
--mush-rgb-state-lock-pending: var(--mush-rgb-orange);

You can also theme the card using card mod (if you want to customize a card locally)
type: custom:mushroom-lock-card
entity: lock.door
card_mod:
  style: |
    :host {
          --rgb-state-lock-locked: var(--rgb-red);
          --rgb-state-lock-unlocked: var(--rgb-green);
          --rgb-state-lock-pending: var(--rgb-orange);
    }

This didn't work. I created a themes folder and inserted there a file "mushroom.yaml" then added Mushroom: at the top with the indented text you posted above so with the rgb colors. After a restart I cannot see the color changing of the door lock card. And card-mod did also not work. But with other card it works, for example in the alarm card i can change the text to red with card-mod. So how exactly this works? Can you please explain? :)

@dayt47
Here you can view an example with mushroom-alarm card where both color and icon are changing according to state.
type: custom:mushroom-alarm-control-panel-card
states:
  - armed_away
entity: alarm_control_panel.fake_alarm
show_keypad: true
card_mod:
  style: >
    ha-card {
    --card-mod-icon: {{ 'mdi:shield-off-outline' if
    (states('alarm_control_panel.fake_alarm') == 'disarmed')else
    'mdi:shield-check-outline'}};
    --rgb-state-alarm-armed: var(--rgb-green);
    --rgb-state-alarm-disarmed: var(--rgb-red);
    }

Same strategy for mushroom-lock
type: custom:mushroom-lock-card
entity: lock.kitchen_climate_away_mode
card_mod:
  style: >
    ha-card {
    --rgb-state-lock-locked: var(--rgb-yellow);
    --rgb-state-lock-unlocked: var(--rgb-blue);
    }

Make sure to install card_mod

thank you @amaciuc that works! The problem was the word "host" which should be replaced with "ha-card", like you did. And before ha-card there is no colon but afterwards. So the code from @piitaya was wrong. But now everything works, thanks :)


Using pcf pipelines v0.16 to deploy pcf

Job upload and stage ert fails.
Error
pcf-pipelines/tasks/stage-product/task.sh: line 19: ./pivnet-product/metadata.json: No such file or directory
Is this file part of the pivnet resource?
I noticed the resource this job is using is:
source:
repository: czero/cflinuxfs2
I deployed a simple pipeline with

name: pivnet
type: docker-image
source:
repository: pivotalcf/pivnet-resource
tag: latest-final

And this file exists.
Is there an error in this version?

Hey @filidav I had a quick look at this. You are correct that the pivnet resource generates the metadata file. What is happening is since you aren't using the pivnet resource in your pipelines, this task.sh fails.
The upshot for PCF pipelines is that the method being used now ONLY works if the customer is getting their artifacts directly from pivnet. If they are using S3/artifactory/nexus/other they can't use use this task.
cc: @christianang

Thanks Ian
I guess the artifactory job is used as an input  to this task and that is why it is failing?
I guess my only option is to go direct to pivnet and hardcode the version I want in the   Param file.
What version did this change?  I was thinking of trying v15 of the pipelines with Artifactory .
David Filippelli
On Sep 22, 2017, at 5:16 PM, Ian Zink <notifications<EMAIL_ADDRESS>wrote:
Hey @filidavhttps://github.com/filidav I had a quick look at this. You are correct that the pivnet resource generates the metadata file. What is happening is since you aren't using the pivnet resource in your pipelines, this task.sh fails.
The upshot for PCF pipelines is that the method being used now ONLY works if the customer is getting their artifacts directly from pivnet. If they are using S3/artifactory/nexus/other they can't use use this task.
cc: @christiananghttps://github.com/christianang
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/pivotal-cf/pcf-pipelines/issues/192#issuecomment-331562585, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AWJsOgjIbstYHRXkt0NfSVNs1EyFe5cEks5slCObgaJpZM4PhLvp.
STATEMENT OF CONFIDENTIALITY The information contained in this email message and any attachments may be confidential and legally privileged and is intended for the use of the addressee(s) only. If you are not an intended recipient, please: (1) notify me immediately by replying to this message; (2) do not use, disseminate, distribute or reproduce any part of the message or any attachment; and (3) destroy all copies of this message and any attachments.

I see. Not sure which version this changed in, but it does sound like we need to reevaluate how we get the version to support non-pivnet repositories.

Hi @filidav, just circling back to see if you were able to follow @svrc-pivotal's suggestion to make this work?

Yes we got it to work.
David Filippelli
On Oct 10, 2017, at 8:38 PM, abbyachau <notifications<EMAIL_ADDRESS>wrote:
Hi @filidavhttps://github.com/filidav, just circling back to see if you were able to follow @svrc-pivotalhttps://github.com/svrc-pivotal's suggestion to make this work?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/pivotal-cf/pcf-pipelines/issues/192#issuecomment-335647516, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AWJsOhBuP1m_FnOFvlS0juTQGSJ4U8QTks5srA4EgaJpZM4PhLvp.
STATEMENT OF CONFIDENTIALITY The information contained in this email message and any attachments may be confidential and legally privileged and is intended for the use of the addressee(s) only. If you are not an intended recipient, please: (1) notify me immediately by replying to this message; (2) do not use, disseminate, distribute or reproduce any part of the message or any attachment; and (3) destroy all copies of this message and any attachments.

Hi @filidav thanks for letting us know, much appreciated. @svrc-pivotal if you don't mind, we've added your recommendation to the Troubleshooting section on each of our install-pcf README pages.
@z4ce thanks for your help on this one. We don't plan on prioritising this issue because there appears to be a reasonable workaround. If you think otherwise, or if we hear there is a need from the field, we can review.
Closing this issue out as it is resolved but please do not hesitate to ping us/create a new issue if you have any feedback. Thanks!

@filidav wasn't the workaround you used to actually use the older code that inspected the download? Or are you actually pushing the metadata.json into artifactory?

Pushing the metadata,json and then getting it.
In upgrade ERT pipeline

task: version-metadata
file: pcf-pipelines/tasks/version-metadata/task.yml

put: elastic-runtime-metadata-artifactory
params: { file: "./pivnet-product-meta/metadata-*.json" }

name: upload-ert
serial: true
plan:

aggregate:

get: pcf-pipelines

get: pivnet-product
params:
globs:

"*pivotal"
"metadata*.json"

task.yml
platform: linux
image_resource:
type: docker-image
source: {repository: czero/cflinuxfs2}
inputs:

name: pcf-pipelines
name: pivnet-product
outputs:
name: pivnet-product-meta

params:
run:
macC02T61C9H03Q:upgrade-ert filidav$ cat ../tasks/version-metadata/task.sh
#!/bin/bash
set -eux
Copyright 2017-Present Pivotal Software, Inc. All rights reserved.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
function main() {
local cwd
cwd="${1}"
cp ${cwd}/pivnet-product/metadata.json ${cwd}/pivnet-product-meta/metadata-$(date '+%s').json
}
main "${PWD}"
David Filippelli | Platform Engineer, Provisioning + Pipelines, Global Solutions Delivery
250 Bloor Street East | Toronto, Ontario, M4W 1E5  | M.<PHONE_NUMBER>
David_Filippelli<EMAIL_ADDRESS>| manulife.comhttp://www.manulife.com/
Have a question? Want to know how we deliver?
Check out our Playbookhttps://mfc.sharepoint.com/sites/GEO/playbook and be a part of the community!
<EMAIL_ADDRESS>From: Ian Zink<EMAIL_ADDRESS>Reply-To: pivotal-cf/pcf-pipelines<EMAIL_ADDRESS>Date: Wednesday, October 11, 2017 at 1:13 PM
To: pivotal-cf/pcf-pipelines<EMAIL_ADDRESS>Cc: David Filippelli<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [pivotal-cf/pcf-pipelines] Using pcf pipelines v0.16 to deploy pcf (#192)
@filidavhttps://github.com/filidav wasn't the workaround you used to actually use the older code that inspected the download? Or are you actually pushing the metadata.json into artifactory?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/pivotal-cf/pcf-pipelines/issues/192#issuecomment-335881407, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AWJsOiT-dr3lxL3dcQ8ykVvVs5z7k5GWks5srPdAgaJpZM4PhLvp.
STATEMENT OF CONFIDENTIALITY The information contained in this email message and any attachments may be confidential and legally privileged and is intended for the use of the addressee(s) only. If you are not an intended recipient, please: (1) notify me immediately by replying to this message; (2) do not use, disseminate, distribute or reproduce any part of the message or any attachment; and (3) destroy all copies of this message and any attachments.

@z4ce we're actually pushing metadata.json into artifactory in this case, to stay current

Thanks, follow up story to this issue is here: https://www.pivotaltracker.com/story/show/151900831.

https://network.pivotal.io/products/pcf-automation does not exist