resized search bar, added scroll to top button

Closes issue #28

Changes proposed
Check List (Check all the applicable boxes)

[ X] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers
The scroll-to-top button works as intended the only issue being that it resizes with the window something I mistakenly implemented while trying to find a workaround to the search bar and scroll to top button overlapping on window resize

@JJJ62  seems like you pushed all unnecessary changes. (nodemodules, and all together 139 files). Please remove all the changes and leave only the ones are required.  That's also the reason why devops deploy is failed.


/gcbrun for running experiments

To make it easier for everybody (including trusted external contributors) to launch experiments, we should support a similar /gcbrun to oss-fuzz for launching an experiment from a PR.

We can likely reuse parts of https://github.com/google/oss-fuzz/blob/28760cff6b5a318480357ba96bea9a3263c470ae/infra/build/functions/ci_trial_build.py#L17


Avoid repeated requests to cryptokitties api

I've noticed the cryptokitties api is degrading in performance (or is it just me, in central Europe?). I doubt it's because of this addon, but still.
Perhaps the addon could store the results of past api calls in localstorage, as a service to the nice people developing cryptokitties (who probably haven't slept for a few days now). It would also improve user experience a great deal.

I'm working on this now. How many of the past kitties do think would be a good idea to store? I think if you stored all of them that would be bad once you start getting to 20k+. I was thinking keeping the 1000 most recent.

Ah, didn't see your comment till I already made the pull request :) That's a good question.
localStorage is tricky because you can only save key value pairs, no objects. My solution was to JSON.stringify it, but keeping tabs on how many you have stored would mean searching through the localStorage keys for the pattern kitty-{id} and deleting it based on the cache age, I guess?

I think I have a nice solution that has two tables. One that always stores your own kitties and one that stores the 1000 most recent.

That seems logical. Looking forward to seeing something, the site is less and less accessible it seems :)

Uploaded new version please let me know how it goes. Was a little hard to test with how slow the site was.

Nice!  Seems to be working well for me.  I ran it across my 10 cats and it grabbed data for 3 of them.  The others timed out due to network load.  Then I reloaded the page and ran it across all 10 again -- and those 3 immediately popped up -- and the others started trying to grab data again.
So, the caching seems to work -- and really makes a difference in relieving some load.  Thanks!

Thanks. I will add a failure indicator next  @jgoggan

Looks like everything is good now 👍

How to access to API, is it document?
Thanks


Tab expansion not working in XML files

Open an HTML file, write page and press TAB: <page></page>.
Do the same in an XML file and nothing will happen.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

I too am having this issue. My workaround is too set the language to HTML and then tab completion works.

This was never implemented. Please look at the Tab key section in the readme file.


Update gcr.io/k8s-prow/git base image

This PR updates gcr.io/k8s-prow/git:v20240129-a0a4e743bf base images to gcr.io/k8s-prow/git:v20240729-4f255edb07 which is the latest version.
The current version include CVE-2024-6387. While sshd is not started in the context, it still triggers security incidents in our scanners.

/ok-to-test


080 universal decimal classification number

https://github.com/uwlib-cams/MARC2RDA/blob/main/Working Documents/0XX.csv

@GordonDunsire In 080 and other classification fields where the scheme does not have an IRI in LC, should the scheme just be the text value? So for 080 what would  “udc” + “Full” + $2 look like in practice as the value of skos:inScheme?

What is the best way to combine $a and $x for the notation and label? X can be repeated and have different delimiters, such as in this LC example: 080 | ##$a94$x(474)$x”19"$x(075)$2[edition information]

Additionally, if ind1 is blank, shouldn't the scheme just be "udc" + $2 without "full" or "abridged"?

@cspayne: To combine subfields $a and $x and repeats just remove the subfield codes and concatenate the values in order of appearance. For your LC example, this gives:
94(474)"19"(075)
All embedded punctuation is part of the UDC notation. This includes the slash '/' which is used to truncate a Dewey number; in UDC it indicates a range of classes (a 'consecutive extension'). So another LC example, 080 ## $a971.1/.2 is for the UDC notation:
971.1/.2
Yes, for ind1 = blank/#, generate the scheme label 'UDC'.

All embedded punctuation is part of the UDC notation. This includes the slash '/' which is used to truncate a Dewey number; in UDC it indicates a range of classes (a 'consecutive extension'). So another LC example, 080 ## $a971.1/.2 is for the UDC notation:

In this case, is it safe to mint IRIs with punctuation removed?

Yes, for ind1 = blank/#, generate the scheme label 'UDC'.

Should this still be <skos:inScheme>UDC; [edition]</skos:inScheme>  or just using the LC IRI http://id.loc.gov/vocabulary/classSchemes/udc

@cspayne: I think we need to see an extract of UDC values to determine the effect of removing the punctuation, say 100 instances? (I suspect the punctuation needs to be retained in the IRI, but let's check.)
Good catch for ind1 = blank/#; yes, we can use the LC IRI.

@GordonDunsire
I pulled all of the 080 fields from the shakespeare.xml file and ran them. Output is here.  I serialized the results as turtle to de-duplicate and it looks like the bigger issue is inconsistent spacing (see http://marc2rda.edu/fake/concept/udc/821111shakespearewilliam09, http://marc2rda.edu/fake/concept/udc/821111shakespearewilliam107, http://marc2rda.edu/fake/concept/udc/821111shakespearewilliam, and http://marc2rda.edu/fake/concept/udc/8211112091516).

@cspayne: I don't think the spacing is significant for our context. It is not listed in the UDC table of punctuation for auxiliary/common/qualifier numbers; see UDC Structure & tables 2.1 Common auxiliary signs. I suspect the main cause of inconsistent spacing is that it is permitted for text-based qualifiers or that local applications add spaces for 'readability' or user-friendliness.
I don't know what the UDC manual says about spaces, or what examples it gives, but I think the de-duplication utility of the transform is more important than a minor difference in spaces in the notation or label.
My main concern was that two distinct classifications are collapsed into one IRI if the punctuation is removed. For example, '12.345(6).789' and '123.4(567).89' are potentially correct but distinct UDC classifications. I think my suggested sample size was too small to safely determine this, although the test output supports the assumption. I will ask the UDC Consortium for confirmation.
Meanwhile, if 'correct' punctuation (from the UDC table) is retained in the IRI (but spaces excluded), does the test set de-duplicate to the same, more, or less degree? This is our fall-back approach.

Meanwhile, if 'correct' punctuation (from the UDC table) is retained in the IRI (but spaces excluded), does the test set de-duplicate to the same, more, or less degree? This is our fall-back approach.

@GordonDunsire If punctuation is retained (and put through the encode-for-uri() function to process the punctuation and produce a valid IRI), the test set de-duplicates the same amount :)
I also tested removing spaces from the notations and labels, which solved the problem of having multiple values there.
Updated test output is here

@cspayne: Great! Let's go with the retained punctuation approach; the IRIs do not seem be 'too' long :-)


Some of the filters are kinda useless

I think the problem is with our resolvers, not with the queries or anything we're doing here, but I believe that filters like sourceDbName on interactions are fetching all interactions for genes that have an interaction provided by that source -- rather than fetching just those interactions provided by that source. Ditto pmid and interactionTypes.
I would lean towards removing them for now for this reason -- because they aren't super helpful like this.

actually just moving this to #3


Small edits to soak tests

Description
Follow up to #65, we make some small edits to the Soak Tests:

Delete oldest snapshots in the commits/<current_commit_id>/runs/ folder as well as the commits/ folder.
With https://github.com/JasonEtco/create-an-issue/pull/114 merged, we can use the upstream JasonEtco/create-an-issue action again! (This will be broken until the next minor release)

In the long run, e.g. when upstreaming, could we extract all of these tests into an action so that we don't have to update every repo with each change?

Totally! That would be an awesome improvement 😄
I think they are well set up to be made into an action. We saw the translation to the rest of the repos go fairly smoothly, so off the top of my head as an action it would need to know the following:

The commit at which to checkout the current repo
The location on the current repo for each Sample App to build and Soak Test
A unique way to identify each Sample App (Usually "platform framework" + "auto/manual instrumentation")
AWS credentials
The Process executable name and command line command to identify the process (although  maybe we could find this out independently by checking our the diff of actual vs expected processes on a runner)
Whether to include the otlp metrics receiver (for now while some languages don't have them)

And I just realized we should probably make all the Soak Tests use OTEL_EXPORTER_OTLP_ENDPOINT=http://otel:4317 because some using http://, grpc:// or nothing at all.. I added it to this PR but it's not an urgent fix I would say 😄


Compiler errors on Ubuntu 20.04

The fix for Ubuntu 16 seems to break building TrafficServer on Ubuntu 20, with gcc and clang, as far as I can tell.
I don't know why that change was made since there is no issue associated to the PR. This is the error I get compiling on Ubuntu 20.04:
ink_res_init.cc:97:3: error: excess elements in scalar initializer
  {HOST_RES_PREFER_IPV4, HOST_RES_PREFER_IPV6, HOST_RES_PREFER_NONE}};
  ^                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

These are the commands I run:
./configure CXXFLAGS=-std=c++17 CC=clang CXX=clang++
make

I've tried with Clang 10(default version in Ubuntu 20), Clang 9, and GCC 9.3.0(default version in Ubuntu 20).

I can have a look at this, as seems related to a change I introduced #6820

This change was reverted on 9, and I've tried the three compilers you've mentioned with no issues.


Add social sharing icons on Photo detail page

Add social sharing icons on Photo detail page

Hi, I would like to work on this


Reduce margins on admin pages

Reduce margins around admin boxes and reduce sidebar size from 275px to 240px. This is the same 16px margin we use on issue pages.
Before and After:

More pages will need this treatment, I'll do them in another PR.


Update lds.py

Seems like this should be changed to verbose as well to allow total suppression of output

Thanks, Grace!


Various fixes and new utilities

Here are some fixes and new additions to Lumen.  Let me know if you don't want some of these or want me to rework anything.
Fixes:

bin/lumen correctly handles spaces in pwd
For Lua hosts, fixed read-file and write-file to explicitly close the file before returning a result
Added (code ".") to valid-code? in compiler.l, which fixes compiling foo.bar expressions

(E.g. ffi.load was incorrectly compiling to ffi63load rather than foo.load, which was causing errors when loading the motor lib)

Additions to bin/lumen:

Users can prepend to LUA_PATH and NODE_PATH when invoking lumen

(E.g. LUA_PATH="$(pwd)/some/path/to/?.lua" lumen)

Automatically add $DIR/lib/$PLATFORM to NODE_PATH and $DIR/lib/$PLATFORM/?.lua to LUA_PATH

(E.g. No longer need to run lumen like LUA_PATH="$(pwd)/lib/darwin/?.lua" lumen when loading the motor lib)

Additions to compiler.l:

New fns: compile-string, expand-string, load-string
New exports: run, compile-string, expand-string, load-string

Additions to runtime.l:

(file-exists? filename) returns true if the filename is a valid file, else false
(read-env varname) returns the value of the environment variable varname

read-env isn't a good name for this

(user-path path) returns the absolute path to the user's home dir, joined with path (if non-nil)
(lumen-path path) returns the absolute path to lumen's dir, joined with path (if non-nil)
The path-sep global is "\\" on Windows, else "/"
The windows? global is true on Windows, else false

This is great! I think I'll cherry-pick the ones that are good-to-go and we can discuss the remainder.

Sounds good.  This workflow we discovered seems to have a lot of benefits, so I'll keep following it:

Each time I send a PR to you, I'll try to ensure all commits are atomic and unrelated to prior commits, i.e. each commit will be a standalone bugfix, tweak, or new feature.

That way each PR is essentially a "collection of good and bad ideas."  And since each idea is a single commit, it will always be easy to merge or ignore each of them individually.

When you're finished merging some subset of the PR, I'll merge your tweaks / improvements from sctb/lumen into laarc/lumen@master.  Then I'll create a new branch off of master and continue working.  GOTO 1.

A lovely facet of this workflow is that after I open a PR, I can continue adding fixes and features to it; nothing is time-sensitive.  Please feel free to ignore the PRs whenever you're busy with other things.
(And of course, please ruthlessly reject all the bad ideas.  My only goal is to help make Lumen better, and you're the best judge of "better."  So I won't mind in the slightest if e.g. an entire PR ends up being rejected.)


[WIP] Keyboard tests

Now that we are possible to easily mock keyboard events, it's time to test the keyboard event handlers.
As the title says this is still work in progress, but feedback is wanted.

YES! This will be hugely helpful

Fixed an issue with https://github.com/zurb/foundation-sites/pull/9971/commits/53b82e1e11d4020a788a005592cdeb52e2af08d7.
@kball As far as I see there are now keyboard tests for every plugin that uses the Keyboard Util.
Do you agree that this make the PR merge-able?

This is excellent. Nice work @Owlbertz


[Improvement] - Attaching multiple files have the same tab name

#3 works great (I really appreciate the fast turnaround on that 😄 ) - it now correctly finds multiple files if you pass in a directory. However, if you do add multiple reports, it displays them all with the same name.

An improvement would be to somehow allow passing in multiple names, or possibly just making the tab name the file name.
Rough idea for the latter:
const isDir = statSync(reportInputPath).isDirectory();
...
            const attachmentProperties = {
                name: generateAttachmentName(basename(file), isDir),
                type: 'report-html',
                path: file
            };
...

function generateAttachmentName(fileName, isDirectory) {
    const jobName = dashify(tl.getVariable('Agent.JobName'));
    const stageName = dashify(tl.getVariable('System.StageDisplayName'));
    const stageAttempt = tl.getVariable('System.StageAttempt');
    let tabName;
    if (isDirectory) {
      tabName = fileName.split('/').at(-1);
    } else {
      tabName = tl.getInput('tabName', false) || 'Html-Report';
    }
    return `${tabName}.${jobName}.${stageName}.${stageAttempt}.${fileName}`;
}

Although, to be honest, I'm not 100% on how the attachment name works.

Filename based report tabs now enabled by default, Marketplace extension bumped to v1.2.1


Some GIT commands do not show password prompt

Preconditions

I'm working with a password protected Git repo in VS Code
I open command pallet (F1) and execute a Git command

Now most commands like pull, push, etc. correctly asks for a password by showing a UI password prompt.
Issue
However, certain commands like fetch, etc. do not ask for a password by showing a UI password prompt and fails with error Git: Missing or invalid credentials.

I see File:extensions/git/src/askpass-main.ts Line:31 explicitly skips the fetch command. Any particular reason for this?

We skip fetch since it's done automatically behind the scenes, most of the time. We should probably change the check to make sure it is only skipped if the fetch is automatic (vs manually).

I had the same problem. Cannot type my prompt password anymore. Have any workaround without set a credentials? Thanks.


Use Sun Valley Entry Box

I only tested this on windows so you should probably test it on windows before considering to merge it.

i only tested this on macos so you should maybe see how it looks on windows

Can you send a screenshot of the preview? I mean, clone your fork of TimerX, install all requirements, start the app and take a screenshot, so that we could know what to expect and what not to expect.

Sure!

i deleted my fork to open another pr is that bad?

@not-nef Hi! Thank you so much for opening this PR, I wanted to do this since forever, but other things  came in the way. In the future, instead of deleting forks, try making branches so you can make multiple PRs properly. Ialso did this mistake the first tome I opened a PR. Thabk you, I will merge when I get on my Pc today or tommorow

That's good, well do a final test and then @sumeshir26 can merge.

@not-nef Hi! Thank you so much for opening this PR, I wanted to do this since forever, but other things  came in the way. In the future, instead of deleting forks, try making branches so you can make multiple PRs properly. Ialso did this mistake the first tome I opened a PR. Thabk you, I will merge when I get on my Pc today or tommorow

I tried making a branch for the banner pr, but it also contained the commits for this pr

Hmm... Can you grant me collaborator access to your fork? Maybe I could help.

I know what the problem is as well as the solution. First, I'll test, then I'll go ahead with my plan.

Hmm... Can you grant me collaborator access to your fork? Maybe I could help.

That fork no longer exists lmao

i only have the fork for the banner pr

Grant me collaborator access to that, I'll manage the rest :wink:

oke, gimme a sec

done

@im-coder-lg

I have a good idea, working on that now.

cool

@not-nef close this PR, we'll manage this in #18


Fix exclusivity diagnostics to be aware of [dynamically_replaceable].

Fix exclusivity diagnostics to be aware of [dynamically_replaceable].
Previously, any function marked [dynamically_replaceable] that was
partially applied and captured by address would not be diagnosed.
This is a rare thing. For example:
struct S {
var x = 0
public mutating func testCallDynamic() {
dynamic func bar(_ i: inout Int) {
i = 1
x = 2
}
bar(&x)
}
}
Fixes rdar://problem/50972786 Fix exclusivity diagnostics to be
aware of [dynamically_replaceable].

@swift-ci test.

@aschwaighofer can I merge this?


Can't search for categories

When I try to find a category in the search menu it doesn't show up, it only shows results of the components themselve.
How to recreate the bug

Open once again https://codepen.io/Ni55aN/pen/jBEKBQ.
Left-click on the white background to bring up the menu.
Type in the word 'Values' in the search bar and you'll find it doesn't show up.

This probably isn't a major bug to solve but it'll get tricky when looking for submenus inside of submenus, but I'm sure you'll be able to figure it out.
P.S. When just typing in Value, it doesn't directly show the component Value, but it shows the submenu which leads to 'Value'. I don't know if this is by design but it would be a lot easier if you were taken straight to the actual component.

d655676668f9e439d95caa551f73569529010b9e


Improve the 4x4 sudoku solver.

Implement:

Make the solver responsive.
The input data is shown as Black digits in the solution.
The answer data(solved by the solver) is shown as blue coloured digits in the solution.
Currently the reset function is not working correctly in terms of resetting the colours(it makes everything black). Fix it such that points 2 and 3 are maintained.
Remove the Submit button(it is made reduntant by the "solve sudoku" button)
Add the solve animation of 9x9 solver.

Assign me under JWOC 2024.

@SohanRC Go for it!


Update README.md

feature json should be included otherwise Json can't be found in the above example.

The usage section is distinct from the section above it, which is why they're in different sections. That is, the two examples are not related.

@SergioBenitez I know they are separate, but why not be more user friendly?

It's the exact real tiny issue I met when using your lib for the first time.

I think part of the reason why I didn't enable JSON in that example is to show that these are distinct features. I don't know - I don't really have an argument one way or another, I just don't think it's confusing.

I think part of the reason why I didn't enable JSON in that example is to show that these are distinct features. That is, that you don't need json. I don't know - I don't really have an argument one way or another, I just don't think it's confusing.

People tend to follow example codes in readme so consistency is good.
If that's your point then env is not needed either.

That's it.


SwiftPM usage has docc included in build files

I get the error
AcknowList
found 1 file(s) which are unhandled; explicitly declare them as resources or exclude from the target
    /Users/xxx/Library/Developer/Xcode/DerivedData/xxx/SourcePackages/checkouts/AcknowList/Sources/AcknowList/AcknowList.docc

It seems that the docc needs to be explicitly removed from the SwiftPM package or marked as not a build file.

Hello Joel, thank you for reporting this!


Installing packages error

Seems something is wrong with base_path, I applied these changes and it seems to work:
diff --git a/sources/admin/PackageActions.class.php b/sources/admin/PackageActions.class.php
index 00a58a7..bf08fd6 100644
--- a/sources/admin/PackageActions.class.php
+++ b/sources/admin/PackageActions.class.php
@@ -757,7 +757,7 @@ class Package_Actions extends Action_Controller

 		if (!empty($this->_action['filename']))
 		{
-			$mod_actions = parseModification(file_get_contents(BOARDDIR . '/packages/temp/' . $context['base_path'] . $this->_action['filename']), false, $this->_action['reverse'], $this->_theme_paths);
+			$mod_actions = parseModification(file_get_contents(BOARDDIR . '/packages/temp/' . $this->_base_path . $this->_action['filename']), false, $this->_action['reverse'], $this->_theme_paths);

 			// Any errors worth noting?
 			foreach ($mod_actions as $key => $action)
@@ -788,8 +788,8 @@ class Package_Actions extends Action_Controller
 			global $context;

 			// Now include the file and be done with it ;).
-			if (file_exists(BOARDDIR . '/packages/temp/' . $context['base_path'] . $this->_action['filename']))
-				require(BOARDDIR . '/packages/temp/' . $context['base_path'] . $this->_action['filename']);
+			if (file_exists(BOARDDIR . '/packages/temp/' . $this->_base_path . $this->_action['filename']))
+				require(BOARDDIR . '/packages/temp/' . $this->_base_path . $this->_action['filename']);
 		}
 	}

@@ -836,8 +836,8 @@ class Package_Actions extends Action_Controller
 			global $context;

 			// Let the file work its magic ;)
-			if (file_exists(BOARDDIR . '/packages/temp/' . $context['base_path'] . $this->_action['filename']))
-				require(BOARDDIR . '/packages/temp/' . $context['base_path'] . $this->_action['filename']);
+			if (file_exists(BOARDDIR . '/packages/temp/' . $this->_base_path . $this->_action['filename']))
+				require(BOARDDIR . '/packages/temp/' . $this->_base_path . $this->_action['filename']);
 		}
 	}

@@ -852,8 +852,8 @@ class Package_Actions extends Action_Controller
 		if ($this->_action['type'] === 'redirect' && !empty($this->_action['redirect_url']))
 		{
 			$context['redirect_url'] = $this->_action['redirect_url'];
-			$context['redirect_text'] = !empty($this->_action['filename']) && file_exists(BOARDDIR . '/packages/temp/' . $context['base_path'] . $this->_action['filename'])
-				? file_get_contents(BOARDDIR . '/packages/temp/' . $context['base_path'] . $this->_action['filename'])
+			$context['redirect_text'] = !empty($this->_action['filename']) && file_exists(BOARDDIR . '/packages/temp/' . $this->_base_path . $this->_action['filename'])
+				? file_get_contents(BOARDDIR . '/packages/temp/' . $this->_base_path . $this->_action['filename'])
 				: ($this->_uninstalling ? $txt['package_uninstall_done'] : $txt['package_installed_done']);
 			$context['redirect_timeout'] = $this->_action['redirect_timeout'];

Just looks like a refactoring error, you know me may have one or two :tongue:
Anyway good catch and debug !


feat(ui): Added theme toggle button

PR Title

The purpose of this Pull Request is to fix #8
Description
Added theme toggle button in the navbar
Not fixed

Didnt't added colour scheme
you can add your colours in the src/App.js file

@MunavvarSinan thank you contributing to this project, the color you are supposed to add is #191B1C for the background, please add this to pull req

@MunavvarSinan are you working on the changes requested?


Prevent pixelation of small images by displaying it in orignal size by default

Adding small images features.
If image is smaller than container:
-display it in its original size
-hide snap view until it's enough zoomed to be bigger than container
This work has been done to fix (partially) existing issue: https://github.com/s-yadav/iv-viewer/issues/22
Big thank you to Nuno Freire (@nfcf on github) for his two commits used in that fork:
-https://github.com/nfcf/iv-viewer/commit/cf76a78fab8f68025fb02cb1d236f2c60a499a45
-https://github.com/nfcf/iv-viewer/commit/8564e9bd4c798dc9db52e6fe298f1a2e59e48e11

Thanks for pulling out this PR. I will check and get this merged.


Run tags through message-matcher

Somewhat related to deathandmayhem/jolly-roger#610, but perhaps that's the better implementation.
Options are:

Also run the matching on tagAdd events
Per-hunt setting to only run the matching on tagAdd events
Special tag-prefix to run matching on (needs:, skills:, etc)
Special dingword prefix to run it only on tagAdd events (e.g. tag:crossword)
Per-user opt-in to match on messages only, tags only, or both

Given that we want this to be as easy as possible, my instinct is to just run it on addPuzzleTag calls.


Service: Align to upstream.

Tests on workload clusters (not always required)
For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider
AWS
Azure
KVM

Upgrade from previous version
✓
✓

Existing Ingress resources are reconciled correctly
✓
✓

Fresh install
✓
✓

Fresh Ingress resources are reconciled correctly
✓
✓

Testing was done using hello-world-app.
Hint for KVM:
kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:<IP_ADDRESS>:8080" "http://$ingress_domain" -v

Note for reviewers: I did not align the change in the service's name nor the way we're deciding wether to add node ports or not. The latter would break KVM and will be aligned once I aligned all non-breaking changes (which can be released in minor releases).

Did the basic testing on AWS and Azure now, will do some extended testing (migration, new features etc.) on AWS only.

I literally tested every commit now. Looks good.


Is the form submitted ? why not?

7.0.2

Configuration
multiscrape:
    resource: https://www.ideco.com.jo/portal/WebForms/SubscriberReceivableLinks.aspx
    log_response: true
    name: 'ideco'
    scan_interval: 3600
    form_submit:
      submit_once: True
      resource: "https://www.ideco.com.jo/portal/WebForms/SubscriberReceivableLinks.aspx"
      select: "#ContentPlaceHolder1_Panel1"
      input:
        'ctl00$ContentPlaceHolder1$txtCustomerNo': '0120019332'
        'ctl00$ContentPlaceHolder1$btnGetInvoices2': ''
      input_filter:
      - 'ctl00$ContentPlaceHolder1$ddlCities'
      - '#__EVENTTARGET'
      - 'div.aspNetHidden:nth-child(9)'
      - 'div.aspNetHidden:nth-child(1)'
      - '#__EVENTARGUMENT'
      - '#__EVENTVALIDATION'
    sensor:
      - unique_id: IDECO
        name: IDECO
        select: "#ContentPlaceHolder1_txtCustomerNo"
        value_template: "{{ value | trim }}"
    headers:
      User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/109.0
Add your logs here.

Describe the bug
i really spent so much time trying to find out what is the issue and trying different combination from different soultion mentioned by others but no hope.
I wonder if you can help me get this to work. It is basically my electricity supplier website where I simply want to know when a new invoice is issued for my account, which I mentioned in the YAML code<PHONE_NUMBER>.
for some reason, the selector I put for the sensor, which is my account number, is empty while it should show my account number, as after submission, the number remains, for me I think this is a clue that the form was not submitted in the first place, which i can not understand at all.
Debug log
all is fine as the sensor was able to scrape with empty results, if i change the selector to the month number which i wont then i got a message saying that the tag of the selector is not available which make sense as the form was not submitted correctly

Add your logs here.

Please ask support questions on the community forum (and don't forget to add your logging).


Validating list of radio buttons not working

I really like this library. I want to get rid of jQuery from our website.
However I'm having issues validating groups of radio buttons with this library. I have a list of <input type=radio asp-for="@MyModel">. The model has [Required]-attribute. By default .net will render data-val and data-val-required attribute for the first input. But when I post the form the radio buttons are not validated. The form is sent even if no radio button option is selected. If i use <input type=text> the validation works fine.
This is something i think works out of the box with jquery.validate.unobtrusive.
Another issue is if I'm using a Validation summary @Html.ValidationSummary() and the form is validated on the client it will remove the header rendered by @Html.ValidationSummary(). It seems that the script replaces the content of the validation summary element instead of just updating the content of the ul-list.

Do you have a repro you can provide? Perhaps a model and some .cshtml markup that demonstrates the problem?

You can reproduce the problem with this simple HTML-code:
https://gist.github.com/andreasnylin/eea30c52e054da63c022884e580e8ee0


How can I get page css and js files when using jsdom

by html: I can set page source.
request('http://www.google.com', function(err, resp, body)
{
  jsdom.env(
  {
    html: _body,
    done: function (err, window)
    {
      console.log(body); // ok - content of the site
      // but how can I get content of external CSS file (they are linked in the page body)?
    }
  });
});

How can I get content of external css/js file via jsdom?

phantomjs-node

@donggw2030521 thanks!

You can find their URLs, e.g. using
const urls = [...window.document.querySelectorAll("script[src]")].map(el => el.src);

and then use normal Node.js techniques like http.get() or the request npm package to download them.


Questions on Experiment Data Details

Thanks for your great work. I am writing to you because I have a question regarding the experiment details in your paper "Resolving Interference When Merging Models". Specifically,  I want to reimplement your experiment where you finetune a T5-base/T5-large/IA3 on PAWS dataset and WCS dataset before merging them with your proposed approach.
From the huggingface dataset https://huggingface.co/datasets/paws, I noticed that the PAWS dataset has several splits available, including Labeled (Final), Labeled (Swap-only), and Unlabeled (Final). Could you please clarify which split was used in your experiments? Do you include Labeled (Swap-only) and Unlabeled (Final) for training as well, or just use the Labeled (Final) subset for training and evaluation?
For the WCS dataset, it seems that it only contains a very small-scale test set with a 273 rows version and a 285 rows version (https://huggingface.co/datasets/winograd_wsc). I wonder how you fine-tune T5-base/T5-large on this dataset and which version of test set (273 rows or 285 rows) do you use?

Hi Tingchen,
Thanks for asking the question.
As mentioned in the code here, for the paws dataset, we only use the "labeled_final" split for both training and testing. For more information, you can look at the dataset class here.
The wsc dataset is part of superglue, we use the wsc.fixed, and we use the train split (554 rows) to FT the checkpoints and for merging we split the validation split (104) into val and test. The corresponding code can be found here.
Most of the dataset details are available in the code but if you can't find it then feel free to ping me. Let me know if there are other questions!
Thanks,
Prateek Yadav


Losing Localization. Please help

Dear friend,
Thanks for the package.
I had tried using your package for localization where I found some drifts in localization even when Im fusing with IMU.
I used DIRECT7 method for registrationa and localization
NDT_OMP
I saved map at 0.01 resolution
when I try to localize i found some warning like
"Leaf size is too small for the input dataset. Integer indices would overflow."
I altered downsample_resolution and checked as well. Couldnt figure.I attached a localization config file screenshot.Please check.

Kindly help me to gain the accuracy.
Suggest me some steps.
Thanks a lot

Hi @vimalrajayyappan ,
Maybe your map is too large for voxelgrid filtering. Change VexelGrid in the following line to ApproximateVoxelGrid which can handle smaller resolutions.
https://github.com/koide3/hdl_localization/blob/624a7613d1639fefc0f67934e4f57dd2a8c9878f/apps/globalmap_server_nodelet.cpp#L58

Thanks a lot Koi.
Following which can you please share some values of params in Mapping&Localization and their insights. So that I can tune and check their optimality.
Another qn pls:
Should initial pose be highly accurate? Once I give the initial pose whether the algorithm tries to match the best position nearby, before I start moving?

The following guide would be helpful to tune the parameters.
https://github.com/koide3/hdl_graph_slam#the-mapping-result-is-poor-parameter-tuning-guide
The initial pose should be close to the actual pose (in particular, a large rotational error may affect the convergence). Once you give the initial pose, it updates the estimated pose even if the sensor is fixed.

ctual pose (in particular, a large rotational error may affect the convergence). Once you give the initial pose, it updates the estimated pose even if the sensor is fixed.

The following guide would be helpful to tune the parameters. https://github.com/koide3/hdl_graph_slam#the-mapping-result-is-poor-parameter-tuning-guide
The initial pose should be close to the actual pose (in particular, a large rotational error may affect the convergence). Once you give the initial pose, it updates the estimated pose even if the sensor is fixed.

Hi,
I have the same issue that called "Leaf size is too small for the input dataset. Integer indices would overflow."  Then I saw yor answer for that. When I try ApproximateVoxelGrid terminal issue gones but localization fail is continues. Can you help me for that?


Fix typos discovered by codespell

https://github.com/codespell-project/codespell

That's a lot of misspelled !


Remove trailing newline

Description
When I use the chef generate cookbook command and pass it a license --license 'apachev2' the resulting files fail a rubocop pass off the bat due to the file having an addtitional blankline in the following files.
recipes/default.rb:18:1: C: Layout/TrailingBlankLines: 1 trailing blank lines detected.
spec/unit/recipes/default_spec.rb:19:1: C: Layout/EmptyLines: Extra blank line detected.

Issues Resolved
This PR strips the trailing \n from the result variable.
I only noticed this today and haven't created an issue, happy to create one if you like
Check List
- [ ] New functionality includes tests

[x] All tests pass

- [ ] RELEASE_NOTES.md has been updated if required (not required for bugfixes, required for API changes)

[x] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

Thanks, @username-is-already-taken2 !


Identifier completion with syntax keywords

ycmd supports the feature to seed the identifier completion with syntax keywords.
@abingham Should we add this feature?
I have a branch with this feature implemented. Here is the diff: https://github.com/abingham/emacs-ycmd/compare/master...ptrv:syntax-keywords-support
The thing is that we need to supply the server with keywords and I haven't found a way to get the keywords from the mode, so I added a variable ycmd-get-syntax-keywords-function. The user needs to implement this to provide the keywords.
company-mode supports already a completion backend for keywords, but I think it is nicer if ycmd provides the keyword candidates itself instead of chaining completion backends.
Regarding ycmd-get-syntax-keywords-function it could be implemented the following ways:

Reusing the variable `company-keyword-alist:

(setq ycmd-syntax-keyword-function
      (lambda (mode)
          (assoc-default mode company-keyword-alist))

or loading keywods from files:

(setq ycmd-syntax-keyword-function
      (lambda (mode)
        (let ((filename (f-join "~/src/auto-complete/dict" (symbol-name mode))))
          (when (f-exists? filename)
            (let (result)
              (ignore-errors
                (with-temp-buffer
                  (insert-file-contents filename)
                  (setq result (s-split "\n" (buffer-string) t))))
              result)))))

I like this feature. It would be really useful for working with languages that don't have first-class ycmd support. We could even consider shipping pre-made syntax lists for languages with the client...we could let users supply them and we could just bundle them up (perhaps in a separate, related package). If you think this feature is ready to go - and it certainly looks fine to me - then let's merge it in.

On a related topic, we might think about encapsulating some of these "extra" features in their own packages. Features like "force-semantic", "tags", and this one all follow some similar patterns: they're optional, they add information to the "standard content", etc. It might make sense to split them out, if practical, into their own feature-specific files.
This isn't a fully-formed plan on my part, just an observation. A full-blown plugin system might be over-engineering, but it might be the way to go if we get many more of these kinds of optional features. What do you think?

Ok, I'll prepare the PR. I think the feature is ready to go, but still needs some documentation. I guess we can merge it as soon I added the info how to specify the get-syntax-keywords-function to the readme.
We could ship pre-made lists, like the package auto-complete is doing. At some point on my branch I was adding those too but removed them because I wasn't sure.
About the splitting of features, I am not sure, on the one hand it would improve readability I guess on the other it is still nice nice to have only one file because it is a self contained file. I personally did not feel the need to split out the parts while developing. I was also looking at other excellent packages like flycheck, they also have only one file.

Sounds good. I've been poking around with elm lately, so I'll be happy to
add an elm syntax file.
Regarding splitting out extra features, let's just keep things as they are
for now. There's definitely no strong need to make that kind of change
right now, and if you're happy with the state of things then we should just
keep them as they are. If the time comes that we really need to do
refactoring like that, we'll probably know it :)
On Mon, Jan 18, 2016 at 9:54 AM Peter Vasil<EMAIL_ADDRESS>wrote:

Ok, I'll prepare the PR. I think the feature is ready to go, but still
needs some documentation. I guess we can merge it as soon I added the info
how to specify the get-syntax-keywords-function to the readme.
We could ship pre-made lists, like the package auto-complete is doing. At
some point on my branch I was adding those too but removed them because I
wasn't sure.
About the splitting of features, I am not sure, on the one hand it would
improve readability I guess on the other it is still nice nice to have only
one file because it is a self contained file. I personally did not feel the
need to split out the parts while developing. I was also looking at other
excellent packages like flycheck, they also have only one file.
—
Reply to this email directly or view it on GitHub
https://github.com/abingham/emacs-ycmd/issues/258#issuecomment-172466675
.

Am 18.01.2016 09:59 schrieb abingham:

Sounds good. I've been poking around with elm lately, so I'll be happy
to
add an elm syntax file.
Ok, then I'll add loading keyword files to the code in the PR

Regarding splitting out extra features, let's just keep things as
they are
for now. There's definitely no strong need to make that kind of
change
right now, and if you're happy with the state of things then we
should just
keep them as they are. If the time comes that we really need to do
refactoring like that, we'll probably know it :)
Sounds good.

On Mon, Jan 18, 2016 at 9:54 AM Peter Vasil
<EMAIL_ADDRESS>wrote:

Ok, I'll prepare the PR. I think the feature is ready to go, but
still
needs some documentation. I guess we can merge it as soon I added
the info
how to specify the get-syntax-keywords-function to the readme.
We could ship pre-made lists, like the package auto-complete is
doing. At
some point on my branch I was adding those too but removed them
because I
wasn't sure.
About the splitting of features, I am not sure, on the one hand it
would
improve readability I guess on the other it is still nice nice to
have only
one file because it is a self contained file. I personally did not
feel the
need to split out the parts while developing. I was also looking at
other
excellent packages like flycheck, they also have only one file.
—
Reply to this email directly or view it on GitHub

https://github.com/abingham/emacs-ycmd/issues/258#issuecomment-172466675

.

--
Reply to this email directly or view it on GitHub [1].

Links:
[1]
https://github.com/abingham/emacs-ycmd/issues/258#issuecomment-172467831

Resolved with #259


Add basic tests for HTML interface for editing notices

We should nail down the endpoints and query parameters of them.
The admin test suite for allow-list should give a good idea how this can be done. https://github.com/ssb-ngi-pointer/go-ssb-room/blob/f774817536669c4f2ce2fe356a172d047ef5e780/web/handlers/admin/allow_list_test.go#L109
Check that

[ ] the default notices are present (/notice?id=x for different x's)
[ ] the edit buttons show for logged in admins (might need better stubbing of the is_logged_in helper)
[ ] the edit form includes all the needed fields, for input=hidden and input=text

[ ] for add translation (new)
[ ] for edit (existing)

[ ] the save handlers refuse incomplete requests (all the params included)
[ ] make sure the save handler calls the mockdb  (CallCount and CallArgs)

preemptively assigning myself to https://github.com/ssb-ngi-pointer/go-ssb-room/issues/44 & https://github.com/ssb-ngi-pointer/go-ssb-room/issues/46
will see which one i feel i can get more traction on :^)

@cryptix

the edit form includes all the needed fields, for input=hidden and input=text

Would you mind briefly & explicitly enumerating the needed fields/expected forms? Not really familiar with what's supposed to be included or not atm :)

i'm... done? the onboarding is COMPLETE? hit me up with that review @cryptix lemme know where i have been lacking or misunderstood things


turn off logging messages to stdout

i would love to have the ability to turn off all the logging of simple INFO messages to stdout. But as i can see you are using your own implementation of a logger with no ability to turn it off or change the log level. Maybe its better to switch to the python logging module or at least implement a way to change the log level or turn the logging off completely.
source code:
https://github.com/meteomatics/python-connector-api/blob/master/meteomatics/api.py#L24
Thank you very much for your precious time :pizza: :beers: .

sorry just saw the open pull request #12
But this means +1


fix(esl-tooltip): fix tooltip arrow disappearing

Closes: #2761

:tada: This PR is included in version 5.0.0-beta.40 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Enhancement] report a log when large memory allocation occurs

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

run starrocks_admit_test

starrocks_be_unittest succeeded.


Proper documentation on how to run it.

I successfully installed the docker image and tried to run the example in the documentaiton.
python3.8 test.py

Outputs:
  File "test.py", line 5
    float Q_rsqrt( float number )
          ^
SyntaxError: invalid syntax

I may be not running in a proper way but i would like to know how to run altough I can not find anything on this topic.
I'm sorry if tt's clearly written somewhere but I can't find it.
Thanks.

Make sure to have the # coding: inlinec comment on the first or second line of the file.
This should definitely be documented better. Good point
Thanks!

Now I am getting this error:

@EkremDincel Looks like you have a typo in the coding comment — “inlicec” should be “Inlinec”

Thanks for everything. Now I have my code running better than I expected :)


Hotfix/fix-cli-interface

Fix path resolve
Added apply command

Codecov Report

Merging #9 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   98.93%   98.85%   -0.09%
==========================================
  Files           9       10       +1
  Lines          94       87       -7
  Branches       22       21       -1
==========================================
- Hits           93       86       -7
  Misses          1        1

Impacted Files
Coverage Δ

src/utils/index.js
100% <ø> (ø)
:arrow_up:

src/generator/index.js
95.83% <100%> (+0.37%)
:arrow_up:

modulox.theme.js
100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a58d687...9368132. Read the comment docs.


Warn when binding to native attributes without using $=

If a native element attribute is set using the {{}} or [[]] binding syntax, check to ensure that the value is set using the $= operator.

Cross referencing ticket on overusing $=.


Automated cherry pick of #9176: fix(scheduler): select resource unordered

Cherry pick of #9176 on release/3.5.
#9176: fix(scheduler): select resource unordered

Codecov Report

Merging #9179 (e69d339) into release/3.5 (6a15e02) will decrease coverage by 1.77%.
The diff coverage is 5.88%.

@@               Coverage Diff               @@
##           release/3.5   #9179       +/-   ##
===============================================
- Coverage         5.98%   4.21%    -1.78%
===============================================
  Files              796     163      -633
  Lines           125693   24889   -100804
===============================================
- Hits              7522    1048     -6474
+ Misses          117504   23749    -93755
+ Partials           667      92      -575

Flag
Coverage Δ

aFlag
4.21% <5.88%> (-1.78%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cloudcommon/db/jointbase.go
0.00% <ø> (ø)

pkg/cloudprovider/objectstore.go
2.57% <ø> (ø)

pkg/compute/regiondrivers/managedvirtual.go
0.00% <0.00%> (ø)

pkg/hostman/hostinfo/hostovn.go
27.45% <0.00%> (-2.03%)
:arrow_down:

pkg/multicloud/esxi/host.go
0.77% <0.00%> (-0.01%)
:arrow_down:

pkg/multicloud/esxi/manager.go
0.70% <0.00%> (-0.01%)
:arrow_down:

pkg/util/netutils2/netutils.go
21.62% <100.00%> (+0.35%)
:arrow_up:

pkg/keystone/models/regions.go

pkg/util/gin/middleware/error.go

pkg/cloudcommon/db/quotas/context.go

... and 596 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57cea3...e69d339. Read the comment docs.


Line number color

Hi,
The colortheme worked perfectly but suddenly the line numbers did change color and i can't find a way to fix it. The linenumbers are some sort of purple? Also the CursorLineNr is not applied anymore.

I tried reinstalling but it did not change anything.
Any ideas where it goes wrong?

Hey @thordossche 👋🏼 .
That is really odd. Have you installed a new plugin which is hijacking the LineNr highlight group? I haven't touched that line in months, unfortunately.

The change happened when i installed nvim-tree and was trying to change the colorgroups (which did not work strangely enough). The moment the linenumbers changed color was when i changed the cursorline option to false.
I removed all my plugins and reinstalled onedarkpro and treesitter but the purple linenumbers still appear even with the default config. I tried to change the color of LineNr to the standard gray: LineNr = { fg = "#7D828D" }, but it does not apply.
For CursorLineNr: I can change the color of the CursorLineNr only when i enable the cursorline option.

I finally found it... Its really stupid:
so i source files in my init.vim something like:
source plugins
source colorscheme
source settings
...

I changed the order and sourced my colorscheme as last and it seemed to work so i checked my settings file and there was the culprit: highlight LineNr guifg=#fcc4ff guibg=NONE
I have absolutely no idea how that line got there xp
So the issue is fixed thanks for the help and sorry to waste your time for this...

Not a waste of time at all. I want people to enjoy using the theme as much as I do 😄 .

Well i can assure you I LOVE the theme!! Great work!


lxc 3.0.1 image import is failing on "Metadata file is required"

Required information

Distribution: Ubuntu 16.04.5 LTS
Kernel version: 4.15.0-30-generic
LXC/LXD version: 3.0.1

Issue description
When trying to import lxc images from a URL I'm getting this error:
Error: Metadata file is required
Steps to reproduce
lxc image import https://dl.stgraber.org/lxd
or any URL (it doesn't get to the request part):
lxc image import https://aaaaaa
Is there another way to import images from a webserver or this is a bug?

Oops, clearly not the most used feature if nobody else noticed until now (or they're using the API directly instead of the CLI).
Anyway, sent a fix for this now.


Create code-of-conduct.md

code-of-conduct.md was merged into the branch reflected in pull #24. Closing this pull as a result as the other will cover this (and this version is out of date).


Usage of ModernHttpClient

Hi !
I'm relatively new to C# development and I don't know if my issue is relevant but as I also have a few remarks/questions, I wanted to ask :

Would it not be worth using https://github.com/paulcbetts/ModernHttpClient internally ?
It's not possible to use (error 404) your RestClient with a BaseUrl that doesn't have a trailing "/" (the Resource from RestRequest starts directly with "/").
I use this PCL with Xamarin and I noticed one strange inconvenience due to the Microsoft.Bcl.Build package dependency : I'm not able to use typeof(MyClass).GetTypeInfo().Assembly anymore ... Do you have any idea to get around this problem ?

Thx in advance for your help ! =)

Thanks for answering this, I was using restsharp.portable before Unified-API's Xamarin change and I needed to move to ModernHttpClient to support most recent devices. Following your instructions, I simply wrote this and it worked just fine on arm64 :)
using ModernHttpClient;
using RestSharp.Portable.HttpClientImpl;
using System.Net.Http;
using RestSharp.Portable;

namespace MyApp.Common
{
	public class ModernHttpClientFactory : DefaultHttpClientFactory
	{
		protected override HttpMessageHandler CreateMessageHandler (IRestClient client, IRestRequest request)
		{
			return new NativeMessageHandler ();
		}
	}
}


Fix dates of the previous month with momentjs 2.17.0+

refs #288
I replace the use of negative date by the moment subtract function.
And I update the test file to use moment 2.17.0.

:100: This is great work, thanks for your help! 🍻

:beers:

What about to release a new version? This to help all that use this package with bower, npm, etc.
It took me a while to understand that it was on the master 😭
Thank you in advance.


Rewrite function tests using testing.FunctionTestCase

We have introduced testing.FunctionTestCase (#3499).
This tool enables writing a function test for various backends (including ChainerX) in much simpler way.
This tool also provides an option to automatically dodge non-differentiable inputs.
We should apply this to all the existing function tests, and assure ChainerX support in those functions.
~(Note: we should merge #6069 first to skip float16 in ChainerX backends.)~
To get started
Please declare your will to work on a function, by posting a comment in this issue. If you're a collaborator, just write your name next to the function name.
Typical problems and workarounds for ChainerX support
NumPy-compatible functions are not yet implemented
Write tentative implementation that falls back to numpy/cupy, in chainerx/_fallback_workarounds.py. For module-level functions (e.g. chainerx.hstack), write in _populate_module_functions. For ndarray methods, write in _populate_ndarray. Note that functions written in this way cannot support backprop in their own, but it's sufficient for computations in FunctionNode.forward, for example.
Array type mismatch
In FunctionNode fallback (in which chainerx arrays are automatically converted to numpy/cupy and the corresponding FunctionNode.forward method is called), array attributes are also automatically converted between numpy/cupy and chainerx arrays. This is not the case if the array attribute is wrapped in a tuple, dict, etc. In this case, the attribute must be converted manually, using backend.to_chainerx and backend.from_chainerx.

[ ] functions_tests/pooling_tests/test_roi_max_align_2d.py
[ ] functions_tests/pooling_tests/test_pooling_nd_kernel.py
[ ] functions_tests/pooling_tests/test_max_pooling_2d.py
[ ] functions_tests/pooling_tests/test_unpooling_2d.py
[x] functions_tests/pooling_tests/test_average_pooling_2d.py #6211
[ ] functions_tests/pooling_tests/test_roi_average_align_2d.py
[ ] functions_tests/pooling_tests/test_spatial_pyramid_pooling_2d.py
[ ] functions_tests/pooling_tests/test_roi_pooling_2d.py
[ ] functions_tests/pooling_tests/test_roi_max_pooling_2d.py
[ ] functions_tests/pooling_tests/test_unpooling_nd.py
[ ] functions_tests/pooling_tests/test_roi_average_pooling_2d.py
[x] functions_tests/pooling_tests/test_max_pooling_nd.py https://github.com/chainer/chainer/pull/3499
[ ] functions_tests/pooling_tests/test_upsampling_2d.py
[ ] functions_tests/pooling_tests/test_average_pooling_nd.py
[ ] functions_tests/normalization_tests/test_batch_renormalization.py https://github.com/chainer/chainer/pull/5817
[ ] functions_tests/normalization_tests/test_local_response_normalization.py
[ ] functions_tests/normalization_tests/test_batch_normalization.py
[ ] functions_tests/normalization_tests/test_layer_normalization.py
[ ] functions_tests/normalization_tests/test_group_normalization.py
[ ] functions_tests/normalization_tests/test_l2_normalization.py
[ ] functions_tests/evaluation_tests/test_accuracy.py
[ ] functions_tests/evaluation_tests/test_r2_score.py
[ ] functions_tests/evaluation_tests/test_binary_accuracy.py
[ ] functions_tests/evaluation_tests/test_classification_summary.py
[x] functions_tests/loss_tests/test_mean_squared_error.py https://github.com/chainer/chainer/pull/5822
[ ] functions_tests/loss_tests/test_hinge.py
[ ] functions_tests/loss_tests/test_absolute_error.py
[ ] functions_tests/loss_tests/test_huber_loss.py
[ ] functions_tests/loss_tests/test_negative_sampling.py
[ ] functions_tests/loss_tests/test_contrastive.py
[ ] functions_tests/loss_tests/test_triplet.py https://github.com/chainer/chainer/pull/5819
[ ] functions_tests/loss_tests/test_decov.py
[ ] functions_tests/loss_tests/test_mean_absolute_error.py #6253
[ ] functions_tests/loss_tests/test_discriminative_margin_based_clustering_loss.py
[ ] functions_tests/loss_tests/test_crf1d.py
[ ] functions_tests/loss_tests/test_sigmoid_cross_entropy.py
[ ] functions_tests/loss_tests/test_vae.py
[ ] functions_tests/loss_tests/test_softmax_cross_entropy.py
[ ] functions_tests/loss_tests/test_cross_covariance.py
[ ] functions_tests/loss_tests/test_black_out.py
[ ] functions_tests/loss_tests/test_ctc.py
[ ] functions_tests/loss_tests/test_squared_error.py
[x] functions_tests/activation_tests/test_hard_sigmoid.py #6192
[ ] functions_tests/activation_tests/test_log_softmax.py
[ ] functions_tests/activation_tests/test_softplus.py #6298
[ ] functions_tests/activation_tests/test_selu.py #6243
[ ] functions_tests/activation_tests/test_rrelu.py
[ ] functions_tests/activation_tests/test_prelu.py
[ ] functions_tests/activation_tests/test_maxout.py
[x] functions_tests/activation_tests/test_relu.py https://github.com/chainer/chainer/pull/3499
[ ] functions_tests/activation_tests/test_leaky_relu.py
[x] functions_tests/activation_tests/test_elu.py #6070
[ ] functions_tests/activation_tests/test_slstm.py
[ ] functions_tests/activation_tests/test_sigmoid.py
[ ] functions_tests/activation_tests/test_lstm.py
[ ] functions_tests/activation_tests/test_softmax.py #6242
[ ] functions_tests/activation_tests/test_swish.py
[x] functions_tests/activation_tests/test_clipped_relu.py https://github.com/chainer/chainer/pull/3499
[ ] functions_tests/activation_tests/test_tanh.py #6173
[x] functions_tests/activation_tests/test_crelu.py #6070
[ ] functions_tests/noise_tests/test_simplified_dropconnect.py
[ ] functions_tests/noise_tests/test_zoneout.py
[ ] functions_tests/noise_tests/test_dropout.py
[ ] functions_tests/noise_tests/test_gaussian.py
[ ] functions_tests/noise_tests/test_gumbel_softmax.py
[ ] functions_tests/math_tests/test_sign.py
[ ] functions_tests/math_tests/test_scale.py
[ ] functions_tests/math_tests/test_ceil.py
[ ] functions_tests/math_tests/test_det.py
[ ] functions_tests/math_tests/test_polygamma.py
[ ] functions_tests/math_tests/test_logsumexp.py
[ ] functions_tests/math_tests/test_erf.py
[ ] functions_tests/math_tests/test_log_ndtr.py
[ ] functions_tests/math_tests/test_floor.py
[ ] functions_tests/math_tests/test_exponential_m1.py
[ ] functions_tests/math_tests/test_tensordot.py
[ ] functions_tests/math_tests/test_ndtri.py
[ ] functions_tests/math_tests/test_prod.py
[ ] functions_tests/math_tests/test_fmod.py
[ ] functions_tests/math_tests/test_erfcinv.py
[ ] functions_tests/math_tests/test_ndtr.py
[ ] functions_tests/math_tests/test_erfcx.py
[ ] functions_tests/math_tests/test_exponential.py
[ ] functions_tests/math_tests/test_linear_interpolate.py
[ ] functions_tests/math_tests/test_logarithm_1p.py
[ ] functions_tests/math_tests/test_maximum.py
[ ] functions_tests/math_tests/test_einsum.py
[ ] functions_tests/math_tests/test_cumsum.py
[ ] functions_tests/math_tests/test_minmax.py
[ ] functions_tests/math_tests/test_lgamma.py
[ ] functions_tests/math_tests/test_trigonometric.py
[ ] functions_tests/math_tests/test_average.py
[ ] functions_tests/math_tests/test_cumprod.py
[ ] functions_tests/math_tests/test_sqrt.py
[ ] functions_tests/math_tests/test_matmul.py
[ ] functions_tests/math_tests/test_erfc.py
[ ] functions_tests/math_tests/test_batch_l2_norm_squared.py
[ ] functions_tests/math_tests/test_minimum.py
[ ] functions_tests/math_tests/test_hyperbolic.py
[ ] functions_tests/math_tests/test_fft.py
[ ] functions_tests/math_tests/test_squared_difference.py
[ ] functions_tests/math_tests/test_erfinv.py
[ ] functions_tests/math_tests/test_digamma.py
[ ] functions_tests/math_tests/test_clip.py
[ ] functions_tests/math_tests/test_square.py
[ ] functions_tests/math_tests/test_inv.py
[ ] functions_tests/math_tests/test_sparse_matmul.py
[ ] functions_tests/math_tests/test_sum.py
[ ] functions_tests/math_tests/test_bias.py
[ ] functions_tests/math_tests/test_basic_math.py
[ ] functions_tests/math_tests/test_fix.py
[ ] functions_tests/array_tests/test_broadcast.py
[ ] functions_tests/array_tests/test_vstack.py
[ ] functions_tests/array_tests/test_repeat.py
[ ] functions_tests/array_tests/test_swapaxes.py
[ ] functions_tests/array_tests/test_expand_dims.py
[ ] functions_tests/array_tests/test_separate.py
[ ] functions_tests/array_tests/test_reshape.py
[ ] functions_tests/array_tests/test_where.py
[ ] functions_tests/array_tests/test_flipud.py
[ ] functions_tests/array_tests/test_spatial_transformer_grid.py
[ ] functions_tests/array_tests/test_diagonal.py
[ ] functions_tests/array_tests/test_resize_images.py
[ ] functions_tests/array_tests/test_pad_sequence.py
[ ] functions_tests/array_tests/test_rollaxis.py
[x] functions_tests/array_tests/test_split_axis.py https://github.com/chainer/chainer/pull/3499
[ ] functions_tests/array_tests/test_permutate.py
[ ] functions_tests/array_tests/test_transpose_sequence.py
[ ] functions_tests/array_tests/test_transpose.py
[ ] functions_tests/array_tests/test_pad.py
[ ] functions_tests/array_tests/test_select_item.py
[ ] functions_tests/array_tests/test_flatten.py
[ ] functions_tests/array_tests/test_squeeze.py
[x] functions_tests/array_tests/test_hstack.py https://github.com/chainer/chainer/pull/3499
[ ] functions_tests/array_tests/test_depth_2_space.py
[ ] functions_tests/array_tests/test_space_2_depth.py
[ ] functions_tests/array_tests/test_moveaxis.py
[ ] functions_tests/array_tests/test_scatter_add.py
[ ] functions_tests/array_tests/test_tile.py
[ ] functions_tests/array_tests/test_fliplr.py
[ ] functions_tests/array_tests/test_im2col.py
[x] functions_tests/array_tests/test_concat.py https://github.com/chainer/chainer/pull/5823
[ ] functions_tests/array_tests/test_copy.py
[ ] functions_tests/array_tests/test_cast.py
[ ] functions_tests/array_tests/test_stack.py
[ ] functions_tests/array_tests/test_spatial_transformer_sampler.py
[ ] functions_tests/array_tests/test_flip.py
[ ] functions_tests/array_tests/test_dstack.py
[ ] functions_tests/array_tests/test_get_item.py
[x] functions_tests/connection_tests/test_linear.py #6236
[ ] functions_tests/connection_tests/test_deformable_convolution_2d_sampler.py
[ ] functions_tests/connection_tests/test_embed_id.py
[ ] functions_tests/connection_tests/test_convolution_nd.py
[ ] functions_tests/connection_tests/test_dilated_convolution_2d.py
[ ] functions_tests/connection_tests/test_n_step_gru.py
[ ] functions_tests/connection_tests/test_depthwise_convolution_2d.py
[ ] functions_tests/connection_tests/test_n_step_rnn.py
[ ] functions_tests/connection_tests/test_shift.py
[ ] functions_tests/connection_tests/test_convolution_2d.py
[ ] functions_tests/connection_tests/test_deconvolution_2d.py
[ ] functions_tests/connection_tests/test_bilinear.py
[ ] functions_tests/connection_tests/test_n_step_lstm.py
[ ] functions_tests/connection_tests/test_local_convolution_2d.py
[ ] functions_tests/connection_tests/test_deconvolution_nd.py
[ ] functions_tests/util_tests/test_forget.py

I'm working on tanh (#6173) and sigmoid (#6174)

https://github.com/chainer/chainer/pull/6139/ rewrote the tests of F.rrelu.

I'd like to work on test_softmax_cross_entropy (loss) and test_softmax (activation).

I'm also working on test_mean_absolute_error.

@crcrpar @aksub99
Thank you!

@niboshi  Please review my PR.

@ishanrai05 Thanks! Please wait until a reviewer will be assigned soon.

I have submitted the above PRs  to simplify test_leaky_relu.py and test_maxout.py. Am still working on fixing test_softmax.py and test_mean_absolute_error.py.

I have submitted PRs to simplify test_swish and test_softpool.

@niboshi Could you please review PRs #6301 and #6302 ?

I have submitted PR #6320 to simplify test_log_softmax

Submitted PR #6322  for test_diagonal

Hi, I'm new to this repo, may I work on math_tests.test_sqrt first?

If this issue still needs work, I would love to take it up

@sameshl I think so. Note that the list in the first post might be obsolete.

I would like toi know if the list provided is updated. If yes, I'd like to work on them

May I know the status of this issue? I would like to work on this, if it is still open.

I would like to work on squared error and sqrt tests. Could anyone give me a headstart, I relatively new in chainer contribution community. Thanks!


Learning Resources and Online Editor Availability

Related Documentation Page
No response
Type of the problem
Missing information
Problem Description
Hello all,
I was wondering if there will be a dedicated learning section, as well as the availability of the online editor che era presente in SpecFlow (https://app.specflow.org/gherkin-editor/).
Thank you in advance for your response!

We can have a learning section (any suggestion where?).
The online gherkin editor will anyway stop working most probably by the end of the year, see https://support-hub.tricentis.com/open?number=NEW0001432&id=post


Problem enjecting the dll into pubg

This is the error i get when trying to inject the dll into pubg running unreal engine 4.16

Why would you need mappings for a 4.16 game?


docs: add portlet administration information

Markdown-ified version of the Administration/Testing guide created by the CCC team.

/cc @jgribonvald


Use of [UIApplication sharedApplication]

TWMessageBarManager.m uses [UIApplication sharedApplication].keyWindow.frame to calculate the size of the message bar frame. The use of [UIApplication sharedApplication] means that this library can't be used in an extension. Would it be possible to optionally configure the frame externally?
Thanks a lot, love the library!

Sorry, at this time you can't configure the message bar externally.
Give it a shot and submit a PR! Love the username btw!


Update TypeScript textobjects for type definition support

interface, type and enum declarations are now supported as class textobjects.
Known issues:

the last semicolon (;) of the inner text (interface, type) or the last comma of the inner text (enum) are missed.
an object declared with as const isn't supported (value: as_expression ending with type_identifier)

This is related to https://github.com/nvim-treesitter/nvim-treesitter-textobjects/discussions/396

Also, instead of adding commits can you rebase with master, leaving only 1 clean commit and force-push?
You can use git rebase -i master
Thanks for the PR btw!

Also, instead of adding commits can you rebase with master, leaving only 1 clean commit and force-push?
I'm on my phone now but will do that when I'm on my laptop.

@benyn No need to worry about rebasing. If you fix it to a working version with conversations resolved, I'll squash and merge this.

@benyn friendly ping. I think your change is really useful. Would be great to merge this soon!

Sorry it's been a busy week. Will try to get this in this weekend!


fix: Rework the transformations acceptance to remove target type depe…

…ndency
Fixes: #670

retry with pull 676


Random crashes JVM with Compose application

I make a simple compose application (LazyColumn with Text, Buttons and LinearProgressIndicator in the rows). When  I make it in Linux everything worked fine. But when I compiled it for Windows on the same computer and run, I got an fatal error in JRE. Compose version 0.3.0-build143. Another Compose application with a more complex interface worked fine with this version of Compose and with the previous ones. I try compile the project with different variants of JDK (liberica-14, liberica-15, adopt-openj9-15). I try to run application on different computer (but the same OS: Windows 7 64-bit) - the same result.
The crash may occur after a few clicks, or it may not occur for a long time. It occurs more often after the progress indicator is worked out and then click on some button.
Demo application placed here: simpletimer
JVM save report files after crash. I have attached an  example of these files:
hs_err_pid6836.log
hs_err_pid7576.log

It is stable reproduced on '0.3.0-build143' (start first slider, open/close multiple times "Edit" dialog)
But isn't reproduced on '0.3.0-build146' (we have new skiko/skija in that build).
Can your check 0.3.0-build146?

It is stable reproduced on '0.3.0-build143' (start first slider, open/close multiple times "Edit" dialog)
But isn't reproduced on '0.3.0-build146' (we have new skiko/skija in that build).
Can your check 0.3.0-build146?

I check 0.3.0-build146. Application is worked. Thank you!

I check 0.3.0-build146. Application is worked. Thank you!

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Updating MtHelens

Three of them were the code that the jupyter notebook uses to track # of times the cell has run, so I picked the MtHelens version because I don't think it matters. The other two were displayed code results in the notebook. I picked the results from MtHelens because I'm assuming that is what you want to show.

It tells me that this will merge the StHelens_analysis branch into main, but we don't want that. So I won't push it through until we confirm what's happening.


crypto: v2 address format

This PR is going to stage the various address-breaking changes we have planned prior to mainnet:

[x] Uses new poseidon parameters by removing the pinned branch called oldparams
[x] https://github.com/penumbra-zone/penumbra/issues/1077
[ ] https://github.com/penumbra-zone/penumbra/issues/1079
[ ] https://github.com/penumbra-zone/penumbra/issues/1078
[ ] Add v2 address prefix

(smoke test failing due to invalid addresses in allocations file)

@redshiftzero Galileo may need to be modified to parse the new address format; I forget exactly which regex is used. We can also yolo and find out though.


Token fixes

Fixes upload and adds example bearer token to README for new token format.

I think I brought along a commit that wasn't brought up to master on GitHub, but it seems we need it, and it is a pretty benign update so I didn't fix.


Variable Properties for FilePondOptions

Hello!
@ViewChild('myPond') myPond: any;
  private abortMessage: string = "File upload rejected";

  pondOptions = {
    class: 'my-filepond',
    multiple: true,
    forceRevert: true,

    labelFileProcessingAborted : this.abortMessage,
}

process: (fieldName, file, metadata, load, error, progress, abort) => {

    let sub = this.http.request(req).subscribe(event => {
        if(event.status == 406){
               this.abortMessage = 'File detected as Virus.';
        }
    }
}

At the time of uploading file I want to change my abort label according to server response.
Is it possible to achieve this using filepond ?
or
Any work around will be helpful

You can use the labelFileProcessingError property, see the demo below:
https://codesandbox.io/s/vanilla-filepond-dynamic-process-file-error-kqs4k
const pond = create(inputElement, {
  server: {
    process: (name, file, data, load, error, progress, abort) => {
      setTimeout(() => {
        error('my error');
      }, 1000);
      return {
        abort: abort
      };
    }
  },
  labelFileProcessingError: err => {
    console.log(err);
    return err.body;
  }
});

This works for me. Thank you.


Allow custom field validation error messages

Fixes #20

One CI build timed out due to dev spaces, merging..


New plugin: Scaleway CLI

Platform or tool
Scaleway
Relevant links

https://www.scaleway.com/en/cli/
https://github.com/scaleway/scaleway-cli

Goal or desired behavior
Authenticate to the Scaleway platform.
Contribution

[X] I'd be up for building the plugin myself.

Additional information
No response

I would like to give it  try

Hey @parthiv11, that's awesome! Feel free to ping me on your PR when it's ready.


Enabling xenon absorption length

This PR enables the xenon wavelength photon absorption length (80m) in the semi-analytical model for DUNE-VD. This PR requires:
https://github.com/LArSoft/larsim/pull/115
https://github.com/LArSoft/lardataalg/pull/39

Thank you for addressing this issue, Patrick. Things look good to me from this and other PRs. But I understand the larsoft ones are not merged yet. So we need to wait for those before merging this one, right? If so, can you let us know when it happens?

Yes this requires the corresponding LArSoft PRs to function, and yes I can update once those are merged.

The tests are being triggered in jenkins.
Tested with other pull request(s) LArSoft/lardataalg#39,LArSoft/larsim#115

+LArSoft tests OK on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/18965&builds=
+build

+LArSoft tests OK on slf7 for c7:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/18964&builds=
+build

+argoneut tests OK on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:argoneut/view_builds/index?offset=0&builds=argoneut_ci/8289&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/18965&builds=

-icarus tests failed on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:icarus/view_builds/index?offset=0&builds=icarus_ci/6873&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/18965&builds=

-dune tests tests warning on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:dune/view_builds/index?offset=0&builds=dune_ci/15186&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/18965&builds=

-sbnd tests warning on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:sbnd/view_builds/index?offset=0&builds=sbnd_ci/11603&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/18965&builds=

Hi Patrick, how does it work? I understand that if we set UseXeAbsorption: false we simulate with 20m of absorption, and if we set UseXeAbsorption: true, we get the simulation with 80m of absorption length on the xenon light. But, what if we set  UseXeAbsorption: true with the LArG4 parameter of absorption manually changed to 200 m, for example, does the simulation change?
I suggest adding a comment next to the fhicl parameter explaining how to use this. Something like (if I am right):
dunevd_pdfastsim_par_xe.UseXeAbsorption: true #true for 80m absorption, false for 20m absorption
If this is how we are supposed to use it, maybe the name of the parameter is not the best one...

Hi Jose, if you look at the corresponding larsim PR you can see the code -- the absorption length is taken from the standard spectrum in larproperties.fcl (can be overwritten as desired), the spectrum is interpolated to get the value for 9.7eV (default, argon) or 7.1 eV if this parameter is true. So yes if you change the larproperties absorption it will indeed change in the code.

The PRs in larsoft have now been merged, so this can be included in the next release


docs/syz-verifier: fix internal link

Removed the "\n" from the internal documentation URL.

I think you need to pull new changes. You already fixed this :)
f765b597a136dee8fefef2bb5f346be80f15b8b1


Change lines data["codomain"] = tuple(ms["Spaces"][x] for x in data["codomain"]) to have assertions to check spaces exist

Possibly just before all blocks have a check function?
Could have it be a block specific class function that gets called each time?


Get-AzStorageAccount does not seem to work with classic storage accounts

I used
Get-AzResource -ResourceGroupName "resourcegroupname"
to find the storage account resourceid.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1059069a-e860-f66d-3445-60425a5bffe1
Version Independent ID: 1d80c823-5a41-7d2b-f40d-b0f2ca3c673f
Content: Azure Key Vault managed storage account - PowerShell version
Content Source: articles/key-vault/key-vault-overview-storage-keys-powershell.md
Service: key-vault
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@peledins Thank you for the feedback! We are assigning the Author to make the required changes.

Any update on this, I also spent some wasted time on this before I realized it probably just doesn't work for Classic accounts since nothing is returned :(

Same here. Not working with Classic Storage accounts.

Same here. Not working with classic storage

Document updated with new command for classic storage account. #please-close


Count query fails if a large query ends in a comment

Describe the bug
When the final line of a Kusto query ends with a comment, the count query fails if the tabular expression result contains more than truncationmaxrecords rows (500000 by default).
To Reproduce
conn = {
    "kustoCluster": xxx,
    "kustoDatabase": xxx,
    "kustoAadAppId": xxx,
    "kustoAadAppSecret": xxx,
    "kustoAadAuthorityID": xxx,
}
crp = '{"Options": {"truncationmaxrecords": 500000}, "Parameters": {}}'
kql = 'range _ from 1 to 500001 step 1 // this comment causes issue'

df = (spark.read
        .format("com.microsoft.kusto.spark.synapse.datasource")
        .options(**conn)
        .option("kustoQuery", kql)
        .option("clientRequestPropertiesJson", crp)
        .load())

df.limit(0)

Expected behavior
All else the same, I expected the query range _ from 1 to 500001 step 1 // this comment causes issue to behave identically to the query range _ from 1 to 500001 step 1 (when truncationmaxrecords is 500000 or below in this case).
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

Spark v3.2 on Synapse

Additional context
Maybe it has something to do with this code:
https://github.com/Azure/azure-kusto-spark/blob/83cf263a7e56365a52f895cf774fb24b72e9e0fc/connector/src/main/scala/com/microsoft/kusto/spark/utils/KustoQueryUtils.scala#L11-L13
Perhaps changing would solve the issue:
def limitQuery(query: String, limit: Int): String = {
    val trimmedQuery = query.trim
    trimmedQuery + s"\n| take $limit"
}

(I do not know Scala)

Hello @oglehb , Will have a look at this right away and potentially fixing this issue


[SPARK-29520][SS] Fix checks of negative intervals

What changes were proposed in this pull request?

Added getDuration() to calculate interval duration in specified time units assuming provided days per months
Added isNegative() which return true is the interval duration is less than 0
Fix checking negative intervals by using isNegative() in structured streaming classes
Fix checking of year-months intervals

Why are the changes needed?
This fixes incorrect checking of negative intervals. An interval is negative when its duration is negative but not if interval's months or microseconds is negative. Also this fixes checking of year-month interval support because the month field could be negative.
Does this PR introduce any user-facing change?
Should not
How was this patch tested?

Added tests for the getDuration() and isNegative() methods to IntervalUtilsSuite
By existing SS tests

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17299/
Test PASSed.

Test build #112319 has started for PR 26177 at commit 1f5d684.

Test build #112319 has finished for PR 26177 at commit 1f5d684.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112319/
Test FAILed.

Test build #112321 has started for PR 26177 at commit ab6036c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17301/
Test PASSed.

Test build #112321 has finished for PR 26177 at commit ab6036c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112321/
Test PASSed.

I'm neutral on this PR.
But I have to remind that months, days and microseconds is designed to be 3 separated fields. It's simpler to just check months >= 0 && days >= 0 && microseconds >= 0 and let user to choose their own combination to pass this constraint. If we make them convertible, things can be a bit more complex. I mean, you have to make some assumption to convert the fields and take care of them.

It's simpler to just check months >= 0 && days >= 0 && microseconds >= 0 ...

I do believe the caller should not depend on how many fields interval has, 2 now, 3 after your PR or maybe 5 in the future. What's matter is negative or not user's interval.

... and let user to choose their own combination to pass this constraint.

Users should struggle to pass the constraints. Any combination of non-negative interval should work.

If we make them convertible, things can be a bit more complex. I mean, you have to make some assumption to convert the fields and take care of them.

Such assumption has been already made in Structured Streaming code. It is 31 days per months. Nothing more is needed. Splitting microseconds to days and microseconds should not require more assumptions.

@zsxwing Does this fix make sense, WDYT?

Test build #112488 has started for PR 26177 at commit 6afa006.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17454/
Test PASSed.

Test build #112488 has finished for PR 26177 at commit 6afa006.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112488/
Test PASSed.

Test build #112554 has started for PR 26177 at commit 084c8d5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17519/
Test PASSed.

Test build #112554 has finished for PR 26177 at commit 084c8d5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112554/
Test PASSed.

I'll start reviewing it after conflicts are resolved, thanks for fixing them!

Test build #112671 has started for PR 26177 at commit 2aa6480.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17627/
Test PASSed.

Test build #112671 has finished for PR 26177 at commit 2aa6480.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112671/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17719/
Test PASSed.

Test build #112774 has started for PR 26177 at commit 1840a1d.

Merged build finished. Test PASSed.

Test build #112790 has started for PR 26177 at commit b212976.

Test build #112790 has finished for PR 26177 at commit b212976.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112790/
Test FAILed.

retest this please

Test build #112827 has started for PR 26177 at commit b212976.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17762/
Test PASSed.

Test build #112827 has finished for PR 26177 at commit b212976.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112827/
Test FAILed.

retest this please

Test build #112833 has started for PR 26177 at commit b212976.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17768/
Test PASSed.

Test build #112833 has finished for PR 26177 at commit b212976.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112833/
Test PASSed.

Test build #112864 has started for PR 26177 at commit edad25e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17794/
Test PASSed.

Test build #112864 has finished for PR 26177 at commit edad25e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112864/
Test PASSed.

@cloud-fan Could you take a look at this one more time, please.

thanks, merging to master!


GoDaddy domains fail

I believe this was supposed to be fixed in 1.0.1, but it's failing for me. I've reinstalled the gem multiple times with the same result.
$ gem list --local | grep whois-parser
whois-parser (1.0.1)

Example code:
require 'whois-parser'

record = Whois.whois('university.com')
parser = record.parser

puts parser.expires_on

The result is nil. It works fine for non-GoDaddy domains as far as I've tested.

It seems to happen with other ICANN domains as well.
The issue seems to be that the parser is scanning for "Registrar Registration Expiration Date" whereas the actual response is "Registry Expiry Date" when trying to populate the "expires_on" field.

When this will be fixed?

@gayanW feel free to provide a PR

This issue can be closed now since I am able to get this working with 1.1.0 version of whois-parser

Closed by #60


add omeroweb-install to autogen

Add omeroweb-install to the doc
https://ci.openmicroscopy.org/job/OMERO-DEV-latest-docs-autogen/ updated
should be staged on http://www.openmicroscopy.org/site/support/omero5.3-staging/sysadmins/unix/install-web/walkthrough/omeroweb-install-centos7-ice3.6.html

To test this pr:

run https://ci.openmicroscopy.org/job/OMERO-DEV-merge-docs/ (at this stage http://www.openmicroscopy.org/site/support/omero5.3-staging/sysadmins/unix/install-web/walkthrough/omeroweb-install-centos7-ice3.6.html is only a placeholder)
run https://ci.openmicroscopy.org/job/OMERO-DEV-merge-docs-autogen/
and again https://ci.openmicroscopy.org/job/OMERO-DEV-merge-docs/ with AUTOGENERATED_BRANCH pointing to snoopy/merge/daily

AUTOGENERATED_BRANCH seems to be broken https://ci.openmicroscopy.org/job/OMERO-DEV-merge-docs/471/console. As it is not clear how to test this PR, leaving that to anyone who could suggest how to build and test it.
cc @jburel @sbesson @hflynn

After running the last step:
The page http://www.openmicroscopy.org/site/support/omero5.3-staging/sysadmins/unix/install-web/walkthrough/omeroweb-install-centos7-ice3.6.html is updated with the content of the walkthrough


Dedicated Slack channel

Hi there!
I was wondering why there isn't a dedicated Slack Team where, the community and gRPC members could speak and troubleshoot gRPC all together in real-time or near.
A good list of channel for the start could be:

General

Announcements

gRPC C++

gRPC Java

gRPC Python

gRPC NodeJS

gRPC {any other language}

gRPC-Web

protocol buffer

protobuf.js

protobuf {any language}

Toolings

3d Party projects

BloomRPC

It could be also worth to think about a discord server.
gRPC is becoming big topic all around! I love this technology and i'd love to speak about it all the time with the community.
Apologise if this is not the right place to open this kind of issue (please advice the best place if that' the case).
Regards

We actually do have a Slack that I believe predates this issue. However, I don't know how actively members of the team are currently engaging with it.

We have a mailing list - https://grpc.io/community/
An IRC channel - freenode #grpc
A Gitter channel - https://gitter.im/grpc/grpc
How would adding Slack to this official set of channels help? Perhaps the question is to popularize the gitter presence more?
What about doubling down on IRC?

I Believe that using a slack channel as the default real-time chat and communications makes a big difference.

90% of companies/developers use slack and they have it already installed in their PC / MAC

Cross Platform

Organising topics with channels really makes a difference

Search history it's amazing

I could go further and list all the great functionalities of slack, but we all know them 😄
The main point is that, slack it's much more widely used then gitter for community-based real-time chats. It's just remove the needs of 1 extra app to be installed and it can be organised way better.


chore: run integration tests on openshift.

Ah yes, I forgot about that orb enablement! Sorry about that!
Awesome to have integration tests!!!


join party and leave party for both LPs

closes #43

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Files
Patch %
Lines

contracts/BNBPartySwaps.sol
81.81%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files
Coverage Δ

contracts/BNBPartyFactory.sol
100.00% <100.00%> (ø)

contracts/BNBPartyLiquidity.sol
100.00% <100.00%> (ø)

contracts/BNBPartyManageable.sol
89.28% <100.00%> (ø)

contracts/BNBPartyState.sol
61.53% <ø> (ø)

contracts/BNBPartySwaps.sol
90.32% <81.81%> (-5.84%)
:arrow_down:


Not being able to update editor state

I wasn't sure how to describe the issue. I noticed the following behaviour while working on simple Entity.create scenarios.
I have the following
class SimpleEditorComponent extends Component {
  constructor(props) {
    super(props)
    this.state = { editorState: EditorState.createEmpty() }
    this.focus = () => this.refs.editor.focus()
    this.onChange = (editorState) => this.setState({ editorState })
    this.applyEntity = this.applyEntity.bind(this)
    this.logState = () => {
      const content = this.state.editorState.getCurrentContent()
      console.log(convertToRaw(content))
    }
  }
  applyEntity() {
    const { editorState } = this.state
    const entityKey = Entity.create('LINK', 'MUTABLE', { url: 'http://something.com' })
    this.setState({
      editorState: RichUtils.toggleLink(
        editorState,
        editorState.getSelection(),
        entityKey
      ),
    }, () => {
      setTimeout(() => this.refs.editor.focus(), 0)
    })
  }
  render() {
    const { editorState } = this.state
    return (

        <Editor
          editorState={editorState}
          onChange={this.onChange}
          placeholder="Enter some text..."
          ref="editor"
          />

Apply entity

Log editor state

    )
  }
}

Which is a very basic setup. However the entity is not added to the editor state. In fact if I set editorState to {} it won't change. Any other properties I set would set on state in applyEntity appear in state on next render. I'm sure it's something obvious but I don't even know where to start.
I thought it might be a race condition because of the editor losing focus when I click Apply entity and then gaining it back. But then nothing would be updated in the state object.

I think your suggestion of a possible race condition is the likely culprit here. Try using onMouseDown instead of onClick. You might also want to preventDefault() on the event.

@hellendag onMouseDown works, thank you. preventDefault() is not needed.

This probably should be closed. However maybe we should somehow add it to docs. In fact now when I think about it onMouseDown is used in most of the examples so maybe we should add at least a little note about this.

Seems like it might be useful to have a "Tips & Tricks" section in the documentation, to track pointers like these. Sort of like the "Issues & Pitfalls", but more like advice than like "please don't do that". :)

👍 for a Tips & Tricks section. I spent a good amount of time figuring this out.
Does anyone know why this is? Why does onMouseDown preserve focus (even without preventing default) while onClick causes the editor to lose focus?

@iansinnott, the editor still loses focus with onMouseDown, that's not the underlying issue. The problem here is the onClick={this.focus} on the wrapping div. It makes this.focus being called when you click on the "Apply Entity" button. These two events are processed one after the other, kind of like this:

applyEntity is called and creates the new EditorState with the new entity. It calls setState but it's not set right away because it's an asynchronous operation.
Draft internally processes the focus event and updates the EditorState by triggeringonChange. Notice that at this point Draft still doesn't know about the new EditorState from applyEntity.
SimpleEditorComponent onChange is called with the new EditorState that calls setState effectively overriding the one set at 1).

The difference that using onMouseDown makes is just the order that these events are fired and processed, onMouseDown is fired and processed before onClick so this gives time for setState called during applyEntity to actually change the state and re-render the component. Then, once, the onClick from the wrapping div is fired and processed Draft already has the EditorState from applyEntity.
For instance, If you move the buttons outside the wrapping div onClick will then work as expected.
I hope this makes sense and clarifies the core issue.

Since we merged the new docs let's close this issue. ⚡🎸🎶
Thanks again @aadsm for writing those docs!

Just found this. For anyone who cames back here looking for a solution (wherein a button inside the container div doesn't do as expected onClick), another (proper imo) solution is to use event.stopPropagation in your click handler. This would make sure that your container onClick isn't triggered.


Eviction in version "v1" cannot be handled as a Eviction

What version of descheduler are you using?
descheduler version: 1.25
Does this issue reproduce with the latest release?
yes
Which descheduler CLI options are you using?
none
Please provide a copy of your descheduler policy config file
  strategies:
    RemoveDuplicates:
      enabled: false
    RemovePodsViolatingNodeTaints:
      enabled: false
    RemovePodsViolatingNodeAffinity:
      enabled: false
    RemovePodsViolatingInterPodAntiAffinity:
      enabled: false
    LowNodeUtilization:
      enabled: false
    RemovePodsViolatingTopologySpreadConstraint:
      enabled: true
      params:
        includeSoftConstraints: true

What k8s version are you using (kubectl version)?
1.21 (GKE)
What did you do?
I have upgraded to v1.25 and started seeing these errors with every descheduler run:
E1010 18:10:02.963839       1 evictions.go:141] "Error evicting pod" err="Eviction in version \"v1\" cannot be handled as a Eviction: no kind \"Eviction\" is registered for version \"policy/v1\" in scheme \"k8s.io/kubernetes/pkg/api/legacyscheme/scheme.go:30\"" pod="prod/my-pod-name" reason=""

Hi @dry4ng, this is the same error as in https://github.com/kubernetes-sigs/descheduler/issues/972#issuecomment-1270284469, please see that comment.
tl;dr is that descheduler v0.25 is not supported on k8s 1.21, the latest descheduler version you can use is v0.23
/close
(closing as duplicate)