Tests that throw an exception cause WAT Mono to hang

As stated in the title, creating and executing a test that throws an exception causes WAT to hang on the latest release running on godot 3.4 stable. My faulty test throws a NullPointerException at a certain point (as also happens when run using NUnit), and the editor plugin hangs, while still counting time of execution for all tests.
When the issue occurs, the following error is printed to godot's stdout:
Unhandled Exception:
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.NullReferenceException: Object reference not set to an instance of an object
  at DeadUnit.GetBornUnit (Unit[] adjacentUnits, SpeciesLoader speciesLoader) [0x0002d] in <201300f8dd36490186d566e717f14c1d>:0
  at Test.DeadUnitTest.testGetBornUnit () [0x00124] in <201300f8dd36490186d566e717f14c1d>:0
  at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
  at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in <6a7c203f6f7a4f07b7fa766077730d49>:0
   --- End of inner exception stack trace ---
  at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00083] in <6a7c203f6f7a4f07b7fa766077730d49>:0
  at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) [0x00000] in <6a7c203f6f7a4f07b7fa766077730d49>:0
  at WAT.Test.Execute (WAT.Test+Executable test) [0x0001a] in <201300f8dd36490186d566e717f14c1d>:0
  at WAT.Test.Run () [0x00288] in <201300f8dd36490186d566e717f14c1d>:0
  at System.Runtime.CompilerServices.AsyncMethodBuilderCore+<>c.<ThrowAsync>b__7_0 (System.Object state) [0x00000] in <6a7c203f6f7a4f07b7fa766077730d49>:0
  at Godot.GodotSynchronizationContext.ExecutePendingContinuations () [0x00021] in <a31e640991de4b4d9ae13dd84ecb5441>:0
  at Godot.GodotTaskScheduler.Activate () [0x0000e] in <a31e640991de4b4d9ae13dd84ecb5441>:0
  at (wrapper native-to-managed) Godot.GodotTaskScheduler.Activate(Godot.GodotTaskScheduler,System.Exception&)
ERROR: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.

I encountered this issue on Arch Linux 5.15.5-zen1-1-zen.

Probably not too difficult to handle. Just need to handle exceptions somewhere in the main run method and pass details to the output.

Please check if this has been resolved from commit 790b30094931b5da1d6913c377174da12d0c3908

Sorry for the delay, the issue still occurs.
To replicate this, i simply swapped a value for null inside my test to get a NullReferenceException.
Unhandled Exception:
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.NullReferenceException: Object reference not set to an instance of an object
  at Test.TDeadUnit.testGetBornUnit () [0x00003] in <56ad31002fff4fc994ef8cb8db326f61>:0
  at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
  at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in <62b430b945fa49a19a75382ef03e7bed>:0
   --- End of inner exception stack trace ---
  at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00083] in <62b430b945fa49a19a75382ef03e7bed>:0
  at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) [0x00000] in <62b430b945fa49a19a75382ef03e7bed>:0
  at WAT.Test.Execute (WAT.Test+Executable test) [0x0001a] in <56ad31002fff4fc994ef8cb8db326f61>:0
  at WAT.Test.Run () [0x00288] in <56ad31002fff4fc994ef8cb8db326f61>:0
  at System.Runtime.CompilerServices.AsyncMethodBuilderCore+<>c.<ThrowAsync>b__7_0 (System.Object state) [0x00000] in <62b430b945fa49a19a75382ef03e7bed>:0
  at Godot.GodotSynchronizationContext.ExecutePendingContinuations () [0x00021] in <290d7f0a416b4017b8b4e458dc10a53c>:0
  at Godot.GodotTaskScheduler.Activate () [0x0000e] in <290d7f0a416b4017b8b4e458dc10a53c>:0
  at (wrapper native-to-managed) Godot.GodotTaskScheduler.Activate(Godot.GodotTaskScheduler,System.Exception&)
ERROR: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.

Wrapped in correct methods in try catch. Just prints out the exception for now. Maybe in future releases, we could add it to the results. Check ce15972cf96c66b311b2aa7dea71607632eb17a0


Handling of long vowel sounds

When converting from Katakana to Hiragana, it seems that the library doesn't handle long vowel sounds properly. For example アタラシー becomes あたらしー but should be あたらしい.

Hi @stephenmac7 , thanks for commenting.  Apologies for the late response, my attention has been elsewhere over the last few months.
To summarize, the purpose of this library is one-to-one character conversion, not translation, which I feel this phenomenon falls into and is not the purpose of the this library.
To elaborate:
This repository is for one-to-one conversion between kana, as well the various full-width/half-width conversions necessary when dealing with Japanese text.  Its primary going to be used for normalization.
However, I do not see the purpose of this repository as translating between different types of Japanese text.  As you said, あたらしい becoming アタラシー would be common in modern Japanese, but it doesn't necessarily get written the way.  There are other words like 東京 which are regularly written in katakana as either トウキョウ or トーキョー.  That is ultimately a stylistic choice, which IMO is the realm of translation, not conversion.
To offer an example, the original reason I wanted a library like this (in Java) was when working on a database in which all Japanese kana text was converted to katakana for the purpose of normalizing it for prefix/suffix searches, like the kind of logic used in an autocomplete system.  This was done to avoid always searching both the hiragana, and katakana versions when users input text for autocomplete, it was more efficient to normalize all Japanese text to either hiragana or katakana.  Then we only have to perform one search whether a user inputs hiragana or katakana into a search box.  So in this kind of use case, and many others I imagine for this library, adding the logical long-vowel switch would effectively break that capability of one-to-one conversions.

Though if you wanted to add this as a conversion option, I would definitely welcome a pull request!

Okay, so it looks like doing this won't work as well as I'd like for オー-type long vowels, because it could convert to う or to お depending on the context, ex. 王[おう] (オー) and 十[とお] (トー). It's not really one-to-one, so requires a bit more intelligence which isn't really part of the aim of this project. Thanks for looking into it though.


Fix typo: use 'decrease' instead of 'increase'

This change is

@rmloveland, is this PR tied to a docs issue?

@rmloveland, is this PR tied to a docs issue?

@jseldess No it just came up when I was doing some reading related to txn pipelining.  Will leave it be for now since there is much else to do. :-)

Closing this since the current language is correct and there is other work to be done at this time.  Sorry for the noise folks.


[Suggestion]: Functionality to copy files, instead of moving them

Might be a bit outside of project scope, but hear me out
I would love to have a library, that would have same usage / api / plugin support, but creating copies of files instead
Basically,  just additional cli flag or interchangeable fork of renamer instead, if you think that this functionality would not belong here
I'm willing to do this by myself, but wanna hear contributors ideas first

Hi, yes I love this idea.. "Rename" is the default action but it would be really useful to make the action user-definable (e.g. "copy", "move" etc).
Will have a look into what is required to make this possible then get back to you.. Did you it explore it any more yourself?


ECS Services always updating but ignore_task_definition_changes  is true

Description
Please provide a clear and concise description of the issue you are encountering, and a reproduction of your configuration (see the examples/* directory for references that you can copy+paste and tailor to match your configs if you are unable to copy your exact configuration). The reproduction MUST be executable by running terraform init && terraform apply without any further changes.
If your request is for a new feature, please use the Feature request template.

[ ] ✋ I have searched the open/closed issues and my issue is not listed.

⚠ Note
Before you submit an issue, please perform the following first:

Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
Re-initialize the project root to pull down modules: terraform init
Re-attempt your terraform plan or apply and check if the issue still persists

Versions

Module version [Required]:

Terraform version: 1.4.6

Provider version(s):
hashicorp/aws = 4.67.0

Reproduction Code [Required]
module "consumer_service" {
 source                             = "terraform-aws-modules/ecs/aws//modules/service"
  version                            = "5.0.0"
  enable_autoscaling                 = false
  subnet_ids                         = ["subnet-da5", "subnet-0d8"]
  deployment_minimum_healthy_percent = 100
  ignore_task_definition_changes     = true
  for_each                           = var.services
  tasks_iam_role_name                = each.key
  task_exec_iam_role_name            = each.key
  name                               = "${var.environment}-consumer-${each.value.name}"
  cluster_arn                        = "arn:aws:ecs:us-east-1:175effefefefef0:cluster/staging-cluster-fefefe35553"
  cpu                                = 2048
  memory                             = 8192
  # Container definition(s)
  container_definitions = {

    (each.value.name) = {
      cpu                       = 512
      memory                    = 2048
      essential                 = true
      readonly_root_filesystem  = false
      essential                 = true
      enable_cloudwatch_logging = false
      image                     = "${var.registry}:${each.value.name}-${var.container_hash}"
      docker_labels = {
        "com.datadoghq.tags.env" : var.environment,
        "com.datadoghq.tags.service" : each.value.name
      },
    }
    }
}

var.services
variable "services" {
  description = "The list of services to deploy"
  type        = any
  default = {
    "person-worker" = {
      name = "person-worker"

    }
    "person-incentive" = {
      name = "person-incentive"
    }

    "user-index-worker" = {
      name = "user-index-worker"
    }
   }

Steps to reproduce the behavior:

Expected behavior

We wanted to deploy about 50 microservices to ECS; there was no way we wanted to be repetitive code for each service, so we used the /forech-each.value attribute, but after the deployment, when we run apply, the task definition says it needs to apply again and again and again. yet we have not updated anything on Terraform
Actual behavior

When you set the ignore task definition, the next time you apply, Terraform should not prompt for changes. Something like No infrastructure changes was found, but this keeps prompting.
Terminal Output Screenshot(s)

 module.consumer_service["user-index-worker"].data.aws_ecs_task_definition.this[0] will be read during apply
  # (depends on a resource or a module with changes pending)
 <= data "aws_ecs_task_definition" "this" {
      + arn                  = (known after apply)
      + arn_without_revision = (known after apply)
      + execution_role_arn   = (known after apply)
      + family               = (known after apply)
      + id                   = (known after apply)
      + network_mode         = (known after apply)
      + revision             = (known after apply)
      + status               = (known after apply)
      + task_definition      = "staging-consumer-user-index-worker"
      + task_role_arn        = (known after apply)
    }

  # module.consumer_service["user-index-worker"].aws_ecs_task_definition.this[0] must be replaced
+/- resource "aws_ecs_task_definition" "this" {
      ~ arn                      = "arn:aws:ecs:us-east-1:175effefefefef0:task-definition/staging-consumer-user-index-worker:73" -> (known after apply)
      ~ arn_without_revision     = "arn:aws:ecs:us-east-1:175effefefefef0:task-definition/staging-consumer-user-index-worker" -> (known after apply)
      ~ container_definitions    = jsonencode(
          ~ [

              ~ {
                  - mountPoints            = []
                    name                   = "user-index-worker"
                  - portMappings           = []
                  - volumesFrom            = []
                    # (14 unchanged attributes hidden)
                },
            ] # forces replacement
        )
      ~ id                       = "staging-consumer-user-index-worker" -> (known after apply)
      ~ revision                 = 73 -> (known after apply)
        tags                     = {
            "environment" = "staging"
            "managed-by"  = "terraform"
        }
        # (9 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Additional context

I was having the same issue when I found your post. Turns out that you must specify some of the properties and their default values that are indicated in your terraform output. So you need to add mount_points = [], port_mappings = [], and volumes_from = [], even though you are not using these and would like to use the default values.
I have no idea why they always have be specified, but it solved the issue for me.

thank you so much @martin-pronestor I will look into this

That suggested workaround didn't resolve this for me.

@bryantbiggs Any thoughts on this issue?

do you have a code reproduction?

This issue has been resolved in version 5.2.1 :tada:

Y'all are awesome. thank you @bryantbiggs


DOC: ignore comments

In the paragraph above, can you update the example so that it refers to TYPE_CHECKING_INVALID_USAGE and the corresponding ignore comment?

Still need to make this change then I think it will be OK


How to forbid swipe back gesture in 3.x?

I'm using react-native-viewpager component in a scene, and i need to forbid swipe back gesture in this scene.
I'm using react-native-router-flux 3.1.5.

No old navigator.sceneConfig support (instead the component uses React Native NavigationAnimatedView for better transitions)
How to use NavigationAnimatedView to forbid swipe back gesture?

Please search for existing issues before creation of new one! Duplicate of #359


Training feedback survey

Edit sidebar JS to allow external links
Add feedback survey and docs link to sidenav

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/257fdfe1ba93bae316f6a4bb92c30f1653cc9421/


[TASK] output the command used for mamba

Issue Description
It would be useful for diagnosing failed installs if the command used to install mamba was output.

For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.

[x] 1. Is it tagged with a type: defect or task?
[x] 2. Is it tagged with a priority: critical, normal or minor?
[x] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[x] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[x] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.

[x] 1. If the issue is a defect, is the defect fixed?
[x] 2. If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[x] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[x] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[x] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

issue closure checklist is good.


How to modify in optimizer_config

Hi Team
Great work and thanks for your contribution!
I'm working on training the mask_rcnn_focalnet_small_patch4_mstrain_480-800_adamw_3x_coco_lrf.py with custom dataset in coco format.

The DistOptimizerHook has been depreciated from mmcv.runner.hooks.optimizer and has been recommended to use OptimizerHook replacing the same.# do not use mmdet version fp16
fp16 = None
optimizer_config = dict(
   type="DistOptimizerHook",
   update_interval=1,
   grad_clip=None,
   coalesce=True,
   bucket_size_mb=-1,
   use_fp16=True,
)

I've replaced with below code which goes with default OptimizerHook# do not use mmdet version fp16
fp16 = None
optimizer_config = dict(
    grad_clip=None,
)

Installed mmcv using source code:git clone https://github.com/open-mmlab/mmcv.git -b 1.x /openmmlab/mmcv \
&& cd /openmmlab/mmcv \
&& MMCV_WITH_OPS=1 pip install --no-cache-dir -e . -v

Would like to know recommended configuration with fp16 and optimizer_config in place DistOptimizerHook for distributed training.

@HostGuest I'm using pytorch 1.9.0; cuda11.1; cudnn8;


VG-4002 Date format fix

Can one of the admins verify this patch?

Current coverage is 72.05%

Merging #26 into master will not affect coverage as of adef593

@@            master     #26   diff @@
======================================
  Files          111     111
  Stmts         7031    7031
  Branches      1000    1000
  Methods          0       0
======================================
  Hit           5066    5066
  Partial        522     522
  Missed        1443    1443

Review entire Coverage Diff as of adef593

Uncovered Suggestions

+0.20% via ...ters/tree-service.js#103...116
+0.13% via ...-scroll-directive.js#151...159
+0.13% via ...ters/tree-service.js#285...293
See 7 more...

Powered by Codecov. Updated on successful CI builds.


vs code cannot find module .vue and package.json

VSCode Version: 1.21
OS Version: 10.13.3

With Visual Studio Code, and automatic type acquisition enabled, there are [js] Cannot find module errors:

on .vue files imported in a .js file (example here)
on package.json imported in webpack.config.js (example here)

How is it possible to fix that?
(I asked on stackoverflow first, but didn't have success)
Thank you

Our built-in intelliesense doesn't support resolving vue files. Please try using vetur or a similar vue extension
Support for importing json files is tracked by: https://github.com/Microsoft/TypeScript/issues/7071

@mjbvz Thank you for your answer. In the project linked above, I use Vetur already and still have errors


TestLoader's support for custom paths

Add support for custom paths (seismic and labels) for both, training and testing purposes.

@maxkazmsft Do you have any idea why the build for this PR tried to pull files related to the old PR #190? Here's the log of one of the failed tasks - https://dev.azure.com/best-practices/deepseismic/_build/results?buildId=22806&view=logs&j=e270fe85-15dd-5bc7-2c45-d05ee72dd816&t=30d6f62d-234c-59b7-740e-7cecd7d3283f&l=32

Needed to push 7e86a2d to fix build issue. Verified that new test cases are being run and succeeding in latest build


Structure the repository

Structure:

README.md

Explanation Powers of Tau
Structure of the repository (folders instructions and contributions)
How we run the ceremony
License

Folder instructions

CONTRIBUTE.md (coordinator, tips for randomness, how to download the software, etc.)
VERIFY.md (instructions to verify the whole ceremony)

Folder contributions

Contributions from 88.
In the README.md file of this folder, clarify where the first 1-87 contributions can be found.
Links to contributions/challenges.

Done and merged.


DateAdapter: issues with setLocale(..) in main vs. lazy loaded module

Bug, feature request, or proposal:
Bug (probably, otherwise docs need to be updated to clarify this behavior).
What is the expected behavior?
I expect the entire application to be in a certain locale, thus it should be enough to set it once using the DateAdapter's setLocale(..).
What is the current behavior?
 As a result, setting the locale (like in the app.component.ts might not work (as one expects) when loading some components within a lazy loaded module (via routing).
What are the steps to reproduce?
Here's a Stackblitz to reproduce the issue: https://stackblitz.com/edit/angular-material-datepicker-locale?file=src%2Fapp%2Fapp.component.ts

Clicking the "test" link loads the lazy /test route. Both, app.module and lazy.module import SharedModule which imports the Material stuff.
The datepicker is in English by default. Clicking the button "set locale on app module" should set it to German, but it doesn't.
Clicking the button "set locale in lazy module" however works as expected.

That makes me think there are 2 instances of the DateAdapter, one for the lazy module and one for the app module.
What is the use-case or motivation for changing an existing behavior?
Usually the locale is very much related to the application language. In most cases you load the user profile when the app starts and based on his settings, cookies or whatever, you set the language and locale respectively. Similarly at the same point you also want to adjust other components' locales such as the Material Datepicker.
The current behavior however is misleading, as one might expect that setting the locale on the DateAdapter object should automatically adjust them for all datepickers. Due to the bug that is not the case for lazy loaded modules however.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?

The problem is that the SharedModule is being imported in the lazy loaded module. The SharedModule then provides a new instance of the DateAdapter which is not equal to the DateAdapter at app root.
Workaround is to just make sure that the MatNativeDateModule is only imported once.

I personally think that it's reasonable to have multiple nested DateAdapter instances and that we should just improve documentation.

A possible workaround is to just make sure that the MatNativeDateModule is only imported once.

Yes sure, that's why usually you have the .forRoot() pattern to avoid multiple registrations of services. Unless the new providedIn: 'root' is being used which would solve it as well.

I personally think that it's reasonable to have multiple nested DateAdapter instances and that we should just improve documentation.

For sure this needs to be documented better 😉.

it's reasonable to have multiple nested DateAdapter instances

🤔 hmm...not sure. Currently thinking about that. How would that work. Like when registered in plain normal modules, there would be just 1 global singleton instance anyway. The "multiple" ones only happens in the lazy loaded modules case as I mentioned, as that one will get its own DI container.
To have different instances within my same app, I'd expect to re-registering the DateAdapter on the providers section of some component to enforce a new instance on that sub-tree. Right?

Yes sure, that's why usually you have the .forRoot() pattern to avoid multiple registrations of services. Unless the new providedIn: 'root' is being used which would solve it as well.

Yeah, if we decide to only have one instance of a DateAdapter per app, then this would be easy to fix by using providedIn: "root".

Regarding multiple DateAdapter instances: technically if people extract stuff into sub modules (regardless of lazy loading; e.g. if they have a shared "company" library), they would most have a different DateAdapter for this specific "feature module".
So I don't think it's right to always assume that the DateAdapter should be provided at root.

To have different instances within my same app, I'd expect to re-registering the DateAdapter on the providers section of some component to enforce a new instance on that sub-tree. Right? And that would work just fine, even with .forRoot() or the new providedIn approach.

That would work, but not sure if if want to go this way API-wise.

Yap that helps. But I moved setLocale() to shared.module and works there also. It was not working in app.module
export class SharedModule {     constructor(private dateAdapter: DateAdapter<any>, private translate: TranslateService) {         this.dateAdapter.setLocale(this.translate.currentLang);         this.translate.onLangChange.subscribe(() => {             this.dateAdapter.setLocale(this.translate.currentLang);         });     } }

setLocale() on every lazy loaded module components which has MatDatePicker feels wrong while doing it. Is there any workaround to make it single instance? Since there is option to make new instance as @juristr mentioned.

I found that calling setLocale in a shared module only works, if it's executed right away. It does not work anymore in the translate onLangChange listener.
So when the user changes the language, I just reload the page for now. then the locale is correctly changed/set.


[otbn] Move to version 0.2

OTBN is now in a consistent state from a specification, RTL,
verification, and software perspective. The respective D1/V1/S1 status
indicates that. We would like to use this opportunity to mark this state
as version 0.1 before we move out of this consistent state again.
Version 0.1 of OTBN isn't perfect -- there are known bugs and gaps in
the implementation, in the verification, in the DIF and test software,
and in the specification, as it would be expected for a design in
L1/D1/V1/S1 state. However, OTBN in its current state is good enough
to be synthesized properly, run RSA and ECDSA-P256 on it, and pass basic
verification. The specification has seen extensive review.
Going forward in version 0.2 we will (re-)open the discussion around some
aspects of the specification, mostly to add security hardening features,
and likely to be better suited for workloads we haven't considered so
far (e.g. SIMD instructions for SHA2).
For now, I'm leaving the D1/V1/S1 status in place (instead of going down
e.g. to D0), as it is still valid. In the past we were able in OTBN to
reasonably synchronously add support for new features to DIF, RTL, and
verification, which would keep the *1 status in place. However, we don't
have that many examples of version bumps in OpenTitan, and with that not
that many established guidelines that we could follow.
Finally: The version number does not have any semantic meaning whatsoever.
Documentation on versioning: https://docs.opentitan.org/doc/project/development_stages/#versioning

No objection, but I think it makes sense to discuss briefly in the silicon meeting on Tuesday to make sure nobody has concerns or is caught by surprise. @tomroberts-lowrisc @dsandrs - do you think it makes sense to put this on the agenda?

I believe the next meeting is cancelled due to conflicts

On 1 Apr 2021, at 08:48, Alex Bradbury @.***> wrote:

No objection, but I think it makes sense to discuss briefly in the silicon meeting on Tuesday to make sure nobody has concerns or is caught by surprise. @tomroberts-lowrisc @dsandrs - do you think it makes sense to put this on the agenda?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

lgtm!


PTFE-421: add option to specify zone at pool level

thanks for your comments I would be testing for that.  I think we might end up doing a full migration to EU and maybe later as I continue to work on adding this feature in the coming week.

[ ]  Check chart for config of zone/ I checked the chart the cloudconfig parameter is empty in the chart so we are good.
[ ] Update other methods.

We can update some of the methods. The hard part is updating the get_all_vms method which is very zone specific. The method is used by the delete_existing_runner method. We can pass in a zone as a parameter but where is this parameter coming from. It can't be from a runner because we are trying to list all runners. We could have a list of zones supported I guess.

We can update some of the methods. The hard part is updating the get_all_vms method which is very zone specific. The method is used by the delete_existing_runner method. We can pass in a zone as a parameter but where is this parameter coming from. It can't be from a runner because we are trying to list all runners. We could have a list of zones supported I guess.
I also found a method in the instancclient class of gcp comoute that can list vms by zone.

Had a look at the source code
And it doesn't seem that zone might be a parameter required, they are pretty vague about it with the mention:

It may require specifying regional endpoints when creating the service

So test, you can create a separate small python script and run it to see how it behaves
Play a bit with it, and we'll assess what we do next.

As discussed adding this feature is harder than expected and not worthy


Target serialization in JSON looks ugly

Currently, SerializedTarget has both kind and crate_types and looks like
{
  "crate_types": ["test"],
  "kind": ["test"],
  "name": "foo",
  "src_path": "/home/user/trash/vvv/tests/foo.rs"
}

I think this particular format is problematic, and I wonder if we could do better.
Here are specific issues:

crate_types and kind almost always duplicate each other, which leaves you wondering which one of the two do you need to look at.

kind conflates two pieces of data in one field: 1) what flag (--bin, --example, --lib, --test) should be used on the command line to refer to the target, 2) what sort of artifact(s) is produced for the target.

kind is mostly an enum, but is serialized into array of strings, which is odd.

In the code, both fields just present the same internal data in two different ways, which is a smell

So, the problem was with the kind field form the start, and crate_types is actually much better!
We have cargo metadata versioning in place, so let's just add version 2, and use a simple string for kind?
cc #3654
@KalitaAlexey @ehuss @alexcrichton what do you think about it?
@KalitaAlexey @ehuss make sure that you explicitly pass --format-version when invoking cargo metadata anyway :)

kind is basically there for backwards compatibility for now, I'd prefer to avoid going to version 2 for now (as that's a pretty weighty change)

kind is basically there for backwards compatibility for now, I'd prefer to avoid going to version 2 for now (as that's a pretty weighty change)

Hm, you need kind to decide which argument do you need, --example or --lib. Just crate_types will be insufficient in this case I think?
I'm OK with the current format, it works for all use cases so far, it's just not as good as it could be :)

Oh yeah I'd definitely agree that it's not as good as it could be! I wouldn't mind adding more docs/fields and indicate "don't look at this field" or "look at this field" or something like that.

I am trying to write some docs for this now, and I don't seem able to write what crate_type field stands for.
It is definitely not a crate_type from the reference: there is no example or custom_build crate type. Also, the fact that for ExampleBin crate_types field is example and not bin seems just wrong to me.
What do you thing about changing crate_types  to precisely correspond to crate_type attribute?

Guh. It it suspposed to be precisely what the crate_type attribute is, it appears I didn't review closely enough... I think we may be able to change though as it's a pretty recent feature.

Guh. It it suspposed to be precisely what the crate_type attribute is, it appears I didn't review closely enough... I think we may be able to change though as it's a pretty recent feature.

Will try to fix that tomorrow!

Thanks!


Support 'null' return values.

typeof null === 'object'. Therefore if a script expression is evaluated to null, this line threw an error when trying to access the property 'then' of null.

Ooops! Thanks for spotting this!

Shipped in v2.7.3.


Add documentation link to README

What does this PR do?
Add a link to the OpenVINO documentation in the README.
Before submitting

[x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


This is not how you use the issues tab on github


Server folder usage

Why server folder is required to run jest-puppeteer tests. If I exclude it I get below error:

jest --verbose --no-cache --runInBand

Determining test suites to run...internal/modules/cjs/loader.js:905
throw err;
^
Error: Cannot find module 'C:\Users...\server'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:902:15)
at Function.Module._load (internal/modules/cjs/loader.js:746:27)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)
at internal/main/run_main_module.js:17:47 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}
Regards,
Amit

💬 Questions and Help
Jest Puppeteer project is young, but please before asking your question:

Read carefully the README of the project
Search if your answer has already been answered in old issues

After you can submit your question and we will be happy to help you!

server isn't required unless you specify it in your config file. Can you share your config and setup?

Thanks UziTech.
That was great hint. I removed the server details from jest-puppeteer.config.js and removed server folder and it is working.


How do you implement subcommand menus?

Is your feature request related to a problem? Please describe.
What's the best way to implement subcommand menus? Specifically, I'd like the following behavior:

User opens command palette, sees 2 options: "Foo" and "Bar"
If the user selects "Foo", the command palette closes, and the "Foo" command executes.
If the user selects "Bar", the command palette stays open, and shows another set of commands that the user can select from.

I saw the conversation at #362, as well as the example here. It seems like I can mostly get what I want by adding some logic to the onSelect callback that generates a new set of commands.
The one problem I can't figure out is how to keep the command palette open after selecting the "Bar" command (from the example above). I could toggle a state variable on onSelect that changes the closeOnSelect prop, but unfortunately that doesn't seem to work.
What's the recommended approach here?
Describe the solution you'd like
Some way to selectively keep the command palette open based on the selected command.
Describe alternatives you've considered
This unfortunately does not work:
export const Example = () => {
  const [commands, setCommands] = useState([...]);
  const [closeOnSelect, setCloseOnSelect] = useState(true);

  return (
    <CommandPalette
      closeOnSelect={closeOnSelect}
      commands={commands}
      onSelect={(command) => {
        if (<should get subcommands>) {
          setCommands(<get subcommands>);
          setCloseOnSelect(false);
        } else {
          setCloseOnSelect(true);
        }
      }}
    />
  );
};

@calvinwyoung if memory serves, setting closeOnSelect to false should do the trick. If it doesn’t or you want an example please LMK, I’m pretty close to landing the VS Code theme which does exactly what you want but the docs aren’t ready

Great, thank you! I'll go aheand and close this issue, and will wait for you to have a chance to update the docs.

@calvinwyoung after poking around I think open should mage the display of the component anytime it’s changed. I hadn’t envisioned this use case. I’ll go ahead and put this on the top of my queue. Thanks for raising this issue.

@asabaylus Awesome, thanks so much!

@calvinwyoung I've been swamped at work and this issue is next on my list I hope to have something soon but it looks like I may need to fix a bug.


fix missing return statement. Do not normalize remote paths

What does this PR do?
Fixes two issues found with #2164 merged yesterday. Local paths worked, but remote directory writing broke in a rebase. My bad.
This was now tested by training and passing --default_root_dir='s3://mybucket/ at training and verified all files write successfully to an s3 bucket. v_num successfully increments on multiple runs. Pointing a tensorboard at the s3 bucket successfully live updates while model is training.
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[X] Did you read the contributor guideline, Pull Request section?
[X] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
[X] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
yup!

@rohitgr7 Thanks! Added your suggestion.

Just updated the PR to add documentation of the remote directory support.

@f4hy The last sentence is missing a word I think

@f4hy The last sentence is missing a word I think

Hmm. Last sentence where? Sorry, not seeing it. I am sure you are right.


Update trigger-on-a-new-artifact.md

What Type of PR is This?
Correcting the note on the conditions when the trigger will execute the pipeline, and clarifying that we don't need a artifact source for the trigger to work

Preview environment: https://hdh.pr.harness.io/pr-1022

Preview environment: https://hdh.pr.harness.io/pr-1022


[Question]: How to boot from local image?

Is your question not already answered in the FAQ?

[X] I made sure the question is not listed in the FAQ.

Is this a general question and not a technical issue?

[X] I am sure my question is not about a technical issue.

Question
I am sorry if this sounds dumb, but how exactly do you boot using a local image? Even after adding the volume in the docker compose file according to the FAQ, the boot variable is not ignored, still downloading from whatever URL was provided to the variable.
Am i missing something here? Could you provide a working example of how the docker compose file should look like?

Thank you for the quick response!

The volume is incorrect...
It must be something like:
volumes:
  -  c:/Users/ajuscu/Downloads/ipxe.iso:/boot.iso

instead..

Oh so it has to be specifically those 3 types, ok my bad and thank you for the answer!

Just want to add more thing, so the fix you provided worked, but only after i left BOOT variable empty. If any URL is provided to the variable, even with the path being correct it still does not ignore the URL in the BOOT variable.
Lucky me i have looked around old issues and found this solution on one closed ticket some time ago. I do not know if this is intended or not, or i am still doing something wrong.
Here is a picture as well with the working compose file:

Hi there, sorry for the late reply, so you are correct, even when having a valid URL link, first it tries to boot \boot.iso. Why it didnt worked at first was again a mistake on my part when i added the path to the .iso file. Had lowercase instead of uppercase C


BasicSample could not run bc java.lang.NoSuchMethodError: java.nio.file.Path.of(Ljava/lang/String;[Ljava/lang/String;)Ljava/nio/file/Path

Issue with the samples?
➜  BasicSample git:(master) ./gradlew clean assemble

> Configure project :app
WARNING: DSL element 'android.dataBinding.enabled' is obsolete and has been replaced with 'android.buildFeatures.dataBinding'.
It will be removed in version 5.0 of the Android Gradle plugin.

> Task :app:compileDebugJavaWithJavac FAILED
warning: Current JDK version 1.8.0_172-b11 has a bug (https://bugs.openjdk.java.net/browse/JDK-8007720) that prevents Room from being incremental. Consider using JDK 11+ or the embedded JDK shipped with Android Studio 3.5+.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:compileDebugJavaWithJavac'.
> java.lang.NoSuchMethodError: java.nio.file.Path.of(Ljava/lang/String;[Ljava/lang/String;)Ljava/nio/file/Path;

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.7.1/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 4s
46 actionable tasks: 43 executed, 3 up-to-date

Android Studio: 4.1.0
➜  BasicSample git:(master) java -version
java version "1.8.0_172"

Facing same issue while running BasicSample

It is found that the problem is room 2.4.0. If you restore the version to the previous 2.0.0, there will be no problem

downgrade versions.room = "2.4.0-alpha05" to versions.room = "2.3.0" fixed this problem~


Add compose key support for japanese keyboard

I have been using the composekey extensions with a japanese keyboard successfully for a while on my Chromebook (using dev mode and modifying the vanilla manifest).
I am using this so far
    {
      "name": "Compose Key (for Japanese keyboard)",
      "type": "ime",
      "id": "compose_key_jp",
      "description": "Adds Compose key functionality to the JP keyboard.",
      "language": "ja",
      "layouts": ["jp"]
    }

However, I cannot use this with my kids' Chromebook as they are on managed profiles (no dev mode there).
Is it possible to add this to the mainstream extension if it is not a problem ?

It doesn't work for me. I have a chromebook (not dev mode) & it doesn't work for me either. It functions as a standard english keyboard , without any composekey support even in English. I've tried adding composekey support for other languages too. Sometimes it works, sometimes it doesn't. Occasionally it doesn't even show up in the list of inputs as in the case of Vietnamese when I tried to add it. I have versions for Russian & Greek which both work as expected.

It doesn't work for me. I have a chromebook (not dev mode) & it doesn't work for me either. It functions as a standard english keyboard , without any composekey support even in English. I've tried adding composekey support for other languages too. Sometimes it works, sometimes it doesn't. Occasionally it doesn't even show up in the list of inputs as in the case of Vietnamese when I tried to add it. I have versions for Russian & Greek which both work as expected.

I don't know if you did it on your end, but I know that on my device, I needed to add the language written in the manifest for the keyboard to appear in the candidate list.
For instance, my system is using English as display language, English and Japanese as languages, and then my Compose Key for Japanese layout pops up. If I have no japanese language enabled at all, it wouldn't appear.
Honestly I don't really understand what's happening with country-based locales.
For instance, having "English" as language doesn't propose me spell checking, and if my keyboard is set with manifest "en", it doesn't work.
However, "English (UK)" enables spell checking for UK, and I think I remember seeing the keyboard appearing in that case (or did I put en-UK as a language in the manifest ? Don't remember).
Odd enough, having "French" only works, as well as "French (France)". Kind of a mystery to me.
In my case, I decided that having to add Japanese as a language (which is not that strange if you have a japanese keyboard after all) would be just enough if it allowed me to keep the manifest simple and avoid dupes for each possible language the user may have.

I don't know if you did it on your end, but I know that on my device, I needed to add the language written in the manifest for the keyboard to appear in the candidate list.
For instance, my system is using English as display language, English and Japanese as languages, and then my Compose Key for Japanese layout pops up. If I have no japanese language enabled at all, it wouldn't appear.
Honestly I don't really understand what's happening with country-based locales.
For instance, having "English" as language doesn't propose me spell checking, and if my keyboard is set with manifest "en", it doesn't work.
However, "English (UK)" enables spell checking for UK, and I think I remember seeing the keyboard appearing in that case (or did I put en-UK as a language in the manifest ? Don't remember).
Odd enough, having "French" only works, as well as "French (France)". Kind of a mystery to me.
In my case, I decided that having to add Japanese as a language (which is not that strange if you have a japanese keyboard after all) would be just enough if it allowed me to keep the manifest simple and avoid dupes for each possible language the user may have.


RC test: Natural Selection 1.1.0-rc.2

@amanda-phet @ariel-phet, natural-selection/1.1.0-rc.2 is ready for RC testing.
Ideally, we'd like to finish this by noon on Tuesday, 9/1/2020.  It should be quick - there are only 2 issues to spot check.
Document issues in https://github.com/phetsims/natural-selection/issues and link to this issue.
Assigning to @ariel-phet for prioritization.

General RC Test

What to Test

Click every single button.
Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.

If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.
Test all query parameters on all platforms. (See QA Book for a list of query parameters.)
Download HTML on Chrome and iOS.
Make sure the iFrame version of the simulation is working as intended on all platforms.
Make sure the XHTML version of the simulation is working as intended on all platforms.
Complete the test matrix.
Don't forget to make sure the sim works with Legends of Learning.
Test the Game Up harness on at least one platform.
Check this LoL spreadsheet and notify AR or AM if it not there.
If this is rc.1 please do a memory test.
When making an issue, check to see if it was in a previously published version
Try to include version numbers for browsers
If there is a console available, check for errors and include them in the Problem Description.
As an RC begins and ends, check the sim repo. If there is a maintenance issue, check it and notify developers if there is a problem.

Focus and Special Instructions
@KatieWoe would you please test LoL?

Issues to Verify

[x] Appearance of "Zoom out to see data." is inconsistent
[x] Population graph should not display "Zoom out..." message when all checkboxes are unchecked

These issues should have the "status:ready-for-qa" label. Check these issues off and close them if they are fixed.
Otherwise, post a comment in the issue saying that it wasn't fixed and link back to this issue. If the label is
"status:ready-for-review" or "status:fixed-pending-deploy" then assign back to the developer when done, even if fixed.

Link(s)

Simulation
iFrame
XHTML
Test Matrix - N/A, this is a spot check
Legends of Learning Harness

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

Platforms to test:

[ ] Win 10 Chrome
[ ] Win 10 Firefox
[ ] Win 10 Edge
[ ] Mac 10.15 Chrome
[ ] Mac 10.15 Safari
[ ] iPadOS Safari
[ ] ChromeOS

LoL looks ok on Win 10 Chrome

I tested LoL on macOS Safari and macOS Chrome.

The two issues to verify looked good. Also performance seemed great on the two Mac browsers I tested.

All look great to me on all platforms, all issues verified. Back to @pixelzoom to publish!

👍🏻 Closing.


Index PTN IDs

Hello,
It would be very useful if PTN IDs were searchable in AmiGO.
:)
Thanks, Pascale

I'm fold this as an addition to #79.

They should already be searchable. I'll retest this today to see. You
should be able to type just about anything into the gene search box.
On Thursday, November 10, 2016, pgaudet<EMAIL_ADDRESS>wrote:

Hello,
It would be very useful if PTN IDs were searchable in AmiGO.
:)
Thanks, Pascale
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/geneontology/amigo/issues/403, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABcuEIr7VLj73oLeP8dg3E5Cwv8r32_Tks5q84H6gaJpZM4KvHa2
.

This would be great, but would presumably be of limited use without
including a way to hop from the PTN to the extant child nodes (and
possibly up to ancestors, but I think we can do a good job without
implementing a full blown tree view)
Shall we sketch out some requirements here and then prioritize?
On 10 Nov 2016, at 12:43, pgaudet wrote:

Hello,
It would be very useful if PTN IDs were searchable in AmiGO.
:)
Thanks, Pascale
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geneontology/amigo/issues/403

Yes let's do that Chris
On Thu, Nov 17, 2016 at 2:33 PM, Chris Mungall<EMAIL_ADDRESS>wrote:

This would be great, but would presumably be of limited use without
including a way to hop from the PTN to the extant child nodes (and
possibly up to ancestors, but I think we can do a good job without
implementing a full blown tree view)
Shall we sketch out some requirements here and then prioritize?
On 10 Nov 2016, at 12:43, pgaudet wrote:

Hello,
It would be very useful if PTN IDs were searchable in AmiGO.
:)
Thanks, Pascale
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geneontology/amigo/issues/403

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/geneontology/amigo/issues/403#issuecomment-261391312,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABcuEBLehQj-MkUEHsy6UHHHZpdX4tJjks5q_NY7gaJpZM4KvHa2
.


Access to an undefined property on Models attributes

Larastan Version: 0.6.2
--level used: 5

Description
I have many models where I'm getting "Access to an undefined property...", these are database column attributes no accessor or custom stuff.
 ------ ---------------------------------------------------------------------------
  Line   Http/Controllers/MacroController.php
 ------ ---------------------------------------------------------------------------
  69     Access to an undefined property App\Models\Macro::$name.
  70     Access to an undefined property App\Models\Macro::$comment.
  71     Access to an undefined property App\Models\Macro::$priority.
  72     Access to an undefined property App\Models\Macro::$status.
  73     Access to an undefined property App\Models\Macro::$enabled.

Laravel code where the issue was found
    use App\Models\Macro;

    /**
     *
     * @param Request $request
     * @param Macro $macro
     * @return \Illuminate\Http\JsonResponse
     */
    public function store(Request $request, Macro $macro) {
        $this->authorize('create macro');
        $this->validate($request, $rules, $messages, $customAttr);

        $macro->name = $request->input('name');
        $macro->comment = $request->input('comment');
        $macro->priority = $request->input('priority');
        $macro->status = $request->input('status');
        $macro->enabled = $request->input('enabled');
        $status = $macro->save();

        ...
        return response()->json([
              'status' => $status,
              'data' => $macro
        ]);

    }

Model code
namespace App\Models;

use Illuminate\Database\Eloquent\Model;

class Macro extends Model {

    /**
     * The database table used by the model.
     *
     * @var string
     */
    protected $table = 'macros';

}

Database table
+-----------------+------------------+------+-----+-------------------+-----------------------------+
| Field           | Type             | Null | Key | Default           | Extra                       |
+-----------------+------------------+------+-----+-------------------+-----------------------------+
| id              | int(10) unsigned | NO   | PRI | NULL              | auto_increment              |
| name            | varchar(255)     | NO   |     | NULL              |                             |
| enabled         | tinyint(1)       | NO   |     | 0                 |                             |
| priority        | varchar(255)     | YES  |     | NULL              |                             |
| status          | varchar(255)     | YES  |     | NULL              |                             |
| comment         | longtext         | YES  |     | NULL              |                             |
| created_at      | timestamp        | NO   |     | CURRENT_TIMESTAMP |                             |
| updated_at      | timestamp        | NO   |     | CURRENT_TIMESTAMP | on update CURRENT_TIMESTAMP |
+-----------------+------------------+------+-----+-------------------+-----------------------------+

Am I doing something wrong? Do I need to write docblocks with properties on each model class?
Thanks!

Larastan should recognize your model's fields.
Is your migration file okay?

@szepeviktor yes, this is how migrations looks like:
class CreateMacrosTable extends Migration {

    protected $table = 'macros';

    public function up() {
        Schema::create($this->table, function (Blueprint $table) {
            $table->increments('id');
            $table->string('name');
            $table->boolean('enabled')->default(false);
            $table->string('priority')->nullable();
            $table->string('status')->nullable();
            $table->longText('comment')->nullable();
            $table->timestamps();
        });
    }

    public function down() {
        Schema::dropIfExists($this->table);
    }

}

Hi @LucianoVandi
Looks like it is because of the usage of $this->table. Larastan doesn't resolve that, and it just expects string there.
You can solve it by just inlining the $this->table
Later I'll check if it's possible to resolve the value in Larastan.

Hi @canvural, thanks. I've inlined table_name on both Schema::create() and Schema::dropIfExists(), still get the same result. I'm trying to debug ModelPropertyExtension::hasProperty() to see the results of initializeTables() but it seems never gets called.

Do you have the migrations in the default place or somewhere custom?

Default location: /database/migrations/2016_03_18_170645_create_macros_table.php

@canvural sorry, do larastan uses a cache? I've made a small change to the controller, not related with this issue, and now the errors disappeared. -_-
Now I have these left:
 ------ -----------------------------------------------------------------------------
  Line   Http/Controllers/UserController.php
 ------ -----------------------------------------------------------------------------
  132    Access to an undefined property Spatie\Permission\Models\Role::$name.
  163    Access to an undefined property Spatie\Permission\Models\Role::$name.
  270    Access to an undefined property Spatie\Permission\Models\Permission::$name.
  289    Access to an undefined property Spatie\Permission\Models\Role::$name.
 ------ -----------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------
  Line   Http/Requests/UpdateUser.php
 ------ --------------------------------------------------------------------------
  38     Access to an undefined property Spatie\Permission\Models\Role::$name.
 ------ --------------------------------------------------------------------------

In both files I'm using Role::find(), this time I have the migration file but it's from the v1 of the spatie/laravel-permission, then upgraded to last versions with this custom migration

PHPStan caches everything.
Issue vendor/bin/phpstan clear-result-cache

Alternatively you can run https://github.com/barryvdh/laravel-ide-helper add the phpdoc @property directly to your model.

Markus we may disagree on that ide-helper. When I was searching for a way to run PHPStan on WordPress code I realized that software is a no-go.

@mfn I'm already using barryvdh/laravel-ide-helper, but with the option --nowrite to write on a separate file.

So with inlining the table name your problem is solved?
About the Spatie Role model, Larastan can't parse the migration because of the usage of $tableNames in the upgrade migration. There is nothing we can do.
If you want you can create a stub for the Role model by yourself and add the properties.

@canvural yes inlining table_name solved the problem, I will look into creating stubs for Spatie\Permission\Models. Thanks for your help and for the effort in maintaining Larastan! Have a nice day. ;)

but with the option --nowrite to write on a separate file.

If you write them, static analyzers automagically pick them up btw


any ideas on how to work with ModEngine together?

get mods on along with the frame unlock and speeding up%.

I would like to know if this is possible as well.

I don't believe they're mutually exclusive. The FPS Unlocker patches the game in RAM while it is running, it doesn't modify any game files. I use it alongside a mod engine randomizer, and you should be able to do the same with other mods.


Don't preventDefault on events. Fixes #803

It seems that we started calling event.preventDefault on all .NET-handled events in this commit: https://github.com/aspnet/Blazor/commit/36f5c5898820899831447b3dbde5e8658cc0baaa
It's not explicitly stated why I added that line in that commit, but my guess now is that it was needed because we didn't yet have the "internal link click" handling logic that we now do (which does call preventDefault when it recognizes clicks on internal links).
So it looks like we can fix #803 and all related issues trivially just be removing the event.preventDefault call. It doesn't appear to affect anything else negatively, and conceptually should be the right thing to do because saying you want to handle an event is not the same as saying you want to prevent its default actions.

Merging now so I can proceed to make an RC build, but CC @rynowak @javiercn in case either of you can think of any reason why the change in this PR is not the right thing to do.

Looks straightforward to me.

Wouldn't this cause problems for things like onsubmit handlers for forms where it will also submit the form or for a tags follow the hrefs if there?

@SteveSandersonMS I observed the problem raised by @schotime since 0.4


Problems with g-image

Description
On my local environment I’m getting the following error when I’m using g-image: Error: write EPIPE at WriteWrap.onWriteComplete [as oncomplete] (internal/stream_base_commons.js:66:16)
Publishing on Netlify works fine, but annoying since I can’t see the images on my machine. Any one else experiencing this as well?

This PR should fix the issue. Will publish it within the next days if it works well :)

@hjvedvik Works fine now :)


Severe execution blocking

So yeah, this plugin seems to block execution quite badly. I'm trying to make the flashlight flash (on off on off... etc) by calling toggle on every animation frame and the entire ui of my app is blocked, css animations get stuck and input isn't always processed anymore because the plugin takes way too long to execute.
It works well, but it is far from optimised.

Alright so I dove into the source code for Android a bit and I'll try to clean things up without breaking current implementations, if shit goes fine, I'll propose a PR.

On which platform did you experience this?

I get this warning during launch of my app on iOS (tried iphone 5s and iphone 4):
THREAD WARNING: ['Flashlight'] took 36.587158' ms. Plugin should use a background thread.

Same issue here : it happens only on Samsung Galaxy S5 in cordova release mode and the toggle method is called when the user taps a button. The result is : the camera of the device is not working anymore, I have to manually kill the app to access the camera again. Here is the code :

if (window.plugins && window.plugins.flashlight) {

  window.plugins.flashlight.available(function (isAvailable) {

    if (isAvailable) {

      window.plugins.flashlight.toggle(function () {

          isOn = !isOn;

        });

      }

  });

}

Android takes too long the turn its camera off and on again.
I implemented a third parameter to switchOff(null, null, true) to avoid turning the camera off completely and changing only the flashlight parameter.
https://github.com/lucasdupin/Flashlight-PhoneGap-Plugin

Interesting addition. You'll only use that if you need to blink it repeatedly, right?
What happens if you use the soft switch off and open the camera app? Does it have trouble accessing the camera?

Right, only if you need to blink it repeatedly.
You must turn it off with switchOff(); to release the camera before quitting your app/activity.
But either way, this is something you are probably already doing.

FYI On Android the plugin now executes everything on a background thread (v 3.1.0)


[ACR] Add support to get build details or logs by an image

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

/cc @northtyphoon @ehotinger @sajayantony


Fedora support by adding :Z suffix option to docker --volume

❯ ./gradlew bufLint

> Task :app:bufLint
Emulate Docker CLI using podman. Create /etc/containers/nodocker to quiet msg.
Resolving "bufbuild/buf" using unqualified-search registries (/etc/containers/registries.conf)
Trying to pull registry.fedoraproject.org/bufbuild/buf:0.54.1...
Trying to pull registry.access.redhat.com/bufbuild/buf:0.54.1...
Trying to pull docker.io/bufbuild/buf:0.54.1...
Getting image source signatures
Copying blob sha256:229ec212b546059c5669d1addfce96ea3dc25db2e5c6eeb94d73df54a1f06d0c
Copying blob sha256:a07461379343c0fd0dec23271d4583c31e689c5efc372876359f7bef71214a26
Copying blob sha256:5843afab387455b37944e709ee8c78d7520df80f8d01cf7f861aae63beeddb6b
Copying blob sha256:5843afab387455b37944e709ee8c78d7520df80f8d01cf7f861aae63beeddb6b
Copying blob sha256:a07461379343c0fd0dec23271d4583c31e689c5efc372876359f7bef71214a26
Copying blob sha256:229ec212b546059c5669d1addfce96ea3dc25db2e5c6eeb94d73df54a1f06d0c
Copying config sha256:a15cd6451bffd2f7ab5f609c4b66576eb75035879771fc52d1a9111dce9ed060
Writing manifest to image destination
Storing signatures
Failure: stat /workspace/buf.work.yaml: permission denied.

> Task :app:bufLint FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:bufLint'.
> Process 'command 'docker'' finished with non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 6s
3 actionable tasks: 3 executed

The Failure: stat /workspace/buf.work.yaml: permission denied. is because I'm using https://podman.io instead of https://www.docker.com on Fedora Linux (with the podman-docker package, which aliases docker to podman, as the Emulate Docker CLI using podman. Create /etc/containers/nodocker to quiet msg. message reveals.)
Podman supports SELinux on Fedora, which causes it to be a PITA; repro:
$ podman run --volume "$(pwd):/workspace" --workdir /workspace bufbuild/buf lint
Emulate Docker CLI using podman. Create /etc/containers/nodocker to quiet msg.
Failure: could not clean relative path "".

As per https://github.com/containers/podman/issues/3683#issuecomment-517239831 (also https://github.com/moby/moby/issues/30934), this can be solved like this:
$ podman run --volume "$(pwd):/workspace:Z" --workdir /workspace bufbuild/buf lint

Note the :Z suffix option to docker --volume. Would you consider adding this :Z? It should cause no problems on docker instead of podman on Linux distributions without SELinux, as it should be ignored there.

Until this is fixed, there is a workaround:
$ podman run --volume "$(pwd):/workspace:z" --workdir /workspace bufbuild/buf lint

Note the lower- instead of upper-case :zsuffix - this applies an SELinux label allowing access by all containers - and buf-gradle-plugin works. This is more of a "hack" than a "solution" though - the Gradle plugin should just work out of the box on Fedora (and other Linux distributions with SELinux enabled), as the proposed PR would allow it to.

Thanks for the report and the contribution! Published in 0.2.3.

@vorburger If you're feeling adventurous I just published a new version that doesn't use Docker. Feel free to try it out and report back if you have any issues.


#3450: Update Bootstrap to 5.2.

Note
Primarily marked as draft to ensure someone doesn't review+approve+merge
without ensuring all the little boxes are ticked. Aside from unticked boxes
we do think this is ready to go.

Resolves #3450
Description
Upgrading Bootstrap!

Type of change

Dependency change
This change requires a documentation update (I think?)

How Has This Been Tested?
The test suite now passes, thanks to @jamesiarmes's work
We still have visual testing to do, enumerated below

Screenshots

Rounded corners
Before:

After:

(This can be easily adjusted)
Pages edited in this branch that we should scrutinize for visual problems
This is a summary created by going through what's been changed in this PR. Changes include —
Anything that opens and closes modals, including:

[ ] the add user / invite user modal
[ ] the "Add Vendor" link on the new purchase
[ ] the "Add Vendor" link on the edit purchase (not the same line of code as above)

The little x icon you can use to close

[ ] new vendor modal
[ ] the CSV import modal, accessed by using the buttons "Import Product Drive Participants", "Import Partners", "Import Donation Sites", "Import Storage Locations", and "Import Baseline Inventory"
[ ] the "Calculate Product Totals" modal
[ ] the reject account request modal
[ ] the new vendors modal, the new product drive participants modal, and the new manufacturers modal, especially when you invoke them via JS xhr. Not sure if this xhr is used for pages that display these records in bulk, or for the new donations page, or both
[ ] user new password modal, especially the "I understand" button
[ ] the "View Original" button on the organization page that shows for organizations that have logos

A dismissable alert that can show up as a modal

[ ] when adding a manufacturer
[ ] somehow at the top of the pages that partners see (details?)
[ ] the modal button helper, used to make buttons that read "Add New Barcode", "Reset Partner Password", "See Zipcodes?", "Add User To Partner", "Calculate Product Totals", "Invite User to this Organization"— there are two of this last button, one each for the users page and the organization page. This helper is also used for most of the CSV import modal buttons listed above
[ ] a "continue to the test site" button
[ ] the close button on the barcode modal

Anything else also using Bootstrap buttons, including:

[ ] the donation sites form where you can add rows to the form
[ ] the "Log in" button on the login page
[ ] the "Send me reset password instructions" and "Return to log in page" buttons on the new password page

Anything with Bootstrap toggle functionality, including:

[ ] dropdown menus including

[ ] the user profile nav bar dropdown
[ ] an "Actions" button that shows up when viewing a user — it shows up only if you're a super-admin or org-admin
[ ] other nav bar dropdowns

[ ] the list of storage locations with inventory info
[ ] the "Partners" and "Groups" tabs on the partners index page
[ ] the partner questions, both on the admin side where you manage them and at the /partner/help/ page (having trouble finding a link that takes you to that page)
[ ] there's also questions that are specifically for banks
[ ] the items page tabs that say things like "Item List", "Items, Quantity, and Location", "Kits", etc.

Anything with the new Bootstrap rounded corners, including:

[ ] any flash / alert message
[ ] the partner request history table
[ ] the "distributions" and "requests in progress" sections on the partner dashboard

Anything using tooltips:

[ ] the partners family form. It has text like "Case Manager" that has a tooltip which reads "Person at the
agency who is assigned to this family" as well as a few other tooltips, each should be checked for visual issues separately

Anything that uses some of the background gradient options:

[ ] The "Past Donations from..." section on the manufacturers page
[ ] Most of the cards on the dashboard that we're now rewriting. Of note, the Announcements card shows up only when global announcements exist.

Any forms using file uploads, including

[ ] the proof of partner 501(c)(3) status attachment
[ ] The partner Form 990 upload
[ ] the "Additional Documents" for partners
[ ] the "Click the choose file button" section on the CSV upload modals

The layout of pretty much all forms, especially

[ ] form groups, the placement of form groups and the placement of fields inside form groups
[ ] labels work — they're still clickable to highlight their associated control and they are placed correctly.

Badges

[ ] The badge indicators that show up for partners, for example next to where it says "Organization Details" or "Edit My Organization"
[ ] the "n New Users" and "n New Organizations" badges on the admin dashboard
[ ] The "expired" badge on announcements
[ ] The badge that contains a number of "Pick-ups remaining this week"

We walked through this together in person and it all looks good to me. The hard part is that now we need to do a visual regression check. The above checklist is meant to be a guide, but whatever we need to do to verify. There are no known issues.
We'll need to resolve conflicts as it ages while we do the review.

This is going to take a bit to review -- hope to start on it today.   Noting that there are some conflicts to resolve.  Also, that it is still marked "draft"

I feel like we should do a thorough check in Chrome, and some spot checks in Firefox and Safari.  I'm going to attack Chrome first, and just use this comment to keep track of what is/is not done -- at least until I unearth something that needs attention.  These will be tests on a local in Chrome.
Not done:
Anything that opens and closes modals, including:
the add user / invite user modal
the "Add Vendor" link on the new purchase
the "Add Vendor" link on the edit purchase (not the same line of code as above)
The little x icon you can use to close
new vendor modal
the CSV import modal, accessed by using the buttons "Import Product Drive Participants", "Import Partners", "Import Donation Sites", "Import Storage Locations", and "Import Baseline Inventory"
the "Calculate Product Totals" modal
the reject account request modal
the new vendors modal, the new product drive participants modal, and the new manufacturers modal, especially when you invoke them via JS xhr. Not sure if this xhr is used for pages that display these records in bulk, or for the new donations page, or both
user new password modal, especially the "I understand" button
the "View Original" button on the organization page that shows for organizations that have logos
A dismissable alert that can show up as a modal
when adding a manufacturer
somehow at the top of the pages that partners see (details?)
the modal button helper, used to make buttons that read "Add New Barcode", "Reset Partner Password", "See Zipcodes?", "Add User To Partner", "Calculate Product Totals", "Invite User to this Organization"— there are two of this last button, one each for the users page and the organization page. This helper is also used for most of the CSV import modal buttons listed above
a "continue to the test site" button
the close button on the barcode modal
Anything else also using Bootstrap buttons, including:
the donation sites form where you can add rows to the form
the "Log in" button on the login page
the "Send me reset password instructions" and "Return to log in page" buttons on the new password page
Anything with Bootstrap toggle functionality, including:
dropdown menus including
the user profile nav bar dropdown
an "Actions" button that shows up when viewing a user — it shows up only if you're a super-admin or org-admin
other nav bar dropdowns
the list of storage locations with inventory info
the "Partners" and "Groups" tabs on the partners index page
the partner questions, both on the admin side where you manage them and at the /partner/help/ page (having trouble finding a link that takes you to that page)
there's also questions that are specifically for banks
the items page tabs that say things like "Item List", "Items, Quantity, and Location", "Kits", etc.
Anything with the new Bootstrap rounded corners, including:
any flash / alert message
the partner request history table
the "distributions" and "requests in progress" sections on the partner dashboard
Anything using tooltips:
the partners family form. It has text like "Case Manager" that has a tooltip which reads "Person at the
agency who is assigned to this family" as well as a few other tooltips, each should be checked for visual issues separately
Anything that uses some of the background gradient options:
The "Past Donations from..." section on the manufacturers page
Most of the cards on the dashboard that we're now rewriting. Of note, the Announcements card shows up only when global announcements exist.
Any forms using file uploads, including
the proof of partner 501(c)(3) status attachment
The partner Form 990 upload
the "Additional Documents" for partners
the "Click the choose file button" section on the CSV upload modals
The layout of pretty much all forms, especially
form groups, the placement of form groups and the placement of fields inside form groups
labels work — they're still clickable to highlight their associated control and they are placed correctly.
Badges
The badge indicators that show up for partners, for example next to where it says "Organization Details" or "Edit My Organization"
the "n New Users" and "n New Organizations" badges on the admin dashboard
The "expired" badge on announcements
The badge that contains a number of "Pick-ups remaining this week"
Done:

Hailing @scooter-dangle -- Could you check that the barcodes work with this branch, please?

@h-m-m small note on the product totals modal.  It looks like we've introduced a highlight bar (this behaviour is not showing on the main branch on staging).   Could that highlight bar be a different colour?  -- it kind of blends in to the alternating row colours a.t.m. -- if I were to choose, I'd say the colour we use for highlights in the left hand menu would do.


optimize values list execution plan by moving the evaluation part to execution phase

I wonder what you think about moving the creation of the actual RecordBatch from ValuesExec::try_new to execute -- the rationale would be to make PhysicalPlan creation faster and push the actual work into execute where if can potentially be run concurrently with other parts
Given the size of data in a VALUES statement, this is not likely to be any real difference so I am fine with leaving the creation in the same place too -- I just wanted to mention it.
Originally posted by @alamb in https://github.com/apache/arrow-datafusion/pull/1165#r734957534

It seems statistics computation in ValuesExec still need the evaluation result.
It is ok to ignore this by creating default statistics? or we need iterate data again to compute statistics?

I think don't think adding an RwLock sounds like a good idea. Perhaps we could compute the statistics when the ValuesExec is created (rather than computing on the call to statistics(&self)?

I think don't think adding an RwLock sounds like a good idea. Perhaps we could compute the statistics when the ValuesExec is created (rather than computing on the call to statistics(&self)?

agreed, no need for a lock. we can just put evaluation in the creation part of ValuesExec. i mean it probably wouldn't make any difference

@alamb IMOP, earlier computing statistics conflicts with the purpose of this task, because this will iterate all row and column, which also slow the creation of ValueExec. Maybe stay the same is ok?

I think don't think adding an RwLock sounds like a good idea. Perhaps we could compute the statistics when the ValuesExec is created (rather than computing on the call to statistics(&self)?


Question about feature selection

I am experimenting feature selection strategies, and wondering if the order of features can have an effect on xgboost performance ?
In other words, will xgboost do the same with feature set {A,B,C,D,E,F,G} as with feature set {E,F,G,A,B,C,D} ?
(I have around 200 features, many of which are very sparse)

Feature order should not have any effect if you are not using sub-sampling on columns (all data points are checked to find best split in each tree).
And if you do, results may be slightly different (because of randomness in sub-sampling).
Check slides from @tqchen (https://github.com/dmlc/xgboost/blob/master/doc/index.md) for more info.
Moreover, if you are doing feature selection you may be interested in this conversation:
https://github.com/dmlc/xgboost/issues/419
In particular the idea implemented in GBM to add noise and see how useful are these fake features.
Let us know your results if you try it.
Kind regards,
Michaël

Thank you very much Michaël, you are right, I had colsample_bytree=0.6.
It's also true that the results are slightly different, there's a 0.00001 difference in my cross validation.
The problem is that this difference turns into 0.001 in the public leaderboard of caterpillar kaggle competition !!! It's still small but worth many positions :)
Thanks also for the noise-feature tip, i will definitely use it for my feature selection and keep you updated.

Follow up about noise-feature tip : it works really well not only for feature selection, but also for parameters tuning.
With my previous params, noise-feature was ranked n°1 in feature importance.
I changed the params until it went down to a meaningfull ranking, then selected the more important features, and it looks like i have a better model now.
Thank you very much for your advice !

Nice idea!

Sometimes, a noise feature can rank very high. But removing the features less often used, leads to a drop in cross-validated and  test set performance. So, I think the measure is actually not good. Some features are used less often, but still have valuable information.

What did you mean more clearly? Did you say that variable ranking does not
mean anything?
Another thought: To evaluate the importance of the variables depends on
which measure you're using it for, right? importance of measures such as
"often" are not very good? The best measure would be some weight"
measure within the model trees?
Perhaps the "weight" is the Gini index, right?
As you can see, these concepts are not very clear to me.
Thank you.
2016-07-01 14:12 GMT-03:00 Sören<EMAIL_ADDRESS>
Sometimes, a noise feature can rank very high. But removing the features
less often used, leads to a drop in cross-validated and test set
performance. So, I think the measure is actually not good. Some features
are used less often, but still have valuable information.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dmlc/xgboost/issues/434#issuecomment-230000081, or mute
the thread
https://github.com/notifications/unsubscribe/ARdoT8iIixlHgr_WKVzE9-9sZjX2I2Hhks5qRUp1gaJpZM4Fms0U
.

The approach to parameter tuning is this case would be the same as when you want to reduce overfitting in training data. The more overfitting, the more algorithm  would cling to irrelevant features.
Also much would depend on your data. If the data or labels are rather noisy, it would be especially important not to rely on a single run with injected noise features, but to do many runs to find a threshold. Also, instead of generating completely artificial random features,  I would recommend creating noise features as random shuffles of some typical features in your data.

The term "importance" is a bit misleading, because the f-score simply calculates how often a feature is used in a model. Link
The problem is that 'importance' implies that a feature that scores higher contributes more to a good prediction than a feature that scores lower, but that is not necessarily the case. In fact, a random feature can score higher than features that are rare, but that contains information. F-score should not be called 'feature importance', because it is fishy. Instead, just call it f-score. Or 'feature-split-count' or something along the lines.
There is also the discrepancy between 'importance to fit the model' and 'importance to make predictions'. Actually, importance always needs to be used in conjunction with something 'importance for something'. The best would be to avoid the term 'importance' and name the scores according to what they actually measure. Whether or not it is important, leave it to the user.

there's a way to use xgboost to select features similar to %incMse in random forest ??


Upgraded Firestore version to 0.16.0

Also dropping Node4 config from CI, as Firestore (and GCP) no longer supports it.

Node4 related stuff have been sync'ed via #328


Needs DayDream VR support

Might be a good starting point for getting this on DaydreamVR:
https://github.com/bernardjason/daydream

VR support is not something I’m personally interested in spending time on, but if someone else wants to give it a shot then go for it!

Closing based off of @Interrupt 's comment.


Corrected typos, corrected grammar

Description

Corrected typos
Improved grammar
Corrected Markdown so the linter doesn't complain in VSCode

Thank you very much for your contribution.


releasing monai 1.3.2

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Hi @mdraw could you please assign @KumoLiu permission to write this repo instead of myself? she's taking over the development from me. thank you!


Ensure that "Warning: shouldn't be the case" print errors are fixed before release

Branch : spark-branch
Context :
Certain values are not computed, but expected by the formatter (see frequency_table_utils.py).
Problem :
When variables are expected by the formatter but not present, "Warning: shouldn't be the case is printed". This should be fixed before release.

hi @jyotidhiman0610! So sorry thought I replied on this but I did not. Please feel free to take this on! If you would like to discuss more on this, please feel free to join our slack and we can discuss this more there.


work on listing new attributes. show deprecated attributes

https://github.com/strydercorp/handshake/pull/2371/files

 (3) Add a hard releation of primary_education to users [5]

this is just waiting on the merge


Set issue details

@more-dinner let me know if these changes are along the lines as to what you're thinking


Access to Method parameter names at runtime

Given that JDK8 now supports accessing parameter names at runtime, I've incorporated this behaviour
into the Groovy code base (configurable).
Configuration is similar to the javac -parameters parameter...
It can be enabled by passing -pa or --parameters to the groovy or groovyc executables, or alternatively, you can set the -Dparameters system property.
Happy to have feedback on changes/suggestions. Thanks to @blackdrag for showing me where to get started!
Reference: mail-archives
JIRA: GROOVY-7423

HI @roranade , good catch, thanks! I've made the change and auto-formatted that line.
Just on the formatting...
Re: groovy.ui.GroovyMain - I've tried to make the formatting similar to what's already there. Intellij doesn't like the code current formatting (in GroovyMain), so I've left it as is (3 space tab indents, strange indenting in the #buildOptions() code).

Very nice! It might also be nice to enable the functionality via the ant tasks:
org.codehaus.groovy.ant.Groovy
org.codehaus.groovy.ant.Groovyc

Have a look at how the stacktrace flag is handled (and possibly how the verbose flag is passed on for joint options in groovyc - might be relevant to do this too - I haven't thought through the joint scenario fully yet).
The only other comment I have is that the patch currently doesn't handle some tricky cases where setting the access might be appropriate, e.g. first parameter "this$0" for an inner class should probably be marked synthetic/implicit and possibly a couple of spots within enums too. But so long as not handling such cases doesn't cause a problem, we can probably endeavor to tweak the behavior to be smarter down the track. Maybe add a TODO comment in your patch for now, e.g. "// TODO handle synthetic/implicit?".

Forgot to mention the relevant place for doco changes (which would be nice too):
src/spec/doc/tools-groovyc.adoc (two places, groovyc commandline and groovyc ant task)
src/spec/doc/groovy-ant-task.adoc

Thanks @paulk-asert , I didn't even think of ant tasks or the doco. I'll make those changes later today.
RE: Access Settings - I didn't understand what the difference was between synthetic/implicit(/???), so I just left them as 0 for now. I could just add a todo, but I don't mind doing it properly either. I'll reverse engineer/asm some JDK8 classes, so see how the value changes for enums and inner classes. If you can point me to any documentation, that'd be a great help too!

Don't know whether this will help:
http://docs.oracle.com/javase/tutorial/displayCode.html?code=http://docs.oracle.com/javase/tutorial/reflect/member/example/MethodParameterSpy.java
See the Java tutorial for details:
http://docs.oracle.com/javase/tutorial/reflect/member/methodparameterreflection.html
But as you may or may not know, Groovy's enums are a bit different from Java's enums under the covers, so there might not be an exact one-to-one correspondence.

For bonus marks, you'd also update the doco on the groovy commandline itself but we haven't migrated that across to the new documentation yet.

Thanks @paulk-asert , that's perfect. Reading up on http://docs.oracle.com/javase/tutorial/reflect/member/methodparameterreflection.html#implcit_and_synthetic now.
Will update groovysh (org.codehaus.groovy.tools.shell.Main), with documentation later.

Just some other thoughts (I'll leave this for another day):

Does gradle's groovy plugin support compiler args? (I could only enable -parameters by using a configurationScript).
compileGroovy {
groovyOptions.compilerArgs << '-parameters'
}

Update Groovy Eclipse Maven plugin to support -parameters arg?

Intellij > 'Groovy Compiler' settings (Ctrl+Alt+S) doesn't support compiler args?

OK, now a placeholder doco for groovy commandline:
src/spec/doc/tools-groovy.adoc

We may move that around yet.
Yep, groovysh and groovyConsole would be lower priority but should be handled eventually. And yes, we'd need to percolate it out to other tools eventually. Don't know a better Gradle option off the top of my head.

Notes
I tried using the ASMifier, to decompile all (as many) variations of parameter accessors (e.g. inner classes, implicit constructors, enums) as I could. The only time I got a value other than 0, was for enums, which had ACC_SYNTHETIC on their method parameters. Saying that, the parameters still work using 0 for an enum.
e.g. (groovyConsole)
class Foobar {
    enum Alpha { AAA, BBB}
    def run(String firstParam, int secondParam){}
}

println Foobar.methods.find{it.name=='run'}.parameters.collect{it.name}
println Foobar.Alpha.methods.find{it.name=='valueOf'}.parameters.collect{it.name}

Also, groovyConsole's argument handling was "manual", so I updated it to use the CliBuilder.
Done

Add to groovy
Add to groovyc
Add to groovysh
Add to groovyConsole
Change system property config
Comment TODO on ASM accessor

Backlog

Add to ant tasks
Update documentation
Test

@nickgrealy Thanks for the great work so far. :)
Could you also rebase to latest master, because the merge of https://github.com/apache/incubator-groovy/pull/11 caused some conflicts with your pull request? Thanks!

@PascalSchumacher , sure thing.

And a squash might be good too.

Roger wilco.

Did you get a chance to squash? Are you finished for now wrt the backlog you mentioned?

So, quick update. Finally managed to make some time to rebase and squash the code.
Since then, I implemented the ant groovy tasks (just testing atm) and added everything to the documentation.

Excellent work! The rebase/squash seems a little weird? Squashed down to 112 commits? Thanks for spotting the doco issues - yep, I will fix up manually in the 2_4_X branch. I'll check on where groovy.parameters doco should go.

Yeh, it was my first rebase/squash... so I'm not sure it did what it was supposed to(??).
Ant tasks look good, except for one (existing?) issue that I'm looking at. Joint compilation (i.e. integrated java compilation) is NOT using/passing on the -parameters flag (for Java classes only).
<groovyc srcdir="src" destdir="out" parameters="true">
	<javac source="1.8" target="1.8" debug="on" srcdir="src" destdir="out">
		<compilerarg line="-parameters"/>
	</javac>
</groovyc>

you did "git rebase master"?

After fetching upstream/master (i.e. -> apache/incubator-groovy), I used git rebase -i HEAD~8, where 8 was my last 8 commits (obviously this isn't correct). I'll give git rebase master a go this evening.

hmmm, I couldn't see the problem you mentioned in tools-groovyc.adoc, perhaps something weird happened with your rebase attempt? Unless I am missing something.

@paulk-asert , take a look at the latest docs for the master branch, on the CI server.
http://ci.groovy-lang.org/repository/download/Groovy_Jdk7Build/23592:id/target/distributions/apache-groovy-docs-2.5.0-SNAPSHOT.zip!/groovy-2.5.0-SNAPSHOT/html/documentation/index.html#section-groovyc-compiler
Notice how the groovyc table, is truncated after the --basescript parameter? There should be a few more parameters, which aren't showing up because of the --indy parameter.

Ah, my bad - was looking in tools-groovy.adoc not tools-groovyc.adoc. I see the problem now. Thanks.

fixed and you should get that change if you rebase again (sorry)

If the rebase is too hard, you could create a diff of just your changes, close this PR, create a fresh branch from master and apply the diff and make that into a PR.

Awesome, thanks for fixing the docs. Not a problem, I've almost nailed down the ant java compiler thing. Will have another go at rebasing -> squashing after that. Will stick with this pull request for now. :)

Hi @paulk-asert , I've done a git fetch upstream and a git rebase -i upstream/master, which has (hopefully) squashed my changes. Please have a look when you get a minute.

It still looks a little weird to me. I would be expecting just a small number of commits - possibly just one if you squashed completely. I'll see if anyone else has some git advise on how to correct. Me, I'd do old school close and re-open at this point.

I have seen this happen before when I squash the commits on my local branch and push my local branch to remote repository without force pushing it.
There are a few ways this can be corrected. One of them is to --
git reset --hard <shaOfLastest upstream/master commit>
git cherry-pick <squashed commit's sha> -- (Assuming there is only 1 final squashed commit)
git push -f origin master -- A force push to forked master branch
Also, as Paul said, closing this branch/PR and opening a new branch and cherry-picking the commits on the new branch may probably be cleaner (albeit that would not be much different from git reset --hard in this case)

Thanks, I'll give the cherry picking a go, and fall back to the diff if I'm still having troubles.
I'm a bit of a newb to git, so just for next time, should I be working in a branch, within my fork? I was simply working off my master...

IMO, unless you are working on multiple features at once, having just master is probably fine but in general, yes I do think its better to create a branch to work on.

Continued in https://github.com/apache/groovy/pull/38


No way to read 'test.csv' without labels

Hello!
I'm trying to read train.csv and test.csv files with this call:
dataset = BasicClassificationDatasetReader()
dataset.read('/data/', train='train.csv', test='test.csv', x='text', y='target')
That finishes with an error, because 'test.csv' has no 'target'. How to read dataset without labels to make a predictions on it?

Hi @DrMatters,
DatasetReaders are created for models training and evaluation.
To make predictions you can read your data in a python list (or two lists if the model expects two arguments) and just pass it to the model:
from deeppavlov import build_model, configs

model = build_model(configs.classifiers.intents_snips, download=True)
data = [
    'Show me the forecast for my upcoming weekend',
    'Find me the I, Robot television show',
    'Can I get some Russian cuisine at a restaurant with Shari and I?'
]

predictions = model.batched_call(data, batch_size=32)

Seems fine


Correct Link for "Making open data useful"

https://blog-nrrd.doi.gov/open-data-useful/
Link text "Filterable tables"

@jlouis-onrr Can we set up a redirect from this page to the query tool?  It was the query tool before the redesign.
https://revenuedata.doi.gov/explore/revenue/

I created #1821 to create a redirect.

Taken care of with PR for #1821.


Add Albanian Language to the default languages

Hello, sure thing. Here it is https://github.com/JeremySkinner/FluentValidation/pull/837

Thanks, I've merged these in.
For future reference, it's better to add the extra commits to the same branch and pull request, rather than opening a new one, but I've combined them manually for now.


3.0 docs build fix

What does this PR do?
Fixes issue with python module dependency versioning.  Already done in master.  docs in 3.0.x build will fail without it.
Fixes #2891
Which TC components are affected by this PR?

[x] Documentation
[ ] Grove
[ ] Traffic Analytics
[ ] Traffic Monitor
[ ] Traffic Ops
[ ] Traffic Ops ORT
[ ] Traffic Portal
[ ] Traffic Router
[ ] Traffic Stats
[ ] Traffic Vault
[ ] Other _________

What is the best way to verify this PR?
./pkg -v docs

Check all that apply

[ ] This PR includes tests
[ ] This PR includes documentation updates
[ ] This PR includes an update to CHANGELOG.md
[ ] This PR includes all required license headers
[ ] This PR includes a database migration (ensure that migration sequence is correct)
[ ] This PR fixes a serious security flaw. Read more: www.apache.org/security

was supposed to be against 3.0.x


Self-hosted Whisper Integration

Hi,
Would it be possible to point to a locally hosted Whisper instance rather than OpenAI (currently looking at https://github.com/ahmetoner/whisper-asr-webservice)? Alternatively, or perhaps in addition to, could text documents be an accepted input filetype, so that we can transcribe offline using Whisper and submit our script to bypass the Subtitles stage and skip straight to Chapters/Summary?

That would be great!!

Leaving this issue open, but I'll need to do some deep diving into local whisper models and how (or if) they could integrate with the library being used in this: openai-php/client.

Any news on this request ? This could avoid quota problems on the openai api.

Any update on this feature?


added metrics to p2p queues

Motivation

part of #1553

Changes

Test Plan

apart of the single comment the code is really good 👍

bors r+


micsthepick: Watch ajk\Wtorus

micsthepick requests the watch of the watch_keyword ajk\Wtorus. See the Metasmoke search here and the Stack Exchange search here.

ajk\Wtorus has been seen in 0 true positives, 0 false positives, and 0 NAAs.

The only match so far is https://metasmoke.erwaysoftware.com/post/109744 but I guess for a watch, we are okay with that.

Coverage remained the same at 65.238% when pulling 1e8161e62d687d93538c8f7836bf172248fe646c on auto-blacklist-1520834947.2201996 into 5ca6c6ff53ad89c8ef0a3bc801140b7e2528b66e on master.

!!/approve


Proper handling of push messages

Expected behavior by message type:
Sync

[ ] When app is not running: Nothing.
[ ] When app is running: Run "synchronize" task

[ ] (Nice to have) Update content on screen

Announcement

Independent on app state (running, closed):

[ ] Show a system notification with

[ ] Proper logo (Eurofurence wolf badge)
[ ] Title and Message of the announcement
[ ] Tapping the notification should...

[ ] (at least) ...open the app on the main screen
[ ] (at best) ...open the announcement directly

Personal Message

Independent on app state (running, closed):

[ ] Show a system notification with

[ ] Proper logo (Eurofurence wolf badge)
[ ] Title and Message of the private message (coming from the FCM payload)
[ ] Tapping the notification should...

[ ] (at least) ...open the app on the private messages screen
[ ] (at best) ...open the private message directly

I think this has been done over the weekend. closing