Webpack banner plugin breaks the extracted output

Do you want to request a feature, report a bug or ask a question?
Bug / Resolution / Question - should it be covered in docs?
What is the current behavior?
In production mode I use the webpack banner plugin - it injects a banner into the generated SVG and breaks it
What is the expected behavior?
SVGs work
If the current behavior is a bug, please provide the steps to reproduce, at least part of webpack config with loader configuration and piece of your code.
The best way is to create repo with minimal setup to demonstrate a problem (package.json, webpack config and your code).
It you don't want to create a repository - create a gist with multiple files
add into your webpack build:
new webpack.BannerPlugin({
	banner: util.format('%s (v%s)\nAuthored by %s - %s', pkg.name, pkg.version, pkg.author.name + ', ' + pkg.contributors.join(', '), new Date().toUTCString())
			})

If this is a feature request, what is motivation or use case for changing the behavior?
Trying to help others with a possible fix or doc update
Please tell us about your environment:

Node.js version: 6.11
webpack version: 2.6.1
svg-sprite-loader version: latest
OS type & version: mac latest

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)
I fixed it by excluding the file:
new webpack.BannerPlugin({
       exclude:'sprite-name.svg',
	banner: util.format('%s (v%s)\nAuthored by %s - %s', pkg.name, pkg.version, pkg.author.name + ', ' + pkg.contributors.join(', '), new Date().toUTCString())
			})

The most preferable way to resolve this is to prevent the banner from being injected, but otherwise this is a very easy fix in the webpack config and it might help others.

@sidonaldson thanks for sharing this, I'll add it to docs.


bug(cdk-virtual-scroll): Only shows a few items when using scrollWindow property

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
When you use the scrollWindow property it only renderers the initial items (the ones inside your min and max buffer settings) after that it is just blank spaces.
It also happens at the angular material show case example, it only show the first 21 items. I tried to use the checkViewportSize() method but of no use.
https://material.angular.io/cdk/scrolling/overview
Reproduction
https://stackblitz.com/edit/angular-1uahhp?file=src/app/cdk-virtual-scroll-window-scrolling-example.ts
Steps to reproduce:

It already happens on the virtual scrolling window example.

Expected Behavior
It should render new items as you scroll down the page, eventually rendering all the items.
Actual Behavior
It stops rendering items after the initial ones are rendered.
Environment

Angular: 14.1.0
CDK/Material: 14.1.0
Browser(s): Chrome, Firefox
Operating System (e.g. Windows, macOS, Ubuntu): Windows, macOS

Hello @mcrtricolor , I clicked the above stackblitz link, but it takes me to the stackblitz homepage. Sometimes the URL in the address bar isn't the URL for sharing. Could you please click "Share" on the top bar to get the link to the editor and share it here?

Hi Zach, thanks for the notice!
It's now edited with the proper link.
Thanks again
Martín Corbacho
El lun, 25 jul 2022 a las 13:59, Zach Arend @.***>)
escribió:

Hello @mcrtricolor https://github.com/mcrtricolor , I clicked the above
stackblitz link, but it takes me to the stackblitz homepage. Sometimes the
URL in the address bar isn't the URL for sharing. Could you please click
"Share" on the top bar to get the link to the editor and share it here?
[image: image]
https://user-images.githubusercontent.com/7720245/180833392-7a97847b-0a17-4071-896d-1965b44253fc.png
—
Reply to this email directly, view it on GitHub
https://github.com/angular/components/issues/25336#issuecomment-1194352800,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQYE523MWLBPR5LUZGXRSXDVV3BVVANCNFSM54SJXLAA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks for reporting @mcrtricolor , I'm confirming that I can reproduce on both my mac and my windows machine.
Windows 10 Enterprise, Version 20H2 | Crhome Version 103.0.5060.134 (Official Build) (64-bit)
MacOS 12.4 (21F79) | Chrome Version 103.0.5060.134 (Official Build) (x86_64)

I think this property scrollWindow is new, i was using 14.0.6 and had to
update it to 14.1.0 in order to use it.
Thanks.
Martín Corbacho
El lun, 25 jul 2022 a las 14:26, Zach Arend @.***>)
escribió:

Do you know what version this used to work with?
—
Reply to this email directly, view it on GitHub
https://github.com/angular/components/issues/25336#issuecomment-1194385477,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQYE52YP4YFAYNL6TNZ65EDVV3E4RANCNFSM54SJXLAA
.
You are receiving this because you were mentioned.Message ID:
@.***>

I tried upgrading to 14.1.0 in https://stackblitz.com/edit/angular-vszuks, and it didn't seem to help. @crisbeto is this something you could look at?

I got this bug after upgrading from 13.3.9 to 14.1.0

a

I also can confirm this bug. Just take a look at the StackBlitz demo linked in the official CDK docs: https://stackblitz.com/run?file=src%2Fapp%2Fcdk-virtual-scroll-window-scrolling-example.ts
The example should render 10k elements but only the first 23 elements are rendered

I can also confirm this issue on the StackBlitz demo page. I tried different browsers as well such as Chrome and Edge and both show the same behavior.

looks like it is still an issue in 14.2.4

I spent a bit of time investigating this the other day. As far as I can tell, this is a problem with the demo, rather than the component. For some reason the document doesn't end up receiving the scroll events when it gets forked to Stackblitz which is why it doesn't re-render. If you run into this issue, you should check that the top-level document is actually scrollable and not some container further down.

Any news on this? thanks in advance

I could not get it to work in a regular angular project. I used 'CdkScrollable' instead of 'scrollWindow' as a workaround then massaged the html and css to make the demo function the same:
https://stackblitz.com/edit/angular-sygccx-yxae5u?file=src%2Fapp%2Fcdk-virtual-scroll-window-scrolling-example.css

Hi, any news on this issue?

check that the top-level document is actually scrollable and not some container further down.

@crisbeto's observation is correct - I noticed the same issue when the virtual scroll had ancestors with overflow property.
I'm using mat-sidenav & mat-drawer containers. These also interfere with document scrolling but I can't remove them.

Would appreciate a way to make scrollWindow work with ancestors that have overflow property set, or a workaround..

Update: I found a solution for my case (virtual scroll inside a mat-drawer-content, which expands to fit the available height).
Instead of using the scrollWindow directive, Angular CDK offers another directive cdkVirtualScrollingElement which can be applied to the scrolling ancestor. See: https://material.angular.io/cdk/scrolling/overview#separate-viewport-and-scrolling-element.

For my use-case, I applied this directive to the top-most div inside the drawer-content, along with height: 100%.
  <mat-drawer-content>

My List

      <cdk-virtual-scroll-viewport itemSize="64">
        <my-list-item *cdkVirtualFor="let element of myList; trackBy: trackById" />
      </cdk-virtual-scroll-viewport>

  </mat-drawer-content>

This way I don't need to set a specific height on the virtual-scroll-viewport and it can expand to fill the available space.

If someone having this issue: the issue is only on Angular 14 with Material 14. Even the example on the Material page doesn't work. The one with Material 15 and Angular 15 - works fine.

Any new on that?
I also tried to use "cdkVirtualScrollingElement" outside of my component (which has the "cdk-virtual-scroll-viewport") to set the  as the scroll-container (same as the result of scrollWindow) but the scroll-container remains the  "cdk-virtual-scroll-viewport", if I use the "scrollWindow" I get the same issue as OP

Any new on that?
I also tried to use "cdkVirtualScrollingElement" outside of my component (which has the "cdk-virtual-scroll-viewport") to set the  as the scroll-container (same as the result of scrollWindow) but the scroll-container remains the "cdk-virtual-scroll-viewport", if I use the "scrollWindow" I get the same issue as OP

Is upgrading to Angular >15 an option?

Any new on that?
I also tried to use "cdkVirtualScrollingElement" outside of my component (which has the "cdk-virtual-scroll-viewport") to set the  as the scroll-container (same as the result of scrollWindow) but the scroll-container remains the "cdk-virtual-scroll-viewport", if I use the "scrollWindow" I get the same issue as OP

Is upgrading to Angular >15 an option?

We're using v16+ but my issue is not related to material components or something like that

Any new on that?

I also tried to use "cdkVirtualScrollingElement" outside of my component (which has the "cdk-virtual-scroll-viewport") to set the  as the scroll-container (same as the result of scrollWindow) but the scroll-container remains the "cdk-virtual-scroll-viewport", if I use the "scrollWindow" I get the same issue as OP

Is upgrading to Angular >15 an option?

We're using v16+ but my issue is not related to material components or something like that

Got it. Usually, I had the issue when o set the wrong row height for the elements inside the virtual-scroll.

Any new on that?

I also tried to use "cdkVirtualScrollingElement" outside of my component (which has the "cdk-virtual-scroll-viewport") to set the  as the scroll-container (same as the result of scrollWindow) but the scroll-container remains the "cdk-virtual-scroll-viewport", if I use the "scrollWindow" I get the same issue as OP

Is upgrading to Angular >15 an option?

We're using v16+ but my issue is not related to material components or something like that

Got it. Usually, I had the issue when I do set the wrong row height(item size) for the elements inside the virtual-scroll.
I have a working example here, you can check how it behaves on your side:
<cdk-virtual-scroll-viewport [itemSize]="itemSizeInPixels" [maxBufferPx]="1200">
        <mat-list-item  class="user-list-item-height" *cdkVirtualFor="let userListItem of items; trackBy: trackBy">

              {{ userListItem?.user.firstName + ' ' + userListItem?.user.lastName }}

        </mat-list-item>
</cdk-virtual-scroll-viewport>

.user-list-item-height {
  height: 70px !important;
}

Check also in the package.json that you have cdk version > 14. I have "@angular/cdk": "15.2.1".

we're using the "autoSize" options from the experimental CDK, and yes our CDKs are aligned with our Angular versions

I believe you need Angular 16 to get use of autoSize from experimental CDK.

Any new on that?

I also tried to use "cdkVirtualScrollingElement" outside of my component (which has the "cdk-virtual-scroll-viewport") to set the  as the scroll-container (same as the result of scrollWindow) but the scroll-container remains the "cdk-virtual-scroll-viewport", if I use the "scrollWindow" I get the same issue as OP

Is upgrading to Angular >15 an option?

We're using v16+ but my issue is not related to material components or something like that

Got it. Usually, I had the issue when I do set the wrong row height(item size) for the elements inside the virtual-scroll.
I have a working example here, you can check how it behaves on your side:
<cdk-virtual-scroll-viewport [itemSize]="itemSizeInPixels" [maxBufferPx]="1200">
        <mat-list-item  class="user-list-item-height" *cdkVirtualFor="let userListItem of items; trackBy: trackBy">

              {{ userListItem?.user.firstName + ' ' + userListItem?.user.lastName }}

        </mat-list-item>
</cdk-virtual-scroll-viewport>

.user-list-item-height {
  height: 70px !important;
}

Check also in the package.json that you have cdk version > 14. I have "@angular/cdk": "15.2.1".

we're using the "autoSize" options from the experimental CDK, and yes our CDKs are aligned with our Angular versions

I believe you need Angular 16 to get use of autoSize from experimental CDK.

Using Angular 17  and Material 17 and there is no way to  make this working with projections.
I manage to solve the issue partially but doesn't load  the list when the view disappears and reappears with ngIf.

So... After a lot of research and dive in angular and cdk base code, I came up with a solution.
Bonus track: With scroll restoration 🔥
In my case, I'm using a material Sidenav with a Toolbar and when I started designing the site I delegated all the scroll to the drawer content (mat-drawer-content).
That's why the scrollWindow wasn't working. Now I'm pretty sure that I should have refactored that decision and make the scroll responsability  of the window again and probably I'll do that in a future but, honestly... when I realized that, it was too late and I already had spent hours trying to solve this.
The solution was to make a custom directive, just a copy of the original scrollWindow with my element as scrollable container, that simple. As I already had created an implementation for a custom ViewportScroller to override the angular default scroll restoration, I integrated both of the clasess.
You can find the code here: https://gist.github.com/zalito12/1bbdd3b986531346d1a4e710ac266dbe
If anyone is in this situation, I advise to reconsider your design decisions and if it make senses to have the scroll viewport in a component instead of the window, but as some people say that cdk scrolling is not working correctly with projections, maybe this could help, actually I'm using projections on the drawer content and this solution also works!

I used a workaround to make it work, maybe is not the best performance wise but it works and displays all the items.
Angular 17.3.7, Material 17.3.7 and Ionic 8.1.0
On my template, to make it scroll with ion-content:
<ion-content cdkVirtualScrollingElement

[scrollEvents]="true"

(ionScroll)="configuroScrollMobile() : ''">
...
<cdk-virtual-scroll-viewport #cdkViewport
itemSize="40"

[appendOnly]="true">

...

...

And on my component:
@ViewChild('cdkViewport') cdkViewport: CdkVirtualScrollViewport;
configuroScrollMobile() {
if (this.cdkViewport) {

this.cdkViewport.checkViewportSize();

}
}

Also seeing this issue when the scrollWindow property is nested within an ion-content from the ionic framework

Also seeing this issue when the scrollWindow property is nested within an ion-content from the ionic framework

As I state in my comment: https://github.com/angular/components/issues/25336#issuecomment-2062687052
I suggest you to let the scroll responsability to the window and use the scrollWindow directive, set the other components as fixed.
If that's not possible, I haven't used ion, you could try to use the solution I provided, it's working for me using mat-drawer-content, I think it's a similar problem.

Hi guys, Is there any update regarding this bug? are you going to solve it?
I've moved to Angular 18 + Material 18 version and unfortunately it is still doesn't work.
Or there is any workaround that can work? (i've tried the ones suggested above and they doesn't work for me).
Thank you in advance.

Hello,
Will this bug be addressed soon? I’m using Angular 18 with Material 18.
Are there any workarounds available? I’ve tried the suggestions mentioned earlier, but unfortunately, they didn’t resolve the issue for me.
Thanks in advance!

Any estimation regarding this? @mcrtricolor did you receive any news re: this?


CkArray: Change defaults for static insertion

Closes #3412

Any documentation or test/example changes needed for this?

Good question. I'll check on that. I know the startupTest creates arrays weirdly, and could use some cleanup, but maybe as a separate patch.

Any documentation or test/example changes needed for this?

As far as I can tell, the command line argument this change removes was completely undocumented. Documentation to CkArrayOptions may need updating. Currently though, it counts .insert calls as being fine with static insertion. Basically according to the manual right now, everything that isn't demand creation is static insertion. Or at least, that's my interpretation.


[Koa 2] Style of middleware with extra arguments

in Koa 1.x, middleware (e.g. koa-route, koa-router) with extra arguments would use:
function * (a, b, c, next) { ... }

e.g. in koa-route
app.use(_.get('/pets/:name', function * (name, next) {

})

Which styles should we use in Koa 2 ?

(ctx, next, a, b, c) => { ... }
(ctx, a, b, c, next) => { ... }
(a, b, c, ctx, next) => { ... }

I think we need a consensus about it.
What's your opinion ?

No extra arguments at all, add the data to context.state.

const {a, b, c} = ctx.state works for me! or maybe ({a, b, c}, ctx, next) but meh

Is .state recommended namespace for storing routing params ? I see that .params is mostly used.
relevant: koajs/route#38, alexmingoia/koa-router#202

hm for router I find ctx.params more intuitive. Actually, I find ctx[anything] more intuitive than ctx.state[anything]. I mean, the only reason why koa wraps request and response in a context object for me is so you can add more properties without touching req or res like in express (besides doing the context-as-this thing in koa1). A router param isn't really a state. Maybe we should just stop encouriging people to use ctx.state in koa2? All it does is nest properties one extra level.

I find ctx.params to be better (i.e. more intuitive too) for routers. As for ctx[anything] for URL params, this will most likely lead to name conflict at some point.

:+1: for params. I prefer the lack of unified ctx.state too, from a technical side I think it's cleaner since it lets us do whatever we like at the context level api-wise but I'm not in love with it personally. With destructuring I think the ugliness of it is negligible, and it's a bit easier to inspect

I mean't having params in ctx.params (not ctx.state.params), a JWT token in ctx.token (not ctx.state.token), etc etc. You could still do destrcuturing.

I know, I just mean that destructuring makes the ctx.params / ctx.state objects less ugly in use. I don't think we should advocate throwing everything on ctx instead of ctx.state, unless it's something that really benefits from that like ctx.user is a more obvious one

afaik es2015 supports nested destructuring :wink:
app.use(get('/:id', async ({ params: { id }, user }, next) => {
  if (permitted(user, id)) {
    await next();
  } else {
    throw Error();
  }
}));

I think a good bit of middleware was written before ctx.state was introduced. It may already be in the docs, but as middlewares are updated, most of them could probably do a better job of staying out of ctx props.
@madbence why destructure like that if you have to come up with a creative way to retain the actual object you're destructuring?

@madbence yes, it's var id = ctx.params.id; :P

maybe attach ctx to itself, like ctx.ctx = ctx haha
app.use(get('/:id', async ({ params: { id }, user, ctx}, next) => {
  if (permitted(user, id)) {
    await next();
  } else {
    ctx.throw(403, 'frobz qux');
  }
}));

Nah, there you could just do
app.use(get('/:id', async (ctx, next) => {
  const { params: { id }, user } = ctx;
  if (permitted(user, id)) {
    await next();
  } else {
    ctx.throw(403, 'frobz qux');
  }
}));

:+1:

@simplyianm :+1: it doesn't look that bad at all, i'm just a bit disappointed that you cannot destructure everything on the parameter list :disappointed:

You can do that in Elixir :wink:

To me it gets too cluttered in the params anyway

leaving this as an option for routers and other middleware. feel free to open issues in each router's repo!
i personally prefer this.params = {}


Fix SMTP issue by always getting a new connection

The open SMTP connection would sometimes return a positive response to noop's but throw an error when trying to send an email. Reverting back to creating a new connection each time until someone finds a better way to persist the connection.

Look good, thanks!


Support machine with top-left origin

In the latest version, "top-left" is supported by laser.inx, but not yet implemented.
So, I wrote a small code for "top-left".

I can't test it right now but the changes look good. Thank you for contributing!


Sign up lead time and support for encrpyted image

Hi, how long should we expect for our registration to be approved? And does share image support encrypted image as well? Thanks,

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0d150ace-bd6d-8111-79b5-0ce7cb76a378
Version Independent ID: 13a828ae-ae92-9ea7-5f37-5a69eeeb87b7
Content: Share VM images with Shared Image Gallery in Azure
Content Source: articles/virtual-machines/windows/shared-image-galleries.md
Service: virtual-machines-windows
GitHub Login: @axayjo
Microsoft Alias: akjosh; cynthn

Thanks for the question! We are investigating and will update you shortly.

@cynthn Author is not available in the github. Please take care of this issue.

@v-maroge Getting your subscription whitelisted should happen almost immediately. Are you unable to create gallery resources?
@axayjo Can you comment on the encrypted disks part of this question?

@v-maroge The image version in Shared Image Gallery is nothing but a managed image under the hood, so all managed images are by default SSE enabled i.e., they’re encrypted at rest with Microsoft keys. But we don't yet have support for images encrypted with Customer Managed Keys. It's on the roadmap.

@cynthn No, our customer just wanted a general expectation. Thanks.
@axayjo Got it. Thanks

@v-maroge I will close this out for now. If you need additional help please let me know and we can reopen and continue.


vim-plugins: update and use https for github sources

Motivation for this change
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Pushed to master (5262f5e3a2794719b0db1c57b514395a5176f560 and parents) and release-17.03 (994a3730016200cc98a28493b662605d60d0396f and parents). Thanks!


v4 Fix FakeBrowser address bar (was broken due to jsxstyle)

Right now jsxstyle requires to write <Inline component="input" props={{onClick}} /> instead of <Inline component="input" onClick={onClick} />.
There is a upcoming patch in jsxstyle that will change this API: https://github.com/smyte/jsxstyle/issues/32

Thanks for the fix!


Extensions are not working

After upgrading to the latest version, none of the extensions are showing any recommendations like they are supposed to no matter, how many times I remove and add them again.

I'm seeing the same problem with a fresh installation of 1.23.0 on MacOS X. No extensions are found when searching for extensions or selecting "recommended extensions".
Is there any way to get download the previous version as a workaround for now? The download on the web only offers the latest version.

Actually the F1 trick made them immediately visible. Thanks for the hint.
However I have never had this issue before on any machine (Windows, Linux or Mac) and immediately after install it didn't show anything when clicking at the recommended extensions or when searching for an extension. After the F1 trick everything was suddenly appearing. Now it works, so I'm happy.
I'll try to reproduce it on another machine though and let you know if I'm seeing the same problem again.

it didn't show anything when clicking at the recommended extensions

Just to be clear, what exactly are you referring to when you say "clicking at the recommended extensions"? Is it the "recommended" section that shows up along with "installed" section? Or is it the "Show Recommended Extensions" from the menu? Can you provide a screenshot?

My problem is different, to describe it before updating I have an extension called express snippets and when I type app it shows be snippets but after updating it has completely stopped even other extensions are showing this behavior

@highskillzz So your problem is that when you are searching for extensions, nothing is showing up? When you clear all text from the search box, do you see your installed extensions? Can you share some screenshots?

Yes, i meant the "recommended" section on the left when clicking at extensions. I never did anything via the menu in regards to extensions.
In the aftermath it seemed that the list of available extensions was not fetched until the F1 trick.
It's working flawlessly since then.

@highskillzz We haven't heard back from you, so am assuming that things are working as expected.


Modify default ColumnOption from NOT NULL to NULL

Issue
Currently, default ColumnOption is NOT NULL but many users would consider column as NULL
CREATE TABLE Foo (no INT);

TABLE_NAME
COLUMN_NAME
NULLABLE

Foo
no
NOT NULL

Goal
To reduce confusion, Let's modify default ColumnOption from NOT NULL to NULL
CREATE TABLE Foo (no INT);

TABLE_NAME
COLUMN_NAME
NULLABLE

Foo
no
NULL

Looking forward to this update! This would simply the code from #629 .


Title-Change-Recommendations are not in every case possible

open a motion and click on the plus sign before its title
insert a change recommendation and save it
delete the recommendation because you have e.g. made a typo
try to create a new, this time correct, recommendation

result: this is not possible. One has first to go back to the motion list, then open the motion again.
Title-Change-Recommendations are new since #3626.

@donovaly I cannot really reproduce this error right now. Did you switch to original view again when trying to re-create the second change recommendation (as this is not possible in diff-view)?

I am using a build Emanuel sent me on Friday.

Did you switch to original view again

I go with the mouse before the first character of the title and press the appearing plus button to create a change
I delete the title change recommendation by pressing the red trash can icon behind the thumb icons
I go with the mouse before the first character of the title and now I don't get the plus button to create a new change

Do you see the menu to switch between different change recommendation modes?

Does is make any difference if you switch to the "Original Version"? Creating recommendation is done in the Original Version, while deleting them with the trash icon is on the "Diff version"...

Do you see the menu to switch between different change recommendation modes?

Yes. In this view I deleted the change and wanted to add a new one subsequently.

Does is make any difference if you switch to the "Original Version"?

I don't understand. I can only delete the change in the diff version, I do this, Afterwards I cannot select a version because I am correctly back to the motion without any changes. In this state I just want to create a new title change.

Ok, I think I found the problem. The motion does not switch back to the original view after deleting the title change recommendation if it is the last one, therefore this problem ocurres. I've created a patch for it.

See also the related bug #3672.


Add smesherID to logs around ATX building and for supervised service

Motivation
To easily distinguish logs for different smeshers in the ATX building process.
Description
Note: the smesherID in the supervised service logs is not necessary in production (there is always only 1) but it is helpful in debugging tests (as there might be many).
Test Plan
n/a
TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[ ] Update documentation as needed
[ ] Update changelog as needed

bors merge

bors cancel

bors merge


Performance gap in mmdetection

I'm sorry. I am back.
I have been tried  retinanet_r50_fpn_1x_int8.py in mmdetection, there is nothing wrong in training and evaluation.
But i only got this result in coco2017 val, docs showed that retinanet can reached 34.7 or 35.3 average box mAP on the coco_2017_val dataset.
My result are as follows:
Average Precision  (AP) @[ IoU=0.50:0.95 | area=   all | maxDets=100 ] = 0.260
Average Precision  (AP) @[ IoU=0.50      | area=   all | maxDets=100 ] = 0.420
Average Precision  (AP) @[ IoU=0.75      | area=   all | maxDets=100 ] = 0.272
Average Precision  (AP) @[ IoU=0.50:0.95 | area= small | maxDets=100 ] = 0.143
Average Precision  (AP) @[ IoU=0.50:0.95 | area=medium | maxDets=100 ] = 0.292
Average Precision  (AP) @[ IoU=0.50:0.95 | area= large | maxDets=100 ] = 0.336
Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=  1 ] = 0.258
Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets= 10 ] = 0.425
Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=100 ] = 0.453
Average Recall     (AR) @[ IoU=0.50:0.95 | area= small | maxDets=100 ] = 0.260
Average Recall     (AR) @[ IoU=0.50:0.95 | area=medium | maxDets=100 ] = 0.494
Average Recall     (AR) @[ IoU=0.50:0.95 | area= large | maxDets=100 ] = 0.600
I didn't change anything in config file expect changing samples_per_gpu from 6 to 4 because my gpu can't allocate enough memory. My cuda version is 10.2, pytorch is 1.6.0.
If you need any other information please contact me

Maybe i know what's wrong, your base model is 'retinanet_r50_fpn_1x_voc0712_20200617-47cbdd0e.pth', but your dataset is coco, i think this is why performance descend hardly. Is there something wrong in my understanding or operation?

I have been compare performance between compressed model and official mscoco trained model.
the model name is 'retinanet_r50_fpn_1x_coco_20200130-c2398f9e.pth'.
nncf run evaluation on single 1080Ti as 13.8 task/s and official implementation with model 13.6 task/s, almost the same speed.
and nncf model consume about 2121MB GPU memory at maximum, official mmdetection 1515 GPU memory at maximum, after quantization, model seem to consume more GPU memory. Is this right?
To util the nncf to speedup or reduce memory usage, should i convert the model to onnx and use the openvino?

@Wang-zipeng

To util the nncf to speedup or reduce memory usage, should i convert the model to onnx and use the openvino?

Correct.

Maybe i know what's wrong, your base model is 'retinanet_r50_fpn_1x_voc0712_20200617-47cbdd0e.pth', but your dataset is coco, i think this is why performance descend hardly. Is there something wrong in my understanding or operation?

@Wang-zipeng , you are right. This model was pre-trained on VOC dataset.
If you want pretrained retinanet_r50_fpn_1x on COCO you can change the line
load_from = "https://open-mmlab.s3.ap-northeast-2.amazonaws.com/mmdetection/v2.0/pascal_voc/retinanet_r50_fpn_1x_voc0712/retinanet_r50_fpn_1x_voc0712_20200617-47cbdd0e.pth"
to
load_from="http://download.openmmlab.com/mmdetection/v2.0/retinanet/retinanet_r50_fpn_2x_coco/retinanet_r50_fpn_2x_coco_20200131-fdb43119.pth"
Also, there are different pretrained retinanet models which you can use: https://github.com/open-mmlab/mmdetection/tree/master/configs/retinanet


CI doesn't catch unit test failure on Windows

Godot version
master
System information
GitHub Actions
Issue description
I've recently ran into issues with my PR that caused some unit test runs to fail on CI. I initially thought that the problem was localized to MacOS and Linux, but upon running tests locally on Windows I found out it was affected as well. However, on CI the tests either didn't run, or didn't report anything.
Mac: https://github.com/godotengine/godot/runs/4866470574?check_suite_focus=true
Linux: https://github.com/godotengine/godot/runs/4866474222?check_suite_focus=true
Windows: https://github.com/godotengine/godot/runs/4866470448?check_suite_focus=true
In case the links are no longer available, here's what it looks like for the mac, and here's what windows shows. Again, locally tests fail the same as they should on other platforms (running through Windows Terminal, so essentially in PowerShell).
Steps to reproduce
See above.
Minimal reproduction project
N/a

@brno32 Not sure, haven't looked into it in a while. Checking latest master builds I can see that tests do appear to be running on Windows just as well as on other platforms. So probably not an issue anymore. But would be nice to confirm. You can probably try to break the tests on purpose and then check in your fork what it looks like on CI.

Probably fixed by #76887.


[BUG] System Up/Down Nudgers always use top system margin

I would like to modify the system up/down nudgers to use Distance Between instead of Top Margin. In general, a non-zero system margin offers much less flexibility with page layout than leaving the vertical system margins at zero.
If others feel that Top Margin is preferable, we could implement it so as to use the margin when it is non-zero or the distance between when it is zero or when the result would be negative.
What do y'all think? (It's a simple change.)

A year late, but I'm fine with this change.


static ServiceTracker object crashes in ServiceTracker::Close()

Fixes #281

Codecov Report

Merging #283 into development will increase coverage by 0.02%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           development     #283      +/-   ##
===============================================
+ Coverage        84.29%   84.31%   +0.02%
===============================================
  Files               94       94
  Lines             6456     6458       +2
===============================================
+ Hits              5442     5445       +3
+ Misses            1014     1013       -1

Impacted Files
Coverage Δ

framework/src/bundle/BundleContext.cpp
90.9% <100%> (+0.04%)
:arrow_up:

...include/cppmicroservices/detail/ServiceTracker.tpp
76.57% <100%> (+0.1%)
:arrow_up:

framework/src/bundle/BundleContextPrivate.cpp
100% <0%> (+3.84%)
:arrow_up:


Suggestion: Confirm creation of folders via dialogbox

With the changes in version 0.3.0, I have the problem that I explicitly need to create folders in my workflow if they do not yet exist.
Would it be possible to include a dialog prompt that the user explicitly agrees to the creation of a folder if it does not yet exist?
An alternative option could be to include a checkbox or slider in the settings page of the plugin where the user can switch the option on or off.

I created an option to enable it. Thanks


mirakle-benchmark on Gradle 6+

There seems to be an issue with mirake-benchmark when trying to run on Gradle 6+.
Mirakle itself works great, but the benchmark module fails with this error:
Task :mirakleBenchmark FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':mirakleBenchmark'.
> Could not execute build using Gradle distribution 'https://services.gradle.org/distributions/gradle-6.1.1-all.zip'.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.1.1/userguide/command_line_interface.html#sec:command_line_warnings```

Could you run your build with --stacktrace option and post the output please.
Benchmark does work for me with Gradle 6+ btw.


Standalone Rcs (steel4me)

ty for everything in this code steel4me (https://github.com/steel4me/Osiris.git), i'm just making this up to date.

I'm soooo new on github,if i'm making something wrong plz tell me, ty.

duplicate pr delete pls

but i cant find rcs

uhhh i cant find rcs too

/del

/del

can i hav hlp plz how do i add to original


Investigate client behaviour in a case of target pod/node restart

From this discussion https://apifier.slack.com/archives/C013WC26144/p1653552365035479, it seems that sometimes there is a series of network errors that lead to a suspicion that the client might be retrying the requests to the same pod although it's dead.
2022-05-16T00:38:56.894Z WARN  ApifyClient: API request failed 4 times. Max attempts: 9.
2022-05-16T00:38:56.897Z Cause:Error: aborted
2022-05-16T00:38:56.899Z     at connResetException (node:internal/errors:692:14)
2022-05-16T00:38:56.901Z     at Socket.socketCloseListener (node:_http_client:414:19)

Note: We could test this on multistaging by starting two API pods, starting an actor which uses the API in a loop, and then we would kill one of the two pods. We could also make a testing version of the client with some more debug logging to help us figure it out.

2 pod multistaging here https://github.com/apify/apify-core/pull/6934

It looks like keepalive doesn't work it will not propagate through the application load balancer and the requests are distributed between pods.
There is a list of pods used for each API call, I was doing get run API call from the same apify client instance every 0,5 s.
Because I have just 2 pods and ALB uses a round-robin schema the pods were switched each request.
0: "apify-api-dummymultistagingbranchfortesting-67745785c5-4btl4"
1: "apify-api-dummymultistagingbranchfortesting-67745785c5-gf6m6"
2: "apify-api-dummymultistagingbranchfortesting-67745785c5-4btl4"
3: "apify-api-dummymultistagingbranchfortesting-67745785c5-gf6m6"
4: "apify-api-dummymultistagingbranchfortesting-67745785c5-4btl4"
5: "apify-api-dummymultistagingbranchfortesting-67745785c5-gf6m6"
6: "apify-api-dummymultistagingbranchfortesting-67745785c5-4btl4"
7: "apify-api-dummymultistagingbranchfortesting-67745785c5-gf6m6"
8: "apify-api-dummymultistagingbranchfortesting-67745785c5-4btl4"
9: "apify-api-dummymultistagingbranchfortesting-67745785c5-gf6m6"
10: "apify-api-dummymultistagingbranchfortesting-67745785c5-4btl4"
11: "apify-api-dummymultistagingbranchfortesting-67745785c5-gf6m6"
12: "apify-api-dummymultistagingbranchfortesting-67745785c5-4btl4"
13: "apify-api-dummymultistagingbranchfortesting-67745785c5-gf6m6"
14: "apify-api-dummymultistagingbranchfortesting-67745785c5-4btl4"
15: "apify-api-dummymultistagingbranchfortesting-67745785c5-gf6m6"
16: "apify-api-dummymultistagingbranchfortesting-67745785c5-4btl4"
17: "apify-api-dummymultistagingbranchfortesting-67745785c5-gf6m6"
18: "apify-api-dummymultistagingbranchfortesting-67745785c5-4btl4"
19: "apify-api-dummymultistagingbranchfortesting-67745785c5-gf6m6"
20: "apify-api-dummymultistagingbranchfortesting-67745785c5-4btl4"
21: "apify-api-dummymultistagingbranchfortesting-67745785c5-gf6m6"
22: "apify-api-dummymultistagingbranchfortesting-67745785c5-4btl4"
23: "apify-api-dummymultistagingbranchfortesting-67745785c5-gf6m6"
24: "apify-api-dummymultistagingbranchfortesting-67745785c5-4btl4"
25: "apify-api-dummymultistagingbranchfortesting-67745785c5-gf6m6"
26: "apify-api-dummymultistagingbranchfortesting-67745785c5-4btl4"
27: "apify-api-dummymultistagingbranchfortesting-67745785c5-gf6m6"
28: "apify-api-dummymultistagingbranchfortesting-67745785c5-4btl4"
29: "apify-api-dummymultistagingbranchfortesting-67745785c5-gf6m6"
30: "apify-api-dummymultistagingbranchfortesting-67745785c5-4btl4"
31: "apify-api-dummymultistagingbranchfortesting-67745785c5-gf6m6"
32: "apify-api-dummymultistagingbranchfortesting-67745785c5-4btl4"
33: "apify-api-dummymultistagingbranchfortesting-67745785c5-gf6m6"
34: "apify-api-dummymultistagingbranchfortesting-67745785c5-4btl4"

If you restart one node it simply switches to the new one.

If we want to support keep-alive headers we probably need some changes on ALB or elsewhere in platform networking. Not sure if it can affect users that it is not working right now, but it probably didn't work from a time when we start using ALB, cc @dragonraid @mnmkng

I will move this to the icebox and we can follow up once the issue appears again. It looks like some network or any other error. But hard to say two months after, we do not have any logs and the issue didn't appear in the same actor again till this report.


Bug: NaN in balanceCheck when doing tx

Description
When trying to swap with gooddapp, the below error message shown
Its only a copy/ui bug, but might be confusing to users
Steps to reproduce

connect to gooddapp, do a swap on celo
see below modal in wallet

Which network did you use?
Celo
Supporting data

https://github.com/GoodDollar/GoodProtocolUI/issues/424#issuecomment-1568480975

i believe this has been fixed in latest wc2 fixes


Update XDR Viewer to support Protocol 14 changes

What problem does your feature solve?
Stellar-Core v14 has been released which means that XDR structures for Protocol 14 won't change. It will help with debugging and developing Protocol 14 features if XDR Viewer was updated to support new structures.
What would you like to see?
XDR Viewer supports new structures like ClaimableBalance.
What alternatives are there?
Manual decoding.

Upgrading stellar-sdk to v6.0.0 added support for new Protocol 14 structures.


Arch: refactor and add unit tests for EventStreamRuntime docker image build

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
Give a brief summary of what the PR does, explaining any non-trivial design decisions

Refractor EventStreamRuntime specific logic out of image_agnostic.py, and create a runtime_build.py under runtime/utils to keep all the EventStreamRuntime-related image-agnostic docker building logic.
Add unit tests for runtime_build.py.

Other references

Most LGTM! Great work!


Suppress authors in better-bibtex-citekeys.csl style?

Hi all,
I was using the better-bibtex-citekeys.csl to go from Word to Pandoc---this is a great hidden feature, thanks a lot for that. Previously, I was trying to use regex to get Pandoc citation from the Zotero field codes ...
The only thing that does not work is suppressing authors. If the regular citation looks like that [@jogru-bugreport-2020], it should become [-@jogru-bugreport-2020] if "suppress authors" is checked. In the Zotero field code for Word "suppress-author":true is added.
I tried it with a macro like this in the CSL:
  <macro name="noauthor">
    <choose>
      <if variable="suppress-authors">
        <text value="@" prefix="-"/>
      </if>
      <else>
        <text value="@"/>
      </else>
    </choose>
  </macro>

I also tried suppress-author as variable name (because that is how it is documented for citeproc-js: https://citeproc-js.readthedocs.io/en/latest/csl-json/markup.html#cite-items). Unfortunately, this also did not work. Finally, I tried "author" as the variable name because I thought the suppress author tickbox would maybe just unset the author name. This also did not work. Also, I could not really figure out why the author disappears in other styles.
I might further look into this but since my CSL knowledge is almost zero, maybe someone already has an idea how to check if "suppress-authors" is set.
Best,
Johann

I really think the debug log is unnecessary here, at least if you are not telling me it should work already. However, in case, here it is: D928181290

Yeah

I might further look into this but since my CSL knowledge is almost zero, maybe someone already has an idea how to check if "suppress-authors" is set.

"Someone" is just me on this repo. And unfortunately I know absolutely nothing about CSL, being, after all, a LaTeX-head.

I really think the debug log is unnecessary here, at least if you are not telling me it should work already. However, in case, here it is: D928181290

It isn't necessary here, it's just the standard reply by label-gun if you select anything else than question for the issue type. I can only read BBT-specific logs BTW (the ones whose IDs end in -euc or -apse); the D<number> reports are only accessible to the official Zotero crew.

I don't know anything about CSL; you'll fare better asking this question on the Zotero forums.


lib.doRename: add test for nested option priorities

issue: https://github.com/NixOS/nixpkgs/issues/324802
This test demonstrates a bug where lib.doRename leads to a crash when a nested old option is defined with priority
If old.foo is defined with priority (mkDefault in this example) and then old is renamed to new, evaluation crashes with a misleading type error:
 error: A definition for option `new.foo' is not of type `signed integer'. Definition values:
       - In [...]:
           {
             _type = "override";
             content = 1234;
             priority = 1000;
           }

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

doRename requires paths to actual options; not trees of them. I don't think its implementation or interface are suitable this, so I've opened

https://github.com/NixOS/nixpkgs/pull/324917


[Docs] modify the img in inference_detector(model, img)

In inference_detector(model, img), the img  should be an image object or matrix not an img path
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
The documentation has been modified accordingly, like docstring or example tutorials.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @chg0901
Thanks for your kind PR. It seems that CLA is not signed. Could you sign the CLA so that eventually we could merge this PR after review? You can check the contents and follow the instruction in the communication box shown as below

Hi @chg0901
Thanks for your kind PR. It seems that CLA is not signed. Could you sign the CLA so that eventually we could merge this PR after review? You can check the contents and follow the instruction in the communication box shown as below

Hello, @ZwwWayne , I have signed the CLA. Thank you for your help. Have a nice day~

Hi @chg0901 ,
Thanks for your kind contribution. Would you like to fix the lint issue so that we could merge this PR?
The details can be found by clicking the item of lint check as shown below

Please fix the lint issue. You can install pre-commit hook on your machine like following:
pip install -U pre-commit
cd mmdeploy
pre-commit install

Then you can run pre-commit run --all-file to check whether there are lint errors


Cookie length will exceed browser maximum

When i try to login, it throws:
Unexpected Server Error

Error: Cookie length will exceed browser maximum. Length: 10387

when i remove guilds from object it works but i need guilds

In the example it explicitly says that this is likey to happen and what to do in that case.
Here it is again:

IMPORTANT: This can quickly fill the session storage to be too big.
So make sure you only return the values from the guilds (and the guilds) you actually need
(eg. omit the features)
and if that's still to big, you need to store the guilds some other way. (Your own DB)

ah yeh, sorry


Add requested server name attribute to release 1 0

Checked according to https://istio.io/docs/examples/advanced-egress/egress-gateway/#direct-https-traffic-through-an-egress-gateway.
kubectl -n istio-system logs $(kubectl -n istio-system get pods -l istio-mixer-type=telemetry -o jsonpath='{.items[0].metadata.name}') mixer | grep tcpaccesslog.logentry.istio-system | grep '"connectionEvent":"open"'
{"level":"info","time":"2018-08-17T02:30:32.692709Z","instance":"tcpaccesslog.logentry.istio-system","connectionDuration":"0s","connectionEvent":"open","connection_security_policy":"unknown","destinationApp":"istio-egressgateway","destinationIp":"<IP_ADDRESS>","destinationName":"istio-egressgateway-7fb9959565-6pdxk","destinationNamespace":"istio-system","destinationOwner":"kubernetes://apis/extensions/v1beta1/namespaces/istio-system/deployments/istio-egressgateway","destinationPrincipal":"","destinationServiceHost":"edition.cnn.com","destinationWorkload":"istio-egressgateway","protocol":"tcp","receivedBytes":0,"reporter":"source","requestedServerName":"edition.cnn.com","sentBytes":0,"sourceApp":"sleep","sourceIp":"<IP_ADDRESS>","sourceName":"sleep-776b7bcdcd-f2dsb","sourceNamespace":"default","sourceOwner":"kubernetes://apis/extensions/v1beta1/namespaces/default/deployments/sleep","sourcePrincipal":"","sourceWorkload":"sleep","totalReceivedBytes":0,"totalSentBytes":0}
{"level":"info","time":"2018-08-17T02:30:32.696204Z","instance":"tcpaccesslog.logentry.istio-system","connectionDuration":"0s","connectionEvent":"open","connection_security_policy":"unknown","destinationApp":"","destinationIp":"<IP_ADDRESS>","destinationName":"unknown","destinationNamespace":"default","destinationOwner":"unknown","destinationPrincipal":"cluster.local/ns/istio-system/sa/istio-egressgateway-service-account","destinationServiceHost":"","destinationWorkload":"unknown","protocol":"tcp","receivedBytes":297,"reporter":"source","requestedServerName":"edition.cnn.com","sentBytes":0,"sourceApp":"istio-egressgateway","sourceIp":"<IP_ADDRESS>","sourceName":"istio-egressgateway-7fb9959565-6pdxk","sourceNamespace":"istio-system","sourceOwner":"kubernetes://apis/extensions/v1beta1/namespaces/istio-system/deployments/istio-egressgateway","sourcePrincipal":"cluster.local/ns/default/sa/default","sourceWorkload":"istio-egressgateway","totalReceivedBytes":297,"totalSentBytes":0}

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: kyessenov
If they are not already assigned, you can assign the PR to them by writing /assign @kyessenov in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
mixer/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vadimeisenbergibm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
ed71c9e74ab915b9c2ecf20ddd7f8025e910fd80
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vadimeisenbergibm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
9fac0de6ab6192901bb9241a60a3523e0082924e
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

we may need to bump the proxy to pick up https://github.com/istio/proxy/pull/1909

@vadimeisenbergibm: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vadimeisenbergibm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
330fd92bf7172de7600d9ab40f679da47f5711e2
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov Would it be OK to merge this one without https://github.com/istio/proxy/pull/1924? Now this one passes the tests, so https://github.com/istio/proxy/pull/1924 could be merged later to 1.1 or 1.0.2. If yes, could you please approve this PR?

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: kyessenov
If they are not already assigned, you can assign the PR to them by writing /assign @kyessenov in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vadimeisenbergibm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
d5bf9d2a5515666150442a5bd6cc353c183b4c1e
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vadimeisenbergibm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
d5bf9d2a5515666150442a5bd6cc353c183b4c1e
link
/test istio-unit-tests

prow/istio-presubmit.sh
d5bf9d2a5515666150442a5bd6cc353c183b4c1e
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov
https://github.com/istio/proxy/pull/1924 has been merged, I have updated this PR. Waiting for https://storage.googleapis.com/istio-build/proxy/envoy-debug-cc83ed8fe87d854f6a3f14a06d874879a78076d1.tar.gz to be uploaded.

/retest
/lgtm
/approve
Thanks for doing this @vadimeisenbergibm . Changes look good to me.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyessenov
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vadimeisenbergibm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
d5bf9d2a5515666150442a5bd6cc353c183b4c1e
link
/test istio-presubmit

prow/istio-unit-tests.sh
d5bf9d2a5515666150442a5bd6cc353c183b4c1e
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

@vadimeisenbergibm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
8b05bb0699d0506f4866645eca778f5cc67107be
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vadimeisenbergibm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
c2b45c5b77b1ae47621be4f7dfdf7c5a0e23dd95
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyessenov
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks @kyessenov, sorry I missed additional changes, hope the tests will pass now.

@vadimeisenbergibm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
f87e1fc494f625d2a9c5eec43404152c39a4007c
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-bookInfo-envoyv2-v1alpha3

@costinm @rkpagadala Could you please merge  this one? It is a PR that depends on
https://github.com/istio/proxy/pull/1924. The PR is a minor one - adds a Mixer attribute to two log entries, updates istio/proxy according to https://github.com/istio/proxy/pull/1924 and fixes the tests accordingly. It is a customer issue, I would like to have it in 1.0.1.

Thanks, @costinm ! This is SNI reporting to Mixer, BTW.


Cannot determine module for ButtonWidget

In package.json
"angular2-schema-form": "^1.0.0-beta.7",
npm list yields<EMAIL_ADDRESS>I destroyed my node modules. After npm install and then npm start I get the following error.
ERROR in Cannot determine the module for class ButtonWidget in /Users/joshuarymer/workspaces/gmm/gmm-ui/node_modules/angular2-schema-form/dist/defaultwidgets/button/button.widget.d.ts! Add ButtonWidget to the NgModule to fix it.
Also tried npm install angular2-schema-form --save
Node v7.4.0
npm 4.0.5
Angular CLI 1.3.0
Angular 4.3.4

Got the same issue with last release.

I tried your above fix, did it work for you?

@jrymer yep it work

@jrymer You can also force npm to use the version "1.0.0-beta.7", juste remove the ^ in package.json:
"angular2-schema-form": "1.0.0-beta.7",

@enavarro222 I reverted back to 1.0.0-beta.7 when I realized the issue was with latest.
I'm new to this so out of curiosity, how were you able to modify the module.ts? I was only able to see js files. Did you fork the repo and edit there? Can this not be done directly in node_modules?

@jrymer with npm install you only get compiled js. So to edit ts files you need to clone the repo and compile it "by hand".
In ./node_modules:
$ rm -rf angular2-schema-form/
$  git clone git@github.com:makinacorpus/angular2-schema-form.git
$ cd  angular2-schema-form/
$ ## Edit what you need
$ npm install              # install angular2-schema-form dep
$ npm run build            # build it

Thanks, appreciate the quick lesson.


More help with Testing with Xcode

Hi, I'm starting to code and the Apple developers documentation for Testing in Xcode is quite complex right now... Maybe you could add -some day- a simple guide (for complete dummies like me) about how to work with Xcode for testing, which are the steps and maybe also the basic syntax in an exercism exercise (bob for example)? Thanks.

Thanks for writing in. Have you tried the hello world exercise?

Yes, I did! But I just practised in a playground file and then, when I saw that worked, I copied it in the hello-world.swift file and pushed it...

Ah okay.  Have you seen this one too?
https://github.com/exercism/xswift/blob/master/docs/TESTS.md
I'm trying to figure out how to make it better or give it better exposure if you have seen it.

@masters3d Yes, I've followed all the steps, and besides 2 points that were a bit confusing (if you want I can tell you them as well later) everything went fine. The problem is that after that, I get stuck before the point: "Now use CMD-U to run the tests, and happy coding!" (well also I don't know how to do that :/) Maybe it could be a guide for super newies about that? Between the previous point and this one, there is for me a big empty frustrating hole. In my case for example, in the LeapTest.swift, I don't know where it comes from the class LeapTest: XCTestCase, what means and what should I do with every function inside it, what means XCTAssertTrue(year.isLeapYear)... After 2 days researching and trying things I can figure out a bit how it works... I showed this guide to my developer friend: https://developer.apple.com/library/content/documentation/DeveloperTools/Conceptual/testing_with_xcode/chapters/02-quick_start.html#//apple_ref/doc/uid/TP40014132-CH2-SW1 and told me that this is thought for an experienced developer. Maybe would be interesting to add 2 or 3 more points explaining the unit tests syntax and steps inside Xcode...

But anyway, maybe I just can work with a playground file, and just push the final file once I know that the problem works, without using the XCT environment. I think I will study Unit Testing further in the course I'm doing.

here is something you could use to only use the playground
https://github.com/WhiskerzAB/PlaygroundTDD
I am afraid that could be a little more involved though.

@masters3d Hmmm the problem is just that I'm not used to any kind of TDD... My mentors told me that this will come later (now I should focus in learning to understand classes, functions, optionals...) but I though exercism was also thought for people that is starting to learn :/ I should give up now with excercism then and come back in the future?

For example, I uploaded here the exercise just to show you https://github.com/celiagomezdev/Leap
Now is giving the error 'Cannot load underlying module for XCTest' so I cannot test :/
Also, I don't know what exactly means the XCTAssertTrue(year.isLeapYear) line... I imagine it means that this test should return true, but what means and how the program read what is inside ()? Also, in the 'Hello World' excercise, is very complex to understand every part of: XCTAssertEqual(HelloWorld.hello("Alice"), expected, "When given 'Alice' we should greet Alice!").
(Thanks a lot for helping me)

Use the hello world sample project as a guide. If you replace the files inside the hello world with the ones in leap, it should work.
http://stackoverflow.com/questions/29965397/cannot-load-underlying-module-for-xctest

@masters3d I've managed to solve the problem at the end! And now I understand a bit how the XCTests work. But I still thinking it would help a little guide of the XCT workflow and syntax for very very newies. Thanks for your help!

sounds good. let me know if you find a good tutorial and we will link it.

I didn't find... they were too long or too complex for non-experienced developers. Is that because I thought it would be good to add only two or three points more in this guide: https://github.com/exercism/xswift/blob/master/docs/TESTS.md
between this point:

Select Bob.swift and in the File Inspector make sure that both bob-swift and bob-swiftTests are checked in the Target Membership area.

and this one:

Now use CMD-U to run the tests, and happy coding!

Like for example (but more accurate explained):

Write the code you consider in your working file (Bob.swift) in order to make the tests in LeapTest.swift work (now they will show you some errors, but writing the right code in your working file should make them disappear)._
Once you think that you are done, you just need to go to the Test Navigator (show image) and click the play button next to the tests. If they are correct, they will show a green mark, if not, they will show a red mark and highlight the non-passed tests. Modify your code in your working file until all the tests succeed.
Some syntax: XCTestCase class is the class that contains the tests, and every function is every test. Ignore all this in your working file Bob.swift, there you just need to write the code that will make every of those functions (tests) succeed... XCTAssert lines are the expected results, and there are different types that mean... Equal: ... True/False... For example, in the BobTest.swift file, the line XCTAssertEqual(expected, result) means that...

And then just the line:

Now use CMD-U (or directly in Xcode) to run the tests, and happy coding!

Maybe looks too obvious, but it would help a lot for the people who never had contact with programming or TDD before.

Those look good to me. Do you want to submit a pull request with those changes?

Ok, done! Looking forward to your comments.

Nice work. Thanks!


hadoop: fix failing builds

Co-authored-by: itihas<EMAIL_ADDRESS>
Motivation for this change
Hadoop fails to build on nixos-unstable. This is caused by

glibc 2.23 no longer having some symbols (https://issues.apache.org/jira/browse/HADOOP-17569)
libtirpc being added as a dependency

Things done

Pull upstream patch https://github.com/apache/hadoop/pull/2886/files
Add libtirpc in buildinputs,  cflags, and ldflags

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS

[x] hadoop_3_0
[ ] hadoop
[ ] hadoop_3_1
[ ] hadoop_2_9
[ ] hadoop_2_8

[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 123331 at 042b1305 run on x86_64-linux 1

6 packages marked as broken and skipped:

hadoop
hadoop_2_7
hadoop_2_8
hadoop_2_9
pig
spark

2 packages built successfully:

hadoop_3_0
hadoop_3_1

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/networking/cluster/hadoop/default.nix:90:9:
   |
90 |         installPhase = ''
   |         ^


A little too greedy for mech parts

No way Darius negotiated that bad.
Is it intentional that only mechs are held back?

loot_magnet.log

I'm not one of the devs for this mod, but looking at the code I think this might be symptom of the current way that Helper.HoldbackSalvage calculates the number of held back items (Helper.cs lines 96-102) . It is currently is purely based on the total size of the salvage list, so it looks unreasonably brutal in RogueTech because the size of the loot table will often be large (more items means more stuff held back). If you factor in the relative ratio of "good-stuff" to "bad-stuff" and you get an issue where a large number mech-parts and/or high value internal parts are held back, even on low holdback chances (e.g. a 10% roll on a 50 item loot table will average at 5 items held back).  I think that is what you are seeing here!
Perhaps the mod devs could modify how the number of heldback items is calculated to be capped? Maybe based on the contract negotiation, so that larger loot tables are less punishing on players!!

Actually, thinking about this some more, I think capping the number won't be enough. Because of the way the statistics works (Binomial distribution here) I would anticipate that most players will see at least one mech part held back in almost all missions using the current code.
E.g. The chance to see at least a certain number of items held back (calculated using this website) assuming only a 1% holdback chance:

Loot table size
1 item held
2 held
3 held
4 held

20
18.2%
1.7%
0.1%
almost 0%

40
33.1%
6.1%
0.7%
0.1%

60
45.3%
12.1 %
2.2%
0.3%

80
55.2%
19.1%
4.7%
0.9%

And those numbers are for a 1% holdback chance, not 10+%! So I would expect that the current logic will make most players see a loss of at least 1 mech part in almost every mission until they get some really good rep!

Yes, DeltaIII, that correlate with what i see on my current playthrough. And it's looks like partial mech salvage bundles up before being held back, so even if you headshot 3 mechs (4 pieces in 5-piece-to-rebuild setting) and loot screen holdback message shows three partial mech salvage being removed, all 12 pieces are gone.
I also believe it would be better to use two different holdback queues, for mech parts and for everyting else, with different settings. Not so keen on emploer to hold back Locust's parts when there is an Engine XL(C) collecting dust in pile of Mlasers.

Yes, it's intentional that the most valuable parts are held back first. In most cases, that's going to be mech parts. However, LM does not currently split the partial mech price by the # of parts required to assemble a full mech, so the values are overly-inflated at the moment.
I've made significant changes in 2.0, with the game consistently taking 2-6 parts when holdback is triggered. However, holdback is triggered infrequently when you are friendly. Once 2.0 drops I'd encourage you to check it out and see if it addresses your complaints.
Thanks for the report!


Add gRPC extension

This adds Saturn gRPC extension using @mgravell's https://github.com/protobuf-net/protobuf-net.Grpc.
Check sample/gRpcSample/gRpcSample.fs for sample server definition (same ICalculator sample from original F# implementation).
And... it's working ;-)

CC: @isaacabraham

Just for context: the work I've done here builds heavily on grpc-dotnet, the main difference being that grpc-dotnet uses Google's contract-first approach - and an inherent "feature" of the Google tooling is that it only currently supports C#, so can't be used with native F#. The point of protobuf-net.Grpc is that it adds code-first processing to both grpc-dotnet and the native P/Invoke-based grpc implementations, and once we're talking "code-first": it works with any suitable .NET language, including C#, F#, VB, etc.

@Krzysztof-Cieslak looks great. My only "concern" is whether we really want to add grpc and protobuf support to Saturn? It feels to me a bit like a secondary concern and not really necessary for bundling into the core Saturn package.

Looks great :-) Now that I've actually realised that you've created an extensions package as well - perfect.


[CH] Support SortAggregateExec

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Offload SortAggregateExec into native engine.

How to test SortAggregateExec:

spark.sql.execution.useObjectHashAggregateExec=false
spark.sql.autoBroadcastJoinThreshold=-1
query: select k1, collect_list(k1) as k3 from (select floor(id/4) as k1 from (select id from range(10)) as t1) as t2 group by k1

For consecutive sort agg, I guess the second one is for partial merge.


Cannot import user defined functions / custom operators

Hi, thanks for the package, it is a joy to use. 😊
I want to ask for advice, as I am not sure if I am missing something from the documentation.
I have a query builder with some custom operators on a field. For example:
{
  label: 'content',
  name: 'content',
  operators: [
    ...
    {
      label: 'matches',
      name: 'matchesRegex',
    },
    ...
  ]
}

And I can export them fine with this:
const newOutput = formatQuery(query, {
  format: 'sql',
  ruleProcessor: getCustomRuleProcessor(),
})

function getCustomRuleProcessor() {
  return (rule, options) => {
    if (rule.operator === 'matchesRegex') {
      return `match(${rule.field}, '${rule.value}')`
    }
    return defaultRuleProcessorSQL(rule, options)
  }
}

The code above could result in something like (match(content, 'test'))
But it seems to not be possible to import that same query with the parseSQL function. I don't see anything like a rules processor for parsing.
I've built a small exmaple project here: https://stackblitz.com/edit/react-mkb274?file=src%2FApp.js Copying something like (match(content, 'test')) into the textarea does not result in the user interface changing but putting something like (author = 'Bob') does make a change. See screenshots to see what I mean:

Is it possible? Any ideas on how to import user-defined-functions/custom-operators?

Thanks for the kind words! I'm glad it's helpful.
The problem with parsing custom functions/operators/etc. is that the SQL parser (grammar definition here, generated parser code here) is generated using only common, standard SQL syntax. To parse anything custom it would need to be regenerated, because it can only parse the syntax that it knows about beforehand.
As far as immediate options, I would say the simplest one would probably be to "trick" the parser into thinking it found a standard operator, but manipulating the result in a way that you could post-process the resulting query to use the operators you want. Something like this:
Working sandbox here
(Note that this example doesn't have any error checking or validation.)
import { useState } from "react";
import {
  defaultOperators,
  defaultRuleProcessorSQL,
  Field,
  parseSQL,
  RuleGroupType,
  RuleProcessor,
  transformQuery,
} from "react-querybuilder";
import { QueryBuilder, formatQuery } from "react-querybuilder";
import "./styles.scss";

const fields: Field[] = [
  {
    name: "firstName",
    label: "First Name",
    operators: [
      {
        label: "matches",
        name: "matchesRegex",
      },
      ...defaultOperators,
    ],
  },
  { name: "lastName", label: "Last Name" },
];

const initialQuery: RuleGroupType = {
  combinator: "and",
  rules: [
    { field: "lastName", operator: "in", value: "Vai,Vaughan" },
  ],
};

const ruleProcessor: RuleProcessor = (rule, options) => {
  if (rule.operator === "matchesRegex") {
    return `match(${rule.field}, '${rule.value}')`;
  }
  return defaultRuleProcessorSQL(rule, options);
};

// Before you run the string through `parseSQL`,
// replace "match(x, 'y')" with "x = '::match::y'"
// so the parser will recognize it as a standard
// 'x = y' operation.
const preProcessSQL = (sql: string) =>
  sql.replaceAll(/\bmatch\((\w+),\s*'(.*?)'\)/g, `$1 = '::match::$2'`);

// Once you have the `RuleGroupType` from `parseSQL`,
// run it through `transformQuery` to process any rules
// where the value starts with "::match::" to your custom operator.
const postProcessQuery = (query: RuleGroupType) =>
  transformQuery(query, {
    ruleProcessor: (r) => {
      if (
        r.operator === "=" &&
        typeof r.value === "string" &&
        r.value.startsWith("::match::")
      ) {
        return {
          ...r,
          operator: "matchesRegex",
          value: r.value.replace(/^::match::/, ""),
        };
      }
      return r;
    },
  });

export const App = () => {
  const [query, setQuery] = useState(initialQuery);
  const [sql, setSQL] = useState(
    `(match(firstName, 'Stev.*') and lastName in ('Vai', 'Vaughan'))`
  );

  // 1. Read the SQL from the input
  // 2. Preprocess the string
  // 3. Parse it as SQL
  // 4. Postprocess the query
  // 5. Set the query state
  const onClickParse = () =>
    setQuery(postProcessQuery(parseSQL(preProcessSQL(sql))));

  return (

      <input type="text" value={sql} onChange={(e) => setSQL(e.target.value)} />
      <button type="button" onClick={onClickParse}>
        Parse SQL
      </button>

        Preprocessed SQL:

{preProcessSQL(sql)}

      <QueryBuilder
        fields={fields}
        query={query}
        onQueryChange={(q) => setQuery(q)}
      />

Query

        {formatQuery(query, { format: "sql", ruleProcessor })}

        {formatQuery(query, "json")}

  );
};


kafka receiver ack/nack support

refer to the https://github.com/cloudevents/sdk-go/pull/459, in many cases, we want Receiver ack/nack by the event handler result, like this:
// The ReceiverFn
fn := func(ctx context.Context, event cloudevents.Event) protocol.Result {
	// ack or nack by the event handler result
	err := doSomething(event)
	if err != nil {
		return protocol.ResultNACK
	}
	if err == IgnoreError {
		return protocol.ResultACK
	}
         // if the err !=nil, just do not ack
	return err
}
c.StartReceiver(ctx, fn)

This merge request is the implement for kafka.

Ok so let's wait first for #459 to merge and then we'll look into this one

I think you should not create a new struct for kafka message, but you should rely on WithFinish() to handle the ack/nack

The WithFinish method has two disadvantages

It repeated with message.Finish
Not clear for nack and ack logic than meaage.Finish

The implement will make kafka message just like the PubSub message.

WithFinish() function takes the same error of Finish, so you can easily plug the logic there.
I'm worried that this PR adds quite a lot of code.

Ok, i'll change it

Please add tests to cover the updated client behavior.

@slinkydeveloper I have moved the ack/nack logic to binding.WithFinish. then there just 2 files changes from master
https://github.com/cloudevents/sdk-go/pull/462/files

@slinkydeveloper
I simplified it， only implemented the ack method is ok。
https://github.com/cloudevents/sdk-go/pull/464/files

I think we can close it now as it's supersed by #464


Add clade

Is it okay to add a column?
Please check for correctness! I only know which sequences are for sure WA and assumed that all the others are CA.

I think CA & WA is a good way to tackle potentially hairy geographic naming until someone may suggest something else. We don't have any other names to work with yet, but this minimizes the geographic nature!


Resource Quota - Inconsistent height of limit fields

Setup

Rancher version: v2.6-head (0e2fdc8)
Browser type & version: Firefox Developer 101.0b7 (64-bit)

Describe the bug

The height of the limit fields are taller than the other fields in the row. (screenshots below)
To Reproduce

Navigate to create project --> members --> resource quotas
Click on Add a Resource

Result
Project Limit and Namespace default limit are too tall
Expected Result

Project Limit and Namespace default limit are the same height as resource type dropdown
Screenshots

Context
Discovered while reviewing #5504

Minor styling issue
* create project --> members --> resource quotas --> height of limit fields has grown (when compared with 2.6.5)

This is an existing issue in v2.6-head (0e2fdc8), unrelated to this change. Here's what a new instance of Dashboard looks like this morning

Originally posted by @rak-phillip in https://github.com/rancher/dashboard/issues/5504#issuecomment-1133064791

This has been fixed:

retest passed
QA  tested on HA local 2.7head 44d3d40
screenshot


Add graphml sample file

Download file from https://keybase.pub/mjdilworth/yed-aws-palettes/AWS - Developer Tools.graphml put in reader-graphml /test/resources  as  "AWS - Developer Tools.graphml".
Next add a "AWS - Developer Tools.graphml.meta" file with the single line "url-info=(the URL above)" in it.

Similar for
https://git.flexsim.com/sdk/flexsim-module-sdk/-/blob/61a9f90ad6083efe3917f3b889c919d0126579ba/Documentation/Classes/svg/OnClickEngine.graphml

https://zivgitlab.uni-muenster.de/sciebo-rds/sciebo-rds/-/blob/gitlab-ci-changes-in-folder/docs/static/images/kubernetes-clean-architecture.graphml

The snippet from
http://kb.yworks.com/article/78/

Missing the meta files :-)

the link  https://zivgitlab.uni-muenster.de/sciebo-rds/sciebo-rds/-/blob/gitlab-ci-changes-in-folder/docs/static/images/kubernetes-clean-architecture.graphml is invalid.

@rasBab  (3) Download the graphml files sing the download button ON the page, dont download the HTML PAGE :-)
We fixed already the files as (2).


Compacts Google Analytics events for MetroExtracts

Reorders Google Anaytics events for MetroExtracts page.
Previously: Events were organized primarily by country, so MetroExtracts events crowded out all other types of events, with the nondescriptive action click.
Now: All MetroExtracts are organized into a category metroextracts, with a descriptive action of extract_name.
Analyzing historical data will require joining the previous category name with action names after the changeover.
Additional Actions

[ ] Create dated note in Google Analytics when this is merged documenting the break to allow historical analysis

Connections

Fixes #4
Part of / connected to mapzen/developer#427

cc: @baldur @mjcunningham @migurski


Generalize pivot_hist to bar charts and plots

@papajohn Doing some spring cleaning on our issues. Is this still something we want to do?

I wrote a new pivot_bin that is much more general and mirrors bin. With the
new hist or with bar you can visualize the result.  There are some demos
under text that show this in action.  So I think pivot_hist should be
removed.
David E. Culler
Friesen Professor of Computer Science
Electrical Engineering and Computer Sciences
University of California, Berkeley
On Wed, Oct 7, 2015 at 10:49 PM, Sam Lau<EMAIL_ADDRESS>wrote:

@papajohn https://github.com/papajohn Doing some spring cleaning on our
issues. Is this still something we want to do?
—
Reply to this email directly or view it on GitHub
https://github.com/dsten/datascience/issues/13#issuecomment-146427344.


fix: prefer bins of packages with names matching the bin

cc @elliottsj
it came up in this issue: https://github.com/webpack-contrib/webpack-command/pull/30
it appears that none of the node package managers provide a consistent behavior when many packages use the same names for their commands.
This change doesn't solve all the issues but when a package's command matches the package's name, it is preferred over any other packages that have the same command name. So if foo has a command called foo and bar has a command called foo then foo will be linked to foo and a warning will be printed about the conflicting command names

Thanks for this!


Fix the mac build

This test times out at 300 seconds. It takes almost exactly 300 seconds.

Jenkins, test this please


Add support for in-memory / streamed datasets?

Possible use case: Use terracotta to serve up tiles from bathymetry.

I interpret the lack of activity here that there's not really all that much demand for this. Closing.


Preserve order of properties

I have a prototype for this.  Do we just go JSON-order all the way, or do we let users choose between JSON-order and alphanumeric order?


Type error in monorepo with different Zod versions across packages

TypeScript fails to resolve the correct types in a monorepo if different Zod versions are installed.
I created a minimum reproducible repo with our setup with Zod, React Hook Form, and its resolver; see https://github.com/bkiac/typescript-error-with-monorepo-zod-react-hook-form.
Upgrading all packages to the same zod version resolves the issue.

Thanks for the good repro. In general this isn't supported, and it would be infeasible to do so in the general case. Schemas expose "internal" APIs like _parse that have type signatures that are liable to change. In this particular case I removed two methods that have been deprecated for over a year, but it resulted in incompatible type signatures. Monorepo tooling makes it easy enough to keep versions in sync these days so it's not a priority.


Update estonian

Added more Estonian.
Main focus on Tutorial.

Thank you for the update!

Thank you for the update!


GitHub Issue: EML Analyzer - Error in Date Parsing

Description:
After cloning the main branch of the EML Analyzer repository and adding the VirusTotal API key, I encountered an issue while running the Docker container. The application seems to start successfully, but when making a POST request to analyze an EML file, a 500 Internal Server Error occurs. The error trace indicates a problem in the date parsing process.
Steps to Reproduce:

Clone the main branch of the EML Analyzer repository.
Add the VirusTotal API key to the appropriate environment variable.
Run the application using docker-compose up.
Make a POST request to analyze an EML file.

Expected Behavior:
The application should successfully analyze the EML file and return the appropriate response.
Actual Behavior:
The application returns a 500 Internal Server Error, and the error trace indicates a TypeError related to date parsing.
Error Trace:
...
eml_analyzer_1  | TypeError: Cannot parse argument of type None.
...

Environment:

Operating System: Ubuntu 22.04.3
Docker Version: [Docker version 20.10.18, build b40c2f6]

Additional Information:
VirusTotal API Key has been added to the environment variables.
The issue seems to be related to date parsing in the EML file processing.
It happens with several eml and msg files, it seems unrelated to the Target.
Note:
I have verified that this issue occurs consistently in the provided environment. Any assistance in resolving this issue would be highly appreciated.

Thank you for reporting. I'd appreciate if you could provide an EML file to reproduce the issue. (Please anonymize sensitive data in it)

I will close this issue if there is no response for a week.


CLI Feature: JSON-LD to N-Quads

As a User, I want to be able to generate the canonicalized N-Quads prior to LD signing from a JSON-LD object, with or without a proof.

Closed by PR above;


Make the creation of an IAM Policy in external-dns addon optional

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

What is the outcome that you are trying to reach?
A similar issue to the one I describe in #1379, however this time it's with the external-dns addon module. The Terraform module assumes that an IAM Policy should be created, but this isn't possible in the environment I'm attempting to deploy into.
Ideally, it should be possible to disable the creation of the IAM policy and simply pass through one created by another stack/team/etc.
Describe the solution you would like
I see that the external DNS module already allows for additional IAM policies, so I think the solution would look be as follows:

Add a boolean that disables the creation of the IAM Policy by the module
Change the logic that constructs the irsa_config.irsa_iam_policies attribute that's passed to the helm_addon module.

I will be making the changes in my forked repo to progress my own work, so I'll happily raise a PR once that's complete.
Describe alternatives you have considered

Additional context

I found the best way is to use a provider alias
provider "aws" {
  alias = "route53_ANOTHER_ACCOUNT_NAME_HERE_assume_role"

  region = var.aws_region
  assume_role {
    ## if no role provided, use the account running
    role_arn = var.route53_ANOTHER_ACCOUNT_NAME_HERE_assume_role_arn != null ? var.route53_ANOTHER_ACCOUNT_NAME_HERE_assume_role_arn : var.assume_role_arn
  }
  default_tags {
    tags = local.tags
  }
}

module "eks_blueprints_kubernetes_addons_external_dns_ANOTHER_ACCOUNT_NAME_HERE" {
  count = local.external-dns["enabled"] && var.ANOTHER_ACCOUNT_NAME_HERE != null && var.route53_ANOTHER_ACCOUNT_NAME_HERE_assume_role_arn != null ? 1 : 0

  providers = {
    aws = aws.route53_ANOTHER_ACCOUNT_NAME_HERE_assume_role ## should be pre-existing `ANOTHER_ACCOUNT_NAME_HERE` AWS Account Route53 Zone
  }

  source = "git::ssh://git@github.com/aws-ia/terraform-aws-eks-blueprints.git//modules/kubernetes-addons/external-dns?ref=v4.21.0"
[...]
}

this way the module will create the IRSA role in the target account and should have all the privs it needs

@FernandoMiguel thanks, but I'm unsure whether this will help in my use case. The issue is that the module tries to create an IAM Policy in the same account I'm deploying the EKS cluster into - however, I do not have the necessary privileges for this to occur.
This is by design as the organisation requires any new Policies/Permissions go through an approval process before they can be implemented (by the team responsible for managing them). So, currently, I have to raise a ticket requesting a new IAM Policy, explaining the requirement and attaching a JSON document for the Security team to approve and create for me. I just get an ARN I can then use with my Terraform.
The external-dns module actually allows you to pass ARNs of additional policies to attach to the IRSA role, so I can use that, but I need a way to disable the module from trying to create it's own.
I hope that all makes sense!

even if you have an ARN from another account, your current role wont be able to use that , right?
you would need to allow the service account to jump accounts to assume that role, and that role to trust your SA role, either via iAM or OIDC.

@FernandoMiguel the Policy ARN wouldn't be from another AWS account.
I'm attempting to provision EKS into an AWS account for which I don't have privileges to create IAM Policies - so the execution of the external-dns module throws an exception (as did the aws-load-balancer-controller module, see #1379).
Once I have the Policy created by the security team (in the same AWS account), I should be able to pass that to the module (see PR #1381 for how I achieved this with the load balancer controller).

I recommend the folks facing the same constraint to have a look at lablabs terraform-aws-eks-external-dns


Removing Twitter integration Link

https://zapier.com/l/twitter-integration-faq

Hello @varghesejose2020,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Could you Please review this change @cwarnermm


Add a cookie notice

Add a small pop-up to ask the user if he accepts the use of cookies, and an option to see our use of them. To meet EU laws.

✅  Fixed on<PHONE_NUMBER>7a631ce939060cbb603b391330f3be


TSDoc tag excluded from IntelliSense

A TSDoc tag excluded from the IntelliSense display would be useful. If type declarations are used to generate the full API docs, there may be some things (eg very lengthy descriptions or examples) you want in the docs but not cluttering the small IntelliSense box.
I think it's nice to have @remarks in IntelliSense as a midsize extended description.
VSCode right now lists all tags, including unrecognized custom tags. So it seems to be impossible to get docs-only tags even if you defined custom tags.
/**
 * @notATag Custom tag not in standard TSDoc.
 */
export function foo(): void;

Possible tags @extended @extendedExample:
/**
 * Take over the specified world.
 *
 * @param world - The world to dominate.
 *
 * @remarks
 * Optimizes for minimum loss of life, minimum reputation harm, and maximum deviousness.
 * Leverages all available capital and human resources without remorse.
 *
 * @extended
 * The development of this procedure began with the Sumerian kings.
 * [... long history ...]
 *
 * @extendedExample
 * // Example of error handling based on the latest best practices
 * while (!retired) {
 *   try { takeOverWorld(earth) } catch (error) {
 *     if (error instanceof InsurrectionError) squashInsurrection()
 *     else if (error instanceof CoupError) decimateCoup()
 *     else if (error instanceof GlobalThermonuclearWarError) retire()
 *     [.. long example list .. ]
 *   }
 * }
 *
 * @beta
 */
export function takeOverWorld(world: World): void;

Displaying custom tags was a feature request. We show them after the important bits of intellisense that we do parse (such as types and top level descriptions) I don't think it is worth adding a setting to hide them as it's just additional information, some of which may be useful


[Feature Request] Passing dynamic configuration via the command line

I would like to see the ability to pass configuration via the command line.
Specifically, being able to run
ceedling release --defines FOO

And have it do the equivalent of
ceedling release

with the project.yml including
...
:defines:
  ...
  :release:
    ...
    - FOO
...

I love this idea!


Non-blocking DTLS implementation

The TLS implementation has been able to work in non-blocking mode for a long time. Java 9+ SSLEngine now supports non-blocking DTLS, and Bouncy Castle is beginning to lag behind.
I did see one OS project which seems to have re-implemented the BC DTLS support in an asynchronous way, but I'm not sure what its provenance is https://github.com/mobius-software-ltd/java-dtls

Apologies for the delayed response.
Due to the current code organisation (of DTLS code in particular), non-blocking mode is not at all straightforward unfortunately. I suppose the primary issue is that the DTLS code doesn't share the TLS state machine.
The linked project perhaps shows that it's possible, but also demonstrates the extensive changes needed to rewrite in terms of handlers and events.


⚠ Bofrost.lu has degraded performance

In 86add7d, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1211 ms

Resolved: Bofrost.lu performance has improved in 5c1c061 after 47 minutes.


Implement HasRawWindowHandle trait for win/mac

Implement the HasRawWindowHandle trait for Windows and macOS platforms,
to allow access to native window handles for interop.

@rjwittams are you satisfied? feel free to approve & merge if so. :)

I am happy too modulo the panics.
I think that at a minimum the other shell platforms should return the empty version and log that it is unimplemented.
This is the pattern we have for other shell features.

I could imagine this just not being implemented on those platforms, since it's defined in a trait, and if you're using a raw window handle I would expect you to be compiling or cfging to a specific platform? But curious to hear if this was a decision or an omission.

curious to hear if this was a decision or an omission.

This was discussed. I have no access to non-Windows platforms and little knowledge about them, so rather than doing a blind implementation likely to be buggy, implementations on those missing platforms is left for a future change by whoever can contribute it. I did Windows and @rjwittams did macOS.

Looks good. Could you get it up to date with master (should be a quick merge or rebase, whichever you prefer as we'll squash it anyway), as I'm not sure if the log vs tracing changes may confound Githubs 'this is ok to merge' detection...


re-login fails repeatedly

I am creating an instance of Poke::API::Client and logging in, if it fails, and I try to re-log in, it fails continuously unless I create a new instance, I would try to help further but I had no luck getting it to fail when I turn logs to debug (tried for like 15 mins)

My guess would be an instance variable and seeing that its throwing a proto fault it has to be coming from inside fetch_endpoint. I think it may be related to @endpoint. I will try to test later

Interesting, I'll have to play with this later (hard to reproduce because my logins aren't failing)

I have not had time to test this but, This commit, https://github.com/nabeelamjad/poke-api/commit/8f3caa91adb07c1e636dd9e9b71cfec4ae0bde5b, removed a line that checks if the apiurl is empty and there is also no check to see if its empty in fetch_endpoint(client.rb) so @endpoint presumably gets set to https:///rpc, because its an empty string

Yeah, I'll fix the issue with fetch_endpoint so it doesn't overwrite @endpoint to an empty string or something.

Fixed in 5099412ccb068a7262bb113011558bbb40c7a06d and pushed as a new release.

Thanks, that should fix it!


Localized item names

Are you planning to implement localized item names? For example there may be config for replacing base minecraft item names.

Nearly all item names are delivered using the Vault API for technical reasons. Consequentially, there are no plans to circumvent this. However, if Vault or Spigot themselves offer an easy way to do this, I'm game. Thanks for your interest in Quests!