netplugin on kube-nodes failed to start.

I installed the kubernetes with netplugin demo according to http://contiv.github.io/documents/gettingStarted/networking/install-k8s.html.
1 master and 2 node.
I found netplugin failed to start with logs of journalctl -u netplugin:
[root@k8node-01 ~]# systemctl status -l netplugin
● netplugin.service - Netplugin
Loaded: loaded (/etc/systemd/system/netplugin.service; static; vendor preset: disabled)
Active: failed (Result: exit-code) since 二 2016-12-13 10:07:19 UTC; 42min ago
Process: 31899 ExecStart=/usr/bin/netplugin $NETPLUGIN_ARGS (code=exited, status=1/FAILURE)
Main PID: 31899 (code=exited, status=1/FAILURE)
12月 13 10:07:17 k8node-01 netplugin[31899]: 2016/12/13 10:07:17 Extension point components: {map[consul:0x196a9c0 etcd:0x196a9c0]}
12月 13 10:07:17 k8node-01 netplugin[31899]: time="Dec 13 10:07:17.509893278" level=info msg="Using%!(EXTRA string=etcd, string=service adapter:, *url.URL=etcd://<IP_ADDRESS>:2379)"
12月 13 10:07:17 k8node-01 netplugin[31899]: time="Dec 13 10:07:17.509990126" level=info msg="Connecting to backend (0/0)"
12月 13 10:07:17 k8node-01 netplugin[31899]: time="Dec 13 10:07:17.514226007" level=error msg="Service plugin not connecting to backend client: etcd cluster is unavailable or misconfigured"
12月 13 10:07:19 k8node-01 netplugin[31899]: time="Dec 13 10:07:19.516178288" level=error msg="Failed to connect to etcd. Err: client: etcd cluster is unavailable or misconfigured"
12月 13 10:07:19 k8node-01 netplugin[31899]: time="Dec 13 10:07:19.516250759" level=error msg="Error creating client etcd to url <IP_ADDRESS>:2379. Err: client: etcd cluster is unavailable or misconfigured"
12月 13 10:07:19 k8node-01 netplugin[31899]: time="Dec 13 10:07:19.516295775" level=fatal msg="Error initializing cluster. Err: client: etcd cluster is unavailable or misconfigured"
12月 13 10:07:19 k8node-01 systemd[1]: netplugin.service: main process exited, code=exited, status=1/FAILURE
12月 13 10:07:19 k8node-01 systemd[1]: Unit netplugin.service entered failed state.
12月 13 10:07:19 k8node-01 systemd[1]: netplugin.service failed.
However I checked etcd service on 3 nodes running proprely. and net master also works properly on master node.
I have not found any strange trace.  Does anyone confronted similar situations ???

Try running the clean_restart.sh script, followed by verify_cluster.sh.

@jojimt  hello, I restart the service and found a new problem when creating pods:
FirstSeen	LastSeen	Count	From			SubobjectPath	Type		Reason		Message

55s		55s		1	{default-scheduler }			Normal		Scheduled	Successfully assigned redis-srv-2k3iv to k8node-01
51s		30s		4	{kubelet k8node-01}			Warning		FailedSync	Error syncing pod, skipping: failed to "SetupNetwork" for "redis-srv-2k3iv_default" with SetupNetworkError: "Failed to setup network for pod "redis-srv-2k3iv_default(1287c44a-c1a6-11e6-996f-5254009fbdfd)" using network plugins "cni": Contiv:Error creating EP; Err: Post http://<IP_ADDRESS>:9999/plugin/createEndpoint: dial tcp <IP_ADDRESS>:9999: getsockopt: no route to host; Skipping pod"
my cluster config:
r: Post http://<IP_ADDRESS>:9999/plugin/createEndpoint: dial tcp <IP_ADDRESS>:9999: getsockopt: no route to host{"master": [{"name": "k8master", "management_ip": "<IP_ADDRESS>", "contiv_control_if": "eth2", "contiv_control_ip": "<IP_ADDRESS>", "contiv_network_if": "eth3", "contiv_network_ip": "<IP_ADDRESS>"}],
"nodes" : [{"name": "k8node-01", "management_ip": "<IP_ADDRESS>", "contiv_control_if": "eth2", "contiv_control_ip": "<IP_ADDRESS>", "contiv_network_if": "eth3", "contiv_network_ip": "<IP_ADDRESS>", "max_pods": "40"},
{"name": "k8node-02", "management_ip": "<IP_ADDRESS>", "contiv_control_if": "eth2", "contiv_control_ip": "<IP_ADDRESS>", "contiv_network_if": "eth3", "contiv_network_ip": "<IP_ADDRESS>", "max_pods": "40"}]
}
more detailed logs are :
[root@k8node-02 ~]# systemctl status -l netplugin
● netplugin.service - Netplugin
Loaded: loaded (/etc/systemd/system/netplugin.service; static; vendor preset: disabled)
Active: active (running) since 三 2016-12-14 02:17:07 UTC; 37min ago
Main PID: 21417 (netplugin)
Memory: 3.0M
CGroup: /system.slice/netplugin.service
└─21417 /usr/bin/netplugin -vlan-if eth3 -vtep-ip <IP_ADDRESS> -ctrl-ip <IP_ADDRESS> -plugin-mode kubernetes
12月 14 02:54:49 k8node-02 netplugin[21417]: time="Dec 14 02:54:49.212549200" level=info msg="Handling "add pod" event"
12月 14 02:54:49 k8node-02 netplugin[21417]: time="Dec 14 02:54:49.268787108" level=info msg="labels is bevco/bevco-net1/sugardb for pod redis-srv-rxtfr\n"
12月 14 02:54:49 k8node-02 netplugin[21417]: time="Dec 14 02:54:49.276431749" level=info msg="Making REST request to url: http://<IP_ADDRESS>:9999/plugin/createEndpoint"
12月 14 02:54:49 k8node-02 netplugin[21417]: time="Dec 14 02:54:49.290180000" level=error msg="Error during http POST. Err: Post http://<IP_ADDRESS>:9999/plugin/createEndpoint: dial tcp <IP_ADDRESS>:9999: getsockopt: no route to host"
12月 14 02:54:49 k8node-02 netplugin[21417]: time="Dec 14 02:54:49.290245461" level=error msg="Error making POST request: Err: Post http://<IP_ADDRESS>:9999/plugin/createEndpoint: dial tcp <IP_ADDRESS>:9999: getsockopt: no route to host"
12月 14 02:54:49 k8node-02 netplugin[21417]: time="Dec 14 02:54:49.298203571" level=info msg="Making REST request to url: http://<IP_ADDRESS>:9999/plugin/deleteEndpoint"
12月 14 02:54:49 k8node-02 netplugin[21417]: time="Dec 14 02:54:49.299826761" level=error msg="Error during http POST. Err: Post http://<IP_ADDRESS>:9999/plugin/deleteEndpoint: dial tcp <IP_ADDRESS>:9999: getsockopt: no route to host"
12月 14 02:54:49 k8node-02 netplugin[21417]: time="Dec 14 02:54:49.299973749" level=error msg="Error making POST request: Err: Post http://<IP_ADDRESS>:9999/plugin/deleteEndpoint: dial tcp <IP_ADDRESS>:9999: getsockopt: no route to host"
12月 14 02:54:49 k8node-02 netplugin[21417]: time="Dec 14 02:54:49.300017474" level=error msg="Error creating ep. Err: Post http://<IP_ADDRESS>:9999/plugin/createEndpoint: dial tcp <IP_ADDRESS>:9999: getsockopt: no route to host"
12月 14 02:54:49 k8node-02 netplugin[21417]: time="Dec 14 02:54:49.300057198" level=error msg="Handler for POST /ContivCNI.AddPod returned error: Post http://<IP_ADDRESS>:9999/plugin/createEndpoint: dial tcp <IP_ADDRESS>:9999: getsockopt: no route to host"
do you have any idea of this error. I run verify_cluster.sh  This error is ignored.

@jojimt  I think the problem is about firewalld.

yes, that is correct. You need to open the port on the firewall or disable firewall.

@jojimt  hello, I have a new problem:  " 100: Key not found ",  the default pods in kube-system are setup correctly. However, when I create other pods, contiv cannot setup the network config due to the following logs:
it seems the same issue of https://github.com/contiv/netplugin/issues/291.
Events:
FirstSeen	LastSeen	Count	From			SubobjectPath	Type		Reason		Message

29s		29s		1	{default-scheduler }			Normal		Scheduled	Successfully assigned bbox-client-ej3q1 to k8node-02
27s		27s		1	{kubelet k8node-02}			Warning		FailedSync	Error syncing pod, skipping: failed to "SetupNetwork" for "bbox-client-ej3q1_kube-system" with SetupNetworkError: "Failed to setup network for pod "bbox-client-ej3q1_kube-system(c3350c1c-c1be-11e6-81d1-5254009fbdfd)" using network plugins "cni": Contiv:Error creating EP; Err: 100: Key not found (/contiv.io/state/nets/bevco-net1.bevco) [12328]\n; Skipping pod"
24s	24s	1	{kubelet k8node-02}		Warning	FailedSync	Error syncing pod, skipping: failed to "SetupNetwork" for "bbox-client-ej3q1_kube-system" with SetupNetworkError: "Failed to setup network for pod "bbox-client-ej3q1_kube-system(c3350c1c-c1be-11e6-81d1-5254009fbdfd)" using network plugins "cni": Contiv:Error creating EP; Err: 100: Key not found (/contiv.io/state/nets/bevco-net1.bevco) [12338]\n; Skipping pod"
20s	20s	1	{kubelet k8node-02}		Warning	FailedSync	Error syncing pod, skipping: failed to "SetupNetwork" for "bbox-client-ej3q1_kube-system" with SetupNetworkError: "Failed to setup network for pod "bbox-client-ej3q1_kube-system(c3350c1c-c1be-11e6-81d1-5254009fbdfd)" using network plugins "cni": Contiv:Error creating EP; Err: 100: Key not found (/contiv.io/state/nets/bevco-net1.bevco) [12352]\n; Skipping pod"

I think you may not have create the tenant and network you're specifying in the podspec.

@jojimt Thank you for your notice solved this problem.
However I found pods on different nodes are not reachable. I saw you direct arp packets to controller:65535.
I did n't see sdn controller installation in the script. should I install a sdn controller by myself for connecting pods on different nodes, like Ryu ？
By the way, do you know the openvswitch parse error below？ it's a bug or version compatibility pb...
Thank you.
[root@k8node-02 ~]# ovs-ofctl dump-flows contivVlanBridge
2016-12-15T06:53:39Z|00001|ofp_actions|WARN|invalid instruction ordering: apply_actions must appear before write_metadata, for OpenFlow 1.1+ compatibility
2016-12-15T06:53:39Z|00002|ofp_util|WARN|OFPST_FLOW reply bad instructions
NXST_FLOW reply (xid=0x4):
cookie=0x16, duration=3320.405s, table=0, n_packets=17, n_bytes=1108, idle_age=461, priority=100,arp,arp_op=1 actions=CONTROLLER:65535
cookie=0x14, duration=3320.405s, table=0, n_packets=5138, n_bytes=409540, idle_age=0, priority=1 actions=resubmit(,1)
cookie=0x18, duration=3318.609s, table=1, n_packets=5111, n_bytes=407357, idle_age=0, priority=100,in_port=1 actions=resubmit(,5) parse error

@jojimt  Or, I am wondering should we add the default (Normal probably) flows for each bridge by default.
And I have a question:   does the notion "tenant" in netplugin corresponds to namespace in k8s?  because In k8s， some namespaces should be connected while other namespaces may need to be isolated depending detail use cases.
In my expectation, I hope we can map different networks in netplugin for namespaces in k8s according to our needs.
and For k8s use cases, usually we need a namespace, where all pods can be bidirectly reachable from all other namespaces. could we define  some special flows (like vlan, (vxlan )transition) to make a common network for this namespace in k8s. Instead of traversing of an external  router...

@jojimt Would you please have a look for my question?

Contiv tenant is not tied to k8s namespace. It is completely flexible in that you have the option of placing all the pods in your cluster in the same tenant, same network or net-group. This assignment is performed using io.contiv.tenant, io.contiv.network and io.contiv.net-group labels. See https://github.com/contiv/netplugin/tree/master/mgmtfn/k8splugin for some examples. By default, everything is reachable. You can manage which pods are reachable by applying policy.

Thank you for your response.
@jojimt @erikh @philips
I would like to know how contiv populate the fdb on each host. You use the etcd watch mechanism for synchronizing each host's fdb or use the ofnet agent package, which, to me, looks a little like the l2 pop mechanism in Neutron...
I read a little code, It seems to me you use the second method. The advantages and disadvantages for the first method. we store pods' network info in etcd cluster, and the fdb on each host has an agent for synchronizing ？

and what is the purpose of BGP part in drivers/ovsdb.go  ovsSwitch.go file ?  personally, I found the code a little disordering...

Closing based on: @jojimt Thank you for your notice solved this problem.


README.md UI broken - Repository

We have a broken img tag in README.md for this repository. The possible cause is missing alt attribute in the tag.
See Section Screenshots.

Thanks for reporting and suggesting the fix!


proposal: net/http/httputil: ReverseProxy add a API to get the length of proxy had sent data

demo code:
revProxy := httputil.NewSingleHostReverseProxy(url)
  modifyFunc := func(res *http.Response) error {
		body, err := io.ReadAll(res.Body)
		res.Body = io.NopCloser(bytes.NewReader(body))
		if err != nil {
			return err
		}
		count := len(body)
		return nil
	}
	revProxy.ModifyResponse = modifyFunc

goal：get the length of proxy had sent data, it is successful, but it is block when response is live streaming, because io.ReadAll() can not read EOF or error from streaming。The stream has always existed and has no end。
Design:
type ReverseProxy struct {
    SendBodySize atomic.Int64
}

// copyBuffer returns any write errors or non-EOF read errors, and the amount
// of bytes written.
func (p *ReverseProxy) copyBuffer(dst io.Writer, src io.Reader, buf []byte) (int64, error) {
	if len(buf) == 0 {
		buf = make([]byte, 32*1024)
	}
	var written int64
	for {
		nr, rerr := src.Read(buf)
		if rerr != nil && rerr != io.EOF && rerr != context.Canceled {
			p.logf("httputil: ReverseProxy read error during body copy: %v", rerr)
		}
		if nr > 0 {
			nw, werr := dst.Write(buf[:nr])
			if nw > 0 {
				written += int64(nw)
                                 p.SendBodySize.Add(int64(nw))  // add code
			}
			if werr != nil {
				return written, werr
			}
			if nr != nw {
				return written, io.ErrShortWrite
			}
		}
		if rerr != nil {
			if rerr == io.EOF {
				rerr = nil
			}
			return written, rerr
		}
	}
}

func (p *ReverseProxy) ResetSendSize() {
    p.SendBodySize.Store(0)
}

This functionality looks orthogonal to the purpose of ReverseProxy (you could just as easily wrap it in middleware that will do the tracking for you, eg https://pkg.go.dev/github.com/felixge/httpsnoop).
Additionally, a per-proxy count doesn't appear to be very useful, most people seem to want a per handler count.

CC @neild @bradfitz

This functionality looks orthogonal to the purpose of ReverseProxy (you could just as easily wrap it in middleware that will do the tracking for you, eg https://pkg.go.dev/github.com/felixge/httpsnoop). Additionally, a per-proxy count doesn't appear to be very useful, most people seem to want a per handler count.

thanks for your response. felixge/httpsnoop package：
// myH is your app's http handler, perhaps a http.ServeMux or similar.
var myH http.Handler
// wrappedH wraps myH in order to log every request.
wrappedH := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
	m := httpsnoop.CaptureMetrics(myH, w, r)   // This line is block, when header contains "Transfer-Encoding: chunked"
	log.Printf(
		"%s %s (code=%d dt=%s written=%d)",
		r.Method,
		r.URL,
		m.Code,
		m.Duration,
		m.Written,
	)
})
http.ListenAndServe(":8080", wrappedH)

It does not work, when ReverseProxy is used for proxying live streaming by http-flv format and backend http server response  data by chunk mode, in other words, Transfer-Encoding: chunked. The header and response of backend http server can not be changed.
Unfortunately, CaptureMetrics() does not return any statistics until the live stream is closed. Obviously, felixge/httpsnoop package is ineffective for live stream proxy. I need a golang packet with real-time statistics of forwarding traffic.
Do you have other solutions?
Thanks.

As @seankhliao says, this seems orthogonal to ReverseProxy. You could as easily want to track bytes sent by some other handler.
You should be able to build this with a middleware handler that wraps the http.ResponseWriter. Something like:
type CountingResponseWriter struct {
  http.ResponseWriter
  Count int
}

func (c *CountingResponseWriter) Write(p []byte) (n int, err error) {
  n, err = c.ResponseWriter.Write(p)
  c.Count += n // apply locking as needed
  return n, err
}

func (c *CountingResponseWriter) Unwrap() http.ResponseWriter { return c.ResponseWriter }


SocketIoClientDotNet Not support SelfSigned certificate

SocketIoDotNet fails to connect  if we use selfsigned certificate.

This is the same behaviour as in the javascript version 1.1.


Fix Contiv addon link.

Rollback https://github.com/kubernetes/website/pull/31760 and provide the correct link rather than deleting the entry.
If we'd prefer to leave it deleted, I can update the translations that way instead.

Hmm, this is a bit of a mess, since some of the localizations have removed contiv but not all. Please let me know what you'd like to do here.

/lgtm
We always prefer to have localizations pull changes from upstream; direct changes to localizations aren't supposed to be a thing.
Linking to Contiv VPP seems OK.

/approve


initialized class variables in base class constructor are null

TypeScript Version:  2.3.2
CODE
interface IMember {
      name?: string
    }

    interface IBase {
      member1?: IMember
    }

    class Base implements IBase {
      public get member1() {
        return this._member1
      }
      public _member1: IMember
      public constructor() {
        console.log('parent constructor this')
        console.log(this)
        console.log('parent constructor _member1')
        const a = this._member1;
        console.log(a)
        expect(a).to.not.be.undefined
      }
    }

    class Child extends Base {
      public _member1: IMember = {
        name: 'grrrr'
      }
    }

    const o = new Child()

Expected Behavior:
I initialize a member variable in the Child class during class declaration.
I expect in the parent class constructor the class variable to be initialized.
Actual behavior:
It is not.
However, it is initialized after the object is constructed.

Duplicate of https://github.com/Microsoft/TypeScript/issues/1617

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


view_figure argument not working in fitting() function

When calling hf.fitting() the view_figure argument is not working. Either bool, True or False, displays the figure. I am trying to use this package in a Dash app and just need the x_fit, y_fit, and ec50 values for plotting a Plotly line chart.

Hello @timbo112711, thank you for your inquiry.
Hi @freiburgermsu, can you please check this?

Hello @timbo112711 !
Some IDEs automatically render figures, despite when the figures are not explicitly called. Try setting generate_figure=False, which will prevent the figure from ever being created yet will still yield the contents that you desire.
The forthcoming updates have some additional functionality to help your workflow.
Andrew

Hi @timbo112711,
We have updated master branch to try to resolve this issue.
To try this out, please install hillfit via:
$ pip install git+https://github.com/himoto/hillfit

Please do let me know if this works.

Hi @freiburgermsu !!
That arg worked like a charm. Can't believe I overlooked that one.
@himoto , Will do thanks!


Add my e2e-run and zsh completion scripts

And document it with screencast, help and long description at the top of the file.
demo:
https://user-images.githubusercontent.com/98980/207322663-5278c29e-547f-4b1b-b14e-1af79abc35e0.mov
Signed-off-by: Chmouel Boudjnah<EMAIL_ADDRESS>
Changes

Submitter Checklist

[ ] ♽  Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
[ ] 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
[ ] 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
[ ] 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
[ ] 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

Codecov Report

Merging #1077 (1c778cd) into main (7c9b164) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1077      +/-   ##
==========================================
- Coverage   63.14%   63.13%   -0.02%
==========================================
  Files         103      103
  Lines        6274     6268       -6
==========================================
- Hits         3962     3957       -5
- Misses       1929     1930       +1
+ Partials      383      381       -2

Impacted Files
Coverage Δ

pkg/cmd/tknpac/completion/completion.go
0.00% <0.00%> (ø)

pkg/kubeinteraction/cleanups.go
71.42% <0.00%> (+6.21%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add support for replicas option when deploying MIAA

Closes https://github.com/microsoft/azuredatastudio/issues/14733
Description text taken from azdata CLI

Pull Request Test Coverage Report for Build 659067825

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 43.341%

Totals

Change from base Build 658610170:
0.0%

Covered Lines:
25400

Relevant Lines:
53472

💛  - Coveralls


Windows tool_integration_tests_1_6 flakes on android_plugin_example_app_build_test

(part of https://github.com/flutter/flutter/issues/97036)
Hit one flake today:

[ ] android_plugin_example_app_build_test.dart

12:30 +22 ~2 -1: test\integration.shard\android_plugin_example_app_build_test.dart: FFI plugin example can be built using current Flutter Gradle plugin [E]
  Expected: a file system entity that exists
    Actual: LocalFile:<LocalFile: 'C:\b\s\w\ir\x\t\flutter_flutter_ffi_plugin_test.aae6b239\plugin_ffi_test\example\build\app\outputs\flutter-apk\app-release.apk'>
     Which: does not exist

  package:test_api                                                          expect
  test\integration.shard\android_plugin_example_app_build_test.dart 79:5    main.testPlugin
  test\integration.shard\android_plugin_example_app_build_test.dart 26:26   main.testPlugin
  test\integration.shard\android_plugin_example_app_build_test.dart 131:11  main.<fn>
  test\integration.shard\android_plugin_example_app_build_test.dart 130:7   main.<fn>
  test\src\common.dart 166:18                                               test.<fn>
  test\src\common.dart 161:5                                                test.<fn>

/cc @zanderso

Routing to @dcharkes who added the test a couple weeks back. My suggestion for debugging the flake would be to land more debugging output from the testPlugin plugin method in that file. In particular, if a call to processManager.runSync() fails, it should print the exit code, stdout, and stderr from the subprocess.

This is still happening: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows tool_integration_tests_1_6/784/overview

@dcharkes ptal.

This issue happened twice in the past two days:
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows tool_integration_tests_1_6/2256/overview

@keyonghan both of those failures seem to be saying that the NDK on the bot is malformed. In one case the zip archive failed to be extracted correctly, and in the other, it was missing a file.

@keyonghan both of those failures seem to be saying that the NDK on the bot is malformed. In one case the zip archive failed to be extracted correctly, and in the other, it was missing a file.

Thanks @zanderso for the triage.
It is indeed with the bot. Both failures happened on https://chromium-swarm.appspot.com/bot?id=flutter-prod-windows-us-central1-a-11-fv9g, which seemed have caused tests failure across other tests.
I clicked STOP THE BOT GRACEFULLY, and this bot should not be assigned to any tasks for today. Additionally, all bots will be auto re-provisioned tomorrow
On top of that, the original filed flaky issue is not reproducing.
I will monitor this bot issue a bit before closing.

Closing as this didn't repro.

I'm seeing this in a try bot: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8765048998182417073/+/u/run_test.dart_for_tool_integration_tests_shard_and_subshard_1_6/test_stdout

AGP downloads the NDK (the version it wants) on demand, so maybe some bits fell over on the network? I'm not really sure what to do about this.
(Side note: With the native assets, --template=package_ffi instead of --template=plugin_ffi, flutter_tools controls what NDK it uses for native builds: The one inside the Android SDK detected by flutter doctor. For our bots that means using the NDK from the CIPD package. So hopefully the new way of doing things will not have these kind of install-via-the-network flakes.)


added implementation for brqi

Added implementation for Bitplane Representation of Quantum Images (BRQI)  #131

The implementation of BRQI is present within the embeddings/image_embeddings/brqi.py file.
Added test cases for the BRQI Module in the tests/embeddings/image_embeddings/test_brqi.py file
Added a demo on how to use this module in demos/brqi_demo.py along with a step by step explanation present in the demos/brqi.md file.

Hi @Dljdd,
Thanks for the work. I will get back to you with reviews asap!

Additionally, is it possible to limit this PR to adding the brqi.py and 'test_brqi.py` files only? I would suggest making another PR for adding the demos otherwise this seems like a huge PR for me to review and accept. Let me know if you would need any help in removing those files.

Alright, I'll do that and make another pr for the rest of the files.


Fix chat name color being initially green upon server restart

Actual Behavior
The first time a player chats on the server after it gets restarted their name will show up as green, but then it uses the designated chat name color.
Expected Behavior
Chat name colors should be used the first time a player chats on the server after a server restart and every time after.

This may be resolved by taking Ren's suggestions into account: https://github.com/RP-Kit/RPKit/pull/662


fix(region): create wire input bw deprecated

What this PR does / why we need it:
Fix below issue:
$ climc wire-create my-zone-1 my-wire-1 10000
{"error":{"class":"InputParameterError","code":400,"details":"bandwidth: missing input field","request":{"body":{"wire":{"bw":10000,"mtu":0,"name":"my-wire-1","vpc":"default","zone":"my-zone-1"}},"headers":{"Content-Length":"83","Content-Type":"application/json","User-Agent":"yunioncloud-go/201708","X-Auth-Token":"*"},"method":"POST","url":"https://<IP_ADDRESS>:30888/wires"}}}

Does this PR need to be backport to the previous release branch?:

release/3.8
/area region

/cc @swordqiu @ioito

/lgtm


Release 8.0.0

Updated to .NET 8
Updated nearly all dependencies
Improved build script (build samples, fail on vulns, ...)
Removed some obsolete vulnerability fix dependencies
Fixed missing dependency in AppConfigDemo sample

If we're dropping support for .NET 6 and 7 (or you have to fallback to .NET Standard), then at some point we should probably drop .NET Framework 4.6.2 and just keep .NET Framework 4.7.2. If you're maintaining your .NET Framework apps then you should be using 4.8.


TypeScript compaibility plugin issues with inline fragments since 1.1.1

Describe the bug
since typescript compatibility 1.1.1 we have the following issue. with 1.1.0 it works fine.
→ Cannot read property 'type' of undefined**
[17:24:49] Parse configuration [started]
[17:24:49] Parse configuration [completed]
[17:24:49] Generate outputs [started]
[17:24:49] Generate ./Scripts/shared/api/api.ts [started]
[17:24:49] Generate ./Scripts/shared/fragmentTypes.json [started]
[17:24:49] Load GraphQL schemas [started]
[17:24:49] Load GraphQL schemas [started]
[17:24:49] Load GraphQL schemas [completed]
[17:24:49] Load GraphQL schemas [completed]
[17:24:49] Load GraphQL documents [started]
[17:24:49] Load GraphQL documents [started]
[17:24:49] Load GraphQL documents [completed]
[17:24:49] Load GraphQL documents [completed]
[17:24:49] Generate [started]
[17:24:49] Generate [started]
[17:24:50] Generate [failed]
[17:24:50] → Cannot read property 'type' of undefined**
[17:24:50] Generate ./Scripts/shared/api/api.ts [failed]
[17:24:50] → Cannot read property 'type' of undefined**
[17:24:50] Generate [completed]
[17:24:50] Generate ./Scripts/shared/fragmentTypes.json [completed]
[17:24:50] Generate outputs [failed]

To Reproduce
Steps to reproduce the behavior:
graphql-codegen --config codegen.js
schema.txt

My GraphQL operations:

query fetchServerAnalyticsData($uid: String!) {
  process {
    servers(where: { uid: $uid }) {
      uid
      sources
      active
      principalName
      systemClass
      systemType
      getHostVirtualMachines {
        id
        uid
        host
        displayName
        storage
        sources
        vmType
        active
        vCenterName
        vmVersion
        dataCenterName
        collector
        monitoringGroup
      }
      imacs {
        ... on ServerChangeImac {
          __typename
          requestedAt
          mutatedBy
          mutationContext
          ticketNumber
          note
          active
          cIState
          customer
          patchWindow
          primaryOwner
          region
          systemClass
          businessModules
          description
          isVisibleToCustomer
          isManagedByGIA
          infrastructure
          serviceWindowPft
          serviceWindowApp
          comment
          investmentNumbers
          contractNumbers
          assetNumbers
          assignedServices
        }
        ... on ServerDecomImac {
          requestedAt
          ticketNumber
          mutatedBy
          mutationContext
          note
          __typename
        }
        ... on ServerSetupImac {
          mutatedBy
          mutationContext
          requestedAt
          ticketNumber
          note
          imacId
          archId
          currentState
          __typename
          backupPolicy
          explanation
          region
          description
          platformDistributionComment
          platformInstallComment
          satComment
          networkComment
          platformConfigComment
          serverType
          networkVlan
          hostname
          ip
          subnetMask
          defaultGateway
          vlan
          vlanId
          domain
          primaryDns
          secondaryDns
          computeCluster
          storageSystem
          passwordSaved
          customer
          patchWindow
          businessModules
          primaryOwner
          secondaryOwner
          requestedBy
          scomUser
          sccmUser
          scepUser
          scsmUser
          visionAppUser
          backupUser
          serverSize {
            name
            cpu
            memory
            disk
          }
          sla {
            application
            platform
          }
          systemClass
        }
      }
    }
  }
}

My codegen.js config file:

process.env.VERBOSE = true;
process.env.DEBUG = true;

module.exports = {
  schema: "intro.json",
  documents: ["Scripts/**/*.graphql"],
  config: {
    strict: true,
    namingConvention: {
      default: "change-case#pascalCase",
      enumValues: "change-case#upperCase"
    }
  },
  overwrite: true,
  generates: {
    "./Scripts/shared/api/api.ts": {
      config: {
        resolvers: false
      },
      plugins: ["typescript", "typescript-operations", "typescript-compatibility"]
    },
    "./Scripts/shared/fragmentTypes.json": {
      plugins: ["fragment-matcher"]
    }
  }
};

Expected behavior
no error while building and a api.ts file
Environment:

OS:
@graphql-codegen/...: 1.1.1
NodeJS: v10.13.0

Additional context
excluding the grapqhl documents creates the api. it looks like the issue is in combination with the inline fragments.

Hi @OneCyrus , sorry for the delay. Fixed in https://github.com/dotansimha/graphql-code-generator/pull/1798

@OneCyrus Can you please try 1.1.2-alpha-76e69629.19?

it works again. thank you!

ok. didn't fix it completely as we have some type issues now. it looks like the different fragments get assigned to the same types.
ERROR in ./Scripts/shared/api/api.ts(13166,7):
TS2344: Type '"region" | "active" | "description" | "customer" | "systemClass" | "assetNumbers" | "assignedServices" | "businessModules" | "comment" | "contractNumbers" | "infrastructure" | ... 13 more ... | "__typename"' does not satisfy the constraint '"requestedAt" | "mutatedBy" | "mutationContext" | "ticketNumber" | "note" | "__typename"'.
  Type '"region"' is not assignable to type '"requestedAt" | "mutatedBy" | "mutationContext" | "ticketNumber" | "note" | "__typename"'.
ERROR in ./Scripts/shared/api/api.ts(13223,7):
TS2344: Type '"region" | "description" | "customer" | "domain" | "systemClass" | "backupPolicy" | "businessModules" | "patchWindow" | "requestedAt" | "mutatedBy" | "mutationContext" | "ticketNumber" | ... 34 more ... | "__typename"' does not satisfy the constraint '"requestedAt" | "mutatedBy" | "mutationContext" | "ticketNumber" | "note" | "__typename"'.
  Type '"region"' is not assignable to type '"requestedAt" | "mutatedBy" | "mutationContext" | "ticketNumber" | "note" | "__typename"'.
ERROR in ./Scripts/shared/api/api.ts(13282,9):
TS2344: Type '"region" | "description" | "customer" | "domain" | "systemClass" | "backupPolicy" | "businessModules" | "patchWindow" | "requestedAt" | "mutatedBy" | "mutationContext" | "ticketNumber" | ... 34 more ... | "__typename"' does not satisfy the constraint '"requestedAt" | "mutatedBy" | "mutationContext" | "ticketNumber" | "note" | "__typename"'.
  Type '"region"' is not assignable to type '"requestedAt" | "mutatedBy" | "mutationContext" | "ticketNumber" | "note" | "__typename"'.
ERROR in ./Scripts/shared/api/api.ts(13342,9):
TS2344: Type '"region" | "description" | "customer" | "domain" | "systemClass" | "backupPolicy" | "businessModules" | "patchWindow" | "requestedAt" | "mutatedBy" | "mutationContext" | "ticketNumber" | ... 34 more ... | "__typename"' does not satisfy the constraint '"requestedAt" | "mutatedBy" | "mutationContext" | "ticketNumber" | "note" | "__typename"'.
  Type '"region"' is not assignable to type '"requestedAt" | "mutatedBy" | "mutationContext" | "ticketNumber" | "note" | "__typename"'

@OneCyrus I fixed another issue related to fragments, can you please try 1.1.2-alpha-6668a794.20?

we get closer but there are still two issues.
ERROR in ./Scripts/shared/api/api.ts(13208,8):
TS2339: Property 'serverSize' does not exist on type '({ __typename: "ServerChangeImac"; } & Pick<ServerChangeImac, "region" | "active" | "description" | "customer" | "systemClass" | "assetNumbers" | "assignedServices" | "businessModules" | ... 15 more ... | "primaryOwner">) | ({ ...; } & Pick<...>) | ({ ...; } & ... 1 more ... & { ...; })'.
ERROR in ./Scripts/shared/api/api.ts(13223,8):
TS2339: Property 'sla' does not exist on type '({ __typename: "ServerChangeImac"; } & Pick<ServerChangeImac, "region" | "active" | "description" | "customer" | "systemClass" | "assetNumbers" | "assignedServices" | "businessModules" | ... 15 more ... | "primaryOwner">) | ({ ...; } & Pick<...>) | ({ ...; } & ... 1 more ... & { ...; })'.

here's the generated ts-file:
api.txt

Thank you @OneCyrus , that's very helpful!
I think I managed to fix this issue, can you please try 1.1.2-alpha-f498f076.22?

@OneCyrus Can you please try 1.1.2-alpha-e801e53f.23?

it looks like that did the trick. thank you!

Awesome! Thank you for testing it, @OneCyrus !
I'm keeping it open to make it easier to track what should be included in the next version changelog.

Fixed in 1.1.3 🎉


M2 Encoder why not mentioned input resolution anywhere?a

M2 Encoder why not mentioned input resolution anywhere?a

The input resolution is 224*224, for more details please refer to our paper in Table 10:  https://arxiv.org/pdf/2401.15896v2.pdf


⚠ Bofrost.de has degraded performance

In b87a542, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 764 ms

Resolved: Bofrost.de performance has improved in 28e0bbf.


Hardware Menu Ctrl+C Improvements

Needs to shutoff tool if active
Needs to set back to relative positioning mode.

Completed

Completed


Some inconsistencies in classDB's bindings

Hi,
I'm currently using classDB introspection system to generate bindings for godot-python.
I've found some troubles in the bindings:

audio_server.cpp: AudioServer.set_state and AudioServer.generate_state are mark to return a AudioServerState, but there is no reference of this type anywhere
core_bind.cpp: _Marshalls::base64_to_raw is marked to return a RawArray which is an out-of-date alias to PoolByteArray (i.e. PoolVector<uint8_t>)
visual_script: VisualScriptPropertySet properties' names start with property/..., this is a pretty strange name given slash is not a valid variable character for most languages (including C++ and GDscript) so doing VisualScriptPropertySet.property/set_mode is impossible...
control.cpp: Control.get_minimum_size is binded two times (has a virtual and a regular method)
packet_peer.cpp: PacketPeer.put_packet is declared has returning an Error type which is never defined within classdb

I'm ready to send a PR to solve this (seems all minor issues to me, but some for them like the property/... stuff is more like something I didn't catch...)

@touilleMan Error is an enum that's used almost everywhere and even core types use it (they just say it's an int). I just made Error a core type so my bindings don't try to include a file for it.

@touilleMan Also you forgot PoolFloatArray

@touilleMan I agree that the property naming situation isn't perfect, but you're not forced to use the property name as the property name (that sounds confusing). You could have your bindings transform the name so it's valid. (Just for as long the names are rubbish for most languages)

@karroffel you're right about this, however I thought it was worth mentioning given it's part of the papercuts I got working on the subject (i.e. if the API stays this way, I have to do a workaround for this case - for example using custom name as you said -)

@touilleMan I fixed the ClassDB issues. I think the property names deserve an issue on their own. GDScript encourages the use of properties over getter and setter functions. This is problematic because you can't use many properties that way. So GDScript has the same problems


Gourmaryllis not automatically linking to mana spreader

Sometimes the Botania flowers wont link to the mana spreaders, thus not allowing you to get mana. An easy fix is using the wand to link them together.
Version: 1.152.1

I think that's intended behavior by botania but we can workaround it with script

 kikis2111 on Discord says

Does this really need a script? Using a wand to connect them is intended behaviour

 .eweer on Discord says

And in case you need to connect a bunch of them (or want to automate), Floral Obedience Stick exists

 yarden.zamir on Discord says

It is intended, but I think that if you right click a flower on a mana spreader or similar we could add a qol improvment that connects them


OpenAI completions model not using OpenAI Completion API properly to extract LogProbs

The get_results method in the lm_eval/models/openai_completions.py is not properly using the OpenAI Completion API.
Below is the API definition for LogProbs (from openai):
class Logprobs(BaseModel):
    text_offset: Optional[List[int]] = None

    token_logprobs: Optional[List[float]] = None

    tokens: Optional[List[str]] = None

    top_logprobs: Optional[List[Dict[str, float]]] = None

However, get_results in that module is defined this way:
def get_result(response) -> Tuple[float, bool]:
    is_greedy = True
    logprobs = response.logprobs.token_logprobs
    continuation_logprobs = sum(logprobs)

    for i in range(len(response.logprobs.token_logprobs)):
        token = response.logprobs.token_logprobs[i]
        top_tokens = response.logprobs.top_logprobs[i]
        top_token = max(top_tokens.keys(), key=lambda x: top_tokens[x])
        if top_token != token:
            is_greedy = False
            break

    return continuation_logprobs, is_greedy

It appears the method assumes response.logprobs.token_logprobs is both a list of log probabilities (it sets the continuation_logprobs variable to the sum of its values) and a token since it sets values in the list to a variable named token.
Per the OpenAI type hints, it should be a list of floats and the corresponding token can be determined by extracting it from response.logprobs.tokens (a list of strings) at the same index as each item in response.logprobs.token_logprobs.

Is this solved at https://github.com/EleutherAI/lm-evaluation-harness/pull/1919 or is it some other issue?

Is this solved at #1919 or is it some other issue?

It is a different issue.


A (probably easier) alternative installation for CUDA 11

Hi Chen! Thanks a lot for your excellent work and its open-sourced code!
I am recently trying out different environment builds on a CUDA 11 machine. I found out an installation that worked for me, looks similar to your claimed environment (python 3.8 + torch 1.8), bug-free during installation, and require no source-code compiling.
A major issue with the previous version is that mmdet3d, mmdet, mmcv and mmsegmentation just released a whole bunch of incompatible version so that pip install XXX.git will not work as intended (latest incompatible version is installed).
My installation reads as follows:
conda create -n open-mmlab python=3.8 -y
conda activate open-mmlab
conda install pytorch=1.8 torchvision=0.9.0 cudatoolkit=11.1 -c pytorch -c nvidia
pip install mmcv-full==1.4.5 -f https://download.openmmlab.com/mmcv/dist/cu111/torch160/index.html --no-cache-dir
pip install mmdet==2.22.0 mmsegmentation==0.20.0
wget https://github.com/open-mmlab/mmdetection3d/archive/refs/tags/v0.18.0.tar.gz
tar -xvf v0.18.0.tar.gz
cd mmdetection3d
pip install -v -e .
pip install git+https://github.com/klintan/pypcd.git
pip install timm

Thanks for your interest in our work!
Yes, as we state in the ReadMe.md, we use mmcv-full==1.4.5 and mmdet==2.22.0 for the project. It seems that you can use "pip install mmcv-full==1.4.5 -f https://download.openmmlab.com/mmcv/dist/cu111/torch1.8.0/index.html --no-cache-dir" to directly download the whl and install mmcv-full. If you provide a wrong link (for example "torch160" in the original link), pip will download mmcv-full and build it from source, which costs a lot of time.

Thanks for your interest in our work!
Yes, as we state in the ReadMe.md, we use mmcv-full==1.4.5 and mmdet==2.22.0 for the project. It seems that you can use "pip install mmcv-full==1.4.5 -f https://download.openmmlab.com/mmcv/dist/cu111/torch1.8.0/index.html --no-cache-dir" to directly download the whl and install mmcv-full. If you provide a wrong link (for example "torch160" in the original link), pip will download mmcv-full and build it from source, which costs a lot of time.

Oh, thanks! This was my typo. I will edit the original issue in case anyone get misled.


[v1.1.6] no timeskip to 5 seconds option?

There is no option to change the timeskip forwards/backwards from 10 seconds to 5 seconds, pls help

Not an issue with DontEatMyContent


Why does jquery.inputmask.js refer to the jQuery module as "jQuery", not "jquery"?

Line 9 of jquery.inputmask.js refers to the jquery module as "jQuery", not as it's usual module name, "jquery". Is this a bug, or is there a specific reason for this?
The reason I ask is I'm getting incorrect behavior where requireJS is trying to import /base_path/jQuery.js instead of /correct/path/jquery.js, so it's not recognizing the module "jQuery" as it's defined in my require.config().

@jonesnc ,
Fixed.  That was a typo (bug)


Can't able to open site

hey @sidmish , i've noticed this too and pinged @gustavz ! we had a lot of demand :D

Rebooting it now. The issue is that streamlit community cloud is not really built for multi users.

@gustavz  Thanks for this project. Do you know how to solve this problem?
Traceback (most recent call last):
File "app.py", line 104, in
if not st.session_state["auth_ok"]:
KeyError: 'st.session_state has no key "auth_ok". Did you forget to initialize it? More info: https://docs.streamlit.io/library/advanced-features/session-state#initialization'

@mczhuge hm weird, I don't know how you were able to run into this error as auth_ok is initialised here:
https://github.com/gustavz/DataChad/blob/3dfff5a41d678233e6a8f21a1ee7165f27626f99/app.py#L54-L56

@gustavz I solve this. But when I upload the file, it shows:

What kind of file? Name type and suffix please.

sample.jpeg
But I think this is from some other problems,
Dataset 'hub://${ACTIVELOOP_ORG_NAME}/https-github-com-gustavz-DataChad-git-1000' does not exist -> uploading
Failed to build chain for data source 'https://github.com/gustavz/DataChad.git' with error: A dataset does not exist at the specified path, or you do not have sufficient permissions to load or create one. Please check the dataset path and make sure that you have sufficient permissions to the path.
Dataset 'hub://${ACTIVELOOP_ORG_NAME}/https-github-com-gustavz-DataChad-git-1000' does not exist -> uploading

${ACTIVELOOP_ORG_NAME} is my ACTIVELOOP_ORG_NAME in .env

I am getting same error 'Failed to build chain for data source 'https://github.com/gustavz/DataChad.git' with error: A dataset does not exist at the specified path, or you do not have sufficient permissions to load or create one. Please check the dataset path and make sure that you have sufficient permissions to the path.' even after entering all my credentials in .streamlit/secrets.toml, even tried .env and manually entering them. Not sure if I need to create a dataset in activeloop before running it?

Try deleting the datachad related datasets from your activeloop account. They could be broken.
Let me know if this helped.


replica cluster reports "Cluster is ready" when replication is broken

Hi!
Thanks in advance for your help!
The issue
I am using cnpg to set up a replica cluster that is connected to its primary using streaming_replication. When a connection to the primary is not possible (due to e.g. a firewall misconfiguration), the replication fails with the following error message:
{
  "level": "info",
  "ts":<PHONE_NUMBER>.2284603,
  "logger": "postgres",
  "msg": "record",
  "logging_pod": "db-1",
  "record": {
    "log_time": "2022-10-05 09:54:41.228 UTC",
    "process_id": "282085",
    "session_id": "633d5461.44de5",
    "session_line_num": "1",
    "session_start_time": "2022-10-05 09:54:41 UTC",
    "transaction_id": "0",
    "error_severity": "FATAL",
    "sql_state_code": "08006",
    "message": "could not connect to the primary server: connection to server at \"XXX\" (xxx.xxx.xxx.xxx), port XXXXX failed: server closed the connection unexpectedly\n\tThis probably means the server terminated abnormally\n\tbefore or while processing the request.",
    "backend_type": "walreceiver",
    "query_id": "0"
  }
}

At the same time the cluster condition is reported as "Cluster is Ready":
$ k get cluster db -o json | jq -r '.status.conditions'
[
  {
    "lastTransitionTime": "2022-10-04T13:09:52Z",
    "message": "Cluster is Ready",
    "reason": "ClusterIsReady",
    "status": "True",
    "type": "Ready"
  }
]

What should happen?
This should trigger an error instead, reporting that the replication from the primary is broken.

Hi @cleboo
Can you provide the output of the kubectl cnpg status command for this cluster?

Hi @sxd
Thanks for looking into this. Here the output and I attached the manifest as well (with some info redacted):
Cluster Summary
Name:              db
Namespace:         default
PostgreSQL Image:  ghcr.io/cloudnative-pg/postgresql:14.5
Primary instance:  db-1
Status:            Cluster in healthy state
Instances:         2
Ready instances:   2

Certificates Status
Certificate Name        Expiration Date                Days Left Until Expiration
----------------        ---------------                --------------------------
db-client-ca         2023-11-14 15:05:57 +0000 UTC  336.09
db-replication-cert  2023-11-14 15:05:57 +0000 UTC  336.09
db-server            2023-03-06 16:03:05 +0000 UTC  83.13
db-server-ca         2023-11-14 15:05:57 +0000 UTC  336.09

Continuous Backup status
Not configured

Streaming Replication status
Primary instance not found

Instances status
Name     Database Size  Current LSN  Replication role      Status  QoS         Manager Version  Node
----     -------------  -----------  ----------------      ------  ---         ---------------  ----
db-1  11 GB          5C1/F000000  Standby (file based)  OK      Guaranteed  1.17.0           node05
db-2  11 GB          5C1/F000000  Unknown               OK      Guaranteed  1.17.0           node06

apiVersion: postgresql.cnpg.io/v1
kind: Cluster
metadata:
  generation: 1
  labels:
    app.kubernetes.io/instance: app
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: base
    app.kubernetes.io/version: 0.1.0
    helm.sh/chart: base-0.1.0
  name: db
  namespace: default
  resourceVersion: "32857747"
  uid: 63a557ad-b8a8-4f0e-a272-328a432a0089
spec:
  affinity:
    podAntiAffinityType: preferred
    topologyKey: ""
  bootstrap:
    pg_basebackup:
      database: ""
      owner: ""
      source: db
  certificates:
    clientCASecret: db-client-ca
    replicationTLSSecret: db-cert
    serverAltDNSNames:
    - <REDACTED>
    serverCASecret: db-ca
  enableSuperuserAccess: true
  externalClusters:
  - connectionParameters:
      dbname: postgres
      host: <REDACTED>
      port: <REDACTED>
      sslmode: verify-full
      user: streaming_replica
    name: db
    sslCert:
      key: tls.crt
      name: db-replication-cert
    sslKey:
      key: tls.key
      name: db-replication-cert
    sslRootCert:
      key: ca.crt
      name: db-server-ca
  imageName: ghcr.io/cloudnative-pg/postgresql:14.5
  instances: 2
  logLevel: info
  maxSyncReplicas: 1
  minSyncReplicas: 1
  monitoring:
    customQueriesConfigMap:
    - key: queries
      name: cnpg-default-monitoring
    disableDefaultQueries: false
    enablePodMonitor: false
  postgresGID: 26
  postgresUID: 26
  postgresql:
    parameters:
      archive_mode: always
      archive_timeout: 5min
      dynamic_shared_memory_type: posix
      log_destination: csvlog
      log_directory: /controller/log
      log_filename: postgres
      log_rotation_age: "0"
      log_rotation_size: "0"
      log_truncate_on_rotation: "false"
      logging_collector: "on"
      max_parallel_workers: "32"
      max_replication_slots: "32"
      max_slot_wal_keep_size: 20GB
      max_worker_processes: "32"
      shared_buffers: 1GB
      shared_memory_type: mmap
      shared_preload_libraries: ""
      wal_keep_size: 512MB
      wal_receiver_timeout: 5s
      wal_sender_timeout: 5s
    syncReplicaElectionConstraint:
      enabled: false
  primaryUpdateMethod: switchover
  primaryUpdateStrategy: unsupervised
  replica:
    enabled: true
    source: db
  resources:
    limits:
      cpu: "1"
      memory: 4Gi
    requests:
      cpu: "1"
      memory: 4Gi
  startDelay: 30
  stopDelay: 30
  storage:
    resizeInUseVolumes: true
    size: 50Gi
  superuserSecret:
    name: db-secret
  switchoverDelay: 40000000

cloutdative-pg version in v1.17.0.

Hi @cleboo
Sorry for the late reply, can you confirm if you can still see the same issue with version 1.18.1?
Also, this looks like an issue with the storage or networking, can you check the logs looking for some information that may look like "cannot stream WAL file" or something like that?
Will turn this into a discussion, since I don't see an issue and this looks more like a configuration problem or either a cluster issue.
Best Regards,


[data] Add domain tags to schema/scraper

Adding a field for domain tags; right now it's configured as an array in the Dataset field. Perhaps it'd be better to have a separate table for it?
Right now it's an array with a GIN index rather than the classic intermediate tables/JSON/JSONB due to this post on performance I've seen, though it was written 2 years ago, so maybe it's changed.

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #14   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          63     65    +2
=====================================
+ Hits           63     65    +2

Impacted Files
Coverage Δ

nycodex/db.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56e744a...4ce0be3. Read the comment docs.


JS: config.default_language -> lang

For some reason my configuration suddenly stoped working with:
config.default_language not found in context while rendering
Similar problem found in some zola templates:
https://github.com/getzola/zola/issues/1442

hi,
will this fix be merged or is it blocked? the theme is not usable with zola 0.14 without this fix.

You can merge this branche please ?


Extend UCS servers catalogs

Background
Currently UCS catalogs missed some key properties and need more extend request to UCS-server to get back these data for catalogs.
Details
Extend more details info somthing like:

Disk
IO
Memory
CPU
And other useful information.

Reviewer: @iceiilin @anhou
Paired with Krein.

add to whitelist

@yaolingling @mcgg


Create component to search for stocks in Quandl

This can probably be closed. Extra features can be raised as new issues.


Using Gitlab's full_path instead of name while using authentication by Groups

Hi,
Thanks for the guard. I had integrated with our on-premises gitlab and working great. One requirement that would help us is authentication using group/subgroup. While checking code, guard uses group name instead if its use full_path; then we can grant access subgroup level.
Thanks
Gopinath

Sounds good to me, do you want to send a pr?

cc: @nightfury1204

Fixed in https://github.com/appscode/guard/releases/tag/0.3.0


GPU memory overload

Due to limited GPU resources, my system experiences memory overload during training and testing. I would like to know if it's possible to reduce the number of Precomputed per-point CLIP features (.pt files) during training or testing, or if there are other effective methods to address this issue. If it's possible to reduce the number of files, where should I make the modifications in the code? I eagerly await your response!

Thanks for your interest. Unfortunately, training/testing to each scene requires to use its corresponding pre-computed CLIP features. For example, if you want to train/test model in scene0000_00, you need to use pointwise CLIP features of this scene. So if you are going to train/test the model in the whole training or validation dataset, you need to use CLIP features for all of these scene.
Btw, can you let me know the GPU memory size you are using now?

Sorry for the late reply. Here is the display of my GPU memory.

What I understand is, if I only use a portion of the dataset for testing or training (i.e., by reducing the dataset, and accordingly only having the CLIP features for those specific scenes), the code can still perform the testing and training, right?

Since your GPU memory size is 24GB, testing can be available. However, you may need over 40GB GPU memory to train our SOLE model on ScanNet dataset. So, although you decrease the number of scenes, training may still be not available due to the memory limitation.

Even though you use 24GB GPU memory, testing process can be killed due to insufficient CPU memory. This is due to the inherent heavy memory requirement of Mask3D which is the baseline of our model. You may refer this link.

Alright, I will think of some other ways. Thank you.


Timber\Menu() returns default menu when using non-existent menu slug as parameter

Expected behavior
If I try to create a menu item with non-existent menu slug like here:
<?php
// Get non-existent menu item
// Real menu slug was 'mobile'
$context['mobilemenu'] = new Timber\Menu("mobilemenu");

I would want to see error or no menu or a notice in the error log.
Relevant lines are here:
https://github.com/timber/timber/blob/4d19fa9bba16412bb012280cac714bdfb6be550d/lib/Menu.php#L82-L100
Actual behavior
Current implementation just silently returns the default menu which makes debugging menu errors harder.
What version of WordPress, PHP and Timber are you using?
php7.1, WP 4.7.5
How did you install Timber? (for example, from GitHub, Composer/Packagist, WP.org?)
Composer

I think this is expected behavior (to match WordPress standard behavior), but I absolutely hate it.

Conditionally add to context when the menu exists
if( has_nav_menu( 'mobilemenu' ) ) {
    $context['mobilemenu'] = new Timber\Menu("mobilemenu");
}

Check the menu exists on the context before rendering
{% if mobilemenu%}
   {% include "path/to/menu.twig" with {'menu': mobilemenu.get_items} %}
{% endif %}

Anti-pattern like behavior. Documentation says the following:

Or pass nothing. This is good if you have only one menu. In that case Timber will just grab what you got.

Well, this is not okay. I got 8 contextual menus on a complex site. There is possibilities like @shaneoliver pointed out, but it is neither documented if the slug doesn't exist, nor it behaves like expected from an API as a dev.

I am willing to make an PR, if it will be clarified if the core team wants to add this change.
Personally I think current behavior is incorrect and can make bug in production if a needed menu is deleted - suddenly showing first default one.
Possible solutions

add another option to constuctor new Menu('slug', ['strict' => true]) or mustExist
change current behavior to return Menu without items / empty

@nakashu — thank you so much for running that by before diving into a PR (nothing pains me more than saying "no thank you" to an otherwise well-meaning PR).
The pattern you describe is 👍 — the only caveat I'd add is that as much as possible we try to use existing WP names or patterns (so mustExist => must_exist). We can always quibble over the exact words once the basics are down, but the overall architecture you describe (with an options array instead of an infinite chain of arguments) is exactly what we're transitioning to more and more so it gets my vote.
Thanks for chiming in and taking that on!


Falsely detecting "name property bug" on certain pages in Firefox

Running this code (slightly modified from testForNamePropertyBug()) in Firefox
var el = document.createElement("iframe");
var IFRAME_PREFIX = "easyXDM_";
el.name = IFRAME_PREFIX + "TEST";
el.style.position = "absolute";
el.style.left = "-2000px";
el.style.top = "0px";
document.body.appendChild(el);
var HAS_NAME_PROPERTY_BUG = !(el.contentWindow === window.frames[el.name]);
document.body.removeChild(el);

console.log(HAS_NAME_PROPERTY_BUG);

on the following page: http://www.mobileread.mobi/forums/showthread.php?t=116098 reports as having the name property bug (which is supposed to be IE only). Later on, it tries to create an element using IE-only syntax (e.g. document.createElement('<iframe name="foo">')) which causes an "invalid character" error.
I tested in IE, Safari, Chrome and Firefox, and it appears to be Firefox only.

this can be mitigated by using easyXDM.noConflict() but there still probably be better detection of IE, or a try...catch or something...


Fixed the build of the example project

          2 Messages

:book:
iOS: Executed 1 test, with 0 failures (0 unexpected) in 0.009 (0.020) seconds

:book:
tvOS: Executed 1 test, with 0 failures (0 unexpected) in 0.072 (0.096) seconds

  Generated by :no_entry_sign: Danger


Huge canvases are not rendered

PDF.js seems to assume that the canvas size is unlimited.
As demonstrated by #6385, this is not true. In that bug, a specific system using IE11 with HWA enabled supported canvases of at most 2048x2048 (https://github.com/mozilla/pdf.js/issues/6385#issuecomment-137703758).
Other browsers / systems have more generous limits, but there are probably images (e.g. high-res scans?) that exceeds these boundaries. In these cases, we should still be able to display the image in some way.
Slicing the canvas seems a solution, but that might be a bit tricky with gradients.
In IE, feature detection seems possible using canvas.toDataURL & img.naturalWidth & img.naturalHeight. In Chrome, toDataURL. I haven't checked Firefox or Safari yet, but detection can probably be done in a similar way.
So, how should we tackle big canvases?

Blocked by #6419


Extract media modules

Pulled some duplicate functionality shared between video and audio out into modules. This means only changing one place to have videos and audio get the change.
One question I have is, would the modules be better placed in a folder? lib/fulcrum/concerns/ or lib/fulcrum/media?

We can just put those files under the actions directory since they are actions on the resource. Also, you can add an optional format parameter to track which passes down through to the member_action method which accepts the format to fix #11.

I've moved them to the actions folder. Adding the format parameter is what made me want to originally extract the modules. This should be ready to merge.

:sparkles:


CenterPoint config

Hello, does this includes the centerpoint densehead code?

@sshaoshuai @jihanyang
Yes, it would be great if you could push CenterPoint support to the public repo!
I know you have it internally. :wink:
https://github.com/open-mmlab/OpenPCDet/pull/549/files#diff-6aa849eac2d13c197e5de529cc91f057dc545f5d9d98ce87e0a63e81f8e00b4c

We do have an internally implementation of CenterPoint, but the performance is not matched with official Centerpoint repo yet. It should be easy to add CenterPoint (just a CenterHead) to this repo, but the performance matching may still need some time.
I am busy these days  and may find time to explore it. (You could also try it by youself if you really need it right now)

Any update on when/if CenterPoint is going to be added?

@sidml: It is not so difficult to integrate the config yourself that is mentioned here.
https://github.com/open-mmlab/OpenPCDet/issues/602#issuecomment-906094762

Any update on when/if CenterPoint is going to be added?

@sidml: It is not so difficult to integrate the config yourself that is mentioned here. #602 (comment)

Hi Martin, Just wondering did you make it work? I tried to implemented the config, it was training but i got 0 accuracy during evaluation. Not really sure it's the evaluation metrics code or config that i got wrong with.....

I got it working. I did not change the config. I copied it as is.
Then I just solved one error message after the other (maybe 5 in total), after that, it worked as expected.

I got it working. I did not change the config. I copied it as is. Then I just solved one error message after the other (maybe 5 in total), after that, it worked as expected.

Thanks for your reply. Just wondering is it KITTI or Waymo or both that you got it working?

Neither, I am currently working with the STF dataset. But I adopted the KITTI dataloader to get STF working, so I am sure it would work with KITTI and assume with Waymo, too.

Thanks for the info. I will try it again.

Hi all,
I have updated OpenPCDet to v0.5.0. This version has supported CenterHead and CenterPoint 3D detector. And I guess the performance of CenterPoint is fully reproduced.
You could have a try.


Accept multiple folders as analyzer input path

Is your feature request related to a problem? Please describe.
We currently are playing around with integrating both analyzers from a NuGet package and are considering writing some very laser-focused custom analyzers that only make sense for our current project.
Describe the solution you'd like
Allow multiple --analyzers-path arguments.
So we can do something like --analyzers-path ./download-nuget-folder --analyzers-path ./src/LocalAnalyzer/bin/Debug
Describe alternatives you've considered
One could copy the local analyzer to another folder of course. Doing a dotnet publish wouldn't be a stretch I guess.
Additional context
Might play around with this idea in the weeks to come in the Fantomas repository.

@nojaf Can we close this because of #128 or do you see something still missing here?


fix: build overrides for headless push with new env init scneario

Description of changes
fixes #8912

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #8913 (f56b192) into master (06a8988) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #8913      +/-   ##
==========================================
- Coverage   55.57%   55.57%   -0.01%
==========================================
  Files         868      869       +1
  Lines       48620    48624       +4
  Branches     9657     9657
==========================================
+ Hits        27020    27022       +2
- Misses      20730    20732       +2
  Partials      870      870

Impacted Files
Coverage Δ

...dformation/src/build-override-enabled-resources.ts
25.00% <25.00%> (ø)

...y-provider-awscloudformation/src/initialize-env.ts
22.95% <50.00%> (+0.56%)
:arrow_up:

...y-provider-awscloudformation/src/push-resources.ts
18.43% <50.00%> (+0.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06a8988...f56b192. Read the comment docs.


Critical Bug: search_dates doesn't understand 7am (but ok with 7pm)

Folks, we need to address this ASAP. When using search_dates with something like "7am" it fails to understand the time correctly. It only happens to AM, while PM looks like ok
Here is what I'm observing:
$ date
Thu Feb 22 20:14:33 PST 2024

$ pip3 show dateparser
Name: dateparser
Version: 1.2.0
. . . . .
>>> from dateparser.search import search_dates

>>> search_dates("there is something tomorrow at 7am")
[('tomorrow at 7am', datetime.datetime(2024, 2, 23, 20, 15, 47, 376532))]

>>> search_dates("there is something tomorrow at 7pm")
[('tomorrow at 7pm', datetime.datetime(2024, 2, 23, 19, 0))]

>>> search_dates("there is something tomorrow at 7:00am")
[('tomorrow at 7:00am', datetime.datetime(2024, 2, 23, 7, 0))]

>>>

When adding :00 to it looks like does the trick, however the text doesn't always have hr:min format
so the issue is why it fails with AM?

search_dates("there is something tomorrow at 7am")
[('tomorrow at 7am', datetime.datetime(2024, 2, 23, 20, 15, 47, 376532))]

Please help with this issue. Thanks for your help and support!

https://github.com/scrapinghub/dateparser/issues/1037


New features added, undo system, text tool, save/load system (using the browser local storage) and others.

I finished the undo system and finally added some more features/tools.

The interface is like this now:


Search for Northstar.dll in profile directory

Looks for Northstar.dll in the specified profile directory using -profile=<dir>. If it doesn't exist it defaults to the Northstar.dll in the root directory.

Hol' up this looks so easy, why haven't we been doing this earlier?! o_O
Genuinely awesome idea ngl
Given that the NorthstarLauncher.exe barely gets changed anyway it should stay mostly compatible between releases if combined with other versions of Northstar.dll 👀
Now thing is as much as I want this ASAP there's a few things to consider:
Most importantly

[ ] Release repo CI needs to be updated to put DLL into right folder (I could do that if you don't wanna, just LMK)
[ ] Mod managers will need to support the change (obviously the location in the zip folder would be updated in release repo so that it's in right profile so it's mostly a question of whether mod-managers check for it and maybe have some logic to get rid of old DLL

[ ] @0neGal for Viper
[ ] @BigSpice for VTOL
[ ] @GeckoEidechse for FlightCore (oh hey, that's me xD)
[ ] r2modman probably also needs to be updated given that it puts mods into profile in its dir and places exe in Titanfall2 folder

[ ] General checking whether this breaks stuff?
[ ] ???

Actually as a temporary switchover we could search both paths (old and new) where new is preferred but old is used as fallback and then later deprecated old location after a month or two.

Release repo CI needs to be updated to put DLL into right folder

Does it? Isn't the main benefit of this for RCs and dev work? Surely we should continue to put the dll where it currently is, except for when building/installing an RC or a version using a mod manager?

* [ ]  Release repo CI needs to be updated to put DLL into right folder (I could do that if you don't wanna, just LMK)

I fall back to the Northstar.dll in the root directory so this is completely optional

Actually as a temporary switchover we could search both paths (old and new) where new is preferred but old is used as fallback and then later deprecated old location after a month or two.

Skipped over this originally. We do fallback to the original path when a Northstar.dll doesnt exist in the profile, or when no profile is passed.
Thinking about it if you put a Northstar.dll into R2Northstar it and dont provide a -profile=R2Northstar it'll fallback to the original and wont load the profile one.

Thinking about it if you put a Northstar.dll into R2Northstar and dont provide a -profile=R2Northstar it'll fallback to the original and wont load the profile one.

Fixed in 20d4360

Current behaviour:

No args passed:
Looks for Northstar.dll in R2Northstar
A profile passed
Looks for Northstar.dll in the profile dir

If we dont find R2Northstar we fallback to the one in the root directory

A profile passed
Looks for Northstar.dll in the profile dir

Note that to my knowledge this will break r2modman. Cause it runs NorthstarLauncher.exe with -profile pointing to the mods folder in its install dir. Not sure if moving the the dll into R2Northtstar folder is enough to fix that, I'd have to check r2modman source for that.

No, because it falls back to root directory if it's not there in the profile dir

Note that to my knowledge this will break r2modman. Cause it runs NorthstarLauncher.exe with -profile pointing to the mods folder in its install dir. Not sure if moving the the dll into R2Northtstar folder is enough to fix that, I'd have to check r2modman source for that.

No, because it falls back to root directory if it's not there in the profile dir

Oh right, forgot about that, disregard my comment above then ^^"

Mod managers will need to support the change (obviously the location in the zip folder would be updated in release repo so that it's in right profile so it's mostly a question of whether mod-managers check for it and maybe have some logic to get rid of old DLL

Problem is, how would we go about doing this, mod managers would have to store the file structure of the archive upon installation, and then delete files when missing in newer versions. Either that or have a file in the archive with files of which to delete before/after installation.
As I do believe most if not all mod managers just extract the archive into the install folder in some way or form, without deleting any other files.
Of course, we could all just add in a check to delete the old DLL, but that sounds a lot more like a workaround than an actual solution, given this will quite possibly happen again sooner or later.
Northstar itself could also just delete the old file if it finds it, but uncertain if that's any good of a solution.

A profile passed
Looks for Northstar.dll in the profile dir

Note that to my knowledge this will break r2modman. Cause it runs NorthstarLauncher.exe with -profile pointing to the mods folder in its install dir. Not sure if moving the the dll into R2Northtstar folder is enough to fix that, I'd have to check r2modman source for that.

What should we be doing with the DLL? It was built to the spec at the time of original development, so what’s changed in terms of how we provide -profile and how is the DLL stored there when pulled from TS?
If it’s in the root of the package then we should just support it? Has the target for -profile changed/we’re currently using a legacy approach?

As I do believe most if not all mod managers just extract the archive into the install folder in some way or form, without deleting any other files.

Could be wrong but I’m pretty sure r2mm handles it as we have a state tracker that logs the current state of all the files

A profile passed
Looks for Northstar.dll in the profile dir

Note that to my knowledge this will break r2modman. Cause it runs NorthstarLauncher.exe with -profile pointing to the mods folder in its install dir. Not sure if moving the the dll into R2Northtstar folder is enough to fix that, I'd have to check r2modman source for that.

What should we be doing with the DLL? It was built to the spec at the time of original development, so what’s changed in terms of how we provide -profile and how is the DLL stored there when pulled from TS?
If it’s in the root of the package then we should just support it? Has the target for -profile changed/we’re currently using a legacy approach?

So basically currently the package for Northstar looks like
.
├── icon.png
├── manifest.json
├── Northstar
│   ├── bin
│   │   └── <some stuff>
│   ├── LEGAL.txt
│   ├── Northstar.dll   <--- this would be moved in the future
│   ├── NorthstarLauncher.exe
│   ├── r2ds.bat
│   └── R2Northstar
│       ├── mods
│       │   └── <some stuff>
│       └── plugins
│           └── <some stuff>
└── README.md

and in the future we'd change it to
.
├── icon.png
├── manifest.json
├── Northstar
│   ├── bin
│   │   └── <some stuff>
│   ├── LEGAL.txt
│   ├── NorthstarLauncher.exe
│   ├── r2ds.bat
│   └── R2Northstar
│       ├── Northstar.dll   <---- now moved here
│       ├── mods
│       │   └── <some stuff>
│       └── plugins
│           └── <some stuff>
└── README.md

So if r2mm would already support that, then there's no change necessary. If not we'll keep it in mind and will have to update r2mm accordingly before pushing a changed package structure in Northstar.
(Note that this PR is not about moving the DLL itself but simply about enabling moving it in the future ^^)

So if r2mm would already support that, then there's no change necessary.

As far as I'm aware it should just work out of the box. We do things like compare what's copied across and remove things that aren't specified anyway.
Assuming we don't need to change the target of the mods directory then no change would be necessary from what I can tell as I'm pretty sure it just extracts the zip into the manager's profile dir.

Added depends on another PR as this depends on mod managers to add support ( even though none of them properly support profiles to this date yet )

I personally have not been explained exactly how they work. I'm putting work tn, some pointers would be wonderful 👀

I personally have not been explained exactly how they work. I'm putting work tn, some pointers would be wonderful 👀

The idea of profiles is, in short, just renaming R2Northstar. Let's say you pass -profile="Testing", now instead of using the R2Northstar folder we look for mods, plugins in Testing folder.
This PR adds this functionality for loading the Northstar.dll. Lets say you set the profile directory to Testing. NorthstarLauncher will look for the dll in that directory, if it doesn't find it in there it'll try to load the one in the root ( where we place it rn ), if even that fails it exits.

Added depends on another PR as this depends on mod managers to add support ( even though none of them properly support profiles to this date yet )

Looking back at this again. This PR just adds functionality to search for DLL in the profile folder but does not actually move it yet. So we can probably just skip most of the stuff in my original comment and only do that when we actually move the DLL.

bump


docs(sample): add runReport sample

relevant python sample and java samples
https://github.com/googleapis/python-analytics-data/blob/main/samples/snippets/run_report.py
https://github.com/googleapis/java-analytics-data/blob/main/samples/snippets/src/main/java/com/example/analytics/RunReportSample.java

I'd like to wait to merge until #206 is merged. Thanks!


🐛 manjaro-sway-settings post update instructions break waybar and gtk theme

branch
testing
Architecture
x86_64
Description
The following instructions are displayed after updating manjaro-sway-settings:

in order to update your user configuration, run: skel
in order to apply your user configuration, run: swaymsg reload

After I do that the theme seems to be broken. This is most visible in the waybar, but apps like firefox are also affected.
Strangely, I have to reboot the machine to "fix" the theme. It is not enough to just logout and login again.
This also happens in the current live image manjaro-sway-22.1.2-240114-linux61.iso
Reproduction steps
1. Start live image [manjaro-sway-22.1.2-240114-linux61.iso](https://manjaro-sway.download/download?file=manjaro-sway-22.1.2-240114-linux61.iso)
2. Open foot
3. Run `skel`
4. Run `swaymsg reload`

Screenshots
Some screenshots after running swaymsg reload
waybar:

timeshift:

remmina:

Logs
No response

I can reproduce this, but I don't fully understand why that happens. Perhaps something is still in exec not exec_always, but on first sight, it looks fine. Does the same happen for you if you use the theme-switcher (manjaro-sway-theme)?
That being said: you don't have to always do this all the time. I try to keep changes that require skel to a minimum.

Funny enough: running manjaro-sway-theme after skel seems to fix it again. So we probably should take at look at what the theme-script odes that swaymsg reload alone doesn't.

usually i can fix this by reloading the sway configuration a few times and after a few minutes... it get fixed.. agree it is a mystery

For me this currently "just works" and I can recall if there was anything on our side that could have fixed it. Could one of you give it a try again to see if it also magically is fixed?


Add public total count measure counting the total number of results f…

Implements #167:

Add a total_count measure counting the total number of results not considering the query limit
Add a totalCount field in the QueryResultDto

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


BindParameter_WithTypeProperty_IsNotBound test looks bogus

As part of #6055, I fixed ModelBindingTestHelper.GetParameterBinder so that it now passes through the MvcOptions you give it into the parameter binder that it sets up. Previously it was just disregarding your options and in effect passing defaults.
Since doing this, the test BindParameter_WithTypeProperty_IsNotBound now fails. From what I can understand, this test is checking that with the default options, ExcludeBindingMetadataProvider prevents binding to properties of type System.Type. It does this check by registering a custom IModelBinderProvider that throws if it sees System.Type, so that the test would fail if a parameter if that type was bound.
However, it looks to me like the test was not really checking anything. Because ModelBindingTestHelper.GetParameterBinder was ignoring the options, this meant that the custom IModelBinderProvider was not really even registered. So the test could never fail, whether or not the product code was really working properly.
So either:

The test implementation is wrong, and is failing falsely even though the product code is correct
Or, the underlying product code is broken and the fixed test correctly detects this

In the meantime, I'm marking this test to be skipped so I can push #6055.

@sebastienros It looks like you'll have the most context on this since you implemented 2c639f83c4f0a3232c40881f2e48aaf31e2f0c6e. Could you comment on what you think might be the issue here?

Will look at the test, in the meantime just to give some context, model binding would be utterly slow when a Type property would be on a view model because of the depth of its property graph. This perf issue has be fixed later, but the idea was to just be able to ignore specific types, and we also decided to add Type by default.

This perf issue has be fixed later

I'm not sure about that 😆
I'd also mention that as much as possible the integration tests are trying to test the default configuration of MVC, with some shortcuts where a scenario would require extensibility to test.


Add initial codecov integration

Initial integration with codecov.io and Jenkins. See https://codecov.io/gh/istio/manager for reports)
Race detection is temporarily disabled because istio.io/manage has some data races. Will file follow-up bugs for those.
Codecov is triggered on presubmit. This means the published codecov.io includes reports for the istio.io/manager/master as well as all of the pending PR. This is not a huge deal (yet) since we can differentiate reports on codecov.io's website based on commit summary.

Jenkins job manager/presubmit passed

Jenkins job manager/presubmit passed

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@dcecb20). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #171   +/-   ##
=========================================
  Coverage          ?   31.47%
=========================================
  Files             ?       19
  Lines             ?     1757
  Branches          ?        0
=========================================
  Hits              ?      553
  Misses            ?     1153
  Partials          ?       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcecb20...46d0e7c. Read the comment docs.

Jenkins job manager/presubmit passed

Jenkins job manager/presubmit passed

Jenkins job manager/presubmit passed

Jenkins job manager/presubmit passed


Properly handle subscribe response send by light wallet

Now it reports error
call = "ws.send_subscribe()"
err = ErrorMessage { msg: "subscribe err: "I'm light, cannot subscribe you to updates"" }

currently we use t!(ws.send_subscribe()); in connection init, though it report error and ignore the result which is fine, but we can handle that more gracefully, should we filter the error message?

close it since this is an expected behavior


Updated abridge and sbridge to Meet Style Guide Requirements

Updated indentation spaces/tab to 2 spaces, variable names to COBOL case, function names to camel case, function/class/conditional statements have "{" and "}" on their own line, and other style guide requirements. Corrected typos. Changed variable names for consistency. Writing code that matches the style guide improves readability, comprehension, and overall code uniformity/aesthetic.

Those have already been changed. Can you show me where you found that instance?

Sure. Remind me at the dev meeting tomorrow.
From: Kristiana Rendon<EMAIL_ADDRESS>Sent: Tuesday, October 23, 2018 1:06 PM
To: BCLab-UNM/SwarmBaseCode-ROS<EMAIL_ADDRESS>Cc: Matthew Fricke<EMAIL_ADDRESS>Review requested<EMAIL_ADDRESS>Subject: Re: [BCLab-UNM/SwarmBaseCode-ROS] Updated abridge and sbridge to Meet Style Guide Requirements (#213)
Those have already been changed. Can you show me where you found that instance?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://github.com/BCLab-UNM/SwarmBaseCode-ROS/pull/213#issuecomment-432379067, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADw5E-Hb7BRIm3zy3MBKpldrTYDsVlgkks5un2ingaJpZM4X0XKb.


PR for Add new and display comment

In this milestone

Implemented Displaying the comments for the clicked item when the popup loads it retrieves from the involvement API
Implemented adding new comments for the clicked item.
Implemented Add comment counter to the view number comments.

Hi @Miliyonayalew ,
Your feature is looking great, good job! 💪 , below are my recommendation to improve your code even more:
Highlights

The Pull Request has a proper title and description. ✔
Correct use of git-flow. ✔
Clean and easy-to-follow code. ✔

Recommendations
https://github.com/jfoyarzo/Capstone-II/blob/2ffcf23e0664c8f43ea89d053ef0a336076c55b1/src/modules/commentAPI.js#L2-L8

For this function, you can use the .then() chaining method instead of using await 2 times. I think this will improve code readability. For instance, you may use const response = await fetch(URL).then((response) => response.json());

https://github.com/jfoyarzo/Capstone-II/blob/2ffcf23e0664c8f43ea89d053ef0a336076c55b1/src/modules/modal.js#L98-L103

To comply with the requirement of the task we have to implement the counters in their own module, in this case, we would have to create a dedicated file for this function and import it afterward.

Great job so far! 💯
Happy coding! 👾

Thanks, Felipe,  for the comments as you say it will improve code readability but it's not good practice to use then in the async/await  function.


Increment devcontainer CLI 0.64.0->0.65.0

Description of changes

Increments the devcontainer CLI from 0.64.0 to 0.65.0.
Changelog: https://github.com/devcontainers/cli/blob/main/CHANGELOG.md#0650
(Awesome jobs, @Rucadi @Gerg-L !  I opened my laptop today to finally resurrect https://github.com/NixOS/nixpkgs/pull/276208, only to see the work had already been done :tada: )
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

 Unfortunately, they
cannot be automatically unsubscribed from the issue (removing review request does not
unsubscribe), therefore development cannot continue in this pull request anymore.
Please create a new pull request, link back to this one and ping the
people actually involved in here over there. For the next time, remember to set your PR to draft status before rebasing. In draft status, you can preview the list of maintainers that are about to be requested for review, which allows you to sidestep this issue.
In order to avoid this in the future, there are instructions for how to properly
rebase between branches in our contribution guidelines.
Setting your pull request to draft prior to rebasing is strongly recommended.
In draft status, you can preview the list of people that are about to be requested
for review, which allows you to sidestep this issue.
This is not a bulletproof method, though, as OfBorg still does review requests even on draft PRs.


Finish this repository

Get the file from Windows laptop
Edit the readme file
Relate to MATLAB Wed App generated based on this

Test of the project page


Remove unnecessary builders

I see that we have some MsgBuilder structs that are empty and are used to easily create msgs that can be sent to the chain.
Since all of the methods exposed from that structures can be converted to static methods I suggest to remove all the MsgBuilder structs and move their methods to the corrispettive enums.
For example al methods of ProfilesMsgBuilder can be moved into the ProfilesMsg enum like this:
impl ProfilesMsg {

     pub fn save_profile(
        dtag: &str,
        creator: Addr,
        nickname: &str,
        bio: &str,
        profile_picture: &str,
        cover_picture: &str,
    ) -> ProfilesMsg {
        ProfilesMsg::SaveProfile {
            dtag: dtag.to_owned(),
            nickname: nickname.to_owned(),
            bio: bio.to_owned(),
            profile_picture: profile_picture.to_owned(),
            cover_picture: cover_picture.to_owned(),
            creator,
        }
    }

   // Other functions....

}

Please let me know what you think about this @bragaz @dadamu.

Fair enough for me to move them as ...Msg methods rather then builder's one.
This will also lead to a clearer way to instantiate messages since devs will only need to do
ProfileMsg::save_profile() for instance.

I agree with the change, it becomes simpler to devs.


1.11 Train

Trying to merge:
https://github.com/dcos/dcos-ui/pull/3427 ✅✅
https://github.com/dcos/dcos-ui/pull/3468 ✅✅
High prio because it blocks two issues from being resolved.

:tada: This PR is included in version 1.26.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Connect Prometheus alerts on netcup to Kubernetes Alertmanager

We want to be able to configure alerts on the Netcup Prometheus instance and
act on it accordingly, with the alerting configuration and HA alertmanager
setup running in Kubernetes.
Joe might be able to give us a token that we can use to talk to Alertmanager in
Kubernetes, and connect our Prometheus instance to it.

@jb3 assigning you since you probably know how to quickly add access to the AM instance

Netcup nodes now have an IP bypass to be able to hit AlertManager, they can hit the AlertManager service at https://alertmanager.pythondiscord.com/


Use binary compiler bridge

Problem
Starting Scala 2.13.12, Scala 2 has in-sourced the compiler bridge imple (https://github.com/scala/scala/pull/10472), which hopefully will be kept up to date more than the ones in Zinc.
Solution
This switches to using the pre-compiled compiler bridge for >=2.13.12 /cc @lrytz

I still saw:
[info] Non-compiled module 'compiler-bridge_2.12' for Scala 2.12.18. Compiling...
[info]   Compilation completed in 11.463s.

Will this landed in scala 2.12.18+?

Will this land in scala 2.12.18+?

It won't. For Scala versions older than 2.13.12, everything will keep on working the way it used to.


Fraud domains

Article site https://innpoland.pl/183028,zatruta-odra-to-smierc-biznesu?SGNT=
Section FB Comments

I earn more than $8650 online each month by doing very simple online work from my home. By doing this part-time, I have managed to save enough to buy myself a new car in just a few months.  Start making some money online today by following the instructions on this page....

Tank you Tomasz!
Are you sure easy-extra-income-ways-makes-you-rich.store is fraud? 🤣
Merging!


deis limits:unset web=64M doesn't unset the limit

From @slack on May 14, 2016 23:25
k:mustache example-go [master]$ deis limits:unset web=64M
Applying limits... done

=== indoor-whitecap Limits

--- Memory
web     64M

--- CPU
web     250m
k:mustache example-go [master]$ deis limits
=== indoor-whitecap Limits

--- Memory
web     64M

--- CPU
web     250m

kubectl --namespace=indoor-whitecap describe po indoor-whitecap-v15-web-amixa
Name:       indoor-whitecap-v15-web-amixa
Containers:
  indoor-whitecap-web:
    QoS Tier:
      cpu:  Guaranteed
      memory:   Guaranteed
    Limits:
      cpu:  250m
      memory:   64Mi
    Requests:
      memory:       64Mi
      cpu:      250m

Looks like deis limits:unset web does, bit of a surprise behavior.
Copied from original issue: deis/workflow-cli#62

From @Joshua-Anderson on May 14, 2016 23:49
At the moment there is no validation on the process given, so the cli is trying to unset limits on the process web=64M, which doesn't exist.
Just to clarify, you would expect:
deis limits:unset web=64M
to return an error like Error: No limits defined for process 'web=64M' or do you expect it to unset the memory limit on process web

From @slack on May 14, 2016 23:36
If the value is found, it should unset that value, if the value doesn't match it should throw a bad request.
If no value is given it should clear the value, like it does now.

From @slack on May 15, 2016 0:48
I would expect deis limits:unset web=64M to clear the limit if it matched the currently set value of '64M', otherwise throw an error and not create a new release.
If deis limits:unset web=64M does match, then unset and create the release.
If deis limits:unset web is called it should unset the memory limit for web, regardless of its current value.

From @bacongobbler on May 19, 2016 17:56
given that we have a workaround, is this something we can get back to after 2.0?

From @vdice on May 24, 2016 1:34
ping @slack as to if this issue needs to be resolved in v2.0-rc1 -- if so, let's label with showstopper -- otherwise, as @bacongobbler mentioned, I might suggest we move to a later milestone...


Minor syntax error in readme example

The example given has fail-on-missing-variables as an option.  That returns an error if specified, which helpfully notes that it needs to be written with underscores instead: fail_on_missing_variables
Also, the readme mentions an example at https://github.com/Slidem/inplace-envsubst-action/blob/master/.github/workflows/test.yaml which returns a 404.
Thanks for putting this together, did just what I needed!

Thanks for pointing that out, will modify the README


[Connect] Error during transaction request Error: Cannot recognize PayloadType: 6

Encountering the following error when deploying a contract from my own app:
[Connect] Error during transaction request Error: Cannot recognize PayloadType: 6
The same error is reproducible in Explorer sandbox:

Thanks!

I would update connect to latest, the new types are fairly recent

This issue will be closed by https://github.com/hirosystems/explorer/issues/1028

Bumping this to next iteration.

This should be solved


Test environment for baselines on Val14 and Interplan10 (DTPP)

Hello Marcel
Thank you so much for your quick response to the previous question.
I'm evaluating DTPP and my method based on DTPP, specifically testing their performance on the Val14 and interplan benchmarks. However, there's a significant discrepancy between my experimental results and the ones reported in the paper, and I haven't been able to make any progress.
To test DTPP on Val14 and interplan, I set up the environment as follows. Could you provide some guidance or let me know if I might be missing something in my setup for testing DTPP?
Here's how I experimented:

Hardware Configuration:

GPU: RTX 3090, CPU: Intel i9-10980Xe

Connecting tuplan_garage and DTPP:

Created a YAML configuration file for DTPP:
tuplan_garage/planning/script/config/simulation/planner/DTPP_planner.yaml

DTPP_planner.yaml:
"`yaml
DTPP_planner:
target: tuplan_garage.planning.simulation.planner.DTPP_original.planner.Planner
convert: 'all'

Cloned the DTPP repository into tuplan_garage:
tuplan_garage/planning/simulation/planner/DTPP_original

Generated a configuration file DTPP_base_model.yaml for the model in:
tuplan_garage/planning/simulation/planner/DTPP_original/config

DTPP_base_model.yaml:
"`yaml
model_path: "/model/base_model.pth"
device: "cpu"

Moved base_model.pth to tuplan_garage/planning/simulation/planner/DTPP_original/model.

Edited DTPP_original/planner.py to load the base model:
import yaml
import os
current_file_path = os.path.abspath(__file__)
current_directory = os.path.dirname(current_file_path)
config_path = os.path.join(current_directory, 'config', 'DTPP_base_model.yaml')

def load_config(config_path):
    with open(config_path, 'r') as f:
        return yaml.safe_load(f)

config = load_config(config_path)

class Planner(AbstractPlanner):
    def __init__(self, model_path=None, device=None):
        self._future_horizon = T  # [s]
        self._step_interval = DT  # [s]
        self._N_points = int(T / DT)
        self._model_path = os.path.join(current_directory, config['model_path'].lstrip('/'))
        self._device = torch.device('cpu')

    def name(self) -> str:
        return "DTPP base model"

Running Simulations:

Reduced_val_14_split:
"`bash
python $NUPLAN_DEVKIT_ROOT/nuplan/planning/script/run_simulation.py
+simulation=closed_loop_nonreactive_agents
planner=DTPP_planner
scenario_filter=reduced_val14_split
scenario_builder=nuplan
worker=ray_distributed
hydra.searchpath="[pkg://tuplan_garage.planning.script.config.common, pkg://tuplan_garage.planning.script.config.simulation, pkg://nuplan.planning.script.config.common, pkg://nuplan.planning.script.experiments]"

interplan10:
"`bash
python $INTERPLAN_ROOT/interplan/planning/script/run_simulation.py
+simulation=default_interplan_benchmark
planner=DTPP_planner
scenario_filter=interplan10
worker=ray_distributed
hydra.searchpath="[pkg://interplan.planning.script.config.common, pkg://interplan.planning.script.config.simulation, pkg://interplan.planning.script.experiments, pkg://tuplan_garage.planning.script.config.common, pkg://tuplan_garage.planning.script.config.simulation, pkg://nuplan.planning.script.config.common, pkg://nuplan.planning.script.simulation, pkg://nuplan.planning.script.experiments]"

Results (DTPP):

Reduced_val_14_split: 0.6086
interplan10: 0.3014

Could you provide any advice on this setup? Or what is your test environment for testing DTPP?
Best
Hanbin

Hi @hanbinjang,
your approach looks very reasonable to me. I cannot spot any obvious bug.
When running dttp we took a slightly different approach and integrated it as a planner into tuplan_garage, i.e. we implemented the planner, respective featurebuilders etc. Similar to above, we then loaded a pretrained checkpoint to run the model.
Unfortunately, due to license issues, we cannot publish the code we used. Also, the code we reveived from the authors differs a bit from the one that was published later. In particular, the official repository contains several "bug fixes". I believe this could be the reason for the different results.
Did you also run it on the full Val14 split?

Thank you for the reply!
Yes, I also ran the DTPP planner on the Val14 split.
Results (DTPP):
Val14_split: 0.7182
Could you explain "featurebuilders" in a bit more detail?

Hi,
the feature-builders are the used in the nuPlan framework to wrap the preprocessing needed to compute the features needed by the planners / models. For instance, the feature builder of PDM can be found here.
Re. the Val14 and interPlan score you get with your implementation:
I think these results look reasonable, given that their have been a few updates and bugfixes to the code in the meantime. Admittedly, it is a bit strange though that it performs worse on Val14 than the previous version. But I guess this is a bit out of scope for this repository.

I’m truly grateful for your detailed feedback.
Thank you!