Guard the histogram against loss of precision due to GDAL's float32 h…

…istogram storage. If required, re-calculate counts on-the-fly

OK so I checked and "Float" in RAT terminology is actually double - see ValuesIO call here: https://github.com/OSGeo/gdal/blob/master/gdal/gcore/gdal_rat.h#L260. Also HFA (https://github.com/OSGeo/gdal/blob/master/gdal/frmts/hfa/hfadataset.cpp#L823) and KEA (https://github.com/ubarsc/kealib/blob/master/src/libkea/KEAAttributeTableFile.cpp#L1107) do the actual writing as doubles.
Are you ok to close this?

Yes, I will close this PR, and you should just go ahead with the other.


This is for testing only

Copy xavier's PR

You should use this PR https://github.com/microsoft/onnxscript/pull/1709 for your unit test.
It is weird to see changes not related to old commit.

Is this still active, or should we close this?


DB2 version 1.0.0 causes issues opening .inb documents

I updated to version 1.0.0, tried to open an existing (INB) notebook with only markdown text and I get the error in the image below.   If I create a new empty INB notebook, no error is presented.  I have yet to know what part of my notebook is the reason I get the error.  When I get a document that consistently reproduce the issue I will post it here for testing.  If I downgrade to 0.10.2 version I can open my notebooks.
Expected behavior
Documents open without errors
Screenshots
Version 1.0.0

Environment

OS: Windows 10
Extension Version 1.0.0

@m-tyler can you share the Notebook? It sounds like it might have been created with the old Notebooks extension and then you tried to open it with the new one, which isn't possible since we changed the format.

File Problem.inb was created on my set up versions of DB2 for IBM i version 0.10.2.
problem.inb.txt
File Problem_2.inb was created on my set up versions of DB2 for IBM i version 1.0.0.
Problem_2.inb.txt

At DB2 version 0.10.2
No connection to IBM i server.
Problem.inb opens.
Problem_2.inb will not open.
Once connected to a IBM i server
Problem.inb opens.
Problem_2.inb will not open.

At DB2 version 1.10.0
No connection to IBM i server.
Problem.inb will not open and I receive screen shot above.
Problem_2.inb will open.

Once connected to a IBM i server
Problem.inb will not open and I receive screen shot above.
Problem_2.inb will open.
I almost always create notebooks from scatch.  The one that is giving me problems and started this issue, was created last week using notebook extension version 0.0.6

Context
Version

Code for IBM i version
2.10.1

Visual Studio Code version
1.88.1

Operating System
win32_x64

Active extensions
Auto Hide (fork) (vscode-autohide-fork): 1.0.9
Calculator (calculator): 0.1.1
Code Spell Checker (code-spell-checker): 3.0.1
Code for IBM i Walkthroughs (vscode-ibmi-walkthroughs): 0.5.0
Db2 for IBM i (vscode-db2i): 1.0.0
Emmet (emmet): 1.0.0
Error Lens (errorlens): 3.17.0
Excel Viewer (gc-excelviewer): 4.2.59
Git (git): 1.0.0
Git Base (git-base): 1.0.0
GitHub (github): 0.0.1
GitHub Authentication (github-authentication): 0.0.2
Hawkeye Pathfinder (vscode-ibmi-hawkeye): 0.0.4
IBM i Debug (ibmidebug): 1.0.0
IBM i Notebooks (vscode-ibmi-notebooks): 0.0.6
JSON Language Features (json-language-features): 1.0.0
Merge Conflict (merge-conflict): 1.0.0
Node Debug Auto-attach (debug-auto-launch): 1.0.0
Overtype (overtype): 0.5.0
Partial Diff (partial-diff): 1.4.3
Rainbow CSV (rainbow-csv): 3.11.0
Rocket DevOps (rdo-vsc-ibmi): 10.3.1
TODO Highlight (vscode-todo-highlight): 1.0.5
Text Marker (Highlighter) (text-marker): 1.11.0
TypeScript and JavaScript Language Features (typescript-language-features): 1.0.0
classdiagram-ts (classdiagram-ts): 0.1.67
undefined (indent-rainbow): 8.3.1

Remote system

Setting
Value

IBM i OS
V7R5M0

Tech Refresh
3

CCSID Origin
user

Runtime CCSID
37

Default CCSID
37

SQL
Enabled

Source dates
Enabled

@m-tyler if you have the old Notebooks extension, it's time to remove it. There might be some clashing.

@m-tyler remove the old extension, and Notebooks is now shipped with the database extension.

Ah, thanks.  I didn't even look at the release notes for the DB2 update.  Sorry, my mistake.
How would I go about re-using old version notebooks with the new version code?  The issue still exists with the notebooks create using the standalone version 0.0.6.

For those that don't want to guess the patter is like the following.  I only had three "kinds" of records in my old note books.
Scan and replace
Old notebook pattern -> New notebook pattern replacement
"kind":1,"language":"markdown","value": ->"cell_type":"markdown","metadata":{},"source":
"kind":2,"language":"sql","value": ->"cell_type": "code","execution_count": null,"metadata": {"tags": ["sql"]},"outputs": [],"source":
"kind":2,"language":"cl","value": ->"cell_type": "code","execution_count": null,"metadata": {"tags": ["cl"]},"outputs": [],"source":

wrap the entire file before the outer most square brakets [...]  with {"cells":[...], "metadata": { "kernelspec": { "display_name": "DB2 for IBM i", "name": "db2i" }, "language_info": { "name": "sql", "file_extension": "sql" } }, "nbformat": 4, "nbformat_minor": 0 }


Helm3 cleanup tiller deploy doesnot work with Openshift Cluster

Output of helm version: helm v3.0.0
Output of kubectl version: v1.16.3
Cloud Provider/Platform (AKS, GKE, Minikube etc.): Openshift Container Platform Cluster in AWS
In Openshift DeploymentConfig name is tiller
By default helm execute the command background to delete the tiller deploy
kubectl delete -n  deploy/tiller-deploy (not found in oc cluster)
Any workaround?

It would help to get more information to better understand the issue.
Can you provide some background on what you are trying to do? Are you trying to remove Tiller?
What namespace is Tiller deployed in?
Command to remove Tiller (service and deployment):
kubectl delete -n <tillerNamespace> deploy/tiller-deploy
kubectl delete -n <tillerNamespace> service/tiller-deploy

Hi, @rkamisetti792 - As we have not heard back with more detail, we are closing this issue now. You said you used Helm 3 but also you mentioned tiller, so I want to ensure you know that Helm 2 (which had tiller) is ending support: https://helm.sh/blog/helm-v2-deprecation-timeline/ - please let us know if you need anything else. Thanks.


PC2: Champions Expand aura effect  for duration tracking.

it would be great if this could have an effect to track the duration of the expanded aura if possible.
many thanks if this can be done.

Consolidating into PC2 issues #15804


common: godoc comments fix in common/intefaces.go

Added whitespace to make the Overview section in godoc for package common render much nicer. Faces, Ables, etc., now are nice headings in godoc.
Also added punctuation to make the comments complete sentences.
Also reflowed the comments.

Changes Unknown when pulling 188e12e885f57a6e7d4f8b27145101f484429294 on jrmiller82:godoc-comments-fix-in-common into ** on EngoEngine:master**.

No idea why appveyor is failing... I literally only changed some comments. No code.

This can be fixed by closing and reopening the request sometimes. I'm going to try it.

Changes Unknown when pulling 188e12e885f57a6e7d4f8b27145101f484429294 on jrmiller82:godoc-comments-fix-in-common into ** on EngoEngine:master**.

Changes Unknown when pulling dbf0f1d7b978d14e80451d8f478429ca28b13dba on jrmiller82:godoc-comments-fix-in-common into ** on EngoEngine:master**.

Looks like that fixed it. Thanks!

Changes Unknown when pulling 58a8bc7349925f46017bfc2f19c7821bc15f37c3 on jrmiller82:godoc-comments-fix-in-common into ** on EngoEngine:master**.

Thank you for your contributions


Can't refresh Partitions or tables.

When I use this code it works great to refresh a dataset. But when I try to use the lines of code to refresh a particular table or partition.... it still seems to refresh the entire dataset. Here is the code I am referring to. Any help is greatly appreciated.
`
$type = "Full"                      # full, clearValues, calculate, dataOnly, [automatic], defragment
$commitMode = "transactional"        # [transactional], partialBatch
$maxParallelism = $null             # [10]
$retryCount = $null                 # [0]
$applyRefreshPolicy = "false"       # [true], false
$effectiveDate = $currentDateTime   # uses current server date time (UTC+0) unless specified
$objects = @"
{
"refresh": {
"type": "Full",
"objects": [
{
"database": "$datasetName",
"table": "DIM_I_Item_Type_CAT",
"partition": "DIM_I_Item_Type_CAT-398f922b-f0c1-45b4-b4fa-14123c127f38"
}
]
}
}
"@
###############Creates the paylod used in the API call to the service.
#!pwsh
$json =  [pscustomobject]@{}
if ($type) {
$json | Add-Member -NotePropertyMembers @{type = $type}
}
if ($commitMode) {
$json | Add-Member -NotePropertyMembers @{commitMode = $commitMode}
}
if ($maxParallelism) {
$json | Add-Member -NotePropertyMembers @{maxParallelism = $maxParallelism}
}
if ($retryCount) {
$json | Add-Member -NotePropertyMembers @{retryCount = $retryCount}
}
if ($applyRefreshPolicy) {
$json | Add-Member -NotePropertyMembers @{applyRefreshPolicy = $applyRefreshPolicy}
}
if ($effectiveDate) {
$json | Add-Member -NotePropertyMembers @{effectiveDate = $effectiveDate}
}
if ($objects) {
$json | Add-Member -NotePropertyMembers @{objects = (ConvertFrom-Json $objects).refresh.objects | Select-Object * -ExcludeProperty "database"} -Force
}
$bodyJson = ConvertTo-Json $json
$bodyJson`

It's a little tricky to say why it seems to not work for you, but there a couple things we can look at. Could you confirm:

You meet the requirements for refreshing like this (https://learn.microsoft.com/en-us/power-bi/connect-data/asynchronous-refresh#requirements), in particular is the dataset is running on premium?
If the dataset is backed by premium; what is the output for the step "Create payload"? It should look similar to:

{
  "type": "full",
  "commitMode": "transactional",
  "applyRefreshPolicy": "false",
  "effectiveDate": "2022-10-21T14:52:29.854980Z",
  "objects": {
    "table": "Table1",
    "partition": "Table1-0d2da98d-6fbf-4b2c-a97c-14e932a23fb6"
  }
}

thank you for your response. Yes I am on a P1 node (premium capacity). I've successfully  triggered the refresh for the whole dataset using a service principal account. It is just weird that I can't trigger a refresh on just 1 table or 1 partition. When I try, it still triggers a refresh on the whole dataset. Here is the payload:
{
"type":  "Full",
"commitMode":  "transactional",
"applyRefreshPolicy":  "false",
"effectiveDate":  "2022-10-21T08:59:32.385848Z",
"objects":  {
"table":  "DIM_I_Item_Type_CAT",
"partition":  "DIM_I_Item_Type_CAT-398f922b-f0c1-45b4-b4fa-14123c127f38"
}
}

I'm not sure why it Isn't working for you. The payload structure is correct, and it works for me when I do it (which I've just done right now). Are you able to refresh a single partition using another tool? SSMS or TE3?
The only other things I can think of are to check the XMLA endpoint setting so they are read/write, setting the dataset to large format mode and checking the account executing the command has read/write access on the dataset (i.e a workspace admin).
Hopefully, this helps? I'd be curious to hear back why you're not able to selectively refresh.

I think I found the problem (yes I can refresh partitions from tabular editor). I also got it to work when I simplify the code. When I inject the payload it does not have "square brackets in the payload". so the wrong payload currently looks like this:
{
"type": "Full",
"commitMode": "transactional",
"applyRefreshPolicy": "false",
"effectiveDate": "2022-10-21T08:59:32.385848Z",
"objects": {
"table": "DIM_I_Item_Type_CAT",
"partition": "DIM_I_Item_Type_CAT-398f922b-f0c1-45b4-b4fa-14123c127f38"
}
}
It needs to look likes this below from my understanding (notice the square brackets). When I do this it works:
{
"type": "Full",
"commitMode": "transactional",
"applyRefreshPolicy": "false",
"effectiveDate": "2022-10-21T08:59:32.385848Z",
"objects": [  #############NOTICE THE QUARE BRACKETS HERE##############################
{
"table": "DIM_I_Item_Type_CAT",
"partition": "DIM_I_Item_Type_CAT-398f922b-f0c1-45b4-b4fa-14123c127f38"
}
]  ##############AND HERE####################
}
I don't know how to inject the square brackets into the pay load? Can you help with this? Here is what needs to be updated to include the "Square" brackets:
$currentDateTime = (Get-Date -Format yyyy-MM-ddTHH:mm:ss.ffffffZ).ToString() # current local date time as if it was timezone UTC+0, which is the timezone used by Power BI Service
$type = "Full"                      # full, clearValues, calculate, dataOnly, [automatic], defragment
$commitMode = "transactional"        # [transactional], partialBatch
$maxParallelism = $null             # [10]
$retryCount = $null                 # [0]
$applyRefreshPolicy = "false"       # [true], false
$effectiveDate = $currentDateTime   # uses current server date time (UTC+0) unless specified
$objects = @"
{
"refresh": {
"type": "Full",
"objects": [
{
"database": "$datasetName",
"table": "DIM_I_Item_Type_CAT",
"partition": "DIM_I_Item_Type_CAT-398f922b-f0c1-45b4-b4fa-14123c127f38"
}
]
}
}
"@
$json =  [pscustomobject]@{}
if ($type) {
$json | Add-Member -NotePropertyMembers @{type = $type}
}
if ($commitMode) {
$json | Add-Member -NotePropertyMembers @{commitMode = $commitMode}
}
if ($maxParallelism) {
$json | Add-Member -NotePropertyMembers @{maxParallelism = $maxParallelism}
}
if ($retryCount) {
$json | Add-Member -NotePropertyMembers @{retryCount = $retryCount}
}
if ($applyRefreshPolicy) {
$json | Add-Member -NotePropertyMembers @{applyRefreshPolicy = $applyRefreshPolicy}
}
if ($effectiveDate) {
$json | Add-Member -NotePropertyMembers @{effectiveDate = $effectiveDate}
}
if ($objects) {
$json | Add-Member -NotePropertyMembers @{objects = (ConvertFrom-Json $objects).refresh.objects | Select-Object * -ExcludeProperty "database"} -Force
}
$bodyJson = ConvertTo-Json $json
$bodyJson

Thanks for reporting this! 👍
I've fixed the code to force the return of an array of objects rather than an object when there is only one table. Upon checking, this is correct behaviour in the docs and in line with what you've identified. I'm surprised it worked for me without this change🤷

Really appreciate your help. As you suggest it works perfect now. Thank you


Dielectric loss function

I have written some functionality to plot dielectric loss functions, which could be useful in the code.
A lot of the functionality is replication of the absorption plotting. I have taken the lazy route of copying and modifying the absorption routines rather than extending the existing routines.
I am not sure what your stance is on this. I would guess that the easiest route is to create a Pull Request and allow you to review the code and decide from there.

Hi @keeeto. This sounds awesome. Please submit a pull request we'll try and get it merged as soon as possible.

If you already have the changes on a branch of your own copy of the repo:

Make a fork on your own Github space with the "fork" button on the sumo project
Change your "origin" remote to point at your fork (git remote set-url origin <new-url>) and push up the changes
If you need to pull in any updates from our master you can add the upstream as another remote with git remote add upstream https://github.com/smtg-ucl/sumo.git (or something like that!) and update from it with e.g. git pull upstream master
When you push to your feature branch on Github, if you navigate to the Github page you'll see a little banner offering a button to make a pull request from your branch to the upstream project.

:) thanks I was literally looking this up on Goolge half an hour ago!

Ok, from the discussion on the pull request #23 , it looks like we should be supporting a wider range of optical properties. The suggested list was

Dielectric tensor (real and imaginary)
Refractive index
Optical conductivity
Absorption
Loss

As the plot options are essentially the same for all of these, these should be lumped together in a single plotter. The discussion also hits on possibilities for specifying multiple plots for double-y-axis plotting.
Personally, I'm not a big fan of double-y-axis plots for this kind of spectral data. If the y values aren't comparable, there's little gained by putting them on the same axes vs stacking separate axes.
I have two proposals:
1 Stacking up optional plots
Create a vertical sequence of all the requested plots. They could even be in the requested order:
sumo-optplot --xmax=10 absorption ri loss

Pros: simple to implement, predictable behaviour
Cons: Column could get unwieldy if you specify lots of plots, can't do any special combinations
2 All or one
Accept a single option for the plot type. Have a special case 'all' which does some nice arrangement of all of them. This could even be the default.

Pros: can use colour and layout in a more thoughtful way. More potential for "beautiful by default" which is the Sumo way.
Cons: Less adjustable. In practice, the "all" plot would be good during investigation and for presentations, but you'd usually want a combination of singles for paper publication.

Implemented in #23


Generate comparison tests between Babel-SAPBERT, NameRes and SciGraph

@gaurav To try to review it as well.

Thanks so much for your improvements, @hyi! This worked fine on my computer and is already way more useful than my version. Some thoughts, but I don't think any of these need to be addressed in this PR -- I think we should move any useful ideas into issues and then work on them in separate PRs:

Having some kind of general statistics would be helpful, such as what proportion of variables in each input file had at least one annotation for each method, how many annotations are of each Biolink type and of each CURIE prefix (UMLS, CHEBI, etc.) -- the former will tell us something about how the methods compare and about how useful the annotations they are generating are.
I would love to know how QuickUMLS compares with our tools, since it should be working similar to NameRes but is (1) UMLS only, and (2) really, really fast. Since every UMLS ID is in NodeNorm somewhere (whether as a concept by itself or cliqued with another concept), we should be able to map everything from it into UMLS, and it may be that it doesn't do as well as SAPBERT but is very fast and easy to set up.
The good news with UMLS is that having all the UMLS synonyms seems to be really helpful to correctly identifying very specific concepts (e.g. Annotated "prolonged ventricular excitation" to UMLS:C0860151: UMLS:C0860151 (Prolonged ventricular repolarisation, score: 0.286241173744)), but the downside is that we don't know much about these concepts in the knowledge graph. That is something we could try fixing elsewhere (improve cliquing in NodeNorm, improve connections in ROBOKOP) but I wonder if there's something we could do to find better identifiers with all the synonymy information we have?

I wonder if this is something SAPBERT could help us with -- should we try asking what the closest non-UMLS concept is and see if that helps?

Looking at the output files, I'm very pleased at how well NameRes seems to be doing :). SAPBERT looks like it's getting confused by some of the larger, more complicated chemical names, but otherwise seems fine. SciGraph stills seems to be doing better than our tooling (e.g. SciGraph annotates "Angiotensin II" as CHEBI:48432, but NameRes misses it entirely -- although NameRes does find it if you search for it directly, so maybe the problem here is that BioMegatron is missing it? SAPBERT finds UMLS:C0920394, "angiotensin hypertension", score: 0.349252104759, which is better than nothing.)
I think the next thing is figuring out where we're doing well, where we're doing badly, and how we could do better :) A tall order, but Hong's changes are definitely moving us in the right direction!


Add support for UnifiedPush

This might also be an alternative or addition for #104.
Maybe at some point "UnifiedPush" could be used as an alternative for Firebase Cloud Messaging for de-googled phones, or just people preferring it:
UnifiedPush: https://unifiedpush.org/
UnifiedPush Github: https://github.com/UnifiedPush
This could work for de-googled phones but save battery compared to time-based polling.
If needed, they also have a fallback implementation for phones that have FCM, but also preferred UnifiedPush: https://unifiedpush.org/developers/embedded_fcm/
As a non-programmer I have no estimate on how much work this might be, but considering that you do consider time-based polling, maybe this is also a viable solution.
Thank you either way!

@Fenrikur we can assess this solution and maybe include something for next EF

From what I can tell that's no iOS compatibility with this library.


Fix callsign null check

In the Chase Mode section, if "Enable" is toggled before a callsign is first set, then an exception occurs and the user gets no feedback:

Uncaught TypeError: callsign is null

This only happens if a callsign has never been set, and therefore no callsign value exists in local storage.
I've fixed the null check so that the user gets an alert popup when no callsign has been set.

Cheers!


Fix linting errors

Fixes the linting errors that were not previously addressed.
The Makefile targets were adjusted or corrected to fit our needs and
integrated into our CI workflow. The configuration files were also
updated accordingly.
A new task was added to automatically reformat markdown files using
prettier.

It also fixes all the CI violations. ✅

Are we sure we want to be modifying the files in docs/themes/adidoks? I was under the impression that these were vendored.

Are we sure we want to be modifying the files in docs/themes/adidoks? I was under the impression that these were vendored.

They are not really vendored, they are just there because I dislike using submodules (which is the recommended approach). So I copy pasted the theme instead.
But we can totally create a .prettierignore file and add this folder to it if you'd want.

@bradbeck And done ✅


Disable OUSD for now

@shahthepro did this end up happening? Should we re-enable it now that OUSD is back?

I don't remember if we ever made this change. Let me check and get back

I'd say reenable it if it's not much work. Either way, let's close this after we confirm the status.

@micahalcorn Just checked the code, my bad, I didn't disable that.

No problem, let's just leave it in place, thanks.


[security] Rancher server image comes with known vulnerabilities

Rancher Versions:
Server: 1.6.0
The image rancher/server:v1.6.0 (Image ID f0ed20ddb71d) from Docker hub contains vulnerabilities.
The package libc6 2.19-0ubuntu6.7 is installed, whereas 2.19-0ubuntu6.11 is available:
# apt-cache policy libc6
libc6:
  Installed: 2.19-0ubuntu6.7
  Candidate: 2.19-0ubuntu6.11
  Version table:
     2.19-0ubuntu6.11 0
        500 http://archive.ubuntu.com/ubuntu/ trusty-updates/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu/ trusty-security/main amd64 Packages
 *** 2.19-0ubuntu6.7 0
        100 /var/lib/dpkg/status
     2.19-0ubuntu6 0
        500 http://archive.ubuntu.com/ubuntu/ trusty/main amd64 Packages

Check Ubuntu Security Notice USN-3239-1 for vulnerability details and CVE numbers.
https://www.ubuntu.com/usn/usn-3239-1/

Can you please fix your Rancher server image?
According to Docker hub statistics the server image is very popular and I suppose a lot of people use it in production.

Fixed in v1.6.22


Support nullable types

As per PHP 7.1, it is possible to define nullability of a type by adding a ? in front of it ( https://wiki.php.net/rfc/nullable_types ).
A few heads-up:

careful about ?Foo $bar = null vs ?Foo $bar vs Foo $bar = null
need to eventually patch the TypeGenerator to include the ? in it (not sure yet)

Surely resolving the fact that Zend\Code\Scanner\MethodScanner doesn't properly handle scalar type declarations should come before supporting nullable types? #56 still hasn't received any acknowledgement.

@djmattyg007 I reported the issue completely independently from other issues.

My point was that PHP 7.0 compatibility should be targeted before PHP 7.1 compatibility.

Ah yes, that is because the codegen part of this component is already 7.0 compatible. I hardly ever use the scanner, as it is not AST-based (which makes it very unstable)

If no one is maintaining the scanning code, shouldn't it be removed?

This repository has been closed and moved to laminas/laminas-code; a new issue has been opened at https://github.com/laminas/laminas-code/issues/19.


Shoot cannot be created due to a a race condition with the shoot state

How to categorize this issue?

/kind bug
/priority 3
What happened:
A cluster that was running several days was deleted.
Directly after the cluster was deleted a new cluster with the same name has been created.
Gardener was unable to create the new shoot due to a already existing shoot state resource with a different owner. (see below for a concrete error message).
my assumption:
I suspect that gardener relies on the k8s garbage collection for the shoot state deletion after the owning shoot is deleted.
But if the garbage collection does not happen before a shoot with the same name is created, the old state conflicts with the new shoot.
Detailed err message:
Flow "Shoot cluster deletion" encountered task errors: [task "Ensuring that ShootState exists" failed: retry failed with context deadline exceeded, last error: ShootState.core.gardener.cloud "myshoot" is invalid: metadata.ownerReferences: Invalid value: []v1.OwnerReference{v1.OwnerReference{APIVersion:"core.gardener.cloud/v1beta1", Kind:"Shoot", Name:"myshoot", UID:"7ca9d19a-4d5c-43ef-8b9e-fa80dafc179a", Controller:(*bool)(0xc0a3bc3a80), BlockOwnerDeletion:(*bool)(0xc0a3bc3a81)}, v1.OwnerReference{APIVersion:"core.gardener.cloud/v1beta1", Kind:"Shoot", Name:"myshoot", UID:"b75f622a-469c-4a23-9747-d054d3715a11", Controller:(*bool)(0xc0a3bc3a82), BlockOwnerDeletion:(*bool)(0xc0a3bc3a83)}}: Only one reference can have Controller set to true. Found "true" in references for myshoot and myshoot] Operation will be retried.

What you expected to happen:
The shoot state should get cleaned up before the shoot resource is deleted.
How to reproduce it (as minimally and precisely as possible):

Create a shoot named shoot-abc
Delete that shoot and directly afterwards create a new shoot with the same name.

Anything else we need to know?:
Environment:

Gardener version: v1.21.0
Kubernetes version (use kubectl version): 1.20.5
Cloud provider or hardware configuration: GCP

Can you please share some relevant logs of the GC controller in KCM?

Do you also need the kcm logs of a successfull run when the kcm was able to delete the shootstate.
kcm-shootstate-gc.log
Sidenote: I needed approx. 5 retires until I could reproduce the issue with increased verbosity.

We discussed this issue in the core quality round. Results:

In the above log we see "ts-test" is forbidden: shoot ts-test in namespace garden-core still exists which shows that the garbage collector tries to delete the shootstate but an admission plugin prevents that

Way forward:

No longer rely on the garbage collector but delete shoot state explicitly as part of the shoot deletion flow.
Delete validateShootStateDeletion admission plugin - as it would no longer work (shoot resource will still exist when shoot state is deleted).
Use deletion confirmation plugin if we want to make sure that the state is deleted.

Thanks @schrodit for the detailed issue including logs and a script to reproduce it 👍🏼

@BeckerMax are you working on this?

Yes, I would like to finish it. Hopefully today.

Ok, great 👍
/assign @BeckerMax

This situation still occurs.

@valentinvieriu yes, and as you can see from the linked PR, we are currently working on a fix :)


Branch not found for "master/README.md"

Category
What is the current behavior?
I've a private github repository shared with some collaborators, after gitbook upgrade, I'm getting this error, endlessly.  The editor then keeps refreshing and send me to README.md (introduction) page

Additional information
For the GitBook Editor:

Operating System:  Kubuntu 16.04.2 LTS
(Desktop) Version of the Editor:  7.0.11

The issue exists in 7.0.12 as well

Just to be sure, do you have a master branch in your repository?
How did you import the repository in the Editor?
Is the repository linked on GitBook.com as well?

Hi
Yes I do, I use and sync it for days once someone contribute to it, i bull
the changes, at that time I get the error
On 20 March 2017 at 13:42, Nicolas Gaborit<EMAIL_ADDRESS>wrote:

Just to be sure, do you have a master branch in your repository?
How did you import the repository in the Editor?
Is the repository linked on GitBook.com as well?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GitbookIO/feedback/issues/421#issuecomment-287725121,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABBa0-N4uC_8r12ZdEHRMH09uHJVqIdgks5rnlgAgaJpZM4Mar69
.

--
*Senior Information Security Engineer OSCE, GWAPT, **CEH, **OSCP, **RHCE, *
*CCNA, *MCITP-EA

Same here ... Simply created a gitbook started in online editor to write - switched to desktop editor (osx). While syncing im getting endless messages "Branch not found for master/README.md". Master branch already exists. Sync runs forever.

When I edit gitbook in browser (Chrome), the cursor position is incorrect so I actually could NOT edit at all, then I switch to gitbook editor, the syncing doesn't work, so now I couldn't update my gitbook at all, so frastrated.

Well, I found a workaround to this issue (On Mac):

Open Gitbook Editor, go to the "FILES" tab on the left menu.
Select one file, right click it and select "Reveal in Finder"
Now you know where the files are, for me, the path is "~/GitBook/Library/MY_ORAG_NAME/DOC_NAME",
It is a normal git repo, so you could perform "git pull", "git push" as you want, that solved my "syncing" problem.

Similar problem. Normal use, one user, no branches. When a regular file is created and saved and synced I get the  same forever syncing issue.
git status in the git book repo reports all up to date but github repo does not contain latest changes. I think the push isn't happening.
git pull origin master complains that the remote is ahead of the local repo. It isn't. Pulling in these supposed upstream changes seems to make the sync work again.

Same here, WIN 10, 1 user, no branches.

same problem :(

same here

We are currently evaluating Gitbook to be used for all documentations.
The fact, that a WYSYWIG-Editor is available that hides at least some of the markdown and git details for non-technical users, is the top driver for choosing this solution.
However, this issue turns out to be a serious knock-out-problem for the entire approach.
And even more troublesome is, that nobody from the developers has responded at all in 6 months.
So sad...

Hi everyone,
Can someone provide more info on their environment and specific steps to reproduce ?
So I can look into backporting a fix before the new release is out.

@KINGSABRI @1stone @dmks If I recall correctly this should only happen if the user deleted their local master branch (which we assume not to be a common / normal thing).
Did you delete your master branch or use an alternative branch as your main branch ?

@AaronO: Thanks for responding.
I have a perfectly valid local master branch in a simple plain repository (no other branches yet).
This problem happens always, with every book I started so far.
As long as I'm the only one working on this book, everything is fine.
I can commit changes and push them to the remote repo.
But as soon as there is a commit from another person (using exactly the same Gitbook setup), the editor goes mad, as described by @KINGSABRI initially.

yes, I have same problem

@AaronO:
Is there anything that can be done to get this issue resolved?
Our impression is, that this issue is open for far to long and nobody seems to really care.
With multiple persons collaborating on the same documents, this issue renders the entire gitbook editor unusable to us.

The Gitbook folks are obviously not interested in fixing this, nor enter into discussion to narrow the problem.
After another 2 months of total inactivity in this matter - and actually any gitbook activity - I'm giving up on gitbook entirely.
It's a brilliant concept that would perfectly match many use cases, but without support or community around it, it's just a waste of time - so sad!

@1stone If you're available to jump on a call today or early next week, I would love to.
The whole team has been crazy busy working on the new release: https://beta.gitbook.com/
The beta product itself is mostly finished, most efforts are now concentrated on migrating and getting it live for most of our users.
The main issue preventing us from fixing this issue is insufficient context/information:

Precise "steps to reproduce"
Videos / screenshots

It's extremely hard to fix an issue without being able to reproduce it and without accurate info from the team. So if you're willing to jump on a call and show me, I'll do my best to look into the cause and backport a fix.

No problem
I started again from a blanc document and works fine
Yo can close messague
Thanks
Diego Rodríguez
www.arketipo.net
@arketipo
On 17 nov 2017 11:14 +0100, AaronO<EMAIL_ADDRESS>wrote:

@1stone If you're available to jump on a call today or early next week, I would love to.
The whole team has been crazy busy working on the new release: https://beta.gitbook.com/
The beta product itself is mostly finished, most efforts are now concentrated on migrating and getting it live for most of our users.
The main issue preventing us from fixing this issue is insufficient context/information:

Precise "steps to reproduce"
Videos / screenshots

It's extremely hard to fix an issue without being able to reproduce it and without accurate info from the team. So if you're willing to jump on a call and show me, I'll do my best to look into the cause and backport a fix.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


./configure fails when submodules aren't cloned

When one forget to run git submodule init && git submodule update, the submodules folders will stay empty and ./configure will fail.
I think we should always have submodules directories available when cloning xrdp.
Suggested solutions so far:

adotp bootstrap
use git subtree instead of git submodule

This one is not for v0.9.1

I think we should trigger submodules clone somehow (maybe in
configure or bootstrap)

No. The build is VCS-agnostic.
If you want to circumvent this issue, use git subtree instead!

+1 to subtree

subtree is great as we talked in gitter chat.

Actually, bootstrap is not part of the normal build. It's a developer's tool.

PR #587 submitted, please review.

An alternative fix is #593 - convert submodules to subtrees. Subtrees would be always there, they are part of the top-level repository.

Switching to subtree is an good idea but this issue is now solved by #587.


Upgrade to Fluentd version 1.0 APIs

Hi @wanderaBrno @jojand ,
This plugin is using very old version of Fluentd and needs an upgrade. Please consider upgrading to Fluentd version v1 APIs as there are some changes from the previous versions and old plugins are not compatible with the latest version of Fluentd. Please check the below link for more details.
Upgrade Plugin from v0.12
Please let me know the plan, otherwise I am willing to contribute.

hi @apu1111, there is new version which may help you.


Fixbug/support mysql lower

Summary

修改mysql时间处理，不使用mysql默认，通过程序传入
解决fisco bcos1.3 执行问题

Codecov Report

Merging #102 into develop will decrease coverage by 0.02%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             develop     #102      +/-   ##
=============================================
- Coverage       45.2%   45.18%   -0.03%
  Complexity      1348     1348
=============================================
  Files            180      180
  Lines           9848     9853       +5
  Branches        1251     1251
=============================================
  Hits            4452     4452
- Misses          4895     4900       +5
  Partials         501      501

Impacted Files
Coverage Δ
Complexity Δ

...webank/weid/suite/persistence/sql/SqlExecutor.java
1.43% <ø> (ø)
1 <0> (ø)
:arrow_down:

...m/webank/weid/suite/persistence/sql/SqlDomain.java
51.02% <0%> (-1.07%)
6 <0> (ø)

...weid/suite/persistence/sql/driver/MysqlDriver.java
46.84% <0%> (-1.76%)
15 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25d479e...0f4c45c. Read the comment docs.


wrenEnsureSlots in foreign methods can occasionally corrupt the stack

As discussed on discord, we found a case where wrenEnsureSlots seems to cause a stack corruption.
It runs the method correctly once, but the second time it calls it, the value of the second argument seems to be incorrect.
https://gist.github.com/avivbeeri/6896e8d77c17123e03154a52fb0308f8

In practice wrenEnsureSlots only works reliably when setting up a fiber.
I addressed some patch in the past for this issue. It was mitigated using
another patch which I warned was not complete, but the real fix is
performance expensive... So this issue pops up from time to time.


Allow support of crystals other than 12MHz (#1024)

Improve the current hardcoded PLL and clock set-up

I have just pushed some changes for comment which I think address the XOSC and system frequency related hard-codings in the SDK.
Making set_sys_clock_pll() and check_sys_clock_khz() properly general purpose wasn’t possible without changing their APIs so, for now, I left them: This is because neither of them currently support ’refdiv’ setting other than 1.  I have coned a new #define to keep things in step along with a tripwire to enforce this.
Having used vcocalc.py it is not clear to me that refdiv settings other than 1 can sensibly be used anyway.
A few ‘pico-examples’ will need updating to use the definitions I have added to platform_defs.h

This looks good to me, apart from the btstack related commit

This looks good to me, apart from the btstack related commit
Thanks and agreed.  I found I could not push to my branch because there was another push that I hadn't got locally.
So I did a 'git pull --rebase' and then a push.  It was not enough for me to rebase my local branch from develop which is what I also tried.

This looks good to me, apart from the btstack related commit

Thanks and agreed. I found I could not push to my branch because there was another push that I hadn't got locally. So I did a 'git pull --rebase' and then a push. It was not enough for me to rebase my local branch from develop which is what I also tried.

well you have picked up some other stuff it seems (bt license)

The tag::pll_settings block has now been totally removed - could it (or something very similar) be restored please? As a reminder, it gets auto-included into Section 2.18.3. of https://datasheets.raspberrypi.com/rp2040/rp2040-datasheet.pdf

fixes #1024


Provide explanation on how to build

No parser.c in src. README could contain how to generate it!

tree-sitter generate --no-bindings

tree-sitter generate --no-bindings

i know now, but it would be good to have it in the readme. i don’t think an argument for this is necessary.


[Bug]: Can't see or select "Disabled" page in Bulk Page Add

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
As an admin, when I go to use "Add Multiple Pages", if the page that I want to add pages to is disabled, it doesn't appear in the tree view / page picker.

Steps to reproduce?

Add a page to the root level of the site. Make sure this page is not "Enabled" by toggling it off.
Go to "Add Multiple Pages" and then try to find the Branch Parent.

You won't be able to see it because it doesn't appear if it's disabled.
Current Behavior
Under Add Multiple Pages, if the branch parent is disabled (via page settings), you can't see let alone select it when adding child pages. If you want to add child pages, you have to first "Enable" the page, add them, and then disable the page.
I often have top level parent pages that are not enabled because I use a click menu.
Expected Behavior
You should be able to find and select branch parent's regardless if they are enabled or not.
Relevant log output
No response
Anything else?
No response
Affected Versions
9.13.3 (latest release)
What browsers are you seeing the problem on?
Firefox, Chrome, Safari, Microsoft Edge
Code of Conduct

[X] I agree to follow this project's Code of Conduct

this is a long standing issue


Tag workflowcheck

Describe the solution you'd like
Create a new contrib/tools/workflowcheck/v0.1.0 tag for a table reference point on workflow check.

workflowcheck  is tagged as contrib/tools/workflowcheck/v0.1.0


Use reflection for security check on interface implementation

Fixing php7+ which hard-crash on a constructor with inappropriate arguments

Previous pull request had a brainfart in it...


Provide a way to get method parameter modifiers

There seems to be no way to get modifiers for method parameters, equivalent to java.lang.reflect.Parameter#getModifiers.
In general, there seems to be no way to get info on parameters beyond the name and type...
I'm specifically trying to figure out if a parameter is implicit (java.lang.reflect.Parameter#isImplicit) or synthetic (java.lang.reflect.Parameter#isSynthetic).

There's been some work to handle synthetic parameters better (see #45 and #48), but indeed that hasn't been finished yet.

I'm looking into this and I think I know why parameter flags are not exposed... They are almost never present in bytecode in the first place. They are only present in bytecode when javac is invoked with the -parameters option. This is also why the java.lang.reflect.Parameter methods you mention are often unreliable.

I'm aware the -parameters flag is required to keep names in the bytecode, but Javadoc for e.g. isImplicit() mentions nothing about this info potentially not being available. For contrast, the docs for getName() clearly state the name may be synthesized.
Either way, I use -parameters in my own projects, so support for that would still be welcome. But if really no useful info is available without -parameters, I'd understand if you decided it isn't worth the effort.

I have a nearly finished PR for handling mandated/synthetic parameters uniformly: #192. The final decision is for the most common parameter-related methods on MethodInfo to pretend that mandated and synthetic parameters don't exist [1]. Interestingly, this is also how parameter names and annotations are indexed in bytecode. There will be a way to access the full list of types as present in the method descriptor, but those types can't be correlated with parameter names or annotations.
[1] This is actually surprisingly easy, because Jandex has already been doing that for methods that have the Signature attribute in bytecode. So for methods that use type variables in their signature, this is already how Jandex behaves. Note that javac emits the Signature attribute in other situations, too, e.g. for constructors of local/anonymous classes. In case the method doesn't have the Signature attribute, Jandex will employ a simple heuristic that covers the most important cases: constructors of enums and non-static member classes. This won't work perfectly for constructors of local/anonymous classes compiled with ecj, but I believe that's acceptable. See also https://github.com/wildfly/jandex/issues/45#issuecomment-1109980774.
Hence, closing this.
BTW, here's a simple test class to verify whether isImplicit and isSynthetic work:
public class Test {
  public enum MyEnum { INSTANCE }

  public class Inner {
    public Inner(int ignored) {
    }
  }

  public static void main(String[] args) {
    System.out.println(MyEnum.class.getDeclaredConstructors()[0]);
    System.out.println(MyEnum.class.getDeclaredConstructors()[0].getParameters()[0]);
    System.out.println(MyEnum.class.getDeclaredConstructors()[0].getParameters()[0].isImplicit());
    System.out.println(MyEnum.class.getDeclaredConstructors()[0].getParameters()[0].isSynthetic());

    Inner inner = new Test().new Inner(42);
    System.out.println(inner.getClass().getDeclaredConstructors()[0]);
    System.out.println(inner.getClass().getDeclaredConstructors()[0].getParameters()[0]);
    System.out.println(inner.getClass().getDeclaredConstructors()[0].getParameters()[0].isImplicit());
    System.out.println(inner.getClass().getDeclaredConstructors()[0].getParameters()[0].isSynthetic());
  }
}

When compiled without -parameters, this program prints:
private Test$MyEnum(java.lang.String,int)
java.lang.String arg0
false
false
public Test$Inner(Test,int)
Test arg0
false
false

When compiled with -parameters, this program prints:
private Test$MyEnum(java.lang.String,int)
 java.lang.String $enum$name
false
true
public Test$Inner(Test,int)
final Test this$0
true
false

So, really, isImplicit and isSynthetic only work when compiled with -parameters.

For historical reference, JDK 21 fixes the bug that Parameter.isImplicit() and isSynthetic() only work when compiled with -parameters: https://bugs.openjdk.org/browse/JDK-8292275


Firefox: FontAwesome Icons gone missing?

Hey, on my Docker build the font awesome icons are all missing, and console has a whole lotta this:
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://use.fontawesome.com/releases/v5.15.1/webfonts/fa-solid-900.ttf. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing).

downloadable font: download failed (font-family: "Font Awesome 5 Free" style:normal weight:900 stretch:100 src index:3): bad URI or cross-site access not allowed source: https://use.fontawesome.com/releases/v5.15.1/webfonts/fa-solid-900.ttf
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://use.fontawesome.com/releases/v5.15.1/webfonts/fa-regular-400.ttf. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing).

downloadable font: download failed (font-family: "Font Awesome 5 Free" style:normal weight:400 stretch:100 src index:3): bad URI or cross-site access not allowed source: https://use.fontawesome.com/releases/v5.15.1/webfonts/fa-regular-400.ttf

I thought it was due to some changes to snippet bar I made on a branch, but having the same issue on my master branch that I haven't touched besides merging upstream/master into it.  Also, it's ALL icons, not just in the snippet bar.

I saw a few cross-site cookie warnings for font-awrsome the other day. They seem to have gone away now. I suspect a hiccup with them changing their hosting arrangement. Give it a day, see if issue persists.

@Gazook89 is this still an issue on the Docker stuff?

I found this question/answer on the mozilla forums regarding this.  I was wrong when I opened this issue-- it's not a Docker thing, it's a Firefox thing and at the time it didn't even occur to me to try it in Chrome.
The above link offers a solution (changing a flag privacy.file_unique_origin to false) but that solution no longer works as of FF 95(?).   I think the only solution now is to host the fontawesome icons we need directly on HB?  I'm not sure how that works, but looks like you can download a subset/"kit" of their icons and just host like a font?
This is merely a local development with firefox issue, so not a big deal probably for most people, though I would appreciate it :)

The Proxying solution in #3501 could be leveraged here.

If we wanted to host the FA icons we are using, here is a list of those icons and where they are found.  I wasn't sure if the FA website would tell you which icons you were actively using it, which would make it easy to turn into a 'kit' and download.  I skipped .../fontAwesome.js and .../snippets.js for now.   If we are going to self host the font, might as well self-host the whole set so emojis will also work for firefox people.
Let's not shard the font-awesome icons into partially self-hosted and partially remote.

Ah, right, i forget about the emojis.  I know we've talked about it, but apparently only on gitter (or at least not in this thread).  Thanks for reminder.
In which case, it should be even easier.


[gitbase] add chart for plain gitbase

Heavily based on gitbase-web chart.
Signed-off-by: Santiago M. Mola<EMAIL_ADDRESS>

@rporres AFAIK Ingress is not supported for non-HTTP? https://github.com/kubernetes/kubernetes/issues/23291

@rporres AFAIK Ingress is not supported for non-HTTP? kubernetes/kubernetes#23291

You're totally right. I'm sorry. I somehow mixed things. This doesn't need an in


tests: add integration test for 2.8.0

For quicker reference, it looks like this is the only failure:
=== RUN   TestTargetMarkHealthy
    target_service_test.go:251:
        	Error Trace:	target_service_test.go:251
        	Error:      	Expected nil, but got: &kong.APIError{httpCode:400, message:"no healthchecker found for vhost1.com"}
        	Test:       	TestTargetMarkHealthy
--- FAIL: TestTargetMarkHealthy (0.02s)
=== RUN   TestTargetMarkUnhealthy
    target_service_test.go:282:
        	Error Trace:	target_service_test.go:282
        	Error:      	Expected nil, but got: &kong.APIError{httpCode:400, message:"no healthchecker found for vhost1.com"}
        	Test:       	TestTargetMarkUnhealthy

Looks like a new API response in 2.8, but didn't check further to confirm.


Not working - Authentication is required

The installation worked fine but when I prompt the chat it respond that an error occurred and I have to authenticate at openai.com

Ok, I opened another tab and authenticated my self. Now it's working!


Sparse fieldsets not working with included relationships

Sparse fieldset requests don't seem to be working with included relationships... /api/v1/images?include=places&fields[places]=name,slug returns all attributes for places, instead of just name and slug, as JSON:API specifies here.

@hayespdx I'm going to need more info about this, as I cannot reproduce. Today I've written the sparse fieldsets section for the tutorial I've just added to the docs, and it was working for me in the tutorial application. There's also a sparse fieldsets PHP Unit test, which is passing.
Can you double check? Not sure what else to suggest without more detail or debugging as to what the problem might be.

Hey, I've just encountered a similar thing today. Instead of returning all fields, I get no included models:
GET /api/v2/patients/80?include=person&fields[patients]=status,careDegree
yields a single patient record, with no other records included:
{
    "jsonapi": {
        "version": "1.0"
    },
    "links": {
        "self": "http://localhost:8080/api/v2/patients/80"
    },
    "data": {
        "type": "patients",
        "id": "80",
        "attributes": {
            "status": "active",
            "careDegree": "pg2"
        },
        "links": {
            "self": "http://localhost:8080/api/v2/patients/80"
        }
    }
}

If I remove the fields parameter this is what I get instead:
{
    "jsonapi": {
        "version": "1.0"
    },
    "links": {
        "self": "http://localhost:8080/api/v2/patients/80"
    },
    "data": {
        "type": "patients",
        "id": "80",
        "attributes": {
            "status": "active",
            "careDegree": "pg2",
            "careDegreeSince": null,
            "insuranceNumber": "R286336113",
            "initialContact": "other",
            "createdAt": "2013-05-21T00:00:00.000000Z",
            "updatedAt": "2022-01-31T16:37:11.000000Z",
            "deletedAt": null
        },
        "relationships": {
            "person": {
                "links": {
                    "related": "http://localhost:8080/api/v2/patients/80/person",
                    "self": "http://localhost:8080/api/v2/patients/80/relationships/person"
                },
                "data": {
                    "type": "people",
                    "id": "80"
                }
            }
        },
        "links": {
            "self": "http://localhost:8080/api/v2/patients/80"
        }
    },
    "included": [
        {
            "type": "people",
            "id": "80",
            "attributes": {
                "firstName": "John",
                "lastName": "Doe",
                "listName": "Doe, John",
                "bornAt": "2013-06-01T00:00:00.000000Z",
                "iban": null,
                "bic": null,
                "createdAt": "2013-05-21T00:00:00.000000Z",
                "updatedAt": "2022-01-31T16:36:53.000000Z",
                "deletedAt": null
            },
            "relationships": {
                "address": {
                    "links": {
                        "related": "http://localhost:8080/api/v2/people/80/address",
                        "self": "http://localhost:8080/api/v2/people/80/relationships/address"
                    }
                }
            },
            "links": {
                "self": "http://localhost:8080/api/v2/people/80"
            }
        }
    ]
}

@spaceemotion yes your edited query is correct. If you want to include the person relation, you need the linkage from patients to be shown, which means you need to request the person relationship field in the patients resource.

Closing this due to no further follow up needed on it afaik.


hide filter form above search results

@norm @mannickutd @TheUKDave

:+1 waiting for a successful build.


navigation shortcuts

When in editor, can we have navigation shortcuts like alt+up and alt+down?
Further, here is some inspiration, in case you want to become the coolest guy in town :-)
Codebrowser (use v. 4.9, later versions dont support relative indentation)
One can navigate into Sections using alt+right/left!

My current workaround is to install the Block Travel plugin (currently v 0.0.2, it is small, two code files) and replace its block.js with the attached one (please change the extension from .txt to .js).
It works only for python style comments, if you want more functionality, tweak the isComment function in that file according to your needs.
blocks.txt

I'd also love to see this

I also feel there is a need to have some sort of shortcut navigation especially when you have large & long codes. I use ANCHOR, FIXME & TODO a lot. Wish there are ways to navigate. At least have the option to focus the comment anchor sidebar, and then we can use keyboard to navigate from there then switch back to editor, all done by shortcuts. I really wish this come true.

My apologies for the long wait, I've finally had time to implement this functionality and it will be available in the next release.


Fix for ESP text in incorrect place

role back of parentheses I included in UIHelper DrawString to please StyleCop as it made the string placement off. also including newest update libs as of 3/10/23 update.

It's working properly now.


K.Dᴀᴠɪs: Watch drozhelp.com

K.Dᴀᴠɪs requests the watch of the watch_keyword drozhelp\.com. See the Metasmoke search here and the Stack Exchange search here.

drozhelp.com has been seen in 4 true positives, 0 false positives, and 0 NAAs.

This is already watched.
$ grep -iFs drozhelp *.txt
watched_keywords.txt:1519648329	WELZ	drozhelp\.com


Cannot launch Nyxt 2.2.4 web browser

Describe the bug
A fresh installation of Nyxt 2.2.4 crashes at startup, and throws a Lisp debugger.
Steps To Reproduce
Steps to reproduce the behavior:

Add nyxt to environment.systemPackages
Launch nyxt from the command line
The following error is thrown: $ nyxt --verbose
Arguments parsed: (VERBOSE T URLS NIL) and NIL
<INFO> [11:48:36] nyxt start.lisp (listen-or-query-socket) -
Listening to socket "/run/user/1000/nyxt/nyxt.socket".
Nyxt version 2.2.4
<DEBUG> [11:48:36] nyxt start.lisp (load-lisp unsafe-load) -
Lisp file "/home/loren/.config/nyxt/auto-config.lisp" does not exist.
<DEBUG> [11:48:36] nyxt start.lisp (load-lisp unsafe-load) -
Lisp file "/home/loren/.config/nyxt/init.lisp" does not exist.
<DEBUG> [11:48:36] nyxt gtk.lisp (ffi-initialize gtk-browser) -
Initializing GTK Interface
fatal error encountered in SBCL pid 794764 tid 794875:
SIGABRT received.

Welcome to LDB, a low-level debugger for the Lisp runtime environment.
ldb>

Expected behavior
I expect Nyxt to open normally.
Notify maintainers
@nlewo
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.19.0, NixOS, 22.11 (Raccoon), 22.11pre397509.168d1c57890`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.10.3`
 - channels(loren): `""`
 - channels(root): `"nixos, nixos-unstable, unstable"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Thanks a lot for the effort @sbruder !


Power on not work since V3.19.7

Hi,
my VU+ Box doesn‘t Power on since V3.19.7. Go back to 3.19.6 and it works. Power off, Volume and switch channels perfectly working.
thx

Fixed in 3.19.12


Need Help - Did not create the api in the localhost:3000/

Hi,
Need help, Creating the chaincode was succesful but,
Running the command
npx lerna run dev:debug --scope myapp --stream
did not create the api in the localhost:3000/
Let me know something is missed
Result returned when running the command:
myapp: [nodemon] starting node -r ts-node/register --inspect-brk server/index.ts
myapp: Debugger listening on ws://<IP_ADDRESS>:9229/3e467566-5a70-441e-8509-a8f0c4b96d14
myapp: For help see https://nodejs.org/en/docs/inspector

it worked for me only for
npx lerna run dev --scope myapp --stream


Immediate, infinite recursion when configuration loader is set to boot and reloading is disabled

With the fix in #1399, it appears there was a regression introduced when using the following configuration, which is a use case where you'd want to load the configuration at boot, and never reload:
# load configuration at boot
APICAST_CONFIGURATION_LOADER: boot

# disable configuration refresh
APICAST_CONFIGURATION_CACHE:  -1

Prior to the fix for the above bug, the only way the configuration_loader executed the schedule method was if interval > 0 then, which would then refresh the configuration at whatever positive interval was defined in APICAST_CONFIGURATION_CACHE.
The changes introduced here make it so that even when you have refresh disabled via a negative number as documented here, this logic will always call the schedule method, and ultimately ngx.timer.at with a delay of -1 because the schedule method is recursive and uses the ttl, which will cause the timer to expire immediately (the same as a 0 value delay which is not an edge-case seen in APIcast since that's not valid with boot configuration) executing the callback immediately, and infinitely reloading the configuration.
This ultimately causes CPU and other resource consumption issues, and when done remotely has network and request implications trying to fetch the config.
Version
nginx version: openresty/<IP_ADDRESS>
quay.io/3scale/apicast-ci:openresty-1.21.4-1: 2024-04-29T20:39:47.030811444+10:00

Steps To Reproduce

make development
make dependencies
Ensure this config [1] exists at /opt/app-root/src/config.json
Run APICAST_LOG_LEVEL=info APICAST_WORKERS=1 THREESCALE_PORTAL_ENDPOINT=http://echo:8081/config/ THREESCALE_CONFIG_FILE=/opt/app-root/src/config.json APICAST_CONFIGURATION_LOADER=boot APICAST_CONFIGURATION_CACHE=-1 THREESCALE_DEPLOYMENT_ENV=staging APICAST_SERVICES_LIST=1234 ./bin/apicast

Current Result
You'll see that after the initial boot configuration loads, it then enters into the scheduler, and immediately and infinitely starts refreshing the configuration. Here is a sample of the output: https://gist.github.com/coderbydesign/f3d95680b27a34795c58e9906e784d71
Expected Result
We see the environment config loaded once at boot, with no schedule set for reloading configuration: https://gist.github.com/coderbydesign/0421cd55635007f3f45361eb6c35ee48
Additional Information

Minimal JSON config for reproducer
Current log output
Expected log output

Thanks to @dagbay-rh for finding the initial root cause of our issue!

Proposed PR in https://github.com/3scale/APIcast/pull/1468

@coderbydesign Thanks for your issue, make sense what you're reporting.
Let me have a look, and I'll come back to you in the next couple of days.


Add test to verify behavior of "New Messages" button

Resolves #3597.

Changelog Entry
(No changelog entry is added as this is adding a test to fortify existing behavior.)
Description
Adding a new test to make sure the "New messages" button do not show up when it is not needed, during scrollable size change (e.g. landscape to portrait).
Design

Specific Changes

Added __tests__/html/newMessageButton.containerSize.html to verify:

When scrollable has enough space to show a new activity, the "New messages" button should not show up
When scrollable does not have enough space and it is not at the bottom, the "New messages" button should show up

[x] I have added tests and executed them locally
[x] ~I have updated CHANGELOG.md~
[x] ~I have updated documentation~

Review Checklist

This section is for contributors to review your work.

[x] ~Accessibility reviewed (tab order, content readability, alt text, color contrast)~
[x] ~Browser and platform compatibilities reviewed~
[x] ~CSS styles reviewed (minimal rules, no z-index)~
[x] ~Documents reviewed (docs, samples, live demo)~
[x] ~Internationalization reviewed (strings, unit formatting)~
[x] ~package.json and package-lock.json reviewed~
[x] ~Security reviewed (no data URIs, check for nonce leak)~
[x] Tests reviewed (coverage, legitimacy)

Your videos in the issue don't show the repro steps though. Orientation should be unlocked, then while still waiting for proactive, switch from portrait view to landscape.

Your videos in the issue don't show the repro steps though. Orientation should be unlocked, then while still waiting for proactive, switch from portrait view to landscape.

@amal-khalaf feel free to merge in when you have approved.

@amal-khalaf feel free to merge in when you have approved.


Release Google.Cloud.ManagedIdentities.V1 version 2.2.0

Changes in this release:
Dependency changes only.

Created release for Google.Cloud.ManagedIdentities.V1-2.2.0


Launching CARLA server (./CarlaUE4.sh) without rendering at all.

Hello,
I am trying to run CARLA 0.9.15 on an Ubuntu 22.04 PC with very limited dedicated GPU VRAM (512Mb). Launching the CARLA server with ./CarlaUE4.sh never works, it starts a black screen then the process gets killed / my PC crashes, which is logical given the limited video memory. I want to use it in tandem with "python no_rendering_mode.py", but I first need an instance of the server to be launched.
I have already tried ./CarlaUE4.sh -RenderOffscreen, or with low quality, but I still have not been able to launch a successful instance of the server. Is there any workaround possible that avoids the usage of the GPU for rendering, or am I forced to upgrade my GPU as the only solution?
Thanks in advance

Maybe try launching with ./CarlaUE4.sh -nullrhi

Maybe try launching with ./CarlaUE4.sh -nullrhi

Exactly what I was looking for, thank you!


Prepare release v1.43.0

TODOs

[x] Update UI once https://github.com/jaegertracing/jaeger-ui/pull/1264 is merged

@albertteoh thanks for the review. PR updated

The UI test Check_if_the_favicon_icon_is_available is failing and the UI does not load if I run it locally go run -tags ui ./cmd/all-in-one/main.go

@mszabo-wikia I remember icon file moved in the UI recently

I think this is the root cause https://github.com/jaegertracing/jaeger-ui/issues/1275

@pavolloffay do you want to just downgrade UI to 1.27.4 and get the release out? It might take time to figure out how the UI build changed.

Check_if_the_favicon_icon_is_available

I'm glad we had this test :-). It won't work going forward, but the situation with the blank screen in the UI makes me think we should alter it to look for some other specific element in the UI home page. Ideally it would be something like the Search button, which would only be generated if the correct React app is loaded, but that won't happen via curl.

I added a bit of logging to static handler, things look ok from the server side
serving /static/index-b9997246.js
serving /static/index-3c2d679b.css

and in Chrome too:

I think it's really something about the UI build output, the app is incomplete or we're using a wrong mode.
@mszabo-wikia any thoughts?

Looks like there's this error:
Uncaught TypeError: Unknown theme type: undefined, name: undefined
    withSuffix http://localhost:16686/static/index-b9997246.js:69

Although https://github.com/ant-design/ant-design/issues/19002#issuecomment-965958565 is in Chinese, it seems the observed error matches & from some quick local testing the UI loads properly after applying that update to the build config. So this looks to be an antd 3.9.0 -> 3.26 update regression.

Filed https://github.com/jaegertracing/jaeger-ui/pull/1276. ee7ce64f6784e5e00718a58680a43098f83a3c94  is the first commit that breaks without the additional config, so antd 3.26 indeed seems to be at fault.


Integration's socket doesn't reconnect upon [some?] failures

When I changed some wifi settings earlier, the sensors became Unavailable and never came back. Restarting AppDaemon fixed this, but it seems like a good idea to be resilient to transient network issues inside the integration itself
2022-01-01 00:28:38.165051 DEBUG qolsys_panel: Sending keep-alive
2022-01-01 00:28:38.303066 ERROR qolsys_panel: error while listening
Traceback (most recent call last):
  File "/config/appdaemon/apps/qolsysgw/qolsys/socket.py", line 81, in listen
    line = await reader.readline()
  File "/usr/lib/python3.9/asyncio/streams.py", line 540, in readline
    line = await self.readuntil(sep)
  File "/usr/lib/python3.9/asyncio/streams.py", line 632, in readuntil
    await self._wait_for_data('readuntil')
  File "/usr/lib/python3.9/asyncio/streams.py", line 517, in _wait_for_data
    await self._waiter
  File "/usr/lib/python3.9/asyncio/selector_events.py", line 856, in _read_ready__data_received
    data = self._sock.recv(self.max_size)
ConnectionResetError: [Errno 104] Connection reset by peer
2022-01-01 00:28:38.308925 DEBUG qolsys_panel: Qolsys callback for disconnection event
2022-01-01 00:28:38.311177 DEBUG qolsys_panel: call_service: mqtt/publish, {'namespace': 'mqtt', 'retain': True, 'topic': 'homeassistant/alarm_control_panel/qolsys_panel/availability', 'payload': 'offline'}
2022-01-01 00:28:38.316187 ERROR qolsys_panel: Task exception was never retrieved
future: <Task finished name='Task-335' coro=<QolsysSocket.listen() done, defined at /config/appdaemon/apps/qolsysgw/qolsys/socket.py:59> exception=ConnectionResetError(104, 'Connection reset by peer')>
Traceback (most recent call last):
  File "/config/appdaemon/apps/qolsysgw/qolsys/socket.py", line 121, in listen
    await writer.wait_closed()
  File "/usr/lib/python3.9/asyncio/streams.py", line 359, in wait_closed
    await self._protocol._get_close_waiter(self)
  File "/config/appdaemon/apps/qolsysgw/qolsys/socket.py", line 81, in listen
    line = await reader.readline()
  File "/usr/lib/python3.9/asyncio/streams.py", line 540, in readline
    line = await self.readuntil(sep)
  File "/usr/lib/python3.9/asyncio/streams.py", line 632, in readuntil
    await self._wait_for_data('readuntil')
  File "/usr/lib/python3.9/asyncio/streams.py", line 517, in _wait_for_data
    await self._waiter
  File "/usr/lib/python3.9/asyncio/selector_events.py", line 856, in _read_ready__data_received
    data = self._sock.recv(self.max_size)
ConnectionResetError: [Errno 104] Connection reset by peer

If you can reproduce the error, please try again with the dev branch, as I just pushed a small fix that should resolve that issue! :)

If you can reproduce the error, please try again with the dev branch, as I just pushed a small fix that should resolve that issue! :)

I know it's probably not the same - but I attempted to repro this with your changes by blocking the panel from connecting to wifi for a while and eventually allowing it back in. When it was allowed back in and rebooted, it reconnected automatically l. So that was good!

I know it's probably not the same - but I attempted to repro this with your changes by blocking the panel from connecting to wifi for a while and eventually allowing it back in. When it was allowed back in and rebooted, it reconnected automatically l. So that was good!

I'll consider it's good enough a test :)
I merged this to the main branch too! Thanks again!

I'll consider it's good enough a test :)
I merged this to the main branch too! Thanks again!


How large is the dataset (RGB-normal-depth, poses)?

I want to download the dataset but maybe have enough space storage. I want to know if I want to download the pose, RGB-normal-depth. How much space is needed?

If you download only the RGB and Normal-Depth images, each object will require about 10MB of storage space. Therefore, downloading a subset of Objaverse (about 280,000 objects) would necessitate at least 3TB of storage space.

Thanks1


diff: implement -s

Also: fix a couple small bugs

Review looks OK.
In regards to testing, does the -s output match BSD or Linux diff?

I'm not sure what the difference is, and some searching didn't turn up anything useful. Could you briefly explain?

Review looks OK.
In regards to testing, does the -s output match BSD or Linux diff?

I'm not sure what the difference is, and some searching didn't turn up anything useful. Could you briefly explain?

Restated:   When testing your change on BSD and Linux, does the posixutils diff w/ your change produce (a) similar or (b) different output from BSD diff -s and Linux diff -s?


Add searchmethod setting for tagbar extension

The current implementation of tagbar does not allow for setting the
search-method in the tagbar#currenttag function. In
https://github.com/preservim/tagbar/pull/696, tagbar implemented this,
which has three options: nearest, neartest-stl, and scoped-stl.
The reason for adding this - for me, at least - is to use the scoped-stl
option, so that the statusline will display the proper function when
there are nested functions. (Otherwise, once you go past a nested
function, tagbar#currenttag still returns the nested function rather
than the function it was nested in.)

Please let me know if this is acceptable or if you'd like any edits made.

thanks, I think this looks fine, but please adjust the documentation as mentioned and slightly re-write how to access the searchmethod. Thanks.

can you just squash this into a single commit?

thanks!


Tensile solution found, but kernel not found in any loaded module.

This issue popped up in the AUR package for rocBLAS here: https://github.com/rocm-arch/rocm-arch/issues/312
When compiling rocBLAS 3.5.0 with the following cmake options:
        -Damd_comgr_DIR=/opt/rocm/lib/cmake/amd_comgr
        -DBUILD_WITH_TENSILE=ON
        -DTensile_TEST_LOCAL_PATH="..."
        -DTensile_COMPILER=hipcc
        -DTensile_ARCHITECTURE=all
        -DTensile_LOGIC=asm_full
        -DBUILD_CLIENTS_TESTS=OFF
        -DBUILD_CLIENTS_BENCHMARKS=OFF
        -DBUILD_CLIENTS_SAMPLES=OFF
        -DBUILD_TESTING=OFF

using the corresponding Tensile library, and with a Vega 20 or gfx906 hardware available, I can't get a simple dgemm to work:
#include <iostream>
#include <vector>
#include "rocblas.h"

int main()
{
    rocblas_int N = 10;

    double alpha = 1.0;
    double beta = 0.0;

    // create a and b on the host
    std::vector<double> A_h(N * N, 1.0);
    std::vector<double> B_h(N * N, 1.0);
    std::vector<double> C_h(N * N, 0.0);

    double * A_d;
    double * B_d;
    double * C_d;

    rocblas_handle handle;
    rocblas_create_handle(&handle);

    // allocate memory on device
    hipMalloc(&A_d, N * N * sizeof(double));
    hipMalloc(&B_d, N * N * sizeof(double));
    hipMalloc(&C_d, N * N * sizeof(double));

    hipMemcpy(A_d, A_h.data(), sizeof(double) * N * N, hipMemcpyHostToDevice);
    hipMemcpy(B_d, B_h.data(), sizeof(double) * N * N, hipMemcpyHostToDevice);
    hipMemcpy(C_d, C_h.data(), sizeof(double) * N * N, hipMemcpyHostToDevice);

    rocblas_dgemm(handle, rocblas_operation_none, rocblas_operation_none, N, N, N, &alpha, A_d, N, B_d, N, &beta, C_d, N);

    // copy output from device memory to host memory
    hipMemcpy(C_h.data(), C_d, sizeof(double) * N * N, hipMemcpyDeviceToHost);

    // verify rocblas_scal result
    auto err = 0.0;
    for (size_t i = 0; i < N * N; ++i)
        err += std::abs(C_h[i] - N);

    std::cout << "Error = " << err << '\n';

    hipFree(A_d);
    hipFree(B_d);
    hipFree(C_d);
    rocblas_destroy_handle(handle);
}

compiled with:
hipcc -std=c++14 -I /path/to/rocblas/include/ dgemm.cpp -L /path/to/rocblas/lib/ -lrocblas

It outputs:
Error: Tensile solution found, but Kernel Cijk_Ailk_Bljk_DB_MT32x64x8_SN_APM1_AF0EM1_AF1EM1_AMAS3_ASBE01_ASEM1_BL1_DTL0_EPS1_FL1_GRVW2_GSU1_ISA906_IU1_K1_KLA_LBSPPn1_LPA0_LPB0_LDL1_NLCA1_NLCB1_ONLL1_PBD0_PK0_PGR1_PLR1_RK0_SIA1_SU0_SUM0_SUS256_SNLL1_TT4_4_TLDS0_USFGRO0_VAW1_VS1_VW2_WG8_16_1_WGM1 not found in any loaded module. exception thown for { a_type: "f64_r", b_type: "f64_r", c_type: "f64_r", d_type: "f64_r", compute_type: "f64_r", transA: 'N', transB: 'N', M: 10, N: 10, K: 10, lda: 10, ldb: 10, ldc: 10, ldd: 10, beta: -12345.0, batch_count: 1, stride_a: 100, stride_b: 100, stride_c: 100, stride_d: 100 }

It seems this kernel does exist, though:
$ grep Cijk_Ailk_Bljk_DB_MT32x64x8_SN_APM1_AF0EM1_AF1EM1_AMAS3_ASBE01_ASEM1_BL1_DTL0_EPS1_FL1_GRVW2_GSU1_ISA906_IU1_K1_KLA_LBSPPn1_LPA0_LPB0_LDL1_NLCA1_NLCB1_ONLL1_PBD0_PK0_PGR1_PLR1_RK0_SIA1_SU0_SUM0_SUS256_SNLL1_TT4_4_TLDS0_USFGRO0_VAW1_VS1_VW2_WG8_16_1_WGM1 /path/to/rocblas/lib/  -r
Binary file library/TensileLibrary_gfx906.co matches
library/TensileLibrary.yaml:  name: Cijk_Ailk_Bljk_DB_MT32x64x8_SN_APM1_AF0EM1_AF1EM1_AMAS3_ASBE01_ASEM1_BL1_DTL0_EPS1_FL1_GRVW2_GSU1_ISA906_IU1_K1_KLA_LBSPPn1_LPA0_LPB0_LDL1_NLCA1_NLCB1_ONLL1_PBD0_PK0_PGR1_PLR1_RK0_SIA1_SU0_SUM0_SUS256_SNLL1_TT4_4_TLDS0_USFGRO0_VAW1_VS1_VW2_WG8_16_1_WGM1
library/TensileLibrary.yaml:  name: Cijk_Ailk_Bljk_DB_MT32x64x8_SN_APM1_AF0EM1_AF1EM1_AMAS3_ASBE01_ASEM1_BL1_DTL0_EPS1_FL1_GRVW2_GSU1_ISA906_IU1_K1_KLA_LBSPPn1_LPA0_LPB0_LDL1_NLCA1_NLCB1_ONLL1_PBD0_PK0_PGR1_PLR1_RK0_SIA1_SU0_SUM0_SUS256_SNLL1_TT4_4_TLDS0_USFGRO0_VAW1_VS1_VW2_WG8_16_1_WGM1

Any idea what is causing this problem?

Hi,
Is rocBLAS loading the code object files correctly? If you run with the environment variable TENSILE_DB=0x40 it will print out as it loads each code object file.

Thanks, I'll have a look.
What's the recommended settings for

CODE_OBJECT_VERSION (V2 by default, the last commit on Tensile for rocm 3.5.0 mentions V3: https://github.com/ROCmSoftwarePlatform/Tensile/commit/f842a1a4427624eff6cbddb2405c36dec9a210cd#diff-71fdb92488b0a07be4968071daa33a51R191-R192) and
BUILD_WITH_TENSILE_HOST
?

@sdquiring, with your variable, it's giving me the following output:
Kernel Cijk_Ailk_Bljk_DB_MT32x64x8_SN_APM1_AF0EM1_AF1EM1_AMAS3_ASBE01_ASEM1_BL1_DTL0_EPS1_FL1_GRVW2_GSU1_ISA906_IU1_K1_KLA_LPA0_LPB0_LDL1_NLCA1_NLCB1_PBD0_PK0_PGR1_PLR1_RK0_SU0_SNLL1_TT4_4_USFGRO0_VAW1_VS1_VW2_WG8_16_1_WGM1
 l(128, 1, 1) x g(1, 1, 1) = (128, 1, 1)
[0..7] tensor2dSizeC: 00 00 00 00 00 00 00 00 (0)
[8..15] tensor2dSizeA: 64 00 00 00 00 00 00 00 (100)
[16..23] tensor2dSizeB: 64 00 00 00 00 00 00 00 (100)
[24..31] d: 00 20 20 e5 fe 7f 00 00 (0x7ffee5202000)
[32..39] c: 00 20 20 e5 fe 7f 00 00 (0x7ffee5202000)
[40..47] a: 00 00 20 e5 fe 7f 00 00 (0x7ffee5200000)
[48..55] b: 00 10 20 e5 fe 7f 00 00 (0x7ffee5201000)
[56..63] alpha: 00 00 00 00 00 00 f0 3f (1)
[64..71] beta: 00 00 00 00 00 00 00 00 (0)
[72..75] strideD1: 0a 00 00 00 (10)
[76..79] strideD2: 64 00 00 00 (100)
[80..83] strideC1: 0a 00 00 00 (10)
[84..87] strideC2: 64 00 00 00 (100)
[88..91] strideA1: 0a 00 00 00 (10)
[92..95] strideA2: 64 00 00 00 (100)
[96..99] strideB1: 0a 00 00 00 (10)
[100..103] strideB2: 64 00 00 00 (100)
[104..107] size_0: 0a 00 00 00 (10)
[108..111] size_1: 0a 00 00 00 (10)
[112..115] size_2: 01 00 00 00 (1)
[116..119] size_3: 0a 00 00 00 (10)
[120..123] staggerUIter: 00 00 00 00 (0)
[124..127] problemNumGroupTiles0: 01 00 00 00 (1)
[128..131] problemNumGroupTiles1: 01 00 00 00 (1)
[132..135] magicNumberProblemNumGroupTiles0: 01 00 00 80<PHONE_NUMBER>)
[136..139] gridNumWorkGroups0: 01 00 00 00 (1)
[140..143] numFullBlocks: 01 00 00 00 (1)
[144..147] wgmRemainder1: 01 00 00 00 (1)
[148..151] magicNumberWgmRemainder1: 01 00 00 80<PHONE_NUMBER>)
[152..155] pad: 00 00 00 00 (0)
Error: Tensile solution found, but Kernel Cijk_Ailk_Bljk_DB_MT32x64x8_SN_APM1_AF0EM1_AF1EM1_AMAS3_ASBE01_ASEM1_BL1_DTL0_EPS1_FL1_GRVW2_GSU1_ISA906_IU1_K1_KLA_LPA0_LPB0_LDL1_NLCA1_NLCB1_PBD0_PK0_PGR1_PLR1_RK0_SU0_SNLL1_TT4_4_USFGRO0_VAW1_VS1_VW2_WG8_16_1_WGM1 not found in any loaded module. exception thown for { a_type: "f64_r", b_type: "f64_r", c_type: "f64_r", d_type: "f64_r", compute_type: "f64_r", transA: 'N', transB: 'N', M: 10, N: 10, K: 10, lda: 10, ldb: 10, ldc: 10, ldd: 10, beta: -12345.0, batch_count: 1, stride_a: 100, stride_b: 100, stride_c: 100, stride_d: 100 }

Same story on develop:
srun: job 44102 queued and waiting for resources
srun: job 44102 has been allocated resources
loaded code object/apps/ault/SSL/hstoppel/spack/opt/spack/linux-centos7-zen/gcc-10.1.0/rocblas-develop-wahvubzbrxwbh3fbw3fy5aiynreb44lj/lib/library/TensileLibrary_gfx906.co
loaded code object/apps/ault/SSL/hstoppel/spack/opt/spack/linux-centos7-zen/gcc-10.1.0/rocblas-develop-wahvubzbrxwbh3fbw3fy5aiynreb44lj/lib/library/Kernels.so-000-gfx906.hsaco
Kernel Cijk_Ailk_Bljk_DB_MT96x64x8_SE_APM1_AF0EM1_AF1EM1_AMAS3_ASBE01_ASCE01_ASEM1_BL1_DTL0_EPS1_FL1_GRVW2_GSU1_ISA906_IU1_K1_KLA_LPA0_LPB0_LDL1_LRVW2_MDA2_NLCA1_NLCB1_ONLL1_PBD0_PK0_PGR1_PLR1_RK0_SU0_SUM0_SUS256_SNLL0_TT6_4_USFGRO0_VAW1_VS1_VW2_WG16_16_1_WGM1
 l(256, 1, 1) x g(11, 16, 1) = (2816, 16, 1)
[0..7] tensor2dSizeC: 40 42 0f 00 00 00 00 00 (1000000)
[8..15] tensor2dSizeA: 40 42 0f 00 00 00 00 00 (1000000)
[16..23] tensor2dSizeB: 40 42 0f 00 00 00 00 00 (1000000)
[24..31] d: 00 00 20 e1 fe 7f 00 00 (0x7ffee1200000)
[32..39] c: 00 00 20 e1 fe 7f 00 00 (0x7ffee1200000)
[40..47] a: 00 00 20 ed ff 7f 00 00 (0x7fffed200000)
[48..55] b: 00 00 80 ec ff 7f 00 00 (0x7fffec800000)
[56..63] alpha: 00 00 00 00 00 00 f0 3f (1)
[64..71] beta: 00 00 00 00 00 00 00 00 (0)
[72..75] strideD1: e8 03 00 00 (1000)
[76..79] strideD2: 00 00 00 00 (0)
[80..83] strideC1: e8 03 00 00 (1000)
[84..87] strideC2: 00 00 00 00 (0)
[88..91] strideA1: e8 03 00 00 (1000)
[92..95] strideA2: 00 00 00 00 (0)
[96..99] strideB1: e8 03 00 00 (1000)
[100..103] strideB2: 00 00 00 00 (0)
[104..107] size_0: e8 03 00 00 (1000)
[108..111] size_1: e8 03 00 00 (1000)
[112..115] size_2: 01 00 00 00 (1)
[116..119] size_3: e8 03 00 00 (1000)
[120..123] staggerUIter: 00 00 00 00 (0)
[124..127] problemNumGroupTiles0: 0b 00 00 00 (11)
[128..131] problemNumGroupTiles1: 10 00 00 00 (16)
[132..135] magicNumberProblemNumGroupTiles0: bb e8 a2 0b (195225787)
[136..139] gridNumWorkGroups0: 0b 00 00 00 (11)
[140..143] numFullBlocks: 10 00 00 00 (16)
[144..147] wgmRemainder1: 01 00 00 00 (1)
[148..151] magicNumberWgmRemainder1: 01 00 00 80<PHONE_NUMBER>)
[152..155] pad: 00 00 00 00 (0)

rocBLAS error: Tensile solution found, but exception thown for { a_type: "f64_r", b_type: "f64_r", c_type: "f64_r", d_type: "f64_r", compute_type: "f64_r", transA: 'N', transB: 'N', M: 1000, N: 1000, K: 1000, alpha: 1.0, row_stride_a: 1, col_stride_a: 1000, row_stride_b: 1, col_stride_b: 1000, row_stride_c: 1, col_stride_c: 1000, row_stride_d: 1, col_stride_d: 1000, beta: 0.0, batch_count: 1, stride_a: 0, stride_b: 0, stride_c: 0, stride_d: 0, atomics mode: atomics_allowed }
Kernel Cijk_Ailk_Bljk_DB_MT96x64x8_SE_APM1_AF0EM1_AF1EM1_AMAS3_ASBE01_ASCE01_ASEM1_BL1_DTL0_EPS1_FL1_GRVW2_GSU1_ISA906_IU1_K1_KLA_LPA0_LPB0_LDL1_LRVW2_MDA2_NLCA1_NLCB1_ONLL1_PBD0_PK0_PGR1_PLR1_RK0_SU0_SUM0_SUS256_SNLL0_TT6_4_USFGRO0_VAW1_VS1_VW2_WG16_16_1_WGM1 not found in any loaded module.
Error = 1e+09

Since you're running ROCm 3.5 which is HIP-Clang based, you need to set Tensile_CODE_OBJECT_VERSION to V3; also for this release, BUILD_WITH_TENSILE_HOST must be set to OFF.  If you look at install.sh, you'll see the default values that will work.  Thanks.

If I just set BUILD_WITH_TENSILE_HOST=OFF it still builds the TensileHost target, because of this:
https://github.com/ROCmSoftwarePlatform/Tensile/blob/develop/Tensile/Source/CMakeLists.txt#L27-L86
Should TENSILE_NEW_CLIENT be set to false then?

I can confirm it works now! I hadn't tried -DTensile_CODE_OBJECT_VERSION=V3 and -DBUILD_WITH_TENSILE_HOST=OFF before... Only tried to change them individually. Thanks a bunch!


Requirement file (torch_scatter)

Hello,
I'd like to try out your code. However, I get the issue that torch_scatter is not installed when I install the packages in the requirement file. I tried installing torch_scatter in addition, using conda, but I get a linking issue when running the code
OSError: /home/olga/Software/mambaforge/envs/gnn/lib/python3.9/site-packages/torch_scatter/_version_cuda.so: undefined symbol: _ZN5torch3jit17parseSchemaOrNameERKSs
Could you please provide a complete list of necessary libraries? Thanks in advance!

Hi @olgovich,
I assumed torch_scatter is a full dependency for pytorch_geometric, but apparently it's an optional one. I'll fix that right away. The error you're facing usually is a result of multiple conflicting versions of the package existing in the same environment (cf. this issue).
I'd recommend performing a clean install of torch, torch_geometric, and its dependencies in your environment from their wheels as shown here. This fixed the problem for me. Do not use the conda installer because it seems to install both CPU and CUDA versions, which can lead to this conflict. Hope this helps!


Fixed duplicate code

The proposed "good" way of coding was actually changing a property's name in the developers object.
While one can argue that in this case they could be the same, the point of the example was to show that you can still remove duplicated code that require different things.

I like your version better than what was there, thank you for your contributions! 🎉

Cheers!


Perturb-seq data analysis workflows

https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>6516v1
https://github.com/scverse/pertpy


Placeholder for function 4

Function 4: Can I make a suggestion?
Suggested actions that this function will perform:

Reviews the data set to suggest dropping variables based on their unique values, outliers, and how many NAN's they contained initially and how much data that eliminated from the data set after cleaning.
Checks for imbalance amongst the variables
Suggests an appropriate split for a test and training set based on the size of the dataset.

I like the idea of this function making suggestions. Thanks for documenting all the function ideas.
Besides what has been stated, maybe we could output a comprehensive table including min, max, mean, std for numeric variables, combined with values, number of categories, majority counts, minority counts for categorical variables.

I would prefer having a function that performs the job instead of making a 'suggestion.' For example we could simply have one function that checks the class imbalance if we are focusing on classification problem datasets or just one function that pulls the summary stats like Luming suggested (it may be a simple function but still does the important job of providing the summary stats). These are all great idea but I fear it may be too much for one function to handle and the first point sounds little redundant as we may be just repeating ourselves.

I also like the idea of a summary table basis which we can make decisions for our analysis. However, since we already have the describe() function for unique values and other statistics, we probably would need to add more value to the function that we are creating here.

Hi everyone, thanks for your thoughts, lets simplify to this:

The function checks for imbalance, and unique values in variables.
The function then outputs a summary sentence or table to highlight its findings and prompts the user if they would like to remove the variables with a high threshold of unique values. User inputs "yes" or "no" and based on that performs the action

That way its not too complex but it also "performs" something instead of just suggesting it.
What are your thoughts?

Yes, that's a good idea! Hope the input part of the function does not complicate things🤞

I would prefer not coding interactively. I think some important statistics in a summary table (facts), plus some sentences of suggestions (program's opinions :sweat_smile:) could be good enough. "Performs the action" is very attractive, but I am concerned with complications in it. We could call this function "fact_opinion" :smiley:
You know, "perform the action" we could always add it later, but I prefer not to include it in our mandatory scope.

I'm happy to go with the majority consensus on this and I see your point @Luming-ubc, it's definitely more complex to code, my only concern with not including anything interactive is that then our package it is not very differentiated from the standard EDA packages that already exist.
@jamesktkim and @sukhleen999 what are your thoughts?


feat: internal rate limiting for UAA

Implements a rate limiting feature directly into the UAA.
As a first remark: When nothing is done regarding configuration of this feature, the whole feature will stay disabled (only the request filter, that in this case directly forwards the request, will be used in the container).
However if configuration is done, this allows to rate limit the requests processed by the uaa.
It is possible to configure rate limits for specific endpoints as well as a global limit for all requests. The limits can be targeted at either all users of a specific endpoint or targeted to specific users of the endpoint (as determined by e.g. the email from the used JWT).
The PR nearly contains only new coding, only the HomeController was extended with a new 429 error page and the web.xml was extended with the entry point (Filter) of the rate limiting. All the limiting is done in new classes.
The PR also includes some documentation on how the feature works internally and how it has to be confgured. Also Example configuration is included. A PR to allow this configuration to be done via uaa-release will follow once we have this in the UAA.

since this is new I would like to have at least 80%
https://sonarcloud.io/summary/new_code?id=cloudfoundry-identity-parent&pullRequest=1987
some classes, e.g. configuration and RateLimitingFilter are with 0 coverage, please add a test class for the filter class

Added some more unit tests. Line coverage is now above 80% at 81.8%
Condition coverage is still only at 62.5%, but then Sonar also want the conditions in Lombok-generated equals and hash code methods to be covered: (s. example)
Also the only classes that have larger numbers of uncovered lines are some config classes, that only instantiate other classes.
So in my opinion there are not really meaningful tests left here. If you insist I could of course increase those numbers further by writing those tests, but in my opinion this would add no value.

@torsten-sap  FYI because you were not in the meeting today

What's the current status on this PR? I see that most of the recent commits are about adding tests. Is there any progress on

@peterhaochen47 The last commit were about the other feedback that @strehle provided, so adopting the configuration and having an IT and better coverage as requested by Sonar - so the PR fulfills all prerequisites for getting merged if this is wanted.
If you prefer the solution using some other library, it probably does not make sense to implement this based on the changes in this PR. But this is then a more general discussion of what is wanted, I guess..

I really would like to hear from @litesoft and @tack-sap on the question asked by Markus and Peter

I have expected to find any guava cache or rate limit usage but you have implemented everything on your own, correct? did you knew that uaa uses guava already? and guava provides some mechanisms, e.g. https://www.baeldung.com/guava-rate-limiter

Could you please explain the reasons why you decided to implement everything yourself, instead of using a library like Guava?

from code it look now good,
https://sonarcloud.io/summary/new_code?id=cloudfoundry-identity-parent&pullRequest=1987
I have debugged the IT so from usage point of view I only miss a possiblity in uaa-release to configure this for bosh deployment

I spent some time looking in the HTTP 429 return code (Too many requests). This HTTP code appears to be for individual rate limiting only, not the kind we are trying to write here.
It seems to me like in this case what we want to return is an HTTP 503 (Service unavailable).
And this makes sense to me. HTTP 4xx codes are for user errors. It's not the user's fault if they can't get a response when others overwhelm the server.
So, to summarize. My current understanding is that you should return 429 (Too many requests) for an rate limit per user, but 503 (Service unavailable) for any other rate limit.

Bruce Ricard,
I'm the contractor who wrote the majority of the Rate Limiting code FOR
SAP...  I am no longer under contract with SAP, and am currently working
full time on another project.
I do NOT speak for SAP, and the opinions below are Mine and Mine Alone:
1st the simple and short question/suggestion:
re 429 and 503 status codes -- I think that is a great idea!
2nd re canned/existing library vs all this one-off code:
When the decision was made to add code to the UAA (over multiple other
proposals) there was a primary goal:
The rate limiting should default to disabled AND impact as little other
code in the UAA as possible!
The default to disabled is there, and IMO, the impact is basically limited
to the addition of a new leading filter.
In addition, when it is disabled, the filter processing consists of only
one additional test: for limiter status!
Some of the subsequent goals were:

The Rate Limiting rules could be updated dynamically (via http
request).
Default (local file) Rate Limiting rules should be supported.
If the Rate Limiting rules configuration "files" (either from a web
server or the local file system) are corrupted (can't be fetched or don't
parse error free) then use the existing configuration.
If dynamic updating is active, but there is no usable existing
configuration, the library goes into a semi-disabled state, while
attempting to fetch a good configuration.

While it is possible that there is an existing library out there that could
meet at least the most important goals, and while I can't speak to how much
effort was put into a search by the SAP staff, my co-contractor and I did
spend about a week looking at options and coming up with proposals.  The
closest we got to NOT writing code was to use NGENX as a sort of
side-car, and this was thoroughly investigated and POC deployed, but
eventually abandoned due to our believing that we could NOT extract
caller identity from the JOT (and did not know how it was going to easily
support defaulting to disabled and supporting dynamic updating of the
rules).
George Smith
On Fri, Sep 16, 2022 at 7:03 AM Bruce Ricard @.***>
wrote:

I spent some time looking in the HTTP 429 return code (Too many requests)
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/429. This HTTP
code appears to be for individual rate limiting only, not the kind we are
trying to write here.
It seems to me like in this case what we want to return is an HTTP 503
(Service unavailable)
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/503.
And this makes sense to me. HTTP 4xx codes are for user errors. It's not
the user's fault if they can't get a response when others overwhelm the
server.
So, to summarize. My current understanding is that you should return 429
(Too many requests) for an rate limit per user, but 503 (Service
unavailable) for any other rate limit.
—
Reply to this email directly, view it on GitHub
https://github.com/cloudfoundry/uaa/pull/1987#issuecomment-1249404780,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABO2UAKVWMTPJFUU4KB6NCLV6R42FANCNFSM55VX3DKQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
"And the users exclaimed with a laugh and a taunt: It's just what we
asked for but not what we want." -- Unknown

In regards to 503 vs 429:
503 Unavailable is intended for all users (Downtime for XYZ).
429 Is intended for users and machines that request too many threads (Requests).
https://webmasters.stackexchange.com/questions/65674/should-i-return-a-429-or-503-status-code-to-a-bot

@litesoft Thank you for providing contexts, which explain a lot.

We would strongly prefer not pushing WIP commits to the main branch. Could you maybe squash these WIP commits with the next commit, which fixed the issues?

Peter Chen,
Nice update to the UAA-Rate-Limiting.md file!
George
On Wed, Oct 19, 2022 at 9:27 AM Peter Chen @.***> wrote:

@tack-sap https://github.com/tack-sap @strehle
https://github.com/strehle, before you merge, could you review this new
version of doc:
https://github.com/cloudfoundry/uaa/blob/ratelimit-docs/docs/UAA-Rate-Limiting.md
& cherry-pick it to this PR? And remove the original doc on this PR?
—
Reply to this email directly, view it on GitHub
https://github.com/cloudfoundry/uaa/pull/1987#issuecomment-1284276688,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABO2UAO4K65X3T7XGBG2YRLWEAOPRANCNFSM55VX3DKQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
"And the users exclaimed with a laugh and a taunt: It's just what we
asked for but not what we want." -- Unknown

@peterhaochen47 We agreed in the sync today that we can keep it parallel, especially as the feature will be tagged as experimental in the first release:

Parallelize doc from implementation for 2 PRs.

That works. I'll make a separate PR about the docs.