KIP-363 Make FunctionConversions deprecated

As pointed out in this comment https://github.com/apache/kafka/pull/5539#discussion_r212380648 the object FunctionConversions is only of internal use and therefore should be private to the lib only so that we can do changes without going through KIP like this one.
KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-363%3A+Make+FunctionConversions+private
@guozhangwang @vvcephei @mjsax @debasishg and whoever wants to join the party 😄

We are waiting for the min of 72h of the KIP vote to finish:
<EMAIL_ADDRESS>Which means we can merge this on 26 Aug 2018 18:24:56 GMT

👍

@guozhangwang This is all good to merge

@joan38 I just replied to the KIP thread -- also note, that the vote did not pass yet and the KIP is not accepted yet. It's required to have 3 binding votes (so far only Guozhang gave binding +1).
Also, can you update this PR accordingly? Thanks a lot.

retest this please

12:40:15 * What went wrong:
12:40:15 Execution failed for task ':streams:streams-scala:spotbugsMain'.
12:40:15 > SpotBugs rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/kafka-pr-jdk10-scala2.12/streams/streams-scala/build/reports/spotbugs/main.xml

Do you know what this means?

@joan38 spotbugs was added recently, you can run ./gradlew spotbugsMain spotbugsTest -x test (stated in README.md) locally to see the results.

Thanks @guozhangwang
I get:
Bug type EQ_UNUSUAL (click for details) In class org.apache.kafka.streams.scala.FunctionsCompatConversions$AggregatorFromFunctionIn method org.apache.kafka.streams.scala.FunctionsCompatConversions$AggregatorFromFunction.equals(Object)At FunctionsCompatConversions.scala:[line 88]
--

EQ_UNUSUAL: Unusual equals method
This class doesn't do any of the patterns we recognize for checking that the type of the argument is compatible with the type of the this object. There might not be anything wrong with this code, but it is worth reviewing.

@joan38 . Hmm. I'm not sure why it's running for that one class. Perhaps the other class is already excluded, and this one doesn't match the pattern?
The exclusions are here: gradle/spotbugs-exclude.xml

@vvcephei you are right, it is excluded.
I will add this one also to the exclusion.
Other than that are we happy with the change?

retest this please


[file_selector] Add desktop implementations

The new file_selector plugin has essentially the same functionality as FDE's file_chooser plugin, but the method channel API is slightly different. This tracks migrating file_chooser over to become file_selector implementations for desktop (at which point file_chooser will be removed).

[x] Windows
[x] macOS
[ ] Linux

This is the first instance of a plugin with native desktop UI, so we don't currently have a good testing story. We should start with at least getting PRs for moving the implementation over and adding examples, and then we can evaluate how to move forward. (My preference would be to file a follow-up for integration tests, since I think that's going to be a substantial project, and having it be a standard, published plugin that also supports web and mobile is a significant improvement over maintaining file_chooser even without solving the pre-existing testing problem.)

Implementations (based on the discontinued file_chooser plugin) are now temporarily hosted in the flutter-desktop-embedding repository, and posted to pub (https://pub.dev/packages/file_selector_windows, https://pub.dev/packages/file_selector_macos, https://pub.dev/packages/file_selector_linux). They are unendorsed, so must be added as dependencies in addition to file_selector.
Once we have a testing solution figured out, they can be moved to flutter/plugins and endorsed.

Implementations (based on the discontinued file_chooser plugin) are now temporarily hosted in the flutter-desktop-embedding repository, and posted to pub (https://pub.dev/packages/file_selector_windows, https://pub.dev/packages/file_selector_macos, https://pub.dev/packages/file_selector_linux). They are unendorsed, so must be added as dependencies in addition to file_selector.
Once we have a testing solution figured out, they can be moved to flutter/plugins and endorsed.

Moving and endorsing is blocked on on https://github.com/flutter/flutter/issues/70233 (Windows)/https://github.com/flutter/flutter/issues/70234 (macOS)/https://github.com/flutter/flutter/issues/70235 (Linux)

Moving and endorsing is blocked on on #70233 (Windows)/#70234 (macOS)/#70235 (Linux)

Based on more investigation, and discussion with @cbracken, the plan is now to try to refactor the plugin implementations to allow significant native unit test coverage, and move them based on that. It's not as good as full UI testing—we could have bugs where the two sides of the method channel don't match, for instance (although Pigeon could help address that if we write generators for desktop languages)—but it lets us get significant automated coverage, and is enough that we feel that it meets the bar for moving and endorsing.
That's assuming we can create cut points that make the untested portion as small as possible. It works for macOS; Windows and Linux are TBD.

Prep for moving Linux has been started in https://github.com/google/flutter-desktop-embedding/pull/904


Configure Azure Pipelines

This configuration builds the application and produces builds for both Debug and Release configurations.

dwads


The datasets can be cached in memory？

I want to find a way to use distributed computation system for  computing datasets cached in memory.
The datasets only load in one time,and cached in memory.
Can the gleam help me ?
Tks very much!

Let me know your use case.

There are a lot of data on hdfs,more than 1000G.
I would like to use this system to load the data into memory, so I can submit some jobs directly using the data in memory to calculate the output.Like spark share rdd.

There is a HashJoin() function to keep the smaller dataset in memory.
The other steps all work in a streaming way, unless blocking steps such as LocalSort().
I want to know what operations you need to do.


Distant light rotation axes reversed.

Blender 2.78a
RenderMan 21.2 for Maya-Maya2017 (1676607)
It's difficult to believe this is a bug because I couldn't find mention of it anywhere, and it should be something that would be obvious to anyone using distant lights.
When working with distant lights, the axes rotations are reversed.
To replicate the problem, set up a camera location (0,0,1), rotation (75,0,0).
I added a cylinder at location (0,6,0) with dimensions (0.1, 0.1,1) and put a plane underneath it to see where the shadows fell.
A distant light with an x rotation of 45 degrees.

This is the result and note that the shadow is coming toward the camera rather than away from it.
Here is the blender window.

Setting the light's z rotation to 30, you can see that the shadow is rotating anticlockwise rather than clockwise (if looking along the z axis).

This should be fixed in Renderman 21.  The 20.x exporter still has some old bugs in it and I believe this was one of them.

Sorry, I wrote the wrong version for some reason. Probably looked at the wrong installation file.
The version of Renderman I'm having a problem with is 21.2 for Maya 2017(1676607)
I have corrected the original post.
I recently updated Blender, PRMan and Renderman to the latest versions and this problem has occurred since then.

Sorry to say, but I have the same issue here... I'm using Blender 2.78a, PRMan for blender 21.2, and windows 10.

Just recently launched a new scene and the distant light rotation appears to work fine.  Suggest closing this one.

What versions are you using?
That is, Renderman, PRMan and Maya?
I had given up on this.

Latest master and Blender 2.78b with Renderman 21.3.  I know that existing distant lights can get messed up when the exporter is updated.  I've seen it happen before and the only real solution was to delete the light and create a new one.  Got no clue why that is.

Updating wasn't the issue because I created a new file for the images above.
The only part of the installation I was unsure about was which version of Maya I should use, but went for the latest in the list, but I didn't think it would make a difference in this case. That is, I just chose the latest version.
I see that Renderman has been updated to 21.3. I'll update everything when I get a chance and see how it goes.
Thanks for the feedback.

OK, I uninstalled and deleted everything to do with Renderman, Blender and PRMan from my PC, including the registry and any files and folders left over. Did a clean install of with the latest versions, and the distant light is working as expected.

That's good.  It may have been a 21.2 Renderman bug for all we know.


Feature request: install single file

Hello thanks for your project.
I want to manage with fisher one file plugins, like:
https://github.com/jakubroztocil/httpie/blob/master/extras/httpie-completion.fish
or
https://github.com/justinmayer/tackle/blob/master/plugins/extract/extract.fish

@slavaGanzin Hi. Thanks.
What did you try with and what didn't work? Those look fine to me.

~/ML fisher https://github.com/justinmayer/tackle/blob/master/plugins/extract/extract.fish                                                                                00:53:13
Installing 1 plugin/s
  ⠸
! Fetch extract.fish github.com/justinmayer/tackle/blob/master/plugins/extract/extract.fish
! There was an error installing extract.fish or more plugin/s.
Try using a namespace before the plugin name: owner/extract.fish
~/ML                                                                                00:53:19
~/ML fisher  justinmayer/tackle/blob/master/plugins/extract/extract.fish                                                                                00:53:28
Installing 1 plugin/s
! Fetch extract.fish github.com/justinmayer/tackle/blob/master/plugins/extract/extract.fish
! There was an error installing extract.fish or more plugin/s.
Try using a namespace before the plugin name: owner/extract.fish
~/ML fisher  justinmayer/tackle /plugins/extract/extract.fish

@slavaGanzin This would be a nice feature. 👍

https://github.com/jakubroztocil/httpie/blob/master/extras/httpie-completion.fish

Is not a link to the file, but we can guess the URL in the case of GitHub, parse the name of the file and install it.


Mermaid diagram in node information sometimes shows syntax error

Current Behavior
With the function node in the flow below, following the instructions in the Steps To Reproduce section, the information tab shows a syntax error instead of the chart
Expected Behavior
It should always show the chart.
Steps To Reproduce
Import the Function node included below and Deploy. Select the Debug tab, then select the Function node and the Information tab, and instead of the diagram it shows

If you then click away from the node and then select it again it shows correctly

Example flow
[{"id":"55d54d1c275c150f","type":"function","z":"bdd7be38.d3b55","name":"Test mermaid markdown","func":"\nreturn msg;","outputs":1,"timeout":0,"noerr":0,"initialize":"","finalize":"","libs":[],"x":810,"y":60,"wires":[[]],"info":"```mermaid\nstateDiagram-v2\nState_1 --> State_2: Transition 1\nState_2 --> State_3: Another transition\nState_3 --> State_1: Back to \\nthe start\n```"}]

Environment

Node-RED version: 3.1.0
nodejs version: 20 and 18
npm version: 9.8.0
Platform/OS: Ubuntu 22.04 and Pi OS Bullseye
Browser: Edge and FF

Having dug into this issue, it appears to be the fact that mermaid always tries to insert itself into the DOM. If the element being evaluated isn't in the dom, it generates an error.
Related upstream issue: https://github.com/mermaid-js/mermaid/issues/4358
Hmm, we need to figure out a way around this as it isn't acceptable behaviour for us.


Mavlink Debug Tutorial Code doesn't work anymore on master

The mavlink debug tutorial code described here: https://pixhawk.org/dev/debug_values, doesn't work anymore

Resolved by commit 41f36aa99f8c8007db8cde115461d840eb0c91da


Support pulling image from components

So far pulling a firecracker image was limited to the KIWI kis image type. With this commit it's also possible to pull an image from it's components; rootfs, kernel and optional initrd. This allows for example to make use of the firecracker hosted CI images or any other rootfs image in combination with some kernel/initrd. During the pull of such an image there is also a check for the sci binary inside of the rootfs. If it does not exist it gets added to the rootfs such that the firecracker-pilot can work with it. This Fixes #99

@m-kat with the change here the following becomes possible
flake-ctl firecracker pull \
    --rootfs https://s3.amazonaws.com/spec.ccfc.min/ci-artifacts/disks/x86_64/ubuntu-18.04.ext4 \
    --kernel https://s3.amazonaws.com/spec.ccfc.min/img/quickstart_guide/x86_64/kernels/vmlinux.bin \
    --name firecore --force
flake-ctl firecracker register --app /home/ms/mybash --target /bin/bash --vm firecore

Requires the PR from here #101 to be applied

@m-kat please note I'm shelling out for mount/umount and copy because they get called through sudo such that a normal user can perform the pull action and only discrete commands that requires root permissions are called through
sudo. Thanks


Chore/remove extractor

Removing the extractor from the CLI.  It was mainly used when returning results for the search() and send_to() functions for alerts and file events.
The extractor was replaced by making py42 calls directly and by moving some of the logic out from the extractor and into those alerts and security-data command modules, as well as a shared util file between them.
For security-data events, eventId page tokens were implemented for checkpointing, replacing the timestamps.
For alerts, timestamp checkpoints were implemented in a similar fashion to the audit-logs checkpointing.  However, without the de-dupe logic due to the rarity of two alerts having an identical timestamp - but I don't think it'd be too hard to include that if it was preferred.

I haven't taken a super close look at this yet so maybe this is being handled, but just wanted to call out something we had to be careful about with the Splunk app:
Currently, checkpoints for file events are saved as timestamps. This will change to strings when we start using the page token instead -- If a user is is currently on a version of the CLI that uses timestamps and then upgrades, we need to make sure this change is backwards-compatible.

I should note we don't want to release this until the get_all_alert_details() fix is released in py42.

I should note we don't want to release this until the get_all_alert_details() fix is released in py42.

Yeah, I'll make sure to bump the py42 version requirement too when that happens.


Keyboard shortcuts for McLighting (enhancemnet)

This project is really awesome! It really helped me get my lights up and running quickly.
I have my ws2812b leds around my computer area, so i wanted a way to control the lights directly from my keyboard without having to wait for a web page to load every time i wanted to adjust them.
So, I made an AutoHotKey script that is able to talk directly to the webserver!
I made this on a windows 7 machine. I dont know what the traytip will look like on other operating systems. On windows7 it makes a little balloon popup in the bottom corner that automatically disappears after a few seconds. The shortcuts use the numberpad. Make sure numlock is on
The shortcuts are as follows:
ctrl+windows+numpad4 decrements the animation mode
ctrl+windows+numpad6 increments the animation mode
ctrl+windows+numpad5 turns off the lights
ctrl+windows+numpad0 turns on all of the lights to the current color
ctrl+windows+numpadPlus increases the brightness
ctrl+windows+numpadSubtract decreases the brightness
ctrl+windows+numpadMultiply increases the speed
ctrl+windows+numpadDivide decreases the speed
ctrl+windows+numpad7 increments the red component of the current color
ctrl+windows+numpad1 decrements the red component of the current color
ctrl+windows+numpad8 increments the green component of the current color
ctrl+windows+numpad2 decrements the green component of the current color
ctrl+windows+numpad9 increments the blue component of the current color
ctrl+windows+numpad3 decrements  the blue component of the current color
If people like this, I could try to have it talk to the mqtt server so that it stays up to date with the current mode, color, speed, and brightness.
The AutoHotKey script: (make sure to replace the ip with the ip of your controller)
#NoEnv
#SingleInstance force ; only lets one run
SetBatchLines, -1

socket := new Example("ws://<IP_ADDRESS>:81") ; replace with the ip address of the mclighting controller

incrementAmount := 10 ; how finely you adjust the color, speed, and brightness per keypress
maxColor := 255
maxMode := 56 ; the maximum mode id number

red := 127
green := 127
blue := 127

brightness := 127
speed := 127
mode := 1

^#Numpad4:: ; switch modes down
	mode := mode - 1
	if(mode < 0)
		mode := maxMode
	cmd = /%mode% ; / is the set effect mode command
	TrayTip, , Mode: %mode%
	socket.Send(cmd)
	; MsgBox %cmd%
	return

^#Numpad6:: ; switch modes up
	mode := mode + 1
	if(mode > maxMode)
		mode := 0
	TrayTip, , Mode: %mode%
	cmd = /%mode%
	socket.Send(cmd)
	; MsgBox %cmd%
	return

^#Numpad5:: ; turn off
	TrayTip, , Leds are off
	socket.Send("=off") ; = is the set control command
	return

^#Numpad0:: ; turn on to static color
	TrayTip, , Leds are on
	cmd := "*"+toHexColor(red,green,blue) ; * is the set all command
	socket.Send(cmd) ; = is the set control command
	return

^#NumpadSub:: ; decreases brightness
	brightness := brightness - incrementAmount
	if(brightness < 0)
		brightness := 0
	cmd = `%%brightness% ;  % is the set brightness mode command. ` is the escape character
	TrayTip, , Brightness: %brightness%
	socket.Send(cmd)
	; MsgBox %cmd%
	return

^#NumpadAdd:: ; increases brightness
	brightness := brightness + incrementAmount
	if(brightness > maxColor)
		brightness := maxColor
	cmd = `%%brightness% ; % is the set brightness mode command
	TrayTip, , Brightness: %brightness%
	socket.Send(cmd)
	; MsgBox %cmd%
	return

^#NumpadDiv:: ; decreases speed
	speed := speed - incrementAmount
	if(speed < 0)
		speed := 0
	cmd = ?%speed% ;  ? is the set brightness mode command
	TrayTip, , Speed: %speed%
	socket.Send(cmd)
	; MsgBox %cmd%
	return

^#NumpadMult:: ; increases speed
	speed := speed + incrementAmount
	if(speed > maxColor)
		speed := maxColor
	cmd = ?%speed% ;  ? is the set brightness mode command
	TrayTip, , Speed: %speed%
	socket.Send(cmd)
	; MsgBox %cmd%
	return

^#Numpad7:: ; increase red amount
	red := red + incrementAmount
	if(red > maxColor)
		red := maxColor

	cmd := "#"+toHexColor(red,green,blue) ; # is the set main color command
	; MsgBox %cmd%
	TrayTip, , Red: %red%
	socket.Send(cmd)

	return

^#Numpad1:: ; decrease red amount
	red := red - incrementAmount
	if(red < 0)
		red := 0

	cmd := "#"+toHexColor(red,green,blue) ; # is the set main color command
	; MsgBox %cmd%
	TrayTip, , Red: %red%
	socket.Send(cmd)

	return

^#Numpad8:: ; increase green amount
	green := green + incrementAmount
	if(green > maxColor)
		green := maxColor

	cmd := "#"+toHexColor(red,green,blue) ; # is the set main color command
	; MsgBox %cmd%
	TrayTip, , Green: %green%
	socket.Send(cmd)

	return

^#Numpad2:: ; decrease green amount
	green := green - incrementAmount
	if(green < 0)
		green := 0

	cmd := "#"+toHexColor(red,green,blue) ; # is the set main color command
	; MsgBox %cmd%
	TrayTip, , Green: %green%
	socket.Send(cmd)

	return

^#Numpad9:: ; increase blue amount
	blue := blue + incrementAmount
	if(blue > maxColor)
		blue := maxColor

	cmd := "#"+toHexColor(red,green,blue) ; # is the set main color command
	; MsgBox %cmd%
	TrayTip, , Blue: %blue%
	socket.Send(cmd)

	return

^#Numpad3:: ; decrease blue amount
	blue := blue - incrementAmount
	if(blue < 0)
		blue := 0

	cmd := "#"+toHexColor(red,green,blue) ; # is the set main color command
	; MsgBox %cmd%
	TrayTip, , Blue: %blue%
	socket.Send(cmd)

	return

toHexColor(r, g, b)
{
	SetFormat, IntegerFast, hex ; To print values as hexadecimal
	colorNum := r*65536 + g*256 + b
	color = 000000%colorNum% ; convert to string and add preceeding zeros
	color := StrReplace(color, "0x") ; replace the 0x from the middle
	color := SubStr( color, -5 ) ; get last 6 characters

	SetFormat, IntegerFast, dec ; sets the print mode back to decimal
	return ""+color ;
}

class Example extends WebSocket
{
	OnOpen(Event)
	{
		TrayTip, ,Connection established to led controller!
		; InputBox, Data, WebSocket, Enter some text to send through the websocket.
		; this.Send(Data)
	}

	OnMessage(Event)
	{
		; MsgBox, % "Received Data: " Event.data
		; this.Close()
	}

	OnClose(Event)
	{
		TrayTip, , Websocket Closed
		this.Disconnect()
	}

	OnError(Event)
	{
		TrayTip, , Websocket Error
	}

	__Delete()
	{
		TrayTip, , Exiting
		ExitApp
	}
}

class WebSocket
{
	__New(WS_URL)
	{
		static wb

		; Create an IE instance
		Gui, +hWndhOld
		Gui, New, +hWndhWnd
		this.hWnd := hWnd
		Gui, Add, ActiveX, vWB, Shell.Explorer
		Gui, %hOld%: Default

		; Write an appropriate document
		WB.Navigate("about:<!DOCTYPE html><meta http-equiv='X-UA-Compatible'"
		. "content='IE=edge'><body></body>")
		while (WB.ReadyState < 4)
			sleep, 50
		this.document := WB.document

		; Add our handlers to the JavaScript namespace
		this.document.parentWindow.ahk_savews := this._SaveWS.Bind(this)
		this.document.parentWindow.ahk_event := this._Event.Bind(this)
		this.document.parentWindow.ahk_ws_url := WS_URL

		; Add some JavaScript to the page to open a socket
		Script := this.document.createElement("script")
		Script.text := "ws = new WebSocket(ahk_ws_url);`n"
		. "ws.onopen = function(event){ ahk_event('Open', event); };`n"
		. "ws.onclose = function(event){ ahk_event('Close', event); };`n"
		. "ws.onerror = function(event){ ahk_event('Error', event); };`n"
		. "ws.onmessage = function(event){ ahk_event('Message', event); };"
		this.document.body.appendChild(Script)
	}

	; Called by the JS in response to WS events
	_Event(EventName, Event)
	{
		this["On" EventName](Event)
	}

	; Sends data through the WebSocket
	Send(Data)
	{
		; MsgBox %Data%
		this.document.parentWindow.ws.send(Data)
	}

	; Closes the WebSocket connection
	Close(Code:=1000, Reason:="")
	{
		this.document.parentWindow.ws.close(Code, Reason)
	}

	; Closes and deletes the WebSocket, removing
	; references so the class can be garbage collected
	Disconnect()
	{
		if this.hWnd
		{
			this.Close()
			Gui, % this.hWnd ": Destroy"
			this.hWnd := False
		}
	}
}

Credit goes to G33kDude/WebSocket.ahk for the websocket class

This is fantastic! Love this approach, I will surely try this out.

Hi @flagstone78,
I haven't used AutoHotKey so far, but will surely give it a try. This is also neat for testing.
If you want, we can put that script into the clients directory of McLighting.
Best regards
Tobias

@toblum I made the pull request to make an AutoHotKey directory in the clients folder.  It also contains an updated version of the script that handles server timeouts and errors better.


Mileston 5: Blog app - controllers specs

In for this milestone, I set up tests on the controllers I recently added to my Blog app.

To the next code reviewer, please go ahead with the review.
Treat it as a First review.
Once done, send me a message on slack and I will update it on our database.


Remove react-native executable warning

This is a change around some (minimal) developer UX. If it doesn't align with the project goals, please disregard.
Given that React Native is distributed as two npm packages, react-native-cli and react-native, I get the desire to point people in the right direction of npm install react-native-cli’ing when installing the executable. This was first added in this commit and then restored in this commit.
I have a project that installs react-native as an npm dependency, and react-native-cli as an npm dev dependency. For some “hybrid” apps that aren't started with react-native init, I would recommend this approach – it keeps all required dependencies installable right from the project.
With this setup, though, any npm execution of react-native <command sources the react-native dependency, not the react-native-cli dev dependency.
For example, with these two dependencies in the same package.json, the following npm script will source react-native and not react-native-cli:
{
  "scripts": {
    "foo": "react-native bundle"
  }
}

Not only will the error message be a bit of a red herring, but sourcing the proper react-native-cli bin will require reaching into node_modules:
{
  "scripts": {
    "foo": "node_modules/react-native-cli/index.js bundle"
  }
}

I get that there are two different, possibly conflicting, pieces of developer UX to consider:

automatically pointing people to the proper npm install -g path after a mistaken npm install -g react-native
allowing developers to install both react-native & react-native-cli and easily executing the latter's bin

I can see the first point winning out over the second, but I thought I'd open this PR to make sure it was considered.
Thanks!

I think @vjeux added the warning for a very good reason - when people do npm install -g react-native by mistake, they should see the warning.
The right way should be npm install -g react-native-cli and I think you can install it globally too and make the CLI work even in a hybrid app?

I think you can install it globally too and make the CLI work even in a hybrid app?

Yes, you can have a dev dependency of react-native-cli and execute it from an npm script, it just requires you manually executing index.js as noted in the PR body:
{
  "scripts": {
    "foo": "node_modules/react-native-cli/index.js bundle"
  }
}

While I somewhat dislike doing this as its depending on some inner details of react-native-cli, it is a fine compromise. Thanks.


Created 0920-number-of-music-playlists.java

File Created: 0920-number-of-music-playlists.java
Language Used: Java
Submission URL: https://leetcode.com/problems/number-of-music-playlists/submissions/1013901828/

Thanks!


Create Branch

After creating your pull request, tick these boxes if they are applicable to you.

[x] I have tested my changes against the review branch (the latest developmental version), and this pull request is targeting that branch as a base
[x] I have tested my changes on Python 3.8 or higher
[x] I have ensured my code is formatted using Black

Description
Related issues (if applicable)

Why do we need this? This pr doesn't add anything at all.

spam


Added the comment regarding the supported regions

Added the comment that the target resources must be in one of the regions supported by the Azure Chaos Studio preview (https://azure.microsoft.com/en-us/global-infrastructure/services/?products=chaos-studio). Only those resources will be listed on the "Targets" blade.

@rseso : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

@rseso : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@sign-off

#sign-off


Add module nvm-auto-use

nvm Auto Use
This module integrates nvm auto use shell integration into Prezto. It will automatically call nvm use in a directory with a .nvmrc file. This recipe is not supported by the nvm development team, but they are accepting pull requests for more examples.

LGTM! Thanks!


Nuke the incorrect permission report on /api/v1/notifications

The permissions created in convertRepo use a minimal perm.AccessModeRead instead of
correctly computing the permission for the repository. This incorrect permission is
then reported to the user.
I do not believe that reporting the permissions is helpful and therefore I propose
we simply null these out. The user can check their permissions using a different
endpoint.
Fix #19759
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

Although a bug - I don't believe this is worth backporting to 1.16.

I'm not sure if this is the best way to fix it. Resolving permissions correctly would be much more useful for clients, and just returning null is a bad way for clients expecting the value. Even if they recognize it, they have to make a different request. Why not include it directly?

this is a nixe quickfix - else we should cache repo permissions and calc them per repoID only once ... then assign it tho all of them as we nill them atm

...


Add documentation about the fetch service.

Description

Fixes # (issue)
Checklist:

[x] I have run ./ci/run_stable_checks.sh
[x] I have reviewed my own code
[ ] I have added tests

This was already written with Docusaurus in mind, right?

It was originally a PR for the old docs – I've just updated it slightly to work with Docusaurus. It may be all over the place as a result.

Currently fixing up the example (running it locally)

I've plugged it into yew-wasm-pack-template and with your fixes the example seems to work (I added a some code to mount the app to the body but apart from that it was fine).

Yeah, I would expect it to be working after I tried to fix it :P. The biggest problem is that the comments no longer properly describe what's happening.
Another, less important thing is that in my opinion the callback passed to the fetch task does a bit too much. Instead of having a GotResponse(Result) message the callback already splits the response into the ReceiveLocation and FetchError messages.
These things are totally subjective, I guess, but in this case the resulting case would be more compact.
The response handler could just be this:
GotResponse(resp) => {
    self.ft = None;

    let Json(data) = resp.into_body();
    match data {
        Ok(location) => self.location = location,
        Err(e) => self.error = e.to_string(),
    }

    self.iss = Some(location);
    true
}

And the callback passed to the fetch task:
let callback = self.link.callback(Msg::GotResponse);

Well, I sure hope it works after I fixed it :P.
Sorry, I misread your earlier comment to mean that there were some issues with its behaviour :)
There are still a few other issues with this code

the resulting case would be more compact.

More compact and simpler sounds better!

I think I've made the requested changes – let me know if there's anything still missing.


HADOOP-16768. SnappyCompressor wrongly truncates the compressed data

JIRA: https://issues.apache.org/jira/browse/HADOOP-16768
Note that perhaps there is the same issue in other compressors.
I ran the tests in both CentOS 7 and Ubuntu 18.04.

@aajisaka I observed the same issue on CentOS 8 as reported in HADOOP-17034. While the patch fixed the error of TestSnappyCompressorDecompressor, TestCompressorDecompressor still fails due to NullPointerException. There was no issue on CentOS 7 with and without the patch.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
18m 55s
trunk passed

+1 :green_heart:
compile
17m  2s
trunk passed

+1 :green_heart:
checkstyle
0m 52s
trunk passed

+1 :green_heart:
mvnsite
1m 27s
trunk passed

+1 :green_heart:
shadedclient
16m 41s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  4s
trunk passed

+0 :ok:
spotbugs
2m 12s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m  8s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 51s
the patch passed

+1 :green_heart:
compile
16m 16s
the patch passed

+1 :green_heart:
javac
16m 16s
the patch passed

-0 :warning:
checkstyle
0m 52s
hadoop-common-project/hadoop-common: The patch generated 1 new + 25 unchanged - 0 fixed = 26 total (was 25)

+1 :green_heart:
mvnsite
1m 28s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m  4s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  4s
the patch passed

+1 :green_heart:
findbugs
2m 15s
the patch passed

_ Other Tests _

-1 :x:
unit
9m 11s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 54s
The patch does not generate ASF License warnings.

106m 59s

Reason
Tests

Failed junit tests
hadoop.io.compress.TestCompressorDecompressor

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2003

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux f17e691c35b6 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c784ba370ee

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/1/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/1/testReport/

Max. process+thread count
1718 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Thanks @iwasakims for the testing. Sorry I missed TestCompressorDecompressor failure on Ubuntu 18.04. I fixed the test.

In addition, I refactored the test to print the following error:
[ERROR] Failures:
[ERROR]   TestCompressorDecompressor.testCompressorDecompressor:69  Expected to find 'testCompressorDecompressor error !!!' but got unexpected exception: java.lang.IndexOutOfBoundsException
	at java.nio.Buffer.checkBounds(Buffer.java:567)
	at java.nio.DirectByteBuffer.get(DirectByteBuffer.java:264)
	at org.apache.hadoop.io.compress.snappy.SnappyCompressor.compress(SnappyCompressor.java:238)
	at org.apache.hadoop.io.compress.CompressDecompressTester$CompressionTestStrategy$2.assertCompression(CompressDecompressTester.java:305)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
20m 20s
trunk passed

+1 :green_heart:
compile
17m 27s
trunk passed

+1 :green_heart:
checkstyle
0m 49s
trunk passed

+1 :green_heart:
mvnsite
1m 23s
trunk passed

+1 :green_heart:
shadedclient
16m 12s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  2s
trunk passed

+0 :ok:
spotbugs
2m  8s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m  5s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 50s
the patch passed

+1 :green_heart:
compile
17m  0s
the patch passed

+1 :green_heart:
javac
17m  0s
the patch passed

-0 :warning:
checkstyle
0m 48s
hadoop-common-project/hadoop-common: The patch generated 1 new + 53 unchanged - 0 fixed = 54 total (was 53)

+1 :green_heart:
mvnsite
1m 25s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 45s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 57s
the patch passed

+1 :green_heart:
findbugs
2m 16s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 29s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 46s
The patch does not generate ASF License warnings.

108m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2003

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 211ba2aa21a4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c784ba370ee

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/2/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/2/testReport/

Max. process+thread count
2445 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 26s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
22m  8s
trunk passed

+1 :green_heart:
compile
18m 26s
trunk passed

+1 :green_heart:
checkstyle
0m 47s
trunk passed

+1 :green_heart:
mvnsite
1m 30s
trunk passed

+1 :green_heart:
shadedclient
18m  1s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 55s
trunk passed

+0 :ok:
spotbugs
2m 10s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m  8s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 51s
the patch passed

+1 :green_heart:
compile
17m 29s
the patch passed

+1 :green_heart:
javac
17m 29s
the patch passed

+1 :green_heart:
checkstyle
0m 45s
the patch passed

+1 :green_heart:
mvnsite
1m 23s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 28s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 54s
the patch passed

+1 :green_heart:
findbugs
2m 16s
the patch passed

_ Other Tests _

-1 :x:
unit
9m 33s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 46s
The patch does not generate ASF License warnings.

115m 42s

Reason
Tests

Failed junit tests
hadoop.fs.ftp.TestFTPFileSystem

hadoop.ha.TestZKFailoverController

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2003

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 92411b9a83c3 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c784ba370ee

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/3/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/3/testReport/

Max. process+thread count
1367 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Added testSnappyCompressDecompressWithSmallBuffer. This test case throws IndexOutOfBoundsException if n = Math.min(n, len); is removed.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 18s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
21m 35s
trunk passed

+1 :green_heart:
compile
18m  5s
trunk passed

+1 :green_heart:
checkstyle
0m 47s
trunk passed

+1 :green_heart:
mvnsite
1m 24s
trunk passed

+1 :green_heart:
shadedclient
17m 40s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 56s
trunk passed

+0 :ok:
spotbugs
2m  6s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m  5s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 52s
the patch passed

+1 :green_heart:
compile
19m 35s
the patch passed

+1 :green_heart:
javac
19m 35s
the patch passed

+1 :green_heart:
checkstyle
0m 48s
the patch passed

+1 :green_heart:
mvnsite
1m 24s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 41s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  1s
the patch passed

+1 :green_heart:
findbugs
2m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
10m 10s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 47s
The patch does not generate ASF License warnings.

117m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2003

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 9c9d4d3b0776 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / aab9e0b16ec

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/4/testReport/

Max. process+thread count
2265 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/4/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
22m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
19m 18s
trunk passed

+1 :green_heart:
compile
17m  4s
trunk passed

+1 :green_heart:
checkstyle
0m 54s
trunk passed

+1 :green_heart:
mvnsite
1m 27s
trunk passed

+1 :green_heart:
shadedclient
16m 36s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  1s
trunk passed

+0 :ok:
spotbugs
2m  8s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m  6s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 50s
the patch passed

+1 :green_heart:
compile
16m 16s
the patch passed

+1 :green_heart:
javac
16m 16s
the patch passed

-0 :warning:
checkstyle
0m 53s
hadoop-common-project/hadoop-common: The patch generated 2 new + 53 unchanged - 0 fixed = 55 total (was 53)

+1 :green_heart:
mvnsite
1m 27s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 57s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  4s
the patch passed

+1 :green_heart:
findbugs
2m 14s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 10s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 55s
The patch does not generate ASF License warnings.

128m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2003

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 1e7c960ec6b3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / aab9e0b16ec

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/5/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/5/testReport/

Max. process+thread count
3251 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/5/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Oops. You can address checkstyle warnings before merge.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
19m  0s
trunk passed

+1 :green_heart:
compile
16m 59s
trunk passed

+1 :green_heart:
checkstyle
0m 52s
trunk passed

+1 :green_heart:
mvnsite
1m 26s
trunk passed

+1 :green_heart:
shadedclient
16m 24s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  6s
trunk passed

+0 :ok:
spotbugs
2m  8s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m  5s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 51s
the patch passed

+1 :green_heart:
compile
16m 12s
the patch passed

+1 :green_heart:
javac
16m 12s
the patch passed

+1 :green_heart:
checkstyle
0m 54s
the patch passed

+1 :green_heart:
mvnsite
1m 28s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 52s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  4s
the patch passed

+1 :green_heart:
findbugs
2m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 13s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 55s
The patch does not generate ASF License warnings.

106m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2003

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 5b285ba109b3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / aab9e0b16ec

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/6/testReport/

Max. process+thread count
2872 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2003/6/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Thank you @iwasakims!


MINOR: Fix docs in quickstart.html

Wrong link for connect-file-*.jar
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@JK-Wang , would you please submit the same PR to kafka-site repo? You can refer to this PR: https://github.com/apache/kafka-site/pull/414 . Thank you.

@showuon Done.


While page is reloading Active proposal become "Failed" for a while

Actual where "Filter by status" filter is present
STR:

Open the Global Feed page
Reload the page

ER:
Active proposals are not become "Failed" while the page is reloading
AR:
While the page is reloading Active proposal become "Failed" for a while

Verified on dev. Fixed

Verified on testnet. Fixed


Error installing React Native

I've tried installing React Native, and installing homebrew, initiating a new project, and everytime im getting an error. I tried updating homebrew but it doesn't do anything.

This seems to be a permission error with your .config folder. Try running sudo chown -R $(whoami) ~/.config to ensure this folder is owned by your current user, and not root.


Add 'poly2tri' package

github: https://github.com/jhasse/poly2tri
hunterized: https://github.com/hunter-packages/poly2tri

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/35010418-add-poly2tri-package?utm_campaign=plugin&utm_content=tracker%2F1032790&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1032790&utm_medium=issues&utm_source=github).

Merged to develop, binaries uploaded, new wiki: https://github.com/ruslo/hunter/wiki/pkg.poly2tri


Automator: update<EMAIL_ADDRESS>dependency in<EMAIL_ADDRESS>

Generated by Automator - 2024-06-05T02:00:21+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio_release-1.20
5dad077d49bce44d67241a8ade2bfabd4f857f18
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest


button does not  auto fit its size

just add this code :  self.contentEdgeInsets =  UIEdgeInsetsMake(0.0f,
0.0f,
0.0f,
marginWidth);
to the tail of drawButton func.

@1037390459 thx, but what do you mean exactly by "not auto fit its size"?


dataframe.query must rely on 'python' engine to deal with NaN-related queries

It turns out that the 'numexpr' engine, which is used by default by pandas.eval cannot handle pd.Series for an unknown reason -> https://stackoverflow.com/questions/51878316/pandas-python-series-objects-are-mutable-thus-they-cannot-be-hashed-in-query-me.
When a user doesn't have the 'numexpr' engine installed on his computer, everything is fine, because in that case pandas.eval will use the 'python' engine instead, but otherwise, the following line of code
annot = annot.assign(hemisphere=hemisphere, structure=structure) \
                       .query('(hemisphere == "L" & mni_x < 0) '
                        '| (hemisphere == "R" & mni_x > 0) '
                        '| (hemisphere.isna() & mni_x == 0)')

will raise the following error
TypeError: 'Series' objects are mutable, thus they cannot be hashed

Great! Seems like the solution is just add engine='python' to the end of the .query() call. If you're interested in submitting a PR for this that would be great! Let me know if you're up for it.


IBotTradeOffer error in new ASF update

2024-08-02 05:09:59|dotnet-1201893|INFO|ASF|InitPlugins() Initializing Plugins...
2024-08-02 05:09:59|dotnet-1201893|ERROR|ASF|InitPlugins() Failed due to error: ItemDispenser, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null
2024-08-02 05:09:59|dotnet-1201893|ERROR|ASF|InitPlugins() System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types.
Could not load type 'ArchiSteamFarm.Plugins.Interfaces.IBotTradeOffer' from assembly 'ArchiSteamFarm, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=504f46588cc351a9'.
   at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
   at System.Reflection.RuntimeModule.GetTypes()
   at ArchiSteamFarm.Plugins.PluginsCore.InitPlugins()
System.TypeLoadException: Could not load type 'ArchiSteamFarm.Plugins.Interfaces.IBotTradeOffer' from assembly 'ArchiSteamFarm, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=504f46588cc351a9'.
2024-08-02 05:10:09|dotnet-1201893|ERROR|ASF|Exit() Exiting with 1 error code!

Thank you for the report! I released a new version, give it a try!
https://github.com/Rudokhvist/ItemDispenser/releases/tag/<IP_ADDRESS>


Latest flutter SDK changed the default text weight on Android

Steps to reproduce
After upgrading to flutter 3.24.3, the Chinese font weight is changed too light on my Android device (Realme). It seems that both OPPO and OnePlus phones have been affected.
Before upgrade:

After upgrade:

Expected results
picture-2 above
Actual results
picture-1 above
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(title: 'Welcome to Flutter'),
    );
  }
}

class MyHomePage extends StatelessWidget {
  final String title;

  MyHomePage({Key? key, required this.title}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Text('这是一段中文字'),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.24.3, on macOS 14.6.1 23G93 darwin-arm64 (Rosetta), locale en-US)
    • Flutter version 3.24.3 on channel stable at /Users/taotao/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2663184aa7 (6 weeks ago), 2024-09-11 16:27:48 -0500
    • Engine revision 36335019a8
    • Dart version 3.5.3
    • DevTools version 2.37.3
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/taotao/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/taotao/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

Hi @taosimple, this was initially reported in https://github.com/flutter/flutter/issues/154166.
It appears to have been fixed on the beta & master channels. Can you check if you are still able to reproduce this on either the beta or master channel?
You can switch to either channel by running
flutter channel master or beta
flutter upgrade

@danagbemava-nc
I checked, it fixed on master, thanks.


SWARM-1833: Improve index available in DeploymentProcessor.

Motivation
Currently, the index only contains classes of the top-level
ClassContainer, e.g. WEB-INF/classes for a WAR. Also we don't load/reuse
attached indexes.
Modifications
Modified DeploymentProducer.index() producer method.
Result
DeploymentProducer.index() returns a composite annotation index
(incl. dependencies, e.g. WEB-INF/lib) and attached indexes (located in
META-INF/jandex.idx) are reused.

Linux failure is:

java.lang.AssertionError: <''> should be equal to :<'Management Interface'> ignoring case
at org.wildfly.swarm.management.console.ManagementConsoleTest.testHomePageShouldHaveCorrectTitle(ManagementConsoleTest.java:47)

But the test passes locally.

Weird, that one usually only fails on Windows!


Variables not translated in bigger environment with controller and factory files

I took over an AngularJS-/Ionic-/Cordova-project without documentation and hand-over and have to change it now. Future will be to use angular-translate from Pascal Precht using locale-language.json files.
We are talking about a bigger application, with separate files for controller and factory for i.e.

game
round
player

Within app.js (which I understand as the "main" JavaScript) I have found/built the following:
'use strict';
angular.module('app', ['ionic', 'config', 'pascalprecht.translate'])
.run(function ($ionicPlatform, $rootScope, $window, $translate, GameState)
{
   (...)

	.config(function ($translateProvider)
	{
		$translateProvider.useStaticFilesLoader(
		{
			prefix: 'locale-',
			suffix: '.json'
		});
	  $translateProvider.preferredLanguage('de');
	})

	(...)
}

Within game.controller.js I have
'use strict';
angular.module('app').controller('GameCtrl', function ($rootScope, $scope, $window, $timeout, $interval, $ionicPlatform, $translate, $ionicModal, $ionicPopup, GameState, Players, Purchase)
{
  (...)

  $scope.remove = function ()
  {
	var confirmGameRoundDelete = $translate.instant('GAME_ROUND_DELETE');
	var confirmCancelText = $translate.instant('GAME_CANCEL');
	var confirmOkText = $translate.instant('GAME_OK');

    $ionicPopup.confirm({
      cssClass: 'rules__popup',
      title: confirmGameRoundDelete,
      subTitle: '',
      cancelText: confirmCancelText,
      okText: confirmOkText,
      okType: 'button-balanced'
    }).then(function (confirmed)
	{
      if (confirmed)
	  {
        GameState.get().removeRound();
      }
    });
  };

Here the translation works as expected.
However when talking about players.factory.js the translation does not work:
'use strict';
angular.module('app').factory('Players', function ($window, $translate)
{
  var player1 = $translate.instant('PLAYERS_1');
  var player1 = $translate.instant('PLAYERS_1');
  var player1 = $translate.instant('PLAYERS_1');
  var player1 = $translate.instant('PLAYERS_1');

  console.log("player1:", PLAYERS_1);
  var DEFAULTS = [
	player1,
	player2,
	player3,
	player4,
	];

	(...)
}

console.log (like the HTML-file "behind" shows the variable itself = PLAYERS_1, not the translation.
I believe I overlook something obvious, to have it working, but I am lost in knowing what. Therefore please help.

Within a factory method, you are in the bootstrapping phase still. Translations are being resolved asynchronous.
First: do not resolve translations in the „constructors“, only at runtime.
Second: alternately resolve them using the async way (promise) which would resolve later.

@knalli : Thanks so far.
Not sure, I understand what I have to do in detail here. Do you think, I should follow these lines?

Yeah, that is a good resource getting the main thing about our async loading.
You should always remember: we load translations asap, but this is completed after running every constructor/factory/init method of any initial angular service and rendered components/filters.


Enable markdownKeymap for editor

It is currently quite annoying that when writing a (bullet) list, you need to type -  for every item again. Luckily, CodeMirror can automatically continue lists, like many other editors do.
This PR enables the two keybinds provided by https://github.com/codemirror/lang-markdown#user-content-markdownkeymap.
It binds Enter to insertNewlineContinueMarkup and Backspace to deleteMarkupBackward.
Thank you for your work on this project!

Perfekt, thanks!

Thanks for merging!


Configured terminal environments aren't used by tools

Type: Bug
When connecting to remote workspace (SSH), the tools aren't using environment set for teminal.
I.e. when run git fetch in remote terminal, it's connecting fine, but when I ask VS Code to execute git fetch via extension, it fails to authenticate.
The cause is it loses $SSH_AUTH_SOCK about 20 minutes into session on all the jumps and reconnects, and the redirected socket (the one with stable name coming from ~/.ssh/rc and set up through terminal.integrated.env.linux) is not passed to the tools.


No syntax highlighting in new expressions.

Environment data
dotnet --info output:
.NET Command Line Tools (1.0.0-preview4-004233)
Product Information:
Version:            1.0.0-preview4-004233
Commit SHA-1 hash:  8cec61c6f7
Runtime Environment:
OS Name:     Mac OS X
OS Version:  10.11
OS Platform: Darwin
RID:         osx.10.11-x64
Base Path:   /usr/local/share/dotnet/sdk/1.0.0-preview4-004233
VS Code version:
C# Extension version: 1.6.2
Steps to reproduce
Write statements like: new ClassA();
Expected  behavior
"ClassA" should be recognised and display with syntax highlighting, just like what's in Visual Studio.
Actual behavior
No syntax highlighting for "ClassA" in the new statement.

Hi @cateyes99:
I recommend you try out the latest beta of C# for Visual Studio Code. (Be sure to follow our instructions for Installing Beta Releases.) We've completely rewritten the TextMate grammar used for syntax highlighting from the ground up, and you should see much improved highlighting, and yes, 'new' expressions are definitely much better.
Let me know if the new TextMate grammar in the latest beta does not work better for you.
Also, note that semantic highlighting of identifiers (e.g. highlighting class names differently from other identifiers) is not available today. We're tracking https://github.com/Microsoft/vscode/issues/585 for an API that would allow us to add this feature in the future.

thanks, now it works in v1.7.0, sweet 👍


FileOutputStream is never closed

The output file stream is not closed, so it is still in use by the Java process after the code runs. I noticed this when trying to delete the output files right afterwards.

@holgerl Good point, thanks :) Merged.


Window icons don't work in Safari

The meta_card's icon attribute fails to apply in Safari. Ref examples/meta_icon.py.

Current solution correctly changes favicon href url (I verified in DOM). A few hacks tried with no luck:

Manually create a new HTML node and replace the existing one to trigger favicon update instead of just editing the href.
Remove favicon links from index.html completely and add them via JS within meta.tsx. Seems like webkit reads favicon during parsing phase only, meaning the index.html has to already have the correct favicons set when being downloaded.

Wasn't able to find a solution to make this work. Finally, found a brief mention in this webkit bug report. Citing:
... Since we quite purposefully don't allow dynamic changes/animations to the favicon ...
Related bug - Safari sometimes favors root favicon.ico instead of the value provided in link.
This leaves us with the only option of directing app devs to replace favicon.ico that we ship with Go server and deprecate meta_card's icon prop. @lo5

Deprecation is out of question since this feature already works in other popular browsers. Let's add a note to the docstring indicating that this does not work in Safari.


[bulk] Validation: metadata and absolute links updated

Docs Build status updates of commit 8b45223:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/legacy/core-serializer-json-gson-readme.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/core-serializer-json-jackson-readme.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/core-test-readme.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/cosmos-readme.md
:white_check_mark:Succeeded
View (azure-java-legacy)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Global effort to fix build validation errors
@alzimmermsft
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you’d like to see. Thank you!

Docs Build status updates of commit 4148c26:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/legacy/core-serializer-json-gson-readme.md
:bulb:Suggestion
View (azure-java-legacy)
Details

docs-ref-services/legacy/core-serializer-json-jackson-readme.md
:bulb:Suggestion
View (azure-java-legacy)
Details

docs-ref-services/legacy/core-test-readme.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/cosmos-readme.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/core-serializer-json-gson-readme.md

Line 22, Column 5: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable' will be broken in isolated environments. Replace with a relative link.
Line 22, Column 5: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable. Otherwise, remove the view parameter.

docs-ref-services/legacy/core-serializer-json-jackson-readme.md

Line 22, Column 5: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable' will be broken in isolated environments. Replace with a relative link.
Line 22, Column 5: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable. Otherwise, remove the view parameter.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Adding sharding CLI params to helper

This PR adds sharding parameters to the helper binary to start the HTTP shard server (alongside the MPC server). The existing network.toml argument is expected to describe the entire network, with sharding peers included. Each pod in this configuration will have 2 ports, one for MPC and one for sharding. The certificate will be shared among those two. The network.toml file is expected to have a flat structure with all peer configs as a simple list.
Here's an example with certificate removed for clarity. Note how we added a new field shard_port, that's required for sharding configurations.
[[peers]]
certificate = "..."
url = "helper1.prod.ipa-helper.shard0.dev:443"
shard_url = "helper1.prod.ipa-helper.shard0.dev:444"

[peers.hpke]
public_key = "f458d5e1989b2b8f5dacd4143276aa81eaacf7449744ab1251ff667c43550756"

[[peers]]
certificate = "..."
url = "helper2.prod.ipa-helper.shard0.dev:443"
shard_url = "helper2.prod.ipa-helper.shard0.dev:444"

[peers.hpke]
public_key = "62357179868e5594372b801ddf282c8523806a868a2bff2685f66aa05ffd6c22"

[[peers]]
certificate = "..."
url = "helper3.prod.ipa-helper.shard0.dev:443"
url = "helper3.prod.ipa-helper.shard0.dev:444"

[peers.hpke]
public_key = "55f87a8794b4de9a60f8ede9ed000f5f10c028e22390922efc4fb63bc6be0a61"

[[peers]]
certificate = "..."
url = "helper1.prod.ipa-helper.shard1.dev:443"
url = "helper1.prod.ipa-helper.shard1.dev:444"

[peers.hpke]
public_key = "f458d5e1989b2b8f5dacd4143276aa81eaacf7449744ab1251ff667c43550756"

[[peers]]
certificate = "..."
url = "helper2.prod.ipa-helper.shard1.dev:443"
url = "helper2.prod.ipa-helper.shard1.dev:444"

[peers.hpke]
public_key = "62357179868e5594372b801ddf282c8523806a868a2bff2685f66aa05ffd6c22"

[[peers]]
certificate = "..."
url = "helper3.prod.ipa-helper.shard1.dev:443"
url = "helper3.prod.ipa-helper.shard1.dev:444"

[peers.hpke]
public_key = "55f87a8794b4de9a60f8ede9ed000f5f10c028e22390922efc4fb63bc6be0a61"
...

Possibly some updates to draft are needed to support this PR? You can see the error I am getting at https://draft-mpc.vercel.app/query/view/chief-seam2024-11-15T2004. Unfortunately the error doesn't directly indicate what the problem is. (My speculation is that there is an early error return in helper::server which leads to the runtime being dropped directly in async code, before reaching the call to shutdown_background, resulting in the panic.)

This is the error I found:
2024-11-15T20:05:27.422429 - 2024-11-15T20:05:27.418438Z ERROR ipa_core::error: ThreadId(1) "main" panicked at /home/ec2-user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.37.0/src/runtime/blocking/shutdown.rs:51:21:
2024-11-15T20:05:27.423215 - Cannot drop a runtime in a context where blocking is not allowed. This happens when a runtime is dropped from within an asynchronous context.
2024-11-15T20:05:27.423552 - stack trace:
2024-11-15T20:05:27.423830 -    0: ipa_core::error::set_global_panic_hook::{{closure}}
2024-11-15T20:05:27.424064 -    1: std::panicking::rust_panic_with_hook
2024-11-15T20:05:27.424289 -    2: std::panicking::begin_panic_handler::{{closure}}
2024-11-15T20:05:27.424508 -    3: std::sys::backtrace::__rust_end_short_backtrace
2024-11-15T20:05:27.424722 -    4: rust_begin_unwind
2024-11-15T20:05:27.424933 -    5: core::panicking::panic_fmt
2024-11-15T20:05:27.425153 -    6: tokio::runtime::blocking::shutdown::Receiver::wait
2024-11-15T20:05:27.425370 -    7: tokio::runtime::blocking::pool::BlockingPool::shutdown
2024-11-15T20:05:27.425583 -    8: core::ptr::drop_in_place<tokio::runtime::blocking::pool::BlockingPool>
2024-11-15T20:05:27.425794 -    9: helper::server::{{closure}}
2024-11-15T20:05:27.426004 -   10: <core::pin::Pin<P> as core::future::future::Future>::poll
2024-11-15T20:05:27.426212 -   11: tokio::runtime::scheduler::current_thread::Context::enter
2024-11-15T20:05:27.426418 -   12: tokio::runtime::context::scoped::Scoped<T>::set
2024-11-15T20:05:27.426627 -   13: tokio::runtime::scheduler::current_thread::CoreGuard::block_on
2024-11-15T20:05:27.426835 -   14: tokio::runtime::context::runtime::enter_runtime
2024-11-15T20:05:27.427141 -   15: tokio::runtime::runtime::Runtime::block_on
2024-11-15T20:05:27.427356 -   16: helper::main
2024-11-15T20:05:27.427566 -   17: std::sys::backtrace::__rust_begin_short_backtrace
2024-11-15T20:05:27.427786 -   18: std::rt::lang_start::{{closure}}
2024-11-15T20:05:27.428003 -   19: std::rt::lang_start_internal
2024-11-15T20:05:27.428215 -   20: main
2024-11-15T20:05:27.428428 -   21: __libc_start_call_main
2024-11-15T20:05:27.428637 -   22: __libc_start_main_alias_1
2024-11-15T20:05:27.428846 -   23: _start
2024-11-15T20:05:27.429055 -
2024-11-15T20:05:27.429263 - thread 'main' panicked at /home/ec2-user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.37.0/src/runtime/blocking/shutdown.rs:51:21:
2024-11-15T20:05:27.429508 - Cannot drop a runtime in a context where blocking is not allowed. This happens when a runtime is dropped from within an asynchronous context.
2024-11-15T20:05:27.429723 - note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2024-11-15T20:05:27.430621 - updating status: status=<Status.CRASHED: 9>

as Andy pointed, it does not seem that this is the root cause - runtime is likely getting dropped because of a panic in 2024-11-15T20:05:27.425794 -    9: helper::server::{{closure}}. In release builds it is hard to reproduce, so it is probably required to just run it locally in debug mode


Consider removing docs from npm

Out of 2.6MB of this module the docs take 1.9MB. How often people use docs from node_modules folder? A compromise would be switching to google fonts link as OpenSans itself takes 1MB.

Which version did you install? I cannot reproduce this with the latest version.

@vorg No problem in latest version
<EMAIL_ADDRESS>

True true. It's on of my deps using it so i guess i have to bug them. Thanks!


Add Mizuno and Trinidad support

Server now automatically picks them up if
they register a proper Rack::Handler.
Also suggest them in the Gemfile.
This is a preliminary request for testing, please do not merge yet, especially as Trinidad has not released their Rack support yet.
In the end, I found Mizuno the better experience, especially since it does not rely on jruby-rack.

@skade What's the status with this, seems they've added the rack handler?

Trinidad seems to work right now, can we add it? @skade ?

I just checked and did not get mizuno or trinidad working in a fire-and-forget session. I'll try trinidad master next.

Sorry, my fault. Trinidad works now, still no support on the mizuno side. I pushed some updates.

Great! lets merge this in before release @DAddYE?


Problems with asciiart of sub-widget

I am not sure if this is correct use of the API or not, but at least my code seem to not correctly make use of set_from_asciiart(). I have made a somewhat minimal example below:
import remi.gui as gui
from remi import start, App

class MyApp(App):

    def main(self):
        self.config = gui.GridBox(width='100%', height='100%', style={'margin': '0px auto'})
        self.main_widget = gui.TabBox(width='100%', height='100%')
        # A grid for the configuration tab
        self.config.set_from_asciiart("""
                        |label1  |           |
                        |        |           |
                        |label2  | label3    |
                        """, 1, 1)

        mydict = {}
        for i in range(5):
            mydict[f'label{i}'] = gui.Label(f'label{i}')

        self.config.append(mydict)
        self.main_widget.add_tab(self.config, 'Config', None)

        return self.main_widget

if __name__ == "__main__":
    start(MyApp, title="My App", debug=True)

Now I am expecting to see the three labels according to the layout defined in the asciiart, but instead I just get a vertical list of the 5 labels in the dictionary.

Hello @Eothred, thank you a lot for reporting. The TabBox widget forces the css 'display' attribute of the appended widgets. This causes that GribBox (that must have 'display':'grid') gets the attribute set to 'block'. This causes wrong layouting.
The solution is to append the gridbox to a container, and then, the container to the tabbox.
The widgets tree would be:
TabBox
    Container
        GridBox

Regards


update also build pipeline config map in push pipeline when new bundles

are built
STONEBLD-2277
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

dependent on https://github.com/redhat-appstudio/infra-deployments/pull/3629

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest


Please add support for missing value recognition in lue_translate

Code is part of #23 's branch (gh23), by accident.


flogo cli:  If /tmp and the project dir are on different linux file systems the copy/rename step fails

With this sort of error:
Error renaming executable: rename /tmp/flogo251123746/TownCrier/bin/TownCrier /local/home/wcn00/go/src/github.com/wcn00/pulsartest/ptest/TownCrier: invalid cross-device link
In this case the /tmp and /local file systems are physically separate so a rename syscall will not work.  I think this error should be intercepted and a copy / delete approached used if it fails.

A template for a fix...
commands.go.diff.TXT


Bad interaction between xtensor/view/zeros.

Hi. Another small challenge for you below, which took me few days to get to the bone. To sump up, when subtracting some zeros to a 2D xtensor, through a view, it switches the indices.
#include <xtensor/xtensor.hpp>
#include <xtensor/xio.hpp>

int main( int argc, char** argv ){

    xt::xtensor<float, 2> xtensor_matrix = {
        { 1, 2, 3 },
        { 4, 5, 6 },
        { 7, 8, 9 }
    } ;
    xt::xtensor<float, 2> xtensor_zeros = xt::zeros<float>(xtensor_matrix.shape()) ;
    auto xtensor_view = xt::view(xtensor_matrix,xt::all(),xt::all()) ;

    std::cout << "matrix\n" << xt::view(xtensor_matrix,xt::all(),xt::all()) << std::endl ;
    std::cout << "matrix - zeros\n" << (xt::view(xtensor_matrix,xt::all(),xt::all())-xtensor_zeros) << std::endl ;

    return 0 ;
}

This is a bug in the xstrided_view, used by operator<<.
The following should print the correct result:
xt::xtensor<float, 2> xtensor_matrix = {
        { 1, 2, 3 },
        { 4, 5, 6 },
        { 7, 8, 9 }
    } ;
    xt::xtensor<float, 2> xtensor_zeros = xt::zeros<float>(xtensor_matrix.shape()) ;
    auto xtensor_view = xt::view(xtensor_matrix,xt::all(),xt::all()) ;
    xt::xtensor<float, 2> res = xtensor_view - xtensor_zeros;
    std::cout << "matrix - zeros\n" << res << std::endl;

Hopefully #769 should be a sufficient fix.
Basically, we were printing in column major layout :)
Waiting on the build to pass and we will make a patch release.

Thanks for the report!

Do you think this problem in xstrided_view may affect other operation ? Before I came to this small demo code, I was originally having a computing problem in a more complex code, heavily relying on xt::views.

The issue concerns strided views on expressions that have a dynamic layout.

Also notice that xt::view returns an xview and not an xstrided_view, so this bug should not impact your code heavily relying on xt::view.

@chavid xtensor 0.15.8 was released with that fix included.


Conditional slots (slot in if)

Hello, this package is great.
One issue encountered. It would be nice to be able to conditionally add slots:
{% card %}
  {% if perms.can_edit %}
    {% slot action %}Edit{% endslot %}
  {% endif %}
  …
{% endcard %}

However, the slot ends up being rendered regardless of the conditional block.

Hello,
At the moment this is not supported, however, it sounds like an interesting feature so I will look into it.
In the meantime, there are several alternatives to this.

You could place the if condition inside the slot

{% card %}
	{% slot action %}
		{% if perms.can_edit %}
			Edit
		{% endif %}
	{% endslot %}
{% endcard %}

However, this may not be what you want if you have logic around the slot existing inside the component, e.g. {% if slots.action %}{% render_slot slots.action %}{% endif %}.

You could pass an extra attribute to the slot and access it inside the component

{% card %}
	{% slot action show=perms.can_edit %}
		Edit
	{% endslot %}
{% endcard %}

...

	{% if slots.action.attributes.show %}
		{% render_slot slots.action %}
	{% endif %}

The component could also be split into multiple smaller components instead of using slots

{% card %}
	...

	{% if perms.can_edit %}
		{% card_action %}
			Edit
		{% endcard_action %}
	{% endif %}

	...
{% endcard %}

These may or may not make sense depending on your use case.


[Backport] Support projection after sorting in SQL

Backport of #5788 to 0.12.3.

After this is merged, we need to backport #5912 too, since it fixes a bug in this patch.


[New Feature]: Update PackageName of Mozilla.Firefox.Nightly

Description of the new feature/enhancement
Replace current name Nightly with a more descriptive name such as Mozilla Firefox (Nightly) (like the Beta beta) or Mozilla Firefox Nightly (like the ESR package).
Input for which name to use would be appreciated.
Proposed technical implementation details (optional)
No response

That is Mozilla's fault

Using ProductCode's would also be difficult as its Nightly 96.0a1 (x64 en-US)

Its safe to assume there is not any name aliasing functionality?

No, we can probably work around this by using AppsAndFeaturesEntries when™ that gets supported with all the function

Close with reason: This was fixed;


go-kosu: Add LatestOrders RPC endpoint

Overview
Add LatestOrders RPC endpoint.
Description
With these changes, we can call the kosu_latestOrders RPC endpoint to get the latest persisted orders.
The Orders are persisted in a fixed buffer, the size of the buffer is defined as ConsensusParam.OrdersLimit, and it needs to be set in the genesis file.
Testing instructions
To test this I enabled the --rpc flag in one of the local testnet. So you can perform RPC requests against the node0.
Create one or more orders and call kosu-cli query latest-orders

Unfortunately, I accidentally disabled to WS support in a previous commit.
I'll re-enable it in this one for the sake of simplicity.
Also, pagination will be added.

I'm tagging it with WIP, for some reason, the testnet is crashing and I'm working to figure out why.
Here's the log:
kosu-node-1  | E[2019-10-10|10:39:46.171] CONSENSUS FAILURE!!!                         module=consensus err="enterPrecommit: +2/3 prevoted for an invalid block: Wrong Block.Header.AppHash.  Expected FFE52596F86905C9C69E27233880BA6AF175FD3221124F98FC09B1242161E2A7, got 7F8894F70FAD5F3E98F4E8C9B60198A916DC587DDF446D9F7DAA4AA815996052" stack="goroutine 208 [running]:\nruntime/debug.Stack(0xc002d81508, 0xf2bc40, 0xc002d3cd10)\n\t/usr/local/go/src/runtime/debug/stack.go:24 +0x9d\ngithub.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine.func2(0xc000091c00, 0x1255778)\n\t/go/pkg/mod/github.com/tendermint/tendermint@v0.32.4/consensus/state.go:602 +0x57\npanic(0xf2bc40, 0xc002d3cd10)\n\t/usr/local/go/src/runtime/panic.go:522 +0x1b5\ngithub.com/tendermint/tendermint/consensus.(*ConsensusState).enterPrecommit(0xc000091c00, 0x2, 0x0)\n\t/go/pkg/mod/github.com/tendermint/tendermint@v0.32.4/consensus/state.go:1146 +0x15b9\ngithub.com/tendermint/tendermint/consensus.(*ConsensusState).addVote(0xc000091c00, 0xc002cfe640, 0xc000bdfb90, 0x28, 0x105, 0x105, 0x105)\n\t/go/pkg/mod/github.com/tendermint/tendermint@v0.32.4/consensus/state.go:1657 +0xf10\ngithub.com/tendermint/tendermint/consensus.(*ConsensusState).tryAddVote(0xc000091c00, 0xc002cfe640, 0xc000bdfb90, 0x28, 0xc002e3f6e0, 0xc002d81c28, 0xcbfa7d)\n\t/go/pkg/mod/github.com/tendermint/tendermint@v0.32.4/consensus/state.go:1521 +0x5c\ngithub.com/tendermint/tendermint/consensus.(*ConsensusState).handleMsg(0xc000091c00, 0x1399020, 0xc002cd6028, 0xc000bdfb90, 0x28)\n\t/go/pkg/mod/github.com/tendermint/tendermint@v0.32.4/consensus/state.go:688 +0x260\ngithub.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine(0xc000091c00, 0x0)\n\t/go/pkg/mod/github.com/tendermint/tendermint@v0.32.4/consensus/state.go:633 +0x66d\ncreated by github.com/tendermint/tendermint/consensus.(*ConsensusState).OnStart\n\t/go/pkg/mod/github.com/tendermint/tendermint@v0.32.4/consensus/state.go:334 +0x13a\n"

Removing the WIP tag, it was a local dirty state :man_facepalming: :gun:


https://equinor.com.br redirected to equinor.com instead of https://www.equinor.com.br

https://equinor.service-now.com/selfservice?id=ticket&table=sc_req_item&sys_id=990546d3471fed1041bad352e36d43e9

Done!


VMSS create: switch default vm size from standard_d1_v2 to standard_ds1_v2

//CC: @gatneil  @mayurid @twitchax
Related with https://github.com/Azure/azure-cli/issues/2030

I will find a time to switch this default

I agree. We have DSv3 as well in a lot of regions, but it looks like it still needs to end up in a few more regions, so DSv2 is probably still the best default
https://azure.microsoft.com/en-us/global-infrastructure/services/

@yugangw-msft, have we gotten any update from Portal on this?

@gatneil, any update on when this Portal fix is happening?


Support for C++17

Fixes #1526
Changes:

Set the C++ version to 17 in the top-level CMakelist.txt file
Replaced any and optional dependencies with versions from the standard library
Removed the any and optional dependencies

I noticed there was a comment in src/py-opentimelineio/bindings-common/casters.h about some Python binding code that could be removed with moving to C++17. Is there any additional code that can be removed?

Codecov Report

Merging #1530 (224f2f3) into main (80d341b) will increase coverage by 0.20%.
The diff coverage is 51.01%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1530      +/-   ##
==========================================
+ Coverage   80.11%   80.32%   +0.20%
==========================================
  Files         197      197
  Lines       21699    21690       -9
  Branches     4299     4251      -48
==========================================
+ Hits        17384    17422      +38
  Misses       2170     2170
+ Partials     2145     2098      -47

Flag
Coverage Δ

py-unittests
80.32% <51.01%> (+0.20%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/opentimelineio/anyDictionary.h
87.69% <0.00%> (ø)

src/opentimelineio/anyVector.h
82.85% <ø> (ø)

src/opentimelineio/composable.cpp
54.83% <0.00%> (ø)

src/opentimelineio/composable.h
100.00% <ø> (ø)

src/opentimelineio/externalReference.h
100.00% <ø> (ø)

src/opentimelineio/generatorReference.h
100.00% <ø> (ø)

src/opentimelineio/imageSequenceReference.h
48.27% <ø> (ø)

src/opentimelineio/serializableCollection.cpp
47.72% <ø> (+2.27%)
:arrow_up:

src/opentimelineio/serializableCollection.h
34.37% <ø> (ø)

src/opentimelineio/serializableObject.cpp
48.59% <0.00%> (ø)

... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d341b...224f2f3. Read the comment docs.

The CI error on macOS is:
/Users/runner/work/OpenTimelineIO/OpenTimelineIO/src/opentimelineio/serializableObject.h:241:40: error: 'any_cast<const opentimelineio::v1_0::AnyVector &>' is unavailable: introduced in macOS 10.13
[327](https://github.com/AcademySoftwareFoundation/OpenTimelineIO/actions/runs/3964023896/jobs/6792648407#step:3:334)
                    AnyVector const& av = std::any_cast<AnyVector const&>(source);
[328](https://github.com/AcademySoftwareFoundation/OpenTimelineIO/actions/runs/3964023896/jobs/6792648407#step:3:335)
                                               ^
[329](https://github.com/AcademySoftwareFoundation/OpenTimelineIO/actions/runs/3964023896/jobs/6792648407#step:3:336)
        /Applications/Xcode_14.0.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/any:596:12: note: 'any_cast<const opentimelineio::v1_0::AnyVector &>' has been explicitly marked unavailable here
[330](https://github.com/AcademySoftwareFoundation/OpenTimelineIO/actions/runs/3964023896/jobs/6792648407#step:3:337)
        _ValueType any_cast(any const & __v)
[331](https://github.com/AcademySoftwareFoundation/OpenTimelineIO/actions/runs/3964023896/jobs/6792648407#step:3:338)
                   ^

It mentions macOS 10.13 which seems odd since the GitHub actions are setup to use macos-latest.

Looking good :) As I mentioned elsewhere I think a strategy would be to land this in a feature branch so that we can play and iterate as we work towards the VFX2020 maintenance release that will allow us to cleanly break from C++14 dev.
Perhaps a peek at git logs can reveal who to summon for the note on the code to remove in the bindings (hopefully not me, as I don't recall that aspect ;) )

The note regarding pybind11 was from me. Once we use c++ 17, we can safely remove the two type casters that we had for supporting std::optional. Pybind11 will detect that we compile with 17 and will take care of all that magically, which means we don't need these casters anymore.

I fixed the macOS CI by adding a minimum version to the CMakeLists.txt:
set(CMAKE_OSX_DEPLOYMENT_TARGET "10.14" CACHE STRING "Minimum OS X deployment version")

The "docs / check-links" test is still failing, but I think that's a general issue right now?

@darbyjohnston by feature branch I mean on this repo. In other words land OpenTimelineIO:cxx17 on this repo for official support, as opposed to feature branch that exists on your repo.

OK, I just pushed the "cxx17" branch to the main repo.

@darbyjohnston Sweet :) Why don't we close this, and further iteration can be done as PRs against the branch?

If you need testers, I can probably test with my JS bindings.

Here is the new PR based on a branch in the main repo:
https://github.com/AcademySoftwareFoundation/OpenTimelineIO/pull/1539
@JeanChristopheMorinPerso If you have time to test with your JS bindings that would be great


Error with SQLite with new version

Hello,
I have a website using SQLite database and Adminer plugin. Website launched since months, everything worked perfectly until recently.
Now, when I go to the adminer page, It return an error :

session_start(): open(/var/lib/php/session/sess_p80es0trm1e5hppnb4f5m5bgf0, O_RDWR) failed: No such file or directory (2)
/plugins/martin/adminer/classes/adminer-4.3.1-en.php line 159

Don't know why, the only think I touched about this website is to update plugins. So it's probably related to a change in a recent update.
Best regards,
Alex

Hello @Alex360hd
I've installed a fresh copy of October and Adminer plugin but can't reproduce this error.
Looks session related, have you tried to logout and login (or open on incognito) ?


Scala versions, DL4J/ND4J/DataVec etc modules, 2.12 release

Up to this point, we have released only Scala 2.10 and 2.11 versions of our libraries.
Scala 2.12 is seeing increasing usage (November 2016), and Scala 2.13 is also out now (June 2019).
Adding scala 2.12 is a matter of when, not if. If possible, it would be nice to have Scala 2.12 in the 1.0.0-beta5 release, along with the 2.10 and 2.11, especially given the recent improvements to ND4S.
Even if we don't add 2.12 support for beta5, we'll still need some changes due to the Play framework version upgrade (no 2.10 support).
Our main complication is that certain libraries (and, especially a single version of some libraries) don't support all of Scala 2.10, 2.11 and 2.12.
The end result:

Our simple "find and replace" change-scala-versions.sh script will probably need some more special cases

For example, "Use version X for scala 2.10, use version Y for scala 2.11" etc

We may need a few version upgrades for some dependencies, to a version that has all of 2.10/2.11/2.12 versions
In some cases, we will need to exclude whole modules from the build/release for a given Scala version. For example:

No Scala 2.12 for DL4J Spark 1.0
No Scala 2.10 for DL4J UI (once this is merged: https://github.com/eclipse/deeplearning4j/pull/8098)

In some other cases, a minor reorganization of the tests or test dependencies may be required (for example, Spark has deeplearning4j-play_2.xx test scope dependency; can't build Spark 1 2.10 if there's no deeplearning4j-play_2.10)

Here's the filtered/processed output of mvn dependency:list on the PR above (which has been rebased to master). More work is needed,
https://gist.github.com/AlexDBlack/b0a750f03f2cc8cf79fa30353cd4445c
Script used to process the output: https://gist.github.com/AlexDBlack/2f16f3ee01f159c785f36eadacdec4c4
Related:
https://github.com/eclipse/deeplearning4j/issues/6269
https://github.com/eclipse/deeplearning4j/issues/5259

After talking internally: we have decided to drop Spark 1.x, and also drop scala 2.10
1.0.0-beta5 (and future) releases will be Spark 2.x only, and both Scala 2.11 and 2.12


Setup Resource Group

Setup initial resource group (as a test environment)
Grant project users contributor access

we have hit the tenant limit for service principals - I'm raising internally for an update.


Restart of scheduler should mark running jobs as canceled.

Perform housekeeping on restart.  If old run left jobs in a running state, then the restart should know to mark them as canceled, otherwise they'll ghost in the system forever?
-C.

I believe this already done?  Strike jobs are cancelled and restarted when restarting scheduler.


Is any change needed for the TLS 1.0 deprecation?

We've received notification of TLS 1.0 deprecation. Since, by calling the API server, the library is a client to it; is this library going to be affected in version 2.1.0?
If so, is there anything that can be done that doesn't involve updating its version?

@chris-fa You should be fine. Let me know if you have experienced any complications regarding this

I can confirm that the official release of Node handles this for you. No action needed


python 2 no longer in alpine repository

File: get-started/02_our_app.md
The Dockerfile here needs to be changed to
# syntax=docker/dockerfile:1
FROM node:12-alpine
RUN apk add --no-cache python3 g++ make
WORKDIR /app
COPY . .
RUN yarn install --production
CMD ["node", "src/index.js"]

where on the first RUN command python changed to python3
Reason for this is that python (python 2) is no longer in the alpine repository since alpine version 3.5

Thanks for reporting; I think this should be fixed by https://github.com/docker/docker.github.io/pull/13826, which is now published on docs.docker.com.
Let me go ahead and close this ticket, but feel free to continue the conversation if the issue is not resolved 👍


python 3.13

Btw, do not forget to update pyproject as well

Btw, what is the actual project you are using? that-depends or modern-di?

@Lancetnik for projects with sqlalchemy I'm moving to modern-di, because it's easier to manage orm sessions with scopes.
For simpler projects, where scopes are not needed, that-depends is used

@Lancetnik for projects with sqlalchemy I'm moving to modern-di, because it's easier to manage orm sessions with scopes.
For simpler projects, where scopes are not needed, that-depends is used

Sounds like a useless complexity, isn't it? Why are you using that-depends if modern-di is better? Do you thinking about slowly deprecation of the current lib to prior to modern-di?

@Lancetnik

Sounds like a useless complexity, isn't it?

I'm panning to support both libraries, but with focus on promoting modern-di.

Why are you using that-depends

to be fair, I don't write new projects with that-depends. I had migrated some services to test modern-di in production and it works great. I think, some day we will migrate other services to modern-di as well


Fix network to read upper case service. And stop it perform some unte…

…sted code

The comment out code may need to be used later


feat: Add compatibility with windows, cmd and pwsh

I use it daily on two different Win boxes with no issues.
I don't have access to a Linux box right now, so it hasn't been tested there. My main concerns are with lines 55 and 139, where I might have introduced bugs.
Hope it's useful

Appreciate the PR I have access to both a MacOS and Linux machine and will test.

Running this on Windows, this works with no issues, apart from the fact that I have to manually unset the shellslash option before I start the first debug session, since else netcoredbg wont recognize my breakpoints, regardless of wether the option is already unset.


Add Jacoco aggregation for coverage.

Refactoring Alpha into modules resulted in coverage to be computed only individually for each module. This results in many lines of code being considered not hit by any test, while they indeed are tested in (functional-/integration-)tests of another module. This PR tries to rectify coverage computation by using Jacoco's aggregate plugin on the top-level of the build.

@lorenzleutgeb Since you are the one with the most Gradle experience in our team, could you have a look at this PR and check it? Thanks!


SQL Server: Must declare the scalar variable... when DECLARE lines end with ';'

System information:

Operating system (distribution) and version: Windows 10 Pro
DBeaver version 6.3.3

Connection specification:

Database name and version: SQL Server, whichever version

The code
DECLARE @AcceptableSymbols VarChar(100);
SET @AcceptableSymbols = '_0123456789';
SELECT
'ColumnName'                        AS Type,
Table_Name + '.' + Column_Name      AS Problem
FROM INFORMATION_SCHEMA.COLUMNS
WHERE Column_Name LIKE '%[^a-z' + @AcceptableSymbols + ']%'
UNION ALL
SELECT
'TableName',
Table_Name
FROM INFORMATION_SCHEMA.TABLES
WHERE Table_Name LIKE '%[^a-z' + @AcceptableSymbols + ']%';
returns "Must declare the scalar variable @AcceptableSymbols".
… while this is valid code in SSMS...
Workaround: remove the ending ';' from the first 2 lines… and that works...

It is not a bug.
In order to execute TSQL scripts you need to run them as a single query.
You can select entire script and run it with ctrl+enter.
Otherwise dbeaver splits script on separate queries (using delimiter ;) and executes them one by one.

I got same problem in version 7.1.2.
It will work by delete space line.
DELETE!!!

WORKED!!!

I believe the default behavior should be the same as in ssms.
There are lots of code examples online, which don't work simply because you run them with DBeaver.
In the meanwhile here's another workaround.