Only run Travis for the master branch & run sanity checks with DMD too

A bit more of Travis magic applied:

restrict only to the master branch (currently it runs twice with all PRs made with branches on dlang-tour, e.g. hard to avoid when coming from the web UI)
Run sanity checks with for DMD too (just in case there are some recent compiler bugs)
Since quite some time we use ldc instead of gdc to create the static binary -> fixed the comment

:+1:

This leads to about 30 seconds increase in the run time of the DMD build, but as it's still faster than LDC, I think we don't need to care ;-)

Apart from small nit, LGTM. Feel free to merge when ready.

I tried the new squash feature of GitHub and looks like work good - it added to the commit message a link to this PR.

LGTM. Feel free to merge when ready.

Thanks & good catch!

I tried the new squash feature of GitHub and looks like it works good

If we like it, we should be able to make it the default (by disallowing normal merge commits). This way I can at least not accidentally press on "merge" on my phonem :D
Btw a minor thing that i noticed - it copies all commit messages in the description (like the usual git squash). I think in general this is nice, just be careful when someone uses weird commit messages.
A good, negative  example from Phobos:
https://github.com/dlang/phobos/pull/4662

it added to the commit message a link to this PR.

I think it does this by default for merge commits too:
https://github.com/stonemaster/dlang-tour/commit/214a83352c971ed19452bd9e56f35aa30ff874b4

A good, negative example from Phobos

Yeah, I remember that one. I guess that guy could have squashed his commits into an "appeasing the git Nazis" message :D

Btw a minor thing that i noticed - it copies all commit messages in the description (like the usual git squash). I think in general this is nice, just be careful when someone uses weird commit messages.

The good thing is that it opens a textbox where you can manually edit the commit message. I just decided to leave it as it is for this PR.

I think it does this by default for merge commits too

I already new that it does that for merge messages, I was just worried that we might loose the PR context if squashing was used. C.f. Vladimir's post on the forum.

If we like it, we should be able to make it the default (by disallowing normal merge commits).

I don't think this would be a good idea, because it would make larger PRs harder to review, which usually are not if the they're built from a number of small commits.


audio/transcriptions may specify language

I see that both edgen_rt_whisper_cpp::TranscriptionArgs and whisper_cpp::WhisperParams offer a language field, which I hope means that specifying the desired language should work when using /v1/audio/transcriptions.

The endpoint arguments aren't properly passed to whisper_cpp at the moment, but something that will definitely get addressed.


Indentation fixer -  Wrong indentation

The issue was reported in StyleCI/StyleCI#534.
Since StyleCI uses PHP-CS-Fixer it's better to reference the issue here.
The problem is when the class' code has an indent of 4 spaces and one method has 5 spaces. The indentation fixer just fails to fix these lines with 5 spaces.

Noticed this too +1

Thank you for report. Could you send a PR with fix for that please?

Your report @ffsantos92 is no longer accessible. Could you quote full report?

I closed it on that repo anyway, and expected a full report to have been put here. Seems it hasn't...

Hi @ffsantos92, I know this issue is pretty old but is it possible for you to somehow check whether #2849 fixes it?


Set $GOPATH in the dev VM environment

This is part of the work underway to upgrade metadata-api to the latest go version.
Currently the dev VM has no $GOPATH which requires the apps try and build one within their own directory. This seems increasingly fragile with the most recent >1.6 versions of go.
This commit sets the $GOPATH to /var/govuk/gopath which will require our go apps to be located at
/var/govuk/gopath/src/github.com/alphagov/<reponame> at which point all will be well in the world.
I've opened another PR to update the Procfile (currently just for metadata-api)
Trello

Could we have this in ~vagrant/src/github.com/alphagov/metadata-api, which is a symlink to /var/govuk/metadata-api? Having a src directory in everyone's projects root feels a bit invasive.

There was a typo in the description. It's actually gopath which will be in the projects directory. I tried a few symlinking approaches (admittedly not quite the exact one you're suggesting) and they didn't work so well as just having the repo in a proper directory structure. I thought an explicit gopath directory seemed to be a reasonable approach. There is quite a lot of 'stuff' around complaining about and warning against using symlinks in the $GOPATH.
That said, it may have been other things that I've got rid of (like gom) that were causing the problems so I'll give it a try and see.

I've tried it and you get weird behaviour. If you cd in through the $GOPATH and run make it works but if you cd into /var/govuk/metadata-api it doesn't work. On top of that, even if it did work it would require people to know to find the $GOPATH and symlink the app into it. I think a convention that go apps live inside gopath is easier to communicate and use (and it works)

Ok, having gopath in the projects directory sounds fine to me.


Vaadin 8 Incompatible.

Hi,
While the code itself is compatible with Vaadin 8 there are some issues with the compiled code in release 1.1.0 when used with Vaadin 8.
If you extend ResizableCssLayoutState then you get a StackOverFlowError whenever you call getState(boolean) ... which is called indirectly in the constructor of ResizableCSSLayout.
Recompiling the addon against Vaadin 8 resolves this issue and allows you to extend ResizableCssLayout
This may be related to bridge methods created in the compiled class file for ResizableCssLayout. In Vaadin 7 CssLayout did not define a getState(boolean) method, so when ResizableCssLayout is compiled against the Vaadin 7 code base the compiled class file adds bridge methods because ResizableCssLayout overrides the return type of getState(boolean) casting the returned state to a  ResizableCssLayoutState.

Created a pull request, which solves the StackOverFlowError issue.

Fixed via #15


react version changed to 16.11.0

React version changed as per the issue -
https://github.com/remoteinterview/zero/issues/81

Thanks


Add cardinality calculation for Dataset.unbatch() when possible

This PR tries to address the issue raised in #39136 where cardinality
of Dataset.unbatch() was always UNKNOWN, even if it might be known
in certain situations.
This PR add the cardinality calculation in case the input cardinality
is known and the leading dim of the output shape is known.
This PR fixes #39136.
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

Thanks @aaudiber for the review, the PR has been updated. Please take a look and let me know if there are any other issues.


Remove version: RoyQu.RedPanda-C++ version 2.26

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://sourceforge.net/projects/redpanda-cpp/files/2.26/RedPanda.C++.2.26.win32.MinGW-w64 i686 GCC 8.1.Setup.exe/download
Status Code: 200
(Automated message - build 896)

Close with reason: Package still available.;


Merge support for allowed classes config into latest version

see https://github.com/matomo-org/cache/pull/1

Hi @tsteur
I see no MATOMO_CACHE_ALLOWED_CLASSES_UNSERIALIZE in the GitHub repos.
Did I miss something or is this not needed anymore ?


Broken link documentation AnimationType

Fixed by 2ac44b1d9d6b7075969ec0f1ad2aaf9e3eac759b can you check @RiyanFransen , feel free to re-open this issue if you think there is not fixed, thanks


Add support for click-twice-to-play (#159)

Right now it's always enabled, but we should be smarter about enabling it for small screens only, or making it a user preference.

I agree with making it a setting and only default for small screens.

@sartak could you rebase your PR to the current master so I can review it?
We should have a preferences storage system before merging this.


Fix minor errors in REPRODUCIBLE.md

Add link from README.md

Many thanks for this - much appreciated.
Will merge to master asap.

Rebased and merged to master.
Many thanks.


Component have ref, storybook will have error

my component render function has return many input with ref, when I run npm run storybook,  the error will throw
Uncaught Invariant Violation: removeComponentAsRefFrom(...): Only a ReactOwner can have refs. You might be removing a ref to a component that was not created inside a component's `render` method, or you have multiple copies of React loaded (details: https://fb.me/react-refs-must-have-owner).

what should I do?

This is usually means two versions of React running here. Could you send us a sample repo?

my project React version just one with 15.3.1, and if I remove the ref from input, the error will gone，but I can not do this, because I can't  guarantee other component render function have ref.  I try to npm uninstall react react-dom, npm install react react-dom,the problem have not solve.

and I run npm ls | grep react the result is

I run the find ./ -name react -type -d in my node_modules folder, just output one react

The probelm is gone, the reason is I used webpack bundle file in the stories, and the webpack bundle file has used react. anyway, thx so much.


Fix compatibility with protolude-0.2

This is nice, thanks. Good to know the changes won't be so bad for protolude 0.2.
Perhaps we should wait to apply this until the Stackage LTS version uses the new version of protolude?

Not sure if they will update it soon due to the ongoing 8.2.1 move. But it's surely fine to wait :)
(Note: I already applied the patch for Arch package as we have the new protolude already)

Ah I didn't realize the arch situation. Would merging this PR help make your continuing arch support easier?

It will if you are going to release a new version soon - so I can drop the patch here :)

We are preparing to release v4.3, so I'll merge this change.
Also, not sure it affects your packaging but we're dropping the initial zero from the version, so it will be 4.3.0 rather than <IP_ADDRESS>. The quadruple version numbers is a weird Haskellism and we'd rather use regular semver.

That will be fine, and I like the change :P


fix(jellyfish-api-core, jellyfish-transaction-builder): Fix failed tests for fortcanningcrunch

What this PR does / why we need it:
Which issue(s) does this PR fixes?:

Fixes #https://github.com/DeFiCh/ain/pull/1243
Additional comments?:

I will update activateAfterBlock on WhaleApi controller such that it returns activateAfterBlock: 0 to prevent downstream regression.


Update Create/Edit sidebar

Problem
Currently our edit/update is not updated using new API and new format.
Solution

Please update edit/create using require js and backbone
Please use new API with new format data
Add "comment" change because osm recommend this

@meomancer thanks for making a start with the health facility form 'tips'
'..please define notes hospitalisation and outpatient consultation'
https://staging.healthsites.io/map#!/locality/way/319377840
Where are you getting this copy from?
Could you share a document we can use to define the correct copy?

For is already using new approach
the docuemnt in here @markherringer
https://docs.google.com/spreadsheets/d/1P11VJPocQ5EkmoFaTMItg3z6Rdon2A1M2kIqqjIc-Cw/edit#gid=1195977473


Owncloud integration - Error while downloading the document file to be converted.) (version <IP_ADDRESS>)

Hello,
I am trying to integrate onlyoffice on my owncloud instance, however I have an error that persists despite the services running correctly.
Is there a manipulation I missed?
OS : Debian 10
Owncloud version : 10.7
Onlyoffice version : <IP_ADDRESS>
Configuration file local.json
{
  "services": {
    "CoAuthoring": {
      "sql": {
        "type": "postgres",
        "dbHost": "localhost",
        "dbPort": "5432",
        "dbName": "onlyoffice",
        "dbUser": "onlyoffice",
        "dbPass": "StronPassword"
      },
      "token": {
        "enable": {
          "request": {
            "inbox": false,
            "outbox": false
          },
          "browser": false
        },
        "inbox": {
          "header": "Authorization"
        },
        "outbox": {
          "header": "Authorization"
        }
      },
      "secret": {
        "inbox": {
          "string": "StronPassword"
        },
        "outbox": {
          "string": "StronPassword"
        },
        "session": {
          "string": "StronPassword"
        }
      }
    }
  },
  "rabbitmq": {
    "url": "amqp://guest:guest@localhost"
  }
}

apache2 configuration files :
<VirtualHost *:443>
    ServerName xxx.com
    ServerAlias www.xxx.com

    ServerAdmin<EMAIL_ADDRESS>
    DirectoryIndex index.php

    LogLevel warn

    DocumentRoot /var/www/onlyoffice/documentserver/

    SSLEngine on
    SSLCertificateFile /etc/letsencrypt/live/xxx/fullchain-privkey.pem
    SSLCertificateKeyFile /etc/letsencrypt/live/xxx/fullchain-privkey.pem
    SSLCACertificateFile /etc/letsencrypt/live/xxx/fullchain-privkey.pem

    SSLCipherSuite ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:DHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-GCM-SHA384
    SSLProtocol all -SSLv3 -TLSv1 -TLSv1.1
    SSLHonorCipherOrder Off

    <Directory "/var/www/onlyoffice/documentserver/">
        Options -Indexes +FollowSymLinks -MultiViews
        Require all granted
        AllowOverride All
    </Directory>

    RewriteEngine on
    RewriteCond %{REQUEST_URI} !^/\.well-known/acme-challenge/
    <FilesMatch "\.php$">
       SetHandler "proxy:unix:/var/run/php/php7.4-fpm.sock|fcgi://localhost/"
    </FilesMatch>
    <Proxy "fcgi://localhost/">
    </Proxy>

    LogFormat "%v %h %l %u %t \"%r\" %>s %b \"%{Referer}i\" \"%{User-Agent}i\"" MatomoFormat
    ErrorLog ${APACHE_LOG_DIR}/xxx_error.log
    CustomLog ${APACHE_LOG_DIR}/xxx_access.log MatomoFormat
    Protocols h2 http/1.1
    SSLSessionTickets off
    Header always set Strict-Transport-Security "max-age=63072000"
    ProxyPreserveHost On
    #SSLProxyEngine on
    ProxyPass         / http://<IP_ADDRESS>:8800/ retry=1 acquire=5000 timeout=5000
    ProxyPassReverse  / http://<IP_ADDRESS>:8800/
    RequestHeader set X-Forwarded-Port "443"
    RequestHeader set X-Forwarded-Proto "https"
    Timeout 3000
    ProxyTimeout 3000
</VirtualHost>

nginx configuration file :
include /etc/nginx/includes/http-common.conf;
server {
  listen <IP_ADDRESS>:8800;
  listen [::]:8800 default_server;
  server_tokens off;
  server_name _;
  ## Redirects all traffic to the HTTPS host
  root /nowhere; ## root doesn't have to be a valid path since we are redirecting
  #rewrite ^ https://$host$request_uri? permanent;
  include /etc/nginx/includes/ds-*.conf;
}
#HTTP host for internal services
server {
  listen <IP_ADDRESS>:8800;
  listen [::1]:8800;
  server_name localhost;
  server_tokens off;

  include /etc/nginx/includes/ds-common.conf;
  include /etc/nginx/includes/ds-docservice.conf;
}

rabbitmq service : ok
apache2 service : ok
nginx service : ok
supervisor service : ok
curl healthcheck : ok
curl  https://xxx.com/healthcheck
true

Hi @gitqud, it looks enough, but the Nginx config is strange. To my mind, it's based on SSL config, just use HTTP config for document server.
Also, can you check  curl  https://xxx.com/baseurl to verify proxy settings?

new config for nginx :
include /etc/nginx/includes/http-common.conf;

## Normal HTTP host
server {
  listen <IP_ADDRESS>:8443;
  listen [::]:8443 default_server;
  server_name _;
  server_tokens off;

  ## Redirects all traffic to the HTTPS host
  root /nowhere; ## root doesn't have to be a valid path since we are redirecting
  rewrite ^ https://$host$request_uri? permanent;
}

#HTTP host for internal services
server {
  listen <IP_ADDRESS>:8443;
  listen [::1]:8443;
  server_name localhost;
  server_tokens off;
  include /etc/nginx/includes/ds-common.conf;
  include /etc/nginx/includes/ds-docservice.conf;
}

## HTTPS host
server {
  listen <IP_ADDRESS>:9443 ssl;
  listen [::]:9443 ssl default_server;
  server_tokens off;
  root /usr/share/nginx/html;

  ssl on;
  ssl_certificate /etc/letsencrypt/live/xxx/fullchain-privkey.pem;
  ssl_certificate_key /etc/letsencrypt/live/xxx/fullchain-privkey.pem;
  ssl_verify_client off;

  ssl_ciphers "EECDH+AESGCM:EDH+AESGCM:AES256+EECDH:AES256+EDH";

  ssl_protocols  TLSv1 TLSv1.1 TLSv1.2;
  ssl_session_cache  builtin:1000  shared:SSL:10m;

  ssl_prefer_server_ciphers   on;

  add_header Strict-Transport-Security max-age=31536000;
  # add_header X-Frame-Options SAMEORIGIN;
  add_header X-Content-Type-Options nosniff;

  include /etc/nginx/includes/ds-*.conf;

}

with the change on the apache side of course on the proxy side
Still not working into owncloud

It's wrong to turn on and use documentserver with SSL(HTTPS) behind a proxy. The proxy can't validate the certificate of documentserver cause it working with a local address.

here is the proxy part of vhost into apache
    ErrorLog ${APACHE_LOG_DIR}/x_error.log
    CustomLog ${APACHE_LOG_DIR}/x_access.log MatomoFormat
    Protocols h2 http/1.1
    SSLSessionTickets off
    Header always set Strict-Transport-Security "max-age=63072000"
    ProxyPreserveHost On
    SSLProxyEngine on
    SSLProxyCheckPeerCN Off
    SSLProxyCheckPeerName Off
    ProxyPass         / https://<IP_ADDRESS>:9443/ retry=1 acquire=5000 timeout=5000
    ProxyPassReverse  / https://<IP_ADDRESS>:9443/
    RequestHeader set X-Forwarded-Proto "https"
    Timeout 3000
    ProxyTimeout 3000

I tell the proxy that it should not check the certificate.
Whether I use HTTP or HTTPS the problem is still there


Add exec mode for compiletest

Description of changes:
This PR adds a new exec mode for compiletest. This mode is useful to execute script-based tests, and allows checking expected output and exit codes at the same time.
Unlike cargo-kani tests, this mode expects a folder with a config.yml file within (not adding one will cause an error). The config.yml file should contain:

script: The path to the script to be executed.
expected (optional): The path to the .expected file to use for output comparison.
code (optional): The exit code to be returned by executing the script (a zero exit code is expected if not specified).

A new test error-code has been added with the purpose of testing the exec mode itself. This PR also migrates the check-output test that used to run at the beginning of our regression. Other scripts can be migrated in subsequent PRs, but I'm not doing it here since it might require some work.
Resolved issues:
Resolves #2059
Call-outs:

compiletest actually runs time script, since running script alone didn't seem to be successful. However, many of our existing script-based tests run with time, so I figured that's the best to do there (previously was just running sh script).

Testing:

How is this change tested? CI + new tests.

Is this a refactor change? No.

Checklist

[x] Each commit message has a non-empty body, explaining why the change was made
[x] Methods or procedures are documented
[x] Regression or unit tests are included, or existing tests cover the modified code
[x] My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Thanks @zhassan-aws for the review! I'm still working on documentation for this, but feel free to provide more comments in the meantime.

Added some documentation in the "regression testing" section and rebased the PR against main.


Thanks for the outstanding work you do, when will the code be released!

I'm looking forward to it

Thanks for your interest in our work! We are currently working on cleaning up the code and will release it as soon as possible.


ARC-438 app restructure

First of all, apologies about the size. Lots of things moved around equals lots of pathname changes. Reviewing the restructure will probably be easiest if you pull this branch locally.
Restructured the existing tree in preparation for the rewrite of our frontend. To align with Atlassian guidelines, and adhere to architecture 'guidelines' of Tangerine, I've made the following changes:

create backend and client directories in /src for a clearer separation
renamed utils > common: I currently have one common dir in src but, as I begin making additions to the frontend, it may make more sense to have separate common dirs for the backend and client
renamed static > public
deleted the frontend dir
moved all the middleware files into backend/middleware
moved all testing setup, util, and shared files into common/test-utils
grouped tests and the files they are testing into folders (structure specified in guidelines)

I haven't deleted the views folder yet and the goal here is to keep the app in a working state and get everything in its new place. That will be done in one of my upcoming PRs.

Do you think we should hold this PR until the migration is done to reduce the amount of risk involved?

Do you think we should hold this PR until the migration is done to reduce the amount of risk involved?

I'm merging all of this work into ARC-107-react-rewrite to prevent that and to break the work involved into smaller PRs. The idea is that all my feature branches get approved, get merged back into ARC-107-react-rewrite while I keep that branch up-to-date with micros (which will probably become master while I'm doing this). When all the work is done and all PRs against ARC-107-react-rewrite are approved, then we can look at merging that branch in.


Some New Proxy Sources

Hi @chill117 ,
I found this proxy lists recently:

~http://proxyfor.eu/geo.php~ -- old proxies
[x] http://free-proxy-list.net -- already done
~http://rebro.weebly.com/proxy-list.html~ -- old proxies
[x] https://premproxy.com/list/
~https://www.proxicity.io/~ -- only gives one proxy at a time

Maybe useful 😉

Thanks for these! I don't have much time to implement all of them, but I will try at least some. If anyone else wants to add any of these, pull requests are always welcome :)

#61

All proxy lists here are either already implemented or don't give new, working proxies.


Crash on AFURLResponseSerialization.m line 243

I've received a few reports of this crash but I don't know the exact steps to reproduce it. Seen on iOS 8.3 and 8.4 using AFNetworking 2.5.4.
Thread : Crashed: com.alamofire.networking.session.manager.processing
0  libsystem_kernel.dylib         0x0000000198393270 __pthread_kill + 8
1  libsystem_pthread.dylib        0x0000000198431170 pthread_kill + 112
2  libsystem_c.dylib              0x000000019830ab18 abort + 112
3  libsystem_malloc.dylib         0x00000001983ce3e4 _nano_malloc_check_clear + 318
4  libsystem_malloc.dylib         0x00000001983cd2f8 nano_free + 192
5  CoreFoundation                 0x0000000185ecd5e8 __CFStringDeallocate + 192
6  CoreFoundation                 0x0000000185dd9394 CFRelease + 328
7  <Removed>                      0x00000001000b498c -[AFJSONResponseSerializer responseObjectForResponse:data:error:] (AFURLResponseSerialization.m:243)
8  <Removed>                     0x00000001000b6cdc -[AFCompoundResponseSerializer responseObjectForResponse:data:error:] (AFURLResponseSerialization.m:756)
9  <Removed>                      0x00000001000b7ad0 __72-[AFURLSessionManagerTaskDelegate URLSession:task:didCompleteWithError:]_block_invoke69 (AFURLSessionManager.m:178)
10 libdispatch.dylib              0x000000019824d994 _dispatch_call_block_and_release + 24
11 libdispatch.dylib              0x000000019824d954 _dispatch_client_callout + 16
12 libdispatch.dylib              0x0000000198256b70 _dispatch_async_redirect_invoke + 1604
13 libdispatch.dylib              0x000000019824d954 _dispatch_client_callout + 16
14 libdispatch.dylib              0x000000019825a780 _dispatch_root_queue_drain + 1848
15 libdispatch.dylib              0x000000019825bc4c _dispatch_worker_thread3 + 108
16 libsystem_pthread.dylib        0x000000019842d22c _pthread_wqthread + 816
17 libsystem_pthread.dylib        0x000000019842cef0 start_wqthread + 4

The line that is failing is
CFStringEncoding encoding = CFStringConvertIANACharSetNameToEncoding((CFStringRef)response.textEncodingName); in this section:
    // Workaround for behavior of Rails to return a single space for `head :ok` (a workaround for a bug in Safari), which is not interpreted as valid input by NSJSONSerialization.
    // See https://github.com/rails/rails/issues/1742
    NSStringEncoding stringEncoding = self.stringEncoding;
    if (response.textEncodingName) {
        CFStringEncoding encoding = CFStringConvertIANACharSetNameToEncoding((CFStringRef)response.textEncodingName);
        if (encoding != kCFStringEncodingInvalidId) {
            stringEncoding = CFStringConvertEncodingToNSStringEncoding(encoding);
        }
    }

It looks like it's related to #2775 (text encoding is in there too) but the stack trace is slightly different.

Thanks for the report @robmaceachern.
I'm going to close this issue as there is already another issue tracking this bug #2958.


Embedded builds?

Are there any plans to create builds specifically targeted at running on embedded systems? Something like Espruino or micropython come to mind.

Are you having any particular problems building it for your embedded system of choice?

I haven't just yet but I do have an M0 and two M4 boards I'd like to play around with running something other than Lua. Since this is an interpreter, some sort of bootloader/rtos is needed to run this, correct? Access to hardware via HALs, managing processes, etc. My main question is if this is something you're planning on exploring or if others have expressed interest.
Thanks!


Add adjustments for no-global-function-names

This PR adds following adjustments:

Interpolation handling

postcss-value-parser doesn’t have interpolation handling so this is achieved with very crude implementation by stripping #{ from start of node.value. I’ve opened PR for this but it doesn’t seem there is any interest to implement this. postcss-values-parser handles this so maybe consider switching to this at later date?

Some color functions have mapping to completely new syntax so I’ve made rule mappings for that. There is a list with recommendations: https://sass-lang.com/documentation/modules/color

Thanks! and sorry for the delay on my behalf.

@kristerkari no problem! Maybe it would be best to wait for postcss-value-parser PR changes, it seems there is movement in accepting the changes on their side.

@niksy should we just merge this if the postcss-value-parser changes are not getting merged?

@kristerkari I would like to wait some time because I pinged maintainers yesterday and would like to see what the say.

@kristerkari it seems there’s no movement in PR, so I think we can merge this and apply additional changes when PR gets merged?

sounds good @niksy

@kristerkari can I help on getting this merged?

oh yeah @niksy, good that you reminded me.
Last time I quickly browsed through the changes, but I was wondering about there being only 2 added tests, but quite many changes in the rule.
Would it be possible for you to add a bit more test cases to cover the changes that you have added?

@kristerkari The only new thing is rule mapping for old and new function calls. I could probably check direct string instead of output of messages.rejected?
{
  "code": `
      a {
        background: lighten(#e1d7d2, 30%);
      }
    `,
  "line": 3,
  "column": 21,
  "message": "Expected color.adjust($color, $lightness: $amount) instead of lighten($color, $amount) (scss/no-global-function-names)",
  "description": "lighten"
}

@niksy yeah that sounds good.

@kristerkari done!

@kristerkari thanks for merging! When can we expect to have this released?

I could do a new version today.

@niksy released in https://github.com/kristerkari/stylelint-scss/releases/tag/3.21.0


Configuration not persisted when using --config

Hi all,
I'm using the UniFi Protect Integration for Home Assistant and the Proxy Container -- all seems to go well when manually adding cameras via config.json but cameras that are added via the Home Assistant integration seem to fail due to the URL format.
The cameras are added with rtsps URLs like rtsps://IP:7441/token?enableSrtp and the URL needs to be changed to rtsp://IP:7447/token to make things work -- the port changes to 7447 and the protocal to rtsp. I already set channel_defaults to "insecure_skip_verify": true to ensure this is not causing any issues, too.
It would be awesome if new cameras would be either added to config.json (so people can manually edit them) or if there would be support for RTSP (or port and protocol remapping).
Thanks in advance and keep up the great work,
Tim

Hi @SeraphimSerapis -- it seems like we should be able to make the RTSPS cameras work? Can you add more detail to https://github.com/deepch/RTSPtoWeb/issues/82 about why its not working?
Also, on persistence, my impression is that RTSPtoWeb does persist its configuration files normally, but its not working when run in the add-on for some reason. I don't think that is an RTSPtoWeb bug itself, as if you run standalone it seems to persist just fine.

We can track the persistence issue in https://github.com/allenporter/stream-addons/issues/29 though i'm not really sure why its not working.  I don't have a use case for this myself, so i am not actively looking into it, and it could use some debugging help debugging why its not working.

I'm not using the addon -- simply running the Docker container like so:
  ### RTSP to Web ###
  rtsp:
    container_name: rtsp
    restart: unless-stopped
    network_mode: host
    image: ghcr.io/deepch/rtsptoweb:latest
    volumes:
      - ${DOCKERDIR}/appdata/rtsp/config.json:/config/config.json

Added my errors to #82 for more information. Hope the information I provided are useful. Thanks for the swift response @allenporter

OK, lets use this to track the persistence issue. I made the dockerfile for this as well as the add-on so maybe its the same issue in both. When running from go, it is able to overwrite the config file correctly.

It looks like the --configFile flag is only used to read the config and ignored when writing the config. I'm working on a fix.

Oh one other thing, for the home assistant side I am pretty sure it is going to overwrite the stream url every time it plays. It does this for cloud cameras where the RTSP url changes each time.

Okay, so manually editing the config wouldn't work. It may be a useful addition to be able to tweak camera configurations coming from Home Assistant somehow

OK, we can follow up in the other bug about the unifi protect getting the newer streams working

@SeraphimSerapis have you tried removing ?enableSrtp from the unifi provided RTSPS url?
For me:
rtsps://IP:7441/token(works)
rtsps://IP:7441/token?enableSrtp (does not work)

@azbutz You are right -- that seems to be fine. Not sure why it didn't work for me in the first attempt.


Tell the user that they can right-click on the map

Two options:

Sidebar
Above the upcoming Access Index list, it should say, "Right-click anywhere on the map to get your Access Index/Score"

Info overlay (bubble that hovers on the map)
Overlaid on the map would be a transparent bubble that says the same thing as Sidebar.

We've done item 1. Item 2 isn't that important.


AStar  get_available_point_id () initially returns 1 instead of 0

Godot version:
Godot_v3.3.1-stable_win64
OS/device including version:
Win7 x64
Issue description:
AStar. get_available_point_id () initially returns 1 instead of 0.
Also, in some cases, for unknown reasons, it returns 1 twice in a row.
The first mistake in this line ...
https://github.com/godotengine/godot/blob/8f7f5846397297fff6e8a08f89bc60ce658699cc/core/math/a_star.cpp#L39
Someone correct this one figure, it has been waiting for more than a year.

https://github.com/godotengine/godot/issues/38263

I'd like to work on this.

@deveshXm There's a fix already, see the PR linked above your comment.

@deveshXm There's a fix already, see the PR linked above your comment.

I am beginner. So can i make a pull request on this or has this been already merged and closed because it shows me open.

See this:

If you click the link, you'll see a Pull Request which aims at fixing this issue. It is still Open, so it hasn't been merged yet. But unless there are reasons to think that it wouldn't be merged (e.g. if the fix is wrong), then there's no reason for you to make another PR fixing the issue. We only need one fix (and the best one :)).
You can help by reviewing that PR and confirming that it's how you would have fixed the issue too.

See this:

If you click the link, you'll see a Pull Request which aims at fixing this issue. It is still Open, so it hasn't been merged yet. But unless there are reasons to think that it wouldn't be merged (e.g. if the fix is wrong), then there's no reason for you to make another PR fixing the issue. We only need one fix (and the best one :)).
You can help by reviewing that PR and confirming that it's how you would have fixed the issue too.
This issue will be closed as fixed once the PR is reviewed and merged.

okay. Thank you for the help.

if this is a ready-made fix why was it not included in version 3.4?

if this is a ready-made fix why was it not included in version 3.4?

See the description of https://github.com/godotengine/godot/pull/48958:

Technically it breaks compat so not sure if it should be cherry-picked.


Sentry's User class conflicts with application's User class

Can't use SentryClient.shared?.user because I have a class named User in my app.

@wouterw How are you using/installing this client? It should be namespaced out with the module name (if using as a dynamic framework) if you have a conflicting class name - SentrySwift.User. I have not come across this myself yet but I will take a look into this today for ya ✊

@joshdholtz Sorry for the noise, referencing SentrySwift.User explicitly works. Thanks for the quick reply! 👍

@wouterw No problem, man 😊 Glad that worked! Have fun Sentry-ing and let me know if you run into any other issues or have any suggestions 👍

I have the same issue using Sentry-Swift installed through Carthage.
The problem occurs even without using your class SentrySwift.User, but simply because it is defined in your framework, so prefixing it is not a solution for me. Here is the compilation error I get:
Error:(2788, 1) duplicate interface definition for class 'User'

@carole-lavillonniere How are you installing the library? Are you using either CocoaPods or Carthage?

I am using Carthage as mentioned.
github "getsentry/sentry-swift" == 0.3.3

@carole-lavillonniere Sorry, my bad! Just woke up like 5 minutes ago 😇  I will take a look at once I made my cup of coffee ☕

@carole-lavillonniere Does your User class happen to be an Objective-C class by any chance? 😊

It is a Swift class but it does inherit from NSObject.

Hmmm... Fairly certain that error is an Objective-C error so that does make more sense. I was able to duplicate the error in an a Objective-C project but have not in a Swift project yet. Will work on a fix though 👍

I can't seem to duplicate it with a Swift class that inherits from NSObject 😔  I can rename the User object to something less commonly used but I would like to actually know what the cause is first so its not just a yolo fix on my end 😇   I will keep trying to break things on my end

Seems like a more solid fix is required indeed, because I would assume the same could happen with common class names like Event, Frame or Exception etc (something worth testing maybe?).

@carole-lavillonniere Everything should be namespaced out by the framework name which is why this issue was closed originally. Are you by any chance including the sentry framework twice? I'm trying to think of any project configurations could be different than what I have setup 🤔

The Sentry framework is only imported once and the compiler when failing points to the two different definitions: the one from Sentry and the one from my project.
Here is how I define my User class:
class User: NSObject {
   ...
}

Very odd! I did that exact thing and no compile errors 😔  What version of Xcode/Swift?
Sorry for so many questions! Really want to get down to what is causing this 😇

Strange...
Xcode 7.3.1 and Swift 2.2

In your test app, is the {YourAppName}-Swift.h file generated?

In case it helps, I have just reproduced the error with the Frame class. No error if it does not inherit from NSObject, but the compilation fails with a duplicate interface definition when it does.

@carole-lavillonniere I added a bridging header and still no failure 😖
Here is what my view controller looks like which, based on the information you have provided, should fail (but its not)...
import UIKit
import SentrySwift

class User: NSObject {

}

class ViewController: UIViewController {

	override func viewDidLoad() {
		super.viewDidLoad()

		let user = User()
		print("user - \(user)")

		let client = SentryClient(dsnString: "")
		client?.startCrashHandler()

	}

}

Do you have a test/sample project that can reproduce this error by any chance?

Just to be sure we're talking about the same thing, I'm talking about the
header to expose swift to objective-c, and not the other way around.
I might be able to create a sample project, but not before Monday.
On Thursday, 1 September 2016, Josh Holtz<EMAIL_ADDRESS>wrote:

@carole-lavillonniere https://github.com/carole-lavillonniere I added a
bridging header and still no failure 😖
Here is what my view controller looks like which, based on the information
you have provided, should fail (but its not)...
import UIKitimport SentrySwift
class User: NSObject {
}
class ViewController: UIViewController {
override func viewDidLoad() {
    super.viewDidLoad()

    let user = User()
    print("user - \(user)")

    let client = SentryClient(dsnString: "")
    client?.startCrashHandler()

}

}
Do you have a test/sample project that can reproduce this error by any
chance?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/getsentry/sentry-swift/issues/31#issuecomment-244129607,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABm0k0VarldQTgkfJu9f027EwH1Q4L56ks5qlvjhgaJpZM4IrchD
.

@carole-lavillonniere Ohhhhh, thanks for that clarification! I will give that a shot... I forget that thats a thing sometimes 😉

I did not really need this header anymore, so I disabled its generation by deleting SWIFT_OBJC_INTERFACE_HEADER_NAME in the Xcode settings and it is now compiling.

@carole-lavillonniere That is good to hear! I will still look into this but glad to hear that things are working for you now 😊

:) Thanks for the support!

I have an Obj-C class called User in my project and it conflicts with Sentrys User.
How do I use my projects User? Since there's no namespace.

@n1mda
Hey we will add a namespace for objc in next minor bump because it breaks the current api.
For now you can only rename your User class or add SentrySwift as a project an namespace it by yourself like this.
http://softwaredesign.jeffverkoeyen.com/swift-frameworks-conflicting-symbols-objective-c-apps/

@n1mda We just released 1.4.0 which namespaced all public classes in objc.
If you update your problem should be fixed.

@HazAT Thank you, works great!

Hey! I definitely have tried everything and cannot get this to work. I'm on SentrySwift 1.4.2 and Swift 3.
I have a User class in my project and I've tried SentrySwift.User ("Expression type User is ambiguous without more context") as well as SentryUser (not found at all). Any help?
Do I need to convert my whole class with the @objc prefix? That seems crazy.

Quick update! I was able to get it to work with a typealias, thanks to a suggestion via email from @HazAT (thank you!).
My code now looks like:
import SentrySwift

typealias SentryUser = SentrySwift.User

SentryClient.shared?.user = SentryUser(id: id, email: email, username: slug, extra: [:])

Hope this is helpful for others.

@leah 's solution didn't help me. I still can't make it work.
I have a swift class that imports Sentry, and that same class uses an User Objective-C class that I import in Bridging Header file. When I try to use the Objective-C User class I get the error:
'User' is ambiguous for type lookup in this context
The typelias didn't work.
Any suggestions?


Swanky node cannot run with with -lerror command

Description
I am trying to run swanky node according to tutorial:
./target/release/swanky-node --dev --tmp -l runtime=trace -lerror,runtime::contracts=debug

with this however the node cannot run.
Workaround:
I think that , is an issue
./target/release/swanky-node --dev --tmp -l runtime=trace -lerror-runtime::contracts=debug

Environment

Describe the environment in which you encountered this bug. Use the list below as a starting point and add additional information if you think it's relevant.

Operating system: MacOS 12.5.1
Project version/tag:
Rust version (run rustup show):

installed targets for active toolchain
--------------------------------------

aarch64-apple-darwin
wasm32-unknown-unknown

active toolchain
----------------

nightly-2022-07-24-aarch64-apple-darwin
rustc 1.64.0-nightly (93ffde6f0 2022-07-23)

Logs, Errors or Screenshots

Additional Information

Please add any other details that you think may help us solve your problem.

It is just setting log level and filters which logs to output.
In above example,
log level error is set to entirely and log level debug is set to only runtime pallet contracts.
So if you use ink_env::debug_println! in your contract, node will emits debug logs.
https://use.ink/faq/#how-do-i-print-something-to-the-console-from-the-runtime


UE5 plugin unavaliable

after today's update plugin shows as if installed to engine, but does not appear inside plugin section. Used to work just fine before the update.

Hi yes, the plugin from the marketplace is currently not working. I have submitted a fix which should be out soon. For now please grab the plugin from here:
https://github.com/fpwong/AutoSizeComments/releases/tag/3.1.4

@fpwong is this supposed to be working now? I'm on 3.1.4 but I'm seeing this:

Same issue for AutoSizeComments and BlueprintAssist on custom UE5 engine; idk if that's our problem or plugin's.


Update doc.md and fix typos

This PR did:

fix “－－” to "--"
fix typos ECE
change selinux to SELinux
delete lots of blank lines.

WDYT? @zhe

LGTM. @zhe

LGTM


[CSL-1356] Create the BlockEvent type

Okay, I changed the module name.

But why not Block.Event?

Because Generator.BlockEvent is going to import Generator.Block, and it's weird to import a module from upward in the hierarchy.

It's not necessary to import Generator.Block from there, you could do vice versa.


Search in File does not show location of match in file but start of file

When searching for a pattern in a note, the matching locations are not shown.
Instead the preview shows the file from the top.
I would love to see the match directly in the preview. Otherwise I have to open the file in Obisidian and do the same search again to find the section I am looking for.

If you scroll down it doesnt show it?

Sure, that works. It does show the content if you scroll down.
But the idea of the content search should be to give the direct location and information in search for. Otherwise it is faster to open up Obsidian and search in there, which is not great for productivity reasons.
Do you feel different about it?


CONNECT menu to collect how to connect wallets and services

Would help with answering the questions of how I connect XX app or wallet to the node.
By default should show connection to bitcoind and LND:

[ ] Bitcoind RPC for Specter Desktop and a remote Joininbox / JoinMarket
https://d11n.net/connect-specter-desktor-with-raspiblitz.html
https://github.com/openoms/joininbox/blob/master/prepare_remote_node.md
[ ] Fully Noded (from the MOBILE menu)
[x] Bitcoind P2P - Bisq connects to v2 Tor service
https://twitter.com/openoms/status/1355885287881240578
[ ] LND rest and GRPC with the text with

[ ] TLS cert (from LNDCREDS)
[ ] macaroons (from LNDCREDS)
[ ] Tor Hidden Services
[ ] LNDconnect as now in the MOBILE menu for Zeus / Zap
[ ] show the own watchtower service address
[ ] connect third party watchtowers

Then could change dynamically depending on what is installed:

[ ] LND connection string for BTCpayserver (from LNDCREDS)
[ ] Electrum Server from the ELECTRS menu
[ ] Can consider showing the various ports to open different services
[ ] Hidden services for the various services

Just quick note: There is already a "CONNECT" menu entry for connectig to another Lightning peer. We could change that to "PEERING" ... or will that get a sub entry in the new "CONNECT" menu?

I wonder if we could declutter the Main menu significantly.
Currently with only LN related services installed I can only see 33% of the options:

I am thinking to breakdown to a couple of submenus:
INFO - for the status screen
LIGHTNING - submenu for LN wallet related actions
    FUNDING
    CONNECT - can be called PEERING
    CHANNEL
    SEND
    RECEIVE
    CLOSEALL
    CASHOUT
    lnbalance
    lnchannels
    lnfwdreport
SERVICES - all the installed app info-s including:
    TOR
ADD/REMOVE - instead of the current SERVICES menu to install apps
SETTINGS - kept as it is with the toggle options
SUBSCRIBE
CONNECT - some extra mentioned above and including:
    MOBILE
    LNDCREDS
NAME
REPAIR
UPDATE - as it is (could adjust the menu height automatically to not hide options)
REBOOT
OFF
X - can be configured to be the Cancel button instead (they do similar)

What do you think? it is not too much work to refactor the menu and I can do it.
Need to create 3 submenu files for LIGHTNING, SERVICES and CONNECT.

is if possible to view this as a grid rather than a list? could have the columns be categories (LN, security, utilities, etc)

@keblek, no the dialog system is pretty limited. A tradeoff for being extremely lightweight and compatible: https://bash.cyberciti.biz/guide/Bash_display_dialog_boxes

#2119 is ready to be merged, but of course would benefit from more testing.
There are a lot of new menu options as described in the first comment and the commits.
One more thing I'd like to add is the watchtower info and connection to the CONNECT menu.
Should be easy to do by following: https://github.com/openoms/lightning-node-management/blob/master/watchtower.md

PR merged ... putting on final testing for v1.7RC2 :)

OK ... the connect menu is really nice and tested well :) Looks ready for v1.7. Closing issue for release.


Credentials should always be read from environment variables

In this script, the email credentials should be read from environment variables and should not be mentioned explicitly in code as it is done here https://github.com/Mrinank-Bhowmick/python-beginner-projects/tree/main/projects/Send-Email

@Mrinank-Bhowmick Please assign this issue to me

@Mrinank-Bhowmick I've made appropriate changes in code for this issue. Please review and merge.
Here is the link for the PR: https://github.com/Mrinank-Bhowmick/python-beginner-projects/pull/151

Merged


Installing on a Linux box being not in sudoers breaks the install.

I'm trying to install Linuxbrew on a system where I'm not in sudoers (and I don't want/can't be), but the install script (https://raw.githubusercontent.com/Linuxbrew/install/master/install) is full of sudo invocations which collides with what is stated in the README.md (https://github.com/Linuxbrew/brew/blob/master/README.md#features)
Further inspection of commits on Linuxbrew/install shows that several checks have been recently chunked out https://github.com/Linuxbrew/install/commit/acc72841d05030e645ab806b88fd65de0843aedc?diff=unified#diff-19ad89bc3e3c9d7ef68b89523eff1987L217 , maybe this is the root cause
HTH.

I've merged PR https://github.com/Linuxbrew/install/pull/12 to resolve this issue.


【BUG】部分黑白图片导致致命错误

这个列表的所有图片都会出现错误，全部是黑白图片，但似乎不是所有黑白图片都会出现问题
All the pictures in this list will have errors, all black and white pictures, but it seems that not all black and white pictures will have problems.
 image_list = ["https://store.playstation.com/store/api/chihiro/00_09_000/container/HK/ch/999/HP9000-CUSA02417_00-GONETOTHERAPTURE/1561603730000/image?w=432&h=432", "https://store.playstation.com/store/api/chihiro/00_09_000/container/HK/ch/999/EP4034-CUSA03094_00-ASIA000000000000/1555304545000/image?w=432&h=432", "https://store.playstation.com/store/api/chihiro/00_09_000/container/HK/ch/999/UP1164-CUSA13422_00-ASIA000000000000/1554792500000/image?w=432&h=432", "https://store.playstation.com/store/api/chihiro/00_09_000/container/HK/ch/999/UP9000-CUSA00695_00-ASIAFULLGAME0000/1561601024000/image?w=432&h=432", "https://store.playstation.com/store/api/chihiro/00_09_000/container/HK/ch/999/HP9000-CUSA12613_00-DEATHSTRAND00001/1561107092000/image?w=432&h=432", "https://store.playstation.com/store/api/chihiro/00_09_000/container/HK/ch/999/HP2005-CUSA14358_00-PATOBOXASIA00000/1560504014000/image?w=432&h=432"]

Traceback (most recent call last):
File "/Users/Phishion/Desktop/Haishokutest.py", line 12, in
dominant = Haishoku.getDominant(value)
File "/usr/local/lib/python3.7/site-packages/haishoku/haishoku.py", line 119, in getDominant
colors_mean = Haishoku.getColorsMean(image_path)
File "/usr/local/lib/python3.7/site-packages/haishoku/haishoku.py", line 65, in getColorsMean
grouped_image_colors = alg.group_by_accuracy(sorted_image_colors)
File "/usr/local/lib/python3.7/site-packages/haishoku/alg.py", line 54, in group_by_accuracy
rgb_maximum_json = rgb_maximum(sorted_tuple)
File "/usr/local/lib/python3.7/site-packages/haishoku/alg.py", line 23, in rgb_maximum
r_sorted_tuple = sorted(colors_tuple, key=lambda x:x[1][0])
File "/usr/local/lib/python3.7/site-packages/haishoku/alg.py", line 23, in
r_sorted_tuple = sorted(colors_tuple, key=lambda x:x[1][0])
TypeError: 'int' object is not subscriptable

@Phishion 刚测试了一下，是因为提供的这些图片都是 灰度模式 导致，已经提交了一个新版本修复了这个问题，v1.1.8可以正常处理提供的这些图片

感谢修复，我这边测试也正常了


Fix dwc2 driver for STM32L47x

Describe the PR
Fix dwc2 driver for STM32L47x, reference to https://github.com/hathach/tinyusb/issues/1494.
Additional context
None.

A bit late, but why was this reverted? Was the fix not correct?
(for context: I am running into the same problem, and this change appears to fix it)


[video_player] Fix playback speed resetting on iOS

This fixes the playback speed resetting on iOS on startup and when seeking.
The approach is not the cleanest because there might be up to 500ms (unrealistic because seeking will take some time) that are played back with reset playback speed after seeking.
However, I tried a lot of different approaches for fixing this and this seemed to be the best. The only way I figured we could do better would be by increasing the frequency of applying the playback speed. I am unaware of the underlying issue causing the issue in the first place, which prevents me from creating a better fix.
All in all, I think this is a good fix because it is 1. performant (setting every 500ms does not possibly impact performance) and 2. reliable for every kind of action the video player might take on iOS.
I decided against increasing the frequency (e.g. every 100ms or even more often) because I do not want to impact performance.

Fixes https://github.com/flutter/flutter/issues/73643.
Fixes https://github.com/flutter/flutter/issues/71264.

Pre-launch Checklist

[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I signed the CLA.
[x] All existing and new tests are passing.

@cyanglaz any chance we can merge this now that the null safe version is finished? 🤔

@cyanglaz @iskakaushik any updates here?

@cyanglaz @iskakaushik @stuartmorgan what do we need to do here to move this forward?

Sorry for the delay; we're still working on triaging the PR backlog. From an initial look this will need tests, per policy, and it will need non-trivial review, so will need to go into the backlog.
To elaborate on the second point:

As described in the PR comment and the comment in the code this is essentially hacking around an issue we don't actually understand yet, which is not something we generally do until we've done more investigation, and
It's not clear from the PR how you came to the conclusion that "setting every 500ms does not possibly impact performance" given that it's doing a method channel invocation, which happens on the main thread.

From an initial look this will need tests

@stuartmorgan if you have any idea how to test this, would love to know.

It's not clear from the PR how you came to the conclusion that "setting every 500ms does not possibly impact performance" given that it's doing a method channel invocation, which happens on the main thread.

To be honest, I wrote some of the other code and this is the least impact but it is quite a critical bug (e.g. we cannot use the plugin without this PR).
It would just be nice to move this forward, given we have been on our own fork for 9 months for a 1 line change.

@stuartmorgan your concerns are great but also idealistic.
This is a major bug that has not been addressed for a whole year. Merging this would fix it.
Your concern is valid, however, negligible. The value is updated so often that the single call has 0 measurable effect.

I am all in favor of a better fix. What I would do: merge this and create an issue to clean this up.

And if your concern is quality of code, I am fully with you. If I owned this plugin, the first thing I would do is clean up all of the wanky handling.
The value is not stable at all, which causes this problem in the first place. You cannot trust the value one bit - there are so many ways to bring the value (Dart side) out of sync with the actual underlying video player state (native side).

@stuartmorgan your concerns are great but also idealistic.

I'm willing to listen to explanations for why a native-side fix that has none of those drawbacks would be hard to implement.

Your concern is valid, however, negligible.

You asked me what was necessary to move the PR forward; asserting that my comments don't matter isn't going to move it forward.

And if your concern is quality of code, I am fully with you. If I owned this plugin, the first thing I would do is clean up all of the wanky handling.

Adding hacks instead of addressing root causes directly works against that goal. If the first thing you would do is improve code quality, then I'm not sure why you are arguing against improving this PR as part of the review process.

The value is not stable at all, which causes this problem in the first place. You cannot trust the value one bit - there are so many ways to bring the value (Dart side) out of sync with the actual underlying video player state (native side).

I'm happy to review PRs that address root causes of out-of-sync values, rather than layering hacks over them.

@stuartmorgan

Adding hacks instead of addressing root causes directly works against that goal. If the first thing you would do is improve code quality, then I'm not sure why you are arguing against improving this PR as part of the review process.

I am not at all. What I am trying to say is that I am not familiar with the native side and therefore I cannot move this PR in the direction you pointed out.
Thus, I would merge this and create an issue to fix up the native side once there is someone with the knowledge to do so.

(I would have fixed it on the native side if I knew how - I am sure I have the ability to learn how to do it quickly, but not quickly enough that I have the time to do it, unfortunately)

If the first thing you would do is improve code quality, then I'm not sure why you are arguing against improving this PR as part of the review process.

The issue is that I do not have the capacity to do it. Ideally, I would do it 😕

Based on the comments above it doesn't sound like this PR is going to reach a point where it is landable, so I'm going to close it. If at some point in the future you are interested in revisiting a fix that addresses the comments above, please feel free to open a new PR.

I guess we will have to fork the plugin then.

https://github.com/flutter/plugins/pull/4331 should be the iOS-side fix 🎉
But it is also lacking unit tests right now..


JoSS Review: Clarify README.md

With regard to the ongoing review for your JoSS submission, I would like to suggest stating some sort of use cases and/or warnings in your README.md. In particular, one of the largest drawbacks is the case of large VCF files. You even state as much in your code:

def dataframe(filename, large=True):
    """ [...]
    Note: Using large=False with large VCF files. It will be painfully slow.
    [...]
    """

This same cannot be said about your instructions/quickstart.
VCFs can be excruciatingly large sometimes (looking at you 1KG/ENCODE). Many times, researchers want/need to summarize from this starting point. Therefore, suggesting something like filtering the VCF based on region/contig prior to running cerebra would be thoughtful suggestion to gung-ho users to preempt potentially long-running jobs.

thats a great idea - yeah we've noticed that A) VCFs vary greatly in size depending on the experimental source and B) to state the obvious, larger VCFs run much, much slower.

should be addressed with 0e7cde3

This satisfies my concern. Thank you


ListTile selected background inside ReorderableListView. Background doesn't move correctly when  the selected Tile is not the drag target

Steps to Reproduce

Create a ReorderableListView.
Place a ListTile inside the ReorderableListView.
Have one of the ListTiles selected (background color changes)
Drag the tiles around.

Expected results:
Dragging any Tile should moves it's background with it. Even if it is not the Tile directly chosen.
If the dragged Tile is the selected Tile everything works correctly.
Actual results:
However if we drag any other tile, the background color is locked in place until the drag operation is completed. The background color doesn't move with the selected tile.
The background color should move with its associated Tile. Regardless of if it's the target of the drag or just moving as a consequence of a drag operation.

Logs

No errors were reported in the debugger related to this.

[✓] Flutter (Channel stable, 2.2.2, on macOS 11.4 20F71 darwin-arm, locale en-US)
    • Flutter version 2.2.2 at /Users/kent/Developer/flutter
    • Framework revision d79295af24 (10 days ago), 2021-06-11 08:56:01 -0700
    • Engine revision 91c9fc8fe0
    • Dart version 2.13.3

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/kent/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5, Build version 12E262
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.57.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.23.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 11.4 20F71 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 91.0.4472.106

• No issues found!

Example Screen to reproduce issue:
import 'package:flutter/material.dart';

class PresManager extends StatefulWidget {
  const PresManager() : super();

  @override
  _PresManagerState createState() => _PresManagerState();
}

class _PresManagerState extends State<PresManager> {
  List<SlideData> test = [
    SlideData(slideTitle: "One"),
    SlideData(slideTitle: "Two"),
    SlideData(slideTitle: "Three"),
  ];
  SlideData? selectedSlide;
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(),
      body: Column(
        children: [
          Flexible(
            child: Row(
              children: [
                Container(
                  width: 200,
                  child: Column(
                    children: [
                      Flexible(
                        child: ReorderableListView(
                          onReorder: (int oldIndex, int newIndex) {
                            test.insert(newIndex, test[oldIndex]);
                            if (oldIndex < newIndex) {
                              test.removeAt(oldIndex);
                            } else {
                              test.removeAt(oldIndex + 1);
                            }
                            setState(() {});
                          },
                          children: test.asMap().entries.map((e) {
                            return ListTile(
                              selectedTileColor:
                                  Theme.of(context).highlightColor,
                              selected: e.value == selectedSlide,
                              key: Key(e.key.toString() + e.value.slideTitle),
                              onTap: () {
                                setState(() {
                                  selectedSlide = e.value;
                                });
                              },
                              title: Padding(
                                padding: const EdgeInsets.only(right: 16.0),
                                child: AspectRatio(
                                  aspectRatio: 16 / 9,
                                  child: Card(
                                    child:
                                        Center(child: Text(e.value.slideTitle)),
                                    elevation: 2,
                                  ),
                                ),
                              ),
                            );
                          }).toList(),
                        ),
                      ),
                      Container(
                        color: Colors.grey,
                        height: 1,
                      ),
                      Container(
                        child: Center(
                          child: ElevatedButton.icon(
                            icon: Icon(Icons.add),
                            label: Padding(
                              padding: const EdgeInsets.only(
                                  top: 10.0, bottom: 10.0),
                              child: Text('Add Slide'),
                            ),
                            onPressed: () {
                              setState(() {
                                test.insert(1, SlideData(slideTitle: 'test'));
                              });
                            },
                          ),
                        ),
                        height: 60,
                      )
                    ],
                  ),
                ),
                Container(
                  width: 1,
                  color: Colors.grey,
                ),
                Container()
              ],
            ),
          ),
        ],
      ),
    );
  }
}

class SlideData {
  String slideTitle;
  SlideData({required this.slideTitle});
}

Movies first shows dragging the selected Tile around. Background moves as expected with that selected Tile.
Then it shows the bug. Dragging a different Tile from the selected Tile the background color doesn't move until the mouse is released and the drag operation is completed.
https://user-images.githubusercontent.com/2245494/122794508-f0f2f300-d281-11eb-87fd-421b45c11154.mov

@TahaTesser I Have updates the description and reworked the wording of the issue. I hope that is helps. Please let me know if you need anything else.

CC @darrenaustin

Hi @kenthinson
Apologies, the issue is left out my backlog GitHub filter,
Can you please provide a minimal complete reproducible code sample, and expected results vs actual results
Thank you

Hi @kenthinson
Apologies for the late reply, this issue somehow get lost from my backlog, I can reproduce  using the official ReorderableListView sample with some modifications.
Used the following minimal code sample

minimal code sample
/// Flutter code sample for ReorderableListView

import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

/// This is the main application widget.
class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  static const String _title = 'Flutter Code Sample';

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: _title,
      home: Scaffold(
        appBar: AppBar(title: const Text(_title)),
        body: const MyStatefulWidget(),
      ),
    );
  }
}

/// This is the stateful widget that the main application instantiates.
class MyStatefulWidget extends StatefulWidget {
  const MyStatefulWidget({Key? key}) : super(key: key);

  @override
  State<MyStatefulWidget> createState() => _MyStatefulWidgetState();
}

/// This is the private State class that goes with MyStatefulWidget.
class _MyStatefulWidgetState extends State<MyStatefulWidget> {
  final List<int> _items = List<int>.generate(50, (int index) => index);

  @override
  Widget build(BuildContext context) {
    final ColorScheme colorScheme = Theme.of(context).colorScheme;
    final Color oddItemColor = colorScheme.primary.withOpacity(0.05);
    final Color evenItemColor = colorScheme.primary.withOpacity(0.15);

    return ReorderableListView(
      padding: const EdgeInsets.symmetric(horizontal: 40),
      children: <Widget>[
        for (int index = 0; index < _items.length; index++)
          ListTile(
            key: Key('$index'),
            tileColor: _items[index].isOdd ? oddItemColor : evenItemColor,
            title: Text('Item ${_items[index]}'),
            selectedTileColor: Colors.pink[100],
            selected: _items[index] == 3,
          ),
      ],
      onReorder: (int oldIndex, int newIndex) {
        setState(() {
          if (oldIndex < newIndex) {
            newIndex -= 1;
          }
          final int item = _items.removeAt(oldIndex);
          _items.insert(newIndex, item);
        });
      },
    );
  }
}

Preview
https://user-images.githubusercontent.com/48603081/124121787-fd472f00-da7d-11eb-8a7c-7e953666267b.mov

stable
master

❌
❌

Check flutter doctor -v outputs for each channel below

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.2, on macOS 11.4 20F71 darwin-x64, locale
    en-US)
    • Flutter version 2.2.2 at /Users/tahatesser/Code/flutter_stable
    • Framework revision d79295af24 (3 weeks ago), 2021-06-11 08:56:01 -0700
    • Engine revision 91c9fc8fe0
    • Dart version 2.13.3

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.5, Build version 12E262
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.57.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.23.0

[✓] Connected device (3 available)
    • sdk gphone x86 (mobile) • emulator-5554 • android-x86    • Android 11 (API
      30) (emulator)
    • macOS (desktop)         • macos         • darwin-x64     • macOS 11.4
      20F71 darwin-x64
    • Chrome (web)            • chrome        • web-javascript • Google Chrome
      91.0.4472.114

• No issues found!

[✓] Flutter (Channel master, 2.3.0-17.0.pre.608, on macOS 11.4 20F71 darwin-x64,
    locale en-US)
    • Flutter version 2.3.0-17.0.pre.608 at
      /Users/tahatesser/Code/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18ccfe6386 (9 hours ago), 2021-07-01 05:26:03 +0200
    • Engine revision eab0cd490a
    • Dart version 2.14.0 (build 2.14.0-262.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.5, Build version 12E262
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.57.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.23.0

[✓] Connected device (3 available)
    • sdk gphone x86 (mobile) • emulator-5554 • android-x86    • Android 11 (API
      30) (emulator)
    • macOS (desktop)         • macos         • darwin-x64     • macOS 11.4
      20F71 darwin-x64
    • Chrome (web)            • chrome        • web-javascript • Google Chrome
      91.0.4472.114

• No issues found!

✅ : No Issue ❌: Issue reproduced


charge file required for the ligand

Hi,
Additionally to the pdb and mol2 files for protein and ligand, respectively, the TTMD python code asks for one more file for the ligand charges, a requirement not explained in any docu. Please, could the TTMD developers shed some light on the proper format for such a charge file?
Thank you very much in advance for the reply.

Hi,
thank you for showing interest in using our code.
To specify the ligand charge you don't need to use any file. You only need to write down in an integer the charge, for example, 0 or +1 or -1, and so on.
At the moment, we are working on implementing an automatic ligand charge calculator in the next release.


Add support for Windows

There are some tests that do not pass on Windows because of the difference between file paths in windows and linux. For example, sorald.processor.ProcessorTest.

[ ] fix the tests on Windows
[ ] add Windows CI

I wasn't aware that we support Windows. If that's the case, we must also run CI for Windows. It's not just about filepaths, Windows uses a file system that differs quite a lot from those found in Unix-like systems. Permissions are especially a pain, and I've had massive trouble with temporary files and directories before (which Sorald uses a lot both in testing and production).

I wasn't aware that we support Windows

Actually, I'm not sure if we want to support Windows for users either. But it would be nice to, at least, make the tests pass so that developers who user Windows (like me :D) can ensure tests pass locally before pushing it on Github.

I think we should discuss this at the meeting. Due to how dependent Sorald is on file system interaction, supporting Windows might be an added cost that we don't want to have.
As for local development, have you considered Windows Subsystem for Linux (2)? You'd definitely be able to run the tests in there.

On a side note, Windows is the most popular dev platform according to the SO survey, so if we want to have a lot of end users of Sorald (as opposed to running it with e.g. Repairnator), we should probably at least attempt to support Windows.

have you considered Windows Subsystem for Linux (2)?

Not really! I will give it a try. Thanks for the suggestion.

Just for the record, we've decided to add Windows support in the coming months. It's just not quite at the top of the priority list at the moment :)

Just for the record, we've decided to add Windows support in the coming months. It's just not quite at the top of the priority list at the moment :)

It would probably be helpful to fix #166 first, as using filepaths as strings is a massive complication for supporting different file systems.

We have partial Windows support as of #591, but there are still a few test failures. These are ignored with DisabledOnOs(OS.WINDOWS) markers followed by a FIXME comment. We'll want to fix these before stating that we have full Windows support.


timerender: Render past time till 24 hours before showing yesterday.

This avoids the issue of all the topics in recent topics marked
as yesterday after mid-night.
This change also affects other pieces of UI using this function
like buddy list in a similar way.
discussion: https://chat.zulip.org/#narrow/stream/137-feedback/topic/recent.20topics.20timestamps

This is great, merged, thanks @amanagr!

Hmm, though we may have a second bug here -- will it say "2 days ago" for something that 25 hours in the past if the current time is around midnight?

Do we want to show 1 day 1hour ago instead? I am not sure if that is nicer.


Upgrade eslint

Codeclimate added support for eslint 4

Hmmm. Seems not to be available quite yet. I'll leave this open for a bit and re-run codeclimate in a bit


Housing Data Review

Review data for any patterns or interesting trends to share with group and refine further analysis

#22


Refactor project

Shell script/Linux commands
Python programming
API's call
Docker
System logs

https://docs.google.com/document/d/1_2Deo6MxGRDip7Lj2i5RBfdhfSUjbh2K/edit

Edit the Questionary section with the bash and other questions https://github.com/kiwicampus/SD-final-project/blob/main/planner/docs/homework.md
Edit some Additional points with our discussion today: Create a docker session from terminal, create a script that record a topic, graph those topics.


TwoWay and Event Bindings don't recognize UI.Toggle.onValueChanged

When attaching a TwoWayDataBinding or EventBinding script to a Toggle UI element, onValueChanged does not populate in the event subscription dropdown. This appears to stem from the Toggle widget firing a Toggle.ToggleEvent, which is a nested class in Toggle that inherits from UnityEvent.
I've taken some preliminary steps towards a fix, searching both fields and properties of an object to find any MemberInfo's that inherit from UnityEvent, but it appears the existing subscription infrastructure isn't identifying that ToggleEvent handlers accept a bool argument (GetGenericArguments() only searches the inherited type, which in our case is not generic)
I'm happy to help contribute a fix, let me know what would be most helpful! Thanks!

Hi sghitch,
I've actually got a solve for this in the 1.01 branch. I have a shim script called ToggleControl.cs which subscribes to the Toggle event and fires off another event which has the proper property format for a two way binding.
It's a huge commit, but see here: https://github.com/push-pop/Unity-MVVM/commit/69897ee8257553e2ba31c4ec0a2cce413cf60926
For now I have made the decision to NOT search for public fields, although that could change... I think it might make sense in the special case of Events to search for fields (I would also like to add support for Actions at some point as well.)
I actually did test using a ToggleEvent, and calling GetGenericArguments works on that type as well. Since all UnityEvents must be concrete types I don't see how it would be different from another event type.


feat(cli): add actors field to forms subcommand

This PR adds the possibiliy to provide the actors field to the FormInfo aspect when creating forms via the CLI.
I have also changed some of the assertions in the corresponding forms and structured properties classes to throw exceptions instead of relying on the assert statement (see also here: #10219; one of the assert statements was only used for mypy, therefore the assert statement is still used there).
Regarding the format_owners and format_group_owners methods, I don't wanted to change the (public) interface of the Forms class, but of course we don't need them and could also directly use the format_users and format_groups methods in the add_owners method (as the Forms class is relatively new, I don't think it should be an issue to change the interface anyway, but someone else should decide this...).
There were also some changes caused by the linter, let's see whether the linter in the corresponding GitHub Action is accepting the changes or not (I am not sure whether is works correctly on my local environment)...🤷♂
Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[x] Links to related issues (if applicable)
[x] Tests for the changes have been added/updated (if applicable)
[x] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[x] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

The same was implemented with PR #10683...


Add Snowmobile mod from Kerbal Stuff

This pull request was automatically generated by Kerbal Stuff on behalf of EpicSmileyMan64, to add Snowmobile mod to CKAN.
Please direct questions about this pull request to EpicSmileyMan64.

Single .craft file, do we index these?

KS doesn't host .craft files and as such the discussion is moot.


Windows build broken at cli - System.IO.DirectoryNotFoundException: Could not find a part of the path 'C:\build\BranchInfo.props'.

Tested latest source-build and it has failed during CLI repo build. Seems that some directories are hard coded and do not respect root of repo to create correct relative layout.
Error details:
Target "Update" in project "E:\src\ms\dotnet\source-build\targets\repository.proj" (target "Build" depends on it):
Task "Exec"
  Environment Variables passed to tool:
    DOTNET_RUNTIME_ID=win10-x64
    DOTNET_TOOL_DIR=E:\src\ms\dotnet\source-build\Tools/dotnetcli/
    BUILD_TOOLS_TOOL_DIR=E:\src\ms\dotnet\source-build\Tools/
    BUILDTOOLS_SKIP_CROSSGEN=1
    DotNetBuildFromSource=true
    DotNetRestorePackagesPath=E:\src\ms\dotnet\source-build\packages/
    DotNetCoreSdkDir=E:\src\ms\dotnet\source-build\Tools/dotnetcli/
    DotNetBuildToolsDir=E:\src\ms\dotnet\source-build\Tools/
    GitInfoCommitCount=6908
    GitInfoCommitHash=38031f6e5c3e21fa39d82aca300f5ed769be10a0
  (set DOTNET_VERSION_URL=file://E:\src\ms\dotnet\source-build\bin/obj/x64/Release/build-info/) & powershell.exe E:\src\ms\dotnet\source-build\src/cli/build_projects/update-dependencies/update-dependencies.ps1 -Update

  PowerShell version: 5.1.15063.632
  Free physical memory: 11997 MB out of 16300 MB

  Restoring E:\src\ms\dotnet\source-build\src\cli\build_projects\update-dependencies\update-dependencies.csproj...
    Restoring packages for E:\src\ms\dotnet\source-build\src\cli\build_projects\update-dependencies\update-dependencies.csproj...
    Installing Microsoft.DotNet.VersionTools 1.0.27-prerelease-01723-01.
    Generating MSBuild file E:\src\ms\dotnet\source-build\src\cli\build_projects\update-dependencies\obj\update-dependencies.csproj.nuget.g.props.
    Generating MSBuild file E:\src\ms\dotnet\source-build\src\cli\build_projects\update-dependencies\obj\update-dependencies.csproj.nuget.g.targets.
    Restore completed in 4,07 sec for E:\src\ms\dotnet\source-build\src\cli\build_projects\update-dependencies\update-dependencies.csproj.
  Invoking App E:\src\ms\dotnet\source-build\src\cli\build_projects\update-dependencies\update-dependencies.csproj...

  Unhandled Exception: System.IO.DirectoryNotFoundException: Could not find a part of the path 'C:\build\BranchInfo.props'.
     at System.IO.FileStream.OpenHandle(FileMode mode, FileShare share, FileOptions options)
     at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
     at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize)
     at System.Xml.XmlDownloadManager.GetStream(Uri uri, ICredentials credentials, IWebProxy proxy, RequestCachePolicy cachePolicy)
     at System.Xml.XmlUrlResolver.GetEntity(Uri absoluteUri, String role, Type ofObjectToReturn)
     at System.Xml.XmlTextReaderImpl.FinishInitUriString()
     at System.Xml.XmlTextReaderImpl..ctor(String uriStr, XmlReaderSettings settings, XmlParserContext context, XmlResolver uriResolver)
     at System.Xml.XmlReaderSettings.CreateReader(String inputUri, XmlParserContext inputContext)
     at System.Xml.XmlReader.Create(String inputUri, XmlReaderSettings settings)
     at System.Xml.Linq.XDocument.Load(String uri, LoadOptions options)
     at System.Xml.Linq.XDocument.Load(String uri)
     at Microsoft.DotNet.Scripts.Config.GetRepoMSBuildPropValue(String propsFileName, String propertyName) in E:\src\ms\dotnet\source-build\src\cli\build_projects\update-dependencies\Config.cs:line 94
     at Microsoft.DotNet.Scripts.Config.GetDefaultUpstreamBranch() in E:\src\ms\dotnet\source-build\src\cli\build_projects\update-dependencies\Config.cs:line 80
     at Microsoft.DotNet.Scripts.Config.<>c.<.ctor>b__12_7() in E:\src\ms\dotnet\source-build\src\cli\build_projects\update-dependencies\Config.cs:line 44
     at System.Lazy`1.ViaFactory(LazyThreadSafetyMode mode)
     at System.Lazy`1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)
     at System.Lazy`1.CreateValue()
     at Microsoft.DotNet.Scripts.Config.get_GitHubUpstreamBranch() in E:\src\ms\dotnet\source-build\src\cli\build_projects\update-dependencies\Config.cs:line 59
     at Microsoft.DotNet.Scripts.Config.GetDefaultCoreSetupVersionFragment() in E:\src\ms\dotnet\source-build\src\cli\build_projects\update-dependencies\Config.cs:line 86
     at Microsoft.DotNet.Scripts.Config.<>c.<.ctor>b__12_4() in E:\src\ms\dotnet\source-build\src\cli\build_projects\update-dependencies\Config.cs:line 41
     at System.Lazy`1.ViaFactory(LazyThreadSafetyMode mode)
     at System.Lazy`1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)
     at System.Lazy`1.CreateValue()
     at Microsoft.DotNet.Scripts.Config.get_CoreSetupVersionFragment() in E:\src\ms\dotnet\source-build\src\cli\build_projects\update-dependencies\Config.cs:line 56
     at Microsoft.DotNet.Scripts.Program.Main(String[] args) in E:\src\ms\dotnet\source-build\src\cli\build_projects\update-dependencies\Program.cs:line 28
  Build failed
  At E:\src\ms\dotnet\source-build\src\cli\build_projects\update-dependencies\update-dependencies.ps1:51 char:27
  + if($LASTEXITCODE -ne 0) { throw "Build failed" }
  +                           ~~~~~~~~~~~~~~~~~~~~
      + CategoryInfo          : OperationStopped: (Build failed:String) [], RuntimeException
      + FullyQualifiedErrorId : Build failed

E:\src\ms\dotnet\source-build\targets\repository.proj(100,5): error MSB3073: The command "(set DOTNET_VERSION_URL=file://E:\src\ms\dotnet\source-build\bin/obj/x64/Release/build-info/) & powershell.exe E:\src\ms\dotnet\source-build\src/cli/build_projects/update-dependencies/update-dependencies.ps1 -Update" exited with code 1.
Done executing task "Exec" -- FAILED.
Done building target "Update" in project "repository.proj" -- FAILED.
Done Building Project "E:\src\ms\dotnet\source-build\targets\repository.proj" (BuildRepositoryAndDependencies target(s)) -- FAILED.
Done executing task "MSBuild" -- FAILED.
Done building target "Build" in project "build.proj" -- FAILED.
Done Building Project "E:\src\ms\dotnet\source-build\build.proj" (default targets) -- FAILED.

Build FAILED.

System details:
Windows 10 Pro 1703 x64 pl-PL with language packs defaults to en-US
Visual Studio 2017 v15.3.5

@4creators which branch are you on. I believe this is working in dev/release/2.0

@dleeapho
All todays builds have been done on default repo branch: dev/release/2.0
The commit of my last built is: 716b5ac832a95ea9d29fee5e3bd2c88ad963b3c3
Problem is reproducible and I am trying to debug it although I have extremely limited spare time this week.

The component at fault is the Microsoft.DotNet.Scripts.Config.GetRepoMSBuildPropValue.  It expects the cwd to be the root of the CLI repo.
Source-build ensures this when it calls this Update command here:
https://github.com/dotnet/source-build/blob/716b5ac832a95ea9d29fee5e3bd2c88ad963b3c3/targets/repository.proj#L100
The Windows build leg is passing in CI, so I'm not sure why you are experiencing this error.

@eerhardt Thnx for help in drilling down to the source of error. The problem was with powershell script invocation which skipped -NoProfile command line option what triggered profile script execution and change of current working directory. As this is a general problem which may happen in any repo I have suggested a general solution in #225


Update ttrpc vendor to forked version to fix deadlock

This pulls in a new version of github.com/containerd/ttrpc from a fork
to fix the deadlock issue in containerd/ttrpc#72. Will revert back to
the upstream ttrpc vendor once the fix is merged (containerd/ttrpc#73).
This fix also included some vendoring cleanup from running "vndr".
Signed-off-by: Kevin Parsons<EMAIL_ADDRESS>

@ambarve @anmaxvl @dcantah @katiewasnothere PTAL

LGTM. I assume that extra changes being vendored in are OK?

Yes, that's just some vendor cleanup that was performed automatically.

Are we supposed to focus our reviewing efforts of the deadlock ttrpc changes here or the upstream PR? I take it this is a "this fixes the issue and barring any critical flaws we saw, just want a set of eyes on the vendored files", am I off?

Are we supposed to focus our reviewing efforts of the deadlock ttrpc changes here or the upstream PR? I take it this is a "this fixes the issue and barring any critical flaws we saw, just want a set of eyes on the vendored files", am I off?

Mostly need focus on the upstream ttrpc PR. Comments here would be good if there are any concerns unique to this PR, such as from the vendoring or other ttrpc changes being brought in.

Re-purposing this to be a general revendor PR and pulling in one more change. Will need another look in a moment.


this.file.name inline query renders as - in sidebar reading view

What happened?
The query works fine in other reading and editing panes and renders the correct note name. In the sidebar it also renders correctly in editing views, but displays a dash (-) character only in reading views.
Dataview Version
0.5.52
Obsidian Version
1.1.9
OS
Windows

Open the sandbox vault, install and enable the plugin.
Paste `=this.file.name` into the Start Here note that appears.
Drag the note into the sidebar
Toggle reading view in the note in the sidebar
Open a note from file navigation (or perform any other action that makes Obsidian save the current layout)
Reload the app.

Video.webm

Very interesting and first class reproduction steps. Yours is practically the gold standard. I wish more people did this lol.


Updating React to 15.4.1 brings dependency issue with this package

Can you also release a new version which supports react-tap-event-plugin v2.0.1 ?
I want to update my dependencies for react 15.4.1 and the latest release still uses react-tap-event-plugin v1.x

What's blocking it? I don't have any dependency to it: https://github.com/oliviertassinari/react-swipeable-views/blob/master/package.json#L34-L43.

I'm closing this issue. I don't think that the root of the issue is here.


Difference in the camera setting

Hi authors,
I noticed that in gaussiandreamer_mvdream.yaml the camera distance is set to [0.8, 1.0] and eval at 3.0, and fovy range is [15, 60], elevation_range [0, 30]. However in gaussiandreamer.yaml it is distance=1.5, 4.0 eval at 4.0, (default config) elevation=-10, 60.
I am wondering why is it set differently, is it because the gaussiandreamer_mvdream.yaml is default to be trained with LRM init, while gaussiandreamer.yaml is SHAP-E init, as the scale of the above two are different? But why are the fovy, az, elevation also different?
Looking forward to your reply!

The camera setting is inherited by the threestudio and threestudio-mvdream respectively.
The initialization method causes no difference in camera settings, e.g., you can use LRM with SD2.1 and Shap-E with mvdream.


Improve tasks

Problem statement
Any time that a reviewer of a PR needs to leave actions for the author in order to complete and merge their pull request, it can easily become unclear about what action is required and where to find these actions for both the author (to carry out) and the reviewer (to track). This confusion can prolong the time a pull requests takes to be merged resulting in hurt productivity and frustrated users (authors and reviewers).

Leaving a comment on the entire PR now, please.

https://github.com/tswanatlassian/angular.js/projects/1


Update "Postgres Compatibility" page with spatial support

Once our spatial support lands for 20.2, we need to update 'Postgres Compatibility' and all other places that mention our heretofore lack of support for spatial things to say that, yes, we finally have (some of) it!

This issue can be closed, based on a quick look at the following pages (and searching the rest of our docs for the term "spatial" where it may have been referenced as a gap):

https://www.cockroachlabs.com/docs/v20.2/sql-feature-support
https://www.cockroachlabs.com/docs/stable/postgresql-compatibility.html

This issue can be closed, based on a quick look at the following pages (and searching the rest of our docs for the term "spatial" where it may have been referenced as a gap):

https://www.cockroachlabs.com/docs/v20.2/sql-feature-support
https://www.cockroachlabs.com/docs/stable/postgresql-compatibility.html