add simdjson submodule

For issue 3658, add the simdjson library dependency first.
Authored-by: Wan, weiqiang<EMAIL_ADDRESS>Co-authored-by: Cavalcanti, Adenilson<EMAIL_ADDRESS>Co-authored-by: @xiaodouchen<EMAIL_ADDRESS>

Have implemented json extract and other json function with simdjson
The result shows great performance gains with our implementation.
In simple function mode，SimdJsonExtract can get about 5X~40X speedup compared with VeloxJsonExtract.

In vector function mode, SimdJsonExtract can get about 2X~20X speedup compared with VeloxJsonExtract.

@wanweiqiangintel Thank you for working on speeding up JSON processing in Velox. There are CI failures. Please, take a look.
@kgpai Krishna, this PR introduces a new dependency on simdjson library. Would you advice on the right way to add such a dependency?
@wanweiqiangintel It would be helpful to provide a design document to (1) discuss whether the new code has the same semantic as existing; (2) how much faster the new processing is and how it is being measured (might be helpful to add a microbenchmark); (3) which functions the speedup applies to.

These two files (twitter_10M.json and twitter_1M.json) are too large to be placed directly in the source code repository, probably not a good idea. Maybe we should find a better way, such as putting it in some FTP server, and then only providing the download address, or providing a generation script, which can be downloaded or generated on demand when running performance tests.

These two files (twitter_10M.json and twitter_1M.json) are too large to be placed directly in the source code repository, probably not a good idea. Maybe we should find a better way, such as putting it in some FTP server, and then only providing the download address, or providing a generation script, which can be downloaded or generated on demand when running performance tests.

thanks for reminder, updated.

@wanweiqiangintel Thank you for the context. Sounds great. Have you had a chance to look into whether simdjson allows for efficient implementation of json_parse as well?

The new code is not exactly the same as existing, but it achieves the same set of features

Are there any user-visible / semantic differences? If yes, what are these?

@wanweiqiangintel Thank you for the context. Sounds great. Have you had a chance to look into whether simdjson allows for efficient implementation of json_parse as well?

The new code is not exactly the same as existing, but it achieves the same set of features

Are there any user-visible / semantic differences? If yes, what are these?
Sure, I will add a benchmark to evaluate the performance of json_parse as well.

For the user-visible / semantic differences:

The way to process a number that exceeds the range of long type in json_extract_scalar and json_parse.
simdjson implementation will normalized output in json_parse, such as removing the spaces between each element.
original folly library support jsonExtractScalar and jsonExtract, the output of jsonExtractScalar is std::string and the output of jsonExtract is folly::dynamic, while simdjson implementation only support SimdjsonExtractScalar because I have no idea to convert simdjson output object to folly::dynamic.

I will add simdjson-difference as a flag to mark the difference between the new code and original.

@wanweiqiangintel Thank you for further clarifications. Let's start a design doc to collect all this information in a single place.

The way to process a number that exceeds the range of long type in json_extract_scalar and json_parse.

Would you further clarify these differences? Would you provide examples that behave differently?

simdjson implementation will normalized output in json_parse, such as removing the spaces between each element.

Same as above.

original folly library support jsonExtractScalar and jsonExtract, the output of jsonExtractScalar is std::string and the output of jsonExtract is folly::dynamic, while simdjson implementation only support SimdjsonExtractScalar because I have no idea to convert simdjson output object to folly::dynamic.

I'm seeing that jsonExtract is only used to implement json_size. I imagine it should be possible to implement this function a lot more efficiently without "materializing" the actual array. Is this something that simdjson would allow us to do? Similar question is about json_parse, can we implement it without "materializing" the actual JSON object and therefore avoiding memory allocations and copy?

@wanweiqiangintel Thanks you for the examples of semantic differences. I checked these with Presto Java and it looks like Presto Java behavior matches simdjson and differs from Velox current behavior. Since Velox must match Presto semantics simdjson implementation would fix some bugs. CC: @kagamiori
presto> select json_extract_scalar('184467440737095516151844674407370955161518446744073709551615', '$');
                            _col0
--------------------------------------------------------------
<PHONE_NUMBER>37095516151844674407370955161518446744073709551615
(1 row)

presto> select json_parse('["k1", "v1"]');
    _col0
-------------
 ["k1","v1"]
(1 row)

Hi, @mbasmanova, the design doc is in the discussions. Could you help to review it?

@wanweiqiangintel I still see multiple catch blocks that just re-throw the exception:
    } catch (simdjson::simdjson_error& e) {
      throw e;
    }

Any particular reason to have these? I assume we can simply remove them, no?

fixed, change throw error to return false.


Remove unused 'cmake_minimum_required' commands

Depends on https://github.com/patrikhuber/eos/pull/83

LGTM, thank you!
Will merge after we sort out the other PRs, since this one depends on them. Thanks!

Thanks again.


Some ideas from an author who is working on something similar to this project.

Hi @saadq , I'm working on a project which is similar to this project: https://github.com/g-plane/methane .
As we know, both ESLint and TSLint is so large with their dependencies. When installing ESLint and TSLint at the same time, it will cost much disk space. So if this project use plugin-based architecture will bring freedom to developers. BTW, plugin-based architecture doesn't mean it needs configuration. You can still keep zero-config with plugin-based architecture, just like how my project does.

Not everyone uses TypeScript and TSLint.
Most developers use pure JavaScript so they don't use TypeScript and TSLint. When a project haven't installed TypeScript, the package manager will warn that TypeScript is a peer dependency of TSLint. It's noisy.

And, as what I said above, my project is also a linter wrapper which is similar to this project lynt, so I can provide some help as I have some experience on this. For example, we could use a better linter formatter which is used in my project:

eslint-formatter-beauty
tslint-formatter-beauty

Thanks.

I've been thinking on this for awhile. I'm a fan of your project, and I think its plugin architecture is pretty cool.
I'm struggling with the idea of doing this with lynt though. Though I am not satisfied with the size that lynt requires (even though it's just a devDependency), I think it is a tradeoff for convenience. The main goal of this project was to be easy and simple to use – it comes with everything, and you just tell it what stuff you want when you use it. I don't really want to make the user have to install multiple packages – that's one thing that annoyed me when I was a standard user and I had to always install snazzy alongside it.
I am also unhappy about the peerDependency warning, but I think a lot of npm users have tend to just tune it out from seeing it a lot.
I like your formatter – it's really nice. I'm just concerned about it possibly being too noisy it when you have multiple errors in multiple files. I like the current formatter for lynt as default, but I think having something like this might be cool as an alternate format with something like lynt --verbose.

I agree with you.

Closing in favor of #17


Field customizer doesn't load in a list created in a modern team site (group)

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
Test Field customizer in a list created in a modern team site (group)
Observed Behavior
The warning about loading debug manifests is displayed, but the field customizer isn't loading. No errors are reported in the console.
Steps to Reproduce

Go to SharePoint Home (/_layouts/15/sharepoint.aspx)
Create new site
In the new site create a new list
Append the query string parameters to debug a field extension in the list
The warning about the debug manifests is displayed but the extension isn't loading

For comparison: if you create a new classic site through the SharePoint Admin page and create a new list there, debugging the field customizer works as expected.

I am facing the exact same behavior when "trying" to debug it together with a Display form. I know it is not supported (but REALLY DESIRED ;-) ) so far together with Edit+New form but "thought" it "might" be with a Display form as it is not "that far away" ;-)
https://mmsharepoint.wordpress.com/2017/06/25/sharepoint-framework-spfx-extensions-simple-field-customizer-to-show-a-traffic-light-status-rag/

Has been fixed while back, so closing from issue list.


[BUG] PlatformException unregistered_view_type

Describe the bug
ERROR: PlatformException(unregistered_view_type, A UIKitView widget is trying to create a PlatformView with an unregistered type: < plugins.flutter.io/webview >, If you are the author of the PlatformView, make sure registerViewFactory is invoked.
To Reproduce
Steps to reproduce the behavior:

Just added ToolBar and QuillHtmlEditor

ToolBar(controller: _controller),
const SizedBox(height: 10),
QuillHtmlEditor(
         controller: _controller,
          text: state.value,
          minHeight: 300,
          hintText: 'Write your text here',
          isEnabled: state.enabled,
),

It just gives error and only loading indicator is being shown:
Error

flutter: ERROR: PlatformException(unregistered_view_type, A UIKitView widget is trying to create a PlatformView with an unregistered type: < plugins.flutter.dev/pointer_interceptor_ios >, If you are the author of the PlatformView, make sure `registerViewFactory` is invoked.
See: https://docs.flutter.dev/development/platform-integration/platform-views#on-the-platform-side-1 for more details.
If you are not the author of the PlatformView, make sure to call `GeneratedPluginRegistrant.register`., null)
StackTrace: #0      StandardMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:651:7)
#1      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:334:18)
<asynchronous suspension>
#2      PlatformViewsService.initUiKitView (package:flutter/src/services/platform_views.dart:243:5)
<asynchronous suspension>
#3      _DarwinViewState._createNewUiKitView (package:flutter/src/widgets/platform_view.dart:671:36)
<asynchronous suspension>

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: Iphone 15 Pro (ios simulator)
OS: com.apple.CoreSimulator.SimRuntime.iOS-17-2

Flutter Doctor
Details

[✓] Flutter (Channel stable, 3.19.0, on macOS 14.4.1 23E224 darwin-x64, locale en-UA)
[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
[✓] Chrome - develop for the web
[!] Android Studio (not installed)
[✓] VS Code (version 1.88.1)
[✓] Connected device (3 available)
[✓] Network resources

! Doctor found issues in 2 categories.

How did you solve this problem? Can you explain your solution?

I'm waiting for solution.


[Localization] Install only *.db and *.yaml files

This prevents us from picking up the .gitkeep file and any other stray files that might end up in there.
Fixes rdar://68580755

CC @xedin @gottesmm for review

Thanks @porglezomp = ).

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test Linux

@swift-ci please test Windows


Use Case: Avoid @type array for contextual entities

As a user interface developer, I want to know a single type for contextual entities so that I can choose the most appropriate UI rendering.
In https://github.com/UTS-eResearch/describo the interface is broken down by type of contextual entity, e.g. @type
however some parts of the RO-Crate text, e.g. https://researchobject.github.io/ro-crate/1.0/#workflows-and-scripts have multiple types in an array:
{  "@id": "workflow.xml",
  "@type": ["File", "SoftwareSourceCode", "Workflow"] }

This can make it hard to pick the right type to use for rendering, and there is no guarantee that the order of the list is preserved through JSON-LD processing.
Previously we looked at using http://schema.org/additionalType for extra types - but this is not ideal for schema.org types as it requires full URIs and we really want a more specific type like http://schema.org/ScholarlyArticle to be used where fitting, instead of say http://schema.org/CreativeWork as the subclasses often have additional properties.
https://researchobject.github.io/ro-crate/1.0/#publications-via-citation-property suggest ScholarlyArticle as a contextual entity, but there is no reason why an article could not also be a File part of the RO-Crate, e.g. a preprint PDF. In fact this is in the original http://www.researchobject.org/ vision.
One reason we had before for using @type array was that it made it easy to comply with the RO-Crate spec saying one particular type, while also wanting to use a more specific type, or a type from a different vocabulary. Consumers of the RO-Crate would not need to know any class hierarcies or ontologies, as the "base" @type would also be listed.
If we move to a single @type then they need at least to have knowledge of the schema.org hierarcy (which we could add to the RO-Crate context - we could still use http://schema.org/additionalType for "external" types when people are extending RO-Crate - however this is not ideal from a Linked Data point where people use properties from the extension but the RDF type would be missing.
We also said before that all entries in a Dataset must be of type File - so if they need to also be SoftwareSourceCode then you need an array. So this restrictions would also have to be lifted and made into a fallback when no more specific type is available. Similar issue for ImageObject with EXIF and RepositoryObject with other types from RO-Crate.
Personally I preferred the old @type arrays however the convention above is not described well in the spec.
I think we need to see what happens if we try to do this change, see for instance pull request #81 that already found issue of Workflow vs Script vs File vs SoftwareSourceCode (and decided to simplify for just SoftwareSourceCode). I don't think we want everything to just be File as again an important http://www.researchobject.org/ principle is to have rich types of the aggregated objects.
Hoping for inputs from @ptsefton and @marcolarosa that raised this issue in the RO-Crate Community calls

At the moment (and this is nowhere near final) Describo has a mappings file that maps @type arrays to a singular value in order to determine which type definition to load.
export const mappings = {
    "File, ImageObject": "File",
    "File, SoftwareSourceCode, Workflow": "Workflow",
    "File, ImageObject, WorkflowSketch": "WorkflowSketch",
    "File, Script, SoftwareSourceCode": "Script",
};

So for example, an object coming in from a crate with @type = [ 'File', 'ImageObject' ] would be loaded with a File definition. However, at this stage, it's not possible to create a File object within Describo and write it out with an @type = [ 'File', 'ImageObject' ].
We have discussed a way to map from one type to another in a profile (see: https://github.com/UTS-eResearch/describo/issues/70) and this might be part of a solution to this question if @type arrays are to be supported. Specifically, we would have a type definition in Describo (remember, this is what the profile uses to render the UI) called ImageObject that when used writes out an object with @type = [ 'File', 'ImageObject' ].

It might be needed a button to "promote" something to another type - but the challenge is that the new type may not be a direct subclass of the existing one - e.g.  https://schema.org/ImageObject is a subclass of https://schema.org/MediaObject (our File), which is subclass of https://schema.org/CreativeWork is not related - but https://schema.org/Article is a sister-class of MediaObject so which one would "win"?
I think the grouping by type like in Describo is very useful, but it needs such a mapping as @marcolarosa (or at least the class hierarchy) describes if is to avoid double-listing. So do I get Marco that you are not that insistent on removing the @type arrays anymore?
schema.org offers a derived download of the class hierarchy which we could embed/link, although this is simplified, e.g. https://schema.org/VideoGame is only subclass of Game and is not listed under its secondary parent SoftwareApplication. We could augment it with our new hierarchies like in your mapping.
i would also like as in #71 to use SKOS - it would make it easier to keep both directions of the hierarchy - see https://gist.github.com/stain/39f74513515e34cf9a602c4d6f9cef58#file-schema-skos-flattened-jsonld or the compacted tree https://gist.github.com/stain/39f74513515e34cf9a602c4d6f9cef58#file-schema-skos-framed-jsonld (with duplication for VideoGame etc).   -- this could also be done for properties although they don't have a top-level concept equivalent to http://schema.org/Thing.

@stain From the perspective of the code a singular type is easier to work with and won't require an application update when someone comes up with another combination. So from that perspective I would argue for a singular main type and a secondary array of subtypes.
Consider loading into Describo a crate with @type = [ 'File', 'Fruit', 'Apple' ] - Describo wouldn't know what to do with it until that mapping has been provided.

@marcolarosa instead of defining mappings, could you not have a priority listing of types that your application knows about?
i.e. with File listed above ImageObject so it takes precedence in the case that something has ["File", "ImageObject"]

@fbacall Having a priority list as you mention is definitely doable and TBH, this is something @ptsefton also discussed when we were developing Describo. Though I'd forgotten about it your comment has reminded me that our decision then was to wait on this conversation to occur before we would go back and address it in the tool.
The question for me is how do we determine which is the higher precedence type. We could encode the schema.org hierarchy into Describo but that wouldn't be too different to using a mapping file. It's something that needs to be maintained and doesn't lend itself easily to overrides for specific domains. And this community still needs to decide whether to use least specific or most specific assuming Describo has a type definition for it.
Or, we could just walk the @type array and find a match left to right (more specific) or right to left (least specific) but this assumes the data coming in has a defined order by choice and can be trusted as is.
Furthermore, creating an ImageObject requires Describo to load a File definition in order to know what can be described but then write out something with ['File', 'ImageObject'] which would require some toggle to say it should come out that way instead of just @type = ['File'].
I haven't thought this through completely but my feeling is Describo would need to support cascading type definitions to support multiple @types in order to mitigate a massive amount of redundancy. So, a type definition of ImageObject would have @type = ['File', 'ImageObject'] but it would inherit all of the properties of the 'File' type definition whilst also adding those specific to ImageObject. This is not currently possible.

A priority list could be pretty simple. File and Dataset are special in RO-Crate - and in an application like Describo they have special user interface elements.
If we move to having a single @type then that is at odds with JSON-LD - and people would still have to code defensively in case someone used multiple types. Using additionalType jsut shifts the same coding issues to a new property - programmers will still have to deal with lists of types  and it breaks RDF interoperability.
So I think the spec shoudl jsut be more explict that certain types of things (like Workflows) are identified using an unordered set of @types (and may have additional extra ones).

Thanks, @ptsefton, although I notice you don't agree with @marcolarosa in https://github.com/ResearchObject/ro-crate/issues/83#issuecomment-644449024 !
If we agree then to keep @type arrays, then we can soften this in other cases, e.g. #81 can use both @type https://schema.org/SoftwareSourceCode and the not-yet-existing https://bioschemas.org/Workflow
Then we would instead need a paragraph somewhere about @type arrays, the defensive coding as you mention. Perhaps showing how this could be used with other vocabularies - right after https://researchobject.github.io/ro-crate/1.0/#extending-ro-crate appendix perhaps?
Do you think this mean we should then still keep File also on these specialized data entities like Workflow?
Then we should add a section in the main section on how a data entity can be described further, perhaps using http://schema.org/ScholarlyArticle as example

@stian yes I think we should keep File on specialized data entities becuase FIle and Dataset have special status as Data Entities and may get special handling in apps and HTML previews etc -- will draft something for consideration.


link whole .brewItem card to /edit or /share?

From #240

The whole card should be either a link to the Edit Page if you are the author, or to the Share page if not the author...still retain the little pop up/:hover element that shows the current 4 options, but anticipate the users click based on authorship when clicking anywhere else on the card.

The common action is to either edit-if-author or view-share-if-visitor. Make that the easiest.

We should be able to attach an onClick method to the BrewItem which will then contains the logic to redirect appropriately; my initial feeling is that this should be a relatively simple change which should improve the User Page user experience.

Better to attach an event listener to a higher container, and from there detect if the element clicked was the brewItem (and not the individual links in the sidebar.
document.querySelectorAll('.published,.unpublished')
.forEach(
  item => {
    item.addEventListener( 'click',
      (event) => {
        // do the hard work here
      }
  } );

The "hard work" would be

determining if the click landed inside element with ancestor
 (if so just return true and let the brwser handle the click); and failing that
determine if the click was on an element with ancestor
, then find the appropriate link in the .links div inside that .brewItem.

With item 2, it would be handy if each of the  elements had an appropriate identifying class, like this:

  ...
  ...
  ...
  ...

(This would be preferable to doing document.querySelector('[href^="/edit"]'), as class="edit" is deliberate and explicit, while href^="edit"` might be subject to change for reasons completely unrelated to this click handler. Thus: safer.)
While we're at it, the two divs currently found via document.querySelectorAll('.published,.unpublished') could maybe have a "collection" class also applied (in anticipation of future efforts of having folders/views/collections). Alternatively, the event listener could simply be attached to .phb since we're only handling those clicks with event.target.closest('.brewItem') (and thus the interactive elements within .phb .sort-container can still have their clicks passed to them by default).
I will have the // hard work here bit figured out soon. Fiddling about in the console now...

So, something like this, but optimised/linted/etc
document.querySelectorAll('.published,.unpublished')
.forEach(
  item => {
    item.addEventListener( 'click',
      (event) => {
        // do the hard work here
        let brewItem = event.target.closest('.brewItem');
        if ( !brewItem ) return true;
        if ( brewItem && event.target.closest('.links') ) return true;
        if ( brewItem ) {
          event.preventDefault();
          let editLink = brewItem.querySelector('[href^="/edit/"]');
          let shareLink = brewItem.querySelector('[href^="/share/"]');
          if ( editLink ) {
            let href = editLink.getAttribute('href');
            window.open(href, '_blank').focus();
            return false;
          }
          if ( shareLink ) {
            let href = shareLink.getAttribute('href');
            window.open(href, '_blank').focus();
            return false;
          }
          return true;
        }
      }
  } );

I don't think we need this at all, the current system works just fine. Considering closing this.

Seconded

Closing as unnecessary, we can always come back to it and reopen.


Regression making floating-menu unclickable

Describe the bug
After the b381e500 commit and 1.22.1 release, I can no longer interact with the editor-floating-menu component. Trying to click it results in isActive being flipped to false and hiding it.
Any ideas on that?

Here's a quick video of the issue in action.

When we click that button in Jack's gif, this is what's getting fired:
https://github.com/scrumpy/tiptap/commit/b381e50043baee0f2594d212e30ab0750bf7df80#diff-1fcbad22612f4e7fc6b4b4d9dae86289R21

@jasonvarga hmm strange. but that blur event was already there before 🤔
did you try to call event.stopPropagation() on your button click?

Yes, no luck.

For what it's worth, I was seeing this behavior in Firefox before this update, and now I'm seeing it all browsers.

It seems to blur before any click events happen on any buttons inside the menu.

Ah, the code on the demo page is only working because of a fade transition. So quick fix for you: add a transition.
But I have to find a solution for this.

You folks are awesome! ❤


Enable Go modules as a default

Description
Enable Go modules as a default
Update the templates to use GO111MODULE=on as a default
Then clarify in the docs or the README here how to turn it off, for those who need to vendor private code.
Testing
Test end to end to show that the build arg to turn off modules still works
Show output that also shows the default is working without additional settings.

/add label: good first issue, help wanted

i will work on that, expected to have a pr by the end of the week

Thanks Carlos


Code formatting and documentation

This PR aims to make the code easier to work on by formatting the code with cargo fmt, refactoring and cleaning up some of the code, and adding comments to document the code.
For the formatting, i manually went through and verified every change.
I kept the formatting commit separate on purpose, so if you don't like it i can rebase the PR without them.

I think that's about all i can clean up and document.
I rather not comment too much on the parts i don't understand well, better to have no comments that wrong comments.

Hooray! Great job, really! Thank you so much. Merged with a deep feeling of satisfaction :)


Improve dirty terminal editor wording

Introduces a custom confirm dialog for terminals:

This PR fixes #128880

Decided to implement support for custom confirm dialog handling even when multiple editors are closed:

via https://github.com/microsoft/vscode/pull/130881/commits/a45141580e16626b99c89b0096cd8c73a7e9700f
Note: interestingly we never show a combined dialog if you just close all editors of a group. Instead you need to pick either "View: Close All Editors" or "View: Close All Editor Groups". I forgot the reasoning but I think some people wanted to avoid the combined dialog and decide per-editor.

Feel free to tweak the dialog wording here:
https://github.com/microsoft/vscode/blob/a45141580e16626b99c89b0096cd8c73a7e9700f/src/vs/workbench/contrib/terminal/browser/terminalEditorInput.ts#L107-L120


default route name set to name of VirtualService name

Please provide a description for what this PR is for.
For generated routes in XDS from VirtualServices, the route name is empty unless a name is specified VirtualService match criteria.  This PR uses the virtual service name as the default route name if none is provided.  This way, all routes generated by XDS should be able to be modified with an EnvoyFilter since the match criteria is dependent on name field
part of #26692
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ X ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@GregHanson: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
9326070808547efc7cd4240e2abfb2c8e657136e
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Using wildcard in CoAP resources description

Use MQTT style wildcard in 'struct coap_resource' path description:

the plus symbol represents a single-level wild card in the path;
the hash symbol represents the multi-level wild card in the path.

This change keeps compatibility with RFC 7252 but allows handling multiple requests in single function like
PUT /led/0
PUT /led/1

I'm a bit confused, why do you introduce a MQTT wildcard concept into a CoAP library? AFAIK CoAP does not specify any wildcards or how to deal with them (please provide me with a link to the specification if I'm wrong).

Actually we have no ways to Get/Post enumerated data in CoAP.
And this improvement was marked as "FIXME" - line 826 file coap.c

Regarding the FIXME:
/* FIXME: deal with hierarchical resources */

@rveerama1 Could you clarify what did you mean by this comment? As far as I understand (CoAP spec does not clarify the term of hierarchical resources), this mean a multi-level resource, like /x/y/z which we already do support. Or was it about introducing some tree-like structure for the resource representation instead of a simple array?
I've already expressed my concern about introducing non-standard extensions to the CoAP library, but I think it would be good to hear from others as well.
Perhaps the goal you want to achieve could be tackled another way, like registring a default resource handler for resources that are not registered? Or simply handling -ENOENT from coap_handle_request() in the application?

Let's clarify: this change not related to the protocol itself, but only for handling messages inside Zephyr. Now we can accept messages like
PUT /led/0
PUT /led/1
with only one line in 'struct coap_resource' instead of writing separate lines for each target.
This update keeps compatibility RFC 7252 but reduces the code footprint.

I've already expressed my concern about introducing non-standard extensions to the CoAP library, but I think it would be good to hear from others as well.

I would say that this PR is quite bare on problem description, motivation, and argumentation for a particular way of solving it. Descriptions like "coap: Describing hierarchical resources as described in MQTT standard" indeed give an expression that this change is a result of some confusion.

Clean-up and changing PR message.

Thanks for clarifying the commit messages.
While I understand how this change can simplify specific use-cases, I'm still slightly concerned about RFC 7252 compatibility.
From the RFC, 5.10.1., we have:

The Uri-Path and Uri-Query Option can contain any character sequence.

So theoretically (unlikely but still) nothing prevent users from creating a resource path in a form of /some_resource/+/#, which with wildcard approach would lead to unexpected behaviour.
From my point of view, I think this change could be accepted, but as an optional extension configured with a Kconfig (something like CONFIG_COAP_URI_WILDCARD). We could use it in the sample, nothing against it.
Plus, it would be good to mention in the documentation (https://github.com/zephyrproject-rtos/zephyr/blob/master/doc/reference/networking/coap.rst#coap-server), that with this option enabled, resources can be created with wildcards, and how would it work.


Put NS file protection options in Realm.Configuration

Instead of the method described in the docs for dealing with accessing Realm in the background, it would be nice to be able to set the desired file protection key inside a Realm.Configuration and Realm would use that attribute.
How would I go about accomplishing that?

The only reasons I see against that is the selective availability on some Apple platforms and that this could cause confusion around the purpose whether it's actually thought for the OS-provided encryption or Realm's built-in encryption.
What are your thoughts? /c @jpsim @tgoyne

We had considered that previously, but decided against it to continue giving users full flexibility over how and when file protection attributes are applied. We've documented this in the Using Realm with Background App Refresh section of our docs.

I don't think this should be "idea backlog", given what JP said. Closing.


Redirect to base path of serverless-offline

@edis thanks for the useful project. This change makes sure the srvPath set in the config is removed when passed to the serverless-offline localhost. In the current state, requests are passed with addition path parts and hit the wrong URI.
Thanks!

Hey @jonathon-m , thanks for your interest in the project. I am using custom domain names in my AWS API Gateway, so when emulating I need the srvPath to be passed into the URL. However, I see where you're coming from with your changes, and I think that this should be a property in the sls-multi-gateways config file.

Thanks for the response @edis. I've added a commit which adds a stripBasePath option. This is non-breaking for anyone already using the package 😄

Great, thanks @jonathon-m. I merged the changes and re-published the package.

Fantastic! Thanks!


Proposal: Please close stale issues. Stalebot.

Prerequisites

[x] I have read the documentation;
[ ] In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.

Description
It seems like this repo has become pretty stale when it comes to open pull requests and issues.
I would like to propose that stale issues get closed. One tool that can help with that is https://github.com/probot/stale
In an ideal world with infinite resources, there would be no need for Stalebot.
But in any successful software project, there's always more work to do than people to do it. As more and more work piles up, it becomes paralyzing. Just making decisions about what work should and shouldn't get done can exhaust all available resources.
To some, a robot trying to close stale issues may seem inhospitable or offensive to contributors. But the alternative is to disrespect them by setting false expectations and implicitly ignoring their work. This app makes it explicit: if work is not progressing, then it's stale. A comment is all it takes to keep the conversation alive.

I don't really see this as correct. Just because an issue hasn't had activity doesn't mean it's stale. Sometimes it describes a real bug that will take a lot of effort to fix, and because of the minimal maintenance effort this library receives, may never be fixed. Some of the issues in this repo are stale, but I think this is too blunt of an approach to be helpful.


I have delited the project file and now the world maker's frickedout.

Hi,
@setPrimse i think you mean delete.
Well project_settings.tres tells world maker that a folder is a workspace for a project.
Temp Solution
Go to %APPDATA%\Godot\app_userdata\world_maker and delete the settings.tres it will reset the app.
It should fix the problem. If you have more than one project then you will just have to import those project.
This a bug in the app and will be fixed in the next update.
Also next time make sure to share you system info and how to recreate your problem. It helps alot.
Let me know if it fixes the problem

Yeap, it helped @mayank-prasoon.
Thanks.

Also next time make sure to share you system info and how to recreate your problem. It helps alot.

Manjaro gnome.
CPU: the shitty AMD FX-4300
GPU: AMD ATI Radeon R7 360 / R9 360 OEM
6gb ram.
I just manually delilted the folder...

Yeap, it helped @mayank-prasoon.
Thanks.

@mayank-prasoon good to hear.

Preventing loading folder without a project_settings.tres file should solve the problem.


Implement redirections

[x] < should redirect input.
[x] > should redirect output.
[x] << should be given a delimiter, then read the input until a line containing the delimiter (same as pipex here_doc)
[x] >> should redirect output in append mode.

Implemented here_doc


Adding additional notes for installing Go via Homebrew on Mac OS X

Signed-off-by: Jason Gegere<EMAIL_ADDRESS>

Coverage remained the same at 39.38% when pulling 805528925bdc2623ff3597888c36fe061aab92b4 on gegere:readme/update into 4fadc01ca911f5aa7ea16d703706eac71aab3423 on docker:master.

Thanks! :+1: If you ever forget to sign again, you can just amend your commit using git commit --amend -s --no-edit and force push to your branch. This saves you the hassle of closing and re-opening the PR :)

The line right after you changes sets GOPATH=~/gocode it feels like the 2 docs are conflicting, no ?

@vieux I have restructured the content based on your response. Does this look better?

Coverage remained the same at 39.33% when pulling f1cb97289219fe06dfc88e302cebb02b42058e82 on gegere:readme/update into c28b3a736c580a6641501898f90178f1f066ffa7 on docker:master.

LGTM
ping @SvenDowideit

LGTM - the one line should really be wrapped at 80 chars, @gegere

@gegere can you please fix  the 80 chars ?

@vieux sorry for my delay. Hopefully this is good.

Coverage remained the same at 39.07% when pulling b45518c14b5f80eb12a64fa98ab5f2c4ca95942a on gegere:readme/update into 758612896d7d2eb2ab1be6b68ce58679b5072052 on docker:master.


[PD]: GitHub shows a warning message!

Github shows GitHub no longer supports this web browser. Learn more about the prowsers we support.
This means that Station uses old versions of browser...

Fixed in 2.1.0


[eas-cli] Add EAS update properties that were removed from templates

Checklist

[ ] I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why
Certain properties used in EAS Update, that were previously included by default in Expo templates, were removed in https://github.com/expo/expo/pull/21126 .
This PR modifies eas update:configure to check for those properties in the Expo config, and add the correct default values if they are not present.
Test Plan
Tested with an app created with yarn create expo-app.

If assetBundlePatterns or fallbackToCacheTimeout are removed from app.json, eas update:configure adds them back.
If they are present, eas update:configure does not attempt to modify them.
Overwriting the correct update URL still works as before.

/changelog-entry [bug-fix] [Modify update:configure to add possibly missing EAS update config properties]

/changelog-entry bug-fix "Modify update:configure to add possibly missing EAS update config properties"


Send to Compliance

This adds a Compliance Settings menu item in the Wagtail admin to set a global email address to send notifications to Compliance with.  It also sends an email to compliance when a Project is approved, using the eamil address in this setting.

When a Compliance email hasn't been set this silently does nothing, should we do something a little louder about this?


CMS/Dynamic Sandbox V2.0

Description
This flow involves addressing the current problems with the sandbox and implementing Sandbox 2.0 with enhanced features. The key activities include:

Current Sandbox Problems:

Any new addition of domain/catalog involves generating example JSONs and redeployment.
Some code-level changes are required.
Responses are static.
Limited catalogues are available.

New Implementation of Sandbox 2.0:

Adding new domains/catalogs only requires the addition of the new catalog.
Minor code-level changes.
Responses are dynamic.
Unlimited catalogs—users can add as many catalogs as they want.

Solution for Sandbox 2.0:

Take a database dump from the dev database and restore it in the Strapi instance for Sandbox 2.0.
Implement mock automation for auto-confirmation, auto-arrival of the driver at the pickup location, auto-start, and end ride.
Create one instance for the Sandbox 2.0 environment.
Create a Postman collection.

Steps for Implementation:

Document the approach.
Make a list of all domains available in the sandbox that need to be created in Strapi.
Mock automation for status in <domain> for <this> & <this>.
Create a catalog.
Deploy to the BOC environment.

Additional Points:

Corresponding catalogs are required. If the catalogs are insufficient, additional catalogs need to be added. A baseline of 15 catalogs per use case should be established.
Corresponding Postman collections for each use case are needed and should work in the new sandbox.
List the steps on how the evaluation will be conducted.
Postman collections should be available in the new sandbox.
Corresponding issue tickets for this flow should be created.
Release notes should be added.

Example Use Cases Across Domains:

Retail: 1 use case.
EV: Multiple use cases.
Skilling: 4 use cases.

Goals

[ ] Implement Sandbox 2.0 with enhanced features.
[ ] Ensure dynamic responses and unlimited catalogs.
[ ] Document the approach and deployment process.
[ ] Create and deploy Postman collections for each use case.
[ ] Ensure catalogs meet the baseline of 15 per use case.
[ ] List evaluation steps and create corresponding issue tickets.
[ ] Add detailed release notes for Sandbox 2.0.

Expected Outcome

A fully functional Sandbox 2.0 with dynamic responses and the ability to handle unlimited catalogs.
All use cases across Retail, EV, and Skilling domains are documented and deployed with corresponding catalogs and Postman collections.
Comprehensive documentation, including release notes and evaluation steps, is available.

Acceptance Criteria

[ ] Sandbox 2.0 is implemented with dynamic responses and unlimited catalog capacity.
[ ] All required catalogs (15 per use case) are available in the new sandbox.
[ ] Postman collections are created and functional for each use case.
[ ] Deployment to the BOC environment is completed.
[ ] Documentation, including the approach, evaluation steps, and release notes, is finalized and available.
[ ] Corresponding issue tickets for this flow are created.

Mockups / Wireframes
NA
Product Name
Beckn
Domain
Beckn BPP
Tech Skills Needed
Node.js, Strapi, Database Management, API Development, Mock Automation, QA Testing
Complexity
High
Category
Development
Sub Category
Sandbox Environment Enhancement
Related Tickets
https://github.com/beckn/beckn-ui-workspace/issues/128
https://github.com/beckn/beckn-ui-workspace/issues/125
https://github.com/beckn/beckn-ui-workspace/issues/127
https://github.com/beckn/beckn-ui-workspace/issues/196
https://github.com/beckn/beckn-ui-workspace/issues/123
5 Cards are yet to convert from @shreyvishal side

@emmayank - Can you fill the missing below details and the current working status as comment.
Assignee
Flow status
Start Date
End Date
Labels
Category
Project
@viraj89 @faizmagic

@emmayank - Can you fill the missing below details and the current working status as comment.
Estimation Hrs
Priority
Start date and End date
@viraj89 @faizmagic

As discussed in today’s tech standup, versioning needs to be realigned with @faizmagic. Once he is back, we will review the details of Version 2.0.
@emmayank - Please share the status of the DHP Pharmacy and ODR migration from Static Sandbox, and provide a list of the remaining items along with the actual pending details. Additionally, include the plan for completion, specifying how many iterations are still needed to finish this task.
@faizmagic @viraj89 @vbabuEM

@emmayank - Please update the card.  If DHP Pharmacy and ODR are migrated from Static Sandbox to Dynamic Sandbox please close this card and open a new card by mentioning next set of planned migrating items/components.
@viraj89 @faizmagic

@emmayank - As we discussed, this card allocated resource is working on the P2P energy App Google Demo moving this card next iteration by changing the status as Floated. Next week we need to look for alternate resource to pick if not this is move further to next iteration.
@viraj89 @faizmagic


Speed-up lint/vet when using Docker

This switches it so that instead of calling docker once per file
it just calls it once and pass in the sh script that gets the list of files.
Note, the $(subst ...) call in there simply removes the "-t" (tty) flag since stdin on the container isn't a tty anymore. W/o this Docker will complain.
Signed-off-by: Doug Davis<EMAIL_ADDRESS>

LGTM

Adding lgtm3 label for morgan


Replace hard coded developer path from Building and Testing documentation with $GOPATH.

What does this PR do?
Fixes the docker run command shown in the public documentation for building and testing traefik.  It is currently hard coded as a specific user:path /home/ldez/sources/go/src/{site}/{user}/{repo}.
This commit updates the docker run command to use the environment variable $GOPATH instead.
Motivation
I am working on a bug fix related to traefik, and noticed I was not able to use the command from the documentation to build and test traefik, as the command for docker run contains hard coded values specific to a single user / machine. So I have updated to a more generic command that can be copied and pasted.
More

[ ] Added/updated tests
[X] Added/updated documentation

Additional note
The PR template stated that documentation updates should target v2.3. However that may need to be updated to v2.4 as the diff for v2.3 contained a lot of changes (as this PR is based from master ... I could re-create this basing it from v2.3 if needed?)...  As such I have targeted this PR against v2.4 so the diff only shows the alteration to docs/content/contributing/building-testing.md.
If this is an incorrect assumption, please let me know and I will update accordingly.

Hello,
it's just an output example of the command: in the really this the path is an absolute path and not a bash placeholder.


Conflicts with scrollview

Hi, First off, I love this library, and it works really fantastic.
One thing I seem to notice is that it conflicts with androids scrollview.
The slider would not show up if it is wrapped inside a scrollview.
Is there a possible work around for this?
Thank you

Hi,
i will have to look into that, but it should be possible.


Unable to restart HA for error after update HA to 2023.11.2

Unable to restart HA for this error:
Logger: homeassistant.components.websocket_api.http.connection
Source: components/websocket_api/commands.py:230
Integration: Home Assistant WebSocket API (documentation, issues)
First occurred: 10:40:06 (1 occurrences)
Last logged: 10:40:06
[140699251117760] Cannot quick reload all YAML configurations because the configuration is not valid: Platform error climate.airzonecloud - No module named 'homeassistant.util.temperature'
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 230, in handle_call_service
await hass.services.async_call(
File "/usr/src/homeassistant/homeassistant/core.py", line 2035, in async_call
response_data = await coro
^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/core.py", line 2072, in _execute_service
return await target(service_call)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 986, in admin_handler
await result
File "/usr/src/homeassistant/homeassistant/components/homeassistant/init.py", line 342, in async_handle_reload_all
raise HomeAssistantError(
homeassistant.exceptions.HomeAssistantError: Cannot quick reload all YAML configurations because the configuration is not valid: Platform error climate.airzonecloud - No module named 'homeassistant.util.temperature'

Same is happening to me.


Add accelerators to menu examples

"Accelerator" is the term GTK uses for keyboard shortcuts such as Ctrl+Q. The shortcuts get displayed for items in a menu, which seems to make these two examples the best for also demonstrating accelerators.

Looks good to me, thanks!
Waiting for confirmation from @EPashkin and @sdroege and then we're good to go!

@FreeFull Thanks
👍

If it works I guess it's fine, I don't know at all how this API is supposed to be used. If in doubt, ask some GTK people on IRC :)


Converted theme has the wrong colors (One Dark Pro Monokai Darker Reloaded Theme)

Describe the bug
The converted theme has the wrong colors compared to Visual Studio Code. Most of the tokens are colored differently and the brackets are colored instead of default white.
Screenshots

To Reproduce
Steps to reproduce the behavior:

Install the One Dark Pro Monokai Darker Reloaded Theme from the Marketplace in Visual Studio Code
Add the following lines inside "editor.tokenColorCustomizations" in settings.json in Visual Studio Code

        "[One Dark Pro Monokai Darker Reloaded]": {
            "textMateRules": [
                {
                    "scope": [
                        "storage.type.class",
                        "storage.type.struct",
                        "storage.type.modifier.access.control"
                    ],
                    "settings": {
                        "foreground": "#E06C75",
                        "fontStyle": ""
                    },
                },
                {
                    "scope": "keyword.control",
                    "settings": {
                        "foreground": "#BBBBBB"
                    },
                },
            ]
        },

Execute the steps provided on using the tool in the README.md

Expected behavior
The converted theme must have been colored in the exact same manner as the theme in Visual Studio Code
Environment:

Converter version: commit 3ade7dac81d5a0c2d3adeab64246780f91a7310d
VS version: 17.3.0 Preview 2
Theme used: One Dark Pro Monokai Darker Reloaded Theme

Impact
This demonstrates that the tool is converting but the resulting theme is not colored the same.

I have exactly same issue with Visual Assist Dark Theme. The converted theme has the wrong colors compared to Visual Studio Code.

I have the same problem with OneDarkPro.

I just wanted to note here that I was having the same issue, then the thought occurred to me that it might only work for C#.
I opened a C# project, and sure enough that was the case.
So I guess what this issue is, is please support the C++ keywords as well.

Okay, I took a look at the TokenMappings.json and I'll go ahead and add the Cpp* tokens. I don't use Resharper, so I'm not going to care about those.
 It works good enough for me to make a .vsix from my fork.

oh, I have the same issue, it looks different in visual studio compared to vscode when using cpp.  can it support cpp? please, i really love the dracula theme in vscode and i want to use it when editing cpp.

Same issue on c++ files, with the Railgun theme

Same issue on C++ file, C, xml, xaml and razor file with Cyberpunk 2077 theme.

Following DavidBChristensen's guide, I have succeeded in making it work for C++. But can anyone tell me how to get the VS Token like him ?? I would like to get all the VS token for all the language to further develop my theme. Many thanks!

Can we get some activity on this? Lots of C++ developers out here stuck using VS2022 (against our will) for work and would really like at least the visual comforts of VS Code whilst we use our bloated IDE from 2008.
@DavidBChristensen maybe you can open a PR if you've figured out all the correct mappings? And perhaps you could reply to @Dangcaominh about how you found those mappings?

Sure, I'll make a PR for what I've got.
Unfortunately, I can't remember where I got those tokens from. I'll take a look later to see if I can "re-discover" that.

Sure, I'll make a PR for what I've got. Unfortunately, I can't remember where I got those tokens from. I'll take a look later to see if I can "re-discover" that.

There's some in TokenMappings.json, but definitely not the entire list you posted. I spent 3 hours manually copying hex color codes into that block since Microsoft doesn't care about C++ anymore 😭


config file $distributionName variable definition

Hi,
where do you define $distributionName variable. for example in yml file.
distributions:
  app:
    artifacts:
      - path: path/to//{{**distributionName**}}-{{projectVersion}}.zip

The value of {{distributionName}} resolves from the containing distribution, in this case it would resolve to app. https://jreleaser.org/guide/latest/configuration/name-templates.html#_distribution


Align and change color in Start Menu icon

I'm not sure if this is a bug or a feature request, but I thought I should bring up this here.
When fixing VScode shortcut in Start Menu (Windows 10), the icon doesn't seem to be correctly aligned. That can be seen comparing with Visual Studio 2017 icon, for example:

Also, I have been using a blue tone in Windows theme for some time, when I installed/updated (don't remember exactly) VScode, which was using almost the same tone:

A suggestion would be to use a theme-independent icon, likewise Visual Studio 2017 icon, at the left.
Windows color I was using:

VSCode version: 1.27.2
Windows version: 1803

/cc @joaomoreno since you are more familiar with Windows. I thought we have icons of the same size as VS, but why are they smaller and showing up so low to the frame?

theme-independent icon, likewise Visual Studio 2017 icon, at the left.

If you make the tone purple, VS icon will be buried in the background color, correct? It seems there is no way to completely fix this.

I see, maybe we didn't specify a bg color so the system falls back to the "tone" you are using, which might bury our icon.

@diogoan can you provide more info on how you're setting the tile colors and if you're using any windows customizations? I'm also using Win10 1803 and am not able to repro:

@misolori I'm using vscode 1.27.2 on Win10 1803 too. I reinstalled vscode just to check how to reproduce and I'm not seeing the wrong icon/background again. Maybe that was corrected in a previous release?

I was using just an icon pack extension, but even installing it again, the icon is normal.
Thanks for the patience, if it happens again, I'll try to find what can be causing to bring here.


chore(live-announcer): remove TestComponentBuilder

R: @DevVersion

LGTM.

Seems like Browserstack errored, but it seems to be unrelated and probably due to some flakiness


[Finishes #137645995] mentions should work with spaces or allow scrolling of returned users

https://www.pivotaltracker.com/story/show/137645995

One thing I noticed is by removing the whole mousewheel thing, it now scrolls a lot better. I don't know why we would try to hijack mousewheel instead of letting the browser handle it! I'll try to test it on different browser with a real mouse

fixed in https://github.com/townsquared/simditor-mention/pull/9


Unable to hit service

The service I'm trying to hit is the argocd-server as deployed via this walkthrough. I am able to hit the service without issue when running the following: kubectl port-forward svc/argocd-server -n argocd 8080:443 . This is found under Step 3 in the above link.
I was able to configure my k3d cluster within kube-forwarder without issue. I went to add the service in question with the following details.
Namespace: argocd
Kind: service
Name: argocd-server
Ports Forwarding: Local - 8080 Resource - 443
I attempt to hit https://localhost:8080, but it times out.

Hi @streetmapp, Thank you for the report. It looks like it has the same reason as https://github.com/pixel-point/kube-forwarder/issues/17 (Because Kube Forwarder doesn't map service ports)
If it is fixed by #17 patch in the next release, great! Otherwise, I will investigate it.

Hi, @streetmapp! We've just released a new version, could you, please, check it?

Hi @proAlexandr, thanks for the quick turnaround on this. Just grabbed the latest and tested and it's working with the use case that I was having issues with before. This appears to have solved the problem!
Thanks again.


clean test-requirements

Remove pytest-mock from test-requirements.txt and adapt corresponding tests;
Add generator type check in generator_tester function in helper.py;
Pass name_value_pair=True explicitly in NamedEnumMeta's _as_data_type function

Codecov Report

Merging #45 into dev will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines          163       163
=========================================
  Hits           163       163

Impacted Files
Coverage Δ

named_enum/__init__.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21fc4d0...ec80068. Read the comment docs.


I have Changed the CSS

Issue it solved
I was not working on any issue as such but I have changed the website UI. I mainly changed the CSS portion, now the website looks way more professional.
Which files you changed?
backgroundgen.css
I have edited the CSS code which was earlier available. Few of the main things which I have worked on are the :

Font style and text widths
Component backgrounds
Hover effects like on button
Shadow on button
Bottom Github Image

Screenshots
![Uploading Screenshot 2022-10-01 at 7.40.13 PM.png…]( After My Changes )

I think the Image has not been uploaded, this https://ibb.co/BcRFG7Q is the final UI I have created.

@Nirbhayparmar @Jimmy-Taravia2001 @MahmmadhusenDodiya @lovelacecoding please review this

I like the changes you have done as seen from the given image, can you also send screenshot of this site on smaller screen layout to check how it is looking in smaller screens?

I have actually not made the changes responsive till now, but since you asked - I will start working on that now.

This is the current responsive design for small mobile devices. There are a few more changes that can be made like replacing the radio buttons with manual CSS buttons for the UI to look even better.

Can you make radio buttons in one column(in same verticle line) to make it more readable?

@Nirbhayparmar I have now made the radio buttons in one column, please merge this code.


fixed crash on iOS12 and added dismiss handler

Fix crash on iOS 12 by providing missing initializer in navigation controller - https://github.com/joomcode/BottomSheet/issues/18
Additionally, provide dismiss handler

I've implemented your proposal in release 2.0.3, so I'm closing this PR
Thank you for contribution 🚀


Schema out of date

It may be just this page and just the element I was looking at (EndpointCertificate) but the schema does not match other documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e87c6785-d344-31f1-a86d-d806e7ce4c1a
Version Independent ID: 15f925f2-6e14-fe8b-e582-2663bccb132d
Content: Azure Service Fabric service model XML schema complex types - Azure Service Fabric
Content Source: articles/service-fabric/service-fabric-service-model-schema-complex-types.md
Service: service-fabric
GitHub Login: @athinanthny
Microsoft Alias: atsenthi

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. Though the scope of our feedback channel here on GitHub covers specific documentation fixes, we can help redirect you to the right support channel to get an answer to your question: [reference to alternative product/service or community endpoint]. Because this issue does not relate to documentation, we are closing this issue. #please-close


Refactor test for internal integration tests

What changed?

Export integration test suite definitions
Allow specifying schema dir when setting up nosql test cluster

Why?

For internal integration tests

How did you test it?

Integration tests

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 8cbe1d07-0d41-40d2-9a5e-58f54fd6d68e

29 of 32 (90.63%)  changed or added relevant lines in 5 files are covered.
12 unchanged lines in 5 files lost coverage.
Overall coverage increased (+0.02%) to 56.345%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

common/persistence/persistence-tests/persistenceTestBase.go
0
1
0.0%

common/persistence/nosql/nosqlplugin/cassandra/admin.go
6
8
75.0%

Files with Coverage Reduction
New Missed Lines
%

common/task/weightedRoundRobinTaskScheduler.go
1
88.6%

common/task/fifoTaskScheduler.go
2
84.54%

service/history/execution/mutable_state_builder.go
2
69.9%

common/cache/lru.go
3
90.73%

service/history/task/transfer_standby_task_executor.go
4
90.4%

Totals

Change from base Build b4be510f-3fff-4fe3-ba33-339c8ab6bf62:
0.02%

Covered Lines:
79184

Relevant Lines:
140534

💛  - Coveralls


🌐 Update Chinese translation for docs/tutorial/security/oauth2-jwt.md

as title

Great, thank you @jaystone776! :rocket:
And thanks for the reviews @mkdir700 and @zy7y :bow:


OnDone Issue

OnDone doesn't get triggered, and if i make this method as a stream, it doesn't get canceled
return "Stream has been already set"

Hi there,
the stream is never done, when you call the stopScan method there are no more elements being scanned and therefore pushed into the stream

How can i send a data to bluetooth device?
Example: 55 AA 00 02 23 00 30 19

call initPermissions to check if you have the right permissions to use this plugin
if you are already paired to the device, find it with getPairedDevices
if not, you can call startScan to start scanning (I know, who'd have guessed, right ?) and listen to the onDeviceDiscovered to get the devices as they come in
when done with scanning, you can call stopScan
connect to the device using the connect function providing the device mac address and the UUID of the service you want to connect to (serial, for example)
you can check the connection status on the onDeviceStatusChange stream
once connected, you can use the write function passing in the message you want to send


Fix for #2730. Add CRLDP extension to list of supported extensions

Checklist
Description of change
Fixes #2730. Tracked it down to the extension missing from the list in X509_supported_extension().
I've not added a test, as this would require an always-accessible http address for the CRL download. I have manually tested using generated PKI and a CRL on an internal web server.

248cf95 for 1.0.2; e1d2ea3 for 1.1.0;  e6f648f for master.
thanks!


overlapblock Creator - Web design #13

https://images01.nicepagecdn.com/page/65/76/html-template-65764.jpg Design a overlapblock like the above image
Create a file "overlapblock_NUM_by_(YourName).html" in the modules/overlapblock folder.
Use simple HTML and CSS and JAVASCRIPT to create the overlapblock animation. You can use the interface development https://kwickerhub.com/ (This project) or you can write the lines of code yourself.
Step by Step Guide.
Fork this project(Use the 'fork' button in the top right corner) and Clone your Fork.
git clone https://github.com/YOUR_USERNAME/frontend
Open your code Editor and Create a file "overlapblock_NUM_YOUR_NAME_.html" in the "modules/overlapblock" folder of this project you just cloned. No need to create head, title and body tags, Just Add a div tag with some embedded style(i.e use the style tag) and the script tag where necessary.
If you want to add an image resource, please add it in the folder ••
"modules/overlapblock/images_and_icons"
We recommend you use an svg for your image/icon.
Push your Code: You need to push your recent changes back to the cloud. Use the command below in the main directory of this Repository
git push origin dev
or use a GUI tool to avoid mistakes or complexity. LOL.
Then make you Pull Request...
Below is a example of the code structure we need:
'''

'''
For more examples:
modules->buttons
modules->cards
for examples of contributions or Pull request accepted in to the project.
And please do not wait for this issue to be assigned to you as we have limited hands but have a lot to do/cover. Please send in your PR.
Good-luck.

@nicholasboyce i will be working on this issue


Adjust misformatted Quota balance calculation process log

Description
Fixes a misformatted log in the Quota balance calculation process.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI
[ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity
Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[X] Trivial

How Has This Been Tested?
Before:
2024-11-05 12:40:32,643 INFO  [cloudstack.quota.QuotaManagerImpl_EnhancerByCloudStack_281d8029] (Usage-Job-1:[]) (logid:) Processing quota balance for account[{}] between [{}] and [{}].

After:
2024-11-05 12:40:38,903 INFO  [cloudstack.quota.QuotaManagerImpl_EnhancerByCloudStack_281d8029] (Usage-Job-1:[]) (logid:) Processing quota balance for account [{"accountName":"system","domainId":1,"id":1,"uuid":"60b8ca5a-28b2-11ef-a04e-6ac09c2b3d6b"}] between [2024-11-05T00:13:00.000+0000] and [2024-11-05T12:39:59.000+0000].

@blueorangutan package

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 11506

compiles, ship it ;)
But seriously, I am not sure if this is covered by any tests...

compiles, ship it ;)
But seriously, I am not sure if this is covered by any tests...

@DaanHoogland I think that for a change like this there isn't much to test. The CI should suffice, no?

compiles, ship it ;)
But seriously, I am not sure if this is covered by any tests...

@DaanHoogland I think that for a change like this there isn't much to test. The CI should suffice, no?

You are absolutely right @JoaoJandre, and looking back at the code I am not sure if we need even that.


channels and inputs not appearing

Appeared as a TV in homekit instantly, on/off works and apple remote works, but no channel/input selection just says On On On along the top of the panel for the TV.

Just force close the apple home app and reopen should fix it


Fix agent port configuration

Issue:
I'm using this docker image with swarm-plugin, and I'm having some connection issues between them.
The Swarm Plugin always disconnects after a Jenkins restart, even when the retry flags are set.
After investigating this, I've seen that the agent port number is first set to a random value and then the groovy script changes to the desired value in this image. Jenkins is started before this script execution, and when the plugin connects to ${JENKINS_URL}/tcpSlaveAgentListener/ the Jenkins server returns the random port in X-Jenkins-JNLP-Port and X-Hudson-JNLP-Port headers, what causes the problem.
What this PR does:
This PR sets the agent port using system properties, that set the right value since the start.
Approach:
If the environment variable JENKINS_SLAVE_AGENT_PORT is set and has some value, then the jenkins.sh script will add it as the value of jenkins.model.Jenkins.slaveAgentPort property in java options.
jenkins.sh script will only add the jenkins.model.Jenkins.slaveAgentPort property to JAVA_OPTS if it is not already added.
This PR also removes the init.groovy script because with this approach it won't be needed anymore.
Notes
If someone has any concerns or suggestions about this, please comment.

For now, I'm checking if the property jenkins.model.Jenkins.slaveAgentPort is passed from JAVA_OPTS.

Should I update README with this behavior?

please

Readme updated

Readme updated. Also, Is it possible to add this to the next release?


timedoctor-desktop: init at 3.12.16

Description of changes
Readded a package for Time Doctor Classic. I need this thing for my job and it's been working so far so I might as well upstream it :)
Besides Time Doctor Classic there's also Time Doctor 2. The difference in packaging is that TD2 uses this weird makeself script to install and then patchelf(!!) itself. I couldn't figure out how to get this working so if someone could take a look at it, it would be great. I even emailed its developers to consider making an AppImage release and apparently it was noted.
While this software might be considered spyware, it's sadly actually quite popular even while "free"lancing so it would definitely be useful for some folks if both versions were available in nixpkgs.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

LGTM, Compiles and Runs

tbh I'll close it as it's using an ancient electron etc. looking at how quickly things get resolved in the recent libvpx/libwebp incidents - this package is quite pathetic in this regard


Testing, please ignore. (rcelru)

Bug bounty test - please ignore.... Please DO NOT APPROVE THIS! (rcelru)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.juaquinlarendo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Connecting Frontend to Backend

I couldn't find any information on how to connecting frontend (button clicks) to backend. Let's say I have a button like this:
<w type="button" class="btn ml-3">Start Application</w>

How can I add click event to the xml file and program it in C?
Thanks

Here are the steps:

Add id attribute to xml element
Call LCUIWidget_GetById() to get the widget
Call Widget_BindEvent() to bind the click event of the widget

Examples for reference:
https://github.com/lc-soft/LCUI/blob/ea409f1339580c2f5267597a134c0a8c17d1e5e5/test/helloworld.c#L1-L33
https://github.com/lc-soft/LCUI/blob/ea409f1339580c2f5267597a134c0a8c17d1e5e5/test/helloworld.xml#L1-L11

Worked like charm!


LazyList issue in Title Casing lambda

I have this code:
λW`A`•;ð/

This code should take a string, split it by spaces, and capitalize each word. Instead, this error occurs:
Traceback (most recent call last):
  File "/home/Vyxal/mysite/vyxal/main.py", line 147, in execute_vyxal
    exec(code, locals() | globals())
  File "<string>", line 30, in <module>
  File "/home/Vyxal/mysite/vyxal/elements.py", line 725, in divide
    return {
  File "/home/Vyxal/mysite/vyxal/elements.py", line 732, in <lambda>
    }.get(ts, lambda: vectorise(divide, lhs, rhs, ctx=ctx))()
  File "/home/Vyxal/mysite/vyxal/elements.py", line 3596, in vectorise
    ts = primitive_type(lhs), primitive_type(rhs)
  File "/home/Vyxal/mysite/vyxal/helpers.py", line 541, in primitive_type
    assert type(item) in [list, LazyList]
AssertionError

Note: I am testing this with the input hello world.
Note: I am testing this code on this site.

I pretty much just assumed that this was a LazyList issue when I saw assert type(item) in the traceroute, so this is my bad. The error is actually happening because / doesn't have an overload for functions.


Create error and block state for card list views

See https://github.com/SUSE/stratos/pull/196 && #29

This issue was moved to cloudfoundry-incubator/stratos#1458


🐛 fix: merging of two similarly keyed mappings

Overview
This sets out to fix issue #10.  We found that merging two sources with similar mappings would cause the destruction of the mapping from the previously processed source. The use case we found this in was having a config with some secret values, then populating just the secret values from a secure store.
Specifics

Add deepmerge package to handle merging of two mappings properly
Add some additional typing for added type safety
Fix a test that would fail due to vscode using TEST_ environment variables for it's test runner

Hi @StummeJ
I apologize for replying so late, I appreciate this very much and I am willing to merge and release a new package with this feature.


demo_ntsc.nes tests don't run

scroll.nes and demo_ntsc.nes tests don't  run. I guess NMI/vblank issue?

scroll.nes runs now with #61. But demo_ntsc.nes doesn't run yet.


implicit async

Implements implicit async for functions, arrow functions, and methods.
Half of https://github.com/DanielXMoore/Civet/issues/427

@edemaine This is almost ready but I need some help figuring out the JSX async method handling.

I figured it out, it's ready to go now.


Add ability to specify durability for transactions in Chrome

Implementing step 1 as described in this issue
This PR updates dexie so that we can pass a chromeTransactionDurability when constructing a Dexie instance to drill down into any transactions that are used when interacting with it. This is a special flag that was added by Chrome per this feature (source code for the change is here). For other browsers (or versions of Chrome older than 83) it will have no impact.
I've added tests to check that the raw IDBTransaction has the desired state based on what is passed, and have also used the npm link strategy to verify that there's a performance boost to our app when using the modified Dexie code. We wrote a simple test that inserted blobs into a table in a loop, under three scenarios:

Using Dexie.Table
Using raw IDBTransaction with { durability: 'relaxed' }
Using raw IDBTransaction with { durability: 'default' }

Before the change, the timings for 1) and 3) aligned, with 2) being about twice as fast. Linking the changes in this PR, the timings for 1) reduced in-line with 2). Happy to share the source code for the test we ran if it's of any interest.

Thanks! I couldn't get the same performance benefits when I tested this out earlier. Probably depends a lot about the use case. Not sure that changing the default is ok in a minor version so for 3.x we could allow the option in Dexie constructor but keep the default durability and plan to change the default for next major (4.x).

Thanks! I couldn't get the same performance benefits when I tested this out earlier. Probably depends a lot about the use case. Not sure that changing the default is ok in a minor version so for 3.x we could allow the option in Dexie constructor but keep the default durability and plan to change the default for next major (4.x).

Yeah that makes sense - I guess I was hoping to get away with the lazy option :stuck_out_tongue:
I'll look at plumbing the durability properly so it's configurable. Also, looks like tests are failing because they get run on multiple browsers (so my new tests fails on Firefox for instance - see here). Is there an established pattern for having tests run only on certain browsers that I can follow to get this passing?

Updated to plumb as a DexieOption - also renamed to chromeTransactionDurability so it's super clear it's a Chrome-specific thing.
I also extracted a separate test file for this stuff since I need to construct a Dexie db per test with different options. Still got the outstanding question of how to skip these tests for non-chrome so we can get the Travis build to pass, otherwise I think this is ready for review/release in a minor 3.x version :crossed_fingers:

Great! There is a supports() function in dexie-unittest-itils.js that you could extend. It's also ok to do user-agent sniffing here. If the browser doesn't support the feature, let the test succeed with ok(true, description).

Ah nice! I've put in an isChrome var which seems to work for me. It detects newer versions of Edge, too - but that's fine since it's basically the same browser these days (it's just reskinned chrome, so the tests will pass there I imagine).

Is there anything else you need from me on this? Would be awesome to get it merged and released if possible so we can see the impact it has on our users (if this doesn't provide a sufficient enough performance boost, the sooner we find out the sooner we can do more investigation / look into other avenues) :crossed_fingers:

Currently it's just the comment I made about the variable isChrome not working (which basically makes it not trying your tests on chrome either).

I thought I commented with a jsfiddle link but can't find it now. Anyway, I've tried the isChrome variable in a fiddle and it evaluated to false on all browsers.

Ah interesting - yeah, for me locally in chrome it was skipping the tests too it turns out. It's odd - I tested the flag using chrome dev tools and it worked in there :shrug:
I've simplified the flag and it seems to be working now :+1:

Thanks! It's merged.

Thanks! It's merged.

Fantastic! Thanks for your help and super speedy responses - this has been an excellent contribution experience from my perspective :grin:
Any idea when a new release might be published? Excited to get this out into the wild so we can see how it affects our metrics in production :drooling_face:

Happy to hear that 👍
I will start the release-script this afternoon. It does some additional tests on complementary browsers but unless any script fails, it would be out soon.

Sorry, the release-script failed on a regression test on Chrome 79 (listed in our config file as "chrome_oldest_supported"). Obviously, it's a chrome but probably without the support for this option. Either, we could update the chrome_oldest_supported to a version that has support for this option, or we could extend the test condition to also verify chrome version (could be extracted using a regexp on navigator.userAgent). Another option would be to allow undefined as a valid value of trans.idbtrans.durability (as it would only be set to "default" or "relaxed" if it's a chrome that supports it)

Is it ok if I fix it by allowing trans.idbtrans.durability to be undefined in all three tests?

Is it ok if I fix it by allowing trans.idbtrans.durability to be undefined in all three tests?

Yep, sounds good!

It's released. If you'd get inspiration to update the docs for Dexie constructor (https://dexie.org/docs/Dexie/Dexie) that would be a nice thing. If not, that's ok also and we try make sure fixing it later. The current doc is stone-age old with clumsy HTML table. It's ok to update it to a markdown table if you have that inspiration.

It's released. If you'd get inspiration to update the docs for Dexie constructor (https://dexie.org/docs/Dexie/Dexie) that would be a nice thing. If not, that's ok also and we try make sure fixing it later. The current doc is stone-age old with clumsy HTML table. It's ok to update it to a markdown table if you have that inspiration. (Use the "Edit on github" button to edit the page and it will generate a PR)

Thanks so much! Updating some docs feels like the least I can do - I'll aim to get to it at some point this afternoon :smile:


Colorful chats, .env for api key, .gitignore updated, and python requirements.txt

Just some Qol stuff since i want to get deeper into this.
Example of how chats now look:

This is putting a lot of stuff in the root of the repo. Please move it to the correct subfolders and resubmit.

Have you used poetry before? I use it on production projects, very nice tool.
https://python-poetry.org/docs/basic-usage/#project-setup

Please update the scope of this PR or it will be closed soon. We need to reduce noise.

PR still has conflicts. Will close tomorrow if it is not updated.


carousel on about us

@roseja how are doing with the carousel here? i see you have made good progress with a library.
if you need help please feel free to reach out to @sunshine1004-dev. he can definitely answer any questions and render help if needed! thank you so muchh


Application Deployment

Description:
• Deployment of the Capstone Management System codebase to the server.
• Setup of the web server to serve the application and manage traffic.
Definition of done:
The latest stable version of the application deployed to the production server and accessible via a secure connection.

A great issue with good "definition of done".

since there is no initial version of the application that can be deployed i am closing this issue.


Add download method for PCMPlayer class

Would it be possible to add a .download() method on PCMPlayer? Since it's raw PCM data, I'd like to download a .wav or .pcm file that is ready to be read with VLC or another media player directly. I thought since you already added the corresponding Header for the web version to work, can you implement the .download() method or guide me a little so i can do it myself (I don't have knowledge on audio data i might do wrong things). Thanks

Would it be possible to add a .download() method on PCMPlayer? Since it's raw PCM data, I'd like to download a .wav or .pcm file that is ready to be read with VLC or another media player directly. I thought since you already added the corresponding Header for the web version to work, can you implement the .download() method or guide me a little so i can do it myself (I don't have knowledge on audio data i might do wrong things). Thanks

if you just want to download file, direct download the file may be the better way download file from url and you don't need to play it :D


support for new manifest.json properties

keepConfigAfterMapSwitched, hasVersionManager and supportMultiInstance need to be added to the features list

thanks @jPurush - what version of WAB did these get introduced in? 2.0beta, or earlier?

keepConfigAfterMapSwithched(this is the spelling in WAB) and hasVersionManager is available from WAB 1.0, supportMultiInstance is available from WAB 1.3

Interesting. I've never heard of any of these. I don't know how their used, so it's hard to say whether it's worth adding them to the widget options prompt, what we should use as defaults, and what other impacts (if any) they would have other than setting manifest.json props.
Do you know? Have you ever used them in an app?

Closing this for now, as there has been no interest in these properties in 1.5 years. Developers can manually add if they need these (https://developers.arcgis.com/web-appbuilder/guide/widget-manifest.htm), and we can re-open this if anyone has any particular interest in these manifest properties.


Move all notification nspecs to package local services file

Add localNotificationSettings nspec

If I recall correctly, @mcarcaso told me that doing this in foam breaks the foam build script/tool. Apparently it's only the nanopay build script that looks in subdirectories for now. I haven't tested this myself though, and I guess we could always just improve the foam build tool, but I thought I'd mention it.

Good to know, but I don't think anybody is building FOAM alone anyway, and
if that is broken, then we should fix it. Can you assign a low-priority
ticket to Eric to test/fix?
On Wed, 8 Jan 2020 at 10:04, Troy Wolters<EMAIL_ADDRESS>wrote:

If I recall correctly, @mcarcaso https://github.com/mcarcaso told me
that doing this in foam breaks the foam build script/tool. Apparently it's
only the nanopay build script that looks in subdirectories for now. I
haven't tested this myself though, and I guess we could always just improve
the foam build tool, but I thought I'd mention it.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/foam-framework/foam2/pull/2945?email_source=notifications&email_token=ABY5PM3NKWZRWALMZDT7RSDQ4XTO3A5CNFSM4KEJTIL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIM3IDI#issuecomment-572109837,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABY5PM6CWQHQOYYOW7VBNPTQ4XTO3ANCNFSM4KEJTILQ
.

Good to know, but I don't think anybody is building FOAM alone anyway, and if that is broken, then we should fix it. Can you assign a low-priority ticket to Eric to test/fix?

@kgrgreer will do.

https://nanopay.atlassian.net/browse/CPF-3954

Sorry I don’t really recall this but before I lost access to your repo you
were also using the JS build tool to bundle your app into a single payload.
If that still works then you should be good here. I can’t think of why this
change would break that off the top of my head but anything is possible.
On Wed, Jan 8, 2020 at 7:45 AM Troy Wolters<EMAIL_ADDRESS>wrote:

https://nanopay.atlassian.net/browse/CPF-3954
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/foam-framework/foam2/pull/2945?email_source=notifications&email_token=AB53ESB3ED2IVSYAR2XP5JTQ4XYHXA5CNFSM4KEJTIL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIM7ZAA#issuecomment-572128384,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB53ESG2AYBZWNTN2EJZRBTQ4XYHXANCNFSM4KEJTILQ
.


Does not seem to work with AWS elasticsearch service.

Set up is 3 master only nodes and 3 data only nodes.  I point the plugin from an external server to the aws provided endpoint, and see nothing but 0s (besides node counts) in newrelic.  Doing some debugging, it looks like issue might be in self.process_tree.
I was just targetting my docs count for the first iteration of troubleshooting.  Added some print statements where it collects and processes totals.
def add_datapoints(self, stats):
    """Add all of the datapoints for the Elasticsearch poll

    :param dict stats: The stats to process for the values

    """
    totals = dict()
    for node in stats.get('nodes'):
        for key in stats['nodes'][node].keys():
            if isinstance(stats['nodes'][node][key], dict):
                if 'indices' in key:
                    print("Node: {} -- {}".format(node,stats['nodes'][node][key]['docs']))
                if key not in totals:
                    totals[key] = dict()
                self.process_tree(totals[key],
                                  stats['nodes'][node][key])
    print("Totals: {}".format(totals['indices']['docs']))
    self.add_index_datapoints(totals)
    self.add_network_datapoints(totals)
    self.add_cluster_stats()

And this was the output:
Node: EcjXe8h5QWKXLS2yJqzYfQ -- {u'count': 0, u'deleted': 0}
Node: FACOCJD5SGq-e9T2VkVVAA -- {u'count': 3435012, u'deleted': 0}
Node: 2_VhugKyS4-6bxFxDDg9sg -- {u'count': 0, u'deleted': 0}
Node: HJEkvBT5RZuimmF-hshzxw -- {u'count': 0, u'deleted': 0}
Node: 43CBh1mfTMaYZJBblyQOcw -- {u'count': 1374226, u'deleted': 0}
Node: g8AKrsLgSlGO5GUpCwhcZg -- {u'count': 2060786, u'deleted': 0}
Totals: {u'count': 0, u'deleted': 0}
As you can see there are the 6 nodes mentioned earlier.  All 3 data nodes indicate docs are present.  After all the processing is done, it totals the docs to 0.  Will do some more investigating, but wanted to share.

Related to https://github.com/MeetMe/newrelic-plugin-agent/issues/263.  Closing


STGMEDIUM is invalid under the new interface generation

My usual test for COM interop is to implement IDataObject, put it on the clipboard, and retrieve some data. I'm getting nowhere with this, STGMEDIUM is incompatible with the classic marshaler and the runtime will fail interop calls.
incomplete example code
static class Program
{
    [STAThread]
    static void Main()
    {
        Application.OleRequired();
        PInvoke.OleSetClipboard(new CustomDataObject());
        Clipboard.GetData("Foo");
    }
}

class CustomDataObject : IDataObject
{
    public const int E_FAIL = -2147467259;

    public unsafe void GetData(FORMATETC* pformatetcIn, out STGMEDIUM pmedium)
    {
        throw new NotImplementedException();
    }

    public unsafe void GetDataHere(FORMATETC* pformatetc, ref STGMEDIUM pmedium)
    {
        throw new NotImplementedException();
    }

    public unsafe void QueryGetData(FORMATETC* pformatetc)
    {
        throw new NotImplementedException();
    }

    public unsafe void GetCanonicalFormatEtc(FORMATETC* pformatectIn, FORMATETC* pformatetcOut)
    {
        throw new NotImplementedException();
    }

    public unsafe void SetData(FORMATETC* pformatetc, in STGMEDIUM pmedium, BOOL fRelease)
    {
        throw new NotImplementedException();
    }

    public unsafe void EnumFormatEtc(uint dwDirection, out IEnumFORMATETC ppenumFormatEtc)
    {
        if ((DATADIR)dwDirection == DATADIR.DATADIR_GET)
        {
            FORMATETC fmt = default;
            fmt.cfFormat = (ushort)DataFormats.GetFormat("Foo").Id;
            fmt.dwAspect = (uint)DVASPECT.DVASPECT_CONTENT;
            fmt.lindex = -1;
            fmt.ptd = null;
            fmt.tymed = (uint)TYMED.TYMED_HGLOBAL;

            if (PInvoke.SHCreateStdEnumFmtEtc(1, &fmt, out var enumerator).Succeeded)
            {
                ppenumFormatEtc = enumerator;
                return;
            }
        }

        throw Marshal.GetExceptionForHR(E_FAIL);
    }

    public unsafe void DAdvise(FORMATETC* pformatetc, uint advf, IAdviseSink pAdvSink, uint* pdwConnection)
    {
        throw new NotImplementedException();
    }

    public void DUnadvise(uint dwConnection)
    {
        throw new NotImplementedException();
    }

    public void EnumDAdvise(out IEnumSTATDATA ppenumAdvise)
    {
        throw new NotImplementedException();
    }
}

Since this failed before I could write a complete test scenario my test code does not implement IDataObject sufficiently enough to actually retrieve data, .NET will fail before entering either GetData or GetDataHere. You can see one of the exceptions if you enable first chance exception and run above code:

System.TypeLoadException: 'Could not load type '_Anonymous_e__Union' from assembly 'WinFormsApp1, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' because it contains an object field at offset 0 that is incorrectly aligned or overlapped by a non-object field.'

Given the title of your issue, did this work with an older version?

Well, when using structs you weren't calling into the classic marshaler, so the STGMEDIUM was valid. Obviously with the old struct-based approach you couldn't implement IDataObject but you could call IDataObject and provide your own STGMEDIUM. I didn't test it, but it should have worked, considering there was no marshaling going on, just pointers to structs.
The problem is that you are now putting a marshaled .NET object into a union, which is something the classic marshaler doesn't allow (since it doesn't know when the union field is a reference to a .NET object and when its a plain value)
Other unions like VARIANT probably have the same problem now. There might be some more unions with COM interfaces in them.

BTW you can turn off interface generation using the NativeMethods.json file to get the old behavior back.

Yeah I noticed that but couldn't figure out what the option is. My Visual Studio is also terribly unhappy about something in the generator and throws several "gold bar" errors per minute once I start using the generator, so if the json schema is supposed to provide intellisense VS is probably too broken to deliver it at the moment.
Anyways, as far as unions go, its not easy to fix. C is a language which only has dumb unions and the context for the union is provided outside in a containing struct or as a separate parameter (if the union is a function call parameter). This means the projection can either also be dumb, not projecting COM interfaces inside unions, using pointers instead and leave union handling and unpacking COM references to the caller; or it needs additional information to properly project unions, namely the context to disambiguate the union.
When doing handwritten projections I usually lift the union API into its containing struct/class where the disambuation field is available, this typically matches the API just fine since often these are nested unions anyways which aren't supposed to be used as standalone types in the first place.
It would probably be worth to do a study over the metadata package to see if all unions in the package have disambiguation information available in their direct usage site, and if not, classify the cases where the disambiguation data comes from somewhere else.
If its always available in the direct usage site it would be worth adding metadata to the metadata package to describe how the container is disambiguating unions, allowing projections to generate higher quality APIs for unions.

if the json schema is supposed to provide intellisense VS is probably too broken to deliver it at the moment.

It is, if you have the $schema property defined as explained in the readme.
There is a top-level property called allowMarshaling which you can set to false to go back to the old mode.

Is there any update on this issue? I would like to be able to pass nulls at least.

I haven't had a chance yet to circle back and improve the COM interface generation. The workaround I prescribe above still applies though.

The workaround I prescribe above still applies though.

I went with a C++/WinRT app instead. As a beginner, it was easier to switch to C++ than turning off interface generation.
Maybe I'll come back to C# when I know a bit more about COM.


idle miss and no miss

What feature do you want to get added on the base engine?
idk why it was removed btw if this isn't accepted thats okay i love how psych engine is cool

Duplicate of https://github.com/ShadowMario/FNF-PsychEngine/issues/2114
I didn't wanted to implement the idea so i closed the first issue.

Duplicate of #2114 I didn't wanted to implement the idea so i closed the first issue.

ohh okay sorry i didn't know those things could be closed im new to github


Passive STS metadata.xml contains hard coded URL values.

In a scenario which a hostname is changed, a proxy port is configured and a custom proxy context path is added, none of the above changes are reflected in the URLs configured in Passive STS metadata.xml (<IS_HOME>/repository/deployment/server/webapps/mex/metadata.xml), which will fail the Passive STS login flow.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Do now throw, are throw?

I was just reading through the code and I notice that there were lots of error handling in the code. nice but Isn't it frown upon to throw errors in npm packages.. in stead you should past it as the first argument of the callback.

the errors thrown are all configuration errors which you should throw since your program is using this module wrong. there was a good article about this a while ago - i'll see if i can find it

https://www.joyent.com/developers/node/design/errors

Yes, what @mafintosh said is correct.
Programmer errors that are known at configuration-time should be thrown so they're detected as soon as possible by the programmer. Once you're using the module correctly, you don't have to worry about thrown errors at runtime. All runtime errors will be passed as the first argument to the callback.


Scala Repo Server: remove extra .jar extension on push

We need to bring this forwards - assigning to @jbeemster

https://github.com/snowplow/iglu/blob/master/vagrant/push/publish-iglu-server.bash

Apparently it's not benign:
Error: Invalid or corrupt jarfile iglu-server-0.2.0.jar.jar

Found the issue @alexanderdean:
As .jar is appended here: https://github.com/snowplow/iglu/blob/master/vagrant/push/publish-iglu-server.bash#L138
We do not need to append here: https://github.com/snowplow/iglu/blob/master/vagrant/push/publish-iglu-server.bash#L144
or here: https://github.com/snowplow/iglu/blob/master/vagrant/push/publish-iglu-server.bash#L146
Do you want me to commit this to master or a branch?

Thanks @jbeemster, I will fix it and try to merge back...

@alexanderdean interesting development on this one...
So the jar file outputted from sbt assembly in the target/scala-2.10 folder works, the one that winds up in the zip file in /dist appears to be corrupted.  Trying to figure out what is going on there..

The only difference being this line:
tail -c +44 ${fatjar_path} > ${fatjar_file} which seems to corrupt our ability to run the jar locally but I presume makes it work in the ElasticBeanstalk world.

Thanks @jbeemster , this was fixed in a rebase, closing!