Pin to taskbar; two icons

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.31.2
Regression From
No response
Architecture
x64
Storage Explorer Build Number
20231003.6
Platform
Windows
OS Version
Windows 10 (10.0.19045 )
Bug Description
Really minor issue; if I pin Azure Storage Explorer to the taskbar, and click it open, there is a new icon displayed instead of the usual behavior of underlining the one that's pinned:

Steps to Reproduce
Right click it in the menu, pin to taskbar, and open it from there.
Actual Experience
See image, I get two icons.
Expected Experience
Expected is to have only one icon in the taskbar.
Additional Context
No response

@arildskogmo there's a variety of techniques you can try here to get Windows working right again. I'll share what I would normally try in this situation but you may just need to keep trying stuff and find a set of steps that gets your Windows install happy.

Open Storage Explorer
Right click on any and all Storage Explorer icon from the taskbar, choosing "unpin" if the action exists
Close Storage Explorer
Open Storage Explorer again, make sure there is only one icon in the taskbar
Close Storage Explorer
Uninstall Storage Explorer from Windows settings
Restart computer
Install Storage Explorer
Open Storage Explorer, make sure there is only one icon in the taskbar
Close Storage Explorer
Open Storage Explorer
Right click on the Storage Explorer icon in the taskbar, and choose "pin"

Closing due to lack of response.
If you're still encountering this issue, we recommend opening an Azure support ticket via the Azure portal. Alternatively you can open a new issue here. This issue will no longer be monitored.


Rename ToolConfigurationTypeFacet to ToolConfigurationFacet in tool.ttl

Background
The facet name "ToolConfigurationTypeFacet" is required, but the text "Type" within its name is no longer relevant

Requirements
Remove the text "Type" from the UCO ontology for the following Facet:

tool.ttl:ToolConfigurationTypeFacet

so that it becomes

tool.ttl:ToolConfigurationFacet

Requirement 1
Rename to "ToolConfigurationFacet" from ToolConfigurationTypeFacet, and associated comment, within the turtle file tool.ttl
A total of four (4) changes in tool.ttl (lines 359, 365-366, and 379)
Requirement 2
Update CASE-Examples to reflect the facet name change
Check all examples within the master branch of:  https://github.com/casework/CASE-Examples/tree/master/examples/
for any references affected by the change.
i.e. run a keyword search across all the files in the above folder, and all its sub-folders, for "ToolConfigurationTypeFacet"
Known changes:

master/examples/illustrations/configured_tool/configured_tool.json (3 changes)

master/examples/illustrations/Oresteia/Oresteia.json (2 changes)

Note: This part of the requirement is listed as Issue 97 in the CASE github repository
Risk / Benefit analysis
Benefits
The change will bring the facet name inline with the more modern representation of this facet, and provides better conformance with the standard CASE Facet guidance.
Risks
Low Risk

The two (2) CASE-Examples listed in requirement 2 will be made at the same time to ensure they are remain compatible with this change.

Any developer code which currently hard codes the json-ld output using the existing "ToolConfigurationTypeFacet" name will need to amended to allow compability with future UCO\CASE versions.
Note: Code which automatically generates output data directly from the versioned *.ttl files will be unaffected by the change.
Forked examples may not, by default, have the change in their existing copy.

Competencies demonstrated
After the change, re-run a text search across all the files in the following repositories:

https://github.com/ucoProject/UCO (master)
https://github.com/casework/CASE-Examples (master)

Competency 1

Competency Question 1.1
Check that no hits are generated for the text pattern "ToolConfigurationTypeFacet" (case insensitive) in tool.ttl
Result 1.1
The result should not return any Hits.
Competency Question 1.2
Check that three (3) hits are generated for the text pattern "ToolConfigurationFacet" (case insensitive)

Result 1.2
The result should return exactly 3 Hits within tool.ttl (on lines 359, 365 and 379 only).
Solution suggestion
Rename ToolConfigurationTypeFacet to ToolConfigurationFacet in tool.ttl, and update CASE-Examples which reference this facet.

The OC requested a follow-on issue for removing "Type" from other class names.  I'd be happy to fast-track it.

Ah, dear.  This was re-filed from CASE without cross-linking when I was addressing many other issues.  I missed adding it to the agenda for last Thursday, so we did not discuss it or hold a Solutions Approval vote.
There's a good chance that this will have to be our kick-off of the 2.0.0 merging and reviewing practices.

This is such a simple change that the Requirement review was effectively a Solution review = remove the word "Type" from ToolConfigurationTypeFacet.
I recommend making this change without further voting.

I concur that this is a VERY localized change and that the Requirement review approval should be okay as a solution approval.
I just reviewed the PR and verified that the changes are specifically limited to the proposed changes agreed to in the Requirements review.

@eoghanscasey , @sbarnum , thank you.  We'll proceed with this as a Fast Track proposal having already received its necessary vote.


[web] Safari white frame when removing (last?) platform view

I recently built an app on flutter web using the latest master and I am experiencing random white screens or crashes when tapping around, see the link here App
https://user-images.githubusercontent.com/14053870/122508583-18378f00-cffa-11eb-8d39-8b6ba60930b5.MP4
Flutter Doctor
[✓] Flutter (Channel master, 2.3.0-17.0.pre.390, on Mac OS X 10.15.7 19H105 darwin-x64, locale
    en-US)
[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[✓] Xcode - develop for iOS and macOS
[✓] Chrome - develop for the web
[✓] Android Studio (version 4.2)
[✓] VS Code (version 1.57.0)
[✓] Connected device (2 available)

@peerwaya
Can you provide the crash log it generates ? Is the behavior replicable locally in debug mode or in release mode ?
Can you also provide a complete minimal reproducible code sample that we can use that shows the crashes ?

This is currently running in release mode, no crash log. happens randomly.

You can try the latest gallery app in release mode  on the latest master running on ios safari

I tried the gallery app and ran it in release mode using latest master and opened it in safari browser. Clicked through the app features but don't seem to get any crash / white frames.

Hi @darshankawar , please run it on iOS safari not desktop safari, I am working on a minimum sample

Here is a minimum sample
import 'package:animations/animations.dart';
import 'package:flutter/material.dart';
import 'package:url_launcher/link.dart';

void main() {
  runApp(const MyApp());
}

const url = 'https://google.com';

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        // This is the theme of your application.
        //
        // Try running your application with "flutter run". You'll see the
        // application has a blue toolbar. Then, without quitting the app, try
        // changing the primarySwatch below to Colors.green and then invoke
        // "hot reload" (press "r" in the console where you ran "flutter run",
        // or simply save your changes to "hot reload" in a Flutter IDE).
        // Notice that the counter didn't reset back to zero; the application
        // is not restarted.
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({Key? key, required this.title}) : super(key: key);
  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _selectedIndex = 0;
  final PageStorageBucket bucket = PageStorageBucket();

  final List<Widget> pages = const [
    Page1(),
    Page2(),
  ];

  Widget _bottomNavigationBar(int selectedIndex) => SafeArea(
        child: BottomNavigationBar(
          onTap: (int index) => setState(() => _selectedIndex = index),
          currentIndex: selectedIndex,
          items: const [
            BottomNavigationBarItem(
                icon: Icon(Icons.local_dining), label: 'Page1'),
            BottomNavigationBarItem(
                icon: Icon(Icons.assignment), label: 'Page2'),
          ],
        ),
        bottom: true,
      );

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      backgroundColor: Colors.amber,
      body: PageTransitionSwitcher(
        transitionBuilder: (
          Widget child,
          Animation<double> animation,
          Animation<double> secondaryAnimation,
        ) {
          return FadeThroughTransition(
            animation: animation,
            secondaryAnimation: secondaryAnimation,
            child: child,
            fillColor: Colors.amber,
          );
        },
        child: KeyedSubtree(
          key: ValueKey(_selectedIndex),
          child: pages[_selectedIndex],
        ),
      ),
      bottomNavigationBar: _bottomNavigationBar(
          _selectedIndex), // This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

class Page1 extends StatelessWidget {
  const Page1({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Page 1'),
      ),
      backgroundColor: Colors.amber,
      body: const SizedBox.expand(
        child: Center(
          child: Text('Empty Page'),
        ),
      ),
    );
  }
}

class Page2 extends StatelessWidget {
  const Page2({Key? key}) : super(key: key);
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Page 2'),
      ),
      backgroundColor: Colors.amber,
      body: Center(
        child: Link(
          uri: Uri.parse(url),
          target: LinkTarget.blank,
          builder: (context, onPressed) {
            return ElevatedButton(
                onPressed: onPressed, child: const Text('Button 2'));
          },
        ),
      ),
    );
  }
}

I noticed this happens with a Link Widget or something with a Platform view underneath on web especially iOS Safari. It's not so noticeable on chrome. It is fine on stable channel but It seems to have started after the slots refactor done by @ditman. @ditman what do you think?
https://user-images.githubusercontent.com/14053870/123050643-d2fbce80-d3f8-11eb-835a-78c47a3ae835.MP4

To see the effect, try switching the tabs

Thanks for putting effort to come up with minimal code sample and further details around it. Although I wasn't able to replicate it in debug and release mode using both renderers after running the code sample on iOS safari browser (version 14.4.1), may be it is replicable after deploying it on server.
Keeping it open for further insights from the team.
Cc: @yjbanov

I am running

@ditman is there a possibility this could be related to #80524 ? I started noticing this after migrating to the latest master with HTML slots. without the use of Link widget it works normally on iOS safari. The link widget uses a platform view for web. Also, how can I disable the HTML slots feature so I can test without slots?

how can I disable the HTML slots feature so I can test without slots?

You can switch to flutter stable, slots haven't landed there yet. (Maybe beta either)
I'll take a look at this asap!

This also happens in MacOS Safari:
https://user-images.githubusercontent.com/1255594/123705151-6713ce80-d81b-11eb-9c9f-ec2d22990abc.mov
It seems to be related to the moment where the platform view is deleted from the DOM (maybe it gets cleared before its slot and safari doesn't like it?)

is it possible to fallback to the implementation without slots for safari as a temporary workaround?

@peerwaya use flutter channel master for that, until we land the workaround.

I've reproduced the white page in development mode, locally, and with canvaskit rendering.
This is good news, because it probably means that this is a ShadowDOM Safari bug. I'm diving deeper.

OK, I think I've minimally reproduced the issue (without flutter web). Here's the link:
https://jsfiddle.net/ditman/rmwqjLah
If you visit that fiddle in Safari, the end result will be a "red" screen, but if you use Chrome, the end result will be "green".
I hope the JS code is easy to understand; I'll create a bug for Safari ASAP, but first I'll try to implement a mitigation strategy into flutter. We have two options:

Delete the "slotted" content before the slot itself. This could be a permanent fix, but I need to dive deeper in the ordering of the flutter events regarding web views.
Never delete the root container of the "slotted" content (this will seem like a "DOM node leak" from the outside, but this would be a temporary fix until Safari gets fixed).

We have a workaround for this that doesn't leave DOM nodes hanging. Deleting the slotted content before the slot was not practical, due to how flutter rendering pipeline works.

The underlying issue has been reported to Webkit, here:

Webkit:227652

The fix is rolling into flutter/master here:
https://github.com/flutter/flutter/pull/86036

The fix has rolled into flutter master successfully.


Design database model for wishlists

As a developer
I need to design a database model for the wishlists
So that all the information regarding wishlists can be stored in a single place and we can apply all the CRUD operations to it.
Details and Assumptions

We need to come up with the database design.
Need to finalize the tables and the required fields in each table.

Acceptance Criteria
Given the application is running
When any of the CRUD + list operation is performed
Then that information should be retrieved or saved to the database.

Here's how I think it can look. Open to suggestions.

The overall design looks good to me. Though I have couple of points/questions to ask:

Why is there an item_id in items table ? Is it majorly to have a primary key in the table ?
Should there be more fields in items for each wishlist like
a. Priority - This can be a feature to help users have their wishlist sorted according to the priority. Can be Low, Medium or High.
b. Comment - If there is some comment which a user wants to leave for any item or a wishlist. Can be totally ignored for now maybe?
Will there be multiple user profiles in this e-commerce website ? If yes, then can there be multiple users accessing the same wishlist ?

Hey Saksham, let me clarify -

Yes, it's to uniquely identify a row in the items table. Although technically speaking, a combination of (wishlist_id and product_id) can also uniquely identify a row, and can serve as the PK for items.
As discussed over our call, we can consider these feature enhancements once we have the required functionality up and running first. I like the ideas!
As per my understanding, there will be multiple distinct users, but only a single user profile per user. Each user should be uniquely identifiable by their user_id alone. @jjrofrano - prof- please correct me if this is wrong.

Here is the updated schema design for the wishlists table(s). Closing this ticket because we have reached a consensus among our team members regarding this.

Added the extra product_name field just so we can return a better looking response to the GET end-point calls, as opposed to returning just a product_id.


CI pony tests with and without debug, and compile examples.

After this change, CI runs will compile pony tests both with and without debug mode, and compile examples.

@jemc appveyor isnt running this because it says the PR is unmergeable

Okay, this should finally be passing all CI now, and is ready to merge.


Show all jobs without algolia

Blank searches don't need a search, so don't do a search!
Changes in this PR

Fix a sort value bug
Introducing PageObjects 🍾
Visit jobs page without algolia
Welcome back to system specs for the jobs page (including pagination and sorting)

Review app deployed to https://teaching-vacancies-review-pr-2796.london.cloudapps.digital


Add lock for memory map cache, and add expire when get some key.

/assign @linuxsuren

Ok, will try it later

/cc @kubesphere/sig-devops

hi @tmsi-io ,Any updates about the unit tests? Do you need some help?

Consider there is no response for a long time. I'm going to close this PR. @tmsi-io Please feel free to reopen it once you have free time on this.
/close


Indicate that a test was generated from src/**/{.case,.template}

Something like: test.generated = true | false

lol, just kidding. It's in test.flags


Using the web part shows lots of white space below the content

I am using the Learning web part on a few pages in SharePoint and I have noticed there is a lot of white space on the page below the content.  Please see the screenshot attached.  Is there anyway of getting rid of this please?

We also have the same issue. Now we are forced to move the learning pathways at the bottom of the page. But we actually want it surrounded with the text we add to the page. Can this be fixed?


Update index.json by npm run generate-list

This change also fixes generate-list.js to keep functions that end with X|Y|Z, like rotatex or rotatey (rotateX or rotateY).

Thank you! Available in 3.2.0.

Thank you for your quick release! 🎉


Don't error if device switched off

Previously get_device or the related functions would retrieve a list of
devices that it contacted in the last x seconds. Then we would contact
each light in turn to try and apply some sort of filtering.
This would error out if the light had been switched off.
This patch attempts to contact each light and skips it if it cannot be
contacted.
Closes #6
Note: I haven't tested this latest version just yet. The previous version, which was similar worked fine. Will do that ASAP.

Looks like my change breaks things, will debug tomorrow.

Have updated the patch. Can't use filter as the name of the parameter, as it overrides the Python filter function.


I want to monitor the drag and drop of windows. Are there any related events?

VSCODE plugin development

We have a great extension developer community over on GitHub discussions and Slack where extension authors help each other. This is a great place for you to ask questions and find support.
Happy Coding!


TLS 1.3 wrong JA3 values

when tls 1.3 is negotiated, the JA3 value is truncated therefore the md5 hash is wrong.

Emmm, this case is well tested internally. so it should be OK.
Could you please give a repro of "curl" cli example?

ssl_protocols TLSv1.2;
/usr/local/opt/curl/bin/curl -v https://tls.bob.com:4443

Trying <IP_ADDRESS>:4443...
Connected to tls.bob.com (<IP_ADDRESS>) port 4443 (#0)
ALPN: offers h2
ALPN: offers http/1.1
TLSv1.3 (OUT), TLS handshake, Client hello (1):
TLSv1.3 (IN), TLS handshake, Server hello (2):
TLSv1.2 (IN), TLS handshake, Certificate (11):
TLSv1.2 (IN), TLS handshake, Server key exchange (12):
TLSv1.2 (IN), TLS handshake, Server finished (14):
TLSv1.2 (OUT), TLS handshake, Client key exchange (16):
TLSv1.2 (OUT), TLS change cipher, Change cipher spec (1):
TLSv1.2 (OUT), TLS handshake, Finished (20):
TLSv1.2 (IN), TLS handshake, Finished (20):
SSL connection using TLSv1.2 / ECDHE-RSA-AES256-GCM-SHA384
ALPN: server accepted http/1.1
Server certificate:
subject: CN=*.bob.com
start date: Jun 27 00:00:00 2021 GMT
expire date: Jun 27 23:59:59 2022 GMT
subjectAltName: host "tls.bob.com" matched cert's "*.bob.com"
issuer: C=GB; ST=Greater Manchester; L=Salford; O=Sectigo Limited; CN=Sectigo RSA Domain Validation Secure Server CA
SSL certificate verify ok.

If you see this page, the web server is successfully installed and
working. Further configuration is required.

* Connection #0 to host tls.bob.com left intact
%
ssl_protocols TLSv1.3;
/usr/local/opt/curl/bin/curl -v https://tls.bob.com:4443

Trying <IP_ADDRESS>:4443...
Connected to tls.bob.com (<IP_ADDRESS>) port 4443 (#0)
ALPN: offers h2
ALPN: offers http/1.1
TLSv1.3 (OUT), TLS handshake, Client hello (1):
TLSv1.3 (IN), TLS handshake, Server hello (2):
TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
TLSv1.3 (IN), TLS handshake, Certificate (11):
TLSv1.3 (IN), TLS handshake, CERT verify (15):
TLSv1.3 (IN), TLS handshake, Finished (20):
TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
TLSv1.3 (OUT), TLS handshake, Finished (20):
SSL connection using TLSv1.3 / TLS_AES_256_GCM_SHA384
ALPN: server accepted http/1.1
Server certificate:
subject: CN=*.bob.com
start date: Jun 27 00:00:00 2021 GMT
expire date: Jun 27 23:59:59 2022 GMT
subjectAltName: host "tls.bob.com" matched cert's "*.bob.com"
issuer: C=GB; ST=Greater Manchester; L=Salford; O=Sectigo Limited; CN=Sectigo RSA Domain Validation Secure Server CA
SSL certificate verify ok.

GET / HTTP/1.1
Host: tls.bob.com:4443
User-Agent: curl/7.83.0
Accept: /

TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
old SSL session ID is stale, removing
Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Date: Fri, 06 May 2022 18:35:45 GMT
< Content-Type: text/html
< Content-Length: 371
< Last-Modified: Mon, 30 Dec 2019 03:50:24 GMT
< Connection: keep-alive
< ETag: "5e097400-173"
< Server: bob
< JA3: 772,4866-4867-4865-49196-49200-159-52393-52392-52394-49195-49199-158-49188-49192-107-49187-49191-103-49162-49172-57-49161-49171-51-157-156-61-60-53-47-255,0-11-10-13172-16-22-23-49-13-43-45-51-21,29-23-30-25-24
< JA3-Hash: cc438283e6fc32b1a412abb34f217ec2
< TLS-GREASED: 0
< Accept-Ranges: bytes
<

Default Install

Default Install.
If you see this page, the web server is successfully installed and
working. Further configuration is required.

* Connection #0 to host tls.bob.com left intact
%
The expected result for tls 1.3 should be:
JA3: 772,4866-4867-4865-49196-49200-159-52393-52392-52394-49195-49199-158-49188-49192-107-49187-49191-103-49162-49172-57-49161-49171-51-157-156-61-60-53-47-255,0-11-10-13172-16-22-23-49-13-43-45-51-21,29-23-30-25-24,
JA3-Hash: b0aca3a3bfcbb345b7e4e397f231dee8
when formats is null truncation occurs

i'm no c programmer, so to test my theory i added this horribly wrong code which does seem to work:
/* formats */
if (c->ssl->points.len) {
    pdata = c->ssl->points.data;
    pend = pdata + c->ssl->points.len;
    while (pdata < pend) {
        pstr = append_uint8(pstr, *pdata);
        *pstr++ = '-';
        pdata++;
    }
} else {
    /* quick dirty fix for tls 1.3 */
    *pstr++ = ',';
    pdata++;
}

fix in master branch, https://github.com/phuslu/nginx-ssl-fingerprint/commit/c65faa7c2e95f726170de21acc9506f778192687
please take a look.


When MenuBarState has orientation "vertical" arrow navigation doesn't work the way it does in horizontal.

Current behavior
When I navigate to the Menubar example with tabs, the arrow keys take over and it works great. I can go up / down / left / right.
But when the orientation is vertical, I can go through the menus fine, but when I go back to the top level buttons it loses focus.
Steps to reproduce the bug
Due to corporate firewall rules, I can't use the stackblitz or codesandbox.
Expected behavior
Arrow behavior / focus behavior like it does in Horizontal mode, just in vertical orientation add orientation="vertical" to the MenuBar.
Possible solutions
No response

I am trying this with ariakit as well, and it is the same. If you use keyboard arrows to go into a menu, and then try to go down or left you can't navigate like you can in horizontal mode.

@httpete Are you able to create a CodeSandbox now?

I am trying gitpod. Can you see this?
https://gitpodio-templatetypescr-4zxvldvg1h2.ws-us30.gitpod.io

Thanks! I can reproduce it now. I'll take a better look into the actual issue later. For now, you can add your own keydown handler to the Menu component. Something like this:
<Menu
  onKeyDown={(event) => {
    if (event.key === "ArrowLeft") {
      menu.hide();
    }
  }}
>

I am also seeing a difference when orientation=vertical when it comes to showOnMouseMove and toggleOnClick={false}. My goal is to have one and only one menu up at a time, upon hovering. In horizontal mode it works fine, in vertical if I hover in the menu and directly into another button, I see menus overlap.

I can report that on the latest alpha19 this is fixed!


Add marlin unit tests and marlin benchmark script

This PR ports marlin unit tests and benchmarking code from magic_wand, so we have all of the marlin code in one place.

@alexm-nm should the util files be in tests?


Unity code c# auto complete not working

Type: Bug
Happens sometimes
VS Code version: Code 1.77.3 (Universal) (704ed70d4fd1c6bd6342c436f1ede30d1cff4710, 2023-04-12T09:19:37.325Z)
OS version: Darwin arm64 22.4.0
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Apple M1 (8 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
2, 4, 4

Memory (System)
8.00GB (0.09GB free)

Process Argv
--crash-reporter-id 05ab203f-6b9d-4e9a-9732-ba55b73aa5df

Screen Reader
no

VM
0%

Extensions (3)

Extension
Author (truncated)
Version

csharp
ms-
1.25.4

intellicode-api-usage-examples
Vis
0.2.7

vscodeintellicode
Vis
1.2.30

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
nodejswelcome1:30587005
282f8724:30602487
pyind779:30671433
89544117:30613380
pythonsymbol12:30671437
a9j8j154:30646983
vsccsb:30705552
azdwalk:30721579
pythonms35:30701012
a2ce3375:30706076
pythonfmttext:30716742
pythonclientmv:30725892

\gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

Never mind. I fixed it. Sorry for bothering you


mdformat checks fail on github actions but not locally

Github Actions on this commit:

Local run:

Any help appriciated.

Update: I uninstalled/reinstalled mdformat-gfm & mdformat-toc, the local run threw the same errors:

The thing is everything reinstalled is just old cached wheels, so I didn't really update anything. I'm not sure why mdformat glitched out on multiple runs just now.

As you can see in the screenshot nothing is updated, everything is merely reinstalled from cache. As far as I understand that means that no package has been updated to a newer version.
I could definitely be wrong but I thought it was worth pointing out.

BTW, with the latest mdformat (0.6.3) you can run mdformat --version to print all installed plugins and their versions. Could be useful debugging.

This should be super helpful. Thanks.

As you can see in the screenshot nothing is updated, everything is merely reinstalled from cache. As far as I understand that means that no package has been updated to a newer version

Ah but that screenshot shows though that the cached mdformat-toc version is 0.2.2 which is the first version to remove the redundant angle brackets. Since the brackets were still in place in that commit, it makes sense for the check to fail.
Like said, the way to avoid this in the future is either to pin versions in CI, or alternatively whenever this occurs, install updated versions from pip, format locally, and make another commit.

This should be super helpful. Thanks.

Glad to be helpful :smile_cat:


Makefile should depend on actual dependencies

When building a plugin, we should parse (using go list) the dependencies of the plugin and add those files/directories as dependencies in the Makefile.  We can likely skip standard imports, but anything that can be found in the $GOPATH likely should be included.

Resolved a while back


Adding docs for VectorScene and LinearTransformationScene and reimplementing method

…, more information in PR comments

Overview: What does this pull request change?

Motivation and Explanation: Why and how do your changes improve the library?

When I worked in #3479 I noticed no examples for VectorScene and LinearTransformationScene, so I decided to change it.
During the writing example of the add_axes method, I noticed some bugs and its usage was quite limited. I decided to change it. I will add the reason for all changes in separate comments, in concrete changes.
Links to added or changed documentation pages

Further Information and Comments

please ignore the changes in get_pieces_movement I will remove them in the next commit, It was attached because I copied the code from another branch and forgot that they were there.

Reviewer Checklist

[ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
[ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
[ ] If applicable: newly added functions and classes are tested

Closing due to inactivity.


Show ContentLength in UI

Would be nice to show the content length of the response.
And even better, if the response is compressed (gzipped), show both raw size and text size

It does, at least, show the content length in the response headers. Agree, good to know compressed/uncompressed size.

When gzip is turned on in IIS, content-length header might get missing if the compressed data is bigger than the IIS buffer size.
Getting the uncompressed size is easy (response.Content.Length), but I don't seem to find the binary size...

So the problem is chunked responses. Gzipped responses below the buffer limit will have Content-Length headers with the size set. For Transfer-Encoding: chunked responses we might be able to keep a running total of each chunk or just count the characters in the response at the end.
http://en.wikipedia.org/wiki/Chunked_transfer_encoding
http://www.codeproject.com/Articles/648526/All-about-http-chunked-responses


Make global flags (fast predictive variances, use Toeplitz, etc) python contexts

Fixed  in https://github.com/jrg365/gpytorch/commit/bf4b15d005bb2c556b4683bca97c7699fad4151b


watch: ignore resourceVersion

Potentially addresses #2374 (or, at least, addresses a cause of it, which may or may not be the only cause)
Problem
As an optimization, when one of Tilt's watchers gets an update for an object from a K8s informer, it checks to see if its resourceVersion is older than the last resourceVersion it saw, and if so, ignores it.
Unfortunately:

resourceVersion is a string, and Tilt is using string comparison (so, e.g., if we see resourceVersion "9", we'll then ignore "10" through "89" and "100" through "899")
the comment on resourceVersion says clients must treat it as opaque

Solution
Simply remove the resourceVersion check. Theoretically the K8s informer provides us updates in order, so it does us no good.

I cooooould write unit tests for resourceVersion on the other watchers as well, but writing tests for deleted code, especially deleted code that was never tested in the first place, doesn't seem super valuable.


It's Cutting the text - FFText

Hello guys! I'm trying to create a text with a specific Script font, the text looks cut.

Here my code
const text = new FFText({ text: title, fontSize: parseInt(titleFontSize * 2), x: width / 2, y: 60 });
text.alignCenter();
text.setColor(textColor);
text.setFont(fontPath);

Someone knows why?
Thanks in advance!
Armando

you can set padding

how do we set padding?

@drawcall how do we set padding?

I also have an issue where the text cannot contain special characters like ':' - any way around this @drawcall ?


Bugfix/button loading issue in modal

Description
Fix edge-case issue with setting loading={true} on a Button in a Modal on page load. (Why would anyone do this?)
Button would get width: 0 because the width is calculated before the button is rendered.
This also caused the spinner not to show, because we checked widthOverride instead of the loading prop.
Component Checklist 📝

[ ] JSDoc
[ ] Examples
[ ] Documentation
[ ] Storybook
[ ] Style mappings (@navikt/core/css/config/_mappings.js)
[ ] Component tokens (@navikt/core/css/tokens.json)
[ ] CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
[ ] Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
[ ] New component? CSS import (@navikt/core/css/index.css)
[ ] Breaking change? Update migration guide. Consider codemod.
[x] Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: :sparkles: Add feature xyz.")

looks good to me! I added a story for testing this (i also tried the same story on main to see that it breaks there, but is fixed here 🎉 )
on main (broken loading buttons inside modal ):

this branch:

:shipit:


Can't ingest bittrex data

Dear Catalyst Maintainers,
Before I tell you about my issue, let me describe my environment:
Environment

Operating System: MacOS Sierra 10.13.5
Python Version: Python 3.6.5
How did you install Catalyst: pip installed in virtualenv

aiodns==1.1.1
aiohttp==3.3.2
alembic==0.9.10
async-timeout==3.0.0
attrdict==2.0.0
attrs==18.1.0
bcolz==1.2.1
boto3==1.7.48
botocore==1.10.48
Bottleneck==1.2.1
cchardet==2.1.1
ccxt==1.15.1
certifi==2018.4.16
chardet==3.0.4
click==6.7
contextlib2==0.5.5
cyordereddict==1.0.0
Cython==0.28.3
cytoolz==<IP_ADDRESS>
decorator==4.3.0
docutils==0.14
empyrical==0.2.1
enigma-catalyst==0.5.14
eth-abi==1.1.1
eth-account==0.2.3
eth-hash==0.1.4
eth-keyfile==0.5.1
eth-keys==0.2.0b3
eth-rlp==0.1.2
eth-utils==1.0.3
hexbytes==0.1.0
idna==2.7
idna-ssl==1.0.1
intervaltree==2.1.0
jmespath==0.9.3
Logbook==1.4.0
lru-dict==1.1.6
lxml==4.2.3
Mako==1.0.7
MarkupSafe==1.0
multidict==4.3.1
multipledispatch==0.5.0
networkx==2.1
numexpr==2.6.5
numpy==1.14.5
pandas==0.19.2
pandas-datareader==0.6.0
parsimonious==0.8.0
patsy==0.5.0
pycares==2.3.0
pycryptodome==3.6.3
python-dateutil==2.7.3
python-editor==1.0.3
pytz==2018.5
redo==1.6
requests==2.19.1
requests-file==1.4.3
requests-ftp==0.3.1
requests-toolbelt==0.8.0
rlp==1.0.1
s3transfer==0.1.13
scipy==1.1.0
six==1.11.0
sortedcontainers==2.0.4
SQLAlchemy==1.2.9
statsmodels==0.9.0
tables==3.4.4
toolz==0.9.0
urllib3==1.23
web3==4.0.0b11
wrapt==1.10.11
yarl==1.1.0
Now that you know a little about me, let me tell you about the issue I am
having:
Description of Issue
Running command:
catalyst ingest-exchange -x bittrex -f minute
I get the output message:
Trying to ingest exchange bundle bittrex...
But then nothing. No progress bar or data download appears to happen. Ingesting bitfinex and poloniex seems to work fine. Is this expected behavior? Or is bittrex not supported? The status page doesn't have any information on it https://enigma.co/catalyst/status/

Hi @lucasgadams , thanks for reporting the issue with the coverage page, we are aware of it and working to fix it.
Regarding Bittrex, no minute-resolution data is currently available for this exchange. Historical data is provided with daily resolution for Bittrex, Bitfinex and Poloniex but minute resolution data is currently available for only Bitfinex and Poloniex.
With that said, we are actively adding historical data for more exchanges.


add isatest data

Thank you for submitting your code!
Please ensure this checklist is complete before creating the pull request.

[x] All of my data files are named <site_ID>_data*.csv
[ ] All columns are present in my data file(s)
[ ] All columns are named properly
[ ] Data are coded according to the data dictionary
[ ] All measures are within the appropriate scales and distribution

To check boxes, change - [ ] to - [x]

@ivdvelpen I did something stupid in the checker script and there was a bug.
I've fixed it now and I ran it on your data. It works now.
Can we try this one more time?

I'm learning a lot lol

No worries! From which step would you like me to start again?

From the beginning because your fork will need my updated code. So delete your fork and re-fork the main repo.
Thank you!


[Relay] Convert negative axes to positive when importing ONNX Unsqueeze

Currently, ONNX frontend imports Unsqueeze as a sequence of expand_dims in Relay. This works fine when the axes are positive.
However, for negative axes we need to compute the output rank and add the negative axis value to get its equivalent positive axis value.
This commit computes the output rank as the sum of the input rank of data and the number of axis in the axes array and convert negative axes to positive.
This commit also adds testcases for unsqueeze with negative axes and verifies the result with onnx runtime.

@AndrewZhaoLuo : This is my first pull request. Can you please take a look?


Avoid duplicate expvar metrics - fixes #716

Fixes #716

Use different namespaces for Cassandra primary and archive storage
Fix a bug where archive factory wasn't used in query/main
Use new expvar metrics module from jaeger-lib 1.4.0

Signed-off-by: Yuri Shkuro<EMAIL_ADDRESS>

@black-adder ready for review

Coverage remained the same at 100.0% when pulling d78cae6f0c3018280e624cc5059cc86284ba2c49 on fix-716-expvar-dups into ba7d67bda737f0393749ab06b747c140582a9c8b on master.


Add proposal for Ansible webhooks

Description of the change:
Proposal for supporting webhooks in Ansible-based Operators
Motivation for the change:
Webhook support is necessary for CRD versioning as well as higher level defaulting and validation.
It was also requested in #1658

closed in favor of #2685

closed in favor of #2685


Kiosk mode not always loading ios 12.5.5

Running HA 2021.12.4 I’m having issues with kiosk mode in the ios app 12.5.5.
Initial load the kioskmode get’s activated, but when it got triggered by motion and needs to refresh for instance it fails.
Seeing the following error in my logs:
Logger: frontend.js.es5.202112200
Source: components/system_log/__init__.py:189
First occurred: 08:20:17 (10031 occurrences)
Last logged: 22:04:57

https://haurl.nl/hacsfiles/kiosk-mode/kiosk-mode.js?hacstag=303101606172:38:25 TypeError: null is not an object (evaluating 't.querySelector')

Can't reproduce the error anymore in HA 2021.12.5. Performance is also better.
I think it might have been related to this issue.
Closing for now.


Data missing from CIP57 specification

What Git revision are you using?
aiken v1.0.29-alpha+16fb02e
What operating system are you using, and which version?

[x] Linux / Ubuntu

Describe what the problem is?
Given the following Aiken code
pub type Test{
  DataType { val: Data}
}

the following definition in plutus.json gets created
{
"Data": {
  "title": "Data",
  "description": "Any Plutus data."
},

This type has no dataType as expected (since Data isn't a primitive in cip57`).
What should be the expected behavior?
I'm not sure how this should be handled. From a plutus.json parsing tool, I can just hardcode `title === 'Data'), but maybe this should be mentioned in cip57? If Data is an Aiken-only type, then maybe there needs to be a way for CIP57 to be more clear on handling of custom compiler-specific types
There is a precedent for handle this because of the Void type in Aiken which is a custom type represented as
"Void": {
  "title": "Unit",
  "description": "The nullary constructor.",
  "anyOf": [
    {
      "dataType": "constructor",
      "index": 0,
      "fields": []
    }
  ]
},

But there are also other cases of custom types missing such as https://github.com/aiken-lang/aiken/issues/970

It isn't missing, it's actually part of the spec:

dataType
The value of this keyword must be a string, with one of the following value listed in the first column of the table above. This keyword is optional. When missing, the instance is implicitly typed as an opaque Plutus Data.

The rationale here being that Data actually represent any possible type that can appear in a contract ABI. So it can be the default to anything. dataType allows to constraint further down the type. But when unspecified, it simply is Data.


URLs repeated display

In GitLab by @wknet123 on Nov 10, 2017, 09:18

In GitLab by @sokril on Nov 8, 2019, 08:14
closed

In GitLab by @sokril on Nov 8, 2019, 08:14
assigned to @wknet123


Failed to fetch https://packages.microsoft.com/ubuntu/20.04/prod/dists/focal/main/binary-armhf/Packages.gz

Describe the issue

When doing apt-get update on CI build inside github action, the build failed with Failed to fetch https://packages.microsoft.com/ubuntu/20.04/prod/dists/focal/main/binary-armhf/Packages.gz  File has unexpected size (17314 != 17306). Mirror sync in progress? [IP: <IP_ADDRESS> 443].
The error happened randomly.
When did the issue occur?

The issue start happening yesterday night.
Screenshots

Additional context

Yesterday during your night we were wrestling with some caching issues for our apt repos. Those were resolved around 0100 UTC on 2023-11-21. If you continue to see this issue, please report the IP address to which packages.microsoft.com resolves on the system seeing the issue.

Can confirm, issue is still happening

We've confirmed all mirrors to have healthy information as of 2023-11-21 1800 UTC. Please open a new issue if you see a metadata mismatch after that date/time.

Thanks @jasonzio. Everything is working on our side

@jasonzio  This issue is happening again today.
Get:1 https://cli.github.com/packages stable InRelease [3917 B]
Hit:2 https://download.docker.com/linux/ubuntu focal InRelease
Get:3 https://packages.microsoft.com/ubuntu/20.04/prod focal InRelease [3631 B]
Get:4 https://cli.github.com/packages stable/main amd64 Packages [345 B]
Hit:5 https://deb.nodesource.com/node_16.x focal InRelease
Hit:7 http://archive.ubuntu.com/ubuntu focal InRelease
Get:8 http://security.ubuntu.com/ubuntu focal-security InRelease [114 kB]
Get:9 https://packages.microsoft.com/ubuntu/20.04/prod focal/main amd64 Packages [251 kB]
Get:10 https://packages.microsoft.com/ubuntu/20.04/prod focal/main arm64 Packages [52.4 kB]
Err:10 https://packages.microsoft.com/ubuntu/20.04/prod focal/main arm64 Packages
  Hash Sum mismatch
  Hashes of expected file:
   - Filesize:52423 [weak]
   - SHA512:6ed8aa7a219d25a47e358e95bf0ccdb0902159d05246c6c73c23c46[33](https://github.com/cko-issuing/end-to-end-tests-client-pov/actions/runs/7058693367/job/19214780428#step:7:34)1e089f21332a4dd80fe5c0b3b255446a882bce7d949c804448f41daeaa9c2729f68f62a
   - SHA256:4fe7ed7a60b8e6152126053b33c147bcb3f1008e60d7b9e41b488b16c7c63c37
  Hashes of received file:
   - SHA512:63e209[34](https://github.com/cko-issuing/end-to-end-tests-client-pov/actions/runs/7058693367/job/19214780428#step:7:35)280a4e57c05016be4b80082e7cafe4505350a4999e6fe3b09a93b9a80e3d922263a7a6d75b6fce34b4ee9b4b11ca52f38784d5747aae2416280bf2de
   - SHA256:12ffdd50bb51b186d4c3ddf7115aa552794dc1f6e9d3dd9840ff2a40d25bd7d2
   - Filesize:52423 [weak]
  Last modification reported: Tue, 28 Nov 2023 14:09:50 +0000
  Release file created at: Fri, 01 Dec 2023 09:25:04 +0000
Get:11 https://packages.microsoft.com/ubuntu/20.04/prod focal/main armhf Packages [17.6 kB]
Get:12 http://archive.ubuntu.com/ubuntu focal-updates InRelease [114 kB]
Hit:6 https://packages.cloud.google.com/apt kubernetes-xenial InRelease
Hit:13 http://archive.ubuntu.com/ubuntu focal-backports InRelease
Get:14 http://security.ubuntu.com/ubuntu focal-security/universe amd64 Packages [1143 kB]
Get:15 http://archive.ubuntu.com/ubuntu focal-updates/restricted amd64 Packages [3228 kB]
Get:16 http://security.ubuntu.com/ubuntu focal-security/restricted amd64 Packages [3079 kB]
Get:17 http://security.ubuntu.com/ubuntu focal-security/main amd64 Packages [3238 kB]
Get:18 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 Packages [3726 kB]
Get:19 http://archive.ubuntu.com/ubuntu focal-updates/universe amd64 Packages [1439 kB]
Fetched 16.4 MB in 2s (8017 kB/s)
Reading package lists...
E: Failed to fetch https://packages.microsoft.com/ubuntu/20.04/prod/dists/focal/main/binary-arm64/Packages.gz  Hash Sum mismatch
   Hashes of expected file:
    - Filesize:52423 [weak]
    - SHA512:6ed8aa7a219d25a47e[35](https://github.com/cko-issuing/end-to-end-tests-client-pov/actions/runs/7058693367/job/19214780428#step:7:36)8e95bf0ccdb0902159d05246c6c73c23c46331e089f21332a4dd80fe5c0b3b255446a882bce7d949c804448f41daeaa9c2729f68f62a
    - SHA256:4fe7ed7a60b8e6152126053b33c147bcb3f1008e60d7b9e41b488b16c7c63c[37](https://github.com/cko-issuing/end-to-end-tests-client-pov/actions/runs/7058693367/job/19214780428#step:7:38)
   Hashes of received file:
    - SHA512:63e20934280a4e57c05016be4b80082e7cafe4505350a4999e6fe3b09a93b9a80e3d922263a7a6d75b6fce34b4ee9b4b11ca52f[38](https://github.com/cko-issuing/end-to-end-tests-client-pov/actions/runs/7058693367/job/19214780428#step:7:39)784d5747aae2416280bf2de
    - SHA256:12ffdd50bb51b186d4c3ddf7115aa552794dc1f6e9d3dd98[40](https://github.com/cko-issuing/end-to-end-tests-client-pov/actions/runs/7058693367/job/19214780428#step:7:41)ff2a40d25bd7d2
    - Filesize:52[42](https://github.com/cko-issuing/end-to-end-tests-client-pov/actions/runs/7058693367/job/19214780428#step:7:43)3 [weak]
   Last modification reported: Tue, 28 Nov 2023 14:09:[50](https://github.com/cko-issuing/end-to-end-tests-client-pov/actions/runs/7058693367/job/19214780428#step:7:51) +0000
   Release file created at: Fri, 01 Dec 2023 09:25:04 +0000
E: Some index files failed to download. They have been ignored, or old ones used instead.
Error: Process completed with exit code 100.

@jasonzio can you please help?
@adams-begue-cko  this issue should be re-opened.

@goshik-ahotar-cko we found one mirror where the Packages.gz file was stale, and resolved it at ~1600 UTC. Let us know if you're still seeing an issue.
Note that we're investing in this scenario to prevent recurrence - your concerns are not unheard.

We currently use a "fetcher" to keep apt metadata in sync (due to known race conditions in this protocol) and shipped fixes within the last week to make this more robust.
We're actively working to implement apt-by-hash, to mitigate the race condition altogether
We're investing in monitoring to identify issues of this nature more quickly in the future.

Facing the same issue since the last 8-10 hours:
Err:10 https://packages.microsoft.com/ubuntu/20.04/prod focal/main arm64 Packages
  Hash Sum mismatch
  Hashes of expected file:
   - Filesize:52423 [weak]
   - SHA512:32e5126e8db9cbc5a3c6214deddf1b27dd7e0e922588281996a25183a9a6f4e6a56a559f4fe59f83ea34ed6e8a725eec154744973cf86f7c1c7ca35e09cba70f
   - SHA256:06a5f304110feaf046491a7387962aae7beaa7c78f86043380b4202278475835
  Hashes of received file:
   - SHA512:6ed8aa7a219d25a47e358e95bf0ccdb0902159d05246c6c73c23c46331e089f21332a4dd80fe5c0b3b255446a882bce7d949c804448f41daeaa9c2729f68f62a
   - SHA256:4fe7ed7a60b8e6152126053b33c147bcb3f1008e60d7b9e41b488b16c7c63c37
   - Filesize:52423 [weak]
  Last modification reported: Fri, 01 Dec 2023 09:26:08 +0000
  Release file created at: Sat, 02 Dec 2023 09:00:05 +0000

@srijan thanks for reporting this issue. This specific occurrence of this issue should now be fixed. See #105 for further updates as we work to prevent this from recurring.

👋 Hi, just wanted to chime in add that my team is also experiencing this issue with binary-armhf today:
[91mE: Failed to fetch https://packages.microsoft.com/ubuntu/20.04/prod/dists/focal/main/binary-armhf/Packages.gz  Hash Sum mismatch
   Hashes of expected file:
    - Filesize:17612 [weak]
    - SHA512:225106b79e05167e08ff398b41a31e2807d0d47fdf801a57bdabcec7c384acce4987f73587b2cb4b955b5f10f55f2c8e6f61447e6e4328375d85c3377bd0146f
    - SHA256:3c9116eea3c1def2bc2a920ab3b4968c3235bf1e3bb95822bcbc9bfcc849f5a6
   Hashes of received file:
    - SHA512:625d2539de286f1b9179e4bfc3fd32b72c6785564aef578feda3ae73bed57a78ad044dcdef85cc3b1604661e6a663c9848352b19a3dbebf22a50e7244a4651f8
    - SHA256:437df061bf15c60d78325783820cf97b8a6a09831e9b047f3d3b096c3a5aa182
    - Filesize:17612 [weak]
   Last modification reported: Fri, 01 Dec 2023 09:26:08 +0000
   Release file created at: Sat, 02 Dec 2023 09:00:05 +0000
E: Some index files failed to download. They have been ignored, or old ones used instead.

👋 I'm also seeing the same issue with armhf and binary-armhf. These occurred around 4 Dec 2023 - 19:01 UTC
Get:14 https://packages.microsoft.com/ubuntu/20.04/prod focal/main armhf Packages [17.6 kB]
Err:14 https://packages.microsoft.com/ubuntu/20.04/prod focal/main armhf Packages
  Hash Sum mismatch
  Hashes of expected file:
   - Filesize:17612 [weak]
   - SHA512:225106b79e05167e08ff398b41a31e2807d0d47fdf801a57bdabcec7c384acce4987f73587b2cb4b955b5f10f55f2c8e6f61447e6e4328375d85c3377bd0146f
   - SHA256:3c9116eea3c1def2bc2a920ab3b4968c3235bf1e3bb95822bcbc9bfcc849f5a6
  Hashes of received file:
   - SHA512:625d2539de286f1b9179e4bfc3fd32b72c6785564aef578feda3ae73bed57a78ad044dcdef85cc3b1604661e6a663c9848352b19a3dbebf22a50e7244a4651f8
   - SHA256:437df061bf15c60d78325783820cf97b8a6a09831e9b047f3d3b096c3a5aa182
   - Filesize:17612 [weak]
  Last modification reported: Fri, 01 Dec 2023 09:26:08 +0000
  Release file created at: Sat, 02 Dec 2023 09:00:05 +0000

Get:29 http://archive.ubuntu.com/ubuntu focal-backports/universe amd64 Packages [28.6 kB]
Fetched 30.5 MB in 3s (10.9 MB/s)
Reading package lists...
[91mE: Failed to fetch https://packages.microsoft.com/ubuntu/20.04/prod/dists/focal/main/binary-armhf/Packages.gz  Hash Sum mismatch
   Hashes of expected file:
    - Filesize:17612 [weak]
    - SHA512:225106b79e05167e08ff398b41a31e2807d0d47fdf801a57bdabcec7c384acce4987f73587b2cb4b955b5f10f55f2c8e6f61447e6e4328375d85c3377bd0146f
    - SHA256:3c9116eea3c1def2bc2a920ab3b4968c3235bf1e3bb95822bcbc9bfcc849f5a6
   Hashes of received file:
    - SHA512:625d2539de286f1b9179e4bfc3fd32b72c6785564aef578feda3ae73bed57a78ad044dcdef85cc3b1604661e6a663c9848352b19a3dbebf22a50e7244a4651f8
    - SHA256:437df061bf15c60d78325783820cf97b8a6a09831e9b047f3d3b096c3a5aa182
    - Filesize:17612 [weak]
   Last modification reported: Fri, 01 Dec 2023 09:26:08 +0000
   Release file created at: Sat, 02 Dec 2023 09:00:05 +0000

@allan-pires @Lehcar I think I've fixed the problem. Can you test again?

It's working for me now, thank you!

@goshik-ahotar-cko we found one mirror where the Packages.gz file was stale, and resolved it at ~1600 UTC. Let us know if you're still seeing an issue. Note that we're investing in this scenario to prevent recurrence - your concerns are not unheard.

We currently use a "fetcher" to keep apt metadata in sync (due to known race conditions in this protocol) and shipped fixes within the last week to make this more robust.
We're actively working to implement apt-by-hash, to mitigate the race condition altogether
We're investing in monitoring to identify issues of this nature more quickly in the future.

Thank you

@goshik-ahotar-cko we found one mirror where the Packages.gz file was stale, and resolved it at ~1600 UTC. Let us know if you're still seeing an issue. Note that we're investing in this scenario to prevent recurrence - your concerns are not unheard.

We currently use a "fetcher" to keep apt metadata in sync (due to known race conditions in this protocol) and shipped fixes within the last week to make this more robust.
We're actively working to implement apt-by-hash, to mitigate the race condition altogether
We're investing in monitoring to identify issues of this nature more quickly in the future.

Thank you, it works fine for me.


jsimple and jnegative

added details of both to the yaml and included the thumbnails

@paulmostowyj Thanks for adding jsimple and jnegative. Great themes. Keep it up. Cheers.

cheers
although i've checked the website and can't see the themes on there

@paulmostowyj  See the F.A.Q entry: A: Thanks for your patience. The themes.yml is only used by the drjekyll package manager with "direct" web access. For the Dr Jekyll's website (see source) the themes.yml has to run through build steps (see source) to get github stars 'n' history etc. and, sorry, for now this is still a manual task / procedure that will get done "by hand". For your theme to show up, thus, please wait for the next site update.

thanks for taking the time to answer and I'm sorry I didn't read the README properly :)


Enable cost model rate tests

This is a test to see if the cost model rate tests will pass on GitHub without errors and/or warnings. Seems to be working for me locally.
https://issues.redhat.com/browse/COST-2530

Codecov Report

Merging #2370 (a28cfba) into main (ea880e1) will increase coverage by 0.88%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2370      +/-   ##
==========================================
+ Coverage   67.99%   68.88%   +0.88%
==========================================
  Files         412      412
  Lines        7878     7878
  Branches     1858     1731     -127
==========================================
+ Hits         5357     5427      +70
+ Misses       2515     2446      -69
+ Partials        6        5       -1

Impacted Files
Coverage Δ

src/api/queries/query.ts
43.85% <0.00%> (ø)

...c/pages/costModels/components/inputs/rateInput.tsx
85.71% <0.00%> (+4.76%)
:arrow_up:

.../pages/costModels/components/rateForm/rateForm.tsx
96.96% <0.00%> (+6.06%)
:arrow_up:

src/pages/costModels/components/rateForm/utils.tsx
92.15% <0.00%> (+11.76%)
:arrow_up:

...rc/pages/costModels/components/rateForm/hasDiff.ts
100.00% <0.00%> (+14.70%)
:arrow_up:

...rc/pages/costModels/components/inputs/selector.tsx
97.14% <0.00%> (+17.14%)
:arrow_up:

...ges/costModels/components/rateForm/useRateForm.tsx
97.39% <0.00%> (+30.43%)
:arrow_up:

src/pages/costModels/components/addPriceList.tsx
100.00% <0.00%> (+43.75%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea880e1...a28cfba. Read the comment docs.


Remove options request helper

This method is no longer being used by the API. ✂
Thanks for finding this @bdunne
@miq-bot assign @bdunne
@miq-bot add_label cleanup

Gaprindashvili backport details:
$ git log -1
commit 30a869d5a78ccb02a71a7b22405cc25371f67172
Author: Brandon Dunne<EMAIL_ADDRESS>Date:   Thu Jan 18 10:08:50 2018 -0500

    Merge pull request #16842 from jntullo/remove_options_request_helper

    Remove options request helper
    (cherry picked from commit 4fb6c9be4f0a4dc532740318d5146b4e5f9c5c4d)


Updated video profiles

Check if this PR fulfills these requirements:

[x] My changes respect the Kodi add-on development rules
[x] I have read the CONTRIBUTING document.
[x] I made sure there wasn't another Pull Request opened for the same update/change
[ ] I have successfully tested my changes locally

Types of changes

[ ] New feature (non-breaking change which adds functionality)
[x] Feature change (non-breaking change which changes behaviour of an existing functionality)
[ ] Improvement (non-breaking change which improves functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Refactor (non-breaking performance or readability improvements)

Description

The website has updated the video profiles
In case of Feature change / Breaking change:
Describe the current behavior

Describe the new behavior

Screenshots (if appropriate):

i need to do two tests to know if hevc profiles are working on android,
someone can do? @jakermx?
1 test: with HEVC enabled and HDR disabled
2 test: with HEVC enabled and HDR enabled
remember to enable in expert setting:

to know i the hevc stream is played
plugin.video.netflix_1.16.0+matrix.1_20210614_t1.zip
there is the possibility that this tests fails because i have kept only one type of hevc profile (in zip test)

I had no problem getting all profiles to work on my Firestick 4K.
Dolby Vision, HDR10 and SDR.

thank you for the feedback

Could not find the codec info setting, using Matrix 20 N*.

i will try to see


Nmshdb 90 reactivation of a relationship

Readiness checklist

[ ] I added/updated unit tests.
[ ] I added/updated integration tests.
[ ] I ensured that the PR title is good enough for the changelog.
[ ] I labeled the PR.

Description
This is Hunor's task for which I urgently need a draft. Ignore until Hunor asks for a review.

Regarding this file Modules/Relationships/src/Relationships.Domain/Aggregates/Relationships/RelationshipStatus.cs:
    ...
    Active = 20,
    Rejected = 30,
    Revoked = 40,
    Terminated = 50,
    Reactivated = 60
    ...

This is not a good status name since you're task is concerned only with requesting a relationship reactivation, and this one is concerned with accepting such a request, and only once that happens is the relationship reactivated.
What you would need is something like ReactivationRequested or similar.


Incorrect Azure AI CLI steps for Mac OS

The installation steps mentioned for Mac OS on the following link for Azure AI CLI are incorrect.
https://thebookof.ai/install-ai-cli/
When I run the script it fails with the following error.

dotnet is not installed.
Installing dotnet 8.0...
sudo: apt-get: command not found
awk: can't open file /etc/os-release
source line number 1
grep: invalid option -- P
usage: grep [-abcdDEFGHhIiJLlMmnOopqRSsUVvwXxZz] [-A num] [-B num] [-C[num]]
[-e pattern] [-f file] [--binary-files=value] [--color=when]
[--context[=num]] [--directories=action] [--label] [--line-buffered]
[--null] [pattern] [file ...]
Unsupported distribution:

It seems the "https://aka.ms/InstallAzureAICLIDeb" script is not meant for Mac OS.
Instead I installed the dotnet sdk using brew on Mac OS
brew install --cask dotnet-sdk
and then install using the steps provided in the Azure AI CLI GitHub repo.
dotnet tool install -g Azure.AI.CLI --prerelease

Fixed with https://github.com/robch/book-of-ai/commit/9f959733c42fdcdf97a8f7f72781ffe02c0a2e42

Fixed with commit 9f959733c42fdcdf97a8f7f72781ffe02c0a2e42


Resource Packs error?

No error
Install plugins: https://mclo.gs/QFrPuoF

not really sure what plugin could be causing this, but its probably one of them. You could also try redownloading the jar, but its likely that 2.0 fixes this anyway because it uses direct bedrock packets to send the titles, meaning that Java plugins shouldnt be able to mess it up. But other than that I cant really help

sorry. I will try again


Bug: The search function crashes the application

The search function crashes the application with error message "No logcontroller attached".

Should be fixed in v1.1.0


Stop tests from depending on table row store being sealed

Changed
Stop tests from depending on table row store being sealed, to shorten E2E runtime, and prevent timeouts even with the new HTTP client.

In a lot of other places in the SDK and others, we run a ".clear database cache streamingingestion schema"
Could it work for this case?

In a lot of other places in the SDK and others, we run a ".clear database cache streamingingestion schema"
Could it work for this case?

Valentina said that command wouldn't help


fix bug on nba main page

most likely a problematic join on team name somewhere....

fixed by https://github.com/matsonj/nba-monte-carlo/commit/6ad119a3eca493a5ba7a8370e2b99e33d238cb53
actual issue was moving target elo rating (many per season for a single team)


Support slash commands on Telegram

Telegram bots by default run in "privacy mode" which only passes commands starting with a forward slash / to bots.
Right now the bot to run on telegram needs privacy mode off, but this is easy fixed just changing the prefix for commands on telegram to /.

I've just created a PR that would enable this, since the parse() function can now tell a message is coming from Telegram, and modify the prefix accordingly.


Extensions in web worker not available even if specified?

Hello! I'm trying to make extensions work with the WebWorker.
Here is my worker.js
import { PGlite } from<EMAIL_ADDRESS>import { worker } from<EMAIL_ADDRESS>import { pg_trgm } from<EMAIL_ADDRESS>
worker({
  async init(options) {
    const pg = new PGlite('opfs-ahp://neotab/neotab.db', {...options, extensions: { ...options.extensions, pg_trgm }})
    // If you want run any specific setup code for the worker process, you can do it here.
    return pg
  },
})

console.log('Worker process started')

(I'm using the direct imports because for some reason the '@' imports don't work when importing this script from /public (i'm using vite).
However, with this query:
CREATE EXTENSION IF NOT EXISTS pg_trgm;

  CREATE TABLE IF NOT EXISTS "bookmarks" (
    "id" TEXT PRIMARY KEY NOT NULL,
  "title" TEXT NOT NULL,
  "url" TEXT NOT NULL,
  "snippet" TEXT,
  "created_at" TEXT NOT NULL,
  "tags" TEXT[] NOT NULL,
  "favicon" TEXT,
  "visits" NUMERIC NOT NULL DEFAULT 0
  );

 CREATE INDEX IF NOT EXISTS "bookmarks_snippet_idx" ON "bookmarks" USING gin (snippet gin_trgm_ops);
CREATE INDEX IF NOT EXISTS "bookmarks_title_idx" ON "bookmarks" USING gin (title gin_trgm_ops);
CREATE INDEX IF NOT EXISTS "bookmarks_url_idx" ON "bookmarks" USING gin (url gin_trgm_ops);
CREATE INDEX IF NOT EXISTS "bookmarks_tags_idx" ON "bookmarks" USING gin (tags);

I get Error: extension "pg_trgm" is not available
I tried to query available extensions, and i don't see trgm on there, Any clue?
Thank you!

Hey @Bewinxed, thanks for the report.
I'm struggling to reproduce this. Could you take a look at the network tab on the dev tools and see if it shows pg_trgm.tar.gz being downloaded sucsesfully?
Should look like this:

(There is a double forward slash in there that I'm going to go and fix now, but doesn't seem to cause an issue)

Ok so after a day of testing, I found out how to make this work (I'm developing an Extension, with Svelte + Vite).
WORKER SCRIPT (And this must go somewhere in ./src, NOT /public or it won't be compiled
import { PGlite } from '@electric-sql/pglite'
import { worker } from '@electric-sql/pglite/worker'
import { pg_trgm } from '@electric-sql/pglite/contrib/pg_trgm'

worker({
  async init(options) {
    const pg = new PGlite('opfs-ahp://neotab/neotab.db', {
      ...options,
      extensions: { pg_trgm },
    })
    // If you want run any specific setup code for the worker process, you can do it here.
    return pg
  },
})

console.log('Worker process started')

Import the worker with this (Other ways don't seem to work)
import PGWorker from './worker.js?worker'

export const pglite = new PGliteWorker(
  new PGWorker({
    name: 'neotab-worker',
  }),
  {
    dataDir: 'opfs-ahp://neotab/neotab.db',
    relaxedDurability: true,
    // extensions: { pg_trgm },
  },
)

Now creating the extension then making indexes work!, even after build.
Also, you must set worker.format = 'es' (Default is iife) in vite.config.ts
import { defineConfig } from 'vite'
import { crx } from '@crxjs/vite-plugin'
import { svelte } from '@sveltejs/vite-plugin-svelte'
import path from 'node:path'
import sveltePreprocess from 'svelte-preprocess'
import manifest from './src/manifest'
import { join } from 'node:path'
import { buildSync } from 'esbuild'
export default defineConfig(({ mode }) => {
  const production = mode === 'production'

  return {
    build: {
      emptyOutDir: true,
      outDir: 'build',
      rollupOptions: {
        output: {
          chunkFileNames: 'assets/chunk-[hash].js',
        },
      },
    },
    worker: {
      format: 'es',
    },
    plugins: [
      crx({ manifest }),
      svelte({
        compilerOptions: {
          dev: !production,
        },
        preprocess: sveltePreprocess({
          typescript: true,
        }),
      }),
      {
        apply: 'build',
        enforce: 'pre',
        transformIndexHtml() {
          buildSync({
            minify: true,
            bundle: true,
            entryPoints: [join(process.cwd(), 'public', 'worker.js')],
            outfile: join(process.cwd(), 'build', 'worker.js'),
            external: ['@electric-sql/pglite'],
            format: 'esm',
          })
        },
      },
    ],
    resolve: {
      alias: {
        '@': path.resolve(__dirname, 'src'),
      },
    },
    server: {
      host: 'localhost',
      strictPort: true,
      port: 5173,
      hmr: {
        port: 5173,
      },
    },
    optimizeDeps: {
      exclude: ['@electric-sql/pglite', '@electric-sql/pglite/worker'],
    },
  }
})

Now I need to figure out how to communicate with this via another service worker 🤔 Since the extension's background script is a service worker in an of itself.


Patched driver

Add driver for velodyne vlp32c.
I tried vlp32c which is one of latest production from velodyne in hackathon event in China.
This new sensor have double range than previous production while using the same raw data format which lead to need double distance factor.
Now, even in ros velodyne_driver, keeping using previous driver will lead all the value(distance) to be half of real distance.
Here I modify the previous driver, now it can recognize vlp32c and use a different distance factor only for it.

Thx! Will check it - we will receive a VLP32c on Monday :))

@ChenxiTU Can you please change this PR?
The PR should not target Autoware repo, but instead Autoware fork of velodyne_drivers
The source code there is a subtree.
Please check the details I added to https://github.com/CPFL/Autoware/tree/develop/ros/src/sensing/drivers/lidar/packages/velodyne

@ChenxiTU I added you to the list of collaborators of the repo, so you can create a PR to https://github.com/CPFL/velodyne repo.
Once merged there we create another PR updating the subtree.
Thanks!


AArch64 support

Does a support of aarch64 is achievable (even if not officially supported) ?
https://github.com/jiangcuo/Proxmox-Port?tab=readme-ov-file#interesting-thing states:

related to https://forum.proxmox.com/threads/proxmox-on-aarch64-arm64.121925/
which points to https://github.com/pimox/pimox7 and https://github.com/jiangcuo/Proxmox-Arm64

It might, assuming no issues compiling the kernel for it. Having said that, you'd probably want the newer (6.x) kernels compiled for arch64, not the 5.x series from here (the ones still being produced by this project), no?
From the looks of it, jiangcuo has things working already, although I'm not sure why they are running kernel 5.15 with Proxmox 8.x (it comes with kernel 6.2). Proxmox kernel 6.2 should already have the "relaxable RMRR" patch included, so all you need to do is enable it. How would kernel 5.15 be useful here?

As he started support with proxmox 7.2, he needed the 5.x kernel

So why not just move to kernel 6.x? They'll want that eventually, right?

Stale issue.


Image Demonstrating Data Preview Includes "Objectionable" Data Row

This is probably a really odd submission... I was reading through the tutorial and when I reached Step 8 of "Build transformation logic in the data flow canvas", when I noted with shock that the list of movies included in the sample data included "Birth of a Nation, the". This is a rather infamous white supremacist film in the USA, so it was rather upsetting to see in an otherwise innocuous context like technical documentation.
It's probably just an artifact of open source sample data and a sort on the date column pushing it to the top of the list, but my personal opinion is that it's rather unprofessional and non-inclusive to feature as an image in published documentation. Particularly since it seems like a minor change to replace the image with a slightly different slice of the preview data. But, as a matter of opinion rather than an explicit error, you are certainly free to weight my critique however you wish! I'd rather highlight the issue for consideration than let it pass unremarked.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f7c75ee8-d021-62fe-c7e3-53a6e729e1fc
Version Independent ID: 7ae45fa9-cb4f-dbc5-dcb6-4a4f4c040d28
Content: Transform data using a mapping data flow - Azure Data Factory
Content Source: articles/data-factory/tutorial-data-flow.md
Service: data-factory
GitHub Login: @dcstwh
Microsoft Alias: weetok

@lilylovesyou Thanks for the feedback !  I have assigned this issue to content author to investigate and update the document as appropriate.

Thank you for the feedback, and we understand your concerns.
@minhe-msft  can you help to work with the team to update the screenshot to remove that line?
Thank you.

Fixed.
#please-close


Parse types for nested params

Fixes #593
See e.g. authCache and credentialsFetcher optional params here: https://michaelbausor.github.io/gcloud-php/#/docs/google-cloud/master/bigquery/bigqueryclient?method=__construct
Vs. the existing docs here: https://googlecloudplatform.github.io/google-cloud-php/#/docs/google-cloud/master/bigquery/bigqueryclient?method=__construct

Note - this implementation is borrowed from here: https://github.com/phpDocumentor/ReflectionDocBlock/blob/release/2.x/src/phpDocumentor/Reflection/DocBlock/Tag/ReturnTag.php#L89

I'm so glad you were able to figure this one out!! :)


[Feature request]  SEO improvements

The landing page(https://ifcjs.github.io/info/) does not seem to have a link to the web viewer and only has one for the docs.
The web viewer seems to be the best solution out there and the one with least friction to simply see an IFC file but a google search for "View IFC online" doesn't show it anywhere in the first page for me.
The ideal situation I think would be similar to how Google shows https://gltf-viewer.donmccurdy.com/ for "View gltf online"

We are making a new landing page and we'll make sure to include a link to a viewer, or embed it directly 🙂

::take

🟢🟢🟢

::take

Hi, @arunkvijay! Thanks for taking this bounty! The due date is January 2, 2023 UTC.
If you need to submit some pull requests (PR) to complete the tasks, make sure that the last and only the last PR has a title that either starts with the bounty ID or is exactly the same as the bounty name. After the PR is merged, this bounty’s status will automatically changed to done.
If you do not need to make a PR, tell the manager @agviegas to run ::done command after your tasks is confirmed to be done.
Good luck!

@agviegas I am planning to add a button that allow users to upload an ifc file. Should I add this button to the header next to the Get Started button or should it be a different section added below the header section.

@arunkvijay A button in the top bar called "Demo" (next to Community) should be good!

::extend

🟢🟢🟢

::extend

Hi, @arunkvijay! The due date is successfully extended by 21 days to January 23, 2023 UTC.

🔴🔴🔴
Hi, @arunkvijay! The date is past due, your assignment has been revoked. It’s now available for anyone to take.

::take

🟢🟢🟢

::take

Hi, @arunkvijay! Thanks for taking this bounty! The due date is March 1, 2023 UTC.
If you need to submit some pull requests (PR) to complete the tasks, make sure that the last and only the last PR has a title that either starts with the bounty ID or is exactly the same as the bounty name. After the PR is merged, this bounty’s status will automatically changed to done.
If you do not need to make a PR, tell the manager @agviegas to run ::done command after your tasks is confirmed to be done.
Good luck!

::drop

🟢🟢🟢

::drop

Hi, @arunkvijay! Thanks for giving it a try! It’s now once again available for anyone to take.

::take

🟢🟢🟢

::take

Hi, @aka-blackboots! Thanks for taking this bounty! The due date is May 4, 2023 UTC.
If you need to submit some pull requests (PR) to complete the tasks, make sure that the last and only the last PR has a title that either starts with the bounty ID or is exactly the same as the bounty name. After the PR is merged, this bounty’s status will automatically changed to done.
If you do not need to make a PR, tell the manager @agviegas to run ::done command after your tasks is confirmed to be done.
Good luck!

::done

🟢🟢🟢

::done

Hi, @aka-blackboots! Thanks for your contributions! Please submit an expense to IFC.js Open Collective. Then, tell us the invoice number via the ::expense::_____ command (replace the _____ with the invoice number).

::expense::134263

🟢🟢🟢

::expense::134263

Hi, @aka-blackboots! Thanks for the confirmation! We’ll proceed to review the expense. Once it’s approved, the payment will be scheduled.

🟢🟢🟢
Hi, @aka-blackboots! Your expense has been approved!

🎉🎉🎉
Hi, @aka-blackboots! Thanks for your contributions! The reward of this bounty has been transferred to your Open Collective account.


[3.2.10] restore Package menu item "Go to containing package" vs. new, terrible "Go to Class Creation Dictionary"

This was a change as a side issue on some other issue, but I object to the new name as confusing and uninformative.  I would accept "Go to associated package".  But the Class Creation thing make no sense to me.
The reason I requested something, which turned out to be this menu option, was so I could check if I would be allowed to move a method from another package into this package.  This is controlled by the package's associated SymbolDictionary, since everything in a package has one and only one SymbolDictionary.
Dale's argument was that a dictionary doesn't define a package, and selecting a package not all the contents to the left will be in that dictionary.  But this is not going to confuse anyone, the font changes make it pretty clear,

Changed per request

hold on a second ... let me clarify, AGAIN?
The symbol dictionary that you end up in after using the "go to containing package" has nothing to do with a package ... and you will see ALL of the classes defined in that symbol dictionary independent of package  ... so 'package' is totally unrelated to the operation you are performing ... BTW the original menu item was 'Go to containing dictionary', which is a better name than 'Go to package" .... perhaps 'Go to dictionary' is not a bad name either ... but package?

I think Lisa had a typo- I called it Go to associated dictionary in my fix. That work?

Yeah ... that's fine ...since the typo wasn't called out in the actual issue and the fix message was 'fixed per request' I didn't realize the request was made in some other place :smile:

I'm not sure I follow this thread but I don't object to the current menu items.


change: add deleted value to ChangeDeleted

We can get deleted value from node argument passed in Change.parse(), so we can add this additional attribute to ChangeDeleted.

I agree that it would be nice to have this feature merged in the trunk and the official deliveries.
Thanks for providing that pull request as a reference in the meantime !

Code is working and that would be great if it could be merged!

Hi,
Could you put a description in the commit message? See this link for guidelines.
Also, I wonder what happens when a presence container or list element is deleted. Could you add unit tests to ensure every use case works? Container, ContainerPresence, List, Leaf, etc.
Thanks!

Hi,
Could you put a description in the commit message? See this link for guidelines.
I fear this would brings a significant performance hit when there are a lot of changes. When deleting a container, the value is a dict containing the recursive deleted data. I would really prefer if the ChangeDeleted for List and Container nodes would have None as value.
Also, could you add unit tests to ensure every use case works?
Thanks!

I have added the change for Container nodes (includes List). For tests, I have seen that they are already included for Container (line 108 in tests_subs_module_change), which would be the special case we have. Are there any other use cases you want to include?

For our usecase, we need this change, but the changes that are important for us are actually in a DContainer !
So the check for a DLeaf or DLeafList prevent us from having the node's value.
Would it be possible to have this behavior configurable, so that the user can judge is he can take the small performance hit ?
To have consistency in our code we would like to avoid having to implement some kind of caching mechanism when the information could come from the notification directly.
For instance, can we add a parameter to have a "short" or "full" description when we receive the list of changes ?

For our usecase, we need this change, but the changes that are important for us are actually in a DContainer ! So the check for a DLeaf or DLeafList prevent us from having the node's value.
Would it be possible to have this behavior configurable, so that the user can judge is he can take the small performance hit ? To have consistency in our code we would like to avoid having to implement some kind of caching mechanism when the information could come from the notification directly.
For instance, can we add a parameter to have a "short" or "full" description when we receive the list of changes ?

I also think it would be useful to have the ability to be able to retrieve the value in lists and containers. It is true that, one way or another, when retrieving the changes of the values inside the container we would end up having this information, but it makes it a bit complicated.
Also, in the case of ChangeCreated or ChangeModified, we are getting the value of lists and containers. For consistency, wouldn't it be better to do the same for ChangeDeleted? As @Krisscut comments, we could make this option configurable if performance is a major issue.

If that is needed, we could add a new optional full parameter to Session.get_changes (default to False). Do you want to send a new PR?

In case we add a full parameter to Session.get_changes, how would the user be able to configure this parameter for changes passed in module change callback?
I see that Session.get_changes is called in module_change_callback from sysrepo.subscription module, which is mapped to srpy_module_change_cb C function with same arguments, and this one is called in Session.subscribe_module_change, where I think it would be a good idea to have the configurable parameter. However, we cannot modify the number of arguments in srpy_module_change_cb, as this is used by C library, right? Correct me if I am wrong, please.

Perhaps something along these lines (not tested):
diff --git a/sysrepo/change.py b/sysrepo/change.py
index acc06c78d768..a6beea37e530 100644
--- a/sysrepo/change.py
+++ b/sysrepo/change.py
@@ -31,6 +31,7 @@ def parse(
         prev_list: str,
         prev_dflt: bool,
         include_implicit_defaults: bool = True,
+        include_deleted_values: bool = False,
     ) -> "Change":
         """
         Parse an operation code and values from libsysrepo.so and return a Change
@@ -64,6 +65,8 @@ def parse(
             Previous value default flag, depends on the operation.
         :arg include_implicit_defaults:
             Include implicit default values into the data dictionaries.
+        :arg include_deleted_values:
+            Include deleted nodes values.
         """
         if operation == lib.SR_OP_CREATED:
             if not node.should_print(
@@ -83,8 +86,8 @@ def parse(
                 prev_dflt=prev_dflt,
             )
         if operation == lib.SR_OP_DELETED:
-            if isinstance(node, (libyang.DLeaf, libyang.DLeafList)):
-                value = node.value()
+            if include_deleted_values:
+                value = _node_value(node, include_implicit_defaults)
             else:
                 value = None
             return ChangeDeleted(node.path(), value)
diff --git a/sysrepo/session.py b/sysrepo/session.py
index 06d2377a4488..1f1ba6f2514d 100755
--- a/sysrepo/session.py
+++ b/sysrepo/session.py
@@ -293,6 +293,7 @@ def subscribe_module_change(
         private_data: Any = None,
         asyncio_register: bool = False,
         include_implicit_defaults: bool = True,
+        include_deleted_values: bool = False,
         extra_info: bool = False,
     ) -> None:
         """
@@ -329,6 +330,8 @@ def subscribe_module_change(
             monitored read file descriptors. Implies `no_thread=True`.
         :arg include_implicit_defaults:
             Include implicit default nodes in changes.
+        :arg include_deleted_values:
+            Include deleted node values in changes.
         :arg extra_info:
             When True, the given callback is called with extra keyword arguments
             containing extra information of the sysrepo session that gave origin to the
@@ -343,6 +346,7 @@ def subscribe_module_change(
             private_data,
             asyncio_register=asyncio_register,
             include_implicit_defaults=include_implicit_defaults,
+            include_deleted_values=include_deleted_values,
             extra_info=extra_info,
         )
         sub_p = ffi.new("sr_subscription_ctx_t **")
@@ -732,7 +736,10 @@ def subscribe_notification(

     # begin: changes
     def get_changes(
-        self, xpath: str, include_implicit_defaults: bool = True
+        self,
+        xpath: str,
+        include_implicit_defaults: bool = True,
+        include_deleted_values: bool = False,
     ) -> Iterator[Change]:
         """
         Return an iterator that will yield all pending changes in the current session.
@@ -743,6 +750,8 @@ def get_changes(
             appended to the XPath.
         :arg include_implicit_defaults:
             Include implicit default nodes.
+        :arg include_deleted_values:
+            Include deleted node values into the returned Change objects.

         :returns:
             An iterator that will yield `sysrepo.Change` objects.
@@ -778,6 +787,7 @@ def get_changes(
                             prev_list=c2str(prev_list_p[0]),
                             prev_dflt=bool(prev_dflt_p[0]),
                             include_implicit_defaults=include_implicit_defaults,
+                            include_deleted_values=include_deleted_values,
                         )
                 except Change.Skip:
                     pass
diff --git a/sysrepo/subscription.py b/sysrepo/subscription.py
index e7b2ffae3b34..93c317da9c2f 100755
--- a/sysrepo/subscription.py
+++ b/sysrepo/subscription.py
@@ -33,6 +33,7 @@ def __init__(
         asyncio_register: bool = False,
         strict: bool = False,
         include_implicit_defaults: bool = True,
+        include_deleted_values: bool = False,
         extra_info: bool = False,
     ):
         """
@@ -50,6 +51,9 @@ def __init__(
         :arg include_implicit_defaults:
             If True, include implicit default nodes into Change objects passed to module
             change callbacks and into input parameters passed to RPC/action callbacks.
+        :arg include_deleted_values:
+            If True, include the complete deleted node values into Change objects passed
+            to module change callbacks.
         :arg extra_info:
             When True, the given callback is called with extra keyword arguments
             containing extra information of the sysrepo session that gave origin to the
@@ -64,6 +68,7 @@ def __init__(
         self.asyncio_register = asyncio_register
         self.strict = strict
         self.include_implicit_defaults = include_implicit_defaults
+        self.include_deleted_values = include_deleted_values
         self.extra_info = extra_info
         if asyncio_register:
             self.loop = asyncio.get_event_loop()
@@ -242,6 +247,7 @@ def module_change_callback(session, sub_id, module, xpath, event, req_id, priv):
                     session.get_changes(
                         root_xpath + "//.",
                         include_implicit_defaults=subscription.include_implicit_defaults,
+                        include_deleted_values=subscription.include_deleted_values,
                     )
                 )
                 task = subscription.loop.create_task(

Thanks for the suggestion! I will take a look at it and test it. When it is ready I will open a new PR.

Thanks guys for the fast feedback and proposals !
The new include_deleted_values param in the subscribe_module_change would be a good solution indeed to provide the choice to the user.

I have added a minor fix to changes suggested by @rjarry, some tests and it seems to be working fine (see #37).


Update platform initialization for newest libnode revisions

The current code used to initialize Nodejs (CreatePlatform and CreateEnvironment) is using an older version of the libnode embedding API.
The new version removes the execArgs parameter for CreatePlatform and adds a new parameter to CreateEnvironment that lets you specify the platform version (I'm not sure what this does exactly, in my testing it kinda did nothing).
Are there plans to support this new API? How would a backwards-compatible variant of this even look, considering that the delegate pointers for both of these have strongly-typed parameters?

Yes, I've been planning for a while to update that, but haven't prioritized it since the PR has been in limbo. But @vmoroz is planning to help with that PR soon, so updating this project be a good validation of the revised embedding API before getting that PR merged.

How would a backwards-compatible variant of this even look, considering that the delegate pointers for both of these have strongly-typed parameters?

I'm not sure I understand this question... but since there is no need to support older revisions of the PR, I don't think there's a back-compat concern?

I'm not sure if you guys want to keep compatibility with Node DLLs that were built with the old API.

No, I don't think anyone has any expectation of such compatibility.

We didn't have an issue tracking this, so I'll put this one on the project plan.


Add LatexDraw.app v3.3.5

Here is a Cask definition for LaTexDraw, a small tool for drawing figure in LaTeX documents: thesis, reports, etc. without having to "hand-code" everything.
I run all the required tests before committing 🤓:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.
[x] Named the cask according to the token reference.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no open pull requests for the same cask.
[x] Checked the cask was not already refused in closed issues.
[x] Checked the cask is submitted to [the stable versions repo].

Welcome, and thank you.
Next time, please leave the sections of the template intact. They help visually separate what was done.

just added the appcast call, is that it ?

Hello there,
I don't get the CI response: I followed the instructions for generating the appcast checkpoint but got a different hash value:
$ brew cask _appcast_checkpoint --calculate "https://sourceforge.net/projects/latexdraw/rss"
359991ab747f45b0157314d4826dc2cb3f311e222e6f3dca4fff361cd9d35144

I can sill amend the code to make the CI happy, but without understanding why it feels kinda bad...

@ushu The appcast checkpoint seems to have changed again since your last post. We should investigate why it keeps changing so regularly before we merge this pull request.
1 file inspected, no offenses detected
==> Downloading https://downloads.sourceforge.net/latexdraw/LaTeXDraw-3.3.5.app.
######################################################################## 100.0%
==> Verifying checksum for Cask latexdraw
audit for latexdraw: warning
 - appcast checkpoint mismatch
Expected: 359991ab747f45b0157314d4826dc2cb3f311e222e6f3dca4fff361cd9d35144
Actual: 619b027e14b1b2814f18fcb86d1f51839dce5d5c50212884ee565a10558b962a
Error: audit failed for casks: latexdraw

Tried an appcast a bit more specific. Let’s see if it sticks.

Thank you for your contribution.


Design chatbox component

We will be using a ready-made, open source chat component (the same one being used in the foam demo).  It comes with a decent design already, but to keep the product on-brand, I'll be making adjustments to the design, just not now.  Will be tweaking it later on once functionality has been integrated.  Moving this back to Current Sprint backlog for now


Let the user pick the highlight groups or use some dedicated groups that link to defaults

What the title says. Essentially let the user use their own highlighting.

Hi @kmoschcau, I've added this in ecc1abc1d727a9d1e74eafb62f8d6a35dfc2169f

Thanks!


On mobile while scrolling on rating element triggers onChange with NaN value

Operating system: Windows 10
Browser and version (if relevant): chrome 64

Steps to Reproduce

Open chrome browser in mobile emulation mode
Add rating
Scroll page on rating element
Previous rating value lost

@laimonas can you share an example with reproducible issue on codepen or something similar? I try to reproduce it on demo page but I'm not able to reproduce the reported issue.


Link not worked Open API Specification zip

Download and extract

Hello, thank you. The link to download has been fixed:
Create action project

Hi, I don't have access. Could you provide another link plz

Hello, please let me know if you can download the file now.
All the best,
Céline


"set" method undefined when using needs

The set method on a test case is undefined when using needs. this simple test case passes when the need for the store is removed. this.subject and this.render still function in the scope of the test case
Test case:
import { expect } from 'chai';
import { describeComponent, it } from 'ember-mocha';
import hbs from 'htmlbars-inline-precompile';

describeComponent(
    'my-component',
    'Integration: MyComponent',
    {
      integration: true,
      needs: ['store']
    },
    function() {
      it('renders', function() {
        this.set('model', {});
        this.render( hbs`{{my-component model=model}}`);
        expect(this.$('.my-component')).not.to.be.empty;
      });
    }
);

Results:
Integration: MyComponent renders
    ✘ 'undefined' is not a function (evaluating 'this.set('model', {})')
        TypeError: 'undefined' is not a function (evaluating 'this.set('model', {})')

Did you ever get this working @kswilster ? I've got the same issue.

I had the same problem, but turns out I was just using an outdated version of ember-mocha, so upgrading should help.

as @Fryie mentions this should be fixed the recent releases. please reopen if this is indeed still an issue!


Throw Exceptions instead of Errors

Currently there are some open issues where MapDB throws an Error. A quick search brought up these recent ones:
AssertionError:
https://github.com/jankotek/MapDB/issues/513
https://github.com/jankotek/MapDB/issues/515
https://github.com/jankotek/MapDB/issues/509
https://github.com/jankotek/MapDB/issues/451
IOError:
https://github.com/jankotek/MapDB/issues/514
Even if these issues are not fixed soon, I recommend to catch and throw an exception instead.
Because of an Error an application using MapDB aborts. With an exception the app could detect an issue in MapDB, and drop the whole storage, without knowing what exactly went wrong, and start over with a fresh one.

+1

There is long discussion about checked/unchecked exception. MapDB implements Map interface so we must wrap IOException into IOErrors.
MapDB simple expects IO errors to be inrecoverable. Users should close and reopen the store. WAL should be replayed in case of errors etc. It is too low-level and there is not really option to add something better without more layers and overhead.
MapDB 2.0 is better. It outputs warnings into logger. It also has exception hierarchy with better error messages. Assertions will also give better description.
Also MapDB 2.0 file format is much more robust. There are checksums and bit parity checks, so it detects data corruption much earlier.

MapDB 2.0 now has exception hierarchy. It throws different exceptions for different types of errors.

@jankotek, the discussion about checked/unchecked exceptions is irrelevant. This is about Error being thrown (as opposed to some extension of RuntimeException -- neither of which are checked).

I understand. The DBException,
root of exception hierarchy in
MapDB 2, extends
RuntimeException.


Test fails on device but not in simulator

Describe the bug
I'm using the VoiceMemo tests in my own version of a voice recorder. The tests are failing on device but not in simulator. Seems related to receiving actions before they were expected.
To Reproduce
Here is the VoiceMemo app in its own project and fails tests on device. The screenshot as a hint to what might be going on?
device-test.zip
Screenshots

Environment

Xcode 11.5
iOS 13.5
TCA 0.2 and 0.3

@pcolton You ever manage to repro with our repo?

I reproduced with the TCA VoiceMemo app unmodified. It’s the zip I included.
-Paul

On May 29, 2020, at 9:11 AM, Stephen Celis<EMAIL_ADDRESS>wrote:

@pcolton You ever manage to repro with our repo?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

It seems I can't test the actual TCA repo directly as there's no way for me to sign the library when testing the specific VoiceMemos app, but as I mentioned, I just extracted that demo as its own app and it fails in the exact same way my own app is failing on-device testing. Note that other tests are fine, it's something specific to these tests, and it seems it might be related to the DispatchQueue.testScheduler.
FYI, this is the Xcode error when I try to test TCA VoiceMemos on my device:
`
Showing All Messages
VoiceMemos.app (2763) encountered an error (Failed to load the test bundle. (Underlying error: The bundle “VoiceMemosTests.xctest” couldn’t be loaded because it is damaged or missing necessary resources. The bundle is damaged or missing necessary resources. dlopen_preflight(/var/containers/Bundle/Application/515DF2D4-D817-4C4A-B4C2-64385BF9BE50/VoiceMemos.app/PlugIns/VoiceMemosTests.xctest/VoiceMemosTests): no suitable image found.
Did find:
/var/containers/Bundle/Application/515DF2D4-D817-4C4A-B4C2-64385BF9BE50/VoiceMemos.app/PlugIns/VoiceMemosTests.xctest/VoiceMemosTests: code signature in (/var/containers/Bundle/Application/515DF2D4-D817-4C4A-B4C2-64385BF9BE50/VoiceMemos.app/PlugIns/VoiceMemosTests.xctest/VoiceMemosTests) not valid for use in process using Library Validation: mapped file has no cdhash, completely unsigned? Code has to be at least ad-hoc signed.))
`

Ok, I was able to open the TCA VoiceMemos project directly, I just had to add a Plist.info file to the Tests so it wold properly sign, then I could run tests on my device. They fail again:

For the testPlayMemoHappyPath, the error was:

And stack trace on the first self.scheduler.advance(by: 1) in that test...

Seems like stride is way off?

I printed out stride and delta for simulator and device, hope some of this helps.
simulator:

Stride(magnitude:<PHONE_NUMBER>) Stride(magnitude: 500000000)
Stride(magnitude: 500000000) Stride(magnitude: 500000000)

device:
Stride(mag

Stride(magnitude:<PHONE_NUMBER>) Stride(magnitude: 12000000)
Stride(magnitude: 988000000) Stride(magnitude: 12000000)
Stride(magnitude: 976000000) Stride(magnitude: 12000000)
Stride(magnitude: 964000000) Stride(magnitude: 12000000)
Stride(magnitude: 952000000) Stride(magnitude: 12000000)
Stride(magnitude: 940000000) Stride(magnitude: 12000000)
Stride(magnitude: 928000000) Stride(magnitude: 12000000)
Stride(magnitude: 916000000) Stride(magnitude: 12000000)
Stride(magnitude: 904000000) Stride(magnitude: 12000000)
Stride(magnitude: 892000000) Stride(magnitude: 12000000)
Stride(magnitude: 880000000) Stride(magnitude: 12000000)
Stride(magnitude: 868000000) Stride(magnitude: 12000000)
Stride(magnitude: 856000000) Stride(magnitude: 12000000)
Stride(magnitude: 844000000) Stride(magnitude: 12000000)
Stride(magnitude: 832000000) Stride(magnitude: 12000000)
Stride(magnitude: 820000000) Stride(magnitude: 12000000)
Stride(magnitude: 808000000) Stride(magnitude: 12000000)
Stride(magnitude: 796000000) Stride(magnitude: 12000000)
Stride(magnitude: 784000000) Stride(magnitude: 12000000)
Stride(magnitude: 772000000) Stride(magnitude: 12000000)
Stride(magnitude: 760000000) Stride(magnitude: 12000000)
Stride(magnitude: 748000000) Stride(magnitude: 12000000)
Stride(magnitude: 736000000) Stride(magnitude: 12000000)
Stride(magnitude: 724000000) Stride(magnitude: 12000000)
Stride(magnitude: 712000000) Stride(magnitude: 12000000)
Stride(magnitude: 700000000) Stride(magnitude: 12000000)
Stride(magnitude: 688000000) Stride(magnitude: 12000000)
Stride(magnitude: 676000000) Stride(magnitude: 12000000)
Stride(magnitude: 664000000) Stride(magnitude: 12000000)
Stride(magnitude: 652000000) Stride(magnitude: 12000000)
Stride(magnitude: 640000000) Stride(magnitude: 12000000)
Stride(magnitude: 628000000) Stride(magnitude: 12000000)
Stride(magnitude: 616000000) Stride(magnitude: 12000000)
Stride(magnitude: 604000000) Stride(magnitude: 12000000)
Stride(magnitude: 592000000) Stride(magnitude: 12000000)
Stride(magnitude: 580000000) Stride(magnitude: 12000000)
Stride(magnitude: 568000000) Stride(magnitude: 12000000)
Stride(magnitude: 556000000) Stride(magnitude: 12000000)
Stride(magnitude: 544000000) Stride(magnitude: 12000000)
Stride(magnitude: 532000000) Stride(magnitude: 12000000)
Stride(magnitude: 520000000) Stride(magnitude: 12000000)
Stride(magnitude: 508000000) Stride(magnitude: 12000000)

Testing with the latest master (as of June 4, 2020), this issue seems to have been fixed. 👍

Since I the fix is on master and I assume this will be part of 0.4.0, I'll close this ticket. Thanks.