Confusing FluentEnums

I don't understand the design decisions here. Maybe we can have a discussion.
>>> from ansys.fluent.core import UIMode
>>> mode_1 = UIMode("no_graphics") # due to base class
>>> mode_1
<UIMode.NO_GRAPHICS: ('gr',)>
>>> mode_2 = UIMode("gr")
Traceback (most recent call last):
...
ValueError: The specified value 'gr' is not a supported value of UIMode. The supported values are: 'no_gui_or_graphics', 'no_graphics', 'no_gui', 'hidden_gui', 'gui'.
>>> mode_2 = UIMode(("gr",))
>>> mode_2
<UIMode.NO_GRAPHICS: ('gr',)>
>>> mode_2.str_value()
'no_graphics'
>>> str(mode_2)
'UIMode.NO_GRAPHICS'
>>> repr(mode_2)
"<UIMode.NO_GRAPHICS: ('gr',)>"

@mkundu1 @prmukherj @hpohekar
Please could you give your perspective, thanks.

@seanpearsonuk
It should be redefined as follows - We have implemented LaunchMode in similar way.
>>>from enum import Enum
>>>class UIMode(Enum):
    NO_GUI_OR_GRAPHICS = "g"
    NO_GRAPHICS = "gr"
    NO_GUI = "gu"
    HIDDEN_GUI = "hidden"
    GUI = ""

>>>dir(UIMode)
['GUI', 'HIDDEN_GUI', 'NO_GRAPHICS', 'NO_GUI', 'NO_GUI_OR_GRAPHICS', '__class__', '__doc__', '__members__', '__module__']

>>>mode_1 = UIMode.HIDDEN_GUI
>>>mode_1
<UIMode.HIDDEN_GUI: 'hidden'>

>>>mode_1 = UIMode("hidden")
>>>mode_1
<UIMode.HIDDEN_GUI: 'hidden'>

LaunchMode
>>> from ansys.fluent.core.launcher import LaunchMode
>>> dir(LaunchMode)
['CONTAINER', 'PIM', 'SLURM', 'STANDALONE', '__class__', '__doc__', '__members__', '__module__']
>>> LaunchMode.PIM
<LaunchMode.PIM: 2>
>>> m = LaunchMode(2)
>>> m
<LaunchMode.PIM: 2>
>>>

FluentMode needs update as well.
>>> from ansys.fluent.core import FluentMode
>>> dir(FluentMode)
['MESHING', 'PURE_MESHING', 'SOLVER', 'SOLVER_ICING', '__class__', '__doc__', '__members__', '__module__']

>>> fm_1 = FluentMode.MESHING
>>> fm_1
<FluentMode.MESHING: (<class 'ansys.fluent.core.session_meshing.Meshing'>, 'meshing')>

>>> fm_2 = FluentMode('meshing')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\hpohekar\AppData\Local\Programs\Python\Python310\lib\enum.py", line 385, in __call__
    return cls.__new__(cls, value)
  File "C:\Users\hpohekar\AppData\Local\Programs\Python\Python310\lib\enum.py", line 710, in __new__
    raise ve_exc
ValueError: 'meshing' is not a valid FluentMode

If we want to use multiple values correctly then we need to install aenum package.
pip install aenum
>>> from ansys.fluent.core.session_meshing import Meshing
>>> from ansys.fluent.core.session_solver import Solver

>>> from aenum import MultiValueEnum

>>> class FluentMode(MultiValueEnum):
...     MESHING = Meshing, "meshing"
...     SOLVER = Solver, "solver"
...
>>>
>>> dir(FluentMode)
['MESHING', 'SOLVER', '__class__', '__contains__', '__doc__', '__getitem__', '__init_subclass__', '__iter__', '__len__', '__members__', '__module__', '__name__', '__qualname__']
>>>
>>> FluentMode.SOLVER
<FluentMode.SOLVER: <class 'ansys.fluent.core.session_solver.Solver'>>
>>>
>>> mode_1 = FluentMode("solver")
>>> mode_1
<FluentMode.SOLVER: <class 'ansys.fluent.core.session_solver.Solver'>>
>>>
>>> mode_1 = FluentMode(Solver)
>>> mode_1
<FluentMode.SOLVER: <class 'ansys.fluent.core.session_solver.Solver'>>
>>>

For enums which can be constructed from strings, the enum name in lowercase is the corresponding string value. So the following holds:
UIMode("no_graphics") == UIMode.NO_GRAPHICS

The RHS value is what is passed to Fluent, g or gr are not user-side strings.

Yes @mkundu1 I understand all these points. I didn't give much detail above because I thought we might need a discussion about it to get consensus on a final design. What I really wanted to get to was at the very least to eliminate exposure of the Fluent-side strings in that enum. That's one thing that makes this code confusing. Aside from that, is the UIMode("no_graphics") usage obvious at all? Irrespective of te presence of useful documentation, the code should ideally be simple self-documenting, so that the user does not have to read the additional documentation to follow the complex usage. OTOH, the current code is self-documenting something different from reality.

To have the standard syntax for enums:

uses call syntax to return members by value
uses index syntax to return members by name

we can separate the implementation details (Fluent values or the session classes) from the enum definition. Enums will be defined as:
class MyEnum(<Enum base class>):
    SYMBOL = <name or number>

The user-side code to construct enums will be MyEnum.SYMBOL, MyEnum["SYMBOL"] or MyEnum(<name or number>).

re deprecation of these, I feel that we should simplify deprecation warning messages because complicated help is often going to be insufficient. E.g. telling user to use ui_mode=UIMode.GUI where UIMode being a member of ansys.fluent.core might not be obvious


remove redundant dependency

Coverage decreased (-2.04%) to 62.072% when pulling 19f7c379752252dcd24fb3fb155f4aaff391c4b5 on ziming/fix into bab0081b567caec29c59ced6ab7d9c1f209f411d on master.

Coverage decreased (-2.04%) to 62.072% when pulling 19f7c379752252dcd24fb3fb155f4aaff391c4b5 on ziming/fix into bab0081b567caec29c59ced6ab7d9c1f209f411d on master.

Coverage decreased (-2.04%) to 62.072% when pulling 19f7c379752252dcd24fb3fb155f4aaff391c4b5 on ziming/fix into bab0081b567caec29c59ced6ab7d9c1f209f411d on master.

Coverage decreased (-2.04%) to 62.072% when pulling 19f7c379752252dcd24fb3fb155f4aaff391c4b5 on ziming/fix into bab0081b567caec29c59ced6ab7d9c1f209f411d on master.


blocker: relative paths involving parent directory in a workspace don't work when deploying to crates.io

Originally docify operated on workspace-relative paths, because this often makes the most sense when working in a large workspace. I switched this to be current-crate-relative because apparently when cargo deploys to crates.io, it completely isolates the current crate being compiled (even it if is part of a workspace) such that parent directories are inaccessible. This means any docify embeds that attempt to embed something that is relative to a parent directory of the current directory in a workspace will fail when you go to deploy to crates.io
This would be fine if we could cfg gate docify embed, but because we operate in #[doc = ..] position, this is also impossible because conditional compilation is impossible from that position. A possible workaround for this would be switching to #4 which uses an "outer attribute" approach that would allow gating docify embed such that they do not try to run during crates.io deploys. It has yet to be shown, however, whether this will still function correctly when docs.rs goes to deploy, since we've never gotten a build that far that uses parent directory relative paths.
The other potential workaround is to do a git integration as outlined in #14 and use this as a fallback for situations where the parent directory can't be accessed.
All attempts to detect whether we are cfg(doc) from within the docify::embed proc macro have also failed -- this is not detectable directly from the context of a proc macro, though this could change in the future if some of the proc macro diagnostics features get merged into stable.

Re-reading the issue again, I think the git integration is not extremely hard to do. It can use all the existing code when it comes to parsing, and just use an HTTP get instead of reading a local file as input.
@sam0x17 would be you down to implement this? This would be a huge unblocker, allowing us to publish https://paritytech.github.io/polkadot-sdk to crates.io, and get versioning in line with the polkadot-sdk stable release.
I will support the development of this with a onchain tip, in line with a /tip large polkadot-sdk tip.

Sure I think it would be quick enough that that would be sufficient, will see if I can do it tonight or this weekend


How to set pdf dpi when creating searchable pdf

I recently encountered a problem when making a searchable PDF with reportlab. I simplified the requirements as follows:
Suppose I want to put the image below as a background image in a PDF. You can simply think of this question as how to convert this image to PDF:

The image resolution is 1654×2339 and the dpi is (200,200).
Code:
from PIL import Image
from reportlab.pdfgen import canvas

image = Image.open("image.jpg")
pagesize = (image.width, image.height)

c = canvas.Canvas("output.pdf", pagesize=pagesize)
c.drawImage("image.jpg", 0, 0, width=image.width, height=image.height)
c.showPage()
c.save()

Here is the output PDF.
The problem is the size of this PDF (in cm): 58.343 × 82.505.
Normally, taking the image width (in px) as an example, the width, dpi, inch, and cm should have the following relationship (if wrong, please correct me):

Then the output PDF size should be 21.0058cm (this is also the same size if you use adobe acrobat to convert the image to PDF), but now it is 58.343cm instead of 21.0058cm. And if you calculate the dpi of the output PDF using width=1654 and cm=58.343, you can get dpi=72, not the original 200. Moreover if you use other image to test, you will find that the output dpi is also 72.
Then I look for the dpi settings in the source code, found that only renderPM.py and shapes.py contains dpi settings, the latter only contains in the comment, so the focus should be the former.
Even if I change the dpi=72 in renderPM.py to dpi=200, the output pdf remains the same.
So, how can I keep the original dpi?
Thanks.

this is an unmaintained mirror of the mercurial repository. If you have issues questions etc etc please go to the reportlab users list.


Making a new scroll-bar [GSSOC'23]

Changing the scrollbar as per the UI to give a smooth effect to it.

Hi @bishakhne0gi, could you please assign this issue to me?

@Abhirup-02 check once.

i can solve this issue can you assign me

@KAPIL9027 I saw your PR and commented on it, go check it out. As soon as the official tags are released I will assign you to this issue, so look out.

@KAPIL9027 I saw your PR and commented on it, go check it out. As soon as the official tags are released I will assign you to this issue, so look out.

@Abhirup-02, I have made the new pull request. Please check it out and tell me if you need more changes.


'opt.value.match is not a function' error when using array variable.

https://github.com/Vertamedia/clickhouse-grafana/blob/50d46ef5138f5b5d8098c1cbacc7f0d3f56e16a9/src/sql_query.ts#L548
I'm getting an error when trying to use an array variable.
My variable is called modcha and is a query variable, set up as follows.
SELECT DISTINCT [Module, Channel] FROM mydb.my_table
This works fine, and see the variables getting correctly populated [0,1], [1,1], [2,0],...
However, in the visualization, im trying to use:
... WHERE [Module, Channel] == [ $modcha ] ...
And I get the error
opt.value.match is not a function
Using grafana v6.2.5, and installing clickhouse plugin from the cli
grafana-cli plugins install vertamedia-clickhouse-datasource
UPDATE:
there's even more crazy stuff going on. if I write
... WHERE [Module, Channel] == ${modcha:json} ...
i no longer get the opt.value.match error, however the generated SQL is
WHERE [Module, Channel] == [[1,0],[1,1],[2,0],[2,1],[3,0],[3,1],[4,0],[4,1],[5,0],[5,1],[6,0],[6,1],[7,0],[7,1],[8,0],[8,1]]
i.e. its not using an element, but the whole list of modcha values.
UPDATE UPDATE:
found a problem. I had enabled the All option for my variable, hence i was seeing the whole list. Disabling the All option fixed that.
I got this to work as i wanted:
... WHERE [Module, Channel] == [${modcha:csv}] ...

@ryanmickler unfortunately, grafana 7.x broke template variables for cases when the data source plugin return each variable value as  ["string", "string"], but for grafana 6.7.x latest version of master works fine
as a workaround, we can use
using SELECT arrayStringConcat(array_field,",")  ...  for template variable  and WHERE arrayStringConcat([field1, field2], ",") IN (${variable_name})
https://clickhouse.tech/docs/en/sql-reference/functions/splitting-merging-functions/#arraystringconcatarr-separator


Missing files compared to the list Intel is distributing with the EC FW binary (Intel Kit 643307).

Hello!
Any assistance would be much appreciated.
There is currently a disparity between files used in this repo and those found in the binary provided by Intel. It seems there may have been an update that has not filtered through to GitHub. In trying to rebuild the binary using this repo code for board validation, we've found it cannot be rebuilt due to this disparity.
I have attached files with the differences below.
FileListGithub (2).txt
Thanks for your help.

Hi,
Zephyr-EC FW source code in this repo  is a select subset of features from EC FW binary distributed in Intel Kits.
The code is in this repo is tailored for evaluation purposes of power sequencing and control of few peripherals only in current supported HW (TGL + MECC) as indicated in the documentation
ADL board minimum board support will be added soon, also some additional features, but none of the updates will match the entire feature list from Intel kits.

Thanks for your help. I have found through the documentation with your help what parts of the EC FW are intended for open-source now. I will pass this information on to the relevant parties.


Row overlapping when dynamic row height or virtualization.

**I'm submitting a
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

**Current behavior**
Sometimes two row are overlapping each other while scrolling or hovering. This is happening when the `rowHeight ` is dynamic or `virtualization ` flag is `true`. I am attaching screenshots of the problem.

**Expected behavior**
Row should not overlap each other.

**Reproduction of the problem**
Visit [virtual-paging](http://swimlane.github.io/ngx-datatable/#virtual-paging) or [Dynamic Row Height](http://swimlane.github.io/ngx-datatable/#dynamic) scroll down to the end of the table then scroll up and down until it shows the mentioned problem.

**What is the motivation / use case for changing the behavior?**
<!-- Describe the motivation or the concrete use case -->

**Please tell us about your environment:**
<!-- Operating system, IDE, package manager, HTTP server, ... -->
Windows 10
Node: 8.11.2

* **Table version:**
<!-- Check whether this is still an issue in the most recent table version -->
14.0.0

* **Angular version:**
<!-- Check whether this is still an issue in the most recent Angular version -->
Angular CLI: 6.1.4
Angular: 7.0.1

* **Browser:** [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
Chrome
<!-- All browsers where this could be reproduced -->

* **Language:** [all | TypeScript X.X | ES6/7 | ES5]
TypeScript

![screenshot 37](https://user-images.githubusercontent.com/18557453/48415073-6618f600-e772-11e8-913f-d6c37ad47536.png)
![screenshot 38](https://user-images.githubusercontent.com/18557453/48415074-6618f600-e772-11e8-80a0-71de63940655.png)

Looks to be the same issue described in this other issue.
Duplicate of #1594

Okay. The title is misleading so I didn't if this Issue was created before. :')
So this is a problem of Chrome not ngx-datatable?
Thanks for your quick reply BTW.

I've only been able to produce the issue on Chrome. IE and Edge both render correctly.  I agree title in the other bug could have been more descriptive of the issue.

@pwinstead I guess we will see if the issue is because of Chrome's new update or ngx-datatable. Thanks for your valuable info. 👍

I've posted a potential workaround for this here.

@mfjharvey Thanks for your reply. I have used your patch with a different class and now the problem seems to be reduced as it still overlaps for a fraction of a second. I am posting my answer here for future visitors.
 .datatable-body-cell {
     will-change: transform;
}


Fix 'invalid HMAC key' error for buffers

Problem: Previous versions of this module allowed HMAC keys as buffers,
but there weren't any tests or documentation which meant that they were
eventually broken.
Solution: Add a test to identify the problem and fix the HMAC key
validation function to ensure that it validates HMAC keys that are
expressed as buffers.
Fixes: https://github.com/ssb-js/ssb-validate/issues/23

I can confirm that this does fix the problem as described in #23. Thanks @christianbundy for fixing this and to @regular for reporting.

For some reason I am unable to publish this to npm:
npm ERR! code E404
npm ERR! 404 Not Found - PUT https://registry.npmjs.org/ssb-validate - Not found

Thanks @arj03 and @regular.
Are you arj03 on npm? You should be an owner of the SSB-JS org. Sorry if I've screwed something up, I'll investigate on Monday when I'm back at my computer. If there are any actions I need to take please let me know. Not sure why it isn't letting you publish. :/

Nevermind, I logged in again from console and now it is published :rocket:


Create bodhi update via Packit for completed Koji builds

Signed-off-by: Frantisek Lachman<EMAIL_ADDRESS>
N/A

/packit build


Make passWithNoTests default to true in watch mode (#4722)

Summary
This attempts to fix #4722  by making passWithNoTests default to true in watch mode
Test plan
Added new test in watch.test.js - 'passWithNoTest should be set to true in watch mode'

Thanks!

Happy to contribute :)


Add support for list items gravity

There is no way to control the list item's gravity, can you please add support for it?

This is implemented for the next release

https://github.com/afollestad/material-dialogs/releases/tag/v<IP_ADDRESS>


add objects.exclude

Ref: #14

I'm going to merge this as-is but after some thought I think there is room for improvement for this and object.include.
Instead of relying on an inner reduce to check the 'filter' array. The 'filter' array can be transformed into a set and the item can be looked up using filterSet.has(item) instead.
Set is a hash-based data structure, with O(1) read complexity as opposed to reduce which is O(n). Meaning this modification will reduce the overall complexity for this function from O(n²) to O(n).


the minX mustn't equal maxX and the same as minY&maxY value

initPos = self.current[0]
minX = initPos.x()
minY = initPos.y()
targetPos = self.line[1]
maxX = targetPos.x()
maxY = targetPos.y()
self.current.addPoint(QPointF(maxX, minY))
self.current.addPoint(targetPos)
self.current.addPoint(QPointF(minX, maxY))
self.current.addPoint(initPos)
self.line[0] = self.current[-1]

Please elaborate on what you're trying to do.


SW-5499 Endpoint to update variable workflow details

Add an internal-user-only endpoint that updates the workflow details for a
variable in a project.

Merge activity

Jun 25, 1:02 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.


Ability to hook in commands

Hey, loving the good work. I'm looking to try and get this running with our workflow.
Right now each repository contains a file which denotes the semver. It looks something like this.
major: 1
minor: 2
patch: 0
(etc)

Each time we create a PR we have the ability to update this file. Most of the time it's always updated, but if you're making a minor change, or working together there's no reason to update the semver. There is a ruby gem we run along the lines of semver inc minor which increments the versioning.
Requirement
When NuKeeper runs, I'd like a way to be able to run a command (like updating that file in the repo) before pushing the files up to a new PR.
Proposal 1 - The quick-n-dirty workaround - Execute custom script before PR creation
All I can see for now is running nukeeper repo (etc) but this command does not let me call out to change this file, or hook in another command. Does anyone have suggestions for this? To move me along I could put a prebuild task in to increment the build then as the nukeeper repo command runs it could call out to a .bat or .pr1 or whatever. I understand you are trying to keep this cross platform.
Changes here:

Ability to hook into and run random file after git pull, and before git PR creation

Proposal 2 - Update nukeeper update and create new command to push
Another approach I could think of would be to have a nukeeper update command do the update in the local file system, then I update the semver (through whatever means), then have a new command similar to nukeeper push. This would need a few changes. Right now the PR comment cannot be extracted, and is different from the -o output file from the nukeeper update command. It would be awesome if that could be output to a file by command line.

nukeeper update would ideally create a .md file of the changes
the ability to step out of the NuKeeper lifecycle and hook something in here (.bat, .ps1, .sh, etc.)
A new command like nukeeper push to do the work the push part of nukeeper repo command does, taking in the .md file for changes

I hope that makes sense!

Proposal one is very possible, Running commands is something that NuKeeper has done right from the start -  it shells out to dotnet and/or nuget.exe. Getting a good design is important though. I have 2 suggestions here:

Convention NuKeeper could locate files in the root of the repo that match a certain spec and execute them just before making the PR.  e.g. NuKeeperBeforePullrequest.(bat|ps1|sh). The problem is, what if you have one for linux and one for windows? It's hard to tell which should be run. it's not simple, there is powershell on linux and bash on windows.

Configuration A commandline option e.g. --BeforePullRequestScript .\BeforePs.ps1 to specify a path to a script (relative to the repo root). This puts more complexity on the commandline, and it's up to you to be sure that your script can run (e.g. if it needs ruby then the machines should have ruby).

In both cases, would the script be given data from nukeeper as args?

Thanks for getting back to me.
I think I'd prefer configuration over convention here, I prefer your second proposal (but still happy for either).
I wondered if passing in another dotnet tool command plus arguments? Would that be more compatible? It sounds unnecessary. If the file is in my local folder, then I can write whatever I want into it and just use it as a hook, so no preference.
Agree with your point it's up to me to make sure the  call will run (Ruby etc.).
In my case I need to manipulate files in the PR before it is sent up, so I'd also need access to the files. So nukeeper would run the first half of the process, call my hook, let me modify the file, then send nukeeper changes + my changes in the PR. Happy for it to be a second commit on the PR for clairty.
I think that will be today's workaround, grepping the output and working out where the PR is the using git commands to update the file and push a second commit, downside is two CI builds.
RE passing data to process - Personal preference would be to dump out variables into a file (optionally, flaggable) so I can get more information about the nukeeper state, but wouldn't need this at this point in time.


Issue with latest Docker release 4.27.1

Version of Warden
0.14.1
Operating System and Installation Method
Mac OS 14.3
Image
docker.io/wardenenv/varnish:7.1
Describe the Bug
After updating docker to the latest version 4.27.1 which was released just yesterday, the warden env up command shows below error:

validating /usr/local/Cellar/warden/0.14.1/environments/includes/varnish.base.yml: services.nginx.labels array items[2,7] must be unique

This happens with all old docker environments with the latest version of docker.
I have then downgraded docker to my previous version(4.26.1), which was working fine without any error.
To Reproduce

Update docker to latest version 4.27.1
Run command warden env up on the existing environment
Show error validating /usr/local/Cellar/warden/0.14.1/environments/includes/varnish.base.yml: services.nginx.labels array items[2,7] must be unique

Expected Behavior
Warden should work with the latest version of docker.
Additional context
Note: This is working fine with the old docker version (4.26.1)

See https://github.com/wardenenv/warden/issues/739.

Hi @sprankhub Thanks for your comment.
As per the comment: https://github.com/wardenenv/warden/issues/739#issuecomment-1916884744 The Issue is still with the latest version(4.27.1) of docker desktop mac. And the temporary work around to downgrade the docker desktop to 4.26.1.
The latest version of docker has too many updates. It would be good if we could fix this conflict with the warden.

The issue will be fixed very soon in Docker Compose. There is no need to fix this in Warden, it is clearly a Docker Composer bug. For the time being, feel free to use one of the workarounds.

Problem solved https://docs.docker.com/desktop/release-notes/#4272

Great. Thanks, @DanielJakubowiczStrix for the update.
Have you tried the latest version of the docker?

Yes, everything works fine.


Confusion over AAD Requirement

This page: https://docs.microsoft.com/en-us/azure/marketplace/marketplace-what-is-appsource
Says that Active Directory is preferred but the above documentation says it is required. Which one is correct?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7733e992-48c0-0f31-d9c4-8303064d63cc
Version Independent ID: 609d9b6e-03d6-a8d8-3b86-6ca7021dba44
Content: Azure Marketplace and AppSource publisher guide
Content Source: articles/marketplace/marketplace-publishers-guide.md
Service: marketplace
Product: unspecified
GitHub Login: @ellacroi
Microsoft Alias: ellacroi

@nastassiar Thanks for bringing this to our attention. Your feedback has been shared with the content owner for further review.

@ellacroi please-close

#please-close


Remove all manifests in parallel

This will make it so eastwest gateway is removed in parallel. This
doesn't impact CI much, but on GKE it takes ~1min to remove a LB service so
this makes the cleanup 1min faster
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
557edbce73f5b32eaa8afc97c401d68a14e98005
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


64-bit word literals are parsed incorrectly on 32-bit systems

Version
110.99.3 (Latest)
Operating System

[ ] Any
[X] Linux
[ ] macOS
[ ] Windows
[ ] Other Unix

OS Version
No response
Processor

[ ] Any
[ ] Arm (using Rosetta)
[ ] PowerPC
[ ] Sparc
[X] x86 (32-bit)
[ ] x86-64 (64-bit)
[ ] Other

System Component
Basis Library
Severity
Major
Description
Bits 30 and 31 of 64-bit word literals are lost on a 32-bit machine.  The problem occurs with version 110.98.1 and later.
Transcript
Standard ML of New Jersey (32-bit) v110.99.3 [built: Tue Oct 18 00:40:03 2022]
- 0wxFFFFFFFFFFFFFFFF : Word64.word;
[autoloading]
[library $SMLNJ-BASIS/basis.cm is stable]
[library $SMLNJ-BASIS/(basis.cm):basis-common.cm is stable]
[autoloading done]
val it = 0wxFFFFFFFF3FFFFFFF : Word64.word

Expected Behavior
No response
Steps to Reproduce
0wxFFFFFFFFFFFFFFFF : Word64.word
Additional Information
No response
Email address
<EMAIL_ADDRESS>

Note that this is an issue with the 32-bit version of SML/NJ; it is not present in the 64-bit version.

I found another issue with string matching, also only affects 32-bit, and also started in 110.98.1:
fun f "abcdefg" = true
  | f _ = false;
f "abcdefg";  (* ok *)
f "abcdef_";  (* bad *)
f "abcde__";  (* bad *)
f "abcd___";  (* bad *)
f "abc____";  (* ok *)

Looking into it further, I think I've found the root cause of both this and the original issue.
base/compiler/CPS/opt/streqlcnv.sml:
    val wordSzInBytes = if Target.is64 then 8 else 4
    val bytesToWords = if Target.is64
	  then (fn n => Word.toIntX(Word.>>(Word.fromInt n + 0w7, 0w3)))
	  else (fn n => Word.toIntX(Word.>>(Word.fromInt n + 0w7, 0w3)))

The last line wasn't updated for 32-bit.

Thanks for the pointing out the source of the problem.  I have committed a fix for 110.99.4.


Incorporate Unity 2017.3b assembly definition files into projeny logic

This seems like it could be very interesting for use in Projeny:
https://blogs.unity3d.com/2017/11/22/unity-2017-3b-feature-preview-assembly-definition-files-and-transform-tool/

Hey @svermeulen!
Any updates on this?

Not yet no, but I really want to do this.  It would fit in perfectly with the way projeny is designed.  I am hoping to have more time soon

Thank you for the quick reply!
Would you mind sharing what parts would fit in about where?
I would like to delve into it myself as well, but wouldn't know where to start at the moment.

I can help with this.
What I'd love to see is a hybrid where Projeny still dynamically swaps in/out packages with dependencies taken into account, but also generates .asmdef files for imported packages.
I recommend this approach:
Create a .asmdef file at the root of the package folder
Create a .asmdef file at the sub-Editor folder, and, importantly, from here move any other deeper Editor folders in the tree to be children of that first root Editor folder.  Mirror the original directory structure for clarity.
Why?
Because A) Generating a separate assembly for every sub-editor-folder would defeat a lot of performance gains,
and B) I've seen two Editor folders in completely different directory branches reference classes in eachother.  Since you can't have circular dependencies, this seems like the way to go.
If there are no editor folders, fine, that's the end of it.  If the user ever adds any, then gen the stuff above.
Another awesome feature would be to search for matching file guids in existing projeny packages when you import a new one, and weld together already-imported stuff to avoid duplication and losing references to stuff.

B) I've seen two Editor folders in completely different directory branches reference classes in eachother. Since you can't have circular dependencies, this seems like the way to go.
I second this. I've seen something very similar just a couple days back.

The problem right now is that I want to make a big change first before doing smaller changes like this one or others.  The big change is that I want to port all the python to C# to simplify the implementation and also to make it cross platform.  This project started as literally just a simple python script that set up directory junctions and then just grew over time from there, so the C# unity editor functionality was added later, and now it's very clunky the way the python and the C# interact
So it might be a bit pointless to do work on this bug now since any work would have to be done again after this larger refactor is completed.
My free time outside of work is spent on the next version of Zenject at the moment, so I can't start on this refactor yet until that's finished.  But if either of you or anyone else want to help with the C# refactor that would work

Actually, depending on how much work it is to generate those asmdef files, it might not be such a bad idea to just add it to the current python implementation.  So if you want to take a look at doing that, that would work too.  Since it will probably be a couple months before the refactor to c# is ready


express-session deprecated undefined resave option

While starting my app I get some deprecated warnings... any idea?
express-session deprecated undefined resave option; provide resave option at node_modules\express-socket.io-session\index.js:66:7
express-session deprecated undefined saveUninitialized option; provide saveUninitialized option at node_modules\express-socket.io-session\index.js:66:7
express-session deprecated req.secret; provide secret option at node_modules\express-socket.io-session\index.js:66:7

$ node -v
v0.12.7

$ npm -v
2.11.3

package.json
{
  "name": "messaging",
  "version": "0.0.0",
  "description": "This is a proof of concept for messaging",
  "homepage": "https://github.com/baby-click/messaging#readme",
  "author": "Aurelius Wendelken",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "repository": {
    "type": "git",
    "url": "git+https://github.com/baby-click/messaging.git"
  },
  "bugs": {
    "url": "https://github.com/baby-click/messaging/issues"
  },
  "license": "MIT",
  "dependencies": {
    "body-parser": "^1.14.1",
    "compression": "^1.6.0",
    "cookie-parser": "^1.4.0",
    "debug": "^2.2.0",
    "express": "^4.13.3",
    "express-session": "^1.12.1",
    "express-socket.io-session": "^1.3.1",
    "jade": "^1.11.0",
    "method-override": "^2.3.5",
    "mongoose": "^4.2.5",
    "morgan": "^1.6.1",
    "socket.io": "^1.3.7"
  }
}

Hi, this is specific to recent versions of express-session. You have to
explicitly pass the resave option to true or false on initialiazation.
On Sun, Nov 15, 2015, 5:28 PM Aurelius Wendelken<EMAIL_ADDRESS>wrote:

While starting my app I get some deprecated warnings... any idea?
express-session deprecated undefined resave option; provide resave option at node_modules\express-socket.io-session\index.js:66:7
express-session deprecated undefined saveUninitialized option; provide saveUninitialized option at node_modules\express-socket.io-session\index.js:66:7
express-session deprecated req.secret; provide secret option at node_modules\express-socket.io-session\index.js:66:7
$ node -v
v0.12.7
$ npm -v
2.11.3
package.json
{
"name": "messaging",
"version": "0.0.0",
"description": "This is a proof of concept for messaging",
"homepage": "https://github.com/baby-click/messaging#readme",
"author": "Aurelius Wendelken",
"main": "index.js",
"scripts": {
"test": "echo "Error: no test specified" && exit 1"
},
"repository": {
"type": "git",
"url": "git+https://github.com/baby-click/messaging.git"
},
"bugs": {
"url": "https://github.com/baby-click/messaging/issues"
},
"license": "MIT",
"dependencies": {
"body-parser": "^1.14.1",
"compression": "^1.6.0",
"cookie-parser": "^1.4.0",
"debug": "^2.2.0",
"express": "^4.13.3",
"express-session": "^1.12.1",
"express-socket.io-session": "^1.3.1",
"jade": "^1.11.0",
"method-override": "^2.3.5",
"mongoose": "^4.2.5",
"morgan": "^1.6.1",
"socket.io": "^1.3.7"
}
}
—
Reply to this email directly or view it on GitHub
https://github.com/oskosk/express-socket.io-session/issues/12.

Thanks for quick reply, you may want to close this issue.

I suggest adding this to a FAQ of some sort then.

Thans @dodekeract. I'm sorry for the delay on my reply.
I like the idea of having a FAQ. The thing is that this express-session behaviour has been like this since about mid 2014 , that is when Express 3 was still around approximately.
I tried to explicitly put the resave and saveUninitialized options in the snippets shown on the README.md.

Hi, I have this same problem but, I didn't understood how do that: "You have to
explicitly pass the resave option to true or false on initialiazation."
Please, may you put an example here? I show you my code:
//SESSION CONFIGURATION
//SOCKETS SESSION CONFIGURATION
var ssio = require('express-socket.io-session');
//APP SESSION CONFIGURATION
app.use(cookieParser("secretSign#143_!223")); // required before session.
app.set('trust proxy', 1) // trust first proxy
app.use(session({
    name: 'sessionId',
    store: new redisStore({host: 'localhost', port: 6379, client: redisSt}),
    secret: "e1a8Bc38cc",
    resave: true,
    saveUninitialized: false,
    cookie: {
        //secure: true,
        httpOnly: true,
        maxAge: 10000 },
    rolling: true
}));

//SOCKETS
var io = require('socket.io').listen(server);
io.use(ssio(session, {
    autoSave : true
}));

@dogui1718 your code looks find and it's providing those initialization options @webtobesocial  mentioned. So I don't see how you're getting the same warnings than him

Hi I am getting the same error as @dogui1718 . Do you have any bug fixes for this please?

Hi I am getting the same error as @dogui1718 . Do you have any bug fixes for this please?


Electric plug

[x] Purchased
[x] Received
[x] Checked

"The power output is DC, please pay attention to the direction the cable is plugged in"
What am I gonna do? Not plug a USB in right?


AUI-1940 - make date validator accept brazilian format dd/mm/yyyy

Just started reviewing :) :octocat: Sent from GH.

Pull request submitted to https://github.com/linolaoj/alloy-ui/pull/1. See changes here. :octocat: Sent from GH.

@linolaoj , I sent to you a pull request with a source formatting. Could you please add a test case for your changes and rebase with master?

Hi @thiago-rocha  , new pull request with tests and source format https://github.com/thiago-rocha/alloy-ui/pull/15


Switch theme based on system preference

Feature suggestion

Kore could check the system-wide preference for dark theme/mode and select a light/dark theme accordingly.
Context

Since Android 10, users can use a system-wide dark mode toggle. This helps with eye strain at day and night.
Possible Implementation

As Kore has multiple themes, a selection menu for both light and dark mode would be nice.
Alternatively, we could "sync" light and dark themes so only the background color and text is switched, but the contrast/2nd colors stay the same. Then a simple toggle to switch on/off auto-switching themes is sufficient. The existing theme picker will allow users to select one theme that is used (with a light and dark variant).

Done.


Can't start email address with underscore

Unlike your demo, I can't start an email address with and underscore. I can however, type any other character then move cursor to beginning of line and type an underscore. Have you experienced this behavior before?

@anthonyartese It doesn't work because the underscore is set as the placeholder character.  If you change the placeholder character to something else (like \u2000, for example), then it should allow you to type an underscore..


token-2022: overwrite with init_extension using default state

As discussed in this thread https://github.com/solana-labs/solana-program-library/pull/2743#discussion_r785221520, this PR explores overwriting any existing data for an ExtensionType when init_extension() is called, using Type::default(). This enables future extensions to be initialized with non-zero default data.
@joncinque wdyt?
This is still marked as draft because of the default() implementation. I think ideally Extension becomes trait Extension: Pod + Default, but the ConfidentialTransfer state structs will need to have Default impl first. At a glance, it looks to me like it would be okay to add a Self::zeroed() default to each of those structs, but need to confirm with @samkim-crypto

Yes, it looks good to me. Implementing Default for the confidential transfer state structs with Self::zeroed() is good.
Maybe implementing Default for the ElGamal and authenticated encryption structs in the zk-token-sdk PR #22532 and deriving it for the state structs here may be cleaner.

Maybe implementing Default for the ElGamal and authenticated encryption structs in the zk-token-sdk PR #22532 and deriving it for the state structs here may be cleaner.

Yes exactly, thank you!


Render masked female clothing variants

TG uses a few simple masks to touch up the clothing sprites to better fit the female body sprites they have, so they're actually distinct.
We need to implement this.
There's two possible approaches here. Both will require engine changes of different degrees:

Do masking with a shader. This is really problematic because the mask will have to be a shader uniform *but also dependent on orientation of the sprite. This makes it for all intents and purposes impossible with SpriteComponent. Since SpriteComponent is the only real way to render entities... we'll need some way to do custom drawing on entities. This could probably be worked into Clyde I guess?

Do masking ahead of time on the CPU. This will require a mutable in-memory RSI data class so that we can stitch them all correctly, but is otherwise free of any serious complexities.

This was implemented.

This was implemented.


Does't work since the last Discord update

Plugin no longer works since the last discord update.

Fixed by 24cbd9b2a05c4d703494ee103c38440727305c02. Also make sure you are using the latest version of 0PluginLibrary.plugin.js.
Let me know if you encounter any more issues.


Pixhawk 2.1 IMU Heater Support

With current PX4 master the sensors reach exceed 70s during bench testing.

how was this resolved?

@kd0aij Disabled on pixhawk 2.1 here - https://github.com/PX4/Firmware/pull/5964
Interested in adding a simple controller to maintain sensor temperature?

I'm a bit confused about the state of this. Is the heater currently hard on or disabled for pixhawk 2.1 cubes?

Completely off. The unit heats up by itself fairly quickly.

It was added as an experiment by the designer. We are not using one in designs that are in mass-manufactured drones. We do use temperature calibration through extensively.

The heater is used to set the IMU’s to their optimal temperature for operation.
This is used within other flight controller stacks very successfully.
When flying in extreme cold temperatures, it allows for setting an optimal temperature for operating, regardless of any additional temperature compensation.
This was not an experimental feature, this was a requirement of design. And though I respect that PX4 has chosen to go for compensation tables, gyro noise cannot be compensated for outside the recommendations of the manufacture... therefore I would still recommend that the heater is used by PX4 to set a minimum viable temperature, and also, as recommended by Paul R, a method for doing a full range temperature compensation setup.
Of course, this is 100% up to the PX4 team.

@dagar
We have discovered that the heater is not 100% off as of 1.8.2 firmware. PX4 sets the io pin to be OPEN_DRAIN, and then sets it high, which leaves the heater control pin floating. Because of interactions with the resistor network and the transistor that powers the heaters, the heat is on a small amount, that gets worse as temperature increases.
By disabling the green "RING" LEDs and changing the drive pin for the heater to PUSH_PULL and setting to high, we get the heater to turn completely off. Both that it was partially on and that this fix turned it all the way off were experimentally measured on 2.1 hardware.
With lights off and the heater completely off, we've seen 20-25C drop in sensor temperatures inside the cube. We had to make this change because we were pushing sensors out of spec at only 45-50C ambient. We can now calibrate to almost 60C ambient without pushing sensors past absolute operating max, and still have a little headroom. The MPU9250s get hotter than anything else, presumably because they are self-heating somewhat, but they also have a 105C absolute max operating that we do not exceed while doing temp calibration.

Thanks for raising that @jzazbert. Let's get a fresh issue going to make sure there's no problem before v1.9.0 goes out.


Address #362

Also, there was no TextEdit.is, which I also added.
Currently, this build fails. If the types package is published, we can remove the definitions in protocol/src/protocol.colorProvider.ts and use the ones shipped in vscode-languageserver-types.

@aeschli can you please review and merge.


@conda-forge-admin, please add bot automerge

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/dash-bio-feedstock#2.


Feature - Add type prop to Breadcrumb component

For colored breadcrumbs.
Add prop type based on existing theme.

Can you assign me? xD


Issue-446 Allow a user to retrieve the allocated port the server is r…

…unning on
When writing tests, I don't want my test to fail if the port I want to run Spark on is used by an other program.
Thus, I need to use a random port for Spark.
However, I have no mean to retrieve it from my code, making the server impossible to test.
Related to https://github.com/perwendel/spark/issues/446 and https://github.com/perwendel/spark/issues/400
The basic idea behind this PR is that the Embedded server should return the port it was effectively launched on. Hence we can retrieve the allocated port without changing the logic.

any ideas regarding when this is going to be merged?

There is one huge flaw with this PR. You still need to assign a port number or its going to fail running 2 instances of Spark. All this has really added is a couple of methods to retrieve the port number. Personally I don't see why this is needed?

If you don't want your tests to fail because the SUT can't allocate the port to listen on, then test if it can be allocated before you start testing.

I take back my other comment. (It was late for me). I agree fully with this PR and should be merged.

@ruurd : I do not understand your last comment. How can I modify it to match your needs ?

@chibenwa in other words - before you start testing see if the port in question is allocated or not. If not, test, if taken, fix first. In general testing should be done in a known environment.

While I in principle agree with @ruurd here, I think "an available port assigned by the underlying implementation" is known enough, and most of all, convenient.

I changed from getPort() to port() before merging!

Anyone had any luck using this? It seems the port is never returned back to Service from ignite() because server.join(); is waiting for all threads to finish...

@lyonzy is right. See #714.


missing F-P link annotation

http://www.ebi.ac.uk/QuickGO/GTerm?id=GO:0008233#term=ancchart has an F-P link to proteolysis
erm1 has proteolysis annotation on www (currently) from UniProtKB-KW:KW-0645.
I filtered the mapping so this annotation should disappear on stage (it has), but it should be replaced by an annotation derived from the F-P link (it hasn’t). Can anyone figure out why?
Original comment by: ValWood

opened https://github.com/geneontology/go-annotation/issues/1336


Oracle APEX 21.2.0 does not open camera plz help

i am use oracle apex 21.2.0, plugin does not working

Already Its working fine,
Please check at your end and follow the steps in propper way..
If you are still facing issue plz share error with screen shot.


"window is not defined" error with React / Next.js

Please follow the general troubleshooting steps first:

[X] You are using the latest version
[X] You are testing using the non-minified version of html2canvas and checked any potential issues reported in the console

Bug reports:
I'm attempting to use HTML2Canvas in a React app that's built atop Next.js. It seems to be having trouble with the global window variable, which is odd since I'm only importing it in the client side of the app. Here's the code:
// Module Imports
import React, { Component } from 'react';
import PropTypes from 'prop-types';
import html2canvas from 'html2canvas';

// Save function
  handleSave = async () => {
    const { chart } = this.state;
    const { updateChartFunction } = this.props;
    // capture screenshot
    const input = document.getElementById('chartScreenshot');

    html2canvas(input, {
      useCORS: true,
    }).then(canvas => {
      const imgData = canvas.toDataURL('image/png');
      console.log(imgData);
    });

    await updateChartFunction({ variables: { ...chart } });
  };

Here's the error:
ReferenceError: window is not defined
    at \repo\client\node_modules\html2canvas\dist\html2canvas.js:6873:29
    at \repo\client\node_modules\html2canvas\dist\html2canvas.js:7:85
    at Object.<anonymous> (\repo\client\node_modules\html2canvas\dist\html2canvas.js:10:2)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.html2canvas (\repo\client\.next\server\static\development\pages\editchart.js:3149:18)
    at __webpack_require__ (\repo\client\.next\server\static\development\pages\editchart.js:23:31)
    at Module../components/EditChart.js (\repo\client\.next\server\static\development\pages\editchart.js:457:70)
    at __webpack_require__ (\repo\client\.next\server\static\development\pages\editchart.js:23:31)
    at Module../pages/editchart.js (\repo\client\.next\server\static\development\pages\editchart.js:2760:79)
    at __webpack_require__ (\repo\client\.next\server\static\development\pages\editchart.js:23:31)

And here's the offending line in /dist/html2canvas.js:
    CacheStorage.setContext(window);

I'm absolutely open to the idea that I'm doing something incorrectly or that "this just doesn't work with Next.js" but I'm hoping there's an obvious solution someone knows of!
Specifications:

html2canvas version tested with: 1.0.0-rc.4
Browser & version: Chrome Version 76.0.3809.132 (Official Build) (64-bit)
Operating system: Windows 10

Same issue. I am stuck with this for days now.
Tried with different approaches like
const html2canvas = process.browser ? require('html2canvas') : null;
Not able to get it wokring.

@cwbuecheler,
As you are using next.js
https://stackoverflow.com/questions/55151041/window-is-not-defined-in-nextjs-react-app
and
https://github.com/zeit/next.js/wiki/FAQ#i-use-a-library-which-throws-window-is-undefined
will help you.
I am using nodejs for my ssr app, so not sure how to fix that.

@subhendukundu - thanks. That kind of helps, though unfortunately the error is occurring on the import, not on any usage (even if I put the usage in componentDidMount), so I have to find a workaround for that. I have one, using require instead of import, but that's not my preferred approach. I'll keep working on it, but it'd be nice if html2canvas eventually had some failsafes built in relating to this issue.

Should be fixed with #2039

what version is this included?

Which release fixes the issue?

This issue is still happening in Node application...

does this fix exist in  1.0.0-rc.5 ? I'm still having this issue.

only that it's
 componentDidMount() {     this.html2canvas = require('html2canvas')   }

still happening with node 12

only that it's
 componentDidMount() { this.html2canvas = require('html2canvas') }

this solution works for me on latest nextjs and html2canvas


babel-plugin-jest-hoist complains about typescript types

🐛 Bug Report
Basically, i get the error
babel-plugin-jest-hoist: The module factory of `jest.mock()` is not allowed to reference any out-of-scope variables.
    Invalid variable access: ReturnType

but ReturnType is a built-in typescript type. It's not out of scope.

To Reproduce
Steps to reproduce the behavior:
use a mock like this
import { mockedFunction } from 'mymodule'
jest.mock('mymodule', () => {
  return {
    mockedFunction: jest
      .fn<ReturnType<typeof mockedFunction>, Parameters<typeof mockedFunction>>()
   }
})

Expected behavior

It shouldn't complain!
Link to repl or repo (highly encouraged)

envinfo

Note that it happens on CI (using yarn --frozen-lockfile tho), so this is the best we'll get
  System:
    OS: macOS Mojave 10.14.6
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
  Binaries:
    Node: 12.18.3 - ~/.nvm/versions/node/v12.18.3/bin/node
    Yarn: 1.22.4 - ~/.nvm/versions/node/v12.18.3/bin/yarn
    npm: 6.14.8 - ~/.nvm/versions/node/v12.18.3/bin/npm
  npmPackages:
    jest: ^26.4.2 => 26.5.3

Hmm, it shouldn't complain, we blacklist TSTypeReference
https://github.com/facebook/jest/blob/e84a70c8456d61daa36b5c79a4df7ee752d6d6d6/packages/babel-plugin-jest-hoist/src/index.ts#L93
I also cannot reproduce this locally. Can you put together a repository showing the error?

I've got a reproduction repo set up. I didn't set up the babel config in the project where this happened, but my guess is that something in there is conflicting, just a matter of figuring out what it is

Yeah, it's probably that. It pulls in an old version of the plugin: https://github.com/forivall/jest-10636-repro/blob/0f3fb3c4d1753ecd5799cf03aabd01adb91bf1d5/yarn.lock#L1750
babel-jest has been Babel@7 natively since v24 (about 2 years) and v21 supported it via the babel-core@bridge package

Yup, that was it! moving to current babel-jest solves it, and there wasn't any particular reason why babel7-jest was used.


Release Google.Cloud.BigQuery.AnalyticsHub.V1 version 1.6.0

Changes in this release:
New features

Add properties for nested resource name references (commit 15eec4d)

Created release for Google.Cloud.BigQuery.AnalyticsHub.V1-1.6.0


Custom Bucket Rendering

Package version (if known): v2.2.5
Describe the bug
I'm not sure whether it is justified to file a bug in this regard, but there seem to be a mismatch between documentation and code, which might be easy to fix. While evaluating react-searchkit for our purposes, I arrived at the point where I wanted to customize bucket rendering to support enhanced aggregations (namely ISO-date-time ranges). I've checked this documentation page and was a bit disappointed that in the "Usage when overriding" section no implementation for BucketAggregationContainer  and MyBucketAggregationValues could be found, not even a very basic one.
So I decided to work with the elasticsearch demo, as it should contain an example for that scenario. Unfortunately, I realized, that the demo uses the properties 'renderValuesContainerElement' and 'renderValueElement' of BucketAggregation instead, which seem to be not available in version 2.2.5 anymore (I found them in version 1.X).
Now I'm wondering if it would be possible, to provide an easy example based on the demo code, which is working with the current version?
Many thanks in advance.

The BucketAggregationContainer.element takes only one param valuesCmp (see source code here): it is useful when you need to override the default HTML content of the container containing the list of buckets.
Indeed, the documentation should describe an example, we will fix that.


Fix required modes improperly set to "WARP with Gateway"

Local Domain Fallback works in either WARP with Gateway or WARP with DoH modes. In either case, the local DNS server can change where the DNS lookups are sent.
You can mode switch no matter which mode you are in
We do captive portal detection in both modes

Updated the modes in #6789


ctrl + w / ctrl + a / deally all keymaps should be configurable

[x] I am on the latest Hyper.app version

[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: GNU/Linux 4.9.24 with grsecurity

Hyper.app version: 1.3.3

Link of a Gist with the contents of your .hyper.js: https://gist.github.com/orangecms/f7ccf196e85698cf35a01130ef7c2b8f

Relevant information from devtools (CMD+ALT+I on Mac OS, CTRL+SHIFT+I elsewhere):

(re)loading renderer plugins
total init time 1634.5550000000005

The issue is reproducible in vanilla Hyper.app: yes :cry:

Issue
I have a serious problem. I'd usually just use a pure tty. But I am a web developer, so I work on an actual desktop. I tried this awesome terminal emulator, and I love the hyperpower plugin. It reminds me of activate-power-mode, which I used in Atom. Now I switched to Vim, and I need the ctrl + w keybing there for switching between the panes. Aside of it, I use tmux, and in tmux as well as some other tools like screen and minicom, I need the ctrl + a keybinding. They are being used, however, by Hyper. I couldn't find an option to disable them. I tried the modifierKeys options to fix that, but it didn't change anyhitng. :/
Addendum:
I did see other issues raised around keymaps. They are close to what I would prefer, but not fully. I am trying to run from the current master branch, but the build process is very complicated. I would prefer to just have a tiny bundle (not 350MB, rather like 20MB max) that I can just run with Electron, and build everything from source. I am building Electron from source as well, and I have a Makefile in progress for Hyper.

See https://github.com/zeit/hyper/pull/1876. :smile:

Default keymaps have changed to prevent shell and command line conflict 🎉
You can use build from CIs if you want to test master.
Really curious about your Makefile. I think I missed the point.
I'm closing this issue but we can continue to discuss here


ng:submit still submits the form! So you need onsubmit="return false;" on all your forms. Icky.

ng:submit should cancel the form submit if the action is not set or empty.

this got fixed long time ago


Fixup .sublime-project key

The project key is wrong.

What effect does this change have? I am not familiar with sublime-package files. (is there any dokumentation?)

Those are json schema files that are used by https://github.com/sublimelsp/LSP-json to provide validation and completions for various configuration files in Sublime, including in preferences, project-specific settings, keybindings etc...


Mess with reprint of price of product on product page

I am using Themekit template theme 1.0.0 on my Shopify store. I am facing a bug on my product pages.
Bug:
On my product page, clicking on the variant options reprints the price and compare at price. Let me share a GIF for a better explanation:

You can also experience it by yourself using this product page link: https://bit.ly/2P0hHm4
In the GIF, you can clearly see that when i click on the colors, it reprints the price and compare at price and create a mess.
Kindly resolve this issue as soon as possible.

We are using this Shopify. We also face the same issue. Theme support can fix this ASAP?


Support parent project buildVerson in build.gradle

When defining the default version, should also support the build version of the parent project.

I'm waiting for this to be deployed too? Any updates?

@derekmisler unfortunately I cannot get a slot to work on this due to my current schedule. I gave you write access as a collaborator. Please ping me once I can make a release in npm and I'll gladly do it. Thanks.

@derekmisler @alvaromb guys?

Sorry, guys, I must’ve missed that notification from GitHub because I ended up going in a totally different direction. I’ll see what I can do about testing and merging this this weekend


RTK keeps absolute paths to source/build location when ITK is installed

I have built ITK 5.1.2 from source (let's say sources in /home/codeling/devel/itk/source, build in /home/codeling/devel/itk/build), enabled the RTK module in it (with default version 2.1.0), and then I installed the ITK library (let's say to /opt/itk).
I noticed that my application linking to this installed ITK (in /opt/itk) still was referencing a path from where the build was done (/home/codeling/devel/itk/build and /home/codeling/devel/itk/source).
Searching the generated ITK cmake config in /opt/itk/lib/cmake/ITK-5.1, I found the RTK library to be the culprit - the Modules/RTK.cmake contains hard-coded build/source paths in RTK_INCLUDE_DIRS and RTK_LIBRARY_DIRS.
Checking the includes subdirectory, it contains an RTK subdirectory, but not all the files that are referenced in the INCLUDE__DIRS are there.
set(RTK_INCLUDE_DIRS "${ITK_INSTALL_PREFIX}/include/ITK-5.1;/home/codeling/devel/itk/source/Modules/Remote/RTK/utilities/lp_solve;/home/codeling/devel/itk/source/Modules/Remote/RTK/utilities/lp_solve/shared;/home/codeling/devel/itk/source/Modules/Remote/RTK/utilities/lp_solve/bfp;/home/codeling/devel/itk/source/Modules/Remote/RTK/utilities/lp_solve/bfp/bfp_LUSOL;/home/codeling/devel/itk/source/Modules/Remote/RTK/utilities/lp_solve/bfp/bfp_LUSOL/LUSOL;/home/codeling/devel/itk/source/Modules/Remote/RTK/utilities/lp_solve/colamd;/workspace/itk/bin-5.1.2/Modules/Remote/RTK")

(there is a folder lp_solve, but no subfolders).
And the LIBRARY_DIRS just plainly point to the build directory:
set(RTK_LIBRARY_DIRS "/home/codeling/devel/itk/build/lib")

Is installation just not implemented yet for RTK?

I'm currently trying a workaround:

copying all headers from /home/codeling/devel/itk/source/Modules/Remote/RTK/utilities/lp_solve to /opt/itk/includes/RTK/lpsolve
replacing all /home/codeling/devel/itk/source/Modules/Remote/RTK/utilities/lp_solve in RTK_INCLUDE_DIRS with ${ITK_INSTALL_PREFIX}/include/RTK/lpsolve
adapting the RTK_LIBRARY_DIRS to ${ITK_INSTALL_PREFIX}/lib
It seems to be working.... so if these things could be done during ITK installation, that would be great! If I have time I'll look into it myself but not knowing RTK's structure, this could take a while.

I'm currently trying a workaround:

copying all headers from /home/codeling/devel/itk/source/Modules/Remote/RTK/utilities/lp_solve to /opt/itk/includes/RTK/lpsolve
replacing all /home/codeling/devel/itk/source/Modules/Remote/RTK/utilities/lp_solve in RTK_INCLUDE_DIRS with ${ITK_INSTALL_PREFIX}/include/RTK/lpsolve
adapting the RTK_LIBRARY_DIRS to ${ITK_INSTALL_PREFIX}/lib
It seems to be working.... so if these things could be done during ITK installation, that would be great! If I have time I'll look into it myself but not knowing RTK's structure, this could take a while.

Thanks for reporting this. We'll try to work in our side. cc @LucasGandel

Thanks for reporting this. We'll try to work in our side. cc @LucasGandel


Autoloader: Added support for aliases

This PR adds alias support to the Autoloader plugin.
The bug that the dependencies of forced-loaded languages in data-dependencies were not loaded is also fixed.
I.e. <code class="language-pug" data-dependencies="less!"> the dependencies of less were not loaded.

This resolves #1827.

Can you expose lang_aliases to enable custom aliases?

Before thinking about custom aliases, are 'normal' aliases not enough?
For what purpose do you need them?

I want to define the hs alias for haskell. Looks like I have to register that alias to lang_aliases.

hs is the file extension of Haskell files, right? Then making hs an alias for haskell is an easy solution to your problem.
Also, there are others who might also want this alias, so making this part of Prism is probably a better idea than introducing custom aliases.
If there are any other aliases you want, feel free to request them, I'll add them.
If you want to add them yourself:

Add a line Prism.language.myNewAlias = Prism.languages.mylanguage; to the prism-mylanguage.js file in the components/ directory.
Open components.json and add an alias property to the entry languages.mylanguage and set its value to the added alias. E.g. "alias": "myNewAlias " or "alias": ["firstAlias", "myNewAlias "].
Run the npx gulp command after installing all npm dependencies.
Commit and make a PR (without package-lock.json)!

I see, could you add hs alias with #1830? Since hs alias is adopted with GitHub it can be considered a common alias.

I'll make a new PR (#1831).

Thanks!

We'll also want to update the gulp annotations PR, which may be worth revisiting now.

I closed #1535 because I want to get rid of partly generate files in the end.
My goal is to implement #1539 (or similar) so that we generate files that these plugins then require. This will also get rid of the annoying merge conflicts I get almost every time in prism-autoloader.js and prism-show-language.js.


Add info links to edX secure sw development course

In the details of criteria know_secure_design and know_common_errors
note that there are many resources available and
provide a useful link to the free set of courses on edX titled
Secure Software Development Fundamentals.
While there are many ways to learn things, it's useful to point to
a free resource that people can use immediately.
Signed-off-by: David A. Wheeler<EMAIL_ADDRESS>

👍 LGTM


Generate enums from source

i already do this manually with wn-ats, but there should be an executable bundled with wn-mw2 which automatically generates the enums used for type hints and validation from the game's source code.

Done as of ef3c46c.


Add Chinese doc

Is your feature request related to a problem? Please describe.
Vite is  awesome，Has the team consider providing a chinese document in order to be used by more people？
Describe the solution you'd like
add README_zh-CN.md
Describe alternatives you've considered
Maybe i can provide a pr？
Additional context
Add any other context or screenshots about the feature request here.

不可以

here is chinese doc translated by myself, but due to my english, i can't assure correctness

https://github.com/vitejs/vite/pull/1350

https://github.com/vitejs/vite/pull/1350


Temporary workflows toggling during package deployment

To prevent renditions being regenerated for every package deploy, it is very often that projects are using such filter:
    <filter root="/content/dam/example-demo" mode="merge">
        <exclude pattern="/content/dam/.*/renditions/.*"/>
        <include pattern="/content/dam/.*/renditions/original(.*)?"/>
    </filter>

This has serious side effect. The images will be never removed and messy images may left on instance(s) unintentionally.
But simply, imagine:
aemDeploy {
    def workflows = [
         "/etc/workflow/launcher/config/update_asset_create"
         "/etc/workflow/launcher/config/update_asset_mod"
    ]
    doFirst {
        aem.sync { it.disableWorkflow(workflows) }
    }
    doLast {
        aem.sync {
            it.enableWorkflow(workflows)
            // possibility to use any method from: https://github.com/Cognifide/gradle-aem-plugin/blob/master/src/main/kotlin/com/cognifide/gradle/aem/instance/InstanceSync.kt
            // it.restartBundle('x.x.x')
        }
    }
}

reenabling just after package being deployed, may be too quick, maybe some postpone callback need to be used e.g
aem.sync {
    it.postpone 2000, {
        it.enableWorkflows(workflows)
    }
}

duplicate


Performance issue after long editing session?

Since CRDT tends to be memory and disk storage heavy, will there be performance issue after a long editing session? Thanks!

In its current state, probably yes. Some clearing of tombstone data should really be done.


Update build to allow setting JAEGER_AGENT_HOST when deploying wildfly-swarm-example

I'm guessing the fabric8 plugin can do this

This also needs to be able to set at least TRACER_TYPE, SLEEP_INTERVAL, TEST_SERVICE_NAME, and JAEGER_UDP_PORT

https://github.com/kevinearls/wildfly-swarm-opentracing-demo/commit/ef8ae4ed06451d8f5fdc2c2009d74c708d820270


metadata is malformed

how to use RSocketTCPClient#requestResponse?
Steps to Reproduce
import { RSocketClient, JsonSerializers } from "rsocket-core"
import RSocketTCPClient from "rsocket-tcp-client"

const route = "login"
const MIME_TYPE = "application/json"

const client = new RSocketClient({
  serializers: JsonSerializers,
  setup: {
    keepAlive: 10000,
    lifetime: 86400000,
    dataMimeType: MIME_TYPE,
    metadataMimeType: MIME_TYPE,
  },
  transport: new RSocketTCPClient({
    host: "<IP_ADDRESS>",
    port: 7000,
  }),
})
client.connect().subscribe({
  onError: error => console.error(error),
  onSubscribe: cancel => {
    console.log("onSubscribe")
    console.log(cancel)
  },
  onComplete: rsocket => {
    rsocket.requestResponse({
      data: JSON.stringify({
        username: "admin",
        password: "123456",
      }),
      metadata: route,
    }).subscribe({
      onComplete: data => console.log(data),
      onError: e => console.error(e),
    })
    console.log("onComplete")
  }
})

My Environment

RSocket version(s) used:

    "rsocket-core": "^0.0.27",
    "rsocket-tcp-client": "^0.0.27"

node version:v14.17.3

Hi @yuri-li,
Can you provide some more details about what issues you are encountering? In which way is the observed result differing from your expectations? Is there an error thrown that you do not expect? If so, can you be more specific?

Hi @yuri-li,
Can you provide some more details about what issues you are encountering? In which way is the observed result differing from your expectations? Is there an error thrown that you do not expect? If so, can you be more specific?

hi, @viglucci ,
I am a Java development engineer, good at cloud native. I am afraid of misunderstanding, so the server (springboot.jar) is deployed on the cloud server, the host is real, and the front-end code(typescript) I gave can be run directly.
I ran the back-end code (kotlin coroutines+rsocket+kotest) first, and the test code is as follows:

@viglucci
hi, I found the solution
The front-end code after fixing the bug is as follows:
import { RSocketClient, BufferEncoders, encodeAndAddWellKnownMetadata, MESSAGE_RSOCKET_COMPOSITE_METADATA, MESSAGE_RSOCKET_ROUTING, encodeRoute } from "rsocket-core"
import RSocketTCPClient from "rsocket-tcp-client"

const route = "login"

const client = new RSocketClient({
  setup: {
    keepAlive: 10000,
		lifetime: 86400000,
    dataMimeType: "application/json",
    metadataMimeType: MESSAGE_RSOCKET_COMPOSITE_METADATA.string,
  },
  transport: new RSocketTCPClient({
    host: "<IP_ADDRESS>",
    port: 7000,
  }, BufferEncoders),
})
client.connect().subscribe({
  onError: error => console.error(error),
  onComplete: rsocket => {
    const routeMetadata = encodeRoute(route)
    const metadata = encodeAndAddWellKnownMetadata(
        Buffer.alloc(0),
        MESSAGE_RSOCKET_ROUTING,
        routeMetadata
    )
    rsocket.requestResponse({
      data: Buffer.from(JSON.stringify({
          username: "admin",
          password: "123456",
        })),
      metadata,
    }).subscribe({
      onError: e => console.error(e),
      onComplete: payload => console.log((payload.data as Buffer).toString()),
    })
    console.log("onComplete")
  }
})

Hi @yuri-li,
Thanks for following up and providing the solution you found. I believe this issue could be avoided if we had more extensive documentation around composite metadata, as well as more centralized and extensive examples. I'll keep this in mind as we improve the documentation and APIs moving forward.
I'll close this issue since you've come to a solution.

@yuri-li you have incorrect client configurations. Please see these examples to see how to utilize composite metadata -> https://github.com/rsocket/rsocket-js/blob/master/packages/rsocket-examples/src/CompositeMetadataExample.js

Also, here is a working js -> spring-boot-rsocket example https://github.com/OlegDokuka/rsocket-crosslanguage-example


test: gather kvstore output last

Log gathering is bounded by a timeout through a Context, so that the CI does
not get stuck if a single operation takes a long amount of time. However, if
one of the commands when gathering logs in the CI takes an inordinate amount
of time, all subsequent log-gathering commands will fail, because the Context's
deadline will have been reached. In a few CI runs, it has been observed that the
command to get the output from the kvstore has timed out, which is symptomatic
of broken connectivity to the kvstore from a given Cilium agent. Because this
command was ran as one of the first commands when gathering logs, if it timed
out, a lot of additional logs (e.g., bugtool, specific dumps, etc.) were not
performed because of the deadline being reached. So, this commit separates out
the kvstore log-gathering to be the file step of the log-gathering process in
the CI, so that if it times out, it will not affect gathering of other logs.
That way, if kvstore connectivity is messed up, we can have more actionable data
(bugtool, logs, etc.) to help debug the underlying issue.
Signed-off by: Ian Vernon<EMAIL_ADDRESS>

This change is

test-me-please

Coverage increased (+0.02%) to 44.155% when pulling 0a348a61b28f78939f7ed65a902554fff4107947 on pr/ianvernon/gather-kvstore-logs-k8s-last into 363908b03e0c802797506484254490c979cee693 on master.

Build failure: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/14043/
Unrelated to my changes, running again.

test-me-please

test-me-please

Failure is unrelated, am merging so we can get better insight into test failures for kvstore-related problems.


adding stale bot config file

As documented in https://github.com/apps/stale.

The exclusion labels and maybe the 'stale' label need a review. 'wontfix' does exist as a label in the Numba repository, but I think it has gone out of use somewhat.

@stuartarchibald I have addressed the comments, maybe @sklam or @seibert would like to take another look.

I'm wondering if we should use onlyLabels or we need to do an label cleanup before enabling the bot. There are labels like "Numba1.0" that should not be stale.

@esc Should we close this for now?

@stuartarchibald we might as well. I think StaleBot was a nice try, we learnt that the GitHub search and filter bar has bugs, we also learnt that Github never got back to us about about the filter and search being buggy. The positive outcome is that we manually pruned, cleaned and labeled our backlog once, which is good.


Metable data not shown while value set to 0, false, null

Except unset($user->metaVariable), same effect takes set it value to 0, false or null.
It will be right, but what happens when I need to store zero value into metable variable?

Can you provide a PR for this?

What is PR, sorry?

What exactly I need to write in a PR?

a Pull Request with functionality you'd like to have ;)

I have the same issue using Laravel 5.1.
I have a meta_key = status and meta_value = 0. It doesn't show when using toArray but I can access as an attribute.
I my case,  I have a collection of objects that have the meta_key status and I'm using them in a method(from datatables package) that uses them as array in view. If the value is 0, I can't access the status in view. If I set to 555 for example, it shows.
Any help?


[V3] Implement new Concept Exercise: equality

This issue describes how to implement the equality concept exercise for the JavaScript track.
Getting started
Please please please read the docs before starting. Posting PRs without reading these docs will be a lot more frustrating for you during the review cycle, and exhaust Exercism's maintainers' time. So, before diving into the implementation, please read up on the following documents:

The features of v3.
Rationale for v3.
What are concept exercise and how they are structured?

Please also watch the following video:

The Anatomy of a Concept Exercise.

Goal
This exercise aims to teach students how to compare values for equality.
Learning objectives

Know how to use the abstract equality operator ("double equals")
Know how to use the strict equality operator ("triple equals")
Know how to use Object.is()
Understand the difference in how primitives are handled by each of the value-comparison operations

Out of scope

SameValueZero
Deep object comparison

Concepts

equality

Prerequisites

strings
numbers
booleans
objects
type-conversion

After

SameValueZero
Which equality algorithm is used by common built-in methods like Array.indexOf and Array.includes
When to use Object.is() over strict equality comparison

Help
If you have any questions while implementing the exercise, please post the questions as comments in this issue.

@SleeplessByte  How is it going with this ? How much work got done in this? Sorry was busy with personal life. I would like to talk this back on

We decided to combine the concept "comparison" (which includes equality) and "conditionals" into one exercise and that exercise was already done (https://github.com/exercism/javascript/pull/1037). So I am closing this issue.
@shubhsk88 Sorry nobody got back to you earlier. If you still want to help out with V3, have a look at the more recent open issues.
There are some nice smaller ones like https://github.com/exercism/javascript/issues/1019 or if you can manage something bigger maybe https://github.com/exercism/javascript/issues/1049 would suit you.


Contributor documentation and nox set-up instructions incomplete

Hello!
I've tried to run sphinx-needs nox test locally for testing sphinx-needs with python 3.8 on an Ubuntu 22.04 system. I have followed the contributing.rst file but got stuck.
These are the steps I have performed:

install pipx (sudo apt install pipx)

install poetry via pipx (cd sphinx-needs && pipx install poetry)

install nox and nox-poetry via pipx (pipx install nox && pipx inject nox nox-poetry)

install pyenv (curl https://pyenv.run | bash)

add pyenv to my .bashrc (pyenv prints the instructions after "install")

restart bash shell

Install pyenv install 3.8-> failure

Run on ubuntu:
sudo apt update;
sudo apt install build-essential libssl-dev zlib1g-dev \
   libbz2-dev libreadline-dev libsqlite3-dev curl \
   libncursesw5-dev xz-utils tk-dev libxml2-dev libxmlsec1-dev libffi-dev liblzma-dev

Retry step 7 -> now it works (pyenv versions shows system, which is 3.10, and 3.8.18)

restart bash shell

try nox -s 3.8. Gives error:

nox > Command /home/str2lr/.local/pipx/venvs/nox/bin/python -m virtualenv /home/str2lr/projects/public/sphinx-needs/.nox/tests-3-8-sphinx-5-0 -p python3.8 failed with exit code 1:
RuntimeError: failed to find interpreter for Builtin discover of python_spec='python3.8'

I think it somehow is related to nox not being installed in the "global" python environment, but I won't to that. I have to avoid that nox, poetry etc. with all their dependencies pollute my global or user python environment (it's also what the contributing.rst says -> "use a python environment". It does not explicitly mention which, though... so I thought the choice would be open).
Is nox actually tested? I see that the github actions pipeline doesn't use it.

Heya, From my side, I use nox via pipx, and have no problem:
$ pipx list
...
   package nox 2023.4.22, installed using Python 3.11.6
    - nox
    - tox-to-nox

$ nox -e "tests-3.10(sphinx='7.0')" -- tests/ -x
nox > Running session tests-3.10(sphinx='7.0')
...

I don't use pyenv though, jus a global installed python3.10 (technically Im in a base conda environment)
$ which python3.10
/Users/chrisjsewell/mambaforge/bin/python3.10

You might have to look for "generic" nox+pyenv help, like here: https://stackoverflow.com/questions/71454022/nox-does-not-find-my-pyenv-versions-in-my-python-poetry-project

You might have to look for "generic" nox+pyenv help, like here: https://stackoverflow.com/questions/71454022/nox-does-not-find-my-pyenv-versions-in-my-python-poetry-project

Ah! pyenv local 3.8 system did the trick! Mind if I add this short step-by-step instructions to your contributing.rst?

How do you test with different python versions locally?

Hinestly, I don't 😅, I just test test against one and let the CI handle the rest.
I've never had a problem (and you've seen the amount of PRs I've merged 😄 )
(Obviously I didn't set up this project originally, but in basically all my other projects, I actually steer clear of poetry and nox, and use flit and tox + tox-conda (which does everything through conda environments, and works for multiple python versions)

Ah! pyenv local 3.8 system did the trick! Mind if I add this short step-by-step instructions to your contributing.rst?

Yeh no worries, I guess just add it as a tip for pyenv users

How do you test with different python versions locally?

Honestly, I don't 😅, I just test test against one and let the CI handle the rest. I've never had a problem (and you've seen the amount of PRs I've merged 😄 )
(Obviously I didn't set up this project originally, but in basically all my other projects, I actually steer clear of poetry and nox, and use flit and tox + tox-conda (which does everything through conda environments, and works for multiple python versions)

Ah, the beauty of the Python ecosystem. Reminds me of: https://www.youtube.com/watch?v=BgxklT94W0I&t=20s :D

Love that guy
Maybe one day we'll get one-to-rule-them-all 😂


[CI] Added workflow for running cargo-audit.

This version runs once every day at midnight, for prs and for pushes.
Signed-off-by: Valdemar Erk<EMAIL_ADDRESS>

Thanks!


multiple snippets per file

Does this manager allow multiple snippets per file?

It doesn't support, maybe you can try grouping like this to manage your snippets.


Styling fixes for the "Are you sure?" prompt when deleting a comment/reply

Just added clearfixes which hopefully fixes that issue! (I couldn't reproduce though)


Return the start error and reap

Make sure that if we get an error from start it is returned and that we
reap the container's process from create before existing if we were to
send a kill signal.
Signed-off-by: Michael Crosby<EMAIL_ADDRESS>

LGTM


Mark Avro as provided in harness JAR

After https://github.com/apache/beam/pull/27851, user code that depends on versions newer than Avro 1.8.2 are having problems running on Dataflow.
For example in https://github.com/GoogleCloudPlatform/DataflowTemplates, where we moved on to Avro 1.11.3, there were incompatibility errors:

Caused by: java.io.InvalidClassException: org.apache.avro.specific.SpecificRecordBase; local class incompatible: stream classdesc serialVersionUID = -1463700717714793795, local class serialVersionUID =<PHONE_NUMBER>66568477

and

Caused by: java.lang.NoSuchMethodError: 'boolean org.apache.avro.generic.GenericRecord.hasField(java.lang.String)'   com.google.cloud.teleport.v2.transforms.FormatDatastreamRecordToJson.getMetadataIsDeleted(FormatDatastreamRecordToJson.java:258)    com.google.cloud.teleport.v2.transforms.FormatDatastreamRecordToJson.apply(FormatDatastreamRecordToJson.java:123)    com.google.cloud.teleport.v2.transforms.FormatDatastreamRecordToJson.apply(FormatDatastreamRecordToJson.java:51)    org.apache.beam.sdk.extensions.avro.io.AvroSource$AvroBlock.readNextRecord(AvroSource.java:610)

The root cause is that Avro classes are now being shipped along with the /opt/apache/beam/jars/beam-sdks-java-harness.jar, which wasn't the case before.
Mark Avro as provided should solve the problem and allow users to control their Avro.
(Tried to relocate in https://github.com/apache/beam/pull/29407 but got some test failures, so trying this as an alternative)

Run Java PreCommit

Run Java PreCommit

@aromanenko-dev, can I get your thoughts here if including Avro on beam-sdks-java-harness.jar was on purpose?

@bvolpato I guess it was added while working on removing Avro from "core" and some test were failed because of this. If your PR fixes this - it's perfect!

java precommit currently fails unrelated issue on ":sdks:java:container:goBuild"

The precommit failure on Actions looks more real:

What went wrong:
Execution failed for task ':sdks:java:harness:analyzeClassesDependencies'.

Dependency analysis found issues.
unusedDeclaredArtifacts

org.apache.avro:avro:1.8.2@jar

I think it should be permitUnusedDeclared library.java.avro, but would be good to run the task locally to verify


issues pynzb library + useful extentions

I've used this library to process thousands of NZB files.
These are additions and fixes I hacked together while using pynzb:
http://pastebin.com/JRC6GD8g
You have permission to use any of this code to improve pynzb.
In short:

Not all NZBs are valid XML: a function that tries to fix it and parse again e.g. for some NZBs created by newsmangler
function to grab the file name from the subject + effort to do it for non-standard subject lines too
the date of a file wasn't time sensitive
functions to build new NZB files (I used it to create NZBs with certain files)

Bummer, I just spent a good chunk of last night implementing NZB write functionality.  Welcome to use my code as well:
base.py - http://pastebin.com/30uJ9kQA
lxml_nzb.py - http://pastebin.com/ZCi9U5uT
etree_nzb.py - http://pastebin.com/aSb4jnaw


MT schedulers

Revival of https://github.com/crystal-lang/crystal/pull/6990 with a MT scheduler with blazing fast performance... without a GC.
Please see individual commits for some details, and the heavily documented code.
Please see the following benchmarks for some awesomeness glimpse into the future, with 1, 4 and 8 threads:
switch[1/128]: crystal: 10000000 yields in 288 ms, 34631387 yields per second
switch[4/128]: crystal: 10000000 yields in 128 ms, 77606737 yields per second
switch[8/128]: crystal: 10000000 yields in 91 ms, 108759411 yields per second

Yes, over 100 million fiber context switches on a 4 core haswell laptop CPU (without a GC).
Merry :christmas_tree: :santa:
WARNINGS:

work-in-progress (pre-alpha, unsafe, ...) !
disables select !
awfully slow performance with BDWGC !
thread synchronization introduces overhead (slower mutex/channel) !

TODO:

[ ] keep the current scheduler/mutex/channel implementations, and hide MT behind a -Dmt flag;
[ ] thread safe pending reader/writer fibers in IO::Syscall (e.g. use wait queues?);
[ ] park scheduler threads when there is nothing to do; wakeup 'em up when fibers are enqueued; make sure to keep one thread alive, for example running the event loop in a blocking manner;
[ ] the spec suite hangs forever on CI.

TO SOLVE:

[ ] fix 32-bit support of scheduler runnables (currently fixed to a 64-bit word, which means a Double-Word CAS on 32-bit);
[ ] find a solution to re-enable select which will be hard because one Fiber can't be queued multiple times —it could end up being resumed on different threads in parallel (oops);
[x] find a solution for BDWGC & threads & context switch —and/or make my Immix GC thread-safe.

Thanks for the kind words @RX14 ! I applied most of your changes in commits & force pushed.
I update the PR description with a TODO of things I want to work in this PR, and TO SOLVE that will require much more work, and can come later.

2 extra syscalls on a context switch to set signal masks looks expensive. Is it?

Yes, it's as slow as disabling/enabling GC but it behaves better with multiple threads (no contention on the GC global lock). Disabling the signal for the current thread doesn't prevent other threads from initiating a GC collect, or to operate normally. I think it's the best solution we have at hand:
With GC.disable / GC.enable, it's fast with 1 thread (fast path on the lock), but slow with many (thread contention):
switch[1/128]: crystal: 10000000 yields in 692 ms, 14449817 yields per second
switch[4/128]: crystal: 10000000 yields in 3966 ms, 2521357 yields per second
switch[8/128]: crystal: 10000000 yields in 4230 ms, 2364063 yields per second

With pthread_sigmask, it's slow with 1 thread (I don't know the reason) and "faster" with many (no contention, other threads can progress):
switch[1/128]: crystal: 10000000 yields in 5578 ms, 1792651 yields per second
switch[4/128]: crystal: 10000000 yields in 1903 ms, 5253602 yields per second
switch[8/128]: crystal: 10000000 yields in 2297 ms, 4352259 yields per second

I'd love to see how the performance of something like HTTP::Server is affected by this. Preferably actually over the network so there's a good fraction of blocking syscalls.

With a dedicated GC we could avoid all of this, and create fiber suspension points on GC calls (malloc, realloc, free, ...) to tell threads to pause fibers (save the fiber context) then wait on a condition variable to resume it. But I'll see that later :)

I'm curious what the current scheduler performance yields per second is and are there a benchmark code available somewhere to check?

@vlazar released Crystal 0.27.0:
switch[1/128]: crystal: 10000000 yields in 1206 ms, 8287018 yields per second

The comparison is a little hazardous, because the current Fiber.yield will go through the event loop, whereas in the MT scheduler it's merely pushed to the runnables queue, and shall be resumed ASAP.
I'll try to benchmark HTTP::Server with wrk, but right now I have some hangups, so I can't really tell :sob:

@RX14 I benchmarked HTTP::Server with wrk:
crystal 0.27.0:  98 000 req/s
  mt+bdwgc [1]:  92 000 req/s
  mt+bdwgc [2]: 102 000 req/s
mt+gc_none [1]: 105 000 req/s
mt+gc_none [2]: 157 000 req/s

I.e. the current state of this PR ain't slower than the current single threaded crystal scheduler (yay).
That being said, I easily get the server to hang with mt+bdwgc which I couldn't replicate with -Dgc_none. A quick gdb session showed that a thread is blocked inside GC_stop_world waiting for all threads to reply to the stop-the-world signal. Hence: my last patch is broken, and pthread_sigmask probably doesn't do what I expected it to (delay signal delivery, but still deliver it) :sob:

Closing: a much better solution is available in https://github.com/ysbaddaden/crystal/commits/feature/mt fully hidden behing -Dmt.


Update aws-java-sdk-dynamodb to 1.12.636

About this PR
📦 Updates com.amazonaws:aws-java-sdk-dynamodb from 1.11.1034 to 1.12.636
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-dynamodb" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.amazonaws", artifactId = "aws-java-sdk-dynamodb" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #532.


Error: ENOTDIR: not a directory, scandir 'D:\path\filetowatch'

i'm getting this error message on cli whenever i run watch command

sorry, just realized that watch cannot watch single files :p


Add Support for creating HA Queues

Closing this as won't-fix since the rabbit documentation advises that the use of policies is the preferred mechanism: https://www.rabbitmq.com/ha.html


🐛 Cannot read property 'id' of undefined

What were you trying to do?
Can read the device camera ID on component mount, I already gone through Issue #9  but I can seems to get a work around and below it the error from Android Studio logcat
Reproduceable Code
import React, {useEffect, useState} from 'react';
import {View, Text, ActivityIndicator} from 'react-native';

import SafeAreaView from 'react-native-safe-area-view';
import {Camera, useCameraDevices} from 'react-native-vision-camera';
// Components
import {AppStatusBar} from '../../../../../components/shared';

// Styles && Colors
import {COLORS, STYLES, FONTS} from '../../../../../constants';
import Styles from './styles';

const ScanPreview = (): JSX.Element => {
  const [hasPermission, setHasPermission] = useState<boolean | any>(false);
  const devices = useCameraDevices();
  const device: any = devices.back;

  const requestCameraPermission = async (): Promise<any> => {
    const status = await Camera.requestCameraPermission();
    setHasPermission(status === 'authorized');
  };

  useEffect(() => {
    requestCameraPermission();
  }, []);

  if (!hasPermission) {
    <View style={[STYLES.container]}>
      <Text style={[FONTS.h3, {color: COLORS.secondary}]}>No Permission</Text>
    </View>;
  }

  if (device === null) return <ActivityIndicator color={COLORS.primary} />;

  return (
    <SafeAreaView>
      <AppStatusBar backgroundColor={COLORS.transparent} />
      <Camera style={Styles.camera} device={device} isActive={true} />
    </SafeAreaView>
  );
};

export default ScanPreview;

What happened instead?
The app crashes with **Cannot read property "id" of undefined
Relevant log output
`2022-03-10 03:39:44.319 26267-26267/com.patientui E/GraphicExt: Can't load libboost_ext_fwk
2022-03-10 03:39:44.319 26267-26267/com.patientui E/GraphicExt: GraphicExtModuleLoader::CreateGraphicExtInstance false
2022-03-10 03:39:44.541 26267-26350/com.patientui E/gralloc: Arm Module v1.0
2022-03-10 03:39:44.546 26267-26350/com.patientui E/ion: ioctl c0044901 failed with code -1: Invalid argument
2022-03-10 03:39:44.816 26267-26267/com.patientui E/: [onConstructor]: an error ged handle
2022-03-10 03:39:44.816 26267-26267/com.patientui E/GraphicExt: GraphicExtModuleLoader::CreateGraphicExtInstance false
2022-03-10 03:41:02.519 26267-26461/com.patientui E/ReactNativeJS: TypeError: Cannot read property 'id' of undefined

    This error is located at:
        in Camera (at scanPreview/index.tsx:41)
        in RCTView (at View.js:32)
        in View (at createAnimatedComponent.js:211)
        in AnimatedComponent (at createAnimatedComponent.js:264)
        in AnimatedComponentWrapper (at src/index.tsx:85)
        in SafeAreaView (at scanPreview/index.tsx:39)
        in ScanPreview (at App.tsx:29)
        in Provider (at App.tsx:28)
        in RNCSafeAreaProvider (at SafeAreaContext.tsx:76)
        in SafeAreaProvider (at App.tsx:26)
        in App (at renderApplication.js:50)
        in RCTView (at View.js:32)
        in View (at AppContainer.js:92)
        in RCTView (at View.js:32)
        in View (at AppContainer.js:119)
        in AppContainer (at renderApplication.js:43)
        in PatientUI(RootComponent) (at renderApplication.js:60), js engine: hermes`

Device
Nokia 3.1
VisionCamera Version
"2.12.0"
Additional information

[ ] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

Hi! You are performing an explicit null check (device === null), but device is undefined, not null. So you should instead do device == null (two = signs)

Thanks @mrousavy  Works now


Can KeplerianOrbit functions accept theano variables?

For example, I would like to include the relative velocity as a deterministic variable in my transit model. This let's me check the transit duration and compare with my past models (which used vel_R to fit the transit). This should be simple enough as the KeplerianOrbit has "get_relative_velocity" which effectively calculates this if you input the time of transit, t0, as the variable.
However, just including something like this:
t0 = pm.Normal("t0", mu=list_t0s, sd=1.0, shape=2, testval=list_t0s)
orbit = xo.orbits.KeplerianOrbit(period=period, t0=t0, b=b)
vel_R = pm.Deterministic("vel_R", orbit.get_relative_velocity(t0))
fails:

`AttributeError                            Traceback (most recent call last)
 in ()
95     #print(orbit._get_true_anomaly(t0)[1].shape)
96     #vel_R = pm.Deterministic("vel_R", ((2np.pismac.au.value/P)(1 + eccorbit.cosf)/np.sqrt(1-ecc**2))/(Rsc.R_sun.value))
---> 97     vel_R = pm.Deterministic("vel_R", orbit.get_relative_velocity(t0))
98     print(vel_R)
99     Tdur = pm.Deterministic("Tdur", (2*(1+RpRs)*np.sqrt(1-(b/(1+RpRs))**2))/vel_R)
/Users/hosborn/anaconda3/lib/python3.6/site-packages/pymc3/model.py in Deterministic(name, var, model)
1496     """
1497     model = modelcontext(model)
-> 1498     var = var.copy(model.name_for(name))
1499     model.deterministics.append(var)
1500     model.add_random_variable(var)
AttributeError: 'tuple' object has no attribute 'copy'`

In this case, t0 has two subtensors (i.e. there are two planets with two t0s), so maybe there is something I can do with the t0 tensor to allow KeplerianOrbit.get_relative_velocity to process the input.
I have also tried using:orbit._get_true_anomaly(t0) to give me cosf and do the calculation myself (e.g. using Eq 12 in Barnes, 2008 https://arxiv.org/pdf/0708.0243.pdf), but this also fails...
Thanks!
setup:

exoplanet 0.2.1.dev0
Operating system: MacOSX
Python version & installation method (pip, conda, etc.): pip+git

@hposborn: Theano is a whole can of worms :), but here the issue is that get_relative_velocity returns three elements: the vx, vy, and vy. Each of these should have shape (ntimes, nplanets), I believe. So, I expect that what you actually want is the speed in the plane of the sky which you should be able to compute as:
vx, vy, vz = orbit.get_relative_velocity(t0)
vsky = tt.sqrt(vx**2 + vy**2)

but then there's one more catch. This will be a 2x2 matrix with the speed of each planet at each time so you'll want to take the diagonal of that (tt.diag(vsky) should work, I think) to get the right velocities (in R_sun/day). Try that and see if it works!

Ah thanks. I thought that might be the case, but I couldn't get orbit.get_relative_velocity(t0)[0] (for example) to produce anything either (but I guess I shouldn't treat Theano variables like tensors).
Works great now, thanks!