Allow popup logins in withAuthenticationRequired

Please do not report security vulnerabilities here. The Responsible Disclosure Program details the procedure for disclosing security issues.
Thank you in advance for helping us to improve this library! Your attention to detail here is greatly appreciated and will help us respond as quickly as possible. For general support or usage questions, use the Auth0 Community or Auth0 Support. Finally, to avoid duplicates, please search existing Issues before submitting one here.
By submitting an Issue to this repository, you agree to the terms within the Auth0 Code of Conduct.
Describe the problem you'd like to have solved
My react app can be loaded in an iframe (and in a normal window at times). In order to perform auth, it's best to use the loginWithPopup. This however isn't possible with the withAuthenticationRequired HOC
Describe the ideal solution
withAuthenticationRequired options accepts field that can be toggled to enable/disable popup login. By default this can default to using redirect login.

export default withAuthenticationRequired(component, { popup: true })

Alternatives and current work-arounds
The only workaround is to ensure that a login occurs by using an onclick event for the navigation links. Doesn't work if the iframe loads at the route with a withAuthenticationRequire component.

Hey @Vivalldi - thanks for raising this
This looks like a valid use case, we will add something to our backlog - in the meantime, you could create your own withAuthenticationRequired using https://github.com/auth0/auth0-react/blob/master/src/with-authentication-required.tsx as an example - it uses only public APIs so you should be good to duplicate it. We're also happy to accept PRs if you'd like to have a go at it.

Leaving a simple example of how you might do this here.
const withAuthenticationRequired = (Component, options) => {
  function WithAuthenticationRequired(props) {
    const { isAuthenticated, isLoading, loginWithPopup } = useAuth0();

    useEffect(() => {
      if (isLoading || isAuthenticated) {
        return;
      }
      (async () => {
        await loginWithPopup(opts);
      })();
    }, [ isLoading, isAuthenticated, loginWithpopup, options ]);

    return routeIsAuthenticated ? <Component {...props} /> : null;
  };
};

Am reluctant to add this, as the popup will most likely be blocked by the user agent (when loading the route doesn't come from a user interaction)
Will review this decision if I get anymore info about this.


Enforce gofmt in travis

Run gofmt -l . during travis to catch pull requests that have not had
gofmt run on them.
Change-Id: Ibfdf988a535d82721f3c4bc328b189f606f12778

LGTM

Rebased on top of "Fix gofmt" patch from #113 so the travis check passes.

And made it print the gofmt errors.

LGTM


Support arm and arm64 architectures

Confirmed in arch/{arm,arm64}/include/uapi/asm/ that they do not
override IOC* constants.
Tested on arm at this time.

Thanks!

@tv42 I tagged a new version with arm and arm64 enabled, if you want to not use a commit hash to specify versions.

Sweet, thanks!


Add sample to get access token by oauth

Modify: add redirectUri

OK, but what should the file name, etc. be? If I should simply cut and paste the code somewhere else, it would be easy and I want to leave it to you.

You could name it 'OAuthGetAccessToken.java'. Thank you very much!

I modified. Kotlin code is converted by IntelliJ IDEA and I confirmed it works.

"Unresolved conversations" is still displayed for some reason, but this has been fixed.

Thanks @lamrongol for fixing this so quick!


Espanso doesn't properly work with scrcpy

[x] I have read the FAQ.
[x] I have searched in existing issues.

Environment

OS: Windows 10
scrcpy version: 1.21
installation method: Windows release
device model: Xiaomi Mi A3
Android version: 11

Describe the bug
When I use Espanso (a text expander is a program that detects when you type a specific keyword and replaces it with something else) (https://github.com/federico-terzi/espanso) on my real android phone using scrcpy. So when I try to use the Espanso the trigger doesn't expand the phrase.
-trigger: "aaa"
replace: "Hello world!? test test@@ bla bla**"

In scrcpy I try to send messages in Snapchat (left window, watch the attached video) it doesn't expand the text but only symbols
In BlueStacks emulator it works good (right window, watch the attached video)
Also Espanso works good when I just use it on PC in any place. The problem is only with scrcpy

The video: https://user-images.githubusercontent.com/13819963/165863100-2342fc5f-aa8f-47af-83b6-da5a12b28fea.mp4
On errors, please provide the output of the console (and adb logcat if relevant).
Please paste terminal output in a code block. - Can't paste the full log because it's too long...

When I use Espanso (a text expander is a program that detects when you type a specific keyword and replaces it with something else) (https://github.com/federico-terzi/espanso) on my real android phone using scrcpy.

Espanso runs on the computer, correct?
Several tests you could do:

run scrcpy --prefer-text to inject text instead of key events for letters
run scrcpy -Vverbose, type the trigger (aaa) exactly once, then close, and post the console output
run in OTG mode scrcpy --otg: is the text replaced?

Did what you said. Plus I also added some emojis because they also don't get expanded (forgot to mention it earlier).
So here's the same text but with some emojis: Hello world!?😉 test test@@ bla bla😄**
Also, the trigger letters don't get removed (but they have to) after text expands:

C:\Users\yarak>scrcpy -Vverbose --prefer-text
scrcpy 1.24 <https://github.com/Genymobile/scrcpy>
DEBUG: ADB device found:
DEBUG:     -->   (usb)          01c794fbf4ab            device  Mi_A3
DEBUG: Device serial: 01c794fbf4ab
DEBUG: Using server (portable): C:\Users\yarak\AppData\Local\Android\Sdk\platform-tools\scrcpy-server
C:\Users\yarak\AppData\Local\Android\Sdk\platform-tools\sc... file pushed, 0 skipped. 55.0 MB/s (41159 bytes in 0.001s)
[server] INFO: Device: Xiaomi Mi A3 (Android 11)
DEBUG: Server connected
DEBUG: Starting controller thread
DEBUG: Starting receiver thread
[server] DEBUG: Using encoder: 'OMX.qcom.video.encoder.avc'
INFO: Renderer: direct3d
DEBUG: Trilinear filtering disabled (not an OpenGL renderer)
DEBUG: Using icon (portable): C:\Users\yarak\AppData\Local\Android\Sdk\platform-tools\icon.png
INFO: Initial texture: 720x1560
DEBUG: Starting demuxer thread
VERBOSE: input: text "a"
VERBOSE: input: text "a"
VERBOSE: input: text "a"
VERBOSE: input: text "H"
VERBOSE: input: text "e"
VERBOSE: input: text "l"
VERBOSE: input: text "l"
VERBOSE: input: text "o"
VERBOSE: input: text " "
VERBOSE: input: text "w"
VERBOSE: input: text "o"
VERBOSE: input: text "r"
VERBOSE: input: text "l"
VERBOSE: input: text "d"
VERBOSE: input: text "!"
VERBOSE: input: text "?"
VERBOSE: input: text "😉"
VERBOSE: input: text " "
VERBOSE: input: text "t"
VERBOSE: input: text "e"
VERBOSE: input: text "s"
VERBOSE: input: text "t"
VERBOSE: input: text " "
VERBOSE: input: text "t"
VERBOSE: input: text "e"
VERBOSE: input: text "s"
VERBOSE: input: text "t"
VERBOSE: input: text "@"
VERBOSE: input: text "@"
VERBOSE: input: text " "
VERBOSE: input: text "b"
VERBOSE: input: text "l"
VERBOSE: input: text "a"
VERBOSE: input: text " "
VERBOSE: input: text "b"
VERBOSE: input: text "l"
VERBOSE: input: text "a"
VERBOSE: input: text "😄"
VERBOSE: input: text "*"
VERBOSE: input: text "*"
[server] WARN: Could not inject char u+d83d
[server] WARN: Could not inject char u+de09
[server] WARN: Could not inject char u+d83d
[server] WARN: Could not inject char u+de04

Also, I tried running in OTG mode but something is wrong with it. After I ran that command it started giving me those errors when I move my mouse and it locked the mouse so I couldn't do anything. To exit from that mode I had to press Win button.

Did what you said. Plus I also added some emojis because they also don't get expanded (forgot to mention it earlier).
So here's the same text but with some emojis: Hello world!?😉 test test@@ bla bla😄**
Also, the trigger letters don't get removed (but they have to) after text expands:

C:\Users\yarak>scrcpy -Vverbose --prefer-text
scrcpy 1.24 <https://github.com/Genymobile/scrcpy>
DEBUG: ADB device found:
DEBUG:     -->   (usb)          01c794fbf4ab            device  Mi_A3
DEBUG: Device serial: 01c794fbf4ab
DEBUG: Using server (portable): C:\Users\yarak\AppData\Local\Android\Sdk\platform-tools\scrcpy-server
C:\Users\yarak\AppData\Local\Android\Sdk\platform-tools\sc... file pushed, 0 skipped. 55.0 MB/s (41159 bytes in 0.001s)
[server] INFO: Device: Xiaomi Mi A3 (Android 11)
DEBUG: Server connected
DEBUG: Starting controller thread
DEBUG: Starting receiver thread
[server] DEBUG: Using encoder: 'OMX.qcom.video.encoder.avc'
INFO: Renderer: direct3d
DEBUG: Trilinear filtering disabled (not an OpenGL renderer)
DEBUG: Using icon (portable): C:\Users\yarak\AppData\Local\Android\Sdk\platform-tools\icon.png
INFO: Initial texture: 720x1560
DEBUG: Starting demuxer thread
VERBOSE: input: text "a"
VERBOSE: input: text "a"
VERBOSE: input: text "a"
VERBOSE: input: text "H"
VERBOSE: input: text "e"
VERBOSE: input: text "l"
VERBOSE: input: text "l"
VERBOSE: input: text "o"
VERBOSE: input: text " "
VERBOSE: input: text "w"
VERBOSE: input: text "o"
VERBOSE: input: text "r"
VERBOSE: input: text "l"
VERBOSE: input: text "d"
VERBOSE: input: text "!"
VERBOSE: input: text "?"
VERBOSE: input: text "😉"
VERBOSE: input: text " "
VERBOSE: input: text "t"
VERBOSE: input: text "e"
VERBOSE: input: text "s"
VERBOSE: input: text "t"
VERBOSE: input: text " "
VERBOSE: input: text "t"
VERBOSE: input: text "e"
VERBOSE: input: text "s"
VERBOSE: input: text "t"
VERBOSE: input: text "@"
VERBOSE: input: text "@"
VERBOSE: input: text " "
VERBOSE: input: text "b"
VERBOSE: input: text "l"
VERBOSE: input: text "a"
VERBOSE: input: text " "
VERBOSE: input: text "b"
VERBOSE: input: text "l"
VERBOSE: input: text "a"
VERBOSE: input: text "😄"
VERBOSE: input: text "*"
VERBOSE: input: text "*"
[server] WARN: Could not inject char u+d83d
[server] WARN: Could not inject char u+de09
[server] WARN: Could not inject char u+d83d
[server] WARN: Could not inject char u+de04
VERBOSE: input: key down code=113 repeat=0 meta=203000
VERBOSE: input: key down code=113 repeat=1 meta=203000
VERBOSE: input: key   up code=113 repeat=0 meta=200000
DEBUG: User requested to quit
DEBUG: quit...
DEBUG: Server disconnected
DEBUG: End of frames
DEBUG: Receiver stopped
DEBUG: Server terminated

Also, I tried running in OTG mode but something is wrong with it. After I ran that command it started giving me those errors when I move my mouse and it locked the mouse so I couldn't do anything. To exit from that mode I had to press Win button.

When I use Espanso (a text expander is a program that detects when you type a specific keyword and replaces it with something else) (https://github.com/federico-terzi/espanso) on my real android phone using scrcpy.

Espanso runs on the computer, correct?
Several tests you could do:

run scrcpy --prefer-text to inject text instead of key events for letters
run scrcpy -Vverbose, type the trigger (aaa) exactly once, then close, and post the console output
run in OTG mode scrcpy --otg: is the text replaced?

For some reason, I couldn't quote your reply. So just letting you know I replied to you.

Plus I also added some emojis because they also don't get expanded (forgot to mention it earlier).

That's "expected": https://github.com/Genymobile/scrcpy/blob/master/FAQ.md#special-characters-do-not-work

Also, the trigger letters don't get removed (but they have to) after text expands:

I don't know what "Espanso" does to remove the characters, but it seems nothing is received by SDL. Maybe try with an older SDL version (refs #3230).

After I ran that command it started giving me those errors when I move my mouse

Do you have a "gaming" mouse? (see #3088)


TileBreaker

Your checklist for this pull request
Author name
Author: Rudransh Pratap Singh

About your game
What is your game about? Breaking Tiles By making the Ball Rebound

How do you play your game? Use A & D Keys to move the Player Tile Horizontally

Code
Check off the items that are true.

[x] The game was made using the Sprig editor.
[x] The game is placed in the in the /games directory.
[x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x] The game runs without errors.
[x] The name of the file/game contains only alphanumeric characters, -s, or _s.
[x] The game name is not the same as the others from gallery

Image (If an image is used)

[x] The image is in the /games/img directory.
[x] The name of the image matches the name of your file.

Thanks for your PR!

Hello! Your TileBreaker game so far has a great start, however it would be optimal to add some more game mechanics (like power-ups) in order to meet the quality standard in order to receive the sprig hardware grant and to publish it to the gallery. Thanks!

Looked at this today, still awaiting author response.

Working on this gonna do that soon.... felt great that people are looking out for authors

Looked at this today - still awaiting changes from author.

Looked at this today, still awaiting changes from the author.

Working on it been busy lately

Looked at this today, still awaiting changes from the author.

Looked at this today, still awaiting changes from the author (do not take this as a suggestion that you need to hurry up, this is just for my own bookkeeping).


DCV vs Shell experience differs for third party user

When a third party user gets invited via email-link they (provided the PCM user has sufficient privileges) will be able to access a running cluster via DCV. The "shell" link, however, will request the user to sign-up/sing-in with their AWS account.
For a seamless user experience, the "shell" button should also work without AWS credentials. The current state request the third party user to know about AWS users, IAM, etc. which is exactly what PCM successfully hides in other cases.

Thank you @stephenmsachs for the feedback!
We'll look into how to make the experience for users as smooth as possible, while respecting the security checks that are needed at each step


Recommend YAML-Config Autocomplete for Jetbrains (Pycharm and friends)

There is a great plugin that should be installed alongside this.
[https://plugins.jetbrains.com/plugin/12016-yaml-config-autocomplete](Yaml-Config Autocomplete)
It adds autocomplete when typing keys, which for some reason is not supported OOTB with PyCharm!

Feel free to open a PR tweaking the readme and we'll get it merged!


auth failure: secret conn failed: EOF

As we have talked in gitter I'm going to put a screenshot of the problem.
In the photo theres 2 nodes where I have dropped the DB (bigchaindb drop) and reset the node (tendermint unsafe_reset_validator).
On the node below I have set it to create empty blocks each 60seconds and its there where it pops up the error.

As you can see it doesnt create any blocks (I have waited 10min) and If i try to do a tx with the javascript driver it returns a nil pointer exception but thats another issue and it may be related to this.
Any help will be appreciated.

Hi Jazek!
Thanks for detailed report. It's good that you have opened github issue I encourage you to post all issues publicly because this way community will also benefit from our conversation. I'm a bit busy at the moment but ill answer your gihub issue soon.
Best Regards
David
P.S. This is my<EMAIL_ADDRESS>box. Im just having problem with my registrar so the address might be different.
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Wednesday, October 30, 2019 4:18 PM, Jazek<EMAIL_ADDRESS>wrote:

As we have talked in gitter I'm going to put a screenshot of the problem.
In the photo theres 2 nodes where I have dropped the DB (bigchaindb drop) and reset the node (tendermint unsafe_reset_validator).
On the node below I have set it to create empty blocks each 60seconds and its there where it pops up the error.
Nodo Secret conn
As you can see it doesnt create any blocks (I have waited 10min) and If i try to do a tx with the javascript driver it returns a nil pointer exception but thats another issue and it may be related to this.
Any help will be appreciated.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi. Did you put services down? Before you dropped the database and reseted the blockhain?
Try to make sure that tm and bigchaindb services are down on all nodes before doing that.

Let me try to do it on Monday as I dont have my ARM devices at home.

Well I just did what you said and now it doesn't return a  "secret conn error" but theres another problem.
I set it to create empty_blocks each 60 seconds and it only creates 3 blocks and it stops. Indeed if I try to do an example tx like this:
curl -s 'localhost:26657/broadcast_tx_commit?tx="abcd"'
It returns a nil pointer error as shown below:

Do you know why is all of this happening? On previous version 2.0.0beta9 none of this things happened to me.

Its hard to determine what is causing the problem from description. At the same time I cant replicate your issue. I set 60s empty block creation interval and it works fine.
Did you configure proxy_app and presistent_peers in tendermints config.toml. Is pex set to false?
Did you set 60s interval for all nodes in the network?
Also I am not entirely sure you are suppose to interact with tendermint socket directly. I need double check it.

Let's go part by part.
The proxy_app is set to kv to store keys and values on mongodb.
The persistent_peers are set correctly each with their ip, node id and port.
I dont know what pex is but i will definitively check it out.
Finally regarding the empty blocks, first of all I have tried with only 1 node to create empty_blocks but it didnt work, I did another test this morning with all nodes to create empty blocks each 60s and it works.
I know I shouldnt do tx's directly with tendermint but I have tried to do another one with the js driver and i got a similar error with nil pointer.

You mean you have set proxy app to kv_store? Proxy app should be bigchaindb itself.
For example you could set it as node command argument --proxy_app=tcp://<IP_ADDRESS>:26658. This will work if BigchainDB is available on your localhost port 26658. Let me know If I didn'n get this point right.
Yo can send requests to bigchaindb. See API Docs.
Let's see how It goes. It is not clear for me whether Its a bug a collection of bugs or just wrong environment/configuration.

I am also facing the same error. when I start tendermint using endermint node --consensus.create_empty_blocks=false --proxy_app=tcp://localhost:26658
dialing failed module =p2p addr=node1id@ip_addressofnode1:26656" "err=dial tcp #ip_addressofnode1:26656: I/o timeout
dialing failed module =p2p addr=node2id@ip_addressofnode2:26656" "err=dial tcp #ip_addressofnode2:26656: I/o timeout


Added toggleTouchIdEnrollment

Proposed changes
The Appium team added an endpoint that toggles touchId enrollment (/session/:session_id/simulator/toggle_touch_id_enrollment). This PR adds a new method that hits this endpoint.
Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected

Yeah, I assigned him as a reviewer.

@dpgraham @jlipps I was completely busy.
@dpgraham What the usescase? Which platforms do support this? Could you provide some tests?

@TikhomirovSergey This is used on iOS Simulators that support touchId. This endpoint toggles enrollment in touchId and the other endpoint /session/{sessionId}/appium/simulator/touch_id simulates a touchId event.
If I have time today I'll see if I can add tests.

@dpgraham Do you mind resolving conflicts here?

I'll get to this tomorrow.

I've recently added mobile: endpoints for biometric stuff on iOS. Let's see if we need something similar on other platforms, so then these global endpoints will come into play.


Implement support for persistent state a area

This commit adds the concept of a persistent state area in
immutable-rootfs package. It adds support for adding an additional
non ephemereal overlayfs on top of configurable locations,
alternatively, instead of using overlayfs in can simple bind mount
a mirrored location from a persistent area.
Fixes #430
Signed-off-by: David Cassany<EMAIL_ADDRESS>

Looks good here! shall we also update the docs to specify how to use it? (we can also start to replace it in our samples with the cloud-init mechanism we have spread all over already..)

Sure I am already working on documenting it. Then I was also thinking on updating the examples we have.


Gleam

Wow! Good job. Unfortunately, I haven't had enough time for this for the last few days. Would you like me to continue on this?

Oops, sorry I missed your comment there @EskiMag ! I've got a first version here but I think we could improve some more things. I'll make some issues


WIP-A separate occupancy tracker for MR

added seperate occupancy tracking and refactored metrics registrations

/test all

/test all

/retest-required

PR was closed as the merge target was changed after release to the develop branch

PR was reopened as the merge target was changed back to the main branch

/test pre-main-reconciler-integration-k3d

/test pre-main-ory-reconciler-eval-integration


Fixed rfxtrx binary sensor missing optional keyerror data_bits

Description:
Fixed rfxtrx binary sensor missing optional keyerror data_bits
2018-02-28 11:24:30 ERROR (MainThread) [homeassistant.components.binary_sensor] Error while setting up platform rfxtrx
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/helpers/entity_platform.py", line 84, in async_setup
    SLOW_SETUP_MAX_WAIT, loop=hass.loop)
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
    return fut.result()
  File "/usr/local/lib/python3.6/asyncio/futures.py", line 243, in result
    raise self._exception
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/app/homeassistant/components/binary_sensor/rfxtrx.py", line 58, in setup_platform
    if entity[CONF_DATA_BITS] is not None:
KeyError: 'data_bits'

Related issue (if applicable): fixes #12776
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):
binary_sensor:
  - platform: rfxtrx
    devices:
      0b110001008744e10a000070:
        name: Mailbox
        device_class: opening

Checklist:

[x] The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Fixes #12776 / #12688, probably introduced by #12463.

Thanks! Sorry about introducing the issue 🤔  Will make it part of the next hotfix 🎉


intro-weave-gitops page is not opening at all it shows

https://docs.gitops.weave.works/docs/intro-weave-gitops/
This XML file does not appear to have any style information associated with it. The document tree is shown below.

UserProjectAccountProblem
The project to be billed is associated with a delinquent billing account.

Considering the recent news https://thenewstack.io/end-of-an-era-weaveworks-closes-shop-amid-cloud-native-turbulence/ its no wonder the account hasnt been paid for.
If anybody knows a good UI alternative i would appreciate a pointer. :)

@HannesHil yeah hannes you are right @stefanprodan please help us here if their is anyother for an Flux UI

See https://fluxcd.io/blog/2024/02/introducing-capacitor/

What will happen with weave-gitops? It looks much more mature that capacitor.

What will happen with weave-gitops? It looks much more mature that capacitor.

Since it's OpenSource, anybody can fork it and continue support for it. However, that would realistically need a sponsor with some money, so it remains to be seen if any of the companies using it are willing to back it.


Fix OS X compilation errors

If you try to build this on OS X, you'll get a few compilation errors:
$ make
g++ -pthread main.c src/Blob.c -o pemcracker -lssl -lcrypto -O3
clang: warning: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated
clang: warning: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated
main.c:14:15: warning: extra tokens at end of #ifdef directive [-Wextra-tokens]
#ifdef _WIN32 || _WIN64
              ^
              //
main.c:40:19: warning: extra tokens at end of #ifdef directive [-Wextra-tokens]
    #ifdef _WIN32 || _WIN64
                  ^
                  //
main.c:156:22: error: expected expression
            *mutex = PTHREAD_MUTEX_INITIALIZER;
                     ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/usr/include/pthread.h:179:35: note:
      expanded from macro 'PTHREAD_MUTEX_INITIALIZER'
#define PTHREAD_MUTEX_INITIALIZER {_PTHREAD_MUTEX_SIG_init, {0}}
                                  ^
2 warnings and 1 error generated.
make: *** [pemcracker] Error 1

I've made the necessary changes to fix these errors.

Nice!  Thanks!


java.lang.NoClassDefFoundError: org/openqa/selenium/security/Credentials at com.codeborne.selenide.Selenide.(Selenide.java:37)

The problem
First call to selenide code $(By.xpath(LOGIN_EDIT)) cause  exception
java.lang.NoClassDefFoundError: org/openqa/selenium/security/Credentials
at com.codeborne.selenide.Selenide.<clinit>(Selenide.java:37)
at com.project_name.LoginPage.getLoginEdit(LoginPage.java:17)

Tell us about your environment

Selenide Version: 4.8
Chrome Version 63.0.3239.108 (Official Build) (64-bit)
Browser Driver Version: 2.34.522940
Selenium Version: 3.8.1
OS Version: win 10

Code To Reproduce Issue [ Good To Have ]
Please remember that with sample code it's easier to reproduce the bug.

It is selenium 3.8.0 breaking changes issue.
As workaround downgrade your selenium version.

Thank you @BorisOsipov !
As a workaround selenium version 3.7.1 fixes the issue.

@nitrok  Selenide 3.9 with 3.8.1 compatibility has been released. Try it.


Haskell updates maintainer

Description of changes
add thielema as maintainer to configuration-hackage2nix/main.yaml

Github wants to pull-request this into master, but I have branched from haskell-updates.

Well, that’s a lot of packages.^^ But I see you maintain all of them on hackage, so we are very happy for you to take ownership for them here, too. Cool.
A couple of points:

A while back, I wrote down this information about fixing packages and being a maintainer. https://md.darmstadt.ccc.de/haskell-packages-contribution-checklist#What-does-it-mean-to-be-a-maintainer-of-a-Haskell-package Maybe have a look at that.
If a package you maintain is broken by a dependency of it, you will get notified either way, even if you are not a maintainer of a broken dependency. You might consider only becoming a maintainer of some of the packages. But in your case, that doesn’t seem to make a lot of sense.
To conform more to the contributor's guide, your commit message should start with a scope. e.g. haskellPackages: …
You need an entry in maintainers/maintainer-list.nix.
We, or rather our tooling, only notifies maintainers when packages break. So if you want to confirm that they all work, you will need to check that manually. One idea in this case, with which I would be okay, would be to simply throw them all out of the broken.yaml, merge, let hydra create the report and see how much breakage is happening.

Thank you!


Add repos to Foundational Infrastructure charter, update urls

Added repos:
cf-mysql-bootstrap
cf-mysql-cluster-health-logger
galera-healthcheck
switchboard
greenhouse-ci

@christopherclark @LeePorte I think #256 obviates this PR. If that sounds right to you, let's close this one.

Hey @emalm, indeed that does look to be the case. I'm happy to close this one if @christopherclark is.

Looking at #256 in more detail, I feel pretty confident this one's now redundant. I'll close this PR, and we can always re-open it if I'm wrong.


Display total funding received on the OSO project page

What is it?
Depends on
https://github.com/opensource-observer/oso/issues/2201
Once this is done, we should add the mart to Hasura, then expose the total funding received to the OSO project page.

Here is the dbt model and the materialization. All the data has been successfully deployed to production and is ready to be integrated with the frontend!
cc @ryscheng


sidebar tabs icon unloaded

Checklist

[x] I have read the newlest tutorials and know the correct effect of the functional design.
[x] There is no similar question on existing issues (including closed ones).
[x] I have tried to find the answer on Jekyll Forum and StackOverflow.
[x] My question is based on the latest code of the master branch.

Description

Tab icons don't load.

这是屏幕自适应，你缩小一下页面就有了。

这是屏幕自适应，你缩小一下页面就有了。

怪不得，之前还好好的，突然就没了。


Invalid timeout value and ability to set timeout

This fixes issue https://github.com/substack/hyperquest/issues/39

10000ms seems equally arbitrary to me.Is the change really worth it?

I need to be able to set the socket timeout, to something reasonable, so if if my apis i receive data from stop sending to us with no heartbeat. Otherwise the connection will just be happy doing nothing.

10000 does indeed seem pretty arbitrary. I would rather not have any magic numbers. Magic numbers (5 requests and then your process hangs!) are what annoyed me about core http/request enough to write this module.


Change sample Docker compose file to work with NuoDB 4.2

NuoDB 4.2 no longer ships default TLS keys.
Remove the TLS enforcement to enable the compose file to detect whether NuoDB is running with or without LTS.

Correct. I need to figure out whats wrong with K8s too.


#10 Introduce stricter prop type checks

Coverage remained the same at 100.0% when pulling ea86a7a63f7b37fe2f21d5e9a9affe24d1444415 on feature-10 into 4a8ab51929c78bfb284c4b35954cc17e8e24ae22 on develop.


ENOENT: no such file or directory, open '...../architecture-center/docs/index.yml'

I can't find the index.yml and thus can't build the documentation.

Yes, we accidentally broke this during a hasty effort to come into compliance with publishing platform.
There are actually a couple of things broken with the build scripts. We will fix it, but we have a couple of other high priority items that are taking our attention.
I anticipate getting to this in early May.

Thanks for getting back! Well no hurry with that.
On Fri, 21 Apr 2017 at 23:14, Christopher Bennage<EMAIL_ADDRESS>wrote:

Yes, we accidentally broke this during a hasty effort to come into
compliance with publishing platform.
There are actually a couple of things broken with the build scripts. We
will fix it, but we have a couple of other high priority items that are
taking our attention.
I anticipate getting to this in early May.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mspnp/architecture-center/issues/51#issuecomment-296307085,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFSUwdYNt-vugOpztd7d_sDbgrldXLmks5ryRwbgaJpZM4NEOmR
.

:-)


integrate login system back into header

@BenGamma , this is just a small commit to bring the login system back into the header and some code refactoring.
I used the styled-component button however wanted to add an onClick event to it which was not supported by default. Instead of creating an extra 'onClick' optional prop I've added a slightly complicated looking typescript extension. This is copied from react's default implementation of a  element, so I think it is correct for our element which looks to extend this. It will automatically allow for any button properties, component children etc.
Please take a quick look when you can (I know somebody else was planning to work on further navbar styling so this will need to be committed first). Full list of changes as:

integrate login system back into header
extend types to styled-component button
refactor login from to run from user store
remove login container
add optional app color type list

closes #185

Good for me.
I guess you are talking about #184 & #186 ? For the toggle between public and community site we will probably display the login option only on public site, and access to the community site only once logged in, but that is an further behavior that we will manage later on.


Data processing issues on S3DIS

We confirm that the environment and related libraries have been configured as required, but when preparing the S3DIS dataset, the pkl file could not be generated after the ply file was successfully generated and an error was reported as follows. Is it convenient for you to upload a copy of the processed S3DIS dataset?
Availabel Mem of each GPU: 124268
Traceback (most recent call last):File "main.  py", line 100, in <module>trainer.  train()
File "/root/ERDA-main/utils/trainer.py", line 66, in traing= GraphBuilder (config, verbose-self.verbose)
File "/root/ERDA-main/utils/tf_graph_builder.py", line 47, in__init-dataset= self.  get_dataset (config, verbose)
File "/root/ERDA-main/models/../datasets/tf_s3dis_dataset.py", line 112, in__init,lself.  load_subsampled_clouds(config.  first_subsampling_dl, verbose-verbose
File "/root/ERDA-main/models/.. /datasets/tf_s3dis dataset.py", line 650, in load subsanpled_clouds_alignedsub_xyz, sub_colors, sub_labels= grid_subsampling (xyz, colors, labels, subsampling_parameter)
File "/root/ERDA-main/ops/tf_ops.py", line 121, in grid_subsamplingreturn cpp_subsampling,compute(points, features-features, classes-labels, sanpleDl-sampleDl, verbose-verbose)
AttributeError: module ops.  cpp wrappers.  cpp subsampling, grid subsampling' has no attribute'compute

We confirm that the environment and related libraries have been configured as required, but when preparing the S3DIS dataset, the pkl file could not be generated after the ply file was successfully generated and an error was reported as follows. Is it convenient for you to upload a copy of the processed S3DIS dataset?
Availabel Mem of each GPU: 124268
Traceback (most recent call last):File "main.  py", line 100, in <module>trainer.  train()
File "/root/ERDA-main/utils/trainer.py", line 66, in traing= GraphBuilder (config, verbose-self.verbose)
File "/root/ERDA-main/utils/tf_graph_builder.py", line 47, in__init-dataset= self.  get_dataset (config, verbose)
File "/root/ERDA-main/models/../datasets/tf_s3dis_dataset.py", line 112, in__init,lself.  load_subsampled_clouds(config.  first_subsampling_dl, verbose-verbose
File "/root/ERDA-main/models/.. /datasets/tf_s3dis dataset.py", line 650, in load subsanpled_clouds_alignedsub_xyz, sub_colors, sub_labels= grid_subsampling (xyz, colors, labels, subsampling_parameter)
File "/root/ERDA-main/ops/tf_ops.py", line 121, in grid_subsamplingreturn cpp_subsampling,compute(points, features-features, classes-labels, sanpleDl-sampleDl, verbose-verbose)
AttributeError: module ops.  cpp wrappers.  cpp subsampling, grid subsampling' has no attribute'compute

We have solved this problem and it is the reason that the library does not compile well.

Hi,
Thanks for your interest. Glad that you have solved the problem.
Cheers,
Liyao

when I process the S3DIS,I met this error,did you meet

Hi,
Thanks for your interest.
It seems that you use the wrong files. We use the 'Aligned_Version'. Could you check that?
Best,
Liyao

my dataset is 'Aligned_Version', and Area1-Area4 has been processed successfully. I don't know why there is '_1.2' in the path

than you for your reply. I check my dataset,it's definit ' Aligned_Version',but the method of processed dataset is for ' Stanford3dDataset_v1.2'. so I check the code. I found that default version is 'aligned',but when processed,it became 'full'.I don't know how did this happen,so I modified the version 'aligned'

How much video memory is needed to process the s3dis dataset, I use 4 2080TI gpus, the computer will automatically shut down and abort the process

Hi,
It's probably the problem with the config that you use, please check the version in the config and if it changes during the code execution.
It's also glad to see that you made some progress. To process the S3DIS for the first time, I would recommend having around 64GB CPU mem.

Hi，
I  am really grateful for your reply.
I  used 'free- h' to check CPU mem, the CPU mem is enough.so Do you mean that the GPU has 64G of video mem

Hi,
It seems your hardware should be fine to run the code.
Could you check the log and try to provide more details (output printing / trace-back if any ) regarding the process shut-down?


Add logging to DefinePlugin.js

This PR adds the changes described in #15778. Once merged, this PR will resolve #15778.
What kind of change does this PR introduce?
This change adds logging to DefinePlugin.

Did you add tests for your changes?
No.

Does this PR introduce a breaking change?
No.

What needs to be documented once your changes are merged?
Nothing. In the initial design for this feature, I proposed to use a flag for DefinePlugin logs. Once I started working on this feature I realised that it is probably better to use logger.log(...) since it fits our use case perfectly.

@hdragos Sorry for that, but can you rebase?


Remove every unnecessary any type

I did this mainly to add type to fieldsMap that ended up showing that it might return false! (In edge case)

Pull Request Test Coverage Report for Build 60

19 of 20 (95.0%)  changed or added relevant lines in 1 file are covered.
15 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-14.3%) to 85.306%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

index.ts
19
20
95.0%

Files with Coverage Reduction
New Missed Lines
%

index.ts
15
85.31%

Totals

Change from base Build 54:
-14.3%

Covered Lines:
111

Relevant Lines:
127

💛  - Coveralls

@Mikhus These changes should not have affected tests, not 100% why they did. How do you like this pull request?


Rubocop / code style cleanups

It looks like it's not the same rubocop config we use in the other repos. Do you have an idea how to best sync the style config across repositories?

It looks like it's not the same rubocop config we use in the other repos.

I used the one from fastlane_core, I wasn't sure which one to use

Do you have an idea how to best sync the style config across repositories?

different ideas. It depends if you have other things you want to sync.
Maybe something like

a repo for all the shared configs.
fastlane_common_config.git/common-config/rubocop.yml

a way to share these files into each project. I would use gitsubmodules to include common-config directory into all projects.

then modify the .rubocop.yml to inherit from common-config/rubocop.yml in each project

an optional shortcut to update the Maybe use a rake or fastlane task to do the git submodule update.

You can also replace the git submodule with a simple ruby script to download from github. I would go for git submodule I think.

@lacostej I'm solving this problem right now, already started a new thing countdown :+1:

Thanks for the pull request :+1:


Add Playwright support

Adds support for Playwright test runner. The Playwright runner currently supports basic splitting, include/exclude patterns, retries. Split by example is not yet supported.
Validation
Build the binary and run it from inside internal/runner/testdata/playwright
export BUILDKITE_BUILD_ID=abc
export BUILDKITE_ORGANIZATION_SLUG=my-org
export BUILDKITE_PARALLEL_JOB=0
export BUILDKITE_PARALLEL_JOB_COUNT=2
export BUILDKITE_STEP_ID=xyz
export BUILDKITE_TEST_ENGINE_API_ACCESS_TOKEN=token
export BUILDKITE_TEST_ENGINE_DEBUG_ENABLED=true
export BUILDKITE_TEST_ENGINE_RESULT_PATH=test-results/results.json
export BUILDKITE_TEST_ENGINE_SUITE_SLUG=my-suite
export BUILDKITE_TEST_ENGINE_TEST_RUNNER=playwright
bktec

Nice job!

When this version is released do we need to update the setup docs?
Any readme updates to go in with this too?

When this version is released do we need to update the setup docs?
Any readme updates to go in with this too?

README will be updated when we release the version and requires restructuring. It will be done in a separate PR.


fix the disk tag missing when NDM respawn

related issue: https://github.com/harvester/harvester/issues/2832

hi all, fixed again with the auto-provision case.
Please help to review!


402 create website

Codecov Report

Merging #403 (ae3387a) into master (482fa0a) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head ae3387a differs from pull request most recent head e7e2dde.  Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


User interface improvements

There is a bunch of unrelated minor changes here: fixed various JavaScript strict warnings (in at least one case the warning actually indicated a bug), added a Python script for use with Extension Auto-Installer (yes, yet another build environment), fixed Roots tab being permanent (inconsistent). The main change here is a different table view based on SlickGrid however. Why I did this:

No pagination necessary: SlickGrid will display even large lists efficiently - the entries are only rendered when required.
Better performance: even displaying 500 entries per page caused a noticeable delay.
Better display of owners and edges: the edge name and target are actually displayed inline without having to expand anything (tooltip will display more information). The number of edges/owners links to the details page where full information is available.
Fixed row height: If something doesn't fit in then it is cut off, rest of the text is visible in the tooltip. A single row with masses of content doesn't make scrolling hard.
Column resizing/reordering and potentially also sorting/filtering: these features are built into SlickGrid and don't require any code whatsoever.

The implementation is somewhat hacky, I also didn't bother removing code that is no longer used. The grid doesn't adapt to the window being resized (shouldn't be hard to change). Most importantly however, the changes aren't complete: the Details view needs to be improved next. I think that it should be possible to open multiple Details tabs, one for each object. Tab title should be something like "Details (0x12345678)" then. And it also needs to present the information better: the regular fields should be followed by two table views displaying edges and owners. So you will see all the edges and owners at one glance.
I would like to get your feedback on these changes before I proceed.

Hi palant, thank you for creating the changes. For this version, my experience is as follows:

A new interface, fixed no vertical scrollbar issue, and remove useless index column and "get remaining" button, nice works. But the new colors is a little too harsh.
These entrys seem no longer have sub-menu, the small triangle button does not to work, how to retrieve it.

Requests:

I want a convenient comparison function to identify various differences for identifying memory leaks, like new/changed/removed or bigger/many/... filter.
"Roots" (and other tabs) should be removed or updated after dump a new analysis.

@janodvarko, can you review and reply the pull req?
Otherwise, @palant, can you interest to continue development and release a fork?
Thanks to all.

Ah, I totally missed the pull, I'll take a look at that ASAP
@palant Thanks for the patch!
Honza

A correct, I can see the submenu in Home (and others) tab, just does not in Roots (and Path) tab.

@janodvarko Any news?

The fixes in the patch looks good. I am just worried that the patch needs more work before being applied (or split into more patches)

The implementation is somewhat hacky, I also didn't bother removing code that is no longer used. The grid doesn't adapt to the window being resized (shouldn't be hard to change). Most importantly however, the changes aren't complete: the Details view needs to be improved next. I think that it should be possible to open multiple Details tabs, one for each object. Tab title should be something like "Details (0x12345678)" then. And it also needs to present the information better: the regular fields should be followed by two table views displaying edges and owners. So you will see all the edges and owners at one glance.

I don't know if @palant is still interested in finishing this (give how long time ago this has been done, my fault I know).
In any case, my feedback is positive and it would be great to have this done and merged.
@palant ?
Cheers,
Honza

Frankly, I've given up on ccdump a long time ago :disappointed:. Never managed to get the performance I needed, so rather writing custom scripts to analyze dumps when I need to. Sorry - no, I'm no longer interested in spending time on this.

I see, no problem, thanks for the reply!
I am not going to merge the patch at this point.
Honza


[SMALLFIX] Improve error handling for requestSpace

Before this, all exceptions, including runtime exceptions, would be swallowed and made to seem like the worker was out of space. With this change we properly propagate exceptions through to the client.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10674/Failed Tests: 1org.alluxio:alluxio-tests: 1alluxio.worker.BlockServiceHandlerIntegrationTest.requestSpaceTest
Test FAILed.

Merged build finished. Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10681/
Test PASSed.

Merged build finished. Test PASSed.

@aaudiber Thanks! I left a minor comment.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10690/
Test PASSed.

I've changed this to be backwards compatible with old versions of the client

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10696/
Test PASSed.

LGTM

LGTM


Extract code snippets from how-to-get-all-the-text-in-all-slides-in-a-presentation.md

Extract the code snippets from docs/presentation/how-to-get-all-the-text-in-all-slides-in-a-presentation.md and use docfx snippets to retrieve them from the samples folder and audit the text.

closing as duplicate


[Accordion] Opening second panel scrolls all content off screen

I have 7 panels with a lot of content in each -- on page load all panels open properly. Once I open a second pane, however, the content scrolls up and off screen -- leaving me below the entire set of panels -- with the second panel open.

[ X] This is a v1.x issue.
[ X] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
screne focus should be on top of newly opened pannel
Current Behavior
focus is not at top of newly opened panel - and is quite far down the page
Steps to Reproduce
https://codesandbox.io/s/lxkw18mk2q
I've done my best to explain what's wrong in this sample page.
It seems like when a panel is opened then a panel below it is open, it opens the new panel before closing the first panel, so when the first panel is closed, everything scrolls up by the hight of the panel that was opened first -- leaving focus far below the top of the newly opened panel.  If the panel opened first is below the new panel being open, the behavior works as expected.
Link:
1.https://codesandbox.io/s/lxkw18mk2q
2.
3.
4.
Context
Trying to accomplish a single page with 7 panels of content each in turn hidden with the other is open  -- this is the last issues left to be addressed
Your Environment
The problem was easily reproduced in codesanebox.io

Tech
Version

Material-UI
v1.5.0

React
v16.4.2

browser
any

etc.
windows/mac

@salientknight I'm not sure to understand, how would you expect the expansion panel to support contents that long? I don't see how it could work in the first place. I would discourage you to use it this way, or I'm missing something?

I don't entirely disagree with you -- however, it should still snap to the top of the opened container -- I have to build a functional module so I can prove it's not a good approach. :)

I'm not entirely sure what information you are waiting for? What I need to hide in the expansions is roughly a full page of related information that needs to be accessible but not on the screen all at once. I originally built this at Tabs but the designer wants Accordions. The problem isn's that the accordion behavior is broken is that's the close behavior doesn't seem to be happening in the proper sequence.   If the first open container closed first, the content of the second container would stay on the screen.
Honestly, I can't imagine this being very useful without a few paragraphs of information in them. I definitely exaggerated in the same to make sure the effect was noticed. On a cell phone web for example where there isn't much height at all, this is going to be a problem pretty quickly even without a lot of content.  No one opens an accordion to see what's in the middle or at the bottom of it.

The problem isn's that the accordion behavior is broken is that's the close behavior doesn't seem to be happening in the proper sequence. If the first open container closed first, the content of the second container should stay on the screen.

@salientknight I see your point. It's exactly what I was looking for.
So instead of opening and closing two different panels at the same time. We can do one after the other. It's something the current API allows you to do. Close the panel, wait for the transition to complete, open the next panel. The current transition logic is optimized for small to medium content, what most people should be using the component for.

Awesome thank you :)

I jumped the gun a bit. The code you linked me to is exactly what I am using. The problem isn't that more than one is open at a time. The problem seems to be the order they are opening and closing in.  When the first open panel closes, everything slides up by the height of the panel, pulling what should be the active content off-screen.  Looking at the code demo I linked to, the header tags where it says "focus should be here" or something like that should be in the visual range on the page, but it's not. Is there something in the link you send that I'm missing? B/C otherwise we've just come full circle back to the problem I'm reporting :)

@salientknight I haven't linked you any solution. I was giving you guidance on how to fix the problem:

Close the panel, wait for the transition to complete, open the next panel.

Thank you for the help :)  I found a workable solution. I'll drop it here for the next person who trying misuse this code ;)
` handleChange = panel => (event, expanded) => {
this.setState({
expanded: expanded ? panel : false,
    });
    window.scrollTo(0, expanded.offsetTop-100); //moves the newly opened panel up offeset by 100px
};`

Followed the above but I was still getting some issues because the content was quite large for each panel in my case. There were also some responsiveness issues. Figured out a workaround if anyone's looking:-
const handleChanges = (panel) => (event, newExpanded) => {
    setExpanded(newExpanded ? panel : false);
    let exp = document.getElementById('section-' + expanded);
    let offset = exp?.offsetTop === null ? 36 : exp?.offsetTop;
    window.scrollTo(0, 50 * panel);
  };

const StyledAccordionSummary = styled((props) => <AccordionSummary {...props} />)(({ theme }) => ({
  flexDirection: 'row',
  padding: '0px 0px',

  '& .MuiButtonBase-root-MuiAccordionSummary-root': {
    height: '50px',
  },
...
...
}));

<StyledAccordionSummary
        aria-controls="panel1d-content"
        id={`panel1d-header-` + id}
        expandIcon={<ExpandMoreIcon />}
>...
</StyledAccordionSummary>


Update Ionic and Stencil versions to latest

As stated in the title, please update the Ionic and Stencil versions so we can have a working boilerplate with the latest.

I tried and the layout is broken afterwards. Seams like the latest stenciljs and ionic layout do not support the implementation 😞


Python cannot code navigate some libraries.

Environment data

VS Code version: 1.50.1 (user setup)
Extension version (available under the Extensions sidebar): v2020.9.1143
OS and version: Windows_NT x64 10.0.19041
Python version (& distribution if applicable, e.g. Anaconda): Anaconda3 python=3.7
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
Relevant/affected Python packages and their versions: requests 2.24
Relevant/affected Python-related VS Code extensions and their versions: Pylance v2020.10.1
Value of the python.languageServer setting: Pylance

[NOTE: If you suspect that your issue is related to the Microsoft Python Language Server (python.languageServer: 'Microsoft'), please download our new language server Pylance from the VS Code marketplace to see if that fixes your issue]
Expected behavior & outcome
The only way to access the source file is by going into the site-packages/ directory and directly opening the file.
In my case, ~/Anaconda3/envs/webscraping37/lib/site-packages/urllib3/util/retry.py
My thoughts are that this happens because of how the backward compatibility code is written in requests module.
When you go to ~/Anaconda3/envs/webscraping37/lib/site-packages/requests/util/packages.py, it looks like the below.
import sys

# This code exists for backwards compatibility reasons.
# I don't like it either. Just look the other way. :)

for package in ('urllib3', 'idna', 'chardet'):
    locals()[package] = __import__(package)
    # This traversal is apparently necessary such that the identities are
    # preserved (requests.packages.urllib3.* is urllib3.*)
    for mod in list(sys.modules):
        if mod == package or mod.startswith(package + '.'):
            sys.modules['requests.packages.' + mod] = sys.modules[mod]

# Kinda cool, though, right?

Would it be possible for VSCode to find out the real source of the imported libraries?
I think it should at least tell the user that the library is importable but not reachable in code navigation.
Steps to reproduce:
[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

Try to code navigate

from requests.packages.urllib3.util.retry import Retry

See that it is only accessible to .pyi, not the source code .py itself.

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

This behavior is so dynamic that I don't think we're ever going to be able to support it... This involves 1) a for loop over specific values, 2) importing via some dynamic value, not via import, 3) assigning dynamically to the local scope, 4) string manipulation where the output matters to future behaviors, and 5) assigning values directly into the global module table (which affects all modules in the program as a side effect).
If I'm reading this correctly, this doesn't prevent you from using requests from other code (as we will pull info from stubs), only that you can't navigate around the real code, correct? One of the main reasons for having stubs is that they can hide this sort of dynamic behavior by providing the intended interface, rather than forcing an analyzer to figure out the hacks.

It's been over 30 days since we added "waiting for info" without a reply; I'm going to close this issue to keep the issues clean, but it can be reopened if needed.


Projection Pushdown optimizer on by default

Kyle turned this on by default for batch in #17107, now we turn it on for streaming. Users are able to opt out of the change with the experiment, preserving upgrade compatibility.
(See https://github.com/apache/beam/pull/17107#discussion_r829543160)

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @lukecwik
cc: @ibzib

Run Java PreCommit

Ping @lukecwik

Run Java PreCommit


Current logo gets loaded in briefly

When I go to google.com, I can for a split second see the current logo, before it is then replaced by the classic logo. Is it now possible to reorder the priority so the classic logo takes prescience, or to block the current logo or something?

I might consider running the replacement script at document_start rather than document_end, and then have a wait function in the JS which waits until a logo element is downloaded before running replacement (as not waiting after document_start will cause replacement to run on nothing).
I understand that on slow internet that the new logo may be shown for a long time due to slow loading delaying the document_end "trigger." The JS function I proposed is my best idea on how to approach this and is definitely a TODO after I'm done working on my current project of the UA alt. layout feature.

Fixed in 20aee38 and fba27b6. The favicon and logo replacement code is run by a MutationObserver now, which starts waiting for the logo element to be loaded immediately after the page starts loading (instead of waiting for absolutely everything on the page to finish processing).


Report feature names in fitresult

This PR changes the usage of glm(X, y, ...) to glm(formula, data) so that fitresult reports feature names in the output. For example, before this PR, the names of the features in fitresult where :x1, :x2, .... Now, they take the name of the passed data and the fitresult shows the fitted formula:
julia> X = (; a=[1, 9, 4, 2], b=[1, 2, 1, 4], c=[9, 1, 5, 3]);

julia> y = categorical([true, true, false, false]);

julia> lr = LinearBinaryClassifier(fit_intercept=true);

julia> fitresult, _, _ = fit(lr, 1, X, y);

julia> fitresult[1]
StatsModels.TableRegressionModel{GLM.GeneralizedLinearModel{GLM.GlmResp{Vector{Float64}, Distributions.Bernoulli{Float64}, GLM.LogitLink}, GLM.DensePredChol{Float64, Cholesky{Float64, Matrix{Float64}}}}, Matrix{Float64}}

y ~ a + b + c + 1

Coefficients:
─────────────────────────────────────────────────────────────────────────
                 Coef.  Std. Error      z  Pr(>|z|)  Lower 95%  Upper 95%
─────────────────────────────────────────────────────────────────────────
a              19.1818     1525.99   0.01    0.9900   -2971.7     3010.07
b              27.9007     2951.02   0.01    0.9925   -5755.98    5811.79
c              22.6694     1902.78   0.01    0.9905   -3706.71    3752.05
(Intercept)  -234.541     20231.5   -0.01    0.9908  -39887.6    39418.6
─────────────────────────────────────────────────────────────────────────

Note 1: the type of fitresult does change due to this PR. In essence, to store the information such as feature names, StatsModels.jl wraps a fitted object fit(model, X, y) inside a RegressionModel:
https://github.com/JuliaStats/StatsModels.jl/blob/dee41c287033c0e9c18714a8d63bae61302027a6/src/statsmodel.jl#L75-97
So, that is why, in some cases, fitresult was changed to fitresult.model. This also makes this PR breaking.
Note 2: most of the logic is about handling offset. I doubt whether it is necessary to manually handle offset. Might be related to https://github.com/JuliaStats/GLM.jl/issues/306.

@rikhuijzer Great to get your help here! I think we could happily merge this as is. But I think you will want to consider the following comment first:
This PR changes the form of fitresult but actually makes no observable change to the general MLJ user. This user interacts through the machine interface (rather than the low-level model interface) and inspects all training outcomes using either fitted_params(mach) or report(mach). Now fitted_params(mach) calls fitted_params(model, fitresult) which returns the tuple (fitresult=fitresult, ) by default, but one is encouraged to overload this to something more sensible, which was done in this case:
julia> fitted_params(mach)
(coef = [19.181763436540795, 27.90074681678668, 22.669356788639142],
 intercept = -234.54065292861273,)

julia> report(mach)
(deviance = 5.111376477154906e-7,
 dof_residual = 1.0,
 stderror = [1525.989955771924, 2951.0160293890563, 1902.7782379686707, 20231.540798813898],
 vcov = [2.3286453451167988e6 4.1309530437347214e6 2.8071341146613853e6 -3.0208590983912997e7; 4.1309530437347214e6 8.70849560571115e6 5.295275716293195e6 -5.776954410968086e7; 2.8071341146613853e6 5.295275716293195e6 3.620565022887159e6 -3.8111630494224295e7; -3.0208590983912997e7 -5.776954410968086e7 -3.8111630494224295e7 4.0931524309407127e8],)

This output is identical before and after this PR.
So it would be nice to take this PR one step further and make the feature names accessible to the general user by updating the current overloading of fitted_params.
My suggestion would be to do so in a way that is essentially non-breaking, namely by just adding features = ... to the named tuple returned by fitted_params(model, fitresult).  And one might as well add this to the report as well.
For more on interface points for training outcomes, see here.


Cannot start a connection that is not in the Initial state

I have troubles to get my ASP.NET Core SignalR app working.
I have this server-side code :
public class PopcornHub : Hub
{
    private int Users;

    public async Task BroadcastNumberOfUsers(int nbUser)
    {
        await Clients.All.InvokeAsync("OnUserConnected", nbUser);
    }

    public override async Task OnConnectedAsync()
    {
        Users++;
        await BroadcastNumberOfUsers(Users);
        await base.OnConnectedAsync();
    }

    public override async Task OnDisconnectedAsync(Exception exception)
    {
        Users--;
        await BroadcastNumberOfUsers(Users);
        await base.OnDisconnectedAsync(exception);
    }
}

whose SignalR Hub service is configured as :
public void ConfigureServices(IServiceCollection services)
{
    ...
    services.AddSignalR();
    ...
}

public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerFactory loggerFactory)
{
    ...

    app.UseSignalR(routes =>
    {
        routes.MapHub<PopcornHub>("popcorn");
    });

    ...
}

In my client-side (WPF app), I have a service :
public class PopcornHubService : IPopcornHubService
{
    private readonly HubConnection _connection;

    public PopcornHubService()
    {
        _connection = new HubConnectionBuilder()
            .WithUrl($"{Utils.Constants.PopcornApi.Replace("/api", "/popcorn")}")
            .Build();
        _connection.On<int>("OnUserConnected", (message) =>
        {

        });
    }

    public async Task Start()
    {
        await _connection.StartAsync();
    }
}

My issue is that, when I call Start() method, I get the exception "Cannot start a connection that is not in the Initial state".
The issue occurs either locally or in Azure.
The SignalR endpoint is fine but no connection can be established. What am I missing?

If your start method is called multiple times on the same PopcornHubService you will see that error.
Also, unrelated, but hubs aren't persistent so your Users value will be reset every hub method call.

This is by design at the moment. We may make the connection instance re-usable in the future.

@moozzyk Is there a link to somewhere the discussion about reuse is taking place? The start and reuse thing is a learning stumbling block. From a use perspective, I would like to be able to declare a connection and just use it - hiding some of the plumbing. For example:
const connection = new signalR.HubConnection("/myHub").start();
const val1 = await connection.invoke("invocation1", pars);
const val2 = await connection.invoke("invocation2", val1);

Invoke could check to see if the connection was started and start it if not. Internally a state variable could be set if start was called previously, so it doesn't just start it unintentionally.
I was expecting to see connection/hub state exposed when I first encountered this issue.
if ( !connection.started ) {
  connection.start().then( connection.Invoke("invocation1", pars) );
} else {
  connection.Invoke("invocation1", pars)
}

Even with the ability to check state, this seems to be a lot of unnecessary code for the user. I would never want to call invoke on a closed connection, so it seems that once I have started the hub at some previous point, invoke will always make sure the connection is open/opened.

Is there any workaround to override this design? I am using it in React Native where I have a case to start and stop the connection and restart it. I am using alpha2 final because I have to use core 2.0 and ES5 version work only with React Native.

In the latest builds (preview 2) the connection is re-usable (start can be called after stop/close) and all builds are ES5. We don't support older previews so you'll have to update to preview 2 in order to get that functionality.

so you mean it will work with ASP.NET Core 2.0?

No, SignalR is part of ASP.NET Core 2.1 and requires that. The alpha versions were prototype early releases designed to allow users to try the new APIs and give feedback, but since they released prior to any ASP.NET Core 2.1 release, they were built against ASP.NET Core 2.0.
From preview 2 on, SignalR has required ASP.NET Core 2.1 and it will require ASP.NET Core 2.1 when it RTMs

so if I want to use SignalR I have to use ASP.NET Core 2.1 and only that will provide ES5 client.

The alpha has an ES5 client in dist/browser/signalr-clientES5-1.0.0-alpha2-final.js, but as I said, it is not supported and should not be used in production environments (there are major issues that have been fixed since then).
But yes, SignalR requires ASP.NET Core 2.1


META-INF/scim-changelog.xml::scim-sdk-1.0::pascal knueppel was: 7:54900cba59debc2ce8fe7a3a8067e8b2 but is now: 8:fc78a5690c6c0f158148d1e19cdc6f22

I'm getting the following error
Aug 25 14:30:19 xstage keycloak-start[1279973]: 2022-08-25 14:30:19,485 ERROR [org.keycloak.quarkus.runtime.cli.ExecutionExceptionHandler] (main) ERROR: Failed to start server in (production) mode
Aug 25 14:30:19 xstage keycloak-start[1279973]: 2022-08-25 14:30:19,485 ERROR [org.keycloak.quarkus.runtime.cli.ExecutionExceptionHandler] (main) ERROR: liquibase.exception.ValidationFailedException: Validation Failed:
Aug 25 14:30:19 xstage keycloak-start[1279973]:      1 change sets check sum
Aug 25 14:30:19 xstage keycloak-start[1279973]:           META-INF/scim-changelog.xml::scim-sdk-1.0::pascal knueppel was: 7:54900cba59debc2ce8fe7a3a8067e8b2 but is now: 8:fc78a5690c6c0f158148d1e19cdc6f22
Aug 25 14:30:19 xstage keycloak-start[1279973]: 2022-08-25 14:30:19,485 ERROR [org.keycloak.quarkus.runtime.cli.ExecutionExceptionHandler] (main) ERROR: Validation Failed:
Aug 25 14:30:19 xstage keycloak-start[1279973]:      1 change sets check sum
Aug 25 14:30:19 xstage keycloak-start[1279973]:           META-INF/scim-changelog.xml::scim-sdk-1.0::pascal knueppel was: 7:54900cba59debc2ce8fe7a3a8067e8b2 but is now: 8:fc78a5690c6c0f158148d1e19cdc6f22
Aug 25 14:30:19 xstage keycloak-start[1279973]: 2022-08-25 14:30:19,485 ERROR [org.keycloak.quarkus.runtime.cli.ExecutionExceptionHandler] (main) For more details run the same command passing the '--verbose' option. Also you can use '--help' to see the details about the usage of the particular command.

Not sure what to do. Where did I mess up?

You did not. I would assume you migrated from a previous version?
you can fix this by executing the following sql statement:
update DATABASECHANGELOG_SCIM_JPA_E set MD5SUM = null where 1=1;

due to a bug report I needed to make changes on the liquibase script that are the cause of this result. Sorry for that. LEt me know if it worked

That fixed it. It would be neat if it'd be documented somewhere.

https://github.com/Captain-P-Goldfish/scim-for-keycloak/wiki/How-to-fix:-liquibase.exception.ValidationFailedException:-Validation-Failed:


make overlay OVERLAY=smartcam failed

hello,my friends, recently I use kv260 to study as  a student, and I got petalinux2023.2、vitis 2023.2 、vivado2023.2 installed. when I follow this tutorial https://xilinx.github.io/kria-apps-docs/kv260/2022.1/build/html/docs/build_accel.html, I got "make overlay OVERLAY=smartcam failed" error message，I am new to this, so please give me some advice about how to fix this. And I am confused with question of "why I cant find tutorial about 2023.2 versions".   The detailed message is as belowed.
16:04:26] Starting bitstream generation..
[16:04:26] Phase 16 Post-Route Event Processing
[16:06:53] Run vpl: Step impl: Failed
[16:06:54] Run vpl: FINISHED. Run Status: impl ERROR
===>The following messages were generated while  Compiling (bitstream) accelerator binary: dpu Log file: /home/why/prj/kria-vitis-platforms/kv260/overlays/examples/smartcam/binary_container_1/link/vivado/vpl/prj/prj.runs/impl_1/runme.log  :
ERROR: [VPL 101-2] design did not meet timing - Design failed to meet timing.
Failed timing checks (paths):
{kv260_ispMipiRx_vcu_DP_i/DPUCZDX8G_1/inst/dpu_xrt_i/dpu_wrapper/m_dpu_top/m_buf_writer/dm_write_ctrl/cm_buf_wctrl_augm/state_machines[0].in_chs_cnt_reg[9]/C --> kv260_ispMipiRx_vcu_DP_i/DPUCZDX8G_1/inst/dpu_xrt_i/dpu_wrapper/m_dpu_top/m_buf_writer/dm_write_ctrl/cm_buf_wctrl_augm/state_machines[0].in_chs_cnt_reg[0]/CE}
Please check the routed checkpoint (dr_routed_timing.dcp) and timing summary report (dr_timing_summary.rpt) for more information.

ERROR: [VPL 101-3] sourcing script /home/why/prj/kria-vitis-platforms/kv260/overlays/examples/smartcam/binary_container_1/link/vivado/vpl/scripts/impl_1/_full_write_bitstream_pre.tcl failed
===>The following messages were generated while  creating FPGA bitstream. Log file: /home/why/prj/kria-vitis-platforms/kv260/overlays/examples/smartcam/binary_container_1/link/vivado/vpl/runme.log :
ERROR: [VPL 12-13638] Failed runs(s) : 'impl_1'
ERROR: [VPL 60-773] In '/home/why/prj/kria-vitis-platforms/kv260/overlays/examples/smartcam/binary_container_1/link/vivado/vpl/vivado.log', caught Tcl error:  ERROR: [Common 17-39] 'wait_on_runs' failed due to earlier errors.
WARNING: [VPL 60-732] Link warning: No monitor points found for BD automation.
ERROR: [VPL 60-704] Integration error, Failed to complete hardware generation. The run name is 'impl_1'. An error stack with function names and arguments may be available in the 'vivado.log'.
ERROR: [VPL 60-1328] Vpl run 'vpl' failed
ERROR: [VPL 60-806] Failed to finish platform linker
INFO: [v++ 60-1442] [16:06:54] Run run_link: Step vpl: Failed
Time (s): cpu = 00:00:42 ; elapsed = 01:54:35 . Memory (MB): peak = 468.906 ; gain = 0.000 ; free physical = 26651 ; free virtual = 120928
ERROR: [v++ 60-661] v++ link run 'run_link' failed
ERROR: [v++ 60-626] Kernel link failed to complete
ERROR: [v++ 60-703] Failed to finish linking
INFO: [v++ 60-1653] Closing dispatch client.
make[1]: *** [Makefile:75：binary_container_1/dpu.xclbin] 错误 1
make[1]: 离开目录“/home/why/prj/kria-vitis-platforms/kv260/overlays/examples/smartcam”
make: *** [Makefile:61：overlays/examples/smartcam/binary_container_1/link/int/system.bit] 错误 2

@chkohn thanks for reply, I only got 2023.2 version in my local environment, is there something I can do to let this smartcam project work in 2023.2? I tried ai-box example early, and I got this ai-box overlay example compiled successfully. Besides, I am still confused that why https://xilinx.github.io/kria-apps-docs/kv260/2021.1/build/html/docs/smartcamera/smartcamera_landing.html this kria-docs don't have 2023 versions, and if I can follow this tutorial in 2023.2 version tools, thanks a lot

Based on your provided log, it appears that you were able to build the project in 2023.2 without further modifications so you got lucky there. The only issue is your design did not meet timing.
You can try different implementation strategies and potentially one of them will allow you to close timing in 2023.2. The impl strategy is set here: https://github.com/Xilinx/kria-vitis-platforms/blob/main/kv260/overlays/examples/smartcam/prj_conf/prj_config_1dpu#L44
This tcl code snippet has a list of available impl strategies (the word after the -strategy switch):
create_run impl_2 -parent_run synth_1 -flow {Vivado Implementation 2022}
create_run impl_3 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Performance_Explore
create_run impl_4 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Performance_ExplorePostRoutePhysOpt
create_run impl_5 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Performance_ExploreWithRemap
create_run impl_6 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Performance_WLBlockPlacement
create_run impl_7 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Performance_WLBlockPlacementFanoutOpt
create_run impl_8 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Performance_EarlyBlockPlacement
create_run impl_9 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Performance_NetDelay_high
create_run impl_10 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Performance_NetDelay_low
create_run impl_11 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Performance_Retiming
create_run impl_12 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Performance_ExtraTimingOpt
create_run impl_13 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Performance_RefinePlacement
create_run impl_14 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Performance_SpreadSLLs
create_run impl_15 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Performance_BalanceSLLs
create_run impl_16 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Performance_BalanceSLRs
create_run impl_17 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Performance_HighUtilSLRs
create_run impl_18 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Congestion_SpreadLogic_high
create_run impl_19 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Congestion_SpreadLogic_medium
create_run impl_20 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Congestion_SpreadLogic_low
create_run impl_21 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Congestion_SSI_SpreadLogic_high
create_run impl_22 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Congestion_SSI_SpreadLogic_low
create_run impl_23 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Area_Explore
create_run impl_24 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Area_ExploreSequential
create_run impl_25 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Area_ExploreWithRemap
create_run impl_26 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Power_DefaultOpt
create_run impl_27 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Power_ExploreArea
create_run impl_28 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Flow_RunPhysOpt
create_run impl_29 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Flow_RunPostRoutePhysOpt
create_run impl_30 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Flow_RuntimeOptimized
create_run impl_31 -parent_run synth_1 -flow {Vivado Implementation 2022} -strategy Flow_Quick
create_run impl_32 -parent_run synth_1 -flow {Vivado RQS Implementation 2022}
create_run impl_33 -parent_run synth_1 -flow {Vivado IDR Flow 2022}

It'll be an iterative and tedious approach to try them one by one.
Alternatively, you can open the generated Vivado project (search for the xpr file in the smartcam overlay folder), then copy the above snippet into the Vivado tcl console. It will generate the listed 30+ impl runs for you. You can then run them individually from there or if you have a compute cluster like LSF, you can even run them in parallel. I wouldn't recommend doing that if you run it locally on a workstation.
Once you have found a strategy that meets timing, copy the strategy name into the above mentioned conf file and run the make command again to build the design from scratch.
Hope this helps!

@chkohn Thanks a lot, my friend. I will follow your advice and try it. Thanks.

@chkohn Thanks a lot, my friend. I will follow your advice and try it. Thanks.

Hi @Wanghanying, were you able to figure out which strategy works?

btw the main branch was updated for 2023.2 tools version a while ago. if you use 2023.2 with the latest main branch, you shouldn't be seeing any issues. we will update to 2024.1 in the coming weeks.


Road to unit tests

Since this project raised issues in external users, it's time to improve its resiliency and robustness. This PR:

starts adding unit tests
run tests and docker build in GA - should ensure answer to #8

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b81d884). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #10   +/-   ##
=========================================
  Coverage          ?   52.32%
=========================================
  Files             ?        5
  Lines             ?      172
  Branches          ?       25
=========================================
  Hits              ?       90
  Misses            ?       77
  Partials          ?        5


Backend rename

Renamed all the back end, so it matches the front end, finishes #57
Made sure variables and decision reason logs are consistent with the renames

Gunna merge this one in to prevent issues with future merges so hopefully, it all looks alright!

Yup, everything looks good. You did a much more thorough renaming that I was expecting. Hopefully future developers will thank you for this.

I think this will help future me as the renaming makes some of the logic clearer


git precommit hook is broken

$ git commit -m"test"
.git/hooks/pre-commit: 10: set: Illegal option -o pipefail

It seems the hock assumes that /bin/sh is bash, which is not always the case

Should no longer happen after #86 is merged


[OSD-17712] Add more logging for Account Creation Failure

What is being added?
On CreateAccount error, gets createAccount failure reasons and uses LogAwsError helper to output formatted log
Checklist before requesting review

[x] I have tested this locally
[x] I have included unit tests
[ ] I have updated any corresponding documentation

Steps To Manually Test
Please provide us steps to reproduce the scenarios needed to test this.  If an integration test is provided, let us know how to run it. If not, enumerate the steps to validate this does what it's supposed to.

run make test

Ref OSD-17712

Codecov Report

Merging #775 (08c2e4d) into master (b0c6189) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #775      +/-   ##
==========================================
+ Coverage   42.23%   42.26%   +0.02%
==========================================
  Files          42       42
  Lines        5881     5884       +3
==========================================
+ Hits         2484     2487       +3
  Misses       3166     3166
  Partials      231      231

Files Changed
Coverage Δ

controllers/account/account_controller.go
26.26% <100.00%> (+0.26%)
:arrow_up:

/test validate

/lgtm

/label tide/merge-method-squash

/test validate

/test validate

/retest

/retest

I guess we have to merge https://github.com/openshift/aws-account-operator/pull/776 first and rebase afterwards.
Seems the only complained about unclean working directory is the different image tag.

/lgtm

/approve


fix: fix the issue of generating incorrect Sent time for message body

Description:
This commit fixes a bug in go-rsmq that caused the Sent time of message body to be generated incorrectly. The original code used time.UnixMilli(sent) to convert the Sent timestamp from microseconds to milliseconds, which caused the time to be incorrect.
This commit corrects the conversion to use time.UnixMicro(sent) instead, which generates the correct Sent time.
Changes Made:
Corrected the conversion of Sent timestamp from microseconds to milliseconds by using time.UnixMicro(sent) instead of time.UnixMilli(sent).

I also have a plan to add new unit and integration test cases (elaborating the existing e2e test cases) to cover such kind of possible bugs.


x instanceof Polymer.Base unreliable

Closing this issue due to age and the release of version 1 of Polymer - please feel free to re-open if this is incorrect.


bootstrap italia 2

Hi @peppelinux,
I would like to update static pages and errors pages with bootstrap italia 2.x.
If is ok for you I can migrate from spid-button to ita-button (spid button is not compatible with bootstrap italia 2).
If is usefull I can add the eudi wallet button to ita-button.
What do you think about this idea?

The pages are basend on Bootstrap Italia playground
New discovery:

New discovery mobile version:

New error page:

Improved error style:

Done here:
https://github.com/italia/Satosa-Saml2Spid/pull/94
when eudi will be marged to master this issue will be closed

Done https://github.com/italia/Satosa-Saml2Spid/releases/tag/v2.0.0-RC


0/3 nodes are available: pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 No preemption victims found for incoming pod

Hi,
I created a new Java project using the odo init command. After initializing new components, I ran the command odo dev However it is giving me the following error
0/3 nodes are available: pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 No preemption victims found for the incoming pod.
I want to know do I need to create PersistentVolumeClaims first and define that in generated devfile.yaml

Hi @nishit93-hub,

I created a new Java project using the odo init command. After initializing new components, I ran the command odo dev However it is giving me the following error
0/3 nodes are available: pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 No preemption victims found for the incoming pod.
I want to know do I need to create PersistentVolumeClaims first and define that in generated devfile.yaml

You shouldn't need to create PVCs first. There are some PVCs that odo might request to sync the project sources and, if the devfile contains a volume component, odo would automatically create the PVCs for you (depending on whether the volume component is marked as ephemeral or not). See How odo works for more details.
To help investigate, can you please share your devfile.yaml file?
Also, can you tell us what type of cluster you are connected to? If possible, can you also share the output of the following command (<component-name> is the metadata.namefield in thedevfile.yamlfile, and can also be extracted withyq '.metadata.name' devfile.yaml`)?
kubectl describe pod --selector "app.kubernetes.io/instance=<component-name>"

FYI, I'll convert this issue into a discussion, since this is more of a support question (for now maybe).


[darwin-framework-tool] Always makes Matter.framework a static lib fo…

…r darwin-framework-tool
Problem
darwin-framework-tool is sometimes linked statically, sometimes dynamically. Things will be easier to debug if it is always linked the same way.

Closing for now.


Xbox games dont seem to group with other games

Unless I have done something wrong with the priority levels, any XBox game doesnt seem to be hidden with its regular pc counterparts.
Unfortunately, there are too many overlapping xbox games for me to set up a custom group for each of them.
Example:

Only PC games are hidden by default. You can enable other platforms in the options under "Included Platforms".

Thank you very much! Worked like a charm.


Getting error "Couldn't save to the backend database. If problems persist, you should save your file locally to ensure you don't lose your work." while running collaboration-room with excalidraw-0.17.0

I am trying to run excalidraw with excalidraw-room on Windows 10 machine. The connection is established for collaboration and collaboration happens as well but I keep getting an error "Couldn't save to the backend database. If problems persist, you should save your file locally to ensure you don't lose your work." on all browsers using live collaboration. Do I need to set up a backend database as well for collaboration-room as that is not evident from collaboration-room setup instructions?

The error was happening as persistence store firebase.googleapis.com was blocked in the firewall


How can I fill different colors in up/down area at line chart?

What problem does this feature solve?
I'd like to display like below.

I tried to make with below code, but, I could not make the chart shape like above.
var myChart = echarts.init(document.getElementById('chart'));
var data = splitData([['09:00:00',57000],['09:05:00',56400],['09:10:00',56800],['09:15:00',56300],['09:20:00',56500],['09:25:00',56000],['09:30:00',56100],['09:35:00',56300],['09:40:00',56300],['09:45:00',56200],['09:50:00',56200],['09:55:00',56300],['10:00:00',56400],['10:05:00',56600],['10:10:00',56800],['10:15:00',56800],['10:20:00',56400],['10:25:00',56300],['10:30:00',56300],['10:35:00',56400],['10:40:00',56400],['10:45:00',56700],['10:50:00',56900],['10:55:00',56800],['11:00:00',57300],['11:05:00',57500],['11:10:00',57300],['11:15:00',57200],['11:20:00',57300],['11:25:00',57200],['11:30:00',57100],['11:35:00',57200],['11:40:00',57500],['11:45:00',57400],['11:50:00',57400],['11:55:00',57300],['12:00:00',57200],['12:05:00',57200],['12:10:00',57300],['12:15:00',57300],['12:20:00',57300],['12:25:00',57300],['12:30:00',57300],['12:35:00',57500],['12:40:00',57400],['12:45:00',57500],['12:50:00',57500],['12:55:00',57400],['13:00:00',57700],['13:05:00',57700],['13:10:00',57800],['13:15:00',58100],['13:20:00',57900],['13:25:00',57800],['13:30:00',58100],['13:35:00',58100],['13:40:00',58100],['13:45:00',58100],['13:50:00',58200],['13:55:00',58100],['14:00:00',58100],['14:05:00',58200],['14:10:00',57900],['14:15:00',58000],['14:20:00',58000],['14:25:00',58100],['14:30:00',58000],['14:35:00',57900],['14:40:00',58000],['14:45:00',57900],['14:50:00',57900],['14:55:00',58100],['15:00:00',58100],['15:05:00',58100],['15:10:00',58200],['15:15:00',58100],['15:20:00',58000],['15:30:00',58200]]);
function splitData(rawData) {
	var categoryData = []; var value = [];
	for (var i = 0; i < rawData.length; i++) {
		categoryData.push(rawData[i][0]);
		value.push(rawData[i][1]);
	}
	return {
		categoryData: categoryData,
		value: value,
	};
}
option = {
	animation: false,
	xAxis: { show: false,
		type: 'category', data: data.categoryData,
		axisLine: {onZero: false, show: false}, axisLabel: {show: false},
		splitLine: {show: false }
	},
	yAxis: {
		type: 'value',
		show: false,
		scale: true, axisLine: { show:false }, axisLabel: {show: false, fontSize:10},
		splitLine: { show: false }
	},
	series: [{
		name: 'price',
		type: 'line',
		data: data.value,
		areaStyle: {
		},
		showSymbol: false
	}],
	tooltip: {
		trigger: 'axis',
		backgroundColor: '#505050',
		padding: 5,
		textStyle: { color: '#ffffff', fontSize:10 }
	},
	visualMap: {
		show:false,
		min: 56700,
		max: 56701,
		inRange: { color: ['rgba(81,185,255,0.5)','rgba(255,114,114,0.5)'] },
		outOfRange: { color: ['rgba(255,114,114,0.5)','rgba(81,185,255,0.5)'] },
	},
};
myChart.setOption(option);

The code result :

Could you fix my codes?
What does the proposed API look like?
I'd like to display like below.

I think the only way is to modify your input data that change the baseline from 56700 to 0. For example:
	for (var i = 0; i < rawData.length; i++) {
		categoryData.push(rawData[i][0]);
		value.push(rawData[i][1] - 56700);
	}

I think the only way is to modify your input data that change the baseline from 56700 to 0. For example:
	for (var i = 0; i < rawData.length; i++) {
		categoryData.push(rawData[i][0]);
		value.push(rawData[i][1] - 56700);
	}

i can't see the picture. i guess the areaStyle.origin maybe can solve the problem.
anyway, thanks  your code, it solve my problem.

i can't see the picture. i guess the areaStyle.origin maybe can solve the problem.
anyway, thanks  your code, it solve my problem.


Any good working examples and explaination

I've been using useregex and was able to narrow down 4000+ channels to 125 with this.
-useregex  .*US
But it is missing a few channels that I wanted to add. How can I add additional arguments to the regex?
When I try different variations like below, I just end up with 0 channels.
-useregex  .*US|.MSNBC.us
-useregex  .*US, .MSNBC.us
-useregex  .*US .MSNBC.us

Also when I use .MSNBC.us on it's own, it works. Just showing 1 channel. I just dont know how to merge the 2.

Try -useregex US|MSNBC

When I try your suggestion, I get this error.
 -useregex -useregex US|MSNBC
'MSNBC' is not recognized as an internal or external command,
operable program or batch file.

When I tried your suggestion I get the following error.
 -useregex US|MSNBC
'MSNBC' is not recognized as an internal or external command,
operable program or batch file.


Job summary page

This PR adds a new step (Job summary) to the hiring staff 'Create a job' journey
TODO

[x] Pre-populate about_school field in job summary form with About School data
[x] Refactor .yml files to wrap after 120 characters
[x] Refactor user input sanitization
[x] Product/UX review
[ ] Code review

Jira ticket URL
TEVA-542
Figma for design
Changes in this PR

Rename job_description column to job_summary on the vacancies table and allow it to be NULL
Add about_school column to the vacancies table
Add Job Summary step to the 'Create a job' journey

Screenshots of UI changes

Next steps

Show about_school field on the vacancy in the school overview section that jobseekers see

Is the reason we are adding a new column about_school (rather than use vacancy.school.description) so that it can vary by vacancy?

Is the reason we are adding a new column about_school (rather than use vacancy.school.description) so that it can vary by vacancy?

Yes

massive pull request, maybe unavoidable dunno, but maybe a code smell that tasks could be broken down more? tests look comprehensive , good work

not specifically about this PR, but for discussion, do we have a team GIT methodolgy/workflow/approach - was going to bring this up in retro. for instance in this PR and git history ive seen overall, a bit of interactive rebasing to merge or fixup some commits might be a good idea as its quite verbose


Increased max-width

Increased max-width as requested in https://github.com/igorkamyshev/react-timeline-scribble/issues/3

Hello! Thanks for your PR, good code. 👍
May you attach screenshot with new layout to that?

Sure thing, @igorkamyshev .
Here's how it looks for a relatively wide screen:

![screen shot 2018-07-02 at 14 31 56](https://user-images.githubusercontent.com/16784959/42167079-cf2657e6-7e04-11e8-87d7-d1dd56f7a092.png)

And a narrower screen:

![screen shot 2018-07-02 at 14 31 40](https://user-images.githubusercontent.com/16784959/42167085-d24387c8-7e04-11e8-96db-484036096679.png)

Great, thanks!
Merged. But I publish new release after all Issues for 1.1.0 release will done.


Enum validation fails for numbers

Prerequisites

[x] I have read the documentation;
[x] In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.

Description
react-jsonschema-form fails validation when the schema field has enum validation and a number is selected.
Steps to Reproduce

Go to https://codesandbox.io/s/21j3m9m5qr
Select 1 from the dropdown (also works with 2 or 3)
Click submit

Expected behavior
The demo application should display the following content JSON in the pre tag:
{
  "count": 1
}

Actual behavior
Validation failed, and the following error message was produced.

Version
1.0.6

The issue here is that the default Select widget just uses event.target.value to retrieve the selected value on change, which by default is always a string. https://github.com/mozilla-services/react-jsonschema-form/blob/master/src/components/widgets/SelectWidget.js#L32

You can work around this by setting the type keyword in your schema, so that react-jsonschema-form can correctly infer the type you are expecting, for example:
const SCHEMA = {
  type: "object",
  properties: {
    count: {
      enum: [1, 2, 3],
      type: "number"
    }
  }
};

I've opened a PR to infer the type from the enum if type is not present in the schema https://github.com/mozilla-services/react-jsonschema-form/pull/1100


Bounding box of player vehicle Mustang

Hi,
I wanted to know the car parameters (length, width, height) of player cars. Player measurement does not include bounding_box. I read that the default vehicle is Mustang and I should look for these in Content/Blueprints/Vehicles. But i was not able to locate this. Is it released for public already?
#135

@n-akram even though the player measurement doesn't include the bounding_box information, you still get it as a part of npc measurements.
Just try to dump the measurements with 0 npcs in the scene and you will see what I mean.
Also, I can confirm that the first vehicle instance in the measurements is that of the player vehicle.

@n-akram Yes, it is publicly released. You can see the bounds opening the Mustang blueprint

Note than although the height is not currently adjusted we plan to fix this in the coming release (#83).

@YashBansod

Also, I can confirm that the first vehicle instance in the npc measurements is always of the player vehicle.

This is arbitrary and you should not count with this. Actually, we have noticed this issue and we are going to fix it in the next release; we plan to add the box extend to the player measurements and remove the player from the non-player agents list.

Hi,
Thank you for your inputs. I have tried getting the bounding box. However, I was not able to locate the player vehicle information successfully in the npc measurements. I have used the method of comparing locations to find player in npc. Sample code is as `below.
measurements, sensor_data = self.client.read_data() player_loc = measurements.player_measurements.transform.location for agent in measurements.non_player_agents:     if(agent.HasField('vehicle')):           if((agent.vehicle.transform.location.x - player_loc.x) and (agent.vehicle.transform.location.y - player_loc.y) and (agent.vehicle.transform.location.z - player_loc.z)):                return(agent.id)
I have also tried printing the location information, for all agents. But I could not find any. This is crucial for me as I do not want to include player vehicle in npc vehicles in my studies.
Please help me out with this, or point me in right direction.
I appreciate your help.
Thanks and regards,
-Akram

Hi @n-akram,
The code is already changed to remove the player from the npc list. It is not yet in master but awaiting approval at #272. If urgent you can building from source the branch issue#268, otherwise you can wait for the 0.8.0 release that will be ready hopefully next week.