liblapin: init at unstable-2024-05-20

Description of changes

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

note: II am not sure on what license to put on it, see the license file

note: see the following issue for the src/camera build error with opencv:

https://github.com/NixOS/nixpkgs/issues/313062

Could you also fix the version in the commit title please?

Could you also fix the version in the commit title please?

Done!


Emails Should go to Administrators

Email addresses of administrators should be stored and used to send system emails.

#128


Image is tiny beside the role name

Is it possible to extend the space used for the drop down list to accommodate little bit more space for role's image?
I tried different sizes of the image and it would seem that the image is always scaled down to match width and height which I was not able to figure out - making the image unreadable.
I used this site: https://imgplaceholder.com/ to create a image containing two letters. I used sizes like 100 x 100 and tuned the size all way to 24 x 24, and despite the fact the image looked good in the said site, plugin rendered it to so small (even with 24x24) that I wasn't able to read whats in the image anymore.

Originally this feature was added from PR, and I didn't mean that I was actively implementing it. But I released it because this feature itself does not affect the others.
You may struggle to identify the icon If your monitor is not retina display. I think they are tiny too, so If there is a good solution with CSS, I am trying to fix it.

Would be nice if the size of the image beside role would be globally set from preferences of this addon.

Originally this feature was added from PR, and I didn't mean that I was actively implementing it. But I released it because this feature itself does not affect the others.
You may struggle to identify the icon If your monitor is not retina display. I think they are tiny too, so If there is a good solution with CSS, I am trying to fix it.

I am using 4k display with my mac (using 3.4k x 1.4k resolution).

I enlarged profile icon a little, It's difficult to do more than this.


[Question] Mutex for fiber

I need mutex in the fiber level for protecting data between fibers. Although I found the marl::mutex,  but it is the thread level mutex.   Are there any implementation of mutex for marl like boost::fiber::mutex in boost fiber ?

I am developping a ADAS system. We plan to use marl as our task scheduler system instead of thread pool for improving the performence. So there are a lot of migration work to do. The user of our system are also used to protect share data between task with mutex. So I have to find the substitude for the std::mutex and std::condition_variable for marl.
I can give you a senario. In our system, we have a three node in parallel: prediction_node, planner_node, and hdmap_node.  Each node receives the message from upstream, process it as a task of marl which run in a fiber, and send it to  downstream. hd_map_node will update the HDMap in real time according to the ego car pose. Prediciton task and Planner task need to read the info from hdmap.
So we need a lock when the hdmap_node update the HdMap.  If you have any good practice, don't hesitate to suggest it to us.
Other wise, we want to implement a deterministic recorder && replay based on marl.  We want to implement a lock and condition variable which describe in the paper for reproducing the behavior of our system.
I thank you in advance for answering these questions.
Fonda


bug: Open From Feed Fails When Requiring Credentials

copy of https://npe.codeplex.com/workitem/136

We are using a private nuget feed that requires us to provide our network credentials. Although the package explorer in VS works fine with this feed, the Nuget Package Explorer does not. It returns a 401 status.

I'm still getting a 401 status from a private feed hosted on Visual Studio Online (Team Services). I can't figure out how to configure my credentials. Is there a way to do so?

Still seeing this issue in 3.15.0


fix(firebase): unlink password provider on signin if exists

:tada: This PR is included in version 1.7.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


From private repo

@PRMerger8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


fix: aligns 1inch swap rate with other rates in LLD

📝 Description
Aligns all swap rates in LLD. They were previously misaligned because the 1inch logo was rendered at 24px wide, whereas it should be 28px.
❓ Context

Impacted projects:  Desktop
Linked resource(s):  https://ledgerhq.atlassian.net/browse/LIVE-5152

✅ Checklist

[ ] Test coverage
[ ] Atomic delivery
[ ] No breaking changes

📸 Demo

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

LGTM


pods_evicted custom label

Being able to track evictions by a custom tag (like project or team) would be helpful in building dashboards that cover "what happened to this project", for cases where a project does not cleanly map to a namespace.

Fyi there is some prior discussion about custom metric labels in https://github.com/kubernetes-sigs/descheduler/pull/859

awesome :)

I checked with some folks who know Prometheus a little better than me, and it sounds like our concerns from #859 are valid. Specifically, a metric with custom/dynamic labels could never be marked stable, and there are also performance risks of allowing higher-cardinality metrics. So, we probably will not add this to our default set of metrics. However, we could do something like create a new metric which is "customizable"/"debug-mode" which we don't offer any guarantees on, for situations like this. We are also hoping to allow custom metric definitions as part of the descheduler framework refactor, which is on-going.

/reopen
/remove-lifecycle rotten

With Descheduling Framework, can we create a channel where events are published and subscribed can decide what to do with the information?
This would include the pod, node, and the eviction status (success, skipped, failed)

@a7i you mean different events than k8s events?

/reopen
/remove-lifecycle rotten

/add-lifecycle frozen

/label lifecycle/frozen

/lifecycle frozen


Virtualbox installation - add note about sys pref / security / allow oracle

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

transferred to docs repo issue

transferred to docs repo issue


[french_seeder] Seeder created for French Instructions. NPM Script (n…

…pm run db:refresh) created to refresh database migrations & seed in one command (it basically re-migrates and re-seeds)

Now when user done creating new seeder, just need to only run npm run db:refresh, and it will handle re-migration and re-seeding by itself (no need for you to do anything else but wait) @e-budur @rajan-hiku @huskywhale @sbganesh @DemonFangs


Allow "homeshick clone" to specify name for cloned repo?

Currently if you "homeshick clone" a URL whose basename is the same as a castle you already have (I have more than one repo called "dotfiles" in different places) it simply fails because the target already exists. Maybe there could be some way to specify a name? Regular "git clone" does this with a second parameter but this doesn't work for homeshick which already accepts multiple URLs instead..

I see the problem. However, the homeshick subcommand arguments have remained stable for quite a long time and while the issue is a valid one I am not going to fix this (i.e. I'm prioritizing stability).
You will have to rename the repos after cloning, sorry :-/
Closing as "won't fix".


Dropwizard2 support

@grommitz you've requested to review this quite a while ago. I think it's good to go now.

nice one @hakandilek !


An intermediate level between Gadfly & Compose?

I'm thinking about interactivity a fair bit these days. I'm still learning the code base, but I think I understand enough now to ask an architectural question: might we need a layer of "rendering" that lies between the top Gadfly level and Compose?
Here's one example: say I have a histogram with 10^9 points in it, and I want ~10^4 bins. I want to render this to some Gtk canvas that I can resize and zoom in on. If I have the canvas redraw starting from the top "Gadfly" level, it's going to have to re-bin the points, which from a performance perspective will be too awful to contemplate. So alternatively, I render to a Compose.Context, which makes redrawing very fast. However, now when I zoom in on a small region (my monitor does not have 10^4 pixels horizontally, so I can get more information by zooming), I can't update my tick labels because they've already been rendered in the Context.
I've played around with adding tags (Geom.histogram(tag=:myhist)) to Form objects and then searching the tree for tagged objects and updating them in-place. This is clearly a workable strategy. But I wonder if there's a general need for an intermediate "pre-processed" layer? As another example, when plotting a bunch of points in 2d, you might want to put them in a quad-tree so that updates get fast when you zoom in on a small region.
If there is an intermediate layer, it seems it could do things like computing data limits, etc. Basically any operation that will be of a different order than rendering itself could be.

I've thought a little about this. I think partial re-renders might get very complicated, but with the right indexed data structure, subsetting and binning operations could possibly be made cheap enough that the entire plot could be re-rendered efficiently enough. That could also allow plotting data that's too big to read entirely into memory. One option I've looked at is sqlite's r-tree index, but it might be more efficient to implement something from scratch.
On the gadfly side all that needs to be done is to generalize things like binning, minimum, and maximum which currently assume the input is an array, which seems fairly manageable.

Looking at it a bit more, I think one fairly easy step in this direction is to split render into render_prepare followed by the stuff that happens starting at the call to render_prepared.

I'd like to participate in the discussion by offering an alternative - I've met with Dan a couple of times to discuss the concept of replacing the Cairo based graphics layer with one based on Qt. Qt (vector) graphics would likely speed things up by making it possible to exploit the Qt notion of a graphics view, something completely missing from the Gnome/GTK window model.
Check out the Qt sample code called "40,000 chips." It's in the right ball park to demonstrate what performance could be like with window manager and hardware support for functions like zoom, rotate, and scale. It also demonstrates how the render would be done once and then the resultant qt graphic objects would be repainted as required. Thus the thought that Qt would be an alternative to trying to speed up user interactions with the intermediate layer between Gadfly and Compose.
There are other benefits of using Qt in Julia - one big one would be that Qt has a powerful visual programming paradigm (QML/Quick/Designer).

@protogeezer
You should read-around on julia-users and maybe also on julia related repositories on githup: Enabling access to Qt libraries is major issue with julia that provides direct access to C-APIs but not C++ APIs like Qt. Gtk/Cairo is a simple and good working solution that works cross-OS and can be installed without access to a local C/C++ compiler. Qt has an own build process, C++ APIs and a lot of other 'special' things. And with that it creates some dependencies, that are not easy to avoid.
It's not like i disagree with you, Qt might be in the long run the option for everything on plotting/drawing/painting on screen. But for that it must be enabled to be used and this work is outside the scope of Gadfly/Compose.

@timholy, @Keno
Greetings - I'm here in Seattle this week, and previous plans to meet with Dan seem to have fallen through. I'm eager to contribute to Gadfly but not so much as to undertake a major development effort without some level of agreement that I'm working on something that will ultimately be useful.
The topics of the discussions with Dan were about creating a high performance Qt backend for Compose. As I got further into the design process it became more apparent that to achieve maximum performance and functionality that moving much of Compose into Qt made ever more sense. Similarly, eliminating all remnants of X11 also was necessary.
So, my question is, in the absence of Dan, who can I correspond with about my plans?

@protogeezer
So you already have a working solution on interfacing julia code to Qt5?

I started messing around with Cxx and Qt5 a couple months ago. If it helps at all: https://github.com/tbreloff/Qt5.jl
I was able to do some very basic drawing, but it is nowhere close to a usable product.  However maybe you want to use some of the paint callback interface.

On Jan 8, 2016, at 1:38 AM, Andreas Lobinger<EMAIL_ADDRESS>wrote:
@protogeezer
So you already have a working solution on interfacing julia code to Qt5?
—
Reply to this email directly or view it on GitHub.

I think i remember trying to test this, but both Cxx and Qt5 (which assumes a compositing WM) gave me headaches.

I have a partial vision of one path to provide a julia graphics infrastructure. I really need to debate the alternatives before I (or anyone that wants to jump onboard) launches off on a pretty big development effort. I'll explain briefly. The ultimate design goal is to figure out what will accomplish what Dan and I talked about as (potential) graphics features for Gadfly.
First, I'm not intending to belly up to providing Qt bindings for Julia - unless there is work being done on the Cxx module. Bindings would require, I think, being able to extend Cxx classes in Julia. Julia isn't an OO language and I haven't seen any indication that is the direction things are going. So, I'm making the assumption that I'm going to start off trying to export a set of C functions back to Compose/3D. @Keno
The top level features we discussed: sufficient throughput to support driving animation directly from a plot, 3D, using MathJax (via the QtWebKit classes) for latex annotation (because Qt has an SVG rendering widget that can display -optionally- SVG output from MathJax), much easier compound layouts, using the Qt file generators rather than the myriad backends that exist now, and, as Tim suggested before, support for large scale plots.
I tried to figure out a way to make things work by tweaking GTK. I just couldn't get there from here. There is too much X11 baggage to navigate which makes it hard to envision how to exploit the capabilities of the underlying OS (obviously more so on MacOS and Windows). I kept finding that the features where already supported in Qt - and there were lots of examples of how to move time-critical features down to the native operating system. If I'm wrong about that conclusion I'd really like to know.
One of the side effects of Qt are it's alternatives for scripting. If handled properly those could turn into an uber-emersion capability.
3D may morph from building on the Qt 3D view classes to the VTK qt widget - VTK has many volumetric plots that are way to complex to tackle on a whim. In the long run, adding Blender to the mix could be possible for materials modelers since there is work being done to integrate with Blender with Qt.
The tests I've done so far have led me to conclude that it is necessary to circumvent the Julia RT to achieve reliably fast throughput for animation. (With 0.5 just write a loop that does a bit of computing and then print a value - on my 4GHz iMac there is an obvious stutter - 1,2,3,4,5,think-think-think, 6,7,8,9,10,think-think-think, etc)
One of the unknowns, at this point, is whether the REPL would need to be a Qt app to play nice with the Qt windows that would be used to present the graphics. If so, then would it make sense to replace libUV with the parallel Qt classes? A big but necessary step?

There's some amount of extension possible, see e.g. https://github.com/Keno/CxxROOT.jl/blob/47f19caef3af79fa71a0c52267bccc3fce4f355f/src/CxxROOT2.jl#L487

Thanks, I'll try this to see if it makes it possible to manipulate the C++ objects directly.

Question: can you rely on Qt for zooming? For example, let's say you're hoping to zoom in on data plotted on a graph. You'd like to zoom in on a small region of the data, but you still want the axes painted on-screen so you can see them (and in fact you want the axis ticks, limits to update to the zoom region).

You can access many layers of abstraction with Qt... You could choose to treat it as a replacement for Cairo, or a replacement for Compose, depending on the abstractions you choose. Qt supports a very complete layering of views in a scene, similar in concept to Compose, but you can access raw drawing commands as well. In theory there's nothing you can't do within Qt, but there are a lot of potential design decisions.

On Jan 8, 2016, at 3:05 PM, Tim Holy<EMAIL_ADDRESS>wrote:
Question: can you rely on Qt for zooming? For example, let's say you're hoping to zoom in on data plotted on a graph. You'd like to zoom in on a small region of the data, but you still want the axes painted on-screen so you can see them (and in fact you want the axis ticks, limits to update to the zoom region).
—
Reply to this email directly or view it on GitHub.

Yes! Tom hit the nail on the head on all fronts. Qt offers may powerful features (in a completely cross platform way) - but there has to be structure to the way it's applied or chaos ensues.
The difference between Cairo and Qt is that Cairo is a vector front end to a pixel based backend - the app has to start at the beginning every time something changes. Qt is more OO so the scheme is that the app adds objects to the graphics view that know how to paint themselves when needed. Zooming in on some data  is simple - translate and scale the coordinate system of the widget containing the plotted data, then invoke the repaint operation. No relayout. (Since Qt supports the intermediate layer that started this thread).
Qt also makes it possible to implement the sort of reconfiguring scheme Tim asks about. The object hierarchy would be a container of some sort at the top, with children implementing the axis/label objects and a widget for the plotted objects. In terms of the Compose scheme, there would be all the graphics routines that there are now - since nearly all used for the plotting the data content, but there would also be new higher level constructs for layouts of plots, and for the parts of the plots that need to reconfigure themselves based on a set of parameters.
This is where a good design is critical. To make the reconfiguring as fast and accurate as possible, the axis widget would have to exactly reproduce the range and tick marks that Gadfly would.
I'm on the road this week and next. I can do an example of a simple app to demo the concepts after I get home.
The rescaling is completely fluid using Qt on a Mac. Less so using X11 - but I haven't tried it using the new Wayland? or OpenGL based WMs. They aren't supported on the version of parallels I use.

I've been thinking we should split out the algorithm that decides where to put tick marks into a separate package. Then it would be more modular. Also, I think there's a better algorithm in http://vis.stanford.edu/files/2010-TickLabels-InfoVis.pdf, but I haven't had any time to look into its implementation.

@timholy, did you read all the limitations they list at the end of the paper? And that they actually don't have any good idea how to stop the infinite loop if the constraints of non-overlap is too massive?
I had once a project where i did a plotting facility from scratch (for reasonable fast update, mathplotlib was too slow) and i had the paper on the table, but like similar i read (i should check my bookmarks) there is no final solution to cover all tick/label problems.
Still i agree with you, modularisation in plotting to have dedicated algorithms for dedicated jobs would make some sense.

I did not read it thoroughly, just far enough to see that at least certain elements seem to fix some issues that bothered me about Gadfly's current algorithm. I suspected that using "appearance" as a component of their criteria is the most complicated (but potentially rewarding) aspect, and it's not surprising they didn't get it perfect. One could skip that part (Gadfly doesn't currently consider appearance) and perhaps still achieve improvements.

Tim - it occurs to me we're talking a more complicated path than I first imagined if you literally meant it would be a common occurrence that a julia user would be trying to process 10^9 data points into a histogram. That magnitude of data is going to break julia not just gadfly.
To make that work there would be an intermediate layer but not between compose and gadfly - rather it would be between the file system and julia.
The sorts of (open) systems that handle part of that would be something like Kitware Paraview. Postgresql is a heavy iron dbms that could manage accessing views of huge tables. If that is a "primary" requirement, then some thought could be put into it.

it occurs to me we're talking a more complicated path than I first imagined if you literally meant it would be a common occurrence that a julia user would be trying to process 10^9 data points into a histogram. That magnitude of data is going to break julia not just gadfly

If you try to load a too-large dataset into memory, when all you care about is a histogram, then yes you have a problem.  This is one of those situations where OnlineStats (or maybe AverageShiftedHistograms) would be the appropriate solution.  No need for something so heavyweight like a requirement on PostgreSQL.  I, however, don't think this necessarily needs to be included in Gadfly.  Plots maybe, but probably it should sit among other similar tools to aggregate and visualize large datasets.

I just made that number up, but y'all are a bunch of wimps: I generally like to start my day by performing computations on two or three 100GB mmapped files before breakfast :smile:.
 My point is that one might want to do some precomputations and then pass partially-digested results to Gadfly (e.g., pass a histogram taken at much higher resolution than you'd like to plot, and have Gadfly coarsen it appropriately given the current zoom region). All just examples, but you probably get the general point.
I should also say my immediate need was satisfied by #683, but I left this issue open because obviously a lot more could be done.

Tim:
I'm back from my travels, or I would have responded sooner.
(1) is it possible for you to make one of those he-man sized available so us wimps can work on our upper-body strength by experiencing the joy of over-the-top use case testing? There are big data features on OS X in particular that may be worth comparing to more open sourced and lighter weight alternatives such as HDF5... for example.
(2) I'm ready to either fork or clone Compose and Gadfly to begin implementing the (proposed) Qt backend. @tkelman, I think - since I can't find the thread right this instant, recommended a "gadfly mirror" to enable updates to gadfly while Dan is otherwise occupied. It would be helpful if that could be done (along with appointing the official committer).

I think we only need to go to the length of using a different fork or mirror of any package repositories for cases where no one else has been granted commit access. For Gadfly itself, and probably Compose too, I think work can continue here assuming dcjones trusts the judgement of those who have been granted commit access.

Fair enough. For my purposes, Forking Gadfly and Compose will get things rolling.


Compatibility issue with ActiveRecord 4.2

ActiveModel::Associations seems to be incompatible with Rails 4.2 at the moment.
Any attempt to access a has_many relationship throws the exception undefined method new_record?' for #<MyClass:[object_id]>
It looks like ActiveRecord 4.2 is calling new_record? on 'owner' (i.e. my object) at line 36 of lib/active_record/associations/collection_association.rb.
Looking at the surrounding code I think this is to do with caching, although I've not had time to dig much.
Adding this to the classes that include ActiveRecord::Associations seems to solve the immediate problem, however I don't know what the knockon effects might be yet.
def new_record?
  true
end

Thank you for your report!! :smile:
I have already fixed it.
But I find other probrem on polymorphic association, I don't release next version yet.
I will fix and release soon. please wait.

I have released. :rocket:

:+1:
Thankyou :smile:


"NotImplementedError: Unknown node: pending_xref" error on Sphinx v1.8.4

Hi,
I am using nbsphinx with latest version of sphinx, and I am encountering issues of NotImplementedError: Unknown node: pending_xref when using nbsphinx to read & parse & convert some .ipynb files in my Sphinx project.
I opened an issue on sphinx-doc/sphinx (https://github.com/sphinx-doc/sphinx/issues/6166), but @tk0miya told me that the bug is most likely coming from nbsphinx itself.
Apparently, a pending_xref is generated here:
https://github.com/spatialaudio/nbsphinx/blob/c43ae330f8d466fb3da90eee37f9e492ba17c33b/src/nbsphinx.py#L1353
Do you know why? Could it be removed?
I give more details on my bug and my project on the issue on sphinx-doc/sphinx.
Thanks in advance, and of course I stay at your disposal if need more details.

Thanks for the report!
Could you please create a minimal example project that shows the problem?
Ideally, this should only depend on sphinx and nbsphinx.

Do you know why?

Yes. The pending_xref nodes are used to turn links to Sphinx source files into links to the generated HTML files, see https://nbsphinx.readthedocs.io/en/0.4.2/a-normal-rst-file.html#links-to-notebooks-and-other-sphinx-source-files

Could it be removed?

Not without losing this functionality.

Hi. Okay, thanks for the details!
I don't think I can quickly and easily do such minimal examples, I have a dozen of notebooks in my project, and apparently I cannot know which one created an error (from the error log). Sorry :-(

I don't think I can quickly and easily do such minimal examples

OK, no problem, but then I also can't help you. Sorry :-(

That was a weird exchange...
Do you have any idea how I could nail down the problem and precisely identify which notebook file causes the issue?

You can start removing notebooks as long as the error doesn't go away.
In the end you should have a single notebook.
Then you can start removing cells until you have a single cell.
Then start removing content from this cell.
Then you can remove stuff from your conf.py, etc.
In the end you should have a minimal example.

Hi,
I'll do this as soon as I can. Thanks!

Hi, I don't and will probably never have the time to try, sorry.
(just for curiosity, I tweaked my conf.py file in sphinx to not use the nbsphinx extension on ReadTheDocs, as I modified manually the code of my local sphinx package to fix this error but cannot modify the code used on ReadTheDocs servers, here is the file if you are curious of this specific line: https://github.com/SMPyBandits/SMPyBandits/blob/master/conf.py#L114)

I have a similar issue and in the end, my solution was to rename the notebook file, so there is no work "model", the original name was notebooks/segment-2d_slic-fts-model-gc.ipynb

I have a similar issue it seems to be related to having a cell asking for a password:
# Let's ask for the password and setup ssh agent
import getpass
password = getpass.getpass()+"\n"

The above cell seems to lead to the following error:
Exception occurred:
  File "/g/g19/cdoutrix/miniconda3/envs/kosh/lib/python3.6/site-packages/sphinx/writers/html5.py", line 790, in unknown_visit
    raise NotImplementedError('Unknown node: ' + node.__class__.__name__)
NotImplementedError: Unknown node: pending_xref
The full traceback has been saved in /tmp/sphinx-err-un1e9e6b.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!

@doutriaux1 Can you please provide a minimal reproducible example?
I've tried your code example above, and I'm getting a different error:
StdinNotImplementedError: getpass was called, but this frontend does not support input requests.

It's not surprising to me that this doesn't work.
How would you expect this to behave?


Tools_v0.8.1 _07: Some bubbles are going out of defined boundary while making trails

Release: v0.8.1
Testing Link: http://<IP_ADDRESS>:8080/tools/
Module: Tools page (Bubble Chart)
Description:
Already reported on  /gapminder-tools-vizabi/issues  as :
https://github.com/Gapminder/gapminder-tools-vizabi/issues/54
But it needs to be logged here.

as Hans says, these are terrible events in human history
i suggest leave it up to the user to define the domain in metadata and not to extend it automatically


Freeze

I assume it's caused here, but I didn't verify, can always open an issue downstream later ;)
The following freezes my browser:
American Psychiatric Foundation

The following doesn't:
American Psychiatric Foundation

Thank you for reporting this bug. It has been fixed in v0.3.1.


fix(graph): set schema id by name/message

fix bug :schemaName and schemaMessage not set

Thank you! Please follow the DCO Details link to pass it.

LGTM, thank you! Will merge once all checks passed

ok, I will try to add one.

Merged, thank you!


The results should not be predicted without data on the "Evaluation" page.

System Information (please complete the following information):

Windows OS: Windows-10-Enterprise-21H1
ML.Net Model Builder (Preview): <IP_ADDRESS>2901 (Main Branch)
Microsoft Visual Studio Enterprise 2019: 16.10.2
.Net: 5.0.301

Describe the bug

On which step of the process did you run into an issue: Evaluate page
Clear description of the problem: can predict the result with empty data, this issue appears on Text classification and Value prediction scenarios, not happen on Recommendation scenario.

To Reproduce
Steps to reproduce the behavior:

Select Create a new project from the Visual Studio 2019 start window.
Choose the C# Console App (.NET Core) project template with .Net 5.0;
Add model builder by right click on the project;
After trained;
Navigate to Evaluate page, delete the sample data, then click the "Predict" button, can get the predicted result, this is very strange.

Expected behavior
Should not predict the result if there is no data on Evaluate page, it is recommended to pop up a message to remind user when predicting the result without data.
Screenshots

Additional context
Add any other context about the problem here.

This is a good point. I think it also relates to the consumption of models. It is a very easy (and risky) mistake to run a model without providing it the data it needs. As a personal example, I had a pricing AI many years ago which gave prices every time. Because some users tend to be lazy, some users just kept clicking "Make price" without providing any additional data. It created huge pricing errors.
But I also think there may be cases where we want to run the model even if not all data is available, such as, to give some additional insights for expert users who understand the impact of missing data.
So perhaps, the ML model should have a bool ValidateInput(ModelInput model) method to check the model has all fields set? Then that could be run on this pge Evaluate page.
BTW, I've seen in some cases the model creation failed, and this page helps to check the model can at least be run. If there is large number on inputs, it would be best to let run the evaluation even if there is no data available. This page is not very good for evaluation in many cases because it is slow to use if multiple inputs are required (such as taxi fare example).

@briacht Can we get your thoughts here?

I think it's fine to leave as is. If you train a model with the API and then create a new model input to predict without setting the properties, you'll still get a result.
We could add a warning - something like "You left this input blank which will affect the model results." - @romalpani thoughts?
We should look into inference perf on this step though - "This page is not very good for evaluation in many cases because it is slow to use if multiple inputs are required (such as taxi fare example)" -- thanks for your feedback @torronen

@torronen, regarding your feedback on "This page is not very good for evaluation in many cases because it is slow to use if multiple inputs are required (such as taxi fare example)."  Did you mean the perf is bad, or did you mean it's slow to manually add data? Thanks!

@beccamc Slow to manually add data, because it would be best to try at least 10 different observations. Not sure if it is a good idea but if it had a "next" button to iterate through the test data AutoML used, that would make it easier to make at least a quick sanity test.

Moving this to "Needs design" as we have a few questions for @romalpani

Closing in favor of https://github.com/dotnet/machinelearning-modelbuilder/issues/2101


build: update wasmtime to 3.0.1

Refs
https://github.com/bytecodealliance/wasmtime/pull/5149
https://github.com/bytecodealliance/wasmtime/pull/5015

Looks like WouldBlock was removed in https://github.com/bytecodealliance/wasmtime/pull/5015 without an alternative...
I guess we can't really use 3.0.1


Add detiber to users

Requesting access for testing and replication of issues for kubernetes-sigs and tinkerbell related projects.

Glad to have you aboard! The café configuration still in an alpha state, but the machines themself should be fairly stable.
This should now work: ssh<EMAIL_ADDRESS>(as well as most of the other aliases)

Also, if you need root or docker access on any nodes for testing, don't hesitate to open an issue.


catch unused aliases

Let's create an additional XSL check in eo-parser, which will catch unused aliases. For example, in this code the alias stdout is unused and has to be removed:
+alias org.eolang.io.stdout

[x] > foo
  x.div 42 > @

@andreoss can you fix this?

@yegor256 Taken

@yegor256 Done. Please, close

@andreoss thanks!


Replace use of join

Some parts of plugin use join - replace with joinPathFragments to ensure full compatibility

added in v0.3.3


Running qira with different input requires restarting qira

This is something that's confused me since I started using qira. If I give the binary I'm debugging some input, and now I want to change the input, why do I need to restart qira in order to do so? I can send qira the new input and the output on the command line looks like it's being run, but the web UI shows the old trace.

Press the Left / Right button on your keyboard to switch to other traces.

I see some potential for introducing a feature like this. Since qira is mainly used for debugging and exploit development, it would be great to change the input and rerun, maybe with unique patterns like pwntools cyclic and retain the states from all runs.

I haven't had time to try left/right to see if it works, but I'll try it soon.

This works, it should definitely be documented somewhere.


[Bug]: Incorrect uninitialized variable error when on-fail is used

Description
import ballerina/io;
import ballerina/log;

public function main() returns error? {
    int[] x;

    do {
        x = check fn();
    } on fail var e {
        log:printError("Error initializing x", e);
        return e;
    }

    io:println(x); // incorrect error : variable 'x' may not have been initialized
}

function fn() returns int[]|error => [];

Steps to Reproduce
No response
Affected Version(s)
2201.4.0
OS, DB, other environment details and versions
No response
Related area
-> Compilation
Related issue(s) (optional)
Related issue: https://github.com/ballerina-platform/ballerina-lang/issues/38530
Regression from https://github.com/ballerina-platform/ballerina-lang/pull/38828
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

Closing this issue because this regression issue was resolved with the revert PR. #38530 issue will be used to track the overall on-fail uninitialized variable analysis improvement.


Setting to disable console.logs per generated page

What problem does this feature solve?

When generating thousands of pages the build log becomes enormous.
I'm using Netlify for hosting my static website. They're streaming their build logs to their UI and have a build time limit of 30 minutes. When generating thousands of pages, a delay starts to exist between the log output and the log preview in their UI, causing the build to exceed the build time limit.

What does the proposed changes look like?
Add an option to the generate options to make logging a line per generated page conditional. Just log something like Generated 9000 pages.

This feature request is available on Nuxt community (#c9030)

Is someone working on this? if not I would like to give it a shot.

@seifsay3d It is on progress on #5517

I still have to write some tests, but don't really have time to do so. So please, feel free to give it a go! I already have a PR open.

Alright cool, I'm pretty new to OSS, should I just fork your fork ? add tests and docs and to PR against official nuxt?

Yes, I think that's the easiest way to go. I have to say: I'm pretty new to snapshot testing, so I'm not sure my changes I did in the tests are wanted.

Please hold on. As of thread in related PR we may use log levels for disable per-route logs


Issue 46 - Add Hashicorp vault to all-in-one management hub

Signed-off-by: codejaeger<EMAIL_ADDRESS>This is an attempt to fix #46 . This is still a work in progress and is related to PR 2409 opened in the anax repository.

Closing this because it is out of date and adding the vault container is now being worked on by nathan.


build on arm computer error !

Requirement - what kind of business use case are you trying to solve?

use V1.8.1  build offline on arm computer ,when i got all the dependencies . make  can not success. some error raised, no error message.  can some help ？

Any open questions to address

after glide install  still no dependencies was found  when to make,why?

It does sound like a real compilation problem, but just to confirm: are you able to build Jaeger on a non-ARM machine? If you get similar problems, you might be missing some of the steps listed in the CONTRIBUTING.md.
In any case, I would also like to try it out myself: are you aware of any online resources where I could get an ARM machine to play with?

machine to pla

sorry, no online ARM machine.  i do follow CONTRIBUTING.md to  compile  version 1.8 source code  on non-ARM machine   after  command glide install successful , make still can not found dependencies . i copy all the cache dependencies to the go-path , compile successful, but no  go binary files  and images  found .  can i only run go build in all-in-one directory to build a go binary file?  thinks!

It's still not clear to me whether you are having a setup issue, or something more complex. I can't test on ARM myself, so, I would like to ask you to:

compile the latest version from master (Jaeger 1.8 is old at this point)
compile using the same go version that we use in the CI (1.12.1)

If you still have problems, then try it on a regular x86_64. If you are having a setup issue, it's likely you'd have it on x86_64 as well, and then we can help you.
In time, trying to cross compile targeting ARMv5 failed with:
$ GOARCH=arm GOARM=5 go build -o cmd/all-in-one/all-in-one-armv5 ./cmd/all-in-one/main.go
# github.com/jaegertracing/jaeger/plugin/storage/badger
plugin/storage/badger/stats_linux.go:33:69: invalid operation: int64(valDirStatfs.Bavail) * valDirStatfs.Bsize (mismatched types int64 and int32)
plugin/storage/badger/stats_linux.go:34:67: invalid operation: int64(keyDirStatfs.Bavail) * keyDirStatfs.Bsize (mismatched types int64 and int32)

cc @burmanm

Does it really matter if something doesn't compile on 32-bit ARMv5? Processors with that architecture are not going to run Jaeger.

Does it really matter if something doesn't compile on 32-bit ARMv5?

Not sure. If there's something easy we can do to at least compile, we should do. But it might indeed not matter in the end.
For the record, the same happens for v7:
$ GOARCH=arm GOARM=7 go build -o cmd/all-in-one/all-in-one-armv7 ./cmd/all-in-one/main.go
# github.com/jaegertracing/jaeger/plugin/storage/badger
plugin/storage/badger/stats_linux.go:33:69: invalid operation: int64(valDirStatfs.Bavail) * valDirStatfs.Bsize (mismatched types int64 and int32)
plugin/storage/badger/stats_linux.go:34:67: invalid operation: int64(keyDirStatfs.Bavail) * keyDirStatfs.Bsize (mismatched types int64 and int32)

GOARCH=arm64 succeeds though.

By the way, just saw this: https://blog.travis-ci.com/2019-10-07-multi-cpu-architecture-support

By the way, just saw this: https://blog.travis-ci.com/2019-10-07-multi-cpu-architecture-support

think you for you supporting, finally i  build without ui successfully(change the makefile, using " make build-binaries-linux"), and run it successfully. thanks!

For what it's worth, I was able to build Jaeger for armv7 just now using an amd64 Ubuntu 20.04 userland, go 1.6, and the latest d9453e08a9683cca90e198db62768fe78dd1f9af revision of master.
$ go version
go version go1.16 linux/amd64
$ GOARCH=arm GOARM=7 go build -o cmd/all-in-one/all-in-one-armv7 ./cmd/all-in-one/main.go

I then ran it on a 32-bit armv7 Raspberry Pi 2 system running Raspberry Pi OS (Debian Buster):
pi@pi2:~$ ./all-in-one-armv7 --help
2021/02/22 23:28:36 maxprocs: Leaving GOMAXPROCS=4: CPU quota undefined
Jaeger all-in-one distribution with agent, collector and query. Use with caution this version
by default uses only in-memory database.

Usage:
  jaeger-all-in-one [flags]
  jaeger-all-in-one [command]
...
pi@pi2:~$ ./all-in-one-armv7 2>&1 | head -10
2021/02/22 23:39:24 maxprocs: Leaving GOMAXPROCS=4: CPU quota undefined
{"level":"info","ts":1614055164.873464,"caller":"flags/service.go:117","msg":"Mounting metrics handler on admin server","route":"/metrics"}
{"level":"info","ts":1614055164.8738792,"caller":"flags/service.go:123","msg":"Mounting expvar handler on admin server","route":"/debug/vars"}
{"level":"info","ts":1614055164.8754716,"caller":"flags/admin.go:105","msg":"Mounting health check on admin server","route":"/"}
{"level":"info","ts":1614055164.8760333,"caller":"flags/admin.go:111","msg":"Starting admin HTTP server","http-addr":":14269"}
{"level":"info","ts":1614055164.8762186,"caller":"flags/admin.go:97","msg":"Admin server started","http.host-port":"[::]:14269","health-status":"unavailable"}
{"level":"info","ts":1614055164.8916352,"caller":"memory/factory.go:61","msg":"Memory storage initialized","configuration":{"MaxTraces":0}}
{"level":"info","ts":1614055164.89554,"caller":"static/strategy_store.go:201","msg":"No sampling strategies provided or URL is unavailable, using defaults"}
{"level":"info","ts":1614055165.0275226,"caller":"server/grpc.go:76","msg":"Starting jaeger-collector gRPC server","grpc.host-port":":14250"}
{"level":"info","ts":1614055165.027812,"caller":"server/http.go:47","msg":"Starting jaeger-collector HTTP server","http host-port":":14268"}

It started up fine on that system, but I haven't tested it further yet.


Unexpected behaviour when I have multiple custom_imports in different config files.

Hi, there,
I recently find that custom_imorts in multiple config files may not work as expected: If I write custom_imports in multiple files (i.e., import module in the model config and import dataset in the dataset config), only one of them works. Is it a feature or a bug? Will mmcv fixes it?
Fortunately, I find that most (maybe all) config files inherit default_runtime.py. I then put all my modules there and they are all imported as expected. But documentation about custom_imports is too simple to find something more helpful.
If you treat the custom_imports as a feature, you may need to consider updating the documentation about custom_imports.

It's a feature. You should write custom_imports in  only one config file instead of multi config files, otherwise custom_imports will be overwritten.


Start examples using command line and args

This is a workaround to start the example servers from command line using this file.
You can give args about what to start: example (or no arg), remote_control, qos
Might need renaming of server modules as you removed the "_cp". You only renamed the library, not the examples so should be fine.

I've found it! It's in PEP8:

Comparisons to singletons like None should always be done with is or is not, never the equality operators.

You are right, thanks about that.
I remembered that using this is wrong:
If a==None:
Also pycharm would warn me about that and therefore I write correctly:
If a is None:
But I forgot that this also applies to:
If a:
For a check if a has a value, which is quite commonly used but not quite correct.


Comparison of images with neural style result I don't understand

Hello,
Thank for this implementation, it is a great fun to experiment with. I was interested to compare image with Neural style. I modify a bit the code in order to be able to select an init picture other than random or content. Above that I run only one iteration just to see the loss score.
I compare an image with itself by putting :
init image : image A
style image : image A
content image : image A
loss score : 0000.0000
ok logical
and when I want to compare the distance between 2 images I do :
init image : image A
style image : image B
content image : image B
loss score : 3480.0890
Then, as "init" I put an image E generated with Neural style with as usual a mix: style C + content D. When this init image has been generated it has a loss score around 8 000 000 after a thousand iteration.
when compare this image with its originating set ( C and D), after one iteration  I have :
init image : image E
style image : image C
content image : image D
loss score : 480.0890
That's far less than 8 000 000 score at it's generation. I was expecting a similar score. I tried with other set of pictures, always a lowest score with my "Neural Style Comparison" system.
Did somebody have an explanation for me.
Best Regards

Difficult to say. The program was probably never intended to measure absolute distance between images, but rather use a distance measurement to direct the image generation. Some thought come to mind. I would test this by setting style weight to 0, for instance, to isolate content measurement from style measurement. Then I would pay attention to image size, two measurements are not comparable if the image sizes are different. And of course use the same weights for comparable results.
To me, the last result indicates that image E is quite similar to image D, so perhaps the high loss when generating E was due to style?
Then there is always the possibility that there is some logical error in your modified program.


apache licensing ?

hi,
I'm wondering if you would consider using the apache license ? the apache license includes patent grant and which is a huge thing considering that multiple people may end up contributing to your project (as it should be!!)
I would like to link to this hacker news discussion on this topic - https://news.ycombinator.com/item?id=3402450 . You might recognize some of the commenters.

It depends deeply on the project. Some something like, say, an HTTP API wrapper module, MIT/BSD style licenses are quite sufficient. There shouldn't be something patentable there. Apache, unfortunately, isn't compatible with GPL v2.
But if you're building something like node.js, nginx, or Lucene, choosing MIT/BSD is likely a terrible idea. Apache gives huge protections for unforeseen scenarios: automatic property rights assignment for contributions, poison-pill–like protections against patent suits, &c.
I highly recommend this book on Proprietary Information and Open Source: http://www.amazon.com/Intellectual-Property-Open-Source-Protecting/dp/0596517963

Kenneth Reitz

I'll consider it yes, although in the meantime if it's genuinely a blocker to any companies they could always request a license grant.


Deleting of sections in db file does not work

I have spotted that key value pairs get removed and if there are no KVPs then it should remove the section heading, unfortunately this does not happen and does cause Wasteland to hang.
Refine the code to remove empty sections.

What are you talking about? What sections?

Oops sorry, I thought this was posted in the A3W repo lol

Hehehe no worry AgentRev :)

Still does not remove the section header e.g. [Veh1] but now does not crash the server while loading.

well done! works like a charm again ,)


cr-app-elk771 - Init very slow

Hi, how come in the init phase of the pods a series of folders are copied?
/bin/bash -c ! [ -f /mnt/etc/kubedirector.init ] && cp --parent -ax /etc /opt /usr /var /mnt; touch /mnt/etc/kubedirector.init
This slows down the deployment phase a lot.
A solution to speed up?

Right, this copy is only done if persistent storage is configured. For directories that need to have changes persist across pod restarts, those directories need to be mounted on persistent storage. However if those directories also have initial content in them (in the container image), that content needs to be copied to the persistent storage before we can do such a mount.
If there's a LOT of copying happening, slowing down the initial deployment, then one or more of these two things is true:

The container image is laid out so that "places where user data is written/modified" are intermixed with other nonmutable data, and so it's difficult to arrange directory mounts that only affect that user data.
Or, the mount directories currently specified in the kdapp are too broad, and should be refined (perhaps into certain subdirectories) so that they more exactly cover only the user data locations and don't cover as much nonmutable data.

I don't personally know which of these is the case for the ELK kdapp; we'll need to follow up with the kdapp author.

Saurabh, I'm parking this on with you for now since Om Katthar doesn't have an active account here now. If you don't know who the right person to tackle this is, we will find out.

Should we change our appConfigDefaultMountFolders to be selective "/opt/guestconfig" instead of "/opt"
Also about "/usr". Limit to set of binaries that we require?

We should be as specific as we can for any persisted directories yeah. Unfortunately changing the defaultPersistDirs will probably require updates in various apps and is in general a non-backwards-compatible change, but this problem is coming up a lot.

We should see now whether cr-app-elk771 can be moved to the new storage layout.


protontricks: 1.2.4 -> 1.2.5

Motivation for this change
Upgrade to 1.2.5
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Changelog: https://github.com/Matoking/protontricks/blob/master/CHANGELOG.md#125---2019-09-17

@GrahamcOfBorg build protontricks

[detached HEAD 3900cdf95a6] protontricks: 1.2.4 -> 1.2.5
Author: MetaDark<EMAIL_ADDRESS>Date: Mon Sep 23 17:42:31 2019 -0400
1 file changed, 2 insertions(+), 2 deletions(-)


Qwik uses import before it's processed by vite plugin

Qwik Version
0.12.0
Operating System (or Browser)
stackblitz
Node Version (if applicable)
No response
Which component is affected?
Qwik Rollup / Vite plugin
Expected Behaviour
I'm trying to make Qwik work with Vanilla-Extract. The problem is that VE generates a virtual CSS file that should be imported by Qwik, but that doesn't happen.
Instead I adapted the VE vite plugin so that it exports the css string as part of the import, and I'm giving that to useStyles$(), but that doesn't inject the newly generated css, only the old css from the css.ts file that wasn't processed yet.
Actual Behaviour
Repro link
In dist/build/q-069f...js you can see the result of the build of the header component which imports vanilla-extract css, and in server/entry.preview.mjs you can find the string "this should not be in the build", a string that should not be in the build ;-)
Additional Information
I tried moving the plugins around, but that didn't make a difference.

I am not sure why this is an issue with Qwik, but looking

@manucorporat actually I just realized it could be the same bug, twice :)
The first bug is that Qwik doesn't use the generated CSS file, which is imported from the transformed .css.ts file
This made me add the css export, which is also not read after transform, but before.
So I think the bug is that the Qwik vite plugin reads files before other plugins transformed them.

Maybe all that needs to happen is to remove this line?
https://github.com/BuilderIO/qwik/blob/main/packages/qwik/src/optimizer/src/plugins/vite.ts#L57

Hmm I tried overriding enforce and it doesn't seem to make a difference

The repro now works :) No change on Qwik side needed, but on VE https://github.com/vanilla-extract-css/vanilla-extract/pull/895


IAM role alias

What would you like to be added:
If role aliasing (see IoT IAM for details on role aliases) comes to be rolled out to broader AWS, I would like to be able to use a role alias rather than a full role ARN when annotating a service account / pod with an IAM role.
Why is this needed:

This would be useful for reducing automation code in the following scenario.
You have multiple AWS accounts, each with kubernetes cluster(s) running for any given business reason (departments, multi-tenancy, etc.).
Using a centralised CI system, you have one application that you wish to deploy to a number of clusters in separate accounts. Each instance of this application will need to interact with the AWS account it is deployed in, and will need an AWS role in each account accordingly.
Currently the deployment pipeline for said application would look something like:

test / build
get / create / interpolate role for the application to use on deployment
package
deploy
test / verify / notify

This pipeline could be simplified by the requested feature if you know ahead of time that a role of a given alias will always exist in the target accounts, then there is no need to interpolate account ID.

Hi, we have the same issue. I'm not sure if we're looking for the exact same solution, because I didn't find out what IoT role aliases are based on that link :) Sorry if I'm hijacking this issue and this does not solve your problem:
I propose that either

role/s3-reader (I like this best, are there any downsides?)
arn:aws:iam:::role/s3-reader
arn:aws:iam::$AWS_ACCOUNT:role/s3-reader

expands to arn:aws:iam::111122223333:role/s3-reader (assuming the EKS cluster is in account<PHONE_NUMBER>33).
diff --git a/pkg/cache/cache.go b/pkg/cache/cache.go
index b899c6a..74776b9 100644
--- a/pkg/cache/cache.go
+++ b/pkg/cache/cache.go
@@ -22,7 +22,8 @@ import (
        "time"

        "github.com/aws/amazon-eks-pod-identity-webhook/pkg"
        "k8s.io/api/core/v1"
+       "github.com/aws/aws-sdk-go/aws/arn"
        "k8s.io/apimachinery/pkg/fields"
        "k8s.io/apimachinery/pkg/labels"
        utilruntime "k8s.io/apimachinery/pkg/util/runtime"
@@ -51,6 +52,7 @@ type serviceAccountCache struct {
        annotationPrefix   string
        defaultAudience    string
        defaultRegionalSTS bool
+       defaultAccount     string
 }

 func (c *serviceAccountCache) Get(name, namespace string) (role, aud string, useRegionalSTS bool) {
@@ -79,11 +81,25 @@ func (c *serviceAccountCache) pop(name, namespace string) {
        delete(c.cache, namespace+"/"+name)
 }

+func (c *serviceAccountCache) arnWithDefaultAccount(arnAnnotation string) string {
+       parsedARN, err := arn.Parse(arnAnnotation) // "arn:aws:iam::123456789012:role/eksctl"
+       if err != nil {
+               klog.V(5).Infof("Could not parse ARN %s: %v", arnAnnotation, err) //namespace, name)
+               return arnAnnotation
+       }
+
+       if parsedARN.AccountID == "" {
+               parsedARN.AccountID = c.defaultAccount
+       }
+
+       return parsedARN.String()
+}
+
 func (c *serviceAccountCache) addSA(sa *v1.ServiceAccount) {
        arn, ok := sa.Annotations[c.annotationPrefix+"/"+pkg.RoleARNAnnotation]
        resp := &CacheResponse{}
        if ok {
-               resp.RoleARN = arn
+               resp.RoleARN = c.arnWithDefaultAccount(arn)
                resp.Audience = c.defaultAudience
                if audience, ok := sa.Annotations[c.annotationPrefix+"/"+pkg.AudienceAnnotation]; ok {
                        resp.Audience = audience

cc @micahhausler


TRying first PR

:warning: This is a Pull Request Template :warning:

Checkout all the things you've done by placing an x within the square braces below.

Proposed Changes

[X] I've read the CODE OF CONDUCT and abide to it.
[X] I've read the CONTRIBUTING.md
[X] I've forked the repository.
[X] I've created a branch and made my changes in it.
[X] I understand opening a PULL REQUEST doesn't mean it will be merged for sure.

Your local editor has changed the character encoding, breaking other peoples entries (in your branch). I'm unsure how can you change it back now. You'll need to create a new PR having updated your encoding to UTF8.


Added dwell count

Add dwell count logic.

Please add node and service level tests for minimum dwell count


how to do partial search of strings

only full text match is supported. the partial match is giving empty result. How to do partial search??

Elasticsearch supports a number of different types of partial match: prefix, wildcard, regexp, ngrams and two different types of search-as-type query, so how you would do a partial search would depend on which type you wanted to do.
As an example though, here's a simple example of a wildcard search that word for me:
$results = Product::searchByQuery([
        "wildcard" => ['_all' => "r*do?"]
]);

One little gotcha - when doing this sort of wildcard search you need to cast your search string to lowercase, as that's the way that Elasticsearch indexes your text. So the example above would return products containing the text "Random" in any of the indexed fields, but "R*do?m" would return nothing.


fix: allow pipeline to start with redis isbsvc (Fixes: #1513)

fixes #1513
Moved all the Jetstream pool initializations inside the Jetstream specific branches of code.
Conditionally avoided certain test suites items on unsupported Redis features that are: reducing, side inputs, or watermarks.
Current tests status:
test-e2e: # Passing after disabling TestDropOnFull and TestWatermarkEnabled for redis
test-kafka-e2e: # Untested
test-http-e2e: # Untested
test-nats-e2e: # Untested
test-sdks-e2e: # Untested
test-reduce-one-e2e: # Disabled all individual tests for redis
test-reduce-two-e2e: # Disabled all individual tests for redis
test-api-e2e: # Untested
test-udsource-e2e: # Untested
test-transformer-e2e: # First test of the suite is timing out, are transformers unsported with redis as well ?
test-diamond-e2e: # Passing after disabling TestJoinOnReducePipeline for redis
test-sideinputs-e2e: # Disabled all individual tests for redis

Let me know if it's ok to also ignore the transformers tests with the redis ISBSVC.

Need to update the github CI to enable redis as welll.

I replaced all the returns with SkipNow.
Are transformers also unsupported with Redis ? These tests fail as well. In that case I will skip them as well, once I got your confirmation :pray:
I will also run all the test (unit and E2E) to double-check it's all good when I got a bit of time.

I replaced all the returns with SkipNow. Are transformers also unsupported with Redis ? The test-transformer-e2e suite fails. In that case I will skip them as well, once I got your confirmation 🙏 I will also run all the test again (unit and E2E) to ensure it's all working as expected once I get a bit of time.

The transformer-e2e-test checks watermark, that's why it is not working.
Added redis to https://github.com/numaproj/numaflow/blob/main/.github/workflows/ci.yaml#L142 to see how the CI jobs will look like.

The transformer test that was using Watermarks should be skipped now :+1:
I also fixed a typo that slipped through. Language server is broken in these folders for me because the folder name and package name differ.
Only remaining thing is to modify the CI. I need to dive a little into it because I've been using Gitlab for years and never got my hands on Github actions. Probably during next week if you guys don't do it before :+1:

I disable two last tests when using the redis ISBSVC in the sdk suite that were using reduce and transformers.
This was the last failing tests as far as I know so it should be good to merge!


CORS Error While Setting Up B2B Edition Locally

I attempted to set up the B2B Edition on my local environment (http://localhost:3000/), but I encountered a CORS error
Error details:
Uncaught (in promise) Error: {'allowed_cors_origins': [ErrorDetail(string='Invalid data', code='invalid')]} at b3Fetch.ts:104:15
Please help me set up B2B Edition locally without the CORS error.
Thank you!

Go to apps/storefront/src/utils/loginInfo.ts and edit below thing
const { origin } = window.location; change to
const origin = 'your-store-url'; // bc stront front url

@jet-gunay You can only use registered sites in https://api.bigcommerce.com/stores/[store_hash]/v3/sites, otherwise you will get that error
Could you also provide more information? Like the payload, tools that you're using or a video when the error happen would be helpful


Claiming the bounty button should open the discord link in the new tab

Is your feature request related to a problem? Please describe.
Currently, claiming the bounty from the front-end navigates the current tab to discord web app which is annoying in case you want to look at the bounty board again.
Describe the solution you'd like
Claiming the bounty button should open Discord link in the new tab
Describe alternatives you've considered
N/A
Additional context
N/A

Incorporated into #195


Changing between light and dark theme doesn't update some icons.

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Antergos x86_64 - a88543c
Issue description:

Scene tab

EditorAbout

Help PopupMenu

Audio bus

Debugger

EditorFileDialog

Performance tab "start profiling" button
Project settings search
Steps to reproduce:

Editor settings: interface/theme/preset = Light

yeah it needs restart, or some refactoring of the icon setup process for multiple classes (icons are set when ready, but they should also be set when EDITOR_THEME_CHANGED), im pretty sure there is an issue about this, but i could not find it.


Migrate jQuery to Fetch

jQuery is bulky; need something lighter, Fetch polyfill looks good

jQuery is still here 👎 this is because Materialize needs it


Add e2e tests to see whether middleware dispatches actions correctly

@nickbalestra @goshakkk let me know what you think of these e2e test. Added an XXX comment because for async actions (xs.periodic) I can't seem to find a way to test them. Perhaps cyclejs/time will help.

Niice!


[ISSUE #3860] rocketmq/es log plugin client authorize field and refactor log plugin

Description
rocketmq/es log plugin client authorize field and refactor log plugin.
 #3860
Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@moremind pls comment or review after checks passed.

pls check ci

Codecov Report

Merging #3884 (323685c) into master (b471b4d) will decrease coverage by 0.62%.
The diff coverage is 43.44%.

@@             Coverage Diff              @@
##             master    #3884      +/-   ##
============================================
- Coverage     64.85%   64.23%   -0.63%
+ Complexity     6135     6089      -46
============================================
  Files           900      902       +2
  Lines         24904    24868      -36
  Branches       2244     2234      -10
============================================
- Hits          16152    15973     -179
- Misses         7346     7498     +152
+ Partials       1406     1397       -9

Impacted Files
Coverage Δ

...rvice/converter/DivideSelectorHandleConverter.java
50.00% <0.00%> (ø)

...ervice/converter/DubboSelectorHandleConverter.java
22.22% <0.00%> (ø)

...service/converter/GrpcSelectorHandleConverter.java
22.22% <0.00%> (ø)

.../converter/SpringCloudSelectorHandleConverter.java
18.18% <0.00%> (ø)

...service/converter/TarsSelectorHandleConverter.java
22.22% <0.00%> (ø)

...plugin/logging/common/config/LoggingApiConfig.java
0.00% <0.00%> (ø)

...mmon/handler/AbstractLoggingPluginDataHandler.java
0.00% <0.00%> (ø)

...icsearch/config/ElasticSearchLogCollectConfig.java
71.42% <25.00%> (-28.58%)
:arrow_down:

...icsearch/client/ElasticSearchLogCollectClient.java
63.79% <33.33%> (-10.21%)
:arrow_down:

...ice/converter/AbstractSelectorHandleConverter.java
83.33% <50.00%> (+4.16%)
:arrow_up:

... and 54 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

pls resolve conficts

@yu199195 pls review. Thanks.

pls check ci


MissingReferenceException occurs occasionally when stopping game

About 20% of the time I stop the game in the editor I get a MissingReferenceException occurring in VisualDebugging. I created a new project and an empty scene with only a camera with the code in the following gist attached and I still get the error. Try playing and stopping over and over again and you should be able to reproduce it.
https://gist.github.com/SvDvorak/a15926de8c4f8f519498

Ok, thanks. I think I saw that one, too. It won't break anything, but I guess it's annoying :)
I'll take a look at it

I've had it for a while and it got a bit too annoying, especially when you have other errors it just becomes noise. Thanks!

I changed a few things in Entitas 0.29.0
Let me know if it fixes your issue, otherwise I'll finally add if null check :)

I haven't seen this in awhile but I didn't really see it in my project when I started it under 0.28.2. I used to see it all the time when working on my example project.
I do plan to upgrading that project when I get a block of time but it probably won't be for at least a month.

Still happening for me on 0.29.1. Also while exploring the Entities in Pools in the scene hierarchy I get the occasional TreeView exception.

Just fixed it. Will be in the next release. Happy coding! :)


Implemented model.xml parsing

This PR implements the ability to parse a model.xml. It puts the parsed data into the class structure defined in #6.
The implementation is not complete yet. The follownig aspects are still missing:

[x] Parse relationships
[x] Connect nodes with the parsed relationships
[ ] Document the code
[ ] Fix the following issue with the parsing api: Currently documents containing spaces for better readability cannot be parsed properly. Currently all model.xml files need to be uglyfied (cannot contain spaces outside of elements)

Important: This Implementation builds on a slightly modified version of the class model described in #6 it is probably better to just merge this Pull request instead of #6.

Codecov Report

Merging #12 into master will decrease coverage by 40.54%.
The diff coverage is 59.01%.

@@              Coverage Diff              @@
##             master      #12       +/-   ##
=============================================
- Coverage       100%   59.45%   -40.55%
- Complexity        2       50       +48
=============================================
  Files             1       12       +11
  Lines             2      185      +183
  Branches          0       26       +26
=============================================
+ Hits              2      110      +108
- Misses            0       57       +57
- Partials          0       18       +18

Impacted Files
Coverage Δ
Complexity Δ

...na/transformator/model/ConnectsToRelationship.java
0% <0%> (ø)
0 <0> (?)

...cana/transformator/model/HostedOnRelationship.java
0% <0%> (ø)
0 <0> (?)

...n/java/de/toscana/transformator/util/XMLUtils.java
0% <0%> (ø)
0 <0> (?)

...a/de/toscana/transformator/model/Relationship.java
0% <0%> (ø)
0 <0> (?)

.../toscana/transformator/model/ParsingException.java
20% <20%> (ø)
1 <1> (?)

...java/de/toscana/transformator/util/CheckUtils.java
40% <40%> (ø)
2 <2> (?)

...va/de/toscana/transformator/model/MachineNode.java
58.33% <58.33%> (ø)
3 <3> (?)

...va/de/toscana/transformator/model/ServiceNode.java
63.63% <63.63%> (ø)
6 <6> (?)

...a/de/toscana/transformator/model/ArtifactType.java
64.28% <64.28%> (ø)
3 <3> (?)

...main/java/de/toscana/transformator/model/Node.java
69.23% <69.23%> (ø)
19 <19> (?)

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20c1b63...0d47331. Read the comment docs.

what about changing the way how implementation artifacts are listed from 'nodename/scriptname' to 'scriptname'?
<Node>
<ImplemenationArtifacts>
<Start>start.sh</Start>
<-- instead of <Start>nodename/start.sh</Start> -->
</ImplementationArtifacts>

Seems to be a good idea for Nodes, however it seems to make things more complicated when looking at ConnectsTo relationship artifacts.

If we establish this simple rule in the spec we can solve the ambiguity:
'ImplementationArtifacts of Relationsships have the static part of their relative path set to the source's directory.'
We could even offer both: preprend the path with / gives you absolute paths.


MVC View creation change in VS 2019

Not a C# dev so just going through this to get a sample app created. I find that to add a view to the project the only options are "Razor View", so seems that the workflow has changed. The initial steps to create the view and the screenshots would need to be updated for this process in VS 2019.
I don't have lower versions installed to verify the process is any different.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 788d46c9-a91a-2788-8db7-b53c37b512f2
Version Independent ID: 00c2c01d-d235-2d2d-5c96-1f33a9314382
Content: Add a view to an ASP.NET Core MVC app
Content Source: aspnetcore/tutorials/first-mvc-app/adding-view.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

It's the same.

I just went through the whole tutorial and can tell you the instructions could not be followed as is on 2019.
But if y'all want to leave it that is your decision.

Your screenshot in the doc shows this:

Your steps show:
In the Add New Item - MvcMovie dialog

In the search box in the upper-right, enter view

Select Razor View

Keep the Name box value, Index.cshtml.

Select Add

Dup of #16818
This will get updated in the next doc sweep.


upgrade clang-tidy to v17 on CI

The latest CLion 2024.2 comes with clang-tidy v17 builtin.
It would be nice that local clang-tidy warnings match to the CI.
In this case we can have a feedback from the IDE and solve them as they appear before we reach CI.
Could use a prebuilt binary from this repo:
https://github.com/muttleyxd/clang-tools-static-binaries/releases

CC @yperbasis

see also https://github.com/erigontech/silkworm/pull/2276


ci: add mypy test and semver

Description
resolve #37 , #38
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds new typings)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

:tada: This PR is included in version 0.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


refactor: namespace repository, handle encryption in service

The POST namespace API is not returning the id in the response payload.

There is test coverage missing on encrypt/decrypt function in the namespace service. Let's not miss coverage on core business logic.


WIP: Upgrade to retrofit 2

@1zaman @miankhalid @bguertin
I may be crazy but nothing seemed to have broke when I changed this. I'm crazy right?

I may be crazy

Correct. https://futurestud.io/blog/retrofit-2-upgrade-guide-from-1-9

nothing seemed to have broke

That's because Retrofit1 is still included; it's a dependency of com.jakewharton.retrofit:retrofit1-okhttp3-client:1.0.2

Hmm... so how would we want to upgrade this? It's all over the place. Would we just slowy start to migrate this over?

so how would we want to upgrade this

We should architect the individual requests such that they do not depend on the retrofit version, or any particular networking library for that matter.
This is at odds with the design of Retrofit: Retrofit service definitions depend on Retrofit's annotations, and callers must use the retrofit-specific Call class.
I recommend migrating away from retrofit towards a simple abstraction layer, such that we can define API endpoints in a library-agnostic fashion. OkHttp already provides a high-level HTTP interface.

https://openedx.atlassian.net/browse/MA-2185
Should we even worry about updating to retrofit2?

Should we even worry about updating to retrofit2?

If we want to stick with retrofit, yeah we should upgrade. But IMO it's worth having our own library-agnostic abstraction.

What is the advantage of specifically migrating away from retrofit vs just having a shim interface that can be backed by anything for any particular call (including retrofit).
I'm not against doing it (we have our own thing on iOS though the story was a little different), just want to make sure it's worth the effort?
Anecdotally, I was messing around on the side with retrofit + the rxjava call adapter + a little shim layer and it worked pretty well while still having a reasonable amount of abstraction barrier.
(RxJava is definitely overdesigned, but that's a side note)

What is the advantage of specifically migrating away from retrofit vs just having a shim interface that can be backed by anything for any particular call (including retrofit)

We don't have to migrate away from Retrofit, but once you introduce an abstraction for representing an API call, there's no longer a need for Retrofit (since, literally all Retrofit does is create an interface for API calls)

Talked offline to @bguertin. I agree that retrofit isn't getting us that much and makes it hard for us to centralize customized request handling behavior.

Retrofit2 is a natural fit w/ RxJava.  If you add a shim layer, would you be preventing any future opportunity to hook in RxJava?

Hi @kenkyee Doing our own small network layer (on top of OkHttpClient) would actually make it easier to use RxJava potentially. For example, on iOS we have a NetworkManager class that has a simple callback based API. It also has a stream based option (complete with a persistence layer) on top of that, with little extra code https://github.com/edx/edx-app-ios/blob/master/Source/Core/Code/NetworkManager.swift#L336
We get this API flexibility by decoupling request declaration from the code that services the request.

That makes sense...as long as the layer exposes Observables, it'd work fine w/ RxJava.  I'd just worry that a shim would only provide callbacks instead of Observables which would lock out use of RxJava.
But then the next question is why isn't your network layer on top of Retrofit instead of OkHttpClient?  Being able to define a REST API contract in a small annotated file is one of the biggest pluses of Retrofit and it seems like you'd lose a lot of that with the NetworkManager.  The other thing is the faster Java deserializers work in streaming mode...i.e., you don't get a JSON string blob and stuff it into the deserializer...you feed it the raw stream to it parses the JSON on the fly; this is also more memory efficient obviously.  It looks like NetworkManager is doing the string blob into parser technique?

With retrofit you have a single method per API that defines a request and is its response interface (callback, observable, synchronous value, whatever).
With the other approach you still get a simple declarative way of writing down what a request is, with the added advantage that you don't have to stuff it all in one interface. For example, https://github.com/edx/edx-app-ios/blob/master/Source/Core/Code/RegistrationAPI.swift#L48
Then you use a network service to provide a way to do things with that request. This reduces coupling between the way you use an API and the declarative notion of the API.
Re: streaming, if OkHttpClient exposes an API that lets us do that then I don't see why we couldn't use it. We don't have to follow what the iOS one does exactly. It's in a slightly trickier situation with deserialization due to the lack of reflection in Swift.

That seems to have a lot of boilerplace compared to declaring something like this for a rest call on an endpoint which is also more typesafe because you get strongly typed objects in and out instead of passing hashmaps of strings:
@FormUrlEncoded
@POST("registration/")
Call registerUser(@Body("registration_data") RegistrationData regData);
You'd write an intercepter annotation class to centralize the error handling for all the API calls to deal w/ the 400 errors or just have the error fields map into the ApiResult class which I think is enough in this case.
Seems more like you'd want an abstract layer on top of all this (ike what bguertin mentioned) that's similar like Server.registerUser(regData) but then you could hide any network calls beneath it.

Oh that may have been a bad example. In general it's a pretty typesafe pattern, but the registration API in particular is defined by a set of arbitrary form fields parsed out of a json blob*. In Java you could certainly define a concise annotation syntax for this if you wanted to that did a little extra checking on query parameters (Swift doesn't have that sort of annotations feature).
Syntax is kind of a red herring here, IMO. It really comes down to what the return type of one of these API definitions is. With this version, an endpoint is a function that returns a Request<A> which is just data describing the request, similar to OkHttpClient's Request type but with some type safety on top. Then you have a separate thing that turns any Request<A> into an actual network call. This is indeed a little more verbose, but it gives you a lot more flexibility in the networking API.
Glad we're having this conversation. Hope it means you're interested!

The registration API actually returns this blob when you GET it, but we're not doing that since we didn't want to have to wait for a network request just to show the registration screen, so we canned it up.

That makes sense.  Using the Request pattern for abstracting calls makes sense...just that getting rid of Retrofit didn't quite make sense to me because Retrofit efficiently reduces code so much :-)


Remove WIP warning

Q
A

Bug fix?
no

New feature?
no

BC breaks?
no

Deprecations?
no

Related tickets

Documentation

License
MIT

Why?
Not really WIP anymore :) Might want to tag the first version as well?

sounds good. i invited you as a collaborator so that you are able to do releases and merge PRs.
i suggest that when you do changes, you still do pull requests and ask for peer reviews.

Great thanks !

i suggest that when you do changes, you still do pull requests and ask for peer reviews.

Sure, no problem :)

feel free to release :+1:
(don't forget to update the changelog file before you do, and maybe check if there is anything you wanted to clean up in the config or code)


Add a proper warning to user for permission denied errors because a project file is open in a different program

updating files doesn't work if file is open elsewhere, but the user isn't appropriately informed that that's the issue, just gets a generic failure

f8bdd5a


incidence, azimuth and look angle files are extraction problem

ariaTSsetup.py doesn't fail but the extracted incidence, azimuth and look angle files are empty even though the file sizes are more than 10MB.
To Reproduce
ariaDownload.py --bbox "18.8 20.3 -156.1 -154.8" -t 124 --start 20181101 --end 20190120

ariaTSsetup.py -f 'products/*.nc' -b "18.8 20.3 -156.1 -154.8" --mask Download --dem Download -mo 20386.82310276927 --verbose

***Time-series Preparation Function:***
Shapefile ./user_bbox.json created for input user bounds.
Multi-core version
All (14) GUNW products meet spatial bbox criteria.
Group GUNW products into spatiotemporally continuous interferograms.
All (9) interferograms are spatially continuous.
Thread count specified for gdal multiprocessing = 2
4 out of 9 interferograms rejected for not meeting specified spatial thresholds
Download/cropping DEM

Extracting unwrapped phase, coherence, and connected components for each interferogram pair
Generating: unwrappedPhase - [==================================================] 20190115_20190103    0s /     0s
Generating: coherence - [==================================================] 20190115_20190103    1s /     0s

Extracting single incidence angle, look angle and azimuth angle files valid over common interferometric grid
Generating: incidenceAngle - [==================================================] 20181210_20181204/Users/havazli/miniconda3/envs/aria/lib/python3.8/importlib/__init__.py:127: MatplotlibDeprecationWarning:
The matplotlib.backends.backend_qt4agg backend was deprecated in Matplotlib 3.3 and will be removed two minor releases later.
  return _bootstrap._gcd_import(name[level:], package, level)

Generating: lookAngle - [==================================================] 20181210_20181204
Generating: azimuthAngle - [==================================================] 20181210_20181204
Directory ./stack already exists.
Number of coherence discovered:  5
[==================================================] 20181210_20181204    0s /     0s
cohStack : stack generated
Directory ./stack already exists.
Number of connectedComponents discovered:  5
[==================================================] 20181210_20181204    0s /     0s
connCompStack : stack generated
Directory ./stack already exists.
Number of unwrapped interferograms discovered:  5
[==================================================] 20181210_20181204    0s /     0s
unwrapStack : stack generated

gdalinfo incidenceAngle/20181210_20181204 -stats

Driver: ENVI/ENVI .hdr Labelled
Files: incidenceAngle/20181210_20181204
       incidenceAngle/20181210_20181204.aux.xml
       incidenceAngle/20181210_20181204.hdr
Size is 1561, 1801
Coordinate System is:
GEOGCRS["GCS_unknown",
    DATUM["D_unnamed",
        ELLIPSOID["Spheroid",6378137,298.257223563,
            LENGTHUNIT["metre",1,
                ID["EPSG",9001]]]],
    PRIMEM["Greenwich",0,
        ANGLEUNIT["Degree",0.0174532925199433]],
    CS[ellipsoidal,2],
        AXIS["longitude",east,
            ORDER[1],
            ANGLEUNIT["Degree",0.0174532925199433]],
        AXIS["latitude",north,
            ORDER[2],
            ANGLEUNIT["Degree",0.0174532925199433]]]
Data axis to CRS axis mapping: 1,2
Origin = (-156.099999999999994,20.300833333333301)
Pixel Size = (0.000833333333333,-0.000833333333333)
Metadata:
  Band_1=Band 1
Image Structure Metadata:
  INTERLEAVE=BAND
Corner Coordinates:
Upper Left  (-156.1000000,  20.3008333) (156d 6' 0.00"W, 20d18' 3.00"N)
Lower Left  (-156.1000000,  18.8000000) (156d 6' 0.00"W, 18d48' 0.00"N)
Upper Right (-154.7991667,  20.3008333) (154d47'57.00"W, 20d18' 3.00"N)
Lower Right (-154.7991667,  18.8000000) (154d47'57.00"W, 18d48' 0.00"N)
Center      (-155.4495833,  19.5504167) (155d26'58.50"W, 19d33' 1.50"N)
Band 1 Block=1561x1 Type=Float32, ColorInterp=Undefined
ERROR 1: incidenceAngle/20181210_20181204, band 1: Failed to compute statistics, no valid pixels found in sampling.
  NoData Value=0
  Metadata:
    STATISTICS_VALID_PERCENT=0

Desktop (please complete the following information):

ARIA-tools git tag:

Author: sssangha<EMAIL_ADDRESS>Date:   Mon Aug 3 18:15:55 2020 -0700

    Save figures as PNG in addition to EPS (#206)

OS: macOS Mojave 10.14.6

@ehavazli I couldn't replicate this error.
gdalinfo incidenceAngle/20181110_20181104 -stats
Driver: ISCE/ISCE raster
Files: incidenceAngle/20181110_20181104
       incidenceAngle/20181110_20181104.aux.xml
       incidenceAngle/20181110_20181104.xml
Size is 1561, 1801
Coordinate System is:
GEOGCRS["unknown",
    DATUM["unnamed",
        ELLIPSOID["Spheroid",6378137,298.257223563,
            LENGTHUNIT["metre",1,
                ID["EPSG",9001]]]],
    PRIMEM["Greenwich",0,
        ANGLEUNIT["degree",0.0174532925199433,
            ID["EPSG",9122]]],
    CS[ellipsoidal,2],
        AXIS["latitude",north,
            ORDER[1],
            ANGLEUNIT["degree",0.0174532925199433,
                ID["EPSG",9122]]],
        AXIS["longitude",east,
            ORDER[2],
            ANGLEUNIT["degree",0.0174532925199433,
                ID["EPSG",9122]]]]
Data axis to CRS axis mapping: 2,1
Origin = (-156.100833333332986,20.300833333333301)
Pixel Size = (0.000833333333333,-0.000833333333333)
Corner Coordinates:
Upper Left  (-156.1008333,  20.3008333) (156d 6' 3.00"W, 20d18' 3.00"N)
Lower Left  (-156.1008333,  18.8000000) (156d 6' 3.00"W, 18d48' 0.00"N)
Upper Right (-154.8000000,  20.3008333) (154d48' 0.00"W, 20d18' 3.00"N)
Lower Right (-154.8000000,  18.8000000) (154d48' 0.00"W, 18d48' 0.00"N)
Center      (-155.4504167,  19.5504167) (155d27' 1.50"W, 19d33' 1.50"N)
Band 1 Block=1561x1 Type=Float32, ColorInterp=Undefined
  Minimum=36.794, Maximum=43.929, Mean=39.946, StdDev=1.647
  NoData Value=0
  Metadata:
    STATISTICS_MAXIMUM=43.929100036621
    STATISTICS_MEAN=39.946399452252
    STATISTICS_MINIMUM=36.793869018555
    STATISTICS_STDDEV=1.6473984439886
    STATISTICS_VALID_PERCENT=46.4

Perhaps some products are corrupted? I should also note that the reference interferograms chosen to extract metadata fields--always the first in the stack--for your case was 20181210_20181204, while for me it was 20181110_20181104 after following your download instructions. Can you confirm why this earlier product wasn't used as a reference on your end?
Also, it looks like you haven't checked-out the most recent revision, but that shouldn't affect the run in this way.

Same as @sssangha, I do not get the same error. When I copy the commands exactly from the Reproduce section, I get the following error:
(ARIA-tools) [rzinke@sar T124]$ gdalinfo incidenceAngle/20181210_20181204 -stats
ERROR 4: incidenceAngle/20181210_20181204: No such file or directory
gdalinfo failed - unable to open 'incidenceAngle/20181210_20181204'
meaning that ARIA-tools is using slightly different files from you. It appears that AT is tossing out some duplicated files or has added new ones during download. Instead, AT generates incidence angle for 20181110_20181104, which has valid stats. Exactly like Sim.
Could you rerun the commands in a new folder and see if that works?

@sssangha
I was making multiple tests with different time extents to avoid possible corrupt products just like you mentioned. The discrepancy between the start date and primary date should come from me pasting the output of one of those tries.
I haven't checked out the latest version to test the latest release.

@ehavazli I also tried just extracting the incidence angle layer for this interferogram 20181210_20181204  separately and it still isn't blank on my end:
gdalinfo -stats incidenceAngle/20181210_20181204
Driver: ISCE/ISCE raster
Files: incidenceAngle/20181210_20181204
       incidenceAngle/20181210_20181204.aux.xml
       incidenceAngle/20181210_20181204.xml
Size is 1561, 1801
Coordinate System is:
GEOGCRS["unknown",
    DATUM["unnamed",
        ELLIPSOID["Spheroid",6378137,298.257223563,
            LENGTHUNIT["metre",1,
                ID["EPSG",9001]]]],
    PRIMEM["Greenwich",0,
        ANGLEUNIT["degree",0.0174532925199433,
            ID["EPSG",9122]]],
    CS[ellipsoidal,2],
        AXIS["latitude",north,
            ORDER[1],
            ANGLEUNIT["degree",0.0174532925199433,
                ID["EPSG",9122]]],
        AXIS["longitude",east,
            ORDER[2],
            ANGLEUNIT["degree",0.0174532925199433,
                ID["EPSG",9122]]]]
Data axis to CRS axis mapping: 2,1
Origin = (-156.099999999999994,20.300833333333301)
Pixel Size = (0.000833333333333,-0.000833333333333)
Corner Coordinates:
Upper Left  (-156.1000000,  20.3008333) (156d 6' 0.00"W, 20d18' 3.00"N)
Lower Left  (-156.1000000,  18.8000000) (156d 6' 0.00"W, 18d48' 0.00"N)
Upper Right (-154.7991667,  20.3008333) (154d47'57.00"W, 20d18' 3.00"N)
Lower Right (-154.7991667,  18.8000000) (154d47'57.00"W, 18d48' 0.00"N)
Center      (-155.4495833,  19.5504167) (155d26'58.50"W, 19d33' 1.50"N)
Band 1 Block=1561x1 Type=Float32, ColorInterp=Undefined
  Minimum=36.801, Maximum=43.932, Mean=39.952, StdDev=1.646
  NoData Value=0
  Metadata:
    STATISTICS_MAXIMUM=43.931743621826
    STATISTICS_MEAN=39.951890613885
    STATISTICS_MINIMUM=36.801475524902
    STATISTICS_STDDEV=1.6459143698682
    STATISTICS_VALID_PERCENT=46.4

I would rerun in a new folder and redownload as @rzinke suggested. It's concerning though that the problem isn't captured. Did you check the other interferometric outputs though. Potentially there is an issue with the cutline being biases by a shorter IFG for which all frames hadn't been download (e.g. see #208)

@ehavazli suspect this might go back to the installation you are using. Can you provide reproducibility of the environment you are using too? i.e. provide the link to the exact shell script that installs the code.

@ehavazli suspect this might go back to the installation you are using. Can you provide reproducibility of the environment you are using too? i.e. provide the link to the exact shell script that installs the code.

https://github.com/aria-tools/ARIA-tools-docs/blob/aria_sds/JupyterDocs/ariaMintpy_install/ariaMintpy_install.sh

@ehavazli figured it out! I was able to replicate the issue and figured out it was associated with the most recent release of gdal.
I have confirmed that libgdal revision 3.0.4 is stable.
Add this condition to your https://github.com/aria-tools/ARIA-tools-docs/blob/aria_sds/JupyterDocs/ariaMintpy_install/ariaMintpy_env.yml yml file:  libgdal==3.0.4

Thanks for looking into this Sim. Perhaps for now lets us forced 3.0.4 <=
ligbgdal version for ariatools, till fixed by gdal community.
On Tue, Aug 18, 2020 at 8:28 PM sssangha<EMAIL_ADDRESS>wrote:

@ehavazli https://github.com/ehavazli figured it out! I was able to
replicate the issue and figured out it was associated with the most recent
release of gdal.
I have confirmed that libgdal revision 3.0.4 is stable.
Add this condition to your
https://github.com/aria-tools/ARIA-tools-docs/blob/aria_sds/JupyterDocs/ariaMintpy_install/ariaMintpy_env.yml
yml file: libgdal==3.0.4
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/aria-tools/ARIA-tools/issues/210#issuecomment-675830193,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AESZPSJVO6SUYM45SJ63JGLSBNBGHANCNFSM4PX6L3OA
.

@ehavazli after communicating with the GDAL team (https://github.com/OSGeo/gdal/issues/2867), I realized we just need to make a minor change to ARIA-tools instead of just sticking with an older, static build of gdalWarp.
Files cannot be directly overwritten by gdalWarp anymore, so temporary files are created and deleted after warping. This fixes the issue you raised.
So please refer to PR #212 to test this out.

The problem is fixed with the new PR


Literal types and their unions should not be mutable

This code should not be valid:
let a: 'a' = 'a'
a += 'x' // 'typeof a' is still 'a'

let b: 5 = 5
b += 7 // 'typeof b' is still 5

This seems ok to me, though I might be missing something. At the point in the expression b does have type 5, but after the expression the type of b is correctly widened.
let a: 'a' = 'a';
a += 'x';
const x: 'a' = a; // string not assignable to 'a'

let b: 5 = 5
b += 7;
const y: 5 = b; // number is not assignable to 5

Here is a related issue: #18102
Which does point to inconsistent behaviour, for example:
let num1: 5 = 5;
num1 += 7; // ok
// num1 has type number;

let num2: 5 = 5;
num2 = num2 + 7; // error

I can't say if this is a bug, or by design to support certain JS idioms. Someone on the team will need to clarify that. I agree that the documentation is probably lacking on this either way though.

Should the operator ++ be treated in the same way? That also widens the literal type.

@ahejlsberg You set milestone to 3.2 but I think this might be a breaking change

Opened a pull request (a few weeks back) to solve an issue related to this. #28344

I'm going to close this as a duplicate of #14745 and move the conversation to here.


Explorer opts doesn't work when it's an Overlay

If the explorer has by, there's no way to specify which Element's opts to add.

Could you give an example of what you were trying to do?

Set kind to line, set a by, then try adding line_width to the opts tab.
Rendering failed with following error: Unexpected option 'line_width' for NdOverlay type across all extensions. Similar options for current extension ('bokeh') are: ['border_line_width', 'label_width', 'min_width'].


Sort and Filter Buttons Stay On Top

Description
Currently the sort button and the filter button in the the discovery movies/series tab and are out of frame when you scroll down.
Desired Behavior
The sort and filter buttons should stay at the top, similar to the search box
Additional Context
No response
Code of Conduct

[X] I agree to follow Jellyseerr's Code of Conduct

This is the intended behavior.


intel_s1000: scripts: Fix the runner script

This essentially reverts the commit bc7b1c5 in addition to
minor changes.
Signed-off-by: Rajavardhan Gundi<EMAIL_ADDRESS>

Codecov Report

Merging #11025 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11025   +/-   ##
=======================================
  Coverage   53.22%   53.22%
=======================================
  Files         217      217
  Lines       26668    26668
  Branches     5914     5914
=======================================
  Hits        14193    14193
  Misses      10059    10059
  Partials     2416     2416

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c7b5f...e6a0c4a. Read the comment docs.

This would be a bit easier to review if it was 2 commits: a revert and then the new changes you made.

This would be a bit easier to review if it was 2 commits: a revert and then the new changes you made.

Done.

@MaureenHelm So, should i clone a new repository for west and submit this change there? That'll ultimately get reflected here?

@MaureenHelm So, should i clone a new repository for west and submit this change there? That'll ultimately get reflected here?

Yes

@MaureenHelm If i have to submit it on west, it will be a single commit as the patch that is being reverted is absent on west. So, the changes will be squashed back to a single commit. Is that ok?

@MaureenHelm can you please comment?

@MaureenHelm If i have to submit it on west, it will be a single commit as the patch that is being reverted is absent on west. So, the changes will be squashed back to a single commit. Is that ok?

yes, that is ok. west is another repo with a different code base.

Pushed it to west. https://github.com/zephyrproject-rtos/west/pull/101

@MaureenHelm Though this is now merged into west repository, i still don't see the changes in the mainline Zephyr. Does that happen manually?