Homebridge Verification

Gonna close your issue in the verified repo for now, and start one here, so that a new issue can be created in the verified repo once the plugin is ready.

js files.

On Jul 26, 2023, at 2:53 PM, Ben @.***> wrote:
@richierockskool https://github.com/richierockskool when you make updates to this plugin, are you editing the ts files or js files?
—
Reply to this email directly, view it on GitHub https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/issues/24#issuecomment-1652327288, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJE7PVWJATY76HTESL2KZ6TXSFRRVANCNFSM6AAAAAA2ZAFGYQ.
You are receiving this because you were mentioned.

so if you are only editing the js files why keep the ts files in the first place?
delete them all
and delete the tsconfig file etc

Okay,  will start doing that and see where we end up. (They were in the original Homebridge Plugin template)
The only one that is not js in the setting ts should that one be renamed setting js?

On Jul 26, 2023, at 3:45 PM, Ben @.***> wrote:
so if you are only editing the js files why keep the ts files in the first place?
delete them all
and delete the tsconfig file etc
—
Reply to this email directly, view it on GitHub https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/issues/24#issuecomment-1652396983, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJE7PVVSD5TSA35VUDJD7ZDXSFXWVANCNFSM6AAAAAA2ZAFGYQ.
You are receiving this because you were mentioned.

already have

"type": "module",

"main": “src/index.js",
In the current package.json

On Jul 26, 2023, at 4:16 PM, Ben @.***> wrote:
well looks like your inkbirdPlatform.js doesn't use this file so i think just delete the settings.ts file
Also looks like your platform file exports as es module, so you will need this in your package json (replacing any existing properties with these names)
"type": "module",
"main": "src/inkbirdPlatform.js",
—
Reply to this email directly, view it on GitHub https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/issues/24#issuecomment-1652432067, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJE7PVUK66CPQKCTBMDY5A3XSF3IBANCNFSM6AAAAAA2ZAFGYQ.
You are receiving this because you were mentioned.

yea but it’s not working right now is it?

It will not let me run build when I delete tsconfig.json (so that one is back in for now), but no errors happened when I deleted the rest of the ts files, except not sure what to do with settings.ts
{
"compilerOptions": {
"target": "ES2018",
"module": "commonjs",
"lib": [
"es2015",
"es2016",
"es2017",
"es2018"
],
"declaration": true,
"declarationMap": true,
"sourceMap": true,
"outDir": "./dist",
"rootDir": "./src",
"strict": true,
"esModuleInterop": true,
"noImplicitAny": false,
"resolveJsonModule": true
},
"include": [
"src/"
],
"exclude": [
"**/*.spec.ts"
]
}

On Jul 26, 2023, at 4:16 PM, Ben @.***> wrote:
well looks like your inkbirdPlatform.js doesn't use this file so i think just delete the settings.ts file
Also looks like your platform file exports as es module, so you will need this in your package json (replacing any existing properties with these names)
"type": "module",
"main": "src/inkbirdPlatform.js",
—
Reply to this email directly, view it on GitHub https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/issues/24#issuecomment-1652432067, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJE7PVUK66CPQKCTBMDY5A3XSF3IBANCNFSM6AAAAAA2ZAFGYQ.
You are receiving this because you were mentioned.

correct it is not working, still need to build in the "start function” into InkbirdPlatform.js

On Jul 26, 2023, at 4:32 PM, Ben @.***> wrote:
yea but it’s not working right now is it?
—
Reply to this email directly, view it on GitHub https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/issues/24#issuecomment-1652452276, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJE7PVSO2ESLEFVQYP27JX3XSF5EFANCNFSM6AAAAAA2ZAFGYQ.
You are receiving this because you were mentioned.

the build command is meant to convert the typescript files to js. if you are simply using js files then the build command is not needed. just delete the line from your package json file.
I personally also do not use typescript, all my plugin files are js. You can see an example here
https://github.com/bwp91/homebridge-meross/blob/latest/package.json
I only have two scripts in my package json, a personal one to rebuild the package json, and a lint command. no build command

Now must do a rebuild the InkbirdPlatform.js to reflect all the functions for accessories that were in Platform.ts
or will the at redirect you suggested do anything?
"main": "src/inkbirdPlatform.js",

On Jul 26, 2023, at 4:37 PM, Ben @.***> wrote:
the build command is meant to convert the typescript files to js. if you are simply using js files then the build command is not needed. just delete the line from your package json file.
I personally also do not use typescript, all my plugin files are js. You can see an example here
https://github.com/bwp91/homebridge-meross/blob/latest/package.json https://github.com/bwp91/homebridge-meross/blob/latest/package.json
I only have two scripts in my package json, a personal one to rebuild the package json, and a lint command. no build command
—
Reply to this email directly, view it on GitHub https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/issues/24#issuecomment-1652459707, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJE7PVRUMND7M4WMX47KSA3XSF52HANCNFSM6AAAAAA2ZAFGYQ.
You are receiving this because you were mentioned.

ERROR INITIALIZING PLUGIN homebridge-inkbird-wifi-gateway:
[7/26/2023, 4:50:44 PM] TypeError: Class constructor InkbirdPlatform cannot be invoked without 'new'
at Plugin.initialize (/usr/local/lib/node_modules/homebridge/src/plugin.ts:243:17)
at PluginManager.initializePlugin (/usr/local/lib/node_modules/homebridge/src/pluginManager.ts:173:20)
at PluginManager.initializeInstalledPlugins (/usr/local/lib/node_modules/homebridge/src/pluginManager.ts:162:18)
at Server.start (/usr/local/lib/node_modules/homebridge/src/server.ts:173:5)

On Jul 26, 2023, at 4:37 PM, Ben @.***> wrote:
the build command is meant to convert the typescript files to js. if you are simply using js files then the build command is not needed. just delete the line from your package json file.
I personally also do not use typescript, all my plugin files are js. You can see an example here
https://github.com/bwp91/homebridge-meross/blob/latest/package.json https://github.com/bwp91/homebridge-meross/blob/latest/package.json
I only have two scripts in my package json, a personal one to rebuild the package json, and a lint command. no build command
—
Reply to this email directly, view it on GitHub https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/issues/24#issuecomment-1652459707, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJE7PVRUMND7M4WMX47KSA3XSF52HANCNFSM6AAAAAA2ZAFGYQ.
You are receiving this because you were mentioned.

Now must do a rebuild the InkbirdPlatform.js to reflect all the functions for accessories that were in Platform.ts

So you were using some of the ts files? you can't half and half use the js or ts files, either:

you have no js files in your project, edit the ts files directly, and include all the build scripts, or
use js files, with no dependency on ts files, and discount the build scripts

but what you cannot do is a mixture of both. i think this might be your general issue

so for example if you browse my repos, you can determine that I don't use ts at all, all my files are in js. there are no ts files at all. so no 'building' is required.
the homebridge plugin template uses ts which is why most of the existing plugins are written in ts (i have a personal distaste). but if you look at some examples you will see that these repos do not include any js files.

so you need to basically choose right now if you want to continue with your plugin in typescript or javascript, and then stick to one with your development.

It seems that whatever that has been done, Homebridge is picking up the js files to load on, so definitely sticking with that and not throwing errors. Just need to code those accessories for HomeKit to show up, which they are not. So, when the idea was to combine ts, the meaning is to borrow the functions to make the InkbirdPlatform start and accessories to load, from the ts accessories and ts platform files

On Jul 26, 2023, at 5:05 PM, Ben @.***> wrote:
so you need to basically choose right now if you want to continue with your plugin in typescript or javascript, and then stick to one with your development.
—
Reply to this email directly, view it on GitHub https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/issues/24#issuecomment-1652493848, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJE7PVVS6G5YMOASBG2XNETXSGBCFANCNFSM6AAAAAA2ZAFGYQ.
You are receiving this because you were mentioned.

i made a pr which you could look into. i can't pretend that it will make everything magically start working, but you can see what i am aiming towards, from your feedback/replies on this issue

https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/pull/25

Thank you, will work through those changes,

On Jul 26, 2023, at 5:40 PM, Ben @.***> wrote:
#25 https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/pull/25
—
Reply to this email directly, view it on GitHub https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/issues/24#issuecomment-1652534512, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJE7PVRJJTQ2563J6XBN6T3XSGFF7ANCNFSM6AAAAAA2ZAFGYQ.
You are receiving this because you were mentioned.

Good news all those changes are done and the plugin still loads with no errors, but no start function on the platform and accessories are not loading.

You need to put your plugin setup code into a callback for the didFinishLaunching event, maybe this is the missing piece here.
See the template:
https://github.com/homebridge/homebridge-plugin-template/blob/d0bca523f5cd56f68d9d1e9b21ae20389bbcb2e5/src/platform.ts#L29

this is before the didFinishLauching
Build and Lint #461: Commit 1d08b44 https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/commit/1d08b44857b0a6775d712217e86f6f7dbeaff2c4 pushed by richierockskool https://github.com/richierockskool is failing now, should this be put back?
npm install @@.*** --save-dev
Oops! Something went wrong! :(
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5692364335/job/15429212439#step:5:11
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5692364335/job/15429212439#step:5:12ESLint: 8.42.0
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5692364335/job/15429212439#step:5:13
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5692364335/job/15429212439#step:5:14ESLint couldn't find the plugin @./eslint-plugin".
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5692364335/job/15429212439#step:5:15
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5692364335/job/15429212439#step:5:16(The package @./eslint-plugin" was not found when loaded as a Node module from the directory "/Users/runner/work/homebridge-inkbird-wifi-gateway/homebridge-inkbird-wifi-gateway".)
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5692364335/job/15429212439#step:5:17
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5692364335/job/15429212439#step:5:18It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5692364335/job/15429212439#step:5:19
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5692364335/job/15429212439#step:5:20    npm install @@.*** --save-dev
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5692364335/job/15429212439#step:5:21
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5692364335/job/15429212439#step:5:22The plugin @.***/eslint-plugin" was referenced from the config file in ".eslintrc".
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5692364335/job/15429212439#step:5:23
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5692364335/job/15429212439#step:5:24If you still can't figure out the problem, please stop by https://eslint.org/chat/help https://eslint.org/chat/help to chat with the team.

On Jul 28, 2023, at 8:28 AM, Ben @.***> wrote:
You need to put your plugin setup code into a callback for the didFinishLaunching event, maybe this is the missing piece here.
See the template:
https://github.com/homebridge/homebridge-plugin-template/blob/d0bca523f5cd56f68d9d1e9b21ae20389bbcb2e5/src/platform.ts#L29 https://github.com/homebridge/homebridge-plugin-template/blob/d0bca523f5cd56f68d9d1e9b21ae20389bbcb2e5/src/platform.ts#L29
—
Reply to this email directly, view it on GitHub https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/issues/24#issuecomment-1655606806, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJE7PVRJXMBYCOYNY2UKTMLXSOV7TANCNFSM6AAAAAA2ZAFGYQ.
You are receiving this because you were mentioned.

We are getting
[7/28/2023, 11:58:31 AM] [InkbirdWifiGateway] Initializing homebridge-inkbird-wifi-gateway platform...
[7/28/2023, 11:58:31 AM] [InkbirdWifiGateway] Finished initializing platform: InkbirdWifiGateway
[7/28/2023, 11:58:32 AM] [InkbirdWifiGateway] Executed didFinishLaunching callback
[7/28/2023, 11:58:32 AM] Publishing bridge accessory (name: Homebridge 88AB, publishInfo: {
username: '0E:84:85:50:88:AB’,
Which is great,
But not showing up in Homebridge Status,
and still getting a failure to build, is there a js plug in to fix this?
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:5
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:6> @.*** lint
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:7> eslint src/.js --max-warnings=0
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:8
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:9
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:10Oops! Something went wrong! :(
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:11
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:12ESLint: 8.45.0
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:13
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:14ESLint couldn't find the plugin @./eslint-plugin".
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:15
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:16(The package @./eslint-plugin" was not found when loaded as a Node module from the directory "/Users/runner/work/homebridge-inkbird-wifi-gateway/homebridge-inkbird-wifi-gateway".)
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:17
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:18It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:19
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:20    npm install @@.* --save-dev
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:21
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:22The plugin @.***/eslint-plugin" was referenced from the config file in ".eslintrc".
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:23
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:24If you still can't figure out the problem, please stop by https://eslint.org/chat/help https://eslint.org/chat/help to chat with the team.
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:25
https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/actions/runs/5693914217/job/15434019284#step:5:26Error: Process completed with exit code 2.

On Jul 28, 2023, at 8:28 AM, Ben @.***> wrote:
You need to put your plugin setup code into a callback for the didFinishLaunching event, maybe this is the missing piece here.
See the template:
https://github.com/homebridge/homebridge-plugin-template/blob/d0bca523f5cd56f68d9d1e9b21ae20389bbcb2e5/src/platform.ts#L29 https://github.com/homebridge/homebridge-plugin-template/blob/d0bca523f5cd56f68d9d1e9b21ae20389bbcb2e5/src/platform.ts#L29
—
Reply to this email directly, view it on GitHub https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/issues/24#issuecomment-1655606806, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJE7PVRJXMBYCOYNY2UKTMLXSOV7TANCNFSM6AAAAAA2ZAFGYQ.
You are receiving this because you were mentioned.

Before I do this, is this the correct way?
@./eslint-plugin-json @./eslint-plugin-json>

On Jul 28, 2023, at 8:28 AM, Ben @.***> wrote:
You need to put your plugin setup code into a callback for the didFinishLaunching event, maybe this is the missing piece here.
See the template:
https://github.com/homebridge/homebridge-plugin-template/blob/d0bca523f5cd56f68d9d1e9b21ae20389bbcb2e5/src/platform.ts#L29 https://github.com/homebridge/homebridge-plugin-template/blob/d0bca523f5cd56f68d9d1e9b21ae20389bbcb2e5/src/platform.ts#L29
—
Reply to this email directly, view it on GitHub https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/issues/24#issuecomment-1655606806, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJE7PVRJXMBYCOYNY2UKTMLXSOV7TANCNFSM6AAAAAA2ZAFGYQ.
You are receiving this because you were mentioned.

Fixed the build with "build": "node src/index.js”
All eslint errors have gone,
still not seeing what I see in vs code/terminal  in the Homebridge io
Looks like the accessories are loading when I call homebridge -D in VS, but not in the Homebridge io?

On Jul 28, 2023, at 8:28 AM, Ben @.***> wrote:
You need to put your plugin setup code into a callback for the didFinishLaunching event, maybe this is the missing piece here.
See the template:
https://github.com/homebridge/homebridge-plugin-template/blob/d0bca523f5cd56f68d9d1e9b21ae20389bbcb2e5/src/platform.ts#L29 https://github.com/homebridge/homebridge-plugin-template/blob/d0bca523f5cd56f68d9d1e9b21ae20389bbcb2e5/src/platform.ts#L29
—
Reply to this email directly, view it on GitHub https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/issues/24#issuecomment-1655606806, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJE7PVRJXMBYCOYNY2UKTMLXSOV7TANCNFSM6AAAAAA2ZAFGYQ.
You are receiving this because you were mentioned.

If it is deleted the build fails

On Jul 29, 2023, at 12:06 PM, Ben @.***> wrote:
the build command should not start the plugin. it builds the plugin.
For a homebridge plugin, the build command converts the typescript code to javascript.
since you are using raw javascript, you do not need to build.
—
Reply to this email directly, view it on GitHub https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/issues/24#issuecomment-1656765719, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJE7PVVJB3RIXQ3FLO5UIHLXSUYIPANCNFSM6AAAAAA2ZAFGYQ.
You are receiving this because you were mentioned.

It is now building in and accessories are showing up, then Homebridge crashes
[7/29/2023, 12:11:37 PM] [InkbirdWifiGateway] Initializing homebridge-inkbird-wifi-gateway platform...
[7/29/2023, 12:11:37 PM] [InkbirdWifiGateway] Finished initializing Inkbird Platform: InkbirdWifiGateway
[7/29/2023, 12:11:37 PM] [InkbirdWifiGateway] [class IBSPO1Accessory] [class IBSTH1Accessory]
[7/29/2023, 12:11:37 PM] TypeError: Cannot read properties of undefined (reading 'name')
at new IBSPO1Accessory (file:///Users/richjagger/Documents/GitHub/homebridge-inkbird-wifi-gateway/src/IBSPO1Accessory.js:6:24)
at new InkbirdPlatform (file:///Users/richjagger/Documents/GitHub/homebridge-inkbird-wifi-gateway/src/InkbirdPlatform.js:58:9)
at /usr/local/lib/node_modules/homebridge/src/server.ts:474:40
at Array.forEach ()
at Server.loadPlatforms (/usr/local/lib/node_modules/homebridge/src/server.ts:401:27)
at Server.start (/usr/local/lib/node_modules/homebridge/src/server.ts:176:29)
[7/29/2023, 12:11:37 PM] Got SIGTERM, shutting down Homebridge...
[7/29/2023, 12:11:37 PM] AssertionError [ERR_ASSERTION]: Cannot generate setupURI on an accessory that isn't published yet!
at Bridge.Accessory.setupURI (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Accessory.ts:994:11)
at Server.setServerStatus (/usr/local/lib/node_modules/homebridge/src/server.ts:155:45)
at Server.teardown (/usr/local/lib/node_modules/homebridge/src/server.ts:199:10)
at signalHandler (/usr/local/lib/node_modules/homebridge/src/cli.ts:93:12)
at process.emit (node:events:514:28)
at process.emit (/usr/local/lib/node_modules/homebridge/node_modules/source-map-support/source-map-support.js:516:21)

On Jul 29, 2023, at 12:06 PM, Ben @.***> wrote:
the build command should not start the plugin. it builds the plugin.
For a homebridge plugin, the build command converts the typescript code to javascript.
since you are using raw javascript, you do not need to build.
—
Reply to this email directly, view it on GitHub https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/issues/24#issuecomment-1656765719, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJE7PVVJB3RIXQ3FLO5UIHLXSUYIPANCNFSM6AAAAAA2ZAFGYQ.
You are receiving this because you were mentioned.

well here you are simple setting this.devices to 2 so it’s not a proper object with a name property

get the same with this.device to 1?
InkbirdWifiGateway] [class IBSPO1Accessory]
[7/29/2023, 12:34:33 PM] TypeError: Cannot read properties of undefined (reading 'name')
at new IBSPO1Accessory (file:///Users/richjagger/Documents/GitHub/homebridge-inkbird-wifi-gateway/src/IBSPO1Accessory.js:6:24)
at new InkbirdPlatform (file:///Users/richjagger/Documents/GitHub/homebridge-inkbird-wifi-gateway/src/InkbirdPlatform.js:58:9)
at /usr/local/lib/node_modules/homebridge/src/server.ts:474:40
at Array.forEach ()
at Server.loadPlatforms (/usr/local/lib/node_modules/homebridge/src/server.ts:401:27)
at Server.start (/usr/local/lib/node_modules/homebridge/src/server.ts:176:29)
[7/29/2023, 12:34:33 PM] Got SIGTERM, shutting down Homebridge...
[7/29/2023, 12:34:33 PM] AssertionError [ERR_ASSERTION]: Cannot generate setupURI on an accessory that isn't published yet!
at Bridge.Accessory.setupURI (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Accessory.ts:994:11)
at Server.setServerStatus (/usr/local/lib/node_modules/homebridge/src/server.ts:155:45)
at Server.teardown (/usr/local/lib/node_modules/homebridge/src/server.ts:199:10)
at signalHandler (/usr/local/lib/node_modules/homebridge/src/cli.ts:93:12)
at process.emit (node:events:514:28)
at process.emit (/usr/local/lib/node_modules/homebridge/node_modules/source-map-support/source-map-support.js:516:21)

On Jul 29, 2023, at 12:28 PM, Ben @.***> wrote:
well here you are simple setting this.devices to 2 so it’s not a proper object with a name property
—
Reply to this email directly, view it on GitHub https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/issues/24#issuecomment-1656776570, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJE7PVX3KK6JTUNQNGGTXNTXSU2ZBANCNFSM6AAAAAA2ZAFGYQ.
You are receiving this because you were mentioned.

fix some code InkbirdPlatform.js
result
[7/30/2023, 9:05:19 AM] [InkbirdWifiGateway] Initializing homebridge-inkbird-wifi-gateway platform...
[7/30/2023, 9:05:19 AM] [InkbirdWifiGateway] [class InkbirdPlatform]
[7/30/2023, 9:05:19 AM] [InkbirdWifiGateway] [class InkbirdPlatform]
[7/30/2023, 9:05:19 AM] [InkbirdWifiGateway] [class InkbirdPlatform]
this only shows up in homebridge -D not in  Homebridge
[7/30/2023, 9:05:19 AM] [InkbirdWifiGateway] Executed didFinishLaunching callback
[7/30/2023, 9:13:13 AM] Publishing bridge accessory (name: Homebridge 88AB, publishInfo: {
username: '0E:84:85:50:88:AB',
port: 51516,
pincode: '--**',
category: 2,
bind: [ 'en0', [length]: 1 ],
mdns: undefined,
addIdentifyingMaterial: true,
advertiser: 'ciao'
}).
And, no accessories appear?

On Jul 29, 2023, at 12:28 PM, Ben @.***> wrote:
well here you are simple setting this.devices to 2 so it’s not a proper object with a name property
—
Reply to this email directly, view it on GitHub https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/issues/24#issuecomment-1656776570, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJE7PVX3KK6JTUNQNGGTXNTXSU2ZBANCNFSM6AAAAAA2ZAFGYQ.
You are receiving this because you were mentioned.

In homebridge now…
[8/5/2023, 1:56:54 PM] [InkbirdWifiGateway] Initializing homebridge-inkbird-wifi-gateway platform...
[8/5/2023, 1:56:54 PM] [InkbirdWifiGateway] Starting Inkbird Platform using homebridge API 2.7
[8/5/2023, 1:56:54 PM] [InkbirdWifiGateway] [class InkbirdPlatform]
[8/5/2023, 1:56:54 PM] [InkbirdWifiGateway] [class InkbirdPlatform]
[8/5/2023, 1:56:54 PM] [InkbirdWifiGateway] [class InkbirdPlatform]
[8/5/2023, 1:56:54 PM] [InkbirdWifiGateway] [
{ UniqueId: 'IBS-M1S', DisplayName: 'Backyard Gateway' },
{ UniqueId: 'IBS-PO1/B', DisplayName: 'Pool Temperature Sensor' },
{ UniqueId: 'IBS-TH1', DisplayName: 'Hot Tub Temperature Sensor' }
]
In homebridge -D
[8/5/2023, 1:59:14 PM] [InkbirdWifiGateway] Initializing homebridge-inkbird-wifi-gateway platform...
[8/5/2023, 1:59:14 PM] [InkbirdWifiGateway] Starting Inkbird Platform using homebridge API 2.7
[8/5/2023, 1:59:14 PM] [InkbirdWifiGateway] [class InkbirdPlatform]
[8/5/2023, 1:59:14 PM] [InkbirdWifiGateway] [class InkbirdPlatform]
[8/5/2023, 1:59:14 PM] [InkbirdWifiGateway] [class InkbirdPlatform]
[8/5/2023, 1:59:14 PM] [InkbirdWifiGateway] Adding Bridge Device
[8/5/2023, 1:59:14 PM] [InkbirdWifiGateway] Found device undefined
[8/5/2023, 1:59:14 PM] [InkbirdWifiGateway] [
{ UniqueId: 'IBS-M1S', DisplayName: 'Backyard Gateway' },
{ UniqueId: 'IBS-PO1/B', DisplayName: 'Pool Temperature Sensor' },
{ UniqueId: 'IBS-TH1', DisplayName: 'Hot Tub Temperature Sensor' }
]
[8/5/2023, 1:59:14 PM] [InkbirdWifiGateway] Executed didFinishLaunching callback
then this error,
[8/5/2023, 1:59:15 PM] Error: listen EADDRINUSE: address already in use :::51516
at Server.setupListenHandle [as _listen2] (node:net:1872:16)
at listenInCluster (node:net:1920:12)
at Server.listen (node:net:2008:7)
at EventedHTTPServer.listen (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/util/eventedhttp.ts:164:20)
at HAPServer.listen (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/HAPServer.ts:377:21)
at Bridge. (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Accessory.ts:1365:18)
at step (/usr/local/lib/node_modules/homebridge/node_modules/tslib/tslib.js:193:27)
at Object.next (/usr/local/lib/node_modules/homebridge/node_modules/tslib/tslib.js:174:57)
at /usr/local/lib/node_modules/homebridge/node_modules/tslib/tslib.js:167:75
at new Promise ()
What is happening here?
And still no accessories show up..
when I add this in it asks for a uuid? AssertionError [ERR_ASSERTION]: Services must be created with a valid UUID. https://www.google.com/search?client=safari&rls=en&q=AssertionError+[ERR_ASSERTION]%3A+Services+must+be+created+with+a+valid+UUID.&ie=UTF-8&oe=UTF-8
:this.log.debug('Creating and configuring new bridge')
bridgeAccessory=(devicesDiscovered)
bridgeService=(Service.Tunnel)
bridgeService=(devicesDiscovered)
    this.Service = this.api.hap.Service;
    this.Characteristic = this.api.hap.Characteristic;
    this.name = config.name;
    // create a new Bridge Configuration service
    this.service = new this.Service(this.Service.InkbirdWifiGateway);
    // create handlers for required characteristics
    this.service.getCharacteristic(this.Characteristic.InkbirdWifiGateway)
      .onGet(this.handleDiscoverBridgedAccessoriesGet.bind(this))
      .onSet(this.handleDiscoverBridgedAccessoriesSet.bind(this));

    this.service.getCharacteristic(this.Characteristic.DiscoveredBridgedAccessories)
      .onGet(this.handleDiscoveredBridgedAccessoriesGet.bind(this));

    this.bridgeService.getCharacteristic(Characteristic.StatusFault).updateValue(!devicesDiscovered.is_connected)
    this.bridgeAccessory.addService(bridgeService)
    this.accessories[uuid]=bridgeAccessory
    this.log.info('Adding Gen-1 Bridge')
    this.log.debug('Registering platform accessory')
    this.api.registerPlatformAccessories(PluginName, PlatformName, [bridgeAccessory])
}

Very close to making this work, any help would be great.

On Jul 29, 2023, at 12:28 PM, Ben @.***> wrote:
well here you are simple setting this.devices to 2 so it’s not a proper object with a name property
—
Reply to this email directly, view it on GitHub https://github.com/richierockskool/homebridge-inkbird-wifi-gateway/issues/24#issuecomment-1656776570, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJE7PVX3KK6JTUNQNGGTXNTXSU2ZBANCNFSM6AAAAAA2ZAFGYQ.
You are receiving this because you were mentioned.


Build considers the Signing task to be configuration cache compatible with Gradle 8.1+

There is no signing plugin applied to this build so I am not sure what to test.
https://ge.solutions-team.gradle.com/s/ame5wpwnxlysq/plugins?search=sign
The checks have stored a cache entry correctly: https://github.com/gradle/gradle-enterprise-build-validation-scripts/actions/runs/4723668701/jobs/8379920462?pr=408#step:5:1187

I fixed the merge conflicts but now it says the PR was merged but I don't see it on the main branch. This is odd.


not run

facetest.go:9:2: cannot find package "github.com/machinebox/sdk-go/facebox" in a                                 ny of:
/usr/local/go/src/github.com/machinebox/sdk-go/facebox (from $GOROOT)
/home/gansta/Downloads/detec/webcamFacebox/src/github.com/machinebox/sdk                                 -go/facebox (from $GOPATH)
facetest.go:10:2: cannot find package "github.com/matryer/is" in any of:
/usr/local/go/src/github.com/matryer/is (from $GOROOT)
/home/gansta/Downloads/detec/webcamFacebox/src/github.com/matryer/is (fr                                 om $GOPATH)

Please have a look how to get dependencies in Go with go get:
$ go get github.com/machinebox/sdk-go/facebox
https://golang.org/cmd/go/#hdr-Download_and_install_packages_and_dependencies
Thank you

gansta@gansta-desktop:~$ go install -i facebox
can't load package: package facebox: cannot find package "facebox" in any of:
/usr/local/go/src/facebox (from $GOROOT)
/home/gansta/go/src/facebox (from $GOPATH)

Sorry, to use the go-sdk, you need your Go environment, up and running as a prerequisite.
Please visit https://golang.org/ and follow the instructions for developing Go projects. I'm afraid we can not help you setting up the environment. Sorry about that

maybe you will create instruction?, MY go lang work ND RUN APPs


Requesting a list of plans with related attributes by direct API calls returns public DMPs

To reproduce the bug:

Log into the DMPTool as institutional admin.

Call the following documented API https://github.com/CDLUC3/dmptool/wiki/API#for-a-list-of-plans-with-all-related-attributes-this-api-request-requires-authentication either by direct CURLing or pasting into the browser:
$ curl -H "Authorization: Token token=token_number" https://dmptool.org/api/v1/plans_full

expected result: The call returns all institutional plans (related Issue #127) with a column for ID number (related Issue #128), other attribute columns, and no public DMPs
actual result: The call returns all public DMPS rather than the institutional ones, and with no ID numbers
This behavior is the same across all platforms.

this API call now returns a list of plans that have institutional visibility.  Similar to what you would see if you are an institutional administrator and viewed Public Plans https://dmp2-dev.cdlib.org/public_dmps


Publish updates from master

Publish the latest changes from master

@thaJeztah @jerae-duffin Could you PTAL


[BUG] sqlite3.OperationalError: unable to open database file

Describe the bug
I have LNBits instance at adae3b4302756f3d75498f8fb05658a9a565aa9c commit (patch from https://github.com/lnbits/lnbits/pull/1636). And today I found out that all the services are not working (502 error from nginx). Looking into the logs, I saw errors. The restart command was worked out for a very long time (judging by the logs, the processes were hanging).
Desktop (please complete the following information):

LNbits version: adae3b4302756f3d75498f8fb05658a9a565aa9c
Database sqlite

Additional context
Errors like this:
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]: 2023-04-20 09:20:11.98 | ERROR | caught exception in background task:
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]: 2023-04-20 09:20:11.98 | ERROR | Traceback (most recent call last):
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 2336, in _wrap_pool_connect
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 304, in unique_connection
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 778, in _checkout
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 495, in checkout
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/pool/impl.py", line 241, in _do_get
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 309, in _create_connection
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 440, in __init__
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 661, in __connect
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/util/langhelpers.py", line 68, in __exit__
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/util/compat.py", line 182, in raise_
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 656, in __connect
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/strategies.py", line 114, in connect
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/default.py", line 508, in connect
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]: sqlite3.OperationalError: unable to open database file
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]: The above exception was the direct cause of the following exception:
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]: Traceback (most recent call last):
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/lnbits/lnbits/tasks.py", line 25, in catch_everything_and_restart
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:     await func()
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/lnbits/lnbits/tasks.py", line 128, in check_pending_payments
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:     async with db.connect() as conn:
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/usr/lib/python3.9/contextlib.py", line 181, in __aenter__
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/lnbits/lnbits/db.py", line 188, in connect
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy_aio/base.py", line 580, in __aenter__
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy_aio/base.py", line 110, in _make_async_connection
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy_aio/asyncio.py", line 70, in run
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/outcome/_impl.py", line 138, in unwrap
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 2263, in connect
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 104, in __init__
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 2369, in raw_connection
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 2339, in _wrap_pool_connect
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 1583, in _handle_dbapi_exception_noconnection
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/util/compat.py", line 182, in raise_
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 2336, in _wrap_pool_connect
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 304, in unique_connection
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 778, in _checkout
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 495, in checkout
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/pool/impl.py", line 241, in _do_get
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 309, in _create_connection
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 440, in __init__
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 661, in __connect
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/util/langhelpers.py", line 68, in __exit__
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/util/compat.py", line 182, in raise_
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 656, in __connect
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/strategies.py", line 114, in connect
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/default.py", line 508, in connect
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]: sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) unable to open database file
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]: (Background on this error at: http://sqlalche.me/e/13/e3q8)
Apr 20 09:20:11 fuckedbitcoin poetry[2147615]: 2023-04-20 09:20:11.99 | ERROR | will restart the task in 5 seconds.

Logs about stopping:
Apr 20 17:51:53 fuckedbitcoin systemd[1]: Stopping LNbits...
Apr 20 17:51:53 fuckedbitcoin poetry[2147615]: 2023-04-20 17:51:53.26 | INFO | Shutting down
Apr 20 17:51:53 fuckedbitcoin poetry[2147615]: 2023-04-20 17:51:53.27 | WARNING | Connection to remote host was lost.
Apr 20 17:51:53 fuckedbitcoin poetry[2147615]: 2023-04-20 17:51:53.28 | ERROR | closing handshake failed
Apr 20 17:51:53 fuckedbitcoin poetry[2147615]: 2023-04-20 17:51:53.28 | INFO | connection closed
Apr 20 17:51:53 fuckedbitcoin poetry[2147615]: 2023-04-20 17:51:53.36 | INFO | Waiting for background tasks to complete. (CTRL+C to force quit)
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: State 'stop-final-sigterm' timed out. Killing.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2147615 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2147648 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2147649 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2147650 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149118 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149121 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149128 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149130 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149139 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149140 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149141 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149142 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149144 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149146 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149155 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149156 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149157 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149158 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149159 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149160 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149161 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149162 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149164 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149165 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149172 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149173 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149174 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149175 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149176 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149177 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149178 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149179 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149180 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149181 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149183 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149184 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149185 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149196 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149198 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149200 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149202 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149204 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149206 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149207 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149209 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149210 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149211 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149218 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149219 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149220 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149221 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149222 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149223 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149224 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149225 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149226 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149227 (python) with signal SIGKILL.
...
>Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149405 (n/a) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149406 (n/a) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149413 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149416 (n/a) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149418 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149420 (n/a) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149422 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149424 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149425 (python) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149426 (n/a) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2149428 (python) with signal SIGKILL.
...
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2150009 (n/a) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2150010 (n/a) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Killing process 2150011 (n/a) with signal SIGKILL.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Failed to kill control group /system.slice/lnbits.service, ignoring: Input/output error
Apr 20 17:53:53 fuckedbitcoin systemd[1]: lnbits.service: Failed with result 'timeout'.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: Stopped LNbits.
Apr 20 17:53:53 fuckedbitcoin systemd[1]: Started LNbits.

But all this was preceded by such an error (I have the nostr client extension installed):
pr 20 04:54:31 fuckedbitcoin poetry[2147615]: 2023-04-20 04:54:31.21 | INFO | <IP_ADDRESS>:0 - "GET /api/v1/payments/sse?api-key=XXXXXXXXXXXXXXXXXXXXXXX HTTP/1.1" 200
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]: Traceback (most recent call last):
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/starlette/middleware/errors.py", line 162, in __call__
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:     await self.app(scope, receive, _send)
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/lnbits/lnbits/middleware.py", line 74, in __call__
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:     await self.app(scope, receive, send)
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/lnbits/lnbits/middleware.py", line 53, in __call__
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:     await self.app(scope, receive, send)
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/starlette/middleware/gzip.py", line 24, in __call__
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:     await responder(scope, receive, send)
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/starlette/middleware/gzip.py", line 43, in __call__
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:     await self.app(scope, receive, self.send_with_gzip)
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/starlette/middleware/cors.py", line 84, in __call__
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:     await self.app(scope, receive, send)
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/starlette/exceptions.py", line 93, in __call__
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:     raise exc
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/starlette/exceptions.py", line 82, in __call__
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:     await self.app(scope, receive, sender)
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/fastapi/middleware/asyncexitstack.py", line 21, in __call__
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:     raise e
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/fastapi/middleware/asyncexitstack.py", line 18, in __call__
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:     await self.app(scope, receive, send)
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/starlette/routing.py", line 670, in __call__
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:     await route.handle(scope, receive, send)
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/starlette/routing.py", line 266, in handle
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:     await self.app(scope, receive, send)
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/starlette/routing.py", line 68, in app
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:     await response(scope, receive, send)
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sse_starlette/sse.py", line 182, in __call__
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:     await self.wait()
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sse_starlette/sse.py", line 216, in wait
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:     await self._ping_task
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/sse_starlette/sse.py", line 259, in _ping
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:     await send({"type": "http.response.body", "body": ping, "more_body": True})
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/starlette/exceptions.py", line 79, in sender
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:     await send(message)
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:   File "/home/lnbits/.cache/pypoetry/virtualenvs/lnbits-Me3QFGJB-py3.9/lib/python3.9/site-packages/starlette/middleware/gzip.py", line 93, in send_with_gzip
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:     self.gzip_file.write(body)
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:   File "/usr/lib/python3.9/gzip.py", line 272, in write
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:     self._check_not_closed()
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:   File "/usr/lib/python3.9/_compression.py", line 14, in _check_not_closed
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]:     raise ValueError("I/O operation on closed file")
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]: ValueError: I/O operation on closed file
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]: 2023-04-20 04:55:31.24 | ERROR | Exception: I/O operation on closed file
Apr 20 04:55:31 fuckedbitcoin poetry[2147615]: 2023-04-20 04:55:31.24 | ERROR | Exception in ASGI application

I don't know if one is related to the other, perhaps the nostr client is to blame for subsequent errors with opening the database, or these are independent errors.
P.S. After stopping and starting of lnbits systemd service the LNBits works again but sometime I see errors from in logs like the last error described here

ValueError: I/O operation on closed file

Really not sure what the error could be caused by. Do you use anything else, any other software that accesses the lnbits database?

it was a gzip payments/sse issue, you can resolve that by disabling compression.
there is also this pr this closes this issue once and for all. https://github.com/lnbits/lnbits/pull/1781


No auth provider for kubernetes in aperturectl

We use oidc authentication with Kubernetes. Installing Aperture with aperturectl install failed with the following error:
ERR aperturectl/cmd/root.go87 > Error executing aperturectl error="failed to create new ClientSet: no Auth Provider found for name \"oidc\"" service=aperturectl
Adding an import for "k8s.io/client-go/plugin/pkg/client/auth/oidc" fixes it in my local build but I'm unsure where it ought to be added (or would PR).

Reference in the example in client-go repo https://github.com/kubernetes/client-go/blob/master/examples/out-of-cluster-client-configuration/main.go#L44-L62

Thank you @akevdmeer for reporting the issue.
We have merged a fix for this in main so could you please try that out once and verify the issue has been fixed for you?


BREAKING CHANGE: remove legacy detectron2 model; remove layoutparser extras

Summary
First step in resolving https://github.com/Unstructured-IO/unstructured/issues/3051. Per this comment, we were having troubling running unstructured in the Python 3.12 wolfi-base contain due to issues related to pycocotools, which is only used for the legacy detectron2 model from layoutparser. Since we've replaced this with detectron2onnx, this PR removes the layoutparser extra dependencies that caused issues with Python 3.12.
The layoutparser base dependency is still required because we use layout objects from that library. It's likely we could remove these in a future iteration.
Temporarily disabled the ingest tests, because they seem to have been broken for the past six months. Last commit that they passed for was this one. Opened #352 to reenable them.
Testing
If CI passes we should be good to go.

@qued - Tests are passing now, should be good for final review!


Add filter for INI sections

Sometimes we don't want to produce a diff for all the ini file, which can be huge with a lot of missing sections.
We need to add a filter which can just produce diff against this specific sections and ignore others.

something such as:
os-diff diff file1 file2 --section-filter default,foo,bar
will only diff against:
[default]
...
[foo]
...
[bar]
...

I think you did this already @matbu ?


Files are saved with the generic name "file" instead of the actual filename when saving an image from preview

Files are saved with the generic name "file" instead of the actual filename when saving an image from preview.
I know that there is an option to click in UI to download that saving with proper names - but this option is less intuitive than just clicking on an image and saving it.
Adding a keyboard shortcut to save could be a good option too.

already added

@zanllp
Thank you very much!


Remove references to GetOperatingState and GetAdminState

These functions have been deprecated and are scheduled to be removed from core-contracts with edgexfoundry/go-mod-core-contracts/issues/142. They need some ancillary references not caught by #1244 removed.

this is removed from V2 API


Feat: Attractive logo for the AgriLearnNetwork website.

Describe the feature
Being a graphic designer, I am aware of how much of a difference an attractive logo can make and break the website. Integrating a logo for the AgriLearnNetwork website header will enhance brand recognition, improve user experience, and foster community engagement. A unique logo process involves designing a logo that reflects the project's values and goals, followed by seamless integration into the website's design.
Add ScreenShots

This is a sample logo I have designed for Agrilearn Network project. It can be further customised after review and other requirements.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Suchitra-Sahoo Please consider this issue and I request you to assign me to this. I am a participant of GSSOC'24 and I request you to also assign level label for contribution.

@Suchitra-Sahoo Hey, I request you to assign level label to the issues according to the guidelines, so that we can start making pull requests. Thank you.


fix handling of post.isFixedPitch (accept any nonzero value)

Description
Prior to this change, the code was only accepting a post.isFixedPitch value of 1 as meaning monospaced, but the OpenType spec. says:

Set to 0 if the font is proportionally spaced, non-zero if the font is not proportionally spaced (i.e. monospaced).

So, now the code treats any non-zero value as meaning monospaced, and I've updated one of the test cases to use a non-one, non-zero value for testing.
To Do

[x] update CHANGELOG.md
[x] wait for checks to pass (except github/pages, which is stuck)
[x] request a review

Perfect! Thanks :-D


ng2-tree does not work in default download

I'm submitting a ...
[x ] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Do you want to request a feature or report a bug?
ng2-tree does not work at all but is included with the theme. Do you have a workaround to get the tree to render that does not involve running multiple versions of angular?

What is the current behavior?
ng2-tree throws an error. Reported on ng2-tree website.
https://github.com/valor-software/ng2-tree/issues/9

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).

What is the expected behavior?
ng2-tree renders

@nick-wellinghoff-sp please take a look at this issue https://github.com/akveo/ng2-admin/issues/198, closing this one as a duplicate.


Added group search bar to explore page

This covers issue #60 and allows users to search for specific group titles much easier. Hopefully next we implement filters.

LGTM


support buffered printing mode

as discussed in #2: AFAICT it seems this lib assumes operation is in "Concurrent printing" mode (which seems to be the default over USB), but when connected over bluetooth, the printer seems to operate in "Buffered printing" mode. Would be good to support that too. See #2 for more details

Hi, getting back to this now.
I don't see any exact explanation of what this entails in brother's documentation, do you have any more information?

Hey, sorry for my delayed reply this time :P
From page 39 of the PT-H500/PT-P700/PT-E500 command reference:

Normally, printing is performed as buffered printing.
However, if the printer is connected via USB and uncompressed data is received, concurrent printing is
performed.

It goes on to show flow charts of how both modes work


add Preset connector

Describe your changes :

This PR adds a new Dashboard connector for Preset.io, a managed service offering of SuperSet.

Type of change :

[x] New feature

Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] All new and existing tests passed.

Reviewers

@stephanesol lost track of this PR. please let us know if you want to get this merged in. We can get this into upcoming 1.0 release

closing for now. I'll circle back on this since several things have changed in the codebase.


Added ignore_members variable and use it in opsgenie_team resource

what

adds a variable ignore_members to the team module that is passed to the opsgenie_team resource.  Defaults to false.

why

Ignoring changes to team membership, allows you to manage that in the Opsgenie UI.  This is particularly useful for delegating team membership to team leads, for example.

references
* Opsgenie team resource docs
implementation note
I tried both, setting ignore_members as a variable (first commit) and putting it into the team map (second commit).   Not sure how you guys like it.

/test all


Add support for LogGroupName Property

Adds the LogGroupName property to Logs::LogGroup.

Thanks for this @mikechau You'll need to rebase on top of stevenjack/cfndsl#263 when it gets merged to be able to pass Travis

Sounds good @kornypoet, I've rebased.


Refactor: New Logging framework

New Logging Framework
This PR adds a revamp of the log-tab panel(s). Providing a much more extendable and unified way for notifying the user with information, warnings and errors.
https://user-images.githubusercontent.com/4085393/201477650-6a3271aa-acbc-47a8-ace3-d2394bdc94a4.mov
How to use
Using the logging framework is easy, thread-safe and reactive!
Anatomy of a log entry
UUID id,                // autogenerated uuid
String service,         // service that produced the service
String message,         // information about what happened
LogLevel level          // Info/Warn/Error level

Add Entries
The basic usage - simply add new logs:
Log.addInfo("Some information")
Log.addWarning("Some warning");
Log.addError("Some error");

Origin Service
If the log originates from somewhere that is not an internal place (i.e. jecdar, uppaal, codeanalysis or some custom program), you can specify what service generated the log:
var myService = "NotHuppaal";
Log.addInfo(myService, "Some information")
Log.addWarning(myService, "Some warning");
Log.addError(myService, "Some error");

Links
You can add inline links to your log message, markdown style:
Log.addWarning("Something is wrong at location [L23](component:MyComponent/L23). Please check it out");

A link can link to many types of things:
// location regex:      [text](location:ComponentName/LocationId)
// edge regex:          [text](edge:ComponentName/EdgeId)
// subcomponent regex:  [text](subcomponent:ComponentName/SubcomponentId)
// jork regex:          [text](jork:ComponentName/JorkId)
// tag regex:           [text](tag:ComponentName/TagId)
// query regex:         [text](query:QueryId)
// component regex:     [text](component:ComponentName)
// file:                [text](generic:filename) (open OS default app)

On Log Entry Events
You can also add event listeners for when new logs are added:
private void subscribeOnLogAdded() {
    Log.addOnLogAddedListener(this::onLogAdded);
}

private void onLogAdded(Log log) {
    // Your code here...
}

Note that the events are being called on the main javafx thread - so you don't need to perform any Platform.runLater operations in your handlers.
Backwards Compatibility
You may notice that this PR doesn't remove the old tabs. This is on purpose. Links to locations doesn't actually work at the moment, since classes in the dk.cs.aau.huppaal.abstractions.* (everything that is a Nearable implementation) doesn't know who their parent component is, so they can't actually create any (working) clickable links. Because of this, I haven't implemented all syntactic elements in the LogLinkQuantifier enumeration.
I have integrated all static functions from CodeAnalysis to also use the new logging framework. I haven't deleted the old code though.

Update: current implementations of Nearable will be linked correctly (the old tabs are still present, but I am fairly sure they could be removed pretty soon):
https://user-images.githubusercontent.com/4085393/202027530-b6229cac-c9ea-4bec-8949-d29b8dda8f2b.mov


Refactor BalancedAllocator.Balancer to LocalShardsBalancer

Signed-off-by: Kunal Kotwani<EMAIL_ADDRESS>Description

Refactors BalancedShardsAllocator.Balancer to a new class LocalShardsBalancer
Adds a new abstract class called ShardsBalancer in prep for RemoteShard support
More details: #4759

Issues Resolved

#4759

Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #4761 (346326c) into main (d15795a) will increase coverage by 0.06%.
The diff coverage is 85.08%.

@@             Coverage Diff              @@
##               main    #4761      +/-   ##
============================================
+ Coverage     70.66%   70.72%   +0.06%
- Complexity    57578    57747     +169
============================================
  Files          4661     4663       +2
  Lines        276662   276669       +7
  Branches      40325    40317       -8
============================================
+ Hits         195501   195672     +171
+ Misses        64926    64734     -192
- Partials      16235    16263      +28

Impacted Files
Coverage Δ

...r/routing/allocation/allocator/ShardsBalancer.java
33.33% <33.33%> (ø)

...ting/allocation/allocator/LocalShardsBalancer.java
85.09% <85.09%> (ø)

...ster/routing/allocation/AllocationConstraints.java
100.00% <100.00%> (ø)

.../allocation/allocator/BalancedShardsAllocator.java
93.25% <100.00%> (+6.12%)
:arrow_up:

.../index/shard/IndexShardNotRecoveringException.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../java/org/opensearch/node/NodeClosedException.java
50.00% <0.00%> (-50.00%)
:arrow_down:

...ch/transport/ReceiveTimeoutTransportException.java
50.00% <0.00%> (-50.00%)
:arrow_down:

...ations/bucket/terms/heuristic/PercentageScore.java
17.39% <0.00%> (-34.79%)
:arrow_down:

...nsearch/index/shard/IndexShardClosedException.java
66.66% <0.00%> (-33.34%)
:arrow_down:

...min/cluster/snapshots/get/GetSnapshotsRequest.java
52.63% <0.00%> (-31.58%)
:arrow_down:

... and 465 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add tests and get project ready with levels

Projects need to be able to use it, so we need to get all errors out of the first levels, and only use higher levels for core.

Solved with https://github.com/spryker/architecture-sniffer/pull/19


fix: typo

Thank you for the PR, but it's just a typo in a unit test, not user-facing.
It seems you submit a lot of these "fix: typo" PRs to several hundred projects, but have your own GitHub activity set to private here, and have no other profile information. Sorry but I'm not comfortable merging under those circumstances.


Send dispatch or emit from Chart to parent view

How can I send some data from the chart to a parente view?

Hi @bleekbless ,
What kind of data you need to send to parent component?

Actually I have 2 questions number 1 is I have to send some text information so the parent componentes canal make another request and show some response the other one os that i need to store more than one data per dot in a line chart

What kind of interaction needed to trigger it? IMO the chart should only receive data from parent and show the data, any data changes should be handled by the parent component, if you need to trigger event from the chart, check out the event docs.
I don't quite get what kind of line chart you mean, does it exist in the sample?

Closed because inactivity.


ggsave legend issues

MWE:
import pandas as pd
from ggplot import *

meat_lng = pd.melt(meat[['date', 'beef', 'pork', 'broilers']], id_vars='date')
thing = ggplot(aes(x='date', y='value', colour='variable'), data=meat_lng) + \
    geom_point() + \
    stat_smooth(color='red')

#print(thing)

ggsave(plot = thing, format = 'png')
ggsave(plot = thing, format = 'pdf')

Expected behavior:  The two image files should be identical to this example, from the ggplot for Python readme.
Actual behavior:  See below.  Both have a ribbon, which I assume has been added to stat_smooth since the example was generated.  More importantly, the legend is malformed in the png version, with legend items placed over each other.  The pdf is legible, but the legend items are a little wider than expected.
pdf:
283578011.pdf
png:

Python 3.4, Mac OS X El Capitain, ggplot 0.6.8, matplotlib 1.5.0.

I'm targeting a PDF built at 96 DPI. I had the same problem until I set dpi=96 and ended up with a correct PNG output. I still think it is a bug but I bet the spacing between the legend entries is expressed in pixels.

fixed in 0.9.3


Upgrade isort to 5.3.2

For #12949 #12932
Description of changes made: https://github.com/microsoft/vscode-python/issues/12932#issuecomment-667233403

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[x] Has a news entry file (remember to thank yourself!).
[x] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[x] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #13340 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13340      +/-   ##
==========================================
+ Coverage   59.64%   59.72%   +0.08%
==========================================
  Files         670      670
  Lines       36830    37303     +473
  Branches     5188     5296     +108
==========================================
+ Hits        21968    22281     +313
- Misses      13770    13884     +114
- Partials     1092     1138      +46

Impacted Files
Coverage Δ

src/client/common/utils/platform.ts
64.70% <0.00%> (-11.77%)
:arrow_down:

src/client/datascience/crossProcessLock.ts
79.41% <0.00%> (-11.77%)
:arrow_down:

...nt/datascience/jupyter/kernels/kernelSelections.ts
84.21% <0.00%> (-5.49%)
:arrow_down:

...active-common/intellisense/intellisenseProvider.ts
33.07% <0.00%> (-4.66%)
:arrow_down:

src/client/datascience/jupyter/jupyterExecution.ts
45.54% <0.00%> (-2.90%)
:arrow_down:

...datascience/interactive-common/notebookProvider.ts
50.58% <0.00%> (-2.43%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0.00%> (-2.23%)
:arrow_down:

...science/notebookStorage/notebookStorageProvider.ts
50.00% <0.00%> (-1.73%)
:arrow_down:

src/client/activation/languageServer/manager.ts
81.15% <0.00%> (-1.66%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0.00%> (-1.57%)
:arrow_down:

... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0cf27d...7df60d8. Read the comment docs.

Is this ready to merge?

Hey @int19h Maybe the notification got skipped, but this PR has been blocked on your review since a week. Can you please review?

@karrtikr @int19h Thanks a lot!
Is there a way to verify which version of isort is being used for sorting imports on save? I looked in the Python extension's output panel but only found ~/.vscode/extensions/ms-python.python-2020.9.102493-dev/pythonFiles/sortImports.py - --diff.

You can edit the sortImports.py file to print the isort version and then run the file directly yourself.


Issues with a text input and date

If the date format is specified as dd.mm.yy the datepicker does not recognize strings like "1.1.2016" (like it is typically typed), but user must type 01.01.2016. It also seems that if user types 1.1.2016 or something else that is considered invalid, the ng-model variable disappears from the containing object structure. Is it possible to configure datepicker in such a way that 1) input field ng-variable is maintained as a string 2) the variable is altered by the datepicker only when a date is selected from the popup?

This is addressed in master via b1cfc5762dd80d8eecec95385a4dcf335cdb8ecd

I tested in plunker. I added {{dt}} to the code to see the ng-model content. Selected "dd.MM.yy" format from the selection box and wrote "12.1.2016" to the first popup. dt did not print at all. Only when I wrote "12.10.2016" the dt became available/visible. Did I use this in some wrong way?

There are the M! and d! formats for optional leading 0s. The commit I referenced shows usage.
This is available in the newly released 1.0. If you aren't able to immediately upgrade, you can override the dateparser service with the one from master.

I am unsure how to specify to the datepicker to use M! and d!.
The datepicker plunker from https://angular-ui.github.io/bootstrap/ seems to be using 1.0.0 and the code has a line: "$scope.altInputFormats = ['M!/d!/yyyy'];" Still the plunker example do not accept "2016/01/9". If I put this 'M!/d!/yyyy' string to  $scope.format, it does not work either.

Please post a reproduction - I am not able to reproduce your problem.

Now I got it. So "altInputFormats" like "format" describe just one input format and in the example it is not possible to write the offered formats 'dd-MMMM-yyyy', 'yyyy/MM/dd', 'dd.MM.yyyy' with one digit. Only a totally different form 'M!/d!/yyyy' is allowed to be typed with one digit, so this needs to be rewritten as 'd!.M!.yyyy' to make my original date string to be accepted. So, 1.0.0 Seems to work with nicely when user writes accepted format. Now, if user clears the input field the value becomes null. However, if user writes by a mistake an invalid string and the json is sent to server, the key and value are missing from the json. I am not unsure how this case should be handled because server can't see the malformed datestring.


forceFetch on a route basis

Is there any possibility to have forceFetch on a route basis rather than just for the whole sets of routes in an app?

Not as currently implemented.

That would be great!

This is probably dependent on https://github.com/relay-tools/react-router-relay/issues/68.

Hey, Is it possible now ?

No.


examples now support gym 0.26

Description
Handle interface changes from gym >= 0.26 based on #205 .
Motivation and Context
Some of the examples break with gym >= 0.26
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[x] Example (update in the folder of example)

Implemented Tasks

[x] update files in examples: xla_step.py, acme_examples/, cleanrl_examples/ and ppo_atari/

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[x] I have read the CONTRIBUTION guide (required)
[ ] My change requires a change to the documentation.
[ ] I have updated the tests accordingly (required for a bug fix or a new feature).
[ ] I have updated the documentation accordingly.
[x] I have reformatted the code using make format (required)
[x] I have checked the code using make lint (required)
[x] I have ensured make bazel-test pass. (required)

I believe there should be some changes to sb3_examples, and not sure if cleanrl_examples can run successfully.
@51616 Please run the training command with both gym==0.26 and gym<0.26 for all your modified scripts.
cc @vwxyzjn

@araffin does sb3 support gym>=0.26 now?

@Trinkle23897 In sb3 script, the reset() and step() calls are handled by sb3 itself. So, I didn't update the scripts unless we want implement a wrapper on top. I will test and fill the table later today.

@araffin does sb3 support gym>=0.26 now?

we have a branch for that (https://github.com/DLR-RM/stable-baselines3/pull/780) but as we use a wrapper anyway, we can support gym 0.26.
I'm also working on having the wrapper directly in the RL Zoo: https://github.com/DLR-RM/rl-baselines3-zoo/pull/307

I have tested all examples with gym=0.26 and gym=0.21. Also, the sb3 example can now handle gym=0.26.

Status
gym>=0.26
gym<0.26 (gym=0.21)
library version

acme_examples
:heavy_check_mark:
:heavy_check_mark:
acme=0.4.0 (acme.git@84e0923)

sb3_examples
:heavy_check_mark:
:heavy_check_mark:
sb3=1.6.2

cleanrl_examples
:heavy_check_mark:
:heavy_check_mark:
N/A

tianshou_examples
:heavy_check_mark:
:heavy_check_mark:
tianshou=0.4.10

ppo_atari
:heavy_check_mark:
:heavy_check_mark:
envpool=0.6.5


wrangler publish fails when ESModule is used

Hello,
I got this error when publishing my ESModule project: Cannot read properties of undefined (reading '1')
I reproduce the issue with the following files:
test.js
import './another.js'

console.log('This is a test')

another.js
console.log('This is another module')

wragnler.toml
name = 'test'
type = 'javascript'
account_id = '<ACCOUNT_ID>'
zone_id = '<ZONE_ID>'

compatibility_date = '2021-11-10'

[build.upload]
format = 'modules'
main = './test.js'

And then run npx wrangler@beta publish
The issue does not exist if another.js is not imported. I am not sure this is a bug or it is because v2 is still in beta and ESModule is not yet supported
Thank you.

I can confirm this bug. The error is being thrown here: https://github.com/cloudflare/wrangler2/blob/main/packages/wrangler/src/publish.ts#L142

You can work around this by providing the entry-point script at the command line:
npm wrangler publish index.js

I think this might already be fixed in main after https://github.com/cloudflare/wrangler2/pull/196, but we should verify

#196 didn't help.

Working on a fix...

Hitting this right now as well. The temp fix doesn't seem to work - same error. Is there another workaround?

wow awesome! Worked great - thanks a million

Closing this, working on the reopened issue https://github.com/cloudflare/wrangler2/issues/78 and the deeper fix with https://github.com/cloudflare/wrangler2/pull/258.


Bump ginkgolinter to v0.9.0 and fix findings

What this PR does / why we need it:
Bump ginkgolinter to v0.9.0 and fix findings
The new version of ginkgo linter adds two new warnings:

HaveLen(0) => BeEmpty()
Expect(x == y).To(BeTrue()) => Expect(x).To(Equal(y)) or
Expect(x > y).To(BeTrue()) => Expect(x).To(BeNumerically(">", y)) etc.

None

/test pull-kubevirt-unit-test-arm64

/test pull-kubevirt-e2e-arm64

Thanks @nunnatsa! Great stuff!
/lgtm
Just to be sure - the updated packages are direct dependencies for ginkgolinter, right?

Just to be sure - the updated packages are direct dependencies for ginkgolinter, right?

yes.

Rebased (fixed conflicts)

@iholder101 - please review again

/test pull-kubevirt-e2e-k8s-1.26-sig-storage

/test pull-kubevirt-unit-test

/lgtm
/unhold

/retest-required

/retest-required


ERCOT upload "retry" leading to document filter issue

On 2023/06/08, it appears ERCOT unsuccessfully uploaded a file under the "Settlement Point Prices at Resource Nodes, Hubs and Load Zones" data product (https://www.ercot.com/mp/data-products/data-product-details?id=NP6-905-CD), resulting in a file named "SPPHLZNP6905_retry_20230608_1545_csv" being uploaded instead.
Due to the added "_retry" in the document name, this file was not included in the document filtering and therefore missing from the returned data. Below is the section of code that does this filtering.
https://github.com/kmax12/gridstatus/blob/b29663791ed30635bb7e09be403b11586bc6ee01/gridstatus/ercot.py#L824-L836
To replicate (using v0.21.0):
import gridstatus
import pandas as pd

ercot = gridstatus.Ercot()

start = pd.Timestamp("2023-06-08", tz="US/Central")
end = pd.Timestamp("2023-06-09", tz="US/Central")

df_rt = ercot.get_spp(start, end, market="REAL_TIME_15_MIN")

thank you for posting. I will look into fixing this ASAP

I believe i fixed the logic to handle files named with retry. I added a test case, but hard to test on live data since these files dont always exist. if you or anyone else sees issues, we can reopen this issue. thanks for reporting!