narrow display of transcript on media > video page

Adding this after having it reported and will check the model file after posting. It seems the display of the optional transcript in 3.11 (and possibly earlier) has become an issue in two ways:

it displays as a narrow column rather than filling the width of the video
it displays over the top of the panel rather than expanding the height of the panel

Both of these issue can be seen in the screenshot below and via the test I created at https://xotbeta.dlearning.nl/play.php?template_id=112#page1

@JohnSmith-LT @torinfo @FayCross sorry I'm not sure who last worked on this page but I know there's potentially some overlap with the popcorn developments. Anyway I might be wrong but as far as I can see there are two places in the textVideo model where the width of the transcript divs are meant to be controlled e.g.
120
if ($("#transcriptHolder").length > 0) {
$("#transcript").width($pageVideo.width());
}
185
if ($("#transcriptHolder").length > 0) {
$("#transcript").width(videoDimensions[0]);
}
and I think the first issue is they are referencing ID's but should be classes instead e.g. the conditions don't seem to be triggered because of this?
I checked the similar code in the textGraphics model and in there they are IDs rather than classes and work fine.
So I tried changing the conditions in the textVideo model to use classes instead and that worked to a certain extent in that the width of the transcript became closer to what it should be but the layout still wasn't correct and in any case the panel should also fit the video and expand accordingly when the transcript button is clicked and that isn't happening either. So I've removed my test changes and will leave this to whoever is most familiar with this model and related code.

This has been stopped with https://github.com/thexerteproject/xerteonlinetoolkits/commit/f5c8770ffe62f46c494948995ee5869d6935ed09 but I feel that these pages still need some work - the transcript makes the video really small which makes it hard to watch without going full screen...

@JohnSmith-LT I've imported my local test project into xotbeta and shared co-author access with your account but also made that public so you cab view via https://xotbeta.dlearning.nl/play.php?template_id=115#page1
The test contains a graphic and sound page with transcript added and then 3 video pages all with transcript added 1st with local video, second with YouTube and 3rd with Panopto embed code. Not sure what you mean about the video going really small but as you'll see in this test project the size of each video and the size of the panel and how the transcript displays when opened varies with each. In fact not sure why but the transcript button and transcript doesn't even show in the Panopto example.

Go to page 3 @ronm123 and open the transcript. Then resize a little and you get this:

@JohnSmith-LT just noticed that if you do that resizing when on page 3 and then navigate to page 2 then the size of the local video and everything else on that page is screwed up too:

@ronm123 @JohnSmith-LT closing this as I've committed fix to panel resize bug wheb transcript opened. I can no longer recreate the bug John found with small video after resize - it's possible Tom's recent video sizing commit has fixed this - reopen if you can still see this bug


A typo in the install script

HA core version
2024.5.4
Intergration version
0.3.22
Device type and model
A1 	Dehumidifier
Used App
Home Assistant
The description of problem
When attempting to install the Midea AC LAN from The Home Assistant Community Store, I get an error. It appears that there's a typo in the URL. The script attempts to download
https://github.com/georgezhao2010/midea_ac_lan/releases/download/v0.3.22/mieda_ac_lan.zip
instead, it should be downloading
https://github.com/georgezhao2010/midea_ac_lan/releases/download/v0.3.22/midea_ac_lan.zip
The logs
No response

@PaGuBo
please check with this issue #517  and forked repo

I confirm. Same on my installation

Same on mine as well.


feat: docker build with multi platforms

Signed-off-by: Gaius<EMAIL_ADDRESS>
Description

Docker build with multi platforms.

Related Issue

Motivation and Context

Screenshots (if appropriate)
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.

Codecov Report

Merging #1337 (2c8f53c) into main (eff00c0) will decrease coverage by 0.20%.
The diff coverage is n/a.

:exclamation: Current head 2c8f53c differs from pull request most recent head 721e4f4. Consider uploading reports for the commit 721e4f4 to get more accurate results

@@            Coverage Diff             @@
##             main    #1337      +/-   ##
==========================================
- Coverage   45.69%   45.48%   -0.21%
==========================================
  Files         140      140
  Lines       11950    11950
==========================================
- Hits         5461     5436      -25
- Misses       5871     5898      +27
+ Partials      618      616       -2

Flag
Coverage Δ

Object-compatibility-e2etests
?

e2etests
?

unittests
45.48% <ø> (-0.21%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

client/daemon/peer/peertask_piecetask_poller.go
30.43% <0.00%> (-16.67%)
:arrow_down:

client/daemon/peer/peertask_conductor.go
57.31% <0.00%> (-0.21%)
:arrow_down:


import of hello-app-iap

Also since you're not deriving this from hello-app, we should not call it hello-app-iap, that just creates confusion. We can say iap-example or iap-sample-app or something.


bazel build issues

Discussed in https://github.com/orgs/kubev2v/discussions/1082

Originally posted by jsakil14 October  3, 2024
I am getting errors: when running below
bazel run push-forklift-operator
Starting local Bazel server and connecting to it...
ERROR: /root/.cache/bazel/_bazel_root/3d084ffa320f6dc5a80a67e2b78d0f1c/external/io_bazel_rules_docker/platforms/BUILD:78:9: in constraint_values attribute of platform rule @@io_bazel_rules_docker//platforms:image_transition: '@@io_bazel_rules_docker//platforms:image_transition_cpu' does not have mandatory providers: 'ConstraintValueInfo'
ERROR: /root/.cache/bazel/_bazel_root/3d084ffa320f6dc5a80a67e2b78d0f1c/external/io_bazel_rules_docker/platforms/BUILD:78:9: in constraint_values attribute of platform rule @@io_bazel_rules_docker//platforms:image_transition: '@@io_bazel_rules_docker//platforms:image_transition_os' does not have mandatory providers: 'ConstraintValueInfo'
ERROR: /root/.cache/bazel/_bazel_root/3d084ffa320f6dc5a80a67e2b78d0f1c/external/io_bazel_rules_docker/platforms/BUILD:78:9: Analysis of target '@@io_bazel_rules_docker//platforms:image_transition' failed
ERROR: /root/forklift/operator/BUILD.bazel:37:16: Target @@io_bazel_rules_docker//platforms:image_transition was referenced as a platform, but does not provide PlatformInfo
ERROR: Analysis of target '//:push-forklift-operator' failed; build aborted: Analysis failed
INFO: Elapsed time: 3.524s, Critical Path: 0.02s
INFO: 1 process: 1 internal.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target
```</div>

@mnecas Is this relevant with https://github.com/kubev2v/forklift/pull/1046

@jsakil14 have you tried the make push-operator-image?

I just run the make build-operator-image and without a problem

We should update the readme, but also running the bazel run push-forklift-operator worked for me.
Have you set all env variables? Which bazel version are you using?

https://github.com/kubev2v/forklift#runing-operator-build I followed this -
I dont have REGISTRY_ORG , so ignored this...
export REGISTRY=internal artifcatory local registry
export REGISTRY_TAG=latest
CONTROLLER_IMAGE=${REGISTRY}/forklift-controller:${REGISTRY_TAG}
OPERATOR_IMAGE=${REGISTRY}/forklift-operator:${REGISTRY_TAG}
My install is on a kubevirt cluster running on bare metal k8s nodes.
bazel version
bazel 7.3.2
From the error: Do we need to set this values? somewhere?
ERROR: /root/.cache/bazel/_bazel_root/3d084ffa320f6dc5a80a67e2b78d0f1c/external/io_bazel_rules_docker/platforms/BUILD:78:9: in constraint_values attribute of platform rule @@io_bazel_rules_docker//platforms:image_transition: '@@io_bazel_rules_docker//platforms:image_transition_os' does not have mandatory providers: 'ConstraintValueInfo'

@jsakil14 if you have some problems with the bazel please try the new dockerfiles, I have not tested them personally but they should correspond to the forklift bazel build. We are slowly moving away from bazel so some stuff might be broken.
https://github.com/kubev2v/forklift/tree/main/build

@jsakil14 if you have some problems with the bazel please try the new dockerfiles, I have not tested them personally but they should correspond to the forklift bazel build. We are slowly moving away from bazel so some stuff might be broken. https://github.com/kubev2v/forklift/tree/main/build

I cant follow properly , are you saying to move into build folder ,and run make build-operator-image ?  I have set env -as below :
export REGISTRY_ORG=kubev2v
export REGISTRY=xyz-docker-virtual.docker.xyz.com
export REGISTRY_TAG=latest
CONTROLLER_IMAGE=${REGISTRY}/${REGISTRY_ORG}/forklift-controller:${REGISTRY_TAG}
OPERATOR_IMAGE=${REGISTRY}/${REGISTRY_ORG}/forklift-operator:${REGISTRY_TAG}

and ran from cloned /forklift directory
bazel run push-forklift-operator
ERROR: /root/.cache/bazel/_bazel_root/3d084ffa320f6dc5a80a67e2b78d0f1c/external/io_bazel_rules_docker/platforms/BUILD:78:9: in constraint_values attribute of platform rule @@io_bazel_rules_docker//platforms:image_transition: '@@io_bazel_rules_docker//platforms:image_transition_cpu' does not have mandatory providers: 'ConstraintValueInfo'
ERROR: /root/.cache/bazel/_bazel_root/3d084ffa320f6dc5a80a67e2b78d0f1c/external/io_bazel_rules_docker/platforms/BUILD:78:9: in constraint_values attribute of platform rule @@io_bazel_rules_docker//platforms:image_transition: '@@io_bazel_rules_docker//platforms:image_transition_os' does not have mandatory providers: 'ConstraintValueInfo'
ERROR: /root/.cache/bazel/_bazel_root/3d084ffa320f6dc5a80a67e2b78d0f1c/external/io_bazel_rules_docker/platforms/BUILD:78:9: Analysis of target '@@io_bazel_rules_docker//platforms:image_transition' failed
ERROR: /root/forklift/operator/BUILD.bazel:37:16: Target @@io_bazel_rules_docker//platforms:image_transition was referenced as a platform, but does not provide PlatformInfo
ERROR: Analysis of target '//:push-forklift-operator' failed; build aborted: Analysis failed
INFO: Elapsed time: 0.769s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

tried make build as well..
make build-operator-image
Makefile:331: warning: overriding recipe for target '`go'
Makefile:326: warning: ignoring old recipe for target '`go'
Makefile:331: warning: overriding recipe for target 'env'
Makefile:326: warning: ignoring old recipe for target 'env'
export CONTAINER_CMD=/usr/bin/podman; \
bazel run operator:forklift-operator-image \
	--verbose_failures \
	--action_env CONTAINER_CMD=/usr/bin/podman
WARNING: Build option --action_env has changed, discarding analysis cache (this can be expensive, see https://bazel.build/advanced/performance/iteration-speed).
ERROR: /root/.cache/bazel/_bazel_root/3d084ffa320f6dc5a80a67e2b78d0f1c/external/io_bazel_rules_docker/platforms/BUILD:78:9: in constraint_values attribute of platform rule @@io_bazel_rules_docker//platforms:image_transition: '@@io_bazel_rules_docker//platforms:image_transition_cpu' does not have mandatory providers: 'ConstraintValueInfo'
ERROR: /root/.cache/bazel/_bazel_root/3d084ffa320f6dc5a80a67e2b78d0f1c/external/io_bazel_rules_docker/platforms/BUILD:78:9: in constraint_values attribute of platform rule @@io_bazel_rules_docker//platforms:image_transition: '@@io_bazel_rules_docker//platforms:image_transition_os' does not have mandatory providers: 'ConstraintValueInfo'
ERROR: /root/.cache/bazel/_bazel_root/3d084ffa320f6dc5a80a67e2b78d0f1c/external/io_bazel_rules_docker/platforms/BUILD:78:9: Analysis of target '@@io_bazel_rules_docker//platforms:image_transition' failed
ERROR: /root/forklift/operator/BUILD.bazel:37:16: Target @@io_bazel_rules_docker//platforms:image_transition was referenced as a platform, but does not provide PlatformInfo
ERROR: Analysis of target '//operator:forklift-operator-image' failed; build aborted
INFO: Elapsed time: 0.327s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target
make: *** [Makefile:187: build-operator-image] Error 1

On the host server , where am running from : I have podman,gcc,bazel,kubectl and k8s connected as well.  OS is rocky 8. Could you help me out..

I just run the make build-operator-image and without a problem

tried this as well , doesnt seem to work. I have many issues like windows boot & using firstboot - thought I can do a clean install using bazel - which doesnt seem to be straight forward. @ahadas fyi..

@jsakil14 if you have some problems with the bazel please try the new dockerfiles, I have not tested them personally but they should correspond to the forklift bazel build. We are slowly moving away from bazel so some stuff might be broken. https://github.com/kubev2v/forklift/tree/main/build

Could you guide me on how to install using dockerfiles? I installed forklift using olm and not with bazel. @mnecas

I had to run it like below
bazel run push-forklift-operator --@io_bazel_rules_docker//transitions:enable=false
then it works!

docker

Is this expected? I am building image file using podman...
ls
Dockerfile
4744262@4744262-de197 v2v % cat Dockerfile
FROM registry.access.redhat.com/ubi9:9.4-1214.1729773476 AS appliance

ENV LIBGUESTFS_BACKEND direct

RUN subscription-manager register --org $(cat "/activation-key/org") --activationkey $(cat "/activation-key/activationkey")

RUN subscription-manager repos --enable=codeready-builder-for-rhel-9-x86_64-rhui-rpms

RUN dnf update -y && \
   dnf install -y --setopt=install_weak_deps=False \
       qemu-img \
       libguestfs-devel \
       libguestfs-winsupport \
       libguestfs-xfs

# Create tarball for the appliance.
RUN mkdir -p /usr/local/lib/guestfs/appliance && \
   cd /usr/local/lib/guestfs/appliance && \
   libguestfs-make-fixed-appliance . && \
   qemu-img convert -c -O qcow2 root root.qcow2 && \
   mv -vf root.qcow2 root

FROM registry.access.redhat.com/ubi9/go-toolset:1.21.13-2.1727893526 AS builder
WORKDIR /app
COPY --chown=1001:0 ./ ./


Third party glslang needs a CMakeLists.txt

I am getting this error about a missing cmakelist.txt
--   Libclang C library:  /usr/local/Cellar/llvm/11.0.0/lib/libclang.dylib
--   Builtin include dir: /usr/local/Cellar/llvm/11.0.0/lib/clang/11.0.0/include
CMake Error at CMakeLists.txt:44 (add_subdirectory):
  The source directory

    /Users/petros/projects/cide/third_party/glslang

  does not contain a CMakeLists.txt file.

CMake Warning at third_party/googletest/CMakeLists.txt:54 (project):
  VERSION keyword not followed by a value or was followed by a value that
  expanded to nothing.

-- Configuring incomplete, errors occurred!
See also "/Users/petros/projects/cide/build/CMakeFiles/CMakeOutput.log".

Commenting out the line that is adding the directory leads the compilation to fail later with:
FAILED: CMakeFiles/CIDEBaseLib.dir/src/cide/glsl_parser.cc.o
/Library/Developer/CommandLineTools/usr/bin/c++ -DCIDEBaseLib_EXPORTS -DQT_CORE_LIB -DQT_GUI_LIB -DQT_HELP_LIB -DQT_NO_DEBUG -DQT_SQL_LIB -DQT_SVG_LIB -DQT_WIDGETS_LIB -I. -I../ -ICIDEBaseLib_autogen/include -I../src -I../third_party/yaml-cpp-0.6.3/include -I../third_party/googletest/include -I/usr/local/Cellar/llvm/11.0.0/include -I/usr/local/include -iframework /usr/local/opt/qt/lib -isystem /usr/local/opt/qt/lib/QtWidgets.framework/Headers -isystem /usr/local/opt/qt/lib/QtGui.framework/Headers -isystem /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/OpenGL.framework/Headers -isystem /usr/local/opt/qt/lib/QtCore.framework/Headers -isystem /usr/local/opt/qt/./mkspecs/macx-clang -isystem /usr/local/opt/qt/lib/QtHelp.framework/Headers -isystem /usr/local/opt/qt/lib/QtSql.framework/Headers -isystem /usr/local/opt/qt/lib/QtSvg.framework/Headers -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -fPIC -Wall -Wextra -O2 -msse2 -msse3 -Wno-sign-compare -Wno-strict-overflow -fPIC -std=gnu++11 -MD -MT CMakeFiles/CIDEBaseLib.dir/src/cide/glsl_parser.cc.o -MF CMakeFiles/CIDEBaseLib.dir/src/cide/glsl_parser.cc.o.d -o CMakeFiles/CIDEBaseLib.dir/src/cide/glsl_parser.cc.o -c ../src/cide/glsl_parser.cc
../src/cide/glsl_parser.cc:147:21: error: excess elements in scalar initializer
    /* .limits = */ {
                    ^
../src/cide/glsl_parser.cc:157:6: warning: missing field 'doWhileLoops' initializer [-Wmissing-field-initializers]
    }};
     ^
../src/cide/glsl_parser.cc:145:42: warning: suggest braces around initialization of subobject [-Wmissing-braces]
    /* .maxDualSourceDrawBuffersEXT = */ 1,
                                         ^~
                                         {
../src/cide/glsl_parser.cc:343:19: error: use of undeclared identifier 'EShLangRayGen'; did you mean 'EShLangRayGenNV'?
    shaderStage = EShLangRayGen;
                  ^~~~~~~~~~~~~
                  EShLangRayGenNV
/usr/local/include/glslang/Public/ShaderLang.h:95:5: note: 'EShLangRayGenNV' declared here
    EShLangRayGenNV,
    ^
../src/cide/glsl_parser.cc:345:19: error: use of undeclared identifier 'EShLangIntersect'; did you mean 'EShLangIntersectNV'?
    shaderStage = EShLangIntersect;
                  ^~~~~~~~~~~~~~~~
                  EShLangIntersectNV
/usr/local/include/glslang/Public/ShaderLang.h:96:5: note: 'EShLangIntersectNV' declared here
    EShLangIntersectNV,
    ^
../src/cide/glsl_parser.cc:347:19: error: use of undeclared identifier 'EShLangAnyHit'; did you mean 'EShLangAnyHitNV'?
    shaderStage = EShLangAnyHit;
                  ^~~~~~~~~~~~~
                  EShLangAnyHitNV
/usr/local/include/glslang/Public/ShaderLang.h:97:5: note: 'EShLangAnyHitNV' declared here
    EShLangAnyHitNV,
    ^
../src/cide/glsl_parser.cc:349:19: error: use of undeclared identifier 'EShLangClosestHit'; did you mean 'EShLangClosestHitNV'?
    shaderStage = EShLangClosestHit;
                  ^~~~~~~~~~~~~~~~~
                  EShLangClosestHitNV
/usr/local/include/glslang/Public/ShaderLang.h:98:5: note: 'EShLangClosestHitNV' declared here
    EShLangClosestHitNV,
    ^
../src/cide/glsl_parser.cc:351:19: error: use of undeclared identifier 'EShLangMiss'; did you mean 'EShLangMissNV'?
    shaderStage = EShLangMiss;
                  ^~~~~~~~~~~
                  EShLangMissNV
/usr/local/include/glslang/Public/ShaderLang.h:99:5: note: 'EShLangMissNV' declared here
    EShLangMissNV,
    ^
../src/cide/glsl_parser.cc:353:19: error: use of undeclared identifier 'EShLangCallable'; did you mean 'EShLangCallableNV'?
    shaderStage = EShLangCallable;
                  ^~~~~~~~~~~~~~~
                  EShLangCallableNV
/usr/local/include/glslang/Public/ShaderLang.h:100:5: note: 'EShLangCallableNV' declared here
    EShLangCallableNV,
    ^
2 warnings and 7 errors generated.
[8/33] Building CXX object CMakeFiles/CIDEBaseLib.dir/src/cide/project.cc.o
ninja: build stopped: subcommand failed.

Glslang is distributed and can be installed separately (even on mac os with homebrew). Do you think linking to the bundled lib unconditionally is the best option?

Probably you did not check out the git submodule for glslang? Doing that should add the missing CMakeLists.txt.
Not sure whether the git submodule is better or expecting the library to be installed on the system. The former should ensure that the version is compatible.

Probably you did not check out the git submodule for glslang? Doing that should add the missing CMakeLists.txt.
Not sure whether the git submodule is better or expecting the library to be installed on the system. The former should ensure that the version is compatible.

I will do.
It's almost always the better solution to expect it system-installed. The compatibility thing can be solved inside find_package or in case of a distro within the package manager.
Every big project (take for example firefox or blender) bundles some critical libraries but is giving the user the option to use the system-installed. This is especially true in source-based distros like Gentoo for example.

@puzzlepaint Please put a bit more love into this project or just archived it. Git submodule checkout currently fails.

@3oheicrw It seems that our ideas about open source projects differ substantially. Personally, I developed CIDE mainly for my own use, but made the project available here for the case that others may be interested in it as well. I cannot guarantee maintenance at all times, however. Since I personally still use CIDE on a daily basis, it works very well for me, and I upload any changes to its code that I make here, archiving the project does not seem like the right thing to do.
If you want to have customer support, perhaps a commercial IDE might be the better option for you? Alternatively, there are also other more mature open source projects. For example, CIDE was heavily inspired by KDevelop. KDevelop usually used to work very well for me and I could recommend it as a more mature alternative.

@3oheicrw It seems that our ideas about open source projects differ substantially. Personally, I developed CIDE mainly for my own use, but made the project available here for the case that others may be interested in it as well. I cannot guarantee maintenance at all times, however. Since I personally still use CIDE on a daily basis, it works very well for me, and I upload any changes to its code that I make here, archiving the project does not seem like the right thing to do.
If you want to have customer support, perhaps a commercial IDE might be the better option for you? Alternatively, there are also other more mature open source projects. For example, CIDE was heavily inspired by KDevelop. KDevelop usually used to work very well for me and I could recommend it as a more mature alternative.

At least please fix the submodule checkout so I could compile your IDE. I have everything set on MSYS2 (toolchain + qt) and still waiting for you.

I may look into it someday but frankly, the tone of your messages doesn't exactly motivate me to do it. You would achieve more by formulating them in a polite way instead of making requests.

I may look into it someday but frankly, the tone of your messages doesn't exactly motivate me to do it. You would achieve more by formulating them in a polite way instead of making requests.

Oh no you don't want me to polite with you. From the beginning I'm a bit tough because I was disappointed, after realized my own ignorant why this IDE requires cmake I lowered the tone and really want to help. Only this IDE moves me from surprise to another surprise my tone get a bit harder again. You don't want me to help. As you said, it's your own and you are eating your own dog food, only share here for people could use if they want (this pretty much nullify any responsibility possible of yours to maintain this project, what is I considered irresponsibility). Oh, don't repeat again the mantra open voluntarily work + work in free time, bla bla... please. I didn't request new features nor even bug fixes. I just requested being able to build. The fact is, you want me to beg you for that and I will not. And I know, even if I begged, you will not neccessarily do it. You will do it when you deemed you want won't you? No. I will not waste time with you and your pet project any longer. Eat your own dog food. Bye.

It is sad to see that there are trolls on GitHub. Welcome to my blocked user list @3oheicrw.


Upgrade to rubocop 1.x

Being stuck on an old version of rubocop is blocking allowing ruby 3.0+ in gems using bixby.  With the release of rubocop 1 it has adopted semantic versioning which means that new cops will not be enabled until the next major release.  This is why I've allowed any version of 1.x rubocop in the gemspec.
I think it is worth revisiting #32 and see if there is enough energy to continue maintaining community style defaults or if the main goal of this gem has been fulfilled with the release of rubocop 1.0.

does bixby want a version bump with this? 4.0.0?

@no-reply I would expect that it would need a major version bump due to the required ruby version even if the rubocop rules don't change (which I expect they might slightly).
If we're doing a major version then it would be good to try and clean things up a bit at the same time:

Removing unnecessary configuration based upon my analysis
Reevaluating other rules like max line length
Any other work necessary for promotion out of labs to core


Wait for event completion in fence

Thank you! You have resolved my TODO :D

Thanks for the fix. Didn't notice it before (I don't use multi-threaded command list generation so it might be the case)


How can I add a source to list and edit the source list?

How can I add a source to list and edit the source list?

closing old issues. Feel free to re-open.


Add permission node search function

Introduces the long awaited search function which lets users enter a search term and returns a list of nodes, grouped by their group/user:

😍


Fix an issue in getIamPolicy method

The response of getIamPolicy method is not updated if we use the same reference name (e.g. "$(ref.get-iam-policy)") in Deployment Manager. We work around the issue by giving a different name with the suffix of timestamp in every deployment update.

This is the bug reporeted at https://github.com/GoogleCloudPlatform/deploymentmanager-samples/issues/39


Does it support Stored Procedure ?

can i ask a question~
Does it support Stored Procedure ?
if support,how can i use it, do you have a demo ?

does it support named parameters?
stmtRes, err := stmt.Exec("exec pro_add @var1 = 1, @var2 = 2")


0.4.0 spec compliance

Codecov Report

Merging #48 (3f7ac3d) into main (745a58b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   92.33%   92.33%
=======================================
  Files           5        5
  Lines         274      274
=======================================
  Hits          253      253
  Misses         20       20
  Partials        1        1

Impacted Files
Coverage Δ

pkg/openfeature/provider.go
100.00% <ø> (ø)

pkg/openfeature/client.go
97.15% <100.00%> (ø)

pkg/openfeature/noop_provider.go
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


When will the code be uploaded?

I found this repository from the paper, but now there is only the readme.md.When will the code be uploaded?
Thank you for your time and consideration.

@rishub-tamirisa, could you address this?

Hello @Zbnzbnzbn ! Thanks for reaching out. We plan to clean up and release the code this month. Apologies for the delay, I was busy with several other deadlines for the last few months.

@rishub-tamirisa Do you have any plans to upload the code recently? Thanks for your time and consideration.

When do you plan to upload the code?Thanks for your time and consideration.

@rishub-tamirisa

@rishub-tamirisa I was wondering if you have any plans to release the code associated with this project. If there is a timeline or any information regarding the release, I would be grateful if you could share it. Thank you for your time and consideration.

Apologies, I got very delayed cleaning up the camera-ready code due to other projects. It's uploaded now.


Joke Telling Website using Vanilla JS

WebMasterLog Repository (Proposing new issue)
:red_circle: Project Title : Joke Telling website
:red_circle: Aim : A website which can provide users jokes according to their interests.
:red_circle: Tech Stack Used : HTML, CSS, JS
:red_circle: Category :  Vanilla-JS

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be all the main components.

Cover image of the application, if project will be deployed in future, with the name of the folder in Kebab-Case (hypen-separated).
Main files in formatted state so that code will be readable.
Other Images - In seprate folder named Images used to form the application.

Inside the Project folder, the README.md file must be filled up properly, with proper visualizations and descriptions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.

:white_check_mark: To be Mentioned while taking the issue :

Full name :
GitHub Profile Link :
What is your participant role? (Mention the Open Source Program name. Eg. GSOC, GSSOC, SSOC, JWOC, etc.)

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

assign me under JWOC

what kind of project you want in this repo
Create some issue related to Vanilla-JS

@AftabMankapure Assigned to you. Follow the contributing guidelines.
Any innovative project but neither games nor calculators.
Even you can create same project which is present in other tech stack and contribute it another tech stack by creating it that techs.


Feat. request: myApp.showTab(tab, force)

tl;dr; Add a boolean force parameter to re-trigger the show event in case the tab is already active.

Not exactly a bug but I wanted to propose to add a force parameter to this function. Here's my case in point.
Suppose we have a specific functionality that should happen right after a tab is shown. To capsulate this one would use:
	$$('.mytab-1').on('show', function () {
                // some sort of very specific calls
		ajaxLoad(data);
                showData(element);
	});

Now, we would like this to be executed every time the user makes modifications on another page and goes back to the page where the tabs are:
	myApp.onPageBack('config-page', function(page) {
                // Some other code ..
		myApp.showTab('.tabs.mytab-1');
	});

Now this won't work because that tab is already .active, therefore one cannot trigger the  show event again.

Ok, will add it. But you may also use it like:
    myApp.onPageBack('config-page', function(page) {
                // Some other code ..
        var wasActive = $('.tabs.mytab-1').hasClass('active');
        myApp.showTab('.tabs.mytab-1');
        if (wasActive) $('.tabs.mytab-1').trigger('show');
    });

:+1:
Ah, dang it. My workaround was:
$('.tabs.mytab-1').removeClass('active');
myApp.showTab('.tabs.mytab-1');

:)
The force param is nice to have but no biggie.


In the spirit of #116, create a dynamic version of siUnit.

@bjornbm, do you see any problem with this? My TH package needs some way to get at the numerical value of an AnyQuantity ExactPi and this seemed like a principled way that might also have other uses.
extractTheValue :: AnyQuantity ExactPi -> ExactPi
extractTheValue q = q /~ (siUnit . dimension $ q)

Should be OK I would think.


envoy start error deploy way is sidecar in my app

Title: One line description
deploy envoy sidecar in my app ，but envoy contianer start error。
I want to configure the external OPA authentication function through envoy and start the error reporting through sidecar,
Description:

uri is my opa sidecar access url
this is my envoy.yaml file
`static_resources:
listeners:
- name: listener_0
address:
socket_address: { address: <IP_ADDRESS>, port_value: 80 }
filter_chains:
- filters:
- name: envoy.filters.network.http_connection_manager
typed_config:
"@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
stat_prefix: ingress_http
codec_type: auto
route_config:
name: local_route
virtual_hosts:
- name: local_service
domains: ["*"]
typed_per_filter_config:
envoy.filters.http.ext_authz:
"@type": type.googleapis.com/envoy.extensions.filters.http.ext_authz.v3.ExtAuthzPerRoute
check_settings:
context_extensions:
virtual_host: local_service
routes:
- match: { prefix: "/install" }
route: { cluster: some_service }
http_filters:
- name: envoy.filters.http.ext_authz
typed_config:
"@type": type.googleapis.com/envoy.extensions.filters.http.ext_authz.v3.ExtAuthz
http_service:
server_uri:
uri: localhost:8181/v1/data/ecpdev/api/install
cluster: ext-authz
timeout: 0.25s
failure_mode_allow: false
clusters:
- name: some_service
connect_timeout: 0.25s
type: LOGICAL_DNS
lb_policy: ROUND_ROBIN
load_assignment:
cluster_name: some_service
endpoints:
- lb_endpoints:
- endpoint:
address:
socket_address:
address: <IP_ADDRESS>
port_value: 8000
- name: ext-authz
connect_timeout: 0.25s
type: logical_dns
lb_policy: round_robin
load_assignment:
cluster_name: ext-authz
endpoints:
- lb_endpoints:
- endpoint:
address:
socket_address:
address: <IP_ADDRESS>
port_value: 8181`
error info：
error initializing configuration '/etc/envoy/envoy.yaml': Error: non-terminal filter named envoy.filters.http.ext_authz of type envoy.filters.http.ext_authz is the last filter in a http filter chain.

The route filter should be the last, please check https://www.envoyproxy.io/docs/envoy/latest/start/sandboxes/ext_authz.html?highlight=envoy filters http ext_authz and try.

The route filter should be the last, please check https://www.envoyproxy.io/docs/envoy/latest/start/sandboxes/ext_authz.html?highlight=envoy filters http ext_authz and try.

ok，thanks

I think this may be can be closed directly now? @gogowaiting


How can I run flems.io locally?

Hello,
I am a newbie and would like to find out how I can self-host flems.io?  I am learning as much as I can to web programming and this looks to be a very useful and helpful tool.
Thanks.

Why would you want to self-host it?

For offline use and because the site is blocked from where I work.

flems.io isn't open source so there isn't really a simple way to self host it I don't think.
https://github.com/porsager/flems.io
That said, flems.io is a wrapper around this package, flems, so you could create your own wrapper around it and host it yourself :thinking:
The main things flems.io provides are the interface for adding dependencies / new files, which shouldn't be too hard to re-implement.
Here's a little demo I just coded up to give you an idea
There might some other considerations on the server side that I'm not thinking of, but it should be doable.

I don't know if this is the same question as @aballeras01 had or a new one. Some confusion with the naming but I think he and I are trying to do the same thing, create a stand alone playground that doesn't need to "dial home" to flems.io.
For example, I noticed when I was trying to get a stand alone, static web app version of flems running that I still had to link back to flems.io:
<script src="https://flems.io/flems.html" type="text/javascript" charset="utf-8"></script>
Is the flems.html document that lives on the root at flems.io from this repository or modified specifically for flems.io? Is there a way to self host that file alongside local content or on a sever behind a firewall?

flems.html hosted on flems.io is the distributed version of this core library, so you can just download that or use the one found on this repo if you want to host it yourself 😉

Hi @porsager, thanks for the tip! I think making that relationship clear in the documentation would help future Flems-ers.
Confirming that flems.html I got via npm run build does work stand alone! In the past I had trouble copying flems.html from flems.io so I was under the impression that file may have been modified from what this repo built. But if flems.io does simply host the latest flems.html then I must have been making some other mistake 🙃

Hello,
Did an npm run build but the flems.html created is not running.  There is an errant beginning comment "/*".  After removing it,  I just get a blank screen.  Also this link to flems.html is also not rendering.
https://flems.io/flems.html
Thanks.

@aballeras01 I think you have to load the locally created flems.html in a script tag, as show in the docs/readme.

Did you manage to make it work @aballeras01 ?

Hi @aballeras01 . If you're still having problems running flems yourself, feel free to open this issue again, but I'll close it out for now ;)


Customize Wysiwyg toolbar

I need a field with only the h3 and paragraph levels
I'd like to add a configuration in my form builder to customize the Wysiwyg toolbar.

Could be done with a data-attribute on the textarea tag, so with attr config but it will not allow for formatting functions.
Better register javascript Pell configuration object and use those.
I'd need a few directions before creating a PR.

The actions are defined here: https://github.com/monsieurbiz/SyliusRichEditorPlugin/blob/26a41cb575b773864103d87a8c654b9e858f3f6c/src/Resources/views/Admin/app.html.twig#L86-L103
But it is for all wysiwyg fields. It could be possible to pass the actions directly to an attribute of the field, using data-actions as example, and a json encoded value.
Then add a condition here to initialize Pell with those actions if they exist:
https://github.com/monsieurbiz/SyliusRichEditorPlugin/blob/26a41cb575b773864103d87a8c654b9e858f3f6c/assets/js/app.js#L32

Another way could be to register somewhere more Pell configurations identified by a specific name, and use that name in the attribute to setup pell for each wysiwyg field.
This is much better actually but it'll require a bit more code.

I'm wondering whether this plugin should be so opinionated on the js text editor to use altogether.
We need at least a way to configure Pell's toolbar globally and for individual UiElements but why not allow replacing the editor library?

If you want to replace the library you are free to do so ;).
But we won't change the library here because the goal is to have something really simple.

Sure, I just meant supporting / documenting text editing lib switch

Yes but why documenting a feature which doesn't exist yet? :p

I'm actually making the scope of this issue wider than just "toolbar customization"


Better IMAP: Messages labels prefetching

A suggestion for fixing the lag when displaying labels on message load.
Instead of re-opening and closing an IMAP connection each time a message is loaded, how about using ~the IDLE command or~ the NOOP command every 29 minutes to maintain the connection opened ?
That way you'd need not to AUTHENTICATE/LIST/SELECT/FETCH each time a message is loaded.
Combined with a folder observer listening to folder switches, you can SELECT an IMAP mailbox upon folder changed (loaded/unloaded events, IIRC).
~Also, with IDLE you can observe IMAP mailboxes and catch when a message label is edited.~ (Erratum: Actually X-GM-LABELS are not added in IDLE'd FETCH unsolicited responses, though)
At last, you could prefetch labels from messages visible in the mailview pane, and prefetch next ones each time the user scrolls.

Assuming the IMAP connection would be persistent, labels could be fetched on demand using a custom column handler.

   // To be flushed on folder unselection
  ... this._messages = { labels: {}, awaiting: {} };

  nsIMsgCustomColumnHandler.getCellText: LabelOnDemand(uid) {
    if (uid in this._messages.labels) return this._messages.labels[uid];
    if (uid in this._messages.awaiting) return;
    const msgHdr = gDBView.getMsgHdrAt(uid);
    const labels = msgHdr.getStringProperty('X-GM-LABELS');
    if (labels) {
      this._messages.labels[uid] = labels;
      return labels;
    }
    const session = ...imapSession(msgHdr.folder.server);
    if (!session) return;
    this._messages.awaiting[uid] = true;
    FETCH(..., (response) => {
      const labels = response...;
      msgHdr.setStringProperty('X-GM-LABELS', labels);
      this._messages.labels[uid] = labels;
      delete this._messages.awaiting[uid];
      document.querySelector('#threadTree').invalidateRow(uid);
    });
  }

I don't mind the lag when fetching labels, but it makes all of Thunderbird unresponsive.


Is 1.2.0 compatible with 1.1.1

hello,
I orderd to print some of the 1.1.1 details in a local library. 1.2.0 was released while I was waiting.
My 1.1.1. printed details
sideWallLeft_P  - 1x
sideWallRight_P - 1x
xyPlate_P       - 2x
xBar_P.stl      - 4x
yBar_P.stl      - 4x

Is 1.2.0 compatible with 1.1.1? Thanks.

Yes they should be. The only difference is that the yBars in 1.2.0 have the side modules attached to it already (like the hinge and magnet holders). The newer version just simplifies assembly and reduces the number of parts. How the parts fit together has not changed.

side modules attached to it already

Just assembled my v1.1.1! Here is how 1.2.0 would be simpler.
1.1.1 VS 1.2.0

1.1.1: need to glue magnet and hinge holders

1.2.0: magnet and hinge holders are built in


chore: spi: skip github oauth test

Description
skip the oauth test until it's fixed
Issue ticket number and link
https://issues.redhat.com/browse/KFLUXBUGS-1108
Type of change

[X] test skip

How Has This Been Tested?
N/A
Checklist:

[X] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

/approve
/lgtm

basic CI checks (build, lint) passed. merging


InteractivePrompt scroll issues

When editor is placed in a page which height overflows, the focus tooltip does not stay attached to its focused element. In fact it does scroll with page since it has  position: fixed.
A solution may be to set its position: absolute and make its parent position: relative setting left: 0 and top: -$label-height, but as I've seen this is not enough when the tooltip should be placed over the preview bar beacuse it is in another DOM and z-index does not apply.

Can you try to fix this?
Best regards

This problem will not occur in the next version, you can preview it first. https://easy-email-m-ryan.vercel.app/

Thanks a lot! When will it be released?

It will take about a week, we need to do more testing work.

Okay thanks a lot!


⚠ ClamAV has degraded performance

In 5bf030d, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 195 ms

Resolved: ClamAV performance has improved in 931f89a after 5 minutes.


Create a websocket server enabled Botkit connector which can manage multiple remote clients

This represents an important next step on the roadmap for Botkit: a native communication channel that allows Botkit to talk directly to the web, native clients, or custom platforms.
This is ACTIVELY UNDER DEV and slated for release for a few weeks from now!
Amongst the many todos:

Add documentation for using the websocket
Expand the client code and make it friendlier to use with tools like React and Angular
Publish a mechanism for expanding the message object schema (or adopting other formats)
Make the socket server more robust

The code for this is available in this pull request:
https://github.com/howdyai/botkit/pull/872
I've also created a simple web client starter kit:
https://github.com/howdyai/botkit-starter-web

can we use this library https://github.com/primus/primus to that will let the use se any socket library.

@munawwarhussain That is very interesting! I'll have to take a look.  What are the alternative socket libraries you are interested in?

@benbrown we are waiting for something like this!!!
Is it possible to use the Web Bot without a Botkit Studio token, running in my own server?

@maxmeinberg Yes! You can run it standalone like any other integration, but studio will greatly extend it's capabilities.

@benbrown problem with socket.io is that it has problem scaling and good to have options open.

@benbrown I'm trying to use this Web Bot with my existing Facebook bot and got this error message
"Cannot read property 'middleware' of undefined" when call Web.controller.middleware.receive.use(middleware.receive);
Is it possible to use the Web Bot in same server with Facebook Bot and Watson?
This is part of my code:
module.exports = function(app) {
if (process.env.USE_WEB) {
var Web = require('./bot-web');
Web.controller.middleware.receive.use(middleware.receive);
console.log('Web bot is live');
}
if (process.env.USE_FACEBOOK) {
var Facebook = require('./bot-facebook');
Facebook.controller.middleware.receive.use(middleware.receive);
Facebook.controller.createWebhookEndpoints(app, Facebook.bot);
console.log('Facebook bot is live');
}
// Customize your Watson Middleware object's before and after callbacks.
middleware.before = function(message, conversationPayload, callback) {
if (message.user == process.env.FACE_PAGE_ID)
callback(null, conversationPayload);
else
callback(true);
}
middleware.after = function(message, conversationResponse, callback) {
console.log('After message', message);
callback(null, conversationResponse);
}
};
Thank you very much!!

@maxmeinberg That should work, as you pass in middleware depending on Node's ENV variable setting! Would be interesting how you handle of different tokens depending on the Bot's realm (that is Facebook, Slack and the like).

+1


Resource name button - View or edit the resource name in the creation form

Is this a new component or an extension of an existing one?
We already use the 'Resource name' link button in some areas of the UI (e.g., in the project creation modal). However, we want to change how this button is presented and develop a consistent pattern that can be applied wherever it is relevant.
Describe the feature

This is a button to help users to view or edit the resource name of an object in a creation form.
The resource name will capture the name to generate a value by default and the resource name will be displayed in the help text under the ‘Name’ field.
If users need to edit the resource name by themselves, they can click the ‘Edit resource name’ button to edit it.
The resource name is not editable after the creation.

Are there visuals for this feature? If applicable, please include examples for each state and for varying widths
Here is the link to the guideline document that describes this pattern and provides examples.
Any other information?
For any UX queries regarding this pattern, please contact Kun (Xiankun Li) and Sim Dhaliwal.

It looks like this component was already created in the odh-dashboard repository and is reusable. https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/concepts/k8s/K8sNameDescriptionField/K8sNameDescriptionField.tsx

@simrandhaliw Would it be OK to add a "Description" text area field as part of this pattern?
The current component which is being used in RHOAI is K8sNameDescriptionField so the Description field is included. In the pattern guidelines document, I see that the last screenshot (Model server) doesn't have the description field.
Is it ok to add a Description field? Or is the goal to have a component encapsulating only the Name and Resource name fields?
(also tagging @jeff-phillips-18)

This was discussed in Slack, and I'm sharing some notes from the thread here for transparency:

[Jeff] The Form field is for entering the resource (display) name, giving the user the optional option of setting the actual resource name (k8s name field). The description field would be separate and I don’t think it needs to be included with the name field.
[Jenn] These were designs that were recently handed over to the RHOAI eng team. These were implemented as part of RHOAIENG-583. I think this pattern now falls into the category of existing UI components that we want to include for visibility and documentation. (Vs UI components that don’t exist where we want to provide guidance on how to implement)


Add provider block

This allows us to use explicitely the appfolio-ci remote state storage to avoid storing local terraform state files.

Opened here instead of the fork by mistake.


Analyzer assist test starts failing with CL 117542

Test pkg/analysis_server/test/src/services/correction/assist/convert_to_package_import_test starts failing when committing https://dart-review.googlesource.com/c/sdk/+/117542
@pq believes it to be a problem in the test.

Thanks!

I don't know if there's a race here, but between yesterday and today I've seen this test both pass and fail at least twice each when running the analysis_server/test_all.dart locally without any related changes.


Remove #[deny(warnings)]

#[deny(warnings)] is considered an anti-pattern.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @korken89 (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

If we do this, we should set -Dwarnings in CI so that we don't merge code with warnings

@jonas-schievink good point. It is done now.


Support /transactions API

There is new beta API to get the list of transactions. Currently, this API is still not available on this PHP SDK.
https://developers.xendit.co/api-reference/#transactions

#144

Closing this as resolved~


[Question]: Chat engine takes long time to generate output for the first query

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
When using chat engine with stream_chat it takes long time to generate output just for the first query. The subsequent queries are processed quickly. Why does this problem occur and what to do to resolve this. I am using vertex ai for llm and embed model

@dosu-bot  the model is initialized and assigned to settings.llm. But it looks like it only connects to the api when the first query is given. How to overcome this


pull request for e2e test at 02/04/2017 11:26:05

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Using plugins on Github Actions

Is there a way to use Danger plugins in the Github actions. I see there is a docker image for danger but that image doesn't use bundler.

This repo doesn't have a dockerfile, what are you using for the Dockerfile for actions?

as mentioned in the Getting started guide I am using the duck8823/actions/danger docker image.

Then you'll need to make changes to that Dockerfile - yep, ideally this should probably be living in this repo so that it's centralized and people can work together on things like that.
Basically you'll need to add a Gemfile to the docker file and any required plugins.

@orta I have this Docker image which can be used for loading plugins and running danger in github actions. Feel free to use it in your guides.

Yeah, I think we should have that in this repo and treat it as the canonical source - want to do that?

@orta opened a pr for this.

Hey guys, I'm trying to integrate Danger with GitHub Actions and I have some troubles. Maybe you'll be able to help me out with this one or give me some hints.
I've integrated everything locally and created a simple main.workflow in my repo:
action "Danger" {
   uses = "danger/danger@master"
   secrets = ["GITHUB_TOKEN"]
}

So far, so good, GitHub was happy with this action and when I've opened new PR it got executed properly, but every run was failing with the following logs (I'm pasting whole thing to give a better context):
### STARTED Danger 16:05:13Z

Pulling image: gcr.io/github-actions-images/action-runner:latest
latest: Pulling from github-actions-images/action-runner
169185f82c45: Already exists
e07893e5a964: Pulling fs layer
3e845980d4e2: Pulling fs layer
c49bb58b9e65: Pulling fs layer
40b259a2793c: Pulling fs layer
40b259a2793c: Waiting
e07893e5a964: Verifying Checksum
e07893e5a964: Download complete
3e845980d4e2: Verifying Checksum
3e845980d4e2: Download complete
c49bb58b9e65: Verifying Checksum
c49bb58b9e65: Download complete
e07893e5a964: Pull complete
40b259a2793c: Verifying Checksum
40b259a2793c: Download complete
3e845980d4e2: Pull complete
c49bb58b9e65: Pull complete
40b259a2793c: Pull complete
Digest: sha256:1cd47f51356f6649eafc231b20e7abb92cc6777f8d928cf0e4070eeb6f820376
Status: Downloaded newer image for gcr.io/github-actions-images/action-runner:latest
Step 1/17 : FROM ruby:2.5
2.5: Pulling from library/ruby
741437d97401: Already exists
34d8874714d7: Already exists
0a108aa26679: Already exists
7f0334c36886: Already exists
65c95cb8b3be: Already exists
f32ce1a51034: Already exists
bc94ac5e9510: Pulling fs layer
f0e5f80b593b: Pulling fs layer
f0e5f80b593b: Verifying Checksum
f0e5f80b593b: Download complete
bc94ac5e9510: Verifying Checksum
bc94ac5e9510: Download complete
bc94ac5e9510: Pull complete
f0e5f80b593b: Pull complete
Digest: sha256:ee6cfefa56b5a38c061c961de1fa086cf00b1d90dbae9220fa3f113f86432fa6
Status: Downloaded newer image for ruby:2.5
 ---> b74fc909a012
Step 2/17 : LABEL "com.github.actions.name"="Danger"
 ---> Running in 01199f601607
 ---> 6283fbec535b
Step 3/17 : LABEL "com.github.actions.description"="Runs danger in a docker container such as Github Actions"
 ---> Running in 4026ff974599
 ---> 53bdcd8229d2
Step 4/17 : LABEL "com.github.actions.icon"="mic"
 ---> Running in 212f217b1568
 ---> eda7c239a9dd
Step 5/17 : LABEL "com.github.actions.color"="purple"
 ---> Running in 66ceca625d28
 ---> 753de24ddccf
Step 6/17 : LABEL "repository"="http://github.com/danger/danger"
 ---> Running in c15d0b83c33e
 ---> 44dfd0be415a
Step 7/17 : LABEL "homepage"="http://github.com/danger/danger"
 ---> Running in f1de03afdfd2
 ---> 9f7a30d82f6a
Step 8/17 : LABEL "maintainer"="Rishabh Tayal<EMAIL_ADDRESS> ---> Running in 64996c8bcd21
 ---> e053d6d92643
Step 9/17 : RUN apt-get update -qq && apt-get install -y build-essential p7zip unzip
 ---> Running in be4dc4d23b3f
Reading package lists...
Building dependency tree...
Reading state information...
unzip is already the newest version (6.0-21).
The following additional packages will be installed:
  dpkg-dev fakeroot libalgorithm-diff-perl libalgorithm-diff-xs-perl
  libalgorithm-merge-perl libfakeroot
Suggested packages:
  debian-keyring p7zip-full
The following NEW packages will be installed:
  build-essential dpkg-dev fakeroot libalgorithm-diff-perl
  libalgorithm-diff-xs-perl libalgorithm-merge-perl libfakeroot p7zip
0 upgraded, 8 newly installed, 0 to remove and 4 not upgraded.
Need to get 2171 kB of archives.
After this operation, 3469 kB of additional disk space will be used.
Get:1 http://deb.debian.org/debian stretch/main amd64 dpkg-dev all 1.18.25 [1595 kB]
Get:2 http://deb.debian.org/debian stretch/main amd64 build-essential amd64 12.3 [7346 B]
Get:3 http://deb.debian.org/debian stretch/main amd64 libfakeroot amd64 1.21-3.1 [45.7 kB]
Get:4 http://deb.debian.org/debian stretch/main amd64 fakeroot amd64 1.21-3.1 [85.6 kB]
Get:5 http://deb.debian.org/debian stretch/main amd64 libalgorithm-diff-perl all 1.19.03-1 [48.7 kB]
Get:6 http://deb.debian.org/debian stretch/main amd64 libalgorithm-diff-xs-perl amd64 0.04-4+b2 [11.6 kB]
Get:7 http://deb.debian.org/debian stretch/main amd64 libalgorithm-merge-perl all 0.08-3 [12.7 kB]
Get:8 http://deb.debian.org/debian stretch/main amd64 p7zip amd64 16.02+dfsg-3+deb9u1 [364 kB]
debconf: delaying package configuration, since apt-utils is not installed
Fetched 2171 kB in 0s (16.1 MB/s)
Selecting previously unselected package dpkg-dev.
(Reading database ...

Preparing to unpack .../0-dpkg-dev_1.18.25_all.deb ...
Unpacking dpkg-dev (1.18.25) ...
Selecting previously unselected package build-essential.
Preparing to unpack .../1-build-essential_12.3_amd64.deb ...
Unpacking build-essential (12.3) ...
Selecting previously unselected package libfakeroot:amd64.
Preparing to unpack .../2-libfakeroot_1.21-3.1_amd64.deb ...
Unpacking libfakeroot:amd64 (1.21-3.1) ...
Selecting previously unselected package fakeroot.
Preparing to unpack .../3-fakeroot_1.21-3.1_amd64.deb ...
Unpacking fakeroot (1.21-3.1) ...
Selecting previously unselected package libalgorithm-diff-perl.
Preparing to unpack .../4-libalgorithm-diff-perl_1.19.03-1_all.deb ...
Unpacking libalgorithm-diff-perl (1.19.03-1) ...
Selecting previously unselected package libalgorithm-diff-xs-perl.
Preparing to unpack .../5-libalgorithm-diff-xs-perl_0.04-4+b2_amd64.deb ...
Unpacking libalgorithm-diff-xs-perl (0.04-4+b2) ...
Selecting previously unselected package libalgorithm-merge-perl.
Preparing to unpack .../6-libalgorithm-merge-perl_0.08-3_all.deb ...
Unpacking libalgorithm-merge-perl (0.08-3) ...
Selecting previously unselected package p7zip.
Preparing to unpack .../7-p7zip_16.02+dfsg-3+deb9u1_amd64.deb ...
Unpacking p7zip (16.02+dfsg-3+deb9u1) ...
Setting up dpkg-dev (1.18.25) ...
Processing triggers for libc-bin (2.24-11+deb9u3) ...
Setting up p7zip (16.02+dfsg-3+deb9u1) ...
Setting up libfakeroot:amd64 (1.21-3.1) ...
Setting up libalgorithm-diff-perl (1.19.03-1) ...
Setting up build-essential (12.3) ...
Setting up fakeroot (1.21-3.1) ...
update-alternatives: using /usr/bin/fakeroot-sysv to provide /usr/bin/fakeroot (fakeroot) in auto mode
Setting up libalgorithm-merge-perl (0.08-3) ...
Setting up libalgorithm-diff-xs-perl (0.04-4+b2) ...
Processing triggers for libc-bin (2.24-11+deb9u3) ...
 ---> 53344d48409e
Step 10/17 : ENV APP_HOME /myapp
 ---> Running in 908451d5d882
 ---> 562ae20abbe9
Step 11/17 : RUN mkdir $APP_HOME
 ---> Running in 9aa83030f0a1
 ---> 2f39c2609948
Step 12/17 : WORKDIR $APP_HOME
 ---> Running in 234e2a347fd5
 ---> 47352c796d34
Step 13/17 : ADD ./Gemfile $APP_HOME/Gemfile
 ---> 5d93c1a01d6e
Step 14/17 : ADD Gemfile.lock $APP_HOME/Gemfile.lock

### FAILED Danger 16:05:40Z (26.163s)

Next step in Dockerfile is RUN bundle install, but I'm not sure if this is an issue or something else? I'd love to sort this out and apply necessary fixes to make it works, though I have no idea where to start with this one 😉

@cojoj I am having the same issue, were you ever able to resolve it?

and what's it?
R©ASB
On Tue, Jun 18, 2019, 09:50 DJ Mitchell<EMAIL_ADDRESS>wrote:

@cojoj https://github.com/cojoj I am having the same issue, were you
ever able to resolve it?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/danger/danger/issues/1062?email_source=notifications&email_token=AMBUU57XNQC42ATV4YV57YDP3A5MPA5CNFSM4GNH6NFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX45STY#issuecomment-502913359,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMBUU5653JVLHW5UW72TMC3P3A5MPANCNFSM4GNH6NFA
.


Spurious TS7024 (Function implicitly has return type 'any'...) and TS2577 (Return type annotation circularly references itself) in TS 5.1.x

Bug Report

🔎 Search Terms

TS7024: Function implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions
TS2577: Return type annotation circularly references itself
5.1.6 regression

🕗 Version & Regression Information

I see the issue with TS 5.1.3-5.1.6 and the latest nightly.
I do not see the issue with TS 5.0.4.

This changed between versions 5.0.4 and 5.1.3

⏯ Playground Link
Variant 1 (no return type annotations, 2x TS7024)
https://www.typescriptlang.org/play?target=99#code/GYVwdgxgLglg9mABMAPAFUQUwB5U2AEwGdEBDMATwG0BdAPgAoA3ALkQCVNSCEAbCgIIAnIaQro6ASkQBvRAF8AUMuAMqixJsTqtuxOAKZgMMJgIAaDXs0NpAXjqyFl3TRdad1xAEZ3124gOslZeWhAIRHC8mAB0vHAA5gwA5AASmLzxyZIhevJ+iG6KNDlAA
Variant 2 (I added one return type annotation, I get TS7024 + TS2577):
https://www.typescriptlang.org/play?target=99#code/GYVwdgxgLglg9mABMAPAFUQUwB5U2AEwGdEBDMATwG0BdAPgAoA3ALkQCVNSCEAbCgIIAnIaQro6ASkQBvRAF8AUMuAMqixJsTqtuxOAKZgMMJgIAaDXs0NJbJnBgFEAXjqyFl3TS9ad1xABGX2tbV3cZKwCtCAQiOF5MADpeOABzBgByAAlMXlTMySi9eRDEH0UaIqA
💻 Code
Variant 1
function f<T extends any[]>(v: ReadonlyArray<T>) { }

f([
    [
        undefined,
        () => { },
    ],
    [
        1,
        () => {
            console.log('Hello')
        },
    ],
])

Variant 2
function f<T extends any[]>(v: ReadonlyArray<T>) { }

f([
    [
        undefined,
        (): void => { },
    ],
    [
        1,
        () => {
            console.log('Hello')
        },
    ],
])

🙁 Actual behavior
The code doesn't compile.
What's strange is from my tests it seems that if I run tsc filewithcode.ts it compiles fine but if I run tsc on the whole project it produces errors.
🙂 Expected behavior
I expected the code to compile.

What's strange is from my tests it seems that if I run tsc filewithcode.ts it compiles fine but if I run tsc on the whole project it produces errors.

Most likely you're having a tsconfig.json with noImplicitAny enabled. When running tsc on individual files the compiler won't use your project configuration, and the default value for noImplicitAny is false.

Oh yes, noImplicitAny is very much enabled (in the local project and in the playground).

Bisected this to this diff. It should be safe to say that this has been changed by https://github.com/microsoft/TypeScript/pull/53607

I'll take a look.

Thank you all, I can confirm the problem is gone in the current nightly (5.2.0-dev.20230728).


add common entry points to wiki page

Since the documentation is spread over multiple locations each with its own focus a list of common entry point could guide users to the "right" documentation / answers.

The enhancement is unclear to me. Do you mean a <doc> tag or something?

Currently the catkin wiki page only contains a few links e.g. to external documentation. The user has to follow those links to find out what the links actually contain. This ticket is about adding more links to the wiki page with specific descriptions to reference various resources specific to common questions. That should enable user to find the information they are looking for easier.

Closing due to inactivity.


Mat/Pat - CRM ticket on reapproval

User Story
As a supervisor, I want a CRM ticket to be created automatically when I reapprove a mat/pat leave application so that I do not have to do it manually and it can be connected to the original CRM ticket
Acceptance Criteria

[ ] New information must be sent to the same CRM ticket created when the form was submitted the first time.
[ ] Supervisor should receive an email to confirm the CRM ticket has been updated with the new information

[ ] Email copy should be the default CRM copy when a ticket is created

[ ] The ticket should contain all form fields in the ticket details section

[ ] The text in the thread should be in a format that is easy to read (Sample below)

[ ] The new form should be an additional pdf attachment. The old attachments should not be replaced
- The pdf should contain only the review & certification pages in the form

Sample
Click to enlarge

Technical notes

to start work after #1100

Bhumin has inquired with Nancy about CRM threads - want to have the system delete old threads and only keeping the most recent thread.

I would recommend a second copy of the document is attached to the service request.  It would be time stamped in the audit log to show it’s the newest.  Then we have a complete record of the employees submissions in the event that they/we need it.

Bhumin to make changes and send to testing by end of day.

I did not receive a CRM email for every resubmission, but when i did it reflected the changes, except a weird bug with the start date. - documented in #1334


Retrieve patient treatment for hypertension status via FHIR

Today, the patient's treatment for hypertension status (yes/no) must be set via a UI control. Ideally, this information would be retrieved via FHIR if available.

For Cerner systems, see: https://fhir.cerner.com/millennium/dstu2/individuals/patient/#extensions


How can I get the distance from the face to the camera from the picture？

I know that outputs contains the normalized x, y, z.
But I want to get the depth from the face to camera. Can mediapipe give the depth or calculate the depth from the normalized x, y, z.

This gives you understanding https://github.com/google/mediapipe/issues/2671#issuecomment-948067322


What does "gallery_satellite_usa_un" mean?

https://github.com/wtyhub/LPN/blob/00c33994aa83a46fa60f7c3bcfe8b45443956c4c/test.py#L133
请问这个是否可以无视？

Yes. You can ignore it. "gallery_satellite _usa_un" means that the satellite images of CVUSA are added to the satellite-view gallery of Univeristy1652 as distractors of geo-localization.
是的，你可以忽视。"gallery_satellite _usa_un"指的是在University1652数据集的卫星图gallery中加入cvusa的卫星图，其中，cvusa的卫星图作为地理定位检索的干扰项。

好的感谢解答


added generalApplicationParties

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-1558
Change description
added generalApplicationParties
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

https://tools.hmcts.net/jira/browse/CIV-3210 overrides these changes but code will be reused


target_node in signal is not working (prj included)

Godot version:
3.1 beta 4
OS/device including version:
win7-64
Issue description:
from
https://docs.godotengine.org/en/latest/getting_started/step_by_step/signals.html?highlight=signals
I tried to use target_node (different from "self") but seems not working.
Steps to reproduce:
set a target_node in connect different from "self" see example
Minimal reproduction project:
test_signals.zip

I will close this issue because I guessed now HOW the signals work (lifecycle) . If the documentations where better I didn't waste my and other time/space to open a issue here.  How many time people open issues just because not enough documentation?
Thank you anyway.


[FLINK-23999][table-planner] Support evaluating individual window table-valued function in planner

What is the purpose of the change
This pr aims to support evaluating individual window table-valued function in planner
Brief change log

Remove SimplifyWindowTableFunctionRules
Remove emitPerRecordfield in StreamPhysicalWindowTableFunction and StreamExecWindowTableFunction because the behavior of window table function with row semantics is unified, they emit result by per record.
Refactor  StreamExecWindowTableFunction to support proctime window

Verifying this change

UT in WindowTableFunctionTest
Harness in WindowTableFunctionHarnessTest to test process time window
IT in WindowTableFunctionITCase
Json test in WindowTableFunctionJsonPlanTest

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (docs)

@flinkbot run azure


WIP | Upgrade React and Gatsby

What's the purpose of this pull request?
This PR upgrades Gatsby and React

closing in favor of #753

@tlgimenes do you make the upgrade in PR separately? One to React and another to Gatsby?


test docs preview

This is a link to Empathy Platform Docs Portal preview in a development environment.
⚠ Only for Empathy members. We’re sorry for the inconvenience!
Check out EPDocs preview


Units alignment between DBO and UDMI

Should the list of units in the UDMI repo be aligned with the list of units in the DBO repo?

What are the valid units now?  The units file has been deleted from the repo and the DBO is a much smaller subset of what the units file contained. There also appears to be no definition of what a Null unit is in that file but there was in the old units.json file.

UDMI no longer cares about units, so it has no opinion about "valid units" -- it only matters now in relationship to DBO, so if that subset is not sufficient then it should be raised there.


Updated example PriceMarker.js

Hey! Tried to use this example today in my project, but failed because of outdated code. Do we need to update this examples to the es6 style?

Did that fix the issue for you?

Yep, but some other example use this class, so I'm not sure if they will be working as it is or we need to change them too.
https://github.com/lelandrichardson/react-native-maps/blob/master/example/examples/DraggableMarkers.js
https://github.com/lelandrichardson/react-native-maps/blob/master/example/examples/ViewsAsMarkers.js
https://github.com/lelandrichardson/react-native-maps/blob/master/example/examples/MarkerTypes.js

@AKovtunov All examples need to be updated. Do you think that's something you would be able to do?

@christopherdro I think I can work on it :) At least nobody else is trying to do it now

@AKovtunov 👍 That would be great!

@AKovtunov sorry but this didn't fixed AnimatedViews nor AnimatedMarkers also it seems there is 2 syntax errors in AnimatedView.js

PriceMarker looks good though 👍

@jrichardlai Fixing them, will ping you as soon as will do it

@AKovtunov  Any updates on updating the examples?

Thanks for this PR!
We'd like to update all the examples to use ES6 style.  I've gone through and done a big ESLint pass on the JS, so this PR currently has merge conflicts.  If you rebase, I'll merge it 👍.

@spikebrehm I've updated my branch with original master, but I've met 3 merge conflicts in files. I've returned back my code, but not sure which one is better: ESLint's one or mine.

@spikebrehm :+1:

@AKovtunov thank you for the PR. I've created PR #515 which refactors all of the JS to meet the Airbnb style guide and pass ESLint. It will supercede this PR.


drawer with hamburger menu closing immediately

On galaxy 5s and 7s when you click the hamburger menu the drawer opens and then closes immediately.
Images & references Too fast to capture.
Link to minimally-working code that reproduces the issue
https://evening-ridge-76179.herokuapp.com

Here you can find the code for the topBar.js:
https://github.com/dam4222/academy/blob/master/src/app/components/topBarNav/topBarNav.js
Versions
"material-ui": "^0.16.4",
"react": "^15.4.1",
Browser: Chrome

Hi, please material-ui for reproducible issues GitHub issues for issues with Material-UI components, rather than with your code.
For a working example, you might find inspiration by looking at the Material-UI docs site, which I tested and is fine on an S7: https://github.com/callemall/material-ui/tree/master/docs


TF Lite wants help on Andorid Between ImageClassifier and ObjectDetection

Dear Sir/Madam:
(1)I run tf-lite to recognize things ok according to
https://codelabs.developers.google.com/codelabs/tensorflow-for-poets/#0
(2)But When I want to detect Objects on camera,Only https://github.com/tensorflow/tensorflow/tree/master/tensorflow/examples/android
the first one use  private Interpreter tflite to run .lite for result,while the second one use TensorFlowInferenceInterface to build graph and feed inputs,this need to using bazel compile the whole project,a lot time need to spend
So my Question is: Can Examples like the first one for Object Detection using lighweight interpreter?
Plus tensorflow-lite is valued very import in many areas,Hope for talents helping,Thank you.

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

Dear Sir:
I have learned the newest video on Tensorflow Lite by engineer Renming Gu,Shanghai ,China,R&D develop of Google.
May I contact with him to give me some suggestions on Tensorflow Lite Examples.

@cableyang,
I'm here. I notice you are in CN region, we have active forum here.
https://www.tensorflowers.cn/
As for knowledge discussion, I would prefer you go to forum or mail list. Github issues are more for tracking feature requests, issues etc.


Fix npm build and prepublish scripts

This was done but was broken on the re-extraction

Nice catch!


have a silent install?

Please read
https://github.com/Franiac/TwitchLeecher#support--issues
before posting anything!

The question is why? Do you want to make an install script for your enterprise company using TL 😄
I don't see the usecase.

No answer -> closed


Issue with k8s.io/docs/tasks/tools/install-minikube/

This is a Bug Report

Problem: Following the minikube guide using Hyper-V on Windows, minikube start fails
C:\WINDOWS\system32>minikube start
* minikube v1.2.0 on windows (amd64)
* Downloading Minikube ISO ...
 129.33 MB / 129.33 MB [============================================] 100.00% 0s
* Creating virtualbox VM (CPUs=2, Memory=2048MB, Disk=20000MB) ...
E0701 13:28:09.084688   24924 start.go:559] StartHost: create: precreate: VBoxManage not found. Make sure VirtualBox is installed and VBoxManage is in the path

X Unable to start VM
* Error:         [VBOX_NOT_FOUND] create: precreate: VBoxManage not found. Make sure VirtualBox is installed and VBoxManage is in the path
* Advice:        Install VirtualBox, ensure that VBoxManage is executable and in path, or select an alternative value for --vm-driver
* Documentation: https://www.virtualbox.org/wiki/Downloads
* Related issues:
  - https://github.com/kubernetes/minikube/issues/3784
  - https://github.com/kubernetes/minikube/issues/3776

* If the above advice does not help, please let us know:
  - https://github.com/kubernetes/minikube/issues/new

My PC is running Windows 10 Enterprise, OS build 17763.557 (1809)
Proposed Solution:  I found another guide which got me through the installation process. I think the page should either make note of the additional steps required for Hyper-V users, or (larger change) perhaps update minikube to automatically detect/confirm the hypervisor to use.
Page to Update: https://kubernetes.io/docs/tasks/tools/install-minikube/

/priority backlog
/sig cluster-lifecycle

@connor4312 Please follow this hyperv guide: https://minikube.sigs.k8s.io/docs/reference/drivers/hyperv/


Adds .npmignore

Took the approach that dist belongs in source but not in package manager (~if it's not being used, which in this case it is not~*), but you may have diff feels on that.
If so, can just edit**  or remove L8. As is:
Before
npm notice === Tarball Details ===
npm notice name:          hashids
npm notice version:       1.2.2
npm notice package size:  19.1 kB
npm notice unpacked size: 94.8 kB
npm notice shasum:        8c2b36a4559430c90e466b3b7519f3c2862909d6
npm notice integrity:     sha512-jp+XlsrjkdcEm[...]drOEUTA5qUTsQ==
npm notice total files:   13

After
npm notice === Tarball Details ===
npm notice name:          hashids
npm notice version:       1.2.2
npm notice package size:  7.5 kB
npm notice unpacked size: 20.6 kB
npm notice shasum:        9160e6576f8f8121bb9f9f82d3435b99ee21717a
npm notice integrity:     sha512-65lWfP6p8Yopr[...]rOFokk++h2Dww==
npm notice total files:   5

*Update: that was wrong, it is! (Just not by my use case.)
**Suggest at least consider npmignoring .maps

@ryanblock Is it something you'd have to adjust in .travis.yml?

Apologies, I misread something in the code – turns out deps were just stale and needed to be updated. Should be cleared for takeoff!

Cool, thanks. What if devs install with npm and link directly to dist/hashids.min.js on frontend or backend - would that not work anymore?

Will respond further asap, but please don't merge yet! Sorry for the rollercoaster here.

Sorry, took me a few days to get back to this! Thanks for not merging immediately, I did not look closely enough at how this was configured and not including dist/ in the npm package would probably have broken things for someone. 😅
npmignore now only excludes non dist/ and lib/ files, so it should be good to merge. It's a marginal improvement (but an improvement all the same!), and brings us back to the original question of the intention of dist/.
There are a lot of build artifacts being transpiled for distribution across a variety of use cases, and perhaps not all are necessary. (Whether that's definitely the case I do not know, more on that in a second.) That said, I'd like to think that for those kinds of artifacts (and for conveniences like source maps) folks could acquire them periodically from the git repo instead of via npm.
But I'm also willing to accept that perhaps that's an over-optimization that sacrifices this project's versatility (and conclude that perhaps I should just maintain a fork).
Perhaps you can lend some knowledge of the feedback you've received on your project with regards to how people use it (browser vs server side, etc.) that could guide that kind of decision?
Either way, we've made a bit of an improvement in npm hygiene here, so yay! 🌈

Thanks @ryanblock. Don't have that much feedback into how/where people use it, but any improvement is appreciated.
Did a bit more reading on .npmignore, like this and this. Any benefits to using files in package.json over this?

Either is fine! I prefer .npmignore in this case because the project is stable and not undergoing much change (which is a Good Thing), so we don't have to be too concerned about ensuring newly created files don't leak into the project.
I get the argument in favor of files over .npmignore, but I think in a project like that's stabilized, the safety of specifying the files to include (as opposed to specifying the files to exclude) isn't of much benefit.
It also means that if your build artifacts change at all in the future, you have to remember to add them to files. That blog post is a bit outdated and a little overdramatic IMO, but both approaches work!

👋🏻


[explorer] fix validator getName error when name is not a b64 encoded string

noticed an error when developing locally:

closing this - looks like there's a fix in https://github.com/MystenLabs/sui/pull/7403


What is the Pricing logic for Geo Queries?

Let's say I have 100,000 locations saved in the DB. And I make a radius query which returns 5 locations. Will I be charged for 100,000 document reads or 5? In the background do we download the unused results too?
Also while listening to a query result in real time, If a location changes which is out of bounds of my query, does that still count as a read?

@aytunch this question has a few answers:

This library is only for Realtime Database, not Cloud Firestore, so you're not charged per document read.  You're charged for network traffic and storage.
GeoFire uses the Geohash system to index locations.  So it's not possible for me to say exactly, but the answer is much closer to 5 than 100,000.  We   do as much server-side filtering as possible using the GeoHash and then do the final filtering on the client.
For real-time results the answer is the same.  If something far away changes that won't affect your query.  If something nearby changes it could fall within the geohash accuracy window even if it's not a true match.


M3-3563 image events

Description
Phase 2 of getting progress bars displayed when creating an Image. This adds a progress event to images on Images Landing. Next up is adding create/update image requests to Redux.
Type of Change

Non breaking change ('update', 'change')

Note to Reviewers
Create an image, then reload the page. Look in devtools and you should see an event with a secondary entity attached to the currently-being-created Image.

Unrelated: this button does not pre-fill the create flow with the image:


St2client py27

This fixes the shebang on the st2 CLI for systems that use something other than Python 2.7 as the system Python version.

consistency ftw. let's hope nothing breaks. lgtm. :ship:


What is the typical worflow for usage

Hi Everyone,
Sorry if this is really obvious but i was wondering if someone can please explain what the typical workflow for this module should be? for instance

Should all the installed mobile apps start scanning on the first screen based on a setInterval? The example app allows the user to initiate the scanning but that is just one use case.
Should it scan and then advertise? and then repeat?
When app is in the background what is the process to handle scanning?

My use case is for health contact tracing and i was just wondering how to setup using best practice.

Hi,
I would like to second this question. I tried to create a sample app (below). I tried to write the minimal thing that wouldn't result in exceptions and might work. Unfortunately, when I load my code on two devices, neither device picks up on the presence of the other device. There are no exceptions from this code initially, but after a few minutes, the app crashes for no apparent reason.
import React, { useState, useEffect } from "react";
import { Text } from "react-native";
import SpecialBle, { requestLocationPermission, checktLocationPermission } from "rn-contact-tracing";

const SERVICE_UUID = "00000000-0000-1000-8000-00805F9B34FB";

/*
const ScanMatchMode = [
    {value: 1, label: 'MATCH_MODE_AGGRESSIVE'},
    {value: 2, label: 'SCAN_MODE_LOW_LATENCY'},
];

const AdvertiseMode = [
    {value: 0, label: 'ADVERTISE_MODE_LOW_POWER'},
    {value: 1, label: 'ADVERTISE_MODE_BALANCED'},
    {value: 2, label: 'ADVERTISE_MODE_LOW_LATENCY'},
];

const AdvertiseTXPower = [
    {value: 0, label: 'ADVERTISE_TX_POWER_ULTRA_LOW'},
    {value: 1, label: 'ADVERTISE_TX_POWER_LOW'},
    {value: 2, label: 'ADVERTISE_TX_POWER_MEDIUM'},
    {value: 3, label: 'ADVERTISE_TX_POWER_HIGH'},
];
*/

const BluetoothScreen = () => {
    const [permissions, setPermissions] = useState({location: false, ignoreBatteryOpt: false});
    const [config, setConfig] = useState({
        serviceUUID: SERVICE_UUID,
        scanDuration: 10000,
        scanInterval: 10000,
        advertiseInterval: 10000,
        advertiseDuration: 10000,
        scanMatchMode: 1,
        advertiseMode: 2,
        advertiseTXPowerLevel: 1,
        notificationTitle: "Bluetooth",
        notificationContent: "Bluetooth",
        notificationLargeIconPath: "",
        notificationSmallIconPath: "",
        token: "default_token"
    });

    async function checkPermissions() {
        let isGranted = await checktLocationPermission();
        let ignoreBatteryOpt = await SpecialBle.isBatteryOptimizationDeactivated();
        setPermissions({...permissions, ...{location: isGranted, ignoreBatteryOpt: ignoreBatteryOpt}});
    }

    useEffect(() => {
        (async () => {
            console.log("module:", SpecialBle);

            console.log("permissions");
            await checkPermissions();

            console.log("database");
            await SpecialBle.writeContactsToDB(null);

            console.log("set config");
            await SpecialBle.setConfig(config);

            console.log("start ble service");
            await SpecialBle.startBLEService();

            console.log("advertise");
            await SpecialBle.advertise();

            console.log("start scan");
            await SpecialBle.startBLEScan();

            console.log("get all devices");
            await SpecialBle.getAllDevices(devices => {
                console.log(devices);
            });
        })();
    }, []);

    return (<Text>Bluetooth</Text>);
};

export default BluetoothScreen;

 LOG  module: {"advertise": [Function fn], "cleanDevicesDB": [Function fn], "cleanScansDB": [Function fn], "deleteDatabase": [Function fn], "exportAdvertiseAsCSV": [Function fn], "exportAllContactsAsCsv": [Function fn], "exportAllDevicesCsv": [Function fn], "exportAllScansCsv": [Function fn], "exportScansByKeyAsCSV": [Function fn], "exportScansDataAsCSV": [Function fn], "fetchInfectionDataByConsent": [Function fn], "getAllDevices": [Function fn], "getAllScans": [Function fn], "getConfig": [Function fn], "getConstants": [Function anonymous], "getScansByKey": [Function fn], "isBatteryOptimizationDeactivated": [Function fn], "match": [Function fn], "requestToDisableBatteryOptimization": [Function fn], "setConfig": [Function fn], "setPublicKeys": [Function fn], "startBLEScan": [Function fn], "startBLEService": [Function fn], "stopAdvertise": [Function fn], "stopBLEScan": [Function fn], "stopBLEService": [Function fn], "writeContactsToDB": [Function fn]}
 LOG  permissions
 LOG  database
 LOG  set config
 LOG  start ble service
 LOG  advertise
 LOG  start scan
 LOG  get all devices
 LOG  null

Someone who can answer?
Did you know how to implement it?

@jabzum just to say I'm checking and will make sure this thread gets an answer.

Hi @kaplanlior Do you have the workflow of how to use this plugin and what is the scope for the community?


use property descriptors for .localDescription and .remoteDescription

to make this overridable in rtcpeerconnection-jingle

Codecov Report

Merging #141 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage    99.8%   99.82%   +0.01%
==========================================
  Files           8        8
  Lines        1030     1139     +109
==========================================
+ Hits         1028     1137     +109
  Misses          2        2

Impacted Files
Coverage Δ

rtcpeerconnection.js
99.76% <100%> (+0.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 340c349...68b3344. Read the comment docs.

backporting to 1.2.11 and publishing a bugfix version

this should probably also be done for some other properties:
    this.canTrickleIceCandidates = null;
    this.signalingState = 'stable';
    this.iceConnectionState = 'new';
    this.connectionState = 'new';
    this.iceGatheringState = 'new';

and also currentLocalDescription and friends.


Lint command in generator does not lint /storybook directory

After installing, the generator runs the vue cli lint service. However, it only lint the default vue directories, /src and /tests, it does not lint /storybook.
I'm currently trying to solve this problem for my own unrelated CLI plugin, so I'm very interesting to see any ideas. If I come up with anything I will comment here as well.
https://github.com/vuejs/vue-cli/blob/dev/packages/%40vue/cli-plugin-eslint/lint.js#L39

yeah the lint command is a pretty naive impl on vue's side and they never react to PRs in time. i wanted to change the way it detects what to lint, like default tslint does, but they never reply to issues or accept PRs, so whatever


Fix broken bookmark+saved simulation links.

@magopian what started as a tiny refactor for modularizing saved simulation kinks view stuff eventually highlighted a bug we currently have in production, preventing saved links and bookmarks to work at all. So the fix is actually in commit https://github.com/MTES-MCT/wikicarbone/pull/110/commits/845cb410e45fc6ace55997e8bc5289248a3bc16a but I thought a while PR with the view modularization plus the fix was nice to have and made sense as a whole. Thanks.

Self-reviewed the patch a dozen times now, I'm landing this.


[chaos mode] Choose a random e-node from the e-class rather than the best one

This is what wasm-mutate does to generate pseudo-random semantics-preserving Wasm programs from an input Wasm module. We could also do it in our own mid end to exercise the back half of the compiler pipeline.

          I was talking with @jacarte the other day as well and he had a similar idea: do the `wasm-mutate` e-graphs thing (select a random e-node from the e-class rather than the best e-node). I guess this would also fit in with the chaos mode work.

Originally posted by @fitzgen in https://github.com/bytecodealliance/wasmtime/issues/5967#issuecomment-1464716718

Related to #4134

(Commenting here the same I wrote in the issue)
The concept of "semantically equivalent" is actually subjective. The rewriting rule can be anything that changes the final code. In a potential real chaos mode, you can add whatever transformation rule, for example, x => x + 1.

@Jacarte I may be missing some context here to interpret your suggestion, but in the context we are imagining in the chaos-mode test infrastructure, we do actually need semantics-preserving transforms only. The idea is that every compilation with arbitrary chaos-mode choices is still a valid compilation. Unless we pair e.g. x -> x + 1 with equivalent updates of uses of x everywhere (x' - 1) then we've broken the input program. Perhaps you're thinking in a purely generative context (creating new, arbitrary programs) rather than a transforming/optimizing context?

@Jacarte I may be missing some context here to interpret your suggestion, but in the context we are imagining in the chaos-mode test infrastructure, we do actually need semantics-preserving transforms only.

I agree, it was just a suggestion on disabling the semantic-aware restriction 😄

The idea is that every compilation with arbitrary chaos-mode choices is still a valid compilation. Unless we pair e.g. x -> x + 1 with equivalent updates of uses of x everywhere (x' - 1) then we've broken the input program. Perhaps you're thinking in a purely generative context (creating new, arbitrary programs) rather than a transforming/optimizing context?

Yeah, that was the case, sorry for the missunderstanding.


Java SDK instructions are missing

What happened?
This package is missing the instructions for Java SDK installation, both in the README here and in the Install and Config page in the Pulumi Registry.
Example
n/a
Output of pulumi about
n/a
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Suggest doing an audit of all of our packages, since it's likely others have the same issue. This issue came to me via someone in the Pulumi Community Slack who assumed no Java SDK existed.

I added links to install pages for all packages in https://github.com/pulumi/registry/pull/3568
None of our providers mention how to install Java SDKs in their READMEs... I had a quick look and found no obvious command to include there, actually. I'll resolve this issue as fixed, since linode and other small packages are now on-par with the "big guys". If we want to improve READMEs, let's open a separate enhancement (maybe in /home).


Change design of meetup problem

@pminten brought up a very good point about the API of meetup being
pretty terrible (See exercism/exercism.io#950).
If the meetup problem has not already been fixed in this track, we should
improve the test suite and example code to give the API a better design.

@kytrinyx close?

:+1: https://github.com/exercism/exercism.io/issues/956


Added ICCF numeric notation

Added ICCF numeric notation which is the official chess game notation for all International Correspondence Chess Federation games.

thanks!


Full use of mamba in Github Actions source install test and use generic Python 3.7 (removing the very specific 3.7.10)

Description

This PR does two things:

experimental full use of mamba in the source install test
and revert to the more general Python 3.7 (instead of the specific 3.7.10)

I will generalize the full use of mamba to all the other tests once we've agreed fully that mamba's the way forward, for now it is used in a very user-centric test, the installation from source, and I'll look at this over a period of time, if it works fine then we're all in mamba business :snake:
The source install test is super fast with mamba: Python 3.8 env done in 7min compared to 27min with conda and 3.9 is much faster too, see the conda test

Before you get started

Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🛠 This pull request has a descriptive title
[x] 🛠 Tests run successfully
[x] 🛠 All checks below this pull request were successful

@zklaus it would be nice if we plugged this in 2.4 so we can have GA tests fully mambafied :snake:

sounds good, mi amigo! I removed them and even changed test titles to match what we have in Core (more human -readable) :beer: