Prop type checks don't work for components using kebab-case

Problem
simply put volar/ts doesn't complain about this when the component is defined using kebab-case:

but when using PascalCase it does complain about this (as it should)

Expected Behaviour
the prop required is of type boolean | undefined so I expect to see a squiggly line in both cases

Is this a bug in Volar or is something wrong with my config?

I have the same problem. Using camelCase for the properties of a component will not prompt an error, but there will be a problem with using kebab-case.
Change to camelCase and you will prompt Attribute': varName' must be hyphenated.eslintvue/attribute-hyphenation.
This problem will not occur until you upgrade to version 1.0. It is normal to return the old version.

I can't reproduce this problem, could you provide repro case?

I've run into something similar:

If the tag for the component in the template is not exactly the same as a component defined in the components field of defineComponent options, it will give a type of unknown when hovering on it. An incorrect prop type will not be highlighted.

If it is the same, it will show the proper type and give a proper warning when the prop type does not match.
A couple of examples below using badge and Badge.

Using the example from the top post, if we import DateRangePicker and define the component as DateRangePicker in defineComponent, then it must be used as <DateRangePicker> in the template for proper type information. We can also define it as 'date-range-picker': DateRangePicker in the components field to allow us to use <date-range-picker>

I reverted my version of volar to 0.40.13, where I do not run into this issue. I tried 1.0.0, 1.0.5, and 1.0.7 and ran into the issue.

I tried in https://github.com/johnsoncodehk/volar-starter but can't reproduce, if you have repro case please provide and I will reopen this issue.

@johnsoncodehk Maybe it's not a bug but some wrong configuration. In other projects it works just fine, given that it's a big production project I can't tell exactly why it's happening. I was wondering if there is anything setting or config that can cause such behaviour that you are aware of. If not i'll try to detect a pattern and report here

@fanckush Can you try these screenshots?

Hover <date-range-picker>
Hover <DateRangePicker>
Right click <date-range-picker> -> Peek Definition
Right click <DateRangePicker> -> Peek Definition

And please provide your vue version and vueCompilerOptions setting.
Also helpful if @saifahn can fill these information.


💖 Auto follow PR authors

Use a nice action to automatically follow people when they submit a pull request.
This is a scripted PR sorry the flooding.

Waiting for #114 which restores the build.

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Question: Getting the prototype of the caller of "super"?

I'm writing a binding generator for C++ <-> ChakraCore. Right now, I'm struggling to support extending native classes from JS-defined classes like so:
class JavascriptChildClass extends NativeSuperClass {
  constructor() {
    super();
  }

  TestChildMethod() {
    console.log("Oops!");
  }
}

However, when I return the object generated from NativeSuperClass's native constructor, I have to call JsSetPrototype on it in order to properly bind the native class to its JS prototype.
I'd like to attach the prototype of "JavascriptChildClass" instead. Right now, I can't find any way to do that, and so the methods on the child class are lost, i.e., TestChildMethod can't be called.
I can't figure out any way to get JavascriptChildClass's prototype from a native context in order to properly set it when "super" is called. It doesn't seem to be, "callee.prototype", "callee.__proto__", or "arguments[0].__proto__", or anything returned from JsGetPrototype on either callee or arguments[0].
Any ideas? Am I doing this completely incorrectly?

I managed to figure this out.
The "arguments[0]" object (this) passed in is actually the function that represents the class (JavascriptChildClass constructor in this case, somewhat unintuitively, but maybe only because I'm not super experienced with Javascript), so the "prototype" property on arguments[0] ("this" object) is what I'm looking for here.
Closing and hopefully this knowledge might help someone else in the future :)


Update dependency list

When trying to make newest version of fluxengine I get an error stating
/bin/sh: 1 wx-config: not found
Makefile: 49: *** You must have these wx-config installed. Stop.
Looking this up in Google eventually told me to install libwxgtk3.0-gtk3-dev and libwxgtk3.0-gtk3-0v5
Attempting to install these lead to more errors mostly involving libmount1:i386 not being configured
I am assuming this mess is all related to the new gui

Curses. Yes, it is --- I forgot to update the README. Will fix.


No available version compatible with the installed Atom version: 0.209.0

No available version compatible with the installed Atom version: 0.209.0

Sorry for late response, thanks for report this issue, i'll fix this.


Remove incremental (intra-datum) feature from 1.8 docs.

The incremental (intra-datum) feature has been removed for 1.8. We chose to remove this feature because it was convoluted, not used often, and did not work well with our performance improvements. The mentions of this feature need to either be removed from the docs or marked as deprecated. We will re-visit this feature in the future if there is enough demand for it, or we come up with a more elegant design.
┆Issue is synchronized with this Asana task

Completed


fail to build Observable extenion method on RxSwift

Description
in Xcode 15 beta 6,RxSwiftExt Package is starting to fail building. It turns out that specific method declaration extension is problematic.
Steps to reproduce

I made a simple example to reproduce. or you can try to build RxSwiftExt Package.
import RxSwift

extension Observable {
    func test() -> Observable<Bool> {
        // error: Cannot convert return expression of type 'Observable<Element>' to return type 'Observable<Bool>'
        // error: Cannot specialize non-generic type 'Observable<Element>'
        return Observable<Bool>.empty()
    }
}

but this two code is passing without error.
// fully unqualified
extension Observable {
    func test() -> Observable<Bool> {
        return .empty()
    }
}

// fully qualified
extension Observable {
    func test() -> Observable<Bool> {
        return RxSwift.Observable<Bool>.empty()
    }
}

Expected behavior

build success without error

Environment

Swift compiler version info

swift-driver version: 1.87.1 Apple Swift version 5.9 (swiftlang-<IP_ADDRESS>.2 clang-15<IP_ADDRESS>)
Target: arm64-apple-macosx13.0

Xcode version info

Xcode 15.0
Build version 15A5219j

Deployment target: N/A

FYI this is a regression from Xcode 15 Beta 5 where this worked with no issues

CC: @xedin

I was just having this problem too. Thanks for creating this issue!

I will follow this, just jumped into this issue too

Still an issue in Beta 7

Any chance we could get some clarity about this by anyone from the Core Team? The release date is right around the corner and this was already fixed and then regressed during the beta itself. @DougGregor

Still an issue in Xcode 15 Beta 8

This is just unbelievable :(
The bug is one thing but the silence around this is really baffling.

I believe this is a constraint system bug that was introduced by https://github.com/apple/swift/pull/66657, and this bug manifested with RxSwift when Foundation started exporting Observation library in Xcode 15 Beta 6. The bug is specific to writing an explicitly specialized Observable<X> in expressions in a situation where the constraint system has to perform overload resolution in order to determine what the type refers to (e.g. because there's an import Foundation that also surfaces an Observable declaration), which is why explicitly specifying RxSwift.Observable<X>.empty works around the problem. Regular type annotations should be unaffected, which is why removing Observable<X> from the expression and using the leading dot syntax works around the issue. Removing the specialization may also workaround the problem, though I have not attempted that yet to confirm whether or not it works.
@xedin is working on a fix.

Thank you so much for addressing this! I hope #68254 will bring us over this :)

If you'd like you can test with https://ci.swift.org/job/swift-PR-toolchain-macos/850/artifact/branch-main/swift-PR-68254-850-osx.tar.gz

If you'd like you can test with https://ci.swift.org/job/swift-PR-toolchain-macos/850/artifact/branch-main/swift-PR-68254-850-osx.tar.gz

Thanks Pavel!
I tried testing it but I'm getting build failures from a seemingly-unrelated SDK. Could the custom toolchain be the reason?

I'll try isolating the issue to a separate project but it would be nice to get our large project building as it would give high confidence the fix is good :)

I've removed the Sentry SDK but now bumping into a different build issue, I'm just not 100% sure if it's just a side-effect of using a custom toolchain or there's something wrong.
Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the crash backtrace.
Stack dump:
0.		Apple Swift version 5.9-dev (LLVM f102d9d4700e9d3, Swift 830b15e058bf31f)
2.	Compiling with the current language version
3.	While walking into body of 'confirmationDialog(store:state:action:)' (at /Users/shaimi/Work/Monday/App/Tuist/Dependencies/SwiftPackageManager/.build/checkouts/swift-composable-architecture/Sources/ComposableArchitecture/SwiftUI/ConfirmationDialog.swift:29:10)
4.	While verifying closure expression at [/Users/shaimi/Work/Monday/App/Tuist/Dependencies/SwiftPackageManager/.build/checkouts/swift-composable-architecture/Sources/ComposableArchitecture/SwiftUI/ConfirmationDialog.swift:36:7 - line:66:5] RangeText="{ `self`, $isPresented, destination in
      let confirmationDialogState = store.state.value.wrappedValue.flatMap(toDestinationState)
      self.confirmationDialog(
        (confirmationDialogState?.title).map(Text.init) ?? Text(""),
        isPresented: $isPresented,
        titleVisibility: (confirmationDialogState?.titleVisibility).map(Visibility.init)
          ?? .automatic,
        presenting: confirmationDialogState,
        actions: { confirmationDialogState in
          ForEach(confirmationDialogState.buttons) { button in
            Button(role: button.role.map(ButtonRole.init)) {
              switch button.action.type {
              case let .send(action):
                if let action = action {
                  store.send(.presented(fromDestinationAction(action)))
                }
              case let .animatedSend(action, animation):
                if let action = action {
                  store.send(.presented(fromDestinationAction(action)), animation: animation)
                }
              }
            } label: {
              Text(button.label)
            }
          }
        },
        message: {
          $0.message.map(Text.init)
        }
      )
    "
5.	While evaluating request LocalDiscriminatorsRequest(0x121a6f020 AbstractClosureExpr line=36 : (Self, Binding<Bool>, DestinationContent<ConfirmationDialogState<ButtonAction>, ButtonAction>) -> some View)
6.	While evaluating request LocalDiscriminatorsRequest(0x120875650 AbstractFunctionDecl name=confirmationDialog(store:state:action:) : <Self, State, Action, ButtonAction where Self : View> (Self) -> (Store<PresentationState<State>, PresentationAction<Action>>, @escaping (State) -> ConfirmationDialogState<ButtonAction>?, @escaping (ButtonAction) -> Action) -> some View)
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
0  swift-frontend           0x0000000107cc315c llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 56
1  swift-frontend           0x0000000107cc2500 llvm::sys::RunSignalHandlers() + 112
2  swift-frontend           0x0000000107cc379c SignalHandler(int) + 304
3  libsystem_platform.dylib 0x000000018a019a24 _sigtramp + 56
4  libsystem_pthread.dylib  0x0000000189feacc0 pthread_kill + 288
5  libsystem_c.dylib        0x0000000189efaa80 abort + 180
6  libsystem_c.dylib        0x0000000189ef9d9c err + 0
7  swift-frontend           0x00000001081692c4 swift::ValueDecl::setLocalDiscriminator(unsigned int) (.cold.2) + 0
8  swift-frontend           0x00000001042b5b44 swift::ValueDecl::getOverriddenDecl() const + 0
9  swift-frontend           0x0000000103fd2348 (anonymous namespace)::SetLocalDiscriminators::setLocalDiscriminator(swift::ValueDecl*) + 776
10 swift-frontend           0x0000000103fd6f08 (anonymous namespace)::SetLocalDiscriminators::walkToExprPre(swift::Expr*) + 360
11 swift-frontend           0x0000000104258eac (anonymous namespace)::Traversal::doIt(swift::Expr*) + 40
12 swift-frontend           0x00000001042598b4 swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Expr*) + 144
13 swift-frontend           0x0000000104258f00 (anonymous namespace)::Traversal::doIt(swift::Expr*) + 124
14 swift-frontend           0x000000010425a818 swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Stmt*) + 400
15 swift-frontend           0x000000010425902c (anonymous namespace)::Traversal::doIt(swift::Stmt*) + 124
16 swift-frontend           0x000000010425a7f0 swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Stmt*) + 360
17 swift-frontend           0x000000010425902c (anonymous namespace)::Traversal::doIt(swift::Stmt*) + 124
18 swift-frontend           0x0000000104258fa4 swift::Stmt::walk(swift::ASTWalker&) + 32
19 swift-frontend           0x0000000103fd6e40 (anonymous namespace)::SetLocalDiscriminators::walkToExprPre(swift::Expr*) + 160
20 swift-frontend           0x0000000104258eac (anonymous namespace)::Traversal::doIt(swift::Expr*) + 40
21 swift-frontend           0x000000010425d178 (anonymous namespace)::Traversal::visit(swift::ArgumentList*) + 220
22 swift-frontend           0x00000001042597a0 (anonymous namespace)::Traversal::doIt(swift::ArgumentList*) + 100
23 swift-frontend           0x00000001042598c8 swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Expr*) + 164
24 swift-frontend           0x0000000104258f00 (anonymous namespace)::Traversal::doIt(swift::Expr*) + 124
25 swift-frontend           0x0000000104259880 swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Expr*) + 92
26 swift-frontend           0x0000000104258f00 (anonymous namespace)::Traversal::doIt(swift::Expr*) + 124
27 swift-frontend           0x000000010425a818 swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Stmt*) + 400
28 swift-frontend           0x000000010425902c (anonymous namespace)::Traversal::doIt(swift::Stmt*) + 124
29 swift-frontend           0x000000010425a7f0 swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Stmt*) + 360
30 swift-frontend           0x000000010425902c (anonymous namespace)::Traversal::doIt(swift::Stmt*) + 124
31 swift-frontend           0x0000000104258fa4 swift::Stmt::walk(swift::ASTWalker&) + 32
32 swift-frontend           0x0000000103fd1e50 swift::LocalDiscriminatorsRequest::evaluate(swift::Evaluator&, swift::DeclContext*) const + 1004
33 swift-frontend           0x00000001042fdee4 llvm::Expected<swift::LocalDiscriminatorsRequest::OutputType> swift::Evaluator::getResultUncached<swift::LocalDiscriminatorsRequest>(swift::LocalDiscriminatorsRequest const&) + 376
34 swift-frontend           0x00000001042fdbec llvm::Expected<swift::LocalDiscriminatorsRequest::OutputType> swift::Evaluator::getResultCached<swift::LocalDiscriminatorsRequest, (void*)0>(swift::LocalDiscriminatorsRequest const&) + 384
35 swift-frontend           0x00000001042b5a0c swift::LocalDiscriminatorsRequest::OutputType swift::evaluateOrDefault<swift::LocalDiscriminatorsRequest>(swift::Evaluator&, swift::LocalDiscriminatorsRequest, swift::LocalDiscriminatorsRequest::OutputType) + 52
36 swift-frontend           0x00000001042fdee4 llvm::Expected<swift::LocalDiscriminatorsRequest::OutputType> swift::Evaluator::getResultUncached<swift::LocalDiscriminatorsRequest>(swift::LocalDiscriminatorsRequest const&) + 376
37 swift-frontend           0x00000001042fdbec llvm::Expected<swift::LocalDiscriminatorsRequest::OutputType> swift::Evaluator::getResultCached<swift::LocalDiscriminatorsRequest, (void*)0>(swift::LocalDiscriminatorsRequest const&) + 384
38 swift-frontend           0x00000001042b5a0c swift::LocalDiscriminatorsRequest::OutputType swift::evaluateOrDefault<swift::LocalDiscriminatorsRequest>(swift::Evaluator&, swift::LocalDiscriminatorsRequest, swift::LocalDiscriminatorsRequest::OutputType) + 52
39 swift-frontend           0x00000001043e9a28 swift::AbstractClosureExpr::getDiscriminator() const + 72
40 swift-frontend           0x00000001042550cc (anonymous namespace)::Verifier::verifyChecked(swift::AbstractClosureExpr*) + 412
41 swift-frontend           0x000000010424caa8 (anonymous namespace)::Verifier::walkToExprPost(swift::Expr*) + 20960
42 swift-frontend           0x0000000104258f24 (anonymous namespace)::Traversal::doIt(swift::Expr*) + 160
43 swift-frontend           0x00000001042598b4 swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Expr*) + 144
44 swift-frontend           0x0000000104258f00 (anonymous namespace)::Traversal::doIt(swift::Expr*) + 124
45 swift-frontend           0x00000001042599ac swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Expr*) + 392
46 swift-frontend           0x0000000104258f00 (anonymous namespace)::Traversal::doIt(swift::Expr*) + 124
47 swift-frontend           0x000000010425d178 (anonymous namespace)::Traversal::visit(swift::ArgumentList*) + 220
48 swift-frontend           0x00000001042597a0 (anonymous namespace)::Traversal::doIt(swift::ArgumentList*) + 100
49 swift-frontend           0x00000001042598c8 swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Expr*) + 164
50 swift-frontend           0x0000000104258f00 (anonymous namespace)::Traversal::doIt(swift::Expr*) + 124
51 swift-frontend           0x0000000104259880 swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Expr*) + 92
52 swift-frontend           0x0000000104258f00 (anonymous namespace)::Traversal::doIt(swift::Expr*) + 124
53 swift-frontend           0x000000010425a818 swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Stmt*) + 400
54 swift-frontend           0x000000010425902c (anonymous namespace)::Traversal::doIt(swift::Stmt*) + 124
55 swift-frontend           0x000000010425a7f0 swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Stmt*) + 360
56 swift-frontend           0x000000010425902c (anonymous namespace)::Traversal::doIt(swift::Stmt*) + 124
57 swift-frontend           0x000000010425cf08 (anonymous namespace)::Traversal::visitAbstractFunctionDecl(swift::AbstractFunctionDecl*) + 628
58 swift-frontend           0x00000001042595f8 (anonymous namespace)::Traversal::doIt(swift::Decl*) + 320
59 swift-frontend           0x000000010425bfe4 swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Decl*) + 2448
60 swift-frontend           0x00000001042595f8 (anonymous namespace)::Traversal::doIt(swift::Decl*) + 320
61 swift-frontend           0x00000001042594ac swift::Decl::walk(swift::ASTWalker&) + 32
62 swift-frontend           0x0000000104429d78 swift::SourceFile::walk(swift::ASTWalker&) + 248
63 swift-frontend           0x0000000104246664 swift::verify(swift::SourceFile&) + 96
64 swift-frontend           0x0000000104547464 swift::TypeCheckSourceFileRequest::cacheResult(std::__1::tuple<>) const + 76
65 swift-frontend           0x0000000104010028 llvm::Expected<swift::TypeCheckSourceFileRequest::OutputType> swift::Evaluator::getResultCached<swift::TypeCheckSourceFileRequest, (void*)0>(swift::TypeCheckSourceFileRequest const&) + 120
66 swift-frontend           0x000000010400dd6c swift::TypeCheckSourceFileRequest::OutputType swift::evaluateOrDefault<swift::TypeCheckSourceFileRequest>(swift::Evaluator&, swift::TypeCheckSourceFileRequest, swift::TypeCheckSourceFileRequest::OutputType) + 44
67 swift-frontend           0x000000010307b1e0 bool llvm::function_ref<bool (swift::SourceFile&)>::callback_fn<swift::CompilerInstance::performSema()::$_7>(long, swift::SourceFile&) + 16
68 swift-frontend           0x00000001030751c4 swift::CompilerInstance::forEachFileToTypeCheck(llvm::function_ref<bool (swift::SourceFile&)>) + 76
69 swift-frontend           0x0000000103075158 swift::CompilerInstance::performSema() + 92
70 swift-frontend           0x0000000102ecf174 withSemanticAnalysis(swift::CompilerInstance&, swift::FrontendObserver*, llvm::function_ref<bool (swift::CompilerInstance&)>, bool) + 60
71 swift-frontend           0x0000000102ec29b4 performCompile(swift::CompilerInstance&, int&, swift::FrontendObserver*) + 740
72 swift-frontend           0x0000000102ec1938 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 2496
73 swift-frontend           0x0000000102cf9984 swift::mainEntry(int, char const**) + 2144
74 dyld                     0x0000000189c71058 start + 2224
Command SwiftCompile failed with a nonzero exit code

Command SwiftCompile failed with a nonzero exit code

I think this is worse opening is a separate issue, might be a bug on main that is only reproducible in assert builds. I am going to build a 5.9 toolchain, let’s see if it’s reproducible there as well.

Ok, ping me when you have a 5.9 toolchain and I'll try again 🙏 thank you!
Where should I open another bug? In this repo? FB?

Either FB or github issue works, I will post a toolchain link here.

https://ci.swift.org/job/swift-PR-toolchain-macos/852/artifact/branch-release/5.9/swift-PR-68288-852-osx.tar.gz

I'm getting relatively sporadic build failures (i.e. in different files every time)
Seeing something like:
Assertion failed: (getRawDiscriminator() != InvalidDiscriminator), function getDiscriminator, file Expr.cpp, line 1922.
Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the crash backtrace.
Assertion failed: (getRawDiscriminator() != InvalidDiscriminator), function getDiscriminator, file Expr.cpp, line 1922.

I thought this is a non-assertion build? Do I have the right one?

All of our toolchain builds have assertions enabled, I am not sure what is going on because I managed to build 6.1.0 tag of the project locally with main and my changes.

Maybe Xcode is not picking up a toolchain correctly in SwiftPM projects. Could you try using swift build directly?

@xedin FYI this is still an issue in RC1

Check RxSwiftExt v6.1.0 (In 6.2.0 I added a typealias which helps but it's just a workaround and not a fix)

Unfortunately, that is expected. The fix for this issue was only merged to release/5.9, not release/5.9.0. It was too late to land an overload resolution change in 5.9.0.

The release/5.9 branch corresponds to potential point releases of Swift 5.9. The fix is not in Swift 5.9.0.

The release/5.9 branch corresponds to potential point releases of Swift 5.9. The fix is not in Swift 5.9.0.

Thank you:)
Sorry to go over my last question again but I truly don't understand the semantics🥲
Will a point release of 5.9.1 necessarily only come in the 15.1 version of Xcode itself? Or is there no way to tell?
Thanks for the patience and pardon my ignorance on the topic :)

I can only speak to Swift compiler versions. I cannot comment on Xcode releases.

In my case, after updating RxSwiftExt to 6.2.1 the issue was gone

Yup, we added a workaround, but it would be nice if the breakage wouldn't be happened from the get go
Would be interesting to test after the next public release of Swift

RxSwiftExt has added a workaround but RxRealm is not working unfortunately, so now we are waiting for the next release, until that xcode 14 it is :D


Cannot reproduce the results of  speedup

I implemented a script to test the acceleration by myself and tested it on 3090GPU, but it could not achieve the acceleration effect of Table 4 in the paper.
import torch, tomesd, random, time
import numpy as np
from diffusers import StableDiffusionPipeline, DDIMScheduler, PNDMScheduler

def seed_everything(seed):
    torch.manual_seed(seed)
    torch.cuda.manual_seed(seed)
    random.seed(seed)
    np.random.seed(seed)

seed = 2024
seed_everything(seed)
batch_size = 1
num_inference_steps = 50
pipe = StableDiffusionPipeline.from_pretrained("runwayml/stable-diffusion-v1-5", torch_dtype=torch.float16).to("cuda")
# pipe.scheduler = DDIMScheduler.from_config(pipe.scheduler.config)
pipe.scheduler = PNDMScheduler.from_config(pipe.scheduler.config)

prompt = "a photo of an astronaut riding a horse on mars"
generator = torch.Generator().manual_seed(seed)

# warmup gpu for testing time
print('Warm up of the gpu')
for i in range(2):
    image = pipe([prompt] * batch_size, num_inference_steps=num_inference_steps)
#-------------------

# origin pipeline
start_time = time.time()
image = pipe([prompt] * batch_size, num_inference_steps=num_inference_steps, generator=generator).images[0]
end_time = time.time()
print("Origin Pipeline: {:.3f} seconds".format(end_time-start_time))
image.save("results/orgin.png")

# Apply ToMe with a 50% merging ratio
generator = torch.Generator().manual_seed(seed)
tomesd.apply_patch(pipe, ratio=0.5) # Can also use pipe.unet in place of pipe here

start_time = time.time()
image = pipe([prompt] * batch_size, num_inference_steps=num_inference_steps, generator=generator).images[0]
end_time = time.time()
print("ToMe: {:.3f} seconds".format(end_time-start_time))
image.save("results/orgin_ToMe.png")

The output from this script is:
Origin Pipeline: 2.728 seconds
ToMe: 2.581 seconds

In Table 4, the speedup is almost doubled when r=50. Why is this the case in my test?
Could you give me some advice?

You might not be giving your GPU enough work. Try increasing the batch size and image size and see what happens.
The results in the paper were done using the original stable diffusion repo, not diffusers. Diffusers itself has implemented a bunch of different optimizations that eat into the speed-up of ToMe, but you should still see gains at bigger image sizes.

Does this still work in 2024? with the xl or Lightning models?

Tested on XL, and accidentally found that merging middle blocks (1024 dimensions) give much better results (although no big speedups)

Me too, faster only 5.78% , and no memory reduction.


Add unit testing

Right now the code is not unit tested at all, and it could be very good to have more than just functional end-to-end testing.

Run valgrind's memcheck along with the unit tests to check for memory leaks.

Compile with -fsanitise=thread when launching unit tests, and run them a few times a week (configurable in Travis CI) to drastically reduce the risks for random thread problems like there were for the v1.1.0 (a crash only happening in 1% of the runs, related to the multithreading).

Send unit test code coverage results to Coveralls.io

Update: The code is now in go, and much easier to unit test.

[ ] Discover
[ ] Attack
[ ] Helpers
[ ] Loaders

[ ] Make the CI fail if the unit tests are failing

Done in https://github.com/EtixLabs/cameradar/pull/93


How can I run exactly what you see on websim.ai on my local computer?

I have Claude and OpenAI API keys, but I can't seem to figure out how to run the actual page.

The plain html page should run in any browser, just drag it into. Sure, further websim.ai functions are not running here until coded out.


Improve .Site.GetPage so it can get a specific regular content page

See https://discuss.gohugo.io/t/can-we-use-hugo-commands-in-markdown-files/4937/2

We should probably build some kind of index (a map?) if this is going to be used a lot.

Maybe we can use last outputFormats feature to generate the required "index" ?
I try to generate a json file with all the information about pages, it generate the correct file in public/idx/pages.json but impossible to use/reference this folder it in templates. (egg and chicken problem ?)
Is there a way to generate an outputFormat to data dir ?
Is there a way to order outputFormats'runs ? (to be sure that my generate date are created before used by other templates..)
[outputFormats.IDXPAGES]
MediaType = "application/json"
BaseName = "pages"
IsPlainText = true
Path = "idx"

(egg and chicken problem ?)

Yes. Output format is a rendering format, so your thoughts would only make sense if you build the site several times and route the output to data to first n times ...
But in any case, what you are talking about (not sure what) is not covered by this issue, and probably belong in discussion form.


fix: omit empty string from name & use case-insensitive equality for comparing SAML attributes

What kind of change does this PR introduce?

Fixes an issue where the SAML mapping is incorrect when a Default is specified in the mapping and the FriendlyName in the SAML Assertion is an empty string
Use case-insensitive equality for mapping SAML attributes

What is the current behavior?

During the SAML assertion process, the SAMLAttributeMapping struct defaults the Name to an empty string. When combined with a SAML assertion that has an empty string set in the FriendlyName, this causes an incorrect mapping when a default mapping is provided. (see test case
Use case-sensitive equality for mapping SAML attributes

Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 58.001%

Files with Coverage Reduction
New Missed Lines
%

internal/api/samlassertion.go
4
55.77%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
8811

Relevant Lines:
15191

💛  - Coveralls


Error of included header name

In Windows implementation (https://github.com/play175/wifiNotifier/blob/master/wifiNotifer_windows.go#L14) include is with capital letter which raises an error when trying to find a include file for a cross compile (for example from linux OS)
Fixed in a fork (cannot create PR since needed to modify go.mod file) - https://github.com/justinask7/wifiNotifier

Done.
Thank you for the fix.


Does the csi driver support serverless kubernetes like ASK?

I am trying out in alibaba cloud ASK cluster, and after I do kubectl apply -f k8s.yaml, the csi-controller pod has status ProviderFailed, and describing the pod it shows Message: The specified parameter HostPathVolume is not valid. I guess it's because of hostPath is being used in k8s.yaml ? So my question is does juicefs's csi-driver support ASK? Thanks.

from alicloud ack and ask csi documentations, indeed it seems ack support hostPath but ask not yet, wondering is it possible to modify k8s.yaml file to make it work for ask like Alibaba's official csi-privisioner?

Hi @ZhengRui ,
ASK did not support node related functions, such as DaemonSet and HostPath, but JuiceFS csi driver is deployed as DaemonSet and uses hostPath /var/lib/kubelet shared with kubelet. Furthermore, The nodes of the ASK cluster are virtual in witch pod can't reach kubelet. However csi driver needs to register to kubelet and kubelet needs to call csi plugin when PV is created. So JuiceFS csi driver dosen't support ASK.
I will close this issue, thanks.

thanks for confirmation, is there plan to support serverless k8s? @zwwhdls

Hi @ZhengRui ,
JuiceFS CSI driver can't support serverless k8s, because of its no node related functions such as Daemonset, HostPath, fuse... However, you can use JuiceFS SDK instead. Please refer to this document: https://github.com/juicedata/juicefs/blob/main/docs/en/hadoop_java_sdk.md


[Enhancement] add switch: brpc_connection_type

Fixes #issue
Add BE switch brpc_connection_type, default value is "single", same as before.
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/util/brpc_stub_cache.h
0
1
00.00%
[108]


[EAGLE-406] modify README.md by adding Status section for build status

Reviewed, it is a nice change, very straightforward


I need help with the ajax calls.

I know that this should be very simple.  But,  I just can not figure out the ajax.
All I am trying to do is use a link to call say buttons.php into a div on the current page called winDow.
Please show me  an example of this.
Note**  Then I want to be able to call other pages like typo.php,  components.php,  etc.
I figured out how to do the router which is fine.  But,  I want to separate the sections into other pages and just bring them in via ajax.

Hi Findborg,
You can try the ajax code below.
html.ajax('components.php')
    .done(function (pageContent) {
      html('#myDiv').text(pageContent);
    }).fail(function (xhr) {
      console.log(xhr.statusText);
    });

Oh,  I see.  I could not figure out how to configure the done (function).  I will give it a try.


Investigate 3rd party data generators

Feature Request
We want to make use of existing opensource data generators such as FAKR or javaFaker.  This comes from EPIC #1326.  This task is the investigative part.  The follo wup task to integrate them into data helix is in #1438
Description of Problem
As a Data Helix developer, I want to leverage 3rd party libraries such as  FAKR or javaFaker rather than re-invent the wheel and i want to find out what is out there and how they cna be used
Potential Solutions

Ideally we would use 3rd party libraries like an API and just leverage them in our internal custom generators (like names, addresses etc).
At this stage its hard to know what is involved in using them an dthis task is about finding that out
There is a high chance the 3rd party libraries will be apis but need to connect to the internet behind the scenes or they may just be web services that we ourselves need to connect to.  Wnat to find out what the reality is.

Before bringing the story into 'Ready' please consider the following:
Acceptance Criteria - Given, When, Then

Showing some 3rd party generators producing output in a stand alone java program we write.

Estimate
3
Tasks

[ ] Find a list of 3rd party generators which generate fields useful to datahelix
[ ] Think about trends in the types of generators investigated (do they provide apis, are they just web services, do they have concept of random or sequential mode or have some search criteria)
[ ] write an independent test program in java that uses the 3rd party libraries want to leverage to generate some data - want to do this mini PoC before do the full integration PoC with data helix

Dependencies
3rd party libraries (like FAKR) and possibly web services and the internet
Demo - Should we demo this change? To who?
Possibly could demo what these libraries are capable of to team
Is this feature done?
Please run through the Definition of Done checklist

generatedata
Site: http://benkeen.github.io/generatedata/
Type: Local web-service, REST
Stack: PHP, MySQL
Notes: old PHP project that needs a server and db to run...nah
Fakr
Site: https://github.com/faker-ruby/faker
Type: Library
Ports:

Java: https://github.com/DiUS/java-faker
GoLang: https://github.com/kkirsche/Fakr
Kotlin: https://github.com/moove-it/fakeit
Python: https://pydbgen.readthedocs.io/en/latest/

Notes: The biggest issue when locking for data generators waas finding things that weren't ports of Fakr
NAACCR (North American Association of Central Cancer Registries) Data Generator
Site: https://github.com/imsweb/data-generator
Type: Library
Stack: Java
json-data-generator
Site: https://github.com/vincentrussell/json-data-generator
Type: Library
Stack: Java
Mockaroo
Site: https://www.mockaroo.com
Type: web service, freemium
Notes: many, many data types
Spawner
Site: https://sourceforge.net/projects/spawner/
Type: Executable
Notes: not many data types
Benerator
Site: https://sourceforge.net/projects/benerator/ /
Type: Maven plugin? Binary executable
Notes: Looks dead.... main site is dead http://databene.org.
Other Lists

Lists: https://web.archive.org/web/20180602223444/http://databene.org/databene-benerator/similar-products.html

http://wiki.c2.com/?TestDataGenerator  <- good looking list

For the Purposes of the a POC, i'm thinking of trying Faker and Mockaroo
Faker - seems most widely used library out there, with plenty of custom types but a limited range of values, and functionality. It's available as a java library
Mockaroo - is a freemium web service, it seems to have the most usage of it's type and has a comprehensive set of functionality. It's available as a REST endpoint.

For the Purposes of the a POC, i'm thinking of trying Faker and Mockaroo
Faker - seems most widely used library out there, with plenty of custom types but a limited range of values, and functionality. It's available as a java library
Mockaroo - is a freemium web service, it seems to have the most usage of it's type and has a comprehensive set of functionality. It's available as a REST endpoint.

sounds good to me to try those 2.

Sticking the poc here https://github.com/cuthullu/third-party-generator-poc


WIP: JSDoc 3.6+ and Markdown plugin support

Render is actually broken in JSDoc 3.6+:

There is no issue anymore when disabling Markdown plugin.

Issue opened https://github.com/jsdoc/jsdoc/issues/1668

Codecov Report

Merging #246 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #246   +/-   ##
=======================================
  Coverage   70.83%   70.83%
=======================================
  Files           5        5
  Lines          48       48
  Branches       11       11
=======================================
  Hits           34       34
  Misses         11       11
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3591c8a...d07eebc. Read the comment docs.


release: 1.3.0

:robot: I have created a release beep boop
1.3.0 (2022-12-02)
Features

deps: bump dependencies (c5c567f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/starudream/douyu-task/releases/tag/v1.3.0 :sunflower:


Review usage of arrow.get() for Arrow 0.15.0

Arrow 0.15.0 has been recently released and the warning messages mentioned in #296 have disappeared.
After reading the comments in that issue and reviewing the code, it seems to me that only user date input can be affected for some commands. For example, if someone relied on using timestamps in the command line, errors will probably be raised with Arrow 0.15.0.
@ryanmjacobs It would be great if you could review my changes and compare them with those you made a month ago :relieved:
Changes:

Reduce the number of uses of arrow.get() related to spans in reports.
Unify catched exceptions when calling arrow.get().
Include Frame.updated_at parsing inside try/catch just like
start/stop.

Of course, a review from @k4nar would be great, as much of this code is his! :relaxed:

@k4nar I think that would be great, not because this changes require Arrow 0.15.0 (they should work fine with older Arrow versions), but to take advantage of all the fixes and improvements in that library. If you agree with this, I'll change the requirements.txt to arrow >= 0.15.0.

Ah ok, I thought the changes were not backwards compatible. Then yes, updating the requirements.txt (and not the setup.py) should be enough :+1: .

It looks like setup.py gets the requirements from requirements.txt so it would be effectively upgraded too. Could that be a problem with distribution/packaging dependencies?

This is a strong requirement that might break many users installation. If it's not required, I would not limit requirements. But we should mention it in the installation docs. WDYT?

This is a strong requirement that might break many users installation. If it's not required, I would not limit requirements.

Perfect, let's keep the requirements as they are.

But we should mention it in the installation docs. WDYT?

I'm not sure I understand what should be mentioned in the installation docs. I can't find any mention to requirementes or dependencies :man_shrugging:

I would have wrote something in the single user installation section, but it will make things complicated when it's not required. Forget it.

I think these changes are worth mentioning in the CHANGELOG. WDYT?

I think these changes are worth mentioning in the CHANGELOG. WDYT?

Sure! I've just added a line :+1:
It would be ideal that @ryanmjacobs reviewed and added his changes before merging this, but of course, he could do that a posteriori if you think this can be merged as is.

Hey nice work David! I'm glad someone is finally making a move on this
issue.
I haven't really looked at the codebase since over a month ago. But I'll
double-check everything and add mine tonight. You'll have a LGTM by
tomorrow morning :)
On Fri, Sep 13, 2019 at 12:33 PM David Alfonso<EMAIL_ADDRESS>wrote:

I think these changes are worth mentioning in the CHANGELOG. WDYT?
Sure! I've just added a line 👍
It would be ideal that @ryanmjacobs https://github.com/ryanmjacobs
reviewed and added his changes before merging this, but of course, he could
do that a posteriori if you think this can be merged as is.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TailorDev/Watson/pull/313?email_source=notifications&email_token=ABAN46PIOHKS63WZRBQD53LQJPTHBA5CNFSM4IVJ2B42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6V7RKY#issuecomment-531364011,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABAN46NBJA6Q47FJSQL4GA3QJPTHBANCNFSM4IVJ2B4Q
.

@ryanmjacobs Thank you! I think it's worth waiting for your changes then, even if it takes a bit more time, don't worry :+1:

@davidag Great, I've set aside time to rebase my changes tonight. I'll ping you in this thread when it's done.

Okay, I've pushed my old changes... (I guess I never committed them...)
Looks like the only change I made was this: https://github.com/ryanmjacobs/Watson/commit/80363e6e7213ad6b1d87d80aa622701167decfce. However, I like what you are doing more -- which is reducing arrow.get() usage altogether.
I've run setup.py install on my system using your repository. I see no errors with watson start test, watson stop, watson sync, and then watson log -a. Prior to these changes, I was getting errors on watson sync and watson log. All of my new and prior log data looks fine (correct datetimes and everything).

I might be totally wrong on this part. But if it's fine, then I think we are good to merge.
My only worry is watson report --csv, which I think was introduced after 1.7.0. I see that you've made changes to utils.py in the CSV function used for report() (https://github.com/TailorDev/Watson/pull/313/files#diff-53886fd7d4ba12dfad3dbb6c9716ca57L381).
Anyways, until today, I've been running 1.7.0. watson report -a looks fine to me, but watson report -a --csv gives me this. It looks funny, but maybe that's what the output is supposed to look like.
$ watson report -a --csv
from,to,project,tag,time
1970-01-01 00:00:00,2019-09-17 23:59:59,redacted,,194312.0
1970-01-01 00:00:00,2019-09-17 23:59:59,redacted,SearchBox,11778.0
1970-01-01 00:00:00,2019-09-17 23:59:59,redacted,app-js-overhaul,46644.0
1970-01-01 00:00:00,2019-09-17 23:59:59,redacted,debug-integration-whitescreen,101.0
1970-01-01 00:00:00,2019-09-17 23:59:59,redacted,demo-route,1157.0
1970-01-01 00:00:00,2019-09-17 23:59:59,redacted,deploy-remote-clone,2870.0
1970-01-01 00:00:00,2019-09-17 23:59:59,redacted,error-modal,1091.0
1970-01-01 00:00:00,2019-09-17 23:59:59,redacted,fix-dateslider-after-overhaul,1259.0
1970-01-01 00:00:00,2019-09-17 23:59:59,redacted,fix-remove-integration,4797.0
1970-01-01 00:00:00,2019-09-17 23:59:59,redacted,gridbuilder-streamline,105833.0
...

While watson report -a gives me this:
$ watson report -a
redacted - 53h 58m 32s
        [SearchBox  3h 16m 18s]
        [app-js-overhaul 12h 57m 24s]
        [debug-integration-whitescreen     01m 41s]
        [demo-route     19m 17s]
        [deploy-remote-clone     47m 50s]
        [error-modal     18m 11s]
        [fix-dateslider-after-overhaul     20m 59s]
        [fix-remove-integration  1h 19m 57s]
        [gridbuilder-streamline 29h 23m 53s]
        [local-backend     13m 00s]
        [onboarding-cleanup     24m 30s]
        [onboarding-debug  1h 29m 58s]
...

@ryanmjacobs Thank you for your comment, it's great you could test my changes and provide yours!
After careful reading, I'm not sure I understand your concerns with the output of watson report -a --csv.
When I developed the --csv option I got inspiration from --json, where the output times are in seconds, which made total sense to allow other tools to easily parse and transform the generated csv/json dump. You could compare the output using both formats.
If what worries you is that the end of the interval is 2019-09-17 23:59:59 instead of 2019-09-16 00:00:00, I think the former is correct. You might want to look at class Span in frames.py, which is used to build the span in watson.report().
Please let me know if I'm missing something!

Oh, okay. The lines starting with 1970-01-01 00:00:00 looked concerning
to me at first. They looked like uninitialized epochs, so I was hesitant.
But now I see that it's probably okay. You're just setting a timerange that
encompasses everything.
On Wed, Sep 18, 2019 at 3:06 AM David Alfonso<EMAIL_ADDRESS>wrote:

@ryanmjacobs https://github.com/ryanmjacobs Thank you for your comment,
it's great you could test my changes and provide yours!
After careful reading, I'm not sure I understand your concerns with the
output of watson report -a --csv.
When I developed the --csv option I got inspiration from --json, where
the output times are in seconds, which made total sense to allow other
tools to easily parse and transform the generated csv/json dump. You could
compare the output using both formats.
If what worries you is that the end of the interval is 2019-09-17 23:59:59
instead of 2019-09-16 00:00:00, I think the former is correct. You might
want to look at class Span in frames.py, which is used to build the span
in watson.report().
Please let me know if I'm missing something!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TailorDev/Watson/pull/313?email_source=notifications&email_token=ABAN46ICRJXJP2GCPLW3LU3QKH4SRA5CNFSM4IVJ2B42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD67ROFI#issuecomment-532616981,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABAN46NCI4IFOMWWY3L54JTQKH4SRANCNFSM4IVJ2B4Q
.

@ryanmjacobs Yes, I think that's normal too, thank you again!
@jmaupetit I guess this is ready to merge :tada:


Content Security Policy of your site blocks the use of 'eval' in JavaScript`

How do you envision this feature/change to look/work like?
Create a new project, run the extension in chrome , there is a error : disable function eval
But I don't use eval in any code, how can I resolve this, Thanks
Content Security Policy of your site blocks the use of 'eval' in JavaScript`

What is the purpose of this change/feature? Why?
resolve error message
(OPTIONAL) Example implementations
No response
(OPTIONAL) Contribution

[ ] I would like to contribute to this RFC via a PR

Verify canary release

[X] I verified that the issue exists in plasmo canary release

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate problems.

Same issue

This only occurs in dev mode and is acceptable.

This only occurs in dev mode and is acceptable.

yes, but why?

This only occurs in dev mode and is acceptable.

yes, but why?

https://github.com/parcel-bundler/parcel/pull/8034#:~:text=This required support,contents by id.
Caused by an upstream parcel dependency.
There is an identical issue in parcel.

Thanks all for flagging. It seems the latest Chrome update basically block all eval CSP (which is needed for auto-reload for extension).
Let's see if there's a way to go around it.


Replace RCTBubblingEventBlock  by RCTDirectEventBlock to avoid event name collision with Expo AV

Update the changelog
Pending, will do tomorrow.
Provide an example of how to test the change
Test case with expo is reported here: https://github.com/react-native-community/react-native-video/issues/1618
Describe the changes
Replaces RCTBubblingEventBlock for RCTDirectEventBlock.
As bubbling events are recommended for DOM-like events (scroll, focus, ...) that need to propagate.
This avoids collision on event names with the expo av library. As DeviceEventEmitter is shared among all libraries.
Ref: https://gist.github.com/chourobin/f83f3b3a6fd2053fad29fff69524f91c#ios
Notes: Bubbling events are like DOM events so that a parent component can capture an event fired by its child. Generally these are UI-related, like "the user touched this box". Direct events are not bubbled and are intended for more abstract events like "this image failed to load".
Closes https://github.com/react-native-community/react-native-video/issues/1618
Tomorrow I will test that events are firing correctly, but I open the PR so people can test it easily.

I've tested and it works. We should change the block types in RCTVideo.h as well though.

Updated with changes on RCTVideo.h as well

Changelog

Tested with few events (onLoad, onProgress, onBuffer, ...) and it is working.


Subscribe us button is not working after clicking it ;

after clicking subscribe us button it should be automatically go down to the subscribe section i want to work on it please assign me

I am interested to solve this issue please assign me this task

add our google form in that part @Ritu-2001
All the best. Let me know if you don't want to do in case due to late response.
I'm sorry for being inactive, the reason for the same was due to some serious health issues.

@kaal-coder i want to work in this issue under jwoc

I want to work for on this issue under jwoc community, please assign me


ADVERTISE_FAILED_DATA_TOO_LARGE

Hi,
As per the repo , I am trying to make an app that sends out UID frames.
Here's a code snippet
private void advertise() {
//To check if Bluetooth Multiple Advertising is supported on the Device
if( !BluetoothAdapter.getDefaultAdapter().isMultipleAdvertisementSupported() ) {
Toast.makeText( this, "Multiple advertisement not supported", Toast.LENGTH_SHORT ).show();
start.setEnabled(false);
}
    BluetoothLeAdvertiser advertiser = BluetoothAdapter.getDefaultAdapter().getBluetoothLeAdvertiser();
    //defining the settings used while advertising
    AdvertiseSettings settings = new AdvertiseSettings.Builder().setAdvertiseMode(AdvertiseSettings.ADVERTISE_MODE_BALANCED).setTxPowerLevel(AdvertiseSettings.ADVERTISE_TX_POWER_HIGH).setConnectable(true).build();

    //We make Parcel UUID(UUID can be generated online) and Advertise Data object
    ParcelUuid pUuid = new ParcelUuid( UUID.fromString( getString( R.string.ble_uuid ) ) );

    //building servicedata
    byte txPower = (byte) -16;
    byte FrameType = 0x00;
    byte[] namespaceBytes ="01020304050607080910".getBytes();
    byte[] instanceBytes ="AABBCCDDEEFF".getBytes();
    ByteArrayOutputStream os = new ByteArrayOutputStream();
    try {
        os.write(new byte[]{FrameType,txPower});
        os.write(namespaceBytes);
        os.write(instanceBytes);
    } catch (IOException e) {
        e.printStackTrace();
    }

    byte[] serviceData =os.toByteArray();

    AdvertiseData data = new AdvertiseData.Builder().addServiceData(pUuid,serviceData).addServiceUuid(pUuid).setIncludeDeviceName(false).setIncludeTxPowerLevel(false).build();

     //callback to check success or failure when advertising
    AdvertiseCallback advertisingCallback = new AdvertiseCallback() {

    advertiser.startAdvertising( settings, data, advertisingCallback );
}

What could be causing the data to be too large ? The service data is built as per the code in the repo.

Namespace is 16 bytes not 32. This question would make more sense on StackOverflow maybe?

Sorry I am new to this community.
I thought this would be relevant as the code I wrote was in reference to the one in the repo.
I'll go ahead and remove this if asked to.

They bytes you've provided show a common pitfall: Confusing hex vs bytes vs UTF-8 vs other encodings.
The code "01020304050607080910".getBytes(); encodes the given string into bytes using the platform's default encoding (Could be UTF-8, or something else). https://docs.oracle.com/javase/7/docs/api/java/lang/String.html#getBytes()
Instead, what you want here is to parse the given string as hex. The sample code here: https://github.com/google/eddystone/blob/master/eddystone-uid/tools/txeddystone-uid/TxEddystone-UID/app/src/main/java/com/google/sample/txeddystone_uid/MainActivity.java#L357 does this, but there may be libs you could use to avoid having to "roll your own".

Thanks a lot for your reply. I think that is what causing the issue.


Support nested body params for CompositeError

Update templates that have nested body param logic to call ValidateName API on CompositeError.
See https://github.com/go-openapi/errors/pull/30 for addition of ValidateName API to CompositeError which needs to be committed prior to this.
Closes #2594

Whoops this PR should have been opened as a draft.

Renamed branch according to contribution guidelines, closing this in favor of #2595


No Stats

update to 3.0.0, There's no Stats by Ext or Stats by Loader.
But 2.5.0 is fine.

This question is available on Nuxt community (#c22)

Hey @myeveryheart. Thanks for reporting. It should be fine with the latest release (3.1.2)

I am using the latest version, but I still can't see stats

Yes, I do

Same problem with profile on.

same problem in 3.1.3

Same problem in 3.1.4

try to set like this :
new WebpackBar({                 reporters: [ 'profile'],                 profile: true             })

@Yohox, It works, but missing table line.

@Airkro
we can see https://github.com/nuxt/webpackbar/blob/0c05d65093973058d07faed4b3d2d3e85fa13bbe/src/utils.js
this version use table print the table line but now v3.1.5
the  table pacakge change to  text-table so it hasn't table line~ if you like this  you can fork it and change the package to text-table~
after that 我们可以说中文

try to set like this :
new WebpackBar({ reporters: [ 'profile'], profile: true })
because profile will should when reporters set profile

Hello,
Thank you Yohox for this solution, this is great :)

For using bars reporter and profiler at the same time:
new Webpackbar({
  reporters: ['fancy', 'profile'],
  profile: true,
}),

Tested on<EMAIL_ADDRESS>
But it's still kinda strange to manually set reporters ... The Options section in README.md mentioned that the profile can be used to "enable profiler" but it doesn't actually do it. I'll create a PR to fix this.


Port the Kubernetes guestbook example app to Vitess.

@alainjobart @sougou @shrutip
For those who are trying out the example, the end result is now more fun to play with. :)

Coverage decreased (-0.0%) when pulling 64d0f56e2d0b8c7667b62dbde515766502dbf1d2 on guestbook into 2227ad5a135d4f11b6d99ab90e7f7ccd143b80e4 on master.

Ahh right. v3 will just have to wait a bit longer :). I'll see what I can do this weekend.
lgtm otherwise.

I look forward to upgrading my example to v3 :)

This is great! Let's get this out of the door on v2, then we can upgrade to v3 a bit later...


Support for DSF?

Would it be possible to support DSF?

Hello and thanks for raising this.
Support for formats like DSF or any other depends 100% on the target device. If the device supports it, it should work with Go2TV too.
It's true that currently the GUI mode does allow you to select DSF files but that would be easy to add in future releases. However you can still play those files in the CLI mode by calling
go2tv -v yourfile.dsf

Thanks,
Alex


feat: support timestamp aggregation for Oracle and TD

Closes #762
This removes timestamp from being included in wildcard aggregations by default.
Adds new flag --wildcard-include-timestamp to include timestamp columns in wildcard aggregations i.e. --sum='*'. This will calculate the SUM(UNIX_SECONDS(ts_column))
When manually specifying --sum ts_column, the aggregation will run over SUM(UNIX_SECONDS(ts_column)).

/gcbrun


Toggle "click to count" option

Create a setting that enables a "distinct count" button in the discover interface.
This setting disable timeout, but will cancel if the user modifies the filters.

Implemented in #766


feat-add messages api

Issue: https://github.com/novuhq/go-novu/issues/50
This adds the methods needed for the messages api per: https://api.novu.co/api#/Messages/MessagesController_getMessages
It also introduces a QueryBuilder interface for passing parameters to build query strings with. Using this allows us to not need to rely on reflection which improves performancec and also gives us explicit types and handling for parsing query structs into strings

@jerempy please resolve the conflicts


Issues getting netcdf_to_ee() to work

Discussed in https://github.com/gee-community/geemap/discussions/2031

Originally posted by cjheitzig June  5, 2024
I am trying to use netcdf_to_ee() to convert Copernicus land use data into an ee.image for further processing. My code already is calculating zonal statistics on nighttime lights and GHSL population data as ee.images, so to have it in this format is quite useful.
I would totally use code like the below to download Copernicus land use data, but for some reason landuse data from 1992 is not available in the Google Earth Engine library, so I cannot do this. I am trying to download data for 1992 only. I would upload a compressed sample file, but the data is larger than the allotted 25MB, so instead I am linking above.
landcover  = ee.ImageCollection("COPERNICUS/CORINE/V20/100m")
My issue is that when I run the below code, I receive the error "The netCDF file is not a regular longitude/latitude grid". Others have mentioned this issue (e.g. #1945) and it has supposedly been fixed, but it gives me the same error and does not import the netcdf as an ee.image. I am using geemaps Version: 0.32.1.
url1992     = ".../landuse1992.nc"   # Data downloaded from the CDS link above
nc_dataset = netCDF4.Dataset(url1992, 'r')
var_names = list(nc_dataset.variables.keys())
landuse1992 = geemap.netcdf_to_ee(nc_file=url1992, var_names=var_names, lat='lat', lon='lon')

When I use the example in the Geemap book, I note the following characteristics of the 'wind_global.nc' dataset (which I am able to convert to an ee.image):

Latitude dimensions: ('lat',)
Longitude dimensions: ('lon',)
Latitude data type: float64
Longitude data type: float64
Latitude shape: (181,)
Longitude shape: (360,)
Latitude max: 90.0
Latitude min: -90.0
Longitude max: 359.0
Longitude min: 0.0

With the Copernicus land use data in 1992, I note these characteristics:

Latitude dimensions: ('lat',)
Longitude dimensions: ('lon',)
Latitude data type: float64
Longitude data type: float64
Latitude shape: (64800,)
Longitude shape: (129600,)
Latitude max: 89.99861111111113
Latitude min: -89.99861111111112
Longitude max:<PHONE_NUMBER>1111113
Longitude min: -179.9986111111111

I'm not sure what the issue is and would be grateful for any help. I simply don't know enough about this stuff to understand why my data does not work while 'wind_global.nc' works. I ultimately would like to use geemap.zonal_stats() to report zonal statistics of land use over 5km cells.

See answer in https://github.com/gee-community/geemap/discussions/2031


Allow ingress class to be configurable

Changes

-:gift:  Allow ingress class to be configurable, with istio as the default.

/kind enhancement

Fixes #22

Thoughts on whether or not this should include a README update with how to change the ingress class name?
Default behavior is unchanged.

Issue #96 will take care of the refactoring. Let's merge this now.
/approve
/lgtm


Possible to include other yaml-files inside a yaml-file?

I'm looking for a way to separate my yaml-files into different files and combine them into 1 big yaml-file.
The yaml-loader I used for Webpack was able to do this :   https://github.com/ngfk/yaml-import-loader
The !import statement proved to be very powerful. I would love to have this with this loader as well.
Are there any plans to add something like this?

Apologies for the months-late reply - this is an interesting concept that we're open to supporting! I would love to know more details on the most desirable combination mechanism and some example use cases.
What would the desired behavior be around duplicate keys? Should they cascade where (for example)
!import ./import-1.yml
!import ./import-2.yml

import-2 overrides any keys of the same value in import-1? Similar to in JS:
console.log(
  {
  foo: 'bar',
  ...{foo: 2}
  }
); // -> foo: 2

Yeah, I guess the second would override previous declared values.
However, I want to combine different sections into one file, and will not override values anyway.


Any way of reuse in non-Vue apps?

Hi!
Is there some way to reuse styles for React for example?
or only complete manual rewrite?

You can reuse theme styles (typography, colors, etc). The component styles are currently integrated with the Vue template, but you should be able to rewrite them for React without much difficulty


Added Czech translation

Hey, I started using this plugin some time ago and modified my local copy to include Czech translation, as that is my system language. Thought I'd try adding it upstream as well.
Thanks for your work :)

Very nice! Thanks for your contribution :smile: :blue_heart:


SwiftRemoteMirror: fix static library builds for Windows

We were previously treating all the builds as shared, which is not the
case for the host library build of SwiftRemoteMirror.  The warnings were
lost in the interminable spew from the build which is now fixed and this
stands out.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please smoke test and merge


[WIP-DNM] ectd (ticdc): add etcd meta data magration logic

What problem does this PR solve?

Issue Number: close #xxx
What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

/run-verify-test

/run-all-tests

/run-all-tests

/run-all-tests

/run-integration-tests

/run-kafka-integration-tests

/run-integration-tests

/run-integration-tests


Auto Merge Fail please check pull request #29924

#29924
I'm getting this Automerge error "Auto merge failed, please check pull
failed to verify website: https://piqsol.com/: failed to verify https://piqsol.com/ using HEAD request: context deadline exceeded

Hi @keone,
Can you please check PR https://github.com/solana-labs/token-list/pull/29924


What is the license for Panel_Locker

I am planning to use your Panel_Locker in one of my conversion project, may I know what is the license for this repo?

Aight.. Thats clear it up.. thanks


Add User accounts and grant them sudo

Forge modules are removed from the repo and listed as dependencies. ih-puppet installs dependencies before a puppet run.


NEARBY

I see that tile38 supports a NEARBY query, is that possible at all with buntdb?
http://tile38.com/commands/nearby/

I added a description of the dist param to the Nearby function comment.


⚠ 366.ru has degraded performance

In c8219f2, 366.ru (https://366.ru) experienced degraded performance:

HTTP code: 200
Response time: 1793 ms

Resolved: 366.ru performance has improved in 9ca8416.


Fix slow tests not running

It seems the environment variable was not correctly set .. This PR fixes it

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Yes I think so.. the error I got is :
nvidia-container-cli: requirement error: unsatisfied condition: cuda>=12.2, please update your driver to a newer version, or use an earlier cuda container: unknown


Remove predicate.GenerationChangedPredicate{}

In https://github.com/Skyscanner/applicationset-progressive-sync/pull/96 we added a predicate to the For responsible for sending ProgressiveSync events.
While that helped us moving forward, it means the controller is not able to auto-heal in case something changes the CRD Status.
We should remove the predicate and make the reconciliation loop idempotent, so it should converge over time to the desired state.

Fixed in #143