S3 as a Filesystem section - you should not use any of these tools

S3 should never be attempted to be mounted as a filesystem. This is a bad idea and will result in very poor performance. s3fs and any other tool like mentioned in this are attempting to use s3 in a way it should not be used.
s3 is not a file system, and is object not block level. If one wishes to use it this way, there are methods which are considered best practice.
One option is to use the s3 sync command. This allows a local location sync with whats in s3 on a periodic (cron) basis.
Additionally AWS offers the use of Storage Gateway or File Gateway which are far superior way to use S3 as a file system and is a native aws product. These services are designed to operate in this way.
Any tool attempting to mount s3 in the way mentioned here currently, is against best practice, and considered bad practice.

I don't think this is the place for such debates and I believe this issue should be closed. If you'd like to open a pull request to better explain the downsides of using S3 as a filesystem, sure. But my understanding is that you want to take down the whole section, and I disagree with that.
These tools clearly have their place, otherwise there wouldn't be a bunch of them and in active use. Sometimes people don't care about performance as much as they care about something being simple and working a certain way without much fuss. There are pros and cons for anything.
Try using aws s3 sync on a bucket that is a few terrabytes in size with a lot of small files.
Storage gateway would be great, except it was designed to compete with storage drives and is way too expensive. Look at the requirements: http://docs.aws.amazon.com/storagegateway/latest/userguide/Requirements.html . About $170 per month for the ec2 instance alone. Plus everything else on top. Compared to a NetApp it might be cheap. Compared to a $10 t2.micro that mounts an S3 bucket and provides SFTP access? If it works and that's all you need, the choice is obvious.
I wish people would stop using the words "best practice" to mean "the only true way". Common practice" is better suited for what it actually means. Yes, it's not common practice. Yes, you should know what you're getting into and what the limitations are, as always. Doesn't mean you shouldn't do it, ever, at all. Right tool for the job and all that.

On Wed, Mar 15, 2017 at 1:09 AM, Bogdan Luput<EMAIL_ADDRESS>wrote:

I wish people would stop using the words "best practice" to mean "the only
true way". Common practice" is better suited for what it actually means.
Yes, it's not common practice. Yes, you should know what you're getting
into and what the limitations are, as always. Doesn't mean you shouldn't do
it, ever, at all. Right tool for the job and all that.

This is not a debate, as its direct from Amazon as being bad practice. I am
an amazon Trainer and consultant for many fortune 500 companies. This is
bad practice. The reason these tools exist is that many people do not know
how to use s3 properly and these tools are terrible for that purpose.
Agreed that the storage gateway option has a small cost to it; but keep in
mind aws is an enterprise product, not consumer grade. It in no way is
meant to compete with Godaddy as an example. These tools may meet a need,
albeit very poorly. In an enterprise, no enterprise should consider using
these tools. What is being described here is more for the consumer to use
these to 'save money' even if at an expense of doing it poorly.
So at the very least, I would add some commentary here of the con's to
using these tools and that they are not meant for the enterprise. An
enterprise should have no problem creating a storage / file gateway for
these purposes. I have seen some very big operations suffer majorly by
using these types of tools. This is not a discussion around opinion; this
is a discussion around whats considered right and wrong in AWS (directly
from AWS). I, nor Amazon, would ever recommend the use of these tools in an
enterprise. For someone running a blog? Perhaps. But even then the use of
these tools tells me the architecture needs work.
The best design is to simply leave the data on s3 and let it serve the
files directly vs. storing them on the local server. As soon as you sync
with the local server, you lose scaling, high availability, reduce the file
security (s3 is more secure than your ec2 instance), you make it far less
highly available and you waste money on ebs storage to replicate something
from s3 which is a fraction of the cost.

Whats cheaper than an sftp t2.micro instance mounting s3? Not running the
t2.micro at all and letting s3 be the source removing sftp all together.
Simply send files directly to s3. Thats part of the point; the use of these
tools do nothing than highlight a more expensive, less efficient, less
scaleable design.
On Wed, Mar 15, 2017 at 7:04 AM, Ryan Dymek<EMAIL_ADDRESS>wrote:

On Wed, Mar 15, 2017 at 1:09 AM, Bogdan Luput<EMAIL_ADDRESS>wrote:

I wish people would stop using the words "best practice" to mean "the
only true way". Common practice" is better suited for what it actually
means. Yes, it's not common practice. Yes, you should know what you're
getting into and what the limitations are, as always. Doesn't mean you
shouldn't do it, ever, at all. Right tool for the job and all that.

This is not a debate, as its direct from Amazon as being bad practice. I
am an amazon Trainer and consultant for many fortune 500 companies. This is
bad practice. The reason these tools exist is that many people do not know
how to use s3 properly and these tools are terrible for that purpose.
Agreed that the storage gateway option has a small cost to it; but keep in
mind aws is an enterprise product, not consumer grade. It in no way is
meant to compete with Godaddy as an example. These tools may meet a need,
albeit very poorly. In an enterprise, no enterprise should consider using
these tools. What is being described here is more for the consumer to use
these to 'save money' even if at an expense of doing it poorly.
So at the very least, I would add some commentary here of the con's to
using these tools and that they are not meant for the enterprise. An
enterprise should have no problem creating a storage / file gateway for
these purposes. I have seen some very big operations suffer majorly by
using these types of tools. This is not a discussion around opinion; this
is a discussion around whats considered right and wrong in AWS (directly
from AWS). I, nor Amazon, would ever recommend the use of these tools in an
enterprise. For someone running a blog? Perhaps. But even then the use of
these tools tells me the architecture needs work.
The best design is to simply leave the data on s3 and let it serve the
files directly vs. storing them on the local server. As soon as you sync
with the local server, you lose scaling, high availability, reduce the file
security (s3 is more secure than your ec2 instance), you make it far less
highly available and you waste money on ebs storage to replicate something
from s3 which is a fraction of the cost.

S3 buckets are public. Some people/companies have a problem with that and want to limit access, so using S3 directly is not the right choice. Storage gateway can mitigate that problem, but not everyone is a Fortune 500 company and can shrug off hundreds of dollars every month on something that has "cheap" as one of the main arguments going for it (S3). Similarly, not everyone has Fortune 500 problems, requirements or resources. For some, an EC2 instance mounting a bucket is good enough for the purpose as long as all it does is upload/download, no file-like manipulation.
The guide starts the section about S3 file systems by explaining that S3 is not a file system and it shouldn't be used like that. So the commentary is already there.
Don't get me wrong, I'm just a random guy on the internet and my opinions are my own, don't represent the guide in any way. That said, your insight is welcome. You could join the Slack channel and discuss there. Pull requests are also welcome as far as I've seen.

@bgdnlp s3 buckets arent public by default (well, no more than any other element of Public Cloud).
assuming you trust amazon trust model, you are in total control of permissions and access level.

Completely agree that it's not a best practice-- but it is a reality of how companies use S3.
The disclaimer that's there is a good middle of the road; condescendingly telling people "you're doing it wrong!" isn't going to win hearts and minds, and decreases the utility of the guide to many real-world scenarios.

By public I mean that they are accessible from the public internet and they
are not subject to VPC restrictions. Which means that (1) an attacker would
only need an authorized user's credentials to gain access, which goes
against multi layer security, and (2) it's an access point for an inside
user to exfiltrate unauthorized data.
The only way I know of to protect a bucket on the network level is to
whitelist an authorized set of IP addresses. Assuming that isn't practical,
another way I know of is to set up some kind of gateway to S3 and allow
access from that gateway only. Something the storage gateway would be great
for, except for the price. Yet another way involves DNS hijacking, but I'm
not going to go there.
Happy to be educated. So far no consultant was able to give me a better
solution.
On Mar 15, 2017 19:34, "Fernando Miguel"<EMAIL_ADDRESS>wrote:
@bgdnlp https://github.com/bgdnlp s3 buckets arent public by default
(well, no more than any other element of Public Cloud).
assuming you trust amazon trust model, you are in total control of
permissions and access level.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/open-guides/og-aws/issues/393#issuecomment-286819987,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEkESTnB3IUyC3akAQPtUqrqAeSXYBpEks5rmCERgaJpZM4MdJmE
.

The only way I know of to protect a bucket on the network level is to
whitelist an authorized set of IP addresses. Assuming that isn't practical,
another way I know of is to set up some kind of gateway to S3 and allow
access from that gateway only. Something the storage gateway would be great
for, except for the price. Yet another way involves DNS hijacking, but I'm
not going to go there.

a bucket can be made accessible only from a VPC (s3 peering).
then all you need to do is have a jump host in that VPC (or VPN) to access those files.

@rdymek Could you please provide us with a link + quote to where this is mentioned as a bad practice by Amazon. I think it would be helpful to include within the current document for people to take a look at.

This is not a debate, as its direct from Amazon as being bad practice.

a bucket can be made accessible only from a VPC (s3 peering).
then all you need to do is have a jump host in that VPC (or VPN) to access those files.

That's what I said. I think. Gateway, proxy, jump host, whatever you want to call it. You upload the file to that host and the host uploads it to the bucket. Unless you mean something that does some kind of port forwarding, in which case still that's what I said, DNS hijacking. Because an S3 bucket name will always resolve to a public IP address, in which case the jump host will be ignored. Unless you make your DNS resolve the name to an internal IP or you get fancy with routing. Did I miss anything?

s3 direct access is much more secire thwn s3fs (meets just about
every/anycompliance requirement). By introducing s3fs you actually weaken
the security tremendously.
IAM or bucket policies can control access to allow for conditions
restricting to only certain addresses if wanted/required. In fact
conditions could go far more granular even including time of day, etc.
when using s3fs you are killing your performance. S3 can handle far more
throughput than a t2.micro could ever dream of doing here. Plus its double
performance penalty (write to the ec2 instance, then write to s3). You will
be comstrained to the bandwidth and write limitations of the t2.micro.
Using just s3 alone is cheaper than s3 + t2.micro
Most ftp clients now allow direct comms with s3. Though not ftp itself,
the clients typically support this natively.
simply install the aws cli and do streight copies to s3. This will
perform better than s/ftp and and is a simpler login/command structure. One
commamd to copy a file to s3, vs multiple commands when using ftp.
Auditability. S3 is very easy to audit between s3 access logs, and
cloudtrail logs. Lost capabiloties under s3fs.
Encryption. Though s3fs supports some encryption its quite frankly
awful. S3 encryption allows for integration with kms, hsm, your keys,
amazon generated keys, etc. All with ZERO performance impact.
ftp is dead and convoluted. Direct s3 access from anywhere its needed
without vpn's or any issues scaling. Why on earth would I use ftp?

Bottom line, there is ZERO reason to use these tools. And I could take your
t2.micro instance, save you money, increase security, and increase
performance.
My point is that simoly suggesting these tools perpetuates bad
architecture. I teach for AWS, I always mention these tools. Then say,
"there may be very far edge cases where this could make sense; but if you
are tempted to use them, think twice because its usually a bad design
leading up to the use of these tools.
I will dig up references as I can. But I personally work directly with AWS
engineers and every one of them will say these are a terrible idea and
never lead to good things. Test it for yourself; open am aws ticket and ask
them.
I will follow up with references.
Ryan
On Mar 15, 2017 2:43 PM, "Bogdan Luput"<EMAIL_ADDRESS>wrote:

a bucket can be made accessible only from a VPC (s3 peering).
then all you need to do is have a jump host in that VPC (or VPN) to access
those files.
That's what I said. I think. Gateway, proxy, jump host, whatever you want
to call it. You upload the file to that host and the host uploads it to the
bucket. Unless you mean something that does some kind of port forwarding,
in which case still that's what I said, DNS hijacking. Because an S3 bucket
name will always resolve to a public IP address, in which case the jump
host will be ignored. Unless you make your DNS resolve the name to an
internal IP or you get fancy with routing. Did I miss anything?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/open-guides/og-aws/issues/393#issuecomment-286840931,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHipPbKX35BglUD7N2n2lcZiabV5_IVgks5rmDFlgaJpZM4MdJmE
.

Agree with about half your points, but none of them solve the problem I mentioned. Though it sounds like you didn't read my example, which is understandable. Specifically:

ftp is dead and convoluted. Direct s3 access from anywhere its needed without vpn's or any issues scaling. Why on earth would I use ftp?

S3 access from anywhere is exactly what this use case wants to prevent. It's a point against S3, not for it.

I teach for AWS, I always mention these tools. Then say, "there may be very far edge cases where this could make sense; but if you are tempted to use them, think twice because its usually a bad design leading up to the use of these tools.

Isn't that basically what the guide is also doing? The language is not as strong, but it mentions the pitfalls of using these tools and then lists (some of) them. Since this is a community driven guide, I think that it's good that it takes a more neutral or mildly-opinionated stance. Potentially avoids controversies like this one.

The point about 9... s3 has the CAPABILITY of being accessed from anywhere,
but could be locked down directly to single IP's (a single line in an IAM
constraint), single times of day, heck even for just a single transaction.
Please tell me WHY FTP would be better here?
But even if FTP is wanted, most FTP clients support direct s3 now. Again,
why/how would FTP be a better option?
Ryan
On Mar 16, 2017 2:09 AM, "Bogdan Luput"<EMAIL_ADDRESS>wrote:

Agree with about half your points, but none of them solve the problem I
mentioned. Though it sounds like you didn't read my example, which is
understandable. Specifically:

ftp is dead and convoluted. Direct s3 access from anywhere its
needed without vpn's or any issues scaling. Why on earth would I use ftp?

S3 access from anywhere is exactly what this use case wants to prevent.
It's a point against S3, not for it.
I teach for AWS, I always mention these tools. Then say, "there may be
very far edge cases where this could make sense; but if you are tempted to
use them, think twice because its usually a bad design leading up to the
use of these tools.
Isn't that basically what the guide is also doing? The language is not as
strong, but it mentions the pitfalls of using these tools and then lists
(some of) them. Since this is a community driven guide, I think that it's
good that it takes a more neutral or mildly-opinionated stance. Potentially
avoids controversies like this one.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/open-guides/og-aws/issues/393#issuecomment-286975237,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHipPUhTJf8nNaSE2l4iNapEtMJtVSq6ks5rmOBEgaJpZM4MdJmE
.

I already said why/how in my previous posts. Company wants employees to be able to access S3 on the road or at home, but without exposing S3 to the world on a network level. Or exposing the world to S3. That is normally solved with VPN. But that doesn't work with S3. IP whitelisting is not practical when it would mean whitelisting half the world, or even one country. Again, see my previous replies.
FTP isn't wanted. SFPT is one way of doing it. What is wanted is "internal-only" S3 access. Which is not possible by definition, since S3 is only present in the public space.

@bgdnlp
FTP isn't wanted. SFPT is one way of doing it. What is wanted is "internal-only" S3 access. Which is not possible by definition, since S3 is only present in the public space.

how is (s)ftp any more secure than s3 policies?
it's also exposed to the world. it will grant the user access to all the same files.
S3 can be access from a VPC only, so you can whitelist a VPN endpoint

No, it isn't exposed. Yes, you can whitelist it, but it's useless, as I already said.
But nevermind, that's been quite enough of that.

S3, using aws cli, using secret keys along with MFA. No reason to manage
IP's, and meet the requirements of the customer. Exposed keys are a
non-issue with MFA. One could take this a step farther with federation with
Active Directory and use of roles. Point is, these tools do not solve a
problem, but create more problems than they solve. So why would they be
suggested?
The FTP example is not unique (you aren't the first person/company wbo
wants s/ftp, but again is not the most secure, not the cheapest, and is
the poorest performing model. And if anyone thinjs sftp is more secure than
s3, even in this scenario offered you are poorly mustaken.
On Mar 17, 2017 10:22 AM, "Bogdan Luput"<EMAIL_ADDRESS>wrote:

No, it isn't exposed. Yes, you can whitelist it, but it's useless, as I
already said.
But nevermind, that's been quite enough of that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/open-guides/og-aws/issues/393#issuecomment-287384194,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHipPUq3xJO74NUcSfq0yhmHggaqzSrhks5rmqUrgaJpZM4MdJmE
.

I've been following along here a bit and having just reread the section on S3 in question here, I feel like the guide adequately disclaims that there are inherent issues with this approach.  However, in the spirit of educating people, it needs to be mentioned as a possible approach and obviously needs to be vetted for each individual use case.
Nothing at AWS is one-size-fits all.  This guide's mission is to educate folks with what's possible and how it's possible so I think the section is fine as written with this context.
At most, I could see making a stronger statement that this isn't a great idea for the already mentioned drawbacks and I'd be happy to review a pull request with such language (as I think @bgdnlp already said).

Lot of discussion here, which is fine, but to bring it back to being more actionable:

Many of these s3 filesystem-type tools are used (for good or ill), so we need to mention them; we want to give an overview and guidance and do not want to remove mention of popular tools, even bad ones, as that makes the guide less useful
When we do want to mention gotchas and reasons that it may be ill-advised, and should link to sources on that whenever possible (and include one of our handy warning emojis)

The current bullet "S3 as a filesystem" at https://github.com/open-guides/og-aws#s3-tips does mention limitations, but certainly could be improved.
Two actionable items that might arise from this:

a small, focused PR that adds a bit more language there and a 🔸 emoji that highlights downsides more clearly, with links discussing why it's problematic, if we have one (from AWS and/or elsewhere) and perhaps listing alternatives (@rdymek or others, a PR on this is welcome, and I'll leave this issue open for that)
a broader rewrite that helps a user navigate the question of "how do I get filesystem-like access to S3" and summarizes pros and cons including storage gateway etc. Might even be a matrix. (created #395 for this)

Let me start by saying that I agree that s3fuse is not how S3 is supposed to be used. It's an eventually consistent object store which simulates a filesystem and not a block store.
That said, until very recently certain regions did not have access to EFS, and needed/wanted to access the same data from multiple EC2 instances.
So the tips I found along the way, in case you still want to use s3fuse would be:

set the mount point in /etc/fstab, the server will reboot eventually
use the _netdev flag, that way the OS will wait for network before trying to mount the "drive"
use the iam_role flag instead of having credentials on the EC2 instance
use the noatime flag so that you don't waste money on useless calls to update the access time of the files since it is not a real/traditional filesystem
last but not least, use the flag use_cache=/tmp, not using cache will easily skyrocket your costs

I hope this helps.


Mock data

This adds a script that allows us to add randomly generated patients to the database. For testing.
Nothing else is affected. To run the script, first make sure you've done:
 pip install -r requirements.txt

Then do:
python add_mock_data.py

What changed:

/add_mock_data.py - the script that you can run
requirements.txt - added the fake-factory library. We should separate out different types of requirements for testing, production, dev at some point.
app/example_data.py - added different sets of choices that are used in the interface, such as races, ethnicities, etc. The mock data script selects from these choices to enter them in the database.

Here's what it looks like:

This answers the need described in #46

Whoa, neat! :+1: nice work

Should help alleviate the switch to Postgres, #121


gemspec: spec.files should include site/*

Should fix #3.

Jekyll 2.5.3 has its own docs subcommand so this won't pass until #4043 is merged.


IOS component only have .podspec, how to take?

My IOS Native component want to take The FlutterModule,But Then component only have .podspec。So I am generate FrameWorks，In .podspec write ' s.vendored_frameworks   = 'flutter_boost.xcframework'. But Only component The same use，Submitted Some error What repeat frameworks.I find The frameworks Only deposit at current component directory.

@wumengm
We are not sure what exactly is the issue are you reporting because the description you gave is very unclear. When you are opening an issue in flutter repo, please try to use one of the templates and provide requested details so that we will have enough details to work with.
Also, looking at the description, I think your question is better suited for support channels like StackOverflow so please ask the same there.
If you disagree or have found a bug in the framework, please use new issue template as mentioned above.
Closing for now due to lack of details and unclear description.


Deployment Instructions

What are the instructions for deploying this solution, to amplify or even locally would be great?
I'm attempting to go through the Data Mesh Immersion workshop and it assumes that the UI component has already been deployed.
Thanks

Added the deployment instruction

Thanks for providing those.


Dataset links are not working

Please update the dataset links if possible

Please update the dataset links if possible

Did you get the links to work? If so, would you please share the links. Thanks

@JAIJANYANI Do you by chance have a copy and if so could you share possibly please?


Styled News Article

Resolves #266, code from @narphorium

Few comments:

the layout seems broken on desktop
this is a duplication of the already existing news article sample
the sample doesn't include any explanations of the code

Can we merge instead some of the styling elements into the existing sample?

Closing due to lack of feedback.


Does This Tool Support AMD GPU ?

No, As it appears in the infer file, The code search for this prefix in GPU name, Which are all of them an Nvidia cards.
for value in [
                "10",
                "16",
                "20",
                "30",
                "40",
                "A2",
                "A3",
                "A4",
                "P4",
                "A50",
                "500",
                "A60",
                "70",
                "80",
                "90",
                "M4",
                "T4",
                "TITAN",
            ]

so for now its only Nvidia support ?

Yes, As I said before, The infer file just searching for Nvidia cards in the GPU name.


fix: remove mysql_secure_installation from PostgreSQL

What a blasphemy ;)

Why remove mysql_secure_installation ?

@landaal-ict Not sure if you're trolling, but mysql_secure_installation is part of a MySQL installation which has nothing to do with PosgreSQL which this cheat sheet is about.

It was a joke.. ;)

Please don't use the issues and PRs for jokes. Let's try to keep it as professional as we can, and focus on the task. I have created a discord channel for all contributors, where we can have a more off-topic discussion and I'd like you to invite to it 😊, but it's not the right place here.


Update cpp-storefront-details-tab.md

The category and industry taxonomy structure for Azure Marketplace and AppSource is changing on 01/31/20. I am updating the marketplace publisher guide to make sure all sections are updated to the new taxonomy structure accordingly. Starting on 01/31/20, publishers will only be able to select a maximum of 2 categories and 2 sub categories and a maximum of 2 industry verticals per industry.

@feospina : Thanks for your contribution! The author(s) have been notified to review your proposed change. @v-miclar

@jborsecnik I am not working in the marketplace content. I can review this topic, but it will take some time for me to get the context, and I may not get it for some time.

@feospina - Microsoft authors and contributors need to make content contributions through the private repository so the content can be staged and validated by the current validation rules.
After you review staging and fix all validation issues, you can add the sign-off comment to let PR reviewers know that the updates are ready to be merged.
For more information, see Should I work in a private or a public repo?
If you need help getting set up to work in the private repo, see Set up Git repository locally for documentation.
In the future, would you create pull requests in the private repo? Thanks!
@MaggiePucciEvans - Could you review the proposed revisions?
Also, if author association for the content has changed, could you see that metadata is updated (via the private repo) so that automated author notification works correctly? Thanks very much.

Closing to create new private pull request


Custom Datasets + Module Loading Error

Can I use this framework on my own custom datasets?
Also, I'm experiencing an issue, when I try to run:
python gae/train.py
I get:
Traceback (most recent call last):
File "gae/train.py", line 12, in
from gae.model import GCNModelVAE
ModuleNotFoundError: No module named 'gae'
Yet this command works interactively.

Path works fine for me right now. Forgot to export the python path. Still need help with the custom dataset. Limited setup instructions.

I have a 30x30 adjacency matrix with some covariates. I'm looking to rebuild this adjacency matrix while being able to look at the latent space of the graph. Is that possible with this framework? I've been able to get node-level embeddings here, but nothing yet on the graph level.


Calendar/Schedule control

[ ] bug
[ X] feature request
[ ] enhancement
Expected behavior
Add a calendar/schedule control (like google calendar, outlook calendar, etc).

@pjtmatos do you mean a date/time picker? Does #121 cover your request/use cases and if not, what is different?

No, I mean an actual calendar/schedule.
Something similar to: http://angular-ui.github.io/ui-calendar/
The datepicker could be use in conjunction with to, for instance, select the month or day.

A full calendar control is probably not going to be of Clarity as a component anytime soon. It seems like a much more involved "project" vs. a component. Although it might make sense to build a "Clarity Calendar" as an open source project on top of Clarity, building within Clarity itself seems a lot more involved than a component within a design system especially with the fact that we're currently working on implementing date/time picker. Thanks for filing the issue and please feel free to share your feedback.


[$1000] Animation glitches on CTRL+shift+K shortcut after CTRL+K

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Press CTRL+K to open search
Press CTRL+shift+K to open new group menu and observe that app pushes whole content to left and search menu is partially visible for few seconds creating glitched animation

Expected Result:
Animation between keyboard shortcuts should be clean as it is when we press CTRL+K after CTRL+shift+K
Actual Result:
Animation glitches when we press CTRL+shift+K after CTRL+K
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.26-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/7874c5ad-7a6e-42c4-aa3a-4adfb6a552d7
https://github.com/Expensify/App/assets/43996225/fc74b66b-d17c-4c53-bff7-dfd0f7a3b424
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686136012478009
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d07caa1456efda56
Upwork Job ID:<PHONE_NUMBER>332894208
Last Price Increase: 2023-06-12

Proposal
Please re-state the problem that we are trying to solve in this issue.
Using consecutive alternations between CTRL+SHIFT+K and CTRL+K breaks the animation of the Right Modal. Also noticed that the order doesn't matter, you can start with either CTRL+K or CTRL+SHIFT+K  , as long as you use both and then try to repeat it will the animation. TLDR it breaks on A - B - A pattern.
What is the root cause of that problem?
The root cause of the problem is the Navigation type. I logged the Navigation types while trying to reproduce the issue and these were the logs:

CTRL+K -> action.type went from NAVIGATE to PUSH
CTRL+SHIFT+K -> action type remained NAVIGATE
CTRL+K -> action type remained NAVIGATE

While the action type was supposed to change to REPLACE, it remained as NAVIGATE, and the NAVIGATE type leads to that strange animation on the transition of the 2 shortcuts. The reason this happens is because this scenario doesn't meet the requirements for the below part of the navigation code to be triggered, located in linkTo.js:
  // If this action is navigating to the RightModalNavigator and the last route on the root navigator is also RightModalNavigator
            // then we want to replace the current RHP state with new one
        } else if (type === 'UP') {
            action.type = 'REPLACE';

As you can see, we only expect to do that when we call the navigation with the type being 'UP', which is used on native navigation stuff.
What changes do you think we should make in order to solve the problem?
We can create another case for our scenario here, and also check if the type is for example 'SHORTCUT' so we can make our action type into REPLACE and have a smooth transition.
Video of solution:
https://github.com/Expensify/App/assets/32620770/1c286cbd-9bd0-4c25-9e3f-a5bffa58b6e9

@WoLewicki @adamgrzybowski could you review the proposals on this issue please cc @abdulrahuman5196

@WoLewicki This is more or less in my proposal, we would check if RHP is already open to use REPLACE and discard the animation, unless I understood what you said incorrectly.

Yeah, it just depends how would you like to check if there is RHP already. Ideally it would be checked in e.g. linkTo.js or Navigation.js and based on the states produced.

Yeah, but we can navigate inside one of the flows in RHP, so we have to check if we would navigate at the top level of it with the newest action.

Alright that's a fair point, had to go out for a moment, will check that once I am back

@WoLewicki I noticed now that via the state (  const state = getStateFromPath(path); ) we can check the depth of the route, where we can see if we are going on an inner level or top level.

@Thanos30 have you been able to accommodate the feedback to your proposal?

@Thanos30 have you been able to accommodate the feedback to your proposal?

I believe so, yeah, I am just waiting for a confirmation on my latest comment concerning the depth of the route, to determine if we are heading to top level or inner level

Hi contributors, Thank you for the proposals. I got the idea of what the proposals are trying to do. But I will have to test it little bit extensively since it involves navigation and might affect other un-touched components as well. So I will test the proposals and let you know on the analysis in a day.
Just a note, if the root cause about new right root pages with animations clashing with each other is correct. I would also align with the comment here https://github.com/Expensify/App/issues/20621#issuecomment-1589215494 on to replace the existing right modal only when we have a different right modal page already shown and on other cases it should show up with animations as current experience.

@Thanos30 in linkTo.js, when calling getStateFromPath(path), it will give you the new state based on the path applied, so it has no information about the current state. Also, calling root.getState() will give you the whole current state, before the navigation happens. Based on this information, I think it should be easy to resolve if we are changing the route at the top level of RHP, or does it happen e.g. inside one of the RHP flows already. Could you test it and confirm that it is true? Also, do you need more help with implementing the needed changes?

cc @mountiny

@mountiny I did not update my proposal, we discussed the additions I should make to it and how I should approach the task. I can prepare an update for you if you want in a an hour once I am back home.

@Thanos30 that would be ideal, thanks

Sure. @Thanos30  Kindly ping once the solution is updated so that we can verify.

@WoLewicki @abdulrahuman5196 @mountiny Proposal is updated, thank you all!

@mountiny  It seems SWM(@adamgrzybowski ) is handling it part of https://github.com/Expensify/App/pull/21067
And I have been assigned as reviewer for that PR.
Should we proceed in the same path and remove this issue from external and I continue to review that PR?

thanks. this project has been led by SWM and their work is now to polish as many bugs from the navigation refactor as possible.
@Thanos30 I will offer you 25% of the bounty as is quite standard price in case someone has helpe us with the solution. I hope $250 works for you.
@adamgrzybowski @WoLewicki Thanks for raising a PR with the fix

@mountiny Of course, it's okay. Thank you for the compensation even if I wasn't assigned the job. 🙏
Should I apply for the job or will you create a new one?

@Thanos30 We will handle that once the PR is merged and deployed with all the other compensations if that work. Thanks for contributing and feel free to have a look at some other Help Wanted issues

Thank you @mountiny , on my way to hopefully apply for a C+ spot in the future 😄

This issue is in PR review Melvin.

PR merged will need one quick follow up

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

This issue was caused after the navigation refractor and fixed as part navigation refractor followups. So we can't point a single PR for this issue.

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Press CTRL+K to open search
Press CTRL+shift+K
New group panel should open smoothly without any shakes/glitches.

@adelekennedy
BZ checklist is complete here https://github.com/Expensify/App/issues/20621#issuecomment-1637691341
Payment processing is pending on this issue.

@abdulrahuman5196 thank you! Processing payment now

$250 for @Thanos30 for help with the proposal
$1000 to @abdulrahuman5196
$250 to @dhanashree-sawant
Thanks for paying this out @adelekennedy

Actually payment hasn't been processed yet.

@Thanos30 @abdulrahuman5196 @dhanashree-sawant please apply here: https://www.upwork.com/jobs/~01848cfeb779ada330

Applied @adelekennedy

Same here @adelekennedy , Thanks 🙏

Thanks @adelekennedy, I have also applied to the job.

Just pending @dhanashree-sawant payment

Thanks @adelekennedy, offer accepted.

Done!


Connection Properties Out of Sync

When a connection is established with an ACA-py agent and forwarded to the Controller via the POST /topic/connections/ HTTP/1.1 call, some properties are missing compared to the API call made to ACA-py to retrieve the same connection. This lack of synchronization between the two records requires the controller to make an additional call to the ACA-py agent to determine the connection state. This is important because, the Controller should not send messages as part of the connections/1.0 to the connection until it has entered the rfc23_state: completed state.
It's worth noting that ACA-py will send a POST to the controller every time the rfc23_state connection state changes. Usually, this means 3 POST requests. The controller must then check 3 times what was the state change to see if its safe to send a message.
Missing Fields

my_did
rfc23_state

Received Connection (POST)
{
  "state": "request",
  "created_at": "2023-09-22T16:47:14.292096Z",
  "updated_at": "2023-09-22T16:47:19.455361Z",
  "connection_id": "b3eef4a5-72a3-4c2d-a05e-ba8c88ab9f91",
  "their_did": "RkX8wYrnL5KAzjY3k6sswK",
  "their_label": "My Wallet - 5764",
  "their_role": "invitee",
  "connection_protocol": "connections/1.0",
  "invitation_key": "6bH4err7qHLPbd5iSLrz4Dfbnj7u7cavXuUncHYXP92H",
  "routing_state": "none",
  "accept": "auto",
  "invitation_mode": "once",
  "alias": "blarb7"
}

Fetched Connection (GET)
{
  "state": "response",
  "created_at": "2023-09-22T16:47:14.292096Z",
  "updated_at": "2023-09-22T16:47:19.483166Z",
  "connection_id": "b3eef4a5-72a3-4c2d-a05e-ba8c88ab9f91",
  "my_did": "9xwNP2m3BUsZuEBwiVCizc",
  "their_did": "RkX8wYrnL5KAzjY3k6sswK",
  "their_label": "My Wallet - 5764",
  "their_role": "invitee",
  "connection_protocol": "connections/1.0",
  "rfc23_state": "response-sent",
  "invitation_key": "6bH4err7qHLPbd5iSLrz4Dfbnj7u7cavXuUncHYXP92H",
  "routing_state": "none",
  "accept": "auto",
  "invitation_mode": "once",
  "alias": "blarb7"
}

Looks like an easy one.  @jleach — urgency on this one?  What are you hitting.
ASIDE — a rant: the state and rfc23_state items are a pain that I think we made worse by keeping them both.  IMHO What you are getting in this set of webhooks is information about the connection being established, vs. about the protocol that is used to create the connection. However, these webhooks are fired on the basis of the progress of the protocol used to create the connection, and for most protocols, the protocol information is what we need.  This was made worse when the two protocols (0160, 0023) used different states for essentially the same thing — for no reason.  It is perfectly reasonable to just use the state and expect it to always be the 0160 values.  It’s too bad we didn’t think that through more a few years ago… rant over
Regardless of the rant — we still need to convey the full data in the webhook, so the issue needs to be addressed.

@swcurran Low. The work around is to make an API call to the agent which is fine for now.

See work on #2434 .
That work doesn't explain why rfc23_state is not present in the webhook.
My best first guess is a logic gap in ConnRecord.State.rfc23strict
Note that above, the webhook is request... Would be interesting to see the payload when it hits response (as the GET state is response)... Check for logic the gap and check if subsequent payloads do return rfc23_state.

@jleach - since there are many ways to establish a connection, can you document how the above connection was made?

I can't seem to be able to replicate this with the faber/alice demo or with the mobile wallet. The webhook responses have the fields for all the states.
I do notice the fields missing in the wallet logs though. Perhaps it's an issue with the @aries-framework/core npm package and not acapy?
I'm going to wait on additional context before spending more time on this.
Faber      | 2023-09-25 18:27:18,767 aries_cloudagent.core.event_bus DEBUG Notifying subscribers: <Event topic=acapy::record::connections::request, payload={'state': 'request', 'created_at': '2023-09-25T18:26:18.676041Z', 'updated_at': '2023-09-25T18:27:18.764881Z', 'connection_id': '5b25f3f6-14e7-444f-aeba-b57ce3e40aad', 'their_did': 'GWb3cn23jxQrUs4oKcqQ4Y', 'their_label': 'My Wallet - 6241', 'their_role': 'invitee', 'connection_protocol': 'connections/1.0', 'rfc23_state': 'request-received', 'invitation_key': 'CrG9FxptMUFbHykksiFFRgfPuWA9irbZ82DgwSjUKzov', 'accept': 'auto', 'invitation_mode': 'once'}>
Faber      | 2023-09-25 18:27:18,768 aries_cloudagent.transport.outbound.http DEBUG Posting to http://<IP_ADDRESS>:8022/webhooks/topic/connections/; Data: {"state": "request", "created_at": "2023-09-25T18:26:18.676041Z", "updated_at": "2023-09-25T18:27:18.764881Z", "connection_id": "5b25f3f6-14e7-444f-aeba-b57ce3e40aad", "their_did": "GWb3cn23jxQrUs4oKcqQ4Y", "their_label": "My Wallet - 6241", "their_role": "invitee", "connection_protocol": "connections/1.0", "rfc23_state": "request-received", "invitation_key": "CrG9FxptMUFbHykksiFFRgfPuWA9irbZ82DgwSjUKzov", "accept": "auto", "invitation_mode": "once"}; Headers: {'Content-Type': 'application/json'}

I might not be testing this correctly though. I'd like to check it by doing the websocket messages one at a time instead of using the alice/faber demo and bifold.


cannot import name escape

Hi
I get this error when running python2.7 safaribooks.py
Traceback (most recent call last):
File "safaribooks.py", line 12, in
from html import escape
ImportError: cannot import name escape
pip list | grep html
html                                   1.16
requests-html                          0.2.2
What package am i missing?
Regards,
Kevin

i am finding the same issue

https://en.wikipedia.org/wiki/RTFM ?
Maybe you missed the manual: https://github.com/lorenzodifuccia/safaribooks/blob/master/README.md
Read comprehension test question:

What does the author tell you about python version 2?
Does the author mention any other python version than 2?

Hi I'm suddenly getting this error:
has anything happened to flask3.9, \Python\Python39\lib\site-packages\flask_init_.py", line 14, in
from jinja2 import escape
ImportError: cannot import name 'escape' from 'jinja2'

Hi @sbulink ,
I am in the same situation.
But I found out that it seems to come from MarkupSafe package.
Try downgrading to v1.1.1, it works for me.

Hi I'm suddenly getting this error: has anything happened to flask3.9, \Python\Python39\lib\site-packages\flask__init__.py", line 14, in from jinja2 import escape ImportError: cannot import name 'escape' from 'jinja2'

@sbulink I had the same issue and I downgraded my jinja2 version to 3.0.3 then it works to me.

Hi @oOhyeahh , I tried updating to jinja2==3.0.3 and it worked!


doc: remove fix_text script

The LaTeX build succeeds without the fix_tex.py script, so remove it.
The file actually mentions ".tex file produced by doxygen", so it may
not be relevant for Sphinx after all.

Typo: fix_tex, not fix_text

Typo: fix_tex, not fix_text

fixed, thx

Did you verify the output without this fix being applied? The fix does not seem to be related to a build failure, rather a layout issue.

Did you verify the output without this fix being applied? The fix does not seem to be related to a build failure, rather a layout issue.

I've just checked, and the script does exactly 0 replacements on the tex file, so it effectively does nothing to it.

The fix does not seem to be related to a build failure

Are you sure? It looks like the regular expression is fixing a runaway argument, which would be a syntax error in .tex, although it's doing it in a way that seems to throw away some information.
But that said, if the error is gone, no need for the 'fix'.

Are you sure? It looks like the regular expression is fixing a runaway argument, which would be a syntax error in .tex, although it's doing it in a way that seems to throw away some information.

No, I am not sure, just asking to double check the output so we do not get any surprises with the PDF output after removing this.
The commit message for this fix:
commit 9945e7fda0ac81a4f343fc040828bad3f0494c2d
Author: Daniel Leung<EMAIL_ADDRESS>Date:   Thu Aug 23 11:11:11 2018 -0700

    doc: add ability to generate PDF

    This adds new targets to generate build documentation through
    LaTEX to PDF.

    There are a few notes:

    1. pdflatex complains about the tex file generated by doxygen
       so it needs to be fixed with a Python script before feeding
       in through pdflatex.

so, if there are no complaints and the output is sane, all is good.

so, if there are no complaints and the output is sane, all is good.

Since the output is not causing a latex error anymore and the script has no effect, I think that it should be safe to merge this.


adding server adress makes it stop listening for redis

As soon as i add
"redis": {
			"port": "6397",
			"host": "http://localhost"
		},

The port and host part in redis section I no longer get Listening for Redis events when starting server..
why is this?
My full config file looks like this:
{
	"appKey": "omitted",
	"authHost": "example.com",
	"authEndpoint": "/broadcasting/auth",
	"database": "redis",
	"databaseConfig": {
		"redis": {
			"port": "6379",
			"host": "http://<IP_ADDRESS>"
		},
		"sqlite": {
			"databasePath": "/database/laravel-echo-server.sqlite"
		}
	},
	"devMode": false,
	"host": "exxample.com",
	"port": "6001",
	"referrers": [],
	"socketio": {},
	"sslCertPath": "",
	"sslKeyPath": ""
}

and when i start it it states:
L A R A V E L  E C H O  S E R V E R

Starting server...

✔ Running at example.com on port 6001
✔ Channels are ready.
✔ Listening for http events...

what am I missing?

I just had this same issue, and managed to fix it.
Remove the "http://" from your host line. I have no idea why they put that there in the documentation. It isn't correct.


Get package.json version number from an origin.js instance

origin.version now gives you the npm/package.json version number.
Closes https://github.com/OriginProtocol/origin-dapp/issues/399

@franckc i believe our process has been to delete branches after they're merged

@joshfraser Ah yep, my bad. I forgot to do so after merging this PR. Thanks for catching this !


It is not possible to replace the nabber logo.

Question
Answer

Issue or Enhancement
Issue

Laravel Version
9

Project Version
3

Current Behavior
I am having problems trying to change the default logo image in nabber.
When I replace the AdminLTELogo.png image with a completely different image but keeping the name AdminLTELogo.png, the original default image is still displayed in AdminLTE.
When I want to use another image file name for example mynewlogo.png and I replace its path in the adminlte.php file ( 'logo_img' => 'vendor/adminlte/dist/img/mynewlogo.png) the browser does not recognize the image even if the file exists in the stipulated folder.
Expected Behavior
the image I have changed should appear in the browser.
Steps to Reproduce
1: go to the adminlte.php file located in the config folder
2: Locate the following line: 'logo_img' => 'vendor/adminlte/dist/img/AdminLTELogo.png',
3: Replace "AdminLTE.png" with the name of the new image file, or rename the new image file to "AdminLTELogo1.png" and replace it with the existing file in the vendor/adminlte/dist/img/ folder of your project.
4: Reload your browser

Are you making the changes inside public/vendor/adminlte/dist/img or in vendor/almasaeed2010/adminlte/dist/img/? Note the logo should be somewhere within the public folder.
Another reason may be because of the execution of php artisan config:cache, after that any configuration change won't have any impact. If that's your case, just run php artisan config:clear and be careful when using the cache commands on a development environment.

thank you very much for your answer, I was doing something wrong I was placing it in the directory: vendor/almasaeed2010/adminlte/dist/img/.
I have placed it in the directory: public/vendor/adminlte/dist/img and it works correctly.
I have a question about what is the directory: vendor/almasaeed2010/adminlte/dist/img/ used for?

All that is inside the vendor folder is a dependency of your Laravel application. This package requires the ColorlibHQ/AdminLTE package, and it is downloaded there when you execute composer install or composer update. Then, in the installation process of this package, some files are copied from the AdminLTE downloaded package to the public folder in order to use they.


Please clarify what licenses are needed exactly

It is very unclear for me what licenses every user needs for the Identity Governance.

Could there be clarifications on what users need P1, P2 or Governance license? Administrators that configure need a P2 or Governance license, but what about users that will make use of an ID Governance feature?

What about external users? Are they out of scope for these licenses or do we need to bring on a license for every external user?

Kind regards,
Gilles Ijsebaert

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c48d98ed-5170-140d-59cc-344c755311cc
Version Independent ID: 0ace47ad-ae37-5b99-0bc0-63f0d05f8ed6
Content: Microsoft Entra ID Governance licensing fundamentals - Microsoft Entra
Content Source: articles/active-directory/governance/licensing-fundamentals.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@gijsebaert
It would be great if you could add a link to the documentation you are following for these steps? This would help us redirect the issue to the appropriate team. Thanks!!

Ofcourse, it can be found over here!
I was to quick, I'm sorry for that!
https://learn.microsoft.com/en-us/azure/active-directory/governance/licensing-fundamentals
Met vriendelijke groeten,
Cordialement,
Kind regards,
Gilles Ijsebaert

From: Saibaba Balapur Hireka @.>
Sent: Friday, October 6, 2023 7:08:06 PM
To: MicrosoftDocs/azure-docs @.>
Cc: Gilles Ijsebaert @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-docs] Please clarify what licenses are needed exactly (Issue #115702)
You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification
@gijsebaerthttps://github.com/gijsebaert
It would be great if you could add a link to the documentation you are following for these steps? This would help us redirect the issue to the appropriate team. Thanks!!
—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/115702#issuecomment-1751122317, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARDRHJ5AD5N77E774ZFQ4W3X6A3HNAVCNFSM6AAAAAA5V3UVYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJRGEZDEMZRG4.
You are receiving this because you were mentioned.Message ID: @.***>
[https://sirus.be/sirus_afbeeldingen/2020/03/logo-sirus-4.png]
Gilles Ijsebaert
+32 485 22 99 29tel:+32 485 22 99 29 | https://www.sirus.be
SIRUS
Delivering Smart Innovation | IoT and Cloud Solutions
Verlorenbroodstraat 122 bus 8, 9820 Merelbekehttps://goo.gl/maps/SMtDTHKW6bk
Reiger II, Eurostraat 1, 3500 Hasselthttps://goo.gl/maps/jymbYjQQThT6D2Cv8
Eolis Building, Sq. Sainctelette 15, 1000 Bruxelles
The Beacon, Sint-Pietersvliet 7, 2000 Antwerpenhttps://goo.gl/maps/F4VTcCNiymXU2q9R6
Dit bericht (inclusief de bijlagen) kan vertrouwelijk zijn. Als u dit bericht ten onrechte hebt ontvangen, wordt u verzocht de afzender te informeren en het bericht te wissen. Het is niet toegestaan om dit bericht, geheel of gedeeltelijk, zonder toestemming te gebruiken of te verspreiden. SIRUS sluit elke aansprakelijkheid uit wanneer informatie in deze e-mail niet correct, onvolledig of het niet tijdig overkomt, evenals indien er schade ontstaat ten gevolge van deze e-mail. SIRUS garandeert niet dat het bericht vrij kan zijn van onderschepping of manipulatie daarvan door derden of computerprogramma’s die worden gebruikt voor elektronische berichten en het overbrengen van virussen.

@gijsebaert Regarding the licenses required for users, creating eligible authorizations requires an Enterprise Mobility + Security E5 (EMS E5) or Azure AD Premium P2 license. The EMS E5 or Azure AD Premium P2 license must be held by the managing tenant, not the customer tenant.
Any extra costs associated with an eligible role will apply only during the period of time in which the user elevates their access to that role.
For more information about licenses for users, you can refer to the following document. License requirements to use Privileged Identity Management.
Since this issue isn't directly related to improving our docs, and to gain a better understanding of your issue, I'd recommend working closer with our Q&A forum by posting your issue there so our community, and MVPs can further assist you in troubleshooting this issue or finding potential workarounds. Teams Q&A forum for technical questions about the configuration and administration of Microsoft Teams on Windows.Microsoft Teams Community forum.
I hope this helps! Let me know if you have any other questions.


1 Test fails: test\recipes\80-test_ssl_new.t (Test 12 Failed) in 1.1.1o

Downloaded OpenSSL 1.1.1o from openssl.org and build myself. Followed the same procedure that I've followed with previous builds and all tests always pass. This time, 1 test failed, curious if its a build issue, a bug or I need to update some config parameter?
Enabled features:
```
aria
asm
async
autoalginit
autoerrinit
autoload-config
bf
blake2
camellia
capieng
cast
chacha
cmac
cms
ct
deprecated
des
dgram
dh
dsa
dso
dtls
ec
ec2m
ecdh
ecdsa
engine
err
filenames
gost
hw(-.+)?
makedepend
md4
mdc2
multiblock
nextprotoneg
pinshared
ocb
ocsp
pic
poly1305
posix-io
psk
rc2
rc4
rdrand
rfc3779
rmd160
scrypt
seed
siphash
sm2
sm3
sm4
sock
srp
srtp
sse2
ssl
static-engine
stdio
tests
threads
tls
ts
ui-console
whirlpool
tls1
tls1-method
tls1_1
tls1_1-method
tls1_2
tls1_2-method
tls1_3
dtls1
dtls1-method
dtls1_2
dtls1_2-method
```

Test Output
```
test\recipes\80-test_ssl_new.t .................. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/29 subtests

Test Summary Report
-------------------
test\recipes\80-test_ssl_new.t                (Wstat: 256 Tests: 29 Failed: 1)
Failed test:  12
Non-zero exit status: 1
Files=158, Tests=2329, 230 wallclock secs ( 0.92 usr +  0.23 sys =  1.16 CPU)
Result: FAIL
NMAKE : fatal error U1077: 'C:\Perl64\bin\perl.exe' : return code '0x1'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual
Studio\2017\Professional\VC\Tools\MSVC\14.16.27023\bin\HostX86\x86\nmake.exe"' : return code '0x2'
Stop.
```

Closed as duplicate of #18456


chore: remove fedimint-ui/ repo

Admin UIs live at https://github.com/fedimint/ui now

I think it's alright to remove


Add Nvd3 Dependency to fix UI / Dashboard

This PR fixes #796 :)
/cc: @containous/traefik

any eta on this? :)

What do you mean by eta? This PR was submitted yesterday...

more on merging it in :)

It will be merged for the 1.1 release :)

LGTM! Thanks @santode


Imports only used in docs

When an import is only used in square brackets in the docs it will get removed by ktlint. For example:
package com.example

import android.provider.CalendarContract.Colors

/**
 * [Colors]
 */
class Foo

will become:
package com.example

/**
 * [Colors]
 */
class Foo

IntelliJ itself shows the import as used (or not as unused).

@gabrielittner Thank you! I'll take care of it.

On a second thought, it might be what we want. The thing is Foo class is not technically using Colors. It does reference it the docs but that doesn't mean that Foo has hard (compile) dependency on Colors. Kotlin supports alternatives that don't require imports:
[Colors](android.provider.CalendarContract.Colors)

[android.provider.CalendarContract.Colors]

What do think?

I'm not sure what's the best solution here. In the case where I've run across it, the imported class is used a ton in the docs and using it without import adds a lot of noise. If yo decide to keep removing the import it would be nice to at least get a warning or something, because without the import all the links will be broken.

I'm running into the same issue and I'd prefer if the import would be allowed in this case for the same reason. It would add a lot of noise to reference the full path everywhere.

@gabrielittner @vRallev fair enough. Fixed in 0.7.1 (Maven Central sync might take up to ~25 minutes). :tada:

The new version works nicely. Thanks!

Also working here. Thank you


Crashes under random circumstances in Chrome "Cannot read property 'exp' of undefined" [patch proposed]

My Chrome browser (versions 52.0.2743.106 m to 52.0.2743.116 m on windows 10) broke ng-file-upload with the following exception and html code before even uploading a file (uploading didnt work either). My friend's computer which had the exact same code and Chrome version but Windows 7 didn't cause the exception. Both computers with Windows 10 or Edge or Firefox worked, I could only reproduce this on my setup:
angular.js:13295 TypeError: Cannot read property 'exp' of undefined
at watchFnToHumanReadableString (<anonymous>:703:19)
at Scope.$delegate.__proto__.$watch (<anonymous>:735:28)
at linkFileSelect (http://emblim.localhost/resources/js/libs/ng-file-upload.js:731:26)
at link (http://emblim.localhost/resources/js/libs/ng-file-upload.js:910:7)
at invokeLinkFn (http://emblim.localhost/resources/js/libs/prerequisites/angular.js:9526:23)
at nodeLinkFn (http://emblim.localhost/resources/js/libs/prerequisites/angular.js:8933:27)
at compositeLinkFn (http://emblim.localhost/resources/js/libs/prerequisites/angular.js:8261:31)
at compositeLinkFn (http://emblim.localhost/resources/js/libs/prerequisites/angular.js:8264:31)
at nodeLinkFn (http://emblim.localhost/resources/js/libs/prerequisites/angular.js:8928:38)
at compositeLinkFn (http://emblim.localhost/resources/js/libs/prerequisites/angular.js:8261:31)

<input type="file" class="form-control form-control-file ng-pristine ng-untouched ng-valid" ngf-select="" ng-model="ACECtrl.eventImage" name="eventImage" ngf-max-size="2MB" ngf-pattern=".jpg,.png,.jpeg" ngf-model-invalid="errorBannerFile">

However reading the code, it seems that this should be patched for everyone, because they may not be using the below attributes. Adding these if statements around attribute getters from lines 730 on version 12.0.4 unminified fixed the above issue. Sorry we are working to time/budget and I don't have time to submit a diff or search the issues page to see if this is an existing issue:
    var unwatches = [];
    if (attrGetter('ngfMultiple')) {
        unwatches.push(scope.$watch(attrGetter('ngfMultiple'), function () {
            fileElem.attr('multiple', attrGetter('ngfMultiple', scope));
        }));
    }
    if (attrGetter('ngfCapture')) {
        unwatches.push(scope.$watch(attrGetter('ngfCapture'), function () {
            fileElem.attr('capture', attrGetter('ngfCapture', scope));
        }));
    }
    if (attrGetter('ngfAccept')) {
        unwatches.push(scope.$watch(attrGetter('ngfAccept'), function () {
            fileElem.attr('accept', attrGetter('ngfAccept', scope));
        }));
    }

thanks a lot the same issue

Nice can you do a PR to original repositories?


[WIP][SPARK-36352][SQL][3.0] Spark should check result plan's output schema name

What changes were proposed in this pull request?
Spark should check result plan's output schema name
Why are the changes needed?
In current code, some optimizer rule may change plan's output schema, since in the code we always use semantic equal to check output, but it may change the plan's output schema.
For example, for SchemaPruning, if we have a plan
Project[a, B]
|--Scan[A, b, c]

the origin output schema is a, B, after SchemaPruning. it become
Project[A, b]
|--Scan[A, b]

It change the plan's schema. when we use CTAS, the schema is same as query plan's output.
Then since we change the schema, it not consistent with origin SQL. So we need to check final result plan's schema with origin plan's schema
Does this PR introduce any user-facing change?
No
How was this patch tested?
existed UT

FYi @cloud-fan

Test build #142560 has started for PR 33764 at commit be57420.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47063/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47063/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47063/

Test build #142560 has finished for PR 33764 at commit be57420.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142560/

retest this please

Test build #142737 has started for PR 33764 at commit be57420.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47237/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47237/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47237/

Test build #142737 has finished for PR 33764 at commit be57420.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142737/


Problem with "Webpack 5" & "Module Federation" & "license-webpack-plugin" in Angular 11.2 & 12.0.0@next

I Created an application with Webpack5 and  Webpack Module Federation. It works with Angular 11.0.3 but with Angular 11.2 & 12.0.0@next  I have a problem with  license-webpack-plugin.
Error log:

[error] HookWebpackError: ENOENT: no such file or directory, open '\package.json'
    at makeWebpackError (D:\MyGit\narik-pluggable-dashboard-sample\node_modules\webpack\lib\HookWebpackError.js:49:9)
    at D:\MyGit\narik-pluggable-dashboard-sample\node_modules\webpack\lib\Compilation.js:2383:12
    at eval (eval at create (D:\MyGit\narik-pluggable-dashboard-sample\node_modules\tapable\lib\HookCodeFactory.js:33:10), <anonymous>:29:1)
    at fn (D:\MyGit\narik-pluggable-dashboard-sample\node_modules\webpack\lib\Compilation.js:373:17)
    at _next4 (eval at create (D:\MyGit\narik-pluggable-dashboard-sample\node_modules\tapable\lib\HookCodeFactory.js:33:10), <anonymous>:26:1)
    at eval (eval at create (D:\MyGit\narik-pluggable-dashboard-sample\node_modules\tapable\lib\HookCodeFactory.js:33:10), <anonymous>:45:1)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
-- inner error --
Error: ENOENT: no such file or directory, open '\package.json'
    at Object.openSync (fs.js:458:3)
    at Object.readFileSync (fs.js:360:35)
    at CacheBackend.provideSync (D:\MyGit\narik-pluggable-dashboard-sample\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:233:32)
    at WebpackFileSystem.readFileAsUtf8 (D:\MyGit\narik-pluggable-dashboard-sample\node_modules\license-webpack-plugin\dist\WebpackFileSystem.js:52:24)
    at PluginChunkReadHandler.getPackageJson (D:\MyGit\narik-pluggable-dashboard-sample\node_modules\license-webpack-plugin\dist\PluginChunkReadHandler.js:35:43)
    at PluginChunkReadHandler.processModule (D:\MyGit\narik-pluggable-dashboard-sample\node_modules\license-webpack-plugin\dist\PluginChunkReadHandler.js:45:40)
    at D:\MyGit\narik-pluggable-dashboard-sample\node_modules\license-webpack-plugin\dist\PluginChunkReadHandler.js:29:23
    at WebpackModuleFileIterator.internalCallback (D:\MyGit\narik-pluggable-dashboard-sample\node_modules\license-webpack-plugin\dist\WebpackModuleFileIterator.js:28:13)
    at WebpackModuleFileIterator.iterateFiles (D:\MyGit\narik-pluggable-dashboard-sample\node_modules\license-webpack-plugin\dist\WebpackModuleFileIterator.js:8:9)
    at D:\MyGit\narik-pluggable-dashboard-sample\node_modules\license-webpack-plugin\dist\PluginChunkReadHandler.js:27:32

It seems that with Angular 11.0 Licence Extraction has been disabled,
Warning: License extraction is currently disabled when using Webpack 5. This is temporary and will be corrected in a future update.
but with Angular 11.2 and next, license-webpack-plugin cannot load package.json because directory has not been specified on the module.
You can find sample repo here

Hi @abadakhshan,
Thanks for opening this issue.
Please note that Angular CLI doesn't support custom Webpack configurations. @angular-architects/module-federation and @angular-builders/custom-webpack are 3rd party solutions which are supported by the Angular tooling team.
That said, this appears to be a bug in license-webpack-plugin,  Please file an issue on their issue tracker.


Update to jupyterlab manager 0.29

Coverage remained the same at 61.714% when pulling 47883b0689318addae9862dbaee44522510c5e69 on SylvainCorlay:jlab-0.29 into a24d5ece55c4b36ebd962fe062daecc80dbece99 on maartenbreddels:master.

Coverage remained the same at 61.714% when pulling 2800a1d7ae27b708375595d1557d66cfc07ed157 on SylvainCorlay:jlab-0.29 into a24d5ece55c4b36ebd962fe062daecc80dbece99 on maartenbreddels:master.

Coverage remained the same at 61.714% when pulling 2800a1d7ae27b708375595d1557d66cfc07ed157 on SylvainCorlay:jlab-0.29 into a24d5ece55c4b36ebd962fe062daecc80dbece99 on maartenbreddels:master.

Coverage remained the same at 61.714% when pulling 2800a1d7ae27b708375595d1557d66cfc07ed157 on SylvainCorlay:jlab-0.29 into a24d5ece55c4b36ebd962fe062daecc80dbece99 on maartenbreddels:master.

Seems to be working.

Coverage remained the same at 61.714% when pulling ad2adc872d20e3390294e971b315db90a0e6bab2 on SylvainCorlay:jlab-0.29 into a24d5ece55c4b36ebd962fe062daecc80dbece99 on maartenbreddels:master.

Hey sorry, forgot about this PR, would have saved me from doing this work!


Fix line ending issue

The tool previously incorrectly extracted episode numbers when the string ended with a carriage return and line feed, which led to the accuracy dropping from 99% to 97%. I believe this is a Windows issue as Windows has different line endings than Linux.

I've been assuming the input string has all non-printable characters removed before calling the function. But it seems fine handling that within the library, thanks. 🥰


chore: hotfix comma in package json

:tada: This PR is included in version 2.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Revert back SSL

Is there a command to switch back from SSL to http?

Hello @romapad,
Not in ee-acme-sh, but to disable SSL/TLS,  you just have to rename/remove the files :

ssl.conf in /var/www/yourdomain/conf/nginx
force-ssl-your.domain.tld.conf in /etc/nginx/conf.d


added branch-name, label, no-label, and title CLI params

Sample usage:
--branch-name pull-requests-combined
--label yes,no,maybe
--no-label
--title "Where Prs are combined"

Notes

The few things I moved were to sort things alphabetically.
--label and --no-label should be exclusive, but I didn't add that logic in.

@rnorth Could you merge this PR? It would be really helpful 🙇


rename examples package to fix dependabot

At the moment dependabot fails to run on the repo with the following error:
Dependabot encountered the following error:

error: failed to load manifest for workspace member `/home/dependabot/dependabot-updater/dependabot_tmp_dir/examples`

Caused by:
  failed to parse manifest at `/home/dependabot/dependabot-updater/dependabot_tmp_dir/examples/Cargo.toml`

Caused by:
  the binary target name `examples` is forbidden, it conflicts with with cargo's build directory names

From testing locally using the dependabot CLI, changing the package name to pyo3-examples in examples/Cargo.toml appears to resolve.

Looks like the merge queue hit the timeout of 1 hour; I'll double it to two for now, though that's not a great long-term solution.


Update writer.rb

[ ] I've added tests (if it's a bug, feature or enhancement)
[ ] I've adjusted the documentation (if it's a feature or enhancement)
[ ] The test suite passes (run bundle exec rspec to verify this)

Summary
Fixes https://github.com/boltops-tools/terraspace/issues/284
How to Test
Version Changes
patch

Thanks for the PR! 😄
Ran the terraspace acceptance tests pipeline on it. Annoyingly, this slight change breaks terraspace all 🤦🏻♂
Pipeline with boltops-tools master (passes)

Pipeline with johnlister fork (fails)

Took a look at the terraspace all codebuild logs and sadly it didn't help much. Will have to try to improve the TSC logging when get a chance.

Will have to dig into this more when get a chance. Here's the build script https://github.com/boltops-tools/terraspace/blob/master/.cody/all/bin/build.sh The particularly test checks that https://github.com/boltops-tools/terraspace-graph-demo still works.  Will have to just clone it down locally and test to investigate further.

I'll have a look, to be honest didn't run terraspace all locally after applying it. Suspect something relies on an empty file?

RE: Suspect something relies on an empty file?

Guessing the same thing.

Odd, just ran it locally on my branch and it succeeded - only change I made to the demo graph was to use a local backend, applied the change to your latest master branch and it failed, but re-running a second time passed.  Couldn't see any empty files in the demo... Will re-look later

Bummer 😒 Thanks for the update.

Ran the pipeline again and it passed this time. It may be something intermittent 🤦🏻♂  Merging as-is.

Released in 2.2.3


Mikenowak features

Adding support for enabling/disabling image features via dism.
Features can be specified in an array.
Quite useful for getting rid of Inbox Games and other questionable items.

@mikenowak Thank you very much


Xspec fixes

I've fixed the xspec settings commands that were broken. I made the cosmology settings more user-friendly.
I have added more models to the finite difference table. We still may be missing some. I will add some xspec docs to 3ML.

@grburgess  is this still relevant or shoud we close this?

@giacomov this needs to be merged for sure. It fixes some typo issues and access to all of xspec's "global" parameters


Add test coverage for JavaConversions, JavaConverters and ScalaFutures

Coverage increased (+1.005%) to 75.879% when pulling ad5ba9c4263bb8d357c55343c46ad8b5aea3592e on sergius:master into 63b68206c04dde8f3bf860094e1aa20e3470908f on gilt:master.

Coverage increased (+3.9%) to 78.788% when pulling 8f506fcfc5437bb1da28ca0d296cfb5f62e3acc8 on sergius:master into 9b868d58c6059fbedcdc4642c8826fb308a0138a on gilt:master.

Needed to remove a test. See #31.


Port code snippets to the 2018 edition

All the code snippets must be using 2018 edition features and must compile on 1.30-beta by RC1.

@japaric For clarification, I assume this means both the in tree src (.rs files) as well as the examples scattered in the guide itself in Markdown code blocks?

Yes, I actually meant all the source code.


[BUG] OpenBullet + XEvil bug

Hello.
I really don't know if it's a bug, but I really hope you can help me.
I'm using Openbullet and XEvil, and at the beginning everything was great, I solved captchas very fast, and I had my own proxy service.
While testing some account combos, I noticed that OpenBullet got stuck on "bad: 72". which I found very strange. I checked XEvil, but I saw that it was still resolving the catpchas, and giving them as good, only in OpenBullet, it didn't appear as if it had been an attempt. I restarted all programs, restarted my computer, but none of this worked. Now when I try to put a combolist, XEvil says it is solving captchas, but in OpenBullet.... Not a trace
I know it's a bit confusing, that's why I'll also leave a video so you can see what I mean.
https://www.youtube.com/watch?v=P1ZyTlEikr8
I would appreciate any help. Thank you very much!
PD: I have also tried revisiting the host file, deleting the XEvil parameters and creating them again, and none of this works.

I do not provide any more support for OB1, sorry. Please switch to OB2.

Also I saw that you're performing illegal activity, I'm deleting this issue.


Cannot change school CSV location in segue-config.properties

Because Guice loads it in two different places:

https://github.com/ucam-cl-dtg/isaac-api/blob/master/src/main/java/uk/ac/cam/cl/dtg/segue/configuration/SchoolLookupConfigurationModule.java#L67
https://github.com/ucam-cl-dtg/isaac-api/blob/master/src/main/java/uk/ac/cam/cl/dtg/segue/configuration/SegueGuiceConfigurationModule.java#L185

This shouldn't really be the case, it should only be loaded in once place. In fact, it works as long as the two places load the same value into Guice. Because of #75, if the value is changed in a custom server config, but not in the compiled-in template config, everything explodes.
Stop loading this value twice.

This seems to be working after a code refactor!


The Ctrl / Cmd + Enter shortcut doesn't trigger the completion modal in the RWD projects

Describe the Issue
A learner on Twitter pointed out that using the Ctrl / Cmd + Enter shortcut to run the tests for the RWD projects doesn't trigger the completion modal.
Clicking the "Run the Tests (Ctrl + Enter)" button triggers the modal as expected if all the tests pass. But using the keyboard shortcut just runs the tests, and the shortcut has to be used again to actually submit the code in the editor as a solution and move on to the next challenge.
Affected Page
All RWD project pages
Steps to Reproduce

Go to one of the RWD projects like Build a Survey Form
Enter a valid solution (can use code from the demo repo here for testing: https://github.com/freeCodeCamp/demo-projects/tree/master/apps/survey-form)
Use the Ctrl / Cmd + Enter shortcut to run the tests
Check the tests pane to see that all the tests have passed, but the completion modal is absent
Submit the project code

Use the Ctrl / Cmd + Enter shortcut again
Or click the "Run the Tests (Ctrl + Enter)" button to trigger the completion modal, then click the "Submit and go to next challenge (Ctrl + Enter)" button, or use the Ctrl / Cmd + Enter shortcut

Expected behavior
The Ctrl / Cmd + Enter shortcut should trigger the completion modal like clicking the "Run the Tests (Ctrl + Enter)" button does.
System

Device: Laptop
OS: Linux Mint 20.3
Browser: Chrome (102.0.5005.61), Firefox (101.0)

Related: https://github.com/freeCodeCamp/freeCodeCamp/pull/43728


Major changes: Add System Theme Mode, Color Preferences, Accessibility and more!

Intro
Thanks for the great component @JoseRFelix ! I've been using it on all my projects and I really like the design and animations of this toggle. In particular, the fact its a single icon with no background clutter.
I have been making various edits to the component for my own needs and decided to contribute the changes back to the community. I am happy to take in feedback and make further changes to address any concerns.
Overview
This PR is huge and lots of changes have been made in one go.

Bump package version to 2.0.0 (due to lots of breaking changes that are not backwards compatible)
Update all dependencies to latest (notably React 18, Node 20, react-spring 9.7.4) (partially addresses #45)
Add support for System Theme Mode (fixes #47 ).
Improve color customisation capabilities. (fixes #40)
Add color blending into spring animations.
Improve styling in general (remove excess margin).
Change default style to be more visually appealing.
Revamp examples page to showcase examples with light and dark background.
Remove janky overshoot in animation when going from moon to sun.
Make component accessible by using button (fixes #23 , #32 ).
Add ability to programmatically trigger clicks via ref
Refactor code structure to use best practice (more files etc).
Add stronger typing support and types.
Add extra unit test for each theme mode
Github CI/CD workflow updates to use latest node & action versions
Update demo.gif
Update README

Demo (Examples)
https://github.com/user-attachments/assets/267204bc-1ba8-4d4d-8534-9697572809a1
Changes
System ThemeMode
There is a new third state in the 'toggle' for the System (or Auto) mode!

The design chosen was a half sun and half moon. This design was choses as it looks good and is easily understood. It can also animate well with the other existing sun and moon designs.
Color customisation
One common issue with the component was it was hard to customise the colors easily beyond the now removed sunColor and moonColor.
We now have the following optional colors props:
  halfSunLeftFill: string;
  halfSunLeftStroke: string;
  halfSunLeftBeamStroke: string;
  halfMoonRightFill: string;
  halfMoonRightStroke: string;
  halfMoonRightBeamStroke: string;
  sunFill: string;
  sunStroke: string;
  sunBeamStroke: string;
  moonFill: string;
  moonStroke: string;

This allows you to style each different theme mode however you like.
You can provide partial overrides or specify each color option.
If this prop is not provided, the default styling will be used.
API changes
There are breaking changes in the API that are not-backwards compatible.
export interface Props extends SVGProps {
  onChange: (themeMode: ThemeMode) => void;
  isSystemThemeModeEnabled?: boolean;
  themeMode: ThemeMode;
  style?: React.CSSProperties;
  size?: number | string;
  colors?: Partial<ColorOptions>;
  animationProperties?: AnimationProperties;
}

Changes include:

onChange now provides a ThemeMode and not a boolean
isSystemThemeModeEnabled is new prop that can control if the system theme mode is being used or not (defaults to true)
themeMode is now the prop to bind (replaces checked)
colors provides more configuration

isSystemThemeModeEnabled
This prop is new prop that can control if the system theme mode is being used or not (defaults to true).
If this is set to false, it results in the classic 2-state dark/light mode toggle with same animations as before (except with the janky overshoot removed).
Theme switch direction
The theme switch direction is:
System -> Dark -> Light
I found this cycle path to look the best animation wise.
The choice was made NOT to allow this to be configurable because the animations depend on the ordering. Maybe this can be changed in future PR if there is a need for it.
Single Color Mode
If using single color scheme (i.e. black), the system design and light mode design are identical and not distinguishable.
My recommendation is to not support this (and encourage using fills and/or strokes to try and distinguish the system theme mode). This is solved if you instead use 2 colors (black/white).
Issues
High prio

N/A

Low prio

If using single color scheme (i.e. black), the system design and light mode design are identical and not distinguishable.
Using yarn start in examples does not watch for changes in main package. Requires restart to detect changes.

Manual tests
Test on all browsers

Chrome: ✅
Firefox: ✅
Edge: ✅
IE11: ℹ
Safari: ℹ
Android: ℹ
iPhone: ℹ

Pre-merge TODOs

Get review and feedback
Manually test on all supported browsers
Netlify builds seem to be failing?

@JoseRFelix Hey mate, any chance of this getting merged? I know its a lot of changes. Thanks!


LLC: Reference docs for protocol methods are not sufficient

See https://docs.microsoft.com/en-us/dotnet/api/azure.analytics.purview.account.purviewaccountclient.updateaccountproperties?view=azure-dotnet-preview#Azure_Analytics_Purview_Account_PurviewAccountClient_UpdateAccountProperties_Azure_Core_RequestContent_Azure_RequestOptions_
Protocol methods require the caller to know the schema of the body payload. The current docs (link above) are show the schema in a format that is impossible to understand.

Closing as duplicate of https://github.com/Azure/azure-sdk-for-net/issues/28833


Updated typo of "SLB has no SLA"

Updated typo of "SLB has no SLA" to "The Basic SKU LB has no SLA"

@jalithlal : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

#sign-off

@mamccrea: I'm sorry - only the author of this article, @sukanyamsft, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Pinch to zoom image editor doesn't work on safari

Testing #83296
Repo

Using Safari
Open an image editor
Try to pinch to zoom in

Bug
The entire webpage zooms

We are setting this in our HTML to prevent pinch zooming:
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0, user-scalable=no">
Possible that if you are pinch-zooming into an iframe the rule is disabled. Maybe you need to add something like that too?

Hmm, I think that used to work but now safari may ignore user-scalable=no (I know safari on iOS ignores this setting). Even with that tag I can still pinch to zoom the entire workbench
We may have to intercept touch events to block the browser level zoom in safari

Yeah I noticed this too, but when I added the web to home screen (I guess that means doing PWA on iPad) I could not pinch zoom anymore. So maybe that is working only in PWA mode?

I don't think it's possible to disable pinch zoom possible right now in iOS (accessibility concern) and desktop (based on my current testing). There are a few issues tracking in webkit like https://bugs.webkit.org/show_bug.cgi?id=145214 without any official response. CSS tricks like touch-action: none doesn't work as well, it can disable scrolling but can't disable pinch zoom.

Right now zoom works in an image editor but it zooms the whole workbench (looks like the zoom event bleeds), but if we focus on a monaco editor or just welcome page or watermark, it doesn't zoom at all.

@bpasero I think Pinch zooming on the iPad might make sense for accessibility reasons (easy way to zoom) so I will experiment with removing that user-scalable attribute.

Just make sure to not accidentally allow to pinch zoom on the desktop. We don't want people to zoom into parts of VSCode on desktop.

Right now zoom works in an image editor but it zooms the whole workbench (looks like the zoom event bleeds), but if we focus on a monaco editor or just welcome page or watermark, it doesn't zoom at all.

The same behavior is true in webview, which scales the whole workspace, although I didn't mean to scale the whole workspace.
There is also the forward and backward behavior of the trackpad or mouse, which will not be triggered in the workspace, but will also be triggered in the webview. Is this unexpected? @rebornix @mjbvz

Right now zoom works in an image editor but it zooms the whole workbench (looks like the zoom event bleeds), but if we focus on a monaco editor or just welcome page or watermark, it doesn't zoom at all.

The same behavior is true in webview, which scales the whole workspace, although I didn't mean to scale the whole workspace.
There is also the forward and backward behavior of the trackpad or mouse, which will not be triggered in the workspace, but will also be triggered in the webview. Is this unexpected? @rebornix @mjbvz


roxterm: 3.7.5 -> 3.11.1

Motivation for this change
3.7.5 segfaults a lot, I've been using 3.11.1 for a day and it hasn't crashed once
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] Tested, as applicable:
[x] Tested basic functionality of all binary files (usually in ./result/bin/)

Result of nixpkgs-review pr 145659 run on x86_64-linux 1

1 package built:

roxterm


Emacs: MELPA package updates

Melpa updates via update script
Motivation for this change
The current recipes-archive-melpa.json contains several "No space left on device" errors. Causing several packages to be broken. E.g. cmake-mode, erlang
This is the previous update:

https://github.com/NixOS/nixpkgs/pull/69212

I did run the following command to verify there are no such issues now:
grep 'No space' pkgs/applications/editors/emacs-modes/recipes-archive-melpa.json

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @adisbladis

I updated this before checking your PR, sorry about that.

No, worries, thank you :+1:


Wiki vandalism

Wiki footer

@ryannathans thank you for reporting that.
@gpsukgov @derekcorwin @TheJoaqun please grow up, yes it is possible to edit a public wiki, who would have guessed.


Improved graph-tool installation instructions

To install graph-tool via conda the actual commands are:
conda create --name gt -c conda-forge graph-tool
conda activate gt

The command currently given in the instruction will not work.
It might be good to inform users that they can install (without compilation) using homebrew in MacOS, and also in Ubuntu/Debian. The installation instructions are here: https://git.skewed.de/count0/graph-tool/-/wikis/installation-instructions

I recommend the following instructions.  FWIW, I tested these on my machine (a Mac) and successfully ran conftest.py.

schist has the following dependencies:

numpy
scipy
anndata
pandas
scanpy
graph-tool

Conda users can create an environment with all of them using the following commands:
conda create -n schist -c conda-forge -c bioconda numpy scipy anndata pandas graph-tool scanpy
conda activate schist

Non-conda users should obtain graph-tool via either apt-get or homebrew (see the graph-tool installation instructions), and then use pip for the remaining dependencies.
Since schist itself is not yet available on PyPI or anaconda.org, you must clone the git repo and install it from source.  Once you've installed the above dependencies, run the following commands:
git clone https://github.com/dawe/schist.git
cd schist
pip install .

Thanks for for the comments, I will update installation instructions.
I was thinking to provide a conda recipe for schist, but I never did that, give me time to study.


error with pre-commit

VSCode Version: 1.13.0
OS Version: OS X EI Capitan 10.11.4

Steps to Reproduce:

install pre-commit
commit with Source Control in VSCode

will show the error: Git: /Users/lxd/test/vscode/node_modules/eslint/node_modules/strip-bom/index.js:2

But when I commit in the terminal, It's ok.
why vscode lint in the node_modules? I try to add .eslintignore and add eslint --ignore-path .gitignore file.js, but still helpless
I create a project that show the case: https://github.com/stonelee/vscode-pre-commit-error

@stonelee this is not VS Code limiting. It is eslint trigger by the git hook. I am pretty sure that the same error appears if you lint in a terminal. To test this can you run eslint in a terminal to see which errors it produces.
I will close the issue since this is not related to the eslint support provided by VS Code. If you have questions you can still ping me in this issue.

in terminal, It's ok

use Source Control in VSCode, error happens

Reopening
@joaomoreno assigning to you since this is running eslint (the npm module) in a pre commit hook. It behaves differently when executing git from the terminal or from withing VS Code. Which cwd is git using when executing the pre commit hook from within VS Code. This could be a source of the problem.

@dbaeumer It's using the same cwd.

Process Hacker seems only run in windows, but mine is mac

Use htop then.


luci-app-asterisk: fix typo in package description

Signed-off-by: Jonathan McCrohan<EMAIL_ADDRESS>

thanks


forward domain added & skin added

Hi! What is your PR about?

[x] Add or edit a skin

[x] Add a custom domain for your space

[ ] Add an alias to migrate your space

@gokaiorg Kindly review the above fixes.

@gokaiorg Kindly review the above fixes.

There is a conflict in your PR since domains.json file has been updated, can you resolve it?
To prevent conflicts, it is recommended to add your subdomain between two existing domains rather than at the end or beginning of the list.

@gokaiorg We have resolved it. Please approve the same.


persistence_scalar_index limits

Adds .clip(lower=0, upper=2) to the clear sky index array before the average clear sky is computed. I think this is a reasonable approach, but I suppose others could disagree.
I considered adding keyword arguments to persistence_scalar_index to provide some flexibility for the user. A disadvantage of adding flexibility is that it means you have to be more explicit about the runtime configuration of a reference forecast.
What do you think @cwhanse @alorenzo175?
closes #107

I think it's reasonable. Could use a kwarg max_index and .clip(lower=0, upper=max_index) but that's nice to have, not required.

I'm ok with it as long as the default is reasonable so we just use the default for reference forecasts

Thanks. Then I'll suggest that we skip the kwarg for now. In that case I think this is ready to merge, except that I'd like to wait for #150 so that I can add a note to its 1.0.0b whats new file.

I think this is ready to merge.
Here's the example from the Denver workshop notebook run with and without the limit...
Without limit (old behavior)

With limit (proposed behavior)


feat: Add flag for turning off colors in TTY printing

It is a bit annoying to copy the colored output into something like Markdown.
Test plan
Manually checked.
With scip print or scip print --color=true:

With scip print --color=false

Given you're already touching this code, would be good to follow the CLI conventions (https://clig.dev/#output) and at least handle NO_COLOR env variable as well:
Use color with intention. For example, you might want to highlight some text so the user notices it, or use red to indicate an error. Don’t overuse it—if everything is a different color, then the color means nothing and only makes it harder to read.

Disable color if your program is not in a terminal or the user requested it. These things should disable colors:

    stdout or stderr is not an interactive terminal (a TTY). It’s best to individually check—if you’re piping stdout to another program, it’s still useful to get colors on stderr.
    The NO_COLOR environment variable is set.
    The TERM environment variable has the value dumb.
    The user passes the option --no-color.
    You may also want to add a MYAPP_NO_COLOR environment variable in case users want to disable color specifically for your program.

Added handling for NO_COLOR.


feat: Send selling of player as a notification

Prerequisites

[X] I have searched for existing issues that already include this feature request, without success.

Describe the Feature Request
Currently the notification service only triggers for the buying operations. Similar to the line
writeToLog(     ${playerName}, ${
message
? message
: sellPrice < 0
? "moved to transferlist"
: shouldList
? "selling for: " + sellPrice + ", Profit: " + profit
: buyerSetting["idAbDontMoveWon"]
? ""
: "moved to club"
} ,     idProgressAutobuyer   );
It can be sent in notifications.
Describe the Use Case
Allow users to improve leaving the auto buyer on and tracking profits.
Describe Preferred Solution
No response
Describe Alternatives
No response
Additional Information
No response

https://github.com/ckalgos/FUT-Auto-Buyer/pull/770

Thanks for the PR, I have merged it

@ckalgos Was helping a user out on your discord about this feature and got banned for answering his Q? My username is Milan#1000


Adapt to new haskell-src-exts API.

The IVar namespace argument has moved to IAbs as of HSE b0527bf.

Thanks for the patch. Were these the only changes required to get it working with the latest HSE? Generally the diff between versions is much larger.
Given the HSE release is coming out very soon, I might wait on this patch until the release is out and then merge it then, so the HEAD continues to work with the last HSE release and so that I can make a quick upgrade to the new release.

Seems reasonable; apply when it seems prudent. I just had to patch this in because I needed the support for pattern synonym’s recently added in HSE’s head (6640237). Apart from this, the build against 6640237 went through fine. Maybe there are still some merges ahead for HSE before release.
HSE’s VarA has been refactored into a new constructor, AppA, and the KindBang constructor has been removed, but hlint doesn’t seem to be using either of these.

Closing because the commit is also a part of #184, thanks for the patch!