esgateway pggateway: Changes to parsed nodes and resolvers to PG gateway HAProxy And Make resolvers configurable

Signed-off-by: Kallol Roy<EMAIL_ADDRESS>:nut_and_bolt: Description: What code changed, and why?
Automate when configured with multiple postgres nodes (master + followers) fails to resolve the added/removed follower from the cluster beyond the ones mentioned in the config.
The aim is to make sure that HAProxy should be able to resolve the nodes in a periodic manner based on the resolv.conf.
:chains: Related Resources
This involves changes in:

Modifying HaProxy template to include the resolvers and server-template
Parsing the resolver.conf to find the default resolvers IP addresses
Update the config request to populate the HaProxy Config.

The resolvers can be added and passed by adding the following configurations:
[pg_gateway.v1.sys.resolvers]
# Multiple resolvers can be specified by
# adding the resolvers in the list.
nameservers = ["<IP_ADDRESS>:52"]
enable_system_nameservers = false

In case of ESgateway
[esgateway.v1.sys.ngx.main.resolvers]
nameservers = ["<IP_ADDRESS>:52"]
enable_system_nameservers = false

:+1: Definition of Done
Setting the configurations should make following changes in the deployed environment:

Setting the esgateway section should make a change in the /hab/svc/automate-es-gateway/config/nginx.conf and the resolvers should be added. Example:

resolver <IP_ADDRESS>

Setting the pg_gateway section should make a change in the /hab/svc/automate-pg-gateway/config/haproxy.conf and the resolvers should be added. Example:

resolvers pgdns
        nameserver dns0 <IP_ADDRESS>:52

:athletic_shoe: How to Build and Test the Change

Pull the latest code
Enter hab studio
Rebuild the components

rebuild components/automate-pg-gateway
rebuild components/automate-es-gateway
rebuild components/automate-cli
rebuild components/automate-deployment

Make the changes in the config.toml as above.
start_all_services
Have a look at /hab/svc/automate-es-gateway/config/nginx.conf and /hab/svc/automate-pg-gateway/config/haproxy.conf

:white_check_mark: Checklist

[x] I have read the CONTRIBUTING document.
[ ] Tests added/updated?
[ ] Docs added/updated?
[x] All commits have been signed-off for the Developer Certification of Origin.

:camera: Screenshots, if applicable

Thanks for adding the "how to test..." and "definition of done" sections. That gets the reader much closer to understanding what you are trying to achieve. However, for someone unfamiliar with the context (like me 😁 ), that seems to only show that the entered config lines end up in the correct location. But how does that connect to what your "description" says?

I agree. I should have added more information there. The resolvers would make sure that the PG/ES node IPs can be resolved dynamically and any change in the cluster would not fail the application. In the current scenario when the node IPs are provided and if cluster node goes down, the gateway would keep on trying with the IP addresses. This encourages users to provide hostnames rather than the IPs.

Found an issue while doing acceptance testing for this. The issue can be summarised as below:
While setting up external postgres. In case if the config does not have
[global.v1.external.postgresql.ssl]
   enable =false

Automate-dex expects the connection to be SSL enabled and expects the root_cert path.
This can be fixed from the code or we can update the doc to mention the behaviour.
But we can take it up in the upcoming release as generally for any external ES/PG setup, the connections would be SSL secured for obvious reasons.

Found an issue while doing acceptance testing for this. The issue can be summarised as below:
While setting up external postgres. In case if the config does not have
[global.v1.external.postgresql.ssl]
   enable =false

Automate-dex expects the connection to be SSL enabled and expects the root_cert path.
This can be fixed from the code or we can update the doc to mention the behaviour.
But we can take it up in the upcoming release as generally for any external ES/PG setup, the connections would be SSL secured for obvious reasons.


Update to android_glue 0.2

https://github.com/tomaka/android-rs-glue/issues/93

The small blocker here is Servo. I don't think they want to change their complex Android build system immediately.
cc @glennw @larsbergstrom

If it's just changes to the types in the glue code, that should hopefully be fine to land.
The only change we're thinking about to our current Android build system in Servo is to move from the  deprecated ndk-build / ant system to gradle, which is the more modern way of building them. The new 'cargo apk' command is awesome, but I'm pretty sure that if we tried to accommodate all of Servo's manifest, java, resources, icon, etc. requirements plus the stuff needed to support finicky ndk-gdb issues, the nvidia profiler, etc., we'd end up in a similar situation to where we are with glutin where Servo is pulling in a very different direction from the needs of every other user in the community.

manifest, java, resources, icon, etc. requirements plus the stuff needed to support finicky ndk-gdb issues, the nvidia profiler, etc.

Hmm, why cargo-apk doesn`t need that? As for me, sounds like useful features for many native android apps.

Ping? :)

@larsbergstrom @glennw If you don't disagree, I'm going to merge this PR. When you update your fork from upstream glutin, you should add a commit that reverts it.

crates.io version in still not updated :(


Add Licence File

Hi,
First, thank you for the library.
Please include a license file in the project so it clearly states under which the code is licensed.

Hi @hasssan thanks for raising the issue, added the license file already, it's MIT license
https://github.com/fahmifan/bank-statement-parser-id/pull/2

I'm closing this issue then, thanks!


⚠ Bofrost.lu has degraded performance

In 013d637, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1273 ms

Resolved: Bofrost.lu performance has improved in db2c3ab.


Link 88% of spreadsheets contain errors stat to source paper

"One study by a researcher at the University of Hawaii found that 88 percent of spreadsheets contain errors."
An interesting stat. Wouldn't it be even better with a link to the original paper?

It would! Thanks @zachlipton


How to convert back "WolframObjects" to python objects

e.g.
Table[Values[i], {i, WordData["motorbus", "Synonyms"]}]
Id like to have a python List..
As of now I am doing it like this (which seems very hacky)
raw_results = evaluate('ExportString[Table[Values[i], {i, WordData["motorbus", "Synonyms"]}], "CSV"]')
result_list = results.replace('"', '').replace('\n', '').split(',')

Hi, this is documented here:
https://reference.wolfram.com/language/WolframClientForPython/docpages/basic_usages.html#expression-evaluation
by default you are getting back tuples, that are immutable. you can convert them to list with python code.
>>> from wolframclient.evaluation import WolframLanguageSession
>>> session = WolframLanguageSession()
>>> res = session.evaluate('Table[Values[i], {i, WordData["motorbus", "Synonyms"]}]')
>>> list(map(list, res))
[['autobus', 'bus', 'charabanc', 'coach', 'double-decker', 'jitney', 'motorcoach', 'omnibus', 'passenger vehicle']]


fix: return type of Accuracy#forwad_cpu() norm to array fix#97

Sorry, I found bug my PR(#97). I was fixed return type of Accuracy#cpu_forwad() like SoftmaxCrossEntropy#foward_cpu().
But  I fear that the different return type forward_cpu() and forward_gpu()
x_c = Variable( numpy.array( [ [0. , 1.], [0., 1.,] ], dtype=numpy.float32 ) )
t_c = Variable( numpy.array( [ 1, 1], dtype=numpy.int32 ) )
x_g = Variable( cuda.to_gpu( numpy.array( [ [0. , 1.], [0., 1.,] ], dtype=numpy.float32 ) ) )
t_g = Variable( cuda.to_gpu( numpy.array( [1, 1], dtype=numpy.int32 ) ) )

cpu = F.accuracy(x_c, t_c).data
gpu = cuda.to_gpu( F.accuracy(x_g, t_g).data )
print cpu, gpu #=> [ 1.] 1.0
print cpu.shape, gpu.shape #=> (1,) ()

cpu = F.softmax_cross_entropy(x_c, t_c).data
gpu = cuda.to_gpu( F.softmax_cross_entropy(x_g, t_g).data )
print cpu, gpu #=> [ 0.31326166] 0.313261657953
print cpu.shape, gpu.shape #=> (1,) ()

Thank you very much! I think it's a problem of numpy....
>>> a = numpy.array(1, numpy.float32)
>>> a
array(1.0, dtype=float32)
>>> a + a
2.0  # ???
>>> g = chainer.cuda.to_gpu(a)
>>> g
array(1.0, dtype=float32)
>>> g + g
array(2.0, dtype=float32)

I like the same return types of forward_cpu and forward_gpu as you write.
Another solution is that forward_gpu also returns an array whose shape is (1,).

Please try the master branch. I fixed __add__ operator in #108 for this problem.

This problem was solved. Thank you.


performance issue,  it's a bad idea to use array to store pgids in freelist

pprof

type freelist struct {
	ids     []pgid          // all free and available free page ids.
	pending map[txid][]pgid // mapping of soon-to-be free page ids by tx.
	cache   map[pgid]bool   // fast lookup of all free and pending page ids.
}

// allocate returns the starting page id of a contiguous list of pages of a given size.
// If a contiguous block cannot be found then 0 is returned.
func (f *freelist) allocate(n int) pgid {
	if len(f.ids) == 0 {
		return 0
	}

	var initial, previd pgid
	for i, id := range f.ids {
		if id <= 1 {
			panic(fmt.Sprintf("invalid page allocation: %d", id))
		}

		// Reset initial page if this is not contiguous.
		if previd == 0 || id-previd != 1 {
			initial = id
		}

		// If we found a contiguous block then remove it and return it.
		if (id-initial)+1 == pgid(n) {
			// If we're allocating off the beginning then take the fast path
			// and just adjust the existing slice. This will use extra memory
			// temporarily but the append() in free() will realloc the slice
			// as is necessary.
			if (i + 1) == n {
				f.ids = f.ids[i+1:]
			} else {
				copy(f.ids[i-n+1:], f.ids[i+1:])
				f.ids = f.ids[:len(f.ids)-n]
			}

			// Remove from the free cache.
			for i := pgid(0); i < pgid(n); i++ {
				delete(f.cache, initial+i)
			}

			return initial
		}

		previd = id
	}
	return 0
}

@benbjohnson
Too much runtime.memmove,   why not use a linked list to improve performance?

Linked list will not resolve main issue: 8 seconds a spend in searching, and only 4 sec in moving.


feat(store,world): replace ephemeral tables with offchain tables

Fixes #1123
Replacement for #1496 (since we changed the approach)

but I am surprised gas went up across the board

it's because we're doing an additional check in all store methods to early return if it's an offchain table, and that check costs 200 gas


Limitless Rampage

The druid archetype "Elemental Rampager" has the Ability Rampage which is similar to (Blood)rage. It however does not have an Limitless Feat, so it would be nice if it could be added.

Included in limitless rage. Please reply if not working.


React-Native Compatibility

Hi,
It's seems that this package is not compatible with React-Native because it uses some module from NodeJS that are not implemented in React-Native, the modules involved are: assert, child_process, fs, os, path, stream and util. I tried to implement them first with
node-libs-react-native and then with rn-nodeify but I cannot make it works.
Do you have any Idea how I could use this package in a React-Native app ?
Thanks in advance.

Firstly, thanks for the reply.
Then, the issue is that react-native implement Node.js indeed. But all modules of Node.js are not available or doesn't work in the same way as in pure Node.js, because react-native is more of a "browser" environment so they are not compiled in the same way. While it exists some libraries that adapt those APIs like "react-native-path" to replace the module "path" of Node.js, those packages are meant to be used directly in the code and not to replace the dependencies of other installed package because they wont have the same behavior. On top of that, the environment variable are not the same between React-Native and Node.js, for example the process.version doesn't no exist in react-native and some packages use it.
Technically, it should be possible to polyfill those ones but it will be a pain because you will have to polyfill a lot of APIs from Node.js and I tried to do it but it doesn't seems to work (or at least I cannot make it works). Or, I could rewrite your code with the APIs for React-Native but I don't have neither the time nor the will to do that 😅.
So it's seems that your package is more focused to be used in a backend environment.

Just chiming in here as someone else interested in using the library in a react-native app. There are plenty of youtube-downloaders for react-native, but none are as good as the real youtube-dl like this library

This library is tiny because it's essentially spawning the youtube-dl command.
The youtube-dl is some code executed by python.
That is still "light" assuming you are running it in an environment where python is installed (like a server).
In the case of React Native, you should move all these layers to be executed inside the React Native host device (a phone instead of a server).
So even technically is possible it's too much hard work.  A good enough solution might be to have a microservice that does the thing.
I'm missing what you want to achieve in your React Native application, but in case you are interested in getting video information (like duration, size, format, etc)  you can use ping Microlink API passing a video URL:
e.g.,  api.microlink.io/?url=https://file-examples-com.github.io/uploads/2017/04/file_example_MP4_480_1_5MG.mp4&video
Otherwise, you can use this library for creating your own microservice 🙂


Bring help page up to date with designs

Bring help page up to date with designs: https://www.figma.com/file/SfRqwuE3GEpM3RkgsH4VLC/Main?node-id=467%3A3375

maybe some of the issues are resolved with the max width ticket

maybe some of the issues are resolved with the max width ticket

IBM Cloud toolchain: Delivery Pipeline deployed LRP-web-app to dev, including commit 0f125c8bdf56547178551140311b8fa1d7a4a9be

IBM Cloud toolchain: Delivery Pipeline deployed LRP-web-app to dev, including commit 0f125c8bdf56547178551140311b8fa1d7a4a9be

IBM Cloud toolchain: Delivery Pipeline deployed LRP-web-app to test, including commit 0f125c8bdf56547178551140311b8fa1d7a4a9be

IBM Cloud toolchain: Delivery Pipeline deployed LRP-web-app to test, including commit 0f125c8bdf56547178551140311b8fa1d7a4a9be

IBM Cloud toolchain: Delivery Pipeline deployed LRP-web-app to test, including commit 0f125c8bdf56547178551140311b8fa1d7a4a9be

IBM Cloud toolchain: Delivery Pipeline deployed LRP-web-app to prod, including commit 0f125c8bdf56547178551140311b8fa1d7a4a9be


[Synapse] az synapse spark pool create/update: Add --spark-config-file-path

Description

Add spark config file path argument in az synapse spark pool create and update cmdlets

az synapse spark pool create, add argument: --spark-config-file-path

az synapse spark pool update, add argument: --spark-config-file-path

Testing Guide

History Notes

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

Synapse

Synapse

Please sync with latest dev branch to bypass CI failure


Make Sandcastle tolerant of JSDoc's new static prefixes.

Fixes #2757.  There are two parts to this fix.

In the generated types file, the keys have the prefixes removed (since the keys match lowercase snippets of alphanumeric source code, sans punctuation), but the values are real URLs with the prefixes intact.  Thus, fragments of text can be matched to both static and non-static member URLs.

Sandcastle's presentation of the matched links was based on the values, not the keys, in order to display the correct casing.  Thus the presentation was tweaked to not show the new prefix.

A good test case here is to add this line in Sandcastle's editor and double-click it:
//contains

In the resulting list, Queue.contains is non-static, and Rectangle.contains is static.  Both links should work and scroll correctly.

Looks good.  Thanks @emackey!


fix: Azure Blob transcript key

Fixes #4176
Description

Expecting Azure blob to creat transcript activity and follow the pattern of container/{channelId]/{conversationId}/{Timestamp.ticks}-{activity.id}.json
instead it was creating directory container%2F{channelId}%2F{conversationId}%2F{Timestamp.ticks}-{activid.id}.json due to sanitizeBlobKey method using the encodeURIComponent function.
Specific Changes

Created optional decodeTranscriptKey boolean property in BlobsTranscriptStoreOptions interface to return a new string representing the decoded version of the given encoded blob transcript key. This remains the default behavior to false but can be overridden by setting decodeTranscriptKey to true.

Steps to reproduce

Prerequisite: Azure Blob

Run git clone --branch ramfattah/blobTranscript https://github.com/microsoft/botbuilder-js.git

Run yarn and yarn build in the root folder of SDK

Open libraries/botbuilder-azure-blobs/tests/blobsTranscriptStore.test.js file

Add your blob connectionString and containerName. Note, it will create the container automatically if the name doesn't already exist.

Flip decodeTranscriptKey flag to true

In terminal, run mocha <path-to-blobsTranscriptStore.test.js

Ex: mocha /Users/ram/Documents/bot/botbuilder-js/libraries/botbuilder-azure-blobs/tests/blobsTranscriptStore.test.js

This will create blob transcript key in the container as the following pattern  container/{channelId]/{conversationId}/{Timestamp.ticks}-{activity.id}.json

Before

After

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.003%) to 84.487%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

libraries/botbuilder-azure-blobs/src/sanitizeBlobKey.ts
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

Totals

Change from base Build<PHONE_NUMBER>:
0.003%

Covered Lines:
19753

Relevant Lines:
22145

💛  - Coveralls

Hi @tracyboehrer and @ramfattah . I am trying to use the this from the TranscriptLoggerMiddleware. The middleware does not call logActivity with the options object and does not support setting an options object  see code here
I think the logActivity in the  blobsTranscriptStore should also use  this._isDecodeTranscriptKey to set options for getBlobKey. This way, the middleware won't need to maintain the same attribute.
What are your thoughts, can we create a new issue for this?

@tariromukute The main issue is that what options are being used?  Blobs options?  The transcript middleware doesn't know anything at all about which Storage is being used (Memory, CosmosDB, Blobs, etc...).  It only knows about TranscriptLogger.  So while the BlobsTranscriptStore has an optional options argument, it's not known to the middleware.
One option might be to implement a transcript logger that does have some knowledge about the store being used.  Though perhaps a better option would be to create a BlobsTranscriptStore using a particular BlobsStorageOptions.


Loading an empty pipeline, creating a first step and trying to edit that step fails due to JS listener errors.

Fixed in https://github.com/orchest/orchest/commit/5333cc4dbee4387246b864c0f2f8b98af221980a


add jsdoc

I just added some JSDoc comment to improve typing when using with a Typescript project for example.

Sweet. Thank you :)


Signature verification issue key expired

But  as  I checked apt-key list there is no expired key. I tried to referesh-it did not work, I can't remove it either.

Same here

same here
ubuntu 20.04, installed torbrowser-launcher from ubuntu official repo

"SIGNATURE VERIFICATION FAILED"
"You might be under attack, there might be a network problem, or you may be missing a recently added Tor Browser verification key."
"A copy of the Tor Browser files you downloaded have been saved"
"Click Start to refresh the keyring and try again.  if the message persists report the above error code"
I do not have networking problems.
I cannot install or use Tor Browser.
Operating System: Fedora 32
KDE Plasma Version: 5.18.5
KDE Frameworks Version: 5.70.0
Qt Version: 5.14.2
Kernel Version: 5.8.4-200.fc32.x86_64
OS Type: 64-bit
Processors: 16 × AMD Ryzen 7 3700X 8-Core Processor
Memory: 31.3 GiB of RAM

Solution trouvée plus bas
wget -v 'https://github.com/sysrqb/torbrowser-launcher/raw/develop/share/torbrowser-launcher/tor-browser-developers.asc' ; sudo cp -v ~/tor-browser-developers.asc /usr/share/torbrowser-launcher/ ; torbrowser-launcher ; echo "DONE"

openSUSE Leap 15.2 affected as well.

Solution trouvée plus bas
wget -v 'https://github.com/sysrqb/torbrowser-launcher/raw/develop/share/torbrowser-launcher/tor-browser-developers.asc' ; sudo cp -v ~/tor-browser-developers.asc /usr/share/torbrowser-launcher/ ; torbrowser-launcher ; echo "DONE"

This command worked, however torbrowser still complains of expired keys.

Solution trouvée plus bas
wget -v 'https://github.com/sysrqb/torbrowser-launcher/raw/develop/share/torbrowser-launcher/tor-browser-developers.asc' ; sudo cp -v ~/tor-browser-developers.asc /usr/share/torbrowser-launcher/ ; torbrowser-launcher ; echo "DONE"

thanks a lot!

Kali Linux (2020-07-01) affected as well, fixed with solution from @randoclt

Solution trouvée plus bas
wget -v 'https://github.com/sysrqb/torbrowser-launcher/raw/develop/share/torbrowser-launcher/tor-browser-developers.asc' ; sudo cp -v ~/tor-browser-developers.asc /usr/share/torbrowser-launcher/ ; torbrowser-launcher ; echo "DONE"

Works, might want to replace cp with mv?

Solution trouvée plus bas
wget -v 'https://github.com/sysrqb/torbrowser-launcher/raw/develop/share/torbrowser-launcher/tor-browser-developers.asc' ; sudo cp -v ~/tor-browser-developers.asc /usr/share/torbrowser-launcher/ ; torbrowser-launcher ; echo "DONE"

Did not work for me on Ubuntu 18.04 LTS.

Alternative solution:
 curl -s https://openpgpkey.torproject.org/.well-known/openpgpkey/torproject.org/hu/kounek7zrdx745qydx6p59t9mqjpuhdf | gpg --import --homedir ~/.local/share/torbrowser/gnupg_homedir/ -

Alternative solution:
 curl -s https://openpgpkey.torproject.org/.well-known/openpgpkey/torproject.org/hu/kounek7zrdx745qydx6p59t9mqjpuhdf | gpg --import --homedir ~/.local/share/torbrowser/gnupg_homedir/ -

Still got browser version is earlier than it should be....

This second blocker comes from https://github.com/micahflee/torbrowser-launcher/pull/499 (you need to patch your .py by hand)

Solution trouvée plus bas
wget -v 'https://github.com/sysrqb/torbrowser-launcher/raw/develop/share/torbrowser-launcher/tor-browser-developers.asc' ; sudo cp -v ~/tor-browser-developers.asc /usr/share/torbrowser-launcher/ ; torbrowser-launcher ; echo "DONE"

Did not work for me on Ubuntu 18.04 LTS.

same here.

https://2019.www.torproject.org/docs/signing-keys.html.en
https://support.torproject.org/tbb/how-to-verify-signature/
gpg: key 4E2C6E8793298290: public key "Tor Browser Developers (signing key<EMAIL_ADDRESS>imported
gpg: Total number processed: 1
gpg:               imported: 1
pub   rsa4096 2014-12-15 [C] [expires: 2020-08-24]
      EF6E286DDA85EA2A4BA7DE684E2C6E8793298290
uid           [ unknown] Tor Browser Developers (signing key<EMAIL_ADDRESS>sub   rsa4096 2018-05-26 [S] [expires: 2020-09-12]

All keys are expired. It has nothing to do with launcher, it is tor project issue.

What worked for me was totally uninstalling the version that came with the distro and installing the version from the project website.

No update on this ?  No one assigned ?  A lot of users are dead in the water because of this.  TB hasn't worked for me for a week now.  I'm on Ubuntu MATE 20.04


pg_net 0.11 on 15.6 release branch

Upgrades pg_net from 0.10.0 to 0.11.0 on the pg 15.6 release branch.
We have multiple customers waiting for this release. Its already in the 15.8 image
Note: this version contains a MacOS incompatibility so the CI job for that will fail. Steve is working on a fix but it'll take too long to wait for

Release version needs to be updated


re-re-remove overly restrictive minimum version of meson

Despite being removed a couple of times in commits 6adc79f864138ddf25daa8ffd01fcb3f622cec6f and 208310134ba0ed783e5d979e8111021ce6a5acb3 this kept on getting re-added by the automatic update script. Remove it more thoroughly this time.

Thank you for your contribution!

No problem :) I noticed this while doctest was in the process of being updated on Meson's wrapdb service.


Implement HMAC using EVP_MAC_CTX on OpenSSL 3

This PR updates the HMAC implementation to use EVP_MAC_CTX on OpenSSL 3 instead of the deprecated HMAC_CTX.
While here, I've changed how OpenSSL 1 resets the context to avoid having to keep the key around. HMAC_Init_ex reuses the same key and hash function if they are not passed, as Reset() is not changing those parameters, there is no need to pass them.

HMAC_Init_ex() initializes or reuses a HMAC_CTX structure to use the hash function evp_md and key key. If both are NULL (or evp_md is the same as the previous digest used by ctx and key is NULL) the existing key is reused. ctx must have been created with HMAC_CTX_new() before the first use of an HMAC_CTX in this function. N.B. HMAC_Init() had this undocumented behaviour in previous versions of OpenSSL - failure to switch to HMAC_Init_ex() in programs that expect it will cause them to stop working.

Unfortunately the same optimization can't be used on OpenSSL 3 due to this bug: https://github.com/openssl/openssl/issues/17811.

Friendly remainder to review this PR


Make selected_suite_options argument of children optional

Summary
Makes the selected_suite_options argument of children optional.
Previously, children was a private attribute that took no arguments. This will allow code that used children in this way to continue to function properly.
e.g. This specialized g10 test filtering code:
https://github.com/onc-healthit/onc-certification-g10-test-kit/blob/63eac95deedf9d9ee6a9d5f9df8e32dde70f684f/lib/onc_certification_g10_test_kit/single_patient_api_group.rb#L86
Testing

Uncomment the g10 test kit from the Gemfile
Uncomment require_relative of the g10 test kit in demo_suite.rb
run bundle install and then npm run dev

The following error will be thrown without the change included in this PR:
/inferno-core/lib/inferno/dsl/runnable.rb:401:in `children': wrong number of arguments (given 0, expected 1) (ArgumentError)
    from .../gems/onc_certification_g10_test_kit-2.2.1/lib/onc_certification_g10_test_kit/single_patient_api_group.rb:86

Codecov Report

Merging #206 (d5192fe) into main (cca09a5) will decrease coverage by 41.50%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #206       +/-   ##
===========================================
- Coverage   76.61%   35.11%   -41.51%
===========================================
  Files         180       68      -112
  Lines        4101     1216     -2885
  Branches      384      384
===========================================
- Hits         3142      427     -2715
+ Misses        957      787      -170
  Partials        2        2

Impacted Files
Coverage Δ

lib/inferno/dsl/runnable.rb

lib/inferno/entities/request.rb

lib/inferno/repositories/requests.rb

dev_suites/dev_demo_ig_stu1/groups/demo_group.rb

lib/inferno/entities/preset.rb

lib/inferno/apps/web/serializers/test.rb

lib/inferno/config/application.rb

lib/inferno/result_summarizer.rb

lib/inferno/apps/web/controllers/controller.rb

lib/inferno/apps/web/serializers/header.rb

... and 102 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cca09a5...d5192fe. Read the comment docs.


Make a release

Please tag with a version number (0.0 or 0.1-rc perhaps?) to make it easier to create proper packages for Linux distros while waiting for the release milestone (looks better than locking to a git commit, which is the current situation).

Afaik the language is not yet at a point where a release would make sense,
nor would creating packages for the compiler.
On Mon, Aug 29, 2016, 11:27 Alexander F Rødseth<EMAIL_ADDRESS>wrote:

Please tag with a version number (0.1 or 1.0 perhaps?) to make it easier
to create proper packages for Linux distros (looks better than locking to a
git commit).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/andrewrk/zig/issues/175, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMxqX-T0I5J-kIg6oDavEZ4VqxRH607ks5qkqYXgaJpZM4JvTMb
.

OK, looking forward to the first release. :+1:


can change default icons

can change default icons using custom class in initializer, I added the example in README

Like this at @marcamillion
.ssb-reddit {
position: relative;
}
.ssb-reddit:before {
position: absolute;
font-family: 'FontAwesome';
top: 0;
left: 8px;
content: "\f281";
}


Localtracer - Make builder public

I was incorporating LocalTracer into some code with a custom LocalSpanAndEndpoint.
I could not create a LocalTracer itself without going through the Brave class which was a bit frustrating.
I'm working on a non-blocking webserver framework and the provided implementation of LocalSpanAndEndpoint does not work - as it relies on thread local.
Instead each request through the framework (Vert.x) is given a 'Context' object that is associated to the request and passed through the handler chain (the context object has a Map<String, Object> to store request specific information).
I must create a new LocalSpanAndEndpoint and feed it the request underlying Map at the start of every request - which was wanting me to create a new LocalTracer.
PS: thanks for getting back to me on the google groups. We are already logging some internal timings to a MetricScope class (a directed acyclic graph) with start time/duration.
I was hoping to try and just convert those tracings but hit the wall against the recursive LocalSpans

recursive spans are not supported.. and you'll run into problems where you can't close a parent after you close the child. #166 was opened to support nested spans. Until then, you'd need to make some hacks that violate the contract of LocalTracer. As such, it is almost just as well to create your own LocalTracer (not named localTracer, rather something else).
Otherwise, here's a hack that might help you get by until #166. It totally breaks nested state management in local spans, but it will allow you to create one (assuming you do manual thread state management), and doesn't impact the api.
Span nextLocal;
if (localThreadBinder.getCurrentSpan() == null) {
  nextLocal = localTracer.startNewSpan(.. // we're the root span
} else { // our parent is a local span
  Span parent = localThreadBinder.getCurrentSpan();

  // Brave's thread state management is fixed, as opposed to a stack:
  // You can only create a child local span from a server span.
  // See https://github.com/openzipkin/brave/issues/166

  // save off the old server span
  Span serverSpan = serverThreadBinder.getCurrentSpan();
  try {
     // fake as if the local span is actually a server one.
     // this will allow us to create a child
     serverTracer.setStateCurrentTrace(
                parent.getTrace_id(),
                parent.getId(),
                parent.getParent_id(),
                parent.getName()
     );
     // this will work it will overwrite the threadlocal of the former local span
     // this means that localTracer.finish() will close the nextLocal, but after that
     // happens, you cannot call it again to close parent!
     nextLocal = localTracer.startNewSpan(...
  } finally {
    serverThreadBinder.setCurrentSpan(serverSpan); // put the old server span back
  }
}

please try https://github.com/openzipkin/brave/blob/master/brave-core/src/main/java/com/github/kristofa/brave/InheritableServerClientAndLocalSpanState.java and let us know if you still need help prior to #166


Vcluster/transfer poa

Screenshot of POA transfer proposals created.
But there is a bug in frontend.


Added 'data-snax' in New Libraries

I added a small library that I wrote, 'data-snax', in the New Libraries section.  It is a vanilla JAX (early) implementation of the tf.data input pipelines lAPIs and figured it could be useful for the community too, feel free to ignore the request if deemed not fit. I hope I had read correctly how to edit the README.md.
Best,
jhn-nt

Nice library! I will leave this PR open and wait until data-snax accrues some users and stability before adding it to the list.


Demo Apps Handle Runtime Permissions

The runtime permission support in the library proper is a fallback mechanism. This really should be handled by the apps. Have the demo apps do this properly.

Also update the permissions documentation for this.

Addressed in v0.2.2.


feat(global-metrics): use pure kad exporter for a lightweight public dashboard

Why
Our existing global metrics setup is scraping individual nodes, and is extremely heavy.
What

refactor docker/global-metrics around kademlia exporter

Demo
deployed at https://dashboard.ursa.earth/
Checklist

[x] I have made corresponding changes to the tests
[x] I have made corresponding changes to the documentation
[x] I have run the app using my feature and ensured that no functionality is broken

are we going to maintain these .json dashboards? How often do you think they will change?

Deployed at https://dashboard.ursa.earth/

Great to see parts of the Kademlia exporter reused here. Let me know in case I can be of any help.

They're based off of kademlia-exporter.max-inden.de, of which I couldn't find a git version uploaded. I had to make some minor modifications as well.

I don't have a public repository for those. Sorry. I am in favor of maintaining the rust-libp2p dashboard on the rust-libp2p monorepo, though I haven't gotten around to a pull request yet. Help more than welcome.

kademlia-exporter.max-inden.de is now as well monitoring the ursa network. See:
https://kademlia-exporter.max-inden.de/d/Pfr0Fj6Mk/rust-libp2p?orgId=1&refresh=30s&var-data_source=Prometheus&var-instance=kademlia-exporter-ursa:8080
https://kademlia-exporter.max-inden.de/d/-avwMhsik/kademlia-exporter?orgId=1&var-instance=kademlia-exporter-ursa:8080
Let me know if this is of any help.


Update CHANGES.rst

Fix the issue link in the Flask 3.0.1 Changelog in the send_file argument type entry

Please target docs changes to the maintenance branch (3.0.x) so that they show up in those docs builds.

Ok, done.

You need to rebase to change the target, not only change it in the GitHub UI.

I tried rebase but it was a mess (I didnt see your edit with the commands) so I created a new PR. https://github.com/pallets/flask/pull/5618 Sorry for the confusion.


How to train with predefined train and val split

:question: Question

Current model is doing k-fold cross-validation.
So if I have predefined train and val split, how to do the whole process?

Does this Issue answer your question? https://github.com/MIC-DKFZ/nnDetection/issues/61
(No other changes than the manually created splits file are required)

Since there was no update for some time,  I'll close the Issue for now but if anything else comes up please reopen (if the same) or open a new one.


README: Fix badge rendering in Markdown

This PR fixes the broken Markdown images in the badge list.
Also: since Markdown is kinda HTML, I placed the badges each on its own row in the source. That makes it easier to read when in source form, and does not change the rendered form.

Hmm, for some reason Travis isn't kicking off a build for this PR

That's because I told it not to - using the arcane (?) annotation [ci skip]

Aha, well as it were all commits that land on master are presently gated on passing CI... I suppose I can shut that off

Or I can force push another change with another message. Whatever does it.

@olleolleolle that'd be great

@tarcieri Ta-da!

Thanks!


cargo do_compile fail

I'm compiling in kirkstone, and have meta-rust, which is 1.75.0
I got firefox branch master yesterday, and compile has failed. I see that you have meta-firefox/recipes-devtools/rust, which looks like it is duplicating what I already have in meta-rust.
This is what is failing:
ERROR: Logfile of failure stored in: /mnt/build/builds/oe/kirkstone/oe-quirky/build-amd64/tmp/work/x86_64-linux/cargo-native/1.75.0-r7/temp/log.do_compile.24047
...
| error: failed to run rustc to learn about target-specific information
I have already edited meta-firefox/recipes-devetools/clang/llvm-project-source.bbappend, removed "kirkstone":
SRC_URI += '${@bb.utils.contains_any("LAYERSERIES_CORENAMES", "dunfell",
As I have meta-clang, with clang 14.0.6 and the patches do not work.
I'm wondering, should I just remove all of meta-firefox/recipes-devtools/rust?

Rust: yes, the rust folder is only needed for the Nanbield release. For other releases you can either delete it, or for example add BBMASK += "meta-browser/meta-firefox/recipes-devtools/rust/" to local.conf or similar place, to ignore that folder while parsing. (Once Nanbield is EOL, this folder will go away also with the next FF release. Nanbield will be EOL next week.)
llvm: yes, the patch is only needed for kirkstone. I am going to cherry pick that commit into master in a few moments.
In the past week I did some CI work where these issues are fixed, but unfortunately I missed adding all necessary details to the master branch (including the note about rust), sorry for that. I hope to catch up with all these this weekend.

Hi, just to confirm, I deleted meta-firefox/recipes-devtools/rust and Firefox 125.0.2 compiled ok.
I've got kirkstone with meta-rust 1.75.0 (from master branch April 26) and meta-clang 14.0.6 (from branch kirkstone April 26).

Thank you for the confirmation.
I believe for now there isn't much to do about this issue, closing it.
If you disagree, feel free to reopen it.


Fix home page button alignment

The buttons are misaligned on docs.getdbt.com

I don't think it always looked like this, but I'm not sure when it broke!

Looks fixed!


Quick previous tab shortcut sometimes works

This started to occur after I changed this shortcut mapping on laptop A. The extension on Laptop A works as it should and everything was good until I started using laptop B. Chrome synced the shortcut mapping change properly but when I tried using it works about 60% of the time. Laptop A still works like a charm
HOWEVER
I did some debugging and I noticed that if I navigate to a tab -> use cmd-E to open the menu -> close the menu -> than use previous tab shortcut -> it works without fail.
I've disabled and re-enabled the extension, removed and re-added the extension, restarted chrome, and restarted my computer.
Google Chrome 61.0.3163.100
Quick Tabs 2017.5.10
OS X El Capitan 10.11.6

I also have this bug. Previous tab shortcut doesn't work reliably. E.g. just now I visited tab2, then returned to the gibhub tab, then hit the shortcut, and it got me to tab 4. I have yet to find out if the bug also applies to the tab list in the popup.

@leedoyle That's seems consistent with what I'm experiencing! I noticed that if I wait a few seconds in the current tab before going to the previous one it works more reliably.

You have to watch for when the color of the icon changes from yellow (I believe) back to its default of dark blue.  The wait is what registers the current tab as the new "most recent" tab.
It's a little annoying because there's no option to change the delay. (Going to go start a new issue for that option.)


Ignore gosec false positives

We don't care about errors when closing the body of an API request
Fixes VEGA-1706 #patch

Codecov Report
Base: 85.10% // Head: 85.10% // No change to project coverage :thumbsup:

Coverage data is based on head (7fd6c65) compared to base (3ea983f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   85.10%   85.10%
=======================================
  Files          35       35
  Lines        1296     1296
=======================================
  Hits         1103     1103
  Misses        131      131
  Partials       62       62

Impacted Files
Coverage Δ

internal/sirius/assign.go
66.66% <100.00%> (ø)

internal/sirius/cases_by_assignee.go
75.00% <100.00%> (ø)

internal/sirius/cases_by_team.go
76.92% <100.00%> (ø)

...ternal/sirius/cases_with_open_tasks_by_assignee.go
72.72% <100.00%> (ø)

internal/sirius/feedback.go
53.12% <100.00%> (ø)

internal/sirius/mark_worked.go
50.00% <100.00%> (ø)

internal/sirius/my_details.go
70.96% <100.00%> (ø)

internal/sirius/request_next_cases.go
50.00% <100.00%> (ø)

internal/sirius/request_next_task.go
50.00% <100.00%> (ø)

internal/sirius/tasks_by_assignee.go
68.57% <100.00%> (ø)

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


chore(appeals): back-office consumer functions source

Adjust the source of newly created backoffice appeals functions.

lgtm


externalDependencies not working as expected during serve with Vite

Command
serve
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
When marking certain dependencies as external via option externalDependencies we get runtime errors during dev mode with the Vite server because Vite will prefix the import specifiers with /@id/ (during import-analysis).
For example:
import { BehaviorSubject, Subject, Subscription } from "/@id/rxjs";
import { map, first } from "/@id/rxjs/operators";

This breaks expected behavior, for example when we want to use an importmap to resolve external dependencies at runtime.
I realize that this is an issue with Vite itself, more then Angular: open issues exist on Vite since quite some time already:

https://github.com/vitejs/vite/issues/6582
https://github.com/vitejs/vite/issues/2483

However, I do believe that we can work around this issue by adding a small Vite plugin in vite-server.ts to remove this /@id/ prefix for explicit externalDependencies. I would be more than willing to submit a PR after discussion.
Minimal Reproduction
Here's a StackBlitz link with a simple repro case:
https://stackblitz.com/edit/stackblitz-starters-rbro7s?file=angular.json

rxjs and rxjs/operators are declared as externalDependencies
importmap is added in index.html to resolve these dependencies at runtime

Exception or Error
Failed to load module script: Expected a JavaScript module script but the server responded with a MIME type of "text/html". Strict MIME type checking is enforced for module scripts per HTML spec.

Your Environment
Angular CLI: 18.0.7
Node: 18.20.3
Package Manager: npm 10.2.3
OS: linux x64

Angular: 18.0.6
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1800.7
@angular-devkit/build-angular   18.0.7
@angular-devkit/core            18.0.7
@angular-devkit/schematics      18.0.7
@angular/cli                    18.0.7
@schematics/angular             18.0.7
rxjs                            7.8.1
typescript                      5.4.5
zone.js                         0.14.7

Anything else relevant?
No response

An upstream fix would be ideal. However, if the code is minimal, the team would welcome a contribution to address the issue.


login should redirect to different pages ...

login should return to the previous page the user was on...not mycenter page

I am ok with this issue for now...this shall be handled by the frontend framework, like angular url snapshot


📖 subscribe examples

Codecov Report

Merging #306 into master will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
+ Coverage   51.21%   51.36%   +0.15%
==========================================
  Files         212      212
  Lines        9537     9535       -2
  Branches     1321     1321
==========================================
+ Hits         4884     4898      +14
+ Misses       4134     4115      -19
- Partials      519      522       +3

Impacted Files
Coverage Δ

src/SDK/Common/CustomFunctions/CustomFunctions.cs
44.82% <0%> (-27.59%)
:arrow_down:

...BulkCreate/DeviceEnrollmentBulkCreateRepository.cs
42.3% <0%> (-11.27%)
:arrow_down:

src/SDK/Common/PaginatedResponse.cs
81.39% <0%> (+1.16%)
:arrow_up:

src/Legacy/Connect/Api/ConnectApi.Notifications.cs
39.39% <0%> (+2.2%)
:arrow_up:

...Connect/Model/Notifications/NotificationMessage.cs
57.89% <0%> (+5.26%)
:arrow_up:

...acy/Connect/Model/Notifications/DeviceEventData.cs
47.61% <0%> (+38.09%)
:arrow_up:

...egacy/Connect/Model/Notifications/ResourcesData.cs
94.11% <0%> (+94.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b72ca0e...274e141. Read the comment docs.


added cssModules for sass, css in  createConfig.js

Added support for css modules for *.module.css and *.module.scss files in webpack configuration
The following libraries have been updated:
"css-loader": "^3.0.0",
"mini-css-extract-plugin": "^0.7.0",
"postcss-preset-env": "^6.6.0",
"react-dev-utils": "^9.0.1",
"webpack": "^4.35.2",
The following libraries have been added:
"node-sass": "^4.12.0",
"postcss-normalize": "^8.0.1",
"sass-loader": "^7.1.0",

I think this should be two separate pulls, one for .module.css for razzle core and another for .module.scss for razzle-plugin-scss.

I think you have to change this config in razzle-plugin-scss package!

In modern web development we have to use preprocessors one way or another. CssModules proven well Why not include it in the engine? This will save time on the extension of the config and reduce the likelihood of errors

Yes, but you added scss as a dependency to razzle core that may not compile on some archs. Also if this is a plugin it can have more frequent updates independent of razzle core. I would recommend either separate the scss and css parts to scss-plugin and core or just add it to the scss-plugin so you can opt in on css modules, imho css modules is a anti pattern that makes large bundles and only needed if you mix different css ui libraries. But opt in is better than not being able to opt out. Plugins seems to be the preferred way of adding features to razzle.

I agree with you that the use of the plugin will release frequent updates and this is a very strong argument. 😀
css modules will be used only for those files that contain in the name *.module.css or *.module.scss
Create-react-app works on the same principle, and contains it all in the core
Thus, the developer has a choice of what to use, pure css or cssModules
At the moment there is an initiative to add cssModules in chrome. Let's see how this direction will develop

closed in favor of #1114


docs(lib): adds casl-angular

I added a library which allows to integrate CASL (authorization library) with Angular 2+. There are also a lot of interesting stuff in  documentation - https://stalniy.github.io/casl/ and related articles on Medium.
The library has been around for almost a year, I used it on several projects and believe it's a very good addition to this list.
P.S.:

I read guidelines but I need to add a section and library, that's why I think it would be good to do in one PR :)
Direct link to https://devarchy.com/angular returns 502. Works only if I go to https://devarchy.com and then click on Angular

I'm busy with Reframe atm (https://github.com/reframejs/reframe) and adding a new category is not entirely trivial with the current system. I want to rewrite devarchy in the long term. Don't know when this will happen though. Maybe add it to misc category on devarchy in the mean while. Thanks!

Probably somewhere in awesome React repo I mentioned that devarchy login doesn’t work. So I can’t add anything :)
It redirects to localhost during oAuth flow

The login problem should be fixed


User on gallery detail page for black owned gallery sees ribbon

GRO-771
There might be a less repetitive solution and I'm open to suggestions, but everything I tried seemed overly complex or confusing so I just did the straightforward thing. The "Black Owned" category doesn't actually exist yet, so I used a different category to get the screenshots.

@dzucconi do we have a less repetitive way to incorporate a new component such as this Ribbon? We do not really have a set precedent or previous example on how we would want to incorporate something like this.

So, yeah:

First we'd want to get a spec in the design system Figma first. Presumably there'd be variants on this; different configurable colors, sizes, and sanctioned labels.
Once we have a spec we could implement this in Palette.

@lilyfromseattle sounds like we get to build a brand new Palette component! Woooo!
You should sync up with @dzucconi


How to let SCRecorder play mobile video

you think too much

Yeah, so I wrote a solo player myself.

Yeah, so I wrote a solo player myself.
hi LabelChuang  , have you got the solution for playing local video?


replace Atom

Atom is sunset 2022-12-15 https://github.blog/2022-06-08-sunsetting-atom/
We need to replace it with something else. Very sad.
EDIT: We will use vscode — available on Windows, macOS, Linux.

https://code.visualstudio.com/Download looks good

Build locally while testing
Learn to build the site locally while you edit, e.g. I use run_jekyll.sh:
# useful jekyll info
# https://mademistakes.com/mastering-jekyll/how-to-link/

# sudo port install rb25-bundler
# bundle-2.5 config set --local path '/Users/oliver/Library/ruby/vendor/bundle'
# used bundle-2.5 install

rm -r _site
#bundle-2.4 exec jekyll serve --watch --force_polling --future  --incremental #--drafts
#bundle-2.5 exec jekyll serve --watch --future --incremental --config _config-devel.yml
bundle-2.5 exec jekyll serve --watch --future --incremental

Then open http://localhost:4000/ to see the site.
Files to update
Update any files that mention text editor/atom, for instance

https://github.com/Py4Phy/PHY432/blob/main/_modules/week-01.md
https://github.com/Py4Phy/PHY432/blob/main/modules/setup_unix/environment_installation.md (including screen shots if necessary)
https://github.com/Py4Phy/PHY432/blob/main/modules/setup_unix/Unix_Shell.md
https://github.com/Py4Phy/PHY432/blob/main/modules/setup_unix/Intermediate_Unix_Shell.md
https://github.com/Py4Phy/PHY432/blob/main/modules/git/Git_basics.md
... probably more (git grep atom)


[4.10.2] address unsafe-eval CSP issues, additional cleanup

Fixes #2620 in 4.10
Fixes #2647 in 4.10
Description
Address Content Security Policies around the use of unsafe-eval; in this case, around the use of new Function
Fixes bugs in CODEOWNERS
Specific Changes

Further split Node and browser implementations of files in botframework-streaming

Adds "dom" lib to tsconfig-browser.json in `botframework-streaming

Additional cleanup in tests and style in botframework-streaming
Fix typos in CODEOWNERS file

Testing
E2E WIP, unit tests passing

Pull Request Test Coverage Report for Build 161621

40 of 74 (54.05%)  changed or added relevant lines in 6 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.06%) to 82.91%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

libraries/botframework-streaming/src/webSocket/browserWebSocket.ts
0
5
0.0%

libraries/botframework-streaming/src/webSocket/nodeWebSocketClient.ts
22
29
75.86%

libraries/botframework-streaming/src/webSocket/browserWebSocketClient.ts
11
33
33.33%

Files with Coverage Reduction
New Missed Lines
%

libraries/botframework-streaming/src/protocolAdapter.ts
1
78.38%

libraries/botframework-streaming/src/webSocket/webSocketTransport.ts
1
85.44%

Totals

Change from base Build 159077:
-0.06%

Covered Lines:
15151

Relevant Lines:
17364

💛  - Coveralls


Dependencies update

Note $subject

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7078231146
Status: failure


Tracking Issue: MVP Animation

This issue is meant to be a more actionable/scoped version of #91 and #95, specifically scoped to the goal of providing a minimum low level API for managing asset based animations in Bevy.
RFCs
The overall design for these systems are detailed in the following RFCs. Later parts of the implementation are blocked on the design feedback on these individual RFCs.

[ ] bevyengine/rfcs#49: Low level storage ans sampling design.
[ ] bevyengine/rfcs#51: Composition API and sampling strategy

Implementation/Merge Strategy
This is a fairly large area that touches multiple core areas in the engine. Even with a complete prototype, introducing the system into Bevy in one large PR is likely difficult or impossible (see #1429). The following individual segments will likely need to be individually addressed to piecemeal introduce parts of the system into Bevy proper.

[x] Assets: #3751
[ ] Assets; #3722
[x] Rendering: #4238
[ ] Rendering: Rendering Morph Target Displacements
[ ] Storage: Curve traits and basic concrete implementation (CurveFixed)
[ ] Storage: Curve compression/quantization
[ ] Storage: AnimationClip Asset
[ ] Storage: AnimationClip Serialization
[ ] Sampling: Basic skeletal animation player supporting start, stop, seek operations.
[ ] Composition: Basic AnimationGraph implementation.
[ ] Application: Skeletal animation application systems
[ ] Application: General Reflect-based animation application systems

A full property based animation system is largely enabled by the designs in the RFCs listed; however, at the time or writing, there currently exists no way to get references to components that implement Reflect via the component name. This blocks the ability to apply sampled and blended values to arbitrary component properties.

This is already possible. We use this functionality for our scene system. TypeRegistry::get_with_name gets you the type registration, which can then be used to get the ReflectComponent impl, which will return you an Option<&dyn Reflect> (or mutable variant)  for a given entity.

@cart: updated the main issue to reflect (haha) this. I'll need to dive deeper into the actual reflection APIs to devise an implementation strategy though.

This is a very welcomed addition!

What about animation blending (like Unity's Mecanim)?

What about animation blending (like Unity's Mecanim)?

 However, the proposed animation graph API is low-level enough like Unity's Playables API, which supports arbitrary blending control, and you could potentially build a full state machine driven animation system on top of it.

Is the eventual intention to allow designers (i.e. people using the Bevy Editor, not coders) to apply arbitrary animations that drive arbitrary component values?
This is something that @james7132 brought up in the Schematics discussion https://github.com/bevyengine/bevy/issues/3877#issuecomment-1057752326. I'm wary of that, for reasons that overlap with the arguments made in favour of Schematics.
Firstly, there's the standard issue of tying animation assets too closely to ECS implementation details, meaning that refactorings to the ECS layout would break compatibility with authored animation (and other) assets. This is the problem that Schematics aim to solve, and may be addressable by some design in which animations drive Schematic values instead of component values directly. There's a little discussion of that in #3877.
There's also an ECS philosophy question that I'd be interested to hear the official stance on:
Should ECS Systems be expected to gracefully handle all typesafe Component values, even those that don't make semantic sense? Or alternatively, is it acceptable to rely on engineering knowledge about what values get set on the Component fields by the code? For example, should Systems processing a Component holding a direction vector be expected to have well defined and sensible behaviour if that vector is not in fact normalized?[^1]
On the one hand, in ECS it's hard to keep track of all of the places where a value is mutated, so one could argue that it's dangerous to make assumptions about data values. On the other hand, actually covering every corner case would have both engineering and runtime overhead. Inevitably, cases would be missed. In practice, I've never taken this rigorous approach.
The reason that this is relevant to animation is that if we allow arbitrary animations to make arbitrary changes to entity data, it becomes incredibly easy for these implicit invariants to be broken. The animations may be composed by people who are completely separate from the code, and who don't have any understanding of the restrictions and dangers. We don't want a scenario where somebody tries to animate a value and causes undefined behaviour because the value they applied was unexpected.
For these reasons, I think it's a bad idea for animations to directly touch ECS data without going through some validating mediation layer that only allows semantically valid animations. The ideas around Schematics may work for this, although I don't really know what that looks like yet.
What's Bevy's general philosophy to these problems around data validation and trust, and how that interacts with animations?
[^1]: This particular example might be a good candidate for newtype typesafety.

The intent is to have it work on Component that implements Reflect. For the most part, this usually implies that what you're writing to is mostly just read-only data that has no invariant to enforce (i.e. materials).


Update github actions to docker/build-push-action@v3

Our actions currently use https://github.com/docker/build-push-action@v2 which uses some deprecated GitHub actions functionality. We should upgrade the actions to docker/build-push-action@v3.

I think v3 is backward compatible with your usage. I assume uses: build-push-action@v2 should simply be replaced by uses: build-push-action@v2 in main.yml and dev-build.yml


Updated events page + other tidying

👷 Deploy Preview for orecchia processing.
🔨 Explore the source changes: 229244518ad4bb2f144b4b08696037530e22f803
🔍 Inspect the deploy log: https://app.netlify.com/sites/orecchia/deploys/61eaee8fe5630700093751c0


Support for inline HTML

Right now the Typora extension does not support inline HTML, contrary to its namesake app.

It this the same problem as I have, that when I edit markdown files, then HTML tags are automatically converted to code?

That drove me nuts and I decided not use the extension.

Then I'm on the same path as you are. Did you find something other? Currently I found Mark Sharp. My main purpose is to defeat managing bigger tables.

After trying quite a few VS Code extensions, none of which quite cut it for me, I came to the conclusion that VS Code may be OK for some basic note-taking but will remain clunky. Mind you, I don't have grandiose requirements for an app.
Thanks for mentioning Mark Sharp, I had never heard of it but you made me curious, esp. since like the Typora extension and Typora the app, or Obsidian the app, it has in-Preview editable live rendering, which is one of the things I was so desperate for.
I have been using Obsidian almost from Day 1, and as an app have been very happy with it. But I cannot stand the moderators on Obsidian's Discord channel, and the extreme customizability of the app means one spends a lot of time tweaking/tinkering/fine-tuning.
I took another look at VNote, which I used many years ago but was a bit confounded by its system. Now, esp. after my VS Code disappointments, I am very happy with VNote, have been able to figure out properly how it works, and must say I am impressed. It does, however, lack that  in-Preview editable live rendering.
It is not fair to keep talking in this thread about other apps, so, if you agree, let's communicate directly. My direct email address is<EMAIL_ADDRESS>

Maybe the link helps the owner of the repo to get some ideas for optimizing his own project :-) since you mentioned Discord, you can find a link to Discord in my profile.


[sdl2] Fix pkgconfig: missing system libs

CMake Error at scripts/cmake/vcpkg_fixup_pkgconfig.cmake:232 (message):
  Library "glib-2.0" was not found! If it is a system library use the
  SYSTEM_LIBRARIES parameter for the vcpkg_fixup_pkgconfig call! Otherwise,
  correct the *.pc file
Call Stack (most recent call first):
  scripts/cmake/vcpkg_fixup_pkgconfig.cmake:298 (vcpkg_fixup_pkgconfig_check_files)
  ports/sdl2/portfile.cmake:97 (vcpkg_fixup_pkgconfig)
  scripts/ports.cmake:79 (include)

Above traceback encountered for all of the following libraries glib-2.0 gobject-2.0 gio-2.0 ibus-1.0

Fixes #13236

Hi @gdxn96, thanks for the PR!
Could you try the branch in #13126 and see if that solves your issue? If not, could you please post the contents of the .pc files here?
Because glib is packaged inside vcpkg, we don't want to directly link the system glib accidentally.

@ras0219 unfortunately that branch did not fix the glib issue
-- Building x64-linux-rel
-- Fixing pkgconfig file: /home/george/Desktop/git/vcpkg/packages/sdl2_x64-linux/lib/pkgconfig/sdl2.pc
CMake Error at scripts/cmake/vcpkg_fixup_pkgconfig.cmake:136 (message):
  find_library() failed with result: CHECK_LIB_glib-2.0_RELEASE-NOTFOUND

      find_library(CHECK_LIB_glib-2.0_RELEASE NAMES "glib-2.0" PATHS /home/george/Desktop/git/vcpkg/packages/sdl2_x64-linux/lib/pkgconfig/../../lib "/home/george/Desktop/git/vcpkg/installed/x64-linux/lib" NO_DEFAULT_PATH)
Call Stack (most recent call first):
  scripts/cmake/vcpkg_fixup_pkgconfig.cmake:234 (vcpkg_fixup_pkgconfig_check_files)
  ports/sdl2/portfile.cmake:97 (vcpkg_fixup_pkgconfig)
  scripts/ports.cmake:79 (include)

Error: Building package sdl2:x64-linux failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `./vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: sdl2:x64-linux
  Vcpkg version: 2020.06.15-unknownhash

sdl2.pc file
prefix=${pcfiledir}/../..
# sdl pkg-config source file

exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include

Name: sdl2
Description: Simple DirectMedia Layer is a cross-platform multimedia library designed to provide low level access to audio, keyboard, mouse, joystick, 3D hardware via OpenGL, and 2D video framebuffer.
Version: 2.0.12
Requires:
Conflicts:
Libs: -L"${libdir}" -Wl,-rpath,${libdir} -Wl,--enable-new-dtags -pthread -lSDL2  -lglib-2.0 -lgobject-2.0 -lgio-2.0 -libus-1.0 -ldbus-1 -l/usr/lib/x86_64-linux-gnu/libsndio.so -ldl -lm  -Wl,--no-undefined -pthread -lSDL2
Cflags: -I"${includedir}/SDL2"  -D_REENTRANT

@gdxn96 Could you provide your broken sdl2.pc?

The one I have above? @JackBoosY
If not that one then I'll reset to master and reinstall later tonight to generate another

@JackBoosY
broken sdl2.pc
prefix=${pcfiledir}/../..
# sdl pkg-config source file

exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include

Name: sdl2
Description: Simple DirectMedia Layer is a cross-platform multimedia library designed to provide low level access to audio, keyboard, mouse, joystick, 3D hardware via OpenGL, and 2D video framebuffer.
Version: 2.0.12
Requires:
Conflicts:
Libs: -L${libdir} -Wl,-rpath,${libdir} -Wl,--enable-new-dtags -pthread -lSDL2
Libs.private: -lglib-2.0 -lgobject-2.0 -lgio-2.0 -libus-1.0 -ldbus-1 -l/usr/lib/x86_64-linux-gnu/libsndio.so -ldl -lm  -Wl,--no-undefined -pthread -lSDL2
Cflags: -I${includedir}/SDL2  -D_REENTRANT

I think that this is indicative that we can't expect to list out the full set of system dependencies; it would require us to somehow divine the precise naming and linkage structure of every system out there.
For now, this is blocked on #13126

If you install glib from vcpkg, you only have to set ibus-1.0 as a system dependency. So, the patch should be changed to depend on glib and add ibus as a system dependency.

If you install glib from vcpkg, you only have to set ibus-1.0 as a system dependency. So, the patch should be changed to depend on glib and add ibus as a system dependency.

Was there a documentation on how this could be achieved? It seems more safer than deleting ibus from the host environment.
When I added sdl2 as part of dependencies in vcpkg.json, vcpkg automatically searches for sdl2's dependencies within its ports. How can we add a specific library that are present in the host environment to be used by vcpkg when searching for dependencies?

Just wanted to add to the discussion as I mistakenly opened an identical PR in #14019
The root issue is that the SDL2 CMakeLists.txt detects that an ibus-1.0 development package is available and uses pkg-config to add fetch linker flags for ibus. The resulting dependencies can be seen by manually running pkg-config on a machine with this package installed (libibus-1.0-dev on an Debian/Ubuntu distro):
$ pkg-config --libs ibus-1.0
-libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0

The search for Ibus is scoped to only apply to Linux systems. Personally, I'd recommend adding a patch which simply removes the ibus detection lines from SDL2's CMakeLists, and the entire issue at talk here could be closed.

@jube or @JackBoosY: Seeing there appears to be no further progress here, and I'm keen to get this solved, is it OK for me to open a new PR based on my suggested fix?

@jgilje Sure, please!

@jube or @JackBoosY: Seeing there appears to be no further progress here, and I'm keen to get this solved, is it OK for me to open a new PR based on my suggested fix?

If you know what you're doing, please go for it, lord knows I don't 😁


Maybe include  upstream

https://github.com/conda-forge/qgis-feedstock/blob/0d94ff5f5dc085a5bc5db86408da180d0d70c79a/recipe/patches/0005-include-functional.patch#L19
What platform was it included for?

Would love to get that upstream! Been meaning to submit a few issues/questions now the recipe builds but a little out of steam just now.
The patch is needed to build on Linux (GCC7 - see transition notes) and was also needed on Windows (Visual Studio 14). It wasn't needed on Mac (Clang 4.0) but I left it applied on this platform anyway

I can build and test on Linux (clang) and windows (MSVC) and I'd be happy to review if you want to make a PR upstream.

Merged upstream and backported to LTR version so we can remove our patch in the next version. Thanks!

@elpaso thank you! Sorry I didn't have time to review but I see other core devs helped :)


user update action and reducer

Closes: #441
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.(Specially for Backend)
[x] My changes generate no new warnings.

@codewithvk  i think you forgot to label it


[Bug] When inputting Chinese, the link disappears

Link does not disappear
I am using C language without annotations
Animation demonstration

Link disappear
I am using C language with annotations
Animation demonstration

Send me the whole text the code block contains

Send me the whole text the code block contains

I’m interested in Obsidian
First of all, tell me bit about wha ote-taking  fds
wha ote-taking  fdsfds fsd
-> [[No prior experience|I have no prior experience]] ff分

Official Help Site
输入 [[From standard note-taking]] 输入

What is this place?
This is a sandbox vault in which you can test various functionality of Obsidian.

[!Warning]
Your changes will not be saved, so please don't take actual notes in this vault.

[!Note] Beta vault - contributions are welcome!
This sandbox vault is in beta!
If you spot a typo or a mistake, feel free to submit a pull request here .

fjdkjfk

I am pretty sure, that this has something to do with your input method as last time, because it works for me:

How are you inputting chineese text? Are you on Windows? Did you add a chineese keyboard layout? Are you using a software for that? Or how?
Provide details so I can reproduce the issue.

you should add //，please refer https://github.com/mugiwara85/CodeblockCustomizer/issues/57#issue-1918639663

I did. Still works:

This is too strange. I have changed multiple Chinese input methods and killed all software backends that may affect input behavior, but there is still a phenomenon of link disappearance
Here is the test library I am using
Obsidian Sandbox.zip
I am using a Windows system, The version number is 22H2

Hmm, interesting. I opened the Sandbox you sent, but it is still displayed correctly:

If I enter English after the link, it will not disappear. Once I enter Chinese after the link and go to the screen, the link will disappear

but you enter Chinese with your input method, right? If you copy somewhere chinese text, and paste it, then it will work probably. That's why I say it has to do something with you input method.

Can you send maybe the html of that line? Maybe we can see there, what's happening

Can you send maybe the html of that line? Maybe we can see there, what's happening 你能把这行的 html 发给我吗？也许我们能看到那里发生了什么

how to get html

press CTRL+Shift+I and navigate to that line

yes, that one, but copy it and paste it here.

1// 输入 From standard note-taking

It may really be an input method issue, and I tested several input methods and found that one of them did not cause this problem

It probably is. If you give me a link for one of your input method software then I can download it, and have a look at it.

https://github.com/rime/weasel/releases/tag/0.15.0

Now I have changed input method to sogou, this question is no longed appear


Prepend protocol to new links

New links that don't have a protocol should be prepended with http:// to ensure they can always be correctly embedded.

Assigning to @stuartf for fix

ready for review

Coverage increased (+0.03%) to 90.17% when pulling 463cd742d00b199f8c026361723e8c9f2bacb283 on stuartf:linkprotocol into 15e2e2e19a0fa4298f47c33378846d61a620d862 on oaeproject:master.

Followed up and merged


Breakout Setting Methods

Break out the setting methods from the main script for ease of adding
new functionality.

Check #81 and the includes branch. Adding new functionality is possible there using -include command line parameter - see relevant documentation.

The problem for me with the current approach is the base Win10.ps1 script wants to execute as soon as it is loaded, which makes the many useful configuration functions impossible to use in a more complex powershell-based installer creator and platform configuration solution.  I would like to help identify and add more useful functions to the script library you've started.

I actually like this idea a little more than #81 as it separates the function definitions from the execution logic and improves reusability of the functions without forcing the user to use the default execution and command line handling code.
With this, you could even replace the preset files with standalone .ps1 scripts just containing a list of function calls. (The current preset files are interpreted line-by-line using Invoke-Expression anyway, so there's not much difference from ps1 files.)

From technological standpoint, I like the idea of separation for all the reasons already listed. However at the same time, I need to keep in mind also the BFUs for whom right clicking and confirming an UAC prompt is a pinnacle of their technical skills. I'm inclining towards merging, but I need to think about the possible consequences a bit more.

I'd also support such modularization in general. I'd suggest to move functions to (scriptname).psm1 module and use the capability from includes branch (#81) simultaneously.
I'd go even further and keep functions lists in separated files only, i.e. remove default preset from Win10.ps1. Also this long list is a bit annoyning residing at the start of the script. ;) Regulating the script too much in favour of BFUs could be quite a limiting factor for making future technical capabilities. I don't see any problem with BFUs and their pinnacle of skills anyway, they can still have their default launcher. Main script should naturally become harmless doing nothing without specifying what to do.

Since I have all the people asking for pretty much the same features in this thread, I'll write here instead of continuing in #81 and #115.
Please check the branch includes which I have updated a few minutes ago. It combines both the changes which this PR aimed to introduce and the request for custom tweaks as discussed in #81.
The main loop in Win10.ps1 now contains only the logic for parsing command line parameters and preset files and a single function for administrator privileges elevation. That function is specifically tailored for the script as it uses variables set during parsing, so it doesn't make sense to have it separated. Everything what was in the $tweaks array with the default preset has been moved to Default.preset file and all the tweak functions have been moved to Win10.psm1 file. If you now run Win10.ps1 alone without any parameters, it does exactly nothing.
The minimal params which you have to supply now for the PowerShell command to do something are

the main loop - Win10.ps1
the tweak library - e.g. Win10.psm1
the preset - e.g. Default.preset

Some more info about the command line parameters and general usage can be found in Advanced usage section of the includes branch.
Let me know if it suit your needs or if you're still missing some important features. If there won't be any strong objections, I'm planning to merge it to the master later this week.

🥇 This is just sooo awesome! Thanks!

This PR has been reimplemented as part of 1e977ab95fe04a99cdd152d342586de01d0aec96. Thanks everyone for suggestions.


Same package.json for anomaly_npm and malware_depedency_npm

Below files are equal.
xygeni-goat-main\source\bad_deps\anomaly_npm\package.json
xygeni-goat-main\source\bad_deps\malware_dependency_npm\package.json
When running the scanner on the first, the dependency is tagged as anomaly and malware_dependency. After adding the second, results are the same. Are both really needed ?

This is fine. I mean, those are sources meant to reproduce a specific kind of defect.
However, in particular that file produces two of them, but they are in different folder, one for each issue.
From my point of view those are different CTF-like exercises.


Client side navigation interrupts loader revalidation

What version of Remix are you using?
1.6.5
Steps to Reproduce
I have a webshop with a product page, which submits a form via a fetcher to add products to a cart. I need the updated number of items in the cart a bunch of places on the site, so I also have a loader which loads the cart.
When the form is submitted and items are added to the cart the loader function correctly runs again and the cart data gets revalidated across the site. However if I add something to the cart and then quickly navigate elsewhere on the page, the data revalidation gets interrupted and the cart data is now out of sync.
I've tried to log the data in the loader, and it looks like it still runs no problem and gets updated data. However the data never seems to get updated and sent to the useLoaderData hook.
Expected Behavior
I would expect the updated data from the loader function to update the data on the page, even when the user navigates to a new page before the loader data gets back.
Actual Behavior
Data on the client is out of sync until a) something happens so the loader gets called again or b) the page gets reloaded.

@sjwinther Can you confirm if this is still an issue for you?  Remix 1.10.0 switched over to using @remix-run/router which was a complete rewrite to replace the old TransitionManager in earlier versions of Remix.  I have a hunch that the new implementation properly handles this case but please let us know if you're still seeing the issue.


Super minor corrections

If you want to submit PR with minor typo fixes, at least do all of them at once.

Closing due to lack of any reply. If you are interested in correcting typos, as I said, do all you can find at once, including in code and javadocs.


Failing to import Obj-C header

Using ConfidoIOS as a pod, fails on build time with:

there is no such header as /usr/include/CommonCrypto/CommonCrypto.h on my system, maybe we should use some sort of CommonCrypto wrapper like https://github.com/soffes/Crypto

I had a similar issue. Should be a symlink there. Fixed by running
xcode-select install on my machine
On Sun, 6 Dec 2015 at 17:31, Alexej Tessaro<EMAIL_ADDRESS>wrote:

Using ConfidoIOS as a pod, fails on build time with:
[image: screen shot 2015-12-06 at 17 28 47]
https://cloud.githubusercontent.com/assets/2323918/11614594/f7800520-9c3e-11e5-8362-48192a04a5f6.png
there is no such header as /usr/include/CommonCrypto/CommonCrypto.h on my
system, maybe we should use some sort of CommonCrypto wrapper like
https://github.com/soffes/Crypto
—
Reply to this email directly or view it on GitHub
https://github.com/curoo/ConfidoIOS/issues/14.

shouldn't the path be pointing to a XCode location as in https://github.com/henrinormak/Heimdall/tree/master/CommonCrypto?

Think the idea was this means you don't have to have separate modulemaps
for each of the targets, but does need a little bit extra of set up.
On 6 December 2015 at 17:36, Alexej Tessaro<EMAIL_ADDRESS>wrote:

shouldn't the path be pointing to a XCode location as in
https://github.com/henrinormak/Heimdall/tree/master/CommonCrypto?
—
Reply to this email directly or view it on GitHub
https://github.com/curoo/ConfidoIOS/issues/14#issuecomment-162331013.

I got this problem after upgrading to OSX El Capitan, for some reason I had to reinstall XCode command line tools and now I have the headers in /usr/include/...

Being it a public repository maybe we should state on the README that it requires XCode command line tools installed (xcode-select --install as @benjaminboxler pointed out)

Yeah, it was updating to El C that I couldn't update. Make a PR that adds it to the readme


Re-render cause lost in styles of custom nodes

Describe the Bug
I have custom nodes, using tailwind. When I try to update the nodes, react flow re renders and updates the styles. Most of the styles are removed.
I'm using zustand and update nodes in there, and have an useEffect if the nodes change then setNodes is called with new nodes.
As soon as setNodes is called, custom nodes looses its style.
Your Example Website or App
Web app
Steps to Reproduce the Bug or Issue
setNodes set new nodes re reders and looses styles
Expected behavior
The styles should remain same for custom nodes which is not happening
Screenshots or Videos
No response
Platform

OS: [macOS]
Browser: [eChrome]
Version: [11.6.1]

Additional context
No response

hey @sidgangs99 ! Could you create a codesandbox for this?

You can check it out at: https://db-designer-381205.web.app
If you try to click on node and change the data type and save it. It will re render and loose it's style

hey @sidgangs99 ! Could you create a codesandbox for this?

You can check it out at: https://db-designer-381205.web.app
If you try to click on node and change the data type and save it. It will re render and loose it's style

Might be helpful !!!!

I would need to see the code. Where does this useNodes and useEdges come from?

This is coming for zustand

b9bb63308ec.png">

I would need to see the code. Where does this useNodes and useEdges come from?

let me know if you need something else.

You should not create a local component state on top of the zustand state. Then you have to sync your two states which seem to be causing problems. You can follow our Zustand + React Flow guide here: https://reactflow.dev/docs/guides/state-management/
Please re-open if the issue still persists.


Error adding VM to Host Pool

I was unable to see the option in step 4 that states to select Virtual Machine, but I assume it was the Session hosts option under manage.  When I click the +Add button I receive an error that states that the template stored for VMs creation is invalid:
"error": { "message": "The template stored for VMs creation is invalid.", "code": 404 }

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8b6a3e65-41c2-2b42-2a04-64532ba021d3
Version Independent ID: e24ba292-e0fd-20d7-611c-30b1b664390d
Content: Expand existing host pool with new session hosts - Azure
Content Source: articles/virtual-desktop/expand-existing-host-pool.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

@mwchilde Thanks for bringing this to our notice. We are investigating into the issue and will update you shortly.

Could it potentially have anything to do with using the Storage blob option for Image type rather than Gallery when I created the host pool.  I am reading over some of the directions on creating the host pool via PowerShell and I will see if I can create the VM using PowerShell.

@RoopChevuri @stgeorgi Can you please check and add your comments on this.

I was able add a VM manually documented in the following steps and managed image:
https://docs.microsoft.com/en-us/azure/virtual-desktop/create-host-pools-powershell#create-virtual-machines-for-the-host-pool
I did not use a template so I had to do my best with matching the VM settings.  I am not sure if it is related or not, but when I go to Export Template on one of my existing host pool VMs I receive this error:
{"code":"ExportTemplateCompletedWithErrors","message":"Export template operation completed with errors. Some resources were not exported. Please see details for more information.","details":[{"code":"ExportVirtualMachineExtensionNotSupported","target":"Microsoft:2ECompute-JsonADDomainExtension","message":"Virtual machine extension 'Microsoft:2ECompute-JsonADDomainExtension' is not supported for template export."}]}
Just seeing if there is any chance that is related.  Thanks!

@mwchilde Glad to hear that the issue is resolved.

@mwchilde
We will now proceed to close this thread.
However, you comments will remain on this page and the product team is also looped in the issue for adding their insights if any.
If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion.


Allow precompilation

Title says it all.

Tests pass locally, although I could imagine that GZip isn't safe to precompile

As compilation is a file-level property, this was moved outside of the module.

AppVeyor failure is a false positive, so I'm ignoring given all the other settings where tests passed.


fix: Added a condition, if docker is alive or not.  #1983

This caused problems when docker was not running which resulted in the CLI misinforming me that the database was already running. But it wasn't.
Closes #
✅ Checklist

[x] I have followed every step in the contributing guide (updated 2022-10-06).
[x] The PR title follows the convention we established conventional-commit
[x] I performed a functional test on my final commit

Changelog
[Short description of what has changed]
Added a simple condition to run docker info to check if the docker daemon is actually running or not.
Screenshots
[Screenshots]

In this image you can see that the both of the execution of start-database.sh are successful. But the second one should fail because I killed the docker daemon but the CLI wasn't able to pick it up.
💯

Closed by https://github.com/t3-oss/create-t3-app/pull/1975


feat: merge audit branch

The audit branch contains several important changes:

The resource metadata are now manipulated as a model. But a special model that is automatically registered by sozo when the owner of the world deploys it.
The executor is no longer present. Now, the models are deployed to ensure there's no attack vector by executing the library_call syscall.
Add support for Array<felt252> in models.

Tasks:

[ ] Ensure the address of a model is always tracked by the manifest.
[ ] Verify how the array is handled into introspect and associated layout. SQL test are failing for this reason.

Wondering if the ResourceMetadata model should be handled as any normal model. Or if we keep manipulating it as a special dojo model.

@Larkooo if you have a chance mate, could you take a look at https://github.com/dojoengine/dojo/actions/runs/7904872397/job/21576203978?pr=1533#step:5:897 in case you already faced this working on libp2p and wasm compatibility?

@Larkooo if you have a chance mate, could you take a look at https://github.com/dojoengine/dojo/actions/runs/7904872397/job/21576203978?pr=1533#step:5:897 in case you already faced this working on libp2p and wasm compatibility?

oh yep, from what i can see it is caused by a dependency that doesnt compile to wasm - make sure to use a flag to only use it as a dependency when not compiling to wasm

I believe it comes from the "cainome" dependency. It's caused by tokio and maybe some other deps - gotta check if tokio is the only one. Tokio won't compile if the feature "full" is used. Only these features are supported on WASM

I believe it comes from the "cainome" dependency. It's caused by tokio and maybe some other deps - gotta check if tokio is the only one. Tokio won't compile if the feature "full" is used. Only these features are supported on WASM

Appreciate the feedback on that, will double check cainome and possible sources based on that. Thanks mate. :pray:

@ThePinion and @neotheprogramist if you have a chance I would appreciate a counter review on the core contracts changes. :pray:
@neotheprogramist you had started hard and great work on indexing, however for the audit it was removed as we should reconsider the model for this in a later phase. Appreciate your comprehension on that mate.


Make logging pass the original Async context around

This should make tagging systems which use the Async context
work correctly.

Pull Request Test Coverage Report for Build 140

15 of 16 (93.75%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 76.215%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/logger.ml
9
10
90.0%

Totals

Change from base Build 139:
0.4%

Covered Lines:
298

Relevant Lines:
391

💛  - Coveralls


please add me to the team

@chungy Sorry for abusing the bug tracker for this, but could you please add me to team Doom-Utils?

Email probably would have worked, but sure :)

:facepalm: Thanks!


remove unused import

forgot to remove the unused import for random prefix

Thanks for approving so quick. Merging.


Bump Dependencies #1847836221

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/1847836221

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-is-staging seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Feature/add finnish translations

This PR resolves #7
This PR adds Finnish translations for

the WCAG 2.1-criteria
the report itself

I also re-ordered the credits-list on Readme to be in alphabetical order, and updated the eleventy-version to fix most of the security vulnerabilities npm audit revealed.

@eevajonnapanula Many thanks for all your work on this, this is great!
@samikeijonen thanks for your check, appreciate it!


Rendering bugs when abusing custom UI material

Bevy version
0.12.0
Relevant system information
2023-11-07T12:29:00.521816Z  INFO bevy_render::renderer: AdapterInfo { name: "NVIDIA GeForce RTX 2070 with Max-Q Design", vendor: 4318, device: 8016, device_type: DiscreteGpu, driver: "NVIDIA", driver_info:
"512.78", backend: Vulkan }
2023-11-07T12:29:00.874123Z  INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "Windows 10 Home", kernel: "19045", cpu: "Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz", core_count: "6", memory: "15.9 GiB" }

What you did

I started with the UI Material example.
use bevy::{
    prelude::*,
    render::render_resource::{AsBindGroup, ShaderRef},
};

fn main() {
    App::new()
        .add_plugins(DefaultPlugins)
        .add_plugins(UiMaterialPlugin::<CustomUiMaterial>::default())
        .add_systems(Startup, setup)
        .run();
}

fn setup(mut commands: Commands, mut ui_materials: ResMut<Assets<CustomUiMaterial>>) {
    // Camera so we can see UI
    commands.spawn(Camera2dBundle::default());

    let button = commands
        .spawn((
            ButtonBundle {
                style: Style {
                    width: Val::Px(250.0),
                    height: Val::Px(250.0),
                    ..default()
                },
                ..default()
            },
            ui_materials.add(CustomUiMaterial {
                color: Color::WHITE.into(),
            }),
        ))
        .id();

    let circle = commands
        .spawn(MaterialNodeBundle {
            style: Style {
                width: Val::Px(250.0),
                height: Val::Px(250.0),
                ..default()
            },
            material: ui_materials.add(CustomUiMaterial {
                color: Color::rgb(0.0, 1.0, 0.58).into(),
            }),
            ..default()
        })
        .id();

    commands
        .spawn(NodeBundle {
            style: Style {
                width: Val::Percent(100.0),
                height: Val::Percent(100.0),
                align_items: AlignItems::Center,
                justify_content: JustifyContent::Center,
                ..default()
            },
            ..default()
        })
        .add_child(circle)
        .add_child(button);
}

#[derive(AsBindGroup, Asset, TypePath, Debug, Clone)]
struct CustomUiMaterial {
    #[uniform(0)]
    color: Vec4,
}

impl UiMaterial for CustomUiMaterial {
    fn fragment_shader() -> ShaderRef {
        "shaders/circle_shader.wgsl".into()
    }
}

Curious to see if I could attach shaders to existing bevy_ui bundles, and bypass MaterialUiBundle, I attempted to add a Handle<CustomUiMaterial> to a ButtonBundle to see what it would do. I got a white square, and figured I was doing something I shouldn't be anyway, perhaps the other components (background_color / border_color / image) were drawing over it or something. I figured that was somewhat expected behaviour. Then I decided to put them side by side, and encountered some less expected behaviour.
What went wrong
    commands
        .spawn(NodeBundle {
            style: Style {
                width: Val::Percent(100.0),
                height: Val::Percent(100.0),
                align_items: AlignItems::Center,
                justify_content: JustifyContent::Center,
                ..default()
            },
            ..default()
        })
        .add_child(circle)
        .add_child(button);

draws:

but swapping the children
    commands
        .spawn(NodeBundle {
            style: Style {
                width: Val::Percent(100.0),
                height: Val::Percent(100.0),
                align_items: AlignItems::Center,
                justify_content: JustifyContent::Center,
                ..default()
            },
            ..default()
        })
        .add_child(button)
        .add_child(circle);

draws:

We can see that the circle still takes up space, but isn't rendered.
Using other combinations, e.g.
        .add_child(circle)
        .add_child(circle2)
        .add_child(button)
        .add_child(button2)
        .add_child(circle3)
        .add_child(button3);

Additional information
Is it possible the shader is silently crashing as soon as it encounters the ButtonBundle, so using the shader after that fails?
I don't know if this is a bug to fix or just something to be documented.

Could you try on latest main? I fixed two bugs on UI Material (https://github.com/bevyengine/bevy/pull/10421 and https://github.com/bevyengine/bevy/pull/10422) and this could look like the second one


Add badges in README

Added some badges in README

CI workflow status
Code coverage
Latest release version (GitHub release)
Slack workspace

Closes #862

Thanks a lot, @sh-cho! 🚀 👍 💯 Are you using Central Dogma by the way? 😆

Sadly not now 🥲

@sh-cho Hope you can use this someday. 😆


feat: sideshift integration pay

Related to #187
Depends On:

[ ] https://github.com/PayButton/paybutton-server/pull/840

Description
Adds SideShift integration through websockets that communicate to the PayButton Server.
Test plan
This has to be test alongside with https://github.com/PayButton/paybutton-server/pull/840 of paybutton server. First follow the steps at https://github.com/PayButton/paybutton-server/pull/840, and, after that is set up, follow the steps below:

Add to the config file (react/lib/config.json) the property   "altpaymentClient": "mocked".

Let ecash:myxecaddress be an eCash address in your custody. Save the following diff to a file named temp.patch, change the four occurrences of ecash:myxecaddress to your actual address and apply it with patch -p1 < temp.patch:

diff --git a/paybutton/dev/demo/index.html b/paybutton/dev/demo/index.html
index 320dc03..62a26f4 100644
--- a/paybutton/dev/demo/index.html
+++ b/paybutton/dev/demo/index.html
@@ -78,32 +78,34 @@

+

-      <div id="the_widget" class="paybutton-widget" to="ecash:qrmm7edwuj4jf7tnvygjyztyy0a0qxvl7quss2vxek"
-        goal-amount="500000" hover-text="BLARG" amount="1000.69" success-text="WOW!" text="Purchase"
+

-

-        <button onclick="buttonClick()">Switch up widget!</button>
-

-

-

+

-

-        <button onclick="button2Click()">
-          Switch up widget!
-        </button>
+

+

+

-

-

+

+

Run yarn dev. After it is done running, go to http://localhost:10001
There are four widgets.

The first one has a XEC amount > 10 dollars and is editable, so the user should be able to pay with other currencies by clicking on the "Don't have any XEC?" text.
The second one has no XEC amount set and is uneditable, so the user should still be able to pay with other currencies by editing the amount.
The third one has a very small XEC amount set and is editable, so the user should still be able to pay with other currencies.
The fourth one has a very small XEC amount set but is uneditable, so the user should not be able to pay with other currencies.

Try to pay with another currency (I used ethereum in the optimism network, since it's fast and has very small network fees). Make sure that completing a shift should trigger the onSuccess function.
NOTE: The onSuccess function will trigger in the widget being used but the onTransaction function will trigger in the other three, so when testing this is probably best to comment out 3 widgets and only leave the one being tested.

I got to the point of where it asks me to make the payment -- just asking SideShift if they have any suggestions for how to test better without having to use live payments.

got this error

got this error running yarn clean:build

Should be fixed now.


Implement case-sensitive command option

This is a good start, thanks for the contribution! It's missing a couple things that I'll address in further commits:

I'd prefer the name of the property to be caseSensitiveCommands (plural).
Command names should be converted to lower case when they're added to the bot, to avoid accidentally creating unusable commands through including capital letters in command names.


Put the docker install steps in pip or giskard worker start

Can you put a link here please, let's see if it can be resolved? @jmsquare
I'll try to contribute


macOS unidentified developer on update

I've written my app and added an exception so it can run because it wasn't from the app store. However on update I get the error below. Is there any way around this issue when updating on macOS without paying Apple $99 for a Developer ID?

The second line in the dialog seems to imply you can allow it by changing your security preferences.
Also, I could be wrong but isn't there a way around this like right clicking the app then clicking Open (or something like that)?

You can probably get around it by changing your security settings and you can open it by going to the mac settings > security and clicking a button there. Since this is software made for developers this should be fine but I'd like to make software in the same way for non-developer users. Requiring anything extra from a regular user typically ends in failure.

@Style87 You need to be an apple developer, start here: https://developer.apple.com/programs/


treewide: use ifndef guards for config.h variables

This PR replaces:
// #define OPENWSN_% (0)

by
#ifndef OPENWSN_%
#define OPENWSN_% (0)
#endif

It then replaces all the conditionals accordingly to not check if the Macro is defined but if it is "active" (value 1)
This PR is based on  top of #514.

@TimothyClaeys might want to take a look :)

@fjmolinas @changtengfei Updated this PR:

Remove some deprecated code (e.g., FreeRTOS)
Remove deprecated options (e.g., ide option)
Remove tools folder and .project file
Add compile flags to include apps, software modules, stack configuration and board options from the command line

Example: scons board=openmote-cc2538 toolchain=armgcc modules=udp,coap apps=cjoin, boardopt=hw-crypto, stackcfg='adaptive-msf' oos_openwsn.

@fjmolinas @changtengfei I updated this PR:

Feel free to force push if you want, or to open another PR that includes these changes!