[General][Minor][Label] Making React Native More contributor friendly

With 861 + issues and 180+ PRs, I think this efforts would pay off in the long run for RN. @vjeux @brentvatne @ide @mkonicek @satya164 @astreet
First Timers Only
A suggestion to Open Source project maintainers…
<EMAIL_ADDRESS>and this http://up-for-grabs.net/#/tags/JavaScript, understanding that we already had a similar tags but this seems to be a even better approach.

Will get to this asap. Thanks a lot @qbig .

A guide on how to clone and run the project would be very welcome.

@DanielHoffmann https://github.com/facebook/react-native/tree/master/ReactAndroid

@qbig Great suggestion. May be we  could just rename our label Good First Task to up-for-grabs?
It's important to make it easier to contribute. If you've any other ideas please suggest. I would love to collborate with you to get those implemented.
cc @mkonicek @vjeux @skevy @ide @brentvatne

@qbig Awesome. Let me know how it goes.

@qbig Awesome. Let me know how it goes.

@satya164 maybe could just tweet this out once it's merged https://github.com/up-for-grabs/up-for-grabs.net/pull/300/files or just add https://github.com/facebook/react-native/labels/Good First Task somewhere in the Doc

@satya164 maybe could just tweet this out once it's merged https://github.com/up-for-grabs/up-for-grabs.net/pull/300/files or just add https://github.com/facebook/react-native/labels/Good First Task somewhere in the Doc

@qbig Thanks a lot. Yeah we should both tweet it out and add somewhere in the docs.
cc @brentvatne

@qbig Thanks a lot. Yeah we should both tweet it out and add somewhere in the docs.
cc @brentvatne

@DanielHoffmann - Do you want to try to learn how to do that and then write up a guide? Would be best from the perspective of someone who is new as well.
@satya164 - Happy to tweet that out! @qbig - once it's merged can you submit a pull request to add that to our docs :)
Going to close this issue now we can continue discussion on above mentioned pull requests, thanks a lot people! :rocket:

@DanielHoffmann - Do you want to try to learn how to do that and then write up a guide? Would be best from the perspective of someone who is new as well.
@satya164 - Happy to tweet that out! @qbig - once it's merged can you submit a pull request to add that to our docs :)
Going to close this issue now we can continue discussion on above mentioned pull requests, thanks a lot people! :rocket:

It is merged now. Yay!

@satya164  :+1:


implement pmtiles extract [#31, #52]

Experimental cli support for extracting a region from a larger archive, given a maxzoom and GeoJSON multipolygon region.
Limited to credentialed buckets or local files now, public HTTP to come later
Limited to a single download thread
Change directory optimization to be faster and match Java implementation, affects root/leaf sizes

Wow cool, works super fast! it took 16 seconds to create an extract of Berlin 🤯
time ./pmtiles \
  extract \
  https://r2-public.protomaps.com/protomaps-sample-datasets/protomaps-basemap-opensource-20230408.pmtiles berlin.pmtiles \
  --region berlin.geojson

WARNING: extract is an experimental feature and results may not be suitable for production use.
fetching 10 dirs, 10 chunks, 8 requests
Region tiles 3993, result tile entries 3993
fetching 3993 tiles, 107 chunks, 53 requests
fetching chunks 100% |█████████████████████████| (74/74 MB, 7.7 MB/s)
Completed in 16.588543686s with 4 download threads<PHONE_NUMBER>4435986 tiles/s).
Extract required 64 total requests.
Extract transferred 77 MB (overfetch 0.05) for an archive size of 74 MB
Verify your extract is usable at https://protomaps.github.io/PMTiles/
Feedback wanted! report your success or failure to https://github.com/protomaps/go-pmtiles/issues

real	0m16.612s
user	0m0.702s
sys	0m0.333s

-rw-r--r-- 1 root root 71M Sep 14 10:44 berlin.pmtiles


CLI quickstart: create reasonable default policies

ziti edge quickstart stands up one edge router.
To simplify the use it should create a reasonable edge router and service edge router policies -- #all identity roles and service roles respectively

Was closed when edge was merge to ziti and a commit comment referencing an edge issue now referenced this issue. Reopening.


While resolving remote or relative references, json-refs does not do a complete resolve.

For example: I have two swagger specs A and B residing at the same location.
In the following situation, it will correctly resolve a1 with the B1 from the definitions section of B.json. However, it will not resolve B2 (basically it will not traverse further to ensure that all the other locally referenced properties of that model are also fully resolved).

A.json

{
. . .
  "definitions": {
     "A1": {
        "properties: {
            "a1": { "$ref": "./B.json#/definitions/B1" }
        }
     }
  }
}

B.json

{
. . .
  "definitions": {
     "B1": {
        "properties: {
            "b1": { "$ref": "#/definitions/B2" }
        }
     },
     "B2": {
        "properties: {
            "b2": { "type": "string" }
        }
     }
  }
}

Please execute the following example to get an idea.
json-refs resolve  https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/arm-network/2016-09-01/swagger/vmssNetworkInterface.json --filter relative --filter remote

The output swagger will have "$ref": "#/definitions/NetworkInterfacePropertiesFormat" as a reference but there is no definitions section in the output swagger.
Couple of questions:
Btw, I need to do this because swagger-tools does not accept a swagger spec that contains a relative or remote file reference. Hence, I need to resolve them first and then validate the spec.

Is it possible for swagger-tools to handle file references (relative or remote) then it will help us tremendously.

Does sway handle remote or relative file references in a swagger spec?

Once again, thank you for all the quick responses and genuinely all the tools that you are developing in the swagger space are very very useful 👍

json-refs help resolve says -I, --filter <type>       The type of JSON References to resolved.  This means that if you run it the way you mentioned above, you would only resolve relative and remote references.  But there is a bug (#30) that could explain the issue where you point to a local reference in a remote document and it does not full resolve.
As for swagger-tools supporting relative references, that's one of the many reasons sway came to be.  It would be extremely difficult to make swagger-tools' API support relative references.  I'm not saying impossible but with swagger-tools being deprecated, I don't see it happening.
Sway does handle all kinds of references.

One thing that I miss in Sway after using swagger-tools is an api to validate a model definition against a given example or sample data.
In swagger-tools, one can simply do:
swt.validateModel(swaggerSpecInJson, modelReference, sampleData, callback);

After looking at the sway api documented over here, I cannot find something like that.
I do see validateRequest() and validateResponse(), however the API forces me to provide some kind of a request and serverResponseWrapper object.
It takes away the simplicity of validating a sample for a request body parameter or a sample of a response body that swagger-tools provides.
Is it possible to expose an api similar to validateModel in Sway as well in addition to the current validateRequest and validateResponse ?

Well, you can do that with Sway but it's built into it's object model.  So if the modelReference in your case corresponded with a parameter or response, you could do the same.  Here are some of the APIs:

Operation#validateRequest
Operation#validateResponse
Parameter#getValue (the ParameterValue has an accessor that validates)
Response#validateResponse

The only reason validateModel was ever expose was to originally use it in the swagger-tools middleware but since it validates the document and then validates the model, it was too slow.  This is why the middleware doesn't use this approach anymore.
Also, as for the request/response validation requiring objects/wrappers, it's a very simple wrapper.  If you must use something similar to validateModel that can't be achieved via Parameter#getValue(), you could always use lib/helpers.js#validateAgainstSchema which is what is used by all parts of Sway's validation.  It's basically the same approach swagger-tools middleware validation worked, but better.

Also, I'm just telling you how/why things are now.  I'm all ears if there is a better way.  As for the API, I wanted it to be intuitive and to match Swagger objects.  I didn't want to create an object for every type because it just didn't make sense.  From a model perspective, models are used as responses and inputs via parameter bodies.  That's why there are validations for those as they are.
Feel free to make requests in Sway if you need something.  Other than that, I'm closing this because the issue you originally filed is a duplicate of #30.


Midnight time bug

Fixes #87

@burnflare what about #78

Oops this needs to be opened again, against master


workaround C# build failure by ensuring Go1.13 is installed

Workaround the problem with variable golang version on macos workers by always installing golang 1.13 (see b/147650635)
Fixes https://github.com/grpc/grpc/issues/21626

This still doesn't quite work (for some reason, go still reports version 1.11.1 even after installing go1.13.1)
++ which go
/usr/local/bin/go
++ go version
go version go1.11.1 darwin/amd64
++ curl -O https://dl.google.com/go/go1.13.6.darwin-amd64.pkg
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0  116M    0 26762    0     0   175k      0  0:11:18 --:--:--  0:11:18  175k
 31  116M   31 36.7M    0     0  31.0M      0  0:00:03  0:00:01  0:00:02 31.0M
 62  116M   62 72.8M    0     0  33.5M      0  0:00:03  0:00:02  0:00:01 33.5M
 93  116M   93  109M    0     0  34.5M      0  0:00:03  0:00:03 --:--:-- 34.5M
100  116M  100  116M    0     0  34.6M      0  0:00:03  0:00:03 --:--:-- 34.6M

real	0m3.379s
user	0m2.906s
sys	0m0.319s
++ sudo installer -pkg ./go1.13.6.darwin-amd64.pkg -target /
installer: Warning - A previous installation of Go exists at /usr/local/go. This installer will remove the previous installation prior to installing. Please back up any data before proceeding.
installer: Package name is Go
installer: Installing at base path /
installer: The install was successful.

real	0m32.847s
user	0m0.317s
sys	0m0.100s
++ which go
/usr/local/bin/go
++ go version
go version go1.11.1 darwin/amd64


Bash prompt, php version was never updated

The bash prompt was never updated.
Before the change:
~ > me@debian [php:5.6.13-system]
$  phpbrew use 5.4.45
~ > me@debian [php:5.6.13-phpbrew]
$

After the change:
~ > me@debian [php:5.6.13-system]
$  phpbrew use 5.4.45
~ > me@debian [php:5.4.45-phpbrew]
$

How fast...

:D


Relation Widget: Provide ability to customize slice

Describe the solution you'd like
It looks like we may be capping the relation widget at 20 entires; via https://github.com/netlify/netlify-cms/blob/b4041d39713a781bc7a1e29acf2622df50f9b5c1/packages/netlify-cms-widget-relation/src/RelationControl.js#L144
Has it been considered at all to allow this to be a configurable option? We just went over that limit in a certain situation with authors; and introduced a bit of confusion since the UX around searching wasn't super-clear.
Thanks as always!

Infinite loading could work, not sure how well that's supported in react-select, though.

@erquhart Thanks for the response! I created a PR in case someone would want to add a specified limit instead of the hardcoded one provided.

Nvm, looks like react-select is not supporting that ever lol

Merged in, so closing this one 🎉


Clipboard Copy & Paste BITMAP support

X11 clipboard
http://stackoverflow.com/questions/1868734/how-to-copy-to-clipboard-with-x11


delete redundant table

fix https://github.com/riscv/riscv-cheri/issues/145

This is also part of https://github.com/riscv/riscv-cheri/pull/161, should we just merge that instead?

yes please, let's get that merged and then this can be closed

Closing this PR because the changes were already merged via https://github.com/riscv/riscv-cheri/pull/161


Fix links

Couple more 404's

ah yea, this doc was renamed and cleaned up right as we were publishing the blog post yesterday, so clearly we missed some stuff in the excitement. Thanks for catching and fixing!


docs: correct node_modules path in v3 migration guide

This typo tripped me up when I copy pasted from the docs.

LGTM
Good catch!
Thanks 🙏


Fail to apply equality to side-condition

I have a side-condition that says something like { false #Equals PRED } #And { true #Equals (PRED impliesBool ELSE) }, and I would expect it to replace the second PRED with false and then continue simplifying, but it does not.
K version:
% kompile --version
K version:    v5.1.188-4-g6f2b343a8f
Build date:   Tue Sep 21 16:51:08 UTC 2021

Kore version:
98e241ede

Input K file:
module TEST
  imports INT
  imports MAP
  imports BOOL

  configuration <k> $PGM:Step </k>
                <mem> .Map </mem>
                <amount> 0 </amount>
                <value> 0 </value>
                <key> 0:KItem </key>

  syntax Step ::= "a" | "b" | "c" | "z"

  rule <k> a => b ... </k> <amount> A </amount> requires         A ==Int 0
  rule <k> a => z ... </k> <amount> A </amount> requires notBool A ==Int 0

  rule <k> b => c ... </k> <mem> AS </mem> <key> K </key> requires notBool K in_keys(AS)
  rule <k> b => z ... </k> <mem> AS </mem> <key> K </key> requires         K in_keys(AS)

  syntax Int ::= #lookup ( Map , K ) [function, functional, no-evaluators]
  rule I ==Int #lookup(M, K) => ( ((notBool #isPresent(M, K)) impliesBool I ==Int 0           )
                          andBool (         #isPresent(M, K)  impliesBool I ==Int {M[K]}:>Int )
                                )
    [simplification]

  syntax Bool ::= #isPresent ( Map , K )
  rule #isPresent(M, K) => K in_keys(M) andBool isInt(M[K]) [macro]

endmodule

module TEST-SPEC
  imports TEST

  claim <k> a => z ... </k>
        <mem> Allownces </mem>
        <amount> Amount </amount>
        <value> Value </value>
        <key> K  </key>
    requires Allownce ==Int #lookup(Allowances, K)
     andBool notBool ( Amount ==Int 0
               andBool (Allowance >Int 0 impliesBool Value ==Int 0)
                     )
endmodule

Call commands:
kompile --backend haskell test.k --main-module TEST
kprovex test.k --spec-module TEST-SPEC

And it gives counter-example:
  <generatedTop>
    <k>
      c ~> _DotVar1 ~> .
    </k>
    <mem>
      Allownces
    </mem>
    <amount>
      0
    </amount>
    <value>
      Value
    </value>
    <key>
      K
    </key>
  </generatedTop>
#And
  {
    false
  #Equals
    Allowance >Int 0 impliesBool Value ==Int 0
  }
#And
  {
    false
  #Equals
    K in_keys ( Allownces )
  }
#And
  {
    true
  #Equals
    ( K in_keys ( Allowances ) andBool isInt ( Allowances [ K ] ~> . ) ) impliesBool Allownce ==Int project:Int ( Allowances [ K ] ~> . )
  }
#And
  {
    true
  #Equals
    notBool ( K in_keys ( Allowances ) andBool isInt ( Allowances [ K ] ~> . ) ) impliesBool Allownce ==Int 0
  }

In particular, we see { false #Equals K in_keys(Allowances) }, and then several other side-conditions where substituting in false for that same predicate K in_keys(Allowances) would make it able to simplify further.
This is blocking Michelson K update.
Bug report attached.
test.tar.gz

I'm pretty sure this is the same issue as https://github.com/kframework/kore/issues/2785, which has a fix ready but we need to get a performance update in first.

Note that adding rules like rule A andBool _ => false requires notBool A [simplification] does not solve this.

This should be fixed on ed422630f9383b2774f1ec8ea04eee86ea0afe1e. Please let me know if you still encounter issues.


extract view-specific par in an intuitive way

gs <- gsplot() %>%
    points( y=c(3,1,2), x=1:3, xlim=c(0,NA),ylim=c(0,NA),
            col="blue", pch=18, legend.name="Points", xlab="Index",las=3)  %>%
    lines(2:3,c(5,9), side=c(3,4))
gs

creates this

when it shouldn't apply the las=3 arg to sides 2 and 3

Extract par formals from function calls, subtract out formals from that particular call (from graphics or gsplot) and then append that to the view-level par args list (which doesn't exist as of now). Figure out a way to deal w/ conflicts. On print, set par and reset par within view. Then, that should get it.


fix: implement unsubscribeFromCertificateUpdates

Issue #, if available:
Description of changes:
Implements proper certificate request tracking (including unsubscribe) and also removes CSR processing logic which is no longer needed.
Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Merged based on previous 2 approvals. Rebased without changes (except for addition of TODO comment)


Allow shorthands to be defined (and checked) with keyboard shortcut

Create a dialog that allows editing of the expanded word or text as well as the shortcut; and saving it either into a chord or a shortcut dictionary.
It could also act as an editor to change the existing shortcut -- but that's trickier, and might deserve a separate issue if I cannot get it done in the first pass.


Update Dockerfile to 2.9.0

updated dockerfile to use the newest version number

Superseded by https://github.com/Senzing/entity-search-web-app/pull/478


Revert "Fix #2395, do not directly use cfe_test_msgids.h"

Reverts nasa/cFE#2399

@jphickey - why is this being reverted?  This fixed an issue for us.

Turns out, this only works if you have cfe_testcase included in the application set.  If you don't build the testcase app, it breaks the build ..... see https://github.com/nasa/cFS/actions/runs/5579990936/jobs/10196292874


Custom Beam Search Decoder with sampling

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): no
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): ubuntu16.04
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 1.1.0
Python version: 3.4.3
Bazel version (if compiling from source):
CUDA/cuDNN version: 7.5
GPU model and memory:
Exact command to reproduce:

Describe the problem
I want to incorporating sampling into the  beam search decoder for seq2seq model. Is there any example or document on how to implement it?

This question is better asked on  StackOverflow since it is not a  bug or feature request. There is also a larger community that reads questions there. Thanks!

@yangshao hi i also want to implement this. any progress?


[WIP] refactor(router,config,core,admin,commons)!: architecture change

This PR (is huge obviously), changes Conduit's core architecture. The internal routing mechanism of the client router, is now extracted and made into a library that is used by the Client and Admin routers (with a pretty name "Hermes").
The Client router is made into a standalone service (than can actually be optionally deployed, don't know what the use case is for that , but it's possible) and the security package has been merged into it.
The Admin router now is a standalone router and not a "sub-router" of the client router, listening to a different port. The Core package which has been a "stitching" package, is merged with Config.
Now Conduit's Core is the Config along with the Admin router, meant to be used internally. The Client router can be scaled individually without impacting the Core, and the core will only handle configs, service discovery and general administration of the Conduit cluster.
Also in this PR, the Core will no longer need the Database in order to be spun-up. The primary storage mechanism will be Redis (probably to be replaced by Consul for configs), and the database will be used for persistence and long-term memory storage.
These changes will provide flexibility, allow us to start creating tests for the various Conduit components and create a "more proper" separation of concerns between the various internal systems.
What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update
[x] Refactor
[x] Build-related changes
[ ] Other (please describe)

Does this PR introduce a breaking change?

[x] Yes
[ ] No

The PR fulfills these requirements:

[ ] It's submitted to the main branch
[ ] When resolving a specific issue, it's referenced in the PR's description  (e.g. fix #xxx, where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature

Other information:

@kon14 @Michael-Vol we need to discuss some further polishing steps and how we can actually check this titan of a PR


scheduling, unscheduling, and unpublishing

Trello Tickets

schedule publish
unpublish
toolbar updates
publish updates

Cool New Stuff

added ability to unpublish
added ability to schedule publish
added ability to unschedule publish
scheduling changes publish button color in the toolbar
publish pane is created dynamically based on publish/schedule state
when loading the page, it will display scheduled or published status
when re-scheduling, publishing now, or unpublishing, it will unschedule (if the page is scheduled to publish already) (CQ not doing this was a pain point, according to editors)
scheduling form uses native date and time fields
added db.urlToUri helper method
added expectBooleanResult and db.getHead
added edit.unpublishPage to match edit.publishPage
added edit.schedulePublish and edit.unschedulePublish
added page-state service
:cool: state.formatTime uses moment.js's neat formatting rules
added schedule progress color
updated disabled button styles

Next Steps

add message in the publish pane giving a more detailed article state (e.g. "this was published on Friday at 10am")
update edit.unschedulePublish when amphora changes (so we don't have to search through all the scheduled entries)

Coverage decreased (-1.07%) to 86.657% when pulling bbae45e20b0813d145ff63074db892d4e737f58a on schedule-ui into 2917175bf9441e17262464222d108ea38917b611 on master.

Coverage decreased (-0.8%) to 86.907% when pulling 0141c52859349c8271dc510b18398c39a89a3808 on schedule-ui into 2917175bf9441e17262464222d108ea38917b611 on master.

Coverage decreased (-0.8%) to 86.907% when pulling 8238bd9cd62e7b54efd238eb254db845dad2839b on schedule-ui into 2917175bf9441e17262464222d108ea38917b611 on master.

Coverage decreased (-0.8%) to 86.939% when pulling 8238bd9cd62e7b54efd238eb254db845dad2839b on schedule-ui into 2917175bf9441e17262464222d108ea38917b611 on master.

Coverage decreased (-0.8%) to 86.939% when pulling 8238bd9cd62e7b54efd238eb254db845dad2839b on schedule-ui into 2917175bf9441e17262464222d108ea38917b611 on master.

Coverage decreased (-0.07%) to 87.66% when pulling f2467dffcd9f0ae71e2db5e3c67708576b7cd4d2 on schedule-ui into 2917175bf9441e17262464222d108ea38917b611 on master.

Coverage increased (+0.2%) to 87.922% when pulling 0c73e8d0c373980aee60ecb9632f08eba15cebde on schedule-ui into 2917175bf9441e17262464222d108ea38917b611 on master.

:+1: from morgan, christian


k8s.js and readme test

After pushing create pull request button it notified me "1-Review required 2-Merging is blocked"


Able to initialize Semaphore with groupId starting from non-zero value

Describe the improvement you're thinking about
Semaphore starts with groupId = 0. Being able to have groupId starts with 1 (or non-zero value) maybe more convenient in certain cases, so checking an object with groupId == 0 mean the object/entity doesn't belong to any valid group.
Currently there is no straightforward way to initialize the groupId to start from values other than 0.
Describe alternatives you've considered
We can always have another variable to indicate if an object/entity belongs to a valid group.

I tried to give this a shot this morning, did something as follows:
contract Semaphore is ISemaphore, SemaphoreGroups {
    ISemaphoreVerifier public verifier;

    /// @dev Gets a group id and returns the group parameters.
    mapping(uint256 => Group) public groups;

    /// @dev Counter to assign an incremental id to the groups.
    /// This counter is used to keep track of the number of groups created.
    uint256 public groupCounter;

    /// @dev With this variable allow groupId to start with non-zero, while keeping
    /// groupCounter to be the total number of groups.
    uint256 private groupIdOffset;

    /// @dev Initializes the Semaphore verifier used to verify the user's ZK proofs.
    /// @param _verifier: Semaphore verifier addresse.
    constructor(ISemaphoreVerifier _verifier) {
        constructor(_verifier, 0);
    }

    constructor(ISemaphoreVerifier _verifier, uint256 _groupIdOffset) {
        verifier = _verifier;
        groupIdOffset = _groupIdOffset;
    }

    function nextGroupId() internal returns (uint256 groupId) {
        groupId = groupIdOffset + groupCounter;
        groupCounter += 1;
    }

    /// @dev See {SemaphoreGroups-_createGroup}.
    function createGroup() external override returns (uint256 groupId) {
        groupId = nextGroupId();
        _createGroup(groupId, msg.sender);

        groups[groupId].merkleTreeDuration = 1 hours;
    }
  //...
}

And then realized Solidity doesn't support constructor overloading. I don't have a good way of adding the groupIdOffset parameter without changing the constructor interface. And that would be an API change, a major version bump.
If we want to solve this issue, I guess the best way is to pick this up in the next major release.


Make "Search" field always visible again

I'd like to suggest making the "Search" entry always visible, as it used to be on the old site, instead of requiring to click the hamburger in the top right corner to show it. My primary interaction with the site is via search and it's amazingly annoying to have to click one extra time to get to it now, especially when I still remember how much more convenient it used to be before. And there seems to be plenty of space for showing the search field near the hamburger button, which is not used for anything anyhow right now.
Thanks in advance for considering this!

FYI, if you widen the browser, it should appear and stay visible. The ask here I think is to update the responsiveness to prioritize keeping the search present even at lower widths.

Or maybe  not   :-)

Related, some positioning issue:

Oh, sorry, I should have thought about this. FWIW I am using one of my displays in portrait orientation, which is very convenient for reading documentation, and the window is maximized and, at 1200px wide, seems quite wide enough (inspecting the size of the inner div after moving the tab to a window on a landscape display I see that it's 1108px, so I'm really not sure why does it get hidden).
So this is less important than I thought, but still would be nice to improve.
BTW, I don't know if it's worth opening a separate issue for it, but it would also be great if there were a way to activate the search field from keyboard (if there already is one, I couldn't find it, after trying all those I could think of, such as /, Ctrl+F, F3, Ctrl-Space, etc).

BTW, I don't know if it's worth opening a separate issue for it, but it would also be great if there were a way to activate the search field from keyboard (if there already is one, I couldn't find it, after trying all those I could think of, such as /, Ctrl+F, F3, Ctrl-Space, etc).

Yes, please, and if you can link to any docs on "state of the art" here, I'd appreciate it. Last time this got raised on the old site, we had something ad hoc that no one liked; if there's a standard, everyone can get behind it.

Here is what I see on my iPad:

While it's ok to have all the menu items hidden under the button, the search is, perhaps, one of the most required features of the docs. A keyboard shortcut may not work for iPad. But, as one can see, there is plenty of space to have the search input in it.
About the same applies to iPhone too: there is definitely enough room to plug the field into.

@vadz please review new UI online review for this issue.
@vrurg the change to a hamburger style is set at 'tablet' by the Bulma framework.

looks like it's not visible at all on the new UI (unless you click the slider)

closing as original issue is now resolved by new UI. If new UI could be improved, better for these to be raised in new issue with specific new suggestions/descriptions


fix timezone info UnicodeDecodeError

ref https://github.com/cloudify-cosmo/cloudify-agent/issues/112:
In agent script_runner.tasks.run ,if an agent locale is not of ascii codeset (such as "Chinese (Simplified)_People's Republic of China", '936'), the timezone info is not utf-8 encoded.This will cause exception in logging (amqp_client.publish_message in cloudify/logs.py) , which will cause exception in local logging with json.dumps.
This method can fix it: when celery app starts, set default locale, and when getting timezone info in logging ,use the correct codeset from locale.
Here is the Traceback:
[2016-05-09 10:08:15,540: ERROR/MainProcess] Task script_runner.tasks.run[84982083-9ef8-4879-add3-da53d623330a] raised unexpected: UnicodeDecodeError('utf8', '2016-05-09 10:08:15.481\xd6\xd0\xb9\xfa\xb1\xea\xd7\xbc\xca\xb1\xbc\xe4', 23, 24, 'invalid continuation byte')
Traceback (most recent call last):
File "c:\users\sys\test_windows_host_2d6ed\env\lib\site-packages\celery\app\trace.py", line 240, in trace_task
R = retval = fun(args, kwargs)
File "c:\users\sys\test_windows_host_2d6ed\env\lib\site-packages\celery\app\trace.py", line 438, in protected_call
return self.run(args, *kwargs)
File "c:\users\sys\test_windows_host_2d6ed\env\lib\site-packages\cloudify\decorators.py", line 126, in wrapper
ctx.task_name, exc_info=True)
File "C:\Python27.11\Lib\logging__init_.py", line 1185, in error
self.log(ERROR, msg, args, *kwargs)
File "C:\Python27.11\Lib\logging__init.py", line 1278, in log
self.handle(record)
File "C:\Python27.11\Lib\logging__init_.py", line 1288, in handle
self.callHandlers(record)
File "C:\Python27.11\Lib\logging__init__.py", line 1328, in callHandlers
hdlr.handle(record)
File "C:\Python27.11\Lib\logging__init__.py", line 751, in handle
self.emit(record)
File "c:\users\sys\test_windows_host_2d6ed\env\lib\site-packages\cloudify\logs.py", line 119, in emit
self.out_func(log)
File "c:\users\sys\test_windows_host_2d6ed\env\lib\site-packages\cloudify\logs.py", line 342, in amqp_log_out
publish_message(log, 'log', logging.getLogger('cloudify_logs'))
File "c:\users\sys\test_windows_host_2d6ed\env\lib\site-packages\cloudify\logs.py", line 322, in wrapper
func(client, args, *kwargs)
File "c:\users\sys\test_windows_host_2d6ed\env\lib\site-packages\cloudify\logs.py", line 379, in publish_message
'message={1}, log={2}]'
File "C:\Python27.11\Lib\json__init.py", line 244, in dumps
return _default_encoder.encode(obj)
File "C:\Python27.11\Lib\json\encoder.py", line 207, in encode
chunks = self.iterencode(o, _one_shot=True)
File "C:\Python27.11\Lib\json\encoder.py", line 270, in iterencode
return _iterencode(o, 0)
UnicodeDecodeError: 'utf8' codec can't decode byte 0xd6 in position 23: invalid continuation byte

Closed: As this PR is more than six months old without having been merged. Please reopen (and rebase if necessary) if it is still relevant.


Can we re-use your code for our open-source community?

Hey @fregante, fantastic work!
I help manage an open-source community of over 1,300 active contributors with pretty large repos.
We'd love to give our community the ability to download only the subfolders they need, but we'd prefer to not overload your  site with extra traffic.
I saw that your code is MIT-licensed, but I wanted to ask for your permission to use your code in our community website -- while making sure to give you credit, of course.
If so, do you have any recommendations on how to get started?

overload your site with extra traffic

The site is a plain HTML page served by GitHub, hence the github.io domain. The downloads are straight from the GitHub’s API, so there's no bandwidth issue at all, it can be used directly, ;) I don't pay a dime.

Lol, I noticed. Great use of GitHub pages!
Thanks @fregante  for the quick response!
Our plan is to use a snapshot of your code, but add code to package additional assets in the .zip file to help our community members (e.g.: extra instructions, etc.).
I've already changed the code in my fork to add "Thanks" to the page because you definitely deserve kudos for the nice and succinct code. I looked at GitZip and DownGit, but I thought your code was cleaner.
Here's a screenshot of what it looks like:

So, you're ok with us sending people your way? As far as I'm concerned, everyone who uses GitHub should know about this repo 😋

Sure no problem. You can link to this repository rather than the website, because the website might not be clear (since it looks the same)
Glad you like it! I thought the same of those two websites, that's why I made this one. I hope to improve it a bit more in the future though.


Date Range Selection Cell Manipulation

Hi, finally I found a way to make it as a date range, but there still some gap between dates (white spaces) :

I would like to make it like :

This is the code to accomplish that (your code with some modification) :

So basically I add 2 UIView on the CellView, a half on the left side (leftSelectedView) and a half on the right side (rightSelectedView).
How to close that gap? Thanks.

Whats your cell inset?
calendarView.cellInset = ?

@patchthecode Thank you, it's worked now :)

Hey, your calendar looks sorta nice. If you dont mind, do you wanna place an image of it at this link ? -> https://github.com/patchthecode/JTAppleCalendar/issues/2
Pretty images helps others know the sort of cool stuff they can do with this library.
If you don't then its cool either way.

can you share your code please

Can you share it please?

i am also need this feature.can someone share this code please.

Hi, having the same issue as mrjimoy but there doesn't seem to be a property named cellInsets on calendarView. Not sure if you've renamed it in an update or?
Also thanks for the best iOS calendar out there, you've saved me a lot of time. + star'd 👍

Hi, having the same issue as mrjimoy but there doesn't seem to be a property named cellInsets on calendarView. Not sure if you've renamed it in an update or?
Also thanks for the best iOS calendar out there, you've saved me a lot of time. + star'd 👍

@Dzoni89 yes, every thing has been renamed to exactly match Apple's UICollectionView's function names and variables.  This makes it easier for developers to find the names they need without trying to remember the weird names i invent.
calendarView.minimumLineSpacing = ?
calendarView.minimumInteritemSpacing = ?

@patchthecode  thanks for the reply, I've actually tried setting minimumLineSpacing and minimumInterimSpacing to 0 prior to posting here. But now that I've given each cell a border I see that there is no cell spacing, my top and bottom border whose widths are set to equal cell.frame.size.width seem to have some weird spacing. Screwed up with the math somewhere probably, cheers. :/

@Dzoni89 if you are free, you can contact me here -> https://gitter.im/patchthecode/JTAppleCalendar
I am not understanding the problem correctly.

can you share your code please


Improve Process Output/Error processing

The way ProcessRunner was used, there was a race condition where the process could exit, WaitForExit would complete, and the process would be disposed of before all of the output was read.  There was a check in DotnetPathResolver for 0 lines, but I saw many cases where there was at least 1 line of output returned, but not all of them.
Switched from the event-based output/error processing to use ReadToEnd() on the Output and Error streams, encapsulated the Process more.  This code could be cleaned up further but I wanted to minimize change a bit.

This PR looks like it's got stuff from the other PRs mixed in? Any chance you could refactor it to just include the process output work? If not, no big deal - I can fix it up on my end.


Update platform/plugin versioning

Remove cordova plugin update (this command does not seem to exist)

Thanks @carynbear! I don't think we ever supported a plugin update command.

Why not implement it instead? I'd  bet cordova plugin rm XXX && cordova plugin add XXX is a very common thing, and a cordova plugin update XXX could be usefull.
I've had situations where I couldn't update a single plugin with that workaround because of dependencies, so an update command wouldn't be a shortcut only.

@fredgalvao, I agree that there would be benefits to implementing it. Feel free to open a feature request issue at issues.cordova.io.
Regardless, this PR is to fix the docs issue.


transfer from bitbucket

Before merging:

[ ] save/load kernels

[ ] I would remove dependency to jq and add options to provide lambdas and parameters as FW or connectoFlow COMMIT. This can be done later.

Can you name this flow noddi_flow please

Can you name this flow noddi_flow please

done

Also move kernels to the proper results directory please.


Project name and description dont save

When filling in the project information, it is not saved

Hi @danielmalencar.
Thanks for looking for me carefully.
I will fix it.

I fixed it now.
please try to test again.

Thanks!


change failure handling in PageDownstreamContext

In the next couple commits the context handling will be changed so that the
PageDownstreamContext will destroy itself if is is finished/failed. In order
for that to work finish/fail must not be called until all upstreams are done
sending requests.

ack


Android gradle plugin 3 alpha

Fixes breaking changes in the Variant API which were introduced in 3.0.0-beta3 of the Gradle plugin. Changes include:

Updated gradle dependencies/gradle wrapper to latest versions
Increase logging
Refactor 3 tasks into methods (setup autoConfig of proguard, adding build UUID to manifest, uploading mapping file to server)
Update build UUID/mapping file upload to execute in output.processManifest.doLast, as the manifest is no longer guaranteed to be created during the configuration phase.

The Android plugin for gradle is currently in beta, so we'd need to mark any release as beta, as it contains breaking changes for anyone still on 2.X.
Fixes #40

thanks for the review comments @artem-zinnatullin!

Pff, thank you for supporting AGP beta!


Unable to build plugin frameworks: ** BUILD FAILED **

flutter build  ios-framework --cocoapods --output=pods -v

Hi @LuckyRoc
Can you please provide your flutter doctor -v your complete flutter build ios-framework --cocoapods --output=pods -v and a complete reproducible minimal code sample from module and ios app, you can  add them in a zip and attachment in the comment
Thank you

Without additional information we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


libguestfs: 1.38.2 -> 1.38.3

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libguestfs/versions.
meta.description for libguestfs is: '"Tools for accessing and modifying virtual machine disk images"'.

Checks done (click to expand)

built on NixOS
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/guestfish passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/guestmount passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/guestunmount passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/libguestfs-test-tool passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-alignment-scan passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-builder passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-builder-repository passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-cat passed the binary check.
Warning: no invocation of /nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-copy-in-wrapped had a zero exit code or showed the expected version
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-copy-in passed the binary check.
Warning: no invocation of /nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-copy-out-wrapped had a zero exit code or showed the expected version
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-copy-out passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-customize passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-df passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-dib passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-diff passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-edit passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-filesystems passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-format passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-get-kernel passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-index-validate passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-inspector passed the binary check.
Warning: no invocation of /nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-list-filesystems-wrapped had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-list-filesystems had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-list-partitions-wrapped had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-list-partitions had a zero exit code or showed the expected version
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-log passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-ls passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-make-fs passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-rescue passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-resize passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-sparsify passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-sysprep passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-tail passed the binary check.
Warning: no invocation of /nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-tar-wrapped had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-tar had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-tar-in-wrapped had a zero exit code or showed the expected version
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-tar-in passed the binary check.
Warning: no invocation of /nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-tar-out-wrapped had a zero exit code or showed the expected version
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-tar-out passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-v2v passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-v2v-copy-to-local passed the binary check.
Warning: no invocation of /nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-win-reg-wrapped had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/virt-win-reg had a zero exit code or showed the expected version
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.guestfish-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.guestmount-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.guestunmount-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.libguestfs-test-tool-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-alignment-scan-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-builder-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-builder-repository-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-cat-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-customize-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-df-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-dib-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-diff-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-edit-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-filesystems-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-format-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-get-kernel-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-index-validate-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-inspector-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-log-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-ls-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-make-fs-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-rescue-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-resize-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-sparsify-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-sysprep-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-tail-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-v2v-wrapped passed the binary check.
/nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3/bin/.virt-v2v-copy-to-local-wrapped passed the binary check.
60 of 72 passed binary check by having a zero exit code.
24 of 72 passed binary check by having the new version present in output.
found 1.38.3 with grep in /nix/store/52vxkzllfh484zhkyzq5q4vpi9p8wvb7-libguestfs-1.38.3
directory tree listing: https://gist.github.com/05be2f03fd020c13ff95206bed968099
du listing: https://gist.github.com/fcff572663e93b431d233850aa644f54

Test this build with Cachix (click to expand)

One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout 47e0c751a998d1cf05448e039500d1a32d6a18bd && nix-shell --pure -I nixpkgs=. -p libguestfs

cc @offlinehacker for testing.

@GrahamcOfBorg build libguestfs

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: libguestfs
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: libguestfs
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: libguestfs
Partial log (click to expand)
gzipping man pages under /nix/store/1szvwnk9ibgjfa72vz9hnr5mxmg2a63s-libguestfs-1.38.3/share/man/
strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1szvwnk9ibgjfa72vz9hnr5mxmg2a63s-libguestfs-1.38.3/lib  /nix/store/1szvwnk9ibgjfa72vz9hnr5mxmg2a63s-libguestfs-1.38.3/bin
patching script interpreter paths in /nix/store/1szvwnk9ibgjfa72vz9hnr5mxmg2a63s-libguestfs-1.38.3
checking for references to /build in /nix/store/1szvwnk9ibgjfa72vz9hnr5mxmg2a63s-libguestfs-1.38.3...
running install tests
Formatting 'disk1.img', fmt=qcow2 size=10737418240 cluster_size=65536 lazy_refcounts=off refcount_bits=16
/dev/sda: unknown
/dev/sda1: ext2
/nix/store/1szvwnk9ibgjfa72vz9hnr5mxmg2a63s-libguestfs-1.38.3


Hide Button

This is a great library. 👍
But i need hide some button(ex: sticker,... ) non-use.
How i can do that?
Thank for reply! 😄

It will be in the future. Trust me!!

I hope it will come soon.
Thank you for the reply.

Is it there yet? @baronha

any update on this ?


Magisch: Watch yoyoworks.com

Magisch requests the watch of the watch_keyword yoyoworks\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

yoyoworks\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Fix key certificate tests

That's all to get the key_certificate tests working, should I also implement the renames and rewrites that PR #5 was intended to do?

Okey, I will add them then, and also add test to check the spk value

Okey, I will add them then, and also add test to check the spk value
@satk0
My apologies, I just gave a thumbs up because I appreciate the work you're doing. That's my bad on communication sorry haha.

We're actually in the midst of something that is colliding with the good work you're doing. The SPK value is actually something that is in conflict https://github.com/go-i2p/go-i2p/pull/23/commits/98d05e27c8c3cd1a4cde1b6899d131781b4f216b#diff-0ed98cca3160278053da430fead068f11c258a6599685bb6390737b35a4cda0e
We're still working on it, but as of now it's in a bit of a flux. You might want to hold off on it for now, I apologize.

Oooh allright, hah, thanks for all the good words 💪 I am just so excited about this project that I can't wait to do anything haha
I see, I will just leave all the refactoring to you, you are far more experienced.
I can add spk value checking in the test, that could help in refactoring it I think.
If you don't mind, I can make more PRs fixing or implementing tests, if that could help ;)

Let's go ahead and merge this soon, we can resolve the conflict before we merge the routerinfo branch

Let's not rename or rewrite more things just yet though, put that in another branch and make a new PR for it.

Thanks for merging @eyedeekay, I will add more PRs with tests fixes soon


🐛 [Bug] An error occurs in CompileGraph when gpu_id == 1

When I tried to Complie on the second GPU in a multi-GPU environment, an error occurred. The code sample used is as follows.
void load(const std::string& model_path, int64_t gpu_id, int64_t opt_batch_size) {
    torch::jit::Module module = torch::jit::load(model_path);
    torch::Device device = (torch::cuda::is_available() ? torch::Device(torch::kCUDA, gpu_id) : torch::Device(torch::kCPU));
    module.to(device, torch::kHalf);
    module.eval();

    std::vector<int64_t> in_opt = { opt_batch_size, INPUT_CHANNEL_NUM, BOARD_WIDTH, BOARD_WIDTH };

    trtorch::CompileSpec::InputRange range(in_opt);
    trtorch::CompileSpec info({ range });
    info.op_precision = torch::kHalf;
    info.device.gpu_id = gpu_id;
    module = trtorch::CompileGraph(module, info);
}

Error1
I called this function with gpu_id = 1. I got the following error:
terminate called after throwing an instance of 'trtorch::Error'
  what():  [enforce fail at core/conversion/conversionctx/ConversionCtx.cpp:107] Expected cudaSetDevice(settings.device.gpu_id) to be true but got false
Unable to set gpu id: 1

I think this line is the cause.
https://github.com/NVIDIA/TRTorch/blob/1d4b967a28e36beee048703f5645ee6fcc95793d/core/conversion/conversionctx/ConversionCtx.cpp#L112
cudaSetDevice returns cudaSuccess (= 0) on success. However, TRTORCH_CHECK judges success or failure as a Boolean type.
I fixed it as follows and rebuilt it so that this error disappeared.
diff --git a/core/conversion/conversionctx/ConversionCtx.cpp b/core/conversion/conversionctx/ConversionCtx.cpp
index ff23692..bc5bf68 100644
--- a/core/conversion/conversionctx/ConversionCtx.cpp
+++ b/core/conversion/conversionctx/ConversionCtx.cpp
@@ -109,7 +109,7 @@ ConversionCtx::ConversionCtx(BuilderSettings build_settings)
   cfg->setEngineCapability(settings.capability);

   if (settings.device.gpu_id) {
-    TRTORCH_CHECK(cudaSetDevice(settings.device.gpu_id), "Unable to set gpu id: " << settings.device.gpu_id);
+    TRTORCH_CHECK(cudaSetDevice(settings.device.gpu_id) == cudaSuccess, "Unable to set gpu id: " << settings.device.gpu_id);
   }

   if (settings.device.device_type == nvinfer1::DeviceType::kDLA) {

You may also use set_device.
https://github.com/NVIDIA/TRTorch/blob/1d4b967a28e36beee048703f5645ee6fcc95793d/core/compiler.cpp#L176-L178
Error2
After making the above fix, I get the following error:
ERROR: [TRTorch Conversion Context] - Builder was created on device different than current device.

I changed cudaSetDevice to do it at the beginning of the function and it worked fine.
diff --git a/core/conversion/conversionctx/ConversionCtx.cpp b/core/conversion/conversionctx/ConversionCtx.cpp
index ff23692..09a419c 100644
--- a/core/conversion/conversionctx/ConversionCtx.cpp
+++ b/core/conversion/conversionctx/ConversionCtx.cpp
@@ -47,6 +47,10 @@ ConversionCtx::ConversionCtx(BuilderSettings build_settings)
           util::logging::get_logger().get_reportable_severity(),
           util::logging::get_logger().get_is_colored_output_on()) {
   // TODO: Support FP16 and FP32 from JIT information
+  if (settings.device.gpu_id) {
+    TRTORCH_CHECK(cudaSetDevice(settings.device.gpu_id) == cudaSuccess, "Unable to set gpu id: " << settings.device.gpu_id);
+  }
+
   builder = nvinfer1::createInferBuilder(logger);
   net = builder->createNetworkV2(1U << static_cast<uint32_t>(nvinfer1::NetworkDefinitionCreationFlag::kEXPLICIT_BATCH));

@@ -108,10 +112,6 @@ ConversionCtx::ConversionCtx(BuilderSettings build_settings)
   cfg->setDefaultDeviceType(settings.device.device_type);
   cfg->setEngineCapability(settings.capability);

-  if (settings.device.gpu_id) {
-    TRTORCH_CHECK(cudaSetDevice(settings.device.gpu_id), "Unable to set gpu id: " << settings.device.gpu_id);
-  }
-
   if (settings.device.device_type == nvinfer1::DeviceType::kDLA) {
     auto nbDLACores = builder->getNbDLACores();
     TRTORCH_CHECK(

It's working, but I'm not sure if this is a good fix as there may be other side effects as well.
I would appreciate it if you could respond appropriately.

@andi4191 can you take a look?

@SakodaShintaro: Thanks for bringing this to our attention. I have created a PR with a unit test case.
https://github.com/NVIDIA/TRTorch/pull/361

Thank you very much!


Consolidate Hydrogen config options and explore partner integration story

This is a blanket ticket to cover work related to consolidating Hydrogen configs and exploring what it's like for third parties to integrate with Hydrogen.
We currently accept runtime options a number of ways:

renderHydrogen in a custom client entrypoint for enabling/disabling strict mode
renderHydrogen in App.server.jsx for routes and shopifyConfig
Logger options in App.server.jsx
Dev caching options and shopifyConfig again in hydrogen() Vite plugin

Additionally, these options all require changes to source code and can't be enabled with CLI flags, etc. Some of them might be useful as CLI flags, some not.
We need to explore consolidating these options, perhaps by introducing a hydrogen.config.js file, or moving them to a single location.
We should also take this opportunity to determine if and how this type of config consolidation plays into a larger partner integration story.

If I'm Sanity and I'm providing a few useful utilities, is there a dedicated place to inject public or private configs?
If I'm Partytown or Builder.io, how can I easily integrate with Hydrogen?
If I'm a third-party analytics adapter, how can I integrate with Hydrogen? #890

Related: #910

I like option 2, but also... I don't really think we need to have the separation between shopify.config.js and hydrogen.config.js. Every other metaframework consolidates their config into one spot, and I think it is unnecessarily confusing to have two configs (both for maintainers and for developers). Is there a good reason why we wouldn't combine them?

I like option 2, but also... I don't really think we need to have the separation between shopify.config.js and hydrogen.config.js. Every other metaframework consolidates their config into one spot, and I think it is unnecessarily confusing to have two configs (both for maintainers and for developers). Is there a good reason why we wouldn't combine them?

also like the hydrogen.config.js
I don't think we can merge shopify.config.js since it is needed for vite.config.js but maybe we can make it 2 named exports?
import {ShopifyConfig, HydrogenConfig} from 'hydrogen.config'

but that is a breaking change

Or nest objects, e.g.
// hydrogen.config.js
{
  storefrontApi: {
    token: ''
    domain: ''
    apiVersion: ''
  },
  logger: {}
  ...
}

i think its fine to have breaking changes at this point as long as we fail fast and with good error ( which should be straightforward here because we can detect the missing keys )

DX-wise I would prefer option 2. However, we might find some issues with that:

We've seen some use cases where the shopifyConfig passed to the app must change depending on the URL/request. This becomes harder to customize when we are the ones importing from the file instead of them.
import.meta for reading environment variables or routes wouldn't work if we merge hydrogen.config with shopify.config, because the latter must be imported in the plugin (outside of Vite). process.env can be used instead, but the .env files are still not read at this point.

As a possible solution, perhaps we can do option 2 by default but still allow overwriting it with option 1 -- i.e. if the developer passes options to renderHydrogen, we use that instead of reading from the file (or merge them à la Vite).
Also, we can do the same in the plugin so that developers don't pass shopifyConfig directly. Instead, we import it ourselves and make sure .env files and import.meta are available 🤔

Hello all,
With the plugin system, do you plan to allow the merging in the hydrogenConfig?
For example for hydrogenSanity, I would like to have a sanity node in in the hydrogenConfig to scope all data related to sanity like for the shopify.
Also, could we have a hook such as useHydrogenConfig that provide the complete hydrogenConfig because useShop provide only the shopify config

@b-barry Rather than providing sanity data at the top level, I think the following could work better with typings and other extensions:
import {defineConfig} from '@shopify/hydrogen/config';
import {sanity} from '...';

export default defineConfig({
  shopify: { ... },
  plugins: [sanity({ /* Sanity options and data */ })],
})

Also, could we have a hook such as useHydrogenConfig that provide the complete hydrogenConfig

Can you explain more about your use case? Is this only for getting Sanity data in this example, or something else?

could you elaborate how the config object will handled/merged with the plugins? I agree completely agree that for the typing it is better. We should use interface for making merging easier

This is still not decided but I don't think plugins would just be merged with the config property by property. However, they will have a way to provide data to the app, I'm fairly sure of that. In fact, we already have useRequestContext hook that can be used for this so the idea is that a plugin can provide context to that hook.
// Not actual API, just a quick draft
  name: 'my-plugin',
  middleware: ({request, context}) => {
    if (request.url.startsWith('/...') {
      context.data = 'my-data';
    }
  }
}

...

// In-app
useRequestContext('my-plugin').data // 'my-data'


CI: disable Symbiotic in fed-36 and higher

Symbiotic currently does not support LLVM-14

Thank you both!


Java underscores in literals

Since Java 7 we are allowed to have an underscore as a seperator in a numerical literal, see: http://docs.oracle.com/javase/7/docs/technotes/guides/language/underscores-literals.html
So this is completely valid but not yet supported by highlight.js. A first glance the code does not yet allow me to supply you with a patch. But I suppose at should not be too difficult.
long creditCardNumber = 1234_5678_1234_5678L;
long oneMilion = 1_000_000L;

The implementation of this is causing some problem when accessing members that begin with an underscore. For example, Contacts._ID:

as opposed to the correct highlighting:

I've created issue about this.


Customise httpc: IPv6-only and IPv4-only setups

👋
Is there a way to provide {ipfamily, inet6fb4} option to httpc to make it work in both IPv6-only and IPv4-only networks? I tried to do a quick search but it doesn't seem like user options are passed to HTTP downloader.

Hi @ruslandoga, not at the moment - a way of specifying additional httpc options would be a good addition. I'll leave this issue open as a reminder.
In the mean time, you can achieve what you're looking for through the locus_custom_fetcher behaviour.


Fix Search Page Slow Issue (CMD+K) - 2nd, 3rd solution

Details

src/pages/SearchPage.js

added conditional render using didScreenTransitionEnd

Fixed Issues

$ https://github.com/Expensify/Expensify.cash/issues/3601
Tests

While using e.cash use the cmd+k command
Type on the search field

QA Steps

While using e.cash use the cmd+k command
Type on the search field

Tested On

[ ] Web
[ ] Mobile Web
[x] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

https://user-images.githubusercontent.com/1319853/123469737-bb3c6a00-d5f3-11eb-8c55-bd98276cd43d.mp4
iOS

Android

I have read the CLA Document and I hereby sign the CLA.

@Looxor I added a Work In Progress label until we get a demo account that we can test this PR with and so we don't merge this PR until we've fully tested yet.

@nickmurray47 @Looxor I tested this with my account! Here's a summary of what I found.
I used the dev tools performance profiler to test the CMD +K shortcut followed by typing a name (I used tim since that has multiple results in my account). I didn't notice any regression of performance when using this branch as a build source. I didn't notice an increase in any performance either... but I think this is safe to merge.

Ok, I still think we should hold off on merging until we can definitely say that the PR does increase performance for the search page. @Looxor I also notice that this PR is pretty different from your original proposal of potentially cutting down on the number of renders. Can you include some details on why this change would improve performance?
I'm wondering for testing if we can include some kind of performance metric to quantify this. I will also work on getting you your own testing account. Thoughts?

@nickmurray47, Thank you for your attention.
Regarding multiple rendering, I think that it's better to decrease multiple rendering, but as you mentioned before, it makes some regression issues. At the moment, I realized that it is related to too many components, and I tried to find other ways.
Regarding didScreenTransitionEnd, I found a more effective way to display an ActivityIndicator.
It was more effective to use the conditional rendering than using "visible" variable because a former way does not require to render any blank component if not necessary.
Thank you,

@Looxor I also saw you posted in our open-source channel https://expensify.slack.com/archives/C01GTK53T8Q/p1625851107062100. Did you still need help mocking additional users?

@nickmurray47 ,
And I want to continue to integrate 1st solution of mine, but stopped due to the regression problem.
Can you please provide me a demo user (and password) so that I can check the regression problem as you mentioned?

@nickmurray47 , Yes, I still need them.

Ok, @isagoico do you have a production QA account (expensifail) with a ton of chats on it that you could lend to an external contributor?

@nickmurray47 Sure! You can try with<EMAIL_ADDRESS>/ 123456Hola and let me know if that one has enough chats, If it doesn't have enough I can try and find another one.

Thank you @isagoico!

@isagoico , Thank you so much. It works well.

Regarding 3rd solution,
I just pushed the 3rd solution.
Looking up a component FullScreenLoadingIndicator, I noticed that there is a difference between "adjusting with height:100%" and "adjusting with {top: 0, bottom: 0}".
But, I also agree on that "adjusting with {left: 0, right: 0, top: 0, bottom: 0}" is a better solution than "width/height: 100%".
ex: https://codepen.io/wizardzines/pen/abNXEVy
article: https://stackoverflow.com/questions/15972192/css-positioning-to-fill-container-width-vs-left-right
So, I left the original code and put some additional code for our CMD+K case.
And I believe that the solution is working fast than before.
@timszot , @nickmurray47 ,
Could you all please check this carefully?
Thank you.

Leaving my thoughts here. Looking at the changes here, I am uncertain of any performance gain here. Once again, I would request you to pull Marc in for review as he is mostly looking into performance-related issues.

Leaving my thoughts here. Looking at the changes, I am uncertain of any performance gain here. I would request you to pull Marc in for review as he is mostly looking into performance-related issues.

@parasharrajat
I made 2 screenshots for you to show the difference.
https://user-images.githubusercontent.com/1319853/125639667-4d551937-bd6f-48f9-a2a9-256c46273e9f.mp4
https://user-images.githubusercontent.com/1319853/125639683-e905431c-2088-431b-bd46-e9f979cdd38c.mp4

It seems it more of a UI issue rather then performance.

Hi @isagoico,
At this point, can you please check this solution?

It seems it more of a UI issue rather than a performance.
Edit:
So this suggests that the Absolute positioned element is slower than the flex equivalent, though all of this is handled by the CSS engine. Sorry, but it's hard to believe without any proof. But there is something really going on.
But if it makes a noticeable impact on affected users who first raised this issue then 👍

Hi @isagoico,
At this point, can you please check this solution?

It seems it more of a UI issue rather than a performance.
Edit:
So this suggests that the Absolute positioned element is slower than the flex equivalent, though all of this is handled by the CSS engine. Sorry, but it's hard to believe without any proof. But there is something really going on.
But if it makes a noticeable impact on affected users who first raised this issue then 👍

It seems it more of a UI issue rather than a performance.
Edit:
So this suggests that the Absolute positioned element is slower than the flex equivalent, though all of this is handled by the CSS engine. Sorry, but it's hard to believe without any proof. But there is something really going on.
But if it makes a noticeable impact on affected users who first raised this issue then 👍

@parasharrajat ,
Yes, that's right. The slaggy and slow transition of the search page, is due to UI issue than the performance-related issue.
So, I focused on UI issue than the performance issue.

Sorry, @Looxor I currently don't have the bandwidth to test it.

No problem. @parasharrajat , Thank you for your time.

@Looxor I did some more testing for you.
My performance tests were hitting CMD +K, once loaded type in test in the search field and wait for it to load the results.
Built from main:

Built from the proposed branch:

These proposed changes to cut down on performance costs. @marcaaron @nickmurray47 I would like your thoughts here as well.

I don't see a noticeable improvement when using CMD+K on my production account

FWIW, it might be valuable to test locally on a production build. There is a lot of difference between dev and production JS. More info here -> https://reactjs.org/docs/optimizing-performance.html#use-the-production-build

FWIW, it might be valuable to test locally on a production build.

Sorry if this wasn't clear, all these tests were done with builds from dev, pointed to production.

Interesting. That seems to suggest that we are experiencing some kind of local dev API lag, but this PR is not touching any APIs. Is the speed difference consistently reproducible?

Is the speed difference consistently reproducible?

The actual time that it take to load the search and then populate the changes when you type in a value did not change from what I can tell. The only gains I saw was the rendering and scripting speeds. It was consistently faster.

Sorry I'm not following why these changes would make anything go faster. Can someone summarize?

@timszot Thanks for the writeup and testing.
My understanding of why rendering would go faster is because instead of passing the didScreenTransitionEnd prop to the FullScreenLoadingIndicator component we only conditionally render it if true which means we no longer render a blank FullScreenLoadingIndicator.

which means we no longer render a blank FullScreenLoadingIndicator

What impact does this have on performance? This is the original proposal accepted...
https://github.com/Expensify/Expensify.cash/issues/3601#issuecomment-867409116
How did we end up with this PR ?

How did we end up with this PR?

I asked the same thing above. The original PR @Looxor submitted to address rendering caused several regressions and we ended up reverting it.

@Looxor We are going to close this PR given the minimal performance improvement and how far off we got from the original proposal accepted.


Replace favicon

Related to #428

Thanks :octocat:
Your changes did it to the master branch and the change should be deployed in a matter of minutes.


postgresql adapter not working

Note: for support questions, please join our Discord server

I'm submitting a ...
[X] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Action taken (what you did)
adjusted the line in UIconfig.js
adapter: 'postgresql'

adjusted sample-config.js :+1:
// Postgres adapter example config (please note: requires postgres >= 9.5):
config.postgresql = {
path: 'plugins/postgresql',
version: 0.1,
connectionString: 'postgres://myuser:mypasword@localhost:5432', // if default port
database: gekko_db, // if set, we'll put all tables into a single database.
schema: 'public',
dependencies: [{
module: 'pg',
version: '6.1.0'
}]
}
I can login to this database with this user

Expected result (what you hoped would happen)

I would hope I could load local data in the postgresql database

Actual result (unexpected outcome)

looks like it tries to login with a "user" setting somewhere in an other config?
I have seen the other issues about the difficulties finding the right configs to use, i agree...
I noted issue/956
I also tried renaming sample-config.js to config.js but no luck.
seems gekko does not read the sample-config.js?
gekko stopped working:
hugo@pcloud:~/git/gekko$ node gekko --ui
______   ________  __    __  __    __   ______

/      \ /        |/  |  /  |/  |  /  | /
/$$$$$$  |$$$$$$$$/ $$ | /$$/ $$ | /$$/ /$$$$$$  |
$$ | $$/ $$ |_    $$ |/$$/  $$ |/$$/  $$ |  $$ |
$$ |/    |$$    |   $$  $$<   $$  $$<   $$ |  $$ |
$$ |$$$$ |$$$$$/    $$$$$  \  $$$$$  \  $$ |  $$ |
$$ _$$ |$$ |_____ $$ |$$  \ $$ |$$  \ $$ _$$ |
$$    $$/ $$       |$$ | $$  |$$ | $$  |$$    $$/
$$$$$$/  $$$$$$$$/ $$/   $$/ $$/   $$/  $$$$$$/
Gekko v0.5.10
I'm gonna make you rich, Bud Fox.

TAlib is disabled
TULIP indicators is enabled
Serving Gekko UI on http://<IP_ADDRESS>:3000/
<-- GET /api/imports
--> GET /api/imports 200 2ms 2b
<-- GET /api/gekkos
--> GET /api/gekkos 200 0ms 2b
<-- GET /api/gekkos
--> GET /api/gekkos 200 0ms 2b
<-- GET /api/apiKeys
--> GET /api/apiKeys 200 0ms 2b
<-- GET /api/exchanges
--> GET /api/exchanges 200 999ms 60.95kb
<-- POST /api/scansets
Gekko encountered an error and can't continue
Error:
{ error: role "user" does not exist
at Connection.parseE (/home/hugo/git/gekko/node_modules/pg/lib/connection.js:546:11)
at Connection.parseMessage (/home/hugo/git/gekko/node_modules/pg/lib/connection.js:371:19)
at Socket. (/home/hugo/git/gekko/node_modules/pg/lib/connection.js:114:22)
at emitOne (events.js:116:13)
at Socket.emit (events.js:211:7)
at addChunk (_stream_readable.js:263:12)
at readableAddChunk (_stream_readable.js:250:11)
at Socket.Readable.push (_stream_readable.js:208:10)
at TCP.onread (net.js:594:20)
name: 'error',
length: 96,
severity: 'FATAL',
code: '28000',
detail: undefined,
hint: undefined,
position: undefined,
internalPosition: undefined,
internalQuery: undefined,
where: undefined,
schema: undefined,
table: undefined,
column: undefined,
dataType: undefined,
constraint: undefined,
file: 'miscinit.c',
line: '502',
routine: 'InitializeSessionUserId' } '\n\n'
Meta debug info:
Gekko version: v0.5.10
Nodejs version: v8.9.1

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)

I found the answer on https://discordapp.com/channels/342488930983215115/342488930983215115?jump=374609859674374155
for anyone else wondering i found the answer to my question... to use pgsql with the UI or API web/routes/baseConfig.js and put credentials then in UIconfig.js change sqlite to postgresql
edit web/routes/baseConfig.js

wow, this is an issue and it should not be closed. Gekko has a huge issue with its config files. It has to be fixed. Please reopen this

@AidasK
install pg:
npm install<EMAIL_ADDRESS>

@Kirbylix pg was already installed hence its not related

@AidasK the specific error in this issue:

{ error: role "user" does not exist

Is a postgresql error, Gekko can't do much about postgresql auth.

I do agree we need better documentation on how to run postgresql and other databases with Gekko..

I don't think gekko needs better documentation, it needs to solve how config files are used.
The issue is that nobody expects to set database login params in file web/routes/baseConfig.js which is located in web/routes... I thought this folder should be used for frontend and for vue routes, definitely not for backend configs....
And what about web/vue/UIcoinfig.js,  you have to set DB adapter there adapter: 'sqlite'. It is just wrong.
Why can't all configs be loaded from single config.js?

@AidasK The main problem came from the fact that before the UI the only thing you could do was start one gekko with one config file.
Everything was housed in this config file, including things like strategy params and market settings. Under the hood Gekko still works like this: all settings about what a gekko is supposed to do are pulled out of a config, even if a physical one on disk doesn't exist.
The idea of the UI is that you don't have to configure this in config files anymore, whenever you click on something in the UI a config file is dynamically generated and passed under the hood to the underlying gekko instance.
With the UI a single config file does not make sense since you'll use the create different gekkos that do different things (else what is the point?).
Best would be to move everything which doesn't make sense to the config screen in the UI imo.
Read more background story here: #956.

You are more than welcome to propose a better config system, the last time someone did (see #956 it was a just bashing against how bad things are with the promise to make a better PR, this was almost 6 months ago).

Maybe sqlite is too slow or computer problem
i think update version need to change postalsql or moongodb


Rewrite action in JS

To use the native approach of GitHub Actions, which also gives us an authenticated Octokit client and fits better in the ecosystem in general.

:(


Angle weight

Slightly cleaner.

Great I gotta admit that radians to degrees conversion was harsh.
We need to find a better implementation because right now the bot will go toward the farthest enemy, but still right toward it.
Maybe we should compute some other angles not based on the danger radius on the cells  ?

Think of different scenarios, then look for a way out. The way that my current code works is by looking for open spaces. It does that by removing all the angles that point towards an enemy. What you are left with is a range of angles where if you go towards it, you won't run into anyone. This stops working when there are enemies that completely surround you leaving no good angles left.
The code you are currently writing is supposed to pick up where my code falls off.
A simple idea would be to remove the furthest enemies one by one until you end up with at least one good angle.

You gave me idea.
Instead of stacking the angles one by one like true or false (go / not-go), we could separate the areas in angles all having a risk/reward ratio and select the best. See what I mean  ? This would a big portion of the code but it would reproduce human behiavior much more accurately.

I think this can work. There are many ways in which something like that could get applied though.
The first step would be to rework the current cluster algorithm to be angle based instead or area based. Then do the same for enemies.

Looking at these clusters, an angle based pathfinding would be the best approach. But sooo ressource demanding


Remove items not released from Release notes v1.4

These items had been planned for 5th release, but were not DOI'd and not released.
More discussion and data format is being discussed before they are released in probably the 6th (v1.5) release.
Please remove from HRA portal page: https://humanatlas.io/release-notes/v1.4
2 Physiological organ system tables: Male and female
3 Azimuth crosswalks: Kidney, lung, heart
24 Atlas-to-Atlas projections to/from 500 donor kidney, Allen brain, SPARC heart, SPARC colon, 1D Helmsley colon

Thank you @emquardokus & @bhushankhope!

thank you both as well! @bhushankhope! @ libby-maier


Segmentation fault when run code with cuda in hypre

when I run the ex1p with mpirun -np 4 ex1p -pa -d cuda, I got the Segmentation fault.(on WSL2 ubuntu 22.04      cuda 12.3)
here are some gdb information:

(gdb) attach 680408
Attaching to process 680408
(gdb) b ex1p.cpp:206
Breakpoint 1 at 0x55dd5f77dd42: file ex1p.cpp, line 206.
(gdb) c
Continuing.
Thread 1 "ex1p" hit Breakpoint 1, main (argc=4, argv=0x7ffc76bd0ed8) at ex1p.cpp:206
206              sleep(5);
(gdb) set var k = 0
(gdb) c
Continuing.
Thread 1 "ex1p" received signal SIGSEGV, Segmentation fault.
0x000055dd602a677b in hypre_CSRMatrixTransposeHost ()
(gdb) bt
#0  0x000055dd602a677b in hypre_CSRMatrixTransposeHost ()
#1  0x000055dd602a67d3 in hypre_CSRMatrixTranspose ()
#2  0x000055dd6028a615 in hypre_ParCSRMatrixTransposeHost ()
#3  0x000055dd6028ae9d in hypre_ParCSRMatrixTranspose ()
#4  0x000055dd5f7fde50 in mfem::HypreParMatrix::Transpose (this=0x55dd642db6e0) at linalg/hypre.cpp:1706
#5  0x000055dd5fb839f4 in mfem::ParFiniteElementSpace::GetEssentialTrueDofs (this=0x7ffc76bcd6d0, bdr_attr_is_ess=...,
ess_tdof_list=..., component=-1) at fem/pfespace.cpp:1052
#6  0x000055dd5f77dd70 in main (argc=4, argv=0x7ffc76bd0ed8) at ex1p.cpp:208

and i build the hypre with
./configure --with-cuda --with-gpu-arch="86" --disable-fortran CUDA_HOME=/usr/local/cuda --enable-unified-memory
and if there is no "--enable-unified-memory", command "mpirun -np 4 ex1p -m ../data/square-disc.mesh" will get the same errors. if I add the  "--enable-unified-memory", command "mpirun -np 4 ex1p -m ../data/square-disc.mesh" will work but "mpirun -np 4 ex1p -pa -d cuda" will get the error.

I update the hypre to 2.31,but I get the error:
Device configuration: cuda,cpu
Memory configuration: host-std,cuda
Number of finite element unknowns: 82561
CUDA ERROR (code = 101, invalid device ordinal) at memory.c:191
CUDA ERROR (code = 101, invalid device ordinal) at memory.c:191
CUDA ERROR (code = 101, invalid device ordinal) at memory.c:191
CUDA ERROR (code = 101, invalid device ordinal) at memory.c:191
CUDA ERROR (code = 101, invalid device ordinal) at memory.c:191
CUDA ERROR (code = 101, invalid device ordinal) at memory.c:191
CUDA ERROR (code = 101, invalid device ordinal) at memory.c:191
CUDA error: (cudaGetLastError()) failed with error:
--> invalid device ordinal
... in function: void mfem::CuWrap1D(int, DBODY&&) [with int BLCK = 256; DBODY = __nv_hdl_wrapper_t<false, false, false, __nv_dl_tag<mfem::Vector& (mfem::Vector::)(double), &mfem::Vector::operator=, 1>, void(int), double, double>&]
... in file: linalg/../general/forall.hpp:514
MPI_ABORT was invoked on rank 0 in communicator MPI_COMM_WORLD
with errorcode 1.

You may or may not see output from other processes, depending on
exactly when Open MPI kills them.


Update storage-classes.md

I'm including a new solution to be referenced on Storage Class page
It's called Veritas InfoScale for Kubernetes / Alta Enterprise Resiliency for Kubernetes is a Software defined solution deployed over containers to provide High performance and DR for persistent storage

Veritas InfoScale is not part of Kubernetes and this content does not align with our policy on 3rd party content.
/close


TorchController not working

What is going on?
Mainpath lighting won't work after switching levels.
What should happen?
The mainpath lighting should work every time.
Steps to reproduce

Go ingame
Go into a level
Get to the next level (how is irrelevant)
Toggle the mainpath lighting
Observe the torches not lighting up

Fix
Closes in #48

Broken again


Fix typings test on Windows

tsc needs to be invoked as tsc.cmd on Windows. Otherwise, there are failures as noted in https://github.com/xtermjs/xterm-addon-ligatures/pull/7#issuecomment-411941931.
Also noticed the integration tests were slipping into the coverage so pulled that out too.

Good to know CI is working 😄 I turned it on for PRs and required it to pass for merging.


Oracle Database XE 18.4.0 on M1

I run this command:
docker run --name myxedb -d -p 1521:1521 -e ORACLE_PWD=system -e ORACLE_CHARACTERSET=AL32UTF8 oracle/database:18.4.0-xe
Then I check on Docker that gives me this result:

Specify a password to be used for database accounts. Oracle recommends that the password entered should be at least 8 characters in length, contain at least 1 uppercase character, 1 lower case character and 1 digit [0-9]. Note that the same password will be used for SYS, SYSTEM and PDBADMIN accounts:

Confirm the password:

Configuring Oracle Listener.

Listener configuration succeeded.

Configuring Oracle Database XE.

#

# A fatal error has been detected by the Java Runtime Environment:

#

#  Internal Error (safepoint.cpp:310), pid=195, tid=0x000000403d91a700

#  guarantee(PageArmed == 0) failed: invariant

#

# JRE version: Java(TM) SE Runtime Environment (8.0_171-b11) (build 1.8.0_171-b11)

# Java VM: Java HotSpot(TM) 64-Bit Server VM (25.171-b11 mixed mode linux-amd64 compressed oops)

# Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again

#

# An error report file with more information is saved as:

# /tmp/hs_err_pid195.log

#

# If you would like to submit a bug report, please visit:

#   http://bugreport.java.com/bugreport/crash.jsp

#

qemu: uncaught target signal 6 (Aborted) - core dumped

/bin/bash: line 1:   193 Done                    ( echo 'system'; echo 'system'; echo 'system' )

       195 Aborted                 | /opt/oracle/product/18c/dbhomeXE/bin/dbca -silent -createDatabase -gdbName XE -templateName XE_Database.dbc -characterSet AL32UTF8 -createAsContainerDatabase true -numberOfPDBs 1 -pdbName XEPDB1 -sid XE -emConfiguration DBEXPRESS -emExpressPort 5500 -J-Doracle.assistants.dbca.validate.DBCredentials=false -sampleSchema true -customScripts /opt/oracle/product/18c/dbhomeXE/assistants/dbca/postdb_creation.sql -initParams sga_target=596M,pga_aggregate_target=198M

Database configuration failed. Check logs under '/opt/oracle/cfgtoollogs/dbca'.

/usr/bin/mv: cannot stat '/opt/oracle/product/18c/dbhomeXE/dbs/spfileXE.ora': No such file or directory

/usr/bin/mv: cannot stat '/opt/oracle/product/18c/dbhomeXE/dbs/orapwXE': No such file or directory

ORACLE_HOME = [/home/oracle] ? ORACLE_BASE environment variable is not being set since this

information is not available for the current user ID .

You can set ORACLE_BASE manually if it is required.

Resetting ORACLE_BASE to its previous value or ORACLE_HOME

The Oracle base remains unchanged with value /opt/oracle

#####################################

########### E R R O R ###############

DATABASE SETUP WAS NOT SUCCESSFUL!

Please check output for further info!

########### E R R O R ###############

#####################################

The following output is now a tail of the alert.log:

/usr/bin/tail: cannot open '/opt/oracle/diag/rdbms/*/*/trace/alert*.log' for reading: No such file or directory

/usr/bin/tail: no files remaining```

I've got the same problem on my MacBook Pro M1. I need this database for work so it would be amazing and it would really make my life easier.

Please paste the output of docker info

The same problem occurs but with version <IP_ADDRESS>
Running the command:
docker run --name oratest -d -p 1521:1521 -e ORACLE_PWD=system -e ORACLE_CHARACTERSET=AL32UTF8 --shm-size=1G oracle/database:<IP_ADDRESS>-xe fails, here you can see error log for this execution docker_oracle_error.log
And my docker info is docker_info.txt
The image was compiled using this command ./buildContainerImage.sh -v <IP_ADDRESS> -x -o “--platform=linux/amd64” becasue if you use ./buildContainerImage.sh -v <IP_ADDRESS> -x the image compilation fails build_image_fails.log

i solve that executing in terminal
ulimit -c unlimited

@jaiodoo Have you really been able to run an Oracle Database in a Docker container on Apple Silicon by just using the “--platform=linux/amd64” flag? That would be great! If so, could you elaborate on the exact environment and setup and how is the performance?

I happened to resolve this (or very similar issue) by accident - the docker container got restarted after a failed DB setup until the setup was eventually successful.
To be precise:

I installed docker inside Lima with arch: "x86_64" (the slow mode - better for compatibility)
Enter Lima VM: (lima)
Inside Lima run: ./buildContainerImage.sh  -v 18.4.0 -x

no --platform flag necessary as I am on x86_64 already
this took a really long time (about 6 hours !!!) - now you know why it's called slow mode

docker run --name myxedb -d -p 1521:1521 -e ORACLE_PWD=system -e ORACLE_CHARACTERSET=AL32UTF8 oracle/database:18.4.0-xe
Oracle Database configuration failed and docker got restarted ... until, finally, it succeeded!

Oracle DB doesn't feel slow in my normal day-to-day use (no heavy use).

@Peipi98 Oracle database docker images are not compatible on ARM platform (Apple M1) currently. Many guys are successful in running the docker images on Lima. Please use the method mentioned above to run the image.
Additionally, we are working on the compatibility of Oracle Database with ARM platform and the release expectation is later this year. So, closing this issue for now. Please feel free to reopen in case you have any further queries.

@abhisbyk can you give me an idea how I can run Oracle Db 19c Docker image on Mac M1 using Lima.

Hey everyone, I am going to try running Oracle Database XE 18.4.0 on a new M1 PowerBook Pro, as mentioned in this thread using one of these SO answers
There is also another thread discussing this topic here:
https://github.com/oracle/docker-images/discussions/1951
Fingers crossed at some point will see support for M1-based Macs in the future!!

@OliHarris Do you have any updates about the issue? I have tried the solution with Colima described in this article on my M1 Max and got nothing in result.