Sorting in torrent list does not work

Expected Behavior

Would be nice to see new torrents on top of the list. Sorting could provide this functionality.
Current Behavior

Сортировка в списке торентов не работает.
Т.е. они выстроены по времени добавления, но сделать обратную сортировку не получается.
Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

Version used: 0.1.20

Environment name and version: spmc 17

Operating System and version: android tv 8

Link to Kodi debug log:

https://paste.ubuntu.com/p/2nsnx8FhHf/

Стандартный скин не даёт никакого выбора сортировки, как и в меню обычных (не там где фильмы).
Я добавил дату в торренты, но так же сортировки у меня не появилось.

У меня нестандартный скин. Очень жаль что так выходит.

Сортировка что-то сломалась совсем
Последние торренты стали в середине. (Может связано с жестким выходом из коди.)
https://paste.ubuntu.com/p/kN9SR6FRJH/

In 0.1.26 I removed dates from torrents to keep strict sorting.
The only option I see is to make strict sorting from context menu on torrents.

In general it somehow sorted, but there are many let's say misplaced items. Changing direction of sorting  (still) does not work.
https://paste.ubuntu.com/p/xfKQtgZTt8/

Sorting torrents by means of skin should not work, because torrents list is not a list of movies/episodes, and your skin cannot properly treat it.
When I added date to each item - if was not able even use default sorting and was breaking it.

Sorting torrents by means of skin should not work, because torrents list is not a list of movies/episodes, and your skin cannot properly treat it.

Ok, i see.

In general it somehow sorted, but there are many let's say misplaced items.

For example if you close elementum while it downloads a torrent (that is in the botton of the list at that exact moment - correct sirring) and start elementum again, then this torrent could appear somewhere in the middle of list.

@antonsoroko you can open http://<IP_ADDRESS>:65220/torrents/ and see real order of torrents.
If it differs from what you see in Kodi - then it's your skin.

Checked - order is the same as in kodi.
But this list changes fron time to time. Looks like after restart elementum do some kind of checking of torrents and thus some torrents become "fresher" than they were.

@antonsoroko on load, torrents are sorted by modification date. You can open directory with torrent files and sort by modification time, to see the order there.
I have tried many times, it always sorts by modtime, which is changed only on torrent creation.

I will try.
But if I am not mistaken modification time is also changed when you change attributes of file (and file content), not only on creation - there is a different attribute for that - creation time.
Also I use NTFS (because of Android restrictions), not sure, but it also might add something to the picture.

But if I am not mistaken modification time is also changed when you change attributes of file

Elementum is not touching torrent files after they are created.

I tried standard skin and even English locale and regional settings for date - same result.
Ordering in elementum does not match ordering in File Manager (i mean real files). And after every restart it slightly changes in elementum, but not in FM.
Is ordering is based on *.torrent file or on "real" file/folder? (i have photos to proof what i said above, but for real files and not for *.torrent files - i can make photos of these as well)
And as I can see after restart elementum starts to recheck some torrents and exactly these torrents become out of order.

*. torrent files are definitely changed on every elementum start. But i don't see correlation with sorting in torrents list in elementum/kodi.
@elgatito
Could you please clarify for me what info elementum uses for sorting?
Thanks.

For history:

Could you please clarify for me what info elementum uses for sorting?

https://github.com/elgatito/elementum/blob/v0.1.29/bittorrent/service.go#L944
Elementum is using only *.torrent files, stored in "Torrents" directory inside of downloads directory.
Maybe your system changes modification time on any access to them. We can try with using creation date.

Elementum is using only *.torrent files, stored in "Torrents" directory inside of downloads directory.

I guess you meant "torrent directory" in settings (which is inside of kodi's temp directory be default).
Anyway, as i said above

*. torrent files are definitely changed on every elementum start. But i don't see correlation with sorting in torrents list in elementum/kodi.

So this is kind of strange. Maybe something related to Android or NTFS.
About

We can try with using creation date.

I guess this could be more "native" - sorting by torrent adding date.
Thank you in advance!

Looks I have found the problem.
Each time torrent metadata is resolved by libtorrent, *.torrent file was re-written to the disk, so modification time was changed on every Elementum restart.
I will fix this, but modification time will still be used, because not all filesystems store creation time, so Golang does not have api for getting it.
So new torrents will be in the end of the list, while old ones will stay 'as is'.

Great, thank you !

Golang does not have api for getting it.

Yeah, i also noticed that.

Please, try v0.1.30.
Modification date should not change after you start elementum (kodi).

Seems to be good now.
Thank you very much!


Add attribute escaping to getChallenge method

@romanzipp thanks for this amazing package.
for this issue, i might be able to help, but can you describe a bit about this issue?

I just had the idea to escape all string attributes passed to the getChallenge method. Now that I again think about it, this feature won't be necessary since there should not be any unescaped user data passed to the method.


Merge master into beta

Description
Merge master changes into beta branch
Breaking Changes
NA
JIRA Link
NA
Checklist

[x] Updated the Readme.md (if required) ?

:tada: This PR is included in version 18.0.0-beta.3 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 18.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


pull request for e2e test at 11/12/2016 18:26:09

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


timeLimit immediately throws exception on Windows

Version
110.99.5 (Latest)
Operating System

[ ] Any
[ ] Linux
[ ] macOS
[X] Windows
[ ] Other Unix

OS Version
Windows 11
Processor

[ ] Any
[ ] Arm (using Rosetta)
[ ] PowerPC
[ ] Sparc
[x] x86 (32-bit)
[ ] x86-64 (64-bit)
[ ] Other

System Component
SML/NJ Library
Severity
Minor
Description
In the Repl when running TimeLimit.timeLimit (Time.fromSeconds 60) calculation () the TimeOut exception is thrown immediately. But by running the code once more, it behaves as expected. This appears to only occur on Windows, if running on Linux I can't reproduce the error.
Transcript
No response
Expected Behavior
The exception should not be thrown if calculations complete withing the time limit.
Steps to Reproduce
Run a functon wrapped in the timeLimit function in the Repl on Windows.
TimeLimit.timeLimit (Time.fromSeconds 60) calculation ()
Additional Information
No response
Email address
m at rtin dot nu

I checked macOS and it also appears free of the error, so I suspect that it is Windows specific.

I can confirm that this bug exists on Windows. Are signals even implemented on Windows? (looking at win32-signal.c makes it seem like it isn't)

I believe that there is support for SIGALRM (see win32=timers.c) that is implemented using a separate thread.

Fixed for 110.99.6


Add option to report general issues

When opening new issues you're currently restricted to selecting one of

🐛 Report Bad Task
🐛 Report Bad Test Inputs
🤗 Model Evaluation Request

Some issues are more general in nature, and do not fall in under either of these categories. Add a new option to facilitate reporting of general issues.

Feel free to assign me to this. I'm reporting it so I remember it for later.

Ah! There's an option to add a blank issue at the bottom

Sorry for the noise.


Crash in Sketch v39

Plugin crashes In Sketch v39 Beta
Steps:

Create a new document
Insert an Artboard
Select Plugins › Show States
Right click the States window and select 'Create Page'. Sketch v39 crashes.

FTR, this only happens when using the contextual menu, clicking the '+' icon seems to work fine.

Hello @bomberstudios! Your very detailed report is really appreciated ❤
Please, try this (attached) new version and let us now if it works for you on 3.9beta
Thanks!
▶ States-beta-fix.0.99.sketchplugin.zip

Works like a charm here : )


Navigation with Turbolinks needs work

Currently, navigation with Turbolinks causes two responses HTMLs to fire and clobbers any flashes set by the browser.
Lines in questions:
Picture of the issues:

Navigation has been reworked. This should be working.


Compilation error in a container

I am trying to build incubator-heron master in a container with Ubuntu, I managed to install everything but bazel when building the heron folder gives me an error, probably related to Python.
Can someone help me? I have attached all the output from the build comand, specifically bazel build --config=ubuntu heron/...
output.log

@comes5 - can you include what error you are getting?

Alternatively you could use the docker - streamlio/build-ubuntu14.0:latest - it has everything installed already.

The error I am mentioning is in the log file I posted:
ERROR: /incubator-heron/heron/tools/admin/src/python/BUILD:22:1: PexPython heron/tools/admin/src/python/heron-admin.pex failed (Exit 1) **** Failed to install netifaces-0.10.6 (caused by: NonZeroExit("received exit code 1 during execution of ['/usr/bin/python2.7', '-', 'bdist_wheel', '--dist-dir=/tmp/tmpwn7Syj']while trying to execute['/usr/bin/python2.7', '-', 'bdist_wheel', '--dist-dir=/tmp/tmpwn7Syj']",) ):
The problem is that I want to use Dhalion to implement new policies for Heron so I need to modify the source code and doing some tests with it.

Can you clarify if you are using the Docker containers defined in the Heron repo (docker/compile) or you are constructing your own?

Just constructing it on my own using the ubuntu default container.
Here is my dockerfile:
Dockerfile.txt

I would recommend using the dockerfiles in the docker/compile directory they are used routinely for compilation so should work. Can you give the instructions in the docker/compose/ReadMe.md a try?

Ok tried to compile using the instructions in /docker/Readme.md but there seem to be another error:
INFO: Starting clean (this may take a while). Consider using --async if the clean takes more than several minutes. Creating packages INFO: Analysed target //scripts/packages:tarpkgs (240 packages loaded). INFO: Found 1 target...  Once this is merged, this error will go away.

So, I am trying with virtualbox now, following the heron documentation with ubuntu 16.04. So far no errors from thrift and scribe, but the build fails after a long time building:
ERROR: Process exited with status 1: Process exited with status 1 fatal: Not a git repository (or any of the parent directories): .git Failed to run command to check head: git rev-parse --abbrev-ref HEAD INFO: Elapsed time: 1525.185s, Critical Path: 69.10s INFO: 1914 processes: 1603 local, 311 worker. FAILED: Build did NOT complete successfully

Have you checked out one of the release tags or are you building from the head of the master branch? Try checking out the latest tag, 0.17.8, and compiling from there?

Solved, Bazel couldn't find the .git directory which I had removed. One question though: do I have to build everything if I modify only one component and I want to test it?

@comes5 In short, Yes. You'll need to build the whole project to get the core jars for testing. But since bazel is smart enough to do the incremental building, it will only build targets affected by your changes after the initial full building.


cannot type surrogate-pair-characters correctly

in first, sorry for my bad english.
Steps to reproduce
Tell us about your environment:

Puppeteer version: 1.5.0
Platform / OS version: Windows 7 SP1 (x64)
URLs (if applicable): local
Node.js version: 8.2.1 (x64)

What steps will reproduce the problem?
minimum (and confirmed) reproduces code here:
"use strict";

const puppeteer = require("puppeteer");
const exam = async () => {
    const browser = await puppeteer.launch({
        headless: false
    });
    const page = await browser.newPage();
    await page.goto("https://developers.google.com/web/");

    // Type into search box
    await page.type("#searchbox input", "𩸽𠮷𠮟");
};
exam();

I failed testing with headless-mode, cause stopping at goto.
however, I think it is only a enviroment problem.
What is the expected result?
type 𩸽𠮷𠮟 into textbox
(in unicode: \u29E3D\u20BB7\u20B9F - so, yes, surrogate pair charactors)
What happens instead?
typed 鸽ஷட into textbox
(in unicode: \u9e3d\u0bb7\u0b9f)

@JoelEinbinder is this a dupe of #1096?

Yes. Closing as duplicate of #1096.


Windows interpreters

Using nox on Windows with custom interpreters fails, because the virtualenv is passed -p pythonX.Y, and that is not the correct thing on Windows.
I am not entirely sure what the right way to handle this is. Tox does this, which nox could basically port into nox. (Nox already has a which function, but it does a subset of this, expects a path, and also does not run on virtualenv creation.)
Alternatively, nox could expose a function (e.g. nox.path.resolve(maj, min) that would return the appropriate string, which would have to be manually called and assigned to session.interpreter. That would make this behavior explicitly opt-in.
This can be worked around in nox now (since nox.py is a Python script), but is painful for my use case because I would have to copy this to tons of files. Thoughts?

Yeah, let's do it, let's port the subset of tox's logic that we need.

That will require getting AppVeyor working again. Any clue what it is complaining about? (Is it complaining because Unicode strings are being set as environment variables, perchance?)

This is in-progress on this branch; trying to prove it actually works before writing tests and making a PR.

#18 is merged.


Updates and some small fixes

Thanks!

heck yeah i love the https://github.com/Chik3r/tModPorter/pull/10/commits/2091120305b516bbae19711163725c7ecb31f3eb
its a nice item Rewrite


Remove VEP plugin UTRannotator

Description
The VEP endpoint will not have the external plugin UTRannotator available.
This PR removes docs added in https://github.com/Ensembl/ensembl-rest/pull/517
Use case
Plugin functionality won't be available through REST.
Benefits
Possible Drawbacks
None
Testing
note to submitters and reviewers: documentation-only changes may reflect
changes in other repos that can result in new or different output from
REST endpoints. In turn, these may require new tests or changes to existing tests.
Have you added/modified unit tests to test the changes?
If so, do the tests pass/fail?
Have you run the entire test suite and no regression was detected?
Changelog
Are you changing the functionality of an endpoint? If so, please give a one line summary for the public facing changelog.
Revert the functionality of:
[/vep/:species/hgvs/]
[/vep/:species/id/]
[/vep/:species/region/]

Coverage decreased (-0.01%) to 44.312% when pulling bc92d694c5f08eb4e34e645ffe0f490b192505ff on dglemos:remove_utrannotator_107 into 56e1ade734b96e53f6a2089f3a5983494d630933 on Ensembl:release/107.


Changes in Script.cs

Fixed ToString() override.
Added null protection for lastOpcode in ToOps().


TeachingTip: Toggle theme now button text is not completely visible in 200% text scaling mode.

Describe the bug

Steps to reproduce the bug

Pre-requisite:

Change the system resolution to 1280 * 768.
Open Ease of Access settings and change the text Scaling to 200% (Ease of Access settings -> Display -> Make Text Bigger -> Change the slider to 200% -> Apply).

Steps to reproduce the behavior:

Launch XAML Controls Gallery.
Activate Teaching Tip from All Controls page.
Activate Show Teaching Tip button present under the header "Show a non-targeted Teaching Tip with buttons"
Check if the "Toggle Theme Now" button is completely visible or not.

Expected behavior

Toggle Theme Now button should be completely visible in 200% text scaling mode.
Screenshots

Version Info

Xaml Controls Gallery version <IP_ADDRESS>
Additional context

Copied from internal bug

dupe/related to #3513

We will be tracking this in our internal issue

Why not keep this open and update it when the internal issue is fixed too?

Sure, we may need a similar top level GH item we resolve these issues duplicate of. Trying to make it clear of # of source of issues...

Sure, we may need a similar top level GH item we resolve these issues duplicate of. Trying to make it clear of # of source of issues...

Sure. A label for issues that are also being tracked internally is one way of doing it.
By closing them they can look like they're fixed, or you're not interested in allowing the community to see progress or know when these issues are actually fixed.
Also closing the public version of an issue that is being tracked internally also undermines the message we've heard previously that eventually all work on this repo/project will be done in the open.

@mrlacey , yup, thanks for catching this.

Does not repro with updated visuals so closing:


Josephus Problem is solved

🛠 Issue 1318
#1318
👨💻 Changes proposed

✔ Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshot

Sir all requested changes are done


Model used to train the agent

I'm trying to train a custom agent to learn how to swim in one of the environments provided by this repo using deep Q learning. However, I'm not sure how to get around the fact that the action space is continuous and the observation space is a dictionary of arrays, since all the deep Q models I've looked at initialize their num_actions and num_states variables as follows:
num_actions = env.action_space.shape[0] num_states = env.observation_space.shape[0]
Is there some other way to train this model using action_spec() and observation_spec()? If so, are there examples that I can look at?
Thanks!

Also, for something simple like fish swimming to the target, how many time steps were used in each episode to train, and how many episodes were used in the model?


Windows 10 April 2018 Update with high-dpi displays: RibbonButton dropdown items click events not firing.

This issue happens only on Windows 10 updated to April 2018 (version 1803). If you set the display scaling above 100% (i tried 150% and 200%), the click event does not fire when clicking items on dropdown RibbonButtons.
Note that scaling over 100% is the default in most high-dpi displays.
Debugging the issue I have discovered that the problem is related to FeedHookClick function on RibbonPopupManager class. This function checks if the mouse position is contained into the dropdown bounds.
While before April 2018 Update the mouse location passed as parameter is scaled accordingly with display scaling setting, on April 2018 the mouse location is the real one, related to the physical display resolution, not scaled.
If you set the display scaling at 100% the virtual ant the physical mouse coords are the same, so the issue does not happens.
On April 2018 Update when scaling over 100% the FeedHookClick function mouse position check fails because the (physical) mouse position is outside the (virtual) dropdown bounds, so the function returns false and no mousedown/click/ect. events are fired.
The mouse location passed to FeedHookClick function come from the windows message queue hooked with SetWindowsHookEx API (see GlobalHook class, InstallHook function). This means that Microsoft has changed some policies on passing these coords with April 2018 Update.
Can this be considered a bug from Microsoft? Maybe, i don't know. The problem is: how to fix the bug on the Ribbon? You could change the FeedHookClick function scaling correctly the mouse position before checking, but it will work only on April 2018 Update, not with prior versions.
Should you check the version of Windows and scaling before checking only if >= April 2018 Update?
Anyway, in the meantime i have modified the FeedHookClick function returning ALWAYS true, so the mouse events are always fired. I have made some tests and, for my situation, i have not found any negative side effects.
Somebody can say something more about this issue?
NOTE that maybe the problem could be the same of the issue #1 opened on 26 Nov 2017 by PietF

You can commit the changes to the repository

yes same problem here. interestingly my office computer doesn't affected.

AL-74
did yoy test clicking outside the ribbon yet?  I think the dropdown is going to stay open.
You can replace e.Location by using the GetCursorPos API for a better solution.
GetCursorPos calculates the logical (scaled) location and that is just what we need.
As far as I can see you also have to alter HandleHookMouseDown in the Ribbon class for the same.
PietF

PietF
actually you are right, with my changes clicking outside the dropdown is going to stay open.
My doubt on correcting the problem re-calculating the mouse position (eg. using GetCursorPos API) is that it should be done only if windows is 1803 version, not for other versions.
Morover this new behavior of windows should also be a temporary bug, that could be corrected on a next windows update, sooner or later.

I think the change must be reverted because it breaks it for everyone.
A targeted (temporary?) fix may need to be applied for 1803.
It may or may not be fixed by MS.
On Tue, May 29, 2018, 6:04 PM Al-74<EMAIL_ADDRESS>wrote:

PietF
actually you are right, with my changes clicking outside the dropdown is
going to stay open.
My doubt on correcting the problem re-calculating the mouse position (eg.
using GetCursorPos API) is that it should be done only if windows is 1803
version, not for other versions.
Morover this new behavior of windows should also be a temporary bug, that
could be corrected on a next windows update, sooner or later.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/RibbonWinForms/RibbonWinForms/issues/10#issuecomment-392688476,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEMyXiB3Dy8i3dI2XvAGo-1vBZVyMUDQks5t3QDygaJpZM4T9d9X
.

I can confirm that issue too on these specs :

MacBook Pro 2016 15"
Windows on virtual machine (Parallels Desktop with HiDPI ON)

Cliking on Combobox has no effect

AL-74,
Using GetCursorPos calculates always the logical (scaled) location.
It also should work on older systems. (even when testing on my windows vista everything is okay)
I don't see that this should break it for everyone, tempory bug or not.
PietF

PietF,
i have made some tests using GetCursorPos and actually it seems to work well in all situations.
adriancs2 I have created a pull request with the correct fix.
Thank you guys!

I use ribbon in my projects since 2014, never gave a problem, but now with the update of windows 10, it is giving that CLick problem, which has already been reported, would you just update the ribbon35 dll without having to redo the project?
I tried replacing the Ribon dll just by giving rename, but it did not work

Hi, this problem is fixed in latest version. You may try the nuget version.
Guide: How to add ribbon library via Nuget:
https://github.com/RibbonWinForms/RibbonWinForms/wiki


Challenges data

Does this api list ALL available endpoints? Is there currently any endpoint which holds Battlepass week data eg: Challenges by week.

These are the known endpoints, theres surely other ones but apparently Epic decided to enable certificate pinning in the latest Fortnite update, hence its not possible to look around for other ones anymore.

Do you think sites pull Challenges from an endpoint(no evidence from any api on github) or by entering it manually?

The Challenges are in game files. Not an API Endpoint. It's all included in your cloud save so being able to get the data out from that, would be difficult.

I am sure fortnitetracker doed it automatically whether its api or umodel i just cant find any info anywhere

It's manual data mining. I'm in the process of writing an automated thing for it, though.

Posted this in the Discord
But I'm making good progress on the Data extraction tool. Working well!
https://cdn.discordapp.com/attachments/392667296822198279/448923803599503362/rec20.gif
I have all ingame items: names, descriptions and preview images. As well as Challenges: names and descriptions
Going to add the ability to scrape the data values (ie. rarity, challenge count etc)

I think it would be a nice addition to the script if you haven't already to
allow a covert to png or something :)
On Thu, 24 May 2018 at 04:45 JaydenMaalouf<EMAIL_ADDRESS>wrote:

Posted this in the Discord
But I'm making good progress on the Data extraction tool. Working well!
https://cdn.discordapp.com/attachments/392667296822198279/448923803599503362/rec20.gif
I have all ingame items: names, descriptions and preview images. As well
as Challenges: names and descriptions
Going to add the ability to scrape the data values (ie. rarity, challenge
count etc)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/qlaffont/fortnite-api/issues/85#issuecomment-391464706,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANK6vFOgHPkBGg4R1PetwowyP7OUxD0bks5t1bVZgaJpZM4T3-v1
.

@JaydenMaalouf did you make progress on the extraction tool ? I'd be glad to help if needed

this PR may be of help: https://github.com/qlaffont/fortnite-api/pull/126. I don't really have all challenge data, it's manually added. Would love to see your extraction tool @savisaar2 :)

I haven't worked on it since May so it may need be upto date with the current version of Fortnite. However, I can take a look over the coming weekend.

Let me know, I’m happy to help with it if the code is posted somewhere.

I will create a repo when I'm home next. Currently in the office.

@JaydenMaalouf I figured out how to get the value's for challenges, but could use help figuring out how to get their names

Posted this in the Discord
But I'm making good progress on the Data extraction tool. Working well!
https://cdn.discordapp.com/attachments/392667296822198279/448923803599503362/rec20.gif
I have all ingame items: names, descriptions and preview images. As well as Challenges: names and descriptions
Going to add the ability to scrape the data values (ie. rarity, challenge count etc)

Can you give me your code

I know this is an old post but I'm curious if anyone has been able to get challege completion status? Fortniteapi.com has a legit challenge endpoint
Challenges
GET Challenges
https://fortnite-api.theapinetwork.com/challenges/get?season=current
HEADERS
Authorization{{authorization}}
PARAMS
seasoncurrent
Example Request
Challenges
curl --location --request GET "https://fortnite-api.theapinetwork.com/challenges/get?season=current"
--header "Authorization: {{authorization}}"
Just create an account and to get your authorization code and replace {{x}} with your code --> returns


Drawer no longer close (head)

Using git head the Drawer no longer closes on
pressing outside the drawer.
I think maybe on_after_leave has to also be on the fade transition but that is not the only issue
as the drawer still does not seem to close when is_lock is set to false.

Can you write a minimal repetition example?

Sure
https://github.com/glennpierce/thaw_testing
Contains a page with a drawer and popup.
The popup display small despite the width parameter.
Also when you open the drawer it stays open when clicking on the body of the page.

The popup display small despite the width parameter.

https://github.com/glennpierce/thaw_testing/blob/1d59c048e4521b69ab7c085a33d1413cfc196893/src/pages/home.rs#L22
https://github.com/glennpierce/thaw_testing/blob/1d59c048e4521b69ab7c085a33d1413cfc196893/src/components/layout.rs#L31
Width parameter delete ;, for example: width="1200px"

Also when you open the drawer it stays open when clicking on the body of the page.

https://github.com/glennpierce/thaw_testing/blob/1d59c048e4521b69ab7c085a33d1413cfc196893/src/components/layout.rs#L18
You need to modify the placement parameter before opening the pop-up window. Change to:
    let open = Callback::new(move |new_placement: DrawerPlacement| {
        placement.set(new_placement);
        show.set(true);
    });

Thanks.
The ; I left is was silly :( Sorry.
I'm surprised setting the show first effected the later hiding. That may rear its head again seems to expose the implementation detail to the api. Why does it fix it ?

This PR(#115) fixes the Drawer closing issue, but still requires you to change placement placement.


[BUG] Actual response value type sncMode in SapTableLinkedServiceTypeProperties for DataFactory is not aline with the API definition

API Spec link
https://github.com/Azure/azure-rest-api-specs/blob/b61dcef24c4dbd9d1c26e321c9ea67465a5d8be7/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/LinkedService.json#L7784
API Spec version
2018-06-01
Describe the bug
The API definition for sncMode is a string value, but the actual result is a bool vlaue.
Please have a service team member who is on DataFactory to check which value type is correct.
Expected behavior
"sncMode": "false"
Actual behavior
"sncMode": False
Reproduction Steps
Call GET (or other related operation) for
/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataFactory/factories/{factoryName}/linkedservices/{linkedServiceName}
Environment
No response

Related customer issue: https://github.com/Azure/azure-sdk-for-net/issues/45772

@Frey-Wang Please help take a look, thanks.

"sncMode" should be a boolean value, I will fix it.


[FLINK-2596] Failing Test: RandomSamplerTest

Remove the non-transitive comparator which cause this issue, default Double comparator works just fine.

Looks good to merge. :+1:

Thanks, will merge this!

This has been merged, but I think apache and github is out of sync again. Feel free to manually close this.
Thank you for the contribution!
https://git-wip-us.apache.org/repos/asf/flink/repo?p=flink.git;a=commit;h=f4a48c23a30c170a5a2c08c27e1f01f7827eefd2


Sleigh: Duplicate Symbol Name?

I would like to support an instruction similar to the following:
:add a0, a0 is opcode_00_16=0b1111111111 & a0
{}

The instruction is 16-bits. It references register a0 twice. This fails in the Sleigh compiler with:
ERROR MyProc.slaspec:123: Duplicate symbol name: a0 (previously defined at MyProc.slaspec:123) (SleighCompile)

I am unable to use attach variables (take my word for it, I admit I'm doing weird stuff). I don't want to define the entire instruction as a mnemonic.  I need a0 to be a register. Basically I need it to work like this:
:add a0, a1 is opcode_00_16=0b1111111111 & a0 & a1
{}

But with a0 twice. As the first instruction is a valid instruction there has to be a way right? Thanks in advance.

The fact that you say you can't use attach values for it is interesting, but it's a solvable problem. One way to duplicate the register name in the operands would be to use a string, which would work fine as long as it was always a0, and not possibly some other register:
:add a0, "a0" is opcode_00_16=0b1111111111 & a0 {}

Another way would be to use a sub-constructor:
a0_: a0 is a0 { export a0; }
:add a0, a0_ is opcode_00_16=0b1111111111 & a0 & a0_ {}

A third way is to not worry about the correctness of the display and just use a single a0:
:add a0 is opcode_00_16=0b1111111111 & a0 {}

@GhidorahRex : Thank you for the quick response. The sub-constructor is the closest to what I want, I'll attempt to use that.
Taking a step back, I would consider this a bug in SLEIGH. The above instruction is a valid instruction and should be able to be represented in SLEIGH. We should be allowed to have duplicate register names IMHO.


feat(vm): implement system-actor

Summary of changes
Changes introduced in this pull request:

Implement the system-actor

Reference issue to close (if applicable)
Closes #269

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@austinabell updated


Support WinUI3+ProjectReunion

On top of the impl_inner branch, I am trying to build a sample that uses WinUI3+ProjectReunion. For that I have used the xaml_app and reunioncppdesktopsampleapp as a basis. My Application already partially works. I am able to generate bindings for the WinUI3 winmd files (which I extracted from the ProjectReuinion NuGet package) and then use these to implement Microsoft.UI.Xaml.Application and override OnLaunch (Really much like the xaml_app example). However the app crashes with an internal exception from WinUI3: Exception thrown at 0x00007FFD11A73B19 (KernelBase.dll) in winui3.exe: WinRT originate error - 0x80004005 : 'WinUI: Error creating an UWP Window. Creating an UWP window is not allowed.'.
The exception comes from a separate Thread (i.e. not the Main Rust thread and probably internally from within the WinUI3 implementation) with the following StackTrace:
KernelBase.dll!RaiseException()	Unknown
combase.dll!SendReport(HRESULT error, unsigned int cchMax, const wchar_t * message, unsigned short pSid, void * pExceptionObject, IUnknown *) Line 438	C++
combase.dll!RoOriginateError(HRESULT error, HSTRING__ * message) Line 590	C++
Microsoft.ui.xaml.dll!DirectUI::Window::Window(void)	Unknown
Microsoft.ui.xaml.dll!ctl::ComObject<class DirectUI::Window>::ComObject<class DirectUI::Window>(struct IInspectable *)	Unknown
Microsoft.ui.xaml.dll!DirectUI::Window::Create()	Unknown
Microsoft.ui.xaml.dll!DirectUI::DXamlCore::InitializeInstance()	Unknown
Microsoft.ui.xaml.dll!DirectUI::DXamlCore::InitializeImpl(enum InitializationType,bool)	Unknown
Microsoft.ui.xaml.dll!DirectUI::FrameworkView::Initialize()	Unknown
twinapi.appcore.dll!Windows::ApplicationModel::Core::CoreApplicationView::CreateAndInitializeFrameworkView()	Unknown
twinapi.appcore.dll!Windows::ApplicationModel::Core::CoreApplicationViewAgileContainer::InitializeView()	Unknown
twinapi.appcore.dll!<lambda>(void)()	Unknown
SHCore.dll!_WrapperThreadProc()	Unknown
kernel32.dll!BaseThreadInitThunk()	Unknown
ntdll.dll!RtlUserThreadStart()	Unknown

I have also compared my Application with the reunioncppdesktopsampleapp one written in C++ (from which I already use the Appxmanifest and other things) but I am unable to find any differences (except that the C++ one uses a single threaded apartment, which when used in Rust gives the following exception: Exception thrown at 0x00007FFD11A73B19 (KernelBase.dll) in winui3.exe: WinRT originate error - 0x8001010E : 'The Application Object must initially be accessed from the multi-thread apartment.'. 🤔).

I haven't yet looked into using WinUI/ProjectReunion.
@BenJKuhn @jonwis - is there any docs on how to bootstrap these APIs for developers that aren't using msbuild?
@scottj1s I noticed you contributed to the Project Reunion sample cited above. Any obvious gotchas?
Would be great if someone from WinUI/ProjectReunion could take a stab at writing a Rust example app. We've had such contributions from the teams that own APIs like DirectX and WebView2. Happy to work with anyone who can lend some expertise.

What makes my Rust program an UWP app and what makes the C++ program a desktop app

As you know, Cargo will produce a regular Windows executable by default, which you can simply run directly. I think the error about a "UWP window" refers to when the executable is bundled in an appx package, registered, and then launched from the Start menu. Now the same executable is running in a special process with a package identity. This is required by some APIs like CoreApplication (example) and in-box Xaml's Application::Start (example). This is all rather complicated and hard to debug, so hopefully WinUI/ProjectReunion does not require that, but again those APIs are all beyond my area of expertise so hopefully someone else will chime in.

Little update:
I have now also tried ProjectReunion 0.5-prerelease, because it supports UWP. Sadly your implement macro struggles a bit with the preview release and produces incorrect code which I then manually patched. But all that work didn't pay off because I now get a null pointer exception inside the same winui thread during Application::Start: Exception thrown at 0x00007FFDF3C2AD5B (Microsoft.ui.xaml.dll) in winui3.exe: 0xC0000005: Access violation reading location 0x0000000000000000. in:
Microsoft.ui.xaml.dll!ModernResourceProvider::TryGetResourceCandidate()  Unknown
Microsoft.ui.xaml.dll!ModernResourceProvider::TryGetLocalResource()  Unknown
Microsoft.ui.xaml.dll!ResourceManager::TryGetLocalResource()  Unknown
Microsoft.ui.xaml.dll!XamlNodeStreamCacheManager::GetBinaryResourceForXamlUri()  Unknown
Microsoft.ui.xaml.dll!CCoreServices::TryLoadXamlResourceHelper()  Unknown
Microsoft.ui.xaml.dll!CoreServices_TryGetApplicationResource()  Unknown
Microsoft.ui.xaml.dll!DirectUI::DXamlCore::ShouldTryLoadAppXaml(class xstring_ptr const &)  Unknown
Microsoft.ui.xaml.dll!DirectUI::DXamlCore::EnsureCoreApplicationInitialized()  Unknown
Microsoft.ui.xaml.dll!DirectUI::FrameworkView::Initialize()  Unknown
twinapi.appcore.dll!Windows::ApplicationModel::Core::CoreApplicationView::CreateAndInitializeFrameworkView()  Unknown
twinapi.appcore.dll!Windows::ApplicationModel::Core::CoreApplicationViewAgileContainer::InitializeView()  Unknown
twinapi.appcore.dll!<lambda_8a59c5a5949f65bb89733ef0087a4b8e>::<lambda_invoker_cdecl>()  Unknown
SHCore.dll!_WrapperThreadProc()  Unknown
kernel32.dll!BaseThreadInitThunk()  Unknown
ntdll.dll!RtlUserThreadStart()  Unknown

I am really hoping that I just did something really silly somewhere, that this is easily fixable 🙈.

struggles a bit with the preview release and produces incorrect code

Can you share a minimal repro?


Approval to update LJC's new logo

It appears JLC has a new logo and I would like to update it on the MP site and other materials.

Hey amazing @karianna- Martijn,
While working on the MP white paper, Ryan noticed the JLC is different. if yes, can you help update the JUG logo by attending the drive files and following up via this git issue?
Thanks and abrazos #usualsuspects :)

All good thanks!

Logo package uploaded.

you are wonderful @karianna- thanks for quickly updating newest LJC logo! :) already updated across by @rstjames!


Question regarding using pool connection to query data

I have tried to fetch some data from database. The query should yield some information in rows but it kept being empty. I am not sure what I've done wrong in this snippet...
conn.query('SELECT `upasshash` FROM `user` WHERE `uname` = ?' ,
        [ 'some_user' ],
        function (err, rows, fields) {
        if (err) throw err;
        if (!rows) {
            web_res.json({
                status: 401,
                message: 'no such user with given password'
            });
        } else {

hey did you found the solution for your issue?


added segment tree template

Added a segment tree template.
The segment tree implemented can be used to find the maximum value within a range.

@Shivesh-K   Please write the methods and how will you use it and commit again


New version: Parallels.Parallels version 19.4.25171

Pull request has been created with komac v2.3.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

/azp run


Crashing after new install

Steps to reproduce
After the update, sometimes the app start crashing. Now, I'm not even being able to open  the app.
Expected behavior
App should open  normally
Actual behavior

Crash logs
No response
Neko version
2.16.0
Android version
14
Device
S23
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[ ] I have written a short but informative title.
[X] I have updated the app to the newest version Latest.
[X] I have filled out all of the requested information in this form.

Update to 2.16.1


⚠ ClamAV has degraded performance

In a91370e, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: ClamAV performance has improved in ca0272c after 535 days, 2 hours, 1 minutes.


Unsupported URL: pladform.ru

Checklist

[x] I'm reporting a new site support request
[x] I've verified that I'm running youtube-dl version 2019.10.29
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that none of provided URLs violate any copyrights
[x] I've searched the bugtracker for similar site support requests including closed ones

Example URLs

Single video: http://out.pladform.ru/player?pl=15978&videoid=101194430
Single video: http://out.pladform.ru/player?pl=15978&videoid=101293288

Description

All video examples above plays fine in Google Chrome browser.

already supported.


Added docs on modifying pvc templates.

refs: #265
Add user docs for pvc template changes.

I requested to add about webhook verbally.

@masa213f
Sorry for the delay, I added the webhook description:
https://github.com/cybozu-go/moco/pull/424/commits/1b75bda81aa08393aed5f4dcd4448e20b009cff5


Promotion of negative integers

Hi,
currently evaluating the implementation. Stumbled across this conversion issue:

int main()
{
    using w_t = math::wide_integer::uintwide_t< 32, std::uint32_t, void, true >;
    using ww_t = math::wide_integer::uintwide_t< 64, std::uint32_t, void, true >;

    w_t neg( -2 );
    ww_t neg_wide( -2 );
    ww_t neg_wide_cast = ww_t( neg );

    std::cout << neg << std::endl;
    std::cout << neg_wide << std::endl;
    std::cout << neg_wide_cast << std::endl;
}

which gives
-2
-2
4294967294

I guess that promotion simply adds zeros to the left, but this
does not work for negative integers. Let me know if I am missing
something.
Tested with 7b9347e
Cheers,
Nils

promotion simply adds zeros to the left, but this does not work for negative integers.

Good find. It is a bug.
I can reproduce the buggy behavior and will correct it ASAP.
Thank you Nils.

Nice! Thanks for the quick response.

OK. There is a fix for this in main branch now.
To be honest, there is not a huge amount of testing and/or field experience with mixed limb-size/digit-counts, so there might be a few more problems lurking around in such conversion areas.
Thanks again for reporting this bug and please feel free to report more if/when found.

That was quick, thanks for the fix! :)
I will definitely let you know in case I stumble across something else.


Tools disabled

Hi, I am not sure what I am doing wrong, but tools are always disabled.
I have upgraded apollo-client to (0.5.20) and react-apollo to (0.7.1)
No luck (I also noticed that APOLLO_CLIENT was not in global variables at this point)
Then, I have  added following code to my client initialisation:
client = new ApolloClient({
      networkInterface,
      dataIdFromObject: (result: any) => {
        return result._id;
      },
      connectToDevTools: true
    });

    window.__APOLLO_CLIENT__ = client;

Still no luck.
Running latest Chrome 55, on Mac OS X.

And just like that after several reloads and browser restart all is jolly ...

Yeah it's odd, we'll just have to work on making it more stable over time! One of the things I learned from this project is that the Chrome APIs don't exactly make these things easy. But they do make them possible!


[Event Request] Codeunit 90 - OnBeforeInsertReceiptLine

Please add a new integration event OnBeforeInsertReceiptLine in Codeunit 90.
    [Integration]
    LOCAL PROCEDURE OnBeforeInsertReceiptLine@1000(VAR PurchRcptHeader@1000: Record 120;VAR PurchLine@1001: Record 39;VAR CostBaseAmount@1002: Decimal;VAR IsHandled@1003: Boolean);
    BEGIN
    END;

Call for function:
    LOCAL PROCEDURE InsertReceiptLine@143(PurchRcptHeader@1000 : Record 120;PurchLine@1001 : Record 39;CostBaseAmount@1006 : Decimal);
    VAR
      PurchRcptLine@1003 : Record 121;
      WhseRcptLine@1004 : Record 7317;
      WhseShptLine@1005 : Record 7321;
+     IsHandled@1006: Boolean;
    BEGIN
+     OnBeforeInsertReceiptLine(PurchRcptHeader,PurchLine,CostBaseAmount,IsHandled);
+     IF IsHandled THEN
+       EXIT;

      PurchRcptLine.InitFromPurchLine(PurchRcptHeader,xPurchLine);
      PurchRcptLine."Quantity Invoiced" := RemQtyToBeInvoiced;
      PurchRcptLine."Qty. Invoiced (Base)" := RemQtyToBeInvoicedBase;
      PurchRcptLine."Qty. Rcd. Not Invoiced" := PurchRcptLine.Quantity - PurchRcptLine."Quantity Invoiced";

      IF (PurchLine.Type = PurchLine.Type::Item) AND (PurchLine."Qty. to Receive" <> 0) THEN BEGIN
        [...]
      END;
      OnBeforePurchRcptLineInsert(PurchRcptLine,PurchRcptHeader,PurchLine,SuppressCommit,PostedWhseRcptLine);
      PurchRcptLine.INSERT(TRUE);
      OnAfterPurchRcptLineInsert(
        PurchLine,PurchRcptLine,ItemLedgShptEntryNo,WhseShip,WhseReceive,SuppressCommit,PurchInvHeader,TempTrackingSpecification);
    END;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


fix: Add missing tenant label to some loki_write metrics

We notived that in the other loki.write metrics we find the tenant label, but it's missing for loki_write_send_.+ and those are useful.

PR Description
Which issue(s) this PR fixes

Notes to the Reviewer
PR Checklist

[ ] CHANGELOG.md updated
[ ] Documentation added
[ ] Tests updated
[ ] Config converters updated

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add dark theme.

Could you add dark theme please.

I would gladly accept a PR for the dark theme 🙂
I suggest looking into creating small stylesheet file that can work on top of existing styles to only override some colors, so that we decrease the maintenance for the two themes.
Then create a new option on the options page with the dropdown selector for the theme. When "dark" is selected, inject the additional override styles where applicable.

The next version of browserpass will have dark theme:

Thank you! (:


Make ispyb handler deal with different experiment types

#43 #45 #372 should be done as part of this (if still necessary)


rkt containers access other containers on different hosts

Environment
rkt Version: 1.25.0
appc Version: 0.8.10
Go Version: go1.7.3
Go OS/Arch: linux/amd64
Features: -TPM +SDJOURNAL
Linux 4.10.4-coreos-r1 x86_64
NAME="Container Linux by CoreOS"
ID=coreos
VERSION=1353.4.0
VERSION_ID=1353.4.0
BUILD_ID=2017-03-31-0211
PRETTY_NAME="Container Linux by CoreOS 1353.4.0 (Ladybug)"
ANSI_COLOR="38;5;75"
HOME_URL="https://coreos.com/"
BUG_REPORT_URL="https://github.com/coreos/bugs/issues"
systemd 233
+PAM +AUDIT +SELINUX +IMA -APPARMOR +SMACK -SYSVINIT +UTMP +LIBCRYPTSETUP +GCRYPT -GNUTLS -ACL +XZ -LZ4 +SECCOMP +BLKID -ELFUTILS +KMOD -IDN default-hierarchy=legacy
What did you do?
Access rkt containers to access other containers on a different host
What did you expect to see?
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=63 time=0.072 ms
What did you see instead?
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
^C
--- <IP_ADDRESS> ping statistics ---
11 packets transmitted, 0 received, 100% packet loss, time 10228ms

I think it's expected behaviour that this won't work with the default cni/bridge plugin out of the box.
To get it to work, at a minimum you'd probably have to add rules to the FORWARD chain (or set its default policy to ACCEPT).
If you want containers to talk to each other cross-host, perhaps you want an overlay network (such as a vxlan overlay created by flannel), and to use a CNI plugin which will add pods on each host to that overlay network.
cc @squeed
The iptables-save output on the host could help to check if it's what I mention above.

This is not going to work without either an overlay network, direct access from the container to the network (e.g. macvlan + dhcp), or a route export from each host to the routing + switching fabric.
My suggestion would be to look in to flannel.


[BUG] Unable to open the first record in the Grid. Failing at xrmApp.Grid.OpenRecord(0); for D365 2021 release wave 1 enabled

Bug Report
Issues should only be created for items related to covered functionality.
Not covered functionality, feature requests, and questions should use the Feature Request or Question templates.
EasyRepro Version

[ ] Microsoft Dynamics 365 Online Version 8.2 (8.2.x) (DB 8.2.x) online
[ ] Microsoft Dynamics 365 Online Version 9.0 (9.0.x) (DB 9.0.x) online
[ ] Microsoft Dynamics 365 Online Version 9.0.2 (9.0.2) (DB 9.0.2) online
[ ] Microsoft Dynamics 365 Online Version 9.1 (9.1.x) (DB 9.1.x) online

UCI or Classic Web

[x] UCI (XrmApp)
[ ] Classic Web (XrmBrowser)

Online or On Premise

[ ] Online
[ ] On Premise

Browser

[x] Chrome
[ ] Firefox
[ ] IE
[ ] Edge

Describe the bug

Special formatting / display

Code to reproduce

Expected behavior

Screenshots

Additional context

Facing this same issued since 9/12/2021. looks like latest product update has caused the issue.

@AddalaDeviPriya  and @amars4u Is this related to RW2? The title of the issue states RW1. RW1 should work as expected. Let me know. - Ali

@aliyoussefi  I am having issue with RW1 as well

Good Morning Ali,
I too see this issue in RW1 and Error that is throwing is System.NullReferenceException: 'Object reference not set to an instance of an object.'
Few things to note here, here are the updates i made to the packages -

updated the chrome from 91 to 93 version.
This is coming in Release wave1 only and when we run the script it fails to open the record and throws this exception because it tried to execute the next step and it couldn't identify the record details as the step xrmApp.Grid.OpenRecord(0); didn't opened the record.

@AddalaDeviPriya and @amars4u Is this related to RW2? The title of the issue states RW1. RW1 should work as expected. Let me know. - Ali

I am facing this issue in below mentioned version. My project is on government cloud.
2021 release wave 1 enabled
Server version: 9.2.21082.00150
Client version: 1.4.3120-2108.2


[Bug]: Using dts.bundle: true does not fully bundle.

Version
System:
  OS: Windows 11 10.0.22631
  CPU: (20) x64 13th Gen Intel(R) Core(TM) i9-13900H
  Memory: 10.85 GB / 31.75 GB
Browsers:
  Edge: Chromium (128.0.2739.42)
  Internet Explorer: 11.0.22621.3527

npmPackages: "@rslib/core": "^0.1.0"

Details
使用 dts.bundle: true 并没有打包完全

Using dts.bundle: true does not fully bundle.
Reproduce link
https://github.com/Zhang-Wei-666/rslib-bug-report/tree/2
Reproduce Steps
运行以下命令进行构建
pnpm i && pnpm build

查看打包产物 dist/index.d.ts 中可以发现以下内容未被打包
import type { UpperCaseCharacters } from './internal';
import type { WordSeparators } from './internal';

Run the following command to build.
pnpm i && pnpm build

Please check the packaged product at dist/index.d.ts to find the following content that has not been packaged.
import type { UpperCaseCharacters } from './internal';
import type { WordSeparators } from './internal';

This may be an issue of api-extractor when bundling complex 3rd dependecies, similar to https://github.com/web-infra-dev/rslib/issues/411
We are collecting issues for that now and this issue will be tracked too.


Add move package function to YamlCreate

[x] Have you signed the Contributor License Agreement?

@officialesco @jedieaston @mdanish-kh
I've had a script in a separate branch of my repo for moving packages for several months now, and it's been greatly helpful. However, it's a pain to swap between branches, or to checkout the file and commit it temporarily onto the main branch before reverting the commit after the packages have been moved.
This PR takes the functionality of that script and moves it into YamlCreate as a new mode, making it more accessible to the community.
Microsoft Reviewers: Open in CodeFlow

@denelon

@mdanish-kh - Seems I fixed only one of the two misspells earlier; Pushed a new commit


Add authorization parameters in if configured

Any kind of configured authorization parameters are not passed to api calls from instantiated client
Again, just starting a dialog with potential fix. I can add tests if you agree this is the right fix.
# Assuming Conf::Github[:client_id]/Conf::Github[:client_secret] is a valid Github auth pair.
github = Github.new do |config|
  config.client_id     = Conf::Github[:client_id]
  config.client_secret = Conf::Github[:client_secret]
end

# Before patch
github.ratelimit      # => 60

# After Patch
github.ratelimit      # => 5000

This issue has been fixed, any extra parameters are now passed through.

@piotrmurach Could you explain how this was fixed? The code snippet from @phil-monroe still doesn't work, and the only way I found to include the additional client_id and client_secret params on request's URL is by including on each API call
i.e.:
repo = Github::Client::Repos.new(user: 'a-user', repo: 'a-repo')
repo.contents.get(path: '/foo', client_id: ENV['CLIENT_ID'], client_secret: ENV['CLIENT_SECRET'])

Is there an easier way to set these credentials for all API calls that I missed?
Also (and kind of offtopic from this issue), since you mention you usually used OAuth tokens for authentication, is there a way to use 2-legged OAuth authentication with Github for server-to-server communication?


Failed to run klipper_estimator

Hello
i get an error when i want to slice the file and transfer it to klipper.
Fallen to run klipper_estimator
b'thread main panicked at 'gcode read: IO(Error {kind: InvalidData, message: "stream did not contain valid UTF-8" }, tool/ src/cmd/post_process.rs:355:27\nnote: run with 'RUST_BACKTRACE=1 environment variable to display a backtrace\n'
I use
klipper-preprocessor and I also entered where the klipper_estimator is located

Hi @Tomek5111
This is caused by one or more lines in the input file containing non-UTF8 characters. As gcode should always follow this, you are seeing a bug in whatever is outputting the gcode(I'm assuming Cura).
Best regards,
Lasse


Research: Make watch task more robust (2nd approach)

This is another test using http-proxy and tinylr for live reloading.
Please tell me what you think when you have a chance.
Thanks!

Awesome that you found another way!

The redeployment is working fine but the reload is not happening. I dug a bit in the code and figured out that the reload event is sent to the browser but is not properly executed.
I fixed that by editing ./node_modules/liferay-theme-tasks/node_modules/livereload-js/dist/livereload.js on line 409 with window.location.reload();.
It seems that this is a bug on livereload-js. I am not 100% sure if that's true so it would be great if the author of this PR could look more into that.
Thanks

@trytuna thanks for the comment.
I wanted to ask you more details about it:

the reload event is sent to the browser but is not properly executed.

Does this happen for scss and js files?
I also wanted to let you know that is still "work in progress"; so for example, right now if a template is changed it the browser will not be reloaded (yet).

Does this happen for scss and js files?

I've tested it with scss files

@trytuna ok thanks, I'll have a look.
Can I also ask you which OS and browser you're using?

@trytuna ok thanks, I'll have a look.
Can I also ask you which OS and browser you're using?

Sure
macOS 10.14.3 (18D109)
Google Chrome 72.0.3626.121

@trytuna thanks for the info, I'm currently using the same OS (a "bit" older - macOS 10.11) and browser (same version) and can't seem to reproduce the issue here, do you have any extensions enabled that could be  (ad-blocker?)

@trytuna thanks for the info, I'm currently using the same OS (a "bit" older - macOS 10.11) and browser (same version) and can't seem to reproduce the issue here, do you have any extensions enabled that could be interfering (ad-blocker?)

I tried that again with Chrome in incognito mode and all plugins disabled. I've also tried Safari and Firefox. Same Issue :(.
A bit more details on my setup:
gulp -v
[10:14:57] CLI version 2.0.1
[10:14:57] Local version 3.9.1

I am using Liferay 7.1.0-ga1 and<EMAIL_ADDRESS>for generating my theme.

I try to dig a bit deeper to get a better glimpse of the problem.

@trytuna thanks for the update, I will have a look at that shortly

@wincent @jbalsas a quick update: reloading the assets (css, images, javascript) works better right now, I still have to check what @trytuna mentioned.
Concerning the templates I'm really not sure how to approach the "reload", but if you have suggestions I'm all ears.
Thanks

Following up on my last comment.
The issue I think is that the reload in the browser happens before Liferay is done deploying. An approach would be to trigger an event from Liferay and send it to the gulp watch task.


Question

Hi,
I have used your NBitcoin Library followed a few examples and seen some progress.

I am a little confused now, is this application now some how syncing to the blockchain like Bitcoin Core or is it using some other way to get data of the blockchain.
Do I need to run my own full bitcoin core node now with an RPC interface to work with this library.
Thanks Patrick

If you use QBitNinja then you depends on a block explorer. This has some risk because you depends on how available it is, and on its own interpretation of consensus.
The advantage is that you don't need a bitcoin core node running, and you can query way more stuff than you can with bitcoin core, and you don't need to worry about having a sync node.
You can connect to your own Bitcoin Core node with NBitcoin with the RPCClient class.
I advise you to depends on Bitcoin Core for the most you can, and if you find out that Bitcoin Core is not enough for you, then you should host your own Block Explorer. (QBitNinja is open source, but must be hosted on Microsoft Azure)

Got it, thanks


Broadcast to certain group of users thought Sockend

Do Cote provides any mechanism to broadcast not to all, but to a certain group of users through Sockend? Thanks.

Hello @VMois , the only automatic way to achieve that is to use different namespaces.
However if you want to delve deeper, you can manually decide whom to send a message to by effectively reaching out the underlying socket.io connection.

Thanks, @dashersw . Could I use socket.io rooms?


Allow multiple router-views

I have two sections of my templates that are contextual to the given route. Ideally, once the link is clicked, I'd like both sections to update.
Something like this:
URL: http://localhost/blog
const blogRoutes: Routes = [
    {
        path: '/blog',
        view: 'left-nav',
        loadComponent: () => new Promise(resolve => {
            (require as any).ensure([], require => {
                resolve(require('./blog-subnav/blog-subnav.component').BlogSubNavComponent);
            });
        })
    },
    {
        path: '/blog',
        view: 'main-content',
        loadComponent: () => new Promise(resolve => {
            (require as any).ensure([], require => {
                resolve(require('./post-list/post-list.component').PostListComponent);
            });
        })
    }
]

<router-view name='left-nav'></router-view>
<router-view name='main-content'></router-view>

There is support for named route-views already:
https://github.com/ngrx/router/blob/master/docs/overview/route.md#named-components


Error Handling for ExoMAST API data retrieval

When a user enters a target for our tools that request data from the ExoMAST API, if they enter in a bogus name, how should we handle it? Right now the app crashes so it's something we should think about. Some ideas:

Load the same UI with a warning message telling them the target doesn't exist.
Load a new UI with some suggestions/troubleshooting options? (Link them to exomast to look there? Suggest another name that the target might go by?)

I resolved this in #245


Incorrect IMU Type numbers in the Novatel Driver

I have a PwrPak7-E1 which integrates an EPSON G320N IMU.
My GNSS protobuf config file sets the imu_type argument to G320N and is read correctly (the debug logs show that G320N is read)
However, the GNSS driver tries to read the IMU type from the PwrPark and detects a CPT_XW5651 instead. It then uses parameters of the CPT XW5651 (such as the sampling rate) which are incorrect in my setup and ends up with thousands of unexpected delay in IMU data.
While reading the Novatel documentation, I found the table of correspondences between IMU types and their numbers https://docs.novatel.com/oem7/Content/SPAN_Commands/CONNECTIMU.htm
It appears that Novatel has assigned the number 41 to the G320N while Apollo has assigned the number 41 to the CPT_XW5651 and 40 to G320N.
By swapping the values of the G320N with the values of the CPT_XW5651 in modules/drivers/gnss/proto/config.proto, I was able to get the driver to find the correct parameters for my IMU and work correctly.
I suspect that many of the imu_type values in modules/drivers/gnss/proto/config.proto are wrong. I would have loved to send a PR to correct them but I don't find most of the IMUs listed in the Apollo code in the Novatel documentation (for instance I can't find what the number of CPT_XW5651 should be)

@FlorentRevest thank you so much for using Apollo. Apollo currently only works with limited GNSS hardware as you can see in the Specs documents. We are in the process of evaluating and adding new sensors to our platform daily. But for now, I highly encourage you to submit a PR for those IMUs that you are confident about to help our community :)


CI on push fix

Updated remaining API test pipelines (DIND, local OS, s2search, CUDA-DIND) to work on push

Testing matrix (to be completed after merge):

When merged, all CI actions should bass
Run against a recent, working Marqo docker tag (like latest). This should pass
Run against a very outdated Docker tag (like 0.0.5) this should fail


Update how camera limits are defined for rooms

Now instead of using the camera_limits properties (which are now deprecated), two new properties were added to PopochiuRooms: width and height. Popochiu will calculate the camera limits based on the values of those properties instead of asking devs to calculate them by hand.
The corresponding migration step was added to Migration 2 in order to ensure old projects will be updated.

Closes #244


More meaningful warnings for unknown filetypes in detect_filetype

Currently the detect_filetype function in unstructured.file_utils.filetype emits the following warning if it detects an unknown MIME type. This isn't especially helpful because you still don't know what the file type is. The goal of this issue is to update the warning to print out the file extension or filename so it's more obvious what filetype cause the issue.
MIME type was inode/x-empty. This file type is not currently supported in unstructured.

@cragwolfe
I have updated the code and added the filename in the warning message. But this happens when detect_filetype detects the file which is empty. So the warning message should be same or needs to be changed?


[Bug]: iOS - followUserLocation not working

Mapbox Implementation
Mapbox
Mapbox Version
10.12.2
Platform
iOS
@rnmapbox/maps version
10.0.4
Standalone component to reproduce
import React, {useCallback, useEffect} from 'react';
import MapboxGL, {UserTrackingMode} from '@rnmapbox/maps';

import {
  useGetCenterCoords,
  useGetCurrentCoords,
  useLocationState,
  useMapSnapState,
  useMapState,
} from 'hooks';
import {isAndroid} from '@utils';
import {Coordinate, LogManager} from 'model';

const animationDuration = 500;

const MapCamera: React.FC = () => {
  const centerCoords = useGetCenterCoords();
  const currentCoords = useGetCurrentCoords();
  const {followUserLocation, permissionGranted} = useLocationState();
  const {moveCamera} = useMapState();
  const {shouldTakeSnapshot} = useMapSnapState();
  const camera = React.createRef<MapboxGL.Camera>();

  const moveTo = useCallback(
    (coords: Coordinate, zoom?: number | null, animDuration?: number) => {
      const {latitude, longitude} = coords;
      const destZoom = zoom === null ? undefined : zoom ?? 16.35;
      LogManager.log('moveTo', {coords, zoom, destZoom});
      camera.current?.setCamera({
        centerCoordinate: [longitude, latitude],
        zoomLevel: destZoom,
        animationDuration: animDuration ?? animationDuration,
        animationMode: isAndroid ? 'moveTo' : undefined,
      });
    },
    [camera],
  );

  useEffect(() => {
    if (!moveCamera) {
      return;
    }
    if (centerCoords != null && moveCamera) {
      moveTo(centerCoords);
    }
  }, [
    centerCoords,
    moveCamera,
    moveTo,
    shouldTakeSnapshot,
    followUserLocation,
  ]);

  useEffect(() => {
    if (!isAndroid) {
      return;
    }
    if (!followUserLocation) {
      return;
    }
    if (currentCoords != null && moveCamera === true) {
      moveTo(currentCoords);
    }
  }, [currentCoords, followUserLocation, moveCamera, moveTo]);

  const shouldFollowUserLocation = () => {
    if (!permissionGranted) {
      return false;
    }
    return followUserLocation;
  };

  return (
    <MapboxGL.Camera
      ref={camera}
      followUserLocation={shouldFollowUserLocation()}
      followUserMode={UserTrackingMode.Follow}
      animationMode="none"
      animationDuration={0}
    />
  );
};

export {MapCamera};

Observed behavior and steps to reproduce
The map would load and start animating towards user's location, but, after updating some redux state that caused the map to re-render, the map camera's animation would stop, and even by turning off and on the value used for followUserLocation prop would not make any difference. Even setting followUserLocation to true statically would not work.
Expected behavior
The map should move towards the user's current location anytime the followUserlocation prop is set to true, no matter what.
Notes / preliminary analysis
I did some testing, version by version since beta 76, up to beta 80, and then, lastly, using version 10.0.4.
In beta 76, everything was working fine and the followUserLocation was properly responding to the prop value changes.
Starting from beta 77, with this commit (integrated in beta 77), the followUserLocation updates were not causing the camera to move the map to user's current location.
Manually applying a patch that reverted the commit's changes, I was able to restore functionality.
Then I tried with a later version, specifically beta 80, and it was not working anymore.
Again, to restore the camera's functionality, I had to revert the changes in this commit for the ios/RCTMGL-v10/RCTMGLLocationModule.swift file.
Creating a patch that reverts these two code changes, I am now able to get back my application in a working state as expected.
I don't understand exactly why these two commits were needed, but they broke my application and I was wondering if it could be possible that there might be something wrong that should be fixed, so that the code in version 10.0.4 can keep its current implementation, but allowing a proper handling of my scenario.
I don't think I can provide a minimal reproduction component because of the complexity of the structure and the fact that there's the redux state that gets updated and it's really impossible for me to provide a minimum reproducible example.
Anyway I think it could be already a good insight knowing which changes that were integrated in beta 77 and beta 80 that broke my application.
Of course I am available for discussion on my specific use case, also privately, to try to sort this problem out.
Additional links and references
No response

hey why dont u use this
<MapboxGL.UserLocation
         onUpdate={loc => {
           if (followUser) {
             updateCamera(
               loc.coords.longitude,
               loc.coords.latitude,
               loc.coords.heading,
             );
           }
         }}
         requestsAlwaysUse
         showsUserHeadingIndicator
   />
const updateCamera = (lng: number, lat: number) => {
   camera.current?.flyTo([lng, lat]);
 };

thats how i did it but i not able to set heading for some reason i hope this helps u

@whiteHatCip Sorry but it's unlikely that we'll be able to fix the issue without being able to reproduce it.


Add a GCM Playground diagram and link to the DevByte video.

This CL contains improvements to the README.md file.

Can you squash into a single commit (e.g. "Add link to video and diagram to readme") ?

ok will do


Explore URL-RegExp without https://

URL-RegExp with https://  #17 Already discussed, Simple and efficient
https?:\/\/[\w-]+\.[a-z0-9\/:%_+.,#?!@&=-]+

Explore URL-RegExp without https://  quite complicated
https://regex101.com/r/IPa0py/2
(?:https?:\/\/)?(?<!@)\b[\w-.]+\.(?!exe|7z)[a-zA-Z][a-zA-Z0-9/:%_+.,#?!@&=-]+
It's not perfect yet,
For more information, you can see like 👇
https://greasyfork.org/scripts/342
https://github.com/lkytal/GM/blob/master/linkMix.user.js

In fact, you can let users to customize the URL-RegExp. add URL-RegExp input option👇
chrome-extension://kgnfciolbjojfdbbelbdbhhocjmhenep/settings.html

Thanks for the info, as you mention creating a regex that correctly identifies a url without a scheme (http, https, ftp, etc.) is quite difficult. I will look into the resources provided to see if I can get one that works well. The only issue is false identification of urls, where the regex identifies something that is not a url.


Add custom storefront headers

Description
Add new custom headers for storefront API calls. See Issue #660
Additional context
Before submitting the PR, please make sure you do the following:

[x] Read the Contributing Guidelines
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
[x] Update docs in this repository according to your change
[x] Run yarn changeset add if this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning

Yeah, I think so.


Feature requests

Hi!
At the beginning - thank you for creating this. Excalibar looks like another interesting bar alternative.
I have few suggestions:

allow "tasks" to show only active window title, add option to take all free bar space,
allow "click" module to show output of other plugin.

Nice day!

I'd like to add the option to choose whether primary or  secondary montitor as output and to be able to put it on the bottom instead of top. A short documentation on cli would leave me feeling less confused :)
looks very neat though. Just not applicable at this point to me. I'll leave it installled and will watch out for updates!

@tsaber  maybe it would be better to create separate issue? You have valuable points and this way it would be easier for author to keep track of it.


What do we do without or to help Sébastien?

This is a difficult text to write, so apologies if I get the tone wrong, my intentions are only positive and I'm writing this because I really want to see poetry succeed.
So, since December 2018, @sdispater has been really quiet, as can be seen on his github timeline. I hope he's okay; I've tried contacting Sébastien by email, twitter and on the discord channel, even side-channel pinging on an issue he replied to but to no response. There is some activity on GitHub so I'm hopeful that Sébastien is still around, but has anyone had any contact with him?
In the meantime, what can and/or should we poetry users do to help?
@sdispater - if you read this, what would you like to have happen?
It's amazing the amount of energy Sébastien has put into this project, but how do we grow this project so he can safely take a break without the project dying?
There's a potentially breaking change coming from pip soon, so I guess we'll find out one way or another, soon enough :-S (See https://github.com/sdispater/poetry/issues/826 for the poetry side of this)

I'm watching this repository and it seems to me that @sdispater is still quite active here :slightly_smiling_face: I remember seeing him close a lot of issues one or two weeks ago (some spring cleaning I guess?)

Thanks for asking about the state of the project and myself, I really appreciate it.
Just so everyone knows: I am alive and well and Poetry has not been abandoned in any way 🙂
However, I started a new job recently which gives me less time to work on Poetry or any other of my projects for that matter. I know it might seem like the activity has drastically dropped down, which it has, but this is also due to the fact that I worked pretty much full time on it for months (from February 2018 until December 2018). I am still active (see #908 for instance) and the 1.0 is still planned (here is the roadmap: https://github.com/sdispater/poetry/projects/1)
Now, I know this is a problem and some issues need to be addressed, and I also know that I can't do it alone anymore for the reasons mentioned above.
I plan on moving the repository to an organization (https://github.com/python-poetry) to make it easier to add collaborators to the project and eventually extract sections of the codebase into individual packages.
For the time being, if anyone is interested in helping the project, issue triage and bug fixes are the more pressing matter, feel free to reach out to me and we'll move from there.
I want to reiterate: Poetry is still alive. This is a project I deeply care about and I'll make sure that it gets the attention and care it deserves.

@sdispater - how about treating this bug as "fixed" when the repo is moved to the new org and/or there's at least one other maintainer who can merge commits and do releases?

@sdispater Are you planning to do something similar about/with pendulum? That library is excellent but also needs a similar amount of love to keep going.

Hi everyone 👋 I'm one of the maintainers that volunteered to help Sebastién with triaging issues. You can ping me as panyang on the Discord server. I will pin this issue to the top so that people who are interested in contributing can see this thread and can contact us.

Hi @stephsamson and thanks for your effort. I'm very optimistic about future of this project but there's lots of bugs to fix. Please contact me if there's anything I can do to help with that. Maybe we should start with tagging the top priority issues and PRs to focus on it? And also discord invite link from OP seems to be expired.

Working discord server invite link: https://discordapp.com/invite/awxPgve

@sdispater I would like to help.

Can we maybe have a Sponsor link right on GitHub?
Like some repos feature?

I'm now helping as a maintainer.  It'll take me a while to get familiar with the codebase and the problem space. Hopefully we'll get to the point where bug fixes are quickly merged in.
As a start I've gone through and tagged all the pull requests and briefly looked at them all.  For now I'll be prioritizing pull requests with bugs.   After that I'll tag the open issues and prioritize fixing the bugs.
Putting :+1: on important pull requests and issues would help us know which ones are important to the community (as we can sort by that).

@brycedrennan are you active in the discord? what's your handle?

@sztomi I'm not but I suppose I should be.  My time is limited, so until I can get through the open bugs it doesn't feel like a priority.

Fair enough. Let me know if I can help.

@brycedrennan @stephsamson I think it would be more helpful to prioritize Pull Request over issues because they are one-step further. Triaging issues is easier and we can get more volunteers to do that.

@FranklinYu Yes that's how we're currently prioritizing: pull requests for bugs are highest priority.

@sdispater / @brycedrennan / @stephsamson - is the stale bot really a productive thing to add to this project? I now have about 5 issues where I'm going to have to periodically go through and say "yes, nothing has changed, this is still an issue". All that's going to do is create noise on the issue tracker.
https://github.com/sdispater/poetry/issues/969#issuecomment-475524940 gives a pretty clear set of criteria for this issue to be considered resolved, I can't see how marking it stale before that is helpful.

I think the stale bot is useful, but some issues should have a label that makes stalebot ignore them :)

Is there such a thing?

Yes, but should be configured there's an option called exemptLabels, see https://github.com/apps/stale

A stalebot isn't my first choice but I defer to @sdispater since it's his project and he has put the most time into managing issues.

The reasoning behind the introduction of a stale bot is that we just can't go over a backlog of more than 400 issues with the limited number of maintainers. So it's easier to mark them as stale and asking for people originally reporting the issue if it's still relevant. This is especially true since there has been a lot of improvements in the 1.0.0 release (or prereleases) and a lot of them have already been treated.
It gives a better visibility for us and we can actually respond when a stale issue is updated.
Note that it's likely a temporary thing to clean up the backlog a bit before the 1.0 release.
Also, any issue or pull request tracked in a project and/or milestone will not be marked as stale since it means it has been acknowledged and it will eventually be worked on.

I think we can consider this "done" now :-)


Lookout Update package-lock.json to lockfileversion v2

LGTM.  I'll approve once I see if the circle ci integration tests pass.


Bootstrap Modal how to auto render the fullcalendar?

Hi all,
There is one project to use bootstrap modal to render the fullcalendar, when the modal show, but the fullcalendar cannot auto to render, and need manual to click the button text，pls kindly how to set up the fullcalendar auto to render once the modal show, thks.

below is screenshot.

full callendar is ok man :+1:

This could help you.

@Lucifer0601 you still have that issue ? If you resolved it or if you have no further questions please close the ticket.


x-for semicolon

When using the new release which formats Alpine, there is a loose semicolon added before x-for attribute values:
<template x-for="(month, index) in months"> is converted to <template x-for=";(month, index) in months">
Check out the date-time-picker.blade.php in Filament v3 for this example.
Thanks for the new feature BTW!

Thanks, John!


Dev fernando

The branch was updated with the changes in master branch and adapted with the features for Melanoma Tumorvolume dataset. Special features for the dataset are stored in the server for this task

I deleted unnecessary files for the master branch, the config_default was set to default values


Release 1.3.14

Summary | Résumé

#807
#808
#806
#805

Closing because I hit the wrong button and branched off a feature branch instead of main 🤦


Any way to retain the ALT seq?

Hi Team:
Thank you for develop this great tool
I was wondering are there any ways to retain the ALT seq, because I want to save it in the resulting consensus VCF files for transposable element calling?
I do not know about perl, but perhaps deleting some lines of your code could do this？
Thanks

Hi,
I could make this adjustment, which tools are you using for the SV calling?

@ndierckx
Oh Hi and thank you for your reply!
I am using the Sniffles2, CuteSV and SVIM for combination.
Mark: Sniffles2, but not Sniffles.
Thanks for your help, and your journal was also the best benchmarking work I ve seen, really helpful!
RL

The Perl really kills me hahaha^_^

I don't have my old data anymore, so could you send me those 3 vcf files, so I can test it. Will be quicker than running everything again, not into SV detection at the moment so.. You can also send to my mail nicolasdierckxsensathotmail.com

@ndierckx
Thank yo so much, I am sending you in!

Sorry for the delay, forgot to put it online, version 2.3 gives the REF and ALT sequence


CloudCredential is not created when using a custom Docker Machine Driver.

Setup

Rancher version:  2.6.8
Browser type & version: Chrome

Describe the bug
CloudCredential is not created when using a custom Docker Machine Driver.
To Reproduce

Install ProxmoxVE Machine Driver : https://github.com/lnxbil/docker-machine-driver-proxmox-ve
Create Cloud Credential
But not created.

Result
Expected Result

Screenshots

It returns 201 as response to POST, but Response Body is null.
Additional context

There are no logs related to the rancher pod.

Pushing to Q4 but we need to understand how much of this is a Rancher issue. Research required.

The issue is that the proxmox node driver does not support a cloud credential (the spec.addCloudCredential property on the node driver is false).
We use this to prevent a user from creating a cloud credential for that driver type, but in the cluster creation process, we do not - we assume all cluster providers need credentials, so we show the UI for creating a credential as part of the flow. the backend API does return 201 (this is a bug and it should return an error status code) - but the credential does not get created.
We need to update the RKE2 cluster creation flow to skip credential creation based on the same criteria it uses to determine that you can/can't create one via the Cloud Credentials page.

I reproduced the issue on Rancher v2.7.9
Creating a new cluster using the machine driver the UI shows the Create Credential form.
On Rancher v2.9.0 this isn't reproducible, the cluster create workflow goes straight to filling the cluster resources details. Without errors on the Network logs.


tooltip of LHN elements is WAY OFF for longer emails

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

open any chat
scroll through LHN to find longer emails
hover over the names and observe the tooltip

Expected Result:
tootltip is rightwards in the main chat
Actual Result:
tootltip should be right above the element
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.33-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/2c963ece-a631-44ed-a700-d39f84efc53a
Expensify/Expensify Issue URL:
Issue reported by: @chiragxarora
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686989358411139
View all open jobs on GitHub

Dupe of https://github.com/Expensify/App/issues/21105

This issue is still reproducible and reported in channel.
https://expensify.slack.com/archives/C049HHMV9SM/p1688368904317509


cannot format with offset clause

with temp as (
  select array<int64>[1, 2] arr
)

select *
from temp, temp.arr with offset
;

https://github.com/kitta65/bq2cst/commit/df21cd9c4048bc86d801fb75f81354ece910cf7d


fix: Green dot doesn't appear automatically when assigning task to self repeatedly

Details

Green dot doesn't appear automatically when assigning task to self repeatedly
Fixed Issues

$ https://github.com/Expensify/App/issues/22149
PROPOSAL: https://github.com/Expensify/App/issues/22149#issuecomment-1621386962
Tests

Create a task with no assignee
Open the task report
Set the assignee to a random person
Set yourself as the assignee
Verify that a green dot appears
Set assignee to someone else
Verify that a green dot disappears

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Create a task with no assignee
Open the task report
Set the assignee to a random person
Set yourself as the assignee
Verify that a green dot appears
Set assignee to someone else
Verify that a green dot disappears

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/129500732/6004b4e1-5e9b-407d-935d-625e6f32a361

Mobile Web - Chrome
https://github.com/Expensify/App/assets/129500732/891c8cb5-fa06-4fc0-83b9-1c1d6bf685f6

Mobile Web - Safari
https://github.com/Expensify/App/assets/129500732/19dea09d-715d-4856-980f-22534df4b67e

Desktop
https://github.com/Expensify/App/assets/129500732/fbdb9e94-f178-4e46-821c-06d667207328

iOS
https://github.com/Expensify/App/assets/129500732/eae4733b-af22-4719-894a-ef1c19c00c1c

Android
https://github.com/Expensify/App/assets/129500732/30da889c-bf4c-433e-9274-9cf4b889754c

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Just tested it and it works well! Merging!

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.42-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.44-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅