feat!: contract creation metadata

What I did
implemented contract creation metadata. this improves upon get_creation_receipt by offloading the logic to query engine and also exposing deploy block, deployer and factory besides the receipt.
this pull request implements the needed logic with two query providers:

otterscan (currently under geth query provider), which takes around 300ms
default query engine, which takes around 5.5s https://github.com/ApeWorX/ape/pull/2001/commits/0460d718e0f7da97b166e4d2c0188919495ba234

the default query implementation is also significantly improved, as it now can detect deployments from factories.
the ContractCreationQuery is demoted from block query to base query, as now doesn't accept the block range arguments. its return type has also changed to ContractCreation. we are forced to return an iterator by QueryAPI.perform_query, but maybe we should relax this requirement where an iterator doesn't make sense and a single value is returned.
as this query provides superior information and accuracy, it supplants get_creation_receipt, so i have removed duplicate methods related to them, namely:

chain.provider.get_contract_creation_receipts
chain.provider.ots_get_contract_creator
chain.provider._get_contract_creation_receipt
chain.contracts.get_creation_receipt
ContractInstance.receipt - available dynamically as ContractInstance.creation.receipt

instead, this pull request exposes the expanded deployment metadata is placed under ContractInstance.creation property, so you can do Contract(addr).creation.block and so on.
How I did it
How to verify it
from ape.api.query import ContractCreationQuery

query = ContractCreationQuery(columns=['*'], contract='0x1d42064Fc4Beb5F8aAF85F4617AE8b3b5B8Bd801')

# implemented in 3 query engines

next(chain.query_manager.query(query, engine_to_use='geth'))
# ContractCreation(txn_hash='0x37d8f4b1b371fde9e4b1942588d16a1cbf424b7c66e731ec915aca785ca2efcf', block=12369739, deployer='0x11E4857Bb9993a50c685A79AFad4E6F65D518DDa', factory='0x1F98431c8aD98523631AE4a59f267346ea31F984')

next(chain.query_manager.query(query, engine_to_use='__default__'))
# ContractCreation(txn_hash='0x37d8f4b1b371fde9e4b1942588d16a1cbf424b7c66e731ec915aca785ca2efcf', block=12369739, deployer='0x11E4857Bb9993a50c685A79AFad4E6F65D518DDa', factory='0x1F98431c8aD98523631AE4a59f267346ea31F984')

# NOTE etherscan query engine doesn't return factory address yet
# i reached out to them about this
next(chain.query_manager.query(query, engine_to_use='etherscan'))
# ContractCreation(txn_hash='0x37d8f4b1b371fde9e4b1942588d16a1cbf424b7c66e731ec915aca785ca2efcf', block=12369739, deployer='0x11E4857Bb9993a50c685A79AFad4E6F65D518DDa', factory=None)

# easily access the creation metadata in ContractInstance.
# this one is cached in retrieved almost instantly on later invocations.
Contract('0x1d42064Fc4Beb5F8aAF85F4617AE8b3b5B8Bd801').creation
# ContractCreation(txn_hash='0x37d8f4b1b371fde9e4b1942588d16a1cbf424b7c66e731ec915aca785ca2efcf', block=12369739, deployer='0x11E4857Bb9993a50c685A79AFad4E6F65D518DDa', factory='0x1F98431c8aD98523631AE4a59f267346ea31F984')

Checklist

[x] update etherscan query provider api https://github.com/ApeWorX/ape-etherscan/pull/124
[x] All changes are completed
[ ] New test cases have been added
[ ] Documentation has been updated

I sense something unusual with the mac OS runners right now. I am re-running an Ubuntu to see if that is successful as I investigate.


Create matt_nicholson.md

I wasn't able to test locally -- I had the following error when I tried to run bundle install
> bundle install
[!] There was an error parsing `Gemfile`: There are no gemspecs  at <local path> Bundler cannot continue.

 #  from <local path>/columnlab.github.io/Gemfile:2
 #  -------------------------------------------
 #  source "https://rubygems.org"
 >  gemspec #  source "https://rubygems.org"
 #  -------------------------------------------

Also go a similar error when I tried bundle exec jekyll liveserve
> bundle exec jekyll liveserve
[!] There was an error parsing `Gemfile`: There are no gemspecs  at <local path> Bundler cannot continue.

 #  from <local path>/columnlab.github.io/Gemfile:2
 #  -------------------------------------------
 #  source "https://rubygems.org"
 >  gemspec #  source "https://rubygems.org"
 #  -------------------------------------------


feat: bump phosphor-icons

Bumped phosphor-icons/core to the newest version
Thanks for your work with this library :)

Closed because tests weren't passing, but looks like it might be a configuration issue on my end because the build directory is created correctly.
I'm reopening this. Hopefully tests pass on your end.


added copy function

Now users can copy the color.
And paste it where ever they want.

Hey, @jatiinyadav I have made a change. So, Now users can copy the color to clipboard with just one click on the element.
Please merge this request.


New label for MessageSaved metric: isProcessed

In the method HandleNewMessages of Manager, the data of messages that are processed is set to nil. Then, the payload bytes of processed messages is effectively set to 0 bytes. When this is recorded with the stats collector defined, there is no good way to distinguish between messages that were processed and messages that weren't.
Later on, we would want to graph this data and be able to differentiate between the two. Therefore, I suggest adding a new boolean label, isProcessed, to the metric MessageSaved.
Some things to note with this change:

When messages that are fully processed will be saved, their corresponding payload bytes will be 0. At first look, that can look nonsense; but when we expose the stats (to Prometheus, for example), we can choose not to export the payload bytes of processed messages by utilizing this new label, and thus avoid unnecessary overhead.
When messages that were not fully processed will be saved, it will be some non-negative value. This can be meaningful, and can be exported to dashboards.
This change will break #258. Therefore, once #258 is merged, I will make sure to safely merge it in this PR, and then mark this PR as ready for review.
I couldn't manage to stress-test Fleetspeak enough to get messages that are processed and messages that are not processed in the same deployment (only separately). I tried changing the timeout value to 1, where all messages are fully processed in my case, and to 0, where all messages are not processed; if someone has some tips on testing this, I'd appreciate it. Apparently some messages of type ResourceUsage can go through with 0 timeout value. So I managed to get both processed and not processed messages in the same deployment.

Currently, we can keep count of messages processed/not processed using the calls made by liveService.processMessage. In particular, we call stats.MessageErrored if there is a failure, stats.MessageDropped and stats.MessageProcessed if we have too many pending messages for the service to begin processing any more. (BTW, adjusting the max_parallelism flag when setting up a service is probably the best way to get a mix of processed and unprocessed message - if you set it to, say, 1 make the accepting service a bit slow, there is a high chance that you'll get one processed and the rest unprocessed).
Given all that, I'm not sure what benefit there is changing MessageSaved, though maybe there is something. e.g., will this let us see if messages are slower to save when they include a payload?

Currently, we can keep count of messages processed/not processed using the calls made by liveService.processMessage. In particular, we call stats.MessageErrored if there is a failure, stats.MessageDropped if we have too many pending messages for the service to begin processing any more, and stats.MessageProcessed if everything worked. (BTW, adjusting the max_parallelism flag when setting up a service is probably the best way to get a mix of processed and unprocessed message - if you set it to, say, 1 make the accepting service a bit slow, there is a high chance that you'll get one processed and the rest dropped initially, then they'll come back and be tried again soon after).
Given all that, I'm not sure what benefit there is changing MessageSaved, though maybe there is something. e.g., will this let us see if messages are slower to save when they include a payload?

If I understand the code correctly, messages which are processed are recorded, while messages that are not processed are not recorded there (since there may be timeout during the execution of the method). Or is the timeout guaranteed to only finish after the execution of ProcessMessage?
And to make sure I understand your comment - are messages which are not processed within the timeout considered dropped messages? That is, # of dropped + # of processed = # of saved?
If so, then I agree that adding this label is not very useful (although MessageDropped does not collect as much information as MessageSaved does).
Adding this label does not give any new information we couldn't have accessed before, but a different way of filtering the data. I think your example is a good idea; If I understand it correctly, this can give us a look into the max payload processing capability of Fleetspeak.

I'm not sure which timeout you are thinking of, the 30 second context timeout?
The design intent is that every call to liveService.processMessage results in exactly one call to one of the 4 methods mentioned.
Drop functionality is DOS protection for whatever service we are handing the message off to - we don't start a new request if we already have too many requests outstanding, max_parallelism is the parameter which decides what 'too many' means. Messages which are dropped will be retried later. (Manager.ProcessMessage will be called at some point in the future, which in turn calls liveService.processMessage again.)
MessageProcessed is success, and indicates that we should not retry processing.
MessageFailed is failure, and it might or might not be a retryable error. If it is retryable, it will be retried some time later (same mechanism as for dropped messages). If the 30 second context timeout expires, that indicates that any blocking functions should return as soon as possible, aborting operations and returning a matching error if necessary. This error should be marked as retriable, as such errors are likely to be transient.

Ok I think I understand. In this case, would it make sense to somewhere record the payload size of messages that have been fully processed? Because if I understand correctly, right now HandleNewMessages records only the savedPayloadBytes of messages that were not fully processed.

stats.MessageIngested sees the message before it is processed and can therefore record the size as it is received. If you compare this to the bytes written, you can deduce the size of the messages processed before being written. The backlogged parameter indicates if the message was just received from a client (backlogged=false) or is a message that was dropped or temp-errored (backlogged=true).

At the moment, MessageIngested can see the message before it is processed but does not record its size. So, instead of adding the suggested label isProcessed, maybe instead we should consider adding a new label of size to MessageIngested, e.g. savedPayloadBytes int similar to the one that MessageSaved has?
We can indeed achieve it without adding this new label (i.e. by using the same logic presented here for calculating the size of the meesage within MessageIngested) but I think adding the new label can improve readability.

I do not think that adding redundant parameters (which is not the same a label) would improve readability. As soon as there are two places to get a bit of data, it introduces uncertainty about which to trust more.
Whatever MessageIngested wants to extract from the message proto, it can. Size, source service, destination service, and message type all come to mind, the last three of which could become prometheus labels. I think size has too many possible values to make a good prometheus label, instead it should be well bucketed.
If we think of other things to extract from a message, for a given collector, we can, without breaking other StatsCollector implementations. e.g. somehow logging when an outlier is found, etc.

I do not think that adding redundant parameters (which is not the same a label) would improve readability. As soon as there are two places to get a bit of data, it introduces uncertainty about which to trust more.

You're right, I confused label with parameter. Thanks for clearing it up!

Whatever MessageIngested wants to extract from the message proto, it can. Size, source service, destination service, and message type all come to mind, the last three of which could become prometheus labels. I think size has too many possible values to make a good prometheus label, instead it should be well bucketed.

Like MessageSaved, I meant to have size as a parameter, so that we can have graphs like bytes ingested per service, per source etc. This can be done without adding this parameter, by just calculating the size within MessageIngested, or it could be done by passing the size as a value (like it is passed to MessageSaved).

If we think of other things to extract from a message, for a given collector, we can, without breaking other StatsCollector implementations. e.g. somehow logging when an outlier is found, etc.

Just so I understand, which StatsCollector implementations can be broken? Do you mean implementations in tests?

Internally, Google has an implementation of StatsCollector. Any change to the StatsCollector interface will require us to update this implementation. This internal implementation's MessageIngested method does indeed pull out the data size, destination service name, message type, and message priority. If we decided to pull out more, we could, without changing the interface. Coming from this point of view, adding parameters to duplicate any of this functionality does not make sense to me.
As Fleetspeak is deployed more widely, other installations might write their own private StatsCollector in order to interface with their own internal monitoring system. So future changes to the interface will become more expensive.
MessageSaved, on the other hand, is much simpler for us, because it is meant to help us evaluate the database behavior and performance, and we care less about what exactly was save. That said, it has gained parameters over time and for consistency maybe it would make sense to change that interface to see the message that will be saved, reducing the number of parameters and again letting each collector pull out the labels and data that it chooses.

MessageSaved, on the other hand, is much simpler for us, because it is meant to help us evaluate the database behavior and performance, and we care less about what exactly was save. That said, it has gained parameters over time and for consistency maybe it would make sense to change that interface to see the message that will be saved, reducing the number of parameters and again letting each collector pull out the labels and data that it chooses.

Ben, do you think it'd make sense to pass the message object instead of a number of parameters for MessageProcessed, MessageErrored and MessageDropped as well? (see https://github.com/google/fleetspeak/blob/fd979027097f4f60c93ba18a9a965cb5eaa66154/fleetspeak/src/server/stats.go#L41)

Yes, I agree with the suggestion of altering the Message* methods to see the actual message in question, rather than information extracted from them - it is a little bit of churn and hasn't been a priority, but makes the interface more uniform and gives the stats collector more flexibility. The current variations are largely a result of history.

I'll take on this. I think this PR can be closed, as we won't add a new parameter to MessageSaved (but rather remove parameters from it, and possibly from other methods in the Collector interface as well).


Does not work if code contains ES6 syntax

The aliasify transform will fail if code contains ES6 syntax. So far, both usage of const and template strings cause issues. I will follow up with exact error message.

Also fails on export MyExport from MyPackage and fat-arrow functions

also fails when using pkgify. I think this is a problem with browserify-transform-tools

Yeah, likely this can be fixed just by upgrading falafel in browserify-transform-tools.  If someone wants to make a PR and try it out, I'm happy to merge it.

Yep, I tracked it down to an old verson of acron in falafel. Went in and manually updated to<EMAIL_ADDRESS>and all is well.

Um, yeah, I guess so.  -_-  At least I own browserify-transform-tools, so if node-falafel is fixed, it's easy to fix the others.
Although, this doesn't quite fix this perfectly, because browserify-transform-tools#makeRequireTransform is going to transform all the requires in your code, but I doubt it will nicely fix the imports.
As a workaround, you can add a Babel transform before you get to aliasify (so there won't be any ES6 code in what aliasify is transforming) but this only helps if you want something like Babel in your transform stack in the first place.

I'm already running babelify along with browserify (and aliasify + stringify), but for some reason the parse through BTT didn't seem to be helped by putting the babel step first in the transform chain  ¯_(ツ)_/¯
I'll just go ahead and go to falafel since that's the quickest fix.

Are there any updates regarding this issue?
I am running into the same problem.

Depends on an upstream update of benbria/browserify-transform-tools#24
For now, you can manually bump the versions in node_modules.

Hi @gunderson. How do you "bump the versions in node_modules" manually? Could you explain further the process? I don't get how to tell browserify to use<EMAIL_ADDRESS>Thanks.

@eightyfive Go into the node_modules folder and find the package.json file inside the alaisfy folder.
There you can change the old falafel dependency and update it.
Obviously this is an untested change and might break things? and also if you upgrade the package the manual override will be lost.

Hi, thx.
What I did is change the version manually in:
node_modules/browserify-transform-tools/package.json

I also did install<EMAIL_ADDRESS>Do I need to clear some npm cache so browserify-transform-tools grabs the v2 of falafel?
Because I still get the same error:
SyntaxError: Unexpected token (2:7) (while aliasify was processing...

Thanks for your help.

Should be fixed in v2.1.0.


[WFLY-19009] Remove Stage.RUNTIME uses of capability 'org.wildfly.legacy-security' in undertow subsystem

Issue: https://issues.redhat.com/browse/WFLY-19009
[WFLY-19009] Remove Stage.RUNTIME uses of capability 'org.wildfly.legacy-security' in undertow subsystem

Thanks @soul2zimate and @pferraro


Find a way to save class names when saving mesh

When you save a mesh with TexturedPhotogrammetryMesh.save_mesh and load it back in, you loose the class ID to name mapping. It would be nice to find a way to preserve it. Saving it as a metadata field in the mesh would be ideal, but I'm not sure that's something you can do. Alternatively, saving a sidecar file, probably .json or .yml, and providing an option to specify it when loading would be good.

Looking at the constants.py code, by example we use the .ply file format to save/load meshes. The ply file format doesn't support adding extra metadata, but saving the mesh to another file format, like .vtp, does allow adding metadata fields to the Polydata mesh. But the only metadata format accepted is a numpy array with a size that matches the number of points in the mesh, so some transformations are necessary but it would be doable. Would this be a solution worth pursuing, or would the sidecar file be more reasonable?

Thanks for looking into this. I don't think the alternative mesh format method is worth pursuing, especially since it sounds like even with that format, saving the correspondences between human readable names and integer IDs might not be super obvious to the user. It might be useful to automatically save the sidecar file in save_mesh here which isn't currently done.

What do you think?

The sidecar file definitely helps in regards to human readability and accessibility to the user. On that note, I will get started on adding this functionality to the save_mesh method. I'll assign this issue to myself as well.


⚠ Bofrost.lu has degraded performance

In e1d4c49, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1484 ms

Resolved: Bofrost.lu performance has improved in d880e7f after 6 minutes.


feat: implement globalThis.performance API

Description of changes
The Minimum Common Web Platform API is being considered at WinterCG.
I have implemented the following several APIs.

globalThis.performance.timeOrigin
globalThis.performance.now()

Checklist

[x] Created unit tests in tests/unit and/or in Rust for my feature if needed
[x] Ran make fix to format JS and apply Clippy auto fixes
[x] Made sure my code didn't add any additional warnings: make check
[x] Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks for the PR! Just a minor "enhancement" and we're good to go


Suggestion: Allow 'local' color theme changes

I often have multiple projects open in multiple instances of VSCode.  Using different color themes on each open instance is a very useful way to provide a visual clue as to which context (project) I'm in. At the moment VSCode will change the color theme simultaneously on all open instances whenever it is changed in one.  It would be desirable if there was a 'temporarily change scheme for just this instance' command that didn't affect other instances.

VSCode Version: Code 1.13.1 (379d2efb5539b09112c793d3d9a413017d736f89, 2017-06-14T18:21:47.485Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions:

Extension
Author
Version

Bookmarks
alefragnani
0.15.2

numbered-bookmarks
alefragnani
0.10.0

cpptools
ms-vscode
0.11.4

csharp
ms-vscode
1.10.0

PowerShell
ms-vscode
1.4.1

Steps to Reproduce:

@NeilMacMullen you can configure colors via workspace settings.

As @bpasero writes, the solution is to use different themes per workspace.


Github Automation

Aim

A script that allows user to automate github workflow

Details

This script allows user to completely automate github workflow. This script keeps track of changed files and generates a diff, then auto adds and commits(asks for a commit message) the changed files.

@avinashkranjan  Please assign me this issue

@avinashkranjan  Please assign me this issue

Sure Go ahead @antrikshmisri

Sure Go ahead @antrikshmisri


Create Localization template for 'dotnet new'

With the new dotnet new extensibility, it would be nice to have an ASP.NET Core template that is fully localizable.

cc @DamianEdwards

Why we didn't add starter template like what we have in the entropy repo

@hishamco that's essentially what we want in the template. Someone just has to do the work to wrap it in the structure that dotnet new uses (and make sure the content is appropriate).

Sure, but in which repo shall we add this template, perhaps I 'll contribute to this if it's not assigned to anyone 😄

@DamianEdwards where do you want this to live?

@Eilon can we just put it in the aspnet/Templates repo? As a new package?


Kubernetes Meetup

Please make sure to check the following boxes creating your pull request, thank you very much!

[x] Add Blog Header, including title, author, image, categories, tags, etc.
For example:
---
title: Your Great Blog Title
author: your_github_id
categories: project
tags:
  - python
  - padlocal
image: /assets/2021/02-your-blog-slug/teaser.jpg
---

One line bio

Your blog post content Your blog post content
Your blog post content Your blog post content
Your blog post content Your blog post content

It will be easier to start drafting your post by using a existing post file as your template, for example, this one

[x] Keep all filenames lowercase, and use - to connect words instead of space. e.g. 2017-10-06-wechat-pc-impactor.md instead of 2017-10-06-WeChat PC Impactor.md

[x] Embed video/pdf from YouTube/Bilibili/local (if there's any) by using {% include iframe.html src="URL_or_PATH" %}. (Learn more about how to embed file/url in the post by reading this blog post

[x] Save photo to local before publishing, to a folder named by ${MONTH}-${YOUR_BLOG_SLUG}/ under /assets/2021/ directory.

[x] Select a beautiful and meaningful teaser image for your blog

[x] Create your contributor profile (if you are a first time contributor)
For excample:

jekyll/_contributors/lijiarui.md

---
name: Jiarui LI (李佳芮)
site: https://lijiarui.github.io
bio: 句子互动创始人 & CEO，微软人工智能最具价值专家 (AI MVP)
avatar: /jekyll/assets/contributors/lijiarui/avatar.png
email<EMAIL_ADDRESS>twitter: https://weibo.com/u/2175505900
---

Here is the example file:

lijiarui.md: https://github.com/wechaty/wechaty.js.org/blob/master/jekyll/_contributors/lijiarui.md
It will shown like this on wechaty website: https://wechaty.js.org/contributors/lijiarui/

To learn more about the contribute guideline, visit: https://wechaty.js.org/docs/contributor-program/

Could you please explain why we should publish this post?
I can not see anything related to Wechaty in it.

Could you please explain why we should publish this post?
I can not see anything related to Wechaty in it except a few words about the blinder project.

Look here，https://github.com/wechaty/wechaty.js.org/pull/1180#issuecomment-895017786, I wrote the first one

Look here please,<https://github.com/wechaty/wechaty.js.org/issues/909>, I wrote the first one.

------------------ Original ------------------
From: "Huan (李卓桓)";
Date: 2021年8月9日(星期一) 下午3:44
To: "wechaty/wechaty.js.org";
Cc: "gangena"; "Author";
Subject: Re: [wechaty/wechaty.js.org] Kubernetes Meetup (#1180)

Could you please explain why we should publish this post?
I can not see anything related to Wechaty in it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.


vimPlugins.dhall-vim: init at 2018-06-04

Motivation for this change
dhall syntax highlighting for Vim.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Success on x86_64-darwin (full log)
Attempted: vimPlugins.dhall-vim
Partial log (click to expand)
unpacking source archive /nix/store/yf90q7wi70153gylm368yzj9vfzh3gj3-dhall-vim-290c2ec
source root is dhall-vim-290c2ec
patching sources
configuring
building
installing
post-installation fixup
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/7j6ng0zlpdj82pj64wwza43jjq5a433z-vimplugin-dhall-vim-2018-06-04
/nix/store/7j6ng0zlpdj82pj64wwza43jjq5a433z-vimplugin-dhall-vim-2018-06-04

Success on aarch64-linux (full log)
Attempted: vimPlugins.dhall-vim
Partial log (click to expand)
updateAutotoolsGnuConfigScriptsPhase
configuring
building
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/92ksjwwc649n702jxiw3yh7xcxhznq9h-vimplugin-dhall-vim-2018-06-04
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/92ksjwwc649n702jxiw3yh7xcxhznq9h-vimplugin-dhall-vim-2018-06-04
checking for references to /build in /nix/store/92ksjwwc649n702jxiw3yh7xcxhznq9h-vimplugin-dhall-vim-2018-06-04...
/nix/store/92ksjwwc649n702jxiw3yh7xcxhznq9h-vimplugin-dhall-vim-2018-06-04

Success on x86_64-linux (full log)
Attempted: vimPlugins.dhall-vim
Partial log (click to expand)
patching sources
configuring
building
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/snlj1rcgg8zkcppvdjxgfd9q17zw57wg-vimplugin-dhall-vim-2018-06-04
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/snlj1rcgg8zkcppvdjxgfd9q17zw57wg-vimplugin-dhall-vim-2018-06-04
checking for references to /build in /nix/store/snlj1rcgg8zkcppvdjxgfd9q17zw57wg-vimplugin-dhall-vim-2018-06-04...
/nix/store/snlj1rcgg8zkcppvdjxgfd9q17zw57wg-vimplugin-dhall-vim-2018-06-04


Endwalker Support

Does not work on Endwalker npc's

Just played a round with Aiglephine and it works fine for me.

Which plugin version are you on? (expected: <IP_ADDRESS>)
Is it failing for all new npcs or just some?
What are the reported card/npc numbers in plugin's status window (/triadbuddy) (expected: 347 cards, 108 npcs)
What is your client language? It's matching stuff based on name so it's possible that some language data is broken.

Just in case: Dalamud is currently disabled and access to plugins requires a few additional steps. Please refer to their Discord server for more information.
If tool shows up on old areas correctly and doesn't work on new ones, please answer questions from list above. Can't help without additional info.

closing for now due to lack of repro / additional info.


include ASF disclaimer

Coverage remained the same at 94.795% when pulling 6d48deaa3a0a95104da512eed156bf6fc00e7b82 on lijasonvip:bo into 75b112e29bb1a5f36d92776af0109a6bab679721 on apache:master.


Test for permission to serve directories

Detect if we don't have permission to read from a certain directory and show an error

With the way I built the filesystem, it always combines the input path and the base path. Should we just add an error for when user requests something like
http://localhost:8887/../../somepath

They shouldn't be able to select a directory that they don't have read
access from, because they need read access to be able to go in and select
it. The web server is also run with the same privileges so the server would
get an unauthorized error. Should I try to handle this error? Is there more
to this that I am missing?

Does Windows already prevent you from picking a directory you don't have access to?
Does the web server already handle read permission by returning a 403?

Windows does not block selecting the directory, but blocks reading it. The server does not check for read permissions

What happens when the server tries to serve a file it doesn't have permission to read?

Fs returns an error and then renders the 404 page

Could we add a case for a fs permission error and make that a 403 instead?

Possibly, I'll take a look at that when I get a chance


Fixed incorrect offset of snap to floor

AABB for collision geometry was being calculated based on parent nodes transform without consideration for collision geometries translation.
Also hopefully clarified logic for selecting starting point for ray cast
Bugsquad edit: This closes #44282.

Thanks for opening a pull request!
Please amend the commit to use a human-readable commit message. This way, people reading the Git log can easily figure out what's going on.

For the reference, this further refactors code added in #44234.

For the reference, this further refactors code added in #44234.

Thanks!

Thanks!

Cherry-picked for 3.2.4.

Cherry-picked for 3.2.4.


Bump sqlalchemy dependency

Related to https://github.com/apache/incubator-superset/issues/6977

Codecov Report

Merging #7000 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7000   +/-   ##
=======================================
  Coverage   64.46%   64.46%
=======================================
  Files         421      421
  Lines       20521    20521
  Branches     2245     2245
=======================================
  Hits        13229    13229
  Misses       7165     7165
  Partials      127      127

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83b48a9...3d5e92f. Read the comment docs.

Addressed the comments.


Error parsing JSON: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

I have everything set up correctly, added 5$ worth credit to my OpenAI account but I still keep getting this error. I don't believe I have exceeded my current quota, could someone shed some light on this? Thanks.

This does not seem to be an error from this repository. Kindly check your OpenAI account if it actually shows the credits... If yes, then you may try generating a new key

Hi, this looks like an openai rate limit so I'll go ahead and close this issue.


proxy protcol follow up

From #1032
@hennna FWIW, I'm not a huge fan of this type of error checking of the C++ runtime functions by catching std exceptions. It can be really unclear what throws and why, and we might catch something that we don't intend. It's not a huge deal, but in this case, would rather see us just verify things using standard if length checks, and then using StringUtil::atoul which is a lot faster than the standard version. Not a big deal at all but we might consider a follow up. cc @htuch

@mattklein123 question on what you mean by "using standard if length checks"?

I just mean that for this code:
uint32_t remote_port, destination_port;
  try {
    remote_port = std::stoul(line_parts[4]);
    destination_port = std::stoul(line_parts[5]);
    // Check that TCP port value is in range [0, 65535].
    if (remote_port > 65535 || destination_port > 65535) {
      throw std::out_of_range("failed to read proxy protocol");
    }
  } catch (const std::invalid_argument& ia) {
    throw EnvoyException(ia.what());
  } catch (const std::out_of_range& ex) {
    throw EnvoyException(ex.what());
  }

I would check the cases that you think would/should cause an invalid_argument/out_of_range exception directly, and then let the process crash if some other invariant is not met. Basically, with this type of code and the way the std lib is written, you may be masking problems that you don't know you had.

Aren't the exceptions documented at http://en.cppreference.com/w/cpp/string/basic_string/stoul?

They are, but IMO it's very easy to accidentally mask behavior that "shouldn't happen" when catching the std exceptions (for example if line_parts has been accessed with at() which could also throw an exception if the logic was wrong above). This might not be the case here, and you can feel free to ignore, as it's really just a style preference. (However StringUtil::atoul will be faster as it doesn't attempt to process white space or minus).
I don't feel that strongly about this, so feel free to close if you don't agree.

I'll close for now and revisit when we add more functionality to the proxy protocol code.


Can not add css comments at the end

This compiles:
    let backdrop = css!(
        r#"
  position: fixed; /* Stay in place */
  z-index: 1; /* Sit on top */
  width: 100%; /* Full width */
  height: 100%;
        "#);

This doesn't:
    let backdrop = css!(
        r#"
  position: fixed; /* Stay in place */
  z-index: 1; /* Sit on top */
  width: 100%; /* Full width */
  height: 100%; /* Full height */
        "#);

compiler output:
error: Failed to Parse CSS, due to:
0: at line 5, in Many0:
  height: 100%; /* Full height */
                ^

1: at line 1, in Trimmed:

^

2: at line 1, in StyleSheet:

^

  --> src\main.rs:12:9
   |
12 | /         r#"
13 | |   position: fixed; /* Stay in place */
14 | |   z-index: 1; /* Sit on top */
15 | |   width: 100%; /* Full width */
16 | |   height: 100%; /* Full height */
17 | |         "#);
   | |__________^

Thanks for the report.
Preliminary analysis makes me think the parser see this something like this:
  position: fixed; /* Stay in place */
                   └─────────────────┐
┌────────────────────────────────────┘
│ z-index: 1; /* Sit on top */
└───────────┘ └──────────────┐
┌────────────────────────────┘
│ width: 100%; /* Full width */
└────────────┘ └──────────────┐
┌─────────────────────────────┘
│ height: 100%; /* Full height */
└─────────────┘ ^^^^^^^^^^^^^^^^^

I.e. the comments are recognized as part of the following attribute name, and leaves the rest dangling.
https://github.com/futursolo/stylist-rs/blob/master/packages/stylist-core/src/parser.rs#L140
I think the best course of action would be to completely disregard comments anywhere, compared to selectively as done now. I'm not 100% sure how this can be done in nom, but will dig into it.

Tentative bug fix lives @ https://github.com/WorldSEnder/stylist/commit/6833f1c7017bd44719fc7399c2a65225ef6c2c8c I do want to slim the changes down a bit before creating the PR.


Full expression support

@httpsOmkar yes, contributions are welcome. This one is quite complex (that's why it is not yet implemented 😉
However, to make it work you'll need to create

Generator from camel-yaml-dsl.json to CamelModel, CamelAPI, CamelMetadata for all 21 expression languages
Implement UI builder new Models in DslProperties
Adjust CamelYaml to read/write all types (implicit/explicit/full expressions) correctly

Originally posted by @mgubaidullin in https://github.com/apache/camel-karavan/issues/124#issuecomment-979217275

Done


cant build for bench

Hello, i'm trying build ur tiedot:
bsbak@bsbak:~/go/src/github.com/HouzuoGuo/tiedot$ go build main.go
./main.go:80: undefined: benchSize
./main.go:81: undefined: benchCleanup
./main.go:144: undefined: embeddedExample
./main.go:147: undefined: benchmark
./main.go:149: undefined: benchmark2
what is that? was look in code, all is fine, but i why cant build?

Try go build without main

Try go build without main
works! Why with main.go not work? What difference?

go build main.go only compiles main.go. go build compiles everything it finds.


HTTP Functions Refactor

Featuring Type
Function
So, what is it about?
I believe that currently the attention that has been given to HTTP functions has been null.
There are some features that could be implemented for this area, and not just have $httpRequest and $jsonRequest.

what if I want to know which type of content type the API return? (currently implemented on $httpRequest but I started feeling that is not the best idea) / what if I want to know the status code of the API response / etc, etc...

The idea is: "give you more control over the requests you can make with your client".
I would like to do this work myself, but I would like to know if it will be accepted.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Seeing this I absolutely agree it can be improved.
If any suggestions, please feel free to make a Pull Request and show your ideas and it can be further discussed.


runtime/trace: incorrect WithRegion usage in code snippet

What version of Go are you using (go version)?

1.11

Does this issue reproduce with the latest release?

yes (go1.11)

What did you do?

Read code snippet in docs for https://golang.org/pkg/runtime/trace/#NewTask

What did you expect to see?
...
trace.WithRegion(ctx, "preparation", prepWork)
// preparation of the task
go func() {  // continue processing the task in a separate goroutine.
    defer task.End()
    trace.WithRegion(ctx, "remaining", remainingWork)
}()

What did you see instead?
...
trace.WithRegion(ctx, prepWork)
// preparation of the task
go func() {  // continue processing the task in a separate goroutine.
    defer task.End()
    trace.WithRegion(ctx, remainingWork)
}

The trace.WithRegion requires 3 parameters (ctx, regionType, fn) however in the code snippet for trace.NewTask, it seems to be missing some parameter.
It depends what prepWork and remainingWork represent here, but if they represent function (fn parameter) then this code snippet is misisng regionType parameter.
The code snippet is also missing () for the go func() ... call.

I'll take this


The SqueezeNet deploy.caffemodel files have all 0.0 weight and bias data

The comments on the SqueezeNet models indicate that the .caffemodel files include the training data.  The deploy.caffemodel files' weights and biases are 0.0.  Is this intentional?  It wasn't evident from the comments.  I see the squeezenet_v1.1.caffemodel does have non-zero weights and biases.
Look at any of the parameter data
import caffe
import numpy
nnet = caffe.Net("deploy.prototxt",1, weights= "deploy.caffemodel")
net.params['conv1'][0].data[...] # weights
net.params['conv1'][1].data[...] # biases

The train_val.prototxt does contain appropriate weights and biases,  which solves my problem.  I'll close this.


Update canister-sdk 0.18 -> 0.19

This PR relies on https://github.com/bitfinity-network/canister-sdk/pull/225 . Please, approve that PR before this one.
Issue ticket
Issue ticket link: <>
Checklist before requesting a review
Code conventions

[ ] I have performed a self-review of my code
[ ] Every new function is documented
[ ] Object names are auto explicative

Security

[ ] The PR does not break APIs backward compatibility
[ ] The PR does not break the stable storage backward compatibility

Testing

[ ] Every function is properly unit tested
[ ] I have added integration tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] IC endpoints are always tested through the canister_call! macro

@itsyaasir @ufoscout I'm not sure why CI is failing. I don't thinks it's related to this update....


Dependency upgrades

This upgrades dependent libraries to their latest versions

@matthewfarwell

Codecov Report

Merging #335 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #335   +/-   ##
=====================================
  Coverage       0%     0%
=====================================
  Files          62     62
  Lines        1495   1495
  Branches      146    146
=====================================
  Misses       1495   1495

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec14399...21ab9f0. Read the comment docs.

Codecov Report

Merging #335 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #335   +/-   ##
=====================================
  Coverage       0%     0%
=====================================
  Files          62     62
  Lines        1495   1495
  Branches      146    146
=====================================
  Misses       1495   1495

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec14399...21ab9f0. Read the comment docs.

What is this waiting on?

@niebloomj - this project is no longer maintained, I've been trying to maintain it on a separate fork here https://github.com/beautiful-scala/scalastyle.
See https://github.com/scalastyle/scalastyle/issues/327 for more context.

I see it and started using it in my project. Are you looking for another maintainer? Thanks.

Yes @niebloomj, having some help would be great.

scala-steward can take care of dependency upgrades ;-)


Add test for issue #136 (currently fails)

This adds a test for issue #136 (but doesn't fix the bug yet).

Hi @shamrin, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

Since this pull request does not solve the issue yet, the baselines generated may not be correct. This test case will be added when the issue is solved.  Thanks


M3-2126 images search bar

Use Reduxed images for the search bar and search landing page

Coverage decreased (-0.004%) to 33.375% when pulling 2dfa02430de59b9eab1176cb5e96e01e0279ad78 on Jskobos:M3-2126-images-search-bar into f21fd1304a9f669f8dbe853642141006fbed6fe6 on linode:feature/images-in-state.


Protocol 1: Sample intake.

[ ] Intake barcodes (this is protocol 1a below)
[ ] Samples placed in 95C oven for 30min (in LIMS so we record time)
[ ] Samples removed from oven (record time)
[ ] Racks centrifuged at 200g for 20 seconds

when the 96-well plates come out of the oven, how do we remember which goes in which quadrant?

Workflow idea: put stickers like this https://www.amazon.com/Round-Coding-Circle-Sticker-Labels/dp/B07Q4X9GWX on each of the plates. So each of 4 384-well plate types have a color. And then the 4 96-well plates that will go in that 384-well plate have a number. So the 4 red stickers are labeled 1, 2, 3, 4, the 4 blue stickers are labeled 1, 2, 3, 4, ...
As each 96-well plate .csv is uploaded to the LIMS, the LIMS can say: "label red2". And then if there's a time lag before actual pipetting, that's ok.
The plates also have barcodes, but the above is a potential human-readable solution.
Can this be improved???


[BE Week] Add Ruff pre-commit hook

Motivation and Context

Ruff is a faster, more featureful reimplementation of flake8 in rust that also provides autofixes

How Has This Been Tested

Types of changes

[X] Docs change / refactoring / dependency upgrade
[X] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[X] My code follows the code style of this project.
[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have completed my CLA (see CONTRIBUTING)
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

Since rust does everything that autoflake, flake8, and isort do, but faster, should these three be removed from the toml file now?

@naokiyokoyama autoflake is redundant. Not all the flake8 rules are implemented in ruff yet, same with isort (although we may be using all the features in isort that ruff implements).


Added status property in user object

@swarajpure @sumitd94
I have added the Status property in User model.
Please review the PR!

@swarajpure
I have added the test cases for status property and worked on comments.
Please review the PR!

@swarajpure I have made the changes as you suggested. Please check!


adding player names to the game invite process

What's this PR do?

During the game creation process, sends the alpha messages which let her know the names of players she's invited to the game.
When a beta joins, a) sends that beta a message letting her know which players haven't joined yet, b) sends the alpha a message letting her know the name of the beta that's joined, who they're still waiting on, and whether she wants to begin the game, and c) sends a message to already-joined betas telling them who's joined, and who they're still waiting on.

It does this by:
During any state change (an alpha creating a game, a beta joining a game), it updates the necessary Mobile Commons user profiles with user name information and then sends the right messages.
Where should the reviewer start?
The meat is in playerNameHelpers.js, within createGameInviteAll and betaJoinNotifyAllPlayers. There have been minor changes to SGCompetitiveStoryController.js to make sure that even if a beta isn't given a first name when a game is created, her first name is stored as her phone number.
How should this be manually tested?
Use this Postman collection to test, perhaps with phone numbers you have access to. Create a game, ensure that the alpha gets a message with the names of the users she's invited, and when betas join, ensure that the proper betas get the right messages.
I've modified the Science Sleuth A/B testing game so that it supports this new feature. This postman collection creates a new game within that campaign.
todo: writing automated tests for this feature.
Any background context you want to provide?
Note that there are a few necessary things for this feature to work:

We need to add a notify_joined_betas_that_beta_has_joined OIP to the SMS game template. I'm also going to add that property to Intertwine.
We also need to make sure that the alpha_start_ask_oip and beta_wait messages have the proper liquid templating to display the text strings.

What are the relevant tickets?
Closes #326.
Questions:

notify_joined_betas_that_beta_has_joined is unwieldy--any suggestions for renaming?
Right now, the names of players are listed in a string as Tong, Michelle, Vikram. Should I add an & in there somewhere?
I haven't included any obscenity filters or character limitations on the name strings uploaded to Mobile Commons. Should I do so?

notify_beta_has_joined?
I'd leave the & out.
Nah. If it needs to be done, frontend validation on the webform will be an easier solution.

:+1:

Actually, not sure if this is you or not, I'm gonna do more testing, but I left my server running for a while without starting the game and got an error:
error: uncaughtException: Cannot read property 'game_started' of null

Umm and now I can't reproduce it. It was complaining about line 76 in logicGameStart.js
else if (doc.game_started !== true) {

where I assume doc was undefined. But because I can't repro my guess is I ended up deleting the game doc manually after I finished testing but the node server just kept running.
Sorry! Ignore me. :disappointed:


use logverification event structures

Draft
re: AB#9604

Naming comments will be addressed in a subsequent PR


Inconsistent JSON format for Active Targets List API

Summary
The data key in /upstreams/{name or id}/targets/active API response should always contain a list. But if the total number of active targets is 0, data contains an empty object instead of an empty list.
{
  "data": {},
  "total": 0
}

Thanks @vaibhav-sinha. This should be an easy fix :)


Parsing and writing of different value types

i.e. strings are written to the file with "" and numbers without and this makes accessing the Field-Names and Values a bit problematic atm

there's actually not a problem, the Package CsvHelper already takes care of this. I don't know what the customer did wrong here

I'll just add an Option to Wrap all Output-Values in Quotes (") for now. Later on i want to go over to use the Package CsvHelper for writing the CSV-Files as well


Allow t() to return falsy result instead of translation key or provide a way to add a fallback value

Is your feature request related to a problem? Please describe.
For Next.js 13 Metadata, I want to do the following:
export async function generateMetadata({ params: { locale }) {
  const t = await getTranslator(locale, "home")

  return {
    title: t("title"),
    openGraph: {
      title: t("seo.og.title") || t("seo.title") || t("title"),
    }
  }
}

Describe the solution you'd like
Either will do:

t.optional('home') that'd to return "" or other fals-y value. Similar to t.rich().
t('seo.og.title', null, t('seo.title', null, t('title'))), where the 3rd arguments is a fallback value.

Describe alternatives you've considered
As of now, I'm doing it with my customized version of the t() function:
export const t = async (locale: Locale, at: string, paths: Array<string>) => {
  const t = await getTranslator(locale, at)
  return t(paths.find((path: string) => !t(path).startsWith(`${at}.`)))
}

// usage
t(locale, "home", ["seo.og.title", "seo.title", "title"])

It works, but results in the pretty annoying, irrelevant error:

IntlError: MISSING_MESSAGE: Could not resolve seo.og.title in site.home.
at getFallbackFromErrorAndNotify (webpack-internal:///(rsc)/./node_modules/use-intl/dist/development/createIntl-dfba4462.js:131:23)
at translateBaseFn (webpack-internal:///(rsc)/./node_modules/use-intl/dist/development/createIntl-dfba4462.js:153:20)
at translateFn (webpack-internal:///(rsc)/./node_modules/use-intl/dist/development/createIntl-dfba4462.js:222:24)
at base (webpack-internal:///(rsc)/./node_modules/use-intl/dist/development/core.js:24:16)
at eval (webpack-internal:///(rsc)/./lib/i18n.ts:26:34)
at Array.find ()
at t (webpack-internal:///(rsc)/./lib/i18n.ts:26:20)
at async Promise.all (index 4)
at async localizedPageMetadata (webpack-internal:///(rsc)/./lib/seo.ts:44:82) {
code: 'MISSING_MESSAGE',
originalMessage: 'Could not resolve seo.tw.title in site.home.'
}

Thanks for the request, this seems to be a duplicate of https://github.com/amannn/next-intl/issues/88. I'll close this ticket in favor of the existing one.

Sure, sorry for the dupe

Is there currently a way to suppress the error tho?

Yep, please see the alternatives section in the linked issue.


Product site?

Every good projects wether it is small or big has its own website (atleast an github.io one) so why not championify. Its a great application and i think with a good webpage it could attract more people.
I can make the website just need you choose which branch/repo to put in (can create a seperate repository like Championify-site to keep the website or use a gh-pages branch in this repo).
:sweet_potato: :sweet_potato: :sweet_potato:

@surajmandalcell, I think @hollowsxd is just referring to the https://github.com/dustinblackman/Championify/ page with the readme and link to downloads.


Delete examples in extendr-api/examples?

Can we delete the examples in extendr-api/examples?
https://github.com/extendr/extendr/tree/master/extendr-api/examples/R
Most of them currently don't work (#100), and almost all cases are now covered in integration tests in extendrtests. And anything that isn't yet in extendrtests (ndarray code) should be moved there anyways.
The README should probably point to extendrtests rather than extendr-api/examples anyways.

I support this decision, I was thinking about opening this issue yesterday myself.
Those examples do not reflect the extendr way. But we should perhaps create a set of easy to use examples that people can install and test from R and put it in some 'examples' folder in the root of the repo.

I support this decision, I was thinking about opening this issue yesterday myself.
Those examples do not reflect the extendr way. But we should perhaps create a set of easy to use examples that people can install and test from R and put it in some 'examples' folder in the root of the repo.

We have a separate repo for examples, we just need to add some:
https://github.com/extendr/extendr-examples
We also have this:
https://github.com/extendr/helloextendr

We have a separate repo for examples, we just need to add some:
https://github.com/extendr/extendr-examples
We also have this:
https://github.com/extendr/helloextendr

Absolutely. Delete away, in master if necessary.

Absolutely. Delete away, in master if necessary.


Add automatic invasion tech trading between allies

There were talks about adding an auto tech trade feature that would simulate 1 invasion event per year from each technologically superior ally at a cost of resources per attempt.
Resource cost would increase with ETA (based on gates/normal engine travel, whichever is lower) between the 2 players' closest planets with docks and the tech level being learned. Costs would be roughly equivalent to the price of building and scrapping 1 scout under  normal conditions.

Would be much different from Stars. Also let all manage the logistic of the game its an important mechanic. Also it looks better to get ships from scraped ships then from ress. Also popdrop is the way techtrade between allies is normaly made.

I was thinking about it mainly for the AI (since it's not very smart atm).


[asn] Fix #27 - extend string encoding options of fromJSON API.

Fix #27
Adds support for flexible string encoding options when creating a certificate with the fromJSON API.

@turon The new version<EMAIL_ADDRESS>has been published
Thank you for your update


Add my school to JetBrains

.

@IMRIor Please provide us with:

the university official website URL, if different from the domain you are submitting
an URL of a page on the official website where an IT-related long-term (>1 year) course is offered by the university
an URL of a page or another proof (.pdf or a screenshot are OK) showing that the university recognizes the domain which you are submitting as an official email domain for the students.

@IMRIor You might miss my previous comment. Please react.

@IMRIor I am sorry, this request remains unanswered for a while. I have to close it without merging.
Please reopen and comment if you have an update regarding the abovementioned issue.
You can also ensure that you are familiar with this repository rules located at the bottom of this page and make a new correct request.  Thank you for the understanding!


evolve driver.Compile so it's easier to add new procs

The structure of driver.Compile has lots of proc-specific logic that reaches into ast data structures to make decisions.  If this optimizer had a model of what attributes it needs to know about each proc, then the ast nodes could implement one or more interfaces that provide the needed info.  That way, when someone adds a proc, they just  implement the methods needed, rather than having to look into the driver/optimizer code, study it, and see where and how the new proc fits in.

driver is gone and compiler/optimizer has improved structure for adding operators


feat: migrate to salt mux

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 74.744%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6786

Relevant Lines:
9079

💛  - Coveralls


Schema incorrect after select over aggregate function that returns a different type than the input

Describe the bug
When you have a column that is created using array_agg and the column name is the same as the column name of the original data, calling schema() produces a result that is based on the original data rather than the aggregate data.
To be more clear, if you call something like .aggregate(vec![col("a"), col("b")], vec![array_agg(col("c")).alias("c")]) and you print the schema, followed by a select_columns("c") you will get a different schema displayed. This only happens if the columnc above is a computed value, even if it is as simple as an expression col("c").alias("c").
The minimal example below shows this.
To Reproduce
The following code demonstrates that selecting the column changes the displayed schema.
The input csv is a simple table:
a,b,c
1,2,3
4,5,6
7,8,9
10,11,12

use datafusion::prelude::*;

#[tokio::main]
async fn main() -> datafusion::error::Result<()> {

    let ctx = SessionContext::new();
    let mut df = ctx.read_csv("/Users/tsaucer/working/testing_ballista/lead_lag/example.csv", CsvReadOptions::default()).await?;

    println!("Original data:");
    df.clone().show().await?;

    df = df
        .clone()
        .with_column("c", col("c"))?
        .aggregate(vec![col("a"), col("b")], vec![array_agg(col("c")).alias("c")])?;

    println!("\nBefore select\n{}", df.schema().field(2));
    println!("{}", df.logical_plan().display_indent());

    df = df.select(vec![col("a"), col("b"), col("c")])?;
    println!("\nAfter select\n{}", df.schema().field(2));
    println!("{}", df.logical_plan().display_indent());

    println!("\nFinal data:");
    df.show().await?;

    Ok(())
}

Produces the following output:
Original data:
+----+----+----+
| a  | b  | c  |
+----+----+----+
| 1  | 2  | 3  |
| 4  | 5  | 6  |
| 7  | 8  | 9  |
| 10 | 11 | 12 |
+----+----+----+

Before select
Field { name: "c", data_type: List(Field { name: "item", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }), nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }
Aggregate: groupBy=[[?table?.a, ?table?.b]], aggr=[[ARRAY_AGG(c) AS c]]
  Projection: ?table?.a, ?table?.b, ?table?.c AS c
    TableScan: ?table?

After select
Field { name: "c", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }
Projection: ?table?.a, ?table?.b, c
  Aggregate: groupBy=[[?table?.a, ?table?.b]], aggr=[[ARRAY_AGG(c) AS c]]
    Projection: ?table?.a, ?table?.b, ?table?.c AS c
      TableScan: ?table?

Final data:
+----+----+------+
| a  | b  | c    |
+----+----+------+
| 7  | 8  | [9]  |
| 4  | 5  | [6]  |
| 1  | 2  | [3]  |
| 10 | 11 | [12] |
+----+----+------+

You can see the final table shown is correct, but the displayed schema is not.
Expected behavior
Schema should remain invariant under trivial select of col or select_columns.
Additional context
No response

Commenting here for myself to continue looking further, but I suspect this is happening in exprlist_to_fields in datafusion/expr/src/utils.rs where we look towards the input fields of aggregates. Because this type of aggregate does not produce the same type as the input field is likely the culprit.

It should be caused by exprlist_to_fields_aggregate.
There are two columns named 'c', one from the aggregated input and the other from the output. exprlist_to_fields_aggregate forcibly uses the column 'c' from the input, which is of type Int64.

exprlist_to_fields_aggregate was introduced by #2486, I doubt whether we still need it now because removing it won't break any tests.

take


Application top menu does not unhide in Zen Mode when mouse is at top

VSCode Version: Insiders
OS Version: Linux (Ubuntu)

test item #15647
Steps to Reproduce:

Enter Zen Mode on Ubuntu
Note that you cannot get your OS top app bar back (e.g. File, View, Help...) when hovering at the top of the screen like you can on Mac (or on Linux when not in Zen Mode).

Should be able to see this when mouse is at top, so it's easy to discover how to get out of Zen Mode.

This is the default behavior when you go into full screen mode on linux. So we already had this concept when a user eneterd full screen -> so we are not introducing anything new.
I am not worried about people being trapped in zen mode since double esc gets out and since restarting vscode does not preserve zen mode.
Due to the above closing as designed


[Site] Configure Twig-CS-Fixer

(and apply rules)
Fully isolate website GA workflows from the components
Fix #1166

Thanks Simon.


config(bed-5001): Add GPG key generation and configuration script wit…

…h directory-aware commit verification
This script automates the setup of GPG keys for secure Git commit signing and integrates with 1Password and GitHub. It performs the following tasks:

Installation and Updates:

Installs or updates essential tools: gnupg, pinentry-mac, 1Password CLI, GitHub CLI, and jq using Homebrew.

Configuration:

Sets up GPG with proper permissions and configurations.
Configures gpg-agent to use pinentry-mac for passphrase prompts.
Appends export GPG_TTY=$(tty) to the user's shell configuration file (.zshrc or .bashrc) based on the shell being used.

User Inputs:

Prompts for and stores the user's 1Password email, GitHub username, GitHub email, and SpecterOps email.

Authentication:

Authenticates with 1Password and GitHub using the provided credentials.

GPG Key Generation:

Generates a GPG key pair with:

A non-expiring primary key used for certification only.
An expiring signing subkey (valid for one year) used for signing commits and tags.

Stores the GPG passphrase and keys securely in 1Password.

Git Configuration:

Configures Git to use the signing subkey for commit and tag signing.
Sets Git to use pinentry-mac for signing operations.

GitHub Integration:

Uploads the subkey's public key to GitHub to enable commit verification.

Security Enhancement:

Deletes the primary key from the local machine to keep it secure and re-imports the subkey for daily use.

Verification:

Ensures the script operates in its own directory, regardless of where it is executed from.
Creates or updates a shared verification file (verify_signed_commit.txt) in the script's directory, appending a new line with the developer's information.
Commits the changes to the config/bed-5001 branch, ensuring that the commit is signed with the GPG subkey.
Pushes the branch to the remote repository for verification.

Utility Functions:

Adds a function to extract the GitHub username from the gh auth status command output.
Detects the user's shell (bash or zsh) and appends export GPG_TTY=$(tty) to the appropriate shell configuration file, ensuring GPG functions correctly in new terminal sessions.

This script streamlines the process of setting up secure GPG signing for Git commits, integrating seamlessly with 1Password for credential management and GitHub for commit verification. It enhances security by using a signing subkey and keeping the primary key offline, and ensures that commit verification is consistent and operates within the script's directory.

Files Added:

tools/scripts/setup-gpg-signing.sh: The main script that automates the GPG key generation and configuration process.

Description
Describe your changes in detail
Motivation and Context
This PR addresses: [GitHub issue or Jira ticket number]
Why is this change required? What problem does it solve?
How Has This Been Tested?
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
Screenshots (optional):
Types of changes

Chore (a change that does not modify the application functionality)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Database Migrations

Checklist:

[ ] I have met the contributing prerequisites

Assigned myself to this PR
Added the appropriate labels
Associated an issue: https://github.com/SpecterOps/BloodHound/issues/672
Read the Contributing guide: https://github.com/SpecterOps/BloodHound/wiki/Contributing

[ ] I have ensured that related documentation is up-to-date

Open API docs
Code comments (GoDocs / JSDocs)

[ ] I have followed proper test practices

Added/updated tests to cover my changes
All new and existing tests passed

Closing this, moved script to confluence page.


Allow to focus previous item in editor

Fix #34405
Fix #24064
Fix #8799
The ideal fix would that is_action_pressed checked for modifiers.

I pushed a revert for now with 3d6f991a1742d89640b4b2c104d602de00dc0741.
Maybe you can rebase this PR to readd the reverted changes (to fix the issues #30721 meant to fix) + your proposed changes (to avoid #34405), and we can assess this further for 4.0?

@akien-mga actually this fixes the problem.
For some reason my local settings had some different bindings making me think and claim at #34405 that this didn't work.
Also neikeq was requested for review because of some git stuff, trying to merge...... So he isn't acutally code owner of the modified part.

These different bindings also lead me to think the same bindings was used for prev/next tab and focus prev/next and that one was used over the other depending on context. When actually they have distinct bindings.

@NilsIrl Is this still desired? If so, it needs to be rebased on the latest master branch.

Note that this pull request likely conflicts with https://github.com/godotengine/godot/pull/47671, since they try to fix the same thing but in different ways.

Superseded by #51346, which I am convinced is the "proper" fix, using the exact match checking.

Closing per @EricEzaM's comment. Thanks for the contribution nonetheless!


Cannot change the precompiled header file

Describe the bug
When changing the precompiled header file the following files are still generated with the wrong entry #include "pch.h":
XamlLibMetadataProvider.g.cpp
XamlTypeInfo.Impl.g.cpp
Steps to reproduce the bug

Create a new C++ project with template Blank App, Packaged (WinUI 3 in Desktop).
Open project properties -> Configuration Properties -> C/C++ -> Precompiled Headers -> Change the "Precompiled Header File" (e.g. to global.h)
Build.
Check the generated files.

Expected behavior
All generated entries "#include pch.h" will be replaced by entries with the new precompiled header file (e.g. #include "global.h").
Screenshots
No response
NuGet package version
1.2.220930.4-preview2
Packaging type
Packaged (MSIX), Unpackaged
Windows version
Windows 10 version 21H2 (19044, November 2021 Update)
IDE
Visual Studio 2022, Visual Studio 2019
Additional context
The problem also occurs in old Windows App SDK versions, like 1.0.0 and 1.1.3

Windows App SDK 1.3 will include support for a customized (or no) precompiled header


Omitting TypedArrays from crawling?

I have recently run into an issue with json-schema-ref-parser on a JSON object that uses $ref pointers to binary assets that get merged into the JSON object as Uint8Arrays. Some of these arrays are fairly large (several megabytes), and it turns out that the crawl() function in lib/dereference.js descends into every single element of these arrays even though they cannot contain $ref references to other items (since all the elements are numbers).
Would it be possible to exclude TypedArrays from the crawl? If so, would you be open to accepting a PR if I prepare one?

Yeah, I think that makes total sense. A PR would be appreciated 👍

Fixed in #187.


Why is there no on_error callback?

Hi,
I want to execute some code on transition failure what are my options??
FSM does provide a way to move object to some errored state but why does it not provide a callback function(or signal) for it??

django_fsm always reraising the exceiption, so you can just handle it in your code
https://github.com/kmmbvnr/django-fsm/blob/master/django_fsm/__init__.py#L331


Improve help threads

This PR does the following:

Disallow timed-out users to open/close threads.
Change the nextcord button style to blurple instead of red (why was it red?)
Indefinitely fixes the close button (finally)
Fixes an error that could appear when closing threads (awaiting .history)
And now to the main change...

Implemented a wait_for that waits 30 minutes for the thread author to send a message else close it before pinging all the helpers.

An ext.tasks.Loop that checks every 24 hours for empty threads and closes them.

This depends on Nextcord PR #317

Also does not seem to handle reboots.

it does?


draw_tree error, adata.uns['schist']['state'] is not assigned

schist runs successfully, including the scs.inference.nested_model(adata) function. However, as a result adata.uns['schist']['state'] is not assigned, and scs.plotting.draw_tree(adata) give the error KeyError: 'state'.
Going back to the code, I can see that nested_model lists adata.uns['schist']['state'] as an output, however, this is never assigned later in the file.
I also saw a previous issue "Remove state from unstructured data and IO functions #12" where 'state' is removed from adata.uns['schist']. A relevant bug is fixed in version 0.7.11 that I am using right now. The problem is that pl.draw_tree() still requires the 'state' (pls see in line 83).
I am not sure how to proceed or if I am totally missing the point. Could the producers confirm that the package is running well for them?

Hi, while waiting for fix this, you may try a workaround that requires generating a block_state and putting it into your dictionary. Something like
adata.uns['schist']['state'] = schist.tools._tl_utils.state_from_blocks(adata)

should work

It indeed does, thanks a lot! The visualisation is stunning

Should be fixed in 0.7.12


glasgow: update, fix failing build

Description of changes
Fix the glasgow package.
~Note: this is blocked by updating #pythonPackages.fx2 and adding https://github.com/NixOS/nixpkgs/pull/231156.~

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I would have tended to use substituteInPlace rather than a patch for something as simple as this, but it's not important.


add DPDK probe for performance

try to be not intrusive by using github.com/intel-go/yanff

It's good.

Hi, naplanel. Now DPDK probe has some requirements from me.
This issue wants to add DPDK probe or use DPDK　for communication?

@jonnary DPDK for packet capture not for communication

Good. Now in skydive we created some dpdk kni interfaces add to br_int for inject_packet.

Fixed: #482


SequencialGenerator should be spelt SequentialGenerator

Hi @sv3ndk :)

Hi adam,
That's a good point! Would you have time to submit a quick PR?  :)

@sv3ndk , I made a fix but the py.test gave me 14 failed, 127 passed, and 19 warnings, so I am not ready for submit a PR at the moment. However, if I do the same py.test in the master branch, I also got  14 failed, 127 passed, and 19 warnings. Is this consistent with how you understand the status of the master branch?


fix issue 88 plotAbundance rank

The original idea was for the default value to be equal to null instead of defaulting by 'Kingdom'. However, the plotExpression which is used for if the rank is not specified does not allow rank to be null because of issues with the scater library (merging error). Instead I created a function .find_lowest_taxonomy_level which looks for the lowest taxonomy level of the tse that does not contain NA's then reverts to that rank if the user didn't specify one.

Thanks!
Usually, there are some NAs in microbial datasets even in the highest ranks, so this might not be the most robust option.
Moreover, this still agglomerates the data which was the initial issue. Usually TreeSE is constructed so that the lowest rank (ASV/OTU/strain) is in "row level". The higher ranks are described in rowData (Species, Genus...). --> You cannot find the real lowest rank from rowData since it does not include that kind of information.
Check for example GlobalPatterns data. Agglomerate it to lowest available level in rowData (Species) --> the number of rows differ because there are more OTU level bacteria than Species level.
So the most transparent option would be to skip agglomeration by default.
In function .get_abundance_data, we could modify it so that it first calls agglomerateByRank only if rank is not NULL. (currently the agglomeration is done in the function without using these general mia functions for some reason) https://github.com/microbiome/miaViz/blob/0fa499a260478f135ba66b4e5cef37f9a53619bd/R/plotAbundance.R#L276
So modifications to that function would be
a. Add line that calls agglomerateByRank
b. Remove line 276
Other thing is that then user cannot use plotExpression anymore from the plotAbundance function (plotExpression is called when rank is NULL).
Also, I noticed that plotExpression does not work currently because features cannot be NULL.
My suggestion:

rank = NULL by default
Use agglomerateByRank function in .get_abundance_data function (Skip the function when rank is NULL)
Remove plotExpression from plotAbundance function (User can use it from scater.)

@antagomir

Reason for using scater::plotExpression has been that it is easier to use existing methods. Other option would be to reuse code from scater in miaViz. However, the scater pkg is under GPL-3 so we cannot use the code unless we change miaViz license (which we are by default unwilling to do). Thus we need to either stick to scater::plotExpression, or rewrite the necessary parts. Both are feasible options in principle. But calling scater would be less work.
If scater does not allow NULL ranks as discussed above, how about augmenting rowData internally and creating a new rowData field that equals to the assay rows. Then the agglomeration would not change the data but scater::plotExpression could still work?
The function .find_lowest_taxonomy_level might be otherwise useful somewhere.

Yes, but plotAbundance and plotExpression creates totally different kinds of plots.
library(miaViz)

data("GlobalPatterns")
tse <- GlobalPatterns

# This is how plotAbundance is "usually" used, --> it is agglomerated to some
# level
# It creates this common plot which is often used for microbiome summary
plotAbundance(tse, "Phylum")

# We have another layout for plotAbundance
plotAbundance(tse, "Phylum", layout = "point")

# If we want to visualize certain ASV level bacteria that belong to certain group for instance
tse_sub <- tse[1:10, ]

# We have to use plotExpression
plotAbundance(tse_sub, features = rownames(tse_sub), rank = NULL)

Currently, we cannot create plotAbundance-type plots for ASV level. So instead of using plotExpression, we could create plotAbundance-type plots also when rank==NULL

I agree about separating plotAbundance and plotExpression.
I suggest that @TuomasBorman you check this with @Insaynoah when your respective schedules allow.

@Insaynoah Can you modify plotAbundance so that it does not utilize plotExpression when rank = NULL?

One thing i don't really get is that if rank is set to null, since the plot's colors come from the rank, it will just create gray bars like this:

Thus, i don't really see how to make a usuable graph like this one.

Hmmm, true...
Well, if rank is NULL, then:

add rownames to rowData with name "rownames"
rank <- "rownames"

Does that work?
The problem might be that there are lots of rows to plot, but this is still useful since user might have already subsetted the data

That is actually a very good solution. Now when rank is set to null, the plot will color by each individual rowname, creating something like this

However if you agglomerate the data beforehand such as by phylum it will create something like this:

Also when rank is set to null, I added a condition where order_sample_by should also be null because this parameter is dependant on the rank.
Let me know if I should make any changes.

It seems as though, there's an issue with plotabundance in the Rmd file.
It uses the plotAbundance function with rank equal to NULL, expecting a plotExpression plot being returned:

But now that plotAbundance is updated to not use plotExpression when rank is null, the following line throws an error.
features <- match.arg(features, colnames(colData(x)))
Should the example be updated  to not expect a plotExpression plot ?

I will comment on this later today in more detail, but you can use plotExpression() directly. That is handy function to visualize assay. (There will be support for boxplots in couple of days)
Also check OMA examples on this

Also OMA chapter 8 on this would require updating once this is done:
https://microbiome.github.io/OMA/docs/devel/pages/21_microbiome_community.html

Hi @Insaynoah can we aim to close this soon?

I think this one should be done no ? Am i missing something ?

Ok to me (with no detailed testing).

Ah, also confirm that you have updated vignettes/ folder if that contains examples.
If @TuomasBorman approves and merges this, please check that OMA examples are subsequently updated as well if this is used somewhere.

@Insaynoah any chance to fix this one..?


PCF stays at "Loading" stage

Hi @drivardxrm,
Love this PCF thank you!
I've been trying to make it work lately but in runtime, the pcf stays at the "loading" state :

Tried it in version 9 and 8, I have the issue in both.
I'm pretty sure I have already made it work in v8 so it seems to be a new issue.

Hi @tchinnin ,
Can you try to configure the pcf using the classic editor. I noticed a weird bug that happens sometimes when I configure using the modern editor while using the filtering capabilities.

Hi,
I works using the classic form editor thank you !

@tchinnin I'm glad that you were able to make it work. I will definitely try to get to the bottom of this and try to make it work in the modern editor.
Thanks for your feedback.

@tchinnin
I have made an interesting discovery.
I compared the xml of a solution that contains the same form with the PCF configured in the modern UI vs the classic UI.
It seems that the ouput is different and the form configured in the modern UI is missing some required attributes necessary for the PCF control. Ex. Defauld view ID

I will try to send the details to Microsoft and hope that they can adjust this.
In the meantime I will update the documentation of the control. I will reopen this issue until then.

Is there a ticket or suggestion that we can follow regarding the status of the bug with Microsoft?


Update README.md to fix spelling typo

Fixed the "undertanding" vs "understanding" typo in the LUIS Bot Sample description

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


Improve Illumina 1.5 guess encoding heuristics

Adds new heuristics to improve the guessing of Illumina 1.5 encodings.
Resolves issue #18.

@brentp Thanks for the detailed code review and for those improvements!
I'll do that outstanding one and run a quick test. I hope to get to it sometime this week and will let you know once it's done.

@brentp I've revised the code accordingly, run a couple of quick tests, and pushed the revisions. Thanks again for all your help!

thanks for the improvements!


Dart-defines should generate a warning when not const

This issue is related to

Analyzer
Documentation

Version
Dart VM version: 2.8.3 (stable) (Tue May 26 18:39:38 2020 +0200) on "windows_x64"
Description
When you access dart defines in a non-const expression, e.g.
void main() {
  print('foo: ${String.fromEnvironment('foo')}');
}

This works fine when the script is run directly with dart, e.g. dart -Dfoo=bar bin/main.dart.
But fails silently when run as a Flutter application, e.g. flutter run --dart-define=foo=bar. If I understand correctly this is because Flutter only passes defines to the front-end, so they aren't available at runtime.
The example also crashes on web.
Proposal
The analyzer should give a warning if String.fromEnvironment, bool.fromEnvironment, or int.fromEnvironment are called in a non-const expression.
Documentation should be updated to clarify the importance of using const and whether or not accessing them at runtime is supported at all.

The "only const" restriction was never intended, but it was implemented that way by dart2js.
It does avoid having to carry the entire environment along in the compiled code, which is a reasonable goal for ahead-of-time compilation.
We should either accept the const-only behavior, and then enforce it on the VM too, or make dart2js support run-time lookups (it can still warn that using the constructors as non-const increases the size of the compiled code)..

I'm going to triage this into area-web (but this generally may cross over a few areas).

We cannot reasonably supply non-const values for flutter applications, so it might be a reasonable restriction that we could add to our embedder

You should not supply different results for non-const invocations of .fromEnvironment than you would have for the same const invocation.
It is supposed to be a compile-time environment that we are retaining at run-time, not a new run-time environment, so one compilation strategy is to embed that environment in the executable (but only if anyone calls .fromEnvironment non-const with a non-const argument).
(It was never actually specified in a way that made sense for AoT compilation, or modular compilation, but now at least the latter has been specced.)

Hey, people. Do you think that we can advance with upgrade docs since it is cheaper than creating a warning(it's optimal),

The docs update would have to say that the constructor is only guaranteed to work when called as const, but may work with new on some specific platforms, mainly non-AoT-compiled ones.

@lrhn Nice, I’ll add this information in my PR https://github.com/dart-lang/sdk/pull/46846

This seems to be tripping up quite a lot of people using Flutter. See https://github.com/flutter/flutter/issues/55870 and the numerous upvotes and comments there.
It doesn't sound like there's much interest from either Flutter or dart2js in actually supporting non-const usage. (When a user does want to dynamically select from some data provided at build time, there are lots of existing ways they can accomplish that.) So I think a good way forward would be to make non-const usage of String.fromEnvironment and its friends generate a warning, if not an error.


Greyed out buttons need a dark font color at darkmode

Hi @TheCheatsrichter ,
if you freshly start GW2LB, click on "Account Settings" and no account exists or no account is selected at this moment, some buttons are greyed out, but the font color is still white and this doesn't look good... a dark font color for inactive buttons would be good in general.

Hi,
the account settings buttons are still set to white colour on grey background colour.
But this happens only on first selection of account settings.
If some account was selected, the colour is white on dark grey.


Int to Nat

Hey, I am just curious: is this correct? https://github.com/pigworker/CS410-15/blob/master/HaskellSetup.hs#L44.
Since we're shrinking the domain from that of all integers to that of all natural numbers, not all integers will find a point on the co-domain of this function. Should this not rather return Maybe Nat? It currently recurses forever if n is a negative integer to begin with. Or is this correct and we consider the non-termination to be the implicit bottom?

Hi
On 20 Sep 2017, at 03:22, Felix Schlitter<EMAIL_ADDRESS>wrote:

Hey, I am just curious: is this correct? https://github.com/pigworker/CS410-15/blob/master/HaskellSetup.hs#L44.
Since we're shrinking the domain from that of all integers to that of all natural numbers, not all integers will find a point on the co-domain of this function. Should this not rather return Maybe Nat? It currently recurses forever if n is a negative integer to begin with.

Technically true for Integer, but not Int. Might take a while for Int, all the same.

Or is this correct and we consider the non-termination to be the implicit bottom?

Given the way it's used in practice (to convert window dimensions and cursor
positions into Agda-manipulable values, rather than in general), it's not a big
deal.
I mean, it's not as if Haskell programmers routinely promise to tighten their
types only to the meaningful domain.
That file is intended as "glue code" between specific Agda exercises and the
outside world. If taken as directed, all will be well.
Wontfix
Conor

I mean, it's not as if Haskell programmers routinely promise to tighten their types only to the meaningful domain.

If  we talk about partial vs. total functions then I would argue the opposite and would prefer a total function any day of the week even at the cost of less convenience somewhere else. I could always unleash my fromJust when providing a value to the function I know is in the range of natural integers.
Anyway, as I warned this was really just curiosity and I learned something from it. So case closed :)


Replace poison with jason in applications list

When running a release
** (UndefinedFunctionError) function Jason.encode_to_iodata/1 is undefined (module Jason is not available)

Oh, really nice catch! I definitely missed this since I am very used with :extra_applications :). Thanks @teamon! 💟


Redesign completely the "petition template"

The petition template code is not very clean to stay polite.
Rewriting it from scratch is really something that needs to be done.
Maybe rethinking the page organization with designers would be a good idea.
The template in question is https://github.com/fallen/Pytition/blob/master/pytition/petition/templates/petition/detail2.html

Let's be more specific about what I think should change in this detail2.html template:

its name
fontawesome should go away, the remaining part of the site uses Open Iconic, fontawesome was interesting becaused it shipped with Bootstrap 3, Bootstrap 4 no longer does.

<script type='text/javascript'>var CONTEXT_ROOT = '/ea-action';</script>
<script type='text/javascript' src='/static/eaCommon.js'></script>
<script type='text/javascript' src='/static/eaAJAX.js'></script>
<script type='text/javascript' src='/static/eacampaign.js'></script>

Those should go away as well. They are copy paste from an old Greenpeace petition, I don't even know which kind of copyright or license applies on those files and I guess we use very few of the features brought by those. Let's just integrate the minimum we need and remove the files altogether.
think about dropping typeahead, is it really needed?

"Important" features to keep IMO:

Color of "Sign button", or at least have a nice style, not the default HTML5 button style.
Color of signature number loading bar
The fact that the signature number loading bar "loads" at page startup (animation)
The fact that the right panel follows the scroll and sticks to the top when it reaches it.
Keep it reactive, like https://petition.antipub.org/petition/4/ so that when it is viewed on smartphone or small screen the right panel stacks up with the petition and the "sign" button follows the scrolling/reading.
Error feedbacks on the signature submission form

its name

Yes !

fontawesome should go away, the remaining part of the site uses Open Iconic, fontawesome was interesting becaused it shipped with Bootstrap 3, Bootstrap 4 no longer does.

Ok, I did not found exactly the same icons but it should work.

think about dropping typeahead, is it really needed?

I agree, it is not really needed.

The fact that the right panel follows the scroll and sticks to the top when it reaches it.

It is.

Keep it reactive, like https://petition.antipub.org/petition/4/ so that when it is viewed on smartphone or small screen the right panel stacks up with the petition and the "sign" button follows the scrolling/reading.

I can use order flexbox property
And ok for the others features, I have to test the petition signature for some of them.

I think we can close this.
Thanks again! :)


Fix: issue #233

Changed ports so no error occurs.

Hi @JanKaczmarski, thank you for your contribution to opening this PR.
I think the best approach for this will be updating the documentation README.rst instead of the docker-compose.yml.

Hi @kairoaraujo , thanks for pointing out the problem in my approach.
I'll try to fix it.

Could you also add sign-off to your commit @JanKaczmarski?
This way if in the future someone wants to ask you about your change your email will be there.
Thanks for contributing!

Okay @MVrachev


Is there a way to auto update the hosts file?

Hi there. Is there an easy way to update the hosts file in /etc/hosts? Is it even safe?
And how would I go about doing so?`
Also... Your hosts file blocks useful sites such as max.com which is the new HBO Max.

Hi there. Is there an easy way to update the hosts file in /etc/hosts? Is it even safe? And how would I go about doing so?`

Hi. I'm using pihole for network-wide ad blocking and never tried editing / auto-updating local /etc/hosts file.

Also... Your hosts file blocks useful sites such as max.com which is the new HBO Max.

Thanks for report. max.com whitelisted.
If you see any other false positives, please let me know.

Thank you so much.


Fixed broken links in what-next.md

Fixed the broken links on the whats-next page which redirect to the human-in-the /human-in-the-loop.ipynb , code-executors.ipynb and conversation-patterns.ipynb.

Why are these changes needed?

Related issue number

Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

hey sorry I am getting back on this @sonichi your invitation to me expired  can you invite me again please :)

I believe this is already fixed


Can't make gitsigns appear

Sorry for opening this issue but I can't figure out why I'm not seeing the vertical bar with colors representing git changes.
I'm hoping you could help me

My configs:
--- configs/statuscol.lua
local builtin = require("statuscol.builtin")

local cfg = {
	relculright = true,
	segments = {
		{
			text = { builtin.foldfunc },
			click = "v:lua.ScFa",
		},
		{ text = { " " } },
		{
			sign = { name = { "Diagnostic" }, maxwidth = 1, colwidth = 2, auto = false, wrap = true },
			click = "v:lua.ScSa",
		},
		{ text = { builtin.lnumfunc }, click = "v:lua.ScLa" },
		{
			sign = { namespace = { "gitsigns" }, name = { ".*" }, maxwidth = 1, colwidth = 2, auto = false },
			click = "v:lua.ScSa",
		},
	},
}

return cfg

--- plugins/ufo.lua

return {
	"kevinhwang91/nvim-ufo",
	dependencies = {
		"kevinhwang91/promise-async",
		"luukvbaal/statuscol.nvim",
	},
	config = function()
		local statuscolCfg = require("configs.statuscol")
		local ufoCfg = require("configs.ufo")

		require("statuscol").setup(statuscolCfg)
		require("ufo").setup(ufoCfg)
	end,
}

--- plugins/statuscol.lua
return {
	"luukvbaal/statuscol.nvim",
}

No worries, I've just opened GH Discussions for this repo so you can use that in the future.
I'm not sure why your gitsigns aren't showing up. Works for me with your config. What Neovim version are you on?

Version:
nvim --version
NVIM v0.9.5
Build type: Release
LuaJIT 2.1.1710088188

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/opt/homebrew/Cellar/neovim/0.9.5/share/nvim"

Run :checkhealth for more info

I'm using NvChad as a baseline for my config and I didn't change anything for gitsigns.
You can find them her:

https://github.com/NvChad/NvChad/blob/v2.5/lua/nvchad/configs/gitsigns.lua
https://github.com/NvChad/NvChad/blob/v2.5/lua/nvchad/plugins/init.lua#L35-L44

If I run the :set scl=yes stc= I do get a new gutter which shows the gitsigns

I'm afraid I don't know. I cloned NvChad and cant reproduce it there either.

Well, I "fixed" it.
It was already working, my highlight groups were wrongly set and it was coloring 😅
Thank you for the support!


Problem with dropdows

Hello. I've added this materialize to my rails app, and made navbar with it with dropdown menus. At first it works normal: I click on navbar, dropdown appears, and then links, which are in this dropdown work. But when I link it and try to open dropdown again it doesn't appear until I refresh the page. Please help me.
Here it is my app for example http://qualitet.herokuapp.com/

I don't even see a dropdown. Why don't you create a isolated incident in a codepen so we can determine that this is a problem in Materialize?

Due to a lack of response and an unclear problem, we've closed this issue for now. If you clarify with the necessary information we will reopen it.

i have this problem too!!

Is this a general materialize problem? I cant solve and my friend cant too

http://www.alunosdesucesso.com/
Check the dropdowns!

if you click in the dropdown more than one time, it doesn't appear until i refresh the page

well it looks like you could be using meteor or something similar. In which case you need to init the component in a rendered callback

Sorry, but i didn't understand

I have seen this problems in others sites with materialize dropdowns