WSL.exe adds null characters between characters

Windows Build Number
Microsoft Windows [Version 10.0.21354.1]
WSL Version
2
Distro Version
Ubuntu-20.04
Other Software
No response
Repro Steps
WSL.exe adds null characters between letters
PS C:\Users\user> $results = wsl --status
PS C:\Users\user> $results[0]
Default Distribution: Ubuntu-20.04
PS C:\Users\user> $results[0][0]
D
PS C:\Users\user> $results[0][1]

PS C:\Users\user> $results[0][2]
e
PS C:\Users\user> [int]$results[0][1]
0

Expected Behavior
WSL.exe does not add null characters between letters
Actual Behavior
WSL.exe adds null characters between letters.
Diagnostic Logs
No response

https://en.wikipedia.org/wiki/UTF-16

I am surprised that PowerShell isn’t handling UTF-16 correctly.

Variation on #4456.

And #4707.  There's a workaround in this comment.

After getting some time to test this, I have confirmed that UTF-16 is my issue.  Setting PowerShell to handle it does address my issue.


Don’t mess with __d in while, for, and if

That isn’t necessary because __d is only ever mutated, not reassigned.

Nice!


Cannot set workflow ID for replayer

We have a workflow which derives various child workflow execution IDs by appending subtask names ("-start-session" in the example below) to the current workflow execution ID. Upon replaying those histories during CI to check for non-determinism problems, we see (re-wrapped for your convenience):
2023/01/04 13:33:12 ERROR Workflow panic
    WorkflowType Main
    WorkflowID ReplayId
    RunID 2bc48c60-ee48-4b19-99fb-0656c4d30a99
    Attempt 1 Error unknown command
    CommandType: ChildWorkflow, ID: merchant-consumer-workflow/ed472a6d-b793-501c-af06-a501158487b6-start-session,
    possible causes are nondeterministic workflow definition code or incompatible change in the workflow definition
    StackTrace process event for Merchant [panic]:
go.temporal.io/sdk/internal.panicIllegalState(...)
        /home/drahflow/go/pkg/mod/go.temporal.io/sdk@v1.19.0/internal/internal_command_state_machine.go:532
...

as the re-derived child workflow IDs will now (i.e. during replay) be based upon the ReplayId string used as the workflow execution ID here:
https://github.com/temporalio/sdk-go/blob/06e474c93e936b71dc4afcec973460b22c13986d/internal/internal_worker.go#L1235
In reality however, there is nothing non-deterministic about such a derivation, as the workflow execution ID is fixed for a given execution.
A possible solution would be to allow providing a custom execution ID (in practice derived from the recorded history filename) when replaying a history.

A workaround is relatively straightforward via recording the own execution ID in a side-effect, but that seems extremely unnecessary.

Yeah workflow ID, unlike run ID, cannot currently be derived from history. Unlike our other SDKs, the Go SDK does not offer a way to set the workflow ID on the replayer. I have altered the title of this issue.


Fix formatting + check content for Programming Languages

Additionally, look into splitting this chapter into two seperate ones - one that focuses on what is programming (the introduction of the existing chapter), and one that focuses on low level languages/ compilers/ interpreters.

Resolved as of V3.0


bug/fix-octicons

Summary of Changes:

Fix build so that it properly copies octicons based on the lib's changes to its directory structure in 4.x

@reviewbybees

🐝
Trivial change ... +1 on going for an immediate merge @cliffmeyers


Sorry about the problems, this seems to be much harder to implement than I
originally thought.

/packit build


chore: prettier, tslint and cleanup

Add warning message on windows platform and do not start the language server.
Change compile directory to standard "out".
Update tslint and add prettier.
Reformat all files.

Still a work in progress.

thanks, this is much needed! do  you think we could make separate PRs?

PR for adding prettier / TSLint (which are the majority of the changes here)
PR for adding the warning etc

Yes, I agree, as this got a bit out of hand last night. I will clean it up and make a series of PRs.

tsling, prettier, eslint
warning mesage
Chane to how phpactor LS is bundled
Change of publisher and GH actions

Please leave this open and I will try to refactor it today when I have time.

I think this PR is ok now. Let me know if you see anything you don't like.
I'm looking into the windows warning again. There is a concept of when in the extension manifest that could perhaps be used to disable the extension on windows - but I can't seem to get it working. In either case, all the registered command also need to be disabled. I'll do a separate PR for that. After that comes the repackage of phpactor LS. And lastly what is needed to publish.

looks good from a quick glance :+1: a few questions above

:+1: thanks!


Filters are not working in qute web views

I've created pretty standard filters for my application. They are working fine for standard rest easy endpoints but not for qute web views.
import io.quarkus.logging.Log;
import jakarta.ws.rs.Priorities;
import jakarta.ws.rs.container.ContainerRequestContext;
import jakarta.ws.rs.container.ContainerResponseContext;
import jakarta.ws.rs.core.Request;
import org.jboss.resteasy.reactive.server.ServerRequestFilter;
import org.jboss.resteasy.reactive.server.ServerResponseFilter;

public class SampleFilters {

    @ServerRequestFilter(priority = Priorities.AUTHENTICATION)
    public void filterRequest(ContainerRequestContext requestContext, Request req) {
        Log.warn("request filter");
    }

    @ServerResponseFilter(priority = Priorities.AUTHENTICATION)
    public void filterResponse(ContainerResponseContext responseContext) {
        Log.warn("response filter");
    }

}

This filter is not invoked at all for any qute views.

Well, the resteasy-reactive filters are indeed not used for routes registered by qute-web. They're only applied to JAX-RS resources. You would need to register a filter in an @Observes io.quarkus.vertx.http.runtime.filters.Filters method or a @RouteFilter method (from the reactive-routes extension) in order to apply the same logic for any route (including the JAX-RS resources).

I'm going to close this one because quarkus-qute-web is not built on top of resteasy-reactive or JAX-RS in general.


parent width percentage bug

i've been finding that when the parent container has width as a percentage (or has flex growth), The chart (any type) seems to be cut off on the right side.  But if the width was fixed size it was fine.  Then once the browser resizes, it will resize correctly.  But if I refresh, the chart is cut off again.  This happening at least on Chrome and Firefox. Has anyone else seen this?
Attached is what i'm seeing: top is fixed width, bottom is percentage

sorry for prematurely posting seems like there's an animation state that's screwing it up

I'm having this too. So what do I do to it?


mockReturnValueOnce takes precedence over mockImplementationOnce

🐛 Bug Report
mockReturnValueOnce takes precedence over mockImplementationOnce regardless of the invocation order.
I would expect mockReturnValueOnce(value) to be a shorthand of mockImplementationOnce(() => value), but it doesn't seem to be the case.
Is this an intended behavior? It looks weird to me. If this is intended, what's the rationale behind the design decision?
To Reproduce
test('test', () => {
    const spy = jest.fn();
    spy.mockImplementationOnce(() => 1);
    spy.mockReturnValueOnce(2);
    console.log(spy(), spy()); // I expect 1 2, but 2 1 is logged
});

Expected behavior
Should log 1 2
But it logs 2 1
Run npx envinfo --preset jest
Paste the results here:
System:
    OS: Linux 4.15 Ubuntu 18.04.1 LTS (Bionic Beaver)
    CPU: (4) x64 Intel(R) Core(TM) i7-7600U CPU @ 2.80GHz
  Binaries:
    Node: 10.13.0 - /usr/local/bin/node
    Yarn: 1.15.2 - ~/.npm-packages/bin/yarn
    npm: 6.9.0 - ~/.npm-packages/bin/npm

Duplicate of https://github.com/facebook/jest/issues/8376. There's a fix PR, but it'll have to land in a major version.


Suggested addition of strip plot graph

Hi,
Suggested addition of strip plot option. I think I’ve changed the right bits of the code to add a strip plot, though for some reason when I view it locally the strip plot option does not appear? Maybe I’m missing further changes needed to add this new option.

Fixed it. Here’s how it would look with strip plot added https://billster45.github.io/python-dataviz-cookbook/


remove semicolon

Remove semicolon after ADD_SERIALIZE_METHODS

Thanks, all unit tests pass. This is great!
If you want to do more files, just push more commits to your branch. When you get bored and feel finished I can press 'merge' :) Just let me know.

ignore the last part of my comment, I bet you got all of them. I'll check tomorrow when I'm less sleepy.


crash: Error validating proposed transition frontier dependencies: already in frontier

Crash on proposer
coda.log.save.gz
{
"crash_timestamp":<PHONE_NUMBER>.315317,
"filename": "./test-coda-already_frontier/coda.log",
"full_error": "(monitor.ml.Error
"Error validating proposed transition frontier dependencies: already in frontier"
("Raised at file \"src/result.ml\" (inlined), line 158, characters 17-26"
"Called from file \"lib/proposer/proposer.ml\", line 316, characters 24-1023"
"Called from file \"src/deferred0.ml\", line 56, characters 64-69"\n  "Called from file \"src/job_queue.ml\" (inlined), line 131, characters 2-5"
"Called from file \"src/job_queue.ml\", line 170, characters 6-47"
"Caught by monitor coda"))
",
"hostname": "20190613_us-east-1_proposer_0.us-east-1",
"signature": "a63663f59bb12ed7bff9215e9038fc03"
}

We think this was caused by bad testnet configuration (duplicate proposer keys). It shouldn't crash still.


[BUG] JSQLParser Version 4.8: DB2 : CURRENT TIMEZONE parsing failure

Always check against the Latest SNAPSHOT of JSQLParser and the Syntax Diagram
Failing SQL Feature:
SELECT * FROM TABLE1 where COL_WITH_TIMESTAMP <= CURRENT TIMESTAMP - CURRENT TIMEZONE

Above query validation is failing with below error
"Cannot parse statement: net.sf.jsqlparser.parser.ParseException: Encountered unexpected token: "ZONE" "ZONE"\n    at line 1, column 177.\n\nWas expecting one of:\n\n    "::"\n    "["\n    "^"\n    \n    <ST_SEMICOLON>\n"
Software Information:

JSqlParser version 4.8
Database (IBM DB2 )

Tips:
Please write in English and avoid Screenshots (as we can't copy and paste content from it).
Try your example online with the latest JSQLParser and share the link in the error report.
Do provide Links or References to the specific Grammar and Syntax you are trying to use.

Greetings.
CURRENT TIMEZONE is not supported.
I also struggle to understand how the expression CURRENT TIMESTAMP - CURRENT TIMEZONE makes sense, since CURRENT TIMEZONE is not supposed to be a scalar, is it?

Its special register as per https://www.ibm.com/docs/en/db2/11.1?topic=registers-current-timezone
But the query works fine in DB2.


Check in a current and canonicalized config.yaml

need to do a fork of my local config.yaml so i can maintain both my own version for use and a canonical default for the github repository.
see: https://gist.github.com/eFishCent/dcce711d6babb123d8ab8d0ba3dc0532

Is this done since the merge happened?  Or is there more to do.

The config checked in is now a good template.  We should still make a better way for people to customize their own config without editing the source code tree, but maybe that is done now too?

https://github.com/ericaltendorf/plotman/issues/84 is what has come of the related discussions.  As installation is recommended now on development you do not clone the source (pip does, but you don't).  @jkbecker has been talking about options for having plotman grow a command to write out a config file to it's 'preferred' location rather than making users go to GitHub to get a copy to start from.
It sounds like this issue is done.  It sounds like maybe another ticket should be created for the create-a-config-for-the-user feature?

That makes sense to me.


JavaScript Algorithms and Data Structures - Testing Objects for Properties

Describe the Issue
Attempting this lesson and I create this:
This is shown in the box below:
// running tests
checkObj({gift: "pony", pet: "kitten", bed: "sleigh"}, "gift") should return the string pony.
checkObj({gift: "pony", pet: "kitten", bed: "sleigh"}, "pet") should return the string kitten.
checkObj({city: "Seattle"}, "city") should return the string Seattle.
// tests completed
And I cannot move on.
Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/basic-javascript/testing-objects-for-properties
Your code

function checkObj(obj, checkProp) {
// Only change code below this line
return "Not Found";
// Only change code above this line
}
Expected behavior
The correct answer
Screenshots
No response
System

Device: Laptop
OS: Windows 10
Browser: Chrome
Version: [e.g. 22]

Additional context
No response

@AnthonySummers157 This sounds like it should be asked in the forum. Please use the Get Help button in the challenge to Ask for Help, which will create a new post in the forum and automatically include our code.

Thank you for reporting this issue.
This is a standard message notifying you that this issue seems to be a request for help. Instead of asking for help here, please click the "Get Help" button on the challenge on freeCodeCamp and choose the "Ask for help" option, which will help you create a question in the right part of the forum. Volunteers on the forum usually respond to questions within a few hours and can help determine if there is an issue with your code or the challenge's tests.
If the forum members determine there is nothing wrong with your code, you can request this issue to be reopened.
Thank you and happy coding.

This is not an ask for help, the answer being provided is not related to the input being asked, it is two different scenarios in one.

What do you mean?
checkObj called with {gift: "pony", pet: "kitten", bed: "sleigh"}, "gift" is expected to return string pony.
At the same time when called with {gift: "pony", pet: "kitten", bed: "sleigh"}, "pet" it should return string kitten.


Extract Application.get_env(:cadet, :environment) and ignore priv/plts

Pull Request Test Coverage Report for Build 2962

3 of 4 (75.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 94.275%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/cadet/assessments/image.ex
0
1
0.0%

Totals

Change from base Build 2957:
0.07%

Covered Lines:
1054

Relevant Lines:
1118

💛  - Coveralls


azsphere device update error

after I run the command "azsphere device update --productname MyProduct --devicegroupname Development" it returns "azsphere device update: error: the following arguments are required: --device-group/-g
Run 'azsphere device update --help' for detailed information about the command." and shows me the command arguments.  I'm running
Azure Sphere SDK
<IP_ADDRESS>749
appreciate any help. thanks!

I just ran the deprecated version of Azsphere CLI and it worked.


focusedView gets stuck on workbench.view.search when search is not open or focused

Type: Bug
When the search view is the last focused view the side bar and the sidebar is toggled closed focusView is left set to workbench.view.search which breaks keybindings.
Steps to reproduce:

Press Ctrl+Shift+F to open the serach view
Press Ctrl+B to toggle the side bar
Inspect context keys
Notice focusedView == "workbench.view.search"

Expected outcome

focusedView == ""

In this gif I first show the Alt+B works to toggle editor maximized state, which relies on focusedView not being set. Then I toggle the sidebar with the search view active. Then I attempt to use Alt+B again and it no longer works.

One workaround is to toggle the panel to force focusedView to update.
 Do you have any other keybindings that may be contributing alt+b? I tried to repro by checking context keys (focusedView was properly unset when search was closed) and also setting an action to run on empty context (which worked once I closed the search view).

I'm unable to repro after updating Insiders to 2f32f0edae007ddd03699c325a451184c4c5e89b. Looks like some snuck a fix in already :)

I'd like to bump this issue if at all possible. This is a significant workflow impediment that occurs multiple times a day for me. Keybindings are based on context and broken keybindings are a major issue, imo. Jiggling panels until things start working again can be highly frustrating.
The default bindings don't use focusedView in a way that is likely to be problematic, but for users with custom keybindings this is an important context key. I have 20 keybindings that use it.

I'm not able to reproduce this anymore, given that the issue is pretty old I will be closing it.
https://github.com/user-attachments/assets/3ffe1605-908c-4e1a-829d-68c7d6033146
Please feel free to reopen and ping me if you are still having problems


Arcade physics fps fixes

This PR (delete as applicable)

Fixes a bug

Describe the changes below:
We've encountered several issues in Phaser when using Arcade Physics and the framerate drops below 60. (Technically, any time when multiple physics steps run per frame, so if physics FPS is above 60 this will also occur.)
Issue 1: Friction starts to flip out. Objects on moving platforms get pushed ahead of the platform and "catch" on the leading edge.
Issue 2: Physics objects start to dip into the floor. In the "Before" demo, the camera is locked to the player, so this appears as the entire world starting to shake up and down.
Issue 3: When objects dip into the floor, their "rest velocity" is non-zero. This can affect debug and other logic.
Early sightings of these issues were reported in issue #4672
I provide a demo of these issues at work, using a barrel of balloons to drag the frame rate down to the point where these effects becomes noticeable. Debug commands are available for tweaking the frame rate killers for different machines.
Demo 1: Before
https://storage.googleapis.com/staging-files.gamefroot.com/users/71078/games/106343/gamefroot-2019-7-27T3-43-18.540Z/index.html
I've developed fixes for these issues, hopefully without significant impact.
Demo 2: After
https://storage.googleapis.com/staging-files.gamefroot.com/users/71078/games/106343/gamefroot-2019-7-27T3-43-18.540Z-new/index.html
The friction fix in more detail:

Added prevFrame vector to Arcade.Body, so we can distinguish between frame-length changes and step-length changes. Several steps may run for every frame, particularly when fps is low.
Removed _reset flag from Arcade.Body, and replaced it with a check of this.moves. The flag only turned on when this.moves was true, and never turned off.
Added reset of prev in Arcade.Body#step. This fixes the friction issue.
Removed Arcade.Body#postUpdate setting _dx, _dy, and prev. They remain in the state they were at the end of the last physics step. This will affect the delta methods, which are documented to provide step-based data (not frame-based data); they now do so. (However, because several steps may run per frame, you can't interrogate every step unless you're running functions based on physics events like collisions. You'll just see the latest step.) This should partially balance out the extra load of resetting prev, above.
Added a zero-out of stepsLastFrame in Arcade.World#postUpdate, which would otherwise never zero out and keep running at least one pass per frame. This should improve performance when frames can be skipped.

And the floor dip fix:

Removed blocked checks from TileCheckX and TileCheckY. Originally, this prevented multiple checks when an object had come to rest on a floor. However, when multiple steps run per frame, the object will accelerate again, the floor won't stop it on steps 2+, and it will end the frame a short distance into the floor. Removing the blocked checks will fix the floor dip issue and the rest velocity issue. Although this opens up multiple checks, this is probably very rare: how many times does an object hit two different floors in a single frame?

An alternative fix might be to simply prevent an object from moving in a given direction if it's been blocked already during this frame's steps. But this would cause weird effects when sliding around corners (you'd actually want to have the option of moving in the blocked direction once you pass the corner), so I don't recommend it.

I think this will result in more reliable physics under high step rate conditions (e.g. low fps, or running high physics fps to cope with high velocity game objects), without any significant performance cost. Both demo scenes run around 17fps in Chrome on my desktop.
Note: Instead of @since, I documented the prevFrame vector with @author, because I wasn't sure if/when this fix would be released, and I figured I might as well toot my own horn. Please alter that section as necessary.

Hi @BenjaminDRichards, I downloaded and built your branch and I just wanna let you know that you've just solved this issue: https://github.com/photonstorm/phaser/issues/4732
Thank you so much! This fix needs to be added to next version of Phaser.

@BenjaminDRichards, I just want to inform you that your implementation somehow broke arcade body reset() method. If I call this.body.reset(startPos, startPos) on arcade sprite in order to move it to initial position (flow of my sprite is StartPos -> Move to endPos -> Reset to StartPos), the body is positioned on wrong coordinates. Also I have experienced different behaviour when I call this.body.enable = false before reset.
I am sorry I am not attaching any code, but I am too busy to separate it from my big project right now. The only thing I know is that with official Phaser distribution reset behaves correctly. If I switch to your build, the error is present. Can you take a look on this issue please? Thanks so much!

@falifm Good spotting! Let me dig into that and see if I can improve matters before this gets merged.

@BenjaminDRichards did you get anywhere with the issue @falifm mentioned? just wondering as I'll hold on that before merging into 3.20.

@photonstorm I'm currently working on an unrelated, urgent project, so no progress on this. I'll make noise when I've had the time to diagnose and resolve the issue, I'm guessing in about a week or so.

@BenjaminDRichards really looking forward to this one, thank you man, I can't wait!

This is all now merged into 3.20 and I've added in a fix which should address the Body.reset issue as well. Thanks everyone.


[Bug]: Scrolling Action is Not Performed in Contact Us Section

Description

In Contact Us Page, Scrolling Action is not Performed.

Expected Behavior

Fix this Scrolling Action in Contact Us Page. Scrolling action Behaves smoothly likely other Related Pages

Show us the trouble with screenshots
https://github.com/OSCode-Community/OSCodeCommunitySite/assets/84512164/dff6fe66-0152-4a4e-9a78-9f4403209a77
Which browsers are affected?
Chrome
Which OS are affected?
Windows
Enter the version of your web browser
Google Chrome- Version 114.0.5735.199 (Official Build) (64-bit)
Device?
Desktop
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

Please assign this issue to me.


Generic parameter 'Element' could not be inferred

XCode 12.0.1
v 2.1.10
AES.swift  line 153
try CCCryptorFinal(cryptor, &outBytes + outLength, outBytes.count, &outLength).check()
build failed, Generic parameter 'Element' could not be inferred.

how to solve it?

@skywinder please look into this issue, as the Xcode version later than 12 is complaining as the &outBytes and outLength are different data type and they cant be get added.


Command Cache: enhancements

From the webinar: Can we enable command cache for selective queries? Also can we explicitly query the DB if command cache is enabled ?

@luigidellaquila can we query the database with metadata to know this?

I think the question was not related to getting info from the db, but just to enable command cache selectively and/or bypass it.
Anyway, in v3.0 the command cache has to be re-written
Thanks
Luigi


SfBadgeView

Description

Badges are used to notify users of new or unread messages, notifications, or the status of something.
https://help.syncfusion.com/maui/badge-view/overview
Public API Changes
<badge:SfBadgeView HorizontalOptions="Center" VerticalOptions="Center" >
        <badge:SfBadgeView.Content>
            <Button Text="Primary" WidthRequest="120"  HeightRequest="60"/>
        </badge:SfBadgeView.Content>
</badge:SfBadgeView>

SfBadgeView sfBadgeView = new SfBadgeView();
sfBadgeView.HorizontalOptions = LayoutOptions.Center;
sfBadgeView.VerticalOptions = LayoutOptions.Center;
//Adding image to the content of the badge view.
Button button = new Button();
button.Text = "Primary";
button.WidthRequest = 120;
button.HeightRequest = 60;
sfBadgeView.Content = button;
Content = sfBadgeView;

Intended Use-Case
Position : Position the badge text around the badge content.
Predefined styles : Customize the badge background with predefined colors.
Animation : Use animations for badge text.

Please develop on this branch
git fetch origin
git checkout 84-sfbadgeview


Add link URL for analysis

When a user runs an analysis and clicks "run analysis", we should update the URL to save that information
And when coming from this link, autofill the analysis module.

Related:
https://github.com/WFP-VAM/prism-frontend/pull/145


Modify arcs_kt_gen rule to allow on schema-only .arcs dependencies.

Developers may want to write Schema.arcs files that contain shared schemas. This breaks Ben's arcs_kt_gen tool, which also offers a lot of developer convenience.
This change allows one to specify an .arcs file as a dependency in arcs_kt_gen.

This is failing to pass tests in an interesting way.
This change runs the manifest checker anywhere that arcs_kt_gen is called. This seems to have exposed a bug in the manifest checker: It does not support java-style classpaths for particles.

Can you share the error and the test case causing the error on team chat?

Posted the issue w/ a test branch on chat.


Bad error message when array-of-tuples to tuple-of-arrays transformation fails

When running futhark on this
fun [ { [int], [int] } ] main () =
    [ {[1,2], [3,4,5]}, {[4], [1,2,3,4]} ]

I get the cryptic error message futhark: (Array.!): undefined array element. This is of because of the array-of-tuples to tuple-of-arrays transformation, which is also shown in the documentation, but I still think a better error message could be expected.

lets also get a way to add negative tests

This fails due to changes I recently made in Futhark.Internalise.TypesValues.internaliseValue.  (I think previously it just naively truncated, so no great regression.)  I will fix it eventually.


flake-info: drop channels for flake commands

Same workaround as in nix-community/nur-packages-template#95 and https://github.com/wegank/nur-packages/commit/631ea9f525ec2ecfb3daf4365cab213b19baa0cf, should hopefully fix the hourly import.

Thank you!


IAsyncCollector capability per binding type is undocumented

The IAsyncCollector implementations/capabillities per binding type are undocumented. I think this should be fixed. Below is my private story that deals with the ServiceBus binding and its surprisingly lacking IAsyncCollector implementation.
If I understand the code correctly after exploring the issue, the binding result/implemetation of IAsyncCollector for a ServiceBus binding is MessageSenderAsyncCollector. This class has an empty implementation for  IAsyncCollector#FlushAsync, where it returns a task with an immediately available result.
This means or at least implies that there is no support for batching of messages sent to a service bus.
In fact, if the programmer doesn't explicitly await the result of the Task returned from AddAsync in his own code, it is possible the message will never be sent.
It is true, that the interface allows and sort of documents the possibility, but without exploring the code of the WebJobs SDK, there is no way for me know what is the status of the support for IAsyncCollector for each binding type.

The BYOB binding graph support should help with this. We need to find some way to expose this and make it more discoverable.


[Godot 4.x] Memory leak

Godot version
Any godot 4.x is affected. I didn't check 3.x
System information
Debian 11
Issue description
The Godot editor have memory leak.
To check it run any project and wait for it (look at its process)
It grow ~20Mb hour.
Steps to reproduce
See before.
Minimal reproduction project
NA

any project

Do you have an example?

any project

Do you have an example?

Well my projects are fine. The Godot editor leak. I noticed by chance because I have two projects (auth+gtw section) in another pc and I let them running for days - in production they will running forever -;) Their editors grow up to 5Gb each while it start with ~400Mb. Still my projects remain the same. I tested it with other projects and other versions - as stated before -. And in all cases the project is ok. while the editor process grow.
Well I use network ofc for all my projects but I tested them without any network connections. You cannot see any differences in the first 2~3 mins. You have to wait. My intuition tell me it happen when the editor refresh itself. But is just my intuition, so I can be wrong because I don't know the whole codebase.

Yes, happens to me too. I am on Mac OS Ventura 13.2.1. I am leaving the Editor open all the Time and it caps the memory of my machine (8GB). When the Godoteditor starts lagging i know memory is full. I check in Activity Monitor and it is at around 6GB. I think my machine cannot allocate more. If i restart the editor my project starts at 1.1 GB.


Converting Hyper::Body to Vec

Please how do I get the below issue resolved. I have tried to use concat2 and try_concat but to no avail serde_json::from_slice expects bytes.
 use std::future::Future;
 use hyper::Client;
 use hyper_tls::HttpsConnector;
 use serde_json;
 async {
          let mut request = hyper::Request::builder().method(.....);
	 let https = HttpsConnector::new().expect("TLS initialization failed");
	 let client =  Client::builder().build::<_, hyper::Body>(https);
	 let response = client.request(request).await;
	 response.unwrap().into_body()
	 let value: serde_json::Value = serde_json::from_slice(&body).unwrap();
};

error[E0308]: mismatched types
--> src/actions/request.rs:235:67
|
235 |             let value: serde_json::Value = serde_json::from_slice(&body).unwrap();
|                                                                   ^^^^^ expected slice, found struct hyper::Body
|
= note: expected type &[u8]
found type &hyper::Body

Not sure if this is what you might be looking for?
let response = req.into_body().concat2().map(move |chunk| {
    let body_bytes = chunk.iter().cloned().collect::<Vec<u8>>();
});

use futures::stream::TryStreamExt;
self.take_body().try_concat().await.unwrap().to_vec()

Maybe you'd want to be using reqwest instead? It can directly parse responses as JSON, for example.

use futures::stream::TryStreamExt;
request.body_mut().try_concat().await.unwrap().to_vec()

@fundon
I got this ;
error[E0599]: no method named `try_concat` found for type `hyper::Response<hyper::Body>` in the current scope
   --> src/actions/request.rs:232:20
    |
232 |           response.try_concat().await.unwrap().to_vec()
    |                    ^^^^^^^^^^ method not found in `hyper::Response<hyper::Body>`
    |
    = note: the method `try_concat` exists but the following trait bounds were not satisfied:
            `&hyper::Response<hyper::Body> : futures_util::try_stream::TryStreamExt`
            `&mut hyper::Response<hyper::Body> : futures_util::try_stream::TryStreamExt`
            `hyper::Response<hyper::Body> : futures_util::try_stream::TryStreamExt`

What do I do next?

Maybe you'd want to be using reqwest instead? It builds on top of hyper and can directly parse responses as JSON, for example.

I am upgrading to async await ... So I cant change crate.

The next version of reqwest will ship with async/await support, the alpha releases already feature it and are quite usable.

https://github.com/hyperium/hyper/blob/master/examples/echo.rs
https://github.com/hyperium/hyper/blob/master/examples/client_json.rs
I checked out the above, and it is now obvious to me that there is something wrong with my code.
Could it be coming from,  let response = client.request(request).await;

My Cargo.toml
[dependencies]
clap = "2.32.0"
colored = "1.7.0"
csv = "1.0.5"
hyper = "0.13.0-alpha.4"
hyper-tls = "0.4.0-alpha.4"
regex = "1.1.2"
serde_json = "1.0.39"
time = "0.1.42"
yaml-rust = "0.4.3"
linked-hash-map = "0.5.2"
futures = "0.3.1"
tokio = "0.1.15"
tokio-scoped = "0.1.0"
futures-timer = "1.0.3"
rustc --versionrustc 1.40.0-nightly (50f8aadd7 2019-11-07)
I am beginning to think that what I am going through could be from version mismatch

@janus You missed this body_mut(),  try it response.body_mut().try_concat().await.unwrap().to_vec().

@janus You missed this body_mut(), try it
use futures::stream::TryStreamExt;
response.body_mut().try_concat().await.unwrap().to_vec()

error[E0599]: no method named try_concat found for type &mut hyper::Body in the current scope
--> src/actions/request.rs:231:29
|
231 |         response.body_mut().try_concat().await.unwrap().to_vec()
|                             ^^^^^^^^^^ method not found in &mut hyper::Body
|
= note: the method try_concat exists but the following trait bounds were not satisfied:
&&mut hyper::Body : futures_util::stream::try_stream::TryStreamExt
&hyper::Body : futures_util::stream::try_stream::TryStreamExt
&mut &mut hyper::Body : futures_util::stream::try_stream::TryStreamExt
&mut hyper::Body : futures_util::stream::try_stream::TryStreamExt
hyper::Body : futures_util::stream::try_stream::TryStreamExt
= help: items from traits can only be used if the trait is in scope
= note: the following trait is implemented but not in scope; perhaps add a use for it:
use futures_util::try_stream::TryStreamExt;
error: aborting due to previous error
I have this the use futures::stream::TryStreamExt;
This issue I am having may be related to hyper  v0.13.0-alpha.4
https://github.com/hyperium/hyper/tree/v0.13.0-alpha.4/examples.
Please @fundon  could your try https://github.com/hyperium/hyper/blob/v0.13.0-alpha.4/examples/client_json.rs ? I would like to see your Cargo.toml file.

hyper = { version = "0.13.0-alpha.4", features = ["unstable-stream"] }

@janus You missed this body_mut(), try it
use futures::stream::TryStreamExt;
response.body_mut().try_concat().await.unwrap().to_vec()

error[E0599]: no method named try_concat found for type &mut hyper::Body in the current scope
--> src/actions/request.rs:231:29
|
231 |         response.body_mut().try_concat().await.unwrap().to_vec()
|                             ^^^^^^^^^^ method not found in &mut hyper::Body
|
= note: the method try_concat exists but the following trait bounds were not satisfied:
&&mut hyper::Body : futures_util::stream::try_stream::TryStreamExt
&hyper::Body : futures_util::stream::try_stream::TryStreamExt
&mut &mut hyper::Body : futures_util::stream::try_stream::TryStreamExt
&mut hyper::Body : futures_util::stream::try_stream::TryStreamExt
hyper::Body : futures_util::stream::try_stream::TryStreamExt
= help: items from traits can only be used if the trait is in scope
= note: the following trait is implemented but not in scope; perhaps add a use for it:
use futures_util::try_stream::TryStreamExt;
error: aborting due to previous error
I have this the use futures::stream::TryStreamExt;

@janus Enable the unstable-stream feature.
hyper = { version = "0.13.0-alpha.4", features = ["unstable-stream"] }

I am aware of this and it was enabled in the last build it still failed. It was because I enabled it that I have this output:
= note: the following trait is implemented but not in scope; perhaps add a use for it: use futures_util::try_stream::TryStreamExt;

@fundon
Please try one of the listed examples and see for yourself.

I just add to_vec() to the body. Everything is ok.
async fn fetch_json(url: hyper::Uri) -> Result<Vec<User>> {
    let client = Client::new();

    // Fetch the url...
    let res = client.get(url).await?;
    // asynchronously concatenate chunks of the body
    let body = res.into_body().try_concat().await?.to_vec();
    // try to parse as json with serde_json
    let users = serde_json::from_slice(&body)?;

    Ok(users)
}

$ cargo run --example client_json --features="runtime unstable-stream"

users: [
    User {
        id: 1,
        name: "Leanne Graham",
    },
    User {
        id: 2,
        name: "Ervin Howell",
    },
    User {
        id: 3,
        name: "Clementine Bauch",
    },
    User {
        id: 4,
        name: "Patricia Lebsack",
    },
    User {
        id: 5,
        name: "Chelsey Dietrich",
    },
    User {
        id: 6,
        name: "Mrs. Dennis Schulist",
    },
    User {
        id: 7,
        name: "Kurtis Weissnat",
    },
    User {
        id: 8,
        name: "Nicholas Runolfsdottir V",
    },
    User {
        id: 9,
        name: "Glenna Reichert",
    },
    User {
        id: 10,
        name: "Clementina DuBuque",
    },
]
sum of ids: 55

Use
    let mut res = client.get(url).await?;
    let body = res.body_mut().try_concat().await?.to_vec()

instead of
let res = client.get(url).await?
let body = res.into_body().try_concat().await?;

It's ok too.

Hyper depends on futures 0.3.0-alpha.19 not futures 0.3 so the stream traits do not line up.

So, Must hyper = { version = "0.13.0-alpha.4", features = ["unstable-stream"] } + futures 0.3.0-alpha.19. dont use futures 0.3 on current version.

Same problem, the compiler simultaneously recommends futures_util::stream::try_stream::TryStreamExt; and cannot use it:
error[E0432]: unresolved import `futures_util::try_stream`
 --> src/lib.rs:9:19
  |
9 | use futures_util::try_stream::TryStreamExt;
  |                   ^^^^^^^^^^ could not find `try_stream` in `futures_util`

error[E0599]: no method named `try_concat` found for type `&mut hyper::body::body::Body` in the current scope
   --> src/lib.rs:120:62
    |
120 |                         let body_bytes = response.body_mut().try_concat();
    |                                                              ^^^^^^^^^^ method not found in `&mut hyper::body::body::Body`
    |
    = help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope, perhaps add a `use` for it:
    |
1   | use futures_util::stream::try_stream::TryStreamExt;
    |

error: aborting due to 2 previous errors

Code is in https://github.com/klausi/rustnish/tree/hyper-await
Can anyone post a combination of cargo futures dependencies that is working right now? Would be super useful to be able to read bytes from a response body :-)

I am using only:
futures-preview = '0.3.0-alpha.19'

[dependencies.hyper]
version = '0.13.0-alpha.4'
features = ['unstable-stream']

and
use futures::stream::TryStreamExt;

And works just fine.

Ran into this also, you have to do as @orballo says, turn on the feature and use the preview version of futures

Not turning on the unstable-stream feature has bitten me a few times already, I hope streams can be stabilized soon. https://github.com/hyperium/hyper/issues/1920


Show spinner when opening/creating a project, take #2

Pull Request Description
This is almost the same as #6321, but it got reverted since it created an impactful regression.
To recap, this fixes #5505: A spinner with the Enso logo is now shown for most of the duration when opening and creating projects.\
The only new code is the last commit which ensure that it works when there is no project manager available.
Note that the value of the spinner is somewhat lessened with the new dashboard since some of the startup time is covered after clicking the play button in the dashboard but before opening the project.
With the old dashboard:
https://github.com/enso-org/enso/assets/607786/f357263b-8a88-4ef1-9ca7-ced99ca75a2b
With the new dashboard:
https://github.com/enso-org/enso/assets/607786/d9f99248-5830-43e0-a731-f2a6e0147908
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the Scala, Java, and Rust style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:

[ ] Unit tests have been written where possible.
[x] If GUI codebase was changed, the GUI was tested when built using ./run ide build.

Could you link the regression ticket, please? I want to better understand what changed between this and previous implementation take.
Could you link the commit with the changes between this and the previous implementation? In the PR description you've written "The only new code is the last commit which ensure that it works when there is no project manager available.", which is probably not the case anymore.

Could you link the regression ticket, please? I want to better understand what changed between this and previous implementation take.

This is the regression issue: https://github.com/enso-org/enso/issues/6708

Could you link the commit with the changes between this and the previous implementation? In the PR description you've written "The only new code is the last commit which ensure that it works when there is no project manager available.", which is probably not the case anymore.

It's this one: 8216a267eb8f293451e5a959975a57a16e14a9a6

After discussion with @farmaazon, we decided to merge this as is since it contains useful changes, but not close the original issue since it's not resolved yet.

@Procrat I've left a comment in the code but it's not displayed here:


Support unmanaged secrets

First thank you for this module, it is quite great!
I have use cases, where I need to prepare some AWS secrets, but I can't
have them set randomly or stored inside a shared file.
So I'm looking for a way to be able to enable lifecycle when I have such
use case. Unfortunately dynamic does not support lifecycle so this
is the solution I ended with.
In case of shared states, this would allow the secret to be initalized,
eventually with real secret values through terraform.tfvars, by a
first user, but would not prevent another user that don't have access
to the secrets to use the state.
module "secrets-manager-2" {

  source = "lgallard/secrets-manager/aws"

  secrets = [
   {
      name                    = "unmanaged-secret-kv-1"
      description             = "This is a key/value secret"
      secret_string           = "Changeme"
      recovery_window_in_days = 7
    },
  ]

  unmanaged = true

  tags = {
    Owner       = "DevOps team"
    Environment = "dev"
    Terraform   = true
  }

}

So, the idea would be to initialize the secret and then rotate outside Terraform, thus, avoiding other users to change the secret using Terraform?

Yes exactly. The secret resource would be created by someone that don't have necessarily access to the real secret., with this resource. Secret management itself would be handled outside of TF.

@fabio42. I merged and published your changes in release 0.3.0.
Thanks for contributing!


MultiStory pause not working

is there any way to pause the MultiStory ?

@Dipak-Complitech
Could you please provide us any form of code snippet or screen recording for the issue ?
Thanks


Add Dockerfile to allow for application execution isolated

close #45

Hi @jonbrohauge,
Thanks for the contribution. I have run in local and it works fine. :)
already mark as hacktoberfest-accepted.
Thanks
Hong


Passing the version flag in the query string results in a stale minified version that is not the latest.

Bug Report/Feature

What

Passing the version flag in the query string results in a stale minified version that is not the latest.
The requests from the following URLs produce the same string in Safari Version 14.0.3.
https://polyfill.io/v3/polyfill.min.js?version=3.103.0&features=Intl
https://polyfill.io/v3/polyfill.min.js?version=3.104.0&features=Intl
This is both a bug report as there may be more browsers that present the issue (browser/os specs below), and there may be an intermediate solution to print the version number in the minified responses.
Providing the version string in all responses would provide better transparency, and make it easier to screen shot and share issues such as this one.
Details

Bug Report Details
Issue was produced on Safari Version 14.0.3 (166<IP_ADDRESS>.7) on Mac OSX Version 11.2.3.
In this video, I empty caches before the request, then copy the response body into text files, and run a command line diff against those two files. The diff command should show changes between the two as Intl.DateTimeFormat polyfills were added in 3.104.0.
I was able to compare the results from the non-minified versions and validate that  Intl.DateTimeFormat are present in 3.104.0.
The issue feels like it could be on the CDN layer as adding flags=gated to both requests produces responses that are shown to have differences when comparing them. It's possibly that version is not part of the cache hit strategy for your minified requests.
Feature request Details
In order to better understand what version has been returned from the service request, can we add the version string to the minified comment header, similar to the non-minified responses?
/* Polyfill service v3.104.0 Disable minification (remove `.min` from URL path) for more info */

Looks like this might be on the polyfill-library instead: https://github.com/Financial-Times/polyfill-library/blob/329b48ac5308fe58dad10fe4a8700b6583b0d877/lib/index.js#L320

Pull request created: https://github.com/Financial-Times/polyfill-library/pull/1040


New page layouts

[x] with top and bottom full width area and 3 columns in the middle with the following proportions - 2/6/4
[ ] with top and bottom full width area and 3 columns in the middle with the following proportions - 2/5/3

Page layout with 2/6/4 proportions was added in Ticket #3405

Layout with 2/5/3 proportions is very close to the first one (2/6/4) and isn't so critical.


login/registration

login and registration did not work

@jayjovial Sorry, this project is no longer supported and will be marked as archived.

@stephanyan ok thanks, but i have been looking for a project like this,is there any you can recommend for me?

Maybe https://funkwhale.audio/ is what you're searching for


Device crashed due to bus fault while executing null work->handler in work_queue_main() and current thread is tcp_work

I've built webserver application using civetweb and running it on wifi interface(using infineon WHD) that uses zephyr network stack.
Zephyr version - 3.2.0
Hardware - STM32U575ZI_Q connected to wifi Murata 1DX module over SDIO interface
When I run my pytest suite that sends REST request consistently. It runs test cases where it opens TCP connection with the device, executes REST URI and closes TCP connection. This process repeats for all the test cases and at some point device crashes due to bus fault when work_queue_main() executes null work->handler. Following is the callstack when the device crashes:

It seems that something in tcp_workq causes this null handler scenario but I'm unable to find the exact root cause. Temporarily I've added the following workaround in work.c file just to bypass this null handler scenario(which is not good practice)

I have the following questions:

Can you provide some pointers on what could be the root cause or how to debug tcp_workq scenario that leads to null work->handler?
I understand that the workaround that I posted above is not recommended. This workaround helps us to avoid the device crash but we're not aware what impact it will have. Could you provide your inputs here?

Just and observation from your log that might indicate you have a bit of (kernel?) memory corruption, a valid HTTP header first line would end in something like HTTP/1.1, you have garbage after the slash in your debug output though

Can you reproduce this with the latest Zephyr version?

Cc @rlubos

It seems that something in tcp_workq causes this null handler scenario but I'm unable to find the exact root cause. Temporarily I've added the following workaround in work.c file just to bypass this null handler scenario(which is not good practice)

This looks like a stack overflow in the TCP workqueue, try increasing this value to see if it fixes it.

I tried to increase CONFIG_NET_TCP_WORKQ_STACK_SIZE and test. This reduces the probability of issue but doesn't completely fix it. The only difference this change makes is the device crashes little late. For example, if the device crashes after 15-20mins in normal cases then after increasing CONFIG_NET_TCP_WORKQ_STACK_SIZE the device will crash after an hour or so

It seems that something in tcp_workq causes this null handler scenario but I'm unable to find the exact root cause.

NULL work handler clearly seems like some memory corruption, but it doesn't have to be anything in the tcp_workq, it could be some other part of the code that causes the corruption. Such issues are tricky to identify and practically impossible to find w/o the application on the table with the debugger attached.
I suggest to enable STACK_SENTINEL and asserts and try to dig further.

@AshwiniMShinde-eaton any news on this? could the issue be in your own code?

@AshwiniMShinde-eaton any news on this? could the issue be in your own code?

We're working on it. We're trying to upgrade our wifi stack and test the same. We'll get back to you once we have some findings there

@AshwiniMShinde-eaton any news on this? could the issue be in your own code?

We're working on it. We're trying to upgrade our wifi stack and test the same. We'll get back to you once we have some findings there

@AshwiniMShinde-eaton please update us on this issue.

@AshwiniMShinde-eaton any news on this? could the issue be in your own code?

We're working on it. We're trying to upgrade our wifi stack and test the same. We'll get back to you once we have some findings there

@AshwiniMShinde-eaton please update us on this issue.

Sorry we didn't get chance to revisit this again as we were occupied with some other work. Will get back to you once we switch to working on this.

I saw a similar problem in TCP work. It also happened right after the socket was closed.
[00:12:38.227,000] <err> os:   Illegal use of the EPSR
[00:12:38.228,000] <err> os: r0/a1:  0x20018ef8  r1/a2:  0xe000ed00  r2/a3:  0x00000000
[00:12:38.228,000] <err> os: r3/a4:  0x00000001 r12/ip:  0x00000000 r14/lr:  0x08046119
[00:12:38.228,000] <err> os:  xpsr:  0x60000000
[00:12:38.228,000] <err> os: Faulting instruction address (r15/pc): 0x00000000
[00:12:38.228,000] <err> os: >>> ZEPHYR FATAL ERROR 35: Unknown error on CPU 0
[00:12:38.229,000] <err> os: Current thread: 0x1fff0108 (tcp_work)

I saw a similar problem in TCP work. It also happened right after the socket was closed.

Did you try this proposal ?

I saw a similar problem in TCP work. It also happened right after the socket was closed.

Did you try this proposal ?

Not yet, I'll give it a try.

Hello, I have this crash too and did some investigations which led me to understand the problem.
The crash happens when tcp_resend_data is called by the send_data_timer with the following values in the connection structure:

in_retransmission = true
send_data_retries < CONFIG_NET_TCP_RETRY_COUNT
send_retries = 0

In that case we have the following chain of execution in tcp_resend_data: tcp_send_data() -> tcp_out_ext() -> tcp_send_process_no_lock() -> tcp_conn_close(), which causes the conn structure to be blanked by a memset(conn, 0x00) call.
The problem is that after calling tcp_send_data(), the tcp_resend_data function resumes its execution and keeps using the conn struct like it was still valid.
What causes the fatal crash is the call to k_work_reschedule_for_queue(send_data_timer): at expiration of the timer the conn->send_data_timer.work.handler which has been set to NULL is called, and kaboom ;-)
I'm able to reproduce this issue in less than 30s when doing socket connect / disconnect in a loop on a specific service which is behind a load balancer, not sure why it affects the working of the TCP stack, but the good thing is that I can test proposed fixes.

Thanks @paussems for the detailed analysis. The issue seems quite tricky to reproduce, I've tried hard today but with no success. But looking at the code, based on the information you provide, it's hard to deny that the problem exists (we should definitely avoid dereferencing the TCP connection while it can still be used from the same context).
Thinking about the solution for this issue, I think that it'd be reasonable to move the actual TCP context deallocation to a separate work item. As @talih0 suggested in some other thread, that should also prevent any potential race with any other scheduled work item, as we'll be 100% certain then, that any other pending work will be removed from the queue when canceled. I'll try send a fix proposal soon.

Hi @rlubos , I have a minimal project for ESP32 which reproduces the problem on https://gitlab.com/esnah/zephyr-59752

@paussems Thanks for the additional input. I didn't manage to reproduce exactly the issue, but with some ugly tweaks with artificial packet loss and bogus delays in the TCP work handlers I was able to finally encounter the race, so I had something to verify the results.
I've submitted https://github.com/zephyrproject-rtos/zephyr/pull/65888 with the solution described earlier, we now submit a dedicated work to release the TCP context, to avoid race with other work handlers. Seems to help nicely in the test scenario I've created. Please give it a try and tell if it solves the issues you observe as well.

I've submitted #65888 with the solution described earlier, we now submit a dedicated work to release the TCP context, to avoid race with other work handlers. Seems to help nicely in the test scenario I've created. Please give it a try and tell if it solves the issues you observe as well.

Thanks @rlubos for looking into this issue so quickly. I'm running the test program with #65888 applied as we speak, and it's still running fine after a couple of minutes, whereas it crashed within 15s just before I applied the patches.
I have some errors once in a while in my logs, but they do not make the device crash.
[00:09:39.128,000] <inf> net_websocket_client_sample: ...
[00:09:40.368,000] <err> net_tcp: net_pkt alloc failure
[00:09:40.493,000] <err> net_tcp: conn: 0x3fffaa7c packet allocation failed, len=53
[00:09:40.493,000] <err> net_tcp: TCP failed to allocate buffer in retransmission
[00:09:40.698,000] <err> net_tcp: conn: 0x3fffacd4 packet allocation failed, len=53
[00:09:40.698,000] <err> net_tcp: TCP failed to allocate buffer in retransmission
[00:09:40.804,000] <err> net_tcp: conn: 0x3fffaf2c packet allocation failed, len=53
[00:09:40.804,000] <err> net_tcp: TCP failed to allocate buffer in retransmission
[00:09:43.368,000] <err> net_websocket_client_sample: connect: -1
[00:09:43.369,000] <inf> net_websocket_client_sample: ...

I will leave it running overnight and I'll report tomorrow morning (CET TZ), but so far it's looking very good !

Hello again @rlubos, the device is still running with #65888 after 15h of continuous connects/disconnects on the setup where I could reproduce the issue, so on my side it's confirmed that your new release implementation fixes the race condition.
Have a good day!

Excellent @paussems, thank you


add new python algorithms

There is no changes in the project file QuantConnect.Algorithm.Python.csproj that reflects the addition of these new files. This is required so that they can be displayed at Visual Studio Solution Explorer.


Use real format types in fake data generation

Use real format PUIDs, format names, versions, etc. in the fake data generator.

PR ready for review: https://github.com/artefactual-labs/AIPscan/pull/298


32 watch permissions are required by fluentbit

fixes #32

CentOS 8 does not have the watch permission available, hence the build fails.

I added the watch permission in the class file, for both centos8 and centos9.


Error message upon verify related to setTimeStruct in ESP32Time.h

I attempted to integrate this library into my latest Adafruit Matix Portal M4 project and I am getting an odd error. I went back to basics and attempted to run the same code in the esp32_time.ino example and I get the same error.
In file included from D:\Arudino\esp32_time\esp32_time.ino:3:
c:\Users\marti\Documents\Arduino\libraries\ESP32Time/ESP32Time.h:37:22: error: 'tm' has not been declared
37 |   void setTimeStruct(tm t);
|                      ^~
c:\Users\marti\Documents\Arduino\libraries\ESP32Time/ESP32Time.h:38:3: error: 'tm' does not name a type; did you mean 'Pm'?
38 |   tm getTimeStruct();
|   ^~
|   Pm
exit status 1
Compilation error: exit status 1
After a bit of searching I can't find any other solutions, hopefully someone can assist please.

This is a wrapper library for ESP32 time functions, it relies on time libraries used by ESP32 core
https://github.com/fbiego/ESP32Time/blob/56c7cca5838249db5bff3cbc4f67e7da0f91b126/ESP32Time.cpp#L26-L27
Compatibility with other Arduino cores is untested

Thank you for getting back to me quickly. I'll head over to Adafruit and start with Circuit Python which seems to be what they prefer.


feat(input,textarea,datepicker,chip-input): focus api

Add a focus() and blur() public API to

ux-input
ux-textarea
ux-datepicker
ux-chip-input

Compatible with the Aurelia built-in focus custom attribute.

@bigopon what's the status on this PR from your point of view ?

@ben-girardet as for the direction, I think it's good, as it enhances the custom element hosts to have similar API to native inputs. For the details of the focus behavior, I dont think we will have clear answer to all edge and corner cases, better let them with some consistency and then later draft out a better specs if we see any issues. For now, I think focusing on the underlying textbox is good enough. Let me know when you need a review for the code, as we don't have tests or specs, it will feel uneasy, but it should be ok if we continue the course of this until that point.

@bigopon You can go ahead with a code review. As you mention, it probably doesn't cover all cases, but from my experience (already using this code) it already greatly improve the focus api.


Release python base sdk v0.3.5

Adds options that will be used in the lambda SDK.

@medikoo ready for review 🙏


Comparison of 2 records that have size field that equals undefined fails with exception

To reproduce just run:
const C = Immutable.Record({
    size: undefined
});

var a = new C({});
var b = new C({});

Immutable.is(a, b);

Expected: it must run well
Actual: it fails with Uncaught TypeError: undefined is not a function which points to this line: https://github.com/facebook/immutable-js/blob/master/dist/immutable.js#L3885
if (a.size === undefined) {
  if (b.size === undefined) {
    a.cacheResult(); // <--- this line
  } else {
    flipped = true;
    var _ = a;
    a = b;
    b = _;
  }
}

Thanks for the report!

I've taken a quick look at this. The problem is that the supplied size key is clobbering the size key that immutable-js is adding to the prototype. This throws if set to undefined, but if it was set to a valid size (that is not the actual size of the collection) it could cause a bunch of more subtle errors. I don't have any good ideas here. Maybe the best thing is disallowing the use of size as a key name for Record Types?

That's close to what I plan to do.
I also want to ensure that none of the other prototype methods are affected for the same reason, so I may use the prototype as a blacklist. Rather than throwing an invariant, I'll probably just not assign property descriptors for those keys, instead requiring that you access those keys via the get() method.
Either way, this will be a breaking change that will need to go into the next major version bump of immutable.js, and we may also need to include some way to opt out of this behavior in the case that you want to clobber the prototype.
In the short term, I will look into a way to mitigate the immediate issue reported here.

Closed because this immediate issue should be resolved in https://github.com/facebook/immutable-js/commit/6b6074677ae986c92c793673ceb958bc130a76c2 but the larger issue of clobbering prototype property keys still exists.

Tracking the larger issue in #377


fix: adding additional domains to the allowlist

me.com is owned by apple
ymail.com is owned by yahoo
zoho.com is also a legit domain

Thank you


feat: Add support for generating OpenQASM from circuits

Issue #, if available:
Description of changes:

Adds the ability to generate OpenQASM from Braket circuits.
The implementation doesn't cover every supported gate/result type/noise yet. It only covers the following components:

Compiler Directives
Circuit
Gates (Only Rx)
Instruction
Noise (Only BitFlip)
Observables (Only I and Hermitian)
Result Types (Only Expectation)

Testing done:

tox -e unit-tests succeeded.
Validated that the generated circuits can be executed against the service.

rom braket.circuits import Circuit
from braket.circuits.serialization import IRType
from braket.aws import AwsDevice

c = Circuit().rx(0, 0.15).rx(7, 0.3)
r = c.to_ir(ir_type=IRType.OPENQASM)
print(r.source)
d = AwsDevice("arn:aws:braket:::device/quantum-simulator/amazon/sv1")
res = d.run(r, shots=10).result()
print(res)

Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[x] I have read the CONTRIBUTING doc
[x] I used the commit message format described in CONTRIBUTING
[x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This seems complex enough that it warrants an integ test for the stuff we have. What do you think?


Add tests asserting that newlines must appear after table names

Newlines need to appear after table names in TOML. This library rejects TOML where this is not the case, as expected, but I could not find any tests ensuring this (apologies if I'm mistaken!) so I added some :)

Coverage decreased (-0.2%) to 87.842% when pulling e955e7dd17c3dae7234ecf4109a1f6e412ffc7fd on zofrex:test-no-newline-after-table into 36d1ecf29f5b4e8ba86dc9c4d6d4342a97e68ce9 on joelself:master.

Looks good to me. Most of the files in assets/valid and assets/invalid come from BurntSushi/toml-test so you might want to consider submitting these tests there too.


Publish to live

@ajcvickers @JeremyLikness @smitpatel Thanks for merging the PR to mater, could you also please approve merge it to live. Thanks.

@JeremyLikness  @kenanlv - Should this be applied to Microsoft.Data.Sqlite API docs too? Repo here - https://github.com/dotnet/Microsoft.Data.Sqlite.ApiDocs

@JeremyLikness @kenanlv - Should this be applied to Microsoft.Data.Sqlite API docs too? Repo here - https://github.com/dotnet/Microsoft.Data.Sqlite.ApiDocs

@smitpatel Thank you for mentioning this. Taxonomy for the Microsoft.Data.Sqlite API should have some overlap with the entity-framework, but I will need to check with @sudeepku for the next step. Thank you.


Remember Main sidebar collapsed state

When collapsing the main left sidebar on a given page, how can the collapse state be 'remembered' for the other pages when they are loaded?
Removing the collapse class in the <body> tag works, but shows first open then quickly closed, which is less than ideal.

I've recently had to use AdminLTE for a project and came across this but could not find a solid front-end solution. The closest I got was disabling CSS animations temporarily and then applying the .sidebar-collapse class to the body. My solution is below. Note that this only works with localStorage!
<!-- Custom styles to disable animation temporarily (inlined for show) -->
<style>
/* Probably doesn't need all these prefixes but oh well */
.disable-animations, .disable-animations * {
  /* CSS transitions */
  -o-transition-property: none !important;
  -moz-transition-property: none !important;
  -webkit-transition-property: none !important;
  transition-property: none !important;
  /* CSS transforms */
  -o-transform: none !important;
  -moz-transform: none !important;
  -webkit-transform: none !important;
  transform: none !important;
  /* CSS animations */
  -webkit-animation: none !important;
  -moz-animation: none !important;
  -o-animation: none !important;
  animation: none !important;
}
</style>

<!-- AdminLTE JavaScript -->
<script src="AdminLTE/dist/js/app.js"></script>

<!-- Custom scripts loaded AFTER AdminLTE JavaScript (inlined for show) -->
<script>
$(function ($) {
  var $body = $('body');
  // On click, capture state and save it in localStorage
  $($.AdminLTE.options.sidebarToggleSelector).click(function () {
    localStorage.setItem('sidebar', $body.hasClass('sidebar-collapse') ? 1 : 0);
  });

  // On ready, read the set state and collapse if needed
  if (localStorage.getItem('sidebar') === '0') {
    $body.addClass('disable-animations sidebar-collapse');
    requestAnimationFrame(function () {
      $body.removeClass('disable-animations');
    });
  }
});
</script>

Interesting approach! I didn't think of going the CSS route. The following is a javascript based solution in case somebody may find it useful.
Basically I went to the original <body class="hold-transition skin-blue sidebar-mini sidebar-collapse">  tag from the template and added the 'sidebar-collapse' class, so the sidebar will always load collapsed by default.  Next I added the following script snippet to each web page, just before the $(document).ready() if there is one (but not inside of it).
This takes care of the jittery animation, since it now expands when necessary, providing for a reasonably natural feel.
<script>
  if (Boolean(sessionStorage.getItem("sidebar-toggle-collapsed"))) {
    $("body").removeClass('sidebar-collapse')
  }

  $('.sidebar-toggle').click(function() {
    event.preventDefault();
    if (Boolean(sessionStorage.getItem("sidebar-toggle-collapsed"))) {
      sessionStorage.setItem("sidebar-toggle-collapsed", "");
    } else {
      sessionStorage.setItem("sidebar-toggle-collapsed", "1");
    }
  });

  $(document).ready(function() {
    // Document ready code here
  }
</script>

Hi, I have tried both solutions and both have the animation on page refresh that is not natural.
For example
Using css solution when the sidebar = 0  and hit refresh F5
we can see a very quick animation mini go to full then get back to mini
Using javascript solution when the sidebar-toggle-collapsed =1 and hit refresh F5
we can see a smooth animation full go to mini then go back to full
Is there a way not to see an animation on refresh?
Thanks

Hi, and thanks for this. I used your idea with session storage and came up with this code that doesn't display animations. Trick is to handle sidebar-collapse very early, just after the body tag is loaded. This way there is no need to use CSS tricks...
<body class="skin-black sidebar-mini">

  <script>
    (function () {
      if (Boolean(sessionStorage.getItem('sidebar-toggle-collapsed'))) {
        var body = document.getElementsByTagName('body')[0];
        body.className = body.className + ' sidebar-collapse';
      }
    })();
  </script>
  ...

@KLuka  I'm using your solution with Localstorage and this is working fine. Thanks

You can perform an ajax to the server and save a session of the sidebar state... then render it on the body tag via php

You can hide this ugly transition with add the class hold-transition and remove it after its done 😄
@ajcastro not every one use php and sometimes its easier to use localstorage.

Thanks for the info!
Yeah that solution is only for those who use php or server-side rendering.

@REJack  could you point us where to add and remove the hold-transition
Thanks

I've created already a fully working script look at #1240 (comment)
regards REJack

Thanks I will try to adapt to @KLuka version because I do prefer to use LocalStorage


Ability to delay dragging event by X milliseconds

Bug, feature request, or proposal:
Feature request
What is the expected behavior?
Set property to delay dragging event by X milliseconds
<div cdkDrag cdkDragDelay="2000">Hold for 2 seconds to move this item</div>
What is the current behavior?
No option to prevent dragging on initial touch rendering this very hard to use on mobile.
(This is certainly not helped by the fact that cdkDrag elements disable mobile scroll events)
What is the use-case or motivation for changing an existing behavior?
Currently click events immediately trigger leading to unintended re-ordering. Many sites and native devices solves this issue by not starting the drag event unless user have clicked and hold the object for a short amount of time.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
@angular/cdk: 7.0.2

The CdkDrag directive only starts dragging after a certain threshold, however the default of  5px might too low for a mobile device. You can try to set a different threshold through the CDK_DRAG_CONFIG provider.

I am not sure this will solve the issue regarding touch devices, as you are scrolling down content it is unfortunate to reorder up random elements, and not sure any amount of distance threshold will resolve this. I believe that #13895 will make this Drag'n'Drop usable for smaller touch devices, but for the next iteration, I still think implementing an optional time-based threshold would make it act more intuitive to the users and make it behave more like native implementations.

I +1 this idea. On the other hand a custom solution could probably be created once #13722 is merged. You'd then just manually need to handle the long-press and after that enable the dragging of that element.
Or you could use separate drag handles that are only active and visible on mobile devices.

+1 this feature.
Right now it is possible to disable drag, so one could just disable it until a certain time (!) threshold is passed. But unfortunately enabling doesn't work reliable, sometimes the dragging starts sometimes not. So I think a built-in time delay (aka longpress) would be very helpful for a lot of use cases.


Doc.Ms readme updates on ms.service and ms.author

The readme files (Overview in Doc.MS) update through the release pipeline.
We currently hard-coded the ms.service to azure and ms.auther/author to maggiepint.
Need to investigate the best source of these inputs.
Proposal:
For ms.service

Use package name as ms.service.
Use Taxonomy metadata for ms.service.
For ms.author\author
People who triggered the pipeline will be the author.
Dedicated person for each languages.

This is done on automation.


fix(nx-aws-cdk): implement cdk build executor to exclude lambda runti…

…me from bundling
Initially cdk app used default esbuild executor that was trying to build lambda runtime apps. This prevents from using feature not supported by cjs giveen that cdk app is build using that format.
fix #52

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.66%. Comparing base (72027af) to head (63e0e30).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #59      +/-   ##
===========================================
+ Coverage    98.62%   98.66%   +0.03%
===========================================
  Files           33       32       -1
  Lines         1238     1269      +31
  Branches       242      240       -2
===========================================
+ Hits          1221     1252      +31
  Misses           1        1
  Partials        16       16

Flag
Coverage Δ

cdk
98.66% <100.00%> (+0.03%)
:arrow_up:

create-aws-cdk-app
98.66% <100.00%> (+0.03%)
:arrow_up:

nx-aws-cdk
98.66% <100.00%> (+0.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/92387

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/92563

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/93823

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/94914

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/99365

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/114444

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/119834

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/121535


Porting all systems to will-os as well as major refractor and restructuring of messaging.

Nice, sorry i havent had time to work on this much

Npnp. It's all good lmao, I've got nothing else to do rn so it's been a fun hobby. I'm teaching myself android development as of recently so I've backed off on development. With a few exceptions most of the framework stuff is dealt with. Any new LED animations or OLED animations will probably have to be made by you or adrien.


cmd/vet: warn about concurrent modification of a map (values added in a for loop)

(using https://github.com/golang/go/issues/43698 as a template)
Related issues: https://github.com/golang/go/issues/9926, https://github.com/golang/go/issues/35239
Per the Go specification of for loops, within the For statements with range clause section, it states:

If a map entry is created during iteration, that entry may be produced during the iteration or may be skipped. The choice may vary for each entry created and from one iteration to the next.

I expect that package authors might not be expecting the non-deterministic behavior that comes with concurrent modification. This can lead to unexpected bugs and behavior. I believe Java goes so far to even throw a runtime exception.
Playground example
Real-world example
I propose that cmd/vet should emit a warning when:

a map is iterated over using a for statement
the map has elements added during iteration

I think  must be cmd/vet tool issue a warning in such situations to prevent programmers from changing the map simultaneously during iteration. This warning can help increase the accuracy and predictability of the code and reduce bugs associated with this behavior.

Within a single goroutine, adding to or deleting from a map while iterating over it is not always wrong, so we definitely would not want vet to report a diagnostic in that case. Therefore, I will close this issue.
With multiple goroutines, it is always a mistake to modify the map concurrent with iterating over it. It would be great if vet could reliably report a diagnostic for this (and other) data races. Unfortunately, detecting such races with only an ALGOL-like type system is one of the great unsolved (or unsolvable) problems of computer science.


Add a delete transform

What's up?
Add a delete transform to delete data.
Example
from employees
filter end_date < @2021-01-01
delete

It would translate into:
DELETE FROM employees WHERE end_date < '2021-01-01';

OK, let's roll this into https://github.com/PRQL/prql/issues/1092. I agree it would be useful — it's a big extension, though. The semantics are more different across dialects, and we would need to be much more risk averse given the bad outcomes from making a mistake.

There could be a lint for this too:
Bad query
Delete without filter!
from employees
delete

Good query
Delete with filter of course!
from employees
filter end_date < @2021-01-01
delete


fix(kit): fix LineClamp spits ChangesAfterChecked

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows Conventional Commits
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Other... Please describe:

What is the current behavior?

Closes #404
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This issue is deeper there, this only fixes one ExpressionChanged and then another one pops up. I need to take a closer look


rank_zero_only removal violate backward compatibillity

cc @borda @justusschock

Can you provide more details of what broke exactly and in which version? We might have made a mistake. In that case we can add it back in a bug-fix release.

hi @carmocca this issue seems to be related to several issues with scripts hosted by CompVis which import rank_zeo_only, so I'll add some info rather than open a new issue.
After the last update (sometime around Nov 1st), importing rank_zero_only from 'pytorch_lightning.utilities.distributed' was causing an ImportError. from pytortch_lightning/utilities/distributed.py
A temporary solution is importing using this line instead:
from pytorch_lightning.utilities.rank_zero import rank_zero_only
I'm not sure what the permanent solution is, this Github stuff is new to me. It would be nice to get a suggestion from you guys or to bug fix in the next update. More details on this problem are documented here

Hi @visoutre. Thanks for the description.
I've opened a PR making the modification to the CompVis repository: https://github.com/CompVis/taming-transformers/pull/190. You can also make this edit in your local installation to unblock you using 1.8.0 in your work.
These functions had been deprecated since version 1.6.0, to be removed in 1.8.0. It's unfortunate that this had not been updated before. To alleviate the confusion, I have opened a PR here to provide the user with a better message on what to do if this happens: #15569

@carmocca Sounds good, thank you!
Is a pull request something I can do as well? CompVis has 1 more script using the old import

I left comments in an exisitng PR for the stable diffusion repo: https://github.com/CompVis/stable-diffusion/pull/451

Thanks you guys


How do we get graphs such as 'AssA bs DetA' ?

Like Kitti dashboard, How do we get graphs such as 'AssA bs DetA', 'AssPr vs AssRe', 'DetPr vs DetRe', and 'HOTA(0) vs LocA(0)'?
please, let me know a python script.

https://github.com/JonathonLuiten/TrackEval/blob/master/scripts/comparison_plots.py


Add root and data/ as PR template paths

Overview
Add root and data/ as default PR template paths, in addition to .github/. These are common paths mentioned in the docs for creating PR templates.
Test Plan
Created a test repro with pull_request_template.md in the root and verified that it's picked up when calling av pr create
❯ go run ./cmd/av -C /Users/andrew/dev/projects/test pr create

%% Creating pull request for branch 'foo'
%% Lines starting with '%%' will be ignored and an empty message aborts the
%% creation of the pull request.

%% Pull request title (single line)
Hello world

%% Pull request body (multiple lines)
A test PR template

%% This branch includes the following commits:
%%     8e34ff9    Hello world

fixes #219

Thank you for this! Sorry for the slow review over the holidays. I made a minor change to put the directory in the outer loop since that matches the order of the path.
Let's ship it! 😸


Handle errors when starting Subscriber and Publisher

We aren't handling errors when the Publisher or Subscriber is started.
For example, starting up the Ably SDK can throw an error that will crash our SDKs. For now there is force try used in the ecample apps.
This is the iOS version of the ably/ably-asset-tracking-common#10
┆Issue is synchronized with this Jira Bug by Unito

I'm not sure if handling ARTRealtime exceptions are even possible with the current codebase. That's because ARTRealtime doesn't throw any exception on init. I know it's done in Android. They could do this because they manage to throw exceptions in the AblyRealtime initialiser cascade (HERE and HERE)
To be honest, I have no idea how to solve it in AAT Swift (if it's even possible).
WDYT @lawrence-forooghian @ben-xD @maratal @QuintinWillison?

Isn't it closed in https://github.com/ably/ably-asset-tracking-swift/pull/132 ?

Isn't it closed in #132 ?

I'm not sure, there is only presence failure managed:
func start(completion: @escaping ResultHandler<Void>) {
        // Trigger offline event at start
        delegate?.subscriberService(sender: self, didChangeChannelConnectionStatus: .offline)
        channel.presence.subscribe({ [weak self] message in
            logger.debug("Received presence update from channel", source: "AblySubscriberService")
            self?.handleIncomingPresenceMessage(message)
        })

        // Force cast intentional here. It's a fatal error if we are unable to create presenceData JSON
        let data = try! presenceData.toJSONString()

        channel.presence.enter(data) { error in
            guard let error = error else {
                logger.debug("Entered to channel presence successfully", source: "AblySubscriberService")
                completion(.success)
                return
            }

            logger.error("Error during joining to channel presence: \(String(describing: error))", source: "AblySubscriberService")
            completion(.failure(error.toErrorInformation()))
        }

        channel.subscribe(EventName.raw.rawValue) { [weak self] message in
            logger.debug("Received raw location message from channel", source: "AblySubscriberService")
            self?.handleLocationUpdateResponse(forEvent: .raw, messageData: message.data)
        }

        channel.subscribe(EventName.enhanced.rawValue) { [weak self] message in
            logger.debug("Received enhanced location message from channel", source: "AblySubscriberService")
            self?.handleLocationUpdateResponse(forEvent: .enhanced, messageData: message.data)
        }
    }

Ok, I've finished code reviewing and in my opinion, the Ably SDK failures are managed and forwarded to AAT Swift. Below I pointed out the places in code where they are managed.
Publisher
https://github.com/ably/ably-asset-tracking-swift/blob/0885a04f729964d3b396a0f5e735b7ae128b2ef6/Sources/AblyAssetTrackingPublisher/Services/DefaultAblyPublisherService.swift#L63-L69
https://github.com/ably/ably-asset-tracking-swift/blob/0885a04f729964d3b396a0f5e735b7ae128b2ef6/Sources/AblyAssetTrackingPublisher/Services/DefaultAblyPublisherService.swift#L97-L103
https://github.com/ably/ably-asset-tracking-swift/blob/0885a04f729964d3b396a0f5e735b7ae128b2ef6/Sources/AblyAssetTrackingPublisher/Services/DefaultAblyPublisherService.swift#L131-L137
https://github.com/ably/ably-asset-tracking-swift/blob/0885a04f729964d3b396a0f5e735b7ae128b2ef6/Sources/AblyAssetTrackingPublisher/Services/DefaultAblyPublisherService.swift#L182-L188
Subscriber
https://github.com/ably/ably-asset-tracking-swift/blob/0885a04f729964d3b396a0f5e735b7ae128b2ef6/Sources/AblyAssetTrackingSubscriber/Services/DefaultAblySubscriberService.swift#L49-L55
https://github.com/ably/ably-asset-tracking-swift/blob/0885a04f729964d3b396a0f5e735b7ae128b2ef6/Sources/AblyAssetTrackingSubscriber/Services/DefaultAblySubscriberService.swift#L77-L83
https://github.com/ably/ably-asset-tracking-swift/blob/0885a04f729964d3b396a0f5e735b7ae128b2ef6/Sources/AblyAssetTrackingSubscriber/Services/DefaultAblySubscriberService.swift#L160-L166

So this issue needs some clarification then IMHO.

If you're happy that this has been covered already then we can close this issue. 😁


feat: implement jupiter as a swapper

Description
Implementing the Jupiter swapper:

We are delegating the fee estimate at quote time to jupiter as they are building the TX instructions, it's safer and more opti in term of execution time
We need to use the wrapped SOL assetId instead of the SOL, jupited is unwrapping and wrapping directly in their program
Added affiliate fees account and BPS
Selecting wrapped sol shouldn't be possible as Jupiter is using it as underlying asset, if we send the wrapped sol balance to the Jupiter API, it will consider we want to swap SOL (as a follow up, we could display somewhere on the wrapped sol asset page or swapper that the user can unwrap these wrapped sol by clicking on a button)
⚠  Waiting for the DAO fee address for affiliate

Issue (if applicable)

closes #8017
Risk
High because swapper but behind a feature flag

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Try to do a swap from SOL to any SPL token
Try to do a swap from SPL to SPL
Try to do a swap from SPL to SOL
Try all of those but with a manual receive address (SPL to SOL shouldn't provide a quote because it's not effectively supported by Jupiter (it leave some wSOL in the receive address which is not acceptable for us))
Please try to swap to fresh accounts, and send again so it already have an associated token account, it's 2 different mechanisms, also try to swap a token you never had in your wallet
Try to swap some Token2022 tokens too (catwifhat is one of those), specially with a manual receive address
Smoke test swapper but shouldn't change anything to the rest

Engineering
n/a

Operations
n/a

[x] :checkered_flag: My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)
SOL to SPL

SPL to SOL

https://jam.dev/c/ce54f3bb-43f1-4e1f-9f44-c8b44a19fb73
SPL to SPL
⚠ It was a high volatility SPL token, I had to increase the slippage tolerange
https://explorer.solana.com/tx/3jfq6B3z44Y7ffJxfVm2wRAKFJMba8fANUitHSguzmiKgb8NYfyRfWRHyqvokxHbRe8Qi5mUyuESoAuUEZzwTau5

https://jam.dev/c/16c8e5f0-d5e2-4530-865b-b324a6980e25
TX history

Txs links
https://explorer.solana.com/tx/23xAVVo18sgD2ykyqH5Kx9C37j6bLNjbFXi2rRW4ge5YArm1ywsTFGXKzSRmAQV6Dx13GnXZP5W7f1UNjmrAqDau
https://explorer.solana.com/tx/5k2r33Dd2oPKf5NESmQZz2G2fQ23wSy7xfL82PhCKwZuT5kojmynuHrVDy3uzhsf2UFq13wKjcvJMr61cdsGDGBL
https://explorer.solana.com/tx/2ucg29ZHH58uVZ9MCbE3VCCfwgHVdcozcxG4NfELDmTQTew4T6HQKh6E8eBx7Xr12K2xjZEEHpHDfdi1fQxg7Tyv
https://explorer.solana.com/tx/4XgfBYeqrn5pq2vTGmYrktYmgii1EiUXR7vZNzmULNNQgePMQVMKZsVWPbChURtUrYN9w8cD2aFteVtP1fCet8LV

@gomesalexandre we should be good for another review/runtime test 🙏

I disabled explicitly swapping between wrappedSOL to any other asset and any asset to wrappedSOL as it's considered as SOL from the Jupiter point of view, I updated the PR description because we may need to provide an unwrap feature to our users as Jupiter does
Fixed all the last comments

⚠ I can't reproduce the USDC => SOL and SOL => USDC bugs, I tried a couple of swaps and none of them was not picked by the mempool, all the swaps were successful with good rates
q1 @gomes : Also tried to wait around 40 minutes after fetching the quote, it did fail, so I decided to fetch the prices again in the getTradeQuote handler in [5780800] (https://github.com/shapeshift/web/pull/8120/commits/578080067d966c0b382860fda2c36afef6621d92)
Can you please guys test again and tell me if you see any more flaky behaviors?
q2: From the Jupiter point of view, the list is not so big: Update to be acceptingAuto, Default, Custom, add a prod acceptAuto`, that should be enabled for the jupiter swapper
Ensure all mathematics done with slippage are handling the "auto" mode, specially for the jupiter swaper
But please, we should try this in a follow up if we really want to, not on this particular PR which starts to be big

Stamping as I ended up with the simulation failed on Phantom / Tx not broadcasted to the mempool only once, and couldn't repro after (which is why there is none in this Jam) despite many attempts). E2E testing below:
https://jam.dev/c/4bae293f-4fb2-47eb-85ab-1b53d231642e
Still noticing some Txs rarely failing for a diff. reason, though increasing slippeedge seems to solve it, so not too concerned about this as we will fast-follow with auto-slippage (#8193)
https://explorer.solana.com/tx/ajy2v17CFGZiuXvwC8NvKZqDeeeqgYLtGww39aRXBREwH4Bo9o2ZDGz859Fwy4SmKwu5GrUFHhjd59p6UD9XAHq
@NeOMakinG if you feel like it as a fast-follow, the ETA as " ms" where x < 100 is still looking very odd to me, looks like it got lost in translation in previous review (https://gist.github.com/gomesalexandre/bbf9f37e179b1ecc31e7505171ed08bb) but would be nice to tackle as a one-liner fast-follow, or in this PR if you feel like it, to make it no ETA similar to most EVM swappers (see 0x and Portals in the screenshot below missing it altogether, since swap is done within a block i.e effectively instantly, vs. Jup showing some ETA in the realm of ms):

Removed the time for jupiter in 561cd08


Convert dockertools from Docbook to CommonMark

This issue tracks the conversion of /doc/builders/images/dockertools.xml from Docbook to CommonMark per RFC 72.
If you intend to work on this conversion, please comment below!
Conversion instructions

Comment here that you intend to work on it. (Please also post if you stop working on it.)
Checkout a new branch of nixpkgs master.
Edit doc/builders/images.xml: change dockertools.xml to dockertools.section.xml.
Rename doc/builders/images/dockertools.xml to dockertools.section.md.
Convert the contents from Docbook to CommonMark. Follow conversion best practices. Use existing .md sections for inspiration.
Use nix-build from the doc/ folder to build the manual.
Preview the manual on your computer at http://<IP_ADDRESS>:8000/manual.html after running from doc/ folder:

nix-shell -p python3 --run 'python3 -m http.server --directory ./result/share/doc/nixpkgs'

When it looks good, submit a PR and reference this issue.

Hi @ryantm, I'd like to work in this issue. First one with documentation so I will probably need to understand a few things first.

@bryanasdev000 Thanks, let us know if you need help!

Hi @bryanasdev000, thanks for picking this up. Are you still working on this? If you're stuck, you could create a draft PR so someone can help, or if you've changed your mind that's also ok.

Hi @bryanasdev000, thanks for picking this up. Are you still working on this? If you're stuck, you could create a draft PR so someone can help, or if you've changed your mind that's also ok.

Hi @bryanasdev000, thanks for picking this up. Are you still working on this? If you're stuck, you could create a draft PR so someone can help, or if you've changed your mind that's also ok.

Hi @roberth! Sorry for late reply.
I worked a little bit, on and off during the holidays, I do not finished yet, I had some problems during the build of the documentation, but from what I read (pandoc output) I made some mistakes during the file conversion.
For now, I didn't commit, It's on my personal computer only.
As the week is a little difficult, I'll see if I finish it at the weekend.
(Maybe I should have asked for this issue just now, just see 14 days ago and I was like "What ?! That was 2 weeks ago ?!" LOL)
Thanks for asking!

Hi @bryanasdev000, thanks for picking this up. Are you still working on this? If you're stuck, you could create a draft PR so someone can help, or if you've changed your mind that's also ok.

Hi @roberth! Sorry for late reply.
I worked a little bit, on and off during the holidays, I do not finished yet, I had some problems during the build of the documentation, but from what I read (pandoc output) I made some mistakes during the file conversion.
For now, I didn't commit, It's on my personal computer only.
As the week is a little difficult, I'll see if I finish it at the weekend.
(Maybe I should have asked for this issue just now, just see 14 days ago and I was like "What ?! That was 2 weeks ago ?!" LOL)
Thanks for asking!

Hi @bryanasdev000, thanks for picking this up. Are you still working on this? If you're stuck, you could create a draft PR so someone can help, or if you've changed your mind that's also ok.

Hi @roberth, I followed your suggestion to create a draft PR, at the moment I'm stuck in two things, the first is how to create a note and the second reference errors during the build of the documentation.
For the first, pandoc created notes with the following formats: ::: {.note} Using this parameter requires the kvm device to be available. :::, in this case I should use the default way to create notes in markdown (using > **_NOTE:_**) or wrap this in docbook way?
And for the build errors, here is log:
...
warning: failed to load external entity "functions/library/generated/overrides/lib.options.showOption.xml"
jing doc-support/result/docbook.rng manual-full.xml
/build/doc/manual-full.xml:13148:59: error: IDREF "ex-dockerTools-buildImage-runAsRoot" without matching ID
/build/doc/manual-full.xml:12728:49: error: IDREF "ex-dockerTools-buildImage" without matching ID
make: *** [Makefile:29: validate] Error 1
builder for '/nix/store/yajds5xax6hjdjdqm4y23xvkvhpbr36r-nixpkgs-manual.drv' failed with exit code 2
error: build of '/nix/store/yajds5xax6hjdjdqm4y23xvkvhpbr36r-nixpkgs-manual.drv' failed

For this I tried (see <xref linkend="ex-dockerTools-buildImage"/>)  per #105243 but build fails with same error.
Any help is appreciated.

Hi @bryanasdev000, thanks for picking this up. Are you still working on this? If you're stuck, you could create a draft PR so someone can help, or if you've changed your mind that's also ok.

Hi @roberth, I followed your suggestion to create a draft PR, at the moment I'm stuck in two things, the first is how to create a note and the second reference errors during the build of the documentation.
For the first, pandoc created notes with the following formats: ::: {.note} Using this parameter requires the kvm device to be available. :::, in this case I should use the default way to create notes in markdown (using > **_NOTE:_**) or wrap this in docbook way?
And for the build errors, here is log:
...
warning: failed to load external entity "functions/library/generated/overrides/lib.options.showOption.xml"
jing doc-support/result/docbook.rng manual-full.xml
/build/doc/manual-full.xml:13148:59: error: IDREF "ex-dockerTools-buildImage-runAsRoot" without matching ID
/build/doc/manual-full.xml:12728:49: error: IDREF "ex-dockerTools-buildImage" without matching ID
make: *** [Makefile:29: validate] Error 1
builder for '/nix/store/yajds5xax6hjdjdqm4y23xvkvhpbr36r-nixpkgs-manual.drv' failed with exit code 2
error: build of '/nix/store/yajds5xax6hjdjdqm4y23xvkvhpbr36r-nixpkgs-manual.drv' failed

For this I tried (see <xref linkend="ex-dockerTools-buildImage"/>)  per #105243 but build fails with same error.
Any help is appreciated.


ueberzugpp: drop range-v3

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg eval

Result of nixpkgs-review pr 267969 run on aarch64-darwin 1

2 packages built:

ueberzugpp
ytfzf

Result of nixpkgs-review pr 267969 run on x86_64-darwin 1

2 packages built:

ueberzugpp
ytfzf


Update Filesystem Header and Add Centered "Hello SFML" Text

This pull request includes two changes: first, the update of #include  to #include <experimental/filesystem> for compatibility; second, the addition of a centered "Hello SFML" text in white, using a pre-installed font overlaid on an image in the SFML project. These changes collectively enhance compatibility and introduce a visually appealing element to the project.

i added the Arial.ttf for a font!

btw goated Template!

So I changed all Requests...

working now!
i changed everything needed

window size 800x600?

would fix

Since having an image and the Hello SFML both at the same time didn't make much sense, I replaced the whole thing with this

This is generated on the fly, so there is no need for a separate Hello SFML text.

nice thank you


Error reported during operation

Hello, I am executing bash/ Tools/train_ After femmode. sh 4, there was no output result and an error was continuously prompted. What is the reason for this, and which epoch_ Is 300.pth automatically generated? It keeps prompting that this file cannot be found.
ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: 1) local_rank: 0 (pid: 4635) of binary: /root/miniconda3/envs/openmmlab/bin/python
FileNotFoundError: ./work_dirs/femtodet_nano_2stage_daconv1_0/epoch_300.pth can not be found.
torch.distributed.elastic.multiprocessing.errors.ChildFailedError
RuntimeError: CUDA error: an illegal memory access was encountered CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect. For debugging consider passing CUDA_LAUNCH_BLOCKING=1.

I'm sorry to bother you. After re implementing the project, I found that it may have failed due to my environment not being properly configured. However, it seems to have been trained, but there seems to be no output of the final results, without the results in your readme.md. May I ask if it saved the final results in a certain folder