HADOOP-18099. Upgrade bundled Tomcat to 8.5.75

Description of PR
Upgrade bundled Tomcat to 8.5.75

JIRA: HADOOP-18099

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
8m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-2.10 Compile Tests _

+1 :green_heart:
mvninstall
14m 20s

branch-2.10 passed

+1 :green_heart:
compile
0m 20s

branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
compile
0m 18s

branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
mvnsite
0m 22s

branch-2.10 passed

+1 :green_heart:
javadoc
0m 23s

branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javadoc
0m 18s

branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 13s

the patch passed

+1 :green_heart:
compile
0m 14s

the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javac
0m 14s

the patch passed

+1 :green_heart:
compile
0m 12s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
javac
0m 12s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 15s

the patch passed

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 14s

the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javadoc
0m 12s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

_ Other Tests _

+1 :green_heart:
unit
0m 12s

hadoop-project in the patch passed.

+1 :green_heart:
asflicense
0m 24s

The patch does not generate ASF License warnings.

30m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3947/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3947

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml

uname
Linux 03a75ed98ffd 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-2.10 / 58033cb9d1f3ac83a7962822620ff218e17207ae

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

Multi-JDK versions
/usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_262-b10 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3947/1/testReport/

Max. process+thread count
93 (vs. ulimit of 5500)

modules
C: hadoop-project U: hadoop-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3947/1/console

versions
git=2.17.1 maven=3.6.0

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Configuring code generation to write nulls for missing properties

Using the latest version of the Maven plugin with a simple Address class I get the following generated code with Jackson 2 annotations:
@JsonInclude(JsonInclude.Include.NON_NULL)
@Generated("org.jsonschema2pojo")
@JsonPropertyOrder({
    "post-office-box",
    ...
})
public class Address {
...

I would really like missing properties to be serialized as null but the default inclusion of the  @JsonInclude(JsonInclude.Include.NON_NULL) annotation prevents that.
Even if I override the property in the object mapper as follows:
    ObjectMapper mapper = new ObjectMapper();
    mapper.setSerializationInclusion(JsonInclude.Include.ALWAYS);
    Address address1 = mapper.readValue("{\"post-office-box\": \"232\", \"extended-address\": \"an extended\",  " +
      "\"street-address\": \"123 Main St\", \"locality\": \"a locality\", " +
      "\"region\": \"a region\", \"postal-code\": \"666\", \"country-name\": null }", Address.class);

    address1.setCountryName(null);

    mapper.writeValue(outputAddressFile, address1);

I still do not get nulls in the output JSON.
Is there a way to override this default behaviour?
Thanks
Martin

There's no current way to override this behaviour in this tool. We'd have to implement #629.
There was a possible solution mentioned here though:
https://github.com/joelittlejohn/jsonschema2pojo/issues/629#issuecomment-250645527
Configure the ObjectMapper.


Convert.py does not produce yolov3.tf

Hi
I am running convert.py on darknet original weights. It does not produce any error but it does not produce yolov3.tf although I put it as the output file. It produces the following  files.

I appreciate if anyone can help me about this.

It doesn't matter if the extensions are not the same. Run the inference still with 'yolov3.tf', and it correctly reads the data automatically.

Thanks! I used the .tf in the detect.py and it worked but in the training .tf was not working.

Hi @kalikhademi
In train.py if you are loading weights from .tf file please replace the model.load_weights(FLAGS.weights) with model.load_weights(FLAGS.weights).expect_partial()


organization member list

Thanks for the implementation, I would add example in swagger file and also please verify that a user of an organization can see other member. I do not know if I remember it correctly, but only admin of an organization can see other organization users and a user can see other users just from his/her team.

Thanks for the implementation, I would add example in swagger file and also please verify that a user of an organization can see other member. I do not know if I remember it correctly, but only admin of an organization can see other organization users and a user can see other users just from his/her team.

I've confirmed with Tomáš, that user should be able to see all their colleagues in the organization. Swagger was updated to describe the new endpoint.


Appendices HTML formatting fix

Currently, all the appendices are under one "Appendix" section in HTML. This PR solves this and separates each in its own Appendix.

Minor editorial change, multiple approvals, merging


DO NOT MERGE WiP implementation of Proposal #2702

CI only.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3583/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4728/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3585/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4732/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3585/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4732/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3586/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4733/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3586/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4733/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3589/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4736/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3590/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4738/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3591/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4742/
Test PASSed.

@JSExportTopLevel for fields will require more work than I thought, and less similar to @JSExportStatic than I thought, so I think it is best to keep that one out from this PR, and submit it later.
Therefore this PR is ready for review. Review by @gzm0. The second commit has been cherry-picked verbatim from #2685 and need not be reviewed again.

Updated. I should have addressed all your comments, except mentioning that static fields are initialized in the companion module's constructor.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3597/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4752/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3599/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4754/
Test PASSed.


Support for Adj-RIB-Out monitoring

Do you know if there is currently support in place for monitoring the Adj-RIB-Out of a router connected to gobmp via a BMP session? If not, is it in the roadmap? Relevant resource: https://datatracker.ietf.org/doc/rfc8671/
I am not sure if such monitoring is officially supported in commercial or open-source software routers yet.
Thanks in advance for the clarification!

Hi Vasileios,
The primary devices we have access to test with are Cisco XR and XE, and unfortunately neither OS supports Adj-RIB-Out.  It looks like gobmp should pick it up as Serguei has accounted for the O-Flag: https://github.com/sbezverk/gobmp/blob/master/pkg/bmp/per-peer-header.go#L25
If you have access to a platform which does support Adj-RIB-Out please feel free to get it connected and send gobmp logs our way.
-Bruce

Hello and thanks for the  response! I am using gobgp software routers which are quite handy, and have posted the same question on their implementation https://github.com/osrg/gobgp/issues/2550 . Will let you know when I receive the response. In the meanwhile I may have access to Juniper routers supporting RIB-out (https://supportportal.juniper.net/s/article/Change-in-implementation-of-BMP-protocol-in-Junos-OS-release-19-1-and-18-2X75-D30?language=en_US) but that is more difficult to acquire than in-software.
On GoBMP's side what do I have to configure CLI-wise to enable this kind of monitoring, assuming that the router supports it? Or is it in theory out-of-the-box as long as the router provides this capability?

Hi, nothing to configure on the GoBMP side. I don't know if it'll work out of the box, but the O-flag code has me feeling optimistic :)
Maybe enable logging at v=6 to capture raw message data from the adj-RIB-out coming from the router.


Windows Defender reporting trojan in Winx86 release

Trojan:Win32/Wacatac.B!ml

Thank you for the report. I'm not sure why Windows Defender detected this as a Trojan, but I intend to investigate if there is any issue.


How to check if class is defined or not?

I want to check some class is defined or not.
defined? method haven't implemented yet, and doc says use const_defined? method instead.
I tried follow code, but it raises error.
# test.rb

class TestClass
end

p const_defined?(:TestClass)

test.rb:4: undefined method 'const_defined?' (NoMethodError)

How can I check it?

You can use Object.const_defined?

@Shokuji
Thanks, I got it.


handshake failed ... Server returned status code 400, Error Domain=SocketIOError Code=-6

When I tried to send events to server, I got these errors. Does anyone know this problem.

which version of socket.io are you using?

for the client side? I think client is using socket.io version 1.0

this library only supports socket.io < 1.0

i got it. Thanks :)

@pkyeck Is there any special reason to library not working with socket IO v 1.0?

@Dhaval3110 yep, socket.io 1.0+ was a complete rewrite and I didn't have the time to do all the adjustments needed for this lib to work with v1.


demystify the "autoscale" UI control

Overview of design need
The "autoscale" UI element is confusing -- the GUI does not indicate the difference between "once" and "continuous" (e.g., via a tooltip revealed on mouse hover), and the GUI does not clearly indicate whether "once" or "continuous" has been selected. It's true that if you click "continuous" the button changes color, but the same thing does not happen for "once", presumably because selecting "once" has a different kind of effect than selecting "continuous" -- the former triggers a one-time adjustment of the contrast limits, while the latter does... something else, continuously? Is the viewer re-checking the contrast limits every tick  :sweat_smile:, or is it re-checking the contrast limits every time the displayed data is changed (I would call this dynamic, not continuous). In any case, the GUI doesn't tell me. And even if the meaning of "continuous" was clarified, it's confusing to have a one-time action and a continuous process represented nearly identically in the GUI.
What level of design is needed? (Choose all that apply)
This section may be updated by the designer / UX researcher working on this issue

[ ] User experience research:  high-level recommendation/exploration of user needs, design heuristics, and / or best practices to inform a design experience
(Use this option when you feel there’s a challenge to be solved, but you’re curious about what the experience should be — may involve research studies to understand challenges/opportunities for design)
[ ] information flow / conceptual: organizing and structuring of information flow and content, including layout on screen or across multiple steps
[ ] Visual: creating mockups, icons, etc
(If choosing this level alone, it means that the content to be mocked up and its organization is already known and specified)

Is design a blocker?

[ ] Yes: engineering cannot proceed without a design first
[ ] No: engineering can create a first version, and design can come in later to iterate and refine

If selecting Yes, how much design input is needed to unblock engineering? For example, is a full, final visual design needed, or just a recommendation of which conceptual direction to go?

the GUI does not clearly indicate whether "once" or "continuous" has been selected ... presumably because selecting "once" has a different kind of effect than selecting "continuous" -- the former triggers a one-time adjustment of the contrast limits, while the latter does... something else, continuously?

yep, you got it exactly right :).  Happy to take suggestions how how to clearly indicate that one button is "toggle-able" and the other one is a one time button.  Tried to show that with the changes of colors, but happy to take additional suggestions.

Is the viewer re-checking the contrast limits every tick or is it re-checking the contrast limits every time the displayed data is changed (I would call this dynamic, not continuous)

it's every time the view slice is changed (e.g. via the dims sliders or via data updating itself in the background).  I took the term continuous from various acquisition software auto-contrast controls.  While "dynamic" might be your pick, I'm not sure it's any more "globally obvious", so I agree that the tooltip is the best solution here.

And even if the meaning of "continuous" was clarified, it's confusing to have a one-time action and a continuous process represented nearly identically in the GUI.

almost every major microscope software has this (buttons next to each other that perform a one-time autoscaling and a continuous autoscale as the data changes), and that was the driving use case here).  If you think that clarifying with a tooltip still won't help, please provide additional suggestions

yep, you got it exactly right :). Happy to take suggestions how how to clearly indicate that one button is "toggle-able" and the other one is a one time button. Tried to show that with the changes of colors, but happy to take additional suggestions.

What about a button for the action, and a checkbox for the continuous thing?

it's every time the view slice is changed (e.g. via the dims sliders or via data updating itself in the background). I took the term continuous from various acquisition software auto-contrast controls. While "dynamic" might be your pick, I'm not sure it's any more "globally obvious", so I agree that the tooltip is the best solution here.

In the Zeiss acquisition software this is called "auto" and also set with a checkbox, I think? (I haven't touched a zeiss scope in years, so i'm just going by screenshots). In Icy I think they call this functionality "refresh", and it's set with a checkbox. I think "auto" is probably the simplest / clearest? But whatever word is used for this functionality, there will be some user who doesn't know what it means, and so there should probably be an intuitive way (e.g., tooltip) to figure out what process this GUI element controls.

But whatever word is used for this functionality, there will be some user who doesn't know what it means, and so there should probably be an intuitive way (e.g., tooltip)

agreed!  I've changed the title of this post to reflect that the tooltip is the main issue here.  thanks

What about a button for the action, and a checkbox for the continuous thing?

This was my first thought as well! It is the classic (most universally understood) component + interaction for the type of behavior described.

fwiw, this was discussed back in the original issue.  It was hard to get both a checkbox and text to "fit" in the allotted area nicely... we can certainly go back in that direction.  but i'd like to get some more opinions first

I can work on the layout also
On Tue, Sep 7, 2021 at 1:16 PM Talley Lambert @.***>
wrote:

fwiw, this was discussed back in the original issue. It was hard to get
both a checkbox and text to "fit" in the allotted area nicely... we can
certainly go back in that direction. but i'd like to get some more opinions
first
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/napari/napari/issues/3346#issuecomment-914595180, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AMWPDSHEPARAEW4KQTHOJWLUAZXLJANCNFSM5DQ2HWAA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Lia Prins
Senior Data Visualization Designer
(650) 422-1750
chanzuckerberg.com


Input container / form field font size does not adhere to material design spec

https://github.com/angular/material2/blob/85a6fff17a1f3ccbbda1f555ba32868c95b16b25/src/lib/form-field/_form-field-theme.scss#L146
The size is set to inherit, but the spec requires size 16. Inherit is wrong.

Apparently this was addressed by #5154 / #5262 but not fully fixed (the root cause was addressed but not the root problem - font size).

aha... so this is probably why md-selects are sized 16px and form field text inputs are... whatever sized

We intentionally make the input more flexible than the spec calls for (allowing the input to use its inherited font-size).

Why? I don't understand why it needs to be "more flexible." I can easily override the style if I want flexibility. I'd love to know the reasoning behind that for my own education. Do you do this with any other components? Disappointing that in some cases the spec is adhered to with great rigidity and no consideration for "flexibility" whereas here it is considered unimportant.
I though this would be an obvious one but I guess I was wrong. I suspect this is an ad-hoc arbitrary decision that no-one really thought through, so let me state the case a little more clearly. This is less flexible because now I have to override the style if I happen to have my input in a  or  with .mat-typography applied - which is generally always. I apply .mat-typography at the root of my page which is what Angular Material recommends (I love this feature). So every input in every DIV or P now has font size 13 with (as a result) a barely visibly 9.75px label and hint. (You should try this and see how bad it looks.) And there is no class defined so that I can easily say  or similar to have it at spec size - because you made .mat-input font-size inherit. Please, for the love of bacon, explain to me how this is more "flexible???"


Fix typo in webjobs-sdk-how-to.md

Fix typo in "WebHobs" -> "WebJobs"

@byguid : Thanks for your contribution! The author, @ggailey777, has been notified to review your proposed change.

#sign-off


Closing


Running otel-go-instrumentation in the same container as the app errors with "process not found yet, trying again soon"

Describe the bug
When running otel-go-instrumentation in the same container as the app it errors with "process not found yet, trying again soon".
The sidecar approach needing to run as privileged is a concern for us so I was seeing if this can work if otel-go-instrumentation is run in the same container as the app being instrumented.
Environment

OS: OSX Sonova 14.5 Apple M2 Pro ARM host machine, Debian 11 bullseye x86_64 container
Go Version: 1.23.1
Version: v0.14.0-alpha

To Reproduce
Dockerfile:
FROM golang:1.23.1-bullseye as base

RUN apt-get update && apt-get install -y curl vim net-tools procps wget clang gcc llvm make libbpf-dev

RUN wget https://github.com/open-telemetry/opentelemetry-go-instrumentation/archive/refs/tags/v0.14.0-alpha.tar.gz && \
  tar zxf v0.14.0-alpha.tar.gz && \
  cd opentelemetry-go-instrumentation-0.14.0-alpha/ && \
  make build && \
  cp otel-go-instrumentation /usr/local/bin

docker-compose.yaml:
version: '3.4'

services:
  app:
    platform: linux/amd64
    build:
      context: .
    #### See if these can be removed if it's running in the same container
    privileged: true
    pid: "host"
    cap_add:
      - SYS_PTRACE
    ####
    environment:
      OTEL_GO_AUTO_TARGET_EXE: /app/oteltest
      OTEL_SERVICE_NAME: otelgoautotest
      OTEL_EXPORTER_OTLP_ENDPOINT: http://localhost:4318
      OTEL_PROPAGATORS: tracecontext,baggage
    expose:
      - 8080
    ports:
      - 8080:8080
    volumes:
      - .:/app
    working_dir: /app

Test app to be instrumented:
package main

import (
  "fmt"
  "net/http"
)

func handler( w http.ResponseWriter, r *http.Request) {
  fmt.Fprintf(w, "received request")
}

func main() {
  http.HandleFunc("/otelgotest", handler)

  fmt.Println("Starting...")
  http.ListenAndServe(":8080", nil)
}

Run the app and otel-go-instrumentation in the same container:

Run and exec into the container: docker-compose run app.
Build the test app: go build ..
Run the app in the background: /app/oteltest & .
Run otel-go-instrumentation: otel-go-instrumentation --log-level=debug.

It fails to find the app process with the error:
{"level":"info","ts":1727709418.1301615,"logger":"go.opentelemetry.io/auto","caller":"cli/main.go:86","msg":"building OpenTelemetry Go instrumentation ...","globalImpl":false}
{"level":"debug","ts":1727709420.1934721,"logger":"Instrumentation.Analyzer","caller":"process/discover.go:71","msg":"process not found yet, trying again soon","exe_path":"/app/oteltest"}

Though the process can be seen by ps -ef:
root      2394  2102  0 15:15 pts/0    00:00:00 /usr/bin/qemu-x86_64 /app/oteltest /app/oteltest.
I tried setting OTEL_GO_AUTO_TARGET_EXE to how it shows in ps -ef and some variations of that to see if it's an issue with being an ARM mac host machine and x86_64 container since the process output shows qemu-x86_64. I also tried running /app/oteltest in the container from one terminal and exec'd into the container a second time from another terminal to run otel-go-instrumentation and still had the same error.
Expected behavior
The otel-go-instrumentation binary is able to find the test app process, instrument it, and send traces to OTEL_EXPORTER_OTLP_ENDPOINT.
Additional context
I'm not sure if this is considered a supported flow or not but the sidecar approach requiring being run as privileged or needing additional capabilities is a concern. I'm curious if the stance here is to use the privileged sidecar approach or instrument your go app in the app-code instead and there isn't intended to be a way to auto-instrument without a privileged container.

@mjneth Thank you for opening this issue.
Can you try using an ARM image to see if the problem relates to qemu?

@mjneth Thank you for opening this issue. Can you try using an ARM image to see if the problem relates to qemu?

It does work with an ARM image but our production images are x86_64 so we want to use the same in the docker-compose setups for local dev. Is it feasible for this to work with qemu?

@mjneth From the ps output you attached, it seems that the actual process being run is qemu one which emulates the go binary, if that is the case then our current implementation won't support it since we are looking for a running go executable.


Line height is too short for awards when swapped title and info line is enabled

Hey @ccrama
I'd like to contribute from my side to this project and looking for a good start.
I feel that I can take up this issue and get more familiar with the project as well!
If you are okay with this, let me know the steps to reproduce the above issue

Hey @tejuamirthi , we'd love to have you on the project! The file in question is CachedTitle.swift, specifically these lines https://github.com/ccrama/Slide-iOS/blob/develop/Slide for Reddit/CachedTitle.swift#L439. To reproduce the issue, go to Settings > Card Layout and enabling the "Title below post details" option. I think there is a typo there at the moment...
You can also join us on Discord  if you want to chat with us there


Uplift third_party/tt-metal to 4952f01a39068cba4e85c93cf34c4f95f10f5c34 2024-12-06

This PR uplifts the third_party/tt-metal to the 4952f01a39068cba4e85c93cf34c4f95f10f5c34

Appreciate the fix while I was sleeping - thanks a lot!  tt-forge-fe run with this uplift passed link : https://github.com/tenstorrent/tt-forge-fe/actions/runs/12200575561
Going to merge. Daily uplifts FTW.


Query multiple tables

In this milestone I have made the following changes.

Add species table.
Add owners table.
Remove the species column from animals.
Add owner_id and species_id as foreign keys to the animal's table.
Insert owner's data.
Insert species data.
Query data from multiple tables.

Here is the screenshot of my query result.
Screenshot 1

Screenshot 2

**STATUS: APPROVED  🟢 **

Hi @melashu ,
Great work on making the changes requested by a previous reviewer 👏🏻
Highlights:
✔ Project is setup correctly
✔ All linters are passing
✔ Correct gitflow
✔ Professional documentation
Your project is complete! . There is nothing else to say other than... it's time to merge it 🍾🚢 :shipit: . Congratulations!  🎉💯🌟

Cheers and Happy coding! :clap: :clap: :clap:
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me [@shoirata] in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have  limited number of  reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.


feat(concept/policies): Add documentation for policies

Feature : Trailpack / Express Policies

[x] Aprobate documentation
[ ] check if something is missing
[x] Accept the pull request

Added By  @jaumard validation needed when both are check:

[x] Check if true/false and '*' are allowed then modify the docs

-> Removing true/false and '*' as Policy argument

[x] Check if  '': ['ExamplePolicy.test2'] is allowed here to override the global '' then modify the docs

Approbation needed
Please Merge this pull request if there is no problem with concepts.
Link of he current version that will be merged: https://github.com/maissani/trailpack-express/tree/feat/docs/docs/concepts/policies/README.md
Validators: @tjwebb @jaumard
Current : 369c2e0
PS: please doucble check, comment again or validate.

Rebase done => You can accept the PR if you consider that all is OK
Thx  @jaumard


Small improvements in sphinx build

As proposed by @akaszynski
Also added yellow role for text colouring.

Found the issue. We were overwriting the html theme settings in a1c4ff76feb7638686f86b4944635b49b2dd4bdf.

Thank you @RobPasMue !


Remove the bosco audit command

This PR removes the bosco audit command:

It relies on nsp, the service for which no longer exists
Even before Node Security Project was decommissioned, bosco audit didn't work when I tested it out
The nsp library contains dependencies known to be insecure

We can put bosco audit back (if it's useful) when we complete tes/bosco#250.
https://github.com/tes/jobs-issues-and-documentation/issues/2103

Coverage remained the same at 81.275% when pulling d02eeccc80d15e628dac8f05a01f80ffff556071 on remove_nsp into e5e88b8265a9cf88e9a25d061f27a53f73384bd8 on master.


ISSUE-6136: Fix DB::Exception throwed by bitmapContains

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):

Bug Fix

Short description (up to few sentences):
Fix issue 6136
...
Detailed description (optional):
Issue 6136 is caused by previous commit of
commit c9a5b3c9ab5f1617bf3913ffc0378d73c405b1b6
Author: dimarub2000<EMAIL_ADDRESS>Date:   Wed Jul 10 17:53:57 2019 +0300

    primary key and MergeTreeIndexFullText support for string functions

In function of
bool KeyCondition::atomFromAST(const ASTPtr & node, const Context & context, Block & block_with_constants, RPNElement & out)

from KeyCondition.cpp
...

Many thanks for your fix. Tests will be added.

Fixed in #6156


Automatic Signing Fails: Certificate and Team Not Set During iOS Archive with Fastlane using match.

Description:
I am using Fastlane to create and deploy an iOS IPA using the deploy_to_app_store lane. While everything else works fine, the build fails due to a code signing issue. Specifically, the failure is caused by the "Automatic signing" being enabled but the team and certificates not being set in the Signing & Capabilities section of Xcode.
I need to generate an IPA entirely via Fastlane without manually opening Xcode. After the failure, when I open Xcode to check, I see that automatic signing is enabled, but no team or certificate has been selected, which seems to be causing the issue.

Steps to Reproduce:

Run the Fastlane lane: fastlane deploy_to_app_store.
Observe the failure during the archive step due to code signing issues.
Open the Xcode project and navigate to the Signing & Capabilities tab.
Notice that automatic signing is enabled but the team and certificate fields are not set.

Fastfile Configuration:
lane :clean_build_artifacts do
  sh <<-SHELL
  #!/bin/bash
  echo "Cleaning React Native project cache..."
  rm -rf ~/Library/Developer/Xcode/DerivedData/*

  pkill -f "node .*react-native start"

  cd ..
  rm -rf node_modules/ && npm cache clean --force
  npm install

  cd ios
  rm -rf Pods/ Podfile.lock
  bundle exec pod install
  xcodebuild clean

  echo "Done cleaning!"
  SHELL
end

lane :deploy_to_app_store do |options|
  app_store_connect_api_key(
    key_id: "L2R....",
    issuer_id: "69a.......................",
    key_filepath: "./fastlane/keys/AuthKey.p8",
    in_house: false
  )
  match(
    type: "appstore",
    storage_mode: "apple",
    storage_mode: "git",
    git_url: "https://github.com/myuser/fastlane",
    app_identifier: CredentialsManager::AppfileConfig.try_fetch_value(:app_identifier),
    team_id: CredentialsManager::AppfileConfig.try_fetch_value(:team_id),
    readonly: false
  )
  clean_build_artifacts
  gym

  UI.success("Successfully uploaded to TestFlight using API Key!")
end

Gymfile Configuration:
scheme("FastlaneTest1")
export_options({
  method: "app-store",
  signingStyle: "automatic", # automatic/manual
})
clean(true)
output_directory("./fastlane/builds")
include_bitcode(false)
include_symbols(true)

Expected Behavior:
Fastlane should set the appropriate team and certificate for automatic signing when creating the IPA without needing to open Xcode.

Observed Behavior:
The build fails due to code signing issues. Automatic signing is enabled in Xcode, but no team or certificate is set.

Command Used:
fastlane deploy_to_app_store

Screenshots:
Provide screenshots showing the Signing & Capabilities tab in Xcode after the failure and any terminal errors.

Environment:

Key
Value

OS
14.5

Ruby
3.1.0

Bundler?
false

Git
git version 2.39.3 (Apple Git-146)

Installation Source
~/.rvm/gems/ruby-3.1.0/bin/fastlane

Host
macOS 14.5 (23F79)

Ruby Lib Dir
~/.rvm/rubies/ruby-3.1.0/lib

OpenSSL Version
OpenSSL 1.1.1w  11 Sep 2023

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
15.4

Swift Version
5.10

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE

fastlane gems

Gem
Version
Update-Status

fastlane
2.225.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

error_highlight
0.3.0

did_you_mean
1.6.1

executable-hooks
1.7.1

bundler-unload
1.0.2

rubygems-bundler
1.4.5

bundler
2.5.22

pathname
0.2.0

addressable
2.8.7

artifactory
3.0.17

babosa
1.0.4

CFPropertyList
3.0.7

colored
1.2

highline
2.0.3

commander
4.6.0

dotenv
2.8.1

emoji_regex
3.2.3

excon
0.112.0

faraday-em_http
1.0.0

faraday-em_synchrony
1.0.0

faraday-excon
1.1.0

faraday-httpclient
1.0.1

multipart-post
2.4.1

faraday-multipart
1.0.4

faraday-net_http
1.0.2

faraday-net_http_persistent
1.2.0

faraday-patron
1.0.0

faraday-rack
1.0.0

faraday-retry
1.0.3

ruby2_keywords
0.0.5

faraday
1.10.4

faraday_middleware
1.2.1

domain_name
0.6.20240107

http-cookie
1.0.7

faraday-cookie_jar
0.0.7

fastimage
2.3.1

sysrandom
1.0.5

fastlane-sirp
1.0.0

gh_inspector
1.1.3

uber
0.1.0

declarative
0.0.20

trailblazer-option
0.1.2

representable
3.2.0

retriable
3.1.2

mini_mime
1.1.5

jwt
2.9.3

multi_json
1.15.0

os
1.1.4

signet
0.19.0

googleauth
1.8.1

httpclient
2.8.3

google-apis-core
0.11.3

google-apis-androidpublisher_v3
0.54.0

google-apis-playcustomapp_v1
0.13.0

google-cloud-env
1.6.0

google-cloud-errors
1.4.0

google-cloud-core
1.7.1

google-apis-iamcredentials_v1
0.17.0

google-apis-storage_v1
0.31.0

digest-crc
0.6.5

google-cloud-storage
1.47.0

mini_magick
4.13.2

naturally
2.2.1

plist
3.7.1

rubyzip
2.3.2

security
0.1.5

simctl
1.6.10

terminal-notifier
2.0.0

unicode-display_width
2.6.0

terminal-table
3.0.2

tty-screen
0.8.2

tty-cursor
0.7.1

tty-spinner
0.9.3

word_wrap
1.0.0

rouge
2.0.7

xcpretty
0.3.0

xcpretty-travis-formatter
1.0.1

set
1.0.2

public_suffix
6.0.1

aws-eventstream
1.3.0

aws-sigv4
1.10.1

aws-partitions
1.1009.0

jmespath
1.6.2

aws-sdk-core
3.213.0

aws-sdk-kms
1.96.0

aws-sdk-s3
1.172.0

rexml
3.3.9

nkf
0.2.0

base64
0.2.0

rake
13.2.1

json
2.8.2

optparse
0.6.0

nanaimo
0.4.0

colored2
3.1.2

claide
1.1.0

atomos
0.1.3

xcodeproj
1.27.0

forwardable
1.3.2

logger
1.6.1

shellwords
0.1.0

cgi
0.3.1

date
3.2.2

timeout
0.2.0

stringio
3.0.1

securerandom
0.3.2

uri
0.11.0

ipaddr
1.2.3

io-wait
0.2.1

openssl
3.0.0

digest
3.1.0

io-nonblock
0.1.0

zlib
2.1.1

resolv
0.2.1

time
0.2.0

open-uri
0.2.0

mutex_m
0.1.1

net-protocol
0.1.2

net-http
0.2.0

english
0.7.1

erb
2.2.3

strscan
3.0.1

abbrev
0.1.0

io-console
0.5.10

tempfile
0.1.2

delegate
0.2.0

fileutils
1.6.0

tmpdir
0.1.2

singleton
0.1.1

open3
0.1.1

prettyprint
0.1.1

pp
0.3.0

find
0.1.1

ostruct
0.5.2

yaml
0.2.0

psych

Additional Information:
I suspect that the issue might be related to how match or gym is configured in the lane. Any guidance or fixes would be appreciated.

Any updates??

ANY UPDATES??


Upgrade to markdown2 and enable tables

The code change looks fine. Should there be a markdown to html test? I looked around and didn't see one.

Good catch! I added a unit test, increased coverage from 84% to 86% 👍


refactor: 仮引数をparamにリネーム

What
タイトルの通り
Why
Resolve #750
Additional info (optional)

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 81.81818% with 6 lines in your changes missing coverage. Please review.

Files with missing lines
Patch %
Lines

src/type.ts
40.00%
6 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines
Coverage Δ

src/interpreter/index.ts
94.30% <100.00%> (+8.50%)
:arrow_up:

src/interpreter/util.ts
68.04% <100.00%> (+0.06%)
:arrow_up:

src/interpreter/value.ts
100.00% <100.00%> (ø)

src/node.ts
71.42% <ø> (-26.95%)
:arrow_down:

src/parser/plugins/validate-keyword.ts
88.42% <100.00%> (-0.19%)
:arrow_down:

src/parser/plugins/validate-type.ts
100.00% <100.00%> (+17.64%)
:arrow_up:

src/parser/syntaxes/common.ts
92.95% <100.00%> (+3.42%)
:arrow_up:

src/parser/syntaxes/expressions.ts
91.63% <100.00%> (+2.45%)
:arrow_up:

src/parser/syntaxes/statements.ts
97.35% <100.00%> (+4.09%)
:arrow_up:

src/parser/visit.ts
100.00% <100.00%> (+5.26%)
:arrow_up:

... and 1 more

... and 19 files with indirect coverage changes

一応ホスト向けの変更を含むので、ChangelogにFor Hostsとして記載をお願いします。


Dev

Project requirements
Config & basic setup
Create React App.
Install React Redux, Redux Logger and React Router.
Download the free image for the app logo.
Create routes and view components: rockets, missions, my profile. Add dragons [only if your team has 3 members]).
Use  for the page navigation links and style active class to indicate which section/page user is currently on (underline active navigation link).
Redux: Fetch data and update Redux store
Upon the first render fetch data from the SpaceX API endpoints:
Rockets: https://api.spacexdata.com/v4/rockets
Missions: https://api.spacexdata.com/v3/missions
Dragons: https://api.spacexdata.com/v4/dragons [only if your team has 3 members]
Once the data are fetched, dispatch an action to store the selected data in Redux store:
Rockets:
id
rocket_name
description
flickr_images
Missions:
mission_id
mission_name
description
Dragons [only if your team has 3 members]:
id
name
type
NOTE: Make sure you only dispatch those actions once and do not add data to store on every re-render (i.e. when changing views / using navigation). NOTE: Rockets is the default view, so you must fetch Rockets data when the application starts. However, the mission data should only be fetched (once) when a user navigates to the Missions section.

@sam2if, @leloufadel, please kindly restore your linter file back to the original state as editing of the linters file will get your pull request invalidated. The reason for your error is that the path referenced in your Rockets.js file is not correct.

There is no Redux folder in your project.
There is no /LoadingR file in your components folder.

@sam2if, @leloufadel, please kindly restore your linter file back to the original state as editing of the linters file will get your pull request invalidated. The reason for your error is that the path referenced in your Rockets.js file is not correct.

There is no Redux folder in your project.
There is no /LoadingR file in your components folder.

Hello @topeogunleye I have restored the linter


Obligations not imported from OggDude's XML

The obligation list is not imported from the OggDude's XML. It also needs to be calculated for the total obligations

the obligation list will auto calculate for all of them entered.  To see the obligation / duty section, click on the header of the duty or obligation total amount box on the bio section

the obligation list will auto calculate for all of them entered.  To see the obligation / duty section, click on the header of the duty or obligation total amount box on the bio section


Atomtyper sanitization breaks down for decorators with specific rules

For example this is making a comparison with all_patterns which only contains combinations of patterns based on element names.

Moved https://github.com/iModels/foyer/issues/2


Check confirm del button active before clicking.

Before clicking the confirm delete button check if its active or not, if not remove the class disabling it before clicking.

If the tab is not in focus github will not remove the disabled attribute from confirm delete button. Therefore script not removes disabled attr from the button before clicking for situations where user might move away from that tab.
Done in commit f93e3280cd47e04da7b3a26a1419bcfdf021f67d


Use zstd compression in NRRD and MetaIO

[Background discussion]
zstd's advanced API which supports multithreading has recently entered staging area with intention to be moved into stable API. Now is a great time to make use of it, before ITKv5.0 is released.

Just adding updated information:
zstd v1.4.0 was released April 16th, 2019.
https://github.com/facebook/zstd/releases/tag/v1.4.0

Advanced API
The main focus of the v1.4.0 release is the stabilization of the advanced API.

Current release is now v1.4.3
https://github.com/facebook/zstd/releases/tag/v1.4.3

Two recent experiments I did may be relevant to this thread. These both focus on making Gzip compression faster, which would retain compatibility with the current NRRD format. One could use this acceleration to use a better compression level, getting a little closer to zstd.
1.) Since pigz is based on zlib, it can be recompiled with the accelerated CloudFlare zlib. Here is a simple CMake script that builds pigz with the CloudFlare zlib:
git clone https://github.com/neurolabusc/pigz.git
cd pigz
mkdir build && cd build

2.) ITK uses znzlib to read/write NIfTI images. My accelerated znzlib demonstrates two methods to accelerate writing gzip images. First, the NIfTI IO can be built using the CloudFlare zlib which is faster than the system zlib. Second, the user can provide an environment variable to request that data is piped to pigz. Only a few lines of code are modified, yielding a dramatic performance increase. I do think the same strategy could be used for the NRRD writing. As my project demonstrates, file writing for uncompressed data and piped pigz are the same, so one can generally use the same existing well tested routines.

The low hanging fruit is zlib-ng, as pointed out in a VTK forum discussion.

Also #416

I am giving up on this as zlib-ng was integrated via #2708 and #2803, adding zstd to NRRD and MetaIO is major undertaking, and there is ongoing OME-Zarr effort.


Manager#logs deprecation warning after upgrading to Selenium 4.0

Hi!
After I updated my gemfiles to use Selenium 4.0, I received a few of these warnings:
2021-10-19 13:48:26 WARN Selenium [DEPRECATION] Manager#logs is deprecated. Use Chrome::Driver#logs instead.
After a few hours of research, I found out that they deprecated the use of Manager:
https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES#L36
The workaround for me was to remove Manage from here:
https://github.com/dbalatero/capybara-chromedriver-logger/blob/60e7a9c6bc8bbe5e4dc1f508a57e5d4c6cac3d53/lib/capybara/chromedriver/logger/collector.rb#L56
After I removed it, and reran my tests, the deprecation warnings disappeared, and the console log reports were generated just fine.
I know that currently capybara-chromedriver-logger supports Selenium > 3 and Selenium < 4, but maybe for future versions it would be cool to handle this deprecation warning.
I am glad to help with more information, or anything needed.
Thank you!

Hi @TamasGombos! I see, so they moved everything from .manage up a level and got rid of it?
My issue for patching this is getting a minimal reproduction/environment to test in, so I can ensure I made the right changes. I'd rather not just blindly remove the .manage call, as it might break older clients.
Something like this could work:
def logs(type)
  browser = Capybara.current_session.driver.browser

  if browser.respond_to?(:manage)
    # Support older Selenium versions < 4
    browser.manage.logs.get(type)
  else
    # Support Selenium version 4+
    browser.logs.get(type)
  end
end

Tests produce a lot of noise. Is it possible to fix it?

@dbalatero Is there anything I can do to help? Is @rubendinho's patch mergable?

The patch https://github.com/rubendinho/capybara-chromedriver-logger/commit/10632e6daa92fc849c0f92d0fb981a63e2ef750f works fine for me

Any update to this? Could https://github.com/dbalatero/capybara-chromedriver-logger/pull/38 get merged?

I would also love to get this fixed... Is it going to be in a near future, or can i run the patched version somehow?

Curious what the holdup on this is. This breaks hard in selenium-webdriver v4.4.0 (whereas deprecation warning in v4.1.0).
     Failure/Error:
       Capybara
         .current_session
         .driver.browser
         .manage
         .logs
         .get(type)

     NoMethodError:
       undefined method `logs' for #<Selenium::WebDriver::Manager:0x000000012a978238>

Happy to help or submit a sponsorship to get this across the finish line.

Sorry, I haven't been using Rails or Capybara for 3 years now and don't have a great test setup here. I'm checking in on #38 - it can be merged, but I don't know the state of things and whether it warrants a hard major version bump since it might be a breaking API change for older clients?

@dbalatero I think a major release will be a good first step.
From what you've said it might also be a good opportunity to re-home the project to another maintainer. What do you think?

@dbalatero Can we rehome this repo as @benschwarz requested?

Relevant to make it work with Chrome 120: https://github.com/SeleniumHQ/selenium/issues/13112. TLDR: use --headless=new instead of --headless.


config leads to typescript path mapping not being resolved in nx project

Extending with this config in an NX project causes ESLint errors (import/no-unresolved) for path mapped internal packages.

Problem is from upstream at airbnb-typescript-prettier


Shadows not properly rendered from OmniLight3D

Tested versions

Reproducible in v4.4.dev3.official [f4af8201b] Not Reproducible in v4.3.stable.official [77dcf97d8]

System information
Godot v4.3.stable - Windows 10.0.22631 - Vulkan (Forward+) - dedicated GeForce GTX 1060 with Max-Q Design - Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz (12 Threads)
Issue description
Upgrading from 4.3 to 4.4.dev seems to break omni light shadows

Building the scene from scratch in a new project has the desired effect:

Steps to reproduce
I created a scene with 2 boxes (1 with faces flipped and 1 wish shadows only) inside an existing project and that new scene had omnilight shadows that behaved as expected in 4.3. Upgrading the project to 4.4 causes the lights to break. It's worth noting that creating a fresh project with just the scene shown above and upgrading that to 4.4 does not seem to create the issue.
Minimal reproduction project (MRP)
N/A
I tried to create the scene described above in a new project but it succeeded.

Please upload an MRP to make this easier to test, especially as it works in a new project

Sorry first time opening a new issue
what I meant was that creating the issue scene in a fresh 4.3 project and upgrading worked as intended. I was not able to replicate the issue. Creating that scene in an existing project and then upgrading it to 4.4 causes the issue to occur

@final-turn Can you try following the same steps on 4.4 dev/beta/RCs to determine when the regression started? You can download them here.

I ran the project in v4.3.stable.official [77dcf97d8] to make sure it worked as expected

v4.4.dev1.official [28a72fa43] worked as expected
v4.4.dev2.official [97ef3c837] worked as expected
v4.4.dev3.official [f4af8201b] did NOT work as expected looks like the regression started in the latest version

v4.4.dev2 (expected):

v4.4.dev3:

I tested this issue with the latest version of Godot v4.4.dev6.official [1f47e4c4e] and it's still present:
Here's what it looks like with a DirectionalLight3D in the scene heirarchy

And here's what it looks like if I use the preview sunlight (expected behavior)

I was also able to create a project that reproduces the issue!
light_issue_project.zip

@clayjohn That's embarrassing haha
I double checked with my existing project and it looks like it's still an issue 🤔
Here it is in 4.4.dev6

and here it is in 4.3

I mentioned in a previous comment that the issue seemingly started in 4.4.dev2 since it worked on that version and before, not sure if that can help pinpoint the cause
what it looks like in 4.4.dev2:

I was able to identify the cause of the issue! @clayjohn
tested on v4.4.dev7.official [46c8f8c5c]

I had this setting turned on in my project and up until 4.4.dev2 it didn't seem to affect the omni light shadows but after it had that effect I detailed above. I guess my question now is this an issue that was introduced in subsequent releases or was it previously not working as intended and now it is.

@final-turn Nice! Vertex shading was added in dev 3! (https://godotengine.org/article/dev-snapshot-godot-4-4-dev-3/) Before that, the setting did nothing.

This is an expected limitation of vertex shading. Quoting the pull request that reimplemented vertex shading:

Production edit: Pixel shadows are only available for the first DirectionalLight3D in the scene. Omni and spot lights cannot cast shadows on vertex-shaded materials (like in Godot 3.x), except in the Compatibility rendering method where lights with shadows are rendered with a multipass approach.


Fix az cli usage docs

Hi @colemickens, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Cole Mickens). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Equal signs were removed because of this bug: https://github.com/Azure/azure-cli/issues/1379 (and then on the other flags just to be consistent.


drivers: gpio: esp32: Fix return function isn't handled

To know if the gpio was set correctly pinmux_pin_input_enable()'s
return and pinmux_pin_pullup()'s return must be handled in
gpio_esp32_config().
Signed-off-by: Vitor Massaru Iha<EMAIL_ADDRESS>

@iha : Please also change the commit title to something like "drivers: gpio: esp32: Check return value of pinmux_pin_input_enable()".


Add Ubuntu Oracular (24.10)

Is this going to be merged soon? I'm building oss projects against distributions, and would love to try on 24.10. Thank you.


Do console errors reference the correct character position?

If you type in M on it's own it says
line: 1
char: 2
ERROR
Expected 'opcode', got end of file
Is character 2  right? If it's meant to imply that character 2 (in that example) is intended to be the end of the opcode then I guess it makes sense.
If it's intended to imply that character 2 is an error then it's a little more confusing.
The more I read it I suspect the former, in which case probably not a problem!

I believe this is a duplicate of #127

Closing, duplicate.


Could not generate the web site from 1.0.15 binaries

Hello,
I need to generated the web site for two source code  repositories. For that i passed to the HtmlGenerator.exe two .sln files, i tried with the 1.0.14 version, the web site is generated but in the repo explorer bar i can see only one repository, i have to navigate through assmeblies to get to the second one.
So i wanted to try the latest version 1.0.15, but the web site isn't generated (i don't see any index.html ) , it fails with the exception bellow.
Is there a change between binaries of the two versions ? because i cannot find all .css/.js/.html files that used to be located in "\tools\web".
I have VS 2015 installed, i have both MSBuild 12 and 14. I am on Windows 7.
Thank you
15:57:11: First chance exception
System.Runtime.InteropServices.COMException (0x80040154): Retrieving the COM class factory for component with CLSID {177F0C4A-1CD3-4DE7-A32C-71DBBB9FA36D} failed due to the following error: 80040154 Class not registered (Exception from HRESULT: 0x80040154 (REGDB_E_CLASSNOTREG)).
   at System.RuntimeTypeHandle.CreateInstance(RuntimeType type, Boolean publicOnly, Boolean noCheck, Boolean& canBeCached, RuntimeMethodHandleInternal& ctor, Boolean& bNeedSecurityCheck)
   at System.RuntimeType.CreateInstanceSlow(Boolean publicOnly, Boolean skipCheckThis, Boolean fillCache, StackCrawlMark& stackMark)
```

```
15:57:11: First chance exception
System.DllNotFoundException: Unable to load DLL 'Microsoft.VisualStudio.Setup.Configuration.Native.dll': The specified module could not be found. (Exception from HRESULT: 0x8007007E)
   at Microsoft.Build.Shared.VisualStudioLocationHelper.GetSetupConfiguration(ISetupConfiguration& configuration, IntPtr reserved)
   at Microsoft.Build.Shared.VisualStudioLocationHelper.GetQuery()
```

```
15:57:12: First chance exception
System.ArgumentNullException: Value cannot be null.
Parameter name: o
   at System.Runtime.InteropServices.Marshal.GetIUnknownForObjectNative(Object o, Boolean onlyInContext)
   at Microsoft.Build.Tasks.InteropUtilities.RCWForCurrentContext`1..ctor(T rcw)
```

```
15:57:12 Workspace failed: Msbuild failed when processing the file 'D:\repo1\repo1.csproj' with message: C:\Program Files (x86)\MSBuild\12.0\bin\amd64\Microsoft.CSharp.CurrentVersion.targets: (448, 9): Invalid command line switch for "Csc.exe". Value cannot be null.
Parameter name: o
15:57:12 Msbuild failed when processing the file 'D:\repo1\repo1.csproj' with message: C:\Program Files (x86)\MSBuild\12.0\bin\amd64\Microsoft.CSharp.CurrentVersion.targets: (448, 9): Invalid command line switch for "Csc.exe". Value cannot be null.
```

Yes unfortunately I think you need VS 2017 and MSBuild 15.

Thank you for your reply.
Is it possible with 1.0.14 to generate one web site from multiple .sln ?

I think it was possible, I'm not sure though. Try using the command-line help.
Also just try specifying multiple solutions on the command line.

Yes the help shows that it is possible. As i mentioned, i already tried with two repos and the web site is generated, my issue is that i can't see both repositories on the index of the web site.
I tried to add in a file my two .sln full paths and passe it to HtmlGenerator through "/in", but didn't work either.
I will try to install MSBuild 15 and test with the latest version. I will keep you in touch

With MSBuild 15 and 1.0.15 version of sourcebrowser i no longer get the exception mentioned above, but still the index.html is not generated.
The destination folder of my web site has the following content :

index (which doesn't contain the index.html)

refs

runtimes

And a bunch of Microsoft dlls

Can you please provide me an explanation on the issue described in my last comment ? we do really hope to migrate to the latest version.
Thank you in advance

Could you read through https://github.com/KirillOsenkov/SourceBrowser/issues/80 and see if the investigation we did there helps?

Thank you for replay, i am using binaries from Nuget and the solution provided by the linked issue work when working with sources.
I suppose the latest nuget binaries version takes into account Alex's PR. If this isn't the case, i will try installing VS 2017 and work with sources instead, i will keep you informed.

I see, maybe I should regenerate and upload the latest NuGet binaries.

That would be great. Thank you

I've uploaded this: https://www.nuget.org/packages/Microsoft.SourceBrowser/1.0.16
Could you please try and let me know if this works for you? Thanks!

I did test with the new binaries on my machine which has MSBuild 15, i get to see the wwwroot folder generated which has the index.html, content folder...etc.
In my IIS server i link the web site with the index folder, but i don't get to see anything .
As @yaakov-h did in the linked issue, when i copy the content of wwwroot to index it works fine. We are generating the web site on every push on the repository so it won't be practical to copy wwwroot content each time.
No Errors.txt nor Messages.txt is generated.

Here's how I work with this:

git clone https://github.com/KirillOsenkov/SourceBrowser
Open SourceBrowser.sln in Visual Studio 2017
F5

By default it will generate the TestSolution.sln to C:\SourceBrowser\src\SourceIndexServer\index. After that, you can set the SourceIndexServer project as startup and F5. It will open IIS Express and the website should work fine.
Here's the layout on disk:

Index
    index
        Errors.txt
        DeclaredSymbols.txt
        results.html
        SolutionExplorer.html
        ...
    wwwroot
        index.html
        overview.html
        scripts.js
        styles.css
        ....
        content
            icons
                ...

When you serve the website, point it at the root Index, not at the index\index.

Hello @KirillOsenkov , sorry for the late replay.
Infortunatlly i was unable to test with the sources on my machine. For that i still keep investigating in the issue.
Here is what i find in the system log after enbaling the "stdoutLogEnabled" in the web.config:
Failed to start process with commandline '"dotnet" .\Microsoft.SourceBrowser.SourceIndexServer.dll', ErrorCode = '0x80004005'.
The folder ./logs isn't created, i see this warning :
Warning: Could not create stdoutLogFile \\?\D:\MySite\logs\stdout_1588_20171120111616.log, ErrorCode = -2147024891.
My machine has .net core 1.0.1, could this be the source of the problem? because i see in the Microsoft.SourceBrowser.SourceIndexServer.runtimeconfig.json file this:
"framework": {
      "name": "Microsoft.NETCore.App",
      "version": "1.1.2"
    },

Yes, try installing .Net Core SDK 1.1 and also 2.0. We've just updated from 1.1 to 2.0 but I didn't publish 2.0 packages yet.

Hello, sorry for the delay.
I used .Net core SDK 1.1.5 and i get to visualize the web site perfectly.
So to sum up for future visitors who use binaries instead of sources, here is what i did:

for the proxy exceptions i mentioned first in the issue: i added this to HtmlGenerator.config

         <system.net>
             <defaultProxy useDefaultCredentials="true" />
         </system.net>

By this the web site generation should normally work fine

you need .net core sdk >=1.1.* in order to visualize the web site on IIS server
point your IIS web site to the root folder of your sourcebrowser, let's say Index in this hierarchy:

Index
    index
        Errors.txt
        DeclaredSymbols.txt
        results.html
        SolutionExplorer.html
        ...
    wwwroot
        index.html
        overview.html
        scripts.js
        styles.css
        ....
        content
            icons
                ...

if you encounter any other problems with the server, say 502/401 server errors, it is actually a problem with your IIS web site configuration not with the sourcebrowser generator.

Thank you @KirillOsenkov for all your clarifications. The issue can be closed now

👍


upgrade logrus to v1.4.2

Description
upgrade logrus to v1.4.2
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

@thinkerou Can you please fix the conflict ?

@youngbupark done, thanks!

my mac is run OK:
➜  xyz git:(mod) go test ./... -mod=vendor
?   	github.com/dapr/components-contrib/bindings	[no test files]
ok  	github.com/dapr/components-contrib/bindings/blobstorage	0.017s
ok  	github.com/dapr/components-contrib/bindings/cosmosdb	0.034s
ok  	github.com/dapr/components-contrib/bindings/dynamodb	0.025s
ok  	github.com/dapr/components-contrib/bindings/eventhubs	0.036s
ok  	github.com/dapr/components-contrib/bindings/gcpbucket	0.102s
ok  	github.com/dapr/components-contrib/bindings/http	0.033s
ok  	github.com/dapr/components-contrib/bindings/kafka	0.017s
ok  	github.com/dapr/components-contrib/bindings/kubernetes	0.050s
ok  	github.com/dapr/components-contrib/bindings/mqtt	0.029s
ok  	github.com/dapr/components-contrib/bindings/pubsub	0.034s
ok  	github.com/dapr/components-contrib/bindings/rabbitmq	0.029s
ok  	github.com/dapr/components-contrib/bindings/redis	0.030s
ok  	github.com/dapr/components-contrib/bindings/s3	0.065s
ok  	github.com/dapr/components-contrib/bindings/servicebusqueues	0.029s
ok  	github.com/dapr/components-contrib/bindings/sns	0.032s
ok  	github.com/dapr/components-contrib/bindings/sqs	0.031s
?   	github.com/dapr/components-contrib/exporters	[no test files]
ok  	github.com/dapr/components-contrib/exporters/native	0.036s
?   	github.com/dapr/components-contrib/exporters/stringexporter	[no test files]
ok  	github.com/dapr/components-contrib/exporters/zipkin	0.039s
ok  	github.com/dapr/components-contrib/pubsub	0.032s
ok  	github.com/dapr/components-contrib/pubsub/redis	0.030s
?   	github.com/dapr/components-contrib/secretstores	[no test files]
ok  	github.com/dapr/components-contrib/secretstores/keyvault	0.043s
ok  	github.com/dapr/components-contrib/secretstores/kubernetes	0.041s
ok  	github.com/dapr/components-contrib/state	0.028s
ok  	github.com/dapr/components-contrib/state/cassandra	0.033s
ok  	github.com/dapr/components-contrib/state/consul	0.029s
?   	github.com/dapr/components-contrib/state/cosmosdb	[no test files]
ok  	github.com/dapr/components-contrib/state/etcd	0.029s
ok  	github.com/dapr/components-contrib/state/redis	0.031s

but CI is run error: https://github.com/dapr/components-contrib/pull/60/checks?check_run_id=279561629
go test ./... -mod=vendor
?   	github.com/dapr/components-contrib/bindings	[no test files]
# github.com/dapr/components-contrib/bindings/blobstorage [github.com/dapr/components-contrib/bindings/blobstorage.test]
##[error]bindings/blobstorage/blobstorage.go:64:2: undefined: logrus.Debugf
FAIL	github.com/dapr/components-contrib/bindings/blobstorage [build failed]
ok  	github.com/dapr/components-contrib/bindings/cosmosdb	0.003s
ok  	github.com/dapr/components-contrib/bindings/dynamodb	0.021s
# github.com/dapr/components-contrib/bindings/eventhubs [github.com/dapr/components-contrib/bindings/eventhubs.test]
##[error]bindings/eventhubs/eventhubs.go:87:5: undefined: logrus.Errorf
##[error]bindings/eventhubs/eventhubs.go:113:3: undefined: logrus.Infof
FAIL	github.com/dapr/components-contrib/bindings/eventhubs [build failed]
ok  	github.com/dapr/components-contrib/bindings/gcpbucket	0.006s
ok  	github.com/dapr/components-contrib/bindings/http	0.004s
# github.com/dapr/components-contrib/bindings/s3 [github.com/dapr/components-contrib/bindings/s3.test]
##[error]bindings/s3/s3.go:61:3: undefined: logrus.Debugf
# github.com/dapr/components-contrib/bindings/sqs [github.com/dapr/components-contrib/bindings/sqs.test]
##[error]bindings/sqs/sqs.go:87:4: undefined: logrus.Errorf
# github.com/dapr/components-contrib/bindings/kafka [github.com/dapr/components-contrib/bindings/kafka.test]
##[error]bindings/kafka/kafka.go:148:5: undefined: logrus.Errorf
FAIL	github.com/dapr/components-contrib/bindings/kafka [build failed]
ok  	github.com/dapr/components-contrib/bindings/kubernetes	0.010s
ok  	github.com/dapr/components-contrib/bindings/mqtt	0.003s
ok  	github.com/dapr/components-contrib/bindings/pubsub	0.035s

my mac is run OK:
➜  xyz git:(mod) go test ./... -mod=vendor
?   	github.com/dapr/components-contrib/bindings	[no test files]
ok  	github.com/dapr/components-contrib/bindings/blobstorage	0.017s
ok  	github.com/dapr/components-contrib/bindings/cosmosdb	0.034s
ok  	github.com/dapr/components-contrib/bindings/dynamodb	0.025s
ok  	github.com/dapr/components-contrib/bindings/eventhubs	0.036s
ok  	github.com/dapr/components-contrib/bindings/gcpbucket	0.102s
ok  	github.com/dapr/components-contrib/bindings/http	0.033s
ok  	github.com/dapr/components-contrib/bindings/kafka	0.017s
ok  	github.com/dapr/components-contrib/bindings/kubernetes	0.050s
ok  	github.com/dapr/components-contrib/bindings/mqtt	0.029s
ok  	github.com/dapr/components-contrib/bindings/pubsub	0.034s
ok  	github.com/dapr/components-contrib/bindings/rabbitmq	0.029s
ok  	github.com/dapr/components-contrib/bindings/redis	0.030s
ok  	github.com/dapr/components-contrib/bindings/s3	0.065s
ok  	github.com/dapr/components-contrib/bindings/servicebusqueues	0.029s
ok  	github.com/dapr/components-contrib/bindings/sns	0.032s
ok  	github.com/dapr/components-contrib/bindings/sqs	0.031s
?   	github.com/dapr/components-contrib/exporters	[no test files]
ok  	github.com/dapr/components-contrib/exporters/native	0.036s
?   	github.com/dapr/components-contrib/exporters/stringexporter	[no test files]
ok  	github.com/dapr/components-contrib/exporters/zipkin	0.039s
ok  	github.com/dapr/components-contrib/pubsub	0.032s
ok  	github.com/dapr/components-contrib/pubsub/redis	0.030s
?   	github.com/dapr/components-contrib/secretstores	[no test files]
ok  	github.com/dapr/components-contrib/secretstores/keyvault	0.043s
ok  	github.com/dapr/components-contrib/secretstores/kubernetes	0.041s
ok  	github.com/dapr/components-contrib/state	0.028s
ok  	github.com/dapr/components-contrib/state/cassandra	0.033s
ok  	github.com/dapr/components-contrib/state/consul	0.029s
?   	github.com/dapr/components-contrib/state/cosmosdb	[no test files]
ok  	github.com/dapr/components-contrib/state/etcd	0.029s
ok  	github.com/dapr/components-contrib/state/redis	0.031s

but CI is run error: https://github.com/dapr/components-contrib/pull/60/checks?check_run_id=279561629
go test ./... -mod=vendor
?   	github.com/dapr/components-contrib/bindings	[no test files]
# github.com/dapr/components-contrib/bindings/blobstorage [github.com/dapr/components-contrib/bindings/blobstorage.test]
##[error]bindings/blobstorage/blobstorage.go:64:2: undefined: logrus.Debugf
FAIL	github.com/dapr/components-contrib/bindings/blobstorage [build failed]
ok  	github.com/dapr/components-contrib/bindings/cosmosdb	0.003s
ok  	github.com/dapr/components-contrib/bindings/dynamodb	0.021s
# github.com/dapr/components-contrib/bindings/eventhubs [github.com/dapr/components-contrib/bindings/eventhubs.test]
##[error]bindings/eventhubs/eventhubs.go:87:5: undefined: logrus.Errorf
##[error]bindings/eventhubs/eventhubs.go:113:3: undefined: logrus.Infof
FAIL	github.com/dapr/components-contrib/bindings/eventhubs [build failed]
ok  	github.com/dapr/components-contrib/bindings/gcpbucket	0.006s
ok  	github.com/dapr/components-contrib/bindings/http	0.004s
# github.com/dapr/components-contrib/bindings/s3 [github.com/dapr/components-contrib/bindings/s3.test]
##[error]bindings/s3/s3.go:61:3: undefined: logrus.Debugf
# github.com/dapr/components-contrib/bindings/sqs [github.com/dapr/components-contrib/bindings/sqs.test]
##[error]bindings/sqs/sqs.go:87:4: undefined: logrus.Errorf
# github.com/dapr/components-contrib/bindings/kafka [github.com/dapr/components-contrib/bindings/kafka.test]
##[error]bindings/kafka/kafka.go:148:5: undefined: logrus.Errorf
FAIL	github.com/dapr/components-contrib/bindings/kafka [build failed]
ok  	github.com/dapr/components-contrib/bindings/kubernetes	0.010s
ok  	github.com/dapr/components-contrib/bindings/mqtt	0.003s
ok  	github.com/dapr/components-contrib/bindings/pubsub	0.035s

@thinkerou I do not know why it passed in mac, but not in linux. Can you try to run the test in linux box ?


feat: add more notation attributes to values.yaml

Description
What this PR does / why we need it:
Currently, helm chart parameters exist for ORAS stores and KMP resources, but not for Notation Verifier. We need to add parameters for setting up Notation Verifier.
Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #1965
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
[ ] This change requires a documentation update

How Has This Been Tested?

Checklist:

[ ] Does the affected code have corresponding tests?
[ ] Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
[ ] Does this introduce breaking changes that would require an announcement or bumping the major version?
[ ] Do all new files have appropriate license header?

Post Merge Requirements

[ ] MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@yizha1 @akashsinghal @susanshi
I update the PR:
I added verificationCertStores to values.yaml so that the user can manage notation cert stores directly before installing Ratify.
1- The current values inside values.yaml ensures the same functionality as the existing helm chart. In other words, when installing Ratify after applying this PR, it will render the same notation verifier. Here is the result of running helm template test ./charts/ratify --set featureFlags.RATIFY_CERT_ROTATION=true --values ./charts/ratify/values.yaml --debug:
# Source: ratify/templates/verifier.yaml
apiVersion: config.ratify.deislabs.io/v1beta1
kind: Verifier
metadata:
  name: verifier-notation
  annotations:
    helm.sh/hook: pre-install,pre-upgrade
    helm.sh/hook-weight: "5"
spec:
  name: notation
  version: 1.0.0
  artifactTypes: application/vnd.cncf.notary.signature
  parameters:
    verificationCertStores:
      certs:
    trustPolicyDoc:
      version: "1.0"
      trustPolicies:
        - name: default
          registryScopes:
            - "*"
          signatureVerification:
            level: strict
          trustStores:
            - ca:certs
          trustedIdentities:
            - "*"
---

The rendered template above, is exactly the same as running the same command for the existing release.
2- If the user intends to change notation settings, they can define multiple verificationCertStores (for each cert type which can be either ca or tsa or signingAuthority) and reference them inside trustStores of trustPolicies. I'll explain that with an example:
Here is a sample user-specified notation setting in values.yaml
notationCerts: ["filepath1", "filePath2", "filePath3"]
notation:
  enabled: true
  verificationCertStores:
    ca:
      certs-1:
        - kmprovider-akv
      certs-2:
        - notation-inline-cert-0
        - notation-inline-cert-1
    tsa:
      certs-3:
        - notation-inline-cert-2
    signingAuthority:
  trustPolicies:
      - name: my_private_registry
        registryScopes:
          - "skalantari_registry.azurecr.io/*"
        signatureVerification:
          level: strict
        trustStores:
          - ca: certs-1
        trustedIdentities:
          - "my identity"
      - name: mar_images
        registryScopes:
          - "mcr.azurecr.io/*"
        signatureVerification:
          level: strict
        trustStores:
          - ca: certs-2
        trustedIdentities:
          - "mar identity"

In the example above, the user intends to have two trustPolicies. The first one has trustStores set to - ca: certs-1 meaning that azure key vault KMP will be used with the specified trustedIdentities and scopes in the first trustPolicy. The second  one has trustStores set to - ca: certs-2 meaning that two inline notation certs will be used with the specified trustedIdentities and scopes in the second trustPolicy. Note that, in this structure, the private KMP which is AzureKeyVault and the inline certs  which are specified in notationCerts attribute in values.yaml, are still defined outside notation of the values.yaml file. For this setting to work, THE USER NEEDS TO USE THE RATIFY NAMING OF CERTS. Ie. the user should use the naming convention that Ratify follows, which is kmprovider-akv for Azure Key Vault, and  ratify-notation-inline-cert-{i} for cert files. In the example above, three notationCerts are defined (notationCerts: ["filepath1", "filePath2", "filePath3"]) and the verificationCertStores uses the mentioned naming convention to refer to them respectively, starting from index 0.
Here is the rendered template for the values specified above:
---
# Source: ratify/templates/verifier.yaml
apiVersion: config.ratify.deislabs.io/v1beta1
kind: Verifier
metadata:
  name: verifier-notation
  annotations:
    helm.sh/hook: pre-install,pre-upgrade
    helm.sh/hook-weight: "5"
spec:
  name: notation
  version: 1.0.0
  artifactTypes: application/vnd.cncf.notary.signature
  parameters:
    verificationCertStores:
        ca:
          certs-1:
            - kmprovider-akv
          certs-2:
            - notation-inline-cert-0
            - notation-inline-cert-1
        tsa:
          certs-3:
            - notation-inline-cert-2
    trustPolicyDoc:
      version: "1.0"
      trustPolicies:
        - name: my_private_registry
          registryScopes:
            - "skalantari_registry.azurecr.io/*"
          signatureVerification:
            level: strict
          trustStores:
            - ca:certs-1
          trustedIdentities:
            - "my identity"
        - name: mar_images
          registryScopes:
            - "mcr.azurecr.io/*"
          signatureVerification:
            level: strict
          trustStores:
            - ca:certs-2
          trustedIdentities:
            - "mar identity"
---

I tried to bring notationCerts inside verificationCertStores to avoid the mentioned caveat, however, it breaks a lot of tests. I found several tests that install ratify with --set notationCerts[0]=... and they will break if I move notationCerts to verificationCertStores. I also tried to change notationCerts to have name and filePath attributes, so that the user can specify their own name for each cert, however, it also failed for the same reason. It renders the template successfully, but it fails the tests and it may have the backward compatibility issue.

@akashsinghal @binbin-li: There is one e2e error failing at the moment. The default verifier template is exactly the same as before. However, I think because of the way notationCerts is parsed in the new verifier, that test is failing. Can you please have a look and see if you have any insights on how it can be fixed?
@yizha1 Other that the e2e error mentioned above, the PR is ready to test. I provided an example of the test in the PR description. Let me know if you need any help testing it.

Thanks @shahramk64. Overall it looks good with your examples of helm command.
Some questions:

Regarding setting registryScopes, currently Notary Project does not support registry level scope. Instead it supports * for any images or a list of repo URLs. So what it will look like for a list of repo URLs. For example, I need to configure a trust policy for skalantari_registry.azurecr.io/repo1, skalantari_registry.azurecr.io/repo2, what the parameters look like using the helm commands.
Note: The regstiryScope value like skalantari_registry.azurecr.io/* does not work for Notary Project today

Regarding setting trustedIdentities, per Notary Project spec, there is additional key word x509.subject:  before each identity that users input, so maybe the template of Notation Verifier need to add these key words?

will you add examples for AKV later?

Let me know if you have any questions/comments.

Thanks @shahramk64. Overall it looks good with your examples of helm command.
Some questions:

Regarding setting registryScopes, currently Notary Project does not support registry level scope. Instead it supports * for any images or a list of repo URLs. So what it will look like for a list of repo URLs. For example, I need to configure a trust policy for skalantari_registry.azurecr.io/repo1, skalantari_registry.azurecr.io/repo2, what the parameters look like using the helm commands.
Note: The regstiryScope value like skalantari_registry.azurecr.io/* does not work for Notary Project today
Regarding setting trustedIdentities, per Notary Project spec, there is additional key word x509.subject:  before each identity that users input, so maybe the template of Notation Verifier need to add these key words?
will you add examples for AKV later?

Let me know if you have any questions/comments.

1- The way to set registryScopes per trustPolicy is to provide the list one by one. For example:
--set notation.trustPolicies[0].registryScopes[0]="skalantari_registry.azurecr.io/repo1"
--set notation.trustPolicies[0].registryScopes[0]="skalantari_registry.azurecr.io/repo2"
2- I can add x509.subject: to the beginning of every trustedIdentity.
3- Here is an example of AKV:
helm template test ./charts/ratify --debug --set featureFlags.RATIFY_CERT_ROTATION=true \
  --set azurekeyvault.enabled=true \
  --set azurekeyvault.vaultURI=https://myKeyVault.vault.azure.net \
  --set azurekeyvault.certificates[0].name=cert_name1 \
  --set azurekeyvault.certificates[0].version=version1 \
  --set azurekeyvalut.tenantID=tenant1 \
  --set azurekeyvault.clientID=client1 \
  --set-file notationCerts[0]="notation-file1.crt" \
  --set notation.trustPolicies[0].registryScopes[0]="registry1.azurecr.io/" \
  --set notation.trustPolicies[0].trustedIdentities[0]="cert identity 1" \
  --set notation.trustPolicies[0].trustStores[0]=ca:notationCerts[0] \
  --set notation.trustPolicies[0].trustStores[1]=tsa:AzureKeyVault

As discussed, we should consider adding e2e test coverage for both inline and akv after this PR.


Can't print Chinese (zh-TW)

Thansk for the great plug-in, but since Version 1.10.0 it can not print Chinese (zh-TW) ...

It shouldn't be like this. Open the console and check if there are any error messages.

no error message in the console ...

here is a compariosn of the MD and PDF snapshot:

Then it should not be a problem with the plugin. Generally, this kind of issue is related to the operating system and the Electron version used by Obsidian. You can try reinstalling Obsidian.

Many thanks !! It works now😀

many thanks !!
after reinstalling, it works now.


Lib doesn't seem to read routes file

Hello there,
I'm trying to add express routes in swagger but for some reason the file is not read. Am I doing something wrong?
Some time ago I did a test and it seems to work well. But in this other folder organization model, the lib doesn't seem to work. @davibaltar would you help me?
The repository with the projects is in this link: https://github.com/bralandealmeida/swagger-example, and the model I'm referring to doesn't work is the one inside the TS folder.

Hi @bralandealmeida! Thank you for opening the issue.
I'll fix it as soon as possible.

The version 2.21.0 has fixed this. If the problem persists, let me know.

It's a bit of a strange behavior. I literally copied the swagger.js you mentioned and I still couldn't generate the routes that are inside the test project's routes file. Only the route that is inside the server.
I tried with the typescript and with the build version. No success with any. I updated the example repository again.

Thank you, I'll see it. And just to know, what OS and NodeJS version are you using?

Thank you, I'll see it. And just to know, what OS and NodeJS version are you using?

I'm using macOS 12.3.1 and NodeJS 16.13.

Sorry for the delay. I'm using macOS 10.14.6 and NodeJS 12.13.0. Any news, I'll post here.

I've tried to change the Node version to the same as yours, but with no success. I will also analyze and post any news here.

I think I may have understood the problem. When the lib reads the routes file inside ./src/shared/infra/routes/index.ts it is generating a wrong filepath of these routes, see:
./src/shared/infra/http/routes/modules/test/infra/routes/test.routes.ts
/Volumes/Slim/Projetos/community/swagger-autogen/src/handle-files.js:32
            console.log(data.trim());
                             ^

TypeError: Cannot read properties of undefined (reading 'trim')
    at ReadFileContext.callback (/Volumes/Slim/Projetos/community/swagger-autogen/src/handle-files.js:32:30)
    at FSReqCallback.readFileAfterOpen [as oncomplete] (node:fs:314:13)
error Command failed with exit code 1.

The correct path of the test.routes.ts file would be ./src/modules/test/infra/routes/test.routes.ts and not the one he's trying to find.

Another point is that she is not being able to understand the extension of this file when calling the readEndpointFile function.
./src/shared/infra/http/routes/modules/test/infra/routes/test.routes
/Volumes/Slim/Projetos/community/swagger-autogen/src/handle-files.js:31
            console.log('filePath', data.trim());

In the previous comment I had forced the extension on this line:
https://github.com/davibaltar/swagger-autogen/blob/085be9ee4229dfbddf16bf14ba8bb9bff5b0bfa4/src/handle-files.js#L1723

Hi @bralandealmeida! Thanks a lot for the PR. I've merged and I only made an adjustment at the line:
let baseUrl = tsBaseUrl && tsBaseUrl.split('/').length > 1 ? tsBaseUrl.split('/')[1] + '/' : './';
The tsBaseUrl.split('/').length > 1 avoid when tsconfig.json file constains for example "baseUrl": "." generate a baseUrl equals 'undefined/'.
The version 2.21.1 contains your code. Any problems, let me know.

Hi @bralandealmeida! Thanks a lot for the PR. I've merged it and I only made an adjustment at the line:
let baseUrl = tsBaseUrl && tsBaseUrl.split('/').length > 1 ? tsBaseUrl.split('/')[1] + '/' : './';
The tsBaseUrl.split('/').length > 1 avoid when tsconfig.json file constains for example "baseUrl": "." generate a baseUrl equals 'undefined/'.
The version 2.21.1 contains your code. Any problems, let me know.

Awesome! Works perfectly!


Awesome

Hey man , thanks for the amazing package . it deserves hundreds of stars really .
i want to use this package for my Ticketing system . any advice or example ?

Hi, I'm very happy that the package is good for you. If you wait for three weeks, something very good is being made.
I will inform you

Hey buddy, appreciate you checking in on the package progress. So, this package had a bit of a dependency party with other packages, and I'm investing some quality time in getting those sorted.  Trust me, I'm putting in the time to make sure something awesome comes out of it.


Change Images BACK to PNG

-Misread GD's message, coverted to Jpg.
-Converted to png for reals this time.

These two images are still technically jpeg:
Agent\KerbalAcademy.png
Agent\KerbalAcademy_scaled.png
The file header (first few bytes in ANSI):
ÿØÿà JFIF      ÿí „Photoshop 3.0 8BIM
Should start with:
‰PNG

Actually Im using MS paint...
Any thoughts on how one might make it work correctly?

Well, everybody has another taste, but for file viewing, screenshots and quick conversion I use https://www.xnview.com/en/xnviewmp/

Ok so all images are now actually png files. I think


Fine-tune parameters of transitive vulnerability search

Currently, transtive vulnerabilities are reconstructed from report_references (or policy_processed_references for FIPS), but only from directly_referenced_by and indirectly_referenced_by.
Shouldn't it be that if certificate X references certificate Y and vuln. appears in Y, then X is possibly vulnerable as well?
We should analyze and possibly fix that.

Shouldn't it be that if certificate X references certificate Y and vuln. appears in Y, then X is possibly vulnerable as well?

This is what the transitive computation of vulnerabilitites should be. Are you saying it is implemented in reverse? :grin:


Cameradar service backend

From @Ullaakut on October 18, 2017 12:33
Binary should implement basic functionalities of the cameradar binary and should be able to communicate with the electron app via JSON RPC over WebSocket or HTTP.
Copied from original issue: EtixLabs/cameradar#118

This issue was moved to EtixLabs/cameradar#140


Can't build on non-default version of gcc

We're trying to build a package with gcc 4.9. The system has versions 4.8, 4.8, 6.3 (default).
if __name__ == "__main__":
    builder = ConanMultiPackager(
    reference="switcher/0.4",
    upload=True,
    remote="barbarian")
    builder.add({"os": "Linux", "compiler": "gcc", "compiler.libcxx": "libstdc++", "compiler.version": "4.9", "build_type": "Debug", "arch": "x86"})
    builder.add({"os": "Linux", "compiler": "gcc", "compiler.libcxx": "libstdc++", "compiler.version": "4.9", "build_type": "Debug", "arch": "x86_64"})
    builder.run()

It seems to be the first time you've ran conan
Auto detecting your dev setup to initialize conan.conf
Found gcc 6.3
Default conan.conf settings
    os=Linux
    arch=x86_64
    compiler=gcc
    compiler.version=6.3
    compiler.libcxx=libstdc++
    build_type=Release
*** You can change them in ~/.conan/conan.conf ***
*** Or override with -s compiler='other' -s ...s***

WARN: Conanfile doesn't have 'url'.
It is recommended to add it as attribute
WARN: Conanfile doesn't have 'license'.
It is recommended to add it as attribute
WARN: Conanfile doesn't have 'description'.
It is recommended to add it as attribute
switcher/0.4@paulius/switcher_program: A new conanfile.py version was exported
switcher/0.4@paulius/switcher_program: Folder: /home/parallels/.conan/data/switcher/0.4/paulius/switcher_program/export
PROJECT: WARN: config() has been deprecated. Use config_options and configure
switcher/0.4@PROJECT
WARN: Remotes registry file missing, creating default one in /home/parallels/.conan/registry.txt

############## CONAN PACKAGE TOOLS ######################

DEBUG: - Skipped build, compiler mismatch: {'os': 'Linux', 'compiler.version': '4.9', 'compiler.libcxx': 'libstdc++', 'arch': 'x86', 'build_type': 'Debug', 'compiler': 'gcc'}

#########################################################

############## CONAN PACKAGE TOOLS ######################

DEBUG: - Skipped build, compiler mismatch: {'os': 'Linux', 'compiler.version': '4.9', 'compiler.libcxx': 'libstdc++', 'arch': 'x86_64', 'build_type': 'Debug', 'compiler': 'gcc'}

#########################################################

It looks like conan found the default compiler and is sticking with it. How can we make it recognise other versions? We could define the CXX variable or change the settings, but we're going to be doing multi-compiler builds pretty soon, and ConanMultiPackager seems like our best bet here.

Hi @DariusL, currently it looks for the default compiler (set on the PATH or CC/CXX) only.
I think the best approach will be to allow to pass a profile to builder.add or maybe a builder.add_profile. This way we could declare CC/CXX/PATH environment variables specific for that build. Even more, in conan 0.22 we are introducing build_requires in profiles, that mean that we could install conan packages (like a mingw compiler or other) specifing a require in the profile.
http://docs.conan.io/en/latest/mastering/profiles.html
WDYT?

I hoped we could avoid profiles, since we'll be having multiple configurations, lots of different compilers, different compiler versions, different OS's. So lots of profiles.

Maybe allow passing environment variables as a dictionary to each build? that way you could configure different compilers.

I think either profiles or the equivalent of .conf files would be best. Our main requirement is to build multiple configurations programmatically.

Hi!
I've just released conan_package_tools==0.3.1 supporting environment variables and build_requires.
Example:
if __name__ == "__main__":
    builder = ConanMultiPackager(reference="switcher/0.4", upload=True, remote="barbarian")
    compiler_dir = "path/to/your/compiler/bin"
    cxx = "g++"
    cc = "gcc"
    builder.add({"os": "Linux", "compiler": "gcc", "compiler.libcxx": "libstdc++",
                 "compiler.version": "3.8", "build_type": "Debug", "arch": "x86"},
                {},  # Options
                {"PATH": "[%s]" % compiler_dir, "CC": cc, "CXX": cxx},  # Env vars,
                {})  # Build requires
    builder.run()

It's important to declare the CC or CXX vars to skip the compiler version match check.
This way you could add programmatically different builds.

This looks good, I think we'll be able to use it.
A bit of an unrelated issue, any way to filter builds depending on the current OS? Right now we have
    if platform == Platform.macosx:
        builder.add({"os": "Macos", "compiler": "apple-clang", "compiler.libcxx": "libc++", "compiler.version": "8.0", "build_type": "Debug", "arch": "x86"})
        builder.add({"os": "Macos", "compiler": "apple-clang", "compiler.libcxx": "libc++", "compiler.version": "8.0", "build_type": "Debug", "arch": "x86_64"})
    elif platform == Platform.linux:
        builder.add({"os": "Linux", "compiler": "gcc", "compiler.libcxx": "libstdc++", "compiler.version": "4.9", "build_type": "Debug", "arch": "x86"})
        builder.add({"os": "Linux", "compiler": "gcc", "compiler.libcxx": "libstdc++", "compiler.version": "4.9", "build_type": "Debug", "arch": "x86_64"})
    else:
        builder.add({"os": "Windows", "compiler": "Visual Studio", "compiler.runtime": "MD", "compiler.version": "14", "build_type": "Release", "arch": "x86"})
        builder.add({"os": "Windows", "compiler": "Visual Studio", "compiler.runtime": "MD", "compiler.version": "14", "build_type": "Release", "arch": "x86_64"})

which is a mess. If I remove the branches, it tries to build an OS X binary on Windows and fails.

Are you thinking about something like this?

 builder.add({"os": "Macos", "compiler": "apple-clang", "compiler.libcxx": "libc++", "compiler.version": "8.0", "build_type": "Debug", "arch": "x86"})
 builder.add({"os": "Macos", "compiler": "apple-clang", "compiler.libcxx": "libc++", "compiler.version": "8.0", "build_type": "Debug", "arch": "x86_64"})
 builder.add({"os": "Linux", "compiler": "gcc", "compiler.libcxx": "libstdc++", "compiler.version": "4.9", "build_type": "Debug", "arch": "x86"})
 builder.add({"os": "Linux", "compiler": "gcc", "compiler.libcxx": "libstdc++", "compiler.version": "4.9", "build_type": "Debug", "arch": "x86_64"})
 builder.add({"os": "Windows", "compiler": "Visual Studio", "compiler.runtime": "MD", "compiler.version": "14", "build_type": "Release", "arch": "x86"})
 builder.add({"os": "Windows", "compiler": "Visual Studio", "compiler.runtime": "MD", "compiler.version": "14", "build_type": "Release", "arch": "x86_64"})

 builder.filter({"os": platform.system()})

It could be done easily but I don't see too much problem with your ifs, is practically the same, right?

Right now, because I hacked it together for a basic test. Later we'll be adding more compilers. I'll try filter, thanks.

Ey! Filter doesn't exist, yet. It has to be developed. Please open a new issue for that, you can paste the examples. I'll close this issue, please reopen if needed.


Update docs related to supported python version [ENG 199]

Proposed changes:

As part of this task, it is decided not to do any dependency upgrades but update the docs.
Fixes: https://rasahq.atlassian.net/browse/ENG-199
Status (please check what you already did):
[ ] added some tests for the functionality
[x] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

Thank you for the suggestions @ancalita :)


add mob member by url, to reduce friction point, and make it easier to mob with others

So That: I can easily get involved with the current mob
As A: Mob Organiser
I Want To: Send a url to a potential collaborator, that allows that to fill in a text field with their name, adding them to the mob.
--
Notes: Is this what is wanted? Discussion: https://twitter.com/alterisian/status/1623294428109582336

So the idea here is a url could be given that would have a user enter their name before the timer loads?

Yeah. That's it. Basically to make it easier for people to be invited, and join the mob.
One friction point removed a bit.
I initially thought that people could send this by whatsapp, twitter, email etc to potential MobInvitees. But it could probably also go into a calendar for yourself. Then the reminder would have the how to get involved in the mob, they put their name into buy into it, and the video/jitsi/pop/etc url on how to start, then look for the goals.


it can't extract .tmpl file

		nggettext_extract:{
			pot:{
				options:{
					startDelim:'##',
					endDelim:'##'
				},
				files:{
					'./lang/language.pot':['<%= config.src %>/web/**/*.html','<%= config.src %>/web/**/*.tmpl']
				}
			}
		},

i rename all template file in project with .tmpl,it can't trim it

You'll need to use the extensions option to map .tmpl files to html: https://github.com/rubenv/angular-gettext-tools/blob/a509df9d0d5d1c6ce4975d5f80b950cc95075463/lib/extract.js#L70-L79

Note that we can add it by default, but to do that, we need a sample file + unit test. Pull request in https://github.com/rubenv/angular-gettext-tools welcome!

so fast!with great thanks

and sorry...i dont konw how to write a unit test now

Closing this since it seems like you solved your issue.


README: how to build?

$ go get github.com/Comcast/vault-plugin-auth-cloudfoundry/cmd/vault-plugin-auth-cloudfoundry
package github.com/hashicorp/vault/logical: cannot find package "github.com/hashicorp/vault/logical" in any of:
	/usr/local/Cellar/go/1.12.5/libexec/src/github.com/hashicorp/vault/logical (from $GOROOT)
	/Users/drnic/Projects/gopath/src/github.com/hashicorp/vault/logical (from $GOPATH)
package github.com/hashicorp/vault/logical/framework: cannot find package "github.com/hashicorp/vault/logical/framework" in any of:
	/usr/local/Cellar/go/1.12.5/libexec/src/github.com/hashicorp/vault/logical/framework (from $GOROOT)
	/Users/drnic/Projects/gopath/src/github.com/hashicorp/vault/logical/framework (from $GOPATH)
package github.com/hashicorp/vault/helper/pluginutil: cannot find package "github.com/hashicorp/vault/helper/pluginutil" in any of:
	/usr/local/Cellar/go/1.12.5/libexec/src/github.com/hashicorp/vault/helper/pluginutil (from $GOROOT)
	/Users/drnic/Projects/gopath/src/github.com/hashicorp/vault/helper/pluginutil (from $GOPATH)
package github.com/hashicorp/vault/logical/plugin: cannot find package "github.com/hashicorp/vault/logical/plugin" in any of:
	/usr/local/Cellar/go/1.12.5/libexec/src/github.com/hashicorp/vault/logical/plugin (from $GOROOT)
	/Users/drnic/Projects/gopath/src/github.com/hashicorp/vault/logical/plugin (from $GOPATH)

If there are specific versions of dependencies that work, perhaps add dep support to the project to tie them all nicely together?

Thanks. This is very early days but we will firm up the process in due course. Please review the VENDOR read me as that may help.

On May 16, 2019, at 8:37 PM, Dr Nic Williams<EMAIL_ADDRESS>wrote:
$ go get github.com/Comcast/vault-plugin-auth-cloudfoundry/cmd/vault-plugin-auth-cloudfoundry
package github.com/hashicorp/vault/logical: cannot find package "github.com/hashicorp/vault/logical" in any of:
/usr/local/Cellar/go/1.12.5/libexec/src/github.com/hashicorp/vault/logical (from $GOROOT)
/Users/drnic/Projects/gopath/src/github.com/hashicorp/vault/logical (from $GOPATH)
package github.com/hashicorp/vault/logical/framework: cannot find package "github.com/hashicorp/vault/logical/framework" in any of:
/usr/local/Cellar/go/1.12.5/libexec/src/github.com/hashicorp/vault/logical/framework (from $GOROOT)
/Users/drnic/Projects/gopath/src/github.com/hashicorp/vault/logical/framework (from $GOPATH)
package github.com/hashicorp/vault/helper/pluginutil: cannot find package "github.com/hashicorp/vault/helper/pluginutil" in any of:
/usr/local/Cellar/go/1.12.5/libexec/src/github.com/hashicorp/vault/helper/pluginutil (from $GOROOT)
/Users/drnic/Projects/gopath/src/github.com/hashicorp/vault/helper/pluginutil (from $GOPATH)
package github.com/hashicorp/vault/logical/plugin: cannot find package "github.com/hashicorp/vault/logical/plugin" in any of:
/usr/local/Cellar/go/1.12.5/libexec/src/github.com/hashicorp/vault/logical/plugin (from $GOROOT)
/Users/drnic/Projects/gopath/src/github.com/hashicorp/vault/logical/plugin (from $GOPATH)
If there are specific versions of dependencies that work, perhaps add dep support to the project to tie them all nicely together?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


ttnn.std and  ttnn.var operations failed with low PCC value error [Grayskull and Wormhole]

Describe the bug
ttnn.std and ttnn.var operations break with "low PCC value" error in some test cases.
To Reproduce
Steps to reproduce the behavior:

Checkout barsic/model-preprocessing branch. To be merged into main soon.
Run unit tests test_std.py and test_var.py using these commands:
pytest tests/ttnn/python_api_testing/non_working_unit_tests/grayskull/test_std.py
pytest tests/ttnn/python_api_testing/non_working_unit_tests/grayskull/test_var.py
NOTE: the same calls should be used for the Wormhole, to avoid duplicating files.

Expected behavior
There is a test case presented in the unit test tests/ttnn/python_api_testing/non_working_unit_tests/grayskull/test_std.py and it is expected to fail with low PCC value error.
Getting Additional info for the operation under test and its behavior
To get additional information and results for different combinations of input shapes, types, layouts and memory configs for which this operation was tested you can also run locally sweeps for ttnn.std and check the results. To do this you should:

Follow the Getting Started page to setup the repo, environment variables and python-env
Activate source build/python_env/bin/activate
Run sweeps by using python tests/tt_eager/python_api_testing/sweep_tests/run_pytorch_test.py -i tests/ttnn/python_api_testing/sweep_tests/test_configs/ci_sweep_tests_broken/grayskull/ttnn_std_test.yaml -o ./result-sweeps
After the run is completed all test sweeps results should be available inside specified output directory (in this case ./result-sweeps). There you will find std_sweep.csv which holds all executed sweeps, among which you can also find the ones that failed and were recreated by the unit test, which you can get by searching unique data_seed field.

@banekg @jliangTT, this issue is due to reduce operation

will be revisited after TTNN migration

Hi @banekg

std works fine and the test passes.
Fix for variance : #7963