Support conda install

@pzelasko
I think it would be good to support
conda install -c kaldialign kaldialign

All you need to do is the following two steps I will take care of the rest.
Note: Step 1 is optional. If you don't do it, I will do it.
Step 1:
Create an account at https://anaconda.org/
The account name MUST be kaldialign. Otherwise, it is not possible to use -c kaldialign.
After creating the account, visit the following URL:
https://anaconda.org/kaldialign/settings/access

You will find the token at the bottom of that page after clicking Create.
Click view to get its value. (We don't need the name of the API token. Only its value is important).
Step 2
Visit
https://github.com/pzelasko/kaldialign/settings/secrets/actions
Click the button "New repository secret".
Name of the secret should be: KALDIALIGN_CONDA_TOKEN
Value of the secret:  Please paste the value of the API token you copied from step 1.
That is all.

Thanks @csukuangfj! I will set it all up and let you know when it's done.

@csukuangfj done, let me know what's next (great tutorial btw)


Issue with saving

Hi, I tried to test how it works and when I enter the name of the zip file the studio drops an error..any idea what it could be? P.S I used some sample scorm files (eg https://scorm.com/scorm-explained/technical-scorm/golf-examples/)

Thank you @mslyon for providing your feedback!
Do you see any error in the CMS log ? Can you please upload it ?
Can you also provide the exact SCORM package you are trying to load ?

Thank you @mslyon for providing your feedback!
Do you see any error in the CMS log ? Can you please upload it ?
Can you also provide the exact SCORM package you are trying to load ?

Hi
CMS logs is this one:
2020-09-15 08:26:29,875 WARNING 4823 [abstract_scorm_xblock.scormxblock] scormxblock.py:122 - SCORM package "Intro.zip" not found
Here is the scorm file: https://drive.google.com/file/d/1fYHjXwaStnhlhwj0zhW4308_TresqSyg/view?usp=sharing
Also, I'm using bitnami Ironwood.
thanks.

The SCORM package needs to be uploaded through the "Files & Upload" section of your course and then referenced by name (e.g. "Intro.zip" in your case) in the XBlock "SCORM file package" field.
Good that you are using Ironwood since the XBlock is not yet compatible with Juniper.
Could you please try again?
Please let me know if the issue persist.

that is exactly what I did and it throws the error. COuld it be that bitnami Ironwood stores the file somewhere else and the code does not pick it up where it should?

The code is looking into course files which are stored within the course in the MongoDB database.
The search is case sensitive and if the filename set on the XBlock doesn't match exactly a zipfile loaded in the course files an error is raised.
I can't reproduce your issue so i'm going to test on a Bitnami setup before coming back to you again, thank you for you patience.

Hi @mslyon , sorry for making you wait so long. I finally managed to test the XBlock on a Bitnami installation.
Unfortunately i could not reproduce your problem since the XBlock was able to find the zip package with no issues (screenshots attacched).

There is indeed a problem since by default Django sets the X-Frame-Options header to "DENY" which will prevent your browser from loading the SCORM content in an iframe. This is easily solved by adding a setting "X_FRAME_OPTIONS" in the Django settings module (which on a bitnami installation is /home/bitnami/apps/edx/edx-platform/lms/envs/bitnami.py for the LMS and /home/bitnami/apps/edx/edx-platform/cms/envs/bitnami.py for the CMS) like shown in the following screenshot.

thanks a lot - I tried and still the same "Studio's having trouble saving your work" - I will install it from scratch..thanks a  lot.

I also have above same issue. Are you found any resolution? Please advice.


[Bug]: On saving and authorizing auth api, from a branch in a git connected app, user is thrown out of application

Is there an existing issue for this?

[X] I have searched the existing issues

Description
On saving and authorizing an authenticated api, from a branch in a git connected app, user is thrown out of application
Steps To Reproduce

Create a git conected app
Create  a branch, and from the branch, create an Auth API.
Save and authorize this.
Note that user is taken to the home page, instead of retaining the user on the Review page.
Note: If the above steps are done from the Master branch, it works fine

Public Sample App
No response
Environment
Deploy Preview
Issue video log
No response
Version
Cloud

As per discussions on the slack thread, this is an issue seen on Release as well, in a particular case where the Page ID's don't match. Removing PR Blocker tag and assigning adding this to Prod .. cc: @ayushpahwa

changing tags to platform pod because

Not able to reproduce this on Production v1.18, hence closing this as of now.


need to use the new times for the script line inside the while loop

Maybe try a stringstream to get the same formatting.

https://en.cppreference.com/w/cpp/string/basic_string/to_string
for ways in which to_string can format. But we would probably need to use another method, since to_string doesn't have any other formatting parameters.

Fixed by using << prevdvalue[] instead of << prevwords[]


Error importing draw from pymunk.pygame_util

I wanted to run your code on my window 10 with 32bit python installed but its giving me an ImportError saying cannot import name draw  which is occurring on carmunk.py file please help

Hello @mzkhan141 change it to pymunk.pygame_util.DrawOptions

now it says no module named DrawOptions

This will do the trick.
from pymunk.pygame_util import DrawOptions as draw

You will get more issues with version > 5.0.0 from pymunk. Solution is pip install pymunk == 4.0.0

As @anthdm said, you need to use pymunk 4.
Quick way to downgrade is:
pip3 install pymunk==4.0.0
Then CD into your dist-packages/pymunk and run 2to3 -w *py.
This fixed it for me recently.

from pymunk.pygame_util import DrawOptions as draw
works thanks
but
game_state = carmunk.GameState()
gives error
builtins.NameError: name 'carmunk' is not defined


The data is not being created

I have just installed this plugin and I am fairly new to obsidian.
I have installed and enabled the plugin, connected my account and set up my folders:

When I selected sync pocket items it states it is running and syncs 2 items which is the correct number. However, in the folder where they should be there is nothing (and it has not gone into any other folder either) so I am unsure what to try next.
I am on an M1 Mac version 12.1, Obsidian v.0.13.23 Pocket v.0.5.5

Hello,
Sorry you’re experiencing some unexpected behavior!
Did you just sync Pocket items, or did you also open the Pocket item list
and click on an item to create a Pocket item note?
Currently, notes aren’t created automatically for Pocket items - you have
to click on the Pocket item list to create the note.
I’m working on some changes to make it possible to have the Pocket item
notes created automatically in sync. If you have any input on how you’d
expect things to work, I’d appreciate it.
On Fri, Feb 4, 2022 at 08:09 Susan Pearson @.***> wrote:

I have just installed this plugin and I am fairly new to obsidian.
I have installed and enabled the plugin, connected my account and set up
my folders:
[image: CleanShot 2022-02-04 at 16 03 @.***
https://user-images.githubusercontent.com/39191327/152561791-86e600ba-cba5-48d0-9d74-fd4115808203.png
When I selected sync pocket items it states it is running and syncs 2
items which is the correct number. However, in the folder where they should
be there is nothing (and it has not gone into any other folder either) so I
am unsure what to try next.
I am on an M1 Mac version 12.1, Obsidian v.0.13.23 Pocket v.0.5.5
—
Reply to this email directly, view it on GitHub
https://github.com/nybbles/obsidian-pocket/issues/77, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADG36MYKWEFY3ZRWJU7JXLUZP24XANCNFSM5NSFZO5Q
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Nimalan

Hi,
So, I cleared the synced data and tried again. I synced in the plugin and then clicked on the empty list and that didn't do anything, then I tried creating a new note from the template and that didn't do anything either.
I don't know at this point if there is a conflict with another plugin? But I don't know what else I can try doing to get it to work.
I would expect it would work a little like the Kindle Highlights plugin where you click the sync icon in the sidebar and it automatically happens. The Kindle icon looks a bit like a Kindle so the pocket icon could be like the actual pocket icon.

can you attach a screenshot of the empty list? What did you click on if the list was empty?
You currently have to create the Pocket item notes by first opening the Pocket item list:

Then you click on the title of the Pocket item to create the Pocket item note:

So in that example, I have already clicked on and created notes for the first and third items, but not for the second one.

Thank you, your screenshot was enough to show me what I was doing wrong. I was not using the command open pocket list, I was literally clicking on the folder in the sidebar. I said I was pretty new to Obsidian - doh. I now have it working fine. Can I ask rather than using {{extract}} is it possible to bring the whole article? if so what code would I need. I like to create a source note with the whole blog post etc then I can highlight it and add my own thoughts in etc and then link it to permanent notes around the subject.

No worries! It's not that intuitive, so I understand where you're coming from. Welcome to Obsidian!
Unfortunately I can't get the whole article text using just the Pocket API (which is what I'm trying to stick to, within the scope of this plugin). I think there might be other plugins that do this, i.e. given a URL associated with an Obsidian note, download the URL and convert it to Markdown.

I'm going to close this issue now, since it seems like you've gotten your problem solved. Feel free to reopen if it has not been addressed, and open new issues if anything arises.


Change dual SHA1-SHA256 signing to SHA256-only (VS2017)

Updating VS2017 branch to change dual SHA1-SHA256 signing to SHA256-only.

@bricelam Same change as #893 - but for the VS2017 branch.


feat(build): add full dockerfile containing yarn step

Description
Full build dockerfile for frontend registration image with yarn stage.
Why
We can create images without yarn installed and this change streamlines dockerfiles across portal repositories.
Issue
Refs: #186
Checklist

[x] I have performed a self-review of my own code
[x] I have successfully tested my changes locally

@evegufy @oyo any update on this?

sorry for the late review, looks good in general.
I'd just change the base branch to dev as we still have that the dev flow in place for this repo.
And another thing: could you please rename the prebuilt dockerfile to Dockerfile.prebuilt and adjust the referencing in the workflow files accordingly, example, so that we improve also on the understanding of why there are now two dockerfiles.
Thank you!

Hi Evelyn,
Thanks for the reply. At first I did not want to touch the existing Dockerfile since external workflows/jobs might be using the previous name.
I can't fully evaluate the risks but made the requested changes.
Cheers


notebook 7

double-well example:

vamp is used without any arguments. That is bad practice because at least the user will want to select a lagtime.
For this example the default lag time (10) seems too large, because the second singular value only appears to have a contribution of 0.08.
There is no explanation about the VAMP values, e.g. why the VAMP score is 1 for the bad direction and what this means.

alanine dipeptide

the RMSD is really pointless, remove that. Use something else instead, such as Cartesian coordinates after aligning to a reference structure. That should still be worse than using the dihedrals.
I don't think a direct application of VAMP to dihedral makes sense, because dihedrals are periodic but VAMP is linear. Use cos/sin of dihedrals.
RMSD and dihedral VAMP scores and MSM analyses are in a confusing order, this is hard to follow, needs to be cleaned up.

**I suggest this notebook to be reviewed by @fabian-paul **

Hi all,
I'm happy to review the tutorial. I also want to remind you, that there is already some material for feature selection with VAMP, see https://github.com/markovmodel/pyemma-workshop/blob/master/notebooks/VAMP_01_feature_selection.ipynb
We could probably also reuse some martial from Frank's slides from the last workshop.

On 02.07.2018 21:54, fabian-paul wrote:

Hi all,
I'm happy to review the tutorial. I also want to remind you, that there is already some material for feature selection with VAMP, see https://github.com/markovmodel/pyemma-workshop/blob/master/notebooks/VAMP_01_feature_selection.ipynb
We could probably also reuse some martial from Frank's slides from the last workshop.

Hi Fabian,
we've decided that we are going to restructure the tutorial a bit. The
VAMP estimation and scoring will be demonstrated along with a comparison
with TICA and PCA, so please standby with reviewing this right now.
Thank you for pointing us to the the previous tutorial, this is helpful.
Best,
Martin


Add debug logger showing the glyph name for which gvar is built

When building gvar, some situations cause fontmake/varLib to fail, for example if a component has a coordinate that's >32k or <-32k. This adds a debug line that prints each glyph name for which gvar is built, so it’s easier to pinpoint where the faulty glyph is.

i'm surpised to read Github says this is your "first contribution" to fonttools, is that so? :)

When Just and then Behdad were maintainers, I explained my suggestions with words, used issues etc. :) I haven’t contributed code via a PR yet :)


use shared examples

A lot of duplication can be removed by using RSpec's shared examples.

Closing since WatirSpec is not maintained.


Replace flaky regexes with local uuid tags

SOUS-1017

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.

  Generated by :no_entry_sign: Danger

Codecov Report

Merging #748 into master will increase coverage by 0.04%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
+ Coverage   56.24%   56.29%   +0.04%
==========================================
  Files         262      263       +1
  Lines       15292    15284       -8
==========================================
+ Hits         8601     8604       +3
+ Misses       5962     5955       -7
+ Partials      729      725       -4

Impacted Files
Coverage Δ

ext/docker/dockerfile_buildpack.go
36.36% <0%> (+0.8%)
:arrow_up:

ext/docker/splitcontainer_splitbuilder.go
68.31% <100%> (+1.65%)
:arrow_up:

ext/docker/buildutil.go
100% <100%> (ø)

ext/docker/splitcontainer_runnablebuilder.go
79.41% <100%> (+2.26%)
:arrow_up:

ext/docker/runmount_builder.go
73.71% <85.71%> (+1.33%)
:arrow_up:

lib/auto_resolver.go
89.55% <0%> (+1.49%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fb9009...27c7adf. Read the comment docs.


[e2e]: generic release main default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/v24.0.1
Run: https://github.com/slsa-framework/example-package/actions/runs/7675641368
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.release.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.release.main.default.slsa3.yml
Trigger: release
Branch: v24.0.1
Date: Sat Jan 27 02:07:26 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/v24.0.2
Run: https://github.com/slsa-framework/example-package/actions/runs/7705279145
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.release.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.release.main.default.slsa3.yml
Trigger: release
Branch: v24.0.2
Date: Tue Jan 30 02:12:54 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/v24.0.3
Run: https://github.com/slsa-framework/example-package/actions/runs/7735235436
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.release.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.release.main.default.slsa3.yml
Trigger: release
Branch: v24.0.3
Date: Thu Feb  1 02:18:16 UTC 2024
Tests are passing now. Closing this issue.


Fixes class logger variable name, keep the same with other class file.

Purpose of this pull request
Fixes class logger variable name, keep the same with other class file.

Thank you for your contribution, and look forward to your next contribution.
btw, I prefer @slf4j to reduce unnecessary code. But this needs to be discussed, let's talk about this later.

Thank you for your contribution, and look forward to your next contribution.
btw, I prefer @slf4j to reduce unnecessary code. But this needs to be discussed, let's talk about this later.

Thank you for your contribution, and look forward to your next contribution. btw, I prefer @slf4j to reduce unnecessary code. But this needs to be discussed, let's talk about this later.

Hi @CalvinKirs , Thanks for you reply, @slf4j is a good tools.

Thank you for your contribution, and look forward to your next contribution. btw, I prefer @slf4j to reduce unnecessary code. But this needs to be discussed, let's talk about this later.

Hi @CalvinKirs , Thanks for you reply, @slf4j is a good tools.


Update Spring Boot related tests

Update tests that reference 2.x Spring Boot to the latest available 2.6.7 release.
Modify tests that reference 1.x Spring Boot to use 2.6.7 instead. Also update the Liberty version used as it is quite old at <IP_ADDRESS>.

They are located here: https://github.com/OpenLiberty/ci.maven/tree/main/liberty-maven-plugin/src/it/springboot-tests

@anjumfatima90 I am running into problems when trying to update these tests.

Updating to use a newer Open Liberty <IP_ADDRESS> causes the application to not deploy correctly. The test case gets a 404 when trying to connect.
Updating the classifier test case to use Spring Boot version 2.6.7 causes the jar without the classifier to get deployed in Liberty (and not to a spring folder in the apps folder).

I wanted to update both test cases to use Spring Boot 2.6.7 and Open Liberty <IP_ADDRESS>. Can you look into these issues and see if our plugin needs some fixes, or if Open Liberty needs some fixes? The behavior is different when I change either of the versions.

Please update  src/it/springboot-tests/springboot-appsdirectory-apps-it/pom.xml. Remove the following lines
<plugin>
				<groupId>org.springframework.boot</groupId>
				<artifactId>spring-boot-maven-plugin</artifactId>
				<!-- Test support for classifier configuration parameter -->
				<executions>
					<execution>
						<goals>
							<goal>repackage</goal>
						</goals>
						<configuration>
							<classifier>exec</classifier>
						</configuration>
					</execution>
				</executions>
			</plugin>

And replace it with
<plugin>
				<groupId>org.springframework.boot</groupId>
				<artifactId>spring-boot-maven-plugin</artifactId>
				<!-- Test support for classifier configuration parameter -->
				<configuration>
				    <classifier>exec</classifier>
				</configuration>
</plugin>


Glasgow 6 | Haroun Alarabi | Full-Stack-Project-Assessment | Level 300

https://level-300--verdant-crisp-d6d210.netlify.app/
Hi @Dedekind561 I'm attempting to display data from Render in browser but i's not showing up. However, when I use Postman to retrieve the data from Render, it works as expected."

Hi @HarounAlarabi ,
Thankyou for submitting Level 300 of the Full Stack Project Assessment. However, at the moment, I can't review your work properly. Locally I'm just seeing a blank screen with a heading Video Recommendation - do you have a deployed version of the site itself?

Morning Haroun,
Thankyou for submitting a link to your deployed application.
At the moment, I can't review your work because you've committed the node_modules. Please can you remove them from your pull request then I can take a look :)

The deployed version of your app is now working for me at the moment :)

Hi @Dedekind561  I have commited the code again with changes


feat: add msg91 as phone provider (fork of #989)

Same as #989 with some technical details resolved.

Hey @MeetChaudhari @hf @kangmingtay any update for this ? Went through comments on #989, it looks like this won't be merged until webhook solution is implemented. So, any idea about what is the status on webhook solution ?
This is turning out to be a blocker for Indian Startups. Hope we receive a update soon. Thanks!!

Hey @MeetChaudhari @hf @kangmingtay any update for this ? Went through comments on #989, it looks like this won't be merged until webhook solution is implemented. So, any idea about what is the status on webhook solution ?
This is turning out to be a blocker for Indian Startups. Hope we receive a update soon. Thanks!!

I completely agree with you @paigham-tech , even our startup had to go with a different implementation than supabase just due to this auth provider thing,
But as i am aware, the webhook based auth implementation is pending from supabase team side, @hf  please correct me if i am wrong.
@paigham-tech  As soon as supabase team implements webhook based system, ill write the webhook based integration or whatever required for Msg91 support.

Waiting for this

Hey @MeetChaudhari,
Thanks for the implementation. We're implementing it now and will circle back with further updates soon. I'm heading to India this weekend and hope to test it then if I can get a number. I'm going to close this PR for now but will reach back out once we're closer to completion on the hook implementation
Let us know if there are further queries.
Thanks

Hey @MeetChaudhari,
Thanks for the implementation. We're implementing it now and will circle back with further updates soon. I'm heading to India this weekend and hope to test it then if I can get a number. I'm going to close this PR for now but will reach back out once we're closer to completion on the hook implementation
Let us know if there are further queries.
Thanks

what is the status?

Hey @rohankm,
Feel free to follow along on #1474. Testing some final bits.

Hey @rohankm @MeetChaudhari,
Thanks for patiently waiting. We'll be moving forward with the Hooks implementation soon and are open to taking contributions for a msg91 -here's what it looks like for Twilio
If you're still keen on adding Msg91 as a custom SMS provider feel free to let me know and will follow up with next steps.
Thanks!

Hey @rohankm @MeetChaudhari,
Thanks for patiently waiting. We'll be moving forward with the Hooks implementation soon and are open to taking contributions for a msg91 -here's what it looks like for Twilio
If you're still keen on adding Msg91 as a custom SMS provider feel free to let me know and will follow up with next steps.
Thanks!

Hey @J0,
Thanks for reaching out, yes I am still up for integration of msg91, how can we proceed.

Hi,
I have already implemented msg91 and its working fine.
Here is the fork https://github.com/rohankm/gotrue.git

Hi,
I have already implemented msg91 and its working fine.
Here is the fork https://github.com/rohankm/gotrue.git

Hey, @rohankm
I haven't checked the fork, but if it's based on my fork of initial implementation then it won't work as the supabase team is switching to an webhook based implementation which @J0 is talking about.

Hi,
I have already implemented msg91 and its working fine.
Here is the fork https://github.com/rohankm/gotrue.git

Hey, @rohankm
I haven't checked the fork, but if it's based on my fork of initial implementation then it won't work as the supabase team is switching to an webhook based implementation which @J0 is talking about.

I understand but I didn't have time to wait for the supabase team to implement it and its not based on webhooks

Hi,
I have already implemented msg91 and its working fine.
Here is the fork https://github.com/rohankm/gotrue.git

Hey, @rohankm
I haven't checked the fork, but if it's based on my fork of initial implementation then it won't work as the supabase team is switching to an webhook based implementation which @J0 is talking about.

I understand but I didn't have time to wait for the supabase team to implement it and its not based on webhooks

Yup, I got it bro anyways none of our implementation will move forward, as now it has to be webhook based one, I'll start working on it as soon as @J0 pings me up with necessary stuff, I am right now studying the example implementation of twilio which he shared.

@MeetChaudhari do you have Discord? If so I'll open a thread there with details - else I can open a Github issue or discussion in this repo and tag you

@MeetChaudhari do you have Discord? If so I'll open a thread there with details there and tag you - else I can open a Github issue or discussion in this repo and tag you
Actually, let's stick to Github for visibility - will open an issue.

My discord username - kreferlink

@J0  @MeetChaudhari any progress?

@J0  @MeetChaudhari any progress?

Was Stuck in something, will start today

No worries - feel free to ping me if there's anything confusing

Folks, checking in - any issues here or anything we can help with?

@MeetChaudhari are you working on this?

@MeetChaudhari are you working on this?

Yes, mostly it will be done within the next week or so, it's delayed as I am working on so many things together.


Java Bolt: unable to get request payload for block action

I have started exploring slack interactive component using block kit and currently, facing issue with getting payload on button click.
I am able to create and send block action to slack but unable to get the request payload on button click.
Please find below the code snippet:-
// when a user clicks a button in the actions block
app.blockAction("button-action", (req, ctx) -> {
  System.out.println("inside block action");
  String value = req.getPayload().getActions().get(0).getValue(); // "button's value"
  if (req.getPayload().getResponseUrl() != null) {
    // Post a message to the same channel if it's a block in a message
    ctx.respond("You've sent " + value + " by clicking the button!");
  }

Hello @BaradPuja , can you check the Slack App Configuration part in the document?
https://slack.dev/java-slack-sdk/guides/interactive-components
Configuring Request URL beforehand in Interactivity & Shortcuts page is required.

Hi @Seratch, I already configured the api url and I am using the same url both for event subscription and interactive component

Can you check the following?

Check your app's access logs to know your app surely received requests from Slack

If you use ngrok, access http://localhost:4040/inspect/http
if you're not sure about how to check this - having this kind of middleware may be helpful

If your app is surely receiving requests and the listener for the action_id "button-action" doesn't work as you expect:

Verify if the action_id set to the button is "button-action" (if you don't have action_id in the block element, a randomly generated value should be set to the field)

if you're not sure about how to check this - having this kind of middleware may be
app.use method gets executed when I/m posting a message to slack
if(userMsg.equals("help")) {   						ctx.say(asBlocks(   							      actions(actions -> actions   							      .elements(asElements(   							        button(b -> b.actionId("button-action").text(plainText(pt -> pt.text("Yes"))).value("yes"))   							      ))   							    )   							  ));

Verify if the action_id set to the button is "button-action" (if you don't have action_id in the block element, a randomly generated value should be set to the field)
Yes, i am using the same action id but it's not entering to the block action method

on button click, no request comes to the app

app.use method gets executed when I/m posting a message to slack

Does this mean you see the request payload log only when your app receives Events API requests? If so, I guess your app's Interactivity feature's configuration is still incorrect. Could you verify the configuration is surely correct again and/or check if shortcuts work (global/message shortcuts use the same Request URL)?
Otherwise, ... this seldomly happens but something wrong may be happening on the Slack's server-side. In this case, re-installing your app into the workspace may help.
Also, turning debug-level logs (by changing slf4j/logback settings) on may be helpful to know what is happening. You can easily check the detailed information in logs.

Slash command and shortcuts also not working, only event subscription works for me. I have reinstalled the app multiple times still the same issue

hmm, it sounds a bit similar to this issue: https://github.com/slackapi/java-slack-sdk/issues/582
Do you use Bolt in a Web framework? If you use Bolt as part of a Spring Boot 2.1 app, consider upgrading Spring Boot version to 2.2+.

yeah, I am using bolt with spring boot. Let me upgrade the version of spring boot. Will it you know if it works

Hi @Seartch,
Now my app is able to receive block action request payload but in the app block action message top it's showing "only visible to you" . Could you please help on this.
Thank you!

@BaradPuja It's an ephemeral message. You can use in_channel response type. https://api.slack.com/tutorials/slash-commands-style-guide#public_vs_ephemeral_responses
With Bolt for Java, the actual code would be as below:
app.command("/hi", (req, ctx) -> {
  ctx.ack(r -> r.responseType("in_channel").text("Hi"));
  ctx.respond(r -> r.responseType("in_channel").text("Hi"));

I'm glad to know you've managed to run your apps with Spring Boot! If I've answered all your questions, could you close this question issue?

Yeah Sure, Closing this. Thank you for you quick help and support


Fixed not printing some objects by telling JSON.stringify how to handle them

Im zec
From: imzacm<EMAIL_ADDRESS>Reply-To: achille1789/smart-console-nodejs<EMAIL_ADDRESS>Date: Monday, 22 May 2017 at 10:13
To: achille1789/smart-console-nodejs<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [achille1789/smart-console-nodejs] Fixed not printing some objects by telling JSON.stringify how to handle them (#8)

You can view, comment on, or merge this pull request online at:
https://github.com/achille1789/smart-console-nodejs/pull/8
Commit Summary

Merge pull request #1 from achille1789/dev
Fixed not printing some JSON objects such as c

File Changes

M smart-console.jshttps://github.com/achille1789/smart-console-nodejs/pull/8/files#diff-0 (123)

Patch Links:

https://github.com/achille1789/smart-console-nodejs/pull/8.patch
https://github.com/achille1789/smart-console-nodejs/pull/8.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/achille1789/smart-console-nodejs/pull/8, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AUXpyYbbCIM1b32Le6c3mDIhC7L5gx02ks5r8VHTgaJpZM4NiFU1.
Information in this email including any attachments may be privileged, confidential and is intended exclusively for the addressee. The views expressed may not be official policy, but the personal views of the originator. If you have received it in error, please notify the sender by return e-mail and delete it from your system. You should not reproduce, distribute, store, retransmit, use or disclose its contents to anyone. Please note we reserve the right to monitor all e-mail communication through our internal and external networks. SKY and the SKY marks are trademarks of Sky plc and Sky International AG and are used under licence.
Sky UK Limited (Registration No. 2906991), Sky-In-Home Service Limited (Registration No. 2067075) and Sky Subscribers Services Limited (Registration No. 2340150) are direct or indirect subsidiaries of Sky plc (Registration No. 2247735). All of the companies mentioned in this paragraph are incorporated in England and Wales and share the same registered office at Grant Way, Isleworth, Middlesex TW7 5QD.


[BEAM-5404] Use Java serialization for MutationGroup objects.

The Cloud Spanner connector uses a custom serialization system for MutationGroup objects
Java serialization is much more efficient than the custom serialization
system used by MutationGroupEncode -- in both speed, and space: the
encoded byte arrays are 1/10th of the size.
This PR replaces the custom serialization with a simple Java serialization using the Beam SerializableCoder class.
@chamikaramj
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---
---

Hi Neil,
I'd like someone from Spanner team who is more familiar with this code to sign off/review this PR. Can you please ask someone from that team to review this ?
Also, I suggest adding more specific large scale performance benchmarks related to this change to https://issues.apache.org/jira/browse/BEAM-5404 before changing the default method of serialization.

Hi Chamikaramj
From my tests on a 1TiB dataset, with GCP dataflow, this increases performance by about 10x, and reduces the amount of dataflow worker disk space required by about 10x (from 40TiB to 4TiB). Overall there is a 40x reduction in cost (dataflow worker and PD)

Got it. Thanks for checking Niel.


Support animating an overlay out after returning a result

Currently, if we want an exit animation for an overlay, we must wait for that animated to complete before returning the [Result]. This results in a lot of perceived lag if the [Result] should update the screen it was launched from. While this can be worked around with injecting callbacks or composition locals, those aren't ideal.
This updates ContentWithOverlays to animate an AnimatedOverlay in and out instead of just adding and removing it from composition. I'm open to ways to improve this.

Updated this to use androidx.compose.animation.AnimatedContent. The size transform bits were a little tricky and what initially tripped me up, but I think ultimately works out nicely. The transition calculation is much nicer now. Since this is no longer using experimental animation APIs, I don't see a good reason to branch between the two implementations. In my testing, this works seamlessly for both Overlay types.
One open question is whether AnimatedOverlay be able to specify a SizeTransform. I opted not to include it as is more of an implementation detail of ContentWithOverlays.
Screen_recording_20231222_220709.webm

LGTM! :shipit:

Thanks!


Docker image pull access denied

Hi, did you close the public docker image? So sad..

Unable to find image 'jutanke/mv3dpose:latest' locally
docker: Error response from daemon: pull access denied for jutanke/mv3dpose, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.

Shigeru

@sowd did you build the image? I think the documentation is a bit lacking in that regard.
cd docker && ./build.sh

Also, did you add your user to the docker group? (docker post-install)


[AIRFLOW-620] Add log refresh button to TI's log view page

Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:

https://issues.apache.org/jira/browse/AIRFLOW-620

Testing Done:

Manually tested on all major browsers.

This will add log refresh button to TI's log view page, thus eliminating the need of whole page reload to get the latest logs of that TI.

Current coverage is 66.26% (diff: 50.00%)

Merging #1875 into master will increase coverage by 0.07%

@@             master      #1875   diff @@
==========================================
  Files           128        128
  Lines          9840       9842     +2
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           6513       6522     +9
+ Misses         3327       3320     -7
  Partials          0          0

Powered by Codecov. Last update f192770...64aebd8

I like the idea but for long logs the user needs to scroll all the way up to refresh, and all the way down to see new data.  I would prefer to put the refresh button underneath the log data.

👍

+1

I  thought I commented on this, but looks like I didn't.
I'd really like a "tail N lines" feature in the log view -- essentially, automatically refreshing the log every S seconds and showing the last N lines (both configurable) to the view port.
I +1 @dgies comment about moving the refresh button to the bottom of the screen. Manually refreshing is okay, but automatically refreshing feels like the right solution.

@r39132 in that case we should do something like this:
If a TI is running, server will send the log text along with the pointer (no of bytes) upto which log has been read. In next call, UI will pass that pointer in ajax call and server will send only the new logs after that pointer along with the new pointer.
On UI rather than replacing the dom content, it'll just append to it. This process will continue until the TI finishes. On full page refresh UI will send no pointer and server will respond to full logs.

I propose we do not let the perfect become the enemy of the good and merge this as-is (after squashing).  Automatic refreshes are trickier to get right and can be added in a new PR without invalidating what's been done already.

Yeah, that was my idea as well.. instead of doing all magic in once, do it incrementally..

@msumit shall we rebase, squash and merge this?

@zodiac sure, will rebase it this weekend..

@zodiac can u do a final review and merge it?

@msumit What do you want to do with this PR? Close and re-open a fresh one or rebase and ask for a review. If I don't hear back in a few days, I'll close this.

closing for now..  reopen to update and rebase.


Exclamation mark in use_backend clause causes error

If you have the following in the cfg:
	acl url_api-gateway_dark url_sub api-gateway_cluster=dark
	use_backend api-gateway-dark-http if url_api-gateway url_api-gateway_dark
	use_backend api-gateway-live-http if url_api-gateway !url_api-gateway_dark

it will cause a parse error even though it is correct. Error is as follows:
ACL '!url_api-gateway_dark' not found

@flyhard Really thanks for your report and P-R #3 !
I'll check it later.


Add support for block form of ActiveSupport::Notifications.subscribe

Cf https://github.com/rails/rails/blob/main/activesupport/lib/active_support/notifications.rb#L212-L245 for the documentation about this

Does this method for Rails 6 accept the same block? If so, you should edit the RBS file for Rails 6 instead. https://github.com/ruby/gem_rbs_collection/blob/a4c633634493ab7ae73219022f56acff56ab69af/gems/activesupport/6.0/activesupport-generated.rbs#L9931

I'll close this PR because of a lack of activity.


Handling Exceptions with Promises/A+

I've been running into some problems with uncaught exceptions not being reported in nested promises. I know that Promises/A bubbles up exceptions and Promises/A+ catches them, but I can't find a way to handle the caught exception.
To demonstrate, I've removed all Parse queries/saves and broken it down into a purely promise based example:
var promise1 = new Parse.Promise();

console.log(1);
promise1.then(function(r) {
  console.log(2);
  var promise2 = new Parse.Promise();
  promise2.then(function() {
    console.log(3);
    doesNotExist.go(); // this should cause an exception
  });
  promise2.resolve();
  return promise2;
}).then(function(r) {
  console.log(4);
}, function(e) {
  console.log('error handler');
  console.log('error', e);
});

promise1.resolve()

I would expect the output to be 1,2,3,error handler, but instead it is 1,2,3,4 with no errors reported anywhere.

So, my question is: how can I handle uncaught exceptions with nested A+ promises?
Thanks!

When errors occur, it's like returning a rejected Promise from the function they occur in. In your example, promise2 is one Promise, and promise2.then(...) returns a different Promise. That is the promise that gets rejected with your error.
In your case, promise2 has two separate callbacks: the one that logs 3, and the one that logs 4. You can consider them running in "parallel," printing 4 does not wait for printing 3 to be resolved. What you really want to be doing is returning the Promise returned by promise2.then(), eg:
console.log(1);
promise1.then(function(r) {
  console.log(2);
  var promise2 = new Parse.Promise();
  var promise3 = promise2.then(function() {
    console.log(3);
    doesNotExist.go(); // this should cause an exception
  });
  promise2.resolve();
  return promise3;
}).then(function(r) {
  console.log(4);
}, function(e) {
  console.log('error handler');
  console.log('error', e);
});

Sorry if that's a bit confusing, you can only read the word "promise" so many times before going a bit cross-eyed 😉

Thanks for the reply, @andrewimm.
I think the key concept for me to remember here is that .then(...) returns a different promise and thus errors need to be handled on that promise.
So many "promises"... if you stare hard enough it doesn't even look like it's spelled correctly anymore 😝


x/tools/cmd/godoc: should not display vendor packages

Currently, if someone goes to https://tip.golang.org/pkg/ and scroll to the bottom, they see:

Instead, godoc should hide this information.
Close this if people believe vendor folders should actually be displayed on the package documentation page.

CC @adg


Updates needed in graphics documenting

[ ] sediment flux plots (https://github.com/RachaelDMueller/SalishSeaModel-analysis/blob/main/notebooks/workshops/plot_RigbyStation_monthlySedimentFluxes.ipynb)
[ ] Hourly_NO3_DOXG_salinity.png (https://github.com/RachaelDMueller/SalishSeaModel-analysis/blob/main/notebooks/WaterQualityWorkshop_Sept29_2022.ipynb)
[ ] Add "purple" plots from: https://github.com/RachaelDMueller/SalishSeaModel-analysis/blob/main/NPP_workshop_120622/plot_2D_DepthTime_inlets_NPP_workshop_12062022.ipynb
[x] Main region reference case noncompliance, percent hypoxic, and concentration movies

non-compliance graphics for movie are located in: /mmfs1/gscratch/ssmc/USRS/PSI/Rachael/projects/KingCounty/graphics/main/noncompliance/m0p25/movies/Region/wqm_baseline/
/mmfs1/gscratch/ssmc/USRS/PSI/Rachael/projects/KingCounty/graphics/main/noncompliance/m0p25/movies/Region/wqm_reference/

Similar with DO concentration:

/mmfs1/gscratch/ssmc/USRS/PSI/Rachael/projects/KingCounty/graphics/main/DOXG/concentration/movies/Region/wc/wqm_baseline
/mmfs1/gscratch/ssmc/USRS/PSI/Rachael/projects/KingCounty/graphics/main/DOXG/concentration/movies/Region/wc/wqm_reference

re:sediment flux plots
The time of the FVCOM array has apparently changed for reasons that are unclear to me and this code needs to be modified so that the array lengths are referenced correctly.  There is one extra day in the new result than I account for in my post-processing scripts (which were intentionally developed to not be flexible on this dimension)


Download location of the VM

So far the VM download (11 GB) is hosted on Random-Orcales.org.
This might be a bottleneck in near (and far) future.
We've talked about moving the Download-File to somewhere else.
Hosting at HSRM or decentralized hosting (IPFS, Torrent) are current options.
Some events in the near future (SpinlHDL Workshops, Journal-articles, Research Collabs, Twitter influencers) could drive the download counts up. We should discuss and set the download location soon!
Needed:
Discussion between Harald, Steffen and Thorsten

VMs are also hosted on HSRM servers now.

VMs are also hosted on HSRM servers now.


add the goBack() method to the page object

Proposed changes in this pull request
add the goBack() method to the page object
Checklist

[x] New tests have been added
[x] npm test passes successfully
[ ] Documentation has been updated

@amir20 to review

Needs tests. @luismesas besides that looks good.

test added

You are awesome. Merging.

Apparently I forgot to merge.

2.1.17 released.


Cannot find module '@angular-devkit/schematics/tools' on a fresh install

I'm using Nx to manage node packages (no dependency to angular), but I can't setup this plugin on a fresh install, see error below:
✔ Lock/sync versions between packages? (y/N) · true
✔ Enforce conventional commits? (Y/n) · false
Cannot find module '@angular-devkit/schematics/tools'
Require stack:
-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>
My dev-dependencies:
"devDependencies": {
    "@jscutlery/semver": "^2.4.0",
    "@nrwl/cli": "12.5.7",
    "@nrwl/eslint-plugin-nx": "12.5.7",
    "@nrwl/jest": "12.5.7",
    "@nrwl/linter": "12.5.7",
    "@nrwl/node": "^12.5.7",
    "@nrwl/tao": "12.5.7",
    "@nrwl/workspace": "12.5.7",
    "@types/jest": "^26.0.24",
    "@types/node": "14.14.33",
    "@typescript-eslint/eslint-plugin": "4.19.0",
    "@typescript-eslint/parser": "4.19.0",
    "dotenv": "8.2.0",
    "dotenv-cli": "^4.0.0",
    "eslint": "7.22.0",
    "eslint-config-airbnb-typescript": "^12.3.1",
    "eslint-plugin-import": "^2.22.0",
    "jest": "27.0.3",
    "ts-jest": "27.0.3",
    "ts-node": "~9.1.1",
    "typescript": "~4.2.4"
  }

I also have this error, I'm using react

This will be fixed soon, a PR is open #238, we are just waiting for the next Nx version which comes with a fix that we need. Meanwhile, a quick fix would be to install the dep @angular-devkit/schematics before the install, then you can remove it.

cool! thank for the quick support!


printf format string fix for long long time_t

If time_t is defined as long long it should not be printed with %lu format string.

What are you going for here? The PR title says it's about time_t, but the commits add some fix, add a bunch of OpenBSD pledge code, then reverts the time_t change.

On Fri, Sep 02, 2016 at 12:23:15PM -0700, dormando wrote:

What are you going for here? The PR title says it's about time_t, but the commits add some fix, add a bunch of OpenBSD pledge code, then reverts the time_t change.

some problems with github web gui.
My intention was to provide 2 different patches.
The first is to fix time_t printf, the second one to add support to pledge(2) in
drop_privileges function.
Giovanni
diff --git a/items.c b/items.c
index 4399f24..b1ae631 100644
--- a/items.c
+++ b/items.c
@@ -484,10 +484,10 @@ char item_cachedump(const unsigned int slabs_clsid, const unsigned int limit, u
/ Copy the key since it may not be null-terminated in the struct /
strncpy(key_temp, ITEM_key(it), it->nkey);
key_temp[it->nkey] = 0x00; / terminate */

   len = snprintf(temp, sizeof(temp), "ITEM %s [%d b; %lu s]\r\n",

   len = snprintf(temp, sizeof(temp), "ITEM %s [%d b; %llu s]\r\n",
                  key_temp, it->nbytes - 2,
                  it->exptime == 0 ? 0 :

                  (unsigned long)it->exptime + process_started);

                  (unsigned long long)it->exptime + process_started);
   if (bufcurr + len + 6 > memlimit)  /* 6 is END\r\n\0 */
       break;
   memcpy(buffer + bufcurr, temp, len);

diff --git a/Makefile.am b/Makefile.am
index 2352301..073f49f 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -32,6 +32,10 @@ if BUILD_SOLARIS_PRIVS
memcached_SOURCES += solaris_priv.c
endif
+if BUILD_OPENBSD_PRIVS
+memcached_SOURCES += openbsd_priv.c
+endif
+
if ENABLE_SASL
memcached_SOURCES += sasl_defs.c
endif
diff --git a/configure.ac b/configure.ac
index 9311332..cc937a0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -564,6 +564,16 @@ AC_CHECK_FUNCS(setppriv, [
AM_CONDITIONAL([BUILD_SOLARIS_PRIVS],[test "$build_solaris_privs" = "yes"])
+AC_CHECK_FUNCS(pledge, [

AC_CHECK_HEADER(unistd.h, [

 AC_DEFINE([HAVE_DROP_PRIVILEGES], 1,

    [Define this if you have an implementation of drop_privileges()])

 build_openbsd_privs=yes

], [])
+],[])

+AM_CONDITIONAL([BUILD_OPENBSD_PRIVS],[test "$build_openbsd_privs" = "yes"])
+
AC_CHECK_HEADER(umem.h, [
AC_DEFINE([HAVE_UMEM_H], 1,
[Define this if you have umem.h])
diff --git a/memcached.c b/memcached.c
index 8412d47..4110c0c 100644
--- a/memcached.c
+++ b/memcached.c
@@ -6414,7 +6414,7 @@ int main (int argc, char **argv) {
}
 /* Drop privileges no longer needed */

drop_privileges();

drop_privileges(pid_file);
/* Initialize the uriencode lookup table. */
uriencode_init();
diff --git a/openbsd_priv.c b/openbsd_priv.c
new file mode 100644
index 0000000..62946b8
--- /dev/null
+++ b/openbsd_priv.c
@@ -0,0 +1,42 @@
+#include <errno.h>
+#include <stdlib.h>
+#include <stdio.h>
+#include <string.h>
+#include <unistd.h>
+#include "memcached.h"

+/*

this section of code will drop all (OpenBSD) privileges including

those normally granted to all userland process (basic privileges). The

effect of this is that after running this code, the process will not able

to fork(), exec(), etc.  See pledge(2) for more information.

*/
+void drop_privileges(const char *pid_file) {
extern char *__progname;

if (settings.socketpath != NULL) {

   if (pid_file != NULL) {

      if (pledge("stdio cpath unix", NULL) == -1) {

         fprintf(stderr, "%s: pledge: %s\n", __progname, strerror(errno));

         exit(EXIT_FAILURE);

      }

   } else {

      if (pledge("stdio unix", NULL) == -1) {

         fprintf(stderr, "%s: pledge: %s\n", __progname, strerror(errno));

         exit(EXIT_FAILURE);

      }

   }

} else {

   if (pid_file != NULL) {

      if (pledge("stdio cpath inet", NULL) == -1) {

         fprintf(stderr, "%s: pledge: %s\n", __progname, strerror(errno));

         exit(EXIT_FAILURE);

      }

   } else {

      if (pledge("stdio inet", NULL) == -1) {

         fprintf(stderr, "%s: pledge: %s\n", __progname, strerror(errno));

         exit(EXIT_FAILURE);

      }

   }

}

+}
diff --git a/solaris_priv.c b/solaris_priv.c
index 349334e..ffcd7de 100644
--- a/solaris_priv.c
+++ b/solaris_priv.c
@@ -9,7 +9,7 @@

effect of this is that after running this code, the process will not able

to fork(), exec(), etc.  See privileges(5) for more information.
*/
-void drop_privileges(void) {
+void drop_privileges(const char *pid_file) {
priv_set_t *privs = priv_str_to_set("basic", ",", NULL);
if (privs == NULL) {

can you please open two pull requests, one for each change? since they're unrelated.
thanks

closing this, the other two PR's replace it.


[improve] [client]Add new ServiceUrlProvider implementation: SameAuthParamsAutoClusterFailover

Motivation
Background
So far, there are two implementations of ServiceUrlProvider

ControlledClusterFailover: call an HTTP API to change the pulsar service URL.
AutoClusterFailover: check the pulsar service URL by creating a socket, and automatically switch to the high-priority pulsar service URL.

Issue

We build two clusters c1 and c2, and start a binary-way replication between them.
Enabled AutoClusterFailover for our client to switch connections to the healthy cluster when the primary one can not work.
The network traffic is:client -> proxy -> brokers

If all the brokers crash, the proxies are still healthy, AutoClusterFailover can not determine that the primary cluster can not provide service anymore.
Modifications
Add a new ServiceUrlProvider implementation: SameAuthParamsAutoClusterFailover, which uses lookup topic to check whether the target cluster is healthy or not. Since the clusters that enabled Geo-Replication always have the same auth settings, it can be easy to implement(skipping the different auth settings ).
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: x

/pulsarbot rerun-failure-checks

Codecov Report
Attention: Patch coverage is 71.69811% with 45 lines in your changes missing coverage. Please review.

Project coverage is 74.50%. Comparing base (bbc6224) to head (47ccb1e).
Report is 501 commits behind head on master.

Files
Patch %
Lines

.../impl/SameAuthParamsLookupAutoClusterFailover.java
71.69%
30 Missing and 15 partials :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23129      +/-   ##
============================================
+ Coverage     73.57%   74.50%   +0.93%
- Complexity    32624    33589     +965
============================================
  Files          1877     1920      +43
  Lines        139502   144325    +4823
  Branches      15299    15783     +484
============================================
+ Hits         102638   107534    +4896
+ Misses        28908    28552     -356
- Partials       7956     8239     +283

Flag
Coverage Δ

inttests
27.78% <0.00%> (+3.19%)
:arrow_up:

systests
24.68% <0.00%> (+0.36%)
:arrow_up:

unittests
73.85% <71.69%> (+1.00%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...g/apache/pulsar/client/api/ServiceUrlProvider.java
100.00% <ø> (ø)

.../impl/SameAuthParamsLookupAutoClusterFailover.java
71.69% <71.69%> (ø)

... and 489 files with indirect coverage changes


Removed clear results in set input and keep results visible.

This PR removes the clearing of the results tab and messages tab when the editor is replaced (when pressing "save" on a file, this issue does not occur, but renaming the file or saving it for the first time does)  following a "save as". However, as a result, this preserves the results and editor when a new query tab is added, but it will be refreshed with the right results when run is pressed again.
This PR fixes #1876

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 2 (0.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 42.562%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/contrib/query/browser/queryEditor.ts
0
1
0.0%

src/sql/workbench/contrib/query/browser/queryResultsView.ts
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.001%

Covered Lines:
26721

Relevant Lines:
56899

💛  - Coveralls

@Charles-Gagnon Yes that was exactly the issue I mentioned in my report, however clicking "save as" technically creates a new editor entirely, should there be a flag to indicate if this is a "save as" and to disable the clear results and keep results visible when it happens? This is going to require a lot of passed booleans. The results will be cleared if we remove the "clear results tab and messages tab" from queryResultsView, while still keeping the results and messages tab open but empty.

That's definitely not something we should allow to happen since that could easily result in the user thinking the results are wrong.
You should look into when we set the state ensuring that we update the display properly - if there isn't a state (or it's empty) then we should clear the grid/hide the tab.

Added a flag for textResourceEditorInput to indicate if the view state is needed to be preserved since that is what passed in to the queryEditor when a saveAs happens (don't want to break anything at the moment).

Edit, needs to work for save button

There is an issue where if you open one new query and run the results on it, saving it to a file, then run another new query and saving onto the first one, it replaces the contents of the query, but not the results, since there is currently no way to pass in the query input of the untitled editor into the new one.

@Charles-Gagnon The main issue so far is that when saving, the file is turned into a TextResourceEditorInput by vscode and this means that the status for the query window is lost as a result. this is on top of numerous import violations and creating subclasses of the querytexteditorinput based on the other versions of other abstractTextClasses.
I'm starting to think that by design, vscode doesn't allow this to be done at all without the vscode edit that I proposed.

What I think you should be looking at here is looking at overriding the save for the UntitledQueryEditorInput such that it calls save on the text input like it does currently but then instead of returning that new file input directly create a new FileQueryEditorInput using the returned text input and setting the properties such as results state on that new input.
(note that the save is done in the abstract class, so you'd just be overriding that behavior in the Untitled version of the input since saving the File input shouldn't change at all)

@Charles-Gagnon That doesn't seem to work as attempting to change the state of resultsVisible on the text input casted as FileQueryEditorInput results in an "undefined" error, also the import of the FileQueryEditorInput violates vs-nls imports as well. Also even if this was able to be done, vscode calls a registerEditorOverride function that creates a new FileEditorInput given a resource file, and this does not preserve the state of the editor.

@Charles-Gagnon That doesn't seem to work as attempting to change the state of resultsVisible on the text input casted as FileQueryEditorInput results in an "undefined" error, also the import of the FileQueryEditorInput violates vs-nls imports as well. Also even if this was able to be done, vscode calls a registerEditorOverride function that creates a new FileEditorInput given a file resource, and this does not preserve the state of the editor.

I'm not saying just cast it - because yeah that won't work since the object isn't an actual FileQueryEditorInput. You need to create a NEW FileQueryEditorInput and give it the FileEditorInput that was created by the call to save, and then update the state of that new FileQueryEditorInput.
The editor override stuff is going to be a problem as it is though - that's correct. Currently they call the override before the input is actually created and so we only have the resource URI. The good news here though is that in the next VS Code merge we should be getting the newer version of that API that was updated to pass in the input instead : https://github.com/microsoft/vscode/blob/main/src/vs/workbench/services/editor/common/editorResolverService.ts#L105 which means we should be able to handle your case as well (since we can just ignore inputs that are already query inputs and not create a new one).
So my suggestion here is to put this off until the next VS Code merge comes in and then look at fixing it then since that should be more possible with my suggestion at that point.

@Charles-Gagnon Yeah, I'm going to need to put in an initialization service for UntitledQueryEditorInput to create a new FileQueryEditorInput

@Charles-Gagnon As an update: the FileQueryEditorInput doesn't seem to play nice with the sqltoolsservice when it tries to run getQueryRows, it gets an error saying "The Requested Query does not exist." Changing the sqltoolsservice to accommodate this may break SSMS if this happens.
I found that adding the resultsVisible Property in the saveAs for untitledQueryEditorInput works without modifying the vs files themselves, however as you mentioned this is risky to do this. But now its isolated only to the Query related only SQL code this time.

It turns out my approach to the fix is wrong so far, the results clearing is needed to prevent bleeding from one window to another, but the input passed in stores a gridPanelState that contains the results, this is not passed in when a saveAs happens due to the editor being replaced. This means I need to find a way to pass in the gridPanelState as well as the boolean flag to show the results.


fixed mod_tile rendering and more

fixed cached tiles re-rendering
minor Dockerfile optimization
moved rendering state (lastRedered) to a seperate file (renderedState.txt)

rendered is writing it's logs to stderr so it's spamming the error log

Related to #22

Please remove the TODOs
I do not think using an action_id is a good idea, for a couple of reasons:
what if we exceed the int limit?
Assuming we re-deployed the service we would start back from 1, so action_id is not unique.

A counter alternative I would suggest that we should rely on the timestamp in the log. @CptSchnitz wdyt?

Please merge main to your branch. This branch is behind main.

I agree that action_id doesn't give a lot, but we can replace it with the sequence number as it is unique, and gives you info about the state of the expiry in relation with other services.

1. Please remove the TODOs

2. I do not think using an `action_id` is a good idea, for a couple of reasons:

3. what if we exceed the int limit?

4. Assuming we re-deployed the service we would start back from 1, so action_id is not unique.

A counter alternative I would suggest that we should rely on the timestamp in the log. @CptSchnitz wdyt?
1. Please merge main to your branch. This branch is behind main.

done

probably won't happen because action_id is raised by 1 each minute so 6024365*100(years)=52,560,000

it's more likely to happen, or for pod scaling reasons. plus, the code inside the infinite loop is sync so action_id isn't helping too much to extract the logs of a process within the loop

merged

The docs changes also related to #37


chore(website): fix typo in word 'exact'

Thanks a lot for catching this @alexvilchis 🎉

My pleasure!


php8.2-zts 8.2.7 build failed, php8.2 arm missing

At https://github.com/Endava/docker-php/actions/runs/5222322393/jobs/9429661810 the build failed here
I reported the problem upstream at https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/47884#note_317591

Arm build missing, because alpine arm packages cannot be build atm on alpine side.
the zts build was blocked because aports was pulled from master and not from 3.18-stable branch. Fixed with 0a74aa4f025cae107bd255cccfae9f8eaacf5039

arm builders are working again at https://build.alpinelinux.org/


fix(ingest): bound types-requests

We should be able to loosen this once https://github.com/python/typeshed/issues/10764 is fixed. I have a PR up for it: https://github.com/python/typeshed/pull/10776.
Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Merged to unblock CI


Create dashboard exactly like Disk View in perf archives

Dear support,
is possible to have a dashboard like the one attached:
read/write latency,total transfers, disk busy grouped per raid group inside every aggregate?

Thanks Luca on Discord for raising.


XS Left-hand nav does not include any keyboard navigation

Summary of the bug
When the left-hand nav component is open on small width devices, keyboard navigation is not set, so users are not able to navigate to any page
🪜 How to reproduce
Reduce screen size so left-hand nav appears as XS variant. Tab to component. Press 'space' to open. Notice how arrows or tabs do not move focus between pages.
🧐 Expected behaviour
Up/Down keys should move focus between pages, like select.

Closing as duplicate ticket.

duplicate of: https://github.com/mi6/ic-design-system/issues/421
fixed by https://github.com/mi6/ic-design-system/pull/435


[PINOT-4425] Controller should not assign segments to disabled server instances

Updated all segment assignment strategies to skip disabled server instances.
Also updated rebalancer and move replica group commands to skip disabled instances
in the destination list.
Testing: Integration test

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9260696). Click here to learn what that means.
The diff coverage is 30.3%.

@@            Coverage Diff            @@
##             master    #1047   +/-   ##
=========================================
  Coverage          ?   56.74%
=========================================
  Files             ?      860
  Lines             ?    42140
  Branches          ?     5382
=========================================
  Hits              ?    23914
  Misses            ?    16630
  Partials          ?     1596

Impacted Files
Coverage Δ

...in/pinot/tools/admin/command/MoveReplicaGroup.java
0% <ø> (ø)

...m/linkedin/pinot/tools/PinotSegmentRebalancer.java
0% <ø> (ø)

...helix/core/sharding/BucketizedSegmentStrategy.java
0% <ø> (ø)

.../helix/core/sharding/RandomAssignmentStrategy.java
86.66% <100%> (ø)

.../sharding/BalanceNumSegmentAssignmentStrategy.java
81.81% <100%> (ø)

...linkedin/pinot/common/utils/helix/HelixHelper.java
52.66% <72.72%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9260696...ed4e3c2. Read the comment docs.


CLI Commands: support loading startup from a separate project

Add support for supplying a project as a parameter in --startup-project that is different than the current project.
This is explicitly disabled in code. See https://github.com/aspnet/EntityFramework/issues/4577#issuecomment-217496222 for background and https://github.com/aspnet/EntityFramework/pull/5312.
Blocking issues:
https://github.com/dotnet/cli/issues/1540
https://github.com/dotnet/cli/issues/2289

Remarking for triage. Brice and I came up with a way to re-factor EF tools that will help solve this, but this will require a refactoring too big to get in for the RTM timeline.


feat: godot 4_3 platform drop through submiission for FortunesFavorite

My awesome pull request for the godot platform drop through solution. More details in the README.

Great submission!


[Feature] No resources available for some mentioned languages

Problem
There are no resources available for some mentioned languages on the home page
Description
Based on my understanding of the problem and the user's perspective, I suggest of removal of those languages from the home page which doesn't have any resource mapped to it.  By this feature, we eliminate unnecessary redirection.
You can see there are no resources available for languages like Hindi(hi), Urdu(Ur), Spanish(es) and Mandarin(cmn). So I suggest to remove those tags for increased clarity It can improve usability, and a better overall user experience.

Alternatives
We can add new resources of the above mentioned languages.
Implementation

[x] I would be interested in implementing this feature.

@nishchay-veer might be good to double check that there is indeed not a bug occurring here, and that there are resources they just aren't displaying.

I am willing to work on this issue can you please assign it to me

@BalrajDhakad feel free to look into this!

okay thanks for your reply it matters alot @possumbilities

Hey @possumbilities ,
I think we should add at least one resource for each language as I have checked and @nishchay-veer mentioned above that there are only four languages which don't have any resource. (Hindi, Urdu, Spanish and Mandarin).
What do you say

Hey @possumbilities ,
I have solved this issue but I am not able to make a PR because of an existing PR for issue #15 and the PR is #191 can you please review it so that I can have another PR for this issue.


rqt_image_overlay: 0.1.2-1 in 'humble/distribution.yaml' [bloom]

Increasing version of package(s) in repository rqt_image_overlay to 0.1.2-1:

upstream repository: https://github.com/ros-sports/rqt_image_overlay.git
release repository: https://github.com/ros2-gbp/rqt_image_overlay-release.git
distro file: humble/distribution.yaml
bloom version: 0.11.2
previous version for package: 0.1.1-1

rqt_image_overlay
* Correctly map ImageManager list model index to topic vector (#48 <https://github.com/ros-sports/rqt_image_overlay/issues/48>)
* Contributors: Kenji Brameld, Marcel Zeilinger

rqt_image_overlay_layer

No changes

Holding for Humble sync


Pre-trained network with BN => InplaceABN

What is the process to replace BN layers with InplaceABN in a pre-trained network, say
resnet34 from torchvision
?

Note that the Readme states that in this case you must expect a severe drop in performance,
because the scaling parameter is handled differently. In some sense I think the process you are searching for is: Adapt this code to use the scaling factor exactly as the regular BN and then replace your layers with inplace layers and copy the weights. Thats a lot of work though.

As @somedadaism said, porting weights from standard BN to InPlaceABN is a somehow cumbersome process, due to the different way the scaling parameters are handled. In general we recommend to use one of our pre-trained models, or if possible redo ImageNet training with the desired model and InPlaceABN.


Static Web App ------ Deployment Failure Reason: Failed to deploy the Azure Functions.

Static Web app was running fine. Did a code push and now the stack is down and I cannot figure out why. I tried re-running the build but it always fails the same.
build below
---End of Oryx build logs---
Function Runtime Information. OS: Linux, Functions Runtime: v3, Node version: 12.X
Finished building function app with Oryx
Zipping Api Artifacts
Done Zipping Api Artifacts
Zipping App Artifacts
Done Zipping App Artifacts
Uploading build artifacts.
Finished Upload. Polling on deployment.
Status: InProgress. Time: 0.3657797(s)
Status: InProgress. Time: 15.5921772(s)
Status: InProgress. Time: 31.5297017(s)
Status: Failed. Time: 46.7196347(s)
Deployment Failed :(
Deployment Failure Reason: Failed to deploy the Azure Functions.

logs_356.zip
Here are my logs.
This has been working for several months. Then out of nowhere lastnight it just wouldn't build anymore.

Hi @adam-javelin, sorry for the inconvenience! If you retry the deployment now do you still see errors? It seems like last night we had some issues deploying to Azure Functions, but they seem to have been resolved.

Thanks @joslinmicrosoft I did try a pull request to test a branch. I will update when I can get dev to build successfully. ATM dev is somehow working even the Azure Portal says its not. I'm hesitant to re-build right now because we have some users testing right now. I will build it again later today and post back. Thanks for your prompt reply.

Good to hear the PR works! When you say that Portal says it's not working, do you mean within the Environments section it says "Failed" under the status? Just to clarify there, that status is about the latest deployment attempt, not the status of the live app. Failed builds/deployments do not update the app, so your currently live app should reflect the changes from your last successful deployment.

Ok its all good now just built to main and 👍 .

I don't know if it's possible to re-open this, or look at it, but I'm experiencing the same error. Almost exactly.
The deployment worked before I added the function, but not after. No real reason or explanation, just fails.

we are having the same issue starting yesterday

Yeah it would be nice to understand what is causing this.

We are investigating, does look like an issue with Azure Function deployment.

As an update we've found a potential root cause for the issues we are seeing and working to address it. Will continue to update here as we know more.
One thing to note is this only affects new SWA deployments with Functions, all existing SWA's with Azure Functions should be unaffected.

A fix has been found and applied, all new Function deployments should begin to work again. Sorry for the inconvenience!


Add MetadataEncoder and MetadataDecoder

Description:
This change is the first step to enable METADATA in Envoy. METADATA is used to communicate extra information related to a session or a stream which is not carried in the standard HTTP(s) and HTTP/2 headers and payloads. METADATA in Envoy is handled as nghttp2 extension frames, where the payload is a block of key-value pairs, encoded using the HPACK Literal Header Field Never Indexed representation.
MetadataEncoder and MetadataDecoder are used to encode and decode METADATA payload. For more detailed background and motivation, please refer to https://docs.google.com/document/d/1oKWxAyqVqA1ZToxSM5F63mJyLr70wHS7RbEGBfXl1qE/edit#bookmark=id.ehs4e62zi5s8 and #2394
Risk Level: Low. Not used in production.
Testing: unit tests in metadata_encoder_test.cc
Docs Changes:
Release Notes:
#2394

I added MetadataDecoder to this PR. It makes the test cleaner since decoder and encoder can test against each other. Please let me know if a separate PR is preferred. Then I can revert the change, and get the encoder in first. Thanks!

Yes, assigning myself.

@soya3129 @alyssawilk before I review, just for my high level understanding, the end goal here is to proxy METADATA from upstream to downstream and vice versa? Or do we also plan on allowing filters to add/modify/remove metadata? Just trying to get the full picture before I review.

Thanks for the review!

@soya3129 @alyssawilk before I review, just for my high level understanding, the end goal here is to proxy METADATA from upstream to downstream and vice versa? Or do we also plan on allowing filters to add/modify/remove metadata? Just trying to get the full picture before I review.

Thanks for taking the PR!! METADATA will be used to communicate extra information related to a session or a stream which is not carried in the standard HTTP(s) and HTTP/2 headers and payloads, like billing or logging information. That may require Envoy to be able to add/modify/remove METADATA at different hops. With my very limited understanding of Envoy, I think that means we would allow filters to add/modify/remove METADATA.
This change is the first step towards that goal. It allows codec to encode and decode METADATA using nghttp2.  Next step would be designing APIs for a filter to add/modify/remove METADATA to a stream (or to a session in the far future, :))

Oops! Sorry! Reopened.

Thanks for the review!

Thanks for the review!

When you get a chance, please pull and merge master, to pick up the fix to the coverage build.

Thanks for the review! Opened https://github.com/nghttp2/nghttp2/issues/1246 to track the option in nghttp2.

Cc Biren the metadata change.
@birenroy


Angular 5

Hi!
Can I count on this plugin to be updated for Angular 5?
I use it in an internal corporate project alongside Angular 5.2.6 and it works as expected, though Angular dependency version number is set for 4.x.
Probably it's just a quick dependency version bump for you :)

Also would like!
I use it in projects already in production.

Hello guys, I will try to fix it in some days

Hi guys. Can we have it updated to angular 6 also? 😊

Fixed.

For Angular 2/4 please use old version. angular-autofocus-fix package.
For Angular 5/6/7/8+ please use ngx-autofocux-fix package


Lint -> Atom IDE Diagnostics

Replace old Linter to default Diagnostics tool.

👍 makes this plugin compatible with atom-ide-ui diagnostics part (that only supports linter v2 messages).


Constants.DataFolder returns the correct value after calling Config.Set("data-folder", ...)

@naicigam - I'm curious what the use case is here? My concern is that this is a very frequently hit property, so ideally we wouldn't need to peruse a JObject each time we need it.

@mchandschuh I am trying to test the import of data by running a local backtests and making sure the algorithms can access the imported data.
Since I have multiple test cases that import data for the same instruments (same file names), I am switching the data folder between tests. and this was the less intrusive way I found to do this.
The Config and the Constant classes are tightly coupled inside Lean. Do you have any plans or intentions to reduce this coupling? I would be happy to start working on this if you can point me out in the right direction, since you know Lean much better than I do.

Maybe the easiest implementation here would be to implement get/set -- it seems that the Constants class is no longer really Constants -- any ideas on a better name?

We could also implement a Reset method, like the one in the Composer class.
On Thu, Feb 25, 2016 at 8:06 PM, Michael<EMAIL_ADDRESS>wrote:

Maybe the easiest implementation here would be to implement get/set -- it
seems that the Constants class is no longer really Constants -- any ideas
on a better name?
—
Reply to this email directly or view it on GitHub
https://github.com/QuantConnect/Lean/pull/306#issuecomment-189024867.

I'll close this PR. Please submit another with the get/set change, and another if you'd like a Reset method. Thanks. Was thinking another good change may be to renames Constants to something else, maybe Globals


GL Container Images: Push container artifacts to public registries

Push container artifacts to public registries
The newly created container image must be pushed to one or more public registries where users may consume the image. However, we still need to evaluate which registers to use, which version to use and how frequently to push. Maybe it could be done during the nightly jobs to push the container image.

Unfortunately, I do not have enough permissions to create, adjust and add the GitHub secrets to solve this issue. This can only be proceeded by placing the needed secret to push artifacts to the Google Artifact Repository.

Publishing of Container Images is implemented.
PR https://github.com/gardenlinux/gardenlinux/pull/1712 closes this issue


Subaction addFolder

According to schema the subaction addFolder is added. But it doesn't work as expected. Is there any possible update on this issue.
Category

[x] Question
[ ] Bug
[ ] Enhancement

Expected or Desired Behavior
Add specified Folder(s) under document library.
Thanks for your contribution! Sharing is caring.

The subAction "addFolder" is still not working but it's included in the schema: https://developer.microsoft.com/json-schemas/sp/site-design-script-actions.schema.json.
Any news about the issue?

Agreed.  This does not work

I've used this many times and it has worked for me. What issues have you been having? (The initial issue is 2y old, so likely no longer the actual issue.)

{
"$schema": "https://developer.microsoft.com/json-schemas/sp/site-design-script-actions.schema.json",
"actions": [
{
"verb": "createSPList",
"listName": "Test List",
"templateType": 101,
"subactions": [
{
"verb": "setDescription",
"description": "This is the description"
},
{
"verb": "addFolder",
"path": "TestFolder",
}
],
"version": 1
}
the above schema adds a list called "Test List" with no description or subfolders.
oddly enough the following will set the description:
{
"$schema": "https://developer.microsoft.com/json-schemas/sp/site-design-script-actions.schema.json",
"actions": [
{
"verb": "createSPList",
"listName": "Test List",
"templateType": 101,
"description": "this is the description",
"subactions": [
{
"verb": "addFolder",
"path": "TestFolder",
}
],
"version": 1
}
there is no way I can a site script to actually make sub folders.


favicon href is undefined after build

Do NOT ignore this template or your issue will have a very high chance to be closed without comment.

Describe the bug
favicon href is undefined after build

Reproduction
https://repl.it/join/vxnznbnu-07akioni
A reproduction is required unless you are absolutely sure that the the problem is obvious and the information you provided is enough for us to understand what the problem is. If a report has only vague description (e.g. just a generic error message) and has no reproduction, it will be closed immediately.
System Info

required vite version: 1.0.0-rc.13
required Operating System: Mac OS
required Node version: 12
Optional:

npm/yarn version
Installed vue version (from yarn.lock or package-lock.json)
Installed @vue/compiler-sfc version

Logs (Optional if provided reproduction)

Run vite or vite build with the --debug flag.
Provide the error log here.

Create a folder name public and move the icon to this folder

Create a folder name public and move the icon to this folder

You can create a folder name public and move the icon to this folder

Your reproduction is unrelated link. Need valid reproduction to track issue.

@underfin
https://github.com/07akioni/ConsiderateSlategreyLicensing

Your reproduction is unrelated link. Need valid reproduction to track issue.

It seems repl.it's content can be modified...

It seems repl.it's content can be modified by other people.

Sorry, I modified it. I thought it was a sandbox environment.
By default, the icon is placed in the public folder. Does this not meet your requirements?

That worked fine for me...Not sure what happend to you, can you give more information about this? Like system os, etc.

That worked fine for me...Not sure what happend to you, can you give more information about this? Like system os, etc.

sorry for didn't make a working reproduction.
I've make a working one.
the problem happens when the favicon is outside public folder.
node -v v12.16.1
macos
https://github.com/07akioni/vite-favicon-bug
@underfin

It seems repl.it's content can be modified by other people.

Sorry, I modified it. I thought it was a sandbox environment.
By default, the icon is placed in the public folder. Does this not meet your requirements?

No problem, I have the same thought before, lol. It did match my requirement. However I think it need to work in other places as long as it's placed inside root folder.

Fixed at 2.0. Please upgrade and see migration guide

Fixed at 2.0. Please upgrade and see migration guide


Waterworld gets stuck after certain timesteps

While running waterworld environment from SISL, I get the following message and then the process hangs:
(raylet) [2023-06-19 01:48:23,965 E 1002285 1002285] worker.cc:199: Failed to send wait complete: IOError: 14: Connection reset by peer
(raylet) [2023-06-19 01:48:23,965 E 1002285 1002285] worker.cc:199: Failed to send wait complete: IOError: 14: Connection reset by peer
(raylet) [2023-06-19 01:48:23,965 E 1002285 1002285] worker.cc:199: Failed to send wait complete: IOError: 14: Connection reset by peer
(raylet) [2023-06-19 01:48:24,173 E 1002285 1002285] worker.cc:199: Failed to send wait complete: IOError: 14: Connection reset by peer
(raylet) [2023-06-19 01:48:24,207 E 1002285 1002285] worker.cc:199: Failed to send wait complete: IOError: 14: Connection reset by peer
(raylet) [2023-06-19 01:48:24,207 E 1002285 1002285] worker.cc:199: Failed to send wait complete: IOError: 14: Connection reset by peer
Versions / Dependencies
ray==1.8.0
ray[tune]==1.8.0
ray[rllib]==1.8.0
icecream==2.1.3
torch==1.9.0
pettingzoo==1.12.0
pettingzoo[mpe]==1.12.0
supersuit==3.2.0
numpy==1.23.0
importlib-metadata==4.13.0
gym==0.21.0
PyYAML
python==3.8
#Reproduction script
from marllib import marl
import torch
torch.manual_seed(42)
env = marl.make_env(environment_name="sisl", map_name="waterworld", force_coop=True)
mappo = marl.algos.mappo(hyperparam_source="common")
model = marl.build_model(env, mappo, {"core_arch": "mlp", "encode_layer": "128-256"})
mappo.fit(env, model, stop={'episode_reward_mean': 2000, 'timesteps_total': 10000000}, local_mode=False, num_gpus=1,
num_workers=60, share_policy='group', checkpoint_freq=100)
I am facing this issue only in the Waterworld Sisl environment. I tried different parameters for mappo but still the issue persists. Is it because of older version v3? Or an issue in Ray?

Could you please provide full trace of the error log? Thanks!

Run 2 mil steps on my local machine without encountering any errors ;)

I am able to run it for 1 million time steps on a different server.


Deprecated uninitialized variable rule

Also fixed failing test cases as part of this change

Looks good to me.


fix: flicker issue when both the min max values collide

Description
Issue
When we drag the min/max to each other and make them equal, we see a flicker to the past value in the one we are dragging.
Solution
We do a batch update when the two values collide, and then set the diff to 0 therefore it goes back to its previous value but then the batch completes and resets the value which we wanted to set hence the flicker. Now we set the diff after the batch update completes.
Fixes #18548
Media
-- Before
https://user-images.githubusercontent.com/17961105/204501044-6c062a75-9f76-444c-bee3-5e9c1d365815.mov
-- After
https://user-images.githubusercontent.com/17961105/204501270-0cb17733-8321-4644-a151-d349473a07e6.mov
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test sha=a4b9899

tested on DP, works fine


Turrets are way too loud

Description
A turret going full auto is way too loud, completely drowns out other sounds even from across the room.
Additional context
These were the shotgun turrets.
Lets try not to bust any headsets.

Is this a general gun problem? They're all the same volume.

Hmm perhaps, but guns usually only shoot a limited number of times. The turret in question leading to the creation of this issue was firing shotgun shots full auto. That might have been the reason for it sounding so loud.

can confirm, I was playing with shotgun turrets and they're loud only because of how fast the fire rate was (i cranked it to 15)
standard turrets are a lot quieter just on the premise that they're shooting .25 caseless compared to shotgun shells. default turrets should be fine, this is more indicative of being reasonable with admeme alterations rather than an issue with turret design/sound itself

This issue only seems to apply to a very specific admeme circumstance and does not seem to be a problem.


Create .gitignore

Based on JAX's gitignore

Hey Neil, thanks for the contribution.
Yeah I think we can safely remove those entries since Optax does not rely on Bazel/TF etc.

If you can remove those entries we can then merge the PR.
Apologies for the delay in getting back to you.

Done as requested :)

Hey @NeilGirdhar @hbq1 what's the state of this PR? Having a gitignore sure helps :)

It should be ready to check in right?  Unless you want me to rebase onto master?

Apologies for the delay! Merged now.


[cleanup] Remove dead extractors

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Cleanup and removal of dead/broken extractors.
Files removed:

airmozilla (Now handled by Panopto)
atttechchannel (Shut down and moved to YouTube)
biqle (Shut down piracy site, redirects to redtube) Closes #4763
bitwave (Down for 2 years)
breakcom (Original site shutdown 2018)
camwithher (Domain dead. .com seems like clone/entirely different backend)
carambatv (Shut down 2020)
channel9 (Shut down in 2021)
chirbit (Dead since January 2023)
cinchcast (Dead since 2018)
cloudy (Domain expired)
daftsex (Shut down piracy site, redirects to redtube)
defense (Site now uses YouTube)
dotsub (Shut down)
echomsk (Shut down)
ehow (No longer has videos)
elevensports (Purchased by DAZN)
ellentube (Moved to YouTube)
engadget (Shut down video section of site and moved to YouTube)
escapist (Video section from site removed, uses YouTube)
esri (Shut down and redirects to YouTube. New site mediaspace.esri.com has different IDs)
expotv (Video section gone, now does influencer marketing?)
extremetube (Dead. Redirects to YouPorn)
fourzerostudio (Shut down)
foxgay (Dead)
gfycat (Dead)
helsinki (Subdomain dead, new site uses different IDs)
howcast (Shut down video section and only uses YouTube embeds in articles, which weren't supported.)
howstuffworks (redirect to iHeart radio)
keezmovies (Dead. Redirects to YouPorn. Since Tube8 inherits from keezmovies, _extract_info function was moved over.)
laola1tv (Main site shut down, EHFTV/ITTF moved to different provider with different IDs.)
linuxacademy (Dead)
m6 (Was urL_result to 6play before. Site now also redirects)
meta (Shut down)
metacafe (Shut down)
mgoon (Dead since 2020)
miomio (Dead since 2020)
moevideo (Partially dead/rebranded. Potentially pirate hoster)
mofosex (Dead. Redirects to YouPorn)
mojvideo (Shut down in March)
movieclips (Site has shut down and only redirects to YouTube Channel)
mwave (Dead)
mychannels (Heroku Error for past year)
myvi (Dead since August)
newstube (dead, redirects to loan comparison site?)
normalboots (Site no longer has videos)
nosvideo (Dead piracy hoster)
ooyala (Sold to Brightcove with service shut down)
pandoratv (Shut down) Closes #6026
people (Removed videos section from site)
playfm ("on holiday" since 2022)
plays (Merged(?) with medal.tv, which has its own extractor)
playvid (Shut down in 2020)
porncom (Now a content aggregator, linking to other sites)
pornez (Dead pirate site)
pornhd (Now a content aggregator, linking to other sites) Closes #3232
radiobremen (merged in to ARD Mediathek)
recurbate (Domain was seized) Closes #7912
rice (mediahub is dead)
rtvnh (new site nhnieuws has different api and ids)
ruhd (Back soon since 2018)
shared (Dead piracy video hoster)
spankwire (Dead. Redirects to YouPorn)
streamcloud (Dead piracy site)
swrmediathek (Now part of ARD Mediathek)
techtalks (Moved to YouTube)
tinypic (Shut down in 2019)
tokentube (Dead since April)
trilulilu (Shut down in 2020)
tunepk (Shut down)
tvnet (Dead)
tvnow (Relaunched as RTL+)
twentyfourvideo (Dead)
unscripted (Dead)
veehd (Dead piracy site)
vimple (Dead)
vodlocker (Dead piracy site)
voicerepublic (Dead)
vrak (Shut down in October)
vrv (Replaced by CrunchyRoll) Closes #6322
vshare (Dead piracy site)
vupload (Dead)
vyborymos (Dead since 2021)
vzaar (Site shut down with api dead. Direct download links still work, but handled by generic)
wakanim (Shut down in November) Closes #1609
watchindianporn (Dead)
willow (Only TV channel now)
xbef (Dead)
xtube (Shut down)
xuite (Shut down)
yesjapan (Relaunched as From Zero. Different IDs)
yinyuetai (Relaunched on different subdomain. New IDs)
ynet (Subdomain dead. Videos on main site have different ID format)

Extractors removed:

BRMediathekIE (merged in to ARD Mediathek)
NickNightIE (Shut down 2021)
RTL2YouIE (Shut down 2017. Now part of RTL+)
RTL2YouSeriesIE (Shut down 2017. Now part of RTL+)

Extractors marked broken:

AolIE
BehindKinkIE (moved to kink.com/blog)
BFIPlayerIE (Only supported ooyala based videos)
BetIE
BYUtvIE
Clubic (Uses ancient m6 endpoint)
CMTIE
DHMIE
NRLTVIE (Only supported ooyala based videos)
SCTEIE (Subdomain dead. IDs on new site might be the same. Authwalled)
SCTECourseIE (Subdomain dead. IDs on new site might be the same. Authwalled)
SRMediathekIE (Partially moved to ARD Mediathek. Other parts broken)
ToypicsIE (new site no longer on videos subdomain)
ToypicsUserIE (new site no longer on videos subdomain)
Tube8IE (Modified to no longer inherit from KeezMoviesIE. Not deleted, since site is similar enough to before)
VidbitIE (Currently invite only, site has new URL structure)
VootIE (Merged with JioCinema)
VootSeriesIE (Merged with JioCinema)

Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Another one that should be removed is hitbox, which has been dead since 2020.

@LoneFox78 Thanks for the hint.
Discovered a mistake in my testing method, where network errors would cause a skip, which meant the test was counted as a pass. Re-ran all tests and found these additional dead sites:

clipsyndicate (Site redirects to some 2-year-old landing page. Looking on IA seems to have been down since 2021)
fusion (Dead since 2021)
hitbox (Dead since 2017)
mnet (Moved to mnetplus.world and TVING. IDs are different)
watchbox (Dead since 2019)

wow. this is some heavy work.


Email notification: Administrator: Deposited item with Globus option

See: https://docs.google.com/document/d/1TZVILUrORI25kRZyUZ70vMQYo90Ngp_tqCI7BdU_VyQ/edit#heading=h.8x9m2iq2234s
Note: send to all H2 administrators
Subject: User has deposited an item with files on Globus
Body:
Dear Administrator,
The following item has been deposited with the "Files have been uploaded to Globus" option checked.
Item: [item.name] [linked to the item details page]
Collection: [collection.name] [linked to the collection details page]
Deposited by: [depositor’s preferred name]
The Stanford Digital Repository Team

See also #2349, which implements the feature this notification is about.


[LANG-1578] refine StringUtils.compare

as title.

Hi.
there is some spotbugs issue in this pr.
seems we need to black-list some functions out of spotbugs.
Any ideas about how to achieve it?

Coverage increased (+0.007%) to 94.685% when pulling f396b9c3b63db59dbb485aa1f421513d1ae56ffa on XenoAmess:refine_compare into da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master.

@garydgregory rebased. please find some time to review. thanks.


[BUG] Jacobian computation incorrect for prismatic joints

Description
Prismatic joints are ignored in the Jacobian computation. Note that this was discovered through the same problem in kinpy issue, which uses very similar code.
Steps to Reproduce

Create a robot with purely prismatic joints, such as defined by this URDF file:

<robot name="prismatic_robot">
<link name="link1" />
<link name="link2" />
<link name="link3" />
<link name="link4" />

<joint name="joint1" type="prismatic">
    <origin xyz="0.0 0.0 1.0"/>
    <axis xyz="0 0 1"/>
    <limit lower="-0.5" upper="0.5" effort="1" velocity="1"/>
    <parent link="link1"/>
    <child link="link2"/>
</joint>
<joint name="joint2" type="prismatic">
    <origin xyz="0.0 0.0 0.0" rpy="1.57079632679 0 0"/>
    <axis xyz="0 0 1"/>
    <limit lower="-0.5" upper="0.5" effort="1" velocity="1"/>
    <parent link="link2"/>
    <child link="link3"/>
</joint>
<joint name="joint3" type="prismatic">
    <origin xyz="0.0 0.0 0.0" rpy="0 1.57079632679 0"/>
    <axis xyz="0 0 1"/>
    <limit lower="-0.5" upper="0.5" effort="1" velocity="1"/>
    <parent link="link3"/>
    <child link="link4"/>
</joint>

</robot>

Compute Jacobian in world/base frame with any configuration
Produce the zero matrix as the Jacobian

Expected Behavior
The Jacobian of this robot for any configuration should be
                                           [[0., 0., 1.],
                                            [0., -1., 0.],
                                            [1., 0., 0.],
                                            [0., 0., 0.],
                                            [0., 0., 0.],
                                            [0., 0., 0.]]

Additional Context
I did not directly run pybotics code, but discovered this problem through kinpy, which uses the same code to compute Jacobians. There, the robots can be defined via URDF files, hence I provided the URDF here.
I discovered this problem while building my pytorch kinematics project, with a solution in this file. However, I am not familiar with the pybotics code base so am not sure how to directly port that over.

hi @LemonPi
Prismatic links need to use the PrismaticMDHLink class (see below). Since they're used much less regularly than revolute joints (in my research and work at least), I never made many helper functions for these. I'd be happy if you wanted to contribute prismatic code features, that would help a lot!
https://github.com/nnadeau/pybotics/blob/90e3503417300fc63b2f224a416c1f95369dc9b3/pybotics/link.py#L156-L161
Otherwise, I'm not familiar with kinpy nor do I know of any code connection.
Closing this ticket as prismatic joints are relatively supported, but it's also more of a feature request if you're looking for a direct URDF -> pybotics feature

hi @LemonPi
Prismatic links need to use the PrismaticMDHLink class (see below). Since they're used much less regularly than revolute joints (in my research and work at least), I never made many helper functions for these. I'd be happy if you wanted to contribute prismatic code features, that would help a lot!
https://github.com/nnadeau/pybotics/blob/90e3503417300fc63b2f224a416c1f95369dc9b3/pybotics/link.py#L156-L161
Otherwise, I'm not familiar with kinpy nor do I know of any code connection.
Closing this ticket as prismatic joints are relatively supported, but it's also more of a feature request if you're looking for a direct URDF -> pybotics feature