N-ary Tree Inorder Traversal in cpp

🚀 Feature
Code for the inorder traversal of a N-ary tree.
Have you read the Contributing Guidelines on Pull Requests?
yes
Motivation
The code for the inorder traversal of N-ary tree is not commonly available. Therefore, want to work on this.

/assign

Problem already available.


rclex_connection_tests becomes failed on Dashing from v0.6.0_rc

One of the simplest solution for us is to throw away Dashing because the EOL of Dashing has already been passed :D

https://github.com/rclex/rclex/actions/runs/1729037863
Compiling 19 files (.ex)
warning: variable "defstruct" does not exist and is being expanded to "defstruct()", please use parentheses to remove the ambiguity or change the variable name
  lib/rclex/geometry_msgs/msg/twist.ex:2: Rclex.GeometryMsgs.Msg.Twist

== Compilation error in file lib/rclex/geometry_msgs/msg/twist.ex ==
** (CompileError) lib/rclex/geometry_msgs/msg/twist.ex:2: undefined function defstruct/0

Error: Process completed with exit code 1.

After a long consideration, we have decided to deprecate Docker for the target environment  85fd13d0f3abd62db41d4080cea50122cfe49750


Select convo when acting on a chat notification

This fixes a bug where the convo doesn't load if acting on the chat
notification launches Keybase.

r? @keybase/react-hackers


Use bundle to add or modify multiple flow entries in a same operation

Describe the problem/challenge you have
When a new pod/node/networkpolicy is added, multiple OpenFlow entries are needed to ensure the networking connectivity or isolation. Currently, Antrea is installing Openflow entries one by one, it is difficult to rollback when errors are happening.
Describe the solution you'd like
Bundle is a key feature introduced in OpenFlow1.4. It is a sequence of OpenFlow modification requests from the controller that is applied as a single OpenFlow operation. If all modifications in the bundle succeed, all of the modifications are retained, but if any errors arise, none of the modifications are retained.
We could introduce bundle in OpenFlow gobinding, and leverage it to install multiple OpenFlow entries in a batch.
Anything else you would like to add?
N/A

Assign it to myself.

I think it's worth adding that this change would make error handling much easier in the Antrea OpenFlow client, and in particular when it comes to installing flows for network policies. There will be no need to implement rollback manually.

As discussed in another issue (https://github.com/vmware-tanzu/antrea/issues/195#issuecomment-566222964), we could use bundle support to improve how we send Gratuitous ARP packets after adding a new Pod. If libOpenflow can notify us on a Go channel when a bundle has been processed by OVS, we can use that information to stop sending GARPs.
@wenyingd I added this comment so we don't lose sight of this after merging #195


[QUERY] Trigger a logic app workflow with a custom payload using logic app management client library

Library name and version
Azure.Management.Logic
Query/Question
I want to developed an azure function in C#. This function will get triggered from an action group and will get a payload as an input.
The function is expected to process the payload, runs logic app workflow and pass that payload to the logic app workflow.
We are committed to use azure .net sdk to communicate with azure services and want to go away from REST APIs.
Can you please provide a way to trigger the logic app workflow using the .net sdk client libraries in C# instead of calling REST api directly?
Environment
.Net 8
Azure function in C#
Visual studio
Azure .net sdk

Hi @SanketTag , if you could provide the RestApi you were using, we could find you the correct SDK methods. Or you could search the repo with the  api yourself, you may found those methods and check the samples for usage guide.

I am not using any rest api. However, I am using RunAsync method on workflowtrigger object created with client library for logic app management.
The runAsync method does not accept the payload to pass to the HttpTrigger .
can you please provide a way to pass the payload to trigger the logic app using .net ask client libraries.

Hi @SanketTag, you can refer to the following methods to achieve the functionality you want.
var logicWorkflowCollection = resourceGroup.GetLogicWorkflows();
var workflowName = "workflow";
var definition = File.ReadAllBytes("WorkflowDefinition.json");
// It is a method defined in the File class under the "System.IO".
// "WorkflowDefinition.json" is the path where you store the JSON file
var data = new LogicWorkflowData(AzureLocation.BrazilSouth)
{
    Definition = new BinaryData(definition)
};
var logicWorkflow = (await logicWorkflowCollection.CreateOrUpdateAsync(WaitUntil.Completed, workflowName, data)).Value;

The following is the content of WorkflowDefinition.json.
This JSON file is a workflow definition for Azure Logic Apps. Its function is to define the workflow of a logical application, which includes triggers and actions.
{
  "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#",
  "contentVersion": "<IP_ADDRESS>",
  "parameters": {},
  "triggers": {
    "manual": {
      "type": "Request",
      "kind": "Http",
      "inputs": {
        "schema": {}
      }
    }
  },
  "actions": {
    "Response": {
      "runAfter": {},
      "type": "Response",
      "kind": "Http",
      "inputs": {
        "statusCode": 200
      }
    }
  },
  "outputs": {}
}


Fix user ingestion for GitlabOrgDiscoveryEntityProvider for GitLab.com

Hey, I just made a Pull Request!
Fixes an issue with user ingestion for GitLab.com by making the entity provider aware of the group config parameter and scoping the provider to this group. Previously, the Gitlab Org data entity provider attempted to fetch all users from Gitlab.com via the /users REST endpoint, which was undesirable.
Switched the user fetching for Gitlab.com to GraphQL API, scoped to the root Gitlab group for the Org, or via existing /users REST API for Gitlab Self-Managed.
Groups are fetched via GraphQL API for Gitlab.com and via existing /groups REST API for Gitlab Self-Managed.
Group members are fetched via existing GraphQL API for both instance types
Example provider configuration used to test with:
catalog:
  providers:
    gitlab:
      gitlabSaasOrgData:
        host: gitlab.com
        orgEnabled: true
        group: org/teams
        rules:
          - allow: [Group, User]

Relates to:

https://github.com/backstage/backstage/issues/16025

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Tested on GitLab Self-Managed (16.1.1) without group parameter:

All User entities ingested from GitLab instance (all users have email on profile)
All Group entities ingested from GitLab instance

Tested on GitLab.com w/ group parameter configured

User entities ingested for users who are direct members of descendant GitLab groups of the configured group
Group entities ingested for descendant GitLab groups of the configured group

@freben  @alde Would appreciate some reviews here, and if you can remove the stale label 🙏
I'm not 100% sure on the changeset version for this change. My gut feeling if minor, but will await your feedback. Thanks!

Thanks for the review @jamieklassen and for the helpful feedback! I have addressed point 2 and 3 I believe. PTAL when you have a chance 😄
Could you elaborate on what bolierplate you might deduplicated in point 1?
I don't believe that I have the capacity at the moment to address your point 4 I'm afraid 😞

Thanks once again for the review @jamieklassen and the very helpful suggesstions 💪
I think we're very close here now, if you can take another look and hopefully over to @alde / @freben
We're hoping we can get this in for 1.18 release, as it's preventing us from enabling sign-in resolvers for user identity, which is blocking various options and plugins on out adoption journey 🤞

Very nice work! Also hoping for a 1.18.x release!

Great work!  Anxiously waiting for the merge to use it!

Should we hold off waiting for the publicEmail question, or is this ready to go from your POV?

Should we hold off waiting for the publicEmail question, or is this ready to go from your POV?

We've switched to commitEmail it's is similarly not guaranteed to be populated or returned from the GraphQL API, but seems like a more sane default attribute in hindsight
Further details in the comment here - https://github.com/backstage/backstage/pull/18889#discussion_r1313026717

See above about group?.id and user.user?.id - besides that I think we are ready to 🚢

Greate work guys!!!


small improvement to the readability of the Local Transactions topic

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


feat(perf): Remove stores with known values

Description
Problem*
Follow-up to https://github.com/noir-lang/noir/pull/5925 and alternative to https://github.com/noir-lang/noir/pull/5865
Working towards #4535
Summary*
Additional Context
Documentation*
Check one:

[ ] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

[ ] I have tested the changes locally.
[ ] I have formatted the changes with Prettier and/or cargo fmt on default settings.

Closing in favor of https://github.com/noir-lang/noir/pull/5935 as to base off of master


[tflite][android]deeplab-v3+ runtime error on Pad Ops

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):NO
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): MacOS 10.13.6
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: BlackBerry KEY2
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): master branch last commit is 78f58629ae4a47a799e88da7a78ecfcb6a6115cc
Python version:3.6.3
Bazel version (if compiling from source):0.15.2
GCC/Compiler version (if compiling from source): NDK r17 toolchain
CUDA/cuDNN version:NA
GPU model and memory:NA
Exact command to reproduce:

Describe the problem
I download the pre-trained modals with MobileNet-v2 from mobilenetv2_coco_voc_trainaug. covered model to tflite then load into android application, I see internal error at OP Pad on prepare.
Source code / logs
using below command to cover the model without any errors:
bazel run //tensorflow/contrib/lite/toco:toco -- \
  --input_file=/tmp/frozen_inference_graph.pb \
  --output_file=/tmp/optimized_graph.tflite \
  --input_format=TENSORFLOW_GRAPHDEF \
  --output_format=TFLITE \
  --input_type=QUANTIZED_UINT8 \
  --input_arrays=ImageTensor \
  --output_arrays=SemanticPredictions \
  --input_shapes=1,513,513,3

below command to build tensorflow-lite.aar
bazel build --cxxopt='--std=c++11' -c opt        \
  --fat_apk_cpu=x86,x86_64,arm64-v8a,armeabi-v7a   \
  //tensorflow/contrib/lite/java:tensorflow-lite

Then I load optimized_graph.tflite and tensorflow-lite.aar into Android application project
  private static final int DIM_PIXEL_SIZE = 3;
  static final int DIM_IMG_SIZE_X = 513;
  static final int DIM_IMG_SIZE_Y = 513;

    tflite = new Interpreter(loadModelFile(activity));
    imgData =
        ByteBuffer.allocateDirect(
            DIM_IMG_SIZE_X * DIM_IMG_SIZE_Y * DIM_PIXEL_SIZE);
    imgData.order(ByteOrder.nativeOrder());
    outputs = new int[DIM_IMG_SIZE_X * DIM_IMG_SIZE_Y];

  /** Memory-map the model file in Assets. */
  private MappedByteBuffer loadModelFile(Activity activity) throws IOException {
    AssetFileDescriptor fileDescriptor = activity.getAssets().openFd(MODEL_PATH);
    FileInputStream inputStream = new FileInputStream(fileDescriptor.getFileDescriptor());
    FileChannel fileChannel = inputStream.getChannel();
    long startOffset = fileDescriptor.getStartOffset();
    long declaredLength = fileDescriptor.getDeclaredLength();
    return fileChannel.map(FileChannel.MapMode.READ_ONLY, startOffset, declaredLength);
  }

run Interpreter
tflite.run(imgData, outputs);

Error Logs:
07-31 16:20:36.144 25819-25974/android.example.com.tflitecamerademo E/AndroidRuntime: FATAL EXCEPTION: CameraBackground
    Process: android.example.com.tflitecamerademo, PID: 25819
    java.lang.IllegalArgumentException: Internal error: Failed to run on the given Interpreter: tensorflow/contrib/lite/kernels/pad.cc:96 op_context.dims != 4 (3 != 4)Node number 24 (PAD) failed to prepare.

        at org.tensorflow.lite.NativeInterpreterWrapper.run(Native Method)
        at org.tensorflow.lite.NativeInterpreterWrapper.run(NativeInterpreterWrapper.java:130)
        at org.tensorflow.lite.Interpreter.runForMultipleInputsOutputs(Interpreter.java:168)
        at org.tensorflow.lite.Interpreter.run(Interpreter.java:145)

We will investigate. Meanwhile, could you make sure your input tensors are 4D? Are you calling resizeInput()?

@andrehentz I use pre-trained model from model_zoo https://github.com/tensorflow/models/blob/master/research/deeplab/g3doc/model_zoo.md, I think it's 3-D tensor with shape [height, width, channels] for PAD.
I noticed from Pad.cc there's a TODO
  TF_LITE_ENSURE_EQ(context, op_context.dims, 4);

seems Pad not support 3D tensor right now.

Thanks @kismeter We are tracking this and will support 3D (and other) soon.

Nagging Assignee @gargn: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @gargn: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Hello! I see there are still some ops (SPACE_TO_BATCH_ND, SPACE_TO_BATCH_ND) which support only 4D tensors:
tensorflow/contrib/lite/kernels/space_to_batch_nd.cc:96 NumDimensions(op_context.input) != kInputDimensionNum (3 != 4)
3D support for this ops is hightly required! Are you planning to implement it in near future? Should i create feature request?

Just for a clarification, do you need BatchToSpace non-4D and SpaceToBatch non-4D, or just BatchToSpace non-4D?
BatchToSpace non-4D hasn't been prioritized yet, contributions are welcome, but we are also tracking these operations requests here: https://github.com/tensorflow/tensorflow/issues/21526 to help with prioritizing. For that reason, moving forward we are closing individual issues for operation requests. Feel free to file an issue if you have more info on the specific model you are trying to convert. Thanks!


oauth not found

Hi! Sorry to disturb you again! after I set up your oauth package in laravel 5, I got an issue when accessing my rest api. It displays 'class oauth does not exist'. Here is my part of codes in Route.php:
Route::group(['namespace' => 'Api', 'middleware' => 'oauth'], function(){
........
});
I think I need to alias class oauth in routeMiddleware in Kernel.php, but I wonder which class should I alias?

oauth is meant to be used as 'before_filter' => 'oauth' this because it can have parameters passed to it.

is oauth a class name or what? I am not pretty sure about it.

it's a string

Thank you!


Json path doesn't match. Expected sql.Date, found lang.String

I have a problem with deserialisation of response body. I need sql.Date but in fact I get lang.String
Help me to correctly setup my RestAssure, please.
Here is how my RestAssure.config looks:
RestAssured.config = RestAssuredConfig.config()                 .objectMapperConfig(objectMapperConfig()                         .gsonObjectMapperFactory((aClass, s) -> new GsonBuilder().setDateFormat("yyyy-MM-dd").create()));
Here is my test:
given()                 .contentType("application/json")                 .when()                 .get("some url")                 .then()                 .assertThat().body("birthday", response -> equalTo(Date.valueOf("2016-06-07")))
And such exception I got:
java.lang.AssertionError: 1 expectation failed. JSON path birthday doesn't match. Expected: <1994-12-30>   Actual: 1994-12-30

What do you mean? You can't represent Date objects in JSON.

I want to make RestAssure to properly deserialise response data that is was possible to compare it to sql.Date.

Ok so then you probably need to configure Gson properly. I don't know how to do this though so I would suggest that you read up in its docs. Also REST Assured might not use GSON if you have multiple JSON libraries in your classpath (see docs).


Update of, well, everything

It's been a while, so a few things needed an update:

Added support for 7.0 and 7.1.
Switched from Coveralls to Codecov for code coverage
Fixed PHPUnit namespaces

Tests passes on >=5.3.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@859d596). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master     #6   +/-   ##
=======================================
  Coverage          ?   100%
=======================================
  Files             ?      9
  Lines             ?    263
  Branches          ?      0
=======================================
  Hits              ?    263
  Misses            ?      0
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 859d596...3cf940f. Read the comment docs.


Use improved Final Exponentiation algorithms for BLS12 curves

Yousef recently benchmarked a variety of pairing based curve libraries' performance here: https://hackmd.io/@zkteam/eccbench, which is extremely helpful for identifying places to improve performance!
Something notable is that the difference in final exponentiation speed for a variety of curves is >2x relative to the implementation in gurvy.  (The base curve arithmetic is faster in gurvy as well, suggesting that a lot of the speed difference is also attributable to base field speed differences).
The hard part of the final exponentiation in gurvy (bls12-377 src, bls12-381 src ) uses improved algorithms from https://eprint.iacr.org/2020/875.pdf, along with ideal addition chains for exponentiating by t and t/2. That algorithm claims to take ~500 fewer base field multiplications than the prior state of the art.
Arkworks currently implement something slower than the mentioned prior of the state. (Assuming tight implementations of sub-routines, it takes ~5 extra operations in Fp12, which is around 500 base field operations. Furthermore the arkworks implementation has significantly higher register pressure, which is likely a significant performance hit at the relevant field sizes)
I think we should amend the bls12 parameters to include an addition chain for exponentiating by t and t/2 (I confess that I'm not yet clear on what t is yet), and implement it.
Its likely that the improved algorithm has different cases that need to be accounted for, as the bls12-381 and bls12-377 final exponentiation code in gurvy are not the same.

Thanks @ValarDragon . I think it would be interesting to investigate what changes could be made to the group ops add and double to be more on par with the competing libraries. This probably deserves a different issue.
One wonders whether the limitations exist in how things are inlined or other compiler level things.
Personally, I'd like to bench some of these results myself. I'm unhappy with the sometimes inconsistent results one can get when calling --target=native v.s. not doing so.

I took a look at the mixed addition formulae, and they are exactly the same for the short weierstrass curves. This leads me to believe that the speed difference there is between field arithmetic differences, and compiler-level things / inlining.

The mixed addition and doubling formulae are the same. The only difference I can think of is that the compiler is not optimizing out temporaries well, so we might have to move to using the _assign variants, which perform operations in place.

I did think of another explanation, which is that the bottleneck is in fact not in the mul and squaring, since when I benched them they were neck and neck or faster than goff or mcl, but rather in addition and subtraction, which use iterators as defined in the biginteger trait

So yes, there is a discrepancy between arkworks and celo-org/zexe, for bls12_381, fq square is 34.4ns in former vs 25.0ns in latter. That's a 37.6% difference, which is rather appalling.

I can only conclude that the port was done in a rushed manner with little concern for checking correctness, as I have encountered numerous uncalled-for modifications, which must have been the source of all these issues we have encountered recently. This is quite appalling as one expects that in a port, one should be cautious to be as faithful to the original as possible.

The assembly output is the same for zexe and arkworks, so I'm not sure where the difference would lie?

In my opinion, it is ill conceived to have reworked the entire asm mul framework without having bothered to bench to check for regressions

the framework wasn't reworked; I just moved some components around. Most of the code is identical.

Appears https://github.com/ConsenSys/gurvy/pull/29 contains the gurvy changes

So yes, there is a discrepancy between arkworks and celo-org/zexe, for bls12_381, fq square is 34.4ns in former vs 25.0ns in latter. That's a 37.6% difference, which is rather appalling.

In the last version of zexe, the cost of square is still 37ns/iter (same as multiplication), so I think any change in the performance happened before the transition.

I think you got it wrong, as it ought to be correct that the mul and square are approximately equal. However, currently on arkworks, the square is about 20% slower (34.5ns vs 28ns). So the regressions according to what you said, seem to have happened after the transition.

How fast is multiplication? On my machine multiplication and square are both 37 ns/iter

Ok, so actually I didn't do cargo update to get the asm fix, it appears once I did that, the timings were as expected. I think now that git pull is not enough, I have to remember to do cargo update frequently too.
There seems to have been some improvements against old zexe in terms of fq::add_assign, strangely enough, and also the overall perf of non-asm mul_assign.
In any case, I estimate the following:
bls12_381::
g1::add_assign_mixed 544ns (v.s. gurvy 387ns).
g1::double 320ns (v.s. gurvy 245ns)
I think if one would like to close such a gap (around 30-40%), one should either write more assembly or unroll loops for most of the operations (add/sub/double/negate).
The naive impls of these I believe actually have significant contributions to slowdown.

I think this can be closed, since the optimisation as per issue title was done in https://github.com/arkworks-rs/algebra/pull/211.
The discussion around general benchmarking and performance comparisons can be continued in https://github.com/arkworks-rs/algebra/issues/80 if needed, though we should probably define smaller and more concrete optimisation targets if someone's to actually push it forward.


How to get ipv6 address of client from req object

I am using req.ip to get the client ip address and it is returning ::ffff:<IP_ADDRESS> but i think this is ipv4 address. I wanted to retrieve the ipv6 address of a client. Is it possible get it from req object?

Hi @ksushilmaurya, the req.ip property is just the IP coming from the Node.js req.connection.remoteAddress core functionality in most cases. The address you provided, ::ffff:<IP_ADDRESS> is an IPv4 address that has been mapped into the IPv6 namespace (typically done from a dual stack network listening on IPv4.
The way you can get an IPv6 address is better asked over in the Node.js core repository (since you are most likely using the Node.js core HTTP server), but it boils down to the following two steps:

Start your server listening on the IPv6 network stack (typically app.listen('::'); see Node.js documentation for more https://nodejs.org/dist/latest-v6.x/docs/api/http.html#http_server_listen_port_hostname_backlog_callback).
Make a request to your server using the IPv6 network, not the IPv4 network.


chore: upgrade yarn.lock => lint

Description
If we upgrade the packages the new linter complain about some details, those are fixed in this PR.

@adjisb Do we still want to merge this?

We will run the yarn upgrade on master


Cannot change 2nd date once a date has been picked

Case #1

Enter a date for the 1st item, e.g. 10 Sep.
Enter a date for the 2nd item, e.g. 11 Sep.
Open the date picker on the 2nd item.

Expected: can select any date on or after 10 Sep.
Actual: can only select dates between 10 Sep and 11 Sep.
Workaround: clear the date from the item first
Case #2

Enter a date for the 1st item, e.g. 10 Sep.
Enter a date for the 2nd item, e.g. 11 Sep.
Change the 1st date to an invalid date, e.g. 12 Sep.
Attempt to change the 2nd date.

Expected: can select any date on or after 12 Sep.
Actual: cannot select any date at all, cannot navigate months.
Case #3

Enter a date for the 1st item, e.g. 10 Sep.
Enter a date for the 2nd item, e.g. 11 Sep.
Attempt to change the 1st date.

Expected: can select any date not later than 11 Sep.
Actual: can select any date.
I suspect these issues are related.

+1
It was working fine in the pre-5.0 version: https://apex.oracle.com/pls/apex/f?p=45587:700:0

@jeffreykemp @vincentmorneau This is not a bug, rather a configuration option. You probably have the following setting for the TO_DATE item:

This does raise a good point, that the plugin should catch this issue as it can be very hard to debug. As such I will update the plugin to show an alert message on run time to let developers know right away:

As well, when the application is run in debug mode it will be obvious to developer and provide reference back to this issue:

Update: As they're other possible mis-configurations I have moved all the configurations into the plugin render function. As such these will now be PL/SQL errors that show up when the page is run if the item configuration is invalid.


Turning off New UI doesn't work until manual refresh

Describe the bug
There is a regression in 2018.2 beta where if you turn off the New UI it has no effect until you go to a page other than settings, and press F5 (browser refresh).
In 6.6 Stable, after changing the setting I could click on 'Dashboard' and the New UI would be turned off.
To Reproduce
Steps to reproduce the behaviour (assuming you're on a server which already has the new UI enabled):

Go to Settings > UI
Click the toggle for 'Enable new UI' so that it is off
Click on the 'Dashboard' menu item - observe that you're still in the new UI
Press F5 to refresh your browser - observe that now you in the old UI

Expected behaviour
When I arrive at the dashboard in step 3 above I expect to see the system in the old UI.
Platform:

OpenEquella Version: 2018.2-beta
OS: Ubuntu server, Debian client
Browser Firefox

Additional context
I've confirmed this works in 6.6-Stable.

Issue no longer relevant, as the "Enable new UI" switch now reloads the page and changes the UI instantly.


Tests can fail when being re-run because they try to redefine existing functions

Although a single test script is only loaded once, there are test functions which internally define new functions.  If they don't either use func! to define the function or call delfunc at the end of the test routine, then a re-run of the test (e.g., due to flakiness) will cause the test to fail due to redefining an existing function.
One such example is Test_term_nasty_callback, which defines OpenTerms and TermExit unsafely.
:vimgrep /^ \+func\%[tion]\>[^!]/ src/testdir/test_*.vim finds a lot of potentially problematic function definitions.  I haven't verified which of them can actually cause problems.

James McCoy wrote:

Although a single test script is only loaded once, there are test
functions which internally define new functions.  If they don't either
use func! to define the function or call delfunc at the end of the
test routine, then a re-run of the test (e.g., due to flakiness) will
cause the test to fail due to redefining an existing function.

Ideally every test cleans up after itself.  There are a few checks, but
not for everything.  Files are cleaned up by the Makefile (needed when a
test causes and error and doesn't get to the cleanup lines).
I just added a check that a test doesn't leave any popup windows behind
and fixed a few tests that did.  We can add more of these checks if that
is useful.

One such example is Test_term_nasty_callback, which defines
OpenTerms and TermExit unsafely.

That was just fixed yesterday.

:vimgrep /^ \+func\%[tion]\>[^!]/ src/testdir/test_*.vim finds a lot
of potentially problematic function definitions.  I haven't verified
which of them can actually cause problems.

They should show up when a test fails a second time.  And then running
it more often won't help, thus keep failing.
In Vim9 script this will get better, as functions will be local to the
scope by default.  But it's not stable enough yet to use outside of the
"vim9" tests.
--
I AM THANKFUL...
...for the piles of laundry and ironing because it means I
have plenty of clothes to wear.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

They should show up when a test fails a second time. And then running it more often won't help, thus keep failing.

Right, and that's the problem.  The test, which is expected to retry, fails any retry because it's incorrectly redefining local functions.
Every local function should either be declared using func! or have a matching delfunc (and I'd prefer the former since it's less to forget).  If you agree with this, I can make the changes.

They should show up when a test fails a second time. And then
running it more often won't help, thus keep failing.

Right, and that's the problem.  The test, which is expected to retry,
fails any retry because it's incorrectly redefining local functions.
Every local function should either be declared using func! or have a
matching delfunc (and I'd prefer the former since it's less to
forget).  If you agree with this, I can make the changes.

Yes.  I was meaning that when "delfunc" is missing we would find out if
it is flaky, since the retry will also fail.
I prefer using "delfunc", because then an error is given when
accidentally using the same function name again.  Which is common when
copy/pasting lines to add another test case.
--
hundred-and-one symptoms of being an internet addict:
101. U can read htis w/o ny porblm and cant figur eout Y its evn listd.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


Runs coverage no matter what build result.

Runs coverage no matter what build result.

[Current coverage][cc-pull] is 91.92%

Merging [#2065][cc-pull] into [master][cc-base-branch] will increase coverage by 0.62%

@@             master      #2065   diff @@
==========================================
  Files            93         93
  Lines          6537       6537
  Methods        1169       1169
  Messages          0          0
  Branches       1370       1370
==========================================
+ Hits           5968       6009    +41
+ Misses          569        528    -41
  Partials          0          0

Powered by Codecov. Last updated by [b2a5092...f06c481][cc-compare]
[cc-base-branch]: https://codecov.io/gh/ParsePlatform/parse-server/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/ParsePlatform/parse-server/compare/b2a509262767dd2c56e41c10ec7edf57bacdfd85...f06c481ccd414fa2d66b6645cbdbeb6797b3e70a
[cc-pull]: https://codecov.io/gh/ParsePlatform/parse-server/pull/2065?src=pr

Awesome! I'm somewhat surprised this works.


Book search is failing to reindex correctly if events are changed (add/delete/reassociate) without updating work record

Describe the bug
When a work is altered on the test-admin site, the test-production site adds the new work but does not reindex the old work on the book sort page. For example, when I divided "Vanity Fair" from one periodical with 16 events to the periodical with 4 events and another entry for the novel Vanity Fair with 12 events, the production site shows the novel entry with 12 events but still shows the periodical work with 16 entries when it should only be 4. This is only wonky on the search page; when you click through to the individual work bibliography page, circulation page, and card page it does the expected 4 events.
RSK put it more concisely on Slack:  the error is happening if you change events (especially add/delete/reassociate) without updating the work record.
To reproduce
Steps to reproduce the behavior:

Change events for a work without altering the work entry itself
See that the altered work does not show up with its changes in the book search page

Expected behavior
When events within a work are changed (added, deleted, or re-associated) the book search page should show the correct number of events.
Screenshots
Example of error with Vanity Fair:

Have configured a nightly cron job to reindex works in the interim until this is resolved. The cron job should be turned off when this is fixed.

I went to the test admin site and created a new item -- 2020 by Virginia Woolf. I created one event -- a Hemingway borrow. I then went to the test site: the book was there, but the search page was showing 0 events.
I added another borrow to the same book -- by Stein -- and still 0 events on the search page.  I don't know how I tested it differently earlier.
I added a borrow to a preexisting item -- Brooke's 1914. The search page only shows one event when there should be two.

@jkotin  I think I figured out what's going on here — indexing was working if you saved generic events but not if you saved borrows and purchases. Please test to confirm that my fix resolves this.

Yes, it works. I tried borrows, purchases, and generic -- the additional events showed up in search results and on bibliography page.


tests: add cases and demos for req id ws

Codecov Report

Merging #162 (2784ce0) into main (9547925) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   76.55%   76.55%
=======================================
  Files          20       20
  Lines        2474     2474
=======================================
  Hits         1894     1894
  Misses        580      580

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Provide guidance for ISBN fetching

@andrew2net can you also update relaton.org for ISBN? Thanks.
Originally posted by @ronaldtse in https://github.com/relaton/relaton-isbn/issues/1#issuecomment-1880270870

Updated


contents: add Parking Lot question to OOP

Design a parking lot system is an important sample question in low-level design. It would be great if this question is added.

Many thanks!


[RESOLVED] printNextSteps is not a function (FIXED v2.6.0)

There was an error in the printNextSteps  file where I accidentally commented out the module.exports. That resulted in an error like this:
npm/_npx/1103/lib/node_modules/wpgulp/installer/index.js:34
        throw err;
        ^

TypeError: printNextSteps is not a function

So, it was fixed in v2.6.0. It may take a while for npx to pick it up but you can test npx<EMAIL_ADDRESS>and it works. But mostly you should be fine with just npx wpgulp in an hour after the release.
Thanks for the report Shamai.

Just tested npx wpgulp and it's working fine.

hmmm for some reason it wont work on one of my macs. I get this error when i try to run npx wpgulp:
Bug Report
throw err;
      ^
Error: Command failed: npm install --silent

Node: 8.12
NPM: 6.4.1
Then, specify:

Operating system: Mac OS 10.13.6


[SPARK-29292][SQL][ML] Update rest of default modules (Hive, ML, etc) for Scala 2.13 compilation

What changes were proposed in this pull request?
Same as https://github.com/apache/spark/pull/29078 and https://github.com/apache/spark/pull/28971 . This makes the rest of the default modules (i.e. those you get without specifying -Pyarn etc) compile under Scala 2.13. It does not close the JIRA, as a result. this also of course does not demonstrate that tests pass yet in 2.13.
Note, this does not fix the repl module; that's separate.
Why are the changes needed?
Eventually, we need to support a Scala 2.13 build, perhaps in Spark 3.1.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests. (2.13 was not tested; this is about getting it to compile without breaking 2.12)

Test build #125859 has started for PR 29111 at commit 8b9f4a8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30469/
Test PASSed.

Test build #125859 has finished for PR 29111 at commit 8b9f4a8.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class Estimator[M <: Model[M] : ClassTag] extends PipelineStage

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125859/
Test FAILed.

Yep, as I feared:
[error]  * method this()Unit in class org.apache.spark.ml.Estimator does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.Estimator.this")
[error]  * method this()Unit in class org.apache.spark.ml.Predictor does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.Predictor.this")
[error]  * method this()Unit in class org.apache.spark.ml.classification.ProbabilisticClassifier does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.classification.ProbabilisticClassifier.this")
[error]  * method this()Unit in class org.apache.spark.ml.classification.Classifier does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.classification.Classifier.this")

Adding a ClassTag means it implicitly has a new parameter in the bytecode and that breaks MiMa. Hm. I'll have to think about this more

Test build #125864 has started for PR 29111 at commit bc74297.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30473/
Test PASSed.

Test build #125864 has finished for PR 29111 at commit bc74297.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class Estimator[M <: Model[M]] extends PipelineStage

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125864/
Test FAILed.

I think I understand the last test failures, will fix too.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30512/
Test PASSed.

I can confirm that modules after REPL also compile (I commented out REPL locally). That's a good step, and I can look at getting the secondary modules compiling next.
For anyone watching, I am entirely open to questions about the approach here. The changes are actually quite superficial but broad. I do want to keep an eye on issues like perf regressions - I do not expect them in 2.12 but may be an issue in 2.13 builds.

Oh erm, we didn't get a passing test after my last commit - I did double-check it passes 2.12 tests after the last change, but, should we be watching out for that or is this all down to github actions now?

Hi, @srowen .  Please see here.

https://github.com/apache/spark/pull/29111/commits/6390b6c46f5bf35e0c92b140bfbe12f98c35cd8f

Also, here.

For a record, this is merged because all tests passed in GitHub Action.

For now, GitHub Action finished in two hours if there is no congestion.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125904/
Test FAILed.


Wv 261  converted methods into static methods [MERGE READY]

Converted methods with warning to @staticmethod.  It's available for review

Great work Ilona, thank you! 👍


SlotSet in RemoteAction should be applied to Utterance

Rasa Core version:
rasa-core==0.12.2
Python version:
Python 3.6.6
Operating system (windows, osx, ...):
Ubuntu
Issue:
I was trying to debug why this is happening.
Problem occurs when I set slot from FormAction (RemoteAction) and that slot value needs to be set to template that Bot will utter in a single group of a sequence.
For example, the sequence would be like (a) Bot Utter (b) Set Slot
(a) Bot Utter template contains Slot that gets set in (b)
Module
action.RemoteAction.run
line#360 there is a line of code
events_json = response_data.get("events", [])
Its value looked like this:
{'events': [{'event': 'slot', 'name': 'distance_to_run', 'timestamp': None, 'value': '4'}, {'event': 'slot', 'name': 'requested_slot', 'timestamp': None, 'value': 'distance_to_run_confirmed'}], 'responses': [{'template': 'utter_ask_distance_to_run_confirmed'}]}

The slot value in events_json needed to be passed to
self._utter_responses(responses, dispatcher, tracker)

So I've changed the line to
self._utter_responses(responses, dispatcher, tracker, {e['name']: e['value'] for e in events_json if e['event'] == 'slot'})

and this new addl_slots are passed as additonal kwargs to dispatcher.nlg.generate
and was able to see desired result.
I'm thinking this is a bug... Please let me konw what you think.

Thanks for raising this issue, @Ghostvv  will get back to you about it soon.

Thank you for analyzing the problem. Please see this issue for a discussion: https://github.com/RasaHQ/rasa_core_sdk/issues/27.
We have not decide on the best approach to fix it yet. Please try tracker-updated-utterance branch of rasa_core_sdk, whether it fixes it.

Yes @Ghostvv , apply to the changes fixes. Until the change (or whatever the final change) is merged, I will overwrite the function on my custom form action. Thank you. I will close this now since other better described issue point to the same issue.


There is no inheritance of slots

@FragsterAt A little bit of description could be useful for future reference.

@CdTgr look at readme.md in pr #20 with this pr becomes possible to use standart quasar slots in q-input and q-select


backoffice: add identifiers to e-items

new field in create/update form
identifiers appear in the metadata detail panel
requires inveniosoftware/invenio-app-ils#914
closes inveniosoftware/invenio-app-ils#658

I noticed there was a bug with the scheme dropdown: the current value (as provided by the server) is not selected accordingly on the UI. Is there an open issue about this problem?


fix: apply 4992

Description
Back-porting of security fix in https://github.com/cosmos/ibc-go/pull/4992 into v4.5.x
Commit Message / Changelog Entry
fix: apply 4992

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md).
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Provide a commit message to be used for the changelog entry in the PR description for review.
[ ] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

@snobbee May I ask why you would need to fix back ported to v4.5.x? The extra length checking we added does not actually solve the root cause of the problem, as an attacker could create spam transactions by other means. Also this problem has not been categorised as a security vulnerability (it seems to be more of a mempool/protocol design issue), and given that v4.5. has actually reached end of life, we believe that we should not backport and release any improvements in that release line.

@snobbee May I ask why you would need to fix back ported to v4.5.x? The extra length checking we added does not actually solve the root cause of the problem, as an attacker could create spam transactions by other means. Also this problem has not been categorised as a security vulnerability (it seems to be more of a mempool/protocol design issue), and given that v4.5. has actually reached end of life, we believe that we should not backport and release any improvements in that release line.

@crodriguezvega I understand the points raised regarding the backporting to v4.5.x, and I agree that the extra length checking doesn't address the root cause of the issue. However, there are currently active chains, such as Osmosis and Sifchain, that are operating on v4.5.1.
These chains continue to experience the impact of spam attacks due to the lack of verification in the memo field. While it's true that attackers might use other methods, the proposed fix could mitigate the current known attack vector significantly.
By patching this within the ibc-go repository for the v4.5.x versions, we could provide these chains with an immediate improvement to their resilience against such attacks. It would serve as a stopgap solution until they can transition to a more robust solution that solved the issue at its core, when it gets available.
Given the circumstances, I believe it is beneficial to backport this fix, thus extending support to any other chains that still depend on this version. This could be a valuable measure to ensure the stability and security of the broader ecosystem during the transition period.
Would it be possible to reconsider the decision in light of this context?

@snobbee Thank you for your detailed reply and for giving your point of view. Unfortunately we discussed this internally and we do not think that this fix warrants to be back ported to a version that has reached End of Life. Please note that the EoL date for the v4 line had already been extended. Besides, this fix is state-machine breaking, so we actually cannot back port it to v4.5.x. And this also means that chains would require a coordinated upgrade.
As an alternative, wouldn't some of the mitigations recommended here be enough?
I will close the PR now.


can you add an option to export only the text?

can you add an option to export only the speech text? I don't want the timeline code.

If text_only be checked, the output file type will be txt.


force use image handler

The regexp test for the image handler prevents using an image url that does not have an image extension even if use {'handler':'image'} for the options.
i.e. I can't use images like https://lh3.googleusercontent.com/JT9YU8YgAur2EWr2-Ra1SFEqYjlqjH0q_GAimejTXK_hvxEEvymMsf1drGorDwsk9Js_Gf9H9ifCUOgUg3q-lhhk3w6FdnSg

Yes, good catch. I'm afraid this isn't possible at the moment. The handlers should be separated into a test() and handle() part so that handle() can be forced without checking the url.
I'm going to implement that for 2.0.


adding university official website URL: https://www.jinnah.edu/ and .txt file

Adding the university official website URL: https://www.jinnah.edu/ and .txt file
University Full Name
Mohammad Ali Jinnah University Karachi Pakistan

@uddinislam46 Please provide us with a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

@uddinislam46 You might miss my previous comment. Please react.

Hi @philipto ,
Thank you for contacting me. You can verify maju.edu.pk domain that I am submitting as an official email domain for the students of Muhammad Ali Jinnah University (MAJU) by contacting on the following email:
<EMAIL_ADDRESS>(Source: https://www.jinnah.edu/contact/)
Thanks & Regards,
Isalamuddin
<EMAIL_ADDRESS>

@uddinislam46 Pull request merged. Thank you!
FTR: proof of the domain ownership is at https://scholar.google.com/citations?user=UqgsZc4AAAAJ&hl=en

Great. Thanks, Sir @philipto 👍 💯 :)


Update http to https for world geocoding service

Update references to world geocoding service URLs from http to https. Identified in 'Find Place', 'Find Address' and 'Reverse Geocode Online' via a find in path search.
As per https://support.esri.com/en/technical-article/000023241
And further details in CS 2252.
@JonLavi
Checklist:

[x] Set target branch to master (current release) or dev (next release)
[x] Request a reviewer
[x] Assign a reviewer
[x] Tag reviewer in comment

I haven't looked closer into whether these https servers are already live. Were you able to run the samples ok with these changes?
Yes they all ran with the updated urls. Thanks @JonLavi !

@Rachael-E up next :)

Noted @Rachael-E thanks. Merging this for now....


Graph does not render when in_chart is set to false

Checklist

[x] I updated the card to the latest version available
[x] I cleared the cache of my browser
[x] I verified that I'm really running the latest version in my browser console
[x] I checked if there is another issue opened with the same problem

Describe the bug
After updating from version 2.0.4 to 2.1.0 the graphs do not render when one of the series has the in_chart set to false. I think it has something to do with this change.
https://github.com/RomRider/apexcharts-card/blob/2935b4efb73d67014b8043c369e089ce692dfc24/src/apex-layouts.ts#L192
Version of the card
Version: 2.1.0
To Reproduce
Create a chart where the value in_chart of one of the series is set to false.
type: custom:apexcharts-card
span:
  start: day
now:
  show: true
header:
  show: true
  show_states: true
  standard_format: true
all_series_config:
  type: column
  float_precision: 1
  stroke_width: 3
  show:
    legend_value: false
yaxis:
  - id: price
    decimals: 1
    max: '|+1|'
    min: '|-1|'
experimental:
  color_threshold: true
series:
  - entity: sensor.entso_e_average_electricity_price_today
    name: Price
    show:
      in_header: false
      extremas: true
    unit: ct
    color_threshold:
      - value: 18
        color: rgb(0, 255, 0)
      - value: 19
        color: rgb(107, 238, 0)
      - value: 20
        color: rgb(149, 219, 0)
      - value: 21
        color: rgb(176, 200, 0)
      - value: 22
        color: rgb(197, 180, 0)
      - value: 23
        color: rgb(215, 159, 0)
      - value: 24
        color: rgb(230, 135, 0)
      - value: 25
        color: rgb(244, 105, 0)
      - value: 26
        color: rgb(252, 71, 0)
      - value: 27
        color: rgb(255, 0, 0)
    yaxis_id: price
    data_generator: |
      return entity.attributes.prices.map((entry) => {
      return [new Date(entry.time), entry.price * 100];
      });
  - entity: sensor.entso_e_average_electricity_price_today
    name: Price (tomorrow)
    type: area
    offset: +1day
    extend_to: false
    curve: stepline
    show:
      in_header: false
      offset_in_name: false
    unit: ct
    yaxis_id: price
    data_generator: |
      return entity.attributes.prices.map((entry) => {
      return [new Date(entry.time), entry.price * 100];
      });
  - entity: sensor.entso_e_current_electricity_market_price
    name: Current
    show:
      in_chart: false
    unit: ct
    transform: return x * 100;
  - entity: sensor.entso_e_average_electricity_price_today
    name: Average
    show:
      in_chart: false
    unit: ct
    transform: return x * 100;
  - entity: sensor.entso_e_lowest_energy_price_today
    name: Min
    show:
      in_chart: false
    unit: ct
    transform: return x * 100;
  - entity: sensor.entso_e_highest_energy_price_today
    name: Max
    show:
      in_chart: false
    unit: ct
    transform: return x * 100;

Screenshots

On my test env, in_chart: false works. Can you please create the smallest example which fails for you, please ?

This is the smallest configuration I can make that doesn't work. If I remove the yaxis part or set in_chart to true it works correctly.
type: custom:apexcharts-card
yaxis:
  - id: cost
series:
  - entity: sensor.electricity_cost_per_day
  - entity: sensor.energy_usage_per_day
    show:
      in_chart: false

Ok, found the issue. Actually it was already an issue before but for some reason it did work with the previous apexchart.js library version 🤷


feat: add support for sortOption for all selection components

Description
Adds the support for a sortOrder property to all selectable components and not just Dropdown.
Related Issue(s)

closes #1599

Verification/QA

Manual functionality testing

[x] I have tested these changes manually
[ ] Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
[ ] No testing done/necessary

Automated tests

[x] Unit test(s) have been added/updated
[ ] Cypress E2E test(s) have been added/updated
[ ] No automatic tests are needed here (no functional changes/additions)
[ ] I want someone to help me make some tests

UU/WCAG (follow these guidelines until we have our own)

[ ] I have tested with a screen reader/keyboard navigation/automated wcag validator
[x] No testing done/necessary (no DOM/visual changes)
[ ] I want someone to help me perform accessibility testing

User documentation @ altinn-studio-docs

[ ] Has been added/updated

[x] No functionality has been changed/added, so no documentation is needed
[ ] I will do that later/have created an issue

Support in Altinn Studio

[ ] Issue(s) created for support in Studio

[x] This change/feature does not require any changes to Altinn Studio

Sprint board

[x] The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
[ ] I don't have permissions to do that, please help me out

Labels

[x] I have added a kind/* label to this PR for proper release notes grouping
[ ] I don't have permissions to add labels, please help me out

Percy fails with a bunch of new snapshots. This might be because I deployed a new version of frontend-test, and later rolled back to the old version. In any case, I don't think any of the screenshots are related to the code in this PR.

Alright. We have solved it with some backend-code as of right now, so we technically don't need this in v3

When testing this against the reasons radio list in frontend-test and adding language keys for one of the options there, it seems that:

The options are sorted according to their text resource key, not the actual label (I set the key to something beginning with z, so it always came last, even though the text resource value started with a)
The options don't always change according to the changing language (when using the language selector). I assume that problem wasn't introduced here.

https://github.com/Altinn/app-frontend-react/assets/700139/cced6a00-c7fb-4a67-9f5c-7e7726ff9501
I think we should add a Cypress test for this scenario, and fix the underlying issues with it. 🙏

Thanks for the thorough testing! I will add a cypress test for this case and fix the issue :smile:


Apply documentation suggestions to stationary wall boundary assignment.

Some suggestions could be applied to the stationary wall boundary assignment that was recently created.
          ```suggestion
    ht_correlation_type : str, optional
        The correlation type for the heat transfer coefficient. Options are
        "Natural Convection" and "Forced Convection". This parameter is
        relevant if ``ht_correlation=True``. The default is ``"Natural Convection"``.
    ht_correlation_fluid : str, optional
        Fluid for the correlation option. This parameter is relevant if
        ``ht_correlation=True``. The default is ``"air"``.
    ht_correlation_flow_type : str, optional
        Type of flow for the correlation option. This parameter
        is relevant if ``ht_correlation=True``. Options are ``"Turbulent"``
        and ``"Laminar"``. The default is ``"Turbulent"``.
    ht_correlation_flow_direction : str, optional
        Flow direction for the correlation option. This parameter is relevant if
        ``ht_correlation_type="Forced Convection"``. The default is ``"X"``.
    ht_correlation_value_type : str, optional
         Value type for the forced convection correlation option.
         This parameter is relevant if ``ht_correlation_type="Forced Convection"``.
         Options are "Average Values" and "Local Values". The default is
         ``"Average Values"``.
    ht_correlation_free_stream_velocity : str or float, optional
         Free stream flow velocity. This parameter is relevant if
         ``ht_correlation_type="Forced Convection"``. If a float value
         is specified, the default unit is ``m_per_sec``. The default is
         ``"1m_per_sec"``.
    ht_correlation_surface : str, optional
        Surface type for the natural convection correlation option.
        This parameter is relevant if ``ht_correlation_type="Natural Convection"``.
        Options are "Top", "Bottom", and "Vertical". The default is ``"Vertical"``.
    ht_correlation_amb_temperature : str or float, optional
        Ambient temperature for the natural convection correlation option.
        This parameter is relevant if ``ht_correlation_type="Natural Convection"``.
        If a float value is specified, the default unit is degrees Celsius.
        The default is ``"AmbientTemp"``.
    shell_conduction : bool, optional
        Whether to use the shell conduction option. The default is ``False``.
    ext_surf_rad : bool, optional
        Whether to use the external surface radiation option. This parameter
        is relevant if ``ext_condition="Heat Transfer Coefficient"``. The
        default is ``False``.
    ext_surf_rad_material : str, optional
        Surface material for the external surface radiation option. This parameter
        is relevant if ``ext_surf_rad=True``. The default is ``"Stainless-steel-cleaned"``.
    ext_surf_rad_ref_temp : str or float, optional
         Reference temperature for the external surface radiation option. This paramter
         is relevant if  ``ext_surf_rad=True``.  If a float value is specified, the default
         unit is degrees Celsius. The default is ``"AmbientTemp"``.
    ext_surf_rad_view_factor : str or float, optional
        View factor for the external surface radiation option. The default is ``"1"``.

_Originally posted by @PipKat in https://github.com/pyansys/pyaedt/pull/2290#discussion_r1071417409_

See #2290 to get the documentation suggestions from previous review.


fix(behavior_path_planner) not run pull out if out of lane

Description

not run pull out if ego is out of lane
fix shift  pull out lane departure check.

previously used current pose to end pose even if backward driving is need, so changed to using pull out start pose (= backward driving end pose) instead of current_pose

these changes fixed infinity backward driving behavior when putting ego out of lane.
Related links

TIER IV INTERNAL LINK
Tests performed

psim
if ego is out of lane, do not run pull_over but just lane_following.

Notes for reviewers

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kyoichi-sugahara
Could you please approve this as a code owner of lane_departure_checker?


pull request for e2e test at 01/27/2017 05:56:21

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[zh-cn]Update architecture/controller.md

Please also add the missing comment for the frontmatter (line 1 - line 5).

Please also add the missing comment for the frontmatter (line 1 - line 5).

It has been modified. Thanks

preview page： https://deploy-preview-37785--kubernetes-io-main-staging.netlify.app/zh-cn/docs/concepts/architecture/controller/
/lgtm
/approve


Create a Docker image for this project

Need to create a Dockerfile that at minimum:

[x] Installs nginx/apache
[x] Properly configures the server
[x] Pulls the git repo into the proper directory
[x] Installs npm dependencies and
[x] Puts www/ in a volume for easy editing

Would love for this to happen. +1

Nope, just focused on other things ATM. Should be closed with PR #22


Does Lookup guarantees the order?

https://github.com/GoogleCloudPlatform/dotnet-docs-samples/blob/master/datastore/api/TaskListTest/DatastoreTest.cs#L877
I don't think Lookup guarantees that the order of the result is the same as the given keys. Please close if it does, but please fix this otherwise.

Yes I think it re-order the result:
https://github.com/GoogleCloudPlatform/google-cloud-dotnet/blob/9c7b5f4c905e42217bce01e41dc069e1cc690c6d/apis/Google.Datastore.V1/Google.Datastore.V1/DatastoreDb.cs#L406


Slow Pash performance in for loop with echo

Reproduce:
# write the code below to gen.sh
##############################
mkdir tmp_folder
for i in {0..2335}
do
    touch tmp_folder/$i.log
done
##############################
# write the code below to the run.sh
##############################
for i in tmp_folder/*
do
    echo $i
done
##############################
# generate the files
bash gen.sh
# and then execute using run.sh script
$PASH_TOP/pa.sh run.sh

In my machine, bash needs 0m0,016s whereas pa.sh needs 1m19,493s
Branch: future
Kernel: Linux 5.0.0-37-generic #40~18.04.1-Ubuntu SMP x86_64 GNU/Linux
OS: Ubuntu 18.04.6 LTS (Bionic Beaver)
Machine: Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz

This is standard behavior. We have significantly improved the tight loop performance of PaSh but there are fundamental limits (the fact that every time we want to execute a command, we have to go through the process of compilation, reseting the state, etc. I am closing this issue for now since it is not a bug, and it cannot be addressed straightforwardly

Could I re-structure this script somehow (using for-loops) to gain better performance using pash?
Could you point me to these tight-loop examples that pash is compatible with?

By tight-loop performance improvement I meant that PaSh's performance has been improved in all loops in the last few months. However, it still cannot match the performance of plain bash in a loop of trivial commands since PaSh has to do a lot of stuff (e.g., state management) everytime it enters the body.

The only way to address this would be to not have loops with many iterations and trivial bodies.
FYI there are plans to add some additional optimizations that can help in this case, but still, the performance won't be like bash's.

Alright, thanks. @tammam1998 @nvasilakis maybe you should take a look at this since it affects directly all our benchmarks.


🚧 start implementing mongodb plugin

[ ] I adjusted the corresponding documentation for this change.
[ ] I adjusted the values.yaml file and the documentation for all values.

Codecov Report

Merging #431 (2e097ef) into main (f810912) will decrease coverage by 0.97%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
- Coverage   45.45%   44.47%   -0.98%
==========================================
  Files         139      141       +2
  Lines       11938    12199     +261
==========================================
  Hits         5426     5426
- Misses       6373     6634     +261
  Partials      139      139

Impacted Files
Coverage Δ

cmd/kobs/main.go
0.00% <0.00%> (ø)

plugins/plugin-jaeger/cmd/jaeger.go
18.40% <0.00%> (-0.12%)
:arrow_down:

plugins/plugin-jaeger/pkg/instance/instance.go
18.51% <0.00%> (-0.97%)
:arrow_down:

plugins/plugin-mongodb/cmd/mongodb.go
0.00% <0.00%> (ø)

plugins/plugin-mongodb/pkg/instance/instance.go
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Dataset download failed

I Open the training dataset for fully convolutional networks and the lables on dropbox. But the downloading failed everytime.

fixed now

fixed now


Enroll and Authentication reset state

When authentication fails, if the authentication function is triggered again, the process will not start again:

The same happens when Enrollment is completed or failed... right now it's necesary to reload the page to make it work again.

Hello,
The Short Answer:
You will need to call the  faceio.restartSession() method which let you perform another call to enroll() or authenticate() without reloading or refreshing the entire HTML page.
Refer to the method documentation at: https://faceio.net/integration-guide#restart_sess
The Long Answer:
The introduced restartSession() method let you purge the current user session and request a new one. By default, sessions in FACEIO starts following the first call to the enroll() or authenticate() method whichever comes first, and are immutable. After successful call to this method, the old session is discarded, a new one is created, and you can perform another round of calls to enroll() or authenticate() for the same user without reloading (refreshing) the entire HTML page or relying on an external JavaScript function such as location.reload() to do so.
Source: https://blog.pixlab.io/2022/10/fiojs-190-released-with-face-duplication-prevention

That made the trick


pipenv install does not use the system python3 and report another python3 version issue.

The following screenshot said my issue clearly.  I first run pipenv --rm to remove existing venv then pipenv install , pipenv chose 3.8 while I use 3.9. But an error pop up said it hit the error with 3.6.

pyenv_test ➤ pipenv --rm
Removing virtualenv (/Users/qiulang/.local/share/virtualenvs/pyenv_test-8P5GrENk)...
pyenv_test ➤ pipenv install
Creating a virtualenv for this project...
Pipfile: /Users/qiulang/Dev/tmp/pyenv_test/Pipfile
Using /Library/Frameworks/Python.framework/Versions/3.8/bin/python3.8 (3.8.6) to create virtualenv...
⠧ Creating virtual environment...created virtual environment CPython3.8.6.final.0-64 in 440ms
creator CPython3Posix(dest=/Users/qiulang/.local/share/virtualenvs/pyenv_test-8P5GrENk, clear=False, no_vcs_ignore=False, global=False)
seeder FromAppData(download=False, pip=bundle, setuptools=bundle, wheel=bundle, via=copy, app_data_dir=/Users/qiulang/Library/Application Support/virtualenv)
added seed packages: pip==20.2.4, setuptools==50.3.2, wheel==0.35.1
activators BashActivator,CShellActivator,FishActivator,PowerShellActivator,PythonActivator,XonshActivator
✔ Successfully created virtual environment!
Virtualenv location: /Users/qiulang/.local/share/virtualenvs/pyenv_test-8P5GrENk
Installing dependencies from Pipfile.lock (c9a7fb)...
🐍   ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 4/4 — 00:00:07
To activate this project's virtualenv, run pipenv shell.
Alternatively, run a command inside the virtualenv with pipenv run.
pyenv_test ➤ pipenv --venv
/Users/qiulang/.local/share/virtualenvs/pyenv_test-8P5GrENk
pyenv_test ➤ which python3
/Library/Frameworks/Python.framework/Versions/3.9/bin/python3
I opened (closed) an related issue https://github.com/pypa/pipenv/issues/4546
Thanks!

You must have python_version=3.8 in Pipfile, which is respected by Pipenv

You were right, I did have python_version=3.8 in Pipfile. After I changed it to 3.9 pipenv chose the system python 3.9
But that "python cannot be opened" warning still exist, only I delete all the venv in /Users/qiulang/.local/share/virtualenvs/ did that disappear.

If I keep other venv in /Users/qiulang/.local/share/virtualenvs/ , sometime it complained 3.5 error

Just clear all the invalid installations in the paths shown in the error message

But I don't have python 3.5 & 3.6 in my path now.
echo $PATH
/Users/qiulang/.rvm/gems/ruby-2.5.1/bin:/Users/qiulang/.rvm/gems/ruby-2.5.1@global/bin:/Users/qiulang/.rvm/rubies/ruby-2.5.1/bin:/Users/qiulang/.nodenv/shims:/Library/Frameworks/Python.framework/Versions/3.9/bin:/Library/Frameworks/Python.framework/Versions/3.8/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/sbin:/usr/local/go/bin:/Library/Apple/usr/bin:/Users/qiulang/.rvm/bin

@qiulang Do you still require support with this?

@matteius  thanks for reaching out but that was in 2020.  I have not used pipenv for a while so I will just close it.


Performance issues

I'm experiencing some performance errors in the console of the react-native debugger of the kind '[Violation] 'message' handler took XXXms'
where XXX gets up to 767ms.
The FlatList I am using contains many images. The messages occur after I release at the bottom, i.e. when the onRelease callback is called.
Does anyone else experience these problems?

could you please give a demo repo that can reproduce this issue?

I am also experiencing serious issues with performance. Will see if there is an improvement on release. Im on 0.43

Also, I dont know about others, but I wanted to use this library when I couldnt find a resource that allowed custom pull distance for the regular FlatList. I had to pull with several gestures to trigger the onRefresh.

@stokesbga Thanks for your reply and I will provide a example project about how to create custom indicator

https://gist.github.com/razor1895/2e755135af960752c164fad62f169ec9 here's the code will shows the same demo in the gif

Yes, I also noticed major performance when I try to wrap this with native-base components


rand_cta.cu functions have no documentation.

Stanley, when you get a chance, please document all the functions in
rand_cat.cu.  The other files have good docs, but not this one.

Not marking for Release 1.1 because it's not crucial.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 26 Jun 2009 at 5:01

Added Doxygen documentation to rand_cta functions and have verified that it
compiles
correctly with Doxygen.  Please check when you get a chance.

Original comment by<EMAIL_ADDRESS>on 26 Jun 2009 at 2:32

Changed state: Fixed

Original comment by<EMAIL_ADDRESS>on 28 Jun 2009 at 11:55

Changed state: Verified

Verified.  Excellent, thanks Stanley!

Original comment by<EMAIL_ADDRESS>on 28 Jun 2009 at 11:54


Change preview content height setting

Sets min-height rather than height and sets height to auto. This improves the preview look. Container will then never be smaller than textarea but will still adapt to the preview content height. Currently, as the height is hardwired, if the preview content is higher than the textarea, a scrollbar appears.

Thanks @AugierLe42e


[SMALLFIX] Reduce test flakiness

The test will fail if it times out before the third task throws its exception. Increase the timeout to 500ms to be safe. Not increasing it higher because the method always waits for the timeout to elapse before checking for exceptions

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/33/
Test FAILed.

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/34/
Test PASSed.


integrated eos-icons-react library

Integrated eos-icons-react library

[x] My code follows the code style of this project.
[x] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.

@mharshita one thing, can we also remove the eos-icons css if it is not being used anywhere? that will reduce the package size

@mharshita one thing, can we also remove the eos-icons css if it is not being used anywhere? that will reduce the package size

We cannot remove eos-icons css because of padding and margins

@mharshita one thing, can we also remove the eos-icons css if it is not being used anywhere? that will reduce the package size

We cannot remove eos-icons css because of padding and margins

what do you mean? i meant the font/css files which were being used for the icons. since we are using the react package now, those shouldnt be needed anymore right?

@mharshita one thing, can we also remove the eos-icons css if it is not being used anywhere? that will reduce the package size

We cannot remove eos-icons css because of padding and margins

what do you mean? i meant the font/css files which were being used for the icons. since we are using the react package now, those shouldnt be needed anymore right?

Oh, sorry. I got confused with eos-icons class in scss files😅.... I will remove the css files...


SAK-32295 Don’t fail attachments in peer review mode.

When an assignment is in peer review student review mode there is an option for the student to provide attachments for their review, however we were attempting to check these with content-review which isn’t correct (and was failing). So this check has been disabled when in peer review mode.

Closing as it's got linked to the wrong jira because my commit msg was wrong initially.

Created #4116 which is correctly linked 🤞


Shouldn't package.json define the license as MIT?

Or is it a better practice to leave it as unlicensed because this repo is not an npm package?

I don't think we care much about the license field in package.json, given that this is not a npm package, but a project. The license is already stated multiple times in the repo. But this could indeed be changed (I guess this unlicensed comes from the Flex recipe, which sets this license because most Symfony projects are not open-source).


chore: move npm targets to Makefile

We currently have various npm script target, and some of them are
getting complex enough that making sense out of them in package.json is
not a trivial task.
This commit moves all npm targets that are not directly recognisable by
npm (like start, test, preshrinkwrap, etc) into the Makefile.
Signed-off-by: Juan Cruz Viotti<EMAIL_ADDRESS>

Coool! :-D
I once considered suggesting exactly this quite a while ago, but I didn't because I thought you were too much of an NPM fan ;)  (and at the time, I wasn't aware of the node_modules/.bin/ 'trick').

...and on the topic of Makefiles, something I've been wondering recently is if there should also be a rule which deletes the node_modules and build folders? Something like a distclean (which would also depend on the clean rule) ?

@lurch I think you forgot you already took care of that yourself :P https://github.com/resin-io/etcher/blob/master/Makefile#L559

I'm merging this since I'd like to do some electron-builder work during the weekend, and I believe all comments were addressed. Please let me know if there was something else you wanted me to address and I'll send a future PR with it :)


remove unnecessary cast operator on date field

What type of PR is this：

[ ] bug
[ ] feature
[x] enhancement
[ ] others

Which issues of this PR fixes ：
To remove unnecessary cast operator on date field.
Problem Summary(Required) ：
Taks tpch/q05.sql for example,  the output explain verbose shows that
NON-PARTITION PREDICATES: 13: o_orderdate >= '1994-01-01', CAST(13: o_orderdate AS DATETIME) < '1995-01-01 00:00:00' |

If we could simplify predicates to

o_orderdate >= '1994-01-01'
o_orderdate < '1995-01-01

The backend execution engine has more opportunites to do optimization.
Right now, Hdfs scanner on ORC can use this simplified predicate to scan less data.
Another reason is that, many hive external tables are relying on date field as partition key..

A better implementation: https://github.com/StarRocks/starrocks/pull/3006/files


ci: track jjb jobs by a jjb/session= label

Describe what this PR does
By using a template, it becomes possible to identify the Pod that has
been started by the Batch Job.
This prevents the script from getting the logs from an incorrect (old)
container.
Related issues
Fixes: #1111

/test ci/centos/jjb-validate

/test ci/centos/jjb-validate

of course ci/centos/jjb-validate fails, because the checkout gets updated after this PR is merged

@Yuggupta27 please review

@Yuggupta27 approved, so adding the ready-to-merge label


forge's main branch is still called 'master'

Pre-flight checklist

[X] I have read the contribution documentation for this project.
[X] I agree to follow the code of conduct that this project uses.
[X] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem description
Should be 'main'
Proposed solution
Rename to 'main'
Alternatives considered
n/a
Additional information
No response

This has been fixed by https://github.com/electron/forge/pull/2946


Encrypt with python?

(Optional and Optional choice in RMMVCookTool)How about mixed encrypt some files with python(.pyd) and pyinstaller?

Could you please elaborate on what you'd like to do?

The Cook Tool compiles the JS files to binaries that NW.js understands. This is used for protecting the game's source code. Due to the compiler that the tool uses (nwjc.exe, included with the NW.js SDK), it does make the source code specific to the version of NW.js and the platform where the compiler ran (so, if you compiled it for Windows, the game's code will only run on Windows).

In my mind,I think it has two parts.First part is python part and second part is game(js) part.
(First think)Python part has the key which is encrypted.Game part has the way to decrypt.When player clicks the exe file(python),python part start connection with game part.Then python part send the key to game part.At last,the game part decrypt the key and start the game(if True).
(Second think)Same as first think.But python part has the way to decrypt.Game part has the key which is encrypted.
But these ideas are not mature.

In my mind,I think it has two parts.First part is python part and second part is game(js) part.
(First think)Python part has the key which is encrypted.Game part has the way to decrypt.When player clicks the exe file(python),python part start connection with game part.Then python part send the key to game part.At last,the game part decrypt the key and start the game(if True).
(Second think)Same as first think.But python part has the way to decrypt.Game part has the key which is encrypted.
But these ideas are not mature.

The Cook Tool compiles the JS files to binaries that NW.js understands. This is used for protecting the game's source code. Due to the compiler that the tool uses (nwjc.exe, included with the NW.js SDK), it does make the source code specific to the version of NW.js and the platform where the compiler ran (so, if you compiled it for Windows, the game's code will only run on Windows).

Can I compile them on Mac or Linux and have them run on these platforms?

The Cook Tool compiles the JS files to binaries that NW.js understands. This is used for protecting the game's source code. Due to the compiler that the tool uses (nwjc.exe, included with the NW.js SDK), it does make the source code specific to the version of NW.js and the platform where the compiler ran (so, if you compiled it for Windows, the game's code will only run on Windows).

Can I compile them on Mac or Linux and have them run on these platforms?

Yes. However, you'd need to use the Mac/Linux version of the NW.js SDK (alongside a compiled version of Cook Tool for said OS). In my case, I used WSL (Windows Subsystem for Linux), in order to create a Linux binary.

The Cook Tool compiles the JS files to binaries that NW.js understands. This is used for protecting the game's source code. Due to the compiler that the tool uses (nwjc.exe, included with the NW.js SDK), it does make the source code specific to the version of NW.js and the platform where the compiler ran (so, if you compiled it for Windows, the game's code will only run on Windows).

Can I compile them on Mac or Linux and have them run on these platforms?

Yes. However, you'd need to use the Mac/Linux version of the NW.js SDK (alongside a compiled version of Cook Tool for said OS). In my case, I used WSL (Windows Subsystem for Linux), in order to create a Linux binary.

Okay, I See.
At the same time, I found that pixel game maker mv and RMMV are the same company, and this game engine also has many similarities with RMMV, using JavaScript as the scripting language. Although it is very good, it is difficult to encrypt because it is an open folder. If it can be compiled, it will be usable. I am not sure if your tool can also be applied to it. If not, I hope you can add support for it. Many developers who use it will be very happy. Thank you.


chore: replace tsup with unjs/unbuild

It fixes #1137
Motivation and Resolution
Currently, the tsup build tool produces issues in build time when using re-exported same-named values and constants (companion pattern). TLDR: The build output is not correct, which results in correct types, but the constant cannot be recognized by a TS when using the starknet package out there.

[x] - Add unbuild and setup config
[x] - Update package.json exports
[x] - Remove tsup
[ ] - Check if jsdelivr and unpkg is needed (if yes make a workaround for that one)
[ ] - Check if browser export is needed

So, I introduced unjs/unbuild.
RPC version (if applicable)
7
Usage related changes
n.a
Development related changes

Replaced tsup with unjs/unbuild

Checklist:

[x] Performed a self-review of the code
[x] Rebased to the last commit of the target branch (or merged it into my branch)
[x] Linked the issues which this PR resolves
[ ] Documented the changes in code (API docs will be generated automatically)
[x] Updated the tests
[x] All tests are passing

Deprec


labels & classes in project "La déportation des Roms en Transnistrie" seem to be systematically missbehaving

It seems that after the kafka-toolbox update some stuff in the EHESS/Deportation project is not right anymore (or hiddenly never was).
The symptom to be observed easiest is, that many entities appear to be “zombies”, hence without label. This happened also in other projects, but there, it was few and to be resolved easily. Here, it seems more systematical problem.
Find below the results of my fast investigation. I hope this is helpful.

See the screenshot below of a person without label:

-> A short investigation shows that most likely this entity appears without label because the “Person appellation in a language”, which is label-defining, is not in the project (clicking on it I could add it, which I did not do). Also the external identifiers and the localization below behave the same way.
Checking more generally via the analysis tab, I find that likle no localization for example is within the project, all rows are empty:
The same is true for the archival references:

When it comes to identifiers, many persons show 2 identifiers of which only 1 is within the project, like this one:

In general, “only” 4008 of all persons have currently an identifier.:

Data changed

@gaetanmuck it generally looks good thanks! there are some 12 zombie "births", lets check them together today.

closing as done


Add notes on finding next PowerHour, simple Agenda.md

This adds an Agenda.md with a list of links to Agenda folders, as well as guidance on finding out when the next session is.  Might be overkill.
Could do more interesting things down the line, but this will help #37 for now

Once we have our first youtube link, we can add a column for the stream/video to the agenda, as well as each date's readme.  Will figure out a clean way to add this vs. manually.  Maybe...


Possible fix for issue #9

Thanks for your PR, @panta! I'll look into it soon. 👍

A bugfix for the problem you describe was provided in a329ba0017f0d40cb8c31cfe23b1219187a61e02.


stats  memory leak

stats update has memory leak
I was running my server and everytime stats was updating my server was freezing 2-3 sec while stats update and when I typed st cpu was high and ping too , I think that the stats after 1-2 days server running gets memory leak I hope you fix , tested with 2 servers the freezing while stats update I reported #111  it seems that the issue is with stats Current memory usage: 804.5/1161.5 mb

nice finding.
You can disable stats server with setting serverStatsPort = -1.

Server stats is really useless :/ You have an interval set there, setInterval(getStatsBind, this.config.serverStatsUpdate * 1000); Which is what runs in the background of the server, taking up memory because the interval repeats. No one checks the server stats... and I doubt many people port forward the server stats port so others can view it.

I check it :)

is there anyway to fix I dont wanna disable stats because on client we have live stats of server :/

You can disable stats server with setting serverStatsPort = -1.

I dont wanna disable stats because on client we have live stats of server

Oopsy, I read it wrong.

DAVID1ALI12 YOU CAN HELP ME FOR INSTALL OGARPLUS WITHOUT DOWNLOAD EXTENSION ? like agarlist.com please

Actually, there is no need for server stat if you're already connected to the server.
Just send byte 254 with interval 2-5 seconds and you will receive message 254 with server stat in JSON from server.
Here is how I'm using it to display server stat:
On client load:
    // Stat request
	setInterval(function () {
	    if (server.sendStatRequest) {
	        server.sendStatRequest();
	    }
	}, 5000);

On connect:
    server.sendChatMessage = sendChatMessage;
    server.sendStatRequest = sendStatRequest;

On disconnect:
    server.sendChatMessage = null;
    server.sendStatRequest = null;

On message:
			    case 254:
			        var buffer = [];
			        for (var i = curPointer; i < dataView.byteLength; i++) {
			            var value = dataView.getUint8(i, !0);
			            if (value == 0) break;
			            buffer.push(value);
			        }
			        var json = getStringFromUtf8(buffer);
			        var data = JSON.parse(json);
			        document.getElementById('statInfo').innerHTML =
                        "<center>" + data.name + "<b> | " + data.playersAlive + " / " + data.playersTotal + " / " + data.playersLimit + "  |  </b>" + data.mode + "</center>";
                                break;

getStringFromUtf8:
		function getStringFromUtf8(array) {
		    var out, i, len, c;
		    var char2, char3;
		    out = "";
		    len = array.length;
		    i = 0;
		    while (i < len) {
		        c = array[i++];
		        switch (c >> 4) {
		            case 0: case 1: case 2: case 3: case 4: case 5: case 6: case 7:
		                // 0xxxxxxx
		                out += String.fromCharCode(c);
		                break;
		            case 12: case 13:
		                // 110x xxxx   10xx xxxx
		                char2 = array[i++];
		                out += String.fromCharCode(((c & 0x1F) << 6) | (char2 & 0x3F));
		                break;
		            case 14:
		                // 1110 xxxx  10xx xxxx  10xx xxxx
		                char2 = array[i++];
		                char3 = array[i++];
		                out += String.fromCharCode(((c & 0x0F) << 12) |
                                       ((char2 & 0x3F) << 6) |
                                       ((char3 & 0x3F) << 0));
		                break;
		        }
		    }
		    return out;
		}

@David1ali12 DAVID1ALI12 usted me puede ayudar PARA INSTALAR EN MI OGARPLUS AGAR, Y SIN ampliación de la descarga? como agarlist.com favor

si skype:david12ali9

Uh... What's the status on this bug?

@SimonOrJ I think the only fix right now is to use what @Barbosik said of sending a request to the server to send back.
But doing that, won't it just have the same affect as having stats on but at different timings?


Chore: update

[x] Update README.md
[x] Set platformName: 'windows' in Karma IE11 config.
[x] Update devDependencies (karma, webpack)
[x] Apply<EMAIL_ADDRESS>and prettier

retest this please

retest this please


Nested State does not update the UI

Hi
I have an AppState and a nested MenuState.
Actions on the AppState trigger the reducer and that then triggers the UI to update.
Actions on the nested MenuState trigger the nested reducer BUT do not trigger the UI to update.
Is this a bug or am I doing something wrong?
If there is nothing obvious in my following code, would you be so kind and provide an example with a nested action and reducer that actually triggers an update using the flutter_built_redux StoreConnection?
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel dev, v0.5.4, on Microsoft Windows [Version 10.0.17134.112], locale en-NZ)
[√] Android toolchain - develop for Android devices (Android SDK 26.0.2)
[√] Android Studio (version 3.1)
[√] IntelliJ IDEA Community Edition (version 2017.3)

store
Store<AppState, AppStateBuilder, AppActions> createStore() {
  return new Store<AppState, AppStateBuilder, AppActions>(
    appReducerBuilder.build(),
    new AppState.loading(),
    new AppActions(),
    middleware: [
      createFirebaseMiddleware(),
    ],
  );
}

middleware
final Firestore firestore = Firestore.instance;

Middleware<AppState, AppStateBuilder, AppActions> createFirebaseMiddleware() {
  return (new MiddlewareBuilder<AppState, AppStateBuilder, AppActions>()
        ..add(AppActionsNames.connectFirestoreAction, connectFirestore))
      .build();
}

connectFirestore(MiddlewareApi<AppState, AppStateBuilder, AppActions> api,
    ActionHandler next, Action<Null> action) {
  firestore
      .collection("menus/P1N09rgDMAgc5u2KrIIT/items")
      .orderBy("sortOrder")
      .snapshots()
      .listen((QuerySnapshot snapshot) {
    BuiltList<MenuItem> menuItems =
        documentsToBuiltList<MenuItem>(snapshot.documents, MenuItem.serializer);
    api.actions.menu.menuItemsLoadedSuccessAction(menuItems);
  });
  next(action);
}

app_state
part 'app_state.g.dart';

abstract class AppState implements Built<AppState, AppStateBuilder> {
  static Serializer<AppState> get serializer => _$appStateSerializer;

  factory AppState([updates(AppStateBuilder b)]) = _$AppState;

  AppState._();

  MenuActions get menu;
}

menu_actions
part 'menu_actions.g.dart';

abstract class MenuActions extends ReduxActions {
  ActionDispatcher<BuiltList<MenuItem>> menuItemsLoadedSuccessAction;

  factory MenuActions() => new _$MenuActions();

  MenuActions._();
}

app_reducer
final appReducerBuilder = new ReducerBuilder<AppState, AppStateBuilder>()
  ..add(AppActionsNames.shopsLoadedSuccessAction, shopsLoadedSuccess)
  ..combineNested<MenuState, MenuStateBuilder>(menuReducerBuilder);

menu_reducer
final menuReducerBuilder =
    new NestedReducerBuilder<AppState, AppStateBuilder, MenuState, MenuStateBuilder>(
        (s) => s.menuState,
        (b) => b.menuState) // maps from the main state object to the nested state
      ..add(MenuActionsNames.menuItemsLoadedSuccessAction, menuItemsLoadedSuccess);

void menuItemsLoadedSuccess(MenuState state, Action<BuiltList<MenuItem>> action,
    MenuStateBuilder builder) {
  builder.menuItems.replace(action.payload);
}

menu_widget
class MenuWidget extends StatefulWidget {
  @override
  MenuWidgetState createState() => MenuWidgetState();
}

class MenuWidgetState extends State<MenuWidget>
    with SingleTickerProviderStateMixin {

// ...

  @override
  Widget build(BuildContext context) {
    return StoreConnection<AppState, AppActions, BuiltList<MenuItem>>(
        connect: (state) => state.menuState.menuItems,
        builder: (BuildContext context, BuiltList<MenuItem> menuItems,
            AppActions actions) {
          print(menuItems); // not printed when nested action triggers nested reducer :(
          return Scaffold(

// ...

            floatingActionButton: FloatingActionButton(
              child: Icon(Icons.control_point),
              onPressed: () {
                actions.connectFirestoreAction();
              },
            ),

// ...

Sorry for the late response, I'm sure you've given up or fixed it by now :P
But just in case you've been patiently waiting, I can try and help. Everything looks good to me tho, this sounds like a really weird issue. The only way i could see this happening is if

The list of items returned from firebase contains the same items already in your store, in that case no update will take place.
You do not have a StoreProvider as a parent in the widget tree

Seeing as you said updates from app trigger ui updates, i doubt 2 is true.
If 1 isn't true I would try just setting up a listener to the store and seeing if it triggers when your action is dispatched, just to make sure the store recognized the change.

I encountered a similar problem: As my app grew more complex at some point reducer calls stopped updating the app state (I added a listener to store changes to see this). I investigated further and figured out that everything works as expected when I dispatch a simple action with no reducer or middleware attached to it during start up; yet this can't be the final solution, so I tried to rebuild the app architecture in a simple prototype and added more tests. Currently all my tests are passing and the simplified prototype works as well, so I'm not able to reproduce the problem. In the meantime, I'm encountering the issue despite my small workaround in my prod code again.
Can you please tell me under which circumstances it might happen that store updates by a reducer are not reflected into the app state? I guess I'm using the api wrong somewhere in my code and this information would be helpful to find the right spot :)
A bit context information: I'm using async middlewares and epics in a flutter app along with built_redux.
I think my problem is related to this issue, but let me know if I should open a new one.


Update to use node-plex-api 2.0

Are you planning on updating this module to support the latest version of node-plex-api? Most notably you cannot use this module currently if your PMS requires authentication :(
(I've tried doing it myself, but I am banging my head against a brick wall regarding an exception being thrown inside the node.js core modules after I simply change the dependency to use the latest plex-api and running the mocha tests. I'm about ready to give up and just use node-plex-api without the handy control wrappers that this provides.)

Absolutely! I'll get a new major version out before the weekend.

I'm afraid I promised a bit too much here @OverloadUT :disappointed: Supporting plex-api v2.x was more work than I thought. And as I'm headed on a short vacation until friday next week now, I havent had time to finish the whole refactoring.
I'll continue ASAP and keep you updated.

No problem at all! The only client method I'm using in my project currently is the one you don't actually yet support: playMedia. It took a hell of a lot of trial and error to figure out how to get it to work. Once you get this up to 2.0 I will be happy to contribute what I figured out as an ext in this module :)

Sounds great! Looking forward to have playMedia support :)
On fre. 3. jul. 2015 at 22.13 Greg Laabs<EMAIL_ADDRESS>wrote:

No problem at all! The only client method I'm using in my project
currently is the one you don't actually yet support: playMedia. It took a
hell of a lot of trial and error to figure out how to get it to work. Once
you get this up to 2.0 I will be happy to contribute what I figured out as
an ext in this module :)
—
Reply to this email directly or view it on GitHub
https://github.com/phillipj/node-plex-control/issues/4#issuecomment-118419696
.

FYI I got alot further with this tonight. The XML to JSON convertion of tests and samples/fake responses are cumbersome. Will continue tomorrow evening.

Landed with b7741bf4be

Excellent! I will eventually migrate the playMedia stuff I have figured out in to this module. Still trying to figure out the exact gotchas, which are many!


Where can i find the corresponding paper?

I can't find the corresponding paper on google scholar.

Thanks for your interest. Our paper has been submitted to arxiv today and will be published soon.

Thanks for your interest. Our paper has been submitted to arxiv today and will be published soon.

ok, thanks for your reply!