[Event Request] Table 39 Purchase Line - field Amount Including VAT

Dear ALAppExtensions Team,
We would like to request the following change
field(30; "Amount Including VAT"; Decimal)
{
    AutoFormatExpression = "Currency Code";
    AutoFormatType = 1;
    Caption = 'Amount Including VAT';
    Editable = false;

    trigger OnValidate()
    begin
        GetPurchHeader();
        "Amount Including VAT" := Round("Amount Including VAT", Currency."Amount Rounding Precision");
        case "VAT Calculation Type" of
            "VAT Calculation Type"::"Normal VAT",
            "VAT Calculation Type"::"Reverse Charge VAT":
                begin
                    Amount :=
                      Round(
                        "Amount Including VAT" /
                        (1 + (1 - PurchHeader."VAT Base Discount %" / 100) * "VAT %" / 100),
                        Currency."Amount Rounding Precision");
                    "VAT Base Amount" :=
                      Round(Amount * (1 - PurchHeader."VAT Base Discount %" / 100), Currency."Amount Rounding Precision");
                    **//--> change request
                    OnAfterNormalVATCalculate(Rec, PurchHeader, Currency);
                    //<-- change request**
                end;
            "VAT Calculation Type"::"Full VAT":
                begin
                    Amount := 0;
                    "VAT Base Amount" := 0;
                end;
            "VAT Calculation Type"::"Sales Tax":
                begin
                    PurchHeader.TestField("VAT Base Discount %", 0);
                    if "Use Tax" then begin
                        Amount := "Amount Including VAT";
                        "VAT Base Amount" := Amount;
                    end else begin
                        Amount :=
                          Round(
                            SalesTaxCalculate.ReverseCalculateTax(
                              "Tax Area Code", "Tax Group Code", "Tax Liable", PurchHeader."Posting Date",
                              "Amount Including VAT", "Quantity (Base)", PurchHeader."Currency Factor"),
                            Currency."Amount Rounding Precision");
                        OnAfterSalesTaxCalculateReverse(Rec, PurchHeader, Currency);
                        "VAT Base Amount" := Amount;
                        if "VAT Base Amount" <> 0 then
                            "VAT %" :=
                              Round(100 * ("Amount Including VAT" - "VAT Base Amount") / "VAT Base Amount", 0.00001)
                        else
                            "VAT %" := 0;
                    end;
                end;
        end;

        InitOutstandingAmount();
        UpdateUnitCost();
    end;
}

[IntegrationEvent(false, false)]
local procedure OnAfterNormalVATCalculate(var PurchaseLine: Record "Purchase Line"; PurchaseHeader: Record "Purchase Header"; Currency: Record Currency)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 45914.


Negated pattern throws zsh: event not found: css/

This is probably specific to my setup somehow, but 🤷♂ .
$ cleancss --batch css/*.css !css/*.min.css
zsh: event not found: css/

Yep, a few minutes after publicly posting my issue, found the solution: always happens. 🤦♂
https://unix.stackexchange.com/questions/33339/cant-use-exclamation-mark-in-bash
$ cleancss --batch css/*.css '!css/*.min.css'

No worries, glad you did, and it'll hopefully help someone else!


opencdmsdb provider plugin

As an OpenCDMS core developer, I need an ORM implementation for OpenCDMS (e.g. /opencdms/provider/opencdmsdb/) so that I can use the OpenCDMS domain models (/opencdms/models/) with the default OpenCDMS database backend and not just with other supported CDMS databases.

Hey team! Please add your planning poker estimate with Zenhub @chinedu117 @david-i-berry @scottylad501

Implement acceptance tests as integration tests that are testing the implementation of the repository pattern


Add project file for carthage build to repository

Closes #17

@kevinrenskers any thoughts on this? :)


Update changelog.md for v3.1.0

Consolidated tweaks from https://github.com/mattermost/docs/pull/222 into a commit here because of merge conflicts.


Simplewarp php. (Small Change)

Grammar issues:

Make sure to check the warp if its incorrect

and

No warps are found.


Initial support for IP allocations scheduling constraint.

This PR adds initial support for being able to assign IPs allocated from the Titus VPC service to Titus jobs. It has an associated companion PR: https://github.com/Netflix/titus-api-definitions/pull/103. PR builds will fail until this is merged.
This PR does the following:

Adds IP allocations from the new Titus VPC service to the object model.
When present, IP allocations from the job are assigned to tasks as they are created or replaced. These assignments are represented as a new task context field.
A new scheduling constraint ensures that tasks with IP assignments are placed on hosts that are able to fulfill that assignment (currently only requiring a matching AZ).

The scheduling constraint leverages updates to the TaskCache that cache which IP allocations are already assigned. This cache is updating during assignment with a new SchedulingEventListener.
Tasks wanting to use an IP allocation that is already assigned to a running task wait for that task to finish and release the allocation.

Add integration tests for various scenarios.

This PR does NOT do the following, which will be in subsequent PRs:

Add a task context field to represent pending tasks that are waiting for the release of an assigned IP allocation.
Validate that the number of task instances is less than or equal to the job's number of IP allocations.
Update the agent proto passed to Mesos.

@andrew-leung I resolved some of the comments that I saw you addressed, and left some more open that are still being discussed


Questions about ComputeHistogram in autoflip

https://github.com/google/mediapipe/blob/master/mediapipe/examples/desktop/autoflip/calculators/shot_boundary_calculator.cc
`void ShotBoundaryCalculator::ComputeHistogram(const cv::Mat& image,
cv::Mat* image_histogram) {
cv::Mat equalized_image;
cv::cvtColor(image.clone(), equalized_image, cv::COLOR_RGB2GRAY);
double min, max;
cv::minMaxLoc(equalized_image, &min, &max);
if (options_.equalize_histogram()) {
cv::equalizeHist(equalized_image, equalized_image);
}
cv::calcHist(&image, 1, kHistogramChannels, cv::Mat(), *image_histogram, 2,
kHistogramBinNum, kHistogramRange, true, false);
}`

Three funcs, i.e. cvtColor, minMaxLoc and equalizeHist, seem no work in this function. Isn't as expected?
The kHistogramChannels of calcHist is set to {0, 1, 2}, but the dims of calcHist is 2. Why? Should the dims be set to 3?

Hi @YaqiLYU, I'd recommend you switch to the shot boundary detection calculator that uses the TransNetV2 model as shown here:
https://github.com/googleinterns/intern-for-design/tree/master/autoflip_integrated_calculators
This deep model based shot boundary detector has improved performance over the color histogram method linked above.
-Nathan Frey

Hi @YaqiLYU, Please go through the above comment.  Now we are closing this issue, Feel free to reopen if your query is relevant. Thanks!


Interploation of releases values from values/environment

I'm looking for a way to interpolate values for my releases inside helmfile from environment or values.
Background: I'm working on a prod/staging setup. I want to use the same helmfile for an application but deploy different versions on prod/staging. E.g. 1.2.3 and ~1.2.3.
Ideally I could write this:
helmfile.yaml
releases:
  - name: foo
    namespace: default
    chart: my/foo
    version: {{ .Values.Version }}
    values:
      - values/values.defaults.yaml.gotmpl
      - values/values.{{ .Environment.Name }}.yaml.gotmpl

values/values.production.yaml.gotmpl
Version: 1.2.3

values/values.staging.yaml.gotmpl
Version: ~1.2.3

This always results in error  ./helmfile.yaml: error during helmfile.yaml.part.0 parsing: template: stringTemplate:6:28: executing "stringTemplate" at <.Values.Version map has no entry for key "Version"
What kinda works:
helmfile.yaml
releases:
  - name: foo
    namespace: default
    chart: my/foo
{{ eq .Environment.Name "production" }}
    version: 1.2.3
{{ else }}
    version: ~1.2.3
{{ end }}
    values:
      - values/values.defaults.yaml.gotmpl
      - values/values.{{ .Environment.Name }}.yaml.gotmpl

but this gets messy very quickly with more than 2 envs.
Any idea how to do this or am I trying it the wrong way?
I also checked https://github.com/roboll/helmfile/issues/36 and https://github.com/roboll/helmfile/issues/86 and https://github.com/roboll/helmfile/pull/90 and https://github.com/roboll/helmfile/pull/87 which all seem related but still differently

Hey folks - is there a solution for this? I'm in exactly the same situation where I would like to describe a set of environments with different versions. Ideally, in each environment I'd maintain a versions file with a simple :  type layout with I can then refer to in the Helmfile.yaml

@soupdiver @mikeduffy11fs Hey! Sorry but I'm still not sure what you are trying to achieve here.
Does the version number really need to be defined within helm values, rather than helmfile values?
In other words, does this work for you?
values:
- someApp:
    version: "1.2.3"

environments:
  prod:
    values:
    - someApp:
        version: 1.2.2
  dev:
    values:
    - someApp:
        version: 1.2.4

releases:
  - name: foo
    namespace: default
    chart: my/foo
    # This version number results in 1.2.4. for `helmfile -e dev`  and 1.2.2 for `helmfile -e prod`, and 1.2.3 without `-e`
    version: {{ .Values.someApp.version }}

We are doing this exactly the same way as @mumoshu just pointed out.
We define app versions using the environment values, not in chart values. Works like a charm.

We are doing this exactly the same way as @mumoshu just pointed out.
We define app versions using the environment values, not in chart values. Works like a charm.

gonna check it out that way around


Features should be documented elsewhere too

slog has two types of impactful features (they may cause messages to not be displayed in released binary executables). These are only documented for slog_stdlog. I propose to document them in the API docs for slog and to refer to this section from other crates.

https://docs.rs/slog/2.0.5/slog/#notable-details

Thanks! Two issues though made this harder to find though.

release_max_level_warn cannot be found using the search bar at the top of the docs.
The heading ‘Notable details’ is aspecific and abstract. A (bigger) heading ‘Features’ is a better choice IMO. The preceding heading about ‘features’ can be renamed ‘Functionality and related crates’ (and should perhaps not be in the API docs in its current shape, since it mixes promotion and description).

From my experience: not many people actually read documentation from end to end anyway. The whole thing is a gotcha, unfortunately, and I encourage users to ask questions on gitter channel. :)
Maybe when compiling with the defaults a warning/notice should be printed so users have to set their own compile time logging level if they want to avoid it... . But then they will mind additional work.
Anyway, I'm always for docs improvements, but it's always similar story: people have different needs, approaches, read different parts. I don't want to be moving things back and forth and generally would like everything to be on docs.rs ("advertisement", functionality, examples, whatever).
I am open to renaming sections / improving structure though. Feel free to submit a PR. :)


Save the access mode when creating backup, for restoring from the backup

Issue #3444
Signed-off-by: Ray Chang<EMAIL_ADDRESS>Enhancement

When create backup, save the access mode into backup label
When restore backup, if the access mode is empty then use the backup label to create new volume.

Self-testing

Create two volumes: ReadWriteOnce (RWO) * 1 + ReadWriteMany (RWX) * 1, and both are attached to one node.
![image](https1. Create two volumes: ReadWriteOnce (RWO) * 1 + ReadWriteMany (RWX) * 1, and both are attached to one node.

Create backups for each volumes.

Wait all backups are complete, then delete all volumes.
Switch to `Backup' page, and click the backup name and the tags filed.
CHECK: The LonghornVolumeAccessMode of backup labels should be equal as the access mode.

Select all backups and click Restore Latest Backup button

DON'T fill in any filed and click OK button.
Switch back to Volume page and click the name filed.
CHECK: The access mode should be same as the volume's backup.

ReadWriteOnece

ReadWriteMany
://user-images.githubusercontent.com/17548901/187202524-568df547-f571-46d7-be32-3a58ed8dc32f.png)

Create backups for each volumes.

Wait all backups are complete, then delete all volumes.
Switch to `Backup' page, and click the backup name and the tags filed.
CHECK: The LonghornVolumeAccessMode of backup labels should be equal as the access mode.

Select all backups and click Restore Latest Backup button

DON'T fill in any filed and click OK button.
Switch back to Volume page and click the name filed.
CHECK: The access mode should be same as the volume's backup.

ReadWriteOnece

ReadWriteMany

Can you also add the longhorn issue number to the commit message?

Do we need to add the label to the backup CRs during upgrade or in the mutation webhook?

Can you also add the longhorn issue number to the commit message?

Suggest having the issue number in the commit message instead. The linked issue is likely to flood with the commit notices when putting a link in the commit message.

In general, LGTM.
Suggest reorganizing the two commits. Some commented codes and changes make the commits somewhat messy.


timeout=0 doesn´t work in new version?

As one of my inverters is connected to L2i had problems with the shown AC-loads / dbus-mqtt reports them as L1
I saw there is a new version now that reflects that problem
But there must be a bug
i have timeout=0
Directly after i start the program i get:
INFO:root:MQTT client: Connecting to broker <IP_ADDRESS> on port 1883 INFO:root:Waiting 5 seconds for receiving first data... INFO:root:MQTT client: Connected to MQTT broker! ERROR:root:Driver stopped. Timeout of 0 seconds exceeded, since no new MQTT message was received in this time. root@raspberrypi2:/data/etc/dbus-mqtt-pv3#

The timeout = 0 is only working, if the driver is already running. If the driver has no data it cannot start and is trying to start until he gets some data.


Add ESLint plugin for Testing Library

Add eslint-plugin-testing-library to improve tests.

Fixed by #405


clarification about Stream::into_future()

I had been confused about why the Stream::into_future() used Option. This patch adds a sentence to the documentation to clarify.

Thanks!


Fixed installation guide links for mssql-cli

Docs were moved to a README, which broke installation links on the docs site.

@ellbosch : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thank you, @ellbosch
Changes approved!


Fix: fix variable description for var.use_fullname, run make github/init

what

Fix variable description for var.use_fullname.
Run make github/init.

why

The var.use_fullname variable description is incorrect and refers to ECR repositories instead of IAM roles.
Running make github/init will update GHA-workflow related files (and CODEOWNERS), the former of which is required for the no-release label (which allows for consolidating multiple small PRs such as this into one release).

references

N/A

/test all


@auth transform not correct

Describe the bug
Using "amplify add api":
$ amplify add api
? Please select from one of the below mentioned services GraphQL
? Provide API name: notes
? Choose an authorization type for the API Amazon Cognito User Pool
Use a Cognito user pool configured as a part of this project
? Do you have an annotated GraphQL schema? No
? Do you want a guided schema creation? true
? What best describes your project:
? What best describes your project: Objects with fine-grained access control (e.g., a proj
ect management app with owner-based authorization)
? Do you want to edit the schema now? (Y/n)
? Do you want to edit the schema now? Yes
? Press enter to continue

Using the following schema:
type Note
    @model
    @auth(rules: [{
		allow: owner,
		ownerField: "userId",
		identityField: "sub",
		mutations: [create, update, delete],
		queries: [get, list]
	}]) {
   id: ID!
   note: String!
}

This is the output of amplify/backend/api/notes/build/resolvers/Query.getNote.request
{
  "version": "2017-02-28",
  "operation": "GetItem",
  "key": {
      "id": $util.dynamodb.toDynamoDBJson($ctx.args.id)
  }
}

The bug is there is no code in the resolver to check for owner as allow owner only.
Desktop (please complete the following information):
macOS
$ amplify --version
0.1.19

The authorization check for the getItem resolver happens in the response mapping template. Please look at Query.getNote.response.

@mikeparisstuff can't we use Query with FilterExpression instead of GetItem? DynamoDB tutorials I read normally is using the Query method, letting the database doing the guard rather than when data is retrieved out. Kind of waste of bandwidth by pulling the data out to do checking.

@jaxondu  Are you still blocked?

@kaustavghosh06 blocked? The latest version CLI seems to work fine with my simple testing. The question I posted above is nick picking on the way the code is structured. Does not seem like a best practice the way you retrieve all data out and do the checking. You can close this case if it is acceptable to you.

This is a good point. We can change the transform to always use Query operations instead of GetItem even when getting an item with a unique key as a slight optimization assuming this does not impact the latency of the call in DynamoDB. This isn't a bug and sounds like a lower priority issue but it has been added to the backlog.


bpf: switch egress gateway logic to identity_is_cluster()

See individual commits.
Fixes: https://github.com/cilium/cilium/issues/19784

/test

/test-1.23-net-next

/test-1.16-4.9

/test-runtime

/test-1.16-4.9

/test-1.23-net-next

/mlh new-flake Cilium-PR-K8s-1.16-kernel-4.9

@jibi Think this PR added the test and the changes necessary for it to pass. Might just need a rebase

We'll want to backport the docs fix so best to move it to its own PR.

We'll want to backport the docs fix so best to move it to its own PR.

Good shout, I'll keep everything here while I finish drafting the PR, then I'll do the split

/test

/test-1.16-4.9

Filled https://github.com/cilium/cilium/issues/20288 for the K8sVerifier flake

/test

All required tests are green (AKS, GKE and multicluster workflows are disabled), marking as ready


feat: concurrent handling w/ seda

Use asynchronous SEDA queue with concurrent consumers (6).
EVNT-791

Superseded by #120


Removing the yiisoft/yii-core dependency

Here are the current issues with the log packages, preventing them from being used outside of Yii:
yiisoft/log
The package currently depends on yii-core for the following reasons:
\Yii\Log\LogRuntimeException

Extends yii\exceptions\Exception

\Yii\Log\Logger

Uses yii\base\ErrorHandler::convertExceptionToString() to format dispatch failure exception.
Uses YII_BEGIN_TIME constant (it is defined in yii-core/config/defines.php)
Uses yii\helpers\VarDumper but checks for availability.

\Yii\Log\LoggerTarget
Uses yii\exceptions\InvalidConfigException
\Yii\Log\Target

Extends yii\base\Component
Uses YII_BEGIN_TIME
Uses yii\helpers\VarDumper
Uses yii\helpers\ArrayHelper
Uses yii\helpers\StringHelper

yiisoft/log-target-db

Uses yii\exceptions\InvalidConfigException
Uses yii\helpers\VarDumper

yiisoft/log-target-email

Uses yii\mail\MailerInterface
Uses yii\mail\MessageInterface
Uses yii\di\AbstractContainer to configure the Message
Uses yii\exceptions\InvalidConfigException

yiisoft/log-target-file

Uses yii\helpers\FileHelper to create a directory
Uses yii\exceptions\InvalidConfigException
Uses yii\helpers\Yii to resolve aliases

yiisoft/log-target-syslog
Nothing :tada:

Proposals:
exceptions:
Libraries should define their own base exception class, extending from \Exception.
Libraries should define all the exceptions they thrown (unless it's from a required package).
(i.e. \Yii\Log\Exceptions\InvalidConfigException extends \Yii\Log\Exceptions\Exception extends \Exception)
Furthermore, I'd like to rename \Yii\Log\LogRuntimeException to \Yii\Log\Exceptions\RuntimeException (and adopt this folder for other packages)
helpers:
We need to extracts our helpers into yiisoft/helpers.
YII_BEGIN_TIME:
The application start time should be provided in Logger::__construct()
Questions
yii vs non-yii:
Should log-target-file try to resolve aliases when it detects Yii, and skip that otherwise?

Libraries should define their own base exception class, extending from \Exception.

It is better to extend exception from \RuntimeException, not from \Exception in this case.

We need to extracts our helpers into yiisoft/helpers.

I think that having all helpers in a single package isn't good. Having multiple packages would make more sense.

Should log-target-file try to resolve aliases when it detects Yii, and skip that otherwise?

No.

Created two repos:

https://github.com/yiisoft/string
https://github.com/yiisoft/array


add UpdateFile

closes #8

Codecov Report

Merging #24 into master will decrease coverage by 0.6%.
The diff coverage is 69.56%.

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   74.37%   73.77%   -0.61%
==========================================
  Files           3        4       +1
  Lines         160      183      +23
==========================================
+ Hits          119      135      +16
- Misses         23       27       +4
- Partials       18       21       +3

Impacted Files
Coverage Δ

file.go
69.56% <69.56%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fe00e4...e18851c. Read the comment docs.


[1.0 patch] .NET 4.7x Framework pages are started with Workstation GC

See #73

Discussed with @DamianEdwards and this is not worth patching for 1.x.


How to make the whole panel https?

How would i go around making the panel https, deamon keeps throwing error when i do so?

https://docs.mcsmanager.com/#/tutorial/reverse-proxy-ssl
Maybe this will help you, good luck.

am i doing this wrong?

when i go to api.karasu.live i can see my demon
it doesnt respond on wss://api.karasu.live or wss:/api.karasu.live:24444

proxy port 24444 whit websocket
location ^~ /
{
    proxy_pass http://<IP_ADDRESS>:24444;
    proxy_set_header Host $host;
    proxy_set_header X-Real-IP $remote_addr;
    proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
    proxy_set_header REMOTE-HOST $remote_addr;
    proxy_set_header Upgrade $http_upgrade;
    proxy_set_header Connection $connection_upgrade;
    proxy_http_version 1.1;
    # proxy_hide_header Upgrade;
}

Then you shoud set address is wss://you.domain,  port is proxy port in mcsmanager

adding that to custom location made it offline on the proxy

can you explain a bit deeper?

Since you can access https://api.karasu.live normally, but cannot access wws://api.karasu.live, it proves that you have a little problem with the websocket configuration.
Please refer to here, support for Websocket + SSL.
https://docs.mcsmanager.com/#/tutorial/simple-reverse-proxy
Everyone's network environment is somewhat different. We cannot adopt a solution that is suitable for all network environments. Most of them may only be tried and solved by yourself.

I don't understand why i cannot access wss://api.karasu.live:8443
The demon is on 24444 its reverse proxied to 8443 it still doesnt work
Its accessible from api.karasu.live but not wss://api.karasu.live:8443

我也是遇到同样的问题，用https能访问到远程节点，但在面板用wss就不通了

发现面板只能用localhost的24444端口连接到节点，nginx把节点的端口映射到别的都不行

我也是遇到同样的问题，用https能访问到远程节点，但在面板用wss就不通了

did  you find a fix?

Reverse proxy the daemon to https://panel.karasu.live:24444 and make sure you can access this URL from your browser. Then add localhost:24444 as a daemon in the MCSM panel.
把守护进程反向代理到https://panel.karasu.live:24444，并确认能从浏览器访问这个网址。然后在MCSM面板添加localhost:24444作为守护进程。

does your proxy work properly? maybe you have only proxied https but not wss. you can test your websocket on online websocket tester (like piesocket).

How do i proxy the wss?

Reverse proxy the daemon to https://panel.karasu.live:24444 and make sure you can access this URL from your browser. Then add localhost:24444 as a daemon in the MCSM panel.
把守护进程反向代理到https://panel.karasu.live:24444，并确认能从浏览器访问这个网址。然后在MCSM面板添加localhost:24444作为守护进程。

this didnt work, panel is accessible the https://panel.karasu.live:24444 shows the deamon but it cant connect using https it because ssl doesnt allow ports in url

`proxy_hide_header Upgrade;
proxy_hide_header X-Powered-By;
add_header Content-Security-Policy "upgrade-insecure-requests";
add_header X-Frame-Options "SAMEORIGIN";
add_header X-XSS-Protection "1; mode=block" always;
add_header X-Content-Type-Options "nosniff" always;
add_header Cache-Control "no-transform" always;
add_header Referrer-Policy no-referrer always;
add_header X-Robots-Tag none;
location @ws {
proxy_pass http://localhost:24444;
proxy_set_header Host $http_host;
proxy_read_timeout     60;
proxy_connect_timeout  60;
proxy_redirect         off;
proxy_http_version 1.1;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection 'upgrade';
proxy_set_header Host $host;
proxy_cache_bypass $http_upgrade;
}`

I'm facing the same issue, I can access the daemon if I request it directly through https, but I can set the panel to use https, if I use wss://my.domai it simply sends the request to the panel port, instead of using the daemon port I provided.
But, if I remove the "wss://" it actually sends the request to the port, but it does it through http, and the connection fails

in both cases the port is set to 8080 (proxy port) in the panel

Any solutions?

Not really, I resigned to follow the marvelous recommendation of keep it insecure

(Translate by fanyi.baidu.com)
Although I haven't translated it into English yet, I think you might try to refer to it
https://github.com/bddjr/nginx-proxy-docs-for-mcsm/blob/master/配置HTTPS反向代理.md


fix some typo error

fix some typo error
fix readme Installation url

Thanks for the fixes!
/approve


Centralized Documentation Repo/Site

@kazk I had it slated for this sprint to focus on this, but I may have to push this off to the first week of August since I'm dealing with a possible CR server refactor (due to some issues that are popping up), and I am mostly out next week for a business trip with limited availability.
I did do a deeper look into the Jekyll implementation and the big question I have is can we implement search functionality and still support automatic deployments? Doing some research it seems Jekyll with Github pages only works if you don't use plugins.
If it ends up being the case where we can't use Github auto-deployments due to needing additional functionality, then we may want to look into (Metalsmith)[http://www.metalsmith.io/].
The main items for me to work through as the next steps are:

[ ] finalize content structure
[ ] homepage and article design

can we implement search functionality and still support automatic deployments?

We can, by generating data to be used by client side library.
Current search functionality depends on the data in docs/assets/data.json.txt which is populated automatically and performed by lunr.js.
I haven't compared the functionality or the efficiency against Jekyll plugins.

Jekyll with Github pages only works if you don't use plugins.

In the current setup, we can't use Jekyll plugins that's not in the GitHub's whitelist. We can avoid this limitation by setting up some external service to do the automatic deployments though (just use GitHub Pages as hosting service). If we're doing that, using other static site generators like Metalsmith is an option too.
I tried to make things simple because I wasn't sure what we wanted. So existing content should be able to adapt to other tools if we want. I don't think I used any of the whitelisted plugins or any JavaScript except for the search.

Closing because we'll be using wiki for now. We'll do something about this later.


Operators under same namespace and avoid resource name collision

AC

[x] All deployed operators under namespace kcp-system
[x] Avoid resource name collision by provide unique namePrefix in each operator repo.

[x]  lifecycle-manager with namePrefix  lifecycle-manager- https://github.com/kyma-project/lifecycle-manager/pull/139

[x] module-manager with namePrefix module-manager-
❌   watcher-operator with namePrefix watcher-operator-
[x]  Write guide about how to do this changes in template operator doc. https://github.com/kyma-project/lifecycle-manager/pull/172

closing as all prefixes are set and all labels corrected


Update Authentication.yaml with Password Complexity Restrictions

Passwords should require 1 capital letter, 1 number, and 1 symbol.

Thank you for the suggestion. In the current Digital Standard, we evaluate if the authentication system force user to set up a complex password. "1 capital letter, 1 number, and 1 symbol" could be one kind of situation met the requirement. So, it is overlap with another indicator. @billfitzg  @mrerecich


Fix status calculation

Return checksum only if local item exists
During investigation of "Reset package name" https://github.com/larshp/abapGit/issues/2264, I found that the status calculation doesn't work correctly if

object existed before, was deleted, and then should be recreated (via pull or reset local for example)
object existed in another branch but not in the current branch
object had been deleted in another session

Root cause was that the local checksum still existed which made the status calculation incorrectly 'believe' the object was still there (due to the same checksum as remote).
I created a new test case https://github.com/abapGit-tests/DEVC_main_sub with two branches. Master contains MAIN and 1 sub-package. Branch "feature" contains 2 sub-packages.
This PR not only fixes #2264 but potentially several other open issues related to checksums and switching branches:
Branch created with no changes identified
https://github.com/larshp/abapGit/issues/3258
REFRESH_LOCAL_CHECKSUMS regression?
https://github.com/larshp/abapGit/issues/2086
Branching can cause changes to be flipped
https://github.com/larshp/abapGit/issues/2869
@christianguenter2, @7qiang, @sbcgua, @flaiker, @FreHu  please test.

Unforunately does not resolve #2869.


Genes disappear from LD plot at certain plot widths

@ljwh2 commented on Mon Mar 02 2020
Daniel reported a bug with the LD plot. Genes that are visible in the 50kbp window disappear in the 25 and sometimes 200kbp window (genes displayed in track "Ensembl genes", below the plot; plot width changed using the drop-down on top right of the plot). I replicated the behaviour with a couple of other variants. As Daniel observes, it seems to occur when the gene is larger than the initial plot width:
https://www.ebi.ac.uk/gwas/variants/rs6466479
https://www.ebi.ac.uk/gwas/variants/rs45446698
but not
https://www.ebi.ac.uk/gwas/variants/rs7412
This is misleading for users and needs fixing so the genes are visible at all window sizes.
Original GWAS-info email:
I wanted to show off with the LD plot and I have bumped into a bug. Check out this variant: https://www.ebi.ac.uk/gwas/variants/rs35407685
This variant is an intron variant (https://www.ensembl.org/Homo_sapiens/Variation/Mappings?db=core;r=7:140785945-140786947;v=rs35407685;vdb=variation;vf=20866875) overlapping with BRAF. When the LD plot is loaded the BRAF gene on the reverse strand is correctly displayed (50kb window by default). However it disappears when the window size is decreased to 25kb, and when you try to change back to 50kb it still not shown, only when the largest 500kbp window is selected.
I think when the plot is updated only those genes are shown, whose start and end coordinates are both included within the window. So I suspect the fix could not be too complicated.
Please take a look and verify if this indeed not the expected behavior.

Ugh. I've been watching what's going on and I think I've got an idea. When the plot_width changes, it needs to reload the data. I think this is block of code causing the problem:
`
var preloadedData = self.getPreloadedData('gene');
  if(preloadedData){

    if(self.configuration.region_width == '500'){
      self.data.four = preloadedData;
      return;
    }

    self.data.four = preloadedData.filter( entry => {
      return self.data.left < entry.start && entry.end < self.data.right;
    })
    return;
  }

That's saying 'if there is preloaded data, check against the region_size. If the region_size is 500, return all the data. Else, only return the data contained in the region. Like Daniel thought, this is cutting out genes that aren't contained in the region window. Changing
return self.data.left < entry.start && entry.end < self.data.right;
to
return self.data.left < entry.start || entry.end < self.data.right;
`
should return any related genes.
sending this to Daniel for investigation.

@jstewart-ebi that's right! If either the self.data.left < entry.start or  entry.end < self.data.right are true, the feature will not be displayed. So if the gene start or the end is outside the window, the gene will not be shown. This might effect a great handful of genes (depending on the window size).
What I find interesting though is that the initial loading of the page works... It only fails when the page is reloaded. Strange.
We rather need something like this (you can easily try if it works):
self.data.left < entry.end  && entry.start < self.data.right

But I'm quite sure the guy will fix it in no time.

There may be another bug with the way the data is loaded. In that same block of code, if there's no  preloadedData, it queries the /overlap/region endpoint, but uses data.left and data.right, not data.maxLeft and data.maxRight, so the preloaded data will only be a 200kb region, not a 500kb one.

Well that's interesting. Do they have the repo on github somewhere?

I'm not sure. There is an Ensembl repo for widgets https://github.com/Ensembl/public-plugins, but I can't find the LDPlot.full.js file in the Ensembl repo.

Hello @jstewart-ebi  & @daniwelter, thank you reporting this issue and investigating this further.
I have now updated the condition to the following and pushed it live:
self.data.left < entry.end && entry.start < self.data.right;

There may be another bug with the way the data is loaded. In that same block of code, if there's no preloadedData, it queries the /overlap/region endpoint, but uses data.left and data.right, not data.maxLeft and data.maxRight, so the preloaded data will only be a 200kb region, not a 500kb one.

The way it works is that it first loads the data for the initial value selected  in the plot width drop down  (50Kb for example) and uses it to draw the UI. Simultaneously, it also sends another request in the background to preload the data for 500Kb which is just to make the transition pretty instant when we increase the size from 50Kb to 200Kb or 500Kb, instead of having to wait longer.
OTOH if you already have 500Kb selected during the initial load, it would mean that data.left = data.maxLeft & data.right = data.maxRight, in which case the second request not made.
I hope that makes sense. Please let us know if you come across any other issues.
Kind regards,
Manoj

Fixed by Ensembl.


📱 mobile phone gameplay: thumbstick and thumblook mechanic

we need to build a good virtual thumbstick for mobile users.
thumbstick

[x] we want to build a modern replacement for nipplejs https://yoannmoi.net/nipplejs/
[x] we want to place the thumbstick in the lower-left corner, and use it as player movement input (in addition to wasd)
[x] we want the thumbstick to work based on touch events on mobile, but it should also be usable by desktop users via clicking and dragging
[ ] we need an in-game interface for toggling the mobile controls (turning the thumbstick on or off)

thumblook

[ ] instead of having a right thumbstick, we want the user to touch-and-drag anywhere on the right side of the screen to initiate "looking", where they press and drag around to control their aim direction
[ ] similarly, we want desktop users to emulate this action with their mouse by clicking and dragging when the mobile controls are on

user experience

[ ] the user needs some in-game interface for toggling the mobile controls
[ ] when the mobile controls are activated, the pointer lock system should deactivate

woohoo, this is done in d80fcadfc5c777d8b427ee772aeabcf1b03ebb27
we'll save further improvements, like thumblook system (without sticks), and disabling mobile controls, for future tickets


This software is removed if I shutdown the Sagemaker Studio instance and then restart it

This software does not appear to survive a shutdown-restart cycle. The sidebar tool disappears and I need to run install_tarball.sh again. Is there a way to make it presistent?

As the extension needs to be installed on top of a running Jupyter server container, currently there is no way to avoid the reinstallation after the restart of the "default" application. This is currently a limitation of SageMaker Studio and not the extension. However, hopefully we will be able to solve this issue soon either by adding this extension to the Jupyer server image directly or leverage some future Studio capabilities which would allow to install extensions "permanently".


ADD PATIENT: Integration testing of new patient / case creation

Create an end to end integration test of logging in and creating and saving a new patient and case from a call.

I think we should bump this to a future sprint since it requires a little more backend wiring. Removing from sprint 1.

Starting this up!


Support for plain text documents

Issue
It looks like Optimus does not support the download of plain text at the moment. How difficult would it be to add support for other document types?
Background
Why a simple request does not work: Even if a text file may look like a dumb static resource it may be required to fake a real browser with valid cookies to download it correctly.
First thoughts (before I try to create a pull request)

A text file or any other plain text content could be represented by a Document that only has text as its root element or as inner html. This document could have ResourceTypes.Text which is already defined.
Engine.LoadFromResource should not throw an exception on non-html documents and build the document according to the resource type. A BuildDocument for plain text only needs to read the stream and create a single root element or set the inner html.
Head and Body of such a Document could just be null, but this would require a null check (or Body?.) in a few places.

What do you think?

Thanks for your feedback. I think there is no point in treating the text as an html document. Instead, it would be good to have a convenient way to load an arbitrary file using the current cookies.

Thanks for your feedback. I think there is no point in treating the text as an html document. Instead, it would be good to have a convenient way to load an arbitrary file using the current cookies.

I came up with this idea, because the browser I'm currently using implements it this way (ScrapySharp). This way cookies, headers und redirects work without any special handling. Thought this would be a cool feature for Otimus :-)

I came up with this idea, because the browser I'm currently using implements it this way (ScrapySharp). This way cookies, headers und redirects work without any special handling. Thought this would be a cool feature for Otimus :-)

Added new extension method to Knyaz.Optimus.TestingTools class.
var resource = await engine.DownloadAsync("/file/on/your/site");
var resultStream = resource.Stream;


fix(browsochrones): Don't refetch origin when changing isochrone cutoff.

Previously we did not keep the cached profile request up to date as parameters changed, which meant
that, once any parameter that caused refetch had been changed, we were always refetching the origin
if any parameters changed, even if they were parameters that should not cause a refetch. e.g. you
could change the date and that would correctly cause a refetch, but after that changing the
isochrone cutoff would cause a refetch, which it shouldn't.

Again, merging in advance of review, but let me know if anything looks off @trevorgerhardt!


feat: add buf is_changed

Add a function to see if a buffer is changed or not. Can be used to show an indicator when there are unwritten changes.
Example of using is_changed()
line.wins_in_tab(line.api.get_current_tab()).foreach(function(win)
  return {
    line.sep(" ", theme.win, theme.fill),
    win.buf().is_changed() and "" or "",
    win.buf_name(),
    line.sep("", theme.win, theme.fill),
    hl = theme.win,
    margin = " ",
  }
end),

I think this is very useful, thank you!


Bundle doesn't implement === (hardware equality)

Type of issue: bug report (?)

Impact: API addition (no impact on existing code)

Development Phase: proposal
Other information

Not sure if this is desired behavior or if no one has ever needed to compare a Bundle (or felt strongly enough about not being able to and opened an issue). So far, === is only implemented on Bits.
There may be some nuance in implementing this since Bundles can be bidirectional, so exact semantics (should we want to do this) are up for debate.
For reasons that I can't remember right now, this interacts badly (produces unhelpful and confusing error messages) with trying to instantiate hardware assertions while in a ScalaTest environment, because the Scala compiler guesses you meant the ScalaTest assert and derps hard.

It looks like === isn't even defined on Bits, it's defined on UInt and SInt. I believe the normal pattern is just to do a myBundle.asUInt === myOtherBundle.asUInt. We certainly could define === on Data. It will require a whitebox macro but hopefully there's a resolution to that in future macros.

I just stumbled over the same issue. It seems like Equality should be defined on any type that is backed by Bits or that could be a Wire.

If this does go forward, I think equality should be defined fieldwise, so that it does something sensible if the two bundles have a common field with the same type but different widths.

Similar for optional items


Performance improvements & modern technologies

FractalJS must be a showcase for Javascript technologies. As such, it needs to implement the following technologies:

Webworkers
asm.js
WebGL
ES6 or Harmony or Ecma262 or whatever the name
WebAssembly ?

Webworkers implementation is well under way. It works, but you know the 80/20 rule, so there is still a lot of work. Preliminary results with Chrome : the performance improvement is around 3.1x with 4 workers (eg from 4759ms to 1544ms). For the moment, I pass the buffers by copy instead of by reference; some improvements could be attained here. What remains to be done:

[ ] reimplement the palette refresh that became broken
[ ] estimate the number of processors if possible
[ ] rework the build process because workers require their own external JS file
[ ] code cleanup
[ ] test under four browsers

test

[x] reimplement the palette refresh that became broken
[x] estimate the number of processors if possible
[x] rework the build process because workers require their own external JS file
[x] code cleanup
[x] test under four browsers

Webworkers are here !

Tests with asm.js show no improvements in Firefox and a decrease of performance with Chrome. I implemented the core fractal function, then the tile drawing (in case the call overhead was causing the performance decrease) without success.

WebGL : limited to float precision on a lot of GC, which is not enough. Moreover, it seems the GC are not well suited to arbitrary precision math... I will get back to this when working on arbitrary precision
ES6 : concerns mostly JS syntax and is of no relevance to users. browser support will take some time to catch up, so no priority there
WebAssembly : far from being ready, but I'll jump in ASAP
Closing the ticket...


Use a 0 delay when the suggestion list is active

The autoActivationDelay is the delay before displaying the list, but it is being used for an update of the results as well. When the suggestion list is open, this will use a 0 delay. It feels considerably snappier.

Do you think there is value in keeping some debounce so that we don't impact typing performance?
Looking for your guidance, as I'm certainly not an atom performance expert.


Video playing on Android emulator and debug apk. But not on Release apk. Showing black screen.

Bug description:
I am streaming a CCTV footage coming from WSS type. Video is playing fine in Android emulator and also debug apk. But after trying generating a release apk and testing on real physical device, it is showing black screen.
I implemented steps which were mentioned in issue number: 1632 and issue number: 1954.
I added android:usesCleartextTraffic="true" in AndroidManifest.xml

To Reproduce:

Expected behavior:

Screenshots/Videos:

Environment:

OS: Mac
OS version: 12.7.3
react-native version: 0.73.2
react-native-webview version: 13.6.4

+1


add bscherer's site

You want to add your news to this huge list!
That's great.  I'd love to add it.  If you can share where your content is I'd love to only link to it.  To do this I need the way to get the data.
If you have a RSS feed, that works best.  However if I have to get it differently I can do that too, I just need to know where this data is.

Title: ChecksumFailed
Category: Blog
RSS Link or Other Endpoint: https://checksumfailed.com/index.xml

Added


[Bug] Lexer lookup doesn't cache custom plugin lexers

Hi 👋,
I'm coming from https://github.com/facelessuser/pymdown-extensions/pull/2121 where I tried to add a simple cache for the lexer lookup to make my MkDocs documentation build time faster. During the process it turned out that the issue is in Pygments, because the module does implement a cache methodology for built-in lexers, but doesn't do so for custom lexers from the entry points.
I'm specifically talking about this function, which is used by Python Markdown Extensions:
https://github.com/pygments/pygments/blob/master/pygments/lexers/__init__.py#L109-L131/
Since I'm using MkDocs with Python Markdown Extensions, my usage of Pygments is rather streamlined to providing the appropriate markdown code block with the custom lexer alias name dae and this is everywhere throughout the documentation. Therefore, I would prefer for the cache to incorporate that and make use of the alias itself when searching the cache... What I'm alluding to is that the cache lookup should be before the for loop to keep it O(1) and not O(N) + O(1)
In this comment https://github.com/facelessuser/pymdown-extensions/pull/2121#issuecomment-1646689381 I provided my testing methodology, which has shown the difference in time of the cache lookup of different builtin lexers. It also shows that the time of lookup for the custom lexer stays the same...

Here are some diagnostics files, but as you added in the second message this affects everyone that has a lot of code examples in their documentation, which use a custom lexer.
pip_freeze.txt
DxDiag.txt
>>> platform.python_version()
'3.11.3'

The lexer plugin is open source: https://github.com/kamilkrzyskow/gothic-lexer
On my machine the custom lexer lookup is ~20ms, which I'm aware is exaggerated by my slow PC. However, the issue of the slow documentation build time was noticeable even before, on my Ryzen 3600 machine, because I turned off the Pygment highlighting for the development build. It wasn't 33 -> 4 seconds (explained here), but something along the lines of 13 -> 3 seconds. I'm currently away, and can't use Ryzen 3600 machine to compare.
To summarize my previous post, since I see there are too many words:
The issues are here twofold, the cache doesn't affect custom lexers, the cache lookup comes after the lexer lookup instead of before it.


Adapt HERON to use ravenframework

Pull Request Description
What issue does this change request address?
Closes #141
What are the significant changes in functionality due to this change request?
There should be no changes in functionality. Only adapting code to use a new RAVEN feature.

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass.
[x] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large tes.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
[x] 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

Job CentOS 8 on f3dee5e : invalidated by @PaulTalbot-INL
TEAL in RAVEN has been updated retesting

Note that some tests may not pass now due to changes made in RAVEN PR#1780 to percentile and value at risk. The differences should be small, but some tests may need new gold files.

@PaulTalbot-INL All tests passed and diffs resolved. This is ready for a full review and merge.

Checklist complete. Thanks for taking care of this, and sorry it took so much effort!

See https://github.com/idaholab/raven/pull/1808 for submod update


[Issue] The throttling is not exact for both publish and dispatch in pulsar-2.10.1 version

Search before asking

[X] I searched in the issues and found nothing similar.

Version
pulsar-2.10.1 runs on the k8s cluster.
Minimal reproduce step
Precondition
There is only one topic under this namespace.
Topic: persistent://kafka_test/test/my_test_par_10
Partition Num: 10
Broker Num: 3
Bookie Num: 4
Broker Metrics:  pulsar_throughput_in, pulsar_throughput_out
Producer
bin/pulsar-perf produce   --batch-max-messages 30000   --num-producers 2   --num-test-threads 2 --num-io-threads 2   --rate 30000   --size 1000   persistent://kafka_test/test/my_test_par_10
Consumer
bin/pulsar-perf consume persistent://kafka_test/test/my_test_par_10 -ss sub201
Dispatch Rate Test
Please refer to PIP-3
We test the byte and message dispatch rates separately. The test results are not excepted(Not exact).
Byte Dispatch Rate
Only set the byte dispatch rate = 1000000(1MB). The excepted result is 1MB/s. However, the test result is 11.9MB/s.(Ref to broker metric pulsar_throughput_out )
bin/pulsar-admin namespaces set-dispatch-rate kafka_test/test --byte-dispatch-rate 1000000 --dispatch-rate-period 1

Message Dispatch Rate
Only set the message dispatch rate = 1000. The excepted result is 1MB/s. However, the test result is 12.5MB/s.(Ref to broker metric pulsar_throughput_out )
bin/pulsar-admin namespaces set-dispatch-rate kafka_test/test --msg-dispatch-rate 1000 --dispatch-rate-period 1

Publish Rate Test
We test the byte and message publish rates separately. The test results are not excepted.
Byte Publish Rate
Only set the byte publish rate = 1000000(1MB). The excepted result is 1MB/s. However, the test result is 8.9MB/s.(Ref to broker metric pulsar_throughput_in )
bin/pulsar-admin namespaces set-publish-rate kafka_test/test --byte-publish-rate 1000000

Message Publish Rate
Only set the message publish rate = 1000. The excepted result is 1MB/s. However, the test result is 8.8MB/s.(Ref to broker metric pulsar_throughput_in )
bin/pulsar-admin namespaces set-publish-rate kafka_test/test --msg-publish-rate 1000

Resource Group
Please refer to PIP-82
I tested both publish rate and dispatch rate in resourcegroup. However, the test results show the sourcegroup throttling does not work exactly.
Publish Rate
Message Publish Rate
Only set the message publish rate = 100. One message size = 1024. The excepted result is 100KB/s. However, the result is 14.7MB/s.
bin/pulsar-admin resourcegroups create rs_name --msg-publish-rate 100
bin/pulsar-admin namespaces set-resource-group kafka_test/test --resource-group-name rs_name

Byte Publish Rate
Only set the byte publish rate = 10000(1MB). One message size = 1024. The excepted result is 10KB/s. However, the result is 11MB/s.
bin/pulsar-admin resourcegroups create rs_name --byte-publish-rate 10000

Dispatch Rate
Byte Dispatch Rate
Only set the byte dispatch rate = 1000(1MB). One message size = 1024. The excepted result is 10KB/s. However, the result is 20MB/s.
bin/pulsar-admin resourcegroups create rs_name --byte-dispatch-rate 10000

Message Dispatch Rate
Only set the message dispatch rate = 100. One message size = 1024. The excepted result is 100KB/s. However, the result is 21.2MB/s.
bin/pulsar-admin resourcegroups create rs_name --msg-dispatch-rate 100

What did you expect to see?
I provide the excepted value in the above reproduction steps.
What did you see instead?
Please refer to the reproduction steps.
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

Do you set preciseTopicPublishRateLimiterEnable=true ?


Support complex type 'compare' in 3-arg min_by and max_by Presto aggregates

Presto's min_by and max_by with 3 args support complex type for the compare param, such as array.
Fixes #7469

@mbasmanova Could you please review this PR?

Could someone please review this PR? Thanks！ @mbasmanova @kagamiori @kgpai

Thank you for this @f0rest9999 ! This PR will take me a bit of time, please give me a couple of days to review.

Thanks for the review, I'll take the time to think about and fix.

Throw an exception when the key col which participate in comparison contains null.

This is a bit tricky. See kNullAsIndeterminate in CompareFlags.h and #7703

nit: This class is very similar to MinMaxByNComplexTypeAccumulator save only difference is that here the compare is comples and there the value is complex, I am curious if there is a way to merge both into 1 (without adding too much templating so its hard to follow).

@mbasmanova Already fixed.

That's a good suggestion. Could you open an issue and see if anyone is interested? While I probably haven't had a lot of time to look into how to implement this recently, and I prefer to get this non-simple Function API PR done first to support complex types. Is that all right?
And I'll spend some time looking at how to test "Aggregation Fuzzer using Presto". Thanks.

Have you run Aggregation Fuzzer using Presto as source before? In the process of running, I found some problems.
@mbasmanova @kgpai
When I run the arbitrary functions for test (from https://facebookincubator.github.io/velox/develop/testing/fuzzer.html) , an error will be reported.
./velox_aggregation_fuzzer_test \
                --seed ${RANDOM} \
                --only "arbitrary" \
                --duration_sec 3600 \
                --logtostderr=1 \
                --minloglevel=0 \
                --repro_persist_path=/tmp/aggregate_fuzzer_repro \
                --enable_sorted_aggregations=true \
                --presto_url=http://<IP_ADDRESS>:8080
I20240327 14:04:16.002938 3310529 HiveConnector.cpp:69] Hive connector test-hive created with maximum of 20000 cached file handles.
I20240327 14:04:16.003876 3310529 AggregationFuzzerBase.cpp:576] Total functions: 1 (1 signatures)
I20240327 14:04:16.004051 3310529 AggregationFuzzerBase.cpp:580] Functions with at least one supported signature: 1 (100.00%)
I20240327 14:04:16.004269 3310529 AggregationFuzzerBase.cpp:586] Functions with no supported signature: 0 (0.00%)
I20240327 14:04:16.004276 3310529 AggregationFuzzerBase.cpp:589] Supported function signatures: 1 (100.00%)
I20240327 14:04:16.004280 3310529 AggregationFuzzerBase.cpp:595] Unsupported function signatures: 0 (0.00%)
I20240327 14:04:16.004335 3310529 AggregationFuzzer.cpp:325] ==============================> Started iteration 0 (seed: 7063)
I20240327 14:04:16.020104 3310529 AggregationFuzzerBase.cpp:366] Executing query plan:
-- Aggregation[SINGLE [g0] a0 := arbitrary(ROW["c0"]) ORDER BY c0 ASC NULLS LAST] -> g0:ARRAY<BOOLEAN>, a0:TIMESTAMP
  -- Values[1000 rows in 10 vectors] -> c0:TIMESTAMP, g0:ARRAY<BOOLEAN>
I20240327 14:04:16.056669 3310541 Task.cpp:1096] All drivers (1) finished for task test_cursor 1 after running for 30 ms.
I20240327 14:04:16.056702 3310541 Task.cpp:1818] Terminating task test_cursor 1 with state Finished after running for 30 ms.
I0327 14:04:16.683683 3310529 Compression.cpp:628] Initialized zstd compressor with compression level 7
I20240327 14:04:16.692608 3310529 FileSink.cpp:123] closing file:fuzzer.dwrf,  total size: 8.36KB
QueryAssertions.cpp:1129: Failure
Failed
Expected 376, got 376
328 extra rows, 328 missing rows
10 of extra rows:
        null | "3784991-02-06T13:52:39.498000000"
        [] | "10265357-09-13T20:16:11.120000000"
        [null] | "55442863-07-23T06:20:47.805000000"
        [null,null] | "60150461-09-15T15:10:55.522000000"
        [null,null,null,null,null,true,null,null] | "55442863-07-23T06:20:47.805000000"
        [null,null,false] | "181669003-06-08T20:15:29.805000000"
        [null,null,false,true,false,false,false,null,true,true,true,true,null,null,false,null,null,true,false] | "105667027-12-16T05:18:40.658000000"
        [null,null,false,true,false,false,false,true,null,false,false,true,false,false,null,true,true,null,null] | "271030430-06-16T08:10:18.450000000"
        [null,null,false,true,false,true,false,false,false,true] | "11883841-03-28T20:43:26.332000000"
        [null,null,true] | "49077045-08-24T05:22:50.606000000"

10 of missing rows:
        null | "104725217-01-14T04:26:14.072000000"
        [] | "100565777-03-15T01:55:31.427000000"
        [null] | "65877250-09-07T18:37:01.933000000"
        [null,null] | "264175230-11-02T07:20:50.204000000"
        [null,null,null,null,null,true,null,null] | "55442863-07-22T14:20:47.805000000"
        [null,null,false] | "181669003-06-08T04:15:29.805000000"
        [null,null,false,true,false,false,false,null,true,true,true,true,null,null,false,null,null,true,false] | "273329593-02-10T01:01:17.785000000"
        [null,null,false,true,false,false,false,true,null,false,false,true,false,false,null,true,true,null,null] | "271030430-06-15T16:10:18.450000000"
        [null,null,false,true,false,true,false,false,false,true] | "11883841-03-28T04:43:26.332000000"
        [null,null,true] | "278842008-11-07T20:43:18.559000000"

Unexpected results
E20240327 14:04:16.891533 3310529 Exceptions.h:69] Line: AggregationFuzzer.cpp:848, Function:verifySortedAggregation, Expression: assertEqualResults( expectedResult.value(), firstPlan->outputType(), {resultOrError.result}) Velox and reference DB results don't match, Source: RUNTIME, ErrorCode: INVALID_STATE
libc++abi: terminating with uncaught exception of type facebook::velox::VeloxRuntimeError: Exception: VeloxRuntimeError
Error Source: RUNTIME
Error Code: INVALID_STATE
Reason: Velox and reference DB results don't match
Retriable: False
Expression: assertEqualResults( expectedResult.value(), firstPlan->outputType(), {resultOrError.result})
Function: verifySortedAggregation
File: AggregationFuzzer.cpp

And when I run max_by, I got this error, while I think MAP<BOOLEAN,BOOLEAN> should not be passed into the function as a compare key, how can I limit it?
./velox_aggregation_fuzzer_test \
                --seed ${RANDOM} \
                --only "max_by" \
                --duration_sec 3600 \
                --logtostderr=1 \
                --minloglevel=0 \
                --repro_persist_path=/tmp/aggregate_fuzzer_repro \
                --enable_sorted_aggregations=true \
                --presto_url=http://<IP_ADDRESS>:8080

Error Source: RUNTIME
Error Code: INVALID_STATE
Reason: Unknown input types for max_by (SINGLE) aggregation: SMALLINT, MAP<BOOLEAN,BOOLEAN>, BIGINT
Retriable: False
Function: createNArg
File:MinMaxByAggregates.cpp
Line: 1755

@f0rest9999

That's a good suggestion. Could you open an issue and see if anyone is interested? While I probably haven't had a lot of time to look into how to implement this recently, and I prefer to get this non-simple Function API PR done first to support complex types. Is that all right?

I'm afraid we won't be able to merge this code as is. There is too much copy-paste. The code is too hard to read and reason about. We'll need to simply. I believe the first step would be to convert existing implementation to use Simple Function API. The next step would be to add new logic to it and figure out how to avoid so much copy-paste when doing that. Thanks.

I'm afraid we won't be able to merge this code as is. There is too much copy-paste. The code is too hard to read and reason about. We'll need to simply. I believe the first step would be to convert existing implementation to use Simple Function API. The next step would be to add new logic to it and figure out how to avoid so much copy-paste when doing that. Thanks.

@mbasmanova Thanks for your all review and suggestion, also @kgpai .
The issue can cc@ me. Rewriting to the simple API will take some time. So it probably not be done quickly by me.
During the time, if someone else has implemented it, I will learn how to do it.In short,  I‘m interested in this issue.
I think the reason it's hard to scale is that templates are used in a lot of places, and the function takes two arguments (various types). The combination of these two reasons made it difficult to extend and reuse code under the old framework.
You can close this PR. Thanks!

Have you run Aggregation Fuzzer using Presto as source before? In the process of running, I found some problems. @mbasmanova @kgpai
And when I run max_by, I got this error, while I think MAP<BOOLEAN,BOOLEAN> should not be passed into the function as a compare key, how can I limit it?
./velox_aggregation_fuzzer_test \
                --seed ${RANDOM} \
                --only "max_by" \
                --duration_sec 3600 \
                --logtostderr=1 \
                --minloglevel=0 \
                --repro_persist_path=/tmp/aggregate_fuzzer_repro \
                --enable_sorted_aggregations=true \
                --presto_url=http://<IP_ADDRESS>:8080

Error Source: RUNTIME
Error Code: INVALID_STATE
Reason: Unknown input types for max_by (SINGLE) aggregation: SMALLINT, MAP<BOOLEAN,BOOLEAN>, BIGINT
Retriable: False
Function: createNArg
File:MinMaxByAggregates.cpp
Line: 1755

At present, I don't know much about the data-generate process of Fuzzer, seems like a general problem?

Hi @f0rest9999 this might be related to the your PR change as current min_by, max_by doesnt support complex types for comparison. Nevertheless if you can create an issue and add the stack trace I can investigate more.

Hi @f0rest9999 this might be related to the your PR change as current min_by, max_by doesnt support complex types for comparison. Nevertheless if you can create an issue and add the stack trace I can investigate more.

You may have missed this comment. Once you address it, the error should go away.
After the modification according to mbasmanova's suggestion, there is no such problem. Thanks for your attention.


Update Eventhub-Client jar dependency to 1.0.1

Eventhub client library has few key fixes that need to be included in storm-eventhub jar.
Fixes:

Fix for EventHubSender may throw NullPointerException on .close()
EventHubsSender keeps failing to send messages once it hits ConnectionClosedException

This seems fine once the storm versions are reverted, though you should get this on the master branch first. I'd like to mention before you spend too much time on trying to make the spout run reliably, that we've had some reliability problems with the com.microsoft.eventhubs.client:eventhubs-client since the underlying AMQP library isn't being maintained. There's a new eventhub client here based on Apache Proton which is likely to provide a better experience. https://github.com/Azure/azure-event-hubs/tree/master/java

Hm, nevermind the new client, it requires Java 8. It's still an option for Storm 2.0 though.

Btw, IMO, upgrading the dependency is worth to file an issue.
@raviperi Could you file it and copy description of PR to issue's description?

Is there a similar pull request to master?

The latest PR addresses the above comments
. Move dependencies to parent pom
. Revert changes to versions to reflect naming convention.
I will be sending a different PR to master branch, that includes the above changes.

Created a new PR https://github.com/apache/storm/pull/1717 for the master branch.
Created a new JIRA that reflects the  need for the aboce work.
STORM-2127 - Storm-eventhubs should use latest amqp and eventhubs-client versions

@revans2 Please let me know if you have further comments.

I am not really familiar with EventHub all that much so I don't really feel all that confident in reviewing it.  I mostly jumped on to answer a few generic questions.

+1. @srdo do you have any further comments pending.

No, this seems fine. +1

@raviperi do you have JIRA filed here for this https://issues.apache.org/jira/browse/STORM/

@raviperi sorry for nitpick. we need the format of the title to be
" STORM-2127: Storm-eventhubs should use latest amqp and eventhubs-client versions"

@harshach
Updated title as per your recommendation.


Upgrade pymongo to 3.8

Motivation
Resolves https://github.com/DataDog/integrations-core/issues/1947

Do we know if it's not gonna break tokumx this time?
https://github.com/DataDog/integrations-core/pull/2116

@FlorianVeaux Yes since we vendor it https://github.com/DataDog/integrations-core/tree/master/tokumx/datadog_checks/tokumx/vendor


Add dependency tree for paket.lock files

Expands #611 by adding dependency trees.

Thanks @robaliias. Is it possible to set your email correctly on future PRs to claim contributor credits?


Docs: distributed jr dependency on k8s?

Check the doc if k8s is a strong prerequisites and document how to run jr distributed mode without k8s

This could be added in the docs
https://github.com/SvenskaSpel/locust-swarm?tab=readme-ov-file


Not possible to reduce countries after filtering

Describe your issue
When using a filter, all countries are expanded and there is no way to reduce them. Of course, it would be possible to filter by country, but the expand/collapse icon remains, symbolising that it should be possible to collapse this country category.

To avoid confusion now when filtering channels expand/collapse icon will be hidden.


Graviton build update

What changed? Why?
Target arm64 architecture in web Dockerfile
Notes to reviewers
How has it been tested?

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1


[WIP] ReinforcementLearning.jl integration

I realized that CommonRLInterface.jl never settled on what to do with continuous action spaces, so directly integrating with RLBase from ReinforcementLearning.jl.
Will add tests and examples with PPO and DDPG.

Codecov Report

Merging #9 (fa08c49) into main (efab5f2) will decrease coverage by 0.11%.
The diff coverage is n/a.

:exclamation: Current head fa08c49 differs from pull request most recent head 1043fc3. Consider uploading reports for the commit 1043fc3 to get more accurate results

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   92.13%   92.02%   -0.12%
==========================================
  Files          81       81
  Lines        3816     3762      -54
==========================================
- Hits         3516     3462      -54
  Misses        300      300

Impacted Files
Coverage Δ

src/Dojo.jl
100.00% <ø> (ø)

src/orientation/quaternion.jl
81.08% <0.00%> (-5.46%)
:arrow_down:

src/orientation/mapping.jl
36.36% <0.00%> (-5.31%)
:arrow_down:

src/joints/rotational/input.jl
42.10% <0.00%> (-1.49%)
:arrow_down:

src/joints/joint.jl
88.88% <0.00%> (-0.51%)
:arrow_down:

src/contacts/impact.jl
86.20% <0.00%> (-0.46%)
:arrow_down:

src/bodies/set.jl
94.54% <0.00%> (-0.37%)
:arrow_down:

src/joints/rotational/springs.jl
97.29% <0.00%> (-0.14%)
:arrow_down:

src/utilities/methods.jl
96.66% <0.00%> (-0.11%)
:arrow_down:

src/joints/prototypes.jl
96.15% <0.00%> (-0.08%)
:arrow_down:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efab5f2...1043fc3. Read the comment docs.


empty string is a valid key

https://html.spec.whatwg.org/multipage/webstorage.html#the-storage-interface

Any string (including the empty string) is a valid key.

https://github.com/bouzuya/cookie-storage/commit/00aee3f591083dfa9f2d3b3ec75c8d299f7c3819


Update PF dependencies to 2022.07

Description
Upgrading directly to 2022.08 is blocked by
https://github.com/patternfly/patternfly-react/issues/7722 (which is fixed in @patternfly/react-core version 4.225.11 and will be part of the next PF release.)
Related to https://github.com/stackrox/stackrox/pull/1419
Checklist

[ ] Investigated and inspected CI test results

Testing Performed
Manual spot check by using the app, focusing on PatternFly pages.

Looks like this PF upgrade might have really broken some things, based on the ui-e2e tests.

Yikes! I'll take a look and see how serious it is. Hoping this is just an internal PF change based on some selectors (I see a lot of failures failing to find td.pf-c-table__action) and not a more functional issue.

Two issues introduced by this update that should be fixed now. (Passing locally, just pushed to CI)

In menu dropdowns, the role="menuitem" attribute is now placed on the child of the li instead of the li itself. The li gets role="none". (Unless the child is a checkbox, then this behavior is reversed). Introduced by PF change https://github.com/patternfly/patternfly-react/pull/7368/files#diff-dba8c84d269ff65dc2f536cdc0fcf812decfd80e52d7f4674c9fe86313422be2

The need to press 'downarrow' followed by 'enter' when attempting to create a tag is no longer. This reverts this change, which was the original fix for a PF behavior change that broke e2e tests. I haven't tracked down exactly where they updated this yet to verify, but the behavior is consistent on my machine.


Added a telegram bot which runs python code

A simple telegram bot that runs python code

Description

Run python expressions from telegram, Telegram Bot

As described in issue #623 , the new bot is added

On branch aahnik_runPythonBot

This bot will execute a python expression and return the results.

Take a look at this GIF to understand better:
You may use pythonic expressions to easily calculate any complex problem. Or you may test your algorithms on the go.

Click the gif to view full screen on Smartphone

You can easily deploy this bot on Python Anywhere or on your local machineby following the steps given in README.
Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:
Please tick all the boxes that are fulfilled by your Pull Request.

[X] I have named my files and folder, according to this project's guidelines.
[x] My code follows the style guidelines of this project.
[x] My Pull Request has a descriptive title. (not a vague title like Update index.md)
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
[x] I have included a requirements.txt file (if external libraries are required.)
[x] My changes do not produce any warnings.
[x] I have added a working sample/screenshot of the script.

Changes to be committed:
	new file:   runPython_bot/.gitignore
	new file:   runPython_bot/Makefile
	new file:   runPython_bot/README.md
	new file:   runPython_bot/bot/__init__.py
	new file:   runPython_bot/bot/execute_code.py
	new file:   runPython_bot/bot/runPython_bot.py
	new file:   runPython_bot/requirements.txt
	new file:   runPython_bot/start.py

@AdityaJ7 @fuzzmz @valterm @dingusagar @k1m0ch1 @arthuralmeida93 @MNISAR @antoniouaa @sandyjswl @malhotra-paritosh @chavarera @SuvamPrasd @Araon @symtalha14
The bot is live and running.
Check it out now ☺
http://t.me/runPython_bot
If the link does not work search
@runPython_bot in Telegram.

@aahnik very nice, just add some comments in your py files to make it a bit beginner friendly else everything else is awesome

I have added docstrings with explanations and links to tutorials in my last commit https://github.com/Python-World/Python_and_the_Web/pull/624/commits/5668ad1524cf246455b11dea4cfaf193d864eafe

My work is complete, you may try running the following on the already deployed bot

Check out @runPython_bot
Run Python code from telegram chat

@allcontributors please add @aahnik for code

Thanks a lot @AdityaJ7 and @tusharnankani for accepting my pull request.
This was really a fun and enjoyable learning experience.
I hope to contribute more code in future.

@aahnik
Expecting more contributions from your end! 👍🏻
Keep it up! ^_^


Link

[Enter feedback here]
Hi,
The following stopped working: https://gallery.technet.microsoft.com/Shared-Responsibilities-81d0ff91
Thanks,
Eric

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e3b44b4c-526f-7b2a-7977-02c88df6969a
Version Independent ID: 87f296a8-b30e-ae96-53bc-d13a133dec83
Content: Security recommendations for Azure IoT
Content Source: articles/iot-fundamentals/security-recommendations.md
Service: iot-hub
GitHub Login: @dsk-2015
Microsoft Alias: dkshir

@stperic We need more info on this issue.
Please elaborate on what stopped working? is it a URL?, is it any broken Hyperlink? or any Search functionality not working?
Please include some images or screenshots of the issue, so that we help in fixing it.

@SatishBoddu-MSFT Please find below the screenshot of the webpage when clicking the link.

@stperic
Are you browsing this URL  https://docs.microsoft.com/en-us/samples/browse/
And something is broken?
I am trying to understand which document or tutorial are you referring to?
This issue is referring to this Tutorial: Security recommendations for Azure IoT So I am trying to find out if this tutorial has any issues?
Or we have to move this issue to the right place/


Github is out of sync with released code

Released extension is at 0.0.3, from January 28th.
The code here is at 0.0.2, last modified January 23rd. Please update Github to match what was released.

Done, and sorry about that!


Legacy plugin breaks async generators

Describe the bug
I recently upgraded from Vite 2.x to Vite 4.x, and I can no longer build my project. I think it's due to plugin-legacy changing the target browsers here: https://github.com/vitejs/vite/blob/128f09eb0100e80f566e33ca8c55bcd0896d4e38/packages/plugin-legacy/src/index.ts#L187-L192
This target leads esbuild to think it needs to transpile async generators (which was usually left to babel). When I run build, it throws this error (from transpiling a dependency): Transforming async generator functions to the configured target environment ("chrome64", "edge79", "es2020", "firefox67", "safari11.1" + 2 overrides) is not supported yet
Reproduction
https://stackblitz.com/edit/vitejs-vite-wddogq
Steps to reproduce
Run npm install and then npm run build
System Info
success Install finished in 1.172s

  System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 7.17.0 - /usr/local/bin/npm
  npmPackages:
    @vitejs/plugin-legacy: ^3.0.2 => 3.0.2
    vite: ^4.1.0-beta.1 => 4.1.0-beta.1

Used Package Manager
npm
Logs

Click to expand!
❯ npm run build
$ vite build
vite v4.1.0-beta.1 building for production...
✓ 6 modules transformed.
dist/assets/index-legacy-6515cddc.js      2.17 kB │ gzip: 1.13 kB
dist/assets/polyfills-legacy-40963d34.js  7.92 kB │ gzip: 3.11 kB
[vite:esbuild-transpile] Transform failed with 1 error:
assets/index-!~{001}~.js:61:0: ERROR: Transforming async generator functions to the configured target environment ("chrome64", "edge79", "es2020", "firefox67", "safari11.1" + 2 overrides) is not supported yet

Transforming async generator functions to the configured target environment ("chrome64", "edge79", "es2020", "firefox67", "safari11.1" + 2 overrides) is not supported yet
58 |    asyncGenerator();
59 |  }
60 |
   |   ^
61 |  async function* asyncGenerator() {
   |  ^
62 |    yield 0;

error during build:
Error: Transform failed with 1 error:
assets/index-!~{001}~.js:61:0: ERROR: Transforming async generator functions to the configured target environment ("chrome64", "edge79", "es2020", "firefox67", "safari11.1" + 2 overrides) is not supported yet
    at failureErrorWithLog (file:///home/projects/vitejs-vite-wddogq/node_modules/esbuild/lib/main.js:1594:15)
    at eval (file:///home/projects/vitejs-vite-wddogq/node_modules/esbuild/lib/main.js:827:29)
    at responseCallbacks.<computed> (file:///home/projects/vitejs-vite-wddogq/node_modules/esbuild/lib/main.js:691:9)
    at handleIncomingPacket (file:///home/projects/vitejs-vite-wddogq/node_modules/esbuild/lib/main.js:746:9)
    at Socket.readFromStdout (file:///home/projects/vitejs-vite-wddogq/node_modules/esbuild/lib/main.js:667:7)
    at EventEmitter.emit (https://vitejsvitewddogq-ogu5.w-corp.staticblitz.com/blitz.685d3c93544a5e80be2c9e6906d68c0f4bd854cc.js:6:155574)
    at addChunk (https://vitejsvitewddogq-ogu5.w-corp.staticblitz.com/blitz.685d3c93544a5e80be2c9e6906d68c0f4bd854cc.js:6:656481)
    at readableAddChunk (https://vitejsvitewddogq-ogu5.w-corp.staticblitz.com/blitz.685d3c93544a5e80be2c9e6906d68c0f4bd854cc.js:6:656185)
    at Readable.push (https://vitejsvitewddogq-ogu5.w-corp.staticblitz.com/blitz.685d3c93544a5e80be2c9e6906d68c0f4bd854cc.js:6:656869)
    at _0x5baa5a.onStreamRead [as onread] (https://vitejsvitewddogq-ogu5.w-corp.staticblitz.com/blitz.685d3c93544a5e80be2c9e6906d68c0f4bd854cc.js:6:783983)
    at Object.emit (https://vitejsvitewddogq-ogu5.w-corp.staticblitz.com/blitz.685d3c93544a5e80be2c9e6906d68c0f4bd854cc.js:8:250102)
    at _0x555c73 (https://vitejsvitewddogq-ogu5.w-corp.staticblitz.com/blitz.685d3c93544a5e80be2c9e6906d68c0f4bd854cc.js:8:251737)
    at Object._0xecd3d [as emit] (https://vitejsvitewddogq-ogu5.w-corp.staticblitz.com/blitz.685d3c93544a5e80be2c9e6906d68c0f4bd854cc.js:8:248385)
    at https://vitejsvitewddogq-ogu5.w-corp.staticblitz.com/blitz.685d3c93544a5e80be2c9e6906d68c0f4bd854cc.js:8:250999
    at Map.forEach (<anonymous>)
    at _0x55861a (https://vitejsvitewddogq-ogu5.w-corp.staticblitz.com/blitz.685d3c93544a5e80be2c9e6906d68c0f4bd854cc.js:8:250970)

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Unfortunately this is a current limitation of plugin-legacy. This requires #6922 to be implemented to plugin-legacy or async generator transpilation supported by esbuild (https://github.com/evanw/esbuild/issues/2780)
Closing as a duplicate of #6922.

This target leads esbuild to think it needs to transpile async generators (which was usually left to babel).

Previously async generators were transpiled by babel for legacy build. But wasn't transpiled for modern build. This means when accessing with browsers that supports dynamic import but doesn't support async generators your site didn't work. See https://github.com/vitejs/vite/pull/10052#issuecomment-1242076461, https://github.com/vitejs/vite/pull/10072 for more details.

I noticed that plugin-legacy could transpile async generators with babel for modern build.


Feature/admin analytics

Y'ALL READY FOR THIS, IT'S 3:30 AND I HOPE THIS IS COHERENT
NOTES FOR THIS PR:
What got done:
-Limit QTY Per Item to 6 (not 10 like was previously implemented)
-Can only have 10 unique items (there are some bugs, but with the system in place, this is what I came up with)
-Added Admin Analytics (Bar Chart to see how much money has been made per day)

(Not sure if that image works)
Notes for Criticism:
So I am running a script for something called Plotly.js it's a javascript thing that creates graphs, if we want to use something else I am totally game, this was just one that works really well and doesn't need to install anything (hopefully it works with Heroku) if you want to research it look here: https://plot.ly/javascript/
So if you want anything changed. Please let me know ASAP.
Cheers,
Alex

The Image works, thats what the Graph looks like in the admin page, it changes if more items are added (on a button click). We can do some really cool stuff with it if we want


Bashit light weight for servers

Expected Behavior
There should be a light version of bashit for servers with essentials like

3 - 4 simple themes that loads fast
few lines in .bashrc so that the shell prompts faster
essential completions / plugins only
server specific functionality like

add new vhost
iptables aliases and more

Current Behavior

The current size is 3.4 mB which is kinda huge for servers. There we need some light weight solution that runs faster
Possible Solution
From the current repo, purge all the unnecessary files and add few servers specific functionalities

@nwinkler @NoahGorny any ideas on this?

Is the performance an issue or the repo size?
If the performance is an issue, we can just add a new installation option for servers, which enables only the most suitable plugins and themes for servers

Is the performance an issue or the repo size?
If the performance is an issue, we can just add a new installation option for servers, which enables only the most suitable plugins and themes for servers

Basically it's both. But I would like to stick to performance issue

IMHO, this is a duplicate of packing up for distribution, because when doing so we would not include any git history, making the install very lightweight.
However, in the meantime, this point about changing default plugins might be worth exploring. We could open a PR to add an install flag for this, as @NoahGorny suggests.

The repo size issue is caused by

the long history of Bash-it, and
some binary files (images) that crept into the Git history. Removing those would mean rewriting the Bash-it history.

To your point, @tbhaxor, "purging all the unnecessary files" will not fix this, as it will simply add more history, the cloned repo size will not really shrink. The current installation instructions recommend to do a shallow fetch, which results in 1.2 MiB (which still seems rather large - might be worth investigating).
TBH, with today's download speeds, a download size of 1 MiB (or even 3 MiB) shouldn't be a problem at all. You've got a point about the initialization time - but as mentioned, that can be handled using the installer.

Hi Team,  Okay I've been grinding on this ... I see @tbhaxor mentioned their main concern was performance, but my thoughts are mostly related to install size ...
Reduced runtime overhead

If the performance is an issue, we can just add a new installation option for servers, which enables only the most suitable plugins and themes for servers

I think there could be value to having install profiles with different defaults for enabled components.
There's also value in a --no-components option that installs with no components enabled.
Q: Does that exist already?

... which enables only the most suitable plugins and themes for servers

I don't think we enable any themes by default, right?  So the user/admin has full control over that.
Reduced Install footprint
I think the use-case for having Bash-it installed with a reduced footprint is valid.
I don't find much value in the idea of a separate, "lightweight" distribution. Until Bash-it can download+install components on-demand (ala brew per se), you'll never please everyone with the component choices that go into a sub distro.
What I think would be valuable is either a built-in function(s), or a documented process, for removing unused components and unneeded files, etc.
For instance, it would be pretty easy to Detect and Delete aliases, completions and plugins that were not Enabled.
You could imagine a function like:
$ bashit remove plugin ruby

$ bashit remove plugins --all

$ bashit remove plugins --not-enabled

Themes would be a bit harder, because some themes rely on others.
$ bashit remove theme simple

$ bashit remove themes --all

$ bashit remove themes --all-except powerline,powerline-plain

Unneeded files in release archives
Additionally, I feel our Releases contain a lot of files that are likely not needed by the average user:
.ackrc
.editorconfig
.gitattributes
.gitignore
.gitmodules
.pre-commit-config.yaml
.readthedocs.yml
.shellcheckrc

.github/

clean_files.txt
lint_clean_file.sh

test/
test_lib/

NOTE: I might consider the docs/ folder on this list as well
I recommend we consider removing these files/directories from our official release archives.  Users who want to contribute should be encouraged to checkout from source, and they would pickup these files that way.
Lastly, you could also imagine a bash-it command to remove these files (and the .git/ folder itself) post-install:
$ bashit --reduce-footprint

NOTE: --reduce-footprint is merely a place-holder as I could not think of a more-useful name in the moment.
NOTE: I suspect users of this action would like the ability to consider the docs/ folder for removal as well, so we would want some way to accommodate that, something like
# Exclude docs by default
$ bashit --reduce-footprint --include-docs

# Remove docs by default
$ bashit --reduce-footprint --keep-docs

# Separate action for removing docs
$ bashit remove docs

User-created distros
One of the goals with these tools would be to allow users to easily create their own distros.  With that idea in mind, we may also want to consider a Bash-it command to archive itself:
$ bashit archive /path/to/save/file.tar.gz

-DF

To your point, @tbhaxor, "purging all the unnecessary files" will not fix this, as it will simply add more history, the cloned repo size will not really shrink. The current installation instructions recommend to do a shallow fetch, which results in 1.2 MiB (which still seems rather large - might be worth investigating).

Currently we are using latest tag to determine the current stable version of bashit.
Why not we add a simple file that would download the tarball / zip from github released of latest plugin and extract it in the ~
Something like
curl https://github/bashit/install.sh | sh

Please note, there would be no frequent updates on server. As servers are meant to be keep running on lts versions unless there is serious security flaw in it (here bash interpreter)

Thanks for the summary, @davidpfarrell!

I think there could be value to having install profiles with different defaults for enabled components.
There's also value in a --no-components option that installs with no components enabled.
Q: Does that exist already?

The install.sh script has the --silent flag, which enables only a set of reasonable defaults, e.g. bash-it completion and the general aliases.
Install footprint: Do we really see value in saving a couple of megabytes here? The overall size of the Themes, Plugins, Aliases, and Completions is about 2 - 3 MiB in total. Do we really want to go through all this work to save a couple of KB here and there? The impact of having to handle the local Git changes when removing files seems unnecessarily complex - unless we convert the cloned repo to a non-Git folder and stop tracking local changes...
I agree that a lot of the development-related files like Editorconfig don't belong in a packaged distribution, but that's something we can cover as part of the packaging. A dedicated command for that feels like overkill.

Why not we add a simple file that would download the tarball / zip from github released of latest plugin and extract it in the ~

@tbhaxor This is an over-optimization. The current install path is also a "one liner". There just isn't a need for any of this concern. See #1819

I don't think we enable any themes by default, right? So the user/admin has full control over that.

@davidpfarrell By default bobby theme is enabled
https://github.com/Bash-it/bash-it/blob/2d56cc4167a5a884722f770fe32ace4cb16143f3/template/bash_profile.template.bash#L15

I don't find much value in the idea of a separate, "lightweight" distribution

For this we can use makefile approach
bash-it install  # default install
bash-it install --target server

Also, remove plugin is not required.

$ bashit --reduce-footprint

We can use something like
$ bashit purge-unwanted
$ bashit purge-unwanted --with-disabled plugins --with-disabled themes

This is an abstract idea

Ohk let's not make this complicated.
My whole point was, in servers we want very few things

iptables related alias or plugins
systemd related plugins
few themes (bobby is good)
fast source-ing of .bashrc (it takes time when too many assets are enabled)
bashit updation

We can use @NoahGorny's approach. I really liked that instead of creating separate repo or branch simply add flag. Nice thinking brother

Oops. Accidentally closed. Sorry about that 😅

An install profile similar to the --silent option might be the right way then. Like I said, saving disk space (a couple of MiB at best) feels like overkill - the couple of extra files that are on disk but are not loaded will not hurt anyone.
Maybe a --minimal option for the installer is what we need, or a way to define custom profiles, e.g. --profile <profile_name>.
On the other hand, if you end up wanting the same config on every one of your servers, a backup/restore of your current configuration might be a smarter way to go about this. I'd like to point to this again: https://github.com/nwinkler/dotfiles/blob/master/home/bin/backup-bash-it - the resulting file can be backed up in Git and then run on any server where you want the same Bash-it configuration...

An install profile similar to the --silent option might be the right way then. Like I said, saving disk space (a couple of MiB at best) feels like overkill - the couple of extra files that are on disk but are not loaded will not hurt anyone.
Maybe a --minimal option for the installer is what we need, or a way to define custom profiles, e.g. --profile <profile_name>.
On the other hand, if you end up wanting the same config on every one of your servers, a backup/restore of your current configuration might be a smarter way to go about this. I'd like to point to this again: https://github.com/nwinkler/dotfiles/blob/master/home/bin/backup-bash-it - the resulting file can be backed up in Git and then run on any server where you want the same Bash-it configuration...

I really like the profile way. We can have default profiles that we distribute, and also allow users to save/load different profile to allow customized profiles

@NoahGorny How can I test this?

@tbhaxor, create a new profile file named "minimal.bash_it" or similar. You could create a new branch and just edit default.bash_it and try install.sh --silent on a server and see how you like it.
I think the biggest candidate for removal is the alias completion, but there's really not much in there. Maybe alsö set $BASH_IT_THEME?

Closing as #1865 solves this


chore!: drop unused coreTopicsAtFork

Motivation
Found un-used duplicated code while on https://github.com/ChainSafe/lodestar/issues/5447
Description
Drop unused coreTopicsAtFork. The actually used function is on
https://github.com/ChainSafe/lodestar/blob/342eb171f01497e2d582b9235f412382b5ebd77a/packages/beacon-node/src/network/gossip/topic.ts#L194-L197

:tada: This PR is included in v1.9.0 :tada: