New metabolism/enzyme terms part 1( molecular function and biological process)

@hdrabkin ...I get the feeling this may end up on your doorstep...I can separate these out futher into individual requests for each term. They are logically grouped here because the enzymes catalyze reactions that are part of the pathways. Also from the same paper describing the biology.
Term: fraxetin 5-hydroxylase activity  ==     GO:0106144
Defintion: Catalyzes the reaction fraxetin+ NAD(P)H + 02= sideretin + NAD(P)(+) + H20
Suggested Parentage: GO:0016709
Ref:PMID:29581584
Term: scopoletin 8-hydroxylase activity  == GO:0106145
Def: Catalyzes the hydroxylation of scopoletin at position C-8 to form fraxetin (Scopoletin + 2-oxoglutarate+O2=fraxetin +succinate+ CO2)
Suggested Parentage: GO:0016709
Ref: PMID:29581584, PMID:29361149
Term: sideretin biosynthesis === GO:0106146
Def: The chemical reactions and pathways resulting in the formation of sideretin.
Suggested parentage: GO:009805 (coumarin biosynthetic process)
Ref:PMID:29581584
Term: fraxetin biosynthesis == GO:0106147
Def: The chemical reactions and pathways resulting in the formation of fraxetin.
Suggested parentage: GO:009805 (coumarin biosynthetic process)
Ref:PMID:29581584

I will request both the reduced and oxidized forms while I'm at it.

I decided to go ahead and put these in now while I'm waiting for CHEBI ids; I also requested two EC numbers (I have no idea how long they will take). It looks like RHEA would like the CHEBI ids or structures first. CHEBI should not take long, so I'll wait for them.

Will be in next monthly CHEBI release
submission: 13730
chebi_id: CHEBI:142096
name: sideretin (oxidized form)
submission: 13729
chebi_id: CHEBI:142095
name: sideretin (reduced form)

fraxetin 5 hydroxylase EC:1.14.14.fm (pending);  EC 1.14.14.fm, RHEA:57844

Scopoletin 8-hydroxylase EC:1.14.11.ag (pending) EC 1.14.11.ag, RHEA:57848

@hdrabkin  Is this done?

RHEAs and ECs now public.


Host based route matching

Hello,
I am considering switching to fast-gateway from my own custom quick&dirty gateway implementation based on http-proxy.
My use case is based on domains for APIs, instead of /prefixes, so basically I want api gateway to map current request to specific API service on the base of Host header.
Here is how I implement it in my own code:
https://github.com/restyler/api-gateway/blob/master/gateway/src/server.js#L113
https://github.com/restyler/api-gateway/blob/master/gateway/api.http#L7
Stub API servers are launched using vhost package ( https://github.com/restyler/api-gateway/blob/master/gateway/src/server.js#L141 ).
I am probably missing something, but I don't see obvious way to do the same trick in fast-gateway . Can you please point me to the right direction how this can be solved?
Thanks!

Hi @restyler thanks for your interest in this project.
Below I want to show you how this would look like using fast-gateway, I will release the new hostnames-hook implementation and the example ASAP.
My recommendation would be to basically map hostnames to prefixes. In this way we can hold the performance of the path based router.
Looking forward to your considerations:

Hi @jkyberneees thank you for your prompt reply and the proposed solution!
It should do the job, but in terms of code readability I think there is a room for improvement - reading the routes definition now does not give the full picture on the gateway schema, since jumping back and forth between hostnames2prefix and routes() is now required.
I'm not sure I can grasp the whole technical limitation factors here, but In terms of external gateway API route() definition I would prefer to get rid of unnecessary 'prefix' and have something like:
gateway({
  server: app,
  matchByHost: true, // or matchBy: 'host' / 'url_prefix' ?
  middlewares: [
  ],

  routes: [{
    match: 'node.com:443',
    target: 'http://localhost:3000'
  }]
})

May be it does not make sense, just my 2 cents.
Thank you!

Hi @restyler , excuse my delay on this thread.
Totally valid question and remark from your side. I basically agree on the fact that my proposal looks like not integrated with the current configuration approach.
As you also mention, the reason is because of technical limitations. Let me explain:
The current library was initially designed for API Gateway implementations. Meaning, we enable developers to decouple big APIs and monoliths into REST based microservices while still providing a single entry point to their applications. (read more)
The core implementation was based on url prefix routing, this would allow us to benefit from existing frameworks like restana or express.js in regards of their routing capabilities as well as middlewares support. Basically this is the reason why this gateway framework is so fast and so easy to extend, since we could reuse basically the hundreds of existing middlewares available at NPM.
This is why my proposal for supporting hostnames goes on the same direction to keep performance, a critical requirement for this kind of application component.
I hope I could give you some data points.
Regards

This totally makes sense @jkyberneees , thank you for the details. I'd suggest we consider this issue as solved :)


Consider partial content HTTP status as successful

This resolves https://github.com/home-assistant/core/issues/75465 locally for me.

Codecov Report

Merging #24 (9ce2743) into master (267fc61) will increase coverage by 3.51%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   85.18%   88.70%   +3.51%
==========================================
  Files           7        7
  Lines         324      354      +30
==========================================
+ Hits          276      314      +38
+ Misses         48       40       -8

Impacted Files
Coverage Δ

setup.py
0.00% <ø> (ø)

pytomorrowio/pytomorrowio.py
89.79% <91.20%> (+6.36%)
:arrow_up:

pytomorrowio/__init__.py
100.00% <100.00%> (ø)

pytomorrowio/const.py
92.17% <100.00%> (+0.20%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8407d8...9ce2743. Read the comment docs.

I sent a tomorrow.io support request with the following message
It looks like the V4 API started returning status code 206 today which is a breaking change for our application. We can obviously change our application to handle that, but I don't see any documentation regarding this change. It would be great if we could register to receive notification of API changes before they happen to avoid breaking our application in the real world.

Restarted HA again with 0.3.4 already installed and it started to work after 5 minutes. My guess that something has changed again on the API side:

2022-07-20 15:55:30 INFO (MainThread) [homeassistant.setup] Setting up tomorrowio
2022-07-20 15:55:30 INFO (MainThread) [homeassistant.setup] Setup of domain tomorrowio took 0.0 seconds
2022-07-20 15:55:50 DEBUG (MainThread) [homeassistant.components.tomorrowio] Finished fetching Tomorrow.io - Home data in 18.572 seconds (success: False)
2022-07-20 15:55:50 WARNING (MainThread) [homeassistant.config_entries] Config entry 'Tomorrow.io - Home' for tomorrowio integration not ready yet; Retrying in background
2022-07-20 15:57:22 DEBUG (MainThread) [homeassistant.components.tomorrowio] Finished fetching Tomorrow.io - Home data in 4.025 seconds (success: False)
2022-07-20 15:57:42 DEBUG (MainThread) [homeassistant.components.tomorrowio] Finished fetching Tomorrow.io - Home data in 4.420 seconds (success: False)
2022-07-20 15:58:16 DEBUG (MainThread) [homeassistant.components.tomorrowio] Finished fetching Tomorrow.io - Home data in 1.282 seconds (success: False)
2022-07-20 15:58:57 DEBUG (MainThread) [homeassistant.components.tomorrowio] Finished fetching Tomorrow.io - Home data in 0.634 seconds (success: False)
2022-07-20 16:00:18 DEBUG (MainThread) [homeassistant.components.tomorrowio] Finished fetching Tomorrow.io - Home data in 0.702 seconds (success: True)
2022-07-20 16:00:18 INFO (MainThread) [homeassistant.components.sensor] Setting up sensor.tomorrowio
2022-07-20 16:00:18 INFO (MainThread) [homeassistant.components.weather] Setting up weather.tomorrowio


[$4000] Implementing NetSuite Integration in NewDot (shubham1206agra)

This is the bulk amount for the implementation of the project for @shubham1206agra's contribution to https://github.com/Expensify/Expensify/issues/377671
Amount: $4000
Link to last PR: https://github.com/Expensify/App/pull/44159
cc @zsgreenwald

$4000 approved for @shubham1206agra


Fixed broken example project for trying out fastlane snapshot feature

Checklist

[ ] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[ ] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[ ] I've read the Contribution Guidelines
[ ] I've updated the documentation if necessary.

Motivation and Context
Recently I decided to use fastlane snapshot for the first time. However I encounter the same issue as here: https://github.com/fastlane/fastlane/issues/18722
I tried to use minimal environment to see if it's working with bare minimum and decided to use this documentation:
https://docs.fastlane.tools/getting-started/ios/screenshots/ and clone the test code:
git clone https://github.com/fastlane/fastlane  # Clone the fastlane repo
cd fastlane/snapshot/example                    # Navigate to the example project
fastlane snapshot                               # Generate screenshots for the sample app

However it doesn't even build because the sample code is simply outdated.
Description

Updated Xcode project files to recommended settings
Updated Xcode project to use Swift 5
to be faithful with documentation then I removed the snappy lane and stick with Snapfile
updated test simulators to be iPhone 12 Pro Max and SE (2nd generation) instead of iPhones 6/7

Testing Steps
Just running fastlane snapshot like in documentation to see if I can get screenshots right.

@googlebot I signed it!

Bad e-mails in commits


[FLINK-2871] support outer join for hash join on build side.

There are 4 reserved bytes left in bucket header of MutableHashTable, as there are only 9 elements in each bucket, This PR could use 2 bytes to build a BitSet which is used to mark whether elements in that bucket has been probed during probe phase. After probe phase, return the elements which has not been probed at the end.
As build side outer join is supported, we could support more flexible strategy for left outer join, right outer join and full outer join, new supported join types includes:

left outer join with REPARTITION_HASH_FIRST.
right outer join with REPARTITION_HASH_SECOND
full outer join with REPARTITION_HASH_FIRST or REPARTITION_HASH_SECOND.

But there is still some limitations about broadcast hash join, the following join types are still not supported for obviously reason:

left outer join with BROADCAST_HASH_FIRST.
right outer join with BROADCAST_HASH_SECOND.
full outer join with BROADCAST_HASH_FIRST and BROADCAST_HASH_SECOND.

Thanks for the PR! I will shepherd it.

Hi @ChengXiangLi, very nice PR! Sorry for not reviewing it earlier.
I had only a few minor comments. I did not check the tests yet, but hope to do it in the next days.
Although, I do not expect major performance implications for inner joins, it would be good to check that to be on the safe side.
Have you done any performance regression tests?
Thanks, Fabian

The tests look mostly good.
I would change the HashTableITCase.testHashWithBuildSideOuterJoin2() to process outer join tuples.
Can you explain the rational for the changes in HashVsSortMiniBenchmark?
Thanks, Fabian

I did simple regression test based on HashVsSortMiniBenchmark, the result looks like:

Test
Before
After

testBuildFirst
6.63s
6.65s

testBuildSecond
3.7s
3.8s

The inner join performance is not influenced by this PR, which fit into my expectation. There is a flag called buildsideOuterJoin in MutableHashTable, all the extra effort only happens while buildSideOuterJoin is true.

Thanks for the update and the regression test @ChengXiangLi!
Looks good, only minor changes to do, IMO.

Thanks for the update @ChengXiangLi!
PR is good to merge, IMO.
Do you want to do it yourself?


Cache accessory?

First of all, thank you for this awesome plugin!
I have been trying to use e.g. 2.5 PPM sensor data in my automations. Unfortunately this only works as long as I do not restart Homebridge. After a restart, the 2.5 PPM condition is gone from my automation.
Complete noob here, but as the AirThings View do not appear in Homebridge cached accessories, maybe this is the cause for my automations to stop working after a restart?
If so, would it be possible to cache the devices?

This is likely because I naively originally created this as an accessory plugin instead of a platform plugin, and there doesn't appear to be a way to do caching with accessory plugins. Switching to a platform plugin model would have backward compatibility issues with all existing users. Will keep this issue open to track feedback or upvotes if others are interested in this..


[1.18.2] missing documentation. display name for created items.

examples generate files where all items have name "Custom Item"
CF page have wrong link: https://crafttweaker.readthedocs.io/en/latest/#Mods/ContentTweaker/ContentTweaker/ (The page you were trying to reach could not be found!)
from example:
<factory:item> .typed<Basic>() .tab(examplesTab) .rarity(<constant:minecraft:item/rarity:uncommon>) .build("very_basic_item");
so, how change name form "Custom Item"?

You'll need to add a lang file via a resourcepack. Folder structure for the Lang file would be as followed,
assets - contenttweaker - lang - en_us.json
Then within that file to name for instance very_basic_item, you would use
"item.contenttweaker.very_basic_item": "This is now named"
As for a block you would use
"block.contenttweaker.custom_block":  instead of item and for creative tabs it would be "ItemGroup.examplesTab":


[feedback] Simplify development environment/contributing docs

From @aberba on January 31, 2017 12:53
Devs new to workflow (including me) would want to know how to set it up locally for testing before deploying to cloud (staging, testing).
Copied from original issue: deis/workflow#718

From @aberba on January 31, 2017 18:37
Yeah, pretty much. But process of setting a local deployment is really cumbersome.

From @bacongobbler on January 31, 2017 15:5
It's probably out of date, but there is documentation available: https://deis.com/docs/workflow/contributing/development-environment/
Does that help?

From @bacongobbler on January 31, 2017 19:12
Can you elaborate more on that? What can be done to make it less cumbersome? What makes local development cumbersome for you? I need feedback if I'm going to improve anything :)

From @aberba on February 1, 2017 14:48
It involved a long process to det it up. May be an installation script to bundle all dependencies up. Deis is supposed to be easy to set up without knowing kubernetes configurations.


[StateCodelab] TodoViewModel.todoItems should be val, not var with private setter

It's never assigned outside initialization. The codelab oddly emphasizes the var with private setter, when it should actually be val. I do not see a conceptual reason for making it var.

Thank you for flagging this issue! We've replaced this version of the StateCodelab.


ISPN-12684 Lazy start SearchMapping for protobuf caches

https://issues.redhat.com/browse/ISPN-12684

Marking as preview to let CI run

Fixed tests, ready for review

Merged ,thanks


Fix bug about accessing model.config when model is None in pipeline

What does this PR do?

This PR fixes the issue mentioned in #297: when instantiating a pipeline with pipe = pipeline(task=my_task), the given model is None and we get the following error:
Traceback (most recent call last):
  File "test_yolos.py", line 3, in <module>
    classifier = pipeline(task="zero-shot-classification", accelerator="ort")
  File "/home/regis/HuggingFace/dev/tmp_venv/lib/python3.8/site-packages/optimum/pipelines.py", line 113, in pipeline
    load_tokenizer = type(model.config) in TOKENIZER_MAPPING or model.config.tokenizer_class is not None
AttributeError: 'NoneType' object has no attribute 'config'

With this PR, model.config is not accessed anymore to set load_tokenizer and load_feature_extractor. Tests have been added to automatically check this behaviour.
Also:

the current version number is bumped,
we were using the pipeline method from Transformers in tests/onnxruntime/test_modeling.py, this is changed for the pipeline method of Optimum.

Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Added relevant objects

Added objects for storing_food and putting_leftovers_away tasks.

Nice! Have you confirmed this allows oracle to solve our two tasks locally?

Yes, I have now.


Sass file bug

The boilerplate has a bug in the sass file - if you try to run gulp right after install, you'll get a sass compile failure. After some debugging I found that it's
Error: styles/modules/_alerts.scss
Error: ".alert-help" failed to @extend "%alert".
       The selector "%alert" was not found.
       Use "@extend %alert !optional" if the extend should be able to fail.
        on line 15 of styles/modules/_alerts.scss

Edit - made a pull request https://github.com/jbutko/AngularJS-Boilerplate/pull/16

Fixed in PR #16 Closing.


Add warning banner

Closes #3426

To affect this change on the beta banner, we will need to update pypi-theme.  PR here:https://github.com/python/pypi-theme/pull/24

@ewdurbin or @di - any chance of a review on this?  It's blocking a PR from a new contributor.

Not clear to me why the tests are failing. Seems the frontend build is failing on travis:
Error in plugin 'sass'
Message:
    warehouse/static/sass/blocks/_notification-bar.scss
Error: Undefined variable: "$brand-color-dark".
        on line 40 of warehouse/static/sass/blocks/_notification-bar.scss
        from line 90 of warehouse/static/sass/warehouse.scss
>>   background-color: $brand-color-dark;


128 | Longest Consecutive Sequence | C++

Longest Consecutive Sequence
Adding new code for Longest Consecutive Sequence in C++
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Cod

Programming Language
Please add/delete options that are not relevant.

[x] C++

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

I want to work on this problem.Please assign it to me.

please assign this problem to me . I am the issue creator.

I have created a PR for this : https://github.com/SHY-Corp/LeetCode-Solutions/pull/343


Laravel 10.x Compatibility

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.
Before merging, you need to:

Checkout the l10-compatibility branch
Review all comments for additional changes
Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

:warning: Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 10. However, you should review these changes to ensure the desired combination of versions are built for your package.

:alembic: Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.
To do so, temporarily add Shift's fork to the repositories property of your composer.json:
{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-disable-floc.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:
{
    "require": {
        "spatie/laravel-disable-floc": "dev-l10-compatibility",
    }
}

Finally, run: composer update


Import React when using JSX

When using JSX, React must be accessible.

Had already committed this to master before seeing this PR


Enable ephemeral message, reply with BlockKit UI, and handling Interactive events

Sample Image

implement Message#replyEphemeral
Ruboty applications can reply message as ephemeral message.
Message#reply Message#replyEphemeral can receive block argument
These methods can handle BlockKit JSON as argument: block.
(experimental) Interactive events of BlockKit can be passed to handlers
This is experimental feature.
BlockKit's interactive events is handled as Ruboty-command: slack_interactive::#{action_id}.
Ruboty handlers can receive them by catching above command.
(experimental) implement Message#delete for ephemeral message interaction
This is experimental feature.
Ruboty message made from BlockKit's interactive events can use delete method.
This is useful to clean up ephemeral message containing BlockKit UI.
It can be used only for ephemeral message.

https://github.com/reproio/ruboty-slack_socket_mode/pull/3
こちらが上位互換的なPRになってしまったのでこちらはCloseしてしまいます。


dependencies issue

Hi, How can I install discord/bottom-sheet?
when i click the link i get an error, (404 - page not found)

solved by adding  "@discord/bottom-sheet": "discord/react-native-bottom-sheet#discord-fork-4.6.1-rngh-v2" to package.json


add ESPHome

https://raw.githubusercontent.com/iobroker-community-adapters/ioBroker.esphomemaster/admin/esphome.png no gettable ..404

RE-CHECK!

Automated adapter checker
ioBroker.esphome

[ ] :heavy_exclamation_mark: [E140] width and height of logo are not equal
[ ] :heavy_exclamation_mark: [E201] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: npm owner add bluefox iobroker.esphome

Add comment "RE-CHECK!" to start check anew

RE-CHECK!

Automated adapter checker
ioBroker.esphome

[ ] :heavy_exclamation_mark: [E140] width and height of logo are not equal
[ ] :heavy_exclamation_mark: [E201] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: npm owner add bluefox iobroker.esphome

Add comment "RE-CHECK!"

Automated adapter checker
ioBroker.esphome

[ ] :heavy_exclamation_mark: [E140] width and height of logo are not equal

Add comment "RE-CHECK!" to start check anew

RE-CHECK!

Automated adapter checker
ioBroker.esphome

[ ] :heavy_exclamation_mark: [E140] width and height of logo are not equal

Add comment "RE-CHECK!" to start check anew

RE-CHECK!
logo fixed, all issue solved

RE-CHECK!

Automated adapter checker
ioBroker.esphome

:thumbsup: No errors found
Add comment "RE-CHECK!" to start check anew

@Apollon77 all solved 👯

Hey, review feedback:

should you encrypt apiPass??
makes that sense? https://github.com/iobroker-community-adapters/ioBroker.esphome/blob/main/admin/index_m.html#L272 ... and honestly with controller 3.2 as dep simply kill all that encrypt/decrypt and use encrypted/protectedNative

rest ok :-)

Hey, review feedback:

should you encrypt apiPass??
makes that sense? https://github.com/iobroker-community-adapters/ioBroker.esphome/blob/main/admin/index_m.html#L272 ... and honestly with controller 3.2 as dep simply kill all that encrypt/decrypt and use encrypted/protectedNative

rest ok :-)

as discussed by. telegram, encryption for API pass implemented other stay on old fashion as I need to store a array of password which cannot be handled with encryptedNative
https://github.com/DrozmotiX/ioBroker.esphome/commit/f94eee808d60f49155be782a9fe05ed052d6f857

RE-CHECK!

Automated adapter checker
ioBroker.esphome

[ ] :heavy_exclamation_mark: [E019] Invalid repository URL: https://github.com/DrozmotiX/ioBroker.esphome. Expected: git+https://github.com/iobroker-community-adapters/ioBroker.esphome.git

Add comment "RE-CHECK!" to start check anew

RE-CHECK!

Automated adapter checker
ioBroker.esphome

:thumbsup: No errors found
Add comment "RE-CHECK!" to start check anew

@Apollon77 password encryption for messaging fixed in 0.1.4
see https://github.com/DrozmotiX/ioBroker.esphome/commit/f1f55e794fb9c96d68e4fd8e9df0c480f7a7294d


added table reports, available through request

Please check if table creation of "reports" is there. It wouldnt show me as a addable file, so probably already there

Checked it, the migration is not added. There is a migration for reports on master but doesn't one doesn't have the same fields as the seeder in this pull request. Building this with db:init will probably crash the app. I'm closing the request for now until it's complete (so a complete working migration).


Round L2G score in Genetic Associations data table

Changes to the pipeline mean that we now get a more precise L2G score, which we display in the Gene Prioritisation Score column in the Genetic Associations (Common Diseases) data table on the evidence page.

Can we please make a change and round the scoring using 6 decimal points?

Issue closed as work completed as part of 20.04 release process


Use date from status, not current date

In previous version of code, the current timestamp was always used, not the date from Status class.
This change fixes this...
P.S. Sorry, that I include previous PR - forgot to do pull before committing my code...

Totally right, @alexott, thanks for paying attention!


[ExoPlayer Downloader] How to map new keySetId (license) to earlier downloaded content

We are trying download and playback of offline content using ExoPlayer Downloader.
Steps which we are following now :

WidevineOfflineLicenseFetchTask / execute (OfflineLicenseHelper/downloadLicense)
"keySetId" returned from above step is saved
Track Selection happens
DownloadRequest is made with "uri" , "keySetId" is also used for DownloadRequest preparation
DownloadRequest prepared in above step is used to call "DownloadService.sendAddDownload" which downloads actual content

-> Now after few days, license gets expired and we want to refresh license without downloading the content again.
There is no "renew" support from our backend so we cannot call "OfflineLicenseHelper/renewLicense".
Instead of that, our backend wants us to download license again.
To do that, we can call "OfflineLicenseHelper/downloadLicense" again, it will return new "keySetId" , but as we would not be initiating step 4 and 5 again, so how can we map this updated "keySetId" to earlier downloaded content ?
Concisely, we want to map new keySetId (license) to earlier downloaded content.

I think you must already have some wiring in your app code to plumb the keySetId into the player when it comes to playing the downloaded content. The demo app does this here:
https://github.com/androidx/media/blob/51622b6d80f5e73734d43b4c0b4fd63902ddb0ff/demos/main/src/main/java/androidx/media3/demo/main/PlayerActivity.java#L565-L568
If you have stored the new keySetId somewhere, then you can simply use that new value at this point instead of the keySetId from the DownloadRequest.

It worked, thats for the help.


who register singleton

Hello i am in doubt how can i register a singleton and if i did it the right way
repository:
singleton()
export default class EmployeeRepository implements IRepository<Employee> {
  private ormRepository: Repository<Employee>;
  constructor() {
    this.ormRepository = getRepository(Employee);
  }
  readAll(): Promise<Employee[]> {
    throw new Error("Method not implemented.");
  }
  readOneById(id: string): Promise<Employee | undefined> {
    throw new Error("Method not implemented.");
  }
  create(data: Employee): Promise<Employee | undefined> {
    throw new Error("Method not implemented.");
  }

}

and service:
@injectable()
export class EmployeeServices {
  constructor(@inject('EmployeeRepository')
  private repository: EmployeeRepository) {
  }

  public create() {
    return `a`
  }
}

controller:

@singleton()
export class EmployeesController {
  readonly routes = Router();
  private services: EmployeeServices;
  constructor() {
    this.services = container.resolve(EmployeeServices)
  }
  public static() {

  }

}

here i register repository  keys on container:
private registerRepositories() {
   let rootDir: string =
     process.env.NODE_ENV === 'development' ? 'src' : 'build/src';
   let pattern: string = rootDir + '/modules/**/repositories/*.{js,ts}';
   glob.sync(pattern).forEach(file => {
     let repository = require(resolve(file)).default;
     let name = repository.name;
     container.register(`${name}`, { useValue: repository });
     console.log(container.isRegistered(name))
   });
 }

I have some questions,
how do I register my singletons (controllers),
as my repository is a singleton, I could just use container.resolver (repository key)
in my service?
I'm a little confused by this

The @singleton decorator registers the class as a singleton against the class itself as the injection token.
In your example, it looks like you want to have string tokens with the repository name; I would suggest not using @singleton() in this case, and changing your registerRepositories() code to use container.registerSingleton(...).
Perhaps a feature could be added to allow @singleton() to take in an injection token. Would you find that helpful?

thank u @Xapphire13


debug: Add Dockerfile for debugging gittuf on Git 2.34.1

This should make life easier when debugging on Git 2.34.1.

I think the current setup is fine.


Project setup

Set up the Project infrastructure
Changes

[x] Deleted most old stuff.
[x] Set up a page with IPFS node.

TODO next

Set up  S3 for react
Build the Redux store

Screenshots (if appropriate)
Checklist

[ ] tested locally
[x] added new dependencies
[x] updated the docs
[ ] added a test

View rendered .github/pull_request_template.md
View rendered CODE_OF_CONDUCT.md
View rendered CONTRIBUTING.md
View rendered CONTRIBUTORS.md
View rendered CORTXTestimonials.md
View rendered Community_Roadmap.md
View rendered CortxFilecoinHackathon22/README.md
View rendered CortxFilecoinHackathon22/cortx2ipfs/README.md

I see that you closed this. It looked interesting! But there was a problem with the PR because it was overwriting a ton of files. The PR should only include the minimal files necessary for your hackathon submission. Thanks!

Hi,
Yes, I closed it since I opened it by accident. I wanted to merge to my
cloned repo, not the original yet!
Best,
Wolf
On Mon, Jun 20, 2022 at 8:07 PM John Bent @.***> wrote:

I see that you closed this. It looked interesting! But there was a problem
with the PR because it was overwriting a ton of files. The PR should only
include the minimal files necessary for your hackathon submission. Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/Seagate/cortx/pull/1557#issuecomment-1160719900, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AGA6ORMD7IEMMFMT7KDWGB3VQCXPVANCNFSM5ZFGGNVQ
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


make the change

Hey @gabrielsuch , made some changes to MAX_RETRIES, it was because it was printing the wrong line. Now it is MAX_ATTEMPTS. I think by default at riq is 2, so you won't need to do any changes, at worst you will have to change the augmented.properties from MAX_RETRIES to MAX_ATTEMPTS

Forgot to bump up the version, I will do it on another branch that is coming


cupy regression + arrow-batching for all funcs

Changes:

Added cupy support to regression
Added arrow batching to all funcs
Added cupy testing for lrm / regression

build

build


Updated grt 1.1.0-rc.5 for #270

This change is

QA PASS
confirmed in 1.0.1
https://deploy-preview-257--tc-create-app.netlify.app/


Forbid duplicate edges in the Graph

Resolves #604 & #580
I was thinking about 2 ways to resolve this:

Maintain the new invariant in the Graph (actually, in GraphOperator) on each operation (add,remove,update etc.)
Maintain the new invariant in the GraphNode

I chose the second alternative and substituted  implementation of nodes_from from standard list to thin subclass UniqueList that forbids duplicate elements. Btw: list is used instead of something like ordered set to preserve standard list interface, and for small lists such as nodes_from it's no less efficient than a set.
Motivation for the second approach:

This for sure prevents us from future bugs related to duplicate edges. otherwise on each change to Graph or its subclasses we must remember about its invariants. It's difficult to enforce.
Trying to maintain the new invariant on Graph level requires a lot of scattered changes, that complicates core logic of graph methods. GraphNode is essential part of Graph, so that's natural that it bears responsibility for Graph invariants. Anyway, I see no sense to allow storing duplicate elements in node.nodes_from.
It also somewhat hides implementation details of GraphNode (that we use a list underneath)

Hello @gkirgizov! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file fedot/core/dag/graph_operator.py:

Line 230:26: E701 multiple statements on one line (colon)
Line 232:1: W391 blank line at end of file

In the file fedot/core/dag/unique_list.py:

Line 11:32: E251 unexpected spaces around keyword / parameter equals
Line 11:34: E251 unexpected spaces around keyword / parameter equals
Line 39:1: W391 blank line at end of file

In the file test/unit/dag/test_unique_list.py:

Line 12:56: E231 missing whitespace after ','
Line 12:93: E231 missing whitespace after ','
Line 13:50: E231 missing whitespace after ','
Line 13:87: E231 missing whitespace after ','
Line 33:17: E231 missing whitespace after ','
Line 33:19: E231 missing whitespace after ','
Line 33:21: E231 missing whitespace after ','
Line 33:23: E231 missing whitespace after ','
Line 33:25: E231 missing whitespace after ','
Line 33:27: E231 missing whitespace after ','
Line 33:29: E231 missing whitespace after ','
Line 33:31: E231 missing whitespace after ','
Line 38:13: E231 missing whitespace after ','
Line 38:15: E231 missing whitespace after ','
Line 38:17: E231 missing whitespace after ','
Line 38:19: E231 missing whitespace after ','
Line 38:21: E231 missing whitespace after ','
Line 38:23: E231 missing whitespace after ','
Line 38:25: E231 missing whitespace after ','
Line 38:27: E231 missing whitespace after ','


node usage vs. entitlements/api

PR: https://github.com/rancher/csp-adapter/pull/3

https://github.com/rancher/csp-adapter/pull/4

See internal test plan.


Access to method Children

Hi Pedro,
there's a way to get this working?:
$page->children()->find('contact-info')->email()
I can't access to this field using children()->find().
Thanks for the great plugin!

This would only work if every page on your website had a contact-info child page. Have you tried page('contact-info')->email()?

Thanks for your reply, the code is something like this:
c::set('meta-tags.templates', function(Page $page, Site $site) {
    return [
        'gym' => [
	    'json-ld' => [
	         'ExerciseGym' => [
			'name' => 'whatever '. $page->title()->value(),
			'image' => $page->image($page->briefImage())
					? $page->image($page->briefImage())->url()
			                 : site()->images()->sortBy('sort', 'asc')->first()->url(),
			 'url' => $site->url(),
			 'telephone' => $page->children()->find('contact-info')->tel(),
		  ]
	    ]
        ]
    ];
});

As you say I tried to access with method page('some-page') but does not work as well.
It seems imposible to work with children and page methods.
$page->title()->value() is working fine.

Please try: page('contact-info')->tel()->value()

Under the hood the plugin used json_encode to generate the JSON-LD markup. Kirby fields are Field objects and need to be converted to string before, that's what the value() method does, it converts the object to string.


Wip 222 replication failure detail reporting

@volkerstampa with the last commit, I limited exception serialization to subclasses of ReplicationReadException.


XVI images not placed in the correct position

XTherion embeds XVI graphics into TH2 files using special comment formats. Example:
encoding  utf-8
##XTHERION## xth_me_area_adjust -128.0 -128.0 2726.4199999999996 1939.02
##XTHERION## xth_me_area_zoom_to 100
##XTHERION## xth_me_image_insert {1063.0 1 1.0} {1102.3600000000001 3a} elev1.xvi 0 {}

This apparently means that station 3a should be placed at (1060, 1102).
Significant work needed to implement.

Looking at some of my xvi files and how they are inserted by XTherion into th2, your deduction on xvi placement appears correct.  Related information available in #1

@CaverBruce can you please check if this works for you, afterwards we can close the issue.
I haven't had a lot of time so I didn't work on this sooner, sorry.

Looks like you've nailed it.  I just loaded a moderately complex th2 (3000+ lines, 7 scraps and 4 xvi).  It is super fast and the xvi colours are clearly rendered (unlike XTherion).  I took it through an OtherExports.DownloadSave to json, then imported the resulting json (Import.JSON) and then exported to th2.
The imported document looks good in WTherion, but git shows a reasonable difference in the th2 file.  The th2 file will not open in XTherion, probably because the th2  ##XTHERION## headers are missing.
I have a lot of annoying finicky comments to work through, I will post them as separate issues.  I don't seem to be able to close this one, so I'll leave it to you.
I don't consider your response slow, sometimes life holds treasures more than cave software.  Take your time.

Okay, since this part is working I'm closing the issue.


Screen rotation should keep position in message

Expected behavior
While reading a message any screen rotation should keep the reading position in the message body.
Actual behavior
Currently the text view jumps to the first line after any screen rotation.
Steps to reproduce

Open text message with more than one screen of text
Scroll to the end or any other position in the message body
Change screen orientation: vertical to horizontal
Scroll to end again
Change screen orientation: horizontal to vertical

Environment
K-9 Mail version: 5.010
Android version: 5.1.1
Account type (IMAP, POP3, WebDAV/Exchange):
any

Developer notes:
I suspect this ought to be possible by retaining the compute_ScrollOffset/compute_ScrollRange proportions and re-applying them to the opposite axis.
For example if the vertical scroll offset / vertical range was 1/3, when the re-orient is performed, set the new horizontal offset to 1/3 of the new horizontal range.

I noticed the same problem in 5.205
It's fairly annoying if your reading a long mail and every time you lay down the device for a moment it rotates and you have to find your reading position again.
I could lock the rotation... but it would be nice if k9 could handle this.
I grepped through the source and could not find any mention of ScrollOffset or ScrollRange

+1 issue is still valid and still annoying ;)

PR #2787 is a first attempt to deal with this issue.
@philipwhiuk I am using getScrollY/getContentHeight instead of ScrollView.computeVerticalScrollOffset/...Range, since the description of the latter is a quite focused on the scrollbar and the position of its thumb. However, I'd change that, if desired.

$15 bounty on bountysource


Not correct working with views

System information:

Operating system (distribution) and version
Linux Mint, Windows 10
DBeaver version
<IP_ADDRESS>104042040
Additional extensions
No

Connection specification:

Database name and version
Oracle 10 (maybe the same in Postgres 13)
Driver name
Standard (from maven)
Do you use tunnels or proxies (SSH, SOCKS, etc)?
No

Describe the problem you're observing:

If there is a view with comments (for the main object and columns), there is not correct working due "Save view".
There is no saving.
Sometimes comments will be lost.

Steps to reproduce, if exist:

Create a view
Add comments to a view and its columns.
Try to change a view.

Include any warning/errors/backtraces from the logs

could you check if it reproducible for you against 21.1.1?


[Fixes #1536] Added activation tests for tag helpers

@NTaylorMullen

@pranavkm @dougbu can you take a look?

Updated.

:shipit:

:shipit:


Report got generated by command but not from Grafana (public IP, SSL)

@IzakMarais Just trying to understand whether this is an issue or my wrong setup...
I am running Grafana and Reporter as dockers in VM in MS azure (SSL) and issuing command within reporter docker work just fine, see below.
root@47cb4834c409:/# grafana-reporter -proto=https:// -cmd_enable=1 -cmd_apiKey MYIPKEY -ip ms.azure.device.com:443 -cmd_dashboard ybG8WXyZz -cmd_ts from=now-12h -cmd_o out2.pdf
2020/02/02 19:01:54 grafana reporter, version: 2.3-1 hash: 6cfc3e220dc4f8fc0175ae0ec8698d35546d8c10
2020/02/02 19:01:54 serving at ':8686' and using grafana at 'https://ms.azure.device.com:443'
2020/02/02 19:01:54 SSL check enforced
2020/02/02 19:01:54 Using sequential report layout. Consider enabling 'grid-layout' so that your report more closely follow the dashboard layout.
2020/02/02 19:01:54 Called with command line mode enabled, will save report to file and exit.
2020/02/02 19:01:54 Called with command line mode 'dashboard' 'ybG8WXyZz'
2020/02/02 19:01:54 Called with command line mode 'apiKey' 'MYIPKEY'
2020/02/02 19:01:54 Called with command line mode 'apiVersion' 'v5'
2020/02/02 19:01:54 Called with command line mode 'outputFile' 'out2.pdf'
2020/02/02 19:01:54 Called with command line mode 'timeSpan' 'from=now-12h'
2020/02/02 19:01:54 Reporter called
2020/02/02 19:01:54 Called with api Token: MYIPKEY
2020/02/02 19:01:54 Called without variable
2020/02/02 19:01:54 Called with dashboard: ybG8WXyZz
2020/02/02 19:01:54 Called with time range: {now-12h now}
2020/02/02 19:01:54 Connecting to dashboard at https://ms.azure.device.com:443/api/dashboards/uid/ybG8WXyZz
2020/02/02 19:01:54 Populated dashboard datastructure: {Title:Dashboard 1 Description: VariableValues: Rows:[] Panels:[{Id:73 Type:table Title:Last Status (3 days window) GridPos:{H:5 W:12 X:0 Y:0}} {Id:60 Type:grafana-piechart-panel Title: GridPos:{H:9 W:6 X:12 Y:0}} {Id:68 Type:graph Title: GridPos:{H:9 W:6 X:18 Y:0}} {Id:18 Type:graph Title:OEE trend GridPos:{H:6 W:12 X:0 Y:5}} {Id:4 Type:gauge Title: GridPos:{H:4 W:4 X:12 Y:9}} {Id:6 Type:gauge Title: GridPos:{H:4 W:4 X:16 Y:9}} {Id:15 Type:singlestat Title:Good Units GridPos:{H:2 W:4 X:20 Y:9}} {Id:71 Type:singlestat Title:Rejected Units GridPos:{H:2 W:4 X:20 Y:11}} {Id:39 Type:singlestat Title:Machine Available Time GridPos:{H:2 W:4 X:12 Y:13}} {Id:44 Type:singlestat Title:Expected Units GridPos:{H:2 W:4 X:16 Y:13}} {Id:58 Type:graph Title:Quality Trend GridPos:{H:5 W:4 X:20 Y:13}} {Id:12 Type:singlestat Title:Machine Running Time GridPos:{H:2 W:4 X:12 Y:15}} {Id:43 Type:singlestat Title:Produced Units GridPos:{H:2 W:4 X:16 Y:15}} {Id:72 Type:graph Title:Availability Trend GridPos:{H:5 W:4 X:12 Y:17}} {Id:13 Type:graph Title:Machine Cycle Time Trend GridPos:{H:5 W:4 X:16 Y:17}}]}
2020/02/02 19:01:54 Downloading image  73 https://ms.azure.device.com:443/render/d-solo/ybG8WXyZz/_?from=now-12h&height=500&panelId=73&theme=light&to=now&width=1000
2020/02/02 19:01:54 Downloading image  60 https://ms.azure.device.com:443/render/d-solo/ybG8WXyZz/_?from=now-12h&height=500&panelId=60&theme=light&to=now&width=1000
2020/02/02 19:01:54 Downloading image  68 https://ms.azure.device.com:443/render/d-solo/ybG8WXyZz/_?from=now-12h&height=500&panelId=68&theme=light&to=now&width=1000
2020/02/02 19:01:54 Downloading image  18 https://ms.azure.device.com:443/render/d-solo/ybG8WXyZz/_?from=now-12h&height=500&panelId=18&theme=light&to=now&width=1000
2020/02/02 19:01:54 Downloading image  4 https://ms.azure.device.com:443/render/d-solo/ybG8WXyZz/_?from=now-12h&height=500&panelId=4&theme=light&to=now&width=1000
2020/02/02 19:02:03 Downloading image  6 https://ms.azure.device.com:443/render/d-solo/ybG8WXyZz/_?from=now-12h&height=500&panelId=6&theme=light&to=now&width=1000
2020/02/02 19:02:06 Downloading image  15 https://ms.azure.device.com:443/render/d-solo/ybG8WXyZz/_?from=now-12h&height=150&panelId=15&theme=light&to=now&width=300
2020/02/02 19:02:13 Downloading image  71 https://ms.azure.device.com:443/render/d-solo/ybG8WXyZz/_?from=now-12h&height=150&panelId=71&theme=light&to=now&width=300
2020/02/02 19:02:15 Downloading image  39 https://ms.azure.device.com:443/render/d-solo/ybG8WXyZz/_?from=now-12h&height=150&panelId=39&theme=light&to=now&width=300
2020/02/02 19:02:16 Downloading image  44 https://ms.azure.device.com:443/render/d-solo/ybG8WXyZz/_?from=now-12h&height=150&panelId=44&theme=light&to=now&width=300
2020/02/02 19:02:17 Downloading image  58 https://ms.azure.device.com:443/render/d-solo/ybG8WXyZz/_?from=now-12h&height=500&panelId=58&theme=light&to=now&width=1000
2020/02/02 19:02:23 Downloading image  12 https://ms.azure.device.com:443/render/d-solo/ybG8WXyZz/_?from=now-12h&height=150&panelId=12&theme=light&to=now&width=300
2020/02/02 19:02:23 Downloading image  43 https://ms.azure.device.com:443/render/d-solo/ybG8WXyZz/_?from=now-12h&height=150&panelId=43&theme=light&to=now&width=300
2020/02/02 19:02:28 Downloading image  72 https://ms.azure.device.com:443/render/d-solo/ybG8WXyZz/_?from=now-12h&height=500&panelId=72&theme=light&to=now&width=1000
2020/02/02 19:02:29 Downloading image  13 https://ms.azure.device.com:443/render/d-solo/ybG8WXyZz/_?from=now-12h&height=500&panelId=13&theme=light&to=now&width=1000
2020/02/02 19:02:35 Calling LaTeX - preprocessing
2020/02/02 19:02:35 Calling LaTeX and building PDF
2020/02/02 19:02:35 Extracted filename from dashboard title:  Dashboard 1.pdf
2020/02/02 19:02:35 Report generated correctly

But I am not able to use as link in Grafana dashboard, when using command as below just getting page not found.
Do I need to strcture the link differently ? Do I missing arguments in the link ? When it is working within docker with external / public IP ms.azure.device.com:443 I expect that this should work from Grafana ?
https://ms.azure.device.com:443/api/v5/report/ybG8WXyZz?apitoken=MYIPKEY

If you want to link to the report from Grafana, you need to run the reporter in the standard http web server way, not using the "Command line mode".

@IzakMarais thanks for reply.
Command line was just to test if reporter is able to connect to HTTPS IP and generate report. It is able to connect to HTTPS and generate one, not sure if command line is connecting from outside (public network) or inside network (within VM).
2020/02/02 19:01:54 Connecting to dashboard at https://ms.azure.device.com:443/api/dashboards/uid/ybG8WXyZz
When using link in grafana seems like service is not available.
How to troubleshoot where is the problem ? command line generate the report but when use a link like no service running. Network / firewall issue ?
My https web server is running in VM ms azure using public IP and NGINX Reverse Proxy.
$ sudo docker container ps -a
CONTAINER ID        IMAGE                         COMMAND                  CREATED             STATUS              PORTS                    NAMES
47cb4834c409        izakmarais/grafana-reporter   "/usr/local/bin/graf…"   37 hours ago        Up 37 hours         <IP_ADDRESS>:8686->8686/tcp   exporter
029304e4013b        grafana/grafana               "/run.sh"                5 days ago          Up 44 hours         <IP_ADDRESS>:3000->3000/tcp   grafana
189d6517cfa3        influxdb                      "/entrypoint.sh -con…"   2 weeks ago         Up 38 hours         8086/tcp                 influxdb
$

I made it working by running however not secure way :(
aqmp@aqmp:~$ sudo docker run --net="host" izakmarais/grafana-reporter
2020/02/04 09:31:14 grafana reporter, version: 2.3-1 hash: 6cfc3e220dc4f8fc0175ae0ec8698d35546d8c10
2020/02/04 09:31:14 serving at ':8686' and using grafana at 'http://localhost:3000'
2020/02/04 09:31:14 SSL check enforced
2020/02/04 09:31:14 Using sequential report layout. Consider enabling 'grid-layout' so that your report more closely follow the dashboard layout.
2020/02/04 09:31:40 Reporter called
2020/02/04 09:31:40 Called with api Token: MYIPKEY
2020/02/04 09:31:40 Called without variable
2020/02/04 09:31:40 Called with dashboard: ybG8WXyZz
2020/02/04 09:31:40 Called with time range: {now-1h now}
2020/02/04 09:31:40 Connecting to dashboard at http://localhost:3000/api/dashboards/uid/ybG8WXyZz

By using that I am skipping HTTPS and connecting to reporter via HTTP which is security door to my server. Do you know how to make it work with https ?
This link is working and generate report:
http://ms.azure.device.com:8686/api/v5/report/ybG8WXyZz?apitoken=MYIPKEY
I need the link to be
https://ms.azure.device.com:8686/api/v5/report/ybG8WXyZz?apitoken=MYIPKEY

It is matter of setting up docker network correctly rather than reporter or reporter issue


Describe and architect an QUIC state machine

Reference:

RFC 9001
RFC 9000
RFC 8446
RFC 9002
Cromium reference
RFC 9308
QUIC LB
QUIC ACK

Based to RFC 9000:
CLIENT-STREAM-FLOW:

SERVER-STREAM-FLOW:

TLS Interface Summary:

RFC 9221 informing about UDP datagrams, which work under QUIC


datasets missing file or folder

datasets missing file or folder

Instructions about the data can be found here: https://github.com/AristotelisPap/Question-Answering-with-BERT-and-Knowledge-Distillation/tree/main/Knowledge_Dist


TreeChop works in creative, but will revert back to vanilla chopping in survival.

I have tried changing all the configs and can't seem to find a fix, I can send my modlist if it helps, however it is extensive.

Hey, sorry about that. Some questions:

What minecraft and treechop versions are you using?
Have you tried respawning?

If not on a server, have you tried deleting treechop-common.toml?

One of your log files should show your mod list, I don’t remember which one though. If you can find one, just upload the file

Found out it was an incompatibility with MultiMine.

Ah yeah, that’ll do it. Adding log blocks (or just treechop:choppables) to multimine’s blacklist should fix it.

Closing as duplicate of #106


ShardGroups() supports returning all ShardGroups

With this change the function would support the following forms:
ShardGroups()
ShardGroups("mydb")
ShardGroups("mydb", "myrp")

This will make it easier to code stuff like DROP SHARD GROUP.

Any objection to this change @corylanou @benbjohnson
If not, I will add more unit testing to ensure implementation is correct. Right now I am concerned about style.

I'm not crazy about that style because a caller has to read the code to know what to pass in to the function.  I prefer the explicit parameters.

That's fair.
Same with make though, right? :-)

The alternative is something like AllShardGroups() which is uhh. Any other ideas?

golang's builtins have spurred more than a few debates.  :)
ShardGroups could be written to accept empty strings for either parameter and then AllShardGroups() could just call ShardGroups("", "")`.
No strong feelings either way on this one function but I would be opposed to widespread use of that style.  I worked on some Go code, before InfluxDB, that someone else wrote that used that style a lot.  I found the code harder to understand and had to fix a few bugs related to it.
Whatever Cory & Ben vote works for me on this one though.

Yeah I did consider using "","" as the params. I just like the vargs.
Open to consensus.
On Monday, November 9, 2015, dgnorton<EMAIL_ADDRESS>wrote:

golang's builtins have spurred more than a few debates. :)
ShardGroups could be written to accept empty strings for either parameter
and then AllShardGroups() could just callShardGroups("", "")`.
No strong feelings either way on this one function but I would be opposed
to widespread use of that style. I worked on some Go code, before InfluxDB,
that someone else wrote that used that style a lot. I found the code harder
to understand and had to fix a few bugs related to it.
Whatever Cory & Ben vote works for me on this one though.
—
Reply to this email directly or view it on GitHub
https://github.com/influxdb/influxdb/pull/4731#issuecomment-155280341.

I'm with @dgnorton on this one.  This doesn't feel like a good use of vargs based on what I typically see them used for.  Named parameters work best here.  My rule is how would GoDoc be able to explain a function if you didn't write a comment, and in this case it can't, so it's not ok.

OK, good enough @corylanou @dgnorton -- I will try another approach.
Thanks for the feedback.


Add $message parameter to TestCase::assertEqualsWithoutLE()

This allows to set custom error message in assertEqualsWithoutLE()
This third parameter is already used in some tests, even if it was not supported until now :P:
https://github.com/yiisoft/yii2/blob/ba0a3c00ca36a26f2f34b09d31230e4d83bd831e/tests/framework/mail/BaseMailerTest.php#L273-L274

Merged. Thanks!


Fix "playlist options" welcome message for new users

as seen from the image above the dismiss button on the welcome message doesnt work. i already fixed this but it was lazily fixed by commenting the code. would like to improve

best way to reproduce the issue is by using incognito mode on chrome and clearing browsing data (in incognito mode, not regular chrome)

can also run js in console to reset:
window.localStorage['first_visit'] = 'true';

can also run js in console to reset:
window.localStorage['first_visit'] = 'true';

Fixed by commits in #42


Problem with nightvision

the screen becomes light blue

the minecraft screenshot (F2) didn't show the blue

I will check it out

Should be fixed next release


Update android gradle plugin to add support for Android 11

When build app for Android, it throws an error unexpected element <queries> found in <manifest>
for more info you can check here

Thanks for your contribution!


Move mandatory inlining cleanup to mandatory combine

This patch makes MandatoryInlining a SILModuleTransform instead of a SILFunctionTransform. It also moves the function removal cleanup to MandatoryCombine so that it will be run on every function. This is better because then we don't have to iterate over every function in a module twice in MandatoryInlining. And now, both can remain a SILFunctionTransform. It also has the benefit of allowing MandatoryCombine to exit early sometimes.
The successor to #28394.

cc @gottesmm

This is the wrong way to do this. What we want to do is move stuff into the mandatory combiner since it runs after diagnostics. That way we can make it easy for SourceKit to not run this sort of code.

I re-wrote this patch fixing most of the issues that you brought up. I removed changes to MandatoryCombine. I'll either add those to this patch later or add them in another patch.
The basic flow of this pass is now:

Collect apply instructions.
Try to devitalize applys.
Iterate over every apply and try to inline it. Otherwise, continue.
Add the apply's callee to the pass manager worklist so it will also try to be inlined (instead of trying to inline it recursively).
If any functions were inlined, add them to the worklist as well so the now-dead functions can be removed.

The recursive inlining is now removed. All mandatory inlining tests pass (assuming I ran the right tests).
There are still a few things I want to clean up (see TODOs). I'll probably fix those in a different patch, though.

So I was thinking about this a little bit. We need to do this differently/split this up. Here is my suggestion:

Why don't we create a separate PR that just moves cleanup code (and leaves everything else the same). This would mean eliminating the code in cleanup callee and moving that to the Mandatory Combiner. No passes should be moved around, it should just require having the mandatory inliner not cleaning up after itself and leaving that later for the mandatory combiner.

There is more complexity here around the pass manager. I can explain it in more detail offline, but I think that this may be a bit more complex than a simple cleanup. Maybe we do 1 in the short term and then circle back around to this?

@gottesmm, that sounds good to me.
I'll look into making a cleanup patch. I'm not 100% sure the cleanup done here is necessary, though. I think the mandatory combiner might already handle this. I'll double-check and make a patch if not.
I would also be interested to learn more about the pass manager. Feel free to reach out to me whenever (no rush, though, I'm sure you're busy).

Closing for now. Might reopen later.


Consider supporting root-datasource credentials configuration for some of the databases

Feature description
Some of the databases preconfigure additional admin/root credentials.
Sometimes it's decided to alter user's permissions before the test runs.
Example for MySQL to do modifications with the access to the container:
        Driver instance = container.getJdbcDriverInstance()
        def url = container.getJdbcUrl()
        final Properties info = new Properties()
        info.put("user", "root")
        info.put("password", container.getPassword())
        try (Connection connection = instance.connect(url, info)) {
            connection.createStatement().execute('''GRANT ALL PRIVILEGES ON *.* TO 'test'@'%' WITH GRANT OPTION;''')
        }

It looks like MySQL and MariaDB will have an additional user with a username "root" and the same password.
OracleDB testconainer also sets the same password, but I'm not sure with username is used, maybe "system".
The idea would be to have some convention:
datasources:
   root-default:
      db-type: xyz

or:
datasources:
   default:
      db-type: xyz
      db-admin: true

Can't this be done with an init script?

Nope, it looks like the init is running using the user credentials

There are probably different ways we can support this:

the hard way. For each DB, expose configuration properties and implement queries ourselves. This is more or less the idea exposed in your issue, I think.
provide an extension mechanism which lets the user do something with the container before or after it is started. It is more generic, but requires a simple way to expose such customizations. With Gradle that's easy since we already have the testResources source set, but for Maven it's still a bit painful. I would prefer such a solution though, since it's more generic.
add scripting support to the server, so that we can run Groovy (or Kotlin) scripts (we can even support Java if we compile the class ourselves in the test resources service) where the context is the container. This is a lightweight version of 2. The biggest drawback is that this would prevent the test resources service to run in native mode (however, I don't think it's a big deal since we're FAR from being able to do so, since running Testcontainers natively is quite hard)

I would be keen on deferring support for this until we have a clear idea where we want to go.


EngineResult

plumb through some job info like job_id and job_finished_time.
cc @maffoo

thanks for the review @dstrain115 and @maffoo . As a draft PR, just wanted to provide early insight into what sublassing Result would look like inside cirq_google. If the overall strategy looks good, I'll flesh out the PR with all the usual niceties

@maffoo @dstrain115 ptal; this now is based on top of #5274 and only includes the EngineResult changes.

A lot of the test changes are putting in an update_time to the mocked quantum jobs.
@wcourtney can you verify that completed jobs will always have this field supplied?


SpinBox immediately clears contents after losing focus

Godot version:
2cfc5b868
OS/device including version:
Manjaro 20.1 KDE
Issue description:

Steps to reproduce:

Try to input numbers into the SpinBox (Typing, Arrows, etc.)
Apply the change (Enter, Focus Change, etc.)

Minimal reproduction project:
Test1.zip

Fixed in 7844775 (master) and 8a66ea7 (3.2)
Awesome job Akien! :smile:


Custom transcoding profiles

It would be awesome if you could specify custom ffmpeg arguments, that are used for the transcoding process.
For example, so I can have a 720p version with 5.1 audio support, that doesn't sound rubbish.

I have never tested multichannel audio, but you can modify the profiles here, mount them (-v $PWD/ffmpeg_profiles:/templates/ffmpeg_profiles) or build a new Docker image with your changes.
Good luck!

nice to hear and really cool! 😄  best thanks for the feedback


Allow to undock the sidebar into a new window

At work I can only use a small screen, and I need the explorer view always open.
The matter is that keeping it opened leaves very small place for actual code.
So I started looking for a undocking option, but I found out that there's none.
I'd really love to be able to switch between explorer and code in two different windows (just like I do, for example, with Chrome and Chrome Debugger).
(I don't know how to add tags to the request, I wanted to use explorer-files, feature-request, ux)
Thanks!

https://github.com/Microsoft/vscode/issues/10121


ANCHOR-227: Fix incorrect asset

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
Fix asset being set incorrectly when quote is null
Why
Bug fix
Known limitations
N/A

Something went wrong with PR preview build please check

@Ifropc Please create a release branch from main-1.2 for the fixes.
https://github.com/stellar/java-stellar-anchor-sdk/issues/806

Something went wrong with PR preview build please check

@Ifropc Please create a release branch from main-1.2 for the fixes. Issue #806 is created.

Done

Reference Server Preview is available here:https://anchor-ref-pr805.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr805.previews.kube001.services.stellar-ops.com/


Updating version of grunt-sass to fix compiling error

Build of international site is failing:
 DEBUG [8ed474a1]     Loading "sass.js" tasks...
 DEBUG [8ed474a1]     ERROR
 DEBUG [8ed474a1]     >> Error: `libsass` bindings not found. Try reinstalling `node-sass`?
 DEBUG [8ed474a1]     Warning: Task "sass:prod" not found. Use --force to continue.
 DEBUG [8ed474a1]
 DEBUG [8ed474a1]     Aborted due to warnings.

I think this is due to an outdated version of grunt-sass

@blisteringherb wait, what do you mean re: possibly blocking Phoenix deploys in the future? Wanna make sure I understand before I merge!

@mirie I was thinking that we haven't tested it to see if the old versions of Sass are needed in some way for the current Phoenix deploys and whether making this change will break those deploys. It's probably unlikely, but just mentioning it, and we can cross that bridge when we get to it. This is most likely also broken in those deploys as well.

Ah, I see - Looking at package.json on dev branch: https://github.com/DoSomething/phoenix/blob/dev/lib/themes/dosomething/paraneue_dosomething/package.json
Looks like that package is no longer being used. International is pretty outdated


Create Candlestick model CRUD

Attributes:

id
open
high
low
close
volume
timestamp
currency_pair_id
created_at

We can maybe work only in the GET endpoints for now.


fix: add items key for objc

Description

add ClickstreamItemKey for Objective-C API

General Checklist

[x] Added new tests to cover change, if needed
[x] Build succeeds using Swift Package Manager
[x] All unit tests pass
[ ] Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
[x] Documentation update for the change if required
[x] PR title conforms to conventional commit style
[ ] If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (648f658) 95.50% compared to head (f3dd659) 95.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   95.50%   95.50%
=======================================
  Files          35       35
  Lines        1937     1937
=======================================
  Hits         1850     1850
  Misses         87       87

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Set up for development

I'd like to set the project up for development, so I can send some pull requests regarding the issues I've opened, so I don't have to bother you too much :).
However, I'm having some troubles with running npm run start after npm install:
❯ npm run start

><EMAIL_ADDRESS>start /Users/Jan/Projects/OpenSource/react-input-range
> gulp run

[11:44:34] Requiring external module babel-core/register
module.js:338
    throw err;
          ^
Error: Cannot find module '/Users/Jan/Projects/OpenSource/react-input-range/build/react-input-range'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.require.resolve (module.js:388:19)
    at Object.<anonymous> (/Users/Jan/Projects/OpenSource/react-input-range/tasks/config.js:48:15)
    at Module._compile (module.js:460:26)
    at normalLoader (/Users/Jan/Projects/OpenSource/react-input-range/node_modules/babel-core/lib/api/register/node.js:199:5)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/Jan/Projects/OpenSource/react-input-range/node_modules/babel-core/lib/api/register/node.js:216:7)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)

npm ERR! Darwin 15.0.0
npm ERR! argv "node" "/usr/local/bin/npm" "run" "start"
npm ERR! node v0.12.7
npm ERR! npm  v2.11.3
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: `gulp run`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'gulp run'.
npm ERR! This is most likely a problem with the react-input-range package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     gulp run
npm ERR! You can get their info via:
npm ERR!     npm owner ls react-input-range
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/Jan/Projects/OpenSource/react-input-range/npm-debug.log

Also npm run build brings up the same error.
And one more question: Could you be so kind to tell me how to install scss_lint locally in the project folder? I've installed it through sudo gem install scss-lint, but npm run test tells me that I don't have scss_lint installed?
Thank you very much!

Try running npm install && bundle install before you run npm start. I assume you have Bundler installed. If not, just gem install bundler before running the aforementioned commands. :) If successful, you should be able to develop locally.

Works perfect now! Wasn't aware of bundler :)


Improve Searching in Linked List

I would like to add a code to improve linear searching in Linked List. Can you assign this issue to me ? @viralvaghela

Added the code #179 , Please review and merge it


Next release ?

Would it be possible to release the new changes and pio pkg publish them ?
Thanks!

Of course, but wouldn't esp32 also be indexed into espressif?

No for ESPIDF projects this is yet another repo. I was more asking of a new tag and new deployment in platformio repo: https://registry.platformio.org/libraries/lewisxhe/XPowersLib

Okay, it has been published. It will be indexed in a moment.

Done .

Thanks a lot :-)
FYI I m working on this project which makes use of the new lilyfo boards and XPower lib and your TinyGSM fork: https://beelance.carbou.me

Cool project, thanks for sharing


Can we resize the image to specific MB (MegaByte) ?

You can calculate image file size follow this link. For your purpose, you can resize the image or change the bit depth to get the image with your expected file size.


Potential PeerConnection crosstalk

Okay, so I'm operating on #be7bbf0 and I've got a funny problem. I'm creating two simultaneous PeerConnections and it seems like there's some crosstalk. I'll call them pc1 and pc2 for simplicity.
This might be a signalling error. But is there anywhere else I should look?
PeerConnection1 (pc1)
First I do:
pc1.CreateOffer()

And get something like
{"type":"offer",
"sdp":"...
a=candidate:foundation 1 udp<PHONE_NUMBER> <IP_ADDRESS> 60818 typ host generation 0
a=candidate:foundation 2 udp<PHONE_NUMBER> <IP_ADDRESS> 60818 typ host generation 0
a=candidate:foundation 1 udp<PHONE_NUMBER> <IP_ADDRESS> 60101 typ srflx raddr <IP_ADDRESS> rport 60101 generation 0
a=candidate:foundation 2 udp<PHONE_NUMBER> <IP_ADDRESS> 60101 typ srflx raddr <IP_ADDRESS> rport 60101 generation 0
..."}

PeerConnection2 (pc2)
I do something like
pc2.SetRemoteDescription(offer)
ans := pc2.CreateAnswer(nil)
pc2.SetLocalDescription(ans)

And pc2's answer looks something like:
{"type":"answer",
"sdp":"...
a=candidate:foundation 1 udp<PHONE_NUMBER> <IP_ADDRESS> 60607 typ host generation 0
a=candidate:foundation 2 udp<PHONE_NUMBER> <IP_ADDRESS> 60607 typ host generation 0
a=candidate:foundation 1 udp<PHONE_NUMBER> <IP_ADDRESS> 59428 typ srflx raddr <IP_ADDRESS> rport 59428 generation 0
a=candidate:foundation 2 udp<PHONE_NUMBER> <IP_ADDRESS> 59428 typ srflx raddr <IP_ADDRESS> rport 59428 generation 0
..."}

Weird errors from pc1
What's really odd is that I get the following errors from pc1:
ice WARNING: 2019/04/30 15:46:56 discard message from (<IP_ADDRESS>:60607), username mismatch expected(724f4b6f6362657249574967466776483a) actual(724f4b6f6362657249574967466776483a7a4172516653694e70704a437647436c)
ice WARNING: 2019/04/30 15:46:56 discard message from (<IP_ADDRESS>:59428), username mismatch expected(724f4b6f6362657249574967466776483a) actual(724f4b6f6362657249574967466776483a7a4172516653694e70704a437647436c)

This is looking a lot like a signalling issue! Closing until I confirm otherwise.

Hey @rob-deutsch I think you are getting ICE traffic, but you haven't finished signaling yet (is all) this is going to be fixed shortly. We used to implement aggressive ICE, but this was actually deprecated by a later RFC (because of issues like this)
The username mismatch looks like you only have the partial 724f4b6f6362657249574967466776483a is a subset of 724f4b6f6362657249574967466776483a7a4172516653694e70704a437647436c the username is using local+:+remote


Remove reference to nightly version from package.json

We only want to declare the nightly version once in the justfile

Removed


Conditionally enrich context and change it's type for all subsequent midleware.

By far my understanding is that, during middleware chain, Context type is only changed through filters and all middleware must explicitly flavor Context type globally.
But what if I have a middleware which usage only makes sense after some filtering was done and it also modifies the context, extending it's type?
export const enrichContextWithTargetUser = (ctx: Filter<ChatTypeContext<Context, 'supergroup'>, 'message:is_topic_message'>, next: NextFunction) => {
    ctx.targetUser = AppStorage.getUserForThreadId(ctx.message.message_thread_id!);
    // ???
}
bot.chatType('supergroup').on('message:is_topic_message').use(enrichContextWithTargetUser).use(async ctx => {
    ctx.targetUser; // this should be typed properly
}

Some related example from trpc library, where middleware modifies ctx type for all subsequent functions. There, context isn't mutated directly but passed to the next function instead.

But what if I have a middleware which usage only makes sense after some filtering was done and it also modifies the context, extending it's type?

Then this filtering can narrow down the type to a custom, more narrow type by using a type predicate with bot.filter.
Since there are multiple bot.use statements that mutate the bot object's type, we cannot do this any other way. The only solution would be to move away from mutating statements entirely, and use a purely declarative syntax for middleware, but this is much harder to use, looks less familiar, and will generally alienate away newcomers.
People have suggested less explicit ways of changing the bot object, but that's just type casts in disguise so I won't ship that stuff.

Then this filtering can narrow down the type to a custom, more narrow type

Yes I can narrow down middleware input context. But how to properly type context modified by middleware?

Since there are multiple bot.use statements that mutate the bot object's type

Honestly, I didn't understand what do you mean. For me the solution is the matter of adding second  type param to Middleware, adding types to NextFunction and proper typings for use:
use<T extends C>(...middleware: Array<Middleware<C, T>>): Composer<T> {
        const composer = new Composer(...middleware);
        this.handler = concat(this.handler, flatten(composer));
        return composer;
}

But that's may be naive.

Then this filtering can narrow down the type to a custom, more narrow type

Yes I can narrow down middleware input context. But how to properly type context modified by middleware?

Using a type predicate. Look:
const t: Composer<T> = composer.filter((ctx): ctx is T => {
  ctx.prop = value;
  return true;
})

In TypeScript, type predicates always are implicit type casts.

Since there are multiple bot.use statements that mutate the bot object's type

Honestly, I didn't understand what do you mean. For me the solution is the matter of adding second type param to Middleware, adding types to NextFunction and proper typings for use:
use<T extends C>(...middleware: Array<Middleware<C, T>>): Composer<T> {
        const composer = new Composer(...middleware);
        this.handler = concat(this.handler, flatten(composer));
        return composer;
}

This code does not type-check. You will have to add an explicit type cast to the implementation.

But that's may be naive.

It is not. This has been discussed before, and we were considering to introduce bot.cast<T> that simply casts the context type. However, type casting is unsafe, so we should ideally make it as explicit as possible. Adding a new method to hide away the type cast (or---even worse---secretly performing type casts internally in bot.use) increases the chance of bugs, so it simply makes bot code worse.
If you want to perform type casts, simply do them explicitly:
const narrow = (composer as Composer<T>).use(async (ctx, next) => {
  ctx.prop = value;
  await next();
});

Using a type predicate. Look:
Mutating inside filter is by any means ugly, I think you'd agree. But at least thanks for a workaround.

This code does not type-check. You will have to add an explicit type cast to the implementation.
I don't think so. My assumption is that we can add second type to middleware and type NextFunction properly. Again, have you checked the link I provided? Can it possibly be implemented the way they did?

or---even worse---secretly performing type casts internally in bot.use
Why secretly? It's inferred, yes, but without dirty tricks.

Using a type predicate. Look:

Mutating inside filter is by any means ugly, I think you'd agree. But at least thanks for a workaround.

I do agree, but you were explicitly asking for filtering and type casting in one, so if there were any meaningful filtering condition in the code, it would look muss less like abuse.

This code does not type-check. You will have to add an explicit type cast to the implementation.

I don't think so. My assumption is that we can add second type to middleware and type NextFunction properly. Again, have you checked the link I provided? Can it possibly be implemented the way they did?

I have, and we have played around with similar implementations, but the code rapidly gets messy with fully declarative middleware systems. If you have 50 handlers installed after 10 plugins and 5 custom pieces of middleware, you'll end up with deep nesting or lots of helper variables. If you can draft an implementation for a middleware system that is better, please share it here, but especially @wojpawlik tried many options and so far there has not been a convincing result.

or---even worse---secretly performing type casts internally in bot.use

Why secretly? It's inferred, yes, but without dirty tricks.

Casting with as would happen at some point inside the library and the developer would not know this. It is better to cast explicitly.

grammY is already pushing TypeScript to its limits.
grammY's Composer could allow sub-trees with independent ctx, but we couldn't think of any practical use-case.
The very foundation of middleware trees prevents us from doing use(...): asserts this is Composer<???>:
https://github.com/grammyjs/grammY/blob/42800500cccb0be7cf6872d643247e156f436b2c/src/composer.ts#L225-L226

Closing due to inactivity. Please feel free to re-open if you still have more things to share.


Release 1.10.0

Bump to 1.10.0 and update changelog.
Also include the last couple network & consensus PRs, including the fix for handling DNS lookups after a change in network connection that changes the system DNS servers.

bors merge


prmd doc incorrectly applies $ref links if properties are out of alphabetical order

Here is an example.  (I'm using YAML because I find it more readable.  I don't think it affects the problem here.)
directory structure
$ tree
.
├── schema.json
└── schemata
    ├── bar.yaml
    └── foo.yaml

1 directory, 3 files

foo.yaml
---
$schema: http://json-schema.org/draft-04/hyper-schema

id: schemata/foo
title: foo

type: object
properties:
  # Note the fields are not in alphabetical order
  b_field:
    type: string
  a_field:
    $ref: /schemata/bar#/properties/bar_id

bar.yaml
---
$schema: http://json-schema.org/draft-04/hyper-schema

id: schemata/bar
title: bar

type: object
properties:
  bar_id:
    type: string

running prmd doc
$ prmd combine schemata -o schema.json && prmd doc schema.json
...
### Attributes

| Name | Type | Description | Example |
| ------- | ------- | ------- | ------- |
| **a_field** | *string* |  | `"example"` |
| **[b_field](#resource-bar)** | *string* |  | `"example"` |
...

Note that b_field is linked instead of a_field.  The problem in the Markdown is fixed if I change the ordering in the schemata.  Also, schema.json is always "right".
schema.json
...
      "properties": {
        "b_field": {
          "type": [
            "string"
          ]
        },
        "a_field": {
          "$ref": "#/definitions/bar/properties/bar_id"
        }
      }
...

Interesting, I had actually seen a couple cases of mis-linking similar to this, but never quite put my finger on how/why. The alpha sorting seems like a good lead, I'll try to dig in from there.

released in 0.11.11

Thanks for the quick turnaround!


Uncaught TypeError: a.querySelector is not a function

Uncaught TypeError: a.querySelector is not a function

try $(#selector)[0]


EVP_CIPHER_CTX_FLAG_WRAP_ALLOW flag support

I'm implementing the new Russian GOST CMS specification. It uses the key wrap algorithm described here: https://tools.ietf.org/html/draft-smyshlyaev-tls12-gost-suites-06#section-8.2
I've implemented the algorithm as a cipher with the EVP_CIPH_WRAP_MODE flag.
The EVP_CipherInit_ex function does not reset the EVP_CIPHER_CTX object and the EVP_CIPHER_CTX_FLAG_WRAP_ALLOW stays untouched, so the behavior seems a bit controversial (and undocumented, at least for the 1.1.1 branch). The EVP_CipherInit_ex function also especially preserves the EVP_CIPHER_CTX_FLAG_WRAP_ALLOW flag. The
EVP_CipherInit function cleans up the passed context.
I see the following variants:

Document the difference in behavior.
Update the EVP_CipherInit function to preserve the EVP_CIPHER_CTX_FLAG_WRAP_ALLOW flag on context reset.

I'm ready to implement any of these variants.

A significant difference between EVP_CipherInit and EVP_CipherInit_ex is that the former does a "memset" on the EVP_CIPHER_CTX first (thus resetting any flags). I'm fairly sure that it is by design that EVP_CipherInit_ex doesn't reset any flags.
I suspect documentation is probably the way forward.

The problem with the older EVP_CipherInit() is that it doesn't allow incremental initialization, i.e. something like:
    EVP_CipherInit_ex(ctx, cipher, NULL, NULL, NULL, 1);
    ....
    EVP_CipherInit_ex(ctx, NULL, NULL, key, NULL, 1);
    ....
    EVP_CipherInit_ex(ctx, NULL, NULL, NULL, iv, 1);

This way of initializing incrementally is something we use a little here and there.


Update docker-aspnetmvc.md

Make the bit of creating dockerfile a bit clearer for beginner

Thank you for the contribution, @namvan!


Feature Request: Support if-directives from AsciiDoc

It would be great if ifdef and endif directives from AsciiDoc would be supported.
These "blocks" are not defined by brackets or tags, but they should be considered as blocks, I think.
The blocks are defined from ifdef::foo[] (or ifndef:foo[]) to endif.
ifdef::foo[]
This content is for GitHub only.
endif::[]

Or endif::[] can include the same attribute as the beginning like endif::foo[].
ifdef::foo[]
Thius is some Text.
And some more Text.
endif::foo[]

There is also ifeval:
You can use this to supports multiple languages in one document.
And this is where blockman really would come in handy.
ifeval::["{lang}" == "de"]
Das ist mein Text.
endif::[]
ifeval::["{lang}" == "en"]
This is my text.
endif::[]
ifeval::["{lang}" == "es"]
Spanish text.
endif::[]

There are also one-liner, that I would not consider as blocks.
ifdef::foo[This is some text]

I hope to try it in the near future.


Add tests for templates

The templates currently have no unit test coverage. We should look at porting some of the template testing infrastructure from dotnet/aspnetcore to enable us to get some template test coverage.

@DamianEdwards we have some tests now, how would you describe the gap (or should we close this now)

Happy for engineering to decide as I haven't looked at the tests added. If we have basic coverage now of project create, build, run, publish from all our templates we can close and open specific issues to add missing coverage when necessary.


Introduce Swift Subprocess

This is the implementation accompanying https://github.com/apple/swift-foundation/pull/397

@swift-ci please test

@swift-ci please test


Update sbt-scoverage to 2.2.1

About this PR
📦 Updates org.scoverage:sbt-scoverage from 2.2.0 to 2.2.1
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (2.2.0).
You might want to review and update them manually.
project/plugins.sbt
website/package-lock.json

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scoverage", artifactId = "sbt-scoverage" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scoverage", artifactId = "sbt-scoverage" }
}]

labels: sbt-plugin-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

Superseded by #480.


Update README.md

add "git checkout -b BRANCH_NAME" which create and switches to the BRANCH_NAME.

Hi Abdullah Emara,
I hope this message finds you well!
I wanted to extend my heartfelt thanks for your recent contributions to our GitHub repository. Your efforts and dedication have truly made a positive impact, and I deeply appreciate your time and skills in improving our project.
If you haven't already, could you please give our repository a star? It helps us gain more visibility and attract more collaborators like yourself. Additionally, if you could share the repo with your network, it would be immensely helpful in spreading the word and growing our community.
Here's the link to the repository: Repository URL
Thank you once again for your valuable contributions and support!
Best regards,
Aditya kumar Gupta


Add support for additional PTP parameters

Change Summary

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes)
[ ] Documentation content changes
[ ] Other (please describe):

Related Issue(s)
Related to #979
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes

Add supports for specifying mode fordard-unicast and monitor threshold parameters on PTP

How to test

Checklist:

[X] My code has been rebased from devel before I start
[X] I have read the CONTRIBUTING document.
[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I have updated molecule CI testing accordingly
[X] All new and existing tests passed (pre-commit, make linting and make sanity-lint).

Rebased to current devel and added Molecule variables and the artefacts.


[CERTIFICATE]larvel

Ask us to find free certificates in a specific field that you couldn't find here and we will add it.

Just confirming I've received you're request! Once I find some Laravel courses with certificates/badges I'll add it and notify you!


Duplicate row that duplicates only selected cells, to the next row

Is your feature request related to a problem? Please describe.
When duplicating row, primary key/unique values is also duplicated, which obviously cannot be committed to db.
Describe the solution you'd like
when duplicating row, duplicate only selected values, or
add option in configuration to not duplicate primary key/unique values.
Or keep 'duplicate row' command, and add another 'duplicate selected cells only"

We will fix this issue in #17547


[libevhtp] Remove vcpkg_fail_port_install.

Previously there was no supports expression.
In support of https://github.com/microsoft/vcpkg/pull/21502

Thanks!


Allow text markers to specify background and foreground colors

Allow text markers to specify background and text colors with colors field so that the text can be more readable.
Add enableBgColor prop to Text for opting in the new feature

Test: manually test the following cases

no colors field: change color, background color is automatically updated based on the lightness of the new color
colors field with two items:  colors[0] becomes the text color and colors[1] becomes the background color.
colors field with one item:  the colors field doesn't affect the final text or background color.

This looks pretty good. I like the colors[0]/[1] support for background color. I'm not totally convinced that it's necessary to provide this auto background color feature, since the user could just choose a background color for themselves, and it's a pretty long/awkward name for a prop. Was also thinking of <Text backgroundColor="auto" but I don't really like it better.

Currently we are batching the text markers so we can render one single <Text> in worldview. Allowing the user to specify backgroundColor may cause some text labels to be illegible. The other advantage of autoBackgroundColor is to allow us to globally control the worldview label UI with default dark/light background, so it doesn't go out of control over time.


[Feature] Add UI to AgentQnA example

Priority
P3-Medium
OS type
Ubuntu
Hardware type
Gaudi2
Running nodes
Single Node
Description
Add GUI to AgentQnA example and allow multi-turn conversations.

will co-work with back_end @lkk12014402


Users logs streams m3u

Is your feature request related to a problem? Please describe.
Hello sorry for my bad English. I can see logs in xteve when some channels is playing but not show me what user is playing. I dont know if its possible but this give more control about streams m3u.
Describe the solution you'd like
Add in logs user streams.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Thanks for the project.
Regards

+1


Feature Request:  Re-Scrub Sentry Event

Do you want to request a feature or report a bug?
Feature request.
What is the current behavior?
Currently if a sensitive field is not listed in the 'Additional sensitive fields' section when the event is logged, then the sensitive data is shown in the sentry error.  Adding the new field to the 'Additional sensitive fields' does not retroactively scrub the even, and there is no button on the event to re-scrub it against new filters.
What is the expected behavior?
I would expect that I could have Sentry re-scrub an event rather than the  only supported solution to delete the event altogether.

@matteius – Hey, we appreciate the issue, but this ticket probably belongs on getsentry/sentry. This is strictly for JavaScript client stuff.

Ah gees -- my bad!


Macros of!, empty! and from_iter! replaced by functions.

I'm proposing a change that (partially) addresses #23 and replaces macros with plain strongly typed and constrained functions.
Hope you'll find it useful for further development.

BTW: I've noticed pre-0.3 version had functions instead of macros.
I consider #23 as really reasonable and I opt for, wherever possible, adhering to a regular language syntax.
Was there a particular reason to migrate to macros?

There is no particular reason to migrate to macros. Before 0.3, I am still not find a way to not pay cost for multi-thread when the code only run in local thread. During this time, I'm trying to resolve it , not limit every thing must be support shared between thread, so trait and api change frequently. Use macro reduce many work.

adhering to a regular language syntax

I'm totally agree with this and very happy to accept this pr. Thank you very much for your work.
There is two little work to do:

please update Unreleased  in CHANGELOG.md
remove the #![allow(unused_imports)] line after removed macros.

thanks,
sure, no prob. here is a cleaned up one.

BTW: Thanks for picking this rx challenge!
I was many times looking for a Rust getting it done. You've managed to move further than any one before (at least in part of web I could search trough).
I'm quite excited seeing Rx in Rust being a real thing, Thanks to your efforts this is becoming a fact. Your library is nicely positioned to be the one (and only). Keep it up!

thanks, done.


Cannot get gd for SwiftUI eventhough code actions are working

I'm not sure if I'm mis-configuring something because I cannot get go to definition not working. but as you can see in the picture the code suggestions are working correctly in here.

Here is my config for xbase.

Hello @xiifain. Yes, unfortunately  this is a known issue. Planning to support it in 0.5 release. You can subscribe to get updates on #96.
Meanwhile I'm closing this as duplication.


[Automation] Generate Fluent Lite from healthcareapis#package-2021-01

[Automation] Generate Fluent Lite from healthcareapis#package-2021-01

/azp run prepare-pipelines

/azp run java - healthcareapis - ci


Signed-off-by: Kees Cook<EMAIL_ADDRESS>

Ack, thank you!
Sorry I missed this, my GH notifications are a mess :)


Delete docs/windows/deploying-native-desktop-applications-visual-cpp.md

Fu

@demetri112 - I'm afraid articles can't be deleted via the public repo. If you'd like to submit feedback about this article, you can do so at the bottom of the live page:


KAS code returns identical errors for different error cases, increasing difficulty of diagnosing problems

the same 'bad request' error text appears in multiple error paths, making it more difficult to diagnose this sort of thing.  It would be better if there were unique responses to the different conditions.  Even something with filename+linenumber would be better.
Not the only example, but one case that illustrates the problem:
https://github.com/opentdf/platform/blob/588827c6b4b7b1c0b8f39002eefd294357b5a206/service/kas/access/rewrap.go#L193

Ran into something similar after regenerating keys. The error kas / sdk returned wasn't really clear what the exact issue was.
time=2024-06-24T13:53:09.391Z level=DEBUG msg="default rewrap algorithm" namespace=kas
time=2024-06-24T13:53:09.392Z level=WARN msg="failure to decrypt dek" namespace=kas err="error decrypting data: x509.ParsePKCS8PrivateKey failed: crypto/rsa: decryption error"
time=2024-06-24T13:53:09.393Z level=ERROR msg="rewrap tdf3" err="request error\nrpc error: code = InvalidArgument desc = bad request"


Make clear the requirement of the [cli] dependency group for the schema exporter

Description
Make clear the requirement of the [cli] dependency group when running the schema exporter to avoid import module errors.
Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[X] Documentation

Issues Fixed or Closed by This PR
Not closed, but related to: https://github.com/strawberry-graphql/strawberry/issues/3056
Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Summary by Sourcery
Documentation:

Clarify the requirement of installing the [cli] dependency group for using the schema exporter command line tools.

Thanks for contributing to Strawberry! 🎉 You've been invited to join
the Strawberry GraphQL organisation 😊
You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67
And don't forget to join our discord server: https://strawberry.rocks/discord 🔥


Clarify that Windows isn't supported on Readme and PyPI

I agree it should be explicitly mentioned.
pip command to install sh works okay, but when I try to import the library I get this:
ModuleNotFoundError: No module named 'fcntl'

See also this question on stackoverflow.

@amoffat What do you think about the wording in the two referenced PRs (one for the README shown here on GitHub and PYPI, and one for the GitHub Pages docs)?

LGTM @ecederstrand

Merged


How to set SiteURL in sitemap plugin?

Description
Installed the sitemap plugin, and it says to set the SiteURL in the project config.
Is that in gridsome.config.js? And also, is it just siteURL: 'www.site.com' below siteName: 'site name' in module.exports?

You need to set it in gridsome.config.js, yes.
For example:
https://github.com/cossssmin/gridsome-starter-bleda/blob/ce5f657ba72cc6a9ed06ece82ee7178dff15c877/gridsome.config.js#L10

@cossssmin thank you!


refactor(storage): remove global epoch in uploader

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Removed the global max_syncing_epoch and max_synced_epoch in uploader. Instead, we maintain this value per table.
Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[x] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

There is a panic in the e2e deterministic test:
thread '<unnamed>' panicked at src/storage/src/hummock/event_handler/uploader.rs:803:61:
should exist
stack backtrace:
   0: rust_begin_unwind
             at /rustc/4a0cc881dcc4d800f10672747f61a94377ff6662/library/std/src/panicking.rs:645:5
   1: core::panicking::panic_fmt
             at /rustc/4a0cc881dcc4d800f10672747f61a94377ff6662/library/core/src/panicking.rs:72:14
   2: core::panicking::panic_display
             at /rustc/4a0cc881dcc4d800f10672747f61a94377ff6662/library/core/src/panicking.rs:197:5
   3: core::panicking::panic_str
             at /rustc/4a0cc881dcc4d800f10672747f61a94377ff6662/library/core/src/panicking.rs:172:5
   4: core::option::expect_failed
             at /rustc/4a0cc881dcc4d800f10672747f61a94377ff6662/library/core/src/option.rs:1995:5
   5: core::option::Option<T>::expect
             at /rustc/4a0cc881dcc4d800f10672747f61a94377ff6662/library/core/src/option.rs:896:21
   6: risingwave_storage::hummock::event_handler::uploader::TableUnsyncData::ack_synced
             at ./src/storage/src/hummock/event_handler/uploader.rs:803:61
   7: risingwave_storage::hummock::event_handler::uploader::UploaderData::poll_syncing_task
             at ./src/storage/src/hummock/event_handler/uploader.rs:1337:25
   8: risingwave_storage::hummock::event_handler::uploader::HummockUploader::next_uploaded_sst::{{closure}}
             at ./src/storage/src/hummock/event_handler/uploader.rs:1381:42
   9: <core::future::poll_fn::PollFn<F> as core::future::future::Future>::poll
             at /rustc/4a0cc881dcc4d800f10672747f61a94377ff6662/library/core/src/future/poll_fn.rs:151:9
  10: risingwave_storage::hummock::event_handler::hummock_event_handler::HummockEventHandler::start_hummock_event_handler_worker::{{closure}}::{{closure}}

Related: https://github.com/risingwavelabs/risingwave/issues/17602