[Feature Request] Allow user to import one single tool from toolkits by importing each tool in toolkits.__init__

Required prerequisites

[X] I have searched the Issue Tracker and Discussions that this hasn't already been reported. (+1 or comment there if it has.)
[ ] Consider asking first in a Discussion.

Motivation

Solution
No response
Alternatives
No response
Additional context
No response

from camel.toolkits import SearchToolkit

google_tool = OpenAIFunction(SearchToolkit().search_google)
wiki_tool = OpenAIFunction(SearchToolkit().search_wiki)


feat: Added search (no-stream) method

Added search (no-stream) method (existing search with callback remains available).
Removed findAll method and made the filter optional for findManyStream method. When filter is not supplied - it will stream all

Codecov Report
Base: 91.43% // Head: 91.47% // Increases project coverage by +0.03% :tada:

Coverage data is based on head (c1d77a6) compared to base (199798a).
Patch coverage: 96.96% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   91.43%   91.47%   +0.03%
==========================================
  Files           8        8
  Lines        2031     2052      +21
  Branches      292      296       +4
==========================================
+ Hits         1857     1877      +20
- Misses        172      173       +1
  Partials        2        2

Impacted Files
Coverage Δ

src/collection.ts
95.44% <96.96%> (-0.01%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

closing this in favor of https://github.com/tigrisdata/tigris-client-ts/pull/92


Merged with master

@bojeil-google I needed to make some changes to following files to satisfy the compiler. PTAL:
both modified:   src/auth/user-record.ts
both modified:   test/unit/auth/auth-api-request.spec.ts
modified:   src/auth/auth-api-request.ts
modified:   src/auth/user-import-builder.ts
modified:   test/unit/auth/user-import-builder.spec.ts
modified:   test/unit/auth/user-record.spec.ts

Other changes are straight up merge from master.

Thanks for taking care of this!


Windows interop doesn't work for .exe files that live inside of a Docker container

Windows Version
Microsoft Windows [Version 10.0.22631.3737]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-2
Distro Version
Ubuntu 22.04
Other Software
Docker (Ubuntu 22), version 24.0.7
Repro Steps

Launch WSL (ubuntu-22.04).
Run /mnt/c/Windows/System32/cmd.exe and it works fine.
Run a custom some-program.exe that lives in Ubuntu's filesystem (maybe in /home/username) and it works fine.
Start a Docker container with /run/WSL, /init, /mnt/wsl, /mnt/wslg, and /mnt/c bind-mounted into the container, and the WSL2_GUI_APPS_ENABLED WSL_INTEROP, and PULSE_SERVER enviroment variables passed through to the container.
Run /mnt/c/Windows/System32/cmd.exe inside of the container and it works fine.
Run a custom some-other-program.exe that lives only in the Docker container and it fails with ./some-other-program.exe: Invalid argument.
Look up the path to some-other-program.exe in the host's /var/lib/docker/overlay2 and run it from there, and it works fine.

Expected Behavior
some-other-program.exe should be launchable from inside of Docker.
Actual Behavior
some-other-program.exe fails to launch from inside of Docker, possibly because of Docker container bind-mount path translation.
Diagnostic Logs
WslLogs-2024-08-28_23-33-06.zip

@nrclark: Thank you for reporting this.
This is an interesting edge case. Since docker runs in a chroot, the path that the windows service receives is relative to that root, and therefore trying to create that process from Windows fails since that path doesn't exist in the distribution filesystem:
Microsoft.Windows.Subsystem.Lxss	LxssException	08-28-2024 14:33:23.346	"	"	"Code:
File: 	C:\__w\1\s\src\windows\common\SubProcess.cpp
FunctionName:
HRESULT: 	0x8007010B
Line number: 	207
Message: 	""ApplicationName: \\wsl.localhost\Ubuntu-22.04\usr\local\stow\python-3.12.4-embed-amd64\share\python-3.12.4-embed-amd64\python.exe, CommandLine: python.exe, WorkingDirectory: \\wsl.localhost\Ubuntu-22.04\usr\local\stow\python-3.12.4-embed-amd64\share\python-3.12.4-embed-amd64""
Type: 	0
wslVersion: 	<IP_ADDRESS>"				22712	9900	2		00000000-0000-0000-0000-000000000000

Adding support for this would essentially be a new feature, adding feature tag


fix: propagates test script error code correctly

Right now if test script fails at some point it will log error but exit with 0. This is because it will take $? return code from echo which prints the original error code.
This PR keeps actual error code in the variable to avoid this issue.

General question about this script - do you plan to adjust it after the repo split?

Hello? :)

@J0zi Is upstream directory used from the master branch?
Maybe MR should be created to different branch.
Similar question as in #244


Kernel failed while performing array matmul operation

There's an issue i am facing while performing matmul operation on array, it causes kernel to restart everytime
code
a = mx.array([12])
b = mx.array([4])
mx.matmul(a, b)

error message

here's system info
System: Darwin
Node Name: MacBook-Air.local
Release: 22.4.0
Version: Darwin Kernel Version 22.4.0: Mon Mar  6 21:00:41 PST 2023; root:xnu-8796.101.5~3/RELEASE_ARM64_T8103
Machine: arm64
Processor: arm

python: 3.11.4

What version of MLX are you using? Building from source, if so what commit? I have to admit I've never seen anything even close to that message you are showing. So you'll need to give us quite a bit more detail on what you are doing before we can be helpful.

The error is that the two arrays are integers and we are only allowing floating point matmuls. However, this should be caught in the op-level instead of going to the backend such that the exception would surface to the user.
@kjdeveloper8 you should use mx.array([12.0]) or mx.array([12]).astype(mx.float32) to have floating point arrays until this is fixed.
@awni the kernel here refers to the IPython or Jupyter kernel.

@awni the kernel here refers to the IPython or Jupyter kernel
Makes a lot more sense, thanks!


Got some problem in change motions parameters 😭

hello ~
I got some problem on changing motions parameters
First I used assign_rotate_motion ,then I want to change the parameters.

I changed all the parameters before but they got the same error

Also I check the props parameters name that make sure I'm not typing error

😢
thanks a lot
Evelyn

Hello Evelyn @tako861225 I've fixed your issue. The problem is that the motion setup name is fixed and cannot be changed so I was storing wrong reference name internally.


Debug output makes no sense for long folder structures and classnames

This is one of the many examples :)
The folder - ns/class (params) line is unreadable (check on the right side).

duplicated https://github.com/yiisoft/yii2/issues/4763


Any chance for a Public License

I've used this repository as base for an application I'm developing. To turn it more flexible, I need extend its functionalities a bit. As I see, the repo has no license as per use information. So can you grant permission for modifying the base code e distribution?

I have added the license. You may close the issue.

ty


Bump version numbers in prep for v1.5.4 release

bump:
Teams Version 1.5.3->1.5.4
fiftyone version 0.15.3->0.15.4
OSS (aka database) version 0.23.2->0.23.3
This should NOT be merged until the release is finalized

😇  I have no idea what you're talking about....
Changed the base to release/v1.5.4


Newsletters: add 319 (2024-09-06)

[ ] Lede, releases/RCs, topic entries @harding
[ ] Merge summaries @Gustavojfe

@Gustavojfe I wrote the summary for the CMake change since it was both simple and a bit different than our usual summaries given all the follow ups.

just pushed commit to add all merge summaries.

Made a few small formatting fixups. Squashed and merged. Thank you @harding @Gustavojfe @LarryRuane @jirijakes for contributing this week! 🚀


Add NoopDimFilter to list of JsonSubTypes of DimFilter

The NoopDimFilter was not added to the list of JsonSubTypes of DimFilter.
This caused a deserialization exception when queries used this filter directly
(Could not resolve type id 'NoopDimFilter' into a subtype of [simple type, class io.druid.query.filter.DimFilter])

@mrijke would you mind adding a serde test so we catch this kind of bug in the future?

I'm sorry, I haven't had much time to look at implementing tests for this yet. Do you have some pointers to other serde testcases that I might take inspiration from?
What testcases would you like to have? Just a simple test to see if all the possible filters can be correctly (de)serialized, or something more complex?

@mrijke I think io.druid.query.filter.InDimFilterSerDesrTest would be a good starting point.


MGDOBR-694 : Add localConfig for defining test properties to run integration test locally

MGDOBR-694
PR owner checklist
Please make sure that your PR meets the following requirements:

[x] Your code is properly formatted according to this configuration.
Run mvn clean verify -DskipTests so that imports are correctly set.
[x] Your commit messages are clear and reference the JIRA issue e.g: "[MGDOBR-1] - $clear_explanation_of_what_you_did"
[ ] The layers in the kustomize folder have been updated accordingly.
[x] All new functionality is tested
[x] Pull Request title is properly formatted: MGDOBR-XYZ Subject
[x] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket

PR reviewer(s) checklist

[ ] Check if code and Github action workflows have been modified and if the modification is safe
[ ] If the modification is safe, add the safe to test label

How to trigger pipelines and use the bots:

Run the end to end pipeline
Annotate the pull request with the label: safe to test. If you want to run the pipeline again, remove and add it again.

Rebase the pull request
Comment with: /rebase.

Deploy BOT
Comment with `/deploy <dev,stable> when the PR has been merged to deploy to a target environment.

Is this compatible with run-local-tests.sh? I mean that script load LOCAL_ENV_FILE
Do I understand correctly that now we encourage users to set properties in more different files?

I think we can keep localconfig specific to Integration tests and run the tests in local either by loading properties as part of maven cycle or passing parameters as  Maven command..

From my perspective there is a difference in usage.
dev/bin/localconfig - is intended to configure development environment, it is used on server side
integration-tests/localconfig.properties - it is intended for test execution (against any environment), configuration is applied client side


[App] Fix env variable login

What does this PR do?
Fixes a bug where login with env variables from the CLI would pass but then not actually create the credentials file.
This is because the CLI login calls auth = Auth(); auth.clear() and we were using __post_init__ to process the environment variables and save the credential file which would then be immediately deleted by the clear call.
No added tests, but added calls to auth.clear so the tests reflect the CLI command.
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

Thanks @awaelchli !!! I've updated the tests to actually check for the credentials file and also refactored the Auth class a bit further to do all authentication in one place. Mind re-reviewing?


init_defaults doesn't work properly with java opts values

One of the configs that can be set in the elasticsearch defaults file is ES_JAVA_OPTS. There are 2 issues in this module that cause settings this variable to fail.
First, I think there need to be quotes around the value in the set command - i.e. "set ES_JAVA_OPTS "values here". Right now there are no quotes.
Second, even with quotes it appears the shellvars lens doesn't like the java opts value - probably because there are spaces in it. Being able to set java_opts in this file is critical for us so we can add some GC and JMX options.

I'm seeing this with the latest version of the module (from the forge - 0.15.0).
Since we cannot specify ES_HEAP_SIZE anymore with elasticsearch 5, I set ES_JAVA_OPTS but when I try with the space (ES_JAVA_OPTS="-Xms8g -Xmx8g") then augeasproviders_shellvar fails.
When I try with just ES_JAVA_OPTS="-Xmx8g" it works fine.
Anyone aware of a workaround?


feat: add api support of HuggingFace

Bugs to be fixed:

time out

https://github.com/langchain-ai/langchain/issues/3275
https://discuss.huggingface.co/t/cannot-execute-any-model-with-my-api-token-models-are-timed-out/34812/3

sdk

https://github.com/henomis/lingoose/issues/121


Version 3.0.0 publishing

Is it published or what? I see it merged into master, but both CocoaPods and SPM list 2.4.0 as the latest.

The reason I'm asking is that I want to migrate my RiseTransitSet2 wrapper to either ObjC or C, but I don't know which one.

I would love to see this too, especially to see the newer RiseTransitSet2 wrapper, but I understand that it takes a lot of work to do the release I believe. Perhaps the workload could be cut down by only supporting SPM for instance going forward. I also know that as soon as a new version is posted there will be issue after issue posted of "my code doesn't work any more", which onekiloparsec may not have time or more likely the will to handle. So I can appreciate holding the current position. I'd help out myself but I don't know enough about how to release a new version.

especially to see the newer RiseTransitSet2 wrapper

Frankly, I'm somewhat disappointed in the RiseTransitSet2 implementation in AA+. Original RiseTransitSet is based on Meeus's book and it's fast and elegant (with a few known caveats), while RiseTransitSet2 uses a brute-force approach simply iterating over time with 10-minute steps. I even found a bug in it (it's fixed in the latest version).


Try both python and python3

Used configure script for reference
Reopens mistakenly closed #10525

Can one of the admins verify this patch?

skipping tests since this is untested.


Precommit hook rejects valid .gitlab-ci.yml configuration

It seems that the precommit hook rejects the "Reference Tags" feature in Gitlab-CI's YAML files.
When it runs on a file attempting to use this syntax, I see this error:
Check Yaml...............................................................Failed
- hook id: check-yaml
- exit code: 1

could not determine a constructor for the tag '!reference'
  in ".gitlab-ci.yml", line 16, column 7

The snippet which breaks it:
include:
  - project: "controls/reports/ci_templates"
    ref: master
    file: "python3/dls_py3_template.yml"

tests_and_publish_coverage:
  before_script:
    - !reference [default, before_script]
    # We need this file to exist in the expected place for tests
    - mv src/pts_webserver/.env.example src/pts_webserver/.env

This syntax appears to be valid in Gitlab, as tested by pasting it into our Gitlab CI's inbuilt Linter.

https://github.com/pre-commit/pre-commit-hooks#check-yaml would suggest that adding --unsafe to the check-yaml hook will allow this

So I guess that would be
...
      - id: check-yaml
        args: [--unsafe]
...

Thanks, I've added this to my module's precommit. As this skeleton isn't really designed for GitLab anyway, I think this issue is resolved.


Removed restangular from DivisionService

What does this PR (Pull Request) do?
Removes a dependency on Restangular from the "DivisionService"

[x] This PR partially addresses #3571

Which Traffic Control components are affected by this PR?

Traffic Portal

Traffic Portal dependencies are not individually documented, and so no documentation changes are necessary.
What is the best way to verify this PR?
No functionality should have changed (except that errors will now be logged instead of ignored in many cases), so the existing tests should all pass.
Jeremy: actually, the only way to truly verify that the functionality did not change is to:

run the UI tests (which is a very small subset of all TP functionality)
manually verify the functionality associated with ALL the services functions that changed just to be sure all is well.

The following criteria are ALL met by this PR

[x] This PR includes tests OR I have explained why tests are unnecessary
[x] I have explained why documentation is unnecessary
[x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
[x] This PR includes any and all required license headers
[x] This PR does not include a database migration
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3799/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4008/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4277/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4281/
Test PASSed.


Remove copy btn from details tab in deployment dialog

Changes
L- added conditional to show copy btn only in json tab in deployment dialog
Related Issues
#3629
Tested Scenarios

deploy a solution
click view soln btn
observe no copy btn in details tab
switch to json tab, observe copy btn is there
tested on wordpress and microvm

Checklist

[x] Screenshots/Video attached (needed for UI changes)

@ramezsaeed ?


Can we output libraries instead of websites ?

Can kilua output a node js library for example, that can be integrated seamlessly with react website ?
so the library will be like basic components
Understand the complexity , just checking :D
Sorry not an issue, but there was no discussion tab

Do you mean something like creating a web component?

@rjaros yes

Sorry for the long response time.
I haven't tried that yet, but in theory it should be possible. You can initialize a root container using a custom HTML element. The problem I see is the bundle size because every single component would probably need to use its own copy of Kotlin stdlib. I'm not sure if it is possible to share it between different components.


Multistream object storage benchmark sometimes has stddev of 0 when not 0.

First step is to get a consistent repro.

This issue occured with the following parameters:
INFO     Flag values:
3 --object_storage_multistream_num_streams=1
4 --machine_type=m4.xlarge
5 --object_storage_scenario=api_multistream
6 --object_storage_gcs_multiregion=asia-east1
7 --zones=ap-northeast-1
8 --object_storage_region=asia-east1
9 --cloud=AWS
10 --object_storage_object_sizes=1MiB


how to specifying the code arguments if I know the result is all numbers?

⚠IMPORTANT⚠ if you do not fill this out, we will automatically delete your issue. We will not help anyone that cannot fill out this template.

[x] Have you read our Wiki page "Common Issues & Their Solutions"?

Describe the bug
A clear and concise description of what the bug is.
Plaintext
⚠IMPORTANT⚠ The below code is non-negotiable for "Ciphey didn't decrypt...." problems. If you do not tell us your plaintext, we will not help you.
Include your plaintext here, replacing this

Version
⚠IMPORTANT⚠ We need this information because different environments will induce different bugs in Ciphey

OS/Distro: [e.g. Windows, Debian 11.0, Arch, OS X El Capitan]
Python version: [python3 --version]
Ciphey versions: [python3 -m pip show ciphey cipheycore cipheydists]
Did you use Docker?

Verbose Output
⚠IMPORTANT⚠ Verbose output will tell us why it's not working the way we expected it to be.
Run Ciphey with ciphey -vvv and paste the results into Pastebin.com or a GitHub Gist
To Reproduce
Steps to reproduce the behavior:

What input did you use?
What flags / arguments did you use?

Expected behavior
A clear and concise description of what you expected to happen.
Any other information?
Add any other context about the problem here.

You would use the regex checker.
Example: ciphey -t "123456789" -C regex -p regex.regex=^[0-9]+$
More information on the wiki: https://github.com/Ciphey/Ciphey/wiki/Common-things-you-may-want-to-do


Issue with building mozc

Your build system doesn't respect the following python pep: https://www.python.org/dev/peps/pep-0394/ and therefore I cannot build your software on Arch Linux. Specifically, I get this error
Please fix your build system to reference the version of python it uses, rather than depending on whichever version of python happens to be the default on the current system

Sorry, 1195cf739ba9575156f127d2a00a2ff8f002e8a7 was unrelated.

Please let us close this issue as obsolete.
Note, as of 2021 May, we only support Python3 since Python2 has been deprecated.


translate "type" statements as Closure @typedefs

LGTM.

FYI @martine is a Googler, this is just a random hiccup of the automation around googlebot.

Not a hiccup.  Evan should be using his @google.com email address (not @danga.com) in the git commit if you want this to be recognized as a Googler contribution.

@willnorris I'm using a<EMAIL_ADDRESS>address and it works fine. Maybe @martine just has to sign the CLA with his private mail account?

you shouldn't be.  All Googlers should be using their @google.com email for any work related projects.

I'm already registered with this address I think. At least this github
account has the Google org on it. I'll tr y switching the email address.
On Jan 12, 2016 5:50 PM, "Will Norris"<EMAIL_ADDRESS>wrote:

you shouldn't be. All Googlers should be using their @google.com email
for any work related projects.
—
Reply to this email directly or view it on GitHub
https://github.com/angular/sickle/pull/10#issuecomment-171127597.

OK, I'll ensure my subsequent changes are from @google.com addresses.
If it really matters I can also rewrite all my commits to @google.com addresses.  It's not so horrible because they're at the top of the commit log but it potentially breaks anyone's branches.  How much do we care?


fix(Input):  type attribute should not render for select and textarea

What i change :
I change code on Input component in src/Input.js
And added test case for it.

This PR to fix this issue #1038


CR-1284 Disallow estab type OTHER is already establishment exists

Motivation and Context
Disallow CC to set estab type to OTHER if cases in RM or Cache is already existing establishment.
The pre-existing Establishment Type cannot be changed to OTHER
What has changed
Case Service is changed to add a check if there any establishment exists then it can not be changed to OTHER
How to test?
Run put/cases endpoint with estabType as OTHER then if pre existing establishment is not OTHER it should throw BAD REQUEST with error message  "The pre-existing Establishment Type cannot be changed to OTHER"
Links
https://collaborate2.ons.gov.uk/jira/browse/CR-1284

Please merge master latest into this branch, and get a PR ready for cucumber to fit with it, since currently cucumber will fail


Passing props to route

I want to pass props to routes. I am doing it this way but getting error.
Failed prop type: Invalid prop routes supplied to Router in Router
Anyone knows what I am doing wrong
const routeConfig = (type) => {
  return (
  <Route>
  <Route path='/' component={Template}>
    <Route path='/pageform(/:id)' component={PageForm} />
  </Route>

  <Route path='/:pageSlug' component={Page} type=type/>
  </Route>
);
}
class App extends React.Component {
  render() {
    return (
      <MuiThemeProvider muiTheme={getMuiTheme()}>
        <Provider store={store}>
          <Router history={browserHistory} routes={routeConfig type='abc'} />
        </Provider>
      </MuiThemeProvider>
    );
  };
};

Shouldn't it be  ?

Shouldn't it be <Route path='/pageform/:id' component={PageForm} />

@priyadhoundiyal : The params is optional that's why it has been written as
<Route path='/pageform(/:id)' component={PageForm} />  rather than
<Route path='/pageform/:id' component={PageForm} />
The problem is with passing the props argument type which i don't know is write way to do or not

This is a bug tracker, not a support system. For usage questions, please use Stack Overflow or Reactiflux. Thanks!


Enable disabled test in ballerina shell

Description:
BasicsEvaluatorTest.testEvaluateBasicsQuoted is disabled due to identifier unescaping added via #33619. Need to enable it.

Closing since #33619 no longer disables BasicsEvaluatorTest.testEvaluateBasicsQuoted test.


Upgrade com.google.guava:guava 30.1-jre -> 30.1.1-jre

This PR contains the following updates:

Package
Update
Change

com.google.guava:guava
patch
30.1-jre -> 30.1.1-jre

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade Guava 30.1-jre -> 30.1.1-jre

See

Suggested commit message:
Upgrade Guava 30.1-jre -> 30.1.1-jre (#105)

See:
- https://guava.dev/releases/30.1.1-jre/api/diffs/
- https://github.com/google/guava/releases/tag/v30.1.1
- https://github.com/google/guava/compare/v30.1...v30.1.1


Organizer -> sponsor information

One feature that would be absolutely wonderful would be for sponsors to receive information about each event.
Where each hackathon organizer can put in sponsorship information (cost of tier, what you get for each tier, relevant dates, etc.) that sponsors can use to determine which events would be best for them.
As sponsors, we often get TONS of documents about sponsorship, they're all different, and it's a pain to organize them well.  If this were all done in an organized matter, so that we can compare events side-by-side, that would be awesome.
Plus it could be extended so students could see events side-by-side as well, just to compare things like travel reimbursement, prizes, duration, sleep areas, etc.

@cassidoo Interesting concept!
Went ahead any did some quick mockups, is this what you are aiming for?

Student dash

Sponsor dash

Exactly what I was thinking!!

Okay. Will drop this in the pipeline, though may not make it in for public launch. Thanks again for the feature request! :+1:


[redis-ha] Added sysctl init container same as in stable/redis

What this PR does / why we need it:
Includes options to make host kernel modifications. Especially somaxconn and THP disable
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] DCO signed
[ ] Chart Version bumped
[ ] Variables are documented in the README.md

/assign @ssalaues

@ssalaues

Indeed, I probably forgot this last piece

/ok-to-test

@killmeplz looks good and worked exactly as described. Just fix up the conflict and I'll approve (another PR was merged so the versions are likely conflicting)

@ssalaues That should be all

/lgtm


Update archiver and export utils for nancodes and deletion-handling

Description
Update the archiver utility and the export utility for nancode columns. This PR is meant to separate utility changes from the individual indicator PRs.
Changelog
The archiver utility:

Assumes files diffed have a particular column set. Expand this column set. If a file with missing columns is compared with a file without them, then all the rows are considered new.
If a row is deleted, then replace it with nans for the values fields and add Nans.DELETED missing codes.
If a file is deleted, then instead of removing the file, write a diff file for the same file with all the row entries set to missing. This should ensure that deletions are encoded in the database. If a value is returned, this should seamlessly bring them back.

The export utility:

Adds support for new missing columns.
Adds default values for missing columns.
Adds logger actions when default values are missing.
Adds a logger field to create_export_csv so logging.
Adds a flag to create_export_csv that will write an empty csv file for every missing day between start and end date (useful for some indicators, such as changehc, that did this without using the export util).

Fixes

Part of #838 .

Also, want to make sure that my archiver changes sound reasonable @krivard, specifically replacing deleted rows with nan rows and replacing deleted files with nan rows.

replacing deleted rows with nan rows

Correct

replacing deleted files with nan rows

Extremely incorrect; most of our indicators only generate files for the most recent few days/weeks and not the full timeline. If not-producing those days gets interpreted as deletion, we'll eventually delete the whole timeline by accident.

Hm, I see what you're saying. I have a feeling of inconsistency about this though.
Currently the archiver treats the absence of a file exactly the same as if an exact copy of the file in the cache was produced. In most cases, this won't be an issue, since we want it not to do any updates. But in the case of a whole-day deletion, our archiver would miss this.
I think I'm coming around to seeing that this is probably ok, since whole-day deletion is unlikely. Just wanted to put my finger on why I sensed an inconsistency.
I can take out the deleted file nan-replacement part and we can trust that deletions will occur in select geos, on select days, not in all geos, on select days.


USAgov banner is styled as a header

Area or Component
Likely application-wide, but seen on the patient experience
Quick Summary
The banner at the top of the site ("An official website of the United States government. Here's how you know") is stylized as a header, but we normally have other headers in main content of the application.
Accessibility Violation
Two:

Ensures the document has at most one banner landmark (https://dequeuniversity.com/rules/axe/4.4/landmark-no-duplicate-banner?application=AxeChrome)
Landmarks should have a unique role or role/label/title (i.e. accessible name) combination (https://dequeuniversity.com/rules/axe/4.4/landmark-unique?application=AxeChrome)

Action Requested
If possible: remove the role=banner from the USA-gov banner at the top of the site.
Source Code (optional)
https://github.com/CDCgov/prime-simplereport/blob/c3e6b2dc330021e425e01657eaee613c51f9e11c/frontend/src/app/commonComponents/USAGovBanner.tsx#L80-L80
Original Deque Issue:

landmark-no-duplicate-banner
Ensures the document has at most one banner landmark
Two header landmarks on the page; one for main content and one for the "an official website of the US govt"
Document should not have more than one banner landmark
https://dequeuniversity.com/rules/axe/4.4/landmark-no-duplicate-banner?application=AxeChrome
moderate
No
No

[".usa-banner__header"]
Fix any of the following:  Document has more than one banner landmark

cat.semantics,best-practice
<EMAIL_ADDRESS>Patient Self Reg - Terms of Service
https://stg.simplereport.gov/app/register/9C7BB

2022-07-13T20:53:04.535Z

landmark-unique
Landmarks should have a unique role or role/label/title (i.e. accessible name) combination
Same as above
Ensures landmarks are unique
https://dequeuniversity.com/rules/axe/4.4/landmark-unique?application=AxeChrome
moderate
No
No

[".usa-banner__header"]
Fix any of the following:  The landmark must have a unique aria-label, aria-labelledby, or title to make landmarks distinguishable

cat.semantics,best-practice
<EMAIL_ADDRESS>Patient Self Reg - Terms of Service
https://stg.simplereport.gov/app/register/9C7BB

2022-07-13T20:53:04.544Z

Can confirm; this is seen application-wide.


⚠ API - Lens has degraded performance

In b819ba4, API - Lens ($LENS_API_URL) experienced degraded performance:

HTTP code: 503
Response time: 637 ms

Resolved: API - Lens performance has improved in fed2d0c after 8 minutes.


'az apim api import' doesn't take api version argument

Really liking the az apim api, however, is there a way to set the API version?
I notice the option to specify --api-revision. Would be nice to have --api-version option as well.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 86f27e34-66e0-1d08-f734-26ce29c56c36
Version Independent ID: d1a421eb-807c-c0bd-cee3-a5aed7335625
Content: az apim api
Content Source: latest/docs-ref-autogen/apim/api.yml
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

apim

Any update on this?
The CLI command seems to match the Powershell API all except for API versions
https://docs.microsoft.com/en-us/powershell/module/az.apimanagement/import-azapimanagementapi?view=azps-5.9.0
Example 5 is the use case that the CLI doesn't support
https://docs.microsoft.com/en-us/powershell/module/az.apimanagement/import-azapimanagementapi?view=azps-5.9.0#example-5---import-an-api-from-a-open-api-link-into-a-apiversion-set

Issue is now resolved with PR https://github.com/Azure/azure-cli/pull/18604. Please ping me if there is any other issue. Thanks!

@finesse-fingers This is resolved


Debugging Python Functions ignores Selected interpreter and python.pythonPath

Hi there,
It seems like by default, the azure functions extension completely ignores the selected python path, and instead just uses python in the default path.  I troubleshot this issue for days and learned way more about debugging than I ever wanted to to get it working.
Basically, the workaround is as follows:
My tasks.json
{
	"version": "2.0.0",
	"tasks": [
		{
			"type": "shell",
			"label": "func: host start",
			"command": "conda activate AzureFunctions ; func host start --language-worker -- '-m ptvsd --host <IP_ADDRESS> --port 9091'",
			"problemMatcher": "$func-python-watch",
			"isBackground": true
		}
	]
}

I understand that you may not want to support conda out of the box, but it would be nice if it would respect the Selected Interpreter when testing.
After finding a solution I looked for similar issues and this issue and solution have been closed multiple times:
https://github.com/microsoft/vscode-azurefunctions/issues/2750
https://github.com/microsoft/vscode-azurefunctions/issues/3263
https://github.com/microsoft/vscode-azurefunctions/issues/3332 - Sort of?
Repro Steps

Install Anaconda
Create virtual environment using the following command in an anaconda prompt: conda create -n AzureFunctions python=3.9.7
Activate Environment: conda activate AzureFunctions
Install debugger: conda install ptsvd
Install Azure-functions: pip install azure-functions
Navigate to ~/Anaconda3/envs
Set python.pythonPath=%userprofile%\Anaconda3\envs\AzureFunctions
Create function project.
Hit F5

We should utilize the environments API provided by the Python extension. Looks like it has exactly what we need. https://github.com/microsoft/vscode-python/wiki/Proposed-Environment-APIs

Has there been any progress on this issue?

There have been issues opened before about supporting conda environments but they have been closed. The closest is #3263 which supports some changes to tasks.json but things have changed since then. In particular, ptvsd has been deprecated in favour of debugpy. The following is what worked for me, so documenting it here.
// tasks.json
{
  "version": "2.0.0",
  "tasks": [
    {
      "type": "shell",
      "label": "func: host start",
      "command": "conda activate env && func host start --language-worker -- '-m debugpy --listen <IP_ADDRESS>:9091'",
      "problemMatcher": "$func-python-watch",
      "isBackground": true
    }
  ]
}


docs/Acceptable-Formulae: specifiy the list of supported platforms

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Review period will end on 2021-11-17 at 20:53:28 UTC.

This is a follow up after the comments from https://github.com/Homebrew/discussions/discussions/2475#discussion-3689240

Review period ended.


Lua library function issue...

All libraries function that needs more than one primitive parameter have a problem and are not able to retrieve correct values from the stack...
Unknown bug can't find anything on internet...

Yes indead, there is a problem... A big one, Colors are inversed instead of working in correct order RGBA it works at inverse in ABGR ! Lua is a real pain to manipulate... I believe uploading files over the network, and making the net system working, will be much easier than Lua itself ! Lua understands randomly Check instructions at inverse order as you write them in C (I know UNBELIVIABLE !) and sometimes it automaticully corrupts it's own memory ! I haven't even tried to push some user data with raw memory containing pointers, but if the GC starts to corrupt the passed function parameters with only 10 functions, then I would like to know what it will be at a thousand (maybe it will just start to corrupt game memory, in that case I give up as I don't want to have to fix lua to force it to not corrupt the game's RAM)...
If you have any permanent fixes for that please tell, because seriously is getting me angry at corrupting memory and refusing to correctly retrieve values from stack !

Ok I advanced a bit on the issue, it's not random, it's worse : it's always working at inverse : all functions, and absolutely ALL functions are getting parameters at inverse.
What I was thinking of a memory corruption because the DrawRect was not working at all (so was getting 0 instead of lua values), is in fact because lua is sending to my surface lib inversed parameters order which causes DrawRect to start drawing the end position before the start position, which is then completely normal it does not work (a rectangle has only one face, not 2 according to how UE4 manages UCanvas rendering !)
Well in other words, if someone finds a better way than inputing parameters at inverse to my functions (currently in order -1, -2, -3, -4... reversed in ..., -4, -3, -2, 1) this should work, but it's realy strange that lua requires you to read parameters in inversed order.

Ok CheckColor doesn't work at all. After reading one value of a table using C API you indirectly ask lua to corrupt the stack for you, then the result is nil values instead of other values of the table !
When reading a table you must choose to read only one value ! So in conclusion on UMod with the lua53.dll you can't read more than one value of a table passed as function parameter !

Ok stack corruptions issues are being fixed in the latest commit. Basically just use positive numbers instead of negative ones when working with function arguments.


[2.0.0 REVIEW] An application is not an API in EDA

AsyncAPI Review Document

Project name
Reviewers
Company
Spec version

internal project
@scottvorthmann
TIBCO
v2.0.0

Our goals with this project are to:

Use AsyncAPI docs to generate application code stubs, for both publishers and subscribers
Use AsyncAPI docs as configuration artifacts for generic publisher/subscriber implementations

We expect to:

document an event stream, rather than a subscribing or publishing application
avoid redundant configuration for participating applications

We found the following challenges or difficulties:
1. AsyncAPI favors bottom-up approaches
An API, by any reasonable definition, is a contract that allows multiple applications (using the terminology of AsyncAPI) to successfully interact.  In the REST or client-server world, any such contract is very strongly oriented: the service provider defines the contract, and service consumers either adhere to it or fail.
In an event-driven architecture, the focus shifts from away from any single application.  The contract that must be defined is simply what kind of messages/events are flowing, and where.  Applications can participate either by publishing or by subscribing, and no single application owns the contract.
The current formulation of AsyncAPI does not really support this idea of a contract standing apart from any single application.  AsyncAPI today documents the behavior of a single application, unnaturally forcing a provider-consumer orientation on the contract.  In a scenario with multiple publishers and multiple subscribers using a given channel, each application's AsyncAPI specification will look essentially identical to all the others, differing only in identification and in the "publisher" or "subscriber" keyword.  This redundancy is immediately evident in the "Getting Started" examples, and is only weakly addressed by extracting the message declaration in a standalone document; the redundancy of server and channel remains.  I feel that the redundancy is to be addressed not by adding more reuse features, but by fundamentally shifting the API definition away from any particular application, at least as a possibility.
We think it can be solved by...
...merging the fields of the operation object into the channel item object.  Furthermore, where the channel item object had either a "subscribe" or a "publish" operation object, instead it now has an additional optional "role" field whose value must be "publish" or "subscribe".  If the role is absent, then the channel is documenting itself, rather than an application documenting its role with respect to a channel.
asyncapi: '2.0.0-rc2b'
id: 'urn:hello-world-app'
info:
  title: Hello world application
  version: '0.1.0'
servers:
- url: broker.mycompany.com
  protocol: amqp
  description: This is "My Company" broker.
channels:
  hello:
    role: subscribe
    message:
      payload:
        type: string
        pattern: '^hello .+$'

Overall, we think this challenge/difficulty is...

[x] A "nice to have".
[ ] A blocker for us to adopt this version of the spec.
[ ] Something that doesn't affect the specification.

Other thoughts?
I have noted this issue as a "nice to have", since we can readily address the concerns simply by ignoring the "publisher"/"subscriber" key in a channel.  Nonetheless, I feel this is a fairly profound difference in conceptual terms.  To us, an EDA "application" is a larger thing, corresponding to a collection of applications in the AsyncAPI sense; all the processes are integrated as a single application by virtue of coordinating around the event channels and the messages on them.  This is a top-down use of AsyncAPI, and should be just as naturally supported as the bottom-up use.

AsyncAPI Initiative — (website: asyncapi.org, twitter: @AsyncAPISpec)

Thanks for the review, Scott! As we spoke, this will not make any changes in the spec, hence I'm closing it.


e key being remapped

I'm a colemak dh user. I have remapped the hjkl keys to mnei keys in n x o modes. For a long time these keys has been working but within this month it stopped working.
When I run :nmap n
n  n           * j

:nmap e
n  e           *@<Lua 357: ~/.local/share/nvim/site/pack/packer/start/neo-tree.nvim/lua/neo-tree/ui/renderer.lua:751>n  e           * k

In the documentation I couldn't find any default mapping with e.

Sorry. My bad. This has the complete list of defaults.
I added following and everything works fine. For the record, assigning nil is not working.
            mappings = {
                ['e'] = ''
            },

You actually need to assign "noop" or "none" to disable a default mapping. It was a complication with merging commands that can be defined either globally or within a specific source.


Keyboard shortcut manager #2

When having Norwegian Windows, the shortcut for Bold and Italics are different than with an English Windows version.
I would love to be able to have Norwegian Windows, but select that CTRL+B is bold and CTRL+I is italic instead of the norwegian ones, which is CTRL+F for bold and CTRL+K for italic.
The CTRL+F is in my world the same as "find". In norwegian windows, seach/find is CTRL+B...
Please help :-)

Same hapoens in italian, and, i guess, in every language
I think that the correct approach would be https://github.com/microsoft/PowerToys/issues/111

This will be supported.

you would have to add each of those remaps manually though like ctrl F to ctrl b. If they change their languages often though it might get confusing since we follow what Windows does w.r.t language changes but they face issues with exactly that. We think feedback from that kind of use case would be good but the remapper should be able to do this

The new Keyboard Manager module is now available in 0.18 https://github.com/microsoft/PowerToys/releases


update to handlebars v5

updates handlebars to 5.1.1
version 5 simplified some lifetimes and introduced the use of RenderErrorReason to create RenderError. RenderError::new and other functions have been deprecated.

Looks like GHA failed at the build dev image step


add the ability to optionally turn off ansi coloring

with_ansi_colors(false)

with_ansi_colors(true)

Looks good to me, users without ANSI terminal support probably want to turn of the hints anyways as they become hard to distinguish from the actual input


is final_dist a probability distribution ?

I see that you are adding the encoder attention scores to the corresponding word's existing score in the vocabulary distribution at each decoder time step. But how then, after the addition, the final distribution is a probability one. You are directly using this dist. for loss computation by applying log over it without any softmax.

Okay I missed the fact that both the distributions are already scaled down by p_gen and (1-p_gen) so the resulting dist. will be a probability one.


bumping ffi-yajl to pick up 2.x

1.x still works fine, so leaving the lower floor in place.

@chef/client-core @chef/client-engineers reviews

I slightly prefer moving the floor so we just do ~> 2.0 unless we have reason to think some people might be using chef as a library but be unable to upgrade. Not too concerned about it though, :+1:  either way.

That'll immediately conflict with the '~> 1.1' in ohai which means it all needs to get coordinated which is a mild hassle.  I'd rather be lazy and avoid gem conflicts since there's not going to be any code changes in 2.0.0 that chef/ohai will actually execute any differently...

That's a good reason

:+1:


Integrate zea-tree-view web component

Lets move away from the Svelte based tree and used the new web-component one that we are using in the React template.

@seijiwjs I have assigned this issue to you, but you will need help from @mauroporras


New maintainer request

@tonyganch I see this project is no longer updated, but honestly it's the best CSS styler I've found in terms of customizability and simplicity.
I've noticed a handful of small issues myself, and there are a good number of PRs already waiting here. I wonder if you would consider adding me as a maintainer to this project? I don't have a lot of time to keep up with it, but I've already spent a few days getting to know the ins and outs (and the Gonzales-PE package) and think I can at least help patch over a few of the bigger items that have been neglected.
What do you say?

Just a little ping to see if I can get any response here. @mishanga, @tonyganch


improve and expand documentation on using secrets/certs in KMS for timestamp-server

Description
The current documentation on using KMS to store certificates https://github.com/sigstore/timestamp-authority#cloud-kms is somewhat unclear on what needs to be done, and possibly less general and with emphasis on GCP and Tink.  It makes a bit an impression of "leaving the details as an exercise" for the user 😄  - "look at this code [fetch_tsa_certs.go] and figure out how to adapt it for your use-case".

For context, the service was designed originally to be run on GCP where the root was hosted with GCP CA Service, which is why you'll see that fetch_tsa_certs.go hardcodes certain resource expectations. As another way to deploy the service to minimize calls to KMS, Tink provides a secure way to use an in-memory key that is encrypted with a KMS key so that the unencrypted key is never on disk.
The KMS library supports GCP, AWS, Azure, and Hashicorp Vault. Tink supports GCP, AWS, and Vault. Once you have the CA certificate chain, any of these cloud providers can be used.
Roughly, you'll need to do the following to run the service with KMS:

Get a certificate chain where the leaf certificate certifies the KMS public key. The chain must start with a root and end with a leaf certificate which follows RFC3161 (namely, the timestamping EKU is set to critical), with any number of intermediate CA certificates.

There will be a lot of variations for how this is fetched - Your root could be hosted offline, in an HSM, in GCP CA Service, in AWS CA Service, as a KMS key, etc. Same with the intermediates.
fetch_ca_certs presents one suggested deployment, where the root is a hosted CA in GCP CA Service and the intermediate certificate is generated from a KMS key denoted to be for an intermediate CA certificate. It also supports a Tink keyset, which is a raw key encrypted with a KMS key and is loaded into memory on service startup.
Open to PRs to create more scripts to fetch certificate chains.

Deploy the timestamp authority following the readme: "Set --timestamp-signer=kms, provide the path to the chain with --certificate-chain-path, and the KMS key with --kms-key-resource. The key should be prefixed with either gcpkms://, azurekms://, awskms://, or hashivault://"

If using a Tink keyset, "set --timestamp-signer=tink, --tink-key-resource=<path-to-kms-key>, and
--tink-keyset-path=enc-keyset.cfg. The key resource should be prefixed with either gcp-kms://, aws-kms://, or hcvault://. If using Vault, you may also set --tink-hcvault-token. Provide the path to the chain with --certificate-chain-path."

@malancas Did you have anything to add from your experience?
We can update the documentation with this info.

@haydentherapper that about summarizes everything up. My one suggestion to users who want to run a TSA is to confirm their certificate chain can be successfully verified with VerifyCertChain to prevent issues when trying to start the server.


Performance improvement of mapping and schema editing

Is your feature request related to a problem? Please describe.
Improve performance of schema modification, currently, it is quite slow (drops to 6fps on larger processes). Consider adding progress bar

selectSingleNode consume most of the time - so maybe exact XPATH of element can be used instead of using element IDs
Updates batching - do not immediately persist XML file is the easiest solution


[DOC-9207] Fix long-standing display bug, improve k8s docs about tearing down a cluster

[DOC-9207] Fix long-standing display bug
Also take the opportunity to:

Improve k8s docs about tearing down a cluster
Add more context about why we don't use kubectl delete --all
State more clearly that the command intentionally doesn't delete secrets either, point more clearly to the k8s project docs about managing persistent volumes and secrets

Previews:
src/current/v22.2/deploy-cockroachdb-with-kubernetes.md
src/current/v23.1/deploy-cockroachdb-with-kubernetes.md
src/current/v23.2/deploy-cockroachdb-with-kubernetes.md
src/current/v22.2/deploy-cockroachdb-with-kubernetes-insecure.md
src/current/v23.1/deploy-cockroachdb-with-kubernetes-insecure.md
src/current/v23.2/deploy-cockroachdb-with-kubernetes-insecure.md

All looks good to me, also spotted same thing as Mike

Received approval from Mike and Dan offline. I verified that the Operator doesn't support cert-manager, but added more details about Helm and manual deployments using cert-manager at the same time.

Thanks for the reviews, everyone!


Keyboard Manger - Support multiple keyboards

Description of the new feature / enhancement
Would love to see Keyboard Manager allow you to use 2 (or more?) keyboards. Basically the ability to use a separate keyboard (keypad) as a blank slate and assign shortcuts to. Just need to target or distinguish between both keyboards.
Scenario when this would be used?
It's common to have a separate keyboard or keypad dedicated for shortcuts, common or repetitive keystrokes, etc...
Supporting information
No response

This would also be useful for Bluetooth remotes that simulate media keys.


Integrated PDBBox to validate PDF generation in asciidoctorj-pdf

This PR integrates a PDF parsing API (PDFBox) to validate that PDFs are properly generated.
Two tests have been added; one to validates image inclusion and another for text highlighting.
There's one issue though, the parsing of the PDFs generates many warning errors from PDFBox. This "pollutes" quite a bit the console of the CI. If this is a problem I can investigate some workarround.

Wow! This is awesome!
This is the missing link between the document you recently added and the code:)
I'm just seeing many ClassCastExceptions in the source highlighting test:
Aug 09, 2015 6:24:17 PM org.apache.pdfbox.util.PDFStreamEngine processOperator
WARNUNG: java.lang.ClassCastException: org.asciidoctor.util.pdf.ColorsProcessor cannot be cast to org.apache.pdfbox.pdfviewer.PageDrawer
java.lang.ClassCastException: org.asciidoctor.util.pdf.ColorsProcessor cannot be cast to org.apache.pdfbox.pdfviewer.PageDrawer
	at org.apache.pdfbox.util.operator.pagedrawer.LineTo.process(LineTo.java:45)
	at org.apache.pdfbox.util.PDFStreamEngine.processOperator(PDFStreamEngine.java:557)
	at org.apache.pdfbox.util.PDFStreamEngine.processSubStream(PDFStreamEngine.java:268)
	at org.apache.pdfbox.util.PDFStreamEngine.processSubStream(PDFStreamEngine.java:235)
	at org.apache.pdfbox.util.PDFStreamEngine.processStream(PDFStreamEngine.java:215)
	at org.asciidoctor.util.pdf.ColorsProcessor.parse(ColorsProcessor.java:63)
	at org.asciidoctor.WhenBackendIsPdf.pdf_source_code_should_be_highlighted(WhenBackendIsPdf.java:77)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)

This is the missing link between the document you recently added and the code:)

Knowing that PDF generation was tested using file.exists() worried me because (srry, if am wrong) I did not see any test in the ruby gem project.
Also, being self-demanding as we are, the fact that PDFs are not as easy to deal with as HTML should not stop us from testing them to some similar degree.

I'm just seeing many ClassCastExceptions in the source highlighting test:

Those nasty ClassCasExceptions are the warnings I mentioned. I think this could be removed if ColorsProcessor extended PageDrawer instead of PDFTextStripper. But has some drawbacks, let me explain:
The way PDFBox works is similar to SAX XML parser, it offers events, you have to extend basic class and override some methods. In the case of PDFBox it also offers some basic classes with some features already done.
So the trick is choosing which one offers what is closer to your needs.
For text treatment, the closest one is PDFTextStripper, but to get the colors at some point it calls PageDrawer and some elements inside the document fails *.
I already tried extending PageDrawer which prevents those warnings, but I had to reimplement some logic provided by PDFTextStripper and override some methods to avoid other issue. To sum up, using PageDrawer mean a less clean solution and actual exceptions, while PDFTextStripper offers a cleaner solutions but lots of warnings.
Still, I'll give it a try and come back later to report, maybe I can find a better solution
* btw, this does not happen on all PDFs I have tested, but Asciidoctor one always show some warning. But given the preview state I won't worry about this right now.

Knowing that PDF generation was tested using file.exists() worried me because (srry, if am wrong)

Don't be sorry.

I did not see any test in the ruby gem project.

That's one of the requirements to satisfy before we can move to beta. I'd like to use something from the Ruby ecosystem to test them. See https://github.com/asciidoctor/asciidoctor-pdf/issues/37

Also, being self-demanding as we are, the fact that PDFs are not as easy to deal with as HTML should not stop us from testing them to some similar degree.

Correct. It is a bit trickier to test them, but as I mention in the linked report, there are still plenty of things that we can test.

For now, I don't mind having tests in AsciidoctorJ. Extra coverage certainly can't hurt (in this case, coverage at all).

I squashed the following changes:

Added 'pdbboxVersion': following the current pattern I added this to the build.gradle at thet root, but I'm not sure if we should add a properties that only apply to one sub-project.
Found a solution for the ClassCastException messages: just created a custom configuration for the processor removing those components that used PageDrawer. Quite simple and clean in the end.

@mojavelinux while the testing in ruby is not set in stone, open issues If you think some specific feature could be tested here. I only focused in the ones that have been reported so far.

I'm not sure if we should add a properties that only apply to one sub-project.

We also have properties for netty or jsoup that are only used in core.

Found a solution for the ClassCastException messages:

:+1:

some specific feature could be tested here.

It would then be great if we could test against pdf prereleases like we test against asciidoctor prereleases.
Otherwise we find the errors only after a release:)

I see the build failed on Opendk7 for
Could not GET 'http://rubygems-proxy.torquebox.org/releases/rubygems/rubyzip/1.1.7/rubyzip-1.1.7.pom'. Received status code 503 from server: Service Temporarily Unavailable

The rest worked fine. Robert, I think you can relaunch the job since you have write access on the repo.

It would then be great if we could test against pdf prereleases like we test against asciidoctor prereleases.
Otherwise we find the errors only after a release:)

I looked into test-asciidoctor-upstead.sh and this should be easy. But this makes me think if we should test all other asciidoctor gems:epub or diagram.

Thank you!
No need to rebuild. We often have the situation that we randomly see 503 when resolving gems.
As all other builds succeeded, this would have been fine as well.


⚠ Bofrost.de has degraded performance

In 24b5f34, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1558 ms

Resolved: Bofrost.de performance has improved in 24ca6b1 after 13 minutes.


Enable DAO Proposal to execute Arbitray Tx

Goals
Allow more or less (anything the implements a specific tx type) to be executed as a ConcludeProposalTx that will only be executed when the vote has passed. Also allow the Implementing Tx to verify the ProposalConfiguration to make sure it can reject parameters that are invalid.  E.g. not high enough threshold or invalid durration of Proposal.
Non-Goals
Allow for multiple outcomes in the same proposal
Implementation
Newly/Adjusted Tx:

SubmitDaoProposalTx -> Creates and typechecks a proposal for a wrapped proposedTX (Currently only AddValidatorTx)
AddDaoVoteTx -> Any currently active validator that has been a validator before the vote comenced can issue approval with this tx
ConcludeDaoProposalTx -> is Issued automatically by the node and executes the proposed tx if the proposal was accepted

Caveats
The proposedTx is checked at submit time, but the state can change while the proposal is active. If the proposalTx becomes invalid while the Proposal is invalid the proposal concludes as normal and ignores the failure. That might not be desireable but the easiest way of handeling it atm.
The AddValidator proposal will not be able to submited outside of a ConcludeProposalTx

Damm, i just noticed, that there is am implicit requirement for the Ins of both the Submit and WrappedTx to be disjunct. Which the current stake function does not care about... sadge

I converted i back to a draft as i found some bugs that are game breaking, ill need to discuss with @evlekht how to proceed.
Main Issue:

At tx creation time you will need to reference two set of ins that are disjunct for the Submit & Wrapped Tx, the current implementaiton of spend does not do this and the service does also not take this into account which will lead to the Tx no being accepted.

Ill need to see if there is a way to sidestep this issue.

superceded by https://github.com/chain4travel/caminogo/pull/269


Makefile doesn't run offline

The following error gets returned:
zip -r docs/assets/bootstrap.zip bootstrap
updating: bootstrap/ (stored 0%)
updating: bootstrap/css/ (stored 0%)
updating: bootstrap/css/bootstrap.css (stored 0%)
updating: bootstrap/img/ (stored 0%)
updating: bootstrap/img/glyphicons-halflings-white.png (deflated 4%)
updating: bootstrap/img/glyphicons-halflings.png (deflated 4%)
updating: bootstrap/js/ (stored 0%)
rm -r bootstrap
lessc ./less/bootstrap.less > ./docs/assets/css/bootstrap.css
at /Library/Ruby/Gems/1.8/gems/less-2.0.9/lib/less/js/lib/less/parser.js:378:69: 'reset.less' wasn't found. (Less::ParseError)
from /Library/Ruby/Gems/1.8/gems/less-2.0.9/lib/less/parser.rb:88:in to_css' 	from /Library/Ruby/Gems/1.8/gems/less-2.0.9/lib/less/parser.rb:13:in calljs'
from /Library/Ruby/Gems/1.8/gems/less-2.0.9/lib/less/parser.rb:27:in lock' 	from /Library/Ruby/Gems/1.8/gems/less-2.0.9/lib/less/parser.rb:25:in lock'
from /Library/Ruby/Gems/1.8/gems/less-2.0.9/lib/less/parser.rb:12:in calljs' 	from /Library/Ruby/Gems/1.8/gems/less-2.0.9/lib/less/parser.rb:87:in to_css'
from /Library/Ruby/Gems/1.8/gems/less-2.0.9/bin/lessc:23
from /usr/bin/lessc:19:in `load'
from /usr/bin/lessc:19
make: *** [docs] Error 1

I get the same error when I run make and I'm using the Ruby version of less (al biet I'm on 1.9)

I've at least got the makefile past the stages of dealing with less. It involved changing all the paths in bootstrap.less and responsive.less from 'x' to '/less/x'. However, a new problem has arisen which I believe is more an issue with the Ruby version of lessc. It doesn't appear to support --compress, hence this gets thrown
/Users/myusername/.rvm/gems/ruby-1.9.2-p290/gems/less-2.0.9/bin/lessc:20:in `read': No such file or directory - --compress (Errno::ENOENT)

I'm with @davefinster that this issue is more related to the ruby version of lessc.

Try with the Node version of less as recommended in the docs.


fix: labels and help messages for partial errors for clarity

Some of the partial errors could use labels, this pr adds some of them in cases where I thought they would improve clarity especially in edge cases where spans and error messages aren't clear enough.
fixes https://github.com/prefix-dev/rattler-build/issues/399

I've opened #805


How can I wrap a function that I want to differentiate with autograd?

This works:
import autograd.numpy as np
from autograd import jacobian

th = np.array([1., 2., 3., 4.])
A = lambda th: [ [th[0], th[1]], [th[2], th[3]] ]
B = lambda th: np.array(A(th), np.float64)
jacobian(B)(th)

But this does not:
import autograd.numpy as np
from autograd import jacobian

th = np.array([1., 2., 3., 4])
A = lambda th: [ [th[0], th[1]], [th[2], th[3]] ]
B = lambda f: lambda th: np.array(f(th), np.float64)
C = B(A)
jacobian(C)(th)

throwing AutogradHint: This error *might* be caused by assigning into arrays, which autograd doesn't support.
I have a list of functions such as A() that return lists. What I want to do is to wrap each of them into a function such as B() so that I can get numpy array on return. Can I achieve this another way?

This also does not work:
import autograd.numpy as np
from autograd import jacobian

th = np.array([1., 2., 3., 4.])
A = lambda th: [ [th[0], th[1]], [th[2], th[3]] ]
fn_list = [A] * 3
new_fn_list = [lambda th: np.array(f(th)) for f in fn_list]
jacobian(new_fn_list[0])(th)

end up with the same AutogradHint exception.

This do work:
import autograd.numpy as np
from autograd import jacobian

th = np.array([1., 2., 3., 4.])
A = lambda th: [ [th[0], th[1]], [th[2], th[3]] ]
fn_list = [A] * 3

new_fn_list = list()
for f in fn_list:
    new_fn_list.append(lambda th: np.array(f(th)))

jacobian(new_fn_list[0])(th)

Works.

In particular, list comprehensions do not work:

import autograd.numpy as np
from autograd import jacobian

th = np.array([1., 2., 3., 4.])
A = lambda th: [ [th[0], th[1]], [th[2], th[3]] ]
fn_list = [A] * 3
new_fn_list = [lambda th: np.array(f(th)) for f in fn_list]
jacobian(new_fn_list[0])(th)

end up with the same AutogradHint exception.

Try installing from the master branch from Github. This code should work.
The reason this one doesn't work:
import autograd.numpy as np
from autograd import jacobian

th = np.array([1., 2., 3., 4])
A = lambda th: [ [th[0], th[1]], [th[2], th[3]] ]
B = lambda f: lambda th: np.array(f(th), np.float64)
C = B(A)
jacobian(C)(th)

Is that autograd.jacobian(fun) only works when fun is a function which takes a numpy array as input and returns a numpy array. C in this case is a value, not a function.

Actually, B(A) is a function in that first example. The problem in the first example is passing the np.float64 argument to np.array. This runs without error:

th = np.array([1., 2., 3., 4])
A = lambda th: [ [th[0], th[1]], [th[2], th[3]] ]
B = lambda f: lambda th: np.array(f(th))  # removed second argument
C = B(A)
print jacobian(C)(th)

This problem with passing the np.float64 argument is probably a surprising error for a user to get, and we might be able to fix that in our np.array wrapper. Is the second argument to np.array important for your use case, @konstunn?
The code example in the second comment seems to work fine for me (on the current master branch), but it would be good to know if it doesn't work with the pip version. @konstunn, if it fails for you, can you tell us the autograd version (in setup.py) and also paste the full traceback?

I didn't find any setup.py. The version of my pip autograd package is:
$ pip3 list | grep autograd

autograd (1.1.13)

So coming back to this code:
In [1]: import autograd.numpy as np

In [2]: from autograd import jacobian

In [3]: th = np.array([1., 2., 3., 4.])

In [4]: A = lambda th: [ [th[0], th[1]], [th[2], th[3]] ]

In [5]: B = lambda f: lambda th: np.array(f(th), np.float64)

In [6]: C = B(A)

In [7]: jacobian(C)(th)

Here is the full traceback:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
/usr/local/lib/python3.5/dist-packages/autograd/errors.py in wrapped(*args, **kwargs)
     47   def wrapped(*args, **kwargs):
---> 48     try: return fun(*args, **kwargs)
     49     except Exception as e: add_extra_error_message(e)

/usr/local/lib/python3.5/dist-packages/autograd/convenience_wrappers.py in jacfun(*args, **kwargs)
     38     def jacfun(*args, **kwargs):
---> 39         vjp, ans = make_vjp(fun, argnum)(*args, **kwargs)
     40         ans_vspace = vspace(ans)

/usr/local/lib/python3.5/dist-packages/autograd/core.py in vjp_maker(*args, **kwargs)
     11     def vjp_maker(*args, **kwargs):
---> 12         start_node, end_node = forward_pass(fun, args, kwargs, argnum)
     13         if not isnode(end_node) or start_node not in end_node.progenitors:

/usr/local/lib/python3.5/dist-packages/autograd/core.py in forward_pass(fun, args, kwargs, argnum)
     25     active_progenitors.add(start_node)
---> 26     end_node = fun(*args, **kwargs)
     27     active_progenitors.remove(start_node)

<ipython-input-5-8a76d6a45ae3> in <lambda>(th)
----> 1 B = lambda f: lambda th: np.array(f(th), np.float64)

/usr/local/lib/python3.5/dist-packages/autograd/numpy/numpy_wrapper.py in array(A, *args, **kwargs)
     72     else:
---> 73         raw_array = _np.array(A, *args, **kwargs)
     74         return wrap_if_nodes_inside(raw_array)

ValueError: setting an array element with a sequence.

The above exception was the direct cause of the following exception:

AutogradHint                              Traceback (most recent call last)
<ipython-input-7-17128f344d5c> in <module>()
----> 1 jacobian(C)(th)

/usr/local/lib/python3.5/dist-packages/autograd/errors.py in wrapped(*args, **kwargs)
     47   def wrapped(*args, **kwargs):
     48     try: return fun(*args, **kwargs)
---> 49     except Exception as e: add_extra_error_message(e)
     50   return wrapped
     51

/usr/local/lib/python3.5/dist-packages/autograd/errors.py in add_extra_error_message(e)
     66     if extra_message:
     67         if sys.version_info >= (3,):
---> 68             raise_from(AutogradHint(extra_message), e)
     69         else:
     70             raise_(AutogradHint, (extra_message, etype, value), traceback)

/usr/local/lib/python3.5/dist-packages/future/utils/__init__.py in raise_from(exc, cause)
    396         myglobals['__python_future_raise_from_cause'] = cause
    397         execstr = "raise __python_future_raise_from_exc from __python_future_raise_from_cause"
--> 398         exec(execstr, myglobals, mylocals)
    399
    400     def raise_(tp, value=None, tb=None):

/usr/local/lib/python3.5/dist-packages/autograd/errors.py in <module>()

AutogradHint: This error *might* be caused by assigning into arrays, which autograd doesn't support.

If I remove the second argument in np.array() as suggested by @mattjj the exception is raised with the following traceback:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
/usr/local/lib/python3.5/dist-packages/autograd/errors.py in wrapped(*args, **kwargs)
     47   def wrapped(*args, **kwargs):
---> 48     try: return fun(*args, **kwargs)
     49     except Exception as e: add_extra_error_message(e)

/usr/local/lib/python3.5/dist-packages/autograd/convenience_wrappers.py in jacfun(*args, **kwargs)
     38     def jacfun(*args, **kwargs):
---> 39         vjp, ans = make_vjp(fun, argnum)(*args, **kwargs)
     40         ans_vspace = vspace(ans)

/usr/local/lib/python3.5/dist-packages/autograd/core.py in vjp_maker(*args, **kwargs)
     11     def vjp_maker(*args, **kwargs):
---> 12         start_node, end_node = forward_pass(fun, args, kwargs, argnum)
     13         if not isnode(end_node) or start_node not in end_node.progenitors:

/usr/local/lib/python3.5/dist-packages/autograd/core.py in forward_pass(fun, args, kwargs, argnum)
     25     active_progenitors.add(start_node)
---> 26     end_node = fun(*args, **kwargs)
     27     active_progenitors.remove(start_node)

<ipython-input-5-8a76d6a45ae3> in <lambda>(th)
----> 1 B = lambda f: lambda th: np.array(f(th), np.float64)

/usr/local/lib/python3.5/dist-packages/autograd/numpy/numpy_wrapper.py in array(A, *args, **kwargs)
     72     else:
---> 73         raw_array = _np.array(A, *args, **kwargs)
     74         return wrap_if_nodes_inside(raw_array)

ValueError: setting an array element with a sequence.

The above exception was the direct cause of the following exception:

AutogradHint                              Traceback (most recent call last)
<ipython-input-9-17128f344d5c> in <module>()
----> 1 jacobian(C)(th)

/usr/local/lib/python3.5/dist-packages/autograd/errors.py in wrapped(*args, **kwargs)
     47   def wrapped(*args, **kwargs):
     48     try: return fun(*args, **kwargs)
---> 49     except Exception as e: add_extra_error_message(e)
     50   return wrapped
     51

/usr/local/lib/python3.5/dist-packages/autograd/errors.py in add_extra_error_message(e)
     66     if extra_message:
     67         if sys.version_info >= (3,):
---> 68             raise_from(AutogradHint(extra_message), e)
     69         else:
     70             raise_(AutogradHint, (extra_message, etype, value), traceback)

/usr/local/lib/python3.5/dist-packages/future/utils/__init__.py in raise_from(exc, cause)
    396         myglobals['__python_future_raise_from_cause'] = cause
    397         execstr = "raise __python_future_raise_from_exc from __python_future_raise_from_cause"
--> 398         exec(execstr, myglobals, mylocals)
    399
    400     def raise_(tp, value=None, tb=None):

/usr/local/lib/python3.5/dist-packages/autograd/errors.py in <module>()

AutogradHint: This error *might* be caused by assigning into arrays, which autograd doesn't support.

The second traceback still shows the np.float64 argument. Did you paste the right traceback?

I'm sorry. Indeed, I have pasted the wrong traceback. Actually, there is no traceback at all. It works fine.
It seems that when I was preparing this report I modified the 5th line accordingly (removed np.float64 second argument in np.array()) and reevaluate that line, but forgot to reevaluate C() by the next 6th line and run the last line straight away. That might be the reason.
Sorry.

Aha, no problem! I do that sort of thing all the time :)
I think (but correct me if I'm wrong) that we narrowed down the only problem to the np.float64 passed in as the second argument to np.array. We might be able to patch that up, but I haven't had time to investigate it yet, and there are other improvements we want to make to np.array as well (the current autograd-wrapped version can be very slow).
Just to get a sense of how to prioritize this, is your use case going to work without passing the np.float64 argument?

Yes, my use case seems to be going to work without passing the np.float64 argument so far. Thank you.

Yes, my use case seems to be going to work without passing the np.float64 argument so far. Thank you.

Great! I'm going to edit the name of the issue to reflect our updated understanding, and leave it open so we can try to fix it when we get a chance.

I think this is fixed by https://github.com/HIPS/autograd/pull/288. However I should write a couple of tests to check dtype and the ndmin optional arg are working correctly.


Support more than just quick fixes (for ex. "Open docs for error_code") in Problems view context menu

Right-clicking in the Problems view shows a filtered list of QuickFix code actions. I'd really like to add an entry in there to open the help docs for more information on the error - however it doesn't seem right to mark it as a QuickFix:

It would be great if there was some way to either supply a URL for more help about an error, or at least another CodeAction kind that can be shown in the problems view.

@mjbvz How can I get other code actions which are relevant to the given diagnostic? Right now I only get quick fixes.

@sandy081 When calling getCodeActions here, remove the filter. However keep in mind that the returned result may also include refactorings and other actions that probably should not show up in the problems context menu
@DanTup For those documentation code actions, could mark them with a code action kind of CodeActionKind.QuickFix.append('documentation') or similar? The action is related to quick fixes so abusing the code action kind this way may not be too terrible. Once you add that kind, the actions should should show up in the problems menu

I certainly could, but it feels a bit weird. For ex. if you had a keybind to show the menu filtered to "all quick fixes" (I think you can do that?) it'd be weird for this to show up there. Maybe a CodeAction.Help or something would be appropriate?

Or, even better, put the help text in the error message itself. @sandy081 Is that something we support?

We do have extra help text in the errors (in the screenshot at the top you can see some errors have a second line with more descriptive text), but we wanted to be able to link to online docs that are more detailed than we'd want to cram into the problems list.

There are discussions to add help link to diagnostics - https://github.com/Microsoft/vscode/issues/11847
So options here are to change the code action kind to quick fix or follow up on other item.

Making a help URL a first-class citizen sounds good to me - it opens the door to other nice functionality (for ex. a keybind that opens help for the current error). I still think being able to show non-fix items in this context menu is worthwhile, but I don't have a specific need for it if diagnostics could have URLs.
That said, it's not clear what's going on in that issue - using RelatedInformation sounds wonky to me, and I don't think supporting formatted content in errors solves the problem (I don't want to clutter the error list even more with visible links, the context menu is an idea place for it).

@DanTup Thanks for your feedback. Closing this in favor of #11847


Update CreatorsUpdate.md

Toradex Colibri T30 devices don't support Creators Update Build 15063

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/release-notes/commercial/CreatorsUpdate.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


MrWright12

Need to be approved quickly. He needs it. everyone should help him. EVERYONE

Help is coming

Thank you and it's yours. Have it all my friend.


WS error message

On RC4 / Storage 1.1.7 , if you try
ionic serve --consolelogs
you see an error that is not actually seen in the browser console log
[19:52:58]  error opening ws message: {"category":"console","type":"info","data":["Ionic Storage
            driver:","asyncStorage"]}

Not sure what that is, but looks storage related. Seems to work though, even with this error message.

Thanks Alex, this is a non-error with app scripts (it can't serialize that console log with the naive JSON stringify).

If it's a non-error why does it show up?  Should it be removed?

It is removed in the newest version of ionic-app-scripts.

I'm still seeing it.   My package.json has:
  "devDependencies": {
    "@ionic/app-scripts": "^1.0.0",
    "typescript": "2.0.9"
  },

but i'm honestly not sure I trust that to be the right version. is there a cmd-line thing I can run to get the version of app scripts that is currently being used?

Mine is the same:
   "devDependencies": {     "@ionic/app-scripts": "1.0.0",     "typescript": "2.0.9"   },
But I see the same error:
[23:17:33]  error opening ws message: {"category":"console","type":"info","data":["Ionic Storage             driver:","asyncStorage"]}

Still sees it.

I see the same, it is annoying.
"devDependencies": {
    "@ionic/app-scripts": "1.1.4",
    "typescript": "2.0.9"
  }

me too:
"devDependencies": { "@ionic/app-scripts": "1.1.3", "typescript": "2.0.9" },
[11:18:04]  error opening ws message: {"category":"console","type":"log","data":["Log level is: ",5]}
[11:18:04]  error opening ws message: {"category":"console","type":"log","data":["DEVICE READY FIRED AFTER",1568,"ms"]}

same here  with  "devDependencies": {
"@ionic/app-scripts": "1.0.0",
"typescript": "2.0.9"
},
error opening ws message: {"category":"console","type":"info","data":["Ionic Storage
driver:","asyncStorage"]}

Same here debugging to phone:
$ ionic run android -l -c --target blabla
...
[23:25:16]  error opening ws message: {"category":"console","type":"log","data":["DEVICE READY FIRED AFTER",5603,"ms"]}
[23:25:16]  error opening ws message: {"category":"console","type":"info","data":["Ionic Storage
driver:","asyncStorage"]}
[23:25:16]  error opening ws message: {"category":"console","type":"info","data":["Ionic Storage
driver:","asyncStorage"]}
[23:25:16]  error opening ws message: {"category":"console","type":"info","data":["Ionic Storage
driver:","asyncStorage"]}
[23:25:16]  error opening ws message: {"category":"console","type":"info","data":["Ionic Storage
driver:","asyncStorage"]}


Make the API sexy

createQNCache()? What I was thinking about?

Done with version 3.3.0 https://github.com/Fewlaps/quitnow-cache/releases/tag/v3.3.0


feat(alerting): Add condition results to Pushover

Summary

Includes conditions within messages
Updates default title to Gatus: <endpoint>
Enables HTML mode

Fixes #787
iOS Screenshots
Notification

In-App

Checklist

[x] Tested and/or added tests to validate that the changes work as intended, if applicable.
[x] Updated documentation in README.md, if applicable.

Thank you for the contribution!


Document in CONTRIBUTING how to create a new sample

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [x] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Mention any other details that might be useful
It would be good to document how to create a new sample (the structure of the readme, the automatic generation of the workflow, to add it to the main readme....)

This issue is stale because it has been open 170 days with no activity. Remove stale label or comment or this will be closed in 10 days


[#4079] Fix IllegalStateException when HttpContentEncoder is used and…

… 100 Continue response is used.
Motivation:
Whe a 100 Continue response was written an IllegalStateException was produced as soon as the user wrote the following response. This regression was introduced by 41b0080fcc8fcace7cd62d238f6a932e79ec8bb1.
Modifications:

Special handle 100 Continue responses
Added unit tests

Result:
Fixed regression.

@trustin @gjesse please check

LGTM.

Cherry-picked into 4.0 (16d136dc55bca6f6b77568fed65c94334f9eb508) , 4.1 (e59ae12b4239b08c000bb382cd1d9068fd8a8fea) and master (a7d3372b3d924ac43993bc4d9743ab29186e6e61)

late to the party, but yes this looks good, thanks!


start.sh

I wanted to share my start.ps1 to see if that is the issue. When I try to start the docker file I get an error of:
node:internal/modules/cjs/loader:936
throw err;
^
Error: Cannot find module '/app/docker'
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
at Function.Module._load (node:internal/modules/cjs/loader:778:27)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
at node:internal/main/run_main_module:17:47 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}

Spoke to zyzyx over Discord. I'm fairly sure the issue is the back-tick on line 14 of the start.ps1 script as they're on Windows.
They're gonna give it another shot and report back.


Update Interconnect to 1.8.2 version

There are some issue with the current version (race condition / connection) that may be fixed

[x] Update DataCenter
[ ] Update Edge-gateway

Fixed with in data-center with https://github.com/rhpds/agnosticv/pull/18813


Backwards compatibility Testing

Description:
Testing for backwards compatibility to ensure that current users will not be impacted when we turn this feature on, and that they can continue to easily open their existing form files.
Acceptance Criteria:
Testing with legacy forms: (Dave to connect with Tim on the weird bugs)

[x] Test to make sure Repeating Sets is compatible ❌
[x] Test to make sure that file upload is compatible ❌

Testing with pre-existing/legacy Forms

[x] BUGS DETECTED: Get some draft forms setup in the DB as legacy content with the feature off. Turn on the feature --- go to edit ensure things look as expected ❌
[x] Test functionality of pre-existing Published Forms once we turn on the Feature Flag ✅
[x] Upload a JSON file from Prod into Staging to test out pre-existing Form Templates ✅

Running into an issue where I replicate a scenario of a Draft form (with show/hide), and once I turn the Feature Flag on, the questions no longer appear in the Edit screen (but it appears in the Preview screen).
Private Zenhub Video

For the same form:

the Start Page and Confirmation page don't show up
I get an error when I try to navigate to the "Translations" tab or Add a Page
Branching also looks strange

Private Zenhub Video

A note on Abi's test case- I found the same, but just to note that if you re-import the JSON with the Feature Flag ON, it seems to work fine.

PR - for POC to turn on Repeating sets
https://github.com/cds-snc/platform-forms-client/pull/4085
This fixes an issue where the inputs weren't showing up --- this doesn't fix the "99 questions id issue" --- potentially this could be used to update existing forms with repeating sets.

@Abi-Nada
Thinking we should close this one out and pick up under the repeating sets epic?
Believe all works fine with forms that are already published and folks can't use repeating sets or uploads yet for new forms.


Arrow functions with the concise body syntax do not currently work

See README - Caveats

:tada: This issue has been resolved in version 1.1.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


issue_39_moveCheck Testing of the ServiceFilter instance to be agnostic of its underlying purpose

PR build is green.

tx!


Add landscaper component for the Gardenlet

How to categorize this PR?

/area documentation
/area usability
/kind enhancement
/priority normal
What this PR does / why we need it:
Adds the landscaper component for the Gardenlet.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The Makefile includes a statement for local execution.
However you need to provide a valid import file with kubeconfigs for your Garden and Seed cluster as well as the configuration of the to-be registered Seed cluster.
I added documentation describing the required configuration.
Contact me if something is unclear.
The component descriptor included in this PR has the latest Gardenlet version v1.12.4.
@schrodit  for testing in a real landscaper installation, the blueprint has to be updated.
Release note:

Adds the initial version of the landscaper component to deploy a standalone Gardenlet.

Successful test run in landscaper together with @schrodit

Addresses review comments PTAL

/assign

/author-action

I updated the PR.
What still needs to be resolved is that importing types from the landscaper repository pulls many unrelated packages and also breaks the build.
Previously I resorted to defining the simple type in the g/g repository but that is not desired.

Unfortunately, there are package import issue with additional etcd package dependencies that are being pulled in by the landscaper or the spec bindings.

ERRO Running error: S1038: failed prerequisites<EMAIL_ADDRESS>isgenerated@github.com/gardener/gardener/pkg/registry/core/backupbucket): analysis skipped: errors in package: [/Users/d060239/go/src/github.com/gardener/gardener/pkg/registry/core/backupbucket/strategy.go:32:2: could not import k8s.io/apiserver/pkg/registry/generic (/Users/d060239/go/src/github.com/gardener/gardener/vendor/k8s.io/apiserver/pkg/registry/generic/storage_decorator.go:23:2: could not import k8s.io/apiserver/pkg/storage/storagebackend/factory (/Users/d060239/go/src/github.com/gardener/gardener/vendor/k8s.io/apiserver/pkg/storage/storagebackend/factory/etcd3.go:30:2: could not import go.etcd.io/etcd/clientv3 (/Users/d060239/go/src/github.com/gardener/gardener/vendor/go.etcd.io/etcd/clientv3/client.go:29:2: could not import go.etcd.io/etcd/clientv3/balancer (/Users/d060239/go/src/github.com/gardener/gardener/vendor/go.etcd.io/etcd/clientv3/balancer/balancer.go:24:2: could not import go.etcd.io/etcd/clientv3/balancer/picker (/Users/d060239/go/src/github.com/gardener/gardener/vendor/go.etcd.io/etcd/clientv3/balancer/picker/err.go:37:53: PickOptions not declared by package balancer)))))]]

@schrodit can the imports of the landscaper and spec-bindings be tidied up to not pull so many unrelated packages?

Unfortunately, there are package import issue with additional etcd package dependencies that are being pulled in by the landscaper or the spec bindings.

ERRO Running error: S1038: failed prerequisites<EMAIL_ADDRESS>isgenerated@github.com/gardener/gardener/pkg/registry/core/backupbucket): analysis skipped: errors in package: [/Users/d060239/go/src/github.com/gardener/gardener/pkg/registry/core/backupbucket/strategy.go:32:2: could not import k8s.io/apiserver/pkg/registry/generic (/Users/d060239/go/src/github.com/gardener/gardener/vendor/k8s.io/apiserver/pkg/registry/generic/storage_decorator.go:23:2: could not import k8s.io/apiserver/pkg/storage/storagebackend/factory (/Users/d060239/go/src/github.com/gardener/gardener/vendor/k8s.io/apiserver/pkg/storage/storagebackend/factory/etcd3.go:30:2: could not import go.etcd.io/etcd/clientv3 (/Users/d060239/go/src/github.com/gardener/gardener/vendor/go.etcd.io/etcd/clientv3/client.go:29:2: could not import go.etcd.io/etcd/clientv3/balancer (/Users/d060239/go/src/github.com/gardener/gardener/vendor/go.etcd.io/etcd/clientv3/balancer/balancer.go:24:2: could not import go.etcd.io/etcd/clientv3/balancer/picker (/Users/d060239/go/src/github.com/gardener/gardener/vendor/go.etcd.io/etcd/clientv3/balancer/picker/err.go:37:53: PickOptions not declared by package balancer)))))]]

@schrodit can the imports of the landscaper and spec-bindings be tidied up to not pull so many unrelated packages?

I had a look at the package dependency and why the etcd is needed -> the etcd package is used by helm which we use in the helm deployer.
But anyhow I think we will run into more of such issues in the future, as we have to keep the gardener and landscaper in sync. Maybe we should rather think of creating a separate module (lets see if a module is enough or if we also need an additional repository) for the apidefinitions and constants.
WDYT @Diaphteiros @hendrikKahl @MrBatschner

Unfortunately, there are package import issue with additional etcd package dependencies that are being pulled in by the landscaper or the spec bindings.

ERRO Running error: S1038: failed prerequisites<EMAIL_ADDRESS>isgenerated@github.com/gardener/gardener/pkg/registry/core/backupbucket): analysis skipped: errors in package: [/Users/d060239/go/src/github.com/gardener/gardener/pkg/registry/core/backupbucket/strategy.go:32:2: could not import k8s.io/apiserver/pkg/registry/generic (/Users/d060239/go/src/github.com/gardener/gardener/vendor/k8s.io/apiserver/pkg/registry/generic/storage_decorator.go:23:2: could not import k8s.io/apiserver/pkg/storage/storagebackend/factory (/Users/d060239/go/src/github.com/gardener/gardener/vendor/k8s.io/apiserver/pkg/storage/storagebackend/factory/etcd3.go:30:2: could not import go.etcd.io/etcd/clientv3 (/Users/d060239/go/src/github.com/gardener/gardener/vendor/go.etcd.io/etcd/clientv3/client.go:29:2: could not import go.etcd.io/etcd/clientv3/balancer (/Users/d060239/go/src/github.com/gardener/gardener/vendor/go.etcd.io/etcd/clientv3/balancer/balancer.go:24:2: could not import go.etcd.io/etcd/clientv3/balancer/picker (/Users/d060239/go/src/github.com/gardener/gardener/vendor/go.etcd.io/etcd/clientv3/balancer/picker/err.go:37:53: PickOptions not declared by package balancer)))))]]

@schrodit can the imports of the landscaper and spec-bindings be tidied up to not pull so many unrelated packages?

I had a look at the package dependency and why the etcd is needed -> the etcd package is used by helm which we use in the helm deployer.
But anyhow I think we will run into more of such issues in the future, as we have to keep the gardener and landscaper in sync. Maybe we should rather think of creating a separate module (lets see if a module is enough or if we also need an additional repository) for the apidefinitions and constants.
WDYT @Diaphteiros @hendrikKahl @MrBatschner

@schrodit Isn't a dedicated package for the APIs good enough?

@schrodit Isn't a dedicated package for the APIs good enough?

Isn't a dedicated package for the APIs good enough?

They are already in a separate package  (https://github.com/gardener/landscaper/tree/master/pkg/apis/core).
I see that you only import the apidefinitions in the pkg/apis directory which do not require the etcd package.
The etcd and k8s.io/apiserver are only used in pkg/deployers/helm.

Isn't a dedicated package for the APIs good enough?

They are already in a separate package  (https://github.com/gardener/landscaper/tree/master/pkg/apis/core).
I see that you only import the apidefinitions in the pkg/apis directory which do not require the etcd package.
The etcd and k8s.io/apiserver are only used in pkg/deployers/helm.

@schrodit do you got already a plan on how you want to resolve this on your side?
I think this should be tackled quite soon as it is blocking this PR from getting merged since a while.
Additionally, let's please not make drastic API changes for the go-spec-bindings anymore (at least not frequently) because we need some stability if we want to build the landscaper components.

@schrodit do you got already a plan on how you want to resolve this on your side?
I think this should be tackled quite soon as it is blocking this PR from getting merged since a while.
Additionally, let's please not make drastic API changes for the go-spec-bindings anymore (at least not frequently) because we need some stability if we want to build the landscaper components.

Latest commit of the Gardener landscape solved the dependency issue. However, I think there are still a bunch of unrelated packages that are being pulled in.
I think we can move ahead. with this PR and review & test it.
I can also make a little introductory session on how to test it etc.

Latest commit of the Gardener landscape solved the dependency issue. However, I think there are still a bunch of unrelated packages that are being pulled in.
I think we can move ahead. with this PR and review & test it.
I can also make a little introductory session on how to test it etc.

@danielfoehrKn that would be great!

@danielfoehrKn that would be great!

/merge/squash

/merge/squash

close. in favor of #3627


feat(moac): serialize all CSI create and publish requests

It is done to workaround for blocking connect in mayastor but not only
that. It will improve the overall readability of logs and
debuggability of the issues.
As part of that the CSI method implementation were rewritten to adhere
to async paradigm instead of combining callbacks with await in a
single function which was messy.
Resolves: CAS-935

bors merge


Code Release

Hi,
This work is very interesting!
Are you planning to release the code? If yes, what is the approximate timeline for that?
Thanks a lot!

The evaluation code and pre-trained models have been released. Please refer to answer for the future timetable.