./gradlew signingReport does not work

Whenever I put the command it does not work, my plugin is at the latest version and I have it set in the build.gradle ...
I don't know what could be happening.

Hi @Hekhy
Have you tried flutter clean and flutter pub get?
Thank you

Yes, I have tried it now and the same thing happens

Have you tried adding a direct firebase core dependency to your pubspec.yaml?
firebase_core: ^1.2.1

Yes, and here is the same error

I have tried directly executing the gradlew.bat file and I get this error

Apparently the gradle that android uses is version 6.7 as you can see in the left panel the folder with version 6.7 appears, but it needs version 7.0
This seems to be a flutter error when generating the android files, because I also tried deleting the android folder and executing the flutter create command. and it remains the same, I even tried a new project and the same thing happens.

I haven't been able to reproduce the issue and as far as I can see there are no other who have faced it. What I can recommend is that you upgrade your flutter to the latest version on whatever channel you are using and then see if the gradle plugin version and the dependencies in both the android folder build.gradle and app-level build.gradle are the same.
SInce we can't reproduce this and you have somewhat of a workaround that solves the issue for you I'm going to close the issue.

I have the updated version for a long time, I do not know what the problem is but it is clear that something is happening, I understand that the problem is closed but they should work on it.


fix:#7 added new styles to heading✌

I have added some new styles in the heading

It is good but try to change font as well and give it some funky look. You can look for different fonts in google fonts

ok

I have added the new styles

I have merged one pull request so first, you need to do git pull to update your local repo and then make changes and create a pull request.

my local repo is already updated and i made the necessary changes,do i have to push the commits again ?


Import fatal error

Hello, I was trying to import helper.h like this
#include <../zmk-nodefree-config/helper.h>
but I got this error
fatal error: ../zmk-nodefree-config/helper.h: No such file or directory
some tips to fix it?
Link to my repo
Thank you

I found my error I have to use "" not <>. Sorry


M2 WDL should call picard version of CollectArtifactSequencingMetrics until GATK4 public has embedded picard jar

GATK4 ported version has a bug:  https://github.com/broadinstitute/gatk/issues/2351
Please note that a conversion step will be necessary to rename the class that is generated in the metrics file in picard.
Something like:
CollectSequencingMetricsPicardJar -->  ConvertCollectSequencingMetricsToGATK --> FilterByOrientationBias

Ask @LeeTL1220 for that conversion step.  He has some WDL that does that.
Also note that this issue may be obviated if/when GATK4 wraps the picard jar.

Already done.


[3532] Add default kept scope to user mode

Context
https://trello.com/c/Z9uH4OZB/3532-only-show-kept-users-on-orgusers-list
Changes proposed in this pull request
Add default scope to users to prevent showing discarded
Guidance to review
Checklist

[ ] Make sure all information from the Trello card is in here
[ ] Attach to Trello card
[ ] Rebased master
[ ] Cleaned commit history
[ ] Tested by running locally

 Only show "kept" users on org#users list


Topic/web bridge

This is a new plugin w/ optional compile. This should be low-risk.

Is there a JIRA ticket for this?


getItem & setItem is not available

Current behavior
AsyncStorage in react-native has getItem & setItem methods that is working good.
Its not working after migrating to this repository.

As per the documentation in "README", after migrating to this repository, above mentioned methods are not available and so not working
Expected behavior
Update the documentation.

Both Async Storage version have the same API. Can you be more specific ?

I accidentally ran upon the same issue, but it had to do that I was looking at multiple documentated usages, one using the old API directly from react native core.
The old api was documented as importing like:
import { AsyncStorage } from 'react-native';
while using this library you import the default insteadl, like this:
import AsyncStorage from '@react-native-community/async-storage';

If more issue arise, please reopen with more details, thanks


Having Featured Stats as persistent leaderboards per in-game level

Hello!
As I understand it, featured stats are only temporary statistics, that are wiped at the beginning of each month. How would you go about to have (in-game) leaderboards, which are persist "forever"? We want to have about 100+ unique leaderboards for each of the levels in the game, which also would go against the 20 featured leaderboard limit. Do we need to use some other service for this use case? Thanks in advance!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 65e69968-d4a3-08b5-da8a-9f33c4298bb9
Version Independent ID: cfa84b0e-21a3-091f-7324-91974b79332f
Content: Player Stats - UWP app developer
Content Source: windows-apps-src/xbox-live/leaderboards-and-stats-2017/stats2017.md
Product: windows
GitHub Login: @aablackm
Microsoft Alias: aablackm

Hello lidin,
Featured Stats are persistent over time, but to attain the number and type of leaderboards you mentioned here you will need to use the Stats 2013 and Leaderboards 2013 services. The Stats 2013 service is described in the Player Stats article. However, it is not available to Creator's Program titles. In order to use this service you will need to have an ID@Xbox or Managaed partner title. You can read about the different developer programs in the Developer Program Overview.


Additional description of lithology field in collections form, geologic optional fields

Please make this a bigger text box so that multiple lines are viewable as you type them. (Like what we have on the "Notes on stratigraphy" field just below.

This is in paleobot/pbot-client@fe94a312f128f2f98791a11cbb507dcc780fdef0
merged to master, running on dev and stage


Pic shown sideways

Hey,
your EasyPix module is great, but I have one pic that is always shown sideways and I can't rotate it.
Have you had the problem before?
Best regards,
Denis

No sir, I have not, nor has anyone else that I know of. If it is just one picture then you can assume it's the picture that is causing the issue

Yeah it's probably the picture.


Warning when providing an unknown argument to defineComponent

What problem does this feature solve?
When typing "mixin" instead of "mixins". The mixin will fail silently, but there will be no error message. Providing an error or warning while Vue is in development would provide a quick pointer to the developer that they made a typo.
Silent failures are the worst.
What does the proposed API look like?
I imagine that you could iterate over the defineComponent arguments and test that they are within an array of known argument names. Even a general warning like "you have includedd a non-standard argument"

This is expected and has been raised before. In vue, plugins can add anything.
The best to avoid these silent failures is to use types like TS


ReactNative 0.71.1 - SourceMap not uploaded

Describe the bug
When i'm trying to build on release mode my RN project, i can see on my output window some error from bugsnag, and the sourcemap wasn't uploaded on the Dashboard.
Bugsnag: unable to find ReactNative bundle task 'bundleDevReleaseJsAndAssets'

After some research, i found out gradle task was renamed from 'bundleDevReleaseJsAndAssets' to 'createBundleDevReleaseJsAndAssets'.
As we can see on the github of ReactNative :
https://github.com/facebook/react-native/blob/cd5a8c48c59a0ecac21b19787ed8951dc23f57bb/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/TaskConfiguration.kt#L55
This changement was made for the 0.71.+ before that the name of the Gradle task is correct.
They are other changement made to this version
The file index.android.bundle.map is still located to the same directory : android/app/build/generated/sourcemaps/react/release
But the file index.android.bundle was move on an another folder
Before: android/app/build/generated/assets/react/release
After : android/app/build/ASSETS/createBundleReleaseJsAndAssets/
Steps to reproduce : 0.70.6

npx react-native init test --version 0.70.6
cd test/android
./gradlew task | grep JsAnd
Output

bundleDebugJsAndAssets - bundle JS and assets for Debug.
bundleReleaseJsAndAssets - bundle JS and assets for Release.

Steps to reproduce : 0.71.1

npx react-native init test
cd test/android
./gradlew task | grep JsAnd
Output

createBundleReleaseJsAndAssets

Environment

React Native : 0.71.1
Gradle version: 7+
"@bugsnag/source-maps": "2.3.1"
"@bugsnag/react-native": "^.18.2"

Hi @Elvinra,
Thanks for bringing this to our attention. We’ve identified an issue that we believe to be causing this and our engineers will work on a fix for this soon. We will make sure to keep you updated with the progress!

Hey @mclack, do you have any update? RN 0.71 was released more than month ago

Hi @Rag0n,
After some additional investigation it appears the structure of the ReactNative bundle task has changed completely, and will require significant work to our plugin in order to support both the old and new structures.
While we work on this, we would advise to invoke our JS bugsnag-source-maps upload-react-native CLI tool manually https://docs.bugsnag.com/build-integrations/js/source-maps-react-native/
We will post here as soon as we have further updates.

@johnkiely1 any news regarding this?

Hi @ruslan-hontar. No updates I'm afraid, this is still on the backlog and other priorities have meant we haven't been able to work on it as yet.  We will update as soon as we have anything to share.

Chiming in here to say this issue is pretty pressing for our team. The past few releases have unusable errors in them. We would love to see a fix become a priority.

Just to keep you updated, we have now released a new version of the BugSnag CLI to help plug this gap. Rather than hooking into your Gradle build itself, this solution runs after the build to upload the source maps.
For now this will require some manual integration, however you can expect some updates in due course that will reduce the setup steps somewhat.
For information, please see our docs: https://docs.bugsnag.com/platforms/react-native/react-native/rn071/

Thanks @tomlongridge we had stumbled onto that by chance. This may be the wrong forum for this but what's the difference between that the cli you referenced and @bugsnag/react-native-cli on npm?

For new projects, our @bugsnag/react-native-cli is now compatible with RN 0.71 and 0.72 directory structures - it uses the BugSnag CLI to perform the uploads outside of Gradle (and the bugsnag-android-gradle-plugin) so that we're not tied to changes going on in the Gradle build that seem to be going on in the React Native tooling.
The bugsnag-android-gradle-plugin should now only be used to upload native Android files (ProGuard mappings and SO files) and the BugSnag CLI (now with an NPM wrapper) used for Android source map uploads. Users can remove/disable the uploadReactNativeMappings configuration option in bugsnag-android-gradle-plugin.
We have also updated our docs page to give a run down of what people upgrading to RN 0.71+ and their BugSnag integration need to do: https://docs.bugsnag.com/platforms/react-native/react-native/showing-full-stacktraces/
In future iterations, we aim to also support the Cocoa platforms in the CLI and so consolidate the instructions further.


md-button-toggle [checked] input doesn't work when we click inside the tag class "label-content"

Bug, feature request, or proposal:
Bug
What is the expected behavior?
When we click inside a "md-button-toggle" element, the [checked] input should be done, regardless the position where we click.
What is the current behavior?
If we click inside the "label-content", the [checked] input doesn't change. But if we click outside (between "md-button-toggle" tag and "label-content"), it works.
What are the steps to reproduce?
Here my plunker. Click on the green area to see when it works, then click on the red area to see when it fails.
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Is there anything else we should know?

Still have this bug, with version 5.2.2

I wasn't able to reproduce it with the latest version. Closing since this hasn't had any activity in a while.


Dynamically named screenshots

What is the current behavior?
Hello,
I am trying and are unable to crawl trough a page and create a screenshot for all the pages and name the screenshots after the current url.

Version:
Platform / OS version:
Node.js version:

Im having this same issue
code is like this
const startCrawler = async () => {
  const crawler = await HCCrawler.launch({
    /* eslint-disable no-undef */
    browserCache: false,
    evaluatePage: () => ({
      title: $('title').text(),
      body: $('body').html()
    }),
    /* eslint-enable no-undef */
    onSuccess: result => {
      console.log(result);
    },
    onError: err => {
      console.log(err);
    }
  });
  await crawler.queue(
    urlList.map(c => ({
      url: c,
      userAgent: pickRandomElement(userAgents),
      screenshot: {
        path: `./sreenshots/${Buffer.from(c).toString('base64')}.png`
      }
    }))
  );
  await crawler.onIdle(); // Resolved when no queue is left
  await crawler.close(); // Close the crawler
};

@igna92ts why are you using map on crawler queue? I think you should don't use map iside crawler queue. I can't test it right now, but I will do.

Well, in the documentation it says I can queue multiple urls at once, I dont see the issue with that map.
Its the same as instead of doing
await crawler.queue(
    urlList.map(c => ({
      url: c,
      userAgent: pickRandomElement(userAgents),
      screenshot: {
        path: `./sreenshots/${Buffer.from(c).toString('base64')}.png`
      }
    }))
  );

doing
await crawler.queue(
    urlList.map([{
      url: c,
      userAgent: pickRandomElement(userAgents),
      screenshot: {
        path: `./sreenshots/${Buffer.from(c).toString('base64')}.png`
      }
    }]))
  );

Which, at least according to the docs, should be fine to do

Your code looks fine. But when you use map inside queue you are calling crawler queue only one time. I think that this could be the issue.

yes but in the documentation in the first example its also doing just that
`const HCCrawler = require('headless-chrome-crawler');
(async () => {
const crawler = await HCCrawler.launch({
// Function to be evaluated in browsers
evaluatePage: (() => ({
title: $('title').text(),
})),
// Function to be called with evaluated results from browsers
onSuccess: (result => {
console.log(result);
}),
});
// Queue a request
await crawler.queue('https://example.com/');
// Queue multiple requests
await crawler.queue(['https://example.net/', 'https://example.org/']);
// Queue a request with custom options
await crawler.queue({
url: 'https://example.com/',
// Emulate a tablet device
device: 'Nexus 7',
// Enable screenshot by passing options
screenshot: {
path: './tmp/example-com.png'
},
});
await crawler.onIdle(); // Resolved when no queue is left
await crawler.close(); // Close the crawler
})();`

Yep, you're right, but i cannot see custom options inside the crawler queue array. I've tried to use the example as you are using, but it didn't worked for me. So i had to call crawler.queue ever time i need to use it

I just tried to save a screenshot with a single queue and still didnt work 😢

What code are you using? Please, post your node version and environment

Im on node v8.9.4 and in maxOS high sierra v10.13.6

I just tried to save a screenshot with a single queue and still didnt work 😢
If I check whats on result in the onSuccess it does have a property screenshot but its undefined rather than being the image buffer as it said in the docs.
Maybe im doing something else wrong? 🤔

When i use the example code provided on README, it returns the screeshot buffer.
result: { title: 'Example Domain' },
  screenshot:
   <Buffer 89 50 4e 47 0d 0a 1a 0a 00 00 00 0d 49 48 44 52 00 00 03 20 00 00 02 58 08 06 00 00 00 9a 76 82 70 00 00 20 00 49 44 41 54 78 9c ec dd 77 54 14 d7 df ... >,
  cookies: [],
  links: [ 'http://www.iana.org/domains/example' ] }

I was reading the Puppeteer docs, and it says:
Puppeteer docs

NOTE Screenshots take at least 1/6 second on OS X. See https://crbug.com/741689 for discussion.

But you are using MacOS Hight Sierra. I think that the bug is still alive. I tryed the demo code for a single screenshot using linux (since i don't have a mac) and  your node version and i tryed too using node 10.15.0 . For all my tests, i get the screeshot buffer. So, since i dont have a mac, i cant help you. I suggest you to try to use a newerly node.js version, and try again. If you want to use, i'll put my test code below if you want to test
const HCCrawler = require('headless-chrome-crawler');
//const path = require("path");
const PATH = './print/';

(async() => {
  const crawler = await HCCrawler.launch({
    // Function to be evaluated in browsers
    evaluatePage: (() => ({
      title: $('title').text(),
    })),
    // Function to be called with evaluated results from browsers
    onSuccess: (result => {
      console.log(result);
    }),
  });
  await crawler.queue({
    url: 'https://example.net/',
    screenshot: {
      path: Buffer.from(`./print/PRINT.png`),
      type: 'png'
    },
  });

  await crawler.onIdle(); // Resolved when no queue is left
  await crawler.close(); // Close the crawler
})();

@igna92ts is this issue resolved? If so, could you post the solution summary here?

Leaving this here for posterity, since I ran into the same issue: link
        this.crawler = await HCCrawler.launch({             maxConcurrency: 1,             preRequest: ((options:any) => {                 // if (!options.saveAs) return false; // Skip the request by returning false                 console.log(options)                 let splitted_url = options.url.split('/');                 let page = splitted_url[splitted_url.length - 1];                 if(!page) {                     page = 'HOME-' + Math.floor(Math.random());                 }                 options.screenshot = {                     path: './tmp/IMG-' + splitted_url[2] + '-' + page + '-'  + '.png',                     fullPage: true                 };                 return true;             }),             evaluatePage: ...


ADD TOPIC (to end of list)

in version 1.51 the ADD TOPIC (to end of list) isn't working

Hi,
It's a fresh instalation (docker) - with empty DB

OK, I tried with a fresh Docker 1.5.1 - "Quick Add Topic" works for me (Mac with Chrome Browser)
1.) First: You know you have to press ENTER key, to trigger the Add functionality?
2.) If you enter some text, then press ENTER what happens? Nothing?
3.) Could you provide us your operating system and browser and version number of browser?
4.) If you know how to open your browser's JavaScript console, please open console and see if there is an error message when you press ENTER on "Quick Add Topic to End of List Field"?
Thankx in advance.

Ok,
1.) It's the Add new topic but to the END of list.
2.) It saves the TEXT ok
3.) Win7 whit Chrome Broswer
4.) I  have restarted the docker and now it works OK
4.a) The look however changed a little, i.e. the icons at the end of line of the topic are now diferent , before they were square ..??? weird

Great to hear, it works now.
When the icons ware square, then the "Icon Font" we use was not loaded correctly. So maybe the whole application was not yet loaded correctly in the browser. Maybe the reason for other strange behavior.
We'll keep this issue open for a few more days.
Please comment here, if the problem re occurs.
If not, I will close this issue then.
Thx. & have fun.
(We are in preparatin of bugfix release 1.5.2 - I woulod recommend to wait til this version before using 4Minitz in production).

Off topic question:
is there an IRC channel or mailing list for submitting questions, because it does not make sense via issues/bugs?

Please comment here, if the problem re occurs.

Apparently it didn't reoccur, so I'll close this. Reopen this or open a new issue if the problem came up again.


Refactor Codegen phase

Purpose
Remove unnecessary classes from interop
Fix code quality warnings
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

@madushajg @gayaldassanayake Can u check these changes too.


cleanup & modernization

A while ago, I attempted a refactoring of this library in: https://github.com/sachaw/micro-web-flasher
However I have seen the recent effort in the typescript migration, I thought I'd focus my efforts here.
This will stay a draft PR until I'm happy with the state and have addressed any of the other developers concerns.
I hope this effort can bring the library more inline with current practices and be a major boost in maintainability.

Big PRs like this have very little chance of getting merged. If you want to do cleanups, please open PRs that address single issues.


Skip PIN and Fingerprint

Not sure if this one is an issue
When creating a new account. I can skip both.
Whos to say that someone else wont take my phone after and while loging in set up a password or Fingerpring that I dont have and I cant recover my account.

Yes


Find Path in BST program

Code the given problem in any of the programming language. The code should be correct without any extra keywords or spaces in between.
Statement:
Given a BST and an integer k. Find and return the path from the node with data k and root (if a node with data k is present in given BST) in a list. Return empty list otherwise.
Note: Assume that BST contains all unique elements.
Input Format:
The first line of input contains data of the nodes of the tree in level order form. The data of the nodes of the tree is separated by space. If any node does not have left or right child, take -1 in its place. Since -1 is used as an indication whether the left or right nodes exist, therefore, it will not be a part of the data of any node.
The following line of input contains an integer, that denotes the value of k.
Output Format:
The first line and only line of output prints the data of the nodes in the path from node k to root. The data of the nodes is separated by single space.
Constraints:
Time Limit: 1 second
Sample Input:
8 5 10 2 6 -1 -1 -1 -1 -1 7 -1 -1
2
Sample Output:
2 5 8

I can solve this using Python. Please assign me.


[CSL-1758] Track installed updates in MiscDB

I had to rebase it after #1840 — @gromakovsky, review again?


drmare-music-converter-for-spotify: Add version 1.4.1

Can you install manifest from local without any problem? I am facing this weird issue, which I suspect is only on my end.

Yes it is working for me. But I had a "regular" install done before. Could it be a dependency thing ?

Hello, is there still any issue preventing the merge of this pull request?


Added Open NewTab Color

Summary of the Pull Request

References

PR Checklist

[x] Closes #xxx
[ ] CLA signed. If not, go over here and sign the CLA
[x] Tests added/passed
[x] Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
[ ] Schema updated.
[x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Thanks for the contribution! Unfortunately, this doesn't really seem like it's got any Terminal related code in it at all, so I'm gonna close this one. If you'd like any pointers on how I'd go about implementing #12412 myself, I can give you some pointers over in that thread. Thanks!


"Meaningful normal value"

In many contexts, nil is a special value meaning "no value" or similar. In many of those contexts, nil would not be a meaningful normal value anyway (or both meanings coincide), so there are no difficulties.

Mechanisms such as gethash already provide support for that behaviour, in form of a secondary return value that states whether the value was found (including a NIL that was found in the hashtable) or whether the value was not found.
What issue does your library solve that isn't already solved by the (much more standardized and popularized, I assume) mechanisms of returning an additional value for whether the object was found or not?

 The documentation (of which you already quoted a part of) already addresses all of your points. I expected better from you.

The documentation states, "Reserving nil as the special value is the right call in most contexts" without stating why exactly it is "right". I claim otherwise, that having a deliberate value marker for a function that can return any value does not solve any problem that multiple values do not solve; also, multiple return values already have high adoption as a value-returning idiom in the Lisp world (e.g. assoc-value and rassoc-value from Alexandria).
Moreover, using a value to denote a lack of value is not sound. Reserving another value, let's say, nil* as a stand-in for a meaningful "lack of value" simply moves the famous (find nil '(1 2 nil 3 4)) problem elsewhere. If we declare that nil* is the lack of value instead of nil, then, instead of being unable to represent the value nil, we are now unable to represent the value nil*. This might cause issues for example for functions which use fakenil and then iterate over all symbols; they may then interpret fakenil:nil* as a lack of value instead.

The documentation states, "Reserving nil as the special value is the right call in most contexts" without stating why exactly it is "right".

That's right, I am relying on my 13+ years of Common Lisp experience, here. (I recognize that the documentation for this project has not yet reached a platonic ideal, but I have much more important projects to work on.)
One of my favorite design decisions in definitions-systems is using the simpler API for defsys:locate (returning nil to indicate no definition found) instead of cargo-culting gethash. The reality is that almost nobody would ever need to use nil as a definition, and if someone somehow does need to, then fakenil would probably be a suitable solution in most of those rare contexts. If that's still not good enough for that highly sophisticated user, then they can trivially implement their own alternative to defsys:locate which does behave like gethash (and can fallback to defsys:locate by default with a default method). defsys:locate is also a frequently used operation (relative to all other operations supported by definitions-systems), and I would hate to take a small performance penalty just for the sake of gratuitous inconvenience.
Another library I'm working on, and which prompted me to finally create fakenil after years of always encountering the same damn problem, is a trivial protocol for arriving at a "guess" by consulting some "advisors", some of which may not have a particular preference in the matter. Here again, after initially considering to cargo-cult gethash, I decided to not support nil directly as a "normal value" (so an advisor returns nil if they don't know or don't care, not to choose nil as their preferred value). Instead of leaving open the issue of how to represent nil as a normal value or documenting the design decision, both of which are painful in some ways, I decided to reify and document the pattern once and for all with fakenil.

I claim otherwise, that having a deliberate value marker for a function that can return any value does not solve any problem that multiple values do not solve

Assuming that users indeed almost never need to represent nil as a "normal value" in that particular context, then using the single-value approach makes the API slightly simpler to use for users, and much simpler for implementors when you're designing an extensible protocol. While user code can normally trivially ignore the second returned value if it doesn't care about it, all implementors of extensions to your protocol do need to deal with that second return value explicitly, which can be quite a hassle. For instance, in my trivial consensus protocol one can just use some to return the guess of the first advisor who has an opinion on the matter. Having to deal with a second return value for each guess would be annoying.

multiple return values already have high adoption as a value-returning idiom in the Lisp world

No shit? I've been saying that multiple values is an underrated feature since at least 2012, and many of my libraries use multiple values in exposed parts of the API, such as its, parse-number-range and cartesian-product-switch, and I have some libraries entirely dedicated to the concept of multiple values such as enhanced-multiple-value-bind and multiple-value-variants. Needless to say, my code also heavily uses multiple values internally, but I don't care to dig examples of that...

(e.g. assoc-value and rassoc-value from Alexandria)

I extensively don't care about Alexandria, I haven't used in probably at least a decade. I don't dispute that it's a fairly well-designed "personal utilities library", but I've come to hate that very concept, and from my personal perspective Alexandria is already mostly obsolete, and with a few of the libraries I'll be releasing this year I think I should be able to build a pretty good case to announce that Alexandria is "officially" obsolete. I think it's useful to remember that Alexandria is so damn popular in large part because of the official Quicklisp download statistics which count both direct and indirect downloads. I think it would be very interesting to see how libraries stack up if only direct downloads are counted...

Moreover, using a value to denote a lack of value is not sound.

It is extremely practical and entirely or mostly sound in most contexts, and sometimes you just don't have a choice to conform to existing API's. Note that using a distinguished value to represent "no value" is a classic technique notably to implement unbound slots, although fakenil would certainly not be an appropriate value to use in that context. fakenil is not an approach that makes sense in all contexts, but then all approachs to all problems don't make sense in all contexts. My recommendation would be to use fakenil in contexts where it makes sense, and not use it in contexts where it doesn't make sense.

the famous (find nil '(1 2 nil 3 4)) problem

What the fuck? Using member is the classical, obvious solution. I know it's just an example, but it's particularly ridiculous.

Moreover, using a value to denote a lack of value is not sound. Reserving another value, let's say, nil* as a stand-in for a meaningful "lack of value" simply moves the famous (find nil '(1 2 nil 3 4)) problem elsewhere. If we declare that nil* is the lack of value instead of nil, then, instead of being unable to represent the value nil, we are now unable to represent the value nil*. This might cause issues for example for functions which use fakenil and then iterate over all symbols; they may then interpret fakenil:nil* as a lack of value instead.

I know all this, aren't you happy that we now have an obvious place where to document all these caveats? By reifying this extremely common pattern, we are better able to reason about its strengths and shortcomings and advise others about them.

My view is that it is better to use either 1) a non-local exit, possibly by signaling a condition or 2) using a value that is outside the logical codomain of the function to signal. Using nil* just creates another arbitrary symbol to worry about in all contexts.
I'm no longer going to put in effort on this package.

My view is that it is better to use either 1) a non-local exit, possibly by signaling a condition

Of course that's going to be the right solution in some contexts, but in others you would just be complicating the API for everyone (users, implementors, extension designers) for no reason.

or 2) using a value that is outside the logical codomain of the function to signal.

 Isn't that what fakenil already provides? Of course, in some contexts you would indeed need to us a truly unique value such as a gensym or something, in which case, don't use fakenil if it's not suitable.

Using nil* just creates another arbitrary symbol to worry about in all contexts.

Actually, a big part of the point of fakenil is that most code will be able to pass along nil* without having to know or care about it, it can just be returned somewhere and then go through some oblivious machinery and then at the other end something can finally care to distinguish it as a special value and do something appropriate about it such as treating it as a "normal value" of nil.

Your nearly information-free commentary also seems to exist for no real purpose. And I'm a nihilist. The target market for fakenil is those who understand why it might be useful, or otherwise derive some value from it, not those who are convinced it is not useful.

I'm no longer going to put in effort on this package. I suggest nobody else does either.

 I invite you to reflect on the unnecessary costs your impulsivity may inflict on yourself and others.

I know it's just an example, but it's particularly ridiculous.

It's an issue that has been long recognized as a mistake in the Common Lisp standard. A secondary value of t returned from (find nil '(1 2 nil 3 4)) would make it obvious that a nil was found in the list, and therefore find would be usable with a nil as its first argument.

It's an issue that has been long recognized as a mistake in the Common Lisp standard.

By whom? This is the first time I hear of this, and I am not convinced at all.

A secondary value of t returned from (find nil '(1 2 nil 3 4)) would make it obvious that a nil was found in the list, and therefore find would be usable with a nil as its first argument.

So what? I almost never want to find nil in a list anyway, and member provides a complete solution for the rare cases that I do, and member has other useful use-cases that justify its existence as well, so it's not like if it was there just to compensate for a design flaw in find.
I also wonder if your proposed design might sometimes incur a certain penalty cost, which I would not be eager to pay for, and I'm saying that as someone who mostly doesn't care about performance. Again, I just don't want to make my code slower just for the sake of gratuitous inconvenience...
I'm open to being convinced, but you'll have to provide more compelling arguments...

This issue is resolved to my satisfaction, so I'm going to close this.
Obviously, a cleaned up version of some of this content should be added to the documentation at some point, but this is a very low priority for me, as I have much more important projects to work on.
Those with further meaningful commentary (as demonstrated by phoe) are encouraged to append to this issue.


Made voice support optional

⚠Breaking Change⚠
I've changed voice support to require installation with pip install DiscordUtils[voice]. This should enable people who only want to use paginate or invite tracking to not need to install discord.py[voice] or its dependencies.
I have not been able to test locally. but it should be ok 🤞 tested, works
I have also not updated the version number, I'll leave that to you
close #24

@toxicrecker can this be reviewed/ merged pls

LGTM


implemented possibility to specify bodyContent

Implemented possibility to specify some specific bodyContent.
For example root element in ReactJS apps: ''

Just use it together with the https://github.com/jaketrent/html-webpack-template :)


Update Hardcoded Repo Name in Workflow

Updating checkout step to use ${{ github.repository }} for its path to help with transitioning to new org. Should be aliased, but might be nice to avoid confusion if someone is reviewing CI process.

Possibly related to Helm 2 being unsupported for test failure? https://helm.sh/blog/helm-2-becomes-unsupported/


htmx

where did you hear about this?

I don't think you can avoid hearing about it at this point lol, I'm just playing around with HTMX while looking at other neat projects/tools in the ecosystem like Air

You're getting into neovim too? Lmao
Let me know if you need any help setting up. I've been using it for a few years plus I maintain a few popular plugins.

Wait lol what gave that away? Yep I'm setting it up rn, but I still need to get more familiar with vim motions. The Normal mode doesn't really benefit me rn, I just go into insert lol.

I see you staring things on the GitHub home/activity page. Normal mode is king. I started with vim in vs code with the vim extension. Just get used to editing without using a mouse or arrow keys.


Apply code highlighting background to code in HTML headers
 through

This is an enhancement or feature.
Fixes #2780.
Summary

Modify _base.scss to apply code highlighting background to code in headers. It now looks like this. Notice the code in headers now has a grey background. Before this PR, code in headers would NOT get the grey background, which made it very hard to tell it was code!
.

Darken background color from #fafafa to $lighter-gray, since the former is so light it's hard to see.

Add Table of Contents to README. See this commit for details: cd2726cc52ea9400c55537cc9b87820b37f4a12a.

Update Rakefile to serve jekyll on port 4001 instead of 4000, so as to avoid conflicts with NoMachine. See my answer here for more background and info on this.

Update changelog.

Context

helps fix https://github.com/mmistakes/minimal-mistakes/issues/2770#issuecomment-752797477
helps fix https://github.com/mmistakes/minimal-mistakes/discussions/2278#discussioncomment-253708

The Table of Contents in the readme can be viewed here, just above the screenshots: https://github.com/ElectricRCAircraftGuy/minimal-mistakes/tree/upstream-theme_fixes. I made it collapsed by default so it doesn't distract from the main content.

This is a bit too messy.

I agree this is 3 small changes in one PR, but that's kind of hurtful. I've put great effort into making this PR clean, neat, easy to read, easy to understand, and well-described in the PR's description.
This PR is 3 small changes in one:

Apply code highlighting background to code in HTML headers
 through

Move the server port from 4000 to 4001 to avoid conflicts with users using NoMachine, such as myself, so I can even build the site and view it. This hurts no-one and helps some.
Add a table of contents to the readme to make it easier to jump around and read.

Changing large chunks of README that doesn't have much to do with the original intention isn't a good practice, nor do I like it though.

If someone with approval and merge authority wants me to split the PR, I can. Or, they can commandeer the PR and do it. If they want to accept only parts of it, the fastest way is for them to manually pull my branch, fix it up how they want it, and then merge it to the repo. My changes they want do get in, and any they don't, don't.

My real question is, is this change really useful to most users? Given that the CSS change is simple enough for one to apply on their own, and that some may argue that the result is not desired, I don't see much value in this PR.

On all 3 of the main markdown-based interactive sites in the world: Stack Overflow, GitHub, and GitLab, headers with code have the code shaded, like this:
I'm a header with code
Unfortunately, minimal mistakes theme doesn't follow this pattern. We can help meet a lot of people's expectations by merging this.
How many people are not web developers who use Jekyll, GitHub pages, and this minimal mistakes theme? I'd argue that it's most users. I am not a web developer. I didn't know hardly anything about CSS before I put in the 50+ or so hours tweaking this theme. It's very difficult for an aeronautical engineer (ex: me) or embedded software developer (also me) to learn to do these CSS changes. I find huge value in this PR. I wish someone had done it before me. I think others will be grateful for it too. Anyone who writes anything in markdown ever will notice when code doesn't show up in headings. It's one of the first things I ever noticed about this theme. I write a lot on Stack Overflow and GitHub, and this theme was missing that feature. I considered that a bug.
@iBug , thanks for reviewing. Do you have approval or merge authority on this repo?
I'd like to hear from @mmistakes too.

This is a bit too messy.

I agree this is 3 small changes in one PR, but that's kind of hurtful. I've put great effort into making this PR clean, neat, easy to read, easy to understand, and well-described in the PR's description.
This PR is 3 small changes in one:

Apply code highlighting background to code in HTML headers
 through

Move the server port from 4000 to 4001 to avoid conflicts with users using NoMachine, such as myself, so I can even build the site and view it. This hurts no-one and helps some.
Add a table of contents to the readme to make it easier to jump around and read.

Changing large chunks of README that doesn't have much to do with the original intention isn't a good practice, nor do I like it though.

If someone with approval and merge authority wants me to split the PR, I can. Or, they can commandeer the PR and do it. If they want to accept only parts of it, the fastest way is for them to manually pull my branch, fix it up how they want it, and then merge it to the repo. My changes they want do get in, and any they don't, don't.

My real question is, is this change really useful to most users? Given that the CSS change is simple enough for one to apply on their own, and that some may argue that the result is not desired, I don't see much value in this PR.

On all 3 of the main markdown-based interactive sites in the world: Stack Overflow, GitHub, and GitLab, headers with code have the code shaded, like this:
I'm a header with code
Unfortunately, minimal mistakes theme doesn't follow this pattern. We can help meet a lot of people's expectations by merging this.
How many people are not web developers who use Jekyll, GitHub pages, and this minimal mistakes theme? I'd argue that it's most users. I am not a web developer. I didn't know hardly anything about CSS before I put in the 50+ or so hours tweaking this theme. It's very difficult for an aeronautical engineer (ex: me) or embedded software developer (also me) to learn to do these CSS changes. I find huge value in this PR. I wish someone had done it before me. I think others will be grateful for it too. Anyone who writes anything in markdown ever will notice when code doesn't show up in headings. It's one of the first things I ever noticed about this theme. I write a lot on Stack Overflow and GitHub, and this theme was missing that feature. I considered that a bug.
@iBug , thanks for reviewing. Do you have approval or merge authority on this repo?
I'd like to hear from @mmistakes too.

I don't have any extra access to this repo than you do, but I'm sure @mmistakes's thoughts would be in line with mine.
Questions to ask before deciding a feature is useful:

Is there a strong demand for this?

Code background in headings: Mixed, some may prefer the status quo
README ToC: Good to have
Default listening port change: Probably no. Users are responsible for knowing their software. What's more, this repo is not intended to be forked for building your website (the starter repo is).

Does it complicate things or make it harder to maintain code?

Code background: It's simple enough. Nothing wrong with this.
README ToC: Apparently it does. Maintaining the ToC (and the unnecessary anchors - headings already have id attribute added automatically by GitHub) now requires extra effort.
Default listening port change: As said above. it's not a compelling reason to change Jekyll's default behavior just because another (not quite popular) software conflicts with it. It's going to cause confusion for whoever using the default setup.

Does it break for existing users, or is it easy enough for one to apply on their own?

Code background: Some users may simply don't want this change. Plus this CSS is straightforward to understand and apply.
README ToC: Not end-user facing, not discussing here.
Default port: This would greatly break existing setup and is very easy to apply.

Given the above arguments, I'm in favor of none of these changes.

I don't have any extra access to this repo than you do, but I'm sure @mmistakes's thoughts would be in line with mine.
Questions to ask before deciding a feature is useful:

Is there a strong demand for this?

Code background in headings: Mixed, some may prefer the status quo
README ToC: Good to have
Default listening port change: Probably no. Users are responsible for knowing their software. What's more, this repo is not intended to be forked for building your website (the starter repo is).

Does it complicate things or make it harder to maintain code?

Code background: It's simple enough. Nothing wrong with this.
README ToC: Apparently it does. Maintaining the ToC (and the unnecessary anchors - headings already have id attribute added automatically by GitHub) now requires extra effort.
Default listening port change: As said above. it's not a compelling reason to change Jekyll's default behavior just because another (not quite popular) software conflicts with it. It's going to cause confusion for whoever using the default setup.

Does it break for existing users, or is it easy enough for one to apply on their own?

Code background: Some users may simply don't want this change. Plus this CSS is straightforward to understand and apply.
README ToC: Not end-user facing, not discussing here.
Default port: This would greatly break existing setup and is very easy to apply.

Given the above arguments, I'm in favor of none of these changes.

Maintaining the ToC (and the unnecessary anchors - headings already have id attribute added automatically by GitHub) now requires extra effort.

This isn't quite true. It depends on your text editor. The ToC I added uses MarkdownTOC, which is a Sublime Text plugin. These markers:  work with the tool and every time I save the file the ToC is automatically updated without any intervention from me. It automatically updates all HTML anchors too.

Plus this CSS is straightforward to understand and apply.

I still disagree with this and think it would do a lot of people good. We could help many people by merging this change. If @mmistakes doesn't implement this change/merge this PR, I hope he at least documents what I've done officially. It took me a long time of research, spread out over months in evenings after work, and on weekends, to figure this out.

Maintaining the ToC (and the unnecessary anchors - headings already have id attribute added automatically by GitHub) now requires extra effort.

This isn't quite true. It depends on your text editor. The ToC I added uses MarkdownTOC, which is a Sublime Text plugin. These markers:  work with the tool and every time I save the file the ToC is automatically updated without any intervention from me. It automatically updates all HTML anchors too.

Plus this CSS is straightforward to understand and apply.

I still disagree with this and think it would do a lot of people good. We could help many people by merging this change. If @mmistakes doesn't implement this change/merge this PR, I hope he at least documents what I've done officially. It took me a long time of research, spread out over months in evenings after work, and on weekends, to figure this out.

While maintaining the ToC appears easy for you, it requires one to use Sublime Text and use that specific plugin, which obviously everyone does not. You can say "it's easy according to your workflow", but it doesn't necessarily hold true for someone else. The same holds for your other arguments.
The point here is, you speak from your experiences and perspectives, but as a 7.5k-star open-source project, we have to take other users' favor and dependency into account. That something works for you in no way implies it'll also work for someone else.
Unless there's a compelling reason to, default settings shouldn't be changed, nor should breaking changes be introduced. That's my $0.02.

While maintaining the ToC appears easy for you, it requires one to use Sublime Text and use that specific plugin, which obviously everyone does not. You can say "it's easy according to your workflow", but it doesn't necessarily hold true for someone else. The same holds for your other arguments.
The point here is, you speak from your experiences and perspectives, but as a 7.5k-star open-source project, we have to take other users' favor and dependency into account. That something works for you in no way implies it'll also work for someone else.
Unless there's a compelling reason to, default settings shouldn't be changed, nor should breaking changes be introduced. That's my $0.02.

nor should breaking changes be introduced.

Let's not consider you having to update a single bookmark to a new port a "breaking change." That's a bit of a stretch.

nor should breaking changes be introduced.

Let's not consider you having to update a single bookmark to a new port a "breaking change." That's a bit of a stretch.

I don't want to be too harsh, but here's my view on all three changes.
The core: CSS changes
The only change related to the title of this PR is code background is a few lines of new CSS, which could be simplified as such:
h1, h2, h3, h4, h5, h6 {
  > code {
    background: $code-background-color;
  }
}

After taking a closer look, I noticed that it isn't carefully done. For example, someone using code-in-heading combined with header overlay sees an ugly artifact:

So at best this CSS should be relocated inside .page__content here. Another good-to-have change would be replacing the CSS key with background-color so it doesn't override other background-related settings.
This is one way the change is breaking, though it can be easily fixed.
Again, just because you want this change doesn't mean someone else does. This is resembled by the fact that all your linked issues have no input or interaction from other users (excluding Michael, of course). See #2246 for example: Someone else opened that issue, and 3 more users showed interest in that feature.
The Readme ToC
I'll basically reiterate my last commment. You said you generated the ToC "easily" with your setup (Sublime Text + a plugin). In order for the same task to become comparably easy for someone else, they have to at best follow your setup, install and open Sublime Text and the plugin to update the ToC, after their own favorite workflow. For example, I use VS Code as my code editor / IDE, and occasioanlly Typora as my Markdown editor. It's nowhere near compelling that I have to add Sublime Text just for this ToC.
The port change
I'll put this point first: This repository is not intended for end users who want to build a website with this theme. It is therefore assumed that someone running rake preview or similar is a theme developer, not user. Based on this role assignment, it's then the developer's responsibility to know what tools they're using, and resolve software conflict by themselves.
Changing one bookmark for me surely isn't a great deal of a problem, making more people have to change their bookmarks is.
Setting that aside, it's not this theme's fault that the port conflicts with another software, so it makes less sense to "fix it" here than to fix it with Jekyll. Not to mention that NoMachine isn't as popular as other remote desktop (RD) solutions like VNC (default port 5900) and RDP (default port 3389). 4000 is a port just too common for a conflict, so I'd even doubt if a long-running software should use it.
Given that the port can be specified per invocation with command-line options, this is not a desirable change to have.
Summing up
So basically you squashed 3 unrelated changes into one PR that arguably makes reviewing and cherry-picking more complex than it should, and in addition this PR introduced

A change in theme appearance that is not perceived to be popular / demanded
A change in the README document that requires extra effort or software-and-workflow to maintain
A change in software setting that is both confusing and targetting the wrong audience

I'll copy my word from the previous comment as the last line, with emphasis added:

The point here is, you speak from your experiences and perspectives, but as a 7.5k-star open-source project, we have to take other users' favor and dependency into account. That something works for you in no way implies it'll also work for someone else.

I don't want to be too harsh, but here's my view on all three changes.
The core: CSS changes
The only change related to the title of this PR is code background is a few lines of new CSS, which could be simplified as such:
h1, h2, h3, h4, h5, h6 {
  > code {
    background: $code-background-color;
  }
}

After taking a closer look, I noticed that it isn't carefully done. For example, someone using code-in-heading combined with header overlay sees an ugly artifact:

So at best this CSS should be relocated inside .page__content here. Another good-to-have change would be replacing the CSS key with background-color so it doesn't override other background-related settings.
This is one way the change is breaking, though it can be easily fixed.
Again, just because you want this change doesn't mean someone else does. This is resembled by the fact that all your linked issues have no input or interaction from other users (excluding Michael, of course). See #2246 for example: Someone else opened that issue, and 3 more users showed interest in that feature.
The Readme ToC
I'll basically reiterate my last commment. You said you generated the ToC "easily" with your setup (Sublime Text + a plugin). In order for the same task to become comparably easy for someone else, they have to at best follow your setup, install and open Sublime Text and the plugin to update the ToC, after their own favorite workflow. For example, I use VS Code as my code editor / IDE, and occasioanlly Typora as my Markdown editor. It's nowhere near compelling that I have to add Sublime Text just for this ToC.
The port change
I'll put this point first: This repository is not intended for end users who want to build a website with this theme. It is therefore assumed that someone running rake preview or similar is a theme developer, not user. Based on this role assignment, it's then the developer's responsibility to know what tools they're using, and resolve software conflict by themselves.
Changing one bookmark for me surely isn't a great deal of a problem, making more people have to change their bookmarks is.
Setting that aside, it's not this theme's fault that the port conflicts with another software, so it makes less sense to "fix it" here than to fix it with Jekyll. Not to mention that NoMachine isn't as popular as other remote desktop (RD) solutions like VNC (default port 5900) and RDP (default port 3389). 4000 is a port just too common for a conflict, so I'd even doubt if a long-running software should use it.
Given that the port can be specified per invocation with command-line options, this is not a desirable change to have.
Summing up
So basically you squashed 3 unrelated changes into one PR that arguably makes reviewing and cherry-picking more complex than it should, and in addition this PR introduced

A change in theme appearance that is not perceived to be popular / demanded
A change in the README document that requires extra effort or software-and-workflow to maintain
A change in software setting that is both confusing and targetting the wrong audience

I'll copy my word from the previous comment as the last line, with emphasis added:

The point here is, you speak from your experiences and perspectives, but as a 7.5k-star open-source project, we have to take other users' favor and dependency into account. That something works for you in no way implies it'll also work for someone else.

Now your README change is useless.
https://twitter.com/natfriedman/status/1375430850620256257

Bump. @mmistakes

My views are completely in alignment with @iBug's comments.
I prefer focused pull requests that address one feature or bug... adding several no matter how small they appear makes merging harder.
 It also needs to be tested across all the skins to make sure it looks good in all the different color schemes.


Bombshell crashes under ruby 1.9.3

Do you have an idea why is that?
$ ruby pizza/bin/pizza
wrong number of arguments(1 for 0) (ArgumentError)
/home/konstantin/.rvm/gems/ruby-1.9.3-p0/gems/bombshell-0.1.5/lib/bombshell/shell.rb:58:in initialize' /home/konstantin/.rvm/gems/ruby-1.9.3-p0/gems/bombshell-0.1.5/lib/bombshell/shell.rb:58:in new'
/home/konstantin/.rvm/gems/ruby-1.9.3-p0/gems/bombshell-0.1.5/lib/bombshell/shell.rb:58:in launch' /home/konstantin/.rvm/gems/ruby-1.9.3-p0/gems/bombshell-0.1.5/lib/bombshell.rb:19:in launch'
pizza/bin/pizza:6:in `'
Just hate ruby's backward compatibility (works fine under my 1.9.2 rvm environment).

Yikes -- looking into this.

Thanks again for the bug report @kostyl!

I'll try it out)


ECMA module

Hi :)
Would it be possible to have this as ECMA module?
My Angular CLI is complaining: https://web.dev/commonjs-larger-bundles/
Thanks for considering :D

@reisi007 Apologies for the delay, I initially did not notice this pull request. I've pushed an update to remedy this, it's available in v0.0.10.


Publish-AdfV2FromJson trimming white spaces in sql queries part of Source Data

Using the PowerShell comands  on an ubuntu machine to deploy ADF directly from JSON
- task: PowerShell@2             enabled: true             inputs:               targetType: 'inline'               script: |                 Install-Module Az.DataFactory -MinimumVersion "1.10.0" -Force                 Install-Module -Name "azure.datafactory.tools" -Force                 Import-Module -Name "azure.datafactory.tools" -Force           - task: PowerShell@2             inputs:               targetType: 'inline'               script: |                 Test-AdfCode -RootFolder .           - task: AzurePowerShell@5             enabled: true             inputs:                             azureSubscription: 'AMN_Shared_Dev_Staffing_dev'               ScriptType: 'InlineScript'               azurePowerShellVersion: 'LatestVersion'               pwsh: true               Inline: |                   $opt = New-AdfPublishOption                   $opt.Excludes.Add("integrationruntime.*", "")                   $opt.Excludes.Add("triggers.*", "")                   $opt.StopStartTriggers = $false                   Publish-AdfV2FromJson -RootFolder . -ResourceGroupName '$(SharedRGName)' -DataFactoryName '$(DataFactoryName)' -Location '$(location)' -Stage '$(System.DefaultWorkingDirectory)/deployment/adf-config1.json' -Option $opt -Verbose
After the deployment our Pipelines stopped working
Looking at the source data , we see the whitespaces have been trimmed

We moved to use the PowerShell commands instead of using the ADO tasks to support linux build agents

We experienced this with az_9.2.0 module in Powershell as of January 12 2023. My team found a temporary resolution, switching ubuntu-latest to ubuntu-18.04 in your YML file lets you use az_9.0.1 previous version that does not have this issue.

https://github.com/Azure-Player/azure.datafactory.tools/issues/265


 On my perspective the last one should have hr_id="1".
There is also a discussion in this Oxygen forum topic.

@nkutsche you are right, I will start to look into this. In a way although I did not write the XSLT I blame myself for adding the @mid attribute on the processing instructions only in very particular cases. As my original interpretation of these processing instructions has in Java I could store the start and end processing instructions in a Java Stack and find quite easily the pairs but this in XSLT it's harder to do.

@raducoravu : there is no true developer who has never been sorry for what he has done in the past. :-)
I think it is even not so hard in XSLT as it seems to be in the first glance. This is my current function to get from a start PI the corresponding end PI.
<xsl:function name="d2t:getEndPI" as="processing-instruction()?">
    <xsl:param name="start" as="processing-instruction()"/>
    <xsl:variable name="startName" select="name($start)"/>
    <xsl:variable name="endName" select="replace($startName, '_start$', '_end')"/>
    <xsl:variable name="followingPIs" select="$start/following::processing-instruction()
        [name() = ($endName, $startName)]"/>
    <xsl:variable name="followingEndPIs" select="
        $followingPIs[name() = $endName][
        every $endPi in . satisfies
        d2t:doTheyMatch($start, $endPi, $followingPIs[. << $endPi])
        ]
        "/>
    <xsl:sequence select="$followingEndPIs[1]"/>
</xsl:function>

<xsl:function name="d2t:doTheyMatch" as="xs:boolean">
    <xsl:param name="piStart" as="processing-instruction()"/>
    <xsl:param name="piEnd" as="processing-instruction()"/>
    <xsl:param name="piBetween" as="processing-instruction()*"/>
    <xsl:sequence select="count($piBetween[name() = name($piStart)]) = count($piBetween[name() = name($piEnd)])"/>
</xsl:function>

It does not support the PIs with @mid, but this is not a big deal.

@nkutsche I committed a possible fix on the repository using your suggestions:
https://github.com/oxygenxml/dita-classic-pdf-review/commit/635f06d06f11fd24e9ecb50409c1c8665e49ebd5#diff-889545fa292a353b2664b5855a158450
but will probably need to create test case with more complicated situation. My fix should take @mid's into account.


NullPointerException while fetching Application.get.getPippoSettings()

I have added some constants in application.properties,
So, I am trying to fetch these constants using  Application.get.getPippoSettings()
Im getting NPE.
I don't if it is good to add the constants to application.properties
NPE at this line
private static final PippoSettings pippoSettings= Application.get().getPippoSettings();

Application.get() returns not null only in the context of web layer (on a http request). It cannot be useful in a service (server side business layer). For a service you must to inject PippoSettings in that service.


feat: introduce golangci

Signed-off-by: Kush Trivedi<EMAIL_ADDRESS>

Nope, some viper config error new to me. May be @kumarabd can figure the
issue out?
On Thu, 24 Sep, 2020, 23:18 Lee Calcote<EMAIL_ADDRESS>wrote:

@leecalcote commented on this pull request.
In .github/workflows/ci.yml
https://github.com/layer5io/meshery-kuma/pull/90#discussion_r494501298:

- name: Setup Go

  uses: actions/setup-go@v1

  with:

   go-version: ${{ secrets.GO_VERSION }}

- name: Create cluster using KinD

  uses<EMAIL_ADDRESS>

  with:

    version: "v0.7.0"

- run: |

    export CURRENTCONTEXT="$(kubectl config current-context)"

    echo "current-context:" ${CURRENTCONTEXT}

    export KUBECONFIG="${HOME}/.kube/config"

    echo "environment-kubeconfig:" ${KUBECONFIG}

    GOPROXY=direct GOSUMDB=off GO111MODULE=on go test ./...

     # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.

     version: v1.29

@kushthedude https://github.com/kushthedude ready to upgrade?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/layer5io/meshery-kuma/pull/90#discussion_r494501298,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKQMTLW4E5I3Y6S6GO2RENTSHOA6NANCNFSM4RW2COHQ
.

@kushthedude is this valid anymore of is it superseded by https://github.com/layer5io/meshery-kuma/pull/107?

@kushthedude is this valid anymore of is it superseded by #107?

And given #109?

@leecalcote let me merge upstream master into the branch and see if golangci works


python3Packages.pyupgrade: 2.23.0 -> 2.23.1

Motivation for this change
Update to latest upstream release 2.23.1
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 132038 at b5e7e053 run on aarch64-linux 1

2 packages built successfully:

python38Packages.pyupgrade
pyupgrade (python39Packages.pyupgrade)


[crypto] Changed mbedTLS API calls to fit 3.0.0 version.

Problem
In mbedTLS 3.0.0 there are some API changes comparing to previous versions that require aligning Matter source code calling this API.
This change is a first step for future mbedTLS 3.0.0 support, so it contains only API calls changes, no version update or building
configuration done.
Change overview
Added ifdefs checking mbedTLS version and changing:

mbedtls_*_ret() calls to mbedtls_*()
direct mbedtls structure's fields accessing to using MBEDTLS_PRIVATE() macro (no getters API available for now)

Testing
Manually checkout mbedTLS v.3.0.0 tag from thirdparty/mbedtls/repo and verified that building chip_tool and linux lighting_app examples works after API changes.

@Damian-Nordic looks like a great idea for me. I will try to do so.


[FALSE-POSITIVE]

Domains or links
Please list any domains and links listed here which you believe are a false positive.
Domain name: digitalapss.in
More Information
How did you discover your web site or domain was listed here?

Website was hacked
Incorrectly marked as Phishing on Phishtank or OpenPhish?

Answer: Incorrectly marked as Phishing on google page and Phishtank or OpenPhish.
Have you requested removal from other sources?
Please include all relevant links to your existing removals / whitelistings.
Answer: We have scanned the system with imunify360 and found nothing suspicious although we have removed some unwanted files from it.
Additional context
Add any other context about the problem here.
:exclamation:
We understand being listed on a Phishing Database like this can be frustrating and embarrassing for many web site owners. The first step is to remain calm. The second step is to rest assured one of our maintainers will address your issue as soon as possible. Please make sure you have provided as much information as possible to help speed up the process.
Send a Pull Request for faster removal
Users who understand github and creating Pull Requests can assist us with faster removals by sending a PR to mitchellkrogza/phishing repository, on the falsepositive.list file

https://github.com/mitchellkrogza/phishing/blob/main/falsepositive.list
Please include the same above information to help speed up the whitelisting process.

Domain name: digitalapss.in

Issue template isn't fulfilled, should be closed as invalid.
The same goes for https://github.com/mitchellkrogza/Phishing.Database/issues/893 and https://github.com/Ultimate-Hosts-Blacklist/whitelist/pull/211

You don't show as being listed by us but you are by numerous others
https://www.virustotal.com/gui/domain/digitalapss.in

Incorrectly marked as Phishing on google page and Phishtank or OpenPhish.

https://urlscan.io/result/73d1a681-4f8d-4832-9640-880c95c967cc/ shows the scan from OpenPhish, so it was correctly labeled but has since been remediated, according to you.


When query expressions added to a bucket an unexpected deprecation is printed

@tchak can this be closed now because of #736 ?

yes. closed by #736


Add avoid notification

Change-Id: I526a7fde5d4b3741ad6e79b8b575bd8551b28e53

Coverage increased (+0.005%) to 89.883% when pulling 488a13af75d5be531535d61759839ca7147f1dd8 on rafinskipg:master into 549f6369ba3b4f8266c7021d562062d856c3e2e7 on bq:master.


added Tunein.com support

Verified working on my local system

Hi there, thank you for contributing to the project.  I see that you added functionality for two websites, can you please separate www.iloveradio.de into a separate pull request and fix conflicts with manifest.json?  I've verified that both are working on my own system as well.  🙂

When looking up some things for #203, I also noticed that you have your own version of the extension on the Chrome Web Store.  As awesome as it is to see that you want to keep this extension shining, may we ask if you can either change the title and description to mention that it's your own version, or remove it entirely?  (Note: this won't change whether we decide to accept your PR!)

Happy to remove my version now that someone is working on this project again. Also happy to fix the conflicts in manifest.json. Any particular reason you want me to make 2 PRs?

I't no real nesseserity in two PRs in your case. Just restore the version, homepage and add the second service to Readme

Thank you!  My reasoning for requesting the separation of both changes is particularly since it's a common convention to roll out changes one by one (which I've been taught the hard way a few times), but since Feedbee says it's alright, I have no complaints either.  :P

@mrpoptart, can we get your fixes for the next release planed to the end of this week?


useLocation issue with remix-pagination

Hi, i have this issue when i tried to add remix-pagination to my project
An unknown error occured.
The stack trace is:

Error: useLocation() may be used only in the context of a <Router> component.
    at invariant (/Volumes/Workspace/www/lesfoodcuisine/node_modules/@ignisda/packages/react-router/lib/router.ts:5:20)
    at Object.useLocation (/Volumes/Workspace/www/lesfoodcuisine/node_modules/@ignisda/packages/react-router/lib/hooks.tsx:75:3)
    at Object.useSearchParams (/Volumes/Workspace/www/lesfoodcuisine/node_modules/@ignisda/packages/react-router-dom/index.tsx:444:18)
    at RemixPagination (/Volumes/Workspace/www/lesfoodcuisine/node_modules/@ignisda/remix-pagination/index.cjs:1971:26)
    at renderWithHooks (/Volumes/Workspace/www/lesfoodcuisine/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:5662:16)
    at renderIndeterminateComponent (/Volumes/Workspace/www/lesfoodcuisine/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:5735:15)
    at renderElement (/Volumes/Workspace/www/lesfoodcuisine/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:5950:7)
    at renderNodeDestructiveImpl (/Volumes/Workspace/www/lesfoodcuisine/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:6108:11)
    at renderNodeDestructive (/Volumes/Workspace/www/lesfoodcuisine/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:6080:14)
    at renderNode (/Volumes/Workspace/www/lesfoodcuisine/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:6263:12)
    at renderChildrenArray (/Volumes/Workspace/www/lesfoodcuisine/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:6215:7)
    at renderNodeDestructiveImpl (/Volumes/Workspace/www/lesfoodcuisine/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:6145:7)
    at renderNodeDestructive (/Volumes/Workspace/www/lesfoodcuisine/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:6080:14)
    at renderElement (/Volumes/Workspace/www/lesfoodcuisine/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:5975:9)
    at renderNodeDestructiveImpl (/Volumes/Workspace/www/lesfoodcuisine/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:6108:11)
    at renderNodeDestructive (/Volumes/Workspace/www/lesfoodcuisine/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:6080:14)
    ```

Hello @nkrmr! Could you please share the repo where this occurred? Or a minimal reproduction would be fine too.
I updated the remix version for the example app and it works fine so I think the error must be specific to your setup.

Yes sorry i found the issue, everything works fine. THX

It's not working with the latest version of remix, just upgraded remix and unable to start the app.

@chirdeeptomar What is the error?

@chirdeeptomar What is the error?

Same as above.

@IgnisDa any update on this?

Uninstalled and installed again, works now!

I am running into the same error. Please check it out:
https://codesandbox.io/p/sandbox/peaceful-bash-ynfqxr

Hey @blitze I have not maintained this library for a long time. If you want to fix it and make a PR, I can review and publish it to NPM, but I will not work on it myself.


Support using non-hunter version of bzip2, zlib and libarchive if HUNTER_ENABLED is OFF

Introduction: among our modifications to support the HUNTER_ENABLED=OFF build (see also https://github.com/luxonis/depthai-core/pull/1048 and https://github.com/luxonis/depthai-core/pull/1049) this is probably the one that complicates the code the most, so I would understand if you prefer to not merge such modification. However, I think it was worth to isolate the change and made it available in the form of a PR.
When setting HUNTER_ENABLED=OFF, one can install all the dependencies via the usual CMake workflow in a directory that is added to CMAKE_PREFIX_PATH, and then build depthai-core . However, there are three packages that are installed in different ways depending of weather the hunter/luxonis fork is used, or if the upstream version is used.
The three packages are:
ZLIB: The hunter/luxonis ZLIB is found via find_package(ZLIB CONFIG) and it defines the ZLIB::zlib imported target, while the regular ZLIB does not install any CMake config file, but it can be found by CMake's upstream FindZLIB.cmake that defines the ZLIB::ZLIB imported target.
BZip2: The hunter/luxonis BZip2 is found via find_package(BZip2 CONFIG) and it defines the BZip2::bz2 imported target, while the regular BZip2 does not install any CMake config file, but it can be found by CMake's upstream FindBZip2.cmake that defines the BZip2::BZip2 imported target.
libarchive: The hunter/luxonis libarchive is found via find_package(archive_static CONFIG) and it defines the archive_static imported target, while the regular libarchivedoes not install any CMake config file, but it can be found by CMake's upstream FindLibArchive.cmake that defines the LibArchive::LibArchive imported target.
If you have a project that is already using the upstream version, in general you would like for depthai-core to also use the upstream version.
To achieve this, this PR modifies the logic if HUNTER_ENABLED is set to OFF. In that case, first the hunter/luxonis package names and target are tested, and if they can be found they are used, while if they do not exist the logic fallbacks to the upstream package names/target names.
If  HUNTER_ENABLED is set to ON, the PR does not change the existing logic.

Thanks @traversaro !
Really excited to get these merged in.
The changes besides the implicit minimum cmake version look good to me.
As I see it this is what has to be done before the merge:

Add Find**** files to avoid the minimum cmake version
Add a test to CI to test with HUNTER_ENABLED=OFF.

I think replicating however you build locally will work (just docker-zing it)


copier: fix override siva file on remote fs

Added a test to check if copier implementation is overriding the remote siva file with new changes.
Fix hdfs copier to check if the file already exists and delete it before upload the new version.
Added a todo comment to implement 'truncate' flag in the hdfs client library on Create.

Should we also create an issue about this to not forget we should create a Truncate method on the client?

@erizocosmico yep, good idea. I'll do it.

@erizocosmico done: https://github.com/src-d/core-retrieval/issues/37

:+1:


IP Address concrete parent relationship to Prefix

As ...
Austin - Network Automation Engineer
I want ...
The IP Address model to have a concrete foreign key relationship to the Prefix model
So that ...
Lookups for address containment can be optimized, and so that I can ensure proper prefix ownership in the case of duplicate address space.
I know this is done when...

A nullable foreign key parent is added from the IP Address model to the Prefix model.
This relationship can be manipulated in the UI and API
Existing installs have the relationship populated via the logic defined in today's annotate_tree() method, so maintain compatibility with the current logic.
In v1.4 existing UX pertaining to the deletion of prefixes and modification of prefix address space (sub/super-netting) is maintained. If this logic should be changed, that will occur in v2.0.

Optional - Feature groups this request pertains to.

[ ] Automation
[ ] Circuits
[ ] DCIM
[X] IPAM
[ ] Misc (including Data Sources)
[ ] Organization
[ ] Plugins (and other Extensibility)
[ ] Security (Secrets, etc)
[ ] Image Management
[ ] UI/UX
[ ] Documentation
[ ] Other (not directly a platform feature)

Database Changes
Add a new nullable parent FK from the IP Address model to the Prefix model and populate it via a data migration.
External Dependencies
None
TODO
AC: Alpha

[ ] Data model changes

Design meeting for what fields are no longer required (netmask? etc)

[ ] Form updates, data validations

AC: Beta (new story)

[ ] Re-parenting (more-specific prefix, deleted prefix) algo
[ ] Data migration from 1.X

This is a unit of #1032 and has been identified as being doable in 1.4.

I am not sure if this is the right place for this, but I think we should also make family (or ip_version) a concrete field on IPAM models instead of a derived query/method field so that family-based filtering is even more efficient and can be indexed.

Discussion Notes (not all being done in this issue)
This Story

[ ] Add Required FK from IPAddress to Prefix

Schema will require an object to exist
"Global" prefixes created for "Global" namespace

[ ] The view/form

If you provide a prefix, find the closest parent
If you don't provide a prefix you must provide a namespace
UI shouldn't need to show the prefix, as that parenting is enforced to be correct, but should show namespace

[x] Remove FK to VRF from IPAddress (already in Namespace alpha)
[ ] Add ip_version

Other:

[ ] Should host be modifiable?
[x] Solve loopback problem:

Parent prefix is likely very large
As-configured is /32

[ ] Ditch Broadcast?
[ ] Ditch Prefix_length?

Use IP Address type to hint at configured mask

[ ] Revisit "Global" as name for "global" namespace (ie "Default")


libqmatrixclient: <IP_ADDRESS> -> 0.4.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libqmatrixclient/versions.
meta.description for libqmatrixclient is: '"A Qt5 library to write cross-platfrom clients for Matrix"'.
Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS
Warning: no invocation of /nix/store/19hda3hk79ika22lsx468khxrzx4w5x4-libqmatrixclient-0.4.0/bin/qmc-example had a zero exit code or showed the expected version
0 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 0.4.0 with grep in /nix/store/19hda3hk79ika22lsx468khxrzx4w5x4-libqmatrixclient-0.4.0
directory tree listing: https://gist.github.com/e9bb3eaa0c15d5e343e4795d4b578c94
du listing: https://gist.github.com/51a091ec9d09148787386f88cfc16bed

Outpath report (click to expand)

Outpath difference report
11 total rebuild paths
3 package rebuilds
3 x86_64-linux rebuilds
3 i686-linux rebuilds
2 x86_64-darwin rebuilds
3 aarch64-linux rebuilds
First ten rebuilds by attrpath
libqmatrixclient
matrique
quaternion

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/19hda3hk79ika22lsx468khxrzx4w5x4-libqmatrixclient-0.4.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A libqmatrixclient https://github.com/r-ryantm/nixpkgs/archive/2822fbb239fb5d0d2570c9314625fbf152211b54.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/19hda3hk79ika22lsx468khxrzx4w5x4-libqmatrixclient-0.4.0
ls -la /nix/store/19hda3hk79ika22lsx468khxrzx4w5x4-libqmatrixclient-0.4.0/bin

cc @peterhoeg for testing.

Success on aarch64-linux (full log)
Attempted: libqmatrixclient
Partial log (click to expand)
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/157iajsk2xqrcids9mm50ps0gmahpi3v-libqmatrixclient-0.4.0
shrinking /nix/store/157iajsk2xqrcids9mm50ps0gmahpi3v-libqmatrixclient-0.4.0/bin/qmc-example
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/157iajsk2xqrcids9mm50ps0gmahpi3v-libqmatrixclient-0.4.0/lib  /nix/store/157iajsk2xqrcids9mm50ps0gmahpi3v-libqmatrixclient-0.4.0/bin
/nix/store/157iajsk2xqrcids9mm50ps0gmahpi3v-libqmatrixclient-0.4.0
patching script interpreter paths in /nix/store/157iajsk2xqrcids9mm50ps0gmahpi3v-libqmatrixclient-0.4.0
checking for references to /build in /nix/store/157iajsk2xqrcids9mm50ps0gmahpi3v-libqmatrixclient-0.4.0...
postPatchMkspecs

Success on x86_64-linux (full log)
Attempted: libqmatrixclient
Partial log (click to expand)
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/19hda3hk79ika22lsx468khxrzx4w5x4-libqmatrixclient-0.4.0
shrinking /nix/store/19hda3hk79ika22lsx468khxrzx4w5x4-libqmatrixclient-0.4.0/bin/qmc-example
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/19hda3hk79ika22lsx468khxrzx4w5x4-libqmatrixclient-0.4.0/lib  /nix/store/19hda3hk79ika22lsx468khxrzx4w5x4-libqmatrixclient-0.4.0/bin
patching script interpreter paths in /nix/store/19hda3hk79ika22lsx468khxrzx4w5x4-libqmatrixclient-0.4.0
checking for references to /build in /nix/store/19hda3hk79ika22lsx468khxrzx4w5x4-libqmatrixclient-0.4.0...
postPatchMkspecs
/nix/store/19hda3hk79ika22lsx468khxrzx4w5x4-libqmatrixclient-0.4.0

Success on x86_64-darwin (full log)
Attempted: libqmatrixclient
Partial log (click to expand)
-- Installing: /nix/store/306ap8hskfwks9wa8zn1mdq5vqnxmdz6-libqmatrixclient-0.4.0/lib/cmake/QMatrixClient/QMatrixClientTargets-release.cmake
-- Installing: /nix/store/306ap8hskfwks9wa8zn1mdq5vqnxmdz6-libqmatrixclient-0.4.0/lib/cmake/QMatrixClient/QMatrixClientConfig.cmake
-- Installing: /nix/store/306ap8hskfwks9wa8zn1mdq5vqnxmdz6-libqmatrixclient-0.4.0/lib/cmake/QMatrixClient/QMatrixClientConfigVersion.cmake
-- Installing: /nix/store/306ap8hskfwks9wa8zn1mdq5vqnxmdz6-libqmatrixclient-0.4.0/bin/qmc-example
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/306ap8hskfwks9wa8zn1mdq5vqnxmdz6-libqmatrixclient-0.4.0/lib  /nix/store/306ap8hskfwks9wa8zn1mdq5vqnxmdz6-libqmatrixclient-0.4.0/bin
patching script interpreter paths in /nix/store/306ap8hskfwks9wa8zn1mdq5vqnxmdz6-libqmatrixclient-0.4.0
postPatchMkspecs
/nix/store/306ap8hskfwks9wa8zn1mdq5vqnxmdz6-libqmatrixclient-0.4.0

@disassembler - did you test this? I haven't been to get quaternion working with this version (segfault on start).


Add webpack proxy, react-dev-tools hot client

😍

This fixes #284.
But, this is mostly a POC: it sacrifices a lot, sadly.
Notes:

I was unable to get this working with webpack-hot-middleware & webpack-dev-middleware. It appears react-dev-utils/webpackHotDevClient uses a couple of hardcoded features only available in webpack-dev-server (which is kind of hacky!)
Sadly, this means we still need to run webpack on a seperate port; my goal was to completely eliminate the need of a separate webpack server, but this makes this pretty much impossible.
This breaks backwards compatibility; it assumes all razzle apps are using the proxy; otherwise the client will be unable to connect.
This does require all razzle based apps to have razzle-dev-utils as a dependency. We could make the webpackProxy part of razzle itself, but it really feels a lot more like a dev util to me.
It doesn't appear to catch run time errors like create-react-app.
Haven't been able to figure out why yet.

There's also the possibility to builld our own error overlay, but that would bring the extra burden of maintaining that one as well, while other really great solutions like react-error-overlay & react-dev-utils/webpackHotDevClient exist.

This is pretty amazing work. So thank you x1000000.
Backwards compat is pretty important. Not because I personally care too much, but that Razzle's competition (CRA, Next, react-server, etc.) are really good about maintaining it. Thus, I would explore writing our own overflay based on some of the work you have done, but as a separate package (perhaps called razzle-dev-tools). This would be optional, as Razzle is not a runtime dependency right now.
FYI, if we could figure out how to make Razzle work as simply node.js middleware (like next), I would totally be open to runtime a dep.

Yea, I'd be interested in exploring that too. What's really great about next's error handling is that it also shows server side runtime/compile errors, something we probably can never do if we use CRA's error handling, would be really cool if we could add that to razzle as well.
Regarding middleware: I basically had the entire client side compiling working as a middleware, shouldn't be too hard to add server compiling to that as well.
Let's make a separate issue for that though.

Going to close this in favor of a from scratch based approach.


Investigate the use of PyHelm to replace the execution of helm via subprocess.

Investigate the library PyHelm to replace the "helm" commands launched from Python using subprocess.

Could be cleaner to handle credentials to access helm in the cluster.
Maybe we can reduce the complexity of unit-testing using this library.
Adding the third party library we may reduce the maintenance load, make the code more clear to handle using only python code and not having to assemble cli commands, and what is expected from the api call could be more reliable.
Reduce the error handling special characters and how we are escaping them.

Module documentation: https://pypi.org/project/pyhelm/
Example of how we execute:

We create a command string:

command = "helm install {repo}/{app} -n {name} --namespace {ns}".format(

Execute method:

  if show_command:
       print(t.magenta(command))
   try:
       # TODO: Can we do this with a different command than check_output (Bandit security issue)
       result = check_output(command, stderr=STDOUT, shell=True)
       decoded = result.decode("utf-8")
       if verbose:
           print(decoded)
       return decoded, None
   except CalledProcessError as e:
       error_text = e.output.decode("utf-8")
       if show_errors:
           print(t.red("Command failed with CalledProcessError:"))
           print(error_text)
return None, error_text

This could help to fix https://github.com/hyperledger-labs/nephos/issues/26

Aha, PyHelm appears to be relatively young project. I agree that it is worth looking into it, and agree that getting rid of as many subprocess calls as possible, would be helpful.
And anything that reduces the Unit Test complexity without sacrificing functionality is worthwhile.

Related tools mentioned on Helm website include:
https://github.com/reactiveops/reckoner
Furthermore, currently we use Helm, but depending on the future of Kubernetes packaging, we may also consider using https://github.com/kubernetes-sigs/kustomize


Fix UID handling with cask installer script:

Broadly speaking, Homebrew respects EUID and writes all files using that EUID.
When using installer script: this contract may not necessarily be true for third-party scripts, leading to permission issues under setups where EUID != UID. For example, bash scripts by default will respect UID instead unless you use Bash protected mode (bash -p).
In formulae, we already handle this here: https://github.com/Homebrew/brew/blob/2cdc092a2623522d21f5fe4a5a8526a40f011e74/Library/Homebrew/utils/fork.rb#L48
This PR adds the same to casks via a reset_uid system_command option. Unfortunately Open3 isn't flexible enough to handle this so we need to replace it with our own implementation.

Great work here, thanks @Bo98!


Function builtin expanded notation

This detail was missing from the specification.

@ericelliott if it becomes => Any we will have to move that note somewhere else.

@ericelliott I don't wanna be annoying but better be safe than sorry: squash the commits.

To have a clean history? One commit per PR seems better. And GitHub supports it in its interface directly.

Here's a blog post that explains it in details: https://blog.github.com/2016-04-01-squash-your-commits/#enter-commit-squashing
On all the open sources projects that Iv contribute to, the maintainer squash the commits that results from the review. It's not my pet peeve, it's just a convention on GitHub.

Ah, so pet peeve. ;)

@ericelliott LGTM

You should not be proud of having Update README.md for almost all of your commit messages :)

We should be more descriptive about what feature we're updating. =)


Option to 'refresh' embedded asset data

It would be good to have an option to batch-refresh embedded asset data, if some change on the provider's end causes some part of the existing embedded asset data other than the URL to be invalid (which seems like the cause of #185).

Subscribing! Thanks for opening this @ttempleton.
I think a pretty decent way to do this would be a console command. If I could run something like craft embedded-assets refresh --volume="videos" or something, that would make me really happy!

Yeah, this also just hit one of my client sites and I'm staring down the barrel of re-uploading 100+ assets without any seemingly easy way to refresh the video thumbnails.

@stevecomrie my quick and dirty script
https://github.com/spicywebau/craft-embedded-assets/issues/185#issuecomment-930221389

Working on this in the 2.x branch. I've added console commands as suggested by @jakedohm. They work as follows:

craft embeddedassets/refresh/by-volume --volume=embedded refreshes all embedded assets in the embedded volume.
craft embeddedassets/refresh/all refreshes all embedded assets in all volumes.

If anyone would like to try it out, feel free, and please let me know if there are any issues or if you have any other feedback. Hoping to have 2.9.0 out within the next week.

2.9.0 has now been released with this feature.


Update Bucket.jl

Update the surface_fluxes method for the coupled case to return p, as the coupler will have filled p with the correct values already

bors r+


ACF Compatibility Updates + Build Error Fix

Fixes errors with ACF vs. Lucee handling of java.util.LinkedHashMap instantiation.
Additional syntax corrections for ACF.
Fix for nested build path on ortus stg server.

@lmajano I'm closing this PR until I can debug the Travis issue (which is the same problem as the Jenkins build issue).


Add Redout: Enhanced Edition

umu-database pr : https://github.com/Open-Wine-Components/umu-database/pull/58

I clearly did something wrong with git.
I prefer to do a clean pull requets.

I clearly did something wrong with git. I prefer to do a clean pull requets.

Rebase and force-push to your branch.
This is the silver bullet with PRs. 👍🏻


"Run in Background" disconnects from the network

Environment

Smapp version: 1.3.2
Node version: v0.x.xx
OS: Windows 10

Describe the bug
Letting the app run in the backgroun (minimized to tray) will immediately upon clicking the button cause the app to lose it's connection to the network.
Note that the node has to either be synced or in the process of syncing for this to happen. When you start the wallet up and let it run in the background while it is running the database migration nothing will happen until it starts to sync.
I have tried several clean re-installs, even syncing from scratch, nothing helped. It runs fine while the program is opened, or simply minimized to the task bar. But as soon as you let it run in the background, boom disconnected from the network. (look at the picture)
Even clicking the button and choosing the "mainnet" again doesn't work, as nothing happens.

Steps to reproduce
Open App
Wait for database migration to finish
Wait for syncing activations to finish
Once it starts syncing, or if it already is synced, close app to run in background
Maximize the app again
See that the node lost it's connection to the network and clicking the button to reconnect to the mainnet doesn't do anything.
Expected behavior
Running in the background should just minimize the app to tray, while it still runs fine.
Actual behavior
Running in background disconnects from the network.
Logs
spacemesh-log-7c8cef2b.zip

Something weird happened for you here; it seems that your Smapp (ISP blocked it?) lost access to networks.json and somehow decided not to connect to the mainnet, therefore.
I think that is clearly stated in 1.3.9 by adding the new screen with config service reachability. Please reacheck :)


Return master branch to 1.x development

The 2.0 development has been moved into https://github.com/googleapis/gapic-generator-ruby so we are switching master back to 1.x. I can't rebase master in this repo, so this includes a commit that reverts all the 2.0 development, and then merges in the existing 1.x branch.
Notes:

I verified via git diff that the contents of this commit are identical to the current state of the 1.x branch.
I left a branch "2.x-old" to mark the final extent of the 2.0 development in this repo.

Did you try renaming master to 2.x and then renaming 1.x to master?

@blowmage Master branch protection won't let me 😞

Obsolete.


fixed dashboard link showing to non auth user

Description
Fixed Bug where non authenticated user could see the dashboard
Npm audit updated a packagelock.json file
Related Issue

[ ] Is this related to a specific issue? Is so please specify:

Type of Changes
Use a check for ✓ the following type of changes:

Type

✓
:bug: Bug fix

:sparkles: New feature

:hammer: Refactoring

:100: Add tests

:link: Update dependencies

:scroll: Docs

Updates
After
Non authenticated user can not not access dashboard
Checklist:

[x] This PR is up to date with the development branch, and merge conflicts have been resolved
[x] My code follows the style guidelines of this project
[ ] I have executed npm run lint and resolved any outstanding errors.
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings

Merged


Building firmware CPP typesupport generation is triggered.

Running ros2 run micro_ros_setup build_firmware.sh in the branch dashing ends up in interface generation issues:
Starting >>> std_srvs
--- stderr: builtin_interfaces
CMake Error at /uros_ws/firmware/mcu_ws/install/rosidl_typesupport_c/share/rosidl_typesupport_c/cmake/get_used_typesupports.cmake:34 (message):
  No 'rosidl_typesupport_cpp' found
Call Stack (most recent call first):
  /opt/ros/dashing/share/rosidl_typesupport_cpp/cmake/rosidl_typesupport_cpp_generate_interfaces.cmake:65 (get_used_typesupports)
  /uros_ws/firmware/dev_ws/install/ament_cmake_core/share/ament_cmake_core/cmake/core/ament_execute_extensions.cmake:48 (include)
  /uros_ws/firmware/mcu_ws/install/rosidl_cmake/share/rosidl_cmake/cmake/rosidl_generate_interfaces.cmake:286 (ament_execute_extensions)
  CMakeLists.txt:16 (rosidl_generate_interfaces)

It does not happen running build_firmware.sh in a shell with no ROS 2 sourced. See
https://github.com/micro-ROS/docker/blob/37e28cfaee944f1549ad605fa434cc6f4561ba18/micro-ROS-Olimex-NuttX/Dockerfile#L18
see https://github.com/micro-ROS/micro-ros-build/pull/32

Okay, I've found one issue at least. build_firmware.sh uses COLCON_PREFIX_PATH to determine which prefixes to clean. This variable is only set for crystal, however.
Fortunately, the variable AMENT_PREFIX_PATH is set on both versions, and it contains the same data, so we can use that.

8de7fad45ae1bf288e1c2357ec3ca280b5a603e3 should have fixed this. Can you try again, please?

Fixes it.


utcnow.now functionality

Codecov Report

Merging #8 (5a2ac35) into master (c60a456) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master        #8   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines          254       281   +27
=========================================
+ Hits           254       281   +27

Impacted Files
Coverage Δ

utcnow/__init__.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c60a456...5a2ac35. Read the comment docs.


prepare 0.4.2

It would be great to publish a new version after all PRs get merged. Thanks!

This change is

Would be cool to keep a changelog.
You can add one and write what changed between 0.4.1 and 0.4.2
If you do, use https://keepachangelog.com/en/1.0.0/ as a template

Done! I added the date for release as tomorrow, but feel free of change it, I am not sure when you're going to release it.
Thanks!

When? A minute ago!

hahaha thanks!


what is depth_multiplier?

Hi,
I see in the paper that higher depth multiplier (0.5, 0.75, 1.0) leads to lower gradient error. My question is what is it and how much i can increase it?

Refer to MobileNets: Efficient Convolutional Neural Networks for Mobile Vision Applications for the explanation of width multipliers. Basically, it scales the number of channels which, in turn, changes the capacity of the model. You can increase it as much as you want but increasing it will make your network slower and bulkier.