Feature/cloud gov deployment

Note: I'm going to go ahead and merge this to test the GitHub Action kickoff


Disable NestedGroups cop in spec

Context
I personally find this cop really annoying in spec files. Thoughts?

For what it's worth, I like this cop. I think there can be good reasons for disabling it on an ad hoc basis, eg when we have temporary extra context like a feature flag.

Can you point me to a place where we violate this cop?

Ah sorry, I altered it this morning after it was agreed that providers would have to give feedback on rejection. It was something along the lines of:
RSpec.describe CandidateMailer, type: :mailer     describe 'rejection emails' do       context 'All application choices have been rejected email' do          context 'when the provider gives feedback          end        end    end   end


Only use function-bind when native isn't available

We should be ponyfilling instead of executing it all the time. It results in an error in runtimes which disallow the result of eval, like Chrome Apps and Atom. See https://github.com/AtomLinter/linter-stylelint/issues/90
The line in question is lib/index.js:8

Resurrection of https://github.com/substack/tape/issues/199

"ponyfill" is not a real word (and yes I'm aware that a few people try to pretend it is).
At any rate, while it'd be fine to do Function.prototype.bind || require('function-bind') it's not going to help anything wrt CSP and Chrome Apps. The solution remains (as pointed out in https://github.com/substack/tape/issues/199#issuecomment-147215863) to shim function-bind to Function.prototype.bind in an env in which you can rely on it being available.

it's not going to help anything wrt CSP and Chrome Apps

Can you please explain why it won't help? I'm not sure about Chrome Apps as I have no experience working with them, I'm quite confident that in Atom you won't get a warning about a runtime feature being disallowed until it's executed and Function.prototype.bind is available in all Atom versions that I've tried it on, so I believe that a simple Function.prototype.bind || require('function-bind') will solve the problem
Please note that if we do not workaround this, packages will have to drop tape dependency and explore alternatives, like stylelint did

My understanding is that Chrome Apps and CSP freak out when Function or eval occurs anywhere in the app - not just when it's executed. This means that the || will not avoid the CSP error.
If in fact is is the case that that is sufficient to bypass CSP, then I'd be happy to modify function-bind itself to export Function.prototype.bind when available - but I'm pretty confident it won't have any affect.
If you need to pursure another testing solution, that's fine, but when a single line in your package.json will allow browserify to replace function-bind with Function.prototype.bind, it seems like a simple fix on your end (because only on your end can you know for sure that bind is available)

I am not sure about the behavior in Chrome Apps but our use case is a package in Atom that is requiring this package, and I have personally verified that Function.prototype.bind || new Function('') does not produce this warning in Atom. Therefore if you do that, it will fix our use case and stylelint will be able to use this package again.
Our use case does not include browserify, so a manifest fix won't do it for us :)

function-bind v1.1.0 is published - a fresh npm install should include the newest version. That should cover it if your theory is correct.

Beautiful, Thanks! :+1:

@ljharb I just confirmed it works, thanks again


make setFriendlyPermissions global

When working on #4038, #4039 & #4040, I had to reuse the function setFriendlyPermissions, the same that is used for spo roledefinition list.
We should make this function global and place it in the base-permssions.ts file so it can be used globally

Seems like something that we could move to https://github.com/pnp/cli-microsoft365/blob/main/src/utils/formatting.ts

Seems like something that we could move to https://github.com/pnp/cli-microsoft365/blob/main/src/utils/formatting.ts

Even better! Can assign me please?


Refactors tests and improves coverage

Motivation
Review test quality and coverage status of current projects and find improvements.
[No Jira at the moment]
Description
This only affects MobileCore.
A bit of refactorization to MobileCoreTest class, to make it more extendable.
Also some new test cases to increase coverage 79% -> 90% .

@josemigallas can you rebase on master and I will merge

@secondsun done


Dummy annotation into kaniko-secret as workaround.

Workaround until Kubernetes Credentials Provider can deal with a secret without annotations.

/ok-to-test

/approve


Add Stable Diffusion Unet/clip/vae compile test to presubmits

Request description
This is to prevent issues like https://github.com/openxla/iree/issues/12634. It would be good to compile for CUDA, vulkan rdna2, vulkan rdna3 (wmma).  Ideally we can run a simple run-module / benchmark-module for those three on an NVidia gpu.
What component(s) does this issue relate to?
Other
Additional context
No response

What config and compiler flags should be used for each model? There looks to be several available in https://github.com/nod-ai/SHARK/tree/main/apps/stable_diffusion/src/utils/resources. I currently have it defaulting to "CompVis/stable-diffusion-v1-4" with no additional compiler flags.

I'm also running into this error for VAE:
Failed to import model SD_VAE_MODEL. Exception: Lowering Torch Backend IR -> Linalg-on-Tensors Backend IR failed with the following diagnostics:
error: failed to legalize operation 'torch.aten.convolution' that was explicitly marked illegal
note: see current operation: %173 = "torch.aten.convolution"(%arg0, %157, %156, %171, %172, %171, %2, %172, %17) : (!torch.vtensor<[1,1,4,64,64],f32>, !torch.vtensor<[4,4,1,1],f32>, !torch.vtensor<[4],f32>, !torch.list<int>, !torch.list<int>, !torch.list<int>, !torch.bool, !torch.list<int>, !torch.int) -> !torch.vtensor<[1,4,4,64,?],f32>

Another question: Is the sequence length for ClipTextModel fixed or variable? If variable, what is the typical sequence length that we should set for the regression?

We use 64 and 77 for clip.
@monorimet can you please share the compile flags for vulkan rdna2 / rnda3 and cuda for the SD models ?

Removing "awaiting-triage" since this has both priority and assignee.

Here are the commands that work for me.
UNet ( rdna2 ):
iree-compile --iree-input-type=none --iree-hal-target-backends=vulkan --iree-stream-resource-index-bits=64 --iree-vm-target-index-bits=64 --iree-util-zero-fill-elided-attrs -iree-vulkan-target-triple=rdna2-unknown-linux --iree-preprocessing-pass-pipeline='builtin.module(func.func(iree-flow-detach-elementwise-from-named-ops,iree-preprocessing-convert-conv2d-to-img2col,iree-flow-convert-1x1-filter-conv2d-to-matmul,iree-preprocessing-pad-linalg-ops{pad-size=32}))' unet.mlir -o unet.vmfb

VAE ( rdna2 ):
iree-compile --iree-input-type=none --iree-hal-target-backends=vulkan --iree-stream-resource-index-bits=64 --iree-vm-target-index-bits=64 --iree-util-zero-fill-elided-attrs -iree-vulkan-target-triple=rdna2-unknown-linux --iree-preprocessing-pass-pipeline='builtin.module(func.func(iree-flow-detach-elementwise-from-named-ops,iree-preprocessing-convert-conv2d-to-img2col,iree-flow-convert-1x1-filter-conv2d-to-matmul,iree-preprocessing-pad-linalg-ops{pad-size=32}))' vae.mlir -o vae.vmfb

Clip ( rdna2 ):
iree-compile --iree-input-type=none --iree-hal-target-backends=vulkan --iree-stream-resource-index-bits=64 --iree-vm-target-index-bits=64 --iree-util-zero-fill-elided-attrs -iree-vulkan-target-triple=rdna2-unknown-linux --iree-preprocessing-pass-pipeline='builtin.module(func.func(iree-flow-detach-elementwise-from-named-ops,iree-flow-convert-1x1-filter-conv2d-to-matmul,iree-preprocessing-pad-linalg-ops{pad-size=32}))' clip.mlir -o clip.vmfb

(will edit this to add RDNA3 and cuda)

@mariecwhite Can you update this one?

Sorry, I didn't see Ean's comment. Clip and UNet are in CI and running for CUDA. VAE was working but now regressed. I also need to add support for running the models with Vulkan/Spirv.

Thanks for adding Vulkan benchmarks @antiagainst ! For VAE, there seems to be an issue with the model: https://github.com/openxla/iree/issues/12771

Unassigning myself from issues that I'm not actively working on

Assigning this to @antiagainst since he picked up this task.

The only missing one is VAE I think, which is pending in #12767. Any chance we move that forward, @mariecwhite?

obsolete


Tag the newest v1 release with v1

To allow github actions users to specify only the major version - this project needs to tag the latest v1 version as v1 - see https://github.com/actions/checkout/tree/v2 for example.
Right now v1 is pointing to the commit of v1.5.0. Please update the tag 😄

@chulkilee The tag has been updated. Let us know that all is working on your end ❤

@chulkilee The tag has been updated. Let us know that all is working on your end ❤

It works great! Thanks - closing it.

It works great! Thanks - closing it.


paymentRequest.update is not a function

I have managed to set up PaymentRequest so that it works correctly when the paymentRequest object is set initially on page load. However, I need to be able to change the paymentRequest object to account for changes in product quantity, for example
According to the Stripe docs, this should be done via a function named paymentRequest.update however this does not exist when using injectStripe (as set out in the official stripe.dev example)
This essentially means that there is no way to update the paymentRequest object
Any suggestions? Thank you!

To make it clearer.. here is a CodeSandBox to show what I mean: https://codesandbox.io/s/funny-spence-fwfhc
Clicking the first button attempts to update the paymentRequest by using setState()
Clicking the second button attempts to update the paymentRequest by using paymentRequest.update() (using the exact same object as the one in the Stripe Docs)

also here is a vanilla js codesandbox showing how it is possible to update a paymentRequest via paymentRequest.update()
https://codesandbox.io/s/serene-heisenberg-ss1it

Hi @brunocrosier - the payment request in your first codesandbox example does seem to have a .update() function on it. It should just be a normal payment request object and you can operate on it as you otherwise would as shown in your second example.
Give that a shot and let me know if it doesn't work out as expected.

Ah, I have managed to get it to work!
for anyone else who encounters this issue, in a class component, you have to call this.state.paymentRequest.update({               total: {                 label: "Demo total",                 amount: 2000               },               shippingOptions: [                 {                   id: "basic",                   label: "Ground shipping",                   detail: "Ground shipping via UPS or FedEx",                   amount: 995                 }               ]             })
and in a function component, it's the same but remove the initial this.state
As an aside, I would definitely recommend including some sort of documentation about how to update the paymentRequest inside the react-stripe-elements docs. I am sure that a lot of people would benefit from it, as it's an extremely common use case :)

Glad you got it working! Thanks for the suggestion. I'll close this out now if that is all.


fix: broken README.md link

Description
Just a minor fix on a broken link in the README.md.
Type of change

[X] Documentation update

Thanks @alvarobartt 🙏🙏
I'd like this to point develop as it is the default branch we show to newcomers .


self as target doesn't seem to work

I have a derived getter, using the getset crate, but I also need to impl a trait that has the same getter.
This works:
#[derive(Getters)]
pub struct Struct {
	member: Member,
	#[getset(get)]
	foo: Foo,
}

impl Trait for Struct {
	delegate! {
		to self.member {
			fn bar(&self) -> Bar;
		}
	}

	fn foo(&self) -> &Foo {
		self.foo()
	}
}

But this doesn't work:
impl Trait for Struct {
	delegate! {
		to self.member {
			fn bar(&self) -> Bar;
		}

		to self {
			fn foo(&self) -> &Foo;
		//  ^^ error: expected identifier or integer
		}
	}
}

But it should also work, because the handwritten delegation from trait to self.foo() works :)

Hmm, for some reason syn refuses to parse self as an Expr. This is pretty tricky, I'll probably have to do through the tokens one by one and build the target expression manually if I can't just parse it as an expression.

@Kobzol syn does parse self as an Expr:

https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=129a928ee8a737716517441645bfe0ea

The problem here is that it is parsing self { ... } as an expression as a whole (e.g., self { 0: hi } is, syntactically, a valid expression: Demo), and so it commits to start parsing a struct-like expression and fails when it encounters the token fn instead of a field name or a tuple index.
In general, you cannot really parse a braced group right after arbitrary expressions. Try adding some separator (such as , or =>) to disambiguate. For instance:
impl Trait for Struct {
    delegate! {
        {
            fn foo ...
        } => self,
    }

Otherwise you would have to do the parsing of the part before the braces manually (e.g., with Punctuated<IdentOrInteger, Token![.]>::parse_separated_non_empty or something like that, given some enum IdentOrInteger that impls Parse).

@Boscop in the meantime, you can use (self) or {self} to disambiguate 🙂

Ooh, now it actually makes sense, thank you! I'll probably parse it manually, if it won't be too problematic, because I don't want to introduce another syntactic layer.

So I decided to special case this, because self is pretty much the only bare token that makes sense here (delegating to a global variable or parameters of the delegated method is not currently supported). It works fine for normal cases, however there is some problem with macros generating the delegation tokens.
It seems that rustc inserts None-delimited groups around macro tokens (https://github.com/media-io/yaserde/pull/79), so this test generates something like this:
Group {
                   delimiter: None,
                   stream: TokenStream [
                       Ident {
                           ident: "self",
                           span: #3 bytes(659..671),
                       },
                       Punct {
                           ch: '.',
                           spacing: Alone,
                           span: #3 bytes(659..671),
                       },
                       Literal {
                           kind: Integer,
                           symbol: "0",
                           suffix: None,
                           span: #3 bytes(659..671),
                       },
                   ],
                   span: #3 bytes(659..671),
               },
... rest of input

Before, when I was parsing this as syn::Expr, it worked fine, so I tried to parse it as an Expr and if it doesn't work, switch to self, something like this:
impl syn::parse::Parse for DelegationTarget {
    fn parse(input: ParseStream) -> Result<Self, Error> {
        let cursor = input.cursor().token_stream();
        Ok(if syn::parse2::<syn::Expr>(cursor).is_ok() {
            DelegationTarget::Expr(input.parse()?)
        } else {
            DelegationTarget::SelfTarget(input.parse()?)
        })
    }
}

The problem is that the first condition doesn't succeed. I tracked it down to this:
syn::parse2::<syn::Expr>(input.cursor().token_stream()).is_ok() // false
input.parse::<syn::Expr>.is_ok() // true

I printed the contents of the two token streams and they seem to be the same, so it seems like there is something wrong with my usage of the parse2 function. This is hitting the limits of my syn-fu, as I have no idea why should this return a different result.
Maybe it's caused by this: https://github.com/dtolnay/syn/blob/master/src/parse.rs#L1173? Could it be avoided somehow?
@danielhenrymantilla any ideas? :)

Sorry for my late answer, I forgot about this thread.
The good thing is the results you are hitting make sense in my head; and I like the idea of using a None-delimited group as a workaround. I'm gonna be using ⟨ and ⟩ as sigils to represent the delimiters of None-delimited groups.
The key thing to understand about such ⟨…⟩ groups is:

they group the contained tokens as a single one, much like (), {} and [] do,

but they don't show up / are invisible to operations such as stringification, hence your:

I printed the contents of the two token streams and they seem to be the same

So, in your case, your sequence of tokens is:
⟨self . 0⟩ { … }

Then, the difference between:

syn::parse2::<syn::Expr>(input.cursor().token_stream()).is_ok() // false
input.parse::<syn::Expr>().is_ok() // true

is that the former tries to parse all the given tokens as an expression, whereas the latter only tries to parse a prefix of such tokens as one.
And given the capture, ⟨self . 0⟩ is an expression (self.0 is), but <expr> { ... } on the other hand, is not a valid expression (as I mentioned, the ambiguity originated from self being interpreted as a path, which is no longer the case with our ⟨self . 0⟩ captured expression).

The solution
The goot thing about having waited that long to keep this thread updated, is that, in the meantime, I have stumbled upon a bunch of posts from dtolnay where they mention that this is a common case of ambiguity in the language.
Because of that, I have suspected there had to be one function inside syn to disambiguate. And indeed there, which does contain the examples I had seen in such posts. Behold:

Expr::parse_without_eager_brace()

I'm pretty sure this will neatly solve your issues 😉

Thank you! That is exactly what I needed. Actually if I thought of using Expr::parse(input) instead of input.parse<syn::Expr> I would probably find it immediately :man_facepalming:
This test broke:
macro_rules! some_macro {
    ($delegate_to:expr) => {
        impl Trait for Struct2 {
            delegate! {
                // '$delegate' will expand to 'self.0' before ´delegate!' is expanded.
                to $delegate_to {
                    fn method_to_delegate(&self) -> bool;
                }
            }
        }
    };
}
some_macro! {self.0}

It produces
error[E0424]: expected value, found module `self`
  --> tests/in_macro_expansion.rs:34:14
   |
28 |                     fn method_to_delegate(&self) -> bool;
   |                     -- this function has a `self` parameter, but a macro invocation can only access identifiers it receives from parameters
...
34 | some_macro! {self.0}
   |              ^^^^ `self` value is a keyword only available in methods with a `self` parameter

Initially I thought that it's a regression of the new self parsing, but after bisecting it I realized that Rust 1.46 introduced this change (in macro hygiene?), as it also happens with the old code. Probably caused by this: https://github.com/rust-lang/rust/pull/73293/. Not sure if we can work around that easily.

Indeed, the self that the macro introduces is internal / hidden, so the caller of some_macro! has no way to refer to it / "cannot know what that self refers to"  (the whole point of hygiene was to avoid such confusing situations).
A possible fix is to use:
macro_rules! some_macro {
    (|$self:ident| $delegate_to:expr) => {
        impl Trait for Struct2 {
            delegate! {
                // '$delegate' will expand to 'self.0' before ´delegate!' is expanded.
                to $delegate_to {
                    fn method_to_delegate(&$self) -> bool;
                }
            }
        }
    };
}
some_macro! { |self| self.0 }

Looking forward for the merge of #26 !  :smile:

@lulivi Published rust-delegate 0.5.0 with #26.


Update contributing.rst

Add information on how to switch doc versions.
@koubaa When I searched the folder for occurrences of the<EMAIL_ADDRESS>email, I saw two instances. I don't know how or if I can change this content in a Dockerfile to<EMAIL_ADDRESS>In pymechanical\docker\231\Dockerfile, line 7
In pymechanical\docker\232\Dockerfile, line 7
German told me I could edit the address in the Dockerfiles so I did so in a later commit.

@samigithub2022 I'm not sure why the Documentation check is failing. The message says it is "Unable to fetch some archives..." Do you know what this means or how to fix it?

Let me update the PR... Just did some quick fixes here. Pinging @koubaa


Emacs crashes when killing text (Ctrl + W)

Mark text with Ctrl + SPC, go to end of text selection: CTRL+W. Everything freezes right there.
Doesn't happen through Terminal so I'm guessing its Hyper. Maybe from trying to access a clipboard?

Hyper 1.3.3
Electron 1.4.16
darwin x64 15.6.0

#1509

Same thing happens to me with C-k.

This happens to me as well with both Ctrl-W and Ctrl-K and also when copying a region of text with Meta-W.
This is the error message that appears in the console:

Im running Hyper 1.3.3 and macOS 10.12.6

close in #1876


Forward dynamics: J and gamma in the API ... why?

The forward dynamics algo computes the model acceleration given some torques and contact info. It is indeed requesting the explicit jacobian J and contact drift gamma to be provided by the user, while these info can be computed from the state q,vq, also given in input.
Shouldn't we provide a simpler API where J and gamma are already computed. At least, we could provide that for 6D contact, maybe also for 3D contacts. The API might be:
forwardDynamics(model,data,q,vq,tauq,[contact_1 ... contact_N]) with [...] a list of contact, each of which being a structure with the frame id and the contact dimension:
struct ContactInfo
{
frame_id idx;
enum { CONTACT_3D, CONTACT 3D } contact_type;
};
What do you think?

Sounds good to me.

I have already implemented such a solution.
I will provide it in two weeks if you are able to wait until then.
Le Vendredi, Décembre 28, 2018 17:14 CET, Nicolas Mansard<EMAIL_ADDRESS>a écrit:

The forward dynamics algo computes the model acceleration given some torques and contact info. It is indeed requesting the explicit jacobian J and contact drift gamma to be provided by the user, while these info can be computed from the state q,vq, also given in input.
Shouldn't we provide a simpler API where J and gamma are already computed. At least, we could provide that for 6D contact, maybe also for 3D contacts. The API might be:
forwardDynamics(model,data,q,vq,tauq,[contact_1 ... contact_N]) with [...] a list of contact, each of which being a structure with the frame id and the contact dimension:
struct ContactInfo
{
frame_id idx;
enum { CONTACT_3D, CONTACT 3D } contact_type;
};
What do you think?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@nmansard Is it fine for you?

Another answer to this issue comes from historical reasons.
The idea behind J and gamma is to enable the user to define his/her own contact model like rolling contact.
The current API is then much more flexible than the one assuming rigid contact model.


Add APNG image support

for #542

I'm sorry it took so long

There is only a slight difference between PINGIFAnimatedImage and PINAPNGAnimatedImage.
Based a PINAppleAnimatedImage would maybe is a better choice.

@garrettmoon This PR has been suspended for a long time, is there anything not modified?
I have updated the PR to the latest code.

It has been too long, I'm sorry :(
The CI failures may be related to Xcode updates. I think https://github.com/pinterest/PINRemoteImage/pull/616 may have some fixes there?

@garrettmoon it's done

Thank you for hanging in there and for the contribution!


Support custom HTML templates

Is your feature request related to a problem? Please describe.
Hardcoded HTML templates do not offer any customisation (to improve branding or security). For instance, we have a strict Content Security Policy, which does not allow inline scripts and we do not want to have unnecessary exclusions.
Describe the solution you'd like
Allow to configure custom HTML templates.
Describe alternatives you've considered
I cannot think of any.
Additional context
See https://github.com/zitadel/saml/pull/89.

Hey @feeltheajf
Thank you for the issue (and implementation). While there are for sure some workarounds for CSP (e.g. hash) and the form itself should not get displayed to the user, but i totally get your requirement. Will check the PR now.


Automatic names for devices and Assets

When a device is created automatically the is made with deviceModel and deviceReference separated by hyphen (AbeewayITSpot-deveui001). It was undescore in the prévious version.
When an asset is create it is an undescore wich separate type, model reference (CaisseMobile_krone_0008)

In fact when we create an asset directly with device-manager/asset:create the name is made with type-model-reference, separated by hyphen. In the above comment the name was created with _id and a local naming. So there is not a consistency problem the separator is hyphen.

You should use the provided API to create assets and devices, they will compute the name with hyphen separator automatically :+1:


Invalid log level handing in the code

Description
Our log levels are messed up.
We use go.uber.org/zap as the logging implementation.
This logger uses the following levels:

DebugLevel = -1
InfoLevel       = 0
WarnLevel     = 1
ErrorLevel     = 2
DPanicLevel = 3
PanicLevel    = 4
FatalLevel     = 5

In the pkg/log/logger.go, where we configure the zap/zapr logging, we  have the following code:
func ConfigLogger(level int8, syncer zapcore.WriteSyncer) logr.Logger {
        if level > 0 {
                level = -level
        }

This is essentially making any positive level a negative one.
Then in some kustomizations we configure logging level to 9, which then becomes -9... There's no such level at all.
Then we have this strange mapping in our code:
const (
        WarnLevel = iota  // 0
        InfoLevel              // 1
        DebugLevel         // 2
        TraceLevel           // 3
)

that is used in invocations like this:
logger.V(log.DebugLevel).Info(

There, the log.DebugLevel maps to the value of 2, which is... ErrorLevel in zap.
Overall it looks like a total mess at the moment and requires fixing.
Reasons
Lack of control over logging in the code
Acceptance Criteria

[ ] Establish sensible logging levels for the runtime flag - may remain numerical. Not sure if we should use negative values at all.
[ ] The log level used in the code must correspond to what is actually emitted to the log stream.

Feature Testing
No response
Testing approach
unit test
Related issues
https://github.com/kyma-project/lifecycle-manager/issues/345

Copying some first observations from https://github.com/kyma-project/lifecycle-manager/pull/1262/files#r1466093337 to here

I still don't fully get it, but seems that this [multiplying by -1] was right. According to docs, zap is using log levels like Debug -1, Info 0, Warning 2, ... where higher level means higher importance and less verbosity.
We are logging through the logr API where zapr is the implementation using zap. logr does not have a notion of log levels. Instead, it just distinguishes info and error messages and assigns a verbosity. The verbosity means "it is a more or less important info log" for instance. Verbosities are positive where higher number means less importance (opposite of zap).
Now, zapr describes the relation here https://github.com/go-logr/zapr?tab=readme-ov-file#increasing-verbosity where they initialize with the negative levels. Here I am now a bit confused and still need to think about it further. Just wanted to share my thoughts already.

There we go: https://pkg.go.dev/github.com/go-logr/zapr#hdr-Implementation_Details
Levels in logr correspond to custom debug levels in Zap. Any given level in logr is represents by its inverse in zap (zapLevel = -1*logrLevel). For example V(2) is equivalent to log level -2 in Zap, while V(1) is equivalent to Zap's DebugLevel.

Just as a further observation, looking at KLM logs, we can see levels Info, Debug, -1, -2, ...


Bump cardano-node

Appears to break compatibility with the most recent FF genesis
Should include what we need to get non myopic member rewards

bors try

Looks like there is a proper build failure in cardano-node/cardano-config. I have asked about it on slack.

bors try

Do we merge this now even if it breaks FF compatibility? Maybe we do still…?

Looks good to me. I am not sure whether we should wait for a ff respin before merging.

I'd be for waiting a bit unless it is blocking further development.

bors r+

bors r+

bors r+

It compiles locally for me, and it seems rebased 🤔

Ah, maybe due to other PRs in the same batch


bench: search multiple candidates

Let

n: number of nodes
k: choose k nodes

and assume each node has the same cap.
The number of searching segment table will be
sum (n/(n-i)) for i = [0,k)
for example, if n=10 and k=3 it will be 1+10/9+10/8 ~ 3
Write benchmark to check if the actual execution time can be explained by the math.

done.


Change in version of AWS Package causes resource to be replaced

What happened?
NPM Package version changed, causing replacement of resource due to a default provider change.
Version before: 5.20.0
Version after: 5.40.0
From CLI:
+-aws:servicediscovery/privateDnsNamespace:PrivateDnsNamespace: (replace)
        [id=ns-oysnznpiqouvsnhy]
        [urn=urn:pulumi:dev::business-web-app-experience-layer-pl1-account-setup::aws:servicediscovery/privateDnsNamespace:PrivateDnsNamespace::frontendplatform.app15584.dev]
        [provider: urn:pulumi:dev::business-web-app-experience-layer-pl1-account-setup::pulumi:providers:aws::default_5_20_0::6627ffcd-1e39-4b15-a682-24cec749691f => urn:pulumi:dev::business-web-app-experience-layer-pl1-account-setup::pulumi:providers:aws::default_5_40_0::20dad2ba-662d-488c-8d7c-733bbabfc84a]
      ~ description: "Platform private dns namespace for service discovery" => "Platform private dns namespace for service discovery for frontendplatform"

I got the customer to generate a plan, and here's the relative resource:
"urn:pulumi:dev::business-web-app-experience-layer-pl1-account-setup::aws:servicediscovery/privateDnsNamespace:PrivateDnsNamespace::frontendplatform.********.dev": {
            "goal": {
                "type": "aws:servicediscovery/privateDnsNamespace:PrivateDnsNamespace",
                "name": "frontendplatform.**********.dev",
                "custom": true,
                "inputDiff": {
                    "updates": {
                        "description": "Platform private dns namespace for service discovery for frontendplatform",
                        "tags": {
                            "Project": "business-web-app-experience-layer-pl1-account-setup",
                            "__defaults": [],
                            "app": "********",
                            "deployedBy": "**********",
                            "environment": "dev",
                            "feature": "platform-account-setup",
                            "managedBy": "Pulumi",
                            "platform-project": "business-web-app-experience-layer-pl1-account-setup",
                            "provisioned-by": "Pulumi",
                            "stack": "***********",
                            "team": "Productivity"
                        }
                    }
                },
                "outputDiff": {},
                "parent": "urn:pulumi:dev::business-web-app-experience-layer-pl1-account-setup::pulumi:pulumi:Stack::business-web-app-experience-layer-pl1-account-setup-dev",
                "protect": false,
                "provider": "urn:pulumi:dev::business-web-app-experience-layer-pl1-account-setup::pulumi:providers:aws::default_5_40_0::04da6b54-80e4-46f7-96ec-b56ff0331ba9",
                "propertyDependencies": {
                    "description": null,
                    "name": null,
                    "tags": null,
                    "vpc": null
                },
                "customTimeouts": {}
            },
            "steps": [
                "delete-replaced",
                "replace",
                "create-replacement"
            ],
            "state": {
                "description": "Platform private dns namespace for service discovery for frontendplatform",
                "id": "",
                "name": "frontendplatform-app15584.dev",
                "tags": {
                    "Project": "business-web-app-experience-layer-pl1-account-setup",
                    "app": "*********",
                    "deployedBy": "*********",
                    "environment": "dev",
                    "feature": "platform-account-setup",
                    "managedBy": "Pulumi",
                    "platform-project": "business-web-app-experience-layer-pl1-account-setup",
                    "provisioned-by": "Pulumi",
                    "stack": "**********",
                    "team": "Productivity"
                },
                "tagsAll": {
                    "Project": "business-web-app-experience-layer-pl1-account-setup",
                    "app": "*********",
                    "deployedBy": "********",
                    "environment": "dev",
                    "feature": "platform-account-setup",
                    "managedBy": "Pulumi",
                    "platform-project": "business-web-app-experience-layer-pl1-account-setup",
                    "provisioned-by": "Pulumi",
                    "stack": "************",
                    "team": "Productivity"
                },
                "vpc": "vpc-01ea94e87dd7374ee"
            },
            "seed": "3szGCti8yyzp/EaeJ6SzupcoSVb9Dh6ZY+yJzVj1MEo="
        },

Expected Behavior
Resource shouldn't be replaced
Steps to reproduce
Internal code
Output of pulumi about
 CLI
Version      3.72.2
Go Version   go1.20.5
Go Compiler  gc

Plugins
NAME    VERSION
nodejs  unknown

Host
OS       darwin
Version  13.4.1
Arch     arm64

This project is written in nodejs: executable='/opt/homebrew/bin/node' version='v20.3.1'

Backend
Name           pulumi.com
URL            https://app.pulumi.com/*****
User           *********
Organizations  **********

Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Hi @pierskarsenbarg - this is very strange behavior, indeed. Is this the only resource being replaced during this update?

Yes. I'll send you the entire plan in slack shortly

Hi @pierskarsenbarg - just to close the loop here. The actual change causing a replacement here is in the description:
https://www.pulumi.com/registry/packages/aws/api-docs/servicediscovery/privatednsnamespace/#inputs
That is something defined upstream of us by the terraform provider, so is a bit outside our control. Unfortunately, any change to a description here will replace this resource.

As this is an issue upstream, I'm going to mark it as such until we identify/open a corresponding issue, and that issue is resolved.

This has been fixed upstream: https://github.com/hashicorp/terraform-provider-aws/issues/32341


Failed to create watcher error

I am seeing the below issue when i try to run my application on containers.
2023/08/17 11:11:36 FATAL -- failed to create Watcher
goroutine 14 [running]:
runtime/debug.Stack()
/usr/local/go/src/runtime/debug/stack.go:24 +0x65
github.com/sec/go-plugin/vendor/github.com/hpcloud/tail/util.Fatal({0x7a6e23?, 0xc000310080?}, {0x0, 0x0, 0x0})
Tried on alpine & centos based containers with go 1.19.6.
Is this a known issue ? or is it not supported by the OS or go version i am using?
Appreciate all the help.

met the same problem 😢


Make spring-boot-configuration-processor dependency optional

spring-boot-configuration-processor should not be transient
dependency. This commit makes the dependency optional so it is not
passed transitively.

Hey @eddumelendez thanks for the contribution! 👍 LGTM and to @geoand
integrating


Update to allow custom endpoint version for Catalog

Issue is related to deprecated v0 endpoints as per info provided here
The Catalog Items v0 operations listCatalogItems (GET /catalog/v0/items) and getCatalogItem (GET /catalog/v0/items/{asin}) will be deprecated on September 30, 2022.
This change will add option to call specific endpoint version (as we currently default on v0 and there are two new versions currently active [3 in total])

Hi, thanks for the PR. The new endpoints for CatalogItems are in CatalogItems. The endpoint supports versioning as well.
See #568

def test_get_catalog_item():
    res = Catalog(version=CatalogItemsVersion.V_2020_12_01).get_catalog_item('B098RX87V2')
    assert res.errors is None
    assert isinstance(res, ApiResponse)

def test_get_catalog_item_version():
    res = Catalog(version=CatalogItemsVersion.LATEST).get_catalog_item('B098RX87V2')
    assert res.errors is None
    assert isinstance(res, ApiResponse)

def test_list_catalog_items():
    res = Catalog().search_catalog_items(keywords='test')
    assert res.errors is None


Official GPL-1.0 license text is not being matched correctly by LicenseCompareHelper.isTextStandardLicense()

When org.spdx.utility.compare.LicenseCompareHelper.isTextStandardLicense().isDifferenceFound() is run on the official GPL-1.0 license text, it (incorrectly) returns true (i.e. the standard license was not matched).  When I run org.spdx.utility.compare.LicenseCompareHelper.isTextStandardLicense().getDifferenceMessage() on it, I get:
Additional text found after the end of the expected license text starting at line #192 column #21 "end"

However the GPL-1.0 SPDX template does appear to (correctly) contain the text END OF TERMS AND CONDITIONS at this point (albeit in an <optional> block).
This was reproduced with Spdx-Java-Library v1.11 and SPDX license list v3.23.

Note: the same thing appears to be happening with the official GPL-2.0 license text as well.


Clean-up publish-blobs.yml to have better defaults

Cleaning this up in order to remove azure-sdk-docs-prod-blob-name from the keyvault. Need to do this first and then I can remove all the references to that value in all the language repos.

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow


External hyperlinks (Relationship) with a space character within its address crashes Excel 2007.

Describe the bug
This issue is a kind of link to this issue - https://github.com/ClosedXML/ClosedXML/issues/2397
Feel free to close this issue as invalid if it's necessary (I don't have enough time to properly describe this right now).
Screenshots
If applicable, add screenshots to help explain your problem.
To Reproduce
// Please add a self-contained, minimum viable repro of the issue.
// If you require external resources, please provide a gist or GitHub repro
// An Xunit style test is preferred, but a console application would work too.
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Observed behavior
A clear and concise description of what you expected to happen.
Expected behavior
A clear and concise description of what you expected to happen.
Desktop (please complete the following information):

OS: [e.g. Windows]
Office version [e.g. 16.0.15427.20178]
.NET Target: (e.g. .NET Framework, .NET Core, UWP, Xamarin...)
DocumentFormat.OpenXml Version: (e.g. 2.11.0)

Additional context
Add any other context about the problem here.

I don't have enough time to properly describe this right now

Make bug reports great again!

closing as not actionable. Please reopen with more details if needed.


Disable runner not correctly implemented

The disable runner operation is executing a wrong request:
Executing request DELETE /api/v4/projects/20218/runners?runner_id=2632 HTTP/1.1
But as per spec it should be DELETE /projects/:id/runners/:runner_id [https://docs.gitlab.com/ee/api/runners.html#disable-a-runner-from-project].

@olivierpaquet
This has been fixed and is available in release 4.9.18, please verify and close when you have a chance.

@olivierpaquet
I'm closing this since it has been fixed.  Feel free to re-open if you find any issues with the fix.


Add custom styles/dark mode for Google Map

Looks pretty weird right now, and markers are rather hard to make out w/ default settings.

Completed in release v1.2.0.


yeast 8.6.3

Main improvements in this PR:

Feature:

New reactions and metabolites related to volatile esters & polyphosphates (PR #337)

I hereby confirm that I have:

[x] Tested my code with all requirements for running the model
[x] Selected main as a target branch (top left drop-down menu)
[ ] If needed, asked first in the Gitter chat room about this PR

@mihai-sysbio I don't understand why memote-run keeps on failing.

Well, it looks like there could be two issues (at the same time):
A) Something to do with the permissions
touch: cannot touch '.env': Permission denied

B) Dependencies are not installed (perhaps they have been changed also since the previous release?)
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/opt/code/io.py", line 8, in <module>
    from dotenv import find_dotenv
ModuleNotFoundError: No module named 'dotenv'

The workflow is missing this line from the README:
pip install -r code/requirements/requirements.txt  # installs all dependencies

which is of course faster (the installation takes forever).

This also begs the question how come the .github/workflows are different in /main and /develop.

@edkerk please see PR #341 - once that is merged in develop, it should allow the failed workflow to re-run successfully

So not to delay further model progress, I'll merge this PR, the failing memote run can also be solved in another Issue/PR.

Not sure why it's failing, the models is loaded, memote is running. Some tests are failing, but that shouldn't trigger the Action to fail?

An action/workflow fails based on the exist code of the command. I presume the python command exited with an code of non-zero, indicating error, because of:
 Storing result in 'result.json.gz'.
Traceback (most recent call last):
  File "/usr/local/bin/memote", line 8, in <module>
    sys.exit(cli())
[...]
  File "/usr/local/lib/python3.9/gzip.py", line 173, in __init__
    fileobj = self.myfileobj = builtins.open(filename, mode or 'rb')
PermissionError: [Errno 13] Permission denied: 'result.json.gz'

This means the result gzip doesn't get created, likely because of the same file permission issue like above about the .env file.


Dev

⚠ WARNING: This PR is too large. Consider breaking it down into smaller ones for faster and easier review.

⚠ WARNING: This PR is too large.
Consider breaking it down into smaller ones for faster and easier review next time.
Make sure your code has tests and you have done the necessary QA.

⚠ 🔴 WARNING: This PR is too large.
Consider breaking it down into smaller ones for faster and easier review next time.
Make sure your code has tests and you have done the necessary QA.

⚠ WARNING: This PR is large.
Make sure your code has tests and you have done the necessary QA.

⚠ 🔴 WARNING: This PR is too large.
Consider breaking it down into smaller ones for faster and easier review next time.
Make sure your code has tests and you have done the necessary QA.


uncaptured error during startup

FabricPlugin is unable to catch one error during initialization (white screen shortly after splash screen).
https://github.com/graphql/graphql-js/issues/1182
I identified the crash/bug itself and was able to apply a workaround for the bug.
However on fabric dashboard for broken builds there is no even 'Launch' registered in beta - just "installed". I am sure the "launch" and errors should be both captured by crashlytics.
Even more - as for broken builds an app despite the error/stuck on white sreen - is able to detect a new build - thus I believe that error intercepting should be possible to be initialized earlier as well.
should this be considered as a bug/enhancment?
https://stackoverflow.com/questions/52751138/error-after-startup-of-ionic-app-uncaught-by-crashlytics-fabric

Working with Sapper and "graphql": "15.0.0" today and here we are!
Temporarily fixed by building with NODE_ENV=production. But something is broken I think. 🤕


httpd_ws_send_frame_async makes illegal frames (IDFGH-3443)

Environment

Development Kit:      none
Module or chip used:  ESP32
IDF version (run git describe --tags to find it):
v4.2-dev-1660-g7d7521367
Build System:         idf.py
Compiler version (run xtensa-esp32-elf-gcc --version to find it):
xtensa-esp32-elf-gcc (crosstool-NG esp-2020r1) 8.2.0
Operating System:     Linux
Using an IDE?:    Yes, Visual studio code
Power Supply:         USB

Problem Description
When using httpd_ws_send_frame_async, a simple client using python websocket_client says that frames are invalid.  Non-async frames are fine.
Expected Behavior
Data would be received as normal
Actual Behavior
send: b'\x81\x87w\x0eS\xd1?k?\xbd\x18.c'
recv: Hello 0
send: b'\x81\x87\xb7\xe4\xb3\x92\xff\x81\xdf\xfe\xd8\xc4\x82'
error: Illegal frame
send: b'\x88\x82\xf7\xf3w\t\xf4\x1b'
closed
Steps to reproduce
Run a websocket server.  Run python client.  Trigger an async event (such as a push button).
Code to reproduce this issue
This should also error out with the Espressif ws_echo_server as well.
static void async_work(void *arg)
{
    connection_data_t *n;
    SLIST_FOREACH(n, &connection_data_head, next) {
        static const char *data = "Hello async world!";
        httpd_ws_frame_t ws_pkt = {
            .payload = (uint8_t *)data,
            .type = HTTPD_WS_TYPE_TEXT,
            .len = strlen(data),
        };

        httpd_ws_send_frame_async(server, n->fd, &ws_pkt);
    }
}

static void async_task(void *pvParameters)
{
    while (true) {
        xEventGroupWaitBits(io_event_group, IO_BUTTON0_DOWN, pdFALSE,
            pdFALSE, portMAX_DELAY);

        httpd_queue_work(server, async_work, NULL);

        xEventGroupWaitBits(io_event_group, IO_BUTTON0_UP, pdFALSE,
            pdFALSE, portMAX_DELAY);
    }
}

Python test code is here: https://pypi.org/project/websocket_client/#long-lived-connection

@jkent Thanks for reporting, we will look into.

Hi @jkent
The reason why the async frames are treated as invalid is that they miss the FIN flag. Please update the snippet to:
        httpd_ws_frame_t ws_pkt = {
            .payload = (uint8_t *)data,
            .type = HTTPD_WS_TYPE_TEXT,
            .len = strlen(data),
            .final = true,
        };

should make the websocket client receive the async frames correctly.
There's a bug in the example code and the documentation is not very clear on the asynchronous send. This will be fixed.

Hello,
Not fixed yet, neither example code nor documentation.
"There's a bug in the example code and the documentation is not very clear on the asynchronous send. This will be fixed."
https://github.com/espressif/esp-idf/issues/5602
Thank's.

Hi again,
How to use "httpd_ws_send_frame_async" without "static esp_err_t trigger_async_send(httpd_handle_t handle, httpd_req_t *req)"  ?
I need to use "httpd_queue_work(handle, ws_async_send, resp_arg);" ?
In the function "esp_err_t httpd_ws_send_frame_async(httpd_handle_t hd, int fd, httpd_ws_frame_t *frame)", is not very clear to me
which one httpd_handle_t hd and which one int fd to use.
Thank's.


add SexyFont client submod

This makes the minecraft text renderer a whole lot gooder
sample: https://i.imgur.com/Yeckp4U.gifv

This is required

i agree

ooh, that's hot

Why isn’t this accepted yet

pls accept

hi discord

#StartTheRevolution

Dab

![damn](https://cdn.discordapp.com/emojis/489113647302443028.png?v=1 <3)

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉


It would be better to display the string 'Search Results' in the address bar when applying 'search by prefix' in one blob container

Storage Explorer Version: 1.20.0-dev
Build Number: 202100625.5
Branch: rel/1.20.0
Platform/OS: Windows 10/ Linux Ubuntu 20.04/ MacOS Big Sur 11.4
Architecture: ia32/x64
How Found: Exploratory testing
Regression From: Not a regression
Steps to Reproduce

Expand one storage account -> Blob Containers.
Create a blob container -> Click 'Show Filter Panel'.
Type a character to the 'Search by prefix (case-sensitive)' box -> Click 'Hide Filter Panel'.
Observe the address bar.
Check whether the string 'Search Results' displays in the address bar.

Expected Experience
The string 'Search Results' displays in the address bar.
Actual Experience
The blob container name displays in the address bar.
Additional Context
The string 'Filter Results' displays in the address bar after applying filters.

I did this!


[fix][broker] make closing producer thread-safe while updating recently closed producer

Motivation
Right now, #20747 has a limitation where closing producer has to be called from the same executor of the connection-ctx which might not be always true for usecases where async operation can be completed by a different thread. #20747 was added to store value in closed-producer map thread safely so, the correct fix is to make the map thread-safe to avoid duplicate efforts during storing into the map which will remove the above limitation.
Modifications
Make recentlyClosedProducers thread-safe as it can be accessed by multiple threads.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Codecov Report

Merging #21355 (29d02b2) into master (1a352f1) will increase coverage by 39.27%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             master   #21355       +/-   ##
=============================================
+ Coverage     33.49%   72.76%   +39.27%
- Complexity    12257    32526    +20269
=============================================
  Files          1636     1876      +240
  Lines        127789   140102    +12313
  Branches      13963    15442     +1479
=============================================
+ Hits          42798   101952    +59154
+ Misses        79372    30068    -49304
- Partials       5619     8082     +2463

Flag
Coverage Δ

inttests
24.08% <100.00%> (-0.06%)
:arrow_down:

unittests
72.53% <100.00%> (+40.52%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...va/org/apache/pulsar/broker/service/ServerCnx.java
71.84% <100.00%> (+32.33%)
:arrow_up:

... and 1501 files with indirect coverage changes


How do I use this to detect the start of a speech segment?

Q1) can I use this on a .wav/.mp3 files?
Q2) how to use this to to detect the beginning of any voice activity in the file.

Hi @StanSilas , I am glad it will be useful for you.
Q1: you can use this to a file(wav/mp3), you should change the interface a little. for example:
fp = open('test.wav')
data = fp.read()

then you can do vad using data
Q2: if you solve Q1 successfully, you will find you can do VAD at any time.

you can deliver the voice data to this function
active = vad.is_speech(chunk, RATE)

@StanSilas


token validation of  a new user (user registration backend) always fails.

Hi @bennylope ,
I realize that a random password is set, when creating a user in the registration backend.
https://github.com/bennylope/django-organizations/blob/master/organizations/backends/defaults.py#L348-L352
Would it make sense to forge a proper user token during the time of creation of the user - since the activate_view in the BaseBackend checks to see if the forged token is a valid token?
https://github.com/bennylope/django-organizations/blob/master/organizations/backends/defaults.py#L134
Right now the validate_token func doesn't work as the token forged isn't a proper one (random one).
If this sounds ideal (I might be wrong) , I can submit in a PR, since this is something that I would myself need.

If you have a PR for this that'd be welcome.
In version 2, in pre-release, an updated system does away with the need to use these tokens, using an intermediate model instead with a UUID.


Does not load tesla trap from Piggys Variety Mod

Piggys variety mod adds a tesla gate which works fine but once LQ is installed the trap doesn't get added to the preset and stops spawning no matter the order i delete files or install the mods. When I first used these mods together they seemed to work fine and i could change the tesla gate config just like any other trap it only seemingly stopped working after a crash with the minecraft village moon, but I have yet to be able to recreate them working together even on a fresh modpack. Side note all the scrap from Piggys variety works fine and is added to the presets file.

Ok thanks, I'll have to see if they instantiate the trap differently or something.


chore(ci): add automation that asks/enforce PR title to incl. a scope and change type

Hey, I just made a Pull Request!
I'm not sure where is the right place to bring this up... So I raised a PR :laughing:
This PR adds the Conventional Commits convention to this repository, as we had already in backstage-showcase.
But here, with our workspaces, I set requireScope to true.
This will request that all PR titles starts with a type and a scope (workspace) like:

feat(bulk-import): awesome new feature
fix(repo-tools): some bugfixes
...

All types:

feat
fix
chore
docs
style
refactor
perf
test
revert

It should ignore the Version PRs from @rhdh-bot
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or Updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)

/cc @BethGriggs @04kash @kim-tsao @schultzp2020
Wdyt? Any opinions?
If you're fine / not blocking this, then I would add a small section to CONTRIBUTING.md


Count on properties is evaluated on sql for each of item.

Steps to reproduce
I try to make count on list properties and this count query is evaluated for each of record, not as one query. It is bad performance.
db.Blogs.select(x=> new BlogsDto(){       PostsCount = x.Posts.Count})
Is there some not implemented functionality yet? I try also do this with include but also get 100 of Count query for each of Blog.
This code is simplified to get a problem.
EF Core version: 2.2.3
Database Provider: PostgreSQL

Ok I find duplicate #11186


Fix http proxy ENV when TLS is enabled.

Fixes https://github.com/containerd/cri/issues/1169.
Support http proxy env.
The transport is the same with https://github.com/containerd/containerd/blob/master/cmd/ctr/commands/resolver.go#L82
Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

/test pull-cri-containerd-node-e2e

create some test cases unit and crictl or node that test TLS, Proxy, and other off the beaten path patterns for registry pull tests

It is hard to test this. :(

create some common code in containerd that can be used here and in ctr.

Added TODO

Just added a TODO, apply lgtm based on https://github.com/containerd/cri/pull/1171#pullrequestreview-248761802


Write tests

[x] Click into different sections- @Hi9173
[x] IPC Handlers - @Hi9173
[x] Help button - @Ohm-Rishabh
[x] loadMatrix() - @Ohm-Rishabh
[x] createWindow function (renderer)- @bdasgupta027
[x] convertMarkdownToHtml - @bdasgupta027

@ishanppendse merge the PRs to unblock this progress

PR is up but not merged as it had some minor merge conflict before code freeze - #78


Geocoding API not responding fast enough

This error started happening a few weeks ago.  More specifically happens when getting lat and lon from ip address.  Please help.

This means the geocoding service is slow/down. Try using a different :ip_lookup.


libs.xml_utils: fix class alias XmlElementTree

Codecov Report

Merging #25 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop      #25   +/-   ##
========================================
  Coverage    70.12%   70.12%
========================================
  Files           14       14
  Lines          666      666
  Branches        87       87
========================================
  Hits           467      467
  Misses         164      164
  Partials        35       35

Impacted Files
Coverage Δ

cl_sii/libs/xml_utils.py
68.42% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d675be...cde9fe6. Read the comment docs.


Added uceou

Official School Website URL : https://www.uceou.edu/
CS Courses URL : https://www.uceou.edu/dept-cse.php   ->(go to courses section)
email template<EMAIL_ADDRESS>Address : CG49+PCF, Osmania University, Hyderabad, Telangana State, INDIA.

@BalaAkshay Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.

Thankyou


How does sampling work?

It's not clear how this exporter interacts with sampling. If I were to use the Probability Sampler, it is not clear how to provide that sampling rate to this exporter. Moreover, if I wanted to use a dynamic sampling method, it doesn't seem like I'd be able to send the sampling rate over on a span by span basis. Should I just entirely avoid the opencensus sampler and do the sampling via configuration of libhoney?

Hi @apechimp ! I just merged https://github.com/honeycombio/opencensus-exporter/pull/7 in which I add the sampleRate to the event.
If you were to use the Probability Sampler, please also pass the sample fraction you choose to use to the exporter. (You can see an example of that in the example app in this repo).
Thanks for the suggestion!


Module build failed: Error: Cannot find module 'jshint'

Hello,
I use webpack 3.8, and i can't use the given configuration as I have error "Module build failed: Error: Cannot find module 'jshint'".
Nevertheless, the directory "jshint-loader" is in node_modules... Any ideas ? :)
The code I use:
module: {
rules: [
{
test: /.(jsx|js)$/,
exclude: /node_modules/,
use: [{
loader: 'babel-loader',
options: {
presets: ["es2017", "stage-0", "react", ],
plugins: ["transform-decorators-legacy"]
}
}, {
loader: 'jshint-loader'
}]
}
Thanks,
Dorian

I hit the same issue. I ran npm install jshint --save-dev and that resolved it.
However, then I hit the same issue as in #50 which doesn't appear to have a nice fix at present.


Don't provide default decimal precision & scale

Is your feature request related to a problem? Please describe.
Currently, there is a default scale & precision. Those attributes are highly dependant to the usage.
Describe the solution you'd like
Just no default. The user must provide its own scale & precision. This impacts the current AvroDecimal annotation, where we should remove the default precision, and set the default scale to 0 line the standard library.
The global default may be provided through a serializer or the avro config, but I would say to first not do it for simplicity.
Breaking change: annotating a BigDecimal with @Contextual or @Serializable(with = BigDecimalSerializer::class) will still need @AvroDecimal. We may want to provide a default configuration-less usage for a better adoption and simplicity with a default to the string type (no logical type), but this complicates the API to go back to a bytes or fixed type.
Whatever the default, there is 3 decimal types : bytes, fixed, and string (this one without the logical type).
Side note: there is an ongoing dev that would ship in avro 1.11.4 and 1.12.0 including a new big-decimal logical type where we don't need to provide a scale or a precision, which would fit perfectly to the need of a default configuration-less encoding of a BigDecimal

Released in v2.0.0


smooth scroll is not working in chrome version>=81

if (document.querySelector(target)) {
                    event.preventDefault();
                    document.querySelector(target).scrollIntoView({ behavior: 'smooth' });
                }`

if (document.querySelector(target)) {
                    event.preventDefault();
                    document.querySelector(target).scrollIntoView();
                }

Tried both the ways in chrome Version 81.0.4044.138(official-build). but no luck, smooth scroll is not working. But the same is working in IE and firefox. By setting inside a time out function also didnt do the trick.
Also noticed one thing in other versions like 71.0 smooth scroll is working fine

I had the same experience, but it worked when I enabled animations for Windows display settings.
This seems to be by design for the scroll-behavior CSS property.

@imkrmgn  thanks a lot mate after changing the display settings ,, booom,, started  working for me


Cryptic and un-actionable error message when actor interfaces do not match

Expected Behavior
A mismatch in actor interface contracts can be reported in a way that makes sense.
Actual Behavior
Having a mismatch in details like what namespace an interface or DTO is declared in results in a cryptic error message.
 No interface found with this Id 403064080

This error can't really be reasoned about since it's a generated checksum. Fixing the problem is a matter of trial and error. I don't have in my head yet a clear picture of what exactly has to match for communication to work properly.
It seems like the best way (right now) to use actors with Dapr is to rely on binary dependencies to share contracts. This fights with the rationale for using microservices in the first place (to version and deploy separately).
Steps to Reproduce the Problem
Using the actor sample in the repo - remove the project reference from the sample client. Copy the IDemoActor interface into the sample project, and change the namespace used to declare to be inconsistent with the hosting project.

Non remoting scenario without the need for sharing the interface can be used for this: https://github.com/dapr/dotnet-sdk/blob/master/samples/Actor/ActorClient/Program.cs#L74

I just ran into this error on a new project. Is a copy of existing project that works fine.
What do I need to start looking at to resolve this cryptic error?

Hi @MattCosturos - It's a been a while since I opened this issue, so I'm remembering to the best of my ability ....
What I remember about this issue is that the C# strongly-typed actor programming model requires you to share interface definitions between the client and the server. It's not good enough for for the interfaces to have the same members and names, they need to actually be shared via project-references.

Thanks for getting back to me.
I ended up having some mixed up reference in my new project docker builds. I was using Actor binary from project 1, but client binary from the new project 2, so in my case it was an actual mismatch interface.
It would be great if the error message could be improved to be something like "Actor with Interface definition Task<string> DoSomething(int param) not found"

Somewhat related, I have a proposal/PR (#1158) that would eliminate the need for applications to share compiled definitions when using strongly-typed interfaces.


Updated examples for build-time env configuration for v8

This should not be merged until v8 has been released!

I updated the example with-universal-configuration-build-time to use the new next.config.js env-option instead of the transform-define babel-plugin. Now also includes dotenv for managing variables.
Also updated the Readme for with-dotenv to make it clearer what the difference between the two examples are, and added link to the above example.
While the automatic inclusion of referenced variables in with-dotenv can be nice, I'm not sure if it makes sense to keep this example now that there is a more idiomatic way to include environment in Next? In this example it is also not as clear that inlining happens at build-time which can lead to confusion, for example in #6229.
Tried structuring it in a way that it made sense, but would love any feedback. :)

It works for me in development, but fails to build in production while deploying to Heroku unless I comment out the require dotenv lines https://github.com/NinjaOnRails/danni-react-apollo/blob/master/next.config.js

@NinjaOnRails Old merged PRs are not the best place for this (I only saw your comment by accident 😄), but the problem you seems to be having is this:
dotenv tries to read variables from a .env-file in the root of the application, but this is correctly ignored in your .gitignore because you don't want to check in secrets to git. When code lands in Heroku, the .env file is not there.
Here is a good resource for how to manage config variables in Heroku: https://devcenter.heroku.com/articles/config-vars

I put it in a conditional statement like below and it didn't work at first and I thought there was something else wrong, but now it works, so I guess I must've made a typo somewhere previously 👯♂
if (process.env.NODE_ENV !== 'production') {   const dotEnvResult = require('dotenv').config();   if (dotEnvResult.error) {     throw dotEnvResult.error;   } }


Adding the workflow to create releases with changelog

This workflow happens when a tag is pushed.
Changelog will list all commits and commits' summary.
Release's body will be the previously generated changelog.

You might want to add on pull request so it will create a release on pull requests. I'm not sure of how tags works on pulls request
Moreover, you might want to create more branches and keep the master for production only (it depends of how you organise the repository though.)
You can preview the result of my tests here

Hello and thank you very much for your help.
I'll check it out more in-depth and merge a bit later. But from what I see now from your tests it looks perfect!

Hello and thank you very much for your help.
I'll check it out more in-depth and merge a bit later. But from what I see now from your tests it looks perfect!

So I thought that best way to test it just to merge, and I did. Also I've had several tags locally for older versions which I pushed, and I see nothing. Does this work only for tags for commits that were added after action workflow?

So I thought that best way to test it just to merge, and I did. Also I've had several tags locally for older versions which I pushed, and I see nothing. Does this work only for tags for commits that were added after action workflow?

I fear it only works for tags after it. I pushed 2 tags at the same time on my test repository and it created two releases but these releases were after the commit which added the workflow.
Maybe you can try making a branch to test it. Make a test tag in this branch after updating the workflow file:

Line 34 set draft = true so it won't publish an actual release but just a draft for us to test it.

I fear it only works for tags after it. I pushed 2 tags at the same time on my test repository and it created two releases but these releases were after the commit which added the workflow.
Maybe you can try making a branch to test it. Make a test tag in this branch after updating the workflow file:

Line 34 set draft = true so it won't publish an actual release but just a draft for us to test it.

Yeah thanks, that worked)

Yeah thanks, that worked)

@all-contributors please add @Lyaaaaaaaaaaaaaaa for infra

@all-contributors please add @Lyaaaaaaaaaaaaaaa for infra


v0.5.0 Release Tracker

ETA Monday 06/10.
This is a version bump in minor because we expect the following major features to informally enter beta stage:

Chunked Prefill
Speculative Decode
FP8
VLM

Blockers:

[ ]

Optional:

[ ] https://github.com/vllm-project/vllm/pull/4650
[ ] #4109

Until I complete the chain of PRs related to #5214, imo the dev API for VLMs is still too unstable to be considered "beta".

Any plan to support aarch-64 ?

Hi, is it possible to include the following PRs?

#4409
#5054
#5197

Yes, #4409 please.

if you can include https://github.com/vllm-project/vllm/pull/5164 in the release it would be great

Initial support for LLaVA-NeXT (#4199 + #5380) has been merged!

What's going on with the releases? It shows up under releases but it's also not the latest release. Docker vllm/vllm-openai also hasn't been updated?

@simon-mo Sorry for tagging you. Would you mind telling me if vllm support aarch-64 now or not?

No. Contribution welcomed.


Add tasks to perform linting including checking YAML files.

Description

This PR adds Taskfile tasks for linting:
# Checks for linting violations
task lint:check

# Checks and fixes any fixable linting violations
task lint:fix

It currently includes linting for YAML files which can be run specifically with:
task yml:check
# or
task yml:fix

More linters will added in future PRs along with a GitHub workflow to run them.
NOTE:

The code is largely based on lint-tasks.yml and lint-requirements.txt from log-surgeon.
We should be naming our files with the ".yaml" extension as encouraged by the RFC. but for consistency with Taskfile.yml, I'm leaving the added lint-tasks.yml as is.

Validation performed

Added a trailing space in Taskfile.yml
Validated that task lint:check detected the error.
Validated that task lint:fix detected the error (yamllint doesn't have support for fixing any violations automatically).

Summary by CodeRabbit

Documentation

Enhanced clarity in the README.md with a new "Contributing" section and subsections for "Set up" and "Linting."

New Features

Introduced a new linting task in the project, enabling checks and fixes for YAML files.

Chores

Added yamllint as a required dependency for YAML linting.
Created a structured configuration for linting tasks in lint-tasks.yml.

Not sure if we want to follow "Conventional Commits"; if not the PR title is fine for the final commit message.

Forgot how specific "Conventional Commits" was. Maybe we can adopt it in the future (with a workflow to ease adoption).


Signature on Specific pages

Hello, is it possible to add visible signature on specific page, like on page 2 & 3 or on all pages?

here my update working with pages array:
export const signPDF2 = async (base64Pdf: string, base64Img: string) => {
  const tempPdfBuffer = base64ToArrayBuffer(base64Pdf);
  const tempImgBuffer = base64ToArrayBuffer(base64Img);
  const certificatePath = path.join(__dirname, "./secret/lutfiikbalmajid.pfx");
  const signerCert = fs.readFileSync(certificatePath);
  const pages = [0, 1, 2, 3];
  let tempPdf = tempPdfBuffer;

  for (let i = 0; i < pages.length; i++) {
    console.log(i);
    let sopt = {
      p12cert: signerCert,
      pwd: "foo123",
      permission: 4,
      drawinf: {
        area: {
          x: 25, // left
          y: 150, // top
          w: 60, // width
          h: 60, // height
        },
        pageidx: pages[i],
        imgData: tempImgBuffer,
        imgType: "png",
      },
    };

    var signer = new Zga.PdfSigner(sopt);
    var u8arr = await signer.sign(Buffer.from(tempPdf));
    tempPdf = await u8arr.buffer;
  }

  return {
    msg: "success",
    base64string: Buffer.from(tempPdf).toString("base64"),
  };
};

function base64ToArrayBuffer(base64: string) {
  const buffer = Buffer.from(base64.split(";")[1].split(",")[1], "base64");

  return buffer;
}

this is so cool, what i've been looking for. most easier over another nodejs signer library. Thank you

I second the comment on the last poster.  This library is exceptional in that it just WORKS out-of-the-box.  I have tried everything else and this is by far the simplest and foolproof implementation out of them all.  Thank you's to @zboris12 just doesn't seem adequate.


Ch13768/dominant speaker for our ac dialer

https://app.clubhouse.io/callstatsio/story/13768/dominant-speaker-for-our-ac-dialer
Dominant speaker for our AC dialer
Detect dominant speaker in AC dialer using hark library.

@LongHDinh @karthikbr82 Can you please quickly go through the pull request ? 😄


CreditCardDetector and strict mode

Hey there, very nice work with cleave.js!
I have a question regarding the new strict mode for credit card detection:
Would it be possible to keep the spacing lengths for e.g. amex and still make it possible to enter 19 digits? When I enable strict mode and type in an amex number, the spacing is the same for every card.
See https://jsfiddle.net/shapeshifta/Lhqu62vk/5/
Thanks :+1:
BTW: This number, for example, is supposed to be for aura credit cards, 19 digits long and has a valid Luhn:<PHONE_NUMBER>000127985

Sorry for the delay.
Good idea, should be an easy fix. Will update soon.

That would be indeed very cool! Thanks!

Released in https://github.com/nosir/cleave.js/releases/tag/v1.5.0
Cheers

Thanks a lot!


Support for optimistic channel open

Crate
relayer

Summary
The IBC specification allows a channel handshake to be initiated over a connection that exists but not in Open state.
Hermes does not have proper support for this.

Problem Definition

Proposal

Acceptance Criteria

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate milestone (priority) applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

Closing until we get request.


Remove outdated version (<IP_ADDRESS>)

The latest version is available in the Microsoft store, as the store is also used as source for winget, it is not necessary anymore, to provide it here as well.
Microsoft Reviewers: Open in CodeFlow

URL: https://languagetool.org/download/windows-desktop/Languagetool.Packaging_<IP_ADDRESS>/Languagetool.Packaging_<IP_ADDRESS>_x64.msixbundle
OK
(Automated message - build 829)

Hi @boergegrunicke,
This manifest has the highest version number for this package. Is it available from another location? (This might be in error if the version is switching from semantic to string, or string to semantic.)
(Automated response - build 878.)

URL: https://languagetool.org/download/windows-desktop/Languagetool.Packaging_<IP_ADDRESS>/Languagetool.Packaging_<IP_ADDRESS>_x64.msixbundle
Status Code: 200
(Automated message - build 878)

Even if an application is available in the msstore source, it is a good idea to keep in in this repo too, as there are several users who do not have the msstore source available or who have elected to remove it

URL: https://languagetool.org/download/windows-desktop/Languagetool.Packaging_<IP_ADDRESS>/Languagetool.Packaging_<IP_ADDRESS>_x64.msixbundle
Status Code: 200
(Automated message - build 878)

URL: https://languagetool.org/download/windows-desktop/Languagetool.Packaging_<IP_ADDRESS>/Languagetool.Packaging_<IP_ADDRESS>_x64.msixbundle
Status Code: 200
(Automated message - build 878)

URL: https://languagetool.org/download/windows-desktop/Languagetool.Packaging_<IP_ADDRESS>/Languagetool.Packaging_<IP_ADDRESS>_x64.msixbundle
Status Code: 200
(Automated message - build 880)

@stephengillie - Probably don't need to have your automation re-check this one each day

It shouldn't be rechecking each day. I think I may have found a bug, where I didn't have the .name property specified. Testing suggests that this was the cause, so hopefully the unnecessary checks will stop now.

URL: https://languagetool.org/download/windows-desktop/Languagetool.Packaging_<IP_ADDRESS>/Languagetool.Packaging_<IP_ADDRESS>_x64.msixbundle
Status Code: 200
(Automated message - build 880)


Make a distinction between language driver and language variant.

http://tinkerpop.apache.org/docs/3.2.1-SNAPSHOT/tutorials/gremlin-language-variants/

driver: the machinery to connect to Gremlin Server (Websockets, etc.)
variant: the machinery to write Gremlin in native Go.

Thank you, for pointing this out, gremgo is a driver and not a language variant. I will make this clear in the readme.


go/lint: enable nancy once again

Fixes: https://github.com/moov-io/infra/issues/138

Codecov Report

Merging #140 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   75.75%   75.75%
=======================================
  Files           1        1
  Lines          33       33
=======================================
  Hits           25       25
  Misses          4        4
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ed1ada...669b8a9. Read the comment docs.


[$500] Android - IOU-Tapping hold request, cursor is shown but keypad is not opened

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.44
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Action Performed:

Launch app
Tap 1:1 report
Create request money
Tap IOU to open details page
Tap 3 dots on top
Tap hold request

Expected Result:
Tapping hold request, cursor is shown similarly keypad must be opened.
Actual Result:
Tapping hold request, cursor is shown but keypad is not opened.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/b93abb62-df2e-4365-9b37-deedc5fed124

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012dbcf06cfb05e557
Upwork Job ID:<PHONE_NUMBER>179457024
Last Price Increase: 2024-02-27

We think that this bug might be related to #vip-bills
CC @davidcardoza

@izarutskaya can you please test again on production android app with the same android device where you reproduced bug on staging build?

Proposal
Please re-state the problem that we are trying to solve in this issue
When the HoldReasonPage opens, the input is looks like it's focused but the keyboard doesn't show up.
What is the root cause of that problem?
I was not able to find any offending PR within the deploy checklist, so I'm assuming this was not caused by the latest deploy.
This being said, the root cause of why the keyboard does not open on Android even though the input looks like it's focused (we see focused styles and the cursor) is because the focus is called when the component is not completely ready, most likely because of the navigation transition. I can confirm this since in rare cases, the keyboard does show-up (randomly) and I think this varies due to individual device thread load.
This is the logic that handles the autofocus on mount on native platforms, see code block.
What changes do you think we should make in order to solve the problem?
Within the native specific code block mentioned above we can observe that we already have logic implemented to delay the focusing on mount via shouldDelayFocus.
So within the HoldReasonPage we should pass shouldDelayFocus as true to the input component here, under / above the existing autoFocus prop.
Since this alone would still not show the keyboard 100% of the time (depending on individual device thread load), I suggest wrapping the focus call from within the existing shouldDelayFocus timeout with InteractionManager.runAfterInteractions - this way besides the timeout's 300ms delay, we add the interactions delay too. This ensures the keyboard will show 100% of the time.
Changed code:
if (shouldDelayFocus) {
    const focusTimeout = setTimeout(() => {
        InteractionManager.runAfterInteractions(() => input.current?.focus()); // <- this line
    }, CONST.ANIMATED_TRANSITION);
    return () => clearTimeout(focusTimeout);
}

Videos

Android: Native

Before
After

Even if we cannot reproduce this in prod, since we still can get the keyboard to show up, because of this I will remove the deploy blocker label.

yup, @Krishna2323 proposed first here

Ah sorry I just completed review. It was weekly and @Krishna2323 bumped me on slack so I already planned review today

I understand why this was marked as deploy blocker.
On both staging and prod, sometimes keyboard shows and sometimes not, even on same device.
Mostly auto focus doesn't work in android without timeout. Maybe it accidentally worked when QA team tested on production app.

I agree that @neonbhai's solution goes by the docs, but in this case the TextInput shouldDelayFocus logic doesn't work as expected because of the navigation transition delay and I think fixing that as suggested by my proposal here is a more holistic approach instead of using the  useAutoFocusInput hook in every component where the issue occurs.
What do you guys think ?
cc @rlinoz @ishpaul777 @situchan

@ikevin127 useAutoFocusInput is not using TextInput shouldDelayFocus logic at all.
The solution is actually combined with autoFocus prop removal.

useFocusEffect approach is what we already discussed and landed on - https://expensify.slack.com/archives/C01GTK53T8Q/p1694660990479979
If you have better approach, please raise discussion on slack and get votes.

I think we should hold this in favor of https://github.com/Expensify/App/issues/36948 since the proposal was first posted there.
Do you agree @situchan @ishpaul777 ?

Production video
https://github.com/Expensify/App/assets/115492554/686f54d3-ca15-4f1e-bf17-240e03e638ae

Moving to weekly since it is on HOLD

PR of the other issue is in draft.

PR of the other issue is in draft.

Other PR is deployed and fixed this one as expected, so closing.


bug: Focus is not getting trapped for alert dialogue using talkback in ionic 5

We using ionic 5 and we noticed that on the alert dialogue while navigating using Talkback, talkback focus does not get trapped on the alert, and instead it goes behind the dialogue if the user swipes forward. this seems to be fixed in ionic 3 but not ionic 5. here is the PR #11543
Will look forward to the response.

Thanks for the issue. Please update to the latest version of Ionic Framework. This was fixed in Ionic Framework v5.1.0.

Thanks for the reply, upgrading ionic version didn't work for us, the focus is still not getting trapped on alert dialogue, we have created the project using ionic and Vue, upgrading to the new version should also work for us?

We are still working on Ionic Vue, so this fix should be available in the next beta. We were waiting for the Vue 3 API to become stable before continuing to work on it. Now that it is stable, we are continuing development on Ionic Vue.

Thanks again for informing, could you please help with the timelines of the next beta as in when it is out? just so I can inform my team and look forward to the fix?

Hi Liam, I also checked the alert which is part of the core (ionic 5) I believe, and focus is not getting trapped here as well for the talk back, attached is the screenshot for reference.

Hi @liamdebeasi, have u had the chance to check the above comment? we need to know if these issues can get fixed at the framework level as writing code explicitly can cause issues later when we upgrade to newer versions.

The issue was fixed in a recent version of Ionic Framework, but the docs demo you linked to is using an outdated version.
As for Ionic Vue, we are working on it right now, and hope to have a release candidate in the next few months. We do not recommend using the old betas of Ionic Vue in production.

Hi @liamdebeasi, thank you for the clarification, could you please share the latest docs demo version? so we can test and implement them accordingly. Thanks again!

The latest version is Ionic Framework v5.2.2.
You can install using npm install @ionic/angular@latest if using Angular of npm install @ionic/react@latest @ionic/react-router@latest if using React.

Hi @liamdebeasi, We upgraded our core to the latest (V5.2.2) as you mentioned and tested with talk back but the focus is still not getting trapped in the alert dialogue and goes behind the modal dialogue if u swipe forward, I think this is because there is no aria-hidden given to the parent window once the modal dialogue is opened,  I also tested few apps that are featured on the ionic website like Sworkit, JustWatch and untapped and noticed that focus goes behind the modal, as it will be a blocker for us could you please help?

Can you please provide a repo I can use to reproduce the issue?

Hi @liamdebeasi, I have attached a zip, let me know if u can run talkback (Android screen reader) after extracting the files from the zip, as I am new to all ionic and JS frameworks, I created this small project by learning from a Udemy course and have also updated the ionic core to latest 5.2.3, below are the steps to reproduce:

Launch the app
turn on the talkback (from settings>accessibility>talkback )
navigate to any of the two recipes using talkback (by swiping right on the screen)
double-tap to go inside any of the recipes
Navigate to the delete icon and double-tap to activate the alert.
once the alert is triggered, navigate to the delete button by swiping right
when the talkback focus is on the delete button, keep swiping right, after two or three swipes talkback focus will go behind the alert.

I couldn't reproduce this in the browser with the latest Ionic core, checked with NVDA as talkback is only for Android, however, it is reproducible in devices. Let me know if u are able to reproduce and thanks in advance.
Ionic+talkback-issue.zip

Thanks! Another person reported this as well, so I made a PR that fixes this here: https://github.com/ionic-team/ionic-framework/pull/21716

I face same issue again in new version of ionic 5.27.0


New version: Alibaba.DingTalk version 7.6.0-Release.70310805

Created by 🥟 Dumplings in workflow run #6336.

Log
下载源
https://alidocs.dingtalk.com/i/p/Y7kmbokZp3pgGLq2/docs/gXMGnr6AkOP814d6rvOmJybeZRxlzopj
Updated: 7.6.0-Release.62810810 → 7.6.0-Release.70310805
Submitting WinGet manifests
Creating manifests
Uploading manifests and making commits
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

/azp run

https://github.com/microsoft/winget-pkgs/issues/142854


confusion about MultiBoxTarget

Hi , I have a question about MultiBoxTarget layer.
Why ssd uses MultiBoxTarget layer to do things like assigning positive and negative samples?
I think these processings could be done when making a dataset, because all the default boxes are fixed, so I might just match these default boxes to image's ground truth bounding box. This way would save a lot of time during training.
Is there anything wrong with this idea?

refer to the paper about data augmentation.

Ground-truths changing all the time after augmentation. So it's better to put that into layers.

@nopattern @zhreshold Thank you very much! I get it.


feat: stateful environment script

environment.sh is not being actively used since the JS based CLI version is out.
The logic can be used still to carry out other specific use-cases that the JS CLI do not support because that is tailored to operate with pre-built, stateless images.
This PR allows to run any bee image with the environment.sh if one changes the .commit-version-tag to the version that they built and execute
export COMMIT_VERSION_TAG=true && export BUILD_IMAGE=true && ./scripts/environment.sh start
it will retain the data generated by the bee clients in the bee-data-dirs folder.
Next time when the environment starts with another bee images (after changing the .commit-version-tag), it will remember all uploaded files and other states.

Release v2.2.0 addresses this.


cmd/cover: use different //line comment for code that does not come from source file

What version of Go are you using (go version)?
go version go1.10.1 darwin/amd64
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GORACE=""
GOTMPDIR=""
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/m6/vs051rl54k3_sgxr94ylcz5h0000gn/T/go-build238749509=/tmp/go-build -gno-record-gcc-switches -fno-common"
What did you do?
git clone git@github.com:linzhp/go_examples.git
cd go_examples/hyphen
go tool cover -mode set -var Var_power-driven -o power-driven-gen.go power-driven.go
go run main.go

What did you expect to see?
An error pointing to the right line of power-driven-gen.go
What did you see instead?
power-driven.go:7:14: expected ';', found '-'
However, power-driven.go has less than 7 lines.

The go/parser package is working correctly.  The error occurs in new code added by the cover tool.  The cover tool should add a new //line comment for that code, so that it does not get misattributed to the original file.
In this case the bug is, of course, using a -var option with a name that is not a valid Go identifier.  The cover tool could perhaps check for that too.

Hey @ianlancetaylor, I would like to start contributing to Go. I would be interested in working on this if that's OK for you. What do you think?

@nodo Sure, thanks.

Thanks @nodo

@ianlancetaylor I have started to look at the issue and I have a couple of doubts.
In order to check that the string passed using -var is a valid Go identifier I considered using https://golang.org/pkg/go/scanner and if the output of the scanner is exactly one identifier. Then the option is valid. This check could be implemented in the parseFlags function.
Another possibility would be to match the string against a regex that matches https://golang.org/ref/spec#Identifiers.
What do you think about these solutions?  Are there other options?

@nodo A valid Go identifier is defined by the language spec at https://golang.org/ref/spec#Identifiers.  It's easy enough to write a function for that, something like:
first := true
for _, c := range ident {
    if !unicode.IsLetter(c) && c != '_' && (first || !unicode.IsDigit(c)) {
        return false // invalid identifier
    }
    first = false
}

Awesome! Thanks @ianlancetaylor , I will continue that way.

@ianlancetaylor  I have added a first CL with the check that the argument of -var is a valid go identifier. WDYT?


Output of lint step in product build not handled correctly

Summary
In the prepare-build job, the lint dockerfiles step fails without showing the actual error even though corresponding logs were added to the hadolint script. Despite facing an actual lint error in the Dockerfile, the show dockerfile lint error step is just omitted. This can be seen in the screenshot below:

Expected Behavior
We would expect to see more logs in the lint step and especially the show dockerfile lint error should never be omitted if errors occur.
Corresponding Github Action: https://github.com/datavisyn/github-workflows/tree/new_deployment/.github/actions/lint-docker

https://github.com/datavisyn/github-workflows/pull/34


Update zcl_excel_converter.clas.abap

Converting an ALV table that includes a color column failed because deep tables are not supported. The check that was addes prevents an error.

Hi @K-Wagner,
is there any sample report that could be adjusted to replicate this issue first and then use your correction?

I've tried to reproduce the error using ZDEMO_EXCEL32. When run interactively the color column is excluded in ZCL_EXCEL_COMMON~DESCRIBE_STRUCTURE, no problem there. I recalled I wanted to reproduce Excel files in batch mode also using an ALV Layout. There the problem begins. I enhanced ZDEMO_EXCEL32 to produce the output also when called from ZDEMO_EXCEL. Right now the color information is missing. Also there is made no column selection based on an ALV layout. Working on that.

#781 was merged and resulted in some conflicts, sorry for the inconvenience.

Hi @K-Wagner. I tried to reproduce but couldn't understand what problem you exactly faced. If I run the demo program you have proposed, I don't see any failure. The catalog returned by SALV in my 7.52 version doesn't contain the COLOR_CELL table type component you have added to contain the colors of cells. To continue the discussion, could you create an issue with details about how to reproduce? Thank you.


Update Composer dependencies (2021-10-05-00-11)

Visual regression test passed!
View the visual regression test report


update release notes for 3.5

Description
Some notes about the release, yo.
Issues Resolved
... The lack of release notes? Note to selves: we need to get better at including that "RELEASE_NOTES.md has been updated" item from the PR check list during review.
Check List

~New functionality includes tests~
[x] All tests pass
[x] RELEASE_NOTES.md has been updated
[x] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

So many thumbs!


notifiers key was missing

Without "notifiers" in the provisioning file for notifications the grafana service could not start anymore.
Tested with Grafana v8.1.3.
Error:
"[root@ ansible]# journalctl -u grafana-server.service -f
-- Logs begin at Fri 2022-03-04 12:20:13 CET. --
Mar 30 15:30:57  grafana-server[946630]: service init failed: Alert notification provisioning error: yaml: line 1: did not find expected key
"

This role has been deprecated in favor of a the grafana-ansible-collection collection.


unicode-10.0.0 has a Block named "undefined"

From https://github.com/slevithan/xregexp/pull/221#pullrequestreview-97394129
require('unicode-10.0.0').Block[273]
// -> 'undefined'

I looked into this a bit, and found that at this line in parseBlocks unicode-loose-match seems to be unable to handle an item argument of "Syriac_Supplement". I'll probably open an issue there.

This should be fixed now.

Thanks! Has there been a unicode-10.0.0 release with the fix? I don't see it on npm

Good catch<EMAIL_ADDRESS>is now up.

Cheers!


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative/operations-wg-leads
/assign knative/operations-wg-leads
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/eventing abe0a57...91e8838:
  > 91e8838 use latest ce SDK (# 6557)
  > 57eb56d upgrade to latest dependencies (# 6556)
bumping knative.dev/pkg 7c4fef1...158538c:
  > 158538c upgrade to latest dependencies (# 2603)
bumping knative.dev/caching fba49b7...969cafb:
  > 969cafb upgrade to latest dependencies (# 687)

/test build-tests


The type or namespace name 'HttpRequestResult' could not be found MicrosoftPassport

Noob here: Im seeing these two errrors on a fresh install of vs2017, and cant figure out what to do. Can anyone help?

The master branch requires the latest SDK, which is 18362. I bet you are using 17763.
I'm surprised Visual Studio didn't warn you about this. The project is marked
    <TargetPlatformVersion>10.0.18362.0</TargetPlatformVersion>
    <TargetPlatformMinVersion>10.0.18362.0</TargetPlatformMinVersion>


Add Aether wood signs

Adds signs for each aether wood variant.
Everything works, except that they don't render.
Currently all the sign items look like acacia signs and all the sign blocks have the oak sign texture.
Any help would be much appreciated :)
Solly says he's got the fix

I'm not at my computer right now, but when I am, I'll check if this works


Platform AccessoryInformation

Is the AccessoryInformation for a platform changeable? I didnt find any code hints on how to do this. Currently only "Defautl-xxx" ist displayed.

same question...

Yes, example: https://github.com/snowdd1/homebridge-knx/blob/v0.3.10/lib/knxdevice.js#L73
You'll need this service for each accessory.

thanks for you response @snowdd1 , I will try it later, hopefully it will work 😄

@benzman81 @snowdd1
Thanks for your support, I know how to config AccessoryInformation for a accessory in homebridge plugin, my question is how to config manufacturer/model/serialNumber for entire home(which mean config these info of bridge).
As read the source code in here, I found how to config,
Just add some field in config.json in .homebridge folder:
"bridge": {
"manufacturer": "Realank",
"model": "HomeV1",
"serialNumber": "001",
"name": "realank homee",
"username": "CC:22:3D:E3:CE:22",
"port": 51810,
"pin": "xxx-xx-xxx"
},

@Realank You want to change the information for the bridge itself?
As you can see here https://github.com/nfarina/homebridge/blob/v0.4.10/lib/server.js#L97 the bridge section of config.json supports the attributes

manufacturer
model
serialNumber

However, that info will only show in Home app if you look at the details of the bridge itself - as the bridge has no user functionality, most user will put it somewhere hidden (I created a virtual room "system devices" for all things that have no user value for my family. So just curious, what are you going to do with it?

@snowdd1 yeah, bridge has no user functionality, it represents home(or room) in our Home App. It's useless, I just don't want to see "Default -xxx" at the details of the bridge 😜