feat(op, fs): :sparkles: Intergated statx into monoio

Add statx support for monoio
Add Statx<T>  struct to support Op, just implement for SharedFd and CString to support different use cases.
So there are two types: FdStatx and PathStatx, both of them are implement OpAble Trait.
Currently, they can work on linux with iouring and legacy feature, and not support macos and windows, due to these two platforms don't have the statx syscall, it may use the stat syscall and transform the result to the statx
Also, to test the Statx<T> work correctly, I add some new struct to fs module like Metadata, Permissions and FileType.
There is another reason to add these struct, I can't transform the statx struct to the Metadata and other types in std::fs.
So these struct provide nearly the same API like std::fs's
I also add some basic test in tests dir.
Currently, all these changes above only work on linux

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

#267

It seems test failed for i686 and aarch64...

the problem in aarch64 may fixed, but the i686's i don't know why this would happen, maybe disable the statx in i686?

the error happen due to the cross's bug, i have test in newest cross version, it works fine.

and the run.sh is
#!/bin/bash

# Define the list of architectures to test
architectures=(
    "x86_64-unknown-linux-gnu"
    "i686-unknown-linux-gnu"
    "aarch64-unknown-linux-gnu"
    "armv7-unknown-linux-gnueabihf"
    "riscv64gc-unknown-linux-gnu"
    "s390x-unknown-linux-gnu"

    "x86_64-apple-darwin"
    "aarch64-apple-darwin"
)

# Loop through each architecture and run the tests
for arch in "${architectures[@]}"; do

    cross test --lib --bins --tests --target "$arch" --no-default-features --features "async-cancel,bytes,legacy,macros,utils" > /dev/null 2>&1

    if [ $? -eq 0 ]; then
        echo "Success for $arch"
    else
        echo "Failure for $arch"
    fi
done

the failure of riscv is #1423


2way SSL is not supported

Hi Team,
I greatly like your product; which to our need. We appreciate your effort for making it open source. But we found that MBTest doesn't support 2-way-ssl.
B'coz of this we are not able to do virtualize any of our backend service in Cap1. Hope you will provide a fix for this which will enable us to use the tool smoothly.

It supports.


Question - JSON Support

Details
Great library! We understand JSON is not yet supported in the way it is in Python.
However, do you know if there is a workaround to create a Document that can interpret it as-is?
  var jsonData = {
    "macros": [
      {
        "value": "Hey, ABC...",
        "title": "ABC"
      },
      {
        "value": "Hey, DEF...",
        "title": "DEF"
      },
    ...}

    const nodes = getNodesFromDocument(
      new Document({ text: jsonData }),  // tried jsonData.toString()
      new SentenceSplitter(1024, 20),
    );

    const nodesWithEmbeddings = await VectorStoreIndex.getNodeEmbeddingResults(
      nodes,
      serviceContextFromDefaults(),
      true,
    );

   ...

   const query = "Answer only with the macro value I should use to reply to this text: ...";
   const result = await queryEngine.query(query);

The answer is pretty much always: { "reply": "macro_1" }. When converted to text, such as "Macro: Hey, ABC.\nMacro: Hey, DEF.", it works fine. Can we assume the sourceNodes' metadataSeparator is the culprit here? It seems to work on the playground demo though.
Cheers,

Checklist

[X] packages/core/src/JsonDocument.ts

Define a new class JsonDocument that extends the Document class.
• In the constructor, take a JSON object as input and store it in a suitable format.
• Override the necessary methods of the Document class to handle JSON data.

[X] packages/core/src/NodeParser.ts

Modify the getNodesFromDocument function to check if the document is an instance of JsonDocument.
• If it is, parse the JSON data and generate nodes accordingly.

[X] packages/core/src/ResponseSynthesizer.ts

Modify the synthesize method to handle nodes generated from JSON data.

[X] packages/core/src/indices/list/ListIndex.ts

Modify the fromDocuments method to handle documents that are instances of JsonDocument.

[ ] packages/core/src/OutputParser.ts

Modify the parse and format methods of the SubQuestionOutputParser class to handle output related to JSON data.

Try JSON.stringify(jsonData, null, 2) and see if it does better.
In general, JSON will perform worse on embedding search performance, so if you can convert to text I would do so. Happy to discuss this further as this is an area that I've looked into quite a bit.


Aghosts Can't See Radio Keys In Strip Menu

Description
Aghost are unable to check a radio's encryption keys while on a person in the strip menu. Makes admining around it difficult.
Screenshots

This was fixed at some point.


More 'splitscroll' problems

Problem:    'scroll' is not updated when resizing windows, alloc error due to unitialized window size in terminal communication?
Solution:   Update 'scroll' in win_fix_scroll(), revert win_init_size() relocation in main.c and update prev_height for gui instead. (closes https://github.com/vim/vim/issues/11123, https://github.com/vim/vim/issues/11119)
This was being skipped for cases where scroll_to_fraction was not used in win_fix_scroll/cursor. Might be able to refactor this such that is only called when we do not scroll_to_fraction in either win_fix_scroll or win_fix cursor but it seems an inexpensive function so I'm not sure we care enough to? Does this need a test? Seems trivial.

There are easy repro steps thus it should be easy to add a regression test.

There are easy repro steps thus it should be easy to add a regression test.

Sure, easy enough. I just thought it might have been redundant as it is basically just testing win_comp_scroll which I assume is tested elsewhere. Gave up on the suggested refactor I mentioned in https://github.com/vim/vim/issues/11123#issuecomment-1245710418. Didn't work correctly for win_close control flow.

Just to be sure; this should fix both outstanding issues and is ready to be merged as far as I'm concerned.

There are easy repro steps thus it should be easy to add a regression test.

Sure, easy enough. I just thought it might have been redundant as it
is basically just testing win_comp_scroll which I assume is tested
elsewhere. Gave up on the suggested refactor I mentioned in
https://github.com/vim/vim/issues/11123#issuecomment-1245710418.
Didn't work correctly for win_close control flow.

There probably is some testing, but since the combination of features
and user actions is infinite there is never 100% coverage.  If someone
ran into a problem and reported it, it's always good to add a test for
that specific situation, since someone was doing that.  Ideally we might
think "if this fails, then perhaps that fails too?" and add a few
related tests.  But it's quite often already more work to write a test
than to fix the problem, therefore we are flexible.
--
Q: Should I clean my house or work on Vim?
A: Whatever contains more bugs.
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Included with patch 9.0.0461


[vim9] super became a keyword only word

Steps to reproduce
E1356: "super" must be followed by a dot
E1105: Cannot convert class to string
vim9script

def Foo(super: bool)
	echom 'foo: ' .. super
enddef

defcompile

Expected behaviour
expected no err
Version of Vim
v9.0.1623
Environment
linux
Logs and stack traces
No response

"super" is a reserved word now.  It's commonly used in languages using inheritance.
Not using it would cause greater problems.  The error messages could be clearer though.

"super" is a reserved word now.  It's commonly used in languages using inheritance.
Not using it would cause greater problems.  The error messages could be clearer though.

but it would not raise err if using 'this/silent/class'
// though we can try to avoid using keyword in script..
--
shane.xb.qian

now (your last patch) i saw 'this' and 'super' became a real keyword (e1034) now. :smile:
// ok, if this is the best choice for now.


Czech localization

I've prepared czech localization for your tool.

Awesome, thanks!

https://www.nuget.org/packages/Gu.Wpf.NumericInput?NormalizedVersion=0.5.2


Added or improved documentation to a few more String methods

Includes bigrams(), chr(), similarity(), is_valid_int(), is_valid_float(), is_valid_identifier()

Thanks!

Cherry-picked for 3.5.

Cherry-picked for 3.4.4.

It took me this long to realize that the line print("24".is_valid_float()) # Prints "true" is repeated twice...


Secure Practice MailRisk Update package

Required items, please complete
Change(s):

Update package

Reason for Change(s):

Update Solutions package with latest changes

Testing Completed:

yes

Checked that the validations are passing and have addressed any issues that are present:

yes

Hi @ingin97, please add Solution_SecurePracticeMailRisk.json from Solutions\MailRisk\Data.
Also package this solution with 2.0.1 version as 2.0.0 already exist. Thanks

Hi @v-rbajaj, the version number is now changed as requested.


New workflow submission for Checkout Processing System

To submit a workflow to the Step Functions Workflows Collection, submit an issue with the following information.
To learn more about submitting a workflow, read the publishing guidelines page.

Use the model template located at https://github.com/aws-samples/step-functions-workflows-collection/tree/main/_workflow_model to set up a README, template and any associated code.

All the information below must be provided in the "example-workflow.json" file cloned from the model **

Note the following information for the model:

Description: The example implements a checkout processing workflow that simulates a series of steps that an order must go through before notifying the result to the user.

Simplicity: 2 -  Pattern

Diagram: /resources/workflow_diagram.png

Type: Standard

Resources should link to AWS documentation and AWS blogs related to the post (1-5 maximum).

Framework: SAM

Author bio may include a LinkedIn and/or Twitter reference and a 1-sentence bio:
Jing Xiang is a Solutions Architect at AWS based in Singapore. Linkedin: www.linkedin.com/in/jing-xiang-peh

You must ensure that the sections of the model README.md are completed in full.
PR #284

merged


Failed to clone nvm repo

#Operating system and version:
Windows 10
Using CygWin
How did you install nvm?

I wasn't able to install using the curl command.
Here's the transcript:
$ curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.2/install.sh | bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 13527  100 13527    0     0  13527      0  0:00:01 --:--:--  0:00:01 48138
=> Downloading nvm from git to '/cygdrive/c/MikesStuff/Pers/Dropbox/Personal/home/.nvm'
=> Cloning into '/cygdrive/c/MikesStuff/Pers/Dropbox/Personal/home/.nvm'...
remote: Enumerating objects: 288, done.
remote: Counting objects: 100% (288/288), done.
remote: Compressing objects: 100% (258/258), done.
Receiving objects:  87% (251/288)sed 95 (delta 18), pack-reused 0Receiving objects:  8
Receiving objects: 100% (288/288), 146.70 KiB | 2.72 MiB/s, done.
Resolving deltas: 100% (35/35), done.
error: invalid path 'test/fast/Aliases/"nvm alias" should not accept aliases with slashes'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

Failed to clone nvm repo. Please report this!

For the install debugging step, here's what I got:
$ curl -I --compressed -v https://nodejs.org/dist/
curl: option --compressed: the installed libcurl version doesn't support this
curl: try 'curl --help' for more information

Duplicate of #1643.
either way, nvm does not work on non-WSL Windows, because it requires POSIX.

I dowloaded this zip from this link and Voilá worked fine.
https://content.breatheco.de/en/how-to/nvm-install-windows#:~:text=Install nvm Go to your,that you will hit too.
Saludos!

I dowloaded this zip from this link and Voilá worked fine. https://content.breatheco.de/en/how-to/nvm-install-windows#:~:text=Install nvm Go to your,that you will hit too.
Saludos!

This Is correct!!!! I appreciate it!!!

@elmulix that's nvm-windows, a different project.


[Storage] add ability to update version of logging for storage services

Change is needed to support changes in displaying diagnostics logs, in new versions (newest, 2.0).
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

Is this closing an open issue?

@tjprescott it is not


[Feature]: Improve sdk-vue docs

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
I would like to collect some improvements/fixes for @telegram-apps/sdk-vue docs page. Then I'll contribute.
Describe alternatives you've considered
No response
Additional context
No response

@heyqbnk , hi! Could you please assign that issue to me 😄


fix: search

Fix search.

Would prefer to use #1030

Would prefer to use https://github.com/kyverno/website/pull/1030

Didn't see this PR. When is this going to land ?

When he gets some time to fix a few remaining items.

Ok, added to the agenda for tomorrow meeting.

/cherry-pick release-1-11-0


Fit can fail if 0s in array as well as NaNs

Quick fix, ODR fit can fail if there are 0s in the array (since error will also be 0)

thanks!


Implementing File Node

This node is going to upload a file directly into Pagenodes.  It should allow you to upload a file and then in future versions send through p2p, or load into a CSV/XML parser.
Currently WIP

This should be sending the object now, I'm trying to think of a clever way to test its actually being sent.

This should be sending a base64 encoded package at this point.  I took the character escaping out.


Fix/handle multiple classes in same files correctly

Hi @aconrad
I try to continue on PR #113 here, as @smortvedt did not yet reply and may have lost interest in the project.
As a first, I just merged in his changes into my master and put it into a new branch.

Hi @aconrad
Also this is ready for review, unfortunately Python 3.8 and Python 3.9 are still red, albeit the diff is small, that might give an easier indication what is different in Python 3.8 and 3.9...

Hi @aconrad
Also this is ready for review, unfortunately Python 3.8 and Python 3.9 are still red, albeit the diff is small, that might give an easier indication what is different in Python 3.8 and 3.9...

Do you have both py37 and py38/py39 installed? The generated coverage files for each interpreters might be worth looking at. I'm not in front of my laptop but if you were to upload the files in a new GitHub issue that would be great so we can take a look at what is different. Do you think you can do that?


Question about c# windows application

Hello, I am trying to create a windows form application using c#. I am able to get the example located in SpotifyAPI.Web.Example working perfectly. However, I am unable to run windows forms while the console is open. Is their a way to keep the console open in the background while using windows forms to call the spotify API? or is their another way I should be doing this?
thanks.

solved


fix: Escape user controlled input

Fixes #162
This should escape all needed user controlled inputs.

Nice job, I hadn't thought about it while i had already used this function :smile:

Would you be amenable to an option to turn off the escaping of custom module output? I've been relying on a custom module that returns markup with changing background and foreground colors based on machine state.
If you'd be amenable to this option I'm happy to work on a PR for it.

@mnussbaum This change wouldn't be hard to implement.
On the otherhand it may be better to apply an css class if you don't have to many states. For an example you can look in my dotfiles (This module and This Style).
If it's not suitable I happily make the change :)


strict mode: missing type "object" for keyword "required" at "#" (strictTypes)

What version of Ajv are you using? Does the issue happen if you use the latest version?
8.1
Ajv options object

    const ajv = new Ajv({ allErrors: true })

JSON Schema
Its a small extraction  - I have left out the full properties..

{
      required: ["PoolConfig"],
      properties: {
        PoolConfig: {
          type: "object",
          required: [
            "address",
            "coinbaseString",

The error that is displayed is
strict mode: missing type "object" for keyword "required" at "#" (strictTypes)

It doesn't stop it from working.
But the "required" is there, I should not disable strict mode, right ?

The problem is that type: "object" is absent, so the data can be any JSON type.

From the documentation, the solution is to add type: "object", to your schema root object:
This simple JSON Schema is valid, but it violates strictTypes:
{
  properties: {
    foo: {type: "number"},
    bar: {type: "string"}
  }
  required: ["foo", "bar"]
}

This is a very common mistake that even people experienced with JSON Schema often make - the problem here is that any value that is not an object would be valid against this schema - this is rarely intentional.
To fix it, "type" keyword has to be added:
{
  type: "object",
  properties: {
    foo: {type: "number"},
    bar: {type: "string"}
  },
  required: ["foo", "bar"]
}


⚠ ClamAV has degraded performance

In 6135542, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 605 ms

Resolved: ClamAV performance has improved in ad01b7b.


Columnar layout padding

The full-width columnar appears a bit off in terms of layout. I see padding-top: 100px; and too little padding between h3 and the next block.

Fixed via #299


Corrected punctuation, spelling, and grammatical errors.

Minor errors; just needed a bit of polishing.

Thanks, son.


At the first start "btoa is not defined"

When you running your nuxt application at the first time, get error: [Vue warn]: Error in beforeCreate hook: "ReferenceError: btoa is not defined"
After save any component - the error disappears.

BTW, my package didn't use btoa. I am not sure about this warning

BTW, my package didn't use btoa. I am not sure about this warning

Yep, me too. But If I don't used plugin this error dissapear.
` [Vue warn]: Error in beforeCreate hook: "ReferenceError: btoa is not defined"                                                                                09:57:11
found in
--->
 at components/Common/ModalsWindows/index.vue
 at layouts/default.vue
`
It is full error message

are you using Nuxt or just Vue? which version?

I'm using nuxt version 2.15.3

solution : wrapped with  (previously no-ssr)

yes for Nuxt you need to wrap it https://initbase.github.io/vue-modal-2/installation/vue-2x.html#nuxt


Volume declaration missing in v0.3.3 install routine

Describe the bug
While running the v0.3.3 install procedure, an error occurs, that a docker compose volume declaration is missing.
To Reproduce
Steps to reproduce the behavior:
See screenshots
Expected behavior
The install procedure should run through successfully.
Screenshots

System information (please complete the following):

OS: Linux
Install script using image version v0.3.3

Additional context
As discussed in Slack: https://fonoster.slack.com/archives/C01C7NHQJVD/p1645686814273269

@baflo
Thanks for reporting the issue. We finished triaging this and confirm it as a bug. We are currently testing a fix, and hope to have a patch by the end of the week.

@baflo
I merged a fix that solves this issue. Find here examples of use. I'm closing this as solved, but feel free to reopen if needed.


Update to build with Zig 0.11.0-dev.86+b83e4d965

It's mostly API changes

Thank you! I really appreciate it since I was thinking of how annoying it was going to be to learn the breaking changes.


The implementation of ID Loss seems different from the original paper

At first, thank you for your nice work, it helped me a lot!
But when I was reading your code, I found a problem: in the original paper, id loss is calculated by the cos similarity, while in this implementation, it's calculated by bmm or inner product.
Would like to know the reason why change cosine loss to bmm,  and the influence on the final result. much appreciate it if you would reply.

I changed the id loss to the cosine format, and this improved the model performance in my experiments.

Hi, the cosine similarity of two unit vectors is equal to the inner product. In my code, I used bmm to implement the inner product.
I recommend you to read paper and code about Arcface, which faceshifter used for identity encoder.


Can't turn off the requirement for givenName on register

Maybe I'm doing something really dumb, but I've spent some time banging my head against this and can't get it to work.
I'm trying to present a reg form that requires simply Username, Email, and Password. But when I try and register, the form comes back with the alert, "Account givenName cannot be null, empty, or blank."
In my code I have:
app.use(stormPath.init(app, {
    // ...
    enableUsername: true,
    requireUsername: true,
    enableGivenName: false,
    requireGivenName: false,
    enableSurname: false,
    requireSurname: false,
    // ...
}));

I've added some debug output to the helpers.collectFormErrors function but that doesn't seem to be where the alert is coming from. It's almost as if the validation is failing over at the stormpath server.
Thanks for any advice!
bobby

Arg!  Let's see if we can figure this out.  Are you using the default login page, or a custom one?

Working on this now. This is a confirmed bug =)

Going to start by adding a test for the registration controller to assert these guys. Right now there are no controller tests yet, so might take a little bit.

Bam, this is now fixed and released.


Support shared libraries

Are there plans to support reading from multiple BBT or JSON library files? I work on several group libraries (one per project).

It makes sense to support group libraries. The only non-trivial thing is to deal zotero items that appear in multiple libraries, since the the plugin currently assumes that a MD file should point is a single zotero item. That constraint exists mostly because it protects against configuration mistakes. I'll think about a user-friendly way to keep the configuration guardrails while also allowing for duplicate zotero items. But in the mean time, I might start by adding an advanced option to relax the constraint so that you can use your group libraries.

It does support group library exports already: I can easily export any group library into a bib/json file and link it under the Citations database path.
My proposed enhancement is to allow multiple bib/json files, so that users could cite content from multiple bib/json files (i.e., multiple libraries).
Conflicts (i.e., same citation key) could be resolved by keeping the largest or most recent entry.

I can use exports from group libraries now. The point is to support multiple of them. Conflicts could be maybe handled by picking the biggest or most up to date one given the same cite key? 😉
Sent from my iPhone

On 19 Apr 2022, at 18:49, Dae @.***> wrote:

It makes sense to support group libraries. The only non-trivial thing is to deal zotero items that appear in multiple libraries, since the the plugin currently assumes that a MD file should point is a single zotero item. That constraint exists mostly because it protects against configuration mistakes. I'll think about a user-friendly way to keep the configuration guardrails while also allowing for duplicate zotero items. But in the mean time, I might start by adding an advanced option to relax the constraint so that you can use your group libraries.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.


Problem with datetime format

Problem statement
I tried to send request to get server time, but i get zero time. I have similar code, that works with usual string, and this code works well, but with strfmt.datetime I have problem . As I can see, server send payload with right time, but client receive zero time. Can you help me to find problem?
Or maybe you can give example, how to work with strfmt.datetime.
My code:
Server:
configure_api.go:
api.GetTimeHandler = operations.GetTimeHandlerFunc(func(params operations.GetTimeParams) middleware.Responder {
		t := models.Datetime(time.Now())
		fmt.Printf("Server time %v \n", time.Time(t).String())
		return operations.NewGetTimeOK().WithPayload(t)
	})

Client:
type Client struct {
	http *apiclient.ConfgenSwagger
}
func (c *Client) GetTime() (models.Datetime, error) {
	p := operations.NewGetTimeParams()
	resp, err := c.http.Operations.GetTime(p)
        if err != nil {
		fmt.Printf("Client time error  \n")
		return resp.Payload, err
	}
	t := resp.Payload
	fmt.Printf("Client time %v \n", time.Time(t).String())
	return t, err
}

I get next results:
Server time 2017-06-29 17:07:26.956884177 +0300 MSK
Client time 0001-01-01 00:00:00 +0000 UTC

Swagger specification
...
datetime:
    type: string
    format: date-time
paths:
  /time:
    get:
      description: get server time
      operationId: getTime
      responses:
        '200':
          description: getTime success
          schema:
            $ref: "#/definitions/datetime"
        default:
          description : getTime error
          schema:
            $ref: "#/definitions/error"

Environment
swagger version: 0.9.0
go version: 1.5.3

It seems like that client and server never use functions MarshalJSON and UnmarshalJSON from go-openapi/strfmt/time.go.

I think, I found the reason of bug.
When we call ProducerFunc from /go-openapi/runtime/json.go ,then  data interface{} has type Model.Datetime ( type, that is generated by goswagger). But this type has not methods like MarshalJSON. So it can not make right JSON.
But Model.Datetime is just redefinition of type strfmt.DateTime, that has such methods.
So we have two possible ways of solution of problem:
1)Add automatic generation of methods like MarshalJSON for generated types
func (t Datetime) MarshalJSON() ([]byte, error) {
	return strfmt.DateTime(t).MarshalJSON()
}

Convert type Model.Datetime to strfmt.DateTime before it falls into ProducerFunc

it implementes the TextMarshaller which the json marshalling should make use of.

I stepped on that too when handling default or enum values.
The type aliasing cuts any call to the unmarshalling methods made available by the strfmt type.
I believe we should generate the MarshallJSON method for all situations where the type is aliased to a strfmt type which is not a string alias (currently these are: Date, DateTime, Duration, ObjectID).

ok I started a small PR on this which fixes this annoyance. test is ongoing.
@casualjim do you think we should add the [Un]MarshalBinary interface as well for these simple type redefinitions? (I could never catch what was the use case for these)

Fixed with #1420


fix(TDI-38860):Unable to save table metadata from Repository Azure

connection.
What is the current behavior? (You can also link to an open issue here)
https://jira.talendforge.org/browse/TDI-38860
What is the new behavior?
Please check if the PR fulfills these requirements

[ ] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Pull request test result: success :star:


Make session timeout a fatal error

Session timeouts can happen if a user is idle too long or when we
perform certain types of App Inventor updates. Without this change, the
standard red error bar is produced. However many users appear to ignore
this error and keep working, but this work will never be saved!
This patch instead provides a dialog box that requires them to reload
their browser. The reload should not only refresh their session, but
should load any new App Inventor client side code. There is a risk that
up to 30 seconds of work may be lost when this dialog appears (most
people might lose only 5 seconds, but the risk is up to 30 due to the
way the auto-save code operates).
Change-Id: I4301e6dbdef0c52681b90ede4b8d84d6f9445d97

@afmckinney Please review. Not only do I want to put this in master, but I'll cherry-pick it onto the current release branch and deploy it hopefully on Monday. This will facilitate the component release on Wednesday by providing a way for people to reload into the new code instead of getting "red bar" errors after the release.


Fix the error which caused TEMPUS_DOMINUS_INCLUDE_ASSETS==False to re…

…move any Media from the form
See attached test for details.

Looks good to me. We had been relying on folks to include the JS/CSS assets themselves at the template level, and this should still work for them.

I've published this here, @pax0r, and added you to the README as a contributor:
https://pypi.org/project/django-tempus-dominus/<IP_ADDRESS>/
It is appreciated!


Include Assets rather than GitCDN

I noticed in https://github.com/Laralum/Laralum/blob/master/src/Views/layouts/master.blade.php that it directly links to gitcdn for many of the assets, why not include this directly into the package to make it customization?
Perhaps this is already an item on your todo list 😄

Hello @Braunson !
Thanks a lot for the feedback, we decided to use gitCDN to avoid unessesary fiels and commands to be copied, including the mlocally would require a publish and in fact, when the assets gets updated they get kinda messy.
On the other hard, customization is still posible and will be expanded, using:
https://laralum.com/docs/Customization/Description
It still needs much development but as far as I'm concerned, I think it can do everything you'll like it to do!


More consistent self-update assets determination

Description
Typst v0.12 has prebuilt aarch64-pc-windows-msvc and riscv64gc-unknown-linux-gnu (#4821), but current self-update is not aware of the new targets.
https://github.com/typst/typst/blob/2634a8402cdbd2443edf27abeb4ee6bafb70f5bd/crates/typst-cli/src/update.rs#L208-L220
This PR not only fixes it, but also provides a more maintainable implementation.
Questions
I see that we have prebuilt x86_64-unknown-linux-musl, aarch64-unknown-linux-musl and armv7-unknown-linux-musleabi. They are all using musl libc, but riscv64gc-unknown-linux-gnu is using gnu libc alone. Is it better to use riscv64gc-unknown-linux-musl for consistency (rust 1.82 supports it now)?

Thanks!
If musl is supported now, maybe we can indeed switch.

I forgot to bump Rust in the release workflow alongside CI (also in the flake, but I can't test that anyway), so that'd need to be done as well for musl to work.

I forgot to bump Rust in the release workflow alongside CI (also in the flake, but I can't test that anyway), so that'd need to be done as well for musl to work.

See #5340 . I have sent a new PR for riscv64gc-unknown-linux-musl and release.yml :)


Question regarding: model.train(dataframe)

I'm using pandas to import a csv file :
training_data = pd.read_csv(csv_file_path)
Yet when I use the ludwig api:
train_stats = model.train(data_df=training_data)
I get this error:
FileNotFoundError: [WinError 2] The system cannot find the file specified
I'm misunderstanding the api examples. My understanding is one can specify either a csv file path or a dataframe, yet am unable to get either to work properly.

It looks like that's a pandas error, you are loading the wrong file, doesn't seem to be a Ludwig error. Please make sure of that, if you able to load the csv correctly and look at it's content before callin model.train() then post here a reproducible result and I will look into it.

Doesn't appear to be a pandas issue. I installed and ran another automl package in the same environment, on the same data,  and it worked fine. Here's my session after the csv import until it crashes in the subprocess.py file:

from ludwig import LudwigModel

model_definition_string = '{input_features: [{name: Grants, type: numerical}, {name: Loans, type: numerical}, {name: CumGPA, type: numerical}, {name: Level, type: category}, {name: Load, type: category}, {name: LowIncome, type: category}], output_features: [{name: Target, type: binary}]}'

model_definition = yaml.load(model_definition_string)

model = LudwigModel(model_definition)

train_stats = model.train(data_df=data)

Traceback (most recent call last):

File "", line 1, in
train_stats = model.train(data_df=data)
File "C:\Users\name\AppData\Local\Continuum\anaconda3\envs\ludwig\lib\site-packages\ludwig\api.py", line 417, in train
random_seed=random_seed)
File "C:\Users\name\AppData\Local\Continuum\anaconda3\envs\ludwig\lib\site-packages\ludwig\utils\misc.py", line 43, in get_experiment_description
stdout=open(os.devnull, 'w')) == 0
File "C:\Users\name\AppData\Local\Continuum\anaconda3\envs\ludwig\lib\subprocess.py", line 267, in call
with Popen(*popenargs, **kwargs) as p:
File "C:\Users\name\AppData\Local\Continuum\anaconda3\envs\ludwig\lib\site-packages\spyder_kernels\customize\spydercustomize.py", line 143, in init
super(SubprocessPopen, self).init(*args, **kwargs)
File "C:\Users\name\AppData\Local\Continuum\anaconda3\envs\ludwig\lib\subprocess.py", line 709, in init
restore_signals, start_new_session)
File "C:\Users\name\AppData\Local\Continuum\anaconda3\envs\ludwig\lib\subprocess.py", line 997, in _execute_child
startupinfo)
FileNotFoundError: [WinError 2] The system cannot find the file specified

the variable ‘data’ is not defined in your snippet of code.
Plus please format and indent your code and error correcly otherwise it is unreadable.
Please provide a fully replicable example, including a sample of the data or an equivalent, what os you are running on and all the details that are needed, otherwise it is difficult for us to try to solve your issue.

Windows 10 Pro
Python 3.6.7
Conda 4.6.3
I'm using the iris data set imported with pandas as a (150, 5) DataFrame.
The code I'm testing Ludwig with is:
import pandas as pd
import yaml
path = 'C:/tf_data/iris.csv'
data = pd.read_csv(path)
from ludwig import LudwigModel
model_definition_string = '{input_features: [{name: sepal_length, type: numerical}, {name: sepal_width, type: numerical}, {name: petal_length, type: numerical}, {name: petal_width, type: numerical}], output_features: [{name: species, type: category}]}'
model_definition = yaml.load(model_definition_string)
model = LudwigModel(model_definition)
train_stats = model.train(data_df=data)
The error thrown is:
File  ~\Continuum\anaconda3\envs\ludwig\lib\subprocess.py", line 997, in _execute_child
startupinfo)
FileNotFoundError: [WinError 2] The system cannot find the file specified

I need the full stack of the error to figure out where it happens. Please provide it. Also please run data.describe() before importing Ludwig and report on what it prints.

data.describe() prints various statistics describing the iris numerical data; count, mean, std, min, 25%, 50%, 75%, max.
The full stack error is:
Traceback (most recent call last):
File "", line 1, in
train_stats = model.train(data_df=data)
File ~\Continuum\anaconda3\envs\ludwig\lib\site-packages\ludwig\api.py", line 417, in train
random_seed=random_seed)
File ~\Continuum\anaconda3\envs\ludwig\lib\site-packages\ludwig\utils\misc.py", line 43, in get_experiment_description
stdout=open(os.devnull, 'w')) == 0
File ~\Continuum\anaconda3\envs\ludwig\lib\subprocess.py", line 267, in call
with Popen(*popenargs, **kwargs) as p:
File ~\Continuum\anaconda3\envs\ludwig\lib\site-packages\spyder_kernels\customize\spydercustomize.py", line 143, in init
super(SubprocessPopen, self).init(*args, **kwargs)
File ~\Continuum\anaconda3\envs\ludwig\lib\subprocess.py", line 709, in init
restore_signals, start_new_session)
File ~\Continuum\anaconda3\envs\ludwig\lib\subprocess.py", line 997, in _execute_child
startupinfo)
FileNotFoundError: [WinError 2] The system cannot find the file specified

I believe this has to do with the attempt to get the git hash, try to use the current master branch as i already solved an issue related to this.

I found the closed issue referenced and used the stop-gap code addition mentioned therein. Look forward to upcoming releases. Thank you.


Documentation inconsistencies for usage/reference

Playing with osbuild locally, I ran into 2 issues with the online documentation to run builds locally when using Fedora 39 as the OS I was developing my image(s) on:

The composer-cli package is actually weldr-client for dnf operations in current versions of Fedora. Referencing: https://osbuild.org/docs/on-premises/installation/

When I attempt to do a files customization install into /root (well aware of the cautions, was just trying some ideas out) - my composition didn't seem to accept that as a possible path. Referencing: https://osbuild.org/docs/user-guide/blueprint-reference (Files and directories section). I wasn't sure if I was hitting a change/limitation or maybe just using the wrong pathing (maybe I should've tried /var/roothome).

Hi!
Ad 1) There should be a virtual provide, I just tested this on F39 and it works as expected for me:
user@fedora ~ $ sudo dnf install composer-cli
Last metadata expiration check: 0:50:18 ago on Mo 11 Mär 2024 11:16:11 CET.
Package weldr-client-35.11-2.fc39.x86_64 is already installed.
Dependencies resolved.
Nothing to do.
Complete!

Ad 2) Could you share your blueprint please? Thanks!


Create a sample integrating Firebase

As per this request: https://forums.creativeclouddeveloper.com/t/anyone-using-firebase-with-their-uxp-plugin/3640
I'm not 100 % sure if it's possible to integrate the Firebase libraries, meaning that this includes first evaluating if it is possible to do so.

@pklaschka @ErinFinnegan  Can you assign this issue to me? I'd like to work on it.


fix: fix missing explanation for then branch in case when

Which issue does this PR close?
NA
Rationale for this change
fix copy paste issue
How are these changes tested?
Manually

This fix is trivial and obvious. I merged it. Feel free to submit a follow up to add test if you want. Thanks.


Generic user_friendly name in generated spreadsheets

Describe the bug
When I download a generated spreadsheet from DCP the user_friendly names I get for all biomaterials and protocols is a generic Biomaterial ID and Protocol ID instead of DONOR ORGANISM ID and COLLECTION PROTOCOL ID I have from the template that we use.
There can be multiple columns with the same name when we have input biomaterial into one entity or multiple protocols applied to one entity.
To Reproduce

Download a spreadsheet from DCP i.e. GSE67833_neural_stem_cells (works for ~100 spreadsheets I downloaded).
For each tab of the graph for biomaterial or protocol, the user_friendly name is a generic Biomaterial ID or Protocol ID

Expected behaviour
The generated spreadsheet would have a user_friendly name for the Biomaterial ID that specifies the type of biomaterial i.e. Donor Organism ID, Specimen from Organism ID, Cell suspension ID, Cell line ID, Organoid ID, Imaged specimen ID and the type of protocol Aggregate generation protocol, Collection protocol, Differentiation protocol, Dissociation protocol, Enrichment protocol, iPSC induction protocol, Treatment protocol, Imaging preparation protocol, Imaging Protocol, Library preparation protocol, Sequencing protocol, Analysis protocol.
Screenshots / Logs
What is shown in the downloaded spreadsheet from DCP.
Private Zenhub Image
What is shown in the template that we use.
Private Zenhub Image
Links
no links
Environment

[X] prod
[ ] staging
[ ] dev

Browser

[X] Chrome
[ ] Safari
[ ] IE
[ ] Other (please specify)

I investigated a bit about this, this is due to the way the flattener recollects the information from the schemas for the headers.
I am preparing a PR to solve this


Flipping navigator causes incorrect navigator display region rotation

Description

It seems that the $.Navigator.setFlip() function overrides or incorrectly sets the rotate() value of the displayRegion element
Setting flip, then rotating rotates the display region of the navigator correctly
Setting rotation, then flipping causes the display region to be flipped correctly but have an incorrect rotation

Example:

Note the rotation of the display region in the navigator vs the FOV shown
This was achieved by rotating, then flipping the TiledImage (see linked sandbox)

Correct Example:

Note that the display region accurately reflects the FOV

Version

5.0.0 (but present in 4.x)

Steps to repro

Add a TiledImage
Rotate then flip via the viewport.setFlip and viewport.setRotation methods
Note the incorrect position of the display region

Sandbox
Link to sandbox with example

Might not be the best way of going about it, but tweaking the setFlip function of Navigator to more closely match the logic in Navigator.setRotation seems to resolve the issue:
    // $.Navigator.setFlip()
    /**
      * Flip navigator element
      * @param {Boolean} state - Flip state to set.
      */
    setFlip: function(state) {
      this.viewport.setFlip(state);

      var rule = this.viewer.viewport.getFlip() ? "scale(-1,1)" : "scale(1,1)"
      var displayRegionRule = "rotate(" + -this.viewport.getRotation() + "deg) " + rule;

      setElementTransform(this.canvas, rule);
      setElementTransform(this.element, rule);
      setElementTransform(this.displayRegion, displayRegionRule);

      return this;
    },

Matching what we do for rotation seems like a reasonable approach. I'm not finding Navigator.setRotation in the code... what function are you referring to?

My mistake, its actually just called the rotate function found in $.Navigator: https://github.com/openseadragon/openseadragon/blob/e1e0ec6b241e11baec873a024ddf6a7e59834647/src/navigator.js#L223-L238
And what I mean by matching is that it seems that the existing flip code just overwrites the transform on the displayRegion div, we can just counter-rotate based on current rotation like is found on line 225:
https://github.com/openseadragon/openseadragon/blob/e1e0ec6b241e11baec873a024ddf6a7e59834647/src/navigator.js#L225
Thanks for all your work on OSD!

I see! Seems like the best approach would be to have a common function that the rotate handler and setFlip both call, so either way it gets set properly (since either flip or rotate could be called first). What do you think? Would you be up for making a pull request?

Finally got some time to work on this!
Have a quick question after looking into this a bit:
it seems that the main problem is that the main problem is that setFlip() is overriding existing rotation transforms for the display region when flipped:
https://github.com/openseadragon/openseadragon/blob/e1e0ec6b241e11baec873a024ddf6a7e59834647/src/navigator.js#L350C7-L350C26
What I don't quite understand though is that by flipping the element and canvas we are also flipping the display region, so I'm not sure that line is even needed.
An example of what setFlip() appears to do (not including the displayRegion transform):
2024-11-20 13-52-25.webm
I think that the displayRegion is correctly oriented just by the element/canvas flipping?
Let me know if I'm incorrect, I can pursue just preserving the existing rotation transform while still flipping, or your suggestion of a shared method!

Well spotted! Looks like the code evolved unevenly. Good to have that cleaned up!
Fixed by #2619.


Storing Classifications in Open Lineage Services

Some questions about storing classifications for lineage:
1   Should all classification types be stored in OLS, or should we have a filter? A potential use case for storing all classification types could be: "Show me the complete list of all classifications that have ever been assigned to this glossary term"  (Provided we have historical lineage)
2 If we decide to filter on classification types, could we establish a list of classification types that are relevant for Open Lineage Services?
3  If we decide to filter on classification types, should this filtering happen in the Asset Lineage OMAS (which events are published) or in the Open Lineage Services (which events are processed)? An argument to not place the filter in AL Omas could be that somebody who is interested in the classification types that we decide to filter out, could build his/her own version of OLS to receive these versions anyway.

IMHO:

Probably not, and I would suggest that the "show me the complete list of all classifications that have ever been assigned to x" is probably one (or more) other OMASes (?)

This sounds like the best approach to me: which classifications are relevant to lineage?

A configurable list for the AL OMAS, which we default to the set of classifications that we think are applicable (but that could therefore be easily overridden / extended if there are others of interest)?  If OLS then operated based on this same configured list, then it would be dynamic enough to be configurable, but narrow enough for a "default" set to be applied for filtering 🙂

I agree to have a default list that relevant to asset lineage context as long as the Asset Lineage OMAS can be configurable and able to filter relevant classifications to AL OMAS out topic, then the OLS can just store the classifications.


Automator: update proxy@master in istio/istio@master

Generated by Automator - 2023-09-06T21:35:37+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ipv6_istio
b65851fb7c770e67e4c2f4100503f498492d0cfb
link
true
/test integ-ipv6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-ipv6


"--requires" flag is broken in all versions of Python.

When I run python setupy.py --help I see the following tantalizing option:
 --requires          print the list of packages/modules required
But using it simply prints a newline to stdout. I've tried this on in 2.7/3.4 on my local Ubuntu install as well as on 2.7, 3.4, 3.5 and 3.6 CPython Docker images.
Expected behavior:
$ git clone https://github.com/pypa/sampleproject.git
$ cd sampleproject
$ python setup.py --requires
peppercorn

Observed behavior.
$ git clone https://github.com/pypa/sampleproject.git
$ cd sampleproject
$ python setup.py --requires

$ python3.4 setup.py --requires

Duplicate of https://github.com/pypa/setuptools/issues/1153.


Run Gatekeeper under Valgrind

The goal of this task is to see whether Valgrind can identify any memory safety issues in Gatekeeper.

This was done in 2bc39b7 . No leaks were found. End-to-end tests will be now run under Valgrind to detect any potential leaks in the future.


Content-Security-Policy (CSP) and canvas style attribute

I'm using Chart.js version 2.9.3 and I'm using strict CSP headers on my server, which includes blocking unsafe-inline styles.
I have followed the instructions from the documentation:

Content Security Policy
By default, Chart.js injects CSS directly into the DOM. For webpages secured using Content Security Policy (CSP), this requires to allow style-src 'unsafe-inline'. For stricter CSP environments, where only style-src 'self' is allowed, the following CSS file needs to be manually added to your webpage:
<link rel="stylesheet" type="text/css" href="path/to/chartjs/dist/Chart.min.css">

And the style injection must be turned off before creating the first chart:
// Disable automatic style injection
Chart.platform.disableCSSInjection = true;

While this does prevent a <style> tag from being injected, the canvas element still uses a style attribute for setting the width and height, which still requires style-src 'unsafe-inline' to work.
Is there something I'm missing here, or is the documentation incorrect in stating Chart.js can run properly when CSP is configured with style-src 'self'?

Is there something I'm missing here

Yes.
Apparently, one style attribute is not the same as another:

When you write CSS to elements via JavaScript using the CSSOM, it’s not the same as literally writing style=“...”; rather, you are directly manipulating the DOM [correction: the CSSOM]. CSP allows these types of styles even when not allowing unsafe-inline styles. -- https://stackoverflow.com/a/51592893


Update to current client_golang

@gouthamve @brancz This is mostly to get the new client_golang code into our own main repos before releasing it as v0.9.
There was only one use of a deprecated type, and that only in an example. I fixed it in this PR, too.
We could now, of course, prefix the TSDB metrics with prometheus_ here (by wrapping) and remove it in prometheus/tsdb. @gouthamve as you are the expert of using prometheus/tsdb as a library, is this something desired, i.e. give users of prometheus/tsdb the freedom of prefixing their TSDB metrics with something else (or nothing, i.e. leave it at tsdb_...)? One might also argue every user of prometheus/tsdb should use the same metric names. The crucial question here is: Do all the prometheus_tsdb_... metrics mean the same, even if prometheus/tsdb is used as a library in something that is not Prometheus?

Oh wow, https://godoc.org/github.com/prometheus/client_golang/prometheus#WrapRegistererWithPrefix has been something I have been looking forward to since ages!
I think the only reason we have the prometheus_ prefix down in TSDB is because this function is missing and I think it only makes sense to remove it there and wrap it here.

Do all the prometheus_tsdb_... metrics mean the same, even if prometheus/tsdb is used as a library in something that is not Prometheus?
Yes, but prepending it with prometheus_ could be confusing if people are using it for generic applications.

👍 to this PR though!

Do all the prometheus_tsdb_... metrics mean the same, even if prometheus/tsdb is used as a library in something that is not Prometheus?

Yes, but prepending it with prometheus_ could be confusing if people are using it for generic applications.

What was the reason then for prefixing them with prometheus_? (Real question. I'd like to understand the reasoning so that we can make an informed decision if we want tsdb_... only in the prometheus/tsdb repo but then still prefix with prometheus_... for Prometheus as a user of the TSDB library.)

IIRC it was to make sure that all metrics that are prometheus internal are prefixed with prometheus_. It was initially tsdb_ but the change was made in this PR: https://github.com/prometheus/tsdb/pull/184
Maybe @fabxc @brancz can clarify.

I don't think _tsdb is sufficient for namespacing, while prometheus_tsdb_ clearly tells you this is concerning a Prometheus tsdb. I think there are arguments to both sides, but I think there are going to be less confusions with the prometheus_tsdb_ prefix, plus the metrics have been around for almost a year now and it would be nice not to break them :slightly_smiling_face: .

this lgtm

I'll create a separate PR in prometheus/tsdb for the un-prefixing. Objections can still be raised there.
Merging this for now.

@beorn7 the prefixing was the result of a longer discussion during release and the amount of confusion and support requests it caused when users couldn't find Prometheus metrics. I don't think we should reverse that decision.

The resulting metrics will still look like prometheus_tsdb_... on the Prometheus server. The only question is if it should be hardcoded into the TSDB library or added by the actual Prometheus server code using https://godoc.org/github.com/prometheus/client_golang/prometheus#WrapRegistererWithPrefix

The only question is if it should be hardcoded into the TSDB library

It should be hardcoded into the TSDB library. Applications should not prefix metrics of the libraries they use, except in extremely rare circumstances as that prevents horizontal monitoring - that's what target labels are for.


Calling $extend with a Class function is awkward and incorrectly documented

The docs indicate that $extend() can be called with a class function. In practice, this works, but not as documented. The API documents indicate this will work:
    function Widget(ref) {
      $firebaseArray.call(this, ref);
      // do widgety things
    }

   var WidgetArray = $firebaseArray.$extend(Widget);
   new WidgetArray( ...ref... );

However, in practice, this does not return an array, but the instance that wraps the array (internally, AngularFire's constructor creates an array and returns that, so Array.isArray() will work as expected, and array functions can be used on it directly).
To make this actually work, one must do the following:
    function Widget(ref) {
      var res = $firebaseArray.call(this, ref);
      // do widgety things
      return res;
      // or this works, too:  return this.$list;
    }

   var WidgetArray = $firebaseArray.$extend(Widget);
   new WidgetArray( ...ref... );

We should ponder this to see if it can be simplified and also update docs to match.

Any chance of also supporting ES6 classes with babel somehow? It would be great if we could do something like this:
import {FirebaseArray} from 'angularfire';

class WidgetArray extends FirebaseArray {
    constructor(ref) {
        super(ref);
    }
}

new WidgetArray( ...ref... );

No plans to support ES6 for 1.0.

There's no easy fix for this issue. I've changed it to a documentation fix. the solution is to return this.$list from the function, which is not immediately intuitive, but necessary to make Array functions (e.g. Array.isArray() and Array.prototype.forEach()) function correctly on $firebaseArray instances.


Add pulling

From #850

Make sure to close #850 when this gets merged.

Pulling players requires https://github.com/space-wizards/RobustToolbox/pull/1189

Closed by accident.


Batches are not processed in parallel

I just tried to run the batch manager for multiple shards at once and realized that the script will wait for each batch file to be processed completely before going on with the next one, due to the structure of the batch loop.
While this is necessary for uploading jobs, if not performed concurrently, waiting for each job to finish before commencing the next one is likely not what you intended.

Maybe I’m misunderstanding the token limits for OpenAI. Don’t they require
you to only be running one batch at a time to stay under them? Or is the
token limit just per-batch?
If it’s the latter, then I really don’t get the point 🤔 it just seems like
a nuisance.
But if that’s the case, then yes, we should run them all concurrently!!
On Mon, Sep 30, 2024 at 6:52 AM regtm @.***> wrote:

I just tried to run the batch manager for multiple shards at once and
realized that the script will wait for each batch file to be processed
completely, before going on with the next one, due to the structure of the
batch loop.
While this is necessary for uploading jobs, if not performed concurrently,
waiting for each job to finish before commencing the next one is likely not
what you intended.
—
Reply to this email directly, view it on GitHub
https://github.com/danvk/gpt-batch-manager/issues/4, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAX77IFUYWAT2SR3QJIF5TZZEUO5AVCNFSM6AAAAABPDAEMLSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU2TMMRYGA2DAMY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

In my understanding there are two limits at play for completions. The request limit per batch and the batch queue limit which is in total over all batches https://platform.openai.com/docs/guides/rate-limits/usage-tiers?context=tier-four

Gotcha. I'm just using OpenAI for personal projects and I'm on Tier 1, so the queue limit (2M for 4o-mini and 90,000 for 4o) is the big constraint for me. But if you're on Tier 4, then I guess the 50k requests/file is the main limit.
I'd be happy to accept a PR that adds a flag to run batches in parallel.


[Epic] Proof Timeliness and Prover Coordination

Overview
Design docs of proof timeliness and prover coordination.
I'm lumping them together within this one epic because they're tightly related in practice/development, though the key  observation is that the Proof Timeliness work is largely enshrined and on L1, and the Prover Coordination work is not.
As a quick overview of the functionality we want with this epic.
Proof timeliness
An epoch is comprised of many blocks (e.g. 32).
On L1, we keep track of a pending chain tip, and a proven chain tip (which is a prefix of the pending chain).
The committee can post blocks to the pending chain, once per L2 slot (e.g. every 36 seconds).
One epoch is proven at a time, and verified on L1.
When epoch n ends, its proof must land in epoch n+1.
The first 13 proposers in an epoch have the ability to post a prover commitment bond, and subsequently the proof.
Doing so claims the TST block rewards that will be distributed once the epoch is proven according to the fee specified by the prover.
The bond they post must come out of an escrow specifically designed for holding prover commitment bonds.
If a bond to prove epoch n-1 doesn't land in the first 13 slots of epoch n, then the pending chain tip get reorged back to point to the last proven block (i.e., the last block in epoch n-2).
If a bond to prove epoch n-1 does land in time, but a proof does not land in epoch n, this results in the same reorg back to the last proven block.
Prover coordination
It is doubtful that the proposers will actually be running their own proving infrastructure. They will, instead, be coordinating with proving marketplaces to get bonds and proofs posted; this is what "prover coordination" refers to.
There will be an optional p2p layer to allow prover marketplaces to submit quotes, which will allow proposers to immediately submit the quote to L1.
The quotes will be signed such that the proposers can use the provers funds in escrow for the purpose of the prover commitment bond.
Stress test of functional requirements
We must demonstrate that 20 actors representing proving marketplaces can submit bids, that at most 1 bid can be accepted on L1 during, the bid can only be accepted during the proof claim period of a prescribed epoch, the bid is only actionable on L1 if the prover has the requisite bond in TST, and that all the above works when there are 300 nodes on the p2p network, and the chain is operating at 1TPS with proving turned on.
### Tasks
- [x] Spec design
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/8401
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/8679

closed in favor of the two supporting, distinct epics


Update gensim.model.vocab call in seminar 1

replaced call to model.vocab with call to model.index_to_key to be compatible with gensim v.4. no extra sorting is needed - index_to_key is effectively coming in the order of keys.
This code was not run at the seminar in sep-2022.

will resubmit as separate PRs


Registries 2023-06-01-preview staging

ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify -- update existing versions to correct breaking change

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

@milesizydorczak12 please remove ARMChangesRequested label after you getting Approved-Breaking Changes and ready for ARM review.

@milesizydorczak12 please remove ARMChangesRequested label after you getting Approved-Breaking Changes and ready for ARM review.

I removed the breaking changes (and most of the changes) planning to introduce them via a separate Breaking change review for both June and April versions after version merges (for sake of unblocking June API)

@qiaozha @raych1 @msyyc, could you help to take a look at the SDK breakingchange error in this PR? Thanks

@v-jiaodi PR has received SDK Breaking change approval (I think the checks are flaky hence why it failed). What are the next steps here? Who should I ping to merge the PR?

The automation detected this Pull Request introduces breaking changes to an existing API version and hence it added the NewApiVersionRequired label. This means you cannot proceed with merging this PR until you complete one of the following action items:- A) Submit a new PR instead of this one, or modify this PR, so that it introduces a new API version instead of introducing breaking changes to an existing API version. The automation will remove the label once it detects there are no more breaking changes.- B) OR you can request an approval of the breaking changes, get it reviewed, and approved. The reviewer will add Approved-BreakingChange label if they approve.For additional guidance, please see https://aka.ms/NewApiVersionRequired

@milesizydorczak12 Please operate according to the reference above.


Add listening interface and port selection

Solves #17 .

Please describe shortly why you split managed_proxy.rs from the main.rs file


Add support for Azure German Cloud (and China, US govt, etc)

We're blocked deploying our EH spark-based solution to a customer site due to not being able to run against an eventhub located in the german cloud.
I'm having issues building the solution locally with maven so I'm not able to test properly - but I thought I'd open the PR now so that maybe reviewers can get eyes-on as soon as possible.
Essentially this just allows for eventhubs.namespace to either be the namespace name, or the fully qualified namespace URL - and uses the existing ConnectionStringBuilder overload in the java lib.
Once tested and merged, how would we go about getting an updated build published to maven so we can proceed with deployment?

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: p2bauer sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

investigating build failures now :-)

Hey Paul, thanks for the PR!! I wanna make sure I understand your change correctly. Instead of providing the namespace, name, policy name, and key separately, you'd like the option to provide the entire connection string in the namespace name?
Let me know if I'm understanding that correctly, and we can discuss the best way to handle it 👍

Also, is a staging build sufficient for now or do you guys need a release in maven central? The staging build can be made available much quicker, so you guys can be unblocked. We're happy to release to maven central to accommodate you guys, but that would take more time...probably end of this/early next week.

@sabeegrewal - i'm totally open to an alternative solution on how to handle EH configuration (and we can just discard this PR) - this was just the most minimal change I could come up with.
Re: maven, staging build would be great as well, just let me know.

oh, and I don't necessarily need the whole connection string - just the fully qualified namespace url instead of namespace name.
ie. I could specify <NAMESPACE>.servicebus.windows.net instead of just <NAMESPACE> - since in the case of the german cloud, the suffix would not be .servicebus.windows.net.

Ok, let's do a staging version for now. I'll expose the ability to add an EventHubs URI to the user, and you can set your URI there. Could you close this out and open an issue? We can continue this conversation there :)


Merge 2-8 updates to live

OPS Build status updates of commit 05586db:
:clock10: Preparing: average preparing time is 3 min(s) 17 sec(s)

OPS Build status updates of commit 05586db:
:clock10: Incremental building: average incremental building time is 54 min(s) 24 sec(s)

OPS Build status updates of commit 05586db:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

F1/gridlinestyleleft-property-access-vbaac10-chm10528.md
:white_check_mark:Succeeded
View

F1/gridlinestyleleft-property-access-vbaac10-chm11156.md
:white_check_mark:Succeeded
View

F1/gridlinestyleright-property-access-vbaac10-chm10530.md
:white_check_mark:Succeeded
View

F1/gridlinestyleright-property-access-vbaac10-chm11158.md
:white_check_mark:Succeeded
View

F1/gridlinestyletop-property-access-vbaac10-chm10529.md
:white_check_mark:Succeeded
View

F1/gridlinestyletop-property-access-vbaac10-chm11157.md
:white_check_mark:Succeeded
View

Language/Reference/User-Interface-Help/attributes-property.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.Height.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.HelpContextId.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.HorizontalAnchor.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.InSelection.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.IsVisible.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.KeyDown.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.KeyPress.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.KeyUp.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.LabelAlign.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.LabelX.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.LabelY.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.Layout.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.LayoutID.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.Left.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.LeftPadding.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.Locked.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.MouseDown.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.MouseMove.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.MouseUp.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.Move.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.Name.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.OLEType.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.OLETypeAllowed.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.Object.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.ObjectPalette.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.ObjectVerbs.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.ObjectVerbsCount.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.OldBorderStyle.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.OldValue.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.OnClick.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.OnDblClick.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.OnEnter.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.OnExit.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.OnGotFocus.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.OnKeyDown.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.OnKeyPress.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.OnKeyUp.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.OnLostFocus.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.OnMouseDown.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.OnMouseMove.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.OnMouseUp.md
:white_check_mark:Succeeded
View

api/Access.BoundObjectFrame.OnUpdated.md
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


modules/persistence: fix string leak

Default value is leaked if persist_open() fails on
persistence/string.
Also it was lacking proper handling of strdup error.
Signed-off-by: Bruno Dilly<EMAIL_ADDRESS>

merged, thanks


It does clonal vs suclonal variants?

Hi,
It's a great tool using the neural network approach. Could you clarify, does this tool classifies somatic clonal and subclonal variants? Or it classify germline variants vs. somatic variants?
Thanks again!!

Hi @immuneAI ,
clonal vs subclonal variant would require clustering the reads which is not implemented in DeepSomatic. Currently we only do germline vs somatic.

Thanks, I saw the LinkedIn post of Andrew, stating it does subclonal variant, guess it's a typo!!

Hi @immuneAI
This is due to me not choosing my words as exactly as possible.
I wanted to use the word "subclonal" to suggest that the method can potentially be inclusive of non-cancer applications where you want to identify variants in populations of cells. For example, cases like CHIP, detecting CRISPR edits, or cases where you have a population of mostly genetically identical organisms like bacteria colonies that carry a low rate of variants within them.
I didn't think about how that distinction that would be read for cancer applications specifically.
DeepSomatic detects somatic variants, but it is not itself capable of distinguishing which are clonal and which are subclonal from within the tumor BAM file. DeepSomatic will flag either of those classes as somatic variants, but you would need some other process to determine which are clonal to the tumor and which are subclonal within it.
I hope that explanation clarifies what DeepSomatic is designed for.


Need some advice about training

Hi!
First of all, thanks for sharing these codes, especially the trained models. I've tested the detection part and the results are astonishingly good given the fact that yolov3-tiny has such a simple structure. So I'm really curious about your training approach.
1.What dataset did you use for detection? I've tried it on coco and voc but the results were way worse than yours.
2.Is there any pre-trained weights for yolov3-tiny? or you just trained from scratch?
Hope you can help me!

Hi, thanks for interest.
First, a big and good data-set is required, the company i work for has provided one(~2.5W) which i could not release out.  Thx for understanding.
Second, we take advantage of pre-trained weights of YOLO, namely fine-tune from imagenet data. It can be downloaded freely.
Third, we take an incremental tranning method : easy samples first, then hard samples for iterative training(use simple hand ratio of 6:4 for example).

Thanks again!

@jokerobbin Hello! i'm also working on training this neural network.if it's possible, can you share your train code of the detection part with me?

@hustpenghuan I trained the network on Darknet. You can check the code on Darknet's official site.


chore(ci): remove wit-bindgen-cli from test runs

This commit removes wit-bindgen-cli from tests, which was required when building golang tooling. Since upstream deps have changed (it no longer tries to call wit-bindgen but instead calls wasm-tools, we should be OK removing wit-bindgen-cli.
Feature or Problem

Related Issues

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

Sorry this wasn't clear but this was a WIP, I should have marked it so -- https://github.com/wasmCloud/wasmCloud/pull/3441/commits/0d9dcff54ee31ac62fcef4700fd7cc15923ee100
What I found out ~4 days ago was that this code doesn't actually work, especially if you don't have the tooling installed, because go run won't actually download and install the thing automatically, you need the "tools.go" pattern for that, which is a wider change, and there's a PR that does that and other stuff which actually should be broken down and used instead (excluding the "tools.go" adoption change, IIRC).
Closing this for now, as other PRs have started landing to update the Go examples as well!

it's worth noting that with the changes that are going in to component-sdk-go, I think fast approaching state where we will no longer need the tools.go trick.


Binary name should be xf not xenforo

Small thing: This can be changed ourselves easily and xf is a little more ambiguous but it might be worth considering changing the binary name to that (preferably because it's shorter) or go with the same name as the repo, e.g. xf-cli.
Simple reason being is that's basically what we would expect to become more familiar over time. Different from XF1, we very rarely refer to XF2 as "XenForo" in the code. By contrast, it was pretty much the opposite in XF1.
So, little thing, but a name change (even though we can do it ourselves!) is probably something to think about.

Makes sense to me, will probably do this when I get a chance to look at #2


Problems with cache and saving

I usually use Google Chrome to create my files.
I find no problems at all while creating and saving my homebrews, the problem comes the day after. When I start my pc and open Google Chrome, the homebrew I find open in my tabs is the one of yesterday BEFORE doing any edits to it. A quick refresh usually fixes the problem.
Unluckly, today I forgot and lost around 12 pages of content. Is they any way to see a chronology of the edits or something like that?

This should be fixed now. Brews should always be loaded from the database now instead of cached.


How to setup GraphQL Transport ?

Hi!
I want to use this package within a SSR app, so I need to authenticate my user on first request, but  also into my graphQL API
Can you explain me quickly how to do so ?
Should I use rest-client and store tokens in the cookies, and then use the express-rest middleware to log the user before reaching the ggraphql middleware ?
Or should I use the graphQL transport ? How this transport proceed ?
Maybe both, I'm confused
Thanks !
@davidyaha ?

Found this, in case anyone is still looking:
https://github.com/accounts-js/graphql/tree/master/packages/graphql-api

A new documentation website will be available soon !


Skill meters!!!

Coverage decreased (-0.6%) to 78.79% when pulling b346ae153d64d76d4face06bc40b0ca38f34dd45 on skill-meters into 902f026f49935587caa9dc267f58163e78e63674 on master.

@jannypie


Adds gradient background as an option

I figured I'd take a stab at trying to implement the solid background request from last night (#6). However, I'm a PHP developer and have never looked at LUA until last night lol I feel like there's a better/more efficient way to do this than to have an if condition, but it works. The only thing I couldn't get to work is live updating. Toggling the option only takes effect after a reload. After about an hour of trying to figure out the issue, I gave up. Also, as you can tell, I didn't add any translations other than enUS.

While I appreciate the effort that's definitely not how you want to implement that, hehe 😅

lol Hey, it was worth a shot!

Yeah, dw dw, it's fine ❤


[Faucet] Skip instead of returning an error when the balance is small

Today we return an Error: https://github.com/MystenLabs/sui/blob/aa1a78e7d5538a017d696fb12b573147d9624bc1/crates/sui-faucet/src/faucet/simple_faucet.rs#L338-L344 when the selected coin does not have insufficient balance. This error should not be visible to the end users. Instead, we should try to find another coin  when the balance of current selected coin is too low

Just finding another coin is enough, or would it be better to merge with the next coin until a coin with sufficient balance is formed?
Or slightly larger refactoring where the prepare_gas_coin would return a vector of coins since paySui works like that?

Is this still something that would be desirable to have? @Eis-D-Z @666lcz


added option (-u) to unlock SPI roms

I've added very basic support to unlock spi roms that require it by specifying a -u commandline option.
This option issues command 0x98 before any write. Other spi chips may need other commands so this could be extended in the future.
By default no new commands are issued when running fomu-flash

this is a fix for issue #9

Looks good to me. Thanks for the patch!


[KED-1404] Remove trufflehog pinned dependency in test_requirements.txt

Description
One of trufflehog's dependencies dependency upgraded itself and broke everything (see https://github.com/dxa4481/truffleHog/issues/200).
We've pinned it inside test_requirements as a temporary workaround, but it is fixed in their side. So we would like to remove the line in test_requirements.txt
gitdb2==3.0.0 # pin trufflehog dependency to get it working for now https://github.com/dxa4481/truffleHog/issues/200

While doing this,  remember to bump the lower bound of trufflehog.

@ANA-POTJE solved this one! Thank you! 🎉


Install loki #40

PR Description
This PR adds loki to preform visual regression testing for storybook. This tool looks at the rendered stories within storybook, stories .png files of the stories, and compares them to the reference .png files. This tool will add an additional testing step for developers. When a story's visual representation is changed, or potentially changed, the developer will need to complete the following steps:

Run storybook locally by executing yarn storybook
In another terminal, execute yarn loki test

yarn loki test creates .png files of the current state of the stories and places them within the .loki/current directory. It also creates diff .png files (stored in .loki/difference) comparing the current .png files and the reference .png files (stored in .loki/). If there are any differences between the current and reference stories, the test for that story will fail. This is normal and expected.

Exam the current and difference files to look at the story changes. Once it is determined the changes are intended and correct, execute yarn loki approved.

yarn loki approved updates the reference images with the current images.
In addition to installing loki, this PR includes the following changes:

Created .loki/.gitignore for the current and difference loki directories so we don't checkin junk files
Updated .circleci/config.yml to execute yarn loki test to fail unapproved or unintended changes

Actual way to test
docker-compose run --rm storybook bash
yarn build-storybook
yarn loki test --requireReference --reactUri file:./storybook-static
yarn loki approve <- must do this prior to committing changes
For Reviewers
I am unsure how to best document this new developer step. I would love suggestions on how to make the process clearer. I also don't know if I correctly changed the circleci config. Should there be a command to clear the current and difference directory after yarn loki test completes successfully?
Milmove has had trouble using loki and IE11. Is this a concern for us? If so, I will need to change the storybook config file a bit.
P.S. This looks like a huge PR because it is adding all of the reference images for each component. They are auto-generated.
Potential Future Work

Install git-lfs
Execute git lfs track "*.png" (as suggested via in the loki documentation)
Execute git add .gitattributes to maintain the lfs tracking

References
Loki
git-lfs

Warnings

:warning:

Changes were made to yarn.lock, but no plain text yarn audit output was found in PR description. - Can you run yarn audit in your branch and paste the results inside a markdown code block?

  Generated by :no_entry_sign: dangerJS against 385bfcc18e52b58fb73d87140a16c1d7ffaab2c5

Can we include loki without requiring Docker? I know that applications like MilMove use it but since this is a library I don't want to require Docker as part of the dev environment. Also, I know we have to check in the loki reference images but do we also have to check in the static storybook files?

Can we include loki without requiring Docker? I know that applications like MilMove use it but since this is a library I don't want to require Docker as part of the dev environment. Also, I know we have to check in the loki reference images but do we also have to check in the static storybook files?

I don't believe we can use this library without docker. I first attempted to do this, but when loki is ran locally, the images created are slightly different than those created on circleci which led to circleci failing every time.
We don't have to check in the storybook static files. I just updated the .gitignore and removed the files.

@suzubara I just heard back from chromatic. Unfortunately the open source free plan only allows from chrome testing. It also has a snapshot limit of 35,000 per month. Given it only tests in chrome, I am not sure the collaboration tools out weight being able to in different browsers. What are your thoughts?


ng run project:server universal with custom environment not possible

Versions
Node: 9.4.0
OS: linux x64
Angular: 6.1.9
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, platform-server, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.8.3
@angular-devkit/build-angular     0.8.3
@angular-devkit/build-optimizer   0.8.3
@angular-devkit/build-webpack     0.8.3
@angular-devkit/core              0.8.3
@angular-devkit/schematics        0.8.3
@angular/cdk                      6.4.7
@angular/cli                      6.2.3
@angular/flex-layout              6.0.0-beta.18
@ngtools/webpack                  6.2.3
@schematics/angular               0.8.3
@schematics/update                0.8.3
rxjs                              6.2.2
typescript                        2.9.2
webpack                           4.20.2

Repro steps
I want to have a custom environment named staging. I updated the configuration in the angular.json file accordingly:
{
  "$schema"<EMAIL_ADDRESS>  "version": 1,
  "newProjectRoot": "projects",
  "projects": {
    "myproject-website": {
      "root": "",
      "sourceRoot": "src",
      "projectType": "application",
      "prefix": "app",
      "schematics": {},
      "architect": {
        "build": {
          "builder": "@angular-devkit/build-angular:browser",
          "options": {
            "outputPath": "dist/myproject-website",
            "index": "src/index.html",
            "main": "src/main.ts",
            "polyfills": "src/polyfills.ts",
            "tsConfig": "src/tsconfig.app.json",
            "assets": [
              "src/favicon.ico",
              "src/assets"
            ],
            "styles": [
              "src/styles.scss"
            ],
            "scripts": []
          },
          "configurations": {
            "production": {
              "fileReplacements": [
                {
                  "replace": "src/environments/environment.ts",
                  "with": "src/environments/environment.prod.ts"
                }
              ],
              "optimization": true,
              "outputHashing": "all",
              "sourceMap": false,
              "extractCss": true,
              "namedChunks": false,
              "aot": true,
              "extractLicenses": true,
              "vendorChunk": false,
              "buildOptimizer": true
            },
            "staging": {
              "fileReplacements": [
                {
                  "replace": "src/environments/environment.ts",
                  "with": "src/environments/environment.staging.ts"
                }
              ],
              "optimization": true,
              "outputHashing": "all",
              "sourceMap": false,
              "extractCss": true,
              "namedChunks": false,
              "aot": true,
              "extractLicenses": true,
              "vendorChunk": false,
              "buildOptimizer": true
            }
          }
        },
        "serve": {
          "builder": "@angular-devkit/build-angular:dev-server",
          "options": {
            "browserTarget": "myproject-website:build"
          },
          "configurations": {
            "production": {
              "browserTarget": "myproject-website:build:production"
            },
            "staging": {
              "browserTarget": "myproject-website:build:staging"
            }
          }
        },
        "extract-i18n": {
          "builder": "@angular-devkit/build-angular:extract-i18n",
          "options": {
            "browserTarget": "myproject-website:build"
          }
        },
        "test": {
          "builder": "@angular-devkit/build-angular:karma",
          "options": {
            "main": "src/test.ts",
            "polyfills": "src/polyfills.ts",
            "tsConfig": "src/tsconfig.spec.json",
            "karmaConfig": "src/karma.conf.js",
            "styles": [
              "src/styles.scss"
            ],
            "scripts": [],
            "assets": [
              "src/favicon.ico",
              "src/assets"
            ]
          }
        },
        "lint": {
          "builder": "@angular-devkit/build-angular:tslint",
          "options": {
            "tsConfig": [
              "src/tsconfig.app.json",
              "src/tsconfig.spec.json"
            ],
            "exclude": [
              "**/node_modules/**"
            ]
          }
        },
        "server": {
          "builder": "@angular-devkit/build-angular:server",
          "options": {
            "outputPath": "dist/myproject-website-server",
            "main": "src/main.server.ts",
            "tsConfig": "src/tsconfig.server.json"
          },
          "configurations": {
            "production": {
              "fileReplacements": [
                {
                  "replace": "src/environments/environment.ts",
                  "with": "src/environments/environment.prod.ts"
                }
              ]
            },
            "staging": {
              "fileReplacements": [
                {
                  "replace": "src/environments/environment.ts",
                  "with": "src/environments/environment.staging.ts"
                }
              ]
            }
          }
        }
      }
    },
    "myproject-website-e2e": {
      "root": "e2e/",
      "projectType": "application",
      "architect": {
        "e2e": {
          "builder": "@angular-devkit/build-angular:protractor",
          "options": {
            "protractorConfig": "e2e/protractor.conf.js",
            "devServerTarget": "myproject-website:serve"
          },
          "configurations": {
            "production": {
              "devServerTarget": "myproject-website:serve:production"
            },
            "staging": {
              "devServerTarget": "myproject-website:serve:staging"
            }
          }
        },
        "lint": {
          "builder": "@angular-devkit/build-angular:tslint",
          "options": {
            "tsConfig": "e2e/tsconfig.e2e.json",
            "exclude": [
              "**/node_modules/**"
            ]
          }
        }
      }
    }
  },
  "defaultProject": "myproject-website",
  "cli": {
    "defaultCollection": "@ngrx/schematics"
  }
}

The environment.staging.ts file is very simple:
export const environment = {
  production: true,
  env: 'staging'
};

I compiled my application using the following commands:
ng run myproject-website:build --output-path dist/browser/en --i18n-locale=en --configuration=staging --i18n-file=src/i18n/messages.en.xlf --i18n-format=xlf

ng run myproject-website:server --output-path dist/server/en --i18n-locale=en --configuration=staging --i18n-file=src/i18n/messages.en.xlf --i18n-format=xlf

and the server script with:
webpack --production --config webpack.server.config.js

The log given by the failure
The application compiles successfully.
When trying to launch the server script with:
node ./dist/server.js

I got the following error:
/home/templth/work/repositories/git/theglobetrotterturtle/myproject-website/dist/server.js:8121
        throw new Error('Cannot enable prod mode after platform setup.');
        ^

Error: Cannot enable prod mode after platform setup.
    at enableProdMode (/home/templth/work/repositories/git/theglobetrotterturtle/myproject-website/dist/server.js:8121:15)
    at Module../src/main.server.ts (/home/templth/work/repositories/git/theglobetrotterturtle/myproject-website/dist/server.js:147274:73)
    at __webpack_require__ (/home/templth/work/repositories/git/theglobetrotterturtle/myproject-website/dist/server.js:146581:30)
    at Object.0 (/home/templth/work/repositories/git/theglobetrotterturtle/myproject-website/dist/server.js:147289:18)
    at __webpack_require__ (/home/templth/work/repositories/git/theglobetrotterturtle/myproject-website/dist/server.js:146581:30)
    at /home/templth/work/repositories/git/theglobetrotterturtle/myproject-website/dist/server.js:146645:18
    at Object.<anonymous> (/home/templth/work/repositories/git/theglobetrotterturtle/myproject-website/dist/server.js:146648:10)
    at __webpack_require__ (/home/templth/work/repositories/git/theglobetrotterturtle/myproject-website/dist/server.js:20:30)
    at Module.<anonymous> (/home/templth/work/repositories/git/theglobetrotterturtle/myproject-website/dist/server.js:163:20)
    at __webpack_require__ (/home/templth/work/repositories/git/theglobetrotterturtle/myproject-website/dist/server.js:20:30)

I investiguated a bit the problem and it seems that there are the following calls when launching the server script:
enableProdMode();
enableProdMode();
isDevMode();
enableProdMode();

Notice that I don't call isDevMode() myself...
If I updated the isDevMode in the generated js file (from ts):
/**
 * Returns whether Angular is in development mode. After called once,
 * the value is locked and won't change any more.
 *
 * By default, this is true, unless a user calls `enableProdMode` before calling this.
 *
 * @experimental APIs related to application bootstrap are currently under review.
 */
function isDevMode() {
    //_runModeLocked = true; <------------
    return _devMode;
}

the server starts correctly and the environment variables are taken into account in the server rendering...

Can you please share your main.server.ts?

Sure!
Here it is:
import { enableProdMode } from '@angular/core';

import { environment } from './environments/environment';

if (environment.production) {
  enableProdMode();
}

export { AppServerModule } from './app/app.server.module';

You cannot perform enableProdMode() after the platform has been initialised.
enableProdMode should happen in your server.ts and not in main.server.ts, as the later is too late.
Your main.server.ts, should pretty much contain only:
export {AppServerModule} from './app/app.server.module';

Yes, you're right! It fixed the problem. Thanks very much for your help!


Service discovery

DiscoveredBy decorator for fetch definitions
discoveredBy attribute for  tag
fixed typos

Coverage decreased (-1.3%) to 92.251% when pulling 39624d58ec9d3b93e675e62fb717a6cb2a3c2f12 on service-discovery into 1cf43da6fb30ad998df7a9d5f9e455825dd94556 on master.

Coverage decreased (-1.3%) to 92.245% when pulling 04d322d391a21e71049df14650842747944a40ef on service-discovery into 1cf43da6fb30ad998df7a9d5f9e455825dd94556 on master.

Coverage decreased (-1.3%) to 92.245% when pulling 04d322d391a21e71049df14650842747944a40ef on service-discovery into 1cf43da6fb30ad998df7a9d5f9e455825dd94556 on master.

+1

Coverage decreased (-0.7%) to 92.852% when pulling 15d7ac12b4a65ba4a62052b25a6a6c529f54f20b on service-discovery into 1cf43da6fb30ad998df7a9d5f9e455825dd94556 on master.

Coverage decreased (-0.4%) to 93.122% when pulling cc53808a13198707fde6ddef67d2d9095e73fd3b on service-discovery into 1cf43da6fb30ad998df7a9d5f9e455825dd94556 on master.


Deploy Flutter AppStore with libusb (M1)

Error  (no such file)
Library not loaded: /opt/homebrew/opt/libusb/lib/libusb-1.0.0.dylib
Referenced from: <08E9B59C-29B6-32C6-B2D8-DCD81153FE85> /Volumes/Data/Projects/SWTH/qipos/build/macos/Build/Products/Debug/QiPOS Anywhere.app/Contents/MacOS/QiPOS Anywhere
Reason: tried: '/opt/homebrew/opt/libusb/lib/libusb-1.0.0.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/opt/homebrew/opt/libusb/lib/libusb-1.0.0.dylib' (no such file), '/opt/homebrew/opt/libusb/lib/libusb-1.0.0.dylib' (no such file), '/usr/local/lib/libusb-1.0.0.dylib' (no such file), '/usr/lib/libusb-1.0.0.dylib' (no such file, not in dyld cache)
But solved by user already install or pre install lib before (brew install libusb)
How to add install lib or included lib with deployment in flutter app?
Apple store support can not install libusb outsite store for approve flutter app..

I have faced the same problem but I fixed it by removing
s.vendored_libraries = 'libusb-1.0.23.dylib', 'libusb-1.0.23-m1.dylib'
this line from macos/quick_usb.podspec here and manually add the lib with following
https://docs.flutter.dev/platform-integration/macos/c-interop
this guideline, and if you are publishing for intel too, check that libusb-1.0.0.dylib library supports intel or not or you can modify code like this
 QuickUsbMacos() {     if(Platform.version.contains('arm64')) {       _libusb = Libusb(DynamicLibrary.open('libusb-1.0.23-m1.dylib'));     } else {       _libusb = Libusb(DynamicLibrary.open('libusb-1.0.23.dylib'));     }   }
in lib/src/quick_usb_desktop.dart this file


[Request] Don't uglify code for npm

There is no real benefit in uglifying code before shipping it.
It just makes life worse for me when investigating into the source code.

@smitetierlist m8 pls. https://github.com/hydrabolt/discord.js/tree/master/src

NPM is for shipping production versions, not for development. If you want source, source folder

As it's in NPM and being shipped for production, I won't stop uglifying code - it minifies it for production to reduce the overall size of your application. If you want the source code, please see the links @TehSeph and @abalabahaha have posted.
Please also know that the API is going under a rewrite, so if you want to see the latest developments please check the rewrite branch.

We like ugly code ;)

Okay, I'll accept that.
Anyway: what is the benefit of uglifying the code? It's a very small code base.
When one really wants to run uglified code on a server (I don't see any benefit here) they could implement it easily in their deploy script.
Rewrite branch: Do you have planned / expect massive breaking changes? I'm just starting my new project.

@smitetierlist I believe from Discord chats that there will be a major stability overhaul in the coming 5.x rewrite, so probably breaking changes.
You could ask the dev and other programmer people questions on the Discord API server linked in the README, probably will get a faster response.

@smiteteirlist there are general breaking changes all around, but most will only take a few minutes to fix so I'd say your safe to start with the master branch as it has docs etc

@smitetierlist ^^