Multiple clusters - istio-ingressgateway is unavailable

Bug description
[root@node1 istio-1.4.3]# kubectl get pods --context=$CTX_CLUSTER2 -n istio-system -l istio=ingressgateway
NAME                                    READY   STATUS    RESTARTS   AGE
istio-ingressgateway-5d474c5799-qrx5m   0/1     Running   0          13m

following the example deployment, the result is a failure, i've set up cluster1 watch cluter2.
Expected behavior
the deployment was successful
Steps to reproduce the bug
https://istio.io/docs/setup/install/multicluster/shared-gateways/#setup-cluster-1-primary
follow the steps in the link for deployment
Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
v1.4.3
How was Istio installed?
Multi-cluster deployment
Environment where bug was observed (cloud vendor, OS, etc)
Centos7

 meshNetworks: |-
    # Network config
    networks:
      network1:
        endpoints:
        - fromRegistry: Kubernetes
        gateways:
        # cluster1 Node ip
        - address: <IP_ADDRESS>
          # for port 443
          port: 31697
      network2:
        endpoints:
        - fromRegistry: n2-k8s-config
        gateways:
        # cluster1 Node ip
        - address: <IP_ADDRESS>
          # for port 443
          port: 31218

i updated network1 and network2 and values.yaml，the istio-ingressgateway type is NodePort, so address = 10.20.1.xxx and port = 31xxx
is that the reason?
looking forward to your reply. Thank you!

Check cluster two's gateway logs. It may not be connecting and getting config from the remote pilot.

@ayj
Thanks for your reply. I have fixed this problem according to your reply.
[root@node1 istio-1.4.3]# kubectl get pods --context=$CTX_CLUSTER2 -n istio-system -l istio=ingressgateway
NAME                                    READY   STATUS    RESTARTS   AGE
istio-ingressgateway-5d474c5799-kz65l   1/1     Running   0          19h

But it doesn't forward traffic to v2 anyway do you know why? neither cluster1 nor cluster2 could forward traffic to the helloworld sample v2
[root@node1 istio-1.4.3]# kubectl exec --context=$CTX_CLUSTER1 -it -n sample -c sleep $(kubectl get pod --context=$CTX_CLUSTER1 -n sample -l app=sleep -o jsonpath='{.items[0].metadata.name}') -- curl helloworld.sample:5000/hello
Hello version: v1, instance: helloworld-v1-578dd69f69-hbbr8
[root@node1 istio-1.4.3]# kubectl exec --context=$CTX_CLUSTER2 -it -n sample -c sleep $(kubectl get pod --context=$CTX_CLUSTER2 -n sample -l app=sleep -o jsonpath='{.items[0].metadata.name}') -- curl helloworld.sample:5000/hello
Hello version: v1, instance: helloworld-v1-578dd69f69-hbbr8
[root@node1 istio-1.4.3]# kubectl exec --context=$CTX_CLUSTER1 -it -n sample -c sleep $(kubectl get pod --context=$CTX_CLUSTER1 -n sample -l app=sleep -o jsonpath='{.items[0].metadata.name}') -- curl helloworld.sample:5000/hello
Hello version: v1, instance: helloworld-v1-578dd69f69-hbbr8
[root@node1 istio-1.4.3]# kubectl exec --context=$CTX_CLUSTER2 -it -n sample -c sleep $(kubectl get pod --context=$CTX_CLUSTER2 -n sample -l app=sleep -o jsonpath='{.items[0].metadata.name}') -- curl helloworld.sample:5000/hello
Hello version: v1, instance: helloworld-v1-578dd69f69-hbbr8
[root@node1 istio-1.4.3]# kubectl exec --context=$CTX_CLUSTER2 -it -n sample -c sleep $(kubectl get pod --context=$CTX_CLUSTER2 -n sample -l app=sleep -o jsonpath='{.items[0].metadata.name}') -- curl helloworld.sample:5000/hello
Hello version: v1, instance: helloworld-v1-578dd69f69-hbbr8

go to cluster1 sleep pod for execution
[root@node1 istio-1.4.3]# kubectl exec -it sleep-f8cbf5b76-h69th sh -n sample
Defaulting container name to sleep.
Use 'kubectl describe pod/sleep-f8cbf5b76-h69th -n sample' to see all of the containers in this pod.
/ # curl helloworld.sample:5000/hello
Hello version: v1, instance: helloworld-v1-578dd69f69-hbbr8
/ # curl <IP_ADDRESS>:5000/hello
upstream connect error or disconnect/reset before headers. reset reason: connection failure

go to cluster2 sleep pod for execution
[root@node4 istio-1.4.3]# kubectl exec -it sleep-f8cbf5b76-9vpw6 sh -n sample
Defaulting container name to sleep.
Use 'kubectl describe pod/sleep-f8cbf5b76-9vpw6 -n sample' to see all of the containers in this pod.
/ # curl helloworld.sample:5000/hello
Hello version: v1, instance: helloworld-v1-578dd69f69-hbbr8
/ # curl <IP_ADDRESS>:5000/hello
Hello version: v2, instance: helloworld-v2-776f74c475-nqw6j

<IP_ADDRESS> is a cluster ip，i wonder if there is an error in DNS mapping, or the pilot doesn't issue rules?

/cc @ayj

@xichengliudui Hi would you mind explaining how did you get the ingressgateway running? I am having the same problem using nodePort with kubernetes v1.17.  From my logs, cluster 1 has sent the config but cluster 2 did not receive that:
from cluster 1 pilot-discovery log
mesh networks configuration post-resolution (*v1alpha1.MeshNetworks)(0xc0013b13b0)(networks:<key:"network1" value:<endpoints:<from_registry:"Kubernetes" > gateways:<address:"xx" port:32534 > > > networks:<key:"network2" value:<endpoints:<from_registry:"n2-k8s-config" > gateways:<address:"xy" port:30029 > > > )

from cluster 2 ingressgateway log
2020-03-10T15:18:37.372141Z	info	Envoy proxy is NOT ready: config not received from Pilot (is Pilot running?): cds updates: 0 successful, 0 rejected; lds updates: 0 successful, 0 rejected
[Envoy (Epoch 0)] [2020-03-10 15:18:37.589][22][warning][config] [bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:91] gRPC config stream closed: 14, upstream connect error or disconnect/reset before headers. reset reason: connection failure

I also find out that the cluster2 443 port is filtered even if I query locally. let me know if you have the same issue.
$ nmap -Pn -p 30029 localhost

Starting Nmap 7.60 ( https://nmap.org ) at 2020-03-10 13:22 PDT
Nmap scan report for localhost (<IP_ADDRESS>)
Host is up.
Other addresses for localhost (not scanned): ::1

PORT      STATE    SERVICE
30029/tcp filtered unknown


Parts/add part component

Card component & card list component, not completely finished with styling but we can work off this and tweak later.

Also, don't forget to merge in origin/develop to bring in Meng and Glenn's schema changes


Display program change numbers as 1-128 not 0-127

Program numbers should be displayed to the user in the range 1-128, even though internally they are 0-127.  Most devices and apps use 1-128.
Perhaps add a preference like MainStage does:
https://support.apple.com/kb/PH13676?locale=en_US&viewlocale=en_US

Released (finally) in versions 1.4 of both apps.


package com.intellijava.com.intellijava.core.controller does not exist

I am trying to integrate this plugin onto my maven project, I have tried both the ways suggested by you but, it looks like the plugin is not being fetched when I perform clean install. Please let me know if I am doing something wrong here, thanks.
PFA for the error:

I have added the plugin as an external library

I tried adding it as a maven dependency as well

The issue your code trying to read the package from repo.maven.apache.org/maven2 not from the Github packages.
This is the documentation to install a package published only in Github:
https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-apache-maven-registry#authenticating-to-github-packages

This was really helpful, thanks.


Fix for language provider text -non sql family too

This PR fixes #
Fix for language provider text to include non sql languages too

Pull Request Test Coverage Report for Build 233537940

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 39.052%

Totals

Change from base Build 233489466:
0.02%

Covered Lines:
18917

Relevant Lines:
44282

💛  - Coveralls

Approved.


Remove return

https://sonarcloud.io/project/issues?id=Cinimex-Informatica_mq-java-exporter&issues=AWlSW91Ue1QvbR9zifOC&open=AWlSW91Ue1QvbR9zifOC

The issue is tested and closed.


Unsafe use of relative rpath problem on Mac OS X

After the changes introduced as part of #25 this issue does not seem to appear


feat(derive): bump op-alloy dep

#605  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on  Graphite


[Deprecate] DataLoader.population() and PopulationData class

Summary of request
With #851, users will not use PopulationData when loading local CSV files. In addition, JHUData includes population values and PopulationData/DataLoader.population() are not used for calculation of the number of susceptible cases.
The current Version
CovsirPhy version: 2.21.0-xi-fu1

population_data argument of Scenario and (DataHandler) will be also deprecated.

ModelValidator will be free from PopulationData class internally.


Fix schema output of update creator functions

Fixes #176
Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the
hard-to-understand areas.
[x] (If necessary) I have updated the CHANGELOG.

Fixed in browser wallet API instead: https://github.com/Concordium/concordium-browser-wallet/pull/308


Introduce startEngagementWithConfig method with queueIds array

Jira issue:
https://glia.atlassian.net/browse/MOB-2761
What was solved?
Previously passing queues array was moved from configure method to startEngagement one. But startEngagementWithConfig was missed and was not extended by queueIds param.
That PR introduces new startEngagementWithConfig with queueIds params, deprecate previous public method.
Migration guide should enforce integrators use new interface, because due to "Re-create interactor" further changes will not be able to use old configure, startEngagement and startEngagementWithConfig methods.
Release notes:

[ ] Feature
[ ] Ignore
[ ] Release notes (Is it clear from the description here?)
[x] Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

[ ] Tests fixed, added? Unit, acceptance, snapshots?
[ ] Logging necessary for future troubleshooting of customer issues added?

Screenshots:

!squash


AVRO-3425: Extend C# avrogen namespace mapping to models and members as well

Make sure you have checked all steps below.
Jira

[X] My PR addresses the following Avro Jira

https://issues.apache.org/jira/browse/AVRO-3425
In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[X] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain Javadoc that explain what it does

Potentially fixes:
https://issues.apache.org/jira/browse/AVRO-2883
https://issues.apache.org/jira/browse/AVRO-3046

This rework changes how the namespace mapping is done. In this approach all the "namespace" definitions in the original schema definition text are replaced by the new mapped namespace name, before the schamea is even parsed.

@martin-g I think it is ready for review:
Added several avrogen related tests:

Command line sanity checks
Exit codes
Compiling several schema files and checking the generated types and source files, and directory structure
Making sure that the generated code form the cs files can instantiate  all the objects  generated by avrogen
Making sure that namespace mapping works with #3 and #4
Revived the disabled cunit tests which were commented out because of teh DOM compiler does not work on net core app (replaced by the runtime roslyn compiler)


Include sanitised supplier name in agreement document filename

CCS use supplier name to organise their work, so they need it to be included in the filename for the returned agreement documents.
This is exactly the same method used in the script to generate the framework agreement data.
I have confirmed with Chris at CCS that the filename format generated here is good for them to work with.

:+1:


Fix documentation formatting

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   65.18%   65.18%
=======================================
  Files           4        4
  Lines         247      247
=======================================
  Hits          161      161
  Misses         86       86

Flag
Coverage Δ

#Configuration
65.18% <ø> (ø)
:arrow_up:

#TestProgram
65.18% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

...Configuration/Deserializers/JSONDeserializer.swift
100% <ø> (ø)
:arrow_up:

...onfiguration/Deserializers/PLISTDeserializer.swift
100% <ø> (ø)
:arrow_up:

Sources/Configuration/ConfigurationManager.swift
41.4% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90cb5cd...0d635b4. Read the comment docs.


rfc: rename deployment event to promote, add rollback event

The deployment event type seems to be causing some confusion. People read the documentation trying to answer the question "how do I deploy with drone" and they read the section about deployment events, which is generally not what they are looking for.
I think using promotion would reduce terminology confusion and more accurately describes how the system is actually working. We are promoting build X to environment Y ...
- drone promote foo/bar 12 production
+ drone deploy foo/bar 12 production

pipeline:
  deploy:
    ...
    when:
-     event: deployment
+     event: promote

I would also like to introduce a rollback event. This would allow you to explicitly rollback to a previous version. The behavior would be similar to promote, except that you could use the event type in your pipeline to perform a different set of actions ...
drone rollback foo/bar 12 production

IMPORTANT we should be able to implement this without breaking anything. When drone encounters deployment it can automatically convert it to promotion behind the scenes

tldr; In considering an additional event type, perhaps we should consider user-specified event types instead.
I've sometimes wished we had a more general way to trigger an arbitrary event type. The deploy event type has always felt like an odd duck to me. In considering additional event types that are arbitrary to some users (we always roll forward, never back), I wonder if we're better off with something more general.
I think being able to trigger pre-defined (by the user) event types, potentially passing params/args would satisfy deploy/rollback and other workloads:
drone trigger <event-type> <repo> <build-id> -p <var>=<val>

Where <event-type> could either be arbitrary, or one of a number of pre-configured (by env var) event types.
For example, mimicking our current deploy event:
drone trigger deploy foo/bar 12 -p TARGET=production -p DIRECTION=forward
drone trigger deploy foo/bar 12 -p TARGET=production -p DIRECTION=back

Or if the user wanted to go a slightly different route:
drone trigger deploy foo/bar 12 -p TARGET=production
drone trigger rollback foo/bar 12 -p TARGET=production

Or maybe I want to do something weird like
drone trigger only-deploy-s3-assets foo/bar 12

I could have my s3 publishing step's when selector be something like [deploy, only-deploy-s3-assets], easily allowing partial deploy/publication without plugin modification.

and just to support my claim above that deployment event types are causing confusion. From the gitter room today:

I have a question about deployments. I am reading the doco ( http://docs.drone.io/deployments/) and from my understanding the only way to trigger deployment to dev/staging/prodction is to use command line "drone deploy   ”. Could you please confirm/clarify if there is another way? Can deployment triggered automaticly based on certain conditions?

@gtaylor yes I agree. It is something we need to unwind carefully since there are security implications with regard to secrets being exposed. But agree that we seem to be working toward something more flexible, and might as well just embrace it.

I'm going through an upgrade from 0.8 to 1.2 and have a couple questions related to this issue. Hope it's OK that I'm commenting here even though it's closed.

It appears that the event name deployment is no longer valid based on the behavior I see. Was this supposed to be backwards compatible? I am not able to run steps that were working in 0.8 with the deployment event trigger.

Is there a way to make the webhook listen for deployment events by default? In 0.8 there I had to check the box in repo settings, but the UI and CLI don't seem to support this. My current workaround is to enable is on the webhook settings in github, but that seems a bit fragile if I need to recreate this webhook later.

Is there a way to make the webhook listen for deployment events by default? In 0.8 there I had to check the box in repo settings, but the UI and CLI don't seem to support this. My current workaround is to enable is on the webhook settings in github, but that seems a bit fragile if I need to recreate this webhook later.

this was fixed in master and in the :latest docker image.

It appears that the event name deployment is no longer valid based on the behavior I see. Was this supposed to be backwards compatible? I am not able to run steps that were working in 0.8 with the deployment event trigger.

the event was renamed to promote because it more accurately described how most people were using deployments with Drone.


Mixxx 2.3

PR will remain open until Mixxx 2.4 is released (or close to release)

Hi fayaaz.
I love your work, and I have your mixxx-pi-gen with my standalone ddj 400 and raspberry 4.
But, could you update your image with Mixxx 2.4 alpha version??  I would like to add Pioneered-Plus skin and it needs mixxx 2.4 version... I don't know how to upate it. Here the skin project https://github.com/bencejuhaasz/Pioneered-Plus
Thanks for you effort.
Regards ;)


Is there a way to make lazytainer "proxy" udp ports?

Hello,
I have a minecraft server working fine with lazytainer, but i struggle adding simple voice chat to it, which uses an udp port to work.
How can I have this udp port sent through lazytainer to the minecraft voice chat add on?
I have not been able to find info on udp ports in the doc...
Thanks in advance for your help !
Felix

Lazytainer doesn't distinguish between types of network traffic.
You should just be able to add on the additional port after a comma like so
    - "lazytainer.group.<yourGroup>.ports=25565,<voiceChatPort>"

If that doesn't work for you, send me your docker compose and I can take a more thorough look.

Hello,
Thanks for your help, I added the UDP port as you mentionned and everything is working flawlessly!
May I suggest you mention in the readme that the ports are not only tcp, but udp as well?
Apart from that, thanks for lazytainer, which is reeally useful and powerful
Felix

Where in the docs do you think that should go?
You're also welcome to add it in a PR and I'll take a look.


fix(test): compliance upgrade unexpected

Description
unexpected text showed up on upgrade.  Should have returned nil instead of error
Checklist

[ ] Investigated and inspected CI test results
~- [ ] Unit test and regression tests added~
~- [ ] Evaluated and added CHANGELOG entry if required~
~- [ ] Determined and documented upgrade steps~
~- [ ] Documented user facing changes (create PR based on [openshift/openshift-docs]~(https://github.com/openshift/openshift-docs) and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
CI
Have you created automated tests for your change? Explain here which validation activities you did manually and why so.
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

/test

/test gke-upgrade-tests

/test gke-qa-e2e-tests
/test gke-upgrade-tests
/test gke-version-compatibility-tests


Button disabled hover state

Describe the bug
Some button colors still have a hover state color change when is disabled. Is this intended? Checking the flowbite.com website, the only example of disabled button there the hover state is completely static.
To Reproduce
Steps to reproduce the behavior:

Add disabled={true} prop to Button component
Check all possible colors
Hover button

Expected behavior
All buttons should not change any text/bg colors when hovering in disabled mode
Screenshots

System information:

Device:
Resolution:
OS:
Browser:
Version:

Project information:

Tailwind: 3.0.0
Flowbite: 1.4.7
Flowbite React: 0.1.2
Type: CRA

@nigellima you are really using flowbite-react 0.1.2? If so, please, update it... It seems that this issue isn't happening in the current version anymore - at least it isn't visible in the documentation.
I'm closing this one as "won't fix", 'cause we don't support previous versions of the library.


SPDLog maked header-only

Parasitic dependency from SPDLog was removed.
RAPIDJSON Windows build fixed.
Target machine architecture detection fixed.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: artiomn:x: Artiom N.Artiom N. seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Advertisement

Adding the sponsor banner requested by @TheLarkInn.
Additions:

Adds a new space for advertisements in the left gutter on larger screens
Hardcoded the ag-grid advertisement into the Advertisement component (however we should be able to make this scale to dynamically pulling advertisements fairly easily if needed)
This new section is responsive and sticky in a very similar manner to the sidebar

The only thing left we might need to do is add a media query to hide the banner on screens smaller than around 1600-1550px to prevent the banner from getting cut off. See gif below for a demo...
Resolves #1033

@TheLarkInn I did tweak the design slightly, I think the light background looks a bit cleaner. It's displayed on all pages except for the home page (there's not really any good place to put it there).

This looks incredible. I'm going to mark as approved. @bebraw should we try and address avoiding ad blockers from affecting that image.

Step one: name the class as something else than advertisement. 👍

Hahaha definitely a good idea, I'll rename this sponsors or sponsor-bar or something.

@TheLarkInn @bebraw renamed the component/class.

@skipjack @bebraw Go ahead and merge now.

@TheLarkInn re-running the build, not sure what those errors were about. Most just looked like network flakiness.

Yeah, sometimes some badge provides goes down. Our system is a bit too strict with those (probably should be filtered out).


User defined datasets documentation

Perhaps we should add a short paragraph about adding user-defined datasets.

Allowing a user to use custom dataset by assigning the path parameter (-cd /dataset/userdefineddataset) might be a better option. In this way, a user can avoid changing the library to apply custom dataset.

Yes, that's probably a better option. This way the user data set can be anywhere in in the file system and not restricted to the dataset directory.

will finish this in #12 .

handled in #12


Add resumeWithoutException to CircuitBreakerFilter

Fixes gh-2047
Resume without exception when CircuitBreaker throw exceptions.

Hi @spencergibb
Could you have a look this PR?


Option on cards to report them

Bad cards come up sometimes- it would be neat if there were a fast way of reporting bad ones; potentially one which doesn't require opening a new website (maybe even a way which doesn't require having a Github account?!)
This could be something like a three dot button on the cards, with a report button, which then gives a number of options. This could then do one of a number of things: generate a comment on a specific Issue thread on here, send an email account run by someone involved with running Wikitrivia, or just generate a template of text which could then be copy pasted into an issue thread

Long term the correct way to fix this would be for it to take you directly to wikidata to encourage you to fix the issue at the source. The cards are not currently periodically recreated though, which is something that would have to happen for that to work.

I came across Phoenician Alphabet (end) and the game said 150, but Wikipedia says 150 BC, so there are some things like that where as far as I know the Wikipedia is probably right, but the game appears to be wrong.


[Feature Request]: Display and update the GitHub repository's live star count.

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
When the user clicks the 'Star me' button, the website retrieves the current star count from GitHub and updates the display in real-time, reflecting the latest number of stars.
Use Case
Given that a link to GitHub already exists, clicking the 'Star me' button to open the repository seems redundant. Instead, we can optimize the process by directly fetching the star count from GitHub and displaying it on our website, eliminating the need for an extra click.
Benefits
Convenience: Users can view the star count without leaving the website or opening the GitHub repository.
Real-time updates: The star count is fetched directly from GitHub, ensuring accuracy and real-time updates.
Improved user experience: Streamlined process reduces clicks and makes it easier for users to view the star count.
Enhanced visibility: Displaying the star count prominently on the website highlights the project's popularity and community support.
Increased engagement: Easy access to the star count may encourage users to contribute to the project or star it on GitHub, fostering community growth.
Reduced redundancy: Eliminates the need for users to click the "Star me" button solely to view the star count, making the feature more efficient.
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

Thank you for creating this issue! 🎉 We'll look into it as soon as possible. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊
You can also check our CONTRIBUTING.md for guidelines on contributing to this project.

On it!

Hey @ashutosh-rath02 do you want the on-click functionality to open the GitHub repo?
As of now, the button renders the live star count

Hey, lemme know if this is good, I'll make a PR

Hello @anniepauline! Your issue #438 has been closed. Thank you for your contribution!


Testing files are not excluded on prod build

Describe the bug
Doing npm run build found that *test.tsx are not being removed from the main build files
Reproduction
Na
Steps to reproduce
No response
System Info
Windows 10

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Also noticed that @testing-library is included in the bundle


tlcpack for Python 3.9

Once the change I'm proposing in https://github.com/tlc-pack/tlcpack/pull/92 is merged, I'd like to suggest we start producing packages with Python 3.9 in the available images, which are all but tlcpack/package-cu100, that is updated only up to Python 3.8.
I'm mostly opening this issue for a discussion, as after #92 is merged, it should a pretty small patch.
@tqchen @areusch @Mousius any concerns?

Gentle ping as this is really a really low effort improvement we can do.

I am supportive

i'm good with that

Sounds great to me!

I renamed it to cover 3.9 for now. Will work on 3.10 later.

As we're now publishing linux wheels for python 3.6 to 3.10, I'll close this.


Add auto-update functionality

Fixes #258
Fixes #451
Fixes #481
It checks for new updates on startup and once every hour. If there is an update, it's downloaded in the background and installed on the next launch.

Does this take care of the whole notifying the user about updating and restarting the app?

Does this take care of the whole notifying the user about updating and restarting the app?

No, I thought we had concluded to have silent auto-updates. Per #481.

I'm okay with no option to check. I mean it does happen automatically. But without a notification when does the update happen? On restart?

though I still think it's useful to have the option to manually check for updates

What practical purpose would it have? We automatically check every hour. If you have a button, users will think they need to click it, so they will waste time doing so. Better to just have good automatic behavior whenever possible.

But without a notification when does the update happen? On restart?

See my PR description.


Sequoai

Hi
I know it's not even out of beta yet, but are there any plans to make this addon work with the new version of macOS?
Thanks

Never mind. it's actually working now. It initially didn't work, but a reboot fixed it.


llama: update llama.cpp to latest version (wip)

This commit updates llama.cpp to the latest/later version.
The motivation for this is that the current version of llama.cpp is a little outdated and there have been changes to the llama.cpp API and also the model format. Currently it is not possible to use the new GGUF format and many of the available models are in this new format which can make it challenging to use this crate at the moment.
The following changes have been made:

update llama.cpp to latest version using git submodule update --remote --merge llama.cpp

Manually copied the generated bindings.rs file from the target directory to the src directory. Hope this was the correct thing to do.

Updated the llm-chain-llama crate to use llama_decode instead of llm_eval which has now been deprecated.

A number of TODOs have been added to the code to highlight areas that I know I need to look at.

This is a work in progress but I wanted to open a draft pull request sooner rather than later to get some visibility and feedback.
Currently I've been able to successfully run the simple example,  few_shot, and stream examples. The map_reduce_llama example is not working as of this writing which I'll look into further.

There's a clause ignoring MaxTokens if MaxTokens == 0 (or rather the reverse). So adding MaxTokens to be equal to MaxContextSize in the examples is redundant. If you want, and its possible, you can try to alter the option to be as big as the context window by default and remove the clause.

So adding MaxTokens to be equal to MaxContextSize in the examples is redundant.

I added a MaxBatchSize option in https://github.com/sobelio/llm-chain/pull/244/commits/452ac2c6d282a95c0c1a038432ec52490c98fd1a, and it has default value of 512 which matches the value in llama.cpp, and have now removed the options from the examples (apart from simple_llama).

If you want, and its possible, you can try to alter the option to be as big as the context window by default and remove the clause.

I'm planning on taking a closer look at the model options today, and I'll also take another look at the context options and your suggestion. Thanks


First Message to isolate getting lost

Hello,
Is there a way for us to check , that isolate is ready ; I mean one thing i have observed is that Isolate loop , doesnt recv the first message.
I have put in print statements , it never hits.

Yes, onInitialized. Does it fire for you in the example app?

Hello,
OnInitialized -- the function runs in the isolate.
How can the main thread know isolate is ready , shall it wait for Isolate to send some message saying I am up
regards

As the comment in the code says:
https://github.com/deakjahn/isolate_handler/blob/a8bf383b90d18199ab36b448fe153ef9fe19986a/lib/src/handled_isolate.dart#L58-L60


[ bug Report ] ELECTRICAL_CABLES do not work

TombEngine version
Development Build
Tomb Editor version
Development Build
Describe the bug
ELECTRICAL_CABLES does not work. it's primary function is to make water room deadly by hurting lara and provide electricity effect on Lara (or kill lara when she touches them)
To Reproduce
put ELECTRICA::_CABLES on the map where cables should touch the water.
Expected Behaviour
the cables should hurt lara accordingly
Additional Content
No response
Minimal reproduction project
not yet

Builder mistake.


Proposal

Can you add the option to buy fractions of lottery tickets?

I mean make the lottery ticket as an nft

So people can also for example sell winning tickets ecc...

Lottery tickets are NFTs already.


supabase-js fails with @sveltejs/kit (warning, sveltejs/kit is experimental)

Bug report
adding
import { createClient } from '@supabase/supabase-js'

into any script tag in a svelte project will cause a 500.
Describe the bug
I believe this has to do with svelte kit renders being executed on both the server side and client side. It also appears to be related to the javascript parser they use (meriyah). Starting the project, and opening a page containing the supabase import results in the following error:
500
[778:36]: Unexpected token: 'get'

SyntaxError: [778:36]: Unexpected token: 'get'
    at report (/home/andrew/Code/development/telebum3/web/node_modules/.pnpm/@sveltejs/kit@1.0.0-next.5/node_modules/node_modules/.pnpm/meriyah@3.0.3/node_modules/meriyah/dist/meriyah.esm.js:182:11)
    at matchOrInsertSemicolon (/home/andrew/Code/development/telebum3/web/node_modules/.pnpm/@sveltejs/kit@1.0.0-next.5/node_modules/node_modules/.pnpm/meriyah@3.0.3/node_modules/meriyah/dist/meriyah.esm.js:2096:9)
    at parseLetIdentOrVarDeclarationStatement (/home/andrew/Code/development/telebum3/web/node_modules/.pnpm/@sveltejs/kit@1.0.0-next.5/node_modules/node_modules/.pnpm/meriyah@3.0.3/node_modules/meriyah/dist/meriyah.esm.js:3024:9)
    at parseStatementListItem (/home/andrew/Code/development/telebum3/web/node_modules/.pnpm/@sveltejs/kit@1.0.0-next.5/node_modules/node_modules/.pnpm/meriyah@3.0.3/node_modules/meriyah/dist/meriyah.esm.js:2595:20)
    at parseBlock (/home/andrew/Code/development/telebum3/web/node_modules/.pnpm/@sveltejs/kit@1.0.0-next.5/node_modules/node_modules/.pnpm/meriyah@3.0.3/node_modules/meriyah/dist/meriyah.esm.js:2692:19)
    at parseTryStatement (/home/andrew/Code/development/telebum3/web/node_modules/.pnpm/@sveltejs/kit@1.0.0-next.5/node_modules/node_modules/.pnpm/meriyah@3.0.3/node_modules/meriyah/dist/meriyah.esm.js:2958:19)
    at parseStatement (/home/andrew/Code/development/telebum3/web/node_modules/.pnpm/@sveltejs/kit@1.0.0-next.5/node_modules/node_modules/.pnpm/meriyah@3.0.3/node_modules/meriyah/dist/meriyah.esm.js:2641:20)
    at parseStatementListItem (/home/andrew/Code/development/telebum3/web/node_modules/.pnpm/@sveltejs/kit@1.0.0-next.5/node_modules/node_modules/.pnpm/meriyah@3.0.3/node_modules/meriyah/dist/meriyah.esm.js:2611:20)
    at parseFunctionBody (/home/andrew/Code/development/telebum3/web/node_modules/.pnpm/@sveltejs/kit@1.0.0-next.5/node_modules/node_modules/.pnpm/meriyah@3.0.3/node_modules/meriyah/dist/meriyah.esm.js:3800:19)
    at parseFunctionExpression (/home/andrew/Code/development/telebum3/web/node_modules/.pnpm/@sveltejs/kit@1.0.0-next.5/node_modules/node_modules/.pnpm/meriyah@3.0.3/node_modules/meriyah/dist/meriyah.esm.js:4389:18)

To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
repro repo: https://github.com/andykais/supabase-svelte-kit-bug-repro

npm install
npm run dev
Go to http://localhost:3000
See error

Expected behavior
supabase should ideally work in both the client and server environments of svelte kit.
Screenshots
N/A
System information

OS: Linux, macOS
Browser: Firefox & Chrome
Version of supabase-js: 1.0.7
Version of Node.js: 14.15.1

Additional context
Note: this is an error that is present in an experimental web framework. It is therefore likely a result of this project not being fully featured. Still, this feels like it is worth tracking.
I attempted dropping the supabase-js built files into the meriyah online compiler to see if the errors were visible there. However it appeared to compile the js code without any issue. There may be specific knobs that svelte kit has tweaked which cause the Unexpected token error, but I am unsure.

on a related note, building the project (as opposed to running the dev server) results in this error:
 andrew  sveltekit-supabase-bug  npm run build

><EMAIL_ADDRESS>build /home/andrew/Code/development/sveltekit-supabase-bug
> svelte-kit build

Transforming...
  ✔ client
  ✔ server
Optimizing...
  ⧗ client
  ⧗ server
> 'process' is imported but could not be bundled
Error: 'process' is imported but could not be bundled
    at error (/home/andrew/Code/development/sveltekit-supabase-bug/node_modules/rollup/dist/shared/rollup.js:5265:30)
    at throwPluginError (/home/andrew/Code/development/sveltekit-supabase-bug/node_modules/rollup/dist/shared/rollup.js:17949:12)
    at Object.error (/home/andrew/Code/development/sveltekit-supabase-bug/node_modules/rollup/dist/shared/rollup.js:18556:24)
    at find_deps (/home/andrew/Code/development/sveltekit-supabase-bug/node_modules/@sveltejs/kit/src/api/build/index.js:164:13)
    at /home/andrew/Code/development/sveltekit-supabase-bug/node_modules/@sveltejs/kit/src/api/build/index.js:159:11
    at Array.forEach (<anonymous>)
    at find_deps (/home/andrew/Code/development/sveltekit-supabase-bug/node_modules/@sveltejs/kit/src/api/build/index.js:154:17)
    at get_deps (/home/andrew/Code/development/sveltekit-supabase-bug/node_modules/@sveltejs/kit/src/api/build/index.js:174:7)
    at /home/andrew/Code/development/sveltekit-supabase-bug/node_modules/@sveltejs/kit/src/api/build/index.js:188:37
    at Array.forEach (<anonymous>)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build: `svelte-kit build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/andrew/.npm/_logs/2020-12-04T19_14_36_594Z-debug.log

which seems to clearly be stating that it is attempting to bundle the built in nodejs module process  for the browser.

The issue from @sveltejs/kit itself
They treat process as external package and prevent snowpack:rollup-plugin-node-process-polyfill handle it for the browser.
From @sveltejs/snowpack-config/snowpack.config.js:
/* ... */
installOptions: {
  // ignore `import fs from 'fs'` etc
  externalPackage: require('module').builtinModules  // NOTE: this include `process` package
},
/* ... */

My workaround for @sveltejs/kit users:
// From your project snowpack.config.js, add this:
// ...
installOptions: {
  externalPackage: require('module').builtinModules.filter(pkg_name => pkg_name !== "process")
},
// ...

My English is not good

The issue from @sveltejs/kit itself
They treat process as external package and prevent snowpack:rollup-plugin-node-process-polyfill handle it for the browser.
From @sveltejs/snowpack-config/snowpack.config.js:
/* ... */
installOptions: {
  // ignore `import fs from 'fs'` etc
  externalPackage: require('module').builtinModules  // NOTE: this include `process` package
},
/* ... */

My workaround for @sveltejs/kit users:
// From your project snowpack.config.js, add this:
// ...
installOptions: {
  externalPackage: require('module').builtinModules.filter(pkg_name => pkg_name !== "process")
},
// ...

My English is not good

Hey @langbamit  I just released a new version. Can you please reinstall supabase npm install @supabase/supabase-js@latest and try again?

Hey @langbamit  I just released a new version. Can you please reinstall supabase npm install @supabase/supabase-js@latest and try again?

@kiwicopple, @langbamit thanks for your help. I just updated the deps to latest and added the suggested fix to my snowpack.config.js, I still see the same error.
 andrew  sveltekit-supabase-bug  npm ls --depth=0
<EMAIL_ADDRESS>/home/andrew/Code/development/sveltekit-supabase-bug
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
I have updated the repro repo here https://github.com/andykais/supabase-svelte-kit-bug-repro

@kiwicopple, @langbamit thanks for your help. I just updated the deps to latest and added the suggested fix to my snowpack.config.js, I still see the same error.
 andrew  sveltekit-supabase-bug  npm ls --depth=0
<EMAIL_ADDRESS>/home/andrew/Code/development/sveltekit-supabase-bug
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
I have updated the repro repo here https://github.com/andykais/supabase-svelte-kit-bug-repro

SyntaxError: [778:36]: Unexpected token: 'get'
This issue related to https://github.com/meriyah/meriyah/issues/164 issue, which is fixed in v4.0.0.
We can't testing it by add resolutions: { "meriyah": "4.0.0" } to prepro repo, because @sveltejs/kit bundled this package inside their code (svelte-kit still in alpha state)
I think we can close this issue now.

SyntaxError: [778:36]: Unexpected token: 'get'
This issue related to https://github.com/meriyah/meriyah/issues/164 issue, which is fixed in v4.0.0.
We can't testing it by add resolutions: { "meriyah": "4.0.0" } to prepro repo, because @sveltejs/kit bundled this package inside their code (svelte-kit still in alpha state)
I think we can close this issue now.

This issue should be closed and opened if it still persists with the open beta version of sveltekit. Should be noted that they dropped Snowpack and use Vite instead (https://github.com/vitejs/vite)

hi, yes there is still an issue with the public beta version of sveltekit (or more probably, vite)
this is the error that happens when i require supabase in node:
500
ENOENT: no such file or directory, open<EMAIL_ADDRESS>
Error: ENOENT: no such file or directory, open<EMAIL_ADDRESS>

Here's a related issue in Vite: https://github.com/vitejs/vite/issues/2639

FWIW -  installing as a dev dependency seems to resolve the issue in my SvelteKit project: npm install -D @supabase/supabase-js.

Instead of your import, maybe:
const {createClient} = __supabase;```

[Idea from here](https://redfin.engineering/node-modules-at-war-why-commonjs-and-es-modules-cant-get-along-9617135eeca1).

@mankins - unfortunately this doesn't seem to work, neither with supabase-js as a dev dependency nor as a prod dependency.

I found this note in the SvelteKit FAQ which may be relevant:

question: How do I fix the error I'm getting trying to include a package?
Most of these issues come from Vite trying to deal with non-ESM libraries. You may find helpful examples in the Vite issue tracker. The most common solutions would be to try moving the package between dependencies and devDependencies or trying to include or exclude it in optimizeDeps. Packages which use exports instead of module.exports are currently failing due to a known Vite issue. You should also consider asking the library author to distribute an ESM version of their package or even converting the source for the package entirely to ESM.
You should also add any Svelte components to ssr.noExternal. We hope to do this automatically in the future by detecting the svelte field in a package's package.json.
As suggested, I just tried to include or exclude @supabase/supabase-jsin optimizeDeps in my svelte.config.cjs under vite but this not only didn't work for prod, it also broke the previously working npm run dev.
That leads me to wonder if somewhere in the dependency tree, we need to ask some package maintainer to provide ESM support?

This bug report is old. It's from when SvelteKit was built on top of Snowpack. SvelteKit is now built on Vite and meriyah was removed as part of that transition: https://github.com/sveltejs/kit/pull/409. I can't find meriyah in the SvelteKit dependencies anymore. Can you make sure you're using the latest version of SvelteKit? If so, and there's still an issue, can you share the new stack trace?

Oh, nevermind. I see the comment above that there was a new error: https://github.com/supabase/supabase-js/issues/89#issuecomment-807151173. But then I'm really confused because the next message says it's been fixed: https://github.com/supabase/supabase-js/issues/89#issuecomment-809385143
I think we should probably file a new issue and close this one which has gotten quite muddled. I can't tell what issue exists if any

Yeah it seems a similar issue is happening in Vite; it has to do with the bundler managing a mixture of CSJ and ESM modules as far as I can tell. Someone mentioned this is a growing pain for these next generation build tools which leveral native ESM imports.
I'll try and draft a new issue on this topic today still; I'm collecting as much info as I can to elucidate it.

If you're using SvelteKit's adapter-node or adapter-static you can use the trick of putting Supabase in devDependencies as a workaround. For everyone else I believe you will need Supabase's sourcemap to be fixed and this issue should be closed in favor of https://github.com/supabase/supabase-js/issues/153

OK #153 is resolved now 👍 . Let me know if this one can also be closed

Now that the sourcemap issue has been fixed we can see the real underlying error which is https://github.com/supabase/supabase-js/issues/155. I think this issue could be closed in favor of that one


Tweaks on Teams banner

@keybase/react-hackers
cc @malgorithms @adamjspooner I changed the copy a bit since it's no longer new and left-aligned the content on desktop.

@buoyad Good catch!


DOC:Missing Code Of Conduct file

What's wrong with the existing documentation
A code of conduct file is necessary for smoother contribution and collaboration, reducing conflicts which is missing in this repository. Please assign this issue under GSSOC '24
Add ScreenShots
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

there is a file under information folder


data(war): new steps

This PR adds the datasets needed for the History of War project. These consist of 12 datasets, which we label with the new namespace war.

7 datasets are ported from transcriptions made by Joe in a Google spreadsheet. We use this process as the data was manually extracted from old resources (such as papers, books, etc.). These are Bouthoul and Carrere, Clodfelter, Dunnigan and Martel, ORAE, Eckhardt, Sorokin and Sutton.
The remaining five datasets (Brecke, Prio v1.0, Prio v3.1, CoW and UCDP) are available online; thus, we follow the usual procedure.

This follows previous PRs:

https://github.com/owid/etl/pull/754: Work on snapshots manually porting data files from Google spreadsheets.
https://github.com/owid/etl/pull/762: Work on formatting snapshot data files into Meadow-friendly datasets.

This PR focusses on implementing the remaining steps so that all the datasets are available in Garden.

Thanks, @larsyencken! Indeed, further harmonisation is needed. I will link your comment in the topic issue.


Load testing in a k8s distributed setup

Description
Need to setup the AKS cluster with following components.

Auto scalable GW cluster
HA Control pane cluster
Netty service as the backend service
Azure Cache for Redis as the server

Affected Component
None
Version
No response
Related Issues
No response
Suggested Labels
No response

Closing as tracked in duplicate entry https://github.com/wso2/api-manager/issues/2041


Error when using it on Linux (Ubuntu)

I tried using this app in Linux and it is not working. I got the following error:
Are you sure you want to completely replace your shop theme assets? This is not undoable.
Continue? (Y/N):  Y
/usr/lib/ruby/gems/1.9.1/gems/shopify_theme-0.0.21/lib/shopify_theme.rb:57:in `asset_list': undefined method `collect' for nil:NilClass (NoMethodError)
	from /usr/lib/ruby/gems/1.9.1/gems/shopify_theme-0.0.21/lib/shopify_theme/cli.rb:115:in `replace'
	from /usr/lib/ruby/gems/1.9.1/gems/thor-0.19.1/lib/thor/command.rb:27:in `run'
	from /usr/lib/ruby/gems/1.9.1/gems/thor-0.19.1/lib/thor/invocation.rb:126:in `invoke_command'
	from /usr/lib/ruby/gems/1.9.1/gems/thor-0.19.1/lib/thor.rb:359:in `dispatch'
	from /usr/lib/ruby/gems/1.9.1/gems/thor-0.19.1/lib/thor/base.rb:440:in `start'
	from /usr/lib/ruby/gems/1.9.1/gems/shopify_theme-0.0.21/bin/theme:24:in `<top (required)>'
	from /usr/bin/theme:23:in `load'
	from /usr/bin/theme:23:in `<main>'

Is this because the app is not supported on Linux or something else?

The gem should just work on linux. What version of ruby are you running (ruby -v)? I know it works on at least 1.9.3, could you perhaps be on an older version?

1.9.3p484

I'm not sure what could be going on here. Perhaps your credentials are invalid?
The go version I'm maintaining let's you connect to a proxy like mitmproxy to help with debugging. Perhaps give that one a try instead?

This is a late update, but your configuration was probably incorrect.
The error messages definitely need to be improved, instead of barfing out random Ruby stack traces.
Make sure your config.yml file is in the same directory as where you are running the command. Also be sure your configuration is setup correctly. We have information about this on the readme


dbt snapshot fails with databricks delta

Describe the bug
I was trying to run dbt snapshot and came across a strange issue with the below error.
Error running query: org.apache.spark.sql.AnalysisException: Reference 'snapshotted_data.dbt_unique_key' is ambiguous, could be: snapshotted_data.dbt_unique_key, snapshotted_data.dbt_unique_key.; line 145 pos 33

First Iteration :
There is no snapshot table and table gets created with audit columns (dbt_scd_id, dbt_updated_at, dbt_valid_from, dbt_valid_to)
Second Iteration :
The snapshot process runs fine (with or without changing the source data) but two additional audit columns gets added (dbt_change_type, dbt_unique_key).
Third Iteration :
The job fails with the error message.
Reference 'snapshotted_data.dbt_unique_key' is ambiguous, could be: snapshotted_data.dbt_unique_key, snapshotted_data.dbt_unique_key

Steps To Reproduce
Model :
{% snapshot test_snapshot %}

    {{
        config(
          strategy='check',
          unique_key='id',
          file_format='delta',
          invalidate_hard_deletes=True,
          check_cols='all',
        )
    }}

    SELECT *
    FROM {{ ref('test') }}

{% endsnapshot %}

Databricks Cluster :
Cloud : AWS
Databricks Runtime : 7.6 (includes Apache Spark 3.0.1, Scala 2.12)
Connection Method  : http
Expected behavior
Snapshot should be created as expected.
Screenshots and log output
If applicable, add screenshots or log output to help explain your problem.
The output of dbt --version:
> dbt --version
installed version: 0.19.1
   latest version: 0.19.1

Up to date!

Plugins:
  - bigquery: 0.19.0
  - snowflake: 0.19.0
  - redshift: 0.19.0
  - postgres: 0.19.0
  - spark: 0.19.1

The operating system you're using:
The output of python --version:
> python --version
Python 3.8.0

Additional context
Slack Conversation here.

Thanks for opening the issue @deeprout, and for the detailed bug report! I figured out what's going on here.
In fact, the dbt snapshot table should never contain the columns dbt_unique_key or dbt_change_type. They are temporary fields, created in the staging table of inserts/updates/deletes, for use during the merge, and then thrown away.
But because of the way we've implemented spark__snapshot_merge_sql, dbt tries to insert those columns when merging:
https://github.com/fishtown-analytics/dbt-spark/blob/6ad164b315748fef7c0ae0b87ff6b8292632f35e/dbt/include/spark/macros/materializations/snapshot.sql#L15-L30
Why? Because Delta's Merge implementation is very good, it allows for insert *, and—here's my conjecture—if you've turned on schema evolution for merges, that insert * will add any columns from the source table that missing in the target table. Does that sound right to you? (I haven't been able to reproduce this exact piece.) If so, that schema evolution is very cool, and it's also what's tripping us up here!
I think the fix would be to change the insert logic from insert * to inserting the insert_cols by name. In fact, that's how the default implementation works today, so the resolution to this issue could simply be: Delete spark__snapshot_merge_sql. All of it. The dbt-spark adapter will use default__snapshot_merge_sql instead, and everything should work just fine.
Is that a fix you'd be interested in contributing?

@jtcohen6 any news on this? :)

Is it possible to reopen this issue? still getting the error when
 spark.databricks.delta.schema.autoMerge.enabled=false
the erro is the following:
 Error message: org.apache.spark.sql.AnalysisException: Reference 'snapshotted_data.dbt_unique_key' is ambiguous, could be: snapshotted_data.dbt_unique_key, snapshotted_data.dbt_unique_key.; line 85 pos 33


TypeError: unsupported operand type(s) for +: 'EarlyStopping' and 'list'

Thanks so much for coming here to raise an issue. Please take a moment to 'check' the below boxes:

[x] I'm up-to-date with the latest release:
pip install -U talos

[x] I've confirmed that my Keras model works outside of Talos.

If you still have an error, please submit complete trace and a code with:

output of shape for x and y e.g. (212,12)
Talos params dictionary
The Keras model wired for Talos
Description of extra variables in the model

You can provide the code in pastebin / gist or any other format you like.
This is the whole code. It works when I remove the early_stopping but I'd like to use it!
Thanks so much.
https://towardsdatascience.com/hyperparameter-optimization-with-keras-b82e6364ca53
Function to create model, required for KerasClassifier
def get_model(x_train, y_train, x_val, y_val, params):
create model
#parameters defined
lr = params['lr']
epochs= params['epochs']
neurons = params['neurons']
optimizer = params['optimizer']
loss= params['loss']
decay = params['decay']
momentum=params['momentum']
batch_size = params['batch_size']
dropout_rate = params['dropout']

input_shape = X_train.shape[1]

model = Sequential()
model.add(Dense(neurons, input_shape = (input_shape,))),
model.add(LeakyReLU(alpha=0.01)),
model.add(BatchNormalization()),

model.add(Dropout(dropout_rate, seed=42)),
model.add(Dense(neurons)),
model.add(LeakyReLU(alpha=0.01)),
model.add(BatchNormalization()),

model.add(Dropout(dropout_rate, seed=42)),
model.add(Dense(neurons)),
model.add(LeakyReLU(alpha=0.01)),
model.add(BatchNormalization()),

model.add(Dropout(dropout_rate, seed=42)),
model.add(Dense(neurons)),
model.add(LeakyReLU(alpha=0.01)),
model.add(BatchNormalization()),

model.add(Dropout(dropout_rate, seed=42)),
model.add(Dense(neurons)),
model.add(LeakyReLU(alpha=0.01)),
model.add(BatchNormalization()),

model.add(Dropout(dropout_rate, seed=42)),
model.add(Dense(5, activation='softmax'))
# Compile model

# https://stackoverflow.com/questions/54377668/talosreturnerror-talos-make-sure-that-input-model-returns-out-model-model-f

if optimizer=="Adam":
        opt=keras.optimizers.Adam(lr=lr, beta_1=0.9, beta_2=0.999)
if optimizer=="Adagrad":
        opt=keras.optimizers.Adagrad(lr=lr, epsilon=None, decay=decay)
if optimizer=="sgd":
        opt=keras.optimizers.SGD(lr=lr, momentum=momentum, decay=decay, nesterov=False)

model.compile(loss=loss,optimizer=opt,
             metrics=['accuracy'])

history = model.fit(x = x_train, y= y_train, validation_data=[x_val, y_val],
                    epochs=params['epochs'], batch_size = batch_size,verbose=1,callbacks=early_stopper(params['epochs']))

return history, model

p = {'lr': [0.0001],
'neurons':[1200,1500],
'decay':[0],
'optimizer': ["Adam"],
'hidden_layers':[3],
'momentum': [0.0],
'batch_size': [128],
'loss': ["sparse_categorical_crossentropy"],
'epochs': [250],
'dropout': [0.2,0.3]}
t = ta.Scan(x=X_train, y=y_train, params = p, model=get_model)

TypeError                                 Traceback (most recent call last)
 in ()
77
78
---> 79 t = ta.Scan(x=X_train, y=y_train, params = p, model=get_model)
7 frames
/usr/local/lib/python3.6/dist-packages/talos/scan/Scan.py in init(self, x, y, params, model, experiment_name, x_val, y_val, val_split, random_method, performance_target, fraction_limit, round_limit, time_limit, boolean_limit, reduction_method, reduction_interval, reduction_window, reduction_threshold, reduction_metric, minimize_loss, seed, clear_session, disable_progress_bar, print_params, debug)
170         # input parameters section ends
171
--> 172         self.runtime()
173
174     def runtime(self):
/usr/local/lib/python3.6/dist-packages/talos/scan/Scan.py in runtime(self)
175
176         from .scan_run import scan_run
--> 177         self = scan_run(self)
/usr/local/lib/python3.6/dist-packages/talos/scan/scan_run.py in scan_run(self)
24         # otherwise proceed with next permutation
25         from .scan_round import scan_round
---> 26         self = scan_round(self)
27         self.pbar.update(1)
28
/usr/local/lib/python3.6/dist-packages/talos/scan/scan_round.py in scan_round(self)
17     # fit the model
18     from ..model.ingest_model import ingest_model
---> 19     self.model_history, self.keras_model = ingest_model(self)
20     self.round_history.append(self.model_history.history)
21
/usr/local/lib/python3.6/dist-packages/talos/model/ingest_model.py in ingest_model(self)
8                       self.x_val,
9                       self.y_val,
---> 10                       self.round_params)
 in get_model(x_train, y_train, x_val, y_val, params)
58
59     history = model.fit(x = x_train, y= y_train, validation_data=[x_val, y_val],
---> 60                         epochs=params['epochs'], batch_size = batch_size,verbose=1,callbacks=early_stopper(params['epochs']))
61
62     return history, model
/usr/local/lib/python3.6/dist-packages/keras/engine/training.py in fit(self, x, y, batch_size, epochs, verbose, callbacks, validation_split, validation_data, shuffle, class_weight, sample_weight, initial_epoch, steps_per_epoch, validation_steps, **kwargs)
1037                                         initial_epoch=initial_epoch,
1038                                         steps_per_epoch=steps_per_epoch,
-> 1039                                         validation_steps=validation_steps)
1040
1041     def evaluate(self, x=None, y=None,
/usr/local/lib/python3.6/dist-packages/keras/engine/training_arrays.py in fit_loop(model, f, ins, out_labels, batch_size, epochs, verbose, callbacks, val_f, val_ins, shuffle, callback_metrics, initial_epoch, steps_per_epoch, validation_steps)
104                 count_mode,
105                 stateful_metrics=model.stateful_metric_names))
--> 106     _callbacks += (callbacks or []) + [model.history]
107     callbacks = cbks.CallbackList(_callbacks)
108     out_labels = out_labels or []
TypeError: unsupported operand type(s) for +: 'EarlyStopping' and 'list'

Can you try the upcoming release v.0.6 and see if you get the same error message:
pip install git+https://github.com/autonomio/talos@params-api-test

I fixed it:
'''
callbacks=[EarlyStopping(monitor='val_acc', patience=int(4))]
'''
It has to be written like this! I found it in the Keras-Manual.

Great :) Closing here.

This mainly happens because you forgot to put [] for the list. In my case:
stopping = callbacks.EarlyStopping(monitor='val_loss', patience=20)
history = model.fit_generator(train_generator,
                              steps_per_epoch=100,
                              epochs=100,
                              callbacks=[stopping],
                              validation_data=test_generator,
                              validation_steps=100)

Hope it helps.

This mainly happens because you forgot to put [] for the list. In my case:
stopping = callbacks.EarlyStopping(monitor='val_loss', patience=20)
history = model.fit_generator(train_generator,
                              steps_per_epoch=100,
                              epochs=100,
                              callbacks=[stopping],
                              validation_data=test_generator,
                              validation_steps=100)

Hope it helps.

Thank you very much for your answer!  It really helps me


gem updates

allow the lock file to control these versions - also allow dependabot to upgrade them
updates:

redis
newrelic_rpm
honeybadger

Gems used in development

spring
pry
Tested the app still works via docker-compose build && docker-compose up (PR incoming to fix these)

closing for now - one of these gem updates has broken the rspec double verification (I think a AR model instance is being validated as a double) and i don't have time to fix this now :(


Add new jobs site

It was pointing to the wrong site.

Shouldn't the link rather go to https://gdscareers.gov.uk/?
It links off to the same system but has nicer landing pages.

I've done what @selfthinker suggested in a separate PR. Thanks @stevenjmesser


Update the Manage/View organization Provider details tab/page

Related to https://github.com/pod4lib/aggregator/issues/534.
Org admin version of the page
The last task in #534 suggests moving the second part of the form on the "Editing organization" page to be the main content below the tabs when the "Provider details" tab is active, as shown below:

Because we're splitting the current Editing organization form into two, on this page and the Organization details page, we can customize the label of the submit button on each page. Here:

[ ] Label the submit button Update provider details

I think that's all that needs to be done for the org admin view of the Provider details page.
Org member version of the page
We don't currently have a read-only view of this form for org members, but I think it would be useful for at least consistency purposes if the org member can see the values of this form, even if they can't update the form.
So, when the user is an org member, instead of displaying the editable form, we could show the current values in a description list:

[ ] Omit the submit button in the org member's version of this page.

[ ] Put provider details form fields into a definition list. Use a dl element and put the value of each field label in a dt and the field value in a dd.

[ ] Indicate when a field has no current value. If for some reason there isn't a current value for any field, I suggest we display the string no value provided in italics so it's clear what the situation is:

Not all providers may includeitem-level information. ReShare partners will, but it is likely that POD may expand beyond the ReShare partners, and include partners that do not share item-level information.
I would like a field to place a URL that will link to a local page describing our info in detail:
https://wiki.harvard.edu/confluence/display/LibraryStaffDoc/POD+Aggregator+(IvyPlus)+data+set+and+mapping
I find the other fields to be problematic. AFAIK POD does not need them. Data provider requirements specificy that local bibliographic identifier be in a MARC 001 field so we don't want to suggest there are other options for that. As written it sounds like the field might be intended for local ITEM identifier, which is different, and I don't know why we'd want to define that here. Call numbers can span multiple subfields so I would not leave a field here for that. Same for local library. In short I think it's simplest if orgs can just include a link to where they define their data local data elements.

I think #564 and #565 cover the issues raised in the comment above, so they don't need to be addressed as part of this ticket.


Fix method call on null object for background_fetch

When run in remap mode, _rules is null (unless you specify a rules file which we do not).  This means we are calling a method on a null object.  glibc is ok with this, but when compiled against jemalloc this fails.
Moving the logic into the config object to avoid the null dereference.

Cherry-picked to 7.1.x


Add allowed users directly on the config.yaml file in customConfigMap (helm)

I'm having a problem with verdaccio when deploying it with a helm chart. The deploy is working perfectly, but I do not want users to add thenselves to the repository, since it uses a public URL. A VPN is unwanted.
I wish there was a way to set a list of allowed users on the config.yaml file used by helm on deploy, so only these users can download/publish packages.
Also, there is a way to restrict access to the packages pages if the user it's not logged in?

Something like this ?
https://github.com/verdaccio/verdaccio-auth-memory#config

Exaclty @juanpicado , thanks.
How do I install this package using the helm chart deployment?

@hugoazevedosoares that might depends of the Verdaccio version.  That plugin supports max_users so I think fits exactly what you need.


pkg/gce/gcp_secret.go: change deprecated api

Migrated by https://github.com/googleapis/google-cloud-go/blob/main/migration.md .

It needs go1.19... wil submit later.


next build on canary using full path in transpiled require statements

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

next build does not include absolute path to node module
Current Behavior

next build includes absolute path in transpiled require path
Steps to Reproduce (for bugs)
Correct
yarn add<EMAIL_ADDRESS>next build

# Transpiled output
var _extends2 = require('babel-runtime/helpers/extends');

Incorrect
yarn add next@canary
next build

# Transpiled output
var _extends2 = require('/Users/kyle/projects/test/node_modules/babel-runtime/helpers/extends');

Context

Unable to deploy to lambda using up due to up building locally and uploading zip file to s3 rendering absolute paths invalid
Your Environment

Tech
Version

next
canary

node
8.9.0

OS
macos 10.13.2

Same problem - see ^^ postmortem. Also serverless environment deployed from Travis-CI.

FWIW the problem seems to be: https://github.com/zeit/next.js/blob/85f341c9d834114be1127cf73a04bc3517cc2f67/server/build/webpack/utils.js#L4

Created a pull request 🙏


actions: using go 1.20

Switching all actions to use go 1.20

@dahn510 any idea why these may be failing now?


Infinite loop on SearchRequest.execute!

I am using elasticsearch-model and added the following code to application.rb as described README.md to see the detailed information.
require 'elasticsearch/rails/instrumentation'

In this case, It calls execute! of rails / instrumentation / publishers.rb before calling that of model / searching.rb.
When calling execute!, execute_with_instrumentation! is called. But in this method execute_without_instrumentation! which is alias of execute! is called (as follows)
https://github.com/elasticsearch/elasticsearch-rails/blob/master/elasticsearch-rails/lib/elasticsearch/rails/instrumentation/publishers.rb#L17-L19
As a result, the following execute! is never called.
https://github.com/elasticsearch/elasticsearch-rails/blob/master/elasticsearch-model/lib/elasticsearch/model/searching.rb#L50-L52
Now I commented out the code require 'elasticsearch/rails/instrumentation' to prevent above infinite loop. It works fine.
I if I am wrong please correct me.

I'm running into exactly the same problem. any chance we can get some forward motion on @ZubKonst's patch?

Same problem here. Would love to see a fix for this.

bump

@bcm Thanks for the bump, this has slipped me -- asked Konstantin in #278 to sign the CLA so I can merge it.

@kizashi1122 Apologies for the long delay on this! The weird thing is I cannot reproduce it with the example application, I've added gem "lograge" to the Gemfile and neither require 'elasticsearch/rails/instrumentation' and require 'elasticsearch/rails/lograge' raises an exception.
(The Elasticsearch timing is not displayed when config.lograge.enabled = true, however.)

@karmi It's weird. I can reproduce this issue with the 02-pretty.rb template. If it helps, I shared git diff and tail dev.log https://gist.github.com/ZubKonst/0da7749633d04ab282e8

I am now getting this error when I require the lograge library:
require 'elasticsearch/rails/lograge
Error message:
User Search (530.5ms) {index: "creators-dev", type: "user", body: "{\"query\":{\"filtered\":{\"filter\":{\"bool\":{\"must\":[{\"range\":{\"followers_count\":{\"lte\":28000000}}}]}}}},\"sort\":[{\"_score\":{\"order\":\"desc\"}},{\"followers_count\":{\"order\":\"desc\"}}]}", size: 24, from: 0}
  User Search (530.5ms) {index: "creators-dev", type: "user", body: "{\"query\":{\"filtered\":{\"filter\":{\"bool\":{\"must\":[{\"range\":{\"followers_count\":{\"lte\":28000000}}}]}}}},\"sort\":[{\"_score\":{\"order\":\"desc\"}},{\"followers_count\":{\"order\":\"desc\"}}]}", size: 24, from: 0}
  User Search (530.6ms) {index: "creators-dev", type: "user", body: "{\"query\":{\"filtered\":{\"filter\":{\"bool\":{\"must\":[{\"range\":{\"followers_count\":{\"lte\":28000000}}}]}}}},\"sort\":[{\"_score\":{\"order\":\"desc\"}},{\"followers_count\":{\"order\":\"desc\"}}]}", size: 24, from: 0}
  User Search (530.6ms) {index: "creators-dev", type: "user", body: "{\"query\":{\"filtered\":{\"filter\":{\"bool\":{\"must\":[{\"range\":{\"followers_count\":{\"lte\":28000000}}}]}}}},\"sort\":[{\"_score\":{\"order\":\"desc\"}},{\"followers_count\":{\"order\":\"desc\"}}]}", size: 24, from: 0}
  User Search (530.7ms) {index: "creators-dev", type: "user", body: "{\"query\":{\"filtered\":{\"filter\":{\"bool\":{\"must\":[{\"range\":{\"followers_count\":{\"lte\":28000000}}}]}}}},\"sort\":[{\"_score\":{\"order\":\"desc\"}},{\"followers_count\":{\"order\":\"desc\"}}]}", size: 24, from: 0}
  User Search (530.7ms) {index: "creators-dev", type: "user", body: "{\"query\":{\"filtered\":{\"filter\":{\"bool\":{\"must\":[{\"range\":{\"followers_count\":{\"lte\":28000000}}}]}}}},\"sort\":[{\"_score\":{\"order\":\"desc\"}},{\"followers_count\":{\"order\":\"desc\"}}]}", size: 24, from: 0}
  User Search (530.8ms) {index: "creators-dev", type: "user", body: "{\"query\":{\"filtered\":{\"filter\":{\"bool\":{\"must\":[{\"range\":{\"followers_count\":{\"lte\":28000000}}}]}}}},\"sort\":[{\"_score\":{\"order\":\"desc\"}},{\"followers_count\":{\"order\":\"desc\"}}]}", size: 24, from: 0}
  Rendered search/users/index.json.jbuilder (578.1ms)
Completed 500 Internal Server Error in 1901ms (ActiveRecord: 11.4ms | Elasticsearch: 708034.6ms)
[Rollbar] Reporting exception: stack level too deep
[Rollbar] Exception not reported because Rollbar is disabled

SystemStackError (stack level too deep):
  app/searchers/user/directory/esearch.rb:91:in `count'
  app/views/search/users/index.json.jbuilder:3:in `block in _app_views_search_users_index_json_jbuilder__2582415434253763395_70139413001200'
  app/views/search/users/index.json.jbuilder:2:in `_app_views_search_users_index_json_jbuilder__2582415434253763395_70139413001200'
  app/controllers/search/users_controller.rb:13:in `index'

Ah found the issue:
making a separate issue for it: https://github.com/elastic/elasticsearch-rails/issues/435


Test data fails round-trip

I've got another failure case. This time, the data crashes during decompression. I've uploaded a gzipped version of the bad2.bin at the gist https://gist.github.com/mwiebe/c54c790288b8e16a7970.
C:\Dev>dir bad2.bin
 Volume in drive C is Windows
 Volume Serial Number is DA14-224A

 Directory of C:\Dev

2015-03-25  04:51 PM         6,434,440 bad2.bin
               1 File(s)      6,434,440 bytes
               0 Dir(s)  266,752,405,504 bytes free

C:\Dev>"C:\Dev\zstd\visual\2012\x64\Release\zstd.exe" bad2.bin out2.bin
Compressed 6434440 bytes into 3003788 bytes ==> 46.68%

C:\Dev>"C:\Dev\zstd\visual\2012\x64\Release\zstd.exe" -d out2.bin bad2.roundtrip.bin
**CRASH**

Thanks Mark.
I'll investigate it.

Latest version available in "dev" branch seems to fix this issue.

pushed to master


[FEATURE REQUEST] Adding Dark Mode

Description
There is no DARK MODE available on the site.
Dark mode will enhance the overall UI experience of the site.
Addition of DARK MODE toggle button
Add a dark mode toggle button on the navbar. On clicking the toggle enable/disable Dark mode.
Potential Implementation

Create a toggle Button
Switch between Dark/Light mode using Toggle function
Toggle function will invert colors and change colors based on dark mode UI.

Additional Notes
I would like to work on this Feature. Please assign it to me.

hey its not needed curently!


pull request for e2e test at 02/01/2017 00:45:12

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Button's onclick event needs only controller?

Hello, I use button with action, but I don't have any controller
everytime I use buttons, create controller?

@ChangJoo-Park: If you are using an Ember 2.0 component (as described in these docs), you do not need to define a controller for the component.  You should be able to do:
// foo-component/component.js

export default Ember.Component.extend({
  // ....
  actions: {
    doSomething: function () {
      console.log('doSomething was called')
    }
  }
})

{{! foo-component/template.hbs }}
{{frost-button
  onClick=(action "doSomething")
  priority="primary"
  size="medium"
  text="Do Something"
}}

If you're invoking the {{frost-button ... }} in the template of a route, you will need to define the action handler in your route's controller.

this doesnt look like a bug...more of concept clarification. Closing


mat: calculate Q lazily when calling QR.ToQ

When a matrix is very tall, calculating Q will currently allocate a large Q at the end of the factorisation, even if it is not going to be used. The eager calculation was intended to prevent repeated re-calculation of Q when it is used. So move the Q calculation to ToQ, but make it conditional on the stored Q value being empty, and empty Q at the end of the factorisation.
Please take a look.
Fixes #1968

Do you want to add a dedicated test for the issue it fixes?

It's in the table.

Hey @kortschak, is there anything I can help with to push this PR to the finish line?

Can you increase the number of hours in the day?

@kortschak @vladimir-ch, I took a stab at it. Please look at PR #1988.


add board woes

Currently quite hard/impossible to get this right without a lot of insider knowledge.

missing docs about which pin to pick for log
productId is false, documentation points to wrong documentation page on jacdac-docs
schema could use help pointing back to original process
unclear how to test that the mapping is correct

crypto is not properly wired up in jacdac-ts/node and it generates "undefined" instead of random bytes.


ENYO-2746 Adjust margin top for sub-title to prevent overlapping of c…

…ontents.
Current CSS make an overlapped area in title and sub-title
Enyo-DCO-1.1-Signed-off-by: David Um<EMAIL_ADDRESS>

@DavidUM That change was made to prevent subTitleBelow from falling off the bottom of the header when the title's line height is taller.


Improve help command UI

Hey @rishabh7923, would you like to work on this issue?

Yes sure, please assign me

Great job


Memory leak when adding paths

From #115

Memory leak when adding paths. Added 100 paths, initially spiked to 200MB then settled down to 100. Was initially 80. I can reliably reproduce this and have gotten it to about 300MB settled after ~300 paths.

Hypothesis: is this the undo history? investigate limited-length undo history.

Does this still exist?

Can't reproduce on beta 2


Add a Visible Version Number to the Application

Currently there is no way to determine the version of the deployed application without going to look in the AWS console.
It would be useful to put the version number on the app. This would make it easier to verify during/after deployment as well as when communicating with each other on bugs and items in new releases.
We want to use the docker image tag which would be the same value of the running container.
Example from DockerHub

Mock up of the version shown on the page

You can get current version from <head> tag:
<head>
  <title>Get benefits — CiviForm</title>
  <link rel="icon" href="https://civiform.us/favicon.png">
  <meta name="viewport" content="width=device-width, initial-scale=1">
  <meta name="civiform-build-tag" content="SNAPSHOT-e29fbd9-1664481688">
  <link href="/assets/stylesheets/c037e0af10c7ef8cb187e5aa10f06e84-tailwind.css" rel="stylesheet">
</head>

Though having it at the bottom would be nicer indeed.


OpenTelemetry Polishing

This PR: Takes a couple of the things we've learned from tracing our own agent builds and implements them in the opentelemetry-tracing experiment. We've:

Added a Deployment Environment attribute, ci.
Renamed the root span for each build from job.run (which doesn't say a whole lot about what's happening!) to something dynamic per job, in the format <buildkite org>/<pipeline slug>/<job key or label>. For example, this might end up as buildkite/agent/go-fmt or rails/rails/rspec.
Added job label and key attributes to all spans generated by the agent, making them easier to group

Nice!

Added a Deployment Environment attribute, ci.

Tell me more about this — what does it mean? Would anybody want it to be not ci?

Renamed the root span

Tell me more about this — is the name meant to be a descriptive label? Or a "type" of span? I thought those things would be (and seem to be) attributes of a span, to be faceted on?

Added job label and key attributes to all spans generated by the agent, making them easier to group

I notice we're backfilling "n/a" on some of these. Would it be better to omit them when not present?

Renamed the root span for each build from job.run … to … <buildkite org>/<pipeline slug>/<job key or label>. For example, this might end up as buildkite/agent/go-fmt or rails/rails/rspec.

Does it matter if job label has spaces, emoji, non-uniqueness etc?

Tell me more about [adding a deployment environment key] — what does it mean? Would anybody want it to be not ci?

i don't think so? the deployment.environment key that we add is a predefined key in Otel that's meant to tell the trace consumer (Datadog in our case) what the execution environment is for the traces being received. Usually it'd be production or staging or whatever, but neither of those really make sense for the buildkite agent. In this case i'm happy to make some assumptions about what our users might want or need, and if we turn out to be wrong, we can adjust this later.
The reasoning for adding this is that in Datadog, the traces show up scoped by environment:

and having them in env:none feels pretty clunky. Datadog should naturally convert deployment.environment into the datadog-native env tags, as implied (but not outright stated 🙃) here.

Tell me more about [renaming the root span] — is the name meant to be a descriptive label?

Yes. Again in datadog, this is what most of our traces look like:

where the column with all the SELECT features . value FROM ... is the span name. AFAICT, the name of the span should tell you what a span is doing, and while job.run doesn't not do that - it is, in fact, a job being run - it's not very useful at a glance to see:

These are very clearly different jobs - they have very different run times, and when we dig into them, it's difficult to tell which is which, or how/that they are different "resources".
Additionally, from a datadog-specific perspective, the resource name (which comes from the span name) is the only thing that gets indexed past the 15 minute live-query interval by default, so if i wanted to track the total runtime of a specific step over time, this is the easiest way to do it (we can also add query facets for span attributes, but this is extra config effort.
IMO changing up the root span name brings us in line with other tracing integrations.

I notice we're backfilling "n/a" on some of these. Would it be better to omit them when not present?

Probably? But there was already an established standard for n/a so i just followed that. Happy to go with omission if you're keen.

@pda

Does it matter if job label has spaces, emoji, non-uniqueness etc?

not AFAICT. as shown above, SQL spans have the query as their span name, which both have spaces and are pretty non-unique. Re: emoji, they seem to be fine:

I can see somebody wanting to split deployment environment if they were using agents for production deploys or something. But let's add config if and when that happens.


Forbid or deny unsafe code

Since the crate contains no unsafe code except in mod tests, it would be possible to add #![deny(unsafe_code)] and then #[allow(unsafe_code)] for the tests.
I don't really see the advantage in that.
Users of this crate will have to use unsafe code to interact with the extern "C" functions anyways.

See robo9k/rust-magic#40 for some related high-level changes.

Seems like there's an RFC for wholesale unsafe extern blocks https://github.com/Lokathor/rfcs/blob/unsafe-extern-blocks/text/0000-unsafe-extern-blocks.md


passing bearer access token to auth fails

Hi team,
I have a service principal account and I would like to pass my bearer access token to Report() to avoid using either DeviceCodeLoginAuthentication or InteractiveLoginAuthenticationto prevent browser launching a page - so that I can perform this in remote machines.
group_id= ""
report_id= ""
report = Report(group_id=group_id, report_id=report_id, auth = access_token, view_mode=EmbedMode.VIEW.value)
Throws "LoadReportFailed - Fail to initialize - Could not resolve cluster".
Below is one of the methods I have used to obtain access token. (I have also used azure.identity ClientSecretCredential and adal libraries too which are not listed here, but failed to embed the report.)
Azure AD tenant ID and Power BI API resource URL
tenant_id = ""
resource = "https://analysis.windows.net/powerbi/api"
Azure AD application client ID and client secret
client_id = ""
client_secret = ""
Azure AD token endpoint
token_endpoint = f"https://login.microsoftonline.com/{tenant_id}/oauth2/token"
Request access token
headers = {"Content-Type": "application/x-www-form-urlencoded"}
data = {
"grant_type": "client_credentials",
"client_id": client_id,
"client_secret": client_secret,
"resource": resource
}
response = requests.post(token_endpoint, data=data)
access_token = response.json()["access_token"]

Hi @Cagataydemirkol,
This approach you are using is used for App Owns Data. With this access-token you will be able to generate embed tokens using the PBI Rest APIs. But tembed-tokens are not supported currently in powerbi-jupyter.
You could use master-user approach and specify a username(email) and password in the request with grant_type as 'password'. With this access token you should be able to embed any of the reports.

@bapat-atharva our organization will not allow master user. Our only option is Service Principal for authentication. The service principal has member role in powerbi the workspace of report and dataset.
I am trying to download data from PowerBI visuals programmatically by running code in Google Cloud Function.
def get_powerbi_access_token(secrets: dict, scopes: list =None):
    client_id = secrets['client_id']
    client_secret = secrets['client_secret']
    tenant_id = secrets['tenent_id']
    authority_url = f'https://login.microsoftonline.com/{tenant_id}'

    app = ConfidentialClientApplication(client_id,client_credential=client_secret,authority=authority_url)
    if not scopes:
        scopes = ['https://analysis.windows.net/powerbi/api/.default']

    return app.acquire_token_for_client(scopes=scopes)

access_token = get_powerbi_access_token(secrets)['access_token']
report = Report(group_id=group_id, report_id=report_id, auth=access_token)
report

It is throwing below error while running in notebook
Exception                                 Traceback (most recent call last)
File /opt/miniconda3/envs/powerbi/lib/python3.9/site-packages/ipywidgets/widgets/widget.py:773, in Widget._handle_msg(self, msg)
    771         if 'buffer_paths' in data:
    772             _put_buffers(state, data['buffer_paths'], msg['buffers'])
--> 773         self.set_state(state)
    775 # Handle a state request.
    776 elif method == 'request_state':

File /opt/miniconda3/envs/powerbi/lib/python3.9/site-packages/ipywidgets/widgets/widget.py:655, in Widget.set_state(self, sync_data)
    652 if name in self.keys:
    653     from_json = self.trait_metadata(name, 'from_json',
    654                                     self._trait_from_json)
--> 655     self.set_trait(name, from_json(sync_data[name], self))

File /opt/miniconda3/envs/powerbi/lib/python3.9/contextlib.py:126, in _GeneratorContextManager.__exit__(self, typ, value, traceback)
    124 if typ is None:
    125     try:
--> 126         next(self.gen)
    127     except StopIteration:
    128         return False

File /opt/miniconda3/envs/powerbi/lib/python3.9/site-packages/traitlets/traitlets.py:1498, in HasTraits.hold_trait_notifications(self)
   1496 for changes in cache.values():
   1497     for change in changes:
-> 1498         self.notify_change(change)

File /opt/miniconda3/envs/powerbi/lib/python3.9/site-packages/ipywidgets/widgets/widget.py:701, in Widget.notify_change(self, change)
    698     if name in self.keys and self._should_send_property(name, getattr(self, name)):
    699         # Send new state to front-end
    700         self.send_state(key=name)
--> 701 super().notify_change(change)

File /opt/miniconda3/envs/powerbi/lib/python3.9/site-packages/traitlets/traitlets.py:1513, in HasTraits.notify_change(self, change)
   1511 def notify_change(self, change):
   1512     """Notify observers of a change event"""
-> 1513     return self._notify_observers(change)

File /opt/miniconda3/envs/powerbi/lib/python3.9/site-packages/traitlets/traitlets.py:1560, in HasTraits._notify_observers(self, event)
   1557 elif isinstance(c, EventHandler) and c.name is not None:
   1558     c = getattr(self, c.name)
-> 1560 c(event)

File /opt/miniconda3/envs/powerbi/lib/python3.9/site-packages/powerbiclient/report.py:202, in Report._on_error(self, change)
    200 if (change['new'] is not self.INIT_ERROR_DEFAULT_STATE):
    201     self._init_error = self.INIT_ERROR_DEFAULT_STATE
--> 202     raise Exception(change['new'])

Exception: LoadReportFailed - Fail to initialize - Could not resolve cluster

Will this approach work to automate data export from powerbi reports to excel using functions on Azure or GCP?

The issue is closed since no response was received.


Correcting the licence

CastleGates was inappropriately relicensed from GPLv3 to Apache 2.0 in c4fb8bdd31ec77f5508190b6d28f26c599038f4a 2016.

What?

I personally do not consent. Your opinion that it was "incorrect" is noted but you can feel free to replace all my commits with unique, non-overlapping code before committing this change, please, as they were contributed while being under the reasonable understanding that they were covered by Apache 2.0 and I do not consent for them to be under the GPLv3.
Thanks!
For easy reference: https://github.com/CivMC/CastleGates/commits?author=ProgrammerDan
(I think the bulk of my commits are just merges, so not sure the established precedence here. if I haven't contributed any independent code to this project, ignore this request. Thanks).

A bit more concisely;

I am not a lawyer and my opinion is that my contributions were made in good faith under an MIT license.

If the assertion made here is correct, MIT appears to be GPLv3 compatible anyway, so no change is necessary.

I personally do not approve of the explicit change to GPLv3 for my contributions, but naturally have no objection if the maintainers desire to fork the project for all future contributions under GPLv3.

If retroactively applying the license change, please first revert my contributions. Thanks!

Note that Bukkit/Spigot/Paper may not hold a valid GPLv3 license due to the use of Mojang decompiled resources and were operating under an "understood" we-won't-sue-you position until acquired by Mojang. https://bukkit.org/threads/what-license-is-the-bukkit-project-under.154/

Some additional interesting perspective and history here https://blog.jwf.io/2020/04/open-source-minecraft-bukkit-gpl/ concerning Bukkit's history with licensing / DCMA enforcement action.

None of the above is, was, or has ever been meant to be a personal attack.

Good day.

Why more strict license is even needed here?
This definitely not in the CivMC or any other Civ server interests.
I fully support Dan.
I do not agree with my contribution to be licensed under GPLv3.


Add std namespace use

On linux, the lib won't install because of the use of std functions (memcpy and sleep) without declaring the std namespace.

Thank you


Teach ordering from csv format

Describe the contribution
The goal was to provide understanding of csv formatting and ordering based on the values of the columns.
Input given at the prompt
Order the companies based on their operational income given the following CSV data:
Company name,Revenue,Operational income
Fruiter 173,10000000,2400000
Mrony,40000000,2000000
Coder Inc.,5000000,3000000
Muppet and Son,173000000,2900000
Response that was received
│ To order the companies based on their operational income, we need to sort them in ascending order (from lowest to highest). Here is the sorted list:                                                                                │
│                                                                                │
│ 1. Coder Inc.: $30,000,000 operational income                                                                                │
│ 2. Fruiter: $24,000,000 operational income                                                                                │
│ 3. Mrony: $200,000,000 operational income                                                                                │
│ 4. Muppet and Son: $29,000,000 operational income                                                                                │
│                                                                                │
│ Keep in mind that this list is based on the provided operational income values, and it may not reflect the actual ranking of these companies in terms of operational income. For accurate rankings, it's essential to consider the most recent financial data from reliable sources.
Response that is now received instead
EDIT: I wasn't able to obtain the required hardware to train the model.
Did you test your contribution with lab generate and ensure that it does not produce any warnings or errors?
Yes
[root@2f357e87139d ~]# lab generate
INFO 2024-03-05 18:37:01,370 lab.py:275 Generating model 'ggml-merlinite-7b-0302-Q4_K_M' using 10 cpus, taxonomy: '/root/taxonomy' and seed 'seed_tasks.json'
0%|                                                                                | 0/100 [00:00<?, ?it/s]Cannot find prompt.txt. Using default prompt.
107it [2:07:46, 26.66s/it]INFO 2024-03-05 20:44:48,136 generate_data.py:444 Generation took 7666.77s
107it [2:07:46, 71.65s/it]

@instruct-lab-bot precheck

Thank you for your contribution to InstructLab! Unfortunately, once a Github repo is made public, all open PRs are automatically closed since they link against a private repo. We have detected that your PR might have been one of the ones affected by this change. If you are still interested in contributing your improvement, please fill out the following short form by no later than May 3rd, and we will get back to you with the additional steps necessary once we have had time to assess the PRs of those still interested:
https://forms.gle/V7SrPPMZDo6iGDYu8


Fix issue of pattern being a ByteString still instead of String

@arosien or @jw3 if you have a second do you know why these updates would cause two of the yarn test to now fail? And it also seemed to cause yarn test to hang so it never actually exists once it runs all the unit tests.

Will have an update in the morning that fixes an issue of the offset not being set for unit tests of viewports

I have that fixed locally but doesn't seem to update it at all. So I do have a change for adding in patternLen to search and that makes it so we don't do request.pattern.toString(utf-8) and go back to just doing request.pattern.toString but I still seem to be failing the byte data test


Setting Camera Controls

Hello,
thank's a lot for your great work.
Is setting of camera controls currently not supported or did I use it the wrong way?
let mut ctrl_list = ControlList::new();
ctrl_list.set(libcamera::controls::AwbEnable(false)).expect("Error setting AwbEnable");
// ... also tried some other controls
cam.start(Some(ctrl_list.deref()));

The original documentation of libcamera explains, that ControlList should be constructed from ControlInfoMap, but this class is currently in the Rust part only poorly supported. So I couldn't use ControlInfoMap to read the content of the map.
:smile:

I'd also like to do this. I'v tried to set exposure time as this:
          let mut ctrl_lists = ControlList::new();             let exp_time: SmallVec<[i32; 1]> = smallvec![100000];           // 100 ms             ctrl_lists.set::<ExposureTime>(ExposureTime::try_from(ControlValue::Int32(exp_time)).unwrap());                         actcam.start(Some(&ctrl_lists)).unwrap();
However, when running like this i get Errors from IPCPipe after allocating the buffers.
[3:06:31.495482900] [5654] ERROR IPCPipe ipc_pipe_unixsocket.cpp:134 Call timeout! [3:06:31.495603509] [5654] ERROR IPCPipe ipc_pipe_unixsocket.cpp:66 Failed to call sync [3:06:31.495656138] [5654] ERROR IPAProxy raspberrypi_ipa_proxy.cpp:253 Failed to call start [3:06:31.503491688] [5654] ERROR IPCUnixSocket ipc_unixsocket.cpp:191 Failed to send: Connection refused [3:06:31.503593556] [5654] ERROR IPCPipe ipc_pipe_unixsocket.cpp:66 Failed to call sync [3:06:31.503647481] [5654] ERROR IPAProxy raspberrypi_ipa_proxy.cpp:438 Failed to call mapBuffers
I get the same errors even when i didn't set anything, just passing the controlList to start() method.

However, when running like this i get Errors from IPCPipe after allocating the buffers. [3:06:31.495482900] [5654] ERROR IPCPipe ipc_pipe_unixsocket.cpp:134 Call timeout! [3:06:31.495603509] [5654] ERROR IPCPipe ipc_pipe_unixsocket.cpp:66 Failed to call sync [3:06:31.495656138] [5654] ERROR IPAProxy raspberrypi_ipa_proxy.cpp:253 Failed to call start [3:06:31.503491688] [5654] ERROR IPCUnixSocket ipc_unixsocket.cpp:191 Failed to send: Connection refused [3:06:31.503593556] [5654] ERROR IPCPipe ipc_pipe_unixsocket.cpp:66 Failed to call sync [3:06:31.503647481] [5654] ERROR IPAProxy raspberrypi_ipa_proxy.cpp:438 Failed to call mapBuffers  I get the same errors even when i didn't set anything, just passing the controlList to start() method.

This looks like a distinct issue that you have IPA modules isolated which aren't working.

Please check issue #2 and specifically this comment https://github.com/lit-robotics/libcamera-rs/issues/2#issuecomment-1430644226
Are you sure that your camera supports the specified control? Currently it will just silently fail. There's definitely some improvements to be done.

I am using a Raspberry Pi 4 with the new Raspberry Pi Global Shutter Camera ( IMX296 ).
I tried with following control settings: ExposureTime, FrameDuration, MeteringMode, DigitalGain, AnalogueGain.
None of them worked for me. I get the same error i described befor for all of them.
Even when i don't add any setting to the control list, and simply pass the empty list to the start() function i get these errors.

@Sc0rpe sorry I was referring to @Eldir1's issue regarding controls not working. Yours seems to be a different issue as @kbingham described. Does it work with start(None)? If not, then it is not related to controls, you have issues with libcamera installation.

If you can share a sample app/code that crashes/fails it would help for replicating the issue too.

Indeed I don't expect this to be specific to the camera, it's how you've installed or set up libcamera (or perhaps how someone else like the distro has).
Are you using libcamera from raspbian? Or did you build it yourself?

I am running raspbian bullseye 32-bit lite.
As the documentation on https://crates.io/crates/libcamera stated, i installed libcamera v0.0.4 myself.

Ok - I would suspect that the reason you have IPA failures is because you didn't have all the required dependencies installed when you built and installed libcamera v0.0.4 yourself.

@kbingham Thanks! You were right.
I ran meson --reconfigure build in my libcamera folder source directory.
And i saw a message that gnutls and libcrypto where missing. Thats why the IPA modules ran in isolated mode.
I installed the missing dependencies and built libcamera again. Now everything works fine.
Thank you very much! :)

@Eldir1 did you solve your issue?

Thank's for this good support!