esp32s2 USB CDC not working (without tinyusb) (IDFGH-14212)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
I tried to make a new project using a esp32s2. I enabled USB CDC but it is not working. In my old project from two years ago, as far as I remember, this was working without problems.

I copied the hello word example.
Configured it for esp32s2.
Since my esp32s2 only uses usb for console output I went ahead and enabled in menuconfig:
(Top) → Component config → ESP System Settings → Channel for console output → USB CDC

When I reboot the device it's no longer available to the system and thus I cannon use idf.py monitor.
dmesg output gives me the following recurring messages.

[32198.950492] usb 3-3: new full-speed USB device number 30 using xhci_hcd
[32210.279669] usb 3-3: Device not responding to setup address.
[32210.482356] usb 3-3: Device not responding to setup address.
[32210.690001] usb 3-3: device not accepting address 30, error -71
[32210.690042] usb 3-3: WARN: invalid context state for evaluate context command.
[32210.690083] usb usb3-port3: attempt power cycle
[32211.070353] usb 3-3: new full-speed USB device number 31 using xhci_hcd
[32216.498284] xhci_hcd 0000:0c:00.3: Timeout while waiting for setup device command
[32216.705943] usb 3-3: Device not responding to setup address.
[32216.914262] usb 3-3: device not accepting address 31, error -71

I found a workaround for this problem by adding tinyusb to the project.

idf.py add-dependency esp_tinyusb

I want to preserve as much battery power as possible so I am also curious if enabling tinyusb effects power consumption.

If you are using this, you can enable /dev/ttyACM0 by following the steps below.

Since it uses the chip's USB-OTG function, it will not be recognized as a USB device even if you simply connect it to the host with a USB cable.
To write firmware, press ButtonRST while pressing Button0, then release ButtonRST and then Button0.
Now the device will enter DFU mode, the USB device (/dev/ttyACM0) will appear, and you can upload the firmware.
Once the firmware upload is complete, press ButtonRST again.
The firmware will now start.
If you press ButtonRST without pressing Button0, the USB device will disappear.
To use STDOUT, you need to change Channel for console output to USB CDC in menuconfig.

After changing Channel for console output to USB CDC in menuconfig, upload the firmware again.
Once the firmware has been uploaded, the following display will appear.

Now press ButtonRST.
The firmware with USB CDC enabled will now start running.
From now on, you will be able to write and monitor the firmware without pressing Button0 or ButtonRST.

I did indeed follow this exact procedure and I can only reach as far as this point.

The firmware with USB CDC enabled will now start running.
From now on, you will be able to write and monitor the firmware without pressing Button0 or ButtonRST.

Since the system cannot recognize it as a proper usb device, as seen from the output of the dmesg command in my initial post, idf.py monitor will never work nor will flashing the device without entering DFU mode.
My device is similar to a Espressif ESP32-Saola-1 and I know USB CDC used to work previously with a version 4 of the sdk from a couple of years ago.


Meta title only partial correct

Problem
Edit Page > Meta > Title
Currently this only changes the opengraph title, it should also change the regular  tag for improved SEO.

Hm, I am not so sure about this.
In my head, the following scenario is true: You assign a title to your page, i.e. "About". This will be the default page title and the default title used when users share a llink to your page.
However, if you like to define a custom title used when users share the link on social media, you'd use the Meta > Title field and set it to something else, e.g. "About company XYZ", but you wouldn't necessarily have your page title affected by this.
Is it true that your suggestion would also improve SEO in general? A quick google search didn't bring up anything. Maybe you can give more reasons as to why this should be changed?

Those are fair questions, hopefully this all makes sense. Please let me know if I can provide more information.
Pagekit: Menu Title
This should be used for the slug, menu links, and breadcumb links.
Pagekit: Meta > Title
Currently it's the Open Graph title and description. OG is separate from regular title tags and meta descriptions as OG tags are used for social sites such as Facebook and Twitter. Regular title tags and meta descriptions are used for users and search engines.

https://blog.kissmetrics.com/open-graph-meta-tags/
https://moz.com/learn/seo/title-tag
https://moz.com/learn/seo/meta-description

A  tag decides simply what is shows in the browser tab and as the link anchor from a search engine, while the meta description is usually only shown as the text below the link in the search engine results page.
Example:

A couple of options to fix this could be:

Changing the current functionality of the Meta options to regular title and meta description tags
Change the labels for the existing options so that people know it's for Open Graph and add a plugin for regular title tags and meta descriptions

Just checking in to see if this is planned any time soon, thanks!

Just checking to see if there are any updates on this, thanks!


accessor not always "equivalent to calling Array.from"

In the README we often have this sentence about the accessor to d3.extent and other reduction methods: "An optional accessor function may be specified, which is equivalent to calling Array.from before computing the extent."
However in most cases the accessor receives the original data as the third argument—whereas Array.from only sends (d, i) to its accessor.
Should we follow the README (and remove the third argument), or update this sentence in the README to be more accurate wrt the existing behavior? I'd vote for updating the README, maybe with the following sentence:

An optional accessor function may be specified, which receives the datum, the index, and the data, and returns the value.

Another difference is that Array.from accepts values like {length: 42} whereas D3 only accepts values that are iterable. (This is why we do an explicit test for the Symbol.iterator method instead of calling Array.from directly in d3.map.)


ISPN-10372 Add checkstyle that prevents use of *Async with no executo…

…r from CompletionStage

Also changed 2 references

https://issues.jboss.org/browse/ISPN-10372

Forgot to mention that this doesn't currently support 0 argument explicitly. It can only be chosen when no argument count is provided. The usage currently doesn't require that though so I didn't bother trying to add it yet.

You have just reminded me I need to remove that code that deals with potential class duplicates caused by uberjars

Updated per comments.

Actually I forgot about the mention re: test code using these methods or not. I can add a boolean parameter to enable it in config as needed.

Added in property to enable for tests if desired.

Updated again :)

Integrated, thanks Will!

I noticed that CompletableFuture.supplyAsync() with just 1 parameter is still allowed, do we want to prohibit it as well?


Copy track icon into language track repository

See exercism/exercism.io#2925 for more details.

Thank you!


refactor: change NDTiff reader

Swapped out ndstorage to instead of use tifffile and zarr. Tried to get tensorstore to work, but the store can't be read by it.
NOTE: will need to be careful about the channel indexing, as the zarr attributes produced by tifffile don't have the channel_id mapping. Might need to write some extra information to disk to ensure correct loading.

The motivation here is continued elimination of anything dask related.


Using bazel build a c api

System information

OS Platform and Distribution Linux Centos8):
TensorFlow installed from source
TensorFlow version ( github SHA if from source):

Question
Hi:
When I used 'bazel build -c opt //tensorflow/lite/c:tensorflowlite_c' to create the C API for tflite. I only got 'libtensorflowlite_c. so' of only 4.4M, and I'm not sure if it's correct because it's too small?May I ask if this size is correct? Why is it so small?
Thanks!

Hi @panhu ,
On linux given build command should generate libtensorflowlite_c.so, and the mentioned size seems Ok to me as per the similar ticket #48068.
You may also test with C-Make build as per instructions here.
You can also refer lite guide here. Basically all tensorflow Ops are not supported for tflite and hence it is lightweight.

Hi@SuryanarayanaY:
Thank you for your reply. I would like to ask if Tflite supports the Risc-v architecture. If so, how should we build the relevant shared library of tflite ? Is there a Risc-v toolchain?
Thanks!

Hi @panhu,
It seems this query is already answered here.

hi @panhu,
i am working on building bazel on risc-v. do you have any way?
thanks!


Font editor perspectives

I just spoke to @chrissimpkins, and shared some loose thoughts about "faster font compilation" in the context of a font editor, and he suggested that I post here, as you are talking about use cases.
(I follow this repo only superficially, as the details of Rust table implementation strategies are beyond my expertise.)
Premise: A font editor would benefit from showing the user correctly shaped live previews.
FontGoggles attempts to do this as quickly as possible when previewing UFOs, using the following strategy:

It scrapes all unicode and anchor information from the .glif files as fast as is possible with Python
That information and the kerning and .fea data available is presented to ufo2ft to write the final .fea data
feaLib is used to compile that into GSUB/GPOS/GDEF
A "sparse" font (a TTF with the bare minimum of tables, ie. no outlines) is presented to HarfBuzz, which can then shape the user-entered string correctly
It watches for changes in individual .glif files in the UFO, and updates its internal cmap and anchor data incrementally, so it won't have to re-scrape ALL unicode + anchor data when a single glyph changes.

While this is a lot faster than compiling a full font with fontmake, there are still two bottlenecks:

The scraping of unicode + anchor data from .glif files when opening a UFO
The compilation of .fea into binary tables when opening a UFO, and when updating according to changes in the UFO

So: specialized (Rust-based?) tools for those two tasks would be incredibly useful.
For a font editor with in-memory data, things will look a little different:

cmap and anchor data can be made quickly available
some GSUB features may be generated on the fly, using glyph name conventions
kerning data will be live

With the currently available tools, we have to go via .fea to get data that HarfBuzz can use. This gives us a double bottle-neck:

Writing .fea data from live data
Compiling binary tables from .fea

My final thought here is that a superfast shaper isn't a requirement, but a shaper that can more efficiently work from live data (for example kerning and anchors) is what's really needed.
Using Rust-based tools will surely make many things much faster, but to me there is possibly more to gain with a clever (I know I'm hand-waving) system that can shape more directly from font/glyph source data, looking only at the data that is relevant for the string being displayed, without having to go via TWO intermediate formats (.fea and OTL tables).
The other thing that could be beneficial for a font editor is incremental compilation to a full font: when I edit a single glyph of a single master of a 50,000-glyph variable CJK font, it shouldn't require recompilation of the whole thing.

So this is basically the original motivation that set me down on this path, and remains one of the major goals. I have other dreams (like a step-through debugger for shaping, where it can show each rule that is applied, and its source) but I am definitely keeping this case in mind.
Incremental compilation is also definitely something nice to have; ideally that can be a layer on top of the general compilation tools.

If providing fast interactive shaping is a goal, then good Rust ↔ Other Languages interop should be part of the goals, too.
Rust is awesome for specific low level fastness, but not so much for high level orchestrating of complex processes, where people with lower CompSci skills still want to (and deserve to be able to) customize.

One other topic when it comes to font editors is efficient interoperability, since they might be written in different languages. e.g. do I need to write a file to disk to feed to the compiler, or can I provide the input data over pipes?

do I need to write a file to disk to feed to the compiler

At time of writing, yes.

can I provide the input data over pipes, or use a C API?

Not yet, but I don't see why not. Wrt pipes, what would you expect to pipe? - a standalone .glyphs file makes sense but UFO+designspace doesn't seem to lend itself as well to piping. Or perhaps you had some other input in mind?

Or file an issue against https://github.com/googlefonts/fontmake-rs explaining what you'd like to do?

adding my 2 cents:
There are two use cases:

Plain exporting the full font to get a finished .otf/ttf.
partially building some structures for different purposes. e.g. text preview, validating fea code.

The two most expensive operations I encounter in Glyphs:

writing .fea code (manually written and automatically enraged (kern, mark …) and parsing it in again.
building and compacting GPOS/GSUB tables

The current state of external compilers (like fontc or fontmake) adds the parsing and translation of the source file.
One solution to cut down most of the above could be to expose the internal representation (by an API/callbacks) that the editor app could build up data (instead of the source parser). So the editor tells the compiler: "Here are some outlines", "Here is a list of kerning pairs", "Here is another kerning pair", "Here is some fea-code" …
That could be done by a direct c style API or by pipes (potentially slower? More error prone?)
We are in the works for feaKit: it will get an API that lets me give it some fea code (a lookup or a feature) one at a time or, more importantly lets me write the GPOS lookups directly into the internal representation. That has two big advantages. It is much faster and, if done right lets me incrementally update things (e.g. a changed kerning pair).
And one important benefit: it can give much more precise errors. Because the context were that data came from is much clearer.

One solution to cut down most of the above could be to expose the internal representation

An in memory translation to what fontc reads .glyphs files into (here) should be pretty quick, no need to touch disk or parse a source file.

feaKit [...] lets me write the GPOS lookups directly into the internal representation

Ha, us too. fea-rs is learning this trick so fontc can avoid generating strings to parse.

An in memory translation to what fontc reads .glyphs files into (here)

IIUC, Georg was referring to the fontc IR (fontir/src/ir.rs) proper, not the glyph-reader/font.rs that we parse the plist into. So basically the font editor would do the job of glyphs2fontir themselves, skipping not just the plist parsing but the glyphs=>IR itself and somehow produce IR directly to feed fontc

IIUC, Georg was referring to the fontc IR (fontir/src/ir.rs) proper, not the glyph-reader/font.rs that we parse the plist into

That was my understanding also but I think that bypasses things we do want to happen.

We should be able to find a level where it makes sense to hand over the data.


MPI in module paths also for TCL?

The MPI loop has been added in general, so it can work for both TCL and LUA modules, but the install paths have been changed to include MPI name/ver only for LUA.
I imagine this has been done with support for multiple MPI on Zeus in mind. However, I am wondering whether in the future this could lead to errors if multiple MPI is made available on machines were TCL is used.
Would it be harmful to add MPI in paths also in the case of TCL modules?

We'll add MPI to the TCL module generation once it has been sorted out for LUA.
Need to test it out on Zeus first.

Implemented in #98


Usability improvements

Link to judges tab from add model responses modal when no judges are configured

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.86%. Comparing base (50b1fa0) to head (b1345fb).

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk      #93   +/-   ##
=======================================
  Coverage   96.86%   96.86%
=======================================
  Files          34       34
  Lines        1434     1434
=======================================
  Hits         1389     1389
  Misses         45       45

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Error in error message in viz/topomap: points to function in wrong file.

I found (what I think is) a small error in an error printed in mne/viz/topomap.py.
Line 557 defines a message to be printed if, as I did, you mess up the channel pos input (gets printed in lines 561 & 564).
It states:
("Pick Info with e.g. mne.pick_info and "
"mne.channels.channel_indices_by_type.")
The issue/error is that 'channel_indices_by_type' is not 'mne.channels', but rather in 'mne.io.pick', so this error sends you on a bit of a quest to find that function to try and use it, if applicable.
I'm guessing it moved at some point, and this reference is just out of date. If it just needs a quick PR fixing the path listed in the string, I'm happy to do so - just wanted to throw this up here in case it hints at anything more, and/or I've misunderstood something.

thx.
fixed in bd1b3184f


REQ: /tokens, Add percentage column for percentage of total tokens that each file represents

Issue
It might be helpful to see an additional column in the /tokens output that shows the % of the total tokens/cost that each file represents.  When you have quite a few files it could help focus the eye...
Version and model info
Aider v0.59.1
Main model: claude-3-5-sonnet-20240620 with diff edit format, prompt cache, infinite output
Weak model: claude-3-haiku-20240307
Git repo: .git with 55 files
Repo-map: using 1024 tokens, files refresh

Hi @5ocworkshop,
Can you share what do you expect with an example ? So that its easy for others to implement.


[WIP] Providing base classes to make parts reusable

This PR references #24. As of now, this just has an init commit for everyone to keep track of the work.

Coverage remained the same at 100.0% when pulling d4717328f98cff97db344d8fabbbcfbc8acdccbc on rohithasrk:base-classes into da628eeef32488dc9b38d9607f91d20d31a5890f on netjson:master.

This passes all the tests but there are some minor things I've noticed,

get_random_string function has been moved to utils.py but hasn't been removed from base/topology.py because importing from utils is creating some recursive import errors.
Not much changes have been done to the base models as they already seem reusable.
There might be some other issues that I might have overlooked.
Your reviews are requested @nemesisdesign

next steps:

base API views
draft in docs

Coverage remained the same at 100.0% when pulling e65c30ddcefee147de8bc64e7921f0e2110716cc on rohithasrk:base-classes into da628eeef32488dc9b38d9607f91d20d31a5890f on netjson:master.

Coverage remained the same at 100.0% when pulling 6244f7acf3efcadc1b6dec7ce0e8c460ca220094 on rohithasrk:base-classes into da628eeef32488dc9b38d9607f91d20d31a5890f on netjson:master.

Coverage remained the same at 100.0% when pulling 797eaf7398fff9e853d19749cd0ca09ad9ee1195 on rohithasrk:base-classes into da628eeef32488dc9b38d9607f91d20d31a5890f on netjson:master.

Coverage remained the same at 100.0% when pulling a6eb7518edefe61abb8864af2b42606fd6dcc430 on rohithasrk:base-classes into da628eeef32488dc9b38d9607f91d20d31a5890f on netjson:master.

Coverage remained the same at 100.0% when pulling 3720e1b2e0b1d7a51e94068fa049a97346ce34d4 on rohithasrk:base-classes into da628eeef32488dc9b38d9607f91d20d31a5890f on netjson:master.


build: update the build rules for adjusted tree layout

Update the file list and locations to allow building with CMake once again.

@swift-ci please test


Added examples of COMMENT ON TABLE in SHOW CREATE TABLE output

Fixes #6609.
Added examples of COMMENT ON TABLE in SHOW CREATE TABLE output to:

COMMENT ON page
SHOW TABLES page
SHOW CREATE page

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/cb3dff6b1112f82a3c6a378adcdfe104ed6346b5/
Edited pages:

v20.1/comment-on.md
v20.1/show-create.md
v20.1/show-tables.md


Investigate why Renovate isn't working and fix

See Slack thread here.
Renovate doesn't appear to be working in this repository. The failure may relate to the config in this PR: https://github.com/api3dao/airseeker-v2/pull/4/files

It needed to be enabled on this repository. It works now. Thanks to @aquarat 🙏


TSC Meeting 2021-06-16

add topic suggestions here
Review TSC issue backlog
Review TSC-tagged issues (toggle to "open" after checking for recently "closed" items)

@ampproject/tsc

@ampproject/tsc does anyone have topics for today's meeting?  if not, we can cancel.

👍🏻 to cancel

+1 to cancel, but I'm around if we meet.

+1 to cancel, but I'm around if we meet.

Ditto.

OK, looks like consensus is to cancel!


Regenerate all APIs with new generator, including ClientBuilders

(Only the second and third commits need reviewing)

The build is failing with The type or namespace name 'ClientBuilderBase<>' does not exist in the namespace 'Google.Api.Gax.Grpc' (are you missing an assembly reference?).
Is the wrong version of GAX being referenced?

Ah - Bigtable is still failing because there's a custom generation step there. I'll need to look at that separately.

(The others were due to project dependency issues.)

(Problem with Grpc.Core version in KMS)


SELinux policy configuration (app.te)

Dev: P2 (kuntao)
OS: LineageOS 15.1 Official - Treble compatible
KernelV: 3.18.115 (LineageOS Official ^)
So I managed to patch my kernel for HID support and it is working pretty well when I set selinux to permissive but I have problems with configuring sepolicy to make it work while SELinux is set to "Enforcing". I found and edited device.te and file_contexts but I can't find app.te in the same directory.
I found only these in whole build directory. Two were crossed out because these directories are not matching my board - MSM8953 (these came here probably from TheMuppets blobs repo).
I would be glad if I receive help because I'm noob with these SELinux policies thing. I also hope that full ROM compiling is not required since official system image passes safetynet out of box and I don't want to touch it.

ROM compiling is required


Bump upjet to v1.4.0

Description of your changes

Related with: #1311
This PR bumps the upjet dependency to v1.4.0 and generates the secret references under spec.initProvider API trees for the sensitive MR parameters.
spec.forProvider.user of the Broker.mq dependency is moved to spec.initProvider.user in the User.mq example manifest to ignore the desired set of broker users declared via the Broker.mq MR and to prevent a race between the Broker.mq & User.mq controllers on the (external) broker users. We now also do a late-initialization configuration for spec.forProvider.user of Broker.mq so that it will be late-initialized iff the spec.initProvider.user is not set. This configuration is done to prevent an "unintended" race condition between the aforementioned controllers in cases where the client of the Broker.mq API deliberately disables broker user management by only setting spec.initProvider.user and leaving spec.forProvider.user unset.
I have:

[x] Read and followed Crossplane's contribution process.
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

/test-examples="examples/mq/v1alpha1/user.yaml"

/test-examples="examples/eks/v1beta1/clusterauth.yaml"

/test-examples="examples/budgets/v1beta1/budget.yaml"

/test-examples="examples/iot/v1beta1/policy.yaml"


[Refactor] Replace OAM with MeshModel

Description
This PR replaces OAM-inspired constructs in our project with our constructs. It aims to make our system more dynamic, extensible, and consistent by introducing some critical design changes. This is a product of a series of discussions we've had, whose summary has been captured in the doc referenced below.
Design Spec: MeshModel
This PR fixes #
Notes for Reviewers
I am also making the changes in other parts of the projects(meshkit, adapters, adapter-library).
Signed commits

[x] Yes, I signed my commits.

@sudo-NithishKarthik tossing is the towel?

Nope, I am working on it. Reoping...


It seems twig method usage detection does not consider type that it's called on

I've setup templates path
# phpstan.neon
parameters:
    unused_public:
        template_paths:
            - templates

where I call name() on type A. It correctly marked A.name() as used.
However, it also started to consider B.name(), C.name() etc. methods as used, even though they're not.
So I have a suspicion that only a method name is considered.

You're correct. This is a feature, as to analyse types, the full controller + templates would have to be parsed. In reality, those types are not known in template and template can be used from many places, e.g. includes etc.
This is to avoid false positives.

I thought it would have to be much more complex. Thanks.

@simPod I actually made such a "smart" tool for Twig in past (https://tomasvotruba.com/blog/stamp-1-how-to-compile-twig-to-php), but it yielded so many false positives it added more work than saved time :) that's why I went for this dummy cost-effective approach


Error: Cannot read property '0' of null

Hey,
I'm trying to run the demo but unfortunately, I'm getting the error "Error: Cannot read property '0' of null".
Call Stack Object.get file:///C:/Users/erics/Desktop/Web/server-component-next/next-server-components/.next/server/pages/api.js (133:361419) <unknown> file:///C:/Users/erics/Desktop/Web/server-component-next/next-server-components/.next/server/pages/api.js (140:1613) Array.toJSON file:///C:/Users/erics/Desktop/Web/server-component-next/next-server-components/.next/server/pages/api.js (140:2690) stringify <anonymous> <unknown> file:///C:/Users/erics/Desktop/Web/server-component-next/next-server-components/.next/server/pages/api.js (140:4571) x file:///C:/Users/erics/Desktop/Web/server-component-next/next-server-components/.next/server/pages/api.js (140:4640) k file:///C:/Users/erics/Desktop/Web/server-component-next/next-server-components/.next/server/pages/api.js (140:4910) Immediate._onImmediate file:///C:/Users/erics/Desktop/Web/server-component-next/next-server-components/.next/server/pages/api.js (140:6342) processImmediate internal/timers.js (456:21)
Is the demo still supported?

It's rewritten with nextjs 12 now, please try again 🙏


UInt Serialization

@tabcat and another user brought our attention to this behavior:
const IPFS = require('ipfs')
const OrbitDB = require('orbit-db')

const ipfs = new IPFS( {
  EXPERIMENTAL: {
    pubsub: true
  }
})

ipfs.on('ready', async () => {
  const orbitdb = await OrbitDB.createInstance(ipfs)
  var docstore = await orbitdb.docs('test')
  const uint = new Uint8Array([1,2,3,4])
  await docstore.put({_id:'test', uint, })
  const cachedUint = docstore.get('test')[0].uint
  await docstore.close()
  docstore = await orbitdb.docs('test')
  await docstore.load()
  const loadedUint = docstore.get('test')[0].uint
  console.log(`uint: ${uint}`)
  console.log(`cachedUint: ${cachedUint}`)
  console.log(`loadedUint: ${loadedUint}`)
    // uint: 1,2,3,4
    // cachedUint: 1,2,3,4
    // loadedUint: [object Object]
})

We should figure out a good strategy on how to retrieve binary Uint values to and from Orbit

my main issue with this is that  in the example the cachedUint doesnt equal the loadedUint. I dont think this is unique to Uints but that when someone adds a new entry, im guessing, the cache is storing the plain js object and not the JSON parsed version of the object like in the store.
json parsing payloads before caching would change this behavior.

https://github.com/orbitdb/orbit-db-store/pull/73

This issue has been resolved >1.0.0. To make sure, and to document it, I added tests for this in https://github.com/orbitdb/orbitdb/pull/1139.


Refactored setCookies function

I refactored it by removing an unnecessary else statement and by using async await instead of .then catch.

Changes in this PR are also in #579


 not support fillOpacity attribute

Regarding #38  not support fill-opacity.
This PR allow to get opacity on right elements

This submission seems to be missing the part of the source code changes, only the generated code is provided.


SPI: Clear error flags when detected

Closes #13
This implements the first option (automatic clearing errors on detection) discussed in the above issue. It hasn't yet been tested on actual hardware -- I likely won't be able to do so until this weekend.
The biggest stumbling block I see for testing is actually causing the errors. An overrun should be easy to force, and probably a mode fault. I'm not sure how to force a crc error though...

Made an update to how the MODF error is cleared to ensure that the exact sequence of register accesses called out in the reference manual is followed

Any updates on this?


You must either set Authority or IntrospectionEndpoint

[x ] I read and understood how to enable logging

Issue / Steps to reproduce the problem
Trying to update my api to .net core 2.0 and am now getting the exception below. Upon upgrade I changed my startup.cs with the authentication settings below and I have confirmed that the settings are all being correctly pulled from config and set as the options with the debugger. I'm sure i'm doing something wrong but It not obvious to me what that is yet.
services
.AddAuthentication(IdentityServerAuthenticationDefaults.AuthenticationScheme)
.AddIdentityServerAuthentication(opts => {
// base-address of your identityserver
opts.Authority = Configuration.GetSection("Id4Settings")["Authority"];
// name of the API resource
opts.ApiName = Configuration.GetSection("Id4Settings")["ApiName"];
opts.RequireHttpsMetadata = bool.Parse(Configuration.GetSection("Id4Settings")["RequireHttps"]);
});
System.InvalidOperation:  You must either set Authority or IntrospectionEndpoint
Relevant parts of the log file
Nothing really relevant in the log because of the way I'm handling errors right now it continues to process after this error and the token is successfully validated.
System.InvalidOperationException: You must either set Authority or IntrospectionEndpoint
   at Microsoft.AspNetCore.Builder.OAuth2IntrospectionOptions.Validate()
   at IdentityModel.AspNetCore.OAuth2Introspection.PostConfigureOAuth2IntrospectionOptions.PostConfigure(String name, OAuth2IntrospectionOptions options)
   at Microsoft.Extensions.Options.OptionsFactory`1.Create(String name)
   at Microsoft.Extensions.Options.OptionsMonitor`1.<>c__DisplayClass10_0.<Get>b__0()
   at System.Lazy`1.ViaFactory(LazyThreadSafetyMode mode)
   at System.Lazy`1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)
   at System.Lazy`1.CreateValue()
   at Microsoft.Extensions.Options.OptionsCache`1.GetOrAdd(String name, Func`1 createOptions)
   at Microsoft.Extensions.Options.OptionsMonitor`1.Get(String name)
   at Microsoft.AspNetCore.Authentication.AuthenticationHandler`1.<InitializeAsync>d__42.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationHandlerProvider.<GetHandlerAsync>d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at Microsoft.AspNetCore.Authentication.AuthenticationService.<AuthenticateAsync>d__10.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Builder.IdentityServerAuthenticationHandler.<HandleAuthenticateAsync>d__1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at Microsoft.AspNetCore.Authentication.AuthenticationHandler`1.<AuthenticateAsync>d__47.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at Microsoft.AspNetCore.Authentication.AuthenticationService.<AuthenticateAsync>d__10.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.<Invoke>d__6.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Cors.Infrastructure.CorsMiddleware.<Invoke>d__7.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
      Request finished in<PHONE_NUMBER>ms 500 application/json
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
      Request finished in<PHONE_NUMBER>ms 500 application/json
[21:38:45 Information] Microsoft.AspNetCore.Authentication.JwtBearer.JwtBearerHandler
Successfully validated the token.

info: Microsoft.AspNetCore.Authentication.JwtBearer.JwtBearerHandler[2]
      Successfully validated the token.
info: Microsoft.AspNetCore.Authentication.JwtBearer.JwtBearerHandler[2]
      Successfully validated the token.
[21:38:45 Information] Microsoft.AspNetCore.Authentication.JwtBearer.JwtBearerHandler
AuthenticationScheme: BearerIdentityServerAuthenticationJwt was successfully authenticated.

my guess is that this does not work:
opts.Authority = Configuration.GetSection("Id4Settings")["Authority"];

Thanks Dominick,
The settings are being pulled from the config correctly and the issue has been resolved by specifying opts.ApiSecret.
As I understand it the secret is only necessary if the Api needs to validate a reference token. I'm sending a jwt so it seems to me that the back channel communication is not necessary and thus the secret shouldn't be either...
Interestingly I now get an introspection error and still successful validation at the same time. So from the perspective of my api clients everything is working again but the api logs look like this:
[11:30:38 Error] IdentityModel.AspNetCore.OAuth2Introspection.OAuth2IntrospectionHandler
Error returned from introspection endpoint: Unexpected character encountered while parsing value: <. Path '', line 0, position 0.

[11:30:38 Information] Microsoft.AspNetCore.Authentication.JwtBearer.JwtBearerHandler
Successfully validated the token.

fail: IdentityModel.AspNetCore.OAuth2Introspection.OAuth2IntrospectionHandler[0]      Error returned from introspection endpoint: Unexpected character encountered while parsing value: <. Path '', line 0, position 0.
info: Microsoft.AspNetCore.Authentication.JwtBearer.JwtBearerHandler[2]
      Successfully validated the token.
fail: IdentityModel.AspNetCore.OAuth2Introspection.OAuth2IntrospectionHandler[0]      Error returned from introspection endpoint: Unexpected character encountered while parsing value: <. Path '', line 0, position 0.
info: Microsoft.AspNetCore.Authentication.JwtBearer.JwtBearerHandler[2]
      Successfully validated the token.
[11:30:38 Information] IdentityModel.AspNetCore.OAuth2Introspection.OAuth2IntrospectionHandler
BearerIdentityServerAuthenticationIntrospection was not authenticated. Failure message: Error returned from introspection endpoint: Unexpected character encountered while parsing value: <. Path '', line 0, position 0.

[11:30:38 Information] Microsoft.AspNetCore.Authentication.JwtBearer.JwtBearerHandler
AuthenticationScheme: BearerIdentityServerAuthenticationJwt was successfully authenticated.

I just compared that with the behavior and log output from here:
https://github.com/IdentityServer/IdentityServer4.Samples/blob/release/Clients/src/SampleApi/Startup.cs
I can't repro any of those issues - please compare that to your project.

I'm also getting this "You must either set Authority or IntrospectionEndpoint" exception. But I can not resolve it by setting an ApiSecret.
Now I switched to the plain JwtBearer and with it, it works. But not with the IdentityServerAuthentication.

I gave up on trying to upgrade my projects to .net core 2.0 and instead just created new projects and ported code over. That resolved the issue for me.

OK - I tried it again and cannot repro any of the issues. Glad it's working now.

I was struggling with this issue and getting the same exception - in my case, I had copied and pasted the token into the Authoriation header incorrectly, so it wasn't a valid JWT. Fixing the token immediately fixed the issue.
Based on that and @erikkolo's comment, it looks like failure to extract a valid JWT causes this exception.

I added more logging (trace level) - so it should be easier to diagnose what kind of token was found.

Is there a way to have this return the response as a 401 instead of a 500?  In pre 2.0 the request would just go through unauthenticated and I'd return a 401 so the client could react off that 401 status code and request a new token
For now I injected some middleware to catch the exception and modify the response
 public async Task Invoke(HttpContext context)
        {
            try
            {
                await _next(context);
            }
            catch (InvalidOperationException exc)
            {

but wasn't sure if there exists a better integration point

If there is a 500, that's a bug. What do the logs say?

Pretty much the error message from the original post but let me grab mine real quick...  Before if there was a bad token the request would still just get through to controllers that allowed anonymous access and the request would just be unauthenticated.  So I would just take these cases and return a 401 back to the client if the client had intended to be authenticated.
I have some tests I run against asp.net core which just insert garbage into the Bearer header token to test this behavior.
            An unhandled exception has occurred while executing the request
System.InvalidOperationException: You must either set Authority or IntrospectionEndpoint
   at Microsoft.AspNetCore.Builder.OAuth2IntrospectionOptions.Validate()
   at IdentityModel.AspNetCore.OAuth2Introspection.PostConfigureOAuth2IntrospectionOptions.PostConfigure(String name, OAuth2IntrospectionOptions options)
   at Microsoft.Extensions.Options.OptionsFactory`1.Create(String name)
   at Microsoft.Extensions.Options.OptionsMonitor`1.<>c__DisplayClass10_0.<Get>b__0()
   at System.Lazy`1.CreateValue()
   at System.Lazy`1.LazyInitValue()
   at System.Lazy`1.get_Value()
   at Microsoft.Extensions.Options.OptionsCache`1.GetOrAdd(String name, Func`1 createOptions)
   at Microsoft.Extensions.Options.OptionsMonitor`1.Get(String name)
   at Microsoft.AspNetCore.Authentication.AuthenticationHandler`1.<InitializeAsync>d__42.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationHandlerProvider.<GetHandlerAsync>d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at IdentityServer4.Hosting.FederatedSignOut.FederatedSignoutAuthenticationHandlerProvider.<GetHandlerAsync>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationService.<AuthenticateAsync>d__10.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at IdentityServer4.AccessTokenValidation.IdentityServerAuthenticationHandler.<HandleAuthenticateAsync>d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationHandler`1.<AuthenticateAsync>d__47.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationService.<AuthenticateAsync>d__10.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authorization.Policy.PolicyEvaluator.<AuthenticateAsync>d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Authorization.AuthorizeFilter.<OnAuthorizationAsync>d__15.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.<InvokeFilterPipelineAsync>d__17.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.<InvokeAsync>d__15.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Builder.RouterMiddleware.<Invoke>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at IdentityServer4.Hosting.IdentityServerMiddleware.<Invoke>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.<Invoke>d__6.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Cors.Infrastructure.CorsMiddleware.<Invoke>d__7.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at IdentityServer4.Hosting.BaseUrlMiddleware.<Invoke>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at IdentityServer4.Hosting.IdentityServerMiddleware.<Invoke>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.<Invoke>d__6.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Cors.Infrastructure.CorsMiddleware.<Invoke>d__7.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at IdentityServer4.Hosting.BaseUrlMiddleware.<Invoke>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.<Invoke>d__7.MoveNext()
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
      Request finished in 885.5916ms 500 text/html; charset=utf-8

But what token are you actually sending - JWT or reference token?

My implementation uses JWT tokens.
For my test
I just send a GUID so it's set to something to emulate a "bad token"
 HttpClient.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", Guid.NewGuid().ToString());

I don't have anything that sets the client like this
client.AccessTokenType = AccessTokenTypes.Reference;

I don't set the AccessTokenType anywhere

So does it work when you send a valid JWT token? Also - have you tried setting the SupportedTokenTypes on the handler?

OK - I had a look -
so basically you are sending a token that looks like a reference token, but don't configure the handler correctly for reference tokens (the ApiSecret is missing) - right?
I agree that the exception is misleading - so either

configure the handler with an ApiSecret
restrict the supported token types to JWT
don't send garbage for testing

On a related note - if you are using JWTs only - our handler doesn't really give you any extra features. It is only useful if you need to support JWTs and reference tokens in the same API.

I also had this problem and had to switch.
https://github.com/damienbod/AspNetCoreAngularSignalRSecurity/blob/master/ApiServer/Startup.cs#L99
I have no bearer token in the header.

So it looks like setting the Supportedtoken to JWT worked

it looks like setting the secret worked as well... I had the secret set on the Clients that get added in later on from this call AddInMemoryClients but I'm probably just mixed up with how I'm thinking it ties together. I figured since the ApiName matched up then handler just used those clients

hehe ... I added this test mainly because I noticed that tokens seem to get invalidated for lots of unforeseen reasons ... I have certificate data encryption setup and noticed if the DataProtection libraries get updated then all tokens from a previous versions invalidate....   So gradually I just ended up where I'm at with these tests to try and cover my #@$ in whatever scenarios I can think of.   They might also be left over from when I was using a beta version of ASOS :-/

Either way
Thanks for the info about just switching to AddJwt
Thanks for the link to the sample as well @damienbod   ..  I'll just go that route to minimize possibility of things like this coming up

But after some experiments the issue goes away :))
If I supply the api secret (Identity and api):
IdentityServerWithAspNetIdentity (Config.cs):
ApiSecrets = new List()
{
new Secret("api_secret".Sha256())
},
Api:
options.ApiSecret = "api_secret";

For me this error occurs when sending a request from a JavaScript client to Web API only when Authorization header is on the request but the token is null, like so - Authorization: Bearer null or Authorization: Bearer

I'm getting this exception when "access" instead of valid JWT is sent from HttpClient...

see above discussion.
https://github.com/IdentityServer/IdentityServer4/issues/1627#issuecomment-339102001

When a malformed JWT is passed to a .NET Core 2.0 API using IdentityServer Authentication and a 500 status code is returned instead of a 401, setting options.SupportedTokens = SupportedTokens.Jwt; in the Startup.cs ConfigureServices() solved this problem.
My Senario:
GET to API requiring OAuth (client credentials is grant type) where I sent some string that cannot be decoded as a JWT.
Header:
Accept:application/json
Authorization:Bearer SomeStringThatIsNotAJwtThatCantbeDecoded
Exception message in the body contains:
InvalidOperationException: You must either set Authority or IntrospectionEndpoint

see https://github.com/IdentityServer/IdentityServer4/issues/1627#issuecomment-339102001


(Chore) profile validations

164809205
Changes
Added UserModel
Re uses UserRecord and adds validation layer
export type ModelValidator = {
  isValid: (key: string) => boolean,
  getErrors: (key: string) => {},
  validate: (key: string) => Validation
}
export type UserModel = UserRecord & ModelValidator

Then you can do
const { errors, isValid } = profile.validate()

This is being used in UserStorage to avoid saving an invalid profile and now we are only saving user profiles via userStorage.setProfile
Added validation functions in model
Since validation functions being used in model validation are also exported from UserModel these validations are consistent across the app
export const getEmailErrorMessage = (email?: string) => {...}
userModelValidations = { email: getEmailErrorMessage, ... }

Just updated this PR with the requested changes.
Also, I realized that subscribing to profile was a problem to test so I've added an unsubscribe and change names to make this subscribe more obvious (getProfile -> subscribeProfileUpdates).
Now is using default privacy for settings except when there is a previous privacy setting on that field


#34 Updating to newer TyRAS lib again.

Codecov Report

Merging #36 (995d13b) into main (c1df831) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines          203       203
  Branches        41        41
=========================================
  Hits           203       203

Flag
Coverage Δ

metadata-jsonschema
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Nt/tweaks

What does this PR?
two fixes applied to editor

text getting clipped at the end
in multiple image upload, image link added in between texts

Where should the reviewer start?
editorContainer.js
applyWebLinkFormat.js
Steps to reproduce
Uploaded multiple images in between paragraphs ideally
Issue number
fixes #1890
Screenshots/Video

Pending Fixes

Multiple image reordered...
The order for images is messed up by ImagePicker app receives reordered list of selected images. no ImagePicker fix found so far.. however, in case it is not possible with ImagePicker, we can introduce and reordering modal to upload them in order. perhaps a fix for another release

@noumantahir modal for reordering seem good approach if we cannot find a fix for upload order selection


Badly rendered emoji

In some cases it happens that it does not render well
Steps to reproduce the error

Install Aur version

Possible solution

It is possible that some dependency is missing in the build flow in github action

Solved


chore(main): release 1.2.0

:robot: I have created a release beep boop
1.2.0 (2024-03-12)
Features

create event api (#8) (c450524)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ubccsss/blood-for-life-backend/releases/tag/v1.2.0 :sunflower:


basehub: rely on a single user-scheduler replica

Fixes #3865

The issue being fixed (#3865) includes the motivation and why I think its safe enough to do.

Please bring this up in the next sprint planning meeting so we can prioritize this accordingly with the rest of our tasks.

I'll try to do that, but I propose if we don't manage to allocate time to review this in the next sprint, I'd like to propose we merge it without further review. I'm very confident on this change is fine to make without regressions.
I'm looking at shared cluster cost in aws, and found that we have two code nodes running due to too many pods, where each node can schedule up to 57 pods. With this change, we can almost (2 pods too much still) go below the need to have two core nodes.

With this PR merged and https://github.com/2i2c-org/infrastructure/issues/3999 resolved, we would cut core node costs by half in 2i2c-aws-us

I'll go for a merge here to save 2i2c-aws-us and catalystproject-africa almost 200 USD a month per cluster in core node pool costs. I'm very confident on this change being safe to make @yuvipanda and have self-reviewed my thinking about this a ~fourth time or so now.


Spawn vehicle at requested orientation

Part of

https://github.com/osrf/lrauv/issues/48

Requires

https://github.com/ignitionrobotics/ign-gazebo/pull/1263
https://github.com/ignitionrobotics/ign-msgs/pull/212
Forward-port: https://github.com/ignitionrobotics/ign-gazebo/pull/1293

This is a subset of

#81

Make use of the roll, pitch and heading fields on the init message when spawning a vehicle.
I also changed the test to run paused, so we don't have the physics affecting the spawn pose and we can check it more precisely.
This takes an alternative approach to #81. Instead of rotating the model to face North by default, we introduce offsets when receiving spawn commands. This means we must be mindful of the fact that the vehicle faces West by default all the time when looking at poses, which is extremely error prone. I'd much rather change the model to match NED / FSK by default, but as explained in https://github.com/osrf/lrauv/issues/48#issuecomment-1018063778, there are physics issues with using a Z-down model that we'll need more time to track down.

I forgot that the orientation is in NED, so this can't escape #81 .

Upstream's forward-port was merged. After tonight's nightlies are built, we should retrigger CI here.

Ahh last night's ign-gazebo7 nightly failed:
https://build.osrfoundation.org/job/ign-gazebo7-debbuilder/159/

Yay, the latest nightlies are out and CI is :green_circle:


feature(transpiler): add key to transpile method

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/ngneat/transloco/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)

I may need help with testing since this feature doesn't add any functionality directly, but it does not break any existing tests afaik

[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

https://github.com/ngneat/transloco/issues/568
The TranslocoTranspiler.transpile does not give the key of the current translation.
Issue Number: 568
What is the new behavior?
The TranslocoTranspiler.transpile now accepts the key as a parameter, and the TranslocoService.translate method now passes in the key.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information
This is one of my first contributions to an open source project, so I expect that I will need to make some changes.

@jacksonopp fix the types please and force push all the changes in one commit made using yarn commit/npm rnu commit.

Thank you for your patience as I work thru my first OSS contribution by the way!

@jacksonopp please note that the CI is failing

@shaharkazaz
Looking into the unit tests
Looks like we're seeing a peer dependency mismatch around rxjs. I think running an npm install should fix this, and would involve committing a change to package-lock.json. Is that okay with you?
Looking into the e2e tests, I'm seeing the following failures:

locale.spec.ts is failing because it is displaying the wrong unix date, and it fails regardless of whether or not we are using the custom transpiler. I was playing around with changing my time zone, and that seemed to affect the displayed output. Adding timeZone: 'UTC' as a parameter to the translocoDate pipe normalizes the timezone, and seems to solve this issue. I'm not sure what has changed to cause this. Does this sound correct to you?

full-cycle.spec.ts is failing because the custom transpiler just returns the value without doing any transpiling. Removing the custom transpiler from the providers array seems to fix this issue. Since we've updated the documentation site with the new key input, I think its fine if we do not include this in the transloco playground. It wasn't there before anyway.

Thoughts?

@jacksonopp

You didn't make any change on the package so I'm not sure why would that change anything 🤔 But let's try it, make sure you have node 16+ and npm 8+.
Let's try to remove the custom compiler from the playground.
I don't think there was any change in the locale area, and last couple of commits passed, I'll take a look when I get time if the issue persists, anyways you didn't cause the issue 🙂

@shaharkazaz

Updated package-lock.json. I used node v16.15.1 and npm 8.11.0
Removed the custom transpiler from the playground
Running through the specs, I'm now seeing the unit tests around locales failing for the same reason as the e2e tests, but sounds like you're going to investigate it.

@shaharkazaz Any update on this? Looks like all specs are passing now.

@jacksonopp sorry man I'm swamped, I'll get to it as soon as I have some free time to do one last review 🙏

@shaharkazaz I understand you are probably busy, but any more updates?

@jacksonopp Sorry man for disappearing, had a lot of stuff going on and just couldn't find the time.
If you'd like we can pick this up again.

@shaharkazaz All good. I've updated my fork to match master here.

@jacksonopp nice work on this man. I hope to see you contributing more 😄


[Draft] Allow registering search attributes without Advance Visibility enabled

What changed?

Remove validation for Advance Visibility Store
Add Advance Visibility Config check before updating ElasticSearch/OpenSearch mapping
Remove co-related test of validate 'no advanced config' for AddSearchAttribute
Update CHANGELOG.md

Why?
It's convenient to test the search attribute API in the workflow code before using advanced visibility.
How did you test it?
Tested locally with AdvancedVisibility Enabled and AdvancedVisibility Disabled
Potential risks
Release notes
Allow registering search attributes when Advanced Visibility is not enabled
Documentation Changes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

lgtm. Can you also test it with https://github.com/uber-common/cadence-samples/tree/master/cmd/samples/recipes/searchattributes ?

lgtm. Can you also test it with https://github.com/uber-common/cadence-samples/tree/master/cmd/samples/recipes/searchattributes ?

Passed using ./docker/dev/cassandra-esv7-kafka.yml setup.

Pull Request Test Coverage Report for Build 01874a65-5684-4135-a468-cede0b8739e3

11 of 17 (64.71%)  changed or added relevant lines in 1 file are covered.
85 unchanged lines in 15 files lost coverage.
Overall coverage decreased (-0.02%) to 57.078%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

service/frontend/adminHandler.go
11
17
64.71%

Files with Coverage Reduction
New Missed Lines
%

common/task/weightedRoundRobinTaskScheduler.go
1
89.64%

client/history/client.go
2
38.1%

client/history/metricClient.go
2
45.3%

service/frontend/adminHandler.go
2
47.88%

service/history/handler.go
2
47.15%

service/matching/matcher.go
2
91.46%

common/persistence/nosql/nosqlplugin/cassandra/workflow.go
3
59.55%

common/persistence/statsComputer.go
3
93.57%

service/frontend/workflowHandler.go
4
59.86%

service/history/task/fetcher.go
4
91.24%

Totals

Change from base Build 01874884-43c6-4cf8-b6b8-ecc8c5686563:
-0.02%

Covered Lines:
85246

Relevant Lines:
149351

💛  - Coveralls


Would love it if Command-D did word lookup for specific language

Currently Command-D does a straight search for the current word across all installed Dash languages, and the results are relatively slow to come back since Dash is searching all of its languages.
Would be great if it could do a search for only the current TextMate syntax being used.
So for ex. searching for "cd" while editing a shell script, should only search the shell script language in Dash. Results would come back much quicker, also.

@edrozenberg Option + D does that. I can't remember the history of this very well, but it used to be that we had Command + Shift + D doing that I believe, then it had to be change to what we have now.
There should be a closed issue/PR that has the change.


Standardize on a way Windows/Linux can test MacOS and iOS apps

Problem: All issues aren't being tested on macOS and iOS because some contributors have Windows or Linux systems and they're unsure of how to test macOS and iOS.
Solution: Find a tool/VM/Cloudservice that can be used for Windows/Linux users.  Review it then standardize on the best. Update CONTRIBUTING.md to include details.
Alt Solution:
Make it a necessity for all contributors to test on all platforms.  For any new issues created after a deadline, ask contributors to confirm they can test MacOS and iOS, if not, they won't be hired.  (existing open issues will be allowed some flexibility, C+ can test)
Discussion in This thread in #expensify-open-source and this thread in #contributor-plus

Working on it. Will update in a few hours.

Draft of my suggestion in this doc - https://docs.google.com/document/d/1TD8A-SQbBN2EsnF98cEib2wiERK68fux2P0LGSkobrg/edit

Progress so far.
The doc is updated. The video demonstrates the high responsiveness and clipboard access. Basically, the cloud mac is as good as a local machine. A contributor can do all the initial macos setup using this script.
I'll verify the doc after lunch, and add some finishing touches.
https://user-images.githubusercontent.com/29673073/152134356-af4aa73d-3843-433b-a25f-136c2605f58a.mp4

The doc is ready. @Anthony highlighted that reemo is free only for personal use.
Changes made: use chrome remote desktop instead of reemo. It has the same performance, but it's initial setup is a bit more harder as it can't be done using a shell.
Shoutout to @kidroca for mentioning chrome remote desktop

Thanks for the updates @rushatgabhane , it's easier to follow here than in the thread (mainly just because of volume of the discussion).
I reviewed the doc, great job on the steps for Chrome Remote Desktop.
Is there more work/testing that's needed? We're planning to make macOS/iOS mandatory starting on Friday.  I think it's best to share your google doc with contributors to start then, after a few weeks, we can look into creating an .md file to add to the E/App repo.  Think that's a good approach?

it's easier to follow here than in the thread

I agree.

Think that's a good approach?

This was discussed on slack, so I'll put a TL;DR; for anyone who might read.

Link the doc in contributing.md
On Feb 4, make an announcement on expensify-open-source.
After a few weeks and hopefully some feedback from contributors, create a .md file.

@rushatgabhane 10 days overdue. Is anyone even seeing these? Hello?

@rushatgabhane 10 days overdue. I'm getting more depressed than Marvin.

@rushatgabhane 10 days overdue. Is anyone even seeing these? Hello?

@rushatgabhane 10 days overdue. I'm getting more depressed than Marvin.

@rushatgabhane 10 days overdue. Is anyone even seeing these? Hello?

@rushatgabhane 10 days overdue. I'm getting more depressed than Marvin.

@rushatgabhane 10 days overdue. Is anyone even seeing these? Hello?

@rushatgabhane 10 days overdue. Is anyone even seeing these? Hello?

MelvinBot had a panic attack yesterday. Hopefully he's feeling better today.

@rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

I'm awaiting feedback from some contributors who have used the doc to test some PRs.
slack thread

@rushatgabhane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

D'oh, this def shouldn't have been left as a Daily, sorry @rushatgabhane .
I made a weekly for now, once you drop in some feedback we can hopefully close, right Rushat?

Sorry for the delay, I received positive feedback from a contributor (1 day ago)
I'll loop back to this soon.

The next step is to put all this in a .md file (unless you think doc is a better idea)
And I'll try to get this done tomorrow.

Assigning myself as CM so I (hopefully) don't forget to compensate you for the work @rushatgabhane

Thanks.

On a scale of 1-100 how confident are you that your solution is best and that the current process and documentation are dialed in?

Hmm, I'd say like 95. There's always room for some incremental improvement, but none that I can think of rn.
We should update the .md file in case any step becomes outdated, and or if contributors find it difficult to follow.

@mallenexpensify Now that the PR is up, lemme know if the changes look good, and what you think regarding converting doc to .md file

Reviewed and commented there, looking good

Rushat, we discussed internally and think $1000 is fair compensation for this project, do you agree?  If so I'll create an Upwork job to get ya paid

@mallenexpensify that sounds great! Thanks so much 🙇

Wonderful. I created a job and invited you, let me know once you've accepted
https://www.upwork.com/jobs/~01594cea0f8f35f46b

@mallenexpensify done ✅

Hired, let me now once you've accepted... again (damn Upwork...) and I'll pay

Accepted 😂

Paid!  Should we leave this open til the .md file is deployed to production? To be safe?
https://github.com/Expensify/App/pull/7992

@mallenexpensify the .md file is already on the homepage of this repository. There's no QA for the PR, and deploying it to production won't make any changes to the app because we're just changing a .md file.
So, let's close this issue. It can always be reopened if needed
Please let me know if this is okay :)

When in doubt.. close it out!  (as you said, it can always be reopened).
What's the final, permanent link for it?

What's the final, permanent link for it?

Do you mean this? - https://github.com/Expensify/App/blob/main/TESTING_MACOS_AND_IOS.md

Yup, thanks!  Just saw you updated the CONTRIBUTING.md to link to the new .md file too 😎.  Do you think we need to share/include it anywhere else?  Only place I can maybe think of would be in the PR template.  Not sure, at that point, if it'd be helpful or not (ie. if someone is already to the stage of submitting the PR, is it safe to assume they know they need to test on mac?

If someone is able to post a proposal and submit a PR, then it's safe to assume that they've read contributing.md
Besides, we already have it linked (indirectly) in the PR template


When I call Trainer.test it calls both "test" and "fit" stages of setup - should it just be "test"

🐛 Bug
When I call Trainer.test it calls both "test" and "fit" stages of "setup" function.  Shouldn't it just call test?
To Reproduce
You can actually look through the code to see that this will happen since self.fit() is called.  Follow trainer.test() then choose the function self.__test_given_model(model, test_dataloaders) and then self.fit(model) is called.  Also, you can just print out "stage" in the setup function and you will see both "fit" and "test" are called when trainer.test(model=model, test_dataloaders=dataloaders) is called.  I'm using the "fit" value for training, should I be using something else?

Can you check on master? It's fixed #2624.

@yukw777 mind have look? :]

@Borda it's already fixed on master.


bug: Animcations in 4.8.1 errors: "undefined is not a function (near '...element.animate...')"

Bug Report
Ionic version:

[x] 4.x
Current behavior:
Navigation animations do not load correctly, ie: modals don't render and some navigations have choppy or non-existent animations.
Expected behavior:
Modals should load correctly and navigation should animate correctly.
Steps to reproduce:
Modals created do NOT animate or open properly.
Other information:
We reverted to 4.7.4 and the animations work and modals are now working correctly again.
Ionic info:

   Ionic CLI                     : 5.2.6
   Ionic Framework               : @ionic/angular 4.7.4 (/Users/morgan.wood/Source/CRM_WebApp/node_modules/@ionic/angular)
   @angular-devkit/build-angular : 0.12.4
   @angular-devkit/schematics    : 7.2.4
   @angular/cli                  : 7.3.9 (/Users/morgan.wood/Source/CRM_WebApp/node_modules/@angular/cli)
   @ionic/angular-toolkit        : 1.2.3 (/Users/morgan.wood/Source/CRM_WebApp/node_modules/@ionic/angular-toolkit)

Capacitor:

   Capacitor CLI   : 1.1.1
   @capacitor/core : 1.1.1 (/Users/morgan.wood/Source/CRM_WebApp/node_modules/@capacitor/core)

Cordova:

   Cordova CLI       : 9.0.0
   Cordova Platforms : ios 5.0.1
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 4.0.1, (and 10 other plugins)

Utility:

   cordova-res : not installed
   native-run  : not installed

System:

   NodeJS : v12.9.0 (/usr/local/bin/node)
   npm    : 6.10.2
   OS     : macOS Mojave
   Xcode  : Xcode 10.3 Build version 10G8

@liamdebeasi Noticed this in production through our error reporting service for Safari browsers.  Seems to be partially fixed in<EMAIL_ADDRESS>The explicit error on .animate being undefined no longer exists but my modal that is presented auto dismisses now. This behavior is not present on 4.7.4.
I will attempt to reproduce it in a starter project although I suspect it has to do with the fact that I 'm presenting two modals on top of each other.

Unable to reproduce in a starter project. Reverting to 4.7.4 for now until I am able to investigate further.

Ok no problem. When you're able to reproduce feel free to open a new issue, and we can continue the conversation there. Thanks!

same issue on 4.9.0 only if run on device from xcode

@goelectricstations This issue has been closed. Please create a new issue if you are experiencing further problems. Thanks!


"System Error" response after query.

Hi guys,
Our app stopped working over the weekend.
JWT request and access token is sent and received fine. When sending the request to the report endpoint, we're now getting a response with an unhelpful message:
{'reason': 'There was an error processing your request. Request id: uZdK1wktssgfLZqoIK7phGfMu9MOr6Ck.', 'message': 'System error'}
The request ID changes each time obviously.
I'm looking at the insights dashboard for some of our other BUs integrations and they're showing 200 responses being recorded over the weekend, but not ours.
Is there any way to get any insight into this? Is System error just a generic error, is there something wrong on the endpoint side or is there something wrong with our code? I've rolled back quite a few commits to multiple instances where this was working but I'm getting the same error.
Any advice would be very much appreciated.

I was passing company ID as org ID

Ah -- good to know. I'm glad you got it figured out.


interpreter.json should be saved in $ZEPPELIN_CONF_DIR

The path for interpreter.json is actually hardcoded in ZeppelinConfiguration.getInterpreterSettingPath(). I would expect to see this file in $ZEPPELIN_CONF_DIR.

Moved to https://issues.apache.org/jira/browse/ZEPPELIN-30


MGMT-1487 Agent might not restart in case of failure

Updateed the restart policy:
Set StartLimitIntervalSec to 0 to disable any kind of rate limiting
Set RestartSec to 3 seconds delay between executions

http://<IP_ADDRESS>:8080/job/test-infra/1698/


Delete group in GroupsController MARATHON-7301

Summary:
Re-implement delete group in akka.http GroupsController.
JIRA issues: MARATHON-7301

@jeschkies all your comments should be addressed now


Fix a typo in Multi-region Capabilities Overview page

The docs say that database's primary region is defined in Step 1 while actually it is Step 2.

@MantasMiksys Thank you for your contribution! We recently moved our default branch from master to main as well as restructured our docs content. I went ahead and reapplied the changes in this PR to #17210.


Add basic build CI workflow

Add a basic CI action that just checks formatting then builds. No tests.

forc build doesn't actually return a non-successful status code on a failed build so this will always pass.
I've just made a PR to fix this: https://github.com/FuelLabs/sway/pull/539


Fixed Bug #56 "Update SpiltAE internals to snake_case"

Reference Issues/PRs

What does this implement/fix? Explain your changes.
Updated the camelCase in SplitAE file to snake_case
Any other comments?

Thanks for the contribution! There are a few lines that are too long for the style guidelines which is why travis-ci failed, but looks pretty good. Once you fix that up we'll get another reviewer to confirm everything.

Looks good to me. I'm going to ask another collaborator to take a look and confirm since there are a lot of changes here.


net: lwm2m: Allow setting string to zero length

Lwm2m firmware object have defined a write of zero length string as a cancel operation.
So allow lwm2m_set_opaque(path, NULL, 0);

Added tests as well.

Rebased to get fix for the buffer size.


Added artifacts for kernel modules/extensions

Please update with origin master and fix the separator.

This should be good now


Set partials path prefix/suffix

Would be great if I could optional define these when calling node-simple-html-includes. Rather than:
@Html.Partial("./path/to/partial.html", ...
If I could just:
@Html.Partial("partial", ...

I agree! Perhaps I could check the package.config file for some variable or setting? Any suggestion or feedback about how to best implement this?


Documentation for LynxKite Operations in Python

Description
In this pull request I'm trying to finish what I started "quite" some time ago. That is, I'm trying to improve the LynxKite documentation for the Python API.
On a high level, I have implemented a script that can convert the .asciidoc operations documentation to Sphinx compatible Python descriptions for the LynxKite operations that a user can call on LynxKite. These descriptions are stored in the file called operations.py. As a result, a user can now call help(...) on a given operation and see some meaningful documentation.
E.g.:
import lynx.kite
lk = lynx.kite.LynxKite(address='http://localhost:2200/')
help(lk.createExampleGraph)

now shows:
Help on function createExampleGraph in module lynx.kite:

createExampleGraph(*args, **kwargs)
    Creates small test graph with 4 people and 4 edges between them.

I also added a build.sh script for generating the operations.py and Sphinx documentation in one go. Lastly, I fixed a parameter descriptions in a few .asciidoc files.
Screenshots of how the Sphinx documentation looks like

@darabos I think it's good enough to merge right now. I changed the formatting in a few .asciidoc files, because that made the parsing of the files much easier for me. I hope this is ok.
If you want, you can checkout the generated Sphinx documentation yourself to see whether it's satisfactory enough.

There may be a special place in the afterlife for people who convert AsciiDoc to RST with regular expressions. 😄  Hopefully it's a good place. Thanks!


cleaned the review page a bit not final

Could you take a look at the conflicts that need to be resolved in reviews.handelbars? Thank you!


Rollback fails because Capifony searches for a release it just deleted

I have a problem with the rollback of Capifony.
When there's an error during the deploy, it rolls back and the rollback fails.
*** [deploy:update_code] rolling back
  * executing "sudo -p 'sudo password: ' rm -rf /var/www/capifony/releases/20150923104657; true"
servers: ["ec2-54-154-86-179.eu-west-1.compute.amazonaws.com"]
[ec2-54-154-86-179.eu-west-1.compute.amazonaws.com] executing command
command finished in 110ms
**failed: "sh -c 'sudo -p '\\''sudo password: '\\'' sh -c '\\''cd /var/www/capifony/releases/20150923104657 && SYMFONY_ENV=prod /usr/local/bin/composer.phar install --no-dev --verbose --prefer-dist --optimize-autoloader --no-progress'\\'''" on ec2-54-154-86-179.eu-west-1.compute.amazonaws.com**

Then the error on the browser is:
Compile Error: Symfony\Component\Debug\DebugClassLoader::loadClass(): Failed opening required '/mnt/app/www/capifony/releases/20150923104657/src/MyApp/CoreBundle/MyAppCoreBundle.php' (include_path='/mnt/app/www/capifony/shared/vendor/phpunit/phpunit-mock-objects:/mnt/app/www/capifony/shared/vendor/phpunit/php-file-iterator:/mnt/app/www/capifony/shared/vendor/phpunit/phpunit:/mnt/app/www/capifony/shared/vendor/symfony/yaml:.:/usr/share/php:/usr/share/pear')

From what I understand, it tries to do a composer install on the<PHONE_NUMBER>4657 release. However, this is the version it just deleted (rm -rf /var/www/capifony/releases/20150923104657). So it's normal that it fails. But I don't understand why it does it on that order. I didn't add any tasks before or after the rollback. Is this the normal behavior?
Thanks.

If this can help, this is part of my deploy.rb:
set :application,                    "myapp"

set :deploy_to,                      "/var/www/capifony"
set :app_path,                      "app"
set :repository<EMAIL_ADDRESS>set :scm,                              :git
set :branch,                          "master"
set :model_manager,           "doctrine"
set :symfony_env_prod,      "prod"

#recette
role :web,                    "myserver"
role :app,                    "myserver", :primary => true

set :use_sudo,                     true
set :user,                             "ubuntu"
set :keep_releases,             10
set :assets_install,                true
set :dump_assetic_assets,     true
set :use_composer,              true
set :composer_bin,               "/usr/local/bin/composer.phar"
set :update_vendors,            false             # false = install mode
set :clear_controllers,            false
set :shared_files,                  ["app/config/parameters.yml"]
set :shared_children,            [app_path + "/logs", app_path + "/Resources/images/myimages",   web_path + "/media", web_path + "/zip", web_path + "/temp", "vendor"]
set :deploy_via,                    :remote_cache
set :writable_dirs,                 ["app/cache", "app/logs" , "app/../web", "app/Resources/images/myimages"]
set :webserver_user,          "www-data"
set :permission_method,       :chown
set :use_set_permissions,     true

logger.level = Logger::MAX_LEVEL

before "deploy", "maintenance_enable", "cron_stop", "permissions_capifony", "finalize_update"
after "deploy", "deploy:cleanup", "others_tasks", "cron_start"
before "symfony:cache:warmup", "symfony:doctrine:schema:update"


Register

As a user, I want to be able to register myself with an e mail address and a user   name so that I can login into Flattie

#47


new facebook interface

unable to obtain client id, gives authentication error.

Seems no one is still reacting here 👎


fix/web response io writer case

fix: handle io.Writer case in web response and close body
feat(web): update dependencies

Thanks so much. I had to pull out the relevant stuff because PR was against old stuff.


Even-Odd winding not working properly on dx11

the green fill. idk how hard is it to fix, seems to be compute shader bug. (or maybe wrong parameter transfer)
dx11: https://i.imgur.com/JwbARtG.png
dx9:  https://i.imgur.com/FqYHY2V.png

This is weird since a fix (ee0e01283099c5e8e38c75501d8ba0d31dc3c9e6 and 8cc856bc7847cf3146995325ba913908a4358788) was made quite a long time ago. In addition, a PR https://github.com/servo/pathfinder/pull/513 has been submitted to the original repo. A regression might have happend at some point.


[core] sorting the document according to the dependencies

What changes were proposed in this pull request?

topological sorting of the imported document

How was this patch tested?

Manually

Do not merge.

We can see in this PR -> https://github.com/cloudera/hue/pull/3158 that for python2 unittest is failing and for python3 it is passing.

@ranade1 @wing2fly @Harshg999 please take a look.

@ranade1 @amitsrivastava @wing2fly @Harshg999 any other corrections needed or good to merge now?


Crashes when all windows are removed from DStack layout

Unsigned Integer overflow on all tiling layouts (except monocle).

Fixed.


Enable pipebuild in CoreRT

These are only the changes necessary to enable pipebuild for all platforms on DevDiv VSO: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/index?definitionId=4582&_a=completed.

Add checked-in build definitions and pipeline definition.
Add some extra scripts that are helpful for CI builds.
Minor change to how runtest.sh determines the test folder, this seems to be a bash version difference on the build machines.

Hi @crummel, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

@SedarG @jkotas @joshfree @MichalStrehovsky

just two comments above.  Otherwise LGTM

@crummel Can this be merged?

@jkotas Yes, it's ready.


Update README to Include Information on Performance Degradation and Mitigation Options

This Pull Request updates the README file for the optimum-habana repository to inform users about potential performance degradation due to the PyTorch 2.5 upgrade and provides options to mitigate this issue. Additionally, it includes information about an upcoming Gaudi-specific safe_softmax implementation that will improve performance in the next release of Optimum Habana.

@astachowiczhabana I think we should just put this message in the main README of the repo: https://github.com/huggingface/optimum-habana/blob/main/README.md
Also @libinta was telling me that it would be helpful to link to the Gaudi doc as there will be a similar message there once SynapseAI 1.19 is released.

I've checked following files, and they dont contain models requiring adding sdp_on_bf16 param:
/examples/zero-shot-object-detection/README.md
./examples/summarization/README.md
./examples/text-classification/README.md
./examples/text-to-speech/README.md
./examples/translation/README.md
./examples/image-to-text/README.md

@astachowiczhabana Please merge the v1.15-release into your branch. We'll merge this one directly there as it shouldn't go to main before SynpaseAI v1.19 is released.

@regisss it's ready, since this is only readme changes I don't think it needs any additional testing

@regisss it's ready, since this is only readme changes I don't think it needs any additional testing

@astachowiczhabana  as you are updating the readme, we do need ci test update. to speedup, we will provide patch for that today.


fix: added helper text for authentication namespace for advance kms form

fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2185164

/assign @SanjalKatiyar

/lgtm
but needs UX approve once before merging...

/cherry-pick release-4.13

/cherry-pick release-4.13-compatibility

/lgtm but needs UX approve once before merging...

/approve

/bugzilla refresh


Add steps to run in documentation

Add the steps to run the application locally in the host computer.

done


Use 1ES Self-Hosted Images provisioned with dependencies

Have to use cmdline rather than built in python task, because the python env variable chooses python2

Is this true even with the 1ES images?

Refers to: azure-pipelines/build/templates/dopapt-native-steps.yml:28 in 3d35aa5. [](commit_id = 3d35aa528ec0448f0c8d7095ad79ebd5bf602f33, deletion_comment = False)

Have to use cmdline rather than built in python task, because the python env variable chooses python2

Unfortunately yes =-/, I had a commit where I tried out the python task and it auto selected python 2. There's another azdo pipeline task for specifying a target python version within a job, but that requires python installation to the tools directory of the self-hosted agent, which would require us to have an additional installation step.

In reply to: 879487839

Refers to: azure-pipelines/build/templates/dopapt-native-steps.yml:28 in 3d35aa5. [](commit_id = 3d35aa528ec0448f0c8d7095ad79ebd5bf602f33, deletion_comment = False)


Building 74

Default value of the cards when drawn

Done, and added appropriate notes in the item section as well


Remove headers from error

Webhook-service was returning errors with header for content-type, which was causing go-rancher to call HtmlWriter in place of JsonWriter. So removing the header makes sure it is handled as json.
There were http: multiple response.WriteHeader calls messages in logs. Because in case of no error, the HandleError function was first writing the response code, which is not required in case of 200 code hence causing multiple WriteHeader calls

LGTM


chore(rpc): reusable eth api EthCall

Moves rpc call methods impl on EthApi to default trait impl EthCall

could we not make method name changes and keep it to a refactor? e.g. trace_block_with

one or two  methods have existed duplicate, I have removed them to not bloat codebase for no need


Can we convert files to unicode? Or at least have it fail more gracefully?

If a csv isn't encoded in unicode can we have it automatically convert it before parsing? Or, at least have a more instructive error message than "Internal Server Error" (ie it blows up). Here's what currently happens.

This is the bug that was happening with Miranda's file. Converting her file to UTF8 made it so that it worked. I have a copy of her file for when we are fixing this bug

Using this file in WTF -- https://www.dropbox.com/s/jpdnbdl5dni7rs2/HowAmericaInjuresItself_FromNEISS.xlsx?dl=0
Got the below error which seems to be new. This could also just be the same encoding issue we have seen previously.

Cool - Rahul - maybe we schedule some time early next week to work on this
together? I think we should fix pretty soon as it's holding up folks from
being able to use it in certain cases.

Assistant Professor of Civic Media and Data Visualization, Emerson College
Fellow, Emerson Engagement Lab
Research Affiliate, MIT Center for Civic Media
www.kanarinka.com | @kanarinka |<PHONE_NUMBER>
On Thu, Feb 4, 2016 at 10:14 AM rahulbot<EMAIL_ADDRESS>wrote:

We handle this well in WordCounter - see convert_to_txt
https://github.com/c4fcm/DataBasic/blob/a61c49f43464ac6a643af901a6f2a9b6d168f7fb/databasic/logic/filehandler.py#L85
and the associated unit tests
https://github.com/c4fcm/DataBasic/blob/master/databasic/logic/test/filehandlertest.py#L23
.
We can probably use the same "try-to-parse" approach to fix it for WTFcsv.
—
Reply to this email directly or view it on GitHub
https://github.com/c4fcm/DataBasic/issues/177#issuecomment-179892831.

Here's another testing data set that makes it fail: https://www.dropbox.com/s/byq9vqxh7754jz3/universityData 2.csv?dl=0

Closing this bug in order to make more specific progress on other errors


Not working corectly

BkCommonLib version:1.70-2
TrainCarts version:1.75
Spigot version: 1.8.x 1.9
Problem or bug:
Hello
I have problems with the Plugin in minecraft 1.8.x the plugin wont be enabled and wont work but in 1.9 it enables but wont work corectly no signs work and carts get invisible instant
Expected behaviour: Normal working in 1.8.x
Steps to reproduce: Install it in 1.8.8 and 1.9
MFG GoMini

Please use the correct version for 1.8


Relative width of GridColumns not working

It seems it doesn't compute the relative width, with gridunittype.star , correctly.
Example of code
  <Grid>
            <Layout>
                <ColumnDefinition GridUnitType="GridUnitType.Star" Width="1" ></ColumnDefinition>
                <ColumnDefinition GridUnitType="GridUnitType.Star" Width="3" ></ColumnDefinition>
            </Layout>
            <Contents>
                @foreach (var tipper in tippersManager.Tippers)
                {
                    <TipperRow tipper="tipper" row="rowCount"></TipperRow>
                    rowCount++;
                }
            </Contents>
        </Grid>

And the component TipperRow:
<GridCell Row="@row" Column="0">
    <Image Source="ImgSource" BackgroundColor="Color.Black"  HorizontalOptions="LayoutOptions.Start" VerticalOptions="LayoutOptions.Center" WidthRequest="1"/>
</GridCell>
<GridCell Row="@row" Column="1">
    <Label<EMAIL_ADDRESS>HorizontalOptions="LayoutOptions.Start" FontSize="25"  VerticalOptions="LayoutOptions.Center"
           FontAttributes="FontAttributes.Bold" />
</GridCell>

as you can see, I would expect, in each row of the grid, an image with Width 1/4 of the total width of the row, (or 1/3 of the label width).
But it seems each gridcell take up to 50% of the available space.

I finally tried to reproduce this and I'm not seeing any problem. Of course, it's 1/2 a year later, so who knows what changed since then 😄
Here's what I used:
Tipper class:
    public class Tipper
    {
        public string Name { get; set; }
    }

Main page:
<ContentView>
    <Grid ColumnDefinitions="1*, 3*">
        @{
            var rowCount = 0;
        }
        @foreach (var tipper in tippers)
        {
            <TipperRow tipper="tipper" row="rowCount"></TipperRow>
            rowCount++;
        }
    </Grid>

</ContentView>

@code
{
    List<Tipper> tippers = new List<Tipper>
{
        new Tipper {Name="First Tipper" },
        new Tipper {Name="Second Tipper" },
        new Tipper {Name="Third Tipper" },
    };
}

TipperRow:
<GridCell Row="@row" Column="0">
    <Image Source="@ImageSource" BackgroundColor="Color.Purple" HorizontalOptions="LayoutOptions.Start" VerticalOptions="LayoutOptions.Center" />
</GridCell>
<GridCell Row="@row" Column="1">
    <Label<EMAIL_ADDRESS>HorizontalOptions="LayoutOptions.Start" FontSize="25" VerticalOptions="LayoutOptions.Center"
           FontAttributes="FontAttributes.Bold" BackgroundColor="Color.Orange" />
</GridCell>

@code
{
    [Parameter] public int row { get; set; }
    [Parameter] public Tipper tipper { get; set; }

    string ImageSource = "https://upload.wikimedia.org/wikipedia/commons/thumb/9/9e/Twemoji_1f527.svg/60px-Twemoji_1f527.svg.png";

    int count;

    void IncrementCount()
    {
        count++;
    }
}

The only thing that I thought was odd is that the original code shown had WidthRequest="1" on the image, which means it'll render as 1 pixel wide in its container (so it's just a line or a dot). But the cell it's in is still appearing as 25% of the width for me. Other than that I also changed the background colors of the controls so that they would show up more clearly (purple and orange).
Here it is without WidthRequest="1", you can see 25% width image cell, 75% width text cell (though the controls themselves don't take up the whole cell):

And this is with WidthRequest="1", you can see 25% width image cell, 75% width text cell, and the image is only 1x1 pixel so it's just a tiny purple square:

Now, if you want the images and labels to be much larger, you can set all their layout options to be LayoutOptions.FillAndExpand (or whatever else suits you). With this TipperRow:
<GridCell Row="@row" Column="0">
    <Image Source="@ImageSource" BackgroundColor="Color.Purple" HorizontalOptions="LayoutOptions.FillAndExpand" VerticalOptions="LayoutOptions.FillAndExpand" />
</GridCell>
<GridCell Row="@row" Column="1">
    <Label<EMAIL_ADDRESS>HorizontalOptions="LayoutOptions.FillAndExpand" FontSize="25" VerticalOptions="LayoutOptions.FillAndExpand"
           FontAttributes="FontAttributes.Bold" BackgroundColor="Color.Orange" />
</GridCell>

I get this lovely layout:

And here are the full docs on various layout options: https://docs.microsoft.com/xamarin/xamarin-forms/user-interface/layouts/layout-options
Anyway, if there was a bug here, it seems fixed by now. If you're still running into an issue, please let me know and I will investigate more. Thank you for the report!


MoreLikeThisQueryDescriptor support for ids and docs

2.41:
Support for ids and docs parameter:
According to https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-mlt-query.html the query take ids or docs as paramters, which doesn't exists in Nest

NEST 2.4.1 supports like text, id and doc, here's an example:
var client = new ElasticClient();

// Using like text with fields
var response = client.Search<Question>(s => s
	.Size(5)
	.Query(q => q
		.MoreLikeThis(mlt => mlt
			.Fields(f => f
				.Field(fi => fi.Title)
			)
			.Like(l => l
				.Text("what are shards in Elasticsearch?")
			)
			.MinTermFrequency(1)
			.MaxQueryTerms(10)
		)
	)
);

// Using like a document specified by id
response = client.Search<Question>(s => s
    .Size(5)
    .Query(q => q
        .MoreLikeThis(mlt => mlt
            .Fields(f => f
                .Field(fi => fi.Title)
            )
            .Like(l => l
                .Document(d => d
                    .Id(37420718)
                    .Index("posts")
                    .Type(typeof(Question))
                )
            )
            .MinTermFrequency(1)
            .MaxQueryTerms(10)
        )
    )
);

// Using like a given document
response = client.Search<Question>(s => s
    .Size(5)
    .Query(q => q
        .MoreLikeThis(mlt => mlt
            .Fields(f => f
                .Field(fi => fi.Title)
            )
            .Like(l => l
                .Document(d => d
                    .Document(new Question
                    {
                        Title = "what are shards in Elasticsearch?"
                    })
                )
            )
            .MinTermFrequency(1)
            .MaxQueryTerms(10)
        )
    )
);

Hi Russ
Yes, I know this way and actually that is how I am doing it now. Is this the preferred way in the future? I was referring to the ids og docs paramters.
Best regards

@ziaxdk yep - per the docs, like_text, ids and docs are deprecated and replaced by like which can take text, a document or a document id, index and path, or a combination thereof.


Update CHANGELOG to include fingerprint changes

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

also no need to run CI for these, I can power merge them


Update README.md to include Jenkins build status

@bparees we have build badges now with update jenkins plugin \o/

not sure we want that badge...all that's going to tell us is "did someone test a broken PR lately?"

@bparees oh yes, I did not realized that... this is only showing the PR tester status...