[ClangImporter] Fix handling of bitfields in unions

Previously this caused an assertion failure in +Asserts builds and incorrect behavior in -Asserts builds.
rdar://problem/37242238

@swift-ci Please test

@swift-ci Please test Linux

Build failed
Swift Test Linux Platform
Git Sha - ed372b61c1a6ddbab87251bdc04eb370d3cd13e9

<unknown>:0: error: module 'SwiftGlibc' in AST file '/tmp/swift-testsuite-clang-module-cachekQ1VqF/3HI2C9E08ID58/SwiftGlibc-21G5CLUE7WUPX.pcm' (imported by AST file '/tmp/lit_tmp_5JlkA_/unions-and-bitfields-d6cac5.pch') is not defined in any loaded module map file; maybe you need to load '/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/lib/swift/linux/x86_64/glibc.modulemap'?
<unknown>:0: note: consider adding '/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/lib/swift/linux/x86_64' to the header search path
<unknown>:0: note: imported by '/tmp/lit_tmp_5JlkA_/unions-and-bitfields-d6cac5.pch'
<unknown>:0: error: clang importer creation failed

(here]
Okay, this doesn't seem possible. The Clang importer unconditionally loads that module map.
@swift-ci Please test Linux

Build failed
Swift Test Linux Platform
Git Sha - ed372b61c1a6ddbab87251bdc04eb370d3cd13e9

At least it reproduces reliably. Looking into it.

Full Mac tests passed, so
@swift-ci Please test Linux

@swift-ci Please smoke test macOS

Build failed
Swift Test Linux Platform
Git Sha - ed372b61c1a6ddbab87251bdc04eb370d3cd13e9


adding email test

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

Email test is failing on latest addon as expected. The fix is yet to be merged in addon.


Group aggregation epic

open issues:
#158
#156
#154

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

7 of 189 (3.7%)  changed or added relevant lines in 9 files are covered.
9 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-3.05%) to 16.882%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

frontend/src/components/Scenario.tsx
0
7
0.0%

frontend/src/components/IconBar.tsx
0
8
0.0%

frontend/src/store/services/groupApi.ts
4
12
33.33%

frontend/src/store/DataSelectionSlice.ts
2
11
18.18%

frontend/src/components/ChartToggle.tsx
0
18
0.0%

frontend/src/components/SimulationChart.tsx
0
35
0.0%

frontend/src/components/ScenarioCard.tsx
0
41
0.0%

frontend/src/components/CreateFilter.tsx
0
56
0.0%

Files with Coverage Reduction
New Missed Lines
%

frontend/src/components/Scenario.tsx
1
0%

frontend/src/components/ScenarioCard.tsx
3
0%

frontend/src/components/SimulationChart.tsx
5
0%

Totals

Change from base Build<PHONE_NUMBER>:
-3.05%

Covered Lines:
238

Relevant Lines:
1085

💛  - Coveralls


Fix event unsubscription logic

I noticed that unsubscription messages are never sent to speakers because of the ordering of guards in soco.events_base.unsubscription.
Once _cancel_subscription() is called, the _timestamp attribute is set to None. This in turns causes the time_left property to always return 0. This aborts the unsubscription call early and the outgoing request is never fired.

Coverage remained the same at 53.728% when pulling 94a625cf6ccb6278e68561f1b9a26d6cb5922c32 on jjlawren:fix_unsubscriptions into 7ff1457a07c70fda67af797edb60b308cebdf450 on SoCo:master.

It also seems that the call to _cancel_subscription can cause the event listener to stop prematurely. Once this occurs I'm not seeing the remaining unsubscription requests sent out.

Moved the internal Subscription/SubscriptionsMap cleanup method after the successful unsubscription request.

When I run this against SoCo-CLI, I'm getting an exception in event unsubscription:
2021-06-08 09:59:06,498 events_base.py:664 - _cancel_subscription() - An Exception occurred. Subscription to http://<IP_ADDRESS>:1400/MediaRenderer/AVTransport/Event, sid: uuid:RINCON_B8E93790A1A001400_sub0000000634 has been cancelled
2021-06-08 09:59:06,498 api.py:81 - run_command() - Exception: _request() takes 5 positional arguments but 6 were given

My code simply calls sub.unsubscribe() on a subscription object.
I think the defect is hit in events.py line 434, with the exception caught in line 436.

Ok, the issue is that events.py was not updated to fit the new pattern. The following changes are required:
diff --git a/soco/events.py b/soco/events.py
index 667943b..4c6c670 100644
--- a/soco/events.py
+++ b/soco/events.py
@@ -370,7 +370,7 @@ class Subscription(SubscriptionBase):
         self._auto_renew_thread_flag.set()

     # pylint: disable=no-self-use, too-many-arguments
-    def _request(self, method, url, headers, success):
+    def _request(self, method, url, headers, success, unconditional=None):
         """Sends an HTTP request.

         Args:
@@ -381,6 +381,9 @@ class Subscription(SubscriptionBase):
             success (function): A function to be called if the
                 request succeeds. The function will be called with a dict
                 of response headers as its only parameter.
+            unconditional (function): An optional function to be called after
+                the request is complete, regardless of its success. Takes
+                no parameters.

         """
         response = None
@@ -400,6 +403,9 @@ class Subscription(SubscriptionBase):
         if success:
             success(response.headers)

+        if unconditional:
+            unconditional()
+
     # pylint: disable=inconsistent-return-statements
     def _wrap(self, method, strict, *args, **kwargs):

@jjlawren: Please could you review and include these changes, and resubmit a PR? Thanks.

Apologies, I forgot about the original. Will re-submit a new PR.


Allow triggering nightly build from PR label

Adding the full-test-run label to a PR before creating it will trigger the same workflow as the nightly job.

Since some nightly tests are still failing this PR won't show green CI, but the fact that the nightly tests are running with this label shows its working


Why Router.HandleFunc?

Why do we need Router.HandleFunc? http.HandlerFunc implements http.Handler so anywhere where Router.HandleFunc is used, it could be replaced with Router.Handle.
Furthermore, I personally think that functions should accept interfaces and return structs. So Router.Handle should be preferrable to Router.HandleFunc because http.Handler is an interface. And http.Handle is shorter than http.HandleFunc 😉
Or am I missing something here? Is this just to be more compatible with http.ServeMux?
Also, is there a specific reason why all the examples use http.Handle?

https://www.calhoun.io/why-cant-i-pass-this-function-as-an-http-handler just answered my question. Sorry for the trouble.


Update robots.txt

I have found that Bing/Yahoo/DuckDuckGo, Yandex and Google report crawl errors when using the default robots.txt. Specifically their bots will not crawl the the path '/' or any sub-paths. I agree that the current robots.txt should work and properly implements the specification. However it still does not work.
In my experience explicitly permitting the path '/' by adding the directive Allow: / resolves the issue.
More details can be found in a blog post about the issue here: https://www.dfoley.ie/blog/starting-with-the-indieweb

I have a similar problem with the robots.txt. I have published a page with an image under '/user/pages/01.page/01._module/default.md' and '/user/pages/01.page/01._module/default.img'. The image url in the html representation is 'domain.tld/user/pages/01.page/01._module/default.img'.
The GoogleBot can crawl all sites without any problems. But he not index the image. I tested the image url with the search console and got the message that the image cant be in the index because it is blocked by the robots.txt. If i test the same url with the Google robots.txt tester everthing looks fine. The rule 'Allow: /user/pages/' is highlighted. And the Response is 200.
I've tested it with the 'Allow: /' rule also. No succed. And i've tested it with the allow-rules before the disallow-rules. Nothing helped.
Every robots.txt tester say the robots.txt is fine, and the image url is not blocked. Except the Google-search console. Any hint how i can get the image in the index?

Does anyone know a way to report these clearly identified errors to these providers? I only know that I've concluded it's futile trying to communicate to Google about their products. Even when they supposedly have channels open, nothing happens, not even an acknowledgement of the message. Not sure about the others.

I think Google is just listening. Whether and what will be changed in their products will probably be decided elsewhere. As I understand it, the robots.txt tester is not designed to check the indexing of the images. And the feedback from the tool is not generally valid.
For my problem I have now created an extra sitemap for pictures. That helped.


[Crosswalk-21][Embeddingapi] Correct subcase number in v7.XWalkSettingTest

There should be 11 subcases in v7.XWalkSettingTest(7 new tests
added by commit 47705205d4e814212d4ffa452305ea106a1eea00)
https://crosswalk-project.org/jira/browse/CTS-1819

LGTM


Fix: Adjusted gaps and paddings inside of chat window

Fix: Adjusted gaps and paddings inside of chat window
Description

The problem was in huge paddings between attached files and user input message
I've changed values for paddings and gaps inside of UserInput, ChatContent and ContextFiles components to resolve this issue
Any background context or related links?

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (no functional changes, only code improvements)
[ ] Documentation update

How to Test

Step 1: Open a new chat window
Step 2: Mention any @file inside of a message textarea
Step 3: Send one more message using @file directive to see how it behaves in different places.

Screenshots

Top left corner

Somewhere in the middle of the chat

Checklist

[x] My code follows the code style of this project.
[x] I have performed a self-review of my code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.
[ ] I have updated the documentation where necessary.

merged


Update libisyntax API

Update the c-binding and wrapper to the changes introduced in this libisyntax commit.

Thank you!


Update date-format.js

It is easier to read in a readable form.
Fixes #[replace brackets with the issue number that your pull request addresses].
Changes proposed in this pull request:

[list out summary of changes here]
[list out summary of changes here]
[list out summary of changes here]
[etc]

Note: pull requests without proper descriptions may simply be closed without further discussion. We appreciate your contributions, but need to know what you are offering in clearly described format. Thanks! (you can delete this text)
cc @HospitalRun/core-maintainers

@fooksupachai thanks for the PR.  HospitalRun uses the following styleguide when it comes to formatting javascript: https://github.com/DockYard/styleguides/blob/master/engineering/javascript.md.
The file app/helpers/date-format.js is already following this convention but your change would undo that, so I am going to close this PR.


VSCode extension allows Trie.empty() with no generic type but moc throws error

Let's say you have a record typed as such:
public type Foo = {
    var map: Trie.Trie<Text, Nat>;
};

And you initialize a record of type Foo as such:
let foo: Foo = {
    var map = Trie.empty();
};

The VSCode extension is totally fine with this and throws no error.
But when you run dfx build, the compiler complains with this:
Stderr:
Ill-typed intermediate code after Desugaring (use -v to see dumped IR):
(unknown location): IR type error [M0000], subtype violation:
  {var map : Trie<None, None>}
  {var map : Trie<Text, Nat>}

Note: this only happens if the field is prefixed with var.

Closing (feel free to create an issue on dfinity/motoko if this is still relevant).


Allow recursive directories to be indexed with file://

If I have a folder containing all my repos (local or on shared network space using gitlab or similar) the entire directory contains sub directories of different git repos. If I want to index all of the repos, including newly added repos, I would hope to be able to use the following config to index all of the repos at once.
{
  "repos" : {
    "gitlab" : {
      "url" : "file://path/to/repos/"
      "recurse" : "true"
    }
  }
}

This would hopefully help with managing dozens or hundreds of repos needing to be put into a config.json file.

Is your intent to have Hound automatically discover the git repos and keep them up to date with polling as usual?

That would be ideal. Auto discovery would be important although I read polling with file:// already has issues.

Use the file:// protocol. This allows you to index any local folder, so you can clone the repository locally and then reference the files directly. The downside here is that the polling to keep the repo up to date will not work.

An alternative would be better gitlab support to auto discover/poll all repos for a team, org, etc. I'm looking to index 700+ repos which would obviously be cumbersome to input manually. I saw some of the generation scripts but those would require crons and service restarts if a new repo was added.

+1  for automatic discovery of all repositories from local FS recursively!
It might be a CLI argument like houndd --discover file://path/to/dir which actually generates the default config.json in the existing format with a listing of all repos found.
Same approach might work later for the discovery of all repositories for the particular github org like houndd --discover https://github.com/orgname/

This is similar to #13 - it would be good to come up with a solution that solves both cases.

As a note to other users, I will say locally I have searched my "code" directory for git urls like this.
find $HOME/code -name .git -type d -prune | xargs -n1 -P4 -I '{}' git --git-dir='{}' config --get 'remote.origin.url' | sort

which outputs something like this:
git@github.com:andxyz/.dotfiles.git
git@github.com:mislav/dotfiles.git

Then with some text manipulation I created the required config.json file.

+1 this would be really useful. I was surprised this option doesn't already exist.
Here is my BASH script as a workaround:
  echo '{' > config.json
  echo '"max-concurrent-indexers" : 2,' >> config.json
  echo '"dbpath" : "data",' >> config.json
  echo '"repos" : {' >> config.json
  first=true;
  for f in $(find /home/developer -maxdepth 2 -type d); do
    if [ -f "$f/HEAD" ]; then
      bn=`basename $f`
      if [[ "$first" == "true" ]]; then
        first=false;
      else
        echo "," >> config.json
      fi;
      echo "\"$bn\" : {\"url\" : \"file://$f\"}" >> config.json
    fi;
  done;
  echo '}}' >> config.json


Incorrect character summary in detailed character info when newest update exists

For example, the current version is 4.7, we are still counting down to the end.
If the page for the next version, say 4.8, exists, the "Last day since run" function will say that the last run is the currently running version (4.7) but still use the day count from the previous run before 4.7.
It should not say that 4.7 is the last run as it is still running.

I cannot see this bug anymore however I think that the next version from this current version must exist and is counting down in order to see the bug. Will need further testing.


Improvement : Activity-log event should not fire when click on OK or Cancel button at Delete CLA Group prompt.

Steps :

Open easyCLA page : https://pcc.staging.platform.linuxfoundation.org/project/a097c000007pundAAA/tools/easycla/overview
Now click on Delete CLA group icon.

See-API event fired at network tab

Now Click on Cancel or Ok button at Delete CLA group prompt

Actual Results : Activity-log event fired while Delete CLA group is just information dialog

{"Events":[{"EventCLAGroupID":"3a946a78-4397-4a83-b93c-463c0c615ca8","EventCLAGroupName":"Veer_LLC_CLA","EventCLAGroupNameLower":"veer_llc_cla","EventCompanyID":"0702ab0b-5d3d-433c-9fde-d0352a2e6e80","EventCompanyName":"Proxima","EventCompanySFID":"0012M00002MnADGQA3","EventData":"CLA Manager: veerendrat, Email<EMAIL_ADDRESS>LFID: ff9f1a52-bc43-4257-8b4d-ef21330c2854 added GitHub Username: vrthakur to the approval list for Company: Proxima, Project: Veer_Staging_Standalone_LLC.","EventID":"25d8e348-9a12-444e-bcfc-0a549cf3d7ba","EventProjectID":"a097c000007pundAAA","EventProjectName":"Veer_Staging_Standalone_LLC","EventProjectSFID":"a097c000007pundAAA","EventSummary":"The CLA Manager veerendrat added the GitHub username vrthakur to the approval list for the CLA Group Veer_LLC_CLA for the project Veer_Staging_Standalone_LLC for the company Proxima.","EventTime":"2021-03-22T09:51:36.000000+0000","EventTimeEpoch":1616406696,"EventType":"cla_manager.approval_list_updated","UserID":"ff9f1a52-bc43-4257-8b4d-ef21330c2854","UserName":"Veerendra Thakur"},{"EventCLAGroupID":"3a946a78-4397-4a83-b93c-463c0c615ca8","EventCLAGroupName":"Veer_LLC_CLA","EventCLAGroupNameLower":"veer_llc_cla","EventCompanyID":"0702ab0b-5d3d-433c-9fde-d0352a2e6e80","EventCompanyName":"Proxima","EventCompanySFID":"0012M00002MnADGQA3","EventData":"User: Veerendra Thakur was assigned Scope: a097c000007pundAAA|0012M00002MnADGQA3 with Role: cla-manager-designee for Project: Veer_Staging_Standalone_LLC with ID: a097c000007pundAAA.","EventID":"f8ced66d-68c8-4460-a199-90a2fa0af786","EventProjectID":"a097c000007pundAAA","EventProjectName":"Veer_Staging_Standalone_LLC","EventProjectSFID":"a097c000007pundAAA","EventSummary":"The user Veerendra Thakur was added to the role cla-manager-designee for the CLA Group Veer_LLC_CLA for the project Veer_Staging_Standalone_LLC for the company Proxima.","EventTime":"2021-03-22T09:47:38.000000+0000","EventTimeEpoch":1616406458,"EventType":"lfx_org_service.assign_user_role_scope","UserID":"0037c00000xsDTPAA2"}]}
Refer Video clip :
https://images.zenhubusercontent.com/194341141/24ac2c15-7099-40be-8553-5a3af07e5c39/deleteclaprompt.mp4

This issue looks like it's related to the frontend. If an event log is generated this means we received some backend request. When clicked OK or Cancel the frontend should avoid sending the request to the backend in this case.

It was discussed in the 16-April standup that as it is a front-end issue, we should close this ticket and log a PCC ticket.
Following PCC ticket has been logged.
https://jira.linuxfoundation.org/browse/PCC-921
So closing this ticket.


Update repositories.txt

The library url has been changed.

@marcinsaj you already submitted a pull request for this: https://github.com/arduino/library-registry/pull/2014
As I replied there, your request has been received and is in progress, so you don't need to do anything further. The URL will be updated in good time. Until then, the old URL will serve perfectly well because GitHub automatically redirects the old URL to the new URL.


Success

The introductory text says "Success audits record successful attempts", but later, the article states "This subcategory doesn’t have Success events"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 14b78c8d-9064-a39a-d75e-6a2201b85397
Version Independent ID: 59662c79-4b42-cfa9-37bb-009749a901a8
Content: Audit Account Lockout (Windows 10)
Content Source: windows/security/threat-protection/auditing/audit-account-lockout.md
Product: w10
GitHub Login: @Mir0sh
Microsoft Alias: justinha

In addition, the default setting is defined as "Success" (Explain tab), whereby only "Failure" events are thrown as described (4625(F)).

@officedocsbot assign @mypil

@dkbriley Thanks for the feedback. Your point is valid and I will do my best to amend the content to make it more clear,

@dkbriley - Thank you for submitting this feedback.
From our understanding, the issue has been resolved. If you feel it hasn't been resolved, please re-open this issue.
Thank you for your contribution to make the docs better! Much appreciated!

@officedocsbot close


[Bug Report] el-cascader component jamming

Element UI version
2.15.13
OS/Browsers version
macOS 13.0 / Chrome 109.0.5414.87
Vue version
2.7.14
Reproduction Link
https://codepen.io/wudechong/pen/bGxdqGO
Steps to reproduce
Check the primary and secondary multiple check boxes
What is Expected?
Can check data smoothly
What is actually happening?
Cannot check data smoothly

The problem is reviewed and supported


Bump glob from v7 to v10

closed https://github.com/joshwooding/vite-plugin-react-docgen-typescript/issues/34
glob has stopped supporting node 12, but this is not relevant for Vite, so it is not breaking changes.

@dartess Thank you for the contribution! Happy to merge this as Storybook bumped their version of glob too. I made a few small changes:

Dropped the glob version to ^10.0.0 - having ^10.4.2 limits deduping unneccessarily.
Updated the changeset and bumped the change to a minor. The package is pre 1 but since this bumps glob through major versions it wouldn't be a patch change.

@joshwooding It was lightning fast 😅
It’s even embarrassing that the quality of the PR is not good enough. I'll remember about limits deduping, it's a valuable lesson, thanks!

@dartess It was perfect :) Those were minor changes that are nice to make


Implement Bidirectional IO

https://github.com/mean-expert-official/loopback-component-pubsub/issues/10

This is implemented in the Backend but requires to be integrated with the SDK Builder before closed.


ImportError: libcudart.so.8.0: cannot open shared object file: No such file or directory

Ubuntu 18.04, Nvidia 430.50 drivers. Followed install directions exactly using conda. Uninstalled and reinstalled multiple times, still same error.

Moved over to 1.0 branch. Different error. Will open separate issue.


Multiple dotnet test runs produce error

You might mention that you have to call dotnet clean $testProjPath ( - where $testProjPath is a variable containing the path to the test *.csproj file - ) between each subsequent call to dotnet test $testProjPath.
Otherwise, the user will get an error: error CS0579: Duplicate ‘System.Reflection.AssemblyCompanyAttribute’ attribute

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f9b54562-9072-a864-be3d-44ed7965c798
Version Independent ID: a69ec985-ed05-90dd-a686-dc956b0cf5df
Content: Organizing and testing projects with the .NET Core command line - .NET Core
Content Source: docs/core/tutorials/testing-with-cli.md
Product: dotnet-core
GitHub Login: @cartermp
Microsoft Alias: mairaw

@geronimus Hello.
I don't think this is correct. Generally that error is present because you have two things declaring that attribute. Usually this happens when you port a .NET Framework project (which stores these attributes in the AssemblyInfo.cs file) to the SDK project-style (which automatically generates these attributes for you)
Can you elaborate on your problem?


[FIX] improve longitudinal example

closes #1575

@gdevenyi does this look better?
https://bids-specification--1576.org.readthedocs.build/en/1576/longitudinal-and-multi-site-studies.html#longitudinal-and-multi-site-studies

Looks good, thanks!


example is broken

I'm trying to use ormx and I can't even get the example to run. If I use the schema
create table users (
  id serial4 primary key,
  first_name varchar,
  last_name varchar,
  email varchar,
  last_login timestamp
);

and just a simple cargo build I get a bunch of errors.
error[E0308]: mismatched types
  --> src/schema.rs:21:10
   |
21 | #[derive(ormx::Table)]
   |          ^^^^^^^^^^^ expected `u32`, found `i32`
   |
   = note: this error originates in the macro `$crate::sqlx_macros::expand_query` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0308]: mismatched types
  --> src/schema.rs:21:10
   |
21 | #[derive(ormx::Table)]
   |          ^^^^^^^^^^^ expected struct `std::string::String`, found enum `Option`
   |
   = note: expected struct `std::string::String`
                found enum `Option<std::string::String>`
   = note: this error originates in the macro `$crate::sqlx_macros::expand_query` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0308]: mismatched types
  --> src/schema.rs:21:10
   |
21 | #[derive(ormx::Table)]
   |          ^^^^^^^^^^^ expected `i32`, found `u32`
   |
   = note: this error originates in the derive macro `ormx::Table` (in Nightly builds, run with -Z macro-backtrace for more info)

because these are type mismatches in the compiler, they're almost impossible to debug. I'm using the latest postgres.

that's weird - did you do cargo run in ./example-postgres?

I think it'd be great if you could show exactly what you did.


Use custom sql init (sqlite)

What's changing
The whole DB URL is passed through the environment. This allows a custom DB to be used without any changes.
How to test it
Start the lumigator image using the provided URL, and removing the postgresql service from the docker compose. SQLite should be used instead locally in the lumigator image.
Related Jira Ticket
LUMI-86
Additional notes for reviewers
I already...

[ ] added some tests for any new functionality;
[ ] updated the documentation.

I think we should remove postgres dependencies from the docker-compose and simplify the variables as well

Also, can we add local.db to .gitignore?


[SPARK-42259][SQL] ResolveGroupingAnalytics should take care of Python UDAF

What changes were proposed in this pull request?

This is a long-standing correctness issue with Python UDAF and grouping analytics. The rule ResolveGroupingAnalytics should take care of Python UDAF when matching aggregate expressions.
Why are the changes needed?

bug fix
Does this PR introduce any user-facing change?

Yes, the query result was wrong before
How was this patch tested?

existing tests

cc @HyukjinKwon @gengliangwang

The k8s failure is unrelated, I'm merging it to master/3.4/3.3/3.2, thanks for the review!


RiskOfRain2

Github doesn't support .tar.xz files..
RiskOfRain2.dxvk-cache.zip

Thanks.
https://github.com/begin-theadventure/dxvk-caches/commit/516b6e9207146628b832135d839dea02e63524af

https://github.com/begin-theadventure/dxvk-caches/issues/7#issuecomment-1067563627


Missing modifier x?

Table containing "mode modifier"s doesn't mention modifier x. Is this modifier only available on the non-secure APIs? If so I would value some discussion of what to do instead while using secure APIs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c5a2e737-afe6-a70d-8eb3-fe3a0aeda3e8
Version Independent ID: 3a9bdb00-1d09-1b08-3dc3-029a6a0b16a2
Content: fopen_s, _wfopen_s
Content Source: docs/c-runtime-library/reference/fopen-s-wfopen-s.md
Product: visual-cpp
Technology: cpp-ucrt
GitHub Login: @TylerMSFT
Microsoft Alias: twhitney

@WillerZ
Did you try it? I haven't, but I expect it's supported, just not documented. We'll take a look.

@WillerZ - "x" is supported. I've updated the documentation. It's also supported for freopen(), _wfreopen(), freopen_s() and _wfreopen_s() so I also updated those pages.
This should be live by the end of the week.

Thanks!

@WillerZ , just FYI that we are having some issues with our publishing pipeline. I hope that the fix will be out sometime next week.


Environment variables not loaded from .env in monorepo

We tried introspection in an existing Prisma 1 project (a mono-repo with a total of seven prisma.yml and respective datamodel.prisma files). After having added the @prisma/cli as a dev dependency, we tried to introspect one of the PostgreSQL schemas that mapped to one of the seven Prisma 1 services. This is the error we got:
yarn run v1.12.3
$ prisma introspect
  prisma { argv:
  prisma    [ '/Users/abhiaiyer/.nvm/versions/node/v10.19.0/bin/node',
  prisma      '/Users/abhiaiyer/gatsby/mansion/cloud/packages/lib-prisma/node_modules/.bin/prisma',
  prisma      'introspect' ] } +0ms
  prisma Environment variables not loaded +4ms
  getos { platform: 'darwin', libssl: undefined } +0ms
  download { fileExists: true,
  download   cachedFile:
  download    '/Users/abhiaiyer/.cache/prisma/master/2fb8f444d9cdf7c0beee7b041194b42d7a9ce1e6/darwin/query-engine' } +0ms
  download { cachedFile:
  download    '/Users/abhiaiyer/.cache/prisma/master/2fb8f444d9cdf7c0beee7b041194b42d7a9ce1e6/darwin/query-engine' } +0ms
  download { fileExists: true,
  download   cachedFile:
  download    '/Users/abhiaiyer/.cache/prisma/master/2fb8f444d9cdf7c0beee7b041194b42d7a9ce1e6/darwin/migration-engine' } +0ms
  download { cachedFile:
  download    '/Users/abhiaiyer/.cache/prisma/master/2fb8f444d9cdf7c0beee7b041194b42d7a9ce1e6/darwin/migration-engine' } +0ms
  download { fileExists: true,
  download   cachedFile:
  download    '/Users/abhiaiyer/.cache/prisma/master/2fb8f444d9cdf7c0beee7b041194b42d7a9ce1e6/darwin/introspection-engine' } +0ms
  download { cachedFile:
  download    '/Users/abhiaiyer/.cache/prisma/master/2fb8f444d9cdf7c0beee7b041194b42d7a9ce1e6/darwin/introspection-engine' } +0ms
  download { sha256File:
  download    '031aa3d28731224dd1601098480011699473befd0d53f91bf0a6e0b9921d9b78',
  download   sha256Cache:
  download    '031aa3d28731224dd1601098480011699473befd0d53f91bf0a6e0b9921d9b78',
  download   cachedFile:
  download    '/Users/abhiaiyer/.cache/prisma/master/2fb8f444d9cdf7c0beee7b041194b42d7a9ce1e6/darwin/introspection-engine',
  download   sha256FilePath:
  download    '/Users/abhiaiyer/.cache/prisma/master/2fb8f444d9cdf7c0beee7b041194b42d7a9ce1e6/darwin/introspection-engine.sha256' } +101ms
  download { sha256File:
  download    '71d67323cfb48eea636e39c73559cae35baeec0132101c79f3cf2dd02292d2b8',
  download   sha256Cache:
  download    '71d67323cfb48eea636e39c73559cae35baeec0132101c79f3cf2dd02292d2b8',
  download   cachedFile:
  download    '/Users/abhiaiyer/.cache/prisma/master/2fb8f444d9cdf7c0beee7b041194b42d7a9ce1e6/darwin/migration-engine',
  download   sha256FilePath:
  download    '/Users/abhiaiyer/.cache/prisma/master/2fb8f444d9cdf7c0beee7b041194b42d7a9ce1e6/darwin/migration-engine.sha256' } +39ms
  download { sha256File:
  download    '7dfa7c8a8814c7f18ca37f052b0fcd59af62518ab2a56e1c0b9a5f8118754477',
  download   sha256Cache:
  download    '7dfa7c8a8814c7f18ca37f052b0fcd59af62518ab2a56e1c0b9a5f8118754477',
  download   cachedFile:
  download    '/Users/abhiaiyer/.cache/prisma/master/2fb8f444d9cdf7c0beee7b041194b42d7a9ce1e6/darwin/query-engine',
  download   sha256FilePath:
  download    '/Users/abhiaiyer/.cache/prisma/master/2fb8f444d9cdf7c0beee7b041194b42d7a9ce1e6/darwin/query-engine.sha256' } +16ms
  download { targetSha256:
  download    '031aa3d28731224dd1601098480011699473befd0d53f91bf0a6e0b9921d9b78' } +67ms
  download sha256 of target is correct, so there's nothing to do :) +1ms
  download { needsToBeDownloaded: false } +0ms
  download { targetSha256:
  download    '71d67323cfb48eea636e39c73559cae35baeec0132101c79f3cf2dd02292d2b8' } +48ms
  download sha256 of target is correct, so there's nothing to do :) +0ms
  download { needsToBeDownloaded: false } +0ms
  download { targetSha256:
  download    '7dfa7c8a8814c7f18ca37f052b0fcd59af62518ab2a56e1c0b9a5f8118754477' } +14ms
  download sha256 of target is correct, so there's nothing to do :+0ms
  download { needsToBeDownloaded: false } +0ms
Introspecting based on datasource defined in services/static-uploads/prisma/schema.prisma …
  getos { platform: 'darwin', libssl: undefined } +297ms
  IntrospectionEngine:rpc starting introspection engine with binary: /Users/abhiaiyer/gatsby/mansion/cloud/node_modules/@prisma/cli/introspection-engine-darwin +0ms
  IntrospectionEngine:rpc SENDING RPC CALL {"id":1,"jsonrpc":"2.0","method":"introspect","params":[{"schema":"// This is your Prisma schema file,\n// learn more about it in the docs: https://pris.ly/d/prisma-schema\n\ndatasource db {\n  provider = \"postgresql\"\n  url      = env(\"DATABASE_URL\")\n}\n\ngenerator client {\n  provider = \"prisma-client-js\"\n}\n"}]} +9ms
  IntrospectionEngine:rpc { jsonrpc: '2.0',
  IntrospectionEngine:rpc   error:
  IntrospectionEngine:rpc    { code: 4466,
  IntrospectionEngine:rpc      message: 'An error happened. Check the data field for details.',
  IntrospectionEngine:rpc      data:
  IntrospectionEngine:rpc       { is_panic: false,
  IntrospectionEngine:rpc         message:
  IntrospectionEngine:rpc          'Error in datamodel: ErrorCollection { errors: [EnvironmentFunctionalEvaluationError { var_name: "DATABASE_URL", span: Span { start: 160, end: 179 } }] }',
  IntrospectionEngine:rpc         backtrace: null } },
  IntrospectionEngine:rpc   id: 1 } +16ms
Error: Error: Error in datamodel: ErrorCollection { errors: [EnvironmentFunctionalEvaluationError { var_name: "DATABASE_URL", span: Span { start: 160, end: 179 } }] }
    at IntrospectionEngine.<anonymous> (/Users/abhiaiyer/gatsby/mansion/cloud/node_modules/@prisma/cli/build/index.js:2:2542935)
    at Generator.next (<anonymous>)
    at /Users/abhiaiyer/gatsby/mansion/cloud/node_modules/@prisma/cli/build/index.js:2:2537655
    at new Promise (<anonymous>)
    at n (/Users/abhiaiyer/gatsby/mansion/cloud/node_modules/@prisma/cli/build/index.js:2:2537403)
    at Object.registerCallback (/Users/abhiaiyer/gatsby/mansion/cloud/node_modules/@prisma/cli/build/index.js:2:2542141)
    at IntrospectionEngine.handleResponse (/Users/abhiaiyer/gatsby/mansion/cloud/node_modules/@prisma/cli/build/index.js:2:2539961)
    at LineStream.l.default.on.e (/Users/abhiaiyer/gatsby/mansion/cloud/node_modules/@prisma/cli/build/index.js:2:2541779)
    at LineStream.emit (events.js:198:13)
    at addChunk (_stream_readable.js:288:12)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

It says: prisma Environment variables not loaded +4ms.
When hardcoding the url directly in schema.prisma, introspection worked as expected.

@nikolasburk Can you please share your folder structure?
Also, this might be already fixed via https://github.com/prisma/prisma-client-js/issues/664 so please try this again once as well with the alpha version.

@nikolasburk do you still have the information? It's been over 3 months now, if this is not actionable anymore, please close it.

Closing. Please re-open if you're still running into this. Thanks!

Hope this helps, I have a .env file in a parent directory and tried to delete the .env file that was in the prisma folder. However, it seems that npx prisma introspect does not pick up the .env file from the parent directory so I had to explicitly define another .env file in the prisma folder. Is it the case that the .env file has to be in the prisma folder for prisma environment variables?

Having the same issue here. It's kinda annoying we cannot have one single unified ´.env´ file in a monorepo setup.

Can you please share the full information? What does your structure look like? Where do you have .env files? What commands can pick it up or not?

We have a monorepo using turbo repo with the following structure:

The prisma package is being used in multiple applications, currently we're trying to use a single .env to avoid confusion. Moving the DATABASE_URL url from packages/prisma/.env to the root .env errors when trying to run any yarn prisma script.
We also tried to use a solution like cmd-env:

But no luck so far.

Ok. Can you please open a new issue with exactly that information (And whatever else the template asks for)? Then we can apply the correct labels etc and make sure this gets worked on properly. Also post the link to the issue here when done please.

@janpio opened #12535 🙏🏽


How do adapters work?

The documentation doesn't explain how Adapters work. How do they work?

I'm going to merge this into https://github.com/select2/select2/issues/3166 and start building up a collection of useful links that can eventually be turned into documentation points.


[WIP] forest_actor-5.0.2

forest_actor-5.0.1 fails the most recent conformance test. This draft PR contains an improved actor.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)

Closes
Other information and links

Turns out the actor wasn't the problem at all. It was the test driver that selected the wrong network version.


Device Request - Smart Knob -  _TZ3000_4fjiwweb /  TS004F

Prerequisites:

Before requesting a device addition, please ensure there is not already a request for the device among the open issues.
Make sure your Homey is upgraded to firmware v5 or higher.
You need a physical example of the device

Device Name: AUBESS Tuya ZigBee Smart Knob
Device Model: TS004F
Device Description: Smart rotational knob
Link to device image: https://manuals.plus/wp-content/uploads/2022/06/Earda-Technologies-ERS-10TZBVK-AA-Smart-PRODUCT.png?ezimgfmt=rs:467x483/rscb1/ng:webp/ngcb1
Device Interview:
"ids": {
"modelId": "TS004F",
"manufacturerName": "_TZ3000_4fjiwweb"
},
"endpoints": {
"endpointDescriptors": [
{
"endpointId": 1,
"applicationProfileId": 260,
"applicationDeviceId": 260,
"applicationDeviceVersion": 0,
"_reserved1": 1,
"inputClusters": [
0,
1,
3,
4,
6,
4096
],
"outputClusters": [
25,
10,
3,
4,
5,
6,
8,
4096
]
}
],
"endpoints": {
"1": {
"clusters": {
"basic": {
"attributes": [
{
"acl": [
"readable",
"reportable"
],
"id": 0,
"name": "zclVersion",
"value": 3,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 1,
"name": "appVersion",
"value": 67,
"reportingConfiguration": {
"direction": "reported",
"attributeDataType": 32,
"minInterval": 1,
"maxInterval": 65534,
"minChange": 0,
"status": "SUCCESS"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 2,
"name": "stackVersion",
"value": 0,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 3,
"name": "hwVersion",
"value": 1,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 4,
"name": "manufacturerName",
"value": "_TZ3000_4fjiwweb",
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 5,
"name": "modelId",
"value": "TS004F",
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 6,
"name": "dateCode",
"value": "",
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 7,
"name": "powerSource",
"value": "battery",
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"writable",
"reportable"
],
"id": 65502,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 65533,
"name": "clusterRevision",
"value": 2,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 65534,
"name": "attributeReportingStatus",
"value": "PENDING",
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 65504,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 65505,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 65506,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 65507,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"powerConfiguration": {
"attributes": [
{
"acl": [
"readable",
"reportable"
],
"id": 0,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 32,
"name": "batteryVoltage",
"value": 30,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 33,
"name": "batteryPercentageRemaining",
"value": 200,
"reportingConfiguration": {
"direction": "reported",
"attributeDataType": 32,
"minInterval": 14400,
"maxInterval": 65534,
"minChange": 10,
"status": "SUCCESS"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 65533,
"name": "clusterRevision",
"value": 1,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"identify": {
"attributes": [
{
"acl": [
"readable",
"writable",
"reportable"
],
"id": 0,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 65533,
"name": "clusterRevision",
"value": 1,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"groups": {
"attributes": [
{
"acl": [
"readable",
"reportable"
],
"id": 0,
"name": "nameSupport",
"value": {
"type": "Buffer",
"data": [
0
]
},
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 65533,
"name": "clusterRevision",
"value": 1,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"onOff": {
"attributes": [
{
"acl": [
"readable",
"writable",
"reportable"
],
"id": 32772,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"touchlink": {
"attributes": [
{
"acl": [
"readable",
"reportable"
],
"id": 65533,
"name": "clusterRevision",
"value": 1,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
}
},
"bindings": {
"identify": {
"attributes": [
{
"acl": [
"readable",
"writable",
"reportable"
],
"id": 0,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 65533,
"name": "clusterRevision",
"value": 1,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"groups": {
"attributes": [
{
"acl": [
"readable",
"reportable"
],
"id": 0,
"name": "nameSupport",
"value": {
"type": "Buffer",
"data": [
0
]
},
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 65533,
"name": "clusterRevision",
"value": 1,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"onOff": {
"attributes": [
{
"acl": [
"readable",
"writable",
"reportable"
],
"id": 32772,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"touchlink": {
"attributes": [
{
"acl": [
"readable",
"reportable"
],
"id": 65533,
"name": "clusterRevision",
"value": 1,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"ota": {
"attributes": [],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"time": {
"attributes": [],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"scenes": {
"attributes": [],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"levelControl": {
"attributes": [],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
}
}
}
}
}
Additional Comments:
https://www.aliexpress.com/item/1005004625731544.html
How to interview a device:

Add the device as a generic Zigbee device in Homey
Navigate to https://developer.athom.com/tools/zigbee.
Interview the device, the button for this is to the right of the device in the list of Zigbee units.
Click the copy button/icon to capture the device information.
Paste the copied information above.

Note: To be able to add more devices to the Tuya Zigbee app, we rely on community members like you to provide interviews of the devices you want added. Thank you for your contribution!

Looks to be the same knob as in #441, just different vendor.


Will this run on a Jetson Nano?

I have a Jetson Nano - 4 arm64 cores, 128 CUDA cores and 4 GB of shared RAM, Ubuntu 18.04, CUDA 10.2. Will cueForth run on it?

Ed, hello again,
Jetson is a target of great interest for me as well. cueForth is in its alpha state and currently under active development on my desktop GTX 1660 only. I do compiled it with sm5.2 so hopefully can work with Jetson. However, I haven't had a chance play with one yet. Will keep you posted.

I have an RTX 3090 and a GTX 1650 Ti too with Windows 11 / WSL :-) ... if you can put your build scripts in the repo it would probably take me a couple of days to get it working on the Jetsons. The downside of Jetsons is that they are now expensive; in terms of price per CUDA core they're not competitive with laptops any more.

Wow, a RTX 3090! You must be very serious about it. 8-)
To benchmark the difference between threading models (i.e. token vs subroutine), I'm churning the code right now. The difference on my eForth repo which I've just completed is 2.5x. Too big to pass. Give me a week or so. I'll get back to you once stabilized.
BTW, I use Eclipse with CUDA SDK 11.6 on Ubuntu. I think the SDK works on Windows even better. Thanks,

I think the SDK works even better on Windows. Cheers,

My standard operating procedure for CUDA on Windows is to run everything in WSL Ubuntu 20.04. That was what NVIDIA and Microsoft tested in the Windows Insider Builds for Windows 10 and it's what they support in Windows 11. There's some overhead, but even in Docker their N-body container benchmark gets 20 TFLOPS on the 3090. I don't think some of the HPC tools like the compilers even run on Windows itself.
The other side of that coin is because of Intel "Optane" and secure boot, dual booting with most Linux distros is a bigger hassle than it used to be, so it's a good thing WSL is almost as good as dual booting.

I don't know if this is relevant or not - I'm still wading through it.
Programming with a Differentiable Forth Interpreter

I've forked the project and I'm starting on the Jetson testing - repo is https://github.com/AlgoCompSynth/tensorForth. For my own sanity I'll be maintaining issues / project details over there. Meanwhile the answer to the original question, "Will this run on the Jetson Nano?" depends on whether it needs CUDA 11 or can run with the version of CUDA on the Nano, 10.2. Is CUDA 11 a hard requirement?
For the moment I'm testing on a Jetson Xavier NX - 6 ARM Cortex cores, 8 GB of RAM and 384 CUDA cores. It also has tensor cores if tensorForth can use them. It's running Jetpack 5.0 developer preview, which has CUDA 11.4.

Ed,
Ed, I was about to send a mail to you but apparently you're well ahead. Very cool!
Since upgraded to Ubuntu 20.04, I lost CUDA 10.2. So, aside from CUDA 11.6, I have not tried it on anything else. Would be exciting to learn if it compiles on your system.
BTW, though the name implies tensor but no implementation at all yet. I have just started reading to figure out how torch+numpy stores them. I'll probably start with CUTLASS and CUB. Would enjoy hearing your recommendations!

From 'The differentiable Forth': ∂4 can learn to fill the sketch and generalize well to problems of unseen size. Wow!
I haven't contemplated that far yet, but it does open a window (or door). Thank you for the link.

Ed, I was about to send a mail to you but apparently you're well ahead. Very cool!
Since upgraded to Ubuntu 20.04, I lost CUDA 10.2. So, aside from CUDA 11.6, I have not tried it on anything else. Would be exciting to learn if it compiles on your system.
BTW, though the name implies tensor but no implementation at all yet as you can see in my long TODO list. I have just started reading to figure out how torch+numpy stores them. I'll probably start with CUTLASS and CUB. Would enjoy hearing your recommendations!

I've got Eclipse installed but I've never used it - I'm a command-line geek. :-) What options do you use on the import to get the build tools set up?

I prefer command-line as well. Am actually an Emacs guy, but single stepping gdb in IDE works a bit better. It would be easier if I have a Makefile. However, for the time being,

Install CUDA SDK by follow the instruction in https://docs.nvidia.com/cuda/nsightee-plugins-install-guide/index.html
Start Eclipse, set your workspace to your development directory

/home/chochain/devel in my case

Create a project: File=>Open Project from File System=>pick your ten4 repo directory

/home/chochain/devel/forth/ten4

Tune nvcc options: File=>Properties=>C/C++ Build=>Settings=>NVCC Compiler with following

Dialect => C++14
CUDA => Generate SM 5.2 SASS, Generate SM 5.2 PTX

To compile: Project=>Build Project, this should get through the compilation

/home/chochain/devel/forth/ten4/Debug/ten4 is created in my case. This is the executable.

Let me know whether it work for you while I try to build a Makefile for the job.

Thinks are looking pretty good:
https://github.com/AlgoCompSynth/tensorForth/blob/master/agx-xavier-make.log
https://github.com/AlgoCompSynth/tensorForth/blob/master/agx-xavier-test.log
https://github.com/AlgoCompSynth/tensorForth/blob/master/xavier-nx-make.log
https://github.com/AlgoCompSynth/tensorForth/blob/master/xavier-nx-test.log
https://github.com/AlgoCompSynth/tensorForth/blob/master/nano-make.log
https://github.com/AlgoCompSynth/tensorForth/blob/master/nano-test.log

Ed, thank you very much and hope you got some fun out of it, too. 8-)
Now we know it might work for other Nvidia chips, too. Seeing them run through Dr. Ting's test cases is very satisfying.
Here're the issues I noticed:

vector.h:35 has a bug which I fixed.
clock is skewed since I don't know how to get millisecond from within GPU and hard-coded (for my GTX1660). Knowing compute capability might help there, too.

The compute capacity code is done and pushed to the repo - see https://github.com/AlgoCompSynth/tensorForth/blob/master/set-envars.sh. It should work on any Linux with the CUDA samples installed. But there are probably better ways to query the device(s) in C++; I'm a shell programmer so I did it with grep and sed. :-)
Also, it works on Windows 11 / WSL / Ubuntu 20.04 now on my RTX 3090. I have a laptop dual-booted Windows 11 and Ubuntu 20.04 with a GTX 1650 but I'm assuming it'll work there too.

Now that I think of it, you can probably find the C++ way to query the devices in the PyTorch source; they have a function that lists the devices. Of course, they might be doing it via pycuda or something like that.

Rebuild on my desktop (the one with the 3090) for release 2.0.0 is in progress. It doesn't look like CUTLASS is in the repositories so I'm building it from source. It's taking a while and I'm only building for the GPU on this machine.
Once I get this done I'll attempt it on a Jetson with JetPack 5.0. If it will work with CUDA 10.2 I'll try it with JetPack 4.6.1, but I doubt if it will work on the Nano - it only has 4 GB of RAM and it's an ancient GPU.

Ed, your enthusiasm encourages me to plow forward. Thank you.
The inclusion of CUTLASS was a residual of my early GEMM lib testing with command line options. It escaped my attention when dropping the need of the same. I'm reworking opt.h right now so that people would not need to have CUTLASS on the system and hopefully lower system requirement.


Ingest photovoltaic data

Ingest photovoltaic capacity and costs data.
In order to creat this dataset, many different things needed to be refactored from previous steps, so this PR snowballed a bit into a monster.
@paarriagadap would you mind reviewing the files related to the papers namespace?
@spoonerf would you mind reviewing the files related to irena?
@lucasrodes would you mind reviewing th files related to energy?
Thanks a lot, and sorry for the big PR!

Hi @pabloarosado! The papers namespace seems fine, except for the meadow step of nemet_2009, which generates an error. I commented on the line of the error.

Now etl papers runs fine. There's only a warning for a step done in November, which I assume it's nothing:
3. data://meadow/papers/2022-11-03/zijdeman_et_al_2015...
2023-01-09 16:43.37 [info     ] zijdeman_et_al_2015.start
/home/parriagadap/etl/.venv/lib/python3.9/site-packages/openpyxl/styles/stylesheet.py:226: UserWarning: Workbook contains no default style, apply openpyxl's default
  warn("Workbook contains no default style, apply openpyxl's default")
2023-01-09 16:43.39 [info     ] zijdeman_et_al_2015.end
OK (5s)

Thanks @paarriagadap @spoonerf @lucasrodes and @Marigold for the review!


Maybe new model? Schematic Provided..

SKU593344   光控工控YD010(英文）.docx
I've one of this could you please tell me if it's supported?
Bought here:
https://it.aliexpress.com/item/DIY-Digital-Clock-Kit-Light-Control-Industrial-Control-1-Inch-LED-Electronic-Kit-5-Colors-in/32804714439.html?spm=a2g0y.search0104.3.8.ef30158cQz0JnA&ws_ab_test=searchweb0_0,searchweb201602_4_10152_10151_10065_10344_10068_10342_10343_10340_10341_10696_10084_10690_10083_10691_10618_10304_10307_10302_10689_10313_10059_10184_10534_100031_10688_10103_10624_10623_10622_10621_10620-10152,searchweb201603_25,ppcSwitch_5&algo_expid=adec31bf-5b61-43c2-8298-4f984780b608-1&algo_pvid=adec31bf-5b61-43c2-8298-4f984780b608&priceBeautifyAB=0
(Led Digits have Amber colors stock firmware has too dark light when ambient is full dark I must always set to disable automatic dim)
P.S.
I'm only windows user could you please provide a guide to compile and flash?
Command lines etc.. thanks in advance.
Best regards
Tony
Here it is also a scan but docx is perfectly my model.

I had the same problem with my yellow color unit.
I exchanged the (8) 510 ohm segment resistors with 47 ohm parts. This allows for a nice brightness range. While this appears to be a large change, the resulting current was within expected limits. I can only surmise the yellow LED's are significantly dimmer than the other colors.

@aFewBits
First all thanks a lots for your work, I've perfectly repaired another Clock kkmoon with your source.
I've installed kali linux in a virtual machine installed sdcc and compiled modifying global.h, then I've programmed the chip by windows with a little usb to ttl based on cp2102 using stc-isp-15xx-v6.86L.exe.
Now I've another one I do not succeed in compiling it correctly it gives always some error.
This is the schematic:

With this one I've tried with this changes:

Closed issue by error sorry people.

With zerog2k's firmware, IIRC, the 1F:7F display occurs when DS1302 is not communicating with the processor. I just posted a fix for the 15F204EA processor type on my repo and if you have comments or questions on my code, you should ask a question on that repo rather than here.

aFewBits you are right I'll close here and open issue there. Only for info also my model something hybrid with MODEL_C (it misses only relay on PCB) needs:
Changed DS1302's CE to open-drain output
//M1 M0
// 0 0 Bidirectional
// 0 1 Push-Pull
// 1 0 Input
// 1 1 Open-drain
//          IO CE CK
P1M1 = 0b00000010;
P1M0 = 0b00000010;

Constant 1F 7F has been changed to constant 00 00, but still could not set time.
Maybe all DS1302 pins need to be set to bidirectional as vargham suggested for his Model_D and solved.
I don't know how to do it.
@aFewBits thanks for helping opening question on your repo now.

Maybe better leave this open to permit also zerog2k to add all DS1302 pins bidirectional for model_c

As far as I understand it, from page 54 (5.1 Special Function Registers) of the STC15F204EA datasheet,  power-on defaults for P0Mx and P1Mx registers should be all zeroes, meaning pinmode is "quasi-bidirectional". I have seen this issue (ds1302 communication) reported several places, but myself have not been able to reproduce it. All of the models I had are slightly different w.r.t. pullups on various ds1302 lines, and different from what folks are having... I think the manufacturers keep cutting corners and  saving $0.0001 on external pullup resistors here and there..
I think a "real ds1302" is supposed to have something like approx 40k pull_down_ resistor on the signal lines, fwiw.
For this particular model, you may need to add a new model type if this is unlike anything existing. It sounds like it might be the case.

@flyingsaucer75
You referred in post date Mar 30, that green color clock with afewbits compiled source now is working perfectly.  Is it possible to upload HEX file of that ?  I have no knowledge of writing or compiling codes.  I want to try this HEX on my broken clock ! I have a clock with RED Leds and I attach circuit diag


(WIP) Pass on the forms chapter

This is not the full forms pass, better to merge it in pieces.

[x] Make the intro paragraph more interesting
[x] Move the description of how forms work up

I'll review once you review. :)

Quite right. After some thought I'll also split this one up—so I'll do the code and the text changes in different PRs.


Add translations into other languages

Currently the application is only available in Portuguese (en-us) and English (en-us). It would be great to find people willing to help with translations into other languages.
Any translation is welcome.
Choose a language and create its translation file named according to one of the ISO language codes from the table below.

Code
Name

af
Afrikaans

af-ZA
Afrikaans (South Africa)

ar
Arabic

ar-AE
Arabic (U.A.E.)

ar-BH
Arabic (Bahrain)

ar-DZ
Arabic (Algeria)

ar-EG
Arabic (Egypt)

ar-IQ
Arabic (Iraq)

ar-JO
Arabic (Jordan)

ar-KW
Arabic (Kuwait)

ar-LB
Arabic (Lebanon)

ar-LY
Arabic (Libya)

ar-MA
Arabic (Morocco)

ar-OM
Arabic (Oman)

ar-QA
Arabic (Qatar)

ar-SA
Arabic (Saudi Arabia)

ar-SY
Arabic (Syria)

ar-TN
Arabic (Tunisia)

ar-YE
Arabic (Yemen)

az
Azeri (Latin)

az-AZ
Azeri (Latin) (Azerbaijan)

az-AZ
Azeri (Cyrillic) (Azerbaijan)

be
Belarusian

be-BY
Belarusian (Belarus)

bg
Bulgarian

bg-BG
Bulgarian (Bulgaria)

bs-BA
Bosnian (Bosnia and Herzegovina)

ca
Catalan

ca-ES
Catalan (Spain)

cs
Czech

cs-CZ
Czech (Czech Republic)

cy
Welsh

cy-GB
Welsh (United Kingdom)

da
Danish

da-DK
Danish (Denmark)

de
German

de-AT
German (Austria)

de-CH
German (Switzerland)

de-DE
German (Germany)

de-LI
German (Liechtenstein)

de-LU
German (Luxembourg)

dv
Divehi

dv-MV
Divehi (Maldives)

el
Greek

el-GR
Greek (Greece)

en
English

en-AU
English (Australia)

en-BZ
English (Belize)

en-CA
English (Canada)

en-CB
English (Caribbean)

en-GB
English (United Kingdom)

en-IE
English (Ireland)

en-JM
English (Jamaica)

en-NZ
English (New Zealand)

en-PH
English (Republic of the Philippines)

en-TT
English (Trinidad and Tobago)

en-ZA
English (South Africa)

en-ZW
English (Zimbabwe)

eo
Esperanto

es
Spanish

es-AR
Spanish (Argentina)

es-BO
Spanish (Bolivia)

es-CL
Spanish (Chile)

es-CO
Spanish (Colombia)

es-CR
Spanish (Costa Rica)

es-DO
Spanish (Dominican Republic)

es-EC
Spanish (Ecuador)

es-ES
Spanish (Castilian)

es-ES
Spanish (Spain)

es-GT
Spanish (Guatemala)

es-HN
Spanish (Honduras)

es-MX
Spanish (Mexico)

es-NI
Spanish (Nicaragua)

es-PA
Spanish (Panama)

es-PE
Spanish (Peru)

es-PR
Spanish (Puerto Rico)

es-PY
Spanish (Paraguay)

es-SV
Spanish (El Salvador)

es-UY
Spanish (Uruguay)

es-VE
Spanish (Venezuela)

et
Estonian

et-EE
Estonian (Estonia)

eu
Basque

eu-ES
Basque (Spain)

fa
Farsi

fa-IR
Farsi (Iran)

fi
Finnish

fi-FI
Finnish (Finland)

fo
Faroese

fo-FO
Faroese (Faroe Islands)

fr
French

fr-BE
French (Belgium)

fr-CA
French (Canada)

fr-CH
French (Switzerland)

fr-FR
French (France)

fr-LU
French (Luxembourg)

fr-MC
French (Principality of Monaco)

gl
Galician

gl-ES
Galician (Spain)

gu
Gujarati

gu-IN
Gujarati (India)

he
Hebrew

he-IL
Hebrew (Israel)

hi
Hindi

hi-IN
Hindi (India)

hr
Croatian

hr-BA
Croatian (Bosnia and Herzegovina)

hr-HR
Croatian (Croatia)

hu
Hungarian

hu-HU
Hungarian (Hungary)

hy
Armenian

hy-AM
Armenian (Armenia)

id
Indonesian

id-ID
Indonesian (Indonesia)

is
Icelandic

is-IS
Icelandic (Iceland)

it
Italian

it-CH
Italian (Switzerland)

it-IT
Italian (Italy)

ja
Japanese

ja-JP
Japanese (Japan)

ka
Georgian

ka-GE
Georgian (Georgia)

kk
Kazakh

kk-KZ
Kazakh (Kazakhstan)

kn
Kannada

kn-IN
Kannada (India)

ko
Korean

ko-KR
Korean (Korea)

kok
Konkani

kok-IN
Konkani (India)

ky
Kyrgyz

ky-KG
Kyrgyz (Kyrgyzstan)

lt
Lithuanian

lt-LT
Lithuanian (Lithuania)

lv
Latvian

lv-LV
Latvian (Latvia)

mi
Maori

mi-NZ
Maori (New Zealand)

mk
FYRO Macedonian

mk-MK
FYRO Macedonian (Former Yugoslav Republic of Macedonia)

mn
Mongolian

mn-MN
Mongolian (Mongolia)

mr
Marathi

mr-IN
Marathi (India)

ms
Malay

ms-BN
Malay (Brunei Darussalam)

ms-MY
Malay (Malaysia)

mt
Maltese

mt-MT
Maltese (Malta)

nb
Norwegian (Bokm?l)

nb-NO
Norwegian (Bokm?l) (Norway)

nl
Dutch

nl-BE
Dutch (Belgium)

nl-NL
Dutch (Netherlands)

nn-NO
Norwegian (Nynorsk) (Norway)

ns
Northern Sotho

ns-ZA
Northern Sotho (South Africa)

pa
Punjabi

pa-IN
Punjabi (India)

pl
Polish

pl-PL
Polish (Poland)

ps
Pashto

ps-AR
Pashto (Afghanistan)

pt
Portuguese

pt-PT
Portuguese (Portugal)

qu
Quechua

qu-BO
Quechua (Bolivia)

qu-EC
Quechua (Ecuador)

qu-PE
Quechua (Peru)

ro
Romanian

ro-RO
Romanian (Romania)

ru
Russian

ru-RU
Russian (Russia)

sa
Sanskrit

sa-IN
Sanskrit (India)

se
Sami (Northern)

se-FI
Sami (Northern) (Finland)

se-FI
Sami (Skolt) (Finland)

se-FI
Sami (Inari) (Finland)

se-NO
Sami (Northern) (Norway)

se-NO
Sami (Lule) (Norway)

se-NO
Sami (Southern) (Norway)

se-SE
Sami (Northern) (Sweden)

se-SE
Sami (Lule) (Sweden)

se-SE
Sami (Southern) (Sweden)

sk
Slovak

sk-SK
Slovak (Slovakia)

sl
Slovenian

sl-SI
Slovenian (Slovenia)

sq
Albanian

sq-AL
Albanian (Albania)

sr-BA
Serbian (Latin) (Bosnia and Herzegovina)

sr-BA
Serbian (Cyrillic) (Bosnia and Herzegovina)

sr-SP
Serbian (Latin) (Serbia and Montenegro)

sr-SP
Serbian (Cyrillic) (Serbia and Montenegro)

sv
Swedish

sv-FI
Swedish (Finland)

sv-SE
Swedish (Sweden)

sw
Swahili

sw-KE
Swahili (Kenya)

syr
Syriac

syr-SY
Syriac (Syria)

ta
Tamil

ta-IN
Tamil (India)

te
Telugu

te-IN
Telugu (India)

th
Thai

th-TH
Thai (Thailand)

tl
Tagalog

tl-PH
Tagalog (Philippines)

tn
Tswana

tn-ZA
Tswana (South Africa)

tr
Turkish

tr-TR
Turkish (Turkey)

tt
Tatar

tt-RU
Tatar (Russia)

ts
Tsonga

uk
Ukrainian

uk-UA
Ukrainian (Ukraine)

ur
Urdu

ur-PK
Urdu (Islamic Republic of Pakistan)

uz
Uzbek (Latin)

uz-UZ
Uzbek (Latin) (Uzbekistan)

uz-UZ
Uzbek (Cyrillic) (Uzbekistan)

vi
Vietnamese

vi-VN
Vietnamese (Viet Nam)

xh
Xhosa

xh-ZA
Xhosa (South Africa)

zh
Chinese

zh-CN
Chinese (S)

zh-HK
Chinese (Hong Kong)

zh-MO
Chinese (Macau)

zh-SG
Chinese (Singapore)

zh-TW
Chinese (T)

zu
Zulu

zu-ZA
Zulu (South Africa)

Doing this in French! (fr-fr, but I guess the other countries translations are quite the same)

@AkdM  Thanks! Tonight I will review the contributions :)


Paint Application GUI

Description
Paint application GUI made using python. Provides functionality like drawing, saving file , using different colors and sizes of brushes
Fixes #685
Have you read the Contributing Guidelines on Pull Requests?

[x] Yes

Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] My documentation follows Template for README.md
[x] My changes generate no new warnings
[x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

@kaustubhgupta  The application is working successfully on my machine, but here the check is failing and giving some error. Can you please tell me how do I need to proceed.

@kaustubhgupta The application is working successfully on my machine, but here the check is failing and giving some error. Can you please tell me how do I need to proceed.

@Ayushjain2205 You have a lot of undefined variables you can check the logs here

@antrikshmisri This is a similar issue I found - https://stackoverflow.com/questions/58650783/errors-faced-when-using-pyqt
It says that it is a problem with the linter which is not able to detect dynamic Pyqt5 modules and is labelling them as undefined variables
The application is working perfectly but the linter is giving this error
So how do I go about this ?

@Ayushjain2205 Yup I don't think this linter has support for dynamic modules.@kaustubhgupta @santushtisharma10 What do you guys think? Should change pylint settings accordingly?

@Ayushjain2205 Yup I don't think this linter has support for dynamic modules.@kaustubhgupta @santushtisharma10 What do you guys think? Should change pylint settings accordingly?

Pylint settings can't be changed for one case. @Ayushjain2205 I would suggest, instead of importing all (*), import only the required elements from the modules. Example:
from PyQt5.QtGui import QAction

@kaustubhgupta  I tried what you said but that also doesnt solve the problem

Any other suggestions to solve this issue?

@kaustubhgupta I tried what you said but that also doesnt solve the problem

Any other suggestions to solve this issue?

Hmm, give me time till tomorrow morning, will get some ideas for this

@kaustubhgupta Any ideas to proceed with this issue?

@santushtisharma10 @Kushal997-das The test is failing due this: https://stackoverflow.com/questions/58650783/errors-faced-when-using-pyqt and https://github.com/avinashkranjan/Amazing-Python-Scripts/pull/695#issuecomment-804326317
Therefore, we need to ping PA to add PyQt to exceptions. For now, we can approve this PR after you suggest changes (if needed)

@Ayushjain2205 you have copied from here.  You have just removed some comments from the original code

@santushtisharma10 I have referred to this youtube video and when I was getting linting errors I refered to this article
I have written all the code myself after understanding each and every line and I know what is happening in each and every line

@Ayushjain2205 all the variable name, values and even the function name are exactly same.

@santushtisharma10 As this was the first time I was learning/using PyQt5 I have just coded along understanding how things are happening and what is happening.
I didnt realise it that time that I can change values just so that it doesnt appear as plagiarism
I can change the code or even add more functionality to proove that this is not just blind copy paste but I have spent time and effort in learning and implementing this

@santushtisharma10 As this was the first time I was learning/using PyQt5 I have just coded along understanding how things are happening and what is happening.
I didnt realise it that time that I can change values just so that it doesnt appear as plagiarism
I can change the code or even add more functionality to proove that this is not just blind copy paste but I have spent time and effort in learning and implementing this

@Ayushjain2205 okay, add a few more functionality

@santushtisharma10 I have added the following functionalities

Change canvas color
Change brush style

@Kushal997-das @kaustubhgupta


Add sqlite server support

I tried implementing #356 while also taking into consideration the feedback on #414
I ended up copying the Postgres implementation to the Sqlite implementation, which is not great for maintenance, but I did it for 2 reasons:

A generic implementation didn't work out because I got stuck in trait boundary problems I couldn't really solve
If I could solve those problems, the solution would be void when implementation start to drift.

How to use this?
db_uri = sqlite:///my/path/to/db.db  or other uri string as described here.
Possible improvements:

Instead of making the trait generic. The functions implementing the trait could be forwarded to reusable functions. I didn't try this, it might have the same compiler issues? It would save some duplicate code
As an Sqlite setup is probably for a single user, adding configuration options which register a user could save setup time. Or alternatively, we could remove registration all together. Both solutions would make it easier to use Atuin in a Gitpod or Codespace setup by just SSH forwarding the local server port and syncing every command.

While implementing this feature I found: https://github.com/tokio-rs/axum/discussions/358 but I missed the link to a dependency injection example in the Axum repo.
I changed the implementation for this feature to follow that example. While this probably causes a bit of overhead (with the usage of Arc), the code is a lot easier to read.

I think it matters very little - async trait is already full of dynamic dispatch

Hey, sorry for the silence. With the announcement of https://tokio.rs/blog/2022-08-whats-new-in-axum-0-6-0-rc1 I've figured out a way to make it generic and not need DynDatabase by utilising the type-safe state.
Because of that, I'm gonna wait until axum 0.6 releases then this can be the PR to kick that off :)

On top of that, I've tested both the postgres and the sqlite DB paths. I'm very happy with this, thanks for putting in the effort :)

Did anything end up blocking this?
I was interested in running my own personal atuin server in docker, but needing a postgres instance was a bit of a no start for me, so this looks awesome!

Thanks for the nudge!

Did anything end up blocking this?

axum 0.6, but we should get that merged soon #674
As for

I've figured out a way to make it generic and not need DynDatabase by utilising the type-safe state

If you check out 674, you'll see that handlers take State<AppState>. This can actually be generic, so we can offer Postgres or Sqlite handlers each.
I'll try resume this soon when I have some spare time again, unless @ekroon is up to rebase this onto 674 and understands my idea here.

@conradludgate  I think I understand and will give it a shot this weekend.

Thank you all for this initiative. sqlite support is so much better for atuin :)

Hate to nudge again but would still love to see this!

I started some time ago on some integration tests as mentioned here: https://github.com/ellie/atuin/pull/711
Will try to pick that up to get this moving again.


Return correct mime-types

Resource /containerapi/CSARs/{c}/Content/SELFSERVICE-Metadata/image.jpg should respond with the correct mime-type (image/jpeg) in order to display the image properly.

Checked the source code, the media type is set to image/*. We should be fine here, closing the issue.


Improved configuration checks

fixed and improved configuration checks broken by #899

This change is

Outstanding!

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@railsme Please get in touch with me directly. I'd like to send you an invite to our Slack Channel for React on Rails and discuss your usage of React on Rails.


config.json should only be generated if it doesnt exist

Currently config.json is generated everytime renee is run:

initialization
dryrun
run, etc.
It should be only generated at initialization, which may then be edited. Hence, it should NOT be regenerated and possibly overwritten!

We had this same problem in XAVIER. Adding an if/else to only run setup() if runmode == 'init' should do the trick.

Fixed in #39


GitHub Actions has encountered an internal error when running your job

Hi, I am getting this error when I try to run GitHub actions
GitHub Actions has encountered an internal error when running your job.

Wow today is the first time I started using github actions, and after 1-2 successful runs it started giving me these errors. I thought I am doing something wrong, after 1-2 hrs of head scratching I see this.
also checked https://www.githubstatus.com/

See https://github.com/actions/virtual-environments/issues/3611, this seems to be the same kind of issue. However, it looks like the issue has been fixed already.

Hello @filipaGitHub,
There was Github actions outage, currently, everything works fine.
In case of any questions, feel free to contact us.


How to get the depth map output?

Thanks for the fantastic work.
Accoding to the latest release I can get the normal map output.
Instead of using depth map prior, I wonder how can I get the depth map output for the generated multiple views?
I've tried transfer normal maps to depth maps but the results are inaccurate.

Depth is an absolute-valued modality unlike normals. Thus, the dynamic range of a natural image is not enough to encode useful information in depths.

Basically, you have to use another model upon the multi-view images for other kinds of prior that can get depths for you.

Thank you so much for your prompt response. I'm trying to using depth estimation model based on the multi-view images. I just wonder if there is a "ground truth" depth from the zero123plus model.


Replace Lurawave with OpenJPEG for .tiff>.jp2 conversions

Luratech is no longer supporting Lurawave and has let us out of our contract. We would like to replace Lurawave with OpenJPEG for our .tiff to .jp2 conversions.

https://wellcome.slack.com/archives/C6LLC2V8Q/p1583237193029900
That link above is where we talked about the Lurawave settings. Pasting below as well:

config_rate8.xml: c -i $inputFile$ -o $outputFile$ -Part1 -rate 8 -precise -accurate -visual 0 -layers 8 -tilew 1024 -tileh 1024 -tlm -levels 5 -p rpcl
12:06
ist used in
12:06
3rd Party TIFFs
Ancestry-JPEGs
Arabic_Manuscripts
Archives digitisation
Borthwick_3rd_Party_ftp
Digitisation_on_Demand
General_Manuscripts
Glasgow_Crichton_3rd_Party_ftp
LMA_3rd_Party_ftp
Medieval_Manuscripts
Paintings
Recipe_Books
Visual_Arts
12:07
config_lossless.xml: c -i $inputFile$ -o $outputFile$ -Part1 -layers 8 -tilew 1024 -tileh 1024 -tlm -levels 5 -p rpcl
12:07
is used in Iconographic_Images, Paintings
12:07
config_rate10.xml: c -i $inputFile$ -o $outputFile$ -Part1 -rate 10 -precise -accurate -visual 0 -layers 8 -tilew 1024 -tileh 1024 -tlm -levels 5 -p rpcl
12:07
is used in Archive Backlog, Archives digitisation, Genetics_Books_Project, Wellcome_Digitisation_Project
12:07
config.xml: c -i $inputFile$ -o $outputFile$ -Part1 -layers 8 -tilew 1024 -tileh 1024 -tlm -levels 5 -p rpcl
12:08
is used in Reading_Room_mini-theme
Ashley Ray  12:15 PM
Are those Lurawave settings set on the project? Rather than the process template then?
Robert Sehr  12:18 PM
they where on the process templates, the config*.xml is configured in the Lurawave task, but I could not found process templates for all projects any more

Also found this online, if at all helpful (but maybe it's old?) https://www.dpconline.org/docs/miscellaneous/events/529-jp2knov2010parametercomparisonchart/file

switched over to grok on both staging and production


Opal API - POST Opal data

Initial setup for the datahub API, POST function added for submitting Opal data

I'm still unable to change the local Opal data variable using the pandas accessor, even with importing the file via the namespace. @AdrianDAlessandro Could you have a look and see if there's something I'm doing wrong here?

You can run the API server with the command uvicorn datahub.main:app --reload
I've been testing the POST request function using Postman, sending a post request to http://<IP_ADDRESS>:8000/opal with the following JSON body:
{
  "frame": 1,
  "time": 8.58,
  "total_gen": 34.9085,
  "total_dem": 34.9055,
  "total_offwind": 16.177,
  "intra_trade": 0,
  "intra_gen": 0,
  "intra_dem": 0,
  "intra_sto": 0,
  "bm_gen": 0,
  "bm_sto": 0,
  "bm_dem": 0,
  "offwind_exp": 16192.89,
  "offwind_real": 16194.83,
  "bat_gen": -0.5713,
  "inter_gen": -0.8467,
  "offwind_gen": 16.2002,
  "onwind_gen": 9.0618,
  "other_gen": 0.2806,
  "pump_gen": -2.1328,
  "pv_gen": 0,
  "nc_gen": 0.7931,
  "hyd_gen": 0.0522,
  "gas_gen": 0.0522,
  "total_exp": 34.8373,
  "total_real": 34.8343,
  "bm_cost": 0,
  "bm_accept": 0,
  "exp_dem": 30.801,
  "real_dem": 30.801,
  "act_work": 28,
  "act_study": 5,
  "act_home": 63,
  "act_pers": 72,
  "act_shop": 0,
  "act_leis": 303,
  "act_sleep": 7230,
  "exp_ev": 3.774,
  "real_ev": 3.774,
  "ev_charge": 510,
  "ev_travel": 2,
  "ev_idle": 34
}


Update Generation way of the options

When the options array was created, only the unsigned value were setted.

Misses test cases, plus the additional conditionals should be stashed in a separate private method.

I updated the code, and put it into a function, but i'm not the best at doing tests and i currently cannot test them on my machine.
If someone could do them for me, it would be much appreciated :)

There still is a bug with the comments with double quotes, even escaping them doesn't work. for myself i replaced them all with simple quotes, but it's a solution only for my projet, not for long therm.

I updated the code, and put it into a function, but i'm not the best at doing tests and i currently cannot test them on my machine.

Travis can test things for you. Also, read https://github.com/doctrine/doctrine2/blob/e3ecec36ad77525553bfd4e6a2ec86e80d39ac27/CONTRIBUTING.md#unit-tests please :-)

I'm going to close this PR as we will be removing EntityGenerator in Doctrine 3.0 completely and 2.x is closed feature-wise. Thank you for the PR.

Yeah, I completely forgot to update theses :/
Sorry for that.


Adapt to having separate DB for cell1 by default

The nova-operator will switch to cell1 having a separate MariaDB instance in https://github.com/openstack-k8s-operators/nova-operator/pull/279. This PR prepares for it by pre-creating the openstack-cell1 MariaDB or Galera instance.
The collapsed_cell sample is the only one that kept back to use a single DB and single RabbitMQ for the whole nova deployment.

I used the samples from this PR with an openstack-operator (OPENSTACK_IMG=quay.io/gibi/openstack-operator-index:v0.0.100 make openstack) where nova-operator was bumped to contain https://github.com/openstack-k8s-operators/nova-operator/pull/279 and the deployment was successfully with two MariaDBs one for cell1 and one for the rest of the cluster:
$ oc rsh mariadb-openstack-cell1 mysql -u root --password=12345678 -e 'show databases;'
+--------------------+
| Database           |
+--------------------+
| information_schema |
| mysql              |
| nova_cell1         |
| performance_schema |
+--------------------+
$ oc rsh mariadb-openstack mysql -u root --password=12345678 -e 'show databases;'
+--------------------+
| Database           |
+--------------------+
| cinder             |
| glance             |
| information_schema |
| keystone           |
| mysql              |
| neutron            |
| nova_api           |
| nova_cell0         |
| performance_schema |
| placement          |
+--------------------+
$ openstack compute service list
+--------------------------------------+----------------+------------------------+----------+---------+-------+----------------------------+
| ID                                   | Binary         | Host                   | Zone     | Status  | State | Updated At                 |
+--------------------------------------+----------------+------------------------+----------+---------+-------+----------------------------+
| 1e0cd304-e1a9-4540-9481-1d59d7c9c0a2 | nova-conductor | nova-cell0-conductor-0 | internal | enabled | up    | 2023-04-06T08:42:02.000000 |
| e285e600-7e51-4309-9c80-5e64719c223b | nova-scheduler | nova-scheduler-0       | internal | enabled | up    | 2023-04-06T08:41:59.000000 |
| b56a1543-14ab-4ece-870a-ced931bad167 | nova-conductor | nova-cell1-conductor-0 | internal | enabled | up    | 2023-04-06T08:42:03.000000 |
+--------------------------------------+----------------+------------------------+----------+---------+-------+----------------------------+

/lgtm


Restore coverage badges

:tada: This PR is included in version 1.9.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


zsh: killed on macOS m1

Happened on v0.0.70

I encounter it too, so how to fix it?

I don't have the macOS m1 now. Please feel free to figure out it if you're familar with Golang.


Tip: How to populate Filter options from database

(For my future reference and will hopefully help someone else)
The docs are pretty clear on adding custom filter with pre-defined options: http://flask-admin.readthedocs.io/en/latest/api/mod_contrib_mongoengine/
But it was unclear to me how to populate the options from database. Here is solution I found through trial and error. If there is a better way, direction is welcome.
Example (I'm using MongoEngine):

# Showing relevant code

# models
class BaseballTeam:
    team = db.StringField()

class BaseballCard(db.Document):
    player = db.StringField()
    team = db.ReferenceField(BaseballTeam)

# My primary challenge learning when/where to make call to database
def _get_teams(self):
        opts = [(str(x.id), x.team) for x in BaseballTeam.objects().all()]
        return opts

class FilterTeam(BaseMongoEngineFilter):
    def apply(self, query, value):
        return query.filter(team__contains=value)

    # Turns out, there's a handy method for populating the options
    def get_options(self, view):
        return _get_teams(self)

    def operation(self):
        return 'contains'

class BaseballCardAdmin(ModelView):
    ...
    column_filters = [ FilterTeam(
                                  column='team', name='Team',
                                  #options=()  #not sure if it's possible to call '_get_teams()' from here ?
                                )
                              ]

   ...

very productive example and please change title to flask admin custom filter because current title is not as informational as it does the work 👍

@macfire can you tell me how to filter embedded field ?
class SpecialPrice(EmbeddedDocument):
    value = FloatField()
    is_active = BooleanField(default=False)
    active_from = DateTimeField()
    active_to = DateTimeField()

    def __unicode__(self):
      return self.value

class Product(Document):
..
    special_price = EmbeddedDocumentField(SpecialPrice)
..

Hi, you can uggly patch for force reload cache.
`
column_filters =    ( filters.FilterEqual('team', 'Team', options=lims.models.fournisseurs.Fournisseurs._get_teams), )
def get_list(self, *args, **kwargs):
   self._refresh_filters_cache() # Ugly Force update filter and options cache
   count, data = super(self.__class__, self).get_list(*args, **kwargs)
   return count, data

`


Add support for direct CASAPI access from libToolchainCASPlugin.dylib

Add initial CAS support through libToolchainCASPlugin.dylib

Currently only implements store action in plugin CAS as it is the only one needed for now.
Depends on https://github.com/apple/swift/pull/67942

Could you clarify what the overall goal and design of CAS access is? For example it's not clear to me how direct access to the C API of the plugin relates to the swiftscan_cas_create_from_plugin/swiftscan_cas_store APIs. When is it intended to call swiftscan_cas_store and when is the plugin C API store called instead?
My first thought is that we could do what we did for libclang where we have higher-level libclang APIs that represent the CAS-related actions and we don't expose low-level access to direct CAS objects & APIs. Whether the C plugin ends-up getting used or direct on-disk CAS is just a configuration change, it doesn't even change the code-paths in libclang (it uses the C++ ObjectStore/ActionCache APIs).
Should we do something similar here (have higher level swiftscan_ APIs for driver-related CAS/caching actions) and avoid low-level CAS APIs?

Could you clarify what the overall goal and design of CAS access is? For example it's not clear to me how direct access to the C API of the plugin relates to the swiftscan_cas_create_from_plugin/swiftscan_cas_store APIs. When is it intended to call swiftscan_cas_store and when is the plugin C API store called instead?

It is not related. Maybe I should break that apart into two commits/PRs. Scanner will keep its own CAS instance (can be created from plugin after this commit), while giving the option for swift driver to have direct CAS access without going through scanner and owns a difference CAS instance.

My first thought is that we could do what we did for libclang where we have higher-level libclang APIs that represent the CAS-related actions and we don't expose low-level access to direct CAS objects & APIs. Whether the C plugin ends-up getting used or direct on-disk CAS is just a configuration change, it doesn't even change the code-paths in libclang (it uses the C++ ObjectStore/ActionCache APIs). Should we do something similar here (have higher level swiftscan_ APIs for driver-related CAS/caching actions) and avoid low-level CAS APIs?

For short term, we can definitely go through swift scan API for all the CAS operations. The direct CAS access allows converting more scanner logic into swift code.

Scanner will keep its own CAS instance (can be created from plugin after this commit), while giving the option for swift driver to have direct CAS access without going through scanner and owns a difference CAS instance.

Is the intention that these are exclusionary? Meaning, the CAS scanner APIs will be used until the driver moves fully to direct CAS access and at which point we'll deprecate the CAS scanner APIs?
Or are they both going to be used at the same time for different purposes?

Is the intention that these are exclusionary? Meaning, the CAS scanner APIs will be used until the driver moves fully to direct CAS access and at which point we'll deprecate the CAS scanner APIs? Or are they both going to be used at the same time for different purposes?

Depending how much of the depscanner can be written in swift, both will co-exist for a long time. It doesn't really hurt to have scanner and driver each have its own CAS instance which points to the same CAS, just like each swift-frontend invocation will have its own CAS instance pointing to the shared underlying CAS.
If the driver has its own CAS, I might just completely implement the CAS replay logic in swift driver. Otherwise, we can always get some new scanner API that does the replay.

Split out the pluginCAS support in SwiftScan to https://github.com/apple/swift-driver/pull/1422/files
Will rebase this once the other PR is resolved.


[Snyk] Security upgrade Umbraco.Cms from 10.6.1 to 10.8.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `nuget` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

GovUk.Frontend.Umbraco.ExampleApp/GovUk.Frontend.Umbraco.ExampleApp.csproj

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

551/1000  Why? Recently disclosed, Has a fix available, CVSS 5.3
Exposure of Sensitive Information SNYK-DOTNET-UMBRACOCMS-6124616
No
No Known Exploit

471/1000  Why? Recently disclosed, Has a fix available, CVSS 3.7
Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting') SNYK-DOTNET-UMBRACOCMS-6124620
No
No Known Exploit

471/1000  Why? Recently disclosed, Has a fix available, CVSS 3.7
Information Exposure SNYK-DOTNET-UMBRACOCMS-6124631
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting')

I've updated this automatic PR with a further upgrade to 10.8.3, which fixed some bugs with 10.8.1.


Missing 404 routing

Add a 404 screen when route cannot be found

@r7perezyera
https://reactrouter.com/web/example/no-match


added support for ensembl-metadata

Bio::EnsEMBL::Registry now has support for the new ensembl-metadata API, handled in the same way as ensembl-taxonomy.

Coverage decreased (-0.02%) to 79.676% when pulling c74aa9497ae1f8aa04ecbb6312eaf994dd8ac87b on danstaines:master into a7871960c30b7c5ae6c97d87fda7be4d842d04e2 on Ensembl:master.

I guess it's going to be hard to add a test for this in the core API
as long as it's tested in the ensembl-metadata API, change looks fine to me

If that gets integrated I have an idea for a speed increase for the grep @danstaines modified in get_species_and_object_type. After Will's optimisation talk I don't think multiple $dba->dbc->dbname calls is going to help speed.

is this ok to be pulled then? Integration testing in Registry is a tricky problem - and one I happily leave to others...
@andrewyatz  - I'll leave you to make optimisation changes as you see fit.

Looks sane :)


Adding Thuongmai University

Please add Thuongmai University
Thanks and regards,
Danny Jacobi

@dannyjacobi96 Thank you for the request. Regrettably, this university has a different official domain. I have to close the request without merging. If you are a student of this school, please apply with official document ("OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students).


Fix for multiple _ne operators

When filtering with multiple _ne it should use logical AND instead of OR to verify that all checks succeed, close #929

Thanks!


Insiders hasn't been updated for a week

Users are having issues with broken insiders and it isn't getting updated https://github.com/microsoft/vscode-python/issues/9015

@DonJayamanne so are you linking to that issue saying that's the cause?

No, linking to an issue where user was having this problem

🥳  Insiders build: https://dev.azure.com/ms/vscode-python/_build/results?buildId=57872&view=results


Step 4: Request context

Hello,
I added the following features in this PR:

Added Request context
Application context (Improved stores code too)
Replaced the AppSettings table with a config file management.
Added a secrets config file management.
Fixed the reset-password script.
Fixed the changepassword api security (any user could change another user's password)
Added an admin api but it is just a draft for the multi user feature so it's unused right now.
Split the uuid away from the users table.
Simplified the prehandler system
Fixed some of the security problems with the session id.
Fixed some of the security problems with the apis.

The work is still in progress. I still need to:

test the app

seems like i already fixed all those you pushed. i ll push force.

I think I'll really need your help on the front end side. I can fix small things but it'll take me some time to understand the flow.
I've secured apis as they should but the frontend makes requests it shouldn't in certain states.
It tries to load user stuff before being logged in. I think it should query for the application configuration and then determine what to do.
Can you take a look at this ?

You can also add the "sessionLengthInDays" and "userRegistrationEnabled" options in the UI.

I think I'll really need your help on the front end side. I can fix small things but it'll take me some time to understand the flow. I've secured apis as they should but the frontend makes requests it shouldn't in certain states. It tries to load user stuff before being logged in. I think it should query for the application configuration and then determine what to do. Can you take a look at this ?

The application first requests the /api/users/me endpoint. If the status is 200, this is a redirect to the index page. If it's a 404, then it means there are no registered users and it's redirecting to /register. If the status code is anything other than 200 or 404, it is redirected to /login.

Actually, i created a AppSettingsProvider objects which i put at the root of the ui elements in index.js:
root.render(
  <React.StrictMode>
    <AppSettingsProvider>
      <IsLoggedInProvider>
        <UserSettingsProvider>
          <CategoriesListProvider>
            <App />
          </CategoriesListProvider>
        </UserSettingsProvider>
      </IsLoggedInProvider>
    </AppSettingsProvider>
  </React.StrictMode>
);

Based on recovered settings, i want to determine if we display the login or not so that i can fix the ui on nologin mode.
I wanted this to be loaded first and then added a check on retrieved value in App.jsx effect:
 if (authenticationEnabled) {
     fetchProfile();
   }

However, App.jsx effect takes precedence in execution even when it is the very leaf of the dom tree so it's as authenticationEnabled is always true and /api/users/me is always called first.
PS: I see you want to directly redirect to /register if we have no login but we should make as less calls to the database as we can so the check on whether the table is empty may not be at the right place. I'll introduce a boolean context for this.

I think i can just add sign up button to login screen.
Or we can add a default user with default credentials when the database is initialized on first run, but I think it would be better if the user creates a new root user by himself.

the hasAdminUser and hasAnyUser states are implemented now and i reopened /api/users/me to anyone.

Thanks for taking time looking at this. I'll merge this with my changes when i can. I followed planty of react trainings yesterday so i'll catch up.

There should be a huge improvement. Alas I don't have time to test tonight. I'll check when i have time to come back on it.

There are still some bugs i ll fix tomorrow but the code changes are there.

Sorry for the sudden stop, i can't continue for a little while. I'll continue once i get some time. My twins are born last week ^^
But feel free to go forward.

Congratulations! Everything is fine, I will fix the bugs and release a new version, without multi-users yet.

Hello. Thanks for continuing this. Before you merge it, i think there is a bug during the migration / first user creation to be checked. I believe the isAdmin flag is inverted or not properly converted to boolean/number and always end up set as 0. That s why I created a script to invert that flag. I wanted to investigate this too.


Add CI build

Thanks, but updating a version every time it's removed from SourceForge is bad practice IMHO. I found a repository where copies of the gSoap archives are saved: https://github.com/SrcBackup/gsoap. When I have time to test the new version, I will update it, (at least it makes sense for the problem described here: https://sourceforge.net/p/gsoap2/bugs/1269/), this problem was solved in version 2.8.99.

My main intention was to add a CI build, I'm not that bothered about which gSOAP version it uses.