Best Traineddata Feedback - Persian

Ref: https://github.com/tesseract-ocr/langdata/pull/76#issuecomment-320425422
copied below

Hello
I'm a software engineering student and i use tesseract OCR engine in a university project. For persian language, traineddata which it's a file and it made by Training tesseract 4.00 and LSTM method, has a good result and output in Arial fonts but it doesn't have any good result in some specific fonts for persian. So the questions are :
1- did you use specific fonts like B Nazanin , B Roya or etc in Training Tesseract 4.00 with LSTM or not?
2- if they haven't used how can we use these fonts for getting better result?
I prepared a text that all the cases of litrates have repeated for 10 or 15 or more than 15 times in this text. Also i used the process of training tesseract 3.05 for this text but i didn't get better and beneficial output.
For achieving to a good result in persian in Tesseract OCR engine we need your experience and your help.
Thanks for your attention
Sincerely.

@aidinkrmz
Are B Nazanin , B Roya unicode fonts?

Also see
https://github.com/tesseract-ocr/tessdata/issues/3
https://github.com/tesseract-ocr/langdata/issues/26

@theraysmith
Does language-specific.sh have the current list of fonts used by your BEST training?

Are B Nazanin , B Roya unicode fonts? Please try OCR with the latest BEST traineddata.

Those names usually indicating a family of fonts, if you can train a new set of font for Persian, from these page which provides OFL licensed fonts and used heavily on Persian Tex community, download these: XB Zar, XB Roya (equal to B Roya), XB Kayhan (somehow equal to B Nazanin).
Also here is also another Persian font bundle contains both Roya and Nazanin (under Nazli name). These ones have less glyph coverage but somehow more standard compliant.
You can have B Nazanin and B Roya themselves also.

Please try OCR with the latest BEST traineddata.

Is LSTM based Persian traineddata released recently? How we can have a look?

@Shreeshrii ofcourse they are unicode fonts and also more than 90% percent of texts use this font family like B NAZANIN , B yaGHoot , B zar

@ebraminio salam zaheran shoma irani hastid bezarin ma moshkelemono ba shoma dar miyan bezarim traindatayi ke alan ma dar ekhtiyar darim ba fonte arial fgt dorost kar mikonan va matn hayi ke ba font haye irani mesle B nazanin ya B zar neveshte mishe dorost javab nemidan va kar nemikonan be nazareton chare chiye rahe hali hast?

I tested version 4 for attached image. it has these problems
1-doesn't recognize ZWNJ
2-doesn't recognize ●
3-has problem with Ligatures like لا

Please see
https://github.com/tesseract-ocr/tessdata/blob/master/best/fas.traineddata
for the 4.0alpha best model for persian, uploaded by @theraysmith just a
few days back.
Your feedback will help him improve the next version of training for beta
release.
ShreeDevi

भजन - कीर्तन - आरती @ http://bhajans.ramparivar.com
On Sat, Aug 5, 2017 at 3:27 PM, mohammad reza<EMAIL_ADDRESS>wrote:

I tested version 4 for attached image. it has these problems
1-doesn't recognize ZWNJ
https://en.wikipedia.org/wiki/Zero-width_non-joiner
2-doesn't recognize ●
3-has problem with Ligatures like لا
https://en.wikipedia.org/wiki/Arabic_alphabet#Ligatures
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tesseract-ocr/tessdata/issues/70#issuecomment-320434564,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE2_ozQyB1glSITgP-DcG29KGBcefIpJks5sVDyngaJpZM4OuZjP
.

@reza1615 use vietocr 5 alpha you can get good result with it

@aidinkrmz also I tested vietocr 5 alpha. it has the same problem (you can test the attached image). vietocr is only an interface.

Everyone how tests the new best traineddata should also update Tesseract to the latest commit.

is it the last version? here

Yes, that version is the last version.

@reza1615 but i test your pic without any error !!!!!!!!

@aidinkrmz for me it recognizes ساختمان‌ها as ساختمانها ?
or ● as @

@reza1615 agha mohammad reza aziz 2 3 % khata ghabele hale kamel ke dg nabayad tashkhis bede ke on sakhtoman ha ham 2 3 darsad irade

@aidinkrmz you said it doesn't have any error!! now you says it has 2-3 % errors!
I didn't say tesseract-ocr has fatal bug I said it should recognize these problems when these bugs could solve why we shouldn't solve them at the program? also, it doesn't recognize ZWNJ and it isn't a minor bug.

@reza1615 we talk abut traindata file so the traindata file doesn`t have any problem

@reza1615

it doesn't recognize ZWNJ and it isn't a minor bug.

Please elaborate on that with some examples and any suggestions you have for fixing. Thanks!

@Shreeshrii At this image
yellow: doesn't recognize Zwnj
Red: problem with Ligature لا
Green: problem with ●
Blue: confused .  (dot) and ۰ (persian 0)
Perpul: incorrect word
I attached the output file   to compare them

In my opinion, @theraysmith trained the data from texts which don't have ZWNJ. you can use fa.wikipedia Featured articles which uses correct persian handwriting at here  and here there are many texts. you can collect the articles from here

@Shreeshrii: I see LSTM result so convincing here. Keep up the good work :)

Question from Ray in https://github.com/tesseract-ocr/langdata/issues/72

Anyone know which digits are needed for the other Arabic languages?
kur_ara, pus, uig

Hi shree i tested BEST fas.traineddata. but it has problem. "لا".it can't recognize it and i did fine tune for "لا". and again had this problem and about xheight, i used Arabic.xheight for persian but after creating unicharset, this file had cleared.

@theraysmith Any update regarding the new training for RTL languages?

Hi. I tested BEST fas.traineddata but it had some errors. I integrate some fonts: "B Nazanin" "B Zar" "B Lotus" by fine tuning the pre-training model. After testing the new .traineddata, It could recognize some fonts better than the BEST  fas.traineddata. but it couldn't recognize ZWNJ. However with BEST fas.traineddata I could recognize ZWNJ.Nnow my questions are:
1- What fonts did you used for training and making the BEST fas.traineddata?
2- How should I training tesseract-ocr 4.0 to recognize ZWNJ in Persian language?

@AbdelsalamHaa
Did you try with script/Arabic.traineddata?

@farhodi What training text did you use for fine tuning? did it have any ZWNJ in it?
Take a look at the unicharset from your trained data and compare with the one in the repository.
Make sure you have all needed characters in your training text.
Regarding the font list and training done originally by Ray Smith, we are awaiting updates to labhdayak.

Updates to langdata
Please ignore the error in earlier post (autocorrection on phone)

hi, i test new version of tesseract (4 beta) on persian language. the results its good but there are some errors.
for examples :

in different char that have same shape with different dot location or number of dots. (ex. بـ تـ ثـ یـ or ز ر ژ)
in some cases when there are same word in doc, the results of these same words are different. (ex. word="نویسه")

i think at the end of process, does not apply dictionary correction, is it true ?
and how could we train more fonts ?

thanks

@Shreeshrii I've used the same training text in langdata "fas" folder for fine tuning. Just add new fonts for training. Also I couldn't find fas.unicharset at langdata repository to compare with my .unicharset.
The .unicharset I've used is as follow:
108
NULL 0 NULL 0
Joined 7 0,255,0,255,0,0,0,0,0,0 Latin 1 0 1 Joined	# Joined [4a 6f 69 6e 65 64 ]a
|Broken|0|1 f 0,255,0,255,0,0,0,0,0,0 Common 2 10 2 |Broken|0|1	# Broken
و 1 0,68,137,238,65,290,0,27,62,256 Arabic 3 13 3 و	# و [648 ]x
ه 1 55,123,147,255,35,181,6,64,48,222 Arabic 4 13 4 ه	# ه [647 ]x
ک 1 47,121,200,255,131,288,0,45,124,305 Arabic 5 13 5 ک	# ک [6a9 ]x
ن 1 0,88,163,255,68,321,0,52,76,354 Arabic 6 13 6 ن	# ن [646 ]x
ی 1 0,71,148,225,95,253,0,45,103,279 Arabic 7 13 7 ی	# ی [6cc ]x
ا 1 26,117,200,255,11,181,7,82,33,222 Arabic 8 13 8 ا	# ا [627 ]x
خ 1 0,66,172,255,92,262,2,37,84,290 Arabic 9 13 9 خ	# خ [62e ]x
س 1 0,64,140,228,123,493,0,50,132,523 Arabic 10 13 10 س	# س [633 ]x
ع 1 0,64,148,255,98,239,2,37,81,276 Arabic 11 13 11 ع	# ع [639 ]x
ض 1 0,64,174,255,131,619,0,50,132,654 Arabic 12 13 12 ض	# ض [636 ]x
م 1 0,64,134,241,51,272,0,46,56,313 Arabic 13 13 13 م	# م [645 ]x
ل 1 0,96,200,255,62,328,0,50,71,332 Arabic 14 13 14 ل	# ل [644 ]x
ف 1 44,125,202,255,113,339,0,47,123,378 Arabic 15 13 15 ف	# ف [641 ]x
ر 1 0,63,137,224,45,297,0,22,59,244 Arabic 16 13 16 ر	# ر [631 ]x
پ 1 0,42,142,217,113,258,2,50,123,288 Arabic 17 13 17 پ	# پ [67e ]x
د 1 49,123,163,250,43,467,0,70,59,503 Arabic 18 13 18 د	# د [62f ]x
ت 1 58,123,170,255,113,339,2,50,123,378 Arabic 19 13 19 ت	# ت [62a ]x
. 10 12,108,64,140,18,52,9,77,52,193 Common 20 6 20 .	# . [2e ]p
ج 1 0,64,133,255,92,262,2,37,84,290 Arabic 21 13 21 ج	# ج [62c ]x
ق 1 0,79,179,255,84,310,0,52,88,345 Arabic 22 13 22 ق	# ق [642 ]x
ش 1 0,64,196,255,123,493,0,50,132,523 Arabic 23 13 23 ش	# ش [634 ]x
ز 1 0,63,167,255,45,298,0,22,59,242 Arabic 24 13 24 ز	# ز [632 ]x
: 10 12,108,157,255,18,58,11,77,52,193 Common 25 6 25 :	# : [3a ]p
ب 1 0,71,140,224,113,339,0,50,123,378 Arabic 26 13 26 ب	# ب [628 ]x
آ 1 26,117,230,255,36,161,0,58,33,198 Arabic 27 13 27 آ	# آ [622 ]x
ي 1 0,56,148,255,95,431,0,45,103,467 Arabic 28 13 28 ي	# ي [64a ]x
گ 1 47,125,208,255,131,289,0,45,132,305 Arabic 29 13 29 گ	# گ [6af ]x
, 10 0,72,69,140,21,62,8,65,39,193 Common 30 6 30 ,	# , [2c ]p
غ 1 0,64,196,255,98,239,2,37,81,276 Arabic 31 13 31 غ	# غ [63a ]x
ح 1 0,64,133,255,92,262,2,37,84,290 Arabic 32 13 32 ح	# ح [62d ]x
= 0 86,150,160,244,90,218,3,33,99,262 Common 33 10 33 =	# = [3d ]
} 10 0,67,210,255,37,125,4,46,54,193 Common 34 10 86 }	# } [7d ]p
ك 1 49,123,203,255,91,451,0,50,103,483 Arabic 35 13 35 ك	# ك [643 ]x
/ 10 12,102,224,255,43,166,0,29,54,193 Common 36 6 36 /	# / [2f ]p
٧ 8 58,125,181,255,70,211,0,65,87,270 Common 37 5 37 ٧	# ٧ [667 ]0
٨ 8 58,123,179,255,70,235,0,65,88,270 Common 38 5 38 ٨	# ٨ [668 ]0
٣ 8 55,121,184,255,71,235,0,65,88,338 Common 39 5 39 ٣	# ٣ [663 ]0
١ 8 55,121,184,255,13,134,0,110,57,270 Common 40 5 40 ١	# ١ [661 ]0
٤ 8 60,121,183,255,46,238,0,62,58,270 Common 41 5 41 ٤	# ٤ [664 ]0
ژ 1 0,63,192,255,71,190,0,22,59,193 Arabic 42 13 42 ژ	# ژ [698 ]x
چ 1 0,29,133,213,92,192,4,37,84,213 Arabic 43 13 43 چ	# چ [686 ]x
ۀ 1 59,121,206,255,40,134,0,20,48,165 Arabic 44 13 44 ۀ	# ۀ [6c0 ]x

10 76,186,109,216,42,121,4,55,51,193 Common 45 3 45 -	# - [2d ]p
ظ 1 40,123,200,255,110,574,0,19,113,610 Arabic 46 13 46 ظ	# ظ [638 ]x
ؤ 1 0,68,190,255,70,290,0,27,62,266 Arabic 47 13 47 ؤ	# ؤ [624 ]x
، 10 30,121,105,221,20,67,5,72,43,193 Common 48 6 48 ،	# ، [60c ]p
ص 1 0,64,143,249,131,619,0,50,132,654 Arabic 49 13 49 ص	# ص [635 ]x
۸ 8 60,121,179,255,70,176,0,30,88,193 Arabic 50 2 50 ۸	# ۸ [6f8 ]0
% 10 14,102,204,255,88,377,0,22,132,397 Common 51 4 51 %	# % [25 ]p
0 8 14,100,204,255,65,212,6,29,78,249 Common 52 2 52 0	# 0 [30 ]0
ط 1 40,123,200,255,110,574,0,20,113,610 Arabic 53 13 53 ط	# ط [637 ]x
۱ 8 64,121,184,255,22,76,24,75,88,193 Arabic 54 2 54 ۱	# ۱ [6f1 ]0
۹ 8 64,121,181,255,56,152,15,46,88,193 Arabic 55 2 55 ۹	# ۹ [6f9 ]0
۲ 8 64,121,183,255,50,150,17,42,88,193 Arabic 56 2 56 ۲	# ۲ [6f2 ]0
۰ 8 84,155,139,215,24,68,32,77,88,193 Arabic 57 2 57 ۰	# ۰ [6f0 ]0
۷ 8 58,121,181,255,70,176,0,37,88,193 Arabic 58 2 58 ۷	# ۷ [6f7 ]0
( 10 0,85,197,255,31,108,8,74,63,193 Common 59 10 66 (	# ( [28 ]p
] 10 0,73,207,255,31,112,0,53,61,193 Common 60 10 62 ]	# ] [5d ]p
2 8 17,108,204,255,70,215,3,24,78,249 Common 61 2 61 2	# 2 [32 ]0
[ 10 0,73,209,255,31,112,13,72,61,193 Common 62 10 60 [	# [ [5b ]p
7 8 17,108,201,255,67,215,4,37,78,249 Common 63 2 63 7	# 7 [37 ]0
ذ 1 49,123,197,255,43,467,0,70,59,503 Arabic 64 13 64 ذ	# ذ [630 ]x
؟ 10 0,123,188,255,35,181,5,48,69,222 Common 65 13 65 ؟	# ؟ [61f ]p
) 10 0,85,197,255,31,108,0,55,63,193 Common 66 10 59 )	# ) [29 ]p
1 8 17,108,204,255,42,136,18,43,78,249 Common 67 2 67 1	# 1 [31 ]0
3 8 14,100,204,255,59,215,4,30,78,249 Common 68 2 68 3	# 3 [33 ]0
8 8 14,100,204,255,59,218,6,29,78,249 Common 69 2 69 8	# 8 [38 ]0
4 8 17,108,204,255,71,225,1,22,78,249 Common 70 2 70 4	# 4 [34 ]0
ة 1 55,123,190,255,40,181,0,60,48,222 Arabic 71 13 71 ة	# ة [629 ]x
ث 1 58,121,192,255,113,339,2,50,123,378 Arabic 72 13 72 ث	# ث [62b ]x
۵ 8 60,126,177,255,61,161,4,32,88,193 Arabic 73 2 73 ۵	# ۵ [6f5 ]0
٠ 8 56,165,126,227,24,99,8,98,56,270 Common 74 5 74 ٠	# ٠ [660 ]0
» 10 17,140,166,255,70,158,4,43,78,249 Common 75 10 80 »	# » [bb ]p
۳ 8 64,121,184,255,71,166,8,27,88,193 Arabic 76 2 76 ۳	# ۳ [6f3 ]0
ء 1 32,112,129,220,43,163,3,67,62,199 Arabic 77 13 77 ء	# ء [621 ]x
ى 1 0,100,148,255,95,431,0,45,103,467 Arabic 78 13 78 ى	# ى [649 ]x
أ 1 26,117,248,255,29,148,0,67,33,193 Arabic 79 13 79 أ	# أ [623 ]x
« 10 17,140,166,255,68,161,4,43,78,249 Common 80 10 75 «	# « [ab ]p
٢ 8 55,121,183,255,50,214,0,62,77,270 Common 81 5 81 ٢	# ٢ [662 ]0
5 8 14,100,201,255,62,218,6,37,78,249 Common 82 2 82 5	# 5 [35 ]0
ئ 1 0,100,185,255,95,431,0,45,103,467 Arabic 83 13 83 ئ	# ئ [626 ]x

10 79,248,163,255,68,143,0,41,78,193 Common 84 10 84 *	# * [2a ]p
۴ 8 64,121,190,255,71,157,7,38,88,193 Arabic 85 2 85 ۴	# ۴ [6f4 ]0
{ 10 0,67,210,255,37,128,2,46,54,193 Common 86 10 34 {	# { [7b ]p
! 10 12,108,193,255,19,61,15,82,49,193 Common 87 10 87 !	# ! [21 ]p
9 8 14,100,204,255,65,212,6,29,78,249 Common 88 2 88 9	# 9 [39 ]0
٦ 8 55,124,181,255,57,232,0,50,81,270 Common 89 5 89 ٦	# ٦ [666 ]0
6 8 14,100,204,255,65,215,6,29,78,249 Common 90 2 90 6	# 6 [36 ]0
؛ 10 60,119,140,255,20,67,2,72,43,193 Common 91 13 91 ؛	# ؛ [61b ]p
۶ 8 60,121,183,255,52,128,7,41,88,193 Arabic 92 2 92 ۶	# ۶ [6f6 ]0
٥ 8 58,154,163,255,49,241,0,65,67,270 Common 93 5 93 ٥	# ٥ [665 ]0

0 39,111,184,255,76,218,3,38,99,262 Common 94 3 94 +	# + [2b ]

10 17,102,204,255,74,242,0,23,78,249 Common 95 4 95 #	# # [23 ]p
… 10 12,102,64,124,114,273,8,37,132,333 Common 96 10 96 ...	# … [2026 ]p
٬ 10 62,236,164,255,21,53,9,77,52,193 Arabic 97 5 97 ٬	# ٬ [66c ]p
\ 10 12,102,207,255,42,154,0,57,43,193 Common 98 10 98 \	# \ [5c ]p
" 10 139,254,204,255,42,128,9,55,64,193 Common 99 10 99 "	# " [22 ]p
& 10 12,100,192,255,83,266,4,27,121,299 Common 100 10 100 &	# & [26 ]p
٫ 10 15,98,97,167,33,103,6,61,52,193 Arabic 101 5 101 ٫	# ٫ [66b ]p
? 10 12,108,204,255,56,195,4,43,70,249 Common 102 10 102 ?	# ? [3f ]p
< 0 47,109,188,255,49,218,0,40,78,262 Common 103 10 107 <	# < [3c ]
_ 10 0,84,0,102,76,259,0,12,74,249 Common 104 10 104 _	# _ [5f ]p
| 0 0,88,207,255,6,64,12,82,31,193 Common 105 10 105 |	# | [7c ]
٪ 10 33,105,213,255,79,205,0,41,101,294 Arabic 106 4 106 ٪	# ٪ [66a ]p

0 47,109,188,255,49,222,3,33,78,262 Common 107 10 103 >	# > [3e ]

Thanks for your reply

combine_tessdata -u tessdata_best/fas.traineddata fas.
This will unpack the traineddata file.
Look at fas.lstm-unicharset
That probably has the ZWNJ in it.
You can add a few additional lines to the training text in langdata which have ZWNJ

How do I install the fas traineddata on macOS? Can someone provide the necessary commands to run?

@NightMachinery,
Please use our forum for asking questions.


feat: add new form section variants

When working with widgets it would be good if the form section grows to the same size as the widget:
Before:

After:

WDYT?

Can you try v1.7.0?


Add pbmr 400 benchmark files

Refs #12

Job VTB Documentation on 1cffc04 wanted to post the following:
View the site here
This comment will be updated on new commits.


False Positive for 'customElement: true'.

Before You File a Bug Report Please Confirm You Have Done The Following...

[X] I have tried restarting my IDE and the issue persists.
[X] I have updated to the latest version of the packages.

What version of ESLint are you using?
8.52.0
What version of eslint-plugin-svelte are you using?
2.34.0
What did you do?

Configuration
module.exports = {
	root: true,
	parser: '@typescript-eslint/parser',
	extends: ['eslint:recommended', 'plugin:@typescript-eslint/recommended', 'prettier', 'plugin:svelte/recommended'],
	plugins: ['@typescript-eslint'],
	ignorePatterns: ['*.cjs'],
	overrides: [
		{
			files: ['*.svelte'],
			parser: 'svelte-eslint-parser',
			parserOptions: {
				parser: '@typescript-eslint/parser'
			}
		}
	],
	parserOptions: {
		sourceType: 'module',
		ecmaVersion: 2020,
		project: './tsconfig.json',
		extraFileExtensions: ['.svelte']
	},
	env: {
		browser: true,
		es2017: true,
		node: true
	},
	rules: {
		'@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
		'@typescript-eslint/no-explicit-any': 'off',
		'no-prototype-builtins': 'off',
		// 'svelte/valid-compile':'off'
	},
	settings: {
		svelte: {
			compileOptions: {
				customElement: true
			}
		}
	}
};

<svelte:options tag="iron-remote-gui"/>

<script lang="ts">
    import {onMount} from 'svelte';
...
</script>
...

What did you expect to happen?
I expect eslint throw no error with run npx eslint src/**
What actually happened?
> npx eslint src/**

C:\Users\jou\code\IronRDP\web-client\iron-remote-gui\src\iron-remote-gui.svelte
  1:17  error  The 'tag' option is used when generating a custom element. Did you forget the 'customElement: true' compile option?(missing-custom-element-compile-options)  svelte/valid-compile

✖ 1 problem (1 error, 0 warnings)

Link to GitHub Repo with Minimal Reproducible Example
branch not published yet, will update when branch is pushed.
Additional comments
No response

This error is came from Svelte compiler, so I think this is not ESLint issue.
Can you try to compile your code with Svelte compilar and share the result?

I use vite build and it works well. Everything compiles.

here is my vite config
import { defineConfig } from 'vite'
import { svelte } from '@sveltejs/vite-plugin-svelte'
import wasm from "vite-plugin-wasm";
import topLevelAwait from "vite-plugin-top-level-await";
import dtsPlugin from "vite-plugin-dts";

// https://vitejs.dev/config/
export default defineConfig({
  build: {
    lib: {
      entry: './src/main.ts',
      name: 'IronRemoteGui',
      formats: ["umd", "es"],
    }
  },
  server: {
    fs: {
      strict: false
    }
  },
  plugins: [svelte({
    compilerOptions:{
      customElement:true
    }
  }), wasm(), topLevelAwait(), dtsPlugin()],
})

It should be fix in 2.34.1!


⚠ Processors has degraded performance

In 61f0cd0, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 134 ms

Resolved: Processors performance has improved in 3ee194f.


Comment out psycopg2 requirement

What does this PR do?
Comment out the explicit requirement for psycopg, same as the postgres check.
Motivation

Let's do the same things across different checks
Dependency should be handled in omnibus but right now psycopg is listed in the constraint file and the build fails if this and the version in omnibus don't match. This makes impossible to make experiments with updated packages omnibus side

Ummm... I'm not sure about this at the moment, we use the requirements file for validation of versions by the CI (ie. making sure package versions are aligned across different integrations and repos), if we start commenting out the packages for the integrations the sanity check will stop working. The omnibus side is failing by design, I think I would maybe rather add an ENV var on the omnibus side that would skip the creation/enforcement of the constraints file. What do you think?

The reason why the pgbouncer dependency was removed in the postgres check is that it was breaking the Windows agent build (and the postgres check can work with only pg8000). So I'm not sure about 1, I think we should add back as soon as possible the pgbouncer dependency in postgres/requirements.txt. Or get rid of all the */requirements.txt. But having them inconsistent is probably not a good idea.
I think */requirements.txt was an attempt at replacing omnibus definitions, but it's not fully transitioned and this might be the issue.

I'm using the constraint file to actually install the needed packages to avoid keeping this list in another place in the form of a set of omnibus software definitions, so I'd say nope. Will figure out something else agent side.

I think we should have a way to differentiate between ones that are installed by omnibus and ones that aren't. However, we need to keep them somewhere. For instance, with this one, we'd need to ensure that the CI still has it installed for the tests and we'd need to ensure that we could do a source install.
I have no good solution for this, other than developing some tool to wrap pip installs so that they can be done via a json or toml file, or, perhaps, having different requirements files for different things.


Cleanups

Fixes go vet warnings in api/client/lib/... about not using keys in struct literals
Cleanup pkg/authorization to be more consistent with whole code in docker repo
Reorder imports with goimports (OCD)

LGTM

LGTM


Check ports in TrackingServer app

in v0.9.8, Layers app is not getting connection to tracking server --> mayber due to port / protocol issues ?

issue was related to missing address property when request to start broadcast --> fixed in layers app


Componentize the examples page

Describe the bug
There are some duplicate styles applied to example page wrapper
What is the expected behavior?
Componentize the example wrapper to use the duplicate styles
What are the steps to reproduce?

yarn start:reactdev

Screenshots or links to minimum reproduction example
Environment

Anything else to add?
https://github.com/brightlayer-ui/react-component-library/pull/502#issuecomment-1239672805

Link this issue to cleanup story.

Created as BLUI-3508

I checked it. This has already been fixed. @daileytj Can you please re-verify?


fixed the bug when 1st character is not a alphabet.

Closes: #1
Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[x] Tests pass
[x] Appropriate changes to README are included in PR

@googlebot I signed it!


BUG: trying to downcast (Int32 | UInt8) <- Int32 (Exception)

I skimmed through the similarly titled issues but didn't see any that stood out, apologies if this a duplicate.
Crystal Version (On Manjaro (GNOME))
$ crystal -v
Crystal 0.31.1 (2019-10-21)

LLVM: 9.0.0
Default target: x86_64-pc-linux-gnu

Crystal Version (On Debian 9.11)
$ crystal -v
Crystal 0.32.1 [41bd18fbe] (2019-12-18)

LLVM: 8.0.0
Default target: x86_64-unknown-linux-gnu

Code Sample
module Gosu
  class Color
    def self.from_ahsv(alpha : UInt8 | Int32, hue : Float64, saturation : Float64, value : Float64) : Gosu::Color
      Gosu::Color.new(0xff_ffffff)
    end

    def initialize(color : UInt32)
      @color = color
    end
  end
end

# Crashes
Gosu::Color.from_ahsv(255, 60, 1.0, 1.0)

# Doesn't Crash
Gosu::Color.from_ahsv(255.to_u8, 60, 1.0, 1.0)
Gosu::Color.from_ahsv(255.to_i, 60, 1.0, 1.0)

Bug
BUG: trying to downcast (Int32 | UInt8) <- Int32 (Exception)
Unhandled exception: Error opening file 'crystal' with mode 'r': No such file or directory (Errno)
Failed to raise an exception: END_OF_STACK
[0x5638a6fd62d6] ???
[0x5638a665ce4b] __crystal_raise +43
[0x5638a665e665] ???
[0x5638a666a92b] ???
[0x5638a6663bec] ???
[0x5638a6663226] ???
[0x5638a69c16ea] ???
[0x5638a66761a7] ???
[0x5638a6660dc7] main +55
[0x7f844c49d153] __libc_start_main +243
[0x5638a665b55e] _start +46
[0x0] ???

Reduced:
def foo(x : Int8 | Int32, y : Int16)
end

foo(1, 2)

While the error seems to be some issue with autocasting the first argument, it only appears when there is a second autocasted argument (it can even be an enum).

And Int32 must be included in the type union:
def foo(x : Int8 | Int16, y : Int16)
end

foo(1, 2) # Error: ambiguous call, implicit cast of 1 matches all of Int8, Int16

??? = ?


Setup.sh upgrades packages without user permission

As the title says, when I run upgrade.sh it upgrades packages on my system without my permission by running apt-get upgrade. A script should not upgrade my packages without my permission because upgrade packages can, in cases where packages are not held back correctly, break software.
If a specific version of a package is required, it should be specified in the apt-get install as apt-get install package=version.

This is a very reasonable complaint. I'm not going to change the setup system at this point, but we will consider this after competition.


Error Handling Improvements

In gitlab by @NFarrington on Jan 15, 2016, 11:45
When an error is thrown, log the following:

If Auth::check() is true, the CID of the user
The request path (e.g. /mship/manage/dashboard)

In gitlab by @NFarrington on Jan 15, 2016, 19:48
mentioned in commit 5e7d5386f9a3d444360d6ae4267fbbd187460f5d


tar assembler: include SELinux, ACLs and extended attributes

All of those are opt-in for tar, so lets opt in. Only open question is, if it should also be opt-in for the assembler itself. The current code assumes that if you have a tree with any of those properties (selinux, acls, extended attributes), you would want them preserved. Of course that might break on systems/build-roots that have a tar that does not understand any of those options.
Closes #570

I checked via Ubuntu VM that adding --selinux will not result in an error on non-SELinux systems; since it does I made the options all opt-out instead of opt-in to try to preserve as much of the original tree as possible.

I checked via Ubuntu VM that adding --selinux will not result in an error on non-SELinux systems; since it does I made the options all opt-out instead of opt-in to try to preserve as much of the original tree as possible.


tests: pull images from cloud.centos.org

temporary work around vagrant cloud issue which seems broken at the time
of pushing this commit.
Let's pull images from cloud.centos.org for now since vagrant cloud
hosted images return a 403 error.
Signed-off-by: Guillaume Abrioux<EMAIL_ADDRESS>

jenkins test centos-container-lvm_osds

jenkins test centos-non_container-lvm_osds


Teleportation using the ::tele command

Lets you do ::tele [location name] to jump there.
It's my first time using Kotlin. Please let me know any stylistic concerns you may have.

offtopic:
Is that the client from my repo?, did i seriously forget to remove my name from default :O


feat: Add ability to forcefully update nodes in managed node groups

PR o'clock
Description
Allow to set force_update_version flag to managed node groups
Checklist

[ ] CI tests are passing
[ ] README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

Thanks @xr0n1ck for your contribution.


Create a Load Balancer

After adding the node group to the EKS cluster, we might need to expose it using a ELB.
https://docs.aws.amazon.com/eks/latest/APIReference/API_CreateCluster.html

The cluster control plane is provisioned across multiple Availability Zones and fronted by an Elastic Load Balancing Network Load Balancer.

This might indicate that we don't actually need to create a new ELB

The LoadBalancer is created automatically by AWS, once the service with the type=loadbalancer is created in the EKS cluster.


Standard library incompatibilities - os.makedirs

python 3 has a keyword option exist_ok
which doesn't exist on python2
i think this should go on this page
http://python-future.org/stdlib_incompatibilities.html

+1


set_device_value throws warning and is not executed in automations or scripts. Works fine when just manually started.

I agree to the following

[X] I have read the documentation right now
[X] I have read the FAQs right now
[X] I am aware of the latest release notes
[X] The Backend (CCU/Homegear/...) is working as expected and connected devices are controllable by its own UI.
[X] I am running the latest version of the custom_component (and Home Assistant)

The problem
Hi there,
i am trying to change the display of an ePaper Wallswitch (WRCD) with the homematicip_local integration.
I found that this is possible via set_device_value, channel 3, COMBINED_PARAMETER, etc. which basically is exactly the same way/command i used in iobroker for the last 5 years :)
Happily this directly worked with the integration as well, when i am editing an automation or script and test to fire the service... My Display instantly updates properly.
If i now want it to be triggered as part of an automation the display won't update... instead i get following log entry:
WARNING (MainThread) [hahomematic.client] SET_VALUE failed with TypeError
What is the difference of just testing the exact same service and putting it in an automation/script.
(Its quite weird if you hit the run-button for the service (within a script) it works, and if you hit the run-button for the whole script containing ONLY this service it fails with this warning?!?)
Thanks for any support. Happy to provide more info as required!
What version of HomematicIP (local) has the issue?
1.52.0
What was the last working version of HomematicIP (local)?
No response
What type of installation are you running?
Home Assistant Core
What type of installation are you running for your homematic backend?
CCU3
Which version of your homematic backend are you running?
3.73.9
What hardware are you running for your system?
NUC/i5
Which config details do you use

[X] Username and password
[ ] TLS
[ ] callback data (see)

Which interfaces do you use?

[X] Homematic IP
[ ] Homematic (Bidcos-RF)
[ ] Groups (Heating-Group)
[ ] BidCos-Wired (HM-Wired)

Diagnostics information
2023-12-25 12:55:29.686 WARNING (MainThread) [hahomematic.client] SET_VALUE failed with TypeError [cannot marshal <class 'homeassistant.util.yaml.objects.NodeStrClass'> objects]: 002A60C9950C18:3, COMBINED_PARAMETER, {DDBC=WHITE,DDTC=BLACK,DDI=0,DDA=CENTER,DDS=,DDID=2},{DDBC=WHITE,DDTC=BLACK,DDI=6,DDA=CENTER,DDS=,DDID=4,DDC=true},{R=0,IN=5,ANS=4}
Anything in the logs that might be useful for us? The log (full log) is the best source to support trouble shooting!
No response
Additional information
No response

Please attach the corresponding YAML code.

I think it's a better approach to go on in this diskussion.
Basically sending commands to WRCD works for me, so i think there is no issue with the integration.
From an integrations perspective there is no difference between script, automation and manual execution. That is HA core stuff and not part of this integration.

Set the value type to string and it should work.

Hi SukramJ,
don't close it too fast, before i can say thank you!!!
Value type to string made it work. So your hint made my day!
(in the linked discussion i can see the value type is not set, i had indeed used this one as a template and was happy its the same approach as i did with my other systems...)


crash while saving image

What steps will reproduce the problem?
saving images grabber crashes and not responding.
What is the expected behavior? What do you get instead?
save an image from preview window and does not save and crashes.
How often does this problem occur?
everytime
What version of the program are you using? On what operating system?
5.4.2 on win 10
Please provide any additional information below

Which source and image did this happen on?
What was your filename?
Could you also share your log file of right after such a crash?


Improved Documentation

It would be really helpful to document the environment variables that the scaler uses so that it's easier to understand the tuning options without digging into the code.

Thanks for raising this @baderbuddy, we'll look at improving the documentation. Was there anything in particular you found that was confusing or ambiguous?


test-branch/execute-job/quoted-authorization/682d2d82-8cba-4f49-bd2f-90fb5187f6b1

PR for testing e6698a4fd876d27b5b4ac515c6221476ee900551

/canonical/self-hosted-runners/run-workflows e6698a4fd876d27b5b4ac515c6221476ee900551


What are APIs?

Purpose
There exists a slide deck that explains what APIs are.
What should the slide deck contain?

How do APIs work?
How can I find APIs?
Why are APIs  #necessary?
Examples of APIs
Using SDKs

@jlevine272 AWESOME JOB! I had a few comments/technical nitpicks. Seriously great work, I loved the exercise. I thought this was super well-done. Can you ping me with your comments/let me know if I should re-review?


Adding missing fields on Address model type for Here API

I've begun using this package, however as I got into the weeds with my implementation I noticed some missing properties on the Here Geocoding API model types. As luck would have it... I need one of these fields... Specifically "stateCode"
I've reviewed and added missing fields on the "Address" model type, but have not reviewed the remainder of the API.
The documentation I referenced is:
https://developer.here.com/documentation/geocoding-search-api/api-reference-swagger.html

Thank you for contributing! It seems like the build failed in the MapQuest test cases. I am going to take a look and see what is going on. It seems like it could be a concurrency issue.

Re-running it seems to have worked. I will need to figure out what I can do for that. In the meantime, this PR looks good to me. I will merge this and have an alpha build you can try out.

1.5.0-alpha.1 is released.


Upgrade to use v<IP_ADDRESS> SDK

This PR might resolve #19
Testing
I have tested the matter-pi-gpio-commander snap built from this PR locally, with the chip-tool snap built from this PR, and they both work as expected using the same version of Matter SDK v<IP_ADDRESS>. The matter-pi-gpio-commander snap could be commissioned and controlled by chip-tool snap.
build:
snapcraft -v --debug

install and setup matter-pi-gpio-commander:
sudo snap install ./matter-pi-gpio-commander_0.3.0_arm64.snap --dangerous
sudo snap set matter-pi-gpio-commander gpio=26

sudo snap connect matter-pi-gpio-commander:avahi-control
sudo snap connect matter-pi-gpio-commander:gpio-memory-control
sudo snap start matter-pi-gpio-commander

install and setup chip-tool:
sudo snap install ./chip-tool_v<IP_ADDRESS>+snap_arm64.snap --dangerous
sudo snap connect chip-tool:avahi-observe
sudo snap connect chip-tool:bluez

commison and control:
sudo chip-tool pairing onnetwork<PHONE_NUMBER>1
sudo chip-tool onoff toggle 110 1

Upon successful execution, the LED on the Pi should be controlled by Chip Tool, turning it on or off.

Remote build fails for arm64:
:: + [[ arm64 == \a\r\m\6\4 ]]
:: + ZAP_VERSION=v2023.05.04
:: + set -x
:: + mkdir -p /opt/zap-v2023.05.04
:: + git clone https://github.com/project-chip/zap.git /opt/zap-v2023.05.04
:: Cloning into '/opt/zap-v2023.05.04'...
:: + cd /opt/zap-v2023.05.04
:: + git checkout -b v2023.05.04
:: Switched to a new branch 'v2023.05.04'
:: + npm ci
:: npm WARN tarball tarball data for<EMAIL_ADDRESS>(sha512-ql93vEUq6WsstGXD+SBLSIQw6SNnhbDEM0swzgugytMxLp3rT24Ag/jcC80ZHxiPRTdew1niuR7P3/FCrDqIjw==) seems to be corrupted. Trying one more time.
:: npm WARN lifecycle The node binary used for scripts is /snap/bin/node but npm is using /snap/node/6202/bin/node itself. Use the `--scripts-prepend-node-path` option to include the path for the node binary npm was executed with.
::
:: ><EMAIL_ADDRESS>install /opt/zap-v2023.05.04/node_modules/utf-8-validate
:: > node-gyp-build
::
:: make: Entering directory '/opt/zap-v2023.05.04/node_modules/utf-8-validate/build'
::   CC(target) Release/obj.target/validation/src/validation.o
::   SOLINK_MODULE(target) Release/obj.target/validation.node
::   COPY Release/validation.node
:: make: Leaving directory '/opt/zap-v2023.05.04/node_modules/utf-8-validate/build'
::
:: ><EMAIL_ADDRESS>install /opt/zap-v2023.05.04/node_modules/sqlite3
:: > node-pre-gyp install --fallback-to-build
::
:: [sqlite3] Success: "/opt/zap-v2023.05.04/node_modules/sqlite3/lib/binding/napi-v6-linux-glibc-arm64/node_sqlite3.node" is installed via remote
::
:: ><EMAIL_ADDRESS>postinstall /opt/zap-v2023.05.04/node_modules/core-js
:: > node -e "try{require('./postinstall')}catch(e){}"
::
[16/Jun/2023:09:36:48 +0000] "CONNECT github.com:443 HTTP/1.1" 200 3772 "-" "-"
:: Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!
::
:: The project needs your help! Please consider supporting of core-js:
:: > https://opencollective.com/core-js
:: > https://patreon.com/zloirock
:: > bitcoin: bc1qlea7544qtsmj2rayg0lthvza9fau63ux0fstcz
::
:: Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)
::
::
:: ><EMAIL_ADDRESS>install /opt/zap-v2023.05.04/node_modules/canvas
:: > node-pre-gyp install --fallback-to-build --update-binary
::
:: node-pre-gyp ERR! install response status 404 Not Found on https://github.com/Automattic/node-canvas/releases/download/v2.11.2/canvas-v2.11.2-node-v72-linux-glibc-arm64.tar.gz
:: node-pre-gyp WARN Pre-built binaries not installable for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v72 ABI, glibc) (falling back to source compile with node-gyp)
:: node-pre-gyp WARN Hit error response status 404 Not Found on https://github.com/Automattic/node-canvas/releases/download/v2.11.2/canvas-v2.11.2-node-v72-linux-glibc-arm64.tar.gz
:: Package pangocairo was not found in the pkg-config search path.
:: Perhaps you should add the directory containing `pangocairo.pc'
:: to the PKG_CONFIG_PATH environment variable
:: No package 'pangocairo' found
:: gyp: Call to 'pkg-config pangocairo --libs' returned exit status 1 while in binding.gyp. while trying to load binding.gyp
:: gyp ERR! configure error
:: gyp ERR! stack Error: `gyp` failed with exit code: 1
:: gyp ERR! stack     at ChildProcess.onCpExit (/snap/node/6202/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:351:16)
:: gyp ERR! stack     at ChildProcess.emit (events.js:314:20)
:: gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:276:12)
:: gyp ERR! System Linux 5.4.0-149-generic
:: gyp ERR! command "/snap/node/6202/bin/node" "/snap/node/6202/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "configure" "--fallback-to-build" "--update-binary" "--module=/opt/zap-v2023.05.04/node_modules/canvas/build/Release/canvas.node" "--module_name=canvas" "--module_path=/opt/zap-v2023.05.04/node_modules/canvas/build/Release" "--napi_version=8" "--node_abi_napi=napi" "--napi_build_version=0" "--node_napi_label=node-v72"
:: gyp ERR! cwd /opt/zap-v2023.05.04/node_modules/canvas
:: gyp ERR! node -v v12.22.12
:: gyp ERR! node-gyp -v v5.1.0
:: gyp ERR! not ok
:: node-pre-gyp ERR! build error
:: node-pre-gyp ERR! stack Error: Failed to execute '/snap/node/6202/bin/node /snap/node/6202/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js configure --fallback-to-build --update-binary --module=/opt/zap-v2023.05.04/node_modules/canvas/build/Release/canvas.node --module_name=canvas --module_path=/opt/zap-v2023.05.04/node_modules/canvas/build/Release --napi_version=8 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v72' (1)
:: node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (/opt/zap-v2023.05.04/node_modules/@mapbox/node-pre-gyp/lib/util/compile.js:89:23)
:: node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:314:20)
:: node-pre-gyp ERR! stack     at maybeClose (internal/child_process.js:1022:16)
:: node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:287:5)
:: node-pre-gyp ERR! System Linux 5.4.0-149-generic
:: node-pre-gyp ERR! command "/snap/node/6202/bin/node" "/opt/zap-v2023.05.04/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build" "--update-binary"
:: node-pre-gyp ERR! cwd /opt/zap-v2023.05.04/node_modules/canvas
:: node-pre-gyp ERR! node -v v12.22.12
:: node-pre-gyp ERR! node-pre-gyp -v v1.0.10
:: node-pre-gyp ERR! not ok
:: Failed to execute '/snap/node/6202/bin/node /snap/node/6202/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js configure --fallback-to-build --update-binary --module=/opt/zap-v2023.05.04/node_modules/canvas/build/Release/canvas.node --module_name=canvas --module_path=/opt/zap-v2023.05.04/node_modules/canvas/build/Release --napi_version=8 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v72' (1)
:: npm ERR! code ELIFECYCLE
:: npm ERR! errno 1
:: npm ERR<EMAIL_ADDRESS>install: `node-pre-gyp install --fallback-to-build --update-binary`
:: npm ERR! Exit status 1
:: npm ERR!
:: npm ERR! Failed at the<EMAIL_ADDRESS>install script.
:: npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
::
:: npm ERR! A complete log of this run can be found in:
:: npm ERR!     /root/.npm/_logs/2023-06-16T09_36_50_920Z-debug.log
'override-build' in part 'lighting' failed with code 1.

The changes on separate parts have been reverted due to building failure on arm64. Node.js and Zap installations need to be separated into a standalone part for better caching and clarity. I have created an issue for this purpose, which can be found https://github.com/canonical/matter-pi-gpio-commander/issues/21.


064 d freeze txn use instant

Description:
This PR deprecates freeze transaction body's startHour, startMin, endHour, and endMin. It also introduce a new field startTime of Timestamp (Instant) to specify when freeze should start.
Related issue(s):
Fixes #64
Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Actually can we open this against develop first? Sorry. 😞


how to use stream response?

i having problem with that
return (new OpenAIChat($config))->generateStreamOfText('good morning');

but it runs fine when I use openai library directly
$stream = $chat->chat()->createStreamed([             'model' => 'gpt-3.5-turbo',             'messages' => [                 ['role' => 'user', 'content' => 'good morning'],             ],         ]);
foreach ($stream as $response) {             echo json_encode($response);         }

Hey @daunt, which version of LLPhant do you use?

Hey @daunt, which version of LLPhant do you use?

last version of repo

i changed the code a little and it worked

OK. @ezimuel it seems the change you did for streaming did not work or maybe there is something more to do to make it work?

We need to reproduce the issue with a test. I'll work on it.

Thank you for attention..
by the way, can I contribute to add TEI by HF or can you provide it too?
source : TEI

@daunt You are more than welcome to contribute with a TEIChat and TEIConfig implementation. We will help you on that of course.

Starting from ver. 0.6.0 we changed the return of the generateStreamOfText() function. Now it returns a PSR-7 StreamInterface object that doesn't implement the Iterator feature, that means you cannot foreach. You can retrieve the result with the getContents() method as follows:
$chat = new OpenAIChat($config);
$result = $chat->generateStreamOfText('good morning');
echo $result->getContents(); // Good morning! How can I assist you today?


Methods on Entity should be const

These methods are useful for tests, but are not const.
This makes it harder to create dummy entities to use to populate data structures.

This seems to be a duplicate of #5687, which was resolved in #5688, but Entity::to_bits was the only remaining method that wasn't changed to be const.


Expanding the arguments for effects toggle macro

Is your feature request related to a problem? Please describe.
Using name argument is useful, but when targeting unlinked tokens the effect will be toggled on all tokens with the same name on the canvas.
Describe the solution you'd like
Make use of something like tokenId for targeting specific tokens only via macros.
This will also make it easier to add and remove convenient effects, when using a combination of Midi-QOL, DAE, Item Macro and DFreds Convenient Effects.
A small example for a Haste spell with a convenient effect.
Create a DAE on the spell to execute a macro.itemMacro
Item Macro
const lastArg = args[args.length - 1];
let tactor;
if (lastArg.tokenId) tactor = canvas.tokens.get(lastArg.tokenId).actor;
else tactor = game.actors.get(lastArg.actorId);

const target = canvas.tokens.get(lastArg.tokenId);
const targetId = target.data._id;

const ef1 = game.dfreds.effects._haste.name

if (args[0] === "on") {
game.dfreds.effectHandler.toggleEffect(`${ef1}`,`${targetId}`);
}

if (args[0] === "off") {
game.dfreds.effectHandler.toggleEffect(`${ef1}`, ${targetId}`);
}

Fixed in v1.6.1 as far as I understand how your use case works. You can now pass in token IDs instead of names and it should apply to them. Please reopen if it doesn't meet your needs


chore: Add toolbar example

Adds a "toolbar" example https://github.com/reakit/reakit/issues/939.
Toolbar

Toolbar with menu

e-2f496bddc296.png">

hey @diegohaz  is this how you were thinking?

Let's work on a single example per PR. You can open another PR for the toolbar-menu example later.


fix(webui): search pings proxy #385

Type:
The following has been addressed in the PR:

Issue: search pings proxy #385

@juanpicado I have made the requested changes.

I'm afraid this instead of fixing the problem just hide the issue itself.  Refer:  #915

@ashishsurana I want to give you some context.
From #385

it would only be local search because the only data that appears on this UI is only ever local

The UI hits the search endpoint and therefore the storage.
src/api/web/endpoint/search.js

 storage.getPackage({
        name: results[i].ref,
        callback: (err, entry) => {
          if (!err && entry) {

if you dive into that method
  /**
   Retrieve a package metadata for {name} package
   Function invokes localStorage.getPackage and uplink.get_package for every
   uplink with proxy_access rights against {name} and combines results
   into one json object
   Used storages: local && uplink (proxy_access)

   * @param {object} options
   * @property {string} options.name Package Name
   * @property {object}  options.req Express `req` object
   * @property {boolean} options.keepUpLinkData keep up link info in package meta, last update, etc.
   * @property {function} options.callback Callback for receive data
   */
  getPackage(options: any) {
    this.localStorage.getPackageMetadata(options.name, (err, data) => {
      if (err && (!err.status || err.status >= HTTP_STATUS.INTERNAL_ERROR)) {
        // report internal errors right away
        return options.callback(err);
      }

      this._syncUplinksMetadata(options.name, data, {req: options.req},
        function getPackageSynUpLinksCallback(err, result: Package, uplinkErrors) {
          if (err) {
            return options.callback(err);
          }

          normalizeDistTags(cleanUpLinksRef(options.keepUpLinkData, result));

          // npm can throw if this field doesn't exist
          result._attachments = {};

          options.callback(null, result, uplinkErrors);
        });
    });
  }

you will notice the method _syncUplinksMetadata which is the one that ask for the uplinks for updates, that's what #385 is trying to avoid.
Your solution avoids hits the search endpoint and I'm not sure is what we want to achieve here. The problem will remain there anyway.

@juanpicado What can be the solution here? Maybe we can stop pining proxy. ?

Yes, some sort of parameter to avoid hit the uplink, this include update unit testing and functional testing. Big job.

@ashishsurana fyi check https://github.com/verdaccio/verdaccio/pull/1126 that was the root of the issue.


fix for update product command return value

The UpdateProductCommandHandler returns a Unit. In my code the IRequest need to specify this return value.

Thanks for the fix, however I can see that IRequest implements IRequest so I am not sure why this fix is required.
https://github.com/jbogard/MediatR/blob/master/src/MediatR/IRequest.cs
Are you getting an error or some kind of issue?

I've added an example for UpdateCustomerCommand. In this case I have the command and handler nested together, with the command implementing IRequest. The relevant functional tests seem to pass. Let me know if you experience different behaviour.

You are right, I used int as return type instead of Uintand got the following compiler error:
The type '....Command' cannot be used as type parameter 'TRequest' in the generic type or method 'IRequestHandler<TRequest, TResponse>'. There is no implicit reference conversion from '.....Command' to 'MediatR.IRequest<int>'.


Fix macOS Sonoma Beta 2 menubar hang/crash

This fixes the hang and crash that occurs since macOS Sonoma Beta 2. (https://github.com/p0deje/Maccy/issues/566)
Maccy used to hide the "Maccy" title and search bar within the menu by setting the height of the NSView to a small value.
In Beta 2, modifying the frame in any way results in a crash.
While this is likely an OS bug, since setting the height to 1 is a hack anyway, and the header only contains the title and search bar, not adding the header when both are disabled seems like a cleaner solution to me.

Does search still work fine with this patch when hideSearch is enabled?

Does search still work fine with this patch when hideSearch is enabled?

Am I supposed to be able to search just by summoning the app and typing, without focusing the search field first?
While I've been using Maccy, I haven't been needing the search feature, so I don't know if this worked prior to my change.
In both scenarios (search field on/off), I can't just type when I summon Maccy, through either the menubar, nor the shortcut.
Instead, it selects the item that starts with that letter.

This breaks searching when the search field is hidden. Perhaps unlinking the searching functionality from the queryField itself would be beneficial.
Closing this, as the solution is incorrect.

Does search still work fine with this patch when hideSearch is enabled?

Logically, it unfortunately does not in that scenario :(
However: it actually does not work even if the search field is enabled. The panel selects the item that starts with the letter being pressed.
I can see that processSingleCharacter() is called by processKeyDownEvent() whenever a character is pressed, suggesting that all input should be forwarded to the queryField search field control.
For whatever reason, this does not get called on macOS Sonoma Beta 2 in my case for some reason.


feat: updated v2/stored_flows cookie_range to accept an even list of ranges

Closes #165
Summary
See updated changelog file
Local Tests
Query latency reasonable as expected on APM:

Also, sent a few requests exploring the parameters, worked as expected:
❯ http 'http://<IP_ADDRESS>:8181/api/kytos/flow_manager/v2/stored_flows?cookie_range=1&cookie_range=2&cookie_range=10&cookie_range=13'
HTTP/1.1 200 OK
content-length: 2489
content-type: application/json
date: Tue, 08 Aug 2023 19:25:46 GMT
server: uvicorn

{
    "00:00:00:00:00:00:00:01": [
        {
            "flow": {
                "actions": [
                    {
                        "action_type": "output",
                        "port": 2
                    }
                ],
                "cookie": 13,
                "hard_timeout": 0,
                "idle_timeout": 0,
                "match": {
                    "dl_vlan": 13,
                    "in_port": 1
                },
                "priority": 13,
                "table_group": "base",
                "table_id": 0
            },
            "flow_id": "5b0cf6c243d8f318051d758a9acfd4db",
            "id": "f5de0eb1c875b49837ecd58b687c72c9",
            "inserted_at": "2023-08-08T19:23:35.052000",
            "state": "installed",
            "switch": "00:00:00:00:00:00:00:01",
            "updated_at": "2023-08-08T19:23:35.313000"
        },
        {
            "flow": {
                "actions": [
                    {
                        "action_type": "output",
                        "port": 2
                    }
                ],
                "cookie": 12,
                "hard_timeout": 0,
                "idle_timeout": 0,
                "match": {
                    "dl_vlan": 12,
                    "in_port": 1
                },
                "priority": 12,
                "table_group": "base",
                "table_id": 0
            },
            "flow_id": "fc605f52cf93d656a6c9c23854b82c69",
            "id": "07531808aae42b73cd2cbd7fb616038e",
            "inserted_at": "2023-08-08T19:23:35.052000",
            "state": "installed",
            "switch": "00:00:00:00:00:00:00:01",
            "updated_at": "2023-08-08T19:23:35.313000"
        },
        {
            "flow": {
                "actions": [
                    {
                        "action_type": "output",
                        "port": 2
                    }
                ],
                "cookie": 11,
                "hard_timeout": 0,
                "idle_timeout": 0,
                "match": {
                    "dl_vlan": 11,
                    "in_port": 1
                },
                "priority": 11,
                "table_group": "base",
                "table_id": 0
            },
            "flow_id": "1c0d0d75c622942bc9bcca335bf885e8",
            "id": "fe8e967ef16708cc2beebd18182a5a36",
            "inserted_at": "2023-08-08T19:23:35.052000",
            "state": "installed",
            "switch": "00:00:00:00:00:00:00:01",
            "updated_at": "2023-08-08T19:23:35.313000"
        },
        {
            "flow": {
                "actions": [
                    {
                        "action_type": "output",
                        "port": 2
                    }
                ],
                "cookie": 10,
                "hard_timeout": 0,
                "idle_timeout": 0,
                "match": {
                    "dl_vlan": 10,
                    "in_port": 1
                },
                "priority": 10,
                "table_group": "base",
                "table_id": 0
            },
            "flow_id": "b49ff1fb9d3ce1a31982741358bf5461",
            "id": "4d8734bc8cf5b9153be761f471d63451",
            "inserted_at": "2023-08-08T19:23:35.052000",
            "state": "installed",
            "switch": "00:00:00:00:00:00:00:01",
            "updated_at": "2023-08-08T19:23:35.313000"
        },
        {
            "flow": {
                "actions": [
                    {
                        "action_type": "output",
                        "port": 2
                    }
                ],
                "cookie": 2,
                "hard_timeout": 0,
                "idle_timeout": 0,
                "match": {
                    "dl_vlan": 2,
                    "in_port": 1
                },
                "priority": 2,
                "table_group": "base",
                "table_id": 0
            },
            "flow_id": "268dc268be7e02ed144e18b91e12a274",
            "id": "7a21877fcd5da593936a41de44b9e330",
            "inserted_at": "2023-08-08T19:23:35.052000",
            "state": "installed",
            "switch": "00:00:00:00:00:00:00:01",
            "updated_at": "2023-08-08T19:23:35.313000"
        },
        {
            "flow": {
                "actions": [
                    {
                        "action_type": "output",
                        "port": 2
                    }
                ],
                "cookie": 1,
                "hard_timeout": 0,
                "idle_timeout": 0,
                "match": {
                    "dl_vlan": 1,
                    "in_port": 1
                },
                "priority": 1,
                "table_group": "base",
                "table_id": 0
            },
            "flow_id": "0869ef60ff80f1004a50d9f9ac0e3907",
            "id": "fd1509d23c9a43fb9e7151094a0b97f4",
            "inserted_at": "2023-08-08T19:23:35.052000",
            "state": "installed",
            "switch": "00:00:00:00:00:00:00:01",
            "updated_at": "2023-08-08T19:23:35.313000"
        }
    ]
}

End-to-End Tests
I'll dispatch an execution, I don't expect surprises though

I'll go ahead and merge this, it's needed for telemetry_int


Relative markdown links between blog and docs does not work

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[X] I have tried the npm run clear or yarn clear command.
[X] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[X] I have tried creating a repro with https://new.docusaurus.io.
[X] I have read the console error message carefully (if applicable).

Description
Hi Docusaurus team,
Love this library - thank you for your awesome work!
I'm looking to link a blog post to a docs page using a relative markdown link, but I receive the following error when I specify [link to doc](../../docs/doc-page.md) in the blog post:
[WARNING] Blog markdown link couldn't be resolved: (../../docs/doc-page.md) in "/home/projects/github-dc5ygn/blog/blog-post.md
On the other hand, using link without the .md ([link to doc](../../docs/doc-page)) extension works fine.
Is there a way I can prevent the broken link while preserving the .md extension? I'm using an Obsidian plugin to convert wikilinks to internal links and need to keep the .md extension for it to work properly.
Reproducible demo
https://stackblitz.com/edit/facebook-docusaurus-mx3fkh?file=blog%2Fblog-post.md
Steps to reproduce

Go to demo linked above.
Wait for the site to compile. You should see a warning: [WARNING] Docs markdown link couldn't be resolved: (../../docs/doc-page.md) in "/home/projects/facebook-docusaurus-mx3fkh/docs/doc-page.md" for version current
In the website preview on the right, click the menu button (three bars).
Click Blog.
Under the "blog-post" title click "link to doc".
You should see a "Page Not Found" error.
Edit "blog-post.md" to exclude ".md" from the link: [link to doc](../../docs/doc-page)
Complete steps 2-5. Link should now work correctly.

Expected behavior
The link [link to doc](../../docs/doc-page) should work regardless of whether or not .md is specified.
Actual behavior
The link [link to doc](../../docs/doc-page) only works when .md is omitted.
Your environment

Public source code: See demo link above
Public site URL: See demo link above
Docusaurus version used: 2.4.1
Environment name and version (e.g. Chrome 89, Node.js 16.4): Node.js 16.20.0
Operating system and version (e.g. Ubuntu 20.04.2 LTS): N/A

Self-service

[ ] I'd be willing to fix this bug myself.

Yes, it does not work, because currently the relative link resolution is a plugin-specific feature and not a Docusaurus core feature.
I'd like to support cross-plugin relative links but it would require the core engine to somehow maintain a "file path -> URL path" mapping, and we probably need additional plugin lifecycle hooks for that.
Note: if you use Docs versioning, once your docs get versioned, the docs copy will be at a different location and it might break your relative links that are not linking to the same current version (I mean: a relative link from v1.3 to v1.3 won't break, but a v1.3 relative link to a blog post might break when the doc is moved from ./docs to ./versioned_docs/1.3).

Hi @slorber,
Thanks for confirming! I now see this is noted here.
Good to know regarding doc versioning. Fortunately, I do not have a need for versioned docs at this time.

سوف يتم تصحيح الأخطاء في أسرع وقت


Url not available on Link UmbNavItem

Which exact Umbraco version are you using? For example: 8.7.0 - don't just write v8 or v9
9.4.3
Bug summary
Url not available on Link UmbNavItem. When using the Link navigation item type the url is not available.
Specifics
No response
Steps to reproduce
Set up a doc with umbnav
Set up a Link item type with a url and no anchor set
Retrieve the UmbNavItem from the Published Property
Url is not available
Expected result / actual result
Url is available.

@nzdev Can you confirm which version of UmbNav you are using?

@nzdev, I was having a similar problem but I had not added @using UmbNav.Core.Extensions into my view, as soon as I did item.Url() worked like a charm

Thanks @onionstar ! Looks like that should work. I'll give it a go tomorrow.

@nzdev Was this solved?

I believe so. Thanks.


Adds more env vars for setting the numbers/copy in the site

This is iPhone.artsy.net - check out that package.json

Minor thing, then 👍


#4182, ignore showLike context in show columns

Fixes #4182.

Codecov Report

Merging #4217 into 4.0.1 will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              4.0.1    #4217   +/-   ##
=========================================
  Coverage     63.39%   63.39%
  Complexity      876      876
=========================================
  Files          1053     1053
  Lines         16971    16971
  Branches       2736     2736
=========================================
  Hits          10758    10758
  Misses         5611     5611
  Partials        602      602

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7065af6...9eff5f2. Read the comment docs.

Pull Request Test Coverage Report for Build 9409

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.523%

Totals

Change from base Build 9381:
0.0%

Covered Lines:
11296

Relevant Lines:
16729

💛  - Coveralls


Build process with Gulp stops after a few files are created

Hello community,
I am on Mac and all necessary modules are installed for the Gulp Build. When I started the build process with gulp build-css, the process just stops after a few files are created.

Does anyone know a solution for this problem?

Could you check if it is also happening when using https://github.com/fomantic/Fomantic-UI?


When do you release the code?

Really impressive with your paper. When you will release the code?

Hi @kaitorecca,
Thanks for your interest in our work. We are currently cleaning up the code and applying for its public release to the company. We plan to release the code in June.

Hi @kaitorecca, Thanks for your interest in our work. We are currently cleaning up the code and applying for its public release to the company. We plan to release the code in June.

When do you release the code

Hi @kaitorecca, Thanks for your interest in our work. We are currently cleaning up the code and applying for its public release to the company. We plan to release the code in June.

When do you release the code

When do you release the code？7 months passed.

When do you release the code？


when i run with idea error-prone plugin, the idea message is display "Failed to download

ATTENTION! Please read and follow:

if this is a question about Error Prone, send it to<EMAIL_ADDRESS>if this is a bug or feature request, fill the form below as best as you can.

When I run an idea plugin, it reports an error.
The idea message display is "Failed to download 'https://repo1.maven.org/maven2....../error_prone_ant-2.x.x.jar'  "

Replace this line with your answer.

Failed to download 'https://repo1.maven.org/maven2....../error_prone_ant-2.x.x.jar'
Depending on my corporate policy, I can't connect to the external network inside the company.So,How can I solve this problem？

Replace this line with your answer.

Install the plugin for the first time, close the network and start the javac with error-prone

Replace this line with your answer.

I installed errpr-prone-plugins v182.3911.36,and add settings to the maven-compiler-plugin with java 1.8.

Replace this line with your answer.

Have you found anything relevant by searching the web?
no

Replace these lines with your answer.
Places to look:

GitHub issues: https://github.com/google/error-prone/issues
email threads on https://groups.google.com/forum/#!forum/error-prone-discuss

God
error-prone-plugin ->  error-prone.jar-> lib/library/error-prone.xml
The download address is fixed to “repo1.maven ....."

work around - fetch the jar to your maven repo via corporate maven mirror:
mvn dependency:get -Dartifact=com.google.errorprone:error_prone_core:2.6.0:jar:with-dependencies


GCC for Windows

Windows
Download and install the GNU Compiler Collection (GCC) for Windows from winlibs. Make sure to add the installation directory to your system path environment variable during installation.
https://github.com/brechtsanders/winlibs_mingw/releases/download/14.1.0posix-18.1.8-12.0.0-ucrt-r3/winlibs-x86_64-posix-seh-gcc-14.1.0-llvm-18.1.8-mingw-w64ucrt-12.0.0-r3.7z
can make a simple tutorial , how to install ?
thank you

it is easy to install it on windows as any other program, you can look in youtube for such video there are a lot.


Provide more detailed error message on validation of deploy preferences

Instead of a general 'Invalid bucket name' or similar messages for project ID, and version, the error message should be more descriptive including the details of what part of the name violates the rules, e.g:

too long name

too short name

invalid character/reserved word

Empty Project ID should say "Missing Project ID", and we should have some explanation as to the consequences since we can continue to run locally.

Having a description of the field in the top status area is a bit awkward: it's a single line, and not very long.

I wonder if it might make sense to provide detail on the project, version, and bucket formats when editing the text field.  We could have a hover that pops up when the field has focus (ControlDecoration#showHover and #hideHover), kinda like Balloon Help or Bootstrap popovers.


Orthogonalizing paths

Hello,
I just wanted to orthogonalize a path, and couldn't figure out a way to do so with iD. It looks like the “square” option (for areas) is replaced with a “straighten” option (for paths).
Is there a rationale for not supporting squaring paths? As squaring is strictly more powerful than straightening, I don't really understand why the two are treated differently.
Anyway, thank you for your work!

Is there a rationale for not supporting squaring paths? As squaring is strictly more powerful than straightening, I don't really understand why the two are treated differently.

I don't know why either.  You can currently orthogonalize a closed path, but not an open one.. I think the squaring algorithm only works on closed paths, but maybe we could change that.

Does this example fit this usecase? It would be awesome to be able to "square" this line in having 90° angles:

Source

Does this example fit this usecase? It would be awesome to be able to "square" this line in having 90° angles:

Yes, exactly!


Rage Attack Bonus isn't working

When applying rage, I'm not getting the appropriate damage bonus for strength based attacks.  Here is the configuration for the rage bonus.

Here is the resulting attack from a lvl 9 barbarian (I would expect to see +3, not +0)

If this is a simple attribute change or adjustment please let me know.  Thanks for all you do, this module is great!

Check you rage scale in the Barbarian class advancement.
There was an issue some time ago with DnD Beyond imports having a wrong identifier.

Got it.  Instead of @scale.barbarian.rage-damage it was supposed to be @scale.barbarian.rage
This is fixed, thank you


Add deposit tests

Add a test for deposit instruction happy path
Add a test for failure when the payer is not the margin account owner

awesome. i was actually about to prep a pull request for this too XD.
code looks good to me

awesome. i was actually about to prep a pull request for this too XD.
code looks good to me

Thanks for taking a look, I was about to work on borrows as well just so we don't end up doing the same thing :D

good to know thanks!
looks like we will need to mock out the OpenOrders object from Serum in order to test both Borrow and Withdraw


Add email listing signup on splash page

Description
Resolves #22

add email listing sign up UI
integrate Firestore backend with security rules for validation
add unit tests for Firestore security rules with Jest and Firestore emulator
update workflows to run unit tests and deploy Firestore rules
rework global state management with zustand to use single Firebase analytics and Firestore db instance across app

Sign up input behavior:

shows status on right icon button (submit, loading, success)

input is disabled when loading and after successful submission

toast message notifies user after clicking submit (and getting response back from database) if it worked

red error when the email is in an invalid format or if it's a duplicate email that has already been submitted
green success when it is in the correct format and is unique

focus outline turns red on invalid email inputs after first attempt submitting (doesn't annoy the user on first try)

except when the input is empty -- it stays on default focus color

Yep, I'll add it here! I wasn't sure whether or not to bundle it in this pr or not before


Closes #54: Pull Request Template

Pull Request
Hello! I think this pull request template includes everything it needs to, in accordance with the description and comments provided on #54.

[x] Title: Place Closes #<insert_issue_number> at the beginning of your PR title. Use the Edit button in the top-right if you need to update.
[x] Linked Issue: Ensure the related issue is linked in the "Development Section" on the right-hand side.
[x] First Contribution: If this is your first contribution, add yourself to the DESCRIPTION file.
[x] Impact on Examples: If your updates impact any examples, review locally for warnings or errors in the impacted example pages.
[x] Merge Conflicts: Developers should address any merge conflicts and merge upon successful review.
[x] New Packages: If new packages were used, ensure they are included in the DESCRIPTION file's Imports section.
[x] Updated Examples: If you added or updated an example, ensure it runs on the latest CRAN release versions of all packages used.
[x] Testing Instructions: Provide instructions on how to test the code if necessary.

thanks for your contribution @DavidBlairs - i just sent you an invite for repo write access in case you'd ever like to make any other PRs in future.


[enhancment] using a generic memory interface for mapping/unmapping

Description:

Add support for abtracted memory backend management for portability between various MPU subsystems and potential future MMU-based systems

Type:

IMPROVEMENT

Rationale:

Allows a simplification of the memory backend access through higher level API
Permits to support a unified model of memory abstraction

Thanks for that very helpful work!
I worked on that code to integrate some massive previous patches and some slight changes. It's integrated in PR #41.
However, credit is mostly yours.


Import twitter archive

Script to import json files from twitter's new archive feature. Only tested with my data so far. Feedback appreciated.

Twitter seems to have changed their data archive structure. No more "data/js/tweets/year_month.js", just one big "tweets.js" (and everything else including media, DMs)
Anyone working on an update? :(


Some images do not go through the compression until after a reload.

STR:

Go to https://www.ghacks.net/
Click on an article with a picture.
See that the picture is in full color and uncompressed.
Reload the page.
Now the same picture is compressed and greyscaled.

I can't reproduce it. Sounds related to the cache.

I can't reproduce it too.
Right, it could be related to browser cache - maybe it cached the full color image before.
Also could be related to rate limiting on the proxy - sometimes webtask.io returns HTTP 429 Error, too many requests. But in this case it should not display the image at all.

I can reproduce it in Firefox and Firefox on Android.
I can also confirm that the problem does not exist in Chrome.

@mrdokenny thanks for confirming!
Are you using the default proxy URL (https://wt-e9c9a7a436fcd9273a7f8890849dae65-0.run.webtask.io/bandwidth-hero-proxy) ?
I will try to reproduce it with remote debug on my Android device...

Yes, everything is at default.

I tested on a new profile with only this extension installed and I still couldn't reproduce it. I'm using Firefox 56.0.1 (x64) on Windows, in case it's due to some sort of compatibility issue.

I had this happen to me for the first time today. So far I've only seen it happen on that particular site (ghacks.net) and the only significant difference I can point out is that I visited the site through a VPN this time. There's definitely something going on, I'll try to test some more later.

I will also add that sometimes when I visit a site for the first time I get to see some uncompressed images load before they are replaced by compressed versions without me doing anything.
I wish I could provide more useful feedback, but I'm not even sure how often this happens because most of the time it's actually pretty hard to notice, as the compressed versions are loaded almost immediately afterwards. Also, I can't tell what is happening in the area of websites that is not visible when they're still loading (before I scroll down).

@claustromaniac thank you for trying to help!
I've tried to reproduce it as well, but can't seem to get it reproduced repeatedly, just happens sometimes randomly.
Might have something to do with how browser events are handled. But I don't see a way to locate and fix it right now.

@ayastreb I wish I could do more 😄
It is still an invaluable add-on for me so I wouldn't mind this staying a known issue in the future. It seems relatively minor.
Thank you again!


feat: make nfc check optional on android

Summary
Fixes a null pointer access error, and also introduces the supportsTapToPay field for canAddCardToWallet(). This field defaults to true, but when set to false, it will disable the check for NFC compatibility and allow merchants to provision cards on devices without tap to pay functionality
Motivation
closes https://github.com/stripe/stripe-react-native/issues/1306
Testing

[x] I tested this manually
[ ] I added automated tests

Documentation
Select one:

[x] I have added relevant documentation for my changes.
[ ] This PR does not result in any developer-facing changes.

Does this mean we can create apps to collect payments with tap to pay without needing a separate card reader terminal?


Clean up #1337

While dealing with merge conflicts for #1360 I caught some messy code from #1337:

We only include CsvExport in the CategoriesController, meaning that the index action with a zip format is probably broken for the EquipmentModelsController and the EquipmentItemsController.
Luckily, the links on all of the views for equipment export point to /categories.zip, so we're never hitting the routes for the other controllers.

We should be more consistent, either including it in all the controllers or just the one but then updating the index action in the others. @esoterik I'm giving this to you since the original issue was yours; sorry for not catching this earlier! We can wait for this until #1360 is finalized to avoid merge conflicts in the controllers.

#1500 was merged in so I'm unblocking this @esoterik.

looks good to me


[64] Issue #64 - April 6, 2017

https://twitter.com/jckarter/status/847844818461933569
https://lists.swift.org/pipermail/swift-evolution/Week-of-Mon-20170327/034752.html

Refactoring tools for Swift:
https://twitter.com/simjp/status/848288462952316928
https://twitter.com/simjp/status/848288609006309376

lol
https://twitter.com/harlanhaskins/status/848172027760574465

https://twitter.com/simjp/status/848707039966646272

welp
https://lists.swift.org/pipermail/swift-evolution-announce/2017-April/000337.html
https://twitter.com/slava_pestov/status/849051907435839488

Well then, that's settled. 😁

keypath proposal:
https://twitter.com/jckarter/status/849471704871174146

greg heo's images are 👌
https://swiftunboxed.com/lang/reduce/

Yet Another Sequence-related proposal from the illustrious airspeedswift:
Add an all algorithm to Sequence
https://github.com/airspeedswift/swift-evolution/blob/9a778e904c9be8a3692edd19bb757b23c54aacbe/proposals/0162-all-algorithm.md

Don't hear too much about swift-users, but there are some tips on how to narrow down compiler crashes to help debug:
https://lists.swift.org/pipermail/swift-users/Week-of-Mon-20170403/005143.html


cmd/wit-bindgen-go: add --version flag

The version and git revision are pulled from the debug.BuildMode struct.
Variation of #143.

@Mossaka does this meet your requirements?


antimatter: javascript and subpages visibility

The default antimatter theme needs javascript for the very basic of page switching (click to open the navigation menu).
I suggest that to be discussed. At least the navigation could start visible when javascript is disabled.
I found that when I discovered that subpages would not show up in the navigation menu  without the dropdown option being enabled.
Following the same principle of "content [and usability] first and eye-candiness and features second", I think it'd make sense that default settings do not hide subpages (eg: dropdown: true,)

If you want to provide a Pull Request, I will take a look.  This is just a sample theme, and no-javascript support is not a top priority in our resource allocation.


Ansible-based operator logging verbosity flags don't affect events written to stdout

Bug Report
I'm attempting to lower the log level of my ansible-based operator for every day use. Logs are collected from stdout of the operator pod.
I would also like to be able to increase log levels for investigation when there's an issue.
What did you do?
I followed the guidelines for adjusting log levels here
Before any change I ran ps -ef inside the container and see the anible-runner start with command:
 /usr/bin/python3.6 /usr/local/bin/ansible-runner -vv --rotate-artifacts 20 -p /opt/ansible/playbook.yml -i ....
With the annotation in the watched CR
annotations:
    "ansible.operator-sdk/verbosity": "0"

I see ( -vv gone from command )
 /usr/bin/python3.6 /usr/local/bin/ansible-runner --rotate-artifacts 20 -p /opt/ansible/playbook.yml -i  .....
What did you expect to see?
I expect to see the log verbosity at stdout is the same as what is written to internal log files
/tmp/ansible-operator/runner/<group>/<version>/<kind>/<namespace>/<resource>/artifacts/latest/stdout
What did you see instead? Under which circumstances?
Log levels written to stdout remain at info level regardless of the annotation.
The annotation in the CR affected the verbosity of logs written to file, but not what is written to stdout.
Environment
Operator type:

/language ansible

Kubernetes cluster type:
Openshift 4.5.17
$ operator-sdk version
ansible-operator:v0.19.0
$ go version (if language is Go)

$ kubectl version
v1.18.3+45b9524
Possible Solution

Additional context

/kind bug
/assign @jmrodri

I happen to have run into this very same issue a few of days ago.
And pulled my hair for a couple of hours trying to understand why Ansible logging doesn't work correctly.
It boils down to how the Ansible operator program handles logs from Ansible (Runner).
See https://github.com/operator-framework/operator-sdk/blob/master/internal/ansible/events/log_events.go#L50.
By default, the output from Ansible is only included when:

e.Event == eventapi.EventPlaybookOnTaskStart && !setFactAction && !debugAction
e.Event == eventapi.EventRunnerOnOk && debugAction

Which I find more than restrictive and strange. Why give the debug action any more precedence over the rest?
And why is set_fact excluded?
Furthermore, there's also an missing event called runner_item_on_ok which is sent by Ansible Runner in the case of a loop.
Like @FNaughton, I expect the Ansible operator to forward all the output from Ansible (Runner), leaving the choice to the user how many information needs to be gathered, based on the existing verbosity setting.
Basically what is contained in the stdout property of all the JSON files in /tmp/ansible-operator/runner/<group>/<version>/<kind>/<namespace>/<resource>/artifacts/latest/job_events/.
By the way, why set the default Ansible verbosity level to 2 (i.e. -vv) in https://github.com/operator-framework/operator-sdk/blob/master/internal/ansible/flags/flag.go#L66?
A value of 0 seems to me a more sensible option.

I too was expecting ANSIBLE_STDOUT_CALLBACK=actionable to have an effect.

The ansible runner inside the operator seems to have the STDOUT_CALLBACK hardcoded inside it.
bash-4.4$ grep STDOUT_CALLBACK /usr/local/lib/python3.6/site-packages/ansible_runner/runner_config.py
self.env['ANSIBLE_STDOUT_CALLBACK'] = 'minimal'
self.env['ANSIBLE_STDOUT_CALLBACK'] = 'awx_display'
Is there a way to configure the CALLBACK plugin (to say oneline) ?

Hi, any known workaround until this is fixed ?

@fabianvf - tried adding the envvar
env:
        - name: ANSIBLE_DEBUG_LOGS
          value: "True"

It does indeed print the ansible run to the console. But this is in addition to the messages logged by default. I would like to control the verbosity of these default messages. Our logging solution collects from stdout.
On the plus side, the debug logs respect the verbosity set in the watched CR annotation. Perhaps we could disable the default message?

Testing with an image built from operator-sdk v1.9 I still see info level logs at stdout even with log level set to 0.
Wondering if I'm missing something here?
Dockerfile:
FROM mylocalrepo/8-jre-rhel:latest as builder
FROM quay.io/operator-framework/ansible-operator:v1.9.0
...

Annotation in watched CR:
annotations:
    ansible.sdk.operatorframework.io/verbosity: "0"

Hi @FNaughton,
Can you show us the current info logs you are getting vs the type of output you are expecting?
With the fix from the PR above, the stdout logs associated with a task will be dumped out (based on annotation/env variable verbosity) during that task's execution. However, we still left the logs that are outputted during the initialization of the operator. Are these the info logs you are referring to?

Hi @FNaughton,
We have started looking into this again. Here are some clarification points:

We have two types of logging packages at use - Zap and Log.
The fix I submitted in the PR above dumps StdOut logs to the console when verbosity is set as an annotation or environment variable. Keep in mind this PR limits Ansible task-related logs only, not the initialization logs that you reference in your comment.

Reading your use case, you might want to use --zap-log-level=error CLI flag to only see the Ansible task output with no logs, such as below:
$ ansible-operator run local --zap-log-level=error

--------------------------- Ansible Task StdOut -------------------------------

TASK [Gathering Facts] *********************************************************

-------------------------------------------------------------------------------

--------------------------- Ansible Task StdOut -------------------------------

 TASK [Hello World] ********************************
ok: [localhost] => {
    "msg": "Hello, World!"
}

-------------------------------------------------------------------------------

----- Ansible Task Status Event StdOut (cache.example.com/v1alpha1, Kind=Memcached, memcached-sample/default) -----

PLAY RECAP *********************************************************************
localhost                  : ok=2    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

----------

I am also submitting a PR soon that allows even less output while running the operator, using a CLI flag --ansible-log-events, that will look like the following:
$ ansible-operator run local --zap-log-level=error --ansible-log-events=nothing

----- Ansible Task Status Event StdOut (cache.example.com/v1alpha1, Kind=Memcached, memcached-sample/default) -----

PLAY RECAP *********************************************************************
localhost                  : ok=2    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

----------

Feel free to weigh in and let us know if this is what you are looking for and any other suggestions you have as well.  Thanks!


Question: Is there a way to change now dev to use start instead of build command?

I'm using create-react-app and when I tried to use now dev it is using the default build command. Is there a way to change it to use the start command with the development server instead of doing production builds on each change?
Thanks.

Hi Bruno,
You can add a dev script to package.json which will be used with now dev instead of the build script.
https://zeit.co/docs/v2/serverless-functions/introduction#local-development

Thanks @styfle. After rename the start command to dev I had to add BROWSER=none. Final version: "dev": "BROWSER=none react-scripts start"


[Addition]: Self witnessing clusters of hotspots ;Location spoofing

Hotspot b58 Addresses
11mNWE9cTP8c67eE4p89WbCpJycqBwQRrPvnSuWmzdpmMfza7cL
Discord Handle
Akira#2514
Reason(s)
Witnessing only among each other even though surrounded by  other hotspots.

Merge #6961


Update help messages custom to page shown

== Ready to Merge ==
Added in help messages specific to pages being shown + general commands.
Eg. help from the Course page

Closes #152

LGTM !! Great job 😊😊


input source maps only have their first sources considered

At https://github.com/thlorenz/combine-source-map/blob/master/index.js#L30 it's clear that only the first source is considered.
When using combine-source-map to try to take already bundled/transpiled source and add new code, updating the source map, it's helpful to process the mappings for all sources.
See here for an example of using the source-map module directly to port all mappings with a fixed offset: https://github.com/okfn/annotator/blob/browserify/tools/bundle#L145

Any progress with merging the pull request in - or at least explaining why it hasn't been so it can be improved?!
This bug has been open for over a year and renders browserify source-maps unusable in all but the most basic situations.

I just submitted a new pull #14 that modifies pull #11 and which I think fully addresses the issue.

@aarononeal I added you as collaborator.
Now you can merge your proposed PRs into master and ping me when done so I can publish a new version.
Please make sure that the changes don't break anything and still work with the latest browserify.
Also it'd be nice to ensure that new versions get used in new browserify releases, i.e. propose PRs that upgrade their combine-source-map dependency.
When you do merge, please do forward merges by rebasing off master first.
I consider Merge Pull request ... commits in the history as noise, so I'd like to keep it clean and linear.
Please close any issues once they are resolved due to merged PRs and help out with other issues as you can. I'd greatly appreciate it.
Thanks for your help.

@thlorenz-- Thanks! I'll tackle that this weekend.

@thlorenz -- I added an extra test to cover the behavior, added a couple comments for clarity, and FF merged the PR. I ran the change through my Browserify based projects and I'm getting the source paths I would expect. I'll keep an eye on things in case anyone reports a regression.
Once you publish I can send a PR to browser-pack and browersify to update their dependencies. In the meantime, folks can manually add this component to their package.json to get the fix.

Awesome work!
Published as 0.4.
Thanks a lot.


drivers: udc: eliminate C++ errors by casting void* to the target type

When this header is included in a C++ source file, compilation fails due to invalid syntax. It can be converted to a warning with -fpermissive, but the long term solution is to just perform the missing casts as done here.

@jfischer-no is there anything to be done to move this PR forward?

It may be that the bugfix in the branch name is a misnomer, since the Zephyr codebase itself builds without issues. However, Zephyr claims to support applications written in both C and C++. This PR is a step to reach this claim in effect. It has absolutely no adverse effects when compiled into C, but this change is vital to allow compilation into C++.

@jfischer-no please revisit

Here in project, we are using C language. Implicit conversion to a pointer to void is fine and vice versa.

But we do support out-of-tree applications written in C++, where implicit pointer conversion leads to a warning.


Update README URLs based on HTTP redirects

Created with https://github.com/dkhamsing/frankenstein
GitHub Corrected URLs

Was
Now

https://github.com/s4cha/Arrow
https://github.com/freshOS/Arrow

https://github.com/s4cha/then
https://github.com/freshOS/then

https://github.com/s4cha/ws
https://github.com/freshOS/ws

          1 Warning

:warning:
Too many changes (when adding, please keep it to one project per Pull Request)

  Generated by :no_entry_sign: danger


Validation doesn't clear when submitting a literal to a required lookup

If you create a new resource using "Sinopia:RT:Demo:SampleResourceFuller" on development (or any template that has a required lookup), then before entering any values you click save. This validates the form.   Next fill in all required fields except the required lookup ("Example 10" in this case).

Then enter text in the field and press the search button

Click the "Add ... as literal" link.

Then you see the validation that cannot be cleared and the resource cannot be saved.

Unfortunately, consumers of the data (e.g., rdf2marc) have to assume that a literal may be present when a URI is expected. That is likely to be the case for other sources of bibliographic data in RDF, not just Sinopia.


Add jupyter notebook for semantic caching tutorial

Purpose

This is a jupyter notebook that is used as a guide in our documentation for a tutorial on semantic caching.
Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Documentation content changes
[X] Other... Please describe: Documentation tutorial sample code

Other Information

Thanks @philon-msft! BTW, I don't have write access to this repo, so I think I need you to actually merge the PR.


Problem Declaring a pointer to a function that returns a function pointer

This is what I did. It is a bit dense, but it works with gcc locally and with clang on Travis CI:
struct SMockSupport_c
{
    void (*(*returnFunctionPointerValueOrDefault)(void (*defaultValue)()))();
}

However, gcc on Travis CI (with cmake) takes exception to it:
MockSupport_c.h:104:5: error: function declaration isn’t a prototype [-Werror=strict-prototypes]

I don't know how to fix that :-(

@basvodde it would appear that compiler switches do not agree between builds, because 8 jobs are building fine, and only three complain. Is this intentional?

The builds in question specify -pedantic-errors. The errors only happen when MockSupport_c is included from a C source, the C compiler is compiling it and -pedantic-errors is requested.
The fix seems to be that (void) has to be specified instead of (). Strange, because in non-function-pointer contexts, () is perfectly fine.


netcdf4: build fails on aarch64-darwin

Describe the bug
The package builds but its tests fail, details below. This package is a prerequisite for gdal, postgis etc., which I'm trying to work towards building on M1.
To Reproduce
Steps to reproduce the behavior:

Start with nixpkgs master (currently 431ca399425b602de01c552efe29095dd138990d)
nix-build --argstr localSystem aarch64-darwin -A python3Packages.netcdf4

Additional context
Various test failures are reported, e.g.
*** testing nc_inq_varnatts ... ok
*** testing nc_inq_varndims ... ok
*** testing nc_inq_vartype ... ok
*** testing nc_get_var_text ...
        FAILURE at line 1393 of test_get.c: value read not that expected
        FAILURE at line 1393 of test_get.c: value read not that expected
        FAILURE at line 1393 of test_get.c: value read not that expected
        FAILURE at line 1393 of test_get.c: value read not that expected
        ### 4 FAILURES TESTING nc_get_var_text! ###
*** testing nc_get_var_uchar ... ok
*** testing nc_get_var_schar ... ok

*** testing nc_put_var_longlong ... ok
*** testing nc_put_var_ulonglong ... ok
*** testing nc_put_var1_text ...
        FAILURE at line 311 of test_put.c: Var value read not that expected
        FAILURE at line 311 of test_put.c: Var value read not that expected
        FAILURE at line 311 of test_put.c: Var value read not that expected
        FAILURE at line 311 of test_put.c: Var value read not that expected
        ### 4 FAILURES TESTING nc_put_var1_text! ###

*** testing nc_get_varm_longlong ... ok
*** testing nc_get_varm_ulonglong ... ok
*** testing nc_get_varm ...
        FAILURE at line 1605 of test_read.c: buf read not that expected
        FAILURE at line 1605 of test_read.c: buf read not that expected
        FAILURE at line 1605 of test_read.c: buf read not that expected
        FAILURE at line 1605 of test_read.c: buf read not that expected
        ### 4 FAILURES TESTING nc_get_varm! ###
*** testing nc_get_att_text ...
        FAILURE at line 10674 of test_get.c: value read not that expected
        ### 1 FAILURES TESTING nc_get_att_text! ###

Notify maintainers

Metadata

system: "aarch64-darwin"
host os: Darwin 20.5.0, macOS 11.4
multi-user?: yes
sandbox: no
version: nix-env (Nix) 2.3.12
channels(steve): "darwin, nixpkgs-21.11pre297902.e8597594274"
nixpkgs: /Users/steve/.nix-defexpr/channels/nixpkgs

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
  - "python3Packages.netcdf4"
# a list of nixos modules affected by the problem
module:

🤔 I don't see homebrew applying anything aarch-specific: https://github.com/Homebrew/homebrew-core/blob/52ad4319821c5c8244614842ebb900c9d7b98370/Formula/netcdf.rb

The one thing that Homebrew does do is disable the tests...

I concur. This prevents gdal installation.

Googling turned up an (old) result from the GDAL devs saying that such test failures could be ignored, and since all the other tests are passing and the homebrew folks are disabling tests wholesale, perhaps an acceptable workaround is to disable tests on this platform+arch.

Googling turned up an (old) result from the GDAL devs saying that such test failures could be ignored, and since all the other tests are passing and the homebrew folks are disabling tests wholesale, perhaps an acceptable workaround is to disable tests on this platform+arch.

Sounds good to me. Could you submit a PR? Maybe referencing the links you're referring to?

Yes, I'll take a look if get chance. It's probably somewhat fiddly because doCheck is already false here: the homebrew formula (linked above) passes a bunch of different build flags to cmake to disable tests for various things, it doesn't look like an easy fix relative to my personal nix skill level.
Btw, that link I mentioned:

"Don't be too concerned about this. 90% of the problems we have
with nc_test and nf_test are with the tests themselves. (Arrgh.)"

But that's from '97, lol.

Seems resolved now, closing.


List of Problems Regarding Enemies

[ ] Set up attack animation for enemies
[ ] Make enemies move after player moves (so player doesn't die on spawn)
[ ] New enemies with different features  (related to level)
[ ] Fix bugs with flying goomba (especially avenida level)
[ ] Fix rapid left and right (jittering) movement that happens when there are too many enemies on screen
[ ] Fix flying goomba not doing any damage or kills
[ ] Less/more enemies per level (depending on level)
[ ] Regular Goombas don't kill you on any level except normal

this can be fixed from this function below:
        if (this.timer === false) {
            this.timer = true;
            if (GameEnv.difficulty === "normal" || GameEnv.difficulty === "hard") {
                this.canvas.style.transition = "transform 0.5s";
                this.canvas.style.transform = "rotate(-90deg) translate(-26px, 0%)";
                GameEnv.playSound("PlayerDeath");
                if (this.isDying == false) {
                    this.isDying = true;
                    setTimeout(async() => {
                        await GameControl.transitionToLevel(GameEnv.levels[GameEnv.levels.indexOf(GameEnv.currentLevel)]);
                        console.log("level restart")
                        this.isDying = false;
                    }, 900);
                }
            } else if (GameEnv.difficulty === "easy") {
                this.x += 10;
            }
        }
    }

[ ] Flying goomba only starts flying/jumping when the player jumps (not fully sure about this)

Tube.js, Coin.js, Tree.js were fair game as well.   You could coordinate with Platform/Walls team to make sure different types of obstacles are considered.


Add link to COMBINE 2021 recordings #59

This solves the issue that @nickerso was having when creating the PR


Fix StorageObjectInUseProtection format in doc

Fix StorageObjectInUseProtection format to follow other admission controllers in doc.

I signed it

/lgtm
/approve