[Bug?] Unable to require('node-forge') in a jest test

Example repo: https://github.com/torarvid/jest-test
I made the smallest example I could to show the issue, which is that when doing require('node-forge'), jest gives the error:
TypeError: mods[i] is not a function

  at Object.module.exports (node_modules/node-forge/js/forge.js:41:14)

Now, I don't understand the nature of this problem, so maybe the problem is me (I'm new to Jest). My actual scenario is that I'm testing one of my own modules that happen to require 'passport-saml', which in turn requires 'node-forge', and so this error occurs.
If the problem is me, I'd like to understand how I should work around the issue, but also why it happens in the first place.
Just to try to be comprehensive, I'm attaching output from jest --debug. My system is macOS Sierra, node v6.7.0.
jest version = 16.0.1
test framework = jasmine2
config = {
  "testEnvironment": "/Users/torarvid/src/jest-test/node_modules/jest-environment-node/build/index.js",
  "rootDir": "/Users/torarvid/src/jest-test",
  "name": "-Users-torarvid-src-jest-test",
  "setupFiles": [],
  "testRunner": "/Users/torarvid/src/jest-test/node_modules/jest-jasmine2/build/index.js",
  "scriptPreprocessor": "/Users/torarvid/src/jest-test/node_modules/babel-jest/build/index.js",
  "usesBabelJest": true,
  "automock": false,
  "bail": false,
  "browser": false,
  "cacheDirectory": "/var/folders/b6/wxj8mztd61j7rthm5p9n2_3r0000gn/T/jest",
  "clearMocks": false,
  "coveragePathIgnorePatterns": [
    "/node_modules/"
  ],
  "coverageReporters": [
    "json",
    "text",
    "lcov",
    "clover"
  ],
  "globals": {},
  "haste": {
    "providesModuleNodeModules": []
  },
  "mocksPattern": "__mocks__",
  "moduleDirectories": [
    "node_modules"
  ],
  "moduleFileExtensions": [
    "js",
    "json",
    "jsx",
    "node"
  ],
  "moduleNameMapper": {},
  "modulePathIgnorePatterns": [],
  "noStackTrace": false,
  "notify": false,
  "preset": null,
  "preprocessorIgnorePatterns": [
    "/node_modules/"
  ],
  "resetModules": false,
  "testPathDirs": [
    "/Users/torarvid/src/jest-test"
  ],
  "testPathIgnorePatterns": [
    "/node_modules/"
  ],
  "testRegex": "(/__tests__/.*|\\.(test|spec))\\.jsx?$",
  "testURL": "about:blank",
  "timers": "real",
  "useStderr": false,
  "verbose": null,
  "watch": false,
  "cache": true,
  "watchman": true,
  "testcheckOptions": {
    "times": 100,
    "maxSize": 200
  }
}
 FAIL  __tests__/node-forge.test.js
  ●  › should foo

    TypeError: mods[i] is not a function

      at Object.module.exports (node_modules/node-forge/js/forge.js:41:14)

    ✕ should foo (1ms)

Test Suites: 1 failed, 1 total
Tests:       1 failed, 1 total
Snapshots:   0 total
Time:        0.321s, estimated 1s
Ran all test suites.

Hitting this issue. I debugged this a bit until I lost patience 😃
node-forge is doing some wonky module stuff to basically export its various libs. It:

Converts from "Node" modules to AMD
Has a ton of indirection for loading them and has a cache to make sure it only loads them once.
Exports the modules

From what I can tell, when run under jest the dyanmic exports aren't getting set, which makes the require call undefined, which then throws an error when looped through.
I was debugging what was going on, but don't think I know enough about modules and how jest mocks to find the cause.
I just commented out the array access in node-forge for now and my tests are working. YMMV.

oh hello, @LegNeato! Good to run into you.
I don't think I'd like to support this weirdness in the module loading that node-forge does. I recommend building a manual mock for it or sending a PR to the maintainers of node-forge to provide a better versions that uses CommonJS properly. This will make it work with Jest automatically.


Check that pkg.maintainers is defined before checking it's length

:recycle: Current situation
For some reason, NPM doesn't seem to be setting the maintainers key on packages in the registry right now. I only noticed this because I was seeing this error in the Homebridge UI after publishing an update to a package:
[6/20/2024, 6:17:45 PM] [Homebridge UI] [homebridge-fujitsu-airstage] Failed to check registry.npmjs.org for updates: "Cannot read properties of undefined (reading 'length')" - see https://homebridge.io/w/JJSz6 for help.

:bulb: Proposed solution
Check that pkg.maintainers is defined before checking it's length

pkg.maintainers.length could be undefined ! We have error in our plugin untlil we add mainteners = [] to the pachage.json.

and maybe not only first mainteiner? Maye first 4 mainteiners?

Patched my environment with this fix.  The source also seems to end up in dist/main.js, from where the error is caught - I still don't understand typescript in full.
Anyways, this PR solves the missing menu items, but doesn't solve the missing author.  The author still seems to be in the response, under _npmUser/name.

It’s supposed to be set on the NPM side automatically, according to this:

npm also sets a top-level "maintainers" field with your npm user info.

I filed a support ticket with them and started a thread on their GitHub community page, here, if you all want to comment there

maintainers is still there on the top level; it's no longer included at the version level of recently published versions.  So when only getting the latest version of a package, the info is missing.

If you want to fix errors in plugins you need to:

add to package.json: "mainteiners" = ["mainteiner-name"]
publish latest release (not beta)

in Homebridge UI code should check firts if mainteiners is not empty.

If you want to fix errors in plugins (until this patch will be released) you need to:

add to package.json: "maintainers" = ["maintainer-name"]
publish latest release (not beta)

I think that this patch should be released ASAP, cause every new public release without maintainers in package.json will generate errors.
And maybe not only first maintainer? Maybe first 4 maintainers?

@mkz212 workaround seems to work.  Note that it's actually "maintainers": ["maintainer-name"] (using a colon instead of an equals sign).

@mkz212's workaround seems to work. Note that it's actually "maintainers": ["maintainer-name"] (using a colon instead of an equals sign).

Sorry, yes, colon!

4.56.3 should be released soon.

Ran into a test coverage issue that needs to be resolved first


Redirect to login after logout

This redirects to the login page after logging out instead of reloading the client which may case an unexpected "You're not allowed to see this application" error.
Please review @terrestris/devs.

Thanks for the review!


Add py3 to Python's extensions list

Closes #3323 (check it for a discussion)
According to @Alhadis,

The 1895 py3 files on GitHub are distributed among 392 repositories by 366 users

@danilaml Could you please confirm the origin of the sample file you added? We require samples to be released under a permissive license (specifically, one of these). Aside from that, I'd say this is good to go. 👍

@Alhadis My bad, I've traced the sample origin and it looks like it's CC BY-NC-SA. I'm not certain, but I've changed it with one that is in public domain, just to be sure (I squashed it with the previous commit).

Looks good to me. Should we ⚓ this?
@brandonblack, you're first in alphabetical order of newly-assigned staff members, so I'm pinging you first for feedback. =)

@Alhadis btw, should I accept the Github CLA? I see the check in the PR, but no mention of or link to it in the CONTRIBUTING.md.

Ah, yes please! That's actually the first thing every contributor should do... once it's done, you'll never have to worry about it ever again. =) It's just a legal requirement, like agreeing to an EULA when installing a program. There's no hidden agenda or anything.
... as for the CI status, I'm not sure why it's stalled. :S It might be confused by the lack of CLA agreement (though it usually fails if that's the case).

@Alhadis I had to go read git-lfs readme to find out how to acquire proper link for this repo's CLA. Is there any information on it in this repo and I've just missed it?

Okay, looks good! CI's lovely and green. 💚 Incidentally, my favourite colour.
Well, when CI fails due to a missing CLA signature, it's supposed to display a notice which includes links to the relevant pages. In this case though, it's behaving weirdly, so of course you weren't notified about it.
The GitHub CLA actually isn't specific to this project: instead, it's specific to every open source project which GitHub is legally responsible for. So including links to the CLA pages for every affected repository would be slightly spammy.

This looks good. Thanks @danilaml and @Alhadis.


add Trim punct and space function support

add Trim punct and space function support

Codecov Report

Merging #28 into master will decrease coverage by 0.92%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   91.83%   90.90%   -0.93%
==========================================
  Files           9        9
  Lines         588      594       +6
==========================================
  Hits          540      540
- Misses         36       42       +6
  Partials       12       12

Impacted Files
Coverage Δ

gse.go
74.35% <0.00%> (-13.52%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 491ba30...8088549. Read the comment docs.


Objective C error : Unknown type name 'AKNodeRecorder'

Hi all,
i've developing an audio app with Objective C. I integrated successfully with AudioKit and played lats of file via AudioKit using mixer etc but i need  recording input from mic while players is running.
When try to use AKNodeRecorder got this message: Unknown type name 'AKNodeRecorder'.
Any idea of this situation?

Yeah, its a pretty simple fix.  Its updated on the develop branch, or you can make the change yourself too:  https://github.com/audiokit/AudioKit/commit/c0ba34789eb49fda642f82eb80e0c40bd99e35d3


Pre-bundling dependencies

Hello everyone,
Is it normal that each time that I run storybook the cli keeps showing: "Pre-bundling dependencies (this will be run only when your dependencies or config have changed)".
It's like the cache from vite is not working or should I put something in the config.
Thank you in advance.
Here is my actual config:
async viteFinal(config, { configType }) {
    return {
      ...config,
      resolve: {
        alias: [
          {find: '@', replacement: path.resolve(__dirname, '../src')},
          {find: 'ag-grid', replacement: path.resolve(__dirname, '../node_modules/ag-grid-community/dist/styles/ag-grid.css')},
          {find: 'ag-theme-alpine', replacement: path.resolve(__dirname, '../node_modules/ag-grid-community/dist/styles/ag-theme-alpine.css')},
          {find: 'vue', replacement: 'vue/dist/vue.esm-bundler.js'}
        ]
      },
      cacheDir: path.resolve(__dirname, '../node_modules/.cache/vite'),
      optimizeDeps: {
        ...config.optimizeDeps,
        entries: [`${path.relative(config.root, path.resolve(__dirname, '../src'))}/**/*.stories.js`],
        include: [...config.optimizeDeps.include],
      },
    }
  }

Do you still get the message if you add those dependencies that it pre-bundles into optimizeDeps?  And FWIW, include: [...config.optimizeDeps.include], is unnecessary, since you're already spreading it as part of config.optimizeDeps two lines above it.

Thank you for your response Ian, Yes I was writting the dependencies there, for example:
optimizeDeps: {
        ...config.optimizeDeps,
        entries: [`${path.relative(config.root, path.resolve(__dirname, '../src'))}/**/*.stories.js`],
        include: ['vue-i18n', 'vue3-tel-input', 'vee-validate', ...config.optimizeDeps.include],
      },

But the console keeps showing
info @storybook/vue3 v6.4.0-alpha.18
info
info => Loading presets
info => Using prebuilt manager
Pre-bundling dependencies:
  @storybook/addon-actions
  vue-i18n
  vue
  vue3-tel-input
  vee-validate
  (...and 76 more)
(this will be run only when your dependencies or config have changed)

Each time I run storybook.

It happens to me as well. Not sure if it's a bug. It doesn't bother me a lot, since Vite starts almost instantly in every case, but I think it will use the pre-cached/optimized deps from last time you ran Storybook - it just logs the message anyways?

Also wondering what's up with this. Vite is fast to start, but going through all these bundles takes a full minute.

Also wondering what's up with this. Vite is fast to start, but going through all these bundles takes a full minute.

👁👄👁
It takes 2-3 seconds here. Are you preoptimizing a lot of other dependencies as well?

Sorry, what I was seeing was it discovering new dependencies after that initial list, and it would keep finding new ones did about a minute. I think it's dependencies that's used in async modules, so they aren't added to the initial bundle. But it should still only so that on the first run, like Vite standalone.
I added these dependencies manually into the optimzeDeps includes list, and now it's starting up in a couple of seconds again.

Same here... did anyone happen to resolve it? In my case, it's not a huge issue either because the dev server is up and running less than a couple of seconds, but still it shouldn't re-run the pre-bundling process unless if needed.

I took me about minutes

Is there a way to resolve this ? Facing the same.

@siva-sundar what issue are you seeing exactly?  Can you provide some details of what is happening, vs what you expect?

It takes 40 second for me to display stories after Storybook 6.4.20 for Vue3 started

@extrem7 have you tried enabling features.storystoreV7?  It can help initial load performance a lot.

Yes, enabling storyStoreV7 increases start-up time to ~10s.

@extrem7 it increases start-up?  That's very odd!  Any chance this is a public repository I could take a look at?

Sorry for my French) Time was totally reduced!

pre-bunding enhancement indeed saved the bootstrap time.

Thanks for confirming, @zheeeng!  I'll close this out, but if anyone's still seeing long times, let me know and we can re-open and investigate.


Templates Are Not Being Overriden

I am trying to embed the Django-Oscar system into a custom HTML template. When I do that, I create a directory templates/oscar inside my project's root and place the new template's base.html there. However, I am still seeing the Oscar's original template and styles displayed in the browser.
On the other hand, if I place the very same base.html directly into the root of the templates directory, it is shown, but is missing the static files.
If it helps, here are some settings:
# Build paths inside the project like this: os.path.join(BASE_DIR, ...)
BASE_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))

INSTALLED_APPS = [
    'django.contrib.admin',
    'django.contrib.auth',
    'django.contrib.contenttypes',
    'django.contrib.sessions',
    'django.contrib.messages',
    'django.contrib.staticfiles',
    'django.contrib.flatpages',
    'django.contrib.sites',

    'compressor',
    'widget_tweaks',
] + get_core_apps()

STATIC_URL = '/static/'

STATIC_ROOT = os.path.join(BASE_DIR, "static")

#This should be commented out in Development
STATICFILES_DIRS = [
  os.path.join(BASE_DIR, "static"),
]

MEDIA_URL = "/media/"

MEDIA_ROOT = os.path.join(BASE_DIR, "media")

What can I do to fix this? Does Oscar treat templates in some special way? Is this a Django bug? I am using Django 1.11.

On the other hand, if I place the very same base.html directly into the root of the templates directory, it is shown,

That is the right place to put it. base.html is not within the Oscar namespace.

but is missing the static files.

Not sure if this is the problem, but your configuration of STATICFILES_DIRS is wrong - it is invalid to include the same path as STATIC_ROOT in that list. The former is used to provide additional locations that Django should look for static files. The latter is where Django should write the files when you run collectstatic.

I was able to resolve this. The following code has worked.
TEMPLATES = [
    {
        'BACKEND': 'django.template.backends.django.DjangoTemplates',
        'DIRS': [
            os.path.join(BASE_DIR, 'templates'),

            #re-route the search for templates into this custom template directory
            os.path.join(os.path.join(BASE_DIR, 'templates'), 'tshirt-theme'),

            #Uncomment the line below to restore the original Oscar template
            #OSCAR_MAIN_TEMPLATE_DIR,
        ],
        'APP_DIRS': True,
        'OPTIONS': {
            'context_processors': [
                'django.template.context_processors.debug',
                'django.template.context_processors.request',
                'django.contrib.auth.context_processors.auth',
                'django.template.context_processors.i18n',
                'django.contrib.messages.context_processors.messages',

                'oscar.apps.search.context_processors.search_form',
                'oscar.apps.promotions.context_processors.promotions',
                'oscar.apps.checkout.context_processors.checkout',
                'oscar.apps.customer.notifications.context_processors.notifications',
                'oscar.core.context_processors.metadata',
            ],
        },
    },
]

COMPRESS_ROOT = os.path.join(BASE_DIR, "static")

STATIC_URL = '/static/'

#STATIC_ROOT = os.path.join(BASE_DIR, "static")

#This should be commented out in Development
STATICFILES_DIRS = [
  os.path.join(BASE_DIR, "static"),
]

MEDIA_URL = "/media/"

MEDIA_ROOT = os.path.join(BASE_DIR, "media")

Closing as it seems to be a local configuration issue.


Numba 0.57.0 Checklist

numba 0.57.0

[x] Cherry-pick items from the 0.57.0 milestone into a PR.

[x] https://github.com/numba/numba/pull/8922

[x] Update the "version support table" in the documentation with the final
release date (FINAL ONLY).

[x] Make, approve and merge a PR against the main branch (#8929).
[x] Create a cherry-pick from the merge and include in the cherry-pick-PR
for the release0.57 branch.

[x] Check if any dependency pinnings need an update (e.g. NumPy)

[x] From OOB discussion between @sklam and @stuartarchibald, this seems ok, setup.py, meta.yaml and __init__.py seem to have NumPy, Python and TBB selected appropriately.

[x] Approve change log modifications and cherry-pick (#8929).
[x] Merge change log modifications and cherry-picks to X.Y release branch.

[x] https://github.com/numba/numba/pull/8922

[x] ~Review, merge and check execution of release notebook. (FINAL ONLY)~
[ ] Run the HEAD of the release branch through the build farm and confirm:

[ ] Build farm CPU testing has passed.
[ ] Build farm CUDA testing has passed
[ ] Build farm wheel testing has passed

[ ] Annotated tag 0.57.0 on release branch (no v prefix).
[ ] Build and upload conda packages on buildfarm (check upload).
[ ] Build wheels and sdist on the buildfarm (check "upload").
[ ] Verify packages uploaded to Anaconda Cloud and move to
numba/label/main.
[ ] Upload wheels and sdist to PyPI (upload from ci_artifacts).
[ ] Verify wheels for all platforms arrived on PyPi.
[ ] Verify ReadTheDocs build.
[ ] Post link to Twitter.
[ ] Post announcement to discourse group and ping the release testers group
using @RC_Testers (RC ONLY).
[ ] Post link to<EMAIL_ADDRESS>
Post release

[ ] Snapshot Build Farm config
[ ] Clean up ci_artifacts by moving files to subdirectories
[ ] Update release checklist template with any additional bullet points that
may have arisen during the release.
[ ] Ping Anaconda Distro team to trigger a build for defaults (FINAL ONLY).
[ ] Create a release on Github at https://github.com/numba/numba/releases (FINAL ONLY).
[ ] Close milestone (and then close this release issue).

Hey,
Any plans to release it soon?


install virtual environment pipenv

added virtual environment configuration or installation - used pipenv

added branch development-1 for backend development


Rope with alpha overlaps with itself

Hi - I'm running into a problem were I want to use a semi transparent image for a rope, but unfortunately where it overlaps itself you get a doubling up of the image which looks bad. I was hoping to improve this by using SCREEN blendMode and giving the image a black background rather than transparent but this provides the same issue. Also the same thing happens where the alpha is set, rather than the whole rope which is a bit unexpected.
Is there any way around this ?  I'm trying to make a trail (a bit like SwiftKey/Swype, but fading out).
Thanks!
J

Trails are often done with particle systems, although they may be rougher on performance than a rope. (Blatant self advertising) You could try using PixiParticles for a particle based trail.

Yes love PixiParticles !
I did implement with a particle system which results in a nice looking
trail. Only difficulty is when the particles get too far apart and it looks
less continuous.
I was wondering about if it was possible to apply some kind of unsharp mask
that would cut off the opacity ? So then you could have larger partcles
with a blurry edge, but the filter would cut that down.  Not sure if this
is possible or not with filters as am not very experienced with them.
On Fri, Mar 18, 2016 at 1:06 PM Andrew Start<EMAIL_ADDRESS>wrote:

Trails are often done with particle systems, although they may be rougher
on performance than a rope. (Blatant self advertising) You could try using
PixiParticles https://github.com/CloudKidStudio/PixiParticles for a
particle based trail.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/pixijs/pixi.js/issues/2383#issuecomment-198347407

I would imagine that you could make a small filter that acts similarly to the ColorStepFilter, but just for alpha - set alpha to 0 if below a certain value, and leave it alone otherwise.

Nice! - and that would on a container ?
On Fri, Mar 18, 2016 at 10:51 PM Andrew Start<EMAIL_ADDRESS>wrote:

I would imagine that you could make a small filter that acts similarly to
the ColorStepFilter, but just for alpha - set alpha to 0 if below a certain
value, and leave it alone otherwise.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/pixijs/pixi.js/issues/2383#issuecomment-198571067

Yes, although I believe it would be applied to each individual child as they are drawn, not the container as a whole.

Ah is see. Guess that wouldn't work then ! Bummer !
On Fri, 18 Mar 2016 at 23:00, Andrew Start<EMAIL_ADDRESS>wrote:

Yes, although I believe it would be applied to each individual child as
they are drawn, not the container as a whole.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/pixijs/pixi.js/issues/2383#issuecomment-198572282

closing for now as this is intended behaviour. For what you are looking to achieve @andrewstart is spot on, a simple alpha filter applied to rope should do the trick!

Sorry @GoodBoyDigital --- He said "it would be applied to each individual child as they are drawn, not the container as a whole."  --- which would mean we would end up with the same situation  ? Or am I missing something ?

you could apply the filter directly to rope or a container.


Issue #29

Finished sum() implementation, issue-#29. Ran linting and code formatting.

[ ] commit message follows format outlined here
[ ] passes flake8 modin
[ ] passes black --check modin
[ ] signed commit with git commit -s
[ ] Resolves #?
[ ] tests added and passing

Codecov Report

:exclamation: No coverage uploaded for pull request base (modin-gpu-baseline@057eb61). Click here to learn what that means.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##             modin-gpu-baseline      #59   +/-   ##
=====================================================
  Coverage                      ?   55.90%
=====================================================
  Files                         ?      135
  Lines                         ?    14722
  Branches                      ?        0
=====================================================
  Hits                          ?     8231
  Misses                        ?     6491
  Partials                      ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 057eb61...462023d. Read the comment docs.


fix Java 8 dependency, now compiles under Java 7

This library almost compiles under Java 7, but java.util.Map lacks a putIfAbsent method (added in Java 8). If we replace the regular Map with a ConcurrentHashMap (which does have this method), then it compiles fine.

Coverage remained the same at 99.373% when pulling 67a0595ce4d11386a5a4186d5e269f4c7bb951a3 on qbisins:master into 709012c4518489043e4a3a61a0212736f3b07499 on piwik:master.

Coverage remained the same at 99.373% when pulling b62733601910ec1f97f0c113443abf97fe318004 on qbisins:master into 709012c4518489043e4a3a61a0212736f3b07499 on piwik:master.

Coverage remained the same at 99.373% when pulling b62733601910ec1f97f0c113443abf97fe318004 on qbisins:master into 709012c4518489043e4a3a61a0212736f3b07499 on piwik:master.

Thanks for the pull request, but I've resolved this with the approach I've outlined above.  Thanks for pointing this out!


inferenceX test depends on random seed

The inferenceX test depends on a seed and doesn't always pass which is understandable. Could do with reformulating the test.

This is still a stochastically failing test! @zhenwendai when you get a minute could you take a look? I know we discussed it previously and we decided it was a floored test, but it is useful to have something like this in here! Maybe we can just fix the seed!

I fixed this by setting a seed.


Cleanup panic and unwrap

PR Info

Closes https://github.com/SeaQL/sea-orm/issues/1023

Breaking Changes

[x] Added InnerConnection::Disconnected
[x] Changed return type of DatabaseConnection::as_mock_connection(&self) -> Result<&MockDatabaseConnection, DbErr>
[x] Changed return type of MockDatabaseTrait's and MockDatabaseConnection's begin(&self) -> Result<(), DbErr>
[x] Changed return type of MockDatabaseTrait's and MockDatabaseConnection's commit(&self) -> Result<(), DbErr>
[x] Changed return type of MockDatabaseTrait's and MockDatabaseConnection's rollback(&self) -> Result<(), DbErr>

Changes

[x] Added DatabaseConnection::try_into_transaction_log()
[x] Implemented From<DbErr> for TransactionError<E>

Please review!

Looks good for what this PR changed.

Looks good for what this PR changes

This PR mostly touches the Connection and Mock API, I think there might be other places to cleanup too?

This PR mostly touches the Connection and Mock API, I think there might be other places to cleanup too?

Yes, but I think we can leave them as-is:
20 results - 10 files

src/entity/active_model.rs:
  168              }
  169:             _ => panic!("The arity cannot be larger than 6"),
  170          }

  812              ActiveValue::Set(value) | ActiveValue::Unchanged(value) => value,
  813:             ActiveValue::NotSet => panic!("Cannot unwrap ActiveValue::NotSet"),
  814          }

  844              ActiveValue::Set(value) | ActiveValue::Unchanged(value) => value,
  845:             ActiveValue::NotSet => panic!("Cannot borrow ActiveValue::NotSet"),
  846          }

src/entity/base_entity.rs:
  270              } else {
  271:                 panic!("primary key arity mismatch");
  272              }

  274          if keys.next().is_some() {
  275:             panic!("primary key arity mismatch");
  276          }

  837              } else {
  838:                 panic!("primary key arity mismatch");
  839              }

  841          if keys.next().is_some() {
  842:             panic!("primary key arity mismatch");
  843          }

src/executor/cursor.rs:
  95                  .add(f(c1, v1)),
  96:             _ => panic!("column arity mismatch"),
  97          }

src/executor/execute.rs:
  48              ExecResultHolder::SqlxPostgres(_) => {
  49:                 panic!("Should not retrieve last_insert_id this way")
  50              }

  54                  if last_insert_rowid < 0 {
  55:                     panic!("negative last_insert_rowid")
  56                  } else {

src/query/combine.rs:
  49                              ColumnRef::Asterisk | ColumnRef::TableAsterisk(_) => {
  50:                                 panic!("cannot apply alias for Column with asterisk")
  51                              }

  58                                  ColumnRef::Asterisk | ColumnRef::TableAsterisk(_) => {
  59:                                     panic!("cannot apply alias for AsEnum with asterisk")
  60                                  }

  62                              _ => {
  63:                                 panic!("cannot apply alias for AsEnum with expr other than Column")
  64                              }
  65                          },
  66:                         _ => panic!("cannot apply alias for expr other than Column or AsEnum"),
  67                      };

src/query/delete.rs:
  115                  }
  116:                 ActiveValue::NotSet => panic!("PrimaryKey is not set"),
  117              }

src/query/helper.rs:
  585          }
  586:         _ => panic!("Owner key and foreign key mismatch"),
  587      }

src/query/insert.rs:
  136              } else if self.columns[idx] != av_has_val {
  137:                 panic!("columns mismatch");
  138              }

src/query/update.rs:
   99                  }
  100:                 ActiveValue::NotSet => panic!("PrimaryKey is not set"),
  101              }

src/schema/entity.rs:
  49      if matches!(backend, DbBackend::MySql | DbBackend::Sqlite) {
  50:         panic!("TypeCreateStatement is not supported in MySQL & SQLite");
  51      }

  59          ColumnType::Enum { name, variants } => (name.clone(), variants.clone()),
  60:         _ => panic!("Should be ColumnType::Enum"),
  61      };

Yeah all of them seems to be in the "Misuse of API" category

Except this one:
  54                  if last_insert_rowid < 0 {
  55:                     panic!("negative last_insert_rowid")
  56                  } else {

Which should either be unreachable or an Runtime error.

Just checked the docs, https://www.sqlite.org/c3ref/last_insert_rowid.html, I think it can only return 0

Can remove the doc /// - SQLite last insert row id might be negative integer, in this case it will panic too?

Just checked the docs, https://www.sqlite.org/c3ref/last_insert_rowid.html, I think it can only return 0

But why SQLx method return i64? https://docs.rs/sqlx/latest/sqlx/sqlite/struct.SqliteQueryResult.html#method.last_insert_rowid

But why SQLx method return i64?

That's another question

It's just a wrapper around the SQLite library in C
https://github.com/launchbadge/sqlx/blob/76ae2865005cc79d56972d68d3be30805581103d/sqlx-core/src/sqlite/connection/handle.rs#L58

This PR should goes after all other feature updates

Ah sad, after a third thought I think InnerConnection::Disconnected is unnecessary

While converting unwrap into expect is always good, even better if we can make it an Err if the surrounding function is a Result.
But I don't think this PR should change API interfaces from returning nothing into Result.

There are too many breaking changes stapled together, which is risky. Can we avoid all breaking changes, if possible?

Sure! Check again :D

This is still a LOT of changes and hopefully I did not miss a fine detail


Month update, event dot update

Hi,
Is there any way to update days dot marker before loading a month?
Thanks!

Hello @marcpages,
Could you please more explicit? I don't completely understand the thing you're talking about.
Regards,
Eugene

When you swipe right or left to change the month view, is there any way to update the day event dot marker before loading the next month? I mean a delegated function called before the month is loaded.
Thanks

Dot markers are being created at the time of MonthView setup. I could provide a method notifying when a dot marker is being created. But I still don't understand what you're trying to do to be capable of predicting the best way of designing the feature.
Thus it would have a sense if you provided me with an idea you want to reach.

I've this function:
func dotMarker(shouldShowOnDayView dayView: CVCalendarDayView) -> Bool {
        let day : Int? = dayView.date?.day
        if contains(self.daysWithDotArray, day!) {
            return true
        } else {
            return false
        }
    }

and I want to update daysWithDotArray when you change month and before any day is created.
Thanks

Hello @marcpages,
Sorry for not replying for so long. It isn't that clear still. As well as I understand, you have an array with days you're planning to mark with dots. So if there is something wrong with a practical month you can simply get the month with a CVDate instance and then check whether it's optimal for your purpose or not.
What I mean is that the issue is unlikely inside of CVCalendar. If I'm mistaken try to explain it more explicitly. Hope it helps!
Regards,
Eugene

Hello, thanks for your answer, it was my fault, I've managed to make it work. I've another question, this function:  commitCalendarViewUpdate()  is only for initializing the calendar or also for updating it? Because when I call it coming from another view the calendar goes wrong.
Thanks

Hello @marcpages,
commitCalendarViewUpdate() should be called only once when your view is firstly appeared. The demo works a little bit wrong since it doesn't check whether it has been already committed an update or not. I'll update demo project and documentation with the new release.
For now just check and ensure the method is called once.
Regards,
Eugene

Perfect, thank you.


Excuse me, first of all thank you for the tool. When I synchronize, I always get an error at this location, how can I troubleshoot it.

poetry run python -m strava_to_fittrackee.s2f --sync -v 2
DEBUG:s2f:Current API usage -- 15 minute: 56/200 -- daily: 339/2000
DEBUG:s2f:Writing Strava activity gpx to /tmp/tmpdriwgwl9/8234648116.gpx
INFO:s2f:Uploading workout 1 of 146 to FitTrackee
DEBUG:s2f:Uploading /tmp/tmpdriwgwl9/8234648116.gpx to FitTrackee
INFO:s2f:Rewriting GPX file without comment field
DEBUG:s2f:POSTing /tmp/tmpdriwgwl9/8234648116.gpx to FitTrackee
Traceback (most recent call last):
  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/opt/strava-to-fittrackee/strava_to_fittrackee/s2f.py", line 1189, in <module>
    sync_strava_with_fittrackee()
  File "/opt/strava-to-fittrackee/strava_to_fittrackee/s2f.py", line 1142, in sync_strava_with_fittrackee
    fittrackee.upload_gpx(temp_file)
  File "/opt/strava-to-fittrackee/strava_to_fittrackee/s2f.py", line 884, in upload_gpx
    r.raise_for_status()
  File "/root/.cache/pypoetry/virtualenvs/strava-to-fittrackee-MJ8iXs7D-py3.10/lib/python3.10/site-packages/requests/models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 413 Client Error: Request Entity Too Large for url: https://fit-track.writely.xyz/api/workouts
DEBUG:s2f:Removing <TemporaryDirectory '/tmp/tmpdriwgwl9'>
DEBUG:s2f:Removing /opt/strava-to-fittrackee/strava_to_fittrackee/s2f.pid

I found the solution, nginx limits the file upload size.


cleaned up some data integrity issues

encoded UTF-8, fixed lines that begin with NOT a year, fixed some other data integrity issues. now imports cleanly with read.csv data.table::fread or readr::read_csv.

more to be done here to make it truly tidy, but this is a start.

Awesome - thanks, Stephen

I found a few more things here, under "data integrity issues".
http://rpubs.com/turnersd/daily_show_guests
I'll put in another PR if I get around to whipping this into shape. I might use this for teaching at some point.
Thanks for making it public!


Bug: Duplicate items possible

What happened?
If the user reconnects to an existing seed by connecting through the mod options menu and then loading the save slot afterwards, some/all? items will be received again. Not sure why this is happening so needs more investigation.
What were the expected results?
Only items received since last connection should be received. This doesn't cause any issues with the single use items, but can cause issues with power seals and time shards being duplicated.
Is this reproducible?
No response

Rewrote the saving method so this should hopefully be fixed.


Updated README.md

Fixed the markdown form. The links are going to 404's. Hopefully this helped some!
https://github.com/vladmandic/pigallery/blob/master/'docs/client-server.md'
This ^ is wrong because the server is not used to the files having **'**s. This commit should fix that.

silly mistake on my part, thanks for the PR

Your very welcome. Np :3


How to process video data into the form of new_k400?

I want to resize my custom video data  to the short edge size of 320 like new_k400, but I am only familiar with the python. Do you have any good suggestion? Or maybe you can tell me how do you process the origin k400 data to the new_k400. Thanks a lot.

I notice that you have downloaded the videos from BaiduYun. They have been resized to the short edge size of 320! You just need to run the training.

For your training data, you do not need to resize them. Resizing 320 is for faster loading. If your data size is small, you do not need to resize them. To resize video, you can follow MMAction2.


Add sagan back

I temporarily removed sagan integration to get Finchley.M3 releaser builds green.
See 947ad0a2780cfafb066d86b3f401c839a46238f6

Reverted https://github.com/spring-cloud/spring-cloud-release-tools/commit/7521f85236aa639953adadde9e8d6199c59a214c


Make retention configurable

I see that retention/limits for OnMyMac accounts have seen some attention lately. I'd like to suggest that perhaps this could be configurable on the accounts preference pane?
When I added a feed a couple of months ago there 10 articles, I was quite surprised to open NNW today and see all but one had been deleted. I was slowly making my way through them! All 10 are still in the actual RSS feed.
Personally my preference would be never automatically delete; back of napkin the DB should grow about 50MB per decade for me, which is perfectly fine.
Version 5.0.3 (2618)

Sorry to bump an old issue but I'd just like to bring attention to it again, I think the cutoff date should be configurable by the user and not hard coded to 30 days, I'd much rather sacrifice storage than have things deleted without me knowing.

it would be great to allow users to set retention policy eg  24 hours, 7 days 14 days 30 days ...
some online communities can have hundreds of posts per day for example popular github repo feeds and subreddits


fix: experience tweaks

Closes #16
Closes #15
Closes #13

:tada: This PR is included in version 1.7.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v1.7.2
v1.7.2

Your semantic-release bot :package::rocket:


AAC payload fragmentation

If the size of the RTP packet exceeds writing MTU, the RTP payload should be fragmented. According to the RFC 3016, fragmentation of the audioMuxElement requires no extra header - the payload should be fragmented and spread across multiple RTP packets. However, such an implementation seems not to work correctly.
Any help will be much appreciated.

This was annoying me, as AAC sounds great streamed from a Pi Zero W, but the (rare) dropouts messed it up.
I think I kind of worked around it by setting the AAC bitrate field to 160kbps and enabling CBR mode. VBR doesn't make much sense when you've got a fixed bitrate channel, anyway - just use all of the bandwidth available.
Doesn't fix the fragmentation code of course, but makes AAC much more usable, based on an evening of testing with a single pair of headphones.

(Doubt it's the root cause but...) should this be:
rtp_header->markbit = len <= payload_len_max;

@olliewalsh You're right, it's not a cause :) But yeahh... this line is buggy :D Nice catch! It should definitely read:
rtp_header->markbit = payload_len <= payload_len_max;
or:
rtp_header->markbit = len == payload_len;
whatever one desires :).
@pyntofmyld It is indeed possible to disable VBR mode (just let other device know, that we are not supporting it), because sink IO thread is not prepared for fragmented frames as well... However, right now I'd rather have buggy version of AAC, just for the sake of reminding me of this issue. The more I'm frustrated, the more I'm determined to find a way to fix it :)


Auto adjust value label of LineBar chart

When use horizontal line/bar chart label of axis y will be covered by board as below :

And also right margin is a little big for one value axis


Why bal-tag does not have white space breaks?

I am wondering if there is a reason, that the bal-tag does not break when the text inside is too big for the screen. see screenshot:

add new prop multi-lines which removes the max height and breaks.
if possible lets add ellipsis in the default when it goes out of the viewport

tested with the newest version and it worked


MAINT rejigger empyrical imports, pt. 2

Closes #425
Mostly @jameschristopher's work, I just implemented @twiecki's suggestion to add functions to call their empyrical counterparts and add a deprecation warning.
There were some merge conflicts with perf_attrib.py, I just went for the version that was on master branch right now, as this PR is pretty old.
@yankees714 @richafrank ready for engineering review

Builds passing, but Py3.4 is timing out. This is starting to become an issue: I'll file an issue for this.

let's just remove 3.4.
On Aug 30, 2017 7:03 PM, "George Ho"<EMAIL_ADDRESS>wrote:

Builds passing, but Py3.4 is timing out. This is starting to become an
issue: I'll file an issue for this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/quantopian/pyfolio/pull/436#issuecomment-326055439,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AApJmAect6kM1AdYDR9PWmlyVnNd8slWks5sdZXegaJpZM4PHnND
.

done! 👍

Thanks @eigenfoo! Just editing the string and we can merge.

Done! Ready to merge

Awesome, thanks a bunch!

Actually need to fix the """ to " before.

Don't """ make multi-line strings in python? https://stackoverflow.com/questions/10660435/pythonic-way-to-create-a-long-multi-line-string
I'll fix it anyways, though

It does create multi-line strings but that's not what we want. It would also include the indents which is the main problem.


Refactor HRUState so that it prints only relevant state variables

This is a breaking change.
Change the signature of HRUState.
Instead of HRUState(soil0=10), we now write HRUState(data={"SOIL[0]": 10}).
Knowing which variables are specified, we're able to only put those in the rvc. This avoids warnings of initial conditions for state variables not in model. I think it's also a better design become the variable names are identical to those in the RavenC documentation.

@ldajab This will avoid having to redefine the RVC template.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

41 of 41 (100.0%)  changed or added relevant lines in 12 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 87.816%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
5182

Relevant Lines:
5901

💛  - Coveralls


feat: support virtual sharding and stream failure processing (#1261)

Issue #, if available:
Description of changes:
Release v1.16.0
Description of how you validated changes:
Checklist:

[ ] Write/update tests
[ ] make pr passes
[ ] Update documentation
[ ] Verify transformed template deploys and application functions as expected
[ ] Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1262 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1262      +/-   ##
==========================================
+ Coverage   94.41%   94.42%   +<.01%
==========================================
  Files          71       71
  Lines        3619     3624       +5
  Branches      714      714
==========================================
+ Hits         3417     3422       +5
  Misses        103      103
  Partials       99       99

Impacted Files
Coverage Δ

samtranslator/model/lambda_.py
88.46% <ø> (ø)
:arrow_up:

samtranslator/model/eventsources/pull.py
94.64% <100%> (+0.52%)
:arrow_up:

samtranslator/__init__.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf5720d...39ad59f. Read the comment docs.


{Network} network application-gateway waf-policy custom-rule create/update: add params

Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Network


[PROJECT] Temperature Converter Website

I want to add a Temperature Converter Website made using HTML, CSS, and JavaScript.
It converts temperature to and from Celsius, Fahrenheit, and Kelvin.

@Shreyaar12 Please assign this issue to me under GSSOC'23.


Feature/883

#883

This is currently compared with feature/875 since it builds on that. I will rebase once that branch is merged.

Review Notes
As discussed previously it is not possible with CSS alone to style the expanded part of a select element.
View http://localhost:3030/form to see the select variations at the top of the page. Matches specs at https://zpl.io/2GDAZ9V.

@LeoT7508 This is ready for design review. Branch is feature/883.


How to get identity transform?

Good day! Subj

If you mean that you don't want to change images, then you can just use Noop, e.g.
seq = iaa.Noop()
images_aug = seq.augment_images(images)

then images_aug contains a copy of images.
Most other augmenters also default to do nothing if no parameters are provided. E.g. Affine() should not change images.

Thank you!


Part-5: Fix Offset Handling and Effective Time Filter + Enable Group-By Expressions + Add Unit Tests and Minor Cleanup

This PR fixes offset handling and the effective filter that's generated, and also adds some unit-tests.

Offset handling is fixed by fixing the unit to seconds in the LeafTimeSeriesPlanNode. The offset will then be converted to the unit of the time-column at every other place (when creating effective filter and when reading the time-values from the segment).
Enables group-by expressions. We are now not limited to just column names. This can be seen in one of the tests for compileQueryContext.
Added unit-tests for effective filter and the QueryContext compilation
Minor cleanup of engine/language renaming.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (59551e4) to head (fa88c1d).
Report is 1097 commits behind head on master.

:exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (fa88c1d). Click for more details.
HEAD has 53 uploads less than BASE

Flag
BASE (59551e4)
HEAD (fa88c1d)

integration
7
1

integration2
3
1

temurin
12
1

java-21
7
1

skip-bytebuffers-true
3
1

skip-bytebuffers-false
7
0

unittests
5
0

unittests1
2
0

java-11
5
0

unittests2
3
0

integration1
2
0

custom-integration1
2
0

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #14104       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436        3     -2433
  Lines        133233        6   -133227
  Branches      20636        0    -20636
=============================================
- Hits          82274        0    -82274
+ Misses        44911        6    -44905
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <ø> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <ø> (ø)

java-11
?

java-21
0.00% <ø> (-61.63%)
:arrow_down:

skip-bytebuffers-false
?

skip-bytebuffers-true
0.00% <ø> (-27.73%)
:arrow_down:

temurin
0.00% <ø> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Proper button rendering in IE8

Fixes #781

@amsul can you take a look at this?

This has been open for over a year now. Is this ever gonna get merged? Otherwise we might want to close it once and for all...

lgtm
Thanks for your contribution 👍


.codecov.yml: reduce root rather than move it

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you successfully run brew tests with your changes locally?

reduce root rather than move it
This is attempt number 2 since the first attempt at a fix seems to have failed.
CC @reitermarkus @MikeMcQuaid

Closing this as it seems the first PR, once it took effect, is good enough.


Adds Pair API

Coverage remained the same at 100.0% when pulling 0482a5a106369c35c465ab5cefdac18cbd1264a3 on rstegg:pair-api into 9b29c669830ef1c8219fd63aa55bf2d6c9fead43 on evilsoft:docs.

Coverage remained the same at 100.0% when pulling 2d655dda2a44498a95e1c95ec72d5d38f75d0050 on rstegg:pair-api into 9b29c669830ef1c8219fd63aa55bf2d6c9fead43 on evilsoft:docs.

Coverage remained the same at 100.0% when pulling 2d655dda2a44498a95e1c95ec72d5d38f75d0050 on rstegg:pair-api into 9b29c669830ef1c8219fd63aa55bf2d6c9fead43 on evilsoft:docs.

Coverage remained the same at 100.0% when pulling ea0e165ad7cf900e7a0d16e193deae22e1a839bf on rstegg:pair-api into 9b29c669830ef1c8219fd63aa55bf2d6c9fead43 on evilsoft:docs.

Coverage remained the same at 100.0% when pulling 59494a1f6a924a6365074644ef05ab87ec7127d8 on rstegg:pair-api into 9b29c669830ef1c8219fd63aa55bf2d6c9fead43 on evilsoft:docs.

Coverage remained the same at 100.0% when pulling 4e1d1e28639be18044486b08d4f7149005b8afbc on rstegg:pair-api into 9b29c669830ef1c8219fd63aa55bf2d6c9fead43 on evilsoft:docs.


set sparklyr.do.implicit.dot to FALSE

@kevinushey:
I think setting this to TRUE makes this feature a bit harder to use, for instance, I was helping someone troubleshoot:
iris_tbl %>% group_by(Species) %>% do(other = "x")

The other user we know of was following this guide: https://cran.r-project.org/web/packages/dplyr/dplyr.pdf which also uses explicit . so I can't find a good example at the moment where people would expect to pass . implicitly, thoughts?

The intention of that option was to support syntax of the form:
  S <- diamonds_tbl %>%
    group_by(color, clarity) %>%
    do(model = ml_linear_regression(price ~ x + y + z))

But I'm thinking this was probably misguided so maybe we should just remove that option altogether. We should likely amend the ml_ interfaces so that the following works:
  S <- diamonds_tbl %>%
    group_by(color, clarity) %>%
    do(model = ml_linear_regression(price ~ x + y + z, data = .))

(or something similar?)

I'm just going to remove the implicit do stuff on mater -- we can close this PR.


"Add as Link" support

Hi, I'm having trouble with files added to a csproj as a link, they do not show up in VS Code, not in this extension or even natively.
    <Content Include="..\..\..\..\..\Source\BES.D365\CrmPackage\WebResources\bes_\Script\Core\D365.Core.js">
      <Link>Javascript\D365.Core.js</Link>
    </Content>

Can we have the links show up in the solution explorer same as they do in Visual Studio.
Currently there is no way to have the files show up in VS Code other than creating windows file/folder links via shorcuts.
Problem is, we have a sandbox enviroment the code goes into that does not allow any 3rd party assemblies to be referenced, thus we link the files as part of the assembly. There files are however generic and used in multiple places, syncing or copying the content quickly becomes a mess.

Possible same solution as #57 but on a project file level.

Closing this as it seems to be added.


Xenops is not compatible with auctex (13.1.4)

I use xenops in org-mode.
(add-hook 'org-mode-hook #'xenops-mode)

It looks like Xenops is not working with the new version of auctex (13.1.4)?

Hi @LuminaDCIX, can you post the errors that you're getting?

Hi!
I didn't encounter significant errors. But the xenops-related commands all fail (e.g. xenops-increase-size). The rendering of formulas also gets stuck for a while, as if xenops-mode is not turned on. Emacs seems to still be using auctex for latex preview.

I finally found out that it was a problem with org-fragtog. Thx

OK, excellent, happy you got to the bottom of that.


Is it possible to add Autocomplete entries on the go?

I'm working on an app where users have to put people names on it. I want to let them put one of the suggested by autocompletion, but let them put names that aren't suggested. And, in this case, add this new name to the suggestion list.
Is that possible? I didn't manage myself to do it.
Thanks in advance!
Edit: It's in fact possible, putting an ArrayList inside RecyclerViewPresenter.

cannot make 2 Autocomplete in one class ?
ive tried it but error on with(presenter) and with(callback)


fix: Handle Int64 from duplicate dependencies

Added IInt64 interface and type check.
Description
Fixes:

Fixes for Int64 created from a buffer and offset.
Fix negative check for toDecimalString() (bit operations on numbers from the buffer are 32-bit, not 8-bit).
Add tests and handling for NaN, Infinity, and -Infinity when setting the Int64 value from number(s).

Updates because it already uses Buffer:

Re-implement many of the number methods using Buffer number methods instead of byte by byte implementations.
Remove _2scomp() method that looks like it was intended to be private but ended up being used in the compact protocol.
Handle the -1 case in the compact protocol without using _2scomp().

Motivation and Context
When multiple packages depend on @creditkarma/thrift-server-core, they may have different versions. This results in duplicates in different node_modules paths. Some may even be the same version but if there is not a common parent version they may be split between different siblings.
The instanceof check between these different instances of Int64 is false. The serialization checks for instanceof Int64 and fails.
Switch to an interface and more flexible type check. The Buffer type is the Node type and should match instanceof Buffer across packages.
While making the fixes, I started adding tests because test coverage was poor. In doing so I found more issues and ended up making more fixes. It's possible to make a smaller PR just for the instanceof Int64 issue if desired.
How Has This Been Tested?
Tested end-to-end in a service.
Much improved unit test coverage.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)
Removed the _2scomp() export which probably should not have been exported in the first place.

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

The lint formatting rules are very aggressive. Some of the files I did not change manually. I can try to restore them and hope lint won't reformat them again.


Sensu not connecting to Redis Sentinel Cluster

Hey there,
we are using Sensu with a cluster of 3 Redis nodes per Datacenter where each node is working as Sentinel.
The cluster itself is working as expected and also replication of Master <==> Slave is working flawless just as the failover is working fine.
But for a reason we don't know, Sensu cannot connect to the Redis Sentinels and thus is not connecting to the Redis master and thus not starting up.
Here is our config for /etc/sensu/conf.d/redis.json
{   "redis": {     "sentinels": [       {         "host": "sensuredis38-1.sensitive.info",         "port": 26379       },       {         "host": "sensuredis38-2.sensitive.info",         "port": 26379       },       {         "host": "sensuredis38-3.sensitive.info",         "port": 26379       }     ]   } }
As I said Sentinels and Redis itself is working without problems but if you need config form there, let me know
Additional info:
We are on Sensu version 0.23.2-1
We are on Redis-server version 2.8.17-1~bpo70+2
Operating System is Debian 7.8 on the Redis machines and Ubuntu 14.04.2 on the Sensu-servers

I also have the same issue. The setup is prerry much the same, but I am using embedded ruby. Logfiles dont say much ...

oh yeah here’s the last log entries form sensu-server and sensu-api log
{"timestamp":"2016-04-27T13:20:15.396154+0200","level":"warn","message":"loading extension files from directory","directory":"/etc/sensu/extensions"} {"timestamp":"2016-04-27T13:20:15.396274+0200","level":"warn","message":"loaded extension","type":"mutator","name":"ruby_hash","description":"returns ruby hash event data"} {"timestamp":"2016-04-27T13:20:15.396345+0200","level":"warn","message":"loaded extension","type":"mutator","name":"json","description":"returns JSON formatted event data"} {"timestamp":"2016-04-27T13:20:15.396413+0200","level":"warn","message":"loaded extension","type":"mutator","name":"only_check_output","description":"returns check output"} {"timestamp":"2016-04-27T13:20:15.396506+0200","level":"warn","message":"loaded extension","type":"handler","name":"debug","description":"returns raw event data"} {"timestamp":"2016-04-27T13:20:15.413891+0200","level":"debug","message":"connecting to redis","settings":{"sentinels":[{"host":"sensuredis38-1.sensitive.info","port":26379},{"host":"sensuredis38-2.sensitive.info","port":26379},{"host":"sensuredis38-3.sensitive.info","port":26379}]}}
it is the same entry for both

@RiRa12621 do the Redis Sentinel logs show connections? Are the Sensu instances able to reach Sentinel? e.g. telnet sensuredis38-2.sensitive.info 26379

telnet works for all the instances
the sentinel logs only show that it starts up and detects all slaves and master but nothing about sensu connecting

@RiRa12621 perhaps reduce the configured sentinels in Sensu to be a single node and use something like tcpdump to confirm an attempt is made?

@RiRa12621 any additional information that you can provide is much appreciated :+1:

@portertech i did that for testing
so i shrinked the config to the following:
{   "redis": {         "sentinels": [         {                 "host": "sensuredis38-3.sensitive.info",                 "port": 26379         }         ]   } }
and did a tcpdump to confirm it’s attempting to connect
[root@sensu38-2:~]# tcpdump | grep 26379
tcpdump: verbose output suppressed, use -v or -vv for full protocol decode
listening on eth0, link-type EN10MB (Ethernet), capture size 65535 bytes
17:33:53.048541 IP sensu38-2.sensitive.info.52796 > sensuredis38-3.sensitive.info.26379: Flags [P.], seq<PHONE_NUMBER>:2675061329, ack<PHONE_NUMBER>, win 238, options [nop,nop,TS val 851339016 ecr 19275683], length 62
17:33:53.048857 IP sensuredis38-3.sensitive.info.26379 > sensu38-2.sensitive.info.52796: Flags [P.], seq 1:6, ack 62, win 227, options [nop,nop,TS val 19275933 ecr 851339016], length 5
17:33:53.048874 IP sensu38-2.sensitive.info.52796 > sensuredis38-3.sensitive.info.26379: Flags [.], ack 6, win 238, options [nop,nop,TS val 851339016 ecr 19275933], length 0
17:33:53.134514 IP sensu38-2.sensitive.info.52799 > sensuredis38-3.sensitive.info.26379: Flags [P.], seq<PHONE_NUMBER>:2262169349, ack<PHONE_NUMBER>, win 238, options [nop,nop,TS val 851339037 ecr 19275705], length 62
17:33:53.134881 IP sensuredis38-3.sensitive.info.26379 > sensu38-2.sensitive.info.52799: Flags [P.], seq 1:6, ack 62, win 227, options [nop,nop,TS val 19275955 ecr 851339037], length 5
17:33:53.134907 IP sensu38-2.sensitive.info.52799 > sensuredis38-3.sensitive.info.26379: Flags [.], ack 6, win 238, options [nop,nop,TS val 851339038 ecr 19275955], length 0
17:33:54.049187 IP sensu38-2.sensitive.info.52796 > sensuredis38-3.sensitive.info.26379: Flags [P.], seq 62:124, ack 6, win 238, options [nop,nop,TS val 851339266 ecr 19275933], length 62
17:33:54.049545 IP sensuredis38-3.sensitive.info.26379 > sensu38-2.sensitive.info.52796: Flags [P.], seq 6:11, ack 124, win 227, options [nop,nop,TS val 19276183 ecr 851339266], length 5
17:33:54.049562 IP sensu38-2.sensitive.info.52796 > sensuredis38-3.sensitive.info.26379: Flags [.], ack 11, win 238, options [nop,nop,TS val 851339266 ecr 19276183], length 0

Yeah I will try to provide us much as possible but it’s like we really don’t get to much out of the logs after all .
As I said: telnet connects
and if i connect sensu directly to redis with host and port and without sentinel, it also works flawlessly

@RiRa12621 did you use a different Redis master name? Default name is "master".

We definitely need to add more logging to the Redis client :+1:

@portertech yes we did use a different master name “node01”

@RiRa12621 you need to add "master": "node01" to your Redis definition (top level).

@calebhailey this is missing from the Redis docs.

@portertech noted. I'll add that ASAP.

@calebhailey :boom:

@RiRa12621 you'll want to ensure that your master name remains consistent.

{
  "redis": {
    “master”: “Name-of-master”,
    "password": "your_redis_password",
    "sentinels": [
      {
        "host": "<IP_ADDRESS>",
        "port": 26379
      },
      {
        "host": "<IP_ADDRESS>",
        "port": 26379
      },
      {
        "host": "<IP_ADDRESS>",
        "port": 26379
      }
    ]
  }
}

so it is supposed to be like this?
but then this is the opposite of the documentation where it says that sensu is self discovering the master via sentinels.
as of here”
to use the HA Redis configuration, they must be configured to query Redis Sentinel for the current Redis master connection information (host and port).

@RiRa12621 the Redis client queries Sentinel for a master from the master group, which actually defaults to "mymaster". The master key should probably be changed to master_group.

ok, fine it’s just a matter of documentation then.
it’s working if i change the config like this.
Thx a lot for the very quick help!

bravo!! but redis client output is still non existent ;)
thanks!

@RiRa12621 @lgarciaaco great! We'll be tracking Redis logging improvements @ https://github.com/sensu/sensu-redis/issues/1 and updating the Redis configuration documentation!

Tracking documentation changes here: https://github.com/sensu/sensu-docs/issues/380

This has been documented here: https://sensuapp.org/docs/latest/reference/redis.html#redis-attributes


Add rel=nofollow to generated markdown hyperlinks, fixes #1185

To discourage SEO spam we generate rel="nofollow" in the hypertext link
for project_homepage_url and project_repo_url. We should do that for all
user-provided data.  This commit eliminates a missing case, namely,
do this with markdown data from users in the project badge entry page.
Signed-off-by: David A. Wheeler<EMAIL_ADDRESS>

LGTM


Fix inductive-implicits benchmark

The inductive-implicits benchmark fails on the benchmarks machine since April 2024:

This should have been caught by the tests at:
https://github.com/scala/scala3/blob/912b6f278b0fe5e7a25160612922cadf184acdbb/compiler/test/dotty/tools/dotc/BootstrappedOnlyCompilationTests.scala#L30
When I run scala3-bootstrapped / testOnly dotty.tools.dotc.BootstrappedOnlyCompilationTests -- *posMacros locally, the tests are indeed failing and the following error is printed:
64 |  val sel = Selector[L, Boolean]
   |                                ^
   |No given instance of type shapeless.Selector[Test.L, Boolean] was found for parameter selector of method apply in object Selector.
   |I found:
   |
   |    shapeless.Selector.inTail[Int,
   |      Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int ::
   |         Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int
   |         :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int ::
   |        Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int
   |        :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int ::
   |        Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: ...Int :: ... :: ... :: ...,
   |    Boolean](
   |      shapeless.Selector.inTail[Int,
   |        Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int
   |          :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int ::
   |           Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int ::
   |          Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int ::
   |          Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int ::
   |          Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: ...Int :: ... :: ... :: ...,
   |      Boolean](
   |        shapeless.Selector.inTail[Int,
   |          Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int ::
   |            Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int ::
   |            Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int ::
   |            Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int ::
   |            Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int ::
   |            Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: ...Int :: ... :: ... :: ...,
   |        Boolean](

...

   |            )
   |          )
   |        )
   |      )
   |    )
   |
   |But method inTail in object Selector does not match type shapeless.Selector[
   |  Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int :: Int ::
   |     Boolean :: shapeless.HNil,
   |Boolean].
   |
   |Note: method inTail in object Selector was not considered because it was not imported with `import given`.

It is not clear to me why the test does not fail on the CI. I checked that dotty.tools.dotc.BootstrappedOnlyCompilationTests.posMacros indeed runs there, and I confirm it is the case.
Anyway, the fix is simple, we just need to import the implicits explicitly.
This PR additionally removes the duplicate tests/pos-deep-subtype/inductive-implicits-bench.scala.

After having a deeper look with @hamzaremmal, we found that importing the given should actually is not needed; the last line of the error message is incorrect. However, importing explicitly the given apparently diminishes the required stack size, which why it made the test on my machine. This explains why the test was not failing on the CI: the stack size was sufficient there.
I pushed a new fix which comments out some more lines of the summoned implicit argument type.

For the record, here is an other error I got for the same benchmarks while working on another branch, with the import in the object:
object Test extends App {
  import Selector.given
  val sel = Selector[L, Boolean]
  ...

  Exception while compiling tests/bench/inductive-implicits.scala

  An unhandled exception was thrown in the compiler.
  Please file a crash report here:
  https://github.com/scala/scala3/issues/new/choose
  For non-enriched exceptions, compile with -Xno-enrich-error-messages.

     while compiling: <no file>pped / Test / testOnly 11s
        during phase: parser
                mode: Mode()
     library version: version 2.13.15
    compiler version: version 3.6.3-RC1-bin-SNAPSHOT-git-924ea08
            settings: -Xsemanticdb true -Xunchecked-java-output-version 9 -Xverify-signatures true -Ycheck List(all) -Yforce-sbt-phases true -Yno-double-bindings true -classpath /Users/mbovel/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/org/scala-lang/scala-library/2.13.15/scala-library-2.13.15.jar:/Users/mbovel/dotty/library/../out/bootstrap/scala3-library-bootstrapped/scala-3.6.3-RC1-bin-SNAPSHOT-nonbootstrapped/scala3-library_3-3.6.3-RC1-bin-SNAPSHOT.jar:out/compilePosMacros/bench/inductive-implicits -color never -d out/compilePosMacros/bench/inductive-implicits -indent true -pagewidth 120

java.lang.StackOverflowError
        at dotty.tools.dotc.core.Scopes$MutableScope.enterAllInHash(Scopes.scala:310)
        at dotty.tools.dotc.core.Scopes$MutableScope.enterAllInHash(Scopes.scala:310)
        at dotty.tools.dotc.core.Scopes$MutableScope.enterAllInHash(Scopes.scala:310)
        at dotty.tools.dotc.core.Scopes$MutableScope.enterAllInHash(Scopes.scala:310)
        at dotty.tools.dotc.core.Scopes$MutableScope.enterAllInHash(Scopes.scala:310)
        at dotty.tools.dotc.core.Scopes$MutableScope.enterAllInHash(Scopes.scala:310)
        ...

Here the stack overflow error is not caught and crashes the compiler.


[Question] Is there a way to get not translated Strings?

Hi,
If my completed translation file is intl_en.arb, is there a way to find differences or generate a file with not translated strings?

Hi @selankon
Could you give more context to the question so I can fully understand it?
You want to find differences between what two states/files?

Hi,
Yes sorry for the bad explanation.
I mean when you add Strings to intl_en.arb, for example, but this strings doesn't exists on intl_es.arb.
Example,  intl_en.arb:
{
  "@@locale": "en",

  "tabsLocal": "Local",
  "tabsTags": "Tags",
  "tabsExplore": "Explore",
  "tabsFollowing": "Following",
}

And  intl_es.arb:
{
  "@@locale": "es",

  "tabsLocal": "Local",
  "tabsTags": "Tags",
}

I want to find a way to get that the strings tabsExplore and tabsFollowing are not translated on the file  intl_es.arb.

Ok, I get it now.
Currently, you can compare the files using IDE to spot such differences among them.
Or you can integrate with Localizely for more advanced features.

Ok thanks for your answer.
I was looking something more like this from the  intl 0.17.0 package generate a file with all the strings that need translation.

Neither anything to extract strings that are not internationalized?
Thanks


feat: enable output of global changelog

Hi all! I'd been meaning to work on functionality mentioned in #200, #264, and #387 for awhile now, and finally had a chance to take a look. I wanted to open this as a draft to get some feedback on this approach, as something feels off to me about this.
As of right now, this functionality is attached to the version command by means of the --globalChangelog flag, which naively places CHANGELOG.md at the root of cwd. I've tested this with the chakra-ui repo, so I can verify that it works correctly. You can see the output of that here: https://gist.github.com/with-heart/ebdb9e9e74b3f84e221111d12c3723ca
Changes

Modified generateMarkdown to return {title: string, body: string} rather than string. This was needed because title is normally ## X.Y.Z in the individual packages, but we'd want this to be<EMAIL_ADDRESS>in a global changelog similar to how it works with "Version Packages" PRs.
Modified existing individual package changelog generation within applyReleasePlan to utilize above change in data shape
Added a new section to applyReleasePlan that combines the individual changelogs into a single CHANGELOG.md

Questions/Issues

Does it still make sense to start by collecting changelogs as markdown?

#200 mentions outputting a "'release info' thing", but it seems weird to me that the output of this would be a markdown file, which is a fairly static piece of output instead of something like a json file. In my mind, a nice opportunity for refactoring the releases->changelogs process would be to come up with a metadata object that stores the individual titles/change lines (as plain text instead of markdown? maybe?) which is used to generate the markdown needed for the changelogs, with the additional benefit that the output artifact could be a json file, which would allow anyone to consume it to produce whatever they wanted, whether that's a global changelog or something else.

How do we envision configuration of the global changelog? With the Chakra global changelog, I think I'd want to sort the packages based on the highest version (packages with major changes come before packages with only minor changes come before packages with only patch changes), but I'm not sure how to easily allow that type of customization.

What's the intention of the global changelog? Or rather - what kind of things people could want from it? Are there any other use cases beyond just gathering all generated per-package changelogs in a single document?

What's the intention of the global changelog? Or rather - what kind of things people could want from it? Are there any other use cases beyond just gathering all generated per-package changelogs in a single document?

That's a good question and after thinking about it for two weeks 😅 I haven't been able to think of any other use cases besides our own.
For Chakra, global changelog is part of a move we'd like to make to abstract our monorepo a little bit. Right now, we have a ton of individual changelog files being generated by changesets and just as many individual GitHub releases containing the same information. It's great to have that information available, but for most of our users, it's serious information overload and makes it difficult to navigate.
One of the packages we publish is @chakra-ui/react, which is like an aggregate of most of our other packages and offers a single entrypoint for most of our React users. So ideally we'd like to abstract the monorepo behind that. We already refer to the Chakra UI version as the version of the aggregate package, and we'd like to go a bit further by offering a global changelog that is organized around that package's version.
In my mind, that'd look like one of these (leaning towards 1, but really not sure which would be more useful tbh):
# `<EMAIL_ADDRESS>
## Minor Changes

- `<EMAIL_ADDRESS>Line for change! Thanks user1!
- `<EMAIL_ADDRESS>Line for change! Thanks user2!

## Patch Changes

- `<EMAIL_ADDRESS>Line for fix! Thanks user3!

# `<EMAIL_ADDRESS>
## Patch Changes

- `<EMAIL_ADDRESS>Line for fix! Thanks user4!

# `<EMAIL_ADDRESS>
## `<EMAIL_ADDRESS>
### Minor Changes

- Line for change! Thanks user1!

## `<EMAIL_ADDRESS>
### Minor Changes

- Line for change! Thanks user2!

## `<EMAIL_ADDRESS>
### Patch Changes

- Line for fix! Thanks users3!

# `<EMAIL_ADDRESS>
## `<EMAIL_ADDRESS>
### Patch Changes

- Line for fix! Thanks user4!

fwiw we also would find this helpful for the create-single-spa project.

I think this feature would be amazing for projects like Babel (or a design system) where there are a lot of packages, and having to navigate to each package's changelog becomes burdensome. It's useful to see at a glance what packages were updated with each release of such a project.

Having used https://github.com/changesets/action for releases and the Version Packages PRs sort of as a global changelog, I think that something like https://github.com/babel/babel/releases/tag/v7.16.3 would probably be the best option. Currently, if you add a changeset that touches multiple packages, the Version Packages PR will contain "duplicate" entries for this change in every package's changelog. It'd be useful to deduplicate them the way Babel does (see how babel-plugin-transform-parameters, babel-traverse are on the same line):
## v7.16.3 (2021-11-09)

#### :bug: Bug Fix
* `babel-helpers`
  * [#13862](https://github.com/babel/babel/pull/13862) fix(helpers): match `Reflect.get` behaviour ([@lightmare](https://github.com/lightmare))
* `babel-plugin-transform-parameters`, `babel-traverse`
  * [#13941](https://github.com/babel/babel/pull/13941) Support transforming params of arrow functions in class fields ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo))
* `babel-parser`
  * [#13928](https://github.com/babel/babel/pull/13928) fix: incorrect await rejection following arrow function in parameters (Closes [#13872](https://github.com/babel/babel/issues/13872)) ([@The-x-Theorist](https://github.com/The-x-Theorist))
* Other
  * [#13918](https://github.com/babel/babel/pull/13918) Fix `parserOverride` support in `@babel/eslint-parser` ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo))

Being able to see all the major changes in 1 place is probably very useful too, and Babel's changelog enables you to do that.

Does the Changesets team plan on accepting/implementing the global change log feature?

@CxRes I would be open to discussing and accepting a PR for this: https://github.com/changesets/changesets/issues/683 . I think this would be a more flexible approach and it could be used to achieve the "global changelog". Let me know if you are interested in helping out with this.

@Andarist I have only recently started playing with Changesets and do not know my way around the code to make a helpful contribution. It seemed to me though that this PR mostly resolves the issue; again, I do not understand the ways in which it falls short wrt #683. I would be happy to discuss but unless I understand the issue/code better I am in no position to offer any help.
All that said, this is definitely a useful feature I would like to see implemented! It is more consistent for my use case of a monolithic project that I am migrating to a monorepo to keep a single change log going.

Hi 👋,
What the current status with this feature? Is there anything we can do to help getting this implemented?


Support for (alternative for) GeoShapeQuery

Is your feature request related to a problem? Please describe.
We want to port our (Nest) Elastic API to the v8. Currently we use the GeoShapeQuery , mapping to https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-geo-shape-query.html . However it seems that in the latest version we cannot create this query type.
Describe the solution you'd like
A way to create GeoShapeQuery's in the latest C# Elastic Client API
Describe alternatives you've considered
Looking at bounding boxes, geopolygon queries, but they all have different semantics
Additional context
Many thanks in advance!

Hi @arthurvb, the GeoShapeQuery indeed is one of the few things missing right now. It's definitely planned to bring back support for this, but in the meantime there is no workaround 🙁 (except for completely hand-crafting the query using the low-level client).


Need to support LVM stripping

Describe the problem/challenge you have
LVM support stripping for better I/O performance using striped logical volume when there‘re number of disks
So，if lvm-localpv support this will be a useful feature

Describe the solution you'd like
The storage class add parameters regarding

if open stripping support
the strip number

Anything else you would like to add:
This function also needs modification

Nice to have for mee too

I second this: striping support would be ideal for me too!

I face the same issue. This is really necessary.

@npu21 Thanks for the feature request. We have not plaaned to implement this as of now. However, would like to know if you want to contribute?

Unfortunately, I currently cannot commit any time to contribute, but I would simply like to state here that a well-known (albeit neither flexible nor automated) workaround is to use Linux software (mdadm) RAID0 to pre-create a single striped PV for the VG given to lvm-localpv

Tracking this via #259


DM Validator Unit tests

Unit testing the already implemented GCP types and basic validtion.

@ocsig https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/pull/434
Do you think that is the right approach?

@nick4fake We should not use bats for integration tests, but instead use normal Go testing methods. Please follow the example of how this is done in Terraform Validator (and put tests in a separate PR, not the same PR): https://github.com/GoogleCloudPlatform/terraform-validator/tree/master/test

@morgante I was following existing approach.
Plus this issue is only related to unit tests that are fully written on go, I've added function tests as a bonus.

@nick4fake Please put them in a separate PR then. I don't want bats tests for Go code going forward.


Kafka source #90

resolves #90

Addressed the feedback of the review. I haven't changed the output channel from reference to Source.OUTPUT as we probably need to discuss this a bit further it seems like.

@mbogoevici Few more changes need to be committed for the source.

@artembilan @mbogoevici I tried to address all the comments above. Can you review?

As part of the ongoing discussion on what types of OOTB modules we want to provide for messaging systems, the Kafka source and sink are too similar to the Kafka binder in terms of functionality, so we will rely on the binder for supporting this functionality (also on multibinder support if needing to connect to different types of systems, or cluster instances).
Current gaps in the binder:

support for multiple topics/destinations in the binder: https://github.com/spring-cloud/spring-cloud-stream/issues/334
listening to specific partitions: https://github.com/spring-cloud/spring-cloud-stream/issues/336
resetting to arbitrary topics: https://github.com/spring-cloud/spring-cloud-stream/issues/335

Closed as per above comment.


Nested routes and parameters

Hello,
I'm having an issue creating nested routes where the parent route contains a parameter. This is my desired end result:

I want #/projects/1 to be handled by ProjectDashboard
I want #/projects/1/documents to be handled by ProjectDocumentIndex,
Both components should be wrapped in ProjectWrapper

This is my current route setup:
    <Route name="project" path="/projects/:projectId" handler={ProjectWrapper}>
        <Route name="project-detail" path="XXXXXXXX" handler={ProjectDashboard} />
        <Route name="project-documents" path="documents" handler={ProjectDocumentIndex} />
    </Route>

I'm unsure what to substitute for XXXXXXXX:

If I try "/", I get an error: Invariant Violation: Missing "projectId" parameter for path "/"
If I try "", I don't get an error, but #/projects/1 renders ProjectWrapper without ProjectDashboard
If I try "/projects/:projectId", I get an error: Invariant Violation: Missing "projectId" parameter for path "/projects/:projectId/documents"
If I remove the project-detail route entirely and replace it with , I get an error: Invariant Violation: Missing "projectId" parameter for path "/projects/:projectId/documents"

What should I do?

I would say :
 <Route name="project" path="/projects/" handler={ProjectWrapper}>
        <Route name="project-detail" path="/projects/:projectId" handler={ProjectDashboard} />
        <Route name="project-documents" path="/projects/:projectId/documents" handler={ProjectDocumentIndex} />
    </Route>

#/projects/ is a route that is handled by another component that should not be wrapped in ProjectWrapper (and that, itself, can't act as a wrapper for ProjectDashboard or ProjectDocumentIndex either). I really need the wrapper to be used only on #/projects/:id and pages below that.

#/projects/  will not be matched by /projects/:projectId
As for the awkwardness of having to repeat the path, I would say it makes sense because you can see by just looking at a particular route what is the url and what are the parameters.

Not sure what you mean with that. I don't want #/projects/ to be matched by /projects/:projectId. My point was that in your example, #/projects/ will be rendered by ProjectWrapper instead of the (already existing) handler that I have set up for it. Maybe I should have pasted a larger excerpt from my routing. This is what I currently have (but it's not working):
<Route name="app" path="/" handler={Page}>

    <Route name="projects" path="/projects" handler={ProjectIndex} />
    <Route name="projects-new" path="/projects/new" handler={ProjectNew} />
    <Route name="project" path="/projects/:projectId" handler={ProjectWrapper}>
        <Route name="project-documents" path="documents" handler={ProjectDocumentIndex} />
        <DefaultRoute handler={ProjectDashboard} />
    </Route>
    (...)
</Route>

As for the awkwardness, still feels wrong, but I can live with that.

Sounds like you're looking for DefaultRoute. Try this
 <Route name="project" path="/projects/:projectId" handler={ProjectWrapper}>
        <DefaultRoute name="project-detail" handler={ProjectDashboard} />
        <Route name="project-documents" path="documents" handler={ProjectDocumentIndex} />
</Route>

@taurose That's what I thought (you can see that's what I tried in my latest paste). But that when I do that, and then go to #/projects/1, I get this error: Invariant Violation: Missing "projectId" parameter for path "/projects/:projectId/documents"
I find it kind of weird that I get an error on the documents route one while triggering the detail route, but I guess it's trying to evaluate it.

Perhaps I'm missing something here, but that does sound like a bug. Are you using the latest release?
Have you tried without the slashes at the beginning of the paths?
<Route name="app" path="/" handler={Page}>
    <Route name="projects" path="projects" handler={ProjectIndex} />
    <Route name="projects-new" path="projects/new" handler={ProjectNew} />
    <Route name="project" path="projects/:projectId" handler={ProjectWrapper}>
        <Route name="project-documents" path="documents" handler={ProjectDocumentIndex} />
        <DefaultRoute handler={ProjectDashboard} />
    </Route>
    (...)
</Route>

@taurose Yes, I tried that, still the same problem though. I'm on 0.12.0.
However, I was trying to create a small test case to reproduce, and it looks like in the test, everything works. I'll see if I can get it to fail and report back here.

Well this is embarassing.
The error message didn't actually come from the router setup. Everything was working as it should have (especially with the latest version with DefaultRoute), but the selected component was rendering a Link element that was missing a parameter required for the route it was linking to.
Finally figured it out by taking a deep good look at the stack trace when the error occurred.
Sorry for wasting your (and my) time.

That makes sense. No worries, glad you figured it out eventually.

Hey guys, I'm fighting with the same problem. Did you found a solution @efdee ? Thanks in advance!

@fnitschmann In my case the problem was caused by me, not react-router. This issue has been closed though, maybe you should create a new issue with more information, or post it to StackOverflow.

Thanks for your fast reply @efdee!
The solution for me, my problem , and I think in generell to stop struggling around with deep nested routes + parameters, is/was an upgrade to the new react-router 1.0.0-rc1. It solves many problems and brings a lot of cool new things.
I'm not sure, maybe there is also an an solution possible with any 0.13.x version...
But nevermind.


how to perform four var/invar occsions with one image input ?

the four variance/invariance occasions is the same in your defination, I 'm confused , how to perform four var/invar occsions with one image input ? thank you.

and where is the homography?
thanks again!

Hi,
Yes the definition is the same for the four variances/invariances, but what differs between them is the loss function used for them: invar_desc_triplet_loss for invariant ones and var_desc_triplet_loss for the others.
The homography is in the 'inputs' dictionary: you can access it with inputs['homography'].


BE: User settings: Get & Post 06/23-06/24

!!!!!Possibly invalid, may be handled in-browser by frontend??!!!!!
Retrieving and returning user settings

[ ] Build endpoint to retrieve user settings from the database transfer user settings to front end.
[ ] Build endpoint to receive user settings from the front end and store in the database.

Is this something we still need?

Negatory, this will be handled on the FE. "This" being "default env variable".


build: add cache-from and cache-to support

@tiborvass @AkihiroSuda
Signed-off-by: Tonis Tiigi<EMAIL_ADDRESS>

@AkihiroSuda If you find a way to normalize parsing across buildkit, cli and buildx then PRs are welcome. It will probably become much easier after we drop support for deprecated versions in buildctl.


Add EPOLLEXCLUSIVE that is added in Linux 4.5.

Add EPOLLEXCLUSIVE that is added in Linux 4.5.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

@bors: r+

:pushpin: Commit d6fbc0d has been approved by alexcrichton

:hourglass: Testing commit d6fbc0d with merge 3ae5203...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 3ae5203dd19baa8673730685cabecbafe2ba83ec to master...


ConfigureKestrel() conflict with appsettings

I have Kestrel section in appsettings.json and I also call ConfigureKestrel() in Program.cs. When I run the app, there is an error:
11:10:36 [Warning] () Overriding address(es) '"https://localhost:5003"'. Binding to endpoints defined in "UseKestrel()" instead.

11:10:36 [Fatal] () Unable to start Kestrel.
System.IO.IOException: Failed to bind to address https://[::]:5003: address already in use. ---> Microsoft.AspNetCore.Connections.AddressInUseException: Address already in use ---> System.Net.Sockets.SocketException: Address already in use

Here is my appsettings.json:
    "Kestrel": {
        "Endpoints": {
          "HttpsInlineCertFile": {
            "Url": "https://localhost:5003",
            "Certificate": {
              "Path": "/tmp/localhost.pfx",
              "Password": "password"
            }
          },
          "HttpsDefaultCert": {
            "Url": "https://localhost:5003"
          },
          "Https": {
            "Url": "https://*:5003",
            "Certificate": {
                "Path": "/tmp/localhost.pfx",
                "Password": "password"
            }
          }
        },
        "Certificates": {
          "Default": {
            "Path": "/tmp/localhost.pfx",
            "Password": "password"
          }
        }
    },

Here is my ConfigureKestrel():
            .ConfigureKestrel((context, options) =>
            {
                options.Listen(IPAddress.Any, 5003, listenOptions =>
                {
                    listenOptions.UseHttps(o => o.SslProtocols = SslProtocols.Tls12);
                    listenOptions.UseConnectionLogging();
                    listenOptions.Protocols = HttpProtocols.Http1AndHttp2;
                });
            });

OR:
            .ConfigureKestrel((context, options) =>
            {
                options.Configure(context.Configuration.GetSection("Kestrel"))
                    .Endpoint("Https", listenOptions =>
                    {
                        listenOptions.HttpsOptions.SslProtocols = SslProtocols.Tls12;
                        listenOptions.ListenOptions.UseConnectionLogging();
                        listenOptions.ListenOptions.Protocols = HttpProtocols.Http1AndHttp2;
                    });
            });

So, which is which? I am confused. Can I do everything in appsettings.json?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f22dcddb-0c25-be1a-9a02-9e71dce86bdb
Version Independent ID: 3e0e12c2-e544-5655-e001-d2ec180b11a8
Content: Kestrel web server implementation in ASP.NET Core
Content Source: aspnetcore/fundamentals/servers/kestrel.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @guardrex
Microsoft Alias: riande

Yes, you can. If you call CreateDefaultBuilder, the settings (from the file) will apply to the configuration without you having to do anything in code.
I see a few things here to address:

Bad link (to web host) and a minor grammatical issue ("endpoint is a available").
CreateDefaultBuilder:

Isn't cross-linked. It wasn't linked on purpose because we have both Web Host and Generic Host coverage concurrently in the doc. I think I see a better way to handle it. We can link in parentheses to both host topics ... "(Generic Host / Web Host)" with each linked to its respective host destination.
Probably isn't mentioned/cross-linked enough. Since all of the Kestrel config can come from the settings file, it either should be:

At the very top of all Kestrel config in its own section (probably best).
Or, briefly mentioned at the top of each of the existing sections. It's in the HTTPS config section. That's fine, but it should also be cross-linked from perhaps two other spots.

WRT to the two ConfigureKestrel approaches that you showed ...
The 2nd one allows you to load a different section of configuration (from any configuration source that has been provided, including the app settings file config) and then perform additional config in code on just that loaded section via the Endpoint ... BUT ... the UseKestrel warning pertains to how you composed it. Scroll down in https://docs.microsoft.com/aspnet/core/fundamentals/servers/kestrel#listenoptions-usehttps to see an example of the correct composition.
The first one is the best choice configuring entirely in code (no configuration involved).

How about the SslProtocols and UseConnectionLogging? How to configure them in the config file? Is there any document on the available configuration properties for Kestrel using config file?
I might be wrong but I read that kestrel configuration using external config file was removed sometime in the journey of .Net Core but added back in. What's the best approach/practice? External config file or code? Thanks.

How to configure them in the config file?

On the first point, I really do think that it's possible. However, I haven't done it ... or even looked that far into it. I agree that it's a problem that we need to address in the content. I would even go so far perhaps to including a "snapshot" JSON file linked to the topic that has all of the settings shown (or over at http://schemastore.org/json/ ... similar to http://json.schemastore.org/appsettings).
When I get to this issue, I'll confer with engineering, do some testing here, and get our content fleshed out.
If you can't wait that long (ur working on this today 🏃) and can't figure out the composition or find online resources, I recommend Stack Overflow, Slack, Gitter first. If that doesn't pan out, open an engineering issue to ask (last resort given how busy the engineers are).

kestrel configuration using external config file was removed sometime in the journey of .Net Core but added back in

I don't recall such a period, and I've been here since ..... er ..... Beta 5 👴 :smile: lol

External config file or code?

Rubber :duck: always says, "Config file plz!"
Main benefit: Just update the file on the hosting system (environment) (by name appsettings.development.json, appsettings.staging.json, appsettings.production.json, etc.), and it's all good. It's very easy to manage config that way.

@halter73 Working this now.
Cross-linking a bit for CreateDefaultBuilder is done. Easy!
The other aspect of this issue is a bit harder to address. Rubber :duck: says not to ask this stupid question, but do you have a schema for all of the Kestrel options that would be loaded from a configuration provider showing all of the keys? ........ (Rubber :duck: is laughing at me now.)
You see, we focus on this only for the most complicated scenario (that would be very hard to guess), the listen options for endpoints. However, I think we should have a brief example early in the discussion of options that speaks to loading basic options from configuration providers with at least a quick/short example.
Any thoughts on this?

For example, something along the lines of (if this is even correct; haven't tested it yet) ...

The following options, which are configured in C# code in the examples, can also be set using a [configuration provider](fundamentals/configuration/index). For example, the File Configuration Provider that loads app settings from a file (*appsettings.json* or *appsettings.{Environment}.json*) when `CreateDefaultBuilder` is called can also load Kestrel configuration:
{
  "Kestrel": {
    "Limits": {
      "MaxConcurrentConnections": 100,
      "MaxConcurrentUpgradedConnections": 100
    },
    "AllowSynchronousIO": true,
    "AddServerHeader": false
  }
}

@halter73 Let's discuss this further on the PR. I think I'm close to something that will work there.


⚠ Processors has degraded performance

In 70896df, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 52 ms

Resolved: Processors performance has improved in 4f138a4.