[FLINK-19038][table] It doesn't support to call Table.limit() continuously

What is the purpose of the change
Method validateAndGetChildSort of SortOperationFactory checks the fetch of previousSort, which doesn't support continuously fetch or limit. Indeed in SQL perspective, Flink SQL supports continuously fetch or limit, therefore the fetch and limit Table API also needs to support this case. validateAndGetChildSort should remove the check of previousSort fetch.
Brief change log

Method validateAndGetChildSort and createLimitWithOffset remove the check of previousSort fetch.

Verifying this change

Method testFetch and testOffsetAndFetch of LegacyLimitITCase add test cases for continuously fetch or limit.
Method testOrderByFetch of SortITCase  add test cases for continuously fetch.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@twalthr @dawidwys Could you please review this pull request? The current behavior of SortOperationFactory are familiar to you. Thanks.

@twalthr @dawidwys Could you please review this pull request? The current behavior of SortOperationFactory are familiar to you. Thanks.

@SteNicholas I'm actually not familiar with the Table API / SQL component's code base. @wuchong or @twalthr are the right people to ask :)

Thanks @SteNicholas. I will take a look shortly.

Thanks @SteNicholas. I will take a look shortly.

@twalthr Thanks.

Thanks @SteNicholas. I will take a look shortly.

@twalthr could you please take a look for this pull request?

@SteNicholas are you sure that this PR implements the intended behavior? I quickly checked
table.limit(2).limit(2) --> Sort(order = None, offset = 0, fetch = 2, child = Table)
table.orderBy($("word")).limit(2).limit(2) --> Sort(order = None, offset = 0, fetch = 2, child = Table)

So always only one SortOperation is created, not subsequent ones. Is that intended?

So always only one SortOperation is created, not subsequent ones. Is that intended?

Yes, that's intended.

Wouldn't a user expect to further minimize the result when calling limit(3).limit(10) --> at most 3, not 10?

Wouldn't a user expect to further minimize the result when calling limit(3).limit(10) --> at most 3, not 10?

User's operation is always limit(10).limit(3). limit(3).limit(10) doesn't make sense.

limit(3).limit(10) doesn't make sense and equals to limit(3)

Currently, it equals to limit(10). The last limit overrides the previous limit. This can be confusing. A limit should only be set once. After that a new sort operation should be created. I agree that it doesn't make much sense but we should not introduce pre-optimization here.


Upgrade Modernizer Maven Plugin 2.4.0 -> 2.6.0

This PR contains the following updates:

Package
Type
Update
Change

Modernizer Maven Plugin
build
minor
2.4.0 -> 2.6.0

[ ] If you want to rebase/retry this PR, check this box

Warning
Renovate's suggested commit message is being replaced with improved initial commits to enable automerging. As a side effect, these suggested commit messages might have changed. Consider comparing the initial commit message and this message to determine the most suitable one. Please leave feedback in #sys-renovate.

Suggested commit message:
Upgrade Modernizer Maven Plugin 2.4.0 -> 2.6.0

See:
- https://github.com/gaul/modernizer-maven-plugin/releases/tag/modernizer-maven-plugin-2.5.0
- https://github.com/gaul/modernizer-maven-plugin/releases/tag/modernizer-maven-plugin-2.6.0
- https://github.com/gaul/modernizer-maven-plugin/compare/modernizer-maven-plugin-2.4.0...modernizer-maven-plugin-2.6.0

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


AIMNet2 Performance near TS

I have tested a simple PES calculation for the Diels-Alder reaction using the following models:
AIMNet2
torchani models (ani-1x, ani-2x, ani-ccx, ani-xnr)
DFT calculations as the target theory for each ML potential
The results indicate that AIMNet2 shows good predictive performance even near the transition state (TS).
My question is, what might be the reason AIMNet2 predicts well near the TS compared to ANI models? Additionally, does AIMNet2 generally predict well near the TS?
In a past presentation about AIMNet2 video, a TS-targeted model called RxnAIMNet is mentioned. Could you please clarify if this is the same model as the current AIMNet2?
Sincerely,
Kangmg

Hi Kangmg,
Thank you for a feedback.

My question is, what might be the reason AIMNet2 predicts well near the TS compared to ANI models?

AIMNet2 is more sophisticated model, trained on a larger corpus of data.
Btw, ANI1-ccx does well on this reaction. And AIMNet2_B97-3c does poor job, probably due to deficiency of GGA DFT reference.

Additionally, does AIMNet2 generally predict well near the TS?

In many (one can say most) cases it is decent. Models trained on datasets with emphasis on reaction paths certainly might be noticeably better.

Could you please clarify if this is the same model as the current AIMNet2?

This model is under development. Up to my understanding, it has the same architecture, maybe with very minor charges. The training dataset specifically targets diverse set of reactions.


fix: request with query params not containing string values not validated correctly

Given the example:
const mocker = fetchMock.sandbox()

const params = {
   a: 1,
   b: 2
}

const request = mocker.mock({
  url: 'http://test.example.com',
  method: 'GET',
  query: params
}, 200);

fetch( {
   url : 'http://test.example.com?'+ qs.stringify(params),
   method: 'GET'
}).then( () => {
   assert request.called() === true   // fails
})

The problem is query matcher checks for passed query values without transforming them. For ex. if the passed query param is a number it will fail because received query params will be string.

Also related to #554

I can see this being a convenience for developers, even though query strings, technically, can only ever be strings, so I'm in favour of the addition.
I think it is however a bit odd to coerce numbers but not boolean and null, and it also raises the question (which must be documented/implemented) of what to do with keys that exist but contain undefined.
In summary - if we start coercing some values we should coerce other values where it's sensible to do so, and have clear documentation of when coercion is not applied.
I'd favour

Booleans are coerced
objects (including null and functions) throw an error
undefined is treated the same as a non-existent key

Questions:

Does that sound sensible?
Can you think of any omissions?
Are you happy to implement that behaviour in this PR?

You are right about other types. But regarding to your proposals I believe leaving to a module rather than implementing our own ways for dealing with it would cover most cases. We could also add a global option for letting users to use their own module. One of the possible module which users could choose is qs and it has really edge case difference with querystring module. IMHO In this state, updating type definition of query to object would be enough.

In addition, as you know querystring is a core module in Node.js and it is only serving this purpose and I believe it sticks to common URI semantics. Implementing other ways would confuse users. If users have other requirements they always can use full url matching ( which is I am currently doing right now)

We could also add a global option for letting users to use their own module

Or we could provide an interface for passing arguments to querystring

Ok, so it seems querystring covers most cases in a pretty intuitive way. If you wanna expand the tests & types to cover these extra types of input (boolean & undefined I think are particularly important... the others less so) I'll take a proper look at your PR when that's done.

added test cases as you requested

Closing in favour of #557, which tweaks the docs and tests a bit


Allocating request matcher to support C++ callback API

To reduce the memory footprint of having a large number of pre-requested server RPCs, create a new request matcher that dynamically allocates RPCs when they are actually needed. Memory footprint is reduced as expected, there is no negative impact on QPS (for 62-channel 0-byte unary test which is the most stressful for this path), and lock contention is reduced 99% by eliminating any use of the slowpath of publish_new_rpc .

Performance impact: no effect on QPS, 99% reduction in lock contention!

Thanks for the prompt review @soheilhy ! My goal here was to make the callback server a 1st-class citizen at core rather than trying to make it fit into the infrastructure put in place for the async server. I think this should help a lot with that (and makes the code a lot easier to follow too imo).

(squashed commits)

squashed commits again. Will merge when tests pass. Thanks for the reviews!


error / warning on images with an embedded thumbnail

We do have some jpg images that embed thumbnails, for instance https://iiif.bdrc.io/bdr:I1NLM2232_001::I1NLM2232_0010001.jpg/full/full/0/default.jpg (this is a byte copy of the s3 image, no treatment by the IIIF server). You can extract the thumbnail from it using (under Linux at least):
wget https://iiif.bdrc.io/bdr:I1NLM2232_001::I1NLM2232_0010001.jpg/full/full/0/default.jpg -O I1NLM2232_0010001.jpg
exiftool -b -ThumbnailImage I1NLM2232_0010001.jpg > thumbnail.jpg

Here it is attached for reference:

It's about 13kB in size, this means that 13k at the beginning of the image are taken by the thumbnail, but are not useful for our purpose... (unless I'm missing something?). I think we could make at least a warning in the asset manager if there are thumbnails in JPGs.

That would actually be really helpful to you to have this information extracted and preserved somehow.  I've been resisting having audit tool actually do anything, but there's certainly a case for starting to build a processing suite that extracts thumbnails and ICC profile for each object, so that IIIF server doesn't have to.
The problem with errors/warnings is that, in general, nobody sees them, and someone has to then post process (do what your shell script does).
If we had a workflow that read errors & warnings as part of a toolchain, and decided what to do with them, that workflow could pick up the notifications and extract + persist the ICC profile, thumbnail, or whatever else IIIF needs.

@TBRC-Travis Another question is why NLM processing is doing this when (possibly) nobody else is. This gets back to the discussion Karma and I were having, and will continue to have, next week.

Oh actually just ignore the embedded thumbnails so ideally it wouldn't be there at all... if at some point I create thumbnails that will be a separate objects and it would be in separate files, not embedded. So my request would be more to issue a warning when there's an embedded thumbnail and ask the user to remove it

@eroux agreed.  in the case of NLM the inclusion of embedded thumbnails was not intentional.  it's likely an artifact of using Adobe Lightroom for processing at NLM which is likely adding some of these extra bits under the hood.  I can adjust the NLM process to stop generating the thumbnails.

ah great, thanks! Note that this could possibly be part of a processing script:
$ ls -al I1NLM2232_0010001.jpg
-rw-r--r-- 1 eroux eroux 473078 juin   3 16:53 'I1NLM2232_0010001.jpg'
$ exiftool -ifd1:all= I1NLM2232_0010001.jpg
    1 image files updated
$ ls -al I1NLM2232_0010001.jpg
-rw-r--r-- 1 eroux eroux 459512 juin   3 16:55 'I1NLM2232_0010001.jpg'

note the size reduction, also this doesn't reencode the jpg so it's fine (or at least I don't see why it would reencode it)

 Why we need a platform

@eroux Would it help if this info were encoded into dimensions.json? (Won't help the past, but might help the future) v_m_b can extract the 0x201 fields from a num,ber of dictionaries (see https://www.exiftool.org/TagNames/EXIF.html 0x201 0x202) and derive where the image thumbnail is (not create the node in dimensions.json if there is none.)
It might just help to have the warning in a place where IIIFPRES can use it, as well as where the creator sees it.

I don't think it will be useful no, I think my intention was to make sure that audittool complains if there's an embedded thumbnail

From metadata-extractor-issue-262
  Metadata metadata = ImageMetadataReader.readMetadata(inStream);

            ExifSubIFDDirectory directory = metadata.getFirstDirectoryOfType(ExifSubIFDDirectory.class);

            int offset = directory.getInt(0x0201);
            int length = directory.getInt(0x0202);

            logger.info("Embedded jpeg offset: " + offset);
            logger.info("Embedded jpeg length: " + length);

            inStream.reset();
            inStream.skip(offset);

            byte[] jpegData = new byte[length];
            inStream.read(jpegData, 0, length);

            return jpegData;

Closed in PR #161


release-helper: Skip CI for release PRs

Reference:
https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/

Can we try manually?

Just for reference, I tested this successfully with #39 (needs an admin merge then though because due to general PR rules CI should run successfully).


urls and methods modified

Thanks for this. I just started using the gem and sure enough was getting 404s from Clever.
Do you think that the URLs should be part of the config/initializer? Having to update the gem if the URLs change does not seem ideal (documentation on URLs should be exposed on Clever docs).
Also, I get what's going on here -> https://github.com/thinkthroughmath/omniauth-clever/pull/3/files#diff-1a4a556d7b8ff767d97a6a37fc1ef662R24 (proper Authentication data) but I'm not so sure why you removed the options here -> https://github.com/thinkthroughmath/omniauth-clever/pull/3/files#diff-1a4a556d7b8ff767d97a6a37fc1ef662R18
Does Clever no longer support those options?
Thanks again!


Examples not working

I tried this lib and I can't get examples working.
I cloned the repository and then did a mix deps.get, elixir -S mix run examples/progress_and_queue_status.exs and I got no output.
I changed the start function to display the status of queues and workers to :
  def start do
    :ok = Honeydew.start_queue(:my_queue)
    :ok = Honeydew.start_workers(:my_queue, HeavyTask, num: 10)
    IO.puts "App started"
    IO.inspect Honeydew.queues
    IO.inspect Honeydew.workers
    IO.inspect Honeydew.status(:my_queue)
  end

I have this output:
App started
[:my_queue]
[:my_queue]
%{queue: %{count: 0, in_progress: 0, suspended: false}, workers: %{}}

what am I doing wrong? I run elixir 1.7.4

Are any of the other examples working for you?

Nop ...

if you manually queue a job with
{:work_really_hard, [0]} |> Honeydew.async(:my_queue)
does it display anything?

It displays nothing

You don't even see a %Honeydew.Job{…} struct printed?

No.
I wondering if this is normal that when I a do Honeydew.status(:my_queue) the result is
%{queue: %{count: 0, in_progress: 0, suspended: false}, workers: %{}}

Especially the empty workers dict.

Hm, you're right, it shouldn't be empty, I don't know why it is.
Can you try installing the elixir/erlang versions specified in .tool_versions?

The result of elixir --version is
Erlang/OTP 20 [erts-<IP_ADDRESS>] [source] [64-bit] [smp:4:4] [ds:4:4:10] [async-threads:10] [kernel-poll:false]

Elixir 1.7.4 (compiled with Erlang/OTP 19)

is it ok?

Sorry about that, looks like I hadn't pushed the file to github. Here's what I'm using:
erlang 21.2.5
elixir 1.8.1

If you pull the changes to the repo, it's easy to install the new elixir/erlang versions with asdf.

I installed the 1.8 version but it's still not good.
The strange thing is that tests are passing with version 1.7 on travis.
I can't get them passing on my version, here are the results with the version 1.8
 1) test simple global queue yield/2 (Honeydew.GlobalTest)
     test/honeydew/global_test.exs:22
     ** (exit) :not_alive
     stacktrace:
       (stdlib) slave.erl:198: :slave.start/5
       (honeydew) test/support/cluster.ex:16: Honeydew.Support.Cluster.spawn_node/1
       (honeydew) test/support/cluster_setups.ex:22: Honeydew.Support.ClusterSetups.start_node/3
       test/honeydew/global_test.exs:9: Honeydew.GlobalTest.__ex_unit_setup_1/1
       test/honeydew/global_test.exs:1: Honeydew.GlobalTest.__ex_unit__/2

  2) test simple global queue hammer async/3 (Honeydew.GlobalTest)
     test/honeydew/global_test.exs:15
     ** (exit) :not_alive
     stacktrace:
       (stdlib) slave.erl:198: :slave.start/5
       (honeydew) test/support/cluster.ex:16: Honeydew.Support.Cluster.spawn_node/1
       (honeydew) test/support/cluster_setups.ex:22: Honeydew.Support.ClusterSetups.start_node/3
       test/honeydew/global_test.exs:9: Honeydew.GlobalTest.__ex_unit_setup_1/1
       test/honeydew/global_test.exs:1: Honeydew.GlobalTest.__ex_unit__/2

.....

  3) test should inform the awaiting process of an uncaught throw (Honeydew.FailureMode.AbandonTest)
     test/honeydew/failure_mode/abandon_test.exs:44
     ** (MatchError) no match of right hand side value: nil
     code: {:error, reason} =
     stacktrace:
       test/honeydew/failure_mode/abandon_test.exs:45: (test)

  4) test should inform the awaiting process of the uncaught throw (Honeydew.FailureMode.MoveTest)
     test/honeydew/failure_mode/move_test.exs:51
     match (=) failed
     code:  assert {:moved, {"intentional crash", stacktrace}} = Honeydew.yield(job)
     right: nil
     stacktrace:
       test/honeydew/failure_mode/move_test.exs:54: (test)

  5) test should inform the awaiting process of an uncaught throw (Honeydew.FailureMode.RetryTest)
     test/honeydew/failure_mode/retry_test.exs:66
     match (=) failed
     code:  assert {:retrying, {"intentional crash", _stacktrace}} = Honeydew.yield(job)
     right: nil
     stacktrace:
       test/honeydew/failure_mode/retry_test.exs:69: (test)

  6) test should remove job from the queue (Honeydew.FailureMode.AbandonTest)
     test/honeydew/failure_mode/abandon_test.exs:24
     No message matching :job_ran after 100ms.
     The process mailbox is empty.
     code: assert_receive :job_ran
     stacktrace:
       test/honeydew/failure_mode/abandon_test.exs:26: (test)

  7) test should move the job on the new queue (Honeydew.FailureMode.MoveTest)
     test/honeydew/failure_mode/move_test.exs:28
     No message matching :job_ran after 100ms.
     The process mailbox is empty.
     code: assert_receive :job_ran
     stacktrace:
       test/honeydew/failure_mode/move_test.exs:30: (test)

  8) test should retry the job (Honeydew.FailureMode.RetryTest)
     test/honeydew/failure_mode/retry_test.exs:37
     No message matching :job_ran after 100ms.
     The process mailbox is empty.
     code: assert_receive :job_ran
     stacktrace:
       test/honeydew/failure_mode/retry_test.exs:39: (test)

And then it get stuck

did you install erlang 21.2.5?

Sorry it took some time.
This is working now! thank you for your time!
There are just two errors on mix test
1) test simple global queue yield/2 (Honeydew.GlobalTest)
     test/honeydew/global_test.exs:22
     ** (exit) :not_alive
     stacktrace:
       (stdlib) slave.erl:198: :slave.start/5
       (honeydew) test/support/cluster.ex:16: Honeydew.Support.Cluster.spawn_node/1
       (honeydew) test/support/cluster_setups.ex:22: Honeydew.Support.ClusterSetups.start_node/3
       test/honeydew/global_test.exs:9: Honeydew.GlobalTest.__ex_unit_setup_1/1
       test/honeydew/global_test.exs:1: Honeydew.GlobalTest.__ex_unit__/2

  2) test simple global queue hammer async/3 (Honeydew.GlobalTest)
     test/honeydew/global_test.exs:15
     ** (exit) :not_alive
     stacktrace:
       (stdlib) slave.erl:198: :slave.start/5
       (honeydew) test/support/cluster.ex:16: Honeydew.Support.Cluster.spawn_node/1
       (honeydew) test/support/cluster_setups.ex:22: Honeydew.Support.ClusterSetups.start_node/3
       test/honeydew/global_test.exs:9: Honeydew.GlobalTest.__ex_unit_setup_1/1
       test/honeydew/global_test.exs:1: Honeydew.GlobalTest.__ex_unit__/2

but progress_and_queue_status example is now working

No worries, glad it's working. :)
It sounds like there might be an issue in the test suite getting the slave nodes working, It's interesting that it doesn't fail on travis. I'll look into it, thanks!

Thank you very much!


[Backport release-23.11] chromedriver,{ungoogled-,}chromium: 124.0.6367.207 -> 125.0.6422.60

Manual backport of #312059 without 81c988db8af8674c8905f3286f058f0456ecb6b8 because we (purposely) didn't backport #310209 either.

Result of nixpkgs-review pr 312328 run on x86_64-linux 1 1 package failed to build:  sharedown  21 packages built:  aws-azure-login chromedriver chromium chromium.sandbox fast-cli mermaid-cli mermaid-filter percollate playwright-test puppeteer-cli python310Packages.pytest-playwright python310Packages.pytest-playwright.dist python311Packages.pytest-playwright python311Packages.pytest-playwright.dist selendroid selenium-server-standalone sitespeed-io ungoogled-chromium ungoogled-chromium.sandbox vhs wayback


How to do a custom training??

Hello.
I'm new to SparseInst, and also new to detectron2. I want to train my own datatset that fomart with coco .  But I don't no how to modify  your config.  or I need modify some codes of detectron2? I have 2 class,when I train as  issues  #34.  I got a error as  below:
`Traceback (most recent call last):
File "train_net.py", line 180, in
launch(
File "/home/cxf/detectron2-0.3/detectron2/engine/launch.py", line 62, in launch
main_func(*args)
File "train_net.py", line 172, in main
trainer = Trainer(cfg)
File "/home/cxf/detectron2-0.3/detectron2/engine/defaults.py", line 284, in init
data_loader = self.build_train_loader(cfg)
File "train_net.py", line 144, in build_train_loader
return build_detection_train_loader(cfg, mapper=mapper)
File "/home/cxf/detectron2-0.3/detectron2/config/config.py", line 201, in wrapped
explicit_args = _get_args_from_config(from_config, *args, **kwargs)
File "/home/cxf/detectron2-0.3/detectron2/config/config.py", line 236, in _get_args_from_config
ret = from_config_func(*args, **kwargs)
File "/home/cxf/detectron2-0.3/detectron2/data/build.py", line 301, in _train_loader_from_config
dataset = get_detection_dataset_dicts(
File "/home/cxf/detectron2-0.3/detectron2/data/build.py", line 220, in get_detection_dataset_dicts
dataset_dicts = [DatasetCatalog.get(dataset_name) for dataset_name in dataset_names]
File "/home/cxf/detectron2-0.3/detectron2/data/build.py", line 220, in
dataset_dicts = [DatasetCatalog.get(dataset_name) for dataset_name in dataset_names]
File "/home/cxf/detectron2-0.3/detectron2/data/catalog.py", line 58, in get
return f()
File "/home/cxf/detectron2-0.3/detectron2/data/datasets/coco.py", line 469, in
DatasetCatalog.register(name, lambda: load_coco_json(json_file, image_root, name))
File "/home/cxf/detectron2-0.3/detectron2/data/datasets/coco.py", line 71, in load_coco_json
meta.thing_classes = thing_classes
File "/home/cxf/detectron2-0.3/detectron2/data/catalog.py", line 148, in setattr
assert oldval == val, (
AssertionError: Attribute 'thing_classes' in the metadata of 'coco_2017_train' cannot be set to a different value!
['person', 'bicycle', 'car', 'motorcycle', 'airplane', 'bus', 'train', 'truck', 'boat', 'traffic light', 'fire hydrant', 'stop sign', 'parking meter', 'bench', 'bird', 'cat', 'dog', 'horse', 'sheep', 'cow', 'elephant', 'bear', 'zebra', 'giraffe', 'backpack', 'umbrella', 'handbag', 'tie', 'suitcase', 'frisbee', 'skis', 'snowboard', 'sports ball', 'kite', 'baseball bat', 'baseball glove', 'skateboard', 'surfboard', 'tennis racket', 'bottle', 'wine glass', 'cup', 'fork', 'knife', 'spoon', 'bowl', 'banana', 'apple', 'sandwich', 'orange', 'broccoli', 'carrot', 'hot dog', 'pizza', 'donut', 'cake', 'chair', 'couch', 'potted plant', 'bed', 'dining table', 'toilet', 'tv', 'laptop', 'mouse', 'remote', 'keyboard', 'cell phone', 'microwave', 'oven', 'toaster', 'sink', 'refrigerator', 'book', 'clock', 'vase', 'scissors', 'teddy bear', 'hair drier', 'toothbrush'] != ['background', 'table', 'index']
Could you  give  a detailed document about training  in  README.MD?    About how to set datasets,  how to modify config...

Hi @caoxuefengzz, you should take care of the following:

the dataset, converting the dataset into COCO format.
the NUM_CLASSES, which determines the classes of your dataset.
the NUM_MASKS, which determines the maximum instances in your dataset. (I suggest that you can leave it 100 as default.)
the evaluation
For more details, you can refer to the official guide for custom training.

Thank you for your reply !
I have trained my  dataset by learnning from detectron2 github.

Hi, @caoxuefengzz, your suggestion is good and we'll add it. This issue will be closed, you can open a new issue if you have other problems or reopen it. Thanks for your interest in SparseInst 😊 . If you find it useful in your work or research, could you give us a star 🌟 or help us recommend SparseInst to your friends.

Changing NUM_CLASSES causes CUDA error 59: Device-side assert triggered. Due to some sort of mismatch ig. Any way to enable only two classes and avoid this mismatch?


Change package version of the Util package to snapshot

We have not bumped the other dependencies to be marked as pre-release packages (e.g. all of the D.F.Account, D.F.Holding and so on ...
If we release now, these would be marked as stable (but dependent on a pre-release package)

And it looks like we have bumped the two packages to <IP_ADDRESS>323.1 (which means prelease for 1.1.0), but since they're prerelease for 2.0.0 they should rather have <IP_ADDRESS>323.1 or something.


New rule on Amazon EC2 Security Group not being used (EC2_SECURITY_GROUP_NOT_USED)

Kindly provide comments around Gherkin if any.
Description:
  Checks that Security Groups are attached to EC2 instances or elastic network interfaces (ENIs). The rule returns NON_COMPLIANT for a Security Group if it's not associated with any Elastic Network Interface.
Trigger:
  Configuration Changes
Reports on:
  AWS::EC2::SecurityGroup
Rule Parameters:
  None
Scenarios:
  Scenario: 1
     Given: 'relationships' in the configuration item does not contain a Network interface Id in resourceId
     Then: Return NON_COMPLIANT with annnotation 'This Security Group is not associated with any resource'.
  Scenario: 2
     Given: 'relationships' in the configuration item contains at least one Network interface Id in resourceId
     Then: Return COMPLIANT

Updated and good to go :)


fix: small return typo, filterings elements

:tada: This PR is included in version 1.8.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


People like you make me want to kill myself.

@ogar-unmimited agar is dead, stop playing this XD

@gyeyoqu Why are you on the repo then?

@ogar-unmimited The bots are only made for testing features that require more than one player (such as popsplits), not normal gameplay. If you actually want to make some smart bots, start learning here.

Duplicated so many times...

lel


[NEW ALGORITHM] Longest Path in DAG

Name:
[NEW ALGORITHM]  Given a weighted directed acyclic graph (DAG) and a source vertex, find the cost of the longest path from the source vertex to all other vertices present in the graph. If the vertex can’t be reached from the given source vertex, print its distance as infinity.
Input:
Source vertex and the cost matrix or the dajacency list as per your wish.
Output:
Longest path from source vertex to all other vertices.
About:
Propose a new algorithm to be added to the repository. Implementation of Dynamic Programming.

Labels:
new algorithm, gssoc-ext, hacktoberfest, level1

Assignees:

[x] Contributor in GSSoC-ext
[x] Want to work on it

Additional Information:
Please assign me this issue I want to work on it.

assigned


Map-filter-reduce

[ ] Map
[ ] Filter
[ ] Reduce

Blocked by https://github.com/naomijub/ClojuRS/issues/13


Cannot understand how to use it

I was reading cpp-coveralls README.md example but couldn't understand ./configure --enable-gcov. Is configure a built file by cmake?
Cheers!

No, that line in the documentation just means "run your app however you would usually run it but make sure to enable gcov"
Here is a config of mine for a project I wrote which does not use ./configure but instead uses just make
https://github.com/mkfifo/icarus/blob/master/.travis.yml
this works because my make test always compiles with gcov
https://github.com/mkfifo/icarus/blob/master/config.mk#L13
https://github.com/mkfifo/icarus/blob/master/Makefile#L28
So for your application all you need to do it make sure you compile and run with gcov enabled, have cpp-coveralls install, and then run cpp coveralls at the end to upload results
language: cpp
compiler:
  - gcc
before_install:
  - pip install --user cpp-coveralls
script:
  - echo "do whatever you want in here to build and run your application/test"
  - echo "just make sure that you compile with gcov options"
  - echo "for gcc this means using the flags `-fprofile-arcs -ftest-coverage`"
after_success:
  - coveralls --exclude lib --exclude tests --gcov-options '\-lp'

Yesterday I have achieved to do a bit differently. Maybe do you know why I am getting 100% coverages on the files which don't have tests?

The coverage is calculated by whatever code you run with gcov enabled, not just what you test.

But without seeing your config I can't be expected to debug it.

Thanks, I have solved the problem


HomepageForDomain doesn't work with www

Moved from http://open.silverstripe.org/ticket/4489
On a fresh install of SS 2.3.3, entering a value for "Use this page as the 'home page' for the following domains:" in behaviour tab only makes this page as homepage, when the domain is entered without www.
So entering "domain.com" works, but not "www.domain.com".
If this behaviour is wanted, please add a note in the UI.
php: PHP 5.2.0-8+etch15 mysql: 5.0.32-Debian_7etch10-log

Cleaning up old issues. Please feel free to reopen if you feel the issue is still valid!


Handle compound SRTCP messages

Make sure any extra packets packed into an
encrypted payload are properly handled
Resolves #249

Pull Request Test Coverage Report for Build 1180

0 of 10 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 29.968%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/network/port-receive.go
0
10
0.0%

Totals

Change from base Build 1179:
-0.03%

Covered Lines:
2081

Relevant Lines:
6944

💛  - Coveralls


Input-container does not have an hidden property, and does not honor inner input hidden property

Bug, feature request, or proposal:
Right now there is no way to hide an input property, cause the input-container does not have (or does not honor) a hidden property. Also, it's a hidden property it's set in the input child, the input will hide, but the other "decorators", placeholders, prefix, suffix,  will not.
What is the expected behavior?
A way to actually hide a input.
What is the current behavior?
The input it's not hided.
What are the steps to reproduce?
  <md-input-container
    fxFlex
    class="flex-item"
    *ngFor="let input of inputFieldList"
    hidden="true"
  >
    <input md-input
      [placeholder]="input.placeholder"
      [formControlName]="input.name"
    >
    </textarea>
  </md-input-container>

I tried also [hidden]="'true'" and [hidden]="item.hidden". Neither of them work.
If is set in the input, just the input gets hidden.
  <md-input-container
    fxFlex
    class="flex-item"
    *ngFor="let input of inputFieldList"
  >
    <input md-input
      [placeholder]="input.placeholder"
      [formControlName]="input.name"
      hidden="true"
    >
    </textarea>
  </md-input-container>

What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, browsers are affected?
Angular 2.4.2
Material 2.0.0-beta.1
Is there anything else we should know?
I try to search, and did not find anything. Sorry if this is duplicated.

That's because the input container has a display: inline-block, which takes precedence over the browser agent stylesheet (which is the one that sets [hidden] { display: none; }). You can work around it by adding this somewhere in your stylesheet:
[hidden] {
  display: none.
}

Thanks you. I will use this. Just to know, this solution is just a temporally workaround or is this the intended behavior?

In general, we try to avoid defining global styles like this one, so I doubt that we'd add it to Material itself. I recommend either adding this to your CSS or using a class for hiding stuff.

Thanks. 👍

But, the component should read the hidden property, and do binding with it's own css display property, shouldn't it?

Not necessarily. The hidden attribute is built-in browser attribute, it's not something that's specific to Material or Angular. The issue with it is that it's specificity is really low, which makes it very easy to override.

But, I mean, I think the component should handle the display for itself, shouldn't it? I know the hidden property it's something built-in browsers, but still, a expected behavior if it is set to false, it's for the component to hide, and the component should do it. I understand you mean, but you won't, and it should not, override any built-in property, it just have to set it temporally as is, to be handle by the browser.

@crisbeto After some read, I was waiting for the stable version, I found this: https://codingwithgerwin.blogspot.com/2016/04/polymer-and-hidden-attribute.html. That may help you about the hidden property. I did what you said, but how is explain in the article, the CSS specification of yours is prefer. But you could add the hidden property as appears in the article.
That maybe a solution. You could use Promact/md2#34 for example.

@crisbeto Have you though about this? Adding
    mat-form-field[hidden] {
      display: none;
    }

still feels tricky and a workaround. I think this should be build in. This is not something specific to a browser, but a CSS standard. https://caniuse.com/#search=hidden.
It's really weird that when you apply hidden to any attribute this still show.

Thought its 2019 and still it is helpful. @crisbeto


Binary Distribution Randomly Failing

Hi!
We're using appcenter-cli to upload our binaries to AppCenter in our CI process and every once in a while, we get this kind of error:
Release upload failed
Release upload was aborted
Error: release binary uploading failed: socket hang up

Our binaries are quite huge, so, that might be a part of the problem, but these errors got more frequent over the past weeks and our binary size didn't change much. Is there anything we can do to alleviate this problem?
Thank you very much!

@jpdesjardins-bhvr - Hey! Thanks for letting us know about this issue. We were doing some work to change the infrastructure around how we process release uploads which might have caused some of the instability you are seeing. Those issues should be fixed by now, so if you are still seeing problems please open a support case by navigating to the App Center portal and clicking the blue chat icon in the bottom right of the screen.

Sounds good, thanks for the update!


os/exec: execution of internal command at Windows gives error

Go version
go version go1.22.2 windows/amd64
Output of go env in your module/workspace:
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\neo\AppData\Local\go-build
set GOENV=C:\Users\neo\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=C:\lib\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\lib\go;C:\Users\neo\Projects\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=C:\Program Files\go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLCHAIN=auto
set GOTOOLDIR=C:\Program Files\go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.22.2
set GCCGO=gccgo
set GOAMD64=v1
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=C:\Users\neo\Projects\go\osutil\go.mod
set GOWORK=
set CGO_CFLAGS=-O2 -g
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-O2 -g
set CGO_FFLAGS=-O2 -g
set CGO_LDFLAGS=-O2 -g
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=C:\Users\neo\AppData\Local\Temp\go-build930553209=/tmp/go-build -gno-record-gcc-switches

What did you do?
package executil

import (
	"os/exec"
	"testing"
)

func TestEcho(t *testing.T) {
	cmd := exec.Command("echo", "ok")
	if err := cmd.Run(); err != nil {
		t.Fatal(err)
	}
}

What did you see happen?
exec: "echo": executable file not found in %PATH%
What did you expect to see?
'echo' is an internal command at Windows so it can not found in %PATH%.

CC @golang/windows.

This is probably working as intended. If there was a command named echo in %PATH%, would it be executed? If so, it might not be a responsibility of os/exec to track which builtins on various platforms.

This is probably working as intended.

I agree.

If there was a command named echo in %PATH%, would it be executed?

If a file named echo.exe would be found in the %PATH%, it would be executed. If a file named echo would be found in the %PATH%, it would not be executed.
Alex


Resolve Idam client-Id failure

JIRA link (if applicable)
N/A
Change description
Resolve Idam client-Id failure
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[X] No

Not required


createEnv from @t3-oss/env-nextjs returns genric object when using Zod v3.23.0

After upgrading Zod to v3.23.0 from v3.22.5, createEnv from @t3-oss/env-nextjs will always return
const env: Readonly<{
    [x: string]: any;
}>

regardless of how the env vars are specified. The createEnv exported from @t3-oss/env-core doesn't seem to be affected by this issue.
Reproduction:

import { createEnv } from "@t3-oss/env-nextjs"; // this doesn't generate the correct type
// import { createEnv } from "@t3-oss/env-core"; // this does
import { z } from "zod"; // reproducable in v3.23.0. Not reproducible in v3.22.5

const env = createEnv({
  server: {
    DATABASE_URL: z.string().url(),
  },
  experimental__runtimeEnv: {},
});

console.log(env);

Hover the env variable to see the generated type.

Same, just get a failed check from dependabot for Zod version bump. Following for resolution.

Also experiencing this

same, but i'm experiencing this with older zod versions as well.

Someone know what types they've changed? We're not using any internal types so feels like they've mistakenly broken semver.

same, but i'm experiencing this with older zod versions as well.

That's weird, please open a separate issue with a reproduction.

@juliusmarminge Could it be related to this change?

we're only using ZodType as a generic constraint so that shouldn't matter

can't reproduce inside this repo though which will make it harder to debug...

Is it feasible to release a beta/canary/unstable release so that we can test it and see whether that's the case?

Was just about to do that from #223

Try this one: pnpm add<EMAIL_ADDRESS>

yup looks like canary fixes it for me

Though there is a breaking change on presets, which are now functions

Yea this will be a 0.10 release. Needed to make them functions to avoid side-effects in the imports
I'll go ahead and relese 0.10 now then

Thanks for the quick action @juliusmarminge.
I've fixed the underlying problem in Zod 3.23.2, so there's no need for everyone to upgrade. Perhaps add this as a note at the top of the original issue to avoid further confusion?

@t3-oss/env-nextjs: 0.9.1 with zod: 3.23.4 (latest) -> works
@t3-oss/env-nextjs: 0.10.1 (latest) with zod: 3.23.4 (latest) -> shows any

@t3-oss/env-nextjs: 0.9.1 with zod: 3.23.4 (latest) -> works
@t3-oss/env-nextjs: 0.10.1 (latest) with zod: 3.23.4 (latest) -> shows any

3-oss/env-nextjs: 0.9.1

I also get this issue. Reverting to 0.9.1 fixes the issue for now

Still a problem for me.
Using: @t3-oss/env-nextjs: 0.10.1 with zod: 3.23.8 and the createEnv returns  any type.

@juliusmarminge I can confirm this issue still persists like described above. Rolling back to 0.9.1 works for now

If anyone still gets this please also provide a reproduction. Im using the latest version without issues

When I install 0.10.1 it says

Cannot find module '@t3-oss/env-nextjs' or its corresponding type declarations.

Using version 0.9.1 it works fine.
See https://codesandbox.io/p/devbox/dreamy-black-7l4ywn?workspaceId=78150bbe-056c-4c8d-8542-1698ecfb6c1d

When I install 0.10.1 it says

Cannot find module '@t3-oss/env-nextjs' or its corresponding type declarations.

Using version 0.9.1 it works fine.
See https://codesandbox.io/p/devbox/dreamy-black-7l4ywn?workspaceId=78150bbe-056c-4c8d-8542-1698ecfb6c1d

You're using an incompatible module resolution. See https://github.com/t3-oss/t3-env?tab=readme-ov-file#installation for compatible options

Ahhh I see. After I changed it to
    "moduleResolution": "Bundler",
    "module": "esnext",

it seems to work.
Also I had to use proper import instead of require inside my next.config.mjs. Maybe this helps anyone else finding this


Allow KNNIndex classes to take **kwargs arguments and pass them to KNN library

See title. We discussed it at Dagstuhl. Should be useful for PyNNdescent, but could potentially be useful for Annoy/HNSW/etc at well.
We could potentially allow Affinity classes to take **kwargs as well and pass them to the KNNIndex. Here I'm less sure if that's a good design idea.

Yes, we definitely need to add that! IMO, a general **kwargs would be messy, and something like like a knn_kwargs argument would be better. Scikit-learn also does something similar in their KNN classes, but they call it "params". I prefer "kwargs". What do you think?


Invalid url when using custom port with custom endpoint suffix for File Services

Storage Explorer Version: 1.6.2
Platform/OS: Windows 10?
Architecture: x64?
Regression From: 0.9.2
Bug description
When creating File Storage connection using custom endpoint with explicit port number. Storage explorer displays error dialog that url is invalid. The url is encapsulated into square brackets.
Steps to Reproduce

Connect to Azure storage
Select use storage account name and key.
Specify account name and key
Select Storage domain as Other (enter below)
Enter custom domain with explicit port number
Press Connect

Expected Experience
Successful connection
Actual Experience
Error dialog as in attachmen

Additional Context
Traced the reason to be in url.format method that wraps the url in square brackets when explicit port is specified

It looks like custom domain is essentially translated to EndpointSuffix in the generated connection string. I don't know if custom endpoints with ports is supported. Do you need a custom port for your custom endpoint?

Custom port used to be supported on previous versions of Storage Explorer. Additionally, AFAIR there was an Azure storage emulator that could use custom port.
The reason we need custom ports is because we do not do direct connection but through a special proxy software.

What end is the proxy on? It sounds like you just need to turn on proxy settings. Also, if you're connecting to an emulator, you should use the "Connect to local emulator" option in the Connect dialog. It has fileds for port numbers and handles it correctly.

Proxy is local to the Storage Explorer.

OK, so it sounds like you just need to enable proxy settings. You can do that from the menu Edit > Configure Proxy. If all you need is a hostname and port number, it should work just fine.

The proxy software I was talking about is not classic HTTP proxy. It works on the TCP level. So essentially Storage Explorer connects to that software thinking that it is one of the Azure Storage servers.

I believe you said the software runs on your local machine, yes? You should still be able to route Storage Explorer web requests correctly by configuring the proxy to go through localhost:4433.

Not always. It can also run on the same network or on premises in customer environment.

Is your system also configured to go through this proxy? Can you tell me anything else about the proxy, such as whether it is an NTLM proxy?

My system does not run through this proxy and as far as I know it is not an NTLM proxy.
I do not understand why does it matter? Even if can tweak or setup proxy differently on my local environment I do not have such control on other environments.
The issue here is that Storage Explorer does not handle custom ports correctly, while in the past there was no such problem.

I've suggested proxy settings, because that's where port numbers are usually use the way you're describing. As far as I know, your scenario is not one we usually cover, so we don't have tests that make sure your scenario continues to work.
Since that's apparently not the issue here, I did some deeper investigation and found where the bad URL is coming from. It's deep down in the Azure Storage client library for Node that we use. The bad news is I don't know a way around this, so we'll have to push for a fix.
One of the reasons this may have changed is because we switched to passing around connection strings to make our architecture simpler a while ago.
@XiaoningLiu Is this something we can get fixed in v2.*? I'm not aware of an explicit way to pass ports via connection string, so we may have to be smart about how we parse the DNS/suffix/endpoints.

@XiaoningLiu, I guess v2.* should be fine. Do you have any timelines for when that version would come around?

Hi, I think definition of DNS/suffix/endpoints refers to an endpoint suffix, which doesn't include port. So it's more like a feature request instead of bug fix. Out our curious, did it work previously?

Yes, according to @vadmyst, but I think that's because we were using URIs directly. As I explained above, we switched to using connection strings throughout to simplify the architecture some time ago.

Got it. Which connection section are you using? "EndpointSuffix" or "BlobEndPoint"? "EndpointSuffix" doesn't support a port, while "BlobEndPoint" can support a customized port like "http://account.blob.core.windows.net:8080"

I did not use connection string explicitly. Look the the first post in this thread for details how to reproduce. BTW, we are using File Services.

@vadmyst Just about every attachment you make we convert to a connection string.
Here's something you can try. Instead of using the account name and key option in the Connect dialog, do the following:

Construct a connection string manually using the account name, key, and custom endpoints (see here). For example:DefaultEndpointsProtocol=http;
AccountName=myaccount;
AccountKey=ABC...==;
BlobEndpoint=http://my.custom.blob.endpoint:1234;
FileEndpoint=http://myaccount.file.core.windows.net:1234

Open the Connect dialog and choose the connection string option.
Enter the connection string you constructed, give the connection a name, etc.

Closing. No responses since June. This is a known limitation of connection strings.

Commenting on a closed issue in case this helps someone.
The below suggestion worked well for me.
I have local proxy on 8433 forwarding to emulator so I can observe the traffic, and hosts entry for myaccount.blob.core.windows.net.
DefaultEndpointsProtocol=http;AccountName=myaccount;AccountKey=TXlLZXk=;BlobEndpoint=http://myaccount.blob.core.windows.net:8433;

@vadmyst Just about every attachment you make we convert to a connection string.
Here's something you can try. Instead of using the account name and key option in the Connect dialog, do the following:

Construct a connection string manually using the account name, key, and custom endpoints (see here). For example:DefaultEndpointsProtocol=http;
AccountName=myaccount;
AccountKey=ABC...==;
BlobEndpoint=http://my.custom.blob.endpoint:1234;
FileEndpoint=http://myaccount.file.core.windows.net:1234

Open the Connect dialog and choose the connection string option.
Enter the connection string you constructed, give the connection a name, etc.


Importing ridgeplot fails with scipy 1.14.1 with "symbol not found in flat namespace '_npy_cabs'"

This is more of an FYI for visibility than an issue that needs action, but importing ridgeplot fails when using scipy 1.14.1 ("symbol not found in flat namespace '_npy_cabs'")
Issue has been raised with scipy maintainers: https://github.com/scipy/scipy/issues/21434
I'm on Mac OS 14.6.1, Python 3.10.14. Downgrading scipy solved the issue:
pip install --upgrade scipy==1.14.0

This issue is fixed in statsmodels==0.14.3, see https://github.com/statsmodels/statsmodels/issues/9333

Thanks @cduvallet for reporting the issue and @nickodell for referencing the relevant issue on statsmodels.
Since the problem seems to be which statsmodels==0.14.2, I have removed it as a valid dependency in #198 :

A new released has been published to PyPi: https://pypi.org/project/ridgeplot/0.1.26/
For anyone landing here looking for a solution, just upgrade to the latest version of ridgeplot:
pip install -U ridgeplot

or lock to the latest version:
pip install ridgeplot==0.1.26

I filed an issue on pyodide to update statsmodels from 0.14.2 to 0.14.3: https://github.com/pyodide/pyodide/issues/5093
However, I think this will be a nontrivial task because that version of statsmodels wants an updated version of numpy and scipy.

@wch let me know if there is anything I can do from my end :)
Python's dependency specification doesn't allow for complex exclusion rules such as statsmodels>=0.12 & !(scipy==1.14.1 & statsmodels==0.14.2 & numpy==2.1.0) so I opted for the stricter statsmodels>=0.12,!=0.14.2 approach.
Apologies if this interfered with your workflow! Better to get the error here rather than an obscure exception at runtime I guess...


Can't seem to make SD1.5 models which have VPred work after converting them.

Been using some of the fluffyrock models which do have VPred, used their configs to convert them, but the models do not seem to generate anything good besides garbled noise, as if VPred is not considered (similar behaviour was in KohyaSS if i didn't check VPred check, or using the models in ComfyUI without the config).

If you can't tell, this is a dead project if the non-answering of tickets is any indication.  Powerful tool without support, or good documentation, is a worthless tool.


Implement addMatchers shortcut on jest

This will make it easier to use arrow functions when writing unit tests that have custom matchers:
beforeEach(() => {
  jest.addMatchers({
    toBeOne() {
      return this.actual === 1;
    }
  });
});

Seems fine. Might be worth adding a comment in the code that it will need to be updated if we upgrade to jasmine2. http://jasmine.github.io/2.0/upgrading.html

Shall we go with this PR? Also, we have the process of upgrading to jasmine2 in https://github.com/facebook/jest/pull/330.

OK, seems it was merged internally already, so we can add it here.


Character Stats Screen Is Missing Wanderer Title

On the main menu, Statistics -> Character Stats -> Scroll down to specific character statistics. The CULL and the base characters have "titles" for their sections of stats, but Wanderer does not.

never mind, its showing up now?


Feature/958

#958
NOTE: A simple JS script was added to demonstrate the functionality but this component WILL NOT work without supporting JavaScript. It will be up to each team to implement the behavior on their own.

This is ready for review ... branch feature/958, go to http://localhost:8080/dropdown
The implementation matches https://zpl.io/bzlRrMV

@xak
Drop downs are looking good.
Side note:
I think the url you're using above is wrong. "http://localhost:8080/dropdown" wouldn't work. I changed 8080 to 3030 and it worked. FYI.

@LeoT7508 Yeah, it's always 3030. My mistake.

@xak  - a couple of questions.

the menu does not go away when you click elsewhere on the page.
do we need to show any kind of validation with this? I know it's not a form element, but what if someone wants to use a form instead of select control?

@saadmhybris
#1 I don't see much value in expanding the JS. This is minimal to test the functionality. We will need to discuss how much (if any) JS support we want to provide esp. since there will be no Bootstrap JS to do these small things. I'll open a separate JS story.
#2 Same with the validation. The button itself inherits all the form behaviors so it should get a green background with the is-valid class, etc. This dropdown has little value on it's own and is better suited for navigation dropdowns whereas Select2 or similar library would be better suited for form-like interactions. That needs to be addressed separately. I took pains to ensure the markup and structure match the Select2 outputs so it should be easy to expand this component to work with more advanced use cases.

@xak - ok makes sense. PR looks good from code perspective. I'll merge once @LeoT7508 give the green light.


UseBiometrics

Can someone please provide the correct Custom CSP for enabling the Biometrics and Enhanced Anti Spoofing?
i've tried
./Vendor/MSFT/PassportForWork/Biometrics/FacialFeatureUseEnhancedAntiSpoofing
./Device/Vendor/MSFT/PassportForWork/Biometrics/FacialFeatureUseEnhancedAntiSpoofing
with boolean, integer (1 and 0) string (<enabled/>) and a few more combinations but all i get is catastrophic failure.
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f4180b6e-2786-ffb0-8f92-e4456dc343c9
Version Independent ID: 7722d866-c095-b806-1da8-17e00cfe9a0a
Content: PassportForWork CSP
Content Source: windows/client-management/mdm/passportforwork-csp.md
Product: w10
GitHub Login: @MariciaAlforque
Microsoft Alias: maricia

@Heidilohr Any updates with this issue? We would like to follow-up. Thanks.

@e0i Unfortunately, I'm no longer the writer responsible for CSPs. However, I've forwarded this issue along to the team who currently updates CSP content. They should get back to you soon.

I'm also waiting for reply. Do we need to register support case?
There is also this link that gives the impression to use UsePassportForWork instead of PassportForWork:
https://docs.microsoft.com/en-us/windows/security/identity-protection/hello-for-business/hello-manage-in-organization

@manikadhiman Would you be able to provide guidance with this issue? Thanks.

Hi @e0i, Product team had suggested to refer to the PassportForWork CSP DDF for this issue. According to DDF, the supported value (allowed value) for "FacialFeaturesUseEnhancedAntiSpoofing" is True/False.
Hope this helps!


Pages from disabled languages are still accessible by visitor

My language settings:

For some reason I got a report from a friend that my website content wasn't there.
He said he just went to my website https://weblama.be
The reason my content wasn't there was because for some reason he was on the American English version of my website.
Eventhough that language is disabled.
All I can think of is that this might be because of it being the default language?
But I can't seem to find a way to change the default language.
There also is no fall-back for pages on disabled languages.
It should redirect to the enabled language(s).

Thanks for report, we fixed it in the dev branch

The issue persists on the latest dev branch (updated with the Standalone updater).
Visitors can still access American English (Default) while it's disabled.
Visitors still don't get redirected to enabled language(s).

Settings again:

The visitor who reported the issue said they got to these pages through Google Results.
I can't reproduce this, but I am able to access the pages as well in an incognito window.

@bobimicroweber I don't know how to reopen this issue.


fix: styling filter widget in tablet view port

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #365
Test URLs:

Before: https://main--accenture-newsroom--hlxsites.hlx.live/
After: https://filter-styling-tablet--accenture-newsroom--hlxsites.hlx.live/
After: https://filter-styling-tablet--accenture-newsroom--hlxsites.hlx.live/subjects/technology

The TBT in subjectes/technology is unrelated to this change


fix: handle whitespace is error message

When the whitespace is the difference between Expected and Received value, the values are not properly displayed in the error message:

Did you run it to see if it helps? My understanding is that this fix won't only leave the problem as is, it'll also reset the remaining color highlighting. VS Code sanitizes the styles and adding white-space makes it think the the style is bad.

This was addressed using & nbsp ;


Deploy CMR into JPL AWS

Sent Update email to Algorithm Service about this deployment.
Hi @McDuffie, James L (US 398E)
I am just wondering if you have made any progress deploying CMR on the cloud?
I did not make much progress, but managed to create 2 AMIs.
edc-app-base-am-uds-dev-cmr-1-amzn-linux2-x86_64 from Step 1 of Deploying ElasticSearch
cmr-elasticsearch-7.10.0-1644954114 from Step 2 of Deploying ElasticSearch
When I tried Step 4 from https://git.earthdata.nasa.gov/projects/CMR/repos/cmr-cloud-elasticsearch/browse , the command  bundle exec rake cluster, it failed with 2 error so far:
I think I know the first error. It is because I am just a power user, not an advanced user.
I am still debugging 2nd error.
2022-02-24T17:37:14.936+0000 [INFO] 2022-02-24 17:36:51 UTC ElasticsearchNodeRole (AWS::IAM::Role) CREATE_FAILED API: iam:CreateRole User: arn:aws:sts::884500545225:assumed-role/power_user/[wai.phyo<EMAIL_ADDRESS>is not authorized to perform: iam:CreateRole on resource: arn:aws:iam::884500545225:role/elasticsearch-node-am-uds-cmr-es-cluster-1 with an explicit deny
2022-02-24T17:37:14.936+0000 [INFO] 2022-02-24 17:37:00 UTC ElasticClusterLoadBalancer (AWS::ElasticLoadBalancing::LoadBalancer) CREATE_FAILED Security group "sg-0a2c317ea2b6504c0" does not belong to VPC "vpc-0fa55a4f7feb0110a" (Service: AmazonElasticLoadBalancing; Status Code: 409; Error Code: InvalidConfigurationRequest; Request ID: 9e3d8597-13c5-4c0c-9485-b460a9f9a6ed; Proxy: null)
2022-02-24T17:37:14.936+0000 [INFO] 2022-02-24 17:37:00 UTC ElasticClusterMasterLoadBalancer (AWS::ElasticLoadBalancing::LoadBalancer) CREATE_FAILED Security group "sg-0a2c317ea2b6504c0" does not belong to VPC "vpc-0fa55a4f7feb0110a" (Service: AmazonElasticLoadBalancing; Status Code: 409; Error Code: InvalidConfigurationRequest; Request ID: 7e009413-c5ed-4269-a176-d7c1aba889ee; Proxy: null)

This is the config.yml that I used.
# This is technically the number of data nodes. The cluster size will
# actually be cluster_size + num_eligible_master_nodes.
cluster_size: 2
# name of any s3 bucket used to store deployment artifacts
ngap_bucket: am-uds-dev-cumulus-tf-state
region: us-west-2
subnet_id: subnet-03eeb8818c15892ac
vpc_id: vpc-06e627ef021d1854e
# must refer to an existing EC2 key pair to allow access to provisioned instances
key_name: /Users/wphyo/Downloads/uds_william_1.cer
cidr_block: <IP_ADDRESS>/28
root_volume_size: 10
instance_type: r5.xlarge
# identifier for the environment (e.g. dev, sit, uat, prod)
ngap_app_environment: sit
# unique prefix for this cluster
cluster_name: am-uds-cmr-es-cluster-1
data_volume_size: 40
alarm_recipients:
  - [wai.phyo<EMAIL_ADDRESS>elasticsearch_url: localhost:1111
# should be set to `true` for a new cluster
is_new_cluster: false
master_node_instance_type: c5.large
master_node_data_volume_size: 40
num_eligible_master_nodes: 3

I am curious if you managed to go further than that?

@wphyojpl Will follow up with ADS team.


[Fix #8788] Change Style/Documentation to not trigger offense with only macros

Closes https://github.com/rubocop-hq/rubocop/issues/8788

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

How do I generate expected.html? I don't see any rake task and my git-fu isn't helping.

How do I generate expected.html? I don't see any rake task and my git-fu isn't helping.

You can uncomment the right line in formatter/html_formatter_spec.rb (look for FileUtils.copy) and run the test...

Such a change should also be reflected in the cop's documentation.

@tejasbubane ping :-)

Updated changelog and added to cop documentation. Sorry for the delay.

Thanks!

I think this change is a bit too aggressive. For example, this is considered "only macros" so there's no lint error if documentation is missing:
class Thing < ApplicationRecord
  belongs_to :user
end

My reading of the issue is this is specifically trying to find classes or modules that exclusively extend or include other modules. Would you be open to making the check more precise?


[RFE] support to upload validated and packaged templates

It would be nice to have the tool not only validate, and package the templates but upload them to an f5 or FAST service also.  This could really streamline the authoring process.

I think this is a better feature for the SDK that focuses on communication with BIG-IP: https://www.npmjs.com/package/f5-sdk-js
FAST-core is primarily focused on template rendering and generic HTTP capabilities. BIG-IP specific code is out of scope for FAST-Core.

Thanks for the feedback gents!  As recommended, I implemented this in the extension.


Tests for SVGMobject

At the moment, there are no tests for checking that SVGs are being parsed and rendered properly using SVGMobject. Note that tests for the text-related Mobjects should be separate (e.g. TexMobject, TextMobject, Text...). These tests would help with PR #108 and prevent future bugs relating to SVG rendering.

I completely agree. More tests is better that no tests.
Unfortunatly, I'm not an expert on SVG on manim. What implementation would require SVG tests ?

As we have currently no one working on improving SVG support, and it is not one of our current priorities, I am closing this issue for the time being.
This issue will be reopened when someone takes on the challenge to improve SVG support.
All issues (open or closed) related to SVG support can be found in the SVG project board.

I've collected 14 SVGs from the Discord to develop SVG tests upon. I had planned to upload the SVGs, but Github issues didn't support that, so I've instead attached them to my fork of Manim. I hope it's not too much of a mess for someone else to download if they need to. https://github.com/ManimCommunity/manim/commit/303b8c2b88f7d1601419ce3010976139fa74c665

I've collected 14 SVGs from the Discord to develop SVG tests upon. I had planned to upload the SVGs, but Github issues didn't support that, so I've instead attached them to my fork of Manim. I hope it's not too much of a mess for someone else to download if they need to. https://github.com/ManimCommunity/manim/commit/303b8c2b88f7d1601419ce3010976139fa74c665


Exit when compile completed

Using Node.js 0.6.x, process don't exit at compile completed.

This seems rather urgent: I'm releasing this today as 0.1.3.

Thank you for releasing!!


[Suggestion] Actions left Calc for Melee Skills depending on Enemy Max HP

Basically, one type of enemy has the same HP. 1 Dmg is 4 XP for Melee.
So why not calculate when attaking an enemy, how many enemeis of this kind you have to kill, to have a Level Up? Like when an enemy has 10 HP, so you get 40 XP for killing him in Defense/Strenght/Attack.
It would be rather useful, definetly better than "Actions left" consantly recalculating cause its based on the dmg of the last hit. Ye, good that i have to hit 200 more times with 10 Dmg, could just aswell calculate them manually.

Duplicate of #1594


[DOCFIX] Improve Async cache docs

Improve user documentation on async caching

FYI: after merging the load command updates, those metrics @yuzhu  mentioned in the updates are replaced by the following metrics.
Worker.CacheRequests: "Total number of cache requests received by this worker"
Worker.CacheRequestsAsync: "Total number of async cache requests received by this worker"
Worker.CacheRequestsSync: "Total number of sync cache requests received by this worker")
Worker.CacheSucceededBlocks: "Total number of cache succeeded blocks in this worker")

@jja725 is there a way for the user to monitor how many AsyncCache requests were submitted vs succeeded like before? seems like we lost that if we just have Worker.CacheSucceededBlocks ?

@jja725 is there a way for the user to monitor how many AsyncCache requests were submitted vs succeeded like before? seems like we lost that if we just have Worker.CacheSucceededBlocks ?

yeah during the review, we think it's not that valuable to track the sync/async success number and just total number and a single ratio metric to see the separation between the two should be good. If you think individual metrics provide useful information we can add that back easily I think.

alluxio-bot, merge this please


[BI-1335] sort: fix capitalization first sort order

Description
Story: (https://breedinginsight.atlassian.net/jira/software/c/projects/BI/boards/1?modal=detail&selectedIssue=BI-1335)
Simple configuration fix for backend sorting util.
Dependencies
bi-web: develop
Testing
Create some programs or locations (easiest to create) with various beginning capitalization. Sort your programs and check the sort order. Make sure that the capitalization doesn't factor into the sort order.
Checklist:

[x] I have performed a self-review of my own code
[x] I have tested my code and ensured it meets the acceptance criteria of the story
[x] I have create/modified unit tests to cover this change
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to documentation
[ ] I have run TAF: <link to TAF run>

Happy Path passed.

I don't think the changes to src/test/resources/sql/ResponseUtilsIntegrationTest.sql have any effect on the unit test.
I'm not sure how the unit test for this work, so, locally, I replace "Place4" and "Place26" with values like "XXXXX", "xxxxxx", and "AAAAA". All unit test still passed.

I'll check it out. Can you request changes on this PR so I can keep track that this needs work?


Research S3 Bucket storage

Determine if we will have the capacity to store all 200 images for a professional model, and N number of images for the random forest.
Or if we will need to create thumbnails to save space


remove Basilisk related code

I think we will decide on a date, and we can drop a code related to BSX

PLUS there is BSX rpc error

Originally posted by @yangwao in https://github.com/kodadot/nft-gallery/issues/8486#issuecomment-1847346309

let's do it! maybe some announcement on twitter in order for ppl solve their business there?

Didn't we want to give them a chance to migrate their collections?

Let's remove the code regarding Basilisk

https://github.com/search?q=repo%3Akodadot%2Fnft-gallery basilisk&type=code

hey @kodadot/internal-dev we've got end-of-year cleaning of code base 😅 to hunt some performance. If anyone wants to take a bite. Probably could be done in more PRs so we don't turn of some of our major critical features.
🙏

tag new release before?

tag new release before?

For sure there will be release with tag before

i would leave teleport and transfer enabled tho if you guys think it makes sense


How to load an alternative image if the remote image has failed to load?

Is there a way to achieve that with Haneke?
If you look at SDWebImage, it has a feature like this:
[_newsImage sd_setImageWithURL:imageURL placeholderImage:[UIImage imageNamed:alternative_image_name]];

You could load the alternative image in the failure block.


Evaluate SeqWare

I have looked at the seqware docs: https://seqware.github.io/docs/6-pipeline/
I have not played with the code or browsed the source. Notes:
Has multiple workflow engines.
Preferred workflow specification is in Java - which is nice, but does not work with all engines.
Can use both Hadoop and SGE like systems.
Has associated web ui / database engine.
Seems pretty complex - but that's just a first impression.
Works with AWS, but not sure about spot market.
Provides preconfigured VMs.


Confused about publish implementation

Hey there,
Thanks for making and maintaining this library. I'm confused about the publish implementation here. Exmqttc publish
Publish I think is async in nature in :emqttc. If the nature of it is async, why handle it using a GenServer.call and not GenServer.cast. I think the backpressure that call generates in the message queue for async publish here is unnecessary?
Please help me understand if I'm wrong in my approach here.

Hey, sorry for the slow response.
Given that I wrote this library ages ago I can't say for certain, but I think your reasoning regarding backpressure is correct. GenServer.casting the message might mean that the GenServer is busy doing other stuff and might be overloaded, in which case I would prefer the error being pushed out to the boundary as far as possible by blocking the operation.


"ModuleNotFoundError: No module named 'brute_force_cython_ext'"

I have the error reported in the issue title...how could I solve this problem?

Got same error on Docker..

Got same error on CentOS 7.5


Remove check for port 35903

This port is entirely unused now, we should probably not check if it's open (it does not matter)

I thought it was for the workout game thingy

I thought it was for the workout game thingy

No, it was an oooold owoTrack discovery port that isn't used anymore, there's 0 references in the code besides this