expcertificates: correctly handle keyFormat

Is your feature request related to a problem? Please describe.
As per:

https://github.com/jetstack/cert-manager/pull/2843#discussion_r417912053
https://github.com/jetstack/cert-manager/pull/2843#issuecomment-621760713

We should make sure we correctly handle the keyFormat field to encode private keys to PKCS1 or PKCS8 as requested by the user. Currently, we'll always use PKCS8 even if PKCS1 is requested (when a user is using the 'experimental' certificates controller only).
/kind bug
/priority important-soon

cc @JoshVanL


Performance improvements

Hello @goldengrisha! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file icusim/icu_burden_simulator.py:

Line 90:80: E501 line too long (105 > 79 characters)
Line 224:1: W293 blank line contains whitespace
Line 226:13: E303 too many blank lines (2)
Line 342:80: E501 line too long (80 > 79 characters)


revalidate_instances conflict with SerializeAsAny

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
When using SerializeAsAny +  revalidate_instances + layered inheritances, SerializeAsAny is not anymore respected.
Example Code
from pydantic import BaseModel, SerializeAsAny

class commonbase(
    BaseModel,
    revalidate_instances="subclass-instances",  # <--- toogle to generate error or not
): ...

class basechild(commonbase):
    test_val: int = 1

class derivedchild(basechild):
    test_val2: int = 2

class container(commonbase):

    ct_child_1: dict[str, basechild] = {}
    ct_child_2: SerializeAsAny[dict[str, basechild]] = {}
    ct_child_3: dict[str, SerializeAsAny[basechild]] = {}

if __name__ == "__main__":
    test_val = container(
        ct_child_1={"test1": derivedchild()},
        ct_child_2={"test2": derivedchild()},
        ct_child_3={"test3": derivedchild()},
    )

    # print(test_val.model_dump_json(indent=1))
    # print(test_val.model_dump())

    assert "test_val2" not in test_val.model_dump()["ct_child_1"]["test1"]
    assert "test_val2" in test_val.model_dump()["ct_child_2"]["test2"]
    assert "test_val2" in test_val.model_dump()["ct_child_3"]["test3"]

Python, Pydantic & OS Version
pydantic version: 2.9.2
        pydantic-core version: 2.23.4
          pydantic-core build: profile=release pgo=false
                 install path: C:\Users\chacha\AppData\Roaming\Python\Python311\site-packages\pydantic
               python version: 3.11.8 (tags/v3.11.8:db85d51, Feb  6 2024, 22:03:32) [MSC v.1937 64 bit (AMD64)]
                     platform: Windows-10-10.0.22631-SP0
             related packages: mypy-1.9.0 typing_extensions-4.10.0
                       commit: unknown

Hi @cclecle,
Thanks for your question. This is the behavior we'd expect. When you revalidate subclass instances, you effectively discard attributes associated with the subclass and not the superclass that you're validating against.
So post validation, you have the following:
print(repr(test_val))
#> container(ct_child_1={'test1': basechild(test_val=1)}, ct_child_2={'test2': basechild(test_val=1)}, ct_child_3={'test3': basechild(test_val=1)})

Which is why it makes sense that no test_val2 keys would ever be present in the model_dump output, no matter your SerializeAsAny specification.
If you'd still like to preserve that information, I'd recommend not setting the revalidate_instances setting as you have it.


Allow specifying locale for string matching when walk through syntax tree

Problem description
I just came across this project when dealing with the product i18n process. First of all I want to thank to @zealot128 to come up with a nice solution. This tool allow me to plan a quicker process of extracting all untranslated content in the Rails application.
As for my project there's a big pain point when using the tool, mainly because we are a Taiwan company where the untranslated content might be all in zh-TW. And current implementation will basically ignore those characters which resulting weird result.
For example:
In one of the ruby file there's the following content: (please ignore the shop_translate method, it was a weird method that actually not doing it's job, so this might need to be adjusted manually)
    flash[:error] = shop_translate('密碼不正確，請重試.')

And if I follow the prompt and I will get wrong result:

replaced string I18n.t("shop.shops_controller."), which is empty after the namspace
translation file looks likezh-TW:
  shop:
    shops_controller: 密碼不正確，請重試.

expected result wil be something like I18n.t("shop.shops_controller.密碼不正確_請重試") and the following yaml:
  zh-TW:
    shop:
      shops_controller:
        密碼不正確_請重試: 密碼不正確，請重試.

And another issue is that the prompt is asking every possible strings, which is not ideal for extracting non-en characters. eg. Those strings that should be extracted to translation keys are ALWAYS contain zh-TW characters. And those strings what don't contain zh-TW characters are definitely not the target.
Proposed solution

Add a new configuration option called detect_locales that defaults to ['en']. This can be configured through CLI.
Each locale map to particular set of characters. For zh-TW it should be like [\u4e00-\u9fff]+

Example for ruby_adapter.rb

Update the ExtractI18n.key implementation to accept those locales
Update on_dstr and on_str implementation to first check if the string contains any characters from the target locales before processing

I havn't looked into other format (.slim, .erb) yet but the idea is similar.

And I think this api will benefit other usecase that extract non-en text to translation files.
Any thoughts on this design? I can make a PR  if the design is ok.
(might need some time since I'm a React developer instead of Ruby developer lol. but I'm interested on solving this problem.

And there's a tool in js ecosystem that doing similar job:
https://github.com/i18next/i18next-scanner
Maybe we can support sort of config file that gain maximum customization if the character set implementation is simply not enough. But might need further study and plan on the API.


Links to theme demos fail

Creating a theme has links to standard themes:
Fresh
Original
Wing
All lead to the github 404 page.

Thanks, the wiki has been updated. Demos can be seen here https://atomicpages.github.io/skeleton-sass/


god and log rotation (logrotate)

This is a part of my conf file:
God.watch do |w|
  w.name = "myproc_1"
  w.group = "myproc"

  w.start = "node App.js"

  w.log =     File.join(config_path, "..", "..", "logs", "node.log")
  w.err_log = File.join(config_path, "..", "..", "logs", "node.log")
  ...
end

I started using unix's logrotate for node.log. The file was renamed to node.log.1, but god continued writing log data to rotated file, instead of creating new node.log.
What can I do to force god to create new log file every time it is rotated?

This is usually done using a SIGHUP, but you probably want to look at just changing your logrotate configuration to use copytruncate.

Thanks a lot, that solves the issue.


IOS14 XCODE BETA 4 : Return black screen after dismiss CardView

Hi there,
Version : Xcode 12 beta4 with IOS 14
Issue : Return to black screen after dismiss  detail view
tried to change cardContentVC.modalPresentationStyle = (.fullScreen) but not working for me

I'm having the same issue! Does anyone have any fixes?
Version: Xcode 11 with iOS 13
Issue: Returns a black screen after dismissing detail view

see issue
it worked for me
Cheers!

I was able to get it working! It's so smooth and fluid!

In the function "shouldPresent" of file Card.swift add the following code:
under detailVC.isFullscreen = fullscreen
need add
if fullscreen {
detailVC.modalPresentationStyle = .fullScreen
}
else {
detailVC.modalPresentationStyle = .currentContext
}
it worked for me


feat: port Algebra.Category.Module.Abelian

[x] depends on: #4052
[x] depends on: #4297

This PR/issue depends on:

leanprover-community/mathlib4#4052
leanprover-community/mathlib4#4297
By Dependent Issues (🤖). Happy coding!

Very nice diff, great to see the autoporter doing so well on stuff like this. A shame to see those necessary changes f.range -> LinearMap.range f but there's nothing you can do about that.
maintainer merge
(although I don't think this works yet)

This PR/issue depends on:

leanprover-community/mathlib4#4052
leanprover-community/mathlib4#4297
By Dependent Issues (🤖). Happy coding!

bors merge

bors merge


Pure Java package of the app

I wonder is there a reason why there are only "binary" packages of the app in each release?
It would really nice to see a pure java package generated by ./gradlew distTar for those of us who already have JRE installed.
P.S.
There is one caveat. Native binaries (hwi and libbwt_jni) are packaged only for the platform the package is built on.

Bundling with Sparrow with a JVM included ensures binary reproducibility, reduced complications from different Java versions, and increased security from a minimal JVM provided by JLink. All this for the cost of a few extra megabytes on disk.
If you want to use your own JRE though, my suggestion is to run from source - this is simple to do and described in the project README.


Translate concepts/workloads/controllers/deployment into Japanese

This is a Feature Request

What would you like to be added
Translate concepts/workloads/controllers/deployment into Japanese
Why is this needed
This document is not translated in Japanese.
Comments

/language ja

/priority backlog

duplicates of #14848
/close


Add support for local kernel execution

Proposal
Right now, myst has no built-time execution support (e.g. to generate figures). We are in a strong position to implement cache-aware builds, and I don't think it will be too much work given the fact that we're just re-using the Jupyter APIs.
c.f. https://github.com/executablebooks/mystmd/issues/330
Additional notes

We may want a myst execute command to avoid building any render targets. Maybe just myst build?
Add support for annotating documents as "un-cacheable" e.g. things that depend upon random inputs.
Multiple cache backends? In future, could perhaps centralise a cache among users for e.g. a JupyterHub deployment that controls the execution environment

This is closed by #873


soc: stm32f7 remove cache memory with dma transfer

When using the DMA on stm32f7, the cache memory is disabled using the CONFIG_NOCACHE_MEMORY
This must be the case when running dma memory-to-memory transfers test cases
tests/driver/dma/chan_blen_transfer and  tests/driver/dma/loop_transfer
on nucleo_f746zg (dma2 is already enabled in the dts of the board)
Signed-off-by: Francois Ramu<EMAIL_ADDRESS>Fixes #35220

single commit for this fix so that it is not mix with other PRs

@mnkp - wonder if this same fix would address #35107

The implementation is incorrect. From the description of NOCACHE_MEMORY Kconfig option

Add a "nocache" read-write memory section that is configured to
not be cached. This memory section can be used to perform DMA
transfers when cache coherence issues are not optimal or can not
be solved using cache maintenance operations.

The option adds support for a new, dedicated linker section. Only data placed in this specific, limited RAM section via __nocache pragma/macro are not cached. This PR disables completely instruction and data cache if CONFIG_NOCACHE_MEMORY=y.

I fully agree with that. Now if that PR fixes the issue, it means that there is a cache issue somewhere, which can actually be fixed by using no cache memory for that particular region. Alternatively it should be possible to use cache invalidate / clean, but Zephyr still lacks a proper infrastructure to do that.
Both DMA and cache are supposed to improve performance. They should not be exclusive.

I have been able to reproduce the issue on a stm32f723e_disco board. This happens every other boot and is definitely the same issue than #35107 and #35089. Reverting commit b160cb7cfea0cf128fca436b263de14f7ef31849 fixes the issue.

I have been able to reproduce the issue on a stm32f723e_disco board. This happens every other boot and is definitely the same issue than #35107 and #35089. Reverting commit d6b5023 fixes the issue.

Do we think there is a an ordering issue here between MPU init and cache init and that commit changed the order and thus broke M7?

I have been able to reproduce the issue on a stm32f723e_disco board. This happens every other boot and is definitely the same issue than #35107 and #35089. Reverting commit d6b5023 fixes the issue.

Do we think there is a an ordering issue here between MPU init and cache init and that commit changed the order and thus broke M7?

I have the impression that it worked by chance before and that the cache clean and invalidation is not done the proper way. For instance enabling CONFIG_INIT_ARCH_HW_AT_BOOT moves that cache clean and invalidation even earlier in the boot process, and also fails.

I think the problem is with the clean part of the operation. By reorganizing the code, the call to SCB_CleanInvalidateDCache() happens before the D-cache is enabled. When the cache is not enabled, it might contain plenty of outdated cache lines from before the reset, and trying to clean them means pushing random data to random addresses, triggering a bus fault.
We should change that part to something like:
        if (SCB->CCR & SCB_CCR_DC_Msk) {
                SCB_CleanInvalidateDCache();
        } else {
                SCB_InvalidateDCache();
        }

Now if we are sure that the D-cache is not enabled at this point, we can just call SCB_InvalidateDCache() instead.
For the CONFIG_INIT_ARCH_HW_AT_BOOT case, we should just drop SCB_CleanInvalidateDCache(), as SCB_DisableDCache() already takes care of cleaning and invaliding the cache.

This patch is no more relevant since the https://github.com/zephyrproject-rtos/zephyr/pull/35258, isn't it


Login redirect fail when using base-path and auth

code-server version: 2.1523-vsc1.38.1
OS Version: Ubuntu 18.04.2 LTS x86_64

Description
Using Nginx to reverse proxy code-server with a subpath, I noticed base-path and auth cannot work together. The login page shows up properly, but always redirect to login page instead of actual editor page. If I disable the auth option, the subpath works fine.
I followed the instruction form https://github.com/cdr/code-server/blob/master/doc/quickstart.md#nginx-reverse-proxy and this issue https://github.com/cdr/code-server/issues/241. Not sure if this is an expected behaviour
Steps to Reproduce

Nginx Conf

       location /code/ {

            proxy_pass https://localhost:8080/;
            proxy_http_version 1.1;
            proxy_set_header Upgrade $http_upgrade;
            proxy_set_header Connection "upgrade";
            proxy_set_header Host MY_HOST;
            proxy_set_header Accept-Encoding gzip;
       }

Initialized code-server

./code-server \
        --cert PATH/cert1.pem \
        --cert-key PATH/privkey1.pem \
        --auth password \
        --base-path /code

Goes to HOST/code -> login page -> enter password -> click enter -> still redirect to login page

CC @code-asher you might want to investigate this.

I haven't been able to replicate this yet on 2.1523-vsc1.38.1. Just to be sure, the login page doesn't say the password is invalid, does it?

I tested today and could not replicate this issue anymore as well.. Not sure if my environment is changed or there was any cache issues in my browser before.
The issue can be closed now, thanks for all your helps

@yihengli I'm guessing it might be caching on your end, it takes a while before browsers invalidate their cache.


[Bug]: no tsconfig.json for generated projects

Package name
workspace
Package version
10.1.5
Reproduction steps
Create a new Otter app and generate an application or a lib within
Current result
There's no tsconfig.json file in the project.
Expected result
We should have a tsconfig.json for each project (lib or app) for the IDE
Additional comments
No response

There is actually a tsconfig.json.template in the library generator:

https://github.com/AmadeusITGroup/otter/blob/main/packages/%40o3r/workspace/schematics/library/templates/ng/tsconfig.json.template

Is it an issue only in Nx workspace? Or an issue in the template generation globally?

Actually libs seem to be ok, but there is no tsconfig for apps.


[Feature Request] Authentication Feature should have own Timeline and Code Generation

Insomnia Version: 6.3.1 (<IP_ADDRESS>86)
Operating System: macos 10.13.6 (17G3025)

Details
Normal requests have a Timeline pane and a Generate Code action, however things like the OAuth2 pane have neither.

Ya, the code generation is done through an open source library that doesn't know about those things...
Unfortunately, a lot of the authentication stuff is complicated and handled by libcurl under the hood, making writing code generation really difficult in a lot of cases (such as Windows NTLM auth)

Timeline entries for OAuth 1/2 might be possible though


Fix simple typo in Introduction to variable fonts

What's changed, or what was fixed?

Fixes a typo in the fallback example for using font-variation-settings
Took me a few minutes to notice why that @support didn't work

CC: @petele

:tada: This has been pushed live to https://developers.google.com/web/


Returned deltas are reversed

Hi,
I found a strange behavior of the code. After solving the other issue I posted as explained inside the issue, I used the code to see the deltas returned by the KnowledgeEnhancer (as you can see in the notebook).
I found that if I manually sum the returned deltas with the original preactivation I obtain a different vector w.r.t. the one returned by the KnowledgeEnhancer. I used the debugger to inspect the behavior and I found that in line 98 of ClauseEnhancer.py the variables scattered_delta and delta contain the same values but reversed. I also checked that scattered_delta is the summed variable to obtain the enhanced prediction and delta is the returned variable when save_training_data = True.
Why these variables are reversed?
I think that the correct one is scattered_delta, is it correct?
Thanks

Hi Manuel! Thanks for the feedback. I checked the code at line 98 and tried it in debug mode. The behavior seems correct to me. The correct matrix, used by the knowledge enhancer, is scattered_delta which contains the changes to be applied on the initial predicates. The delta matrix was used in the tensorflow version for explainability (but the code of the explainer  is not available for the pytorch version, and not yet completed in the tensorflow one). It was copied from the tensorflow code while doing the migration but it can be removed.


Localisation support

Feature Request:
It would be nice if we could change the description of "Cancel", "Take photo", "Use photo" and "Retake" so it can match the app's language.

These aren't hard coded in the app anywhere.

For some reason the text is in english only (on iOS at least) if I take a picture on a dutch device, it still says: "Cancel". Where can I look to fix this ?

See: https://stackoverflow.com/questions/8258391/how-do-i-localize-uiimagepickercontroller/8268438

Thanks!


feat: Implement Copy for some types

Closes #401
Note: Copy is an API commitment. There are some non_exhaustive types that could already be Copy as well, but I'm not sure all variants will be in the future.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 5 (80.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.388%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

imap-types/src/response.rs
1
2
50.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
8848

Relevant Lines:
9577

💛  - Coveralls


exports declaration not compatible with typescript nodenext

When using nodenext, importing the library with Typescript causes an error:
Could not find a declaration file for module 'tiny-lru'<EMAIL_ADDRESS>implicitly has an 'any' type.
  There are types at '{omit}/node_modules/tiny-lru/lru.d.ts', but this result could not be resolved when respecting package.json "exports". The 'tiny-lru' library may need to update its package.json or typings. ts(7016)

Types should be included in the exports object:
"exports": {
    "types": "./lru.d.ts",
    "import": "./dist/tiny-lru.js",
    "require": "./dist/tiny-lru.cjs"
  },

Ref: https://www.typescriptlang.org/docs/handbook/esm-node.html#packagejson-exports-imports-and-self-referencing

Ok, that seems reasonable.

This is 11.0.1.


Can't move to the next page

if you can add an option to move to the next page and start generating, that would be perfect

I did not get this, are you saying that there should be an option to let current page be empty and start adding new content to new page?
If this is the case, there is already an option called PDFPageBreakView, anything added after this view will be moved to new page. Read more here.

Closing for inactive


When open the editor for large files its keeps hanging! But in sublime it works!

When I try to open large files it is hanging and I can't able to type a single in the editor. But the same when I open in sublime its working. Please fix it!

Thanks for the report! This looks like a duplicate of https://github.com/atom/atom/issues/8864 and/or #979 – feel free to subscribe there for updates.


http.client missing status code constants

httplib provides status code constants like httplib.OK. http.client in py3 maintains these for backwards compatibility. Because these constants are not included in the __all__, they are not available in future.moves.http.client. This means I can't use the future moves for this library in my project.

I don't know why, but this doesn't seem to be an issue when I use standard_library.install_aliases(), only when I use with standard_library.hooks(): import http.client


Make Poison an optional dependency

You should be able to mark poison as an optional dependency in your mix.exs, and then in all places that reference Poison, simply check if poison is available. Heres how to do it:
https://elixirforum.com/t/how-to-check-if-a-module-exists-how-to-check-if-a-module-has-a-function/581

@mgwidmann this has been addressed in the above changeset


🐛 Bug Report: Azure remote url output for software template does not work

📜 Description
I have a custom software template that publishes a repository in Azure DevOps. All steps are working fine and I can see the repository in my project in Azure DevOps. Now I click on the repository link from the screenshot.

the template.yaml:
   - id: publish
      name: Publish the repo
      action: publish:azure
      input:
        description: 'This is ${{ (parameters.repoUrl | parseRepoUrl).repo }}'
        repoUrl: ${{ parameters.repoUrl }}

    - id: register
      name: Register
      action: catalog:register
      input:
        repoContentsUrl: ${{ steps['publish'].output.repoContentsUrl }}
        catalogInfoPath: '/catalog-info.yaml'

 output:
    links:
      - title: Repository
        icon: code
        url: ${{ steps['publish'].output.remoteUrl }}
      - title: Open in catalog
        icon: catalog
        entityRef: ${{ steps['register'].output.entityRef }}

I copied this directly from the docs
👍 Expected behavior
I can see my new repository and the files.
Forwards to https://dev.azure.com/my-org/my-project/_git/my-repo
👎 Actual Behavior with Screenshots
I can see a white page and a console error: Uncaught DOMException: Failed to execute 'replaceState' on 'History':...
Forwards to<EMAIL_ADDRESS>👟 Reproduction steps
Create a software template that publishes an azure devops repository.
Use the template to create a project.
Click on the output repo link (see screenshot above)
📃 Provide the context for the Bug.
No response
🖥 Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, but I'm happy to collaborate on a PR with someone else

Hi @JetteBke this looks like the same issue here: https://github.com/backstage/backstage/issues/15724. Can you take a look and confirm, please?

Hi @awanlin yes you are right, sorry about that!

Closing as a duplicate of #15724 :)

No worries @JetteBke! I was just going through the Azure DevOps issues and noticed they looked alike but wasn't totally sure.


Datagrid: inline edit extension with isFetching property causes error

What package(s) are you using?

[X] Carbon for IBM Products (or Carbon for IBM Cloud & Cognitive)
[ ] Legacy/CDAI
[ ] Legacy/Security

Detailed description

Describe in detail the issue you're having.

When using inline edit Datagrid with the isFetching property, an error is thrown because value.text is undefined at that point. Adding an optional chain (ie value?.text) should easily fix this issue.

Is this issue related to a specific component?

Datagrid (inline edit)

What did you expect to happen? What happened instead? What would you like to
see changed?

Expected no errors using inline edit with the isFetching property.

What browser are you working in?

Chrome

What version of the @carbon/ibm-products (or @carbon/ibm-cloud-cognitive)
package are you using?

Latest

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

N/A

As part of this work, one other small suggestion that would help with our modelling structure is to have the inline edit drop down able to support items defined simply by an array of strings: items: ["item1", "item2", "item3"]. The drop down component supports this already, but a small change would still be required to remove the assumption that each item has a text field in it. In InlineEditCell file the method renderDropdownItem can be changed in these areas:
const renderDropdownItem = (item) => {
    const includesIcon = !!item?.icon;
    return includesIcon ? (
      <>
        {React.createElement(item.icon)}
        <span className={cx(`${blockClass}__inline-edit--select-item`)}>
          **{item?.text}**
        </span>
      </>
    ) : (
      **item?.text**
    );
  };

Also the label parameter for the InlineEditButton would need a small change:
label={
            type === 'selection'
              ? **value.text**
              : type === 'date'
              ? buildDate(value)
              : value
          }

Complete, will be included in next release


Testing broken while using StyleRoot in v0.16

Try to update to version 0.16
I used StyleRoot to wrap the entire app in the top component and it works fine, but the testing was broken because the testing used shallow render in TestUtils module to render each single component one by one, in that way the child component did not wrap with StyleRoot, so the test was broken. Any way to solve this problem? Thanks!
Attached the error message;

Currently you cannot render a component requiring StyleRoot on its own. We could perhaps have a test mode or some other simple method that just ignores this error for testing.

I had the same problem with my teets but I eneded up wrapping StyleRoot component on my tests too. the following example is just a basic test
import React from "react";
import should from "should";
import TestUtils from "react-addons-test-utils";
import {injectTheme} from "../../lib/ContextUtils";
import Landing from "site/components/Landing";
import I18n from "shared/components/I18n";
import RadiumWrapper from "shared/components/RadiumWrapper";

describe("Landing", () => {
    let LandingComponent;
    let LandingWithContext;

    before(() => {
        LandingWithContext = injectTheme(Landing);
    });

    beforeEach(() => {
        LandingComponent = TestUtils.renderIntoDocument(
            <RadiumWrapper><LandingWithContext /></RadiumWrapper>
        );
    });

    it("should create a new instance of Landing", () => {
        should.exist(LandingComponent);
    });

    it("should display content in English by default", () => {
        const components = TestUtils.scryRenderedComponentsWithType(LandingComponent, I18n);
        should(components[0].state.locale).be.eql("en_US");
    });
});

and RadiumWrapper consist the StyleRoot component
import React from "react";
import {StyleRoot} from "radium";

class RadiumWrapper extends React.Component {
    render() {
        return (
            <StyleRoot>
                {this.props.children}
            </StyleRoot>
        );
    }
}

export default RadiumWrapper;

I'm also running into this issue. Our project has dozens of tests, so adding a wrapper for each test is not really an option.
Would you consider demoting the error to a warning?

It truly is an error, so making it a warning will be worse for usability. We can look more earnestly into a test mode, instead. A global flag on Radium should be fine, e.g. Radium.enableTestMode().


T265 extrinsics not available

Required Info

Camera Model
T265

Firmware Version
<IP_ADDRESS>29

Operating System & Version
Ubuntu 16.04

Kernel Version (Linux Only)
4.15.0-46

Platform
PC

SDK Version
2.19.0

Language
C++

Segment
Robot

Issue Description
Similar to issue #3379 , the extrinsics between any of the streams on T265 are not available, both with my own code and with rs-enumerate-devices -c. I'm opening this issue in case the fix for intrinsics is not the same as the fix for extrinsics.

Regarding T265 extrinsics, please take a look at this PR (https://github.com/IntelRealSense/librealsense/pull/3563) it might cover what you're looking for.

Hi @aharmat17, intrinsics and extrinsics are now exposed in librealsense 2.20.0, you can see an example using both to render a virtual object in the fisheye frame here:
https://github.com/IntelRealSense/librealsense/tree/master/examples/ar-basic
Can I close this issue?


Enhancement: Change API to New Golang Server

Description
The current Healthcare Service API needs to be updated to point to the new Golang server. This will involve:

Updating the API URL to point to the new Golang server.
Adjusting any response handling based on the new API's format while ensuring the UI remains unchanged.

Tasks

Update API URL:

Change the base API URL in the frontend configuration to the new Golang server endpoint.

Review Response Structure:

Ensure that the response structure from the new API matches or is compatible with the current UI's requirements.
Update any response parsing logic if needed, to align with the new Golang API structure.

Testing:

Test all functionalities (patient management, appointment scheduling, healthcare records) to ensure they are working correctly with the new API.
Ensure that the UI remains unchanged and functional with the updated API.

Acceptance Criteria

[ ] The API URL is updated to point to the new Golang server.
[ ] The response structure from the new API is handled correctly.
[ ] The UI works seamlessly without any changes in the user interface.
[ ] All functionalities are tested and verified with the new API.

Notes

No changes are needed in the UI itself; only the backend connection needs to be updated.
Ensure backward compatibility if needed while transitioning to the new API.
Refer here for postman collection of NewGolang Server
If you want to take this issue, tell me your idea how you're going to do this.

i would like to solve this issue...thanks


Different focus styles for ScrollArea and InfiniteScrollArea

Which package has an issue?
@yamada-ui/react
Package Version
1.5.0
Description
Different focus styles for ScrollArea and InfiniteScrollArea.
ScrollArea

InfiniteScrollArea

It is strange that there are differences in style even though they are similar components.
Link to Reproduction
No response
Steps to Reproduce

Go to '...'
Click on '...'
Scroll down to '...'
See error

Browser
None
Operating System

[ ] macOS
[ ] Windows
[ ] Linux
[ ] iPadOS
[ ] iOS
[ ] Android

Do you know how to fix the issue?
Yes
Are you willing to participate in fixing this issue and create a pull request with the fix?
Yes
Additional Information
No response

The problem is not with the style of focus, but with being focused.
The InfiniteScrollArea does not need to be focused, so there is no need to set the tabIndex.


⚠ eaglestorage.com.au has degraded performance

In 5dfb51b, eaglestorage.com.au (https://eaglestorage.com.au) experienced degraded performance:

HTTP code: 200
Response time: 14533 ms

Resolved: eaglestorage.com.au performance has improved in 39addb9 after 9 minutes.


Support capturing "reasons" for subaward amount changes

After updating an amount in a subaward or expenditure, the treasury portal will accept the bulk upload template, but later expect someone to log in (via the UI) and add a "reason" for the change.
We can't make this part of the bulk upload process, but we should be able to extend support for this information to the input template file.  Once collected, we should be able to extract these changes somewhere for reference by state admins.

Split this in two: Input template and render.

Added two columns:

Added Column W

Title: “Did the Subaward Amount (Obligation) Change from Last Reporting Period?”
ID: Subaward_Changed__c (not specified by Treasury)
Required
Pick List: Yes, No
Help Text: If the Subaward amount (obligation) changed from the last reporting period, answer "Yes."

Added Column X

Title: “Reason for the Subaward Amount (Obligation) Change
ID: Change_Reason__c (not specified by Treasury)
Conditional
String: 250 characters
Help Text: A brief reason for why the Subaward Amount (Obligation) changed.

This has been implemented in v20220902


Relation widget bug when using slug as valueField

Describe the bug
Relation widget is not working when using {{slug}} as value_field as described here https://www.netlifycms.org/docs/widgets/relation/. The autocomplete field only show one suggestion, and when selecting that option no value is assigned to the field. It works perfectly when using title as value_field. The only problem then is that the relation disappears when the title of the related item changes.
To Reproduce

Add relation widget

label: Top Activeties
name: top_activeties
widget: relation
collection: <collection to search>
search_fields: ["title"]
value_field: '{{slug}}'
display_fields: ["title"]

Expected behavior
Relation field should show all suggestions. When an item is selected the title should display, and the slug should be the value in the markdown file
Screenshots
Only one suggestion when using slug as valueField

When the item is selected the field is not updated with any value, preventing me from saving the page.
This is what it should look like, but now i use title as value_field

CMS configuration
---
backend:
  branch: master
  name: git-gateway

collections:
  -
    create: false
    delete: false
    folder: "_cms_EN_frontpage"
    label: "EN: Frontpage"
    name: frontpage
    slug: "{{slug}}"
    identifier_field: "frontpage"
    editor:
      preview: false
    fields:
      -
        default: index
        label: Layout
        name: layout
        widget: hidden
      -
        label: Language
        name: lang
        default: "en"
        widget: hidden
      -
        default: Frontpage
        label: Frontpage
        name: frontpage
        widget: hidden
      -
        label: SEO (search optimalization shorttext)
        name: description
        widget: string
      -
        label: Title 1
        name: title_1
        widget: string
      -
        label: Tekstboks 1
        name: textbox_1
        widget: text
      -
        label: "Top 3 activeties"
        name: "top_3_activeties"
        widget: "list"
        summary: '{{fields.title}}'
        allow_add: true
        max: 3
        min: 3
        field: {label: Activity,name: top_activeties,widget: relation,collection: en_activity,search_fields: ["title"],value_field: '{{slug}}',display_fields: ["title"]}
      -
        label: Title 2
        name: title_2
        widget: string
      -
        label: Tekstboks 2
        name: textbox_2
        widget: text
      -
        label: Title 3
        name: title_3
        widget: string
      -
        label: Tekstboks 3
        name: textbox_3
        widget: text
      -
        label: "Gallery"
        name: "galleryImages"
        widget: "list"
        summary: '{{fields.image}}'
        field: {label: Image, name: image, widget: image}
  -
    create: false
    delete: false
    folder: _cms_EN_faq
    label: "EN: FAQ"
    name: en_faq
    slug: "{{slug}}"
    identifier_field: faq
    editor:
      preview: false
    fields:
      -
        default: FAQ
        label: FAQ
        name: faq
        widget: hidden
      -
        label: Language
        name: lang
        default: "en"
        widget: hidden
      -
        default: faq
        label: Layout
        name: layout
        widget: hidden
      -
        label: SEO (search optimalization shorttext)
        name: description
        widget: string
      -
        label: Title
        name: title
        widget: string
      -
        label: "FAQ"
        name: "faq_list"
        minimize_collapsed: true
        widget: "list"
        fields:
          - {label: Title, name: faq_title, widget: string}
          - {label: Content, name: faq_content, widget: markdown }
  -
    create: false
    delete: false
    folder: _cms_EN_about
    label: "EN: About"
    name: en_about
    slug: "{{slug}}"
    identity_field: about
    editor:
      preview: false
    fields:
      -
        default: about
        label: About
        name: about
        widget: hidden
      -
        label: Language
        name: lang
        default: "en"
        widget: hidden
      -
        default: about
        label: Layout
        name: layout
        widget: hidden
      -
        label: SEO (search optimalization shorttext)
        name: description
        widget: string
      -
        label: Title
        name: title
        widget: string
      -
        label: Body
        name: body
        widget: markdown
  -
    create: true
    folder: _cms_EN_activity
    label: "EN: Activity"
    name: en_activity
    editor:
      preview: false
    slug: "{{slug}}"
    fields:
      -
        label: Language
        name: lang
        default: "en"
        widget: hidden
      -
        default: activity
        label: Layout
        name: layout
        widget: hidden
      -
        label: SEO (search optimalization shorttext)
        name: description
        widget: string
      -
        label: Title
        name: title
        widget: string
      -
        label: "Gallery"
        name: "galleryImages"
        widget: "list"
        summary: '{{fields.image}}'
        field: {label: Image, name: image, widget: image}
      -
        label: Body
        name: body
        widget: markdown
      -
        label: Price
        name: price
        widget: string
        required: false
      -
        label: Time
        name: time
        widget: string
        required: false
      -
        label: Peoples
        name: people
        widget: string
        required: false
      -
        label: "Practical information"
        name: practical
        widget: markdown
        required: false

media_folder: static/images/uploads

Additional context
netlify-cms-app 2.14.21
bootstrap.js:85 netlify-cms-core 2.38.0
index.js:27 netlify-cms 2.10.91

Just some additional information from when I encountered this bug this weekend: it only happens when the slug of the target of the relation is something other than "{{slug}}"
So what does not work is:
collections:
  - name: "pages"
    label: "Pagina's"
    files:
      - name: "pagina"
        ....
        fields:
          - label: "Page"
            name: "page"
            widget: "list"
            fields:
              - label: "Items"
                name: "items"
                widget: "relation"
                collection: "items"
                value_field: "{{slug}}"
                search_fields: ["title"]
  - name: "items"
    label: "Items"
    folder: "content/items"
    create: true
    slug: "{{year}}-{{month}}-{{day}}-{{slug}}"
    fields:
      - {label: "Title", name: "title", widget: "string"}
        ...

But what works is:
collections:
  - name: "pages"
    label: "Pagina's"
    files:
      - name: "de-gelukkigste-klas"
        ....
        fields:
          - label: "Page"
            name: "page"
            widget: "list"
            fields:
              - label: "Items"
                name: "items"
                widget: "relation"
                collection: "items"
                value_field: "{{slug}}"
                search_fields: ["title"]
  - name: "items"
    label: "Items"
    folder: "content/items"
    create: true
    slug: "{{slug}}"
    fields:
      - {label: "Title", name: "title", widget: "string"}
        ...

I solved this by using a uuid plugin written for netlify-cms. Seems UUID is a better way for connecting relations than slug.
Feel free to close this, but i would strongly advice working on a way to implement this as a default to netlify cms.


Update Wondershare.PDFelement to 8.3.6

Microsoft Reviewers: Open in CodeFlow

/rerun-pipelines-please

Hmm.

lol

@ItzLevvie2 I think that as a mod if you comment Duplicate of <#XXXXX on the issues, it would close them. I could write a quick powershell statement to do that if you wanted

@ItzLevvie2 I think that as a mod if you comment Duplicate of <#XXXXX on the issues, it would close them. I could write a quick powershell statement to do that if you wanted

I tried it before (https://github.com/microsoft/winget-pkgs/issues/38714#issuecomment-999960446) but I don't think @denelon has added me for it to work.
https://github.com/microsoft/winget-pkgs/issues/38926
https://github.com/microsoft/winget-pkgs/issues/38926

@ItzLevvie2 I think that as a mod if you comment Duplicate of <#XXXXX on the issues, it would close them. I could write a quick powershell statement to do that if you wanted

I tried it before (#38714 (comment)) but I don't think @denelon has added me to the rule for it to work.
#38926

I cri

We're working on the bots to give moderators the ability to close duplicates, I might take a look to see if I can do that this afternoon. It will get refactored, but it's a start.

We're working on the bots to give moderators the ability to close duplicates, I might take a look to see if I can do that this afternoon. It will get refactored, but it's a start.

It seems to work for Joakim and Esco, just not Levvie

I have "ItzLevvie" in the rule for the pkgs repository.

I have "ItzLevvie" in the rule for the pkgs repository.

Interesting. I don't know why it didn't work on https://github.com/microsoft/winget-pkgs/issues/38926 then

No clue on my end. No typo or anything. It's essentially just an "or" with username.


[wip] GRPC client

Hi,
This PR is a work in progress and the idea is to start the discussion on how to provide a GRPC client for Phoenix. The Phoenix PR is here: https://github.com/owncloud/phoenix/pull/2613
Motivation and Context
At CERN we want to test the feasibility of using GRPC between REVA and the webapp. As it was agreed with Owncloud, to accomplish this the owncloud-sdk should define a very clear interface, usable by Phoenix, and it should be modular in order to easily replace the current webdav implementation with something else. But this is not the case at the moment.
Description
This PR creates new class representations of elements that Phoenix requires: for now I have a File class and I'm working on others like FileTrashBin, Share, etc. If you already have any documentation on this, please let me know. If not, let's discuss what is required.
These new classes have no knowledge about webdav, they are completely agnostic, and they replace the current SomethingInfo. The responsibility to convert from webdav to our internal representation is inside the Converter functions. GRPC works in the same way.
I'm also removing completely the possibility of Phoenix to define what "webdav properties" to request, thus moving all of these from Phoenix to sdk. This is the only way we could provide a common interface for any access type! Phoenix should only know about the sdk interfaces/objects and nothing else. This also means that we need to clarify what methods are required (again, if you have some internal documentation, can I get more details about it?). I'm saying this because I see things like, for example, mkdir, createFolder, recursiveMkdir. Aren't these, more or less, the same thing?
Finally, this PR has a REVA/GRPC client and a FileManagement class that allows listing a directory. This is already usable, so you can list files in Phoenix, but nothing else. I'll work on the remaining methods once we agree on them.
Please ignore the documentation.
What do you think?
Diogo

@felixboehm @DeepDiver1975 please give feedback :)

For me it's perfectly fine to have separate implementations. What's missing are the interfaces.
And it was just easier to prototype both together so I could move between one and the other easily.
Do not forget this is a prototype.

Using build time tools (yarn/npm) everybody can pick the desired implementations.

I think that would be the best approach, also if you want to Graph APIs it should be done in the same way WebDAV and Grpc is done (abstracted from the developers).
@DeepDiver1975 any idea on how to hook the transport library in the build process? I imagine it requires changes in Phoenix itself

any idea on how to hook the transport library in the build process? I imagine it requires changes in Phoenix itself

I could image a possible approach is:

yarn remove owncloud-sdk
yarn add owncloud-sdk-grpc

Or have both required by yarn but a build switch is choosing which to import
if (env.BUILD_WITH_GRPC) {
    import sdk from 'owncloud-sdk-grpc'
} else {
    import sdk from 'owncloud-sdk'
}

One need to look deeper on how to do this

Failing tests:

ERROR in ./tests/XmlParserTest.js
--

This is a PR to kick start the discussion only, as I mentioned before...
I did not fix the tests (in this case I would have to change the import path from ../src/xmlParser to ../src/webdav/xmlParser) nor finished everything. We need to define first what path to follow, as I don't want to waste time in code that is going to be thrown away.

Ideas on build time decision on which transport to be used: https://stackoverflow.com/questions/28572380/conditional-build-based-on-environment-using-webpack


[ENH,WIP] Starting an implementation of templateflow's registration

Closed in favor of the 4 issues listed above.


no output

im am doing the following command  "monke unpack "C:\Users\olive\AppData\LocalLow\Ninja Kiwi\BloonsTD6-Epic\9adfd9ba7a484cf0a99a7904eddb12a9\link\PRODUCTION\current\Profile.Save" "C:\Users\olive\Pictures" 11"
and i am not getting an error nor any output please help thx :=)

nv fixed monke unpack Profile.Save Profile.Save.json 11 worked

i do have a question though i waht to just get a maxed save or summon what should i put in the json file for that

Try:
"monke unpack "C:\Users\olive\AppData\LocalLow\Ninja Kiwi\BloonsTD6-Epic\9adfd9ba7a484cf0a99a7904eddb12a9\link\PRODUCTION\current\Profile.Save" "C:\Users\olive\Pictures\Profile.save.json" 11"

Oops, I am unable to read apparently.

It doesn’t currently output an error if it fails. I have a version with error messages on my laptop and will push it soon.


Refactor: Avoid conversion to []byte by using WriteString

This PR replaces .Write([]byte(...)) with .WriteString(...).

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[x] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

Hi @alexandear. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alexandear: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
0867ebab7c0e6e50846362a1d8f4f27fbf956347
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@alexandear: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
0867ebab7c0e6e50846362a1d8f4f27fbf956347
link
unknown
/test unit-tests-arm64

integ-basic-arm64_istio
0867ebab7c0e6e50846362a1d8f4f27fbf956347
link
unknown
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Add Custom Directive Support for Fields

based on graph-gophers/graphql-go#446 and work by @eko
I intend to revive the stalled conversation from #446 with this PR. I addressed the open comments on that change.

I added a commit that addresses your comment. I will keep my changes in a separate commit and then we can squash the whole thing down when we are ready merge.

@pavelnikolov thanks for the review feedback so far. I have some questions about how we should handle errors from directive visitors. Wondering if you've thought this through before.

@rudle I think that it is fine to stop execution if we have an error in the Before method of a directive. It makes sense to prevent further execution. We can also make it configurable.
On a separate note, I was thinking that we should make method resolver execution configurable based on logic in the Before directive method. Imagine a @cache directive which would cache fields for a certain amount of time. And if the value is present in the cache the code should not produce a query to the backend storage. Before merging we should think of practical examples, like @auth(hasRole="editor"), @cache(for="10m") (such a caching directive would be different to the commonly used @cacheControl(maxAge="300", scope="PUBLIC") which is used to set cache-control headers on the response - if something is found in the cache we don't hit the DB).

Does that make sense or is it too much to think about for now?

I'm not opposed to adding on to this PR nor am I in a rush to have it merge it, but I don't have the time to do the requirements gathering you're describing here.
What I will do as a next action is experiment with different options for how we can pass state between Before(), the Method Resolver and After() and report back here. I said above that the context.Context may be our only choice, but I'd like to convince myself of that.

What I will do as a next action is experiment with different options for how we can pass state between Before(), the Method Resolver and After() and report back here. I said above that the context.Context may be our only choice, but I'd like to convince myself of that.
Maybe we can have a 3rd method which returns bool value indicating whether we need to execute the resolver method or no. Because obviously the directive is a struct and the Before and After methods can shared state either through the context or using struct fields. However, the library needs to agree on some special method, which indicates whether we need to execute the method resolver between the Before and After 🤔

OK. A 3rd return value from Before makes sense to me. I wonder if it need to be a whole method? I guess that's more flexible, but at the cost of a broader API.
I just did a quick code sketch of a directive implements server-side caching via a struct field set in Before and a return of that value as the result of resolution in After and it felt pretty good to me.
Earlier today, I tried to find a nice way for Before to pass data into a resolver, but I didn't like any of the options I came up with. I hope we can avoid this requirement.

above commit adds a new test case that demonstrates how to implement server-side caching. It takes the approach of adding a second return value to Before(). I'm open to adding a 3rd method to the Visitor interface also.

Thank you @rudle! Happy New Year! I like the 3rd return value! This makes sense to me and looks nice.
I was looking at the connections specification and this example looks interesting to me. Imagine this query:
{
  user {
    id
    name
    friends(first: 10, after: "opaqueCursor") {
      edges {
        cursor
        node {
          id
          name
        }
      }
      pageInfo {
        hasNextPage
      }
    }
  }
}

So imagine we want to cache the friends of a user and when we open their profile get the first 10 friends from cache. The schema declaration would look like this:
    ...
    friends(first: Int = 10, after: ID) @cache(ttl: Int = 300, key: String) FriendsConnection!
    ...

The interesting thing there is the key. This would be our cache key. Since we have many users and the directive is applied to each of them, how do we know which user's friends are we picking up from cache? We need to cache based on the user ID, right? So our "key" would be something like parent.id or something similar. I'm not sure how to resolve that problem. I found this directive and it seems that they accept parent, args and vars cacheKeys prefixes, as in:
parent.<field-name>
args.<argument-name>
vars.<variable-name>

see their "understanding cacheKey argument section".
So my final issue before merging this PR is: do we need to give the directive access to the parent object and query context (like arguments and variables). The field (method) arguments should be accessible I think, however, that is not enough since often times we should cache based on the parent ID. Chances are we have that ID in the Before method already. However, in order to create a fully field agnostic directive, we need to work with any type of parent ID/key. Do you think this is important?
Other than that, I am happy with this PR. I have few other thoughts:

Maybe I should state that the directives API is not stable yet. This would give us an option to iterate on it before we call it final? Thoughts?
I was thinking about checking out what's needed for something like Apollo Federation. This relies heavily on custom directives. I might take a look. I don't mean fully implementing it. I mean just checking if the current implementation would support such a use-case. Ideally, I don't want to bake such features in the library with special directives that we treat in some different way. It would be nice if the library would allow users to extend it and build anything they want.

Hello! Happy new year. Thanks for all the feedback so far. Excited that this is maybe getting close!

Maybe I should state that the directives API is not stable yet. This would give us an option to iterate on it before we call it final? Thoughts?

Definitely agree with this. I appreciate the legwork you have already done to find some specific directives to help guide the API. The graphql-go community will no doubt have more specific feedback for this initial implementation as they try it out on their own applications. I also suspect that once this PR lands, more small contributions and improvements from the community will quickly follow. We should plan to iterate on this API and document that things are unstable.

Another directive to consider is a sample query complexity directive. Such a directive would need access to the field args, for example:

This is supported in this PR, but in an untyped way. The 3rd argument to Before contains the traceCtx and also all args to the field. The input isn't typed, so the resolver would need to know the type of the field resolver method in order to use them. A less sophisticated approach would be: splatting them all together and calling .String(). Could the former approach be as easy as passing in res.Method(f.field.MethodIndex).Type or something like that?

Regarding the parent object

This makes some sense to me but it seems hard to support. I don't know of any prior art for this type of thing within graphql-go. It seems to me that each field resolves in isolation of other fields and that walking up and down the graph isn't supported. It seems a bit related to this very old issue #17.

This makes some sense to me but it seems hard to support. I don't know of any prior art for this type of thing within graphql-go. It seems to me that each field resolves in isolation of other fields and that walking up and down the graph isn't supported. It seems a bit related to this very old issue https://github.com/graph-gophers/graphql-go/issues/17.
Indeed it is similar issue, however, I can imagine people opening issues about it. The selected fields issue is easy to solve, but it is difficult to implement in a type-safe way without changing the existing resolver API. I don't want field resolution to happen through the context if possible. This would require some other argument to the resolvers containing information about the GraphQL request such as the selected fields and maybe some other info in future.

@rudle I added a few commits to your branch. I added an example @hasRole directive as one of the most popular examples from the community for declarative authorization. I love the custom directive feature overall but here are some topics which might need polishing:

We pass ctx to the Before and After methods. Instead I believe we need to pass the traceCtx this way the activity of the directive visitors will be added to the trace graphs. However, in order to do this in a protocol-agnostic way (e.g. OTEL, OpenTelemetry etc.) we need to create some kind of directive tracer interface. Then check if the provided tracer implements the directive visitor interface and wrap the Before and After methods with a trace span.
Alternatively, since we could just pass to them the traceCtx and leave it to the user to start a span inside of these methods.

I just pushed a commit which passes the traceCtx to the directive visitors. The users can opt-in to use that.

I'm going to merge this PR the way it is. It already covers basic usage of field directives. I put a note in the readme that the directives API is potentially subject to change in future versions. You are correct that some of my ideas are outside of the scope of this PR. When in future it is possible to check selected fields in a resolver it will be introduced retrospectively into directives as well. Then potentially we will be able to access field arguments as well. That is why I stated that potentially the directives resolver API is subject to change.
Thank you @rudle

Thanks @pavelnikolov! I was just checking in on this PR and am happy to see that it's merged.
I'm excited for the next steps that will make this feature more powerful, especially checking for selected fields.

There is one thing that I'm not completely happy about in this PR and it's the arguments of the directives. I don't like the way we extract them now. I wish we could assign directly to a struct in a type-safe way similar to the way resolvers do it and also get validated during schema parsing. However, this would be tricky.
The selected fields in resolvers/directives/context is the next thing on my list. It has been the most requested feature. I've implemented it a few times already. I'm just going to start a new issue with requirements and try to make it user-friendly and without breaking changes. If you are interested - feedback/contributions would be more than appreciated.


error when building

package 'UI' requires minimum Swift language version 5.2 which is not supported by the current tools version (5.1.0)
how to update?

have you used Xcode 11.4 Beta?

I'm using the new Xcode 11.4 beta 1, so I've updated the Swift version to 5.2. You can download it from Apple dev center and then you'll be able compile the app

I change  swiftLanguageVersions: [
.version("5.1.0")
]
and resolved my problems.


Fix collection dropdown not activating

Issue happened when a collection was named with one or more underscores

Codecov Report

Merging #361 into 2.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x     #361   +/-   ##
=======================================
  Coverage   85.89%   85.89%
=======================================
  Files          38       38
  Lines         723      723
=======================================
  Hits          621      621
  Misses        102      102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05d142b...e953c1f. Read the comment docs.


Add tags for activity and local activity metrics

https://github.com/uber-go/cadence-client/issues/614
activity metrics (except poll related metrics) and local activity metrics will contains both tags of WorkflowType and ActivityType(LocalActivityType)

Coverage decreased (-0.02%) to 69.008% when pulling 8f98747ad65d5fc894322dd2cae495af9094fcb6 on metric into ed836f63720b32c8ea922f1052b222079d4fa4c8 on master.


Updated README.rst

Improved the README for concision and clarity.

I added the changes you mentioned.  Glad to help out :)

Great, thanks :+1:


remove retry

Retrying is leading to worse outcome where an order is successfully sent but received an error. Effectively, duping orders is worse than no orders, which will get cleaned up on the next re-run


Large file read error

When you read file by somethig like
var reader = new FileReader();
reader.onloadend=console.log;
reader.readAsText(file);

and if the file is bigger that CHUNK_SIZE (256kB) it gives you corrupted file: for example reading file that has about 0.5MB i get string, which length is over 800 000 characters (tested on android).
My solution, in www/FileReader.js instead of line
readSuccessCallback.bind(this, readType, encoding, offset, totalSize, accumulate),
put
readSuccessCallback.bind(this, readType, encoding, offset, Math.min(totalSize - this._progress, CHUNK_SIZE), accumulate),

Does this bug happen only on Android?
What version of Android?
Did you encounter the same problem in iOS?
What exactly does your solution do? Can you explain it in plain words?

When plugin exec java code, sends how many bytes to read. But it sends size of whole file. And when it recived from java code, it increments this._progress by CHUNK_SIZE
 this._progress = Math.min(this._progress + CHUNK_SIZE, totalSize);
And then it asks java code (by exec function) for the rest of file, although it already has whole file.
I didn't tested on other platforms.

Could you please create a Pull Request with your change? (You can ignore the requirement for JIRA issue when creating the PR - we are currently removing this)

Even i'm facing similar issue with android6.0 where im getting an error like  "Failed to allocate a ***** byte allocation with 1243880 free bytes and 24MB until OOM.... the issue is getting resolved when i include a parameter  android:largeHeap="true" in android manifest file.
Is this bug resolved?
As we are expecting the file is going to be much more larger in future (Ex.20-24MB JSON file) in future for our applications.

I've posted a link to a workaround with readAsArrayBuffer for the chunk size problem in #284.


Initial implementation of encoding integers to strings

This is in reference to #120.
I added some code to enable marshalling and unmarshalling the following types to/from strings:

int
int64
*int
*int64

To accomplish this, you would use a struct tag of string, like the built-in json encoding package. For example:
type Example struct {
  // ...
  ParentID int64 `jsonapi:"attr,parent-id,string"`
  // ...
}

I have added tests to verify my new functionality is working as expected and all existing tests still pass, so I don't think I messed with the default behavior by doing this.
Thanks!

Signed CLA per the comment.

Looks good so far, please add tests for error cases, e.g. not an int on parse. @mylanconnolly

Added a test case to include strings that cannot be parsed to numbers.
Please let me know if you'd like to see more test cases. I don't believe my changes affected any more logic than that.

Please add support for doubles/floats too.


Do you support reload/rebuild ef entity class in runtime?

Can i rebuild/modify class definition in runtime without restart webapp?

you can write a small function of unloading and loading assembly again manually from ALC.
hope this helps.


Syntax highlighting vscode

with the addition of elif the highlighting is not right anymore in a couple of places

[ ] vscode
[ ] misc/inmanta.vim
[ ] inmanta-sphinx: sphinxcontrib/inmanta/pygments_lexer.py

Hey team! Please add your planning poker estimate with ZenHub @arnaudsjs @bartv @FloLey @Hugo-Inmanta @sanderr

I think no changes are required fot inmanta-sphinx as the keywords are imported:
https://github.com/inmanta/inmanta-sphinx/blob/b95fd8660089231346011a32d96c069710017d89/sphinxcontrib/inmanta/pygments_lexer.py#L22
Am I correct?

Indeed, good find. Looking at the docs confirms this as well.


Add GH Actions Workflow to check for Syntax Errors that would break the readthedocs.org Build

...using myst-nb. This is to avoid build errors such as this one.

Completed with https://github.com/brightway-lca/brightway-examples/commit/0532828480cc0828863d2c33b47ca156be2eb069 and https://github.com/brightway-lca/brightway-examples/pull/5.


does anyone have any guide or know if multus works with Racher k3s?

does anyone have any guide or know if multus works with Racher k3s?
Thanks

My pod never launches and I get validateIfName: interface name net1 already exists
Normal   Scheduled                 default-scheduler               Successfully assigned default/samplepod to localhost.localdomain
Normal   AddedInterface          9s         multus                          Add eth0 [<IP_ADDRESS>/24]
Normal   AddedInterface          9s         multus                          Add net1 [] from default/macvlan-conf
Normal   AddedInterface          9s         multus                          Add eth0 [<IP_ADDRESS>/24]
Warning  FailedCreatePodSandBox  9s         kubelet, localhost.localdomain  Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "6680c8253a85b20d0b5e21e95ae1ba7a0a2d85cd91ac621c40e2da5dd454f025": [default/samplepod:macvlan-conf]: error adding container to network "macvlan-conf": delegateAdd: cannot set "" interface name to "net1": validateIfName: interface name net1 already exists
/etc/cni/net.d/70-multus.conf
{
"name": "multus-cni-network",
"type": "multus",
"logFile": "/var/log/multus.log",
"logLevel": "debug",
"readinessindicatorfile": "/var/run/flannel/subnet.env",
"delegates": [
{
"type": "flannel",
"name": "flannel.1",
"delegate": {
"isDefaultGateway": true
}
}
],
"kubeconfig": "/etc/cni/net.d/multus.d/multus.kubeconfig"
}
apiVersion: "k8s.cni.cncf.io/v1"
kind: NetworkAttachmentDefinition
metadata:
name: macvlan-conf
spec:
config: '{
"cniVersion": "0.3.1",
"plugins": [ {
"type": "macvlan",
"master": "eth1",
"mode": "bridge",
"ipam": {}
} ]
}'
apiVersion: v1
kind: Pod
metadata:
name: samplepod
annotations:
k8s.v1.cni.cncf.io/networks: '[
{ "name": "macvlan-conf"}
]'
spec:
containers:

name: samplepod
command: ["/bin/bash", "-c", "trap : TERM INT; sleep infinity & wait"]
image: dougbtv/centos-network

Name:         samplepod
Namespace:    default
Priority:     0
Node:         localhost.localdomain/<IP_ADDRESS>
Start Time:   Sat, 29 Aug 2020 05:15:39 -0400
Labels:
Annotations:  k8s.v1.cni.cncf.io/network-status:
[{
"name": "",
"ips": [
"<IP_ADDRESS>"
],
"default": true,
"dns": {}
},{
"name": "default/macvlan-conf",
"interface": "net1",
"mac": "4e:e5:1e:6b:f6:1a",
"dns": {}
}]
k8s.v1.cni.cncf.io/networks: [ { "name": "macvlan-conf"} ]
k8s.v1.cni.cncf.io/networks-status:
[{
"name": "",
"ips": [
"<IP_ADDRESS>"
],
"default": true,
"dns": {}
},{
"name": "default/macvlan-conf",
"interface": "net1",
"mac": "4e:e5:1e:6b:f6:1a",
"dns": {}
}]
Status:       Pending
IP:
IPs:
Containers:
samplepod:
Container ID:
Image:         dougbtv/centos-network
Image ID:
Port:
Host Port:
Command:
/bin/bash
-c
trap : TERM INT; sleep infinity & wait
State:          Waiting
Reason:       ContainerCreating
Ready:          False
Restart Count:  0
Environment:
Mounts:
/var/run/secrets/kubernetes.io/serviceaccount from default-token-w9zhv (ro)
Conditions:
Type              Status
Initialized       True
Ready             False
ContainersReady   False
PodScheduled      True
Volumes:
default-token-w9zhv:
Type:        Secret (a volume populated by a Secret)
SecretName:  default-token-w9zhv
Optional:    false
QoS Class:       BestEffort
Node-Selectors:
Tolerations:     node.kubernetes.io/not-ready:NoExecute for 300s
node.kubernetes.io/unreachable:NoExecute for 300s

I've been battling this as well and I just got it to work.  Your distro may use different paths, but make sure /opt/cni/bin is where your plugins are located.
I installed a single node k3s cluster using the following command:
curl -sfL https://get.k3s.io | INSTALL_K3S_EXEC="--flannel-backend=none" sh -
Then I installed Flannel:
kubectl apply -f https://raw.githubusercontent.com/coreos/flannel/master/Documentation/kube-flannel.yml
Your /etc/cni/net.d/ should have "10-flannel.conflist" listed
I followed the quick start instructions utilizing the daemonset. After updating the mater interface and deploying the sample pod, everything worked.

that did the trick, Thanks


Cannot run a simple SELECT query

Please, make it clear on this page that querying the database is not currently implemented.
You can connect to the database but cannot run a single SELECT statement.
This is the case for at least an year - are there any plans to implement it at all?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ad5899cc-4757-b131-c36e-a0243b5bad95
Version Independent ID: 8df879ca-e629-a313-6af9-8a6c3c04eefe
Content: Quickstart: Connect and explore Oracle databases - Azure Data Studio
Content Source: docs/azure-data-studio/quickstart-oracle.md
Service: azure-data-studio
GitHub Login: @tdoshin
Microsoft Alias: timioshin

page already says:
Note

Currently extension provides a read-only view of the database objects. Running queries is not supported.

#assign:dzsquared

#please-close


Shim close() to process.exit()

How would I shim close() to process.exit()?

Using Deno.exit(0) worked for me


How to configure a global GitHub account password？

How to configure a global GitHub account password, so that when the webhook executes the script, it can read the global account password and pull the code package

Starting in 2021, GitHub removed the option to use a username and password for Git operations and instead requires the use of personal access tokens (PATs) or SSH keys.

@nitishmalang   I have 30 projects on a GitHub account. It is very troublesome to configure and maintain ssh keys for each project. Is there any good solution? Thank you


Property 'status' does not exist on type 'XMLHttpRequestEventTarget'

Hi,
When I try to compile the current v2 branch I get
ERROR in [at-loader] node_modules/api-ai-javascript/src/XhrRequest.ts:69:26
    Property 'status' does not exist on type 'XMLHttpRequestEventTarget'.

ERROR in [at-loader] node_modules/api-ai-javascript/src/XhrRequest.ts:69:48
    Property 'status' does not exist on type 'XMLHttpRequestEventTarget'.

I guess this can be fixed by replacing
if (this.status >= 200 && this.status < 300)

with
if (client.status >= 200 && client.status < 300)

Thank you for your report, looks like i have some custom definitions on my other laptop. I push fix.


Fix for bug #86

Fix for bug #86
Tests v8 before fix:
Excluding skipped: 89.5% (3630/4054) passed
Including skipped: 82.7% (3630/4392) passed

After fix:
Excluding skipped: 89.6% (3631/4054) passed
Including skipped: 82.7% (3631/4392) passed

I have already signed OCA with my backup mail: victor two at ukr dot net

Hi,
thanks for your contribution. I see you listed as Victor Polischuk - OpenJDK - victor.polischuk. I'll update our CI so it accepts this.
Best, Christian

Thank you for an attempt to provide a fix for bug #86. Your patch really ensures that the expression mentioned in the bug does not trigger a SyntaxError. Unfortunately, it also results in other expressions (like Object({a=1})) not to trigger SyntaxError incorrectly.

Excluding skipped: 89.6% (3631/4054) passed
Including skipped: 82.7% (3631/4392) passed

Also I believe it covers only the case with async arrow functions

Thank you for another attempt to fix bug #86. This attempt looks much better than the first one and is very close to a correct fix, I believe. Unfortunately, there are still some corner cases that are not handled correctly. async token can either represent a modifier of an async function or it can be an identifier (of a normal/non-async function possibly). Your fix does not handle the latter case correctly. It accepts expressions that should lead to SyntaxError. For example, async({a=1}) should trigger a SyntaxError but it does not.
In fact, I already have a fix for bug #86 ready for a review in our internal system. The fix handles the mentioned corner case correctly but is very similar to your fix otherwise.
Note that we appreciate external contributions. I am sorry that our efforts clashed on fixing of bug #86. If I knew that you will attempt to fix the issue on your own then I would not start the work on the fix myself.

No problem, I was just blocked with the bug. I am glad it is fixed. Thank you.


occasional zero rewards in pommerman team competition envt

As title says, I'm occasionally getting zero rewards for all agents in the TeamCompetition environment - what condition leads to that? as far as I know, a victory leads to +1, loss leads to -1 and ties lead to -1 for all agents.

It's right here in the rewards --> https://github.com/MultiAgentLearning/playground/blob/master/pommerman/forward_model.py#L621
It happens when the game has not ended yet (and consequently it's frequent).


Load + USB output state machine rework needed

Currently, USB and load output are both mangled in one file and have similar state machines. However, the state machines are not exactly the same, so we have lots of duplicated code.
In addition to that, errors in the load output sometimes need to overrule also the USB output. So we have duplicated code also in the error checking mechanisms.
The load output state is currently also used to indicate errors (saying why it is off and not only that it is off). Most of these errors are also indicated in the global log_data.error_flags. So we have another redundancy and source of issues here.
Don't have a good idea for improvement yet, but want to raise the issue so that we can think about it and discuss suggestions.

I'm currently working on this topic. Will also remove lots of duplicate code here, @hogthrob.

Appreciated 👍

Done for the load state machine in commit f254c77ab6793b393439f74d2e2ea31045fc450b.
USB state machine is still as before. We should probably also add USB-specific error flags, as the SMPS on the MPPT 1210 HUS has a power-good signal that can be read by the microcontroller.

USB state machine was also updated in the meantime. USB and Load output are now based on the same C++ class.


"No Safes" copy and CTA updates

@decentdao/product @decentdao/design
I can see there are "No Safes", but I don't know what that means, or what I could do to rectify it. It likely isn't "Create a Safe" since many of our prospective customers already have them.

Can we add some copy that tells the user what this list will contain?
Can we add some copy that tells the user what to do to add Safes to the list? Encourage them, conversationally. Ie "You haven't added any Safes yet! Search for a safe above to start tracking its governance activity" or similar.

Originally posted by @parkermccurley in https://github.com/decentdao/decent-interface/discussions/1863#discussioncomment-9524294
See original comment thread.

This is on @decentdao/design to take first pass

@adamgall This is ready. Please keep text on a single line until mobile.
I'll remove the design label and move this back to ready.


Update select arrow to match figma

Closes #336

The dropdown menus were displaying with a gray background. FTFY.

Also, there should be 20-23px of space to the left of each dropdown menu.


Refined GitHub updates

Welcome to Refined GitHub!
You can subscribe to this thread to receive updates regarding new features added to the extension. Click the Subscribe button in the sidebar!
Enabling API-based features
Make sure you create and add a Personal Access Token in the extension’s options to ensure every feature works correctly.
Debugging
If any feature isn't working, open the web console and look for Refined GitHub-related errors.
Contributing
Suggestions and pull requests are highly encouraged! Have a look at the open issues, especially the easy ones. Check out contributing.md for more info!

https://github.com/sindresorhus/refined-github/issues/818

Automatically closes modals when they’re no longer visible
Shows all keyboard shortcuts in the help modal (? hotkey)
Adds links to the default branch and to the latest semver release
Adds Commented button to Issues/Pull Requests page
Highlight closing PRs in open issues and PRs
Show latest tag in latest release button

Open multiple issues at once in your repos.
Possibly-related issues are shown when creating a new issue.
Merged PRs show the closing commit in the header.
Permalinked comments are highlighted. Example on this page.
Add your own custom CSS to GitHub without having to install Stylish.
Inactive deployments in PR timelines are hidden.

GitHub has implemented many of Refined GitHub's features natively through their Paper Cuts initiative. 🎉
Refined GitHub with GitHub Enterprise now works on Firefox.
404 pages are now more useful.
Navigate with arrow keys through pages with navigation.
User profile contribution activity automagically expand when you scroll down.
Useless comments are now hidden.
You'll now see a badge on a user's profile if they follow you.
Forks are hidden from a user's Repositories list (but they can still be shown).
Filter PRs that you haven't submitted a review for.
Followers you know are shown on profile pages.

Refined GitHub was rewritten in TypeScript.
Add co-authors when merging PRs with multiple committers. https://github.com/sindresorhus/refined-github/commit/e0bce6fcbe0dc21006d320bf72b974af13ba544a
Insert collapsible content when writing comments (via <summary>). https://github.com/sindresorhus/refined-github/commit/547795cb5e204b2465e32d306d64a3eae1879747
Your issues and PRs are highlighted in the issue/PR list. https://github.com/sindresorhus/refined-github/commit/681bf2c20a14e0212e0724ab1b8cd67784c3fa03
Search for issues and PRs separately in the global search. https://github.com/sindresorhus/refined-github/commit/abebd9fc7b9f07d8ea0981b0f6e196ef0c5483ca
Star/unstar a repository by pressing g s. https://github.com/sindresorhus/refined-github/commit/9eb93b11e9a8c4bdc1ba19a91ec153fd1dc1af57
Bypass the "Checks" page and go directly to the Travis build when clicking the "Details" links on a PR https://github.com/sindresorhus/refined-github/commit/5c45ccb0313b813c76e6a673bd7ee2c83fb394ba
Exclude PR/issue filters from their list with alt/option-click. https://github.com/sindresorhus/refined-github/commit/07b247295255d37a4f61df60a19b688d4b903a1d
Find a user’s most starred repositories in their profile. https://github.com/sindresorhus/refined-github/commit/483dc65817d3104e87cb0b0b4067bbb20a10eb7d
The PR/issues search box expands when focused. https://github.com/sindresorhus/refined-github/commit/29faf28bb816cbecb8fb834d5461a22fd9913eda
Significant head and base branches are shown in the PR list. https://github.com/sindresorhus/refined-github/commit/f25483fa128d9dcc8e1e74fcf2d2751d604fe11f
GitHub has implemented even more of Refined GitHub's features natively through their Paper Cuts initiative.

Fix merge conflicts in a click ← https://github.com/sindresorhus/refined-github/pull/1882
Follow file renames in commits lists ← https://github.com/sindresorhus/refined-github/pull/1870
View the source of Markdown files ← https://github.com/sindresorhus/refined-github/pull/1873
Hidden comments are previewed inline ← https://github.com/sindresorhus/refined-github/pull/1755
Change diff style and whitespace visibility in one click ← https://github.com/sindresorhus/refined-github/pull/1799
Press esc to deselect the current line when viewing files ← https://github.com/sindresorhus/refined-github/pull/1878
Comment boxes expand with their content and no longer show scroll bars ← https://github.com/sindresorhus/refined-github/pull/1871
Edit comments in one click ← https://github.com/sindresorhus/refined-github/pull/1880
Your issues and PRs are highlighted ← https://github.com/sindresorhus/refined-github/pull/1782
Insert collapsible content when writing comments (via <details>) ← https://github.com/sindresorhus/refined-github/pull/1804
Forks and watchers counters are hidden ← https://github.com/sindresorhus/refined-github/pull/1820
Text wrapped in `backticks` in issue titles is highlighted ← https://github.com/sindresorhus/refined-github/pull/1872
The Projects tab is hidden from repositories and profiles when there are no projects. https://github.com/sindresorhus/refined-github/pull/1788
A warning appears when trying to create a PR from the default branch ← https://github.com/sindresorhus/refined-github/pull/1758
Links to an issue's closing commit, not just pull request ← https://github.com/sindresorhus/refined-github/pull/1832
Diff signs are hidden ← https://github.com/sindresorhus/refined-github/pull/1866
The PR/issues search box is wider ← https://github.com/sindresorhus/refined-github/pull/1886
Tall code blocks and quotes are limited in height ← https://github.com/sindresorhus/refined-github/pull/1146
Search for issues and PRs separately in the top search ← https://github.com/sindresorhus/refined-github/pull/1738
Access Commits and Branches from the More dropdown ← https://github.com/sindresorhus/refined-github/pull/1825

See an automatic changelog for each tag or release. ← https://github.com/sindresorhus/refined-github/pull/1998
Update a PR from the base branch to ensure it build correctly before merging the PR itself (same-repo branches only). ← https://github.com/sindresorhus/refined-github/pull/1950
Update the PR’s title to the merge commit title, if changed. ← https://github.com/sindresorhus/refined-github/pull/1960
Edit files straight from a repo’s list by clicking their icon. ← https://github.com/sindresorhus/refined-github/pull/1939
Filter pull requests by their build status. ← https://github.com/sindresorhus/refined-github/pull/1904
Browse a repository at the time of each comment, including each link. ← https://github.com/sindresorhus/refined-github/pull/1863
Search or select tags from a dropdown in the Releases page. ← https://github.com/sindresorhus/refined-github/pull/1896
The checks tab in PR is removed unless you're owner ← https://github.com/sindresorhus/refined-github/pull/1929
View the raw version of files in PRs and commits. ← https://github.com/sindresorhus/refined-github/pull/1924
Hide milestone sorter UI if you don’t have permission to use it. ← https://github.com/sindresorhus/refined-github/pull/1980
SVG files in a PR default to rich-diff view. ← https://github.com/sindresorhus/refined-github/pull/1932
Link to file itself in the history pages ← https://github.com/sindresorhus/refined-github/pull/2000
Empty sections in the issue/PRs sidebar are hidden or collapsed. ← https://github.com/sindresorhus/refined-github/pull/2011

Open issues to the latest comment by clicking the comments icon. ←  #2028
Wrap code inside all code blocks to match indentation.  ← #1989
The most useful comment in issues is highlighted.  ← #2108
Download count is shown next to release assets. ←  #2027
Projects and Milestones filters are dropped if they are empty. ←  #2114
Cycle "popover lists" (labels, milestones, etc) when selecting them with the ↑ and ↓ keys. ←  #2140
Add upload button to the comment toolbar and remove the upload message. ←  #2157
Limits the length of commit fields to 72 characters ←  #2115

July 2019

 Linkifies symbolic links files. ← https://github.com/sindresorhus/refined-github/pull/2277

 🔥 Shows whitespace characters. ← https://github.com/sindresorhus/refined-github/pull/2073

 Shows PRs that touch the current file. ← https://github.com/sindresorhus/refined-github/pull/2197

 Adds a button to submit a single PR comment if you mistakenly started a new review.  ← https://github.com/sindresorhus/refined-github/pull/2188

 Adds a shortcut to your forks next to the Fork button on the current repo. ← https://github.com/sindresorhus/refined-github/pull/2153

August 2019

Hide unnecessary tip on comment field ← https://github.com/sindresorhus/refined-github/pull/2375

 Adds comment indicators when comments are hidden in PR review. ← https://github.com/sindresorhus/refined-github/pull/2320

 Adds button to revert all the changes to a file in a PR. ← https://github.com/sindresorhus/refined-github/pull/2182

 Hides the Packages tab in repositories if it’s empty. ← https://github.com/sindresorhus/refined-github/pull/2301

November 2019

 Shows the user local time in their hovercard (based on their last commit). ← https://github.com/sindresorhus/refined-github/pull/2549

 Adds the age of the repository to the statistics bar. ← https://github.com/sindresorhus/refined-github/pull/2560

 Linkifies the user location in their hovercard and profile page. ← https://github.com/sindresorhus/refined-github/pull/2544

 Makes labels clickable in the dashboard’s "Recent activity" box. ← https://github.com/sindresorhus/refined-github/pull/2513

 Points the "View file" in PRs to the branch instead of the commit, so the Edit/Delete buttons will be enabled on the "View file" page, if needed. ← https://github.com/sindresorhus/refined-github/pull/2529

 Adds a link to preview HTML files. ← https://github.com/sindresorhus/refined-github/pull/2505

 Shows which PRs have conflicts in PR lists. ← https://github.com/sindresorhus/refined-github/pull/2310

September 2019

 Expands the entire file when you alt click on any "Expand code" button in diffs. ← https://github.com/sindresorhus/refined-github/pull/2434

 Adds a menu item to embed a gist via <iframe>. ← https://github.com/sindresorhus/refined-github/pull/2347

 Adds a shortcut to toggle all similar items (minimized comments, deferred diffs, etc) at once: alt click on each button or checkbox. ← https://github.com/sindresorhus/refined-github/pull/2087

 Makes it easier to tell apart commits added to the current PR versus plain commits that reference the PR. ← https://github.com/sindresorhus/refined-github/pull/2415

 Retries downloading images that failed downloading due to GitHub limited proxying. ← https://github.com/sindresorhus/refined-github/pull/2393

October 2019

 Preserves the current line on “View blame prior to this change” links. ← https://github.com/sindresorhus/refined-github/pull/2481
 Lets you create draft pull requests in one click. ← https://github.com/sindresorhus/refined-github/pull/2486

November 2019

 Shows the user local time in their hovercard (based on their last commit). ← https://github.com/sindresorhus/refined-github/pull/2549
 Adds the age of the repository to the statistics bar. ← https://github.com/sindresorhus/refined-github/pull/2560
 Linkifies the user location in their hovercard and profile page. ← https://github.com/sindresorhus/refined-github/pull/2544
 Makes labels clickable in the dashboard’s "Recent activity" box. ← https://github.com/sindresorhus/refined-github/pull/2513
 Points the "View file" in PRs to the branch instead of the commit, so the Edit/Delete buttons will be enabled on the "View file" page, if needed. ← https://github.com/sindresorhus/refined-github/pull/2529
 Adds a link to preview HTML files. ← https://github.com/sindresorhus/refined-github/pull/2505
 Shows which PRs have conflicts in PR lists. ← https://github.com/sindresorhus/refined-github/pull/2310

December 2019 - January 2020

Lots of small refinements of existing features
 Adds a button to @mention a user in discussions. ← https://github.com/sindresorhus/refined-github/pull/2556
"Requested changes" in PRs now have a friendlier color. ← #2611

February 2020

 On long discussions where GitHub hides comments under a "Load more...", alt click will load all the comments at once instead of part of them.  ← https://github.com/sindresorhus/refined-github/pull/2754
 Adds a "Bugs" tab to repos, if there are any open issues with the "bug" label.  ← https://github.com/sindresorhus/refined-github/pull/2750
 Lets you toggle between is:open/is:closed/is:merged filters in searches.  ← https://github.com/sindresorhus/refined-github/pull/2745
latest-tag-button now tells you whether the default branch matches the latest published version.  ← #2771

April 2020

 Clears the PR merge commit message of clutter, leaving only deduplicated co-authors. (#3003)

 Adds a link to access the past runs of a GitHub Action workflow when seeing the workflow configuration file. #3011)

 Lets you see how others are using the current Action in the Marketplace. #3033)

 Mark/unmark multiple files as “Viewed” in the PR Files tab. Click on the first checkbox you want to mark/unmark and then shift-click another one; all the files between the two checkboxes will be marked/unmarked as “Viewed”. #3007)

 Linkifies the header of each notification group (when grouped by repository). #3048)

March 2020

Marks merge commits in commit lists. ← #2832
Adds the updated time to pinned issues. ← #2795
In your forked repos, shows number of your open PRs to the original repo. ← #2880
Clone a branch from the branches list. ← #2896
When exploring blames, Alt-clicking the “Reblame” buttons will extract the associated PR’s commits first, instead of treating the commit a single change. ← #2881

April 2020

 Adds a link to the issues and pulls on the user profile repository tab and global search. ← #2981
 Clears the PR merge commit message of clutter, leaving only deduplicated co-authors. ← #3003
 Adds a link to access the past runs of a GitHub Action workflow when seeing the workflow configuration file. ← #3011
 Lets you see how others are using the current Action in the Marketplace. ← #3033
 Mark/unmark multiple files as “Viewed” in the PR Files tab. Click on the first checkbox you want to mark/unmark and then shift-click another one; all the files between the two checkboxes will be marked/unmarked as “Viewed”. ← #3007

May 2020

 Linkifies the header of each notification group (when grouped by repository). ← #3048
 Stops redirecting to notification inbox from notification bar actions while holding Alt. ← #3036
 Makes some dropdowns 1-click instead of unnecessarily 2-click. ← #3050
 Removes redundant user/repo from notifications when being grouped by repository ← #3051
 Suggests fixing your PR Commit links before commenting. GitHub has a bug that causes these link to appear as plain commit links, without association to the PR. ← #3085
 Shows the associated pull requests on branches for forked repository’s. ← #3116
Only show comments-time-machine-links after visiting the link ← #3135

Each release now includes a changelog 🎉
Subscribe to releases at the top of this page to get timely updates:


Implement Send for Error

Implement Send for Error so that it could be used in structs and traits requiring any error E to be E: Error + Send + 'static (e.g.: generally Result).

There were the following issues with your Pull Request

Commit: 197d9ca687782e946621f34d9550a4d616bbed50
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/zitsen/unqlite.rs

This message was auto-generated by https://gitcop.com


Arrangement fill parent not reserving enough size

I'm not sure what the root cause is, but a vertical arrangement of height fill parent sitting inside a horizontal arrangement of height automatic doesn't seen to be doing the right thing.
The following project illustrates the bug
people.csail.mit.edu/hal/misc/horizVertsizeBug.aia

@halatmit
Actually, how can the child fill the area which the parent doesn't own?
Consider it an android concept, or a limitation, but, it's very important to limit the child, so that it does not acquire area of some other layout.
For more information you can refer to
http://stackoverflow.com/questions/4606613/combining-wrap-content-on-parent-and-fill-parent-on-child
http://developer.android.com/reference/android/view/ViewGroup.LayoutParams.html#FILL_PARENT
And, the wrap_content on parent will ensure that, the height of parent will automatically increase ( to the extent the screen size minus padding let it go to.

@halatmit ,
wrap_content only takes minimum area required, and fill parent fills the whole area it's parent has.
http://developer.android.com/reference/android/view/ViewGroup.LayoutParams.html#FILL_PARENT
And consider it a concept or bug, layout containing,

    <Button
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="haha"
        />

    <LinearLayout
        android:layout_height="fill_parent"
        android:layout_width="wrap_content"
        android:orientation="vertical"
        >

        <Button
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="text1"
        />
        <Button
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="text2"
        />
        <Button
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="text3"
        />

    </LinearLayout>

</LinearLayout>

is not working properly in android.

In the aia project, the Horizontal Arrangement's layout height is stetted as Automatic, and the inner Vertical Arragement's layout height is stetted as Fill Parent.
In the below explanation from source code, it says that actual height of the horizontal arrangement is determined by the tallest component whose height property is not set to Fill Parent.
In this project, because there is a button, whose height property is Automatic, in the Horizontal Arrangement layout, the height of horizontal arrangement is determined by button then instead of inner Vertical Arrangement
https://github.com/mit-cml/appinventor-sources/blob/4a18ef5dd41114ad68353c6f7e0037ad94dc755d/appinventor/appengine/src/com/google/appinventor/client/editor/simple/components/MockHVLayoutBase.java


They Are Billions: Fonts fail to render

Fonts completely fail to render.
EDIT: This issue is not new and always persisted, since i began testing a few weeks ago.
Here is how its looking with d9vk right now:

Here is how it should look like (screenshot made with wined3d):

System information

GPU: Nvidia GTX 1050 Ti
Driver: Nvidia 430.34-53 long lived
Proton version: Proton 4.12.1.r4 (staging, esync)
D9VK version: latest master branch (ed02e5)
Winetricks: corefonts, gdiplus, dotnet472
additionally installed to wine prefix: SlimDX (January 2012)

Log files
steam-644930.log
i've cut the log at around 3000 lines, because the game spams a lot of the failing textures at start (the top counter has a counting animation), therefore my original log was 700MB after just a few seconds. :D
Should not be important to have the full log though, since the same issue basically just repeats itself over and over again.

Can you get me a trace of this (preferably with WineD3D) so I can debug this? Cheers

i would love to, but i am honestly sure know how to do that wrapped inside of steam/proton :/

well. not a trace, but an actual debug log of d9vk..
TheyAreBillions_d3d9.log
so far, i didnt manage to get an apitrace out of this, still working on it..

Ah, looks like an issue I might have fixed recently. Can you try the latest master?
Builds available here:
https://git.froggi.es/joshua/d9vk/-/jobs

ha..
yup.. it is indeed fixed already now.
nice job! :)

ty enjoy :-)


Plot limits do not set automatically when -Inf values are present

Using GeoMakie 0.6.5, I found that GeoAxis limits fail to set automatically if there are one or more -Inf values present in the data being plotted.  +Inf, NaN, or missing values do not trigger the issue.  I tried heatmap using CairoMakie and surface using GLMakie with similar results.
using GLMakie, GeoMakie

fig = Figure()
ga = GeoAxis(fig[1, 1])

lons = -180:180
lats = -90:90
z = [exp(cosd(l)) + 3(y/90) for l in lons, y in lats]

# One or more values to `-Inf`
@. z[-3 < lons < 3, -3 < lats < 3] = -Inf

hm = surface!(ga, lons, lats, z; shading=NoShading, interpolate=false)

Result:

If I change -Inf to Inf or NaN, I get what I expect.

This shouldn't be an issue on master and Makie v0.21 - am away from my laptop but will confirm later.

This displays correctly on master, with both CairoMakie and GLMakie in png mode:

CairoMakie in PDF is also fine, but SVG has some weird artefacts depending on which renderer you use.  That can't be helped there, though.
If you want to use GeoMakie master,
using Pkg
Pkg.add(name = "GeoMakie", rev = "master")

ought to do it.  Just remember to Pkg.free("GeoMakie") later.