Use the configured remote when pushing tags

This patch modifies the release command such that it now looks up which remote to push a tag to based on:

remotes configured for PUSH operations
remote URLs matching the provider domain name
remote URLs matching the package name in the path

The name of the first remote to satisfy all three criteria is returned and used for pushing tags. Otherwise, the command indicates an error occurred, provides information for debugging why, and exits with a failure status.
Fixes #39

@Xerkus This addresses the first bit of your suggested fix: failing early when we cannot find an appropriate remote.
I tried a few different combinations locally, and in each case, it was correctly finding the remote to which to push; when it could not find a remote configured for push operations, or matching both the provider domain name and the package name in the path, it was bailing early, and suggesting I double-check my git configuration.
Since the tag push operation causes the command to bail on failure, I don't see a need to check for the tag on completion, so long as the command is using the correct remote.
The one potential problem still lingering is that if multiple remotes match, this functionality will return the first to match, which may still not be correct. One thing I could also do is check to see if multiple remotes match, and ask the user to select, which would resolve that issue. Should I make those changes as well before merging this?

The one potential problem still lingering is that if multiple remotes match, this functionality will return the first to match, which may still not be correct. One thing I could also do is check to see if multiple remotes match, and ask the user to select, which would resolve that issue. Should I make those changes as well before merging this?

My overcautious side calls for abort and explicit flag. But in practice I do not think it will matter. At worst it will fail on push and user will need to explicitly provide remote name.
One special rule for this case is to make remotes origin and upstream be inspected first.

As for safeguard for creating release on github, github provider would need to be updated with one extra api call and assert for the returned value:
https://github.com/phly/keep-a-changelog/blob/8585813060576fc939772a7b1e37b8b6a7ff438d/src/Provider/GitHub.php#L19-L42
Something like this:
$client->authenticate($token, GitHubClient::AUTH_HTTP_TOKEN);
$tagRef = $client->get('gitData')->references()->show('tags/' . rawurlencode($tagName));
// didn't check for 404 condition. How library handles it? Exceptions?
$tagType = $tagRef['object']['type'] ?? null;
if ($tagType === 'tag') {
    // proper signed tag <-- those we create and push
} elseif ($tagType === 'commit') {
    // unsigned, annotated tag object: git tag -a
    // we do not allow those in Zend Framework repos
    // Also this type is silently created by github if tag does not exist in the repository for release.
    // UI does not show them as unsigned tags, showing verified seal of the commit they point to.
} else {
    // something went wrong
}
// continue with create release api call

I've done a little experimentation, and what I've found is that if a matching refs/tags/{tagName} reference is found, the type is always tag, even for those that were not signed; there is literally nothing differentiating them in the API result. When a particular tag reference is not found, the client raises an exception.
What we can do, however, is use the data returned by fetching the reference to fetch the tag data:
$tagData = $client->api('gitData')->tags()->show($org, $repo, $tagRef['object']['sha']);

The data returned from that includes a "verification" object, with a "verified" subkey that indicates if the tag has an associated signature. That value is a boolean, with true indicating a signature was matched.
I'll make those changes shortly.

Actually I was wrong, annotated tag does create a tag object, it is not signed.
tag -a:
{
  "ref": "refs/tags/test",
  "node_id": "MDM6UmVmMTg1MjMyMjE1OnRlc3Q=",
  "url": "https://api.github.com/repos/Xerkus/zend-authentication/git/refs/tags/test",
  "object": {
    "sha": "8b21a7924310a11d7623e7b863453f3e160f8d78",
    "type": "tag",
    "url": "https://api.github.com/repos/Xerkus/zend-authentication/git/tags/8b21a7924310a11d7623e7b863453f3e160f8d78"
  }
}

tag -s:
{
  "ref": "refs/tags/test-s",
  "node_id": "MDM6UmVmMTg1MjMyMjE1OnRlc3Qtcw==",
  "url": "https://api.github.com/repos/Xerkus/zend-authentication/git/refs/tags/test-s",
  "object": {
    "sha": "5a5885eda25638e85893df9748fbedab5d622f0e",
    "type": "tag",
    "url": "https://api.github.com/repos/Xerkus/zend-authentication/git/tags/5a5885eda25638e85893df9748fbedab5d622f0e"
  }
}

non-annotated unsigned tag:
{
  "ref": "refs/tags/test-r",
  "node_id": "MDM6UmVmMTg1MjMyMjE1OnRlc3Qtcg==",
  "url": "https://api.github.com/repos/Xerkus/zend-authentication/git/refs/tags/test-r",
  "object": {
    "sha": "cbfec9c0270b8c3139c16d00ef93fc800d0dd190",
    "type": "commit",
    "url": "https://api.github.com/repos/Xerkus/zend-authentication/git/commits/cbfec9c0270b8c3139c16d00ef93fc800d0dd190"
  }
}

For the purposes of the provider assertion for release command it would be enough to ensure the presence of the tag in the target.
Existing wrong tag in the target will cause tag push operation to fail, so from practical standpoint correctness of the tag is covered by ensuring proper remote is used.

@Xerkus Commit f23e900 provides the logic to verify the tag was (a) pushed, and (b) signed. I think with those in place, your issues are finally addressed!


Add LongForm dataset (better than Alpaca)

Adds the LongForm dataset.
LongForm is a semi-synthetic dataset based on raw text corpora for which the instructions were generated via an LLM. For more details about the instruction-generation process, please refer to the LongForm research paper by Köksal et al. According to the research paper, a Llama 7B model trained on LongForm achieves substantially better performance than the same Llama model trained on the 2x larger Alpaca dataset.
LongForm consists of 23,652 training samples, 2,042 validation samples, and 2,045 test samples. (In Lit-GPT, the validation samples are currently not used.)
The more detailed dataset composition is as follows based on a table taken from the dataset repository:

Type
Source
Number of Examples

Corpora
C4
10,000

Wikipedia
5,000

Structured Corpora
Stack Exchange
4,380

WikiHow
2,500

Tasks
NIv2
3,684

Big Bench
600

BEA-GEC
1,203

Enron
372

Total

27,739

Train

23,652

Validation

2,042

Test

2,045

License information is not provided but would depend on the individual subsets listed above.

@carmocca There seem to be some CI issues unrelated to the PR. Perhaps issues elsewhere too since they seem to be missing-authtoken related.

Ok fixed


Bug 1497839 - copy secrets to transient namespace and always run

Describe what this PR does and why we need it:
Removes split code path based on secrets to run the APB in the transient namespace always
Changes proposed in this pull request

remove branch on secrets
copy secrets to the transient namespace
panic the broker if we are attempting to delete its namespace.

Does this PR depend on another PR (Use this to track when PRs should be merged)
depends-on
N/A
Which issue this PR fixes (This will close that issue when PR gets merged)
N/A

 (2) Update AWS APB workflow on broker to match with transient namespace approach.

Example Namespace:
- apiVersion: v1
  kind: Namespace
  metadata:
    annotations:
      openshift.io/sa.scc.mcs: s0:c13,c7
      openshift.io/sa.scc.supplemental-groups:<PHONE_NUMBER>/10000
      openshift.io/sa.scc.uid-range:<PHONE_NUMBER>/10000
    creationTimestamp: 2017-10-12T17:12:06Z
    generateName: dh-hello-world-apb-prov-
    labels:
      apb-action: provision
      apb-fqname: dh-hello-world-apb
    name: dh-hello-world-apb-prov-84s0z
    namespace: ""
    resourceVersion: "10004"
    selfLink: /api/v1/namespaces/dh-hello-world-apb-prov-84s0z
    uid: 7927f3e5-af70-11e7-a5b7-64006a6fb904
  spec:
    finalizers:
    - kubernetes
    - openshift.io/origin
  status:
    phase: Active

@shawn-hurley @djzager meant to request changes, apparently I can't operate github.

doublecomboACK


Replace moment with date-fns

Notes

dateFormat(input: string, formats: any[], locale: string): boolean; changed to dateFormat(input: string, formats: any[]): boolean; since this API was not exposed directly, nor documented. This change allows to drop locales import. It's possible to reexport locales provided by date-fns

cc @thetutlage

Coverage remained the same at 100.0% when pulling 4eaf7fea95f98caf7367c8f36e9c07a21329220b on Andreyco:date-fns into a533d9bed4201aef304c3b1956c3301d146760af on poppinss:develop.

Coverage remained the same at 100.0% when pulling 764ed4838b82f0efb7c19b4960db3aad7fd95441 on Andreyco:date-fns into a533d9bed4201aef304c3b1956c3301d146760af on poppinss:develop.

Have been going through the PR and the only breaking change I can see is that date_format will not working just with time anymore and always needs to have a date in front

@thetutlage yes, you are correct. Do you think watching for "time" format patterns and evaluating in different code path would be good solution? E.g.:
// Pseudocode
Raw.dateFormat = function (input, formats) {
  const formatsArray = Array.isArray(formats) ? formats : [formats]
  return formatsArray.some(pattern => {
    return isTimeFormat(pattern))
        ? isValidTime(parseTime(input)) && format(input, pattern) === input
        : isValidDate(parseDate(input)) && format(input, pattern) === input
  })
}

Of would you prefer creating new "time_format" rule and keep "date_format" strictly for date validation?

Nope, I think it's fine to keep time separate from date and better have a different rule for time.
I am going merge the PR but will wait for a while to release it.


[Bug] Order placing sometimes is not working

Current behavior
Sometimes it is impossible to place an order, after clinking on 'place the order' button the information 'The order can not be transfered because of server error. Order has been queued ' appears.
It appears mostly in 'incognito' mode. After user gets all the way back to the 'Details' (by cling on
Edit payment, Edit shipping, Edit Details) and again through the checkout steps without changing anything (by clicking on continue to shipping, continue to payment, go review the order) placing order is possible.
Expected behavior
Placing order is possible in incognito mode whiteout going twice through the checkout.
Steps to reproduce the issue

open the page in incognito mode
add any product to the cart
go to checkout
go thorough all the checkout steps
click on 'place the order' button
see the error
click in turn on: Edit payment, Edit shipping, Edit Details
clicking in turn on: 'continue to shipping', 'continue to payment', 'go review the order' buttons
click on 'place the order' button
see the error

Can you handle fixing this bug by yourself?

[ ] YES
[ ] NO

Environment details

Browser:
OS:
Code Version:

Additional information

Unable to reproduce right now. Closing issue.


Sample env file must be created for development purpose

Hey @SwanandD121 As I can see that no sample env files are provided its better if we can add a one for the references

@SwanandD121  please add the level tag


Please sign any .ps1 scripts in this repository

You currently have a script for helping install PowerShell as per https://github.com/PowerShell/PowerShell/blob/master/tools/install-powershell.ps1
This script is not signed - could you please sign this and others if you are sharing them to be used in production environments by users :-)

Perhaps @TravisEz13 could address the question.

I'm assuming you are asking to sign with a Microsoft Certificate.  I'd have to investigate any other option.
What is the goal for us signing it (there are different certificates with different amounts of engineering work on our part for each scenario)?

Know that it comes from Microsoft and has not been tampered with.
The First option plus knowing it is safe to use.

It would be impractical to sign scripts that are simply checked into the repo and under development.  Anything we sign falls under additional requirements that sample code we have in the repo.
To solve this, we would have to create a release mechanism such as releasing it as a script on the gallery.
@SteveL-MSFT 	Can you give feedback?

@iSazonov 	That would be scenario 2. Windows Defender Application Control (formerly Device guard) is similar.

The scripts are (hopefully) a temporary problem on Windows (we're looking at different options).  On Linux, and macOS, I believe it's easy enough to install using apt/yum/brew.  In the interim, we could sign the install-powershell.ps1 script and publish to PSGallery.

We have a request to have Update-PowerShell cmdlet. We could replace install-powershell.ps1 with the cmdlet which could download a signed manifest from persistent link and use the manifest to download new PowerShell version or updates.


Option to disable { braceSpace } in object literals

Desired:
void {one: 10, two: 20, three: 30}

Actual:
void { one: 10, two: 20, three: 30 }

Not seeing a documented option to disable this additional spacing. If I missed one, then would appreciate a pointer, and a documentation update. Otherwise, would be nice to add an option. It would also be nice to get an option to consistently disable all such brace spacing. Thanks!

My bad and sorry about that! The JSON schema file was missing them. The configuration is spaceSurroundingProperties: false and there are AST node specific configuration for that as well. I've updated the JSON schema file so this should be resolved now:
https://dprint.dev/plugins/typescript/config/

I think that doesn't disable this spacing for named imports and exports though. You might have to do:
"spaceSurroundingProperties": false,
"importDeclaration.spaceSurroundingNamedImports": false,
"exportDeclaration.spaceSurroundingNamedExports": false

Works great. Thanks for the help! Appreciate the rapid response. 🙂


Fix setting IREE_MEMORY_ACCESS_ALIGNMENT_REQUIRED

Even if IREE_MEMORY_ACCESS_ALIGNMENT_REQUIRED was defined it was
always set to 0. However, it is only valid to set it to 0 if
IREE_MEMORY_ACCESS_ALIGNMENT_REQUIRED isn't defined.
Makes progress on #9593 and allows to control the alignment behavior
via IREE_MEMORY_ACCESS_ALIGNMENT_REQUIRED instead of being
forced to pass -mno-unaligned-access.

With what we have now IREE_MEMORY_ACCESS_ALIGNMENT_REQUIRED is always set to 0 (for Arm) for the following configurations:

add_compile_definitions(IREE_MEMORY_ACCESS_ALIGNMENT_REQUIRED)
add_compile_definitions(IREE_MEMORY_ACCESS_ALIGNMENT_REQUIRED=0)
add_compile_definitions(IREE_MEMORY_ACCESS_ALIGNMENT_REQUIRED=1)
no compile definition at all

The architecture is only evaluated if IREE_MEMORY_ACCESS_ALIGNMENT_REQUIRED isn't set (the last case). So in fact a user cannot control the behavior. With the proposed change IREE_MEMORY_ACCESS_ALIGNMENT_REQUIRED is set

to 1 with `add_compile_definitions(IREE_MEMORY_ACCESS_ALIGNMENT_REQUIRED)
to 0 if no compile definition is added

However, the code just checks if IREE_MEMORY_ACCESS_ALIGNMENT_REQUIRED is defined, not if already a numerical value was passed by the user. (I can further iterate on this to allow passing 0 or 1.)
But I agree, we need to fix alignment.h and this is only an intermediate step on the way to a more complete fix. (Already on it. This is just something I noticed on the way.)

The issue is this:

That's saying if IREE_MEMORY_ACCESS_ALIGNMENT_REQUIRED is defined then set it to 1 (which seems like it'd be a re-definition?) - there should be no else at all. Either the user specifies IREE_MEMORY_ACCESS_ALIGNMENT_REQUIRED as 0 or 1 or we pick for them. What's there with that else is treating it as a #ifdef style "if IREE_MEMORY_ACCESS_ALIGNMENT_REQUIRED is defined then alignment is required" but the 0 and 1 values are treating it as an #if style "if IREE_MEMORY_ACCESS_ALIGNMENT_REQUIRED is 1 then alignment is required" - it's gotta be one or the other.
If you remove this else block then it can stay as the latter (-DIREE_MEMORY_ACCESS_ALIGNMENT_REQUIRED=0 or -DIREE_MEMORY_ACCESS_ALIGNMENT_REQUIRED=1).

If you remove this else block then it can stay as the latter (-DIREE_MEMORY_ACCESS_ALIGNMENT_REQUIRED=0 or -DIREE_MEMORY_ACCESS_ALIGNMENT_REQUIRED=1).

Ah got your point! I agree and dropped the block with the latest push. I thought you were referring to adding #define IREE_MEMORY_ACCESS_ALIGNMENT_REQUIRED 0 to the // IREE_ARCH_* block which is a actually a need.
Thanks for clarifying!


pkg/pub_admin: skeleton Angular web-app

#1642
The web app's code is the default skeleton Angular web app. I've removed a few non-necessary items and hooked up with the static file handling we have.

@jonasfj Can you review this one?

obsolete for now


Add export talks list feature

[ ] Export list of talks to CSV (one talk per row) with all information including speaker bio etc.
[ ] Export list of anonmised talks to CSV (Talk title, length, category and abstract)
[ ] Export list of email addresses for accepted talks
[ ] Export list of email addresses for speakers with only rejected talks

@jakefolio Would it be possible to get an icon done for the admin side menu?

POC: https://github.com/opencfp/opencfp/compare/master...michaelcullum:export-feature
Fully working but could use a little tidying but if the powers that be (@mdwheele?) are happy with that as-is then I'm happy to send up a PR.

Would love to see a PR please

Yeah, send a PR and I'll gladly review. Few things from diff I'd immediately ask for change:

Use of boolean $userData to expose additional formatted output off the Talk model begs to instead use a more appropriate method (or, better) some sort of Presenter responsible to provide an alternative formatted response.
In HTTP routing, would it be a good idea to start all export options under something like /admin/export? GET to route might show all options for export. POST might process a request that specifies a particular option.
Tests, of course!

Sure, I did warn you it is pretty nasty and all three of those things are things that need doing (and quite a bit else). Most of it was done just because that was the quickest way of doing it (POC), not because it was the right way. I don't really have much more time I can put into this unfortunately but I've thrown up a PR in case anyone wants to finish it off.

No problem! Thanks for the effort and PR.


Add KFServing E2E tests

Fixes: https://github.com/kubeflow/kfserving/issues/930
The PR is going to:

Remove kfctl_e2e_workflow.py as @jlewi comments.
Update kf_is_ready_test.py to separate kfserving from knative check section, to ensure the KFServing is installed and started successfully.

Thanks @jinchihe

@jinchihe Sorry for the slow reply see https://github.com/kubeflow/kfserving/issues/930#issuecomment-664734634

@jlewi Removed KFServing E2E cases since that's tested in KFServing repo, and only keep fist item in kubeflow/kfserving#930 discussed to ensure the KFServing is installed and started successfully.
This is ready for another reviewing. Thanks.

/lgtm
/approve


Typo "Postgres"→"PostgreSQL"

https://docs.microsoft.com/en-us/azure/cloud-adoption-framework/migrate/azure-best-practices/contoso-migration-postgresql-to-azure
https://github.com/MicrosoftDocs/cloud-adoption-framework/blob/main/docs/migrate/azure-best-practices/contoso-migration-postgresql-to-azure.md
#PingMSFTDocs

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change. @deltadan

#sign-off

@MicrosoftDocs/cloud-architecture-content-team-pr-reviewers - Please review the proposed changes. If you want to move forward with the content, add a sign-off.
#label:"aq-pr-triaged"
#label:"pending-content-team/business-approval"
Cc: @MicrosoftDocs/public-repo-pr-review-team

#label:"cact-review-in-progress"

CACT #sign-off
#remove-label:"do-not-merge"
#label:"ready-to-merge"


Update dependencies to the latest version

Automated changes by create-pull-request GitHub action

:tada: This PR is included in version 1.0.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


SECURITY WARNING

When I try to download your file, a security warning appears.
Here is the message:
**Connection broken: potential security risk
Firefox has detected a potential security threat and broken the connection with codeload.github.com, as it is only possible to connect to this site securely.
What can I do to fix it?
codeload.github.com uses a security policy called HTTP Strict Transport Security (HSTS). This means that Firefox can only connect securely and it is not possible to add an exception to visit this site.
The error is probably caused by the website and cannot be resolved.
If you are using a corporate network or antivirus software, contact the support teams for assistance. You can also report the problem to the website operator.**
Could you try to fix it?

This is probably a configuration problem on your end. See here for more information.
Do you have security software installed? It might be interfering.

I've tested on two computers with Firefox Stable and Beta (74 and 75) and have had no issues downloading.
This is either an issue with your computer or an issue with GitHub, but it's not really related to the theme.
Are you clicking the clone or download button? Have you tried downloading one of the releases? Have you tried using a different computer?

#response_container_BBPPID{font-family: initial; font-size:initial; color: initial;}  And can you let gh know?                                                                                Inviato con Posta in arrivo di BlackBerry Hub+ per Android                                                                                Da<EMAIL_ADDRESS>7 Aprile 2020 15:28A<EMAIL_ADDRESS>a<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Re: [muckSponge/MaterialFox] SECURITY WARNING (#217)
I've tested on two computers with Firefox Stable and Beta (74 and 75) and have had no issues downloading.
This is either an issue with your computer or an issue with GitHub, but it's not really related to the theme.
Are you clicking the clone or download button? Have you tried downloading one of the releases? Have you tried using a different computer?
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.

https://support.github.com/contact
This isn't an issue with this repo at all, try getting in touch with Github support (link above) to find out if the issue is from your security settings, or GH's servers - and what the fixes may be. None of us can really do anything 🤷♂

#response_container_BBPPID{font-family: initial; font-size:initial; color: initial;}  Ok, thanks, bdw, can u send me the file here in email?                                                                                Inviato con Posta in arrivo di BlackBerry Hub+ per Android                                                                                Da<EMAIL_ADDRESS>8 Aprile 2020 16:00A<EMAIL_ADDRESS>a<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Re: [muckSponge/MaterialFox] SECURITY WARNING (#217)
https://support.github.com/contact
This isn't an issue with this repo at all, try getting in touch with Github support (link above) to find out if the issue is from your security settings, or GH's servers - and what the fixes may be. None of us can really do anything 🤷♂
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.

Your best bet is to (ironically) download with Chrome or Safari. If you still have the issue, try cloning through git. I'd recommend something like Fork or one of these other git GUIs.


fix use_clock_today

use_clock_today was checking the wrong config option (use_clock_time), causing it to never be properly activated.

thank you very much!! ^^


README Suggestions : Avoid Flashes Case on iOS

After the 'flashes' episode we had on react-native-modal (#92).
I found myself subject to some flashes when using the component on iOS.
And i've found out it was caused because i was setting a backgroundColor white directly to my Modal component instead of the child 'container'.
In order to avoid that someone else reproduce this mistake and goes through the same process, i'd like to suggest that we add a text to the READMe.md file to tell the user not to set backgroundColor style to the Modal as it will cause flashes on iOS.

Thank you 🙏


[Refactor] refactor mim uninstall

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Refactor mim uninstall in order to use the same method as pip uninstall.
Modification
commands/uninstall.py

Added -r / --requirements option.
Rename the original package to uninstall_args to uninstall multiple packages at the same time.
Support for passing unknown option of mim uninstall to pip uninstall.

BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
The documentation has been modified accordingly, like docstring or example tutorials.

Please update the unit tests of uninstall command.


Quick Debugging Never Attaches

Brief Issue Summary
When launching the debugger using the 'Quick Debugging' feature, the debugger never attaches.
Expected:
Debugger to attach.
CMake Tools Log
[build] Starting build
[proc] Executing command: /usr/local/bin/cmake --build /Users/brporter/projects/spong/build --config Debug --target spong -- -j 6
[build] [100%] Built target spong
[build] Build finished with exit code 0
[proc] Executing command: /usr/bin/lldb-mi --version
[proc] Executing command: /usr/bin/gdb --version
[proc] Executing command: /usr/bin/lldb --version
[proc] Executing command: /usr/bin/lldb --version

Developer Tools Log
C/C++ output window contains
Finished installing dependencies

Failed to read response from server: 2
Failed to read response from server: 22

Platform and Versions

Operating System: macOS
CMake Version: 3.15.4
VSCode Version: 1.40.1
CMake Tools Extension Version: 1.2.2
Compiler/Toolchain: Apple clang version 11.0.0 (clang-1<IP_ADDRESS>)

Other details
I'm producing a macOS bundle, if that matters.

Those error messages are from the cpptools language server, not debugging.  macOS Catalina currently has issues with debugging.  Have you seen https://github.com/microsoft/vscode-cpptools/issues/3829?

Those error messages are from the cpptools language server, not debugging. macOS Catalina currently has issues with debugging. Have you seen microsoft/vscode-cpptools#3829?

I had not seen that issue, thank you! That does seem to be my problem as well.


Experimental

This PR does two things

speed up inference by introducing a custom training loop
fix a bug in laue processing wherein the predicted intensities/sigmas were not appropriately convolved

Another minor change in this pr is that surrogate distribution parameters are now sorted lexicographically in the output mtz(s).

Codecov Report

Merging #32 (1597169) into main (d715eab) will decrease coverage by 0.84%.
The diff coverage is 90.32%.

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   86.58%   85.73%   -0.85%
==========================================
  Files          38       38
  Lines        1267     1290      +23
==========================================
+ Hits         1097     1106       +9
- Misses        170      184      +14

Flag
Coverage Δ

unittests
85.73% <90.32%> (-0.85%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

careless/careless.py
58.82% <66.66%> (-0.34%)
:arrow_down:

careless/models/merging/variational.py
97.18% <92.00%> (-2.82%)
:arrow_down:

careless/io/manager.py
91.95% <100.00%> (+0.04%)
:arrow_up:

careless/callbacks/progress_bar.py
0.00% <0.00%> (-100.00%)
:arrow_down:

careless/io/formatter.py
90.82% <0.00%> (-0.88%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d715eab...1597169. Read the comment docs.


Update URL and homepage for Google Noto font family

Changes made:

Use HTTPS protocol in all font-noto* Casks
Update homepage and use https://www.google.com/get/noto for all family fonts
Update URL of font files

This fixes #387

Thank you.


[FEATURE REQ] Add Dockerfile for grofer

Describe the solution you'd like
Have a Dockerfile for grofer for ease of use.
docker run pesos/grofer:latest

Additional context

On initial thought, this can be done by mounting the file systems being used by gopsutil to fetch metrics, /proc and /sys might be a good starting point.

I looked this up a bit, haven't tried any of this yet. Apparently, mounting /proc inside the container does not provide details of the host. The alternative is to mount the whole root FS as read-only in the container (ref).
It might be only for the hostname, I'm not sure yet. I can take up this issue if no one else has taken it up for a few days.

Ohhh that makes sense, hmm.
Mounting the whole root file system could be an option, maybe qualifying the mount as read only as well.

Okay so I did a little digging, cAdvisor also mounts the entire root file system for this purpose, followed by a read-only qualification. That might be the way to go.

@Samyak2 looks like you can take this up!


Problem in p35 - Gas station

Line 16: return total>=0 ? j+1 : -1
Should be (j+1)%gas.size(), so that we will return 0 instead of N in some cases,.
Regards,
Tianze

Sorry, % is unnecessary here, by further analysis.


Starter code

There's a large amount of starter code, what do you think about it. I would like to have very less code, since many members may not know react. I want that this project should enable everyone to contribute, more or less.
Issue 1:
My idea 💡 is to re-commit the starter code with lesser code.
If you have took any course before, you may know that instructors start from scratch, then react, then react-router, then redux, then any backend like firebase.
But we now have everything together
Issue 2:
Is there any chance to seperate server and client code. It would be easy for all the developers who only know either front or backend, not both.
Also deployment would be easy, if it's possible
Issue 3:
Create readmes in almost every folder, it would be easier for non-js (php,django,etc.,)developers. And also create map(s) for contributions, where to start and how the execution goes to render the page.
Being a contributor and collaborator, these are my suggestions for this project, I thought this would be more appropriate place than the slack channel
Your feedback is highly important and appreciated (will be accounted too)...

Yes, I agree, starter code should be as less as possible as that would help us understand it way better.

@VarunDevPro, I completely understand your concern that you want to make it easy for contributors to be able to contribute to the project. Lot of starter code may seem confusing for new contributors atfirst but I think with proper guidelines we can solve that.
Issue 1
Since our project code is anyways gonna grow with time I think instead of recommitting the starter code we should instead provide with a better documentation(just as you said in Issue 3) so that it becomes easier for everyone to navigate the code. My idea 💡is we could develop Wiki Pages for client and server side.
Issue 2
By separate server and client code, I think you mean separate repositories because we have definitely separated server and client code in separate folder.
Issue 3:
I agree with you that we should develop a guide so that becomes easier for different types of contributors to start contributing. But instead of README files in every folder, I suggest we use GitHub Wiki pages. We can have README for the 2 main (client and server) folder but for every folder it seems too much.

So our idea was to have a starter code which is already well defined.
The idea is to explain the flow of the app in the readme and once we do that, trust me it will be very helpful for people to follow along.
Consider the current code base. What contributors are going to contribute about when all the configuration part is done? Follow the path and create feature in the similar flow.
Our main goal with this was to make things easier which I understand is not because of lack of documentation (that's our first priority and it's just a basic flow and explanation about what belongs where) and to have contributors adhere to the flow in which we want them to write the code.
Let me know your thoughts? :)

Ok @twishasaraiya  has addressed all the issues, so we can close this now


rephrase README and add screenshot

Ok so in the process of adding the screenshot I've ended up doing a few more things. Please feel free to edit this and remove whatever you don't like. I've:

tried to make the description a little more detailed, to explain the benefits of using the add-on, and point to the JS plugin used (to not bug you about it);
added a screenshot (fixes #2 )
fixed a problem where the example code was not working, because the json_editor file does not exist (it's actually called json, the file, which I think is better)
reordered the field attributes, so that mandatory fields are at the top (view_namespace is mandatory)
rephrased the optional attributes comments a little bit but I'm not sure it's better; it's prettier, but not sure if it's better;

Again, feel free to edit anything in this PR to get it to a point you like.
Cheers!

Thank you!


Workers occupied by larger repos

Description
During the problems with our queue on Monday, it's been discovered that the last executed command in both of our long-running workers has been (or replace with different repository):
[2024-04-29 10:26:46,485: DEBUG/ForkPoolWorker-1] task.run_copr_build_handler[d62bca3b-d550-4666-a2c2-13443fe8f130] Popen(['git', 'clone', '-v', '--tags', '--', 'https://github.com/systemd/systemd.git', '/tmp/sandcastle'], cwd=/src, stdin=None, shell=False, universal_newlines=True)

Given the size of the systemd repository from the example and its presence in both of the workers, it is suspected that the clone of the large repository resulted in the queue being “choked” by cloning large repository in the workers.
Since this has been caught as part of the run_copr_build_handler, we do not need the full history, it will be cloned for the build (and potential user-specified actions) in Copr build environment anyways.

⚠ WARNING ⚠
We still need the full history for sync-release runs and upstream-koji-build. Though those could be postponed to their respective sandboxes in Sandcastle.

TODO

[ ] Clone repositories with --depth=1

[ ] NOT applicable to sync-release and uptream-koji-build

[ ] Clone full repositories just in Sandcastle

[ ] Involves additional clone in the Sandcastle (this could be probably included in the command handler in Packit)

Sizes of repository
Current command »218 MiB«
/tmp % git clone -v --tags -- https://github.com/systemd/systemd.git
Cloning into 'systemd'...
POST git-upload-pack (175 bytes)
POST git-upload-pack (gzip 19402 to 9771 bytes)
remote: Enumerating objects: 519634, done.
remote: Counting objects: 100% (963/963), done.
remote: Compressing objects: 100% (570/570), done.
remote: Total 519634 (delta 512), reused 648 (delta 366), pack-reused 518671
Receiving objects: 100% (519634/519634), 218.39 MiB | 2.89 MiB/s, done.
Resolving deltas: 100% (407856/407856), done.

Only cloning the latest commit »16 MiB«
/tmp % git clone -v --tags --depth=1 -- https://github.com/systemd/systemd.git
Cloning into 'systemd'...
POST git-upload-pack (175 bytes)
POST git-upload-pack (229 bytes)
remote: Enumerating objects: 6383, done.
remote: Counting objects: 100% (6383/6383), done.
remote: Compressing objects: 100% (5196/5196), done.
remote: Total 6383 (delta 1405), reused 2941 (delta 893), pack-reused 0
Receiving objects: 100% (6383/6383), 16.03 MiB | 11.69 MiB/s, done.
Resolving deltas: 100% (1405/1405), done.

Since this has been caught as part of the run_copr_build_handler, we do not need the full history

We are cloning the repo there only to get the config, right? Then making a shallow clone makes complete sense, I just don't think passing --tags is necessary (it would pull only the tags pointing to the cloned commit anyway).
There is also another option, treeless clone:
$ git clone -v --tags --filter=tree:0 -- https://github.com/systemd/systemd.git
Cloning into 'systemd'...
POST git-upload-pack (175 bytes)
POST git-upload-pack (gzip 19369 to 9522 bytes)
remote: Enumerating objects: 77751, done.
remote: Counting objects: 100% (183/183), done.
remote: Compressing objects: 100% (183/183), done.
remote: Total 77751 (delta 1), reused 86 (delta 0), pack-reused 77568
Receiving objects: 100% (77751/77751), 23.53 MiB | 19.67 MiB/s, done.
Resolving deltas: 100% (492/492), done.
remote: Enumerating objects: 467, done.
remote: Counting objects: 100% (185/185), done.
remote: Compressing objects: 100% (167/167), done.
remote: Total 467 (delta 7), reused 70 (delta 4), pack-reused 282
Receiving objects: 100% (467/467), 197.63 KiB | 1.69 MiB/s, done.
Resolving deltas: 100% (8/8), done.
remote: Enumerating objects: 5915, done.
remote: Counting objects: 100% (4053/4053), done.
remote: Compressing objects: 100% (3445/3445), done.
remote: Total 5915 (delta 1099), reused 708 (delta 605), pack-reused 1862
Receiving objects: 100% (5915/5915), 15.88 MiB | 11.78 MiB/s, done.
Resolving deltas: 100% (1380/1380), done.
Updating files: 100% (6130/6130), done.

That's about 39 MiB in total and it could in theory work in place of full clones.

A config option with a default to clone just the last commit might be a good approach.

We are cloning the repo there only to get the config, right?

That's actually not true, we are getting the config via API earlier. The cloning happens anytime LocalProject is initialised, so there is room for improvement as well (probably related to #1955).


Loan Status Prediction (Model Enhancement , Visualizations , Hyperparameter Tuning)

🛠 Related Issue

Closes #203

📝 Description
The loan status prediction model utilizes a combination of machine learning algorithms, including logistic regression, decision trees, random forest, gradient boosting machines (GBM), support vector machines (SVM), and voting classifiers. Through exploratory data analysis (EDA) and hyperparameter tuning, the model optimizes performance and selects the best-performing algorithm. Key evaluation metrics such as precision, recall, are used to assess model effectiveness, with a focus on selecting the most accurate and reliable predictor for loan approval decisions.
🔍 Type of PR

[x] 🐛 Bug fix
[x] ✨ Feature enhancement
[x] 📚 Documentation update
[x] 🛑 Other (specify): _______________

📸 Screenshots / 🎥 Videos (if applicable)

✅ Checklist

[x] I have performed a self-review of my code.
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

ℹ Additional Context

Please review the changes and put the level-3 tag under GSSoC'24 before merging the PR

@Akshat111111 Can you please review the PR and merge it


Time Code Submission

Currently the submitted time code (e.g., for KIS tasks) requires the frame-number after the second, it would be very helpful to also allow for submitting milliseconds instead. Moreover, in the Submissions view of the server (Admin), it would be good to show the frames or milliseconds to clarify wrong submissions.

Closing this issue for now as it is fixed for version 2


feat: first set of mapping implementation #213

First implementation for get_id(), get_name(), get_description() and get_url().

Thanks for the PR @BaptisteCecconi!
I have a few comments that I'll post in the code review.

Ok, I updated the return types and removed the @pytest.mark.skipif decorators when applicable.
I still have a question on tests/test_main.py::test_convert_returns_expected_properties. It is failing if I don't skip it, and I don't see how to fix this one.


Aggregate migrations to 2.4.0-alpha

Description
The aggregation of the current migrations within the main branch to a '2.4.0-alpha' migration is needed in preparation for https://github.com/eclipse-tractusx/portal/issues/489

@evegufy should I close the issue? changes are done

@Phil91 thank you --> closed


Refactor Handlers

Refactor Handlers
fmt + clippy
adjustments while integrating into nteract-next

Current dependencies on/for this PR:

main

PR #34   👈

This stack of pull requests is managed by Graphite.


timeout is not effective

Hi,
I am wondering is wandb-osh --timeout -1 working?
and when I try to set it to negative or extremely large positive value it make no difference.
I still get time out warning.
Update:
https://github.com/klieret/wandb-offline-sync-hook/blob/4f228ece6b70d27b36f67f20f9d7a7b1f68c3093/src/wandb_osh/cli.py#L47
I guess the call to WandbSyncer is missing the time timeout thus the default is used (aka 120 sec)
Thanks

Very good catch, I'll fix that!
Sorry for the late reply!

@all-contributors please add @MoH-assan for bug


🐛 Tex output serialize content has been deleted

Right now the files can be cleaned up before other processing has been completed. I believe that this is only hit when there are outputs that are shared between notebooks (i.e. the hash is the same of the content). One of the notebooks deletes the files before the other one has started.
This is a temporary fix to not crash - @fwkoch I would be interested in a better solution.
Bug was introduced in:

#674

"Better solution" was merged in #683 - still not perfect, there are some comments on that PR.


UE4.16 Plugin Setup?

I'm attempting to get the ue4.16 branch up and running with a bare-bones project, and I have run into a couple problems.  I've cloned/checked out that branch, and ran init-plugin.hxml.  At first I got an "invalid excape sequence" error, which related to the gameDir string that was generated (which had backslashes in it).  I remedied this by adding gameDir = gameDir.replace('\\','/'); at line 85 in InitPlugin.hx, but then I get the following error:
c:\HaxeToolkit\haxe\std/haxe/macro/Context.hx:247: charactes 9-32:Type not found 'HaxeModuleRules' (called from ../unreal.hx/Haxe/BuildTool/Package.hx:42
Is the 4.16 branch missing some files?

Thanks for the bug report. This was an oversight as we are moving away from having to define your own Build.hx file - now you can directly subclass HaxeModuleRules on the Build.cs, in C# itself (and init-plugin.hxml won't be needed anymore). We still need to fix this for people that will use Build.hx, but a simple workaround would be to use Build.cs directly - like in https://github.com/proletariatgames/UE4Hx-Tests/blob/ue4.16/Source/HaxeUnitTests/HaxeUnitTests.Build.cs#L3

Well that sounds wonderful.  So once I check out ue4.16, I can go straight into adding classes to Haxe/Scripts?  Or is there another step before the engine will recognize my haxe class files and compile them?

Once you check out ue4.16, just change your Build.cs file to subclass HaxeModuleRules, and add the UnrealHx plugin to your uproject - e.g.
"Plugins: [{ "Name": "UnrealHx", "Enabled": true }]"

Sorry I'm new to plugins, but what file does that get added to?  My .uproject file directly?

Yes, so your project's .uproject file will have that. E.g.:
{
"FileVersion": 3,
...
"Modules": [ ... ],
"Plugins": [{ "Name": "UnrealHx", "Enabled": true }]
}

Does Unreal.hx require compilation outside of the editor (UnrealBuildTool)?

I have unreal.hx up and running with 4.16.3 and Haxe 3.4.2.
Just download the 4.16 branch, put it into "plugins/unrealhx" and change the .uproject file like it says above. Open Visual studio and hit compile, and you should be good to go! Requires a UE c++ project, right?

Success, thank you!  Also, as a note, you can start with a blueprint project, and convert it to a hybrid blueprint/c++ project by just creating a new empty class in the editor.


Using dynamic options in page make it crash when going back to formfilling

Description of the bug
In relle rettigheshavere we use dynamic options (disabled now). When it is enabled for the kontroll størrelse option it crashes when returning to Data task from confirmation. The options provider is not called
altinn-app-frontend.js:2
   TypeError: Cannot read properties of undefined (reading 'index')
at t.getIndexCombinations (altinn-app-frontend.js:2:2053084)
at altinn-app-frontend.js:2:2075576
at Array.forEach (<anonymous>)
at t.getOptionLookupKeys (altinn-app-frontend.js:2:2075463)
at d (altinn-app-frontend.js:2:2017417)
at d.next (<anonymous>)
at m (altinn-app-frontend.js:2:1697323)
at l (altinn-app-frontend.js:2:1697655)
at altinn-app-frontend.js:2:1693835
at g (altinn-app-frontend.js:2:1690101)

Steps To Reproduce
Enable dynamic options for this field.
Fill ot form
Go to confirm
Go back to data
See commit to disable
https://altinn.studio/repos/brg/rrh-innrapportering/commit/e228ecfee1f4f0bb1d070bdab256ff5f1ccd73ff
Additional Information
No response

I suspect this has been fixed now, as a consequence of #575 and #576. @TheTechArch, could you re-test this with v3.54.0-alpha2? I've made some attempts to reproduce it now, but I haven't managed to do it (but I'm unsure if I used the app correctly).

@olemartinorg
I tested this just now - seems to me like it works 😊

@allinox Fantastic! Sadly, the fix is a bit risky - and along with the #540 PR, the next release is scheduled to have a lot of (risky) changes. I'm wanting to delay it until I can look over #556 and clean up a little as well. You'll hear from me soon!

Closing as it is tested OK, but my point about the delayed release remains.


Remove access policy from key vault

Related command

az keyvault delete-policy
Is your feature request related to a problem? Please describe.

I am writing a script that should remove all user access policys for key vaults in a given environment. This is not possible with the azure-cli, but only with a Powershell module (https://learn.microsoft.com/en-us/powershell/module/az.keyvault/remove-azkeyvaultaccesspolicy?view=azps-9.1.0).
Describe the solution you'd like

an az keyvault delete-policy that takes an ObjectID and removes the access policy for the given object.
Describe alternatives you've considered

Additional context

@evelyn-ys for awareness


No ETag in Virtual Machines - Get response

API documentation for Virtual Machines - Get specifies that response returns etag property:

Name
Type
Description

etag
string
Etag is property returned in Create/Update/Get response of the VM, so that customer can supply it in the header to ensure optimistic updates.

I've tried executing this sample request from documentation using curl:
GET https://management.azure.com/subscriptions/{subscription-id}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/myVM?$expand=userData&api-version=2023-09-01

In documentation, sample response contains "etag":
{
  "name": "myVM",
  "id": "/subscriptions/{subscription-id}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/myVM",
  "type": "Microsoft.Compute/virtualMachines",
  "location": "West US",
  "tags": {
    "myTag1": "tagValue1"
  },
  "etag": "\"1\"",

But Azure Compute API doesn't return it in responses to my requests.
I need it to avoid race conditions when updating Virtual Machine. Is there a way to do it without ETag?

@andlr I am getting additional clarity on the etag functionality with the VM API and get back to you.

Any update on this ? I am facing the same issue.

@andlr @Mitthu1990 I am able to get the ETAG when sending API requests using API version 2023-09-01. Can you give a more specific example of when you are not seeing these Etags?

I've just tried this request again, and it does work now. But it didn't half a year ago, when I've created this issue. I guess I can close it now


#272 await missing from completions

Fixes statement range calculation to correctly handle empty statements.
Allows "await" to appear as a statement keyword.

:+1:


[SPARK-34776][SQL] Nested column pruning should not prune Window produced attributes

What changes were proposed in this pull request?

This patch proposes to fix a bug related to NestedColumnAliasing. The root cause is Window  doesn't override producedAttributes so NestedColumnAliasing rule wrongly prune attributes produced by Window.
The master and branch-3.1 both have this issue.
Why are the changes needed?

It is needed to fix a bug of nested column pruning.
Does this PR introduce any user-facing change?

No
How was this patch tested?

Unit test.

cc @dongjoon-hyun @HyukjinKwon @cloud-fan

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40831/

Test build #136249 has started for PR 31897 at commit 7eab1ac.

Test build #136249 has finished for PR 31897 at commit 7eab1ac.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136249/

Merged to master/3.1.
Could you make a backporting PR to 3.0/2.4?
I believe we can reuse the JIRA issue ID and with some properly modified title like [SPARK-34775][SQL] Window class should override producedAttributes.

Got it. Thanks @dongjoon-hyun


TableView dynamic columns

🐛 Bug Report
Not sure if this should be a bug or a feature, but sometimes we don't know the columns we will have in a table, until we fetch the some data, that can be different based on some query params.
🤔 Expected Behavior
To be able to set the columns async after the initial render.
😯 Current Behavior
Currently table view crashes.
💁 Possible Solution

🔦 Context
A good example would be a preview Table with some extra information for an item and based on let's say item type we will get different data and columns.
Workaround would be not to use asyncList, fetch in a wrapper and don't render the table until data is fetched and we know all rows and columns , but user will need to add a spinner for the table while data is fetching, and can't use the native api of the table for asyncLists and loadingStates
💻 Code Sample
https://codesandbox.io/s/dynamic-columns-spectrum-dtelm?file=/src/App.tsx

Interesting, not sure if this use case was considered by the team. For now I'm leaning towards this being a enhancement since, as you noted, the rendering of the TableView itself can be blocked until the columns are loaded but we'll have to talk to Spectrum about what the experience should be here (spinner where columns are? spinner where the TableView itself is? something else entirely?).

For now we are suggesting that you handle this by blocking rendering of the TableView until the fetch finishes and rendering a loading spinner yourself.


Fix alt-svc header

What does this PR do?
This PR changes the alt-svc header format.
Motivation
as specified https://quicwg.org/base-drafts/draft-ietf-quic-http.html#rfc.section.3.1, we need to send h3-#draft-version#=:#port# instead of quic=:#port#
and
as specified https://quicwg.org/base-drafts/draft-ietf-quic-http.html#rfc.appendix.B.22, we need to send supported version in quic=#supported# instead of v=#supported#
More

[x] Added/updated tests

Codecov Report

Merging #2166 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #2166   +/-   ##
=======================================
  Coverage   86.49%   86.49%
=======================================
  Files         104      104
  Lines        7484     7484
=======================================
  Hits         6473     6473
  Misses        750      750
  Partials      261      261

Impacted Files
Coverage Δ

http3/server.go
65.93% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 594b274...ff89d42. Read the comment docs.

Thank you for this PR!
The changes you're suggestion look correct, but it looks like we also need to fix the encoding of the version number. If I understand the spec correctly, it should be encoded as a hex value, right? Can you change protocol.VersionNumber.ToAltSvc()?

You're right, good catch!
And it's done :wink:


experiment

Description

Related Issue

Type of Change

[ ] ✨ feat -- New feature (non-breaking change which adds functionality)
[ ] 🛠 fix -- Bug fix (non-breaking change which fixes an issue)
[ ] ❌ ! -- Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 refactor -- Code refactor
[ ] ✅ ci -- Build configuration change
[ ] 📝 docs -- Documentation
[ ] 🧪 test -- Test
[ ] 🗑 chore -- Chore

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.96%. Comparing base (ef43eb7) to head (5f1dd55).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #883   +/-   ##
=======================================
  Coverage   61.96%   61.96%
=======================================
  Files          33       33
  Lines        1057     1057
=======================================
  Hits          655      655
  Misses        402      402

Flag
Coverage Δ

generator
63.13% <ø> (ø)

win32
59.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Slow import times

In environments that have Pandas, Dask, and maybe some other libraries installed, importing openff.units is pretty slow. This profiling is from from openff.toolkit.topology.molecule import Atom, but most of the time is spent here.

I anticipate this would be resolved via https://github.com/hgrecco/pint/issues/1460.

Well, I broke https://github.com/hgrecco/pint-pandas, but I made our import times not horribly slow.
https://github.com/hgrecco/pint/pull/1492 landed in Pint 0.21


TGI for Inf2 returns the input text even if return_full_text is set to False

As of https://github.com/huggingface/optimum-neuron/commit/3b3afa4dad427c0d43d3c799431a0e2619ac636a, calling a TGI endpoint for Inf2 returns the input text even if return_full_text is set to False in the request.
This is not the case for regular TGI.

@tahirazim is fixed in 0.0.18


MM-10970: Adds new FormattedMarkdownText to format translations using…

Summary
Adds ability to use markdown translations.
Ticket Link
MM-10970
Checklist

[ ] Added or updated unit tests (required for all new features)

Device Information
iPhone 6, iOS 11.4 (emulator)
Screenshots
Translation string:
'Enter *Enter* **Enter** ~~servr~~ `Server` [URL](https://simple.wikipedia.org/wiki/Uniform_Resource_Locator)\ntoday.'

Output:

Trying to run a simple test like this:
import React from 'react';
import {configure} from 'enzyme';
import Adapter from 'enzyme-adapter-react-16';
configure({adapter: new Adapter()});

import FormattedMarkdownText from './formatted_markdown_text';

import {shallowWithIntl} from 'test/intl-test-helper';

describe('FormattedMarkdownText', () => {
    test('should match snapshot', () => {
        const theme = {};

        const wrapper = shallowWithIntl(
            <FormattedMarkdownText
                id='asdf'
                defaultMessage='**hello** world'
                theme={theme}
            />,
        );

        expect(wrapper).toMatchSnapshot();
    });
});

fails on some syntax in node_modules/jail-monkey/index.js which if you follow it back along the call stack is being used by MarkdownLink. If I remove MarkdownLink the test can run.

Overall, this looks good. I'm excited to be able to start using this


Add Release 1.5.2 message to master CHANGELOG.md

The pull requests synchs Release 1.5.2 message onto master branch's
copy of CHANGELOG.md .  Our objective-c-sdk 1.5.2 was released
last week, June 15, 2018 .

Coverage remained the same at 97.248% when pulling cf12791f5402b183d42deb9ffaa78259c98cf901 on kroach/OASIS-2898-changelog into bacc139460a2ff5633f0da03aba60f4e1320fed3 on master.


Add test for 10 card; add test comparing 5-high straight to other str…

…aight; add test comparing two high-card hands where all cards but the last are equal in rank; update to version = 2. Also changed the name of test_an_ace_high_straight to test_a_5_high_straight and changed some other test names and variables to match poker convention of reporting two pair with highest pair first. Closes #446.

Don't forget to add the corresponding example.rb to show proof of concept.

@moveson ,  You'll need to remove the poker.rb file and only have example.rb as the example solution.

Also add closes #446 to the description so that the issue is automatically closed when this PR is merged.

Closes #446

@moveson Not sure if a comment would work, you will need to edit your first description  and add it there.
Refer: https://github.com/blog/1506-closing-issues-via-pull-requests
PS: This is not super-important, but just that we don't forget to close the issue after this is merged.

OK, thanks for your patience. This is my first collaborative project for which I am not the owner.

This is failing the CI Check due to a Rubocop issue:
9.26s$ rubocop -fs -D
== exercises/poker/poker_test.rb ==
C: 62:  5: Style/VariableName: Use snake_case for variable names.
C: 63:  5: Style/VariableName: Use snake_case for variable names.

The variables in question are these, imo sensibly named, variables:
62: +    double_pair_K_and_2 = %w(2S KH 2S KD JH)
63: +    double_pair_Q_and_J = %w(JS QH JS 8D QH)

The best solution for now is probably to wrap the test_another_two_double_pair method with the Rubocop disabling comments:
#rubocop:disable Style/VariableName
and
#rubocop:enable Style/VariableName

I started looking more closely at local variable names in the tests, which made me look more closely at the cards used in the tests, which led me to add validations to uncover any duplicate cards in the tests. There were a surprising number of invalid hands and hand comparisons because of duplicate cards, and these have been fixed in the latest push.

If those are invalid hands only because of duplicate cards, realize that there is nothing indicating a single deck hand.  Indeed, the tests even support a multi-deck hand.  Before removing this, consider the value of this discussion on the exercism site for premature validation or defensive programming.

I have been assuming the exercise is for single-deck poker. If the intention is to support multi-deck poker, then shouldn't the highest scoring hand be 5-of-a-kind? I don't feel strongly one way or the other, but this discussion indicates that the exercise should specify one way or the other, and of course the tests should reflect the stated expectation one way or the other.

I vote for single deck, poker gets more complicated with more decks!

Don't forget how the tests can drive implementation, and may remove some discussion from the iterations.  This has no tests that test for "valid hands" in a single deck use, that I have spotted.  There is code in the example for this though.  The example.rb should be driven by the tests... I have not gone through extensively to ensure this is happening at the moment.

Yes, understood. I wrote the hand-validation code to ferret out duplicates and clean up the tests (this is really hard to do by just eyeballing them), but I understand that hand validation is not strictly necessary and may make the problem more complicated than it needs to be. I think the best course of action moving forward should be:

State expressly in the README file that this exercise relates to single-deck poker
To avoid confusion, update the tests to remove duplicate cards (as the PR already reflects)

and then either:
3(a) Add tests to require a raise if there is card duplication, or
3(b) Remove the hand-validation code from the example.
I feel 1 and 2 are important but don't feel strongly about the choice between 3(a) and 3(b).

I say leave the possibility for assumption, write the tests to the most "default" position (being a single test), don't test for duplication (this forces a single deck).  This can bring up the discussion of "How easily would it be to expand this to multiple decks?" etc.  Removing the duplicate card(s) is fine, I think.
Even having the duplication in the test itself in no way invalidates any requirement at the moment.  But it does open up the discussion as to why it may be there, what the tests are trying to communicate (That they are not complete, that it may be remnants of a real life project that does involve multiple decks, etc.).
I like having the work done that you did, it doesn't enforce a single deck, only lightly suggests it, it leaves a discussion open.

OK, so not sure what you want me to do next. Should I remove the hand-validation code from example.rb? Are any changes needed in the tests?

I don't think there are changes in the tests necessary.  Yes for the cleanup for the code in example.rb.  Anything that is not driven by the tests, and not mentioned in the Readme.
If you are interested, I think the next steps would be to start the process for exercism/x-common for putting together the common data.  I think Hamming exercise may be a good example to work from.  That will bring in other tracks and conversations about some things mentioned in this discussion should be covered.
After that, the following step would be writing the generator for this track, based on that common data.
Are you game?

Looks good to me, let's squash the commits as appropriate.

Would you like me to squash commits on my end and force a push? Or will you squash commits during the merge?

Best if you squash them, as you are the best person to make sure that the log message contains all the relevant information from the squashed commits.

Looks good to me, I'll let @kotp merge this.

Thanks @moveson I just brought the changes in.  I think there is some time before fetching will be bringing in the new tests, but it should start happening soon.


Interface Docs

Docs Improvment
export interface SummaryDetail {
  ...
  bid?: number;
  ask?: number;
  bidSize?: number;
  askSize?: number;
  ...
}

Suggested Improvement
export interface SummaryDetail {
  ...
  bid?: number;
  /**
   * Returns the current market price for one share of this stock.
   */
  ask?: number;
  bidSize?: number;
  askSize?: number;
  ...
}

Reason For Suggestion (if not related to a module)
Currently many interfaces does not have any documentation about the attributes they contain and what the attributes are meant for. This makes it hard to guess what the attribute could be used for, when you are not familiar with the yahoo api. Look at the SummaryDetail Interface in the quoteSummary functionality. When you read the attribute ask for example you may ask yourself if the attribute represents the current market price of this stock or the current volume activity? I think its not needed to document every single attribute since the meaning of some are obvious but some should be documented.
If you agree with me I would be happy to contribute to this improvement.

While this could take potentially hours or weeks, it may be worth it. However, each response field isn't well documented documented at all on yahoo's side - we would have to do a lot of guessing. If we perform this task, there may be a good few inaccuracies. What do you think, @gadicc?

Hey @RoXioTD, thanks for raising this.  Like @PythonCreator27 says, we have no way to know the true definition of these fields.  Having said that, I agree with you both that this is likely worth doing, and indeed helpful.  It's clear this is a community project with no liabilities, and we can stress this again in the docs that the field definitions are user contributed - and continue to accept PRs for corrections or improvements.
So @RoXioTD, if you're happy to contribute something like this, it will be very, very welcome and I thank you for the initiative.
We can also get guidance for how the fields are used in Yahoo Finance's own site (React based, so potentially using the React dev tools it will be slightly easier to track where the values come from, but we may still need to infer their true meaning).
Lastly, TypeScript / JSDoc accepts such definitions on one line too, which I think is better for shorter ones, e.g.
export interface SummaryDetail {
  // ...
  bid?: number;
  /** Returns the current market price for one share of this stock. */
  ask?: number;
  bidSize?: number;
  askSize?: number;
  // ...
}

Thanks so much!  Really excited to see where this goes.


How do i fix this

everytime i try to convert a rat python script into an executable this comes
Error: [WinError 2] The system cannot find the file specified: 'testfile.spec'

Which version of Python do you use?


chore(storage): return proper error on import failure

Signed-off-by: Amine Kherbouche<EMAIL_ADDRESS>

LGTM :+1:


[ADP-2878] Remove cleandb from db-bench.hs

This is part of the epic to remove (unused) multi-wallet support in DBLayer
Because we need to remove the removeWallet function in the DBLayer we need to remove cleanDB function which is based on it. A lot of testing/benching code depends on it to reuse the database instance for multiple subsequent operations. The solution is to use instead a reset/cleanup operation at the DBFactory level that will restart the DB completely.

[x] remove cleanDB function and restructure a bit to reuse db factory-level cleanup in db-bench-hs

ADP-2878

bors r+


Determine key based on file checksum

As in the example at https://github.com/actions/toolkit/issues/47#issuecomment-525028518, it is useful to determine the key based on the contents of a file, such as package-lock.json for Node.js or mix.lock for Elixir.
key: v1-npm-dependency-cache-{{ checksum "package-lock.json" }}

That way the cache lasts for as long as the dependencies remain the same.
This was actually pretty easy to implement in Go.

Sorry, I didn't see that hashFiles('**/package-lock.json'). 🤦♂


Multi page toggle survey ux

-Make description wider
-Move description closer to multi toggle button
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report

Merging #1495 (003e804) into main (d389395) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1495   +/-   ##
=======================================
  Coverage   72.01%   72.01%
=======================================
  Files         330      330
  Lines        9698     9698
  Branches      696      696
=======================================
  Hits         6984     6984
  Misses       2597     2597
  Partials      117      117

Flag
Coverage Δ

metweb
65.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes


Fix Ajv import

Thanks for this package! I had trouble finding something to help me validate and OpenApi Doc with nested discriminators but I managed to get this working for my needs and its great!
Opening this PR to fix this issue that cropped up for me, ajv is the default export:
node_modules/express-json-validator-middleware/src/index.d.ts:4:10 - error TS2614: Module '"ajv"' has no exported member 'Ajv'. Did you mean to use 'import Ajv from "ajv"' instead?

4 import { Ajv, ErrorObject, Options as AjvOptions } from "ajv";
           ~~~

Found 1 error.

+1

Codecov Report

Merging #110 (13760e5) into main (689fb6d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #110   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           26        26
=========================================
  Hits            26        26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 689fb6d...13760e5. Read the comment docs.

@ledleds Thanks so much for this fix! I'm going to open a separate PR to automatically type check these type definitions.
I'm surprised this issue hasn't cropped up before. I can only guess that most folk have skipLibCheck enabled in their tsconfig.json.

Released in v3.0.1 (npm).


ScanNetPP training

Hi, thank you for your great work!
I am a beginner, my questions might be a bit basic, but I hope you can offer me some advice.
When I use the ScannetPP dataset, I found that the train split is "train_grid1mm_chunk6x6_stride3x3" in the config file "semseg-pt-v3m1-0-base.py". So I have some confusion. Can you help me？
1.What's the difference between "train_grid1mm_chunk6x6_stride3x3" and "train".
2.Why are some "train" files missing in "train_grid1mm_chunk6x6_stride3x3" , such as "0a5c013435","3e928dc2f6", etc.
3.I  changed the config file and used "train" split, but Loss=nan in the middle of the trainig. But when I use the "train_grid1mm_chunk6x6_stride3x3" split, the training process can proceed normally. Can you provide some possible reasons?
Thank you for your help!

thank you！


Flutter 3.27, text appears thinner than expected

Steps to reproduce

Run the code sample

Device model:
Xiaomi 11 Lite 5G NE.
Expected results
I'm not sure if this is the expected behavior. I tried disabling Impeller, but the result remained the same.
Actual results
Text rendered thinner
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(
    const MainApp(),
  );
}

class MainApp extends StatelessWidget {
  const MainApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: Scaffold(
        body: Center(
          child: Text(
            'Hello World',
            style: TextStyle(fontSize: 30),
          ),
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration

3.27
3.24.5

Logs
No response
Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.27.0, on macOS 14.5 23F79 darwin-arm64, locale en-VN)
    • Flutter version 3.27.0 on channel stable at /Users/khoa/fvm/versions/stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 8495dee1fd (2 days ago), 2024-12-10 14:23:39 -0800
    • Engine revision 83bacfc525
    • Dart version 3.6.0
    • DevTools version 2.40.2

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/khoa/Library/Android/sdk
    • Platform android-35, build-tools 34.0.0
    • Java binary at: /Users/khoa/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 16.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 16B40
    • CocoaPods version 1.16.2

[✗] Chrome - develop for the web (Cannot find Chrome executable at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✓] Android Studio (version 2024.2)
    • Android Studio at /Users/khoa/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11)

[✓] VS Code (version 1.96.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.102.0

[✓] Connected device (4 available)
    • 2109119DG (mobile)              • <IP_ADDRESS>:40405                  • android-arm64 • Android 14 (API 34)
    • iPhone 16 Pro Max (mobile)      • DE5E6F3B-4DED-4446-9C0E-BA12380EFE8C • ios           • com.apple.CoreSimulator.SimRuntime.iOS-18-1 (simulator)
    • macOS (desktop)                 • macos                                • darwin-arm64  • macOS 14.5 23F79 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad                • darwin        • macOS 14.5 23F79 darwin-arm64

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

@khoadng
I don't see the behavior on S10+ device. Can you provide the font weight set on your device and whether it was changed ?
Also, can you try on another device to see if you still get same behavior or not ?
Moreover, can you try on latest master version as well to check if you still see same behavior or not ?

@darshankawar

Can you provide the font weight set on your device and whether it was changed ?

comparison when I set them to XXL

3.27 XXL
3.24.5 XXL

Also, can you try on another device to see if you still get same behavior or not ?

I checked with Samsung Galaxy A04, no issue.

Moreover, can you try on latest master version as well to check if you still see same behavior or not ?

The issue is still there (3.27.0-1.0.pre.669)

This is a bug in 3.24.
https://github.com/flutter/flutter/issues/154166

@khoadng
Is the device you are seeing this on uses ColorOS or HyperOS. ?

HyperOS 1.0.10
Android 14

The issue is still there (3.27.0-1.0.pre.669)

This isn't latest master. Please upgrade to latest and re-run to confirm.

Tried with 3.28.0-1.0.pre.125, same problem

This is a bug in 3.24. #154166

It's a 3.24 bug that causes the text to look bolder.

As you can see in my screenshot, the text is not in Chinese characters, and it looks thinner, not bolder.

You can compare 3.22, 3.24 is wrong.

@khoadng
Can you try with latest stable hotfix (3.27.1) to check if the issue still persist or not.

@darshankawar
The issue is still present in 3.27.1
@HaijunWei
I’m unable to compile the starter template with version 3.22.3, so I can’t verify it.

Keeping the issue open for team's tracking as I am unable to replicate this on device (S10+) and Pixel 7.

@khoadng 我也是用小米手机，flutter 字体由 skia 渲染，而 web 也是通过 skia 渲染，所以手机网页的字体和 flutter 是一样的，它们都和原生应用不一致


Update README formatting

These changes are all just trivial ones I made as I read through the README.

Thanks @lafrenierejm
I've merged it in 👍


bench does not pass dash-prefixed arguments to binary

Problem
cargo bench -- --blah raises error Unrecognized option: 'blah'.
cargo bench -- -b raises error Unrecognized option: 'b'.
However, cargo bench -- blah is okay.
cargo still seems to be handling them on its own. The expected behavior is to pass all arguments after " -- " to the binary.
Steps

run cargo bench -- --blah or cargo bench -- -b.

Possible Solution(s)
No response
Notes
No response
Version
cargo 1.57.0 (b2e52d7ca 2021-10-21)
release: 1.57.0
commit-hash: b2e52d7cab0a286ee9fcc0c17510b1e72fcb53eb
commit-date: 2021-10-21
host: x86_64-pc-windows-msvc
libgit2: 1.3.0 (sys:0.13.23 vendored)
libcurl: 7.79.1-DEV (sys:0.4.49+curl-7.79.1 vendored ssl:Schannel)
os: Windows 10.0.19042 (Windows 10 Pro) [64-bit]

Sorry, maybe I'm confused by what you are trying to illustrate, but I believe this is working as expected.  The test harness has its own argument handling.  You can see the kinds of arguments it takes by running cargo bench -- --help.
If you want to handle arguments yourself, you have to set harness=false in Cargo.toml and write your own main function.

@ehuss Sorry I forgot to mention this, I have set harness=false.
So in more details:
Cargo.toml
[package]
name = "bench_bug"
version = "0.1.0"
edition = "2021"

[[bench]]
name = "bench_example"
harness = false

benches/bench_example.rs
fn main() {
    println!(
        "Bench_example args: {:?}",
        std::env::args().collect::<Vec<String>>()
    );
}

(The following binary paths are simplified)
I expect to get output:
Bench_example args: ["bench_example.exe", "--blah", "--bench"]

But there seems to be no way, I tried:
$ cargo bench
Bench_example args: ["bench_example.exe", "--bench"]

$ cargo bench -- blah
Bench_example args: ["bench_example.exe", "blah", "--bench"]

$ cargo bench -- --blah
error: Unrecognized option: 'blah'
error: bench failed

I just found a way to make it work:
$ cargo bench -- -- --blah
Bench_example args: ["bench_example.exe", "--", "--blah", "--bench"]

But you can see a "--" argument. Is this also expected? If so, I may have to manually filter both "--" and "--bench" to get it working with my #[derive(clap::Parser)] structure.

It seems that Unrecognized option: 'blah' is from getopts, which is used by libtest.
Without specifying a benchmark to run, args after -- slip into test harness. Running benchmark with --bench arg should fix your issue.
$ cargo bench --bench bench_example -- --blah
    Finished bench [optimized] target(s) in 0.00s
     Running unittests (target/release/deps/bench_example-1e2b3187f40626fe)
Bench_example args: ["target/release/deps/bench_example-1e2b3187f40626fe", "--blah", "--bench"]

@weihanglo It works now, thank you very much!
If this is by design, I think we can close this issue.


[WIP] Add rbac to kubeadm.

Partially resolves #402
(Still a WIP but didn't want to lose track of the work while I'm out.)

Closing in favor of #623


issue

Try npm install @types/react-styled-carousel if it exists or add a new declaration (.d.ts) file containing declare module 'react-styled-carousel';

@appasaheb4 We don't have types for this project. Please feel free to create a PR, if you would like to add. Closing this issue


Receive Code error

File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 801, in __bootstrap_inner
self.run()
File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 1073, in run
self.function(*self.args, **self.kwargs)
File "/Users/MitchellPavlak/PythonProjects/P2PPlatform/Network.py", line 132, in autoReceiver
self.alert(message)
File "/Users/MitchellPavlak/PythonProjects/P2PPlatform/Network.py", line 45, in alert
alerter(message)
File "/Users/MitchellPavlak/Desktop/iRT/ChatInterface/ChatInterface2/ChatInterface/Interface.py", line 168, in netMessage
if message[:6] == "" and self.receivingCode:
TypeError: 'int' object has no attribute 'getitem'
I have a suspicion that this is because of initial port passing, which makes me hopeful that the update I just did to alerters worked (I'll push shortly)—I'll take a look

Fixed, and no longer relevant to this repo.


Qingwei/trade lifecycle

@borisyankov
This PR is not handling asset symbol, so it always create new trade of R_100, I think it's sensible because it's not clear what symbol should we use.
Is it fine?

Coverage decreased (-0.03%) to 30.983% when pulling c39d233cd6c5953ad4820ddd8795b5db0832d5b6 on qingweibinary:qingwei/trade_lifecycle into e26947f4584502e02245de2e4eaa8f7c8215144a on binary-com:master.

Yeah, R_100 is good for now. Later we might improve.


4 spaces, lint everywhere

Reviewer: self
CC: @MariagraziaAlastra @jdorweiler @russellholt @dharb
Description:
Finally trying to standardize all the code across the entirety of the codebase. This is with --fix. There will be some manual changes as well, in a separate PR.
To see a diff without all the whitespace changes see: https://github.com/duckduckgo/duckduckgo-privacy-extension/compare/develop...andrey/4-spaces?w=1
Steps to test this PR:

Automated tests:

[ ] Unit tests
[ ] Integration tests

Reviewer Checklist:

[ ] Ensure the PR solves the problem
[ ] Review every line of code
[ ] Ensure the PR does no harm by testing the changes thoroughly
[ ] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR Author Checklist:

[ ] Get advice or leverage existing code
[ ] Agree on technical approach with reviewer (if the changes are nuanced)
[ ] Ensure that there is a testing strategy (and documented non-automated tests)
[ ] Ensure there is a documented monitoring strategy (if necessary)
[ ] Consider systems implications

Lookin' good.


feat: simplified job for Keep3r v2.2

bls add the Keep3r version that the keeper should be registered on!


Upstream can't become healthy from unhealthy

Summary
There is one case,that there is one upstream with an target,only one target.And then put the target offline by admin_api or delete the target by admin_api.The third step is take the target online.
At the time,you will see all of the request will meet an 503 error with an error message 'failure to get a peer from the ring-balancer'.
I have tried  ten times in my env, and it will occur more than eight times.
It seems like a mechanism,that kong will delete the upstream in memory when there is no target in upstream.But it become a bug when the target comes back.
Steps To Reproduce
1.take the  only target offline
2.add the same target,and online it
3.go http request and check the response
Additional Details & Logs
There is no message appear in log file
Env:
Kong: Centos
Upstream: Java/Centos
Kong version (v1.4.0)

Hi @wangdafang, we have made a few changes to the balancer. Could you confirm if this issue still exists?


Partials: Correctly set the HtmlFieldPrefix of the partial view

Otherwise IdFor and friends do not work as expected because the view prefix is empty.
This also has the advantage of not replacing the user FieldGenerator for the view.
--
Before this patch, if you have the following:
@* Parent.cshtml *@
@using (var f = Html.BeginChameleonForm()) {
     using (var s = f.BeginSection("Fields")) {
           @s.PartialFor(m => m.ChildProperty)
     }
}

@* ChildProperty.cshtml *@

@this.FormSection().FieldFor(c => m.Integer)

<script>console.log($('#@Html.IdFor(m => m.Integer)').length)</script>

The javascript console will print 0, because the id of the Integer field is ChildProperty_Integer but IdFor returned Integer.
After the patch the console will print 1, as expected.

ping

This also has the advantage of not replacing the user FieldGenerator for the view.

I just noted that this (replacing the user FieldGenerator) makes this feature unusable for my use case, becase I have several non-default handlers.

This is a good change, but I'm wondering if we need to write a test to cover the bug it's fixing first?

I'm doing this as part of some other work I'm doing to fix a bug in Partial.

Indeed, tests would be nice. I'll try to get something and submit it.

Oh you already did that in #155. Thanks!
Saludos,
Felipe Sateler
On Jan 28, 2017 13:01, "Rob Moore"<EMAIL_ADDRESS>wrote:

I'm doing this as part of some other work I'm doing to fix a bug in
Partial.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MRCollective/ChameleonForms/pull/152#issuecomment-275856314,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABQsHYnNMpdhqIGfPEZ5VdctQ8Ww4SCaks5rW2ZhgaJpZM4K_klS
.


[AMBARI-24637] Ambari metrics service check failed during UI deploy.

What changes were proposed in this pull request?
Race conditions in UUID computation helper caused issues in writes. Fixed the race condition.
How was this patch tested?
Manually tested.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3949/
Test FAILed.
Test FAILured.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3952/
Test FAILed.
Test FAILured.

retest this please.


Hardcoded check for San Marino

Issue content
@astagi ,
validator.js has this hardcoded check (below), which is not dependent on the settings file that can be downloaded from dgc official site, nor can be found in any of the files that can be cached by the library:
 72     if (type === 'Sputnik-V' && last.countryOfVaccination !== 'SM') {
 73       return {
 74         code: NOT_VALID,
 75         message: 'Vaccine Sputnik-V is valid only in San Marino',
 76       };
 77     }

Is there a place where all these special rules are listed (and maybe can also be downloaded like the settings file)?
Thank you.

Hi @qippur unfortunately not, this is something that will be implemented in business rules. At the moment Italy is not using business rules to verify DCCs so we're forced to use settings + hardcoded values.


[Feature] Improve node startup time?

🚀 Feature

The client node currently takes way too long to start - I'm measuring a 4-minute loading time with zero output to indicate what the node is doing.
Motivation

Restarting the node is becoming PITA with the longer startup time. Especially important for service providers as well.
Implementation

Dunno TBH, haven't profiled it.
Are you willing to open a pull request? (See CONTRIBUTING)
Not sure.

I'll bring https://github.com/AleoHQ/snarkVM/pull/1606 up to date, it should speed it up.

I just tested it with a fully synced client node, and indeed, it speeds things up.

baseline (testnet3): 119.45s
with the linked snarkVM PR: 41.75s (-65%)

I've confirmed that PR significantly speeds up the startup time, and it scales especially well with high core counts.
The remaining feature request would be to provide some feedback on what the node is trying to do - even with verbosity 3 there is only a "Starting a client node" message.

The startup speed-up one? I don't think so, it's most likely a separate new issue.

strange, lemme try to isolate this then. I'm getting another strange panic right now:
thread 'tokio-runtime-worker' panicked at 'assertion failed: previous_atomic_depth != 0', /home/mrx/snarkVM/ledger/store/src/helpers/rocksdb/internal/map.rs:217:9                                                note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I'll try to revert some commits to see which one caused this.


support and explain use of service_name options via cli or yaml.

This PR for #99 adds support for the following:

suggestions for ways to specify service_name in the README.
example of how to configure pip install to trigger installation of pyyaml.
support for --service=<name> on the coveralls cli, eliminating the requirement for pyyaml in order to explicitly name the service.

This is a backwards-compatible change, as evidenced by the two screenshots below.
Note: I have also suggested to the Travis team that they add support for a TRAVIS_PRO=true environment variable. Time will tell on that one. Meanwhile, this PR offers two ways to get around the apparently-common problem of Coveralls getting mixed signals between travis-ci and travis-pro values on successful builds.
As coveralls behaved prior to this PR (with the new debug log message added):

How coveralls behaves with the --service=<name> option.

This change is

Hey there! This repo just underwent a change in maintainers -- myself and @goanpeca will be taking over this project. Give us some time to get up-to-speed and we'll make sure to take a look at this PR soon.

Closing as abandoned. I will be opening a PR with this patchset momentarily and getting it merged in. Thanks for the submission!


Acceptance test for smart contract based permission models

This PR contains the acceptance test to support contract based permission models.

basic (v1)
eea (v2)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: amalrajmani:x: amalraj.manigmail.comamalraj.manigmail.com seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

This PR has some commits with invalid user id: amalraj.manigmail.com
I will raise a new PR without user id related issues to replace this


Add functionality to mark embedded field with reference back to parent.

It is there. Just set a key as parent: true and notSaved: true on the field you want to be the parent and it will work.


How should we handle censoring / loss-of-follow-up / exclusion criteria for the 1y-5y MI task?

Task file: https://github.com/mmcdermott/MEDS-DEV/blob/main/src/MEDS-DEV/tasks/criteria/phenotyping/outpatient/MI/1y-5y.yaml

@prockenschaub, I'm very comfortable changing the criteria for this task (or deciding we can't pursue this task if we can't appropriately handle competing risks with death and censoring due to loss of follow up). what would you recommend?

I think what irritates me about this task is the long follow-up. While binary classification is easily defendable for short-term outcomes like 30-day readmission, using it for follow-ups up to 5 years seems less advisable. After all, this type of question is the poster child for time-to-event analysis. This may simply be a gut feeling, though, because I think the basic problems remain the same.
Treatment of competing risks in existing CVD prevention tools
You linking the readmission task to a prospective use case helped me a lot to think about it, so I tried to do the same here. To me, this task feels a lot like the traditional CVD risk assessment models, e.g., SCORE2 endorsed by the European Society of Cardiology. The goal here is to estimate a patient's risk of developing CVD. Using this estimated risk, we can stratify patients and recommend high-risk patients for additional preventative care, closer management, etc.
If we accept that as the prospective use case, it is interesting to note that SCORE2 was developed using a Fine-Gray (FG) model, which --- unlike the Cox model which models hazards --- directly models the relationship between covariates and the cumulative incidence function (CIF). There are two interesting aspects of this choice: (1) this does not care whether the CIF is reduced because a covariate lowers the risk of CVD specifically or whether it just increases the risk of dying before ever getting the chance to develop CVD, and (2) it is very similar to Option 2 in the readmission task if we do not allow for censoring other than through death (i.e., every patient either has $E=1$ or $M=1 but never $E=0$ and $M=0$)
Even though FG was used in this very popular score, it remains debatable whether it was the right choice to begin with. The likely reason why it was chosen is that it allows to directly link covariates to the CIF, which is particularly important for such a simple scoring system calculated by hand but less important for an computerised decision support tool. To say it with the words of Therneau, the creator of the R survival package:

The primary strength of the Fine-Gray model with respect to the Cox model approach is that if lifetime risk is a primary question, then the model has given us a simple and digestible answer [...] This simplicity is not without a price, however, and these authors are not proponents of the approach. [...] The attempt to capture a complex process as a single value is grasping for a simplicity that does not exist for many (perhaps most) data sets.

What other option might exist?
Pooled binary prediction
A method that has become very popular in causal inference is pooled logistic regression. Here, the follow-up time is divided into discrete bins (e.g., weeks or months) and the model predicts for each bin if the event is going to happen. For example, we could divide our follow-up into yearly bins (1st year, 2nd year, ...) and treat each one as a binary problem. Once an event has happened or the patient is lost to follow-up, no subsequent years are included. The total predicted risk for a patient can then be estimated by through $1 - \prod_t=1^5 (1 - \hat p_t)$.
This is a (sequential) binary task that captures a lot of the intricacies of time-to-event data, and it might be adapted to either resemble a Cox model or a FG model. However, it still adds some (necessary?) complexity that we may not want to have in the initial push.
Additional thoughts
Delayed prediction
I presume the gap of 1 year between annual physical and the prediction window is meant to avoid any causal leakage of information around the time of the visit (e.g., because a test was ordered following the physical and the result backdated)? Whether or not this is necessary probably strongly depends on the dataset. For example, if I knew for sure that this does not happen, I would want to predict for the entire follow-up from 0-5y. This is what SCORE2 and other traditional scores do.
I agree that for benchmarking purposes --- and without knowing much about the underlying datasets --- it may make sense to choose a safer option and include some wash-out period of immortal time to avoid any leakage. We do something similar in the current definition of the mortality task here, and Robin and I also introduced a gap like this in YAIB. However, I am wondering whether 1y is way too conservative and we should consider 1m-5y instead, which hopefully introduces a less severe selection bias (simply excluding those at imminent risk of MI).
Implicit vs. explicit loss to follow-up
One problem in the readmission use case is that we usually don't know if a patient was lost to follow-up. If all we have is MIMIC, we don't know if a patient was lost to follow-up, for example because they moved to a different state.
Depending on the healthcare system, primary care data like the one implied by this task may be different. In the UK, for example, you are registered with your general practitioner and a patient can be considered under observation as long as they remain registered with that practitioner. This allows to distinguish between patients who are followed-up but have no visits/data and patients who are truely lost to follow-up. If possible, this would be a better criterion than "any data after 5 years", mainly because it doesn't bias the cohort as much towards patients with longer follow-ups or frequent visits.