[FEATURE REQUEST] - Compatibility with Image Receiver node (Impact Pack)

Summary
I'm considering different approaches to reduce the number of wires in the AP Workflows without sacrificing understandability of the information flow.
Among the other things, I'm evaluating the use of Impact Pack's Image Sender and Image Receiver nodes.
I would place an Image Sender node after each image generation node (e.g., KSampler, Detailers) and an Image Receiver node just before every SD Prompt Saver node.
My test shows that the latter don't play well together.
After a KSampler node generates the image, it passes it to the Image Sender node, which correctly passes it to the Image Receiver node. However, the Image Receiver node doesn't seem to pass the image to the SD Prompt Saver node as expected:

I am not married to the idea of using Impact Pack's Image Sender/Receiver nodes at all costs. I'd just like to have the SD Prompt Saver to wirelessly receive the image to save, if possible.
Basic Example
See screenshot.
Reference Issues.
No response

In my tests, everything is working fine, at least the Prompt Saver performs the same as the built-in Saver.
I guess what you mean by 'don't play well together' is that the Saver only updates the image from the first generation after generating the second one. But even when connecting the image receiver to the built-in Saver, this behavior still occurs. So, it seems to be a characteristic of the image receiver rather than something caused by the Saver.

That is correct. I wrongly assumed that behavior was caused by an incompatibility with the SD Prompt Saver. I should have checked the default saver before opening this issue. I'll be more mindful in the future. Thanks for testing it.


rosidl linking error

Dear community,
I have a problem with meta-ros2-iron compilation. There is a mixing target and native symbols during linking. I was trying to build the bitbake lifecycle-msgs -c compile but lot of components are failing due to the same error.
build/../meta-ros/meta-ros2-iron/generated-recipes/rcl-interfaces/lifecycle-msgs_1.6.0-2.bb:do_compile
build/../meta-ros/meta-ros2-iron/generated-recipes/rcl-interfaces/rcl-interfaces_1.6.0-2.bb:do_compile
build/../meta-ros/meta-ros2-iron/generated-recipes/common-interfaces/sensor-msgs_5.0.0-2.bb:do_compile
build/../meta-ros/meta-ros2-iron/generated-recipes/common-interfaces/std-srvs_5.0.0-2.bb:do_compile
build/../meta-ros/meta-ros2-iron/generated-recipes/common-interfaces/nav-msgs_5.0.0-2.bb:do_compile
build/../meta-ros/meta-ros2-iron/generated-recipes/common-interfaces/diagnostic-msgs_5.0.0-2.bb:do_compile
build/../meta-ros/meta-ros2-iron/generated-recipes/geometry2/tf2-msgs_0.31.5-1.bb:do_compile
build/../meta-ros/meta-ros2-iron/generated-recipes/rosbag2/rosbag2-interfaces_0.22.3-1.bb:do_compile

FAILED: liblifecycle_msgs__rosidl_generator_c.so
: && /home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/recipe-sysroot-native/usr/bin/aarch64-oe-linux/aarch64-oe-linux-gcc -fPIC -mcpu=cortex-a53 -march=armv8-a+crc+crypto -mbranch-protection=standard  --sysroot=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/recipe-sysroot  -O2 -pipe -g -feliminate-unused-debug-types -fmacro-prefix-map=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/git=/usr/src/debug/lifecycle-msgs/1.6.0-2-r0  -fdebug-prefix-map=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/git=/usr/src/debug/lifecycle-msgs/1.6.0-2-r0  -fmacro-prefix-map=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/build=/usr/src/debug/lifecycle-msgs/1.6.0-2-r0  -fdebug-prefix-map=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/build=/usr/src/debug/lifecycle-msgs/1.6.0-2-r0  -fdebug-prefix-map=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/recipe-sysroot=  -fmacro-prefix-map=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/recipe-sysroot=  -fdebug-prefix-map=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/recipe-sysroot-native=  -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -fmacro-prefix-map=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/git=/usr/src/debug/lifecycle-msgs/1.6.0-2-r0  -fdebug-prefix-map=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/git=/usr/src/debug/lifecycle-msgs/1.6.0-2-r0  -fmacro-prefix-map=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/build=/usr/src/debug/lifecycle-msgs/1.6.0-2-r0  -fdebug-prefix-map=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/build=/usr/src/debug/lifecycle-msgs/1.6.0-2-r0  -fdebug-prefix-map=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/recipe-sysroot=  -fmacro-prefix-map=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/recipe-sysroot=  -fdebug-prefix-map=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/recipe-sysroot-native= -shared -Wl,-soname,liblifecycle_msgs__rosidl_generator_c.so -o liblifecycle_msgs__rosidl_generator_c.so CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/msg/detail/state__description.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/msg/detail/state__functions.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/msg/detail/state__type_support.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/msg/detail/transition__description.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/msg/detail/transition__functions.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/msg/detail/transition__type_support.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/msg/detail/transition_description__description.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/msg/detail/transition_description__functions.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/msg/detail/transition_description__type_support.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/msg/detail/transition_event__description.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/msg/detail/transition_event__functions.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/msg/detail/transition_event__type_support.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/srv/detail/change_state__description.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/srv/detail/change_state__functions.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/srv/detail/change_state__type_support.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/srv/detail/get_available_states__description.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/srv/detail/get_available_states__functions.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/srv/detail/get_available_states__type_support.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/srv/detail/get_available_transitions__description.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/srv/detail/get_available_transitions__functions.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/srv/detail/get_available_transitions__type_support.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/srv/detail/get_state__description.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/srv/detail/get_state__functions.c.o CMakeFiles/lifecycle_msgs__rosidl_generator_c.dir/rosidl_generator_c/lifecycle_msgs/srv/detail/get_state__type_support.c.o  -Wl,-rpath,/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/recipe-sysroot-native/usr/lib:  /home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/recipe-sysroot-native/usr/lib/libservice_msgs__rosidl_generator_c.so  /home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/recipe-sysroot-native/usr/lib/libbuiltin_interfaces__rosidl_generator_c.so  /home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/recipe-sysroot/usr/lib/librosidl_runtime_c.so  /home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/recipe-sysroot/usr/lib/librcutils.so  -ldl && :
/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/recipe-sysroot-native/usr/bin/aarch64-oe-linux/../../libexec/aarch64-oe-linux/gcc/aarch64-oe-linux/12.3.0/ld: /home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/recipe-sysroot-native/usr/lib/libservice_msgs__rosidl_generator_c.so: error adding symbols: file in wrong format
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
WARNING: exit code 1 from a shell command.

My good feeling is, that it's trying to link the native library with target. I was thinking about the problem with service-msgs or rosidl. So I updated the recipes under rcl-interfaces to versions 2.0.2.-2 and rosidl to 4.6.0-2, but it didn't help.
The setup is use the meta-ros2-iron from mickledore branch (because all other layers have this revision) and build the ros components. But it it's not working... :(.
What's the real issue and how to fix it?
Thanks

ok, I identify the issue. When I looked into CMakeCache.txt there was a generated line:
//Path to a library.
_lib:FILEPATH=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/lifecycle-msgs/1.6.0-2-r0/recipe-sysroot-native/usr/lib/libservice_msgs__rosidl_typesupport_fastrtps_cpp.so

If we look deeper into problem, the path is pointing to recipe-sysroot-native/usr/lib/ because the target doesn't exist in recipe-sysroot/usr/lib/. Not sure what's the right way to fix the transition dependencies, while the recipes are generated. I see there a quick fix to add ROS_BUILD_DEPENDS += "service-msgs" into target recipes.

Hi,
This was fixed in the other branches by adding service-msgs as a target recipe so the link would choose it over service-msgs-native: https://github.com/ros/meta-ros/commit/4fa5442ff905cf371d717f868634d23714e8c28d
This commit is not available in Mickledore + Iron as that is not a supported combination: https://github.com/ros/meta-ros?tab=readme-ov-file#supported-combinations  (Unfortunately, Mickledore went end-of-life on November 2023).
I am providing "best effort" support for Mickledore + Humble, if that appeals to you.  I am also open to merging fixes to meta-ros2-iron in Mickledore if someone volunteers to maintain it as "best-effort" or "contrib".
Regards,
Rob

Ok, I see, thanks for the hints. Now I fixed the similar issues. But now I found an another one, but it's for rosbag2-storage-mcap component. Upgrading to 0.22.6-1 didn't help.
/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/recipe-sysroot-native/usr/bin/aarch64-oe-linux/aarch64-oe-linux-g++ -DROSBAG2_STORAGE_MCAP_BUILDING_DLL -DROSBAG2_STORAGE_MCAP_BUILDING_LIBRARY -DROSBAG2_STORAGE_MCAP_HAS_SET_READ_ORDER -DROSBAG2_STORAGE_MCAP_HAS_STORAGE_FILTER_TOPIC_REGEX -DROSBAG2_STORAGE_MCAP_HAS_STORAGE_OPTIONS -DROSBAG2_STORAGE_MCAP_HAS_UPDATE_METADATA -DROSBAG2_STORAGE_MCAP_HAS_YAML_HPP -DROSBAG2_STORAGE_MCAP_OVERRIDE_SEEK_METHOD -DROSBAG2_STORAGE_MCAP_WRITER_CREATES_DIRECTORY -Drosbag2_storage_mcap_EXPORTS -I/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/git/include -I/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/recipe-sysroot/usr/include/mcap_vendor -I/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/recipe-sysroot/usr/include/pluginlib -I/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/recipe-sysroot/usr/include/ament_index_cpp -I/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/recipe-sysroot/usr/include/class_loader -I/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/recipe-sysroot/usr/include/rcpputils -I/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/recipe-sysroot/usr/include/rcutils -I/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/recipe-sysroot/usr/include/rosbag2_storage -mcpu=cortex-a53 -march=armv8-a+crc+crypto -mbranch-protection=standard  --sysroot=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/recipe-sysroot  -O2 -pipe -g -feliminate-unused-debug-types -fmacro-prefix-map=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/git=/usr/src/debug/rosbag2-storage-mcap/0.22.6-1-r0  -fdebug-prefix-map=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/git=/usr/src/debug/rosbag2-storage-mcap/0.22.6-1-r0  -fmacro-prefix-map=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/build=/usr/src/debug/rosbag2-storage-mcap/0.22.6-1-r0  -fdebug-prefix-map=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/build=/usr/src/debug/rosbag2-storage-mcap/0.22.6-1-r0  -fdebug-prefix-map=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/recipe-sysroot=  -fmacro-prefix-map=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/recipe-sysroot=  -fdebug-prefix-map=/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/recipe-sysroot-native=  -fvisibility-inlines-hidden -DNDEBUG -fPIC -Wall -Wextra -Wpedantic -std=gnu++17 -MD -MT CMakeFiles/rosbag2_storage_mcap.dir/src/mcap_storage.cpp.o -MF CMakeFiles/rosbag2_storage_mcap.dir/src/mcap_storage.cpp.o.d -o CMakeFiles/rosbag2_storage_mcap.dir/src/mcap_storage.cpp.o -c /home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/git/src/mcap_storage.cpp
/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/git/src/mcap_storage.cpp:273:23: error: 'RecordOffset' is not a member of 'mcap'; did you mean 'EndOffset'?
  273 |   std::optional<mcap::RecordOffset> last_read_message_offset_;
      |                       ^~~~~~~~~~~~
      |                       EndOffset
/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/git/src/mcap_storage.cpp:273:35: error: template argument 1 is invalid
  273 |   std::optional<mcap::RecordOffset> last_read_message_offset_;
      |                                   ^
/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/git/src/mcap_storage.cpp:274:23: error: 'RecordOffset' is not a member of 'mcap'; did you mean 'EndOffset'?
  274 |   std::optional<mcap::RecordOffset> last_enqueued_message_offset_;
      |                       ^~~~~~~~~~~~
      |                       EndOffset
/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/git/src/mcap_storage.cpp:274:35: error: template argument 1 is invalid
  274 |   std::optional<mcap::RecordOffset> last_enqueued_message_offset_;
      |                                   ^
/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/git/src/mcap_storage.cpp: In member function 'bool rosbag2_storage_plugins::MCAPStorage::read_and_enqueue_message()':
/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/git/src/mcap_storage.cpp:482:47: error: 'const struct mcap::MessageView' has no member named 'messageOffset'
  482 |   last_enqueued_message_offset_ = messageView.messageOffset;
      |                                               ^~~~~~~~~~~~~
/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/git/src/mcap_storage.cpp: In member function 'bool rosbag2_storage_plugins::MCAPStorage::enqueued_message_is_already_read()':
/home/projects/build/tmp/work/cortexa53-crypto-oe-linux/rosbag2-storage-mcap/0.22.6-1-r0/git/src/mcap_storage.cpp:545:33: error: no match for 'operator==' (operand types are 'int' and 'const std::nullopt_t')
  545 |   if (last_read_message_offset_ == std::nullopt) {
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~ ^~ ~~~~~~~~~~~~
      |       |                                 |
      |       int                               const std::nullopt_t


Issues with Program Reproduction and Usage

Dear Author,
I am a student studying image processing. I have recently read your article, downloaded the associated code, and attempted to reproduce the results. I have a rather naive question. I was successful in removing noise from the airplane images in the sigma25 folder of the CBSD68 dataset. However, when I replaced the airplane images with my own noisy images, the denoising was unsuccessful. I used the same path and the same denoising process and method, but I could not achieve the same denoising results. I am unsure about the reason behind this. I sincerely hope you could provide an answer! Thank you!

Hello,
As stated in the paper, the probability for the Bernoulli sampling & dropout and number of iterations vary.
Hence, you should find an appropriate hyperparameter for your own dataset.
Thank you.

Thank you for your reply. I will further study the issue with the hyperparameters, and once again thank you for your paper!

Dear ediotr:
I confirm that this email can contact me and i am one of the co-authors of article of jmse-2664592.
Chao Jiang
best wishes
获取 Outlook for iOShttps://aka.ms/o0ukef

发件人: Jaekyun Ko @.>
发送时间: Tuesday, October 24, 2023 3:53:24 PM
收件人: JK-the-Ko/Self2SelfPlus @.>
抄送: AllenJHawk @.>; Author @.>
主题: Re: [JK-the-Ko/Self2SelfPlus] Issues with Program Reproduction and Usage (Issue #1)
Hello,
As stated in the paper, the probability for the Bernoulli sampling & dropout and number of iterations vary.
Hence, you should find an appropriate hyperparameter for your own dataset.
Thank you.
―
Reply to this email directly, view it on GitHubhttps://github.com/JK-the-Ko/Self2SelfPlus/issues/1#issuecomment-1776702430, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BAHYAZ2V2USOKFW3F7H7GJLYA5XXJAVCNFSM6AAAAAA6M6AXI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZWG4YDENBTGA.
You are receiving this because you authored the thread.Message ID: @.***>

I'm sorry, I sent the wrong email. Haha, it's embarrassing.🤣
获取 Outlook for iOShttps://aka.ms/o0ukef

发件人: 蒋 超 @.>
发送时间: Tuesday, October 24, 2023 6:32:03 PM
收件人: JK-the-Ko/Self2SelfPlus @.>; JK-the-Ko/Self2SelfPlus @.>
抄送: Author @.>
主题: Re: [JK-the-Ko/Self2SelfPlus] Issues with Program Reproduction and Usage (Issue #1)
Dear ediotr:
I confirm that this email can contact me and i am one of the co-authors of article of jmse-2664592.
Chao Jiang
best wishes
获取 Outlook for iOShttps://aka.ms/o0ukef

发件人: Jaekyun Ko @.>
发送时间: Tuesday, October 24, 2023 3:53:24 PM
收件人: JK-the-Ko/Self2SelfPlus @.>
抄送: AllenJHawk @.>; Author @.>
主题: Re: [JK-the-Ko/Self2SelfPlus] Issues with Program Reproduction and Usage (Issue #1)
Hello,
As stated in the paper, the probability for the Bernoulli sampling & dropout and number of iterations vary.
Hence, you should find an appropriate hyperparameter for your own dataset.
Thank you.
—
Reply to this email directly, view it on GitHubhttps://github.com/JK-the-Ko/Self2SelfPlus/issues/1#issuecomment-1776702430, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BAHYAZ2V2USOKFW3F7H7GJLYA5XXJAVCNFSM6AAAAAA6M6AXI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZWG4YDENBTGA.
You are receiving this because you authored the thread.Message ID: @.***>


[Bug] Unable to craft Anti-Plasmid

Describe the bug
Anti Plasmids cannot be attuned to a gene. When placed in a crafting table, there is no output available.
Expected behavior
Crafting a filled plasmid with an empty anti-plasmid should attune the anti-plasmid with the gene.
Screenshots
See linked issue below
Additional context
https://github.com/EnigmaticaModpacks/Enigmatica10/issues/283

Fixed

Thanks!


Deleting binding without related appinfo stored

Log still shows the following error:
OUT ERROR o.c.a.s.s.AutoSleepServiceInstanceBindingService(91) - Deleting a binding with no related application info. This should never happen.
As stated, "this should never happen". Investigate.

Other bug or same issue?:
 OUT ERROR o.c.a.s.AppStateChecker(55) - ApplicationInfo is null, this should never happen!


Wait Statistics report - hidden wait types

Is this:
Just place "x" to indicate selection (e.g. "[x]")

[x ] feature
[ ] bug:

Instance Details
Can we have a hyperlink in the report to a list of the waits that are described as 'benign' please?

Good point!
This will be added in the openquerystore.com website soon!

Wait details created at https://github.com/OpenQueryStore/OpenQueryStore/wiki/BenignWaits. rdl only needs link to be added and this is then complete

fixed with latest commit (should have used "close" in the commit to auto-close this issue)


Update test method comments

Proposed Changes
Fix some copy/pasted method comments
Related Issues
N/A

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.64%. Comparing base (a113023) to head (a95adc2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   99.64%   99.64%
=======================================
  Files           4        4
  Lines         280      280
  Branches       29       29
=======================================
  Hits          279      279
  Misses          1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


{Test} Fix live tests for appconfig, batchai, make some tests in container, security record_only

Description

appconfig: LiveScenarioTest has bugs with assertRaisesRegex, change it to ScenarioTest with @live_only().
batchai: stderr.txt has some logs and the contentLength is no longer 0.
container, security: some tests rely on existing resources and it's not easy to fix by creating them during the test, make them record_only to skip in live tests pipeline.
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Test


Fix: input bar hidding long answer in a conversation

fixes: https://github.com/dust-tt/tasks/issues/197

Closing this PR without merging.
The scope of this task is bigger than the eng-runner scope.


Fix AWS ELB teardown

Changes to the underlying module and the logic surrounding the results.

This looks good.
Steps I used to test:

Created a classic load balancer attached to my cloudera-deploy created VPC
Ran teardown with purge: True
Confirmed that ELB is discovered and that filter to find LB in VPC works correctly
Confirmed that ELB is successfully deleted
Confirmed that teardown completes without error


Ongoing?

Hi, nice initiative.
Is this work still preceding, or has the project been abandoned?

Hello @yonaskolb.
Currently I have little time to finish the conversion, but most of it is complete and needs testing. If you want to contribute, please welcome to!


Add help text and change prompt name

Hey, thanks for your contribution! 🙂
I see the point of the help text, but, to be honest, I'm not a fan of it showing all the time. What do you think about making it configurable via a cli parameter (like --show-help)?

That's fine for me. I will have a look into this as soon as I have time for this.

Yeah, no hurry! If you want to, I can also have a look some time 🙂

As an inspiration, you can look how rofimoji implements configuration.

Hey @DSIW, I just wanted to ask if you've made progress or need help?

I have just pushed a major update that should fix this problem. Please open a ticket if you're missing anything 🙂

Awesome! Thank you for taking care of it.


Rollover Wrapped Position

Adds a wrapped position which allows users to deposit, provide LP, and then have their funds rolled over into a new term by a governance process. The implementation has some subtleties so will need close review before merge into main.

Coverage decreased (-1.7%) to 92.716% when pulling 8614c2ed89aece3d5ffa3fb24abe13ac633ed91e on paul/feature/rolloverWP into 3e94eaa152841e96592e3332a8c91c2c2dfc33bb on main.


Updates swagger spec

Adds new field graphite_label_policy to v1/config/RollupRule

#12
#11  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pbotros and the rest of your teammates on  Graphite


extend rfc5102 434-491 element key

Expanded the list of supported Netflow element key according to the list https://www.iana.org/assignments/ipfix/ipfix.xhtml
This pr fix error i.e. - Netflow element key (463) not exist

Thanks!


Sbs 9 changes name to Viaplay

Describe your issue
Adjust https://github.com/iptv-org/epg/tree/master/sites/tvgids.nl to adapt to the name change

The configuration needs to be modified to something like this
 <channel site="tvgids.nl" lang="nl" xmltv_id="ViaplayTv.nl" site_id="viaplaytv">VIAPLAY TV</channel>

https://github.com/iptv-org/epg/pull/2376#issuecomment-2151110236


Add text and user defined classes/tags

I was wondering instead of having predefined classes and tags if it is possible to add user-defined classes/tags or text. For example, let's say there is an image of a cat, using a bounding box the user would select the left eye, add a class for eye a tag for color and add a description saying something like "This is the left eye of the cat".
Perhaps even have it where just text could be used.

Custom text, it's a good idea!

This is somewhat possible using the custom label entry thing #28, but I think building it in would be nice. We might be expanding to have a more complex data entry system allowed for the label dialog in the near future


Update snapshots for upstream changes

Description
Following upstream OUI changes, the snapshots are outdated, breaking the unit test CI. This PR updates all the snapshots with yarn test -u.
Issues Resolved
N/A
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Does this also need to be backported?


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report

Merging #695 (abf877c) into main (6b2eeec) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main     #695   +/-   ##
=======================================
  Coverage   95.69%   95.69%
=======================================
  Files           1        1
  Lines         395      395
  Branches       53       53
=======================================
  Hits          378      378
  Misses         17       17


rowclick for ajax grid [4.0.1]

How to bind row clicked event when using ajax?
I tried everything from the manual..

You should use DOM event delegation by binding it on a static parent element or re-initializing it after every reload.

Working well with static parent,
Thanks for help!


🍒 Cherry pick PR #8827 to staging 🍒

🍒 Cherry pick https://github.com/Expensify/App/pull/8827 to staging 🍒

This pull request has merge conflicts and can not be automatically merged. :disappointed:
Please manually resolve the conflicts, push your changes, and then request another reviewer to review and merge.
Important: There may be conflicts that GitHub is not able to detect, so please carefully review this pull request before approving.

Fixed the conflicts here if you can review @sketchydroide

🚀 Cherry-picked to staging by @sketchydroide in version: 1.1.57-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by @chiragsalian in version: 1.1.57-17 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


None of the responsive utilities work

None of the responsive utilities work.. might be a Bootstrap 4 issue and not a Core UI one though.
When I visited the Test Cases page, every case stayed green no matter how big or small I made my browser window.

I'm getting similar behaviour, although it only seem to be affecting hidden-*-up and hidden-*-down and not  hidden-*-only. some screenshots bellow.

The bulk of  .hidden- classes have been removed from Bootstrap v4 alphas in favor of display utilities.

Similar issues here too. User menu disappears in mobile view too.

@xidedix how so? They have a documentation page for them, here.

FIXED!
It looks like bootstrap and reactstrap aren't properly installed in the react version of this kit. I had to follow the reactstrap installation instructions for adding bootstrap, found here.
$ npm install --save<EMAIL_ADDRESS>$ npm install --save reactstrap<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
// index.js
import 'bootstrap/dist/css/bootstrap.css';

No luck fixing it :/ Any other steps I may have missed?

We use this version of bootstrap https://github.com/twbs/bootstrap, it's newer then alpha.6. In next version of bootstrap ( beta.1) responsive utilities will be removed.
Please download documentation to latest version of Bootstrap from github and check it https://github.com/twbs/bootstrap

Okay thank you very much!


in Mac build error

Mac OS
$ GOOS=windows GOARCH=amd64 go build -ldflags="-s -w " -trimpath -o main_windows_amd64.exe main.go
server/webserver.go:335:25: undefined: sqlite3.Error
server/webserver.go:339:24: undefined: sqlite3.ErrConstraint

but, build for Mac,is ok
go build main.go

When cross-compiling, Go requires that you explicitly enable cgo via CGO_ENABLED=1. In addition, you must set CC to a valid C cross-compiler.

@rittneje how set cc ,thanks

First you will need to install a C compiler that runs on macos but targets Windows. I've never done this, but mingw-w64 might work. https://formulae.brew.sh/formula/mingw-w64
Then set the C environment variable to the path to that C compiler when running go build.


Adding Node to an empty project does not save properly

[ ] Criteria 1

Criteria 1
Give:

The user has created a fresh empty project

When:

The user adds a node to the project

Then:

The node should be properly added instead of wiping the IR

No idea what's happening. When I tried to create a node without GDB the yaml was erased. When I stepped through with GDB everything operated as expected

Possibly an issue with '_' in project name. Project was erased again When I created a project named TEST_PROJ

That was exactly the problem. Adding and pushing a fix to the front end


Adding support for master non-registered Lint.jl

Glad to see somebody working on this that actually uses it and knows Julia! 🎉
Sent you an invite to the team within the organization for this repository, as I'm assuming @TeroFrondelius added you manually here 😉.


Feat(*): Add arm64 Support

This PR adds support for collecting the OS's architecture from process.arch to allow the action to fetch arm64 binaries when called for. Also lumped in some tests.
I'm very much not a NodeJS person, so feedback would be greatly appreciated.

When run (locally):
$ npm run test
<snip>
 PASS  ./index.test.js
  automatic version fetching
    ✓ does not fetch when a version is provided (5 ms)
    ✓ fetches the latest version when no version is provided (27 ms)
    ✓ fails when there are no releases and no specific version is provided (12 ms)
  version parsing
    ✓ throws when an invalid version is provided (18 ms)
    ✓ accepts a valid semver input (1.7.0)
    ✓ accepts a valid semver input (1.7) (1 ms)
    ✓ accepts a valid semver input (1.6) (1 ms)
    ✓ accepts a valid semver input (1.6.4) (1 ms)
    ✓ accepts a valid semver input (1.8.0-beta2)
  install
    ✓ does not download if the file is in the cache (1 ms)
    ✓ downloads if it is not in the cache (1 ms)
    ✓ downloads correctly for default (1 ms)
    ✓ downloads correctly for linux (1 ms)
    ✓ downloads correctly for win32
    ✓ downloads correctly for darwin (1 ms)
    ✓ downloads correctly for x64
    ✓ downloads correctly for arm64
  wrapper
    ✓ does not apply the wrapper by default
    ✓ applies the wrapper when enabled (1 ms)

Test Suites: 1 passed, 1 total
Tests:       19 passed, 19 total
Snapshots:   0 total
Time:        0.943 s, estimated 1 s
Ran all test suites.

GitHub is having issues I think. The following patch needs applying before merge:
From 0d704cff4a4219d7289a40dae63b253c72fabecc Mon Sep 17 00:00:00 2001
From: Michael Heap<EMAIL_ADDRESS>Date: Wed, 7 Jun 2023 17:25:29 +0100
Subject: [PATCH] Explicitly set arch in all tests

---
 index.test.js | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/index.test.js b/index.test.js
index 223e197..5ea55e0 100644
--- a/index.test.js
+++ b/index.test.js
@@ -10,6 +10,7 @@ jest.mock("actions-output-wrapper");
 let createWrapper = require("actions-output-wrapper");

 let originalPlatform;
+let originalArch;
 let restore;
 let restoreTest;

@@ -22,6 +23,7 @@ beforeEach(() => {
   jest.spyOn(console, "log").mockImplementation();
   createWrapper.mockClear();
   originalPlatform = process.platform;
+  originalArch = process.arch;
 });

 afterEach(() => {
@@ -37,6 +39,7 @@ afterEach(() => {
   }
   nock.cleanAll();
   setPlatform(originalPlatform);
+  setArch(originalArch);
 });

 describe("automatic version fetching", () => {
@@ -143,6 +146,7 @@ describe("install", () => {
     });

     setPlatform("linux");
+    setArch("amd64");
     mockToolIsInCache(false);
     mockTcDownload();
     mockExtraction();
@@ -172,6 +176,7 @@ describe("install", () => {
     });

     setPlatform(platform);
+    setArch("amd64");
     mockToolIsInCache(false);
     mockTcDownload();
     mockExtraction();
--
2.39.0


az webapp config connection-string set: not enough values to unpack (expected 2, got 1)

Describe the bug
Running the command "az webapp config connection-string set" results in an error.
Related command
az webapp config connection-string set --connection-string-type SQLServer --name MyServer --resource-group MyResourceGroup --subscription MySubScription --settings ConnectionString="Data Source=tcp:MyServer.database.windows.net,1433;Initial Catalog=MyDatabase;User Id=MyID;Password=MyPassword;"
Errors
The command failed with an unexpected error. Here is the traceback:
not enough values to unpack (expected 2, got 1)
Traceback (most recent call last):
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/appservice/custom.py", line 2021, in build_app_settings_input
File "json_init.py", line 346, in loads
File "json\decoder.py", line 337, in decode
File "json\decoder.py", line 355, in raw_decode
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/cli.py", line 233, in invoke
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 664, in execute
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 731, in _run_jobs_serially
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 701, in _run_job
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 334, in call
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/command_operation.py", line 121, in handler
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/appservice/custom.py", line 2048, in update_connection_strings
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/appservice/custom.py", line 2036, in _build_app_settings_input
ValueError: not enough values to unpack (expected 2, got 1)
Issue script & Debug output
cli.knack.cli: Command arguments: ['webapp', 'config', 'connection-string', 'set', '--connection-string-type', 'SQLServer', '--name', 'MyAppService', '--resource-group', 'MyResourceGroup', '--subscription', 'MySubscriptionID', '--settings', 'ConnectionString', '=Data Source=tcp:MySQLServer,1433;Initial Catalog=MyDatabase;User Id=MyID;Password=MyPassword;', '--debug']
cli.knack.cli: init debug log:
Enable color in terminal.
cli.knack.cli: Event: Cli.PreExecute []
cli.knack.cli: Event: CommandParser.OnGlobalArgumentsCreate [<function CLILogging.on_global_arguments at 0x000001E352F8B920>, <function OutputProducer.on_global_arguments at 0x000001E3531160C0>, <function CLIQuery.on_global_arguments at 0x000001E353143C40>]
cli.knack.cli: Event: CommandInvoker.OnPreCommandTableCreate []
cli.azure.cli.core: Modules found from index for 'webapp': ['azure.cli.command_modules.appservice', 'azure.cli.command_modules.serviceconnector']
cli.azure.cli.core: Loading command modules:
cli.azure.cli.core: Name                  Load Time    Groups  Commands
cli.azure.cli.core: appservice                0.391        79       270
cli.azure.cli.core: serviceconnector          0.075        16       244
cli.azure.cli.core: Total (2)                 0.466        95       514
cli.azure.cli.core: These extensions are not installed and will be skipped: ['azext_ai_examples', 'azext_next']
cli.azure.cli.core: Loading extensions:
cli.azure.cli.core: Name                  Load Time    Groups  Commands  Directory
cli.azure.cli.core: Total (0)                 0.000         0         0
cli.azure.cli.core: Loaded 93 groups, 514 commands.
cli.azure.cli.core: Found a match in the command table.
cli.azure.cli.core: Raw command  : webapp config connection-string set
cli.azure.cli.core: Command table: webapp config connection-string set
cli.knack.cli: Event: CommandInvoker.OnPreCommandTableTruncate [<function AzCliLogging.init_command_file_logging at 0x000001E355FFEF20>]
cli.azure.cli.core.azlogging: metadata file logging enabled - writing logs to 'C:\Users\draymond.azure\commands\2024-04-16.15-32-38.webapp_config_connection-string_set.23440.log'.
az_command_data_logger: command args: webapp config connection-string set --connection-string-type {} --name {} --resource-group {} --subscription {} --settings {} {} --debug
cli.knack.cli: Event: CommandInvoker.OnPreArgumentLoad [<function register_global_subscription_argument..add_subscription_parameter at 0x000001E356055440>]
cli.knack.cli: Event: CommandInvoker.OnPostArgumentLoad []
cli.knack.cli: Event: CommandInvoker.OnPostCommandTableCreate [<function register_ids_argument..add_ids_arguments at 0x000001E3560554E0>, <function register_cache_arguments..add_cache_arguments at 0x000001E356055620>]
cli.knack.cli: Event: CommandInvoker.OnCommandTableLoaded []
cli.knack.cli: Event: CommandInvoker.OnPreParseArgs []
cli.knack.cli: Event: CommandInvoker.OnPostParseArgs [<function OutputProducer.handle_output_argument at 0x000001E353116160>, <function CLIQuery.handle_query_parameter at 0x000001E353143CE0>, <function register_ids_argument..parse_ids_arguments at 0x000001E356055580>]
cli.azure.cli.core.azclierror: Traceback (most recent call last):
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/appservice/custom.py", line 2021, in build_app_settings_input
File "json_init.py", line 346, in loads
File "json\decoder.py", line 337, in decode
File "json\decoder.py", line 355, in raw_decode
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/cli.py", line 233, in invoke
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 664, in execute
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 731, in _run_jobs_serially
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 701, in _run_job
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 334, in call
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/command_operation.py", line 121, in handler
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/appservice/custom.py", line 2048, in update_connection_strings
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/appservice/custom.py", line 2036, in _build_app_settings_input
ValueError: not enough values to unpack (expected 2, got 1)
cli.azure.cli.core.azclierror: The command failed with an unexpected error. Here is the traceback:
az_command_data_logger: The command failed with an unexpected error. Here is the traceback:
cli.azure.cli.core.azclierror: not enough values to unpack (expected 2, got 1)
Traceback (most recent call last):
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/appservice/custom.py", line 2021, in build_app_settings_input
File "json_init.py", line 346, in loads
File "json\decoder.py", line 337, in decode
File "json\decoder.py", line 355, in raw_decode
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/cli.py", line 233, in invoke
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 664, in execute
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 731, in _run_jobs_serially
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 701, in _run_job
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 334, in call
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/command_operation.py", line 121, in handler
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/appservice/custom.py", line 2048, in update_connection_strings
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/appservice/custom.py", line 2036, in _build_app_settings_input
ValueError: not enough values to unpack (expected 2, got 1)
az_command_data_logger: not enough values to unpack (expected 2, got 1)
Traceback (most recent call last):
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/appservice/custom.py", line 2021, in build_app_settings_input
File "json_init.py", line 346, in loads
File "json\decoder.py", line 337, in decode
File "json\decoder.py", line 355, in raw_decode
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/cli.py", line 233, in invoke
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 664, in execute
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 731, in _run_jobs_serially
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 701, in _run_job
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 334, in call
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/command_operation.py", line 121, in handler
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/appservice/custom.py", line 2048, in update_connection_strings
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/appservice/custom.py", line 2036, in build_app_settings_input
ValueError: not enough values to unpack (expected 2, got 1)
To check existing issues, please visit: https://github.com/Azure/azure-cli/issues
cli.knack.cli: Event: Cli.PostExecute [<function AzCliLogging.deinit_cmd_metadata_logging at 0x000001E355FFF1A0>]
az_command_data_logger: exit code: 1
cli.main: Command ran in 1.692 seconds (init: 0.610, invoke: 1.082)
telemetry.main: Begin splitting cli events and extra events, total events: 1
telemetry.client: Accumulated 0 events. Flush the clients.
telemetry.main: Finish splitting cli events and extra events, cli events: 1
telemetry.save: Save telemetry record of length 7628 in cache
telemetry.main: Begin creating telemetry upload process.
telemetry.process: Creating upload process: "C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe C:\Program Files\Microsoft SDKs\Azure\CLI2\Lib\site-packages\azure\cli\telemetry_init.pyc C:\Users\draymond.azure"
telemetry.process: Return from creating process
telemetry.main: Finish creating telemetry upload process.
Expected behavior
The connection string would be set.
Environment Summary
azure-cli                         2.59.0
core                              2.59.0
telemetry                          1.1.0
Extensions:
application-insights               1.2.1
azure-devops                       1.0.0
Dependencies:
msal                              1.27.0
azure-mgmt-resource             23.1.0b2
Python location 'C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe'
Extensions directory 'C:\Users\draymond.azure\cliextensions'
Python (Windows) 3.11.8 (tags/v3.11.8:db85d51, Feb  6 2024, 22:03:32) [MSC v.1937 64 bit (AMD64)]
Legal docs and information: aka.ms/AzureCliLegal
Your CLI is up-to-date.
Additional context
None

Thank you for opening this issue, we will look into it.

I'm unable to repro - I copied your input into CloudShell and was able to set the connection strings.
Please ensure the settings parameter is formatted correctly and escape characters are included where needed based on your shell type.

I found that I could not use an object to create the string and had to use a string replacement instead. This is showing to not be an issue with the connection-string set function.
$newConnectionString = $ConnectionStringName + '=''Data Source=tcp:' + $DataSource + ',1433;Initial Catalog=' + $SQLDatabase + ';User Id=' + $UserID + ';Password=' + $Password + ';'''
az webapp config connection-string set --connection-string-type SQLServer --name $AppServiceName --resource-group $AppServiceResourceGroupName --subscription $AppServiceSubscriptionID --settings $newConnectionString


Autodelete code

What part of the code do i need to copy so I can copy the autodelete code to my bot? And what program can i use to code it? Thankyou

You probably won't end up with a working bot if you just "copy the autodelete code" to your bot.
With that said, here's a great tutorial on how to start with golang (the language the bot is made in): https://www.youtube.com/watch?v=YS4e4q9oBaU. Note that you will need a computer.


RTX_EXPERIMENTAL=0

this should disable experimental mode even if it is enabled in the global config:
$ rtx settings set experimental true
$ RTX_EXPERIMENTAL=0 rtx settings get experimental
false

this is unfortunately going to be a pain to fix. And I very much want to refactor the settings generally since that is probably now the oldest and worst part of the codebase with a ton of yak shaving involved in adding new settings.

Hello! I'm checking codes about this Issue.
I think the orders of configuration values should be changed.
Currently, the first values are loaded from env var (fallbacked by default values) and that will be overlayed by values in the configuration file.
However, I think env vars should be loaded lastly and overlay values from other sources. (means putting env vars before others)
(Env || Default) --(overlay)--> values in configuration
↓
Default --(overlay)--> values in configuration --(overlay)--> env vars

@jdxcode
Hello! I'm checking codes about this Issue.
I think the orders of configuration values should be changed.
Currently, the first values are loaded from env var (fallbacked by default values) and that will be overlayed by values in the configuration file.
However, I think env vars should be loaded lastly and overlay values from other sources. (means putting env vars before others)
(Env || Default) --(overlay)--> values in configuration
↓
Default --(overlay)--> values in configuration --(overlay)--> env vars
If that way is not bad, Could I pick this up?

yep, agreed, that sounds like the right approach. I will warn you though this may be a tricky issue since that code is truly awful.

I think it's split across rtx_toml.rs, env.rs, and settings.rs

Thank you for the confirmation! I will join the rtx discord channel and chat you when I'm confusing.
When I finish changing codes, I inform you to request review 🙏

one thing I was having a chat with @ilovesegfault about was that it would be nice to link at least some of the arguments (not this one) to the CLI flags. For example rtx --log-level=info. That feels like a hard problem though. It's related to this though because if we're refactoring the (currently horrific) settings logic it would be good to have CLI flags in the back of our mind at least.

one thing I was having a chat with @lovesegfault about was that it would be nice to link at least some of the arguments (not this one) to the CLI flags. For example rtx --log-level=info. That feels like a hard problem though. It's related to this though because if we're refactoring the (currently horrific) settings logic it would be good to have CLI flags in the back of our mind at least.

I used figment on another project which works pretty well at solving this problem of hooking up config files, env vars, and CLI flags.
I don't want to bring on a dependency for rtx for this particular problem, but I think figment has some patterns that might be useful to think about here.


Remove security key from serialized array

As title. It's related to issue #25.

@Techworker, I've already removed the seed serialization from dumped trace :+1:.
Please check that.


"Nothing to Merge" issue after a conflicting git rebase

It seems like I am getting bitten by a Nothing to Merge issue.
 to unstage)

	modified:   [app/controllers/users_controller.rb]
	modified:   app/views/users/index.html.erb

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   config/routes.rb

And as a matter of fact, I can see the following in my config/routes.rb:
<<<<<<< HEAD
  [Their lines]
=======
  [My lines]
>>>>>>> [Commit redacted]

However, when I run the detection, I get:
Nothing to Merge
No conflicts here!

Note that gitwas properly installed in /usr/local/bin/git.

merge-conflicts uses a file's status in the git index to determine whether or not conflicts exist, so this line in your status output is a hint about the problem:
rebase in progress; onto [commit redacted]
You are currently rebasing branch [branch redacted] on [commit redacted].
  (all conflicts fixed: run "git rebase --continue")

Did you run git add config/routes.rb before attempting to detect conflicts? If you did, you told git (and therefore this package) that you've already dealt with any conflicts in that file, so there's nothing more to resolve!
I believe you can restore the "unresolved" bit in the index by running:
git update-index --unresolve config/routes.rb

Hi @smashwilson,
Nop, the git status above is the first thing I did after the git rebase that showed us the conflict. No git add. I had to manually pursue anyway so I can't run any more tests, but I'll keep this issue open to reproduce it next time I have a conflict, which should be soon enough.

Weird! Yeah, ping me here if and when you reproduce.
If you also happen to see this on a repository that's public, it would also be helpful to have the URL of the repository and the SHAs of the commits that you're rebasing from and to.

I am also experiencing this bug.
The merge conflict format is the same:
<<<<<<< HEAD
  [Their lines]
=======
  [My lines]
>>>>>>> [Commit redacted]

@Glavin001 Hmm. Can you share:

The output of git status?
The repository URL and current SHAs of the branches you're trying to merge, if the repository is public?

For sure.

➜  api git:(glavin) git status
On branch glavin
Your branch is ahead of 'origin/glavin' by 1 commit.
  (use "git push" to publish your local commits)
nothing to commit, working directory clean
➜  api git:(glavin) git pull origin matt
From github.com:Skilltapper/api
 * branch            matt       -> FETCH_HEAD
Auto-merging config/routes.js
CONFLICT (content): Merge conflict in config/routes.js
Auto-merging config/policies.js
CONFLICT (content): Merge conflict in config/policies.js
Auto-merging api/models/User.js
Auto-merging api/controllers/UserController.js
CONFLICT (content): Merge conflict in api/controllers/UserController.js
Automatic merge failed; fix conflicts and then commit the result.
➜  api git:(glavin) ✗ git status
On branch glavin
Your branch is ahead of 'origin/glavin' by 1 commit.
  (use "git push" to publish your local commits)
You have unmerged paths.
  (fix conflicts and run "git commit")

Changes to be committed:

	modified:   api/models/Recommendation.js
	modified:   api/models/User.js
	modified:   api/services/JobQueueService.js

Unmerged paths:
  (use "git add <file>..." to mark resolution)

	both modified:   api/controllers/UserController.js
	both modified:   config/policies.js
	both modified:   config/routes.js

No, the repository is not public.

Let me know if there's anything else I can help with. I have since resolved the merge conflicts manually, however.

@Glavin001 Odd, that one should have been detected as conflicting. You can tell by these lines in your status output:
You have unmerged paths.
  (fix conflicts and run "git commit")

Notice how the original reporter's status, instead, says (all conflicts fixed: run "git rebase --continue"), which indicates that git doesn't think there are any conflicts to detect, which is what I'm using as a source of truth. If you want to verify the exact output that merge-conflicts is interpreting, you can run git status --porcelain instead; the UU lines are the ones that it interprets as conflicted files.
Another thing I thought of to check: Is the root of the git repository (namely, the .git directory) at the root of the project in Atom? Otherwise, Atom currently doesn't detect the project as having a git repository at all (see #129).

I keep seeing this inconsistently, BTW. Unfortunately, it's most of the time on private repos and at times when "dammit I need to commit/rebase/else these ASAP!" so I didn't take the time to build a nice report yet. I am keeping that issue in mind whenever I can though.

I am seeing this as well. Happens a lot during merging.. Usually what helps is: to restart atom editor completely.


root-level Makefile -- do we need?

What does the root level Makefile do for us? I find that I edit it frequently to keep it from introducing errors to my build. Is it necessary? I get that it allows both the release and the debug builds to coexist, but I'm not sure why that's an advantage.

Tom, what is causing you errors for building?  The Makefile makes it easy to configure CMake, but not necessary for using CMake.  Also, it is used often for linux build (i.e. make opt -j8, etc...)

I use a Mac, but I don't use Xcode on it, just the command-line tools. So the Makefile wouldn't build without Xcode, so I had to disable that. And then I was trying to build across multiple directories, but the dependencies didn't work with the Makefile in the way. So I deleted the Makefile and everything is happier now.
The Makefile provides some useful functionality, but you're only using it as a script that accepts arguments.  There are no dependencies recorded in it, which was the whole point behind Makefiles. Why not just write a little shell script called build.sh or something and get out of cmake's way?  Let cmake use the "Makefile" name.

Good idea, I can look into that.  Just out of curiosity, what do you mean by building across multiple directories?  Just want to understand the problem better.  I don't understand why there would be a cmake conflict.

I am also not sure if we gain much from the makefile as it seems to duplicate functionality from cmake. The biggest advantage i see is that it unifies where people put their build (but i am not sure if we have to restrict them). Apart from that i do not see much advantage, but even more disadvantages, e.g. cmake is an easy way to see what options are available and to allow different IDEs. This might be important when different plugins are integrated and should be selectable. (And as you generate with cmake makefiles on Linux you can still use -j8 etc)

I removed the Makefile, so now we should build everything through CMake.  Here are the directions:

Create build directory:

mkdir build

Linux / Makefile

cd build
cmake ..
make

Mac / XCode

cd build
cmake .. -G xcode
# Build with XCode

Windows

# Open up CMake GUI and configure
# Build with Visual Studio

A script of some sort might be a good way of documenting these steps if nothing else.  The Makefile was probably motivated by me through my training from David Laidlaw, following his mantra that you should be able to go into any directory, type "make all", and have it work.  This mantra predates a system like cmake though, so it is fine with me to revisit that.
Is there any way to write a script like "build.sh" but that would work on linux, OSX, and Windows?  Or, is it necessary to have at least a build.sh and build.bat?
I think we've committed at this point to having cmake as a dependency, but would be good if we do not have to add "make" or "sh" as dependencies on windows unless they already come packaged with cmake.  We normally install all of these on our computers anyway, so it doesn't matter too much for our lab, but it might be important to others.

I think this is resolved now with instructions in README.


How long does it take to release the docs?

Empty DataFrame
Columns: [epi, t, wall_t, opt_step, frame, fps, total_reward, avg_return, avg_len, avg_success, loss, lr, explore_var, entropy_coef, entropy, grad_norm]
Index: []
Process Process-2:
Traceback (most recent call last):
File "/home/s50005224/miniconda3/lib/python3.7/multiprocessing/process.py", line 297, in _bootstrap
self.run()
File "/home/s50005224/miniconda3/lib/python3.7/multiprocessing/process.py", line 99, in run
self._target(*self._args, **self._kwargs)
File "/home/s50005224/ConvLab-master/convlab/experiment/control.py", line 32, in mp_run_session
metrics = session.run()
File "/home/s50005224/ConvLab-master/convlab/experiment/control.py", line 146, in run
metrics = analysis.analyze_session(self.spec, self.agent.body.eval_df, 'eval')
File "/home/s50005224/ConvLab-master/convlab/experiment/analysis.py", line 175, in analyze_session
assert len(session_df) > 1, f'Need more than 1 datapoint to calculate metrics'
AssertionError: Need more than 1 datapoint to calculate metrics
when I run python run.py demo.json sequicity train, it throws the above error.
My spec setting:
"sequicity": {
"agent": [{
"name": "DialogAgent",
"algorithm": {
"name": "ExternalPolicy",
"e2e": {
"name": "Sequicity",
"model_file": "https://convlab.blob.core.windows.net/models/Sequicity.zip"
},
"action_pdtype": "Argmax",
"action_policy": "default"
},
"memory": {
"name": "Replay",
"max_size": 1
}
}],
"env": [{
"name": "multiwoz",
"user_policy": {
"name": "UserPolicyAgendaMultiWoz"
},
"sys_policy": {
"name": "RuleBasedMultiwozBot"
},
"nlu": {
"name": "OneNetLU",
"model_file": "https://convlab.blob.core.windows.net/models/onenet.tar.gz"
},
"nlg": {
"name": "MultiwozTemplateNLG",
"is_user": true
},
"evaluator": {
"name": "MultiWozEvaluator"
},
"max_t": 40,
"max_frame": 1000
}],
"body": {
"product": "outer",
"num": 2
},
"meta": {
"distributed": false,
"eval_frequency": 1000,
"num_eval": 100,
"max_tick_unit": "total_t",
"max_trial": 2,
"max_session": 2,
"resources": {
"num_cpus": 0,
"num_gpus": 1
}
}
},

@qazwsx74269 Sorry for the inconvenience. We are working hard on the docs. Please be patient waiting.
As mentioned in the README, ConvLab can only train the policy component by interacting with a user simulator currently. For other components like Sequicity, ConvLab supports offline supervise learning by  using the local training script. Please refer to Sequicity directory for details.


All output files should use the name of the cproject.yml file as base name.

This is the expected output for a Hello project
Hello.axf
Hello.axf.map
Hello.bin
Hello.hex
Hello.Debug+AVH.clog    // log file with current build/target-type

When a build process starts, the build tool should check if there is a log file with the current build/target-type.   If this does not exist, the build output artifacts cannot be reused and to ensure a proper rebuild, the build tool could simply delete all files with the name <project-name>.*, in the example above Hello.*.  This would ensure that a change of build/target-type in a build context manager would remove inconsistent artifacts.

The project name as default output name has been implemented in the PR https://github.com/Open-CMSIS-Pack/devtools/pull/836.
The handling of rebuilding was not implemented. Conceptually this should be a CMake task, I would recommend to avoid overwriting build artifacts.

Great this is all we need for now.  Once the tool is available, I suggest to try this:
https://github.com/Open-CMSIS-Pack/devtools/issues/826#issuecomment-1508586239

see: CMSIS-Toolbox 1.6.0

Fundamental problem is fixed in 1.6.0, I still suggest to implement #855


Allow to enable git signature verification in Helm chart

Labeled as blocked to ease the patch release of the chart next week (planned 1.12.3 release will not include the feature).


Question: timer persistence across suspend?

Hi there, first of all thanks for making this awesome app! I use it often.
I've noticed that sometimes it seems like the timer has issues persisting across suspensions (e.g. set timer for 10 minutes, suspend for 5, and have 5 left when the computer wakes). I haven't been able to reproduce it, but just curious if this app is expected to work in that case or not.

Actually, just confirmed there are some strange issues -- sometimes it works, sometimes it doesn't.


displayed user data

Related Issue

Fixes #209  .

Proposed Changes

displayed user data by fetching data from firestore

Checklist

[x] Tested
[x] No Conflicts
[x] Change In Code
[x] Follows linting rules

Screenshots

ALso, you can try Provider to store the user details in the model. SO we don't have to call it from one place to another

Okay i'll fix those changes @himanshusharma89

Okay i'll fix those changes @himanshusharma89

Pull the lastest code

done

Okay i'll do it @himanshusharma89

done @himanshusharma89


Question: keyboard events

I just found this library, it looks cool and easy to use, well done!
As a fun project, I've set myself the challenge of cloning Google Sheets using Svelte.
I realised that the enter sheet is actually built with canvas, hence how I found svelte-canvas.
Would svelte-canvas cut the mustard in my endeavour or would you recommend something like Konva?
I see that you handle mouse and touch events, but what about keyboard events?
When editing a formula, it is possible in google sheets to navigate the sheet using the keyboard arrows.
Submitting cell content with "Enter" or "Tab"
toggle a cell edit on "Enter"
etc...
I new to canvas so not sure what the simplest and/or technically possible solution is.
By the looks of it I might have to handle these outside the canvas context but it's still quite unclear to me at this time.

svelte-canvas doesn't support keyboard events on the Canvas or Layer components, though neither does Konva. I do think your best bet would be to handle it at the document level, and keep track of the cell values and other state in a parent component. Here's an example of what that could look like:
<script>
  // let's say the value of each cell is stored in a Map with keys [x, y]
  const cells = new Map()
  cells.set([0, 0], '')

  let active;
</script>

<Canvas>
  {#each cells as [[x, y], value]}
    <Cell {x} {y} {value} on:click={() => (active = [x, y])} />
  {/each}
</Canvas>

<svelte:document
  on:keydown={(e) => {
    // Enter increments active cell row by 1
    if (e.key === 'Enter') active[0]++;

    // Tab increments active cell col by 1
    else if (e.key === 'Tab') active[1]++;

    // Otherwise, add the key to the cell's value
    else cells.set(active, cells.get(active) + e.key)
  }}
/>

Building a spreadsheet is probably pretty challenging and I can't promise this is the best direction, but hope it's helpful!


Download

I keep getting an error reading:
fatal: could not create work tree dir 'MusicBot': permission denied

To fix this, either run Git Bash with administrator privileges or run it in a place that doesn't require them.
You should open Git Bash by right-clicking the folder you want the bot to go in and choosing 'Git Bash Here'
If the option doesn't exist, you installed Git Bash wrong.


Single field for other bc types

Second (and final) part of https://github.com/ONSAS/ONSAS.jl/pull/329

Codecov Report

Merging #331 (16442c1) into main (233fd8f) will decrease coverage by 0.24%.
The diff coverage is 93.75%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
- Coverage   79.25%   79.02%   -0.24%
==========================================
  Files          41       42       +1
  Lines        1485     1478       -7
==========================================
- Hits         1177     1168       -9
- Misses        308      310       +2

Impacted Files
Coverage Δ

.../BoundaryConditions/DirichletBoundaryConditions.jl
0.00% <0.00%> (ø)

...c/BoundaryConditions/FixedDofBoundaryConditions.jl
100.00% <100.00%> (ø)

...BoundaryConditions/GlobalLoadBoundaryConditions.jl
89.65% <100.00%> (-0.97%)
:arrow_down:

.../BoundaryConditions/LocalLoadBoundaryConditions.jl
100.00% <100.00%> (+6.25%)
:arrow_up:

... and 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


#WIP remove old postgres and add new docker posgres/liquibase #trivial

This works on my machine (famous words have been uttered throughout the years) @nyarly when you get a chance, can you?

Stop your Postgres instance
Pull this branch
Run make test-unit

And see what you think.

          1 Warning

:warning:
PR is classed as Work in Progress

  Generated by :no_entry_sign: Danger

@samsalisbury Cool, add a change to makefile


No build for latest tagged release from GitHub in many hours

I maintain dimgx. RTD webhooks are enabled on the repository. At Wed May 20 14:17:51 2015 -0700, I tagged and pushed the 0.2.0 release. So far (about 7 hours later as of this filing after over 24 hours), neither an updated stable nor the v0.2.0 tag shows up as available to RTD:
https://readthedocs.org/builds/dimgx/
https://readthedocs.org/dashboard/dimgx/versions/
Possibly related to #1017?

did you try rebuilding the project?

I believe there was a bug in our tag updated code that is now fixed. I rebuilt your project and its working properly again. Sorry about that!

I had tried rebuilding in the past, but not this particular occasion. It didn't seem to help when I did it. It looks like your code change triggered a rebuild on the new tag. Thank you! :bow:


Page Link To Azure Machine Learning functions in Stream Analytics Doesn't Work

The provided link https://blogs.technet.microsoft.com/machinelearning/2015/12/10/azure-ml-now-available-as-a-function-in-azure-stream-analytics/ doesn't works please update this.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b7334179-7aa1-55af-0fc6-68cf8f12fbad
Version Independent ID: b9b35a33-9e0a-f47a-7f3f-b76ddd6aed28
Content: Scale Machine Learning functions in Azure Stream Analytics
Content Source: articles/stream-analytics/stream-analytics-scale-with-machine-learning-functions.md
Service: stream-analytics
GitHub Login: @JSeb225
Microsoft Alias: jeanb

Hi @abhinayabhi. Thanks for reporting this.  I just submitted a PR to remove this outdated link.

Fixed by https://github.com/MicrosoftDocs/azure-docs-pr/pull/72372
#please-close


Update portfolio website

-Made portfolio website to be desktop version
-Updated content and styling to fit the desktop version.
-Updated images and classes for visibility in desktop version

Kindly join this meeting if you are available.


Sidebar width not memorized

Does this issue occur when all extensions are disabled?: Yes/No

Version:
Version: 1.64.0-insider (Universal)
Commit: f0054e049cd286ff317c738efe0fd8810b48ae98
Date: 2022-01-05T05:14:16.471Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 21.2.0

Steps to Reproduce:

drag the sidebar width
cmd + q to quit vscode
open vscode, the width of vscode will not be the same when it closed

Looks like this got fixed by @sbatten on #140175
/duplicate


diverse questions

Checklist

[X] I'm asking a question and not reporting a bug/feature request
[X] I've looked through the README
[X] I've read the guidelines for opening an issue
[X] I've searched the bugtracker for similar questions including closed ones

Question
Hi to all, I’m @khk58,
On downloading youtube-playlists, I get lots of the following messages:

Private video. Sign in if you've been granted access to this video

Video unavailable. The uploader has not made this video available in your country

Video unavailable. This video contains content from 'xxx', who has blocked it in your country on copyright grounds,
where 'xxx' is one of the following
   A+E Networks
   AdRevEnt_managed
   ARD
   Constantin Film
   DEFA-Stiftung
   E! Entertainment Television
   LDS
   Muyap
   rbb media GmbH
   RTL 2 Fernsehen GmbH & Co. KG
   Satel Film GmbH
   Seven.One
   SME
   Studio Hamburg
   Studio71_1_1
   Studio71_2_4
   Warner Bros. Entertainment
   WMG
   ZDFE
   ZDFE.drama

What can I do?
Kind regards,
Kurt
Verbose log
No response

Private video. Sign in if you've been granted access to this video
If you can play the video in your browser while logged in, use the --cookies or --cookies-from-browser option.

Video unavailable. The uploader has not made this video available in your country
Video unavailable. This video contains content from 'xxx', who has blocked it in your country on copyright grounds,
where 'xxx' is one of the following   A+E Networks
   AdRevEnt_managed
   ARD
   Constantin Film
   DEFA-Stiftung
   E! Entertainment Television
   LDS
   Muyap
   rbb media GmbH
   RTL 2 Fernsehen GmbH & Co. KG
   Satel Film GmbH
   Seven.One
   SME
   Studio Hamburg
   Studio71_1_1
   Studio71_2_4
   Warner Bros. Entertainment
   WMG
   ZDFE
   ZDFE.drama

If you get the same error in your browser, there's nothing yt-dlp can do about it. You can try using a proxy or VPN. Though this sounds a lot like you're trying to download pirated content, which we will not help with.


[Widget-Hub] Can't update the images for my widget

When I click on edit my widget I get the overview with name, url of script and so on.
Under "Preview Images" I want to change the url to the pictures.
If I save it with new url, leave this page and click on edit again,  it shows me the old image url.

Hi @wickenico thanks for reporting this bug. I will have a look on it. I assume that this is related to the NoSQL Database.

@wickenico bug is fixed

Thanks! Now my changed images were not displayed on the widget page (Crypto Ticker). Does it just take some time for updating in background?

did you use the same name? there is some caching in place.

I found the issue. You are using a wrong URL:
https://github.com/wickenico/crypto-ticker-widget.js/blob/main/img/cryptoTickerWidget.jpg
Is not the JPG himself. It is a GitHub Page with the image.
You have to use the raw image url. If you click on the download button on the right, you will get the needed URL:
https://raw.githubusercontent.com/wickenico/crypto-ticker-widget.js/main/img/cryptoTickerWidget.jpg
this mistake has already happened to some and I corrected the URL at the review.
Maybe I'll add a warning if the domain is github.com and not raw.github.com.

I found the issue. You are using a wrong URL:
https://github.com/wickenico/crypto-ticker-widget.js/blob/main/img/cryptoTickerWidget.jpg
Is not the JPG himself. It is a GitHub Page with the image.
You have to use the raw image url. If you click on the download button on the right, you will get the needed URL:
https://raw.githubusercontent.com/wickenico/crypto-ticker-widget.js/main/img/cryptoTickerWidget.jpg
this mistake has already happened to some and I corrected the URL at the review.
Maybe I'll add a warning if the domain is github.com and not raw.github.com.

Thanks thanks!
Yes I would love to have a warning there or maybe a small instruction list :)

Also I recognized that the setting of the "Manuell configuration of the Widget necessary" switcher is set back to "OFF" every time I edit a script.

Also I recognized that the setting of the "Manuell configuration of the Widget necessary" switcher is set back to "OFF" every time I edit a script.

I will have a look on it 😊

Also I recognized that the setting of the "Manuell configuration of the Widget necessary" switcher is set back to "OFF" every time I edit a script.

I looks like that only the displaying isn't working correct (see right corner):

I will check why the toggle doesn't reflect the status correct.

fixed ✅

yes, nice!


Make it possible to select supported devices in the operator

In order to support per device deployment in the operator:

Add customization overlays for FPGA, DSA, SGX, GPU, QAT under deployments/operator/device/
Add --device cmdline to operator main.go which defines the controllers/webhooks to set up

/cc @dmitsh FYI

@ozhuraki There was some activity on combining components in kustomize last year: https://github.com/kubernetes-sigs/kustomize/issues/1251 Would this approach help us to generate combined operator resources for multiple devices?

@bart0sh

Would this approach help us to generate combined operator resources for multiple devices?

Thanks. It might help when we solve the problem of dropping the unwanted CRDs (at the moment they are combined).
I tried to pull only the required bases, however it didn't work (see the discussion above). One possibility is:

maybe the only way to do it is to have the CRDs created by the manager itself. This could follow the idea I demonstrate in #394 (comment)

OK, updated, please take a look:

Added a validation of --device arguments
Added a check for duplicates
Switched to string array
Merged "fpga" clauses

@mythi @rojkov please review.


[site] add example of cronjob

What type of PR is this?
/kind documentation

What this PR does / why we need it:
adds example of cronjob
Which issue(s) this PR fixes:

Fixes #1440
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/retest

/cc

@moficodes are you going to continue on this?

@mimowo My notification from during the break were buried 😄
Will get back to this.

@moficodes do you have bandwidth to bring this up to date?
Note that I restructured the task folders

I will get to it once I am back from vacation next week. Thanks for
the heads up.
On Thu, Mar 28, 2024 at 3:36 PM Aldo Culquicondor @.***>
wrote:

@moficodes https://github.com/moficodes do you have bandwidth to bring
this up to date?
Note that I restructured the task folders
—
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/kueue/pull/1446#issuecomment-2025370356,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADRERVBDELT2C76JYSENEY3Y2QTGJAVCNFSM6AAAAABASAJB76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRVGM3TAMZVGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

@alculquicondor


Stable build is broken

In file included from /usr/lib/gcc/x86_64-pc-linux-gnu/5.4.0/include/g++-v5/memory:81:0,
                 from /tmp/src/github.com/yandex/ClickHouse/dbms/include/DB/Common/Exception.h:5,
                 from /tmp/src/github.com/yandex/ClickHouse/dbms/include/DB/Core/Field.h:10,
                 from /tmp/src/github.com/yandex/ClickHouse/dbms/include/DB/Core/FieldVisitors.h:3,
                 from /tmp/src/github.com/yandex/ClickHouse/dbms/include/DB/Storages/MergeTree/PKCondition.h:5,
                 from /tmp/src/github.com/yandex/ClickHouse/dbms/src/Storages/tests/pk_condition.cpp:2:
/usr/lib/gcc/x86_64-pc-linux-gnu/5.4.0/include/g++-v5/bits/unique_ptr.h: In instantiation of 'typename std::_MakeUniq<_Tp>::__single_object std::make_unique(_Args&& ...) [with _Tp = DB::PKCondition; _Args = {std::shared_ptr<DB::IAST>&, DB::Context&, DB::NamesAndTypesList&, std::vector<DB::SortColumnDescription, std::allocator<DB::SortColumnDescription> >&}; typename std::_MakeUniq<_Tp>::__single_object = std::unique_ptr<DB::PKCondition>]':
/tmp/src/github.com/yandex/ClickHouse/dbms/src/Storages/tests/pk_condition.cpp:34:72:   required from here
/usr/lib/gcc/x86_64-pc-linux-gnu/5.4.0/include/g++-v5/bits/unique_ptr.h:765:69: error: no matching function for call to 'DB::PKCondition::PKCond
ition(std::shared_ptr<DB::IAST>&, DB::Context&, DB::NamesAndTypesList&, std::vector<DB::SortColumnDescription>&)'
     { return unique_ptr<_Tp>(new _Tp(std::forward<_Args>(__args)...)); }
                                                                     ^
In file included from /tmp/src/github.com/yandex/ClickHouse/dbms/src/Storages/tests/pk_condition.cpp:2:0:
/tmp/src/github.com/yandex/ClickHouse/dbms/include/DB/Storages/MergeTree/PKCondition.h:226:2: note: candidate: DB::PKCondition::PKCondition(DB::
ASTPtr&, const DB::Context&, const DB::NamesAndTypesList&, const SortDescription&, const DB::Block&)
  PKCondition(ASTPtr & query, const Context & context, const NamesAndTypesList & all_columns, const SortDescription & sort_descr,
  ^
/tmp/src/github.com/yandex/ClickHouse/dbms/include/DB/Storages/MergeTree/PKCondition.h:226:2: note:   candidate expects 5 arguments, 4 provided
/tmp/src/github.com/yandex/ClickHouse/dbms/include/DB/Storages/MergeTree/PKCondition.h:216:7: note: candidate: DB::PKCondition::PKCondition(const DB::PKCondition&)
 class PKCondition
       ^
/tmp/src/github.com/yandex/ClickHouse/dbms/include/DB/Storages/MergeTree/PKCondition.h:216:7: note:   candidate expects 1 argument, 4 provided
/tmp/src/github.com/yandex/ClickHouse/dbms/include/DB/Storages/MergeTree/PKCondition.h:216:7: note: candidate: DB::PKCondition::PKCondition(DB::PKCondition&&)
/tmp/src/github.com/yandex/ClickHouse/dbms/include/DB/Storages/MergeTree/PKCondition.h:216:7: note:   candidate expects 1 argument, 4 provided
dbms/src/Storages/tests/CMakeFiles/pk_condition.dir/build.make:62: recipe for target 'dbms/src/Storages/tests/CMakeFiles/pk_condition.dir/pk_condition.cpp.o' failed

Could you provide hash of a commit used for build?
It seems that you use outdated version.
Master branch now looks as follows:
https://github.com/yandex/ClickHouse/blob/master/dbms/src/Storages/tests/pk_condition.cpp#L35
(5 arguments in constructor)

I have just checked the build and it is fine.
BTW, in per-commit auto builds, we are building only clickhouse-server, not all targets.

I use last tag labeled as stable:
git checkout tags/v1.1.54083-stable
HEAD is now at 0a2d1eb... Attempt to improve merge selecting algorithm [#METR-23632].

May be you can benefit from building all targets with Circle CI or something like that?

We have investigated possibility of using Travis CI and Circle CI.
For Travis CI, maximum build time in free version is not enough.
For Circle CI, there is no root access to install custom packages.
We already have our internal CI, and our QA engineers could enable check for all targets.

With Circle CI you can build in docker.
https://circleci.com/docs/docker/

We considered different variants of CI build system to make results of per-commits builds and tests publicly available.
Circle CI and similar CI systems (CI as a service) have serious limitations.
For example, Circle CI allows to use only strictly pre-defined VM configurations, so we even cannot use gcc 5 to compile.
Nevertheless, we plan to make our task tracker and CI system publicly available.

While it is not possible to install gcc5 in Circle CI with free plan (with paid access you can ask their tech support to install everything you want), you are allowed to run docker build inside CircleCI instance.
Having that you can create builder image with newest GCC and other dependencies and than run docker run to compile clickhouse and collect artefacts.
I believe this is the fastest way.

I have just created v1.1.54093-testing:
https://github.com/yandex/ClickHouse/releases/tag/v1.1.54093-testing
which is as stable as the latest stable tag.

What is the criteria for a tag to be "-stable"?

It must be released to our production clusters.

We have several new stable releases since then.
Including release 1.1.54127 today.


[Updated steps to reproduce] Data grid paging doesn't work when set @bind-Settings

Go to https://blazor.radzen.com/datagrid-save-settings
Edit code and add e.g. PageSizeOptions="new[] { 2, 4, 8, 12 }"
After that try to click a few times. Sometimes it's needed to click a few times

When using PageSizeOption you should also set PageSize to a variable:

otherwise every change state will reset the PageSize to what is declared in the razor


We should define the full specs of the deserialization with inheritance

Before going further in the implementation with the risk of having to replace everything if we encounter a new unforeseen case, I think we should set the full specs of the deserialization with inheritance.
This issue should list all cases and how to manage them. This comment will be edited with the latest updates.

Object without its discriminator field
Object with unmatching discriminator value
Register with children that does not extends the parent
Register with the parent among the children
Inheritance with explicit matching for the parent itself (same as above?)
Inheritance with implicit matching for the parent itself (allowSelf?)
Recursive inheritance, with multiple levels, like grandchildren and further

I'll try to describe my own thoughts about each case:

Object without its discriminator field
Either return parent if allowSelf is defined or throw new TypeError(...), it allows more flexibility in API models, but we could add a warning to say something like "undefined value found in discriminator field ...".

Object with unmatching discriminator value
I think we should act like this:

if parent has allowSelf, return parent.
else, throw new TypeError

Register with children that does not extends the parent
Nice case, I think we should add a typeguard implementation that checks inheritance over children and throw an error if a "non-extending-parent child" is found.

Register with the parent among the children
To me, you can't be the child of yourself, that's the same thing for OOP.

Inheritance with explicit matching for the parent itself (same as above?)
We should add an optional parent field value in Registration. This approach would be way better than the previous one I think, because we don't break OOP laws.

Inheritance with implicit matching for the parent itself (allowSelf?)
allowSelf should act as a fallback flag to me, meaning that if you don't have a child for the current value, you get the parent, but you have to explicitly set the flag if you want this behavior, else you get an error.

Recursive inheritance, with multiple levels, like grandchildren and further
We already have a recursive approach in the current impl (see recursive-impl branch) and I think this is how we should do it. Because if you have a 10-levels deep inheritance, we have to use recursivity to find which child you're using.

BUT, each level has to add its own discriminator, else we can't know if it's just a child of parent, or a grandchild, etc. see https://github.com/kaiu-io/serializer/blob/recursive-impl/src/serializer.ts#L141

Object without its discriminator field

I'm agree

Object with unmatching discriminator value

I think if the parent isn't explicitly asked (allowSelf + null value) we shouldn't fallback to the parent by default. So for this case, throw for any unmatching discriminator.

Register with children that does not extends the parent

I'm agree

Register with the parent among the children

We should design the extends test needed for the case above, in a maner that the parent itself doesn't pass the test.

Inheritance with explicit matching for the parent itself (same as above?)

Same case that previous.

Inheritance with implicit matching for the parent itself (allowSelf?)

Already cover by allowSelf + null value.

Recursive inheritance, with multiple levels, like grandchildren and further

I'm ok with it, I was just trying to list all the cases, not only the remanining.

Closed by #7.


Show user-friendly error page instead of the exception

Is it possible to make global error handling that will show user-friendly error page instead of showing red exception?
I already made error handling (here) that will report exception to the backend but what I really would like to achieve is to hide red exception and show something a little bit friendlier.
I searched everywhere and I found literally nothing.

I believe the big red exception only appears in debug builds. Have you tried out a release build?

I believe the big red exception only appears in debug builds. Have you tried out a release build?

Nope. I created a sample project and basically tried setting the property value of an uninstantiated object.
MyClass myClass;
myClass.myProperty = "hey";

And I still got the red exception in the release mode saying:
The setter 'myProperty=' was called on null.
Receiver: null
Tried calling: myProperty="hey"

You can register a custom error handler using
https://docs.flutter.io/flutter/foundation/FlutterError/onError.html
https://github.com/flutter/sentry has some tips for how to handle errors globally ("Tips for catching errors")

big red exception only appears in debug builds

I thought so as well but seems that only applies to layout issues like overflow

I digged around a bit and found out you can set the ErrorWidget builder. By using the builder you can implement a custom screen. I made a small example that you can find here: https://gist.github.com/wouterhardeman/1f939e661e166a6ec119269c13bcbfba

God bless you.

@wouterhardeman nice one. Can't remember seeing that being mentioned.

@wouterhardeman To use those theme-defined styles I need to have the context object like this:
Widget getErrorWidget(BuildContext context, FlutterErrorDetails error) {
  return Center(
    child: Text(
      "Error appeared.",
      style: Theme.of(context).textTheme.title.copyWith(color: Colors.white),
    ),
  );
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    ErrorWidget.builder = (FlutterErrorDetails errorDetails) {
      return getErrorWidget(context, errorDetails);
    };

    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

Any smarter way to do this?


Modified some tests to work cross platforms (locales and floats)

Coverage remained the same at 74.373% when pulling 40b0811dd7b3e9217cace6fecc8503f9cf07618a on yitam:brittleTests into 7e58d1aa92e6d97bf806763de960ae9ef8fd78aa on microsoft:dev.


Add Pronouns custom field type.

First commit adds "Pronouns" field type in backend.
Second commit is to show typeahead for "Pronouns" type field.
Third commit is to fill the label and hint by default.
Fourth commit is to check the display_in_profile_summary field by default if required.

Fixes:  #21271

Screenshots and screen captures:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

I have few questions-

Do we want to fill the label and hint field if there is already a "Pronouns" field with "Pronouns" type only, since we cannot have two fields with same label?
Do we want to set default value for hint and display_in_profile_summary if no value is passed for them when creating Pronouns type field using API? I don't think we should do that since in UI user can still edit the fields, but in this case user maybe unaware of these default values for Pronouns type fields.

Overall this implementation looks pretty solid; I've not done any testing.

Do we want to set default value for hint and display_in_profile_summary if no value is passed for them when creating Pronouns type field using API? I don't think we should do that since in UI user can still edit the fields, but in this case user maybe unaware of these default values for Pronouns type fields.

I think the answer is no; it's extra work, and I think it would make life more complex for a developer of mobile app UI for editing the organization's custom profile fields down the line.

Do we want to fill the label and hint field if there is already a "Pronouns" field with "Pronouns" type only, since we cannot have two fields with same label?

@alya thoughts? My perspective is it's probably fine to do nothing special as long as the error handling when trying to create a duplicate field is reasonable.

I started https://chat.zulip.org/#narrow/stream/378-api-design/topic/new.20pronouns.20field.20type/near/1444560 for the API transition questions we'll need to answer before merging this.

@alya thoughts? My perspective is it's probably fine to do nothing special as long as the error handling when trying to create a duplicate field is reasonable.

Yes, I think that's fine. For reference, we don't do anything special when the user tries to create a second GitHub profile field (even though we know it won't work), and I think it's not a big deal.

I'm having issues with provisioning this, so I'll wait for updates before I test.

Updated the PR. It should be ready to test now.
Also updated the API docs as Tim mentioned above.

Looks good to me! @timabbott tagging for your review.

Merged, thanks @sahil839!


Feature/simplify read own writes tagging

Scope & Purpose

Simplify the tagging of EnumerateCollectionNodes and IndexNodes with the
"read-own-writes" flag. Previously the tagging only happened after all query
optimizations were completed, making the tag unavailable to the optimizer.
Now the tag is set early on, so it is accessible by the query optimizer.

This change is required to complete https://arangodb.atlassian.net/browse/BTS-624

[x] :hankey: Bugfix (requires CHANGELOG entry)
[x] :pizza: New feature (requires CHANGELOG entry, feature documentation and release notes)
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification
[x] :book: CHANGELOG entry made

Backports:

[x] Backport for 3.9: (Please link PR)
[x] Backport for 3.8: (Please link PR)
[x] Backport for 3.7: (Please link PR)

Testing & Verification

[x] The behavior in this PR was manually tested
[x] This PR adds tests that were used to verify all changes:

[x] Added new integration tests (shell_server_aql)

LGTM, but perhaps we should add another test case with an UPSERT inside a subquery.

done


% Synced label shows different levels or precision.

Yes, this clearly lives in the land of trivial, but if I noticed it, others probably have too:
The number of decimal places displayed in the % Synced Label changes based on the value:
Expect: 99.89%, 99.90%, 99.91%
Actual: 99.89%, 99.9%, 99.91%

So you are suggesting this? Fixed 2 decimal places


zippyshare-dl error when upgrade ubuntu...

zippyshare-dl or zippyshare-downloader version 0.3.3, Im using Python 3.10.6 and pip 23.0.1 from /usr/local/lib/python3.10/dist-packages/pip (python 3.10)
root@ubuntu:~# zippyshare-dl "https://www76.zippyshare.com/v/xxx/file.html" --proxy "socks5h://user:pass@<IP_ADDRESS>:1212"
[INFO] Grabbing required informations in https://www76.zippyshare.com/v/xxx/file.html
[INFO] Downloading "ASD.mp4"
Traceback (most recent call last):
  File "/usr/local/bin/zippyshare-dl", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/dist-packages/zippyshare_downloader/cli/process.py", line 165, in main
    process(**kwargs)
  File "/usr/local/lib/python3.10/dist-packages/zippyshare_downloader/cli/process.py", line 80, in process
    file = extract_info(urls, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/zippyshare_downloader/fetcher.py", line 158, in extract_info
    file_path = file.download(**kwargs)
  File "/usr/local/lib/python3.10/dist-packages/zippyshare_downloader/file.py", line 105, in download
    downloader.download()
  File "/usr/local/lib/python3.10/dist-packages/zippyshare_downloader/downloader.py", line 86, in download
    file_sizes = float(resp.headers.get('Content-Length'))
TypeError: float() argument must be a string or a real number, not 'NoneType'

Please help me, thanks mansuf!

It was actually pattern change, zippyshare changed their code, i added new pattern in v0.3.4. So update your zippyshare-downloader


chore(turbo): add remote cache to reduce duplicated ci or build

fix #299
Overview

As the project grew, CI and build times were getting longer. Therefore, I wanted to shorten this time by using a remote cache. We can check extremely fast ci in GitHub Actions using Turborepo's remote caching of Vercel. I'm happy to solve the problem and introduce it to you with this Pull Request. 🚀
Extremely fast ci (for example: ci(lint): 1m 24s -> 28s)
AS-IS:not using cache (ci(lint total): 1m 24s, prepack:29s -> lint:22s)

TO-BE:using cache (ci(lint total): 28s, prepack:2s -> lint:1s)

Extremely fast publish
In Pull Request, visualization and docs built file and @suspensive/react @suspensive/react-query @suspensive/react-await packed files will be cached, and when this Pull Request finally is merged, reuse it so publishing time for all packages and websites(docs, visualization) will be extremely saved
build on Pull Request and cache it to reuse on publish docs, visualization and all packages

PR Checklist

[x] I did below actions if need

I read the Contributing Guide
I added documents and tests.

Is there any other downside to caching?

I don't think there is downside of caching just now. If there are any problems while using it, let's fix it.


Why is "god" triggering the profanity filter?

I only see "God-damned" in the language list, but using god alone was also triggering the check. Any ideas what could be going on? Thanks!

This is not intended as a statement. there's a problem with dashes:
see https://github.com/web-mech/badwords/issues/82

AH... I think "god" is actually from package badwords-list, since I see that package imported, and "god" is in the list over there... Not sure though.

"god" is not in the bad word list but "God-damned" is, see here https://github.com/web-mech/badwords/blob/master/lib/lang.json
A workaround would be to remove "god" form the bad word list before doing the filter, for example:
            languageFilter.removeWords("god");
            console.log(languageFilter.clean("Now tell me there is God watching over us!"));

This is a workaround, not a proper fix.

I have never seen so many bad words in my life meshed into one sitting.

Maybe that's why Scratch didn't allow us to make a bad word filter