Record by default?

Just noticed there's a number of issues being submitted around not working or not seeing data that appear to be folks missing the record button.
I wonder if it would be useful to have the extension record by default upon activation of the tab?

I agree with @snypelife: like the Network tab that record by default.


Remove unsupported examples

What is is PR for?

[ ] Code update
[X] Documentation update
[X] Infrastructure update

What does this PR do?
It removes few examples that are not needed for the core CDP (sensor examples, BLE, DishDuck, etc)
Is this related to an open issue?
https://github.com/ClusterDuck-Protocol/ClusterDuck-Protocol/issues/376
Testing methodology
Nothing to test. Just examples were removed and the readme was updated.
Additional context
Add any other technical detail or considerations here.
Checklist
Before you submit this pull request, please make sure you have done the following:
General

[X] Contribution Guidelines: Have you read the contribution guidelines?
[X] Code of Conduct: Have you read the code of conduct?
[X] Documentation: If applicable, have you added or updated all relevant documentation?

For Code Updates

[ ] Hardware Validation: If relevant, have you validated your changes on actual supported Duck hardware?
[ ] Unit Tests: Have you run the unit tests on the device?
[ ] Network Testing: If applicable, have you tested your changes on a Duck network?
[ ] Licensing: Have you added a copyright and license header to each new file?

Tested Targets (Please check all that apply)

[ ] All
[ ] Heltec LoRa v3
[ ] Heltec LoRa v2
[ ] Heltec CubeCell Series
[ ] TTGO T-Beam (SX1262)
[ ] Others

Moved this back to a draft to address the conflicts.


Upgrade node version in CI workflows

Pull Request
Related issue
Fixes #1119
What does this PR do?
Upgrade node version in CI workflows (from node 16 to node 18) in following files:

.github/workflows/meilisearch-prototype-tests.yml
.github/workflows/pre-release-tests.yml
.github/workflows/publish.yml
.github/workflows/tests.yml

PR checklist
Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Hey! Thanks a lot for this PR :)
You missed one in this file: https://github.com/meilisearch/instant-meilisearch/blob/main/.github/workflows/publish.yml

Thanks for reviewing. I got it and updated in the latest commit. Please review again

bors merge

bors merge

bors r-


Update docs generators to include proper edit on github links

Ref: https://github.com/ghostty-org/website/pull/197
The "Edit on Github" links currently on ghostty.org link to the downstream MDX files. This has lead to multiple folks editing the downstream MDX files.
Preview:
https://website-git-edit-on-github-link-override-ghostty.vercel.app/docs/config/reference#auto-update-channel

Well this is fancy as hell. Nice!

I'm gonna merge in https://github.com/ghostty-org/website/pull/197 so we have the functionality.  This will just need to get in before the next regeneration.


Fix multiple bugs and conversions for PARGB32 bitmap object and premultiplied Cairo surfaces

Contributes to #446.
Fixes the following issues:

Converts to/from premultiplied colors in GdipBitmap[Set/Get]Pixel in PARGB32 mode
Converts back and forth underlying data for Cairo surfaces where only PARGB32 is supported and ARGB32 is emulated. This fixes regressions caused by 389cb7bb49006c0a598ee3369d9c4876574740fe and f7775ec5746d242e9c3c0f06a725bfee748f8243 at the expense of slight inaccuracies due to rounding in the ARGB32 -> PARGB32 -> ARGB32 conversion.

Should fix the CorrectColorDepthExtracted test failing on Mono PRs. I didn't try it locally yet. The test itself is slightly broken because it expects rounded values (resulting from alpha pre-multiplication) instead of the actual values in the .ico file.

/cc @akoeplinger

I tried this locally on OSX and it doesn't fix the issue for me:
    System.Drawing.Tests.IconTests.CorrectColorDepthExtracted [FAIL]
      Assert.Equal() Failure
      Expected:<PHONE_NUMBER>
      Actual:<PHONE_NUMBER>
      Stack Trace:
        /_/src/System.Drawing.Common/tests/IconTests.cs(864,0): at System.Drawing.Tests.IconTests.CorrectColorDepthExtracted()
        /Users/alexander/dev/mono/netcore/System.Private.CoreLib/src/System.Reflection/RuntimeMethodInfo.cs(339,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Hmm, that is still the wrong premultiplied value.

/azp run

Now it should pass all the tests except for this one:
    System.Drawing.Tests.IconTests.CorrectColorDepthExtracted [FAIL]
      Assert.Equal() Failure
      Expected:<PHONE_NUMBER>
      Actual:<PHONE_NUMBER>

It is consequence of rounding error in ARGB32 -> PARGB32 -> ARGB32 conversion and naive implementation of Bitmap(Bitmap bitmap) constructor. The best fix is on CoreFX side to switch to  GdipCloneBitmapArea API which is lossless since it avoids creating GpGraphics object and drawing using Cairo.

Cherry-picked to release/6.0


Android-Kotlin : 04.1 Overview of Android Resource file

Description :
Give an overview of the Android-Resource file (res):-
References :

https://developer.android.com/guide/topics/resources/providing-resources
https://medium.com/@doyouseeitmyway/creating-and-using-resource-files-in-android-studio-8b4208c08862

Changes should be made in Android_Development/Kotlin/ directory under Android_Development_With_Kotlin branch.
You have to push your PR to the Android_Development_With_Kotlin branch only.
You can take help to the references but don't simply try to copy it. Just explain in your own word.
This issue is for GWOC'21 contributors only.
You need to push in a single commit. If there exists more than one commit then you need to squash your commits into one commit.

Supervisor @rahulsain

Hello @rahulsain I want to work on this issue.
Batch- 3 Android with Kotlin
Serial Number- 81

@rahulsain please review

mention me in that PR

please share your PR link here. Else you can tag us in your PR


"x" button to close "Manage Workspace" , "Tool Catalog" are sluggish to respond.

Version - 0.10.0-rc2 (0.10.0-rc2)
Steps to reproduce the problem:
I am seeing the "x" button to close "Manage Workspace" , "Tool Catalog" are all not always responding quickly. Takes a few seconds to get it to actually close.
I am seeing this behavior only from rc2 builds.

https://github.com/user-attachments/assets/f8b03873-58cb-4666-9cbd-f26a7a6e490d

Seems like they are "hard to target" or something.


Update gdpr-dsr-Office365.md

Removed references of OUTlook customer manager as it has been deprecated

@JohanFreelancer9 Please copy review

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/3385

@JohanFreelancer9 Please copy review, reminder, Thanks

@msbemba and @yogkumgit - this content was migrated to another repo, will incorporate these updates into the topic in the new location on separate PR.


Бесплатная версия (Free version)

Можно ли получить полный список ограничений и возможностей бесплатной версии?
Сколько человек может принимать участие в одной видеоконференции, какова продолжительность конференций в часах за один раз и в целом в месяц и т.д.
Can I get a complete list of limitations and features of the free version?
How many people can take part in one videoconference, what is the duration of conferences in hours at a time, and in general per month, etc.

Сведения о документе
⚠ Не вносите правки в этот раздел. Это необходимо для связывания страницы сайта docs.microsoft.com с вопросом на GitHub.

ID: 905e2c09-ef3e-07cc-0809-6ff171157c47
Version Independent ID: c0d33162-183d-fff8-32e9-a999f391ea51
Content: Ограничения и спецификации для Microsoft Teams - Microsoft Teams
Content Source: Teams/limits-specifications-teams.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

@Akackk  Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@officeglobal could you please help on this issue? Thanks!

@scanum article is being HumanTranslated, but it seems the question is related to an author of the article. Could you please check it one more time?
Akackk's Question:
Can I get a complete list of limitations and features of the free version?
How many people can take part in one videoconference, what is the duration of conferences in hours at a time, and in general per month, etc.

@OfficeGlobal Thanks for letting us know! Appreciate your help.

@Balu-msft can you confirm that the free versions of Teams have all the capabilities/limitations of the paid version?

@Akackk  thanks for your inquiry. For Teams Exploratory and the recent free E1 Teams trial, all capabilities are the same. For Teams Free, there are differences. Check out the comparison in this article:
https://www.microsoft.com/en-us/microsoft-365/microsoft-teams/compare-microsoft-teams-options


Problems with start angular-phonecat Wndows 7

Starting up http-server, serving ./ on port: 8000
Hit CTRL-C to stop the server
[Sun, 10 Apr 2016 15:29:51 GMT] "GET /app/index.html" "Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Geck
o) Chrome/49.0.2623.110 Safari/537.36"
_http_outgoing.js:351
throw new TypeError('The header content contains invalid characters');
^
TypeError: The header content contains invalid characters
at ServerResponse.OutgoingMessage.setHeader (_http_outgoing.js:351:13)
at ResponseStream.(anonymous function) [as setHeader] (D:!Projects\Angular\angular-phonecat\node_modules\http-serve
r\node_modules\union\lib\response-stream.js:86:34)
at serve (D:!Projects\Angular\angular-phonecat\node_modules\http-server\node_modules\ecstatic\lib\ecstatic.js:146:1
1)
at D:!Projects\Angular\angular-phonecat\node_modules\http-server\node_modules\ecstatic\lib\ecstatic.js:139:9
at FSReqWrap.oncomplete (fs.js:82:15)
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "sta
rt"
npm ERR! node v4.4.2
npm ERR! npm  v2.15.0
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: http-server -a <IP_ADDRESS> -p 8000
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'http-server -a <IP_ADDRESS> -p 8000'.
npm ERR! This is most likely a problem with the angular-phonecat package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     http-server -a <IP_ADDRESS> -p 8000
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular-phonecat
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls angular-phonecat
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     D:!Projects\Angular\angular-phonecat\npm-debug.log
PS D:!Projects\Angular\angular-phonecat>
FILE npm-debug:
0 info it worked if it ends with ok
1 verbose cli [ 'C:\Program Files\nodejs\node.exe',
1 verbose cli   'C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js',
1 verbose cli   'start' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info prestart<EMAIL_ADDRESS>6 verbose unsafe-perm in lifecycle true
7 info start<EMAIL_ADDRESS>8 verbose unsafe-perm in lifecycle true
9 info<EMAIL_ADDRESS>Failed to exec start script
10 verbose stack Error<EMAIL_ADDRESS>start: http-server -a <IP_ADDRESS> -p 8000
10 verbose stack Exit status 1
10 verbose stack     at EventEmitter. (C:\Program Files\nodejs\node_modules\npm\lib\utils\lifecycle.js:217:16)
10 verbose stack     at emitTwo (events.js:87:13)
10 verbose stack     at EventEmitter.emit (events.js:172:7)
10 verbose stack     at ChildProcess. (C:\Program Files\nodejs\node_modules\npm\lib\utils\spawn.js:24:14)
10 verbose stack     at emitTwo (events.js:87:13)
10 verbose stack     at ChildProcess.emit (events.js:172:7)
10 verbose stack     at maybeClose (internal/child_process.js:827:16)
10 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
11 verbose pkgid<EMAIL_ADDRESS>12 verbose cwd D:!Projects\Angular\angular-phonecat
13 error Windows_NT 6.1.7601
14 error argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "start"
15 error node v4.4.2
16 error npm  v2.15.0
17 error code ELIFECYCLE
18 error<EMAIL_ADDRESS>start: http-server -a <IP_ADDRESS> -p 8000
18 error Exit status 1
19 error Failed at the<EMAIL_ADDRESS>start script 'http-server -a <IP_ADDRESS> -p 8000'.
19 error This is most likely a problem with the angular-phonecat package,
19 error not with npm itself.
19 error Tell the author that this fails on your system:
19 error     http-server -a <IP_ADDRESS> -p 8000
19 error You can get information on how to open an issue for this project with:
19 error     npm bugs angular-phonecat
19 error Or if that isn't available, you can get their info via:
19 error
19 error     npm owner ls angular-phonecat
19 error There is likely additional logging output above.
20 verbose exit [ 1, true ]

This is due to outdated dependecies (more specifically http-server). We are about to update all our dependencies (including http-server).
In the meantime, you can solve this by manually updating your local version of http-server to 0.9.0 or newer. E.g.:
npm uninstall http-server
npm install<EMAIL_ADDRESS>


Create multi-slot BS2e+ Examples

After multi-slot features are added to app, PropGit should create multi-slot examples to include in the Examples project.

UPDATE: I've now created examples that are ready for inclusion once multi-slot functionality is added to app.


Office Apps add on

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b73778b8-8dd2-98f5-b4a1-e135a0049011
Version Independent ID: 25744bd8-6084-00dc-545a-4b3eb87dedd4
Content: Create add-in commands in your manifest for Excel, PowerPoint, and Word - Office Add-ins
Content Source: docs/develop/create-addin-commands.md
Product: non-product-specific
Technology: add-ins
GitHub Login: @o365devx
Microsoft Alias: o365devx

Hi @ptwqigit,
With no issue description, it's unclear what your feedback is. I'm going to close the issue, but we can revisit the problem if you add context with additional comments.


2.5.5 "There are no charts available, have you added any repos?"

i cannot install any apps from Rancher as none show up

As I believe was discussed with you in Slack, k8s 1.20 is not supported by Rancher 2.5.5.

Correct. Thanks, Vincent!


Is there any way to ignore certificate check for ssl destinations?

Here is a config file:
example.com:
  - { route: "^/(.*)", dest: "https://<IP_ADDRESS>:443/$1" }

And sometimes there is a case when destination is self signed certificate and I would like to have ability to ignore certificate check. I see some cases for dev or test purposes.
For now I have another service haproxy, which can ignore ssl check but it would be great to add such option to reproxy.

this is not a bad idea, should be easy to do on the top-level, i.e. as cli/env param


Restrict create application admin endpoint to only allow IDIR user

Describe the task
Restrict create application admin endpoint to only allow IDIR user
Add rule to API for creating access assignments to prevent granting fam/app admin access to a BCeID user; and
Ensure grant access screen for granting FAM/app admin does not include the option for BCeID user.
Acceptance Criteria

[x] Add check on user type when creating application admin, return error message when user type is bceid
[x] Update tests to check on user type
[x] return descriptive error notification
[x] Remove temporary addition on repository query filter FamUser.user_type_code == UserType.IDIR (and the comment) from application_admin_repository.get_user_app_admin_grants() as after restriction is added there won't be such record (other than idir type user) being created.

Additional context

See #1059 for frontend-related work already in review
could be done in router guard or service validation check (router preferred)

Status of done in project, open in github; forcing close in github


UI slow if the aggregation creates too many buckets

the aggregation zipkin servers sent to Elasticsearch as below:
{
"_source": false,
"aggs": {
"name": {
"terms": {
"field": "name",
"size":<PHONE_NUMBER>
}
}
},
"query": {
"bool": {
"filter": {
"bool": {
"must": [{
"range": {
"timestamp_millis": {
"from":<PHONE_NUMBER>984,
"include_lower": true,
"include_upper": true,
"to":<PHONE_NUMBER>984
}
}
},
{
"term": {
"localEndpoint.serviceName": "mobileuser-service"
}
}]
}
}
}
}
}
Warning: 299 Elasticsearch-6.3.0-424e937 "This aggregation creates too many buckets (10001) and will throw an error in future versions. You should update the [search.max_buckets] cluster setting or use the [composite] aggregation to paginate all buckets in multiple requests." "Wed, 18 Jul 2018 08:21:04 GMT"

[ ] Question.

What is this aggregation used for ?
How to resolve this issue?

do you have variables in your span names? Span names should be fixed
cardinality. If you have something like an http route, make sure this is
used instead of paths with variables in it.
https://github.com/openzipkin/brave/tree/master/instrumentation/http#http-route-cardinality
https://github.com/openzipkin/zipkin-api/blob/master/zipkin.proto#L108
https://github.com/openzipkin/zipkin-api/blob/master/zipkin2-api.yaml#L312

Thanks for the quick response.   We are using Spring Cloud -Dalston RELEASE with sleuth.  By default, it puts variables in the span name.

I just tested the lastest Spring Cloud and found the cardinality has been fixed in this Finchley RELEASE,  like span name: " get /user/{userId}"


How to handle off typing event??

I can display typing indicator, but cannot disappear it.
This is my code.(We're using LaravelEcho)
handleOnType () {
      this.echo.whisper("typing", {
        user_id: this.user_id
      });
    },

Echo.listenForWhisper("typing", (e) => {
            this.showTypingIndicator = e.user_id;
          });

If user submit the message, we can disappear the indicator on onMessageWasSent function.
But if user cancel the input, we cannot handle that.
Do you know how to do this??

It seems that you need an extra event besides the "typing" one that you are using:
User A, User B, event "start_typing", event "stop_typing", event "message"
A: sends start_typing
B: gets start_typing from A, the chat shows the typing speech bubble by setting the showTypingIndicator property
A: sends stop_typing
B: gets stop_typing from A, the chat unsets the showTypingIndicator property and the speech bubble disappears
Is this answering your question?
Thanks for stopping by and for the awesome PR.

Thank you for replying.
yeah, I can easily implement stop_typing event on Laravel Echo.
But I don't know the best way to handle stop-typing-event on our vue component.
onType event will be called on handleKey function in UserInput.vue.
handleKey (event) {
      if (event.keyCode === 13 && !event.shiftKey) {
        this._submitText(event)
        event.preventDefault()
      }
      this.$emit('onType')
    },

But, handleKey does not pass params to onType function.
so,If we distinguish the typing status is whether ON or OFF,
we have to add the condition like...

this.$ref.userInput.length is 0 => as offTyping / => as  onTyping
this.$ref.userInput active => as onTyping / disactive => as offTyping
etc...

Anyway, I want to handle those trigger in UserInput.vue component.(not our parent component)
like...

Parent component pass offType and onType function to UserInput.vue
UserInput.vue trigger the offType or onType function according to any conditions

Is there any way to do this??

Ah yes now I see the issue.
Well the way you explained can work I think.
Another way would be to set a timeout for, for instance, 5000 milliseconds, and reset this timeout each time the user changes the userInput. If the timeout expires, it means that there were no changes in the last 5000 milliseconds, therefore the stop typing function (passed at initialization time) can be called. The actual milliseconds for the timeout could be also specified at initialization time.
What do you think about this?

On 20 May 2019, at 2:01 AM, Yoshihide-Nishimoto<EMAIL_ADDRESS>wrote:
Thank you for replying.
yeah, I can easily implement stop_typing event on Laravel Echo.
But I don't know the best way to handle stop-typing-event on our vue component.
onType event will be called on handleKey function in UserInput.vue.
handleKey (event) {
if (event.keyCode === 13 && !event.shiftKey) {
this._submitText(event)
event.preventDefault()
}
this.$emit('onType')
},
But, handleKey does not pass params to onType function.
so,If we distinguish the typing status is whether ON or OFF,
we have to add the condition like...
this.$ref.userInput.length is 0 => as offTyping / => as onTyping
this.$ref.userInput active => as onTyping / disactive => as offTyping
etc...
Anyway, I want to handle those trigger in UserInput.vue component.(not our parent component)
like...
Parent component pass offType and onType function to UserInput.vue
UserInput.vue trigger the offType or onType function according to any conditions
Is there any way to do this??
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@Yoshihide-Nishimoto did you find your way out? 👍

@mattmezza sorry for missing response.
Eventually, we forked your repo and customize UserInput.vue...

Got it. Thanks for the reply. If one day you’ll have time to give some contrib back please feel free to reach out again.
All the best.
I’ma close this one for the moment.

@Yoshihide-Nishimoto How did you do it? Would you be okay submitting a PR for this so others can benefit from the solution?
TIA


Where should I place the glove embedding?

I want to train a new model. Where should I place the embedding file and in which format should it be?

Hi, the training scripts are out-dated for now. Updating then is next on my to-do list but I don't have an ETA for the moment.


[docs] Rename s3clean to s3remove

Looks like you had planned to rename the plugin's command, but never did.

@f00f  Indeed, thanks for fixing it.


Custom domain name for cluster

Using common name method for cluster certificate requires the cluster to have custom domain name (since you cannot get certificate for *.cloudapp.net). How is custom domain name assigned to the cluster?
Does one just edit the managementEndpoint
"managementEndpoint": "https://...cloudapp.azure.com:19080",
-->
"managementEndpoint": "https://cluster.my-domain.com:19080",
Is this safe to do on running cluster assuming the certificate has been uploaded and added as secondary certificate?

Is there any update on this, as I also need this information ?


Scope/Roadmap

It's time to outline what we want out of an Electron application for the Jupyter notebook!

Fully standalone desktop application (in Electron!)
One click installers for OS X and Windows
Integrates well with the current ecosystem of tooling
Bundles a kernel with scientific Python packages

As part of this, we'll want to make sure we adhere to the way that Jupyter paths work across kernels (so users can install others). This is the reason jupyter-paths exists for node - we'll need to make sure this adheres to the right spec (it was ported directly from the original Python).

Fully standalone desktop application (in Electron!)
One click installers for OS X and Windows

Nice!

Integrates well with the current ecosystem of tooling

I assume you are referring to things like ipywidgets and nbextensions with this statement?
Can you run Electron apps inside Docker?

Can you run Electron apps inside Docker?

Um what, no?

I assume you are referring to things like ipywidgets and nbextensions with this statement?

Yup. The entire diaspora of crazy fun. @jdfreder and @sylvaincorlay recently adapted ipywidgets to work outside the notebook for these cases.

Probably worth noting this will not include nbextensions in their current form, especially those that are Python based.

I'm going to close this one now that there's an embedded roadmap in the README + a series of issues to scope some of this out.


forc-pkg: allow building with provided engines

Downstream tooling sometimes needs access to declaration & type engine after building the project to make look-ups. So it would be great to have a function in forc-pkg, which allows user specified engines.

Closed because of https://github.com/FuelLabs/sway/pull/4576#issuecomment-1559063887


Compat for Immortals

This was a rather painful experience, for how simple it was in reality.
Thanks, mod author, for knowing how to correctly tick your stuff.
Tested the described functions of the mod and the suspicious code samples, shouldn't desync, but could use more reports, some people wanted this compat.

Looks good


Represent VAST type system in flatbuffers

The flatbufferized definitions of vast::type look fine. I didn't manage a full pass over the main commit unfortunately.

Is this supposed to update the CAF submodule?

This PR will be rebased after #766 is merged. Only the last commit is currently relevant.


settings: Add options to automatically follow and/or unmute topics.

Add option to:

[x] Automatically Follow topics
[x] Automatically Unmute topics
[x] Automatically Follow topics (Frontend)
[x] Automatically Unmute topics (Frontend)

Note:

There is an increase in the query count by  5 (max) while sending a message.

When we send the first message to a topic, there is an increase in the query count by 5 --  1 for checking if it is the first message in the topic + 1 to check if the topic is already followed + 3 for following the topic.

Fixes #25914

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Question:
If a user has selected the option: Topics I participate in
So, every time the user sends a message, do_set_user_topic_visibility_policy will try to follow the topic. If the topic is already followed, we will have a lot of INFO logs. for example:

2023-06-19 04:37:05.207 INFO [] User 10 tried to set visibility_policy to its current value of 3

We can avoid this with an initial check; if the topic is already followed, then skip. But this will cost us an extra query in the message send code path.
Suggestions on how to tackle this?
(check the changes in zerver/actions/message_send.py for related code)

@zulipbot add "mentor review"

Is there anything blocking integration of this other than a review from me?

@timabbott
Yes, pending discussion: https://chat.zulip.org/#narrow/stream/101-design/topic/automatically.20follow.20topics.20.2325914/near/1614384

@zulipbot add "QA"

@zulipbot add "QA needed"

@abhijeetbodas2001 @timabbott
This is ready to review.
Updates in the recent push:

Addressed the review comments.
Added last 3 commits -- Automatically unmute policy + UI for these two settings.
Resolved the error: CZO discussion -- first commit

This is ready to review
Updates in the recent push:

Addressed the review comments (check respective comments)
we have UI and API level constraints to disallow combinations of settings like both having the same value, except NEVER -- related CZO discussion

I merged the prep commits as the series ending with db8229ae32475ec9d114d04a35a50c5096d27f2e.

@timabbott This is ready to review.
Updates in the recent push:

Addressed the review comments.

The test failure is related to postgres client upgrade failures

The recent push includes a small fix. + A couple of questions in the review comments above.

Let's try adding the note discussed on CZO just below the "Topic notifications" heading: "You will automatically follow topics that you have configured to both follow and unmute."

I also posted a suggestion on CZO.
Otherwise looks good to me in manual testing! I have not attempted to test all the possible combinations of settings.

Updates in the recent push:

change the unmute option to "Automatically unmute topics in muted streams" -- CZO discussion
Addressed the review comments
Added a note in settings panel - Alya's review comment

@alya I have added a demo video that shows:

unmute policy only applicable in muted streams
follow policy applicable in both the muted & not muted stream (as before)
Note added in settings panel

Let's fix the compose banner issue alya mentioned in a separate follow-up PR? -- this PR already has ~85+ comments now.

Let's fix the compose banner issue alya mentioned in a separate follow-up PR?

Yeah that sounds good to me, that should be a straightforward follow-up.

Addressed the review comments (see respective comments):

 Important

I rebased this to resolve the merge conflicts; there's a test failure that I suspect is just because some new tests were written without 49092dfa79e10aa8fa28e01d6991e9bba065464c already in main.
I think the above is the complete list of outstanding work to integrate this feature. However, I think we might want to take the opportunity to change the default to "PARTICIPATION" for "automatically unmute" and INITIATION for "automatically follow" -- and then test that this interacts nicely with our compose banners (E.g. we don't pop up a banner telling you to unmute a topic you sent to a muted stream if your configuration automatically unmuted it when you sent the message).
Hrm, I kinda feel like "participation" might feel a bit aggressive for "automatically unmute" -- I'm now wondering if we want an intermediate "Send a message" that doesn't include reactions/etc. Will chat with @alya about that and some of the transition trade-offs today.
Maybe that can be done as a new commit intended to be squashed into the existing commit, just to keep those changes separate.

OK I chatted with @alya and I think there's a few changes:

We should add a new AUTOMATICALLY_CHANGE_VISIBILITY_POLICY_ON_SEND ("Topics I send a message to") -- correct me if I'm wrong, but I think this is a pretty simple change. And set that as the default for automatically_unmute_topics_in_muted_streams_policy. (And ON_INITIATE is confirmed as the planned default for the follow topic setting)
I opened https://github.com/zulip/zulip/issues/26900 as a follow-up for communicating more clearly about when we're making changes.

Posted couple of blockers:

CZO - 1
CZO -2

The issue is when we send a message in muted stream and automatically unmute/follow a topic the unread_mssg.count should increase as it represents not muted messages count. Web client doesn't use count. apply_events should also handle such cases.
The tests are failing as we fixed the count to consider unmuted/followed topics in #26848

Posted a design question

Updates in the recent push:

First commit to fix a bug
Second commit to address the issue discussed on CZO
 -- This was causing a test failure, so included as a prep commit.
Added the AUTOMATICALLY_CHANGE_VISIBILITY_POLICY_ON_SEND ("Topics I send a message to") option.
Addressed the review comments

I think changing the defaults would make sense only when we will fix the compose banners flow in a follow-up PR?

This looks great! Marked to merge once CI passes, leaving the never default in place -- we will do a future migration to change the defaults of these settings once we have everything finished for the feature.
Huge thanks for all the work on this @prakhar1144!


Hello Moo

I tried contacting you via skype but I didn't receive a reply. Could you post your email address ?

                                                                                You can view it on the composer.json file

Sorry, I dont use skype very much. Why dont use gitter?

contacted you via email --- thanks


flow cancellationtoken through HttpConnection.StartAsync

Related to API reviewing

I think we need to reduce the scope of this PR by exposing the token on top level APIs but don't bother flowing it to the other APIs like ITransport.

Starting the transport is part of starting the connection. Not passing it the token would hamstring the effectiveness of cancelling.

I dislike flowing cancellation throughout the stack and using it in various places untested and throwing from arbitrary points in the code where we don’t know what state we’re in.

We're going to go super simple and just put CTs at the public APIs and ignore them for now.


Ability to create and query for classes of failures

Feature request
Pipelineruns fails for various reasons e.g (git_related, build_related). I know results give top level success/failure status. I want to be able to further classify failures to provide more context.
This would help easily identify & surface underlying root causes of taskrun failures.
Use case

As a user, I want to query for all git_related failures in the last week.
As a user, I want to know the most common reason for failures.

/remove-lifecycle rotten, feature is still needed

/reopen
Still needed please!


Mast: Watch +1(720)-306-1632

Mast requests the watch of the watch_number +1(720)-306-1632. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by double-beep in Charcoal HQ


macOS: work get_term_size correctly

Description
After 80299bd064f9c2873305783cb538b1b14c6d0748, get_term_size on macOS is failed always, so image is not shown.
This PR corrects get_term_size to return term size if escape sequences work.

What you wrote isn't valid bash. The change in master is working as intended. It tried universal techniques for window size then return on macOS before the X server stuff.

Sorry I fix it soon.
However I think 80299bd064f9c2873305783cb538b1b14c6d0748 change is wrong totally: Why is it assign 0 to term_width before early return (here)?

I don't see the point in these changes at all.

term_width=0 in line 3692 does not make sense to me. It discards the result of universal techniques for window size. And it is the only reason not to show image at all. It should be fixed.
You pushed fc229704c8ee03452f8f4e5cf30bccbe1e4bdd7d an hour ago, which removes macOS from early return condition. It can solve this issue, but we will have another issue. It lets xquartz start on macOS if failed to get window size for some reasons.
I will push very simplified version of this. A change I need is this in fact.

Good. Thank you.


Bug: "Breathe Act" letter contains duplicate content

It looks like the Lob template content for the "Breathe Act" letter contains duplicate content:

We should clean that up on the Lob side. 🧹

fixed!


Add NPM 'types' property to package.json

Hello,
Please can you add the 'types' property to your package.json file so Typescript types are automatically discovered by IDEs.
Details here : https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html
As you already have a definition file you just have to point the property to it.
"types": "Typings/xelement.d.ts",
Thanks
Marlon

Added types in package.json


blocks with content length=1 do not display

the content array is empty when blocks have only 1 character in them.

Ive been poking around and might have found the solution. It seems to work, but i dont fully understand what is happening here ;P
https://github.com/lokiuz/redraft/pull/1

#1 fixed it.


fix

tbGridComponents
tbHttpSpec
tbRowSelectable

Coverage decreased (-0.07%) to 76.622% when pulling bf99553cb5113f959b471955b12b0535fceef038 on chubbsnes65:master into d3bfd9ebc1e0683a729adcfeb471aadaf5141355 on unosquare:master.


Updated some files for better GUI

Check the GUI please #40

Completed all of the tasks, you can review them and let me know for any further changings


Added 4 Leetcode Questions (Q 7,11,13,42)

Added 4 Leetcode Questions (Q 7,11,13,42)

Sorry to inform but this repository has been excluded from hacktoberfest. So inorder to make your PR count towards hacktoberfest, request you to make your contribution in this repository -> https://github.com/SR-Sunny-Raj/Hacktoberfest2022-for-all


Why not use ORT built-in SPDX report?

I'm looking into license scanning solutions and I already found ORT as a batteries-included solution around scancode-toolkit. This repo was linked as an example for a github action, which is still a todo there.
Looking into your solution I noticed you use your own spdx-builder. Why did you choose a roll-your-own solution, rather than the built-in spdx report from ORT? Was this a timing issue that it was not yet available in ORT?
Also: thanks for developing this in public, it is an interesting solution that has some nice ideas like pushing the SPDX documents to a central repo.

We're doing research on the matter, and we found that in order to fully understand the world of SBOM, we need to do some investigation ourselves.
We're choosing another approach to getting the SBOM. We're using ORT for getting the dependency structures for projects (as input for SPDX-builder. SPDX-builder uses the License-scanner with scancode to get more detailed information about the actual licenses in the source. This is a deployed service which does this in the background with a way of concluding the licenses with a ui.. difference between declared / detected and concluded licenses.
The SPDX-builder tool outputs a SPDX file which can be imported into Bom-Bar where you can check against policies depending on the deploy context.
THIS IS ALL EXPERIMENTAL AND NOT USED IN PRODUCTION
We're also comparing the spdx outputs with blackduck (SPDX-builder can produce a SPDX file from a blackduck output) and other tools.
In Philips we have a lot of different type of projects / setups. So using this setup we've learned a lot about how you can create a SPDX file from an existing project.
We found that it's very difficult to have a tool give the right SBOM if it does not know the context of a project. Often results from a tool need to be checked / filtered by an application expert on what's really in the code.
That's why we're now experimenting with shifting the burden of delivering a proper (easy to generate and readable) tree of dependencies for a project to the application expert.
Almost any package tool can produce a list of dependencies during buildtime. Something like: mvn dependency:tree for maven. See https://github.com/philips-software/spdx-builder/blob/develop/src/main/resources/treeformats.yml
If you have a project with multiple technologies in it, you can combine these outputs and feed them into SPDX-builder. SPDX-builder will send the information to another service called Bom-base which is a knowledge base. Bom-base will replace the functionality of License-scanner. It will search all kind of sources for the truth. It uses ClearlyDefined to get the source. It uses Scancode to get the licenses. It uses harvesters to get information from the package managers like pypi. And so on.
The data is send to SPDX-builder and SPDX-builder will create a nice SPDX document of it, which you can use in your checks.
The key difference is that the scan environment only needs to know it's own build environment. No more detect scanners with a certain version of dotnet in it which perform some magic. No more magic detection of how a developer setup his python project, which is often not standarised. We need to involve the application expert anyways, so let's make him co-owner of the SBOM by asking her what dependencies there are in the project. We convert them to the latest purl spec or whatever is necessary.
Again, this is all experimental and we're testing it with a lot of different internal projects. We want to minimize the impact on the projects and we want to create various views on the SBOM for different people. Legal should see about conflicts in compatible licenses.. Security should see about vulnerabilities. An Export Control officer should see if some 'dangerous' packages are used and the developer should have a feeling the tools are supporting her work instead of adding work to her already busy agenda.
More on the Tree-based part: https://github.com/philips-software/spdx-builder/blob/develop/docs/usage_with_tree.md
We're planning to deploy OSS versions of the tools so we can also demo this to others.

Thanks for the detailed response. It is interesting. I'm also looking into a setup where the 'application experts' are responsible for generating and submitting the SPDX files. Byt your idea of still scanning on a central level sounds interesting. The infrastructure becomes somewhat more complex (moving parts at the teams and at the central level), but it seems to make sense. Anyway, thanks for your work in this area, it is inspiring!


can not find

Trying to load the data using Angular 2 with clusterize js but unable to load it. here my js fiddle https://jsfiddle.net/ba5pk1dg/
Can you please provide inputs

@klmuralimohan If you look at the console output in the browser's developer tools for the provided fiddle, there are multiple 404 errors.  Try loading the external libraries using resources, the same way clusterize is loaded.  This is not a clusterize.js bug.

ok thank you. Please find the similar thread which is created https://github.com/NeXTs/Clusterize.js/issues/166


CI: Miri test causes a complie error with Rust nightly-2023-05-27

https://github.com/moka-rs/moka/actions/runs/5098288414/jobs/9165346113
/home/runner/.cargo/bin/rustup toolchain install nightly --component miri --allow-downgrade
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: latest update on 2023-05-27, rust version 1.71.0-nightly (1a5f8bce7 2023-05-26)
...

  nightly-x86_64-unknown-linux-gnu installed - rustc 1.71.0-nightly (1a5f8bce7 2023-05-26)
...

Run actions-rs/cargo@v1
/home/runner/.cargo/bin/cargo miri test deque
Running `"rustup" "component" "add" "rust-src"` to install the `rust-src` component for the selected toolchain.
info: downloading component 'rust-src'
info: installing component 'rust-src'
Preparing a sysroot for Miri (target: x86_64-unknown-linux-gnu)... done
    Updating crates.io index
 Downloading crates ...
...
  Compiling proc-macro2 v1.0.59
...
error: to use a constant of type `core::any::TypeId` in a pattern, `core::any::TypeId` must be annotated with `#[derive(PartialEq, Eq)]`
Error:   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/value-bag-1.0.0-alpha.9/src/internal/cast/primitive.rs:43:33
   |
43 |                                   $const_ident => |v| Some(Internal::from(unsafe { &*(*v as *const Self as *const $ty) })),
   |                                   ^^^^^^^^^^^^
...
71 | /         to_internal![
72 | |             usize: (USIZE, OPTION_USIZE),
73 | |             u8: (U8, OPTION_U8),
74 | |             u16: (U16, OPTION_U16),
...  |
96 | |             String: (STRING, OPTION_STRING),
97 | |         ];
   | |_________- in this macro invocation
   |
   = note: the traits must be derived, manual `impl`s are not sufficient
   = note: see https://doc.rust-lang.org/stable/std/marker/trait.StructuralEq.html for details
   = note: this error originates in the macro `to_internal` (in Nightly builds, run with -Z macro-backtrace for more info)

$ cargo tree -i value-bag
value-bag v1.0.0-alpha.9
└── log v0.4.17
 ...

I tested locally and found that the followings worked:
$ cargo +nightly-2023-05-24 miri test timer_wheel
$ cargo +nightly-2023-05-24 miri test timer_wheel

We will use that version it the CI until the compile error issue is addressed.

A new version of log crate has been released and it no longer depends on the value-bag version that had the issue:
$ cargo update
$ cargo tree -i value-bag
value-bag v1.4.0
└── log v0.4.18

I confirmed that Miri now compiles with the latest Rust nightly:
$ cargo +nightly miri test deque
$ cargo +nightly miri test timer_wheel

$ rustc +nightly -V
rustc 1.72.0-nightly (dd5d7c729 2023-06-02)


PELEDGE19-425 Added AccountID and edgecore status in info command

What Changed in "info"?

New jsonParse function Added
In account function added accountID and edge status

@ygoyal18 did you check these changes?

@enggb Looks good. Merging..


Add support for illegal addresses

And added more tests (moving coverage of address.rs over 85%).
Ref https://github.com/many-protocol/specification/pull/85
Fixes #https://github.com/liftedinit/roadmap/issues/19

Codecov Report

Merging #233 (b200466) into main (95ba9a1) will increase coverage by 0.69%.
The diff coverage is 97.97%.

@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
+ Coverage   67.64%   68.34%   +0.69%
==========================================
  Files          85       85
  Lines        9937    10131     +194
==========================================
+ Hits         6722     6924     +202
+ Misses       3215     3207       -8

Impacted Files
Coverage Δ

src/many-identity/src/address.rs
86.42% <96.42%> (+6.06%)
:arrow_up:

src/many-modules/src/_9_account.rs
79.79% <100.00%> (-0.69%)
:arrow_down:

src/many-protocol/src/lib.rs
96.80% <100.00%> (+2.93%)
:arrow_up:

src/many-protocol/src/response.rs
90.44% <100.00%> (+4.40%)
:arrow_up:

src/many-types/src/blockchain.rs
72.41% <0.00%> (-1.15%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Update filter.js

Solve case : https://github.com/angular/angular.js/issues/10991
with using filter and deep object

Just signed a Contributor License Agreement (CLA)

Nice catch, but I don't think the fix is right. The problem is that typeof null returns object which results in following the object path which is not the right thing to do. Just comparing against actualVal if actulaVal is not semantically the same as following the "non-object-nor-function" path, namely delegating comparison to the comparator.
So, the right fix would involve differentiating "real" objects from null.
I would probably change:
var actualType = typeof actual;

with:
var actualType = (actual !== null) ? typeof actual : 'null';   // anything other than "object" or "function"

@ElephantRose: BTW, it would also be great to have a couple of tests should in order to ensure that this is not accidentally broken in the future.

@gkalpak
Hi,
Thanks for your reply.
I just tried your fix and i found a small issue
When I clear the filter's input field, the object with null property value are still filtered (and so not displayed)
It's because the filter value for the user name is not reset to null, but is put to an empty string
Here is a jsfiddle demo : http://jsfiddle.net/ykm0d6f0/13/
The 1rst case, is without fix just for reference
The 2nd one use my first  solution
And the 3rd one use yours, as you can see the last row (the one with null value)  will not be displayed anymore if you enter a user name value.
Sadly I do not have other tests, so  i can't guarantee what i proposed work for every cases.

@ElephantRose: Unfortunately, this is a different issue (not related to this one).
Here is what is going on:

Before the input is touched, there is no prop1 defined on f, so the filtering expression is {}.
After, interracting with the input (and emptying it again) the filtering expression (f) already has this structure: {prop1: {prop2: xyz}}. No matter what you put into xyz ('', null, undefined) it won't match against {prop1: null}.

This is why I said that your original fix changes the semantics of filterFilter.
Whether we want to support a way to make some attributes "optional" (as in "ignored if not present") is another story.
--
So, to recap, there are 2 different issues discussed here:

Treat null as object (and trying to access properties on it).
This is clearly a bug and should be corrected. See https://github.com/angular/angular.js/pull/10992#issuecomment-73227008.

Match item {prop1: null} against filtering expression {prop1: {...}}.
This is not a bug, but rather a "feature" request and would need a breaking change if we decided to support it. And even if we did, a different approach would be needed (than the one proposed in this PR).

--
Regarding (2) (off the top of my head), it might be possible to prefix/suffix a property name with ? to make it optional (not sure if ? in a property name would pose any problems in any of the supported browser).

So, here is what I propose:

Update this PR with the fix mentioned above.
Use a custom comparator to solve your problem #10991 (i.e. a comparator that matches null against anything).
If you still think that having "optional" properties is a feature that should be natively supported by filterFilter, open a separate (feature request) issue.

@gkalpak
I understand the 2nd point is not really an issue... more a side effect.
Frankly i can't even tell myself  in that particulary case if a property with an empty value should be treated (or not) the same way than a null value.
I'll definitely look after custom comparator before opening a feature request.
Thanks for your help

@ElephantRose, so since this PR is not the right fix, would you be interested in submitting a new PR to fix the null issue (based on https://github.com/angular/angular.js/pull/10992#issuecomment-73227008) ?
(If not I will gladly do it myself :))

@gkalpak, I'll be glad to do a new one
And I didn't reply about my 2nd point, but i managed to do it with custom comparator as you suggested.


Update SELECT * to return tag values

Users are getting confused by the fact that SELECT * doesn't include tag values. We should include tag keys in the columns and the tag values in the values array.

why not include them in a tags section? Whatever goes in comes out, and when pushing tags are clearly separate.

@dashesy they are included in the tags section if you add GROUP BY * to the query. The problem is that people don't really know about this so when they do the query and see no tags they think it's broken. I guess we could just update the default behavior to make SELECT * force a GROUP BY *

@pauldix yes that seems to have the least surprise (it threw me off too when I first tried it), it helps to know * will return everything.

I think it could be very useful to to optionally include tags in the results, rather than just in the tags sections.
An example of where this would be used is I have a database of events that happened from multiple machines.  I store data like event_code, device_id, etc in tags.  When I query the data, I might only specify to search for a single device (multiple codes) or a single code (multiple devices).  I want the results to in sequential order (by time).  If you have it in the group by, I have to manually merge the series together to get one list and also know which device or event code it is associated with.  Returning them in the query results would solve this (it would essentially identify which unique series the data originated from).
Also, FYI... When I tried to run a query like SELECT value, my_tag FROM my_series WHERE ..., the server panics and stops (due to the tag being in the select).  I didn't add a bug for this because this and #1989 already exist.

+1

+1


B-spline registration with non uniform control point grid

Hello,
I am trying to perform a Bspline registration with a non uniform grid spacing. Is it possible in SimpleElastix?

No, B-Spline registration is only supported on a uniform grid. You might want to take a look at the SplineKernelTransform if you need non-uniform grids.

No, B-Spline registration is only supported on a uniform grid. You might want to take a look at the SplineKernelTransform if you need non-uniform grids.


test(firestore): error handling for loadBundle() & namedQueryGet()

Description
Requires this test API PR to be merged first.
Follow up PR to test error handling for namedQueryGet() & loadBundle() API.
Related Issues
none.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[ ] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] The analyzer (melos run analyze) does not report any problems on my PR.
[ ] I read and followed the Flutter Style Guide.
[ ] I signed the CLA.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change.

Added some comments about the error handling, otherwise LGTM


Take into account case insensitivity

Names of functions, classes, or methods are case insensitive in PHP. But for VS Code PHP IntelliSense, they are.
For example, if you name function abc(), you wont find its definition or references if you use it like ABC().

Duplicate of https://github.com/felixfbecker/php-language-server/issues/69


Can't verify CSRF Token authenticity - 422 Unprocessable Entity

Hello,
I'm working on a project that consists of a client side angularjs app and server side rails app.
The users need to authenticate to access the app contents, so I chose devise to deal with the authentication.
I followed the installation instructions on github's readme, and I think everything is set up properly.
In my angularjs app login function i do $http.post('/users/sign_in.json', { "email"<EMAIL_ADDRESS>"password": '987654321'}) and i get
POST http://localhost:3000/users/sign_in.json 422  (Unprocessable Entity).
On the server side, I get this error message:
Started POST "/users/sign_in.json" for <IP_ADDRESS> at 2014-09-09 17:30:18 +0100
Processing by Devise::SessionsController#create as JSON
Parameters<EMAIL_ADDRESS>"password"=>"[FILTERED]", "session"=>{"
<EMAIL_ADDRESS>"password"=>"[FILTERED]"}}
Can't verify CSRF token authenticity
Completed 422 Unprocessable Entity in 1ms
I also tried with CURL and i get the same error messages.
Can you guys please help me? I'm stuck with this for almost 3 days... I can't find a working solution anywhere... I think I tried everything!

To further documents my findings, I had a similar issue with ember-cli and didn't find an obvious answer. This post helped me: https://www.adibsaad.com/blog/setting-up-ember-cli-with-a-rails-back-end-and-token-authentication-authorization


Error building firmware

Hi,
I am following the introductory tutorial from the website. I tried it in a Docker container and in a fresh install of Ubuntu 20.04. I am failing to execute the step:

ros2 run micro_ros_setup build_firmware.sh

The error:
In file included from /home/humboldt/micro2/src/uros/micro-ROS-demos/rclc/autodiscover_agent/main.c:11: /home/humboldt/micro2/src/uros/rmw_microxrcedds/rmw_microxrcedds_c/include/rmw_uros/options.h:22:10: fatal error: ucdr/microcdr.h: No such file or directory    22 | #include <ucdr/microcdr.h>
And the final output of colcon:
Summary: 29 packages finished [6min 23s]   1 package failed: micro_ros_demos_rclc   4 packages aborted: micro_ros_demos_rclcpp nav_msgs sensor_msgs visualization_msgs   2 packages had stderr output: micro_ros_demos_rclc micro_ros_demos_rclcpp   2 packages not processed
Additional information
Yesterday the repository was also failing, but the error was in rmw-microxrcedds.
The error was the number of parameters in the function uxr_init_serial_transport. I removed &context_impl->udp_platform from rmw_microxrcedds_c/src/rmw_init.c and rmw_microxrcedds_c/src/rmw_uros_options.c and it worked (a similar fix was introduced in commit).

Following the error, the problem that I have is related with this include in rmw-microxrcedss:

Hello @h-valdes we are aware of this. Please wait a couple of hours because we are updating some repos and we will fix this. Sorry for the inconvenience.

No Problem! Thanks for the quick answer!

I will notify you here when this is solved.

Hello, you should be able to try it now.
I'm closing, do not hesitate to reopen if you have any problem.

@pablogs9 Thanks a lot, it works! I did a test of the basic example and also with the esp32 firmware.
Both are working.
Thank you!


[Improve][Zeta] Move SaveMode behavior to master

Purpose of this pull request
This PR move savemode logic into master node.
Mainly for two purposes:

Maintain the same behavior as the Rest submit job. Before this, the SaveMode logic of Rest mode was executed on the master, but the client mode was executed on the client side.
Prepare for related SaveMode event processing. Based on purpose 1, we can ensure consistent behavior of SaveMode related events.

Does this PR introduce any user-facing change?
no

How was this patch tested?
add new test.

Check list

[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

Please fix ci error

Please fix ci error

done


Tests fail on Linux Mint 19.2

Tests fail with the following message:
Must specify something as a path: did you mean '.' for the current directory?
  in sub guess_library_name at /home/vrurg/raku/share/perl6/core/sources/947BDAB9F96E0E5FCCB383124F923A6BF6F8D76B (NativeCall) line 225
  in method setup at /home/vrurg/raku/share/perl6/core/sources/947BDAB9F96E0E5FCCB383124F923A6BF6F8D76B (NativeCall) line 285
  in block  at /home/vrurg/raku/share/perl6/core/sources/947BDAB9F96E0E5FCCB383124F923A6BF6F8D76B (NativeCall) line 594
  in method outline at /home/vrurg/src/Raku/Font-FreeType-p6/lib/Font/FreeType/Native.pm (Font::FreeType::Native) line 246
  in method outline at /home/vrurg/src/Raku/Font-FreeType-p6/lib/Font/FreeType/GlyphImage.pm (Font::FreeType::GlyphImage) line 49
  in block <unit> at t/00-basic.t line 41

libfreetype6 and libfreetype6-dev packages are installed:
Package: libfreetype6
Version: 2.8.1-2ubuntu2

Package: libfreetype6-dev
Version: 2.8.1-2ubuntu2

> ll /usr/lib/x86_64-linux-gnu/libfreetype.*
-rw-r--r-- 1 root root 1037428 Apr 12  2018 /usr/lib/x86_64-linux-gnu/libfreetype.a
-rw-r--r-- 1 root root     906 Apr 12  2018 /usr/lib/x86_64-linux-gnu/libfreetype.la
lrwxrwxrwx 1 root root      21 Apr 12  2018 /usr/lib/x86_64-linux-gnu/libfreetype.so -> libfreetype.so.6.15.0
lrwxrwxrwx 1 root root      21 Apr 12  2018 /usr/lib/x86_64-linux-gnu/libfreetype.so.6 -> libfreetype.so.6.15.0
-rw-r--r-- 1 root root  735704 Apr 12  2018 /usr/lib/x86_64-linux-gnu/libfreetype.so.6.15.0

Tried on a 32-bit Mint 19.3 with libfreetype6 and libfreetype-dev version 2.81 against Rakudo blead.
Haven't been able to replicate the error yet.
Appears to happen Font::FreeType::Native line 246 when trying to resolve symbol "ft6_glyph_outline"from the wrapper library "libft6,so: that should have been built by Build.pm.
$ perl6 -I . -MFont::FreeType::Native -e'say Font::FreeType::Native::FT-WRAPPER-LIB'
/home/david/git/Font-FreeType-p6/resources/libraries/libft6.so
$ ls -l resources/libraries/
total 20
-rwxr-xr-x 1 david david 16552 Jan 13 07:54 libft6.so

I can manually access the symbol without an error:
$ perl6 -MFont::FreeType::Native -MNativeCall -e'cglobal(Font::FreeType::Native::FT-WRAPPER-LIB, "ft6_glyph_outline", Pointer)'

Are you getting similar results?

I just realized that it was my bad in first place: I forgot about zef build. Perhaps, it worth adding a note about it to README.md. Still, as long as the previous failure was coming from zef install I guess there was a problem of some kind.
Pulling master and building makes tests passing ok. Closing.
Thank you!

Have added some notes to the README and sanity tests to t/00basic.t that freetype is installed and bindings have been built. Uploaded to CPAN


[BUG] Open On Load setting not persistant on remote clients

Describe the bug
Upon connecting to the Foundry server, remote clients accessing the server (through a browser) are met with the calendar opening by itself. Entering the configuration menu and turning 'Open On Load' to false will not stop this behavior, as that setting does not persist between sessions of play.
To Reproduce
Steps to reproduce the behavior:

Host starts Foundry VTT server
Remote client logs on to the server, calendar auto-opens
Remote client turns off 'Open On Load'
Remote client closes their browser
Host closes the server
Host restarts the server again
Remote client logs on to the server, calendar auto-opens. 'Open On Load' can be found set to 'On' in the configuration menu.

Expected behavior
The Open on Load setting should persist between sessions, so that a user accessing the server remotely doesn't have the calendar auto-open on load every time.
Screenshots

Foundry Information

Foundry Version: 10, build 291
Game System: DnD5e version 2.15
Simple Calendar Version: 2.1.80

Browser (please complete the following information):

Browser: Chrome, Firefox

Additional context
As the host of the server, I can confirm all my remote players have this issue.

Having some trouble locating the source of the bug. Even changing the default values of 'openOnLoad' to 'false' doesn't seem to solve the issue.
Suggesting a hasty but effective solution in #489


ENH: pass minimizer params in scipy.optimize.differential evolution

Reference issue
Closes #13561
What does this implement/fix?
This allows the user to specify the deterministic minimization method for differential_evolution just like
it is done dual_annealing or shgo.

I've started a discussion in #13561 to see whether the feature is worth adding.


NMS op causing poor performance in tf2 models

This is a follow up to the PR #8174 by @masahi. Some of the tf2-tvm object detection (OD) models performed poorer than just tf2 framework. Following are the numbers observed. TF-TVM latency is on models that are post processed with combined-nms

Model
TF-TVM Latency(ms)
TF latency (ms)
Boxes Shape
Scores Shape

ssd_mobilenet_v1_fpn_640x640_1_nms
377.20
203.31
(1, 51150, 1, 4)
(1, 51150, 90)

efficientdet_d0_1_nms
333.01
140.92
(1, 49104, 1, 4)
(1, 49104, 90)

GPU activities for ssd_mobilenet_v1_fpn_640x640_1_nms
"GPU activities",71.961571,2.649234,10,264.923361,256.370119,274.001845,"fused_vision_all_class_non_max_suppression_kernel2"
"GPU activities",9.830572,0.361908,160,2.261926,0.870473,7.882956,"volta_scudnn_winograd_128x128_ldg1_ldg4_relu_tile148t_nt_v1"
"GPU activities",2.893616,0.106527,70,1.521816,0.068355,7.010179,"trt_volta_scudnn_winograd_128x128_ldg1_ldg4_relu_tile148t_nt_v1"

GPU activities for efficientdet_d0_1_nms
"GPU activities",79.611974,2.520980,10,252.097991,246.456348,261.662513,"fused_vision_all_class_non_max_suppression_kernel2"
"GPU activities",3.295807,0.104364,160,0.652278,0.038498,5.779056,"void cuReduceLayer::nonTailReduceExcludeW<int=32, nvinfer1::ReduceOp, float, float>(float*, cuReduceLayer::nonTailReduceExcludeW<int=32, nvinfer1::ReduceOp, float, float> const *, cuReduceLayer::LaunchParams)"
"GPU activities",1.695395,0.053686,40,1.342152,1.012731,1.530201,"void thrust::cuda_cub::cub::DeviceRadixSortDownsweepKernel<thrust::cuda_cub::cub::DeviceRadixSortPolicy<float, long, int>::Policy700, bool=0, bool=1, float, long, int>(thrust::cuda_cub::cub::DeviceRadixSortPolicy<float, long, int>::Policy700 const *, thrust::cuda_cub::cub::DeviceRadixSortDownsweepKernel<thrust::cuda_cub::cub::DeviceRadixSortPolicy<float, long, int>::Policy700, bool=0, bool=1, float, long, int>*, bool=0 const *, thrust::cuda_cub::cub::DeviceRadixSortDownsweepKernel<thrust::cuda_cub::cub::DeviceRadixSortPolicy<float, long, int>::Policy700, bool=0, bool=1, float, long, int>**, bool=1*, thrust::cuda_cub::cub::DeviceRadixSortDownsweepKernel<thrust::cuda_cub::cub::DeviceRadixSortPolicy<float, long, int>::Policy700, bool=0, bool=1, float, long, int>**, int, int, thrust::cuda_cub::cub::GridEvenShare<thrust::cuda_cub::cub::DeviceRadixSortDownsweepKernel<thrust::cuda_cub::cub::DeviceRadixSortPolicy<float, long, int>::Policy700, bool=0, bool=1, float, long, int>**>)"

Did you encounter these input shapes before and notice the same performance issues, do you think there is anything different we can do to optimize this input shape case? @masahi

Yes, I'm aware that TF2 models have large number of input boxes and our NMS becomes a bottleneck. I think our NMS needs further improvement in general. cc @trevor-m
Two questions:

Do you have numbers for TF-TVM before https://github.com/apache/tvm/pull/8174? You can disable the new conversion in 8174 by changing https://github.com/apache/tvm/blob/main/python/tvm/relay/frontend/tensorflow_ops.py#L914 to if False:.
Does TF latency number include CPU time? Because I heard that TF doesn't support running combined NMS on GPU.


Fix rsp body closing on error and empty buffer flush to agent

Fixes closing the response body on error too
Fixes sending empty requests to the agent every second when the buffer is empty
Moves the agent/recorder state logic to the senders

Looks great @boyand.  I'll just test manually on a local dev stack as last verification and then merge.  Thanks for the fixes/improvements


Writing to SSBO causes rendering to fail

We have a test case in Amber which currently fails on MoltenVK. The below amber test fails on MoltenVk with data_set1_binding0_result = .5; enabled (I haven't tested the reduction on Linux as I don't have access for the next week). Commenting out that line and the framebuffer has the correct colour. With that line enabled the framebuffer just contains the clear colour, not the colour from the fragment shader.
Issue https://github.com/google/amber/issues/216.
[require]
vertexPipelineStoresAndAtomics

[vertex shader]
#version 430

layout(location = 0) in vec4 position;

layout(set = 1, binding = 0) buffer block1 {
  float data_set1_binding0_result;
};

void main() {
  gl_Position = position;
  // comment out next line and test passes
  data_set1_binding0_result = .5;
}

[fragment shader]
#version 430

layout(location = 0) out vec4 final_color;

void main() {
  final_color = vec4(0.5, 0.25, 0.124, 0);
}

[vertex data]
#      position
0/R32G32_SFLOAT

#      R32  G32
      -1.0 -1.0
       1.0  1.0
      -1.0  1.0

      -1.0 -1.0
       1.0  1.0
       1.0 -1.0

[test]
clear color .5 .5 .5 .5
clear

ssbo 1:0 subdata float 0 0

draw arrays TRIANGLE_LIST 0 6
relative probe rect rgba (0.0, 0.0, 1.0, 1.0) (.5 .25 .124 0)

This is a known limitation of Metal (rdar://48348476). For whatever reason, Metal vertex shaders cannot simultaneously write to a buffer and return a value to the rasterizer.

I've registered this as something the Vulkan portability initiative might address to identify for a particular implementation...and I'm closing this as a MoltenVK issue.


sh: 1: Syntax error: Unterminated quoted string

os.system("echo %s"%(shell_escape("Hello 'world'"),))
-> sh: 1: Syntax error: Unterminated quoted string

I've made a PR at #24 which seems to address to the same issue

fixed in #24


Refactor tests to utilize full Cobra command backend

This PR refactors ec-cli's tests to utilize the modular Cobra command hierarchy introduced in #1010. Resolves #1011.

This is now ready. Tests do pass as is.
One potential improvement I could make would be to store the branch commands for each test (eg. validate image) in a global variable, then append specific arguments to that per test. Thoughts?

Thoughts?

Merge as is, if we find the need for global variables we can refactor...


Integration tests

From #52
We currently only have unit tests (some of which actually go pretty far to do integration test kind of checks against dummy back-ends), but it would be good if there was also a bit of real integration tests against real back-ends

Idea to be covered:
merging of collections (#5)  could trigger some warnings or even errors (e.g. incompatible metadata from upstream providers). An integration test could check for these warnings/errors

#76  added initial reporting tool for collection and process metadata merging issues. This should be integrated in the integration tests

To start this task simple:

create basic pytest based test suite skeleton in top level folder integration-tests, largely based on https://github.com/Open-EO/openeo-geopyspark-integrationtests, but much simpler (just the part to get root URL from an env var).
some simple tests:

simple test to check if https://openeocloud.vito.be/openeo/1.0/ returns with something sensible
does /collections look ok?
does /processes look ok?

just merged initial skeleton of PR #104
next steps:

Figure out how to do get authenticated connection (without exposing secrets in this repo)
set up jenkins flow to run this regularly or trigger based (e.g. pre-release check)

I've set up basic configs for running integration tests in jenkins (triggered at end of normal openeo-aggregator run)

next step of working with authenticated connection is probably best done through https://github.com/Open-EO/openeo-python-client/issues/419


Unexpected token *

I installed<EMAIL_ADDRESS>to my project and when I try to run my project it fails with a syntax error.
import * as RTFJS from './dist/RTFJS.bundle';
^
SyntaxError: Unexpected token *
I added "type": "module" to my package.json and added --experimental-modules to my start script.
I changed the version to 2.3.3
Everything I have attempted I get the same error. Any ideas on what I am doing incorrectly

Have you tried importing it as described in the Getting Started Guide (i.e. import {EMFJS, RTFJS, WMFJS} from 'rtf.js';)?

The error is not in the code itself but coming from the rtf.js index file from my node_modules.
/node_modules/rtf.js/index.js:27
import * as RTFJS from './dist/RTFJS.bundle';
I forgot to mention I am trying to use this in a nest service and not a front end application

If you want to use the library server side you will have to use jsdom as described here.

OK thank you for your help. I will look into that


[CCI] Update DEVELOPER_GUIDE.md.

Description
add docker installation and run commands to DEVELOPER_GUIDE.md.
Issues Resolved
issue #341 resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Can you please rebase/resolve conflicts. Make sure PR numbers match. Thanks!

@roma2023 Please resolve the conflicts on this PR by merging the latest changes from the main branch.

@roma2023 Looks like you're dragging in a bunch of other changes.
https://code.dblock.org/2015/08/31/getting-out-of-your-first-git-mess.html might be helpful?

Hello, @roma2023. Thank you for your contribution to the opensearch-py repository. Please make the following modifications:

Add a change log entry.
DCO has not been signed. When committing, use the -s flag. For example git commit -s -m "Updated Developer_Guide".
Merge all commits into single commit. If you have trouble, close this PR and create a new PR.

Thanks.

This PR was closed due to unknown "git mess," I have tried to tackle it in different ways but the issue was not gone. I will try to create a new PR with the up-to-date version of the master, I hope this will solve it. Please let me know if you have any questions regarding this PR. Thank you for your support!

Speaking of git mess, https://code.dblock.org/2015/08/31/getting-out-of-your-first-git-mess.html may be helpful.


Basic

Changes

refactor(alert): get dismiss button from children
chore: reformat license

This pull request introduces 1 alert when merging d7ac055f3c228332a94a0de6c412ddc83cfc7f10 into d793bbbcdb9094558c54823d7a669ffb3945945a - view on LGTM.com
new alerts:

1 for Unused variable, import, function or class

Comment posted by LGTM.com


Update migration workflow to implement 2 stage approach for copy

This PR significantly reworks the migration workflow. The main change is that instead of having just 1 backup and 1 restore, we have 2 backups and 2 restores. The workflow goes like this:

Backup 1: Captures all resources in the targeted namespaces. This is called InitialBackup. This backup explicitly sets includePersistentVolumes: false so it only captures resource state, no PV data at all. This backup is not run on stage migrations.

Create Stage Pods: This creates staging "dummy" pods for all pods that have restic annotations. These will be used to copy PV data. The stage pods are rhel7 pods that mount the same volumes.

Quiesce source application: This does not run on stage

Backup 2: Captures only PVs, PVCs, and Stage Pods. For copy, this will perform restic backup/restore on the staging pods. For move this will simply swing the PV over

Restore 1: Runs a restore of Backup 2. This copies all PVCs and PV data over and brings the staging pods to the destination cluster.

Delete stage pods: This deletes all staging rhel7 pods on both source and destination clusters

Restore 2: Runs a restore of Backup 1. This brings all application resources over including the original application pods.

Future Enhancements

We could run a check on all PVs to see if there are zero copy PVs specified. If there are none, we could simple do the old approach with 1 backup and 1 restore. The backup will set includePersistentVolumes to true

@dymurray how far does this go in implementing copy? Is this a complete implementation?

LGTM, @dymurray!
Deferring to @djwhatle for approval.

I'm still investigating the failure, but so far on a basic "stateless" scenario I'm getting failed migrations on phase StageRestoreFailed. Inspecting the respective restore shows that it is PartiallyFailed.
Errors:
  Velero:   backup does not contain top level resources directory

Going to proceed to other scenarios and see if I get different results. It is desired that this PR will not break existing known working migration scenarios even though it is dramatically changing the flow of migrations to support copy.

@jortel and I are currently hitting an issue attempting to migrate using copy from NFS to EBS while running the StageBackup.
{"level":"info","ts":1561568366.717578,"logger":"migration|rncwx","msg":"Migration: waiting.","name":"migmigration-sample","phase":"WaitOnResticRestart","backup":"","restore":""}
{"level":"info","ts":1561568371.3125923,"logger":"migration|qf2tv","msg":"Migration: resumed.","name":"migmigration-sample","phase":"WaitOnResticRestart"}
{"level":"info","ts":1561568371.3126671,"logger":"migration|qf2tv","msg":"Waiting for restic pod to be ready"}
{"level":"info","ts":1561568371.3128345,"logger":"migration|qf2tv","msg":"Migration: waiting.","name":"migmigration-sample","phase":"WaitOnResticRestart","backup":"","restore":""}
{"level":"info","ts":1561568376.723304,"logger":"migration|vpcjf","msg":"Migration: resumed.","name":"migmigration-sample","phase":"WaitOnResticRestart"}
{"level":"info","ts":1561568376.7233653,"logger":"migration|vpcjf","msg":"Waiting for restic pod to be ready"}
{"level":"info","ts":1561568376.7235482,"logger":"migration|vpcjf","msg":"Restic pod successfully restarted"}
{"level":"info","ts":1561568376.7410655,"logger":"migration|vpcjf","msg":"Migration: waiting.","name":"migmigration-sample","phase":"InitialBackupStarted","backup":"migmigration-sample-n54fd","restore":""}
{"level":"info","ts":1561568380.1979518,"logger":"migration|wjff7","msg":"Migration: resumed.","name":"migmigration-sample","phase":"InitialBackupStarted"}
{"level":"info","ts":1561568380.1982908,"logger":"migration|wjff7","msg":"Migration: waiting.","name":"migmigration-sample","phase":"InitialBackupStarted","backup":"migmigration-sample-n54fd","restore":""}
{"level":"info","ts":1561568389.862849,"logger":"migration|v7xz2","msg":"Migration: resumed.","name":"migmigration-sample","phase":"InitialBackupStarted"}
{"level":"info","ts":1561568389.8975227,"logger":"migration|v7xz2","msg":"Migration: waiting.","name":"migmigration-sample","phase":"CreateStagePodsStarted","backup":"migmigration-sample-n54fd","restore":""}
{"level":"info","ts":1561568398.6692595,"logger":"migration|fvlmv","msg":"Migration: resumed.","name":"migmigration-sample","phase":"CreateStagePodsStarted"}
{"level":"info","ts":1561568398.695923,"logger":"migration|fvlmv","msg":"Migration: waiting.","name":"migmigration-sample","phase":"CreateStagePodsStarted","backup":"migmigration-sample-n54fd","restore":""}
{"level":"info","ts":1561568408.0310137,"logger":"migration|j29gp","msg":"Migration: resumed.","name":"migmigration-sample","phase":"CreateStagePodsStarted"}
{"level":"info","ts":1561568408.0593767,"logger":"migration|j29gp","msg":"Migration: waiting.","name":"migmigration-sample","phase":"CreateStagePodsStarted","backup":"migmigration-sample-n54fd","restore":""}
{"level":"info","ts":1561568416.996085,"logger":"migration|dcts9","msg":"Migration: resumed.","name":"migmigration-sample","phase":"CreateStagePodsStarted"}
{"level":"info","ts":1561568417.0266328,"logger":"migration|dcts9","msg":"Migration: waiting.","name":"migmigration-sample","phase":"StageBackupStarted","backup":"migmigration-sample-n54fd","restore":""}
{"level":"info","ts":1561568426.545885,"logger":"migration|57b5b","msg":"Migration: resumed.","name":"migmigration-sample","phase":"StageBackupStarted"}
{"level":"info","ts":1561568426.5637126,"logger":"migration|57b5b","msg":"Migration: waiting.","name":"migmigration-sample","phase":"StageBackupFailed","backup":"migmigration-sample-n54fd","restore":""}

time="2019-06-26T17:00:17Z" level=info msg="[common-backup] Entering common backup plugin" backup=velero/migmigration-sample-th4tp cmd=/plugins/velero-plugins logSource="/go/src/github.com/fusor/ocp-velero-plugin/velero-plugins/common/backup.go:25" pluginName=velero-plugins
time="2019-06-26T17:00:17Z" level=info msg="Executing custom action" backup=velero/migmigration-sample-th4tp group=v1 logSource="pkg/backup/item_backupper.go:307" name=pv8 namespace=mysql-persistent resource=pods
time="2019-06-26T17:00:17Z" level=info msg="[pv-backup] Entering Persistent Volume backup plugin" backup=velero/migmigration-sample-th4tp cmd=/plugins/velero-plugins logSource="/go/src/github.com/fusor/ocp-velero-plugin/velero-plugins/pv/backup.go:30" pluginName=velero-plugins
time="2019-06-26T17:00:17Z" level=info msg="Executing takePVSnapshot" backup=velero/migmigration-sample-th4tp group=v1 logSource="pkg/backup/item_backupper.go:372" name=pv8 namespace=mysql-persistent resource=pods
time="2019-06-26T17:00:17Z" level=info msg="Skipping persistent volume snapshot because volume has already been backed up with restic." backup=velero/migmigration-sample-th4tp group=v1 logSource="pkg/backup/item_backupper.go:390" name=pv8 namespace=mysql-persistent persistentVolume
=pv8 resource=pods
time="2019-06-26T17:00:17Z" level=info msg="Executing custom action" backup=velero/migmigration-sample-th4tp group=v1 logSource="pkg/backup/item_backupper.go:307" name=mysql namespace=mysql-persistent resource=pods
time="2019-06-26T17:00:17Z" level=info msg="[common-backup] Entering common backup plugin" backup=velero/migmigration-sample-th4tp cmd=/plugins/velero-plugins logSource="/go/src/github.com/fusor/ocp-velero-plugin/velero-plugins/common/backup.go:25" pluginName=velero-plugins
time="2019-06-26T17:00:17Z" level=info msg="Executing custom action" backup=velero/migmigration-sample-th4tp group=v1 logSource="pkg/backup/item_backupper.go:307" name=mysql-1-ff8xn-stage-pod namespace=mysql-persistent resource=pods
time="2019-06-26T17:00:17Z" level=info msg="[common-backup] Entering common backup plugin" backup=velero/migmigration-sample-th4tp cmd=/plugins/velero-plugins logSource="/go/src/github.com/fusor/ocp-velero-plugin/velero-plugins/common/backup.go:25" pluginName=velero-plugins
time="2019-06-26T17:00:21Z" level=info msg="1 errors encountered backup up item" backup=velero/migmigration-sample-th4tp group=v1 logSource="pkg/backup/resource_backupper.go:265" name=mysql-1-ff8xn-stage-pod namespace=mysql-persistent resource=pods
time="2019-06-26T17:00:21Z" level=error msg="Error backing up item" backup=velero/migmigration-sample-th4tp error="pod volume backup failed: error getting volume path on host: expected one matching path, got 0" error.file="/go/src/github.com/heptio/velero/pkg/restic/backupper.go:173" error.function="github.com/heptio/velero/pkg/restic.(*backupper).BackupPodVolumes" group=v1 logSource="pkg/backup/resource_backupper.go:269" name=mysql-1-ff8xn-stage-pod namespace=mysql-persistent resource=pods

I also had trouble running an NFS move with this PR currently, the app on the destination side failed to start up with error despite quiescing on the source side:
2019-06-26T15:25:59.189006Z 0 [ERROR] InnoDB: The innodb_system data file 'ibdata1' must be writable

I was able to reproduce this multiple times, and noted that it does not occur on current master. We will need to resolve this and the above issues before merging.

@jortel and I are currently hitting an issue attempting to migrate using copy from NFS to EBS while running the StageBackup.
{"level":"info","ts":1561568366.717578,"logger":"migration|rncwx","msg":"Migration: waiting.","name":"migmigration-sample","phase":"WaitOnResticRestart","backup":"","restore":""}
{"level":"info","ts":1561568371.3125923,"logger":"migration|qf2tv","msg":"Migration: resumed.","name":"migmigration-sample","phase":"WaitOnResticRestart"}
{"level":"info","ts":1561568371.3126671,"logger":"migration|qf2tv","msg":"Waiting for restic pod to be ready"}
{"level":"info","ts":1561568371.3128345,"logger":"migration|qf2tv","msg":"Migration: waiting.","name":"migmigration-sample","phase":"WaitOnResticRestart","backup":"","restore":""}
{"level":"info","ts":1561568376.723304,"logger":"migration|vpcjf","msg":"Migration: resumed.","name":"migmigration-sample","phase":"WaitOnResticRestart"}
{"level":"info","ts":1561568376.7233653,"logger":"migration|vpcjf","msg":"Waiting for restic pod to be ready"}
{"level":"info","ts":1561568376.7235482,"logger":"migration|vpcjf","msg":"Restic pod successfully restarted"}
{"level":"info","ts":1561568376.7410655,"logger":"migration|vpcjf","msg":"Migration: waiting.","name":"migmigration-sample","phase":"InitialBackupStarted","backup":"migmigration-sample-n54fd","restore":""}
{"level":"info","ts":1561568380.1979518,"logger":"migration|wjff7","msg":"Migration: resumed.","name":"migmigration-sample","phase":"InitialBackupStarted"}
{"level":"info","ts":1561568380.1982908,"logger":"migration|wjff7","msg":"Migration: waiting.","name":"migmigration-sample","phase":"InitialBackupStarted","backup":"migmigration-sample-n54fd","restore":""}
{"level":"info","ts":1561568389.862849,"logger":"migration|v7xz2","msg":"Migration: resumed.","name":"migmigration-sample","phase":"InitialBackupStarted"}
{"level":"info","ts":1561568389.8975227,"logger":"migration|v7xz2","msg":"Migration: waiting.","name":"migmigration-sample","phase":"CreateStagePodsStarted","backup":"migmigration-sample-n54fd","restore":""}
{"level":"info","ts":1561568398.6692595,"logger":"migration|fvlmv","msg":"Migration: resumed.","name":"migmigration-sample","phase":"CreateStagePodsStarted"}
{"level":"info","ts":1561568398.695923,"logger":"migration|fvlmv","msg":"Migration: waiting.","name":"migmigration-sample","phase":"CreateStagePodsStarted","backup":"migmigration-sample-n54fd","restore":""}
{"level":"info","ts":1561568408.0310137,"logger":"migration|j29gp","msg":"Migration: resumed.","name":"migmigration-sample","phase":"CreateStagePodsStarted"}
{"level":"info","ts":1561568408.0593767,"logger":"migration|j29gp","msg":"Migration: waiting.","name":"migmigration-sample","phase":"CreateStagePodsStarted","backup":"migmigration-sample-n54fd","restore":""}
{"level":"info","ts":1561568416.996085,"logger":"migration|dcts9","msg":"Migration: resumed.","name":"migmigration-sample","phase":"CreateStagePodsStarted"}
{"level":"info","ts":1561568417.0266328,"logger":"migration|dcts9","msg":"Migration: waiting.","name":"migmigration-sample","phase":"StageBackupStarted","backup":"migmigration-sample-n54fd","restore":""}
{"level":"info","ts":1561568426.545885,"logger":"migration|57b5b","msg":"Migration: resumed.","name":"migmigration-sample","phase":"StageBackupStarted"}
{"level":"info","ts":1561568426.5637126,"logger":"migration|57b5b","msg":"Migration: waiting.","name":"migmigration-sample","phase":"StageBackupFailed","backup":"migmigration-sample-n54fd","restore":""}

time="2019-06-26T17:00:17Z" level=info msg="[common-backup] Entering common backup plugin" backup=velero/migmigration-sample-th4tp cmd=/plugins/velero-plugins logSource="/go/src/github.com/fusor/ocp-velero-plugin/velero-plugins/common/backup.go:25" pluginName=velero-plugins
time="2019-06-26T17:00:17Z" level=info msg="Executing custom action" backup=velero/migmigration-sample-th4tp group=v1 logSource="pkg/backup/item_backupper.go:307" name=pv8 namespace=mysql-persistent resource=pods
time="2019-06-26T17:00:17Z" level=info msg="[pv-backup] Entering Persistent Volume backup plugin" backup=velero/migmigration-sample-th4tp cmd=/plugins/velero-plugins logSource="/go/src/github.com/fusor/ocp-velero-plugin/velero-plugins/pv/backup.go:30" pluginName=velero-plugins
time="2019-06-26T17:00:17Z" level=info msg="Executing takePVSnapshot" backup=velero/migmigration-sample-th4tp group=v1 logSource="pkg/backup/item_backupper.go:372" name=pv8 namespace=mysql-persistent resource=pods
time="2019-06-26T17:00:17Z" level=info msg="Skipping persistent volume snapshot because volume has already been backed up with restic." backup=velero/migmigration-sample-th4tp group=v1 logSource="pkg/backup/item_backupper.go:390" name=pv8 namespace=mysql-persistent persistentVolume
=pv8 resource=pods
time="2019-06-26T17:00:17Z" level=info msg="Executing custom action" backup=velero/migmigration-sample-th4tp group=v1 logSource="pkg/backup/item_backupper.go:307" name=mysql namespace=mysql-persistent resource=pods
time="2019-06-26T17:00:17Z" level=info msg="[common-backup] Entering common backup plugin" backup=velero/migmigration-sample-th4tp cmd=/plugins/velero-plugins logSource="/go/src/github.com/fusor/ocp-velero-plugin/velero-plugins/common/backup.go:25" pluginName=velero-plugins
time="2019-06-26T17:00:17Z" level=info msg="Executing custom action" backup=velero/migmigration-sample-th4tp group=v1 logSource="pkg/backup/item_backupper.go:307" name=mysql-1-ff8xn-stage-pod namespace=mysql-persistent resource=pods
time="2019-06-26T17:00:17Z" level=info msg="[common-backup] Entering common backup plugin" backup=velero/migmigration-sample-th4tp cmd=/plugins/velero-plugins logSource="/go/src/github.com/fusor/ocp-velero-plugin/velero-plugins/common/backup.go:25" pluginName=velero-plugins
time="2019-06-26T17:00:21Z" level=info msg="1 errors encountered backup up item" backup=velero/migmigration-sample-th4tp group=v1 logSource="pkg/backup/resource_backupper.go:265" name=mysql-1-ff8xn-stage-pod namespace=mysql-persistent resource=pods
time="2019-06-26T17:00:21Z" level=error msg="Error backing up item" backup=velero/migmigration-sample-th4tp error="pod volume backup failed: error getting volume path on host: expected one matching path, got 0" error.file="/go/src/github.com/heptio/velero/pkg/restic/backupper.go:173" error.function="github.com/heptio/velero/pkg/restic.(*backupper).BackupPodVolumes" group=v1 logSource="pkg/backup/resource_backupper.go:269" name=mysql-1-ff8xn-stage-pod namespace=mysql-persistent resource=pods

This is because hostPath in restic daemonset does not match the one kubelet uses in your OCP environment.

Realized yesterday that it may be intended for the current iteration of this PR to work with pre-provsioned NFS on the destination cluster, so going to try that out today.

Wanted to leave this branch as-is rather than making edits directly to Dylan's branch for additional commits that need to be added before merge to master, so @jortel has created a new "feature branch" on fusor that we will submit further PRs to, and that we will eventually merge to master.
https://github.com/fusor/mig-controller/tree/migration-with-pv-copy
Closing this PR.


fix: update dependencies to remove panic

fix:
thread 'main' panicked at 'not currently running on the Tokio runtime.', github.com-1ecc6299db9ec823/tokio-1.0.2/src/runtime/blocking/pool.rs:84:33
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

It can run normally now.

/assign @hi-rustin

/assign @hi-rustin

/ok-to-test
@PsiACE Why it panic? It seems it work well for me.

/ok-to-test
@PsiACE Why it panic? It seems it work well for me.

@PsiACE Why it panic? It seems it work well for me.

You did not make the dependency fixed. The latest version will be used automatically on my system.
Even if it works, it is necessary to update the dependencies.

@PsiACE Why it panic? It seems it work well for me.

You did not make the dependency fixed. The latest version will be used automatically on my system.
Even if it works, it is necessary to update the dependencies.

Recurrence:

cargo clean
cargo run tikv tikv --token  --output tikv-label.yaml
get panic info like this

thread 'main' panicked at 'there is no reactor running, must be called from the context of a Tokio 1.x runtime', $HOME/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.1.0/src/runtime/blocking/pool.rs:85:33
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

see an empty file named tikv-label.yaml

Recurrence:

cargo clean
cargo run tikv tikv --token  --output tikv-label.yaml
get panic info like this

thread 'main' panicked at 'there is no reactor running, must be called from the context of a Tokio 1.x runtime', $HOME/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.1.0/src/runtime/blocking/pool.rs:85:33
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

see an empty file named tikv-label.yaml

/merge

/merge

/merge

/merge

@PsiACE  Thanks!

@PsiACE  Thanks!


now dev takes a long time to reload

I have a project written in 150 lines of TypeScript and now dev takes a long time to reload. Sometimes 10 seconds+.
The project is a single file that imports axios, cheerio, and googleapis.

This may deserve a new issue, but I'm also seeing this happening every 5-10 hot reloads:
FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory

I am also seeing incredibly slow build times. These lines stuck out to me when running DEBUG=* now dev:
 @zeit/fun:runtimes Runtime 'nodejs8.10' is already initialized at '/Users/max/Library/Caches/co.zeit.fun/runtimes/nodejs8.10' +46s
 @zeit/fun:index Creating provider 'NativeProvider' +46s
 @zeit/fun:unzip Unzipping buffer (length=1629090) to temp dir '/var/folders/g4/1sg6rxt10gd8nt_bkhpb09jm0000gn/T/zeit-fun-4a394dc55a43a' +46s

Happy to provide more detail to help

I am experiencing the same issue. Beside, I think that any serverless function is recompiled, even though no files related to this specific function have been changed, between two uses.
Those two problems slow down the development process. I know now dev is still in beta but as of today, is it the expected behavior or I am doing something wrong ?
Despite that, thank you for the great work  !

This may deserve a new issue, but I'm also seeing this happening every 5-10 hot reloads:
FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory

Seeing the same, on a small handler, that is only importing googleapis and node-fetch.

I was also using googleapis. And I believe axios.
On Sat, 18 May 2019 at 18:02 Jan Potoms<EMAIL_ADDRESS>wrote:

This may deserve a new issue, but I'm also seeing this happening every
5-10 hot reloads:
FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
Seeing the same, on a small handler, that is only importing googleapis
and node-fetch.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zeit/now-cli/issues/2319?email_source=notifications&email_token=AAXSQXZBLROO6QR74NE5ATLPWALATA5CNFSM4HK23RW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVWQHLY#issuecomment-493683631,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAXSQX4SDYROSGAPVZ67RKTPWALATANCNFSM4HK23RWQ
.

This issue was resolved with the latest version of Now CLI.
Let me know if you're still experiencing problems, then we'll re-open this. 🙏

@elie222  @GaelS  if caching is disabled in chrome devtools for every api calls it will issue a rebuild

I have caching enabled in Chrome dev tools.
What was the issue? I am on 15.3.0 and now dev is far from running smoothly.

@leo I'm afraid the issue is still here :
> Building @now/node:api/subscriptions/index.js
downloading user files...
installing dependencies for user's code...
installing to /Users/jean/dev/nowslow/api/subscriptions
running user script...
compiling entrypoint with ncc...
ncc: Module directory "/Users/jean/dev/nowslow/node_modules/hash-stream-validation" attempted to require "fast-crc32c" but could not be resolved, assuming external.
ncc: Module directory "/Users/jean/dev/nowslow/node_modules/write-file-atomic" attempted to require "worker_threads" but could not be resolved, assuming external.
ncc: Module directory "/Users/jean/dev/nowslow/node_modules/bytebuffer/dist" attempted to require "memcpy" but could not be resolved, assuming external.
  @zeit/fun:runtimes Runtime 'nodejs8.10' is already initialized at '/Users/jean/Library/Caches/co.zeit.fun/runtimes/nodejs8.10' +2m
  @zeit/fun:index Creating provider 'NativeProvider' +24s

$ now --version
15.5.0
$ ncc version
0.18.5

I have yet to figure out how to force the now-cli 15.5.0 to use ncc 0.19.x

@ywg-jean The version of ncc is tied to the @now/node builder code. Please create a new issue describing the issue 🙏

@TooTallNate it's unclear : are you asking me to open an issue to ask for a way to configure the version of ncc or to open a new issue for slow build time ?
If the latter I'm not sure why since what I am observing has the same symptoms as what @elie222 described initially (including the OOM errors) and has somewhat similar logs as those reported by @maxbeatty
Do you really recommand opening a different issue ?


remove sizing and minor build/readme changes

I think you can just disable the workflow

@Nitzperetz but we do want sizing, did you turn it back on in the console app?

Not yet

for sizing we might want to use https://github.com/siddharthkp/bundlesize as a check rather then https://github.com/ai/size-limit


Fixes an error with the whitespace check that showed the incorrect location of the error

This fixes #1664

Looks good to me and can be merged after rebasing it against master!