Pandas 1.0 tests not passing

One of our tests is not passing with Pandas =1.0.3 but it's fine with Pandas = 0.25.3.
test_mismatch.py test_analysisIrradianceandPowerMismatch
mismatch.py:307: in analysisIrradianceandPowerMismatch
dfst['MAD/G_Total'] = Poat.apply(mad_fn,axis=1)
returns a pandas NotImplementedError
using bifacial_radiance development branch, pandas 1.0.3, numpy 1.18.2
Our mad_fn np.subtract.outer is specifically mentioned as no longer supported in pandas 1.0 release notes:
"The ‘outer’ method on Numpy ufuncs, e.g. np.subtract.outer operating on Series objects is no longer supported, and will raise NotImplementedError (GH27198)"
https://pandas.pydata.org/pandas-docs/stable/whatsnew/index.html

This can be solved by setting pandas < 1.0 in setup.py


TypeInitializationException on OSX

Hello,
We recently updated to 2.2.13 (from 2.1.23) and are encountering an issue on OSX.
Tools:

Visual Studio for Mac
dotnet sdk v2.1.401

Below is the error output:
Target GetBuildVersion:
    /Users/username/.nuget/packages/nerdbank.gitversioning/2.2.13/build/Nerdbank.GitVersioning.targets(63,5): error MSB4018: The "Nerdbank.GitVersioning.Tasks.GetBuildVersion" task failed unexpectedly.
    /Users/username/.nuget/packages/nerdbank.gitversioning/2.2.13/build/Nerdbank.GitVersioning.targets(63,5): error MSB4018: System.TypeInitializationException: The type initializer for 'LibGit2Sharp.Core.NativeMethods' threw an exception. ---> System.DllNotFoundException: lib/osx/libgit2-6311e88.dylib
    /Users/username/.nuget/packages/nerdbank.gitversioning/2.2.13/build/Nerdbank.GitVersioning.targets(63,5): error MSB4018:   at (wrapper managed-to-native) LibGit2Sharp.Core.NativeMethods.git_libgit2_init()
    /Users/username/.nuget/packages/nerdbank.gitversioning/2.2.13/build/Nerdbank.GitVersioning.targets(63,5): error MSB4018:   at LibGit2Sharp.Core.NativeMethods.LoadNativeLibrary () [0x00000] in <b59d5da32f8541b2a767004d8bddc22b>:0
    /Users/username/.nuget/packages/nerdbank.gitversioning/2.2.13/build/Nerdbank.GitVersioning.targets(63,5): error MSB4018:   at LibGit2Sharp.Core.NativeMethods..cctor () [0x00045] in <b59d5da32f8541b2a767004d8bddc22b>:0
    /Users/username/.nuget/packages/nerdbank.gitversioning/2.2.13/build/Nerdbank.GitVersioning.targets(63,5): error MSB4018:    --- End of inner exception stack trace ---
    /Users/username/.nuget/packages/nerdbank.gitversioning/2.2.13/build/Nerdbank.GitVersioning.targets(63,5): error MSB4018:   at LibGit2Sharp.Core.Proxy.git_libgit2_opts_set_search_path (LibGit2Sharp.ConfigurationLevel level, System.String path) [0x00000] in <b59d5da32f8541b2a767004d8bddc22b>:0
    /Users/username/.nuget/packages/nerdbank.gitversioning/2.2.13/build/Nerdbank.GitVersioning.targets(63,5): error MSB4018:   at LibGit2Sharp.GlobalSettings.SetConfigSearchPaths (LibGit2Sharp.ConfigurationLevel level, System.String[] paths) [0x0001a] in <b59d5da32f8541b2a767004d8bddc22b>:0
    /Users/username/.nuget/packages/nerdbank.gitversioning/2.2.13/build/Nerdbank.GitVersioning.targets(63,5): error MSB4018:   at Nerdbank.GitVersioning.GitExtensions.OpenGitRepo (System.String pathUnderGitRepo) [0x00012] in <150882c73d494e8384ad79d7674b0ae0>:0
    /Users/username/.nuget/packages/nerdbank.gitversioning/2.2.13/build/Nerdbank.GitVersioning.targets(63,5): error MSB4018:   at Nerdbank.GitVersioning.VersionOracle.Create (System.String projectDirectory, System.String gitRepoDirectory, Nerdbank.GitVersioning.ICloudBuild cloudBuild, System.Nullable`1[T] overrideBuildNumberOffset, System.String projectPathRelativeToGitRepoRoot) [0x00017] in <150882c73d494e8384ad79d7674b0ae0>:0
    /Users/username/.nuget/packages/nerdbank.gitversioning/2.2.13/build/Nerdbank.GitVersioning.targets(63,5): error MSB4018:   at Nerdbank.GitVersioning.Tasks.GetBuildVersion.ExecuteInner () [0x000c5] in <a9ad9b18f9d14576b838941f05d31209>:0
    /Users/username/.nuget/packages/nerdbank.gitversioning/2.2.13/build/Nerdbank.GitVersioning.targets(63,5): error MSB4018:   at MSBuildExtensionTask.ContextAwareTask.Execute () [0x0005e] in <a039684190264706bf075ac0ee99291f>:0
    /Users/username/.nuget/packages/nerdbank.gitversioning/2.2.13/build/Nerdbank.GitVersioning.targets(63,5): error MSB4018:   at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute () [0x00023] in /_/src/Build/BackEnd/TaskExecutionHost/TaskExecutionHost.cs:631
    /Users/username/.nuget/packages/nerdbank.gitversioning/2.2.13/build/Nerdbank.GitVersioning.targets(63,5): error MSB4018:   at Microsoft.Build.BackEnd.TaskBuilder+<ExecuteInstantiatedTask>d__26.MoveNext () [0x00212] in /_/src/Build/BackEnd/Components/RequestBuilder/TaskBuilder.cs:787
Done building target "GetBuildVersion" in project "MyProject.csproj" -- FAILED.

Let me know if there is any additional information I can provide.

Thanks for your report. What version of OSX are you testing on?

Hi @AArnott , we're using High Sierra 10.13.2

Also on OSX 10.13.6.
Nerdbank.GitVersioning 2.1.84 does not exhibit the problem.

Oddly, dotnet build ... works (with 2.2.13) but msbuild … does not.

@rgmills What about you? Are you using dotnet build or msbuild?
Isn't msbuild only present when mono is installed? I haven't actively tested NB.GV with mono. It's quite the task just to make sure NB.GV works on .NET Framework, and all three OS's with .NET Core. Adding mono to the mix... that's a lot of work.
If dotnet build works, can you switch to using that?

Yes - that's msbuild on Mono. Can't switch for Xamarin iOS projects because the SDK is not available to dotnet build. I guess the same applies to Xamarin Android projects on Mac OS, but not sure since we build our Android projects on Windows.
If you have any pointers to where I might look, I would be happy to try to figure out what has changed between 2.1.84 and 2.2.13 to break Mono msbuild. Is there a way I can debug the msbuild task on a Mac? Also, how/where does TargetsPath get set?

Thanks, @frankbuckley. TargetsPath gets set here:
https://github.com/AArnott/Nerdbank.GitVersioning/blob/d0bbbacfe34e9540572e5747893f2897c892d64a/src/Nerdbank.GitVersioning.Tasks/build/Nerdbank.GitVersioning.targets#L70
I have no idea how to debug mono msbuild on Mac. On Windows I'll sometimes add a Debugger.Launch() call to my msbuild task which pops up a JIT debugger dialog that I can use. I don't know if something similar is available on Mac.
Between 2.1.84 and 2.2.13 the primary change was adding support for Ubuntu 18 and other more recent linux distros. It was a lot of trial-and-error changes to try to get everything working at once. It was a delicate balancing act. So if we can get this to work for mono, we'll need to revalidate on all the other platforms we support. I'm building up my prowess at Azure Pipelines build validations that include many different target OSs and versions that should help with that.
Yes, whatever you can do to help investigate would be much appreciated.

👏  @frankbuckley highly appreciate you working on this since I just started running into this myself - unable to use vscode on Mac to work on projects at the moment.

Thanks @frankbuckley  and @AArnott .  Great surprise to see coming back from vacation!


Test cases fail due to new changes

Events related test cases are failing because a new field (priority) was added to the event class. Test cases need to be changed to reflect that.

Fixed in PR #35


Push image to registry only when building master

I noticed the builds were failing recently. :x: :cry:
It looks like it's trying to always login to Docker Hub, even for PRs, which shouldn't need to push any image.
This PR adds a check to see if we're building off master, and if we're not, then it skips the docker login step and the push step.
Thanks for maintaining this!

Hey @dbirks, thanks a lot for the contribution! We actually want to keep pushing images internally, but stop doing that for forks. Do you think that you could change your check to actually test if it is a fork?
So, instead of checking if it is master, check if the repo full name is the one from the original org. Maybe something like if github.event.pull_request.head.repo.full_name == 'org/repo'.

Ah, yes that sounds good. I was wondering how to prevent untrusted code from being built and pushed, but having the line drawn at forks would work very nicely, and allow you to have internal branches pushed. Making the change now...


Add image uploads functionality to Article from in /admin CMS

Right now, a person has to manually:

resize (dimensions and resolution) images
strip exif metadata images
rename  images
create folders on S3 to match the DD in the MM in the YYYY
upload each of the article images
upload the header image
place the images in the article using our [[ MEDIA URL ]] syntax
copy the header.jpg image URL from S3 and paste it into the header image field

What would be a bajillion times better is something like:

someone in the content side find and/or edit images for content/color/crop
but not resolution, dimension, exif, compression
then they’d drag them into the article form in the browser
the images would get ajax uploaded in the background to a folder on S3 named something (more on that below)
then the URLs and a small thumbnail of the images would be displayed in the form for copy/pasta into the article content (better UX could be added later)
the backend would handle the resolution, dimension, exif, compression concerns

What to name that folder on S3?

I’d LOVE it to be the DD of the article, but that changes sometimes while an article is in draft
It could be the article slug (title/subtitle), but that changes too in the draft process
Same for the short URL (though this is probably the safest)

And it only has to be unique with the MM on S3
Rails 5.2 added ActiveStorage. I think that’d be perfect to use for this.
http://guides.rubyonrails.org/active_storage_overview.html
https://www.schneems.com/2018/05/11/rails-52-active-storage-previews-poppler-and-solving-licensing-pitfalls
https://weblog.rubyonrails.org/2018/4/9/Rails-5-2-0-final
https://weblog.rubyonrails.org/2017/11/27/Rails-5-2-Active-Storage-Redis-Cache-Store-HTTP2-Early-Hints-Credentials
That alone would reduce the friction for the publishing side a great deal

Many moons later, we’re now thinking about this functionality differently.
The current workflow used by content folx, as described above, is still how things are done.
We still want an uploader, for content folx’ self service.
But, instead of having the uploader component on the admin article form, it’ll be on its own page.
Probably at: /admin/upload
And a separate page/sections of pages for using the uploaded media in a media library.
/media
/library
/assets
I’m personally leaning toward /media. At least partially because we gem that’s used to embed things in articles is called: markdown_media.
https://github.com/veganstraightedge/markdown_media
Uploader page should support:

All of the formats that active storage supports
drag and drop
multiple files dropped
direct from browser to S3* uploads via js
progress bar or at least an indicator of each file that’s inflight and when it finishes
exif stripping
auto orientation
size variants**

Note: we no longer carry about vanity URLs of the uploads. The ugly URL/file names that active storage gives us is worth the trade off of all the other good stuff we get from it.
* S3
We’re still using / gonna use S3 for the known foreseeable future, but using active storage offers an easy way to improve our resilience and decrease our tight coupling with a single vendor
We could/should set up our storage.yml with one or more mirrors on google etc.
Migrating all the manually uploaded files on S3 is a separate concern, outside the scope of this issue.
** Size variants
The k own sizes that we want from the jump are:

original (unchanged)
article header 2000px wide max
article content 1400px wide max
mobile article header (px tbd)
mobile article content (px tbd)
related article / article collections (px tbd)

I don’t think any square crops are needed in the redesign. So we don’t need to worry about computer choosing the right square border.
Having the ability to cut size variants means that we’ll be able to do responsive images using the <picture> tag. markdown_media need some updates to make that work.
Also, I think the media library page display some/all of the size variants, so that when an author goes to the asset page to copy the URL, all of the sizes that’ll get served to users will get lazy loaded by their display in admin, and the first user doesn’t take the performance hit.
Media library
I’ll sketch up some rough designs but here’s what I’m imagining now.
Main page of the library is a grid of thumbnails.
Sorted by most recent at the top.
Filters for file type would be good.
Filter by tag would be good too.
Both filters are nice to haves, IMO, and not blockers to launching the uploader to content folx.
The asset page for each upload should have non-editable but copyable fields of the URL for each size variants. And a field with the URL wrapped up in the media embed syntax. [[ ]].
Later, a embed wizard might be nice to. Edit some fields and the copyable snippet changes.

This is a lot in one issue and we should break up the deliveries into smaller PRs.

GCP config information:
https://github.com/googleapis/google-cloud-ruby/tree/master/google-cloud-storage
https://googleapis.dev/ruby/google-cloud-storage/latest/file.AUTHENTICATION.html


TimeSpanValueFormatter throws on OverflowException when its value contains TimeSpan.MinValue

When an assertion fails, and its object contains a TimeSpan field which has a value of TimeSpan.MinValue, an OverflowException is thrown.
This is because GetNonZeroFragmentsToString() calls GetNonZeroFragmentsGetNonZeroFragments(), which calls timeSpan.Duration(), which throws the exception if  its Ticks equals to TimeSpan.MinValue.Ticks.

Thanks for reporting that.


Logging framework

This PR contains all the components of the Logging framework. It closes the following issues.
Closes #68  Log formatting
Closes #69  FileLogger Implementation
Closes #114  ConsoleLogger Implementation
Closes #115  Config Files
Closes #70 Overall

@convict-git @muhammedyaseen-git LoggerManager and FileLogger ready to review

@convict-git @muhammedyaseen-git ConsoleLogger ready for review

@Rahul-R5 please change the WIP tag if it is ready for merge?

@muhammedyaseen-git Test mode logic is under review

@muhammedyaseen-git @convict-git Logger complete

@Rahul-R5, Why was src/module-info.java deleted and committed?

@convict-git src/module-info.java was modified to include javax.xml dependency. @Navneeth told me that was what eclipse suggested to do in order to use javax. I am not aware whether it was deleted and added again.

PR Rahul-R5#39 has been made to address the comments to the review

Exception handling added


adding codeql

Adding config file to enable SAST scanning.
Please reach out via slack to #project-enable-sast if you have any questions or concerns.

archiving this repo


Basic bot command for fetching event sessions

Implements a DM command that fetches the sessions for a Warhorn event.
For now, uses an application token to call the API, which means we only get the information that a user logged out of Warhorn would get going to the event calendar on the web.


⚠ Bofrost.de has degraded performance

In 15d4a50, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1702 ms

Resolved: Bofrost.de performance has improved in cbcb8db after 8 minutes.


[earlgrey_es,tock] Update license header in autogenerated files

Cherry-pick from master onto earlgrey_es:
#19341
#19354

The python formatting tools reformatted ip_block.py quite a bit more than I expected.  During the merge, I had to manually resolve some conflicts related to the presence of semantic_version in master versus its absence in earlgrey_es.  I think I resolved them correctly; could you take a careful look at that module?


New Community page

This is quite a big one, mostly reorganising existing content...

Moved the contributing institution map and list to a new page: Community
Added to this page a list of GitHub avatars scraped from the total list of all contributors (random order)
Added a "Contributor Leaderboard" to the Statistics page, showing how many commits every contributor has done
Rejigged the text in the now much-smaller About page and added a section listing the admin team.

This look quite impressive, quick questions, about the contributors list (the one with the github avatar)

How is it sorted ? (it doesn't look alphabetical)
There are only 26 public members of the nf-core organisation, yet, you publish all 70 members. Is it allowed?

It’s sorted randomly (deliberately) - refresh and it’ll shuffle again..
Other contributions would be good to add in the future. I’m not pulling this yet though.
People are private by default, I’m assuming that everyone wants to be public. I guess if we’re worried I could set up an automated email to email private members every day asking them to change it or remove themselves from the org?

I'm guessing it might be worth discussing, but sending a daily reminder might be a tiny bit too much I think ;-)

hah, sorry - daily because that's when the script runs that pulls the list. Yes, that is maybe a fraction spammy.


Update streaming test to download CRs, use version 0.12.1

Signed-off-by: Kevin Earls<EMAIL_ADDRESS>This also makes it possible to test with other kafka streams operators, like AMQ streams.

@objectiser @jpkrohling  @pavolloffay  Please review


Move string methods from Utils.hpp to StringUtils.hpp

Moving the string functions to StringUtils seems like a better place for these methods to live. While doing so I moved the method bodies to the .cpp file. The combination of the two fixes here allows for us to change the underlying implementation of the method bodies without invalidating much of the build DAG, which means faster incremental builds for everyone.
I will remove the #include "utils/StringUtils.hpp" from Utils.hpp, but I need that there now to make fixes to the private modules repo. That'll be coming in subsequent PRs.
Additional thoughts moving forward, neither of these are part of this PR in order to keep it scoped. If people have strong opinions I'm happy to integrate:

I'm not sure of the value of the StringUtils static class. As it didn't have any state, I moved it to a namespace. I'd like to know if people have strong opinions on whether the other methods in StringUtils.hpp should be in the StringUtils namespace.
The code style guide indicates that public methods are PascalCased and other methods are camelCased. I'd like to change all the StringUtils.hpp methods to match PascalCase, but that seemed like it'd distract from the central point of the PR (moving methods).

Yeah, I'm going to #define NOMINMAX in the Windows build scripts.

Yeah, I'm going to #define NOMINMAX in the Windows build scripts.


networkmanagerapplet: 1.8.16 -> 1.8.18.

Motivation for this change
Mainly to get a fix for https://gitlab.gnome.org/GNOME/network-manager-applet/issues/20 which prevents me from using my work VPN.
Also is it possible to cherry-pick this to 18.09 release ?
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build networkmanagerapplet

Success on x86_64-linux (full log)
Attempted: networkmanagerapplet
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/jdqah1qz122cv62flxdvcm7rc3728b4j-network-manager-applet-1.8.18-devdoc
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/jdqah1qz122cv62flxdvcm7rc3728b4j-network-manager-applet-1.8.18-devdoc
checking for references to /build in /nix/store/jdqah1qz122cv62flxdvcm7rc3728b4j-network-manager-applet-1.8.18-devdoc...
shrinking RPATHs of ELF executables and libraries in /nix/store/19s1m5xwz2zkwljnaq4883wlr6m3ppqd-network-manager-applet-1.8.18-man
gzipping man pages under /nix/store/19s1m5xwz2zkwljnaq4883wlr6m3ppqd-network-manager-applet-1.8.18-man/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/19s1m5xwz2zkwljnaq4883wlr6m3ppqd-network-manager-applet-1.8.18-man
checking for references to /build in /nix/store/19s1m5xwz2zkwljnaq4883wlr6m3ppqd-network-manager-applet-1.8.18-man...
/nix/store/zmfpqd9g2nqzylpw7c4pair1mfijf2n8-network-manager-applet-1.8.18

Success on aarch64-linux (full log)
Attempted: networkmanagerapplet
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/cvg82053dz4k3qlmzbrzxnnfvwdh3y7a-network-manager-applet-1.8.18-devdoc
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/cvg82053dz4k3qlmzbrzxnnfvwdh3y7a-network-manager-applet-1.8.18-devdoc
checking for references to /build in /nix/store/cvg82053dz4k3qlmzbrzxnnfvwdh3y7a-network-manager-applet-1.8.18-devdoc...
shrinking RPATHs of ELF executables and libraries in /nix/store/5q419q6w7jm65zq07r77jm2lqnmv701q-network-manager-applet-1.8.18-man
gzipping man pages under /nix/store/5q419q6w7jm65zq07r77jm2lqnmv701q-network-manager-applet-1.8.18-man/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/5q419q6w7jm65zq07r77jm2lqnmv701q-network-manager-applet-1.8.18-man
checking for references to /build in /nix/store/5q419q6w7jm65zq07r77jm2lqnmv701q-network-manager-applet-1.8.18-man...
/nix/store/9ycllr1hkhfpds258mlica1zs9xrv1cw-network-manager-applet-1.8.18

Success on aarch64-linux (full log)
Attempted: networkmanagerapplet
Partial log (click to expand)
/nix/store/9ycllr1hkhfpds258mlica1zs9xrv1cw-network-manager-applet-1.8.18

Success on x86_64-linux (full log)
Attempted: networkmanagerapplet
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/jdqah1qz122cv62flxdvcm7rc3728b4j-network-manager-applet-1.8.18-devdoc
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/jdqah1qz122cv62flxdvcm7rc3728b4j-network-manager-applet-1.8.18-devdoc
checking for references to /build in /nix/store/jdqah1qz122cv62flxdvcm7rc3728b4j-network-manager-applet-1.8.18-devdoc...
shrinking RPATHs of ELF executables and libraries in /nix/store/19s1m5xwz2zkwljnaq4883wlr6m3ppqd-network-manager-applet-1.8.18-man
gzipping man pages under /nix/store/19s1m5xwz2zkwljnaq4883wlr6m3ppqd-network-manager-applet-1.8.18-man/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/19s1m5xwz2zkwljnaq4883wlr6m3ppqd-network-manager-applet-1.8.18-man
checking for references to /build in /nix/store/19s1m5xwz2zkwljnaq4883wlr6m3ppqd-network-manager-applet-1.8.18-man...
/nix/store/zmfpqd9g2nqzylpw7c4pair1mfijf2n8-network-manager-applet-1.8.18


Add link to Brazilian comunities in Slack

This commit adds a link to the joselitojunior1/slack-list-brazil repository.
This repository groups many awesome Slack teams related to software development in Brazil.

I'm closing to fix the link to the repository.


Browserify compatiblity

This plugin doesn't work when project is build with browserify.
I've checked how other plugins are solving it ( for example jquery-mousewheel ).
Changing this single line works perfectly. However, I'm not sure how it will influence other setups.

What error are you seeing?
I'm building with Grunt and Browserify and can see the logs of failed ajax calls being retried.


Python kubernetes client breaks when parsing the response from custom controller

Issue: Python kubernetes client breaks when parsing the response from custom controller
When running a watch primitive as:
resource_version = ''
while True:
stream = watch.Watch().stream(crds.list_cluster_custom_object, DOMAIN, "v1", "guitars", resource_version=resource_version)
The python client breaks with:
Traceback (most recent call last):
File "controller-pods.py", line 39, in
for event in stream:
File "/usr/lib/python2.7/site-packages/kubernetes/watch/watch.py", line 154, in stream
for line in iter_resp_lines(resp):
File "/usr/lib/python2.7/site-packages/kubernetes/watch/watch.py", line 60, in iter_resp_lines
resp = resp.read_chunked(decode_content=False)
AttributeError: 'HTTPResponse' object has no attribute 'read_chunked'
Packages versions:
rpm -qf /usr/lib/python2.7/site-packages/openshift/dynamic/client.py /usr/lib/python2.7/site-packages/kubernetes/watch/watch.py
python2-openshift-0.8.8-1.el7.noarch
python2-kubernetes-8.0.1-1.el7.noarch

Workaround, it seems that in this case the response does not allow to be chunked, using instead **read() in[1]:
https://github.com/kubernetes-client/python-base/blob/master/watch/watch.py#L48
Before:
for seg in resp.read_chunked(decode_content=False):
After:
for seg in resp.read():
Seemed to work fine.

Fix proposed in #140

Making fail also Ansible Kubevirt https://github.com/kubevirt/ansible-kubevirt-modules/issues/222

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle rotten


Missing device fix

Pull Request summary:
Fixed missing device in Enum
Description of changes:
[Add more in depth analysis of what changed, provide logs, examples of usage]
Checklist:

[x] Make sure to run pre-commit before commiting changes
[x] Make sure all checks have passed
[x] PR description is clear and comprehensive
[x] Mentioned the issue that this PR solves (if applicable)
[x] Make sure you test the changes

This issue was migrated from an old repository: https://github.com/CiscoDevNet/catalystwan/pull/265


kong with oauth2 token invalid every time

Summary
Additional Details & Logs

Kong version: kong-community-edition-0.14.0-1.noarch
Operating system centos 7.4

Hi Team,
We enabled oauth2 ( client credential flow) for one service  named hrms_billing with separate  consumer( hrms)
After that we are able to get Token from endpoint, But when we summit request with provided token it always says invalid , I checked multiple times so decided to highlighted so that you can check whether its a bug or other issue.
Will really appreciate if you help to understand kong for oauth2 implementation.
Step-11:  generate token like this for testing purpose  with high  very expire value
[root@psld-ggn-233 ~]#   curl -X POST http://<IP_ADDRESS>:8001/oauth2_tokens --data "credential_id=0c43d1da-08dc-4126-a3d3-44f2036c4844"      --data "expires_in=360000000"
Step-10: check token generated and get this value
[root@psld-ggn-233 ~]#  curl -X GET  http://<IP_ADDRESS>:8001/oauth2_tokens?credential_id=0c43d1da-08dc-4126-a3d3-44f2036c4844
{"total":1,"data":[{"created_at":1535020491000,"access_token":"c0lWMnk8ncEVqpBvW7fNq390Vxu1gGHX","expires_in":360000000,"id":"d7ce0088-3627-44fa-8c06-0b2f13d6311f","credential_id":"0c43d1da-08dc-4126-a3d3-44f2036c4844","token_type":"bearer"}]}
Step-9: send token with api to get response
[root@psld-ggn-233 ~]# curl -X POST -H 'Authorization: Bearer c0lWMnk8ncEVqpBvW7fNq390Vxu1gGHX' -i 'http://g1.peoplestrong.com/api_v1/public/index.php/login/wines/1'
HTTP/1.1 401 Unauthorized
Date: Thu, 23 Aug 2018 11:07:33 GMT
Content-Type: application/json; charset=utf-8
Connection: close
Server: kong/0.14.0
WWW-Authenticate: Bearer realm="service" error="invalid_token" error_description="The access token is invalid or has expired"
Rest details r below.
[root@psld-ggn-233 ~]#  curl -X GET  http://<IP_ADDRESS>:8001/consumers/hrms/plugins
{"total":1,"data":[{"created_at":1535021437000,"config":{"path":"/tmp/abcd","reopen":false},"id":"039cc5d5-704f-4a40-9244-70f95e3748c5","enabled":true,"name":"file-log","service_id":"268c2499-47a7-4a5e-bfef-b72b44343514","consumer_id":"8ba4743c-aea7-4d39-bfb5-25ed8ba3cc91"}]}
[root@psld-ggn-233 ~]#  curl -X GET  http://<IP_ADDRESS>:8001/services/hrms_billing/routes
{"next":null,"data":[{"created_at":1534791379,"strip_path":true,"hosts":[],"preserve_host":false,"regex_priority":0,"updated_at":1534988394,"paths":["/A"],"service":{"id":"268c2499-47a7-4a5e-bfef-b72b44343514"},"methods":[],"protocols":["http","https"],"id":"4a8b5a07-7f04-42f9-a37b-30b51e156041"},{"created_at":1534795000,"strip_path":true,"hosts":[],"preserve_host":true,"regex_priority":0,"updated_at":1534843166,"paths":["/api_v1/public/index.php/login/wines"],"service":{"id":"268c2499-47a7-4a5e-bfef-b72b44343514"},"methods":[],"protocols":["http","https"],"id":"b6edbfa5-d3b9-4d45-b734-fc16cc9d461b"}]}
[root@psld-ggn-233 ~]# curl -X GET  http://<IP_ADDRESS>:8001/services/hrms_billing/plugins
{"total":4,"data":[{"created_at":1534844114000,"config":{"key_in_body":false,"key_names":["apikey"],"anonymous":"","hide_credentials":false,"run_on_preflight":true},"id":"860c9523-af70-48a3-93c5-b59720fd2344","name":"key-auth","service_id":"268c2499-47a7-4a5e-bfef-b72b44343514","enabled":false},{"created_at":1534853513000,"config":{"key_claim_name":"iss","secret_is_base64":false,"cookie_names":{},"anonymous":"","maximum_expiration":0,"run_on_preflight":true,"uri_param_names":["jwt"]},"id":"015e511a-81ba-4514-90bc-302979439d62","name":"jwt","service_id":"268c2499-47a7-4a5e-bfef-b72b44343514","enabled":false},{"created_at":1535013580000,"config":{"refresh_token_ttl":1209600,"enable_client_credentials":true,"mandatory_scope":false,"accept_http_if_already_terminated":false,"provision_key":"function","enable_implicit_grant":false,"global_credentials":false,"hide_credentials":false,"enable_password_grant":false,"anonymous":"","enable_authorization_code":false,"token_expiration":7200,"auth_header_name":"authorization"},"id":"188e0c45-59f6-4b97-ab33-4eb3af3ddab9","name":"oauth2","service_id":"268c2499-47a7-4a5e-bfef-b72b44343514","enabled":true},{"created_at":1535021437000,"config":{"path":"/tmp/abcd","reopen":false},"id":"039cc5d5-704f-4a40-9244-70f95e3748c5","enabled":true,"name":"file-log","service_id":"268c2499-47a7-4a5e-bfef-b72b44343514","consumer_id":"8ba4743c-aea7-4d39-bfb5-25ed8ba3cc91"}]}
[root@psld-ggn-233 ~]#
Regards
Anupam Narayan

The problem is that you have not created the token to a particular serviceor api(the step 11) and you have not defined config.global_credentials (see the plugins output). You can PATCH the OAuth2 plugin configuration with config.global_credentials=true to get this to work (or add service_id to token).
I will close this now. Please reopen if that still didn't fix your problem.


Pressing enter in operation form redirects page

If you select an input field on an operation's intermediary form, the page redirects to the same URL with query parameters representing the forms inputs.  This results in the user losing all data and progress.

Not sure what to do about this one.  It may be possible to override the inherit handler of the "enter" command on a form?
ps This is using Chrome Version 42.0.2311.135 (64-bit) on Mac OSX

Good eye - we can override the enter button to preventDefault() and then run the submit function.


Change return value Maybe to Completable in SessionDetailViewModel

Issue

N/A

Overview (Required)
Changed SessionDetailViewModel.findSession()'s return value Maybe<Session> to Completable.
Because return value session does not used in SessionDetailFragment.  Completable is fit to this case.

Thanks! LGTM


Support Glob Patterns in extendRenderWith

This merge request adds support for glob patterns in the extendRenderWith configuration.

must have :)


Not compatible with beta 8

flagrow/upload extension version: master
flarum version: 0.1.0-beta.8

I got the error Uncaught TypeError: Cannot read property 'default' of undefined in JS Console and nothing is loading besides the header.

Beta 8 is not released yet and there are still upcoming changes that affect the release. Running flarum beta 8 only makes sense as a developer working on your own extensions.

And yes this extensions wasn't yet made compliant yet.


Add info for translators

We should add some info to CONTRIBUTING.md or perhaps a new TRANSLATING.md targeted toward translators. It should cover how to translate the site (i.e. through Transifex and not PRs here), possibly how the translations system works (how and how often it gets pulled into the project), and some common guidelines we ask translators to follow.

Wow jk that already exists. Derp derp derp.


Colour for 0.00 when target category balance goal set.

Defective ToolKit Feature Name: Red or Orange colour $0.00 for target category balances not yet reached in budget screen.
Expected Behavior
Would like the 0.00 to have a colour indication that the target category balance has not been reached and money needs to be allocated.
Actual Behavior
Currently the 0.00 is uncoloured and a normal font. As if no action is required.
Steps to Reproduce the Behavior

Have a target category balance goal set.
Have no money budgeted.

Export of Toolkit Settings (Bottom Left of Settings Page)
[paste settings here]

System Settings
ToolKit Version:
Operating System (Mac/Windows/Etc):
Browser (Chrome/Firefox/Safari):
Browser Version:
Other Extensions:

@danieldbird Can you be more specific about which number you want to be colored? A screen shot would be best if possible.
@bluebird8203 Do we already have a feature request like this? If not, can you add one? Thanks.

Here is a good example.
The top item has a Monthly Funding goal, and because the goal has not been reached, the $0.00 is coloured orange. Great, this tells me there is action to be taken.
The bottom item however has a Target Category Balance goal, and this goal has also not been reached, however the $0.00 is not coloured orange.
I would like the bottom items $0.00 to also be coloured orange, showing me there is action to be taken.

@danieldbird Thanks for the screen shot. Can you provide one more piece of data? That would be an of the  Toolkit Settings (Bottom Left of Settings Page). What I'm determining is if the number being colored orange is the Toolkit or native YNAB. Thanks.

request added to Trello - https://trello.com/c/KsoIeNLc

@dbaldon here are my YNAB settings as requested:
[{"key":"accountsClearSelection","value":false},{"key":"accountsDisplayDensity","value":"0"},{"key":"accountsEmphasizedOutflows","value":true},{"key":"accountsRowHeight","value":"0"},{"key":"accountsSelectedTotal","value":false},{"key":"accountsStripedRows","value":false},{"key":"activityTransactionLink","value":true},{"key":"betterScrollbars","value":"1"},{"key":"budgetBalanceToZero","value":true},{"key":"budgetProgressBars","value":"0"},{"key":"budgetQuickSwitch","value":false},{"key":"budgetRowsHeight","value":"0"},{"key":"calendarFirstDay","value":"0"},{"key":"categoryActivityPopupWidth","value":"1"},{"key":"changeEnterBehavior","value":true},{"key":"checkCreditBalances","value":false},{"key":"checkNumbers","value":false},{"key":"closeReconcileWindow","value":false},{"key":"collapseExpandBudgetGroups","value":true},{"key":"collapseSideMenu","value":false},{"key":"colourBlindMode","value":false},{"key":"compactIncomeVsExpense","value":false},{"key":"currentMonthIndicator","value":false},{"key":"daysOfBuffering","value":true},{"key":"daysOfBufferingHistoryLookup","value":"0"},{"key":"editButtonPosition","value":"2"},{"key":"enableRetroCalculator","value":false},{"key":"enlargeCategoriesDropdown","value":true},{"key":"enterInRegisterNow","value":false},{"key":"goalIndicator","value":true},{"key":"goalIndicatorWarningColor","value":false},{"key":"googleFontsSelector","value":"0"},{"key":"hideAOM","value":false},{"key":"hideHelp","value":true},{"key":"highlightNegativesNegative","value":true},{"key":"importNotification","value":"0"},{"key":"incomeFromLastMonth","value":"1"},{"key":"l10n","value":"0"},{"key":"largerClickableIcons","value":false},{"key":"monthlyNotesPopupWidth","value":"0"},{"key":"navDisplayDensity","value":"0"},{"key":"options.dark-mode","value":false},{"key":"pacing","value":"0"},{"key":"popupCalculator","value":true},{"key":"printingImprovements","value":false},{"key":"privacyMode","value":"0"},{"key":"reconciledTextColor","value":"0"},{"key":"removePositiveHighlight","value":true},{"key":"removeZeroCategories","value":true},{"key":"reports","value":true},{"key":"resizeInspector","value":false},{"key":"rightClickToEdit","value":true},{"key":"runningBalance","value":true},{"key":"seamlessBudgetHeader","value":false},{"key":"showIntercom","value":false},{"key":"spareChange","value":false},{"key":"splitKeyboardShortcut","value":false},{"key":"splitTransactionAutoAdjust","value":false},{"key":"squareNegativeMode","value":false},{"key":"stealingFromNextMonth","value":false},{"key":"swapClearedFlagged","value":false},{"key":"toBeBudgetedWarning","value":false},{"key":"toggleSplits","value":false},{"key":"toggleTransactionFilters","value":"1"},{"key":"warnOnQuickBudget","value":false}]

@danieldbird Thanks.

@danieldbird I think this was a feature request? I think it might also be a feature request for the Warn When Target Balance is Not Reached feature that made it out in 1.0.0?
If I'm wrong feel free to reopen!

You are right. It was a feature request. You solved it with the "Warn when target balance is not reached". You wizard. Thanks.


response 404

Why can I get a normal response when accessing the address without a proxy server, but when accessing it through a proxy, I receive a 404 response code?
~ ❯ curl test.51kys.cn:7681/api/general/package/list -sv -x <IP_ADDRESS>:3128
*   Trying <IP_ADDRESS>:3128...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 3128 (#0)
> GET http://test.51kys.cn:7681/api/general/package/list HTTP/1.1
> Host: test.51kys.cn:7681
> User-Agent: curl/7.88.1
> Accept: */*
> Proxy-Connection: Keep-Alive
>
< HTTP/1.1 404 Not Found
< Server: nginx/1.24.0
< Date: Mon, 07 Aug 2023 05:37:01 GMT
< Content-Type: text/html
< Content-Length: 153
< Connection: keep-alive
<

<title>404 Not Found</title>

404 Not Found

nginx/1.19.9

* Connection #0 to host <IP_ADDRESS> left intact

~ ❯ curl test.51kys.cn:7681/api/general/package/list -sv
*   Trying <IP_ADDRESS>:7681...
* Connected to test.51kys.cn (<IP_ADDRESS>) port 7681 (#0)
> GET /api/general/package/list HTTP/1.1
> Host: test.51kys.cn:7681
> User-Agent: curl/7.88.1
> Accept: */*
>
< HTTP/1.1 200 OK
< Cache-Control: no-cache
< Pragma: no-cache
< Content-Length: 53
< Content-Type: application/json; charset=utf-8
< Expires: -1
< Server: Microsoft-IIS/7.5
< Access-Control-Allow-Origin: *
< Access-Control-Allow-Headers: Content-Type
< Access-Control-Allow-Methods: GET, POST, PUT, DELETE, OPTIONS
< X-AspNet-Version: 0
< X-Powered-By: WAF/2.0
< Date: Mon, 07 Aug 2023 05:27:52 GMT
<
* Connection #0 to host test.51kys.cn left intact
{"code":1,"message":"请求头参数timestamp为空"}%

nginx access log
"GET http://test.51kys.cn:7681/api/general/package/list HTTP/1.1" 404 153 "-" "curl/7.88.1"
nginx conf

It may be that the port number was lost during the forwarding process

problem fix
$host -> $http_host

Thats impressive that you are able to fix it on your own!


Update firebase-admin to 7.3.0

Updates com.google.firebase:firebase-admin from 7.2.0 to 7.3.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.google.firebase", artifactId = "firebase-admin" } ]

labels: library-update, semver-minor

@Mergifyio refresh

@Mergifyio refresh

@Mergifyio refresh

@Mergifyio refresh


How to push only audio? (no video)

Hi @ggdream, this is currently out of the objectives of this project.


(Fun Fact) # files account for 80% of my commits in the past 3 months.

[number of files] files account for 80% of my commits in the past 3 months.
We count number of files in commits, and then say 20 files account for 80% of my commits in last three months.

I'd like to work on this issue

@prasanth-varikallu great! Ask me here if you have any questions regarding the issue.

@yaronskaya I'm new to this and I'm unable to run the existing tests. Could you please let me know how I can run a single test? I used IntelliJ and I can't figure out a way to run a single test. Thanks


update packages

:white_check_mark: Build TheIdServer 7.0.3-fix-dependencies1-0016 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/46b9b5495d by @)


release 0.4.7 on npmjs.com

Hi,
I'd like to use the latest version 0.4.7 which implements the dot notation for the translation keys.
Please update the release on npmjs.com
Cheers

Only @jeresig can do that (it'd be great if there was an automatic publishing service - TravisCI to do that)

+1 would love to use dot notation
ping @jeresig or @KLicheR

@gjuchault what is your npm username? I can give you access to push releases.

Same (gjuchault)

Is there an ETA for npm version to be updated?

Sorry for the delay. I've just given @gjuchault access to the npm module, he should be able to publish now.

awesome

In fact; there is some problems with the dot notation (if you try to translate a real sentence that contains a dot - as in the tests -) they don't pass as they're treated as object paths. How should we reat that

Version 0.6.0 has been published


Conda install fails for python 3.7

Issue: conda install -c conda-forge ecmwf-api-client fails for python 3.7.
This leads to problems for a conda-package which depends on ecmwf-api-client and additionally requires python 3.7.
The latest files here are over three years old and support up to python 3.5. It seems that this has already been addressed by #3, but the build fails after merging.
On a side note, we found that pip uses ecmwf-api-client version 1.5.4 but the latest conda version is 1.4.

Environment (conda list):

# packages in environment at /home/peter9192/miniconda3/envs/testecmwfapi:
#
# Name                    Version                   Build  Channel
_libgcc_mutex             0.1                        main
ca-certificates           2019.10.16                    0
certifi                   2019.9.11                py37_0
ecmwf-api-client          1.5.4                    pypi_0    pypi
libedit                   3.1.20181209         hc058e9b_0
libffi                    3.2.1                hd88cf55_4
libgcc-ng                 9.1.0                hdf63c60_0
libstdcxx-ng              9.1.0                hdf63c60_0
ncurses                   6.1                  he6710b0_1
openssl                   1.1.1d               h7b6447c_3
pip                       19.3.1                   py37_0
python                    3.7.4                h265db76_1
readline                  7.0                  h7b6447c_5
setuptools                41.4.0                   py37_0
sqlite                    3.30.0               h7b6447c_0
tk                        8.6.8                hbc83047_0
wheel                     0.33.6                   py37_0
xz                        5.2.4                h14c3975_4
zlib                      1.2.11               h7b6447c_3

Details about  conda and system ( conda info ):

     active environment : testecmwfapi
    active env location : /home/peter9192/miniconda3/envs/testecmwfapi
            shell level : 3
       user config file : /home/peter9192/.condarc
 populated config files :
          conda version : 4.7.12
    conda-build version : not installed
         python version : 3.7.3.final.0
       virtual packages :
       base environment : /home/peter9192/miniconda3  (writable)
           channel URLs : https://repo.anaconda.com/pkgs/main/linux-64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/r/linux-64
                          https://repo.anaconda.com/pkgs/r/noarch
          package cache : /home/peter9192/miniconda3/pkgs
                          /home/peter9192/.conda/pkgs
       envs directories : /home/peter9192/miniconda3/envs
                          /home/peter9192/.conda/envs
               platform : linux-64
             user-agent : conda/4.7.12 requests/2.22.0 CPython/3.7.3 Linux/5.0.0-31-generic ubuntu/18.04.3 glibc/2.27
                UID:GID : 1000:1000
             netrc file : None
           offline mode : False

Are there any updates on this? I am encountering the same issue...


[stable/redis] Check API version capability

What this PR does / why we need it:
Use dynamic API version based on cluster compatibility instead of hard-coded API version which fails for some versions of Kubernetes.

/assign @tompizmor

FYI @prydonius @sameersbn @carrodher

/assign @sameersbn @carrodher

Bumped chart version to 3.0.6 not to conflict with #5259

/assign prydonius

@prydonius We didn't want to go this route. We officially support the current and previous minor versions of Kubernetes. So, using apps/v1beta2 is what we currently recommend and charts usually use.

/hold

@unguiculus does this mean that I need to remove apps/v1beta1 and only leave apps/v1 and apps/v1beta2?
By the way, in the same file there is still support for earlier versions of K8s: https://github.com/kubernetes/charts/pull/5260/files#diff-b9c86de901c59fa89e4d0b7544745a37R38

@unguiculus I updated all api versions. Do you think this is better?

Actually, I'll leave this to the maintainers.


Show element in single line diagram

As a user of OpenSCD I want to see all defined ConductiveEquipment, PowerTrasnformer and bus bar in the single line diagram.
Requirements:

The bus bar is not a defined element within the IEC 61850-6 but shall be a Bay element with a single! ConnectivityNode.
Try to reuse the existing svg icons from the icons.ts
out of scope here is the auto align. Use x and y coordinate of the namespace
x and y coordinates are relative nominal values
one nominal value shall be 50px
default x and y is 0

Details

@JakobVogelsang can you add this to https://github.com/openscd/open-scd/projects/7?


Fix link at secure-with-azure-ad-multiple-tenants.md

Fixes bad formatting for md link and corrects path itself

@Gargi-Sinha,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


UPSTREAM: 2059: [vendor change] treat ENODEV error as corrupted mount

Manual backport of https://github.com/openshift/azure-file-csi-driver/pull/79
This is a backport of the upstream fix to treat ENODEV as a corrupted
mount, but this patches the vendor dependency directly instead of
bumping mount-utils to v0.29.8 and pulling in massive changes with it.
/cc @openshift/storage

/jira cherrypick OCPBUGS-41164

/hold for https://github.com/openshift/kubernetes/pull/2083
I need that to merge first, then I'll bump mount-utils again to get the fix.

/jira refresh
/label backport-risk-assessed

/retest

/unhold

all tests passed!

lies!
/retest

/label cherry-pick-approved

/lgtm


Change BFLOAT16 data type/API support naming and prefix

Existing BFLOAT16 support is named with HALF or sh, which is not good as half
precision usually points to FP16 according to IEEE definition. We'd
specify this as BFLOAT16 instead of HALF. According to the discussion in
issue #2767, update related naming and prefix as BFLOAT16 and sb.
Details as:

Change the generic control flag from BUILD_HALF to BUILD_BFLOAT16;
Change the prefix of BFLOAT16 API from shxxxx to sbxxxx;
Change related file names and other related with above prefix also;

Closing due to objection raised in #2767 (naming/API already agreed on with the netlib team)

Reopened after further discussions in #2767, though most files will have been altered in the meantime unfortunately. (Opening a new PR may be easier than updating this - please do whatever seems more practical)
(And perhaps BUILD_BFLOAT is clear enough without the 16 that already features in BUILD_COMPLEX16 ?)

superseding with #2886 due to the number of code changes since the original PR


Support nack when queue is closed

Nack published messages when queue is closed.

I'm a bit unsure of the dead-letter exchange spec, please have an extra look on that one to see if it has the intended behaviour.

so if any matching queue is closed we raise and abort the publish, is that the intended behavior? is that how rabbitmq works too?

when are queues closed? just before getting deleted? when the server is shutting down? when a queue is "paused"?

@jage probably has better answers than me

so if any matching queue is closed we raise and abort the publish, is that the intended behavior? is that how rabbitmq works too?

Yes, nack is the intended behaviour, as per RabbitMQ. If we can't guarantee that we will deliver the message to all destinations (queues) I interpret the docs as we should nack. Though the type of failure is probably a bit different (Erlang process crash + observer restart etc).

By nack'ing one or more messages, the broker indicates that it was unable to process the messages and refuses responsibility for them

RabbitMQ nack.
Since we don't take responsibility anymore, it feels best to abort as early as possible and don't try to save anything.

when are queues closed? just before getting deleted? when the server is shutting down? when a queue is "paused"?

Yes, delete and shut down, but don't think we accept any new messages then so that's not our focus here.
This was something we started thinking about when we started handling index corruption https://github.com/cloudamqp/lavinmq/pull/318#issuecomment-1064961560
When we discover corruption, we will most likely crash altogether but in the future that might not be true, so I think this makes sense to ensure we keep compatibility.

IMHO this looks good, but would be good to see if we can provoke this failure in a real running server to see how it behaves.


CSS being applied globally on import

Hi,
I'm trying to apply a CSS file to a toolbox component using its theme property, like so:
import theme from 'nav.css'
<Navigation type='horizontal' actions={actions} theme={theme}/>

The theme import should be modular css and apply only to this instance of Navigation (as I understand it), but instead the css is applying globally. (e.g theme css: nav button { height: 20px } affects all nav button in the app, including later instances of Navigation).  Why is theme being applied globally on import?
CSS modules is set up correctly as far as I know, webpack.config coming from the official toolbox example project as listed below.
Any comment on this is appreciated.
webpack.config fragment:
      {
        test: /\.css$/,
        use: [
          "style-loader",
          {
            loader: "css-loader",
            options: {
              modules: true,
              sourceMap: true,
              importLoaders: 1,
              localIdentName: "[name]--[local]--[hash:base64:8]"
            }
          },
          "postcss-loader" // has separate config, see postcss.config.js nearby
        ]
      },

In react-toolbox-example on github, the same thing is happening.  I added body { background: green; } to SuccessButton.css, and the background went green.  If css is to be localised I would have thought this global application of styles on import wouldn't be happening.

I raised this as an issue at css-loader on github, and apparently css modules only works with class selectors, not 'native' selectors.  Which raises the question how then one overrides properties locally of elements like buttons in react-toolbox components.  Will have another look at the installation doc, but if any comment on this, it would be appreciated.

More or less solved.  Solution was to specify theme properties as listed in the docs as style classes.  eg for Navigation
.button {
...


[adhoc] Removing unused rule from aws2 tests

Removing unused rule from aws2 tests

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @aromanenko-dev (trivial one)

Run Java PreCommit


Missing dependencies

The following dependencies are missing when I run migrate:

path-parser
lodash._baseiteratee
lodash._baseuniq

@rondlite I will work on the PR once the DCO is signed off. May I know how you came across this issue? I was recently working on creating a migration for a api-plugin-tags and did not see the same. Just curious and also helpful for reproducing the issue for testing.

@MohanNarayana I am trying to figure out how to change the submitter, since the commit is signed of by me, but I committed it from a dev machine which I did not realize was linked to another account, so the DCO does not match the account email.
Wondering if I should just remove this PR and make a new one from the right account, since I can amend a signature but changing committer is not possible afaik.
I came across this issue when I was moving dev server to staging and this triggered an error about my version not right, so I ran migrate and got the error. Weird since they are not packages one would have installed globally, since can't think of other reason you would not get the missing dependencies.

@rondlite if there is no issue signing off with work account you should do that. If you have any restriction with that then I guess a new PR is the easiest way.

I guess I make new PR since running into new issue when trying to commit from work account (i am cto so yes, it was an option).
Was following DCO bot path
git push --force-with-lease origin missing-dependencies
Username for 'https://github.com': DemandDevOps
Password for<EMAIL_ADDRESS>
remote: Permission to reactioncommerce/api-migrations.git denied to DemandDevOps.
fatal: unable to access 'https://github.com/reactioncommerce/api-migrations.git/': The requested URL returned error: 403

didn't have restrictions but ran into permissions :wink:
redone the PR

Fixed in #33


Error while loading shared libraries when running the top level binary on nightly-2024-12-15

When running top level main and driver binaries which solely contain:
#![feature(rustc_private)]
use bevy_api_gen::*;

fn main() {
    panic!("hello");
    env_logger::init();
    rustc_plugin::driver_main(BevyAnalyzer);
}

#![feature(rustc_private)]
use std::{
    collections::HashMap,
    env,
    fs::{create_dir_all, File},
    io::{BufRead, Write},
    path::{Path, PathBuf},
    process::{Command, Stdio},
};

fn main() {
    panic!("hello");

    // rest of code
}

Running: cargo +nightly-2024-12-15 bevy-api-gen
yields:
cargo.exe: error while loading shared libraries: ?: cannot open shared object file: No such file or directory

Running: cargo-bevy-api-gen
yields:
<RESTOFPATH>/.cargo/bin/cargo-bevy-api-gen.exe: error while loading shared libraries: rustc_driver-b7b2de1973390798.dll: cannot open shared object file: No such file or directory

Is this an issue with this plugin or perhaps something upstream?

I can find the missing file under:
cargo.exe*          rustc.exe*                          rustdoc.exe*  rust-lldb*
cargo-clippy.exe*   rustc_driver-b7b2de1973390798.dll*  rustfmt.exe*  rust-windbg.cmd
cargo-fmt.exe*      rustc_driver-b7b2de1973390798.pdb   rust-gdb*     std-c09b6dac30a2ec7e.dll*
clippy-driver.exe*  rustc_main-a70fa1454646a0b9.pdb     rust-gdbgui*  std-c09b6dac30a2ec7e.pdb

Ah, you need to add that directory to your library load path. Idk how Windows works, but it would be LD_LIBRARY_PATH or DYLD_LIBRARY_PATH on Linux/macOS.

Ahhh... Yes this seems to be a windows thing... I've had to switch work environments and I expected windows cargo to work seamlessly, this runs on linux no problem


FIPS complaint binary for Debian

Is your feature request related to a problem? Please describe.
We have FIPS compliance requirements and hence we would like a FIPS compliant binary of Envoy
Describe the solution you'd like
FIPS compliant binary of Envoy or guidance on how we can build one.
Describe alternatives you've considered
This is a mandatory requirement.
Additional context
Add any other context or screenshots about the feature request here.

Thanks for the request, this is in the works but we don't yet have an ETA.

we won't be producing system packages long term. please follow https://github.com/envoyproxy/envoy/issues/16867 for "official" ones


Show alert when clicking on button action: "need to login" to Like/Upvote/Bookmark

Do same like we did with the Comment button, but with all other actions which require login (Like/Dislike/Bookmark-hide)

This issue seems to be for v1 and it is already referenced for v2 here: #803 . Maybe this issue can be closed.


Add improved docs

Initial checklist

[x] I read the support docs
[x] I read the contributing guide
[x] I agree to follow the code of conduct
[x] I searched issues and couldn’t find anything (or linked relevant results below)
[x] If applicable, I’ve added docs and tests

Description of changes
View rendered
Related-to: unifiedjs/unified#168.
/cc @nemo-omen @remcohaszing @ChristianMurphy @Murderlon @with-heart @joostdecock @mgan59

Codecov Report

Merging #25 (1ce9a3c) into main (c17866c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           34        34
=========================================
  Hits            34        34

Impacted Files
Coverage Δ

index.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c17866c...1ce9a3c. Read the comment docs.


[Anime|Manga] Boolean field of airing & publishing

Apart from the status field which tells you the status of the anime or manga as a string, this is a direct boolean response of whether the show/serial is airing or publishing.

Added


Error with travis_pypi_setup.py

Hi there - am trying this cookiecutter package out for the first time.  Thanks in advance!
I created initialized my repository, pushed it to github, and created/linked it with travis-ci.  I even pushed another build to get travis-ci to run the tests once (they failed but I wanted to make sure it was linked).
When I runn travis_pypi_setup.py I am getting this error:
~$ ./travis_pypi_setup.py
Traceback (most recent call last):
  File "./travis_pypi_setup.py", line 122, in <module>
    main(args)
  File "./travis_pypi_setup.py", line 107, in main
    public_key = fetch_public_key(args.repo)
  File "./travis_pypi_setup.py", line 61, in fetch_public_key
    data = json.loads(urlopen(keyurl).read())
  File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/json/__init__.py", line 312, in loads
    s.__class__.__name__))
TypeError: the JSON object must be str, not 'bytes'

Is there something else I need to do?  Do I need my own PGP key ?
Appreciate it -- am sure I am missing a step.

Hey @thornomad -- thanks for reporting!
It seems I forgot to test properly the script in Python 3, sorry about that!
I'll test it properly and send a PR soon, but I think you can solve the problem by updating the travis_pypy_setup.py script, in the function fetch_public_key, replace the line:
    data = json.loads(urlopen(keyurl).read())

for:
    data = json.loads(urlopen(keyurl).read().decode('utf-8'))

The reason is that in Python 3, urlopen(URL).read() returns bytes(), and we need to decode them into str objects before passing it to json.loads function.
Please let me know if this helps you or not.
Thanks!

Yes, that fixed it that part ... Thanks.
However, after I enter my PyPI password I receive this error:
Traceback (most recent call last):
  File "./travis_pypi_setup.py", line 122, in <module>
    main(args)
  File "./travis_pypi_setup.py", line 109, in main
    update_travis_deploy_password(encrypt(public_key, password))
  File "./travis_pypi_setup.py", line 51, in encrypt
    encrypted_password = key.encrypt(password, PKCS1v15())
  File "/Users/thornomad/.virtualenvs/cask-dl/lib/python3.4/site-packages/cryptography/hazmat/backends/openssl/rsa.py", line 583, in encrypt
    return _enc_dec_rsa(self._backend, self, plaintext, padding)
  File "/Users/thornomad/.virtualenvs/cask-dl/lib/python3.4/site-packages/cryptography/hazmat/backends/openssl/rsa.py", line 78, in _enc_dec_rsa
    return _enc_dec_rsa_098(backend, key, data, padding_enum)
  File "/Users/thornomad/.virtualenvs/cask-dl/lib/python3.4/site-packages/cryptography/hazmat/backends/openssl/rsa.py", line 119, in _enc_dec_rsa_098
    res = crypt(len(data), data, buf, key._rsa_cdata, padding_enum)
TypeError: initializer for ctype 'unsigned char *' must be a bytes or list or tuple, not str

I switched over to a 2.7 virtual environment after that point, however, and used 2.7 and it worked fine.

Hm, yeah -- I'm reinstalling my Linux system now, will have a look at this as soon as possible.
Thank you for reporting!

One other thing - I have had to add the line:
python: 3.5

To the .travis..yml file in order to get the py35 builds to pass.  I had to do this with another repo as well.  Otherwise you will get an ERROR: InterpreterNotFound: python3.5 for that set of tox tests.  Thanks!  I think I'm ready to get started...

This was fixed in https://github.com/audreyr/cookiecutter-pypackage/pull/74 and https://github.com/audreyr/cookiecutter-pypackage/commit/2621b10a96b17ee1bfe3e8bb914397ddda26b7d6


Ignore fixup commits

When using the commit-msg hook it would be nice to ignore fixup commits. For CI purposes I see that it could make sense to block them since you don't want to merge fixup commits, but that's not the goal of this tool.
My workaround for this is just using this as the hook: sed "s/^fixup! //" < "$1" | dart run commitlint_cli

Do you mean you want this package do nothing if the commit message contains some characters?

Exactly, it should just allow commits with certain prefixes like !fixup

0.6.0-pre.0 is released with this support


[Feature Request] default filter on dictionnary and undefined parent key

Expected Behavior
If the parent key non_existent_key does not exist, the print statement should print the default value string.
For details (and some workarounds found by the community), see:

https://stackoverflow.com/questions/19614027/jinja2-template-variable-if-none-object-set-a-default-value
https://github.com/ansible/ansible/issues/30944

Actual Behavior
If the parent key does not exist, it throws an error.
Template Code
{{ mydict.non_existent_key.var | default("string") }}

I'm working on this.


tf.keras.applications.mobilenet_v3.preprocess_input documentation not according source code

In https://www.tensorflow.org/api_docs/python/tf/keras/applications/mobilenet_v3/preprocess_input
Said  that:
Preprocessed numpy.array or a tf.Tensor with type float32.
The inputs pixel values are scaled between -1 and 1, sample-wise.
However in source code in GitHub you find this:
@keras_export('keras.applications.mobilenet_v3.preprocess_input')
def preprocess_input(x, data_format=None):  # pylint: disable=unused-argument
return x
And if you check it in a notebook you see that as source code state it is doing nothing. Do not scale and do not change dtype to float32 of the input.

Thanks for reporting the issue.
To give more context, the preprocess_input() was a standard method for all models to normalize the input data. However, it is quite common that user forget to call this method before they feed the data to model, which result into poor result. When we realized this problem, we move the preprocessing logic from this method to the model itself for some new models (like mobilenet_v3). In order to keep the alignment between old and new model, we still keep this method for new model, but as an empty shell, so that user can easily switching between different version of models without changing much code.
I will update the docstring for this method to make it align with the implementation detail.

The nightly view shows what the current state is.
https://www.tensorflow.org/api_docs/python/tf/keras/applications/mobilenet_v3/preprocess_input?version=nightly

Something is wrong:
https://github.com/keras-team/keras/issues/14637#issuecomment-2246743316


Add path-style addressing support

Description

This PR extends support to other S3 object storage like MinIO which has path-style addressing to access bucket/object.
An example is like
from s3torchconnector import S3ClientConfig, S3MapDataset, S3IterableDataset

DATASET_URI="s3://<BUCKET>/<PREFIX>"
REGION = "us-east-1"
s3client_config = S3ClientConfig(path_style=True)

iterable_dataset = S3IterableDataset.from_prefix(DATASET_URI, region=REGION, s3client_config=s3client_config)

for item in iterable_dataset:
  print(item.key)

map_dataset = S3MapDataset.from_prefix(DATASET_URI, region=REGION, s3client_config=s3client_config)

item = map_dataset[0]

bucket = item.bucket
key = item.key
content = item.read()
len(content)

And
from s3torchconnector import S3Checkpoint, S3ClientConfig

import torchvision
import torch

CHECKPOINT_URI="s3://<BUCKET>/<KEY>/"
REGION = "us-east-1"
s3client_config = S3ClientConfig(path_style=True)
checkpoint = S3Checkpoint(region=REGION, s3client_config=s3client_config)

model = torchvision.models.resnet18()

with checkpoint.writer(CHECKPOINT_URI + "epoch0.ckpt") as writer:
    torch.save(model.state_dict(), writer)

with checkpoint.reader(CHECKPOINT_URI + "epoch0.ckpt") as reader:
    state_dict = torch.load(reader)

model.load_state_dict(state_dict)

Additional context

[ ] I have updated the CHANGELOG or README if appropriate

Related items

Fixes https://github.com/awslabs/s3-connector-for-pytorch/issues/208
Testing

The example code is run against play.min.io and it worked as expected.

By submitting this pull request, I confirm that my contribution is made under the terms of BSD 3-Clause License and I agree to the terms of the LICENSE.

CI failures are due to Rust v1.80, but local testing succeeded with Rust v1.70.

Hi @balamurugana, thanks for the contribution. Would you able to fix the failing unit tests, add basic tests for the new path_style feature (covering MountpointS3Client, S3Checkpoint, MapDataset, IterableDataset, S3LightningCheckpoint), and resolve linter errors (clippy for Rust, black for Python)?

Added unit and integration tests

@IsaevIlya @dannycjones @muddyfish This PR is ready for review again. If anything needed to be done, please let me know!

I see the integration test failure against AWS S3 is due to virtual-style enforcement.
2024-08-07T12:17:46.7603425Z 2024-08-07T12:17:14.992668Z DEBUG get_object{id=0 bucket="s3torchconnectorcistack-cibucketdeebc8b6-cozetiwes62w" key="github-actions-tmp/test_get_object_with_endpoint[True]/sample_files/1092671334757588674/hello_world.txt" range=None if_match=None}: mountpoint_s3_client::s3_crt_client: duration=36.034215ms request_id=98FYCBK1P53EKSSX error=ClientError(IncorrectRegion("eu-north-1")) meta request failed
2024-08-07T12:17:46.7610837Z 2024-08-07T12:17:14.992711Z DEBUG get_object{id=0 bucket="s3torchconnectorcistack-cibucketdeebc8b6-cozetiwes62w" key="github-actions-tmp/test_get_object_with_endpoint[True]/sample_files/1092671334757588674/hello_world.txt" range=None if_match=None}: mountpoint_s3_client::s3_crt_client: meta request result: MetaRequestResult { response_status: 301, crt_error: Error(14343, "aws-c-s3: AWS_ERROR_S3_INVALID_RESPONSE_STATUS, Invalid response status from request"), error_response_headers: Some(Headers { inner: 0x7fdd84001a30 }), error_response_body: Some("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Error>PermanentRedirect<Message>The bucket you are attempting to access must be addressed using the specified endpoint. Please send all future requests to this endpoint.</Message><Endpoint>s3torchconnectorcistack-cibucketdeebc8b6-cozetiwes62w.s3.amazonaws.com</Endpoint><Bucket>s3torchconnectorcistack-cibucketdeebc8b6-cozetiwes62w</Bucket><RequestId>98FYCBK1P53EKSSX</RequestId><HostId>hA/BQts+xKuFIBkPdvhrWksYCOCIES3VDtcfWHj3PFwnAmb4T/YR10QNXuOxvgmPDwyyaJMy7KA=</HostId></Error>") }
2024-08-07T12:17:46.7616725Z =========================== short test summary info ============================
2024-08-07T12:17:46.7618388Z FAILED s3torchconnectorclient/python/tst/integration/test_mountpoint_s3_integration.py::test_get_object_with_endpoint[True] - s3torchconnectorclient._mountpoint_s3_client.S3Exception: Client error: Wrong region (expecting eu-north-1)
2024-08-07T12:17:46.7619766Z ======================== 1 failed, 49 passed in 39.92s =========================

I will remove force_path_style=True test for s3torchconnectorclient/python/tst/integration/test_mountpoint_s3_integration.py:test_get_object_with_endpoint

@IsaevIlya @dannycjones @muddyfish I addressed all review comments and updated the PR accordingly. If anything needed to be done, please let me know!


Added Linux Setup Scripts + Fixed TLS Incompatibility Error

More information TLS error here (link below). Powershell defaults to TLS 1.0 which was incompatible and caused download errors when running ./windows/StartGeth.ps1.
https://stackoverflow.com/questions/41618766/powershell-invoke-webrequest-fails-with-ssl-tls-secure-channel


Put escaped names into compression map

After this PR, the escaped form of the name will be inserted into the compression map rather than the partially unescaped form. This is slightly non-optimal as certain names won't compress even though they're identical, this could be improved in future, but it's not a bug as compression is purely optional.
This only partially addresses #841, the rest of it will be fixed in a follow up PR once #833 has been merged.
Updates #841

Codecov Report

Merging #842 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
- Coverage   57.67%   57.65%   -0.03%
==========================================
  Files          43       43
  Lines       10862    10856       -6
==========================================
- Hits         6265     6259       -6
  Misses       3507     3507
  Partials     1090     1090

Impacted Files
Coverage Δ

msg.go
78.77% <100%> (-0.21%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a220737...5611856. Read the comment docs.

(@miekg You did a regular merge, not squash, here too).


Jobs list does not load after a recent update

All other PATRIC services work well

It's back.

Fixed in 10 min - wow!  Thanks much!


python311Packages.signify: 0.5.2 -> 0.6.0

Description of changes
Diff: https://github.com/ralphje/signify/compare/refs/tags/v0.5.2...v0.6.0
Changelog: https://github.com/ralphje/signify/blob/refs/tags/v0.6.0/docs/changelog.rst

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 296693 run on x86_64-linux 1

4 packages built:

python311Packages.signify
python311Packages.signify.dist
python312Packages.signify
python312Packages.signify.dist


Update on cad2unity

Hello, is there an update on this project? Im really interested on importing a STP into Unity at runtime!

Hello,
I think I will start working on this project in january.


Changing the Actor ID?

There's no information here (or anywhere that I can find) on whether or not you can change the Actor ID once the actor has been created.  It appears to be read-only inside the actor service, but that doesn't always mean that it can't be changed by some other mechanism.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 42b349f2-e868-298d-e68a-22caf855bea8
Version Independent ID: d4a5c657-7a1e-7acf-649c-9f27040c537e
Content: Reliable Actors on Service Fabric
Content Source: articles/service-fabric/service-fabric-reliable-actors-platform.md
Service: service-fabric
GitHub Login: @vturecek
Microsoft Alias: vturecek

Thanks for the feedback! We are currently investigating and will update you shortly.

@alovera I am not aware of a way to change the ActorID
@vturecek can you comment on this? And if we cannot, maybe we can add a note in the doc to make this clear

@aloevera, Got confirmation from the SF team that there is no way to change the ActorID. We will consider this closed.
#please-close


Varying frame rate caused video lagging.

Your environment.

Version: v3.1.41
Browser: Chrome Version 109.0.5414.119 (Official Build) (64-bit)
Other Information

What did you do?

Hi,
We've been using pion to build a server to browser app. The app runs in a loop that renders an image, converts that to H.264 and streams over to the browser in each iteration. So far the experience has been great!
During the development, we sometimes find that the video lags a lot in the browser. Loooking at webrtc stats, we noticed that [framesReceived - framesDecoded] has built up in these cases.

To have a better understanding of our app's behavior, it renders the image according to some user input. When there is no input for a while, the app just idles and stops sending any frames. Upon the next frame, it will be awaken. So there is a sudden frame rate change in this situation.
Here is the most related issues I could find online: https://bugs.chromium.org/p/chromium/issues/detail?id=1098514. In comment-11 one pion dev suggested to use WriteRTP() instead of WriteSample() to customize the RTP packet's timestamp. My questions are:

How exactly would RTP timestamp affect the frame's rendering time on the browser side. That is, what's the mechanism behind this:

If the frame rate suddenly increases from 20 fps to 30 fps and the RTP timestamps are set incorrectly it may happen that the 30 fps content is being played out at 20 fps which will cause the queue to grow.

Why would WriteRTP() be useful in this case? FWIW, we are using WriteSample(), but the duration calculation is still based on wall clock.

Would it be helpful if we just keep sending frames, instead of having possibly large idle time between two frames?

P.S. I've also read https://github.com/pion/webrtc/issues/2041, but that's indeed we are doing right now.
Thanks!
What did you expect?
Frame rate stays steady
What happened?
Frame rate lags (significantly sometimes).

Hey @not-an-error
Really sorry I didn't get to this sooner. I am making a bigger effort to triage Pion WebRTC issues.
You need some way to communicate the connection is still active. I don't know the idiomatic way to do that, would it be possible to send 4x4 black frames (some pre-encoded source) to communicate that connection is still alive?
You could also try adjusting the timestamps. However in the time when the connection is dead Chrome is going to be increasing the jitterbuffer etc..
Would love to know how you ended up resolving it. If you didn't I would love to help you take a stab at it!


Second Wind Not Adding Fighter Level

I’m running a Ftr 1 Cleric X, and I don’t get the +1 on my second wind. This also happened in Coparan when the dwarf warrior joins you to fight the soraks in the prison.

I didn’t understand what you mean.

game doesn't even detail the dices on second wind. not an issue.

Hey,
Thanks for responding. I see a roll at the bottom of the screen just like
when I attack, and it does not show a bonus like other rolls. I suspect
this is a multi class issue not a mod issue. My single class fighter in
another campaign does not have this problem, but my fighter/cleric does.
On Mon, Jan 2, 2023 at 1:21 PM Paulo Monteiro @.***>
wrote:

[image: image]
https://user-images.githubusercontent.com/13087646/210278741-7811e7d7-8ca4-425c-8d3b-e08e1418393b.png
game doesn't even detail the dices on second wind. not an issue.
—
Reply to this email directly, view it on GitHub
https://github.com/SolastaMods/SolastaUnfinishedBusiness/issues/2113#issuecomment-1369212572,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5BOVL6EIUYJ7PPMCQQB2K3WQNBDZANCNFSM6AAAAAATPBQYXM
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Thanks
Trevor


fix/journey-book-50: separate css styles into an external style sheet

Description
Fixes #50: Separate CSS styles into an external style sheet. It makes the CSS cleaner and more organized.
Checklist:

[x] I have performed a self-review of my own code
[x] My changes generate no new warnings

Please Revert the changes from the package-lock.json file. Let us know if you need any help!

I reverted it in dd62a82

Hey @ivanetra , thanks for your contribution on this, please create a journey for yourself :)

Anytime @KendallDoesCoding . Thank you!


Data hasn't been decoded even ABI is uploaded on Etherscan

Hi team,
regarding the issue #632 , it seems that the data haven't been decoded. Could you please help check whether your backend is updated?
I tried decoding using url https://safe-transaction.rinkeby.gnosis.io/ with signature 0x20b87853 but I got 404 Not Found.

I did verify the contracts.
https://rinkeby.etherscan.io/address/0x6f7ad059abaf4cf48fed85c1f4a24341d4014ced#code
https://rinkeby.etherscan.io/address/0xce4449c0b46a8cb7af895aee9a62fd3e4b69ab57#code
or is the abi specific per address? (if i call another contract whose has the same interface, it will not be decoded)

Did you do this?

If you create a Safe transaction calling an unknown contract (even if not executed), and the contract is present on Sourcify/Etherscan (or equivalent on the network), it will be automatically added to the Gnosis Safe transaction service within 1 hour.

So you would have to create txs calling 0xce4449c0b46a8cb7af895aee9a62fd3e4b69ab57 and 0x6f7ad059abaf4cf48fed85c1f4a24341d4014ced

I created a tx and wait for an hour but still not decoded (query via https://safe-transaction.rinkeby.gnosis.io/), please help check.
https://rinkeby.etherscan.io/tx/0xc56b708b9a7ac9685d49ec22ea50e54208f51fd1717ea2a06b4356de30fd17e1

You need to create a Safe transaction from our interface, not a regular ethereum transaction. We don't index all the blockchain 😉

This time I added the ABIs manually, for next ones you need to follow https://help.gnosis-safe.io/en/articles/4971390-submit-an-abi and create a Safe transaction 😉

I got your point, btw thanks for helping us.

No worries 👍🏻


Filesystem sizing should be configurable by a role (especially /var)

Hi
It would be interesting to have a role which allows customizing the size of the filesystem on the BB host.
This is especially true for the /var which tends to be very used, and could be considered as an independent FS.
The idea would be to have a role, and a config file which would describe the expected FS and sizes for those.

This already exists:
ep_partitioning: |
clearpart --all --initlabel
part /boot --fstype=ext4 --size=1024
part / --fstype=ext4 --size=60000
part /home --fstype=ext4 --size=4096 --grow


Remove HBase config field from topology config

We're relying on including resource files to the topology jar so putting HBase config in topology config is not in effect, and even it makes confusion. Better to remove it.

@HeartSaVioR There is a check here at https://github.com/hortonworks/storm/blob/HDF-<IP_ADDRESS>/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/AbstractHBaseBolt.java#L60
Right now there is an understanding between UI and flux generation code that UI will put a map with hbase.rootdir as a key and value in topology level config under hbaseConf key. We configure hbase bolt using withConfigKey("hbaseConf").  Before we remove it from UI we need to make sure that either UI is setting an empty {} in json for hbaseConf or change AbstractHBaseBolt to not throw that exception on a null for configKey

@priyank5485
Oh OK. Thanks for the detailed explanation.
Btw, since we're putting the resource files to the topology jar, I wonder we need to let user override the configuration. If we don't think we need to, we could just remove the config from the UI, and include the key to topology config with empty map.
After GA we need to get rid of putting the resources files, and provide flatten configuration map to the component directly to make sure spouts and bolts can connect to the multiple clusters. We can remove the placeholder config then.

I think for now we should go with not providing a way for user to override the configuration. Anyway in current state the only override we provided was hbase.rootdir. To provide other overrides we would need UI changes like a special dialog just to override hbase config.
@shahsank3t  For GA then, we just need UI change to remove hbase.rootdir and putting an empty map with hbaseConf in topology config. Can you take it up and send me a patch? I will test the topology.

@priyank5485 emailed you the UI patch.

https://github.com/hortonworks/streamline/pull/664

Priyank's patch got merged. Closing this.


error initializing configuration '/etc/envoy/envoy-rev0.json': invalid ipv4 address ''

Installed istio in default namespace, which I also have other services running, including headless service. Headless service has no cluster IP, thus istio proxy sidecar produced error:
03:40:00.800][32][critical][main] error initializing configuration '/etc/envoy/envoy-rev0.json': invalid ipv4 address ''

Should at least ignore headless service.

Fixed by https://github.com/istio/manager/commit/3debc8753580f6282832af5e3397b6ee3c616d95


External Google Tools break env() function for config:cache

Laravel Version: 6.2
PHP Version: 7.3.16
Database Driver & Version: MySQL

Description:
I recently ran php artisan config:cache and subsequently received a Google Search Console notification that my schema had errors, after looking into it extensively, I narrowed it down to the config:cache command and interactions with the env() function and the Google Structured Data Testing Tool: https://search.google.com/structured-data/testing-tool
I cannot reproduce the error independently from my own machine, if I load the page with config:cache and again after config:clear it produces identical HTML (verified with SFV hash check).
Steps To Reproduce:

Use a basic Laravel site
Create or modify a blade file to include {{ env('APP_URL', 'Google Sees This') }}
From the console run php artisan config:clear
Load the URL for the blade in a web browser, and inspect the source to observe the APP_URL value as set in the .env file
Load the page using Google Structured Data Testing Tool: https://search.google.com/structured-data/testing-tool
Observe the HTML markup in the tool shows the same APP_URL value
From the console run php artisan config:cache
Load the URL for the blade in a web browser, and inspect the source to observe the same APP_URL value as set in the .env file
Load the page using Google Structured Data Testing Tool: https://search.google.com/structured-data/testing-tool
Observe the HTML markup in the tool shows 'Google Sees This' instead of the correct APP_URL value from the .env file

Really weird error, but it seems like an external tool shouldn't be causing the .env() function to fail to return data from the .env file like this when config;cache is run.

Seems more likely an error with the tool and not laravel. A lot of these types of tools rely on brittle functionality to get data.

This also doesn't seems like a Laravel bug to me. Feel free to try a support channel.

Create or modify a blade file to include {{ env('APP_URL', 'Google Sees This') }}

The problem is that you are not meant to use the env function outside of config files. Once you cache your config files, Laravel will stop bothering to read your .env file to save performance.

@KeithTurkowski I always create a settings file myself if I need extra config options so yeah that's a valid approach. I try to leave the existing config files unaltered if possible.


Why the 'nyu40id2class' of Vote2Cap is different with that of these detection methods?

## VoteNet
(Pdb) DC18.nyu40id2class
{3: 0, 4: 1, 5: 2, 6: 3, 7: 4, 8: 5, 9: 6, 10: 7, 11: 8, 12: 9, 14: 10, 16: 11, 24: 12, 28: 13, 33: 14, 34: 15, 36: 16, 39: 17}
(Pdb) len(DC18.nyu40id2class)
18
(Pdb)

## Vote2Cap
(Pdb) self.dataset_config.nyu40id2class
{5: 2, 23: 17, 8: 5, 40: 17, 9: 6, 7: 4, 39: 17, 18: 17, 11: 8, 29: 17, 3: 0, 14: 10, 15: 17, 27: 17, 6: 3, 34: 15, 35: 17, 4: 1, 10: 7, 19: 17, 16: 11, 30: 17, 33: 14, 37: 17, 21: 17, 32: 17, 25: 17, 17: 17, 24: 12, 28: 13, 36: 16, 12: 9, 38: 17, 20: 17, 26: 17, 31: 17, 13: 17}
(Pdb) len(self.dataset_config.nyu40id2class)
37
(Pdb)

The Scan2Cap task requires localization of instances on categories beyond the pre-defined 18 categories used in 3D detection.
To be specific, the categories in the origin VoteNet implementation are:
{
    'cabinet':0, 'bed':1, 'chair':2, 'sofa':3, 'table':4, 'door':5,
    'window':6,'bookshelf':7,'picture':8, 'counter':9, 'desk':10, 'curtain':11,
    'refrigerator':12, 'showercurtrain':13, 'toilet':14, 'sink':15, 'bathtub':16, 'garbagebin':17
}

However, both scanrefer and nr3d contain annotations on "shoes", "monitors", "tvs" that are common in those 3D environments.
We follow the same category definition as Scan2Cap.


debug_full_compile_millis regressed by 2x

Since https://github.com/flutter/flutter/commit/f19e4ab4f7a74e89e2cf4b5de1e6963765d0728c,
-basic_material_app_android__compile debug_full_compile_millis regressed from ~24000ms to ~55000ms
-complex_layout_android__compile debug_full_compile_millis regressed from ~22000ms to ~55000ms.

CC @jonahwilliams

@digiter : is there any recent update in the device lab that could cause this regression (e.g., replaced the linux box)?

No, except I switched the phones on linux1 and linux2.

I cannot reproduce this on a local device. I'm also extremely skeptical that a version bump in a web debugging library regressed dar compilation time on Android.

I couldn't reproduce this issue either.
cc @dnfield. Could this be related to the changes you made to the JVM heap size?

I did update the gradle settings to make them consistent across linux1 and linux2 - I doubt that did it but i can try to look at it in the morning.

This is due to disabling the gradle daemon on the bots.
I would like to keep it disabled because currently, it runs until it leaks enough memory to fail a test for other reasons (anytime you see logs like "Java Heap Space" - see https://github.com/flutter/flutter/issues/39944).
I'm going to rebaseline the benchmarks. We should re-enable the gradle daemon either after fixing https://github.com/flutter/flutter/issues/31089 or updating the devicelab to more effectively manage state between test runs (e.g. use containers or kill the daemon between runs or so many times a day, etc.).
/cc @blasten @godofredoc

(I reproduced this locally by running the test with and without the gradle daemon - that can be disabled globally by setting org.gradle.daemon=false in your $HOME/.gradle/gradle.properties)

@dnfield : any update on this? Shall we close this now, or close this until https://github.com/flutter/flutter/issues/31089 is fixed and gradle daemon is re-enabled?

IMO we should leave this open until we re-enable the gradle daemon on CI - or, alternatively, we disable it for all customers.

@dnfield : any update on re-enabling gradle?

I am not working on this issue and not aware as to whether anyone is or not.  @blasten may know if it's on the docket.

Closing this as they've gone down to below 20000ms

Did the device lab reenable Gradle daemon recently?

I have no idea. CC @blasten on that question.

I'm not aware of such change. Maybe @godofredoc knows.

We haven't enabled graddle. This is a side effect of replacing the old machines with more powerful ones and installing linux as server rather than as desktop.

The Gradle daemon is enabled by default.  Was it explicitly disabled on the new machines?


[ROCKETMQ-8] Standardize build script.

Step1:
Remove original scripts.
JIRA Issue: https://issues.apache.org/jira/browse/ROCKETMQ-8

Sorry, we don't merge this PR.
IMO, there is step 2 you must finish :-)

@vongosling
I have finished all steps.

Thanks for your PR.
I have checked it. It's seems ok for me. please @stevenschew @zhouxinyu review it.

It seems ok.

review Ok!


SWARM-437 - Allow annotations to advertise services.

[X] Have you followed the guidelines in our Contributing document?
[X] Have you created a JIRA and used it in the commit message?
[X] Have you checked to ensure there aren't other open Pull Requests for the same issue?
[X] Have you built the project locally prior to submission with mvn clean install?

Motivation
In the case a person doesn't use a main(), and wants to perform
multiple advertisements, particularly those not based on the simplified
archive name, provide an @Advertise annotation.
Modifications
@Annotation is inspected for each archive, and can specify the
name of services to advertise.  It is a repeatable annotation
and several can be applied to any class, for whatever reason.
Result
@Advertise("tacos")
public class Tacos { ... }
Will cause the same behaviour as calling
archive.as(TopologyArchive.class).advertise("tacos")
on the deployed archive containing the aforementioned class.

Does this impact an archive without annotations or .advertise() calls such that presence of topology by default will advertise a service based on name of artifact?
Don't think it does from quick look at code, but wanted to check

@kenfinnigan you bring up a good point.
Currently, we do the full list of ArchivePreparers, which will auto-advertise.
Then, we do the full list of MetadataProcessors, which detect these annotations.
I'm trying a local build which swaps the direction of those.  Metadata first, then general ArchivePreparers.
Plus, trying to convince CI to be less goofy.

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please


Fix stock by ID dataloader

I want to merge this change because it fixes problem with dataloader that causes it to return stocks in wrong order. That in some situations (like in linked ticket) caused API to return data inconsistent with data from DB.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-7078 OrderFulfulfill change previously created fulfillment.


Create 0.1.3 installer

Once all Release 0.1.3 issues are out of the way the installer can be created and pushed to the main website.
This needs to be done in line with the procedure in the installer repo.

PREPARE
Ensure all issues are completed for milestone.
Update SPV checkpoints file.
Update the local help.
Update the localisation files from crowdin.com.
Merge from develop into master, tag code.
Final verification that functional tests (FEST, stress and emulator) run correctly.
Final verification that latest hardware wallet firmware is supported.
Create update-message.html for version check user notification.
Check correct copy of multibit-hd.jar is in installer target directory.
Check install4j auto-update points to updates.xml and NOT updates-test.xml
BUILD
Create and sign installer using Windows and Apple developer keys.
Create and check PGP signatures for binaries.
Create and check SHA256 files for binaries.
Create release note with SHA256 hashs of the binaries,
Verify the release note with earlier version of MultiBit HD.
RELEASE
Push binaries to website following the directory naming conventions (expect Reddit notification from this point).
Download installers from website and smoketest on each operating system.
Push the website code to multibit.org.
Issue general notification on social media Reddit/Twitter/BitcoinTalk if not already in place. Wait 24 hours for feedback.
Push to releases/multibit-hd/upgrade.xml so that auto updates start.

Released the following libraries which should be included:

MultiBit Commons - 1.1.0
BRIT Core - 0.3.0
Error Reporting Core - 0.3.0
hid4java - 0.4.0

See #652 for progress with bitcoinj and MultiBit Hardware.

Just for completeness...
Released MultiBit Hardware - 0.6.0

Installer has been completed and has been running live for a while so closing.


Blameable entity

is it possible to change the default blameable entity User to another class? I tried but it gave an ORM error.

What did you try exactly and what was the exact error message?

Hello, and thank you for your contribution.
In the interest of spring cleaning and package modernization, I'm going through and closing old issues that have had no recent activity and/or are no longer relevant.
If this problem is still relevant to you, please open a new issue with the appropriate information and steps to reproduce.
Thank you!


PluginManager.disablePlugin -> UnsupportedOperationExeption

When trying to disable a plugin without having a "disabled.txt" file in the plugins directory, DefaultPluginStatusProvider::disablePlugin() fails with an Exception.
As far as I can tell this is due to thet FileUtils::readLines returns Collections.emptyList() in case the files doesn't exist and DefaultPluginStatusProvider assigns this to disabledPlugins.
I assume the same would be true for enablePlugin.
/Cheers
Torgny
(Btw, nice framework :))

Thanks!
(This has to be the fastest reacting project of all times :))

Thanks! If you encounter other problems please let me know.


Support Multiple Windows Entrypoint Images

Feature request
Backwards compatibility for those who still require specifically ltsc2019 entrypoint images by including multiple windows definitions in the manifests such as this one. I've put together image manifests myself that include separate images for windows os.version "10.0.19042.XXX" vs "10.0.20348.XXX" so it hopefully ought be able to work here as well.
Use case
We'd like to be able to upgrade our Tekton version to be able to build on windows ltsc2022 nodes, but we cannot afford to break our existing ltsc2019 builders.
If I'm missing or misunderstanding anything about the situation that makes this not necessary, please let me know. (I haven't yet had the time to go actually try upgrading on a test cluster yet, but I'm extrapolating based on my previous experience with needing to match the windows image version exactly)

/assign

This should be pretty straightforward to accomplish. The combined base image is stitched together by a script in plumbing (https://github.com/tektoncd/plumbing/tree/main/cmd/combine) which takes two source images, but could fairly easily take 2+ so long as they don't have any overlaps in provided platforms.
I'll send a PR, and if things go well we should see this in an upcoming Tekton release.

With the change in https://github.com/tektoncd/plumbing/pull/1180 I'm able to produce a combined base image that has support for multiple Windowseses:
$ go run ./cmd/combine \
    gcr.io/distroless/static:nonroot \
    mcr.microsoft.com/windows/nanoserver:ltsc2022 \
    mcr.microsoft.com/windows/nanoserver:ltsc2019 \
    $OUT
$ crane manifest $OUT | jq '.manifests[].platform'
...
{
  "architecture": "s390x",
  "os": "linux"
}
{
  "architecture": "amd64",
  "os": "windows",
  "os.version": "10.0.20348.887"
}
{
  "architecture": "amd64",
  "os": "windows",
  "os.version": "10.0.17763.3287"
}

Looks great, really relieved about s390x support

Hey I managed to get this in before today's release!😎
https://github.com/tektoncd/pipeline/releases/tag/v0.39.0


Generalize dimensionlessLength

Now that Foldable is in the prelude, can we generalize dimensionlessLength :: Num a => [Dimensional v d a] -> Dimensionless a to (Foldable f, Num a) => f (Dimensional v d a) -> Dimensionless a?

Same comment on sum, whose prelude type also got generalized, and on mean.

Yes!

Will do this after we resolve #44 since it also impacts documentation.