done fixing the high score and play again button #9

Hello PA ,
By the time of assigning to this project I have seen that already the play again button is added but I have changed the name Restart game to "Play Again" which is more engagble to the audience. But I have seen one more problem that the high score is not updating properly, So I have fixed that issue too. The issue of high score image is given below.

After resolving the error the high score is updating correctly without any overlapping and merging. The image for updated high score is given below.

@YadavAkhileshh  please check this PR

@YadavAkhileshh  I have resolved conflicts please check once.

@YadavAkhileshh Hi please add me as a collaborator you're still using the wrong level labels also you need to add hacktoberfest-accepted label to each quality PRs, I'll update them


Update broccoli-filter version

I just released broccoli-filter 1.0.0 identical to 0.2.0, just to bump to 1.x.

Folded into #23.


A Passing Test for the Maximizer

These changes are also in https://github.com/kolmafia/kolmafia/pull/2197 but I pulled them out to isolate them and hopefully get feedback.  With two exceptions the changes were suggested by static code analysis or spotless.
One change was to explicitly set/reset the password hash in an ApiRequest.  The test itShouldMaximizeAndEquipSelectedWeapon would pass or fail depending upon the run context and the difference was the presence of the password hash in the body of the request.  Clearing the hash in the test that set it made itShouldMaximizeAndEquipSelectedWeapon work consistently.
The other change is itShouldMaximizeAndEquipSelectedWeapon.  It is supposed to be a test that mimics using the maximizer from the CLI or from a script (not the GUI).  It should demonstrate that the Maximizer chooses to equip a weapon and then equips the weapon.
Testing KoLCharacter.hasEquipped(ItemPool.SEAL_CLUB) fails but that is presumably because the request never actually gets executed.  Confirming that the equip request is submitted seems to be the best that can be done.
Feedback or approval is desired.  Is there a better or different way to test things actually being equipped by the Maximizer?
Tagging folks who are pretty good at telling me what I am missing or how I could have done something better.  @gausie @midgleyc @BadHorseMonkey @Veracity0
Thank you.

I think I resolved everything.


Implement a retry policy for client retry middleware

/cc @dbousamra

When we merge this to fs2:

\/ becomes Either
There should be two retriable policies: one that checks the method is idempotent, and a second that checks the method is idempotent and forbids a body. The former is more useful in more cases, but only the latter is safe.


chore(router): update nginx to 1.9.6

See http://nginx.org/en/CHANGES
spdy is gone is favor of http2 as of 1.9.5, but it's unclear to me if that would be a breaking change since Deis didn't advertise the availability of the spdy protocol. ping @helgi and @aledbf for review.

Based on #4542 we should be good to go

Based on #4542 we should be good to go

Is that an implicit LGTM?

Is that an implicit LGTM?

I thought so. :smiling_imp: But I want to wait until @aledbf has had time to field-test the new nginx as I know he will, so no rush.

so no rush.

:+1:

Code LGTM

I've tested this upgrade from v1.11.2 on an AWS cluster and discussed it with @aledbf after his testing.


Replace Axios calls with HttpClient

Old Behavior: used axios to make get/post request calls
New Behavior: use HttpClient to make get/post request calls, since axios does not officially support proxy
Fixes #21837

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

58 of 202 (28.71%)  changed or added relevant lines in 6 files are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.06%) to 42.265%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/azurecore/src/account-provider/auths/networkUtils.ts
1
2
50.0%

extensions/azurecore/src/account-provider/auths/azureAuth.ts
2
4
50.0%

extensions/azurecore/src/utils.ts
17
20
85.0%

extensions/azurecore/src/proxy.ts
12
26
46.15%

extensions/azurecore/src/account-provider/auths/httpClient.ts
25
149
16.78%

Files with Coverage Reduction
New Missed Lines
%

extensions/machine-learning/src/common/processService.ts
2
81.48%

extensions/notebook/src/jupyter/serverInstance.ts
4
75.5%

Totals

Change from base Build<PHONE_NUMBER>:
-0.06%

Covered Lines:
30863

Relevant Lines:
67801

💛  - Coveralls

@Charles-Gagnon the rest of the axios calls are for the ADAL library which is getting deprecated, and we plan to remove it completely by June/July.

That doesn't seem to be completely true, the main one I'm looking at is https://github.com/Microsoft/azuredatastudio/blob/86c3f315f22be13e1456ead6423f3c9f1a8aea39/extensions/azurecore/src/azureResource/utils.ts#L342
which is used by a number of helper functions, such as getManagedDatabases. These calls are for fetching lists of Azure resources so are independent of the auth method being used.

Ok seems like it will need to get replaced there as well

https://github.com/microsoft/azuredatastudio/issues/22431 I created this issue to track it


FailedShack.USBHelperInstaller version 1.2

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

For some reason I cant understand, when ran from winget it fails with a error about not finding a internet connection and a File Open Error. Running the installer outside of winget manually works fine aside from the lack of a /s flag which I'm going to ask the dev about

Will do, will either come back with a fix or close

Dev has not gotten back to me on issue, going to close for now


Throw some exceptions or warning when use incorrect sls endpoint and rds host

in e-mapreduce, users need to use intranet endpoint for sls
in e-mapreduce, users need to use intranet host for rds

won't fix


Increase Cocoa Pods Version

Please update the podspec so that running pod update TPKeyboardAvoiding will grab the latest code (which has some iOS 11 fixes in my case).
Cocoapods Version hasn't been updated in a year...
Current workaround is to directly reference git in the pod file:
pod 'TPKeyboardAvoiding', :git => 'https://github.com/michaeltyson/'TPKeyboardAvoiding.git'

We are missing a new release, not only a pod spec update. 😏 I need this too.

Done!


SwinjectStoryboard don't work with Cocoapods 1.5.0

Next version of Cocoapods add static library support for Swift.
In SwinjectStoryboard+SetUp.m I have 'SwinjectStoryboard/SwinjectStoryboard-Swift.h' file not found.

I haven't been able to reproduce the issue using
cocoapods 1.5.0.beta.1
Xcode 9.2
SwinjectStoryboard 1.1.2

Can you provide more info about the issue?

I have made this empty project to show the issue.
I have the same configuration.
cocoapods 1.5.0.beta.1
Xcode 9.2

testSwinjectStoryboard.zip

I see, it does not work properly with the new use_frameworks!(false) directive.
As I mentioned in #87 we don't want to force the static framework on all the users (which was the only option until cocoapods 1.4.0), but we should make it possible to build SwinjectStoryboard as static library if user chooses to do so.
Thanks for pointing this out! 👍

Thanks for your stewardship of this project.
Sent with GitHawk


feat(just): add flatpaks to path

The shebang is there because it would throw a whitespace error without it.

@Renner0E can you clarify the purpose? I understand that flatpak/exports/bin is added to PATH... and yes, it works

It just makes it a little less annoying to launch flatpaks in the terminal. Nothing special it's just nice to have from my point of view.

instead of running flatpak run org.gnome.Contacts wanting to run gnome-contacts).

I'd love this but it's probably not going to happen anytime soon because of security concerns

if approving I'd suggest changing the order of priority such that the user's personal flatpaks have higher PATH priority than system-wide

Thanks for pointing that out! I Fixed it in a new commit.
AFAIK The first file/directory in your $PATH has the most priority. So you'd have to add it later because it gets inserted at the beginning of the line. Works on my machine™.
@akdev1l If I understood this correctly then this would also affect non-interactive shells aka. launching a script/subshell.
Arch Linux ships this script by default with the flatpak package.
I actually thought that it is normal to have flatpaks in the $PATH on linux because of this. Until I tried Fedora at least.

Arch Linux ships this script by default with the flatpak package.

Ah, that clears up why this might be expected; I appreciate the context.
I feel like this is a nice-to-have change, but is more about making Universal Blue "Arch-like" than fixing something wrong or missing in Fedora. When faced with "maybe" situations, I always try to go back to https://universal-blue.org/scope/ and see if the change obviously fits with staying "close(ish) to Fedora" or not.
My vote is no, because I try to keep the top level Universal Blue "main/nvidia" images as close to stock Fedora as we can within our scope. However, this could be a nice inclusion for downstream images. Both Bazzite and Bluefin are doing LOTS of stuff that is more unique and opinionated, as an example.


No "exports" main defined in /node_modules/gpt-token-utils/package.json

[ERR_PACKAGE_PATH_NOT_EXPORTED]: No "exports" main defined in /Users/***/workspace/dev/ts/ts-utils/node_modules/gpt-token-utils/package.json
// src/openai/token.ts
import { encode, decode } from 'gpt-token-utils';

// Encode a string to a list of tokens...
const tokens = encode('Humans are strange creatures, and ever so curious too!');

// You've got a list of tokens!
console.log(tokens); // [32661, 504, 389, 6283, 8109, 11, 290, 1683, 523, 11040, 1165, 0]

// How many tokens are there?
console.log(tokens.length); // 6

// Can we decode it back to text?
console.log(decode(tokens));

how to occur the bug:
ts-node src/openai/token.ts
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: No "exports" main defined in /Users/***/workspace/dev/ts/ts-utils/node_modules/gpt-token-utils/package.json
    at new NodeError (node:internal/errors:393:5)
    at throwExportsNotFound (node:internal/modules/esm/resolve:358:9)
    at packageExportsResolve (node:internal/modules/esm/resolve:612:7)
    at resolveExports (node:internal/modules/cjs/loader:529:36)
    at Function.Module._findPath (node:internal/modules/cjs/loader:569:31)
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:981:27)
    at Function.Module._resolveFilename.sharedData.moduleResolveFilenameHook.installedValue [as _resolveFilename] (/Users/yanqi/Library/pnpm/global/5/.pnpm/@cspotcode+source-map-support@0.8.1/node_modules/@cspotcode/source-map-support/source-map-support.js:811:30)
    at Function.Module._load (node:internal/modules/cjs/loader:841:27)
    at Module.require (node:internal/modules/cjs/loader:1061:19)
    at require (node:internal/modules/cjs/helpers:103:18) {
  code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}

system: MacOS 13.3
nodejs version: 18

Unfortunately, I have also encountered this issue and hope that the maintainer can resolve it as soon as possible.


No need to select Advanced when mount storage enabled private endpoints.

There are two ways to mount storage to Web Apps via Azure Portal: [Basic] and [Advanced].

For Basic, Portal will automatically obtain an access key for the storage account.
For Advanced, you need to manually fill in the access key for the storage account.

In other words, this is the same behavior, and it does not depend on the existence of a private endpoint for the storage account.
Why do I have to select Advanced if private endpoints are enabled for the storage account?
My understanding is that we can choose [Basic] or [Advanced] without if or not private endpoints enabled.
https://learn.microsoft.com/en-us/azure/app-service/configure-connect-to-azure-storage?tabs=portal&pivots=container-linux&branch=main#mount-storage-to-linux-container

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3cd70fac-5d7c-7637-8385-f3f4af3ba0ad
Version Independent ID: 15d95fc5-f08e-a26c-ce06-8ead78474661
Content: Mount Azure Storage as a local share - Azure App Service
Content Source: articles/app-service/configure-connect-to-azure-storage.md
Service: app-service
GitHub Login: @msangapu-msft
Microsoft Alias: msangapu

@kogepanh
Thanks for your feedback! We will investigate and update as appropriate.

Hi @kogepanh, I did reach out the product team regarding your feedback. Advanced options entry form was initially used when VNet supported was added to BYOS, and customers would have to manually provide the connection details. Later, the implementation was changed load this information on behalf of the customer. This redundancy is known and will be addressed in a planned future update. The doc should be updated relatively soon thereafter.
If you have any further questions, please feel free to @ me in your comment.
#please-close


Popups immediately disappear when editor is scrolled right at all

Issue Type: Bug
Scroll right just 1px and some error popups will blink and then immediately disappear.
I disabled all extensions before reporting this, though enabling some does seem to make the problem worse it definitely exists in base VS Code.  See video:

VS Code version: Code 1.35.0 (553cfb2c2205db5f15f3ee8395bbd5cf066d357d, 2019-06-04T01:16:40.241Z)
OS version: Darwin x64 18.6.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-8259U CPU @ 2.30GHz (8 x 2300)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (0.72GB free)

Process Argv
.

Screen Reader
no

VM
0%

Extensions: none

Appears related to #75374


[incubator/fluentd-cloudwatch] Update api version for daemonset to apps/v1

[incubator/fluentd-cloudwatch] Update api version for daemonset to apps/v1
Signed-off-by: Thomas Schmitt<EMAIL_ADDRESS>
Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

No.
What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[X] DCO signed
[X] Chart Version bumped
[X] Variables are documented in the README.md
[X] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign maorfr

/ok-to-test


Data inconsistency - June

We have a data inconsistency for June.

day
big query

clickhouse

2024-06-13 00:00:00.000000 UTC
1637900845

1636869244

2024-06-14 00:00:00.000000 UTC
1538345093

1493327250

2024-06-15 00:00:00.000000 UTC
931140856

925377511

2024-06-16 00:00:00.000000 UTC
882671302

879692335

2024-06-17 00:00:00.000000 UTC
1583569153

1300349510

2024-06-18 00:00:00.000000 UTC
1671772953

506601749

2024-06-19 00:00:00.000000 UTC
1471450565

155359935

2024-06-20 00:00:00.000000 UTC
1602016032

62077667

2024-06-21 00:00:00.000000 UTC
1574405719

633383446

This requires some materialized views to be rebuilt for this period. Rebuild is partial unless stated:

[x] pypi_downloads (full)
[x] pypi_downloads_by_version (full)
[x] pypi_downloads_max_min (full)
[x] pypi_downloads_per_day
[x] pypi_downloads_per_day_by_version
[x] pypi.pypi_downloads_per_day_by_version_by_country
[x] pypi_downloads_per_day_by_version_by_file_type
[x] pypi_downloads_per_day_by_version_by_installer_by_type
[x] pypi_downloads_per_day_by_version_by_installer_by_type_by_country
[x] pypi_downloads_per_day_by_version_by_python
[x] pypi_downloads_per_day_by_version_by_python_by_country
[x] pypi_downloads_per_day_by_version_by_system
[x] pypi_downloads_per_day_by_version_by_system_by_country
[x] pypi_downloads_per_month (full)

fixed @kellytoole


Limit inbound download and verify queue

Motivation
The Inbound service's Downloads queue can grow without limit.
See #1618 for some general background.
Solution
Drop new requests when the Inbound downloads queue reaches a fixed limit.
The code in this pull request has:

[x] Documentation Comments
[x] Manual Tests

I tested it on mainnet and testnet over the weekend, and it seemed to have a similar pattern of running well, but eventually hanging (due to a known issue #1435)
The new warning did not appear in the logs on mainnet or testnet

Review
This change is a lower priority than #1620, so I'm not going to tag anyone for review.
Follow Up Work
Do the rest of #1618.

I think we've dealt with all the concerns here, so I'm going to merge this PR so we can focus on other work.
If there's anything we need to fix, let's open another ticket.

I think we've dealt with all the concerns here, so I'm going to merge this PR so we can focus on other work.
If there's anything we need to fix, let's open another ticket.


printf stops printing after first newline

It appears that for some strange reason the regular C printf() function stops printing when it encounters the first newline (\n) in a string. This can be trivially reproduced by attempting to print two lines in the one call; see below for a patch to the official 01_hello_world example.
diff --git i/examples/01_hello_world/main/hello_world_main.c w/examples/01_hello_world/main/hello_world_main.c
index ad2c0ac..ca907ea 100644
--- i/examples/01_hello_world/main/hello_world_main.c
+++ w/examples/01_hello_world/main/hello_world_main.c
@@ -14,7 +14,7 @@

 void hello_task(void *pvParameter)
 {
-    printf("Hello world!\n");
+    printf("Hello world!\nHiding in plain sight...\n");
     for (int i = 10; i >= 0; i--) {
         printf("Restarting in %d seconds...\n", i);
         vTaskDelay(1000 / portTICK_RATE_MS);

Despite applying the above patch, the output stays at:
Hello world!

If using the %s modifier, a newline in the argument string also causes printf() to stop outputting characters, effectively cutting short the output. E.g.
printf("Hello%s world!\n", "Hiding\n in plain sight...");

yields the following output:
HelloHiding

That @jmattsson . I committed a patch for this into our review queue yesterday, it's a bug in the write syscall.
Because everyone's on holidays this week I'm not sure if we'll get the merged to github until next week (review policy), but I might be able to pop up a temporary branch.

Really? I instrumented _write_r() but by the time it got there the string had already been truncated at the \n.

Yeah it's not an obvious bug though., _write_r should return number of bytes written, but doesn't. Stdout is line buffered by default: so the first line gets sent to _write_r & TXed,, _write_r returns zero, newlib discards the rest of the buffer thinking there was an error.
Fix is incoming now, should be auto-pushed github shortly...

Ah, sneaky bug! Glad it was an easy fix though.


WIP: userinfo - 3

@cheungpat, thanks for your PR! By analyzing the annotation information on this pull request, we identified @rickmak to be a potential reviewer


⚠ Homepage (omg.lol) has degraded performance

In fd81751, Homepage (omg.lol) (https://8bit.lol/) experienced degraded performance:

HTTP code: 503
Response time: 258 ms

Resolved: Homepage (omg.lol) performance has improved in 3bde70e after 1 hour, 2 minutes.


Regenerate implementation tool sample

Description
The comments in the samples directory for implementation cli tool require updating.
There is one difference that I don't understand which is the last output for the lorem property.
The old output refers to the object class but the new output is more cryptic.

Thanks @nulty

FWIW the last example is broken because the expansion of escaped macro seems to not be handling well the tracking of the expanded_location.


Add easier method for creating pack summary

Pack Summary is a nice feature, but it was pointed out it's a bit hard to use from the outside.
Since we'll likely have an expansion packs mod soon, I've added an easier way of adding your own pack summary while keeping the old style for compatibility sake. Although, I do think it's a bit cumbersome and might be worth removing the text file at some point. It's noticeable in the amount of packs that were PR'ed without a summary or tags. The error logging is a nice touch, but it's easy to miss since there are so many logging calls that early into the intialization.

Makes sense given that we want to split out some packs. FYI I set this up with all the data in one file so that I could add and manage all the ratings and tags in bulk, without needing to touch every pack file. It was much faster and easier that way, especially since I had all the ratings and tags in a spreadsheet.

#639 does this in a different way

Due to #639 being merged and being a better way to solve it, this change is not obsolete


Bug: RunIf doesn't work in a bash task

This part of a pipeline:
                tasks {
                  bash {commandString = 'false'}
                  bash {
                    commandString = 'echo I am bash with runIf=failed'
                    runIf = 'failed'
                  }
                  exec {
                    commandLine = ['echo', 'I am exec with runIf=failed']
                    runIf = 'failed'
                  }
                  bash {
                    commandString = 'echo I am bash with runIf=any'
                    runIf = 'any'
                  }
                  exec {
                    commandLine = ['echo', 'I am exec with runIf=any']
                    runIf = 'any'
                  }
                }

produces this result:
##|01:55:12.644 [go] Start to build My-pipeline/17/Build/1/Test-runIf on my-agent [/var/lib/go-agent]
!!|01:55:12.655 [go] Task: bash -c false
?1|01:55:12.766 [go] Task status: failed (110 ms) (exit code: 1)
!!|01:55:12.766 [go] Task: echo "I am exec with runIf=failed"
&1|01:55:12.771 I am exec with runIf=failed
?0|01:55:12.870 [go] Task status: passed (103 ms)
!!|01:55:12.871 [go] Task: echo "I am exec with runIf=any"
&1|01:55:12.874 I am exec with runIf=any
?0|01:55:12.974 [go] Task status: passed (103 ms)
j1|01:55:12.991 [go] Current job status: failed

that is the bash tasks with runIf are not executed. According to the javadoc both the bash and the exec tasks have a runIf property so I would expect that both of them should be executed in the same way in the example above.
DSL plugin version: 2.1.1-432
GoCD server version: 22.3.0 (15301-9d23ed19a9ea46eaf7f18bd16671ae0569871f53)
GoCD agent version: go-agent_22.3.0-15301_all.deb

Thanks for reporting! Should be fixed in 2.1.2 - let me know if you still have a problem.

It is working as expected now, many thanks for fixing the bug so quickly.


Distributed MXNet fails to bind symbols

Environment info
Operating System:
Ubuntu 16.04.1 LTS
Compiler:
??
Package used:
Python
MXNet version:
mxnet (0.9.5)
MXNet commit hash:
232d8372c668b07ed7c7e58718fc529567139b00
If you are using python package, please provide Python version and distribution:
Python 2.7.6
Error Message:
When trying to train ResNet on CIFAR10, my validation accuracy was very strange, the system would essentially converge at ~85% accuracy in the expected period of time, then within 20 or so iterations, the model would jump up to ~92% accuracy and stay there, barely changing accuracy between iterations.
I discovered that no matter which type of optimizer I selected, there was no change to the way the model would train. So I was searching through the code to find the root of this problem, and I found that the program was getting stuck at this line of code.
Digging a little deeper, it turns out that this function call never returns.
I'm not even sure how the model is able to train without proceeding past this line, but I put print statements on either side of it, and only the first prints.
I have experienced the same problem running any of the models included in the zoo, and have even reduced the model down to a single convolution layer -> FC -> softmax and it still occurs.
It only occurs when there is a convolution layer in the model.
Any idea what the problem could be? I can't dig any deeper into the code, as it eventually reaches some pre-compiled library.
Minimum reproducible example
This problem occurs when running ResNet from the model zoo in a distributed setting (occurs with both --kv-store dist_async and dist_sync).
Steps to reproduce
This problem occurs by running the following command:
python ../../tools/launch.py -n 4 --launcher ssh -H hosts python train_cifar10.py --network resnet --kv-store dist_async --gpus 0

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!


MINIFICPP-1253 - Do not hang on full cycles

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file?
[ ] If applicable, have you updated the NOTICE file?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@adamdebreceni some tests failed in CI:
https://travis-ci.org/github/apache/nifi-minifi-cpp/jobs/701990105


Measure history r quiet down setup

I agree with the changes you made @edeyoung .

Updates look good.


Split lines containing a lambda, and keyword arguments in Ruby

A case such as:
  some_method_call(:foo, -> { :bar }, :baz)

Splits nicely into:
  some_method_call(
    :foo,
    -> { :bar },
    :baz,
  )

But if the argument after the lambda uses keywords, it's splitted into something I don't expect.
Such as:
  some_method_call(:foo, -> { :bar }, some_key: :baz)

into:
  some_method_call(
    :foo, -> { :bar },
    some_key: :baz,
  )

Where I would expect:
  some_method_call(
    :foo,
    -> { :bar },
    some_key: :baz,
  )

The configuration I'm using is:
let g:splitjoin_trailing_comma = 1
let g:splitjoin_ruby_hanging_args = 0
let g:splitjoin_ruby_curly_braces = 0

Worth noting, I also ran into this in a case such as this:
model = create(:some_model, :some_trait, confirmed_at nil)

Which was split into:
model = create(
  :some_model, :some_trait,
  confirmed_at nil,
)

When I expected:
model = create(
  :some_model,
  :some_trait,
  confirmed_at nil,
)

So maybe this is more about when the argument list contains keyword arguments, or a hash?

Any ideas @AndrewRadev?

I haven't had the time to look into this yet. I'm pretty sure the plugin first attempts to split keyword options, and only then does it also split arguments, because it's the more common case. I imagine I'll have to implement a setting to always split all args and opts to get the behaviour you expect, but, again, haven't looked into it. There might be a bug, or it might be a matter of implementing a new setting.

So, yes, the plugin attempts to split options first, and arguments only if there are no options. This usually works well for stuff like:
function_call one, two, three: four, five: six

function_call one, two,
  three: four,
  five: six

This is a pretty common style, I think, and I'd rather not break it. I can implement some option to fit your style, but we should try to define it better. For instance, what happens if there's more than one keyword argument?
function_call(one, two, three: four, five: six)

# option 1:

function_call(
  one,
  two,
  three: four,
  five: six
)

# option 2:

function_call(
  one,
  two,
  three: four, five: six
)

I realize the first one seems obviously correct, but what if there are curly brackets?
function_call(one, two, {three: four, five: six})

# option 1:

function_call(
  one,
  two,
  three: four,
  five: six
)

# option 2:

function_call(
  one,
  two,
  {three: four, five: six}
)

It's tricky because, while parsing, the plugin doesn't really retain whether there were curly brackets or not. We could have an option that says "if we have curly brackets, consider it a single argument, otherwise they're separate". But I'd have to poke around and see how to fit this in the existing logic.
A much simpler option would be to implement a setting that just splits everything on a single line, keyword args, hash options, etc. If you're okay with that, I think I can easily implement it, but you'll lose the ability to only split options if it's set. An alternative might be to consider the cursor position and either split options, or everything, but that'll require another session of poking into internals to figure out how to do it.
What do you think? How do you imagine the behaviour of the plugin in these situations? Keyword args, options with or without curly brackets?

I'm sorry it took a while to get around to this. Difficult to find the energy to sit down and put the effort in.
I've created a branch, ruby-targeted-option-splitting. I've added documentation for the new option, g:splitjoin_ruby_targeted_option_splitting, so please try reading it and let me know if it seems understandable enough. And then try the setting and report back any bugs you find with it, and whether it works the way you'd expect it to.

@AndrewRadev That's absolutely OK. Didn't mean or intend to make you feel bad about not looking into this if this is deemed a low priority. Sorry!
I tried out the branch, and the option, and it works how I expect it to!
Some pointers on the docs:

g:splitjoin_ruby_targeted_option_splitting

Based on the option name alone, I don't really know what it does. Maybe renaming it into something along the lines of g:splitjoin_ruby_consistently_split_arguments_and_options. That's how I view the feature atleast.
What do you think?

If set to 1, this will allow a bit more flexibility on splitting arguments and options, while reducing flexibility in another department.

Which department? I think giving an example this early would be good - what I don't know.

User.new(:one, :two, first_name: "Andrew", last_name:"Radev")

Should there be a space before "Radev" for consistency?

Which department? I think giving an example this early would be good - what I don't know.

Ah, actually, that's my bad. I was thinking about the previous setting I implemented that always split both args and opts. The way it's implemented now, there's no real loss, you can do both, it's just the "only split options" option is a bit more inconvenient.

Based on the option name alone, I don't really know what it does. Maybe renaming it into something along the lines of g:splitjoin_ruby_consistently_split_arguments_and_options. That's how I view the feature atleast.

Hm, maybe. I'm not sure about "consistently". It usually means "in a similar way", but in this case, I'm not sure they're both split in a similar way -- it's more that options are considered the same as any other argument. Except if your cursor is on one of the options, in which case the plugin splits only those.
That's the tricky thing about naming this feature, there's two parts to it:

Split options as if they were arguments
Split only options if the cursor is on them

The "targeted option splitting" name covers the second part. The "consistently split options and arguments", and "split options as arguments" names cover the first part.
This might mean it's better to have two settings. For you, the first one will always be enough anyway, and you won't ever use the second one.
Mind you, it's also not necessary to pick a name that will perfectly cover the entirety of the setting's effect. This isn't a programming language where the "single responsibility principle" is important to ensure code maintainability -- it's a toggle switch, and even just calling it "alternate option splitting" would work just fine (people can read up on all settings for their preferred language), except that there might be a third "alternate" option splitting in the future and that would complicate things :P.
I'm considering making this more complicated behaviour a default, and making a setting for the "just split options if there are any" behaviour (I'd set that, because that's what I'd prefer). It would change default behaviour, but then people would just go to the docs, hopefully, and add a setting. Or I could make the setting "split_method_options_before_args" and set it to 1 by default, for compatibility's sake. (And maybe most people would still prefer easier option-splitting? I think it's somewhat rare to have many positional arguments, apart from very special DSL cases, and common to have many "options" or named arguments)

Hm, maybe. I'm not sure about "consistently". It usually means "in a similar way", but in this case, I'm not sure they're both split in a similar way -- it's more that options are considered the same as any other argument. Except if your cursor is on one of the options, in which case the plugin splits only those.

I see your point.

This might mean it's better to have two settings.

I'm onboard with having two options if that is clearer for other users.

... it's also not necessary to pick a name that will perfectly cover the entirety of the setting's effect.

Something along the suggested lines of "alternate option splitting" would also be a-ok!
Thank you so much for the thoughtful replies and your work!

Works swell, thank you for your fantastic work Andrew!


feat: working on drawable components

This is a working branch. I'm working on drawable components. Todo list:

[x] Add drawable components.
[ ] Add animated drawable components.
[ ] Add controllable drawable components.

Contributions welcomed! Ping me when you got progress on this.


Throws an exception on missing api key, outputs nothing after key is set.

I'm ovos-newbish. I was going to roll my own gpt skill then found this one. I think it's expecting core functionality that hasn't been committed.
Running on rpi4b, raspbian-ovos-dev image (w/o a TV connected to it) from April.
The skill loads, and throws an exception because the key isn't set. Expected that.
My settings.json is simple:
{
    "key": "sk-xxxxxxxxx"
}

The skill now loads silently indicating all is well but it remains silent forever with a fallthrough to the "Unknown" response.
The cause of the fallthrough is found in daemon.log: This skill imports the Persona libraries which throw:
ModuleNotFoundError: No module named 'ovos_plugin_manager.templates.solvers'
Upgrading ovos-plugin-manager doesn't eliminate the exception, but maybe I did that incorrectly?
I'm gonna roll my own gpt skill since the Persona stuff seems too elegant and fragile for my tastes. Establishing gpt personality is straight forward, and well documented, but I think it's too ephemeral/nuanced and fluid to constrain within a templated structure for now e.g., the number of "jailbreak" tricks being found.
I thought this should be reported because this will be a VERY popular skill on systems where it works.

I'm ovos-newbish. I was going to roll my own gpt skill then found this one. I think it's expecting core functionality that hasn't been committed.
Running on rpi4b, raspbian-ovos-dev image (w/o a TV connected to it) from April.
The skill loads, and throws an exception because the key isn't set. Expected that.
My settings.json is simple:
{
    "key": "sk-xxxxxxxxx"
}

The skill now loads silently indicating all is well but it remains silent forever with a fallthrough to the "Unknown" response.
The cause of the fallthrough is found in daemon.log: This skill imports the Persona libraries which throw:
ModuleNotFoundError: No module named 'ovos_plugin_manager.templates.solvers'
Upgrading ovos-plugin-manager doesn't eliminate the exception, but maybe I did that incorrectly?

the OPM version this was introduced is V0.0.23a13 , what version are you running? pip wont install alpha versions unless you explicitly request them

I'm gonna roll my own gpt skill since the Persona stuff seems too elegant and fragile for my tastes. Establishing gpt personality is straight forward, and well documented, but I think it's too ephemeral/nuanced and fluid to constrain within a templated structure for now e.g., the number of "jailbreak" tricks being found.
I thought this should be reported because this will be a VERY popular skill on systems where it works.

Persona is a larger initiative than just ChatGPT, this skill is not using the persona code yet, when persona is done it will use the same solver plugin from error above and this skill will likely be archived/absorbed into persona


vuex on nuxt disappears on page reload

Version
6.0.0-beta.21
Browser and OS info
windows 10, chrome 96
Steps to reproduce
load vuex store data via an api
view in devtools
reload page
What is expected?
vuex should display the newly loaded state
What is actually happening?
an error pops saying vuex 2 inspector not found

Might be a duplicate of #1475?

This might be fixed.

@glen-84 it is not fixed


(app) Update discovery to poll directly connected robots

overview
This PR updated the discovery machinery of the app to also poll for directly connected robots via repeated GET requests to http://${FIXED_LINK_LOCAL_IPv6}:31950/health.
Blocked by #480
This PR includes:

[ ] Chore work
[ ] Bug fixes
[X] Backwards-compatible feature additions
[ ] Breaking changes
[ ] Documentation updates
[X] Test updates

changelog
Write descriptions for your changes. If a change is related to a GitHub issue, please tag the issue in the description.

(Feature) Updated discovery.js to poll /health at fixed local IP every sec
(Chore) Updated MDNS dev script to only advertise if local API is found

review requests
Nothing specific, but a Windows test would be helpful!

Reviewed on Windows, works as desired. Just need to figure out what's up w/ CI and aiohttp packages, then can merge as soon as #480 goes in


Add a f90 multi-version of the original vmuldemo

Define VMUL[0123] to select which version of vmul to use
Useful for simple dispatch testing/bringup
Corresponding C version available for IR comparisons

Here is a PR with a F90 version of vmuldemo with alternate versions (full version, reduced directives, single element access, scalar access)…and a matching C version.
Candidate for simple kernel dispatch in llvm-flang.   All versions run correctly/validate with both classic flang and clang (for the C version)…so can stay in smoke as well.


Added compose such that the rightmost function may have any arity.

Compose's last (rightmost) function can accept an arbitrary number of arguments; every subsequent function must be unary. The arguments to Array.reduce() also use 'f' and 'g', which makes pipe more intuitive to read as it closely resembles its mathematical background.
Also added spread operator into explanation of pipe.

Branches! A PR can come from any branch to be merged into the remote source. I could have one copy of the repo, with 12 branches, none of them my master, and a PR for each, and git wouldn't care. After everything gets merged in, I bring my repo up to date with the remote and I can continue with even more PRs.
So if you make a branch in your repo, make the changes to that branch, and then change the PR to point to that branch you'll be golden.

Ah, okay. So in this case, should I cancel this PR, go back to my forked repo, undo the commits, and then commit each individual change into its own branch, then submit 3 PRs?
Thanks for the info, I really appreciate it!

You should be able to achieve this with a mixed reset and pushing the individual changes to other branches, or the method you described. Whichever is easiest for you will work.

Thanks, I'll try to get this fixed sometime in the weekend.

I agree with @skatcat31 but there's no standard procedure just yet, so I'll merge to get these changes in. Plus even if we needed a revert, I couldn't even find my way through the branch tree right now with everything that's happening!


pkg/testgridanalysis: Generic handling for sad-operator test-case

Per openshift/release#12298, the test-case is really about whether the operator has any sad conditions at gather-time, regardless of whether those gathers occured after a failed install or not.

Replaced by openshift/sippy#111


doc: need some upgrade practice documents

Starting from the Apache APISIX Ingress v1.2 version, we are continuing to unify the api version in order to make it easier to use. #707
However, the upgrade process will contain some destructive changes, we need to add documents to explain it, in order to ensure that users can upgrade smoothly.

CustomResourceDefinition.apiextensions.k8s.io "apisixconsumers.apisix.apache.org" is invalid: status.storedVersions[0]: Invalid value: "v2alpha1": must appear in spec.versions
CustomResourceDefinition.apiextensions.k8s.io "apisixupstreams.apisix.apache.org" is invalid: status.storedVersions[0]: Invalid value: "v1": must appear in spec.versions
CustomResourceDefinition.apiextensions.k8s.io "apisixtlses.apisix.apache.org" is invalid: status.storedVersions[0]: Invalid value: "v1": must appear in spec.versions

@tao12345666333 When applying the crd of v2beta3 version, I encountered the above error, which made me have to delete these CRD before reapplying, and related resources would also be deleted, resulting in short-term unavailability.

@suninuni You can use the CRD from the Helm chart, we have optimized and fixed it

@AlinsRan will pick this up.


Update suggested commit wording to automatically close issues when landing

With "Fixes #N" an the issue N will automatically close once it's pushed: https://help.github.com/articles/closing-issues-via-commit-messages/

r+

Note: that commit message style doesn't automatically close the original issue once it's pushed, you need to reference the issue number inside the PR body.
See https://github.com/mozilla/tofino/pull/71 for an example.
We should update the readme to suggest doing just that. @bgrins care to do it?

I also suggest making a not about asking for review. Pinging somebody in a comment usually works, but it feels better to just assign somebody to a PR if you want their review.

I also suggest making a note about how to ask for review. Pinging somebody in a comment usually works, but it feels better to just assign somebody to a PR if you want their review.

I'm all for getting rid of email pings as a way to track reviewers, but it may be a separate discussion / issue depending on a couple questions:

Does everyone have permissions to set the assignee to anyone else in PRs?
Does a user get notified when they are assigned to a PR?

Note: that commit message style doesn't automatically close the original issue once it's pushed, you need to reference the issue number inside the PR body.

According to https://help.github.com/articles/closing-issues-via-commit-messages/ it looks like it should be enough.


Use the same dialog for searching across all files and across a single file

Suggestion
Unify all searches under the same spacy dialog used for searching across multiple files.
Weaker suggestion
Make it an option to do so.
Background
Searches across multiple files (Ctrl+Shift+F/H) are currently performed in a separate spacy dialog, which is great. It shows you the places where the match was found. If replace is enabled, you will also see the result. And you can remove matches by hand.
Searches across a single file (Ctrl+F/H) on the other hand are performed in a tiny box with limited functionality. There is no preview nor other nice properties of the spacy dialog. I don't understand the value of this tiny simplified search over the spacy one.

I think the use cases between these two are different, and would like to keep separate UIs


Bbox tests

This is not ready to merge
Branch converts tests to mocha, and adds extensive tests of the WGS84 -> 900913 (and back) conversions. Fixture data is based on natural earth world borders, added to postgis using shp2postgis and converted to 900913 using postgis.
However, the tests don't pass. We need to decide on what kinda tolerance we want to accept. Also tests are currently being capped to just 10, of the 250 in the fixture.

Stale: tests were converted to mocha in another commit.


Create .repoman.yml

Copied and only modified slightly from the dotnet docs repo

Related to #149


Unable to Insert Related Records in Dataverse with Datafactory

I am using a dataflow in data factory to write records into 2 custom tables I created in the dataverse.
PackagingInstruction and Attachment.  There can be many attachments for PackagingInstruction.
I created an alternate key on the PackagingInstruction table (ticketid), and a relationship between the 2 tables.
Using PackagingInstructions as a sink with the alternate key works fine, no problem.
I used the following instructions to upload the attachments using the alternate key on the lookup field related table:
https://learn.microsoft.com/en-us/azure/data-factory/connector-dynamics-crm-office-365?tabs=data-factory#writing-data-to-a-lookup-field-via-alternative-keys
After every possible permutation I could conceive I gave up and decided to read the related table and get the GUID of the related record and then just upload the relation that way using the following instructions:
https://learn.microsoft.com/en-us/azure/data-factory/connector-dynamics-crm-office-365?tabs=data-factory#writing-data-to-a-lookup-field
This also fails and does not work according to the instructions.
Depending on the permutation I get different errors but generally they are "Microsoft.OData.ODataException: An undeclared property 'cr4ad_ticketid' which only has property annotations in the payload but no property value was found in the payload. In OData, only declared navigation properties and declared named streams can be represented as properties without values."
Can you please provide some further instructions or provide the correct syntax for actually making this work?
Thanks,
Ryan McCarron

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 304d4c46-c0ac-05c9-15eb-d8b677ec5e90
Version Independent ID: 36a79d36-2b72-2722-68e5-e167f9a2cd41
Content: Copy and transform data in Dynamics 365 (Microsoft Dataverse) or Dynamics CRM - Azure Data Factory & Azure Synapse
Content Source: articles/data-factory/connector-dynamics-crm-office-365.md
Service: data-factory
Sub-service: data-movement
GitHub Login: @jianleishen
Microsoft Alias: jianleishen

@rmccarron-napoleon
Thanks for your feedback! We will investigate and update as appropriate.

@MicrosoftDocs/ops_admin
Based on the error message you provided, it appears that the problem is with the payload of the request being sent to Dataverse. The error message indicates that the property "cr4ad ticketid" was sent without a value, which is not permitted in OData.
To troubleshoot this problem, I would recommend the following:

Check that the "cr4ad ticketid" property exists in Dataverse's Attachment entity and is defined as a lookup field to the PackagingInstruction entity.
Check that the alternate key for the PackagingInstruction entity is properly defined and used in the dataflow.
Enable logging and examine the request body to examine the payload of the request being sent to Dataverse. Logging can be enabled in the dataflow settings by setting the "logActivityDetails" property to true.
Check the request body syntax and make sure the "cr4ad ticketid" property is set to the correct value.

Here's an example of what the payload for creating an Attachment entity with a lookup to PackagingInstruction entity should look like:
{
"filename": "attachment1.pdf",
"documentbody": "",
"filesize": 1024,
"mimetype": "application/pdf",
<EMAIL_ADDRESS>"/packaginginstructions()"
}
The name of the lookup field in the Attachment entity that points to the PackagingInstruction entity is "objectid packaginginstruction," and "alternate-key-value>" should be replaced with the actual value of the alternate key for the related PackagingInstruction entity.

@rmccarron-napoleon
We are going to close this thread , if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.

@RamanathanChinnappan-MSFT
Hi Ramanathan,
I am still unable to get this working.

In the output columns of the Sink, I have the lookup and both alternate keys displayed under them.  However when I map to any of these it does not work.  I tried mapping the GUID to the lookup column itself, and both alternate keys.  It fails with the error:
"Microsoft.OData.ODataException: An undeclared property 'cr4ad_mespackaginginstruction' which only has property annotations in the payload but no property value was found in the payload. In OData, only declared navigation properties and declared named streams can be represented as properties without values.\r\n at".
The documentation says I need to map to "CustomerField@EntityReference" however this does not exist in the possible mappings after I import the schema.  The output columns are a drop down list and I cannot enter free text.  Also, this appears to be for a multi-table / polymorphic lookup which I am not using.
I am also unable to view the actual payload in the dataflow sink for logging / debug to troubleshoot further.


How test two charts that are dependent on each other?

Output of helm version: {SemVer:"v2.9.0", GitCommit:"f6025bb9ee7daf9fee0026541c90a6f557a3e0bc", GitTreeState:"clean"}
Hi,
I am developing two charts, Chart A and Chart B. Chart A is dependent on Chart B. Chart A was developed standalone, tested and uploaded to a repo. And now Chart B is being developed. To test, a requirement is added to Chart A, in the requirements.yaml:
dependencies:
  - name: B
    repository: file://../B
    version: 0.1.0

It all works fine locally.
Now I need to test it on my build server, so I change the requirements.yaml for Chart A to:
dependencies:
  - name: B
    repository: https://repo_url/B
    version: 0.1.0

This obviously fails because Chart B does not exist on https://repo_url/B. But I cannot release until I can test it on the build server where the local file:// directive would not work.
How do you test such dependencies? Has this problem already been solved? Is there a better or different way to do this?
Thanks!

Hi @technosophos,
There is a helm dependency update --skip-refresh done before the package and that fails because it complains about
Error: B chart not found in repo https://repo_url

Thanks!


V3.3 renesas dom0

Remastered and cleaned Xentroops Dom0 changes, applied over zephyr-v3.3.0 branch of Zephyr OS.

Hi, @firscity
please,

move the last three commits (little fs) before the next commit samples: littlefs: add support for H3ULCB, Salvator XS M3 and Spider
change commit massage of the commit https://github.com/xen-troops/zephyr/pull/43/commits/b6bf3e56c65f3347757f981d3d60f833a5aebe7a to the next one:

drivers: sdhc: add support of Renesas MMC driver

Add basic functionality of Renesas SD/MMC driver. It can be used
for both gen3 and gen4 R-car boards, but tested only with H3ULCB,
Salvator XS M3 and Spider boards. This driver working with SDHC
subsystem.

The driver supports regularal reading/writing throught SD/MMC
controller buffer, DMA mode w/o interrupts and timing tuning.

Notes:
    * the driver doesn't support SPI mode;
    * SCC tuning and DMA mode based on IRQs are enabled by default;
    * an address of a data buffer has to be aligned to 128 bytes if it
      is not, driver will use non-DMA mode automatically;
    * Renesas MMC DMAC doesn't support 64-bit DMA addresses, so for
      case when we have 64-bit xref data address we use non-DMA mode;
    * SD/MMC controller supports block size between 512 and 1 with
      a lot of restrictions, more details you can find in code;
    * support of HS400 mode isn't implemented inside driver;
    * tuning of SD card modes hasn't been tested yet.

Signed-off-by: Mykola Kvach<EMAIL_ADDRESS>

add changes from the next pull https://github.com/xakep-amatop/zephyr-mmc-rcar/pull/2 to the commit https://github.com/xen-troops/zephyr/pull/43/commits/b6bf3e56c65f3347757f981d3d60f833a5aebe7a

This PR will be reopened for final review on target branch.


AirPlay crashing after some time

I've noticed AirPlay crashing after a while in idle multiple times in the last few days. I'm seeing the following error in the balena Logs:
fatal error: could not connect to the pulseaudio playback stream -- the error message is "Bad state".

Restarting the airplay container fixes this problem.
Device information

Board (hardware info): Raspberry Pi 4b
Device type (as seen in balenaCloud): Raspberry Pi 4
balenaOS version: balenaOS 2.65.0+rev1

Additional context
The device is operating in standalone mode and has the following variables set:
SOUND_DISABLE_SPOTIFY=1
SOUND_MODE=STANDALONE
SOUND_VOLUME=100
SOUND_DEVICE_NAME=my-custom-name

Any progress on this one? I’m encountering the same problem with the same hardware also.

Fixed in v3.6.11. For details see https://github.com/balenalabs/balena-sound/pull/508


FAILURE: Build failed with an exception. when i run "npm run android"

i have a another project on going and that run pretty well and currently i am working on in ,  but when i create this new project  says this BUILD failed
in package.json i am using
"dependencies": {
"react": "16.3.1",
"react-native": "~0.55.2"
}
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:mergeDebugResources'.
> Error: java.util.concurrent.ExecutionException: java.lang.RuntimeException: AAPT process not ready to receive commands

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 1 mins 11.282 secs
Could not install the app on the device, read the error above for details.
Make sure you have an Android emulator running or a device connected and have
set up your Android development environment:
https://facebook.github.io/react-native/docs/getting-started.html

Hello,
I'm also getting same error message.
after i ran the react-native info i got below data.

Environment:
OS: Windows 7
Node: 9.11.1
Yarn: Not Found
npm: 5.6.0
Watchman: Not Found
Xcode: N/A
Android Studio: Version  <IP_ADDRESS> AI-173.4670197
Packages: (wanted => installed)
react: 16.3.1 => 16.3.1
react-native: 0.55.3 => 0.55.3

I have installed android studio and made sure that emulator is running


Bundle and Minify JS

Using something like this?
http://flask-assets.readthedocs.org/en/latest/
I'm curious what the best way to do this is if you have different javascript modules across different pages.

Do we have enough JS to justify this right now?

Not very much JS but isn't this just something you should do as a good practice no matter how much js/css you have? Definitely not a high priority but are there downsides to doing this?

Main downside I can think of is that it introduces a build step where one might not be needed. I’m a fan of serving JS & CSS unmodified until they get too big, because I think it’s easier to reason about when debugging in-browser.

One of the positives to going the route of #531 is that JS can be compiled with sourcemaps that ease debugging and separate modules at the same time. A very convenient time-saver all around.


Add Bengali and see additional requested languages/dialects

A provider representative is requesting these most commonly used languages at provider locations other than Spanish and some french dialects

Pulaar (Guinea)
Pulaar (Mauritania)
Hassānīya (Mauritania)
Pulaar (Mali)
Wolof
Arabic (Mauritania)
Arabic (Sudan)
Arabic
@shakilhossain1 could you check and see if Google Translate has these dialects?
We can make a decision as to whether to implement some of these based on our ability to copyedit them.

Adding Russian to the list.

@shakilhossain1 just lifting up to get doobneek's russian fixes on test.


feat(single-handle-slider): Export Slider

Export { Slider } and RangeSlider from pcln-slider
This PR mostly moves some files around for better organization, and exports Slider, which already existed prior to this PR but wasn't being exported.  This PR also updates docs to reflect the new Slider export.

Codecov Report

Merging #587 into master will increase coverage by 0.01%.
The diff coverage is 98.73%.

@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
+ Coverage   94.84%   94.85%   +0.01%
==========================================
  Files          67       69       +2
  Lines        1163     1167       +4
==========================================
+ Hits         1103     1107       +4
  Misses         60       60

Impacted Files
Coverage Δ

packages/slider/src/rc-slider/common/Steps.js
100% <ø> (ø)

...es/slider/src/rc-slider/createSliderWithTooltip.js
94.73% <ø> (ø)

...ckages/slider/src/rc-slider/common/createSlider.js
94.21% <ø> (ø)

packages/slider/src/rc-slider/common/Track.js
100% <ø> (ø)

packages/slider/src/rc-slider/common/Marks.js
95.45% <ø> (ø)

packages/slider/src/rc-slider/Range.js
77.36% <ø> (ø)

packages/slider/src/rc-slider/Handle.js
87.09% <ø> (ø)

packages/slider/src/rc-slider/utils.js
94.23% <ø> (ø)

packages/slider/src/styleSlider.js
100% <100%> (ø)

packages/slider/src/RangeSlider.js
100% <100%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4636bd2...edfb8cf. Read the comment docs.

LGTM, just need to double-check our current release process that should we update version here or after merge

LGTM, just need to double-check our current release process that should we update version here or after merge

I think you may be right.  I will revert the versions, and take care of that on publish.


Conflicts resolution handling errors

Describe the bug
When conflict occurs for OfflineTable on PushItemsAsync in OfflineSqlStore then error table got an entry for failed item and if you are handling the conflicts manually and push local item again then these are the issues you can face.
1- No matter what offline table you are pushing butOfflineSqlStore always sends you PushFailedException if there is failed item entry in errors table. For example Table A item was failed due to conflicts you got PushFailedException and now if you have multiple tables and you are pushing Table B and it succeeded on server but OfflineSqlStore still sends you PushFailedException and item will be linked in PushResult from Table A.
https://github.com/Azure/azure-mobile-apps/blob/fe3863b759eba07efa329b84257e8a7fa367f532/sdk/dotnet/src/Microsoft.Datasync.Client/Offline/SyncContext.cs#L606
2- If you are handling conflicts manually and there is a failed item entry in errors table and you are pushing item again with correct version and it get succeeded on server but OfflineSqlStore will not delete that item from errors table and you will still get the PushFailedException because PushItemsAsync method checks for errors in the end if there is any failed item entry in errors table it will consider as PushFailedException
To Reproduce
Steps to reproduce the behaviour:
1- Create conflict on your app
2- Kill the app (It will keep failed item in errors table)
3- Relaunch the app
4- Push your all items from offline tables (Table A, Table B)
5- Or Push corrected item (Local copy with server version)
Expected behaviour
1- It will nor send PushFailedException for Item of Table A when pushing the item of Table B
2- When failed item is succeeded on remote then it should delete the failed item from errors table that will not cause again PushFailedException
What platforms?

Client:

.Net 7
MAUI
6.0.4
Windows/iOS

Suggested change
Problem 1
I am not sure this is best solution or not or can be handled better way by just updating LoadErrorsAsync to return current table errors. I was handling by filtering errors for first tableNames from the parameters of PushItemsAsync as in my case there was always one table being pushed.
// ** AP: Filter errors for the current batch table **
errors = errors.Where(error => error.TableName == tableNames.FirstOrDefault()).ToList();

// If the push did not complete successfully, then throw a PushFailedException.
if (batchStatus != PushStatus.Complete || batch.HasErrors(errors))
{
    List<TableOperationError> unhandledErrors = errors.Where(error => !error.Handled).ToList();
    Exception innerException = batch.OtherErrors.Count > 0 ? new AggregateException(batch.OtherErrors) : null;
    await RemoveErrorsAsync(errors.Where(e => e.Status != HttpStatusCode.Conflict && e.Status != HttpStatusCode.PreconditionFailed), cancellationToken).ConfigureAwait(false);
    throw new PushFailedException(new PushCompletionResult(unhandledErrors, batchStatus), innerException);
}

Problem 2
Again it can be done better way but I am removing the failed item on success in ExecutePushOperationAsync method. I had to handle id for common datatypes like string, int & Guid
if (removeFromQueueOnSuccess && error == null)
{
    await OperationsQueue.DeleteOperationByIdAsync(operation.Id, operation.Version, cancellationToken).ConfigureAwait(false);
// ** AP: Delete the Errors on Success based on id & TableName **
    var errors = await batch.LoadErrorsAsync(cancellationToken).ConfigureAwait(false);
    await RemoveErrorsAsync(errors
        .Where(e =>
        {
            if (e.TableName != operation.TableName)
            {
                return false;
            }

            var idToken = e.Item["id"];
            if (idToken is JValue jValue)
            {
                var idValue = jValue.Value;
                if (idValue is string stringId)
                {
                    return stringId == (string)result["id"];
                }
                else if (idValue is Guid guidId)
                {
                    return guidId == (Guid)result["id"];
                }
                else if (idValue is int intId)
                {
                    return intId == (int)result["id"];
                }
            }

            return false;
        }), cancellationToken)
        .ConfigureAwait(false);
}

https://github.com/Azure/azure-mobile-apps/blob/fe3863b759eba07efa329b84257e8a7fa367f532/sdk/dotnet/src/Microsoft.Datasync.Client/Offline/SyncContext.cs#L891
I can submit a PR if above solution makes sense for these two issues

I know how to fix this one (I've been eyeing it for a while), so no need for the PR.

@adrianhall This will handle only problem # 2 and will not handle peoblem# 1.
For example if I have multiple offline tables and I am pushing on multiple table. If Table1 have conflicts and you are pushing item for Table2. On Successfull push of Table2 it will send this PushFailedException due to failed entry of Table 1 and send Table1 item in PushResult on PushAsync of Table2. Your thoughts ?

The problem with multiple issues in the same issue report :-)
I'll re-open and fix today.

I believe 6.0.5 will fix problem #1 as well.  The solution:

Update LoadErrorsAsync in the OperationsBatch to load only the tables being pushed.
Update the ExecutePushItemsAsync to call LoadErrorsAsync with the list of tables being pushed.
Add a backwards compatible LoadErrorsAsync so that the tests continue to work.

I'm not very concerned about increasing test coverage for the new situation right now.  I'm going to fix this in the v8 code base properly.


Smali Compile Log

Please add more information if an error occurred while compiling smali.
Class brut.androlib.mod.SmaliMod.java

Not sure what is being reported here. Do you mind opening a pull request with an explanation of what you are intending to change and why?

I'll try


fix: circular progress

• setting up basic API
• adding sizing utilities
• identified path for deprecating some icon helpers
• added isNumericString() helper to identity.ts
• added isTshirtSize() helper to size.ts
• added updateEquilateralSizeStyles() helper to size.ts
• added stories for progress-circle
• adding styles for statuses
• adding style to support centered icon
• adding styles for token sizes
• added indeterminate state (spinner)
• added 'unknown' status for a purple version
• changed spinner to use clarity motion timing and easing
• updated colors of status backstrokes for better contrast with arcstroke
• updated inverse status to be a boolean property
• marked legacy sizing classnames for deprecation
• added chaos test to verify animation holds up
• move animation to progress-wrapper to fix IE
• unit tests
• cleaning up stories/dox
• update dox
• fixed zero being treated as a falsy value and treated as indeterminate
• verified in safari
• react wrapper
• clean up styles for 0 and 100 values
• fix build
• a11y guidance added in demos
Signed-off-by: Scott Mathis<EMAIL_ADDRESS>PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)
[x] If applicable, have a visual design approval

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?
there is no circular progress
Issue Number: #4043
What is the new behavior?
there is a circular progress

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

the plan is to merge this after the v4 release. so it will go into the v5 branch.

Is this really a 'fix' when its a new component? Commit message change?

Is this really a 'fix' when its a new component? Commit message change?

Nope. it's not. I'll change the commit message when i rebase and squash after 4.0.


Add method to reset project AES key

Summary
Adding support for resetting AES keys on projects
Checklist

[ ] Added/updated tests? - This api doesn't return anything so there wasn't much to test.
[x] Ran make fmt?
[x] CHANGELOG.md [Unreleased] section updated?

Why was it changed?
Library was missing support for this API and I needed it to automate rotation of over 100 AES keys on our projects after the security incident.
Here is the script I wrote to do all this, I suspect it could be useful for other Codeship customers too: https://github.com/fillup/codeship-rotate-aes
What changed?
Added func (o *Organization) ResetProjectAESKey(ctx context.Context, projectUUID string) (Project, Response, error) to projects.go

I was about to open the same PR 😂 . Great work @fillup I'm really looking forward to seeing this one merged, our team had to rotate every AES key too so we know the pain.
We had also created a small go app to help us through the process, so kudos for yours 👏 , this will help teams affected that are still in the process, and to everyone wanting to rotate AES key on a regular basis without having to go project by project.

Thanks @jotum! Too bad we weren't connected before to collaborate on this one, but I agree hopefully others can find and use it. And I'm happy to have a process for the future that I can run and rotate them all quickly! I emailed Codeship about this PR and my script earlier today to call their attention to it and hopefully get it merged and possibly the rotation script communicated to those in need.

Thanks @joesiewert!


[C++] Unexpected float32/64 to decimal128 cast result

Describe the bug, including details regarding any error messages, version, and platform.
a = pa.array([545803904.0], type=pa.float32())
>>> a.cast(pa.decimal128(38, 18))
<pyarrow.lib.Decimal128Array object at 0x000001DE8FF59840>
[
  545803886.966396699654750208
]
>>>

While encoding of decimal128 and float32 is very different, the difference after the cast  seems much larger than expected.
Component(s)
Python

the first part of the error is down-casting from float64 (python default representation to)->float32
a = pa.array([545803904.0], type=pa.float32())
a
<pyarrow.lib.FloatArray object at 0x3ebb737bb400>
[
  545803900
]

Same happens with numpy:
numpy.float32(545803904.0)
545803900.0

The second part of the error I think is likely due to implementation which looks like we somehow might do an extra cast through an intermediate value:
a = pa.array([545803900.0], type=pa.float64())
print(a.cast(pa.decimal128(38, 18)))
print(a.cast(pa.float32()).cast(pa.decimal128(38, 18)))

gives:
[
545803899.999999976169013248
]
[
545803886.966396699654750208
]
I think the second source of error might be: https://github.com/apache/arrow/blob/cd6e2a4d2b9373b942da18b4cc82cb41431764d9/cpp/src/arrow/util/decimal.cc#L158
since this looks like it it is done in float space (instead of casting to double) which potentially causes further loss of precision.

@rok @felipecrv Does any of you want to take a look at this?

The issue is with the algorithm used in Decimal128::FromReal. We can reproduce the underlying precision problem by repeating the first steps of the algorithm in Python:
>>> powers_of_ten = [1e-38, 1e-37, 1e-36, 1e-35, 1e-34, 1e-33, 1e-32, 1e-31, 1e-30, 1e-29, 1e-28,
...:     1e-27, 1e-26, 1e-25, 1e-24, 1e-23, 1e-22, 1e-21, 1e-20, 1e-19, 1e-18, 1e-17,
...:     1e-16, 1e-15, 1e-14, 1e-13, 1e-12, 1e-11, 1e-10, 1e-9,  1e-8,  1e-7,  1e-6,
...:     1e-5,  1e-4,  1e-3,  1e-2,  1e-1,  1e0,   1e1,   1e2,   1e3,   1e4,   1e5,
...:     1e6,   1e7,   1e8,   1e9,   1e10,  1e11,  1e12,  1e13,  1e14,  1e15,  1e16,
...:     1e17,  1e18,  1e19,  1e20,  1e21,  1e22,  1e23,  1e24,  1e25,  1e26,  1e27,
...:     1e28,  1e29,  1e30,  1e31,  1e32,  1e33,  1e34,  1e35,  1e36,  1e37,  1e38]
>>> int(powers_of_ten[38+10]*1234567890.)
12345678900000000000
>>> int(powers_of_ten[38+11]*1234567890.)
123456788999999995904
>>> int(powers_of_ten[38+12]*1234567890.)
1234567890000000057344

Also it looks like I'm the culprit:
https://github.com/apache/arrow/pull/7612
:-)


Replace developerError with Check in polygonGeometry

Addressing #4794

Thanks! The build failure seems to be unrelated to this PR.


travis_apt_packages not generated for github actions

When adding a travis_apt_package I expected that the packages will be used also on Github actions but they weren't added.
It can be seen here:
https://github.com/OCA/edi/pull/488
https://github.com/OCA/edi/commit/87a686563a5aa17b799b3c53aca0c88e6e5bdc89
https://github.com/OCA/edi/compare/87a686563a5aa17b799b3c53aca0c88e6e5bdc89..8aeed2429022f3820b88366db3162806b6868daf

Although the question text leads to Travis, it should be reused for GH actions as well. Maybe it's the moment now to add a new neutral question apt_packages that feeds both parts, and keep the old travis_apt_packages for compatibility.

You can now declare apt packages in manifest external dependencies using a "deb" key. This way the oca-ci will install them, as well as runboat, without having to parse the ci config, as travis2docker does.

OK, that's great. Maybe an entry in some wiki to point to this FAQ?


Implement Automatic and Manual control

[ ] Automatic control using remote controller
[ ] Manual Control using joystick
[ ] Manual Control using mobile app


M3-422

@Jskobos once @asauber returns he, @martinmckenna, and I will sit down and review this as a team. Didn't want you thinking you were forgotten about.

It's still possible to get a bad label to appear to save.

Edit the label to a duplicate label, and get the error
Cancel editing
Edit again and set the label to the same duplicate label
The bad label will appear to save, but it didn't, no error appears

The state management needs a more fundamental overhaul.

Logic looks good now, thanks @Jskobos.
I would merge this, but it needs some styling work so that the checkmark and X don't appear to "shift down" when an error is displayed.

Coverage decreased (-0.02%) to 25.878% when pulling d41798dadd4c165f1aef32b0c2f48d1c7581325c on Jskobos:M3-422 into c2ad457690b89ed75ae2d6b58dc2d4d39bd4f836 on linode:develop.

@asauber adjusted the styles here. I also accounted for the same possible pattern on NodeBalancerDetail

@martinmckenna I'd mark this as acceptable. This would only happen on mobile under a certain breakpoint and we are not officially supporting all mobile functionalities. As of now the buttons clear underneath which is an expectable behavior and not a bug per say. I'd say let's ship it unless there's another layout issue


Guest mode revisited

Adds in a check to see if you are a guest during silent login. This should remove edge cases where user isn't loaded yet but we want to check for $rootScope.GuestMode

:+1:

Late to the :+1: party, but emphatic :+1: : this is solid, important attention to detail.


🐛 Fix KCPRequestInfoResolver for kind: Cluster

Summary
The cache server preprocesses the path to remove the cluster prefix in https://github.com/kcp-dev/kcp/blob/88d6071b2aaf47bcd5e854f8209e4c3bd8035b35/pkg/cache/server/config.go#L172-L186
When a resource of kind: Cluster is created and the first cluster prefix is dropped, the path would be a k8s request info path (/apis/...) but will still have the clusters keyword in the path.
Due to this, the regex in the kcp request info resolver does not work well.
This commit updates the resolver to include the following changes:

If a path is a k8s request info path (begins with /api or /apis), then the path is not checked against the regex.

The regex is updated to preserve the forward slash in the strippedURL.

Related issue(s)
Fixes #2811

/ok-to-test
Invited you to the org.

/test pull-kcp-lint

/retest


appveyor autodetection, take care of new envs

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[x] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose
Have a new logic in place for pester autodetection (i.e. what tests to run in which scenario)

locally doesn't break. hopefully neither in appveyor.

yay!

yay thank you! my tests failed when i'd forget to update. this is nice ☀ 🌻


feature: add 404 page

I add the new 404 page.

Codecov Report

Merging #43 (bed5c04) into main (35e5492) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   34.40%   34.40%
=======================================
  Files          11       11
  Lines         125      125
  Branches       22       22
=======================================
  Hits           43       43
  Misses         82       82

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[10.x] $model->refresh() not forcing use of writer DB instance for the loaded relationships

Found an issue when working on a project that has a Writer instance and multiple readers when using $model->refresh(), I was expecting the refreshed model an relationships to be the latest modifications, but turns out that although the model itself was being loaded from the writer, the relationships where being loaded from readers which in some cases have not been replicated too yet.
Only users that have both reader and writer db instances would benefit from this changes, apps with only readers would notice no change in behavior

Just curious, why does using the sticky option not solve this?

Please mark as ready for review again once have answered 👍

So in my scenario, by the things updating the record could happen in parallel in different requests, I have an atomic lock in place that controls that both requests don't make the update at the same time, but was still noticing the race condition on my code. We have sticky option enabled, but I think what happens in this specific case is that by the time that we call refresh() no writes have happened to the db so we haven't switched over to the writer. This is also not running on a Job where sticky is expected to persist between runs.

I dunno, I guess I'm not sure I agree with this. In that case, why not make every read be done on the write connection, what is the point of read replicas at all at this point? Will think about it in the future.

I see your point, its an edge case, there are workarounds to it. My main point of the PR was that upon checking the refresh() method I saw that when reloading the main model, it was using ->useWritePdo() already, so not doing so for the relationships felt strange and asymmetrical.


PP-9315 Support Worldpay 3DS2 non-JS mode

WHAT YOU DID
Implement Worldpay 3DS2 flow as described in https://developer.worldpay.com/docs/wpg/directintegration/3ds2#payment-requests-with-javascript-not-enabled
Note: dfReferenceId="" is required for Worldpay to accept the payload even though this is not well documented.
How to test
Tests should make sense. WorldpayPaymentProviderTest.java can be run locally if environment variables are set.
I will test end-to-end including frontend once this is deployed on Test.

@alexbishop1 I believe I've addressed all your comments now. Please may you re-review?


add browserHttpEndpoint option for client requests close #272

Defines the http endpoint which is used and prepended to make client side requests.
Related: #272

I released new version.

Thanks, working great for me 🙏

Looks like this wasn't documented.

Docs update proposed in #277. Feel free to use or discard in favor of something better.


Remove L prefix before line segment of repo URL

i don't know how to explain this one... this L has been here a long time, but it seems unnecessary as it always results in URLs like https://github.com/etc..../foo.jl#LL1-2 with the double LL. Here's an example result of this change:
-https://github.com/invenia/PkgTemplates.jl/blob/89e6dd5e39641c8d40b2492d307e361a83b6dd0f/src/plugin.jl#LL155-L162
+https://github.com/invenia/PkgTemplates.jl/blob/89e6dd5e39641c8d40b2492d307e361a83b6dd0f/src/plugin.jl#L155-L162

I tested with Documenter 0.23, 0.24 and 0.25 and it always gives this same LL result.
As you can test for yourself using the two example links above, both work i.e. both link correctly to the source code of the PkgTemplates.tags(::Plugin) function.
However, the LL doesn't (or doesn't any longer??) work on GitLab. I don't have an open-source GitLab repo where i can show this, but somthing like https://gitlab.com/etc..../foo.jl#LL1-2 does not highlight lines 1-2 whereas https://github.com/etc..../foo.jl#L1-2 (with the single L) does highlight the intended lines.

Turns out this has been outdated since Documenter 0.15! https://juliadocs.github.io/Documenter.jl/v0.14/lib/public/#Documenter.makedocs

i don't have merge rights, but hopefully this is good to go :)


Library Build Support like ng-packager in angular cli

Is your proposal related to a problem?
i cannot rely on create-react-app to build react component / library.
Describe the solution you'd like
Maybe it can rely on babel /rollup / webpack to generate react component library. The generated npm package would be very similar to one like generated by ng-packager in angular.
Describe alternatives you've considered
integrated with third party library like nwb to generate react library.
Additional context
N/A

Adding to this:
We use an ejected CRA, with one of the main reasons to get library output:
    library: 'XYZ',
    libraryTarget: 'umd',

A flag like LIBRARY_MODE=umd (default off) to inject the above would go far


Added source link

Description of Change
This PR will add the Source Link to our package.
Before (1.0.1 on nuget.org):

After (This PR):

As you can see the Source Link is green, and we have the Repository information now.
Linked Issues

Related to #92

PR Checklist

[x] Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
[ ] Has tests (if omitted, state reason in description)
[ ] Has samples (if omitted, state reason in description)
[x] Rebased on top of main at time of PR
[x] Changes adhere to coding standard
[ ] Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls/XYZ

Additional information

Hey @pictos! Could you follow up on the build errors?
It's happening on both Windows + macOS. I'm also able to reproduce it locally.

error NU5017: Cannot create a package that has no dependencies nor content. [/Users/bramin/GitHub/CommunityToolkit.Maui.Markup/src/CommunityToolkit.Maui.Markup/CommunityToolkit.Maui.Markup.csproj]

@brminnick what's the command that you're using? I tried on my end and everything works on both VS 2022 preview 6 and terminal

Also, from the logs
 Successfully created package '/Users/runner/work/1/a/nuget/CommunityToolkit.Maui.Markup.1.0.0-preview1348.nupkg'.
/Users/runner/hostedtoolcache/dotnet/sdk/6.0.302/Sdks/NuGet.Build.Tasks.Pack/build/NuGet.Build.Tasks.Pack.targets(221,5): error NU5017: Cannot create a package that has no dependencies nor content. [/Users/runner/work/1/s/src/CommunityToolkit.Maui.Markup/CommunityToolkit.Maui.Markup.csproj]

looks like the package was created and then an error happens.

I'm able to reproduce it using the same command in the CI Pipeline:
https://github.com/CommunityToolkit/Maui/blob/721b67a3360c594572a4c0ca778813951e95dbe9/azure-pipelines.yml#L296

@brminnick I took the time to investigate this issue, and I would say it's something to do with NuGet or the package...
And has to do with the version number parameter, like on our YAML on MCT we don't specify the output path, as you can see here
script: 'dotnet pack $(PathToCommunityToolkitCoreCsproj) -c Release -p:PackageVersion=$(NugetPackageVersion)'
Locally on my mac, I tried this command and it works.
dotnet pack -c Release -p:PackageVersion=<IP_ADDRESS> --output obj/nuget -p:IncludeSymbols=true -p:SymbolPackageFormat=snupkg

Do think that makes sense to use the same pattern as we use for MCT?
Looking in the www I found this StackOverflow post that could have something to do with it. It says this error is caused by a folder that starts with . (not sure if it's our case)

Thanks Pedro! Let's double-check with @VladislavAntonyuk and @jfversluis who are more familiar with the NuGet part of this CI/CD process.
Vlad/Gerald - what do you think? Can we edit this dotnet pack step?

We need to remove it from macOS build and move to Windows build.
The output path which is currently specified is used by NuGet publish task. This task exists only in Windows job.

Interesting. It seems to create the nupkg but not the snupkg package. The only thing I can think of is that the pdb files are not created in the pipeline and therefore not picked up when creating the snupkg file resulting in an empty package?
But I also can't reproduce this locally. Maybe some bugged .NET version we're using in the pipeline but not locally?

Hey @pictos! I figured out that the error was actually a bug that is fixed in .NET 7.0.
I updated our Azure Pipelines YAML file, adding .NET 7.0.x to the CI pipeline before running dotnet pack:

Install .NET 6 SDK
Install .NET MAUI

Uses the .NET 6 SDK to install .NET MAUI which ensures we have a stable (non-preview) .NET MAUI build

Build CommunityToolkit.Maui.Markup.Sample
Build CommunityToolkit.Maui.Markup + CommunityToolkit.Maui.Maurkup.UnitTests
Run Unit Tests
Install .NET 7 SDK

Used only by dotnet pack

Pack NuGet Package

We're still using .NET 6 to build our DLLs, so our output isn't really impacted by installing this preview of .NET 7.
I also downloaded and tested the NuGet package asset from this CI build and it works fine in my .NET MAUI apps:

Dang - never mind.
Doing this causes the .NET MAUI Dependencies to appear:

I'll revert the CI/CD changes

https://github.com/dotnet/sourcelink


Cover letter

From the PLOS submission guidelines for cover letters:

Upload a cover letter as a separate file in the online system.
The cover letter should address the following questions:

Why is this manuscript suitable for publication in PLOS Computational Biology?
Why will your study inspire other members of your field, and how will it drive research forward?

You may recommend a suitable Associate Editor to handle your submission; however, the editors reserve the right to contact an alternative—either from the board or a guest editor.
The cover letter will only be available to the editor and the journal staff.

Example cover letters from the lab:

Huddleston et al. 2020
Figgins and Bedford 2022
Potter et al. 2019

Closed by f35dd87e


[Enhancement] The way to handle extra info from CDP content.

Is possible to implement support to handle CDP?
Example of the issue: https://github.com/Cuadrix/puppeteer-page-proxy/issues/82

I will take a look tomorrow

The Network.requestWillBeSentExtraInfo and Network.responseReceivedExtraInfo events in the Chrome DevTools Protocol (CDP) are designed to provide extra information about network requests and responses, such as additional HTTP headers added by the browser or by extensions.
However, when we are using page.setRequestInterception(true), CDP client is effectively taking over the handling of requests. This includes things like adding and removing headers.
Because the requestWillBeSentExtraInfo and responseReceivedExtraInfo events are tied to the internal workings of the browser's network handling, they may not be emitted when request interception is turned on. The events are based on the original, unintercepted requests and responses, and therefore may not reflect any changes made during interception.
That's why automation-extra-interception-proxy have same issues as puppeteer-page-proxy does.
Unfortunately, at the moment there is no reliable way to implement this fully. The only thing left is to simulate the behavior of these events as much as possible.
I will keep the issue open until a complete solution is found for all problems associated with the absence of these events.

@devblack Lately, I have been using reqwest-impersonate.
It is possible to create an adapter for the library. I was using it independently, so I didn't do it.
Do you still need it? Or maybe just a simple wrapper to use reqwest-impersonate from Node.js?
I am not particularly interested in this at the moment, but I can help as much as I can.

Hey. I don't need it anymore. But thank you for the reply.


It isn't opening and the problem with the new security

https://novelsparadise.site/

Duplicate of https://github.com/LNReader/lnreader-plugins/issues/1101


AMD should reuse/adapt the academic State Of The Arts

Hi @rys
It is often deeply institutionalized in companies and even in the human nature, to reinvent the wheel or to work in isolation.
I have much admiration for AMD and its software developers and trying new approaches is a way to drive innovation.
AMD FSR while not using neural networks is a very interesting way to look at the problem.
But please AMD you are not alone, there is a widespread community of very smart people out there: the scholars and they regularly release innovations in machine learning, especially regarding the topic of super-resolution.
It would be a shame if you didn't take strong inspiration from their amazing ideas that can be combined in order to create a synergetic algorithm, on par or superior to DLSS.
The #1 reference website for tracking the state of the art is paperswithcode.com
See:
https://paperswithcode.com/task/multi-frame-super-resolution
https://paperswithcode.com/task/image-super-resolution
https://paperswithcode.com/task/video-super-resolution
https://paperswithcode.com/task/super-resolution
https://paperswithcode.com/task/3d-object-super-resolution
Note that i also invite for a collaboration with Intel XeSS.
You might also take inspiration from this new Nvidia open source library:
https://www.phoronix.com/scan.php?page=news_item&px=NVIDIA-Image-Scaling-SDK
The graal would be if for your next neural based DLSS competitor, to publish your results (PSNR, SSIM) on the same benchmarcks as paperswithcode.com, additionally it would be a great scientific contribution if you could submit to paperswithcode.com game/textures oriented datasets.

Agreed.

Here goes a suggestion that improves on the Lanczos kernel. johncostella.com/magic/
Based on this "magic" kernel there is a improved edge detector. johncostella.com/edgedetect/

Here goes a suggestion that improves on the Lanczos kernel. johncostella.com/magic/
There is deep  analysis on the above page and a link to a improved (2021) edge-detector.

"This strategy of “generalized sampling” has appeared in a
few graphics papers, but is largely unexplored in our community. This survey
broadly summarizes the key aspects of the framework, and delves into specific
applications in graphics. Using new notation, we concisely present and extend
several key techniques. In addition, we demonstrate benefits for prefiltering in
image downscaling and supersample-based rendering, and analyze the effect
that generalized sampling has on the noise due to Monte Carlo estimation.
We conclude with a qualitative and quantitative comparison of traditional and
generalized filters."
"The interpolating cardinal B-splines β*int  consistently outperform the more traditional filters for the same N and W. "
https://w3.impa.br/~diego/publications/NehHop14.pdf

In other news: https://www.phoronix.com/scan.php?page=news_item&px=AMD-FidelityFX-Super-Res-2.0

I hope the FSR2.0  use something like this:
"Fast temporal reprojection without motion vectors"
https://jcgt.org/published/0010/03/02/

Great find!

Another great find that helps with why people have so much variance on "sharpness" preferences ( view distance and the display effects).
Presentation:
https://www.youtube.com/watch?v=D0EcX0NtpW0
Paper:
https://onlinelibrary.wiley.com/doi/abs/10.1111/cgf.13942

I'm going to close this issue since it's not directly related to FSR1, but I also wanted to comment on a couple of the general themes to hopefully reassure you around how we go about our developer-focused applied research.
We definitely don't do that research in a vacuum, and honestly I'm not sure how we could. Like every company trying to invent the future in some way, we definitely absorb and take inspiration from the state of the art as we see it, in order to inform what we try, how we try it, and how we shape what ends up in the hands of developers.
Our outlet at the end for this kind of thing is always laser focused on getting the code and related information, tooling, documentation or whatever it is into the hands of developers, and working with those developers to put what we've made into what matters: their games.
So we start by thinking about developers, and we end by delivering what we've made directly to them, often by working with them every step of the way. If we can publish a paper or talk at a conference then we do that when we can (we're presenting about FSR2 internals at GDC 2022 as I type this!). Hopefully the balance is the right one.
<3

@rys It is reassuring to hear that you try to a maximum to survey the advances in the state of the art.
However it is very easy to miss interesting and unknown papers, for example a key major advantage of FSR 1.0 is that contrary to DLSS and XeSS it does not require motion vectors information. Which means that it can be applied on any software/game, games do not need to be designed for it and hence you can provide a global radeon setting. As an example, all game emulators are integrating FSR 1.0 and it has dramatically improved the rendering quality of old video games.
I understand that everything's a tradeoff and algorithms with motion vectors are currently generally better than FSR 1.0.
However researchers have innovatively found that it is possible to have temporal based antialiasing like FSR 2.0 without requiring motion vectors. This is disruptive as it would allow graphisms superior to FSR 1.0 (unclear wether < or >= to FSR 2.0) for every game out there, out of the boxes (including emulators).
I am refering to the paper cited by @brunogm0
https://jcgt.org/published/0010/03/02/
While FSR 2.0 align with XeSS/DLSS, the cited paper would enable AMD to keep having the best option for game not specially designed to provide motion vectors (AKA 99.9% of video games)
Hence I sincerely hope AMD will consider reusing this paper for an innovative FSR variant


Minor cleanup to should.exist()

Improved readme instructions, and moved the tests into the main test suite.
My other pull request for adding custom messages includes these changes, but if you decide not to accept that, you can get this stuff separately.
Cheers,
Aseem

this pull request might solve #25 too

Hoping to see this get merged in for real soon :+1: