Background Service

I was thinking it'd probably be a cool idea to have a background service, mostly for the phone finding feature. I realised that while I was testing out this feature that it wasn't working very well if you forget to open the app or if the app decided to sleep.
If you had some brief idea as to how this would work I could start off the PR however I have limited Kotlin experience and it has been years since I've touched android development.

@G-OD, thanks for creating this issue.
The short answer to how to add this service is to uncomment this line. You can uncomment and test if it works for you, since I have not tested thoroughly. Also, you may have an alternative, better way to do this, so try and let me know how it goes.
As you can see, we had this implemented at one time. However, there are a number of issues doing that:

The app uses more memory. This is one of the major complaints people have with the official app.
The app is always "in your face." People do not like that.
I feel that Android is trying to discourage developers from keeping services running in the background, and this is why people come up with these hacks.

So, we have disabled this feature. I know that always running the app in foreground/background has some legitimate advantages. In addition to "Find Phone", "Auto time adjustment" does not work after the app has been swapped out of memory. On balance, I feel the negatives outweigh the positives, and this is why we disabled it.
Another way to accomplish keeping the app in memory is to use a 3rd party app like Tasker or MacroDroid.
Now, having said that, I am open to giving the user an option to run the app in the background, but this should not be the default behaviour, and should be configurable in the settings.
So, I think we can start by testing if uncommenting the code I mentioned above works well for you. The next step would be to think if we can add this option to settings.
Regards

BTW, I like your handle. O guess GOD was taken by somebody already.

Okay that's understandable. I took a look at the code and noticed there was a service already while looking into creating my own temporary solution so it's nice to get context as to why it's not in use. I'll definitely look into enabling this and see how it goes.
Also thanks. This name is actually my initials so it's not there for the reasons you may think although I obviously made it like this on purpose haha.

I agree that adding an option for keeping the app running in the background would be good. The fact that the app have to be reopened regularly on the phone before being abke to interact with the watch is the only reason why I keep using the official app...

@G-OD So, dies it work for you when you uncommented the background service?

I had issues with it. I think it's because the background service needs to do the bluetooth connection as the main activity cannot run? I'm mostly just guessing as Android development isn't my main forte. I tried changing the foreground service type to "connectedDevice" and added the permission "FOREGROUND_SERVICE_CONNECTED_DEVICE". I also tried modifying the service to search bluetooth in the background like what's done in the MainActivity but that didn't work either so maybe someone who actually knows how to use these APIs could do a better job then me.

Ok, thanks for letting me know.
On Thu., Feb. 1, 2024, 2:11 p.m. G-OD, @.***> wrote:

I had issues with it. I think it's because the background service needs to
do the bluetooth connection as the main activity cannot run? I'm mostly
just guessing as Android development isn't my main forte. I tried changing
the foreground service type to "connectedDevice" and added the permission
"FOREGROUND_SERVICE_CONNECTED_DEVICE". I also tried modifying the service
to search bluetooth in the background like what's done in the MainActivity
but that didn't work either so maybe someone who actually knows how to use
these APIs could do a better job then me.
—
Reply to this email directly, view it on GitHub
https://github.com/izivkov/CasioGShockSmartSync/issues/68#issuecomment-1922040624,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7M37XNOZL2JCDHGXPHE3LYRPSFFAVCNFSM6AAAAABCNOQ3CWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRSGA2DANRSGQ
.
You are receiving this because you commented.Message ID:
@.***>

I am closing this is issue. Will reopen if I, or somebody else can come up with a good solution.


[osgi] avoid javax.xml.bind version range to support Java 8

I'm not very comfortable with the idea of leaving this as a completely open version on the import. I'm also a bit uneasy about expanding the range without adding test coverage to prove it's safe. I'm going to look in to expanding this in to a range that encompasses both 2.2.8 as well our current 2.3.1... probably something like [2.2,3) along with testing across both version bounds (at least for the tests in the :xml module).

Subsumed by #2858


BMI Calculation

Just had a look at your app using my own height which is 1.76 meters... and my weight is 63.2KG's... The app must have a calculation error as its returning that im obese, which i defo aint. The BMI for my body should be in the region of 19-25.
Healthy weight range for your height:
59.9kg - 81kg

Hey Andy.
I just checked out the iOS app and WatchOS app with those same measurements in the simulator and it reports a BMI on 20.6 which is categorized as normal.
There's not a whole lot of information for me to go off but some possibilities are:

There might be a unit conversion error, though you gave me those measurements in metric and the back end is all metric so unless I've messed up there should be no conversion.
The Apple watch can only access two weeks of health kit data and so height has to be regularly updated (I can't remember if I ever fixed this, it's been a while since I worked on this project).
Something messed up on the front end and it didn't update the values correctly.

If you watch for error messages when you run the app then you might see something has gone horribly wrong on the back end. Most things should print an error.
Sorry I couldn't be of more help. If you have any more info just let me know.


Fix incorrect reference to _canvasElement

This was raising an error on snap()

Hi @bensonruan, this is for your consideration. Thanks for your work, I've found it very useful!

Thank you @rilla , I had merged the fix


Created an aim trainer demo

Aim trainer demo. Use mouse to click targets that appear randomly on the screen. Displays time elapsed, click accuracy, and targets clicked per second.

@flarfo Thanks a ton!


Sorting on Discover page does not work correctly

Date sorts are fine, but title and author sorts do not work.
006.zip

181120_181120_test-env.txt

Issue resolved as a part of the Discover redesign


Custom keyboard shortcuts have not worked ...

Issue Type: Bug
Custom keyboard shortcuts have not worked with either a find input or a replace input.
VS Code version: Code 1.36.1 (2213894ea0415ee8c85c5eea0d0ff81ecc191529, 2019-07-08T22:59:35.033Z)
OS version: Windows_NT x64 10.0.17134

Hello, I would like you to edit a behavior of the inputs as well.
When a text is selected in an editor, the text appears in the input after giving either a find or replace command.

@Martin00001 what's the keyboard shortcuts / commands you are trying to use?

I assigned F9 + F9 for copying and F10 + F10 for pasting.

Copy/Paste command only works when the focus is in the text area.

I thank you


Update derevo-cats, derevo-cats-tagless, ... to 0.12.7

Updates

tf.tofu:derevo-cats
tf.tofu:derevo-cats-tagless
tf.tofu:derevo-circe-magnolia

from 0.12.6 to 0.12.7.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "tf.tofu" } ]

labels: library-update, early-semver-minor, semver-spec-patch

Superseded by #244.


#518 Fix upload only when stable

Related issue: https://github.com/bincrafters/community/issues/518

Codecov Report

Merging #15 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   98.44%   98.43%   -0.02%
==========================================
  Files           7        7
  Lines         129      128       -1
==========================================
- Hits          127      126       -1
  Misses          2        2

Impacted Files
Coverage Δ

bincrafters/build_shared.py
97.84% <100%> (-0.03%)
:arrow_down:

bincrafters/__init__.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a5aaf...5f05a10. Read the comment docs.


Add installation update to activity handler

Fixes https://github.com/microsoft/botbuilder-js/issues/2546

Pull Request Test Coverage Report for Build 149174

4 of 5 (80.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.0004%) to 81.6%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

libraries/botbuilder-core/src/activityHandlerBase.ts
2
3
66.67%

Totals

Change from base Build 149093:
0.0004%

Covered Lines:
13380

Relevant Lines:
15638

💛  - Coveralls


Upgrade FAB to 2.1.6

CATEGORY
Choose one

[ ] Bug Fix
[x] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY

Replace the pinned commit with the actual FAB release for the permissions perf fix
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

test in staging
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS
@michellethomas @john-bodley

Codecov Report

Merging #134 into airbnb-master will increase coverage by 7.64%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           airbnb-master     #134      +/-   ##
=================================================
+ Coverage          65.13%   72.78%   +7.64%
=================================================
  Files                427       78     -349
  Lines              20682    10589   -10093
  Branches            2311        0    -2311
=================================================
- Hits               13471     7707    -5764
+ Misses              7086     2882    -4204
+ Partials             125        0     -125

Impacted Files
Coverage Δ

superset/db_engine_specs.py
55.59% <0%> (-1.79%)
:arrow_down:

superset/models/core.py
82.94% <0%> (-0.62%)
:arrow_down:

superset/views/core.py
74.73% <0%> (-0.29%)
:arrow_down:

superset/assets/src/components/Checkbox.jsx

...ations/deckgl/layers/Polygon/PolygonChartPlugin.js

...ets/src/dashboard/components/dnd/DragDroppable.jsx

...c/visualizations/deckgl/layers/Polygon/Polygon.jsx

...ssets/src/visualizations/presets/MapChartPreset.js

superset/assets/src/components/EditableTitle.jsx

superset/assets/src/setup/setupPlugins.js

... and 342 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04577bc...8ddb8de. Read the comment docs.


MMA Agent should not be referred to as an extension

"The Log Analytics agent virtual machine extension for Windows is published and supported by Microsoft. "
I think the agent should not be referred to as an extension as the installation process is different as compared to for example the IaaSAntiMalware Extension. The MMA agent is not listed in the VM extensions blade.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cefed4e0-440d-18d5-8b8d-4a345f396e9b
Version Independent ID: 2882136f-7fde-685d-c24f-037ee7626667
Content: Azure Monitor virtual machine extension for Windows
Content Source: articles/virtual-machines/extensions/oms-windows.md
Service: virtual-machines-windows
GitHub Login: @axayjo
Microsoft Alias: akjosh

@JDWNL
Thanks for the feedback!
Not all the extensions will be listed on the VM extensions blade.
But when we describe the vm using Azure cli or powershell, We can see all of them.
The installation process is similar to installing other extensions. Can you please elaborate about the way it differs?

@JDWNL is there any update

I see what you mean. Perhaps I misunderstood the documentation then. The overlap between the different extensions related to monitoring + the fact that MMA is not listed in the extensions blade + the fact that we don’t recommend to install it via ARM but via ASC instead made me think it’s a different concept.
My apologies for the confusion.
Thanks
From: jakaruna-MSFT<EMAIL_ADDRESS>Sent: Wednesday, 23 October 2019 11:41
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Joost de Wit<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] MMA Agent should not be referred to as an extension (#41205)
@JDWNLhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJDWNL&data=02|01|Joost.deWit%40microsoft.com|df699ae405074b1cc12b08d7579d1e00|72f988bf86f141af91ab2d7cd011db47|1|0|637074204643243338&sdata=oA3MN%2BAbZqMb%2Bgfu1ozWgIqhzxZbDzfU47Pb09wt99I%3D&reserved=0 is there any update
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F41205%3Femail_source%3Dnotifications%26email_token%3DAJESPPAHLYWRRGXBII2BCW3QQAL23A5CNFSM4JDNIVI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECAYTKI%23issuecomment-545360297&data=02|01|Joost.deWit%40microsoft.com|df699ae405074b1cc12b08d7579d1e00|72f988bf86f141af91ab2d7cd011db47|1|0|637074204643253340&sdata=fCGm7zXffKtnlShNXO2pq%2Be%2B82R%2FIv53xyJvFqb1fRY%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJESPPEV45XDWR3WLHUD433QQAL23ANCNFSM4JDNIVIQ&data=02|01|Joost.deWit%40microsoft.com|df699ae405074b1cc12b08d7579d1e00|72f988bf86f141af91ab2d7cd011db47|1|0|637074204643253340&sdata=QJOsPM0XF5vBQNuBqRVy8oJSHJuFGi7ZzCTIjmQF4E4%3D&reserved=0.

@JDWNL Thanks for confirming on the confusion.
Hope you got this clarified now, I am closing this issue now.
However feel free to reply on this thread, if you have further questions so that we can reopen this issue and continue.


Script to pull and deploy latest docker image

Acceptance Criteria

A script is created that pull the latest docker image from the registry made in #93, stands down the current running container and stands up the pulled image

Blocked because it depends on #93


An error occured when i compiled a test file using itkArray.h

I wrote a test file in my Linux environment to test the itkSimilarityIndexImageFilter class.In fact, this test file is itkSimilarityIndexImageFilter.cxx (InsightToolkit-5.2.1/Modules/Filtering/ImageCompare/test/itkSimilarityIndexImageFilterTest.cxx).
when it #include "itkSimilarityIndexImageFilter.h",the error hanppened.

error:
itkSimilarityIndexImageFilter.h:23:
/ITK-install/include/ITK-5.2/itkArray.h:234:41: error: expected a type
ITKCommon_EXPORT std::ostream & operator<<(std::ostream & os, const Array & arr);
/ITK-install/include/ITK-5.2/itkArray.h:236:41: error: expected a type
ITKCommon_EXPORT std::ostream & operator<<(std::ostream & os, const Array & arr);
2 errors generated.
Is there a problem with my environment？

Steps to Reproduce

Expected behavior

Actual behavior

Reproducibility

Versions

Environment

Additional Information

What is you GCC version? What is the full error message?

i had fixed it.thank you.
------------------ 原始邮件 ------------------
发件人: "Dženan @.>;
发送时间: 2023年5月10日(星期三) 晚上9:20
收件人: @.>;
抄送: @.>; @.>;
主题: Re: [InsightSoftwareConsortium/ITK] An error occured when i compiled a test file using itkArray.h (Issue #4043)
What is you GCC version? What is the full error message?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Cannot find module 'graphql-yoga'

Steps to reproduce:

mkdir playground
cd playground
yarn init -y
yarn add graphql-yoga
node
require('graphql-yoga')

Error: Cannot find module 'graphql-yoga'
    at Function.Module._resolveFilename (module.js:543:15)
    at Function.Module._load (module.js:470:25)
    at Module.require (module.js:593:17)
    at require (internal/module.js:11:18)

Node v9.10.1
Yarn v1.6.0

This can be true 😨
Yoga's package.json mentions "main": "dist/src/index.js", while the tree looks like so:

Most probable cause is this change in #283.
@KATT @schickling 🆘

@kurniawanw0194 does installing<EMAIL_ADDRESS>solve the issue for you? This may work as a temporary workaround, you'll just not get graphql-deduplicator introduced earlier today via https://github.com/graphcool/graphql-yoga/pull/272

I believe @kachkaev meant<EMAIL_ADDRESS>This is the latest version that I could get to work this morning. Also manually changing the package.json main field from "main": "dist/src/index.js" to "main": "dist/index.js" solved the problem with the latest graphql-yoga but I'm not sure if that would break other things?

Same issue.

I think the best to stick with<EMAIL_ADDRESS>for now. Any tweaks in package.json in node_modules/graphql-yoga will be washed away after running yarn or npm install.

Yup sticking with 1.12.1 till this gets patched! 😄

#298

Apologies for the inconvenience. This one must have slipped while merging this PR: https://github.com/graphcool/graphql-yoga/pull/283
I just released a new fix 🚢

I did that because typescript watcher doesn't like to both watch dist and write to dist. Wasn't aware it would affect anything other than typescript compilation. Now you probably broke yarn watch instead, but I haven't confirmed (on my phone writing this).

@KATT I see. Happy to merge a PR that fixes this 😊

@schickling I got a PR open now - #300 - please CR carefully :)


oFrugal grammar?

There are several examples of what is called frugalese, but is there any grammar or formal description for that?

Wow! Now that there is a grammar and interpretation, writing oFrugal shell is a matter of expresing grammar for some lexer/parser. I will probably try Antlr4.2 as it support operator associations, so there will be no need to fight with left recursion. The (quicker?) library parsimonious will need some hacks to avoid left-recursion, and I prefer when grammar is represented as directly as possible because then it will be easier to change together with ob-exp if such necessity arises.
Please, also note one question above on how the grammar can accommodate shell commands more naturally (include, ob =, and other custom commands, eg, I have graph and solve).

@rnd0101 Please, also note one question above on how the grammar can accommodate shell commands more naturally (include, ob =, and other custom commands, eg, I have graph and solve).

I had preferred to just use an informal grammar for statements at this point.  I can see how to provide a formal interpretation of a session, that is, for all well-formed inputs through a round of REPL inputs from start-up of oFrugal to ending, but it is getting a bit far ahead.
For now, I think the only statements we need are three:
include "file-reference";

(* reads the file as if entered at the keyboard.  The bindings are updated as appropriate *)

ob binding-name = ob-exp ;

(* evaluates ob-exp in the current bindings context and retains that ob as bound to the
binding-name *)

ob-exp ;
(* simply evaluates the ob-exp and reports the ob that the evaluation yields. *)

The command line initiation of the oFrugal REPL can have file-references to start with.

There is a hash-bang convention:

#! **oFrugal** *semantic-version* *optional-options*

Also, there are no reserved words.  So the **ob** binding-definition needs to depend on phrase up to and including the "=".

Those are my only thoughts at the moment.

ok. What about opening up a good way for "vendor-specific" commands? In my implementation there are some interactive options etc and it could be good not to conflict with lindies.
One way can be:
:command <arguments>
(I think, include can be of the same category for consistency)

@rnd0101 ok. What about opening up a good way for "vendor-specific" commands?
One way can be:
:command <arguments>

I don't think I have any problem with that.  I want include to be part of the standard notation, because it can occur in the included files also.
If you want your implementation-specific commands to be in included files as well as direct REPL statements, I suggest you use the vendor-specific flavor for those.
I suspect ":" at the beginning of the line should be fine.  I don't expect that any term will begin with that.  On the other hand, a "::" could end up at the beginning of a line of a multi-line expression.  Watch out for that, or choose a different command-line trigger character.


changing tab behaviour in multiselect; not focussing immediately on next field

This minor change is a partial revert of 4094c1c (that solved #898). I think the behaviour is requested in that issue is correct for the  traditional, single option select. For the multi select version, however, it makes more sense to keep the focus on the field, since you may want to add another value while typing. Although it is the same plugin, I don't think the different behaviour is conflicting: the appearance is entirely different. I wouldn't want my users to press Enter too often: because in normal text-input fields using Enter leads to submitting the entire form.

+1

Now that 4.0.0 has been released, the branches have switched and this is pointing to the wrong one. If you are still interested in getting this merged, create a new pull request for the stable/3.5 branch and link back to this old one.
Until then, we have to close this off as it is not possible to merge it in.


My portfolio site

In this pull request i did the following

Designed a nav bar / header section using flex styling

designed a headline section right after the nav bar making use of css flexbox

fixed linter errors

Project Status: INVALIDATED :red_circle:
Hi @CrackedYoda ,
While you made a great effort in this project, I can't go ahead and review your code.

Invalid Code Review Request

This is because you have submitted a project, that is missing the Microverse README Template. This makes your project incomplete as every section of the readme template is required except for the FAQ section which is optional. So please make sure to add the README template to your project and fill in all the necessary contents :+1:

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @NahnahAJ in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


Support for login with Apple and Facebook

If anyone isn't tackling this I would like to give it a go 😎

Yeah..... .We can authenticate userprofile not only with Github but apple, google facebook also

@Mvrs wait on this, it's a low priority right now

@Krishna-Ramasimha so you're saying every other has been implemented except for Apple, Facebook, and Google? Correct?

Like... adding support for login with these 3 and many more instead of just github and twitter cuz many might not have these accounts

ah~~~ok

Yeah maybe try limiting/streamlining Oauth services you allow. It could become a security liability in the future if you are supporting authentication through 5 services at once

@DGKSK8LIFE yeah, I agree. I also believe the design would change as well so that would require the login component to have a new design. Which would require a new Storybook component.

+1 for google authentication, non-developer guys don't have github and twitter is not popular in countries like italy


[PCL] build failure

Host Environment

OS: windows

To Reproduce
Steps to reproduce the behavior:
./vcpkg install PCL
config-x86-windows-out.log
PS C:\Users\sam\vcpkg> .\vcpkg install pcl
Computing installation plan...
The following packages will be built and installed:
  * boost-iostreams[core]:x86-windows -> 1.75.0
  * boost-multi-array[core]:x86-windows -> 1.75.0
  * boost-ptr-container[core]:x86-windows -> 1.75.0
  * boost-signals2[core]:x86-windows -> 1.75.0
  * boost-sort[core]:x86-windows -> 1.75.0
  * boost-uuid[core]:x86-windows -> 1.75.0
  * bzip2[core]:x86-windows -> 1.0.8#1
  * eigen3[core]:x86-windows -> 3.3.9
  * flann[core]:x86-windows -> 2019-04-07#1
  * liblzma[core]:x86-windows -> 5.2.5#2
  * libpng[core]:x86-windows -> 1.6.37#14
  * lz4[core]:x86-windows -> 1.9.2-2
    pcl[core]:x86-windows -> 1.11.1#1
  * qhull[core]:x86-windows -> 8.0.2
  * xxhash[core]:x86-windows -> 0.8.0#1
  * zlib[core]:x86-windows -> 1.2.11#9
  * zstd[core]:x86-windows -> 1.4.5#1
Additional packages (*) will be modified to complete this operation.
Detecting compiler hash for triplet x86-windows...

-- Using cached C:/Users/sam/vcpkg/downloads/bzip2-75a94bea3918e612b879d6a11ca64b8689526147.tar.gz
-- Cleaning sources at C:/Users/sam/vcpkg/buildtrees/bzip2/src/8689526147-1ef169fbaa.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/Users/sam/vcpkg/downloads/bzip2-75a94bea3918e612b879d6a11ca64b8689526147.tar.gz
-- Applying patch fix-import-export-macros.patch
-- Using source at C:/Users/sam/vcpkg/buildtrees/bzip2/src/8689526147-1ef169fbaa.clean
-- Configuring x86-windows
-- Building x86-windows-dbg
-- Building x86-windows-rel
-- Downloading https://repo.msys2.org/mingw/i686/mingw-w64-i686-libwinpthread-git-<IP_ADDRESS>06.c9a21571-1-any.pkg.tar.zst -> msys-mingw-w64-i686-libwinpthread-git-<IP_ADDRESS>06.c9a21571-1-any.pkg.tar.zst...
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:198 (file):
  file RENAME failed to rename

    C:/Users/sam/vcpkg/downloads/temp/msys-mingw-w64-i686-libwinpthread-git-<IP_ADDRESS>06.c9a21571-1-any.pkg.tar.zst

  to

    C:/Users/sam/vcpkg/downloads/msys-mingw-w64-i686-libwinpthread-git-<IP_ADDRESS>06.c9a21571-1-any.pkg.tar.zst

  because: No error

Call Stack (most recent call first):
  scripts/cmake/vcpkg_acquire_msys.cmake:90 (vcpkg_download_distfile)
  scripts/cmake/vcpkg_acquire_msys.cmake:138 (msys_package_download)
  scripts/cmake/vcpkg_find_acquire_program.cmake:446 (vcpkg_acquire_msys)
  scripts/cmake/vcpkg_fixup_pkgconfig.cmake:112 (vcpkg_find_acquire_program)
  ports/bzip2/portfile.cmake:43 (vcpkg_fixup_pkgconfig)
  scripts/ports.cmake:128 (include)

Error: Building package bzip2:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: bzip2:x86-windows
  Vcpkg version: 2021-01-13-unknownhash

Additionally, attach any relevant sections from the log files above.

config-x86-windows-out.log

Seems a permission issue or an exist cmake issue, please rebuild pcl again.
Thanks.

Seems a permission issue or an exist cmake issue, please rebuild pcl again.
Thanks.

@sambeebe ,Thanks for posting this issue. Please reopen this issue if it still be a problem for you.


Terminals sometimes need (Ctrl + D) signal to do stuff

Sometimes, when I have a command/server running on a terminal, the process seams stuck or frozen and I have to manually send (Ctrl + D signal [aka EOF]) to let the process continue.
It's really annoying cause for my case, I'm developing a Rails application, I've a Redis Server, a Sidekiq Server And my Rails Server running aside each other, and sometimes, the issue happens and I need to manually send the signal to the terminal where the Server got frozen.
I can confirm that this issue also happened to me for the following case:

Install a package using apt-get, freeze during the install and need Ctrl+D signal to unfreeze

This issue seems to happen when the running command/server/process needs to use the output, and somehow it can't write on the output at a specific time and freeze (it's not really freezing but 'WAITING').
Everytime I press (Ctrl+D) when the issue happens, it does the trick, but it's so annoying cause you can't know if a running process is 'Waiting', you need to 'have a problem' doing stuff to think like 'Why my browser is so slow to load my web app' -> 'Oh damn, I need to Ctrl+D my server cause it was waiting from my Ctrl+D to load the views of my web application'.
I don't really know how to manually produce the bug, but it happens to me really often.
If anyone already have the same issue, is it a BashOnWindows issue or Can you give more infos about this issue ?
Thank's in advance guys.

I'm moderately sure this is just a behavior of command prompt. If you click inside the window, it will pause.
Hitting enter would also cause it to continue.

If the title starts with Select , then program output is blocked by selection and you can hit ESC to cancel it. If this is what you are hitting and it bothers you, you could disable Quick Edit in the app menu (the program icon in the title bar) -> Properties / Defaults.

I've had the terminal appear to freeze as well, but it seems like any keystroke will make it continue

I'm pretty sure @HorizonShadow @simonbuchan and @shatteredsword  are all right here. It's not Ctrl+D particularly that's fixing it, it's the fact that the console is in Select mode, which pauses the output.

Thank you for your replies. As the issue is 'randomly' occurring, I can't say if disabling the 'Quick Edit mode' does the trick. Furthermore I need to keep it enabled cause I really often use Copy & Paste between Windows and BashOnWindows.
One of my work mates seems to have the same issue randomly as well (with 'Quick Edit mode' always enabled by default too).
There must be something that 'freeze' output intentionally, but I didn't figure out yet what it is.
It can't be really 'RANDOM'.
I'm using Windows Desktops and I am used to have 4 terminals on the 3rd Desktop, and it seems (I can't really confirm) that the terminal which freeze is the one to be focused on the Desktop which it belongs.

It just happened right now, and as @simonbuchan said, there was 'Select' in the title. So it's not an issue, it's the select feature (avalaible with Quick Edit mode enabled).
I didn't notice that I was clicking on a terminal who already had the focus, it automatically selected a character in the terminal, causing the 'Pause' action of the terminal.
Thank for your replies, help, and time, I close the thread.


PDI fails to build with hipcc

@tpadioleau identified an issue with hipcc 5.7:
/lus/work/CT5/cin4469/tpadioleau/nova-hdf5/vendor/pdi/pdi/src/data_descriptor_impl.cxx:157:6: error: no matching constructor for initialization of 'Ref' (aka 'Ref_any<false, false>')
        Ref r{data, &free, m_type->evaluate(m_context), read, write};
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/lus/work/CT5/cin4469/tpadioleau/nova-hdf5/vendor/pdi/pdi/include/pdi/ref_any.h:304:2: note: candidate constructor not viable: no overload of 'free' matching 'std::function<void (void *)>' for 2nd argument
        Ref_any(void* data, std::function<void(void*)> freefunc, Datatype_sptr type, bool readable, bool writable)
        ^
/lus/work/CT5/cin4469/tpadioleau/nova-hdf5/vendor/pdi/pdi/include/pdi/ref_any.h:263:2: note: candidate constructor not viable: requires single argument 'other', but 5 arguments were provided
        Ref_any(const Ref_any& other) noexcept
        ^
/lus/work/CT5/cin4469/tpadioleau/nova-hdf5/vendor/pdi/pdi/include/pdi/ref_any.h:276:2: note: candidate constructor template not viable: requires single argument 'other', but 5 arguments were provided
        Ref_any(const Ref_any<OR, OW>& other) noexcept
        ^
/lus/work/CT5/cin4469/tpadioleau/nova-hdf5/vendor/pdi/pdi/include/pdi/ref_any.h:285:2: note: candidate constructor not viable: requires single argument 'other', but 5 arguments were provided
        Ref_any(Ref_any&& other) noexcept
        ^
/lus/work/CT5/cin4469/tpadioleau/nova-hdf5/vendor/pdi/pdi/include/pdi/ref_any.h:255:2: note: candidate constructor not viable: requires 0 arguments, but 5 were provided
        Ref_any() = default;
        ^

access to the free function should be qualified:

&std::free
static_cast<void(*)(void*)>(&::std::free)
static_cast<void(*)(void*)>(&::free)

for example.

Maybe check with more recent compilers.

We already test GCC 14 & Clang 18

I meant recent gpu compilers. This problem may have already been fixed

Ah, indeed, but on PDI side, we might need to expand the list of compilers we support beyond just GCC & Clang. For example, nvhpc, hipcc, dpc++ come to mind.

Ah, indeed, but on PDI side, we might need to expand the list of compilers we support beyond just GCC & Clang. For example, nvhpc, hipcc, icpx, dpc++ come to mind.

That is a lot!


doc: Appsmith helm with tls

Documentation to install tls on helm installations.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@sum35h - As per our discussion, I've made the changes. @sharat87 - It's ready for review.


Refactor to minimize code duplication

Much of the code for the API services and PrivateKey functionality was being duplicated. This means if a developer wanted to make an adjustment to the get_balance() function, they must also make the same changes to get_balance_testnet() and get_balance_regtest() functions as well. This has been simplified to get_balance(network=network) now instead.
This PR refactors as much of that code as I could in order to minimize duplication.
Additionally I added environmental variable checks to the services.py file so that developers can use their own custom endpoints instead of only rest.bitcoin.com and api.bitcore.io.

Very cool change but this one will take a while to go over.

We should be enforcing this with Travis (black --check .), but in the meanwhile can you format this with black?

We should be enforcing this with Travis (black --check .), but in the meanwhile can you format this with black?

Done, and done. d53f2e2

This is looking good! It does have some conflicts. Let's get #85 merged in, then rebase and do one more review.

Rebased on master to resolve the merge conflicts.

I'll need to review this. Thank you!

The file bitcash/network/fees.py was removed but this PR is adding it back. You might want to merge master into your branch.

Running black makes it very hard to review 😅. I am merging this into a refactor branch so that I can fix the bitcash/network/fees.py file issue.


crash

logs
what should I do

Based off the log, I'd recommend trying the 1.1.1-1.20.4 version on 1.20.4, perhaps something with the 1.20.1 version doesn't work that I was unaware of.


Feature/tng 1347 reduce proxy size logger

Split Logger from Chalk.
Reduces Client Bundle Size another 20KB to 26KB total

Taken the easy route and recreated the PR from master


unstable issue (bug) with "A+.Menu" error while indexing

stacktrace: https://apluslms.slack.com/archives/CSDV9CA31/p1587730568005900
related to: https://github.com/Aalto-LeTech/intellij-plugin/issues/133
probably related to: https://github.com/Aalto-LeTech/intellij-plugin/issues/129

closing for now as @OlliKiljunen could not reproduce the bug anymore


JSDoc errors

Describe the bug
Running npm run docs gives an error for generating certain types, namely userLIstObject.
To Reproduce
Steps to reproduce the behavior:

run npm run docs
error appears on terminal

Expected behavior
JSDoc is generated without errors

Was able to clear one error for session-core by correcting the typing from Array[userListObject] either userListObject[] or Array.
Array feels more intuitive, but userListObject[] appears cleaner. Might use userListObject[] for the fix.

Fixed issue by adding a dedicated types.d.ts file to assist typedefs.js in typing. Namely, I've added a type for useState:
useState = [T, React.Dispatch]
This will take in the state for T and the setState dispatch function for T

Issue resolved as of PR #100. Closing issue.


remove deprecated asset manager

The above screenshot informs that the web asset manager must be updated.

Closing this in favor of #490


Cannnot Index string with string "lastreportedAt"

Thanks for reporting this. At what point do you see this error? Can you post a screenshot?

i also get these errors too
any help on this ?

i also get these errors too
any help on this ?

Can you send me your inputcsv.txt file? I'd like to confirm that all is well with the setup file. Thanks.

i read how to set it up on
https://www.admiralsyn-ackbar.com/abuseip-bulk-check-script/
I got it working in the end
in the input.csv the format was "<IP_ADDRESS>"
but i removed the "" and just have <IP_ADDRESS> and it worked ok
also i tried it with just a plan txt file with out the "" and it worked ok to

Hello! I am running into the same issue as Sajuwithgithub, but am running into jq: error (at <stdin>:0): Cannot index array with string "lastReportedAt". I have formatted the input file in the same manner as the previous attempts and it is only with a recent list of IPs that it started hitting me with this error. To see if it was the file, I went back and ran a previous list that I had success with only to be greeted with the same error. None of the files contain quotations and trying them as plain txt files did not work. Seems to be mainly having an issue with the array on line 314, as it will check the IPs against AbuseIPDB but will not output them to the target csv.

Hello! I am running into the same issue as Sajuwithgithub, but am running into jq: error (at <stdin>:0): Cannot index array with string "lastReportedAt". I have formatted the input file in the same manner as the previous attempts and it is only with a recent list of IPs that it started hitting me with this error. To see if it was the file, I went back and ran a previous list that I had success with only to be greeted with the same error. None of the files contain quotations and trying them as plain txt files did not work. Seems to be mainly having an issue with the array on line 314, as it will check the IPs against AbuseIPDB but will not output them to the target csv.

Hi Bribber, can you send me your input.txt and IP CSV list? I can be reached at<EMAIL_ADDRESS>Thanks!


compose setup: avoid locks caused by our thin configuration

Switch to a clustered and threaded implementation of Puma to solve the deadlock issues described by our users using the docker-compose based setup.

To @wangchunyang, monitor this issue


Updating 2019 Pacifica non-hybrid fingerprint

I missed about 5 messages when doing the first fingerprint which caused LKAS faults. This new one works correctly for me.

Thanks for the PR!


push container through push step

@bfosberry when running this container locally with --push=true and --tag=master I get the following:
Image Push error for image gcr.io/codeship-production/google-deployment-example:latest, Post https://gcr.io/v2/codeship-production/google-deployment-example/blobs/uploads/: token auth attempt for registry: https://gcr.io/v2/token?scope=repository%3Acodeship-production%2Fgoogle-deployment-example%3Apush%2Cpull&service=gcr.io request failed with status: 403 Forbidden

The variables are set up correctly though, so it should be working fine from everything I saw

@bfosberry this works now. Could you review?

Lgtm, but I dont think you need 'add_docker' anymore,can you verify?

@bfosberry works without add_docker. I'll merge then


Feature Request: Add on page load corredor script triggers

Is your feature request related to a problem? Please describe.
I want

to use keyboard shortcuts to save the page
saving to happen automatically every second
pages to be in always edit mode. So the heavy editing workflows doesn't require pressing edit all the time

Describe the solution you'd like
A way to affect the DOM without users interacting. IE on-page-load events that can trigger client side scripts
Describe alternatives you've considered

Force the users to press a button that initiates a client-side script
Ask users to download monkey scripts to press a client-side script button

point can be achieved by adding those listeners.

point can be achieved by providing some configuration to the record page.

point however would need what you're suggesting

@Fajfa , what do you mean by adding listeners?
Client-side corredor scripts require user interactiont to be executed, so they'd need to press a button to launch the script everytime they load a page (counterproductive to the keyboard shortcut feature which should be used to save time)

Is this something difficult to add? Would it be approachable to someone who hasn't yet contributed to the frontend of the project?

It does involve extending the server, lib/js, and compose sections. If you wish you can give it a try and I'll take a look.
In general useful keyboard shortcut suggestions are appreciated

OK,
I do have some other things I want to contribute first (specifically optimization in RBAC querying), but if after that there's been no progress here, I'll consider this as a next issue.

Any news on this issue ?


Challenge http://www.freecodecamp.com/challenges/waypoint-headline-with-the-h2-element has an issue

I don't know if "bugs" is where typos go, but.... the checklist on this page has:
Create an h2 elements.
There should not be an s at the end.
(Also: This report a bug button took me to Github, but as an FCC student at HMTL level I don't yet have a Github account or Github orientation.)

Thanks for the heads up. This is already fixed in a pending push to production. Keep em coming though.
Regarding the github account stuff, it's true users may not have one yet but it's a very easy signup process.

Nothing is easy if you are new, and your teachers give you no warning or
explanation...
On Tue, May 26, 2015 at 10:10 AM, Nathan<EMAIL_ADDRESS>wrote:

Thanks for the heads up. This is already fixed in a pending push to
production. Keep em coming though.
Regarding the github account stuff, it's true users may not have one yet
but it's a very easy signup process.
—
Reply to this email directly or view it on GitHub
https://github.com/FreeCodeCamp/freecodecamp/issues/541#issuecomment-105605564
.

That's a good point. We'll make sure to add a "Sign up for GitHub" waypoint in the "Intro to FreeCodeCamp" section. Thanks!


added new file

css and js file using trigonometry

rename pr title

Please create a demo folder inside your project and add a working demo of your project named demo.gif

done


🐛  Use multiple tenant Requestmaps  breaks app startup

Detail App and reproduce steps to be uploaded..
Thanks for reporting an issue for grails-spring-security-core. Please review the task list below before submitting the
issue.

WARNING: Your issue report may be closed if the issue report is incomplete and does not include an example. Make sure the below tasks are completed!

NOTE: If you are unsure about something and the issue is more of a question, a better place to ask questions is on Stack Overflow (http://stackoverflow.com/tags/grails) or Slack (http://slack-signup.grails.org). DO NOT use the issue tracker to ask questions.

Task List

[ ] Steps to reproduce provided
[ ] Stacktrace (if present) provided
[ ] Example that reproduces the problem uploaded to Github
[ ] Full description of the issue provided (see below)

Steps to Reproduce

TODO
TODO
TODO

Expected Behaviour
Tell us what should happen
Actual Behaviour
Tell us what happens instead
Environment Information

Operating System: TODO
GORM Version: TODO
Grails Version (if using Grails): TODO
JDK Version: TODO

Example Application

TODO: link to Github repository with example that reproduces the issue

I have implemented a custom RequestmapFilterInvocationDefinition and defined a bean for it.
If anyone would like to know the details, can comment below.
Thanks.


snippet --command appears broken

Describe the bug
Starting with aef0e46ecc85cbc6b4fd073659c2963ccd80d694, it appears that zinit snippet --command is broken.
From my .zshrc:
zinit ice svn pick="imgcat"
zinit snippet --command \
    https://github.com/gnachman/iterm2-website/trunk/source/utilities/

To Reproduce
See above .zshrc.
As of aef0e46ecc85cbc6b4fd073659c2963ccd80d694, when I load a new shell I get:
Setting up snippet: opt_-x,--command --command
ERROR: The source file opt_-x,--command --command doesn't exist.
Copying opt_-x,--command --command...
cp: cannot stat 'opt_-x,--command --command': No such file or directory
ERROR: The file copying has been unsuccessful.

$ which imgcat
imgcat not found

Expected behavior
If I reset to 9041ba51, I get:
$ which imgcat
/home/<me>/.zinit/snippets/https--github.com--gnachman--iterm2-website--trunk--source/utilities/imgcat

Screenshots
If applicable, add screenshots to help explain your problem.
Versions:
$ echo $ZSH_VERSION
5.8
$ uname -a
Linux heinlein 5.4.85-gentoo-x86_64 #1 SMP PREEMPT Tue Dec 29 14:43:49 CST 2020 x86_64 AMD Ryzen 9 3900X 12-Core Processor AuthenticAMD GNU/Linux

Additional context

just encountered this

just encountered this


Allow users to pass custom Ansible vars file

Closes #7, closes #20, closes #32
Relies on Bypass BITOPS_ extra ENV vars to Docker run #48 which needs to be merged first.
Overwrites #32 which went a bit far in terms of complexity.
In general, we can just rely on built-in BITOPS_ANSIBLE_EXTRA_VARS ENV https://github.com/bitops-plugins/ansible#extra-vars implementation for user to specify the file with the Ansible vars. That'll provide the exactctly needed functionality for overriding the st2.conf and other advanced configuration.
The implementation could be simple as that, getting the best of BitOps VARs and the framework.
~Fix  BitOps 🐛 bug CLI args to the plugins are not passed #360.~

LGTM 👍


Invalid markdown instructions

Accessing tutorial catalogue at https://ide.skillsnetwork.site/open-liberty-tutorial-catalogue I try to open a module and receive the following error in the Open Liberty Masterclass Modules
You tried to start a QuickLab with invalid markdown instructions. Please contact the QuickLab author to let them know their QuickLab is broken.

Encountered on Module 1 (Build) and Module 2 (Dev Mode) and Module 3 (Application API), have not checked other modules or categories yet.
Accessed in Firefox on Windows 10

@AustinSeto the links you have posted, where did you get them from? We have never seen them before. All the masterclasses can be found here

@AustinSeto the links you have posted, where did you get them from? We have never seen them before. All the masterclasses can be found here

This issue has been found in one of the masterclasses. All the masterclasses should now be fully functional. Closing issue.

This issue has been found in one of the masterclasses. All the masterclasses should now be fully functional. Closing issue.


[Candidate 1v1 Planet Coyon V1] Clickable structures on the left side can be moved into

Issue Description
Clickable structures on the left side can be moved into.
Expected behavior
Units cannot be moved into structures that can also be selected.
Screenshots

Fixed with https://github.com/xezon/GeneralsRankedMaps/commit/8a6554e6c84b9d936680f45c5743e750f9c7a4a5


http: allow decoding/encoding a header only request/response

This adds a new return value to encode-/decodeHeaders that indicates that
filter iteration should immediately stop, dropping any pending data/trailers.
This results in a header only request/response, which can be used to
terminate stream processing early, eg in case of invalid
request or response.
Signed-off-by: Snow Pettersen<EMAIL_ADDRESS>Description:
Risk Level: Medium due to HCM modifications
Testing: Unit test ensuring the correct encoding happens and that further data is dropped.
Docs Changes: n/a
Release Notes: n/a
Fixes #4800

Marking as waiting.
/wait

I'd definitely like to see end to end tests, with filters doing this both on the request path and response path if we decide to support both.

+1. In general this is a good opportunity to add multi-filter integration tests for HTTP which should be easy with the new fake filter stuff. See also my related comments here: https://github.com/envoyproxy/envoy/pull/4889. cc @qiannawang. I think we could add tests that cover that PR also pretty easily in the same effort.

I'd specifically like to make sure we correctly ending the streams when we're not draining the body, closing up HTTP/1 connections etc. Though while this strikes me as a reasonable thing to do on the response path (to your point on gRPC translation) it's somewhat confusing on the request path. If we're ignoring a POST body, we either close the stream (bad) or should maybe stop reading, or drain? Maybe it should be a response-only return - while it's unfortunate to lose parallel handling on encode/decode I also don't know that it's worth the complexity if we don't think it's necessary.

This is my concern also, and I've been looking at the code this morning to make myself feel better (will comment on that separately). I think we are OK but integration tests would make me feel better. My general feeling is that even though it might be weird for a request/POST, I don't see any real difference between that and a response with a large body, so IMO we should support the symmetry.

Yeah, I was planning on a second look around timers and timing metrics once e2e tests happened.
The one concern I have about large requests that doesn't translate to large responses, is around request lifetime.  On the response path barring a really weird buffering/delay filter we're about to kill the stream pretty much immediately but on the request path we've got all the backend think time to be reading bytes from the client and black-holding them and doing unreported work makes me leery.  I was tempted to ask that we readDisable the stream but that creates a bunch of other unfortunate conrner cases which think are more likely to cause problems than those black-holed bytes :-/
I almost want to retcon my suggestion of an extra filter response code, fix your TODO About sendLocalReply not going through filters and say that's a more optimal way to handle this.

I almost want to retcon my suggestion of an extra filter response code, fix your TODO About sendLocalReply not going through filters and say that's a more optimal way to handle this.

I don't think that fully covers this case though? We are genuinely trying to change a request/response into a header only request/response? This seems like a reasonable thing to do?

I was tempted to ask that we readDisable the stream but that creates a bunch of other unfortunate conrner cases which think are more likely to cause problems than those black-holed bytes :-/

Yeah agreed. IMO if we do this feature we should black hole.

#4800 specifically says the issue is converting responses so sendLocalReply wouldn't do everything this PR does but it would handle the only use case we have in the open issue

#4800 specifically says the issue is converting responses so sendLocalReply wouldn't do everything this PR does but it would handle the only use case we have in the open issue

I see, got it. In general I think this is a cleaner / more general solution so my vote would be to keep going but I don't feel that strongly about it.

Happy to keep iterating on this and adding adequate integration tests. I'll probably spend some time on this tomorrow.

TODO About sendLocalReply not going through filters

What TODO is this? Would this allow sending a local reply during encoding? I recall trying that at one point and running into some ASSERTs.

Oh this one - someone on my team stumbled on it the other day:
https://github.com/envoyproxy/envoy/blob/master/source/common/http/conn_manager_impl.cc#L993
It might make sense to go this route if we were going for response-only conversions.  Sounds like Matt prefers the bidi solution and I'm good either way so feel free to stick with what you have :-)

Hmm for some reason there's a test failure in one of the integration tests on ipv6 only, will dig into it.


Allow for No organisation

We've a great deal of data in Wikidata (10,000's of items at a guess) which are now in PD - CC0.
Allow a dataset to be added for either No organisation (a fake org of 'None' ) or add w WikiData organisation to which to attribute the datasets (as SPARQL end points for queries to retrieve the data in question.

The organisation field isn't mandatory so we should be able to add datasets without having an organisation tied to it.
We'll have to make some tweaks to JKAN though as the filter option for no org shows up as a blank entry and doesn't work when you click on it.

I would suggest a dummy organisation in this case, i.e. an organisation entry named "no organisation", but I think in the case given above, a "WikiData" organisation may be better


[feature] Added isWeekend support (#5134)

For #5134

Coverage increased (+0.03%) to 88.44% when pulling 1468be2bd51a339c18a4e1a266458fcc814dce91 on raghavmac:develop into 13a61b285c095bda7ea8e33156090ea5ccfeaef1 on moment:develop.

Thank you @ashsearle for the support!
@raghavmac yeah, basically this is not a simple issue. The only sane way to support this is for each locale to define which days it considers weekend. I won't be surprised if there are non-consecutive weekends as well.
So if you want to use this in your codebase you can simply "monkey patch" moment and hope it will only be used for locales where weekends are actually Sat/Sun.

@raghavmac thoughts?
It is helpful to pursue this implementation even if we decide eventually not to merge it. It helps all of us understand how to build such a feature.
If you do not think it is worth the effort, please close the PR. Otherwise, please resolve conflicts.
Thanks for your help with this library!

See https://momentjs.com/docs/#/-project-status/


Run CI jobs in gcc{5-9}-based Docker images

What's this pull request for?
Enabled CI jobs to run in gcc{5-9}-based Docker images, where all dependencies (mysql, postgresql, fcgi, mprpc, etc.) are installed.
Added environment variables ( DOCKER_REPO_USER and DOCKER_REPO_PASSWORD ) in the project setting page of this repository so that CI can download images from docker.retrieva.jp .
In addition, waf is now executed only by python3 because Python2 has ended and I don't wanna double the number of jobs.
How to test

[ ] check CI passes

IMHO: If auth and steps are same, anchor and alias may easier to understand
jobs:
  gcc5:
    docker:
      - image: docker.retrieva.jp/pficommon_ci:gcc5.2007
        auth: &auth  # <- anchor
          username: $DOCKER_REPO_USER
          password: $DOCKER_REPO_PASSWORD
    steps: &steps  # <- anchor
      - checkout
      - run:
          name: configure
          command: CPPFLAGS="-I/usr/include/postgresql" ./waf configure
      :
  gcc6:
    docker:
      - image: docker.retrieva.jp/pficommon_ci:gcc6.2007
        auth: *auth  # <- alias
    steps: *steps  # <- alias

Based on https://github.com/retrieva/pficommon/pull/207#issuecomment-664068012, auth and steps are anchored and aliased in ce06b69 .
Also, 785de3f exports C_INCLUDE_PATH , CPLUS_INCLUDE_PATH , LIBRARY_PATH and LD_LIBRARY_PATH in Dockerfile, not in CI jobs to improve reusability of anchored steps .

LGTM!!


Reduce the usage of Mockk

We had some usages of Mockk that doesn't have any sense.

Warnings

:warning:
This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.

  Generated by :no_entry_sign: dangerJS against 27ad70bbd8f7089ba7b8a4ca6caba82781b609a4


Prepare STG84 release.

Update released date in change log for STG84 public preview release

API change check
API changes are not detected in this pull request.


mapviz on ros2 iron not show the map

Hi, I've installed mapviz from binary on ros2 iron following this tutorial for navigation stack. Everything works as expected on that demo.
Now I want to use mapviz with my own robot. So I run my own robot_localization dual ekf and navsat but mapviz wont show the map. After a few warnings and some errors the map is not loaded:
[mapviz-1] [INFO] [1705970237.310865913] [mapviz]: Target frame selected: map
[mapviz-1] [INFO] [1705970237.312678528] [mapviz]: creating: mapviz_plugins/tile_map
[mapviz-1] [WARN] [1705970237.329849517] [mapviz]: [transform_manager]: No transformer from 'wgs84' to 'map'. If 'map' is a /tf frame, it may not have been broadcast recently.
[mapviz-1] [ERROR] [1705970237.329914933] [mapviz]: Error: No transform between wgs84 and map
[mapviz-1] [INFO] [1705970237.329969518] [mapviz]: Reorder displays
[mapviz-1] [INFO] [1705970237.334444731] [mapviz]: creating: mapviz_plugins/point_click_publisher
[mapviz-1] [INFO] [1705970237.410617852] [mapviz]: Publishing points to topic: clicked_point
[mapviz-1] [INFO] [1705970237.415078459] [mapviz]: Ready.
[mapviz-1] [INFO] [1705970237.424242578] [mapviz]: Reorder displays
[mapviz-1] [INFO] [1705970237.424357422] [mapviz]: Publishing points to topic: clicked_point
[mapviz-1] [INFO] [1705970237.429709922] [mapviz]: creating: mapviz_plugins/tf_frame
[mapviz-1] [INFO] [1705970237.437347095] [mapviz]: Reorder displays
[mapviz-1] [WARN] [1705970237.437629616] [mapviz]: Waiting for transform.
[mapviz-1] [INFO] [1705970237.437667247] [mapviz]: Setting target frame to to base_link
[mapviz-1] [INFO] [1705970237.438090888] [mapviz]: creating: mapviz_plugins/navsat
[mapviz-1] [INFO] [1705970237.442910620] [mapviz]: Reorder displays
[mapviz-1] [WARN] [1705970237.443256920] [mapviz]: No messages received.
[mapviz-1] [INFO] [1705970237.447384441] [mapviz]: Subscribing to /fix
[mapviz-1] [INFO] [1705970237.492977834] [mapviz]: OK
[mapviz-1] [WARN] [1705970237.496088904] [mapviz]: [transform_manager]: No transformer from '' to 'tf'. If '' is a /tf frame, it may not have been broadcast recently.
[mapviz-1] [WARN] [1705970237.496183211] [mapviz]: [transform_manager]: No transformer from '' to 'tf'. If '' is a /tf frame, it may not have been broadcast recently.
[mapviz-1] [WARN] [1705970237.608824028] [mapviz]: [transform_manager]: No transformer from '' to 'tf'. If '' is a /tf frame, it may not have been broadcast recently.
[mapviz-1] [WARN] [1705970237.644285358] [mapviz]: [transform_manager]: No transformer from '' to 'tf'. If '' is a /tf frame, it may not have been broadcast recently.
[mapviz-1] [ERROR] [1705970237.765964087] [mapviz]: [transform_manager]: Could not find a connection between 'map' and 'base_link' because they are not part of the same tree.Tf has two or more unconnected trees.
[mapviz-1] [WARN] [1705970237.768162238] [mapviz]: [transform_manager]: Failed to get tf transform ('base_link' to 'map').  Both frames exist in tf.
[mapviz-1] [ERROR] [1705970237.772587022] [mapviz]: NETWORK ERROR: Protocol "" is unknown
[mapviz-1] [WARN] [1705970237.773754987] [mapviz]: [transform_manager]: No transformer from '' to 'tf'. If '' is a /tf frame, it may not have been broadcast recently.
[mapviz-1] [INFO] [1705970237.773901773] [mapviz]: OK
[mapviz-1] [ERROR] [1705970237.962370595] [mapviz]: [transform_manager]: Could not find a connection between 'map' and 'base_link' because they are not part of the same tree.Tf has two or more unconnected trees.
[mapviz-1] [WARN] [1705970237.962675939] [mapviz]: [transform_manager]: Failed to get tf transform ('base_link' to 'map').  Both frames exist in tf.
[mapviz-1] [INFO] [1705970237.964708782] [mapviz]: API Key Set.
[mapviz-1] [INFO] [1705970237.966012186] [mapviz]: OK
[mapviz-1] [WARN] [1705970237.966397494] [mapviz]: [transform_manager]: No transformer from '' to 'tf'. If '' is a /tf frame, it may not have been broadcast recently.
[mapviz-1] [ERROR] [1705970238.125979271] [mapviz]: [transform_manager]: Could not find a connection between 'map' and 'base_link' because they are not part of the same tree.Tf has two or more unconnected trees.
[mapviz-1] [WARN] [1705970238.126305363] [mapviz]: [transform_manager]: Failed to get tf transform ('base_link' to 'map').  Both frames exist in tf.
[mapviz-1] [ERROR] [1705970238.127018689] [mapviz]: NETWORK ERROR: Protocol "" is unknown
[mapviz-1] [WARN] [1705970238.130293670] [mapviz]: [transform_manager]: No transformer from '' to 'tf'. If '' is a /tf frame, it may not have been broadcast recently.
[mapviz-1] [ERROR] [1705970238.248568235] [mapviz]: [transform_manager]: Could not find a connection between 'map' and 'base_link' because they are not part of the same tree.Tf has two or more unconnected trees.
[mapviz-1] [WARN] [1705970238.248914090] [mapviz]: [transform_manager]: Failed to get tf transform ('base_link' to 'map').  Both frames exist in tf.
[mapviz-1] [WARN] [1705970238.252063924] [mapviz]: [transform_manager]: No transformer from '' to 'tf'. If '' is a /tf frame, it may not have been broadcast recently.
[mapviz-1] [ERROR] [1705970238.260254833] [mapviz]: NETWORK ERROR: Protocol "" is unknown
[mapviz-1] [INFO] [1705970238.262219333] [mapviz]: OK
[mapviz-1] [ERROR] [1705970238.294023996] [mapviz]: NETWORK ERROR: Protocol "" is unknown
[mapviz-1] [ERROR] [1705970238.303270983] [mapviz]: NETWORK ERROR: Protocol "" is unknown

I'm not sure why using nav2 demo it's working ok, but with my robot doesn't.

I managed to make mapviz show the map using the changes suggested on this post to mapviz.launch.py
               Node(
              package="swri_transform_util",
              executable="initialize_origin.py",
              name="initialize_origin",
              parameters=[
                  {"local_xy_frame": "slc"},
                  {"local_xy_origin": "slc"},
                  {
                      "local_xy_origins": [
                          40.76935585340519,
                          -111.89107193491502,
                          0.0,
                          0.0,
                      ]
                  },
                  {"use_sim_time": True},
              ],
          )

I change local_xy_origin with the GPS coordinates of my location and the map shows up.


lombok plugin not working, @data getter setter constructor annotations didn't generate code, and compilation error occurs

Short description
lombok plugin seems not working totally. it couldn't recognize Data, Getter, Setter or constructor annotation. No setter getter are generated and source codes are full of red lines of "couldn't resolve method" issues. Compilation errors occur when building project in IDE.
Version information

IDEA Version:
IntelliJ IDEA 2020.1.4 (Ultimate Edition)
Build #IU-201.8743.12, built on July 21, 2020

JDK Version: zulu 1.8.0_202

OS Type & Version: Windows

Lombok Plugin Version: 0.30-2020.1  (even the latest 2020.2-EAP not work)

Lombok Dependency Version: 1.18.8

Details
getter mothod couldn't be resolved:

Data annotation is used and well defined for the object:

lombok jar is showing in the project dependency, and I have checked the local gradle cache folder, can see the jar there

I have tried unstall and reinstall lombok plugin, reload Gradle project, refresh Gradle dependencies, invalidate cache and restart IDE, check out the repo again and create a new project, install another version of IntelliJ IDEA. Both couldn't resolve the issue, please help!

Seems related to https://github.com/mplushnikov/lombok-intellij-plugin/issues/829

Please ensure that Annotation Processing is Enabled in Build, Execution, Deployment >  Compiler > Annotation Processors:

Please ensure that Annotation Processing is Enabled in Build, Execution, Deployment >  Compiler > Annotation Processors:

Hi unamanic, Annotaion processing is always enabled.

Do you have any other issues present? It's possible the annotation process is not running due to other build errors.

Do you have any other issues present? It's possible the annotation process is not running due to other build errors.

Seems don't have other issues. This one is a major blocker and I can't proceed to other operations in IDE

Hi unamanic, Annotaion processing is always enabled.

This is not the default, I usually have to turn it on for projects that use lombok.
Are you able to build successfully directly with gradle?

Hi unamanic, Annotaion processing is always enabled.

This is not the default, I usually have to turn it on for projects that use lombok.
Are you able to build successfully directly with gradle?
Can you post your build.gradle?

Yes, if I run Gradle command outside of IDE, it can be successfully built.

I had the same issue and it was related to #829. Updating IDEA to 2020.2.1RC helped me.


enable static audit logging trough upgrade is not working

What happened:
In our case we want to enable the static Kubernetes Audit Logging.

Download the default audit logging policy file form the Kubernetes homepage:

wget https://raw.githubusercontent.com/kubernetes/website/master/content/en/examples/audit/audit-policy.yaml
curl audit.policy.yaml

Configure your config.yaml and add the following content:

apiVersion: kubeone.io/v1alpha1
kind: KubeOneCluster
name: tk2
versions:
  kubernetes: '1.15.5'
cloudProvider:
  name: 'gce'
features:
  staticAuditLog:
    enable: true
    config:
      # PolicyFilePath is a path on local file system to the audit policy manifest
      # which defines what events should be recorded and what data they should include.
      # PolicyFilePath is a required field.
      # More info: https://kubernetes.io/docs/tasks/debug-application-cluster/audit/#audit-policy
      policyFilePath: "audit-policy.yaml"
      # LogPath is path on control plane instances where audit log files are stored
      logPath: "/var/log/kubernetes/audit.log"
      # LogMaxAge is maximum number of days to retain old audit log files
      logMaxAge: 30
      # LogMaxBackup is maximum number of audit log files to retain
      logMaxBackup: 3
      # LogMaxSize is maximum size in megabytes of audit log file before it gets rotated
      logMaxSize: 100

Execute the change with upgrade --force what enables features changes

kubeone upgrade config.yaml -t tf.json --force

The upgrade fails:
INFO[15:12:58 CEST] Labeling leader control plane…                node=<IP_ADDRESS>
INFO[15:12:58 CEST] Upgrading Kubernetes binaries on leader control plane…  node=<IP_ADDRESS>
INFO[15:13:04 CEST] Waiting 1m0s seconds to ensure kubelet is up…  node=<IP_ADDRESS>
INFO[15:14:04 CEST] Generating kubeadm config …                   node=<IP_ADDRESS>
INFO[15:14:04 CEST] Uploading kubeadm config to leader control plane node…  node=<IP_ADDRESS>
INFO[15:14:05 CEST] Running 'kubeadm upgrade' on leader control plane node…  node=<IP_ADDRESS>
WARN[15:19:14 CEST] Task failed…
Error: unable to upgrade leader control plane: failed to run 'kubeadm upgrade' on leader control plane: + sudo kubeadm upgrade apply --config=./kubeone/cfg/master_0.yaml -y 1.15.5
[upgrade/apply] FATAL: couldn't upgrade control plane. kubeadm has tried to recover everything into the earlier state. Errors faced: timed out waiting for the condition: failed to exec command: export "PATH=$PATH:/sbin:/usr/local/bin:/opt/bin"

set -xeu pipefail

sudo kubeadm upgrade apply \
	--config=./kubeone/cfg/master_0.yaml \
	-y 1.15.5
: Process exited with status 1
unable to upgrade leader control plane: failed to run 'kubeadm upgrade' on leader control plane: + sudo kubeadm upgrade apply --config=./kubeone/cfg/master_0.yaml -y 1.15.5
[upgrade/apply] FATAL: couldn't upgrade control plane. kubeadm has tried to recover everything into the earlier state. Errors faced: timed out waiting for the condition: failed to exec command: export "PATH=$PATH:/sbin:/usr/local/bin:/opt/bin"

set -xeu pipefail

sudo kubeadm upgrade apply \
	--config=./kubeone/cfg/master_0.yaml \
	-y 1.15.5
: Process exited with status 1

It seems like, the file didn't get copied to the master and the configured /root/kubeone/cfg/master_0.yaml contains a wrong system path on the master. I assume this is the reason why kubeadm fails

apiServer:
  certSANs:
  - <IP_ADDRESS>
  extraArgs:
    audit-log-maxage: "30"
    audit-log-maxbackup: "3"
    audit-log-maxsize: "100"
    audit-log-path: /var/log/kubernetes/audit.log
    audit-policy-file: /etc/kubernetes/audit/policy.yaml
    cloud-config: /etc/kubernetes/cloud-config
    cloud-provider: gce

What is the expected behavior:
K8s control plan get configured with the static audit logging
How to reproduce the issue:
see above
Anything else we need to know?
Information about the environment:
KubeOne version (kubeone version):
{
  "kubeone": {
    "major": "0",
    "minor": "10",
    "gitVersion": "v0.10.0-10-ge1d18c3",
    "gitCommit": "e1d18c35f27b1ee576cc55a1f0e85a9363feaadf",
    "gitTreeState": "",
    "buildDate": "2019-10-20T14:05:09+02:00",
    "goVersion": "go1.12.5",
    "compiler": "gc",
    "platform": "linux/amd64"
  },
  "machine_controller": {
    "major": "1",
    "minor": "5",
    "gitVersion": "v1.5.8",
    "gitCommit": "",
    "gitTreeState": "",
    "buildDate": "",
    "goVersion": "",
    "compiler": "",
    "platform": "linux/amd64"
  }
}

Operating system: linux
Provider you're deploying cluster on: gce
Operating system you're deploying on: Ubuntu

/assign
/priority important-soon
I'll try to fix this in the morning.

Can't reproduce, maybe there was some network glitch or whatever. Now it works.


Shorter fisher-search output?

Imo it'd be much cooler if the search output took a single line per package in format pkgname description. Ideally, table-aligned. I'd love to see smth like fisher info <pkg> to see more information about a particular package (such as author, last update time, deps, whatever).
$ fisher search
fishtape      test tool
shark         chart tool
scaffold      create plugin generator boilerplate fish fisherman
get           stty read line ui cli key character
submit        fisherman contrib index plugin
bobthefish    theme powerline awesome

@tucnak
What about
``
fisher search --name --info

The output is extremely customizable, if you have a second and go through [`fisher help search`](https://github.com/fisherman/fisherman/blob/master/man/man1/fisher-search.md), just type that at the command line.

Now, to get exactly what you want right now, you can always:

Try, `fisher install <TAB>`

Which IMO is far more powerful.

Wow, it's wicked! I love what you've done there!

Great! So, let's close this?


Remove paginator from history page

Closes #2875

Ah, okay. I have removed the pagenator from the history module. Missed that.


fix: issue#246

https://github.com/import-js/eslint-import-resolver-typescript/issues/246

@ken1987 It seems there is a regression after this PR.


fix: analytics vars and events in all the blocks

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #122
Fix #127
Fix #163
Fix #218
Fix #233
Fix #234
Fix #235
Fix #236
Fix #237
Fix #238
Fix #242
Test URLs:

Before: https://main--accenture-newsroom--hlxsites.hlx.live/
After: https://analytics-fixes-v2--accenture-newsroom--hlxsites.hlx.live/
After: https://analytics-fixes-v2--accenture-newsroom--hlxsites.hlx.live/news/2023/accenture-completes-acquisition-of-anser-advisory
After: https://analytics-fixes-v2--accenture-newsroom--hlxsites.hlx.live/subjects/digital

Unfortunately PSI won't run on .page or .live urls anymore because the preview site is behind authentication. we would need to use CDN but that would only point to main branch which renders the PSI useless at this point.


My Artifacts displays each artifact revision as a distinct artifact record (multiple entries for same artifact record)

Describe the bug
From My Artifacts, select Dsroche/Oblivisync and click READ MORE.
I was editing and canceling in a loop and at some point, the system didn't cancel the edit and the DISCARD button didn't display. At this point, I clicked on My Artifacts again and now that object is in my list twice. I suspect there's something about the state that didn't get closed correctly because I never hit the SAVE button while in edit mode. I think.
This is in hub-dev.

Actually, now I am seeing that all edited artifacts are showing up in my artifacts list twice. Now I suspect the issue is actually that the artifacts list is not filtering on versions and is displaying every revision as a distinct record.

I have confirmed that My Artifacts displays an artifact record for each revision of the artifact record.

We do need to verify that if a user uses the back arrow and never saves the edited record, that the system isn't left in some weird state. I don't know what the DISCARD button actually does, so does not pushing it leave things in lala state?


Chore: Add default title

This PR addresses #11 by adding a default title.
Bare with me while I start getting my feet wet. I'm unclear if this is the right solution, but wanted to get something out there to start a conversation. :)
cc: @tylersticka @erikjung

I haven't tried locally, but this looks fine to me! Not sure how else we'd do it.

This should probably be a value that gets delivered to the template context from the builder, but this is a fine solution until that happens. 👍


Add troubleshooting guide for when U-Boot has known broken UEFI support.

Signed-off-by: Kristian Amlie<EMAIL_ADDRESS>

This goes together with https://github.com/mendersoftware/meta-mender/pull/931.


Blog RSS and Atom feeds not found

Description
The RSS and Atom feed URLs are now returning 404 errors. I have just received this as a notification from Feedrabbit, so it's likely broken in the past 24 hours as it was working before that.
The URLs used to be:

http://reactnative.dev/blog/feed.xml
http://reactnative.dev/blog/atom.xml

Documentation version
0.63

Hi @matt-oakes, thank you for reporting that!
I have a PR ready to be merged, but just want to leave note that RSS feed will be now available under URL - http://reactnative.dev/blog/rss.xml - and the Atom feed link would not change. 🙂


Removes non-threadsafe, non-scalable memoization

See #6

Ha, past me wasn't that smart ;)
Thanks for fixing it!


feat: implement export Stronghold with Android Sharesheet

Summary
This PR modifies only on Android the current filesystem export action by using Sharesheet with the aim to simplify the Stronghold backup flow. Allowing to use quick share classic actions, nearby device share with bluetooth, wifi, usb cable, or uploading to Google Drive app or any app desired to transfer the file to an external device.
The same Sharesheet could be used to export transaction history or any file desired. Still we've to implement it, but it's way simpler.
Tested with Android 7, 8, 9, 10, 11, 12.
Changelog
Closes #2473
Relevant Issues

Please list any related issues using development keywords.

...
Testing
Platforms

Please select any platforms where your changes have been tested.

Desktop

[ ] MacOS
[ ] Linux
[ ] Windows

Mobile

[ ] iOS
[ ] Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...
Checklist

Please tick all of the following boxes that are relevant to your changes.

[ ] I have followed the contribution guidelines for this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or modified tests that prove my changes work as intended
[ ] I have verified that new and existing unit tests pass locally with my changes
[ ] I have verified that my latest changes pass CI workflows for testing and linting
[ ] I have made corresponding changes to the documentation

It would be nice if we could have a callback to detect if the file was indeed exported somehow, atm if I close the sharesheet and share nothing, firefly still detects it as a success. Will add a task for this.

Added to #4198

great thanks! 😊 I'll add a new task for that


graphql-ws support is there in this library?

According to the apollo documentation, subscriptions-transport-ws is going to deprecated in favour of graphql-ws and i tried using the WebSocketLink for the graphql-ws but the server is giving me error that i am trying to call my api from a client who is using subscriptions-transport-ws.
Please can anybody help me with this.
Thanks
Here is the link for the documentation for the same thing:
https://www.apollographql.com/docs/apollo-server/data/subscriptions/

We are in beta stage https://github.com/zino-hofmann/graphql-flutter/blob/main/packages/graphql/CHANGELOG.md#new-feature
feedback are welcome!


fixed animation bug when reload dates

additional fix to #136

sorry, my mistake - "attempt to add identical layout attributes to list of on screen attributes to animated"

So, basically youre saying it is adding the same indexPath twice? :/

i think it's not; seems it does not handle situations like
let date = NSDate()
calendarView.reloadDate([date, date])

I see. So basically since same date is being reloaded twice, It therefore adds the same indexPath twice.
And since the same index path is added twice, then the animation errors happens. I get it now.
Ok here's what the fix should be.

This fix is for the swift3 version. Do you know how to convert it to swift2?
If yes, then do the conversion, and I will merge the code.
If not, then I will do the merge in the morning.

i'm not sure how to convert it
better do it in the morning

Ok. Scratch that.
Change the code inside the function to this
        var paths = [IndexPath]()
        for date in dates {
            let aPath = pathsFromDates([date])

            if aPath.count > 0 && !paths.contains(aPath[0]) {
                paths.append(aPath[0])
                let cellState = cellStateFromIndexPath(aPath[0])
                if let validCounterPartCell = indexPathOfdateCellCounterPart(date, indexPath: aPath[0], dateOwner: cellState.dateBelongsTo) {
                    paths.append(validCounterPartCell)
                }
            }
        }
        batchReloadIndexPaths(paths)

If its fixed then create a pull request.

I'm off to sleep. Will read your results in the morning.

its fixed, thanks!


Allow multiplication of SparsePauliOp and ParameterExpression

Summary
Fix issue #10185 relying on the already implemented and tested method SparsePauliOp._multiply.

Thank you @woodsp-ibm for the suggestions. Should I write a separate testing function for this or add it to the current TestSparsePauliOpMethods.test_mul method in test_sparse_pauli_op.py?

If adding new parameterexpression value(s) to the current test works out with the current code then that would be ok. It already deals with a param and having that now as value I do not know how well things would fit to the code given how you might want/need to check the outcome. If it turns out better to be a separate test, save complicating what's there, I think that's fine.

Thank you again for the feedback. I added the test and the release note.
Honestly, I don't understand why some tests are still failing (they don't look related to this).

Thank you again for the feedback. I added the tests and the release note.
Some tests are still failing but they look related to the other changes from the 'main' branch. Maybe I shouldn't have merged it to my feature branch (apologies, I'm just at the beginning of my experience as an open-source contributor).

Hi, as far as the test failure sometimes other changes affect things - in this case its failing due to a change in newly released qiskit aer - #10270 addresses this so after thats merged and your branch is updated to include it then things should be ok.

@ikkoham @woodsp-ibm Anything still missing? I updated the branch and now all the checks are successful.


Various cleanups and improvements

Ok, this is my last PR, at least for awhile! 😅 I had a hack week and decided to work on this role a bit... my ultimate goal was to get centos (yum) working with the molecule tests, but I didn't manage to get quite that far. With any luck, I'll have another PR for that soon-ish.
This PR contains a few aesthetic cleanups, but also improves the overall test coverage by testing some previously-untested features of this role.
ping @emmetog -- thanks for your reviews so far! 👍

Thanks a mill @nre-ableton !

@emmetog Thanks for the quick review!


Fix/product review include variants

1. Why is this change necessary?
Currently if the product has variants and an assigned shopping experience layout only the reviews of that variant are displayed.
2. What does this change do, exactly?
Use the loading mechanism of the ProductReviewLoader to load the reviews.
This PR is based on https://github.com/shopware/platform/pull/2387 since the widget route loads the template for the normal product page.
3. Describe each step to reproduce the issue or behaviour.
-
4. Please link to the relevant issues (if any).
https://issues.shopware.com/issues/NEXT-19689
5. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

@aragon999 what is the state there

@shyim I rebased onto the current trunk and (hopefully) fixed all issues. It should be ready now.

@shopware/st-inventory can you take a look here? :eyes:

I've been working on integrating the changes into our current platform and encountered a few problems that need attention. I've provided detailed comments in the PR regarding the backward compatibility breaks, so please take a look.
Also, I noticed a few instances where the old class is still being used (ex ProductController.php,  ProductPageLoader, etc. ).  This might have been the reason why the other problems didn't surface earlier. It would be beneficial to begin refactoring by addressing these areas.
In my opinion, the root cause of these issues lies in the reversed inheritance scheme that has been implemented (the old class inherits from the new one). It is leading to the aforementioned backward compatibility problems and usage complications. While this may not pose a problem for internal classes, it becomes problematic for public classes. Take the src/Storefront/Page/Product/Review/ProductReviewsWidgetLoadedHook.php as an example.
To tackle this, it might need to consider adjusting the solution's architecture. One possible approach that comes to mind is modifying the inheritance scheme.

I implemented the changes as requested. I am not sure if I understood the arguments correct, but I think the BC should be fixed.
For the other remaining occurrences of the "old" Shopware\Storefront\Page\Product\Review\ProductReviewLoader it would be a breaking change, as the only remaining functionality of this class is to convert the core ReviewLoaderResult to the Shopware\Storefront\Page\Product\Review\ReviewLoaderResult.
Please let me know, if there are missing changes.

Shopware\Core\Content\Product\SalesChannel\Review extends Shopware\Storefront\Page\Product\Review\ProductReviewLoader

I think that is not possible, as the Core may not depend on the Storefront.

I agree, core classes shouldn't be extended from Srotorefront.

On the other hand, if we would replace the Shopware\Storefront\Page\Product\Review\ProductReviewLoader for example in the Shopware\Storefront\Controller\ProductController we need to somehow ensure that for Shopware 6.5 a Shopware\Storefront\Page\Product\Review\ReviewLoaderResult and not a Shopware\Core\Content\Product\SalesChannel\Review\ProductReviewResult is returned, which is only possible by using a class from the Storefront package. But this is only needed for Shopware 6.5 and hence this class should be deprecated.

As I  see currently class  Shopware\Storefront\Page\Product\Review\ProductReviewLoader
As I  see currently class  Shopware\Storefront\Page\Product\Review\ProductReviewLoader used mostly in classes in which constructors are declared as internal,
 Shopware\Storefront\Controller\CmsController
Shopware\Storefront\Controller\ProductController
so theoretically it is possible to change them to a new class without breaking changes.
The bigger problem with Shopware\Core\Content\Product\SalesChannel\Review\ProductReviewResult.
Instead Shopware\Storefront\Page\Product\Review\ProductReviewWidgetLoadedHook maybe it makes sense create a new hook wich will use ProductReviewResult. For Shopware\Storefront\Page\Product\ProductPage it might be possible to use union type for getter and setter. (Just one of variants).
It is a really difficult thing and requires big rework,  but we should find some solution to have a chance to merge PR into the platform.

I will look into it and try to solve it, but probably not this week, as I am quite busy.

Unfortunately, there have been no actions in this PR for a long time. I'll close it. If you find time to continue working on PR, feel free to open it again.


Demo doesn't show tiles when sd card is removed and using Application Private Storage

Issue Type
[ ] Bug
Description and/or steps/code to reproduce the problem
When I Pick the base location and cache location in the Demo Settings and pick Application Private Storage, the tiles load correctly if the device has an sd card available, when the sd card is removed even if the cache is set as an internal app path the tiles won't load and show as blank. Is an sd card necessary to load the tiles even when the base location and cache location don't use external storage?
Similarly, using these config settings in the app we're building before creating a map and setting a tile source, yields the same results, the base path and the cache path are set to the the internal app storage, and the tiles load correctly when an sd card is mounted, and they're blank when it's removed.
Configuration.getInstance().setOsmdroidBasePath(..
Configuration.getInstance().setOsmdroidTileCache(...
Configuration.getInstance().setTileFileSystemCacheMaxBytes(...
Configuration.getInstance().setUserAgentValue(...
Version of osmdroid the issue relates to:
6.0.1

i think there's a check in the code for "is sdcard available". Perhaps that isn't needed any longer. Thanks for the report

@sergeyfolds Maybe not 100% related but who knows: trying to reproduce this issue, I removed my SD card.
Then in the demo, went to Settings, Pick Cache Location, and then ANR!
The problem comes from PreferenceActivity.showPickCacheFromList (edited):
File[] externalFilesDirs = context.getExternalFilesDirs(null);
if (externalFilesDirs != null) {
	for (int i = 0; i < externalFilesDirs.length; i++) {
		File mount = externalFilesDirs[i];
		if (mount.exists() && mount.isDirectory()) {

Because in Context.getExternalFilesDirs

Returned paths may be null if a storage device is unavailable.

The fix is obviously something like if (mount != null && mount.exists() && mount.isDirectory())
I fixed that way, managed to change the "Cache Location" to "Application Private Storage" (/data/data/...) and the tiles are correctly displayed.
Same fix is to be applied in StoragePreferenceFragment.
I'm not sure how relevant it can be for you, but it's definitely a case of "no sd-card => unexpected behavior".

@sergeyfolds I couldn't reproduce your issue. Disclaimer: I have to switch off my smartphone in order to remove the SD card. Do you also have to?

Tested today on newest 6.0.2-SNAPSHOT, on device without SD card. Tiles still aren't displayed when base/tile cache path is set to internal cache directory, external cache directory or files directory. Everything is fine when the paths are not changed. On device with SD card everything works like a charm, regardless of the chosen directory.
Device without SD card: Samsung Galaxy S7, Android 7.0
Device with SD card: Motorola Moto G5, Android 7.0
Let me know if you need any additional information.

@spyhunter99 You were right, there's some historical "if there's no sd card do nothing" test performed through MapTileFileStorageProviderBase.isSdCardAvailable.
I'll have a look at it tomorrow.

Just PR'ed in #1031.
@sergeyfolds @ILikeYourHat That should fix this issue. Could you test and tell me if it's OK?

@monsieurtanuki Is this fix currently available in 6.0.2-SNAPSHOT? If yes, then tiles still aren't displayed. I've downloaded the latest aar from sonatype to be sure that this isn't a cache issue

@spyhunter99 How long does it take between the code merge and the impact on the aar snapshot? Is that automatic?

it isn't automatic. i'll push a build tonight

it isn't automatic. i'll push a build tonight

@spyhunter99 Thanks

@monsieurtanuki Still not working, there must be something else that prevent the tiles for being displayed.

@monsieurtanuki Any updates on this issue?

@ILikeYourHat I just managed to have tiles displayed while stored in lol/tiles by setting not only OsmdroidBasePath but also OsmdroidTileCache (using the demo / Settings).

Sorry for waiting so long. It's working now as expected, thank you :1st_place_medal:


Project.json Reference

ASP.NET 5->.NET Execution Environment->Project.json reference

@danroth27 I can do a start on this one if you like. Should I fork and start a PR?

Sure, that sounds great! The idea for this topic is to simply be a reference for the entire schema for project.json

Sure, sounds good. What about the topic of project.lock.json, is this an appropriate place to provide an explanation of that as well?

No, I think we should cover project.lock.json elsewhere (probably #50).

#50 is closed. Looks like project.lock.json was documented here: https://docs.asp.net/en/latest/dnx/projects.html#project-lock-file

The details of project.json are covered in https://docs.asp.net/en/latest/dnx/projects.html. This content will also be making its way over to the .NET docs. Closing.

I guess then then the page http://docs.asp.net/en/latest/dnx/project-json.html should be removed from the tree