[HOLD 20844] Desktop - Margin above Request Money chat report header

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the Desktop App and Login
Navigate to any money request chat

Expected Result:
The chat header should not contain a top margin
Actual Result:
The chat header contains a top margin
Workaround:
UNknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: n/a
**Reproducible in staging?:**n/a
Reproducible in production?:  v1.3.31-3 (desktop)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: Sibtain Ali
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687147774347499
View all open jobs on GitHub

Please re-state the problem that we are trying to solve in this issue.
Header background color differs for IOU report in desktop.
What is the root cause of that problem?
HeaderGap is applied to ScreenWrapper component and there we don't have any info about the report type. This issue exists for desktop and for moneyRequest report where header bg is not the same as chat report type.
What changes do you think we should make in order to solve the problem?
We need to pass an extra prop called headerGapBackground for ScreenWrapper from ReportScreen here and pass the respective green color when the report type is iou.
https://github.com/Expensify/App/blob/6728589b1d0ff4defb428c260bbac2dbfdc042f5/src/pages/home/ReportScreen.js#L250
This prop we need to maintain and pass to HeaderGap component from Screenwrapper to apply dynamic bg color.
https://github.com/Expensify/App/blob/6728589b1d0ff4defb428c260bbac2dbfdc042f5/src/components/ScreenWrapper/index.js#L134
Ref - https://github.com/Expensify/App/pull/19433#issuecomment-1561307033

I can't repro this on v1.3.32-5 even after logging out/in again:

@allroundexperts what version are you on?
It also seems odd that this is intentional, it's a bit jarring - but I'll wait for @shawnborton to weigh in before I close this GH.

Oh, so my mistake: I didn't realise this was the Desktop version! I re-downloaded it (I've not been using Desktop) and can see it on v1.3.31-3:

@shawnborton - before I apply the External label, can you confirm if this is intentional?

I agree that the top space is intentional, but it should match the color below it. That being said, we're redoing all of the headers for money requests/tasks/etc, so I think we could probably close this since changes are coming.
Also, I could have sworn we reported this one like weeks ago as well? cc @JmillsExpensify @trjExpensify @grgia @thienlnam @jasperhuangg

Yes, this was implemented in the way as the task header so they have the same problem - though this problem shouldn't occur anymore once https://github.com/Expensify/App/issues/20844 we add this, so let's just wait for this to be done instead of trying to solve this

Still on hold

Linked PR was merged!

Ah, looks like the issue is gone on Desktop!

@allroundexperts since you qualify for a reporting bonus, do you want to be paid via New.Dot?

@jliexpensify the issue is for money request report which still exists due to diff background color.

@Pujan92 looks like you're on Dev, and I'm on Production Desktop. @thienlnam do you mind having a look at this issue?

This will be fixed in https://github.com/Expensify/App/pull/22484 / https://github.com/Expensify/App/pull/22562

Nice, thanks @grgia !

Looks like these were deployed to prod over the weekend, will re-test now.

I'm on v1.3.43-7 for the Mac Desktop app and can't see it anymore:


Missing Javadoc

Hello! I find in your Developer Guidelines that

Every Java source file should begin with a header javadoc tag just before the start of the class/interface/enum, which explains the purpose and responsibilities of the code.
All public methods should have a clear Javadoc header describing the purpose, parameters and results (including exceptions). This includes test cases.

However, I still witness some public classes without Javadocs, e.g.,

open-metadata-implementation/governance-servers/open-lineage-services/open-lineage-services-api/src/main/java/org/odpi/openmetadata/governanceservers/openlineage/model/LineageVertex.java
open-metadata-implementation/access-services/subject-area/subject-area-client/src/main/java/org/odpi/openmetadata/accessservices/subjectarea/client/AbstractSubjectArea.java
open-metadata-implementation/access-services/subject-area/subject-area-client/src/main/java/org/odpi/openmetadata/accessservices/subjectarea/utils/QueryBuilder.java

I also find likely missing Javadoc for public methods in the following files:

open-metadata-implementation/access-services/subject-area/subject-area-server/src/main/java/org/odpi/openmetadata/accessservices/subjectarea/utilities/SubjectAreaUtils.java
open-metadata-implementation/adapters/open-connectors/repository-services-connectors/open-metadata-collection-store-connectors/graph-repository-connector/src/main/java/org/odpi/openmetadata/adapters/repositoryservices/graphrepository/repositoryconnector/GraphOMRSMapperUtils.java
......

Would you like to add Javadoc for these methods or classes, or they are just not that important?
If there is anything I can help with?

Please help :)


chore: bdd-spring-1575548671 to 0.0.1

chore: Promote bdd-spring-1575548671 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Failover takes 40 seconds when killing the active node (without SIGTERM)

I launched two vault nodes in HA mode with consul as backend.
When I send the active node SIGTERM followed by SIGKILL it's responding as expected with the standby node becomes active very quickly.
But, when I send  the active node SIGKILL without SIGTERM, it takes ~40 seconds for the standby node to become active
Am I doing something wrong here? I know this is not the proper way to kill a service but sometimes it could happen.
config:
backend "consul" {
  address = "<IP_ADDRESS>:8500"
  path = "vault-local"
  scheme = "http"
  service = "vault-local"
}

listener "tcp" {
  address = "<IP_ADDRESS>:8200"
  tls_disable = 1
}

telemetry {
  statsite_address = "statsite:10120"
  disable_hostname = true
}

disable_mlock = true

Sorry ignore


Add SICKO MODE RESONANCE by jonsch

Song Name
SICKO MODE RESONANCE
Artist Name
jonsch
Source
Youtube
Youtube Link
bEgae6xbZDeVL7DH
Direct File Link
No response
Song ID
12345
Start Offset [ms]
0
Extra
Made specifically bc I like this song :3c I hope there can be some cool levels with it!

reject
invalid YouTube link


Runestone encode

In the first release of Rune, https://rodarmor.com/blog/runes/ you have define that edict end etching are separated in two data. example:
OP_RETURN RUNE_TEST hex1 hex2

But in the current implement seems edicts and etching has combine in one hex right?
    for edict in &self.edicts {
      varint::encode_to_vec(edict.id, &mut payload);
      varint::encode_to_vec(edict.amount, &mut payload);
      varint::encode_to_vec(edict.output, &mut payload);
    }

    if let Some(etching) = self.etching {
      varint::encode_to_vec(etching.rune.0, &mut payload);

      if etching.divisibility != 0 {
        varint::encode_to_vec(etching.divisibility.into(), &mut payload);
      }
    }

is there any conflict? @casey

Keep in mind that that blog post is completely speculative, and that anything in it is subject to change.
It's not an issue to combine edicts and etching. Each edict is three varints, and if there are one or two trailing varints, that is the etching.


c4ai-command-r-plus on 16GPUs

Your current environment
vllm==0.4.3
numpy==1.26.4
nvidia-nccl-cu12==2.20.5
torch==2.3.0
transformers==4.41.2
triton==2.3.0
🐛 Describe the bug
I don't know if this is a bug or if the model just doesn't support this setup. I'm trying to run two machines with 16 L4 GPUs in total and I get this error:
[rank0]: ray.exceptions.RayTaskError(RuntimeError): ray::RayWorkerWrapper.execute_method() (pid=10005, ip=<IP_ADDRESS>, actor_id=92f69d368cc5f16efeca171f01000000, repr=<vllm.executor.ray_utils.RayWorkerWrapper object at 0x7f9ada535240>)
[rank0]:   File "/secondary/thies/.virtualenvs/vllm/lib/python3.10/site-packages/vllm/worker/worker_base.py", line 149, in execute_method
[rank0]:     raise e
[rank0]:   File "/secondary/thies/.virtualenvs/vllm/lib/python3.10/site-packages/vllm/worker/worker_base.py", line 140, in execute_method
[rank0]:     return executor(*args, **kwargs)
[rank0]:   File "/secondary/thies/.virtualenvs/vllm/lib/python3.10/site-packages/vllm/worker/worker.py", line 121, in load_model
[rank0]:     self.model_runner.load_model()
[rank0]:   File "/secondary/thies/.virtualenvs/vllm/lib/python3.10/site-packages/vllm/worker/model_runner.py", line 134, in load_model
[rank0]:     self.model = get_model(
[rank0]:   File "/secondary/thies/.virtualenvs/vllm/lib/python3.10/site-packages/vllm/model_executor/model_loader/__init__.py", line 21, in get_model
[rank0]:     return loader.load_model(model_config=model_config,
[rank0]:   File "/secondary/thies/.virtualenvs/vllm/lib/python3.10/site-packages/vllm/model_executor/model_loader/loader.py", line 243, in load_model
[rank0]:     model.load_weights(
[rank0]:   File "/secondary/thies/.virtualenvs/vllm/lib/python3.10/site-packages/vllm/model_executor/models/commandr.py", line 379, in load_weights
[rank0]:     weight_loader(param, loaded_weight)
[rank0]:   File "/secondary/thies/.virtualenvs/vllm/lib/python3.10/site-packages/vllm/model_executor/models/commandr.py", line 84, in weight_loader
[rank0]:     loaded_weight = loaded_weight.narrow(shard_dim, start_idx,
[rank0]: RuntimeError: start (8) + length (1) exceeds dimension size (8).

Thank you for the hint, this solved the error.
Now I get a new error:


[Feature Request] Make input for console application easier

Debug console can be used to watch values and program outputs. However, I can't input values to my program through it (especially for most of official language plugins). To make input possible, I have to use external console and switch between code and my program. This is really inconvenient. Since most of the feature of current debug console can be done by "debug on the left side (watch)", I have these possible suggestions (any of them might solve the problem) .

Add a combo box at the beginning of input of debug console. And two options are "Program", "Debug". Depending on the value chosen, the input is sent differently.

Add another label "Program" only shows program output and runtime error information. input from this is sent to program. While Debug console works separately. I think this is the best one.

Some debuggers support a "console" attribute in the launch config where you can specify an "integratedTerminal" instead of the debug console.
The "integratedTerminal" supports program input (but it cannot be used as a REPL).


Unable to to use Wrangler in CI (BitBucket Pipeline)

Is it possible to install Wrangler in a CI/CD environment, spcifically BitBucket Pipelines in our case?
If we do npm i @cloudflare/wrangler -g the installation fails with Error: EACCES: permission denied, mkdir '/root/.wrangler':
npm i @cloudflare/wrangler -g
/usr/local/bin/wrangler -><EMAIL_ADDRESS>><EMAIL_ADDRESS>postinstall /usr/local/lib/node_modules/@cloudflare/wrangler
> node install-wrangler.js
fs.js:126
    throw err;
    ^
Error: EACCES: permission denied, mkdir '/root/.wrangler'
    at mkdirSync (fs.js:764:3)
    at Object.<anonymous> (/usr/local/lib/node_modules/@cloudflare/wrangler/install-wrangler.js:60:3)
    at Module._compile (internal/modules/cjs/loader.js:776:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:787:10)
    at Module.load (internal/modules/cjs/loader.js:643:32)
    at Function.Module._load (internal/modules/cjs/loader.js:556:12)
    at Function.Module.runMain (internal/modules/cjs/loader.js:839:10)
    at internal/main/run_main_module.js:17:11 {
  errno: -13,
  syscall: 'mkdir',
  code: 'EACCES',
  path: '/root/.wrangler'
}
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>postinstall: `node install-wrangler.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

If we do npm i @cloudflare/wrangler it installs (installation logs below) but when you try to then run wrangler publish --release we receive bash: wrangler: command not found:
npm i @cloudflare/wrangler
><EMAIL_ADDRESS>install /opt/atlassian/pipelines/agent/build/node_modules/sleep
> node-gyp rebuild
make: Entering directory '/opt/atlassian/pipelines/agent/build/node_modules/sleep/build'
  CXX(target) Release/obj.target/node_sleep/module_init.o
  CXX(target) Release/obj.target/node_sleep/sleep_cpp11.o
  CXX(target) Release/obj.target/node_sleep/sleep_posix.o
  CXX(target) Release/obj.target/node_sleep/sleep_win.o
  SOLINK_MODULE(target) Release/obj.target/node_sleep.node
  COPY Release/node_sleep.node
make: Leaving directory '/opt/atlassian/pipelines/agent/build/node_modules/sleep/build'
><EMAIL_ADDRESS>postinstall /opt/atlassian/pipelines/agent/build/node_modules/protobufjs
> node scripts/postinstall
><EMAIL_ADDRESS>postinstall /opt/atlassian/pipelines/agent/build/node_modules/@cloudflare/wrangler
> node install-wrangler.js
Downloading release https://github.com/cloudflare/wrangler/releases/download/v1.2.0/wrangler-v1.2.0-x86_64-unknown-linux-musl.tar.gz
Wrangler has been installed!
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
><EMAIL_ADDRESS>added 624 packages from 465 contributors and audited 875670 packages in 16.926s
found 0 vulnerabilities

The above is using a Node 12.6.0 container image, I've also tried a Node 8-jessie image too and changing the user the container is running as to no avail.
Thanks very much!

Hey @matthew1534 - we recommend installing node/npm with a version manager like nvm. Could you try uninstalling node/npm and reinstalling with nvm and then installing wrangler afterwards? Please update if that works! Thanks for the report

Hey @EverlastingBugstopper - thanks for the above super quick reply. I've now managed to get this working using a debian container image and running the below commands:
apt-get update
apt-get -y install wget
wget -qO- https://raw.githubusercontent.com/nvm-sh/nvm/v0.34.0/install.sh | bash
source ~/.bashrc
nvm install 12.6.0
npm config set user 0
npm config set unsafe-perm true
npm i @cloudflare/wrangler -g
export CF_API_KEY=$CF_API_KEY
export CF_EMAIL=$CF_EMAIL
wrangler publish --release

We get a sh: 1: node: Permission denied error unless we run npm config set unsafe-perm true which doesn't seem so great?
Thanks :)

You can likely get around this by not running these commands as root. Hope this helps :)

thanks!

The best way I found to install Wrangler via Bitbucket Pipelines was to set the npm user to root:
script:
- npm -g config set user root
- npm install -g packagename

Source: https://stackoverflow.com/a/54290720/8742362
Full bitbucket-pipelines.yml
image: node:10.15.3

pipelines:
  default:
    - step:
      caches:
        - node
      script:
        - npm -g config set user root
        - npm install -g @cloudflare/wrangler
        - npm install
        - npm run export
        - echo $CLOUDFLARE_API_TOKEN | wrangler config
        - mv wrangler-sample.toml wrangler.toml
        - sed -i "s/account_id = \"\"/account_id = \"${CLOUDFLARE_ACCOUNT_ID}\"/" wrangler.toml
        - sed -i "s/zone_id = \"\"/zone_id = \"${CLOUDFLARE_ZONE_ID}\"/" wrangler.toml
        - wrangler publish

Requires a wrangler-sample.toml file with empty account_id and zone_id, and 3 environment variables:

CLOUDFLARE_API_TOKEN
CLOUDFLARE_ACCOUNT_ID
CLOUDFLARE_ZONE_ID

The best way I found to install Wrangler via Bitbucket Pipelines was to set the npm user to root:
script:
- npm -g config set user root
- npm install -g packagename

Source: https://stackoverflow.com/a/54290720/8742362
Full bitbucket-pipelines.yml
image: node:10.15.3

pipelines:
  default:
    - step:
      caches:
        - node
      script:
        - npm -g config set user root
        - npm install -g @cloudflare/wrangler
        - npm install
        - npm run export
        - echo $CLOUDFLARE_API_TOKEN | wrangler config
        - mv wrangler-sample.toml wrangler.toml
        - sed -i "s/account_id = \"\"/account_id = \"${CLOUDFLARE_ACCOUNT_ID}\"/" wrangler.toml
        - sed -i "s/zone_id = \"\"/zone_id = \"${CLOUDFLARE_ZONE_ID}\"/" wrangler.toml
        - wrangler publish

Requires a wrangler-sample.toml file with empty account_id and zone_id, and 3 environment variables:

CLOUDFLARE_API_TOKEN
CLOUDFLARE_ACCOUNT_ID
CLOUDFLARE_ZONE_ID


opentelemetry: add the option to discard buffer response body for http async exporter

Commit Message: opentelemetry: add the option to discard buffer response body for http async exporter
Additional Description: only the response code is used for logging purpose.
Risk Level: low
Testing: unit test
Docs Changes:
Release Notes:

/assign @htuch


Should straight delete the /elpa folder?

Hi there, this is a great package!
I migrated my config to straight and discovered that there were still packages found to be missing in a new environment. It turned out that this was because the /elpa directory still contained all of the locally installed packages in the original environment, some of which weren't indicated in the init config.
Should straight do one of the following:

delete the /elpa folder, or, as this may be too invasive,
unset the package-user-dir variable in some way, maybe by setting it to nil, since it looks like this path is used by Emacs to find packages (and is set to ~/.emacs.d/elpa by default)
document some other appropriate manual way to handle this

Good question.
I agree that deleting the folder may be a bit much. Say someone just wants to try straight, but decides they like their previous set-up better. A combination of 2 & 3 sound reasonable to me.

Disabling package.el is already done automatically out of the box by straight.el. However, if you're using Emacs 27 or more recent, then package.el is initialized before loading the init-file, which bypasses this mechanism. In that case, you should put
(setq package-enable-at-startup nil)

into early-init.el. See https://www.gnu.org/software/emacs/manual/html_node/emacs/Early-Init-File.html for docs on the early init-file.
The informational content of this comment should be part of the official straight.el documentation; see #420.

I've confirmed that adding that line in early-init.el prevents the contents of /elpa from being used locally 👍
I also added this step to this blog post on the subject (please let me know if I missed anything 🧛  ).


Only rerender if refetch result.data is different from cached data

Is your feature request related to a problem? Please describe.
If you use the cacheAndNetwork policy in combination with the Query widget, graphql_flutter will render your ui based on your cache first and then do a full rerender, after the network fetch is finished. This can look a bit odd when you are dealing with big amounts of data like pdfs. A PDF takes some time to render, so the experience is kind of bad.
What I mean is, that flutter will render the pdf based on the cache first, which takes like a second or so.. a few moments later the refetch will be finished and the pdf that just showed up will disappear just to appear again shortly after ... so it feels kind of buggy from the end users perspective.
Describe the solution you'd like
I want flutter_graphql to only rerender the ui, if the data fetched from the network is different to the data that is already available inside the cache.

IMHO cache items should be compared against each other with use of DeepCollectionEquality as far as cache records are not immutable. This could be time consuming. You can use samples from examples flutter_bloc https://github.com/zino-app/graphql-flutter/tree/master/examples/flutter_bloc and apply your desired behaviour inside listener
https://github.com/zino-app/graphql-flutter/blob/master/examples/flutter_bloc/lib/extended_bloc/graphql/bloc.dart#L17

I think the Query() Widget should have an additional property like bool rerender(dynamic oldData, dynamic newData); so that this can be easily opted in by the developer.
So that you could do something like this:
return Query(
    options: QueryOptions(
        document: document,
        rerender: (oldValue, newValue) => oldValue.toJson() == newValue.toJson(),
    ),
);

Closed by #754 and configurable by alwaysRebroadcast


flaky CI macos: IndeterminateOffset and too new GNU

Even more tests on MacOS CI are failing for some reason. This issue is about different tests than #6275, and also a different root cause, but might still be related.
Example "IndeterminateOffset":
---- test_uptime::test_uptime stdout ----
run: /Users/runner/work/coreutils/coreutils/target/x86_64-apple-darwin/debug/coreutils uptime
thread 'test_uptime::test_uptime' panicked at 'Command was expected to succeed. code: 101
stdout =
 stderr = thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: IndeterminateOffset', src/uucore/src/lib/features/utmpx.rs:192:62
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
', tests/by-util/test_uptime.rs:18:10

Example "too new GNU":
---- test_who::test_boot stdout ----
run: gwho --version
uutils-tests-info: version for the reference coreutil 'gwho' is higher than expected; expected: 8.3, found: 9.5
run: gwho -b
run: /Users/runner/work/coreutils/coreutils/target/x86_64-apple-darwin/debug/coreutils who -b
thread 'test_who::test_boot' panicked at 'Command was expected to succeed. code: 101
stdout =
 stderr = thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: IndeterminateOffset', src/uucore/src/lib/features/utmpx.rs:192:62
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
', tests/by-util/test_who.rs:33:28

I don't know whether these are two separate issues; they appear together, so I report them together.
Seen at least in #6294 and #6142. This seems to occur very often.
Since I don't really understand our MacOS CI, I can't fix this.

The errors with IndeterminateOffset have been fixed in https://github.com/uutils/coreutils/pull/6413 and https://github.com/uutils/coreutils/pull/6414


feat: (ohmyzsh git alias) imporve search #8478 & upgrade api version

Description

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

@raycastbot


Fixed build error

compiler didn't understand std::function
included <functional> as a fix

Thank you for fixing this issue!


FIX RUNNER: Support --compiler=dmd

This PR adds a special case for in runner.d for DMD so that we can run the test suite against it.  It is not ideal, as it requires dmd to be on your path.  However, I think this is a good first step.

it's not really relevant.
sdc supports stuff dmd does not!

@UplinkCoder It is relevant.   It helps us compare to the current reference compiler.   In some cases it's helped me find bugs in SDC.   And in most cases it's helped me submit bug reports to DMD.   E.g. test 0075.d is totally broken on DMD.

We all use DMD most of the time for our other code -- having it work correctly is also an important goal.

Yes but getting 100% compliance is a shiton of work, and the kind of work where you need to bach the thing again and again until you get it just right.
This is the kind of work you want a lot of eyes looking to get it done. And you get a lot of eyes by getting more features.


Figure out mechanism to tell us about breaking changes in JxCore

We really need some way to get forward notification of breaking changes in JxCore.

One suggestion is that watching jxcore-cordova project repo. After the dev phase is done. Changelogs must be sufficiant.

Watching it doesn't really work because just today there were 3 commits. Given all the notifications we are all drowned in all day we won't notice significant things. Humans can't just stare at notification feeds all day and notice interesting things (think of that next time you go through airport security). Our brains numb out. So we need a way to call out significant changes. Just a quick email or something saying "hey guys we are about to blow this up" would be enough. That way we can schedule the work.

We will be duplicating the issues here those are relevant.


Add refine_root

Codecov Report

Merging #3 (0e4f028) into master (a69b6dc) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines           61        98   +37
=========================================
+ Hits            61        98   +37

Flag
Coverage Δ

unittests
100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/refine_root.jl
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a69b6dc...0e4f028. Read the comment docs.


new:support mongenine ReferenceField filter

I am a little confused to solve the conflicts,please help me.

support flask_admin display django model.

I resubmitted a pull request for the original topic of this pull request in #1249.
The django model backend looks very interesting. Can you submit a pull request for each change except the new mongoengine referencefield filter?


Combining media queries

I agree that it is nice to have the media queries "as close to their relevant rule sets whenever possible".  Thoughts on mentioning a tool like node-combine-mq to combine them into matching media queries? This would compliment the notion of having them close to their relevance while also the benefits of combining them.

Going to steer clear of anything like that for now. Performance wise, the number of media queries doesn't matter much from what I've heard. Gzipping will also help reduce file size there by essentially de-duping repeated strings, like media queries.


aquatone-gather - JSON::ParserError

Hi there, first of all thank you for this great tool, this will really save a lot of time :-)
I just went to the whole process:
I added an api-key for shodan and did a normal discover with
aquatone-discover --domain example.com
Afterwards I scanned the results with
aquatone-scan --domain example.com
Now when it comes to the gather step I get the following output:
aquatone-gather --domain example.com
                           __
  ____ _____ ___  ______ _/ /_____  ____  ___
 / __ `/ __ `/ / / / __ `/ __/ __ \/ __ \/ _ \
/ /_/ / /_/ / /_/ / /_/ / /_/ /_/ / / / /  __/
\__,_/\__, /\__,_/\__,_/\__/\____/_/ /_/\___/
        /_/  gather v0.1.0 - by @michenriksen

Processing 2877 pages...
   Failed: https://<IP_ADDRESS>:8443/ (na49.example.com) - JSON::ParserError: A JSON text must at least contain two octets!
   Failed: https://<IP_ADDRESS>/ (na38-phx.example.com) - JSON::ParserError: A JSON text must at least contain two octets!
   Failed: https://<IP_ADDRESS>/ (dcl7.example.com) - JSON::ParserError: A JSON text must at least contain two octets!

This is displayed for all urls in the list

Hi there, it looks like it's having problems when calling out to the Nightmare script. Did you install Node and NPM (see README)?

Yes, I did that. I first installed node and then started aquatone. When I came to the discovery gather step, I let the tool download nightmare for me

Hey, thanks for making this, but yeah i see the exactly same error for gather phase, even after install npm and nodejs successfully!

Could you try to see what you get if you run the Nightmare script manually? Here's how to do it:
Find the installation location of the aquatone-gem:
find / -name aquatone.js

Go to the folder where aquatone.js is found, and execute the following:
node aquatone.js https://<ip>/ <domain> /tmp/body.html /tmp/headers.txt /tmp/screenshot.png

Replace <ip> and <domain> with one of the failed processings from the aquatone-gather output.
Normally, it should output a JSON payload, but it sounds like your installations don't.

You are right. The command
nodejs aquatone.js "https://<IP_ADDRESS>" "kranko.net" /tmp/body.html /tmp/headers.txt /tmp/screenshot.png returns nothing

Unfortunately I can't reproduce the problem, on my machine it returns the excepted JSON payload. Are you running aquatone in a Kali installation?

I run it on a Debian 8 machine

Same problem here, installed on newest kali version, node.js v8.x

Hey @michenriksen, when i tried to do it manually as you instructed i seen this error:
root@vps:/var/lib/gems/2.1.0/gems/aquatone-0.1.1# node aquatone.js https://github.com /tmp/body.html /tmp/headers.txt /tmp/screenshot.png
module.js:487
    throw err;
    ^

Error: Cannot find module 'nightmare'
    at Function.Module._resolveFilename (module.js:485:15)
    at Function.Module._load (module.js:437:25)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/var/lib/gems/2.1.0/gems/aquatone-0.1.1/aquatone.js:2:17)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)

and when i tried to install the module manually even it's installed while running gather phase for the 1st time:
root@vps:~/aquatone# sudo npm install nightmare -g

><EMAIL_ADDRESS>postinstall /usr/lib/node_modules/nightmare/node_modules/electron
> node install.js

/usr/lib/node_modules/nightmare/node_modules/electron/install.js:47
  throw err
  ^

Error: EACCES: permission denied, mkdir '/usr/lib/node_modules/nightmare/node_modules/electron/.electron'
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>postinstall: `node install.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2017-06-18T15_42_19_712Z-debug.log

am running as root as well.
root@vps:~/aquatone# npm -v
5.0.3
root@vps:~/aquatone# node -v
v8.1.2

I think this is a known issue with as nightmare uses electron which requires a X display:
https://stackoverflow.com/questions/34795037/nightmare-js-not-working-as-expected-on-ubuntu-linux-cloud-server
So when you run it from a VPS it should not work. I also tested it on a kali instance and it worked flawlessly. I will check the solution from stackoverflow and let you know if it works like that

Alright, got it working on my VPS
When you call electron directly through
/var/lib/gems/2.1.0/gems/aquatone-0.1.1/node_modules/.bin/electron

you get no message when it is working correctly. In my case it complained about missing dependencies:
/var/lib/gems/2.1.0/gems/aquatone-0.1.1/node_modules/electron/dist/electron: error while loading shared libraries: libgtk-x11-2.0.so.0: cannot open shared object file: No such file or directory

With the following command you can install all missing ones:
sudo apt-get install libgtk2.0-0 libxtst6 libxss1 libgconf-2-4 libnss3
When I now run:
xvfb-run aquatone-gather -d example.com
the output is shown and everything works as expected

Just wanted to share my solution. I had the exact same problem on Ubuntu 14.04. This was related to globally installing nmp packages. After you apply the solution, aquatone doesn't seem to actually update itself to the new configuration. Anyway, the steps needed to solve my problems where:

From https://docs.npmjs.com/getting-started/fixing-npm-permissions, I did option 2 (option 1 did not help me).
Installed electron globally
Installed nightmare globally
Removed the aquatone gem
Reinstalled the aquatone gem
Ran the  aquatone-gather

Without removing and reinstalling the aquatone gem this did not work.

I experienced the same problem with the JSON errors, and realized that I was trying to use this on my headless host.  Once I tried it on an xwindows session it worked as expected.  - I'll update the readme with a note.


Errors in csars/misc-tosca-types/service.yaml

In csars/misc-tosca-types/service.yaml, the defined namespace (daily_test.templates) seems to not be a Uniform Resource Identifier, i.e. scheme and : are missed.
Line namespace: "daily_test.templates" should be replaced by namespace: "urn:daily_test.templates", i.e. add urn:.
Then two mandatory requirements are unfulfilled: the host requirement of both file and interfaces node templates.

See PR https://github.com/xlab-si/xopera-examples/pull/34

@philippemerle thanks, very good find!

See PR https://github.com/xlab-si/xopera-examples/pull/36


In tensorflow, why does a 6B GPU show with memory limit than 5GB of VRAM?

I have a 6GB 1060 GPU. Running:
from tensorflow.python.client import device_lib
device_lib.list_local_devices()

gives
name: "/device:GPU:0"
 device_type: "GPU"
 memory_limit:<PHONE_NUMBER>
 locality {
   bus_id: 1
   links {
   }
 }
 incarnation:<PHONE_NUMBER>4385210283
 physical_device_desc: "device: 0, name: GeForce GTX 1060 6GB,
pci bus id: 0000:02:00.0, compute capability: 6.1"

Notice it is showing memory_limit of<PHONE_NUMBER>, which is 1.1GB short of 6GB.  Where did my 1.1GB go?

I think there is a limit(set by system) to what extent you can utilize your virtual memory of GPU, therefore the default size is set to 5GB. However it can be clocked further upto the actual size.

I think there is a limit(set by system) to what extent you can utilize your virtual memory of GPU, therefore the default size is set to 5GB. However it can be clocked further upto the actual size.

The above explanation is correct. Closing this issue since the issue is not at TensorFlow end. Thanks!


Fork, Commit, Merge - Easy Issue (Bootstrap CSS)

Fork, Commit, Merge - Easy Issue (Bootstrap CSS)
Create a Simple Navigation Bar
Note: You don't have ask permission to start solving the issue or get assigned, since these issues are supposed to be always open for new contributors. The actions-user bot will reset the file back to previous state for the next contributor after your commit is merged. So you can just simply start working with the issue right away!
Navigate to the tasks/bootstrap/easy directory from the root of the project.
Then open the navbar.html file to start working with the solution.

For this task, you'll be adding classes to a navigation bar using Bootstrap's Navbar component.
The navigation bar is already created to the navbar.html file, so your task is to add all the missing Bootstrap classes to make the Navbar look nice.
Use Bootstrap's built-in classes to style the navigation bar.
Acceptance Criteria:

When viewed on a large screen, all navigation links should be visible in a row.
Logo-link should be on the left side of the screen and all the other links on the right side.
There is no need to add actual logo, it can just be the default text.

If you are using VS Code and have for example Live Server extension, you can simply open navbar.html with the server and check how the card looks. After the card is done, you are ready to make a pull request!
If you do not have Live Server extension, you'll find information about installing and how to use it here.
Check out README.md for more instructions and how to make a pull request.
Feel free to ask any questions here if you have some problems!
Also, kindly give this project a star to enhance its visibility for new developers!

kindly assign me this issue @nikohoffren ,i want to work on this issue

kindly assign me this issue @nikohoffren ,i want to work on this issue

Hi! The issue description reads:
Note: You don't have ask permission to start solving the issue or get assigned, since these issues are supposed to be always open for new contributors. The actions-user bot will reset the file back to previous state for the next contributor after your commit is merged. So you can just simply start working with the issue right away!

the pr you merge was excluded from hactoberfest @nikohoffren ,do you have any idea about it

the pr you merge was excluded from hactoberfest @nikohoffren ,do you have any idea about it

Yes, it appears that since this repository is an educational repository, hence it is against the Hacktoberfest guidelines so unfortunately these tasks wont count towards that. The commits for Hacktoberfest should be meaningful and consider real issues.


background color button horizontal

hi guys! who is using bubble cards? with the last update my button has a weird color. Normally when every lights or entity is off.. cocina button shows with a black background and with high opassity.. any idea?

Hi, I've changed that in the new release for making it more visible on some setups. But indeed that color should be the same as your background. Have you made any modification to the style?

no;( just update the front end on hacs and restart
Andres Roepke Del Solar.
Ingeniero Civil Industrial
Ingeniero Electronico
Mobile 88196932
On Wed, Feb 14, 2024 at 16:01 Cloos @.***> wrote:

Hi, I've changed that in the new release for making it more visible on
some setups. But indeed that color should be the same as your background.
Have you made any modification to the style?
—
Reply to this email directly, view it on GitHub
https://github.com/Clooos/Bubble-Card/issues/386#issuecomment-1944421133,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIOTKWRZZYKQBMONNSLGW2LYTUCXRAVCNFSM6AAAAABDIYVXZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBUGQZDCMJTGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

lights on

there was some legacy code
my mistake!


Custom CSV fails with header

https://github.com/wadpac/GGIR/blob/bb399f0b5e6d46bc1a0af5c8502e6adc08392d8a/R/g.report.part2.R#L137
Describe the bug
CSV with time/x/y/z fails when specifying rmc arguments.  Following https://cran.r-project.org/web/packages/GGIR/vignettes/readmyacccsv.html still returns an error due to header.
62161_sub.csv.zip
To Reproduce
library(curl)
#> Warning: package 'curl' was built under R version 4.4.1
#> Using libcurl 8.4.0 with LibreSSL/3.3.6
library(GGIR)
zipfile = tempfile(fileext = ".zip")
curl_download(url = "https://github.com/user-attachments/files/17941173/62161_sub.csv.zip", destfile = zipfile)
exdir = tempfile()
unzip(zipfile, exdir = exdir)

datadir = file.path(exdir, "62161_sub.csv")
cat(readLines(datadir, n = 5), sep = "\n")
#> time,x,y,z
#> 2000-01-08T12:30:00.000Z,0.534,0.106,-0.877
#> 2000-01-08T12:30:00.013Z,0.487,0.126,-0.874
#> 2000-01-08T12:30:00.024Z,0.519,0.085,-0.874
#> 2000-01-08T12:30:00.036Z,0.543,0.114,-0.871

I = g.inspectfile(
  datadir,
  desiredtz = "UTC",
  configtz = "UTC",
  params_rawdata = list(
    #=====================
    rmc.dec = ".",
    rmc.firstrow.acc = 2,
    rmc.firstrow.header = 1,
    rmc.header.length = NULL,
    rmc.col.acc = 2:4,
    rmc.col.temp = NULL,
    rmc.col.time = 1,
    rmc.unit.acc = "g",
    rmc.unit.temp = "C",
    rmc.unit.time = "character",
    rmc.format.time = "%Y-%m-%d %H:%M:%OS",
    rmc.bitrate = NULL,
    rmc.dynamic_range = 6,
    rmc.unsignedbit = TRUE,
    rmc.origin = "1970-01-01",
    rmc.sf = 80L,
    rmc.headername.sf = NULL,
    rmc.headername.sn = NULL,
    rmc.headername.recordingid = NULL,
    rmc.header.structure = NULL,
    rmc.check4timegaps = FALSE,
    rmc.noise = 13,
    rmc.col.wear = NULL,
    rmc.doresample = FALSE,
    rmc.scalefactor.acc = 1
  )
)
I
#> $header
#>
#> time         x
#> sample_rate 80
#>
#> $monc
#> [1] 0
#>
#> $monn
#> [1] "unknown"
#>
#> $dformc
#> [1] 5
#>
#> $dformn
#> [1] "csv"
#>
#> $sf
#> [1] 80
#>
#> $decn
#> [1] "."
#>
#> $filename
#> [1] "62161_sub.csv"

outputdir = tempfile()
dir.create(outputdir)
GGIR::GGIR(
  datadir = datadir,
  outputdir = outputdir,
  studyname = "pax_g",
  print.filename = TRUE,
  desiredtz = "UTC",
  configtz = "UTC",
  sensor.location = "wrist",
  verbose = TRUE,
  minimumFileSizeMB = 0, # don't let small gz files be skipped
  do.parallel = FALSE,
  dynrange = 6L, # dynamic range of 6g (https://wwwn.cdc.gov/Nchs/Nhanes/2011-2012/PAX80_G.htm)
  idloc = 6, # filename gives the ID before the "."

  #=====================
  # read.myacc.csv arguments for reading in CSVS
  #=====================
  #=====================
  rmc.dec = ".",
  rmc.firstrow.acc = 2,
  rmc.firstrow.header = 1,
  rmc.header.length = 1,
  rmc.col.acc = 2:4,
  rmc.col.temp = NULL,
  rmc.col.time = 1,
  rmc.unit.acc = "g",
  rmc.unit.temp = "C",
  rmc.unit.time = "character",
  rmc.format.time = "%Y-%m-%d %H:%M:%OS",
  rmc.bitrate = NULL,
  rmc.dynamic_range = 6,
  rmc.unsignedbit = TRUE,
  rmc.origin = "1970-01-01",
  rmc.sf = 80L,
  rmc.headername.sf = NULL,
  rmc.headername.sn = NULL,
  rmc.headername.recordingid = NULL,
  rmc.header.structure = NULL,
  rmc.check4timegaps = FALSE,
  rmc.noise = 13,
  rmc.col.wear = NULL,
  rmc.doresample = FALSE,
  rmc.scalefactor.acc = 1
)
#>
#> Checking that user has write access permission for directory specified by argument outputdir: Yes
#>
#>    GGIR version: 3.1.7
#>
#>    Do not forget to cite GGIR in your publications via a version number and
#>    Migueles et al. 2019 JMPB. doi: 10.1123/jmpb.2018-0063.
#>    See also: https://cran.r-project.org/package=GGIR/vignettes/GGIR.html#citing-ggir
#>
#>    To make your research reproducible and interpretable always report:
#>      (1) Accelerometer brand and product name
#>      (2) How you configured the accelerometer
#>      (3) Study protocol and wear instructions given to the participants
#>      (4) GGIR version
#>      (5) How GGIR was used: Share the config.csv file or your R script.
#>      (6) How you post-processed / cleaned GGIR output
#>      (7) How reported outcomes relate to the specific variable names in GGIR
#> ________________________________________________________________________________
#>  Part 1
#>
#> Checking that user has read access permission for all files in data directory: Yes
#> 1
#> File name: 62161_sub.csv
#> P1 file 1
#>
#> Investigate calibration of the sensors with function g.calibrate:
#>
#> Loading chunk: 1 2 3
#> Extract signal features (metrics) with the g.getmeta function:
#>
#> Loading chunk: 1 2
#> Save .RData-file with: calibration report, file inspection report and all signal features...
#>
#> ________________________________________________________________________________
#>  Part 2
#> 1
#> ________________________________________________________________________________
#>  Part 3
#> 1
#>
#> ________________________________________________________________________________
#>  Part 4
#>  1
#>
#> ________________________________________________________________________________
#>  Part 5
#> 1
#> ________________________________________________________________________________
#>  Report part 2
#>  1
#> Error in if (header != "no header") {: argument is of length zero

Created on 2024-11-27 with reprex v2.1.1

Session info

sessioninfo::session_info()
#> ─ Session info ───────────────────────────────────────────────────────────────
#>  setting  value
#>  version  R version 4.4.0 (2024-04-24)
#>  os       macOS Sonoma 14.4.1
#>  system   x86_64, darwin20
#>  ui       X11
#>  language (EN)
#>  collate  en_US.UTF-8
#>  ctype    en_US.UTF-8
#>  tz       America/New_York
#>  date     2024-11-27
#>  pandoc   3.2 @ /Applications/RStudio.app/Contents/Resources/app/quarto/bin/tools/x86_64/ (via rmarkdown)
#>
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  package     * version date (UTC) lib source
#>  cli           3.6.3   2024-06-21 [1] CRAN (R 4.4.0)
#>  curl        * 5.2.3   2024-09-20 [1] CRAN (R 4.4.1)
#>  data.table    1.16.2  2024-10-10 [1] CRAN (R 4.4.1)
#>  digest        0.6.37  2024-08-19 [1] CRAN (R 4.4.1)
#>  evaluate      1.0.1   2024-10-10 [1] CRAN (R 4.4.1)
#>  fastmap       1.2.0   2024-05-15 [1] CRAN (R 4.4.0)
#>  fs            1.6.5   2024-10-30 [1] CRAN (R 4.4.1)
#>  GGIR        * 3.1-7   2024-11-28 [1] Github (wadpac/GGIR@bb399f0)
#>  glue          1.8.0   2024-09-30 [1] CRAN (R 4.4.1)
#>  htmltools     <IP_ADDRESS> 2024-04-04 [1] CRAN (R 4.4.0)
#>  knitr         1.49    2024-11-08 [1] CRAN (R 4.4.1)
#>  lattice       0.22-6  2024-03-20 [1] CRAN (R 4.4.0)
#>  lifecycle     1.0.4   2023-11-07 [1] CRAN (R 4.4.0)
#>  reprex        2.1.1   2024-07-06 [1] CRAN (R 4.4.0)
#>  rlang         1.1.4   2024-06-04 [1] CRAN (R 4.4.0)
#>  rmarkdown     2.29    2024-11-04 [1] CRAN (R 4.4.1)
#>  rstudioapi    0.17.1  2024-10-22 [1] CRAN (R 4.4.1)
#>  sessioninfo   1.2.2   2021-12-06 [1] CRAN (R 4.4.0)
#>  withr         3.0.2   2024-10-28 [1] CRAN (R 4.4.1)
#>  xfun          0.49    2024-10-31 [1] CRAN (R 4.4.1)
#>  yaml          2.3.10  2024-07-26 [1] CRAN (R 4.4.0)
#>  zoo           1.8-12  2023-04-13 [1] CRAN (R 4.4.0)
#>
#>  [1] /Library/Frameworks/R.framework/Versions/4.4-x86_64/Resources/library
#>
#> ──────────────────────────────────────────────────────────────────────────────

Info

Sensor brand: ActiGraph
Data format: 'CSV from NHANES
Approximate recording duration: 17 hours
Are you using a sleep diary to guide the sleep detection: NO

Desktop (please complete the following information):

OS: Mac OSX
GGIR Version: 3.1.7

Additional context
Add any other context about the problem here.
Before submitting

[X] Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?
[X] Have you tried this on the latest master branch from GitHub?

I think this is a misunderstanding. By 'header' we mean file header, not column headers. With the following parameter set I am able to process your file:

# Test with read.myacc.csv on its own to first isolate any issue:
D = read.myacc.csv(rmc.file = "path/to/filefolder/file.csv",
                   rmc.nrow = 100, # only read start of file for this test
                   rmc.dec = ".",
                   rmc.firstrow.acc = 2,
                   rmc.firstrow.header = NULL, # <= changed
                   rmc.header.length = NULL,
                   rmc.col.acc = 2:4,
                   rmc.col.temp = NULL,
                   rmc.col.time = 1,
                   rmc.unit.acc = "g",
                   rmc.unit.temp = "C",
                   rmc.unit.time = "character",
                   rmc.format.time = "%Y-%m-%dT%H:%M:%OS",
                   desiredtz = "", # <= needed when using this function on its own, in GGIR() calls this happens automatically
                   rmc.bitrate = NULL,
                   rmc.dynamic_range = 6,
                   rmc.unsignedbit = TRUE,
                   rmc.origin = "1970-01-01",
                   rmc.sf = 80L,
                   rmc.headername.sf = NULL,
                   rmc.headername.sn = NULL,
                   rmc.headername.recordingid = NULL,
                   rmc.header.structure = NULL,
                   rmc.check4timegaps = FALSE,
                   rmc.col.wear = NULL,
                   rmc.doresample = FALSE,
                   rmc.scalefactor.acc = 1)

> print(head(D$data))
       time     x     y      z
1 947334600 0.534 0.106 -0.877
2 947334600 0.487 0.126 -0.874
3 947334600 0.519 0.085 -0.874
4 947334600 0.543 0.114 -0.871
5 947334600 0.507 0.114 -0.868
6 947334600 0.481 0.120 -0.862

# Test with GGIR as a whole:
GGIR(datadir = "/path/to/filefolder",
     outputdir = "/some/other/path",
     rmc.dec = ".",
     rmc.firstrow.acc = 2,
     rmc.firstrow.header = NULL,
     rmc.header.length = NULL,
     rmc.col.acc = 2:4,
     rmc.col.temp = NULL,
     rmc.col.time = 1,
     rmc.unit.acc = "g",
     rmc.unit.temp = "C",
     rmc.unit.time = "character",
     rmc.format.time = "%Y-%m-%dT%H:%M:%OS",
     rmc.bitrate = NULL,
     rmc.dynamic_range = 6,
     rmc.unsignedbit = TRUE,
     rmc.origin = "1970-01-01",
     rmc.sf = 80L,
     rmc.headername.sf = NULL,
     rmc.headername.sn = NULL,
     rmc.headername.recordingid = NULL,
     rmc.header.structure = NULL,
     rmc.check4timegaps = FALSE,
     rmc.col.wear = NULL,
     rmc.doresample = FALSE,
     rmc.scalefactor.acc = 1)

The documentation mentions 'file header' a couple of time, but I understand that this should be emphasized more systematically across the whole page. So, action points from this is to update the vignette accordingly.


Makes mathjax script optional with config param.

please sync config to config.yml and add comment

I don't know how to do, I'm just learning along as I go, so could you tell what I need to configure?

LGTM


[DOCS] Creates custom landing page for the Go client book

Overview
This PR adds a new landing page to the Go client book so it will be more in line with the main docs landing page, the ES guide landing page, and the Kibana guide landing page.

Current Go docs landing page
New Ruby docs landing page proposed in this PR

The content can be easily modified based on feedback.

@elasticmachine test this please

@elasticmachine test this please


[$250] Scan - LHN preview for expense report shows 0.00 when there is only one scan expense

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v9.0.23-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to workspace chat that has no unsettled expense (or create a new workspace).
Submit a scan expense.
After the scanning is complete, click on the expense preview in the main chat.

Expected Result:
LHN preview for the expense report will show the correct scanned amount.
Actual Result:
LHN preview for the expense report shows 0.00.
This issue only happens when there is only one scan expense in the report.
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/aa964514-eb12-434d-8933-8537968c8591

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01676bf97c74d0768c
Upwork Job ID:<PHONE_NUMBER>462476516
Last Price Increase: 2024-08-22
Automatic offers:

DylanDylann | Reviewer | 103712163
nkdengineer | Contributor | 103712164

Issue OwnerCurrent Issue Owner: @DylanDylann

We think that this bug might be related to #wave-collect - Release 1

@twisterdotcom  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
LHN last message shows 0 amount in one-expense report if the expense is a scan request.
What is the root cause of that problem?
The one-expense report "lastMessageText" itself is "$0.00 expense". Looks like the last message when we do a scan request is always like that. But if we open an empty transaction thread, the last message shown in LHN is "No activity yet". I believe we want the last message for one-expense report to be the same as transaction thread, so I'll explain why the last message shown in LHN is different.
When we get the last message of a report, we take its last visible action and we create it based on the action type.
https://github.com/Expensify/App/blob/50de692ff915d7998bff3fb0d024446b59912b52/src/libs/OptionsListUtils.ts#L593-L595
If the last message is still empty, we fallback to the report lastMessageText property.
https://github.com/Expensify/App/blob/50de692ff915d7998bff3fb0d024446b59912b52/src/libs/OptionsListUtils.ts#L671-L677
In one-expense report, the last report action is null because the last report action is the CREATED action, but we filter it out, so, it fallback to the lastMessageText which is "$0.00 expense".
This is the same case as one-transaction thread too, but the lastMessageText is empty, so, it gets the last message from the welcome message, which is also empty for a chat thread (including transaction thread), so we finally fallback to "No activity yet".
https://github.com/Expensify/App/blob/50de692ff915d7998bff3fb0d024446b59912b52/src/libs/SidebarUtils.ts#L448-L449
https://github.com/Expensify/App/blob/50de692ff915d7998bff3fb0d024446b59912b52/src/libs/SidebarUtils.ts#L488-L492
What changes do you think we should make in order to solve the problem?

To show "No activity yet" for one-expense report too,

If it's a one-transaction report and the last report action is empty (null), then return empty string as the last message from OptionsListUtils.getLastMessageTextForReport.

if (!lastReportAction && transactionThreadReportIDs[reportID]) {
    return "";
} else if (ReportUtils.isArchivedRoom(report, reportNameValuePairs)) {

transactionThreadReportIDs is a new variable that stores the one-transaction thread report ID for each one-expense report.
const transactionThreadReportIDs = {};

https://github.com/Expensify/App/blob/50de692ff915d7998bff3fb0d024446b59912b52/src/libs/OptionsListUtils.ts#L309-L313
transactionThreadReportIDs[reportID] = transactionThreadReportID;

Update getWelcomeMessage to return empty welcome message for one-expense report too.
https://github.com/Expensify/App/blob/50de692ff915d7998bff3fb0d024446b59912b52/src/libs/SidebarUtils.ts#L488-L492

 || !!ReportActionsUtils.getOneTransactionThreadReportID(report?.reportID ?? '-1', reportActions)

We will pass the reportActions as the param of getWelcomeMessage.

Proposal
Please re-state the problem that we are trying to solve in this issue.
LHN preview for the expense report shows 0.00.
This issue only happens when there is only one scan expense in the report.
What is the root cause of that problem?
When the expense report is a combined report, we filtered out the IOU action of expense report via getCombinedReportActions function here
https://github.com/Expensify/App/blob/156f0a2bd0e94558ad621caa701bd749dd124bfe/src/libs/OptionsListUtils.ts#L310-L313
That makes lastReportAction here null then we fallback to report.lastMessageText which is 0.00 expense in this case
https://github.com/Expensify/App/blob/156f0a2bd0e94558ad621caa701bd749dd124bfe/src/libs/OptionsListUtils.ts#L595
What changes do you think we should make in order to solve the problem?
I think we should not filter out the IOU action in OptionsListUtils because we will use this action to get the correct last message text. For example, if the receipt is scanning, LHN should display Receipt scanning... that is the behavior when the expense report is not a combined report.

https://github.com/Expensify/App/blob/156f0a2bd0e94558ad621caa701bd749dd124bfe/src/libs/OptionsListUtils.ts#L310-L313
To do that we can create a new param in getCombinedReportActions like shouldFilterIOUAction with default value is true then if it's false we will return early here
if (!isMoneyRequestAction(action) || !shouldFilterIOUAction) {
    return true;
}

What alternative solutions did you explore? (Optional)
NA

Two proposals have different output

With @bernhardoj's proposal, the subtitle of one transaction expense in LHN display No activity yet  when the receipt is being scanned and after the scan is successful
With @nkdengineer's proposal, the subtitle of one-transaction expense in LHN rely on the last reportActions, It will display Receipt scanning... if the receipt is being scanned and display the correct amount after the scanning is successful

Note that the amount from both report.lastMessagetext and reportAction.message/originalMessage is returned wrong from BE
The decision to assign this task to someone depends on our expectation. Let's wait for the final decision from the internal engineer
🎀 👀 🎀 C+ reviewed

It will display Receipt scanning... if the receipt is being scanned and display the correct amount (getting from transaction) after the scanning is successful

That seems correct to me. Receipt scanning... (during scanning), $x.xx expense (after scanning, if successful). The latter being consistent with "manual" one expense reports on prod:

Yeah I would tend to agree too.
One question about the approach though (and maybe this can be discussed in the PR) is why do we need a new param shouldFilterIOUAction? Or asked differently, when would we use true and when would we use false? If we only set it to false for one-transaction reports, could we count how many items are in filteredParentReportActions instead?
Basically, I'm thinking if we can avoid introducing a new param, it's one less chance that someone will use it wrong in the future and cause a bug.

@twisterdotcom @francoisl Please help to process payment here

Payment Summary:

@DylanDylann paid $250 via Upwork here (C+)
@nkdengineer paid $250 via Upwork here (Contributor)


fix(sqllab): fix error due to anonymous user

SUMMARY
If a query has been executed by an undefined user or someone that no longer exists in the database, an error is displayed on the SQL Lab history page:
BEFORE

AFTER

TEST PLAN
Local testing
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Thanks for the review @michael-s-molina !


Templates are showing twice

I updated to the latest version this morning and now all my templates are showing twice. One per zone. Is this a bug or on pourpose?

@davidjumani can you triage if this is a bug?

Should be fixed via #543

@gaaray2k Could you attach a screenshot ?

@gaaray2k can you try latest master again, we think it's fixed.

I will today. One more thing. When using a public IP, I have three features I can use. LB, PF or firewall. But only one feature can be use at a time. If I use the LB feature for example, shouldn't the others be grayed out so users cant use them? Right now all the options are available and you get some internal error message but if you look at the logs it says that error is because you have another feature enabled.

Still happening.
[root@cs-mgmt-02 ~]# yum update cloudstack-primate
Loaded plugins: fastestmirror
Loading mirror speeds from cached hostfile

base: mirror.oss.ou.edu
extras: mirror.oss.ou.edu
updates: mirrors.unifiedlayer.com
base                                                                                | 3.6 kB  00:00:00
cloudstack                                                                                | 3.2 kB  00:00:00
cloudstack-primate                                                                                | 2.9 kB  00:00:00
extras                                                                                | 2.9 kB  00:00:00
mysql-connectors-community                                                                                | 2.5 kB  00:00:00
mysql-tools-community                                                                                | 2.5 kB  00:00:00
mysql56-community                                                                                | 2.5 kB  00:00:00
updates                                                                                | 2.9 kB  00:00:00
(1/2): cloudstack/7/primary_db                                                                                | 9.6 kB  00:00:00
(2/2): cloudstack-primate/primary_db                                                                                |  11 kB  00:00:00
Resolving Dependencies
--> Running transaction check
---> Package cloudstack-primate.x86_64 0:0.5.0-20200728 will be updated
---> Package cloudstack-primate.x86_64 0:0.5.0-20200729 will be an update
--> Finished Dependency Resolution

Dependencies Resolved
=============================================================================================================================================================
Package                                  Arch                         Version                                Repository                                Size
Updating:
cloudstack-primate                       x86_64                       0.5.0-20200729                         cloudstack-primate                       5.7 M
Transaction Summary
Upgrade  1 Package
Total download size: 5.7 M
Is this ok [y/d/N]: y
Downloading packages:
Delta RPMs disabled because /usr/bin/applydeltarpm not installed.
cloudstack-primate-0.5.0-20200729.x86_64.rpm                                                                                | 5.7 MB  00:00:01
Running transaction check
Running transaction test
Transaction test succeeded
Running transaction
Running through pre-install cloudstack-primate
Updating   : cloudstack-primate-0.5.0-20200729.x86_64                                                                                1/2
Running through post-install cloudstack-primate
Running through the pre-uninstall cloudstack-primate
Cleanup    : cloudstack-primate-0.5.0-20200728.x86_64                                                                                2/2
Running through the post-uninstall cloudstack-primate
Verifying  : cloudstack-primate-0.5.0-20200729.x86_64                                                                                1/2
Verifying  : cloudstack-primate-0.5.0-20200728.x86_64                                                                                2/2
Updated:
cloudstack-primate.x86_64 0:0.5.0-20200729
Complete!

@gaaray2k Could you check the api being called ? Should be this
listall=true
templatefilter=self
showunique=true
page=1
pagesize=10
command=listTemplates
response=json

Also could you check the backed whether the listTemplates API supports the showUnique parameter

433319, via: 4(cs-compute-02), Ver: v1, Flags: 10, { GetVmStatsAnswer } }
2020-07-29 07:17:10,522 DEBUG [c.c.a.ApiServlet] (qtp1497845528-353:ctx-6fc23353) (logid:ccc9833b) ===START===  <IP_ADDRESS> -- GET  listall=true&templatefilter=self&showunique=true&page=1&pagesize=20&command=listTemplates&response=json
2020-07-29 07:17:10,548 DEBUG [c.c.a.ApiServer] (qtp1497845528-353:ctx-6fc23353 ctx-eac1d965) (logid:ccc9833b) CIDRs from which account 'Acct[22819714-574b-40be-9d50-7367efad451a-lab.com]' is allowed to perform API calls: <IP_ADDRESS>/0,::/0
2020-07-29 07:17:10,576 WARN  [c.c.a.d.ParamGenericValidationWorker] (qtp1497845528-353:ctx-6fc23353 ctx-eac1d965) (logid:ccc9833b) Received unknown parameters for command listTemplates. Unknown parameters : showunique
2020-07-29 07:17:10,711 DEBUG [c.c.a.ApiServlet] (qtp1497845528-353:ctx-6fc23353 ctx-eac1d965) (logid:ccc9833b) ===END===  <IP_ADDRESS> -- GET  listall=true&templatefilter=self&showunique=true&page=1&pagesize=20&command=listTemplates&response=json

two more issues

One more thing. When using a public IP, I have three features I can use. LB, PF or firewall. But only one feature can be use at a time. If I use the LB feature for example, shouldn't the others be grayed out so users cant use them? Right now all the options are available and you get some internal error message but if you look at the logs it says that error is because you have another feature enabled.

I disabled the redundant vpc service offering but still shows up when creating a vpc in primate. it doesnt show up in the legacy UI.

@gaaray2k Looks like a backend issue. In the latest 4.14, we've added a showunique parameter to the listTemplates API which returns only one template per zone
https://github.com/apache/cloudstack-primate/pull/411
https://github.com/apache/cloudstack/pull/4140
Could you open a separate issue for the other bugs ?

will do

it was working ok before updating to the 7/27/20 version

Here is a screenshot of one management server running cloudstack-primate-0.5.0-20200624.x86_64

and here is one of a mgmt server running cloudstack-primate-0.5.0-20200801.x86_64

Also I noticed that on the new version, the systems templates arent showing.

@gaaray2k Primate requires CloudStack latest 4.14 or master, we'll be targetting 1.0/GA along with CloudStack 4.15. Some of the known issues are around listing of unique templates/isos when you've more than a single zone. What you're reporting is one of the known issues for 4.14/older versions, fixed in backend here - https://github.com/apache/cloudstack/pull/4140

I think you are right. I noticed yesterday that it is only showing twice on the admin page and cmk. The users pages shows just one template.


Cannot back-reference a group when the replacement contains "$$"

Does this issue occur when all extensions are disabled?: Yes

VS Code/OS Version:

Version: 1.95.1 (user setup)
Commit: 65edc4939843c90c34d61f4ce11704f09d3e5cb6
Date: 2024-10-31T05:14:54.222Z
Electron: 32.2.1
ElectronBuildId: 10427718
Chromium: 128.0.6613.186
Node.js: 20.18.0
V8: 12.8.374.38-electron.0
OS: Windows_NT x64 10.0.22635

Steps to Reproduce:

Input text $ 1234 $
Ctrl + H to open the replace panel and use regex

Find: \$ (.+?) \$
Replace: $$1$

Expected: text becomes $1234$
Actual: text becomes $1$; but if replacing with $ $1$ the text will become $ 1234$ as expected.

The replace text should be $$$1$$.


Running on Windows

Hi,
Having an issue getting train-binary.py to run correctly on windows due to the colons in the weight-improvement section.
This section : target_dir = "./models/weights-improvement-{epoch:02d}-{val_acc:2f}.hdf5"
Any idea how to get around this?

Screenshot of the issue i'm having: https://imgur.com/a/nanVeau

This is a problem because of the python enviroment you are using. Change the target directory to the exact location instead of a relative path as in the example. For example: "YOUR_PATH_TO_MODELS_FOLDER/models/weights-improvement-{epoch:02d}-{val_acc:2f}.hdf5"
Just go the the folder and check for properties by right clicking and copy the path you see over there to this line.


Proposed feature #1 - Fill the partition with a percentage of the disk space available

The * option is really useful, because it fills the remainder of an image with the final paritition. For instance, when the DH0 is 100MB the DH1 takes the rest of the space, regardless how large the image is.
Maybe I am little "old-style" but as a matter of precaution, I tend to use the 99% of the remainder of the disk to avoid "final cylinder" issues.
If you feel appropriate, would it be possible adding the possibility to fill with a given percentage (say 99%) instead of the 100% of the space?
Thank you for your consideration.

Size in percentage is already supported, but might not have been fully tested for all commands.
Current version supports for example adding a partition sized 20% of Rigid Disk Block Size:
hst.imager rdb part add test.vhd DH0 PFS3 20%
Just released a fix minutes ago, that allows initializing Rigid Disk Block sized 50% of disk:
hst.imager rdb init test.vhd --size 50%


Remote trigger right after sdk is available

Fix #499
Signed-off-by: Sophia Guo<EMAIL_ADDRESS>

@sophia-guo to have a quick test, you can use ""run tests quick 19" than the full tests on all jdk versions with "run tests"

The PR tests failures is not related with this PR.
The PR is testing by https://ci.adoptopenjdk.net/view/work-in-progress/job/sophia_buildPipeline/45/

run tests quick 19


Broken Link in Tutorial

Actual behavior (the bug)
Following the Link "A live demo can be found here" on the tutorial page for "TODO MVC with Vue.js and Kotlin" does not show the live demo but an error page from heroku.
Expected behavior
The live demo is shown (or the link shouldn't exists).

Hmm.. I guess this applies to several of the tutorials now, since they shut down "Heroku Free". Thanks for reporting!


Fixed to fit in Korean Lunar Calendar

https://github.com/dr-prodigy/python-holidays/pull/294#issuecomment-599399631
PEP8 tested
added more tests for Korean Lunar Calendar Holidays.

Pull Request Test Coverage Report for Build 757

157 of 189 (83.07%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 99.626%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

holidays/countries/korea.py
131
163
80.37%

Totals

Change from base Build 756:
-0.4%

Covered Lines:
8520

Relevant Lines:
8552

💛  - Coveralls

Pull Request Test Coverage Report for Build 757

157 of 189 (83.07%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 99.626%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

holidays/countries/korea.py
131
163
80.37%

Totals

Change from base Build 756:
-0.4%

Covered Lines:
8520

Relevant Lines:
8552

💛  - Coveralls

Hey there @1kko
thank you very much for your work!
In order to have it merged soon I would kindly ask you to apply some modifications, ie please:

check / fix code conflicts in your pull request
avoid including code from lunar calendar library (as said, the right approach is to add a dependency to that library, so we don't duplicate code and can take advantage for future code fixes/updates)
provide unit test for all your new code (100% coverage)

I'm available for further explanations: thank you very much and cheers
dr-p

hi @dr-prodigy
I'm quite newbie in contributing open source projects.
If you don't mind may I get some your advise? I frankly don't know what to do.

I think I got understood what you are talking about.
I'll close this request and make new pull request.


Added FormData object

Added a FormData object that encapsulates a byte[] and a String contentType.
Currently, all byte[] parameters are added as an application/octet-stream to the request.
This new object allows users to control the content type sent as part of a multipart/form request.

I've never used Lombok before so please let me know if this is okay.
I'm also open to rename FormData to something you think might be more appropriate.
I've also added @SuppressFBWarnings to the pom and FormData object since I couldn't find a way to guarantee the immutability of the FormData byte[] field.
I also did not bump the version number. I am unsure as to what the release process is, please advise :)

Fixes https://github.com/OpenFeign/feign-form/issues/37

Build failed but it appears to be related to the build itself and not this PR?
$ echo $GPG_SECRET_KEYS | base64 --decode | $GPG_EXECUTABLE --import
--import: command not found
The command "echo $GPG_SECRET_KEYS | base64 --decode | $GPG_EXECUTABLE --import" failed and exited with 127 during .

Looks like $GPG_EXECUTABLE is not defined.

Nope, build failed because of using secure variables in .travis.yml file during regular build. You could see it log above.
It was described here
I have fixed the issue and restarted your build

Thanks for the help  @xxlabaza . I have now fixed the build.

@GuiSim, could you also add usage example, like @tjuchniewicz did with "Spring MultipartFile", at the end of README.md file? After that, I will add you as co-author

I tweaked the README which now includes an example for File, byte[] and FormData.
Let me know if this is sufficient!

Thanks for merging this! Will you deploy a new version with these changes?

yep, do you have an email? Or you don't want to publish it?

Thanks, @GuiSim for your help
New version 3.3.0 with your code was published. Will be available soon on maven central

@xxlabaza Thank you! I didn't realize that I could be deploying it myself. Appreciate it 🙌


stage0: brute-force GC on GC failure

When a pod directory is in an unexpected state, it may happen that the
standard garbage collection fails. When this happens mounts can be left
around, requiring manual removal.
This change forces a GC of the pod mount points when the pod GC
otherwise fails. To do this, the /proc/self/mountinfo file is parsed,
the pod mount points are extracted, ordered, then unmounted.
fixes #1572

LGTM


See the command being executed for key binding

Issue Type: Feature Request
I would like to have a setting that would allow us to see the command being executed for key binding.  That way I can verify my customizations are actually working.
VS Code version: Code 1.55.2 (3c4e3df9e89829dce27b7b5c24508306b151f30d, 2021-04-13T09:35:57.887Z)
OS version: Windows_NT x64 10.0.19042

There is existing >Developer: Toggle Keyboard Shortcuts Troubleshooting which logs received keys and resoled commands.
Have you tried it? Does it cover you use case?

Yes satisfies my need.


Typo fix in test_subword_enrichment:

s/X_test/expected/

Hi @cgpotts
I was checking my code against test_subword_enrichment(), and my result doesn't match with expected.
I just wanted to check with you that is the test case is valid since it seems that this is newly added for the upcoming quarter and I wanted to check.
Thank you very much,

@insop Thanks again for your input on this. Would you mind writing to me at<EMAIL_ADDRESS>If you include your subword_enrichment code, I can check it over and compare it to mine. If you prefer not to do that, then I can share my solution with you and perhaps you'll see the issue.

@insop Hey, actually, maybe never mind? I pushed an update to hw_wordsim.ipynb that might correct the problem. The main change is that I think I had the expected values wrong!

Hi @cgpotts
Thank for checking this. I went back and checked my notebook and my result matched with the updated value.
Here was my note:

@insop Very reassuring! I had simply messed it up!


compatibility with Turing.jl?

Hi
That's an interesting package. Does RunDIME accept a Turingmodel for the LogProb?
Cheers, Fabienne

Hi Fabienne,
Thank you for your interest in the package.
The approach of DIME is somewhat less fancy than Turing.jl. Turing does a lot of things for you under the hood. This is nice if things work out well.
DIME is far more conservative. LogProb is assumed to simly take the state space of the posterior distribution as input and to return the posterior density. IMHO, expressing the large-scale time series models used in economics in the "Turing" way would be quite challenging.
Cheers,
Gregor


The slab structure bounces and jitters from the point of being placed

Even if I set the friction to 1.0 the slabs slowly slide on each other due to jitter and an impossible physical state. I'm trying to make them a kinetic body instead of a static body. Also start them as ISLAND_DISABLED state and then enable them at the time the ball is added. But so far that doesn't work.

It helps that I start the simulation clock when the ball is placed (that's when the simulation actually have to start). Otherwise a huge amount of time can pass between the tower and the ball placement and that would cause the explosion of the slabs. This also guarantees no jitter and movement until the ball is hurdled. However at the point of the hurdle there's still an initial movement and then jitter.

So there's no explosion any more just a small bounce. The slabs were floating on each other because the simulation engine needs a margin around the convex hulls. The engine uses that to compute normal vectors related to the simulation so it's needed.
https://pybullet.org/Bullet/phpBB3/viewtopic.php?f=9&t=2358&sid=c757996ff8459a33e0a7674d4e71e66e
De default margin is 0.04 which is way too big, we need rather 0.0025. That helps to decrease the visual gap.Sphere won't have problem. I also tried to transparently apply the gap (shrink the slabs a tiny bit) just within the Physics layer and then of the reverse transformation when the engine enforces sets the new positions.
There's still some bump thought so that logic right now is disabled.

Eventually this can be solved by a proper selection of setSleepingThresholds. Maybe we'll also need to remove setActivationState(DISABLE_DEACTIVATION);. We'll see.


 Let's go ahead and focus on the other things, I think this might just end up being a bit distracting and confusing. I just did this for the meatmap project and I'm working on it for this project now.

Needs to be done for R language, currently just used Python because R was failing


refactor(ci): build requirements.txt and SBOM artifacts only on release

It’s probably enough to build the requirements.txt file and the SBOM only when we create a release…
@behnazh we currently build and upload the release artifacts with every run of the workflow, and only the “Update release tag” step is guarded
https://github.com/jenstroeger/python-package-template/blob/c7541754294c634cd807068ffaf37bd0279cbb52/.github/workflows/build.yaml#L124
Should we limit the other steps too?

Hmm… maybe another reason why we want to build the requirements.txt file only on release, i.e. only on Linux: https://github.com/jenstroeger/python-package-template/runs/7787360179?check_suite_focus=true#step:9:166


[SPARK-3251][MLLIB]: Clarify learning interfaces

** Make threshold mandatory **
Currently, the output of predict for an example is either the score
or the class. This side-effect is caused by clearThreshold. To
clarify that behaviour three different types of predict (predictScore,
predictClass, predictProbabilty) were introduced; the threshold is not
longer optional.
** Clarify classification interfaces
Currently, some functionality is spreaded over multiple models.
In order to clarify the structure and simplify the implementation of
more complex models (like multinomial logistic regression), two new
classes are introduced:

BinaryClassificationModel: for all models that derives a binary
classification from a single weight vector. Comprises the tresholding
functionality to derive a prediction from a score. It basically captures
SVMModel and LogisticRegressionModel.
ProbabilitistClassificaitonModel: This trait defines the interface for
models that return a calibrated confidence score (aka probability).

** Misc

some renaming
add test for probabilistic output

I think this has gone stale and timed out. do you mind closing this PR?


upgrade-assistant upgrade . This tool is not supported on non-Windows platforms due to dependencies on Visual Studio.

Summary
How about putting that higher in the README.MD, rather than having us assume it will work on Linux/Mac ootb?
Motivation and goals
10-15 minutes time wasted to discover the tool isn't as XPLAT as it might be?
In scope
While we're at it can we get a "mission statement" written for this valuable tool? I foresee that because there were both .Net CORE 4.6.1 and .Net Framework 4.6.1, there could potentially be confusion generated by what the tool can accomplish.
Out of scope
Scenarios you explicitly want to exclude.
Risks / unknowns
How might developers misinterpret/misuse this? How might implementing it restrict us from other enhancements in the future? Also list any perf/security/correctness concerns.
Examples
Give brief examples of possible developer experiences (e.g., code they would write).
Wonder how the VS dependencies could be "de-coupled" ... or maybe we're stuck waiting for the first cut of VS built completely on .NET 6++.

It doesnt work on Mac? OMG, wasted visual studio subscription and time.

Windows isn't listed as a prerequisite on this page, but it looks like it is on the microsoft domain page Not sure about the connection in between the pages though.

really, no Mac support in 2023? that's a shame.

Seriously, no extension for MAC? Why Microsoft is releasing half baked tools.


zookeeper集群的支持问题

单台zookeeper服务端消费正常，当zookeeper搭建集群后启动多个消费者就会报错：
Caused by: org.I0Itec.zkclient.exception.ZkNoNodeException: org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for XXX

的异常

Hi, from you description, there is nothing to do on Dubbo side.


feat: Bump vnu-jar to 18.7.23

✨ new release

oops, sorry, didn't check PRs at all before I pushed the update.


Update deps

Description of the pull request:
Update deps, because the deps shield is red.
Reviewers:
Everyone.

I tried about 6 weeks ago and gave up after an hour or so of hair-pulling. I'd say try 'em one at a time to avoid the massive pile of fail. I think we may need to stick with an older gobble to avoid the fs watch terribleness with native modules.

Good to go?

Yep. This will do for now.
Determined that updating Gobble and/or Rollup causes issues. Will
investigate later.
On 15:22, Tue, Oct 18, 2016 Chris Reeves<EMAIL_ADDRESS>wrote:

Good to go?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ractivejs/ractive/pull/2681#issuecomment-254611711,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABgnVMkkxZFTfAXIDNcJRLts3zz7Osifks5q1Rx_gaJpZM4KVaTi
.

The move was just in time for the news
https://medium.com/@nodejs/node-js-v6-transitions-to-lts-be7f18c17159 :D
On 15:36, Tue, Oct 18, 2016 Chris Reeves<EMAIL_ADDRESS>wrote:

Merged #2681 https://github.com/ractivejs/ractive/pull/2681.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ractivejs/ractive/pull/2681#event-828041587, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABgnVB5yXAeGL7yPFZFHHHdmZwO8ClmEks5q1R_ZgaJpZM4KVaTi
.


Fix a bug with core-input sizes

Due to a Chrome change, all core-input elements were force-styled to be
20em wide.  This looked incredibly strange when used with a
paper-input-decorator (as is all over in the code).  This changes the
styling for core-ipnut element below paper-input-decorators so that they
will have the correct size.
Fixes #1878

:+1:


Use of special characters on website

This issue is from the accessibility audit of the Design System website by DAC in July 2024.
DAC's description

Page: Accessibility strategy – GOV.UK Design System
WCAG reference: none (Usability)
Issue ID: DAC_Special_Characters_Usability_01

There was link in relation to issues found by automated testing tools. Within the link text a tilde (‘~’) was included to represent an approximation of 30% issues found. The inclusion of the tilde could be problematic for some users.
Screen reader users may not interpret the tilde as an approximation symbol. They might read it out as ‘tilde’ or ignore it altogether, leading to misinterpretation of the content to what it was intended.
Also, using the tilde alone does not provide clear context or meaning without additional explanation. Users who are not familiar with its use as an approximation symbol may not understand the intended meaning.

DAC's proposed solution
To ensure clarity and consistency across all users and devices, use the word ‘approximately’
or ‘about’ instead of the tilde to convey the meaning.
Additional instances
As this can potentially happen on any page, this work should include checking all the other pages other links missing context.
It might be worth making two different cards for this: One for checking and recording all instances, the other for fixing them.
To save time, it makes sense to audit all the body copy issues together:

#4010
#4013
#4023
#4024
#4025

Needed roles
Content designer

For a long while now, I've used this Deque blog from 2014 as my reference.
Might be a good starting point for us – or otherwise I'd be keen to update my understanding on this area!

To detect, we can:

scan the website for the specific special characters

To assess, we can:

review results and ensure the special characters are appropriate to use, and used in correct way

To resolve, we can:

correct misused characters
remove special character and replace with text instead


Create a Data Model level Profile to identify core data specification table

The Mdm Explorer Query Builder needs to know which is the core table to use when building tables. There is only one table in the Mauro Database that should be identified as the key table. A new Data Model level Profile needs to be created that can be used to identify which of the tables is the core table. This information will be recorded in a string that defines the schema and table name, e.g: "patients_schema.patient". There is a risk of a mismatch or a typo but that will be handled in the code that consumes this setting and will report an error if the schema and table cannot be found. The consuming code will also need to be updated to report an error if this profile is missing. This will be done as part of #36

The associated PR was not attached to this issue. The PR has passed review and already been merged. Closing this issue.


[cxx-interop] Do not auto-complete unsafe underscored methods, part 2

Previous patch removed unsafe C++ methods from the module interface, but not from auto-completion results.
rdar://103252957

@swift-ci please smoke test


Misc fixes for big-o notation page

@kianmeng, you are the only reason anything is spelled correctly or has proper punctuation on this project. 🤣

@kianmeng, you are the only reason anything is spelled correctly or has proper punctuation on this project. rofl

@BrooklinJazz Is contributions from everyone, https://github.com/DockYard-Academy/beta_curriculum/graphs/contributors
:partying_face: :partying_face: :partying_face: :partying_face: :partying_face:


boardroom launch time

@nikhil1415926 Thank you for catching up the missed part! However, the start date should be Dec 11 (Fri)— so treasuryAllocationDelayInSec should be 6*86400.
Since it looks like it should be fixed ASAP, we'll handle it if you don't mind.

Sure Go ahead


Description
The pr do not fix the pr correctly, so I will revert it.
Content1 ...
Content2 ...
Content3 ...

This PR has:

[ ] been self-reviewed.

[ ] concurrent read
[ ] concurrent write
[ ] concurrent read and write

[ ] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods.
[ ] added or updated version, license, or notice information
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
[ ] added integration tests.
[ ] been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Coverage increased (+0.01%) to 67.885% when pulling f56ad572887f9fb6c52079166ac2ad69b985811a on revert_not_ready_fix_csv_pr into 66918f3f8e2cbae03fe2bfd4ecc56c7dadd79cbf on master.

I will revert the PR and let's find another way to solve the issue.


Async commands support

Hi there! This PR makes initial steps porting the current command system to asyncio. Some parts don't work correctly yet (like console.key.bind). And yes, I understand, that copying the same code in two different places is the last thing we want to do :) But after reading some documentation and stackoverflow answers, I understood, that dealing with sync and async code in one function isn't a good idea. So sometimes you can see two functions/methods, which do the same thing: one does synchronously, the other - asynchronously.
As you remember, my last PR provided pipes support. Now the main features of the language are more or less in the workable state, but the thing is our commands and types checking implementations aren't adapted to the ideas of these features. I will give you an example. Now we have such command
  console.choose.cmd Format export.formats
  console.command export.file {choice} @focus

Since we have new language features, we need to rewrite it like
console.command [
        export.file
        console.choose(Format export.formats()) @focus
]

And here 2 issues come:

console.choose must wait until a user makes a choice or closes an overlay. The previous version of this function used a callback for this, but the current version needs new approach. How to do that?
We want to call the command. We are calling call method from Command object and pass str arguments to it. String arguments will be checked for compilance, parsed and converted to some Python objects. The function corresponding to the command will be called with converted str arguments.
The thing is commands can be chained now console.choose(Format export.formats()) and any enclosing command returns some value as is (not necessary str) -> https://github.com/mitmproxy/mitmproxy/blob/master/mitmproxy/command.py#L105-L115 and outer command should do something with it. So, we have the situation, when console.choose is being called like console.choose(Format ['curl', 'httpie', 'raw']). The return of export.formats is a Python list, Format is a string. Type checking system will try to parse these arguments and convert them to some Python objects, but fail, because arguments must be strings to be parsed.

After long discussions there are two solutions for these two issues:

Let mitmproxy execute async commands.
Now you can define async command like:

@command.command("myaddon.acommand")
async acommand(self, arg1: SomeType) -> SomeType:
    ...

There are 2 ways to execute commands now: command_manager.execute and command_manager.async_execute.
command_manager.execute is needed for sync commands.
command_manager.async_execute is needed for async commands.
If we try to run async command using sync executor command_manager.execute, we will get ExecutionError exception. We also have AsyncExecutionManager, which tracks running commands.
AsyncExecutionManager will probably become a separate addon and get new commands for convenient running commands management.
When you call async command or the command, which has enclosing async command, recursive ParsedEntity object is created and traversed then.

Simplified check for the return value of enclosing command.

Briefly speaking, what this PR brings:

All default key bindings are rewritten according to the new language features;
basic async commands support;
simple async execution manager is provided;
minor changes like f-strings support.

We've already discussed the approaches here extensively on Slack. I think the summary is a) this is excellent, b) let's merge this to the language branch and rebase to master. :)

I think this looks ready to merge to me. We know that there are adjustments yet to come for the interactive features, and I'm happy for us to work towards that in master.


Implement vpx (VP8 and VP9) encoder

Requires libvpx.

Btw, the color seems to be off. But, I really don't mind it. This is definitely a good start! And, I'm sorry for the mess...

@lherman-cs fixed the pointer and the color problem. Please take another look.


[stable/rabbitmq-ha] vHost not found even though vHost exist in UI and is properly configured in chart

Describe the bug
Deploying the RabbitMQ or RabbitMQ-HA charts into a Kubernetes cluster (1.17.0) with multiple vhosts configured  (in my case 2 extra defined) deploys without error. You can see the vHosts in the UI and configuration of the rabbitmqctl command. However when you try and connect via AMQP too one the vHost you get a failure of "vHost (name of vhsost) not found" in the server log. The vHosts exist and all permission have been set and verified.
Version of Helm and Kubernetes:
helm version
version.BuildInfo{Version:"v3.0.3", GitCommit:"ac925eb7279f4a6955df663a0128044a8a6b7593", GitTreeState:"clean", GoVersion:"go1.13.6"}
kubectl version
Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.1", GitCommit:"d224476cd0730baca2b6e357d144171ed74192d6", GitTreeState:"clean", BuildDate:"2020-01-14T21:04:32Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.0", GitCommit:"70132b0f130acc0bed193d9ba59dd186f0e634cf", GitTreeState:"clean", BuildDate:"2020-01-27T21:11:27Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"linux/amd64"}
Which chart:
RabbitMQ and RabbitMQ-HA - Tried both
What happened:
Configured both and deployed. Verified vHosts were created with all correct users and permissions. However when connecting via AMQP the user is authenticated but then you see an error in the server log that the vHosts is not found. Ran the images in straight Docker and Kubernetes without the helm chart and everything works correctly.
I also tried different versions of RabbitMQ (3.8.2, 3.7.14, 3.7.24)  and all have the same failure in the server log when deployed via the Helm Chart.
What you expected to happen:
I expect the vHost to work when deployed via the chart.
How to reproduce it (as minimally and precisely as possible):
Install via Helm Chart with a vhost other than "/" defined and try and connect to the vHost via the AMQP. It will fail with error in the server log.
Anything else we need to know:
I am running this in AKS in Azure. But have tried locally as well with same results. Works perfectly if you just use the default vHost "/".

Hi @mrkcmo
Could you please share the commands you used to deploy the RabbitMQ chart and configure the vhosts? Please also share the exact values.yaml you're using in case you're overwriting the default one.
Thanks in advance

I packaged and deployed:
helm package (folder_name)
helm install rabbitmq (package_name) --namespace (namespace)
values.yaml.txt

Hi @mrkcmo
This is the values.yaml for RabbitMQ HA, isn't it? I am maintainer of the RabbitMQ chart. I am afraid I won't be able to help you with RabbitMQ HA

@juan131 I tried both and see the same issue just FYI.

Hi @mrkcmo
Could you please share the values.yaml you were using with the RabbitMQ chart? Please note that I don't need the whole values.yaml but just the values that you modified (instead of using the default ones)

For anyone else that runs into this issue I was able to resolve it. In the Celery broker URL you have to add the vhost name with two // instead of the normal one /.
IE:  broker = 'amqp://hostname//name_of_vhost'


Better startup performance

What
I've dropped most uses of innerHTML, as textContent is like 5x faster for these tiny text-only strings. The prevArrow/nextArrow are still using innerHTML, due to the inline SVGs. It'd be nice to avoid innerHTML here, but that's a larger refactor.
I've also removed the default parameters for createElement as the compiled version relied on arguments which isn't very performant in a hot path.
Results
On my macbook air, I'm seeing the times of build() go from ~9ms to ~2ms.
For the demo page, the full startup has gone from ~400ms to ~230ms.
So, let's average that out and say we're ~300% faster. 🔥
Seeing it
Here's a before and after trace: https://chromedevtools.github.io/timeline-viewer/?loadTimelineFromURL=https://www.dropbox.com/s/7238b2rphoof6j7/flatpickr-before.json?dl=0, https://www.dropbox.com/s/byyqvjqzqjj37ur/flatpickr-after.json?dl=0
Screenshot:

(You'll see the big forced layouts in positionCalendar.. It may be possible to avoid those, but luckily, it only hits during startup for the inline configuration.)

Coverage remained the same at 65.69% when pulling a5608e7de23b8421f7bab8c06d3391d3eb728a94 on paulirish:faster into 6d7366122a22c6ed3a35758e640d7d6842cc80e8 on chmln:master.

Hello Paul,
Thanks for the contribution!
Performance is one of the main, continuous goals of this project.
I'm also aware of a few other areas that need optimization, e.g. positionCalendar() in open() and its dependency on expensive getBoundingClientRect(). Those will be addressed in near-future releases.
Best regards.