[Improvement][tez] Optimize the method of obtain the vertex id.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

What would you like to be improved?
For now, vertex id is extract from vertex name. This way only support the vertex name like "Map 0", "Reduce 1", generally generated from hive.
For tez examples, the vertex name is arbitrary, so we can't get the vertex id. So we need a new way to get vertex id.
How should we improve?
No response
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

It is great, if can obtain vertex id throuth:
          int sourceVertexId = dag.getVertex(edge.getSourceVertexName()).getVertexId().getId();
          int destinationVertexId = dag.getVertex(edge.getDestinationVertexName()).getVertexId().getId();

The only one it modify lots of file, but it is ok.
but when could not get vertexid, eg:
int sourceVertexId = this.conf.getInt(RSS_SHUFFLE_SOURCE_VERTEX_ID, -1);

could we throw exception, then we could know something wrong, instead get -1 and wrong result.

It is great, if can obtain vertex id throuth:
          int sourceVertexId = dag.getVertex(edge.getSourceVertexName()).getVertexId().getId();
          int destinationVertexId = dag.getVertex(edge.getDestinationVertexName()).getVertexId().getId();

The only one it modify lots of file, but it is ok.
but when could not get vertexid, eg:
int sourceVertexId = this.conf.getInt(RSS_SHUFFLE_SOURCE_VERTEX_ID, -1);

could we throw exception, then we could know something wrong, instead get -1 and wrong result.

@lifeSo
assert is used to throw exception. You can see the below code.
    assert sourceVertexId != -1;
    assert destinationVertexId != -1;

And In fact, the vertex id must exists, so in general way, we will never throw exception.

sourceVertexId

Greate!
How about the assert check is in computeShuffleId() method.
Then users who call this methods do not assert check explicitly.

@lifeSo
That's a good idea, as only computeShuffleId use vertex id.
But just like the code show below. I check whether vertex id is -1, but the -1 is the default value of config. If we want to move assert to computeShuffleId, I think getInt also should move to computeShuffleId. How about this way?
    int sourceVertexId = this.conf.getInt(RSS_SHUFFLE_SOURCE_VERTEX_ID, -1);
    int destinationVertexId = this.conf.getInt(RSS_SHUFFLE_DESTINATION_VERTEX_ID, -1);
    assert sourceVertexId != -1;
    assert destinationVertexId != -1;


Update split to only split on spaces, so that newlines don't get removed

Useful for people who want to stream markdown
Thanks to @LukasMasuch for pointing out this solution
📚 Context

🧠 Description of Changes

Revised:
Insert screenshot of your updated UI/code here
Current:
Insert screenshot of existing UI/code here
💥 Impact

Size:

[ ] Small
[ ] Not small

🌐 References

[ ] Notion

Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

Thanks. I'll get the docstring edit paired with this then merge it.


revert: oauth parameter store change

Description of changes

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #10485 (d052d03) into master (085a7aa) will increase coverage by 0.00%.
The diff coverage is 52.96%.

@@           Coverage Diff            @@
##           master   #10485    +/-   ##
========================================
  Coverage   46.67%   46.67%
========================================
  Files         713      706     -7
  Lines       35383    35268   -115
  Branches     7171     7148    -23
========================================
- Hits        16514    16463    -51
+ Misses      17062    17013    -49
+ Partials     1807     1792    -15

Impacted Files
Coverage Δ

...vice-walkthrough-types/cognito-user-input-types.ts
100.00% <ø> (ø)

...udformation/service-walkthroughs/auth-questions.js
3.23% <0.00%> (-0.33%)
:arrow_down:

.../src/category-interfaces/category-override-base.ts
33.33% <ø> (ø)

packages/amplify-cli-core/src/cliConstants.ts
100.00% <ø> (ø)

...y-provider-awscloudformation/src/push-resources.ts
18.77% <0.00%> (-0.10%)
:arrow_down:

...y-provider-awscloudformation/src/resourceParams.js
13.88% <0.00%> (ø)

...ls/awscloudformation/handlers/resource-handlers.ts
14.85% <7.50%> (+0.14%)
:arrow_up:

packages/amplify-category-auth/src/index.js
16.04% <20.83%> (-0.18%)
:arrow_down:

.../amplify-category-auth/src/commands/auth/update.ts
65.57% <50.00%> (+1.16%)
:arrow_up:

...oudformation/utils/generate-auth-stack-template.ts
50.00% <50.00%> (+21.42%)
:arrow_up:

... and 11 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


{ errorType: 'UnauthorizedException', message: 'Permission denied' } when calling mutation from GitHub action

How did you install the Amplify CLI?
No response
If applicable, what version of Node.js are you using?
16
Amplify CLI Version
12.10.1
What operating system are you using?
linux
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes made
Describe the bug
I have a mutation query in my schema:
registerTenant(name: String, emailAddress: String, tenantName: String): Tenant @function(name: "plateletAddNewTenant-${env}") @auth(rules: [{allow: private, provider: iam}])

that I want to be able to call from a GitHub action. So far I've been able to set up permissions that allow the IAM account to call that mutation, but I'm getting this error:
{ errorType: 'UnauthorizedException', message: 'Permission denied' }
This is the policy I'm using for AppSync:
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": [
                "appsync:GraphQL"
            ],
            "Resource": [
                "arn:aws:appsync:*:<id>:apis/*/types/Query/fields/getTenantByTenantName",
                "arn:aws:appsync:*:<id>:apis/*/types/Mutation/resolvers/registerTenant"
            ]
        }
    ]
}

It seems like it can call the getTenantByTenantName query fine, but gets that error on the registerTenant call.
in amplify/backend/api/platelet/custom-roles.json I have the following (with my proper id):
{
    "adminRoleNames": [
        "arn:aws:iam::<id>:user/test-test.bloodbikes.cloud"
    ]
}

I use this on another API I have and get no issue when making calls to it using IAM.
I tested running the action with a full admin access policy attached to the IAM user but it was still denied, so it seems like the API is returning that permission denied error rather than it being a problem with the policy.
It's strange that no error is returned when using getTenantByTenantName, which is just a queryField added to an index, but the registerTenant which is a custom function throws that error.
type Tenant
@auth(rules: [
{allow: private, operations: [read]},
{allow: private, provider: iam, operations: [read]},
])
@model {
  id: ID!
  name: String! @index(name: "byTenantName", queryField: "getTenantByTenantName")
  referenceIdentifier: String!
  admin: User! @hasOne
}

Expected behavior
I expect the query to complete without a permission denied error.
Reproduction steps

Add a custom mutation to type Mutation with lambda function.
Create access keys and set IAM policy to allow running that mutation.
Set up GitHub action that calls the mutation.

This is the code I use in the GitHub action:
import * as core from "@actions/core";
import { Sha256 } from "@aws-crypto/sha256-js";
import { SignatureV4 } from "@aws-sdk/signature-v4";
import { HttpRequest } from "@aws-sdk/protocol-http";
import fetch, { Request } from "node-fetch";
import {
  RegisterTenantMutationVariables,
  GetTenantByTenantNameQueryVariables,
} from "./API";
import { registerTenant } from "./graphql/mutations";
import { getTenantByTenantName } from "./graphql/queries";

const request = async (queryDetails: { variables: any; query: string }) => {
  const apiURL = core.getInput("tenantApiUrl");
  const region = core.getInput("awsRegion");
  const accessKeyId = core.getInput("awsAccessKeyId");
  const secretAccessKey = core.getInput("awsSecretAccessKey");
  console.log("apiURL", apiURL);
  console.log("region", region);
  console.log("queryDetails", queryDetails);

  const endpoint = new URL(apiURL);
  const credentials = {
    accessKeyId,
    secretAccessKey,
  };
  const signer = new SignatureV4({
    credentials,
    region,
    service: "appsync",
    sha256: Sha256,
  });

  const requestToBeSigned = new HttpRequest({
    method: "POST",
    headers: {
      "Content-Type": "application/json",
      host: endpoint.host,
    },
    hostname: endpoint.host,
    body: JSON.stringify(queryDetails),
    path: endpoint.pathname,
  });

  const signed = await signer.sign(requestToBeSigned);
  const request = new Request(endpoint, signed);
  return await fetch(request);
};

const errorCheck = (body: any) => {
  if (body?.errors) {
    console.error(body?.errors);
    throw new Error(body?.errors[0].message);
  }
};

export const registerTenantQuery = async (
  input: RegisterTenantMutationVariables
) => {
  const response = await request({
    variables: input,
    query: registerTenant,
  });
  const body = await response.json();
  errorCheck(body);
  return body?.data?.registerTenant;
};

export const getTenantByName = async (
  variables: GetTenantByTenantNameQueryVariables
) => {
  const response = await request({
    variables,
    query: getTenantByTenantName,
  });
  const body = await response.json();
  errorCheck(body);

  console.log("aaaa: ", body?.data?.getTenantByTenantName?.items);
  return body?.data?.getTenantByTenantName?.items[0] || null;
};

Project Identifier
f97b80f7ee5ceef2a72f107f35e6d453
Log output

# Put your logs below this line

Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

Hey👋 thanks for raising this! I'm going to transfer this over to our API repository for better assistance 🙂


Got exit code<PHONE_NUMBER> (0xC0000005) from python demo

Hi there,
I try to exec demo with Python 3.9 on Windows, sometimes got unexpected exit, with code -1073741819 (0xC0000005) , that err from C shared lib I think, and that because of index out of range usually.
I'm not good at Golang and not founded the true reason from code, give me some advice to fix it please, thx.

Can you show me exactly what kind of errors are you getting? Just FYI these demos have been tested on Python2 and OpenCV2 so it might be related to the Python version also on which you are trying to run it.

Nothing exactly others, just response err code and exit. That err code correlate with out of range in my experience.
Python2 may working well, but Python2 has out of date now.

I'm aware about that, only that because I have ported the library to WASM I didn't updated the Python examples to run on Python3. But I have tried it with Python3 and OpenCV4 and sometimes just exited without printing any errors. That's why I asked if you could have shown the errors you got.

Only got this unuseful message, means:
Process has been exited, exit code is -1073741819 (0xC0000005)

I have tried on a MacOS with Python 3.9.1 installed and the demos are running, but strangely on Windows in most of the cases the application exits without showing any errors. I was trying to debug it and most probably is related to the data type transfer from Go to Python using ctypes.

I ran in pycharm with debug mode, and than got exit code. If running in cmd or powershell, that output nothing.

I'm closing this ticket, the issue is fixed now.


Add onboarding document

This PR adds the onboarding document https://docs.google.com/document/d/1SQ_qlkcplqhe8h6ONXdgBr7YUVbs4oRSj4ISl3gpLW4/edit?ts=5e4f0618# with some minor adjustments:

Mention the step registry rather than templates for e2e tests
Don't tell ppl to execute commands to view promoted images
Link to https://github.com/openshift/ci-docs/pull/7 for branch protection
Link to https://github.com/openshift/ci-docs/pull/9 for mirroring to an external registry

Ref: https://issues.redhat.com/browse/DPTP-1571

/retest

/retest

/retest


Rename public facing text from GeoApp to Minerva Taxi.

Later, we should go through and rename all internal application hooks to a short form of that as appropriate.

Thanks @manthey


subscription css: Fix cut off bottom border for subscriber list.

Overview
On some specific screen height, the .subscriber-list table will have its bottom border cut off by the .subscriber_list_container wrapper div around it.
This PR attempts to fix that issue by formatting the bottom border of the .subscriber_list_container wrapper div to act like the tables bottom border.
Screencast from 07-02-2024 02:16:25 PM.webm
git grep "subscriber_list_container":

Screenshots & video:

Description
Before
After

Create Channel

Channel with 3 subs

Channel Setting with 13 subs

Group Settings

Dark theme:

CZO discussion: here
Fixes: https://github.com/zulip/zulip/issues/30677.

Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@zulipbot add "buddy review"
@kennethnrk - Could you please help review this one too?
@sbansal1999 - Satyam, do you want to do mentor review in parallel for this one? I think you raised this issue in the original CZO discussion.

@PieterCK LGTM, I think this is the correct approach by adding the border to the container instead of the individual tr. I would suggest squashing both the commits into a single commit as they are not independent.

@zulipbot remove "buddy review"

Thankyou kenneth, I'll consider that for the next round of review. @zulipbot add "mentor review"

This solution looks very rational, merged, thanks @PieterCK!
FWIW, I found the separation of commits helpful for reading, though probably it'd have been fine to squash them in this particular case as well.


split_code param needed

Hi
I see there is an open pr to get split_code in as an option. I am currently also in need of that option.

https://paystack.com/docs/payments/accept-payments/

Fixed in the latest release


Move kerberos dependencies to optionalDependencies in package.json

Making kerberos and related modules optional is useful for developers who don't need Kerberos authentication (the majority don't) and don't have the environment to support it. More info:
https://docs.npmjs.com/files/package.json#optionaldependencies
The kerberos module includes native C++ code and is a more complicated dependency to get working, more info here:
https://www.npmjs.com/package/kerberos
@kcoleman-marklogic brought this issue to our attention.
@ayuwono adds:
There are several dependencies need to be installed on the machine, I can name:
Node-gyp
Python
Glibc-devel 64-bit (sudo yum install glibc-devel.x86_64)
And I think it has different dependencies on windows machine too

This might end up being a useful reference to include in the README, as it does talk about the deps. Silly me, not to have looked there previously.
https://www.npmjs.com/package/kerberos

I have officially given up on getting Node.js to npm install on Windows until Kerberos slinks off to the corner where it belongs.
Heaven help the poor user who actually needs our API + Kerberos on Windows. I've wasted most of this week trying to get our install working on Windows, without success. I wound up in Windows SDK hell, and am now worse off than when I started.
We won't have updated JSDoc for the API on pubs until this issue is addressed, which I realize is a minor matter compared to the potential user pain. I mention it only in case you go looking for the docs and wonder why they are not up to date.

@kcoleman-marklogic hoping the #277 merge addresses your install issues. @ehennum thanks for the help!

Here is what I found:
npm install coughs up a bunch of errors because it still tries to install the optional deps by default. However, the install succeeds now since the failed dep is optional.
npm install --no-optional completes without error since it skips over the Kerberos stuff altogether.
If that's the desired usage, then we're good to go. I do think it is potentially alarming/confusing to see those errors, even though the install succeeds. It looks just like when it fails. :-/ It'd be nice if Kerberos was somehow opt-in instead of just skippable, but I'm not sure npm puts those tools in our hands.

P.S. I also made another attempt to get the kerberos install working today, just because it bugs me to be defeated by an installer, but I was beaten again. I got node-gyp to install finally, but Kerberos still won't build.
I suspect a conflict between the bundle of tools node-gyp points Windows users to (which is how I finally got a successful node-gyp install), and what Kerberos wants. One seems based on VS 2015 and the other recommends only VS 2010. Unfortunately, I haven't found any chatter about the error I'm getting, so I'm going to slink back to my corner again. For now.

Verified that npm install --no-optional works fine and not installing kerberos
It seems that it's the only way to omit the kerberos installation. We should document this clearly.

This issue has re-emerged, because --no-optional is overridden by npm shrinkwrap, which was added to the project in May 2017. This means that if I run npm install marklogic --no-optional, I still get kerberos.
I can workaround this with adding --no-shrinkwrap, as in npm install marklogic --no-optional --no-shrinkwrap, but that means throwing away the locked-down dependencies. For a library that includes this one, it might mean throwing away shrinkwraps for other dependencies as well, if I want to run a single command to install everything.
My suggestion is that you remove kerberos from the generated shrinkwrap. This was suggested in this comment: https://github.com/npm/npm/issues/2679#issuecomment-150084700
Experimenting locally with a library that includes this library as a dependency, I found that removing these lines from npm-shrinkwrap.json (and also from package.json, where they get included when this library is published) meant that:

npm install --no-optional did NOT include kerberos in my node_modules, and
npm install DID include kerberos, though presumably not necessarily the shrink-wrapped version.

(For context, I need this functionality in order to avoid a Python dependency when distributing a reusable Node middle tier.)

@patrickmcelwee, thanks for pointing this out and suggesting a fix. I will investigate editing the npm-shrinkwrap.json.

Confirming what @patrickmcelwee describes...
Run in current project (v2.1.1): npm install --no-optional
kerberos IS installed (when it shouldn't be)
Update project by removing kerberos settings (lines 77-82) from npm-shrinkwrap.json
Run in updated project: npm install --no-optional
kerberos IS NOT installed (so the above update fixes the problem)
Run in updated project: npm install
kerberos IS installed (as it should be)


[msmart.base_device] Network error: Transport is closing or closed.

Toshiba AC - getting this error:
[msmart.base_device] Network error <IP_ADDRESS>:6444: Transport is closing or closed.
The AC "comes and goes" from Home Assistant
If I run a continuous PING from HASS, connectivity is good on the LAN (on local network).
Seems like some sort of timeout / timer conflict....

Likely duplicate of #187, #137, #92, #44.
Hi, I can't help without full debug logs, but you probably need to set the Maximum Connection Lifetime on your device. A value of 90 is common.

Closing as duplicate. If you feel otherwise please re-open the issue.


[REVIEW] suchitragiri

GitHub Profile Link
https://github.com/suchitragiri

Hey @SUCHITRAGIRI , awesome profile.
I had made a pull request to your GitHub readme.md please consider that.

Wow 👀 amazing profile! I liked it very much! 😲
I have made a pull request in your repository for
some minor improvements in the README.md file. 🙂
Thank you for sharing your amazing profile with the community! 🚀

Looks good, reviewed on live stream, some suggestions...

animated svg doesn't work well on safari
recent blog posts could be automated with a GitHub action
maybe do some more contributions to open source


WIP - Error handling

Handler for pretty printed warnings and errors in console in development mode.

@mxstbr @nikgraf rough WIP PR. Looking for comments on implementation and the api. Feels a bit verbose (though less so than my last attempt).

Screenshot:

I like it!

I like it too @bhough - let's do it 👍

Great, I'll get this initial PR cleaned up and passing CI so we can merge it, and I'll start working my way through converting errors over in a separate PR.

Can we make sure errors are stripped out in prod?

@mxstbr @nikgraf this is good to go. Confirmed that errors will be stripped in production if wrapper properly. Will open a new branch to start implementing first on existing errors, then a second one that start getting more error coverage.

@mxstbr @nikgraf just bumping this so we can get it merged. Currently working on a separate branch to handle wrapping existing messages that depends on this.

Closing in favor of #136


feat: improve linter

rename settings (remove suffix Num)
remove the filename from report messages
use standard analysis tests

Thanks for your contributions!


Feature request: more complete git integration

I've tried out this new editor and find it very promising. Looking at the git integration, here's a list of features that would add a ton of usefulness if being integrated into the git screen: (I hope I didn't overlook something)

add git pull --rebase additionally to git pull
add keyboard shortcuts and (easy reachable) buttons to quickly stage and unstage lines and chunks in diff view
add git log, project wise, branch wise and file wise with easy to view commit file changes

For record, git log currently provided by: https://marketplace.visualstudio.com/items?itemName=donjayamanne.githistory

Most of these things are now in, keyboard shortcuts are customizable, etc. There's another issue for git log (history).


change default goal to goal_pose and not just in default rviz

#455 updated the tool name, registration, default rviz files and documentation.
However the migration guide for Eloquent isn't technically correct (https://index.ros.org/doc/ros2/Releases/Release-Eloquent-Elusor/#rviz). The tool name changed, true, and the topic was changed for the default.rviz file. This is also where /move_base_simple/goal was defined from goal. There never was /move_base_simple/goal in the rviz tool file.
If this is what we're going to say in the migration guide, we should change the actual default hardcoded in the tool to be goal_pose, rather than just a configuration change in the rviz file.
I tried to think of a way to explain this better for the migration guide and decided that its just easier to align with it. If that's what people walked away thinking that PR did exactly, I should follow that.

I agree with your statement. In fact, it wasn't until that was brought to my attention that /move_base_simple/goal wasnt in fact the hardcoded default in the code. It effectively is if you start your custom config from the default config.
I don't think any additional clarification is required. This change will make the updates required so that no additional clarification is necessary. Otherwise, I might have to reword it.


[June] Curation Workflow Tracking

This ticket tracks curation workflow progression.
Note: It is possible for work to take place simultaneously in the three sections with overlapping periods, allowing curation workflows for different months to coincide.
1. Curation and Annotation

[x] Run Pubmed crawler to generate PublicationView manifest [205 publications generated, long sprint anticipated]
[x] Send Amber and Jineta a copy of the PublicationView manifest from latest crawl to review for MC2 Center Newsletter publication highlights
[x] Send Amber "News from CCKP" for MC2 Center Newsletter
[ ] Annotate publications in PublicationView manifest [In progress]
[ ] Generate ToolView and DatasetView manifests based on PublicationView manifest
[ ] Run the automated curation workflow to upload publications, datasets and tools [This includes splitting manifests, processing and validating manifests, generating target synapse IDs for upload, schema updates, upload to synapse and (in progress) a validation check for uploads)
[ ] Generate UNION tables
[ ] QC of staging tables
[ ] Performing automate portal sync to CCKP
[ ] Validate data on the CCKP

Status check [Plan to report numbers for each category following pubmed crawl]:

[ ] Publication upload [ ]
[ ] Tool upload [ ]
[ ] Data set upload [ ]

2. Data model

[ ]  Update valid values in the data model and build
[ ]  Generate templates from new model
[ ]  Release new model version [no changes, no release]
[ ]  Update DCA config [no changes, no update]

3. Contributor Engagement

[ ] Emails to contributors (by grant) with info on newly added manifests, link to project, DCA, and instructions on review, annotation, validation, and submission, as applicable
[ ] Jira Help Desk ticket tracking, review, triage, with data model updates, as needed (TBD)
[ ] Annotation gap-filling of DatasetView and ToolView manifests

24-6 close out: aiming to upload May, April and June by mid 24-7/8 sprint. Will likely include a data model release during mid sprint

mid-sprint:

Pending Annotations still growing? @jaybee84  Check which resources have this. Not that "Pending Annotations" was historically implemented with publications that were not yet open access. But these are now also pushed to portal as an incentive for adding annotations to these resources.
resume emails to contributors with existing documentation. Maybe targeted engagement to certain contributor

Publications: pending annotation for tumor type + assay (as discussed in the meeting mostly due to restricted access, but some on open access)
Datasets : pending annotations for tissue


No Auth Provider found for name "oidc"

I encountered an issue while using the kubectl-pods_on plugin, where it fails with the following error message:
F1021 19:11:43.839135    3675 main.go:104] failed to create clientset: no Auth Provider found for name "oidc"

kubeconfig user:
- name: <email>
  user:
    auth-provider:
      config:
        client-id: <client-id>
        client-secret: <client-secret>
        id-token: <id-token>
        idp-issuer-url: <idp-issuer-url>
        refresh-token: <refresh-token>
      name: oidc

It seems the plugin is unable to recognize the oidc authentication provider. This configuration works correctly with kubectl and other plugins, but fails with this one.
Plugin version: v0.1.0

That's weird. I assumed client auth plugins (exec and oidc) no longer need to be imported in plugins. I suspect you'll hit this in many other kubectl plugins (beware).
I can fix it, it's fairly easy to.

It’s interesting because I use other kubectl plugins like kubectl-foreach and kubectx, and they work perfectly fine with my kubeconfig setup. This issue seems isolated to the kubectl-pods_on plugin specifically.

Ah those usually shell out to kubectl; not use the client-go client.


How can I attach to electron window?

I test application which consists of standalone electron windows. Can I attach to electron window using spectron?

You can
this.app = new Application({
path=<>
});

Good idea :)))) But in my case i dont have app path. Window already opened and i need attach to open window.

If you have more than 1 window, you can select any particular window. return this.app.client.getWindowCount()
Also
it('Focus on window',function () {
this.app.client.windowHandles()
.then((handles) => {
const windowA = handles.values[0];
});
});

Hi @sahana2610. I found the way how to do it. Look into this link https://github.com/BorisOsipov/chromeless it's fork with "patch" which give a chance to attach to standalone electron windows.

@DenisChulkov : Thank you.  My electron app starts when I run the script in command line. I cannot make my tests run this script. Is there any way I can point out my test framework to this electron application without starting it through test?

@sahana2610 I handled electron window by title. You just need to investigate this fork and adapt it for your purposes.

@DenisChulkov Can you please give me a sample code of how you pointed it to the electron window by title.

Clone this fork. You can find sinple test as example inside.
чт, 7 июн. 2018 г., 16:29 sahana2610<EMAIL_ADDRESS>
@DenisChulkov https://github.com/DenisChulkov Can you please give me a
sample code of how you pointed it to the electron window by title.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/electron/spectron/issues/255#issuecomment-395420439,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGlhRpo6rYoCotf7ovg_B05OB84vR-4fks5t6SrEgaJpZM4RAlQN
.

@DenisChulkov I am not able to find the link to the fork in your previous comment.

@DenisChulkov I went through the examples. I am still not able to figure out how you attached using the electron title. Did you skip the chromeless.goto and do like this:
const chromeless = new Chromeless()
await chromeless.click('[title="Existing browser title"]')

@sahara2610 Also, you need debug port in application. If you dont have
debug port in your application you will not able to attach to the window.
вт, 26 июн. 2018 г. в 17:20, sahana2610<EMAIL_ADDRESS>
@DenisChulkov https://github.com/DenisChulkov I went through the
examples. I am still not able to figure out how you attached using the
electron title. Did you skip the chromeless.goto and do like this:
const chromeless = new Chromeless()
await chromeless.click('[title="Existing browser title"]')
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/electron/spectron/issues/255#issuecomment-400326698,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGlhRhDH2KZ4dul4z9sW7eIW9f3D7f_aks5uAkNJgaJpZM4RAlQN
.

@DenisChulkov Thank you. Will try doing that

Hello, said code sample is no longer available, what did you do to enable attaching Spectron to existing electron windows?


tech spec for monorepo POC (GSI-659)

See document.

Thanks @TheByronHimes, I fully agree and added the priorities you mentioned to the document.


Rename option retry to retries

There usually provided values greater than 1

Don't really think we should do this. retry looks ok, you can read this like retry: 3 (times)

vote for retry as it's more easy to write


Update README with correct clone command

@8ball030 can you confirm git clone git@github.com:8ball030/AutonomousHegician.git is the correct clone command?
I believe you should use: git clone https://github.com/8ball030/AutonomousHegician.git
The current command doesn't work due to access right, second one works fine.

Should be fixed in pull request #44, the correct form is git clone git@github.com:8ball030/AutonomousHegician

@andreiaugustin is correct, closing with this


Add IUST School

We appreciate if you let our student use you products.
I'm an assistant professor at school of computer engineering.
The courses I teach: http://webpages.iust.ac.ir/sauleh/teaching/
My email<EMAIL_ADDRESS>Here is the list of faculty members at our school: http://ce-inter.iust.ac.ir/page/54/Faculty-Members. If you click on any of their profiles, you can see their email at iust.ac.ir.
Please do let me know if there is anything else needed.
Sincerely,
Sauleh

@sauleh Thank you for providing us with your email address. I sent an email to you with more details.
I am sorry, I have to close this request.

@sauleh Thank you for providing us with your email address. I sent an email to you with more details.
I am sorry, I have to close this request.


HtmlConverter: Fix horizontal rule replacement.

Replace full line with horizontal rule.  (Currently only the space and 30+ - are replaced)
Accept "Scissors" (%<, >%, 8<, >8).  Scissors are used by, e.g., git
when formatting patches.
Add unit tests for horizontal rule replacement.

@cketti Do we want this - it should pretty easy to rebase

Yes. It feels wrong to do this after the conversion to HTML, though.
Also, it looks like a single dash will be replaced, too. I'm not sure if we want to go there.

Created issue #2259 for the functionality. Closing this PR.


Preload bundles do not support modules defining global variables

In case a module is defining a variables in global scope, such as (only a selection):
sap/ui/thirdparty/blanket.js
sap/ui/thirdparty/flexie.js
sap/ui/thirdparty/hyphenopoly/hyphenEngine.asm.js
sap/ui/thirdparty/mobify-carousel.js
sap/ui/thirdparty/require.js
sap/ui/thirdparty/sinon-ie.js
sap/ui/thirdparty/sinon-server.js
sap/ui/thirdparty/swipe-view.js
sap/ui/thirdparty/zyngascroll.js

Building a preload bundle will result in the variables not be defined on global scope any longer, as the preload generation will wrap the module into a function itself, thus rendering the globally defined vars as function scoped vars instead.
Expected Behavior
Building a preload bundle with a depdendency to e.g. sap/ui/thirdparty/require should still expose requirejs, require and define on global scope, just like loading the application w/o a preload bundle.
Current Behavior
Global variables are not exposed, this could lead to side effects with other modules.
Context

UI5 Module Version: 1.5.1

Affected components (if known)

[X] ui5-builder
[ ] ui5-server
[ ] ui5-cli
[ ] ui5-fs
[ ] ui5-project
[ ] ui5-logger

After looking deeper into it, this is a bit different than originally expected. The builder already can handle modules with global vars correctly and it contains code to identify them.
But in case raw module info is maintained in .library files, this info supersedes the analysis (which is even skipped then). On the other side, raw-module info was never meant to be complete, it only should enhance the analysis results.
The raw module info has been given priority over the analysis step when support for standard AMD APIs was added (I can't reference the corresponding commit as this was implemented in an internal repo before going open source. But the code is here). The analysis of standard AMD bundles caused issues when the embedded modules are not available to the UI5 tooling. This approach should be revised so that the raw-module info and the analysis results can be  merged again. This will fix the issue reported here.

Hey @codeworrior! Thanks for the in-depth analysis and the quick solution, as always! =) Looking forward of this beeing merged!
I tried building with the fix you submitted and got quite a verbose log output (I'll send it to you the logs privately, as they contain some internal information). Hope this helps! Thanks again!


feat: support experimental.typedPages

🔗 Linked issue

#2109
#2516

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

warning
In its current state this PR introduces breaking (type) changes

Resolves #2109
Resolves #2516

This works partially, as the generated routes are localized the autocompletion expects suffixed names and prefixed paths, but the NuxtLinkLocale component can be used without. As you can see here:

📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Not sure if this is could be useful for you, but I used this lately to get all unsuffixed route names:
import type { RouteNamedMap } from 'vue-router/auto/routes';

type ValidRouteName = {
  [K in keyof RouteNamedMap]: K;
}[keyof RouteNamedMap];


rust-analyzer type hints are colored invasively

when using rust-analyzer with the most recent theme update, the type hints stand out a lot due to whatever palette they're picking from (i will say i have no idea how plugins or themes work so not sure how feasible changing this is).
default vscode theme with rust-analyzer:

gleam theme without rust-analyzer:

gleam theme with rust-analyzer:

how's this? :)

very nice!


Question - is there a way to read a versioned secret ?

Hi is there a way to read versioned secret such as mentioned here ?
I couldn't see it in the docs. I would appreciate if it possible to provide me a link to the doc and if not I would like to change this to a feature request.
thank you

As far as I understand, there is still no support for the v2 KV engine in node-vault, which is the KV engine that supports versioned secrets; I believe that #82 is the longstanding attempt to get support added for it.


Allow reuse of displays started by other users

Headless provides more than just the automatic launching of an Xvfb
process, it also provides useful screenshot and vidcap features. It
would be nice to be able to use these features even when reusing an Xvfb
display that's managed by another user.
With this change, reuse of another user's display will be allowed if a
display was explicitly given and reuse is explicitly allowed.
fixes #48

Ping!

The main change here is using Process.getpgid instead off Process.kill 0 to check if the process exists, right?

@leonid-shevtsov Basically, yeah. The behavior of Process.kill seemed confusing with regards to processes owned by other users, so it made sense to me to use Process.getpgid instead. I also sought to make these checks clearer (explicit) by separating them from the concerns of read_xvfb_pid.

OK, thanks, merging & releasing this.


No such file: data/cityscapes/gtFine/train/bremen/bremen_000149_000019_gtFine_labelTrainIds.png

I manage cityscapes data dir structure as Prepare data in readme. But, raise an error of not find the file.
I find that file path has been changed in BaseDataset, it add "gtFine_labelTrainIds.png" into file path and this cause error to occur.
What should I do to fix the bug? Thank you!

Hi, how about data/cityscapes/gtFine/train/bremen/bremen_000149_000019_gtFine_color.png? Does this file exist?

Yes, it does exist

Please refer to this link or this link, and convert your RGB mode labels to GTAY mode may helps.

Ok, thanks. I will try it first.

Please refer to this link or this link, and convert your RGB mode labels to GTAY mode may helps.

Hi, thanks for the guidance. I use the code to build up *_labelTrainIds.png files. But the supervised training with the released repo produces a really poor performance, e.g., 744 label, reported: 74.43, reproduced: 63.81.
About converting RGB mode labels to GTAY mode, I do not known where should I make a change. Do you mean change the img loader?
Looking forward your help, many thanks~

If _labelTrainIds.png files are built, there is no need to change img_loader.
As for the poor performance for supervised baseline, did you use sh eval.sh to evaluate the performance?
All results for Cityscapes should be evaluated in a slide window manner using eval.sh.

If _labelTrainIds.png files are built, there is no need to change img_loader.
As for the poor performance for supervised baseline, did you use sh eval.sh to evaluate the performance? All results for Cityscapes should be evaluated in a slide window manner using eval.sh.

Hi, thanks for the response. I have tried to run eval.sh and obtain 67.66 mIoU on 744 label setting which still heavily lags behind the reported number (74.43).
Since I never change the main parts of the supervised training and evaluation codes, the poor performance should attribute to the building up of *_labelTrainIds.png files. Currently, I use this code to create these files. Could you please help me to have a double check if this is a correct solution for dataset preparation? Or do you have any suggestions for such a bad result on the supervised baseline? Thanks a lot

How about try downloading Cityscapes here?

How about downloading labels here

How about downloading labels here?

Hi, thanks a lot. I will have a try and give you a response ASAP.

Hi, I have using the released gt label to rerun the supervised training on cityscapes and the obtained results are as follows

label num
1/16 (186)
1/8 (372)
1/4 (744)

reported
65.74
72.53
74.43

reproduced
64.04
68.12
73.97

it seems that the released gt label solves the problem mentioned above, but there is still a performance margin to the reported one especially for the 1/8 setting (the results are obtained by running eval.sh). I wonder if it is because the optimization randomness or anything else? Look forward your reply, thanks a lot.

Could you provide the config.yaml when training under 1/8 partition protocol?

Hi, sorry for the late response, the config used for 1/8 setting is listed below (data_root is changed to adapt to local path)
dataset: # Required.
  type: cityscapes
  train:
    data_root: semantic_seg/cityscapes
    data_list: ../../../../data/splits/cityscapes/372/labeled.txt
    flip: True
    GaussianBlur: False
    rand_resize: [0.5, 2.0]
    #rand_rotation: [-10.0, 10.0]
    crop:
      type: rand
      size: [769, 769] # crop image with HxW size
  val:
    data_root: semantic_seg/cityscapes
    data_list: ../../../../data/splits/cityscapes/val.txt
    crop:
      type: center
      size: [769, 769] # crop image with HxW size
  batch_size: 4
  n_sup: 372
  noise_std: 0.1
  workers: 2
  mean: [123.675, 116.28, 103.53]
  std: [58.395, 57.12, 57.375]
  ignore_label: 255

trainer: # Required.
  epochs: 200
  start_epochs: 0
  eval_on: True
  optimizer:
    type: SGD
    kwargs:
      lr: 0.01  # 4GPUs
      momentum: 0.9
      weight_decay: 0.0005
  lr_scheduler:
    mode: poly
    kwargs:
      power: 0.9

saver:
  main_dir: output/semi_seg/U2PL/city/372/sup_bs4_ep200
  auto_resume: False #True
  snapshot_dir: checkpoints
  pretrain: ''

criterion:
  type: ohem
  kwargs:
    thresh: 0.7
    min_kept: 100000

net: # Required.
  num_classes: 19
  sync_bn: True  # !!! debug !!!
  ema_decay: 0.99
  aux_loss:
    aux_plane: 1024
    loss_weight: 0.4
  encoder:
    type: u2pl.models.resnet.resnet101
    kwargs:
      multi_grid: True
      zero_init_residual: True
      fpn: True
      replace_stride_with_dilation: [False, True, True]  #layer0...1 is fixed, layer2...4
  decoder:
    type: u2pl.models.decoder.dec_deeplabv3_plus
    kwargs:
      rep_head: False
      inner_planes: 256
      dilations: [12, 24, 36]

I further run the U2PL on cityscapes and the results are as follows (all results are obtained with eval.sh)

label num
1/16 (186)
1/8 (372)
1/4 (744)
1/2 (1488)

reported
70.30
74.37
76.47
79.05

reproduced
70.52
72.35
75.79
78.61

It seems that the result on 1/8 setting is also worse than the reported one and the corresponding config is as follows
dataset: # Required.
  type: cityscapes_semi
  train:
    # data_root: ../../../../data/cityscapes
    data_root: semantic_seg/cityscapes
    data_list: ../../../../data/splits/cityscapes/372/labeled.txt
    flip: True
    GaussianBlur: False
    rand_resize: [0.5, 2.0]
    #rand_rotation: [-10.0, 10.0]
    crop:
      type: rand
      size: [769, 769] # crop image with HxW size
  val:
    # data_root: ../../../../data/cityscapes
    data_root: semantic_seg/cityscapes
    data_list: ../../../../data/splits/cityscapes/val.txt
    crop:
      type: center
      size: [769, 769] # crop image with HxW size
  batch_size: 2  # 1 for debug
  n_sup: 372
  noise_std: 0.1
  workers: 2
  mean: [123.675, 116.28, 103.53]
  std: [58.395, 57.12, 57.375]
  ignore_label: 255

trainer: # Required.
  epochs: 200
  eval_on: True
  sup_only_epoch: 0
  optimizer:
    type: SGD
    kwargs:
      lr: 0.01  # 8GPUs
      momentum: 0.9
      weight_decay: 0.0005
  lr_scheduler:
    mode: poly
    kwargs:
      power: 0.9
  unsupervised:
    TTA: False
    drop_percent: 80
    apply_aug: cutmix
  contrastive:
    negative_high_entropy: True
    low_rank: 3
    high_rank: 20
    current_class_threshold: 0.3
    current_class_negative_threshold: 1
    unsupervised_entropy_ignore: 80
    low_entropy_threshold: 20
    num_negatives: 50
    num_queries: 256
    temperature: 0.5

saver:
  main_dir: output/semi_seg/U2PL/city/372/u2pl_bs2_ep200
  auto_resume: True
  snapshot_dir: checkpoints
  pretrain: ''

criterion:
  type: ohem
  kwargs:
    thresh: 0.7
    min_kept: 100000

net: # Required.
  num_classes: 19
  sync_bn: True
  ema_decay: 0.99
  aux_loss:
    aux_plane: 1024
    loss_weight: 0.4
  encoder:
    type: u2pl.models.resnet.resnet101
    kwargs:
      multi_grid: True
      zero_init_residual: True
      fpn: True
      replace_stride_with_dilation: [False, True, True]  #layer0...1 is fixed, layer2...4
  decoder:
    type: u2pl.models.decoder.dec_deeplabv3_plus
    kwargs:
      inner_planes: 256
      dilations: [12, 24, 36]

Have you reproduce the results for 1/8 spilit under a fully-supervised manner? I notice that your latest question was about semi-supervised settings.
Maybe you could try different random seeds since the config.yaml seems to be correct.
By the way, what kind of GPU, and versions of CUDA and PyTorch you used for training?

Hi, the result of 1/8 split under the fully supervised setting has been presented in the past post.
The results of semi-supervised setting are posted because I just found the poor performance also happend on the 1/8 setting on U2PL.
The results are obtained under the following env

GPU: Tesla V100(32G)
CUDA: 10.2
PyTorch: 1.7.1

Hi, we fix a bug in lr for SupOnly manner.
Please fetch the latest code and try it again~

Hi, @HeimingX
We have re-trained our SupOnly baseline for 1/8 partition protocol on Cityscapes after fixing the bug.
The performance achieves 72.73 after eval.sh.

Hi, thanks for the prompt response.
I also re-run the SupOnly on 1/8 partition on cityscapes (lr bug is fixed) and obtain 69.89 after eval.sh, it is so strange...

How about try using Pytorch 1.8.1 with CUDA 11.2?
I have no idea about why you got such poor performance..........

Hi, @HeimingX
Here is the log of training SupOnly baseline under 1/8 partition. Hope it will help you~

Hi Haochen, thanks for the nice help and I will have a check.

Hi, @HeimingX
Maybe you could try using GTs here, since dataset might be the only difference.

Thanks, I will have a try.
Cheers

Hi @HeimingX
We find that we have uploaded the wrong split for 1/8 Cityscapes, please try it again.

Hi, @Haochen-Wang409
Thanks for the update, I will have a try.


Manually retry LWT statements during queue ops

Previously, the session's default retry policy would throw an exception if the statement encountered a timeout.

https://ocd.appscale.com:8080/job/Daily Build/3073/

https://ocd.appscale.com:8080/job/Daily Build/3106/
The hawkeye failures were connection timeouts.
https://ocd.appscale.com:8080/job/Euca-Faststart/970/

https://ocd.appscale.com:8080/job/Daily Build/3123/


Nullability: Study how zero values are kept in modified fields

istructs.ICUDRow.ModifiedFields

colclusion: ICUDRow.ModifiedFields() does not iterate over emptied field


IDE does not recognize Artisan Facade

PhpStorm 2016.2.2
Laravel 5.1.45
Autocompletion works fine for Route, Session, View facades. Autocompletion does not work for Artisan facade.
Am I missing something?

@barryvdh old issue, outdated versions, works for me locally when I added it to config/app.php aliases => I vote for closing the issue :}


removed release of the node's dlls

@dangershony I think it should be generic to every butting that directly calls the API and waits for it to respond. There will be scenarios when the API will not respond right away for any reason, even if it's a quick API call.


adding proper vagrant ignore

to: @chunyong-lin
cc: @airbnb/streamalert-maintainers
Changes

ignoring /.vagrant instead of /vagrant

Coverage remained the same at 96.609% when pulling 659aa62c307d2e263af75e812163a3f6c0ca9e4b on ryandeivert-git-ignore-update into 97be7284b17e235eed80f1e830223ebe61c6ba71 on release-3-0-0.


Broken links in new GitHub App checks / results

One of the links in the new GitHub Apps UI is broken:
https://github.com/cfengine/core/pull/3646/checks?check_run_id=117645973
The analysis for the merge commit was not successful. For more information, see the build and analysis logs on LGTM.com.
The other link, "View more details on LGTM.com" works.

@olehermanse thanks for the report.
The link you provided is to a check that now seems to be succeeding. If you could find another build that's failing with the same error then that would be useful. It seems though that we're using site-relative lgtm urls and forgetting to add the lgtm.com domain in those links (from what I can tell by your report). In the meantime I've opened an issue internally to track this.
(for future reference, problems with LGTM (rather than QL) should probably be reported on our forum)

We found other instances of this problem, and fixed it internally :)


Ego4d dataset

Thanks for sharing the code of this great work. I want to ask where can I find the train800k.json file of Ego4d dataset? Do you use the Ego4d v1 or v2?

Hi,
Ego4D does not provide a file named "train800k.json." We sampled 800k video clips ourselves from the original Ego4D (V1) dataset. This process is the same as what was done for GR-1.

Hi,
Ego4D does not provide a file named "train800k.json." We sampled 800k video clips ourselves from the original Ego4D (V1) dataset. This process is the same as what was done for GR-1.

Could you provide the script to generate the json?

I apologize. I used the same script as in GR-1, which hasn't open-sourced the data processing script. As a result, I cannot release it without official authorization.


set_security() does not save jenkins state

Resolves #223.

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

this bug still exists in jenkins 2.19.4 ? any recommendations ?


Clarify filter registration

Hi, I successfully registered markdown/coffeescript filters with
import coffeescript
import markdown
pyjade.compiler.Compiler.filters['coffeescript'] = lambda x,y: coffeescript.compile(x)
pyjade.compiler.Compiler.filters['markdown'] = lambda x,y: markdown.markdown(x, output_format='html5')

Is this the correct way, is there an API I'm missing?
You might consider registering these two if the libraries are available.

Could you give an example please how you would now register coffeescriptand markdown. That would be great. Thanks.


Get tut docs compiling for fs2/cats. Still missing pieces.

This task is incomplete, but I wanted to get a PR in to get feedback on some questions and places where the code is not working. I'll put comments in the code in the relevant places.
Also, I still need to proof the results to make sure the text makes sense for cats and compare the output to the scalaz versions. There are also links to documentation for scalaz that should probably be updated.
For streaming.md, there are numerous changes required for fs2 for the "putting it all together" example. I'm pretty much learning fs2 as I go, so this might take me awhile to figure it all out. It would be fine with me if someone with more knowledge updated this file for cats. I can continue working on it, but I know this documentation has become more pressing.

 Will get this into a working state and finish up the little snags.

Works for me.

@toddburnside I've got toddburnside/http4s#2 That should get this PR in order.

@ChristopherDavenport You're welcome, though it seems I left quite a bit for you today. Thanks for picking it up. In retrospect, it appears this was "mostly" low hanging fruit. But I few bits required a giraffe.


Adding tests to verify replication with different versions of BlobId behaves correctly

This PR added test to mock a scenario where replication with different versions of BlobId on local and remote hosts. The intention is to ensure that different combinations of BlobIds as well as messages are transformed and replicated as expected.
No code changes in production code, only for testing.

Codecov Report

Merging #1085 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master   #1085      +/-   ##
===========================================
- Coverage     68.65%   68.6%   -0.05%
+ Complexity     4833    4830       -3
===========================================
  Files           382     382
  Lines         30512   30512
  Branches       3890    3890
===========================================
- Hits          20948   20934      -14
- Misses         8520    8527       +7
- Partials       1044    1051       +7

Impacted Files
Coverage Δ
Complexity Δ

....github.ambry.store/StoreKeyConverterImplNoOp.java
100% <ø> (ø)
4 <0> (ø)
:arrow_down:

...java/com.github.ambry.store/CompactionManager.java
86.75% <0%> (-2.65%)
19% <0%> (ø)

...github.ambry.rest/AsyncRequestResponseHandler.java
88.59% <0%> (-2.29%)
23% <0%> (ø)

.../src/main/java/com.github.ambry.store/Journal.java
90.76% <0%> (-1.54%)
24% <0%> (-1%)

.../java/com.github.ambry.router/DeleteOperation.java
92.19% <0%> (-1.42%)
47% <0%> (-1%)

...m.github.ambry.clustermap/HelixClusterManager.java
92.39% <0%> (-1.13%)
33% <0%> (ø)

...in/java/com.github.ambry.store/BlobStoreStats.java
70.99% <0%> (-0.44%)
100% <0%> (-1%)

...ain/java/com.github.ambry.router/PutOperation.java
90.57% <0%> (-0.2%)
83% <0%> (ø)

...va/com.github.ambry.replication/ReplicaThread.java
72.7% <0%> (+0.39%)
61% <0%> (+1%)
:arrow_up:

...b.ambry.network/BlockingChannelConnectionPool.java
65.65% <0%> (+2.17%)
8% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7299f84...e45aa2c. Read the comment docs.

@dharju reminder to review. Addressed all the comments and refactored the test methods.

Cool, will look at when I can pull out my laptop (in plane right now)
Get Outlook for iOShttps://aka.ms/o0ukef

From: Yingyi Zhang<EMAIL_ADDRESS>Sent: Thursday, December 20, 2018 8:52 AM
To: linkedin/ambry
Cc: David Harju; Mention
Subject: Re: [linkedin/ambry] Adding tests to verify replication with different versions of BlobId behaves correctly (#1085)
@dharjuhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdharju&data=02|01|dharju%40linkedin.com|166331ef204d40e2c43008d6669b9697|72f988bf86f141af91ab2d7cd011db47|1|0|636809215770511355&sdata=4l3Vzk3y2MlSFqdjqTYCZzg4fDamWWlydgX6XKjuCGo%3D&reserved=0 reminder to review. Addressed all the comments and refactored the test methods.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flinkedin%2Fambry%2Fpull%2F1085%23issuecomment-449063913&data=02|01|dharju%40linkedin.com|166331ef204d40e2c43008d6669b9697|72f988bf86f141af91ab2d7cd011db47|1|0|636809215770521373&sdata=7%2BWLVuLl0xJ9uc20nN7lVEjBnVRHvQRYPiW1TabazPs%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAdnF8NfoZ0uDwbevkMt5WnF2gCxFcVwaks5u68BkgaJpZM4XV7Hv&data=02|01|dharju%40linkedin.com|166331ef204d40e2c43008d6669b9697|72f988bf86f141af91ab2d7cd011db47|1|0|636809215770521373&sdata=NOK%2BBi5rd3%2BsTKWNMV1YdmqpLJv%2F1XcmiOyAXl5E15I%3D&reserved=0.


fix: Prevent nested void elements [#96086006]

Addresses nested img tags issue #226

@alexanderGugel Thanks for this.  Will look into this more and try and get this in for 0.6

This looks good

landed as bdc3a65


matchmycolor.Colibri version <IP_ADDRESS>25

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

We have an issue with winget update. The winget update command will show updates for old Colibri versions, which are not published with winget (see screenshot where it shows updates for Colibri 22.1.2 and Colibri 3.8.12). How can we prevent winget from updating these versions? The issue happens when an old version e.g. 3.8.12 is installed: https://cdn.matchmycolor.com/downloads/ColibriInstaller_<IP_ADDRESS>50.exe This version is not published with winget, the product name is "Colibri® 3.8.12". When i run winget upgrade it should not show an update for this version.

Hi @matchmycolor,
Probably the best way to handle this would be to add this older version as a manifest with a parallel PackageIdentifier, such as matchmycolor.Colibri.3.8 or matchmycolor.Colibri.LTS - this will inform the WinGet application to leave the older version alone while allowing updates to the newer version.

I'm seeing executables, so I'm unsure why the label was applied.

@wingetbot waivers Add Validation-No-Executables


[Update Request]: Add paint.NET version 5.1.2

What type of update are you requesting?
A new version of an existing package
Current Package Identifier
dotPDN.PaintDotNet
Package Version
5.1.2
Please describe the changes you would like to see
The new version is available on GitHub at: https://github.com/paintdotnet/release/releases/tag/v5.1.2

#199909
But I'm not sure if this pull request is correct...


Facebook Pixel does not appear on the AMP

Hello guys,
I have inserted in the pages of my site the pixel codes of Facebook. And I use the Chrome extension developed by Facebook to know if the pixel is actually installed on the pages: https://screenshot.net/pt/7q372hn?
But I realized that when I activate the AMP version, the extension shows that the pages on my site do not have active Facebook pixel: https://screenshot.net/pt/7z07qf0?
However, I check the source code of AMP pages and see that a slightly different Facebook pixel code appear:
https://screenshot.net/pt/78x7jcd?
<!-- Facebook Pixel Code --><!--noscript--><amp-img height="1" width="1" src="https://www.facebook.com/tr?id=9999999999999&ev=PageView&noscript=1" class="amp-wp-enforced-sizes amp-wp-cb45893" layout="intrinsic"></amp-img><!--/noscript--><!-- End Facebook Pixel Code -->
But the extension is not identifying that pixel. So I was wondering if even the extension did not identify the pixel, the pixel is loading properly and tracking the visits on my pages?
Thank you,
Rodrigo

Hello @rodrigocarlos Thank you for filing the issue.
There are a few things that I can clarify here

AMP runtime schedule layout of all AMP elements on the page. <amp-img> is lazily loaded. If it is placed at the bottom of the page, it is possible that the pixel is not loaded properly and not track the visit.
AMP provides two components specifically for tracking purpose. They are <amp-pixel> and <amp-analytics>. Both components support facebook pixel. Unlike <amp-img>, AMP runtime treats these tracking components differently and will always load them.
You can embed them like

<amp-pixel src="https://www.facebook.com/tr?id=9999999999999&ev=PageView&amp" layout="nodisplay"></amp-pixel>

or
<amp-analytics type="facebookpixel">
  // your configuration
</amp-analytics>

I don't have enough context on the Chrome extension. But with <amp-pixel> and <amp-analytics> the pixel should be loaded and track the visit on your site. You can verify that in the browser's Network tab.

@kristoferbaxter brought up a great point, that AMP should provide better guidance on this kind of usage. Technically it's invalid, but not what we would recommend as best approach.
@honeybadgerdontcare is there a way to embed this kind of check to AMP validator. I know we have validator warnings, would that be a good fit? For example we can throw warning when <amp-img> has width= 1, height= 1 and recommend <amp-pixel> as the alternative component.

@zhouyx 	we try to avoid adding warnings unless absolutely necessary as we don't want developers to have fatigue from too many messages. are we sure that 100% of the cases where someone puts a height/width of 1 that it really should be amp-pixel?

Most of the time I think so, unless someone want to resize the image later? That's also why we think it should be a warning not an error.
We do have this client side width=1 height=1 check for <amp-iframe>, but we don't want to add it to <amp-img> because it's a builtin element. Also that requires one to run the page to find out.
@kristoferbaxter also suggests that we can maybe check for the image src so that it's not one of the common tracking endpoint.

If it's not 100% of the time then that means some use cases do not necessitate the message and that means the message would always be there. This can lead to validator message fatigue and I'd like to avoid that.

@honeybadgerdontcare I see that. Thank you. Do you think what are the good places to perform these type of check? To me it sounds like an AMP optimized tool and can be a special version of validator.

There has been some discussions around a linter for AMP pages and I think this would be an excellent fit for that. I've filed #21418 and will include your suggestion there.

Thank you for linking to the issue. Linter for AMP pages sounds a perfect fit for this type of check!

Hello @zhouyx
My Facebook pixel code in amp-img format is being loaded inside <head> </ head> (https://screenshot.net/pt/gwn03f1?). Does this mean that Facebook will normally be tracking the accesses of the AMP pages?
Thank you.

@rodrigocarlos AMP components are only allowed in document body. Could you please double check if your page is a valid AMP page?
See the example below


Added nav_bar class method

I've added the ability to specify that a particular screen should have a navigation controller, from within the screen itself. It aligns more with BluePotion's screens and is cleaner and nicer, in my opinion.
Previous way:
class MyScreen < PM::Screen
end

# ...
open MyScreen.new(nav_bar: true)

New way:
class MyScreen < PM::Screen
  nav_bar true
end

# ...
open MyScreen

The old way will continue to work and there is no intention to deprecate it or even discourage it. Use whatever works best for you. I am looking forward to using the class method, though!
Review please @markrickert @ryanlntn @squidpunch @creationrose

Review please @markrickert @ryanlntn @squidpunch @creationrose

Looks good! :+1:

This PR looks gigantic but the actual changes to code functionality are small. They LGTM!


Updated buffertools version

Updated Buffertools to its latest version.

@jmalves, I think the semver ~ will get the latest patch version for you. is 2.1.2 somehow unacceptable?

We are unable to install Buffertools 2.1.2 on our server. I think the relevant fix for us was: https://github.com/bnoordhuis/node-buffertools/commit/1912a927cbab036ccb06204586282a60db38f97a

@jmalves great. thanks for the PR and sorry for the slow reply!


Freedom of materials

I heard there was a mod that allowed for more materials to be used, for example steel for pump. If there isn't, would it be possible to make one?

There wasn't no materials mod. But it has been pretty easy to do it.
Desire granted! You can try it here:
https://github.com/javisar/ONI-Modloader-Mods/blob/master/Mods/MoreMaterialsMod.dll
Be aware that I almost haven't tested.

Wow that is pretty great, and fast too thanks.
I actually did find the other I mentioned, referred to me by someone on reddit, but by that description yours has much more freedom. I'll test it out.

You're welcome.
Yeah, Cairath's mods are awesome.

Alright managed to test it out. May I ask what exactly does this mod do? Because, while indeed it unlocks most materials for a lot of things, it doesn't unlock it for everything, which resulted in a kind of weird stuff. So I think it may not actually be desirable to just unlock everything, but rather get a closer look on case by case for some interchangeable materials. Let me know what you think.

I had to decided which buildings are modified. I didn't see too much sense in changing the ones buildable with plastic.
There isn't a lot of room to choose between materials. The list of possible materials are:
ALL_METALS,RAW_METALS,REFINED_METALS,ALLOYS,ALL_MINERALS,RAW_MINERALS,REFINED_MINERALS,FARMABLE,EXTRUDABLE,PLUMBABLE,PLASTICS,GLASSES,TRANSPARENTS,ANY_BUILDABLE
These are subsets that overlap each other.
I changed to ANY_BUILDABLE. You can see which buildings I changed here:
https://github.com/javisar/ONI-Modloader-Mods/blob/master/Source/MoreMaterialsMod/MoreMaterialsMod.cs
And yeah, probably we have to look on case by case. I'm open to any kind of suggestion.

Sorry for taking too long to reply, but basically, I think the game needs a overhaul in terms of building materials requirements and how they affect the finished product, (and hopefully the developers already something planned down the map).
So I don't really think any massive effort would be worth in that regards anyway, something simple I could think of would be making ore and refined metal interchangeable, but besides that I cannot of anything that needs changing atm in any meaningful way.

I agree. The thing you comment "making ore and refined metal interchangeable", I think is possible by selecting ANY_BUILDABLE. Not really sure what you mean with interchangeable. I'm gonna close this issue for now. I'll add config files in a not far future.
Thanks @Gfurst


IHtmlContent ToString() not working

article code in asp.net 4:
HtmlString html1;
HtmlString html2;

html1 = helper.LabelFor(prop, htmlAttributes);
html2 = helper.LabelFor(prop, htmlAttributes);
return new HtmlString(html1.ToString() + ": "  +
                  html2.ToString();

When I try it in ASP.net 5:
  HtmlString html1 =  new HtmlString(htmlHelper.LabelFor(expression).ToString());

when debugging I noticed
 htmlHelper.LabelFor(expression).ToString()

value is

" Microsoft.AspNet.Mvc.Rendering.TagBuilder"

and not the html value that was expected

This scenario is no longer supported in ASP.NET 5, here's a relative ticket.

Calling HtmlString.ToString() was in fact never correct. It just happened to return the same string. Instead the correct code in ASP.NET 4 is to call [HtmlString.ToHtmlString()](https://msdn.microsoft.com/en-us/library/system.web.htmlstring.tohtmlstring(v=vs.110).aspx).
In ASP.NET 5 there is no IHtmlContent.ToString() operation because concatenating strings is hugely inefficient. You can instead write the IHtmlContent to a TextWriter. This avoids reallocating memory and inefficient code.
To concatenate two IHtmlContent objects you can implement an IHtmlContent that in its WriteTo method calls each "child" IHtmlContent in a row and writes them each out to the TextWriter.

@rynowak @dougbu @Tratcher @pranavkm not sure if maybe one of you remember, but why didn't we make BufferedHtmlContent public? It seems like it would be useful for scenarios like this, where someone wants to recompose other HTML bits and return them. Was there some layering issue?

We could make it public if we want to. It's really kinda a stopgap until we specialize various implementations more. I don't want to make any public API changes that make it harder to make perf changes until we're done :laughing:

Can you confirm what the fix is for this? How do we get the output of the htmlhelper?

@Alchemy86, here's what you'd have to do:
using (var writer = new StringWriter())
{
    content.WriteTo(writer, System.Text.Encodings.Web.HtmlEncoder.Default);
    return writer.ToString();
}

Is there anything wrong with this to simplify usage?
public static string ToHtmlString(this IHtmlContent tag)
{
    using (var writer = new StringWriter())
    {
        tag.WriteTo(writer, System.Text.Encodings.Web.HtmlEncoder.Default);
        return writer.ToString();
    }
}

Is there anything wrong with this to simplify usage?

@agileramblings are you suggesting the extension method be in the MVC or Html.Abstractions public API? I recommend we not do this because it's rather inefficient and discourages better patterns. The old HtmlString.ToHtmlString() didn't have these issues because HtmlString contains only one string.
That said, the code is fine for a DebuggerToString() or similar non-production method.

How do we get the output of the htmlhelper?

@Alchemy86 if you need to add the tag to something else, write, copy, or move it there (depending on whether the you have target TextWriter or IHtmlContent and whether the IHtmlContent implements IHtmlContentContainer). If you need to inspect the tag, subclass TextWriter to inspect the strings it's passed and use Razor's NullHtmlEncoder. And, if you need to modify the tag, downcast to whatever types are of interest and modify those IHtmlContent implementations before they're written out.
I'd like to hear more if your requirements fall into the last bucket. We might have a need for more extensibility somewhere -- allowing you to get the IHtmlContent you want up front.

Oh, and for @giddev's use case, write html1 and html2 into a HtmlContentBuilder and return that.

@dougbu Thanks! I don't think it should be added to the public API. I had a TagBuilder instance I needed to see the HTML in and found this thread. An extension method when needed seemed like an easy solution.

@dougbu I'm confused as to what you mean by:

write, copy, or move it there (depending on whether the you have target TextWriter or IHtmlContent and whether the IHtmlContent implements IHtmlContentContainer

We have many helpers which do things like create composite HTML content via many tag builders and historically have used the implicit .ToString() to allow this. E.g.
        ...
        var cbx = html.CheckBoxFor(expression);
        var lbl = html.LabelFor(expression, metadata.Description);

        var div = new TagBuilder("div");
        div.AddCssClass("multiple-choice");
        div.InnerHtml = $"{cbx}{lbl}";
        ...

Is there a better / more efficient way we should be combining tag builders?

The TagBuilder.InnerHtml property is of type IHtmlContentBuilder and the two IHtmlHelper methods return IHtmlContent. So, change the last line to
div.InnerHtml.AppendHtml(cbx);
div.InnerHtml.AppendHtml(lbl);


Add MiniscopeConverterPipe

Chained to https://github.com/catalystneuro/neuroconv/pull/468 until merged

Created ConverterPipeTestMixin on the example of DataInterfaceTestMixin to generalize test for the converter
Added test for converter
Added documentation for usage

TODO:
maybe change it to Converter, no need for ConverterPipe when there are exactly these two data streams

@weiglszonja Thanks for the great work on this!
Just one last question about the source schema, but should be good to go with or without that

@weiglszonja This LGTM now, thanks for digging into that final issue
Merge when you're ready


 Time for you do a code review!
Add support for Excel Services
Perf Point
Access Services
Please reject this request. I actually want to add in a few more things like detection for Enterprise Cal

Hi @caadam, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@caadam, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

@caadam One thing that needs to be fixed - the module name needs to match the directory name. eg - you have a folder called "MSFT_xSPAccessServices" but the module is called "MSFT_xSPAccessServiceApp" (add app to the folder name).
Also can I get you to do a pull from the dev branch as well - I think you're seeing a bug around the user profile stuff in the tests as well which got fixed.

Hi @caadam, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, MSBOT;

@caadam Can you update the readme with the list of what was added in here mate?

@caadam Just finished my pass over this, fairly minor stuff that should be a quick win. Let me know if you need me to jump in to help finish it off mate.


best practice of workflow

Hi, Romain,
I love you repo! ❤  very useful!
I'm curious about your workflow. Could you please give me an overview?
When I'm debugging, I find myself manually closing the server with ctrl+c every time I adjust the metadata.yml file. Then I have to restart it and refresh the page to see if the configuration is appropriate. If it's not, I have to repeat the previous steps.
I'm not sure if there's a way to automate this entire process, such as automatically refreshing the page. I'm wondering how you handle it.
Thanks again!

In general, when using vega lite, the default format is JSON. Do we have a way to use the Vega-lite specification directly? If the specification is complex, converting it to YAML can feel a bit cumbersome -- while many times you can find tools to convert from YAML to JSON, there will be a lot of manual YAML <<-->> JSON conversion process if you consider that debugging is required


Rename & publish npm package under @zondax/ledger-stacks

Re moving away from Blockstack naming

:link: zboto Link

Package hasn't been published yet

Hi @kyranjamie! The npm package was published and every instance of Blockstack was renamed to Stacks. Keep in mind that class name is no longer BlockstackApp (it was changed to StacksApp).
https://www.npmjs.com/package/@zondax/ledger-stacks


fix an assert() when using custom render targets

we now always mask out target bits that don't exist in the render
target before converting them to GLenums.
Fixes #2285

LGTM. Side note: I'm a little fuzzy on the purpose of the nested gl namespacing within each struct, since this is a GL-specific header anyway.

It's just to keep things organized. I only store "GL stuff" in the gl struct, as opposed to filament stuff. Like I'd store GLEnums, GL handles, etc...  Sometime I need to keep a filament version (E.g. a sampler target) and also the GL version.


stopRecordVideo does not return video path

Hi,
Thanks for the hard work on updating this library.
I've noticed that the actual types / results for the stopRecordVideo function doesn't match up with the docs. The actual return type is Promise. So theres no file path of the video once its captured.
An update for this would be greatly appreciated as at the moment the video recording can't be used.
Thanks!

hey sorry to have missed your query i'm not sure to understand, you shouldn't get any path as result.
nothing in the code return a path

ok i got it, the videoUrl was returned on android, it's now in the definition and i also added the feature on ios


Update peerDependencies for @angular/compiler version 8

This seems to work for me in my own fork of Prettier. I would be happy to raise a PR.
I think it would also be ideal to Travis CI testing with @angular/compiler versions 6, 7, and 8.
I would be happy to raise 1 or more PRs.

Good idea! PRs welcome :)


IOS Firestore Transaction IncorrectDereferenceException

When I use firestore transaction I get an Uncaught Kotlin exception. Full output is like this:
Uncaught Kotlin exception: kotlin.native.IncorrectDereferenceException: illegal attempt to access non-shared <object>@325c7a8 from other thread
    at 0...

I used it in a suspend function launched in a coroutine that uses Dispatchers.Main. Even if its lambda is empty I get the same error. The usage is simply like this:
fireStore.runTransaction {
    ...
}

My environment and library versions are:
IOS simulator - iPhone 13 - IOS 15
kotlin version = 1.5.30
coroutinesVersion = "1.5.2-native-mt"
fireStoreVersion = "1.4.3"

IncorrectDereferenceException most of the time means that you've run the KMM code from non-main thread inside iOS.

Thanks for the reply, but I'm calling it from the main thread in IOS


Add ChatGPT API integration

InWorld API is moving to a paid model. ChatGPT is much cheaper and more effective. To implement:

[x] Implement ChatGPT API call for text conversation history
[x] Implement vision of images
[x] Allow for image generation using DALL-E

Testing to begin Wednesday 2024/09/18


get all findings as part of findings API enhancement

Description
As part of the commit, the query params detector_id and detectorType have become optional for the findings/_search API. As part of the enhancement, the API can now return all the findings for all the detectors.
Issues Resolved
https://github.com/opensearch-project/security-analytics/issues/795
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

i am not sure this design is correct or maybe i have grossly misunderstood the approach.
Can you add a detailed approach of how findings from detectors of all log types are being fetched?

i am not sure this design is correct or maybe i have grossly misunderstood the approach.
Can you add a detailed approach of how findings from detectors of all log types are being fetched?
So, the idea is first to get all the detectors using matchAllQuery [TransportGetFindingsAction.java#L190]. Now to get the findings for all these detectors for all the logTypes, we can search query on index-pattern .opensearch-sap-*-findings, this will give us all the findings for all the LogTypes [TransportGetFindingsAction.java#L143]

i am not sure this design is correct or maybe i have grossly misunderstood the approach.
Can you add a detailed approach of how findings from detectors of all log types are being fetched?

I don't think there is a good way to fetch the findings for detectors across multiple log types without making changes in alerting

i am not sure this design is correct or maybe i have grossly misunderstood the approach.
Can you add a detailed approach of how findings from detectors of all log types are being fetched?

So, the idea is first to get all the detectors using matchAllQuery [TransportGetFindingsAction.java#L190]. Now to get the findings for all these detectors for all the logTypes, we can search query on index-pattern .opensearch-sap-*-findings, this will give us all the findings for all the LogTypes [TransportGetFindingsAction.java#L143]

Gotcha! thank you. I wasn't aware that we already are searching on the "all finding indices pattern"
Can you create 2 detectors for different log types and test fetching findings for only one of the log types and verify that behaviour is correct?

i am not sure this design is correct or maybe i have grossly misunderstood the approach.
Can you add a detailed approach of how findings from detectors of all log types are being fetched?

So, the idea is first to get all the detectors using matchAllQuery [TransportGetFindingsAction.java#L190]. Now to get the findings for all these detectors for all the logTypes, we can search query on index-pattern .opensearch-sap-*-findings, this will give us all the findings for all the LogTypes [TransportGetFindingsAction.java#L143]

Gotcha! thank you. I wasn't aware that we already are searching on the "all finding indices pattern"
Can you create 2 detectors for different log types and test fetching findings for only one of the log types and verify that behaviour is correct?

this test is creating detectors of two different logTypes and verifying the behavior -> https://github.com/opensearch-project/security-analytics/pull/803/files#diff-d37f0c96e5ab58c9a80449652179f36f9696044aa275fc7c7f33ce2677fa6793

Please make sure we create a PR in the documentation repo to update all the supported params. I see the documentation does not have some existing params too like startIndex. Thanks

Fix merge conflicts + make sure CI's pass


docs/ directory in 3.0 missing

Hello!
The docs directory was removed in the 3.0 release and content was moved to helm.sh. Many links now 404, so it makes for a poor user experience.
There should at least be a stub page (docs/index.md) telling users this. I'm happy to create one and submit a PR if it will be accepted.

https://github.com/helm/helm/issues/6768#issuecomment-545695304

Please feel free to contribute a PR that includes a README in the docs directory


Discord webhook support

Use this as template:
https://gist.github.com/smiley/78c1c2a57d17a179a978a1438b389710
Allow the streamer to add atleast one (or more) webhooks,

This is implemented in API. But we need web interface for this


LUIS Phrase List not working

Hi
I have set up in LUIS, an intent with a parameter "foodbev" of type "BusinessType::F&B" where F&B is a child entity of BusinessType and linked to a phrase list "Food and Beverage". After doing "setup restaurant" query,
LUIS returns me entity restaurant but type BusinessType instead of type "BusinessType:F&B".
Could you please advise?
Thanks,

How many examples did you provide with the type "BusinessType::F&B" present?
There should be at least 1 example with the type present.

Hi
Yes, i have at least 1 example in the type present.
It used to work but started not to one or two days back.
Below is my Luis App ID:
b84222b8-6040-48f7-bb71-938e2b0ee841
Thanks,
[image: Inline image 1]
[image: Inline image 2]
On Mon, Dec 5, 2016 at 3:07 PM, Youssef Shahin<EMAIL_ADDRESS>wrote:

How many examples did you provide with the type "BusinessType::F&B"
present?
There should be at least 1 example with the type present.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/BotBuilder/issues/1786#issuecomment-264782100,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALkDGfrRiK6dqCNb0If8dlA-jh252vEVks5rE7g1gaJpZM4LDnFo
.

--
Regards,
William Lee

Hi would it be more appropriate to report this issue to a forum dedicated to LUIs (if any) or okay to report it here ?

LUIS didn't change the entity detection mechanism it works with. Adding one example to the parent or the child is not enough. In your case, you need to add more examples to the child to get better accuracy for it

I'm assuming @rihamma's answer helped answer the question, so I'm closing this issue.
@Lee-William feel free to reopen if this is not the case.
thanks!


Comments not preserved

I have opened .resx files with comments. Upon saving, the comments were lost. Though I don't need them displayed, I would like them preserved, untouched.
It looks like this:
  <data name="FeldPreisDetailsMaxPreis" xml:space="preserve">
    <value>Max. price</value>
    <comment>Maximum price</comment>
  </data>

After saving in Resource Manager, it should still look like this ;-)
Thank you for making this project public. It makes localization easier.

Hello @dellabellacitta ,
the new version of the extension is online.
Comments are not deleted anymore.
Please verify if the issue is solved.
Regards,
David

Hello @Dspecht7123,
thank you for the new version.
I confirm that comments are not deleted anymore :-)
However, empty comment tags ("") are now added to all entries which don't have a comment. This is not necessary.
What I've done: I've opened a resource and, without changing anything, saved the resource. Ideally, this would not result in any change to the files. The empty comment tags should not be added. Is this possible?


Add cred_def_id to metadata when using an Endorser

When publishing a new credential definition to the ledger (with the Author/Endorser workflow), the cred_def_id is nowhere to be found in the transaction response or the webhooks. I have moved the metadata definition lines for cred_def_id and issuer_id to the actual definition point for the metadata and have removed the redundant lines that were in an if block.

That was just a rebase


MTIColorLookupFilter() doesn't work on iOS 13

Hi, YuAo
It seems Lookup Filter doesn't work properly on iOS 13 devices.
I am getting:
Error Domain=MTKTextureLoaderErrorDomain Code=0 "Image decoding failed" UserInfo={NSLocalizedDescription=Image decoding failed, MTKTextureLoaderErrorKey=Image decoding failed}
I am using 512x512 png table image
Thank you for this library!

It's a MTKTextureLoaderError, meaning MTKTextureLoader cannot load your image. Commonly because your image is broken or in a format that cannot be decoded by MTKTextureLoader. You can probably fix this by exporting the image using "Preview" app (File -> Export), and choose "PNG" format and "8 Bit / Channel" depth.


Remove symlinks-to-hardlinks.ps1 hack

cc @jhoobergs @Pebaz, fixes #2547

Nice!

Could you check that this works in your environment? I'm not sure whether github actions has some special setup where symlinks actually do work.

Unfortunately, it failed to build on that branch :/
error: Python compile error from Lib/python_builtins/_frozen_importlib.py: Got unexpected token '.' at line 1 column 1
../../../Lib/importlib/_bootstrap.py

↑
  --> vm\src\frozen.rs:41:24
   |
41 |     ext_modules!(iter, dir = "Lib/python_builtins/");
   |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: Python compile error from Lib/core_modules/copyreg.py: Got unexpected token '.' at line 1 column 1
../../../Lib/copyreg.py

↑
  --> vm\src\frozen.rs:46:24
   |
46 |     ext_modules!(iter, dir = "Lib/core_modules/");
   |                        ^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to 2 previous errors

error: could not compile `rustpython-vm`

For context, I believe that this is the same message as before.

@Pebaz could you pull and try again?

@coolreader18 I added rustpython-vm = { git="https://github.com/RustPython/RustPython.git", branch = "coolreader18/fix-windows-symlinks" } to my Cargo.toml file, but still got the same error.

I think the -C is necessary, since it's not always guaranteed that you're going to be in [a subdirectory of] the git repository

Thanks so much for fixing that!

I have an opportunity to test this again tomorrow, can't wait to see if it works!

@coolreader18 @jhoobergs It worked!
I can run Python snippets now!
Thank you so much for your help and work on this! 🙂🙃🙂🙃
If you need me to test anything else let me know.


Blog_App: Data model migrations

Creating a data model: Milestone-1
In this Milestone, I:

Created a new rails app (Blog_app)
Set up Postgres database for the project.
Created and ran the necessary migration files.

Apparently, this is my ER diagram. The review comments have left me in a state of confusion.
Kindly check and confirm if I have a different diagram than others. Thank you.

Hello, @Enning94 I am not sure why you have a different ERD diagram from mine but from the Project Requirement I have here, this was the ERD diagram. So please check and let me know if you have the same thing. If not, you can send me a link to your Project Requirement so I confirm and ask for future assistance from my superiors if needed.

Hello @Enning94 You can Ignore the first two comments and only fix the last comment so the next reviewer can go ahead and Approve it for you :+1: It seems like the diagram was changed for you but it hasn't been changed for us yet hence the misunderstanding but that's no faultt of yours so kindly forgo the first two comments :wink:

Ok @Enning94 You're welcome :+1:


Add Arabic source sunovels

Source name
sunovels
Source link
https://sunovels.com/
Language
Arabic
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a title with source name.
[X] I have checked that the extension does not already exist by searching the GitHub repository and verified it does not appear in the code base.
[X] I will fill out all of the requested information in this form.

Duplicate of #130


bugfix: Revert battery radiator temperature

The battery has 2 different temperatures: battery and radiator

Ah my bad! Those are the regex caveats! 😆 But let's call it Heatsink then, hm? 😉

Renamed


Handling state parameter in RP-Initiated Logout requests with invalid id_token_hint param

Describe the issue:
According to the specification [1], if the state parameter is included during RP-Initiated Logout, it should be passed back to the RP during redirection.
However, it was observed that when the logout is initiated from the RP with an invalid id_token_hint, the state parameter is not returned in the response.
The documentation [2] also states that if an application sends this parameter, WSO2 Identity Server will return it in the response.
As per the specification and documentation, the behavior should be improved to return the state parameter to the RP even if the id_token_hint provided is invalid.
[1]. https://openid.net/specs/openid-connect-rpinitiated-1_0.html#:~:text=OPTIONAL. Opaque value,to the RP.
[2]. https://is.docs.wso2.com/en/latest/guides/authentication/oidc/add-logout/#:~:text=page after logout.-,state,-The parameter passe
How to reproduce:
Below is a sample request.
https://localhost:9443/oidc/logout?client_id=<clientid>&post_logout_redirect_uri=<redirect_uri>&state=<state>&id_token_hint=<invalid_id_token>

Expected behavior:
As per the specification and documentation, the behaviour should be improved to return the state parameter to the RP regardless of the validity of id_token_hint.
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: 7.0.0

Related issues:
[1] https://github.com/wso2/product-is/issues/21156

This is not reproducible in master. The expected behavior
Ideally the state param has to be returned if we are redirecting to the application, and state param is not returned if redirected to IS error pages.
Example:

If the either callback url or (id_token_hint and client_id) is not added in the logout request (This scenario will be fixed with this update)
If the client ID is present and passing invalid id_token_hint
For 1 and 2 - redirected to application and state param should be returned
If the client ID is not passed, we try to resolve the the client id from id_token_hint. Here, if the id_token_hint is invalid, it redirects to IS error pages, where the state param will not be passed.

(https://localhost:9443/authenticationendpoint/oauth2_error.do?oauthErrorCode=access_denied&oauthErrorMsg=Error+occurred+while+decrypting+the+id+token+(JWE).&crId=844e98a7-40e0-45cd-b20f-5d14fddc9a70)


An unhandled exception of type 'System.NullReferenceException' occurred in AdomdClientNetCore.dll: 'Object reference not set to an instance of an object.'

An unhandled exception of type 'System.NullReferenceException' occurred in AdomdClientNetCore.dll: 'Object reference not set to an instance of an object.'
at Microsoft.AnalysisServices.AdomdClient.StreamInteropHelper.ProcessRequest(XASC comClass, Stream requestStream)
at Microsoft.AnalysisServices.AdomdClient.IXMLAStream.WriteEndOfMessage()
at Microsoft.AnalysisServices.AdomdClient.XmlaClient.WriteEndOfMessage(Boolean callBaseDirect)
at Microsoft.AnalysisServices.AdomdClient.XmlaClient.EndRequest(Boolean useBinaryXml)
at Microsoft.AnalysisServices.AdomdClient.XmlaClient.CreateSession(ListDictionary properties, Boolean sendNamespaceCompatibility, String sessionToken)
at Microsoft.AnalysisServices.AdomdClient.AdomdConnection.XmlaClientProvider.Microsoft.AnalysisServices.AdomdClient.AdomdConnection.IXmlaClientProviderEx.CreateSession(Boolean sendNamespaceCompatibility)
at Microsoft.AnalysisServices.AdomdClient.AdomdConnection.ConnectToIXMLA(Boolean createSession)
at Microsoft.AnalysisServices.AdomdClient.AdomdConnection.Open()
at TestBed.Program.GetDataFromAzureAnalysisService(String query, String databasename) in xxxxx\Program.cs:line 34
at TestBed.Program.Main(String[] args) in xxxxxxxx\Program.cs:line 14

I have the same exception. Does anyone know how to resolve it?

I haven't delved deep into this but the problem comes from commenting out the assignment of the XASC instance in the IXMLAStream ctor. I tried restoring it but then I get authentication problemens further downstream.

After more testing, I realized the project I was trying to use this in was actually a .NET Framework 4.6 project. I switched over to the .NET Core project (they're pretty similar except their frameworks, so I didn't realize the first one wasn't .NET Core), the unofficial library worked without issue.

The problem is here:
https://github.com/bdebaere/Unofficial.Microsoft.AnalysisServices.AdomdClientNetCore/blob/3faea74bb37a3538af93dd28fd3229aaa397a127/AdomdClientNetCore/Microsoft.AnalysisServices.AdomdClient/IXMLAStream.cs#L23-L28
I removed the commend in line 25 and then it worked.

Update: I'm getting this issue now on a .NET Core app, but only after I deployed it to an Azure app service. I tried building @ice1e0's branch and including the DLL from it manually and it doesn't seem to have helped.

Deployed to Azure and I'm seeing the same issue. Not seeing it when run locally.

The problem is here:
https://github.com/bdebaere/Unofficial.Microsoft.AnalysisServices.AdomdClientNetCore/blob/3faea74bb37a3538af93dd28fd3229aaa397a127/AdomdClientNetCore/Microsoft.AnalysisServices.AdomdClient/IXMLAStream.cs#L23-L28
I removed the commend in line 25 and then it worked.

PLEASE approve this PR and then release a new version to nuget!

The problem is here:
https://github.com/bdebaere/Unofficial.Microsoft.AnalysisServices.AdomdClientNetCore/blob/3faea74bb37a3538af93dd28fd3229aaa397a127/AdomdClientNetCore/Microsoft.AnalysisServices.AdomdClient/IXMLAStream.cs#L23-L28
I removed the commend in line 25 and then it worked.

PLEASE approve this PR and then release a new version to nuget!

Hi, has anything changed on that?

@rev3ng, Microsoft have finally release an official version. you should probably move over to that as this repo hasn't been updated in a long time. Not seeing any issues since moving over.
Microsoft.AnalysisServices.AdomdClient.NetCore.retail.amd64

@rev3ng, Microsoft have finally release an official version. You should probably move over to that if you can, as this repo hasn't been updated in a long time. Not seeing any issues since moving over.
Microsoft.AnalysisServices.AdomdClient.NetCore.retail.amd64

I will try a new one. Thanks :)

@rev3ng, Microsoft have finally release an official version. You should probably move over to that if you can, as this repo hasn't been updated in a long time. Not seeing any issues since moving over.
Microsoft.AnalysisServices.AdomdClient.NetCore.retail.amd64

Note: The Nuget package from Microsoft unfortunately requires .NET Framework X and can therefore not run on non-windows OS. So, there is still a valid reason to keep this repo alive. @bdebaere would love to see PR #17 merged

Yes agree with @rev3ng.  I have the same issue and I need this Package since we are running on non win.