segmentation fault when size > 2176x1631

i am running the cpu version on an instance with 240gb of ram. when i set the size to 2176x1631 it works and the memory consumption stays at about 72gb. now if i set the size to anything above that i get a segmentation fault right after initialisation.
is there some technical limit to the image size apart from the available ram?

Sorry, I don't have an answer, but I just have to ask: how did you get that much RAM?! :)  That's just incredible. How long does it take to generate those images?

I'm also not sure what the problem might be - do you get a stack trace, or just a segfault?

it's an aws r3.8xlarge instance (32 vcpus, 244gb ram) and it takes about 15h for 1000 iterations at this resolution.
i am only getting the segfault, no stacktrace. i'll have a closer look at it tomorrow and try to see where it actually happens.

I see the same issue - also using amazon r3.8xlarge.

i now know it always happens the second time line 120 in neural_style.lua is called.
https://github.com/jcjohnson/neural-style/blob/15ad5e5/neural_style.lua#L120
the segmentation fault is an error code 6 so a write to memory results in a page not found.
so apparently it is a memory allocation issue and that could very well be an os-specific configuration problem (although the kernel config looked fine at first glance). then again it could also be related to luajit and i am no lua expert.
will have another shot at this later this week i guess. maybe someone has some hints on what to look at for debugging.

I have read things to the effect that luajit has an internal memory limit of 1GB for lua based objects; it is possible that at higher resolution we are hitting this memory ceiling. One possible fix that I am going to explore today is to use normal lua instead of luajit and see if the issue still occurs.

I tried replacing the lua runtime with a non-jit version, updating open blas to a patch that spoke about segfault issues, ran with extra debugging enabled in luajit and prayed to the software gods. The best lead I have is that it seems to crash out on the while processing the 5th layer within net:forward() in the same place that @dasantonym saw.
Perhaps we can try using a different blas package, such as mkl? If only we had easy access to it...

Linking with MKL does nothing to fix this issue. I don't know what else to try.

Did you try the recently added adam option ?

oh wow, a lot happened here over the week. i am not sure if pursuing the cpu based method is feasible. even if you manage to use up all of the 240gb ram then it will still be limited and the resolution mentioned above takes something like 15h... that will take ages if you go for really high resolutions.
so, i am probably going to try overlapping tiles and then let a stitcher assemble them, but i am also curious if you couldn't use mpi (https://github.com/sixin-zh/mpiT) and run it on a scalable gpu cluster with a unified virtual address space for the memory.
also, i am closing this issue because i do not see it really related to this repo. the segfault is most likely either something related to torch and/or the os.
the discussion on this should rather continue here:
https://github.com/jcjohnson/neural-style/issues/36

This bug really belonged to Torch/nn and must have been fixed with my recent pull request
https://github.com/torch/nn/pull/443
Hope it finally works on big images!

Wow, nice find! I have never tried to run with images that big, but it's good that it works now!


VSCode gives wrong push error message

VSCode Version: 1.17.1
OS Version: Windows 10

Steps to Reproduce:

Set GitHub private email setting to true
Open repo through vscode
Push to repo

VSCode returns : Can't push refs to remove. Run "Pull" first to integrate your changes.
However the issue as visible from the git log is infact
[remote rejected] master -> master (push declined due to email privacy restrictions)

Changed the message to more tentative suggestion.


Add disable_git_hooks config option to security

Also move gitea_security_key and gitea_internal_token to an extra security section in readme

Thanks ! :)


MTT: Moved Nginx image to quay.io

Docker images are not supported by the IBM-Z platform team, test cases depend on the Nginx those test cases are failing.

/retest


App will not launch

Description
App will not launch from Plugins > Sketch Plugin Manager
OS X Version
10.12.5
Sketch Plugin Manager Version
1.6
Screenshot
Logs

I have a few followup questions:

Are you selecting Plugins > Sketch Plugin Manager > Open Manager from the menu?
Have you been able to launch Sketch Plugin Manager before?

If you've selected Open Manager from the menu and nothing happens, can you please check to see if it's running in the background using the Activity Monitor app? To do this:

Open Activity Monitor.app located in the /Applications/Utilities/ folder
Type "sketch" in the search bar in the upper right
Check to see if there is a process name called "Sketch Plugin Manager" listed. If there is, select it and click the 🛑 icon in the upper left to stop the process.

Let me know if you're able to see the process in Activity Monitor.

I ran Plugins > Sketch Plugin Manager > Open Manager from the menu and nothing happened.
Sketch PLugin Manager was not running when I checked activity monitor.
I uninstalled and redownloaded Sketch Plugin Manager and reinstalled. Now the plugin manager works and I was able to install a plugin.

That's great to hear. I'm going to close this for now but please feel free to reopen if you run into the same problem again.


changes in the basic structure

Created basic changes to the template structure

changes wine quality

The article was added and changes were made to the collaboration


Release 0.5.0-2

Add explicit padding members to generated structs (fixes #25)

For some reason, libbpf rejects user-provided structs if their padding isn't zeroed out.
See: https://github.com/libbpf/libbpf/blob/07ba0eeb8e0a4ed492464af55b0ca89a40161615/src/libbpf_internal.h#L241
Note: we're also installing bindgen from source now because it contains a fix for rust-lang/rust-bindgen#2108. Once the next version of bindgen is released, we can use it instead.

Remove rustfmt.toml and use Ubuntu LTS to generate bindings

My preferred rustfmt.toml requires nightly features.
Ubuntu 20.10 is already EOL. Use 20.04 instead, which is perfectly fine our purposes.

Release 0.5.0-2

Will this achieve what you need, @mimullin-bbry?

Visual inspection looks promising.  I shall test by EOD Nov 1, 2021.

@alexforster This achieves what I need Alex.  Thank you.
Warning for your downstream clients.  The addition of all these new __bindgen_padding_x fields might cause a bit of a headache.  libbpf-rs requires just two lines of change in https://github.com/libbpf/libbpf-rs/blob/master/libbpf-rs/src/object.rs#L62.  I am unsure of who your other customers are.
I have tested via local updates to the above libbpf-rs object.rs file and compiling my example application found in this libbpf-rs PR: https://github.com/libbpf/libbpf-rs/pull/138
Lines https://github.com/mimullin-bbry/libbpf-rs/blob/adding-tc/libbpf-rs/src/tc.rs#L41 have removed the MaybeUninit method of zeroing and instead are just using a ::default() call on bpf_tc_opts (similar to bpf_tc_hook).
TL;DR +1

Hm, that's unfortunate, but it certainly won't be the first API/ABI breakage...

You must specify the exact version of libbpf-sys, and you must not assume that any other version will be API or ABI compatible.

I think the improved ergonomics are worth it. Once libbpf goes 1.0 (soon) I won't have the chance to make these kinds of changes anymore.

Published: https://crates.io/crates/libbpf-sys/0.5.0-2


google_auth + static user map

At the moment I create a helm chart for docker_auth to deploy it with ease in a k8s cluster (I will later
publish it in incubator repo). However I have an issue with google auth + static user map for technical users (eg. build systems without oauth account). Is it possible to use both ways?
That's my current config
server:
  addr: ":5001"

users:
  "builder":
    password: xxx

token:
  issuer: XXX auth server
  expiration: 900
  certificate: /certs/token.pem
  key: /certs/token.key
google_auth:
  domain: xxx.de
  client_id: xxx
  client_secret: xxx
  token_db: "/data/google_token_db.ldb"
  http_timeout: 10

acl:
  - actions:
    - push
    - pull
    comment: Logged in users can everything
    match:
      account: /.+/

yes, auth methods are checked in order and whichever succeeds stops the check.
auth mechanism responds "success", "fail" or "don't know" the latter being - "i don't know this user, continue to other methods".
so yes, you should be able to use static users and google accounts. if it doesn't work, it's a bug.

Ok found the issue. My passwort wasn't a BCrypt hash -.-


Terse RDF Triple Language (Turtle) Support

Hi,
Describe the bug
Seems that Titanium lib can't recognize singles quotes in the literals of turtle RDF format.
I need to use singles quotes ' on my RDF turtle and then convert it in json-ld.
Here you can find all types of quotes accepted from RDF-turtle:
Turtle literals quote
I get this error:
Caused by: com.apicatalog.rdf.io.error.RdfReaderException: Unexpected character ['] expected [\t, \n, \r, ^, @, SPACE, ., <, _, ", #].
	at com.apicatalog.rdf.io.nquad.Tokenizer.unexpected(Tokenizer.java:133)
	at com.apicatalog.rdf.io.nquad.Tokenizer.doRead(Tokenizer.java:120)
	at com.apicatalog.rdf.io.nquad.Tokenizer.next(Tokenizer.java:50)
	at com.apicatalog.rdf.io.nquad.Tokenizer.accept(Tokenizer.java:61)
	at com.apicatalog.rdf.io.nquad.NQuadsReader.skipWhitespace(NQuadsReader.java:235)
	at com.apicatalog.rdf.io.nquad.NQuadsReader.reaStatement(NQuadsReader.java:83)
	at com.apicatalog.rdf.io.nquad.NQuadsReader.readDataset(NQuadsReader.java:69)
	at com.apicatalog.jsonld.document.RdfDocument.of(RdfDocument.java:119)
	... 26 more

To Reproduce
String turtle = "<http://this.is.a.test_e5a8> <https://uri.etsi.org/ngsi-ld/coordinates> '1.33903E1'.\n"
+ "<http://this.is.a.test_9d6b> <https://uri.etsi.org/ngsi-ld/coordinates> '5.25075E1'.";

Reader targetReader = new StringReader(turtle);
Document document = RdfDocument.of(targetReader);
return JsonLd.fromRdf(document).get();

Expected behavior
Maybe you can allow singles quotes too.
Additional context
I m use Titanium to convert JSON-LD to RDF and vice versa, but sometimes I need to add manual RDF triples that can contain double quotes " inside a literal, so I need to use singles quotes.
Thank you.

Hi,
thank you for reporting the issue. Unfortunately, Turtle format is not supported now, only N-Quads/Triples

Hi,
yea, sorry, in my case N-Quads or Turtle it's not important, I just need to use ' instead " for literals.
I look N-Quads standard right now, and I confirm that they use only ", so maybe you should implement directly Turtle format instead of add ' to N-Quads (which would not respect the standard).
Thank you

closed due inactivity, feel free to re-open with new information.


Add KONG_STREAM_LISTEN utilities

This PR adds some functionality that is helpful for TCPIngress and UDPIngress tests, in that testing these requires being able to update the ENV and container ports of the running proxy to expose the new ports needed for TCP/UDP.
This is a first iteration in service of https://github.com/Kong/kubernetes-ingress-controller/pull/1150 but it is incomplete and there are follow up issues noted in the comments.

chore: move the overrideenv util to k8s pkg
chore: make the default vars public
feat: add kong stream listeners cluster utils

gonna just pull this for now, I'm going to have to rework a couple things.


Adding the google gRPC client cache for ext authz filter to avoid cha…

…nnel creation for each request
Signed-off-by: Fangpeng Liu<EMAIL_ADDRESS>
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: Adding the google gRPC client cache for ext authz filter to avoid gRPC channel creation for each request, which greatly increased the latency
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

@rojkov do you mind to do the first pass?

/assign @rojkov

Sure, will take a look later today.

By the way, no need to force push to the PR. It's easier to follow updates when they are in separate commits. When the PR gets merged all the commits will be squashed into one with the message specified in the "Commit Message" field of the PR's description.

/azp run envoy-presubmit

/retest

Great thanks for helping review the code! :) looks like some internal error in presubmits.

presubmit is paused to free up resources for a security release.

/retest

/azp run envoy-presubmit

/retest

/retest


Include LLVM definition in bug report

The bug reports for RPC interaction have to reproduce the exact RPC environment which may include an LLVM simplification library (in the case of the Haskell backend booster).
The pyk bug report option should extract the following from the -kompiled folder generated when kompiling with LLVM:

definition.kore
subdirectory dt containing yaml files
the llvm-kompile invocation from kompile --verbose,
the LLVM backend version (depends on https://github.com/runtimeverification/llvm-backend/issues/657)

We also need access to the llvm-kompile binary (not part of this issue).

@ehildenb We met with @Baltoli and discussed in detail what is needed. See updated description above.

It looks like the changes need to be made here
https://github.com/runtimeverification/pyk/blob/bb20d0e27e438b224034b1ada86ee205753065b5/src/pyk/kore/rpc.py#L940-L952

Actually, that's the bug report for when running a haskell backend server. There's this snippet here for a booster server
https://github.com/runtimeverification/pyk/blob/bb20d0e27e438b224034b1ada86ee205753065b5/src/pyk/kore/rpc.py#L1030-L1032
Which has the dt folder and the llvm backend definition.kore. It's missing the llvm backend version and the llvm-kompile invocation. But, now I'm a little unclear on what this issue asks for. Is this for a bug report when running a proof with the booster, or when kompiling with the llvm backend?

@gtrepta It's been a while since I looked at this, but as I recall it's to allow the booster bug reports to include a recipe for the shared bindings library that they generate + dynamically load. If the version + command line information is missing from the manifest, perhaps you could modify Pyk to emit them both into the definition directory when it makes the shared library?

Would including just the shared bindings library be enough (interpreter.so)? I have an example of the llvm-kompile command printed out by kompile:
llvm-kompile /home/gtrepta/runtimeverification/evm-semantics/llvm-library/definition.kore \
             /home/gtrepta/runtimeverification/evm-semantics/llvm-library/dt c -- -o      \
             /home/gtrepta/runtimeverification/evm-semantics/llvm-library/interpreter     \
             -std=c++17 -lssl -lcrypto                                                    \
             /home/gtrepta/.cache/kdist-90e2d68/evm-semantics/plugin/libff/lib/libff.a    \
             -I/home/gtrepta/.cache/kdist-90e2d68/evm-semantics/plugin/libff/include      \
             /home/gtrepta/.cache/kdist-90e2d68/evm-semantics/plugin/libcryptopp/lib/libcryptopp.a \
             -I/home/gtrepta/.cache/kdist-90e2d68/evm-semantics/plugin/libcryptopp/include \
             /home/gtrepta/.cache/kdist-90e2d68/evm-semantics/plugin/libsecp256k1/lib/libsecp256k1.a \
             -I/home/gtrepta/.cache/kdist-90e2d68/evm-semantics/plugin/libsecp256k1/include \
             /home/gtrepta/.cache/kdist-90e2d68/evm-semantics/plugin/plugin-c/plugin_util.cpp \
             /home/gtrepta/.cache/kdist-90e2d68/evm-semantics/plugin/plugin-c/crypto.cpp  \
             /home/gtrepta/.cache/kdist-90e2d68/evm-semantics/plugin/plugin-c/blake2.cpp  \
             -lprocps

There are lots of system/user specific paths that aren't going to translate over onto another system, so I'm not sure how useful this would be in a bug report.


Feat: Add loading logging to dbt adapter

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

should this be debug level?


PHPUnit: Trait 'Illuminate\Foundation\Testing\FreshDatabase' not found

Laravel Version: 5.5.* (master)
PHP Version: 7.1.5
Database Driver & Version:  MariaDB 10.2.5

Description:
In the latest version of Laravel, when you make a new test with the artisan console command, the test class will import a non-existing trait called FreshDatabase:
use Illuminate\Foundation\Testing\FreshDatabase

The proper name should be RefreshDatabase instead. The steps below demonstrate that PHPUnit will throw a fatal error because FreshDatabase trait does not exist.
Steps To Reproduce:
Prepping:

Pull in the latest dev release laravel new app --dev
Run php artisan key:generate

Actual steps:

Make a sample feature test: php artisan make:test SampleTest
Use the FreshDatabase trait which is auto-imported at the top: use FreshDatabase;
Run the test: phpunit tests/Feature/SampleTest.php
Get an error (or similar):

Fatal error: Trait 'Illuminate\Foundation\Testing\FreshDatabase' not found in
C:\laragon\www\forum\tests\Feature\SampleTest.php on line 10

Since the PR has been merged this issue can be closed


TargetView show/hide option.

Hello,
Is it possible to implement hide/show of target view manually?

I did this quick and dirty like this:
    mQuickReturnTargetView = (AbsListViewScrollTarget) mQuickReturnAttacher.addTargetView(mStickyPanel, QuickReturnTargetView.POSITION_TOP, mStickyPanel.getHeight());

public void open() {
	mQuickReturnTargetView.translateTo(0);
	mOpen = true;
}

public void close() {
	mQuickReturnTargetView.translateTo(-mStickyPanel.getHeight());
	mOpen= false;
}

public void toggle() {
	if (mOpen)
		close();
	else
		open();
}

You have to make QuickReturnTargetView.translateTo() public for this to work.
I'm sure there are better ways to do this and I'm open for suggestions!

Thanks a lot. This will help for now.


Resolve 'dead area' between radio/checkbox and label that has hand cursor but is not clickable

What problem does the pull request solve?
On the new radio buttons / checkboxes, there is a 12px gap between the input control and the label which has a hand cursor (inherited from the .multiple-choice parent div) but is not clickable. Since it has the hand cursor, I feel it should be clickable.
The alternative would be to not show the hand cursor in this 12px dead area but that doesn't feel right to me?
How has this been tested?
Checked in Chrome (Ubuntu), IE8, IE9, IE10, IE11, Edge 14, iOS9 Safari, Android 6 Chrome.
Can test more if necessary, if this change is approved. Just let me know...
Screenshots (if appropriate):

What type of change is it?

Bug fix (non-breaking change which fixes an issue)

Has the documentation been updated?

I have read the CONTRIBUTING document.

Nice spot thanks for the PR!
I've attached some screenshots where the pink is anywhere cursor: pointer is enabled, and where the current clickable area is before and after your proposal.

Current
Proposed

Good point, I'll have a peep

@nickcolley If I just remove the cursor: pointer from the parent div, the label and input inside it already have a pointer on them, so you end up with what you highlighted in red.
Only thing I wonder is whether to add the tiniest amount of top and bottom padding onto the label to give it some height. What do you reckon?

Nice catch!
It's important that radios and checkboxes have large hit areas. In the examples above ideally the entire pink area would be clickable - as the hand suggests.

@edwardhorsford Ah I see sorry, I interpreted the pictures wrong. You reckon actually the entire of the light pink area should be clickable, in both those examples? What about this example:
!(https://cloud.githubusercontent.com/assets/2445413/24362846/ec2e663c-1305-11e7-9b61-7d4dc6120de3.png)
Should it be clickable all the way to the far right hand side there?

Happy to do that - I just wondered whether the right hand edge there was quite a long way away from the end of the word Ireland. Is it strange for it to be clickable that far away, or should it be more like this:

Willing to be vetoed but I'd vote for it being all the way on smaller screens.
Thinking about where people's thumbs will be placed if they miss on the right side of the screen we'll catch their input if it's full width.
This will be much more evident in small labels also like the examples above these 'Yes', 'No'

This is a bit more complicated now we don't have the grey box round them, to give that visual indication that there's a thing there. That's my only concern - that a large blank area of the screen as a clickable thing might be more "surprising" than it is useful.

is there a downside to wrapping the whole thing in label like we used to? That means you have a nice big hit area

@joelanman the label is being used with pseudo elements for the fake input, if we wrapped the label we'd most likely need another element alongside the input that is nested.
@robinwhittleton was worried that extra elements will play worse with screenreaders

Don't think we need to change the markup. We should be able to do either of the hit area options with what we've got. Just need to decide on what the "right" hit area is
On 27 Mar 2017 5:02 p.m., Joe Lanman<EMAIL_ADDRESS>wrote:
is there a downside to wrapping the whole thing in label like we used to? That means you have a nice big hit area
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/alphagov/govuk_elements/pull/435#issuecomment-289498750, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAIN8hREY-cL1qXRL9ZKHqPlxqHmzu7Tks5rp9y5gaJpZM4MqXNg.

What do people think about the attached screenshots, with the clickable areas being fatter, but not extending full width? (See the dotted red borders around checkboxes and radios)
The alternative suggested above is that on the mobile option, the clickable area extends full width.

I think unless someone else has strong objections it may be better to keep the full width behaviour as is but with your fixes to touch areas and then raise an issue to look into this again later?

:+1: Cool, will sort that out

Ok that will leave us with the following click areas (dotted in red). I'll tidy up let you know when it's ready for review

Looking good!

Cool, cheers @edwardhorsford. I think this is ready for review in that case.

Will give it another look over thanks so much @andymantell this is great.

Tested this on a Galaxy S7, iPhone 6, IE 6, IE 8, IE 9 and Chrome.
LGTM 👍
Will leave open for a little bit since these are important components for others to comment then merge.

Left open for a day with no extra comments, and @nickcolley’s testing looks good so let’s merge.

Thanks a lot @andymantell 💯  🚀

Good stuff! Thanks! 👏

No probs, thanks for everyones help


Assignment 3 by Lucy

closing this one, in favor of https://github.com/DS219/spark-seprep/pull/51 (that gives credit for assignment 3 & pacman)


Add metadata method to mermaid trace object

The metadata method returs the event data asocciated to each node in the diagram.
Change-type: minor

I self-certify!


questions about clock_network

May I ask what the meanings of INC_DIRECTION and DEC_DIRECTION after this DIRECTION are? If I want to change it to a spine_lvl0 from top to bottom, what should the "direction= " in these horizontal rib definitions be changed to? This information is not explained in the documentation.

@Chris202305 INC_Direction means

horizontal tracks that span from left to right
vertical tracks that span from bottom to top

DEC_DIRECTION means

horizontal tracks that span from right to left
vertical tracks that span from top to bottom

Please be aware the programmable clock network is still under development, bugs and errors may easily be hit. I do not have bandwidth to work on this part in a short term.


Merged master dev 1.19

/assign @savitharaghunathan

@annajung 👋  Thanks for the PR 🎉 Can you change the target to dev-1.19 instead of master?

@savitharaghunathan thank you for catching that! yes, it's been changed now

This is the weekly master to dev-1.19 branch sync.

Hi @yakirch Thank you for catching that! I just pushed a fix for it, please take a look again when you get a chance

/lgtm
/approve


dbeaver/pro#1560 support Greenplum 7 version

https://github.com/greenplum-db/gpdb/commit/b62e06014d1237ab9b3657e30609d2630954134d about external tables - they are foreign tables partially now (probably, we need new ticket about external tables)
https://github.com/greenplum-db/gpdb/commit/f182228992b62e2023e2fac5b4971406abd35c9d - about partitions - in Greenplum 7, we can read partitions like for ordinary PG in our code
Also, please check the DDLs of regular tables - DISTRIBUTED ON case must be inside the DDL
Reding of all main metadata entities also check.

verified


Feature/initial setup

Restructure code base, rename library, add some basic tests.

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Download failed

i can receive the file from my phone, but if i send something to my phone, i can't download it successfully

hello @zk8514, do you receive any error?

I got the same issue.
I don't specify anything. I just use it qrcp send something. It will normally print out the qr code, and my phone can detect it, but when I go to this address my downloader says "file not found".
No other error message.

Hello, can you please show me a screenshot of the terminal when the browser prints the 404?

Latest version.

And here is a new situation. my phone just doesn't start anything anymore.

And sometimes it will output this.

Thank you very much, I think I know where the bug could be.
Can you please test transferring a file whose filename has no spaces?

Sure.

This time it will start downloader correctly, but 404 appear again. My downloader is ADM and the below toast says "Client error( Could not found this file)"

I got a fixup. tested it works fine.
ref https://github.com/claudiodangelis/qrcp/pull/207

Hello @zk8514, are you still experiencing this issue? If so, please feel free to reopen this issue. Thanks! C

Hello, I got the ERR_CONNECTION_TIMED_OUT


Why messages for a group keep failing?

I've added the bot to admins, and when I run /group news I get
An error has occurred: chat not found (https://thefeedreaderbot.com/helpChannels.html#group)
Which says the bot is not in the group -.-
Any ideas?

This is not related to TDLib. You should contact the bot's developer.


tonic: inject an GrpcMethod extension value to request

Motivation
Resolve #772
Solution
Add an extension GrpcMethod to Request via the NamedService trait.
And update tonic-build for making GrpcMethod as a static reference.
This only works on this case
Server::builder()
     .add_service(TestServer::with_interceptor(Svc, interceptor))
// ...

not for the case like
Server::builder()
     .layer(tonic::service::interceptor(interceptor))
     .add_service(TestServer::new())
// ...

Yes, we can find a better name than "GrpcMethod" and "grpc_method".
The "grpc_method" is applied for ensuring the "GrpcMethod" actually exists in the protobuf definition. And providing static lifetime variables instead of generating by the runtime, I believe will acquire more performance improvement.
And the extra constant variables are useful for references and preventing typo accidents.
Please correct me if something is incorrect. Thank you @LucioFranco

@linw1995 We have a need for something very similar to this for reporting prometheus request metrics. We need one small piece of additional information for us to be able to leverage this completely.  We need the method type, which is one of four types.
Curious if you're interested in extending this a tad bit further to include that information on the GrpcMethod struct?  Below is an example of what I'm referring to:
pub enum MethodType {
    Unary,
    ClientStream,
    ServerStream,
    BidiStream,
}

Adding that enum as a field on the GrpcMethod struct would make things significantly easier to get the information we need.

@RyanAmos I am excited about including this in the future. But this pull request currently needs to be reviewed first, then I can put some effort into further work.

I think I am not convinced yet on the server side of this, but the client side I think would be useful. Could you break this PR into those two sections? I believe the client one should be pretty small and should be easy to merge.

I think I am not convinced yet on the server side of this, but the client side I think would be useful. Could you break this PR into those two sections? I believe the client one should be pretty small and should be easy to merge.

@LucioFranco I see. I will split it into another PR for the client's implementation.

Hey guys is there any status on this? :-)
We can't use gRPC without the ability to log times on requests, it's essential for operations to see which routes are taking a long time.

We can't use gRPC without the ability to log times on requests, it's essential for operations to see which routes are taking a long time.

I don't think there is much progress on this but you should be able to do what you want via the http service layer and tracking the paths which correlate to the grpc method being called.

@LucioFranco thanks for the reply.
We decided to go with another framework that supports it by default. Might be something to consider, this framework was fairly nice :-)

@linw1995 You note that this change doesn't work for the case where the interceptor is made a layer over multiple services. Is there some way that could be done? I'm trying to use an interceptor layer for authentication, but I need it to not run on the health check service.

@CodingAnarchy You might need to use the tonic-health crate in this PR. This will allow you to get the correct service name in your interceptor.


Fix samplers CI

Motivation
Fix CI fail due to cmaes becoming optional. ref: https://github.com/optuna/optuna/pull/4901
Description of the changes
Install cmaes in the samplers CI

@HideakiImamura Could you review this PR?


Adding GUI with resources

Added GUI resources featuring Wood, Stone, and Gold, along with accompanying text displaying the settled amount of 10,000.

The area of this GUI is far too large.


IP Address of API Server

I am using AKS cluster with advanced networking. I applied subnet-wide NSG with limited outbound connectivity. I want to lock down outbound communication from the cluster as part of security hardening processes to only communicate to the API server.
I allowed VNET Ports * -> Internet Ports 80,443 (outbound internet connectivity). All other outbound traffic was blocked. With this rule in, commands like kubectl exec, kubectl logs and helm ls timed out. I suspect this is because of outbound connectivity problems to the API server.
Hence this documentation line seems to be insufficient:
The virtual network for the AKS cluster must allow outbound internet connectivity.
I then enabled this outbound rule:
VNET Ports * -> AzureCloud Ports *
The commands above started working again.  Can you confirm:

Which ports the worker nodes are using to communicate to the API Server?
Is the IP address of the API Server static, and can be used in NSG rules?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 37ba0343-7e43-6e2e-e564-5d3a0f523a75
Version Independent ID: 0ba581a1-3e4a-27b4-c667-4a9b969a3ade
Content: Configure Azure CNI networking in Azure Kubernetes Service (AKS)
Content Source: articles/aks/configure-azure-cni.md
Service: container-service
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

Thanks for the question! We are investigating and will update you shortly.

@iainfoulds Please take care of this issue.

Locking down the traffic for outbound connectivity isn't currently a supported option. There is on-going work on the roadmap for this, along with IP address whitelisting to allow private access to the API server. For now, the doc is correct in it's guidance in that the cluster needs outbound internet connectivity. You can create a feature request to the product team to help prioritize this ability at https://feedback.azure.com/forums/914020-azure-kubernetes-service-aks
@jakaruna-MSFT This is a product question rather than docs #please-close

Partial answer found here:
https://github.com/kevingbb/ready-aks-security
Lock down outbound to Port 22,443 to AzureCloud service tag.


Remove asserts from tls_gcc.h

These asserts are for checking whether the thread_local storage variable has been initialized or not. On platforms with gcc, thread_local variables do not need to be initialized and hence this assert is not needed here. tls_pthread which actually requires initialization already has an assert and would fail if used without being initialized.

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

Known Issues #13124, #10092, #12510


XHR: Failed Loading (Kajax)

Just wondering if failed loading is expected given the code below or if there is some idiomatic/alternative way to use ajax for authentication.
I'm using jester for the server and it responds with a 200 OK as expected.
import karax / [vdom, karax, karaxdsl, kajax]
import json

var isloggedin = false

proc login() =
  var j = newJObject()
  j["email"] = ($getVNodeById("email").getInputText).newJString()
  j["password"] = ($getVNodeById("password").getInputText).newJString()
  proc cb(stat: int, resp: cstring) =
    if stat == 200:
      echo "Success"
      isloggedin = true
  ajaxPost("http://localhost:5000/login", @[], $j, cb)

proc createDom(): VNode =
  result = buildHtml(tdiv):
    if not isloggedin:
      section:
       h3: text "Login Form"
      section:
        form:
          label(`for`="input1"): text "Email"
          input(`class` = "input", `autocomplete`= "username",id = "email")
          label(`for`="input2"): text "Password"
          input(`class` = "input", id = "password",`autocomplete`="current-password",`type`="password", onkeyupenter = login)
          button(onClick = login): text "Submit"
    else:
      tdiv:
        text "You are Logged In"

setRenderer createDom

Could you provide more details here? This looks correct to me, however you may be running into CORS when you try and make a request to the Jester backend. If you are running the Karax code using karun, then it will be on a different port, and so a different domain than the Jester server. The browser would then prevent the connection from going through as a security policy. If you are running into a CORS errors, you may need to try proxying, disabling CORS for development purposes in your browser, or serving the Karax frontend from Jester itself, as a static file.
If you could provide a screenshot/error message that would be very helpful in further tracking down the issue!

@ajusa Yes, I think that was the problem.


Show error message if upload failed

Currently upload continues as if nothing bad happened, and then shows preview. We should state when we get an error.

Referenced from #7


⚠ Bofrost.es has degraded performance

In 3d7c33a, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1665 ms

Resolved: Bofrost.es performance has improved in 2893ecf.


ObservableScrollView started wrong Y position

I've a reycleview with cardviews and if i click on them it opens an other activity. But the first item always appeared like this:

And then the second item is showed correct:

Does someone know how to solve this?

+1

+1


We are restricted to selecting only "standard regions".

What happened:
We are unable to execute Athena queries using the "me-central-1" region within the "Amazon Athena" data source. We attempted to manually input "me-central-1" into the "Default Region" field in the data source settings, but this did not resolve the issue.
What you expected to happen:
When utilizing the "Amazon Athena" data source, we anticipate the ability to select non-standard regions, such as "me-central-1", from the "Region" dropdown menu within the Grafana interface. This would enable us to execute Athena queries within the UAE region.
How to reproduce it (as minimally and precisely as possible):

Configure a data source using "Amazon Athena".
Click the "Region" dropdown menu and review the available regions.
"me-central-1" is absent from the list, preventing us from executing Athena queries within the UAE region.

Environment:

Grafana version: 10.2.3
Plugin version: 2.11.1
User OS & Browser: Windows & Google Chrome (125.0.6422.142)

Hello @mitsu-nishi!
Thank you for reporting this issue to us. I see 3 bugs here:

one I think we should allow users to type in any region as a string if we're missing a region. We do this in other datasources and I think it works well. AWS is frequently updating new regions and we will always be a bit out of date.
We should add me-central-1 to our list of standard regions for athena (see here)
We should also add this region to our list of standard regions in the grafana-aws-sdk (whcih is used in our configuration settings) and ultimately pull the list for the query editor from this list so that we have once source of truth https://github.com/grafana/grafana-aws-sdk-react/blob/54fc2b4424d9a94961a2ccb6c4af9c38a0899541/src/regions.ts#L4

Will talk with the team about when we can prioritize working on this. Thanks again!

Hello @sarahzinger
Thank you for your reply.
I would also like to request support for the following regions, as they are experiencing similar issues.
・ap-south-2
・ap-southeast-3
・ap-southeast-4
・ca-west-1
・eu-central-2
・eu-south-2
・il-central-1
・me-central-1
This would be helpful for future use cases.
Thank you for your consideration.

Released a new version with the new regions: https://github.com/grafana/athena-datasource/releases/tag/v2.17.1


Add "Totems popped from X" stats

We already have "Damage from X" and "Totems popped", so maybe find a way to combine them?

Fixed by 4350d1d


(APS-643) Add an info_requested task status

This allows CRU managers to see at a glance what assessments are awaiting information requests from PPs.

I'm on it now 👍


Check for whitespace around operators

I'm looking for an option to check for whitespaces around operators, but cannot find it, yet.
I did find a mention of this feature not being implemented yet, from 2016 though.
examples would be

too less/many spaces around operator:

i=  3

no spaces after ,

for var_1,···,var_n in explist do body end

I realize its not an easy to implement check, due to its context sensitivity, but would like to state I'm missing this feature.
Maybe someone comes along feels the same, and leaves a :+1:.
This project is really nice to have around, thanks!

[...]
Ideally luacheck would also check for correct amount of whitespace around operators, parens, etc., but that would require more cooperation with the parser, and also it will be more complex to support customization. The warnings you suggested don't seem to need any options.
I haven't touched luacheck code in a while, and contributions are most welcome! I think that the way to do this would be to modify the lexer to consider whitespace a token, with exactly one whitespace token between each two consecutive normal tokens. Then the parser can call a function provided by the checker on each token. That function would check whitespace tokens and issue warnings.

Originally posted by @mpeterv in https://github.com/mpeterv/luacheck/issues/79#issuecomment-260404880
I was just made aware of his passing away and hope this repo is the right place to follow up on this.

I think this is out of scope for Luacheck and should rather be a formatter's job to fix and/or check. Luacheck is supposed to check likely semantic issues rather than formatting issues. The only warning where Luacheck checks formatting is with mixed indentation, which is severe and universal enough that it seems reasonable.


DOMParser is not defined error when initializing client in Web Worker

Package Version: 2.0.8

[ ] nodejs

nodejs version: ______
os name/version: _____

[x] browser

name/version: Chrome Version 85.0.4183.121

Describe the bug
When initializing a ms-rest-js client within a web worker, an error is thrown: DOMParser is not defined. DOMParser is not available within a web worker. This prevents the client from being used from within a web worker.
To Reproduce
Steps to reproduce the behavior:

Create a web worker using code similar to the following (substitute ClientName, token, and customBaseUri for valid values--ClientName should be a client derived from msRest.ServiceClient; the other values might be optional depending on the client that is tested)

onmessage = () => {
  const client = new ClientName(new TokenCredentials(token), {
    baseUri: "customBaseUri"
  });
};

Send a message to the web worker to invoke this code
Note error logged in browser console:

Uncaught ReferenceError: DOMParser is not defined
    at<EMAIL_ADDRESS>(xml.browser.js:3)
    at __webpack_require__ (bootstrap:19)
    at<EMAIL_ADDRESS>(deserializationPolicy.js:1)
    at __webpack_require__ (bootstrap:19)
    at<EMAIL_ADDRESS>(serviceClient.js:1)
    at __webpack_require__ (bootstrap:19)
    at<EMAIL_ADDRESS>(msRest.js:1)
    at __webpack_require__ (bootstrap:19)

Expected behavior
The client should initialize successfully within a web worker.
Screenshots
Screenshot of error in browser console:

Additional context
N/A

@adamra-msft We use DOM api to parse and build XML in browsers.  Web Worker don't have access to DOM api.  We are still investigate a proper fix.  In the mean time, would the workaround suggested here work for you?

@adamra-msft We use DOM api to parse and build XML in browsers.  Web Worker don't have access to DOM api.  We are still investigate a proper fix.  In the mean time, would the workaround suggested here work for you?

@jeremymeng  I am having the same issue in Beekeeper Studio. The workaround suggested in the core-http issue did not work for me.

I'm only looking to use the node-mssql library which depends on tedious. I'm not sure why they need this library, but so it is.

@rathboma if possible, could you please provide a simple project that demonstrates the issue when using node-mssql? That would help our investigation greatly!

So this isn't a self-contained reproduction, but Beekeeper is FOSS, so if you are able you can check out this branch:

https://github.com/beekeeper-studio/beekeeper-studio/pull/641

Then yarn install, yarn electron:serve to start it,
you can connect to any database, the easiest is Beekeeper's own db: help -> add Beekeepers Db
Then go to a table, right click, export. You'll see the error in the console.


[Bug]: Failed to connect to Browser using CDP WebSocket URL

The script hangs when attempting to connect to the browser using chromium.connect() with a timeout set to 0 (no timeout).
When a timeout value is specified (e.g., 10000ms), the following error occurs:  browserType.connect: Timeout 10000ms exceeded.
Steps to reproduce and code example:
I created a simple script as provided in the documentation: https://github.com/CheshireCaat/playwright-with-fingerprints?tab=readme-ov-file#launching-the-browser
const { plugin } = require('playwright-with-fingerprints');
const { chromium } = require('playwright');
const path = require('path');

(async () => {
 // Define the base directory and working folder for storing data
 const baseDir = path.normalize(path.join(path.dirname(require.main.filename), '..'));
 const workingFolder = path.normalize(path.join(baseDir, '.data'));
 plugin.setWorkingFolder(workingFolder);

 // Launch a browser instance with the plugin
 const chrome = await plugin.spawn({ headless: false });
 const wsEndpoint = chrome.url;
 console.log('chrome launched, wsEndpoint: ', wsEndpoint);

 // BUG: The script hangs before this point if the timeout is set to 0 (no timeout).
 // If a timeout is set, the following error is encountered:
 // Error message: browserType.connect: Timeout 10000ms exceeded.
 const browser = await chromium.connect(wsEndpoint, {
   timeout: 10000,
 });
 console.log('browser');

 const page = await browser.newPage();
 await page.goto('https://google.com/?hl=en');
 console.log('page');

 await browser.close();
 await chrome.close();
})();

Expected behavior
The script should successfully connect to the browser instance using the WebSocket URL provided by plugin.spawn() without timing out.
System:

Plugin version:

"dependencies": {
    "playwright": "1.49.1",
    "playwright-with-fingerprints": "2.0.5"
  },

Node version: v22.11.0

I want to point out that my main working path involves starting the browser from this plugin and then connecting to the WebSocket endpoint URL from another script.
This is why this functionality is so important to me.

@sergerdn it seems to me that it's playwright related issue. I'll try to figure it out, but not as a priority. You can use an alternative method to connect:
const chrome = await plugin.spawn({ headless: false });
const wsEndpoint = chrome.url;
console.log('chrome launched, wsEndpoint: ', wsEndpoint);

const browser = await chromium.connectOverCDP(`http://localhost:${chrome.port}`, {
  timeout: 10000,
});
console.log('browser');

You can use an alternative method to connect:

Thanks, it works!
However, for some reason, after I connect via chromium.connectOverCDP, it opens a new browser window.
Is that normal? I was expecting a new browser tab, not a new window.

Yes, this is how it works, because your code creates separate context (window), if you wanna reuse window, you can work directly with default browser context, i.e:
const defaultContext = browser.contexts()[0];

const page = await defaultContext.newPage();
await page.goto('https://google.com/?hl=en');
console.log('page');

await browser.close();
await chrome.close();

@CheshireCaat
Thank you so much, you saved me a lot of time!


Split CI command into two

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (1d59640) to head (21d93f9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            9         9
  Lines         1865      1865
=========================================
  Hits          1865      1865

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Status to an option

pending (wish)
validated
archived

do a special front color when not validated

Possibility to add option to change automatically the status after certain time/nb votes + do it by admin member

Do a notification when option status changes


By 06/23: Finalize dates for the Mining and Stacking Products Hackathon

@shannon & @jenny

[ ] Confirm proposed date with BMWG
[ ] Secure legal approval for hackathon

Just a heads up. I think you have the wrong Shannon tagged here. I don't know anything about this project.

Just a heads up. I think you have the wrong Shannon tagged here. I don't know anything about this project.

Sorry about that! Thanks for the heads-up.


How to use customized images for Icons instead of Flutter-integrated icons?

thanks.

Hi @zinwalin , it doesn't support it directly in the current version.
At the moment the FFNavigationBarItem has a private method _makeIcon which creates a Widget which will be used as the child of the CircleAvatar element.
Widget _makeIcon(
    IconData iconData,
  ) {
    bool isSelected = _isItemSelected();
    return Icon(
      iconData,
      color: isSelected
          ? selectedForegroundColor ?? theme.selectedItemIconColor
          : theme.unselectedItemIconColor,
    );
  }

You could try modifying this to return an image (asset or network) instead of the icon, which would still be a valid child of the CircleAvatar element.


Remove application_form from ApplicationExperience

Context
Currently, the application_experience is linked to an application_form
through the experienceable polymorphic columns on the application_experience
model
This commit removes the old link, through the application_form_id, the
column will be dropped in a future PR.
There are a few places where we want to make sure the experienceable
model is of type ApplicationForm, to do this an application_form
method in the ApplicationExperince model exists.
We also need to touch the application_form and application_choices like
the old relation did, to replicate the old behavior
Changes proposed in this pull request
ApplicationExperience model
Guidance to review
Create and edit work experience on review or local
Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[ ] API release notes have been updated if necessary
[ ] If it adds a significant user-facing change, is it documented in the CHANGELOG?
[ ] Required environment variables have been updated added to the Azure KeyVault
[ ] Inform data insights team due to database changes
[x] Make sure all information from the Trello card is in here
[x] Rebased main
[x] Cleaned commit history
[x] Tested by running locally
[x] Add PR link to Trello card

 Edit work experiences - Change db structure to accommodate work experience edits


Update Readme

Provided more background info and made easier to read

Overall the updates look good.  I did fix  a few grammatical errors.  Please see the inline comments.
This looks like a very interesting project!


Port Tunernome

Description

Ported Tunernome. No material improvements made yet.
Chromatic tuner LED positions are no longer correct, but I'm waiting for 2024 hardware before I can fix them.
Test Instructions

All controls and functions were tested on both the emulator and 2023 hardware.
Ticket Links

Closes #17.
Readiness Checklist

[x] I have run make format to format the changes
[x] I have compiled the firmware and the changes have no warnings
[ ] I have compiled the emulator and the changes have no warnings

Only warnings about button enum values unhandled in switch statements still exist

[x] I have run make cppcheck and checked that cppcheck_result.txt has no warnings for the changes
[x] I have added doxygen comments to any code used by more than one Swadge mode. This includes /*! \file comments with Design Philosophy, Usage, and Example sections for new headers.
[x] I have run make docs and checked that doxy_warnings.txt has no warnings for the new code

Only warnings about button enum values unhandled in switch statements still exist

When you make later fixes, clean this up too. Even if you explicitly list the buttons in the default: case, it'll be clear that those buttons don't do anything (and maybe they should?)

Looks like you're using arrow12.png and arrow18.png, but you added 42 different arrows. Please prune the ones you're not using.


CLI not working on Windows 10

Description
Version:  0.26.0-alpha5
Getting an error trying to run the CLI on Windows 10:  "open locales\en: file does not exist"
Steps to reproduce

Download CLI for Windows
Run CLI, get error

Also tested with 0.25.0 with the same result.

@rkpattnaik780 Do you have windows machine?
We should enable tests and build on windows for github actions in long run

@rkpattnaik780 Do you have windows machine?
Nope I have only linux here.
We should enable tests and build on windows for github actions in long run
Yes, that will be great to have.

Looks like path problem:
https://github.com/redhat-developer/app-services-cli/blob/main/pkg/localize/goi18n/go_i18n.go#L47
We can fix it and verify in CI/CD

Replicated problem and identified issue. On PTO so looking if anyone else could make change.
CC @pmuir


Search by specific jobs

Hey y'all, I came across this super cool gem a while ago and decided to give it a try.
However, something I felt a bit weird is that there's no way of filtering/searching by specific jobs in the Web integration page

Sidekiq Web Integration

This gem provides an extension to Sidekiq's web interface with an index at /statuses.

Is there a way of searching only for specific jobs? i.e. MySpecificJobClass?
In our real app, we have hundreds if not thousands of jobs where we use the Sidekiq::Status::Worker  but without such option it becomes a bit hard to really take advantage of the whole gem.
In case there isn't such functionality, would you mind if I open a PR adding it? I'd just ask for some guidance in which files/folder this UI part is being implemented in the code
Thanks!

@kenaniah , any chance to take a look at this?
We are also running into #42 , so it would be great if @Andy9822 can explore an approach to help with that.


plugins: externalize podman driver

@ssbarnea what does it mean "externalize"?

Hi @sshnaidm, it means all the driver code will be maintained in another repository and molecule will load drivers as plugins. Molecule is moving towards a plugin architecture.

Done in master and hosted at https://github.com/ansible-community/molecule-podman


Getting ready to publish

use extracted zipkin-simple package (https://github.com/paolochiodi/zipkin-simple)
add unit tests
add readme
add options to configure zipkin location

REAME already contains links to npm, travis and coveralls but we'll need to actually configure those on the main repo

Also, on david

Updated with __tracer__


How would this be linked in Android Studio?

I am doing a project which needs butterworth filtering, and can't seem to find libraries for DSP in android.
Do you have any directions as to how I can use this in my project?

See the readme. Just install it with maven, then add the dependency to android studio and off you go.
Check out AttysECG for example how it's done.


[Dev→master] Input test scene updates

Overview
Bringing scene updates from Dev branch. Visual (layout & material) updates. No code changes.
Updated FloorMaterial to have a clear visualization of the borders.
Before & After images

Updated Floor material with MRTK/Standard shader

Merged Patch4_Dev and may18_dev. Now, this PR only shows the changes for the two input test scenes.


As an author, I want to pull in my github activity to my “stream”

Github activity is present on user profile


Have TeamCityDisposableExtensions extend ITeamCityProvider

See title. Currently TeamCityDisposableExtensions extends TeamCityProvider and therefore aren't accessible by default.

Closed via #763.


Enhance workflow logs

Description
This PR adds more logs to runtime for better debugging.
Issue reference

Please reference the issue this PR will close: #7065
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@mukundansundar a reminder that we are blocking workflow PRs until https://github.com/dapr/dapr/issues/7241


Add Tech University of Korea domain

I want to add a domain for Tech University of Korea. Below is the official website of the school.
https://www.tukorea.ac.kr/tukorea/index.do

@1024ho I am sorry, the domain tukorea.ac.kr is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


bintools-wrapper: Add dynamicLinker for uClibc

Description of changes
The dynamic linker of uClibc has file name ld-uClibc.so.1 or ld64-uClibc.so.1. Add a case to handle targetPlatform.libc == "uclibc" or target programs will be compiled with a nonexistent dynamic linker.
Without this fix:
$ cat > hello.c
#include <stdio.h>
int main() {
    printf("Hello uClibc\n");
}
$ $CC -o hello{,.c}
$ file hello
hello: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /nix/store/s3m4p74n671np7dpdn10dnl8nizzi389-uclibc-ng-x86_64-unknown-linux-uclibc-1.0.41/lib/ld-linux-x86-64.so.2, not stripped
$ ./hello
bash: /home/dram/hello: No such file or directory

With this fix:
$ $CC -o hello{,.c}
$ file hello
hello: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /nix/store/s3m4p74n671np7dpdn10dnl8nizzi389-uclibc-ng-x86_64-unknown-linux-uclibc-1.0.41/lib/ld64-uClibc.so.1, not stripped
$ ./hello
Hello uClibc

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Pulled. Thank you!


server: bind port lazily when it's configured

What have you changed? (mandatory)
This PR make TiKV only listens to given port when it's started. Note that listening to port before everything is prepared is a mistake and can lead to unexpected bugs like #4224.
Binding port before server is started is required by our tests to avoid port conflict. So this PR delays binding port only when it's configured.
What are the type of the changes? (mandatory)

Bug fix (change which fixes an issue)

How has this PR been tested? (mandatory)
manual tests
Does this PR affect documentation (docs) update? (mandatory)
No.
Does this PR affect tidb-ansible update? (mandatory)
No.
Refer to a related PR or issue link (optional)
Close #2999
Close #4224

Is there any integration test to cover https://github.com/tikv/tikv/issues/4224?

#4224 is expected because messages should not be sent before raftstore is started.

/run-integration-tests

/run-integration-tests


Create contex manager for vManageSession object

Description

[ ] logout() #304
[ ] context_manager #304

Login is already implemented in as an auth attribute.

This issue was migrated from an old repository: https://github.com/CiscoDevNet/catalystwan/issues/82


Tracking coin3d package versions on downstream distros

Original report by luz paz (Bitbucket: [Chitty Cloud](https://bitbucket.org/Chitty Cloud), ).

There is a very cool project called Repology. You can use it to track downstream integration of a package and see if distros are up to date with in this case coind3d. Perhaps this is something that could be added to the README ?
Here's an example:

Hi,
I think that the badge for Coin4 package should be added as well
https://repology.org/project/coin4/versions
At least for Fedora and OpenMandriva the main version is added to Coin project name in order to install both versions if/when required.
Regards
Giampiero

Possibly the badge should be listed here as well: https://github.com/coin3d/coin/wiki

Done.


Save and load history

The client should save conversations and allow loading conversations from history.
Furthermore, conversation history should be searchable.

For the record, I believe the location for saved history should be at ~/.local/share/hummingparrot.

Implemented in 44a4dcde74bd0c30777369689c3b23c3034dfd6b


Sample data script does not add the data to the docker container per tutorial

Hi. I'm following along with the demo tutorial to get a basic implementation up and running. It successfully connects to the running server, but it downloads the sample data to my local app data, which then becomes unavailable to the app.

I've confirmed this behavior on multiple Windows machines, so I believe it's a bug. In the meantime, is there a way I can manually add the sample data to the server to get unblocked?

I got the same problem following the tutorial. Is there any update about this topic?


FW-1594:Lifecycle Refactors, Operation, & Service

@dy2288 Please let me know if you have any questions about changes and we can chat about the changes to PublisherService.


TTN V3

We're looking to migrate out TTN gateways to v3 as and when needed, so we need to look at using V3 in our code.
This looks to still be at v2.   What's the status, if any, on planned TTN v3 compatibility.
If it's none, that's fine, just nice to know.

this is a dup of
https://github.com/adafruit/Adafruit_CircuitPython_TinyLoRa/issues/37
?
we'd love to have the community or TTN help with V3 implementation!

Ah, that is just titled downlink not v3.
Hope someone that knows how to can fix it :-)


chore: added more test websites for cloudflare

Added registry of Cloudflare protected websites. I left the old websites commented so we know how the original benchmark.

Cool! Would be worth making this a part of the automatic CI - maybe on the Apify Platform, using fp-suite with full proxy setup? I'll try to look into that :)


1.0 release

Just a reminder for us to do it. Ideally it should happen alongside RuboCop 1.0, but that's not a hard requirement.
I don't think there's anything blocking us from doing 1.0 at any moment.

Yeah. Would be a good time for #22

1.0 released 🎉


Task shell integration cannot be disabled

VS Code Version: insiders/from sources

Task terminals don't respect "terminal.integrated.shellIntegration.enabled" setting so decorations cannot be disabled.

we're separating the task decorations from terminal decorations (shell integration), so will have a tasks.showDecorations setting

Verified that task.showDecorations works


Updating Muscle Torques mid-simulation - how does it work?

I am trying to build a custom gymnasium environment for my own RL project using PyElastica.
I've been digging into the muscle_torques_with_bspline.py for Case 1 to try and understand the nuts and bolts of how muscle torques are changing mid-simulation.
In an attempt to compare it with a PyElastica example were forces/torques applied to rods aren't changing throughout the simulation, I looked at axial_stretching.py which brought me to the EndPointForces class.
I am still not clear how muscle_torques_with_bspline.py allows for an RL agent to change the torques within a rod while the simulation is running. Could this be explained?
I'm happy to provide additional details to clarify my question if that's useful.
Thanks in advance!

Hi @saultshaker,
Nothing in the classes themselves that is changing muscle torques mid-simulation, what is happening is that we change the value of the inputs to the classes during the timestepping. If you look at set_environment.py in the step method we change spline_points_func_array_normal_dir using the action from the RL agent, note that we don't redefine spline_points_func_array_normal_dir but rather change the values in the array so it is the same input we gave to the MuscleTorquesWithVaryingBetaSplines class but with a different value value.
Let me know if that makes sense!

Hi @Ali-7800
Thank you for your response! I am still trying to understand this a bit better. A few questions:

I noticed that self.simulator.finalize() is called as part of the reset() method. My naive understanding is that the reset() method is called once per episode, and that the finalize() method prevents changes to a PyElastica simulation. How does updating the values of  spline_points_func_array_normal_dir in the step() method update the muscle torques when MuscleTorquesWithBetaSplines is called in the reset() method as part of  self.simulator.add_forcing_to(self.shearable_rod)?

Is self.simulator.add_forcing_to(self.shearable_rod) called and/or updated every step so that the updated values assigned by the RL agent affect the simulation?

Is it important that the MuscleTorquesWithVaryingBetaSplines class is module that is imported to the set_environment.py file? Is that required for it to play nice and update with the RL agent?

Thank you so much for your time on this!

Hi @saultshaker,

The finalize() method prevents changes like adding a rod, a forcing class, a connection, etc. However, that does not mean you cannot modify already existing parts of the simulation like spline_points_func_array_normal_dir. The reset() method sets up the simulation each episode while the step() method does the time stepping for each episode and while timestepping it modifies spline_points_func_array_normal_dir.

No this is only called with each reset(), In each do_step() in step() it calls the apply_forces() and apply_torques() methods of the class you already added with self.simulator.add_forcing_to(self.shearable_rod) in reset().

It does not have to be imported into the file, you can move it in set_environment.py and it should still work.

Hi @Ali-7800,
Thank you so much for this! I've been so busy with all of my code working because of the wonderful feedback you provided that I forgot to close out this issue. Thank you again, this was tremendously helpful!


Errors running tutorials

data_loader.ipynb
For context, I am setting basedir = '/Users/soeren.becker/repos/sfaira/sfaira/data'.
The first thing that I noticed is that, in contrast to the notebook from the github repository,  print(ds.adata)  returns None. This is not an error but maybe it helps explaining some errors downstream.

This is because the data was not downloaded, see below.

Running ds.datasets['mouse_pancreas_2019_10xsequencing_thompson_004_10.1016/j.cmet.2019.01.021'].annotatedthrows an error: KeyError: 'mouse_pancreas_2019_10xsequencing_thompson_004_10.1016/j.cmet.2019.01.021'. My guess is that the name somehow changed as ds.datasets['mouse_pancreas_2019_10x3v2_thompson_004_10.1016/j.cmet.2019.01.021'].annotated runs and returns True.

[ ] Yes indeed the data set key changed as we updated technolgoy versions. This ID will stay fixed now and we can update the key in the tutorial.

In the next cell, ds.datasets['mouse_pancreas_2019_10xsequencing_thompson_004_10.1016/j.cmet.2019.01.021'].load() again throws a key error. However, ds.datasets['mouse_pancreas_2019_10x3v2_thompson_004_10.1016/j.cmet.2019.01.021'].load()also throws an error: FileNotFoundError: [Errno 2] No such file or directory: '/Users/soeren.becker/repos/sfaira/sfaira/data/raw/GSE117770_RAW.tar' This error I could not resolve so far so I haven't run the rest of the tutorial yet.

[ ] This dataset is not downloaded yet. We need to add a download statement from the universe instance at the top of that notebook? Maybe also switch to a data set that does not have private meta data.

user_interface.ipynb

ui.data.obsm throws an error: AttributeError: 'DatasetInteractive' object has no attribute 'obsm' .

[ ] This is trying to access adata.obsm I assume, this would be ui.data.adata.obsm, ui.data is a Dataset.

There are also errors downstream from there, but they might just be the result of this error, I think.

I think so too.

pbmc3k.ipynb

(I think this first error is unrelated to sfaira as I also get this error when just running the corresponding scanpy_tutorial; just mentioning it for completion: In the final pre-sfaira cell (for me cell [31]), sc.pl.umap(adata, color='leiden', legend_loc='on data', title='', frameon=False) results in an error: AttributeError: 'Float64Index' object has no attribute 'add_categories' .)

[ ] I think the issue is that leiden in obs is float, we could address this in the tutorial by redefining that in the adata that is given to the DatasetInteractive.

When running ui = sfaira.ui.UserInterface(   custom_repo=os.path.join(model_dir_sfaira),   sfaira_repo=False ), I get the following error: ValueError: No model weights found in ../../sfaira/sfaira/models/ Weights need to have .h5 or .data-00000-of-00001 extensionto be recognised. This is indeed true, there are no such files under  ../../sfaira/sfaira/models/ .

[ ] I think there is either an explicit download missing or a defaulting to download of weights missing.

I am wondering whether this error occurs as I did not complete the other tutorials before? Also, in case there is an intended order in which the tutorials should be carried out (as they depend on each other's output?), it might be worthwhile to mention this here: https://sfaira.readthedocs.io/en/latest/tutorials.html

Thanks for the issue, @soerenab!

Hello,
I also got errors running the tutorial. Besides the "Float64Index" error above, the following error occur while running ui.load_model_embedding():
KeyError: 'organism'
It was caused by the following function call:
File "_overloaded_dict.py", line 100, in getitem
return self.data[key]
It's greatly appreciated if anyone can show me how to fix this error.
Many thanks!

hello，I also got the error : KeyError: 'organism'

All errors mentioned in this issue are now addressed in the latest version of the notebooks. Some of the fixes required changen sfaira code. Version 0.3.7 will contain all the necessary changes that will allow error-free execution of the notebooks. To already get these changes now, you can install the fix_tutorials branch of sfaira until version 0.3.7 is released.
Thank you very much for the bug reports!

the error is raised by the download of ontology files by sfaira from here, not the download of the dataset: https://raw.githubusercontent.com/obophenotype/cell-ontology/v2021-02-01/cl.obo

ui.load_data(sc.datasets.pbmc3k(), gene_symbol_col='index', gene_ens_col='gene_ids')  # load your dataset into sfaira

got errors:
SSLError: HTTPSConnectionPool(host='raw.githubusercontent.com', port=443): Max retries exceeded with url: /obophenotype/cell-ontology/v2021-02-01/cl.obo (Caused by SSLError(SSLEOFError(8, 'EOF occurred in violation of protocol (_ssl.c:1122)')))

Could you also provide website URL to download the datasets?

It looks like your internet connection is bad (not connected?). Sfaira caches these ontology files so you do not need internet connection every time you use it, but you do need it the first time that you use meta data that requires caching.

Thanks for your help, it is the problem of my internet.


Add non GUI mode

It would be cool if you could use this project as a library or as a console command to automate the translation process

if you want to use a quick and dirty headless/CLI mode you can import argparse and add these couple of lines in comic.py main function
        if args.file_path:
            test.thread_load_images(file_path)

        if args.headless:
            test.start_batch_process()
        else:
            test.show()

if you want to use a quick and dirty headless/CLI mode you can import argparse and then add these couple of lines in the comic.py main function
        if args.file_path:
            test.thread_load_images(file_path)

        if args.headless:
            test.start_batch_process()
        else:
            test.show()

Thanks, so how can I use it?


Opening PDF is hanging

I reinstalled vips using homebrew the other day and now I am unable to open pdf files with ruby-vips. I also upgraded to Big Sur a couple of months ago.
In IRB, I get:

Vips::Error (VipsOperation: class "pdfload" not found)

I have:

Uninstalled vips
Uninstalled poppler (I had two recent versions installed with homebrew)
Reinstalled poppler
Reinstalled vips (8.11.0 now)
Updated ruby-vips

$ vips --vips-config
enable debug: no
enable deprecated library components: yes
enable modules: yes
enable docs with gtkdoc: no
gobject introspection:  yes
RAD load/save: yes
Analyze7 load/save: yes
PPM load/save: yes
GIF load:  yes
generate C++ docs: no
use fftw3 for FFT: yes
accelerate loops with orc: yes
ICC profile support with lcms: yes (lcms2)
zlib: yes
text rendering with pangocairo: yes
font file support with fontconfig: yes
EXIF metadata support with libexif: yes
JPEG load/save with libjpeg: yes (pkg-config)
JXL load/save with libjxl: no (dynamic module: no)
JPEG2000 load/save with libopenjp2: yes
PNG load with libspng: yes
PNG load/save with libpng: yes (pkg-config libpng >= 1.2.9)
8bpp PNG quantisation: yes
TIFF load/save with libtiff: yes (pkg-config libtiff-4)
image pyramid save: yes
HEIC/AVIF load/save with libheif: yes (dynamic module: yes)
WebP load/save with libwebp: yes
PDF load with PDFium:  no
PDF load with poppler-glib: yes (dynamic module: yes)
SVG load with librsvg-2.0: yes
EXR load with OpenEXR: yes
slide load with OpenSlide: yes (dynamic module: yes)
Matlab load with matio: yes
NIfTI load/save with niftiio: no
FITS load/save with cfitsio: yes
Magick package: MagickCore (dynamic module: no)
Magick API version: magick7
load with libMagickCore: yes
save with libMagickCore: yes

I am able to open a pdf at the command line:
$  vips pdfload test.pdf test.jpg
$

And test.jpg is created.
In IRB:
irb(main):001:0> require 'vips'
=> true
irb(main):002:0> Vips::Image.pdfload('/Users/brandoncc/Downloads/test.pdf')
Traceback (most recent call last):
        9: from /Users/brandoncc/.asdf/installs/ruby/2.5.7/bin/irb:11:in `<main>'
        8: from (irb):2
        7: from /Users/brandoncc/.asdf/installs/ruby/2.5.7/lib/ruby/gems/2.5.0/gems/ruby-vips-2.1.2/lib/vips/image.rb:234:in `method_missing'
        6: from /Users/brandoncc/.asdf/installs/ruby/2.5.7/lib/ruby/gems/2.5.0/gems/ruby-vips-2.1.2/lib/vips/operation.rb:350:in `call'
        5: from /Users/brandoncc/.asdf/installs/ruby/2.5.7/lib/ruby/gems/2.5.0/gems/ruby-vips-2.1.2/lib/vips/operation.rb:170:in `get'
        4: from /Users/brandoncc/.asdf/installs/ruby/2.5.7/lib/ruby/gems/2.5.0/gems/ruby-vips-2.1.2/lib/vips/operation.rb:170:in `new'
        3: from /Users/brandoncc/.asdf/installs/ruby/2.5.7/lib/ruby/gems/2.5.0/gems/ruby-vips-2.1.2/lib/vips/operation.rb:67:in `initialize'
        2: from /Users/brandoncc/.asdf/installs/ruby/2.5.7/lib/ruby/gems/2.5.0/gems/ruby-vips-2.1.2/lib/vips/operation.rb:67:in `new'
        1: from /Users/brandoncc/.asdf/installs/ruby/2.5.7/lib/ruby/gems/2.5.0/gems/ruby-vips-2.1.2/lib/vips/operation.rb:204:in `initialize'
Vips::Error (VipsOperation: class "pdfload" not found)

In Rails Console:
[1] pry(main)> Vips::Image.pdfload('/Users/brandoncc/Downloads/test.pdf')
_

It hangs in Ruby!
Any help would be greatly appreciated.

Hi @brandoncc,
It looks like you have a couple of libvipses installed. Your CLI is using an old version (with pdf support) and ruby is picking up the new homebrew one (pdf support seems to be missing). I'd remove the old libvips to reduce confusion.
Your second problem is that homebrew appear to have removed support for poppler. I'll have a look.

Ah it's the new dynamic module system -- it's not working on macOS. I'll dig a bit more.

libvips is unable to find the PDF load module. As a workaround you can do this:
$ export VIPSHOME=/usr/local
$ irb
irb(main):001:0> require "vips"
=> true
irb(main):002:0> Vips::Image.pdfload("something.pdf")
=> #<Image 303x496 uchar, 4 bands, srgb>
irb(main):003:0>

I'll see if I can improve module discovery.

I've made some changes to the way libvips finds library files and it's working in homebrew now. These improvements will be in 8.11.1. In the meantime, I'd use VIPSHOME as a workaround.

Thank you @jcupitt !

Hello again @jcupitt,
IRB works now, but rails console is still hanging in an application where we have used ruby-vips for years. I haven't been able to figure out how to get a stack trace out of the hung process yet, but I will post it here if I manage to do so.

Fun....I just downgraded to 8.10.6 and it is still hanging 😦
There goes the rest of my day debugging or just reinstalling my OS!

Okay, I got it working after downgrading. Things I did:

wget https://raw.githubusercontent.com/Homebrew/homebrew-core/7b09694a24d23218aa7228493d12f2ad56d0a8a6/Formula/vips.rb
brew install vips.rb (didn't work)
brew install -s vips.rb (required me to upgrade xcode command line tools first) -- this worked
brew uninstall vips
brew install vips -- trying 8.11.0 again since command line tools were upgraded and I saw 8.10.6 start working again -- didn't work
brew uninstall vips
brew install vips.rb -- worked this time

I am now able to open pdfs again:
[1] pry(main)> Vips::Image.pdfload('/Users/brandoncc/Downloads/test.pdf')
=> #<Image 594x594 uchar, 4 bands, srgb>

Another workaround would be to configure vips with --disable-modules. That'll stop it building the pdf loader as a dynamic module and instead build it as part of the main vips library.

Thanks, I'll keep an eye out for 8.11.1 and test that. If it doesn't resolve my issue, then I will go that route. I assume I must be able to pass that flag to homebrew's build somehow.

You can download the head of the 8.11 branch to try it out:
https://github.com/libvips/libvips/archive/refs/heads/8.11.zip
I think it should fix this issue (hopefully).
You need to edit your vips.rb to pass the flag. Change the line:
    system "./configure", *args

To be:
    system "./configure", "--disable-modules", *args

That ought to fix 8.11.0.


Please tag release 0.1.1

Hi the latest release (0.1.1) does not appear in the tags: https://github.com/jonschlinkert/path-root/tags
Please tag this release and the future ones so that automatic upstream release monitoring works.
Thanks ! Paolo

done


How to implement the responsive menu?

There is an example of collapsible menu here > http://semantic-ui.com/examples/responsive.html

Thanks @tuxy

I did a pretty good workaround using this Fiddle.
All you have to do to get a good mobile sidebar menu is write some custom CSS and JS on top of the existing framework. However, the sidebar does not have the ability to do dropdowns and is the only caveat.

@rtd62 do you still have access to the workaround code? if so, would you mind to share it via a gist.

Tip:
I implemented menu for desktop (hide by css for mobile) and sidebar for mobile (hide by css for desktop).
Useful links:
https://semantic-ui.com/modules/sidebar.html
https://semantic-ui.com/collections/menu.html
https://semantic-ui.com/examples/responsive.html

Another solution without a sidebar.
https://github.com/natzar/semantic-ui-hamburger/blob/master/README.md

I feel not having a single responsive menu example is enough of a stumbling block that a significant portion of first time users give up on Semantic UI. I have personally not solved this menu issue but I have made some beautify blazing fast UI's with simple vue.js and semantic ui

Updated fiddle here

I know this is a little on the hack side, and smacks in the face of DRY code, but is kind of clean and simple for using only the semantic components for the responsive menu with drop down:
repeat the html altered for both the full size menu and responsive dropdown menu and add a class for each one and the following JS:
` function checkScreenWidth(x) {
if(x.matches) {
$(".full-screen").css("display", "none");
$(".small-screen").css("display", "flex");
} else {
$(".small-screen").css("display", "none");
$(".full-screen").css("display", "flex");
}
}
var x = window.matchMedia("(max-width: 767px");
checkScreenWidth(x);
x.addListener(checkScreenWidth);`

Or just use Onsen UI. It has all these things correctly built in.

Thanks, will have a look at that.
Yeah, I'm in full agreement it's odd/frustrating semantic doesn't have this responsive functionality built it, but when you're already well into the project with it...


useDefineForClassFields defaults to true when target is es2022, breaks decorators.

Bug Report
useDefineForClassFields defaults to true when target is set to es2022 or esnext. This is breaking lots of projects that use decorators.
This was reported in https://github.com/microsoft/TypeScript/issues/45584, but that issue was closed apparently because the title didn't include which versions of TypeScript set useDefineForClassFields and because the TypeScript playground doesn't exhibit this same behavior. I've included a reproduction for tsc here.
This behavior is not documented anywhere in the TypeScript docs that I can find.
🔎 Search Terms
useDefineForClassFields decorators
🕗 Version & Regression Information
Since 4.2.4? according to https://github.com/microsoft/TypeScript/issues/45584
Present in 4.6.3 and 4.7.0-dev.20220422
⏯ Playground Link
This playground link does not demonstrate the problem, as it doesn't default useDefineForClassFields like tsc does. But if you set useDefineForClassFields to true you will see that that decorators could not work because the field is not an instance property that shadows the decorator defined prototype accessors.
Playground link with relevant code
This git repo reproduces the problem locally: https://github.com/justinfagnani/ts-decorators-bug
💻 Code
This does not work with target es2022:
const observe = (proto: Object, name: PropertyKey) => {
  const key = Symbol();
  Object.defineProperty(proto, name, {
    get() {
      return this[key];
    },
    set(v: unknown) {
      this[key] = v;
      this.onChange?.(name, v);
    }
  });
};

class A {
  @observe
  foo = 'abc';

  onChange(name: string, v: unknown) {
    console.log(`${name} changed to ${v}`);
  }
}

const a = new A();
a.foo = 'x'

🙁 Actual behavior
useDefineForClassFields defaults to true
🙂 Expected behavior
Option 1: useDefineForClassFields defaults to false like for other permutations of module and target until the new behavior is documented and users are notified with a prominent breaking change notice on the decorators documentation and the release notes.
Option 2: Use constructor initialization for decorated properties even if useDefineForClassFields is true. This will keep projects from breaking regardless of the config.
Option 3: Disallow both useDefineForClassFields: true and experimentalDecorators in the same config.
This behavior is breaking a large number of our users. Sometimes they are in control of their own tsconfig and can set useDefineForClassFields to false, but sometimes the config is generated for them via some other tool and they don't know how to set the value. In this case their project is just broken and they blame our library, not the update to TypeScript that included the undocumented breaking change.

This behavior is not documented anywhere in the TypeScript docs that I can find.

In the tsconfig reference:

And in the release notes:

Open to adding something to the Decorators docs. We discussed other options in a design meeting and the only one we were sort of ok with was issuing a config diagnostic for experimentalDecorators. (In fact, this is exactly what I said here.)

I guess I missed those and was looking in the decorator docs, don't know why I didn't see the 4.3 notes mention.
Why can't decorated fields opt-out of define semantics? We're seeing more and more users that are broken, and they get no errors at all. They're just assuming our library broke when it didn't change.

Unfortunately the design notes only capture “That sounds horrifying to me” in answer to that question. From my memory, I think the sentiment was generally that experimental decorators are experimental, so we’re not going to break standards compliance elsewhere to make them keep working, and that users should simply not try to use them in combination with useDefineForClassFields, making the config diagnostic the only sensible mitigation.

useDefineForClassFields doesn't break "decorators", per se, they break this specific use of a decorator. Native decorators, per the Stage 3 spec, also cannot replace a field with an accessor. Instead, the Stage 3 decorators proposal introduces a new accessor keyword that performs the syntactic transformation of a field into an accessor for you:
class C {
  accessor foo = 'abc';
}
// becomes
class C {
  #foo_backing_store = 'abc';
  get foo() { return this.#foo_backing_store; }
  set foo(v) { this.#foo_backing_store = v; }
}

It will be a bit before TS support for Stage 3 Decorators is ready, but I have been considering introducing the accessor keyword to TS independently.

The other approach would be to recommend your users use declare if they have no control over the useDefineForClassFields setting:
class C {
  @observe
  declare foo: string; // field not declared on class, but decorator will still run

  constructor() {
    this.foo = "abc";
  }
}

declare on a field in TS does not introduce a runtime field declaration under useDefineForClassFields, it merely adds it to the type in TS. A declare field cannot have an initializer, however, so it must be moved to the body of the constructor.

useDefineForClassFields breaks code that otherwise works with it set to false. Whether that's technically breaking decorators or not is pretty inside baseball that isn't so useful to our customers.
I know that we can tell users to use declare if they hit this problem, but we also tell them to set useDefineForClassFields to false. This doesn't help if they don't make their way to that documentation. More often their components silently don't work and they don't know why.

A property descriptor isn't provided to a field decorator because there's no descriptor to modify. This decorator breaks because it uses Object.defineProperty to introduce a new property that ends up shadowed by the field. Unfortunately, this was never something field decorators were designed to do. TS field decorators primarily existed as a means of recoding metadata about a field. Performing mutations on the prototype outside of that capability is unsafe.

This is really unfortunate, IMO. The switching of this setting to default true in some cases is actively breaking our users.


Register the package

[x] Improve documentation
[x] call registration bot

@JuliaRegistrator register

Registration pull request updated: JuliaRegistries/General/113488
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.4.0 -m "<description of version>" 643d00f6b5704fb9400b4f9f007c338ef42ad450
git push origin v0.4.0

Also, note the warning: This looks like a new registration that registers version 0.4.0.
Ideally, you should register an initial release with 0.0.1, 0.1.0 or 1.0.0 version numbers
This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.

Done!


--answers  doesn't work

i am trying any variation and the result error is any time same...

As saojs is using JSON.parse, so a strict json format with full prompts answers is needed, like
 create-nuxt-app  --answers '{"name": "test", ...}'


Style with icon stroke transparency goes south

Context
When styling with icons, their stroke alpha is not rendered at 1 by default, even the settings say so.
Steps to Reproduce

Style a point layer with any icon
Tweak the stroke size to a more obvious value

Current Result
Stroke is rendering semi transparent even tho alpha setting is default 1

Expected result
Stroke should render at alpha 1, like in normal bubbles
Browser and version
Chrome 55.0.2883.87
.carto file
icon_alpha (on 2017-02-07 at 18.27.36).zip

This is a dependency of how the incons are made I'm afraid.

Yes, already checked, and that's a limitation of the maki icons.

Yesterday we talk about getting rid of the Pin and Simple icons… are we still planning to do that?

I think yes

Hey, let's remember to open a ticket in website mentioning to remove the attribution to those iconsets when it happens.
https://carto.com/attribution (scroll down, there is no direct link).

We cannot, they are still there on editor.
On Thu, Feb 9, 2017, 12:18 PM Javier Álvarez Medina <
<EMAIL_ADDRESS>wrote:

Hey, let's remember to open a ticket in website mentioning to remove the
attribution to those iconsets when it happens.
https://carto.com/attribution (scroll down, there is no direct link).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/CartoDB/cartodb/issues/11479#issuecomment-278614286,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIENTq8nZ_iJnNvNMoomm4goNHw-Nvfks5ravYQgaJpZM4L57Xp
.

I tried to use http://fontawesome.io/icons, but they don't show a border either :(

ouch :(, ok. Changing name of the title guys.

Ready for CR.

About this, did we remove the "maki" name from the tab as we agreed?

Yes


[istio 1.8.1] istio-cni node cpu/mem resources

Describe the feature request
istio-cni-node daemon set; add support to set cpu/mem resources
Running istio-cni daemon set pods consumes 10G total memory in k8s cluster; 5G for install-cni and 5G for repair-cni
kubectl describe node xxxx

kube-system                istio-cni-node-hr669                      1 (1%)        1 (1%)      10Gi (6%)        10Gi (6%)      51d

As a result it consumes more resources on the node. Not sure if we have any base number requirement for install/repair cni.
Describe alternatives you've considered
I added resources in istio-cni charts/templates to tune it  via operator on need basis along with values.yaml
resources:
{{- if .Values.cni.resources }}
{{ toYaml .Values.cni.resources | trim | indent 12 }}
{{- else }}
{{ toYaml .Values.global.defaultResources | trim | indent 12 }}
{{- end }}

k8s node compute resources ;cpu/mem
Hence, need to know if there are any other approaches/suggestions for baseline settings for istio-cni pods resources . Not sure if above alternative support via template change is being worked on.
[ ] Docs
[X ] Installation
[ ] Networking
[X ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Additional context

Setting  too less resources for install-cni causes OOM
  resources:
    limits:
      cpu: 200m
      memory: 200Mi
    requests:
      cpu: 50m
      memory: 50Mi

  Warning  SystemOOM  <invalid>  kubelet, node-xxx  System OOM encountered, victim process: install-cni, pid: 105476
  Warning  SystemOOM  <invalid>  kubelet, node-xxx  System OOM encountered, victim process: install-cni, pid: 106169
  Warning  SystemOOM  <invalid>  kubelet, node-xxx  System OOM encountered, victim process: install-cni, pid: 106622
  Warning  SystemOOM  <invalid>  kubelet, node-xxx  System OOM encountered, victim process: install-cni, pid: 107759

Suggestions/doc on setting optimal value would be great for istio-cni-pod.

5gb memory usage is highly unexpected, the pod does pretty much nothing most of the time. cc @stewartbutler

@howardjohn :
I am using this changes for over-ride
https://github.com/noah8713/istio/commit/cbf8772d48234e8f90c07341109ba526317d264e . Let me know if this is duplicate or can be used as a PR for tuning cni resources.

Adding a higher limit is not the right fix. Maybe its something we should do, but CNI using 5gb is very wrong. Also it sounds likely to a memory leak, so even a high limit would not help?

I think its more of cpu/mem default resource which it allocates but uses few of it (not all of 5G is used). Only thing is node level still things as all allocated resource.  e.g above where super low cpu/mem will cause Crashback loop.
I tried with new defaults and don't see issues so far with OOM for both install/repair CNI because the .
resources:
    limits:
      cpu: 400m
      memory: 400Mi
    requests:
      cpu: 100m
      memory: 100Mi

 kube-system                istio-cni-node-vrsw7                                                 200m (0%)     800m (1%)   200Mi (0%)       800Mi (0%)     5h28m

We can leverage k8s overlay patches to set this too. Hence, closing the same as I am able to over-ride. More details in https://github.com/istio/istio/pull/30536


fix addon import path in docs

What's wrong with the default route? It points to the es-module<EMAIL_ADDRESS>

I couldn't import like it was documented and then took a look at https://github.com/drcmda/react-spring/blob/master/rollup.config.js#L39 and https://codesandbox.io/embed/q9lozyymr9 so I added .cjs to the end.
If it's just me then it's a false alarm.

Yeah, i had the same problem with csb, maybe their bundler is not equipped to handle esm? I opened an issue, let's wait and see. In the demos i load addons as well using the em module (https://github.com/drcmda/react-spring/blob/master/examples/demos/timing/index.js) and it works in a generic webpack setup.

Thanks. I can import from src folder too but the problem seems to be the packaged npm bundle in the dist folder. I'm using Next.js btw and here's my dist folder in node_modules. Not sure how it works with rollup but there are no bundles ending with just .js here:

In a previous version the es exports had ".es" in the name, but now they're just the default, only cjs and umd are marked. If next uses webpack 4 it should be able to deal with modules, i think only the older webpack variants couldn't do it.

@sourcesoft it was a bug in codesandbox, Ives said it's fixed now.


CCDB GE/034 - Section 2.5.3

Comment:
The HW Attacks, like Fault injection, Temperature and Voltage Stress (locally) should be also be considered for the RNG if relevant.
Proposal:
Priority: 1

This would be related to #69. Only to be considered if #69 includes adding physical RNG instead of physical noise source.
v1.1

Since #69 has been moved to v2 as physical RNG is out of scope right now, this will also be moved to v2.


fix(demo): update GitHub stars link

Summary

Update GitHub stars link.

Type of change

[ ] Bug fix (added a non-breaking change which fixes an issue)
[x] New feature (added a non-breaking change which adds functionality)
[ ] Updated documentation (updated the readme, templates, or other repo files)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?
I don't think this applies here.

[ ] Ran tests with composer test
[ ] Added or updated test cases to test new features

On second look, it appears that the github-buttons code requires the link to be in that format for the number of stars to show up, so I think this should be reverted for now.


remove unused "type ignores" with pyright

I've wanted to do this since #5399 when we switched from mypy to pyright.
This will conflict with #7024 but should be simple to fix.
Selected reviewer: @adriangb

looks good but some test failures, guessing some of those are needed. please fix then merge


Volar let Better Comments lost highlighted

Volar enabled before

After the commissioning of the volar

Enabled, you can see highlighted effective within the js file, but in the vue file fail

Duplicate of #1179


objectify plugin

I saw that you started ast and objectify plugins. cool!
I took the idea and started my own.
here is the gist for it I want to get you feedback.
gist

LGTM, only one nit that has probably crossed over from my impl: L110 should return/break.


Add the ability to enable / disable kerberos from Ambari API

All in the title

Available on the release 1.0.3-1


[PR 1] DEV-168 Added Info Message, added ranges to orders and improved button styles.

This PR mainly adds the info message, a new type of message. Because changes to the models where made, be sure to run npm i to update common-front. It also adds ranges to orders for validation and changes some styles.

I like the example info message :P


Canceling "Create Document" creates a new document anyway

If you click "Create Document" from the context menu, it will create a new document with a random id anyway.  Same behavior as just hitting enter when you have not entered input yet.

I disallowed the empty id after feedback on https://github.com/Microsoft/vscode-cosmosdb/pull/148.
Removing the check.

@whiskeyjay were you aware an empty id would auto-generate an id for the user when you gave that feedback? It might not be obvious to the user at first, but it seems like a useful feature to me (Plus it's easy to delete the document if that's not what you wanted)


WIP: a better URI

This looks like a good start.
Do you want to get it all done before merging, or taking it one component at a time?

I think we can do one component at a time.  Stand by.