Add optional max recursion depth to FollowRecursive

First stab at adding an optional parameter max recursion depth for FollowRecursive.
Also noticed MaxRecursiveSteps  wasn't being used anywhere and decided to add a max default recursive depth of 50.
Related Issue: https://github.com/cayleygraph/cayley/issues/624

This change is

Reviewed 9 of 9 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

graph/iterator/recursive.go, line 107 at r1 (raw file):

func (it *Recursive) Clone() graph.Iterator {
	n := NewRecursive(it.qs, it.subIt.Clone(), it.morphism, DefaultMaxRecursiveSteps)

it.maxDepth

graph/iterator/recursive.go, line 134 at r1 (raw file):

		}
	}
	if it.depth == it.maxDepth {

>=

graph/path/path.go, line 371 at r1 (raw file):

// first time the result node was seen.
//
// This is a very expensive operation in practice. Be sure to use it wisely.

Please document that maxDepth will be set to a default value if 0 is passed, and it will have no limit if -1 is passed.

query/gizmo/environ.go, line 400 at r1 (raw file):

	}
	if len(objs) > 1 {
		maxDepth = toInt(objs[1])

This will actually break anyone who uses tags with FollowRecursive now.
Let's check that objs[1] is an int first, and append it to tags otherwise.
You can change toInt to return an ok flag to check this.

Comments from Reviewable

Review status: 6 of 10 files reviewed at latest revision, 4 unresolved discussions.

query/gizmo/environ.go, line 400 at r1 (raw file):
Previously, dennwc (Denys Smirnov) wrote…
This will actually break anyone who uses tags with FollowRecursive now.
Let's check that objs[1] is an int first, and append it to tags otherwise.
You can change toInt to return an ok flag to check this.

Sounds good.
While I was trying to test if the tags were working still after my changes, it appears that the tags arguments did not work prior to my changes either (based on master or commit 94b343e9040e9f1d0fc31996bda37ce3fb0d5772.
Can you confirm? I'm using the following on the test set data/testdata.nq:
Query:
g.V("<alice>").FollowRecursive("<follows>", ["abc", "bca"]).All()

Actual Results:
{"result":[{"id":"\u003cbob\u003e"},{"id":"\u003cfred\u003e"},{"id":"\u003cgreg\u003e"}]}

Expected Results (I think):
{"result":[{"id":"\u003cbob\u003e, "abc":"\u003cfollows\u003e""},{"id":"\u003cfred\u003e", "bca":"\u003cfollows\u003e"},{"id":"\u003cgreg\u003e"}]}

Comments from Reviewable

Review status: 6 of 10 files reviewed at latest revision, 4 unresolved discussions.

graph/iterator/recursive.go, line 107 at r1 (raw file):
Previously, dennwc (Denys Smirnov) wrote…
it.maxDepth

Done.

graph/iterator/recursive.go, line 134 at r1 (raw file):
Previously, dennwc (Denys Smirnov) wrote…
>=

Done.

graph/path/path.go, line 371 at r1 (raw file):
Previously, dennwc (Denys Smirnov) wrote…
Please document that maxDepth will be set to a default value if 0 is passed, and it will have no limit if -1 is passed.

Done.

Comments from Reviewable

Reviewed 4 of 4 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

query/gizmo/environ.go, line 400 at r1 (raw file):
Previously, derekrliang (Derek Liang) wrote…
Sounds good.
While I was trying to test if the tags were working still after my changes, it appears that the tags arguments did not work prior to my changes either (based on master or commit 94b343e9040e9f1d0fc31996bda37ce3fb0d5772.
Can you confirm? I'm using the following on the test set data/testdata.nq:
Query:
g.V("<alice>").FollowRecursive("<follows>", ["abc", "bca"]).All()

Actual Results:
{"result":[{"id":"\u003cbob\u003e"},{"id":"\u003cfred\u003e"},{"id":"\u003cgreg\u003e"}]}

Expected Results (I think):
{"result":[{"id":"\u003cbob\u003e, "abc":"\u003cfollows\u003e""},{"id":"\u003cfred\u003e", "bca":"\u003cfollows\u003e"},{"id":"\u003cgreg\u003e"}]}

Thanks! Let me check this out.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

query/gizmo/environ.go, line 400 at r1 (raw file):
Previously, dennwc (Denys Smirnov) wrote…
Thanks! Let me check this out.

Depth tags was indeed broken. Should be fixed in 9699be355aa723c18d206f1474bbada896d93f70.
Please rebase to check if it works for you as well.

Comments from Reviewable

Review status: 9 of 10 files reviewed at latest revision, 1 unresolved discussion.

query/gizmo/environ.go, line 400 at r1 (raw file):
Previously, dennwc (Denys Smirnov) wrote…
Depth tags was indeed broken. Should be fixed in 9699be355aa723c18d206f1474bbada896d93f70.
Please rebase to check if it works for you as well.

Works for me now. Thanks! Rebased and works with the new optional recursive depth as well.

Comments from Reviewable

Thanks for working on this!

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Update CSVFormat.java

this is the fix

Integr tests passed. To remember not to upload a new csvformat.java file but to edit online as on test acc. debexpert

Deleting branch, work finished


The game crashes on GDScript error

Tested on Godot 2.0.4 and 2.1 beta, Windows 10 64 bits
Under a specific error situation, the game crashes when I debug it from the editor. I can still get the script error, however the game is no longer running and the "program stopped working" window appears.
I expected the error to occur and see the debugger pause the execution, not the game to crash.
I simplified my project to the point I can't tell what is causing the error: I just see that if I disable one of two lines in the script, Godot no longer crashes.
ScriptErrorCrash.zip
Open the project and run it, crash.
Now comment one of the indicated lines in terrain.gd, run again: no crash.
Both versions of Godot say this in the simplified project:
shit?: No error
ERROR: StreamPeerWinsock::read: Server disconnected!
   At: platform\windows\stream_peer_winsock.cpp:210

In the full project, this error occurs just before, maybe it's related:
ERROR: PacketPeerStream::put_packet: Condition ' p_buffer_size+4 > temp_buffer.size() ' is true. returned: ERR_INVALID_PARAMETER
   At: core\io\packet_peer.cpp:228

Visual Studio misses filenames on stack traces, but here it is:
>	PacketPeer::put_var(const Variant & p_packet={...}) Line 95
 	ScriptDebuggerRemote::debug(ScriptLanguage * p_script=0x00000182f2624be0, bool p_can_continue=false) Line 228
 	GDScriptLanguage::debug_break(const String & p_error={...}, bool p_allow_continue=false) Line 167
 	GDFunction::call(GDInstance * p_instance=0x00000182f2c28530, const Variant * * p_args=0x0000000000000000, int p_argcount=0, Variant::CallError & r_err={...}, GDFunction::CallState * p_state=0x0000000000000000) Line 1139
 	GDInstance::_ml_call_reversed(GDScript * sptr=0x00000182f27f7b20, const StringName & p_method={...}, const Variant * * p_args=0x0000000000000000, int p_argcount=0) Line 1213
 	GDInstance::call_multilevel_reversed(const StringName & p_method={...}, const Variant * * p_args=0x0000000000000000, int p_argcount=0) Line 1223
 	Node::_notification(int p_notification=13) Line 110
 	Node::_notificationv(int p_notification=13, bool p_reversed=false) Line 44
 	Object::notification(int p_notification=13, bool p_reversed=false) Line 910
 	Node::_propagate_ready() Line 151
 	Node::_propagate_ready() Line 147
 	Node::_propagate_ready() Line 147
 	Node::_set_tree(SceneTree * p_tree=0x00000182f27f7810) Line 2004
 	SceneTree::init() Line 482
 	OS_Windows::run() Line 2294
 	widechar_main(int argc=8, wchar_t * * argv=0x00000182edc86fd0) Line 146
 	main(int _argc=8, char * * _argv=0x00000182edc9c880) Line 172

I got a stack overflow on the line uint8_t  *buf = (uint8_t*)alloca(len); where len is 1050632.

Likely what causes it is the editor trying to allocate at once the 256x256 2D-array that you create with the script and fails to allocate the >1MB required, overflowing the stack.
For what I can gather, the use of alloca() is not a safe choice.

I don't reproduce the crash on Linux (Mageia 6 x64), but I also have the buffer size error printed in the terminal:
ERROR: put_packet: Condition ' p_buffer_size+4 > temp_buffer.size() ' is true. returned: ERR_INVALID_PARAMETER
   At: core/io/packet_peer.cpp:228.
ERROR: _notification: Condition ' cmd.get_type()!=Variant::STRING ' is true.
   At: tools/editor/script_editor_debugger.cpp:1045.

Otherwise the debugger properly stops on Invalid call. Nonexistent function 'up_div' in base 'Node (terrain.gd)'..

Marking as confirmed though as @vnen could reproduce.

This also crashes if I remove the invalid call but put a breakpoint in its place.

Interesting, my Mingw build just stops responding instead of crashing. It also closes the debug process.

Is this still valid (I'd assume so, but, who knows...)

@bojidar-bg still happens on stable and a recent build from master (MinGW)

I've got same error, version 2.1.3-stable_win64 on win7

oh, I see, i ported it go 3.0. The problem is that it's a ton of data for the current stack frame to send to the debugger. I'll try making the receive buffer from the debugger larger..


Recommend Playlists/Songs as per the weather

This is to work on the feature where as soon as the user selects a location, the recommended playlist/songs are displayed on the main page of the website itself, after the map.

@NoahCardoza kindly assign this issue to @drishtipeshwani and me. We would love to work on this.


Unable to extract download.

I'm currently running into an error and not sure how to debug it further. I am unable to extract the download. While running composer install I get this error:

An error occurred while extracting NodeJS (/Users/peteinge/Sites/panth-github-actions/vendor/node-v14.19.0-darwin-x64.tar.gz) to /Users/peteinge/Sites/panth-github-actions/vendor/node-v14.19.0-darwin-x64. Error: tar: Error opening archive: Failed to open ' /Users/peteinge/Sites/panth-github-actions/vendor/node-v14.19.0-darwin-x64.tar.gz -C '/Users/peteinge/Sites/panth-github-actions/vendor/node-v14.19.0-darwin-x64' --strip 1'

The download looks to be successful. Running the tar command directly in the command line after seems to always work.
At first, I thought it was just a permissions issue while running in composer, so just messing around I changed the file permissions after download to 0777. And still get the error.
I am trying to use the 2.x-dev version on a new Drupal site from Pantheon. Currently Drupal 9.4.2. And Composer 2.3.7 and running on a Mac, 10.15.7.  Any thoughts or if you need any more info, please let me know.
I've been playing around with Github Actions and deploying to pantheon with Integrated composer. We use Gulp to process our css and js. We've been using CircleCi for a few years now and trying to figure out new options with Pantheon's Integrated Composer.
Thanks in advance for any help.

Thanks Pete! Yes, this is an active bug I'm working on right now. It seems like there is a permission issue during the actual extraction, which does not add execute permissions on the actual files, so I'm working on figuring out how and why that happens. Will definitely keep you updated!

Great to hear! Thanks Kyle - looking forward to any updates and let me know if I can help out with anything.

Alright, I finally have it fixed! I'm running into a new issue unrelated to this, so I'm going to close this one, but keep opening new issues when you find them.
You'll want to keep using v2 of this package. The bug I'm running into now happens when I push to a Pantheon site repo, there's an "array to string conversion" error, but doesn't give me a stack trace, so I'm trying to replicate it locally.

Sorry to comment on a closed issue, but thought I'd share my findings on a similar issue. I'm using Docker Desktop with Lando on my Mac and the permissions issue was a result of using VirtioFS. Once I switched to another such a gRPC, the extraction eventually worked. https://github.com/docker/for-mac/issues/6614


Document haxe.Exception

Also moved "throw" section right before "try/catch"

I didn't care about the exception refactor all that much / didn't follow it too much, but this really shows how much nicer everything is now. 👍


Update README.md

fix faq url

Motivation

Solution

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

You should sign the CLA before merged.

Done

Thank you very much for your contribution!


Feature removal: No longer accept port as a flag

I couldn't see this documented anywhere or being used anywhere

@triblondon I removed it from the dependencies section, if you add it to devDependencies in your less-grunt branch as it is only used for development tasks then I think there won't be a conflict.


Add CORS example

An example application for this issue.

Good idea, thanks. Sorry it takes so long, I'm forcing my way through 2.0.0-pre.4 and will look at existing tickets/PRs once my set of changes is in, since I'm still breaking things.


Mask Money not masking when input value is set programatically.

Here is a simple JS fiddle to demonstrate:
http://jsfiddle.net/us6589rk/3/
Notice that the input lists as 5. But if you gain focus, then blur, it fixes it.
This might be related to issue #122
I will take some time tonight to see if I can fix for you.

Its work fine in my code:
var newValue = 123;
$('input#apartment-pricetotal').val(newValue );
$('input#apartment-pricetotal-disp').val(newValue ).trigger('mask.maskMoney');

is any other more beautiful methods?

Best Solution:
$('.maskMoney').maskMoney({allowNegative: false, thousands:'.', decimal:','});

$('.maskMoney').each(function(){ // function to apply mask on load!
    $(this).maskMoney('mask', $(this).val());
})

We can do this by below solution
https://jsfiddle.net/atmiya/uy85fnt8/1/

Hi, put inside single brackets, worked for me!
Ex:   $("#field").maskMoney('mask', '98,94');

$("#moneyValue").maskMoney({
thousands: '.', decimal: ',',
allowZero: true, affixesStay: true, prefix: " R$ 0,00 "

We can do this by below solution https://jsfiddle.net/atmiya/uy85fnt8/1/

This is what i needed. Just an advice, i added $('#element').blur() right after $('#element').focus() to get the best solution.

We can do this by below solution https://jsfiddle.net/atmiya/uy85fnt8/1/

This is what i needed. Just an advice, i added $('#element').blur() right after $('#element').focus() to get the best solution.

Hello everyone, I find a proper solution for this case;
my code;
$("#product_price").maskMoney({thousands:'.', decimal:',', affixesStay: true});
$('#product_price').maskMoney('mask');

https://plentz.github.io/jquery-maskmoney/

	$(".brl").maskMoney({
		allowNegative: false,
		thousands: ".",
		decimal: ",",
		affixesStay: false,
		reverse: true,
	}).maskMoney('mask');


Add notes (#327)

Suggestions in comments pls kthx

grunt --dev is the way. grunt minifies it for distribution (8.0.0 release)

wait abal teach me hot to git lol


Can not share money beetwen two devices

The issue
From physical device scan QR code of app on emulator and make a transfer. However even after half an hour app on emulator hasn't receive the money
Environment
Nexus 7, Android 4.4.
Genymotion emulator, Android 5.0
Steps to reproduce

Run application on both devices
Register users with two different names
Take a physical device and sent money to app on emulator
Get a confirmation dialog that;s transfer pass well
Wait some period of time to let devices sync up (up to 30 minutes)

Observed behavior
Amount of money on both devices remain the same
Expected behavior
In a few minutes amount of money on physical device reduce on value equal to value in transaction and amount of money on emulator increase on the value equal to value in transaction

What server is your app connecting to?

I use the sample and connect under the hood it use this server https://point-demo.iroha.tech (which is unavailable for now)

The context. My team and me plan to use this sample as a part of the demo for our solution for hackathon. We have the issue if that server doesn't work.
Could you please provide your tech guidance how to make it work on our side or deploy our own server into the cloud?

Sorry, this issue is client problem. not server. Caused by missing transfer command.
○ transfer
× Transfer
I will fix it as soon as possible then merge to master from develop.
To tell the truth, this issue is fixed on iroha-demo-android.
Very thanks!

This issue was solved by #77's PR!

Confirm. It works now


Make notSetValue optional for typed Records

Tiny change to the type definitions.
First of all type-safe immutable records are glorious, thank you! I am a huge fan of what you are doing here. Secondly, your type declarations throw compiler errors for using the API as per the documentation. In your documentation for Record. You use get like so:
const { Record } =<EMAIL_ADDRESS>const ABRecord = Record({ a: 1, b: 2 })
const myRecord = new ABRecord({ b: 3 })

myRecord.get('a') // 1

Doing this with the current type definition produces the following error: Expected 2 arguments, but got 1
My new type definition will give you the following behavior:
const { Record } =<EMAIL_ADDRESS>const ABRecord = Record({ a: 1, b: 2 })
const myRecord = new ABRecord({ b: 3 })

myRecord.get('a') // Type: number
myRecord.get('a', 'a') // Type: number
myRecord.get('v', 'a') // Type: string
myRecord.get('v') // Error:
// Argument of type '"v"' is not assignable to parameter of type '"a" | "b"'

This seems to capture the API pretty well.
Dicussion
With type safe records you could forbid the notSetValue entirely. Since we can force key to be a key of TProps we should never need a notSetValue. Using one in these cases will probably be unintentional. But this means there are ways to validly use the API in JS that you can't in TypeScript, which is understandable not to want.

There are two other PRs (#1469, #1445) that address the same issue (#1463). This is the one that Does The Right Thing.
I suspect that the bug originated in a one-to-one translation between Flow and TypeScript - the former treats mixed and any parameters as optional, while the latter does not. However, in addition to fixing that mistranslation, this also fixes an issue that is shared between the Flow and TS annotations - they didn't properly describe the behavior when a key is passed that's not in the Record. This is legal, and results in a different return type. @morsecodist, could you add a commit to the PR applying the same fix to immutable.js.flow? (And then remove the part of the comment right above the TS version that describes the bug :stuck_out_tongue:.)


Multiple objects in post body

Client doesn't support multiple objects in body.

It seems we have the same problem. Posting simple but nested object seems not to work.

Actually  Swagger 2.0 specification says that there can only be one body parameter.

Body - The payload that's appended to the HTTP request. Since there can only be one payload, there can only be one body parameter. The name of the body parameter has no effect on the parameter itself and is used for documentation purposes only.

The bug is that the code generator doesn't check this and generates wrong code: server code compiles but is wrong, client code doesn't compile at all.

fixed in version 0.0.11


feat: update icon buttons on List component

Related to https://github.com/Decathlon/vitamin-design/issues/188

I probably missed something here but what decision has been taken regarding this inconsistency on the design side?
@lauthieb

@thibault-mahe, that's why I need to talk with you about this today :)

I close this ticket because https://github.com/Decathlon/vitamin-design/issues/188#issuecomment-1431064181


STM32L4S5VI Failed to initialize RTT

Describe the bug
Failure to initialize RTT when using STM32L4S5VI board
To Reproduce
Steps to reproduce the behavior:

Attach the board
Run cargo embed on a project (note: it might work the first time, but every other attempt fail)

Expected behavior
Flash the binary and initialize RTT
Stacktrace
The thing I'm observing is failures like
       INFO cargo_embed                                          > Initializing RTT (attempt 1)...
       DEBUG probe_rs_rtt::rtt                                    > Scanning at exact address: 0x20000000
       DEBUG probe_rs::probe::stlink                              > Read mem 32 bit, address=20000000, length=24
       TRACE probe_rs::probe::stlink::usb_interface               > Sending command [f2, 7, 0, 0, 0, 20, 18, 0, 0] to STLink, timeout: 1s
       TRACE probe_rs::probe::stlink::usb_interface               > Read 24 bytes, 0 bytes remaining
       TRACE probe_rs::probe::stlink::usb_interface               > Sending command [f2, 3e] to STLink, timeout: 1s
       TRACE probe_rs::probe::stlink::usb_interface               > Read 12 bytes, 0 bytes remaining
       TRACE probe_rs_rtt::rtt                                    > Expected control block to start with RTT ID: "SEGGER RTT\0\0\0\0\0\0"
. Got instead: "\0�\n�\rx-\u{6}h@\u{8}$@\0\0�"
       DEBUG cargo_embed                                          > Failed to initialize RTT. Retrying until timeout.

Eventually failing with
       Error Error attaching to RTT: RTT control block not found in target memory.
             - Make sure RTT is initialized on the target, AND that there are NO target breakpoints before RTT initalization.
             - For VSCode and probe-rs-debugger users, using `halt_after_reset:true` in your `launch.json` file will prevent RTT
              initialization from happening on time.
             - Depending on the target, sleep modes can interfere with RTT.
        INFO cargo_embed                  > Metadata {
    chip: Some(
        "Unspecified(\"STM32L4S5VI\")",
    ),
    probe: Some(
        "StLink",
    ),
    speed: Some(
        "1800",
    ),
    release: "0.12.0",
    commit: "crates.io",

The only way to get the board working is to use st-flash write to write any binary (probe-rs-cli erase --chip STM32L4S5VI doesn't do the trick) and after that (with re-plugging the board after each step), I get it working and the logs shows
        INFO cargo_embed                                          > Initializing RTT (attempt 4)...
       DEBUG probe_rs_rtt::rtt                                    > Scanning at exact address: 0x20000000
       DEBUG probe_rs::probe::stlink                              > Read mem 32 bit, address=20000000, length=24
       TRACE probe_rs::probe::stlink::usb_interface               > Sending command [f2, 7, 0, 0, 0, 20, 18, 0, 0] to STLink, timeout: 1s
       TRACE probe_rs::probe::stlink::usb_interface               > Read 24 bytes, 0 bytes remaining
       TRACE probe_rs::probe::stlink::usb_interface               > Sending command [f2, 3e] to STLink, timeout: 1s
       TRACE probe_rs::probe::stlink::usb_interface               > Read 12 bytes, 0 bytes remaining
       DEBUG probe_rs::probe::stlink                              > Read mem 32 bit, address=20000018, length=24
       TRACE probe_rs::probe::stlink::usb_interface               > Sending command [f2, 7, 18, 0, 0, 20, 18, 0, 0] to STLink, timeout: 1s
       TRACE probe_rs::probe::stlink::usb_interface               > Read 24 bytes, 0 bytes remaining
       TRACE probe_rs::probe::stlink::usb_interface               > Sending command [f2, 3e] to STLink, timeout: 1s
       TRACE probe_rs::probe::stlink::usb_interface               > Read 12 bytes, 0 bytes remaining
       DEBUG probe_rs::probe::stlink                              > Read mem 32 bit, address=080307c0, length=128
       TRACE probe_rs::probe::stlink::usb_interface               > Sending command [f2, 7, c0, 7, 3, 8, 80, 0, 0] to STLink, timeout: 1s
       TRACE probe_rs::probe::stlink::usb_interface               > Read 128 bytes, 0 bytes remaining
       TRACE probe_rs::probe::stlink::usb_interface               > Sending command [f2, 3e] to STLink, timeout: 1s
       TRACE probe_rs::probe::stlink::usb_interface               > Read 12 bytes, 0 bytes remaining
       DEBUG probe_rs_rtt::channel                                > probe-rs-rtt::Channel::read_c_string() result = Some("defmt")
        INFO cargo_embed                                          > RTT initialized.

Desktop (please complete the following information):

macOS Catalina

me too


Push all images tagged

This pull request adds logic to push all tags specified in <imageTags>.

Thanks @JoelJ for the contribution. #127 adds a similar feature but to docker:build whereas this only adds it to docker:push, if I understand your change correctly. I think it makes sense to have this available in both (and in a consistent way).
Also can you resolve the merge conflict?

+1

rebased here https://github.com/spotify/docker-maven-plugin/pull/131


Ubuntu Java warnings

Describe the bug
A warning appears during compilation.
If we are constantly updating our libraries to the latest it will most likely become an an issue.
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.junit.contrib.java.lang.system.EnvironmentVariables (file:/home/runner/.gradle/caches/modules-2/files-2.1/com.github.stefanbirkner/system-rules/1.19.0/d541c9a1cff0dda32e2436c74562e2e4aa6c88cd/system-rules-1.19.0.jar) to field java.util.Collections$UnmodifiableMap.m
WARNING: Please consider reporting this to the maintainers of org.junit.contrib.java.lang.system.EnvironmentVariables
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

See the following build https://github.com/Flank/flank/pull/1448/checks?check_run_id=1736270298

I think this is related with JDK version you are using. Ubuntu 20.04 has java 11 as the default one. WIth jdk 11 there were some changes introduced with reflection http://openjdk.java.net/jeps/181
I guess if you change jdk to 8 there will be no warnings.
BTW, mockk is also using reflection, a lot... I use JDK 15 on daily basis and get:
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by io.mockk.proxy.jvm.advice.MethodCall (file:/Users/gogo/.gradle/caches/modules-2/files-2.1/io.mockk/mockk-agent-jvm/1.10.5/a01228a3cc5146c4464b2940264c35e367c42d6b/mockk-agent-jvm-1.10.5.jar) to method java.time.LocalDate.create(int,int,int)
WARNING: Please consider reporting this to the maintainers of io.mockk.proxy.jvm.advice.MethodCall
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

They (mockk maintainers) tried recently to abandon jdk 8 and compile source code with jdk 9 (I think). But, well... :)

I think this is related with JDK version you are using. Ubuntu 20.04 has java 11 as the default one. WIth jdk 11 there were some changes introduced with reflection http://openjdk.java.net/jeps/181
I guess if you change jdk to 8 there will be no warnings.
BTW, mockk is also using reflection, a lot... I use JDK 15 on daily basis and get:
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by io.mockk.proxy.jvm.advice.MethodCall (file:/Users/gogo/.gradle/caches/modules-2/files-2.1/io.mockk/mockk-agent-jvm/1.10.5/a01228a3cc5146c4464b2940264c35e367c42d6b/mockk-agent-jvm-1.10.5.jar) to method java.time.LocalDate.create(int,int,int)
WARNING: Please consider reporting this to the maintainers of io.mockk.proxy.jvm.advice.MethodCall
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

They (mockk maintainers) tried recently to abandon jdk 8 and compile source code with jdk 9 (I think). But, well... :)

@pawelpasterz @Sloox So for this issue we should investigate which JDKs we can use without those warnings? Correct me if I am wrong. I am trying to assume what should be done in the scope of this issue.

@jan-gogo any JDK 11+ will give warnings, we can switch java version to 8 in gh action to get rid of those warnings


Handle undefined tag

I have observed this error:
Cannot read property '0' of undefined
TypeError: Cannot read property '0' of undefined
    at EventEmitter.JSXAttribute (/Users/patrick/sigopt-api/node_modules/eslint-plugin-react/lib/rules/forbid-component-props.js:51:16)
    at emitOne (events.js:101:20)
    at EventEmitter.emit (events.js:188:7)
    at NodeEventGenerator.enterNode (/Users/patrick/sigopt-api/node_modules/eslint/lib/util/node-event-generator.js:40:22)
    at CodePathAnalyzer.enterNode (/Users/patrick/sigopt-api/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:608:23)
    at CommentEventGenerator.enterNode (/Users/patrick/sigopt-api/node_modules/eslint/lib/util/comment-event-generator.js:97:23)
    at Controller.enter (/Users/patrick/sigopt-api/node_modules/eslint/lib/eslint.js:918:36)
    at Controller.__execute (/Users/patrick/sigopt-api/node_modules/eslint/node_modules/estraverse/estraverse.js:397:31)
    at Controller.traverse (/Users/patrick/sigopt-api/node_modules/eslint/node_modules/estraverse/estraverse.js:501:28)
    at Controller.Traverser.contMakefile:37: recipe for target 'eslint' failed

Here is a minimal example that causes the error for me:
const Parent = React.createClass({
  render: function() {
    return <Child a={this.props.a}/>;
  }
});

However, I tried adding this as a test and the test appears to pass with the existing code. I'm not sure what would cause this or how to induce this error in test-mode, but I can repeatedly generate this error in my environment.

Is your environment in strict or sloppy mode?

How do I check that? I assume it is whatever the default is because I haven't configured anything like that to my knowledge

@pfhayes if you have 'use strict', or if you've configured eslint to use sourceType modules, then it's in strict mode. Otherwise it'd be in sloppy mode.
If you add 'use strict'; to the top of the test code, does it fail?

I don't believe I have configured eslint to use sourceType modules because I do not know how to do that. I am also not using 'use strict'

@pfhayes are you using babel? any code inside class, or any file using import or export is automatically in strict mode.

Yes, the code is being compiled with babel. The example provided has no imports/exports or class declarations (the example provided was the entire contents of the file that introduced the error)
I tried to reproduce this error recently and was unable to. I'm not sure what the cause was - perhaps an error in a dependent module that was fixed by an npm install. i'm fine closing this

Here's one way to replicate it:
foo(bar) {
    return <bar.baz className="error goes here" />;
}

Thanks for the contribution. Feel free to re-open with a test!

Got the exactly the same issue here , seems @pfhayes 's PR been closed, but still have the issue. So how do I solve this @lencioni  ?

@xeodou if you can provide a test case in a PR, or better, a test case with a fix, then we'd love to merge it!

Sure @ljharb  i'll do.

Hi @ljharb  I just found the use case and create pull request, please feel free to make some comments.


Allow mapping Escape () key in vim normal mode

Trying to map <Esc> key with map() or mapCommand() doesn't do anything. Mapping it in insert or visual mode doesn't really make much sense but it should be possible to map it in normal mode.
Changing handleEsc() to below code might be enough to fix this.
function handleEsc() {
  if (key == '<Esc>') {
    // Clear input state and get back to normal mode.
    if (vim.visualMode) {
      clearInputState(cm);
      exitVisualMode(cm);
      return true;
    } else if (vim.insertMode) {
      clearInputState(cm);
      exitInsertMode(cm);
      return true;
    }
  }
}

Then submit a PR :)

Then submit a PR :)

Thanks! I did that.


Register: Make paper key errors work

@keybase/react-hackers
We already had the data in props, but it never got plumbed through to the input component.

👍


Reject transactions with excessive numbers of sigops

See:  bitcoin/bitcoin@4fad8e6

wtf ? 4 sig op max per Transaction ? It basically means you can't have more than 4 input in a transaction ???

ha no sorry


Breaking Change: Removal of truck speed limits and vehicle attributes from the Snap to Roads API in the Bing Maps Routes Service on 9/30/2024

My apologies for posting this as a bug. I wasn't sure where to ask my question.
Our company contact received an email from Microsoft with the following title:
"Breaking Change: Removal of truck speed limits and vehicle attributes from the Snap to Roads API in the Bing Maps Routes Service on 9/30/2024"
The only link in the email just takes you to the API learning materials, which has limited info concerning the change.
I would like to know if this upcoming change in 9/30/2024 would affect this toolkit beyond the use of the parameters in the request.

I hadn't seen that email, but by the sounds of it, this is specific to truck-based queries on snap to road API. If you are not using trucks as the travel mode with that API, this library will work fine. If you are using trucks as the travel mode, and specify vehicle attributes then it's possible the end service may throw an error (there hasn't been any disclosure on what will happen. Ideally it will simply ignore those parameters). If the API does not ignore those parameters and throws an error, then that would of course flow back to this library as the response. In regards to speed limits, I would expect that if you request that data, it simply would not be returned. Assuming that's the case, this library would continue to work fine, the only potential issue would be if your app has any code dependencies on there being speed limit data in the response.
All that said, I would fully expect that the Snap to Road API will simply ignore vehicle attributes and not return speed limits starting 9/30/2024, and this library will continue to work without issue, just without speed limit data in the response.

Thank you for your response. This is basically the response I was hoping for :)
I did some due diligence, and poked around on different sites looking for more details. I also emailed the contact in the notification email we received. The response pointed me back to the email notification and the bing maps portal. Nothing specific beyond the title of the email/announcement was provided.  Well ... the link to the Microsoft learning docs for the API was provided, but it hasn't been updated in a couple years, and I didn't see any links referencing the change.
Thanks again.

Closing issue


[Extension] Unable to log in to Hypothesis from USA Today pages in Extension

Related
Depends on hypothesis/viahtml#333 , but focused on solving the problem for the extension.

Bug report form
Steps to reproduce

Make sure you are logged out Hypothesis
Open any page at USA Today e.g. https://www.usatoday.com/story/news/politics/2022/03/07/ukraine-russia-invasion-live-updates/9404740002/
Activate Hypothesis extension or bookmarklet, and click the sidebar link to Log In

Expected behaviour
The Hypothesis login pop-up window should appear with appropriate username and password fields available.
Actual behaviour
An entirely blank pop-up window displays.
Browser/system information
Tested on:

Chrome 99
Firefox 97
Brave 1.36.109

Note: The issue does not seem to affect Safari 15.3
Additional details
If you are already logged in to Hypothesis all functionality works as expected.

Prior Art
From hypothesis/viahtml#333

The cross-origin-opener-policy header in particular is a new thing that may be relevant. From this related Chrome issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1221127:

Sites that wish to continue using SharedArrayBuffer must opt-into cross-origin isolation. Among other things, cross-origin isolation will prevent cross-origin popups from having access to their opener. This behavior ships today in Firefox, and Chrome aims to ship it as well in Chrome 92.
As part of crossOriginIsolation, websites must send a Cross-Origin-Opener-Policy: same-origin header. COOP same-origin prevents pages with different top-level origins from being able to communicate with each other. This breaks many OAuth or payment flows that rely on opening a cross-origin popup that will communicate back with the page through window.postMessage for example.

I'm not clear how this interacts with iframes yet.
This feature request in this issue is written with the assumption that the target audience is a web developer who can change the headers that web pages are served with. We can change these headers in Via, but not in the bookmarklet or browser extension.

I was able to reproduce in Chrome using Sauce Labs to load the page from a US-based server, using the browser extension. The window.open call that the OAuthClient class in the client makes is returning null.
This might be something to do with the headers the top-level frame is returning:
content-type: text/html; charset=utf-8
etag: W/"36e87-xQxIdQhDQBw7nNrIxHR+WGsIvwA"
x-content-type-options: nosniff
x-frame-options: deny
x-xss-protection: 1; mode=block
feature-policy: camera 'none';display-capture 'none';geolocation 'none';microphone 'none';payment 'none';usb 'none';xr-spatial-tracking 'none'
permissions-policy: camera=(),display-capture=(),geolocation=(),microphone=(),payment=(),usb=(),xr-spatial-tracking=()
referrer-policy: strict-origin-when-cross-origin
content-security-policy-report-only: script-src https: blob: 'unsafe-inline' 'unsafe-eval' 'self';base-uri 'self';report-uri https://reporting-api.gannettinnovation.com;report-to default
content-security-policy: upgrade-insecure-requests;frame-ancestors 'none';object-src 'none'
cross-origin-opener-policy: same-origin
cross-origin-resource-policy: same-origin
origin-agent-cluster: ?1
accept-ranges: bytes
date: Wed, 16 Mar 2022 14:39:52 GMT
age: 5
set-cookie: gup_anonid=c4d0b197-c729-4a26-8d66-d91134674253; Domain=.usatoday.com; Max-Age=31536000; Path=/; SameSite=Lax; Secure
set-cookie: gup_clientid=3216a3a7-781d-4a99-b099-5d5d66f39e1c; Domain=.usatoday.com; Max-Age=31536000; Path=/; SameSite=Lax; Secure
cache-control: no-store
set-cookie: gnt_ub=1; domain=.usatoday.com; path=/; secure; samesite=lax; max-age=31536000;
set-cookie: gnt_sb=1; domain=.usatoday.com; path=/; secure; samesite=lax; max-age=31536000;
set-cookie: gnt_eid=control:1; domain=.usatoday.com; path=/; secure; samesite=lax; max-age=5184000;
gannett-cam-experience-id: control:1
nel: {"report_to":"default","max_age":31557600,"include_subdomains":true,"success_fraction":0.005}
report-to: {"max_age":31557600,"include_subdomains":true,"endpoints":[{"url":"https://reporting-api.gannettinnovation.com"}]}
link: <https://www.usatoday.com/tangstatic/svg/weather/7-q1a2z3371d08dc.svg>;rel=preload;as=image;nopush
set-cookie: gnt_d=%7B%22w%22%3A%7B%22t%22%3A%2248%22%2C%22f%22%3A%227-q1a2z3371d08dc%22%2C%22c%22%3A%22Cloudy%22%7D%2C%22z%22%3A%2295123%22%2C%22c%22%3A%22san%20jose%22%2C%22s%22%3A%22CA%22%7D; domain=.usatoday.com; path=/; samesite=lax; secure; priority=high;
x-cache: MISS, HIT
x-timer: S1647441593.799128,VS0,VE1
vary: X-AbVariant,X-AbVCfg,X-AltUrl,Accept-Encoding,User-Agent
strict-transport-security: max-age=63072000
content-length: 199138

I'm going to close this here as the only work remaining for now is some documentation by either @mattdricker or myself. I will open the requisite work in the support backlog.


AdAway requires signed key?

I assume this is a bug, because it is the only package with user-keys/shared instead of PRESIGNED and nothing about that is mentioned in https://github.com/sfX-android/android_vendor_extendrom/wiki/EXTENDROM_PACKAGES

thx for reporting. Fixed in https://github.com/sfX-android/android_vendor_extendrom/commit/7ddcabbc14cc3990245c858addeabc2f1f374075#diff-b913bcd7262c28853a2a2596c2d7b22c72f11f4c547ce86b25019a35ae238f78 :)


Navbar dropdown & touchscreen issues

The language selection dropdown menu in the docs doesn't work on touchscreen only devices like the iPhone.

For solutions compare #125


⚠ Mobitopup has degraded performance

In 6e77eae, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 3220 ms

Resolved: Mobitopup performance has improved in 9043865.


Update Token Approval Manger to 1.3.0

Revision checks

[x] Used smart contracts were audited.
[x] Your Safe App include a manifest.json file at the root with the required data.
[x] The app can be loaded as a custom Safe App in the Apps section of https://app.safe.global.
[x] The app auto-connects to the Safe.
[x] You are able to trigger and execute one transaction with a Safe.
[x] RPC requests are optimized (not triggering many requests in a very short time period).

Name/Description
Token Approval Manager
Type

Update

Compatible Networks
- Mainnet
- Goerli
- Gnosis Chain
- Polygon
- Optimism
- Arbitrum

Audit document
No smart contracts involved
Code for review
https://github.com/schmanu/token-approval-tracker/releases/tag/1.3.0
IPFS hash/App URL
QmVvdFrdcv4ivCbimG2NCfoeQFtw7ynEDJHX9VAWQnoRJC
Team information
Manu (me)

Thanks! I checked it and it works again :)


:arrow_up: chore: Update node to 20 lts

Description
Update node to node 20
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

Current dependencies on/for this PR:

main

PR #624

PR #625   👈

This stack of pull requests is managed by Graphite.


ERROR    websocket         error from callback <bound method Client.on_close of <gardena.smart_system.Client object at 0x600239b0>>: (invalid_grant) Failed to find token

Hi again,
seams i got the similar error again (from 7.June):
ERROR    websocket         error from callback <bound method Client.on_close of <gardena.smart_system.Client object at 0x600239b0>>: (invalid_grant) Failed to find token
i got this error at 6:38 before i open the websocket again.
I open the socket every day at 7:00 and close it at 22:00 because
I usually want to keep the connection alive every time but somedays the status seams to be frozen.
I have to reconnect and everything works fine until some days.
To disconnect the websocket is there a special command to exit the websocket.
At the moment i disconnect via "break" i the while loop
Here my complete pyhton code..
#!/usr/bin/env python3
# gardena_garten_system.py

# SmartSystem need :
# https://github.com/py-smart-gardena/py-smart-gardena
# https://developer.husqvarnagroup.cloud/docs/getting-started#/docs/getting-started/#3connect-api-to-application

from gardena.smart_system import SmartSystem
from datetime import datetime
from requests import HTTPError
import pprint
import pytest
import unittest
import requests
import requests_mock
import time
import sys

LOCATION_ID = "xxx"  #nicht ändern!

sh.Gardena.OnOff(1) #Setze beim Auslösen den Schalter auf Eins

smart_system = SmartSystem(email="xxx", password="xxx", client_id="xxx") # ID aus API nehmen und anpassen. Letzte Änderung der ID am 18.7.2020
smart_system.authenticate()
smart_system.update_locations()

for location in smart_system.locations.values():
    smart_system.update_devices(location)
    pprint.pprint(location)
    for device in location.devices.values():
        pprint.pprint(device)

smart_system.start_ws(smart_system.locations[LOCATION_ID])

sh.Gardena.mower.status('Warte auf Start...')
sh.Gardena.mower.battery_state("Warte auf Start...")

while sh.Gardena.OnOff:
    tageszeit = sh.now()
    if (tageszeit.hour >= 20) and (tageszeit.hour < 23):
        sh.Gardena.OnOff(0)
        break
    if (tageszeit.hour >= 12) and (tageszeit.hour < 13):
        sh.Gardena.OnOff(0)
        break
    if (tageszeit.hour >= 7) and (tageszeit.hour < 20):
        for device in smart_system.locations[LOCATION_ID].find_device_by_type("MOWER"):
            sh.Gardena.mower.battery(device.battery_level)
            sh.Gardena.mower.radio_quality(device.rf_link_level)

            if (device.battery_level < 5):
                sh.telegram.photo_broadcast('https://icon-icons.com/icons2/2248/PNG/96/robot_mower_icon_136263.png', 'Batterie kritisch: %d '% device.battery_level, 832868784)
                #Schalte Tunnel öffnen
                requests.get('http://<IP_ADDRESS>/control?cmd=gpio,14,0')

            if device.activity == 'PARKED_PARK_SELECTED':
                sh.Gardena.mower.status('Geparkt')
            elif device.activity == 'OK_CUTTING_TIMER_OVERRIDDEN':
                sh.Gardena.mower.status('Manuelles Mähen')
                #Schalte Tunnel schliessen
                requests.get('http://<IP_ADDRESS>/control?cmd=gpio,14,1')
            elif device.activity == 'OK_SEARCHING':
                sh.Gardena.mower.status('Suche Ladestation')
                #Schalte Tunnel öffnen
                requests.get('http://<IP_ADDRESS>/control?cmd=gpio,14,0')
            elif device.activity == 'OK_CUTTING':
                sh.Gardena.mower.status('Am Mähen')
                #Schalte Tunnel schliessen
                requests.get('http://<IP_ADDRESS>/control?cmd=gpio,14,1')
            elif device.activity == 'OK_LEAVING':
                sh.Gardena.mower.status('Fahre zur Startposition')
                sh.Gardena.mower.in_charge(0)
                #Schalte Tunnel öffnen
                requests.get('http://<IP_ADDRESS>/control?cmd=gpio,14,0')
            elif device.activity == 'OK_CHARGING':
                sh.Gardena.mower.status('Am Laden')
                sh.Gardena.mower.in_charge(1)
                #Schalte Tunnel öffnen
                requests.get('http://<IP_ADDRESS>/control?cmd=gpio,14,0')
            elif device.activity == 'PARKED_TIMER':
                sh.Gardena.mower.status('Geparkt bis Timer')
                #Schalte Tunnel öffnen
                requests.get('http://<IP_ADDRESS>/control?cmd=gpio,14,0')
            elif device.activity == 'PARKED_AUTOTIMER':
                sh.Gardena.mower.status('Geparkt bis Timer - Grashöhe unzureichend')
                #Schalte Tunnel öffnen
                requests.get('http://<IP_ADDRESS>/control?cmd=gpio,14,0')
            elif device.activity == 'PAUSED':
               sh.Gardena.mower.status('Angehalten')
            elif device.activity == 'NONE':
                if device.last_error_code == 'OFF_HATCH_OPEN':
                    sh.Gardena.mower.status('Klappe geöffnet')
            else:
                sh.Gardena.mower.status(device.activity)

            if (sh.Gardena.mower.last_status() != sh.Gardena.mower.status()):
                logger.warning('Mäher: Neuer Status : %s' % sh.Gardena.mower.status())
                sh.telegram.photo_broadcast('https://icon-icons.com/icons2/2248/PNG/96/robot_mower_icon_136263.png', 'Neuer Status : %s' % sh.Gardena.mower.status(), 832868784)
                sh.Gardena.mower.last_status(sh.Gardena.mower.status())

            if device.battery_state == 'OK':
                sh.Gardena.mower.battery_state("Alles OK")
            elif device.battery_state == 'LOW':
                sh.Gardena.mower.battery_state("Niedrig")
            elif device.battery_state == 'REPLACE_NOW':
                sh.Gardena.mower.battery_state("Batterie bitte ersetzen")
            elif device.battery_state == 'OUT_OF_OPERATION':
                sh.Gardena.mower.battery_state("Batterie muss ersetzt werden")
            elif device.battery_state == 'CHARGING':
                sh.Gardena.mower.battery_state("Am Laden")
            elif device.battery_state == 'NO_BATTERY':
                sh.Gardena.mower.battery_state("Keine Batterie")
            else:
                sh.Gardena.mower.battery_state("unbekannt")

sh.Gardena.Update_Date(tageszeit)
    time.sleep(5)

sh.Gardena.mower.status('Offline')
sh.Gardena.mower.battery(0)
sh.Gardena.mower.battery_state("Offline")
sh.Gardena.mower.radio_quality(0)
sh.Gardena.mower.in_charge(0)
sh.Gardena.mower.last_status("Offline")
`

Hello,
I am not sure to understand your issue. Do you always have thee issue ? Or the issue appears one time ?
Jérémie

hi Jérémie,
at the moment i didn't get any error. Very strange.
Yesterday my limit exceeded, so i generate a new api key (this is every month) but the main error did not appears. strange!

What do you mean by API key ? a key from the developer portal ?
Strange i never noticed i had to restart my domotic system (but I restart home assistant pretty often, so myabe i did not have a look into it.

Yes from the portal.
i restart every day the connection to the gardena plugin.
In the morning i start it and in the evening i stop it. i have serveral disconnections when i turn it the whole day on.

i never had to recreate an application key from the gardena portal.
Did you tried to contact the dev ?
If not, i can try to contact them but i will ask you for application id and credentials.

mhh strange.
Every month the same.:
i got following error:
2020-09-25  00:19:00 ERROR    websocket         error from callback <bound method Client.on_close of <gardena.smart_system.Client object at 0x646b7910>>: 429 Client Error:  for url: https://api.smart.gardena.dev/v1/websocket
2020-09-25  00:19:00 ERROR    websocket         error from callback <bound method Client.on_close of <gardena.smart_system.Client object at 0x730a3250>>: 429 Client Error:  for url: https://api.smart.gardena.dev/v1/websocket
2020-09-25  00:19:00 ERROR    websocket         error from callback <bound method Client.on_close of <gardena.smart_system.Client object at 0x64642b70>>: 429 Client Error:  for url: https://api.smart.gardena.dev/v1/websocket
2020-09-25  00:19:00 ERROR    websocket         error from callback <bound method Client.on_close of <gardena.smart_system.Client object at 0x65a3ea50>>: 429 Client Error:  for url: https://api.smart.gardena.dev/v1/websocket
2020-09-25  00:19:00 ERROR    websocket         error from callback <bound method Client.on_close of <gardena.smart_system.Client object at 0x60080130>>: 429 Client Error:  for url: https://api.smart.gardena.dev/v1/websocket
2020-09-25  00:19:00 ERROR    websocket         error from callback <bound method Client.on_close of <gardena.smart_system.Client object at 0x605c5f30>>: 429 Client Error:  for url: https://api.smart.gardena.dev/v1/websocket
2020-09-25  00:19:00 ERROR    websocket         error from callback <bound method Client.on_close of <gardena.smart_system.Client object at 0x60456690>>: 429 Client Error:  for url: https://api.smart.gardena.dev/v1/websocket
2020-09-25  00:19:00 ERROR    websocket         error from callback <bound method Client.on_close of <gardena.smart_system.Client object at 0x730af770>>: 429 Client Error:  for url: https://api.smart.gardena.dev/v1/websocket
2020-09-25  00:19:00 ERROR    websocket         error from callback <bound method Client.on_close of <gardena.smart_system.Client object at 0x657f1750>>: 429 Client Error:  for url: https://api.smart.gardena.dev/v1/websocket
2020-09-25  00:19:00 ERROR    websocket         error from callback <bound method Client.on_close of <gardena.smart_system.Client object at 0x658229d0>>: 429 Client Error:  for url: https://api.smart.gardena.dev/v1/websocket
2020-09-25  00:19:00 ERROR    websocket         error from callback <bound method Client.on_close of <gardena.smart_system.Client object at 0x600143d0>>: 429 Client Error:  for url: https://api.smart.gardena.dev/v1/websocket
2020-09-25  00:19:00 ERROR    websocket         error from callback <bound method Client.on_close of <gardena.smart_system.Client object at 0x64698350>>: 429 Client Error:  for url: https://api.smart.gardena.dev/v1/websocket
2020-09-25  00:19:00 ERROR    websocket         error from callback <bound method Client.on_close of <gardena.smart_system.Client object at 0x65805850>>: 429 Client Error:  for url: https://api.smart.gardena.dev/v1/websocket
2020-09-25  00:19:00 ERROR    websocket         error from callback <bound method Client.on_close of <gardena.smart_system.Client object at 0x65a3e4b0>>: 429 Client Error:  for url: https://api.smart.gardena.dev/v1/websocket
2020-09-25  07:21:37 ERROR    gardena.smart_system 429 : Limit Exceeded
maybe my source is not the best and so the websocket don't work good enough. only 30000request a month are allowed.
i will now let my connection alive the whole day. maybe it works better. hope the source or websocket will reconnect after a lost connection

At the moment a have no errors. now i start the plugin only one time at system startup and it refresh the status every second. seams that will work...
did the plugin have a feature to control the mower? e.g. turn it into move home, start mowing?!

Yes it does :)
Le dim. 4 oct. 2020 à 19:11, Pol3cat<EMAIL_ADDRESS>a écrit :

At the moment a have no errors. now i start the plugin only one time at
system startup and it refresh the status every second. seams that will
work...
did the plugin have a feature to control the mower? e.g. turn it into move
home, start mowing?!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/py-smart-gardena/py-smart-gardena/issues/20#issuecomment-703285932,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAARGI4KTWUKAT6RZSWJRQLSJCUEHANCNFSM4PB5ZXHA
.

oh really, keep me in suspense! ;)

Hey hey,
you have 4 methods on the mower device :
sh.Gardena.mower.start_seconds_to_override(duration): starts manually the mower x seconds, overriding the schedule. duration MUST be positive multiple of 60.
sh.Gardena.mower.start_dont_override(duration) : Sets the mower in automatice mode. I think duration is not used but must be defined.
sh.Gardena.mower.park_until_next_task() : Park the mower until next scheduled task
sh.Gardena.mower.park_until_further_notice() : Park the mower and don't restart until manueally restarted
Jérémie

oh thx. really nice.
may i can force start my mower when it runs out of the field. ;)

Force start when it runs out of the field ? Sorry i did not get it.

i have passage with a relay that closes the passage. sometimes the mower stopped in passage and i got the error " out of field". maybe so i can open the passage and force a start command.

I ma not sure about your use case ! As the mower is in error, I am not sure
you will be able to retart it. You should give it a try.
And it would be great to have your feedback ;)
Le mar. 6 oct. 2020 à 10:10, Pol3cat<EMAIL_ADDRESS>a écrit :

i have passage with a relay that closes the passage. sometimes the mower
stopped in passage and i got the error " out of field". maybe so i can open
the passage and force a start command.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/py-smart-gardena/py-smart-gardena/issues/20#issuecomment-704106505,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAARGI75T7WVFH4QGEZ7TZDSJLGINANCNFSM4PB5ZXHA
.

i only get the error in the gardena app not via the api. maybe it will work.
i will try and give you a feedback

Hello @Pol3cat
Do you have some feedback for us ? ;)
Thanks,
Jérémie

Got the same now, when I did a venv reinstall of my project (due to new python interpretter).
This seems to be caused by websocket-client 0.58.0 being installed, rather than 0.57.0 that is explicitly depended on by this project. In 0.58.0 they broke the callback scheme: https://github.com/websocket-client/websocket-client/issues/669
But, not really sure why it installs the newer one.. The only dependency besides py-smart-gardena in my requirements.txt is prometheus-client..
$ ./venv/bin/pip3 install -r requirements.txt
Collecting py-smart-gardena
  Using cached py_smart_gardena-0.7.10-py3-none-any.whl
Collecting prometheus-client
  Using cached prometheus_client-0.10.1-py2.py3-none-any.whl (55 kB)
Collecting requests
  Using cached requests-2.25.1-py2.py3-none-any.whl (61 kB)
Collecting oauthlib
  Using cached oauthlib-3.1.0-py2.py3-none-any.whl (147 kB)
Collecting websocket-client
  Using cached websocket_client-0.58.0-py2.py3-none-any.whl (61 kB)
Collecting requests-oauthlib
  Using cached requests_oauthlib-1.3.0-py2.py3-none-any.whl (23 kB)
Collecting certifi>=2017.4.17
  Using cached certifi-2020.12.5-py2.py3-none-any.whl (147 kB)
Collecting urllib3<1.27,>=1.21.1
  Using cached urllib3-1.26.4-py2.py3-none-any.whl (153 kB)
Collecting chardet<5,>=3.0.2
  Using cached chardet-4.0.0-py2.py3-none-any.whl (178 kB)
Collecting idna<3,>=2.5
  Using cached idna-2.10-py2.py3-none-any.whl (58 kB)
Collecting six
  Using cached six-1.15.0-py2.py3-none-any.whl (10 kB)
Installing collected packages: urllib3, idna, chardet, certifi, six, requests, oauthlib, websocket-client, requests-oauthlib, py-smart-gardena, prometheus-client
Successfully installed certifi-2020.12.5 chardet-4.0.0 idna-2.10 oauthlib-3.1.0 prometheus-client-0.10.1 py-smart-gardena-0.7.10 requests-2.25.1 requests-oauthlib-1.3.0 six-1.15.0 urllib3-1.26.4 websocket-client-0.58.0

By bumping to websocket-client 0.58.0, together with adding "ws" obj, it works again (also in this diff, unrelated reconnect stuff.. keeping it here in case maintainer thinks it might be useful. not sure why I added that last season.. did it crash if first reconnect failed? or just looped? cannot remember!)
@@ -23,25 +25,32 @@ class Client:
         self.location = location
         self.should_stop = False

-    def on_message(self, message):
+    def on_message(self, ws, message):
         self.smart_system.on_message(message)

-    def on_error(self, error):
+    def on_error(self, ws, error):
         self.logger.error(f"error : {error}")
         self.smart_system.set_ws_status(False)

     def is_connected(self):
         return self.live

-    def on_close(self):
+    def on_close(self, ws):
         self.live = False
         self.logger.info("Connection close to gardena API")
         self.smart_system.set_ws_status(False)
         if not self.should_stop:
             self.logger.info("Restarting websocket")
-            self.smart_system.start_ws(self.location)
+            try:
+                self.smart_system.start_ws(self.location)
+            except RequestException as e:
+                self.logger.exception("Failed to auto-reconnect, retrying in 10s")
+                time.sleep(10)
+
+        self.logger.info("Websocket succesfully reconnected")
+

-    def on_open(self):
+    def on_open(self, ws):


MRG: Covariance plots - Colorbar missing

Fixes issue #4941

it's meant to be two figures. They are not axes.
you should not change figures by adding colorbars

Ok I'll change it back

All reverted (hopefully)

looks good. Can you update whats_new.rst to add an entry about your change?
thanks a lot

All done, hope it's ok

thx @ngayraud


Fix broken documentations style

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   64.28%   64.28%
=======================================
  Files           5        5
  Lines          84       84
=======================================
  Hits           54       54
  Misses         24       24
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0db0a...dace3cc. Read the comment docs.

Look like you miss the link of all available command?  https://github.com/apache/skywalking-cli/blob/dace3ccc2c184997621c82f40c57b4e01573ca6b/README.md#all-available-commands


bug: 5.0 ion-tab-button --background-focused variable not working

Bug Report
Ionic version:

[x] 5.x
Current behavior:

The background of ion-tab-button elements remains unchanged when they receive focus, even though the --background-focused CCS4 variable for ion-tab-button elements is set.
Expected behavior:

I expected the ion-tab-button elements' background to get the background color I set in the --background-focused variable.
This is supposed to happen if I understand the docs correctly, see
https://beta.ionicframework.com/docs/api/tab-button
Steps to reproduce:

Create an Ionic tabs starter.
In the tabs.page.scss file paste:

ion-tab-button {
    --background-focused:#ff600d;
    --background-focused-opacity:0.5;
}

Observe that when a tab button receives focus its background remains unchanged.

Related code:

insert short code snippets here

Other information:

Ionic info:

Ionic:

   ionic (Ionic CLI) : 6.3.0
   Ionic Framework : @ionic/angular 5.0.0
   Angular CLI: 9.0.1
   angular/common: 9.0.0
   angular/core: 9.0.0
   angular-devkit/architect: 0.803.23
   angular-devkit/build-angular: 0.900.1
   angular-devkit/core: 9.0.1
   Node: 10.14.2
   OS: Windows10 x64

Thanks for the issue. Can you try this again with the latest version of Ionic Framework? I am not able to reproduce the issue: https://codepen.io/liamdebeasi/pen/mdJNVRJ

hi, Using the latest version @ionic/angular": "^5.0.7 ion-tab-button is selected, it still cannot be displayed --background-focused a color

Thanks for the follow up. Can you provide a repo with the code required to reproduce this issue?

I think I found the problem. When using the Tab key, it can trigger --background-focused. When it is selected, it triggers tab-selected. I want to add the following code to the CSS of the tab-button to solve this problem.
:host(.tab-selected) {
  color: var(--color-selected);
  background: var(--background-selected);
}

Add a --background-selected attribute

@nidiy In order to change the tab button color when focused, you need to use the --background-focused CSS Variable. --background-selected is not a CSS Variable that exists on ion-tab-button.
Can you provide a reproduction with the code required to reproduce this issue? Without a reproduction, it is unlikely I will be able to fix this issue. Thanks!

Thanks @liamdebeasi
Use a simple method
ion-tab-button.tab-selected{     background:#ff600d; }
my problem is solved


[SPARK-40156][SQL] url_decode() should the return an error class

What changes were proposed in this pull request?

url_decode() return an error class when Invalid parameter input. like :
spark.sql("SELECT url_decode('http%3A%2F%2spark.apache.org')").show

output:
org.apache.spark.SparkIllegalArgumentException: [CANNOT_DECODE_URL] Cannot decode url : http%3A%2F%2spark.apache.org.

Why are the changes needed?

To improve user experience w/ Spark SQL.
Does this PR introduce any user-facing change?

no
How was this patch tested?

$ build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z url-functions.sql"

Can one of the admins verify this patch?

+1, LGTM. Merging to master.
Thank you, @zzzzming95.


chore: remove all instances of inline(always) from corelib

As suggested by @orizi in the discussion to PR #5911.

This change is

@ilyalesokhin-starkware

Can we move this forward before it rots more than it already has? :sweat_smile:


Improving the contact section

I want to tackle this issue. Please assign me this issue of improving the contact section.

Please assign this issue to me

please assign this issue to me


Span Processors do not respect sampled flag when exporting

What version of OpenTelemetry are you using?
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>What version of Node are you using?
14.17.3
What did you do?

Set up a BasicTracerProvider
Add a sampler that downsamples traces
Add a BatchSpanProcessor or SimpleSpanProcessor
Add an exporter, either a dummy that logs spans or an actual exporter

What did you expect to see?
Expected that only sampled spans would be exported, per the spec, and as described by doc comments on SimpleSpanProcessor and the SpanExporter interface.
What did you see instead?
All spans are exported.
Additional context
It seems that the sampled flag was originally being respected by Span Processors, but the logic was removed in this PR: https://github.com/open-telemetry/opentelemetry-js/pull/798. The rationale at the time was that the check was redundant, since Tracer was also checking the sampled flag and preventing unsampled spans from being recorded.
In a later PR https://github.com/open-telemetry/opentelemetry-js/pull/1058, the Tracer check was changed to differentiate between not recorded and not sampled, which resulted in no check being made for the sampled flag.
Looks like the original check in Span Processors just needs to be re-added, which I would be willing to take on and make a PR for. There should probably also be a test for this to ensure that the spec is met.

The sampling decision is checked in Tracer and it creates a NonRecordingSpan (via ) or a "real" Span depending on this.
SpanProcessor.onStart() is  called in Span constructor.
According to spec that seems to be ok. Spec does not require that recorded spans are not exported (should not instead
Which sampler do you use and which return value is used by your sampler? Is it NOT_RECORD or RECORD?

In the "Sampling" section of the specification, the flag you're referring to is called IsRecording, but there's a second flag, Sampled, which is the one I'm referring to. The sampling decision has 3 possible values, DROP, RECORD_ONLY, and RECORD_AND_SAMPLE. The check in Tracer handles the DROP decision, but cannot differentiate between RECORD_ONLY and RECORD_AND_SAMPLE because that handling is the Span Processor's responsibility. The table in the "Sampling" section makes the point clearer, where if IsRecording is true but Sampled is false, the span should reach the Span Processor but not the Span Exporter. It's also stated in the text: "Span Processor MUST receive only those spans which have this field [IsRecording] set to true. However, Span Exporter SHOULD NOT receive them unless the Sampled flag was also set."

Yes, the bug was encountered when using a custom sampler that uses RECORD_ONLY. I see how the included samplers would hide the issue.


HLS streaming error:  first NALU does not contain the start bit

Which version are you using?
v0.16.0
Which operating system are you using?

OS

[ ] Linux
[X] Windows
[ ] macOS

Describe the issue
Description
Pushing stream to server.
Connecting to HLS stream.
Errors are:
2021/05/10 12:02:47 I [1/0] [HLS] [converter 9999] opened 2021/05/10 12:02:47 I [1/1] [HLS] [converter 9999] is converting into HLS 2021/05/10 12:02:47 W [1/1] [HLS] [converter 9999] unable to decode video track: first NALU does not contain the start bit 2021/05/10 12:02:47 W [1/1] [HLS] [converter 9999] unable to decode video track: first NALU does not contain the start bit 2021/05/10 12:02:47 W [1/1] [HLS] [converter 9999] unable to decode video track: first NALU does not contain the start bit 2021/05/10 12:02:47 W [1/1] [HLS] [converter 9999] unable to decode video track: first NALU does not contain the start bit

Hello, to test HLS you can use this configuration:
paths:
  proxied:
    source: rtsp://wowzaec2demo.streamlock.net/vod/mp4:BigBuckBunny_115k.mov

I know that the conversion can fail with some streams (and this can be improved); in particular, at the moment the converter starts converting as soon as possible, and this happens: big frames are usually split into many packets, and if a packet of a previously-existing frame is received, the converter prints errors like the one you reported:
[0/1] [HLS] [converter proxied1] unable to decode video track: first NALU does not contain the start bit

Therefore a first step could be improving the converter to wait for the start of a frame before running.

Have you tested it with a record type stream that is pushing to the server? instead of a proxy stream?

Have you tested it with a record type stream that is pushing to the server? instead of a proxy stream?

Thanks, I have tested it with a record type stream and it works fine (tested by connecting directly to the HLS streams remotely). I have 2 rstp-simple-servers (the remote location set as record and the local server set as proxied). I would like this setup as I wish to have just one connection to the remote and stream to many locally.

This error should be fixed with newer releases. In case it reappears, feel free to post again. A sample .mp4 file would be helpful to replicate the issue.


Please upgrade isar_generator dependencies

While using isar_generator, the latest version:
isar_generator: ^3.1.0+1

... I regularly see dependency conflict errors with other generators. e.g.: We can't use the riverpod_lint package while using isar_generator:
dev_dependencies:
  flutter_test:
    sdk: flutter
  build_runner: ^2.4.6
  riverpod_generator: ^2.3.3
  freezed: ^2.4.5
  json_serializable: ^6.7.1
  flutter_lints: ^2.0.3
  isar_generator: ^3.1.0+1
  custom_lint: ^0.5.3
  riverpod_lint: ^2.3.1

Error:
Because riverpod_lint >=2.2.1 depends on analyzer ^6.0.0 and isar_generator 3.1.0+1 depends on analyzer >=4.6.0 <6.0.0, riverpod_lint >=2.2.1 is incompatible with isar_generator 3.1.0+1.
And because no versions of isar_generator match >3.1.0+1 <4.0.0, riverpod_lint >=2.2.1 is incompatible with isar_generator ^3.1.0+1.
So, because orcapod_app depends on both isar_generator ^3.1.0+1 and riverpod_lint ^2.3.1, version solving failed.

You can try the following suggestion to make the pubspec resolve:
* Consider downgrading your constraint on riverpod_lint: flutter pub add dev:riverpod_lint:^2.1.1

Any news? Is this package maintained at all?
isar is being incompatible with riverpod_generator because of analyzer, but also with device_info_plus because of ffi.

dependencies_override:
  <package_name>: <target_version>

Before isar's maintainer come back from daily works, you can try this.

This does not become an problem if all the dependencies are added at the same line (so that the dependency resolution system can find a version that satisfies both).
flutter pub add isar isar_flutter_libs path_provider flutter_riverpod riverpod_annotation
flutter pub add -d isar_generator build_runner riverpod_generator custom_lint riverpod_lint


[feature] "Render anchor tag content" option should be at watch-level in the Filters & Triggers section

[feature] "Render anchor tag content" option should be at watch-level in the Filters & Triggers section
it only exists on the global settings which is kind of annoying

guess it needs also [use default] option at watch level


Write automated tests: Android Basics with Compose

fun calculateTip(amount: Double, tipPercent: Double: roundUp: Boolean).......this line has an issue in the code lab

Duplicate of https://github.com/google-developer-training/basic-android-kotlin-compose-training-tip-calculator/issues/126


docs(pacnewrelic): add pacrd new relic configuration

@aimeeu is there anything preventing this from being merged?

@aimeeu is there anything preventing this from being merged?

Probably just committing the suggestions?


Update wizardcode-15b.yaml

Updated to latest version, since q4_0 returns a 404
Fix for #30

Using q8 is really not recommended. its also the same age as the q4 so I don't understand the statement of " updated to latest version "?

Sorry, I thought I modified the version as well, there's 1.0 and 1.1 of wizardcoder-guanaco


BACKLOG-17183 Replace view mode buttons with a dropdown

JIRA

https://jira.jahia.org/browse/BACKLOG-17183
Description
Replace view mode buttons with a dropdown. Note that original notes in the ticket should not include the last two cases for pickers.

Probably need to wait for 8.1.2 release before merging cc @rknj


fix: crash when insert nil value into a dictionary

Summary
This PR attempts to fix issue https://github.com/facebook/react-native/issues/28278 and https://github.com/facebook/react-native/issues/29525
On Crashlytics, the following error occurs in file RCTWebSocketModule.m at method -[RCTWebSocketModule webSocket:didFailWithError:] when a nil value is inserted into a dictionary as a value.
Fatal Exception: NSInvalidArgumentException
*** -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[0]

This PR is following the suggestion of this: https://github.com/facebook/react-native/issues/28278#issuecomment-597461650 and it replaces the values of any property if it is nil. In detail:

it converts error to empty NSString if the original value is nil
it converts socketID to a NSNumber object, which stores -1 if the original value is nil

Changelog
[iOS] [Fixed] - A crash in WebSocket module
Test Plan
We were not able to reproduce the crash, but the report itself provided enough information to find a solution for this issue.

thank you @marksinkovics


docs: fix typo in reproduction documentation

This pull request fixes a typo in the How to reproduce crashes documentation.

Thanks


Option "comp-lzo" is deprecated in OpenVPN 2.4

According to Tunnelblick on MacOS, comp-lzo is deprecated in OpenVPN 2.4 and may be removed in OpenVPN 2.5.

Having this option in the configuration may lead to clients not able to connect to the server. To fix this, it seems we can simply remove the comp-lzo option from the configuration.

comp-lzo is indeed deprecated and was referenced in #220. I am hoping to switch directly from comp-lzo to compress lz4.
There is no reason to remove comp-lzo prematurely because as far as I know it will not be removed in OpenVPN 2.5, I don't understand why Tunnelblick developers say this but I can't find a source about it. Please let me know if I have missed something.
People should consider that comp-lzo is a very widely used option and LZO compression itself isn't being removed or deprecated, only the option has been renamed to a better syntax. That's why I seriously doubt that comp-lzo will disappear in 2.5, it would be a very bad idea from my point of view.
TL;DR: developers haven't announced the removal of comp-lzo. I am well aware that it has been deprecated, but is there for compatibility.
PS: you can avoid that warning switching from comp-lzo to compress lzo in your client.

Hi! Apologies, while I had opened and read that issue, I had not seen the line about lzo. I'm not sure what their source is for showing it to be removed in 2.5. A lot stuff seems to have changed in 2.5, perhaps they've simply made a mistake.
Would changing comp-lzo to compress lzo (which helped, thanks!) have any disadvantages if we made this the default?

Would changing comp-lzo to compress lzo (which helped, thanks!) have any disadvantages if we made this the default?

Yes, that would break configuration in OpenVPN <2.4. That’s the case for example in the Ubuntu 16.04 official repos.

What is the equivalent to comp-lzo no?

@pixelrebel read the issue, it is explained in my first response.

@Nyr I don't see a mention of how to disable compression with the new syntax.  Reading the specs, it seems there is not a no or none option.  That would have me believe to disable compression from the client side just compress would suffice (which is extremely confusing).

@pixelrebel from the OpenVPN manual:

If the algorithm parameter is empty, compression will be turned off, but the packet framing for compression will still be enabled, allowing a different setting to be pushed later.

Compression is fully disabled if you don't set compress to begin with.

Ah okay, I read that as compression is still enabled at some level.  Thanks for the clarification @Nyr !

i used "compress lzo",but the prompt "compress lzo" is deprecated in OpenVPN 2.5,I consider not compressing
https://superuser.com/questions/1686651/why-is-compression-not-recommended-in-openvpn


Add Contributors list

Adds contributors depending on the GitHub API to the bottom of the homepage

@hirotachi Thanks for the PR :)


Improve explanation of Problem 1.2's solutions

Following a question in the Q&A session of Feb 1, I have expanded on the solution to problem 1.2 since there was some confusion about the method being used which appeared to just be guessing but is easily turned into an algorithm.
The changes are applied in both the markdown and the Jupyter notebook.

This should be ready to merge. @dlfivefifty


New format to be able to post date value in UTC

New date format "Z" that formats the entire date value using toUTCString(). Useful for the config.dateFormat as it allows to POST date value converted to UTC to the web server while allowing the user to manipulate the date in local time thanks to config.altFormat.

Coverage increased (+0.1%) to 88.339% when pulling 016744a074404108f6f83955ec7cf6ca2221fd9a on dvacet:patch-1 into 8974e660fde6a7e57a558fa998180a02aa0dcf1f on chmln:master.

Hello,
I like the idea, but wouldn't ISO strings be more applicable?

The toISOString() method returns a string in ISO format (ISO 8601 Extended Format), which can be described as follows: YYYY-MM-DDTHH:mm:ss.sssZ. The timezone is always UTC as denoted by the suffix "Z".
The value returned by toUTCString() is a human readable string in the UTC time zone. The format of the return value may vary according to the platform. The most common return value is a RFC-1123 formatted date stamp, which is a slightly updated version of RFC-822 date stamps.

The toISOString is newer and very old browsers do not support it (see http://kangax.github.io/compat-table/es5/) Yes I agree IE8, iOS5.1, Opera 10.1 are ancient. If you already know flatpickr does not work in the old browsers anyway then use the newer toISOString as it is more strictly specified.
Thanks

The toISOString is newer and very old browsers do not support it (see http://kangax.github.io/compat-table/es5/) Yes I agree IE8, iOS5.1, Opera 10.1 are ancient. If you already know flatpickr does not work in the old browsers anyway then use the newer toISOString as it is more strictly specified.
Thanks

Feel free to amend your pull request, I'll gladly accept it.
And thank you for contributing :+1:

Coverage increased (+0.3%) to 88.498% when pulling bfde94ac1dbc6051a30050b336d563d8ca7ca6cd on dvacet:patch-1 into 8974e660fde6a7e57a558fa998180a02aa0dcf1f on chmln:master.

OK, let's use the newer toISOString.


Portainer sometimes reports 'Image successfully pulled', but it doesn't

Bug description
Try pull an image that isn't multiarch and Portainer says image pulled, because Docker API returns a "success operation" response, but it doesn't actually pull. Also sometimes caused when registry access is blocked by a strict firewall
Expected behavior
There should be an error displayed if the image can't be pulled e.g No matching image for [OS_Here]
Steps to reproduce the issue:
(On windows)

Go to Images view
Try to pull the mssql/server image from mcr.microsoft.com
Get Image successfully pulled toast notification
See that the image hasn't actually pulled

Technical details:

Portainer version: 1.23.2
Docker version (managed by Portainer): 19.03
Platform (windows/linux): Windows 10
Command used to start Portainer (docker run -p 9000:9000 portainer/portainer):
Browser: Chrome/FireFox

Additional context
{"status":"Pulling from mssql/server","id":"latest"}
{"errorDetail":{"message":"image operating system \"linux\" cannot be used on this platform"},"error":"image operating system \"linux\" cannot be used on this platform"}

{"status":"Pulling from library/alpine","id":"latest"}
{"errorDetail":{"message":"no matching manifest for windows/amd64 in the manifest list entries"},"error":"no matching manifest for windows/amd64 in the manifest list entries"}

I now have a plan here, is to add a condition in the success judgment whether the pull is successful, the condition is judged from the server feedback data, the modification will not affect the function of portainer, the modification is as follows, please help you see if you can fit into it?
diff --git a/app/docker/views/images/imagesController.js b/app/docker/views/images/imagesController.js
index 1933af39..3650a713 100644
--- a/app/docker/views/images/imagesController.js
+++ b/app/docker/views/images/imagesController.js
@@ -30,8 +30,14 @@ angular.module('portainer.docker').controller('ImagesController', [
   $scope.state.actionInProgress = true;
   ImageService.pullImage(registryModel, false)

   .then(function success() {

     Notifications.success('Image successfully pulled', registryModel.Image);

   .then(function success(data) {

     var err = data.length > 0 && data[data.length - 1].hasOwnProperty('errorDetail');

     if (err) {

       var detail = data[data.length - 1].errorDetail;

       Notifications.error('Failure', detail, 'Unable to pull image');

     } else {

       Notifications.success('Image successfully pulled', registryModel.Image);

     }
     $state.reload();
   })
   .catch(function error(err) {

I now have a plan here, is to add a condition in the success judgment whether the pull is successful, the condition is judged from the server feedback data, the modification will not affect the function of portainer, the modification is as follows, please help you see if you can fit into it?

@deviantony Please help me to see if the above code can be incorporated, thank you!

Join request address:
https://github.com/portainer/portainer/pull/5164

Thanks for the contribution @qinzhiben11 , we'll have a look at it shortly.


MP3 and OGG support

Added support for decoding .mp3 and .ogg (Vorbis) files.

mp3 are decoded using minimp3
ogg are decoded using JUCE.

Added error message when dropping a file with the wrong file format.
Updated readme.
Needs to be tested on Windows.

Code looks good, still need to test on windows, but just wanted to say that it would be useful to maintain the tag or git commit of each dependency. Even just " " lines in ThirdParty/vendor.txt would be enough.

Added https://github.com/DamRsn/NeuralNote/pull/61

I merged the assert PR and fixed unit tests!


Only print unique top results

The top results have a tendency to repeat with slightly different velocities. I need to clean this up and post unique results to the top results.

Closed with #2


VT - Invalid Value in OBX-15.3 (Producer’s Reference/Name of Coding System)

VT reported an issue where all test results from SimpleReport received around 3:15 pm Eastern on 11/30 were failing HL7 validation due to an invalid value in OBX-15.3 (Producer’s Reference/Name of Coding System).
The value they are receiving is “CLIA”, which is not a valid value for this field defined in the HL70396 table. In files received prior to 3:15 pm today, OBX-15.3 was being left blank and the messages were processing successfully.

@jorg3lopez put some sample resend messages in VT's test feed. I informed VT test files were ready for review. Awaiting approval to resend the batch of test results.
Jorge, please use this ticket for updates related to the resends for OBX-15.3 issue.

OBX-15-3 has been suppressed.

@jorg3lopez VT has validated the test messages. So please resubmit the messages to their prod directory.

@jorg3lopez let us know when all the files in  3:15 pm batch and when the fix was put into place and working have been resent so we can let VT know. You may need to double check how often we sent files to VT to make sure we don't miss anything. Thanks.

@anshulkumar-usds @mlighdc I have located all the files that failed due to OBX-15-3.  Do you want me to send one of the files to their test feed first for approval?

@jorg3lopez yes please, and share the file name here in comments so I can follow up with VT.

@anshulkumar-usds @mlighdc I uploaded all the files that failed due to OBX-15-3. I also uploaded the file that they accepted in their test feed. All files were uploaded to their prod folder.
Files:
covid-19-61e77aa7-596a-45db-8636-f0f52adf7387-20211130205405
covid-19-9b58f7bd-fc34-44ba-9ff7-e1f445730c49-20211206234000
covid-19-40c9a8f8-2401-4dc5-aa80-6c75f90be4ee-20211206233901
covid-19-988aacb2-5d70-49a7-9ec2-1d2ed45bfec7-20211206233504
covid-19-cdafd608-3c84-4855-8727-9ed5ad5a2fe8-20211206234000
covid-19-fea642c8-9640-4db5-8050-e2cea82a1586-20211206233901
I will email Theresa to let her know.


Google page rendering instead of pagekit homepage

Hello.
We using pagekit 1.0.2 on our VPS with php 7.0.4 on Ubuntu Server 16.04.
All work fine.
But today, we post new blog article.
And have that home page rendering this http://foxweb24.ru/
What is it ?
I try too disable all modules http://i.imgur.com/UeRi5ov.png.
I clear caches.
But nothing helps.
Technical Details

Pagekit version: 1.0.2
Webserver: Apache/2.4.18 (Ubuntu)
Database: 5.7.12-0ubuntu1
PHP Version: 7.0.4-7ubuntu2.1

What is the name of your theme ? It's a custom theme ?

This seems to be resolved? Can you provide any details what happened here?


Get a list of methods for override in subclass

Type: Feature Request
PyCharm has a modal that allows me to view all non-overriden methods and select which ones to override. Can VSCode's Python extension offer a similar feature?
Extension version: 2022.20.2
VS Code version: Code 1.74.3 (97dec172d3256f8ca4bfb2143f3f76b503ca0534, 2023-01-09T17:05:47.808Z)
OS version: Darwin arm64 21.6.0
Modes:
Sandboxed: No

Thanks for the request. Will add this to the enhancement discussion for Offer completions when overriding class methods
#2950


Integration Test - Release - 2019/06/14 17:45:18

Auto create for integration test. IssueCommandFlow

@PRMergerTest3 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMergerTest3 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


MagicMirror is not formatted

Hey guys,
It seems that the Interface´s formatting is not active.
https://gyazo.com/c983b006ad854eb498de238a58bcb3fc
I guess it´s the same issue which is solved https://github.com/MichMich/MagicMirror/issues/89 but I don´t know what to do / What is the right directory of the CSS files?

Check your web inspector.

In time.js line 26
this.intervalId = setInterval(function () {
it displays "anonymous function"

In time.js in line 26 there is an anonymous funktion
this.intervalId = setInterval(function () {
but i dont think this causes my problem?!
Sorry I don´t have so much knwoledge about this.

Could You post a screenshot of your web inspector?

Could you show what's in the console part?

Are you using a web server? Looks like you are using a file:// link?
Am Fr, 25. Mär 2016, um 13:20, schrieb DominicDecocco:

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/MichMich/MagicMirror/issues/102#issuecomment-201259885

looks like php is not installed

Sorry guys, I was on holiday..
I reinstalled everything again..copied the files to /var/www/html/

...after boot, chromium starts and it displays the same issue:(

[Webserver is running cause the console displays localhost;right?]
May I forgot something or made a mistake again?

What's the url Chromium uses?

How can I check that?

What URL did you use in your autostart?

http://localhost

If you click on the CSS folder in your debuggers left column. Doest it show a css file with contents? (In other words, does it load the CSS file?)

It shows
font-awesome.css
weather-icons.css

It appears the main css file isn't loading. Is it in the css folder?

Ok. Yes it is in the folder.

Sorry, I just remember the main CSS isn't included the usual way. It uses some PHP including: <?php include('css/main.css') ?>
That fact that this doesn't work probably is because your PHP isn't working. Like @ski7777 said before.

Well ok. Apache & PHP-Support are installed (according to your instructions Webserver) and the index.php is in the folder, too.
What else can I do?

You could go adventurous, and try the new V2 version I'm currently building. Build it's in an early stage so I can't give any support yet. Checkout the V2-beta branch.

Yes that would be an interesting option..
Could it also be issued by the raspberry I use..it´s pi 3?

Yes, the installation is much more simple. I didn't yet test it on a Raspberry Pi though. But user @paviro did, so it should be working.
Keep in mind it's on heavy development at the moment, so you might need to update it every so often.

Haven't run it on a Pi for quite some time now but it works you just have to install nodejs. Going to setup the new version on my Pi, as well today.

Yeah I´m gonna try it when v2 is finished.
Do you have any idea why the php is not working?


Swift 4 - Decodable/Encodable protocols

New Swift 4 will include a new encoding/decoding protocols (https://github.com/apple/swift-evolution/blob/master/proposals/0166-swift-archival-serialization.md)
Since Gloss is sharing the same namespace for protocols Decodable/Encodable, I suggest we change the name of the protocols, so Gloss can be a separate library to the new solution proposed by the Swift language team.
@hkellaway - thoughts?

yeah - i saw that and was thinking similarly 😑  perhaps JSONDecodable and JSONEncodable.
i'll create a swift_4 branch for if you or any of the WWDCers feel inspired to get tinkering

Since Swift has module namespacing, for now Gloss is usable in XCode 9 by simply prepending "Gloss." to all use of Decodable and Encodable. Probably not an ideal solution long term though!

Have you considered making a Gloss 2.0 which builds on top of the Swift 4 primitives?
I haven't dug in deeply, but I feel like these spots can be much more ergonomically handled by a 3rd party library like Gloss than what's in Swift 4:

custom date encoding/decoding.  Personally I have Glossy structs that have Date fields that need to use different DateFormatters (e.g. for legacy reasons some fields are UTC, some ISO8601, and others just MM/DD/YYYY).  Swift.Codable requires me to set the encoder/decoders date decoding to custom, and then inspect the CodingKey keyPath to decide on the DateFormatter to use (since I can't use the same DateFormatter for all of the fields)

custom encode/decode functions:  Personal choice, but I prefer Gloss' ~~> and <~~ to the try-heavy approach used in init(from decoder: Decoder) and func encode(to encoder: Encoder).

I feel like there's room for a "DSL" over Codable that combines the CodingKey concept (which is great!) with Gloss' ergonomics (which is even greater!).
Even a Gloss 1.x that adds support for CodingKeys for the JSON keys would be awesome (no more duplicating key name strings in toJSON and `init1!).

Neat ideas! Though I had not considered a re-write on top of Swift JSON parsing. I was simply going to update for compatibility. I was more viewing this an opportunity to eventually halt feature development as native JSON parsing gains popularity. I don't have the bandwidth to personally support Gloss indefinitely.
I agree there's room for a DSL on top of Swift's and others are free to take that notion and other ones present in Gloss and run with it.

@hkellaway according to the doc, we have to write 2 separate methods to support transform and reverse transform, but ObjectMapper requires only one.
I know if we use 2 methods there are certain benefits, but can I only write one?
--------------------------------
If you use carthage the display names in the terminal output have some issues:
*** Building scheme "Gloss" in Gloss.xcodeproj
*** Building scheme "Gloss MacOS" in Gloss.xcodeproj
i think we can change it to be Gloss iOS and Gloss macOS

@lastcc im interpreting this as 2 separate questions

im not familiar with ObjectMapper - taking a quick look at their docs, maybe you're talking about their TransformOf syntax? no, there is not an equivalent in Gloss
true, the naming of the framework targets could be more precise as you describe

Is it possible to start a new version string for swift 4 branch like 1.4.x and release on Cocoapods?
I know we can use with branch parameter in cocoapods but to be able to use in podspec file of my private pod i need a seperate version. AFAIS pod version is same in "swift_4.0" branch as "master"

@ergunkocak swift_4.0 is currently the same as master so you can point to 1.2.4 in your private spec. once updates for Swift 4.0 are made i can release specific betas on CocoaPods, sure

FYI it sounds like the Cocoapods situation for Swift 4 hasn't been fully
resolved:
https://github.com/CocoaPods/CocoaPods/issues/6791
This link has some potential solutions.  The good news is that your Podfile
can include all Swift 3 projects, and your main project can be Swift 4, as
that's what I've been doing.  During the migration, just upgrade your main
xcodeproj to Swift 4, leave all your Pods unchecked in the first screen of
the migration wizard.
Currently, it sounds like if you want to have individual pods built with
Swift 4, you need to use the installer.pods_project.targets.each do |target| loop suggested in the comments, as pod specs don't yet have a
field for defining the Swift version of a project (understandably as Apple
has changed the combat story w/ every Xcode release).
So, until things shake out a little more, my suggestion would be for the
official Gloss release to remain Swift 3.2, and for most people to use
Swift 3.2-compatible pods in their Podfile.  If Gloss 1.3 was released as
Swift-4 only code before Cocoapods adds Swift version support to the pod
spec DSL it'll probably just cause more confusion and Github issues to be
opened than it's worth at the moment.
On Fri, Sep 15, 2017 at 8:26 AM, Harlan Kellaway<EMAIL_ADDRESS>wrote:

@ergunkocak https://github.com/ergunkocak swift_4.0 is currently the
same as master so you can point to 1.2.4 in your private spec. once
updates for Swift 4.0 are made i can release specific betas on CocoaPods,
sure
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/hkellaway/Gloss/issues/296#issuecomment-329815421,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADREItS8FBmlNPiUdL98ESZQlp7TwqMks5sipcegaJpZM4NxFog
.

thats good to know, tnx @ryanschneider

fyi - version 2.0.0-beta.1 has been released with minimum changes for Swift 4 compability

@hkellaway do you need some help fully migrating to swift 4?

@GabrielAraujo i appreciate you asking - i could use assistance.
version 2.0.0-beta.1 should work with Swift 4. however, it would be nice to have uniquely named protocols to disambiguate from Foundation. i was thinking JSONDecodable and JSONEncodable.
are there other Swift 4 migration tasks you see?

@GabrielAraujo i think i still prefer JSONDecodable and JSONEncodable, more descriptive
if you'd like to help move to that, that'd be great

@hkellaway I began to perform the changes to JSONDecodable and JSONEncodable but I also noticed that Encoder, Decoder, JSONEncoder and JSONEncoder are already being used by swift. Do you think we should also change the names for Encoder and Decoder or is it just too much? hahah
https://github.com/GabrielAraujo/Gloss

thanks @gabrielaraujo! im okay leaving those as-is

@hkellaway
https://github.com/hkellaway/Gloss/pull/311

naming will be updated to JSONDecodable and JSONEncodable as of version 2.0.0-beta.2
thanks @GabrielAraujo!

@hkellaway glad to help!!
Man, is there any remaining changes in the roadmap? Why is it beta?

just giving folks time to report any issues with the Swift 4 version before the official release of 2.0
there is one outstanding PR submitted before Swift 4 transition I want to revisit


Refactor label keys in Fluid

Currently, most label keys used in Fluid are got from "getXXXLabelName"-style functions with RuntimeInfo or RuntimeEngine as their receivers.
For example:
type RuntimeInfoInterface interface {
	// GetStoragetLabelname(read common.ReadType, storage common.StorageType) string

	GetLabelNameForMemory() string

	GetLabelNameForDisk() string

	GetLabelNameForTotal() string

	GetCommonLabelName() string

	GetRuntimeLabelName() string

	GetDatasetNumLabelName() string
         ....
}

This regards the label keys as members of these structs. While I think it's better to think label keys as a convention defined by Fluid. Therefore, I suggest we should make the functions as common utils. Like:
func GetCommonLabelName(namespace, name string) {
     return common.LabelAnnotationStorageCapacityPrefix + namespace + "-" + name
}

I think move label function to common is good idea.


Instruct user on how to resolve "dirty working tree" problem

Provides a slightly more helpful error message that continue to present
the problem, but also gives the user a hint on how to resolve it. This
may save some people a trip to Google and back.
@kr I ran into this one and had to land on #24 via Google because it
wasn't too intuitive to me what I should do about it. Would you consider
this slightly expanded error message to provide a little extra help?
Thanks!
Helps address #24.

LGTM

@brandur Thanks! Merged.

Ran into this problem and Google led me here. My "workaround": git stash before godev save.
However, it seems to me too much a restriction. I'd prefer a warning over a hard stop as developers should be able to experiment changes before committing them regardless.


PlaybookView unable to build on tvOS

Happy to open a PR on this one.
But it appears we can't compile PlaybookView on tvOS.
What's alarming is we don't have the PrefirePlaybookPlugin linked yet it's still generating and trying to compile PlaybookView

Example project might be blocked by AccessibilitySnapshot compatibility anyway:
https://github.com/cashapp/AccessibilitySnapshot


Option to show suggestions on initial Focus

Simply add the suggestions to the sink if the user set the showSuggestionsOnFocus to true.

@larsvombruch Thank you so much for the PR, I really appreciate it and the fix looks valid to me, but its already fixed and deployed in https://github.com/maheshmnj/searchfield/commit/182d5c7559d5d78860d9de7bb5deb2ff7bf03700


The title itself is optional as per <IP_ADDRESS>.  EXTINF but a duration is not

This avoids NullPointerExceptions during write if an optional title is not part of read playlist

Adopted this a little bit. I see the point of having a dedicated validation stage right now. Left a TODO for that.


remove some usage of mutable bytes

There is still more to clean up though.

Pull Request Test Coverage Report for Build 4378
Details

6 of 9 (66.67%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.4%) to 83.312%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

bytes/bytes.mbt
1
2
50.0%

builtin/stringbuilder_buffer.mbt
2
4
50.0%

Totals

Change from base Build 4377:
1.4%

Covered Lines:
4653

Relevant Lines:
5585

💛  - Coveralls


Added README.

@agc93 Would you mind taking a look at this?

Looks good enough to start with to me. Maybe worth calling out that the same process to create ping/pong can be used to create any command? Just makes it clearer.
We'll want to pull together some proper docs including hosting and extensibility which I'll try and get a start on over the next few days..

@agc93 Don't you think that's implied?
Sounds awesome with the docs. What do you want to use? Wyam or DocFX?

@agc93 I went ahead and merged this since I'm having a bit of writers block 😄

Personally, I'm a DocFX fan but I'm happy to try out Wyam. I'll just do up some Markdown and it can work with either