[Feature] Enable backward driving

New Feature
Running in the backward direction is essential function for turning back or parking back.
However, it is not yet realized in Autoware now.
Since individual nodes are made on the assumption of running in the forward direction, it is necessary to correct them.

Has any progress been made in this feature?

Has any progress been made in this feature?

Since this issue was created, yes. However, we have moved to Gitlab and back since then. You can find the Gitlab version of this ticket here: https://gitlab.com/autowarefoundation/autoware.ai/core_planning/-/issues/8. However, this feature was not completed (as you can see from that issue) and there is still more to be done. We would be glad to see PRs for this feature.

According to issue #8 in GitLab this issue should be resubmitted at core_planning but unfortunately I couldn't find a corresponding issue for that. Has there been any progress? Thanks!

@d0l1v3 Please do not bump zombie issues. Additionally, Autoware.AI is no longer actively developed. This feature will never be added to this fork of Autoware.AI.


Python 3

The source code seems to be written for Python 2 and thus don't run under Python 3 right?
They seem outdated

Hi raffamaiden, yes, it was written for Python 2.7.


login steps hangs without showing URL

The role runs cloudflared login which hangs until the certificate is issued, but there's no way to see the authorization URL to make this happen.

I'm not even sure this can be solved, as ansible doesn't have a mechanism for it, and cloudflared insists on waiting for the token within the same process, rather than being able to print the URL, exit and then go back for it later.


windows11上构建hello_world项目，ninja编译失败，报找不到目录的错误 (IDFGH-6886)

环境：win11
idf版本：4.4
按照https://docs.espressif.com/projects/esp-idf/zh_CN/latest/esp32/get-started/linux-macos-setup.html网址进行操作的。idf.py build 调用cmake编译完成之后，调用ninja进行编译。报系统找不到指定的路径的错误

尝试：我手动执行报错的命令：cmd.exe /C "cd /D C:\Users\ming\hello_world\build && E:\Espressif\tools\cmake\3.20.3\bin\cmake.exe -E touch C:/Users/ming/hello_world/build/project_elf_src_esp32.c"。发现还是报错，通过排查，发现不支持cmd.exe /C "cd /D xxx”这种用法

Hi @arashrun.
You are using Windows so please use the Windows Tool Installer and follow the recommendations from https://docs.espressif.com/projects/esp-idf/en/latest/esp32/get-started/windows-setup.html. You have linked the guide for Linux and MacOs. The Windows Tool Installer will install an environment where everything will be set up.
If you still encountering an error then please copy the error output here instead of sharing it as an image. I cannot use translator if image is provided and some of the command lines are cut in half and not shown. Thanks!

Hi @dobairoland .
I am sure i have install the Windows Tool on my Windows11. Here is the complete output.
hello-world-log.txt
By the way. I had modify the CMakeTestCCompiler.cmake for solving cmake  test c/c++ compiler failed. At line of 61
 58 message("${CMAKE_BINARY_DIR}+++")
 59 message("test program+++++++${CMAKE_C_COMPILER_WORKS}")
 60   #set(CMAKE_C_COMPILER_WORKS ${CMAKE_C_COMPILER_WORKS})
 61   set(CMAKE_C_COMPILER_WORKS TRUE)

Thanks @arashrun for the log.
Just to confirm, you are running the following command from PowerShell and it returns that the path doesn't exist. Right?
cmd.exe /C "cd /D xxx”

Do you use instead of xxx a valid path, for example build if you are in the project directory?

Does the following command work for you?
E:\Espressif\tools\cmake\3.20.3\bin\cmake.exe --version

Please could you try build of example bundled in ESP-IDF?
cd E:\Espressif\frameworks\esp-idf-v4.4\examples\get-started\blink
idf.py build

Thanks @arashrun for the log.
Just to confirm, you are running the following command from PowerShell and it returns that the path doesn't exist. Right?
cmd.exe /C "cd /D xxx”

Do you use instead of xxx a valid path, for example build if you are in the project directory?

Yes, The second image is the result of insteaded. And cmake --version is work for me
PS E:\Espressif\frameworks\esp-idf-v4.4> E:\Espressif\tools\cmake\3.20.3\bin\cmake.exe --version
cmake version 3.20.3

CMake suite maintained and supported by Kitware (kitware.com/cmake).

Please could you try build of example bundled in ESP-IDF?
cd E:\Espressif\frameworks\esp-idf-v4.4\examples\get-started\blink
idf.py build

Hi, @georgik . That still not work for me. The log is under
blink.txt

Thank you for the test @arashrun .
I re-run the test in CMD and  PowerShell with ESP-IDF 4.4 installed on the same path on E: drive and it works on my Windows 11.
Is the E: drive regular HDD mounted to the system or is in network drive?
Please, could you also run chcp command and provide here output, just to make sure that code page is not causing a problem. It might not be connected to the problem, but better to double-check.
The test was performed on Windows with chcp = 437

@arashrun Thank you for additional information.
I re-run test case on Windows 11 with code page 936 on Azure. The build was without problem.
Also the command with cmd.exe mentioned above works without problem.
Can you check what is the filesystem on external drive E:? Is it NTFS?
My I ask you to test the installation on C:\ drive?

Thank you for confirmation @arashrun . I'm glad that ESP-IDF now works for you.
Could you share with us which registry change lead to the problem? We might be able to add integrity check for modified cmd value to idf-installer.

Sure. The registry is HKEY_LOCAL_MACHINE\Software\Microsoft\Command Processor\AutoRun\REG_SZ which i found on this link cmd microsoft. Just as i said, that's my fault. I set an not exists path as the registry value that cause the error...
Thank you for your patience @georgik

Thank you for providing details.


fix the path of config and weights in Running_pre_trained_models_from…

This PR will fix the path of config and weights in the initial cell of the Notebook

Thanks!


[PHP] Enable Mbstring

Mbstring is such a popular PHP extension that it is used everywhere and most libraries don't work without it. It can be compiled directly with PHP. The official Docker images of PHP include it.

@microsoft-github-policy-service agree
@samruddhikhandale I just push the test and the minor version. Hope I have done it well.


chore: switch styled-components .extend to styled()

Resolves #385
Impact: minor
Type: chore
.extend is deprecated and logging warnings
Testing
Only CartSummary and TextInput are affected. Verify that they still work and look as expected.

🚀 Preview deployed
Built with commit ddd6b4608faa5c76993c20d8519e955faf157188
https://deploy-preview-386--stoic-hodgkin-c0179e.netlify.com


Add Edge Chromium and interest links.

Updating the String for Edge Chromium

Solving issue #3816

@JohanFreelancer9  I did not realize it :P Thank you again! :)

@JohanFreelancer9 : Feel free to review & comment, in case there are any other interesting formatting details I may have missed in this document page.

#sign-off

@billmath Please confirm if this text is okay to merge. Thanks!!

#sign-off

@kenwith  @scanum can you take ownership of this one?


KiD refactor

This PR tries to make KiD closer to ClimaAtmos. That means:

more broadcasting
fields of tuples

I tried to simplify some of the rhs computations. I'm not fully settled on the state and aux structure, yet. For example whether 2M scheme should carry q_ice and q_sno in the Y state.
Anyway, I think the tests should be passing now and the examples should be running and producing some results. I think there were some examples where the results are different, so I still need to work on the PR. But I think this is a good time to start getting some feedback about it. So I'll be very grateful if you could take a look: @sajjadazimi , @nefrathenrici @edejong-caltech

The tests are passing, but there is a couple of cases in the CI that have different results: Box model, 1D collision with sedimentation, 1M with snow and ice and SB2006. I'll look into it. Hopefully this is the last stretch

Sorry I didn't get to review this PR, all of the changes are clear! Have you checked if this PR improves performance significantly?

I didn't see anything significant. Some simulations take longer now, others are slightly shorter. But most of the KiD simulations we have in the CI take ~2-3 minutes to run, so maybe it's hard to see anything?


Add tests for REST API

@sonufrienko Hey! I may be signing myself up some punishment here with testing, but I would like to claim this issue and create a test suite for the API, if you're accepting PR's?
Is there currently any testing going on in the code base? (Hadn't seen any from my brief check...) Is there a specific testing framework you would prefer to be used? I would probably go for some combination of Mocha/Jest.


It's already great, but there are still some questions, such as whether you can provide the closing events for session and stream.

Thanks for the feedback.
I agree. As mentioned in previous discussions, the API is not yet fully completed. Initially, my focus was on creating something functional.
Connection and stream handlers (i.e., SendStream and RecvStream) already have an implicit method for closing. In fact, stream and connection are "automatically" closed when the object is dropped.
Additionally, the "peer connection closed" event is already captured when awaiting on other connection events.
Having said that, I agree that having a convenient method to access those events would be beneficial. The underlying QUIC library (quinn) already provides such functionality, so it should be relatively easy to expose those features at the WebTransport layer.
I will prioritize working on this as soon as possible.

Place sendStream and receiveStream inside a structure with a unique u64 ID. The structure should also have a bool type to determine if it is a bidirectional stream. When the stream triggers the close method, only the ID of the closed stream needs to be provided to the user. The same applies to the session, where a sessionId of type u64 is set.

I believe in you and your abilities!

Thank you, it turns out that I didn't add the 'lib' directory to the environment variables. Previously, I only added the 'bin' directory.

Closing this issue, as

Close event on connection: https://github.com/BiagioFesta/wtransport/commit/d5f25fc468411b814e3157266859d1284841ffef
Stream IDs: https://github.com/BiagioFesta/wtransport/commit/f68f4403e310c3a748384c8f10eebf4505f277d2


acces control shows only MFA registration

the above screenshot shows 3 options. currently only one option is available.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ed580e9f-f99a-7e85-65f0-8a4304b9bf82
Version Independent ID: bd7ab1c4-856b-0e1c-c9d7-d6a5ea494467
Content: How to configure the multi-factor authentication registration policy in Azure Active Directory Identity Protection
Content Source: articles/active-directory/identity-protection/howto-mfa-policy.md
Service: active-directory
GitHub Login: @MarkusVi
Microsoft Alias: markvi

Hi @martinagrom, the other two options are grayed out.
So, yes, there is only one option available.

#please-close

Hi @martinagrom, neither Require multi-factor authentication nor Require password change do apply in this context.


Add scala docs to javadocs

This commit introduces a 3rd party plugin to co-locate
scala docs with java docs. https://github.com/lightbend/genjavadoc
Fixes: #1363

Use the following commands to test:
./gradlew elasticsearch-spark-20:javadoc
open spark/sql-20/build/docs/javadoc/index.html

./gradlew elasticsearch-spark-13:javadoc
open spark/sql-13/build/docs/javadoc/index.html

While reading some of the documentation I gotta say this sounds pretty gnarly. What's the main motivation of this over just using scaladoc? Certainly there's awkwardness here since we are presenting a Scala API as though it were a Java API? Not to mention we are adding to the already atrocious compile times of the Scala compiler by adding this Java source generation that is only ever used for JavaDoc generation but now runs on every compile.
This motivation also makes no sense to me:

This project’s goal is the creation of real Javadoc for Scala projects. While Scaladoc—the native API documentation format of Scala—has several benefits over Javadoc, Java programmers are very much used to having access to API documentation in a syntax matching their programming language of choice.

But, this isn't Java code, it's Scala? So why are they doing all this hackiness to make a Scala API more amenable to Java programmers? I mean, aren't the consumers of this API Scala developers, and thereby more inclined to want the more robust Scaladoc vs a watered-down and potentially inaccurate Javadoc representation of the API?

To add, my comments are mainly rooting in my ignorance of the Scala ecosystem. If this is a common pattern for documentation of APIs implemented in Scala then by all means, I'll defer to the Scala experts here on whether this is a good idea. I simply found this method of JavaDoc generation to be a bit odd and want to ensure we have strong motivations for introducing this since it carries some cost.

I mean, aren't the consumers of this API Scala developers

Nope. Any consumer that wants to use this library with Spark will need to use this API. That could Java or Scala devs. My guess is most are Java devs. If we think most are Scala devs we should look at publishing the scala docs jar.

If this is a common pattern for documentation of APIs implemented in Scala then by all means

Not sure if this is a common pattern, but the library is by from Lightbend  formerly known as Typesafe, which is well known.

Nope. Any consumer that wants to use this library with Spark will need to use this API. That could Java or Scala devs. My guess is most are Java devs. If we think most are Scala devs we should look at publishing the scala docs jar.

Gotcha, understood. Yeah, in that case I would agree then that having the API in Javadoc format would be most accessible. I assume while you were testing this the compile-time cost wasn't appreciable? If it is, there are perhaps things we could do, like make the compiler plugin conditional on the javadoc task being part of the task graph.

Nope. Any consumer that wants to use this library with Spark will need to use this API. That could Java or Scala devs. My guess is most are Java devs. If we think most are Scala devs we should look at publishing the scala docs jar.

We should probably avoid making these assumptions without any data. My gut feeling is that it's split 40/40/20 across Scala, Python, and Java (respectively), but I don't have any data to back this up other than past issues I can think of.

While reading some of the documentation I gotta say this sounds pretty gnarly.

From what I'm reading, it "emits structurally equivalent Java code for all Scala sources of a project, keeping the Scaladoc comments (with a few format adaptions)." Is this structural Java code created alongside the regular compiler class file output, or is this structural Java code an intermediary step? I'm assuming its the former, but I want us to be sure. Scala has some whacky language features in it that just do not translate well to structural Java code.

Nope. Any consumer that wants to use this library with Spark will need to use this API. That could Java or Scala devs.

Is the Java API documentation missing because it's nested under the Scala source? I want to make sure I'm understanding this clearly since I admittedly haven't spent much time looking into the Javadoc/Scaladoc problem for this part of the project.

I assume while you were testing this the compile-time cost wasn't appreciable?

The javadoc task doesn't get called until 'pack' , which should only happen during the release, and doesn't add any appreciable time. I also checked compileScala in case the new params impacted it in a funny way, which it does not.

Is this structural Java code created alongside the regular compiler class file output, or is this structural Java code an intermediary step?

I'm not sure I completely follow the question, but the plugin puts the generated java code in a defined directory.
$ls spark/sql-20/build/classes
scala

$ls spark/sql-20/build/generated
java    sources

Just to be certain, I diffed the generated artifacts and the only difference is the addition of the scala javadoc. (the left is with the changes here)

Is the Java API documentation missing because it's nested under the Scala source?

Where is the Java API documentation missing ?

My gut feeling is that it's split 40/40/20 across Scala, Python, and Java (respectively)

We should probably consider adding the proper scala docs jar to the things that published ?  However, I don't think this PR and that are mutually exclusive things.

The javadoc task doesn't get called until 'pack' , which should only happen during the release, and doesn't add any appreciable time. I also checked compileScala in case the new params impacted it in a funny way, which it does not.

Right, since this is implemented as a Scala compiler plugin those Java source files are generated whenever the Scala source is compiled, regardless of whether we're actually generated JavaDocs or not, so that's the bit I would expect to have a cost. I suspect one of the most costly parts of the Scala compile process is building the AST, which needs to be done regardless of this generation step so in way it makes sense that it doesn't add much time to the build. 👍

I'm not sure I completely follow the question, but the plugin puts the generated java code in a defined directory.

Ok cool, this was my major paranoia. I was mostly worried that the compiler plugin was taking the scala source, turning it into java source, and then converting the resulting java source into byte code/class files. But it sounds like the scala source still compiles to byte code and class files directly, with the added generation of some Java files for use in the javadoc process.

@jbaiera - should be ready for another look. thanks!


Implement token autorefresh

Motivation

Bring the (azure-communication-)common functionality on par with .NET, JS, and Java client libraries

Implementation
This PR:

contains an implementation of proactive token refreshing that is already present in .NET, JS, and Java client libraries
addresses the problem that if the token returned by token_refresher callback (implemented by Contoso) is soon to expire or expired, the AutoRefreshTokenCredential would keep looping constantly trying to fetch a new token. To prevent this, we implemented a back-off mechanism for the case the token is soon-to-expire and throw an exception if the user fails to provide a non-expired token via the token_refresher. We're fixing this particular problem in other SDKs too (see e.g. JS/TS). This approach was discussed and recommended by the Azure Board during an SDK API review.

Merging notes

[x] Do not merge before https://github.com/Azure/azure-sdk-for-python/pull/21777 gets merged. If there are any timezone-related conflicts, resolve them  in favor of #21777.

TODOs

[x] remove options bag according to the Python guidelines - Communication is the only SDK that has an *options.py file - we should remove it
[x] enabled and fix existing tests
[x] implement the autorefresh logic for the sync version

[x] add tests
[x] get the naming right (shorten the param names)
[x] reflect the datetime vs utc fix in utils.py in #21777

[x] implement the autorefresh logic for the async version

[x] add tests

[x] make sure tests are passing for python 2.*
[x] make the autrefresh interval configurable
[x] replicate the logic across the _shared folders in all Communication packages

hey @AikoBB @rosebyte @iwonapytel can I pls get some initial feedback on this?

API changes have been detected in azure-communication-chat. You can review API changes here

API changes have been detected in azure-communication-chat. You can review API changes here

API changes have been detected in azure-communication-chat. You can review API changes here
API changes
- class azure.communication.chat.CommunicationTokenCredential:
+ class azure.communication.chat.CommunicationTokenCredential: implements ContextManager
-             token_refresher = ...,
-             **kwargs
+             refresh_proactively: Optional[bool] = ...,
+             token_refresher: Optional[callable] = ...,
+             **kwargs: Any
-             token_refresher = ...,
+             refresh_proactively: Optional[bool] = ...,

@AikoBB can you please remove the following files?
\communication\azure-communication-sms\azure\communication\sms\_shared\user_token_refresh_options.py
\communication\azure-communication-phonenumbers\azure\communication\phonenumbers\_shared\user_token_refresh_options.py
\communication\azure-communication-networktraversal\azure\communication\networktraversal\_shared\user_token_refresh_options.py
\communication\azure-communication-chat\azure\communication\chat\_shared\user_token_refresh_options.py

plus, we need to fix this:

it's probably caused by too complex type or the multiline comment

API changes have been detected in azure-communication-chat. You can review API changes here
API changes
+     cvar properties = {}
- class azure.communication.chat.CommunicationTokenCredential:
+ class azure.communication.chat.CommunicationTokenCredential: implements ContextManager
-             token_refresher = ...,
-             **kwargs
+             refresh_proactively: Optional[bool] = ...,
+             **kwargs: Any
-             token_refresher = ...,
+             refresh_proactively: Optional[bool] = ...,

API changes have been detected in azure-communication-chat. You can review API changes here

API changes have been detected in azure-communication-chat. You can review API changes here
API changes
- class azure.communication.chat.CommunicationTokenCredential:
+ class azure.communication.chat.CommunicationTokenCredential: implements ContextManager
-             token_refresher = ...,
-             **kwargs
+             refresh_proactively: Optional[bool] = ...,
+             token_refresher: Optional[callable] = ...,
+             **kwargs: Any
-             token_refresher = ...,
+             refresh_proactively: Optional[bool] = ...,

API changes have been detected in azure-communication-chat. You can review API changes here
API changes
- class azure.communication.chat.CommunicationTokenCredential:
+ class azure.communication.chat.CommunicationTokenCredential: implements ContextManager
-             token_refresher = ...,
-             **kwargs
+             refresh_proactively: Optional[bool] = ...,
+             token_refresher: Optional[callable] = ...,
+             **kwargs: Any
-             token_refresher = ...,
+             refresh_proactively: Optional[bool] = ...,
+             token_refresher: Optional[callable] = ...,

API changes have been detected in azure-communication-chat. You can review API changes here

/azp run python - azure-communication-chat - tests

API changes have been detected in azure-communication-chat. You can review API changes here

/azp run python - azure-communication-chat - tests

API change check for azure-communication-identity
API changes are not detected in this pull request for azure-communication-identity

API change check for azure-communication-chat
API changes have been detected in azure-communication-chat. You can review API changes here

API change check for azure-communication-sms
API changes are not detected in this pull request for azure-communication-sms

API change check for azure-communication-phonenumbers
API changes are not detected in this pull request for azure-communication-phonenumbers

API change check for azure-communication-networktraversal
API changes are not detected in this pull request for azure-communication-networktraversal

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-communication-chat
azure-communication-identity


This project has a meaningful contribution to society

We are in dire and immediate need of innovation in the OS and wider Software Development platform space and this project does not aim to improve status quo.
However, working on it is probably a lot of fun + it contributes to the developers experience in said field and as they are a member of society, it thereby also contributes to society.
Hi reddit

I opened a pull request.
Am I thus making a contribution to a contribution to society?

How long can this endless contribution chain go?

Heya, thanks for the mood brightening issue :D
I'm going to have to close this still though, as it isn't technically on topic, but thank you none the less.

Keep at it Jake! Love your work

I opened a pull request.
Am I thus making a contribution to a contribution to society?

How long can this endless contribution chain go?

Everybody knows readme typo fixes are the biggest contribution to society you can make xD

IDK, does society even read anymore?

Clearly you have no meaningful contribution to society! :D
Have a good day, and remember to post real issues on the repo! :)

Clearly, you have no meaningful contribution to society! :D
Have a good day, and remember to post real issues on the repo! :)

I think you may have shared this in the wrong issue btw, the original one is in a different thread, I believe this one is a parody :D but thanks for your kind support

ah i feel stupid lol

hi

hi

After all, that guys issue made a lot of people laugh pretty hard.
Keep up the good work Jake!


Literal add_on: ["ddev/ddev-redis-commander"] shouldn't be?

Isn't this wrong? The add_on value shouldn't be a literal like this should it?
      matrix:
        ddev_version: [ stable, HEAD ]
        add_on: ["ddev/ddev-redis-commander"]

See https://github.com/ddev/github-action-add-on-test/blob/b27b22c2f2b45666036959e7a813c08a4b9e2028/.github/workflows/single-add-on-test.yml#L16-L22

I don't understand what you mean by "literal" (my english is too bad :) and my google search wasn't very helpful).
Is it about using a matrix value whereas there is only one value ?
But maybe it's about the double quote ?
Or something else ?
By the way, I just removed this single add-on test action as the multiple add-ons test just do the same but with more add-on.

I just didn't understand what this was. It's a test of this github action, and I saw it and thought it was a leftover copy-paste problem from something else.
I was just wrong. Closing.

A question though... you're using ddev-redis-commander for this test. It should not successfully install these days without ddev-redis. Is the test actually working right?

Interesting,
here, were just calling exactly the same test as in the add-on repo.
And, as we can see, the test of the add-on does not fail either: https://github.com/ddev/ddev-redis-commander/actions/runs/5960663200 whereas we do not install the redis add-on at all.
I think the test itself is wrong:
By doing URL=$(ddev describe -j ${PROJNAME} | jq -r .raw.services.\"redis-commander\".http_url) , URL is null .
And then curl -s --fail ${URL} | grep "<title>Redis Commander: Home"does not throw any error.
I will create an issue in the ddev/ddev-redis-commander repo.

After reading in more detail: it's normal for the tests to pass because we're doing a ddev get ddev/ddev-redis in setup. : it is normal that tests pass because we are doing a ddev get ddev/ddev-redis in the setup.
https://github.com/ddev/ddev-redis-commander/blob/main/tests/test.bats#L12

Sorry for the false alarm! Thanks for chasing it down.


HTML report does not render code correctly

Describe the bug

To Reproduce
Steps to reproduce the behavior:

1.js as same with 2.js

const axios = require('axios')

function test ({ code, message, _, response }) => { // 服务端响应为非 200 的场景, 都到 catch 这里
  console.log(`hello !@#LK><M>
\n
          <M`)
  console.log('hello !@#LK><M> \n <M')

  return axios(option).then((response) => {
    const { code, success, message, data } = response.data || {}
    const ok = (!!success && code === '200')
    return ok
  })
}

run command npx jscpd -r html ./*.js

Expected behavior
render code correctly
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS:  linux
OS Version alpine 3.16.2
NodeJS Version v16.17.1
jscpd version 3.5.1

Additional context
render clone.fragment as html, may fix this bug.
ref:  https://vuejs.org/guide/essentials/template-syntax.html#raw-html

I confirm the problem. Plus, using npx<EMAIL_ADDRESS>does not fix it, surely because the @jscpd/html-reporter package is installed to the latest version. I did not find any way to workaround this.
Here is the change I suspect it introduces the bug: https://github.com/kucherenko/jscpd/commit/5dc30bf30820594fb5488e42c7aa33a6d0ea326d
cc @kucherenko @zhaoyi


pandas'  becomes either NULL or NaN when inserted into ClickHouse table

Describe the bug
pandas' <NA> turns to

NULL when inserted into Nullable(UIntX) or Nullable(IntX) column
NaN when inserted into Nullable(FloatX)

Steps to reproduce

run clickhouse server
run code example
check what's been inserted into ClickHouse table

Expected behaviour
<NA> becoming the same value for both Int and Float nullable columns (I'd prefer NULL)
Code example
import pandas as pd
from clickhouse_connect import get_client

def main():
    client = get_client(host="localhost", database="default")
    client.command("DROP TABLE IF EXISTS insert_df_test")
    client.command(
        """CREATE TABLE insert_df_test
        (
            row_id UInt64,
            uint64_col Nullable(UInt64),
            int64_col Nullable(Int64),
            float64_col Nullable(Float64)
        )
        ENGINE MergeTree
        ORDER BY row_id
        """
    )
    df = pd.DataFrame(
        [[0, 1, -1, 1.0], [1, None, None, None]],
        columns=["row_id", "uint64_col", "int64_col", "float64_col"],
    )
    df.uint64_col = df.uint64_col.astype("Int64")
    df.int64_col = df.int64_col.astype("Int64")
    df.float64_col = df.float64_col.astype("Float64")
    client.insert_df("insert_df_test", df)

if __name__ == '__main__':
    main()

Configuration
Environment

clickhouse-connect version: 0.8.3
Python version: 3.11.8
Operating system: Win/MacOs

ClickHouse server

ClickHouse Server version: <IP_ADDRESS>

This is expected behavior.  NaN is a valid float in Pandas and ClickHouse, so it would be breaking changing to insert NULL instead.  If you want to actually insert a null, you can convert your pandas column to an object column and replace NaN with None before inserting the dataframe.

In fact, your code is probably doing the conversion, not clickhouse_connect:
 df.float64_col = df.float64_col.astype("Float64")

Okay, I was wrong.  This seems to be related to recent Pandas types.  Let me see if there's a way to determine the difference between  and NaN

This should be fixed in 0.8.4.  Pandas apparently just treats np.nan/float NaN as an  regardless


code is not working

react-authorize is not installing and no function is calling..!

This project is under development
Sent from my iPhone

On Jul 4, 2018, at 6:44 AM, Meenaprasad Yalla<EMAIL_ADDRESS>wrote:
react-authorize is not installing and no function is calling..!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Can u please tell me how to call the Authorize UI from react UI
On Wed 4 Jul, 2018, 22:47 Rayed Bajwa<EMAIL_ADDRESS>wrote:

This project is under development
Sent from my iPhone

On Jul 4, 2018, at 6:44 AM, Meenaprasad Yalla<EMAIL_ADDRESS>wrote:
react-authorize is not installing and no function is calling..!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rayedbajwa/react-authorize-net/issues/1#issuecomment-402529623,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdNecSXdP1cutS2NwVKmMTY_BT_ItReeks5uDPikgaJpZM4VCXbt
.

Just use redux saga to send a request to authorize api
Sent from my iPhone

On Jul 4, 2018, at 1:22 PM, Meenaprasad Yalla<EMAIL_ADDRESS>wrote:
Can u please tell me how to call the Authorize UI from react UI
On Wed 4 Jul, 2018, 22:47 Rayed Bajwa<EMAIL_ADDRESS>wrote:

This project is under development
Sent from my iPhone

On Jul 4, 2018, at 6:44 AM, Meenaprasad Yalla<EMAIL_ADDRESS>wrote:
react-authorize is not installing and no function is calling..!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rayedbajwa/react-authorize-net/issues/1#issuecomment-402529623,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdNecSXdP1cutS2NwVKmMTY_BT_ItReeks5uDPikgaJpZM4VCXbt
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


Merge Develop

I also added a new simplified connection state interface for NettyStreamingService, and some string literals to not implemented exceptions

This looks good to me @walec51

3 small remarks, everything else look ok to me

Thank you


how to change loglevel so i can enable or disbale some log?

Use zerolog as usual: zerolog.SetGlobalLevel(zerolog.InfoLevel) where zerolog.InfoLevel is the minimum level to log.
https://go.dev/play/p/p3l4xpRe_C0
https://pkg.go.dev/github.com/rs/zerolog#SetGlobalLevel
https://go.dev/play/p/xWCGpd0lvzj

I think this answered the question, closing.


[fontconfig] build failure on windows 10

Host Environment

OS: Windows 10
Compiler: 2021-07-26-9425cf5f512f242c0bcbabac31f08832825aee81
vcpkg repo revision: 5742e878fc71b4fcb9c019b50f1f887f22db58df

To Reproduce
Steps to reproduce the behavior:
./vcpkg install fontconfig
Failure logs
Powershell logs:
Starting package 15/15: fontconfig:x64-windows
Building package fontconfig[core]:x64-windows...
-- Using C:/Users/Arjan/source/repos/performous/vcpkg/downloads/fontconfig-fontconfig-844d8709a1f3ecab45015b24b72dd775c13b2421.tar.gz
-- Cleaning sources at C:/Users/Arjan/source/repos/performous/vcpkg/buildtrees/fontconfig/src/75c13b2421-7d202e6ff4.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/Users/Arjan/source/repos/performous/vcpkg/downloads/fontconfig-fontconfig-844d8709a1f3ecab45015b24b72dd775c13b2421.tar.gz
-- Applying patch remove_tests.patch
-- Applying patch build.patch
-- Applying patch build2.patch
-- Applying patch disable-install-data.patch
-- Applying patch macos_arm_fccache.patch
-- Applying patch fix_def_dll_name.patch
-- Using source at C:/Users/Arjan/source/repos/performous/vcpkg/buildtrees/fontconfig/src/75c13b2421-7d202e6ff4.clean
-- Found external ninja('1.10.2').
-- Getting CMake variables for x64-windows
-- Using msys root at C:/Users/Arjan/source/repos/performous/vcpkg/downloads/tools/msys2/2f5e2150b81fcd06
-- Using msys root at C:/Users/Arjan/source/repos/performous/vcpkg/downloads/tools/msys2/aa5af7b2aa7e90e8
-- Generating configure for x64-windows
-- Finished generating configure for x64-windows
-- Configuring x64-windows-dbg
-- Configuring x64-windows-rel
-- Using msys root at C:/Users/Arjan/source/repos/performous/vcpkg/downloads/tools/msys2/aaafe87dcead272e
-- Building x64-windows-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:155 (message):
    Command failed: C:/Users/Arjan/source/repos/performous/vcpkg/downloads/tools/msys2/aaafe87dcead272e/usr/bin/make.exe -j 33 --trace -f Makefile all
    Working Directory: C:/Users/Arjan/source/repos/performous/vcpkg/buildtrees/fontconfig/x64-windows-dbg
    See logs for more information:
      C:\Users\Arjan\source\repos\performous\vcpkg\buildtrees\fontconfig\build-x64-windows-dbg-out.log
      C:\Users\Arjan\source\repos\performous\vcpkg\buildtrees\fontconfig\build-x64-windows-dbg-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_make.cmake:191 (vcpkg_execute_build_process)
  scripts/cmake/vcpkg_install_make.cmake:26 (vcpkg_build_make)
  ports/fontconfig/portfile.cmake:47 (vcpkg_install_make)
  scripts/ports.cmake:141 (include)

Error: Building package fontconfig:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: fontconfig:x64-windows
  Vcpkg version: 2021-07-26-9425cf5f512f242c0bcbabac31f08832825aee81

build-x64-windows-dbg-err.log
cl : Command line warning D9002 : ignoring unknown option '-Xcompiler'
cl : Command line warning D9002 : ignoring unknown option '-Xcompiler'
Microsoft (R) C/C++ Optimizing Compiler Version 19.29.30038.1 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

fcobjshash.gperf.h
Microsoft (R) C/C++ Optimizing Compiler Version 19.29.30038.1 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

fcobjshash.gperf.h
cl : Command line warning D9002 : ignoring unknown option '-Xcompiler'
/bin/sh: line 25: /usr/bin/xgettext: No such file or directory
/bin/sh: line 27: /usr/bin/xgettext: No such file or directory
make[3]: *** [Makefile:247: fontconfig.pot-update] Error 127
make[2]: *** [Makefile:314: fontconfig.pot] Error 2
make[1]: *** [Makefile:601: all-recursive] Error 1
make: *** [Makefile:485: all] Error 2

build-x64-windows-dbg-out.log
Additional context
This still worked on a863c84812089836a3c0f2f215ab3e2579fc8acf every commit after this it fails with the same logs provided above.
Rerunning the .\bootstrap-vcpkg.bat script and rebuilding doesn't solve this sadly

Can you please update vcpkg to latest and try again?

@Baklap4 ,Thanks for posting this issue,please updaye your vcpkg to latest

It seems the latest master resolves this problem. When was this problem resolved? I did try a couple of times since i've noticed this (before filing this issue)

@Baklap4 Fixed by #19361.


[CI] Testing ursabot status push

@ursabot --help

@ursabot build

@ursabot build

Seems like it's working! =)

@ursabot build

Ehh, just testing that :)

@ursabot build

The requests are recorded:

And the statuses are updated.


Using FP16,YoloX,softnms got RuntimeError: expected scalar type Float but found Half

File "/home/lsc/mmdet-2.20/mmdet/models/detectors/base.py", line 174, in forward
return self.forward_test(img, img_metas, **kwargs)
File "/home/lsc/mmdet-2.20/mmdet/models/detectors/base.py", line 147, in forward_test
return self.simple_test(imgs[0], img_metas[0], **kwargs)
File "/home/lsc/mmdet-2.20/mmdet/models/detectors/single_stage.py", line 102, in simple_test
results_list = self.bbox_head.simple_test(
File "/home/lsc/mmdet-2.20/mmdet/models/dense_heads/base_dense_head.py", line 360, in simple_test
return self.simple_test_bboxes(feats, img_metas, rescale=rescale)
File "/home/lsc/mmdet-2.20/mmdet/models/dense_heads/dense_test_mixins.py", line 37, in simple_test_bboxes
results_list = self.get_bboxes(
File "/home/lsc/mmdet-2.20/mmdet/models/dense_heads/yolox_head.py", line 294, in get_bboxes
self._bboxes_nms(cls_scores, bboxes, score_factor, cfg))
File "/home/lsc/mmdet-2.20/mmdet/models/dense_heads/yolox_head.py", line 321, in bboxes_nms
dets, keep = batched_nms(bboxes, scores, labels, cfg.nms)
File "/home/lsc/anaconda3/envs/mmdet/lib/python3.8/site-packages/mmcv/ops/nms.py", line 340, in batched_nms
dets, keep = nms_op(boxes_for_nms[mask], scores[mask], **nms_cfg)
File "/home/lsc/anaconda3/envs/mmdet/lib/python3.8/site-packages/mmcv/utils/misc.py", line 340, in new_func
output = old_func(*args, **kwargs)
File "/home/lsc/anaconda3/envs/mmdet/lib/python3.8/site-packages/mmcv/ops/nms.py", line 245, in soft_nms
dets, inds = SoftNMSop.apply(boxes.cpu(), scores.cpu(),
File "/home/lsc/anaconda3/envs/mmdet/lib/python3.8/site-packages/mmcv/ops/nms.py", line 88, in forward
inds = ext_module.softnms(
RuntimeError: expected scalar type Float but found Half

Thanks for your report! We will check it.

Hi, do you have any updates? I have the same issue.

Could you please provide the environment information, pkg information, and command to reproduce this error ?

i still did not get the answer , i face the same issue while training my model on centriapetal_net,
with fp16 = dict(loss_scale='dynamic')
any solution for that?

I solve the problem by not using the YOLOX in mmdet, btw it's not mmdet's fault

ng the YOLOX in mmdet, btw it's not mmdet's fault

but i am not using yolox as a training model , i used centriapetalNet

Hello @alaa-shubbak. Thanks for your error report. This error should be fixed after mmdet 2.23. Could you check the version of mmdet you used?
Make sure that your mmdet version is greater than or equal to 2.23.0. If the error still occurs, you can open a new issue and provide the error report, config, and environment in the new issue. We will fix the error as soon as possible.


Unpin/pin in cache replacer

For cache policy like lru.rs and lru_k.rs, we can use fine-grained locks instead of one big lock to lock it. If we use fine-grained locks (at least after getting the value from cache, we don't need to hold its lock), we should add unpin/pin in lru.rs and lru_k.rs, in order to prevent eviction of the files which are being used.

#50 partially solve this problem, so #50 won't close this issue.

#50's pin/unpin strategy relies on every put following by a get.
And I still think #50's pin/unpin may have problem? Actually it should unpin after all the data is consumed from receiver (not sure)? but now it unpin at the end of get_data_from_cache. So this PR should not close this issue, we need more tests to validate correctness.


Call for maintainers for charts with a single OWNER

Hello,
As maintaining this repository is growing harder by the day, this is a call for maintainers!
This issue is about 'recruiting' maintainers for charts that only have a single maintainers. The list of charts can be found at the end of this message, along with the existing maintainer of that chart.
If you wish to be added as a maintainer to one of the charts in this issue, please open a PR to add yourself to the OWNERS file.
In addition, maintainers in Chart.yaml and OWNERS should match.
We would suggest to include in the PR references to past contributions to the chart you are applying for.
If you are a maintainer and know someone who fits this (and is interested) - feel free to approach them!
Once a PR exists, please add a comment referencing this issue, and ping one of the maintainers to get added as a read-only user to the helm/charts repository.
Thanks in advance to everyone who applies! We need your help.
All new OWNERS should be familiar with the following documents:
https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md
https://github.com/helm/charts/blob/master/CONTRIBUTING.md
https://helm.sh/docs/chart_best_practices/
Here is the list of charts and maintainers:
incubator/azuremonitor-containers
@vishiy
incubator/chartmuseum
@jdolitsky
incubator/druid
@maver1ck
incubator/gogs
@obeyler
incubator/kafka
@benjigoldberg
incubator/schema-registry
@benjigoldberg
incubator/hoverfly
@tommysitu
incubator/buzzfeed-sso
@darioblanco
incubator/rundeck
@dwardu89
stable/aerospike
@okgolove
stable/apm-server
@mumoshu
stable/auditbeat
@cpanato
stable/bookstack
@verwilst
stable/centrifugo
@cpanato
stable/cerebro
@davidkarlsen
stable/chaoskube
@linki
stable/chronograf
@jackzampolin
stable/cockroachdb
@a-robinson
stable/dex
@desaintmartin
stable/distributed-jmeter
@pedrocesar-ti
stable/drone
@christian-roggia
stable/efs-provisioner
@hareku
stable/graphite
@monotek
stable/helm-exporter
@sstarcher
stable/home-assistant
@billimek
stable/horovod
@cheyang
stable/influxdb
@jackzampolin
stable/jaeger-operator
@cpanato
stable/k8s-spot-rescheduler
@komljen
stable/kube-state-metrics
@tariq1890
stable/magic-ip-address
@mumoshu
stable/magic-namespace
@krancour
stable/nextcloud
@chrisingenhaag
stable/nfs-server-provisioner
@kiall
stable/node-problem-detector
@max-rocket-internet
stable/node-red
@billimek
stable/oauth2-proxy
@miouge1
stable/openebs
@kmova
stable/openiban
@verwilst
stable/prisma
@giacomoguiulfo
stable/prometheus-mongodb-exporter
@steven-sheehy
stable/prometheus-snmp-exporter
@miouge1
stable/redis-ha
@ssalaues
stable/satisfy
@anapsix
stable/schema-registry-ui
@cristian04
stable/sematext-docker-agent
@komljen
stable/sonarqube
@rjkernick
stable/sonatype-nexus
@rjkernick
stable/spark-history-server
@yuchaoran2011
stable/tensorflow-notebook
@cheyang
stable/tensorflow-serving
@cheyang
stable/vault-operator
@mlaccetti
stable/velero
@hectorj2f
stable/graylog
@KongZ
stable/prometheus-nats-exporter
@okgolove
stable/clamav
@zakkg3
stable/sentry
@okgolove
stable/goldpinger
@okgolove

@maorfr
My stable/graphite chart is already deprecated and moved to:
https://github.com/kiwigrid/helm-charts/tree/master/charts/graphite
We also have 2 maintainers now :-)

Sorry, this question is probably way out of date since this repo is no longer under the Kubernetes org, but is it ok these days to have an OWNER on a chart that isn't a member of the Kubernetes github organization?

I'm the sole owner of stable/spark-history-server. I have a pending PR to add my colleague who is familiar with the chart as a co-owner. I need someone to /lgtm my PR for it to be merged.

@yuchaoran2011 would you be able to create a PR with only the addition of @skonto?
then you can pair on all pending PRs...

Thanks @maorfr! That answers my question but creates the new question of how someone gets added as a collaborator. That can be resolved on #13889, though.

I can help on stable/prometheus-nats-exporter, have several commits on nats-exporter itself as well although I'm not part of the org.

@caarlos0 hello! Feel free to add you to OWNERS file.

should the CI have this closed?

/reopen

oh, on #14530 the description says fixes #13867 (comment)...

Oh yeah! That was my PR :/. Sorry

I am the maintainer of incubator/buzzfeed-sso. Lately, we had several MRs from the community, but I can't merge them as I am not a trusted collaborator. I have created an issue to become one here https://github.com/helm/charts/issues/14682 .
Even if I am quite active with the development and testing of that chart, anybody else who wants to help and take ownership is definitely welcomed :)

[stable/minecraft] chart doesn't even have a single owner.  I'm happy to pitch-in on this one.  Is anyone else interested to co-own the chart? @gtaylor? @itzg ?

@billimek, since I don’t actively use Helm I’d be happy for you to take point on https://github.com/helm/charts/tree/master/stable/minecraft and would be good with co-owning since I can help keep the chart lockstep updated with the upstream image.

I have added myself as an OWNER to stable/hubot (I should have done it when I created the chart :facepalm:). It is currently stuck until approved by a helm member.
https://github.com/helm/charts/pull/14784

Fixing a huge bug in dex and adding myself as a maintainer - https://github.com/helm/charts/pull/15050

stable/consul seems to have only one maintainer as well... cc/  @lachie83

I’d love someone, especially someone who runs on GCE, to join me on stable/cluster-autoscaler :)

Is it possible to become a repo wide maintainer? I would only use this power for simple changes like https://github.com/helm/charts/pull/15954
I have generic helm knowledge more so than chart specific knowledge. I've made numerous contributions to various helm charts.

@maorfr I've been helping out on a number of issues/charts, most prominently stable/redis-ha as of late.
I'd like to be a contributor, but I need to be added to the helm approved list of maintainers.
Do I need to go through that process first, or do I made the suggestion here?
@ssalaues can probably attest for the recent updates in that chart.

@DandyDeveloper go ahead and submit a PR. once it is approved by the maintainers of the chart, we'll get you added as a trusted collaborator. thanks!

Can you look for this ticket?

https://github.com/helm/charts/issues/10768

I volunteer to help w/ https://github.com/helm/charts/tree/master/stable/prometheus-cloudwatch-exporter
I'll submit a PR adding myself to owners.

I volunteer to help w/ https://github.com/helm/charts/tree/master/stable/prometheus-cloudwatch-exporter
I'll submit a PR adding myself to owners.

@maorfr https://github.com/helm/charts/pull/18093 looks like I need an invite to the helm org.

@asherf
If helm members do not respond within a week, please find them / directly message them on kubernetes slack channel.

I'd like to ask the same thing @r0fls asked in https://github.com/helm/charts/issues/13867#issuecomment-516476436:

Is it possible to become a repo wide maintainer? I would only use this power for simple changes like #15954
I have generic helm knowledge more so than chart specific knowledge. I've made numerous contributions to various helm charts.

I wanted to get some Prometheus changes merged in but PRs have not been merged for while due to very few OWNERS.
I do work extensively with Helm and I believe I can adequately review changes that are not very app-specific. If somebody modifies some intense config for a chart containing an app I never used I am clearly not the person to review. But anything lower than that I think I could do.

Any news for https://github.com/helm/charts/issues/10768?

Please do not hijack this thread as well.


Done

also you can now remove my scopeio_pointer_emard.vhd

old code

Done

On 5/25/19, Miguel Angel<EMAIL_ADDRESS>wrote:

I added a new architecture into bram.vhd with your
block

ram,

and

specified

that architecture into scopeio. Every thing seems
to
be

fine

here.

On Sat, May 25, 2019 at 12:38 PM emard

<EMAIL_ADDRESS>

wrote:

Yes of course ULX3S has/can have ESP32 wifi chip

and it can have web interface with javascript and
also

access to the serial port so your web application
can
be

running over wifi

very useful if such scope is connected to high
voltage

and

students don't want to get wired there

On 5/25/19, D EMARD<EMAIL_ADDRESS>wrote:

https://github.com/hdl4fpga/hdl4fpga/blob/51385412843509deb02e3477c85a58f0c473998b/library/scope/scopeio.vhd#L506
if trigger_freeze is equial '1' trigger does not work. it keeps the last
trigger and doesn't capture new data. One shot trigger functionality.
if trigger_freeze is equal '0' it will trigger anyway if the trigger_level
does not shoot. It is a free running. I tested those functionalities and
they were working.
I will tested again
On Tue, May 28, 2019 at 2:02 PM emard<EMAIL_ADDRESS>wrote:

OK I tried suggested workaround at downsampler
but it doesn't work for me ,
same DTC pattern appears like before when I changed this:
It seems that with this and input_ena, it's not reacting to trigger -
I placed trigger level in the middle of signal range but no effect
downsampler_e : entity hdl4fpga.scopeio_downsampler
port map (
--factor => hz_scale,
factor => "1111", -- FIXME temporary workaround
On 5/28/19, D EMARD<EMAIL_ADDRESS>wrote:

HI
Aaaa only at downsampler I must hardcode "1111" not to everywhere else.
Not a rush with internet till thursday, it's ok more rarely from
university
On 5/28/19, Miguel Angel<EMAIL_ADDRESS>wrote:

First ... I'm having problem with my Internet connection at home, so I
can
only answer from the university. According to my provider, it will be
solved on Thursday
input_ena is there to tell scopeio when the sample is ready. It is
used
for example : for spi ADCs to feed the spi_clk as *input_clk *but to
capture the sample when all the bits are shifted in.
If a parallel ADC is used it should always be enable ('1').
Instead of setting hz_scale all '1' replace hz_scale by b"1111" here

https://github.com/hdl4fpga/hdl4fpga/blob/51385412843509deb02e3477c85a58f0c473998b/library/scope/scopeio.vhd#L474

factor => b"1111",
As hz_scale controls other thing that can be confusing.
I will check things now ... but those are thing that can be tested if
you
want.
On Tue, May 28, 2019 at 10:33 AM emard<EMAIL_ADDRESS>wrote:

HI
I hardcoded hz_scale to (others => '1')
but problem exists.
So lets say I routed btn1 to ADC input.
when I press btn1 and don't use input_ena, trace
jumps to some high value and when I release btn0
trace is immediately back to 0.
With input_ena used and hz_scale = "1111"
when I press btn1, a duty-cycle pattern appears
rising slowly from 0% DTC to 100% over maybe 10 seconds
and when I release again counter DTC falling from 100%
to 0% again for 10 seconds. Something must be wrong there
On 5/27/19, D EMARD<EMAIL_ADDRESS>wrote:

Aaaaa, I need to fix hz scale hardcoded to "1111" as workaround.
Also I understdant vertical is not finished but it draws fine numbers
so I guess the hardest part is already working.
prj_run is some TCL script inside of diamond
It is not called by a linux shell directly but passed to standard
input
of
"diamondc" commandline exe that is supposed to know where is this
prj_run
and how to execute. All "sh" in diamond scripting must be replaced by
"bash"
I have a sed auto-replacement script there under
"diamond-fix-scripts"
directory
On 5/27/19, Miguel Angel<EMAIL_ADDRESS>wrote:

It's b"1111" not x"1111"

On Mon, May 27, 2019 at 11:42 AM emard<EMAIL_ADDRESS>wrote:

but in that case horizontal scale is fixed,

not changeable (currently I'm able to zoom in time,

horizontally)

On 5/27/19, Miguel Angel<EMAIL_ADDRESS>wrote:

send all ones to the horizontal scale ... it should be working

On Mon, May 27, 2019, 10:43 emard<EMAIL_ADDRESS>wrote:

HI

I have almost done ULX3S ADC MAX11123 working

I think scopeio.vhd input_ena is not working properly.

I must clock ADC core with 62.5 or 75 MHz

that is also input clock

but actual sample rate going out of ADC is currently

about 120-140 kHz, so I'd like to use input_ena

to scopeio to reduce data rate bit it seems not to

work - can you check?

On 5/26/19, Miguel Angel<EMAIL_ADDRESS>wrote:

On Sun, May 26, 2019 at 2:59 PM emard
<EMAIL_ADDRESS>

wrote:

it may be even nothing, a same logic but differently

arranged may randomize LUTusage by few %

I agree !

On 5/26/19, Miguel Angel<EMAIL_ADDRESS>wrote:

On ECP3 versa kit

pass_thru_a => true or false,

pass_thru_b => true or false

don't change LUTs consumption

Just to notice

Diamond version <IP_ADDRESS>

I haven't tried ulx3s yet

On Sun, May 26, 2019 at 2:01 PM emard <
<EMAIL_ADDRESS>

wrote:

My diamond 3.7 compiled it and it works.

the clock is generated by ecppll tools from trellis,

not diamond's original. maybe should we generate

the clock originally by diamond

for 1280x768 we need 375,75,25 MHz all phase shift 0

On 5/26/19, D EMARD<EMAIL_ADDRESS>wrote:

I will regenerate GUI project file for diamond (was
using

commandline)

on my bram, there's option pass_thru, some architectures
are

better

enabling it, some disabling it and some don't care

On 5/26/19, Miguel Angel<EMAIL_ADDRESS>wrote:

I was curios about how hld4fpga's block ram description
worked

compared

to bram_true2p_2clk, and I found this:

bram_true2p_2clk:

Device utilization summary:

PIO (prelim) 83/332 25% used

83/295 28% bonded

IOLOGIC 14/328 4% used

SLICE 1647/16632 9% used

GSR 1/1 100% used

EBR 7/72 9% used

PLL 1/4 25% used

MULT18 1/64 1% used

hdl4fpga

Device utilization summary:

PIO (prelim) 83/332 25% used

83/295 28% bonded

IOLOGIC 14/328 4% used

SLICE 1616/16632 9% used

GSR 1/1 100% used

EBR 7/72 9% used

PLL 1/4 25% used

MULT18 1/64 1% used

Theese data are for ecp3versa kit. It seems as the
brams'

architecture

of

bram_true2p_2clk misses to absorb the registers.

I might have been I've implemented something wrong ...

https://github.com/hdl4fpga/hdl4fpga/blob/071a493810cd73a0b4ef79acd83719c87eb560da/library/common/bram.vhd#L50

I still think it's better to use bram_true2p_2clk as it
is
more

tested

than

the original for tools to work well. It is only a
curiosity.

I tried to compile your projects to see how they
behaved
but
I

got

these

error with the make file

echo prj_project open ulx3s_12f_scope.ldf ; prj_run
Export

-task

Bitgen

|

/bin/sh: -c: line 1: syntax error: unexpected end of
file

make: *** [scripts/diamond_main.mk:163:

project/project_project.bit]

Error

1

I also try the GUI projects but

Diamond gave me theese erors for :

ulx3

@E: CD592

:"hdl4fpga/library/scope/scopeio.vhd":559:17:559:29|Instantiated

entity hdl4fpga.bram has not been analyzed.

@E: CD415

:"hdl4fpga/library/scope/scopeio.vhd":591:29:591:29|Expecting

keyword is

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":606:27:606:27|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":622:27:622:27|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":668:31:668:31|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":717:36:717:36|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":726:30:726:30|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":735:28:735:28|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":753:36:753:36|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":762:27:762:27|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":771:34:771:34|duplicate

entity name hdl4fpga

and after having added library/common/bram.vhd to the
project

ulx3s_12f_scope, I got this :

52111106 ERROR - EHXPLLL
'clk_25M/clk_video_cpu_v_inst/pll_i'

output

CLKOP

with -180 degree phase shift should not be used as the
feedback

signal

(FEEDBK_PATH = INT_OP).

On Sun, May 26, 2019 at 3:51 AM emard <

<EMAIL_ADDRESS>

wrote:

I pulled your latest repository, compiles and works

*** fantastic ***

On 5/25/19, Miguel Angel<EMAIL_ADDRESS>wrote:

On Sat, May 25, 2019 at 4:09 PM emard

<EMAIL_ADDRESS>

wrote:

Great!

There is a line missing in scopeio_pointer.vhd

and set it to latency = 0

Done

also you can now remove my scopeio_pointer_emard.vhd

old code

Done

On 5/25/19, Miguel Angel<EMAIL_ADDRESS>

wrote:

I added a new architecture into bram.vhd with
your
block

ram,

and

specified

that architecture into scopeio. Every thing seems
to
be

fine

here.

On Sat, May 25, 2019 at 12:38 PM emard

<EMAIL_ADDRESS>

wrote:

It was as I described at trigger_freeze = 0
I can toggle trigger freeze 1/0 with right mouse button.
On 5/28/19, Miguel Angel<EMAIL_ADDRESS>wrote:

https://github.com/hdl4fpga/hdl4fpga/blob/51385412843509deb02e3477c85a58f0c473998b/library/scope/scopeio.vhd#L506
if trigger_freeze is equial '1' trigger does not work. it keeps the last
trigger and doesn't capture new data. One shot trigger functionality.
if trigger_freeze is equal '0' it will trigger anyway if the trigger_level
does not shoot. It is a free running. I tested those functionalities and
they were working.
I will tested again
On Tue, May 28, 2019 at 2:02 PM emard<EMAIL_ADDRESS>wrote:

OK I tried suggested workaround at downsampler
but it doesn't work for me ,
same DTC pattern appears like before when I changed this:
It seems that with this and input_ena, it's not reacting to trigger -
I placed trigger level in the middle of signal range but no effect
downsampler_e : entity hdl4fpga.scopeio_downsampler
port map (
--factor => hz_scale,
factor => "1111", -- FIXME temporary workaround
On 5/28/19, D EMARD<EMAIL_ADDRESS>wrote:

HI
Aaaa only at downsampler I must hardcode "1111" not to everywhere else.
Not a rush with internet till thursday, it's ok more rarely from
university
On 5/28/19, Miguel Angel<EMAIL_ADDRESS>wrote:

First ... I'm having problem with my Internet connection at home, so I
can
only answer from the university. According to my provider, it will be
solved on Thursday
input_ena is there to tell scopeio when the sample is ready. It is
used
for example : for spi ADCs to feed the spi_clk as *input_clk *but to
capture the sample when all the bits are shifted in.
If a parallel ADC is used it should always be enable ('1').
Instead of setting hz_scale all '1' replace hz_scale by b"1111"
here

https://github.com/hdl4fpga/hdl4fpga/blob/51385412843509deb02e3477c85a58f0c473998b/library/scope/scopeio.vhd#L474

factor => b"1111",
As hz_scale controls other thing that can be confusing.
I will check things now ... but those are thing that can be tested if
you
want.
On Tue, May 28, 2019 at 10:33 AM emard<EMAIL_ADDRESS>wrote:

HI
I hardcoded hz_scale to (others => '1')
but problem exists.
So lets say I routed btn1 to ADC input.
when I press btn1 and don't use input_ena, trace
jumps to some high value and when I release btn0
trace is immediately back to 0.
With input_ena used and hz_scale = "1111"
when I press btn1, a duty-cycle pattern appears
rising slowly from 0% DTC to 100% over maybe 10 seconds
and when I release again counter DTC falling from 100%
to 0% again for 10 seconds. Something must be wrong there
On 5/27/19, D EMARD<EMAIL_ADDRESS>wrote:

Aaaaa, I need to fix hz scale hardcoded to "1111" as workaround.
Also I understdant vertical is not finished but it draws fine
numbers
so I guess the hardest part is already working.
prj_run is some TCL script inside of diamond
It is not called by a linux shell directly but passed to standard
input
of
"diamondc" commandline exe that is supposed to know where is this
prj_run
and how to execute. All "sh" in diamond scripting must be replaced
by
"bash"
I have a sed auto-replacement script there under
"diamond-fix-scripts"
directory
On 5/27/19, Miguel Angel<EMAIL_ADDRESS>wrote:

It's b"1111" not x"1111"

On Mon, May 27, 2019 at 11:42 AM emard<EMAIL_ADDRESS>wrote:

but in that case horizontal scale is fixed,

not changeable (currently I'm able to zoom in time,

horizontally)

On 5/27/19, Miguel Angel<EMAIL_ADDRESS>wrote:

send all ones to the horizontal scale ... it should be working

On Mon, May 27, 2019, 10:43 emard<EMAIL_ADDRESS>wrote:

HI

I have almost done ULX3S ADC MAX11123 working

I think scopeio.vhd input_ena is not working properly.

I must clock ADC core with 62.5 or 75 MHz

that is also input clock

but actual sample rate going out of ADC is currently

about 120-140 kHz, so I'd like to use input_ena

to scopeio to reduce data rate bit it seems not to

work - can you check?

On 5/26/19, Miguel Angel<EMAIL_ADDRESS>wrote:

On Sun, May 26, 2019 at 2:59 PM emard
<EMAIL_ADDRESS>

wrote:

it may be even nothing, a same logic but differently

arranged may randomize LUTusage by few %

I agree !

On 5/26/19, Miguel Angel<EMAIL_ADDRESS>wrote:

On ECP3 versa kit

pass_thru_a => true or false,

pass_thru_b => true or false

don't change LUTs consumption

Just to notice

Diamond version <IP_ADDRESS>

I haven't tried ulx3s yet

On Sun, May 26, 2019 at 2:01 PM emard <
<EMAIL_ADDRESS>

wrote:

My diamond 3.7 compiled it and it works.

the clock is generated by ecppll tools from trellis,

not diamond's original. maybe should we generate

the clock originally by diamond

for 1280x768 we need 375,75,25 MHz all phase shift 0

On 5/26/19, D EMARD<EMAIL_ADDRESS>wrote:

I will regenerate GUI project file for diamond (was
using

commandline)

on my bram, there's option pass_thru, some
architectures
are

better

enabling it, some disabling it and some don't care

On 5/26/19, Miguel Angel<EMAIL_ADDRESS>wrote:

I was curios about how hld4fpga's block ram
description
worked

compared

to bram_true2p_2clk, and I found this:

bram_true2p_2clk:

Device utilization summary:

PIO (prelim) 83/332 25% used

83/295 28% bonded

IOLOGIC 14/328 4% used

SLICE 1647/16632 9% used

GSR 1/1 100% used

EBR 7/72 9% used

PLL 1/4 25% used

MULT18 1/64 1% used

hdl4fpga

Device utilization summary:

PIO (prelim) 83/332 25% used

83/295 28% bonded

IOLOGIC 14/328 4% used

SLICE 1616/16632 9% used

GSR 1/1 100% used

EBR 7/72 9% used

PLL 1/4 25% used

MULT18 1/64 1% used

Theese data are for ecp3versa kit. It seems as the
brams'

architecture

of

bram_true2p_2clk misses to absorb the registers.

I might have been I've implemented something wrong
...

https://github.com/hdl4fpga/hdl4fpga/blob/071a493810cd73a0b4ef79acd83719c87eb560da/library/common/bram.vhd#L50

I still think it's better to use bram_true2p_2clk as
it
is
more

tested

than

the original for tools to work well. It is only a
curiosity.

I tried to compile your projects to see how they
behaved
but
I

got

these

error with the make file

echo prj_project open ulx3s_12f_scope.ldf ; prj_run
Export

-task

Bitgen

|

/bin/sh: -c: line 1: syntax error: unexpected end of
file

make: *** [scripts/diamond_main.mk:163:

project/project_project.bit]

Error

1

I also try the GUI projects but

Diamond gave me theese erors for :

ulx3

@E: CD592

:"hdl4fpga/library/scope/scopeio.vhd":559:17:559:29|Instantiated

entity hdl4fpga.bram has not been analyzed.

@E: CD415

:"hdl4fpga/library/scope/scopeio.vhd":591:29:591:29|Expecting

keyword is

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":606:27:606:27|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":622:27:622:27|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":668:31:668:31|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":717:36:717:36|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":726:30:726:30|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":735:28:735:28|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":753:36:753:36|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":762:27:762:27|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":771:34:771:34|duplicate

entity name hdl4fpga

and after having added library/common/bram.vhd to the
project

ulx3s_12f_scope, I got this :

52111106 ERROR - EHXPLLL
'clk_25M/clk_video_cpu_v_inst/pll_i'

output

CLKOP

with -180 degree phase shift should not be used as
the
feedback

signal

(FEEDBK_PATH = INT_OP).

On Sun, May 26, 2019 at 3:51 AM emard <

<EMAIL_ADDRESS>

wrote:

I pulled your latest repository, compiles and works

*** fantastic ***

On 5/25/19, Miguel Angel<EMAIL_ADDRESS>wrote:

On Sat, May 25, 2019 at 4:09 PM emard

<EMAIL_ADDRESS>

wrote:

Great!

There is a line missing in scopeio_pointer.vhd

and set it to latency = 0

Done

also you can now remove my
scopeio_pointer_emard.vhd

old code

Done

On 5/25/19, Miguel Angel
<EMAIL_ADDRESS>

wrote:

checking ...
On Tue, May 28, 2019 at 2:24 PM emard<EMAIL_ADDRESS>wrote:

It was as I described at trigger_freeze = 0
I can toggle trigger freeze 1/0 with right mouse button.
On 5/28/19, Miguel Angel<EMAIL_ADDRESS>wrote:

https://github.com/hdl4fpga/hdl4fpga/blob/51385412843509deb02e3477c85a58f0c473998b/library/scope/scopeio.vhd#L506

if trigger_freeze is equial '1' trigger does not work. it keeps the last
trigger and doesn't capture new data. One shot trigger functionality.
if trigger_freeze is equal '0' it will trigger anyway if the
trigger_level
does not shoot. It is a free running. I tested those functionalities and
they were working.
I will tested again
On Tue, May 28, 2019 at 2:02 PM emard<EMAIL_ADDRESS>wrote:

OK I tried suggested workaround at downsampler
but it doesn't work for me ,
same DTC pattern appears like before when I changed this:
It seems that with this and input_ena, it's not reacting to trigger -
I placed trigger level in the middle of signal range but no effect
downsampler_e : entity hdl4fpga.scopeio_downsampler
port map (
--factor => hz_scale,
factor => "1111", -- FIXME temporary workaround
On 5/28/19, D EMARD<EMAIL_ADDRESS>wrote:

HI
Aaaa only at downsampler I must hardcode "1111" not to everywhere
else.
Not a rush with internet till thursday, it's ok more rarely from
university
On 5/28/19, Miguel Angel<EMAIL_ADDRESS>wrote:

First ... I'm having problem with my Internet connection at home, so
I
can
only answer from the university. According to my provider, it will be
solved on Thursday
input_ena is there to tell scopeio when the sample is ready. It is
used
for example : for spi ADCs to feed the spi_clk as *input_clk *but
to
capture the sample when all the bits are shifted in.
If a parallel ADC is used it should always be enable ('1').
Instead of setting hz_scale all '1' replace hz_scale by b"1111"
here

https://github.com/hdl4fpga/hdl4fpga/blob/51385412843509deb02e3477c85a58f0c473998b/library/scope/scopeio.vhd#L474

factor => b"1111",
As hz_scale controls other thing that can be confusing.
I will check things now ... but those are thing that can be tested if
you
want.
On Tue, May 28, 2019 at 10:33 AM emard<EMAIL_ADDRESS>wrote:

HI
I hardcoded hz_scale to (others => '1')
but problem exists.
So lets say I routed btn1 to ADC input.
when I press btn1 and don't use input_ena, trace
jumps to some high value and when I release btn0
trace is immediately back to 0.
With input_ena used and hz_scale = "1111"
when I press btn1, a duty-cycle pattern appears
rising slowly from 0% DTC to 100% over maybe 10 seconds
and when I release again counter DTC falling from 100%
to 0% again for 10 seconds. Something must be wrong there
On 5/27/19, D EMARD<EMAIL_ADDRESS>wrote:

Aaaaa, I need to fix hz scale hardcoded to "1111" as workaround.
Also I understdant vertical is not finished but it draws fine
numbers
so I guess the hardest part is already working.
prj_run is some TCL script inside of diamond
It is not called by a linux shell directly but passed to standard
input
of
"diamondc" commandline exe that is supposed to know where is this
prj_run
and how to execute. All "sh" in diamond scripting must be replaced
by
"bash"
I have a sed auto-replacement script there under
"diamond-fix-scripts"
directory
On 5/27/19, Miguel Angel<EMAIL_ADDRESS>wrote:

It's b"1111" not x"1111"

On Mon, May 27, 2019 at 11:42 AM emard<EMAIL_ADDRESS>

wrote:

but in that case horizontal scale is fixed,

not changeable (currently I'm able to zoom in time,

horizontally)

On 5/27/19, Miguel Angel<EMAIL_ADDRESS>wrote:

send all ones to the horizontal scale ... it should be working

On Mon, May 27, 2019, 10:43 emard<EMAIL_ADDRESS>wrote:

HI

I have almost done ULX3S ADC MAX11123 working

I think scopeio.vhd input_ena is not working properly.

I must clock ADC core with 62.5 or 75 MHz

that is also input clock

but actual sample rate going out of ADC is currently

about 120-140 kHz, so I'd like to use input_ena

to scopeio to reduce data rate bit it seems not to

work - can you check?

On 5/26/19, Miguel Angel<EMAIL_ADDRESS>wrote:

On Sun, May 26, 2019 at 2:59 PM emard
<EMAIL_ADDRESS>

wrote:

it may be even nothing, a same logic but differently

arranged may randomize LUTusage by few %

I agree !

On 5/26/19, Miguel Angel<EMAIL_ADDRESS>wrote:

On ECP3 versa kit

pass_thru_a => true or false,

pass_thru_b => true or false

don't change LUTs consumption

Just to notice

Diamond version <IP_ADDRESS>

I haven't tried ulx3s yet

On Sun, May 26, 2019 at 2:01 PM emard <
<EMAIL_ADDRESS>

wrote:

My diamond 3.7 compiled it and it works.

the clock is generated by ecppll tools from trellis,

not diamond's original. maybe should we generate

the clock originally by diamond

for 1280x768 we need 375,75,25 MHz all phase shift 0

On 5/26/19, D EMARD<EMAIL_ADDRESS>wrote:

I will regenerate GUI project file for diamond (was
using

commandline)

on my bram, there's option pass_thru, some
architectures
are

better

enabling it, some disabling it and some don't care

On 5/26/19, Miguel Angel<EMAIL_ADDRESS>wrote:

I was curios about how hld4fpga's block ram
description
worked

compared

to bram_true2p_2clk, and I found this:

bram_true2p_2clk:

Device utilization summary:

PIO (prelim) 83/332 25% used

83/295 28% bonded

IOLOGIC 14/328 4% used

SLICE 1647/16632 9% used

GSR 1/1 100% used

EBR 7/72 9% used

PLL 1/4 25% used

MULT18 1/64 1% used

hdl4fpga

Device utilization summary:

PIO (prelim) 83/332 25% used

83/295 28% bonded

IOLOGIC 14/328 4% used

SLICE 1616/16632 9% used

GSR 1/1 100% used

EBR 7/72 9% used

PLL 1/4 25% used

MULT18 1/64 1% used

Theese data are for ecp3versa kit. It seems as the
brams'

architecture

of

bram_true2p_2clk misses to absorb the registers.

I might have been I've implemented something wrong
...

https://github.com/hdl4fpga/hdl4fpga/blob/071a493810cd73a0b4ef79acd83719c87eb560da/library/common/bram.vhd#L50

I still think it's better to use bram_true2p_2clk as
it
is
more

tested

than

the original for tools to work well. It is only a
curiosity.

I tried to compile your projects to see how they
behaved
but
I

got

these

error with the make file

echo prj_project open ulx3s_12f_scope.ldf ; prj_run
Export

-task

Bitgen

|

/bin/sh: -c: line 1: syntax error: unexpected end of
file

make: *** [scripts/diamond_main.mk:163:

project/project_project.bit]

Error

1

I also try the GUI projects but

Diamond gave me theese erors for :

ulx3

@E: CD592

:"hdl4fpga/library/scope/scopeio.vhd":559:17:559:29|Instantiated

entity hdl4fpga.bram has not been analyzed.

@E: CD415

:"hdl4fpga/library/scope/scopeio.vhd":591:29:591:29|Expecting

keyword is

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":606:27:606:27|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":622:27:622:27|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":668:31:668:31|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":717:36:717:36|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":726:30:726:30|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":735:28:735:28|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":753:36:753:36|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":762:27:762:27|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":771:34:771:34|duplicate

entity name hdl4fpga

and after having added library/common/bram.vhd to
the
project

ulx3s_12f_scope, I got this :

52111106 ERROR - EHXPLLL
'clk_25M/clk_video_cpu_v_inst/pll_i'

output

CLKOP

with -180 degree phase shift should not be used as
the
feedback

signal

(FEEDBK_PATH = INT_OP).

On Sun, May 26, 2019 at 3:51 AM emard <

<EMAIL_ADDRESS>

wrote:

I pulled your latest repository, compiles and works

*** fantastic ***

On 5/25/19, Miguel Angel<EMAIL_ADDRESS>

wrote:

On Sat, May 25, 2019 at 4:09 PM emard

<EMAIL_ADDRESS>

wrote:

Done

also you can now remove my
scopeio_pointer_emard.vhd

Done

Does your input signal has more than 8 bits ? .... there is  an overflow
problem that it makes display weird things unless vertical is working -
that is not - you cannot see right signal... overflow is not checked now.
On Tue, May 28, 2019 at 2:24 PM emard<EMAIL_ADDRESS>wrote:

It was as I described at trigger_freeze = 0
I can toggle trigger freeze 1/0 with right mouse button.
On 5/28/19, Miguel Angel<EMAIL_ADDRESS>wrote:

https://github.com/hdl4fpga/hdl4fpga/blob/51385412843509deb02e3477c85a58f0c473998b/library/scope/scopeio.vhd#L506

if trigger_freeze is equial '1' trigger does not work. it keeps the last
trigger and doesn't capture new data. One shot trigger functionality.
if trigger_freeze is equal '0' it will trigger anyway if the
trigger_level
does not shoot. It is a free running. I tested those functionalities and
they were working.
I will tested again
On Tue, May 28, 2019 at 2:02 PM emard<EMAIL_ADDRESS>wrote:

OK I tried suggested workaround at downsampler
but it doesn't work for me ,
same DTC pattern appears like before when I changed this:
It seems that with this and input_ena, it's not reacting to trigger -
I placed trigger level in the middle of signal range but no effect
downsampler_e : entity hdl4fpga.scopeio_downsampler
port map (
--factor => hz_scale,
factor => "1111", -- FIXME temporary workaround
On 5/28/19, D EMARD<EMAIL_ADDRESS>wrote:

HI
Aaaa only at downsampler I must hardcode "1111" not to everywhere
else.
Not a rush with internet till thursday, it's ok more rarely from
university
On 5/28/19, Miguel Angel<EMAIL_ADDRESS>wrote:

First ... I'm having problem with my Internet connection at home, so
I
can
only answer from the university. According to my provider, it will be
solved on Thursday
input_ena is there to tell scopeio when the sample is ready. It is
used
for example : for spi ADCs to feed the spi_clk as *input_clk *but
to
capture the sample when all the bits are shifted in.
If a parallel ADC is used it should always be enable ('1').
Instead of setting hz_scale all '1' replace hz_scale by b"1111"
here

https://github.com/hdl4fpga/hdl4fpga/blob/51385412843509deb02e3477c85a58f0c473998b/library/scope/scopeio.vhd#L474

factor => b"1111",
As hz_scale controls other thing that can be confusing.
I will check things now ... but those are thing that can be tested if
you
want.
On Tue, May 28, 2019 at 10:33 AM emard<EMAIL_ADDRESS>wrote:

HI
I hardcoded hz_scale to (others => '1')
but problem exists.
So lets say I routed btn1 to ADC input.
when I press btn1 and don't use input_ena, trace
jumps to some high value and when I release btn0
trace is immediately back to 0.
With input_ena used and hz_scale = "1111"
when I press btn1, a duty-cycle pattern appears
rising slowly from 0% DTC to 100% over maybe 10 seconds
and when I release again counter DTC falling from 100%
to 0% again for 10 seconds. Something must be wrong there
On 5/27/19, D EMARD<EMAIL_ADDRESS>wrote:

Aaaaa, I need to fix hz scale hardcoded to "1111" as workaround.
Also I understdant vertical is not finished but it draws fine
numbers
so I guess the hardest part is already working.
prj_run is some TCL script inside of diamond
It is not called by a linux shell directly but passed to standard
input
of
"diamondc" commandline exe that is supposed to know where is this
prj_run
and how to execute. All "sh" in diamond scripting must be replaced
by
"bash"
I have a sed auto-replacement script there under
"diamond-fix-scripts"
directory
On 5/27/19, Miguel Angel<EMAIL_ADDRESS>wrote:

It's b"1111" not x"1111"

On Mon, May 27, 2019 at 11:42 AM emard<EMAIL_ADDRESS>

wrote:

but in that case horizontal scale is fixed,

not changeable (currently I'm able to zoom in time,

horizontally)

On 5/27/19, Miguel Angel<EMAIL_ADDRESS>wrote:

send all ones to the horizontal scale ... it should be working

On Mon, May 27, 2019, 10:43 emard<EMAIL_ADDRESS>wrote:

HI

I have almost done ULX3S ADC MAX11123 working

I think scopeio.vhd input_ena is not working properly.

I must clock ADC core with 62.5 or 75 MHz

that is also input clock

but actual sample rate going out of ADC is currently

about 120-140 kHz, so I'd like to use input_ena

to scopeio to reduce data rate bit it seems not to

work - can you check?

On 5/26/19, Miguel Angel<EMAIL_ADDRESS>wrote:

On Sun, May 26, 2019 at 2:59 PM emard
<EMAIL_ADDRESS>

wrote:

it may be even nothing, a same logic but differently

arranged may randomize LUTusage by few %

I agree !

On 5/26/19, Miguel Angel<EMAIL_ADDRESS>wrote:

On ECP3 versa kit

pass_thru_a => true or false,

pass_thru_b => true or false

don't change LUTs consumption

Just to notice

Diamond version <IP_ADDRESS>

I haven't tried ulx3s yet

On Sun, May 26, 2019 at 2:01 PM emard <
<EMAIL_ADDRESS>

wrote:

My diamond 3.7 compiled it and it works.

the clock is generated by ecppll tools from trellis,

not diamond's original. maybe should we generate

the clock originally by diamond

for 1280x768 we need 375,75,25 MHz all phase shift 0

On 5/26/19, D EMARD<EMAIL_ADDRESS>wrote:

I will regenerate GUI project file for diamond (was
using

commandline)

on my bram, there's option pass_thru, some
architectures
are

better

enabling it, some disabling it and some don't care

On 5/26/19, Miguel Angel<EMAIL_ADDRESS>wrote:

I was curios about how hld4fpga's block ram
description
worked

compared

to bram_true2p_2clk, and I found this:

bram_true2p_2clk:

Device utilization summary:

PIO (prelim) 83/332 25% used

83/295 28% bonded

IOLOGIC 14/328 4% used

SLICE 1647/16632 9% used

GSR 1/1 100% used

EBR 7/72 9% used

PLL 1/4 25% used

MULT18 1/64 1% used

hdl4fpga

Device utilization summary:

PIO (prelim) 83/332 25% used

83/295 28% bonded

IOLOGIC 14/328 4% used

SLICE 1616/16632 9% used

GSR 1/1 100% used

EBR 7/72 9% used

PLL 1/4 25% used

MULT18 1/64 1% used

Theese data are for ecp3versa kit. It seems as the
brams'

architecture

of

bram_true2p_2clk misses to absorb the registers.

I might have been I've implemented something wrong
...

https://github.com/hdl4fpga/hdl4fpga/blob/071a493810cd73a0b4ef79acd83719c87eb560da/library/common/bram.vhd#L50

I still think it's better to use bram_true2p_2clk as
it
is
more

tested

than

the original for tools to work well. It is only a
curiosity.

I tried to compile your projects to see how they
behaved
but
I

got

these

error with the make file

echo prj_project open ulx3s_12f_scope.ldf ; prj_run
Export

-task

Bitgen

|

/bin/sh: -c: line 1: syntax error: unexpected end of
file

make: *** [scripts/diamond_main.mk:163:

project/project_project.bit]

Error

1

I also try the GUI projects but

Diamond gave me theese erors for :

ulx3

@E: CD592

:"hdl4fpga/library/scope/scopeio.vhd":559:17:559:29|Instantiated

entity hdl4fpga.bram has not been analyzed.

@E: CD415

:"hdl4fpga/library/scope/scopeio.vhd":591:29:591:29|Expecting

keyword is

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":606:27:606:27|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":622:27:622:27|duplicate

entity name hdl4fpga

@E: CD632

:"hdl4fpga/library/scope/scopeio.vhd":668:31:668:31|duplicate

entity name hdl4fpga


Allow publication artifacts to be defined as files through providers

This used to work in Gradle 5.5 (see #11054).
The combination of #9467 and #6775 broke this.
A builtBy dependency is added if the artifact is a TaskDependencyContainer,
which all Providers are (#9467). This dependency was silently doing
nothing in case of a plain File/String. This became an error (#6775)
because a File/String is nothing that can be resolved to a task.
We now only add a builtBy dependency, if the provider value or content is
actually produced by a task.

Update based on feedback: https://github.com/gradle/gradle/commit/62cfd99b4141cee8def764530feb39eb40269c0c