Regression in 	hotReloadInitialDevFSSyncAfterRelaunchMilliseconds

15ms ~7% regression so marking P0.
https://flutter-flutter-perf.skia.org/e/?begin=1607714599&end=1608103683&keys=X4a4e3c57b71c45caf7d762fcf76c8434&requestType=0&xbaroffset=22860
Likely https://github.com/flutter/flutter/commit/4ed3432e8f43dd92130d3360537c0a30c7283a3f
/cc @jmagman @jonahwilliams

reverting. We can probably pick a lower zlib level number.

Drive by comment - I don't think any regression is necessary here. The problem is that you are eagerly encoding the NOTICES file, which works against previous optimizations I've done to do most work lazily. The goal should be to only encode and sync the NOTICES file if any of the underlying license changes.
The way I would accomplish this is with a special DevFSContent subtype that does this computation on the fly. Then constructing the asset bundle could use the same invalidation logic as the DevFSString, but would only perform the encode when the bytes are accessed.

Ha, thanks for checking. I tried to understand what the optimization was (https://github.com/flutter/flutter/pull/71899/files#diff-1339eded5eeb35ab9fbc61051c530c73e307d4640328760c1af0eee36c142be2R356) but must have gotten wrong. Let me bug you about it when you come back in January.


Fix typos in routine documentation

Pull request summary
Fix typos in routine documentation
Checklist

[ ] If code changes were made then they have been tested.

[ ] I have updated the documentation to reflect the changes.
[ ] I have updated the changelog with a quick recap of my changes.

[ ] This PR fixes an issue.
[ ] This PR adds something new (e.g. new method or parameters).
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[x] This PR is not a code change (e.g. documentation, README, ...)

Thanks, I actually have these changes already ready to go in my next push as we are currently updating all the docs.

Roger!


Use recommended git bash args in default detected profile

We should use these defaults: https://code.visualstudio.com/docs/editor/integrated-terminal#_windows
Context: https://github.com/microsoft/vscode/pull/118790#issuecomment-800976242

We decided against doing this because it seems like git-cmd.exe --command=usr/bin/bash.exe -l -i and bin/bash.exe -l are equivalent and both run .bash_profile which was the original reason it was changed in the docs https://github.com/microsoft/vscode-docs/pull/4066. We'll update the docs this release https://github.com/microsoft/vscode-docs/issues/4406

Great, thanks for checking into that (and the simplification)!

By the way, thanks @meganrogge and yourself @Tyriar, now we have simplified the System Setup guide for our bootcamp students with your simplified start command:
https://github.com/upleveled/system-setup/commit/568f3df837f3bc906174d067d6919b3f1df6465b


LoggerExtensions prematurely create FormattedLogValues and potentially exhaust cache of LogValuesFormatter

This is more of a discussion initially...
The LogXXX extension methods in LoggerExtensions create a new instance of FormattedLogValues without being guarded by any IsEnabled check. In turn, FormattedLogValues holds a cache of LogValuesFormatter instances with a hard-coded limit of 1024 instances. After that, all new formatters that aren't in the cache are created as a new instance and thrown away each time.
Whilst the guidelines recommend adding IsEnabled guards around calls to LogXXX, the code samples here and here do not use them.
As this cache is static, it is shared across all ILogger users in the process: the framework, the application and any 3rd party packages. It seems quite possible (even likely) that code without IsEnabled code guards (possibly written using the samples above or possibly just relying on log filtering) could use up the cache of LogValuesFormatter instances and thus impact performance.
So:

Should the cache strategy be changed, for example, to use a keep MRU or evict LRU strategy?
Should the 1024 limit be higher or made configurable?
Should the code expose a way to determine the current state of the cache to allow an application developer to determine if the limit should be up-ed?
Should the LogXXX extension methods perform an IsEnabled check?

Our docs are a bit sparse on the best practices here. The way to optimize logging in general is to use the LoggerMessage type to create a "pre-compiled" logger. https://github.com/aspnet/Logging/blob/9506ccc3f3491488fe88010ef8b9eb64594abf95/src/Microsoft.Extensions.Logging.Abstractions/LoggerMessage.cs
Here's an example on how it's used:
https://github.com/aspnet/SignalR/blob/bfa2df1fc650fda6c92ca52c7a83c187b25e2583/src/Microsoft.AspNetCore.Sockets/Internal/SocketLoggerExtensions.cs
Our default implementation should be a little less naive and should implement a better caching strategy. I'm not sure the limit should be configurable, it's one of those things you should never have to tweak.

Thanks for your reply David. However, that is a bit ... err ... cumbersome.
For every message template you want to log you statically create a delegate (that caches the formatter) regardless of whether the message will ever actually be logged. I guess this would ensure that your formatters are "cached" but it does bypass the purpose of the limited cache.
Re: "Our default implementation should be a little less naive and should implement a better caching strategy."
I think it boils down to this statement as this is the way the vast majority will use the loggers...

Docs are here
I'm experimenting with a pattern that avoids the delegate creation (and template parsing etc) for logs that are never called. However, this pattern does require (CategoryName, EventId) to be a unique tuple:
public static class Logger
{
  private static class DelegatesFor<TLoggerCategory>
  {
    public static readonly ConcurrentDictionary<int, object> Delegates = new ConcurrentDictionary<int, object>();
  }

  public static void Log<TLoggerCategory, T1>(ILogger<TLoggerCategory> logger, int eventId, LogLevel logLevel, string format, T1 arg1, [CallerMemberName] string eventName = null)
  {
    var action = (Action<ILogger, T1, Exception>)DelegatesFor<TLoggerCategory>.Delegates.GetOrAdd(eventId, _ =>
      LoggerMessage.Define<T1>(logLevel, new EventId(eventId, eventName), format));
    action(logger, arg1, null);
  }
  ... other overloads for more parameters / no parameters, plus exceptions
}

The above is a helper type that only needs to be written once and can be placed in a library.
Then, defining each set of log messages:
internal static partial class Logging
{
  public static void RequestReceived(this ILogger<DocumentationFunction> logger, int jsonVersion, string packageId, string packageVersion, string targetFramework) =>
    Logger.Log(logger, 1, LogLevel.Debug, "Received request for jsonVersion={jsonVersion}, packageId={packageId}, packageVersion={packageVersion}, targetFramework={targetFramework}",
      jsonVersion, packageId, packageVersion, targetFramework);

  public static void UpdateRequired(this ILogger<DocumentationFunction> logger, int requestedJsonVersion, int currentJsonVersion) =>
    Logger.Log(logger, 2, LogLevel.Error, "Requested JSON version {requestedJsonVersion} is old; current JSON version is {currentJsonVersion}",
      requestedJsonVersion, currentJsonVersion);
}

Note that all these methods are only defined on generic ILogger<T>, not ILogger. This helps ensure the proper logs are being used.
Things I like about the pattern:

Provides a less cumbersome/verbose way to use LoggerMessage.
The event ids line up nicely in the source file. It's pretty easy to read down them and see 1, 2, 3, 4, 5 and know they're all different.
The event names are autodetected (CallerMemberName instead of nameof).

Things I don't like about the pattern:

Silent failure (with weird logs) if you do mess it up. This is also a drawback to the more verbose pattern.
Requires generic logger. I occasionally need a logger for a static class, which cannot be used as a generic type. As a workaround, I define a tag type in my Logging class.

LoggerMessage.Define should be used to all the cases where exhausting message template cache is a concern.


Remove duplicate titles for imported docs

hack/import-flux2-docs.sh adds frontmatter for both imported markdown and html docs.
Now it should remove the title after having added frontmatter title entry. A good example for this now is /docs/components/source/gitrepositories/.

https://github.com/dholbach/website/blob/juozas-changes/hack/import-flux2-docs.sh#L14


Implement clamp kernel for WGPU

Currently wgpu backend is using the default implementation using mask_fill for clamp operators. This issue ticket is to improve the performance using wgpu specific and more optimal kernel for clamp, including clamp_min, clamp_max.

I have added TODOs in this PR to be replaced with a kernel call: https://github.com/burn-rs/burn/pull/550

@antimora I can take this.


Change write-up link for Contraception module to article

Fixes #1247
Changes link on documentation site write-ups page for Contraception module to link to published article in Studies in Family Planning.
Currently this removes the link to the previous .docx write-up but doesn't remove the actual file. Alternatives would be to keep the link to the .docx file in addition to the article link or to remove the .docx file entirely.

Thanks @matt-graham and @timcolbourn
I would say we should keep the link the original write-up docx file, and add a link to the journal article.
(Unless it's the case that the original write-up is now out-dated and/or contradicts the paper, ... @timcolbourn ..?).

Add a commit to that effect.


Target to Image Plane

Function 1 - For each target, get (x, y) in image plane coordinates.
Function 2 - Get geometric center of targets -> Vector3
Function 3 - If (x, y) within image bounds (u, v) -> true, else -> false

Function 2 complete. Function 1 and 3 nearly done.

Completed all functions in TargetState.cs


⚠ ClamAV has degraded performance

In 45c65ee, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 50 ms

Resolved: ClamAV performance has improved in 8107a3a.


Support automated/scheduled database rebuilds

Would like to perform regular rebuilds of the database, but unfortunately the endpoint to do so requires CSRF tokens which makes it rather annoying to automate.
If there could be a way implemented to trigger such via CLI or via REST interface with an API key or somesuch, it would be greatly appreciated.

Will get rig of CSRF token in next version, since CSRF prevention is useless here as there is no session or cookies to hijack.

Done in v1.7.0


Ignore non-DICOM files in a directory

This PR allows dcmdir_parse to work in a directory with non-DICOM-related files. Currently, mac users will run into problems due to .DS_Store and Icon metadata files. This PR modifies isdicom to account for that.
function isdicom(file)
    try
        bytes = read(file, 132)[end-3:end]
        String(bytes) == "DICM"
    catch
        false
    end
end

A test and a non-DICOM image were also added to make sure isdicom is working properly
@testset "isdicom" begin
    answer = DICOM.isdicom("test/testdata/brain.bmp")
    @test answer === false

    fileDX = download_dicom("DX_Implicit_Little_Interleaved.dcm")
    answer2 = DICOM.isdicom(fileDX)
    @test answer2 == true
end

Thanks for catching and fixing this @Dale-Black !
I think the tests are currently failing because the brain.bmp file was not added---likely because the testdata folder is included in .gitignore. An alternative could be to create an invalid during the tests. I'll open a PR on your branch with this approach.

Sorry this took a while, I was busy with finals. I just merged your PR @notZaki so hopefully that fixes everything. Thanks!

LGTM.
Thanks @Dale-Black !


Add reflection support for wrappers

Develop a generic way to handle reflection for wrappers like glz::quoted, glz::raw_string, etc.

I'm torn about adding reflection support to wrappers, because wrappers work on lambda functions and member functions, making the code more complex. And, I don't want to slow down compile time for normal usage, needing to check if types are wrappers. It keeps the code simpler (and compilation likely faster) by not supporting reflection with wrappers. Users can make their own local macros if they really have issues with the extra typing for wrappers.
In conclusion, I don't think this is a good idea and I'll close this issue.


Offline game changes

With my changes You can only play with a friend not online , offline taking turns
your friend will be the green and you are the red
i didnt remove the AI or computerPLayer settings
i just give another player to play as Computer 💯
btw i never used the worker module :)

With my changes You can only play with a friend not online , offline taking turns
your friend will be the green and you are the red
i didnt remove the AI or computerPLayer settings
i just give another player to play as Computer 💯
btw i never used the worker module :)

What you did is nice but all the play with computer settings are gone I need an additional option for PVP not overwriting it and instead of displaying an alert on win we need to show the message in the panel.


Add proper certificate for docs.brew.sh

https://docs.brew.sh is currently serving an invalid cert for that domain.

This isn't something under our control as it's using GitHub Pages. https://brew.sh is important as it has copy-paste instructions whereas this is not.


Make executable on linux

The file permissions on git were not executable which required to run
chmod 755 linux_mark.sh

Before executing as documented in the README.
This fixes the issue.

Is this abandoned?


[icon] Adds variant 'gpu'

The variant "gpu" follows closer the configure of icon.

when I compile icon I would like to have only: +gpu=openacc+cuda would this be the case, or do I also need to set +cuda ?

+gpu=openacc+cuda conflicts with ~cuda, so it should cause +cuda automatically.

+gpu=openacc+cuda conflicts with ~cuda, so it should cause +cuda automatically.

ok , is this the spack behavior, is not going to give an error because default is ~cuda ?
Should we not have a "depends_on" like depends_on(cuda,when='openacc+cuda' ?

No, no error.
depends_on('cuda', when='gpu=openacc+cuda') would only make the package depend on the cuda library. The variant cuda would be unaffected. But the variant 'cuda_arch' in spack.CudaPackage is only available when +cuda. Therefore I think it's simpler to make the variant cuda follow the variant gpu to leverage spack.CudaPackage's functionality.

launch jenkins icon

tsa
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec

balfrin
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :green_circle: system testTest:green_circle:Icon-install_nwp_cpu :green_circle:Icon-install_nwp_gpu

daint
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :red_circle: system testTest:red_circle:daint_cpu_cce :green_circle:daint_cpu_gcc :green_circle:daint_cpu_nvhpc :green_circle:daint_cpu_nvhpc_out_of_source :green_circle:daint_gpu_nvhpc
WARNING: Serial tests did not run for system tests

launch jenkins icon

tsa
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec

balfrin
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :green_circle: system testTest:green_circle:Icon-install_nwp_cpu :green_circle:Icon-install_nwp_gpu

daint
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :red_circle: system testTest:green_circle:daint_cpu_cce :red_circle:daint_cpu_gcc :green_circle:daint_cpu_nvhpc :green_circle:daint_cpu_nvhpc_out_of_source :green_circle:daint_gpu_nvhpc
WARNING: Serial tests did not run for system tests

daint_cpu_cce and daint_cpu_cce both passed once, for the same commit. We think that the tests are just flaky and it's not within the scope of this PR to fix that.
@jonasjucker Do you agree? Can we merge?

@jonasjucker this is my request: in the current mast the "gpu" build is named "cuda" which is specific to nvidia gpu's and do not reflect the configure script of ICON. Now we have in icon a --enable-gpu=openacc configure option. I need this PR to use it, the corresponding ICON PR is here: https://gitlab.dkrz.de/icon/icon-nwp/-/merge_requests/950
I already reviewed this. The request was not to review but to notify you that we are going to merge although the CI is red on daint. @PanicSheep run it multiple time with out changing the PR and all test succeeded at list once, so we assume this PR is not breaking anything on daint, but there is an issue with the testing. Do you agree ?

Actually I think we need to path the openacc+cuda to the configure script, this as other side effects which are needed

I made a try to set --enable-gpu=openacc+gpu
I have the impression that the variant gpu=openacc+cuda was interpreted as gpu=openacc +cuda , for now I am keeping the 2 variants. Maybe is not so safe to use the "+" inside a variant.

launch jenkins icon

tsa
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec

balfrin
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :green_circle: system testTest:green_circle:Icon-install_nwp_cpu :green_circle:Icon-install_nwp_gpu

daint
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :green_circle: system testTest:green_circle:daint_cpu_cce :green_circle:daint_cpu_gcc :green_circle:daint_cpu_nvhpc :green_circle:daint_cpu_nvhpc_out_of_source :green_circle:daint_gpu_nvhpc

LGTM.
Is compatible with existing spack.yaml of ICON

launch jenkins icon

tsa
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec

balfrin
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :green_circle: system testTest:green_circle:Icon-install_nwp_cpu :green_circle:Icon-install_nwp_gpu

daint
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :red_circle: system testTest:red_circle:daint_cpu_cce :red_circle:daint_cpu_gcc :green_circle:daint_cpu_nvhpc :green_circle:daint_cpu_nvhpc_out_of_source :green_circle:daint_gpu_nvhpc
WARNING: Serial tests did not run for system tests

I still need to run the test with ICON: https://gitlab.dkrz.de/icon/icon-nwp/-/merge_requests/950 before this can be merged

launch jenkins icon daint

tsa
:green_circle: unit testTest:green_circle:summary

daint
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :red_circle: system testTest:red_circle:daint_cpu_cce :red_circle:daint_cpu_gcc :red_circle:daint_cpu_nvhpc :red_circle:daint_gpu_nvhpc
WARNING: Serial tests did not run for system tests

@PanicSheep the test is running here https://gitlab.dkrz.de/icon/icon-nwp/-/pipelines/39788 , you can merge if green, otherwise I'll need to look at it.

We have a workaround for the issue in the ICON MR, with this the test is green : https://bb-prod8.dkrz.de/#/builders/87/builds/22 you can merge and create the release


add fregante to FUNDING

@fregante I assume you're okay with this?  (Went on a bit of a binge last night adding this to various repos and forgot to include you here.)

@fregante Sorry for all the notifications about pushes and vercel builds.  I inadvertently broke things by switching from package-lock.json to yarn.lock.
On a slightly different note, this appears to have surfaced a bug in the npmjs.com website that may be of interest.   I doubt it matters all that much since this project isn't something people are going to be looking for on npm directly but figured I'd let you know I'm aware of the issue: https://github.com/npm/feedback/discussions/802


Dependabot should not run for JavaScript

Looks like there is not much we can do about security alerts from JavaScript except ignoring them in the Security panel.


Return nil from formatters' #call method if the logstash event has been cancelled

Moved the responsibility of returning the formatted message to the
base LogStashLogger::Formatter::Base class, since it is there where
the event is assembled and possibly cancelled by the user.
Added a new private #format_event method that receives an event and
returns the object to be logged to the device. This method may be
overriden by the derived formatter classes.
Public interface should be backwards compatible for non-cancelled
events.
TODO: Do all supported devices gracefully handle a nil response
from the formatters?

Resolves #133

Codecov Report

Merging #134 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   92.81%   92.87%   +0.06%
==========================================
  Files          64       64
  Lines        1628     1642      +14
==========================================
+ Hits         1511     1525      +14
  Misses        117      117

Impacted Files
Coverage Δ

lib/logstash-logger/formatter/logstash_event.rb
100% <ø> (ø)
:arrow_up:

lib/logstash-logger/formatter/cee.rb
100% <100%> (ø)
:arrow_up:

lib/logstash-logger/formatter/base.rb
100% <100%> (ø)
:arrow_up:

lib/logstash-logger/formatter/cee_syslog.rb
100% <100%> (ø)
:arrow_up:

lib/logstash-logger/formatter/json_lines.rb
100% <100%> (ø)
:arrow_up:

spec/formatter/base_spec.rb
100% <100%> (ø)
:arrow_up:

spec/formatter/cee_syslog_spec.rb
100% <100%> (ø)
:arrow_up:

lib/logstash-logger/formatter/json.rb
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a40fbb5...9b075e8. Read the comment docs.

@gdeoliveira I checked a few devices to see if they gracefully handle writing nil. TCP and UDP work fine, the message is ignored. Redis unfortunately does still write a blank message, so I see this error on the Logstash listener side:
JSON codec is expecting array or object/map {:data=>"", :level=>:error}
{"message":"","tags":["_jsonparsefailure"],"@version":"1","@timestamp":"2017-08-30T13:36:01.080Z"}

I think it will be best to go into each device and explicitly handle the nil case. Most of the devices can be handled by modifying LogstashLogger::Device::Base#write_one

@dwbutler, thanks for checking this. I will look into it.

I have been browsing through the devices and this change is possible but will require modifying several files. We would need to make sure each device handles a nil parameter in its #write method (by effectively doing nothing).
Ideally I think we should have just one authoritative #write method and only in the base class (something similar to my approach with #call on the formatters), but this seems quite a big change and I'm not confident I'll be able to test all devices appropriately.
Another approach would be to create a module with a #write method similar to this one:
module CancellableDeviceExtensionExample
  def write(message)
    super unless message.nil?
  end
end

extending the device created in logstash-logger/device.rb. This has the advantage of handling any device with a minimum amount of changes and very little overhead. I would still recommend an eventual redesign of the devices and proper testing, but at least you'll be able to ship the feature beforehand (or even permanently).
If you agree with this approach I can move forward with the implementation.
Best regards.

I think 100% of cases can be handled by modifying LogStashLogger::Device::Base#write and LogStashLogger::Device::Connectable#write without the need for a separate module (which would have to be prepended, further adding to potential confusion). I'm not a huge fan of opaque chains of modules that all call super, since they make debugging quite difficult.

Thanks for the pointer, I think I got a bit worried about the message delegation in devices such as the balancer. I have made the change on the devices you have mentioned and the tests are passing.
The change is relatively small, but I'm not sure how you'd propose to test it. Additionally there is a request for adding documentation, would that entail mentioning this on the main README file?


docs(quickstart): add DNS registrar and Route53 docs for AWS

closes #180
(yes @mboersma this is in first person but just keeping the doc in the same tense as was written :stuck_out_tongue:)

this is in first person

Understood--it's a minor style issue we can try to address comprehensively later. Getting the good content out there is the first priority.


Entity Tick Events

Motivation
Sometimes you want to do something on tick per-entity. Done manually, this involves two mixins, as there are two different code paths for ticking depending on whether the entity is on a vehicle. These events make this far easier.
Content
ServerEntityTickCallback, ClientEntityTickCallback. Also fixes some javadoc in EntityReviveEvents.
Tests
Adds a test for both new events, in the entity events testmod. Zombies will fly in the rain, or place raw iron above them if they're riding something. Slimes constantly emit explosion particles, unless they're riding something.

:thinking: I was sure I had rebased this onto 1.19... I'll redo this in a bit

Javadoc things fixed.

I'm fast-tracking this FCP to Monday (05/12)


 I am aware of this issue from the static code analysis, but I have not faced it as compiler error yet. Anyway, the fix is already being prepared and published soon together with other changes for the next coming official release.

I'm using gcc 9.3.0.

OK, do you have just erpc_arbitrated_client_setup.cpp being part of your project or both the erpc_arbitrated_client_setup.cpp and erpc_client_setup.cpp?

erpc_client_setup.cpp and erpc_arbitrated_client_setup.cpp are both part of liberpc.a. As defined by Makefile.
https://github.com/EmbeddedRPC/erpc/blob/1.7.4/erpc_c/Makefile#L66

yes, ok, let me keep this PR open until my prepared changes are available on the develop branch and evaluated by you then. The change prepared by me is similar to your proposal:
extern ClientManager *g_client;
ClientManager *g_client = NULL;

This seems to be resolved as part of commit 6a571caf6d5042af5d63ff8745f2e4b24e14bc9f although I am interested in hearing an explanation of why this resolves the problem because it appears that there are still two non-static definitions of g_client.  I tried to reproduce a minimal example of this (see attachment) and it fails to link.
extern_test.tar.gz

Actually, I was mistaken.  The  multiple definition of g_client issue seems to still affect eRPC as of a448570

Hello @infn-ke , is the #180 PR by @dpfrey ok for your? If so, could you please close this ticket? Thank you.

Hello @infn-ke , is the #180 PR by @dpfrey ok for your? If so, could you please close this ticket? Thank you.

ok


Expose more ionic date time/picker controller methods

Feature Request
Ionic version:
[x] 4.x
Describe the Feature Request
The current ion date time does not expose all of the classes functions to the angular wrapper. In my case I need to set the valid days based on the current date, NOT the date emited but the current one in the date picker. So I would like to emit every change as an option and expose the method to re generate the column values.
After further investigation with another ionic dev I see that the datepicker is built on top of the picker controller.
Describe Preferred Solution
Add an extra event that emits every value while the datepicker is open.
Expose all functions to the angular wrapper
The request would be a function to refresh column values and to add a handler to each button in the columns
Describe Alternatives
Related Code
Additional Context

I'd say the feature would be to 'support dynamic columns in ion-picker'.
Currently they are all 'static', created when you open the picker.
This causes e.g. bugs like https://github.com/ionic-team/ionic/issues/15794, where if you open with feb-29, the date ranges don't update when you change the month (so can't pick 30 in march).
So from the perspective of that bug, the datetime component also needs to be able to react to selections inside the picker and change the ranges/columns.
So exposing a way (probably through the PickerOption.columns) to get a callback would be nice.
Secondly, allow setting/changing the columns, and have the picker react to these changes while it is open.


Add try, catch for IE11 as it breaks script execution

Issue:
More details - https://github.com/storybooks/storybook/issues/4854, IE11 breaks on change url with security error
What I did
Add try/catch for this case
How to test
Try to load

Is this testable with Jest or Chromatic screenshots? - I think not
Does this need a new example in the kitchen sink apps? - Nope
Does this need an update to the documentation? - I not sure about that

OK, so something is causing a security issue in IE11, would be nice to actually prevent the security issue, but meanwhile merging this can do no harm 👌

Thank you @hmelenok !


chore: update standard-version dependency to 4.0.0

@sipayRT @eGavr @j0tunn
Standard version 4.0.0 includes very useful option called --release-as which value can be major, minor or patch.

https://github.com/gemini-testing/gemini/releases/tag/v4.18.2


Sharing: In light mode "Shared by me" check box is blue in chats/prompt filters. Also need to add tooltip for Filter icon

Switch to Light mode and click on Filter icon on Chat panel -> "Shared by me" check box is blue -> bug

Note: the same is on Prompt panel -> bug
Note: there is no such issue in Dark mode -> ok
Expected result: "Shared by me" check box is light-grey if user is not hovering
Enhancement: Can we add tooltip on Filter icons (chat and prompt) just to be consistent with others buttons

Verified on staging successfully


Kml network links

Added support for onInterval, onExpire and onStop kml refreshes and tests for each of the refresh modes.
Still To Do:

[ ] Fix hack in KmlDataSource.prototype.load to work around a issue with CompositeEntityCollection

Thanks @tfili.  I'll try to take a look at this soon.  Exposing a CompositeEntityCollection from KmlDataSource instead of EntityCollection is technically a breaking change, so we'll probably want to list it as such in changes (as well as the new features).  That being said, it's probably not a big deal unless people are adding/removing entities after the fact.

Awesome work so far.  As we discussed offline, @tfili is going to actually remove the CompositeEntityCollection since we don't need the overhead and non-destructive merging (it also is technically a breaking change).  Once that's fine, I think this should be mostly good to go, but I'll do a full review at that time.

When this is ready for final review, update CHANGES.md to include the full list of new features and behavior.

@mramato I think this is good to go.

Since this is such a major feature, can we include it in the KML Sandcastle demo?

Since this is such a major feature, can we include it in the KML Sandcastle demo?

@pjcozzi Sandcastle demos can't depend on external data, right? What would we do to have data that update? Ship a separate server to run and generate updating KML?

@mramato I'm pretty sure its done for real now. I had an epiphany in the middle of the night that I screwed something up, so it should be good now.

We avoid depending on external data, but some of them do, e.g., Bing Maps.  Is it possible to rig up some data that we could use with our test server?  Or maybe just do a really small change to our test server for this?
This is an important feature for many users so I hate to bury it deep in the reference doc.

We avoid depending on external data, but some of them do, e.g., Bing Maps. Is it possible to rig up some data that we could use with our test server? Or maybe just do a really small change to our test server for this?

No, because cesiumjs.org does not run out test server and therefore won't work.  The best answer is to simply use one of the free dependable (i.e. probably gov organizations) that have data available.  NOAA or similar publishes the current weather map I think.  Otherwise we would have to build and maintain a public server just for this demo.

This is an important feature for many users so I hate to bury it deep in the reference doc.

This doesn't concern me.  Most users already expect it to work, so it won't be buried anywhere.  They have their own KML and when it doesn't load properly they head to the forum.  No one will be looking for this feature because it isn't really an API, they already assume it's there.

I haven't actually ran this yet, but that's it for my initial comments and questions.  I'm a little concerned about performance, but I assume most of that is in the link update processing (which only gets called once every few seconds) and therefore may not be an issue.  We should try and dig up some sizeable examples and profile.

Awesome work @tfili

@mramato I think we are good to go.

Update changes regarding the newly required and deprecated parameters.

4 tests are failing in IE.

That's all I have for this go around.  I think this is pretty close.  Let me know when it's ready for a final look.

@mramato This should be good to go now.

There are some jsHint error that need fixing.

viewerDragDropMixIn needs to be updated to use the options object.

And now you need to merge in master as well.

@bagnell I assume you are fine with the new camera code and tests?  I know you already had a hand in them.
That's it and then we can merge.

@mramato Ok made those last few changes.

Glorious.

Awesome work guys, can't wait to try it out.


Content: Create ReportStream Template for OKTA Activation Email

Problem Statement
As an organization who wants to activate my OKTA account in order to gain access to ReportStream, I would like to see some ReportStream branding in the email that is sent to me for account activation.
Possible Solutions

Create email template for ReportStream based on the Simple Report one but with Reportstream branding

Old. I will be taking lead on setting up new RS Okta instance in #4573.


Open in editor button after saving interactive window to ipynb does nothing if the notebook editor is visible but not active

Create interactive window
Run some code in it
Export to Jupyter notebook
Open in editor. Leave the notebook open
Open interactive window on top of notebook
Export to Jupyter notebook again
Open in editor again
🐛 Notebook isn't foregrounded

does not seem to repro, possibly fixed at some point


Remove jupyter widgets

Fix #62

Remove jupyter-widgets example
Add mention in kernel-output about displaying ipywidgets
Improve kernel-output to execute arbitrary statement - so it could be an ipywidget (should the preview be one?)

Thanks @fcollonval!

Thanks for the review @jtpio


What is the first screenshot of in the README.md?

Trying to figure out what the first screenshot is in the README.md, only clue is "r2cui"  in the Markdown.  Some kind of debugger?

r2cui is an experimental cui for radare2. I've not published it because it's just a PoC I did in a couple of hours.


[python] Add timed request support

Problem
Python cannot send timed requests
Change overview
Add timed request support to chip-repl
Testing

Updated cluster object tests

Where is the logic that ensures that commands that have to be run as timed as defined in schema will always do so?

Thanks for notice, code & tests updated.

fast track: open for a while, created and reviewed by a domain owner, python code is test support code.


Resize, rotate and composite.

Question about an existing feature
What are you trying to achieve?
I want to resize and rotate an image over 1080p and composite it to an 1080p img. But I'm having error:
[Error: Image to composite must have same dimensions or smaller]
When you searched for similar issues, what did you find that might be related?
https://github.com/lovell/sharp/issues/2378
Please provide a minimal, standalone code sample, without other dependencies, that demonstrates this question
 const rotated = await sharp(path)
   .rotate(rotation, { background: { r: 0, g: 0, b: 0, alpha: 0 } })
   .toBuffer();
  const bigImage = await sharp(rotated)
    .resize(6000, 6000, {
      fit: "fill",
      background: { r: 0, g: 0, b: 0, alpha: 0 }
   }).toBuffer();

   await sharp({
      create: {
        width: 1960,
        height: 1080,
        channels: 4,
        background: { r: 0, g: 0, b: 0, alpha: 0 },
      },
    })
      .composite([{ input: bigImage, top, left }])
      .png()
      .toFile(join(outputFolder, "1920x1080.png"));

Please provide sample image(s) that help explain this question

Thank you very much in advance :)

Tried this workaround:

But now I have this error: [Error: Input buffer contains unsupported image format]

OK... nvm, I found a workaround, here's the solution:
// create a "canvas" big enought to fit the "very big img" and the 1080p img
 const canvas =
    await sharp({
      create: {
        width: 4000,
        height: 4000,
        channels: 4,
        background: { r: 0, g: 0, b: 0, alpha: 0 },
      },
    })

      .composite([
        composited1080pImage, // this one needs to be "toBuffer()" and top: 0, left: 0
        compositedVeryBigImage // toBuffer() aswell
      ])
      .png()
      .toBuffer();

     await sharp(canvas) // then you extract the part you need as 1080p :)
      .extract({
        left: 0,
        top: 0,
        width: 1960,
        height: 1080,
      })
      .png()
      .toFile(join(outputFolder, "1960x1080.png"));

Yes, you'll need to clip/crop the images to composite.
https://sharp.pixelplumbing.com/api-composite#composite

The images to composite must be the same size or smaller than the processed image.

I hope this information helped. Please feel free to re-open with more details if further assistance is required.


Code formatting and tests

Description
To ensure that we're moving forward for v1.0.0 release and putting ourselves in a better position with subsequent releases, some changes have been required for formatting and general maintenance. Formatting now follows the prettier standard to ensure that formatting is consistent. Jest tests have been added for utilities - though not for all areas this gives us a good start. Huskey has been updated to allow for tests to be run on push as well as linting checks.
I have also removed the yarn.lock file to encourage more use of npm rather than yarn as a standard.
Change Log

Added prettier and corrected changes resulting from that.
Added jest tests for utilities.
Updated husky and config for v4 -> v7 changes.
Added test runs to husky pre-push.

Checklist (if applicable):

[x] Meets provided linting standards.

Nice pr :)
I tried running the jest tests and a couple failed. The error looked to be the same for all of them see below.

Nice pr :)
I tried running the jest tests and a couple failed. The error looked to be the same for all of them see below.

Looks like Jest is catching the Cypress tests as well. I'll look into exclusion paths.

@con322 This should be fixed now if you would like to review again.

@ampersarnie failed tests have gone from 13 to 9 but some are still failing.

Spoke with Connor about the above, issues were differences in setup and Babel transforms on Node v12 providing false reports for coverage. Node v14 and v16 are known to work. Seen the issue also reported here; https://github.com/facebook/jest/issues/10740


dotnet ef migrations: StyleCop can't load System.Windows.Forms

I have an Asp.Net Core project that builds fine with StyleCop, but when I try to publish it, the step to generate the SQL migration script (command dotnet ef migrations) hits the following error, reformatted for readability:
...\.nuget\packages\stylecop.msbuild\5.0.0\build\StyleCop.MSBuild.targets(101,5): error MSB4062: The "StyleCopTask" task could not be loaded from the assembly ...\.nuget\packages\stylecop.msbuild\5.0.0\build\..\tools\StyleCop.dll.
Could not load file or assembly 'System.Windows.Forms, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089'. The system cannot find the file specified.
Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask.

I'm not sure why StyleCop is applied at this step in the first place, since it's is dealing with auto-generated code.  I'll try to dig out the msbuild target tag.

any news on this? I had the exact same issue.

So one of the things that happens ehre is that the .msbuild version is outdated, you should get the .analyzers version, which will play nicely

Any updates?


Deploy to a few more repositories

We should select 2-3 repositories that bazel steward can support and that may be open to use it. Then we should verify if it works correctly through forks. Then we should open a nice PR with description that we'd like to add such thing to their repository.

Repository
Original url
Fork url

Daml
Link
Link

Grazel
Link
Link

Js-Dossier
Link
Link

SnowBlossom
Link
Link

Arcs
Link
Link

To check result of Bazel-steward go to Fork url ->  Actions -> dependencies

Issue: #24


own images

the pictures in tennis???how to get it ???
if i demo my own video, i have to make it's    format like the 'tennis'??????

You should pass your folder path to the demo.py as a parameter. For example, I put my images into the "my_test" folder under the "data" directory. So I can run the demo.py like this:
python ../../tools/demo.py --base_path='../../data/my_test/images' --resume SiamMask_DAVIS.pth --config config_davis.json

How to select multiple ROI? My input have  multiple ppl coming in each frame how does it work for mutliple ppl

How to select multiple ROI? My input have multiple ppl coming in each frame how does it work for mutliple ppl

I am also looking asnwer for the same question. But maybe this code does not work for multiple ROIs


jest, express mocked get method, called 0 times

🐛 Bug Report
I was trying to test if a correct middlewares are assigned to a specific route. For that, I first needed to check if the router's get method is called. I mocked the express router as follows. And when I test, it fails saying that router.get has not been called.
To Reproduce
router.js
const router = require('express').Router();

router.get('/test', (req, res) => {
    res.json({ message: 'Hello' });
});

module.exports = router;

router.test.js
jest.mock("express", () => ({
  Router() {
    return {
      get: jest.fn(),
    };
  },
}));

const router = require('./router');

it('should call the "get" method', () => {
    expect(router.get).toBeCalledTimes(1);
});

Expected behavior
I have routes that have over 3 middlewares. I want to check if correct middlewares are assigned to them and in right order. I could do this with the help of supertest, but then it would run the code inside my middlewares. To avoid that, I was mocking the router's get method and checking if correct arguments are passed. But, to my surprise, jest says the get method was never called.

I had just set clearMocks: true in the jest.config.js. So, to make it work with that, I wrapped things in beforeEach.


Set target temperature

Hi together,
At the hvac entity I can only set on or off. Its not possible to set the target temperature.
Is it possible to add this entity or do I need to set a variable?

No. You could set the target temperature.

Sorry I did forget to say: I did set up an automation there is no option for the target temperature


GitHub Actions + macOS 10.3

Run meson setup build -Db_coverage=true
  meson setup build -Db_coverage=true
  shell: /bin/bash -e {0}
  env:
    DEVELOPER_DIR: /Applications/Xcode_10.3.app
The Meson build system
Version: 0.56.0
Source dir: /Users/runner/work/simde/simde
Build dir: /Users/runner/work/simde/simde/build
Build type: native build
Project name: SIMDe
Project version: 0.7.0-rc.1

meson.build:1:0: ERROR: Compiler cc can not compile programs.

https://github.com/simd-everywhere/simde/pull/667/checks?check_run_id=1577256946#step:6:16

I don't see that error at the like you posted; maybe it was just a temporary issue, and re-running the build resolved the issue?  I do occasionally see things like xcode failing to install (usually due to something like a network issue or a server being down).

We don't normally build with xcode 10.3, but I tried it out as the clang version is quite different.

Okay, then this isn't really a SIMDe problem, it's a broken/misconfigured xcode installation.  I suppose a meson issue is also possible, but that seems unlikely since from its perspective there isn't really anything different between xcode 10.3 and 11.4.  I'd need to see the error log ($BUILDDIR/meson-logs/meson-error.log, or maybe meson-errors.log, something like that…) to see exactly what the problem is, but if cc can't compile programs at that point it's almost certainly a broken install.

/me is going to close, but feel free to re-open if you disagree… just keep in mind that I don't really have good access to a macOS machine to test on; I'd need to use CI to debug :(


Unexpected behavior when an Observable throws while performing a map and is converted to a promise

RxJS version:
5.0.0-beta.11
Code to reproduce:
http://plnkr.co/edit/EsawlcM58rQfBa8Nuub7?p=preview
In this plunk, I have a simple observable, which I map over. During the map, on the first value, I return Observable.throw. Then I take the result and call toPromise() to it. I expect the resulting promise to be rejected, but it's not.
Expected behavior:
The resulting promise is rejected, just as when you call throw from an observable without mapping over it.
Actual behavior:
the promise is resolved, but it's resolved with a ErrorObservable object
Additional information:

That's cause map returns Observable itself, while it doesn't 'flatteninner observables. I assume what you'd expect isflatMap(ormergeMap`) such as
let o1 = Observable
      .of(42).flatMap(val => {
      return Observable.throw('some error');
    })

o1.toPromise()
  .then((value) => console.log('Resolved!', value, arguments))
  .catch((err) => console.log('Rejected!', err));

Thank you. Sorry this ended up being a "I don't understand" issue.


Cardboard box Blacklist not working. Version 9.1.0

MC: 1.7.10
Mek: Mekanism-1.7.10-<IP_ADDRESS>1
Blacklist is not working for me. Don't know how much simpler my config could be. I was able to pickup stone with the cardboard box with the example config (attached). What am I doing wrong? What information can I provide to fix the problem? This was tested both client and server in a Mekanism only environment.
BoxBlacklist.txt

1.7.10 isn't supported.


Is the docker image published?

Hey @Lissy93 ! Just curious if this image has been published to any registry? I’d be interested to use Dashy, but in my use case I’ll need to be pulling the image. While I can certainly publish it, I’d hate to build the automation around that (or plant a flag in a registry) if this is already done or on your radar.
Thanks for the awesome project!

Hi @turnrye - thanks for raising this, and sorry for the delay in replying.
I don't have much experience in publishing to Docker Hub, so it's taken longer to figure things out. But I will update this issue when it's up and running :)
In the meantime, here is the current published Docker image: https://hub.docker.com/r/lissy93/dashy

Nice, I can give it a try easily now.

Hi Lissy93,
I just happened to stumble upon this repo and read this issue, so I thought I could mention that I experimented with using GitHub Action to build and publish my image to DockerHub just very recently. The process, and result, can be read in here if you fee like it: https://github.com/JonasAlfredsson/docker-nginx-certbot/issues/28#issuecomment-810954953 Hope it can help you in some way :)

Thanks @Lissy93 ! Quick snippet in case someone in the future wants a cut-and-paste of running this in K8S now that the docker image is published:
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: dashy
  namespace: default
  labels:
    app.kubernetes.io/name: dashy
spec:
  replicas: 1
  selector:
    matchLabels:
      app.kubernetes.io/name: dashy
  template:
    metadata:
      labels:
        app.kubernetes.io/name: dashy
    spec:
      containers:
      - name: dashy
        image: lissy93/dashy:latest
        volumeMounts:
        - name: config
          mountPath: "/app/public/conf.yml"
          subPath: "conf.yml"
          readOnly: true
      volumes:
      - name: config
        configMap:
          name: dashy-config
---
apiVersion: v1
kind: Service
metadata:
  name: dashy
  namespace: default
spec:
  ports:
  - name: http
    port: 80
    protocol: TCP
    targetPort: 80
  selector:
    app.kubernetes.io/name: dashy
  sessionAffinity: None
  type: ClusterIP
---
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: dashy
  namespace: default
spec:
  rules:
  - host: dashy.k8s.leb.memhamwan.net
    http:
      paths:
      - backend:
          service:
            name: dashy
            port:
              number: 80
        path: /
        pathType: ImplementationSpecific
---
apiVersion: v1
kind: ConfigMap
metadata:
  name: dashy-config
data:
  # file-like keys
  conf.yml: |
    ---
    pageInfo:
      title: K8S Dashy
      navLinks:
      - title: Home
        path: /
      - title: About
        path: /about
      - title: Source Code
        path: https://github.com/Lissy93/dashy
    appConfig:
      theme: colorful
      fontAwesomeKey: 0821c65656
    sections:
    - name: Getting Started
      items:
      - title: Source
        description: Source code and documentation on GitHub
        icon: fab fa-github
        url: https://github.com/Lissy93/dashy
      - title: Issues
        description: View currently open issues, or raise a new one
        icon: fas fa-bug
        url: https://github.com/Lissy93/dashy/issues
      - title: Demo 1
        description: 'Live Demo #1'
        icon: far fa-rocket
        url: https://dashy-demo-1.netlify.app
      - title: Demo 2
        description: 'Live Demo #2'
        icon: fad fa-planet-ringed
        url: https://dashy-demo-2.netlify.app

Thank you all - this info and help has been really useful :)
Closing the issue, since the Docker image published, but will convert to a discussion so that your info is still easy to find.
The Docker image is up an available on Docker Hub.
It can be used by running: docker run -p 8080:80 lissy93/dashy
Feel free to open a new issue if you have trouble with anything else


Extending with extensions methods (DynamicLinqType attribute)

Hello.
When working with extensions methods, we encountered the following defects (in our opinion):

If several extensions methods are created with the same number and types of arguments, then we get the error "Ambiguous invocation of method ...".
If the base class has an extensions method, then it is not found, the error is "No applicable method ..."
If there is a generic extensions method with the same name, then we also get an error "Ambiguous invocation of method ...".

It is proposed to slightly improve the method FindMethod in a class MethodFinder (System.Linq.Dynamic.Core.Parser.SupportedMethods):

Search extension methods based on the method name.
Search including base classes.
Skip generic methods.

For example, instead (line 55):
                // Try to solve with registered extension methods
                if (_parsingConfig.CustomTypeProvider.GetExtensionMethods().TryGetValue(type, out var methods))
                {
                   ...
                }

Do the following:
                var methods = new List<MethodInfo>();
                foreach (var t in SelfAndBaseTypes(type))
                {
                    // Try to solve with registered extension methods
                    if (_parsingConfig.CustomTypeProvider.GetExtensionMethods().TryGetValue(t, out var methodsOfType))
                    {
                        methods.AddRange(methodsOfType.Where(item =>
                            item.Name.Equals(methodName, StringComparison.OrdinalIgnoreCase) && !item.IsGenericMethod));
                    }
                }
                if (methods.Any())
                {
                   ...
                }

Hi,
I have also run into above issue in my current project. I agree that MethodFinder only uses parameters to match a method and skips it's name.
You can test it by adding:

public static int IncrementMeAlso(this int values)
{
return values + 1;
}

next to IncrementMe method in Utlis class of System.Linq.Dynamic.Core.Tests.Parser.DynamicLinqTypeTest.
ExtensionMethod_NoParameter test will fail.

+1 on this one, practically it turns extension methods into unusable at best, unpredictable at worst.


Allow components inside Trans component

How it works:
<Trans key="welcomeUser">
  {data => <>Hello! <Link to="/profile">{data[1]}</Link></>}
</Trans>

// JSON -> "welcomeUser": "Hello! <1>See my profile</1>"

Due to the way solid-js works, I can't make it be more like how it works in react-i18next.
Reference: https://github.com/mbarzda/solid-i18next/issues/20

Thank you for the contribution! I updated your implementation with optional parse html dependency, added test etc.


How to set css modules with global mode

Now using CSS module requires setting the file name to *. Module.scss. I want the default SCSS file to use CSS module, and *. Global.scss does not use CSS module
I tried to use adjustStyleLoaders of customize-cra to set CSS. Options. Modules. Mode = 'global', but it didn't work

@buffge Post your config, please


[Question] Are there any tools to generate flow types documentation?

I'm really missing a tool to generate html page with all flow types and links to them.
I often forget some keys of some shapes, so I'm always crawling through my flow type definitions to find the type i need, and behink the things i need. And really often i need to send a link to a specific type to a colleague.
Does anyone know if some tool to collect all the types to some pretty html page exists? If there are nothing like that I will do one myself.

documentation has initial support for it but it is a bit limited.  I started ona  webpack plugin to aggregate multiple files to generate a final documentation but haven't had time to continue with it yet.


Fix concurrency issue in TerminalTestReporter

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.07%. Comparing base (b115f39) to head (bf0d88e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4229      +/-   ##
==========================================
- Coverage   64.62%   63.07%   -1.55%
==========================================
  Files         579      579
  Lines       33312    33312
==========================================
- Hits        21527    21013     -514
- Misses      11785    12299     +514

Flag
Coverage Δ

Debug
63.07% <100.00%> (-1.55%)
:arrow_down:

integration
59.73% <100.00%> (-1.78%)
:arrow_down:

production
63.07% <100.00%> (-1.55%)
:arrow_down:

unit
63.07% <100.00%> (-1.55%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines
Coverage Δ

...form/OutputDevice/Terminal/TerminalTestReporter.cs
72.63% <100.00%> (-0.46%)
:arrow_down:

... and 41 files with indirect coverage changes


[TASK] Add github actions to test TEAL

Issue Description
Is your feature request related to a problem? Please describe.
It would be useful to have github actions that test TEAL.

For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.

[ ] 1. Is it tagged with a type: defect or task?
[ ] 2. Is it tagged with a priority: critical, normal or minor?
[ ] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[ ] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[ ] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.

[x] 1. If the issue is a defect, is the defect fixed?
[x] 2. If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[x] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[x] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[x] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

LGTM


How to install?

Hi!
I executed the code in the playground, but I don't see a way to activate the vim mode.

I was in the same predicament with Pharo 7. Then I used Pharo Launcher to
open 6.1. After executing the code in the playground, the vim mode
instantly started working.
Terry
On Fri, Feb 1, 2019 at 1:20 PM itmuckel<EMAIL_ADDRESS>wrote:

Hi!
I executed the code in the playground, but I don't see a way to activate
the vim mode.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/unchartedworks/SmalltalkVimMode/issues/1, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AVjohnh0fjnUFGOkvM8Pc54cQhlyb_Leks5vJKGDgaJpZM4afBG1
.

Hi, to make it work in Pharo 7:
Execute the code as in the README.
Go to Iceberg -> SmalltalkVimMode -> Packages (right click).
You'll see SmalltalkVimMode is not loaded. Right click SmalltalkVimMode -> Load.
Now it should work.


Which version of nas-bench-201 does the code use?

https://github.com/ruocwang/darts-pt/blob/bf3ffdd03f9a4773fee015d5c73a8a38cd0859b7/nasbench201/train_search.py#L394

Here seems missing argument "hp" in api.query_by_arch() according to

https://github.com/D-X-Y/NAS-Bench-201/blob/8558547969c131f75af2725869ff1ece98e98f23/nas_201_api/api_201.py#L118`

Fixed after adding hp argument with 12 or 200
result = api.query_by_arch(genotype, hp='200')

We use the previous version: [2020.02.25]. I was not aware that they changed the query function.
For the newer version, "hp" should probably be 200. I think the 12-epoch version (hp=12) is reserved only for the search phase of RL/EA-based methods (to reduce the search cost).
Thanks for pointing it out!

Problem solved. Thanks for replying.


QMAPS-1761 don't restore last location on load in iframe mode

Description

don't restore last location on load in iframe mode (&no_ui=1)
don't save last location in iframe mode
NB: since pan/zoom is not available in this mode, the app can't save the last visited position, so I only prevented it to be restored.

NB2: I couldn't test this locally as I don't have access to hotLoad API, so can we test it on dev?
Why
To avoid thys flyTo when loading the IA

since pan/zoom is not available in this mode, the app can't save the last visited position,

The map position will be saved anyway if the query triggers a map move (e.g "restaurant à Nice" which requires the map to be centered on the detected zone)


feat: upgrade stacks.js

Upgrade Stacks.js to the latest version
Fix CV to hex conversion
Format contract log using prettyPrint

:tada: This PR is included in version 1.124.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


SSL Handshake Debug Logs not Visible with Graalvm Native Image

Description:
A duplicate of https://github.com/wso2-enterprise/internal-support-ballerina/issues/617

Closing the issue as this has to be fixed from the GraalVM side. Related issue https://github.com/oracle/graal/issues/8564


youtube-dl not picking up .netrc

Checklist

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2020.07.28
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.facebook.com/xxxxxxxxxxxxx/videos/4287339688002603']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2020.07.28
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: ffmpeg 4.0.2, ffprobe 4.0.2
[debug] Proxy map: {}
[facebook]<PHONE_NUMBER>002603: Downloading webpage
[facebook]<PHONE_NUMBER>002603: Downloading webpage
ERROR: This video is only available for registered users. Use --username and --password or --netrc to provide account credentials.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whuxta\build\youtube_dl\YoutubeDL.py", line 797, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whuxta\build\youtube_dl\extractor\common.py", line 530, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whuxta\build\youtube_dl\extractor\facebook.py", line 484, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whuxta\build\youtube_dl\extractor\facebook.py", line 351, in _extract_from_url
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whuxta\build\youtube_dl\extractor\common.py", line 936, in raise_login_required
youtube_dl.utils.ExtractorError: This video is only available for registered users. Use --username and --password or --netrc to provide account credentials.

Description

I've put a config.txt file inside the same folder of the youtube-dl executable that contains
--netrc
In the same folder I've put a .netrc file that contains
machine facebook login "my_address" password "password_that_contains_special_character"
Adding a HOME system variable pointing to the folder in which the three files are placed doesn't help

What's interesting is, my facebook let me know I had logged in from a device that was unrecognized. so it's authenticating but not working somehow.

Read FAQ on where configuration file is supposed to be located.

What's interesting is, my facebook let me know I had logged in from a device that was unrecognized. so it's authenticating but not working somehow.

this


Crash with Skyblock Builder

Mod Name
Skyblock Builder
Mod Homepage
https://www.curseforge.com/minecraft/mc-mods/skyblock-builder
https://www.curseforge.com/minecraft/mc-mods/libx
Describe the bug
Game crashes
Steps to reproduce

Setup Connector and Forgified Fabric API
Install Skyblock Builder and LibX
When creating a Minecraft world in singleplayer, if you change the world type to Skyblock and click Customize to the right, the game crashes.

Logs
https://gist.github.com/BigBull-H3RO/c03e97f1cc66dba4a3ce53452dba109d
Additional context
No response

When i checked up this mod and isues i see that this mod has isue not connector mod, but im not 100% sure

If I disable the Connector and Forgified Fabric API mod. The problem is no longer there. So, it must be a problem with the Connector (Forgified Fabric API) mod.

Fixed in https://github.com/Sinytra/ForgifiedFabricAPI/commit/8ba517a068bf1be75ff03f27a99d4acf56f11d45


Removal request of sensitive content related to Banco Safra/Safra Bank

Dear Sir/Madam,
Our company, AXUR, represents Banco Safra in issues involving the violation of intellectual property and fraud on the Internet.
Banco Safra is the only company authorized to use the trademark SAFRA and owns or licenses numerous trademark registrations worldwide, including, but not limited to the following registration number INPI: 006033504, 810857448, 817834540, 818693363, 820513580, 818473266, 820695858, USPTO: 3150478, 1806382, OHIM: 006017669.
The trademarks, logos, words and phrases registered by Banco Safra shall be exclusively used by Banco Safra and any other use by a third party constitutes a trademark infringement.
It has come to our attention that the reported repository provides related content to the trademark SAFRA without having obtained prior written authorization from Banco Safra. More specifically, this content discloses SENSITIVE DATA from our client or its customer, creating a Likelihood of Confusion between the trademark SAFRA and the reported content.
Here follows the specific lines: 356, 357, 358, 359, 360, 363, 364, 365, 366, 367, 580, 581, 582, 583, 584.
Furthermore, by misusing the trademark SAFRA on your repository, you are also diluting its use, because it weakens the ability of brand identification as a single source of research and may lead consumers to believe that there is some association between Banco Safra and your repository.
Official Website: https://www.safra.com.br/
Considering the violation of intellectual property rights of Banco Safra on your website, we kindly request that you remove all content available on the attached URL(s) which use the abovementioned trademark without having obtained prior authorization.
In order to avoid a lawsuit from a federal court, please, send confirmation that this email was received along with your guarantee to comply with the requests reported above.
Under penalty of perjury, we affirm that AXUR is authorized to act on behalf of the Banco Safra and this notification is in accordance with International Regulations of Internet and Intellectual Property Offices.
Should you require further information or should you prefer to discuss this issue, please do not hesitate to contact us through the e-mail address listed on the signature of this message.
Sincerely,
AXUR
Legal Team
<EMAIL_ADDRESS>ATTACHMENT:
https://github.com/PeterNotenboom/SwiftCodes/blob/master/AllCountries/LU.json

Hi AXUR Legal Team,
Thanks for contacting me.
The lines are removed from the repository/file. I complied with your request.
Note: those Swift codes are publicly available on around 123+ sites (Google search).
Thanks!


Autocompletion: Inconsistent behavior if there is no substring match

This occurred frequently in the C# completion strategy as I was testing, but it is not actually specific to that strategy, as this reproduces in TypeScript as well.
Case 1:
window.| -> choose setTimeout
Expected: window.setTimeout|
Actual: windowsetTimeout|
Case 2:
private _onBufferUpdate(args: Oni.|) -> choose EventContext
Expected: private _onBufferUpdate(args: Oni.EventContext)
Actual:  private _onBufferUpdate(args: OniEventContext|
(note missing parentheses)
It seems that cases where there are characters following the completions are problematic, so need to look at both those cases and evaluate a holistic fix.

Looks like this is resolved by #468 - thanks @keforbes !


feat(r-dependent-packages): add a new feature r-dependent-packages

Close #208
@dpprdan Could you take a look at this? (I am convinced that this is the right design, but I am not sure about the name!)
I assume this will be a simple Feature like https://github.com/rocker-org/devcontainer-features/tree/b24eea2adb7eb39260765f8d0e0cbddc65ac5537/src/r-history, just setting the script to the container.
As far as I know, there is a similar functionality in https://github.com/JuliaLang/devcontainer-features/tree/790b5321727e0b8bfe3bd338749978811c64428b/src/julia.
The lifecycle script just check the DESCRIPTION file exists, and execute something like R -q -e 'pak::pak(NULL, dependencies = "all")'

TODO: cache the package


New scrolling is too slow

Reproduction here: #1384, but basically, add the following line at the end of example_test
await $('EXAMPLE_KEY: at the bottom').scrollTo().tap();

Clone it and run:
patrol test -t integration_test/example_test.dart --dart-define EXAMPLE_KEY="at the bottom"

Observe slow scroll:
https://github.com/leancodepl/patrol/assets/40357511/1f83cb83-4385-4bb6-8f2e-87b7fbbcc29c

We could try setting drag's duration to 0 seconds (or just shorter duration).


Review Elasticsearch Connector

Check all the methods of Elasticsearch Connector.

Refactor would be great in Pipeline and Policy Handlers. See this issue


Update mount secrets to use "target" instead of "dst"

Although dst keeps working, docker/buildkit updated the docs to use target:
https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/reference.md#run---mounttypesecret

do we need to update this on 1.5 as well? (the current version)

@rberrelleza no need, dst also works


Missing link from the 1.42 stable announcement to downloads and examples

OpenUI5 version: 1.42.stable.
SDK Download is not available:
https://openui5.hana.ondemand.com/downloads/openui5-sdk-1.42.16.zip
nor is runtime:
https://openui5.hana.ondemand.com/downloads/openui5-runtime-1.42.16.zip
They should be:
https://openui5.hana.ondemand.com/downloads/openui5-sdk-1.42.6.zip
https://openui5.hana.ondemand.com/downloads/openui5-runtime-1.42.6.zip
This tnt example is mentioned in the blog presentation page but gives 404 as well and is not included in the SDK.
https://sapui5.hana.ondemand.com/test-resources/sap/tnt/demokit/toolpageapp/webapp/index.html
See the blog presentation page:
http://openui5.tumblr.com/post/153635071707/new-release-openui5-142-stable

Please repair the link, I need open ui5 sdk badly.
Thanks

Just use the links that @RobertoMalatesta posted above (section "They should be").

It does not work. Really. Try it.

I did before I posted, fixed one typo (2x runtime, instead of 1x sdk and 1x runtime) and it worked for me.
https://openui5.hana.ondemand.com/downloads/openui5-sdk-1.42.6.zip
https://openui5.hana.ondemand.com/downloads/openui5-runtime-1.42.6.zip
How does it fail for you?

Thanks.

tnt example was listed mistakenly, it is not contained in 1.42.
Links to 1.42.6 have been fixed now.

@codeworrior
for the few who care about the tnt example (I'm one) -- you can find it in the github source and take them from there or do a custom build.
--R


Obsolete API

After importing the asset from the AssetStore it tells me "The project uses obsolete API".

Yes, it is fixed by this commit https://github.com/neuecc/LINQ-to-GameObject-for-Unity/commit/e8b1e2d09a59c293a88ad010ebe7e273ca7e7d25
I'll upload new package on AssetStore.


'--qdf' output scraps previous incremental updates

As you know, PDF includes a feature called "incremental updates".
To see a small example file, download pdf-puzzle (and maybe read the accompanying article by Didier Stevens: 'solving-a-little-pdf-puzzle').
If one simply deletes all lines after the first EOF in the PDF, you've automatically restored the first version of the file (before the incremental update(s) happened).
If you run qpdf --qdf ... on an incrementally updated PDF, the resulting file will no more include the previous versions.
So here are my two wishes for future releases of QPDF:

It would be nice if you could include support for --qdf with PDF files which where incrementally updated.

As long as you can't implement that feature (or in case you are not willing to, for whatever reason), please document this fact.
Please add a clear note/statement to the QPDF manual saying something to this effect: 'The QDF mode does not fully support PDFs which include incremental updates. The output will include the most recent update only, and not the previous file versions.'

In any case, thanks a lot for this beautiful tool, Jay. I very much appreciate it. I love it, and I use it almost daily, mainly to create QDF modes of PDFs I have to investigate and to debug.

I know this issue is almost 10 years old. I was doing some work with digital signatures for an unrelated purpose, and I came back to a need to support incremental updates in some form. After I work on the pages issue, I may come back to this.

Likewise, would be useful to be able to extract versions of a PDF with qpdf. =)

@Manouchehri Yes, I agree. Thanks for the comment.


Added About Page with proposed changes and Button on Navbar

Closes #51
Made the proposed changes to About Page and added a button on the Navbar to navigate to About Page.
Due to a merge conflict, the previous PR was closed so I am creating a new PR with up to date changes.

LGTM!!
Great work @shubhrad1

Thanks @AryanNanda17

@shubhrad1 This looks great to me for now. There are further UI enhancements (because the information is just written down here) and ton of information is not exciting. We would want to make the UI of this page more better and immersive but I think that can be covered in another issue.

This is ready to be merged


welcome.showOnStartup does not effect dev mode

Setting the welcome.showOnStartup to true only effects normally opening the editor, not the dev mode editor.

Just tried this in 1.10 - set the showOnStartup to true and opened with atom -d and welcome displayed just fine.  It's possible it was fixed inadvertently some time between now and when this bug was filed.


Melina's SA missing; True Manifest added but Bertrand's is still highlighted as the newest

Current behavior
All in the title
Expected behavior
No response
Steps to reproduce
Open respective menus
Other information
I don't really understand why this template is necessary, most of the reports here wouldn't need steps to reproduce and current/expected behaviours, just descriptions. But I guess it's Github's problem.

This template is shown because you selected bug report.
Bug report is about something malfuctioning like website crash, not content missing issues.
And also, GitHub Issue is the place for discussing code, not a customer service center.
I don't think that it's wrong.

I'll fix this in a day btw


Exit with status code 1 if cosign is not configured

Please check below, if the PR fulfills these requirements:

[x] The commit message follows the guidelines.
[ ] Tests for the changes have been added (for bug fixes / features).
[ ] Docs have been added / updated (for bug fixes / features).

What kind of change does this PR introduce?

Fails early if cosign is not available. For reference: https://github.com/rancherfederal/hauler/issues/185

What is the current behavior?

If cosign is not properly configured, Hauler will proceed the execution and fail at a later stage:

8:16AM ERR Error: open binaries/cosign-linux-amd64: file does not exist

8:16AM INF syncing [content.hauler.cattle.io/v1alpha1, Kind=Images] to store
8:16AM ERR Error (attempt 1/3): error adding image to store: fork/exec /root/.hauler/cosign: no such file or directory, output:
8:16AM ERR Error (attempt 2/3): error adding image to store: fork/exec /root/.hauler/cosign: no such file or directory, output:
8:16AM ERR Error (attempt 3/3): error adding image to store: fork/exec /root/.hauler/cosign: no such file or directory, output:
Error: operation failed after 3 attempts
Usage:
  hauler store sync [flags]

What is the new behavior (if this is a feature change)?

Hauler will abort execution if cosign is not found / stored at the necessary path.

Does this PR introduce a breaking change?

No.

Another approach would be to move this check only to the relevant subcommands e.g. info doesn't seem to require it. Let me know how you'd prefer to handle this.

@atanasdinov I'm perfectly fine with this solution, but I'm concerned about why cosign would not get configured correctly?
8:16AM ERR Error: open binaries/cosign-linux-amd64: file does not exist

I can confirm that the binary does exist within Hauler to be able to extract and put it <home>/.hauler.  So I'm pretty surprised to see this.

Hi, @amartin120. This came up with our RPM packaging for Hauler. We didn't use the proper path for cosign which in turn contributed to the binary being properly compiled but not working @ runtime.


Feature gate (nested?) disjunctive patterns

Not all BEs support disjunctive patterns/ nested disjunctive patterns. E.g. F* (I believe) supports disjunctive patterns but according to @W95Psp not nested disjunctive patterns.
Right now #304 throws an error in engine/backends/fstar/fstar_backend#337, and thus disallows (nested and top-level) disjunctive patterns, however a better solution is to add disjunctive_pat to features.ml and POp in ast.ml.

You're pointing out something interesting: only nested disjunctive patterns are not possible in F*.
So maybe feature gating those doesn't make sense (since the new construct you added reflects both nested and "simple" disjunctive pats)... I'm not too sure what to think here.

Let's not feature-gate that, that would bring little value and require some (a bit painful / ugly) encoding


Deploy ptsearch on vps issue?

flask route / to ptboard.html.But when access, show Please input your token to access Pt-Board. How to deal with it?

ptsearch is not a vps part project, It's userscript with a front-page (like BT MetaSearch )
If you only want to use pt-search, It's only need the git-page (Which can open in repo settings) and the userscript in docs/js which named ptsearch.user.js.

I know, I have deployed  the PT-help project on vps. and can access ptsearch now.
But when access ptboard, the dialog "Please input your token to access Pt-Board"
I use code in flask:
@app.route('/')
def root():
return app.send_static_file('ptboard.html')

The default Pt-Board app fetch the data from my private  API (Which now need token to access, see this commit https://github.com/Rhilip/PT-help/commit/74b2f37dadcac906d2751a8eeeb5fdf95668dd1e)

To Deploy your own Pt-Board app , you should following those steps:

Install Mysql and set it's seting in flask Config.
restore Mysql database from file : ptboard_record.sql
Use Other script to crawler the publish info from PT-site and record in database. (My crawler script is not public now)
The data stored in database like :

table ptboard_site

table ptboard_record

table ptboard_token

Set your private token in table ptboard_token with length 32.
Change the API url in static file ptboard.html.

Thank your very much. I will follow it.


Update teams-devices-feature-comparison.md

Per PG, PSTN calling isnt available for MTR-W

Per PG, PSTN calling isnt available for MTR-W


[Feature][Manager] Support getByUniqueKey interface

Description
No response
Use case
No response
Are you willing to submit PR?

[X] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Most of interfaces have been done.


fix(app): See How Robot Calibration Works Modal Switched components/constants

Overview
This will fix #10406

Changelog

Updated components/constants in the component

Review requests

Risk assessment
low

Round 1 feedback on modal

I don't think we had a design in our component library for this modal so there are a few things I've had to change.

View the annotated frame on figma

[ ] (1) Update the header to reflect our modal header styling. Font header size should be 14px
[ ] (2) Update to our 'btn-icon/close' component (including states!)
[ ] (3) Missing the line
[ ] (4) Update margin to 24px
[ ] (5) 1rem margin between p and the link
[ ] (6) 0.125 margin between p heading and p text in all three paragraphs
[ ] (7) Updated the formatting of this content (sorry that wasn't in the original design, just updated!)
[ ] (8) Missing the scrolly bar when scrolling
[ ] (9) Update the styling in this button to reflect our primary button component
[ ] (10) Let's give this modal a max-height of 450px
[ ] (11) Use the overflow CTA container (including the white gradient) to hide content


Social: Google Plus

IMO google + should be in the social host file. What do you think about it?

I believe you have a misunderstanding of how this hosts file project works.
It combines several hosts files from other reputable sources who regularly update and curate their lists, to make one massive master list.
It does not add or remove individual entries based on user suggestions - to have something added, you must go and find the curator of the social lists, and ask them to add to their own lists, which will in turn be added here via updates.

Today I learn google plus is still a thing  😸  just kidding.
@StevenBlack I just added google plus to the social media hosts.  I think there must be other related domains but this is the main one.

@mueller-ma @Sinfonietta @kronflux thanks everybody!
Commit 895977 and new build is online now.


Blood Curse of the Fallen Puppet

I just changed the macro in the class feature because it was calling another blood curse, and I changed the hpTempMax to HpValue to temporarily resurrect the creature.

Fixed in v12


Test with monitor

The test now pass. It can be part of the test suite if you think is valuable, otherwise we can just drop it.
P.S. Programming with IO is so much fun! I have to use it more!

This is fantastic! I am so happy to have a test that exercises fd monitoring without the complications of sockets, I've been wanting this for a while.


MM-9849 Disabled system console settings set using environment variables

This disables any system console settings that were set using environment variables as well as migrating a few more of the easier system console pages to the declarative way of defining them.
Since this is based off https://github.com/mattermost/mattermost-webapp/pull/1144, the changes specific to this PR can be viewed here: https://github.com/mattermost/mattermost-webapp/compare/schema-path...mm9849
Ticket Link
https://mattermost.atlassian.net/browse/MM-9849
Checklist

Added or updated unit tests (required for all new features)
Has server changes (please link)
Has redux changes (please link)
Has UI changes

@jasonblais I forgot to get a design for the disabled settings, so I just threw in "This setting has been set through an environment variable and cannot be changed." in red text. Let me know if this works so I can clean up the code for it or if there's something else we'd want to use

@hmhealey Is there a general place we can point admins to configure these settings? It'd be nice to say something like This setting is configured through an environment variable in your config file., since otherwise it sounds like the settings are locked and can never be changed.
@asaadmahmood thoughts on the UI? Instead of red text, perhaps we just add an empty line between the main help text and the This setting is configured through an environment variable in your config file. note?

@jasonblais Yeah I think that makes sense. Or we can have it inside an alertbox below.

@asaadmahmood We could try the alertbox below help text.
However, there is a scenario (outside of GitLab) where all settings on a page could be configured through an environment variable, right? Wondering if the alertbox would be too much below each setting, or if it would still be okay.
/cc @hmhealey

Cool, I'll change it to look like the alert box so we can see how that looks.
@jasonblais Regarding your first question about the text, there's no consistent place environment variables would be defined. GitLab uses gitlab.rb, Docker uses a Dockerfile, and any custom setup could define them wherever they want. If we could detect specific programs, we could add special cases to the text for those, but I'm not sure if that's possible currently.
And for your other question, It's certainly possible that an entire system console page will be defined that way, but I don't imagine it'll be common

@hmhealey Makes sense. Propose changing the text to something like This setting is configured through an environment variable. though just so it doesn't sound like it's permanently locked.

What about "This setting is configured through an environment variable and cannot be changed through the System Console" or "This setting is configured through an environment variable. It cannot be changed through the System Console"? I'm just thinking we could spell out that that's why it can't be changed.

This setting is configured through an environment variable. It cannot be changed through the System Console. sounds like a good compromise, let's go with that.

@jasonblais If that is an option (with everything disabled by the env variable), then we can just add it with the help text at the top.

@jasonblais Oops. I had a combination of both versions there so we were unnecessarily clear that the setting can't be changed

@lieut-data I made setByEnv required by default to make it easier to identify where it was missing. I'm not sure what you mean by your second point, but if you mean some settings like the push notifications server type, that was because the setting doesn't have a 1-1 mapping to the config, but still depends on a config value


input .pcap file in the program

I'm not sure how to run the program. i tried to run it using the terminal python3 pcap2csv --pcap filename.pcap --csv filename.csv and it didnt work. Also, i tried to modify the code to run my files and it didnt work, as follows:
def command_line_args():
"""Helper called from main() to parse the command line arguments"""
parser = argparse.ArgumentParser()
parser.add_argument('--pcap', metavar="/home/PycharmProjects/pcap2csv/filename.pcap",
                    help='pcap file to parse', required=True)
parser.add_argument('--csv', metavar="/home/PycharmProjects/pcap2csv/filename.csv",
                    help='csv file to create', required=True)
args = parser.parse_args()
return args

and it wont run!
can you please help

what errors did you get?

I get no errors, it just hangs.

Same here, it has been hanging for 5 hours. Can you please help?


Updated for newer base docker image & FIELDimageR

Updated README for updates.
Merge pending the updating of the public app on CyVerse

Did you include my suggestions?

@dlebauer Can you remind me what those suggestions were? Thanks


Error "Connection not supported" when using "Toggle device toolbar"

On https://tools.fortifyapp.com/ after downloading several certificates or sometimes even one and updating the page with certificates.
The error "Connection not supported" appears. rebooting, deleting cookies and local storage - do not bring success, the same error is still displayed.
Chrome is up to date
Version 131.0.6778.86 (Official Build) (arm64)
fortify.log.zip
Test_certificate_certificate_2024-11-25_12-30.cer.zip
Details

https://github.com/user-attachments/assets/5da9739a-56d7-4a59-92d6-3526f4278bc8
https://github.com/user-attachments/assets/95e941bc-c764-4a8b-b164-5561c69a1d5d

When the error Connection not supported appears, does the Fortify application continue to work, and is the application icon still present in the system tray? Additionally, can you confirm if https://<IP_ADDRESS>:31337/.well-known/webcrypto-socket is working?

It might be a good idea to catch this error and display a different message. Since Fortify is a desktop application, if someone opens tools.fortify.com on a mobile device, we could show a message indicating that this application is not supported on mobile devices.


Replace FontAwesome usage with built-in icons for StreamField blocks

StreamField only supports SVG icons since v2.15 (https://github.com/wagtail/wagtail/issues/8533). This switches the icon definitions from FontAwesome with SVG icons built into Wagtail.

fa-quote-left becomes openquote.
fa-paragrpah becomespilcrow.
fa-s15 (a bathtub as I recall?) becomes media (same icon used for embeds in Wagtail within rich text.

I’ve updated the existing migrations directly, as the icon is unlikely to be something we’d actively use in a migration anyway.

worth dropping https://github.com/wagtail/bakerydemo/blob/main/requirements/base.txt#L4 while at it

@zerolab this PR only changes icon definitions for StreamField blocks, there are other parts of the UI where we still use FontAwesome

I should stop commenting while ill 🤪
for future ref - FA is used in the bread categories/people menu items, and in the footer

@nickmoreton ty! There are other parts of the UI that still use FontAwesome icons, so no. It’d be nice to remove it eventually.


Unable to use library, window is undefined.

When I try to use the library after installing. I am getting a 500 error from my server saying window is not defined.

If you use the component using nuxt, you can use ClientOnly to render the component correctly.


we are able to view applications in search but not in dashboard of drelephant

Hi All,
We are able to get the application details in search but not in dashboard.

one more thing is it is not showing correct time in UI.

Hi murthykurra,
You are not able to see the applications on Dashboard because of the wrong finished time for jobs. Dashboard only shows applications for last 24 hours. Could you check if the issue is only on the UI or the database is also getting wrong values?
Thanks

Thanks for update.
In mysql database alse we used to see same time.

Is there any way to modify the timing formats in drelephant configurations

@murthykurra , it is not an issue with the format of the date. It appears to me that Dr. Elephant is receiving 0 start time for this application from your Resource Manager. Please verify the data returned by the rest end point of RM.
http:// + ResourceManagerAddress + /ws/v1/cluster/apps?finalStatus=SUCCEEDED


微信交流群

It's already out of dated

It's already out of dated

done!

It's already out of dated


Adding TOPMed to Variant-type tab

Currently in discovery phase.
https://bravo.sph.umich.edu/freeze8/hg38/
SP ticket: https://broadinstitute.atlassian.net/browse/CSP-179

Replaced https://github.com/ClinGen/clincoded/issues/2307


Use the new Ecto.Adapters.Pool

We have just merged it into master.

@josevalim I'm not sure what I'm supposed to do in that case: https://github.com/michalmuskala/mongodb_ecto/blob/master/lib/mongo_ecto.ex#L76
I tried to mirror the SQL adapter, but I'm not sure that's the right thing. With logging in place I will have some string representation of the query, should it be used here?


Controller specs

In this Pull request I have done the following:

[x] Added RSpec as a gem to your project.

[x] Created a Request spec file for all my controllers.

[x] Make sure that for each action you check:

If the response status was correct.
If a correct template was rendered.
If the response body includes correct placeholder text.

Thank you @OyePriscilla, I truly appreciate your time and efforts in reviewing my work


Shows wrong data . verts are to high

v2020.10.27
bl2.83
I just now noticed you showing wrong vert count with high poly models. When i tested you test scene from this repo. The object "un-miyion-oui-monsieur" show much less data than you addons shows.
See below the screengrabs. I think that 'k" at the end should be moved left

The model has the following vertices
1.048.577 verts (blender count)
1.048.57k verts (polycount addon)
Notice the difference according to your count this models should be 10.485.700k
you basicall added k value for and didnt subtract 2digits
ooorrr...
im reading it wrong. Perhaps due to the dots its a but misleading. I guess its the last case. Due to the many dots it looks different. I guess using different dividers should help. Perhaps floating '
So something like 1'048k

yes your last point is the right one: I'm french maybe I have the wrong way of using decimal character "."?
for example I write 2048 or 2 048, for decimal I write 20,48 (identical to 20.48 in code)
so, is 1'048.56k seems right to you? actually it's a semantic question :)

ok, i think i will follow Blender convention, so writing 1,048.56k (equal to 1,048,560) is the way to do, or maybe better, when "k" option is used, i may disable decimals, giving 1,048k like you suggested 👍🏾

https://en.wikipedia.org/wiki/Decimal_separator#Examples_of_use 😅

Yeah its kinda of fuzzy if you see how many different methods there are. I think the point is, is showing those 2 extra decimals it doesnt really matter that much. I mean if you see a big number and its is in K's you kinda need to think about what the actual number is right. I mean with bigger numbers. Perhap if you drop those decimals.
So for instance 2080770 is not 2.088.77k better round that to 2.088k. The thing which is confusing to me is that the dot also also a 1000 seperator but also a decimal. To me at least this is confusing.

really wondering why blenders internal counter is so super fast. But they use C++ internal code probably. This BM mesh makes it kinda slow. I also noticed that other addon make the GUI super slow, he's constantly do panel refreshes and doing lots of calculations, not reallu ideal!

I thought i found a method to make it work instantly using mesh_eval. Sadly this can only pick the vertices and not the tris and area. I also tested a method using scene.statistics() and then stripping that. But it wont show the data properly when i run it with an operator. It doesnt update the scene in between. My idea was to hide every object mesh then run this statistic call. Because in blender it will only show the data of visible objects.

thanks for all your investigations :)
yea in first versions of this addon I was updating stats on every user action, but it was too heavy. I have already in mind to enable user to get automatic refresh, but using a kind of timer and not on every draw, cf #3
About the mesh_eval, if it's allow only vertex count it's not convenient.
About default Blender statistics, your idea could be interesting. However in huge scene, simulation hide/show on every object could probably be lagging too.

Well the show/hide is super fast, but indeed, when its like 100 or 1000s of object it would slow. But that would make this addon as it currently is also slow. For me now its already slow using 2 meshes and around 2 million vertices. Thats not good!
I think it would be better if it only worked on selection, dont you?
I meanif nothing is selected, then there's already Blender default counter.

sorry for the delay, i haven't enough of spare time these days.
i will think about the show/hide option, it can mean a total rewriting.

I mean if nothing is selected, then there's already Blender default counter.

i still want my addon to show per-object stats in a glance

Yeah it's nice yet very slow, especially when scene size is big.
The current method is much easier. Simply hide all other objects.
Isn't that an idea? Make a panel which hides everything see we do see the
current stats. That way you don't need to do the bmesh thing which is
slowing down blender immense
On Fri, 12 Mar 2021, 04:36 Vincent Lamy, @.***> wrote:

sorry for the delay, i haven't enough of spare time these days.
i will think about the show/hide option, it can mean a total rewriting.
I mean if nothing is selected, then there's already Blender default
counter.
i still want my addon to show per-object stats in a glance
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Vinc3r/Polycount/issues/25#issuecomment-797328934,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABU2GABZBRZYATFJMGR5Y73TDHHCTANCNFSM4YPYNCDA
.


@Buildable does not support inheritance

@Buildable
class A {}

@Buildable
class B extends A {}

Error message:
Name clash: The method build(Procedure1<Builder>) of type B has
the same erasure as build(Procedure1<Builder>) of type A but
does not override it.

One possible solution: the build() and copy() static methods could be generated into the nested Builder class instead of directly into the annotated class.

Value objects and inheritance do not mix well. Through subclassing, clients can break the contract of immutabililty. So other clients of the class can no longer be sure that all instances will really be immutable. Could you tell me a little more about your use case?
The proposed solution would break all existing clients and make the API less convenient in the general case.
Another solution would be to allow changing the name of the "build"-method. That would also be interesting for people who like static imports. In your case you could make it buildA and buildB, getting rid of the clash.
A pull request for that feature would be welcome =)