mvn clean install gives error Could not resolve dependencies for project eu.europa.ec.dgc:dgca-verifier-service:jar:latest

mvn clean install gives error when trying in windows 10.
Could not resolve dependencies for project eu.europa.ec.dgc:dgca-verifier-service:jar:latest: Failed to collect dependencies at eu.europa.ec.dgc:dgc-lib:jar:1.1.3: Failed to read artifact descriptor for eu.europa.ec.dgc:dgc-lib:jar:1.1.3: Could not transfer artifact eu.europa.ec.dgc:dgc-lib:pom:1.1.3 from/to dgc-github (https://maven.pkg.github.com/eu-digital-green-certificates/): Authentication failed for https://maven.pkg.github.com/eu-digital-green-certificates//eu/europa/ec/dgc/dgc-lib/1.1.3/dgc-lib-1.1.3.pom 401 Unauthorized -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
Below provided screenshot of settings.xml

username and token as well.

Hi @arunextasy, this is a GitHub authentication issue.
Please ensure the following:

Your GitHub Personal Access Token is configured to allow (read) access to GitHub packages
Settings.xml is actually being used by maven. To that end either

Copy it to your maven (.m2) folder in your user folder (see https://github.com/eu-digital-green-certificates/dgca-verifier-service#github-maven )
Or manually provide it to maven via command line: --settings ./settings.xml

Thanks @daniel-eder that worked. Now Facing build failure error. Below provided complete result.
D:\QRProject\Java\dgca-verifier-service-main5\dgca-verifier-service-main>mvn clean install
[INFO] Scanning for projects...
[INFO]
[INFO] ---------------< eu.europa.ec.dgc:dgca-verifier-service >---------------
[INFO] Building dgca-verifier-service latest
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ dgca-verifier-service ---
[INFO] Deleting D:\QRProject\Java\dgca-verifier-service-main5\dgca-verifier-service-main\target
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.2:check (check) @ dgca-verifier-service ---
[INFO] Starting audit...
Audit done.
[INFO] You have 0 Checkstyle violations.
[INFO]
[INFO] --- license-maven-plugin:2.0.0:download-licenses (download-licenses) @ dgca-verifier-service ---
[WARNING] No license information available for: eu.europa.ec.dgc:dgc-lib:1.1.3
Sep 14, 2021 4:34:24 PM org.apache.http.client.protocol.ResponseProcessCookies processCookies
WARNING: Invalid cookie header: "Set-Cookie: _octo=GH1.1.1835373815.1631617464; Path=/; Domain=github.com; Expires=Wed, 14 Sep 2022 11:04:24 GMT; Secure; SameSite=Lax". Invalid 'expires' attribute: Wed, 14 Sep 2022 11:04:24 GMT
Sep 14, 2021 4:34:24 PM org.apache.http.client.protocol.ResponseProcessCookies processCookies
WARNING: Invalid cookie header: "Set-Cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 14 Sep 2022 11:04:24 GMT; HttpOnly; Secure; SameSite=Lax". Invalid 'expires' attribute: Wed, 14 Sep 2022 11:04:24 GMT
Sep 14, 2021 4:34:27 PM org.apache.http.client.protocol.ResponseProcessCookies processCookies
WARNING: Invalid cookie header: "Set-Cookie: _octo=GH1.1.904858243.1631617467; Path=/; Domain=github.com; Expires=Wed, 14 Sep 2022 11:04:27 GMT; Secure; SameSite=Lax". Invalid 'expires' attribute: Wed, 14 Sep 2022 11:04:27 GMT
Sep 14, 2021 4:34:27 PM org.apache.http.client.protocol.ResponseProcessCookies processCookies
WARNING: Invalid cookie header: "Set-Cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 14 Sep 2022 11:04:27 GMT; HttpOnly; Secure; SameSite=Lax". Invalid 'expires' attribute: Wed, 14 Sep 2022 11:04:27 GMT
Sep 14, 2021 4:34:31 PM org.apache.http.client.protocol.ResponseProcessCookies processCookies
WARNING: Invalid cookie header: "Set-Cookie: _octo=GH1.1.625547193.1631617471; Path=/; Domain=github.com; Expires=Wed, 14 Sep 2022 11:04:31 GMT; Secure; SameSite=Lax". Invalid 'expires' attribute: Wed, 14 Sep 2022 11:04:31 GMT
Sep 14, 2021 4:34:31 PM org.apache.http.client.protocol.ResponseProcessCookies processCookies
WARNING: Invalid cookie header: "Set-Cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 14 Sep 2022 11:04:31 GMT; HttpOnly; Secure; SameSite=Lax". Invalid 'expires' attribute: Wed, 14 Sep 2022 11:04:31 GMT
Sep 14, 2021 4:34:43 PM org.apache.http.client.protocol.ResponseProcessCookies processCookies
WARNING: Invalid cookie header: "Set-Cookie: _octo=GH1.1.562390916.1631617483; Path=/; Domain=github.com; Expires=Wed, 14 Sep 2022 11:04:43 GMT; Secure; SameSite=Lax". Invalid 'expires' attribute: Wed, 14 Sep 2022 11:04:43 GMT
Sep 14, 2021 4:34:43 PM org.apache.http.client.protocol.ResponseProcessCookies processCookies
WARNING: Invalid cookie header: "Set-Cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 14 Sep 2022 11:04:43 GMT; HttpOnly; Secure; SameSite=Lax". Invalid 'expires' attribute: Wed, 14 Sep 2022 11:04:43 GMT
Sep 14, 2021 4:34:50 PM org.apache.http.client.protocol.ResponseProcessCookies processCookies
WARNING: Invalid cookie header: "Set-Cookie: _octo=GH1.1.1377034212.1631617490; Path=/; Domain=github.com; Expires=Wed, 14 Sep 2022 11:04:50 GMT; Secure; SameSite=Lax". Invalid 'expires' attribute: Wed, 14 Sep 2022 11:04:50 GMT
Sep 14, 2021 4:34:50 PM org.apache.http.client.protocol.ResponseProcessCookies processCookies
WARNING: Invalid cookie header: "Set-Cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 14 Sep 2022 11:04:50 GMT; HttpOnly; Secure; SameSite=Lax". Invalid 'expires' attribute: Wed, 14 Sep 2022 11:04:50 GMT
Sep 14, 2021 4:34:51 PM org.apache.http.client.protocol.ResponseProcessCookies processCookies
WARNING: Invalid cookie header: "Set-Cookie: _octo=GH1.1.1589514059.1631617490; Path=/; Domain=github.com; Expires=Wed, 14 Sep 2022 11:04:50 GMT; Secure; SameSite=Lax". Invalid 'expires' attribute: Wed, 14 Sep 2022 11:04:50 GMT
Sep 14, 2021 4:34:51 PM org.apache.http.client.protocol.ResponseProcessCookies processCookies
WARNING: Invalid cookie header: "Set-Cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 14 Sep 2022 11:04:50 GMT; HttpOnly; Secure; SameSite=Lax". Invalid 'expires' attribute: Wed, 14 Sep 2022 11:04:50 GMT
[WARNING] There were 1 download errors - check the warnings above
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.6:prepare-agent (default) @ dgca-verifier-service ---
[INFO] argLine set to -javaagent:C:\Users\VVSA\.m2\repository\org\jacoco\org.jacoco.agent\0.8.6\org.jacoco.agent-0.8.6-runtime.jar=destfile=D:\QRProject\Java\dgca-verifier-service-main5\dgca-verifier-service-main\target\jacoco.exec
[INFO]
[INFO] --- spring-boot-maven-plugin:2.4.4:build-info (default) @ dgca-verifier-service ---
[INFO]
[INFO] --- maven-resources-plugin:3.2.0:resources (default-resources) @ dgca-verifier-service ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Using 'UTF-8' encoding to copy filtered properties files.
[INFO] Copying 7 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ dgca-verifier-service ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 17 source files to D:\QRProject\Java\dgca-verifier-service-main5\dgca-verifier-service-main\target\classes
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  45.801 s
[INFO] Finished at: 2021-09-14T16:34:52+05:30
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project dgca-verifier-service: Fatal error compiling: invalid target release: 11 -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

@arunextasy this project is set up to use java 11 (in pom.xml). Make sure maven is running with Java 11 (i.e. install it if not present and set JAVA_HOME correctly). Please note that this is a general maven issue and not project specific, so we don't really have the resources to support this. Please see https://stackoverflow.com/questions/63154787/maven-is-not-using-java-11-fatal-error-compiling-invalid-target-release-11 for further information

thanks @daniel-eder It worked. Can you please help me with https://github.com/eu-digital-green-certificates/dgca-verifier-service/issues/64 issue to work with eclipse.

I've assigned #64 to one of our devs - i did not look into it yet, but as there is no similar issue here yet, I suspect this is an eclipse specific issue. Until someone gets back on your ticket, please try a Google/stack overflow search for the error message, there might be a general solution.

@daniel-eder Can you please mention which IDE and version your team is using for accessing this code?


Download missing incremental snapshots

@marcinwadon , does this affect my work regarding downloading and peer discovery (PRs #630 and #629)? Also, please update the branch.

yes


python3Packages.ytmusicapi: 0.17.3 -> 0.18.0

Motivation for this change
https://github.com/sigma67/ytmusicapi/releases/tag/0.18.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 129316 at 6ecc0d98 run on aarch64-linux 1

4 packages built successfully:

python38Packages.ytmusicapi
python39Packages.ytmusicapi
spotdl
ytmdl


breaking here caused issue 38 for me because buffers werent flushed

I had the same error as in #38 and tracked it down to being this break. I think that having a break here prevents the buffer from being read when the buffer isn't a complete multiple of 8192. Commenting out this line fixed the issue for me.

I wonder, why does it work for chef 11.18 ? Did you try it with that version?

I got the same error (byte counts being the only difference) when testing using Chef 11.18 (Chef-DK 0.3.6) as I initially tested (on Chef 12.03 via Chef-DK 0.4.0):
This PR has been tested to fix both versions.

When should the loop stop?  When you remove this break it seems like the loop will just run infinitely.

The loop stops in this case because .read() gets an EOF signal from the underlying Socket object. This is similar to how reading a file from disk in Ruby, line-by-line, stops automatically when you reach EOF. Check out this example: http://ruby-doc.org/stdlib-2.1.0/libdoc/socket/rdoc/TCPSocket.html

Yeah, but I think you need to have a while loop for that to happen.  loop do literally loops forever.  You probably need something like while to_server.read(8192, buff) instead of loop to make it stop.

@shaneramey I agree with @jkeiser  - can you try his suggested while loop and see if that works for you?

@shanramey I went ahead and made the while modification, and also added a begin / rescue that will print the error if an error happens (which is probably why you weren't seeing it).  I haven't got a chance to run it yet.  Would you mind putting it through your case and see if things are still working for you?  If so we'll get er done.

@jkeiser where is your code that has the modifications?

@tyler-ball oh!  It's in the https://github.com/chef/chef-provisioning-docker/tree/jk/issue38 branch.

@shaneramey could you try the above branch and see if it fixes things?

/cc @ofross
https://github.com/chef/chef-provisioning-docker/tree/jk/issue38 solves our ContentLengthMismatch issues that occurred only in local mode (-z).  These issues did not occur with standalone chef-zero on <IP_ADDRESS>.
setup
jk/issue38 branch, tweak version and relax constraints on chef-provisioning so this will work with chefdk 0.5 series (coloring outside lines?)
[cbuben@cbloki1 chef-provisioning-docker]$ git rev-parse HEAD
6fa5c79d4cdc58fa7e26af6cbdbbca9f90c10bec
[cbuben@cbloki1 chef-provisioning-docker]$ git diff
diff --git a/chef-provisioning-docker.gemspec b/chef-provisioning-docker.gemspec
index a84d217..9528871 100644
--- a/chef-provisioning-docker.gemspec
+++ b/chef-provisioning-docker.gemspec
@@ -3,7 +3,7 @@ require 'chef/provisioning/docker_driver/version'

 Gem::Specification.new do |s|
   s.name = 'chef-provisioning-docker'
-  s.version = Chef::Provisioning::DockerDriver::VERSION
+  s.version = Chef::Provisioning::DockerDriver::VERSION + "-issue38"
   s.platform = Gem::Platform::RUBY
   s.extra_rdoc_files = ['README.md', 'LICENSE' ]
   s.summary = 'Provisioner for creating Docker containers in Chef Provisioning.'
@@ -13,7 +13,7 @@ Gem::Specification.new do |s|
   s.homepage = 'https://github.com/opscode/chef-provisioning-docker'

   s.add_dependency 'chef'
-  s.add_dependency 'chef-provisioning', '~> 0.9'
+  s.add_dependency 'chef-provisioning'
   s.add_dependency 'docker-api'
   s.add_dependency 'sys-proctable'

before
[cbuben@cbloki1 ~]$ rpm -q centos-release docker chefdk
centos-release-7-1.1503.el7.centos.2.7.x86_64
docker-1.6.0-1.el7.x86_64
chefdk-0.5.0-1.el6.x86_64

[cbuben@cbloki1 local_promo_pricing_transformer]$ chef gem list chef-provisioning-docker

*** LOCAL GEMS ***

chef-provisioning-docker (0.5.2)

[cbuben@cbloki1 local_promo_pricing_transformer]$ chef-client -z recipes/docker_isolation.rb
[2015-05-12T10:33:03-04:00] INFO: Auto-discovered chef repository at /home/cbuben/local_promo_pricing_transformer
[2015-05-12T10:33:03-04:00] INFO: Started chef-zero at http://localhost:8889 with repository at /home/cbuben/local_promo_pricing_transformer
  One version per cookbook

...

    [2015-05-12T10:34:56-04:00] INFO: cookbook_file[/opt/jcollectd/jar/collectd.jar] created file /opt/jcollectd/jar/collectd.jar

    ================================================================================
    Error executing action `create` on resource 'cookbook_file[/opt/jcollectd/jar/collectd.jar]'
    ================================================================================

    Chef::Exceptions::ContentLengthMismatch
    ---------------------------------------
    Response body length 8006 does not match HTTP Content-Length header 52055.
...

after
[cbuben@cbloki1 ~]$ rpm -q centos-release docker chefdk
centos-release-7-1.1503.el7.centos.2.7.x86_64
docker-1.6.0-1.el7.x86_64
chefdk-0.5.0-1.el6.x86_64

[cbuben@cbloki1 local_promo_pricing_transformer]$ chef gem list chef-provisioning-docker

*** LOCAL GEMS ***

chef-provisioning-docker (0.5.2.pre.issue38)

[cbuben@cbloki1 local_promo_pricing_transformer]$ chef-client -z recipes/docker_isolation.rb
[2015-05-12T10:38:27-04:00] INFO: Auto-discovered chef repository at /home/cbuben/local_promo_pricing_transformer
[2015-05-12T10:38:27-04:00] INFO: Started chef-zero at http://localhost:8889 with repository at /home/cbuben/local_promo_pricing_transformer
  One version per cookbook
...
[2015-05-12T10:44:36-04:00] INFO: Chef Run complete in<PHONE_NUMBER>55 seconds

Running handlers:
[2015-05-12T10:44:36-04:00] INFO: Running report handlers
Running handlers complete
[2015-05-12T10:44:36-04:00] INFO: Report handlers complete
Chef Client finished, 1/1 resources updated in<PHONE_NUMBER>19 seconds

Rebased and pushed as 3a4716f

Thanks @jkeiser!  Believe https://github.com/chef/chef-provisioning-docker/issues/38 is a dup; might want to close that one too.


Automation: Tour of Beam infrastructure deployment

PR goal:
Creation of Tour of Beam infrastructure using Terraform, Flutter, FIrebase and Kotlin Gradle.
• Terraform script that creates Tour of Beam backend
• Flutter and Firebase commands which create Tour of Beam frontend
• All wrapped into the Kotlin Gradle script
R: @olehborysevych
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.


fix(packaging): fixes packaging issue

:tada: This PR is included in version 1.37.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


librarycarpentry/lc-r

This serves as the log to record issues in the https://github.com/LibraryCarpentry/lc-r lesson:

Explicit <figure> tags around the R Markdown chunks to produce figures https://github.com/LibraryCarpentry/lc-r/pull/85
discontinuous block quotes, which is not a problem for kramdown, but is a problem for commonmark.
a. first example block
b. second example block
The setup code is kept within bin/ and needs to be moved to episodes/files

fixed in 91f7dddc596f35b09788524c05c008b9288e2cb0


Make active button more visible

To make it easier to immediately spot which version is Active, I would like the button to be filled. Chose a blue color since the text was blue previously.

@geirsagberg I tilfelle du ikke har sett denne PR-en :)


feature request: work with GIF

I sometimes do gifs recordings with peek.
Would be great, if when Pastify is executed, if the clipboard text matches a image extension, like *.gif or file://*.gif or *.jpg or any other image extension, it would just take this text as a filename and copy it into assets directory and insert the Markdown text.
On another small note, could add text to README like "To use this plugin, use :Pastify command, which will take the clipboard content and paste it". There are two movies, but no text description, only installation and config, it got me confused for a second.
Thanks! Great plugin!

thank you for your issue.
As for the first part, basically, I don't know if this is possible. I basically copied a GIF and pasted it into the pastify with this debugging code.
    def paste_text(self) -> None:
        options = self.config['opts']
        img = ImageGrab.grabclipboard()
        if img is None:
            self.logger(
                "No image in clipboard.", "WARN")
            return

        img_name = img.format

        self.logger(f"image format: {img_name}", "INFO") # Always PNG

as you can see, this should print GIF if it is one but from lots of different file types it converts them to a png with metadata. If I could access that metadata than I could probably figure out the type.
As for the second issue I will update the readme now.

Also I would like to add that this was the exif of the image for many different images and types.
ResolutionUnit:2
ExifOffset:78
XResolution:144.0
YResolution:144.0
        image_exif = img.getexif()
        if image_exif is None:
            print('Sorry, image has no exif data.')
        else:
            for key, val in image_exif.items():
                if key in ExifTags.TAGS:
                    with open(f"...", "a") as f:
                        f.write(f'{ExifTags.TAGS[key]}:{val}\n')
                else:
                    with open(f"...", "a") as f:
                        f.write(f'{key}:{val}\n')


Debugging in Intellij

A quick question . How do I debug this in Intellij without exporting as jar everytime to libs folder of  Kafka.  Iam using apache kafka. I want to check the code flow in Intellij. Is there anyway to do this.

Hi @vishnu-chalil,
99% of cases it's enough simulating what Kafka Connect does. For that I'd recommend you take a look at the following test:
https://github.com/castorm/kafka-connect-http/blob/master/kafka-connect-http-test/src/test/java/com/github/castorm/kafka/connect/http/HttpSourceConnectorIT.java
That test runs a WireMock server with some mocked responses, you can skip that part if you want to hit the real API.
What I want you to focus on is the next bit, where it reads all records from your connector, simulating the connector lifecycle:
Map<String, String> config = getConfigMap(replaceVariables(readConnectorConfig("connectors/connector1.json"), properties));

List<SourceRecord> records = readAllRecords(config);

All those are static methods available here:
https://github.com/castorm/kafka-connect-http/blob/master/kafka-connect-http-test/src/test/java/com/github/castorm/kafka/connect/ConnectorUtils.java
I hope this helps.
Best regards.

Yeah sure it helps but I wanted to know if there is a debugging mode or similar mechanism to check the code flow like checking the code flow in spring boot application.

That's what I was trying to say, once you do as I said, you can then debug your test, adding any breakpoints you might like.

I understood it but didn't understand how to debug the flow the files inside the records package etc. from what point in execution are those files acessed, what are their functionalities etc. Do correct me if Iam asking the same question. But I couldnt yet understand how to debug through those.

Thanks Castrom. What you said is making sense once I started working on it. Saved my day :)


Retained Grape::Http::Headers in memory instead of new ones created.

I ran a memory profiling (memory_profiler gem) on my app by hitting our Grape api first. I found it odd that it retains a bunch of http verbs when they are defined as const in Grape::Http::Headers :
       354  "HEAD"
       353  /Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/grape-1.2.6/lib/grape/router/route.rb:67
         1  /Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/grape-1.2.6/lib/grape/router.rb:30

       352  "GET"
       351  /Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/grape-1.2.6/lib/grape/router/route.rb:67
         1  /Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/grape-1.2.6/lib/grape/router.rb:30

       168  "POST"
       107  /Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/grape-1.2.6/lib/grape/router/route.rb:67
        60  /Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/grape-1.2.6/lib/grape/api/instance.rb:230
         1  /Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/grape-1.2.6/lib/grape/router.rb:30

       113  "PATCH"
        82  /Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/grape-1.2.6/lib/grape/router/route.rb:67
        30  /Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/grape-1.2.6/lib/grape/api/instance.rb:230
         1  /Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/grape-1.2.6/lib/grape/router.rb:30

        50  "DELETE"
        46  /Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/grape-1.2.6/lib/grape/router/route.rb:67
         3  /Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/grape-1.2.6/lib/grape/api/instance.rb:230
         1  /Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/grape-1.2.6/lib/grape/router.rb:30

        43  "PUT"
        34  /Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/grape-1.2.6/lib/grape/router/route.rb:67
         8  /Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/grape-1.2.6/lib/grape/api/instance.rb:230
         1  /Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/grape-1.2.6/lib/grape/router.rb:30

I looked at the code and made a fix by detecting supported_methods instead of retaining the route method received.
Actual memory footprint on first call
Total allocated: 50532358 bytes (526479 objects)
Total retained:  6386850 bytes (17587 objects)

And with the improvement
Total allocated: 50453158 bytes (524521 objects)
Total retained:  6346610 bytes (16603 objects)

1958 less objects allocated (79 200 bytes)
984 less objects retained (40 240 bytes)

So for your example it's 80K. How much slower is endpoint mounting?

A lot of endpoints .. Is there an easyway to count them ? Like Grape::Api.endpoints.count ?
For the endpoint mounting, i'll benchmark my app boot time.

A lot of endpoints .. Is there an easyway to count them ? Like Grape::Api.endpoints.count ?

I am not sure, but I think .routes will get you started :)

For the endpoint mounting, i'll benchmark my app boot time.

Let us know when you're ready/happy with this PR! Looking forward to merge.

I dont know why but now I'm just 2x slower instead of almost 6
Warming up --------------------------------------
Hash with case insensitive
                       309.328k i/100ms
              detect   173.918k i/100ms
Calculating -------------------------------------
Hash with case insensitive
                          7.785M (± 4.9%) i/s -     38.975M in   5.021621s
              detect      2.699M (± 1.0%) i/s -     13.566M in   5.026560s

Comparison:
Hash with case insensitive:  7785176.2 i/s
              detect:  2699078.6 i/s - 2.88x  slower

Anyway, the reality is having a case-insensitive hash is really hard (no easy way). I mean we would upcase everything like before but we wont have a substantial gain (less memory usage) anymore. Also, since its a static array, worst case scenario is O(7). So, I'm not sure the 2x slower is a big issue here.

I don't think it's a big issue, I was just trying to make this code simpler. Your call.

I merged this, thanks.


CB-12871: Re-sizing data lake from light -> medium.

With the changes made one can re-build the data lake with a different shape. Below is the new flow chain for re-sizing.
stop-existing DL -> Detach it from the environment -> Create new DL with requested shape -> delete the detached DL.
There could be a failure in any of these flows. These changes don't have implementation for recovery from these failures.
There is a separate Jira created for changes needed to have a recovery mechanism.

Can't see any integration test and e2e test. Without these we can't merge it, I don't want to suffer the same as for HA medium-duty, where repair and upgrade scenarios were not tested and we had to disable and rework the feature after it was released.

Hello Peter, These changes are not ready to be delivered to the customers. This is one of the first commits. Other commits will follow this. I tried to get the e2e tests working locally but will have the tests added in the next few weeks. I have created a separate task for it. Let's not block this patch for e2e tests.

We can merge it but please create a jira ticket, not only for e2e but please do mock integration tests also.

We can merge it but please create a jira ticket, not only for e2e but please do mock integration tests also.

done.


Jackson JsonNode reflection generates duplicate value in 'required' array

No snippet for this, sorry, but the behaviour is very simple to explain:

Define a type that contains a property that is a Jackson JsonNode
Mark a controller with an annotation of OpenApiContent with from your type
View generated OpenAPI docs, required field in the schema for the discovered JsonNode type will contain two entries for the empty property (derived from isEmpty method).

Potential reason for this: JsonNode is an abstract class and isEmpty is overridden in child classes. BUT: there are other properties treated similarly and they are not duplicated in the output.
Overall though: what is a better way to deal with this? Most of the discovered fields for the JsonNode (and other types, mind you) are certainly not required. I'd be inclined to lean on the side of permittivity myself: don't put anything in required unless the user opts in somehow (obviously does not help for library classes like this one!!).

Well, the issue here is that I'm not quite sure why there's a JsonNode as a property in the dto that will be serialized/deserialized to body. Responses should be mapped to plain Java objects, and that's how this plugin interprets them at compile-time. By default, each non-null property is marked as required, and it makes sense, because we don't want to assign null/missing properties to type-safe non-null fields in our data classes.

Not disagreeing that in a perfect world, everything could be converted to a POJO or POKO, but in this case, it's a convenience to treat the JsonNode as an arbitrary piece of JSON that will be interpreted by a piece of software further down the chain. All we care about is that it is in fact, legal JSON.
Perhaps the solution to my issue is to remove the ambiguity here for the parsing: I always expect a JSON object, therefore I can choose a specialisation of JsonNode (ObjectNode) which will presumably help method resolution for required. Even so, maybe now is a good time to ask a question: if i wanted to instruct the plugin to never attempt to derive required fields etc for a given type, is there a way to do that?
I presume I'd have to influence kapt rather than add a runtime call someplace?

I guess you just do sth like that:
@OpenApiPropertyType(Object::class, nullable = Nullability.NULLABLE)
JsonNode jsonProperty;

If it may contain various nested json object. Object will tell OpenApi to not generate any fields from JsonNode & nullable type will exclude it from required properties.


Featuresupport update.


Version for runtime changed from 3 to 4

The old value (3) will lead to the error
"Could not find a runtime version for runtime {} with functions version {} and os {}Run 'az functionapp list-runtimes' for more details on supported runtimes." For PowerShell based apps the runtime version needs to be set to 4.

@ggailey777
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@hsirtl great catch, and thanks for providing the fix! #sign-off


Enable Iframe Fullscreen

Context
Currently when Iframes are rendered there is an issue with allow fullscreen.
Expected Behavior
User can expand a rendered iframe to full screen.
Current Behavior
Fullscreen is disabled
Steps to reproduce
in the editor, go to a newline, click the + icon and add an iframe. copy and paste a youtube link, click preview.
Additional info
The problem is likely with dom-purify and not allowing 'allowFullscreen'. - check SlateEditor.tsx It could also be a problem when we parse the html string into html - check the parse method in pages/create.

I would like to take this!


Value of  the "routable" variable of the page header has no effect.

Page header variable routable does not affect the corresponding page attribute.

Not entirely sure what i'm looking at.  but the header value doesn't always set the internal state of the Page 100% 1 to 1.  For example for modular pages, you can set that to be routable, but the internal code will override this and set the internal state to be routable=false because modular pages cannot be routable.

Ok, I just thought that page.routable for the error page should return false and that if I set routable: false in header for some (non modular) pages the following statements:
{% for child in page.children.routable %}
...
{% endfor %}

or
{% for child in page.children if child.routable %}
...
{% endfor %}

will work.
But they don't work, they list all pages including those for which I set routable: false.

Ok now you have provided some more information, i can test that scenario.

Well, there was a legitimate issue that I introduced in the last version with some refactoring.  This should be sorted for the next release.  Thanks!


Uglifyjs setting in README is different from code

I am using Uglifyjs to handle JS files. From README, I need to set UGLIFYJS_BIN. However from our code, it checks if UGLIFY_BIN exists.
I only changed compress_assets.py instead of README, because UGLIFYJS_BIN and CLEANCSS_BIN have the same lengths :)

This patch is correct. Thanks for catching this!


Fix problem where API Collections had no roleHeading assigned

Bug/issue #, if applicable: rdar://90789460
Summary
The eyebrow title for articles curating a list of symbols should display 'API Collection'. Prior to this fix, the eyebrow did not show anything.
'API Collection' now appears whenever one of the curated items in the Topics section is a symbol. If the entire list does not contain a symbol (i.e., it's a plain collection), we maintain the old behavior of not displaying anything as the eyebrow title.
Dependencies
N/A
Testing
Steps:

Create a markdown file inside a doc catalog that curates multiple symbols under the Topics section.
Preview the documentation
Check that the markdown file has an eyebrow title displaying 'API Collection'

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[X] Added tests
[ ] Ran the ./bin/test script and it succeeded
[ ] Updated documentation if necessary

Closing this pr in favour of https://github.com/apple/swift-docc/pull/754


Make wild command run async

Hello, I run https://earthmc.net and I really enjoy your plugin. Unfortunately the server freezes for everyone while the plugin is trying to find a wild-location. It would be very much appreciated if you could make this process async.

Kinda of a known issue I am looking into potential fixes

I will paypal anyone 15$ able to patch this issue.

Im working on something currently it has reduced the lag to about 1 sec to almost instant in most cases if you would care to test just tell me

@FixTheAdmin Would you mind testing the new version I'm working on https://github.com/Qballl/WildernessTp/raw/TempFix/target/WildTp.jar I need a larger sample size other than me with my local server that is running my client and like 30 chrome tabs

The build works much better! It does not seem to check bioms though

That is great to know. Are you getting any lag at all? Also, the biome thing is probably me forgetting a line of code I recoded a decent amount of the location search for this.

The lag is not noticeable with over 100 players online, well done. When the biome check gets back there is nothing to complain about.

That is great to hear. Please tell me all the problems so far. Also by biome check you mean like /wild Plains and then going to plains only?

Sorry for being unclear. I have several blacklisted biomes in the config file but players still spawn in blacklisted biomes.

Thanks for clarifying I shall look into it

Redownload from the link above it should include the blacklist biome.

Players are still spawning in blacklisted bioms

Alright I will have to look into this


feat: added parcial phone format support

Added function to format parcial string when user is typing phone number.
Function name: format
Params: value and region

Thanks @ajzuse for this PR ! I was meaning to implement the partial formatting bit but never got the time to do it.
I'll review it in the next few days :)


Starting WSL from "C:\Program Files\WSL\wsl.exe" in ssh session breaks my systemd service

Windows Version
10.0.22621.2283
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
22.04
Other Software
Python 3.10
Custom 3rd Party Software (C-based DLL)
Repro Steps
Sorry, 3rd party software a block here. Just wanted to report though in case it is useful or anyone has any ideas. I realize solutions may be difficult.
Expected Behavior
Running a python-based systemd service after starting wsl through C:\Program Files\WSL\wsl.exe should work the same as it does when running from desktop (not session 0) using C:\Windows\system32\wsl.exe
Actual Behavior
My python code running in systemd works fine up until it tries to use a function from a 3rd party dll. The dll is loaded from python using ctypes.cdll.LoadLibrary, and on calling a function from said library I get OSError: exception: access violation reading 0x0000000000000000. I realize this is not helpful. I double-checked and was able to repeat this behavior, toggling back and forth between starting wsl through an ssh session (program files version) and through remote desktop (system32 version). Furthermore the 3rd party doesn't write particularly good code... so I wouldn't be surprised if this is due to the specifics of how this dll was compiled.
I know there is some amount of work being done to resolve the inconsistency between the system32 wsl and program files wsl. I just hope that this resolves the issue and doesn't spread the issue to both methods...
Diagnostic Logs
No response

Thank you for reporting this @aquirdTurtle. Can you share an strace of the command when it fails and when it suceeds to we can figure out what the difference comes from ? (strace -f )


Localization for renderers

We don't really have a good story for this for webviews right now either. We should figure out what to do here.

This should still be an eventual thing, but closing it for now as it's just being snowplowed.


Add profiling for each method called in CDEAPISession

Testing for capturing each methods timings

Testing for successful session being logged

Testing for failed run being logged

Also updated .venv to reflect appropriate snowplow api key

Hey why do we have .env checked in here? I though that was in .gitignore

Are we not checking this in code and only checkig in through a release ?

If we can refactor this code as discussed offline with moving out timer variables, it would be good to go.


marktext: init

Motivation for this change
https://marktext.app is a great editor.
Long-term it would be great to package it without using the AppImage binary release (see https://github.com/marktext/marktext/issues/1647), but until that's done, this is a workaround.
I used the notable package by @dtzWill as a template. It is also an AppImage.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

LGTM! It'd be best to not package an -rc2 release, but personally I'd rather have it that way than not at all :).  Any idea if there is likely a new stable release soon?


Update docs that currently use the depricated init option

As mentioned on stackflow, I ran into a few parts of the docs that still used the old init option over the new onrender option. I did a quick search through the docs and the following pages. Most of these are directly related to components.

options (under components)
partials
components
Ractive.extend()

I've crossposted this to the docs repo, so I'm going to close the issue here.


WAF log query for blocked requests is invalid

'action_s' should be 'action_name_s'

@ericlobner : Thanks for your contribution! The author(s) have been notified to review your proposed change.

From log analytics query results:
SYNTAX ERROR
'where' operator: Failed to resolve column or scalar expression named 'action_s'
If issue persists, please open a support ticket.
Request id: 90f31e7a-188d-4c3b-8912-7656ca18073e
Need Help?
See the language reference
Ask the community

#sign-off


Log improvement

What this PR does / why we need it:
Improve the log module.
Log level and path can be configured in log.conf which was located in the root path of opensds.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
None
Release note:

What this log module provided
Log file path, level and format can be configured in

log.conf

which is in opensds's root path, configuration is like this:
path = /var/log/opensds
level = info
format = [%time%] [%level%] [%filename%] [%funcName%():%lineNo%] [PID:%process%] %message%

path indicates where the log file is stored.
level indicates the level of logger.
format indicates the format of log. %time%, %level%, %filename%, %funcName%, %lineNo%,  %process% and %message% can be used to configure to format
And if path, level or format are not configred, the default path is /var/log/opensds, the default level is info, and the default format is [%time%] [%level%] [%filename%] [%funcName%():%lineNo%] [PID:%process%] %message%
How to write log
First of all, you need to import the package:
import (
    log "github.com/sirupsen/logrus"
)

The log is divided into four levels: debug, info, warn, error
And you can use these four function to write the log: log.Debug, log.Info, log.Warn, log.Error

Is it possible to break this PR into smaller ones? First PR may contain the log framework change and then subsequent PR may contain the module wise changes

@ThisIsClark can you add some test report about your PR, such as what does the opensds logs looks like after you add logrus?

Is it possible to break this PR into smaller ones? First PR may contain the log framework change and then subsequent PR may contain the module wise changes

I have ever thought about this. Modify too many files in a PR would make it hard to be reviewed and verified.
But for this PR,

@ThisIsClark can you add some test report about your PR, such as what does the opensds logs looks like after you add logrus?

The test report has been added to release note.

Closing this PR. @ThisIsClark can you please take a note of it. We will re-look it and bring it back post daito. This will need proper support from all the stakeholders


Server Crash with Gas Pipe

Hello im a gamer with xtremeidiots.com and your gas comduit will crash a server if you try to interface it with meknism i might suggest fixing that

Last I checked, there were no Gas Conduits in Ender Zoo.

Don't bother, this issue was fixed almost a month ago. Please update EnderIO.


Don't import pretty_errors

It's really inappropriate for a low-level library like this to be making global changes to the way stack traces are rendered.  Especially since the "pretty" stack traces don't include file names or line numbers!
This is just crazy.  All I wanted to do was import lightning, and I had to spend a couple hours tracking down why my stack traces were suddenly useless.  If users want this behavior, they should knowingly opt-in themselves.  They shouldn't be forced in by some dependency of a dependency of a dependency.

📚 Documentation preview 📚: https://torchmetrics--2543.org.readthedocs.build/en/2543/

Thank you for sharing your opinion; how/why do you install debug dependency in the first place? :thinking:

I just installed lightning, yesterday:
$ python -m venv venv
$ . venv/bin/activate
$ pip install torchmetrics==1.4.0
...
$ pip freeze | grep pretty
pretty-errors==1.2.25

It's good that torchmetrics doesn't break stack traces by default as of 1.4.0.post0, but there's still no reason for this library to have the potential to do so.  If a user want to use pretty_errors, they should modify site_customize.py or alias python, as recommended by pretty_errors itself.


delete ns listener

This change is

Already fixed, ready for review @feiskyer

Ready for review again @feiskyer

LGTM. Thanks.


Inconsistencies when turning on/off light in an area

Turning on light in an area works, but turning it off doesn't

Sorry, missed this one, thanks for assigning it @tetele

Hmm, strange, I can't reproduce this:

This is in my own productions system running HA 2023.7.2
I also tested in the intents repo using the test scripts there, and also there it works without issues.

Could you test in developer tools > Assist what happens when you use both sentences?

Okay, this helps to reproduce it.
You have a light entity with either the name or alias licht
So for the turn on intent it matches licht with the expansion rule, and then uses the area zolder
However, for the turn off command, it first matches licht with the entity with name or alias licht and then fails because that light is in another area.
Not sure why it does a different matching on these turn on and off actions @synesthesiam can you maybe enlighten us on that?
However, If you can find the light entity with the name or alias licht and rename that, it should work.

It starts to make things clear... but not completely yet ;-)
The entity is called Attic Light, and I haven't renamed it. Though I have provided a alias "zolder licht".

Does that make sense to you?

No, I think it's another entity, which is not in the area zolder
Could you try this in developer tools > template

{% for l in states.light if l.name | lower == 'licht' %}
  entity_id: {{ l.entity_id }} | name:{{ l.name }}{{ '\n' }}
{% endfor %}

Does that return anything?

Keep in mind that it might be an alias, not necessarily a name. And several entities could potentially have the same alias.

Yeah I know, but if it's the name we know the culprit. If it's an alias it could be like finding a needle in a haystack

oh wait, you could also go to devtools > assist and try:
zet licht aan and zet licht uit
does one of those give a reference to a specific entity?

No, I think it's another entity, which is not in the area zolder
Could you try this in developer tools > template
{% for l in states.light if l.name | lower == 'licht' %}
  entity_id: {{ l.entity_id }} | name: {{ l.name }}{{ '\n' }}
{% endfor %}

Does that return anything?

It doesn't return any entities. But it could indeed be one (or more) alias(es). What is the easiest way to check?

in my test case, it does give the light for which I added the alias (used to reproduce your issue)
intent:
  name: HassTurnOff
entities:
  name:
    name: name
    value: licht
    text: licht
targets:
  light.booglamp:
    matched: true

@denniswham you can find the alias by using devtools > Assist (just above your last post) :)

I have removed the alias "licht" which was assigned to another entity. Now it all works, issues resolved 👍

Okay, great!

Thanks @TheFes! I was happy to see the dev tool helped 🙂

@synesthesiam
The devtools addition was indeed really useful here
I still wonder why for turning on the sentence was parsed as turn <expansion rule> <area> on and for turning off as turn <name> <area> off How is decided which option is preferred, and why is it different in both cases.

I still wonder why for turning on the sentence was parsed as turn   on and for turning off as turn   off How is decided which option is preferred, and why is it different in both cases.

Sentences are parsed/matched in order, by filename and order inside the file. There is no priority system (maybe there should be?). I can't say for certain why the matching happened as it did, as I can't read enough Dutch to mentally match phrases, but keeping that in mind, you can probably try to do it yourself @TheFes.


Getting Rails to work

hi i am using a debain linux and recently started rails...the latest version of RUBY available for debain is 1.9.3 so i cannot install mime-types-data on my system .I have installed most of the gems required for running my first RAILS application but BUNDLER is creating a problem help me please....
Following error occurs while installing mime:
Gem::InstallError: mime-types-data requires Ruby version >= 2.0.
Now.
---------------------------------------- gem list bundler
*** LOCAL GEMS ***
bundler (1.12.5, 1.1.4)

rails server

Bundler could not find compatible versions for gem "bundler":
In Gemfile:
rails (= 4.2.6) ruby depends on
bundler (< 2.0, >= 1.3.0) ruby
Current Bundler version:
bundler (1.1.4)
This Gemfile requires a different version of Bundler.
Perhaps you need to update Bundler by running gem install bundler?
Please help me get started with RAILS

There are a couple of options I found using Google:

use the newer version of Debian 8 (aka Jessie) which uses Ruby 2.1.5
install RVM and use it to install the latest version of Ruby and managing your gems - see http://stackoverflow.com/questions/16345465/how-to-install-ruby-2-0-in-debian-6.

Avoid using Ruby 1.9.3 as support for it ended last year.

@RAJKUMAR18 you'll want to follow @hmistry's comment also consider using more recently updated versions of Ruby and Bundler. I'm going to close this but we can continue working with you if you are still experiencing issues

thank you


get the connector

thanks for the 3 test vsdx and the well written test file.
May I know how to get the connection information from vsdx?

I too was wondering this.
Testing from Lucid chart, the CSV export contains connections, but when exporting as vsdx and importing back in to lucid chart, all the relevant information I am looking to retain is present EXCEPT connections are no longer snapped to the shapes.
This is either a manifestation of the vsdx format, or import. Any guidance would be greatly appreciated.

OK I have delved into the VSDX file format... There is no actual data construct which "snaps" the line to the object.
Basically you have the Shapes XY coordinates, as well as heigh and width. You also have a start xy and end xy for each of the line shapes.
I suspect it is as simple as getting each of the shapes, compute the edge boundry, and then check each line to see if it's start or end coordinates are on the edge of the shape.

"I suspect it is as simple as getting each of the shapes, compute the edge boundry, and then check each line to see if it's start or end coordinates are on the edge of the shape."
This is a possible guess, as I am sure that a line is also a shape, they probably just check whether the boundary of the line touches any shape.........
Of course, I am not 100% sure.

OK I have delved into the VSDX file format... There is no actual data construct which "snaps" the line to the object.
Basically you have the Shapes XY coordinates, as well as heigh and width. You also have a start xy and end xy for each of the line shapes.
I suspect it is as simple as getting each of the shapes, compute the edge boundry, and then check each line to see if it's start or end coordinates are on the edge of the shape.

actually if we try to read the source code of drawio, we might know how to get the connecting information, since drawio accepts import vsdx format graph,  and drawio could perfectly read that connection information such that when you drag some shape, the connected line with other shapes will move too.  However, the source code base is huge. I couldn't even locate where does this import function exist.

I am still digging into this, #4 is a bit of a bigger issue as right now this module does not properly implement the masters files which are used for deduplication within the file format. Basically shapes can be defined in the page directly, or they can be defined in master and then referenced within the page with overrides. Its pretty a ingenious solution, and it uses the same methodology of the pages directory. I hope to have something soon which that specific limitation. Then I will look into solving for the connector issue.

Hi - I think you are both right on the connectors/line shapes. There is a relationship defined in Connects/Connect element and the module should move the line shapes that are mapped to any other shape that are being moved (I imagine it will be more complex than that but its a start).
Regards master files - you are right, I have not needed to look at that element.

Hi - I have add a couple of properties to Shape class.
Shape.connected_shapes provides list of Shape objects (so connectors, or shapes if you query the connector)
Shape.connects provides a list of Connect objects which describe the relationship
v0.2.5 pushed to PyPI now
I hope that helps address the initial question :)
I'll leave this issue open for now in case it doesn't.

Closing after v0.2.5 push


Adjust base colors in darkmode

Adjust the base colors in dark mode to fit better visually.

Reduce the saturation on certain color ranges to make the color less aggressive.
Reduce the lightness using linear interpolation to make the color appear lighters and fit better with the darker backgrounds.
Make a system to ensure contrasts are beeing followed.

Was this fixed in #2370 ? @Thunear

This was fixed a bit earlier when we started flipping the colors in dark mode, so this issue is no longer relevant.


jar can not start with v2.6.6

[ ] I have searched the issues of this repository and believe that this is not a duplicate.
[ ] I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

Dubbo version: 2.6.6
Operating System version: MacOS 10.14.3
Java version: 1.8.0_151

Steps to reproduce this issue

sh bin/start.sh

Expected Result
The dubbo jar can not start.
Actual Result
sh bin/start.sh
: No such file or directoryin
: No such file or directory.
: command not found7:
: command not found13:
bin/start.sh: line 93: syntax error: unexpected end of file

I checked the  dubbo/dubbo-container/dubbo-container-api/src/main/resources/META-INF/assembly/bin/start.sh file  on the 2.6.x branch ：
Found nothing is changed recently

The dubbo jar can not start.

Which jar are you using?

The format of start.sh is dos. After I formated it by command "dos2unix ./bin/start.sh", it can work now.

@cvictory Has this bug fixed?

@cvictory Has this bug fixed? You can reproduce this issue easily by
java-server.zip.

This shell is for linux bash,  the mac bash is different from that .
So can you test this demo in linux machine.
I will list some difference between mac and linux:

cd "$(dirname "$0")"  it work well in linux
but in mac , you should use  cd "$(dirname "$0")"
https://stackoverflow.com/questions/1308823/os-x-bash-dirname/1308838#1308838

it is also happened in pwd and other command.

@cvictory

Maybe I am wrong. Firstly I think it is different os problem, and i close this issue.
I will check with 2.6.6 release manager next week.
If you have some solution to fix this , you can fire a pr and reopen this issue.

@cvictory Firstly, I do not have the right to reopen this issue. Secondly, I review the start.sh in the github and I can not find any ^M symbol. So I do not know what's wrong in the release process.

hi @AlexStocks  , where you got the java-server.zip?
If you built the binary package yourself, maybe you can check your git config about core.autocrlf

@biyuhao This package is my dubbo test codes. The start.sh v2.6.6 is from apache central maven repo, I think.

Hi, I've confirmed that both dubbo-2.6.6.jar and dubbo-2.6.6-sources.jar in Maven Central have the malformed scripts.
line endings should be 0x0a not 0x0d0a

Seems release packages in download page are not affected.
This will be fixed in next patch release, maybe 2.6.7?

@biyuhao Good job. Do u know what's wrong with the dubbo-2.6.6.jar that causes this script has "\r\n"?


Footnotes are not rendering properly

I'm using the [^1] syntax in this post, but the footnotes are not rendering at all.
I did not altered the source of this project when I used it for my github.io website.

If I remember correctly, Github Pages's Markdown settings do not enable footnotes by default.

@plttn It seems you are correct, this may not be an issue with pixyll.

@thundergolfer consider building your site locally and pushing only html to your github site dir. It is very easy to do (build takes just one additional cmd) + allows a lot of flexibility to customize what you get in html :).

@thundergolfer Footnotes work with GH Pages hosted sites. I think the issue is with your Markdown. Try removing the space before the colon like this as per Kramdown's syntax
[^1]: Data Engineering, Techopedia -  https://www.techopedia.com/definition/6730/data-architecture

There are also some Kramdown default options related to footnotes you can change in _config.yml, which GH Pages lets you override.


Problem in inheritance with aggregation

Hi, I got a scenario with inheritance like this one:
Parent Class
    public abstract class TypeBase
    {
	...
    }

Child Class (1)
    public class TypeOne : TypeBase
    {
	...
    }

Child Class (2) - With Aggregation
    public class TypeTwo: TypeBase
    {
	...
	public virtual AnotherType ObjectAnotherType { get; set; }
    }

Class to persist
    public class MyClassToPersist
    {
	public virtual TypeBase ObjectTypeBase { get; set; }
    }

Persisting service
    MyClassToPersist obj = new MyClassToPersist { ... };

    ctx.UpdateGraph(obj, map => map
                    .OwnedEntity(o => o.ObjectTypeBase, with => with
                        .OwnedEntity(s => s.ObjectAnotherType)));

Its not working coz its saying theres no ObjectAnotherType in TypeBase. Is there anyway to make it work?
Thanx.

Hello @thiagorizzo ,
Do you think you could provide us a test project with this issue?
It will make easier/faster for my developer to getting started for investigating it.
We now always ask for a project since we found out that most issues are missing some essential information or are resolved by the requestor when creating it
(Even if the issue seem very easy to reproduce, by getting a test project, it allow us to give a faster support and better experience for the support of all our free libraries)
Best Regards,
Jonathan


Not able to grant team roles for an inventory if there is already a similar role present but for a credential

Trying to grant a Use role to a team on a inventory something like following:
tower-cli role grant --type use --team test --inventory Cisco -v

But it doesnt show up on UI.
There is already a Use role granted for this team on one of the credentials. When I run the above command it says this
*** DETAILS: The team field is given as a name; looking it up. ****************
*** DETAILS: Getting the record. **********************************************
GET https://<IP_ADDRESS>/api/v1/teams/
Params: {'name': 'test'}

*** DETAILS: The inventory field is given as a name; looking it up. ***********
*** DETAILS: Getting the record. **********************************************
GET https://<IP_ADDRESS>/api/v1/inventories/
Params: {'name': 'Cisco'}

*** DETAILS: Checking if role exists. *****************************************
GET https://<IP_ADDRESS>/api/v1/inventories/4/object_roles/
Params: {'role_field': 'use_role'}

*** DETAILS: Checking if team already has role. *******************************
GET https://<IP_ADDRESS>/api/v1/teams/1/roles/
Params: {'object_id': 4, 'role_field': 'use_role'}

*** DECISION: This team is already a member of the role. **********************```

*** DETAILS: Checking if team already has role. *******************************
GET https://<IP_ADDRESS>/api/v1/teams/1/roles/
Params: {'object_id': 4, 'role_field': 'use_role'}

This filter is over-broad (my mistake). We need something that we can use to get the content type. I would prefer to use something like content_type__model, so we can look up by model name instead of adding an additional query to get the content type pk (which might not be possible anyway).
Example filter:
/api/v2/roles/?content_type__model=inventory

tower-cli will need to be sure to use the correct database model name for every resource type.

Verified by me as well. Impacting the automation set around all the tower RBAC I've set up.


migrate to null safety

Migrated to null safety and updated depricated android files in example project

Thank you 🙏

This update reverted the last issue:  "Bugfix: Dispose"


Changes for landing https://github.com/dart-lang/sdk/issues/32161

Add void declarations to methods with implicit dynamic returning void
values, which may be illegal in dart 2, but in either case, expresses
the current intent better.

Thanks Harry!
Do you want to do a publish before I pull this in to g3? Since its in bin/ I'm assuming it doesn't matter.

I'll push a +1 release and ping you


Trim subtree of 3dtiles

When I load large scale of 3dtiles, the memory used by tileset will be bigger and bigger, cesium will release content, but cannot release the tree node. When I load tileset which have about 70Gb size and about 2 million tile will finally cause chrome out of memory and shut down.
Do I have a proper way to trim tileset?

Hi @jiangheng90, how was your tileset generated? And would you be able to provide a link to it for testing?

@ggetz I have seen assets of Photogrammetry in ION, the number of tiles are very small. memory usage of tileset is not big.So I think optimize data decrease tiles rather than trim tile in frontend may be a good idea .


feat: add pagespeed insights link

Add link to PageSpeed Insights in URL facet
Description
Added a link to PageSpeed Insights for each given URL in the URL facet.
Related Issue
Motivation and Context
Meant to give a clue to users how to diagnose issues and make it faster to do so even if they don't need the clue.
How Has This Been Tested?
https://pagespeed--helix-website--adobe.aem.live/tools/rum/explorer.html?domain=emigrationbrewing.com&filter=&view=month&domainkey=open&conversion.checkpoint=click
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

The page speed icon should not be an img – we can add that in CSS

The page speed icon should not be an img – we can add that in CSS, maybe with something like this https://codepen.io/trieloff-the-flexboxer/pen/qBGXjxx

I probably missed your point on this -- I had only read the initial comment which showed up in email, not the edited one here which is more pure CSS.  Anyways have a look and advise if I should abandon that one.
https://github.com/adobe/helix-website/pull/555


First pass of data build

got lost in the metaphorical sauce of git history and merge conflicts but here is a first pass of the data. re-syncing so there will be more data from certain chains to be added later.

seems good for the data i can see changed, merging


Fix client initialization when KUBECONFIG OS path has : delimiter

Description
The client now checks if KUBECONFIG env has only one delimiter, and if it's belong to the OS home dir it does not try to split the env var configuration causing this:
[0] C:
[1} Users\DummyUser.kube\config
Issue reference
Please reference the issue this PR will close: #277
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[X] Code compiles correctly
[X] Created/updated tests
[ ] Extended the documentation

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: CarlosLanderas sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


chore: improve docker release pipeline

A couple of improvements related to the docker release pipeline.

Building multiple architectures -> standard arm and amd
Using official docker GitHub actions
Specify Dockerfile argument to have control over asyncapi release expected version in the image

@Ferror hey, we will need the same timeout as I mentioned in the generator PR. Can you add it. Afaik workflows now support it natively

Can you elaborate on what it supports natively? I was more convinced to go with https://docs.github.com/en/actions/using-workflows/reusing-workflows

@derberg  I think I put it all together, but to be honest I find the pipelines weirdly complex. And to have it cohesive must be a different pair of boots 😢
https://github.com/asyncapi/.github/pull/256

@Ferror sorry, I probably did not explain myself correct, and used phrase timeout instead of delay. Sorry about that.
so basically, docker releases run on release event. Thing is that GitHub release might be created, but npm not yet published. The release pipelines were created over 3y ago, when GitHub Actions did not have all the features in place and we were also learning it live. As far as I remember, when I was setting that up, we made sure the semantic-release plugins are ordered properly https://github.com/asyncapi/generator/blob/master/.releaserc#L16 so the GitHub release is created last. Also logs confirm"
[11:25:20 AM] [semantic-release] › ✔  Completed step "publish" of plugin "@semantic-release/npm"
[11:25:20 AM] [semantic-release] › ℹ  Start step "publish" of plugin "@semantic-release/github"

but when I worked on the pipeline, we had random fails of docker publishing, and the conclusion was, after some investigation, that the fact that "logs say" package is published on npm, sometimes there is a "some-seconds" delay before it is available for download.
this is why we had this https://github.com/asyncapi/generator/blob/master/.github/workflows/release-docker.yml#L26 in pipeline for generator docker release.
now, after 3y and github acquisition of npm maybe that improved, and also why CLI docker release did not fail yet. But why taking a risk, we can just have a well described step that just does
name: Short docker release delay
run: sleep 1m #docker image installs generator from npm, this sleep protects this step from any delays on npm side

sorry again for lame initial explanation

@Ferror yo, do you plan to continue with this one? would be great

@Ferror yo, do you plan to continue with this one? would be great

Yea. I forgot about it. I will add some improvements like we did for generator and we can release it :)

@Ferror 1s sleep is not enough. It was 1m originally. We can try 30s now (just changed) and in case it actually still should be 1m we can always modify pipeline. But going with 1s should be avoided

/rtm


Pointer Not Automatically Allowing Expansion?

When reversing a program, setting an address to data type "pointer" doesn't allow for me to expand into that pointer's address. I then have to go to the repeat sign button, and click class (or something else) before I can expand.
Am I missing something?

Maybe this is the same as in #165?

Maybe this is the same as in #165?

That's definitely it. I searched and didn't see that issue in the results. Silly me...... I'll close. My bad!


node.js imagestream with RHOAR version included

Replaces https://github.com/minishift/minishift-addons/pull/96

Can one of the admins verify this patch?

@praveenkumar Updated. This can be "squash and merged" when accepting the PR (https://help.github.com/articles/about-pull-request-merges/). I'm a git noob, I don't really know how to do it on the client side :-(

@praveenkumar Updated. This can be "squash and merged" when accepting the PR (https://help.github.com/articles/about-pull-request-merges/). I'm a git noob, I don't really know how to do it on the client side :-(

@jorgemoralespou we can fix it during merging as you mentioned. Don't worry about it.


Publish to npm

Hi! This looks awesome!! Is there any chance you eventually will publish this as a package to npm? I would love to be able to install it easily. If the app is not ready, I would love a ping on this issue when it is :smile: If you need any help publishing, let me know :+1: :wave:

Even if not published to npm, it would be nice to add a package.json instead of bundling third-party code in.

@nikolay Thanks for bringing that up. I've added one.
@asbjornenge this was a pretty quick weekend project and is still a ways from publishing. If I eventually decide to, I'll let you know. Until then, the package.json should help a lot. Thanks for the interest!


[Request Editable] - table 77 "Report Selections" - "Custom Report Layout Code"

Field "Custom Report Layout Code" is not editable in table 77 "Report Selections" but the same field in table 9657 "Custom Report Selection" is. Customers find the selection of an email body code with the lookup of flowfield(22; "Email Body Layout Description" not inline with the rest of BC on how you select a value. They would rather use the "Custom Report Layout Code".
field(7; "Custom Report Layout Code"; Code[20])
{
Caption = 'Custom Report Layout Code';
Editable = false;
TableRelation = "Custom Report Layout".Code WHERE(Code = FIELD("Custom Report Layout Code"));
}
Could you set it up in a next release as:
    field(7; "Custom Report Layout Code"; Code[20])
    {
        Caption = 'Custom Report Layout Code';
        TableRelation = "Custom Report Layout" WHERE(Code = FIELD("Custom Report Layout Code"));

        trigger OnValidate()
        begin
            CalcFields("Custom Report Description");
        end;
    }

As a side note:
I have already made a suggestion at the serviceshub on the funky way the property TableRelation is set up.
It should just be
TableRelation = "Custom Report Layout";
in previous mentioned tables.

Anybody following this up?


Add prometheus metrics gathering

Adds metrics and metricsServer modules
Metrics is injected as a dependency to various other modules

used to update the metrics (eg: metrics.peers.inc())
subclassed for the beacon node, could be subclassed for validator / light client / etc

MetricsServer serves metrics data

it's separate to allow for alternative implementations (eg: pushgateway for the browser)
the http metrics server serves data as expected for prometheus
also included a pushgateway implementation (not currently used)

Probably not much / only a negligible amount? Can't say definitively, though.

still broken :(

the errors are false negatives, we can restart them and make them green though.


Fix volume snapshot in a VM with an ISO attached

Description
When taking a snapshot of a volume in a VM with an ISO attached, ACS attempts to define the label of the target associated with the ISO by its ID. However, this ID may not be correctly mapped to the label, which causes the snapshot to fail.
This PR fixes this by using the defined label, instead of defining it during the snapshot process by its ID.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[X] Minor
[ ] Trivial

How Has This Been Tested?
In a local lab, I created 3 VMs with ISOs attached: VM1, VM2 and VM3. VM1 had 1 volume, VM2 had 2 volumes, and VM3 had 3 volumes.  The label of the target associated to the ISO was hdc for all of them.
When taking a snapshot for the volume in VM1, the label was incorrectly generated as hdb, which caused the snapshot to fail.
When taking snapshots for the volumes in VM2, the label was correctly generated as hdc, and the snapshots succeeded.
When taking snapshots for the volumes in VM3, the label was incorrectly generated as hdd, which caused the snapshots to fail.
After applying the changes, I took snapshots for every volume of the VMs. In all of them the label was correctly passed as hdc, and all snapshots succeeded.

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5155

@blueorangutan test

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-5733)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42466 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7037-t5733-kvm-centos7.zip
Smoke tests completed. 105 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_08_upgrade_kubernetes_ha_cluster
Failure
566.97
test_kubernetes_clusters.py


Access request for lumpfish to test-ibmcloud-rhel6-x64-1

Access level:

[ X] Non-privileged
[ ] jenkins user
[ ] root/Administrative
[ ] other (Please specify):

System for which access is needed: test-ibmcloud-rhel6-x64-1
Working on https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/1851.  Increasing ulimit -u worked briefly, now the test is going out of memory again.  Would like access to the machine to investigate.

Done - ssh<EMAIL_ADDRESS>- Let Me Know if there are any issues with it :-)

@sxa - I no longer need access. Thank you.


DOM Cross Site Scripting

Hey Cosmo Devs,
I didn't have a direct email with Developers so I am opening this ticket for public. (please send me your email so I can give you more serious security issues).
Anyway, in the HTML of the index and almost every page it says:
            if(window.location.href.indexOf('#!') === -1)
                window.location.href = window.location.protocol + '//' + window.location.host + '/#!' + window.location.pathname;
        </script>

Note: it is IE 9 Commented so, it will primary target IE users. but using encodeURLComponet(window.location.pathname) would pretty much solve this issue. this is basically like the one Wordpress got last time. something like: http://www.paulosyibelo.com/2015/04/facebooks-parse-dom-xss.html
Thanks,

Hey thank you for making us aware, should be patched for next release (v5) for other issues that are better off in email you can send them my way -<EMAIL_ADDRESS>


Inertia of universe if initialized with Zero.

A long time ago, I added the following lines in the constructor of Model:
      // Inertia of universe has no sense.
      inertias[0].mass() = std::numeric_limits<Scalar>::quiet_NaN();
      inertias[0].lever().fill (std::numeric_limits<Scalar>::quiet_NaN());
      inertias[0].inertia().fill (std::numeric_limits<Scalar>::quiet_NaN());

While implementing #742, I found a sense to the inertia of the universe :)
When append modelB to joint a of modelA, the inertia of the universe of modelB ought to be added to the inertia of joint a. Sadly, the information was lost because it was initialized with NaN values.

By the way, at the moment, Inertia::Zero() + Inertia::Zero() gives a NaN Inertia. Is this behavior desired ?

As far as I understand, you should never read this information when merging two models. Am I correct?

If modelB is a manipulator arm, then there are geometries which are not moving. In Pinocchio, they are thus attached to the universe joint and their inertia is lost.
Appending modelB to any other model will then produce a wrong inertia.
I agree that, in most cases, it is not used and I can implement a workaround for this in hpp-pinocchio. So it is not blocking for me.

By the way, at the moment, Inertia::Zero() + Inertia::Zero() gives a NaN Inertia. Is this behavior desired ?

The sum of two Inertia with Zero entries has no meaning because there is no notion of barycenter.

If modelB is a manipulator arm, then there are geometries which are not moving. In Pinocchio, they are thus attached to the universe joint and their inertia is lost.
Appending modelB to any other model will then produce a wrong inertia.
I agree that, in most cases, it is not used and I can implement a workaround for this in hpp-pinocchio. So it is not blocking for me.

This is fine for me. The idea of having these NaN values was for debugging purposes only.

The sum of two Inertia with Zero entries has no meaning because there is no notion of barycenter.

It isn't hard to find a meaning to the barycenter of (0,0,0), with weight 0, and (0,0,0), with weight 0...

Yes, you're right. But you then need to check that two CoM are equal, which is not warranty.
Anyway, I think a special case to check whether the two inertia are Zero will slow down the computations a lot.
We can just add an assert to be sure that the two Inertias are not equal to Zero.

We can just add an assert to be sure that the two Inertias are not equal to Zero.

I am fine with keeping it as it is now or adding an assert.


Use HTTPS instead of HTTP

This avoids mixed content errors when beaconing data from HTTPS pages.
This is currently a problem on jsPerf.

https://jsperf.com/slugs
Open DevTools console
Run test — at the end, it attempts to POST to Browserscope

Ref. https://github.com/jsperf/jsperf.com/issues/235

@elsigh Can you look into this please?


Cowboy UART commands

Hello Jouke,
Thank you for the great repo! It was almost exactly what I required for my small project, but I am still missing one thing: the commands to control the bike's support level (aka Eco, Adaptive, Off). So my question is, how did you get the commands to switch the lights? Or, maybe, do you know the exact commands I need?
Some context: as you surely know, Cowboy bikes lack physical controls (at least mine C4), and I'd like to implement such controls based on esp32. That is why I need to gather as many known commands as possible. The commands from your example:
static uint8_t lightsOffCmd[] = {0x0A, 0x10, 0x00, 0x01, 0x00, 0x01, 0x02, 0x00, 0x00, 0xD4, 0xB1};
static uint8_t lightsOnCmd[] = {0x0A, 0x10, 0x00, 0x01, 0x00, 0x01, 0x02, 0x00, 0x01, 0x15, 0x71};

Good question. If I recall correctly I looked at the source of some of the apps (Unleashed/Untamed/Bronco?) and based it on that. Or I was in contact with one of their developers and they shared it informally. However I just did a quick search and it seems like their source code is offline. Best to ask some of the other devs on reddit for a list of codes.


Issues with version 1.122.0 of cdk

Generates an error on this of something like: new cwt.WebAppDeployment(this, 'WebAppDeploy', {

This seems to be related to differing versions of the cdk referenced in this project and the one I created. I pulled the files and compiled them directly into my infrastructure project.


No way to turn off the automatic opening of Keybase on macOS startup

Keybase GUI Version: 1.0.21-20170413194119+9dea6e1

Your version is almost a year old. Try updating.

Hmm yes, that helped. Kind of thought it was up-to-date but I guess it does not (or did not) automatically update.


Add rake task for avro register

Part of #PW-1836.
Usage:
ros ros:avro:register <service>

No need to add the task to ros-cli. The task is already in ros.


fix(plugins): change log level from error to info when restarting external plugin instance

Summary
When the external plugin instances (go, python, ...) loses the instances_id in a event handler, the instance is restarted to complete the plugin call but a weird error appear:
2021/08/20 10:23:59 [**error**] 30#0: *51336 [kong] mp_rpc.lua:308 [jwe] no plugin instance 0, client: <IP_ADDRESS>, server: kong, request: "POST /example HTTP/1.1", host: "example.es"

We change the log level to info as this is not a real problem as the plugin is restarted lately in code (considering the message string as well)

Thank you @ealogar !


Add features.yaml files to third party integration tests

Description

Related issue

b/246812070
How has this been tested?
Integration tests

Checklist:

Unit tests

[x] Unit tests do not apply.
[ ] Unit tests have been added/modified and passed for this PR.

Integration tests

[ ] Integration tests do not apply.
[x] Integration tests have been added/modified and passed for this PR.

Documentation

[x] This PR introduces no user visible changes.
[ ] This PR introduces user visible changes and the corresponding documentation change has been made.

Minor version bump

[x] This PR introduces no new features.
[ ] This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
[ ] This PR bumps the version.

Obsolete by https://github.com/GoogleCloudPlatform/ops-agent/pull/1021 that includes both the implementation and tests.


[authoring] make regular URLs clickable without link syntax

pasting a regular URL should make it clickable regardless if it's surrounded in markdown link syntax

Duplicate of https://github.com/dxos/dxos/issues/5530


Resolve redundant GCP logs in load_gcp_config

Intended to resolve #627
With my understanding, the redundancy was that "GCP credentials found" was repeated twice. I adjusted the line in cli_init.py::load_gcp_config as a result. Please let me know if there's a redundancy I'm not seeing.
All the other changes were due to running autoflake --in-place --remove-all-unused-imports --remove-unused-variables --recursive skyplane as per the contribution guidelines.

This looks good to me! Thanks for the contribution @mech-a


Loading Error: /apy.eth

Describe the bug
Our snapshot page is not opening up
To Reproduce
Steps to reproduce the behavior:

Go to 'https://snapshot.org/#/apy.eth)'
The page opens, but the proposals are not loading

Expected behavior
The page loaded, with a list of proposals
Screenshots

Desktop (please complete the following information):

OS: OSX Big sur
Browser Chrome
Version: 98.0.4758.102 (Official Build) (x86_64)

Additional context
It was working fine into the end of last week.

Interesting.... For me it shows up after some time but with this error:

I'll have a look.

Seems to be a bug in one of our dependencies: https://github.com/stiang/remove-markdown/issues/52
I'll submit a workaround.


[SPARK-20814][mesos] Restore support for spark.executor.extraClassPath.

Restore code that was removed as part of SPARK-17979, but instead of
using the deprecated env variable name to propagate the class path, use
a new one.
Verified by running "./bin/spark-class o.a.s.executor.CoarseGrainedExecutorBackend"
manually.

@mgummelt

Test build #77106 has started for PR 18037 at commit d129327.

Test build #77106 has finished for PR 18037 at commit d129327.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77106/
Test PASSed.

Test build #77129 has started for PR 18037 at commit a861819.

Test build #77129 has finished for PR 18037 at commit a861819.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77129/
Test PASSed.

Ping? Let me invoke @srowen or @squito since we should have this in 2.2.0.

looking...

Was spark.executor.extraClassPath ever supported in Mesos?  I see no code for it.

Yes, it just set SPARK_CLASSPATH and relied on the launcher code to respect that env variable, but that code was recently removed.

It looks like Standalone gets around this by constructing a raw java command instead of a spark-class command.  Will YARN be using this new SPARK_EXECUTOR_CLASSPATH variable as well?
I don't really see why we would have deprecated SPARK_CLASSPATH only to introduce SPARK_EXECUTOR_CLASSPATH, but I'm fine with this change.

Neither standalone nor YARN use env variables to create the executor's classpath, so I guess that's why Mesos was missed. I'd rather Mesos stop using env variables too, but that's a bigger change, and I want to get this in 2.2.0 to avoid a pretty user-visible regression.

It looks like YARN just sets the generic java CLASSPATH env var.  Maybe Mesos should do that too.

YARN does not run spark-class, Mesos does. And spark-class does not honor CLASSPATH, IIRC.

I'm gonna merge this to unblock 2.2; if there's a desire to clean up this code later, we can do it separately.


[fix] get_state to match appdaemon's api

There is currently a bug in the testing framework that causes attributes to be returned when they should throw a TypeError. Appdaemon's api only takes one positional argument and then catches all kwargs. The framework takes two positional arguments leading to a mismatch in APIs.
For example, this would throw a TypeError in appdaemon, but does not in the framework:
self.get_state(self.entity_id, "friendly_name")

This should actually be called as:
self.get_state(self.entity_id, attribute="friendly_name")

Good catch, thanks a lot for the PR!
I added a test and slightly refactored the implementation. I pushed on this PR so you're still credited for the fix 🙂
Merging now


Clean up header file includes.

Some dependencies are duplicate.
Resolve this by removing unneccesary #includes.

Done: https://github.com/inexorgame/entity-system/commit/e4d7e149efefc7ddc67962fc81c643e23fb96235


Tern Integration issue

Hi and thanks for your work,
i hope I'm right about this but it seems that Tern integration does not work , autocompletition does not appear , same problem also in http://codemirror.fatalix.de/, i tried all major browser , instead it works on http://codemirror.net/demo/tern.html#
Thanks.

i found the problem , it is changed tern's server url , now is 'http://ternjs.net/defs/ecmascript.json'


OC: Grabbed zero system-id for SB, this is not allowed

I ran into this issue when trying to boot the installation USB stick.
Apparently this has to do with a security booting setting.

Same issue.
Security Boot Disabled in BIOS.

After applying @Jyrsa PR https://github.com/duszmox/ThinkPad-X1C4-macOS-OpenCore/pull/4 it boots.


ICS 4 Domain Types for channel handshakes

Closes: #315
Description

For contributor use:

[x] Updated the Unreleased section of CHANGELOG.md with the issue.
[x] If applicable: Unit tests written, added test to CI.
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[x] Updated relevant documentation (docs/) and code comments.
[ ] Re-reviewed Files changed in the Github PR explorer.

Codecov Report

Merging #391 (634f133) into master (b1b37f5) will increase coverage by 21.1%.
The diff coverage is 65.4%.

@@            Coverage Diff            @@
##           master    #391      +/-   ##
=========================================
+ Coverage    13.6%   34.7%   +21.1%
=========================================
  Files          69     152      +83
  Lines        3752    9100    +5348
  Branches     1374    3070    +1696
=========================================
+ Hits          513    3166    +2653
- Misses       2618    5693    +3075
+ Partials      621     241     -380

Impacted Files
Coverage Δ

modules/src/events.rs
0.0% <0.0%> (ø)

modules/src/ics02_client/events.rs
0.0% <ø> (ø)

modules/src/ics02_client/msgs.rs
0.0% <0.0%> (ø)

modules/src/ics02_client/raw.rs
0.0% <0.0%> (ø)

modules/src/ics03_connection/error.rs
13.6% <0.0%> (-19.7%)
:arrow_down:

modules/src/ics04_channel/error.rs
75.0% <ø> (+50.0%)
:arrow_up:

modules/src/ics04_channel/msgs/acknowledgement.rs
0.0% <0.0%> (ø)

modules/src/ics04_channel/msgs/packet.rs
0.0% <0.0%> (ø)

modules/src/ics04_channel/msgs/timeout.rs
0.0% <0.0%> (ø)

modules/src/ics04_channel/packet.rs
0.0% <0.0%> (ø)

... and 282 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24db51d...db09903. Read the comment docs.

Looking at this now and wondering why we need impl DomainType<RawMyType> for <MyType> for many of these. Just the TryFrom/From would be enough. The code compiles and runs fine if we remove all except the cases where RawMyType is not a prost message but wire bytes. For example the client state that is stuffed into an Any type as Vec, or merkle proofs.


Revamp SymbolEnter

Purpose

$title.

Fixes #
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

@gimantha / @hasithaa / @SandaruJayawardana Do we need this draft PR? Looks like it got automatically closed without any attention. If you really don't need this PR anymore, please remove stale label from the PR. Then it won't get added to the [Stale PR] Ballerina Stale PR Details mail in future.

Let's temporarily close this PR, until we finalize the design.


add Checklist

Hello. I implemented a new mode for multiple selection. Checklist is similar to MultiChoice but user can choose multiple variants using Space.
It is a straightforward implementation so any improvements are appreciated. For example, return []int{-1} looks like hack. I think, it would be convinient to return (int, error) from MultiChoice and ([]int, error) from Checklist but it will break API.

I don't mind it breaking the API at the moment. Multichoice was just implemented so there can not be many users yet.
But what are error options in multichoice and checklist other than Ctrl-c and Ctrl-d ?

And thanks again.

For checklist, it is perfectly fine to return an empty slice when nothing is selected. I do not see anything wrong with that.

I think it is Ctrl-c and Ctrl-d only. But with current API I should write the following code after every call:
	choice := s.Checklist(options, text, init)
	if len(choice) > 0 && choice[0] == -1 {
		return nil, readline.ErrInterrupt
	}

And I should distinguish empty checklist and Ctrl-c as well. Because when user didn't choose anything I want to show checklist again.

Thanks. I'll merge it in and cleanup afterwards.

Thank you!

Haha race condition comments.


change monospace font stack

closes #179
I believe I covered all style selectors that set the normal monospace stack.

@jacobbearden thanks! I made a small comment in the code, but otherwise this looks good in all the places I checked (code files, comments, commit messages, sha blocks).
// @sindresorhus @DrewML @sorrycc

LGTM :+1: Thanks!

@sindresorhus updated!

Nice! Thanks @jacobbearden!

Hello,
FWIW, as the chrome extension got updated for me yesterday, I noticed the font change and it was, IMO, quite frustrating...
Comparison:

I have Menlo and Source Code Pro fonts installed, but to me, this change meant either not using this Chrome extensions any more or installing the fonts in the new stack. That's how much it affected me.
I am all for refining github, however, given the source code is one of the main features of github and probably the one thing I spend most of my time looking at (reviewing pull requests, mainly), this was quite a big change.
This made me wonder:

how much refining is too much?
could there be a setting as to which font someone prefers? Seems like a very opinionated thing (I for myself use Ubuntu Mono Regular)
Should there be a mention in the README about the font stack with pointers to what the font options are and where to get them?

Would love to hear what others think about the above. Maybe I am the only one having this issue 😅
Cheers & thanks
Patrik

@pzi since this PR is already merged, you'd probably get more visibility with a new issue, if you're so inclined.

how much refining is too much?

People have asked about adding options (See #193, it might be the most recent discussion). For now it's sort of take it or leave it because there are no "options" available to play with, but you can modify the code and install manually.

could there be a setting as to which font someone prefers? Seems like a very opinionated thing (I for myself use Ubuntu Mono Regular)

You can make a PR with Ubuntu Mono Regular as the first font. 😄  Then it'll come up for you and anyone that has that font installed.

Should there be a mention in the README about the font stack with pointers to what the font options are and where to get them?

That wouldn't hurt either I guess.

Lol. I knew someone would complain about this.

I have Menlo and Source Code Pro fonts installed

Why do you have those installed if you don't like them? What really is the problem here?

how much refining is too much?

We are power users of GitHub and refine to how we like GitHub to be. We're upfront about this being a highly opinionated plugin. That's the only way you can really improve things. If enough people complain about something we always reconsider.

could there be a setting as to which font someone prefers? Seems like a very opinionated thing (I for myself use Ubuntu Mono Regular)

We're not interested in options, but happy to add more fonts to the list, like Ubuntu Mono Regular.

Should there be a mention in the README about the font stack with pointers to what the font options are and where to get them?

Sure

Why do you have those installed if you don't like them?

Menlo is a system font cannot disable that one. Source Code Pro... not sure, maybe from when I was experimenting with monospace fonts to use for source code :)

Either way, thanks for getting back to me this quickly.


[Bug] HACS integration not showing up

going to HACS and searching 'Portainer', i get "No repositories found matching your filter"

yes, this integration is not yet published


Add Use cases to DG

Codecov Report

Merging #251 (fad0b83) into master (c7c4420) will increase coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #251      +/-   ##
============================================
+ Coverage     59.76%   59.88%   +0.11%
- Complexity      676      684       +8
============================================
  Files           130      130
  Lines          2642     2667      +25
  Branches        337      343       +6
============================================
+ Hits           1579     1597      +18
- Misses          907      913       +6
- Partials        156      157       +1

Impacted Files
Coverage Δ

...ogic/parser/property/AddPropertyCommandParser.java
80.00% <0.00%> (-5.72%)
:arrow_down:

.../java/seedu/condonery/model/property/Property.java
69.62% <0.00%> (-2.18%)
:arrow_down:

.../java/seedu/condonery/logic/parser/ParserUtil.java
61.53% <0.00%> (-1.96%)
:arrow_down:

src/main/java/seedu/condonery/ui/HelpWindow.java
0.00% <0.00%> (ø)

...gic/parser/property/TypePropertyCommandParser.java
100.00% <0.00%> (ø)

...ic/parser/property/RangePropertyCommandParser.java
89.47% <0.00%> (ø)

...c/parser/property/StatusPropertyCommandParser.java
100.00% <0.00%> (ø)

...y/logic/commands/property/EditPropertyCommand.java
75.00% <0.00%> (+0.19%)
:arrow_up:

.../main/java/seedu/condonery/model/ModelManager.java
81.31% <0.00%> (+0.20%)
:arrow_up:

...onery/logic/commands/client/EditClientCommand.java
63.82% <0.00%> (+0.38%)
:arrow_up:

... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Generate diploid genomes in FASTA

Summary:

implemented the first step using SURVIVOR simSV
added config files: analysis.yaml and environment.yaml
output homo-/heterozygous genomes with(out) SVs based on the reference (chr17 only)
updated README.md

It is a good idea to keep homozygous and heterozygous SVs as two different sets.

@lsantuari: the workflow makes that distinction by generating chr17.hmsv.fasta (homozygous SVs) and chr17.htsv.fasta (heterozygous SVs) + chr17.hm.fasta (homozygous without introduced SV) files. Or do you mean something else?

My remark was just meant as a statement, not as a suggestion for a change. In particular, I am referring to the idea of generating two SV sets, one for the hmsv and one for the htsv. In the original formulation, hmsv and htsv had the same set of SVs with the difference of being present on one copy of the chromosome (htsv) or on both copies (hmsv). I think that generating two different sets of SVs for hmsv and htsv as you implemented here is better, also with respect with the data being used for model training.


Use JSI to improve perf

At the moment lmdb is slower than mmkv. It could be the bridge. Let's try use the JSI and see if that improves performance: https://ospfranco.com/post/2021/02/24/how-to-create-a-javascript-jsi-module/
benchmarks:

I've been able to improve perf using JSI:


wrote readme in japanese.

I wrote README in japanese.
Why written in japanese, I am native speaker of Japanese but not English.
Will be planning translate README to english from this document.

👍