Add event API with events willparse and parsed

This PR adds API for events. It works the same way it does in DOM (but it doesn't support bubbling/catching). For now, only two events are supported: willparse and parsed, both events are dispatched when the function md.parse (or md.parseInline) is called before and after the parsing respectively.
The events are really useful when making an auto-numbering extension, so that you can reset the number before each rendering, or generally for every extension that needs to manage some document-wide data that should be reset with each rendering. Also, they make the markdown-it library more transparent to the external code.
New methods:
function addEventListener(name: string, fn: (e: Event) => void);
function removeEventListener(name: string, fn: (e: Event) => void);
function dispatchEvent(name: string, props: object);

Example usage:
md = markdownit();
md.addEventListener('parsed', (e) => updateMyStuff());
md.render('*a*'); // event called

I don't believe it's possible to test that one line Coveralls marks as missing coverage…

Sorry, events API does not fit into existing architecture (and can trash performance). You can get similar effect by adding new fake rules or by replaying tokens with your own code.

I don't really understand why events should be any slower than fake rules:

in case of a fake rule, you push a callback to an array, and with each subsequential parsing a State gets constructed, the array of rules is iterated and each rule is called.
in case of an event, you push a callback to an array, and with each subsequential parsing an Event gets constructed, the array of events is iterate and each callback is called.

The difference is that with fake rules you have to use a block rule, correctly place it in the rule list (and hope it doesn't get overriden by any other extension), and shortcircuit it by state.pos = state.posMax. This is more prone to errors and requires deeper understanding of the whole library. And the point of libraries is not having to understand how exactly does it work.
So could you explain to me, please, why in particular did you find this PR not worth merging?

I'm very conservative about API changes, because it can be cluttered very quickly, if we start add  everything anyone can imagine. For significant changes, 2 conditions should be satisfied:

Desired result can NOT be reached in any other way.
This change is needed for many people.

Your PR does not seems to satisfy any (or may be i could not understand).
Also, as a side note, it looks strange to have 2 different approaches for extensions. But the main reasons of decline are above. Existing design is stable and self-sufficient, with all known limitations. If someone decide to bring a new breath into markdown parsers, all info is collected in https://github.com/markdown-it/markdown-ast-spec.

Thanks for your reply. If you're really meticulous about the first rule, then there's nothing I can do to make my PR pass it. You definitely can create fake rules (or even monkey-patch the parse method) but it feels wrong and overly complicated to me.
However, as the PR doesn't comply with rule 1, I can always make an extension for this, so hey, let's not merge this.

I'd suggest you to start using parser, because first impression may be wrong and writing complicated plugins is not trivial thing. If after several months, when you understand well all details, you still think that changes are really needed, we can return to your proposal again. To save your time - please create issue first, to discuss details and make sure if PR will be merged.


Logging + Optimization improvements

[NF] Add a generic way to define loggers in Pyleecan.
All logger are defined in Pyleecan/loggers.py in a dict config inspired from [this example].(https://stackoverflow.com/a/59241472).
A default logger Pyleecan is defined and specific loggers are defined for the following classes:

Output
Simulation
Machine
OutElec
OutMag
OutStruct
OutGeo
OptiGenAlg

The classes above have in their csv file the logger_name attribute corresponding to a logger defined in the config dict in Pyleecan/loggers.py.
Two config dict have been defined to use console text loggings or files. The config choice is in Pyleecan/__init__.py.
Every class has a method get_logger that get the class logger or the parent class logger or the default logger.

Thank you for your contribution :)


Spirit's JEI plugin works fine with JEMI in singleplayer, but causes severe graphical issues in multiplayer

The mod Spirit adds a few unique recipe categories to JEI, at least one of which renders blocks using the Minecraft client's own BlockRenderDispatcher / BlockRenderManager.
Here's an example of one such recipe, displayed in EMI via JEMI:

However, this is the same recipe viewed when connected to a multiplayer / dedicated server:

.
In-game, the dark rectangle near the center of the screenshot is the only part of the screen that continues to update normally. Everything outside of the rectangle will rapidly flash between black and what was visible at the time the recipe was first accessed (i.e. what's visible in the screenshot) until the game is exited.
This is the error thrown in the client log on a dedicated server:
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:100)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at java.base/java.util.Objects.checkIndex(Objects.java:385)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at java.base/java.util.ArrayList.get(ArrayList.java:427)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at me.codexadrian.spirit.compat.jei.multiblock.RotatableList.getCurrent(RotatableList.java:16)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at me.codexadrian.spirit.compat.jei.categories.SoulEngulfingCategory.draw(SoulEngulfingCategory.java:133)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at me.codexadrian.spirit.compat.jei.categories.SoulEngulfingCategory.draw(SoulEngulfingCategory.java:44)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at dev.emi.emi.jemi.JemiRecipe$JemiWidget.method_25394(JemiRecipe.java:157)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at dev.emi.emi.screen.RecipeScreen.method_25394(RecipeScreen.java:225)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at net.minecraft.class_757.method_3192(class_757.java:881)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at net.minecraft.class_310.method_1523(class_310.java:1177)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at net.minecraft.class_310.method_1514(class_310.java:768)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at net.minecraft.client.main.Main.method_44604(Main.java:244)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at net.minecraft.client.main.Main.main(Main.java:51)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at org.quiltmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:551)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at org.quiltmc.loader.impl.launch.knot.Knot.launch(Knot.java:84)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at org.quiltmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:28)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:125)
[13:19:56] [Render thread/INFO] (Minecraft) [STDERR]: 	at org.prismlauncher.EntryPoint.main(EntryPoint.java:70)

This is, I believe, the relevant code in Spirit: https://github.com/terrarium-earth/Spirit/blob/c14173bc2d304250a3a3a964ecc653113e932e9e/common/src/main/java/me/codexadrian/spirit/compat/jei/categories/SoulEngulfingCategory.java#L129-L136
Versions:

Minecraft 1.19.2
Fabric Loader 0.14.25
Fabric API 0.77.0+1.19.2
EMI 1.0.28+1.19.2+fabric
JEI <IP_ADDRESS>8
Spirit 2.2.6

This seems to be a bug in Spirit that you could replicate in JEI, and has nothing to do with EMI. My assumption is they are not serializing their block map properly and it's not getting sent to the client in multiplayer, causing an index out of bounds exception. I believe this bug is the relevant issue on their repo: https://github.com/terrarium-earth/Spirit/issues/61


[SR-13096] Fix autodiff typing rules for class-typed function parameters

Previous ID
SR-13096

Radar
rdar://problem/72819053

Original Reporter
@dan-zheng

Type
Bug

Additional Detail from JIRA

Votes
0

Component/s
Compiler

Labels
Bug

Assignee
None

Priority
Medium

md5: bece69c35790a09fc5e98c37400842e1

relates to:

TF-1175 Self-mutating class method call is not marked active

Issue Description:
Fix @differentiable and @derivative type-checking for class-typed function parameters.
Class-typed values have reference semantics and can be freely mutated. Thus, they should be treated like inout parameters for the purposes of @differentiable and @derivative type-checking.

Example:
import _Differentiation

class Class: Differentiable {
  var x: Float = 0

  // Semantically acts like `Class.x.set`.
  // Type: `(Class) -> (Float) -> Void`.
  func setterForX(_ newValue: Float) {
    self.x = newValue
  }

  // This VJP is expected to pass type-checking but does not.
  @derivative(of: setterForX, wrt: (self, newValue))
  func vjpSetterForX(_ newValue: Float) -> (
    value: (), pullback: (inout TangentVector, Float) -> Void
  ) {
    fatalError()
  }
}

Unexpected error, because the class-typed self parameter is not treated as a "semantic result" by autodiff::getFunctionSemanticResultTypes.
class.swift:13:4: error: cannot differentiate void function 'setterForX'
  @derivative(of: setterForX, wrt: (self, newValue))
   ^              ~~~~~~~~~~

@dan-zheng Why the pullback in the testcase has (inout TangentVector, Float) -> Void function type? Shouldn't it be (inout TangentVector) -> Float as we're having wrt for both arguments?

Original function: `setterForX`
VJP function: `vjpSetterForX`

Original type: (inout Self, Float) -> Void
Differentiable wrt: (0, 1)
Pullback type: (inout Self) -> Float

Yes, I think you're right. I'll update the issue description, thanks.

Great, thanks. I'm having locally, so this will be a part of larger PR:
// reverse-mode derivative of Class.setterForX(_:)
sil hidden [thunk] [always_inline] @$s4main5ClassC10setterForXyySfFTJrSSpSr : $@convention(method) (Float, @guaranteed Class) -> @owned @callee_guaranteed (@inout Class.TangentVector) -> Float {
// %0                                             // user: %3
// %1                                             // user: %3
bb0(%0 : $Float, %1 : $Class):
  // function_ref Class.vjpSetterForX(_:)
  %2 = function_ref @$s4main5ClassC13vjpSetterForXyyt5value_SfAC13TangentVectorVzc8pullbacktSfF : $@convention(method) (Float, @guaranteed Class) -> @owned @callee_guaranteed (@inout Class.TangentVector) -> Float
 // user: %3
  %3 = apply %2(%0, %1) : $@convention(method) (Float, @guaranteed Class) -> @owned @callee_guaranteed (@inout Class.TangentVector) -> Float // user: %5
  // function_ref autodiff self-reordering reabstraction thunk for @escaping @callee_guaranteed (@inout Class.TangentVector) -> (@unowned Float)
  %4 = function_ref @$s4main5ClassC13TangentVectorVSfIegld_AESfIegld_TJOp : $@convention(thin) (@inout Class.TangentVector, @guaranteed @callee_guaranteed (@inout Class.TangentVector) -> Float) -> Float // user: %5
  %5 = partial_apply [callee_guaranteed] %4(%3) : $@convention(thin) (@inout Class.TangentVector, @guaranteed @callee_guaranteed (@inout Class.TangentVector) -> Float) -> Float // user: %6
  return %5 : $@callee_guaranteed (@inout Class.TangentVector) -> Float // id: %6
} // end sil function '$s4main5ClassC10setterForXyySfFTJrSSpSr'


Extract errexit logic into methods

This PR continues work of #812.
Ensure that caching and deployment occurs with errexit option off.
Some builds source bash files that set errexit (e.g., set -e). When our caching and deployment commands fail, this option leads to immediate job termination, which can be very confusing.
An example build is https://staging.travis-ci.org/BanzaiMan/travis_staging_test/builds/507340.
On https://staging.travis-ci.org/BanzaiMan/travis_staging_test/builds/507340#L166, caching command fails, and on https://staging.travis-ci.org/BanzaiMan/travis_staging_test/builds/507340#L196 the deployment (which is just calling false) fails. In both of those cases, the job continues to completion.

Also in production: https://travis-ci.org/BanzaiMan/travis_production_test/builds/149808795


Doc: 'Warning' is misspelt as Warining

Location
README.md
Actual Behavior
The header 'warining' seems to be a spelling mistake. The correct word would be warning. If this is intentional, please feel free to dismiss this issue. If it isn't, I'll happily create a pull request to fix this.
(I know how silly it is to file an issue over so minor a mistake, I hope I'm not wasting your time)

Well, that's kinda embarrassing especially when it's a title which is bold and larger 😂
Thanks for reminding me, I can fix that by myself. By the way any issues are welcomed, as they all show your concern to this project. :heart:


Python Code Generator and Tree-Rewrite Engine for Python Parser

Hi all,
in my Python IDE I need emulate synchrounous Python code in the browser. The reason for this is that we cannot teach young students asynchronous programming paradigma using async and await keywords. The path I want to do this is using dt-python-parser, then to use a grammar-based tree-rewrite engine for AST to rewrite synchronous code to asynchronous and finally use a Python synthetizer to generate Python Code again.

Before I will implement Python Code Generator and Python Tree-Rewrite Engine I want to ask if anyone is not already working on this issue.

My second question is if you want this contribution to make part of dt-python-parser? It would be quite fine to have it in one library.

Thanks very much for answer.

cannot teach young students asynchronous programming paradigma using async and await keywords

@evonox Sorry, I can't understand that~ I think that implementing Python Code Generator and Python Tree-Rewrite Engine are big and complex work.  we know that Python is a very mature language, I think you can find out some implements in the community.
The background of dt-python-parser is that supporting our frontend project, which only needs syntax check, code formatting, and so on simple features.  so I think to make it be part of  dt-python-parser is not suitable.

@evonox is your rewrite engine available publicly anywhere yet?  You asked a little over a year ago.  I do a little Python parse tree restructuring and rewriting in my use of DT Python Parser but my rewrite code is heavily coupled to the rest of my application and I won't be willing to releasing the code very openly any time soon.  I'm up for sharing concepts and brainstorming ideas, if you want to learn a bit from what I've done, though.  Want to share an email address or another way to get in touch?

@joshi1983 To be honest, my idea for Python Rewrite engine remained only idea. But if there would be an interest, it might be a great tool to create in an open-source way. My initial idea is to take inspiration in BabelJS and create it in the similar architecture. What do you think?


bug: abandoned floating window does not close

Did you check the docs and existing issues?

[X] I have read the docs
[X] I have searched the existing issues

Neovim version (nvim -v)
0.8.2 build type: release
Operating system/version
archlinux, 6.1.2-arch1-1
Describe the bug
If you abandon a floating window created by oil it stays there.
Steps To Reproduce

:Oil
g?
<C-w>h
hit enter on a file -> it opens the file but the oil-help is still shown

or:

:lua require'oil'.open_float()
<C-w>h
oil still shown

Expected Behavior
close all oil created windows as soon as a non-oil-created window gains focus
Directory structure
No response
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({
    "git",
    "clone",
    "--filter=blob:none",
    "--single-branch",
    "https://github.com/folke/lazy.nvim.git",
    lazypath,
  })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  {
        "stevearc/oil.nvim",
        config = function()
            require"oil".setup() -- add any needed settings here
        end,
  },
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

Done!

Nice, however, this does not cover the second test case I provided... An abandoned open_float() has the same problem

@stevearc please reopen

Apologies, I was in a rush. Should be working as expected now


Add support for variable sharing within magic commands

Currently, magic commands don't allow providing arguments using variables defined in the kernel. An API for doing this would be very helpful.
For example, in the Python kernel, you can do this:
%magic $variable

Things to consider:

How should a value be escaped when you want to pass a literal string that matches the variable expansion syntax, e.g. #!magic "${variable}"?
How can the syntax support specifying the source kernel where the variable is declared, e.g. #!magic ${fsharp:variable}?
How should the variable's value be stringified?
Should object traversal be enabled, e.g.? #!magic ${someObject.Property}?

What about other expressions, e.g. #!magic ${someObject.Things.Single()}?

I included the last top-level bullet for the sake of discussion, but I'm inclined not to support it because the tooling experience (code coloring, error squiggles, completions, etc.) becomes very complicated and potentially confusing across different languages.

@LadyNaggaga @dsyme @tanhakabir We've discussed this a bit before so if you'd like to contribute to the discussion here, please do.

I would definitely be in favour of this.
Potential use case I first thought of.
gather SQL instances from a database table or file with PowerShell using dbatools, create sql kernel connection dynamically to enable troubleshooting notebooks to be generic and passed to clients.

Great use case! We have a few related issues under https://github.com/dotnet/interactive/labels/Area-Automation

Hm quick thought:

Should object traversal be enabled

I think this is quite important for my REST Book language since I save the entire response to one object/variable and have the user traverse in for the specific piece of information they want to use.

For anyone who is just finding a way to dynamically run a magic command, and does not mind to deal with stringifing the parameter and join the strings into a command, there is an alternative:
using Microsoft.DotNet.Interactive;
using Microsoft.DotNet.Interactive.Commands;

var kernel = await Kernel.GetInputAsync("kernel-spec:");

var s = $"#!connect jupyter --kernel-name python --kernel-spec {kernel}";
await Kernel.Root.SendAsync(new SubmitCode(s));

You can request input within a magic command using the following syntax:
#!connect jupyter --kernel-name python --kernel-spec @input:kernelSpec

This issue should have been closed as implemented a while back. The documentation about how to use shared variables within magic commands can be found here:
https://github.com/dotnet/interactive/blob/main/docs/variable-sharing.md


Don't show None return type for classes

While an __init__ technically returns none, showing --> None is confusing in signatures like the one below.
It would make more sense to show no return type at all for class initializers.

Originally posted by @laurensvalk in https://github.com/pybricks/pybricks-api/issues/72#issuecomment-894088009

This has been fixed upstream based on the issue we reported in https://github.com/sphinx-doc/sphinx/issues/10280.

This was fixed upstream, so closing.


docs: Fixes decorator name

Information

Type
Breaking change

Doc
No

Fixes authentication docs
Replaces reference to Operation decorator with a reference to the In decorator.
This is in line with the comment https://github.com/tsedio/tsed/issues/1053#issuecomment-723181198 and fixes what may be the cause of one of the questions about the Operation decorator.

:tada: This PR is included in version 7.36.0 :tada:
The release is available on:

v7.36.0
GitHub release

Your semantic-release bot :package::rocket:


Unable to send max eth using phantom and metamask

Overview
I initially thought phantom was rejecting the transaction because their fee estimations are very high, it says 10$ of fees while Metamask says 6$ and we are also having 6$ fees, they simulations are then failing and they refuse even before signing (as a guess), but finally Metamask also failed so, we might fail from our side
References and additional details
Reproduction steps:

Click send max ETH
Sign the TX using MM or Phantom
TX is sent but not picked up and finally it fails

https://jam.dev/c/e5aa3fb1-1dc7-4aac-80dd-c3de32547130
Acceptance Criteria
Being able to send max ETH with phantom
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response

I did try again using MM, couldn't reproduce, it was probably failing because of the network state


simplification for gltf

I am a new man in glTF. I'm trying to stream a big size glTF model. While the higher detail is not needed, so I compressed the texture images. But the size is still not small enough, so I wonder if there is any way to simplify the model by compressing the triangles, including the textured models.
Thank you for your help!

You can use the --quantize, --encodeNormals, and --compressTextureCoordinates flags to compress positions, normals, and texture coordinates respectively. Also resizing the input textures may help too if you have a lot of texture data.

I tried the flags and no error reported. The size of model is down about 30%. But after I converted it to .b3dm model, it cannot be visualized in my browser. And the gltf model cannot be visualized too. The decompressed model can be visualized. Please give me some advise.
Thanks for your patience!

Hm.. can you send over the model you're converting? That will help us debug the problem. Feel free to upload it here or send it to me at<EMAIL_ADDRESS>


paintImageRect() crashes if you pass it a fake ui.image

I accidentally ran one of our image rendering tests all the way to the paint phase, and it tried to send an object defined more or less as:
class TestImage implements ui.Image { ... }

...to Canvas::drawImageRect and that promptly crashed on line 209:
    ASSERT(image);

The Dart bindings should throw a useful exception if you try to pass a "fake" image over.
See also #70, #77.

One way to fix this is probably to stop using IDL and start using the direct binding I was working on in https://github.com/flutter/engine/pull/2116

https://github.com/flutter/engine/pull/3811


no flags works in AUR

If we use flags like -h or -l, they through error papirus-folders: Error: Unable to find '-l' color in 'Papirus-Dark'

sorry, it was my fault due to some alias. script is good.


"Check BIP39 recovery phrase" from the NanoS app freezes.

I on my NanoS (fw 2.0.0) I installed the v1.4.0 that I had built in my debian VM.
(with git clone https://github.com/aido/app-sskr-check)
I did this mainly to test if the check sskr shares choose a different word # bug was still there (it is) and if the choose word # 1 bug is still there when you have already entered > 5 words (it is).
Using the other function Check BIP39 seed is also broken.  I entered my 12 word mnemonic seed, and get to "Processing".  The loading animation briefly turns, then the whole NanoS freezes.  I waited >30 mins, and the screen remains frozen on Processing.
I then uninstalled v1.4.0 and reinstalled the v1.3.2 github release binary
Same result, app SSKR Check on NanoS (fw 2.0.0) freezes on "Processing" after a very brief circle animation

Nearly all testing was done using Speculos and this behaviour was not seen. I may have to test some more on an actual device not an emulator.

Same result with Ledger NanoS firmware 2.1.0.  Updating via Ledger Live, the update removed all apps from NanoS.
$ python3 -m ledgerblue.loadApp --appFlags 0x10 --tlv --targetId 0x31100004 --targetVersion="2.1.0" --delete --fileName nanos/bin/app.hex --appName "SSKR Check" --appVersion "1.3.2" --dataSize 0 --icon<PHONE_NUMBER>ffffff00ffffffffffffffc3f1c1c3c083e107fb0fff3ffe7ffe7ffe7ffe7ffeffffffff --curve secp256k1 --path ""
Generated random root public key : b'04061afc36158ffe4a126d64411935ce8dae1fca422ff1ae764ab33815062a12f5dfaa654cb69771c1a6b3dce4c1668c8f9832fc395d0ecf86ac214ee2b3c649b5'
Using test master key b'04061afc36158ffe4a126d64411935ce8dae1fca422ff1ae764ab33815062a12f5dfaa654cb69771c1a6b3dce4c1668c8f9832fc395d0ecf86ac214ee2b3c649b5'
Using ephemeral key b'045bfb72d93281de22b70a198272155278ff9f98a36c32eb33a0b69b685597e125840d3100f66e35e7dbd54f5291437962ae6927e73dd4e553f9c1be2c74bd8612'
Broken certificate chain - loading from user key
Application full hash : b448806cf44c22186b9303c62f3991a5d79fe098946155c70ae43f6b71849c8d
"Check BIP39 recovery phrase" freezes after entering my 12 words mnemonic on NanoS

OK, I'll look into it. This definitely does not happen when using automated testing on Specuos. and ragger.
Here's the results of the automated tests for 12 word, 18 word and 24 word BIP39 phrases ... all pass:
https://github.com/aido/app-sskr-check/actions/runs/5029228287/jobs/9020670231

Hi @InfiniteQE ,
No, I have not tested on a physical Nano S or S+ yet.
However, I have raised an issue with Ledger to see if I can get a lot or all of the finite field processes performed by syscalls rather than writing our own code to do it.  Maybe this will affect the issue you are having.
See the issue I raised here:
Additional syscalls for finite field operations

The gf_syscalls branch makes a significant change to how the app generates Shamir's Secret Shares. It changes the interpolate function to use syscalls for Galois Field operations. There are pros and cons to these changes.
The following could be argued:

Using syscalls is more secure
I am not familiar with the inner working of the Secure Element on each device but using syscalls will give the possibility of using a hardware accelerator if one is present
The resulting binaries are slightly smaller which is important as the app is already almost at the limit if the flash size of a nano device.

It could also be argued:

The original code performing interpolation uses bit slicing for the Galois Field operations. This may be more efficient even if the Secure Element has a hardware accelerator.

The syscall used to rewrite the interpolate functionality is called cx_bn_gf2_n_mul(). This syscall is currently not available on Ledger nano devices but is available on the other devices. I have raised an issue with nanos-secure-sdk to see if it can be added: https://github.com/LedgerHQ/nanos-secure-sdk/issues/64

app-seed-tool is forked from Ledger's app-recovery-check. I have encountered this same issue when sideloading app-recovery-check onto a Nano S device. The strange thing about it is that if app-recovery-check is installed from the Ledger Live this issue is not encountered.
I have raised an issue with app-recovery-check: LedgerHQ/app-recovery-check#15


Add Fargate Restate deployment construct

Bypassing review requirements; this change was already reviewed as part of https://github.com/restatedev/cdk/pull/26 and https://github.com/restatedev/cdk/pull/27 - using a PR just for the sake of creating a squash commit.


[request] Menu bar to be implemented next

Can I please suggest that Menu bar to be the next in pipeline as it is required on almost all websites.

Menu bar? Like cascading menus? Or you mean the dropdown menu?
https://material.google.com/components/menus.html#menus-usage

I was just looking at the new components in projects. Did I miss something

Well. Both components md-menu and md-menu-bar are on my roadmap.
The first one will have a higher priority and will look like a md-select and the second have a behaviour like the Google Docs toolbar.

Awesome

Do you have the roadmap published anywhere? Unfortunately, the applicability of this is limited to me until data tables are implemented.

Not yet. But I will publish the milestones this week. Just need to fix some bugs and then I will focus on this new components.

The md-menu component it's already being implemented. Keep track on #19


Error when compiling dense_flow

Thanks for your contribution!
The error is shown as follows:
-- Could NOT find LIBZIP (missing: LIBZIP_LIBRARY LIBZIP_INCLUDE_DIR_ZIP LIBZIP_INCLUDE_DIR_ZIPCONF)
-- Boost version: 1.58.0
-- Found the following Boost libraries:
--   python
-- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython2.7.so (found version "2.7.12")
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.

Could any one help me?

I met the same problem.Do you feed it or does someone can give some tips?

You need to install libzip to compile DenseFlow. I would suggest you use the provided docker image to avoid this compilations.


DEPRECATED - Fix small typos (DEV)

Checklist

[ ] Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
[ ] If this PR comes from a fork, please Allow edits from maintainers
[ ] Set a speaking title. Format: {task_name} (closes #{issue_number}). For example: Use logger (closes # 41)
[ ] Link your Pull Request to an issue - Pull Requests that are not linked to an issue with you as an assignee will be closed, except for minor fixes for typos or grammar mistakes in documentation or code comments.
[ ] Create Work In Progress [WIP] pull requests only if you need clarification or an explicit review before you can continue your work item.
[ ] Make sure that your PR is not introducing unnecessary reformatting (e.g., introduced by on-save hooks in your IDE)
[ ] Make sure that your PR does not contain changes in text files, therefore the PR must not contain changes in values/strings/* and / or assets/* (see issue #332 for further information)
[ ] Make sure that your PR does not contain compiled sources (already set by the default .gitignore) and / or binary files

Description

Law firm provided a few minor changes to the EULA.

@SabineLoss originally this targeted the master branch. I suppose it should go into Release 1.5.x instead?

I suggest to NOT merge this PR and close it in favor of this PR:
https://github.com/corona-warn-app/cwa-app-android/pull/1318
It is properly rebased on Release 1.5.x.


Support annotating fields with field extensions

Interesting, I implemented a similar feature here:
https://github.com/tony612/protobuf-elixir/pull/91/files#diff-b29046f70a5e38390cd6f773e215597cR50

Interesting, I implemented a similar feature here:
https://github.com/tony612/protobuf-elixir/pull/91/files#diff-b29046f70a5e38390cd6f773e215597cR50

@ulissesalmeida that is very interesting! This pr was intended to simply expose custom field options in the dsl, but we want to swap out the using protobuf macro https://github.com/tony612/protobuf-elixir/pull/87 and use these field options is to cast types like in gogoproto https://github.com/gogo/protobuf/commit/a2aaeaf7b6dcf98a4a400e026a94713ef90e1ac6#diff-c8ef3ed341f269ec9c5f2f199d371b7b.
One benefit to the field option vs message option approach is that you don't have to go modify the canonical google protos.
Regardless of the implementation though, casting is a extremely useful feature. I agree with your points in #90 and #89, it sucks to keep converting to convenient types in code and would be great if we could configure the compiler to do it for us.
Looking through other prs, #85 is actually extremely similar to this one (I should have checked before). @tony612  left a comment on it detailing that he thinks its better to write supporting compilers than to modify this one: https://github.com/tony612/protobuf-elixir/pull/85#issuecomment-602059403. However with type casting I don't know if that would be truly possible. For example the generated type for the struct will be wrong unless the generator is changed to be aware of these field options.
@ulissesalmeida I would love to know any thoughts you have about moving forward and @tony612 yours as well. Should specifying the generated elixir type for a field be something protobuf-elixir supports?

@lizziepaquette Thank you for thoughts.
I agree with you about having field types annotation too. Make sense 👍
Now, about plugins vs changing the compiler approach, it's a hard decision, I don't know what's the best.
Having some plugins supports makes sense, or every time we want to add some extension/feature we need to change the original library. It can be very painful for the maintainers. But these plugins should be able to allow a lot of callbacks/hooks.
However, some stuff sounds good having in the core compiler, like a way to annotate your types or automatically transform some types.
I'm very new in this protobuf world, then I did was easier for me that was: change the core library(that is in elixir haha)

@lizziepaquette Thank you for thoughts.
I agree with you about having field types annotation too. Make sense 👍
Now, about plugins vs changing the compiler approach, it's a hard decision, I don't know what's the best.
Having some plugins supports makes sense, or every time we want to add some extension/feature we need to change the original library. It can be very painful for the maintainers. But these plugins should be able to allow a lot of callbacks/hooks.
However, some stuff sounds good having in the core compiler, like a way to annotate your types or automatically transform some types.
I'm very new in this protobuf world, then I did was easier for me that was: change the core library(that is in elixir haha)

This new pr has full fledged type casting, love to hear your thoughts. https://github.com/tony612/protobuf-elixir/pull/100

@lizziepaquette
Interesting
But I have one question, how a user can extend and add their own types?
This approach is very different from mine here:
https://github.com/tony612/protobuf-elixir/pull/91
Correct me if I'm wrong, your approach is based on fields right?
Let's say, for this message I want this field to be converted to a string.
I believe your changes(field approach) make it more flexible and explicit where you want automatic transformations to happen. However, if you want to make it uniform, you have added those annotations in every place it's needed(can be error-prone).
Meanwhile, my approach is based on messages.
Let's say, I want this message to be a String, in the end, no matter where it's used.
It's good to make it uniform for all messages in the same app, but for some reason, I want to create exceptions, it's impossible (or harder, I would have to implement it 😆 ).
I think both approaches can live in the core library, but I'm not sure if the library author will want to adopt either haha.


vscode plugin formatting bug

Bug description

With the new vsode extension, if there is a @unique modifier in a line , the comment following it will be aligned after all the other comments in other lines
How to reproduce

Expected behavior

Prisma information

Environment & setup

OS: [e.g. Mac OS, Windows, Debian, CentOS, ...]
Database: [PostgreSQL, MySQL, MariaDB or SQLite]
Prisma version: [Run prisma -v to see your Prisma version]
Node.js version: [Run node -v to see your Node.js version]

I can confirm this behavior:
model test {
  id  Int   @default(autoincrement()) @id // Comment 1
  foo foo[] // Comment 2
  bar bar? @relation(fields: [id], references: [id]) // Comment 3
}

becomes
model test {
  id  Int   @default(autoincrement()) @id             // Comment 1
  foo foo[] // Comment 2
  bar bar?  @relation(fields: [id], references: [id]) // Comment 3
}


Invalid syntax for version number

Installed MMS with following command:
pip install --pre mxnet-model-server
Got error while running mxnet-model-server command:
roshanin$ mxnet-model-export --model-name="pretrained-alexnet" --model-path="/tmp/models" --service-file-path="/tmp/models/gluon_pretrained_alexnet.py"
/Users/roshanin/anaconda2/lib/python2.7/site-packages/h5py/__init__.py:34: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.dtype(float).type`.
  from ._conv import register_converters as _register_converters
/Users/roshanin/anaconda2/lib/python2.7/site-packages/urllib3/contrib/pyopenssl.py:46: DeprecationWarning: OpenSSL.rand is deprecated - you should use os.urandom instead
  import OpenSSL.SSL
Traceback (most recent call last):
  File "/Users/roshanin/anaconda2/bin/mxnet-model-export", line 7, in <module>
    from mms.export_model import export
  File "/Users/roshanin/anaconda2/lib/python2.7/site-packages/mms/__init__.py", line 22, in <module>
    from . import version
  File "/Users/roshanin/anaconda2/lib/python2.7/site-packages/mms/version.py", line 14
    __version__ = 0.4b2
                      ^
SyntaxError: invalid syntax

Yes with beta version, the version the version read within mms fails, this works fine for non beta releases. Will be a priority fix


change WebViewWrapper.java

Vulnerability in the line mWebView.loadUrl("data:text/html;charset=utf-8;base64," + base64); is related to the potential for an XSS (Cross-Site Scripting) attack if the submitted javascript is not properly sanitized and validated. The code takes a javascript string from an external source (presumably) and embeds it in the URL using the data: URI scheme. If javascript contains malicious JavaScript code, this code will be executed in the context of the WebView, which may lead to compromise of the application. I added input sanitization.

Thank you! I'll take it into account


Refactor from script => proper python package

@Bajoukx I made (most) of the changes requested -- exceptions being for ones that aren't quite necessary yet (e.g. moving to absl). Going to merge this later today if there's no other major changes needed

Sorry guys I think the approval settings has it so that it auto dismisses reviews when theyre stale -- I can remove that if we want though


Splunk SC4S with Palo Alto

I have this issue with Sc4s to onboard Palo Alto logs. the logs were coming in well until recently when the logs started going to the scrc_fallback sourcetype. I need help with creating a custom filter for it. Thanks

We need samples of the event from fallback the most common issue we have seen is misconfiguration where the source is changed to send ietf format to 514 instead of the 601 port

Thanks. Here is the sample log:
New Sample in sourcetype=fallback:
PRI=13
MESSAGE=350 <14>1 2021-06-23T09:24:31-05:00 Panorama.xxxx.local - - - - 1,2021/06/23 09:24:31,000702285065,SYSTEM,monitoring,0,2021/06/23 09:24:31,,deviating-device, ,0,0,general,informational,"Deviating device: XXX-xxxxxxx-1, Serial: xxxxxxxxx6, Object: N/A, Metric: logging-rate,
Value: 1",1647828,0x0,0,0,0,0,,Panorama,0,0,2021-06-23T09:24:31.000-05:00
Old Sample in sourcetype=pan:system
349 <14>1 2021-05-18T10:05:36-05:00 Panorama.xxxx.local - - - - 1,2021/05/18 10:05:36,000702285065,SYSTEM,monitoring,0,2021/05/18 10:05:36,,deviating-device, ,0,0,general,informational,"Deviating device: XXX-xxxxxxxxx-1, Serial: xxxxxxx1, Object: N/A, Metric: logging-rate,
Value: 1",599191,0x0,0,0,0,0,,Panorama,0,0,2021-05-18T10:05:36.000-05:00

This is a configuration issue on the palo side covered in docs. when using IETF (standard format) the port should be 601 not the legacy BSD 514 port

hello.
is this log the same? or a different issue?  all the logs are configured BSF format
the end of the message is after the beginning of the message
RAWMSG=255.255,,1,1,aged-out,1634,2411,2135,0,vsys1,FW04,from-policy,,,0,,0,,N/A,0,0,0,0,6d4f58b2-5528-474b-b85a-b371f6d82177,0,0,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,2022-08-15T18:47:49.996+00:00,,,infrastructure,networking,network-protocol,3,"used-by-malware,has-known-vulnerability,pervasive-use",dns,dns-base,no,no,0
<14>Aug 15 18:47:51 palo_alto_panarama_host 1,2022/08/15 18:47:51,012501003398,TRAFFIC,end,2561,2022/08/15 18:47:49,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,dns-services,local_domain\userone,,dns-base,vsys1,corp_trust,corp_dc,ae8.1852,ae8.1854,Panorama,2022/08/15 18:47:49,72223499,1,60737,53,0,0,0x19,udp,allow,317,92,225,2,2022/08/15 18:47:18,0,any,,7107085280655064783,0x8000000000000000,<IP_ADDRESS>-<IP_ADDRESS>,<IP_ADDRESS>-10.255.
PRI=13
MESSAGE=255.255,,1,1,aged-out,1634,2411,2135,0,vsys1,FW04,from-policy,,,0,,0,,N/A,0,0,0,0,6d4f58b2-5528-474b-b85a-b371f6d82177,0,0,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,2022-08-15T18:47:49.996+00:00,,,infrastructure,networking,network-protocol,3,"used-by-malware,has-known-vulnerability,pervasive-use",dns,dns-base,no,no,0
<14>Aug 15 18:47:51 palo_alto_panarama_host 1,2022/08/15 18:47:51,012501003398,TRAFFIC,end,2561,2022/08/15 18:47:49,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,dns-services,local_domain\userone,,dns-base,vsys1,corp_trust,corp_dc,ae8.1852,ae8.1854,Panorama,2022/08/15 18:47:49,72223499,1,60737,53,0,0,0x19,udp,allow,317,92,225,2,2022/08/15 18:47:18,0,any,,7107085280655064783,0x8000000000000000,<IP_ADDRESS>-<IP_ADDRESS>,<IP_ADDRESS>-10.255.


feat: update icons

feat/update-icons

If Vitamix is now a generated class, we should maybe add it to sonar.cpd.exclusions to avoid quality date failure on Sonar du to code duplication

@florentlotthepro Can you rename IconModel+Sections.swift to IconsModel+Sections.swift in order to align with the existing file called IconsModel.swift? Thanks.
@mackoj for your info

@lauthieb Fixed 🙂

Thanks @florentlotthepro!
@daniel-dumortier @mackoj can we please have your review in order to merge this PR? 🙏


feat(apple): Write app and tunnel log to disk

Fixes #2721.
Under ~/Library/Group Containers/<container>/Library/Caches/logs/:

App logs are written to app/app.0.log
Tunnel process' Swift code's logs are written to tunnel/tunnel.0.log dir

These and connlib logs are part of exporting logs and clearing logs.
The log entries are written to human-readable text files, one log entry per line. Once a file exceeeds 1 MB, it starts writing to the next file (like app.1.log). After it reaches past app.4.log, it overwrites app.0.log. The current log index is maintained in a separate file. While it's opening the next log file, log calls are not kept waiting -- log entries are written to a buffer temporarily, and once the next log file is open, the buffered logs are dumped into it.

Consider log write errors to be fatal (is this only when disk is full or perms issues? The user should really fix these before running Firezone)

The app will still be usable without being able to write errors to disk (like it happened before this PR). That's why I didn't want to consider it as a fatal error.

Could you prepend the filename with the datetime like connlib does (same format)

I think connlib timestamps correspond to when it starts a new log (like when the session starts, or when it starts afresh after uploading the log).
The app / tunnel keeps appending to the log until it reaches a file size limit.
With these strategy differences, will it be of help if we prepend the timestamp to the filenames? If you think yes, then I can do that.

Could you print JSON logs instead of human-readable logs? If you could follow the connlib log format that would be super helpful in allowing us to cross-examine connlib logs and app logs when debugging

Ok, I can do that.

The app will still be usable without being able to write errors to disk (like it happened before this PR). That's why I didn't want to consider it as a fatal error.

Gotcha. Just trying to keep complexity low to keep cognitive overhead low across clients, but if this logic is well tested then I suppose this is ok. The other clients will barf if they can't write to disk (which is fine) so that's why I thought of it.

Do you think there's value in adding the timestamp to the log file, given that it might not correspond to connlib's?
Is it ok to continue using a log index to identify old logs to remove, or would you want to use the exact same filename format as connlib, and identify the old files using the timestamp prefix?

Yeah it would be good to prefix the filename with a timestamp even if it doesn't match connlib's. What we're finding is that customers want to poke around and view the logs as well.
For us, we need a way to go "client had connection issue -> find it in connlib log -> cross-check it in app log". Today, that could just be cat * | grep ... | less but the timestamp would be helpful to at least know which file to look in

Ok, I can do that. I'm assuming only these fields are required fields: time, target, severity, message, and the others can be skipped.

Yep, perfect

This PR now:

Includes a timestamp in the filename, like: app_macos.2024-01-30-01-55-11.3.log (3 is the log index)
Writes logs to disk in a JSON format, like{"message":"Starting logging","severity":"DEBUG","target":"app_macos","time":"2024-01-29T20:27:04.726Z"}

The keys in the JSON are not ordered in the same way as connlib -- they're sorted alphabetically.


Update package index with latest published versions

Update package index with latest published versions

/azp run azure-sdk - ci

Update package index with latest published versions
curl -L
-X PUT
-H "Accept: application/vnd.github+json"
-H "Authorization: Bearer "
-H "X-GitHub-Api-Version: 2022-11-28"
https://api.github.com/orgs/ORG/actions/permissions/repositories/REPOSITORY_ID


Update loadConfig.js

This pull request should address https://github.com/okonet/lint-staged/issues/1319

Closing as this doesn't seem to be passing in tests. Feel free to re-open if you figure it out!


feat: download app - redirect to stores

:tada: This PR is included in version 1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Group Owners to add Guests - setting misbehaving or wrong description

Hi, this group setting

Let group owners add people outside your organization to groups

does not behave as described when set to "Off":

In my tests the Group/Team owner cannot add ANY guest, even if such already exist in directory.
Is it wrong in the Doc or can some other setting have an effect on this? For example I have set

AllowToAddGuests              False

in Group.Unified AAD global Setting and enabling it ONLY per Group in Group.Unified.Guest.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 030743fd-0c22-025b-f190-f637a2772506
Version Independent ID: fbded472-e3ea-4297-c527-810e117ea7ea
Content: Microsoft 365 guest sharing settings reference
Content Source: microsoft-365/solutions/microsoft-365-guest-settings.md
Product: microsoft-365-enterprise
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

@MarekHalfar Thank you for your feedback. I'll test this and update the document if need be.

@MarekHalfar Thank you for your feedback. I have made the changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/7217
Thank you again for the feedback.
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @MarekHalfar Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Correct background with orthographic cameras

three.js does not support rendering a background texture with environment-like mapping (e.g., equirectangular or cube mapping) with an orthographic camera. Attempting to do so converts the equivalent environment as a small box with unit-length half measures.
Therefore, we need two different sets of background textures based on whether we have a perspective or orthographic projection. This only impacts the texture used for the rendered background. The environment map (which affects the illumination of objects with PBR materials) will continue to be used when available, or using the gradient otherwise.
background.html has been updated to test/explore the behavior. It has been extended with some new controls, a feedback panel, and a cube with a simple PBR material. Various combinations of camera projection and environment configuration can be explored and the observed behavior reconciled with the documented expectations.
Finally, the background environment map has been pulled out of the gltf html file to reduce file bloat. It is now solely defined and used in background.html.

I've tested (love the new background.html test!), and run the npm build. :lgtm: thanks.


Integers are generated at wrong size

OpenAPI specifies an integer to be a signed 64-bit integer.
My OpenAPI schema is specifying integer, but the hypothesis strategy is generating numbers greater than 64 bits of size.
Expected Range of Inputs:
(-9,223,372,036,854,775,808, 9,223,372,036,854,775,808)
Actual Examples of Inputs:
-9,259,542,037,374,435,328, -667,220,327,296,061,663,559,436,087,945,272,576, etc.
I believe this may be because the hypothesis library defines integers at sizes up to 128 bits.
Is this a bug or am I missing something?

Hi @cbb330
I think that this issue is two-fold.
This is indeed true, that if format=int64 is specified in some schema, then the possible values are restricted by this format and should be signed 64-bit integers. And I forgot to implement this restriction - we implement format only for strings (binary, byte) + the others are provided by hypothesis-jsonschema. I will push it to our backlog and it shouldn't take much to implement.
However, The Open API 3.0 spec has this sentence:

Tools that do not recognize a specific format MAY default back to the type alone, as if the format is not specified.

Which from my pov makes the status quo technically valid, but probably not very convenient and not intuitive. Open API 2.0 is vaguer on this matter. Different tooling may have different approaches to this, e.g. connexion does not do any validation in this case, but I think we can provide it as we aim to produce data that fits the given schema.
And, if there is no format keyword, then the validation itself falls back to the JSON Schema Draft 4 / 00 (aka draft 5)  implementation that does not restrict precision:

number:
An arbitrary-precision, base-10 decimal number value, from the JSON "number" production

Which goes to the JSON spec:

This specification allows implementations to set limits on the range and precision of numbers accepted.

Thank you for bringing this issue and let me know if I can provide more info :)

Interesting, thank you for prompt response! Also, thanks for this wonderful project.
I agree that allowing format for other types would be ideal. Yes, OpenAPI leaves responsibility to the implementation to decide type, but it is much more convenient that the user defines that implementation, rather than hypothesis making non-configurable assumptions.
Currently I'm getting around this by removing parameters from Cases that break my integer requirements, before sending the request.
kwargs = case.as_requests_kwargs()
kwargs['headers'] = {'Authorization': 'Bearer ' + token}
kwargs['params'] = filter_params(kwargs['params'])
response = requests.request(**kwargs)

Is this how you recommend?

@cbb330
I was going through all issues and discovered that I completely forgot to respond :( I am very sorry for this

it is much more convenient that the user defines that implementation rather than schemathesis making non-configurable assumptions.

Indeed, it sounds like something that we can configure in Schemathesis. I think it could be implemented after the planned internals refactoring.

by removing parameters
Is this how you recommend?

Yes, something like this, or adding some boundaries there:
MAX = 2 ** 31 - 1
MIN = -2 ** 31
if "int32_value" in params:
    params["int32_value"] = max(min(-2 ** 64, MAX), MIN)

Sorry again for my delayed answer

I'd like to keep it open as a reminder :)

Implementation details:

The easiest way to achieve the desired effect is to update the schema conversion process in schemathesis.specs.openapi.converted.to_json_schema.
If the schema "type" is "number" or "integer" and there is the "format" keyword, then remove the "format" keyword and add proper value boundaries with "minimum" / "maximum" according to the "format" value

Has this been done? I think I can take a look at this since I also put the work around on my code.

Hi @baluyotraf
Sorry for my late reply! This has not been done, feel free to take a look - I'll be happy to provide assistance :)

To temporarily fix the issue, defining the minimum & maximum for the integer field in the schema


Fixes #92

In the always: block of main, force set_fact to null out the lists between runs.

Hello contributor, thanks for submitting a PR for this project!
I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.
In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

Type ci test please on this PR to trigger automated tests for it.
Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow #3 option )
If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

ci add to whitelist

Thank you for the PR!


Is it possible to show "show more" button on a day with two event?

I know it wouldn't show "+1 more" because both of them occupy two row on showing two event and one event with "+1 more" button.
I want to change the event design that user can add a picture to event. It is not enough space to show two or more event so need to display "show more" button to let user watch all the event in popup box.
Is there a way to fulfill this issues?

Thanks

It's not possible, show more  is based on available space, not number of events. It's a function of the layout styling, there are a few past issues about this that might be useful if you can fine them


After install all I get is twurl: command not found

Describe the bug
I followed the instructions in install.md ie gem install twurl
and I see:
Successfully installed twurl-0.9.6
Parsing documentation for twurl-0.9.6
Done installing documentation for twurl after 0 seconds
1 gem installed

Then twurl -v to verify it is working:
twurl: command not found

To Reproduce
I'm using Xubuntu 20.04, fairly new install so a fresh install of ruby was required. This is the output of my sudo gem env command:
RubyGems Environment:
  - RUBYGEMS VERSION: 3.1.4
  - RUBY VERSION: 2.7.2 (2020-10-01 patchlevel 137) [x86_64-linux]
  - INSTALLATION DIRECTORY: /root/.gem
  - USER INSTALLATION DIRECTORY: /root/.gem/ruby/2.7.0
  - RUBY EXECUTABLE: /snap/bin/ruby
  - GIT EXECUTABLE: /usr/bin/git
  - EXECUTABLE DIRECTORY: /root/.gem/bin
  - SPEC CACHE DIRECTORY: /root/.gem/specs
  - SYSTEM CONFIGURATION DIRECTORY: //etc
  - RUBYGEMS PLATFORMS:
    - ruby
    - x86_64-linux
  - GEM PATHS:
     - /root/.gem
     - /snap/ruby/189/lib/ruby/gems/2.7.0
  - GEM CONFIGURATION:
     - :update_sources => true
     - :verbose => true
     - :backtrace => false
     - :bulk_threshold => 1000
  - REMOTE SOURCES:
     - https://rubygems.org/
  - SHELL PATH:
     - /usr/local/sbin
     - /usr/local/bin
     - /usr/sbin
     - /usr/bin
     - /sbin
     - /bin
     - /snap/bin

Expected behavior
I expected my twurl -v command to print a twurl version
Desktop (please complete the following information):

OS: Xubuntu 20.04 (essentially same as Ubuntu 20.04, different UI is all)
Browser N/A
Version Ruby gems 3.1.4, and twurl 0.9.6

Additional context
I also tried installing from source:
$ git clone https://github.com/twitter/twurl
$ cd twurl
$ bundle install

and got the same result.

 I'd expect the install to have put a link to twurl into your Rubygems PATH, which I'd expect to be on your logged-in user's PATH. Try echo $PATH to check the current value.

echo $PATH
/usr/local/maven/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/opt/git-bug:/opt/terraform
(I can't see any reference to ruby on there)
To install ruby I used sudo snap install ruby --classic
Then (as per the install.md file and as I said in the op) I installed twurl using gem install twurl
what should I have done different?

Looking at this Ask Ubuntu thread, it looks like you need to have .gems/bin on your PATH. I haven't tested on Ubuntu for a while.

+1 same issue, tried MacOS and Ubuntu

I imported Ruby in MacOS using Brew, needed to do echo 'export PATH="/usr/local/lib/ruby/gems/3.0.0/bin:$PATH"' >> ~/.zshrc to get gems on my path.


SwiftPM6: Fix to skip locking package build directory

Starting with SwiftPM 6, a mechanism was introduced to lock the package build directory to prevent simultaneous builds/tests. Unfortunately, this behavior affects the swift package dump-package command used by this tool to retrieve dependency information. Specifically, when this tool is executed via a plugin in Swift 6, the workspace gets locked. This can lead to issues such as processes hanging and timing out when running on CI.
Steps to reproduce
$ swift --version
swift-driver version: 1.115 Apple Swift version 6.0 (swiftlang-<IP_ADDRESS>.10 clang-16<IP_ADDRESS>)
Target: arm64-apple-macosx14.0

$ swift package xcode-selective-test

Running process never terminates with Swift 6.
Changes in this PR
To preserve the previous behavior, a new --ignore-lock option has been introduced. This patch ensures that the option is automatically added when running on Swift 6 or later.
References

https://github.com/swiftlang/swift-package-manager/pull/7291
https://github.com/apple/swift-mmio/pull/84

@fxwx23 included in the release https://github.com/mikeger/XcodeSelectiveTesting/releases/tag/0.10.5


"Remove" advice should include a listing of used transitive dependencies it contributes

For example, I have a project which has
implementation 'com.google.android.gms:play-services-gcm'

and this is not used. However, it contributes several transitive dependencies which are used:
implementation("com.google.android.gms:play-services-ads-identifier:17.0.0")
implementation("com.google.android.gms:play-services-base:17.1.0")
implementation("com.google.android.gms:play-services-basement:17.0.0")
implementation("com.google.android.gms:play-services-measurement-api:17.2.1")
implementation("com.google.android.gms:play-services-tasks:17.0.0")
(etc)

and while all of this information is printed to the console (and also available by inspection of the intermediate results produced by the plugin's tasks), it is nevertheless not straightforward to connect all of this information together from either of (1) inspecting the console output or (2) inspecting the advices.json file.
Both the console and the advices.json file should more explicitly indicate the link.

Not going to do this.


[FEATURE] Migrate to Etsy API v3

Is your feature request related to a problem? Please describe.
Etsy V2 API will expire end of this year and all calls will fail.
Describe the solution you'd like
Adapt JEtsy to new Etsy V3 API

The migration to V3 is now underway.


Fix los brett

This replaces #316 (see also #312)
Fixes the line-of-sight calculation when using statevectors and miscellaneous bugs
Description

fixes some bugs in the I/O routines and unit test suite
adds unit tests
Fixes the LOS calculation and simplifies the code logic

Motivation and Context

Fixes #79
Fixes #122
Fixes #273
Replaces #316
How Has This Been Tested?

All tests pass locally
ran autopep8 on the whole repo

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] I have added an explanation of what your changes do and why you'd like us to include them.
[x] I have written new tests for your core changes, as applicable.
[x] I have successfully ran tests with your changes locally.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

@bbuzz31 and @dbekaert All unit tests passing! Can be reviewed and merged.


Fix zip internal path issue on Windows

This PR exists to fix path issues on windows when checking files inside JAR. #36

Looks good! left some inline comments

Updated some inline comments.

Looks good now, I noticed I could also edit the commit and tried it, sorry if I overwrote something in your branch. But the current state looks good. Thanks for the fix, merging!

This merge fixes #35


Conditionally choosing which component to render.

Firstly, id like to say thank you for your work, this library really simplified the amount if work I have to do to render markdown - and also for your prompt response on my previous issue.
I understand that you've provided the ability to render elements with createElement using the built-in compiler, which works extremely well!
I am wondering if there is a way to map conditionally chose which component is used to render each block within a markdown document?
<Markdown
        children={md}
        options={{
           React.Children.map(Child =>{
             if(Child.style.hasOwnPropery(fontWeight)){
                createElement(type, props, children) {
                   props.fontWeight = 600
                  return (

                      {React.createElement(Text, props, children)}

                 );
                }
               // or even better: // return <Text fontWeight={600}>Child</Text>
              } else {
                createElement(type, props, children) {
                  return (

                      {React.createElement(type, props, children)}

                 );
               }
            });
        }}
    />

I tried to do this myself without any luck, so I’m hoping this is something that is possible maybe with a different approach?
In either case thank you for your help once again! Really appreciate it!

Honestly from that code snippet I don't really understand what you're trying to do, but you have a lot of freedom in the "overrides" functionality (see README) to customize how you render things.


Fix compile errors with latest dependencies master

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Merge my current progress

[x] Add Scalar class that inherits from tensorflow.Variable
[x] Add config for storing settings such as the default dtype
[x] Add a very basic BaseDistribution
[x] Add the Normal distribution

LGTM!


Add Json Scalar

Add JsonType to Hotchocolate.Types
Closes #3661

Nice work! Yet another scalar we have at AutoGuru we can possible get rid of :P But ours is just a string, doesn't check validity or anything.
We also have a HTML one if that's something that makes sense to add as well. Bit of a trickier one though as we may need to think about encoding so that out-of-the-box it's safe to inject raw into the client web page.

closing for https://github.com/ChilliCream/hotchocolate/pull/3713


chore(ssa refactor): cp working tests

Description

Problem*

Resolves
Summary*

Documentation

[ ] This PR requires documentation updates when merged.

[ ] I will submit a noir-lang/docs PR.

[ ] I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

[ ] I have tested the changes locally.
[ ] I have formatted the changes with Prettier and/or cargo fmt on default settings.

This PR was premature (false positives from human error in testing).


Tensorflow lite doesn't support Gather Op with multiple dims?

Hello,
Following up this SO question which didn't get too much attention:
https://stackoverflow.com/questions/47321911/cant-convert-model-to-tensorflows-lite-format
I'm filling this form as a question/feature request.
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): YES
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): macOS, builing and trying to use TF Lite for iOS
TensorFlow installed from (source or binary): Source
TensorFlow version (use command below): Latest, made a pull from HEAD 3 days ago
Python version:  2.7.14
Bazel version (if compiling from source): 0.7.0
GCC/Compiler version (if compiling from source): clang 9.0.0
CUDA/cuDNN version: N/A
GPU model and memory: N/A
Exact command to reproduce:

bazel-bin/tensorflow/contrib/lite/toco/toco '--input_file=/Users/valentinradu/Playgrounds/char-rnn-tensorflow/remote_save/latest/graph_frz.pb' '--output_file=/Users/valentinradu/Playgrounds/char-rnn-tensorflow/remote_save/latest/graph.tflite' '--input_format=TENSORFLOW_GRAPHDEF' '--output_format=TFLITE' '--input_type=FLOAT' '--inference_type=FLOAT' '--input_shapes=1,128:1,50,50' '--input_arrays=state_in,data_in' '--output_arrays=state_out,data_out'
Describe the problem
I have a trained rnn that I try to use on mobile. Problem is, when I use toco to convert my .pb file to .tflite it fails with the following error message. Having a look over the source code that generated that exception, I think it's because of the toco's lack of support for multidimensional inputs. But I'm not sure. If so, will this be added later?
WARNING: Config values are not defined in any .rc file: opt.
INFO: Found 1 target...
Target //tensorflow/contrib/lite/toco:toco up-to-date:
  bazel-bin/tensorflow/contrib/lite/toco/toco
INFO: Elapsed time: 0.287s, Critical Path: 0.00s

INFO: Running command line: bazel-bin/tensorflow/contrib/lite/toco/toco '--input_file=/Users/valentinradu/Playgrounds/char-rnn-tensorflow/remote_save/latest/graph_frz.pb' '--output_file=/Users/valentinradu/Playgrounds/char-rnn-tensorflow/remote_save/latest/graph.tflite' '--input_format=TENSORFLOW_GRAPHDEF' '--output_format=TFLITE' '--input_type=FLOAT' '--inference_type=FLOAT' '--input_shapes=1,128:1,50,50' '--input_arrays=state_in,data_in' '--output_arrays=state_out,data_out'
2017-11-16 06:48:00.156091: I tensorflow/contrib/lite/toco/import_tensorflow.cc:937] Converting unsupported operation: Fill
2017-11-16 06:48:00.156811: I tensorflow/contrib/lite/toco/import_tensorflow.cc:937] Converting unsupported operation: Fill
2017-11-16 06:48:00.156821: I tensorflow/contrib/lite/toco/import_tensorflow.cc:937] Converting unsupported operation: Pack
2017-11-16 06:48:00.156829: I tensorflow/contrib/lite/toco/import_tensorflow.cc:937] Converting unsupported operation: Pack
2017-11-16 06:48:00.156841: I tensorflow/contrib/lite/toco/import_tensorflow.cc:937] Converting unsupported operation: Unpack
2017-11-16 06:48:00.156856: I tensorflow/contrib/lite/toco/import_tensorflow.cc:937] Converting unsupported operation: StridedSlice
2017-11-16 06:48:00.156872: I tensorflow/contrib/lite/toco/import_tensorflow.cc:937] Converting unsupported operation: StridedSlice
2017-11-16 06:48:00.157260: I tensorflow/contrib/lite/toco/import_tensorflow.cc:937] Converting unsupported operation: Pack
2017-11-16 06:48:00.157277: I tensorflow/contrib/lite/toco/import_tensorflow.cc:937] Converting unsupported operation: Pack
2017-11-16 06:48:00.158053: I tensorflow/contrib/lite/toco/graph_transformations/graph_transformations.cc:39] Before general graph transformations: 40 operators, 64 arrays (0 quantized)
2017-11-16 06:48:00.158141: F tensorflow/contrib/lite/toco/graph_transformations/propagate_fixed_sizes.cc:793] Check failed: indices_shape.dimensions_count() == 1 (2 vs. 1)

Source code / logs
The repository I user to train the model can be found in full here:
https://github.com/valentinradu/char-rnn-tensorflow/blob/master/char_rnn/model.py

Answered on StackOverflow: https://stackoverflow.com/questions/47321911/cant-convert-model-to-tensorflows-lite-format

@gargn You mean my own answer on SO can be confirmed? No support to date?

I also met this problem
2018-03-04 13:24:20.587520: I tensorflow/contrib/lite/toco/graph_transformations/propagate_fixed_sizes.cc:961] input array name is MobilenetV1/Embeding/embedding 2018-03-04 13:24:20.587527: I tensorflow/contrib/lite/toco/graph_transformations/propagate_fixed_sizes.cc:962] indices array name is input 2018-03-04 13:24:20.587569: F tensorflow/contrib/lite/toco/graph_transformations/propagate_fixed_sizes.cc:983] Check failed: indices_shape.dimensions_count() == 1 (2 vs. 1) Abort trap: 6


Ability for a donor to pledge funds and for that pledge to be recorded like aid packages as institutional donors cannot pay by credit card.

[ ] Ability for a donor to pledge funds instead of pledging towards an aid package, and for that pledge to be recorded like aid packages as institutional donors cannot pay by credit card in the give.asia site.

E.g. create an aid package with no medicines. Instead, a pledge of funds towards a larger pool. Say we create an aid package of 100,000 USD.

According to the current implementation, it's impossible to create an aid package without medicine. Amending the flow would break the structure and validations. I think it's better to come up with a different approach.
@manuranga @NipunaMarcus please let us know your thoughts on this.

Yes, I agree with @jayasanka-sack ... Current flow or the discussed flow was to create aid packages with need packages... If we are to create an aid package without needs, we can introduce another type of package... Something like "DonationPackage" .... Also this will involve a few DB changes and package creation API changes.

Lets add 'kind' to medical item that says its a donation and set a fake amount like 1000000. Elegant way to do it would be use a different table l, but that will require significant changes.


fix win32 locale processing

fix win32 locale processing

What is this supposed to fix ? Any exemple ?
We need more details.

Old code does not support multiline translation.
It has been modified to support it.

Can you provide a sample ? so we can reproduce & test

This only happens on Windows.
If the execution path of the emulationstation contains a folder written in Korean(한글), Japanese(일본), Chinese(중국), etc. rather than ASCII characters, emulationstation will not run properly.
In my case...
"d:\애뮬\emulationstation" is cannot load xml or image...
The reason for this is that emulationstation uses UTF8 internally, but Windows uses multibyte characters.
Therefore, all file input and output must be process through Unicode functions.
Currently, I have worked on images and xml, but there may be some things I don't know, so additional related work may be needed.

EmulationStation Windows build uses gettext by directly implementing it.
So it does not support all specifications.
I don't know much about the rest, but I think not supporting multi-line translation is a big problem.
This is a small patch to solve it.
msgid ""
"THIS WILL DELETE THE ACTUAL GAME FILE(S)!\n"
"ARE YOU SURE?"
msgstr ""
"실제 게임 파일이 삭제됩니다!\n"
"확실합니까?"
That is "locale/lang/ko/LC_MESSAGES/emulationstation2.po" game delete message...
Old code...

My code..


--enable-software-rendering on Android yields black screen

# With an Android emulator running
$ cd examples hello_world
$ flutter run --enable-software-rendering

That yields an all-black screen.  Same happens with any Flutter app.
/cc @chinmaygarde @brianosman

I don’t think this is Skia related. I’ll take a look.

Traced this to https://github.com/google/skia/commit/d4746984e51e18ba3d2e52e96305d72d0fd84c31
The SkImageInfoIsValidCommon does not accept Flutter's use of kPremul_SkAlphaType with kRGB_565_SkColorType

Ooh. Is there a good reason to use 565 in SW mode? I'd assume you want kN32

This is a default format chosen by Android for SurfaceView/SurfaceHolder.  It's probably helpful for performance, especially since software rendering is most likely to be used within an emulator.

Yeah, I just picked the 16bpp format thinking it was good enough for emulators and seemed to be supported by Skia. I must admit I did not compare performance with kN32. We could just switch.

We definitely should not be specifying kPremul_SkAlphaType though.


Bam2rad

Bug fix

Pull Request Test Coverage Report for Build 242162167

0 of 44 (0.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 4.418%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

libradicl/src/convert.rs
0
44
0.0%

Files with Coverage Reduction
New Missed Lines
%

libradicl/src/convert.rs
1
0%

Totals

Change from base Build 240812957:
-0.05%

Covered Lines:
93

Relevant Lines:
2105

💛  - Coveralls


yarn not fetching iOS and android folders

Installing library through yarn add react-native-text-input-mask. checking the node modules there is no ios or android folders in it. needless to say, the lib fails to run.  Though no error while running yarn command.

Same issue mentioned in #186


Series Details

After the series details is sync for the first time, on sync adapter the genres, prod companies and status stays empty. It doesn't sync again

Resolved


run_cloud should output a URL rather than plain invite code

More helpful for users manually installing on cloud.

:+1:


Love_Lock

My Fourth New Game is now Released!
LOVE LOCK
✔ It's a game about a lover who is handicapped but his loved one is locked away.
✔ Objective: Unlock your way to save your bae
✔ You need the key to unlock the teleport to your Lover

Controls

Use w, a, s, d to move around.
Press j to reset the level.
Press k for Music.
Press i for Credits.
Press l for Controls.

The game is a modified version of tolls by leo

This is is a pretty good game, good art, good music. My only complaint would be that the reset button is pretty buggy. But again, overall it is a good game.

This is is a pretty good game, good art, good music. My only complaint would be that the reset button is pretty buggy. But again, overall it is a good game.

Thanks a lot for your feedback 💌
Wow! yes! I didn't notice that reset button issue..Fixed that now..Thank you again Omay! 🤗

A major improvement over the original! Thanks for turning it into a real game.

A major improvement over the original! Thanks for turning it into a real game.

Thank youu ✨ 👍🏻 👍🏻


chore: Scope role down to needed permissions

Fixes #N/A
Description
Scope role permissions down to needed permissions. This includes dropping the CRD update permission that is no longer needed now that webhooks have been dropped.
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
9 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.09%) to 80.825%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/provisioning/scheduling/nodeclaim.go
2
89.13%

pkg/controllers/provisioning/scheduling/preferences.go
7
86.67%

Totals

Change from base Build<PHONE_NUMBER>4:
-0.09%

Covered Lines:
8481

Relevant Lines:
10493

💛  - Coveralls

/lgtm


totoally free  Text to  Speech

you can access this project to your project ,it is free ,no need to pay
https://github.com/rany2/edge-tts

Thanks for the link!
It looks like Edge TTS needs to run server-side (in my tests, calling the API from the browser doesn't seem to work, the connection is dropped by the server). Sending all user requests from the same server would likely hit rate limiting / IP restriction issues.
However, it might be useful for people self-hosting the app just for themselves or a small number of people, so I'll look at adding it as an option.

Thanks for the link!
It looks like Edge TTS needs to run server-side (in my tests, calling the API from the browser doesn't seem to work, the connection is dropped by the server). Sending all user requests from the same server would likely hit rate limiting / IP restriction issues.
However, it might be useful for people self-hosting the app just for themselves or a small number of people, so I'll look at adding it as an option.

I alreay test, it can work well in linux Command，I dont know website

dont need to run server-side,
Use Microsoft Edge's online text-to-speech service from Python


Class with "." in dev visible and production removed

This is example of how to reproduce in tailwind.config.js :
  fontSize: {
    '2.7xl': '1.75rem',
    '3.2xl': '2rem',
    '5.5xl': '3.5rem',
  },

Show when running "dev", in SSR mode (production) removed.
This need to fix by:

error in dev mode to show that don't work
fix in production mode by proper escape

try this
extractor
defaultExtractor: content => content.match(/[\w-/.:]+(?<!:)/g) || []


Support Cromwell config file in Dockstore config

Supports specifying a Cromwell config file in the Cromwell execution command line by using a keyword in the Dockstore config file. I.e. adding this line to the Dockstore config file:
cromwell-config-file: /Users/waltershands/cromwell.conf
will allow Dockstore CLI to generate an execution command line that specifies the Cromwell configuration file:
java -Dconfig.file=/Users/waltershands/cromwell.conf -jar /Users/waltershands/.dockstore/libraries/cromwell-47.jar run --inputs /var/folders/vj/xky2f9pn64q6__y6w2kpjx4m0000gn/T/foo15679799386456966359json /Users/waltershands/Documents/UCSC/dockstore_work/helloworld.wdl
Addresses https://ucsc-cgl.atlassian.net/browse/DOCK-960

Is there a followup issue for adding this to documentation?

Documentation issue https://ucsc-cgl.atlassian.net/browse/SEAB-594

Walt and I discussed this; putting it here for general consideration -- instead of having a specific entry for cromwell-config-file, I think this could be more generic like the cwltool-extra-parameters; that way we don't have to keep adding new entries in the config file to support additional entries.
The difference though is that the config file is a Java VM setting, whereas other settings are application parameters. I think you could have something like cromwell-vm-options and cromwell-extra-parameters to handle both cases.

I think this is a judgement call. cwltool is loaded with extra parameters for a wide variety of useful options.  Not knowing how many vm options or extra parameters Cromwell has and whether they look useful ...

Implemented Charles suggestion for the keywords cromwell-vm-options and cromwell-extra-parameters in the Dockstore config file. There are about 9 extra parameters which could be used. On the one hand they are mostly useful for a specific workflow run so typically a user would not add them to the Dockstore config file, and the --input and --type flags would conflict with the ones Dockstore adds to the command line by default so the user could break the command line, but this does 'future proof' Cromwell command option use...

I still feel there should be a unit test as I suggested in an earlier comment, but all others have approved and it is a fairly small chunk of code, so approving.

Peer pressure!


Compat: Immersive Engineering

At present, machines don't currently seem to accept energy from Immersive Engineering, either directly through an adjacent capacitor set to output in that direction, or via the connectors and wire power transfer system.

seems that Immersive Engineering connectors don't pick up on World::notifyNeighborsOfStateChange calls...
if you configure the machine BEFORE putting the connector on it it should work fine.
not much I can do there... I could be wrong, but I would make an issue about this on Immersive Engineering project...


Facing an Issue

Hi, i like this theme, thank you for it.
I recently added notes to it but i am facing an issue.
I made a new archetype, a list and single, a new directory under content, notesSection.yml, notesSection.html.
Upon deploying my website, it displays my notes on the blog area while leaving the notes area blank, how can i make sure notes appear on the notesSection and not on the blogSection.
The page note renders the notes fine, my issue is in the homepage.
Kindly help me
and if you can also help me fix the notes image issue, making images in notes optional and displaying the full note instead of just the title. Tried adding {{ .content }} but it didn't work

and if you can also help me fix the notes image issue, making images in notes optional and displaying the full note instead of just the title. Tried adding {{ .content }} but it didn't work

and if you can also help me fix the notes image issue, making images in notes optional and displaying the full note instead of just the title. Tried adding {{ .content }} but it didn't work

Your problem is not clear. I think if you want to create a new page or a new section, your data will be on "data/notesSection.yml" On blogSection.html line 23 we used {{ range first 3 (where $.Site.RegularPages "Type" "!=" "portfolio") }} for telling show all file instead of portfolio  you can change it with show only "==" blog, notes or whatever you want to show...  And I can't say understand the problem with out the code for image not showing issue... It could be for absURL pipe or {{ .Content }} instead of {{.content}}

Your problem is not clear. I think if you want to create a new page or a new section, your data will be on "data/notesSection.yml" On blogSection.html line 23 we used {{ range first 3 (where $.Site.RegularPages "Type" "!=" "portfolio") }} for telling show all file instead of portfolio  you can change it with show only "==" blog, notes or whatever you want to show...  And I can't say understand the problem with out the code for image not showing issue... It could be for absURL pipe or {{ .Content }} instead of {{.content}}

Your problem is not clear. I think if you want to create a new page or a new section, your data will be on "data/notesSection.yml"
On blogSection.html line 23 we used {{ range first 3 (where $.Site.RegularPages "Type" "!=" "portfolio") }} for telling show all file instead of portfolio  you can change it with show only "==" blog, notes or whatever you want to show...
And I can't understand the problem without the code for image issue... It could be for absURL pipe or use {{ .Content }} instead of {{ .content }}

Thank you let me try this, if it fails, I'll send a screenshot of my code and the page.

Your problem is not clear. I think if you want to create a new page or a new section, your data will be on "data/notesSection.yml"
On blogSection.html line 23 we used {{ range first 3 (where $.Site.RegularPages "Type" "!=" "portfolio") }} for telling show all file instead of portfolio  you can change it with show only "==" blog, notes or whatever you want to show...
And I can't understand the problem without the code for image issue... It could be for absURL pipe or use {{ .Content }} instead of {{ .content }}

Thank you let me try this, if it fails, I'll send a screenshot of my code and the page.

I'll reopen this issue, if your advice fails, thank you very much. If it fails I'll send you the code and screenshot + how i would like it to render

I'll reopen this issue, if your advice fails, thank you very much. If it fails I'll send you the code and screenshot + how i would like it to render

Thank you, your solution worked!
Thank you very much.
I now have a blog page for long form posts and a note page for short form posts.

Thank you, your solution worked!
Thank you very much.
I now have a blog page for long form posts and a note page for short form posts.


Reformat index pages to match XD styling

The repository has been rebased. It needs one final change (adding "create new" buttons), but the rest can be looked over.

There are merge conflicts that need to be resolved.

Code has been finalized for new index pages, following the XD styling. Available here: https://xd.adobe.com/view/cfad329c-4994-4382-7cd3-93847f0055c4-b99c/


Upper limits

Hi,
I know this is a question that should be better defined, at least referring to a specific statistical test. However, I wonder if you have thought to a way to include upper limits in the analysed time series.
Thanks,
Stefano

Can you explain a little more your idea? i don't understand how/where/why you want an upper limit.

I was cryptic. Sorry for that.
What I mean is simply that it happens, in a time-series, to have upper
limits (or even lower limits, in principle, if we are not speaking of
typical astronomical time series). Depending on the specific task, upper
limits can be meaningful for assessing a variability. However, I do not
know how to indicate them in the context of your package, if there is a
way. In any case it could be interesting to code a standard way to report
these measurements.
Stefano

you mean to limit the "magnitude" of the time series?

Let's assume, for instance, we have ten magnitude measurements. And nine of
them are just upper limits, i.e. nothing is detected. One of them gives a
measurement brighter than the limits. This immediately says there is
important variability, and of course, with ten measurements everything is
trivial. The idea would be to have tools to assess variability able to
compare actual measurements with limits.
Stefano
Il giorno giovedì 14 marzo 2019, Juan BC<EMAIL_ADDRESS>ha
scritto:

you mean to limit the "magnitude" of the time series?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/carpyncho/feets/issues/10#issuecomment-472833954, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA1cHAgx-tUK3apdS7Wpn2syzzA3ugBkks5vWkH8gaJpZM4btmdb
.


Generation example not working

I downloaded the package and ran from the generation folder the suggested process :
python get_vocab.py --min_frequency 100 --ncpu 8 < ../data/polymers/all.txt > ../data/polymers/vocab.txt
python preprocess.py --train ../data/polymers/train.txt --vocab data/polymers/vocab.txt --ncpu 8
I get the following error:
"""
Traceback (most recent call last):
File "/home/cristian/anaconda3/envs/hgraph/lib/python3.6/multiprocessing/pool.py", line 119, in worker
result = (True, func(*args, **kwds))
File "/home/cristian/anaconda3/envs/hgraph/lib/python3.6/multiprocessing/pool.py", line 44, in mapstar
return list(map(*args))
File "preprocess.py", line 19, in tensorize
x = MolGraph.tensorize(mol_batch, vocab, common_atom_vocab)
File "/home/cristian/Work/hgraph2graph/generation/poly_hgraph/mol_graph.py", line 168, in tensorize
tree_tensors, tree_batchG = MolGraph.tensorize_graph([x.mol_tree for x in mol_batch], vocab)
File "/home/cristian/Work/hgraph2graph/generation/poly_hgraph/mol_graph.py", line 209, in tensorize_graph
fnode[v] = vocab[attr]
File "/home/cristian/Work/hgraph2graph/generation/poly_hgraph/vocab.py", line 43, in getitem
return self.hmap[x[0]], self.vmap[x]
KeyError: ('C1=CSC=N1', 'N1=[CH:2]S[CH:2]=[CH:1]1')
"""
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "preprocess.py", line 49, in
all_data = pool.map(func, batches)
File "/home/cristian/anaconda3/envs/hgraph/lib/python3.6/multiprocessing/pool.py", line 266, in map
return self._map_async(func, iterable, mapstar, chunksize).get()
File "/home/cristian/anaconda3/envs/hgraph/lib/python3.6/multiprocessing/pool.py", line 644, in get
raise self._value
KeyError: ('C1=CSC=N1', 'N1=[CH:2]S[CH:2]=[CH:1]1')

I traced the issue to be the fact that you load the motifs from the vocab in preprocess.py, instead of loading the original motifs that pass the min_frequency mark in get_vocab.py
MolGraph.load_fragments([x[0] for x in vocab])
I got rid of the behaviour by saving the original fragments in a separate file after get_vocab.py and then loading them in preprocess.py. What I think is happening is that molecules are not split in the same way because of the difference of starting fragments.

Hi,
I fixed this issue and now it should be able to run. Thank you!

Hi,
I tried running the same command and there was no error. I think what you can do is to run get_vocab.py and see if the output is different from data/polymers/inter_vocab.txt. If they are different (I would be surprised), please try rerun preprocess.py and see if it succeeds.

Hi, I had the same trouble. I found the problem to be that the string being called to map from vocab is different from the ones available. In my case there was difference in the SMILES represntation of the double bond C(O) and C(=O)


POC DO NOT MERGE - Adds on-the-fly enabling of function argument casting

POC for #5. Unittests should make clear how it can be used.
I don't necessarily like the implementation (not very transparent to the end user what's happening and it's not very Pythonic) but I realize it serves a purpose for some use-cases. From that perspective I like this approach way more than if isinstance(..) then logic in every algorithm.

The namedtuple in sweat.algorithms.metrics.core doesn't like to play with my approach. I think it's fixable so ignore it for the sake of the discussion. ;)

Mind twisting, but cool implementation. We can try to keep it and see if it sticks. The main added value, of course, is a support of list-2-list functionality, which is only relevant, if you write quick API gateways.
What I'm still puzzled about is how NumPy behaves:
In [1]: import numpy as np

In [2]: import pandas as pd

In [3]: type(np.log(np.arange(1,5)))
Out[3]: numpy.ndarray

In [4]: type(np.log(pd.Series(np.arange(1,5))))
Out[4]: pandas.core.series.Series

It returns the same type as an input!
Pandas, on the other hand, does not do it. In fact, to make use of most of the functions that pandas provide you first need to convert your array-like into Stream/DataFrame and I don't know what is the best strategy to tackle this. My original approach was to add typecasting at the end of each function.

I tried to figure out how NumPy does this but it looks like they do that in some c library... I don't want to go that way (if only because I'm not comfortable with c...).
If I can make sure it cannot cause any race conditions during testing I think I'm fine with merging the approach in this PR.
About the pandas.Series methods that we're currently using (like pandas.Series.rolling): I think most of these methods on the Series class use NumPy methods in the background so I think it should be fairly straightforward to move away from depending on these and use only NumPy methods for this. The result of that will be that by design we will accept only numpy.ndarrays as input( but allow type casting via the code in this PR). Oh and that will actually fix type casting for e.g. multiple_best_intervals because now it will cast to ndarray which will break that method.

There are some methods in pandas that are not available in NumPy. One notable example is the emwa rolling mean that was deprecated in NumPy. I remember I've read once on the stack that it was a decision of NumPy to focus on a low level handling of manipulation arrays in memory while leaving all statistical computations for other libraries.
Another example, that would be a shame not to implement in pandas is anything that has to do with grouping values. Here is how time in zones is calculated in core.py:
z = pd.Series(compute_zones(power, **kwargs))
tiz = z.groupby(z).count()

That's interesting. It makes sense for Numpy to stay more low-level indeed.
So basically for some algorithms we have to also rely on these methods on pandas.Series/DataFrame. For these algorithms we cannot avoid converting the input argument(s) to pd.Series, since only accepting pd.Series as input arguments for these algorithms would make the interface really confusing.
Is this then the solution?

All algorithms are designed to work with numpy.ndarray
...although probably most of them will accept pd.Series or list as input arguments (a side effect of how numpy ufuncs work) but output will still be numpy.ndarray
There is a utility method enable_type_casting() available that enables on-the-fly-type-casting of input and output arguments to/from pd.Series and list.
Algorithms that require pd.Series specific methods need to convert numpy.ndarray to pd.Series themselves. Output should still be numpy.ndarray.

@sladkovm I finally found time to finish this PR with the input of our discussions. Can you take a look to see if I missed anything?


Implement list count

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

14 of 14 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.6%) to 14.336%

Totals

Change from base Build<PHONE_NUMBER>:
0.6%

Covered Lines:
286

Relevant Lines:
1995

💛  - Coveralls


Revert "Revert "Revert "Include fragment support in Android build to allow use of FragmentActivity in FlutterActivity (#9036)"" (#9046)"

Test is still failing with increased timeout.
This reverts commit 864b3c37c65a4294735bbdb041d17b112a2659cc.

TBR @yjbanov


limit the selectable areas in the aoi_selector

Jeff: The geographical scope of the tool should be limited to land that meets these four criteria ("restorable land"):
Located in LMICs
Trees can exist on it (per Bastin et al. 2019)
Trees do not currently exist on it (suggestion: use 2019 Copernicus 100m land-cover data)
Not urban (suggestion: use 2019 Copernicus 100m land-cover data).
Bins, etc. should be defined using only this land. For (iii), we will need to decide which Copernicus land-cover classes to consider to be "tree cover." I think we're doing all this, but let's confirm.
John: I've drafted this layer using all the forest type layers in GEE
script: https://code.earthengine.google.com/39f660dc8bd71b5d30a01c0ef6c63ab1

I've made two layers related to this:
a. Trees can exist on it, where Trees do not currently exist on it, and is not urban.(layer name: Current forest or ubran landscape)
b. Trees do not currently exist on it, and they're less than the current tree cover fraction.(layer name: Current tree cover less than potential)
Right now they're added to the constraints list/ questionnaire, but it sounds like they should be nonoptional constraints in an either/both situation. @12rambau what do you think would be the best way to add this?
For 2.Located in LMIC, are we going to impose this at the AOI selection?

I think we should hardcode them into the gee side. They should not be constraints that people could select or deselct at will


Update dependencies

Closes #1365
Closes #1506
Closes #1499
Brings progress to #1490

Node.js 6 on AppVeyor is exceeding the time limit of 1h and I'm not sure why. Has someone any idea?

AppVeyor is for Windows, right? You could try adding echo %time% before and after every task in the install: section. Then we know what of it takes so long, as AppVeyor doesn't seem to display the timestamps?

It seems to always freeze at the test step. At or after (not sure) the commit √ can get the commit diff test.
Can someone have a look who is more familiar with nodegit?

This looks promising, I'll focus attention on this branch. How did you get the test error: Error: Callback is required and must be a Function. fixed?

How did you get the test error: Error: Callback is required and must be a Function. fixed?

Either I have forgotten about that and I never ran into this. So no idea.
AppVeyor fails with an error seemingly related to OpenSSL. Any idea about that @tbranyen?

I'll just pull down your branch and see if the tests work okay locally. The AppVeyor issue is gonna be tricky. I'll boot up Windows later today and take a look :|

I didn't get a chance to look yesterday, but awesome that Travis is looking good! Can you just revert your appveyor.yml changes and see if that produces anything different? Was there a specific reason why you had made changes to that file?

Okay so that didn't seem to help. I wasn't able to boot up my Windows machine yesterday, but I'm gonna try and use a VM tonight.

Hey, we're (@stevek-axo and I) are working on ripping openssl out of non-electron builds atm. It's to do with node 10 support and some awesome linking errors we're starting to see in with the 3 copies of openssl we're currently shipping and fedora 28. Atm we're going to continue working on that angle on my branch. We needed to pull in the libssh2 update.

Okay, after who knows how many rebases, commits and resets this should be merge ready.
@implausible @tbranyen

Oh no. That seems like the same bug as CI had before at some points. Node 6 on Windows freezes in some test and never resumes.
Seems like some dependency update isn't compatible with Node 6 or brings another behaviour as on the newer Node versions.

I have ripped out the promisify-node updates, now CI should give green light

Removed commits which lets the Travis and AppVeyor run on all branches, even though I would strongly recommend it for the future.

Thanks @Croydon!