4/26/2022 Publish

Docs Build status updates of commit fad83d4:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-autogen/toc.yml
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-azureadexternalidentities-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-cdn-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-datadog-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-datafactory-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-deviceprovisioningservices-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-devtestlabs-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-dns-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-domainservices-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-eventhub-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-features-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-links-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-managedapplications-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-policy-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-redisenterprisecache-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-reservations-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-resources-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-resources-subscriptions-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-templatespecs-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/preview/arm-botservice-readme.md
:warning:Warning
View (azure-node-preview)
Details

docs-ref-services/preview/arm-datalake-analytics-readme.md
:warning:Warning
View (azure-node-preview)
Details

docs-ref-services/preview/arm-datamigration-readme.md
:warning:Warning
View (azure-node-preview)
Details

docs-ref-services/preview/arm-deploymentmanager-readme.md
:warning:Warning
View (azure-node-preview)
Details

docs-ref-services/preview/arm-desktopvirtualization-readme.md
:warning:Warning
View (azure-node-preview)
Details

docs-ref-services/preview/arm-dnsresolver-readme.md
:warning:Warning
View (azure-node-preview)
Details

This comment lists only the first 25 files in the pull request.

docs-ref-autogen/toc.yml

Line 65535, Column 12: [Warning: xref-not-found] Cross reference not found: 'microsoft-cognitiveservices-speech-sdk.request'.
Line 65535, Column 12: [Warning: xref-not-found] Cross reference not found<EMAIL_ADDRESS>

docs-ref-services/latest/arm-azureadexternalidentities-readme.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 9, Column 16: [Warning: ms-prod-technology-invalid - See documentation] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 11, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'azureadexternalidentities'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 22, Column 1: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@azure/arm-azureadexternalidentities' will be broken in isolated environments. Replace with a relative link.
Line 62, Column 76: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/active-directory/develop/howto-create-service-principal-portal' will be broken in isolated environments. Replace with a relative link.

docs-ref-services/latest/arm-cdn-readme.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 9, Column 16: [Warning: ms-prod-technology-invalid - See documentation] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 22, Column 1: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@azure/arm-cdn' will be broken in isolated environments. Replace with a relative link.
Line 62, Column 76: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/active-directory/develop/howto-create-service-principal-portal' will be broken in isolated environments. Replace with a relative link.

docs-ref-services/latest/arm-datadog-readme.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 9, Column 16: [Warning: ms-prod-technology-invalid - See documentation] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 11, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'datadog'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 22, Column 1: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@azure/arm-datadog' will be broken in isolated environments. Replace with a relative link.
Line 62, Column 76: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/active-directory/develop/howto-create-service-principal-portal' will be broken in isolated environments. Replace with a relative link.

docs-ref-services/latest/arm-datafactory-readme.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 9, Column 16: [Warning: ms-prod-technology-invalid - See documentation] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 11, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'datafactory'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 22, Column 1: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@azure/arm-datafactory' will be broken in isolated environments. Replace with a relative link.
Line 62, Column 76: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/active-directory/develop/howto-create-service-principal-portal' will be broken in isolated environments. Replace with a relative link.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Support: Provider/Provider User page layout improvements

Context
Tidy up of navigation and layout for provider and provider user views, including removing repetition of page titles three times 😮
(Was there any reason why we show provider user permissions within a scrollable div? Doing this creates two scroll separate vertical scrollbars on the page, making this more difficult to use.)
Changes proposed in this pull request

Before
After

Guidance to review
Updated ProviderUsersController to provide same page variables for edit and audits; are my changes correct?
Link to Trello card

Things to check

[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] API release notes have been updated if necessary
[ ] New environment variables have been added to the Azure config

The scrollable div is just because the list can be very long, I think. It's only providers with synced courses but that list is about to get quite a lot longer.
One thing I always miss on this page is, because the list is long, it's hard to find the providers the person is actually associated with. Would it be good to bubble those to the top of the list? Probably shortening the list would be better, though.

@adamsilver reminded me why we have the scrollable div – it’s so the button doesn’t get lost at the end of a long, long page. So, reinstated the scrollable area, but made it more explicit with visible scrollbar and border, and made it so that it takes up 75% of the viewport height.

Approved regardless, but could you use a breadcrumb instead of back link here?

Yeah, was thinking the same. We don’t have a breadcrumb component yet, but I may have a go at creating one 😀


made newPage functions to work without arguments too

I made the newPage function to work without arguments too.
    Initial newPage() without arguments: 1000 x 1000
    Second newPage() without arguments: same as previous page

I found an issue that the function throws an error if you don't draw before. Probably because RecordingDocument's         self.pageWidth = self.pageHeight = None Drawing makes it somehow become not None. It got a temporary fix

btw, all test that test Image failed even with fresh copy

The test failure is because of a reather agggressive linter setting. Please check with
$ flake8 --max-line-length=127 path/to/file.py
...for both files you're edting. If that passes, run pytest locally. Doing
$ pytest
should be enough. If that passes, there's a good chance the CI will pass, too.

Thanks Jan!

I learnt something again :) I thank you!
I am making a small python workshop soon and it's great to welcome a few Windows users too. VS code setup with split editor where one half shows the exported image works pretty well as a substitution for DrawBot app.
Though sharing install instructions with 13 steps is not that good for beginners, but they managed!


[Access Change Request] codeunit 408 DimensionManagement - CheckBlockedDimAndValues

Hi,
could you please change the access of the procedure CheckBlockedDimAndValues from local to global?
Thanks.

Was fixed in version 22.


Deeplink is not working

Type of issue
Feature doesn't work (bug)
Feedback
Suddenly, when I create a group chat with the API, the Teams chat shows a list. However, when I access the chat with a deep link, an error occurs as if the chat room does not exist. If I turn off Teams and turn it back on, it works fine. In web Teams, when I refresh it works fine.
Page URL
https://learn.microsoft.com/en-us/microsoftteams/platform/concepts/build-and-test/deep-link-teams#deep-link-to-navigate-to-a-chat
Content source URL
https://github.com/MicrosoftDocs/msteams-docs/blob/main/msteams-platform/concepts/build-and-test/deep-link-teams.md
Author
@v-npaladugu
Document Id
b6687ceb-6d67-b0b7-0797-b16d14e4bd97

Hi @pnumber - Could you please confirm whether our understanding of the issue correct or wrong?

You created a chat using Graph API.
Then you formed a deep link to navigate to the chat
On clicking of that deep link, you are not able to navigate anywhere, it throws some error message.

Now please let us know if this is happening in New Teams client or Classic Teams? And what exact error message you are getting?

We tested using below deep link and observed that it works perfectly fine in both MS Teams Desktop and Web client.
<EMAIL_ADDRESS>Microsoft Teams version 24114.1000.2834.1395.
The client version is 49/24031414720.


Move auto-open option of Assemblyview to launch.json

This makes it consistent with the other views.

Fixed and Improved via 83ca89d3dec55167c422023985e90cf5bdde9193


x/website: MySQL config is incorrect in the database access tutorial.

MySQL config code should use AllowNativePasswords: true.
The tutorial https://golang.org/doc/tutorial/database-access describes MySQL config code as the following:
cfg := mysql.Config{
	User:   os.Getenv("DBUSER"),
	Passwd: os.Getenv("DBPASS"),
	Net:    "tcp",
	Addr:   "<IP_ADDRESS>:3306",
	DBName: "recordings",
}

But, it causes an error like the following:
[mysql] 2021/10/24 17:03:01 connector.go:95: could not use requested auth plugin 'mysql_native_password': this user requires mysql native password authentication.
2021/10/24 17:03:01 this user requires mysql native password authentication.

To run the code correctly, we should add AllowNativePasswords: true to the MySQL config or use msql.NewConfig method instead of creating mysql.Config struct directly. Please see the following full config code.
The correct code is:
cfg := mysql.Config{
	User:   os.Getenv("DBUSER"),
	Passwd: os.Getenv("DBPASS"),
	Net:    "tcp",
	Addr:   "<IP_ADDRESS>:3306",
	DBName: "recordings",
	AllowNativePasswords: true,
}

or
cfg := mysql.NewConfig()
cfg.User = os.Getenv("DBUSER")
cfg.Passwd = os.Getenv("DBPASS")
cfg.Net = "tcp"
cfg.Addr = "<IP_ADDRESS>:3306"
cfg.DBName = "recordings"

See also:

https://github.com/go-sql-driver/mysql/pull/644
https://github.com/golang/website/blob/281050ffddd88206d068f5f9e9cfa31cf01c9446/_content/doc/tutorial/database-access.md?plain=1#L243-L249
https://github.com/golang/website/blob/281050ffddd88206d068f5f9e9cfa31cf01c9446/_content/doc/tutorial/database-access.md?plain=1#L692-L698

This is still an issue unless I'm looking at an outdated version of this page: https://go.dev/doc/tutorial/database-access... I don't see the change to reference mysql.NewConfig, instead I still see
 cfg := mysql.Config{
        User:   os.Getenv("DBUSER"),
        Passwd: os.Getenv("DBPASS"),
        Net:    "tcp",
        Addr:   "<IP_ADDRESS>:3306",
        DBName: "recordings",
    }

The specified driver now requires: AllowNativePasswords: true,, therefore the Go MySQL tutorial need a refresh.
The intended audience of Go tutorials probably will not know to search the GoLang Issues Queue for this workaround.
@dr2chase - Could you sponsor this doc change, or review with team?
Tutorial: https://go.dev/doc/tutorial/database-access


Can't get a dependency to work

In train.py and eval.py, the line from data_load import DataLoader, AudioMeta seems to cause the following error: ModuleNotFoundError: No module named 'tensorpack.dataflow.prefetch'.
I've verified that tensorpack is installed but can't seem to get passed this. I've actually tried this on multiple computers and get the same error. Has anyone encountered this?

Looks like now PrefetchData is supposed to be imported like
"from tensorpack.dataflow import PrefetchData"
(information from this place)
I made a pull-request with new variation of importing.
https://github.com/andabi/voice-vector/pull/7

read the requirments,you will find the tensorpack's version


Add gRPC retries doc

Blocked on https://github.com/grpc/grpc-dotnet/pull/1187 being merged and released.

@JamesNK, do you want me to do a review to get that started?  You labeled it blocked I assume since we all can't get builds to look at yet, but thought I could help move it along in between time anyway until we can see a build.

Yes, review now. The content is done. The block is so it doesn’t get merged.

..Waiting for the build system to come back online, then I will verify the doc in the build and squash and merge.

This shouldn’t be merged until the linked PR is merged and released. That will be in a weeks time.


Release script should use make tests to run tests; also fix build warning.

Fixes #612, Fixes #616

Such a minor change doesn't need review, me thinks.


Added Bangla language

Texts for Bangla language

Please follow instructions in readme: https://github.com/xPaw/CF-ABetterBrowser#how-to-add-a-language


Support records

Support record types to replace shallow copy constructor with deep copy constructor

is resolved with milestone 1.0.16


Add initial TextureArray wrapper

Adds support for TextureArray objects with LibGDX.
This requires GLES 3.0+ compatibility, and has been tested on android/lwjgl and lwjgl3 backends.
A few tweaks were needed to the android and lwjgl graphics interfaces to correctly create an uninitialized 3D texture.
See the sample test case provided for usecase.

Looks good! I'd say merge it (and update CHANGES)

Do you have plans to integrate it with TextureAtlas? (so that TextureAtlas would use 1 TextureArray instead of several textures)


Dashboard pie and bar chart not visible - only EE feature

System information:

Operating system (distribution) and version
Windows 10
DBeaver version
DBeaver 6.1.2

Connection specification:

Any Database

Describe your question:
In the dashboard creation dialog pie and bar chart are not selectable. Is this an DBeaver EE feature?
I've looked at the wiki and there the pie and bar chart type can be selected in the Default view drop down. However I can only select timeseries:

hi @Sargul ,
sorry for the late response,
Yes, you're right, Pie and bar charts are EE feature. So for CE version only Time series view is available.


Any chance to get EZBUSBA updated?

Dear all,
I am using the Elelabs EZBUSBA device (around five years old) and I experience a strange behaviour in Home Assistant (see https://community.home-assistant.io/t/randomly-switching-zigbee-plug/479839/2).
Now I wonder if a firmware update would improve the situation. Is there a chance to see this stick covered within this project? Or would you be willing to guide me to the right firmware files (I did not find too much on the web)?
Thanks,
Tobias

@Tobster77
Sadly no.
Unfortunately the EZBUSBA is based on older silabs microcontroller (relevant at the time) EM3585. Silabs no longer provides SDK or software updates for that microcontroller, so we at Elelabs can't release new firmwares for it based on the latest SDK.
However, the Zigbee protocol itself didn't change much, so the adapter should work with majority products and software stacks on the market. Unless you want a specific new feature or have a specific issue you want to fix, there is no need to update to the latest software.
In case you wish to update your hardware to our current MG13 version of the USB stick, let us know at<EMAIL_ADDRESS>we will provide you with a discount.


Add CSRF token to dev preview mailbox (fixes #381)

When used in a router pipeline that includes the :protect_from_forgery plug, a CSRF token is required for the "Delete Message Queue" functionality to work.

Thanks a lot for referencing the possibly relevant issue.

Released v1.0.3


Convert script

Can you please provide a script to convert from CSV to JSON? Thx a lot!

probably this script is something you need: https://gist.github.com/yeggor/9a28660a83121e52cff7416f643e9570

this script is probably something you need: https://gist.github.com/yeggor/9a28660a83121e52cff7416f643e9570

Thanks!!


Sticky table headers?

I can't make <thead> elements sticky (at least not on Chrome). In your example your <th> example TH {top: -40px; margin-bottom: 150px;} doesn't seem to work either :(

http://d.pr/i/1fEPV

Chrome 56 now has native position:sticky support, even for table cells/headers.

@wilddeer Firefox 59 has native position: sticky support for table parts. Can the guard be removed in a new release of stickyfill?


[FR] Add support for 3D point clouds, 3D detections, and birds eye view

Proposal Summary
Currently, Fiftyone supports image and video. And I find it a bit troublesome to support new media types (like point cloud), especially when trying not to modify the source code (so that I can directly install Fiftyone using pip instead of building it locally).
In my work, I want to read point cloud files and visualize them in bird-eye-view (BEV). A possible way can be still recognizing the point-cloud files as images, and processing them to BEV images in function draw_label. But I'm still wondering if there can be any better way.
Motivation

What is the use case for this feature?
In 3D vision tasks, which is common in autonomous driving.

Why is this use case valuable to support for your project(s) or
organization?
I'm doing some work about 3D detection in autonomous driving, and hoping to visualize the detection results in bird-eye-view or even in 3D point-cloud.

Why is it currently difficult to achieve this use case? (please be as
specific as possible about why related FiftyOne features and components are
insufficient)
I'm trying to add new media_type without modifying the source code of Fiftyone, by adding wrapper to fo.Sample and fo.Dataset. But I find it hard as too many modules in the library rely on fom.MEDIA_TYPE. It will be appreciated if customized media_type can be supported, or simply supporting point cloud.

What areas of FiftyOne does this feature affect?

[x] App: FiftyOne application
[x] Core: Core fiftyone Python library
[x] Server: FiftyOne server

Willingness to contribute
The FiftyOne Community encourages new feature contributions. Would you or
another member of your organization be willing to contribute an implementation
of this feature?

[ ] Yes. I can contribute this feature independently.
[x] Yes. I would be willing to contribute this feature with guidance from
the FiftyOne community.
[ ] No. I cannot contribute this feature at this time.

Hi @brimoor ~
Thanks for your reply. I'm grad to hear that the development of support for 3D point cloud datasets is in the progress.

Example point cloud data. I assume .pcd format?
Example 3D detections, so we can see the format you're working with

About the point cloud data and 3D detection, I think KITTI 3D Object Detection Benchmark is a valuable reference. You can find the point cloud data and the development kit in the website.
I don't know whether there is a standard point cloud file format. Anyway, I think a general function to read point cloud data is hard to satisfy the all kinds of need and it could be better if we can customize our point cloud file reader. For example, in  autonomous driving, we usually have more than one lidar (e.g. one master lidar and two side lidar), and we usually concatenate the point cloud at several successive timestamps together before pushing it into the DNN. We may need to read the point cloud from multiple data files and preprocess the data before getting the final point cloud.

Any tools you are using to render the point cloud data today?
I'm not quite familiar with the 3d rendering tools. And to my knowledge, pcl, matplotlib, open3d, and pharos seem to be good tools for 3d visualization, especially the last two, which support Jupyter(open3d) and web gui(pharos).

Supported!


Add CI

We should add CI to increase our confidence when merging
We still need to write tests #11 but we could leverage CI for things like Yarn check #59 as well.

Closing because this project is now deprecated.


Upgrade pymongo dependency to 3.x

@danlamanna and I ran into a problem of pymongo version mismatch in a Tangelo-Romanesco experiment.  After pip installing Romanesco, we solved this issue by force-upgrading PyMongo back to version 3.
If Romanesco is able to use PyMongo 3 easily, it might prevent version mismatches in this type of interaction.

My vote would be that we move the mongodb IO mode into a plugin so we can move pymongo out of requirements.txt and into requirements-dev.txt. And we can also upgrade the version there :)

:+1:

Good idea @zachmullen


Add precision_metrics for multilabel labels

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (47f1ed5) to head (fd025ba).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #108   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           36        36
  Lines          846       859   +13
  Branches        94        96    +2
=========================================
+ Hits           846       859   +13

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Build System Page Rewrite

The Build System page is out-of-date. It contains information on CircleCI configuration for functionality that has since been moved to Azure.
There is a note (easy to miss) on the page, but adding this issue for better visibility.

Closed by https://github.com/bioconda/bioconda-docs/pull/16


Beta/rxandroible2

A couple of fixes / updates for the RxAndroidble2 branch. The timeout fix is important, the others are just tidying.

Fixed connection timeout, I chose the wrong timeout overload when converting the RxJava2, currently it will always fail after the connection was successful as timeout is applied to all items emitted not just the first.
Added missing bluetooth connection status enums to error converter
I've used source tidy to add finals to method parameters as they we're present on all.

@mikolak I've also cherry-picked the new commits from master to bring it up to date.
What is going to be the plan for this RxAndroidble2 branch?

There will be a new, and hopefully more active (sorry for that!), maintainer for the libraries. I've recommended making this a stable release to them.

Closing this PR due to new rxandroidble2


Feature request: Support for valves

Hi, here another feature request for such a great project.
The support for valves with the implement timer and the four given icons in HomeKit would be great.

In v1.1.8, see https://github.com/ebaauw/homebridge-rpi/wiki/valve-device.


'FormikContext' refers to a value, but is being used as a type here. Did you mean 'typeof FormikContext'?ts(2749)

After updating Formik from 1.5.8 to 2.2.0 an error occurs on line:
formik: FormikContext;
Stating: 'FormikContext' refers to a value, but is being used as a type here. Did you mean 'typeof FormikContext'?ts(2749)
I have reviewed all change logs since 1.5.8 to 2.2.0 and can not find any breaking change causing this behaviour,
How to fix it?

Hey @tomaszs the FormikContext type that you are using here - formik: FormikContext; is being renamed to FormikContextType and the FormikContext actually refers to the React.Context for the form and is not a type/interface anymore.
Please migrate formik: FormikContext; to formik: FormikContextType;


Icon support

I like to have icons in menus, as it makes it easier to visually scan them. Looking at the available icons I wondered if I could find suitable icons for all the menu items, and indeed found something nice for almost all menus:

Screenshots

Right now I just hard-coded them into the config, but next I'd like to add proper support. I'd propose having an "icon" key for a binding, which which-key then would display depending on a global whichkey.showIcons setting or so.
How does that sound?

That's pretty cool. I implemented the support at https://github.com/VSpaceCode/vscode-which-key/commit/f5be86d4dbad195427c28d0c0007fed324b8d6b3 in the refactoring branch. You can switch to the branch to try it out.
It would be great if you can help us add the icons in VSpaceCode bindings once a new version is released.

Awesome, thank you! FWIW I wanted to try installing the extension on the refactoring branch with vsce package, but that complains:
 ERROR  @types/vscode ^1.54.0 greater than engines.vscode ^1.45.0. Consider upgrade engines.vscode or use an older @types/vscode version

I updated some packages in that branch. Apparently, I also made the vscode type out of sync. Fixed in 1bc6ad7786d7941992e249281fffcc34aed5ae14

Yay, thanks! I adapted my changes (regexes ftw, see also). Seems to work great so far. I'll wait until the next vscode-which-key release (and perhaps improve the icons a bit more until then) and then open a PR.

regexes ftw indeed. That awesome, I am finishing up documentation for the new version. Hopefully, I can release it soon especially it has been in the works for a while.

After testing this for a bit, I noticed a couple of icons don't seem to show up:

+Window:

+Text:

+Zoom / *:

But they are defined in my icons branch, e.g.:
https://github.com/The-Compiler/VSpaceCode/blob/0cc4cfe934d42304f58f0aaedcec0c2051b4308c/package.json#L280
and my VS Code seems to know about them, as they get displayed when I enter :$(selection) (abusing https://github.com/VSCodeVim/Vim/issues/6655).
Any idea what's going wrong there?

Thanks for reporting, there are two things happening:

Icon in transient menu hasn't been implemented
The transient type will be deprecated, and are converted to a separate command internally. The conversion didn't take into account of icon key.

I will implement them before I release the new version of which-key, but I am a little busy atm. Might take a bit more time.

No worries, take your time! :+1:

You could also release now and you specify in the README that icons do not work for transient mode, it's up to you :)

FWIW while y'all don't owe me anything, I'd really appreciate if this was working before the release. I've spent a lot of time picking >600 icons for all the VSpaceCode menus, and having icons for some items but not others in the same menu looks quite weird IMHO (and makes it harder to scan the contents visually with the text "jumping" around, kind of defeating the whole motivation behind those icons).

@The-Compiler, the branch is updated with icon support for transient. It would be great if you can try it out :)

Looks great now, thank you! :rocket:

v0.9.0 is finally released!! Closed.
@The-Compiler It would be amazing if you can open a pull request for the icon your used for the vspacecode's bindings :)

Will open a PR later today or tomorrow! Just going through them again, as I think there are better options for some of those (e.g. I was mixing up windows and frames :sweat_smile:)


[FIX] ERRORS AND WARNINGS

New Task:
What is the task

Who is the task for?

[x] I created this task for me to complete, I will create a PR soon.
[ ] I created this task for someone else to claim.
[ ] I think this is a task that multiple people can do

Confirm all of the following:

[x] I have looked at all the issues currently available and this does not exist or overlap with another ticket

⚠ PLEASE ONLY SUBMIT A PR FOR THIS TASK IF THIS TASK WAS AVAILABLE FOR YOU TO CLAIM

fixing linter warnings

fixing linter warnings


Layer layout navigation node pagination

I think I saw some these changes in previous PR's. Can you please merge these branches or change PR destination to simplify review?
Tell us if need any help with this :)


bug fix:#4646

bug fix:#4646
invalid use of nil pointer in container restoring

Please sign off with full name


Added remove-empty-groups option

If this option is True (default false) we'll remove groups if they have 0 processes (by default we leave the group, assuming processes from that group will be back)
The only real change is at the end of file proc/grouper.go - where I remove un-found groups if remove-dead-groups is true

Merging this branch int https://github.com/RedisLabs/process-exporter/pull/1 instead


Remove shadow

Please, how can I remove the shadow?

I've added this in b238a906bebe67a90121843886a24ec648b1b875, it'll be possible in the next release :-)

thank you very much :)


pip install failure deprecation on >=v0.26.4

Describe the bug
Versions >= v0.26.4 fail to install on fresh Ubuntu 22.04 container w/ Kernel Linux [redacted]-2017 <IP_ADDRESS>-microsoft-standard-WSL2 #1 SMP Fri Apr 2 22:23:49 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
To Reproduce
With the following Dockerfile:
FROM ubuntu:22.04

RUN \
    DEBIAN_FRONTEND=noninteractive apt-get update && \
    DEBIAN_FRONTEND=noninteractive apt-get install -y \
    curl \
    git \
    python3 python3-pip

RUN echo "openai==0.26.4" > /requirements.txt
RUN pip install -r /requirements.txt

Note the installation failure:
 > [4/4] RUN pip install -r /requirements.txt:
#10 1.029 Collecting openai==0.26.4
#10 1.265   Downloading openai-0.26.4.tar.gz (55 kB)
#10 1.298      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 55.6/55.6 KB 1.6 MB/s eta 0:00:00
#10 1.463   Installing build dependencies: started
#10 4.490   Installing build dependencies: finished with status 'done'
#10 4.493   Getting requirements to build wheel: started
#10 4.689   Getting requirements to build wheel: finished with status 'error'
#10 4.698   error: subprocess-exited-with-error
#10 4.698
#10 4.698   × Getting requirements to build wheel did not run successfully.
#10 4.698   │ exit code: 1
#10 4.698   ╰─> [81 lines of output]
#10 4.698       Traceback (most recent call last):
#10 4.698         File "/usr/lib/python3/dist-packages/setuptools/config.py", line 419, in _parse_attr
#10 4.698           return getattr(StaticModule(module_name), attr_name)
#10 4.698         File "/usr/lib/python3/dist-packages/setuptools/config.py", line 26, in __init__
#10 4.698           spec = importlib.util.find_spec(name)
#10 4.698         File "/usr/lib/python3.10/importlib/util.py", line 94, in find_spec
#10 4.698           parent = __import__(parent_name, fromlist=['__path__'])
#10 4.698         File "/tmp/pip-install-7lrzz_ii/openai_2922e99e37a54fe8816c6c965a07945b/openai/__init__.py", line 9, in <module>
#10 4.698           from openai.api_resources import (
#10 4.698         File "/tmp/pip-install-7lrzz_ii/openai_2922e99e37a54fe8816c6c965a07945b/openai/api_resources/__init__.py", line 1, in <module>
#10 4.698           from openai.api_resources.completion import Completion  # noqa: F401
#10 4.698         File "/tmp/pip-install-7lrzz_ii/openai_2922e99e37a54fe8816c6c965a07945b/openai/api_resources/completion.py", line 4, in <module>
#10 4.698           from openai.api_resources.abstract import DeletableAPIResource, ListableAPIResource
#10 4.698         File "/tmp/pip-install-7lrzz_ii/openai_2922e99e37a54fe8816c6c965a07945b/openai/api_resources/abstract/__init__.py", line 3, in <module>
#10 4.698           from openai.api_resources.abstract.api_resource import APIResource
#10 4.698         File "/tmp/pip-install-7lrzz_ii/openai_2922e99e37a54fe8816c6c965a07945b/openai/api_resources/abstract/api_resource.py", line 4, in <module>
#10 4.698           from openai import api_requestor, error, util
#10 4.698         File "/tmp/pip-install-7lrzz_ii/openai_2922e99e37a54fe8816c6c965a07945b/openai/api_requestor.py", line 21, in <module>
#10 4.698           import aiohttp
#10 4.698       ModuleNotFoundError: No module named 'aiohttp'
#10 4.698
#10 4.698       During handling of the above exception, another exception occurred:
#10 4.698
#10 4.698       Traceback (most recent call last):
#10 4.698         File "/usr/lib/python3/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 363, in <module>
#10 4.698           main()
#10 4.698         File "/usr/lib/python3/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 345, in main
#10 4.698           json_out['return_val'] = hook(**hook_input['kwargs'])
#10 4.698         File "/usr/lib/python3/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 130, in get_requires_for_build_wheel
#10 4.698           return hook(config_settings)
#10 4.698         File "/usr/lib/python3/dist-packages/setuptools/build_meta.py", line 162, in get_requires_for_build_wheel
#10 4.698           return self._get_build_requires(
#10 4.698         File "/usr/lib/python3/dist-packages/setuptools/build_meta.py", line 143, in _get_build_requires
#10 4.698           self.run_setup()
#10 4.698         File "/usr/lib/python3/dist-packages/setuptools/build_meta.py", line 158, in run_setup
#10 4.698           exec(compile(code, __file__, 'exec'), locals())
#10 4.698         File "setup.py", line 3, in <module>
#10 4.698           setup()
#10 4.698         File "/usr/lib/python3/dist-packages/setuptools/__init__.py", line 153, in setup
#10 4.698           return distutils.core.setup(**attrs)
#10 4.698         File "/usr/lib/python3/dist-packages/setuptools/_distutils/core.py", line 122, in setup
#10 4.698           dist.parse_config_files()
#10 4.698         File "/usr/lib/python3/dist-packages/setuptools/dist.py", line 804, in parse_config_files
#10 4.698           parse_configuration(
#10 4.698         File "/usr/lib/python3/dist-packages/setuptools/config.py", line 158, in parse_configuration
#10 4.698           meta.parse()
#10 4.698         File "/usr/lib/python3/dist-packages/setuptools/config.py", line 498, in parse
#10 4.698           section_parser_method(section_options)
#10 4.698         File "/usr/lib/python3/dist-packages/setuptools/config.py", line 469, in parse_section
#10 4.698           self[name] = value
#10 4.698         File "/usr/lib/python3/dist-packages/setuptools/config.py", line 222, in __setitem__
#10 4.698           value = parser(value)
#10 4.698         File "/usr/lib/python3/dist-packages/setuptools/config.py", line 599, in _parse_version
#10 4.698           version = self._parse_attr(value, self.package_dir)
#10 4.698         File "/usr/lib/python3/dist-packages/setuptools/config.py", line 422, in _parse_attr
#10 4.698           module = importlib.import_module(module_name)
#10 4.698         File "/usr/lib/python3.10/importlib/__init__.py", line 126, in import_module
#10 4.698           return _bootstrap._gcd_import(name[level:], package, level)
#10 4.698         File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
#10 4.698         File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
#10 4.698         File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked
#10 4.698         File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
#10 4.698         File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
#10 4.698         File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
#10 4.698         File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
#10 4.698         File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
#10 4.698         File "<frozen importlib._bootstrap_external>", line 883, in exec_module
#10 4.698         File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
#10 4.698         File "/tmp/pip-install-7lrzz_ii/openai_2922e99e37a54fe8816c6c965a07945b/openai/__init__.py", line 9, in <module>
#10 4.698           from openai.api_resources import (
#10 4.698         File "/tmp/pip-install-7lrzz_ii/openai_2922e99e37a54fe8816c6c965a07945b/openai/api_resources/__init__.py", line 1, in <module>
#10 4.698           from openai.api_resources.completion import Completion  # noqa: F401
#10 4.698         File "/tmp/pip-install-7lrzz_ii/openai_2922e99e37a54fe8816c6c965a07945b/openai/api_resources/completion.py", line 4, in <module>
#10 4.698           from openai.api_resources.abstract import DeletableAPIResource, ListableAPIResource
#10 4.698         File "/tmp/pip-install-7lrzz_ii/openai_2922e99e37a54fe8816c6c965a07945b/openai/api_resources/abstract/__init__.py", line 3, in <module>
#10 4.698           from openai.api_resources.abstract.api_resource import APIResource
#10 4.698         File "/tmp/pip-install-7lrzz_ii/openai_2922e99e37a54fe8816c6c965a07945b/openai/api_resources/abstract/api_resource.py", line 4, in <module>
#10 4.698           from openai import api_requestor, error, util
#10 4.698         File "/tmp/pip-install-7lrzz_ii/openai_2922e99e37a54fe8816c6c965a07945b/openai/api_requestor.py", line 21, in <module>
#10 4.698           import aiohttp
#10 4.698       ModuleNotFoundError: No module named 'aiohttp'
#10 4.698       [end of output]
#10 4.698
#10 4.698   note: This error originates from a subprocess, and is likely not a problem with pip.
#10 4.702 error: subprocess-exited-with-error
#10 4.702
#10 4.702 × Getting requirements to build wheel did not run successfully.
#10 4.702 │ exit code: 1
#10 4.702 ╰─> See above for output.
#10 4.702
#10 4.702 note: This error originates from a subprocess, and is likely not a problem with pip.

Installs cleanly with:
FROM ubuntu:22.04

RUN \
    DEBIAN_FRONTEND=noninteractive apt-get update && \
    DEBIAN_FRONTEND=noninteractive apt-get install -y \
    curl \
    git \
    python3 python3-pip

RUN echo "openai==0.26.3" > /requirements.txt
RUN pip install -r /requirements.txt

Code snippets
No response
OS
Windows 10/WSL2
Python version
Python 3.10.6
Library version
openai-python >=v0.26.4

This is a dupe of https://github.com/openai/openai-python/issues/219 , but I narrowed things down for you.

this issue should be fixed in v0.27.2. Can you give that a shot?


[WIP] Disables detailed monitoring for simple template instances.

High Level Description
What features does this change enable? What bugs does this change fix? High-Level description of how things changed.
Related Issues

DCOS_OSS- Foo the Bar so it stops Bazzing.
DCOS- Foo the Bar so it stops Bazzing.

Checklist for all PR's

[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[ ] Read the DC/OS contributing guidelines
[ ] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and Review Process
What is the review process and when will my changes land?
All PRs require 2 approvals using github's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

LGTM.
If a user wants to have this feature after the cluster is launched, you can still enable detailed monitoring on an instance after the instance is running or stopped. Cost savings benefit as well for simple cloudformation templates.

cc: @lingmann.


matterbridge module: add configPath option as a workaround, waiting for nix encryption

Motivation for this change
Waiting for NixOS/rfcs/pull/5 , files including secrets should not be set in the nix store, so adding a configPath option as workaround.
I've tested this PR with nixos-rebuild and nix-diff: with the same configuration, absolutely no change happens (apart from the nixos-version hash change). With configPath set, the parameter appears to be properly set.
I think that, as a security fix, this deserves backport to 18.03.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

For easy review, the diff is unexpectedly big due to my removing a useless mkMerge, which reduces indentation and generates a diff. The only real changes in the config section are the removal of the useless mkMerge, and the replacement of mkIf with optional in the users/groups definition.


View title actions not shown when hovering over view on webview views

Actions in the view title bar are usually visible when the mouse is anywhere in the view. As shown here:

In the focus mode view, however, "Open Pull Request on GitHub" is only visible when hovering over the actual title bar. That makes it hard to discover. I suspect that's because the webview consumes the hover events.
     {
        "command": "pr.openPullRequestOnGitHub",
        "title": "Open Pull Request on GitHub",
        "category": "GitHub Pull Requests",
        "icon": "$(globe)"
      },

Duplicate of #109030


Expensify Card - No error message when incorrect code is entered when deactivating card

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.60-0
Reproducible in staging?: Y
**Reproducible in production?:**N, New feature
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Slack conversation (hyperlinked to channel name):
Issue found when executing PR https://github.com/Expensify/App/pull/51147
Action Performed:
Precondition:

User has a virtual card

Go to staging.new.expensify.com
Go to Wallet
Click on the virtual card
Click Report virtual card fraud
Click Deactivate card
Enter incorrect magic code

Expected Result:
There will be error for incorrect magic code
Actual Result:
There is no error for incorrect magic code.
App shows not here page briefly and then empty card details page loads
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[x] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/5414b64d-54a6-44fc-8098-8bb6f11a6d5c
View all open jobs on GitHub

New feature, not repro on Production
https://github.com/user-attachments/assets/88502225-de49-4096-b5a9-c9a7f797e337

This will require backend changes, reassigning and demoting.

I think the last piece was https://github.com/Expensify/Auth/pull/12739 and we can close this now, right @youssef-lr?

Yup!


WIP Reservation validation specs

Coverage increased (+0.05%) to 21.583% when pulling 12af9b1aa953b4afdeb142b007b6c8f17146eea9 on reservation_validation_specs into 755e48111f3ca56e49b53e8eabd83d2a9962e314 on reservations_ui_update.

Coverage increased (+0.03%) to 21.569% when pulling 713d1186f513bea43a52b04cf27285551bd73483 on reservation_validation_specs into 755e48111f3ca56e49b53e8eabd83d2a9962e314 on reservations_ui_update.


Add a higher level API.

Summary
Currently, this only supports Sigstore (and only DSSE on verification). I want to push this now so that people can start playing with it while I update the Colab demo and try to make the API more uniform and add support for the missing cases.
With this, the default signing should be as simple as
from model_signing import api as model_signing_api

model_signing_api.sign(model_path, signature_path)

And verification would be as simple as:
from model_signing import api as model_signing_api

model_signing_api.verify(
  model_path, signature_path,
  expected_identity, expected_oidc_provider
)

Will think on how to simplify this even further..
This is part of #172, but not yet closing it
Release Note
NONE
Documentation
NONE

I think the main thing that stands out to me now is that Signing/Verifying is a high level wrapper that tends to be simple, but the devil is in the Hashing details.

That is true. For most usecases, the config should not be used to change anything from the defaults, but we want to allow flexibility.

The HashingConfig seems like a copy of the serialization API.

I'm planning to make it even more uniform in the future, having setters for each field and then a verification method just before the first signing event. But for that I'd first need to make the serialization API more uniform.

I assume the aim is to be explicit about what is backwards compatible by semver? Either way that seems like the rough point to me currently.

Yup. We can then change anything else in the library and as long as these methods have the same interface no user would be broken. In fact, probably we should make everything else private (but need to check with documentation, so let's do this only after we have all documentation done).

Anything under 1.0 can expect breaking changes?

Yeah, we'll follow https://semver.org/#semantic-versioning-specification-semver
Thank you for the review!


Don't run example UI tests on build/release

UI Tests are now passing on windows 🎉
On mac, we are waiting to hear from https://github.com/browser-actions/setup-chrome/issues/329 to see if we can get that going and if it doesn't get resolved, we'll either have to not run the UI tests on the runner or find another way to update chromium... Maybe only run the UI tests on windows and the rest of the tests on both Windows and Mac??

@BenjaminMichaelis I went ahead and just excluded the test runs for now since they're examples. It would probably make most sense to have them be a separate job so that it doesn't block merging or deployment, but will let us know if things drift out of date again.

Yeah we can build another step to do that, should be pretty trivial


KMS connection failure: "session limit of 1048576 messages exceeded"

We've just experience the below error ("signing operation failed") on the tmkms side, while connecting to irisd instance for irishub.
As the current iris release does not support automatic KMS connection recovery, manual intervention was required, leading to some missed blocks in the interim:

Quick search of the GitHub repo doesn't reveal anything related to this, so I am stuck trying to determine what would cause this error. Any help appreciated.
18:31:35 [INFO] [irishub@tcp://xxxx:27659] connected to validator successfully
06:15:14 [ERROR] [irishub@tcp://xxxx:27659] signing operation failed: protocol error: session limit of 1048576 messages exceeded: protocol error: session limit of 1048576 messages exceeded
06:15:15 [INFO] KMS node ID: DD7036834704E2CFF8C7B35C68F8933D18ECA2E8
06:32:23 [ERROR] [irishub@tcp://xxxx:27659] I/O error

These errors are supposed to be handled internally within yubihsm-rs, however it doesn't look like that happened correctly.
I'll see if I can write some tests to reproduce and handle this better.

@zmanian also commented on Twitter: "This sounds like a secret connection needing to re-key and the lack of auto restart on the Tendermint side causing a failure"

Yep, that's correct

I opened up a PR to automatically initiate a new session and retry sending the command in the event this occurs:
https://github.com/tendermint/yubihsm-rs/pull/203

The above PR was included in yubihsm-rs v0.25.0, which is included in #259 (which I will hopefully land today)

#259 is landed, so I'll close this out.


simple client-routeing it works at  http://localhost:8080/edit  ,but didn't work at http://localhost:8080/edit/

Bug report

What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?

Other relevant information:
webpack version:
Node.js version:
Operating System:
Additional tools:

Please fill the issue template.


MPI Dependency for Computation-Communication Overlapping in Tensor Parallelism

Hi,
I've noticed that you have implemented that allows for the overlapping of computation and communication in tensor parallel operations. This is a significant enhancement that has the potential to increase efficiency in distributed training workflows.
However, during my attempts to deploy jobs using torchrun on a Kubernetes (k8s) cluster, I encountered an issue where this overlapping feature does not operate as expected. It appears that the current implementation has a dependency on MPI for certain initialization procedures, which may not be fully compatible with the k8s environment.
Given the growing trend of containerized deployments and the adoption of Kubernetes for distributed jobs, I was wondering if there are any plans to abstract away or remove the MPI dependency for this feature.
Thanks!

@denera is currently working on lifting the MPI requirement for that overlap.


Fix approval on sent

Coverage decreased (-0.06%) to 64.947% when pulling b298ed58a3cb2225f726f2ea1a3b60f175768c48 on fix-approval-onSent into 85ef045011abe037ade85aacf043c61ff1a89c8d on master.

Coverage decreased (-0.06%) to 64.947% when pulling b298ed58a3cb2225f726f2ea1a3b60f175768c48 on fix-approval-onSent into 85ef045011abe037ade85aacf043c61ff1a89c8d on master.


Support vcf file

Can you provide support for vcf file as gtf and bam files?

This is on my list but it needs some thinking. Thanks for creating an issue :)

Note to self and others about what needs to be done to support VCF:
The main problems:

VCF-files can be huge. In this case, other programs are more appropriate.

The multiline headers are often meaningful and should be preserved, but they should and cannot be preserved in the PyRanges themselves. I do not want to subclass PyRanges or create a proliferation of object types (🤮).

The current string representation method actually deducts columns until the pyrange can fit the console size. It should instead build a string rep until it can no longer fit the console (duh!).

I see that pysam is able to read a host of file formats, not just sam/bam, so this feature might not be so hard to implement.

More problems:
the VCF is not a tidy file-format (pdf link). It mixes data with information about the data in the same entry, like the value of the genotypes and information about whether the data is phased or not.
Example:
#CHROM POS ID REF ALT QUAL FILTER INFO FORMAT NA00001 NA00002 NA00003
20 14370 rs6054257 G A 29 PASS NS=3;DP=14;AF=0.5;DB;H2 GT:GQ:DP:HQ 0|0:48:1:51,51 1|0:48:8:51,51 1/1:43:5:.,.
20 17330 . T A 3 q10 NS=3;DP=11;AF=0.017 GT:GQ:DP:HQ 0|0:49:3:58,50 0|1:3:5:65,3 0/0:41:3
20 1110696 rs6040355 A G,T 67 PASS NS=2;DP=10;AF=0.333,0.667;AA=T;DB GT:GQ:DP:HQ 1|2:21:6:23,27 2|1:2:0:18,2 2/2:35:4
20 1230237 . T . 47 PASS NS=3;DP=13;AA=T GT:GQ:DP:HQ 0|0:54:7:56,60 0|0:48:4:51,51 0/0:61:2
20 1234567 microsat1 GTC G,GTCT 50 PASS NS=3;DP=9;AA=G GT:GQ:DP 0/1:35:4 0/2:17:2 1/1:40:3

This means that

you need special tooling to parse and work with the data
you cannot store each entry in a native datatype,  0|0:49:3:58,50 needs to be stored as a string. This means that the data is not contiguous in memory, but rather placed on the heap and takes up a lot of memory. I.e. working with the data is slow and expensive.

This means that in-memory representations of VCF/BCF in pandas (and hence pyranges) is not going to be super-helpful, as it would be slow and memory-consuming to work with.
I see being able to handle BCF/VCF as important, but it needs a lot of thinking.
I could create a reader for the genomic locations and non-genotype columns to begin with, but even that is not straightforward as the different alleles might be of different lengths, like microsat1 above.
Is it
chr20 1234567 1234570(GTC)
or
chr20 1234567 1234570 (C,GTCT)?

For those of you who are interested in reading VCF/BCF into pyranges, what is your use-case? Just trying to understand the problem better.

If I read the genomic locations and non-genotype data from a vcf/bcf into a pyranges, would that be helpful?

Your points are right. I think reading vcf files may not be in the scope of the pyranges. But there are interesting use cases. For example, I want to overlap exons or transcripts with variants. In this case, I need to convert each variant into pyrange and overlap with exons pyrange table.

For those of you who are interested in reading VCF/BCF into pyranges, what is your use-case? Just trying to understand the problem better.

For me the main use cases would be:

Identifying mutations present in one or several samples, but not in the others. This is currently doable through bcftools, but doing this in python could potentially make subsequent analysis easier. Also, avoiding the expression syntax of bcftools, and instead use the more familiar pandas queries could be nice.
Intersecting mutations with various genomic features. This is doable with bedtools, but in my experience this is often very slow and, again, requires using tools outside of python.

Okay, I would love to try to support this.

To make this happen I would need to support reading BCFs. I guess pysam does that.

The data in VCFs are not tidy; each entry might look like the following:

0/1:35:4

Hence, pandas would likely be slow since each entry would be stored as strings scattered on the heap, not contiguously in native datatypes.
I could make a flag so that only the meta-data columns from VCFs are read: then you could work quickly in pandas and fetch out the appropriate genes afterwards with a simple command. Or do the whole thing in Python, but likely a bit slower.

Note to self: check out https://academic.oup.com/bioinformatics/article/33/12/1867/2971439

This issue has increased priority now. As soon as we have enough workforce we'll address it.
Some thoughts on the way forward:

create a simple VCF/BCF reader (or rely on external library) that, analogously to current GTF reader, would expand features to separate columns. Each column may still host complex values as mentioned, e.g. 0/1:35:4.
create utilities to split some columns to separate columns
create an indexer object or a filter function so that the user can get certain lines by specifying a convenient search pattern (e.g. genotypes of certain individuals; or even more generally an inheritance pattern)


client: return correct error for 50x response

[Updated]
etcd always returns 500/503 response when it may have no leader.
So we should log the other 50x response in a normal way.
This helps to log correctly when discovery meets 504 error. Before this
PR, it logs like this:
18:31:58 etcd2 | 2015/08/4 18:31:58 discovery: error #0: client: etcd
member https://discovery.etcd.io has no leader
18:31:58 etcd2 | 2015/08/4 18:31:58 discovery: waiting for other nodes:
error connecting to https://discovery.etcd.io, retrying in 4s

After this PR:
22:20:25 etcd2 | 2015/08/4 22:20:25 discovery: error #0: client: etcd
member https://discovery.etcd.io returns server error [Gateway Timeout]
22:20:25 etcd2 | 2015/08/4 22:20:25 discovery: waiting for other nodes:
error connecting to https://discovery.etcd.io, retrying in 4s

fixes #3012

Have updated log line. PTAL

LGTM


No tag on this repository (and three others)

Hi @fabiospampinato, thanks for all this code!
I'm in the process of trying to package tsex for Debian, and I discovered that this repository, along with get-current-package, isostore and tiny-levenshtein do not have any tags.
Would it be possible to tag them all appropriately (with 1.0.0)?  It will help us to ensure that we stay up-to-date with any changes.
Thanks!
Julian

Hi Julian. I'm not familiar with packaging for Debian, why would you want that? To not have to install NPM to use some packages?

Would it be possible to tag them all appropriately (with 1.0.0)? It will help us to ensure that we stay up-to-date with any changes.

Yes, you are highlighting a bit of an issue I didn't pay attention too, I use a tool for bumping version numbers and tagging commits, the thing is until I bump the version number no commits are tagged 🤔 I should have thought about that. I can ago through all my packages and add a tag for the initial release in each of them, but since I have like hundreds of them I'm not really have the time and patience right now to go through all this manual work.

In the meantime I've fixed the problem for tsex and all of its dependencies 🤪 hopefully that unblocks you.

Fixed across all my repos 😵💫 thanks!

Aww, thanks @fabiospampinato!  I was going to suggest a short shell script to do the job, but you beat me to it (sorry for the slow reply).


pkg: cmd: remove "version" command from pkg

The "version" command needs the non-exported pkg/version.
his makes the commands pkg unusable outside this project,
that is violating the original design.
We need to untie the commands pkg from the unshipped version pkg;
it is still correct to NOT ship the latter just yet.
The version command is tied to this source tree, so it
makes sense to move it cmd, which we do in this patch.
No expected changes in behaviour.
Signed-off-by: Francesco Romani<EMAIL_ADDRESS>

/lgtm


Refactor docker compose configuration

User Story - Business Need
The local development environment has several docker compose configurations that could be merged into one.

docker-compose.yml
docker-compose-local.yml
docker-compose-test.yml
docker-compose-local-migrate.yml
docker-compose-local-readwrite.yml

The docker-compose and docker-compose-local files do essentially the same thing, with the difference being that docker-compose has only the essential services for the api, where docker-compose-local has the celery tasks. We can accomplish the same thing with one docker compose file and Makefile targets.  The same is true with docker-compose-test, where the only difference is the environment variables (mainly the database URI).  The docker-compose-migrate and docker-compose-local-readwrite files can be replaced with Makefile targets.

[ ] Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)
As a VA Notify developer
I want a simple docker environment
So that my development workflow is streamlined.
Additional Info and Resources

Engineering Checklist

[ ] Merge docker-compose and docker-compose-local and docker-compose-local-readwrite into one and use the name docker-compose.yml
[ ] Merge the docker-compose-test environment variables with the pytest.ini file's environment variables
[ ] Add a Makefile target for creating and applying migrations (make migratations and make upgrade)
[ ] Add a Makefile target for running tests locally (make test-local)
[ ] Add a Makefile target for bringing project up clean. (make fresh)
[ ] Add a Makefile target for bringing project up w/existing data (make up)
[ ] Add a Makefile target for bringing project up with read/write databases (make readwrite)
[ ] Add a Makefile target to build project (make)
[ ] Update documentation

Acceptance Criteria
The Makefile targets work and there is one docker-compose files, docker-compose.yml.

Talked with Michael, after Poetry this change is unneeded, closing as Will Not Do


spread operator should support Java arrays

It already does, doesn't it? @tombentley?

I see an error:
Ceylon backend error: cannot find symbol
symbol:   method sequence()
location: variable objectArray$6 of type java.lang.Object[]
Eclipse. 1.3.1

@LisiLisenok what is your Ceylon code?

@gavinking
https://gist.github.com/LisiLisenok/7bc2e26d351b71dc1f7da4a75124a0b8
It is somekind of java.lang.reflect.Proxy experiments. Function proxyInstance at the end of the file. Commented return method.invoke( delegate, *objectArray.iterable ); works, while return method.invoke( delegate, *objectArray ); leads to the error.

OK, I have reproduced it with:
value words = ObjectArray(4, "hello");
value list = Arrays.asList(*words);

@tombentley would you take a look please?


As an assistant I can produce a report with all the countries in a region organised by largest population to smallest, so that I can provide population information to the management of the organisation

pushed to features/countries_in_region branch in GitHub


Add Page Details in the Header of Settings

User story
When in the Setting Menu, it would be helpful to see which page's settings I am viewing in the header.
E.g. This is the Settings Menu for our fiscal host:

And this is the Settings Menu for an event by that fiscal host

For context: I was in the Settings menu of the event wondering why I didn't have access to virtual cards. It was a bit confusing, but managed to figure out I was in the wrong place.

Another example is when asked to add admin, people may think they are on their initiative's page, but are actually in their own profile page, and can also get confused.

I know the title appears when you hover over the logo, so this might be unnecessary to implement, but just an idea.

This will be solved by the new design @kewitz is implementing in #3880, as we're going to show a breadcrumb:


ASIM WebSession schema parser with its sample and test data for Cisco…

… Meraki.
Required items, please complete
Change(s):

Added ASIM Authentication schema parser for Cisco Meraki based on Syslog data

Reason for Change(s):

Initial version ASIM Authentication Parser

Version Updated:

Initial version

Testing Completed:

Yes

Checked that the validations are passing and have addressed any issues that are present:

Yes

@jayeshprajapaticrest can you please reply on each comment and if the changes are done or not. thanks

Hi @jayeshprajapaticrest, please act on @vakohl's comments. Thanks

Hi @jayeshprajapaticrest, please act on @vakohl's comments. Also kql validations failed please see below screenshot for the same. Thanks

Hi @jayeshprajapaticrest, kql validations failed for below fields please act on these. Thanks

Hi @jayeshprajapaticrest, kql validations failed for below fields please act on these. Thanks

@v-atulyadav all validation errors are fixed


MAINT: Remove redundant example [skip travis] [skip azp]

Remove this example because it seems completely redundant with examples/inverse/plot_mixed_source_space_inverse.py and tutorials/source-modeling/plot_dipole_orientations.py.

@drammock feel free to merge if you agree

thanks @larsoner


[bug:filer] rpc error: code = Unavailable desc = cl osing transport due to: connection error: desc = "error reading from server: EOF", received prior goaway: code: NO_ERROR

Sponsors SeaweedFS via Patreon https://www.patreon.com/seaweedfs
Describe the bug
Some filer servers can't recover after the server throw exceptions.
Here are the exceptions

I have 6 filer servers,5 servers recover after throw the exceptions .the last filer server also has the timewait connection problem

master and volume servers have no error log.
System Setup
weed version: 3.12

@famosss This seems to be normal, since the gRPC server closes all client connections every 10 hours and they hang in the time_white state for some time.

@famosss This seems to be normal, since the gRPC server closes all client connections every 10 hours and they hang in the time_white state for some time.

I think the server should retry itself at least.

fixed.


[New Port Request] nanojson

Library name
nanojson
Library description
Event-Driven JSON Parser for C
Source repository URL
https://github.com/open-source-patterns/nanojsonc
Project homepage (if different from the source repository)
No response
Anything else that is useful to know when adding (such as optional features the library may have that should be included)
nanoJSONc is a C-based event-driven architecture based library for JSON parsing, making it easy to integrate with your project's logic.
Users can register callback functions to respond to specific events, such as key-value pairs within JSON objects or values within JSON arrays, offering a highly customizable and efficient approach to JSON parsing. nanoJSON is ideal for applications where tailored event handling is crucial to processing JSON data effectively.

@JonLiu1993 HI, can you please merge the pull request and publish the library? It's ready to go.


func describe ignores extensions on the trigger

Doing func subscribe for a few attributes/extensions, like:
func subscribe --filter type=com.example --filter extension=my-extension-value --source my-broker

Results in the correct trigger:
...
  spec:
    broker: my-broker
    filter:
      attributes:
        extension: my-extension-value
        type: com.example
    subscriber:
...

However, func describe is not showing the extensions:
func describe
Function name:
  app4
Function is built in image:

Function is deployed in namespace:
  default
Routes:
  http://app4.default.svc.cluster.local
Subscriptions (Source, Type, Broker):
   com.example my-broker

Should we enhance this a bit, since we now are able to create subscriptions (aka Triggers)?

Yes, I believe that we will need to steadily add to func describe as more features are added to the areas it reports.


[improve][authentication] Support for get token from HTTP params

Signed-off-by: Zixuan Liu<EMAIL_ADDRESS>Fixes #16626
Motivation
A scenario that running the standalone Pulsar with WebSocket service, then using the token request param in a WebSocket URL gives an unauthorized response, it seems is not working as intended in the documentation, but it works using a separate WebSocket service.
The root cause is that we did not check whether the token is in the HTTP parameters.
Modifications

Add HttpServletRequestWrapper to support for get token from HTTP params
Add a test for this changes

Documentation

[x] doc-not-needed

You can use mvn clean install -Pcore-modules,-main -DskipTests -Dspotbugs.skip command to build this project.

Thanks @nodece, I was able to pass the compilation problem on 'pulsar-common' but now I have others in 'managed-ledget', I think is something regarding lombok maybe since it says it cannot find some 'get' symbols. I'll try to figure out if I can later.
Anyways, I was trying to build it to test something I had in mind but maybe you could know it firsthand. The thing is, I'm not sure if AuthenticationProviderToken#newHttpAuthState is called for every HTTP request (correct me if I'm wrong) but, if it is, then I think one could manage to authenticate to other requests rather than the WebSocket one by using the token request query param (also not sure if this is intended). E.g.
curl "http://localhost:8080/admin/v2/brokers/configuration?token=ASDFGH...."

Thanks in advance!

Anyways, I was trying to build it to test something I had in mind but maybe you could know it firsthand. The thing is, I'm not sure if AuthenticationProviderToken#newHttpAuthState is called for every HTTP request (correct me if I'm wrong) but, if it is, then I think one could manage to authenticate to other requests rather than the WebSocket one by using the token request query param (also not sure if this is intended). E.g.
curl "http://localhost:8080/admin/v2/brokers/configuration?token=ASDFGH...."

Good idea, I verified that it worked.

Hi @nodece, thanks for checking that!
Sorry since I think that I didn't expose correctly my concerns about that. They are regarding security, I think there is no other option than putting token information in the query param when there is a WebSocket request due to browser API limitations. But I think then that the token query param check should only be applied on WebSocket connection URIs (/ws/ and /ws/v2/) and not the rest.
Do not know if this could be addressed easily, maybe checking in the AuthorizationProviderToken for ws paths? I see references to this paths on pulsar-websocket classes:

WebSocketConsumerServlet
WebSocketReaderServlet
WebSocketProducerServlet
WebSocketPingPongServlet

But not in a "general" one, so maybe just check for /ws/** and /ws/v2/** in the same AuthorizationProviderToken is valid.
And I'm sure security here depends a lot on how Apache Pulsar is managed and if the users use that query param for other requests rather than the WebSocket ones but maybe it could be a security risk in some situations. I'm referencing an OWASP post about this.
Thank you again and sorry for not exposing clearly all my thoughts before!

@acortes-okode Thanks for your explanation about security!

But I think then that the token query param check should only be applied on WebSocket connection URIs (/ws/ and /ws/v2/) and not the rest.

You are right, we should add a filter to check the WebSocket connection URL.

And I'm sure security here depends a lot on how Apache Pulsar is managed and if the users use that query param for other requests rather than the WebSocket ones but maybe it could be a security risk in some situations. I'm referencing an OWASP post about this.

Hi @michaeljmarshall @lhotari, I think you will be interested in this,  could you share your thoughts?

I found many code changes of this PR relies on #14044. @nodece Could you help verify whether could this PR cherry-picked into branch-2.8?

I found many code changes of this PR relies on #14044. @nodece Could you help verify whether could this PR cherry-picked into branch-2.8?

I submitted https://github.com/apache/pulsar/pull/16871 for branch-2.8.

Move the release/2.8.4 label to https://github.com/apache/pulsar/pull/16871

Move release/2.7.5 label to #16892

@nodece I think we don't need to cherry-pick this one to release branches? PR https://github.com/apache/pulsar/pull/14044 only happened on master branch

@nodece I think we don't need to cherry-pick this one to release branches? PR #14044 only happened on the master branch and will release in 2.11.0

#14044 improves the HTTP authentication that adds a new methods to passing the HTTP data, but this issue is still presents in the old version, so we need to cherry-pick to release branches.

Move release/2.10.2  to https://github.com/apache/pulsar/pull/16986.

Move release/2.9.4 label to https://github.com/apache/pulsar/pull/16987.


Revert "Hack to fix missing fields for now"

Reverts AugurProject/augur-node#98

Merge this once we have a new contracts uploaded with canned data applied

Fixed in another PR


Not working with Ubuntu 18.04

Hi,
I tried this script with ubuntu 18.04 and python 3.6.7. This did not work for me. It gave me an empty dict.
$python3
Python 3.6.7 (default, Oct 22 2018, 11:32:17)
[GCC 8.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

import browserhistory as bh
bh.get_browserhistory()

Notification *
Please close Google Chrome completely and invoke the function again,
if you like to see the Chrome browser history.
Other browsers' history would be stored.
{'firefox': []}

You need to completely close your browsers. Can you try again after completely closing your browser windows?


nitunit: import frontend

So the tests can use annotations and other things introduced in compiler phases.
Signed-off-by: Alexandre Terrasa<EMAIL_ADDRESS>

+1

I do not know why but this cause issues with some tests of nitunit http://gresil.org/jenkins/job/CI_github/4751/testReport/

Reroll: the default Toolcontext used by nitunit was not keep_going so the tests stopped at the first error.
Using keep going allows nitunit to spot more compilation errors as can be seen in the update for the test files: https://github.com/nitlang/nit/pull/2283/commits/810dde41aa6df59443b897829a56dabd2215fe3d#diff-07f589fe33d5b380a6fafb464c2b7885R1

+1

So much for a single line of code. :wink:
:shipit: +1


modin pandas read_parquet() failed on ETag KeyError trying to read a partitioned parquet from s3

The source comes from https://stackoverflow.com/questions/68103357/modin-pandas-read-parquet-failed-on-etag-keyerror-trying-to-read-a-partitioned.

@YarShev will you comment there that you opened an issue here and link here so others can follow?

@devin-petersohn, yes, done.


'style' appears to be nonfunctional

How can I configure this library to use new-style {} for formatting?
I note the code appears to have style arguments in appropriate places, e.g. here - but I cannot actually get this working.
Some things I tried:
import logger_tt
logger_tt.setup_logging(full_context=1)
logger_tt.logger.critical("hello {}", "world")
# TypeError: not all arguments converted during string formatting

import logger_tt
logger_tt.setup_logging(full_context=1, style="{")
logger_tt.logger.critical("hello {}", "world")
# ValueError: logger_tt unknown fields: {'style'}

The following are all using this python and different cfg.yamls:
import logger_tt
logger_tt.setup_logging(config_path="cfg.yaml")
logger_tt.logger.critical("hello {}", "world")

Default file, verbatim:
version: 1
disable_existing_loggers: False
formatters:
  simple:
    format: "[%(asctime)s] [%(name)s:%(lineno)d %(levelname)s] %(message)s"
    datefmt: "%Y-%m-%d %H:%M:%S"
  brief:
    format: "[%(asctime)s] %(levelname)s: %(message)s"
    datefmt: "%Y-%m-%d %H:%M:%S"

handlers:
  console:
    class: logging.StreamHandler
    level: INFO
    formatter: brief
    stream: ext://sys.stdout

  error_file_handler:
    class: logging.handlers.TimedRotatingFileHandler
    level: DEBUG
    formatter: simple
    filename: logs/log.txt
    backupCount: 15
    encoding: utf8
    when: midnight

  buffer_stream_handler:
    class: logger_tt.handlers.StreamHandlerWithBuffer
    level: DEBUG
    formatter: brief
    stream: ext://sys.stdout
    buffer_time: 0.5
    buffer_lines: 0
    debug: False

  telegram_handler:
    class: logger_tt.handlers.TelegramHandler
    level: NOTICE
    formatter: brief
    debug: False
    token: "your bot token here or set the below env key to fetch from environ for better security"
    unique_ids: "semicolon separated of [name:]chat_id[@message_thread_id]"
    env_token_key: "TELEGRAM_BOT_LOG_TOKEN"
    env_unique_ids_key: "TELEGRAM_BOT_LOG_DEST"

loggers:
  urllib3:
    level: WARNING
    handlers: [console, error_file_handler]
    propagate: no

root:
  level: DEBUG
  handlers: [console, error_file_handler]

logger_tt:
  suppress: ["exchangelib"]
  suppress_level_below: "WARNING"
  capture_print: False
  strict: False
  guess_level: False
  full_context: 0
  use_multiprocessing: False
  limit_line_length: 1000
  analyze_raise_statement: False
  default_logger_formats:
    normal: ["%(name)s", "%(filename)s"]
    thread: ["%(message)s", "%(threadName)s %(message)s"]
    multiprocess: ["%(message)s", "%(processName)s %(message)s"]
    both: ["%(message)s", "%(processName)s %(threadName)s %(message)s"]

TypeError: not all arguments converted during string formatting

Sure, this makes sense. So let's mark the formatters as style: {:
version: 1
disable_existing_loggers: False
formatters:
  simple:
    style: '{'
    format: "[%(asctime)s] [%(name)s:%(lineno)d %(levelname)s] %(message)s"
    datefmt: "%Y-%m-%d %H:%M:%S"
  brief:
    style: '{'
    format: "[%(asctime)s] %(levelname)s: %(message)s"
    datefmt: "%Y-%m-%d %H:%M:%S"

[...]

([...] in the above is unchanged from the first example)
Traceback (most recent call last):
  File "[...]/logging/config.py", line 544, in configure
    formatters[name] = self.configure_formatter(
  File "[...]/logging/config.py", line 683, in configure_formatter
    result = c(fmt, dfmt, style)
  File "[...]/site-packages/logger_tt/core.py", line 383, in __init__
    self._logger_tt_formatters[case] = logging.Formatter(fmt=fmt, datefmt=datefmt, style=style)
  File "[...]/logging/__init__.py", line 589, in __init__
    self._style.validate()
  File "[...]logging/__init__.py", line 476, in validate
    raise ValueError('invalid format: no fields')
ValueError: invalid format: no fields

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/twotothe/logger_tt_newstyle.py", line 2, in <module>
    logger_tt.setup_logging(config_path="cfg.yaml")
  File "[...]/site-packages/logger_tt/__init__.py", line 217, in setup_logging
    logging.config.dictConfig(config)
  File "[...]/logging/config.py", line 810, in dictConfig
    dictConfigClass(config).configure()
  File "[...]/logging/config.py", line 547, in configure
    raise ValueError('Unable to configure '
ValueError: Unable to configure formatter 'simple'

It's complaining that the formatter has no fields. Sure, it probably needs the format changed too to newstyle. Let's try that:
version: 1
disable_existing_loggers: False
formatters:
  simple:
    style: '{'
    format: "[{asctime}] [{name}:{lineno} {levelname}] {message}"
    datefmt: "%Y-%m-%d %H:%M:%S"
  brief:
    style: '{'
    format: "[{asctime}] {levelname}: {message}"
    datefmt: "%Y-%m-%d %H:%M:%S"

[...]

Traceback (most recent call last):
  File "[...]/logging/config.py", line 544, in configure
    formatters[name] = self.configure_formatter(
  File "[...]/logging/config.py", line 683, in configure_formatter
    result = c(fmt, dfmt, style)
  File "[...]/site-packages/logger_tt/core.py", line 379, in __init__
    super(DefaultFormatter, self).__init__(fmt=fmt, datefmt=datefmt)
  File "[...]/logging/__init__.py", line 589, in __init__
    self._style.validate()
  File "[...]/logging/__init__.py", line 429, in validate
    raise ValueError("Invalid format '%s' for '%s' style" % (self._fmt, self.default_format[0]))
ValueError: Invalid format '[{asctime}] [{name}:{lineno} {levelname}] {message}' for '%' style

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "[...]/logger_tt_newstyle.py", line 2, in <module>
    logger_tt.setup_logging(config_path="cfg.yaml")
  File "[...]/site-packages/logger_tt/__init__.py", line 217, in setup_logging
    logging.config.dictConfig(config)
  File "[...]/logging/config.py", line 810, in dictConfig
    dictConfigClass(config).configure()
  File "[...]/logging/config.py", line 547, in configure
    raise ValueError('Unable to configure '
ValueError: Unable to configure formatter 'simple'

...wait, what? But it just complained a moment ago that %-style formatting didn't work!

Hi @nonnull-ca
Firstly, the problem was indeed the following line:
  File "[...]/site-packages/logger_tt/core.py", line 379, in __init__
    super(DefaultFormatter, self).__init__(fmt=fmt, datefmt=datefmt)

It should have also passed in the style param when calling super.
But this fix is just applied for the format of the formatters as the Python doc says so.
eg. this line: format: "[{asctime}] [{name}:{lineno} {levelname}] {message}"
Secondly, since your target is to be able to use the bracket in the individual log message,
like logger_tt.logger.critical("hello {}", "world"),
this needs more work as it is not supported by the standard logging module.
Thirdly, please note that since logger-tt uses QueueHandler and SocketHandler behind the scene, these handlers will merge the message string and arguments before putting the log record into the queue or sending it. This is just to ensure the log record is pickleable. This behavior will also defeat the purpose of not evaluating the message string if the log record is filtered and only if you have that intention in mind. Anyway, since logger-tt does the logging in a different thread or process, the performance impact is neglectable.
So if you want to use the bracket format in the individual log message, please wait a little more until this function is implemented.


[CLI] Support for passing different types of parameters to entry fun

The types of parameters I expect to be supported are here: #215
For primitive types, it seems that the current CLI can pass parameters like this:
--args @0xae43e34e51db9c833ab50dd9aa8b27106519e5bbfd533737306e7b69ef253647
--args 1u8

But we want entry fun to support some complex types, and we don't know how to pass in parameters via the CLI yet.
The method of sui is to directly support JSON in the cli, like:
sui client call --package _PACKAGE_ID_ --module day_summary_aggregate --function create \
--args u16_year_number \"string_calendar\" u8_month_is_leap u8_day_number \"string_day_time_zone\" \"string_description\" \"vector_u8_meta_data\" '["string_array_data_item1", "string_array_data_item2"]' '["vector_u8_optional_data"]' \"_DAY_SUMMARY_DAY_SUMMARY_ID_TABLE_OBJECT_ID_\" \
--gas-budget 100000

Also, I would like the entry fun's vector type argument to be passed in a string; but conversely, the String type argument is not allowed to be passed in a u8 vector, which I think is acceptable.

I wonder how to pass CLI parameters for an entry fun like the following?
    public entry fun add_foo_table_item(
        storage_ctx: &mut StorageContext,
        object_id: ObjectID,
        key: String,
        val: String,
    ) {
        let obj = something::remove_something(storage_ctx, object_id);
        let update_obj = something_do_logic::add_foo_table_item(storage_ctx, obj, key, val);
        something::add_something(storage_ctx, update_obj);
    }

Also, maybe the types of arguments listed in #215 that require CLI support to be passed in are still necessary in the v0.1 milestone. Otherwise, after v0.1 comes out, it seems harder to write/test a more realistic looking application using the new object model.

Otherwise, after v0.1 comes out, it seems harder to write/test a more realistic looking application using the new object model.

For example, if we use a Table to store multiple OrderItems belonging to an Order, it is quite common to manipulate several OrderItems at the same time, for example, if I want to implement the "XX% discount on N items" function, we may provide multiple OrderItem IDs in the transaction. This ID may be an ObjectID (for example, using the Product ID as the ID of the OrderItem), so it is necessary to pass in vector<ObjectID> from the client.
Of course, passing in a vector<u8> parameter and deserializing it to a vector<ObjectID> is a way to "get around" this problem, but it's a bit tricky.
@pause125 @baichuan3

https://docs.sui.io/build/sui-json

I will work on this. I am going using the Aptos-style CLI types.


ERROR from sink_sub_bin_sink2: Could not initialize supporting library.

Hello, when I run the program, the error is reported as follows, it seems that a certain library is not imported. Please help me. My configuration environment is: deepstream5.1
jetson nx
`mec@mec-desktop:/opt/nvidia/deepstream/deepstream-5.1/sources/apps/sample_apps/deepstream-occupancy-analytics-master$ ./deepstream-test5-analytics -c config/test5_config_file_src_infer_tlt.txt
(deepstream-test5-analytics:10968): GLib-CRITICAL **: 19:47:45.962: g_strchug: assertion 'string != NULL' failed
(deepstream-test5-analytics:10968): GLib-CRITICAL **: 19:47:45.963: g_strchomp: assertion 'string != NULL' failed
** WARN: <create_pipeline:1141>: Num of Tiles less than number of sources, readjusting to 2 rows, 1 columns
Warning: 'input-dims' parameter has been deprecated. Use 'infer-dims' instead.
** ERROR: main:1088: Failed to set pipeline to PAUSED
Quitting
ERROR from sink_sub_bin_sink2: Could not initialize supporting library.
Debug info: /dvs/git/dirty/git-master_linux/deepstream/sdk/src/gst-plugins/gst-nvmsgbroker/gstnvmsgbroker.c(359): legacy_gst_nvmsgbroker_start (): /GstPipeline:pipeline/GstBin:sink_sub_bin2/GstNvMsgBroker:sink_sub_bin_sink2:
unable to open shared library
ERROR from sink_sub_bin_sink2: GStreamer error: state change failed and some element failed to post a proper error message with the reason for the failure.
Debug info: gstbasesink.c(5265): gst_base_sink_change_state (): /GstPipeline:pipeline/GstBin:sink_sub_bin2/GstNvMsgBroker:sink_sub_bin_sink2:
Failed to start
App run failed
`

Hi,
is the kafka running on your server?

Thanks, I turned off Kafka.


nub-stickpad

we already have something called <nub-stick>.
but there's actually a better kind of thumbstick, that is more user-friendly
the idea is that we have a "thumbstick area", and when the user presses down, the thumbstick actually appears, centered on the position where the touch action starts (pointerdown event).
if you watch some videos of high quality mobile games that involve thumbstick action, you'll usually find this kind of dynamic thumbstick.
this should be implemented as a new element, called something different, like <nub-spawnstick>, or come up with a different name (i don't know what the mechanic is actually called).
the more traditional <nub-stick> will remain available.

ooh, how about the name "stickpad" instead?

done


feat: new cosmos keyring helper for injective client

Hi, a little backstory here. Original Cosmos keyring helper was created for Peggo CLI service. It was very cool and really useful, so once we wanted to use the same approach in other apps as well (oracles, etc), we also copied the piece into sdk-go and it sat there for a couple of years.
The fact is that it was never properly tested (unit tests for all branches), it never had interface of possible errors for all failing conditions and it also had a couple of other bugs. In general, the problem with that keyring design was that if the app wants to have 2+ keys loaded at the start time, you can't add them the same way, only using multiple keyrings. Which is not cool.
Last 2 years I was actually reusing the same keyring drop-in function, but during the last year decided to sit down and refactor it, cover with tests and changed the design a bit.
So here is the new version of that keyring helper. I think this PR can be merged as-is once approved, but it will take some time to migrate dependant apps to the new keyring implementation. The latter is not urgent nor necessary. Given that peggo config is very mission critical, I'd advise not change anything in its refactored code.
Feel free to check it out and see the client/keyring/README.md for more details.

Summary by CodeRabbit

New Features

Introduced comprehensive documentation for the "Injective Chain Keyring Helper," detailing keyring creation and management for the Cosmos SDK.
Implemented a keyring management system that supports various key types and configurations, enhancing secure blockchain interactions.
Added validation for key configurations, ensuring compatibility and security during keyring operations.

Bug Fixes

Enhanced error handling for keyring operations, providing clearer messages for various failure scenarios.

Tests

Added a suite of unit tests for the keyring functionality, validating error handling and key management processes.

Chores

Updated project dependencies to include new libraries for improved functionality.
Refined pre-commit configuration to exclude test data directories from checks.
Enhanced GitHub Actions workflow for secure handling of sensitive data during testing.

Hello @maxim-inj. I will start reviewing the PR. In the meantime, could you please do the following?

Point the PR to the dev branch. Unless we are working on a urgent fix, all PRs should be created pointing to dev
Make sure that both the pre-commit and run-tests workflows pass in green

Unless we are working on a urgent fix, all PRs should be created pointing to dev

Oh didn't know, indeed. Rebased, will wait for CI to pass.

Once the PR is merged we should create a task to migrate all repo examples to use the new keyring, and also to mark the old keyring creation logic as deprecated.

Yeah this will be an ongoning process with low priority.

@maxim-inj still waiting for you to resolve all issues in the validation workflows before approving the PR

@aarmoa alright it's good to go!


CSS file imported from JS is not minified

Describe the bug
When importing a CSS file from a JS file, we get unminifed text contents back:
Reproduction

Create a new app with npm init vite-app my-app

Edit src/main.js to have a binding for the CSS import:
 import { createApp } from 'vue'
 import App from './App.vue'
-import './index.css'
+import styles from './index.css'
+
+console.log(styles);

 createApp(App).mount('#app')

Run vite build

Take a look at dist/_assets/index*.js and search for #app

You will see that the console.log that prints the CSS contains the unminifed CSS. You can compare it to dist/_assets/style*.css

System Info

required vite version: 1.0.0-rc.13
required Operating System: MacOS Mojave
required Node version: v12.20.0
Optional:

npm/yarn version
Installed vue version (from yarn.lock or package-lock.json)
Installed @vue/compiler-sfc version

Patching it
Calling minifyCSS will fix it:
diff --git a/node_modules/vite/dist/node/build/buildPluginCss.js b/node_modules/vite/dist/node/build/buildPluginCss.js
index 3f8b2e5..6836998 100644
--- a/node_modules/vite/dist/node/build/buildPluginCss.js
+++ b/node_modules/vite/dist/node/build/buildPluginCss.js
@@ -82,7 +82,7 @@ const createBuildCssPlugin = ({ root, publicBase, assetsDir, minify = false, inl
                                 // module in the chunk's metadata so that we can retrieve them in
                                 // renderChunk.
                                 `${cssInjectionMarker}()\n`
-                            : ``) + `export default ${JSON.stringify(css)}`,
+                            : ``) + `export default ${JSON.stringify(minifyCSS(css))}`,
                     map: null,
                     // #795 css always has side effect
                     moduleSideEffects: true

Would you accept a PR that does it?
Thanks for a lovely product! 😃

This already fixed at 2.0.Please upgrade vite and see new docs https://vitejs.dev/guide/migration.html.

This already fixed at 2.0.Please upgrade vite and see new docs https://vitejs.dev/guide/migration.html.


Getting  "Error: ENOENT: no such file or directory" in path : azure/msal-react/src/packageMetadata.ts

Core Library
MSAL.js (@azure/msal-browser)
Core Library Version
3.0.2
Wrapper Library
MSAL React (@azure/msal-react)
Wrapper Library Version
2.0.2
Public or Confidential Client?
Public
Description
e.g. package.json
...
devDependencies: {
   "react-scripts": "5.0.1"
},
 scripts: {
  "start": "react-scripts start"
 }
...
...

I am getting this message because I don't have path 'src/' when running npm start

MSAL Configuration
No response
Relevant Code Snippets
No response
Identity Provider
Other
Source
External (Customer)

Hey @luan-dang-techlabs, are you seeing this error on install/build? Can you double check our guidance on package installation?

Hey @luan-dang-techlabs, are you seeing this error on install/build? Can you double check our guidance on package installation?

I get this error when I start my local server like this:
 package.json

{
...
 scripts: {
  "start": "react-scripts start"
 }
...

when i start my local server like this:

 $ npm start

Did you try building the packages locally before running the app? Maybe try npm run build:package like here.

Did you try building the packages locally before running the app? Maybe try npm run build:package like here.

I didn't, let give that a try.

Did you try building the packages locally before running the app? Maybe try npm run build:package like here.

I didn't, let give that a try.

Even though I had those message, authenticating is working and local server works fine. The issue lies with Failed to parse source map from  message showing up. Did something change with the way 'source-map' was created ?

Hey @luan-dang-techlabs , this is a bug on our side and I will work on putting a fix out for it. Thanks!

Addressed in #6398 and will be included in our next release

Hey @luan-dang-techlabs , this is a bug on our side and I will work on putting a fix out for it. Thanks!

Sorry to bother but may i ask when you plan on releasing the fix for this?


Interrupt on windows! 😯

YES!!!
It turns out that the magic trick was:

https://learn.microsoft.com/en-us/windows/console/generateconsolectrlevent to send a Ctrl+C event to the process (this is not the same as a SIGINT signal on Windows). We can call this with ccall.
To allow the process to handle the Ctrl+C event (and not its host, ie the Malt host), the process should be launched in detached mode. Distributed also does this.

It's working!! My new interrupt tests are only passing on Windows, because now Malt has better interrupt support on Windows than the other platforms 😅

It's working! Just tweaking the tests now...


Fix exponential delay behavior

Fixes https://github.com/Azure/azure-sdk-for-net/issues/40866 to prevent overflowing the int32 passed into Random.Next.
Additionally, fixes a bug in the exponential delay behavior so that the delays are not double what they should be.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Core


Add env to conditionals

Adds build.env() to the supported variables list on the Conditionals page. I've also alphabetised the table so it's easier to find things.
@keithpitt could I please get your help with an example? Also, is the description correct? 😄

build.env() is a function. An example would be build.env("CUSTOM_ENVIRONMENT_VARIABLE")
Maybe the description is like "This function returns the value of the environment passed into it's first argument. If environment variable has not been set, it'll return an empty string"
Hrm...I wonder if it'd be better if build.env returned null if the environment variable doesn't exist? That way you'd be able to tell the difference between an ENV var that's empty "" and an env var that's not been set null

@harrietgrace I decided that build.env should return null if there's no env with it set. That way folks can tell the difference between an empty ENV, and one that hasn't been set.

@keithpitt awesome, thanks! I've updated the description and edited it a bit. Do you have a real-life-ish example env var and value we could put in? I've just put in filler text into the example for now.
The new vars are also in there now with draft descriptions 👍🏻

Added an extra example with @matthewd's help! Merging this so I can get it in with the Step Deps PR 👍🏻