When #Ceil failure occurs make this obvious in the configuration

Right now, #Ceil failure occurs for a term that has #Ceil rule, stuck configuration won't display any #Ceil terms, making diagnosis not trivial.
For example, if we have this #Ceil rule in KEVM:
rule #Ceil(#buf(SIZE, DATA)) => {(0 <=Int SIZE) andBool #rangeBytes(SIZE, DATA) #Equals true}  [anywhere, simplification]

Stuck configuration looks like:
  #Not ( {
      true
    #Equals
      0 <=Int ?ACCT0
    }
  #And
    {
      true
    #Equals
      ?ACCT0 <=Int<PHONE_NUMBER>37316195423570985008687907853269984665640564039457584007913129639935
    } )
#And
  <kevm-specs>
    <kevm>
      <k>
        #assume notBool ?ACCT0 ==Int ?ACCT ~> #loadERC20Bytecode ?ACCT0 ~> 1 ~> #push ~> #setLocalMem 128 32 #buf ( 32 , ?ACCT0 ) ...
      </k>

The #Not term at the top is the result of #Ceil(#buf) application.
Expected: It would be good to add another term to the top of configuration that makes situation obvious, like #Failure(#Ceil(#buf(...))).
Similarly should be displayed failure of Set concatenation, which in fact has a hidden #Ceil rule.

I don't think this will be needed now that #1665 is fixed.

Not sure what you mean. That there won't be any issues with #Ceil to debug? I tend to disagree. This is a debugging improvement that will be needed whenever we will have to debug #Ceil rules, which clearly is an important part of proof writing in Haskell backend. This will be very important to reduce entrance barrier for newcomers, but will be useful for everybody.

Can you give another example? The proof in the original report is "stuck" due to a backend bug. In my opinion, there is nothing for the user to debug there. I don't think it can be fixed by adding lemmas or side conditions, but it should be reported so that we can fix the bug.

I got the configuration above on recent, properly working Haskell backend. It happened because #buf term was created before the range restrictions that would help solve #Ceil(#buf). The solution was to reorder some logic in symbolic tester, to ensure range restrictions are always created before the #buf that needs them.
This is a situation that might easily occur in future for other semantics. We need efficient ways to debug it.

Unless I'm completely misreading it, that configuration has the following form:
#Not ( #Ceil ( #buf(...) ) ) #And ... #buf(...) ...

That's #False, and if the backend reports it as a stuck configuration, that's a bug in the backend.

Then please explain how this #Ceil magic works, preferably in a wiki page. I understand the following:
When a non-functional function term foo() is encountered, configuration is split into 2 branches, one with #Ceil(foo) another with notBool #Ceil(foo). Rule #Ceil(foo) helps evaluating both sides. The first branch has to evaluate to bottom with the help of path condition and lemmas. If it fails to evaluate to Bottom, we'll get stuck terms like above, with no direct clue that it originated from a failing #Ceil. Please correct me where I'm wrong.

This is what happens: Unifying a variable X with a term foo() introduces a condition #Ceil( foo() ). If this happens when unifying the left-hand side of a rule with the configuration, then #Ceil( foo() ) becomes a requirement to apply the rule. This requirement is where the backend splits the configuration:

#Ceil( foo() ) holds, and the rule applies.
#Not #Ceil( foo() ) holds, and the rule does not apply.

Usually, the #Not #Ceil( foo() ) case needs to be refuted, or the proof becomes stuck (no rules apply) as in #1665. To fix that issue, we realized that for any term T, the formula T = T #And #Ceil(T) is valid in Matching Logic. The backend now applies that identity to the left-hand side of the claim when checking the final implication, introducing #Ceil(left-hand side) into the side condition at the top level. When foo() appears in the left-hand term, the #Ceil(left-hand side) will contradict the #Not #Ceil( foo() ) so that the claim is shown to hold by the principle ex falso quodlibet. After fixing #1665, there is practically no reason for a #Not #Ceil condition to appear in a stuck configuration, and I would go so far as to say that it is a bug in the backend if such condition appears.
Note about efficiency: we re-evaluate #Ceil(left-hand side) every time we check the final implication. The optimization we are undertaking for #1911 is to apply the identity at the start of each proof step, instead of during the final implication check. At each step, we will only need to evaluate the #Ceil of any new partial sub-terms of the left-hand side. This means that we will generally evaluate a #Ceil( #buf(...) ) the first time the #buf(...) appears, and then never evaluate the condition again. As a side effect, the #Not #Ceil branch of most (maybe all?) rules won't be created in the first place.

Thanks for detailed explanation. What I digested:

If every time #Not #Ceil(foo()) is introduced, you practically add #And #Ceil(foo()) to it, which turns everything to Bottom. Then what's the point of creating #Not #Ceil(foo()) branch in the first place?
#Ceil(foo()) is added only when foo() is unified with a variable, e.g. when a variable from a rule matches X. Not at the moment foo() is added, unconditionally. Then in my example above it is too early for #Ceil to be introduced, because the rule for #assume doesn't unify with parts of configuration that contain #buf. So it appears to be a bug indeed.
From your explanation for #1911 it appears that #Ceil(foo()) will work pretty much as I explained 2 posts above ("This means that we will generally evaluate a #Ceil( #buf(...) ) the first time the #buf(...) appears"). Then situation discussed here remains a possibility.

Then what's the point of creating #Not #Ceil(foo()) branch in the first place?

The #Ceil becomes part of the rule's requires clause. It's implicit in the way the rule is written. The #Not #Ceil comes from negating the requires to calculate the remainder of the original configuration after the rule is applied.

the rule for #assume doesn't unify with parts of configuration that contain #buf.

Every rewrite rule unifies with the entire configuration at every step of the proof. Any part that is not explicitly mentioned in the rule is filled in with generated variables by the frontend. Therefore, the following statement is not correct:

in my example above it is too early for #Ceil to be introduced

In fact, the #Ceil are introduced at every step from the time that #buf enters the configuration.

Then situation discussed here remains a possibility.

I don't think so. In fact, you should be able to remove the #Ceil(#buf) rule from the semantics entirely without affecting the proof if the range of Int variables is already established in the claim's requires. It should not be possible anymore for a #Ceil condition to cause a proof to get stuck. At least, not for any #Ceil term created by unification. I would need to see an example that isn't a backend bug in order to understand what we should display here.

Regarding this concrete issue, this assumption is false:

the range of Int variables is already established in the claim's requires

In this example range was established after creation of #buf. The range was not established in the initial proof rule (or claim, whatever), but in the ensures of a definition rule, which was executed after #buf. So I had to refactor the semantics to establish the range simultaneously with #buf. Similar situations may happen for other reasons: bugs in semantics or (very likely) missing lemma for #Ceil content.

It is clear now that understanding #Ceil logic is non-trivial and important for a kprove user. From your explanation many things are still not clear. So instead of bombarding you with questions, please take some time to write a wiki page about #Ceil purpose and implementation in the backend. ERC20 project is virtually finished, but for a new project, clearly understanding what the backend is doing is probably more important than fixing non-blocking workable-around bugs.

The range was not established in the initial proof rule (or claim, whatever), but in the ensures of a definition rule, which was executed after #buf.

The range was actually set at the moment that #buf entered the configuration, but there was a bug in the backend where that was not recognized (#1665). Since the range of variables seems to only be set in order to satisfy the #Ceil(#buf) rule, I still think this rule could now be removed.
I added a page to the wiki based in part on our discussion, but I can't think of much to say about it that I haven't already. At one time, we thought it was going to be important for users to write #Ceil rules for their semantics, but that was really a workaround for a bug in the backend. I don't think it should be common to write #Ceil rules. The only reason I can think of to have them, is if the user wants the backend to infer something else (unrelated to #Ceil) from the presence of a term in the configuration.

I don't understand what you are talking about. Please be more specific about what you are assuming, on what semantics/branch etc. You are probably talking about what happens in the corrected erc20-verification branch symb-test-kevm-master or some older branch you've seen last time. This issue discusses a situation that happened in an earlier commit. There range was not set the moment #buf entered the configuration.

Thanks for opening the wiki page. A few points are worth clarifying.
(a) What is the purpose of #Ceil rules? I understand to specify when partial functions are defined. If a regular rule introduces a partial function, it can only apply when definedness conditions for that function are satisfied.
(b). I understand that #Ceil is introduced not only when X unifies with foo, but also when it unifies with a term containing foo. If this follows from some recursive evaluation of #Ceil then evaluation algorithm should be explained. It is not obvious. What happens when term is functional or is a constructor, of if it doesn't have #Ceil rules? Also please make it explicit when it happens: at every step of execution, in the process of rule matching.
(c) What happens if foo is created by equation rule bar(X) => foo(X) ? Is there still any variable unifying with foo here?
(d) I guess final implication happens at the end of a step, after the rule was applied.
(e)

This case can often be refuted by applying the formula T = T #And #Ceil(T) to the configuration.
If T only exists as part of the #Not #Ceil( T ), this looks unsound. Please clarify the often above.

Just double-checked that the commit which produced discussed issue used Haskell backend with #1665 fix.

Please be more specific about what you are assuming, on what semantics/branch etc. You are probably talking about what happens in the corrected erc20-verification branch symb-test-kevm-master or some older branch you've seen last time. This issue discusses a situation that happened in an earlier commit. There range was not set the moment #buf entered the configuration.

I am not making any assumptions about the semantics, or assumptions about any particular branch. I am only talking about Matching Logic. These are valid statements in Matching Logic:
(1)    φ = φ #And #Ceil( φ )  // φ is any pattern
(2)    #Ceil( σ(φ₁, φ₂, ...) ) #Implies #Ceil( φ₁ ) #And #Ceil( φ₂ ) #And ...  // σ is any symbol, φᵢ are any patterns

Let the left-hand side of the proof claim be config #And side-condition where config is just the "cells". Statement (1) above allows us to elaborate,
config #And side-condition = config #And #Ceil( config ) #And side-condition

This is strictly equality, we are just being explicit about the content of the claim. Statement (2) above allows us to elaborate further: For any term tᵢ appearing in any (sub-)cell of config, we can add #Ceil( tᵢ ) to the left-hand side of the claim (because cells are symbols in Kore):
config #And #Ceil( config ) #And side-condition =
    config #And #Ceil( config ) #And #Ceil( t₁ ) #And #Ceil( t₂ ) #And ... #And side-condition

As a concrete example, whenever #buf(...) appears inside some cell in the configuration, its defined-ness condition #Ceil( #buf(...) ) is implicitly part of the left-hand side of the claim. That's what I mean by this:

The range was actually set at the moment that #buf entered the configuration

The bug in #1665 is that the backend did not exploit this fact. The solution was to make these implicit conditions into explicit conditions.
I think this also clarifies your point here:

If T only exists as part of the #Not #Ceil( T ), this looks unsound. Please clarify the often above.

T is the top-cell, but by statement (2) above it is also extended to the contents of any sub-cell.

The error here is actually a manifestation of #2021. The proof is not actually stuck, but due to a book-keeping error, the backend reports it as a stuck state. Actually, this state was proven as expected.


Sometimes { in insert mode triggers normal mode

Steps to reproduce
From insert mode, sometimes { is interpreted as `^[``, thus triggering normal mode.
Expected behaviour
From insert mode, { should insert {, always.
Version of Vim
9.1.0764
Environment
Linux
Logs and stack traces
No response

Well that doesn't give much details. What keyboard layout? Is this terminal or GUI? what happens if you type in insert mode <C-S-V>{? does it happen with vim --clean?

Well that doesn't give much details. What keyboard layout? Is this terminal or GUI? what happens if you type in insert mode <C-S-V>{? does it happen with vim --clean?

It happens also with vim --clean
In vim (no GUI), with <C-S-V>{ it pasts the content of what I had in the clipboard and inserts }.
In insert mode, <C-v>{ sometimes inserts }, sometimes it shows ^[.
Keyboard layout screenshot:


No support for Apple Silicon?

What device are you using? It should work on Apple Silicon (I use an M1). You'll need Chrome 113 or above for WebGPU support. It is not supported on iOS yet.


edit metadata for dtc

Dataset Description
Drug Target Commons (DTC) is a crowd-sourcing platform to improve the consensus and use of drug-target interactions. The end users can search, view and download bioactivity data using various compound, target and publications identifiers. Expert users may also submit suggestions to edit and upload new bioactivity data, as well as participate in the assay annotation and data curation processes.
Task Description
Regression. Given the target amino acid sequence/compound SMILES string, predict their binding affinity.
Dataset Statistics
(# of DTI pairs, # of drugs, # of proteins) 54,339/42,307/580 for EC50, 22,227/7,867/978 for Kd, 406,422/279,566/1,937 for IC50, 240,895/112,376/1,197 for Ki.
Dataset Split
Random Split Cold Drug Split Cold Protein Split
Note: Drug Target Commons is the collection of many assays. Since different assays use different metrics, TDC separates them as separate datasets. Specifically, it has four datasets with Kd, IC50, Ki, EC50 as the units. All units are in NM.
Tips: Transforming to log-scale pIC50, pKi, and pKd can usually lead to more stable training. You can achieve this transformation via here. Checkout the data processing page for binarization, label distribution visualization, edge list/DGL/PyTorch graph transformation.
from tdc.multi_pred import DTI
data = DTI(name = 'dtc_kd')
# data = DTI(name = 'dtc_ki')
# data = DTI(name = 'dtc_ic50')
# data = DTI(name = 'dtc_ec50')
split = data.get_split()

Note: Many DTI pairs have the same sequence information but different binding affinities due to different experimental assays. To harmonize them, you can use the below function to retrieve either the maximum affinity or the mean for the duplicated pair:
from tdc.multi_pred import DTI
data = DTI(name = 'dtc_kd')

Closing for now, let us know if you still plan to include it / DTC has cleared the license issue.


Fix and document release process

The release process currently depends on a deprecated component and is not documented anywhere. Let's migrate to the current deployment instructions and document the release process within the project repository for Philadelphia 2.0.0.

Closed by #316.


Alert health check

Description
Use new TF modules that automatically creates health check alerts configured to send alerts to MS Teams.
References
https://app.zenhub.com/workspaces/mighty-ducks---the-outlaws-6193fe815d79fc0011e741b1/issues/energinet-datahub/the-outlaws/232

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[FEATURE] milvus

功能描述 / Feature Description
目前milvus版本是v2.1.3， 现在都v2.3.* ,   我尝试升级，但是代码会报错
INFO:     <IP_ADDRESS>:59276 - "POST /knowledge_base/create_knowledge_base HTTP/1.0" 500 Internal Server Error
ERROR:    Exception in ASGI application
Traceback (most recent call last):
File "/root/anaconda3/envs/langchain-chatchat/lib/python3.10/site-packages/uvicorn/protocols/http/h11_impl.py", line 408, in run_asgi
result = await app(  # type: ignore[func-returns-value]
File "/root/anaconda3/envs/langchain-chatchat/lib/python3.10/site-packages/uvicorn/middleware/proxy_headers.py", line 84, in call
return await self.app(scope, receive, send)
File "/root/anaconda3/envs/langchain-chatchat/lib/python3.10/site-packages/fastapi/applications.py", line 292, in call
await super().call(scope, receive, send)
File "/root/anaconda3/envs/langchain-chatchat/lib/python3.10/site-packages/starlette/applications.py", line 122, in call
await self.middleware_stack(scope, receive, send)
File "/root/anaconda3/envs/langchain-chatchat/lib/python3.10/site-packages/starlette/middleware/errors.py", line 184, in call
raise exc
File "/root/anaconda3/envs/langchain-chatchat/lib/python3.10/site-packages/starlette/middleware/errors.py", line 162, in call
await self.app(scope, receive, _send)
File "/root/anaconda3/envs/langchain-chatchat/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 79, in call
raise exc
File "/root/anaconda3/envs/langchain-chatchat/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 68, in call
await self.app(scope, receive, sender)
File "/root/anaconda3/envs/langchain-chatchat/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 20, in call
raise e
File "/root/anaconda3/envs/langchain-chatchat/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 17, in call
await self.app(scope, receive, send)
File "/root/anaconda3/envs/langchain-chatchat/lib/python3.10/site-packages/starlette/routing.py", line 718, in call
await route.handle(scope, receive, send)
File "/root/anaconda3/envs/langchain-chatchat/lib/python3.10/site-packages/starlette/routing.py", line 276, in handle
await self.app(scope, receive, send)
File "/root/anaconda3/envs/langchain-chatchat/lib/python3.10/site-packages/starlette/routing.py", line 66, in app
response = await func(request)
File "/root/anaconda3/envs/langchain-chatchat/lib/python3.10/site-packages/fastapi/routing.py", line 273, in app
raw_response = await run_endpoint_function(
File "/root/anaconda3/envs/langchain-chatchat/lib/python3.10/site-packages/fastapi/routing.py", line 192, in run_endpoint_function
return await run_in_threadpool(dependant.call, **values)
File "/root/anaconda3/envs/langchain-chatchat/lib/python3.10/site-packages/starlette/concurrency.py", line 41, in run_in_threadpool
return await anyio.to_thread.run_sync(func, *args)
File "/root/anaconda3/envs/langchain-chatchat/lib/python3.10/site-packages/anyio/to_thread.py", line 33, in run_sync
return await get_asynclib().run_sync_in_worker_thread(
File "/root/anaconda3/envs/langchain-chatchat/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 877, in run_sync_in_worker_thread
return await future
File "/root/anaconda3/envs/langchain-chatchat/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 807, in run
result = context.run(func, *args)
File "/home/local/Langchain-Chatchat/server/knowledge_base/kb_api.py", line 29, in create_kb
kb = KBServiceFactory.get_service(knowledge_base_name, vector_store_type, embed_model)
File "/home/local/Langchain-Chatchat/server/knowledge_base/kb_service/base.py", line 237, in get_service
vector_store_type = getattr(SupportedVSType, vector_store_type.upper())
AttributeError: type object 'SupportedVSType' has no attribute 'MILIVUS'

milvus lite还是可以升级到2.2.4，升级不了2.3.0及以上，不知道为啥，


Make a bug report template

Made a bug report template for easier handling of bugs

thanks

nice work @akionsight

A small change in that, could be done, to produce this:
custom.md Issue Tempalte


PasswordAlias object not getting created

Hi Team
With the current code PasswordAlias object is not getting created in DataPower. I just modified code in  SOMA.java class and recreated jar in my local and then it is started working. The new code is as below. Please include it in next release.
/**

This method implements the AddPasswordMap operation.

The params must contain:

domain= ... some domain name ...
aliasname= ... passwordAlias object name to show to the world ...
type= ... real, secret password ... Not needed anymore
password= ... actual password ...
The params may contain:

ignore-errors=on or off

@param params
@return NamedParams "rawresponse".
@throws Exception
*/
public NamedParams doAddPasswordMap (NamedParams params) throws Exception {
params.insistOn (new String[] {"domain", "aliasname", "password"});

// Make the request of the XML Management Interface.
StringBuffer body = new StringBuffer ();
body.append("<AddPasswordMap>");
body.append("<AliasName>" + params.get("aliasname") + "</AliasName>");
body.append("<Password>" + params.get("password") + "</Password>");
body.append("</AddPasswordMap>");

String request = SomaUtils.getDoActionEnvelope (params.get("domain"), body.toString());
NamedParams result = params;
if (errorsAreSignificant(params)) {
  result = conn.sendAndReceive (params, request);
  insistSomaResultIsOkay(result);
} else {
  // Do the operation, ignoring the response and any exceptions.
  try {
    result = conn.sendAndReceive (params, request);
  } catch (Exception e) {
  }
}

return result;

}

Hi,
Could you please create a pull request with this new code?
Thanks!

New PR #75
All questions and comments should be resolved there.


Merge with upstream

Mainly want to include all the VLM changes!

Great!! Thanks for merging upstream changes!

Great!! 👍 Thanks for merging upstream VLM changes!


feat: disable download for instagram lightbox views

Disables the download button for Instagram since it's not really meant for that.

The deploy preview looks good. I'm going to merge this.


DepthAI Viewer doesn't work with Jetson nano

As reported in the depthai repository: https://github.com/luxonis/depthai/issues/1089

Thanks @jakaskerl - note that the wheels are now available on the github release page too:
https://github.com/luxonis/depthai-viewer/releases/tag/v0.1.6
(
depthai_viewer-0.1.6-cp38-abi3-manylinux_2_31_aarch64.whl )

Thanks @jakaskerl - note that the wheels are now available on the github release page too:
https://github.com/luxonis/depthai-viewer/releases/tag/v0.1.6
(
depthai_viewer-0.1.6-cp38-abi3-manylinux_2_31_aarch64.whl )


refactor(parser): make parser return Lrc

https://github.com/rolldown/rolldown/pull/1364#issuecomment-2161005292

https://github.com/oxc-project/oxc/pull/3638


feat/support_promise

Added support for Promise.    This will give us a better performance by not using synchronous methods and also allows us to support the Google Chrome debugger.
This is a list of the APIs where the signature has been updated.   The deprecated methods are replaced with new ones and removed.   Upgrading should be straightforward.

isInitialized
initialize
isTablet
getConsentDialogState
hasUserConsent
isAgeRestrictedUser
isDoNotSell
isMuted
getAdaptiveBannerHeightForWidth
isInterstitialReady
isRewardedAdReady
isAppOpenAdReady

Also, removed the headspace from CHANGE.md to show it correctly.

Updated to support 'auto' for sizing AdView.

Forgot to update showConsentDialog() from callback to Promise.

Also merge conflicts


Jellyfish emoji

Not all types of Jellyfish sting, but they are all looking unique with their semi-transparent bodies and tentacle-like extremities.
Petitions

Emoji Request

Candidate for 2022 Emoji 15.0
https://emojipedia.org/jellyfish/


Add acceptance tests

Feature description
Add acceptance tests

Yalantis is working on this ! Check on this @uchennakevinm1


Large portions of the window not repainting on high DPI/resolution displays

Issue Type: Bug
When VS Code sits open for a while, say in the background or after an unmeasured time of just sitting around, large portions of the window appear to not repaint. This also occurs with more "complicated" views, such as the terminal or git diff views, upon scrolling. This causes an insane amount of flickering, and in git diff views it's almost impossible to use as large portions of the screen don't repaint upon scrolling.
This does not occur in other Electron apps, such as Discord or GPMDP, nor does it appear in Chromium or Chrome (not that I suppose that matters).
I know this is a bit of a duplicate of old issues, as I've seen issues like #12473 before, but all of those have been marked as resolved. I don't know if it's my system specifically or what, but none of the fixes in any of these issues seem to work; not even --disable-gpu, --force-gpu-rasterization, window.zoomLevel: 0, or any of the other tricks have had any effect.
I don't see it mentioned in the system info, so I suppose I should also note that I'm running on an AMD RX 480 with mesa and the AMDGPU open source drivers, on KDE X11.
Screenshots
(Both of these are more related to the git diff issue, but I don't have a good way to record nor reproduce the time-based flickering issue yet.)

Launched with --disable-extensions.  Notice how a lot of the code is missing, and the terminal has a very large section of gray.

Yet another screenshot, this one with more pronounced differences. Interestingly, scrolling around in the git diff view seems to partially fix the terminal, and vice versa, even though the panel being scrolled becomes more broken.

 Both --disable-gpu and --disable-gpu-rasterization had no effect. Extensions were disabled while testing.

I feel like this has something to do with higher DPI displays. I've noticed that running Code in a smaller window seems to lessen if not eliminate the effect (but it also makes it much less usable).
For reference, this is a 4k display with 1.7 DPI scaling in KDE. But, again, other Electron applications running at the same resolution are unaffected (Discord used to be, but that was months ago; perhaps it's some sort of regression?).
My apologies for not mentioning this earlier. It hadn't really crossed my mind.

I have the same issue, running ubuntu 16.04 on a 4k monitor with an AMD graphics card (AMD OLAND (DRM 2.43.0 / 4.4.0-116-generic, LLVM 5.0.0)).
It seems to have worsened since the terminal splitting feature (which is so awesome to use on my windows laptop, but unusable on my ubuntu setup). The git diff spilt view has been causing flickering and blank rectangles for some time but I got by without using it. Now, however, the flickering is happening even when there's no screen splitting enabled.
I've also tried running code with  --disable-gpu and --force-gpu-rasterization. This seems to improve the git split screen a little but certainly doesn't fix the problem, and the terminal splitting remains unusable.
Similar to @BytewaveMLP, if I reduce the window size, the problem is alleviated somewhat, but that does defeat the purpose of my shiny 4k monitor!

notice big white, grey and dark grey rectangles over the side panel and terminal windows in the example above. But it happens all over the screen, usually triggered by scrolling. Often there's flickering but it's when they don't go away and the code is obscured, that the app becomes unusable

I've experienced the issue on Windows 10, laptop has a native WQHD 1440p screen, set to 150% scaling, but mostly use a larger monitor at 100% scaling. I also get strange painting issues with terminals, and text sometimes disappears altogether until I type some commands, or the position of the current active line gets moved INTO the existing displayed console output.

This might workaround the problem:
code --ignore-gpu-blacklist

@tyriar how do you set code to always launch with a command?

@mix3d did it work? On Windows I think you could create a shortcut and modify it, or launch from a batch script.

Yup, it seems like --ignore-gpu-blacklist fixes it @Tyriar; however, it's annoying to have to edit all my .desktop files to support this. Fortunately, KDE makes that easy, but it's kinda difficult to set $EDITOR with flags (Code doesn't seem to like the filename being passed after command line arguments, but perhaps that's another bug to report).

Sounds like a good opportunity to open that value as an editor config? Or is that too far into the app loading process?

It could at least be a prelaunch thing. On Arch, the Google Chrome package "binary" actually Chrome from a shell script that reads a file ~/.config/chrome-flags.conf and uses its contents as command line arguments to pass to the actual Chrome instance. Something like that could be used here.

@BytewaveMLP great, we have a root cause! This is happening because Chromium maintains a list of GPUs to disable as they have issues, unfortunately in VS Code this manifests itself as corrupted textures inside the canvas for some reason.
I'm curious if the same thing happens when you run Google Chrome?

Sounds like a good opportunity to open that value as an editor config? Or is that too far into the app loading process?

@mix3d I think it's too far, we don't touch the settings file until the Electron main process is launched.

@Tyriar It's hard to say. Chrome doesn't have any flickering issues when the ignore-gpu-blacklist flag is disabled, but it does seem considerably less performant, and changing views (e.g. switching tabs) does seem to cause a sort of "wiping" effect much like VS Code was exhibiting. Discord, another Electron app, used to have a similar problem to the one noted in this issue, but it would only appear at certain startups and could be fixed after a client or system restart; it was never reliable reproducible, and was fixed a while ago )likely ignoring the blacklist themselves). GPMDP, however, does have a slight flickering and poor performance problem, which does seem related.

@BytewaveMLP oh it should only show up when you're using a canvas though. To test this out you could run the xterm.js demo (which is what the terminal is built on) as that's a canvas that's doing a lot of painting. Try tweaking the rows/cols in the textbox below and running some commands. https://github.com/xtermjs/xterm.js#linux-or-macos

Er... whoops. I guess I missed the canvas part initially. Sorry about that.
However, even with the GPU blacklist disabled and something that should cause a lot of repainting hd /dev/urandom, I'm unable to get any flickering out of Chrome, and only some poor performance, even with an exceptionally large terminal size (500x100, anyone?).

@danloiterton Don't forget that Chrome has chrome://flags which should let you set the --ignore-gpu-blacklist flag without having to pass it on the command line. Code doesn't have a similar interface, unfortunately, but at least you don't have to make a shell script for everything. :P

Same issue here, started to have it after updating vscode last week I think. I have it on a Macbook Pro Retina 15 inches, but it doesn't occur on my secondary screen which is default DPI.

what's the impact if we turn it on for all builds as part of the regular
release?
On Thu, Mar 29, 2018, 12:12 PM Jérémy Faivre<EMAIL_ADDRESS>wrote:

Same issue here, started to have it after updating vscode last week I
think. I have it on a Macbook Pro Retina 15 inches, but it doesn't occur on
my secondary screen which is default DPI.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/45492#issuecomment-377287170,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABZ-WU6f3IbxZbH1HpG2Gmex0kANWCHZks5tjQfOgaJpZM4Sle38
.

I believe the list of disabled/enabled cards is available here. Any systems with these cards disabled with good reason may be affected, but considering the age of most of these... hm.

@BytewaveMLP it looks like this file is what's used and goes into detail on what features are disabled for each configuration. accelerated_2d_canvas is the primary feature we need for this, not 100% sure what other ones affect canvas rendering.

@BytewaveMLP it looks like this file is what's used and goes into detail on what features are disabled for each configuration. accelerated_2d_canvas is the primary feature we need for this, not 100% sure what other ones affect canvas rendering.

@mix3d maybe it's this one? https://cs.chromium.org/chromium/src/gpu/config/software_rendering_list.json?q=software_rendering_list&sq=package:chromium&dr&l=748
You could try updating your drivers. Intel is mentioned a lot in that file, it's tough to tell without knowing. Also we'll be on an older version of that file since Electron isn't on the latest version of Chromium, so the list will be a little different for us.

I've got the same issue on a Lenovo P50 (4K display) in an Ubuntu 14.04 VM. The issue to get worse with window size. --ignore-gpu-blacklist does not seem to resolve the issue.

@martinmeinke GPU support always seems to be broken in VMs, try --disable-gpu and also disabling GPU acceleration in the VM settings if available.

No, bad bot. We had something going here. 😡

I think this was never actually fixed, there was a workaround in Chrome: https://bugs.chromium.org/p/chromium/issues/detail?id=695427
But that did not actually fix the issue.
I got used to just restart VSCode, but it just gets broken sooner and sooner with new releases (the terminal seem to be affecting it badly).
1.22.1 made the problem worse again.
(my machine: MBPro 15inch, mid2015, macOs 10.13.4, 16GB ram, Intel Iris Pro 1536 MB ram)
The only really working "workaround" right now is to run the external display in native resolution without scaling.

This was bugging me so I did a little digging. Found a nice list of command line switches for Chromium here: https://peter.sh/experiments/chromium-command-line-switches/.
When I launch VS Code from Terminal with $code --disable-gpu-compositing the issue is resolved.
Note that during my search I also found that there seems to be a known issue relating to the cursor blink - I messed with this as the flicker seemed to happen when I changed the focus - swapping tabs, moving the cursor - which would also change the cursor focus. This didn't seem to have an effect, but I found using "editor.cursorBlinking": "smooth" drops the CPU usage down from about 20% to 8%, and sometimes it's nearly idle with VS Code open.
If you're a perfectionist (like me) and you want to have a standard "app" to open like this (as you may not always be in terminal) you can use this simple AppleScript in Automator:
on run 	do shell script "/usr/local/bin/code --disable-gpu-compositing" end run
Save as an application (yourapp.app).
If you want to get even pickier (like me) you can find the VS Code app in your Applications folder -> Get Info and click the icon at the top left -> Cmd+C then do the same on yourapp.app and Cmd+D and now it loosk like VS Code proper.
Hope that helps until they fix this.

Had previously experienced the flickering but it resolved itself with an update. Now the flickering is back.
OS: macOS 10.13.4
VSCode: 1.22.2
All while using HiDPI display connected to my mid-2015 15" MBP with AMD Radeon R9 M370X graphics card. As @teki mentioned, only work around that I've had success with is running in native resolution.

@jlmaners
I don’t believe this is likely GPU-specific. I’m on a 2016 MBP with an AMD GPU but others with Nvidia have experienced the same issue.
It’s an issue that is essentially the same as one that plagued Atom (also built in Electron).
I would take a look at my post and the link to Chrome switches - there’s many related to GPU.
If one or the other doesn’t do the trick (or multiple together) I’d be very surprised.
If this were a driver issue there would be more pixel drawing on the screen that is affected than just VS Code (like the OS background) - you’ll notice in all examples there isn’t.
This means the rendering/drawing latency is isolated to the VS Code instance and has something to do with how it’s talking to the GPU (which is why I started with a buffer setting).

I've run into this on a mac as well. None of the gpu flags I tried made any difference, but the window size did - anytime the window was over a certain size the problem showed up. That size was about 2/3 of the monitor.
The problem only shows up for me when the view is split for viewing files side-by-side. Disabling scaling on the monitor made the problem disappear completely. This monitor is 3840x2160. The scaling option is set to, "looks like 3008x1692". It seems to be total window area that triggers the problem, not just a window taller or wider than some limit.

The original chrome bug is about running out of GPU memory: https://bugs.chromium.org/p/chromium/issues/detail?id=695427

Changing the buffer size (or disabling it) should free up real time available memory, so maybe that’s why it worked for me but I’d also expect there to be some serious fan action if the 4GB of GPU memory were maxed - not the case.
There are also a number of flags related to CPU and software rendering - can you guys play with these and see what happens?

Might want to look at —device-scale-factor.
Since all of these potentially set a value which also affects processes down the line it’s likely one of those.
There’s a number of raterization flags re: CPU vs. GPU.

"editor.disableTranslate3d": true
https://github.com/Microsoft/vscode/issues/25934
Grasping at straws here, but safe to say this is something that is fixed in Electron and Chrome for a while but somehow that fix is not backported into VS Code.

I already had "editor.disableTranslate3d": true.
--high-dpi-support=1 --force-device-scale-factor=1 might work, but it is not something that you want to look at.
--high-dpi-support=1 alone works and seems to be an acceptable workaround, it slows the UI down, but bearable.

It may slow the UI down, but that’s a boolean that should probably be part of VS Code settings.
It’s enabled for Atom by default without noticeable UI issues.
I’m really starting to think that this is a VS Code-specific issue with their Electron config.

Please – bumping for attention on this issue. I will try --hi-dpi-support=1 today, but I am near certain this is a VSCode issue as other Electron apps do not suffer in the same manner.

On my setup, with vscode 1.23 (Insiders edition), passing --disable-gpu-blacklist fixed the issue once and for all.
Platform: Linux
OS: Ubuntu 16.04
GPU: Radeon RX 550 2GiB

FYI There are also bleeding edge "exploration" builds available  - these use Electron 2.0 and a newer Chrome: https://github.com/Microsoft/vscode/issues/45542
I'm now using the exploration build together with --disable-gpu-blacklist for a flicker and artifact free experience.

No, this is definitely a VS Code issue, I think @vgeddes and others' testing shows that. Now we just need to probably wait for the next build that they backport the Electron fixes.

It's back since the latest update,

I just tested as I was having a syntax issue which turned out to be unrelated, but this issue is still occurring.
This is my solution for now (from my comment on Apr 9 above):

If you're a perfectionist (like me) and you want to have a standard "app" to open like this (as you may not always be in terminal) you can use this simple AppleScript in Automator:

on run do shell script "/usr/local/bin/code --disable-gpu-memory-buffer-compositor-resources" end run
Save as an application (yourapp.app).
If you want to get even pickier (like me) you can find the VS Code app in your Applications folder -> Get Info and click the icon at the top left -> Cmd+C then do the same on yourapp.app and Cmd+D and now it loosk like VS Code proper.
Hope that helps until they fix this.

I'm trying the --disable-gpu-memory-=buffer-compositor-resources advice now.
My issue is slightly reversed. I have a shiny new Dell Precision 5520 with a 4k display, and I'm using two older external monitors that aren't. Flickering and randomly crashing are par for the course. Most frustrating is when my integrated terminal window doesn't repaint, and I have to drag the size up or down to get it back. Eventually anything I mouse over flickers, and I have to restart. Also, I have to turn off the laptop monitor, or system resources go haywire while Code is open. That's probably another issue entirely.
I've ordered a pair of 43" 4K monitors from LG. My thinking is that if I remove scaling, this issue will go away. It works perfectly without the external monitors. After reading this newest set of issues, I'm not sure that will solve the problem.
Arch Linux: 4.14.51-1-lts
i3wm

@wolfhoundjesse
Unless you’re using a macOS GPU driver and API in Arch, I’d suspect not.
There are a number of other GPU flags that might help. I provided a link much earlier in the thread.

I experience this problem on Windows, so I don't think the drivers are that
important.
On Wed, Jun 27, 2018, 3:58 PM Methodbox.io<EMAIL_ADDRESS>wrote:

@wolfhoundjesse https://github.com/wolfhoundjesse
Unless you’re using a macOS GPU driver and API in Arch, I’d suspect not.
There are a number of other GPU flags that might help. I provided a link
much earlier in the thread.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/45492#issuecomment-400809544,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABZ-WaMZRR5je0LEhRv7DNXaLO6oJwEjks5uA-P1gaJpZM4Sle38
.

@mix3d
Are you also using an AMD GPU? My MBP has the AMD 550. It seems most everyone in this thread is using AMD.
There must be something in common.

Intel HD 620. Lenovo X1 yoga laptop.
 My MBP has the AMD 550. It seems most
everyone in this thread is using AMD.
There must be something in common.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/45492#issuecomment-401035769,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABZ-WasU7N0nXOboeU2cAkykypB6Ixswks5uBNspgaJpZM4Sle38
.

Ran into this with the latest version. Seems that --high-dpi-support=1  now seems to solve it for me, which is weird because it didn't previously.

I have the opposite experience with --high-dpi-support=1, it used to work, now the glitches are back with 1.24.1. --disable-gpu does not do anything either.
macOS 10.13.5 (MacBook Pro 15 mid 2015), Intel Iris Pro GPU, 4k external display.

Managed to get it into usable shape with enabling reduce motion: https://support.apple.com/kb/PH25204
My guess is that Chrome is still running out of GPU memory.

I see something similar but just when in the terminal view (see below), using insiders version 1.25 on ubuntu 18.04.
the terminal window, is sitting over the explorer, I have the exact same version on a 16.04 and this isn't an issue, I guess it may have something to do with monitor size (18.04 on 27" screens 16.04 on 22" screens) neither screens are 4k (as far I can tell).

@DuncanFaulkner I think that's https://github.com/Microsoft/vscode/issues/51479

@Tyriar OK thanks will take a look

@ashmckenzie DisplayPort has significantly higher bandwidth. If you’re using anything 2K or higher for your resolution and want 60Hz or better refresh rate (and you do ;)) then yeah, you want DP.
I on the other hand have been using a LG USB-C monitor at 4K 60Hz. DisplayPort is run over USB-C in this case.
I can try my USB-C to

Similar to @BytewaveMLP, I am using DisplayPort exclusively. Beyond VSCode, I also experience similar flickering in Discord desktop, though I am running in Arch with a RX580, whereas it seems that most users here are using Macs. Definitely appears to be an Electron issue.

@bpasero Thanks! I will try this later today and report back.

Sadly confirm the similar issues. Unfortunately, reproducible for both UHD and HD monitors.
I have encountered this myself 1st time after updating VC from ver. 1.25 to recent 1.27 on Ubuntu 17.01 (run over XRDP from Xeon Server on HP laptop). However, one of my colleagues was reporting this for VC versions earlier than 1.25. In the latter case this was also U17 but run in VBox on W7 HP laptop.
In my case, 1st of all I tried reinstalling VC packages. This allowed to forget about the issue for about 1 week. After the issues got back, neither the packages reinstall, nor updates (nor re-copy of RDP fixing packages [https://github.com/Microsoft/vscode/issues/3451]) helped.
On the other hand, I noticed that the VCode-Insiders didn't have that issue (at least at the moment). I guessed this is caused (in addition to visual perception of what was happening on the screen, where some strange background color rectangular blocks started to appear randomly overlapping (covering, cleaning) the code window text) by some bug with mouse hover hints pop-ups. I increased the code hints popup time and then switched that off completely (although, didn't find how to do the same for full file names pop-ups that appear when mouseovering on top of the file-names shown e.g. in the file list of file browser area or on the top bar of open files tabs). The luck of the VCode-Insiders in this sense seemed to be in the inability to find proper inclusions, so VCode-Insiders wasn't able to show any hint for the code, and hence, no mouseover popups.
Sadly, but disabling the hint popups didn't help the VC. After sometime (even without any mouse moves or visible origin for doing mouse hover triggered actions), the same random background color overlapping rectangles started emerging randomly again, so messing up all the text in the code window (up to 80%).
It doesn't look useful to provide any static screenshots. The videos of what happens might be more useful, if there are no guess from VC developers where the issue night come from..
Just let me know, whether it's needed then. I can shoot the video and post here.
So far, crossing my fingers with hope the VCode-Insiders could work. Otherwise, i'm completely blocked with VC usage for my project development..

Ok. After sometime (probably allowing the corresponding spare processes spoiling text window to finalize), deprecation of mouse over popups really helped.
Next day I tried VC, there was just some VC "nervous" attempts to redraw with background color several lines below one was editing at the moment, but then it was able to recover the text back quite fast.
Only once it showed up with the origin of what probably was casing that.
Seems to be there were VC attempts to show some strange typed code context helper popup. But the info on the popup helper was completely illogical and inconsistent! E.g. it was popping up after typing colon symbol in the double slash comment line. Why the heck?

Is it a bug?

That's how it looks like with no popups blocked:

Also, as the bug description implies, switching VC from full screen mode to windowed of smaller size on UHD monitors seems like allows decreasing the number of residual aftereffects of the mentioned graphics redraw issues.

We are building exploration builds that use a much newer version of Electron (our UI framework). I wonder if this issue reproduces with one of these builds, could you try? Download:

Windows: Download
macOS: Download
Linux: Download

Ok. After waiting for MS IntelliSense to setup (in order to be able showing mouseover popup hints), it looks like I do not see the graphics issues (Linux U17, XRDP) in the corresponding package after playing a little.

What I meant previously, is VC standard extension (offered automatically by VC to be installed based on C/C++ project I work currently):
"
C/C++ | ms-vscode.cpptools | Microsoft
C/C++ IntelliSense, debugging, and code browsing.
"
In addition to standard installation, restarting, etc. more or less quick done actions, it need time to build up its database in order to find the proper sources (includes) to show hints for function declared either by mouseover or when intentionally clicked (from right-click menu) "Go to Definition/Declaration".
Until this DB is built, the hints cannot be shown, so there is no so heavy graphics redraw load (no mouseover based popups).

Is anyone else seeing this issue only in the git file diff view? When a file has many changes, vscode becomes almost unusable until I close that diff tab, then things go back to normal. If the file has just a couple of changes it's not a problem. So I need to use git diff in the terminal not in vscode.
I don't have a non-HIDPI monitor to test against so I assume it's related to this issue.

@rightaway I'm still seeing this on Ubuntu with i3wm.
It seems to be caused when ever there are splits showing (which the diff has). One way around this (for me at least) is to pass the --disable-gpu-blacklist flag when I start code

@bpasero
I have had the same issue with just a 1920x1080 monitor in ubuntu.  The option C_Cpp.dimInactiveRegions turns the entire screen to empty blocks if any large sections of code are dimmed.  It looks very similar to the picture from @Ts-OV and even ends up misdrawing the left side panel.  I also needed to set the terminal renderer to dom in order for it to be responsive.
However, with the exploration version that was posted a couple weeks ago, those issues appear to be gone.  There aren't any empty blocks and the terminal updates very quickly with the default renderer.

Affected as well, but this happened after updating nvidia driver (Linux). Not sure what is the problem, but it means that VSCode is unusable to me. I tried --disable-gpu parameter, but with no luck.

I was only lucky with --disable-gpu --force-cpu-draw arguments. It seems that --disable-gpu is not enough. This is definitely Blink or SKIA issue, VSCode is just a victim in this case :)

I had to remove --disable-gpu-blacklist flag because it was causing very high CPU usage since very recently, possibly the last monthly release. But for some reason I'm not getting repainting issue anymore in the diff view, so the problems seems to be resolved for me at least for now. Anyone else?

Latest build seems to be working well for me too. Have not noticed paint issues in a while. I tried the new TypedArray for the console, but had a crash or two so I disabled it.

Ok, thanks. I will try the electron-3.0.x branch and see how it goes. It generally manages to run better, but I was having issues with it occasionally freezing. Such is the life of  HiDPI laptop owner :)

As of this writing, I'm using the latest version of the Insiders build on MacBook Pro (15-inch, Radeon Pro 560X 4096 MB) + OS X 10.14.1 + Dell P2415Q (DisplayPort / MST Off / 3840x2160 @ 60Hz) and find that the issue still occurs.
After some additional troubleshooting, I determined that in my case the cause seems to be related to adjusting the Resolution to Scaled in the OS X Display Preference pane. With scaling disabled, I don't encounter the issue.
Note that using a third-party display resolution tool, SwitchResX, seems to allow me to adjust resolution while at the same time avoiding the VSC flicker.
This may prove applicable for some.

@cscomfort I have similar issues, reported as a new issue: https://github.com/Microsoft/vscode/issues/68188


Mitigation experiment

Summary
Details and comments

Thanks @chriseclectic , I've opened a new PR to address those issues:
https://github.com/Qiskit/qiskit-experiments/pull/611


Remove invalid debuginfo symlink

Fixes https://github.com/adoptium/adoptium-support/issues/298 (Rogue symlink to something that gets deleted)
Signed-off-by: Stewart X Addison<EMAIL_ADDRESS>

(Note to committers: While this change should be safe, I haven't checked that this definitely works ... Will aim to do that tomorrow so I recommend holding off merging for now then we can verify before the change his the nightlies)

This looks to be good - merging

I think that instead of | xargs rm -f you could also use the -delete flag of the find command?
     -delete
             Delete found files and/or directories.  Always returns true.  This executes from the current working directory as find recurses down the tree.  It will not attempt to
             delete a filename with a ``/'' character in its pathname relative to ``.'' for security reasons.  Depth-first traversal processing is implied by this option.  Following
             symlinks is incompatible with this option.

I think that instead of | xargs rm -f you could also use the -delete flag of the find command?

It's not a standard option across all UNIX-based platforms.


Compute nodes don't get terminated despite Slurm indicating idle~ status

CycleCloud version: 8.6.2-3276
Slurm version: 22.05.11
Autoscaling down after the job queue gets empty worked for me successfully numerous times until it didn't after full occupancy of the cluster lasting several days. All jobs were then killed, the compute nodes transitioned to idle~, but CycleCloud didn't deprovision the VMs. How can I investigate the cause of this behavior?

Can you check for any messages in /opt/azurehpc/slurm/logs/autoscale.log and shutdown.log in the same directory?

Also are the VM's showing up in cyclecloud? Can you verify if you set KeepAlive on them through cyclecloud UI?


Ecto repo timeout

Closes #448. Let me know if anything is missing.

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:

Would it be a good idea to split poolboy timeout and call timeout?

we could do it later if somebody needs it


Natural language classifier

Summary
Provide a general description of the code changes in your pull
request... were there any bugs you had fixed? If so, mention them. If
these bugs have open GitHub issues, be sure to tag them here as well,
to keep the conversation linked together.
Other Information
If there's anything else that's important and relevant to your pull
request, mention that information here.
Thanks for contributing to the Watson Developer Cloud!

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

I suspect this pull request was a mistake.
To clarify our intentions, though, we are working to port services to a new architecture that is faster, safer, and more maintainable. Those changes are being pushed to the rest-kit branch. After all services are ported and the functionality matches that of the master branch, we will merge rest-kit to master.
The NaturalLanguageClassifier branch specified here contains updates to the Natural Language Classifier service for RestKit. It will soon be merged into rest-kit, which will eventually be merged into master. So there's no need to merge the NaturalLanguageClassifier branch directly to master right now, as requested by this pull request.


[bug] fill property on lucide-icons not working

Describe the bug
The property "fill" on lucide-icons is hardcoded to "none". It would be great if the fill property is respected.
To Reproduce
Set a fill={color} on any lucide-icon
<Star color="red" fill="red"/>

https://github.com/tamagui/tamagui/blob/master/packages/lucide-icons/src/icons/star.tsx#L41

I'll stick to the mdi icons for now, or maybe the lucide will have a filled star sometimes in the future


Re-add unit tests

ccopy existing tests
add 'minitest' gem

Readded old tests + created new ones.


update dapr to 1.10.0-rc.2

Signed-off-by: Pravin Pushkar<EMAIL_ADDRESS>Description

update dapr to 1.10.0-rc.2
update kubernetes/configuration_test.go
update e2e/stanalone/run_test.go

@pravinpushkar please fix the E2E ... api logging now has a method field which is either obfuscated or not...If possible add a test for obfuscation also ...

@pravinpushkar please fix the E2E ... api logging now has a method field which is either obfuscated or not...If possible add a test for obfuscation also ...

yes, thought the changes just got reverted with addition to obfuscation. :(

@pravinpushkar I do have a question ... between config file and flag in daprd, which takes precedence if one is set to false and the other true for enabling api logging?

@pravinpushkar I do have a question ... between config file and flag in daprd, which takes precedence if one is set to false and the other true for enabling api logging?

it is the cli flag which takes the precedence

@pravinpushkar I do have a question ... between config file and flag in daprd, which takes precedence if one is set to false and the other true for enabling api logging?

it is the cli flag which takes the precedence

Thanks. Just now saw the description as well in this PR https://github.com/dapr/dapr/pull/5866/

enabled:
description: Default value for enabling API logging. Sidecars can always override this by setting --enable-api-logging to true or false explicitly. The default value is false.


packet-cli: 0.0.7 -> 0.0.8

Motivation for this change
packet-cli: update to latest
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I think this tool's binary is meant to be packet. In the interest of backward compatibility, I symlinked 'packet-cli' to the existing packet-cli.

Thank you @colemickens for the help! Symlink is a good idea IMO. I'm merging.


New measurement list

I updated the list of measurement and a description onhow I measurement that match the morphology code
same for the landmarks to match #1-#18.

@thibaulttabarin this is no longer needed, correct?


The Aggregation and Sort function cannot take effect at the same time

Please use the following questions as a guideline to help me answer
your issue/question without further inquiry. Thank you.
Which version of Elastic are you using?
[ ] elastic.v6 (for Elasticsearch 6.x)
[x] elastic.v5 (for Elasticsearch 5.x)
[ ] elastic.v3 (for Elasticsearch 2.x)
[ ] elastic.v2 (for Elasticsearch 1.x)
Please describe the expected behavior
The values returned after aggregation are sorted by sort
Please describe the actual behavior
Aggregation takes effect, but sort fails(The @timestamp field mapping is good)
Any steps to reproduce the behavior?
{     "query" : {       "bool" : {         "must" : [           {             "term" : {                 "kubernetes.container.name" : "plat-log-server"             }           }         ],         "filter": [           {"range":{             "@timestamp" : {               "gte":"2018-09-13",               "lte":"now"             }           }}           ]       }     }     ,"aggs": {     "property_type": {       "terms": {         "field": "kubernetes.pod.name",         "size":100       }}},       "sort": [         {           "@timestamp": {             "order": "desc"           }         }       ] }
Another solution，that use top_hits also not good
{   "size":0,     "query" : {       "bool" : {         "must" : [           {             "term" : {                 "kubernetes.container.name" : "plat-log-server"             }           }         ],         "filter": [           {"range":{             "@timestamp" : {               "gte":"2018-09-13",               "lte":"now"             }           }}           ]       }     }     ,"aggs": {     "top_agg_hit": {       "terms": {         "field": "kubernetes.pod.name",         "size":100       },       "aggs": {         "top_agg_hit": {           "top_hits": {             "size": 1,       "sort": [         {           "@timestamp": {             "order": "desc"           }         }       ]           }         }       }     }} }
I found a solution to sort using the sort field in the resp，but I don't think it's the optimal solution

why size=0

Just asking: You want the aggregations to be sorted, or the search results (aka hits)?

Sorting has at least 3 integration tests, so I guess something's wrong with your code. Can you post a reproducible test case?

I have some documents indexed on Elasticsearch, looking like these samples:
{'country': 'France', 'collected': '2015-03-12', 'value': 20} {'country': 'Canada', 'collected': '2015-03-12', 'value': 21} {'country': 'Brazil', 'collected': '2015-03-12', 'value': 33} {'country': 'France', 'collected': '2015-02-01', 'value': 10} {'country': 'Canada', 'collected': '2015-02-01', 'value': 11} {'country': 'Mexico', 'collected': '2015-02-01', 'value': 9}
but after  top_hits，it result like this
{'country': 'France', 'collected': '2015-03-12', 'value': 20} {'country': 'Canada', 'collected': '2015-03-12', 'value': 21} {'country': 'Mexico', 'collected': '2015-02-01', 'value': 9} {'country': 'Brazil', 'collected': '2015-03-12', 'value': 33}
I want it to look like this，The results should be sorted by the collected field.
{'country': 'France', 'collected': '2015-03-12', 'value': 20} {'country': 'Canada', 'collected': '2015-03-12', 'value': 21} {'country': 'Brazil', 'collected': '2015-03-12', 'value': 33} {'country': 'Mexico', 'collected': '2015-02-01', 'value': 9}

aka

also the search results that after top_hits，should be sorted by field

Just asking: You want the aggregations to be sorted, or the search results (aka hits)?

also the search results that after top_hits，should be sorted by field

I'm still not sure what you're trying to achieve. Sorting aggregations and search results works well, see this gist. Can you modify the code and/or the data to produce a reproducible test case that illustrates your problem?

Oh, I see your comment just now. I will change the gist to reflect on your comment.

Still confused. But this gist is an example illustrating how sorting the aggs doesn't interfere with sorting the hits in any way. Maybe you can build on that.

Still confused. But this gist is an example illustrating how sorting the aggs doesn't interfere with sorting the hits in any way. Maybe you can build on that.

Thank you very much,I got the right result through your sample code.I guess the order parameter in Terms Aggregation plays a role.So I still have a question as to why Max Aggregation can be ordered, but Top hits Aggregation can't be ordered?

It's in the error message:

Buckets can only be sorted on a sub-aggregator path that is built out of zero or more single-bucket aggregations within the path and a final single-bucket or a metrics aggregation at the path end. Sub-path [last_collected] points to non single-bucket aggregation.

So the top_hits aggregation, even though returning just one document, seems to be considered as a multi-bucket aggregation.
From the docs:

It is also possible to order the buckets based on a "deeper" aggregation in the hierarchy. This is supported as long as the aggregations path are of a single-bucket type, where the last aggregation in the path may either be a single-bucket one or a metrics one.

These kinds of aggregation and sorting also seems to be rather expensive.


"Example: Use the project name for a file name"

This section does not include important information.  One must edit the template csproj such that the Content Include or Compile Include nodes' file names match the formatted filenames in the vstemplate file.  If one does not follow this step, the template will fail upon project creation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5f4a0078-1a87-6e3a-791e-d3068fb7032c
Version Independent ID: 1d2d976d-2698-88d6-fac4-4d34e3855e2a
Content: Project and item template parameters - Visual Studio
Content Source: docs/ide/template-parameters.md
Product: visual-studio-windows
Technology: vs-ide-general
GitHub Login: @gewarren
Microsoft Alias: gewarren

Comment to trigger priority labeling.

This section does not include important information.  One must edit the template csproj such that the Content Include or Compile Include nodes' file names match the formatted filenames in the vstemplate file.  If one does not follow this step, the template will fail upon project creation.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
ID: 5f4a0078-1a87-6e3a-791e-d3068fb7032c
Version Independent ID: 1d2d976d-2698-88d6-fac4-4d34e3855e2a
Content: Project and item template parameters - Visual Studio
Content Source: docs/ide/template-parameters.md
Product: visual-studio-windows
Technology: vs-ide-general
GitHub Login: @gewarren
Microsoft Alias: gewarren

Can you explain more precisely what are the missing steps ?
I'm trying to use $safeprojectname$/$projectname$/$specifiedSolutionName$/$SpecifiedSolutionName$/$specifiedsolutionname$ without any succes !


Rename Server to App, Change Default Signature

We've renamed server to app in favor of an express like api.
Changing the default export signature of ./app, we are able to expose it
directly so that users will be able to integrate directly with mockyeah's express
instance.

@ryanricard, how we looking?

Something doesn't seem right with this PR. What is with the duplicate files added to ./app/server?


pollTask in service degrades acceptance test performance

I noticed an increase in total test time when I used pollTask in a service.
interval =  100 ms -> 33 seconds
interval =  500 ms -> 53 seconds
interval = 1000 ms -> 82 seconds

This is the relevant service code:
// app/services/clock.js
init() {
  this._super(...arguments);
  this.pollTask('update', 'clock#update');
},
update(next) {
  let serverTime = this.get('serverTime');
  if (serverTime) {
    // ...
    this.set('serverTime', new Date(localMillis - totalOffset));
  }
  this.runTask(next, 500); // <-- 500 ms interval
},

and the one test that actually uses pollTaskFor is something like:
// tests/acceptance/clock-test.js
const mockTimeService = Service.extend({
  now() {
    return clientTime;
  },
  offset() {
    return clientOffset;
  }
});

//...

await login.visit();

await assert.equal(clock.date, '16 Mar 2017', 'clock shows date');
await assert.equal(clock.time, '6:30:20 pm', 'clock shows time');
await assert.equal(clock.timezone, 'Pacific', 'clock shows timezone');

clientTime = moment('2018-04-17T19:35:25.100', 'YYYY-MM-DDTHH:mm:ss.SSS').toDate();
await pollTaskFor('clock#update');

await assert.equal(clock.date, '17 Apr 2018', 'updated clock shows date');
await assert.equal(clock.time, '3:35:25 pm', 'updated clock shows time');
await assert.equal(clock.timezone, 'Pacific', 'updated clock shows timezone');

The test really doesn't effect anything, I just think the async/await combined with the pollTaskFor is just super nice looking 😁 thanks for the awesome work!
One thing that may be causing this is that I'm mixing this into a service, not a component. I tried debugging this a bit and it seems like runTask is the culprit. Without it the test suite drops back down to 29 seconds.
I profiled when the polling started and when the timers where cleared and this is what I got (with an interval of 1000 ms):
pollTask 851 ms
runTask 853 ms
willDestroy 1901 ms

It may be that the services willDestroy hook is not called until all tasks in the run loop have finished but I'm not very familiar with the inner workings of the run loop.
As a temporary fix I'm setting the interval to 0 in test:
let interval = 500;
if (Ember.testing) {
  interval = 0;
}
this.runTask(next, interval);

Hmm. Well, the runTask (of 500ms) is explicitly specifying to the test to wait for 500ms. This seems completely expected. In this circumstance before, I have generally imported the timer durations from config/environment and defined separate durations for test vs prod/dev.
It is totally possible (and something that I wanted to start experimenting with) to "fast forward timers" while testing. The idea would be that timers would be guaranteed ordering wise, but would not respect the exact time delay specified.

Ok I guess I was interpreting the docs wrong:

In testing, the updateTime method would execute initially during the components instantiation (just like in development and production environments), but would not automatically start polling. This allows tests that are not related to the polling behavior to continue uninterrupted. To test the actual polling functionality, use the provided pollTaskFor helper

I was thinking that in test the runTask combined with pollTask would only execute the tick when pollTaskFor was called.
I think shortening the timers in test automatically is a good idea. Although yeah, the order would need to be preserved. For now I'll move the configuration into the config.

I was thinking that in test the runTask combined with pollTask would only execute the tick when pollTaskFor was called.

OH! Yes, I see what you mean here.  Reopening so I don't forget to dig into it...

Just doing a bit of cleanup on issues in this repo. If this issue is closed in error please reopen!


fix: use the JUMP_TO action for tab change

The index change event fires after swipe animation. If you quickly navigate to a new screen in stack before animation finishes, the index change event will fire after the previous navigation event. By this time, the tab navigator is not focused anymore. Using the JUMP_TO action instead of NAVIGATE avoids this issue.

For anyone using redux you need to handle 'Navigation/JUMP_TO the same as 'Navigation/NAVIGATE otherwise your tabs will randomly jump back


Updated box.json with ignore of phar

Q
A

Bug Fix?
n

New Feature?
n

BC Breaks?
n

Deprecations?
n

Tests Pass?
n

Fixed Tickets

License
MIT

Doc PR

Sent using Gush

not needed anymore i think


Export config

Add more options

include all regions, but exclude a specific list
only include non-travellers.

The existing setup works well for

home country + travellers export

We need the ability to create a second export that represents

foreign country non travelers

/kind enhancement

/assign


Update to use the DP+ 0.13.0

Getting the below error while installing datapusher-plus docker version 0.13.0
Where are we setting the Python path configuration ?
(default) minhaj@Ubuntu20:~/test-dp/datapusher-plus-docker/datapusher-plus/0.11.0$ docker compose up  [+] Running 1/0  ⠿ Container datapusher-plus  Created                                                                                0.0s Attaching to datapusher-plus datapusher-plus  | ${VENV}/bin/uwsgi --socket=/tmp/uwsgi.sock --enable-threads -i ${CFG_DIR}/uwsgi.ini --wsgi-file=${SRC_DIR}/datapusher-plus/wsgi.py datapusher-plus  | [uWSGI] getting INI configuration from /etc/ckan/datapusher/uwsgi.ini datapusher-plus  | *** Starting uWSGI 2.0.21 (64bit) on [Mon Jun 19 20:42:33 2023] *** datapusher-plus  | compiled with version: 11.3.0 on 19 June 2023 20:18:43 datapusher-plus  | os: Linux-5.15.0-71-generic #78~20.04.1-Ubuntu SMP Wed Apr 19 11:26:48 UTC 2023 datapusher-plus  | nodename: Ubuntu20 datapusher-plus  | machine: x86_64 datapusher-plus  | clock source: unix datapusher-plus  | detected number of CPU cores: 8 datapusher-plus  | current working directory: /srv/app/src datapusher-plus  | writing pidfile to /tmp/uwsgi.pid datapusher-plus  | detected binary path: /usr/lib/ckan/dpplus_venv/bin/uwsgi datapusher-plus  | !!! no internal routing support, rebuild with pcre support !!! datapusher-plus  | setuid() to 33 datapusher-plus  | your memory page size is 4096 bytes datapusher-plus  |  *** WARNING: you have enabled harakiri without post buffering. Slow upload could be rejected on post-unbuffered webservers ***  datapusher-plus  | detected max file descriptor number: 1048576 datapusher-plus  | lock engine: pthread robust mutexes datapusher-plus  | thunder lock: disabled (you can enable it with --thunder-lock) datapusher-plus  | uWSGI http bound on <IP_ADDRESS>:8800 fd 3 datapusher-plus  | uwsgi socket 0 bound to UNIX address /tmp/uwsgi.sock fd 6 datapusher-plus  | Python version: 3.10.6 (main, May 29 2023, 11:10:38) [GCC 11.3.0] datapusher-plus  | !!! Python Home is not a directory: /usr/lib/ckan/datapusher-plus !!! datapusher-plus  | Set PythonHome to /usr/lib/ckan/datapusher-plus datapusher-plus  | Python path configuration: datapusher-plus  |   PYTHONHOME = '/usr/lib/ckan/datapusher-plus' datapusher-plus  |   PYTHONPATH = (not set) datapusher-plus  |   program name = '/usr/lib/ckan/datapusher-plus/bin/python' datapusher-plus  |   isolated = 0 datapusher-plus  |   environment = 1 datapusher-plus  |   user site = 1 datapusher-plus  |   import site = 1 datapusher-plus  |   sys._base_executable = '/usr/lib/ckan/datapusher-plus/bin/python' datapusher-plus  |   sys.base_prefix = '/usr/lib/ckan/datapusher-plus' datapusher-plus  |   sys.base_exec_prefix = '/usr/lib/ckan/datapusher-plus' datapusher-plus  |   sys.platlibdir = 'lib' datapusher-plus  |   sys.executable = '/usr/lib/ckan/datapusher-plus/bin/python' datapusher-plus  |   sys.prefix = '/usr/lib/ckan/datapusher-plus' datapusher-plus  |   sys.exec_prefix = '/usr/lib/ckan/datapusher-plus' datapusher-plus  |   sys.path = [ datapusher-plus  |     '/usr/lib/ckan/datapusher-plus/lib/python310.zip', datapusher-plus  |     '/usr/lib/ckan/datapusher-plus/lib/python3.10', datapusher-plus  |     '/usr/lib/ckan/datapusher-plus/lib/python3.10/lib-dynload', datapusher-plus  |   ] datapusher-plus  | Fatal Python error: init_fs_encoding: failed to get the Python codec of the filesystem encoding datapusher-plus  | Python runtime state: core initialized datapusher-plus  | ModuleNotFoundError: No module named 'encodings' datapusher-plus  |  datapusher-plus  | Current thread 0x00007f9651218740 (most recent call first): datapusher-plus  |   <no Python frame> datapusher-plus  | VACUUM: unix socket /tmp/uwsgi.sock removed. datapusher-plus exited with code 1

Fixed


Some help with assigning N-N relationship

I have some issues using the Associate Entity method.
I want to associate a specific Portal Web Role to a Contact by using a workflow (so I can do the assignment in bulk). For this I create an on demand workflow within the context of Contact. I add a step with the Associate Entity custom activity and use these input parameters:

Relationship name: adx_webrole_contact
Relationship entity name: adx_webrole_contact (both Name and Entity Name are the same)
Record URL: https://.crm4.dynamics.com/main.aspx?etn=adx_webrole&id={32C6733F-6241-E811-A82F-000D3AB4B197}&pagetype=entityrecord (direct URL to the specific web role I want to associate)

I receive the error "Unexpected exception: Input string was not in a correct format.". So I assume that the input parameters are not correct.
Would be great if you could help me out!
Regards and thanks for the great tools!
Elowy.

The Record URL mus have parameters for "etc=" and "id=" (etc is entity type code). The format should be similar to what you get when using the "Record URL(Dynamic)" attribute for an entity in a workflow.
"Record URL(Dynamic)" also doesn't include braces around the id - if you're still getting an error, try it without them.

Thanks! This record URL worked well: https://.crm4.dynamics.com/main.aspx?etc=10016&extraqs=formid=32d92d2c-67d6-4c8c-b406-6ac64391f89a&id=32C6733F-6241-E811-A82F-000D3AB4B197&pagetype=entityrecord

I'm not getting an error, I have the url encoded properly (I think, see below) and it saves the workflow and activates it properly, but when I run it on a given contact, it doesn't associate the two records. The workflow completes with a status of "success." I've tried it with a couple different entities as the "destination" entity to associate the entity specified below with, always same result - nothing happens, no failures,, but the association is not created. Specifically I've tried it with Contacts and Meetings, and the entity below is Tags. I believe Meetings and Tags are custom entities in our system, but they have existing N:N relationships and can be associated manually as usual. Is this limited only to built-in CRM entities, maybe?
https://my.crmurl.org/main.aspx?etc=10095&extraqs=formid=e68ff677-accd-4ea5-8ca0-c1477981192b&id=86adb0f7-9a1b-e711-85ac-00155d24051f&pagetype=entityrecord


Added blueprint EP038

Related to coloring issue #45
Summary
Blueprint detailing vulnerabilities that coloring presents and how to solve them.

@Alopalao let me know when you need another review, the updated text look good, looks like these points are still open though:

Do we really need to manage the general dl_src actions drop? Since flows will be matched with in_port too on NNIs? Maybe we don't even need to manage extra drop flows and let the switch itself drop. Unless for sanity sake we'd like to make that explicitly. I'll leave that up to you and @italovalcy to discuss if you really want this to be explicit.
How flows will be migrated? Are you going to provide a DB script?
Partly related: coloring is also exposing the COLOR_FIELD='dl_src' to be configurable, since that flow is never persisted, if it changes it might also leave flows behind, which probably wouldn't impact but still leftovers, maybe it might be worth documenting in the README if it changes then network operators are supposed to delete the old flows?

This implementation will be on hold for some time until:

MAC address needs to be changed. Start using addresses reserved from IETF/IANA (00-00-5E-00-53-00 - 00-00-5E-00-53-FF)
Attribute in config file to determine range of assigned MAC addresses
coloring needs a counter to keep track of links.


DPL-323 Kanban view for all pipelines [C=M, V=3]

User story
As a member of a DNAP lab team, I would like to be able to use the equivalent of the Heron 'work in progress' view, but for the pipelines that I work on, so that I can manage my workload and make sure all plates are processed that need to be.
Who are the primary contacts for this story
Liz E, Katy
Acceptance criteria

[x] 'In progress' view is made generic, so it can work for any Limber pipeline.
[x] There are links for all Limber pipelines from the 'Work in progress' dropdown on the home page.

Related stories
https://github.com/sanger/limber/issues/1030 will probably result in the query driving the page being updated - doesn't need to clash with this one but be aware of it.
Additional context
Liz E said this would be useful for her team, and also that SSRs might find it useful.
The idea here is to do the minimum possible to extend it to all pipelines, without doing any extra investigation into the details of any specific pipelines.
Then we can advertise it to relevant customers and gather user feedback, or make further spin-out stories if any obvious problems arise when applying it to other pipelines.
Technical details
There is a dropdown on the home page as follows:

Ideally this would list all pipelines, dynamically pulled from config. These buttons pass a parameter through to the page to tell it which pipeline to show. The relevant section of pipeline_work_in_progress_controller.rb is here:
# TODO: Add 'pipeline_group' or similar to pipeline config ymls, to group related ones together
# So that it can work for all pipelines
heron_pipeline_name_to_configs = {
  'Heron-384' => ['Heron-384 Tailed A V2', 'Heron-384 Tailed B V2'],
  'Heron-96' => ['Heron-96 Tailed A V2', 'Heron-96 Tailed B V2']
}

The challenge is that what lab staff think of a 'pipeline' is sometimes represented by more than one key in the pipeline configuration ymls - hence the suggestion in the code snippet above.

I am intrigued by "what lab staff think of a 'pipeline' is sometimes represented by more than one key in the pipeline configuration".
What is the difference between a Limber pipeline and a pipeline for a lab user?
I think this might be relevant for the acceptance crieria.

I'm also not clear on what the comment "what lab staff think of a 'Pipeline' "
From my point of view we would be considering the main library creation types at this time.  Using the submission template would be a fine granular look at pipelines, however this may be too focus to give us value.  Sticking to the library creation aspect of the submission templates Limber-HTP-**** e.g Limber-HTP_ISC.  It would be the ISC portion of the submission template which would define the pipeline.

I going to hazard an answer to my previous question about "what lab staff think of a 'pipeline' is sometimes represented by more than one key in the pipeline configuration".
I believe this stems from 2 causes -
i. Pipelines are linear sequences in Limber - that is any "lab" pipeline that splits plates into two or more, or merges multiple plates into one may need to be internally represented as multiple pipelines.
ii. Pipelines have different versions - so when a "lab" pipeline is updated, internally this is managed by creating a new Limber pipeline.

Sorry, I never saw the above two questions (GitHub emails often get lost in the masses!).
Basically, Tom is correct. When there's a branch in a pipeline, we represent it as two pipelines in the config. It doesn't affect the users, it's just an easier way to do it for technical reasons. And yes, we may also have different versions of the pipeline - often we can just update the existing one, but for bigger changes we might make a new pipeline config and then deprecate the old one once we're sure all the samples have finished going through it.
A final reason is that several pipelines are split into separate library prep and multiplexing stages - so these would be represented separately in the config, but I think should be on the same kanban page.

config/pipelines/bespoke_aggregation.yml and config/pipelines/bespoke_chromium_5p.yml could be grouped?

Emailed Liz/ Barbora/ Danni saying the initial implementation has been deployed to UAT, and if we could discuss the pipeline groupings in a meeting next week.

Off the back of Friday's meeting:

New story for adding user info to Kanban card DPL-457
New story for adding filter DPL-458
New story for more groups DPL-459
New story to make LCMB own pipeline DPL-460
New story to archive pipeline "bespoke chrome v2"

Liz is going to check:

If Custom Metadata and comments work as expected
How the LCM plate is used, and if some plate purposes are skipped
If the Aggregation pipeline is still in use, or if it can be archived
Chromium pipeline and how plates could be grouped. Then add this info to DPL-459


cilium: encryption, if IPv6 is not supported do not throw debug warning

Currently, encryption cleanup code will throw a warning when checking
encryption state with IPv6 support disabled. Lets silence the warning
by adding a check if the error is a 'address not supported' error.
Fixes: #8963
Signed-off-by: John Fastabend<EMAIL_ADDRESS>

This change is

test-me-please

Coverage decreased (-0.03%) to 44.125% when pulling c9022ac2e816530c9f8a6cd9f49a3448bf26858d on encrypt-warning into 42229305fd2e24cf6ece5e9411539341f23852ff on master.


Use probot-metadata for storing snooze config

This is a spike to use the new probot-metadata to store the snooze config for each issue.
@jbjonesjr I based this off master on this fork, which has all of the PRs I've submitted merged together. I tried to cherry pick these changes onto a new branch based off your master, but there were too many conflicts. So I'll wait to submit a PR to this to your upstream repo once the other PRs have been merged.


Cloud Vector DB for TeachableAgent

It would be really useful if the TeachableAgent use a cloud vector db for storing and retrieving memos instead of having the vector db stored locally on my machine.
Something similar to the QdrantRetrieveUserProxyAgent (e.g. a QdrantTeachableAgent) would be really good since Qdrant is a cloud-native vector db. Even better would be a teachable agent where any vector db client (including cloud-native ones) can be passed in the teach_config
@Anush008 @AyushExel

This would be a reasonable extension. Users can currently plug in other DBs by writing a class that inherits from TeachableAgent then modifying that class. Meanwhile, it would be great if somebody volunteers to enhance TeachableAgent so that users can plug in any vector DB without writing code. I don't have time myself, since I'm concentrating on making teachable agents fundamentally more capable, independent of any particular DB.

@rickyloynd-microsoft I can work on it next week

Is there any example code of how to initialise and load the Chrome DB separate from the RAG agent? I would like to do this as part of a start up of the app, of when someone actively wants / needs to refresh the Chrome DB. Apologies if it is trivial, I am new to autogen :)

Is there any example code of how to initialise and load the Chrome DB separate from the RAG agent? I would like to do this as part of a start up of the app, of when someone actively wants / needs to refresh the Chrome DB. Apologies if it is trivial, I am new to autogen :)

Yes, please see autogen/agentchat/contrib/teachable_agent.py

Hi @AyushExel, do you have any news about this feature? It would be awesome!

Hi @AyushExel, do you have any news about this feature? It would be awesome!

Stale. No longer planned.


Fix issue 149 - nfs-client-provisioner create folder with 755, not 777

REF:
https://github.com/kubernetes-incubator/external-storage/issues/149

CLA signed

Please set your email to match github's, then cla should work https://help.github.com/articles/setting-your-email-in-git/.
code lgtm, thanks!

mm merging, CLA is signed the issue is just that the commit was not made with same email as GitHub account's. Thanks again!

@KinOSurvival - I earlier ran into a similar issue related to the CLA and commit email address- here's some advice on how to deal with it - https://medium.com/salesforce-engineering/contributing-to-open-source-at-work-step-1-corporate-cla-7cf74eb77b87


[online] Server failed to connected to Steam 3

Is there an existing issue for this?

[X] I have searched the existing issues

Used image version
sha256:8e22ede2229b4149338006cafee5eb2becd278cabcb9cc38c107374a83e9b3d4
Used docker compose file or docker command
docker run
-d
--name enshrouded
--restart=unless-stopped
-p 37304:37304/udp
-p 38304:38304/udp
-v ./game:/opt/enshrouded
-e SERVER_NAME="Yahu Farm"
-e SERVER_PASSWORD="123"
-e UPDATE_CRON="*/30 * * * *"
-e PUID=4711
-e PGID=4711
-e SERVER_PORT=37304
-e SERVER_QUERYPORT=38304
-e SERVER_IP=MyServerIP
-e STEAM_API_PUBLIC_IP=MyServerIP
--env=HTTPS_PROXY="http://<IP_ADDRESS>:7890"
--env=HTTP_PROXY="http://<IP_ADDRESS>:7890"
--env=https_proxy="http://<IP_ADDRESS>:7890"
--env=http_proxy="http://<IP_ADDRESS>:7890"
mornedhels/enshrouded-server:latest
What you expected to see, versus what you actually saw
When I set STEAM_API_PUBLIC_IP and SERVER_IP to my server IP, it keeps showing [online] Server failed to connect to Steam 3.
Logs from the container
No response

SERVER_IP is the ip config inside the enshrouded_server.json. So the network ip to bind to (in most cases you don't have to change that value at all). If you already set the env you have to update the config manually.
path: game/server/enshrouded_server.json
Default value is <IP_ADDRESS> (bind/listen to all networks)
Pls check if that solves the problem.

SERVER_IP is the ip config inside the enshrouded_server.json. So the network ip to bind to (in most cases you don't have to change that value at all). If you already set the env you have to update the config manually.
path: game/server/enshrouded_server.json
Default value is <IP_ADDRESS> (bind/listen to all networks)
Pls check if that solves the problem.

Thx, I change it to <IP_ADDRESS> and worked but can't find server like another issue "SERVER_IP"

great, than we use #4 for the other problem.
I will leave this issue open, to remind me to update the readme.


⚠ Processors has degraded performance

In 27e8c39, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 96 ms

Resolved: Processors performance has improved in ca3c420.


made changes in deletion logic in server.js, Manager.jsx

solves issue #128
made changes in code to effectively perform the selective deletion of passwords

@jindalpriyanshu101 @jinx-vi-0 kindly review my PR and provide the labels


Code workflow

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: rai69 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


warnings.warn("Mean of empty slice.", RuntimeWarning)

would that be possible to remove this message during testing?
see here:
https://travis-ci.org/neuropoly/spinalcordtoolbox/jobs/125891232

likely coming from numpy.mean in test_sct_register_graymatter:
https://github.com/gregversteeg/CorEx/issues/1

yes-- confirmed: it comes from the test:
        result_dice_wm = mean(wm_dice_list)
        result_diff_dc_wm = mean(wm_diff_list)
        result_dice_gm = mean(gm_dice_list)
        result_diff_dc_gm = mean(gm_diff_list)
        result_hausdorff = mean(hausdorff_list)
        result_diff_hd = mean(hd_diff_list)
        result_median_dist = mean(max_med_list)
        result_diff_md = mean(md_diff_list)

Ok ! Good to know, I'll try to remove the warning in the testing.

already done it!
i'll push soone


Update FHIR test server

The old one is down, has a DNS issue according to James. This one runs faster anyway, so updating.

+1 on Slack


Update module with isolated functions

Description:
Need to update the module with isolated functions.
Reference: https://docs.google.com/document/d/1FDmIdHD80zxVZ-N_ZT-JycME64cAzeR2-34L-9hdqvo/edit#heading=h.l1e2xwmokh4f

Fixed with https://github.com/ballerina-platform/module-ballerina-encoding/pull/20


Installation

Hi,
Can you explaine steps No.5 and N0.6?
Where is repo folder? You mean dotenv folder under lib folder?
Creating .env file with which name and to where?

By repo folder i meant the root folder of the project. There's no dotenv folder or lib folder.
The .env file should be named .env and put in the root folder of the project.

Thanks for explanation but its not letting make file .env (without a file name)
I made bot.env and then tried to rename file (delete file name) but can not save the file after deleting its name

If you're using windows, try following this
https://stackoverflow.com/questions/5004633/how-do-i-manually-create-a-file-with-a-dot-prefix-in-windows-for-example

Worked now. Thanks alot


go lanuage

I want to add go language in your repo and want to implement a ds in it.

Ok, I am assigning this issue to you

Done


Merge nodelet upstream

Hi, I think the contributions you did to this code are useful (specially the nodelet version of the driver). Are you guys planning to contribute it upstream? Or is there something that is specific for your robots?

Would like to, and we were originally pushing everything upstream. They were quite slow on catching PR's though, and we had changes piling up, so we need to de-spaghettifi things and hope they move faster on PR's.
Just need to find a window in which our intern can sort this out, but that won't be for a month at least. Feel free to use this repo or pull the commit(s) and upstream it yourself in the meantime.
Just to note...the bugfix in f30f22505 is probably the most important one. Occasionally the assumption that the device sends 360 pieces of data breaks, and without that, the node will regularly crash and burn.

Thanks for the quick reply! Yeah, I saw that they seem to be slow checking the PRs. For sure I will use your code in the meanwhile, thanks!  (I guess we can close the issue).


add CODEOWNERS

This repo is a collection of TBD examples from across our github. Most of them didn't have codeowners, so I've had to guess who was a good contact for each one. If you're listed, please let me know if you are a good codeowner for that example and if there should be any additional codeowners for it. I'll merge when I get confirmation from everyone.

[ ] javascript/book-reviews @acekyd
[ ] javascript/dinger @blackgirlbytes - note this is the code from the examples folder in developer.tbd.website, not TBD54566975/dinger.
[ ] javascript/dinger-starter @blackgirlbytes
[x] javascript/fan-club-credential @nitro-neal
[x] javascript/kcc-prototype-exemplar @KendallWeihe
[x] javascript/pfi-aud-usd-tbdex @michaelneale
[ ] javascript/pfi-guide-example @chris-tbd
[ ] javascript/shared-todo @acekyd
[ ] javascript/shared-todo-starter @acekyd
[x] javascript/tbdex-pfi-exemplar @michaelneale
[ ] javascript/todo @acekyd @blackgirlbytes
[ ] javascript/todo-starter @acekyd @blackgirlbytes
[x] kotlin/tbdex-example-android @michaelneale
[x] swift/tbdex-example-ios - @kirahsapong

@finn-tbd I checked myself on them - but can we add a few others from the commit history?

For sure, I'm not seeing a lot of other committers for most of the ones you're a on @michaelneale but tbdex-pfi-exemplar seems to actually have it's own CODEOWNERS file that I missed, so I've copied everyone from there into here. Also added @jiyoontbd to tbdex-example-android

at what point do we move examples to this repo vs maintain in others?

Should be good to start doing that any time, I was going to start doing that next week. I'm planning to submit a PR to each of the other repos wiping out all files and replacing the README with a short message linking to the new location.

I agree with this. I think you can add me as an additional code owner for javascript/fan-club-credential

LGTM!

Thanks all!


Fix formatting

These raw tags are causing the Type Doc to get cut off.

That's unfortunate. Is there a way to mark code in comments that doesn't cause problems?


Disable Implicit Cast of Varchar to Int in Multi-Stage engine

Apache Calcite allows implicit cast from VARCHAR to INT. The implicit cast may surprise users with a Runtime Exception if some of the rows cannot be parsed or to unexpected results if parsing is unintentionally successful.
As the intention is to keep the multi-stage engine strongly typed, this PR disables implicit casts from VARCHAR to INT.
Postgres also does not allow this implicit cast.
postgres=# select * from str;
 str
-----
 1
 a
 100
(3 rows)

postgres=# select * from str where str > 10;
ERROR:  operator does not exist: character varying > integer
LINE 1: select * from str where str > 10;
                                    ^
HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.

tags: multi-stage, release notes

Codecov Report
Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 27.72%. Comparing base (59551e4) to head (db5a17d).
Report is 782 commits behind head on master.

Files
Patch %
Lines

...he/pinot/query/validate/PinotTypeCoercionImpl.java
0.00%
29 Missing :warning:

...ava/org/apache/pinot/query/validate/Validator.java
0.00%
3 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (db5a17d). Click for more details.
HEAD has 53 uploads less than BASE

Flag
BASE (59551e4)
HEAD (db5a17d)

integration
7
0

integration2
3
0

temurin
12
1

java-21
7
1

skip-bytebuffers-true
3
1

skip-bytebuffers-false
7
0

unittests
5
1

unittests1
2
0

java-11
5
0

unittests2
3
1

integration1
2
0

custom-integration1
2
0

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #13650       +/-   ##
=============================================
- Coverage     61.75%   27.72%   -34.03%
+ Complexity      207      192       -15
=============================================
  Files          2436     2554      +118
  Lines        133233   140500     +7267
  Branches      20636    21858     +1222
=============================================
- Hits          82274    38958    -43316
- Misses        44911    98553    +53642
+ Partials       6048     2989     -3059

Flag
Coverage Δ

custom-integration1
?

integration
?

integration1
?

integration2
?

java-11
?

java-21
27.72% <0.00%> (-33.90%)
:arrow_down:

skip-bytebuffers-false
?

skip-bytebuffers-true
27.72% <0.00%> (+<0.01%)
:arrow_up:

temurin
27.72% <0.00%> (-34.03%)
:arrow_down:

unittests
27.72% <0.00%> (-34.02%)
:arrow_down:

unittests1
?

unittests2
27.72% <0.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

What is the postgreSQL behavior on this query?
This is backward incompatible, and we need to be careful here

What is the postgreSQL behavior on this query? This is backward incompatible, and we need to be careful here

Postgres behaviour is described in the description.  This PR makes it similar to PG. Some more info on my investigation:
Implicit conversion table of Calcite is in SQL language  It specifically states that string → int is an implicit conversion. This is different from PG. Char/Varchar → integer requires an explicit cast. The implicit conversions in PG can be seen with the following query:
SELECT casttarget::regtype AS target_type
     , castsource::regtype AS source_type
     , castcontext
FROM   pg_cast
WHERE  castcontext IN ('i', 'a')
ORDER  BY 1, 2;

I agree about being careful on breaking backward compatibility. One option is to add a flag for changes that make multi-stage strongly-typed. Has there been any discussions on flags to help move towards ANSI/PG SQL compatability?

So... what should we do with this PR? Merge it or close it?


Fix "clone" action with ScopeTypeTarget

Fixes https://github.com/cursorless-dev/cursorless/issues/1691
Fixes https://github.com/cursorless-dev/cursorless/issues/1959
Also strengthens typing for clone args even more cc/ @auscompgeek

Checklist

[ ] I have added tests
[ ] I have updated the docs and cheatsheet
[ ] I have not broken the cheatsheet

quick one @AndreasArvidsson


i dont know what the Error

I update the changes because the folder users created automatic and  10 seconds later delete hmm

Hmmm, I am not sure how you are getting this since there is no method in the project that deletes users. Could you provide more information?

When i create a account , i can upload the picture the folder in firebase succesfull create , because when you login the folder automatic Delete

Fixed it in last commit! Can you test it to confirm it works now?

Good moring from Austria , Yes the last changes fixed the Problem
Thank you very much