Fix Chakra Converter Handling of NCCL All-to-All, Logging Consistency, and HTA Dependency Issues

Summary
This PR addresses multiple issues in the Chakra converter:
1. Improper Handling of NCCL All-to-All Communication
Chakra incorrectly distinguishes between point-to-point and collective communication. In NCCL, all-to-all is implemented as point-to-point communication, but Chakra's current logic treats these as distinct, leading to an incorrect type for PyTorchNode. More details on NCCL point-to-point can be found here.
2. Logging Inconsistency
There was a mismatch in logging levels: sync dependencies log via logging.info, while other dependencies use logging.debug. This PR resolves the inconsistency by standardizing the logging approach.
3. False Positive Dependencies from HTA
HTA returns false positives for sync dependencies, leading to invalid later op -> earlier op dependencies. This causes Chakra to fail in certain traces. The Chakra converter was found to encounter two critical failures:

Cycle dependencies
Stack overflows (due to call stacks exceeding 1000 levels)

4. Support for PyTorch >2.5.0 and Updated Chakra Schema
The nightly version of PyTorch >2.5.0 appears to require support for schema version 1.1.1-chakra.0.0.4.
Updated Chakra to include the most recent schema version in its supported list.
5. Update trace_linker to use external_id for finding GPU op's parent CPU op
There were many operations matched with wrong parent CPU during trace linking.
This PR solves this problem using external_id instead of ev_idx.
6. Handling HTA Errors in Chakra
The trace linker was terminating unexpectedly due to errors in HTA. Although this may stem from trace inconsistencies, the issue does not occur when HTA is excluded.
Updated Chakra to handle these errors by raising exceptions instead of terminating the trace linker.
7. Proper Encoding of pg_name in Collective Operations
Identified an issue where SendRecv, Reduce-Scatter and All-Gather operations do not correctly encode pg_name following updates on the PyTorch side.
Modified Chakra to ensure proper encoding of pg_name in these collective operations.
Test Plan
I tested the fixes using Mixtral 8x3B traces collected with the NeMo framework (NVIDIA).
traces_device_0.zip
#!/bin/bash
# Set the result path
PATH="~/scratch/results/mixtral_8x3b/results"

# Loop through trace ranks
for i in 0
do
    echo "Start linking trace: $i"
    chakra_trace_link \
        --chakra-host-trace $PATH/host_$i.json \
        --chakra-device-trace $PATH/device_$i.json  \
        --rank $i \
        --output-file $PATH/rank_$i.json

    echo "Start converting trace: $i"
    chakra_converter PyTorch \
        --input $PATH/rank_$i.json \
        --output $PATH/rank_$i.et
done

Hi, please feel free to review this PR.
Thank you!

Hi @srinivas212 and @tushar-krishna .
Who would be the best person to ask for a review?

Hi @srinivas212 and @tushar-krishna . Who would be the best person to ask for a review?

This PR should be refined with recently accpeted PR (https://github.com/mlcommons/chakra/pull/145)


SvelteKit Home Page Is Unprofessional

The UI and UX design, alignment, and contents of sveltekit's welcoming page or home page are unprofessional and not in sync with modern design rules and standards.
Please address this issue and make a deadline for it, as it damages SvelteKit's brand image and marketing.

Closing ad this feedback is too vague and unactionable


UserMap Workbook not identifying Location Details

Describe the bug
Customer reported and demoed that using the "UserMap" workbook is not able to show data on the two map graphics that the workbook contains. In the Workbook's Map Settings the latitude and longitude fields are not translating into data points on the map. To get the maps showing data points I had to rename the final variables for latitude and longitude and re run the query, which then yielded the results:
1st Map: Variables are {lat & lon} changed to {latitude & longitude}
2nd Map: Variables are {latitude_ & longitude_} changed to {latitude & longitude}
To Reproduce
Steps to reproduce the behavior:

Go to 'UserMap' workbook
View malicious events map and user sign in maps
Observe error that says "Location Details missing"
See error

Expected behavior
The variables defined in the workbook and listed in the map settings should load latitude and longitude data points on the two maps
Additional context
Two customers have expressed that they had the issue and the renaming of the variables fixed both

Acknowledged, a new version, that fixes this is almost done, as well as a full update and extra views. I'm just testing and adding to the help content.

Thanks Clive!

Fixes and new features / and a general update have been added to: https://github.com/Azure/Azure-Sentinel/pull/980

Closing as updates have been added


Fixing validators - they need to be able to deal with partially created validation rules

What
I noticed that if you leave a validation rule partially created in the author application and then try to view it in survey runner you end up with an internal server error.
How to test

Create a survey with a partially completed validation rules
Check you can answer the question

Who can review
Anyone apart from @warren-methods

LGTM :+1:


Crowbar, Wrench, Welder inhand

Adds inhand sprites for Crowbar, Red Crowbar, Wrench, and Welder.
Welder in hand flame not working while I fix it.

inhand welder sprites now work


Mouse highlighter problem

Microsoft PowerToys version
0.51.0
Running as admin

[X] Yes

Area(s) with issue?
Mouse Utilities
Steps to reproduce
Clicking mouse buttons too fast will result on the mouse highlighter to bug out and will not disappear until you turn off the feature.
✔ Expected Behavior
I expect the highlights to slowly fade away after a few milliseconds like all of the other slow mouse clicks that i did.
❌ Actual Behavior
Explained in "Steps to reproduce".

Other Software
No response

cc: @jaimecbernardo

How fast is this? I've tried to replicate without success.
Can anyone else replicate this?
Could you please send a bug report?
Right-click on the PowerToys icon in the tray menu and select Report Bug

Drag and drop report into a GitHub comment.

Also it works normal if it isn’t rapid clicks?  Getting the zip should tell us settings too. Wondering if there is a super high timeout.


How to Implement For Multipal source

Hi I Have mutlipal object
Student,
Employee
Staff
let Student= { userid: 1, UserName: 'Karangoswami', IsAutheticate: false };
let gallary =[];
then how to implement in-memeory web Api

return {student,Employee, Staff} in createDb() function.
Example https://github.com/xmlking/hub/blob/master/src/app/core/services/in-memory-data.service.ts

Thanks @xmlking , this works great!

Great Help. Thanks.


Datadog agent setup failed

Orb version:

orbs:
datadog-agent: datadog/agent@0
What happened:

datadog-agent/setup -  failed

Expected behavior:

datadog-agent should be started successfully
Additional Information:

Fail happened on 21 and 22 Dec 2021.
I am using datadog-agent as suggested in
https://circleci.com/developer/orbs/orb/datadog/agent
version: 2.1

orbs:
  datadog-agent: datadog/agent@0

steps:
  - datadog-agent/setup
  - run:
          name: Running tests
          command: |
          run tests
 - datadog-agent/stop

Hello @galunik, sorry to hear that you are having trouble. Would you mind providing the following information:

OS the agent is running on (currently we only support Ubuntu and Debian based systems)
Version of the orb being used

Hello !
We are using Ubuntu
Orb version  datadog/agent@0

Would you mind giving the latest version (3.1.1) a try and see if that one works?

Yeah, I’ve already updated the orb version.
This error appeared twice , so I return to you if I see this error again.( with updated orb version)
Thanks for you quick response !

Sorry to ask for more details could you let me know what version of Ubuntu exactly it is?

Yes, of course
Operating System: Ubuntu 20.04.3 LTS

I have tried and reproduce it in a 20.04.03 LTS but can't. Is it possible that the CI machine cannot reach the URL https://s3.amazonaws.com/dd-agent/scripts/install_script.sh.
Could you cURL that URL from the CI machine/container to confirm it can properly retrieve the output?

@cg14823
Hi!
I was able to run curl  from Ci  and datadog agent was installed properly.


Write a Kotlin program to find the maximum sum of a contiguous subarray (circular)

Description
Write a Kotlin program to find the maximum sum of a contiguous subarray (circular)
Maximum sum of a circular subarray is the task of finding the contiguous subarray within a circular one-dimensional array of numbers which has the largest sum. For example, for the sequence of values 10, -3, -4, 7, 6, 5, -4, -1; the contiguous subarray with the largest sum is 7, 6, 5, with sum 18.
Input  : [8, -8, 9, -9, 10, -11, 12]
Output : 22

How to contribute

Save the solution in program/FindTheMaximumSumOfAContiguousSubarray(circular).kt file
Add FindTheMaximumSumOfAContiguousSubarray(circular).kt file in find-the-maximum-sum-of-a-contiguous-subarray-(circular) folder

!assign


FatalErrorException when trying to assemble chunks

Hi,
I get Error: Call to a member function getPathname() on a non-object in Oneup/UploaderBundle/Uploader/Chunk/Storage/FilesystemStorage.php @ 68 for $base->getPathname()
I suspect there is an error in my filesystem-config, but i can't find it.
My config looks like this
oneup_uploader:
    chunks:
        storage:
            directory:     %kernel.cache_dir%/videos/chunks/
    mappings:
        videos:
            frontend:           fineuploader
            storage:
                 directory:      %kernel.cache_dir%/videos/

Please help @bytehead , thank you!

I've found a solution to the error, it seems to be a Bug; see the pull-request below:
#270

I don't know whether this is related. But ever since upgrading to PHP7 I get an error uploading large files. Apparently no EX_LOCK can be obtained on the file while reassembling the chunks.

Uncaught PHP Exception RuntimeException: "Reassembling chunks failed." at .../vendor/oneup/uploader-bundle/Oneup/UploaderBundle/Uploader/Chunk/Storage/FilesystemStorage.php line 69

@zelding I think your issue is related to the Symfony version you use. I had the same error as you with Symfony 2.7.1. Then, I've seen the fix in issue #190 which removes what you suggest (cf. your PR #270) to fix your issue. So I've updated to Symfony 2.7.5 and it works now as it should.


TypeError exception when handleExceptions: true

When I use winston-console-formatter with winston.transports.Console and handleExceptions: true, I get the following error:
.../winston-console-formatter/dist/utils.js:14
  return clc.magenta('\n  ' + stackTrace.replace(/(\r\n|\n|\r)/gm, '$1  '));
                                         ^

TypeError: stackTrace.replace is not a function
    at Object.getStackTrace (.../winston-console-formatter/dist/utils.js:14:42)
    at Object.formatter (.../winston-console-formatter/dist/index.js:32:31)
    at Object.exports.log (.../winston/lib/winston/common.js:218:27)
    at Console.log (.../winston/lib/winston/transports/console.js:99:19)
    at Transport.logException (.../winston/lib/winston/transports/transport.js:134:8)
    at logAndWait (.../winston/lib/winston/logger.js:649:15)
    at .../async/lib/async.js:157:13
    at _each (.../async/lib/async.js:57:9)
    at Object.async.each (.../async/lib/async.js:156:9)
    at Logger._uncaughtException (.../winston/lib/winston/logger.js:672:9)

To reproduce:
const winston = require('winston');
const toYAML  = require('winston-console-formatter');

const {timestamp, formatter} = toYAML.config();

const logger = new winston.Logger({
  level: 'silly'
});

logger.add(winston.transports.Console, {
  timestamp,
  formatter,
  handleExceptions: true,
});

throw 'My exception';

This is using Node 6.11.0 and winston-console-formatter 0.27.5.
I was able to fix this by making the following change:
in src/utils.js at line 12
return clc.magenta('\n  ' + String(stackTrace).replace(/(\r\n|\n|\r)/gm, '$1  '));

I can pull-request this if it helps.

In creating tests for the proposed fix above, I did more research into what values the options.meta.stack and options.meta.trace variables have when passed into formatter(options). In doing so, I realized that simply converting stackTrace to a string, while it avoids the error, is not the best solution to this problem.
It appears that stack is an array of strings, each corresponding to one line of the human-readable stack normally displayed in console. Trace, on the other hand, is an array of objects, each of which contains information that can be used to recreate the stack display (calling function, source file, line and column). When stack is missing (for whatever reason), a recreation of the stack display is what (I assume) we ultimately want.
So I think a better solution might be to modify index.js line 39: utils.getStackTrace(stack || trace) and utils.getStackTrace to utils.getStackTrace(stack, trace) and the following for utils.getStackTrace:
/**
 * @param {[strings...]|undefined} stack
 * @param {[callbacks...]|undefined}
 * @returns {string}
 */
function getStackTrace (stack, trace) {
  let msg;
  if (stack && stack.length) {
    msg = '\n  ' + stack.join('\n  ');
  }
  else if (trace && trace.length) {
    const lines = trace.map((i) => {
      const fnString = i.function ? `${i.function} ` : '';
      return `at ${fnString}(${i.file}:${i.line}:${i.column})`;
    });
    msg = '\n  ' + lines.join('\n    ');
  }
  return msg ? clc.magenta(msg) : '';
}

This function basically either prints the stack trace (restoring line breaks) as it is if it exists, or recreates as much of this message as it can from the trace if it does not exist.
If this solution seems better than the original one, I will kill the original pull request and create a new one. I also have tests for the above case to submit as well.
See the master branch of my fork.


Provide status heartbeat while a session is running.

To allow simple integration with other tools, a running session should provide a periodic update of its status in some easily usable form.
The simplest case is to report the current running state to a status file as a heartbeat on some regular interval.
Any obvious progress indicators or error conditions should be added to the data in the heartbeat.
The implementation of this should rely on the component API, allowing components to delegate heartbeat details where needed. Each component type which is significant to users in terms of status or error should be included.
Initially, a yaml file which contains basic metadata for those key component is all that is needed.
Upon termination of the session, key status details must be reported in a final heartbeat, including in the case of a SIGINT. The reporting interval for the heartbeat should also be included in the metadata so that any observers can easily detect a stale heartbeat.
The initial reporting interval shall be every minute.

complete in main


[PE-D] "addt" allows to add task with no deadline contrary to UG

When doing addt, you can add a task with no deadline even though UG claims otherwise.

Relevant excerpt from UG: t/DEADLINE not marked as optional.

Labels: severity.Medium type.FunctionalityBug
original: medajet/ped#3

Documentation bug. Thanks for pointing out!

Fixed


Powertoys in combination with groupy does not work properly.

Current situation

How it should be

I hope you can see what the issue is.
Normally I swith a lot between programs with groupy and without so it is annoying that I still have to resize the top of the window everytime I move it.

Hi @Pascal0997
thank you for reporting the issue, this will be fixed in the next release.
We are tracking the problem in https://github.com/microsoft/PowerToys/issues/2533
I'll close this one as duplicate.
Thank you.


User is navigated to dashboard page when navigating to https://<rancher-server>

On master-head - commit id: 89dd0fe25a1

Navigate to https://<rancher-server>
User is directed to Dashboard UI and an error is seen on the console
Error:

client.js:626 Error: Redirected when going from "/" to "/clusters" via a navigation guard.
    at $t (vue-router.esm.js:1958)
    at kt (vue-router.esm.js:1917)
    at vue-router.esm.js:2266
    at $n.d (client.js:236)
    at regeneratorRuntime.mark.regeneratorRuntime.wrap.n.context.n.context.redirect (utils.js:183)
    at Object.fetch (index.vue:9)
    at client.js:407
    at d (runtime.js:45)
    at Generator._invoke (runtime.js:274)
    at Generator.O.forEach.t.<computed> [as next] (runtime.js:97)

@sowmyav27 I'm unable to reproduce this. How did you get here?

@deniseschannon type/copy and paste `https:// in webpage and hit enter. check console to see the error.

Updated the title.
If you're already logged in and later come back to <server_url>, you automatically get re-directed to dashboard even though no cluster view preference is selected.

The error in the console is not really a problem and has no consequence.  We will try to get rid of it eventually because it's annoying, but forget about it for testing.
Directing the root path to one UI vs the other is done by the API, not the UIs.  You can't have "no preference" though so it's not clear anything is wrong here? It has to go to one or the other.
The desired behavior is:

If the authenticated user has a landing preference of their own set, use that.
Use the value from the install-wide ui-default-landing setting.
In the initial setup screen, ui should set both the admin user's pref and the global setting to the option they pick


Travis: fix a 'file exists?' check

Signed-off-by: David Wagner<EMAIL_ADDRESS>

This pull request is now managed with CodeReviewHub. Refresh.

 Last update 2d3518f...812f066


Update forms.py - email field

Just the email field.
Tested and working.

I'm closing this as there has been no response from the original author for over 1 year.

It has been one year...
The project I had with django-paypal stalled. I don't had or will have time for unit tests, sorry.
I understand  your obsession with unit tests, I have it too. Nevertheless, it is just a plain, django, overly tested by django team, email field.
Cheers.

Sure, it is a simple field, but I don't know what it is there for, or why it is needed. Everyone else seems to be able to use the code as it is, so I'm assuming it's not required.
Looking into it, the PayPalPro helper has a hook, paypal_form_cls, that allows you to provide a different form. Therefore, I'd prefer to keep it as it is, rather than spring a change on existing users who don't need the email field.


Is it possible to disable dashboard and make any other page as default one?

Hello. Is it possible to disable dashboard and make any other page as default one?

You can add custom pages, and I guess you can decorate the router to intercept the / route. But there is no built-in way.

To do it had to create another module, configure $urlRouterProvider and add it as dependency to main module before nd-admin...
angular
    .module("app.before", ["ui.router"])
    .config(function($urlRouterProvider) {
        $urlRouterProvider.when('', '/another-page');
    });

angular
    .module("app", ["app.before", "ng-admin"])
```

I think it make sense to make it configurable

To do it had to create another module, configure $urlRouterProvider and add it as dependency to main module before nd-admin...
angular
    .module("app.before", ["ui.router"])
    .config(function($urlRouterProvider) {
        $urlRouterProvider.when('', '/another-page');
    });

angular
    .module("app", ["app.before", "ng-admin"])
```

I think it make sense to make it configurable

Your solution is fine, and making it configurable is hard (because of the sequence of Angular's configuration execution).

this works great, in case we want to make it configurable, we could just customize the otherwise (ui.router) of ng-admin, or hook into start event and do a redirect ? just a thought.


Add support for E-field beams to az_za_to_Healpix

This requires #280

Doesn't really require #280.  We can come back to that problem later.


Facing issue - Another Amqp client opened a receiver link and AmqpLinkDetachForcedException: Server Busy. Please retry operation

Hi Team,
I am facing below issue in sandbox environment
ERROR c.m.a.s.i.d.t.a.AmqpsIotHubConnection.onSessionClosedUnexpectedly - Amqp session closed unexpectedly. Closing this connection...
com.microsoft.azure.sdk.iot.device.transport.amqps.exceptions.AmqpInternalErrorException: Another AMQP Client has opened a Receive Link

For same code I am getting different issue in Production environment
ERROR c.m.a.s.i.d.t.a.AmqpsIotHubConnection.onCBSSessionClosedUnexpectedly - Amqp CBS session closed unexpectedly. Closing this connection...
com.microsoft.azure.sdk.iot.device.transport.amqps.exceptions.AmqpLinkDetachForcedException: Server Busy. Please retry operation

what could be the reason for the above issues.
Any suggestions/guidance will be really helpful.
Thanks.

@Sivaprakash1981 Please help with the link of document on which above document feedback request is created.
Under this repository we want to make sure any issue is linked to a doc so we can help others that may be having the same issue.

@Sivaprakash1981 We try to reserve these issues for feedback directly related to the tutorials: like if there are errors that block tutorial completion or if there are updates/changes required, suggestions for improvement, etc. If this is not the case I would suggest you, open an issue with your question on the Microsoft QnA with appropriate tag where there is a community that can help (plus the engineering team)
Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly reopen the issue and continue the discussion.


1.1.1c/d No pdb files are generated for .exe files when using no-shared

When configuring with no-shared and building with nmake, no pdb files are generated for .exe files. Therefore nmake install fails when trying to install those files. I'm using strawberry perl.
I'm building with 1.1.1c and 1.1.1d, but both fail for the same reason. The below configuration dump is for 1.1.1d.
Command line (with current working directory = .):

    C:\Perl\perl\bin\perl.exe Configure no-shared VC-WIN64A-masm

Perl information:

    C:\Perl\perl\bin\perl.exe
    5.28.2 for MSWin32-x64-multi-thread

Enabled features:

    aria
    asm
    async
    autoalginit
    autoerrinit
    autoload-config
    bf
    blake2
    buildtest-c\+\+
    camellia
    capieng
    cast
    chacha
    cmac
    cms
    comp
    ct
    deprecated
    des
    dgram
    dh
    dsa
    dtls
    ec
    ec2m
    ecdh
    ecdsa
    engine
    err
    filenames
    gost
    hw(-.+)?
    idea
    makedepend
    md4
    mdc2
    multiblock
    nextprotoneg
    pinshared
    ocb
    ocsp
    pic
    poly1305
    posix-io
    psk
    rc2
    rc4
    rdrand
    rfc3779
    rmd160
    scrypt
    seed
    siphash
    sm2
    sm3
    sm4
    sock
    srp
    srtp
    sse2
    ssl
    static-engine
    stdio
    tests
    threads
    tls
    ts
    ui-console
    whirlpool
    tls1
    tls1-method
    tls1_1
    tls1_1-method
    tls1_2
    tls1_2-method
    tls1_3
    dtls1
    dtls1-method
    dtls1_2
    dtls1_2-method

Disabled features:

    afalgeng                [not-linux]
    asan                    [default]   OPENSSL_NO_ASAN
    crypto-mdebug           [default]   OPENSSL_NO_CRYPTO_MDEBUG
    crypto-mdebug-backtrace [default]   OPENSSL_NO_CRYPTO_MDEBUG_BACKTRACE
    devcryptoeng            [default]   OPENSSL_NO_DEVCRYPTOENG
    dynamic-engine          [cascade]
    ec_nistp_64_gcc_128     [default]   OPENSSL_NO_EC_NISTP_64_GCC_128
    egd                     [default]   OPENSSL_NO_EGD
    external-tests          [default]   OPENSSL_NO_EXTERNAL_TESTS
    fuzz-libfuzzer          [default]   OPENSSL_NO_FUZZ_LIBFUZZER
    fuzz-afl                [default]   OPENSSL_NO_FUZZ_AFL
    heartbeats              [default]   OPENSSL_NO_HEARTBEATS
    md2                     [default]   OPENSSL_NO_MD2 (skip crypto\md2)
    msan                    [default]   OPENSSL_NO_MSAN
    rc5                     [default]   OPENSSL_NO_RC5 (skip crypto\rc5)
    sctp                    [default]   OPENSSL_NO_SCTP
    shared                  [option]
    ssl-trace               [default]   OPENSSL_NO_SSL_TRACE
    ubsan                   [default]   OPENSSL_NO_UBSAN
    unit-test               [default]   OPENSSL_NO_UNIT_TEST
    weak-ssl-ciphers        [default]   OPENSSL_NO_WEAK_SSL_CIPHERS
    zlib                    [default]
    zlib-dynamic            [default]
    ssl3                    [default]   OPENSSL_NO_SSL3
    ssl3-method             [default]   OPENSSL_NO_SSL3_METHOD

Config target attributes:

    AR => "lib",
    ARFLAGS => "/nologo",
    AS => "ml64",
    ASFLAGS => "/nologo /Zi",
    CC => "cl",
    CFLAGS => "/W3 /wd4090 /nologo /O2",
    CPP => "\$(CC) /EP /C",
    HASHBANGPERL => "/usr/bin/env perl",
    LD => "link",
    LDFLAGS => "/nologo /debug",
    MT => "mt",
    MTFLAGS => "-nologo",
    RANLIB => "CODE(0xd34088)",
    RC => "rc",
    aes_asm_src => "aes_core.c aes_cbc.c vpaes-x86_64.s aesni-x86_64.s aesni-sha1-x86_64.s aesni-sha256-x86_64.s aesni-m
b-x86_64.s",
    aes_obj => "aes_core.o aes_cbc.o vpaes-x86_64.o aesni-x86_64.o aesni-sha1-x86_64.o aesni-sha256-x86_64.o aesni-mb-x8
6_64.o",
    apps_aux_src => "win32_init.c",
    apps_init_src => "",
    apps_obj => "win32_init.o",
    aroutflag => "/out:",
    asflags => "/c /Cp /Cx",
    asoutflag => "/Fo",
    bf_asm_src => "bf_enc.c",
    bf_obj => "bf_enc.o",
    bin_cflags => "/Zi /Fdapp.pdb /MT",
    bin_lflags => "/subsystem:console /opt:ref",
    bn_asm_src => "bn_asm.c x86_64-mont.s x86_64-mont5.s x86_64-gf2m.s rsaz_exp.c rsaz-x86_64.s rsaz-avx2.s",
    bn_obj => "bn_asm.o x86_64-mont.o x86_64-mont5.o x86_64-gf2m.o rsaz_exp.o rsaz-x86_64.o rsaz-avx2.o",
    bn_ops => "EXPORT_VAR_AS_FN SIXTY_FOUR_BIT",
    build_file => "makefile",
    build_scheme => [ "unified", "windows", "VC-common" ],
    cast_asm_src => "c_enc.c",
    cast_obj => "c_enc.o",
    cflags => "/Gs0 /GF /Gy",
    chacha_asm_src => "chacha-x86_64.s",
    chacha_obj => "chacha-x86_64.o",
    cmll_asm_src => "cmll-x86_64.s cmll_misc.c",
    cmll_obj => "cmll-x86_64.o cmll_misc.o",
    coutflag => "/Fo",
    cppflags => "",
    cpuid_asm_src => "x86_64cpuid.s",
    cpuid_obj => "x86_64cpuid.o",
    defines => [ "OPENSSL_SYS_WIN32", "WIN32_LEAN_AND_MEAN", "UNICODE", "_UNICODE", "_CRT_SECURE_NO_DEPRECATE", "_WINSOC
K_DEPRECATED_NO_WARNINGS" ],
    des_asm_src => "des_enc.c fcrypt_b.c",
    des_obj => "des_enc.o fcrypt_b.o",
    disable => [  ],
    dso_cflags => "/Zi /Fddso.pdb",
    dso_extension => ".dll",
    dso_scheme => "win32",
    ec_asm_src => "ecp_nistz256.c ecp_nistz256-x86_64.s x25519-x86_64.s",
    ec_obj => "ecp_nistz256.o ecp_nistz256-x86_64.o x25519-x86_64.o",
    enable => [  ],
    ex_libs => "ws2_32.lib gdi32.lib advapi32.lib crypt32.lib user32.lib",
    exe_extension => "",
    includes => [  ],
    keccak1600_asm_src => "keccak1600-x86_64.s",
    keccak1600_obj => "keccak1600-x86_64.o",
    ldoutflag => "/out:",
    lflags => "",
    lib_cflags => "/Zi /Fdossl_static.pdb /MT /Zl",
    lib_cppflags => "",
    lib_defines => [ "L_ENDIAN" ],
    md5_asm_src => "md5-x86_64.s",
    md5_obj => "md5-x86_64.o",
    modes_asm_src => "ghash-x86_64.s aesni-gcm-x86_64.s",
    modes_obj => "ghash-x86_64.o aesni-gcm-x86_64.o",
    module_cflags => "",
    module_cxxflags => "",
    module_ldflags => "/dll",
    mtinflag => "-manifest ",
    mtoutflag => "-outputresource:",
    padlock_asm_src => "e_padlock-x86_64.s",
    padlock_obj => "e_padlock-x86_64.o",
    perlasm_scheme => "masm",
    poly1305_asm_src => "poly1305-x86_64.s",
    poly1305_obj => "poly1305-x86_64.o",
    rc4_asm_src => "rc4-x86_64.s rc4-md5-x86_64.s",
    rc4_obj => "rc4-x86_64.o rc4-md5-x86_64.o",
    rc5_asm_src => "rc5_enc.c",
    rc5_obj => "rc5_enc.o",
    rcoutflag => "/fo",
    rmd160_asm_src => "",
    rmd160_obj => "",
    sha1_asm_src => "sha1-x86_64.s sha256-x86_64.s sha512-x86_64.s sha1-mb-x86_64.s sha256-mb-x86_64.s",
    sha1_obj => "sha1-x86_64.o sha256-x86_64.o sha512-x86_64.o sha1-mb-x86_64.o sha256-mb-x86_64.o",
    shared_cflag => "",
    shared_defines => [  ],
    shared_extension => ".dll",
    shared_extension_simple => ".dll",
    shared_ldflag => "/dll",
    shared_rcflag => "",
    shared_target => "win-shared",
    sys_id => "WIN64A",
    thread_defines => [  ],
    thread_scheme => "winthreads",
    unistd => "<unistd.h>",
    uplink_aux_src => "",
    uplink_obj => "",
    wp_asm_src => "wp-x86_64.s",
    wp_obj => "wp-x86_64.o",

Recorded environment:

    AR =
    ARFLAGS =
    AS =
    ASFLAGS =
    BUILDFILE =
    CC =
    CFLAGS =
    CPP =
    CPPDEFINES =
    CPPFLAGS =
    CPPINCLUDES =
    CROSS_COMPILE =
    CXX =
    CXXFLAGS =
    HASHBANGPERL =
    LD =
    LDFLAGS = /nologo
    LDLIBS =
    MT =
    MTFLAGS =
    OPENSSL_LOCAL_CONFIG_DIR =
    PERL =
    RANLIB =
    RC =
    RCFLAGS =
    RM =
    WINDRES =
    __CNF_CFLAGS =
    __CNF_CPPDEFINES =
    __CNF_CPPFLAGS =
    __CNF_CPPINCLUDES =
    __CNF_CXXFLAGS =
    __CNF_LDFLAGS =
    __CNF_LDLIBS =

Makevars:

    AR              = lib
    ARFLAGS         = /nologo
    AS              = ml64
    ASFLAGS         = /nologo /Zi
    CC              = cl
    CFLAGS          = /W3 /wd4090 /nologo /O2
    CPP             = $(CC) /EP /C
    CPPDEFINES      =
    CPPFLAGS        =
    CPPINCLUDES     =
    CXXFLAGS        =
    HASHBANGPERL    = /usr/bin/env perl
    LD              = link
    LDFLAGS         = /nologo
    LDLIBS          =
    MT              = mt
    MTFLAGS         = -nologo
    PERL            = C:\Perl\perl\bin\perl.exe
    RANLIB          = ranlib
    RC              = rc
    RCFLAGS         =

NOTE: These variables only represent the configuration view.  The build file
template may have processed these variables further, please have a look at the
build file for more exact data:
    makefile

build file:

    makefile

build file templates:

    Configurations\common0.tmpl
    Configurations\windows-makefile.tmpl
    Configurations\common.tmpl

That's...  weird.  I can't see anything in the makefile generation code that would prevent PDB generation with that configuration...

Same problem here. We need to use no-shared option because then it will build with /MT flag. But we also need pdb files. One option would be to build dynamic and static files. But how we then can build with /MT? Just replace /MD with /MT in make file?

This works in our CI currently when building the windows installer, assuming its fixed
Marking as inactive, to be closed at the end of 3.4 dev, barring further input


[Bug fix] Fix BelongToMany when using ObjectId in relation

When we use mongodb ObjectIDs for relationships
In the case of a BelongToMany relation, the foreignKeys was incorrectly cast
{
    "_id" : ObjectId("667e831289f74871500d80a7"),
    "name" : "Jean-Luc Picard",
    "updated_at" : ISODate("2024-06-28T09:32:02.401+0000"),
    "created_at" : ISODate("2024-06-28T09:32:02.401+0000"),
    "planetIds" : [
        {
            "oid" : "667e831289f74871500d80a2"
        },
        {
            "oid" : "667e831289f74871500d80a3"
        },
        {
            "oid" : "667e831289f74871500d80a4"
        }
    ]
}

With the type check, the cast is adapted to avoid converting an object into an associative array.
{
    "_id" : ObjectId("667e91e6bfeefc593308f745"),
    "name" : "Tanya Kirbuk",
    "updated_at" : ISODate("2024-06-28T10:35:18.459+0000"),
    "created_at" : ISODate("2024-06-28T10:35:18.459+0000"),
    "planetIds" : [
        ObjectId("667e91e6bfeefc593308f742"),
        ObjectId("667e91e6bfeefc593308f743"),
        ObjectId("667e91e6bfeefc593308f744")
    ]
}

#3015
Checklist

[x] Add tests and ensure they pass
[ ] Add an entry to the CHANGELOG.md file
[ ] Update documentation for new features

Can you please add tests for this change? Thank you!

Can you please add tests for this change? Thank you!

Yes of course when I have a little time.

Can you please add tests for this change? Thank you!

Hello, I have completed the work, can you give me the test procedure?
Should I create a new model?

Add Test OK.

Sorry for the time it takes to review your PR. This part of the code is complicated and we need to ensure this is feature we can support and maintain for the long run. The more we copy and modify code from the parent class, the more difficult it is to maintain and keep compatibility with multiple versions of Laravel version (even minor version can break). Also, I guess belongsToMany is not the only type of relationship that would need such change.

Sorry for the time it takes to review your PR. This part of the code is complicated and we need to ensure this is feature we can support and maintain for the long run. The more we copy and modify code from the parent class, the more difficult it is to maintain and keep compatibility with multiple versions of Laravel version (even minor version can break). Also, I guess belongsToMany is not the only type of relationship that would need such change.

No problem, the big change is in the "formatRecordsList" method, which currently assumes the existence of a pivot table.

Changes in version 4.6 make this modification incompatible. should I make the changes?


On iPhone you can't fill in text into the ComboBox input field

Strange its working bad in iPhone but works well on my android and also chrome (in mobile iPhone mode)

Fixed by removing these styles for combobox box Input:
WebkitUserSelect: 'none',
MozUserSelect: 'none',
MsUserSelect: 'none',
userSelect: 'none',

yay :)


feat(napi): return comments

Current dependencies on/for this PR:

#2469  👈
main

This stack of pull requests is managed by Graphite.

Merge activity

Feb 21, 9:43 AM EST: @Boshen merged this pull request with Graphite.


"Steam removed" issue happens once "Handle Future Dialogs" is used more than once

Describe the bug
If "Handle Future Dialogs" keyword is called more than once then then test fails and "Stream removed" error appears in the logs.
To Reproduce
Steps to reproduce the behavior:

Open New Context
Go to some page
Use any reusable methotd that contains 'Handle Future Dialogs    action=accept" inside
Go to some other page within the same context
Use any other reusable method that contains 'Handle Future Dialogs    action=accept" inside

Code example:
The Test Causing The Error
[Documentation]                                 This is just to report the problem
${case_id}                                             Create Case
Open Case With Case Id                      case_id=${case_id}
Close This Case           <-- this is reusable method that contains 'Hande Future Dialogs' inside
Go To Some Other Page
Delete Some Existing Report               report_title=Report example    <-- this is reusable method that contains 'Hande Future Dialogs' inside
Expected behavior
Test should pass and close the browser at the end.
Screenshots

Desktop (please complete the following information):

OS: [Windows 10 Pro]
Browser [Chrome]
Version [120.0.6099.200]

Additional context
The idea that comes to my mind is to create additional keyword that will handle just one single alert.

Thre workaround is to close existing context and open a new one before the second 'Handle Future Dialogs' is called.

@allcontributors please add @amodzelewski for bugs

I have the same scenario issue on my end, except when I attempt to leave a dirty page and accept the alert, I get a Socket Closed error:

If you use https://marketsquare.github.io/robotframework-browser/Browser.html#Wait For Alerts keyword from 18.9.1 version. Do you still experience this problem?
Most likely this is caused same thing as with https://github.com/MarketSquare/robotframework-browser/issues/3785


refactor reporter tests to use lovely-pytest-docker

Is your feature request related to a problem? Please describe.
Currently reporter tests  depend on external startup of docker,
this limits the scenario testing possibilities and is not programmable.
e.g. how to test what happens when a db service goes down?
Describe the solution you'd like
tests starts and stop docker as needed.
Describe alternatives you've considered
Leave everything as it is
Additional context
N/A

Hi @c0c0n3 @chicco785 I have gone through this issue and https://github.com/lovelysystems/lovely-pytest-docker , I have concluded below points:

We need to update conftest.py for docker fixtures.
We need to update all the test methods to use fixtures.
We need to add dependency of lovely-pytest-docker which can be installed using pip.
We can use docker-compose.yml files which are already present in the test folder.

I will start working as per my understanding and will raise PR for the same. Please correct me if I misunderstood or missed any point.

@pooja1pathak fyi, we are already lovely-pytest-docker, but not for reporter test.
see for example:
https://github.com/orchestracities/ngsi-timeseries-api/blob/master/src/translators/tests/conftest.py#L26

hi guys, I forgot to mention we already have a docker util that avoids the dependency on external libs:

https://github.com/orchestracities/ngsi-timeseries-api/blob/master/src/utils/tests/docker.py

and here's an example usage

https://github.com/orchestracities/ngsi-timeseries-api/blob/master/src/wq/tests/conftest.py

going forward we should avoid shell scripts as much as possible and put the test control logic in Python whenever possible, like we've done in the translator and wq...

also in the same vein, we should start thinking about how to get rid of docker boilerplate, see e.g. #598 about it.

@pooja1pathak fyi, we are already lovely-pytest-docker, but not for reporter test.
see for example: https://github.com/orchestracities/ngsi-timeseries-api/blob/master/src/translators/tests/conftest.py#L26

hi @chicco785 @c0c0n3 for reporter also we have  already implemented lovely-pytest-docker but it does not work like translators.
https://github.com/orchestracities/ngsi-timeseries-api/blob/master/src/reporter/tests/conftest.py#L29

Hi @c0c0n3 @chicco785 I have compared conftest.py  in both reporter and translators but I found no difference in them and I have also investigated on wq/tests/conftest.py https://github.com/orchestracities/ngsi-timeseries-api/blob/master/src/wq/tests/conftest.py
where I found differences do you need to apply similar kind of changes in reporter and translators.


Add 'dynamic = strict' in es mappings generation

This will disable dynamic field mapping so document's are
rejected if they have a field that doesn't have a mapping
defined.

I assume this supersedes #48?

I assume this supersedes #48?

Correct


HomeViewController Bugs.

Using correct indexPath and returning the array count in the correct delegate method.
Code refactor.

@pjwelcome I didn't write any of this code. All I did was to place the tableView delegate methods into an extension, change "let showcaseApps = showcaseAppArray[indexPath.section]", change return for numberOfRowsInSection from "return 1  " to "showcaseAppArray.count", and vice versa for numberOfSections.
I will, however, change these.


[Bug]: Inapproriate filter "Cloned" is displayed to user on Audit log

Is there an existing issue for this?

[X] I have searched the existing issues

Description
The action of clone/duplicate is removed from the home page; however, on the Audit log filter, the option is displayed to the user.
Expectation: Since the option is not useful as it has been removed we should not be disaplying to the user displaying
Steps To Reproduce

Log in as admin
Navigate to Audit logs under the setting
observe the filter for action

Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Cloud

@prapullc  - I believe we have to keep this as there were some events in the past when the feature was present. I will keep this as is for now, may be we can hide it when there are no events for the same.

@infinitetrooper : Sure we can do that I think that is a god idea as well


Esaml issue

fixes #535

Coverage decreased (-0.004%) to 4.84% when pulling ce87ab7d1fd5d1ff84b8ccb70f4a232895d20f44 on esaml_issue into 0fddb0c5b61e635609a37d87c6d79ab0949d342d on master.


v0.148.0

Terraform: Support provider updates
Extract RegistryClient for communicating with terraform registry

@jurre ops I just merged https://github.com/dependabot/dependabot-core/pull/3733 - wanna include that or should we roll into the next release?

@jurre ops I just merged #3733 - wanna include that or should we roll into the next release?

Let's include it 👍


Add bounce with momentum scroll to top?

On iOS, when momentum scrolling a div up, it 'hard stops' when it reaches the top. You can then pull down to refresh. Is there any way to add a bit of a bounce, where if you momentum scroll up to the top, it will continue to scroll past the top, starting the process of pulling to refresh, but not completing it, and then bouncing back to the top?

Uhm, could you record the describe behavior? It's hard to follow just by your description.
Also, this might be an impossible task, since Safari won't report when the user has overshot the viewport when scrolling, it only says 0 (and I think it's great, since having negative values would break lots of things).

Sorry, I tried to explain best I could. Go to Twitter on your iOS device, using the browser (I assume it works the same on Android, but I don't have one to test). When viewing your timeline, scroll down a little bit, then flick down to scroll back to the top. Notice how when it scrolls all the way to the top of the page, it continues a little bit before bouncing back. This is standard behavior for web pages on mobile devices. And it works on Twitter even with their pull to refresh. When I activate pull to refresh on a div on a web page, scroll a bit and flick down to scroll up, it stops hard at the top, and doesn't 'bounce'.

@wingedpig
I'm not iOS user but I believe the behavior you describe is kinda native for the webview and it cannot be emulated on other devices just with pure Javascript, please let me know if I am wrong.

Twitter's an existence proof that it can be done. I just don't know how.

Sorry, I tried to explain best I could. Go to Twitter on your iOS device, using the browser (I assume it works the same on Android, but I don't have one to test). When viewing your timeline, scroll down a little bit, then flick down to scroll back to the top. Notice how when it scrolls all the way to the top of the page, it continues a little bit before bouncing back. This is standard behavior for web pages on mobile devices. And it works on Twitter even with their pull to refresh. When I activate pull to refresh on a div on a web page, scroll a bit and flick down to scroll up, it stops hard at the top, and doesn't 'bounce'.

Your explanation is on-point, but remember than an image speaks a thousand words, so a video would be great.

Twitter's an existence proof that it can be done. I just don't know how.

If I were you, I'd start by debugging the code.
I'm closing this because it got sidetracked offtopic, and it doesn't have anything to do with the library. If you find something, feel free to create a PR.


error on install -> update

I get through most of the install and then the command
./anaconda/bin/bcbio_nextgen.py upgrade --tooldir=~/bcbio --genomes GRCh37 --aligners bwa --isolate --data

gives the error:
Traceback (most recent call last):
  File "./anaconda/bin/bcbio_nextgen.py", line 4, in <module>
    __import__('pkg_resources').run_script('bcbio-nextgen==0.9.8', 'bcbio_nextgen.py')
  File "/uufs/chpc.utah.edu/common/home/u6000771/.local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 742, in run_script
    self.require(requires)[0].run_script(script_name, ns)
  File "/uufs/chpc.utah.edu/common/home/u6000771/.local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 1667, in run_script
    exec(code, namespace, namespace)
  File "/scratch/ucgd/lustre/u6000771/bcbio/anaconda/lib/python2.7/site-packages/bcbio_nextgen-0.9.8-py2.7.egg-info/scripts/bcbio_nextgen.py", line 207, in <module>
    install.upgrade_bcbio(kwargs["args"])
  File "/scratch/ucgd/lustre/u6000771/bcbio/anaconda/lib/python2.7/site-packages/bcbio/install.py", line 94, in upgrade_bcbio
    upgrade_bcbio_data(args, REMOTES)
  File "/scratch/ucgd/lustre/u6000771/bcbio/anaconda/lib/python2.7/site-packages/bcbio/install.py", line 285, in upgrade_bcbio_data
    remotes["genome_resources"])
  File "/scratch/ucgd/lustre/u6000771/bcbio/anaconda/lib/python2.7/site-packages/bcbio/install.py", line 305, in _upgrade_genome_resources
    requests.packages.urllib3.disable_warnings()
AttributeError: 'module' object has no attribute 'disable_warnings'

when I look in /scratch/ucgd/lustre/u6000771/bcbio/anaconda/lib/python2.7/site-packages/requests/packages/urllib3/__init__.py I can see that disable_warnings() is there.
Any ideas?

Hi Brent,
It looks like /uufs/chpc.utah.edu/common/home/u6000771/.local/lib/python2.7/site-packages is sneaking into the path somehow, maybe it is picking up the requests from there by accident? Is that in your PYTHONPATH?

Hi Rory, thanks for the quick reply. I didn't see that.
my PYTHONPATH is not set, so not sure what was happening. I deleted my entire ~/.local/lib/python2.7/ dir and I'see what happens.

that did it. thanks again.

Score!


[Feature] Support ssl for mysql protocol

What type of PR is this：

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

This PR provides the ssl interface framework. Users can implement SSLChannel and put the jar to fe/lib directory to support ssl encryption.
There are three config params to enable ssl, ssl_keystore_location, ssl_keystore_password, ssl_key_password. Users can generate ssl keys using the command
keytool -genkeypair -alias starrocks -keypass starrocks -keyalg RSA -keysize 1024 -validity 365 -keystore starrocks.jks -storepass starrocks

-keystore specify generated keystore file name, set this file path to ssl_keystore_location
-storepass specify the keystore file password, set this password to ssl_keystore_password
-keypass sepecify the private key password, set this password to ssl_key_password

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

fe unit test failed

run starrocks_admit_test

run starrocks_fe_unittest

run starrocks_fe_unittest

[FE PR Coverage Check]
:disappointed: fail : 53 / 118 (44.92%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/mysql/ssl/SSLChannelImpClassLoader.java
0
17
00.00%
[14, 15, 17, 22, 23, 26, 27, 28, 29, 32, 33, 34, 35, 36, 37, 38, 39]

:large_blue_circle:
com/starrocks/qe/QeService.java
4
15
26.67%
[48, 49, 54, 76, 77, 78, 80, 81, 83, 84, 85]

:large_blue_circle:
com/starrocks/mysql/MysqlChannel.java
13
32
40.62%
[138, 141, 146, 147, 151, 152, 154, 155, 156, 157, 160, 161, 162, 163, 164, 165, 170, 206, 249]

:large_blue_circle:
com/starrocks/mysql/MysqlProto.java
10
24
41.67%
[127, 128, 129, 130, 131, 132, 134, 138, 139, 140, 226, 230, 231, 232]

:large_blue_circle:
com/starrocks/mysql/MysqlHandshakePacket.java
3
5
60.00%
[76, 77]

:large_blue_circle:
com/starrocks/mysql/MysqlAuthPacket.java
2
3
66.67%
[89]

:large_blue_circle:
com/starrocks/qe/ConnectContext.java
6
7
85.71%
[635]

:large_blue_circle:
com/starrocks/mysql/nio/AcceptListener.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/common/Config.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/common/ErrorCode.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/mysql/nio/NMysqlServer.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/mysql/MysqlCapability.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/mysql/nio/NConnectContext.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/mysql/nio/NMysqlChannel.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/mysql/MysqlServer.java
3
3
100.00%
[]

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

[FE PR Coverage Check]
:disappointed: fail : 57 / 120 (47.50%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/mysql/ssl/SSLChannelImpClassLoader.java
0
17
00.00%
[14, 15, 17, 22, 23, 26, 27, 28, 29, 32, 33, 34, 35, 36, 37, 38, 39]

:large_blue_circle:
com/starrocks/qe/QeService.java
4
15
26.67%
[48, 49, 54, 76, 77, 78, 80, 81, 83, 84, 85]

:large_blue_circle:
com/starrocks/qe/ConnectContext.java
6
19
31.58%
[652, 653, 654, 655, 659, 660, 661, 662, 664, 665, 667, 668, 669]

:large_blue_circle:
com/starrocks/mysql/MysqlProto.java
10
24
41.67%
[127, 128, 129, 130, 131, 132, 134, 138, 139, 140, 226, 230, 231, 232]

:large_blue_circle:
com/starrocks/mysql/MysqlHandshakePacket.java
3
5
60.00%
[76, 77]

:large_blue_circle:
com/starrocks/mysql/MysqlAuthPacket.java
2
3
66.67%
[89]

:large_blue_circle:
com/starrocks/mysql/MysqlChannel.java
13
18
72.22%
[135, 136, 140, 176, 219]

:large_blue_circle:
com/starrocks/mysql/nio/AcceptListener.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/common/Config.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/common/ErrorCode.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/mysql/nio/NMysqlServer.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/mysql/MysqlCapability.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/mysql/nio/NConnectContext.java
5
5
100.00%
[]

:large_blue_circle:
com/starrocks/mysql/nio/NMysqlChannel.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/mysql/MysqlServer.java
3
3
100.00%
[]


example in readme? or a console?

I do maintain a list of Roslyn Code Generators at https://ignatandrei.github.io/RSCG_Examples/v2/docs/List-of-RSCG
I wish to add yours, but I need some use cases. Could you add into  the readme file?

Thanks! see next issue ;-)

https://ignatandrei.github.io/RSCG_Examples/v2/docs/CopyCat


improve performance of getRelatedNodes

cache the actual nodes that contain the logic (not their parents)
cache the filtered result if no repeat?

Hey @MartijnR, and feel for how much difference this makes for users, and where the speed-up is seen?

Hi @alxndrsn,
I think theoretically it should make a difference for forms with a lot of logic && repeats. However, I didn't have much time for this work, and ended up doing it blindly. I think it would be good to revisit this and disable the cache in getRelatedNodes to see if there is a measurable improvement (otherwise better to remove the cache to reduce complexity, but keep some of the other changes). The automatic performance monitor is not showing a nice impact on 1 form (bench6) only.


'flavor' option does not work for me

I am setting flavor as normal still gulp is downloading the sdk version of nw-js.
 flavor : 'normal',

Seconded. I took a very brief look at the nw-builder module (v 3.2.0) and the files don't seem to be at all inline with the git repository. All the flavour code is missing from Version.js for example.

I updated to latest version 3.2.0, seems to be working for me now.


Luax support?

Kind of like how jsx can inline html and return it from a function, are there any plans in the future to support that in a "luax" file type with this plugin?

Currently there are no plans for a luax file type for a few reasons:

lsp support probably would probably be rough because I would have to translate the entire file into lua, with luals running under the hood (probably a separate process from the main luals)
The markup has to be compiled once (this is mostly a self imposed requirement on the entire project), but this does not really work well with banana currently. This leaves the other option to compile it into a lua table tree which would probably be separate from the main renderable tree
This would probably add a lot of complexity from reactivity and stuff (think of all the use... functions in react)

This does not mean that luax or something similar will not happen, but it will probably be, at the earliest, a few months away. In the meantime, I will try my best to make templating a very valid option because that does not add as large an overhead as a luax format


Update peerDependencies to support Grunt 1.0

Update peerDependencies to support Grunt 1.0
Hello,
This is an automated issue request to update the peerDependencies for your Grunt plugin.
We ask you to merge this and publish a new release on npm to get your plugin working in Grunt 1.0!
Read more here: http://gruntjs.com/blog/2016-02-11-grunt-1.0.0-rc1-released#peer-dependencies
Also on Twitter: https://twitter.com/gruntjs/status/700819604155707392
If you have any questions or you no longer have time to maintain this plugin, then please let us know in this thread.
Thanks for creating and working on this plugin!
(P.S. Close this PR if it is a mistake, sorry)

Updated in https://github.com/heldr/grunt-smushit/commit/91d3ab646882b138d1df95b0b00e7276a41009cc


0.2.1 batch norm fixes

Adds two commits for batch norm bug fixes. From discussion on #273 and #867
cc @zou3519 I ended up cherry-picking two commits since #958 also caught a typo and need for a contiguous call. However, lines-wise, this ends up being a lot of testing changes. I think I can refactor both changes to have fewer testing changes but will end up looking different than the version on main. Any thoughts as to if I should keep it like this or try to refactor for fewer test changes?

Change: since it's failing so many tests I'm going to go with option 1 and try to re-cherry-pick with very minimal testing changes

Change: since it's failing so many tests I'm going to go with option 1 and try to re-cherry-pick with very minimal testing changes

Sounds good

I wouldn't worry about the mac signal -- the macos signal is failing because they deprecated the xcode image I think

Circle CI shows passing for all jobs but mac. Looks like github checks aren't updating


flutter doctor -v can't find Google Chrome

Bug Report
Package Name: googlechrome
Current Behaviour
flutter can’t find Chrome installed via scoop. Current output of flutter doctor -v is:
[✓] Flutter (Channel stable, 2.10.3, on Microsoft Windows [Version 10.0.22000.613], locale en-ID)
    • Flutter version 2.10.3 at C:\Users\Rafiqi\scoop\apps\flutter\current
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7e9793dee1 (7 weeks ago), 2022-03-02 11:23:12 -0600
    • Engine revision bd539267b4
    • Dart version 2.16.1
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at C:\Users\Rafiqi\scoop\apps\android-sdk\current
    • Platform android-32, build-tools 32.1.0-rc1
    • ANDROID_HOME = C:\Users\Rafiqi\scoop\apps\android-sdk\current
    • Java binary at: C:\Users\Rafiqi\scoop\apps\android-studio\current\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)
    • All Android licenses accepted.

[✗] Chrome - develop for the web (Cannot find Chrome executable at .\Google\Chrome\Application\chrome.exe)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✓] Visual Studio - develop for Windows (Visual Studio Build Tools 2022 17.1.3)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools
    • Visual Studio Build Tools 2022 version 17.1.32328.378
    • Windows 10 SDK version 10.0.19041.0

[✓] Android Studio (version 2021.1)
    • Android Studio at C:\Users\Rafiqi\scoop\apps\android-studio\current
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)

[✓] Connected device (2 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22000.613]
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 99.0.1150.55

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Expected Behaviour
Flutter can find chrome.
Additional context/output
Chrome installed manually or via winget can be found by flutter may be sunce it is installed globally.
Possible Solution
Try setting CHROME_EXECUTABLE to a Chrome executable. Like the error said.
System details
Windows version: 11
OS architecture: 64bit

Oh I just found that scoop provide env configurations in docs. I will try to make PR.


Stage FIle Wont save (v1.0)

Describe your bug here.
I was trying to make a stage for my FNF Mod I am trying to make with v1.0.
It didn't save.
I pressed the save button but it wouldn't save no matter how many times I clicked that button.
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No

So, I Don't Exactly Know If Your Using Source Or Not, But On Source, You Need To Have Your Images In A Completely Different File Location. Like For Example: Downloads, Documents, ect.  After Clicking Ok Or Something Like That, You'll Be Able To Save.

Add images from a different folder location (ex. Desktop), if you got a pop-up to copy image to mods folder, click OK and you can save your stage after.

so I can't have them in the games folder? ok thx for letting me know.


podman rmi : can leave untagged images

podman rmi IMG1 IMG2, where IMG1 == IMG2 except for the tag, seems to be removing the tags but not actually the images themselves:
# centos=docker.io/stackbrew/centos
# for tag in 7 latest;do podman pull -q  $centos:$tag;done
61b442687d681ef80a7b1ae148ed5ce75a94d5fcca94315378839b3ad240f314
61b442687d681ef80a7b1ae148ed5ce75a94d5fcca94315378839b3ad240f314
# podman images
REPOSITORY                   TAG      IMAGE ID       CREATED       SIZE
docker.io/stackbrew/centos   latest   61b442687d68   2 years ago   204MB
docker.io/stackbrew/centos   7        61b442687d68   2 years ago   204MB

# podman rmi $centos:7 $centos:latest
Untagged: docker.io/stackbrew/centos:7
Untagged: docker.io/stackbrew/centos:latest
# podman images
REPOSITORY   TAG      IMAGE ID       CREATED       SIZE
<none>       <none>   61b442687d68   2 years ago   204MB

Running individual rmi commands works fine; the first one untags, the second removes:
# for tag in 7 latest;do podman pull -q  $centos:$tag;done
...
# for tag in 7 latest;do podman rmi   $centos:$tag;done
Untagged: docker.io/stackbrew/centos:7
61b442687d681ef80a7b1ae148ed5ce75a94d5fcca94315378839b3ad240f314

podman-0.6.3-1528484991.gitb78e7e4.fc28.x86_64 and podman-0.5.4-1527007540.git926d07d.fc27.x86_64

ill like at this along the way

I found a fix for that. @baude, I hope you're cool with me jumping in (I'll take the risk).

@baude is on PTO and is not supposed to be working.  He will get over it.


Singletons Removal in ballerina-http package

Resolves https://github.com/ballerinalang/ballerina/issues/4146

Still working on removing singletons step by step. Will send a new PR once it is done.


branch: toggleWordWrap_1a

desc:  Add word wrap toggle function.
hotkey: Alt-Z

Hi @ivanixgames, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@ivanixgames, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;


Try to organize all branches in particular folder

It might be better to organize all backport branches in a particular folder. By this way, we can prevent messing up (as a view) the view of original branch structure.

Hi @ercanerdogan 👋 Thanks for your suggestion.
Would it help if branchname (the name of the backport branch) is a configurable input? We could leave the default the same as the current value backport-${pull_number}-to-${target_branch}. That way, the behavior stays the same for the rest of the users, while others can configure it.
Next to pull_number and target_branch, we could also make some of the other placeholders like pull_author available to it.

I'm closing this pull request due to inactivity.
@ercanerdogan Please let me know if my alternative suggestion suits you, or open an issue for it. I would welcome contributions for such a configuration option, as long as the default behavior stays unchanged.

Yeap, that makes sense @korthout . I will have a look when I find a time for that. So, I will create a new PR.
Thanks.


SSML not working in web client voice

 Issue by rstrahan
Tuesday May 22, 2018 at 21:57 GMT
Originally opened as https://github.com/rstrahan/aws-ai-qna-bot-2/issues/31

Add SSML text to SSML Answer field of a question.. Expect that SSML to be used in lex web UI voice response , but there is no audio response.. only text.
Issue tracked down to newlines in the SSML..
This does NOT work:

    Can you keep a secret?
    QnABot is not a real human..
    Can you believe it?

But this does work:
I want to tell you a secret. <amazon:effect name="whispered">I am not a real human.</amazon:effect>. Can you believe it?
We need to support formatted SSML (with newlines)

fixed in 2.1.0


Expanding Primitives + Values > 64 Bits

Currently we can only process Values up to 64 bits, because the interiors of all primitives first convert Values to u64/i64, process, convert back to Values, return.
Altering this behavior would involve processing Values + their BitVecs as bits, but where? If we do that in Values, then aren't we limited by that function's return value? But if that processing is done in Primitives, is that the right place...?

Just a note that we have found an issue with regards to how the comparison works in between value vectors (in the PR addressed above)


Wrong Value in Comment on one of the Lua Script

What needs to be documented?
[THERE WAS NO ISSUE TEMPLATE THAT WAS FINE SO I TOOK THE ONE THAT WAS THE MOST LOGICAL!]

In the Instant Kill Arrow Lua Script, it says 0.23 is the default health gain value, but that would mean each note give 12.5% of your health which is not true! (0.23 * 50)
Don't know the real value, but I'm expecting it's 0.023

0.023 yeah


pgmetrics: 1.14.0 -> 1.14.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/rapidloop/pgmetrics/releases.
meta.description for pgmetrics is: Collect and display information and stats from a running PostgreSQL server
meta.homepage for pgmetrics is: https://pgmetrics.io/
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.14.1 with grep in /nix/store/vqzb98ca0zm7pgirig19h1sxj2v1zc6j-pgmetrics-1.14.1
found 1.14.1 in filename of file in /nix/store/vqzb98ca0zm7pgirig19h1sxj2v1zc6j-pgmetrics-1.14.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
pgmetrics

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/vqzb98ca0zm7pgirig19h1sxj2v1zc6j-pgmetrics-1.14.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A pgmetrics https://github.com/r-ryantm/nixpkgs/archive/561e6f59cbf7db49811958bb0904543a1d862139.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/vqzb98ca0zm7pgirig19h1sxj2v1zc6j-pgmetrics-1.14.1
ls -la /nix/store/vqzb98ca0zm7pgirig19h1sxj2v1zc6j-pgmetrics-1.14.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

pgmetrics

Maintainer pings
cc @marsam for testing.

@GrahamcOfBorg eval


envrionment variable undefined

I'm running into an issue trying to use this package;
_keyclock/utils.js can't seem to load the envrionment variables:
Uncaught (in promise) TypeError: can't access property "VITE_OIDC_ISSUER", import_meta.env is undefined in firefox
and Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'VITE_OIDC_ISSUER') in chrome
at utils.js line 2.
Environment variables work just fine elsewhere, I used VITE_OIDC_ISSUER in keycloak.svelte no problem.

I got the same issue and #3 is the same ✌

@Snukii and @SarcevicAntonio  Sorry you have to run into such an issue. Which version of sveltekit-oidc are you using? Also, I am using node version 14.17.1.


elbv2 describe_tags return ResourceArn empty instead of the correct one

Reporting Bugs
I am using the latest version of moto for elbv2. After create_load_balancer with moto, which return resource 'LoadBalancerArn': 'arn:aws:elasticloadbalancing:us-east-1:123456789012:loadbalancer/app/loadbalancer/50dc6c495c0c9188'
I ran describe_load_balancers() which returned correct resource,. But when I did describe_tags (ResourceArns =<list of ARN from describe_load_balancers), it returned something similar to this:
{'TagDescriptions': [{'ResourceArn': '', 'Tags': [{'Key': 'aaa', 'Value': ''}]}, {'ResourceArn': '', 'Tags': [{'Key': 'bbb', 'Value': ''}, ..}
So 'ResourceArn': '' is returned, instead of the correct ResourceArn.
With this, my test suddenly failed. It was succeed before the change.

Thanks for letting us know @linhmeobeo - will raise a PR to fix this shortly


Namespace elixir caches by workflow

Still having issues with the Elixir cache.

Pull Request Test Coverage Report for Build 62079eda4bd36848e8e40fad5e16274f2a8562af-PR-1227

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.092%

Totals

Change from base Build 5e8407c017616a00f96301deef1e8ecc0460c540:
0.0%

Covered Lines:
1189

Relevant Lines:
1799

💛  - Coveralls


Routing on one of multiple selected checkbox answers

What is the context of this PR?
Added a contains condition to routing rules.
When a routing rule is specified on a checkbox, the routing rule checks if a value is one of the selected answers.
Fixes https://github.com/ONSdigital/eq-survey-runner/issues/684
How to review
On the census-household questionnaire test the routing of the employment-type question

Also needed on the which passport screen I think

This also fixes some issues reported by yogi, can we add them to the description?

https://github.com/ONSdigital/eq-survey-runner/issues/684

@collisdigital i can't add this to the passports question as the question it routes to is added in here https://github.com/ONSdigital/eq-survey-runner/pull/683 so need this to go in then i can merge into the other branch

@jonnyshaw89 Re-tested the issue #684 one scenarios seems to be not working. Lets discuss on Monday

@yoganandkunche i have corrected the routing on the none of the above option

@jonnyshaw89 As discussed selecting the 7 option along with any/all the 1-6 options must skip the next questions

Not merged into master yet. So will be testing it in pre-prod tomorrow as I will be busy with e2e testing today


Dismiss prior pull reviews if done via web in review dismiss

story:

user A (repo admin) create pull to protected branch (need 1 lgtm)
user B review accept
user A create undesired changes ...
user B rejects
user A changes things
user A dismiss review

before:
7. webUI show valid accepted (fallback to last review) review from user B
after:
7. webUI show no valid review from user B

Since we just in 1.17rc1, maybe we could have a break for that? Is false parameter for that meaningful?

Since we just in 1.17rc1, maybe we could have a break for that? Is false parameter for that meaningful?

breaking api should have a serious reason and has nothing to do with rc or so.
now we have the webUI case also covered via api if one like to write a own ui he can do so ...

antecessor is a somewhat technical term used rarely in English ... prior, preceding or earlier would be more usual.

ok I'll rename to prior

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@00d3876). Click here to learn what that means.
The diff coverage is 13.88%.

@@           Coverage Diff           @@
##             main   #20197   +/-   ##
=======================================
  Coverage        ?   46.86%
=======================================
  Files           ?      976
  Lines           ?   135223
  Branches        ?        0
=======================================
  Hits            ?    63376
  Misses          ?    64075
  Partials        ?     7772

Impacted Files
Coverage Δ

models/issues/review.go
52.77% <0.00%> (ø)

routers/web/repo/pull_review.go
0.00% <0.00%> (ø)

services/pull/review.go
48.24% <7.14%> (ø)

routers/api/v1/repo/pull_review.go
69.76% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d3876...3e6c94b. Read the comment docs.

:rocket:

-> #20407


Query Exception when multiple SDK versions are installed in different namespaces

Remember, an issue is not the place to ask questions. You can use Stack Overflow for that, or you may want to start a discussion on the dW Answers.
Before you open an issue, please check if a similar issue already exists or has been closed before.
When reporting a bug, please be sure to include the following

[x] Salesforce version
[x] SDK version
[x] Steps to reproduce
[ ] Expected behavior
[ ] Actual behavior

When you open an issue for a feature request, please add as much detail as possible

[ ] A descriptive title starting with the service name: Conversation, Discovery...
[x] A description of the problem you're trying to solve
[x] A suggested solution if possible

Salesforce version: Summer '18
SDK version: June 14, 2018
Issue: IBMWatsonService class
Line 36: ApexClass ac = [Select ApiVersion From ApexClass Where Name = 'IBMWatsonService']; will return more than one result if multiple versions of the SDK are deployed in different namespaces, such as multiple managed packages that each use the SDK. Please add a LIMIT clause to this query, or store it in a list variable and dereference the first result.

Duplicate of https://github.com/watson-developer-cloud/salesforce-sdk/issues/129


removeAdditional=failing removing non-failing property

What version of Ajv are you using? Does the issue happen if you use the latest version?
6.10.2 - Latest
Ajv options object
{ allErrors: true, removeAdditional: "failing", schemaId: "auto" }

JSON Schema

{
    additionalProperties: false,
    definitions: {
      ApprovalRule: {
        anyOf: [
          {
            $ref: "#/definitions/ITypeA",
          },
          {
            $ref: "#/definitions/ITypeB",
          },
        ],
      },
      "Types.typeA": {
        enum: ["TypeA"],
        type: "string",
      },
      "Types.typeB": {
        enum: ["TypeB"],
        type: "string",
      },
      InnerType: {
        additionalProperties: false,
        properties: {
          stage: {
            type: "number",
          },
          userId: {
            type: "number",
          },
        },
        required: ["userId", "stage"],
        type: "object",
      },

      ITypeA: {
        additionalProperties: false,
        properties: {
          type: {
            $ref: "#/definitions/Types.typeA",
          },
        },
        type: "object",
      },

      ITypeB: {
        additionalProperties: false,
        properties: {
          TypeBProp: {
            items: {
              $ref: "#/definitions/InnerType",
            },
            type: "array",
          },

          type: {
            $ref: "#/definitions/Types.typeB",
          },
        },
        required: ["type"],
        type: "object",
      },
    },
    id: "http://schemas.com/ITestType",
    properties: {
      rule: {
        $ref: "#/definitions/ApprovalRule",
      },
    },
    type: "object",
  };

Sample data

{
    id: NaN,
    approvalEnabled: true,
    version: 1,
    rule: { type: "TypeB", TypeBProp: [{ stage: 1, userId: 17 }, { stage: 2, userId: 15 }] },
  }

Your code

const ajv = new Ajv({ allErrors: true, removeAdditional: "failing", schemaId: "auto" });

  it("should", () => {
    ajv.validate(schema, json);
    expect(ajv.errors).toBeNull();
    expect(json).toEqual({ rule: { type: "TypeB", TypeBProp: [{ stage: 1, userId: 17 }, { stage: 2, userId: 15 }] } });
  });

Validation result, data AFTER validation, error messages
{ rule: { type: "TypeB" } }

What results did you expect?
Property TypeBProp should not have been removed.
I've read the docs, and thought setting it to "failing" would only remove properties that would fail the entire schema?

"Additional property" is only defined in relation to the single schema object, there is no such thing as "additional property" in the context of the whole schema. So as soon as any subschema has additional property (even if it is defined in another schema) it will be removed - that is the expected behaviour. It can be worked around by restructuring the schema to make sure that additionalProperties keyword is only used in the subschemas that have all properties defined (at least as stubs, without any schemas for them).
It's been covered in other issues and in FAQ.


Disable the LOD reduction in splitscreen (and by extension, netplay)

When you have more than 1 player, be it splitscreen or netplay, weapon models, and perhaps other models as well drop significantly in LOD. Since this is no longer needed, as we're not running on N64 hardware, could this behaviour be disabled?

There is a PR for this already (#333). I'll close this when I get around to merging it.

This has been merged now.


chore(deps): update dependency @types/react to v16.9.46

This PR contains the following updates:

Package
Type
Update
Change

@types/react
devDependencies
patch
16.9.45 -> 16.9.46

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

:tada: This PR is included in version 5.1.13 :tada:
The release is available on:

v5.1.13
GitHub release

Your semantic-release bot :package::rocket:


AirnodeTokenPayment

Initial Draft. Access control and tests needs to be implemented but the core logic is here.

@Ashar2shahid this should be ready for review now

@Ashar2shahid you should now be able continue reviewing this PR now

Everything looks good to me just added some small comments. I made a pass of the tests and they seem alright, will do one more pass tomorrow but this is approved from my side (can't approve my own pull request sweat_smile ) .
One more thing is @acenolaza you should probably also update the README similar to the AirnodeTokenLock changes.

Updated the README and added a new test for paying with a contract that only has 6 decimals (Mock USDC stablecoin contract)
I'm feeling pretty confident that this could be merge tomorrow if you agree @Ashar2shahid

Went through the tests again and everything looks good. Shouldn't be a problem to merge this now


[Bug]: Re-entering the world causes a crash

Minecraft Version
1.20.1
Mod Loader
Forge
Mod Loader Version
47.2.0
Architectury API Version
9.2.14
FCAPI Port (if present) Version
No response
Describe the bug
After entering the save file, returning to the main interface and then entering the save file again will cause the system to crash, as will creating a new save file.
Steps to Reproduce

Enter the world
Exit the world
Re-enter the world
See error

Crash Reports/Logs
---- Minecraft Crash Report ---- // Embeddium instance tainted by mods: [oculus] // Please do not reach out for Embeddium support without removing these mods first. // ------- // Uh... Did I do that?  Time: 2024-08-15 10:47:25 Description: Exception in server tick loop  java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@208021a0[Not completed, task = java.util.concurrent.Executors$RunnableAdapter@631a9b5f[Wrapped task = forge.net.superricky.tpaplusplus.io.AutosaveScheduler$$Lambda/0x0000022356824e70@5dca04e4]] rejected from java.util.concurrent.ScheduledThreadPoolExecutor@61d3e9ba[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 0] 	at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2081) ~[?:?] {} 	at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:841) ~[?:?] {} 	at java.util.concurrent.ScheduledThreadPoolExecutor.delayedExecute(ScheduledThreadPoolExecutor.java:340) ~[?:?] {} 	at java.util.concurrent.ScheduledThreadPoolExecutor.schedule(ScheduledThreadPoolExecutor.java:562) ~[?:?] {} 	at java.util.concurrent.Executors$DelegatedScheduledExecutorService.schedule(Executors.java:864) ~[?:?] {} 	at forge.net.superricky.tpaplusplus.io.AutosaveScheduler.initialiseAutoSaveService(AutosaveScheduler.java:13) ~[%5BTP请求%5DTPA++%20-%201.6.0-1.20.x-RELEASE-CANDIDATE-2.jar%23304!/:?] {re:classloading} 	at forge.net.superricky.tpaplusplus.io.ServerLifecycleHandler.onServerStart(ServerLifecycleHandler.java:15) ~[%5BTP请求%5DTPA++%20-%201.6.0-1.20.x-RELEASE-CANDIDATE-2.jar%23304!/:?] {re:classloading} 	at forge.net.superricky.tpaplusplus.TPAPlusPlus.lambda$init$10(TPAPlusPlus.java:64) ~[%5BTP请求%5DTPA++%20-%201.6.0-1.20.x-RELEASE-CANDIDATE-2.jar%23304!/:?] {re:classloading} 	at java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733) ~[?:?] {re:mixin} 	at dev.architectury.event.EventFactory.invokeMethod(EventFactory.java:53) ~[%5B奇异饰品前置%5Darchitectury-9.2.14-forge.jar%23338!/:?] {re:classloading} 	at dev.architectury.event.EventFactory$1.handleInvocation(EventFactory.java:62) ~[%5B奇异饰品前置%5Darchitectury-9.2.14-forge.jar%23338!/:?] {re:classloading} 	at com.google.common.reflect.AbstractInvocationHandler.invoke(AbstractInvocationHandler.java:87) ~[guava-31.1-jre.jar%2388!/:?] {} 	at jdk.proxy3.$Proxy157.stateChanged(Unknown Source) ~[?:?] {} 	at dev.architectury.event.forge.EventHandlerImplCommon.event(EventHandlerImplCommon.java:95) ~[%5B奇异饰品前置%5Darchitectury-9.2.14-forge.jar%23338!/:?] {re:classloading,re:mixin} 	at dev.architectury.event.forge.EventHandlerImplCommon_event_ServerStartedEvent.invoke(.dynamic) ~[%5B奇异饰品前置%5Darchitectury-9.2.14-forge.jar%23338!/:?] {re:classloading,pl:eventbus:B} 	at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:73) ~[eventbus-6.0.5.jar%23137!/:?] {} 	at net.minecraftforge.eventbus.EventBus.post(EventBus.java:315) ~[eventbus-6.0.5.jar%23137!/:?] {} 	at net.minecraftforge.eventbus.EventBus.post(EventBus.java:296) ~[eventbus-6.0.5.jar%23137!/:?] {} 	at net.minecraftforge.server.ServerLifecycleHooks.handleServerStarted(ServerLifecycleHooks.java:115) ~[forge-1.20.1-47.2.0-universal.jar%23433!/:?] {re:mixin,re:classloading,pl:mixin:APP:lithostitched.forge.mixins.json:common.ServerLifecycleHooksMixin,pl:mixin:A} 	at net.minecraft.server.MinecraftServer.m_130011(MinecraftServer.java:638) ~[client-1.20.1-20230612.114412-srg.jar%23428!/:?] {re:mixin,pl:accesstransformer:B,xf:fml:xaeroworldmap:xaero_wm_minecraftserver,xf:fml:xaerominimap:xaero_minecraftserver,re:classloading,pl:accesstransformer:B,xf:fml:xaeroworldmap:xaero_wm_minecraftserver,xf:fml:xaerominimap:xaero_minecraftserver,pl:mixin:A} 	at net.minecraft.server.MinecraftServer.m_206580(MinecraftServer.java:251) ~[client-1.20.1-20230612.114412-srg.jar%23428!/:?] {re:mixin,pl:accesstransformer:B,xf:fml:xaeroworldmap:xaero_wm_minecraftserver,xf:fml:xaerominimap:xaero_minecraftserver,re:classloading,pl:accesstransformer:B,xf:fml:xaeroworldmap:xaero_wm_minecraftserver,xf:fml:xaerominimap:xaero_minecraftserver,pl:mixin:A} 	at java.lang.Thread.run(Thread.java:1583) ~[?:?] {re:mixin}   A detailed walkthrough of the error, its code path and all known details is as follows: ---------------------------------------------------------------------------------------  -- System Details -- Details: 	Minecraft Version: 1.20.1 	Minecraft Version ID: 1.20.1 	Operating System: Windows 10 (amd64) version 10.0 	Java Version: 21.0.2, Oracle Corporation 	Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode, sharing), Oracle Corporation 	Memory: 734001160 bytes (699 MiB) /<PHONE_NUMBER> bytes (2240 MiB) up to<PHONE_NUMBER> bytes (3072 MiB) 	CPUs: 6 	Processor Vendor: GenuineIntel 	Processor Name: Intel(R) Core(TM) i5-9600KF CPU @ 3.70GHz 	Identifier: Intel64 Family 6 Model 158 Stepping 13 	Microarchitecture: Coffee Lake 	Frequency (GHz): 3.70 	Number of physical packages: 1 	Number of physical CPUs: 6 	Number of logical CPUs: 6 	Graphics card #0 name: NVIDIA GeForce GTX 1660 	Graphics card #0 vendor: NVIDIA (0x10de) 	Graphics card #0 VRAM (MB): 4095.00 	Graphics card #0 deviceId: 0x2184 	Graphics card #0 versionInfo: DriverVersion=<IP_ADDRESS>85 	Memory slot #0 capacity (MB): 8192.00 	Memory slot #0 clockSpeed (GHz): 2.67 	Memory slot #0 type: DDR4 	Virtual memory max (MB): 14783.83 	Virtual memory used (MB): 10409.95 	Swap memory total (MB): 6656.00 	Swap memory used (MB): 752.09 	JVM Flags: 3 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xmn460m -Xmx3072m 	Loaded Shaderpack: (off) 	Server Running: true 	Player Count: 0 / 8; [] 	Data Packs: vanilla, mod:betterdungeons, mod:kuma_api (incompatible), mod:playeranimator (incompatible), mod:dimensionalsycnfixes (incompatible), mod:betteroceanmonuments, mod:nerb (incompatible), mod:immersive_aircraft (incompatible), mod:gpumemleakfix (incompatible), mod:structureessentials (incompatible), mod:controlling (incompatible), mod:xaeroworldmap (incompatible), mod:placebo (incompatible), mod:modernfix (incompatible), mod:citadel (incompatible), mod:alexsmobs (incompatible), mod:yungsapi, mod:maxhealthfix (incompatible), mod:mixinextras (incompatible), mod:bookshelf, mod:mr_villager_transportation, mod:achiopt (incompatible), mod:guardvillagers (incompatible), mod:medievalend (incompatible), mod:jeed (incompatible), mod:pickupnotifier, mod:balm, mod:carryon (incompatible), mod:chat_heads (incompatible), mod:jeresources, mod:cloth_config (incompatible), mod:betterfortresses, mod:ctov, mod:leavesbegone, mod:supplementaries, mod:embeddium, mod:embeddiumplus, mod:structure_gel, mod:advancementplaques (incompatible), mod:farmersdelight, mod:ambientsounds, mod:morebows, mod:born_in_chaos_v1, mod:lionfishapi (incompatible), mod:curios (incompatible), mod:cataclysm (incompatible), mod:oculus, mod:advancednetherite, mod:cerbons_api, mod:searchables (incompatible), mod:mr_dungeons_andtaverns (incompatible), mod:bettervillage, mod:noisium, mod:betterstrongholds, mod:queen_bee, mod:sparsestructuresreforged (incompatible), mod:inventoryprofilesnext (incompatible), mod:architectury (incompatible), mod:tpaplusplus, mod:aiimprovements, mod:cupboard (incompatible), mod:lanserverproperties (incompatible), mod:betterendisland, mod:krypton (incompatible), mod:t_and_t (incompatible), mod:bettermineshafts, mod:betteradvancements (incompatible), mod:betterjungletemples, mod:tslatentitystatus, mod:mowziesmobs, mod:geckolib, mod:ati_structures, mod:mutantmonsters, mod:amendments (incompatible), mod:customskinloader (incompatible), mod:jei, mod:lithostitched, mod:spawncapcontrolutility, mod:attributefix (incompatible), mod:conjurer_illager (incompatible), mod:libraryferret, mod:caelus (incompatible), mod:gnumus, mod:obscure_api (incompatible), mod:mr_blossom_blade (incompatible), mod:waystones, mod:fastsuite (incompatible), mod:clumps (incompatible), mod:structory, mod:fastasyncworldsave (incompatible), mod:travelersbackpack, mod:artifacts, mod:hopour (incompatible), mod:betterdeserttemples, mod:bosses_of_mass_destruction, mod:terralith, mod:crafttweaker (incompatible), mod:memoryleakfix (incompatible), mod:imst, mod:puzzlesaccessapi, mod:forge, mod:travelerstitles, mod:wso16 (incompatible), mod:spawnbalanceutility, mod:enchdesc (incompatible), mod:libipn (incompatible), mod:moonlight (incompatible), mod:mousetweaks, mod:forgeconfigscreens, mod:taxcp, mod:mixinsquared (incompatible), mod:jade (incompatible), mod:obscure_tooltips (incompatible), mod:creativecore, mod:cleanswing (incompatible), mod:fastpaintings (incompatible), mod:whats_that_slot, mod:kotlinforforge (incompatible), mod:notenoughanimations, mod:iceberg (incompatible), mod:xaerominimap (incompatible), mod:fastbench (incompatible), mod:irons_spellbooks, mod:entityculling, mod:canary, mod:inventoryhud (incompatible), mod:betterarcheology, mod:immediatelyfast (incompatible), mod:fastfurnace (incompatible), mod:bettertridents, mod:tlc (incompatible), mod:appleskin (incompatible), mod:alexsdelight, mod:ferritecore (incompatible), mod:puzzleslib, mod:packetfixer (incompatible), mod:delightful, mod:expandability (incompatible), mod:chunksending (incompatible), mod:overflowingbars, mod:aquamirae (incompatible), mod:cristellib (incompatible), Supplementaries Generated Pack, T&T Waystone Patch Pack (incompatible), mutantmonsters:biome_modifications 	Enabled Feature Flags: minecraft:vanilla 	World Generation: Experimental 	Type: Integrated Server (map_client.txt) 	Is Modded: Definitely; Client brand changed to 'forge'; Server brand changed to 'forge' 	Launched Version: 1.20.1-Forge_47.2.0 	ModLauncher: 10.0.9+10.0.9+main.dcd20f30 	ModLauncher launch target: forgeclient 	ModLauncher naming: srg 	ModLauncher services:  		mixin-0.8.5.jar mixin PLUGINSERVICE  		eventbus-6.0.5.jar eventbus PLUGINSERVICE  		fmlloader-1.20.1-47.2.0.jar slf4jfixer PLUGINSERVICE  		fmlloader-1.20.1-47.2.0.jar object_holder_definalize PLUGINSERVICE  		fmlloader-1.20.1-47.2.0.jar runtime_enum_extender PLUGINSERVICE  		fmlloader-1.20.1-47.2.0.jar capability_token_subclass PLUGINSERVICE  		accesstransformers-8.0.4.jar accesstransformer PLUGINSERVICE  		fmlloader-1.20.1-47.2.0.jar runtimedistcleaner PLUGINSERVICE  		modlauncher-10.0.9.jar mixin TRANSFORMATIONSERVICE  		modlauncher-10.0.9.jar fml TRANSFORMATIONSERVICE  		modlauncher-10.0.9.jar I18nUpdateMod TRANSFORMATIONSERVICE  	FML Language Providers<EMAIL_ADDRESS><EMAIL_ADDRESS>	lowcodefml@null 		javafml@null 	Mod List:  		[YUNG的地牢优化] YungsBetterDungeons-1.20-Forge-4.0.4.j|YUNG's Better Dungeons        |betterdungeons                |1.20-Forge-4.0.4    |DONE      |Manifest: NOSIGNATURE 		kuma-api-forge-20.1.8+1.20.1.jar                  |KumaAPI                       |kuma_api                      |20.1.8              |DONE      |Manifest: NOSIGNATURE 		[动作前置]player-animation-lib-forge-1.0.2-rc1+1.20.ja|Player Animator               |playeranimator                |1.0.2-rc1+1.20      |DONE      |Manifest: NOSIGNATURE 		[维度同步修复]dimensionalsycnfixes-1.20.1-0.0.1.jar     |DimensionalSycnFixes          |dimensionalsycnfixes          |1.20.1-0.0.1        |DONE      |Manifest: NOSIGNATURE 		[YUNG的海底神殿优化] YungsBetterOceanMonuments-1.20-Forge|YUNG's Better Ocean Monuments |betteroceanmonuments          |1.20-Forge-3.0.4    |DONE      |Manifest: NOSIGNATURE 		[配方书功能移除]nerb-1.20.1-0.3-FORGE.jar                |Not Enough Recipe Book        |nerb                          |0.3                 |DONE      |Manifest: NOSIGNATURE 		[沉浸式飞机] immersive_aircraft-1.0.1+1.20.1-forge.jar |Immersive Aircraft            |immersive_aircraft            |1.0.1+1.20.1        |DONE      |Manifest: NOSIGNATURE 		[修复GPU内存泄漏] gpumemleakfix-1.20.1-1.8.jar          |Gpu memory leak fix           |gpumemleakfix                 |1.20.1-1.8          |DONE      |Manifest: NOSIGNATURE 		[藏宝图定位优化]structureessentials-1.20.1-3.4.jar       |Structure Essentials mod      |structureessentials           |1.20.1-3.4          |DONE      |Manifest: NOSIGNATURE 		[键位冲突显示] Controlling-forge-1.20.1-12.0.2.jar      |Controlling                   |controlling                   |12.0.2              |DONE      |Manifest: NOSIGNATURE 		[Xaero的世界地图] XaerosWorldMap_1.38.8_Forge_1.20.jar |Xaero's World Map             |xaeroworldmap                 |1.38.8              |DONE      |Manifest: NOSIGNATURE 		[配方性能优化前置]Placebo-1.20.1-8.6.2.jar                |Placebo                       |placebo                       |8.6.2               |DONE      |Manifest: NOSIGNATURE 		[现代化修复] modernfix-forge-5.19.1+mc1.20.1.jar       |ModernFix                     |modernfix                     |5.19.1+mc1.20.1     |DONE      |Manifest: NOSIGNATURE 		[alex动物前置]citadel-2.5.6-1.20.1.jar                |Citadel                       |citadel                       |2.5.6               |DONE      |Manifest: NOSIGNATURE 		[Alex 的生物] alexsmobs-1.22.8.jar                   |Alex's Mobs                   |alexsmobs                     |1.22.8              |DONE      |Manifest: NOSIGNATURE 		[YUNG前置]YungsApi-1.20-Forge-4.0.5.jar             |YUNG's API                    |yungsapi                      |1.20-Forge-4.0.5    |DONE      |Manifest: NOSIGNATURE 		[最大生命值忽略修复]MaxHealthFix-Forge-1.20.1-12.0.3.jar   |MaxHealthFix                  |maxhealthfix                  |12.0.3              |DONE      |Manifest: eb:c4:b1:67:8b:f9:0c:db:dc:4f:01:b1:8e:61:64:39:4c:10:85:0b:a6:c4:c7:48:f0:fa:95:f2:cb:08:3a:e5 		mixinextras-forge-0.3.6.jar                       |MixinExtras                   |mixinextras                   |0.3.6               |DONE      |Manifest: NOSIGNATURE 		[附魔描述前置]Bookshelf-Forge-1.20.1-20.2.13.jar        |Bookshelf                     |bookshelf                     |20.2.13             |DONE      |Manifest: eb:c4:b1:67:8b:f9:0c:db:dc:4f:01:b1:8e:61:64:39:4c:10:85:0b:a6:c4:c7:48:f0:fa:95:f2:cb:08:3a:e5 		[骆驼羊驼运输村民]villager-transportation-1.3.1.jar       |Villager Transportation       |mr_villager_transportation    |1.3.1               |DONE      |Manifest: NOSIGNATURE 		[进度系统优化]AchievementOptimizer-1.20.1-1.0.2.jar     |AchievementOptimizer          |achiopt                       |1.0.2               |DONE      |Manifest: NOSIGNATURE 		[警卫村民] guardvillagers-1.20.1-1.6.7.jar            |Guard Villagers               |guardvillagers                |1.20.1-1.6.7        |DONE      |Manifest: NOSIGNATURE 		[中世纪末地结构]forge-medievalend-1.0.1.jar              |Medieval Buildings [The End Ed|medievalend                   |1.0.1               |DONE      |Manifest: NOSIGNATURE 		[JEI药水效果] jeed-1.20-2.2.2.jar                     |Just Enough Effects Descriptio|jeed                          |1.20-2.2.2          |DONE      |Manifest: NOSIGNATURE 		[拾取提示] PickUpNotifier-v8.0.0-1.20.1-Forge.jar     |Pick Up Notifier              |pickupnotifier                |8.0.0               |DONE      |Manifest: 9a:09:85:98:65:c4:8c:11:c5:49:f6:d6:33:23:39:df:8d:b4:ff:92:84:b8:bd:a5:83:9f:ac:7f:2a:d1:4b:6a 		[传送石碑前置]balm-forge-1.20.1-7.3.7-all.jar           |Balm                          |balm                          |7.3.7               |DONE      |Manifest: NOSIGNATURE 		[搬运] carryon-forge-1.20.1-<IP_ADDRESS>.jar             |Carry On                      |carryon                       |<IP_ADDRESS>             |DONE      |Manifest: NOSIGNATURE 		[聊天头像] chat_heads-0.12.10-forge-1.20.jar          |Chat Heads                    |chat_heads                    |0.12.10             |DONE      |Manifest: NOSIGNATURE 		[JER]JustEnoughResources-1.20.1-<IP_ADDRESS>.jar     |Just Enough Resources         |jeresources                   |<IP_ADDRESS>           |DONE      |Manifest: NOSIGNATURE 		[前置支持库]cloth-config-11.1.118-forge.jar            |Cloth Config v10 API          |cloth_config                  |11.1.118            |DONE      |Manifest: NOSIGNATURE 		[YUNG的下界要塞优化] YungsBetterNetherFortresses-1.20-For|YUNG's Better Nether Fortresse|betterfortresses              |1.20-Forge-2.0.6    |DONE      |Manifest: NOSIGNATURE 		[更多村庄][Forge]CTOV-v3.4.5.jar                      |ChoiceTheorem's Overhauled Vil|ctov                          |3.4.5               |DONE      |Manifest: NOSIGNATURE 		[树叶快速掉落优化]LeavesBeGone-v8.0.0-1.20.1-Forge.jar    |Leaves Be Gone                |leavesbegone                  |8.0.0               |DONE      |Manifest: 9a:09:85:98:65:c4:8c:11:c5:49:f6:d6:33:23:39:df:8d:b4:ff:92:84:b8:bd:a5:83:9f:ac:7f:2a:d1:4b:6a 		[锦致装饰]supplementaries-1.20-2.8.17.jar             |Supplementaries               |supplementaries               |1.20-2.8.17         |DONE      |Manifest: NOSIGNATURE 		[光影前置]embeddium-0.3.29+mc1.20.1.jar               |Embeddium                     |embeddium                     |0.3.29+mc1.20.1     |DONE      |Manifest: NOSIGNATURE 		[光影前置++]embeddiumplus-1.20.1-v1.2.13.jar          |Embeddium++                   |embeddiumplus                 |1.2.13              |DONE      |Manifest: NOSIGNATURE 		[魔术师前置] structure_gel-1.20.1-2.16.2.jar           |Structure Gel API             |structure_gel                 |2.16.2              |DONE      |Manifest: NOSIGNATURE 		[进度牌匾]AdvancementPlaques-1.20.1-forge-1.5.1.jar   |Advancement Plaques           |advancementplaques            |1.5.1               |DONE      |Manifest: NOSIGNATURE 		[农夫乐事] FarmersDelight-1.20.1-1.2.4.jar            |Farmer's Delight              |farmersdelight                |1.20.1-1.2.4        |DONE      |Manifest: NOSIGNATURE 		[自然音效] AmbientSounds_FORGE_v6.0.3_mc1.20.1.jar    |AmbientSounds                 |ambientsounds                 |6.0.3               |DONE      |Manifest: NOSIGNATURE 		[更多弓：重振旗鼓！

I believe I know where the issue is and I should be able to get a fix out soon.
Thank you for reporting this bug!

I just released a new beta build fixing this bug on the Modrinth and CurseForge, also containing a few other changes since then. I will test it thoroughly afterwards and release a release candidate with any changes if needed. Please let me know if you encounter any other issues with the build!
Closing this issue now.


TypeScript Resolvers plugin doesn't allow null to be returned from a promise

Describe the bug
Given a query with an optional response:
type Query {
  subscription: SubscriptionDetails
}

I should be able to write a resolver that returns a promise that returns null:
const subscription: QueryResolvers["subscription"] = async (
  _root,
  _args,
) => {
  return await fetchResult(); // Might return null
}

However, I can't because the return type is defined like this:
Maybe<ResolverTypeWrapper<SubscriptionDetails>>
So I can return null immediately (thanks to the Maybe), but if I return a Promise then I have to return ResolverTypeWrapper<SubscriptionDetails>, which is defined as:
export type ResolverTypeWrapper<T> = Promise<T> | T;
Where the type T itself (SubscriptionDetails in the example) isn't null, so I can't return null.
Proposed Solution:
If the response is optional then the generated code should be something like:
Maybe<ResolverTypeWrapper<Maybe<SubscriptionDetails>>>

Hi @timothyarmes  and thank you for the report!
Sorry but I'm not adding a lot here but just labeling it according to our new Contribution Guide and issue flow.
It seems like we are on stage 0.
Now in order to advance to stage 1 we'll need an easily running reproduction, do you think you can create that on code sandbox?
Thank you and sorry that this comment is not a complete solution (yet).

@timothyarmes I've run into this too. Did you find out any more information about this issue?


Update flink-clients, ... to 1.12.5

Updates

org.apache.flink:flink-clients
org.apache.flink:flink-connector-kafka
org.apache.flink:flink-core
org.apache.flink:flink-json
org.apache.flink:flink-runtime
org.apache.flink:flink-scala
org.apache.flink:flink-streaming-java
org.apache.flink:flink-streaming-scala
org.apache.flink:flink-table-api-scala-bridge
org.apache.flink:flink-table-planner-blink
org.apache.flink:flink-test-utils

from 1.12.2 to 1.12.5.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.apache.flink" } ]

labels: library-update, semver-patch

Superseded by #173.


Ensure unit test code coverage is as close to 100% as feasible

Additional unit tests are needed to cover edge cases and as much code as possible. The API pieces simply pass processing to other components so unit tests in their case may not be useful (though verifying methods may make sense here).

Dropping requirement. This is still a goal but not tracked here.