Promote value arithmetic to i128

This does all value arithmetic in i128, which allows u64::MAX value amounts in transactions, and also slightly lessens the risk of overflow problems.

Hi! I looked through the changes and just wanted to contextualize myself a little bit:

What value range are we targetting for MASP amounts?
In the Namada crate we need a 256-bit multitoken Amount type. Is there a way of making this i128 change somehow generic so that consumers can supply a type parameter to get i256 Amounts?
Have you considered tackling overflow problems by instead adding more validation to the accessors/mutators of Amount? And also by preventing direct access to its underlying BTreeMap?

Something like using checked_add, checked_sub, checked_mul, and checked_div in Amount's methods to ensure that no multitoken arithmetic operations ever overflow?

Could space usage be an issue? I'm thinking if the the size of an Amount doubles, then so will AllowedConversion and the data structures holding the up to 200,000 conversions at each epoch on the ledger.

* What value range are we targetting for MASP amounts?

Notes can be a minimum of 0 value and maximum of u64::MAX value, which is a hard limit.
I think everything else is designed around this constraint.

* In the Namada crate we need a 256-bit multitoken Amount type. Is there a way of making this `i128` change somehow generic so that consumers can supply a type parameter to get i256 `Amount`s?

I don't think it will help to make this an i256, or generic. Because each note value is limited to u64::MAX, it would take ~2^63 notes to reach the limits of i128. To handle 256-bit values, there has to be logic that encodes 256-bit values into 64 bits. The purpose of using i128 is only to avoid overflow issues.

* Have you considered tackling overflow problems by instead adding more validation to the accessors/mutators of Amount? And also by preventing direct access to its underlying `BTreeMap`?

Should probably do both, in addition. Since it's not mutually exclusive.

  * Something like using checked_add, checked_sub, checked_mul, and checked_div in `Amount`'s methods to ensure that no multitoken arithmetic operations ever overflow?

Since Amounts can be negative, if we tried to do arithmetic in i64 and use checked_* for verification, then (for example) it would not be possible to Spend a u64::MAX value note and Output a u64::MAX value note, because neither could be safely converted to i64. Whereas promoting a u64 to i128 always succeeds and further should never overflow (although maybe we should use checked_* just in case)

* Could space usage be an issue? I'm thinking if the the size of an `Amount` doubles, then so will `AllowedConversion` and the data structures holding the up to 200,000 conversions at each epoch on the ledger.

Yes, this could be a problem. Since these Amount represent ratios and not actual values, they could be represented with a smaller bit-width. In fact, 32-bits might be enough, if the AllowedConversion serialization is already too large.

@joebebel Thanks for the answers! Understood: the i128s are used in order to avoid overflows of u64s.
It seems that conceptually we are using Amount<i128>s to accumulate value balances, Amount<i64>s when serializing/summarizing value balances, and we may want Amount<i32> or Amount<i64>s for serializing/backing AllowedConversions. Furthermore, we may want Amount<Address, i256> or Amount<AssetType, i256>s in order to provide an API for the Namada SDK that abstracts away how we split up amounts into u64s.
In this light, generics could simultaneously achieve these goals in a way that is consistent with your i128 value balance accumulator approach. Maybe some ideas could be used from here: https://github.com/anoma/masp/pull/52 ?

It seems that conceptually we are using Amount<i128>s to accumulate value balances, Amount<i64>s when serializing/summarizing value balances, and we may want Amount<i32> or Amount<i64>s for serializing/backing AllowedConversions.

This might be good for saving storage costs, although I'm concerned about using i64 when the actual range is -u64::MAX..u64::MAX. But also AllowedConversion should be fairly small, less than i32::MAX so that makes sense there.

Furthermore, we may want Amount<Address, i256> or Amount<AssetType, i256>s in order to provide an API for the Namada SDK that abstracts away how we split up amounts into u64s.

It's possible, but I'm not 100% sure this is the correct place for this - since the API here would have to handle the splitting of one AssetType into 4 others. But it's possible. There's also the thought that we could rename this Amount to ValueSum and have Amount represent an Amount of a single asset only (more in line with librustzcash)

In this light, generics could simultaneously achieve these goals in a way that is consistent with your i128 value balance accumulator approach. Maybe some ideas could be used from here: #52 ?

Yes, I think #52 is the way to do this.

@joebebel Understood. So I've made the following changes in #52 :

Widened the value balance serializations to be Amount<i128>
Contracted the AllowedConversion backing to be Amount<i32>
Renamed Amount to be called ValueSum
Made transparent input/output values u64 to allow the same range as their shielded equivalents
Verified that Namada will continue working with this branch integrated

Let me know if anything else remains to be done. Thanks!


Update configuration_hubert.py

Expanded the config documentation by adding the default configuration and some helpful details (hopefully) of:

[x] pad_token_id
[x] bos_token_id
[x] eos_token_id

Related to this issue: https://github.com/huggingface/transformers/issues/33536
What does this PR do?

Fixes # (33536)
Before submitting

[x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x] Did you read the contributor guideline,
Pull Request section?
[x] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[x] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
@stevhliu
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Yeah I think that should work. We've also got some detailed instructions here for opening a PR :)

Yeah I think that should work. We've also got some detailed instructions here for opening a PR :)

Perfect. Thank you. I would try to make the PR.


Sometimes missing LUN Mapping

Describe the bug
LUN Mapping doesnt get created
Environment
Provide accurate information about the environment to help us reproduce the issue.

Trident version: 20.07.0
Trident installation flags used: operator install with silenceAutosupport
Container runtime: CRIO
Kubernetes version: v1.18.3+2cf11e2
Kubernetes orchestrator: OpenShift 4.5.7
Kubernetes enabled feature gates: Default
OS: RHEL CoreOS
NetApp backend types: ONTAP SAN & ONTAP NAS

To Reproduce
Create a PVC with iscsi backend
Expected behavior
Volume should get created with lun mapping
Additional context
Also please note that this issue doesnt happen all the times i have succesfully created other pvc with the same trident version and same backend configs.
When i login to the netapp i can see that the volume was created, but the lun failed to create therefore also the mapping wasnt created.    In the Logs of the PVC i can see these events
failed to provision volume with StorageClass "netapp-csi-block": rpc error: code = Unknown desc = encountered error(s) in creating the volume: [Failed to create volume pvc-3117739c on storage pool foo_72k from backend ontap_san: backend cannot satisfy create request for volume osd1_iscsi_pvc_3117739c: (ONTAP-SAN pool foo_72k/foo_72k; error creating volume osd1_iscsi_pvc_3117739c: Post "https://<IP_ADDRESS>/servlets/netapp.servlets.admin.XMLrequest_filer": context deadline exceeded (Client.Timeout exceeded while awaiting headers))]

failed to provision volume with StorageClass "netapp-csi-block": rpc error: code = Unknown desc = encountered error(s) in creating the volume: [Failed to create volume pvc-3117739c on storage pool data4_nsad0014_72k from backend ontap_san: problem mapping LUN /vol/osd1_iscsi_pvc_3117739c/lun0: results: {http://www.netapp.com/filer/admin results} status,attr: failed reason,attr: No such LUN exists errno,attr: 9017 lun-id-assigned: nil ]

Hi @Numblesix,
If the volume create operation in Trident failed then there should not be an empty FlexVol. We will investigate why Trident is failing to cleanup the FlexVol when a failure occurs during the create operation. However, please examine the Trident logs for why the LUN creation is failing. Make sure that you have debug turned on in Trident and look for errors after this log statement.

Hi @gnarl
i checked the Logs and could find some more infos but nothing showed a try of trident to delete the flexvol after the failed mapping.
i could find the following after the creation of the volume it shows those lines which i found quite strange:
I0902 08:32:56.685744       1 controller.go:634] CreateVolume failed, supports topology = false, node selected false => may reschedule = false => state = Finished: rpc error: code = Unknown desc = encountered error(s) in creating the volume: [Failed to create volume pvc-3117739c on storage pool foo_72k from backend ontap_san: problem mapping LUN /vol/osd1_iscsi_pvc_3117739c/lun0: results: {http://www.netapp.com/filer/admin results}

time="2020-09-02T08:38:07Z" level=debug msg="LUN already mapped." id=8 igroup=trident_iqn lun=/vol/osd1_iscsi_pvc_3117739c/lun0

time="2020-09-02T08:38:07Z" level=warning msg="LUN attribute fstype not found, using default." LUN=/vol/osd1_iscsi_pvc_3117739c/lun0 fstype=ext4

time="2020-09-02T08:38:07Z" level=debug msg="Attempting volume publish." backend=ontap_san backendUUID=0d721b76-f727-458c-a4da-f57bd5e90bcd volume=pvc-3117739cvolumeInternal=osd1_iscsi_pvc_3117739c

@Numblesix, we confirmed yesterday that in the ontap-san driver the FlexVol is created and if that is successful then the LUN is created. If the LUN creation fails though Trident isn't deleting the FlexVol. We will fix that issue.
I was expecting to see a "error creating LUN" or "error saving file system type" string in the above error messages. From the error messages you provided it appears that LUN creation actually worked at create time.
Can you open a support case with NetApp Support so that we can collect more information? Details on contacting support are:
To open a case with NetApp, please go to https://mysupport.netapp.com/site/.

Bottom left, Click on 'Contact Support'
Find the appropriate number from your region to call in, or login.
Note: Trident is not listed on the page, but is a supported product by NetApp based on a supported Netapp storage SN.
Open the case on the NetApp storage SN, and provide the description of the problem.
Be sure to mention the product is Trident on Kubernetes, and provide the details. Mention this GitHub.
The case will be directed to Trident support engineers for response.

This fix will be included in the Trident 20.10.0 release.


Wiki - Typo - "programatically" instead of "programmatically"

I believe there's a small typo in the wiki, at the Authentification section, under Auth and Users. It says "programatically" instead of "programmatically" (two ms).

I've made the necessary changes: https://github.com/bigbite/wp-cypress/wiki/Auth-and-Users#authentification


Add WinCompose: easily write special characters

A handy tool sitting in the system tray, adding the possibility to write accented characters (or any Unicode pattern) from a hot key.

Cool 👍
1000 issues/PRs 🎉

Woo hoo!


When remote region url is not reachable , metadata takes very long to respond and scheduler keeps getting recreated.

Rancher versions:v1.6.13-rc6
Steps to reproduce the problem:
Deploy rancher servers for region1 and region2.
Have cross regions links between environments in region1 and region2.
Make region1's url unreachable.
Metadata requests in region2 start taking very long time to respond ( like 30-45 secs).
Scheduler service becomes unhealthy and scheduler containers keep getting recreated since they get stuck in Initializing state forever.

With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.


'APP' and 'STG' logs fail to show up

Describe the bug
We’re currently facing issues with loggregator-bridge. When doing cf logs logs of type APP and STG fail to show up.
To Reproduce
We've seen failing in two different scenarios.
scenario 1: we’ve got a long-running deployment of kubecf with eirini and noticed that after a while, APP and STG logs stop appearing during cf logs. I’ve traced it down to loggregator-bridge. The pod logs looks like:
{"level":"info","ts":1615161473.9439654,"caller":"kubeconfig/getter.go:53","msg":"Using in-cluster kube config"}
{"level":"info","ts":1615161473.9440942,"caller":"kubeconfig/checker.go:36","msg":"Checking kube config"}
Error:  unexpected EOF
Error:  unexpected EOF
Received non-pod object in watcher channel

scenario 2: after a fresh installation of kubecf+eirini on OpenShift 4.6 (k8s version 1.19), the cf logs fail to appear and the problem is the exact same as above.
Expected behavior
When doing cf logs I should be able to also see APP and STG logs.
Environment
KubeCF version: 2.7.12
Eirini version: 1.8
Kubernetes: 1.19
Additional context
This was tested on OpenShift 4.4 and 4.6

Tested also on AKS and seeing the same problem:
$ k logs loggregator-bridge-59f5cb64bc-9scbb -n kubecf
{"level":"info","ts":1615563276.4147344,"caller":"kubeconfig/getter.go:53","msg":"Using in-cluster kube config"}
{"level":"info","ts":1615563276.414798,"caller":"kubeconfig/checker.go:36","msg":"Checking kube config"}
Received non-pod object in watcher channel
Error:  unexpected EOF

@mudler Any ideas what this might be / where to look next?

@jbuns Sorry, I know nothing about the eirini-loggregator-bridge, and have no time to learn about it.
Let's see if @mudler can give you hints next week; this week has been Hackweek at SUSE, so everyone has been working on other stuff... (FWIW, I spend half a day of my hackweek time yesterday on getting Eirini-1.8 to continue to work with the latest cf-deployment, so we don't have to drop it (yet) for the kubecf-2.8 releases).

It looks like we are receiving old events in the channel - this reminds me the work done in EiriniX about that https://github.com/cloudfoundry-incubator/eirinix/pull/38 - is the loggregator-bridge using latest EiriniX including that fix? Otherwise, the alternative  is specifying manually a ResourceVersion to start watch on.
From the error message, it looks the watcher is starting to listen on events which are old and not there anymore - while the above PR was meant to fetch the latest ResourceVersion during start to fix exactly that issue

@mudler loggregator-bridge is using eirinix v0.3.1
https://github.com/cloudfoundry-incubator/eirini-loggregator-bridge/blob/master/go.mod#L4
so I'm assuming that it's got the fix you've mentioned since https://github.com/cloudfoundry-incubator/eirinix/pull/38 was merged since v0.2.0:
https://github.com/cloudfoundry-incubator/eirinix/compare/v0.2.0...master
Does that mean that the manager in eirinix is the one that's failing? Only difference I can see between the PR above and what's in the code now is this line:
https://github.com/cloudfoundry-incubator/eirinix/blob/master/manager.go#L298

The status Message:too old resource version seems to be an expected behaviour according to kubernetes:
https://github.com/kubernetes/kubernetes/issues/22024
It looks like podwatcher needs to be updated in order to handle this, rather than erroring out.
@mudler any preference on how I should fix this or should I just come up with the fix and it can be reviewed in a PR?


Nested owned types are reset during DetectChanges

Nested owned entities do not get updated. As far as I can see in the docs, it should be possible to have a type owned by a type owned by an entity. However, when you such an entity is loaded and the nested entity changed, the values of the nested entity get reset to their last loaded value in DbContext.SaveChanges() or more specifically in ChangeTracker.DetectChanges(),
Example domain and context:
internal class Course
{
    public Guid Id { get; private set; }
    public TrackPeriod Period { get; private set; }
}

internal class TrackPeriod
{
    public int Track { get; private set; }
    public Date Beginning { get; private set; }
    public Date End { get; private set; }
}
internal class Date
{
    public int Year { get; private set; } = 1;
    public int Month { get; private set; } = 1;
    public int Day { get; private set; } = 1;
}

internal class CoursesContext : DbContext
{
    public CoursesContext(DbContextOptions<CoursesContext> options) : base(options)
    {
    }

    public DbSet<Course> Courses { get; private set; }

    protected override void OnModelCreating(ModelBuilder modelBuilder)
    {
        base.OnModelCreating(modelBuilder);

        modelBuilder.Entity<Course>().OwnsOne(t => t.Period);

        var datePeriodModelBuilder = modelBuilder.Entity<TrackPeriod>();
        datePeriodModelBuilder.OwnsOne(t => t.Beginning);
        datePeriodModelBuilder.OwnsOne(t => t.End);
    }
}

Steps to reproduce:

Open db context
Add new Course and SaveChanges()
Open new db context
Load and modify previously added course.
Call SaveChanges()
During the last call to SaveChanges() the nested entity's values are reset to the ones it was loaded with.

Further technical details
EF Core version: 2.2.6 (latest 3.0.0-preview6.19304.10 throws an Exception during query generation)
Database Provider: InMemory, SQLite, SqlServer
Operating system: Win10 64-bit
IDE: Visual Studio 2019
Sample project:
EFCoreOwnsTest.zip

Verified that this is fixed in the current 3.0 code. Probably a duplicate of #12118


enlarge scheduler latches bucket

Enlarge scheduler latches bucket. Large bucket is more friendly for load data.

@siddontang @ngaut @BusyJay PTAL

LGTM

LGTM


Support for ".eslintrc.js"

ESLint has lately introduced support for using an .eslintrc.js file among other formats which adds the ability to include comments into the files. Would it be possible to add support for those files to the plugin too?

I believe this should already be working, can someone test?

I've just been reading up on https://github.com/jonathanKingston/ember-cli-eslint/pull/53 and love what having this work here would enable.
@rwjblue I haven't tried yet, but I'll be able to dig in to this a bit more later today and I can check then. In either case, I might also like to add something to the test suite that explicitly makes sure this is covered.

I just tested this with<EMAIL_ADDRESS>and indeed it seems to work without any issues!


Bug 670722: fix the LISTED_STATUSES tuple.

Fixes the issue where unreviewed addons are listed for a dev.

https://bugzilla.mozilla.org/show_bug.cgi?id=670722 is closed, closing pull request. If that's incorrect, please reopen.


TcpServer listening problem in iOS

Hi
I have put together a simple tcp server and client example here:
https://github.com/jmc420/react-native-examples/blob/master/TcpServerProblem/README.md
Everything works well in android but in an iOS environment, the Tcp server stops listening after a client disconnects and will not accept any further connections.

thanks for doing all this footwork, i'm investigating this issue further.

@JasonMore #28 should fix this issue. would you be able to try it out?

@aprock @jmc420 This fix works great thanks! I spent some time yesterday trying to figure it out myself, but glad you were able to fix it.


Training Loss Function

What is the loss function you use during training, LM loss, or ranknet loss？

We train our models with the standard teacher forcing objective.


FIX: Image.renderText() in Xcode 12 beta 5

Adding Image.renderText() is great work.
But the renderText method should pass pointers instead of values to gdImageStringFT. In fact, this causes compiler Errors in Xcode 12 Beta 5 (Swift 5.5).
This PR fixes these errors.
Additional info:
(swiftlang-13<IP_ADDRESS> clang-13<IP_ADDRESS>)

Just to be sure, this is also compatible with earlier versions of Swift, right?

@twostraws I’m going to test it in Docker
Action Items for this PR:

[ ] Confirm this works in earlier versions of Swift
[ ] More and better tests

@twostraws Updated. I have confirmed this works in earlier versions of Swift

Perfect - thank you very much!


Add Kate

https://github.com/nazya/KATE
note that you can't lift the code as-is. Parameters are passed over in a "cfg" variable and also there's an issue with it not checking if gradients are none and how the "device" value is read. Maybe more issues than that.

@tfriedel thanks for the request! As you said, the official code was incorrectly implemented and had several issues, unlike the paper. I corrected the implementation and checked the optimizer working.

@kozistr
Cool! Did you try it and get decent results? I had fixed the obvious issues I mentioned and tried it out, but results were poor. However it would need more testing to check if it's an implementation issue or not.

@kozistr Cool! Did you try it and get decent results? I had fixed the obvious issues I mentioned and tried it out, but results were poor. However it would need more testing to check if it's an implementation issue or not. Haven't checked your implementation yet.

actually, I didn't test it on the other benchmark datasets (just tested with the toy example in the t test case).
it seems there are differences between the original code and the pseudocode in the paper. So, I re-implemented it based on the paper though.

@kozistr Cool! Did you try it and get decent results? I had fixed the obvious issues I mentioned and tried it out, but results were poor. However it would need more testing to check if it's an implementation issue or not. Haven't checked your implementation yet.

just added the visualizations here.
ran the visualization on Rosenbrock and Rastrigin functions. here's the result of Kate optimizer, and the result seems fine (not diverged, maybe working).
if I'm available, will add more tests on the benchmark datasets like imagenet, mnist too.

Interesting! I didn't know about Rastigrin.
Having some more relalistic benchmarks for all these optimiziers would be nice. Do you know about
https://github.com/mlcommons/algorithmic-efficiency
?
I know prodigy and schedule-free were submitted for this benchmark.
Also you may be interested in this twitter thread about optimizers:
https://x.com/_clashluke/status/1808590060654108910
For example there was a mention of a grafted Lion#Adam optimizer:
https://x.com/dvruette/status/1627663196839370755

Interesting! I didn't know about Rastigrin. Having some more relalistic benchmarks for all these optimiziers would be nice. Do you know about https://github.com/mlcommons/algorithmic-efficiency ? I know prodigy and schedule-free were submitted for this benchmark.
Also you may be interested in this twitter thread about optimizers: https://x.com/_clashluke/status/1808590060654108910
For example there was a mention of a grafted Lion#Adam optimizer: https://x.com/dvruette/status/1627663196839370755

thanks for the resources! I'll try some


Feature: Use OS-configured DNS servers if not provided or if requested

UNIX-like: use /etc/resolv.conf
Windows: API to pull configured DNS servers?

Not sure if the miekg/dns package provides helper functions for this or not, best to check there before writing our own.

Windows: API to pull configured DNS servers?

Since it is fairly common to have multiple adapters, how to limit which DNS servers are returned? Just check them all? Add flag / setting to ignore WiFi or VPN adapter-provided DNS servers?

See also https://github.com/improbable-eng/go-srvlb/pull/4/files

Relevant:

https://github.com/miekg/dns/issues/334

This gist was mentioned:

https://gist.github.com/moloch--/9fb1c8497b09b45c840fe93dd23b1e98

which provides code similar to:
package main

import (
	"fmt"
	"log"
	"strings"
	"unsafe"

	"github.com/miekg/dns"
	"golang.org/x/sys/windows"
)

func dnsClientConfig() (*dns.ClientConfig, error) {
	l := uint32(20000)
	b := make([]byte, l)

	if err := windows.GetAdaptersAddresses(windows.AF_UNSPEC, windows.GAA_FLAG_INCLUDE_PREFIX, 0, (*windows.IpAdapterAddresses)(unsafe.Pointer(&b[0])), &l); err != nil {
		return nil, err
	}
	var addresses []*windows.IpAdapterAddresses
	for addr := (*windows.IpAdapterAddresses)(unsafe.Pointer(&b[0])); addr != nil; addr = addr.Next {
		addresses = append(addresses, addr)
	}

	resolvers := map[string]bool{}
	for _, addr := range addresses {
		for next := addr.FirstUnicastAddress; next != nil; next = next.Next {
			if addr.OperStatus != windows.IfOperStatusUp {
				continue
			}
			if next.Address.IP() != nil {
				for dnsServer := addr.FirstDnsServerAddress; dnsServer != nil; dnsServer = dnsServer.Next {
					ip := dnsServer.Address.IP()
					if ip.IsMulticast() || ip.IsLinkLocalMulticast() || ip.IsLinkLocalUnicast() || ip.IsUnspecified() {
						continue
					}
					if ip.To16() != nil && strings.HasPrefix(ip.To16().String(), "fec0:") {
						continue
					}
					resolvers[ip.String()] = true
				}
				break
			}
		}
	}

	// Take unique values only
	servers := []string{}
	for server := range resolvers {
		servers = append(servers, server)
	}

	// TODO: Make configurable, based on defaults in https://github.com/miekg/dns/blob/master/clientconfig.go
	return &dns.ClientConfig{
		Servers:  servers,
		Search:   []string{},
		Port:     "53",
		Ndots:    1,
		Timeout:  5,
		Attempts: 1,
	}, nil
}

func main() {
	conf, err := dnsClientConfig()
	if err != nil {
		fmt.Printf("[!] error: %s\n", err)
	} else {
		for _, server := range conf.Servers {
			fmt.Printf("Server: %s\n", server)
		}
	}
}


Makka / #1741 add disclaimer modal

Description
Adds a disclaimer modal to Buy, Stake, Bonds & Wrap views.
Related Ticket
Resolves #1741
Checklist

[X] I have run npm run build-all without errors
[X] I have formatted JS and TS files with npm run format-all

@0xMakka thanks for quick turnaround on this
Is it possible to shrink all this so the modal fits properly and I don't need to scroll on a typical macbook laptop screen?

@jabby09 I've reduced the text size of the content, removed extra whitespace between the title and content also. Can you see if this helps? Here it is on my 14-inch macbook screen

@0xMakka getting there...
the focus on mobile is fixed
however, now when I gesture up (to scroll the modal to the bottom) when I release my finger the modal bounces back to the top - so I can never click the accept button. It ends up hidden behind the Chrome footer controls.

Hey @jabby09, made some more fixes around mobile. Can you check did it fix the issues you are seeing?

nailed it thank you!


Mineraft crashes with only your mod installed

latest.log

The crash is due to the full Cardinal Components API package breaking the game, not directly from Numismatic Overhaul.
We are working on a fix to only include the required modules so you don't have to download them.

Fixed in 0.1.5


#fn fill all fields of DataConnection class while dataset creation

Description
There is a missing field while creating a dataset of Oracle connection.
so dataset creation was failed
Related Issue : None
How Has This Been Tested?
If you can create a dataset of Oracle connection with no error, it is OK
Need additional checks?
make sure that you are using an extension for oracle connection
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.

Additional Context

run build
deploy to 3


full build instructions

no need to build pcre-8.39.tar.gz yourself pcre development packages available in all systems.
it will prevent problems LD_LIBRARY_PATH because of with incorrectly configured build of pcre library.
# ubuntu contains swig3 that does not support new-nodejs/v8.
# need to install swig4 from git:

if swig -version|grep -q 'Version 3.' # if swig 3 exists
then

  apt remove swig swig3.0

  sudo apt-get install build-essential autoconf automake libtool bison git

  sudo apt-get install libpcre3-dev

  git clone https://github.com/swig/swig.git
  cd swig
  ./autogen.sh && ./configure && make
  make install
  cd ..
fi

ldconfig  # update cache
if ldconfig -pv| grep -q libgridstore  # if libgridstore.so exists
then
  git clone https://github.com/griddb/c_client.git
  cd c_client/client/c
  ./bootstrap.sh
  ./configure
  make
  make install
  cd ../../..
fi

mkdir my_modules
cd my_modules
git clone https://github.com/griddb/nodejs_client griddb_node
cd griddb_node

echo '
{
  "name": "griddb_node",
  "version": "0.8.4",
  "description": "Node.JS Client for GridDB (an In-Memory NoSQL Database for highly scalable IoT applications)",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "repository": {
    "type": "git",
    "url": "git+https://github.com/griddb/nodejs_client.git"
  },
  "dependencies": {
    "nan": "^2.14.0"
  },
  "keywords": [
    "griddb",
    "client",
    "libgridstore",
    "iot"
  ],
  "author": "TOSHIBA Digital Solutions Corporation",
  "license": "Apache-2.0",
  "bugs": {
    "url": "https://github.com/griddb/nodejs_client/issues"
  },
  "homepage": "https://github.com/griddb/nodejs_client#readme",
  "files": [
    "index.js",
    "package.json",
    "lib",
    "sample",
    "README.md"
  ]
}
' > package.json

npm install # install nan from package.json
make
mv griddb_node.js index.js
cd ../..

npm install ./my_modules/griddb_node

use:
var Griddb=require('griddb_node')

maybe it is possible to make it build using a install.sh file that is activated on package install
or maybe it is possible to make it work from inside Makefile
also this there should be package.json file

Thank you for your comment and information of full build instructions.


left_sidebar: Apply grid to 'more conversations' DM row.

This PR applies the DM-area CSS grid to the 'more conversations' row, and fixes a corner-case unread-count display in the process.
CZO discussion
Screenshots and screen captures:

Before
After
After, showing grid

Looks great, merged, thanks @karlstolley!


Auto active substep

I think it's useful to let use active a substep after enter the step, so the first substep (or specified substep) is active at first, then can be hidden after.  e.g. we can show a slogan at first, then replacing it with actually content.
I thought of some way:

add attribute data-substep-active/data-substep-active=<substep-idx> to step element
add attribute data-substep-active to a substep element
add class substep-auto-active to a substep element

I like 3 as it is analogous to
https://github.com/impress/impress.js/blob/78c954ac09e7bc93c3f5467755e2cf47f217b188/src/impress.js#L484-L488

这是来自QQ邮箱的假期自动回复邮件。你好，我最近正在休假中，无法亲自回复你的邮件。我将在假期结束后，尽快给你回复。

Substeps can only be actived one by one. For example, for a step with 3 substeps, it should have only the follow states:

Neither substeps actived
Substep 1 actived
Substep 1 and 2 actived
Substep 1, 2 and 3 actived

I can't image what should happen while user press the space if just substep 3 is actived.  Should only substep 1 actived? or substep 1 and 3 is actived?
I think auto active the very first substep is meanful, e.g. auto highlight substep 1, then unhighligh substep 1 and highlight substep 2, and so on.  So I think it's reasonable to add a class substep-auto-active to the step element, make the first substep of that step be auto actived.  This is different from the 3 ways in the top post, using class instead of attribute.
Don't know if we have a guideline about when to use class, and when to use attribute?

I've always preferred CSS class when possible. This way you can also use CSS directly against this class.

Hmm... I'm only now paying more attention to what you are trying to do...
It should be possible to do what you want already with just CSS: Just add substep-visible and substep-active to the first substep and this should make the slide look like you had just pressed space one already.

It should be possible to do what you want already with just CSS: Just add substep-visible and substep-active to the first substep and this should make the slide look like you had just pressed space one already.

When we enter the slide the second time, the class will be removed.  So I think we have to introduce new class.

Ah, hmm... Good point...
Even so, rather than adding a new css class, I would still want to discuss whether existing commands could be used to achieve what you want. I can actually think of 2 alternatives:

You could submit a PR which changes the behaviour such that what I suggested above becomes possible. In particular, it seems that the substep module should maybe save the starting state of a slide and then reuse it if the slide is shown a second time?
The module that you would generally use to automatically show a substep is actually the autoplay module. It is also used in https://impress.js.org/examples/classic-slides/#/step-9. However, this cannot conveniently be done for the first substep, because there isn't a "previous" substep where to put the autoplay command. You could put the autoplay command on the step itself, but it is cumbersome to do that for an effect you want to use just for one substep, not all.
** I think the right solution down this path would be something like <div class="step" data-autoplay-once="0.1">.
This would automatically move to the first substep after 0.1 seconds, but would not automatically move to further substeps. Of course, if there are no substeps, the same command would move to the next slide.

What do you think? I actually like the second option.


Point people to the OTLP Datadog Agent feature

What does this PR do?

Add link to future section on the Datadog Agent OTLP endpoint.
Motivation

Cross-link this feature on the OpenTelemetry tile.
Additional Notes

Alternatives: we could do a different tile for this. IMO, we should wait until we are stable to do that.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

Yes, I like the wording you suggested, and went ahead and committed it. Thanks!

We can merge this, integrations-core is unfrozen.


Publish to APM

So that people can search and download it from within Atom.

https://atom.io/packages/language-galaxy


Use a key for hologram Builder

Being able to add a config to replace the scroll bar with a key to be able to use the hologram builder correctly. I do not have a working mouse making it difficult to build the items from the hologram builder.

I think something else rather other than a new hotkey will do, maybe a better gui?
The keyboard is already completly saturated with existing mods.

I just need something to replace the scroll bar and I said just a key because with schematica I just set the key to when I need to use it but then disable the key after I use it in game. Also wouldn't it take more time to set up a gui then just add a key toggled through the key binding menu?


MQTT delay in dev branch

I run dev branch of HA on ubuntu/x86, manual install, plenty of resources (quad-core i7-2635QM, 16GB of RAM, SSD). Mosquito is running on the same host as HA (and broker is acceded by <IP_ADDRESS>)
Before dev branch I was running whatever was stable version at the beginning of sumer. But due to tiredness of constant issue with zeroconf on restart I decided to give a try to dev, hopping it is fixed there. It was somewhere at the end of August.
What I found that dev branch introduces tremendous delay. Checked with zigbee2mqtt.
If I switch bulb in front-end, for example, it takes sometimes up to 10 seconds before MQTT message is published.
I tried rules where received MQTT message triggers sending another MQTT message - same story, so it is unlikely frontend.
I enabled debug logging for MQTT component but I see absolutely zero there aside of usual stuff you get when it works normally. It just this stuff delayed by same 1-10 seconds as MQTT messages.
Today I tried to update to current dev, and it is absolutely the same. Nothing change.

According to my testing, issue was introduced between 0.99.2 and 0.99.3

There was an issue with MQTT lags a long time ago https://github.com/home-assistant/home-assistant/issues/12716 , maybe some help to find the culprit.

Interesting. I checked diff between 0.99.2 and 0.99.3...and I see nothing which can affect this delay. Difference only in different frontend version (while test shows that this has nothing to do with frontend) and different zigpy-zigate version, which isn't used on my setup.
But I clearly see a difference when I move to 0.99.3 and rollback to 0.99.2.

@antst This is strange indeed.
If you do a fresh test installation and enable only MQTT, can you reproduce the issue on 0.99.3 but not on 0.99.2?


Add committime support for AzureDevOps / TFS (Git)

Add exporter support for AzureDevOps / TFS (Git)

Resolved by #264


Remove the push Registration Screen

Related issues:

AEROGEAR-3069

I can see there is no registration page anymore.
@ciaranRoche not sure I understand your comment.

@ciaranRoche the trello card was updated based on the comments/feedback.. The JIRAs should have been updated. I will do that now. Sorry for confusion

the push registration screen only exists in Android so the other JIRAs should have been closed. Will close them now.

@wei-lee Pretty much what Laura said, I got some confusion based on the JIRA's


Introduce new TIL string helpers, teach older ones to use wmemcmp

til::equals:
At the time of writing wmemcmp() is not an intrinsic for MSVC,
but the STL uses it to implement wide string comparisons.
This produces 3x the assembly per comparison and increases
runtime by 2-3x for strings of medium length (16 characters)
and 5x or more for long strings (128 characters or more).
See: https://github.com/microsoft/STL/issues/2289
Additionally a number of case insensitive, locale unaware
helpers for prefix/suffix comparisons are introduced.

Please let me know what you think about this. 🙂

@msftbot make sure @miniksa signs off

Make sure (1) it actually builds and (2) very specifically, that the full solution builds on ARM64

I can't get this to compile properly so I'll pivot and add a different method (til::equal) for future use...

So yeah I've reverted almost all of the changes now because I can't for my life figure out how to overload WEX's VerifyEqual struct to use my overloads and not run in ambiguity errors:
error C2593: 'operator ==' is ambiguous (compiling source file ConptyOutputTests.cpp)
could be 'bool operator ==(const std::wstring &,const std::wstring_view &) noexcept' (compiling source file ConptyOutputTests.cpp)
or       'bool operator ==(const std::wstring_view &,const std::wstring_view &) noexcept' (compiling source file ConptyOutputTests.cpp)
or       'bool std::operator ==<wchar_t,std::char_traits<wchar_t>,1>(const std::basic_string_view<wchar_t,std::char_traits<wchar_t>>,const std::basic_string_view<wchar_t,std::char_traits<wchar_t>>) noexcept' (compiling source file ConptyOutputTests.cpp)
while trying to match the argument list '(const wchar_t [2], const T2)'
    with
    [
        T2=std::wstring_view
    ] (compiling source file ConptyOutputTests.cpp)

derp i renamed it to "to use wmemcmp" when i meant "to use memcmp". Oh well.


Add geodesic option for measure

Add geodesic measurement option to the measure example.

Okay I've cleaned this up @ahocevar according to our discussions. To summarize:

use harversine distance on the sphere for distance measurements
add vincentyArea function (and pass on the coordinate array of the linear ring) on the sphere, include the same reference as in OpenLayers 2 since the code is a "migration" of that code
do not export ol.sphere.WGS84 but use the same snippet as is already in the API docs for ol.Sphere (so specify the radius in the example)

@ahocevar I incorporated your latest review comments, let me know if you have more coming

Looks good now. Please merge when Travis is happy.

thanks for the extensive review and discussions @ahocevar !


Add: NaturalInteger

Unsigned systems integers are the most useful type of integers and they kind of deserve a name. I also noticed that A) 2-by-1 signed division is rather useless and B) 2-by-1 signed division can be (and is) derived from 2-by-1 unsigned division. So I could lower that requirement to NaturalInteger.

Hm. Maybe the unchecked part of signed 2-by-1 division is useful, but error handling part isn't.


how to get ultimate skins ?

how to get ultimate skins of agario?
what is the direct link of skins 11/07/16 ??

not relevant to the project

thx


llama3:

Can we pull llama3 using this genai-stack? I was not sure, if the docker files are configured to pull llama3......Have pulled and used llama2 before.....

I used llama3 with my Ollama installation. In my case, Ollama is installed separately on macOS and started with ollama serve before executing docker compose up as the instructions suggest. (Of course, I had llama3 pulled already on my Ollama installation.)
Are you running on Linux? I haven't tested on that.

Yes.....I am running on Linux.....I am using Ubuntu 18.04 LTS......I tried using the same docker compose codes and only replaced Llama3 in place of Llama2......It pulled all the necessary containers.......But could see lot of bugs in chat BOT, as well as pdf BOT......

Yes.....I am running on Linux.....I am using Ubuntu 18.04 LTS......I tried using the same docker compose codes and only replaced Llama3 in place of Llama2......It pulled all the necessary containers.......But could see lot of bugs in chat BOT, as well as pdf BOT......

Have successfully run Llama3:8B.....When I initiate the first chat-BOT through /localhost/8501/, the UI for prompting continues to hide behind the RAG enable/disable box.....But when you copy and paste a text file, by pointing slightly into the "prompt-box", it accepts the entry and gives the response......All other BOTs are working normally.......I tried Llama:70B, but it took way beyond the normal pulling time and exited......


Add Continuous Deployment

Purpose
We need be able to automatically deploy:

master to a staging instance
master:tag to a production instance

Proposal

Define a deployment strategy
Use CircleCI to deploy

Please document this process. Who is deploying what, from where to where and when?

Fixed since f7345c9 (see docs/deployment.md).


Error "Command failed: ninja -v"  when compiling with wasm32:emscripten

Hello,
I am trying to install lib GEOS with wasm32:emscripten on windows but I get an error related to Ninja.
I am able to compile normally with x86 triplet.
The same error occurs with any other lib I tried when using wasm32:emscripten.
Any idea what could I be doing wrong? Thanks,
C:\dev\Emscripten\vcpkg>vcpkg install geos:wasm32-emscripten
Computing installation plan...
The following packages will be built and installed:
    geos[core]:wasm32-emscripten -> 3.10.0
Detecting compiler hash for triplet wasm32-emscripten...
A suitable version of powershell-core was not found (required v7.2.1). Downloading portable powershell-core v7.2.1...
Downloading powershell-core...
  https://github.com/PowerShell/PowerShell/releases/download/v7.2.1/PowerShell-7.2.1-win-x86.zip -> C:\dev\Emscripten\vcpkg\downloads\PowerShell-7.2.1-win-x86.zip
Extracting powershell-core...
Error: while detecting compiler information:
The log content at C:\dev\Emscripten\vcpkg\buildtrees\detect_compiler\stdout-wasm32-emscripten.log is:
-- Downloading https://github.com/ninja-build/ninja/releases/download/v1.10.2/ninja-win.zip -> ninja-win-1.10.2.zip...
-- Configuring wasm32-emscripten
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:128 (message):
    Command failed: ninja -v
    Working Directory: C:/dev/Emscripten/vcpkg/buildtrees/detect_compiler/wasm32-emscripten-rel/vcpkg-parallel-configure
    Error code: 1
    See logs for more information:
      C:\dev\Emscripten\vcpkg\buildtrees\detect_compiler\config-wasm32-emscripten-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_cmake.cmake:370 (vcpkg_execute_required_process)
  scripts/detect_compiler/portfile.cmake:18 (vcpkg_configure_cmake)
  scripts/ports.cmake:145 (include)

Error: vcpkg was unable to detect the active compiler's information. See above for the CMake failure output.

Here is the content of the log file (config-wasm32-emscripten-out.log):
[1/1] cmd /c "cd .. && "C:/Program Files/CMake/bin/cmake.exe" "C:/dev/Emscripten/vcpkg/scripts/detect_compiler" "-DCMAKE_MAKE_PROGRAM=C:/dev/Emscripten/vcpkg/downloads/tools/ninja/1.10.2-windows/ninja.exe" "-DCMAKE_SYSTEM_NAME=Emscripten" "-DBUILD_SHARED_LIBS=OFF" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/dev/Emscripten/emsdk/upstream/emscripten/cmake/Modules/Platform/Emscripten.cmake" "-DVCPKG_TARGET_TRIPLET=wasm32-emscripten" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=external" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/dev/Emscripten/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=wasm32" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/dev/Emscripten/vcpkg" "-DZ_VCPKG_ROOT_DIR=C:/dev/Emscripten/vcpkg" "-D_VCPKG_INSTALLED_DIR=C:/dev/Emscripten/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=C:/dev/Emscripten/vcpkg/packages/detect_compiler_wasm32-emscripten""
FAILED: ../CMakeCache.txt
cmd /c "cd .. && "C:/Program Files/CMake/bin/cmake.exe" "C:/dev/Emscripten/vcpkg/scripts/detect_compiler" "-DCMAKE_MAKE_PROGRAM=C:/dev/Emscripten/vcpkg/downloads/tools/ninja/1.10.2-windows/ninja.exe" "-DCMAKE_SYSTEM_NAME=Emscripten" "-DBUILD_SHARED_LIBS=OFF" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/dev/Emscripten/emsdk/upstream/emscripten/cmake/Modules/Platform/Emscripten.cmake" "-DVCPKG_TARGET_TRIPLET=wasm32-emscripten" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=external" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/dev/Emscripten/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=wasm32" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/dev/Emscripten/vcpkg" "-DZ_VCPKG_ROOT_DIR=C:/dev/Emscripten/vcpkg" "-D_VCPKG_INSTALLED_DIR=C:/dev/Emscripten/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=C:/dev/Emscripten/vcpkg/packages/detect_compiler_wasm32-emscripten""
CMake Error at C:/dev/Emscripten/emsdk/upstream/emscripten/cmake/Modules/Platform/Emscripten.cmake:133 (message):
  Failed to fetch compiler version information with command
  "'C:/dev/Emscripten/emsdk/upstream/emscripten/emcc.bat' -v"! Process
  returned with error code 9009.
Call Stack (most recent call first):
  C:/dev/Emscripten/vcpkg/scripts/buildsystems/vcpkg.cmake:206 (include)
  C:/Program Files/CMake/share/cmake-3.22/Modules/CMakeDetermineSystem.cmake:124 (include)
  CMakeLists.txt:2 (project)

-- Configuring incomplete, errors occurred!
ninja: build stopped: subcommand failed.

Here is the output when running "emcc.bat -v" alone :
C:\dev\Emscripten\vcpkg>C:\dev\Emscripten\emsdk\upstream\emscripten\emcc.bat -v
emcc (Emscripten gcc/clang-like replacement + linker emulating GNU ld) 3.1.8 (3ff7eff373d31d8c0179895165462019221f192e)
clang version 15.0.0 (https://github.com/llvm/llvm-project 80ec0ebfdc5692a58e0832125f2c6a991df9d63f)
Target: wasm32-unknown-emscripten
Thread model: posix
InstalledDir: C:\dev\Emscripten\emsdk\upstream\bin

This issue hasn’t been updated in 3 months, if it is still an issue, please reopen this issue.

I am also experiencing the same issue with vcpkg install zlib-ng:wasm32-emscripten.


cant train not on collab and not locally anymore

97% 205M/211M [00:03<00:00, 67.3MiB/s]
100% 211M/211M [00:18<00:00, 67.3MiB/s]>> DVAE weights restored from: /content/xtts-webui/models/v2.0.2/dvae.pth
| > Found 58 files in /content/xtts-webui/finetuned_models/ShakedAudio/dataset
usage: app.py [-h] [--continue_path CONTINUE_PATH] [--restore_path RESTORE_PATH]
[--best_path BEST_PATH] [--use_ddp true/false] [--use_accelerate true/false]
[--grad_accum_steps GRAD_ACCUM_STEPS] [--overfit_batch true/false]
[--skip_train_epoch true/false] [--start_with_eval true/false]
[--small_run SMALL_RUN] [--gpu GPU] [--rank RANK] [--group_id GROUP_ID]
app.py: error: argument -h/--help: ignored explicit argument 's'
Traceback (most recent call last):
File "/usr/lib/python3.10/argparse.py", line 1878, in parse_known_args
namespace, args = self._parse_known_args(args, namespace)
File "/usr/lib/python3.10/argparse.py", line 2091, in _parse_known_args
start_index = consume_optional(start_index)
File "/usr/lib/python3.10/argparse.py", line 1999, in consume_optional
raise ArgumentError(action, msg % explicit_arg)
argparse.ArgumentError: argument -h/--help: ignored explicit argument 's'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/content/xtts-webui/modules/train.py", line 87, in train_model
speaker_xtts_path, config_path, original_xtts_checkpoint, vocab_file, exp_path, speaker_wav = train_gpt(
File "/content/xtts-webui/scripts/utils/gpt_train.py", line 183, in train_gpt
trainer = Trainer(
File "/usr/local/lib/python3.10/dist-packages/trainer/trainer.py", line 397, in init
args, coqpit_overrides = self.parse_argv(args)
File "/usr/local/lib/python3.10/dist-packages/trainer/trainer.py", line 680, in parse_argv
training_args, coqpit_overrides = parser.parse_known_args()
File "/usr/lib/python3.10/argparse.py", line 1881, in parse_known_args
self.error(str(err))
File "/usr/lib/python3.10/argparse.py", line 2606, in error
self.exit(2, _('%(prog)s: error: %(message)s\n') % args)
File "/usr/lib/python3.10/argparse.py", line 2593, in exit
_sys.exit(status)
SystemExit: 2
Traceback (most recent call last):
File "/usr/local/lib/python3.10/dist-packages/gradio/queueing.py", line 489, in call_prediction
output = await route_utils.call_process_api(
File "/usr/local/lib/python3.10/dist-packages/gradio/route_utils.py", line 232, in call_process_api
output = await app.get_blocks().process_api(
File "/usr/local/lib/python3.10/dist-packages/gradio/blocks.py", line 1561, in process_api
result = await self.call_function(
File "/usr/local/lib/python3.10/dist-packages/gradio/blocks.py", line 1179, in call_function
prediction = await anyio.to_thread.run_sync(
File "/usr/local/lib/python3.10/dist-packages/anyio/to_thread.py", line 33, in run_sync
return await get_asynclib().run_sync_in_worker_thread(
File "/usr/local/lib/python3.10/dist-packages/anyio/_backends/_asyncio.py", line 877, in run_sync_in_worker_thread
return await future
File "/usr/local/lib/python3.10/dist-packages/anyio/_backends/_asyncio.py", line 807, in run
result = context.run(func, *args)
File "/usr/local/lib/python3.10/dist-packages/gradio/utils.py", line 678, in wrapper
response = f(*args, **kwargs)
File "/content/xtts-webui/modules/train.py", line 245, in train_xtts_model
shutil.copy(speaker_reference_path, reference_destination)
File "/usr/lib/python3.10/shutil.py", line 417, in copy
copyfile(src, dst, follow_symlinks=follow_symlinks)
File "/usr/lib/python3.10/shutil.py", line 254, in copyfile
with open(src, 'rb') as fsrc:
FileNotFoundError: [Errno 2] No such file or directory: 'finetuned_models/ShakedAudio/ready/reference.wav'

the same
 File "C:\Users\1\AppData\Local\Programs\Python\Python31011\lib\shutil.py", line 557, in copytree
    with os.scandir(src) as itr:
FileNotFoundError: [WinError 3] Системе не удается найти указанный путь:

I am crying


Added warning for referencing User directly from django.contrib.auth.models

Changed readme to help prevent a mistake which would result in "AttributeError: Manager isn't available; User has been swapped for 'app.UserModel'"
If one was to use the web api from django-rest-framework as is, install Djoser, then try to implement a custom user model, they would run into this issue. Though I'm very new to Django and perhaps other users would not run into this problem, I had a lot of trouble with this since most of my searching for the said error lead to old StackOverflow questions that were unrelated to Djoser.
I think adding this little bit of text could potentially save users of Djoser from a lot of time searching online and looking in the wrong direction.

I was quite tiered when I made this and didn't write my change to the README in the best way possible, I'll just open a suggestion on the repo instead

Also this is outside the scope of Djoser and is more related to django-rest-framework, I just realized


how to implement cors with angular js ?

this is my  js  example  :
angular.module('starter', [])
.config(function($httpProvider) {
$httpProvider.defaults.useXDomain = true;
delete $httpProvider.defaults.headers
.common['X-Requested-With'];
})
.controller('registerController',function($scope,$window,$location,$http)  {
$scope.register=function (){
$http({
method: 'GET',
url: 'http://ecs999.eicp.net:8000/hui2hui_register123',
headers: {
withCredentials:true
},
data: {
"userinfo":"xx"
}
}).success(function(data) {
Window.alert(data);
}).error(function(data) {
Window.alert(data);
});
    };

})
when it executed ,
it  cannot visit the url adress  above ,whether the code above have something wrong or the the file on the server have something wrong ?
I want to make sure that the js file  is correct or not ?
if it is wrong ,how should I modify it?

@xiaoliuliu2050 this is not the right place to ask those type of general support questions, see: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#question
For the CORS-related background info you might check http://www.html5rocks.com/en/tutorials/cors/


:sparkles: Enable Ruff security rules (bandit)

Enabling security rules in Ruff:
lamindb/_annotate.py:962:9: S101 Use of `assert` detected
lamindb/_annotate.py:1168:5: S101 Use of `assert` detected
lamindb/_artifact.py:971:9: S101 Use of `assert` detected
lamindb/_can_validate.py:226:9: S110 `try`-`except`-`pass` detected, consider logging the exception
lamindb/_collection.py:103:9: S101 Use of `assert` detected
lamindb/_feature.py:142:5: S101 Use of `assert` detected
lamindb/_finish.py:106:13: S602 `subprocess` call with `shell=True` identified, security issue
lamindb/_finish.py:127:13: S602 `subprocess` call with `shell=True` identified, security issue
lamindb/core/_feature_manager.py:379:5: S101 Use of `assert` detected
lamindb/core/_feature_manager.py:421:13: S101 Use of `assert` detected
lamindb/core/_feature_manager.py:432:17: S101 Use of `assert` detected
lamindb/core/_feature_manager.py:434:17: S101 Use of `assert` detected
lamindb/core/_feature_manager.py:538:9: S101 Use of `assert` detected
lamindb/core/_feature_manager.py:541:9: S101 Use of `assert` detected
lamindb/core/_feature_manager.py:569:9: S101 Use of `assert` detected
lamindb/core/_feature_manager.py:599:9: S101 Use of `assert` detected
lamindb/core/_label_manager.py:69:9: S112 `try`-`except`-`continue` detected, consider logging the exception
lamindb/core/_label_manager.py:105:13: S110 `try`-`except`-`pass` detected, consider logging the exception
lamindb/core/_mapped_collection.py:110:9: S101 Use of `assert` detected
lamindb/core/_run_context.py:47:24: S324 Probable use of insecure hash functions in `hashlib`: `md5`
lamindb/core/_run_context.py:117:16: S113 Probable use of requests call without timeout
lamindb/core/_settings.py:122:9: S101 Use of `assert` detected
lamindb/core/_sync_git.py:28:9: S602 `subprocess` call with `shell=True` identified, security issue
lamindb/core/_sync_git.py:39:9: S607 Starting a process with a partial executable path
lamindb/core/_sync_git.py:40:9: S602 `subprocess` call with `shell=True` seems safe, but may be changed in the future; consider rewriting without `shell`
lamindb/core/_sync_git.py:61:9: S602 `subprocess` call with `shell=True` identified, security issue
lamindb/core/_sync_git.py:71:9: S101 Use of `assert` detected
lamindb/core/_sync_git.py:85:13: S607 Starting a process with a partial executable path
lamindb/core/_sync_git.py:86:13: S602 `subprocess` call with `shell=True` seems safe, but may be changed in the future; consider rewriting without `shell`
lamindb/core/_sync_git.py:96:9: S602 `subprocess` call with `shell=True` identified, security issue
lamindb/core/_track_environment.py:18:66: S602 `subprocess` call with `shell=True` identified, security issue
lamindb/core/storage/_backed_access.py:210:13: S110 `try`-`except`-`pass` detected, consider logging the exception
lamindb/core/storage/_backed_access.py:308:17: S110 `try`-`except`-`pass` detected, consider logging the exception
lamindb/core/storage/paths.py:50:5: S101 Use of `assert` detected
lamindb/integrations/_vitessce.py:42:13: S101 Use of `assert` detected
tests/conftest.py:36:9: S607 Starting a process with a partial executable path
tests/conftest.py:36:51: S602 `subprocess` call with `shell=True` seems safe, but may be changed in the future; consider rewriting without `shell`
tests/test_run_context.py:107:9: S602 `subprocess` call with `shell=True` identified, security issue
Found 38 errors.

Just a show off for now! We can discuss later

Great! Let's discuss this tomorrow!

How does bandit compare to GitHub's CodeQL (see one of the GA jobs).

How does bandit compare to GitHub's CodeQL (see one of the GA jobs)?

I don't really see any or a lot of overlap. CodeQL seems to be pretty superficial for Python and only checks the most obvious issues. The advantages of CodeQL are that we can also use it for other languages and can use it's query language if we ever need to but I don't see a use-case for us.

(coverage may go down because we have a couple of untested exceptions now). I can add coverage for these in a followup PR quickly tomorrow.

I don't really see any or a lot of overlap. CodeQL seems to be pretty superficial for Python and only checks the most obvious issues. The advantages of CodeQL are that we can also use it for other languages and can use it's query language if we ever need to but I don't see a use-case for us.

So, the overlap is so small because CodeQL doesn't cover as many security issues as bandit for Python? The nature of the tools is the same in that they're both static code analyzers that detect security issues, correct?

Thanks for clarifying! For me to understand: The overlap is so small because CodeQL doesn't cover as many security issues as bandit for Python? The nature of the tools is the same in that they're both static code analyzers that detect security issues, correct?

Correct. CodeQL can also test for unreachable code and other things but we have all of that covered with other tools already. I am currently not impressed by CodeQL but enabling it doesn't hurt.

Hence: In those hard-to-test cases, I'd stick with the assert rather than introducing an additional line of code and an additional test with essentially no value to users & devs

Yeah that's fair. However, either we:

Go back to asserts and tell Bandit to ignore them.
Keep the exceptions and tell codecov to ignore them (if it works cough). Ignoring hard to test things with codecov is totally fine.

I vote for option 2.

Is it possible that the Mac environment is at fault and that's why this might not be caught by CI? I will see if I can still locally run the tests for this.

Mac uses zsh instead of bash by default, right? But that shouldn't change the behavior. So either the test is bad, or it does work without shell=True because I don't see it using any shell specific features.

I vote for option 2.

I think option 1 with a noqa and a brief comment next to it would be simpler because we wouldn't need to mess with codecov and we don't have these verbose sections in the code.
I care much more about simplicity than about the exact codecov coverage number. If there is no or minimal value add through additional complexity, I'd always go with what's simpler.
In this case, I'd say there is zero value add in a few instances where assert was replaced. Introducing complexity both within the code and the coverage CI doesn't seem to merit it. We also need to keep in mind that whatever convention is introduced in this PR will be mandated for future contributors. Explaining people how to "not count a specific except block in coverage" seems like a lot of luggage.
It's also error prone because some people might take it as an excuse to not test triggering the exception. Currently, we have this beautiful & simple rule that every exception needs to be triggered in tests. There can't be a single try except block that's not triggered.
If what you suggest means starting to distinguish between "meaningful exceptions" and "exceptions we add to make bandit happy" my reaction is: ohhhhh, let's please not do this. Nobody will get it.
So, unless I miss something, I vote for option 1. It's just a tiny bit of work to revert some of these exceptions back to asserts and add the noqa and the comment, and we'll not have headache with this topic going forward.

It's also error prone because some people might take it as an excuse to not test triggering the exception. Currently, we have this beautiful & simple rule that every exception needs to be triggered in tests. There can't be a single try except block that's not triggered.

I didn't really agree with all of your arguments because they can be made both ways, but this one is good. I'll revert to asserts where reasonable and then merge.

I didn't really agree with all of your arguments because they can be made both ways, but this one is good. I'll revert to asserts where reasonable and then merge.

How can any of the other arguments made both ways? 🤔

Correct. CodeQL can also test for unreachable code and other things but we have all of that covered with other tools already. I am currently not impressed by CodeQL but enabling it doesn't hurt.

I think I somewhat get this. Thanks!

Explaining people how to "not count a specific except block in coverage" seems like a lot of luggage.

Now we have to explain how to "circumvent the Bandit rule". We could ignore it in the config, but I actually think that it can be useful if developers think twice about whether this should be an internal assert or a user facing exception.

We could ignore it in the config, but I actually think that it can be useful if developers think twice about whether this should be an internal assert or a user facing exception.

I fully agree with you. I think each assert statement should have a noqa: ... and a comment.


missing subClassOf edges

Hi,
I found this tool and started to make use of it to visualize my RDF database, which is great!
I don't quite understand what is happening with respect to subClassOf edges though. This example helps demonstrate.
The class hierarchy is:

Subject

User
Group

From reading your paper I think that subClassOf relations should be the second step in extracting data.
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX : <http://example.org/schema#>
PREFIX d: <http://example.org/data#>

INSERT DATA {

    :Subject rdf:type rdfs:Class .
    :User rdf:type rdfs:Class ;
          rdfs:subClassOf :Subject .
    :Group rdf:type rdfs:Class ;
           rdfs:subClassOf :Subject .

    d:bobGroup rdf:type :Group ;
               :name "Bob's Group" .

    d:jimGroup rdf:type :Group ;
               :name "Jim's Group" .

    d:tony rdf:type :User ;
            :name "Tony" ;
            :memberOf d:jimGroup .

    d:bob rdf:type :User ;
          :name "Bob Himself" ;
          :memberOf d:bobGroup .
}

However, all I see is this. The Subject class is never shown.

While I was debugging this, I accidentally added a triple to the d:tony User making it of type Subject as well as User. This doesn't really make sense, but it did cause the subClassOf edge to start appearing, so I'm pretty sure the triples are correct, but for some reason, the subClassOf does not get explored when I didn't have the below triple.
d:tony rdf:type :Subject .

Visualization with the Subject type:

Thanks

Hi,
I think the behaviour you describe is intended and this is why:
First of all I don't think your class "Subject" will be discovered in your example because there are no entities which are directly Subjects, only Users and Groups.
This is the SPARQL query being used to extract the classes:
SELECT DISTINCT ?class (count(?sub) AS ?instanceCount)
WHERE {
	?sub a ?class.
}
GROUP BY ?class
ORDER BY DESC(?instanceCount);

As you see, there is no part to take instances of subclasses into account.
Secondly, as LD-VOWL only works on the ABox, subclass relations are detected via the number of common instances in step 2 of the extraction:
Speaking in sets you would expect this to be true:
|User| < |Subject| and |User ∩ Subject| = |User|

Every user is a subject but not every subject is a user, so the class User is a proper subset of class Subject which indicates User is a subclass of Subject
But if you make one entity of type User also of type Subject you will end up with the following:
|Subject| < |User| and  |User ∩ Subject| = |Subject|

Now the class Subject is a proper subset of User and this is why the arrow in your second screenshot goes into the wrong direction.
For more information about the extraction process please have a look at our EKAW paper Extraction and Visualization of TBox Information from SPARQL Endpoints  and if you have further questions feel free to ask.


refactor: destroy original component to reduce compilation time

Please describe the changes this PR makes and why it should be merged:
Status

[ ] Code changes have been tested against prettier, or there are no code changes
[ ] I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

[ ] This PR changes the codebase

[ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
[ ] This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)

[ ] This PR only includes non-code changes, like changes to documentation, README, etc.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 7 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 37.913%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/compiler/react/transform.ts
0
7
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
1131

Relevant Lines:
3069

💛  - Coveralls


Render city/town admin_level=8 boundaries more strongly

I've been working on mapping historical Rhode Island boundaries, and city/town boundaries are barely visible and don't get a label.  See this example of Kings Towne (map link):

It is defined by this polygon which seems like it's correctly mapped:

Link:
https://www.openhistoricalmap.org/relation/2828574#map=11/41.4785/-71.4214&layers=O&date=1722-03-24&daterange=1700-01-01,2024-12-31

I've updated the styling here to increase line thickness + slight color adjustment but I'll need to see it after fully deployed - below screen shot from Maputnik

looks like final deploy is slighty different than the rendering when drafting (in Maputnik the original line looked thicker than the above), so this is good to be paying attention to for lines of this thickness.

for names - pulled 7,8 from centroids data.
Note for future referencing, the name is associated with "admin" and not "town:

🧹 closing out some issues


Add support for selecting the size of the Tailscale ACI container

When the Tailscale container is deployed, the size is set to 1 CPU core and 1 GiB of memory. Currently there is no option to adjust this size, unless the aci.tf file is edited.
Provide option for user to specify cpu/ram directly or provide S/M/L/XL size option that can be selected when deploying.

Created branch aci_size to add features
Creating variable container_size

The size of the Tailscale ACI container instance can be set using the container_size variable, with the values small, medium or large. The CPU and Memory values for S/M/L are defined in aci.tf, and can be adjusted by changing the local variable maps for aci_cpu_cores and aci_memory_size.
  aci_cpu_cores = {
    "small" = "1.0"
    "medium" = "2.0"
    "large" = "3.0"
  }
  aci_memory_size = {
    "small" = "1.0"
    "medium" = "2.0"
    "large" = "4.0"
  }


Multiple feign clients (with different names) are mixing their HttpMessageConverters (and custom object mappers)

Hi,
I'm having the following 2 FeignClient configurations
@Configuration
public class ServiceAClientConfiguration {

    @FeignClient(name = "serviceA", url = "${service.a.url}", configuration = ServiceAClientFeignConfiguration.class)
    public interface ServiceAClient extends ServiceAResource {
    }

    @Configuration
    public static class ServiceAClientFeignConfiguration {

        @Bean
        public Decoder feignDecoder(@Qualifier("_halObjectMapper") ObjectMapper objectMapper) {
            ObjectMapper kebabObjectMapper = objectMapper.copy().setPropertyNamingStrategy(KEBAB_CASE);
            HttpMessageConverter jacksonConverter = new MappingJackson2HttpMessageConverter(kebabObjectMapper);
            ObjectFactory<HttpMessageConverters> objectFactory = () -> new HttpMessageConverters(jacksonConverter);
            return new ResponseEntityDecoder(new SpringDecoder(objectFactory));
        }
    }
}

@Configuration
public class ServiceBClientConfiguration {

    @FeignClient(name = "serviceB", url = "${service.b.url}", configuration = ServiceBClientFeignConfiguration.class)
    public interface ServiceBClient extends ServiceBResource {
    }

    @Configuration
    public static class ServiceBClientFeignConfiguration {

        @Bean
        public Decoder feignDecoder(@Qualifier("_halObjectMapper") ObjectMapper objectMapper) {
            ObjectMapper snakeObjectMapper = objectMapper.copy().setPropertyNamingStrategy(SNAKE_CASE);
            HttpMessageConverter jacksonConverter = new MappingJackson2HttpMessageConverter(snakeObjectMapper);
            ObjectFactory<HttpMessageConverters> objectFactory = () -> new HttpMessageConverters(jacksonConverter);
            return new ResponseEntityDecoder(new SpringDecoder(objectFactory));
        }
    }
}

Both of these services talk in a different JSON format. Service A is using KEBAB casing, service B is using SNAKE casing. By tweaking the object mapper, I was hoping to talk with the different services.
However, what I now see is that the FeignClient for service A is using the same converter as of service B, and so using the same object mapper of service B. It's unable to talk with a KEBAB casing service as the object mapper is expecting SNAKE casing.
I read this issue (#1211) which is kind of similar of what I'm facing, but I'm using different names for the FeignClients, so it should not be the root cause.
Is it possible my problem is actually the same as #1211? And the only solution is to create the feign clients manually?

Remove the @Configuration annotation from the configuration classes.
See the note in http://cloud.spring.io/spring-cloud-static/Finchley.RELEASE/single/spring-cloud.html#_logging_configuration

Hi @ryanjbaxter ,
Thanks for your fast feedback! Are you talking about the @Configuration on the ServiceAClientConfiguration class or on the ServiceAClientFeignConfiguration class.
I also see your posting a link to logging configuration. I was wondering what the link is between my problem and the logging configuration?
Thnx!
Jochen

Yes that is what I am talking about.
Sorry I posted the wrong link
http://cloud.spring.io/spring-cloud-static/Finchley.RELEASE/single/spring-cloud.html#spring-cloud-feign-overriding-defaults

Maybe also try removing the @Bean annotations?

Already tried that as well - the configurations still get loaded, but the converters are still being mixed up

Please provide a sample that reproduces the problem.

Yes, I understand that it's hard now to understand what exactly the problem is. I do appreciate your very fast feedback!
I was successful in isolating the problem by creating a small project which only initializes the feign clients and talks to existing services. But you would still not be able to run that application as you need my services. I guess that won't be enough for you? And you would like me to deliver 2 small REST services as well? 1 speaking KEBAB casing, 1 speaking SNAKE casing?

Ok, I'll see what I can do. I'll probably come back to you after the weekend. You can, for now, mark this issue as 'Waiting for feedback'

Hi @ryanjbaxter,
I was able to create a small 'test' project which you could easily use to reproduce the problem. However, by creating those 'dummy' services, it seems like that I can't reproduce the problem anymore.
This actually proved to me that the feign client library works like it should work, and there's a big chance there's something wrong in my project which breaks the stability of the feign clients.
This is no longer an issue for spring-cloud-netflix, so I'm closing this issue.
I do want to thank you for your feedback! The tip on the removal of the @Configuration was very valuable to me!
Jochen

Remove the @Configuration saved my day!

Not just configuration... any Spring annotation.

Remove the @configuration also saved my day!


[Sluggable] Relation targeting a slugged identifier does not work

Hi,
I end up having __id__ as Comment.post_slug values using this mapping.
Any hint ? (test available here)
/**
 * @ORM\Entity
 */
class Post
{
    /**
     * @ORM\Column(name="title", unique=true, length=64)
     */
    private $title;

    /**
     * @ORM\Id
     * @Gedmo\Slug(unique=true, fields={"title"})
     * @ORM\Column(length=64, nullable=false)
     */
    private $slug;
}

/**
 * @ORM\Entity
 */
class Comment
{

    /**
     * @ORM\Id
     * @ORM\GeneratedValue
     * @ORM\Column(type="integer")
     */
    private $id;

    /**
     * @ORM\ManyToOne(targetEntity="Post", inversedBy="comments")
     * @ORM\JoinColumn(name="post_slug", referencedColumnName="slug", nullable=false)
     */
    private $post;
}

well, yes, slug cannot be generated as identifier because orm requires id on persist, if we handle slug on persist, there are numerous other bugs. the situation now allow less wtf factors.. for instance you may persist the entity before setting title, the event will be fired only once, the time it was first persisted. you may change the title after persisting or slug may change during flush based on unique index. if you want something working the way you want, create it for your use case, for example generate the slug manually using the transliterator library and uniqueness check.. extensions are for very basic use cases usually ending up in custom solutions

@l3pp4rd actually the identifier generation works well and I end up having the right slug for Post.
Nevertheless, if I persist/flush a Post then a Comment the slug generated for Post is alright but it seems that the one used for the relation with Comment and found in the joinColumn is not the right one.

ah, haven't looked at the mapping close enough. it is an unusual use case. orm probably tries to set the joincolumn before the slug is generated, would need to update the join column after the slug is available. It will be quite complicated since Post will need to track comments inserted. I currently do not use extensions and I doubt if I would find time for this. So if you need such an use case, either update the source code yourself or generate slug manually

Ok, haven't find a way to force UnitOfWork to update its list of identifiers per object hash from within the SluggableListener.
We will stick with the persist then clear approach to ensure that identifiers associated to object in UOW are the right ones.


Implement more functionality for globals

First commit fixes the warnings about the new object safety rules. I hope I fixed it correctly. If not, you (or I) can delete that commit.
Second commit implements more functionality for globals.

There are three types of global:

Functions
Aliases
Variables/Constants

All of these dereference into a new type, GlobalValue, which in turn, dereferences into a Value.
Module.add_global_constant() has been removed in favour of Module.add_global_variable(), which can optionally be set to a constant by calling GlobalVariable.set_constant(true). The old behaviour didn't set it to constant anyway, so this breaking change has the benefit of alerting people as to whether their globals should be constant or not.
Global variables/constants can also have their initialiser changed through GlobalVariable.set_initializer() (or you can obtain the value through GlobalVariable.get_initializer())
All global values can have their linkage type changed through the GlobalValue.set_linkage() function using the new Linkage enum.
Also added Module.add_global_in_address_space(), which takes an argument of the new AddressSpace enum.
Some tests are probably needed but I'm too busy over the next few days. As far as I've used the new functionality, it works correctly.

Travis seems to be having problems with llvm-config.

Good idea with how you handled the values and sorry for the late pull.


rm list of contributors

The list was severely outdated and could potentially create the impression that there is a closed set of contributors to the the open source software client.

See discussion in  #470

@jnewbery I am not objected to a replacement of the team page that makes more sense. However, I think first removing the current team page is orthogonal to that and an improvement on its own.
(Also amended the section to what you suggested in the comment you just linked to)

orthogonal

I don't think this word means what you think it means :)

utACK c8618b1359005d78b584c95b73d3856a84c52736

This seems to only get rid of some of the team, and not others, giving an erroneous impression that merge permissions is more important than it really is. IMO either the page should be removed entirely, or otherwise updated to a current list. NACK removing some active people and leaving others...

Done

Okay, concept ACK then I guess. (Not really setup to render/test it myself.)

giving an erroneous impression that merge permissions is more important than it really is

Not really - the difference is that a maintainer has a well-defined role in the github organization. They have permissions to merge code. I don't think identifying them infers that they're any more or less 'important'.
Concept ACK removing all, or just leaving maintainers.

concept ACK remove all

Concept ACK for remove all, but I suggest we leave a redirect to another page on the site like the contribute page so the URL isn't broken.  For instructions on creating the redirect, see https://github.com/bitcoin-core/bitcoincore.org/pull/518#issuecomment-369680701

Concept ACK

I kind of like the idea of giving frequent contributors a more visible place then at the bottom of release notes, if they want. But I also agree that if it doesn't get updated it's better to remove it.
Also we already have the team pages on the bitcoin / bitcoin-core organizations, and keeping these things updated in parallel is a pain.

@harding Can you elaborate a bit on that. I think I only removed files in the _data and _include directories and only reformulated the actual _post. Not sure which page needs a redirect...

I think he means that the URL should lead to a redirect in case external sites might be pointing as that's clearer than showing a not-found page.

What does "the URL" refer to?
On Mar 3, 2018 13:46, "Wladimir J. van der Laan"<EMAIL_ADDRESS>wrote:
I think he means that the URL should lead to a redirect in case external
sites might be pointing as that's clearer than showing a not-found page.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bitcoin-core/bitcoincore.org/pull/519#issuecomment-370170400,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGGmv7g4Z8TBFG2tZbrCSaLOB5hg1IvUks5tauUQgaJpZM4SWwaU
.

@MarcoFalke sorry, I thought this PR removed the team page but I just confirmed that it only removes the list of contributors from that page.
Tested ACK 41bd570ae68fb8831a584eb816df371d2236e99f
Preview of the updated page:


fix broken candidate sdp

Description
I added candidates to the sdp without thinking that candidates are defined without the a= in the ice candidate event...
I think i need some edge-specific tests for all the SDP behaviour :-(

LGMT


warning on non existing organization url

Hi all
I run bundle exec jekyll serve --verbose and i get in the trace:
GitHub Metadata: Initializing...
GitHub Metadata: Generating for david-gang/david-gang.github.io
GitHub Metadata: Calling @client.pages("david-gang/david-gang.github.io", {})
GitHub Metadata: Generating for david-gang/david-gang.github.io
GitHub Metadata: Calling @client.pages("david-gang/david-gang.github.io", {})
GitHub Metadata: Calling @client.contributors("david-gang/david-gang.github.io")
GitHub Metadata: Calling @client.contributors("david-gang/david-gang.github.io")
GitHub Metadata: Calling @client.repository("david-gang/david-gang.github.io")
GitHub Metadata: Calling @client.repository("david-gang/david-gang.github.io")
GitHub Metadata: Calling @client.organization("david-gang")
GitHub Metadata: GET https://api.github.com/orgs/david-gang: 404 - Not Found // See: https://developer.github.com/v3
GitHub Metadata: Calling @client.organization("david-gang")
GitHub Metadata: GET https://api.github.com/orgs/david-gang: 404 - Not Found // See: https://developer.github.com/v3
GitHub Metadata: Calling @client.list_repos("david-gang", {"type"=>"public"})
GitHub Metadata: Calling @client.list_repos("david-gang", {"type"=>"public"})
GitHub Metadata: Calling @client.releases("david-gang/david-gang.github.io")
GitHub Metadata: Calling @client.releases("david-gang/david-gang.github.io")
I don't understand why it tries to acess:
https://api.github.com/orgs/david-gang
It should be
https://api.github.com/users/david-gang
If this is ok that the organization page does not exist it should not write an error message.
Is this a misconfiguration on my side or a defect
I asked this question in jekyll talk but no one answered me
https://talk.jekyllrb.com/t/github-metadata-not-found-it-think-that-i-am-an-organization/3417
so i assume it is a defect
Thanks,
David

I too have experienced this exact issue for several weeks now, really hoping jekyll-github-metadata will be updated to use the /users/ directory instead of the /orgs/ URL to clear this error / warning message

Aghh, this! I couldn't work out why I was getting this error all the time. I'm using Jekyll and GitHub Pages, and get this error on my open source repo every time I try and build. Tried so many different authentication methods and none of them work.

Same issue here. This is not an authentication issue, as described in GitHub API errors #374. The wrong URL is used for accounts not having type: "Organization". The URL https://api.github.com/orgs/david-gang should read https://api.github.com/userss/david-gang

Fixed by #86, I believe.

I don't get it, as it is the API issue not the #86 which is just log problem,

@ebagdasa We ask GitHub if the user account the repository belongs to is a User or Organization. We do that by calling client.organization("username") and seeing if it returns something. If it does, then it's an Organization. If it doesn't then it's a User. The reason it's a log issue is because getting a 404 is expected when the username is a User. We were logging it which looked scary, but it wasn't necessary to log it.

This is still broken for users who are associated with an organization. I think client.organization("tbarron") will return something because I'm associated with an organization for work, which means that my personal pages will be treated as orgs when they should be users.


Print CreateNewBlock() when BENCH debug is set

ACK; will be merged into 4.1.

Merging now, if any objections feel free to open a new issue.


Default params to http client

Is there a way to set up default params for all requests? I didn't find it.
Right now I need to set {secure: true} to each request manually, which is can be improved with default params.

Hello @Nihisil !
Which kind of http client are you using ?

axios

@Nihisil thanks for your bug reports!
This bug should be fixed in 6.2.1 release.
Please reopen issue if you still have the same problem.

Thank you for the quick fix!


Crawling prints formatted content, how to avoid it ?

The crawled content is printed in key:value pair as shown below, how can I avoid it ? I want only the text part "Voter turnout in Sunday\'s poll soared..etc"  as shown below.
{
"index": 7,
"tags": [],
"content": "  * Voter turnout in Sunday\'s poll soared - the highest in a parliamentary election since 1997"
},
My script as below
from crawl4ai import WebCrawler
from crawl4ai.chunking_strategy import *
from crawl4ai.extraction_strategy import *
from crawl4ai.crawler_strategy import *
def create_crawler():
crawler = WebCrawler(verbose=True)
crawler.warmup()
return crawler
crawler = create_crawler()
result = crawler.run(    url="https://www.bbc.com/news/live/cn087x77g1dt", css_selector="#summaryPoints", verbose = False , only_text=True , word_count_threshold = 30 ,  screenshot = True )
print("Extracted as follows:", result.extracted_content)

@merihakca Consider using result.markdown for the complete markdown text. Utilize extracted_content in 2 instances:

When employing CosineExtraction or LLMExtraction strategy
When integrating text processing before combining them into a task-appropriate full text.


FFT Choice in dirty_image_generate

Is there a physical reason to use forward FFT (normalizer=1/N, negative exponent) in dirty_image_generate?
If you visibility is generated from other programing languages that is not IDL, the normalization and sign convention in the FFT can be incompatible. For example, FFTW3 (C/C++) has the same sign convention as in IDL FFT but does not apply 1/N normalization to both the forward and the backward transform, and Python (Numpy and Scipy) FFT also use the same sign convention but apply the 1/N normalization on the backward transform (opposite to IDL).

Ian can correct me if I'm wrong, but I'm pretty sure the FFTs in FHD should now have normalizations based on units (for example, Jy/str in the sky maps to Jy visibilities). So even though IDL includes the 1/N for the FFT, other factors should be included to make the units work and thus the internal convention is irrelevant.

@adampbeardsley Are you saying that the transform should be correct as long as the unit of the visibility is Jy?

Ah, now I see what you're worried about. I think this has to do with the offline conversation we were having. I think that the output fits images are normalized post-FFT such that a point source of 1 Jy will be seen with a peak 1 Jy/beam. This is done on line 70 (IF keyword_set(normalization)...).
But now I think I'm getting beyond my actual understanding of FHD's normalization. @isullivan ?

Well, first at line 67
IF Keyword_Set(degpix) THEN di_uv_use/=(degpix*!DtoR)^2. ;FFT normalization

If I understand correctly the uv is divided by (degpix*!DtoR)^2 to convert the FFT normalization factor 1/N^2 from the unit of 1/pixel^2 to 1/rad^2. This is necessary to make the flux unit be Jy/sr.
If you are right about line 70, then the flux unit is converted from Jy/sr to Jy/beam there.

The reason for the choice of FFT convention in FHD is that the forward transform is slightly more efficient in IDL when transforming from the u-v plane to real-valued image space. The normalization has been worked out so that a 1 Jy source at the image center is modeled by an array of all 1s in the u-v plane and has visibilities of all 1s after degridding. The gridded visibilities (in the u-v plane) are in units of variance-weighted Janskys, which is not compatible with other software that grids visibilities and is not meant to be. The output from the FFT wraper function dirty_image_generate.pro is an image of the sky with units of Jy/pixel (the factor of [degpix*!DtoR]^2 accounts for the units of the Fourier transform), and the function get_image_renormalization.pro calculates the conversion factor between Jy/pixel and Jy/beam.


[BEAM-13221] Don't drop data when is_last is true.

The element with IsLast = true may contain data, which must be sent out, or it will be lost.
This PR stops dropping the data, and adds unit tests for both the is_last w/data, is_last without data cases.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @lukecwik
cc: @youngoli @riteshghorse @jrmccluskey

Ping

For some reason I would have moved the if elm.GetIsLast() to beyond the existing select case but can see that we still want to delete from the cache and that doesn't play nicely with the existing code layout.

I can't see any reason it shouldn't work, but I don't want to re-reason through the cache behavior at the moment so I'm hesitant to move it. I feel the clarity of distinct "this is the last element" handling supersedes deduplicating.


getEquallySpace method

We have to change those methods to a single general methods that uses interpolating/extrapolating and approximation polynomials to get the values in the array. A parameter should be the degree of the polynomial we want to use.

@andcastillo I think that splines can work better for the interpolation in this case, but it could be an option as well


Create Pod steps should probably be last

The content of these pages is great, however I was having an issue when getting to the last step of having to modify the pod to use the persistent volume claim.  Trying to update the pod results in an error of Forbidden as you can apparently only change the spec.containers.image, spec.activeDeadlineSeconds or spec.tolerations.
Recommend replacing the pod update step with the pod creation steps.  The creation step can then be changed to use the PVC instead of the file share directly.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d634c63a-6194-86a6-b522-3310812c81e8
Version Independent ID: fa86da1e-9c86-88fe-170c-5e6aa9230b5f
Content: Manually create Azure Files share - Azure Kubernetes Service
Content Source: articles/aks/azure-files-volume.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@eelliottms
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@mlearned @zr-msft
Can you please check and add your comments on this doc update request as applicable.


Problem about download Resources

Hi, there is 2 problem about resources and links.
first is that you can download only 1x resource link links-to-visit from every chapter. I mean if there is 5x chapter, and every chapter has 8 lecture I can see only the last lecture link. so I cant download lecture 1 - 7 links or resources. and it is possible that every lecture has more than 2-3x resource link
second problem is about Quizzes. this part is not work too
also it is good to add them in another folder. I find an working example here. both problems that I explain above are working here.
https://github.com/madmax2/udemy-dl-windows
but my knowledge is low in python. I will try to add it in future but it is hard for me :)

@selanium i will look into these problems thanks for the report+suggestions. currently i 'm closing this issue.

I find another bug too, it is same with first issue but a little more detail.
sometimes I see duplicate links in text file. forexample 2x from the same link

@selanium this is not the bug it gets all the external links and adds it to the file to visit no matter it the same external link is present with each video it will append that in a file.


Forwards logs to the server if server supports it

Adds a new class LogQueue which stores up to a fixed number of log messages in a circular buffer. It stores up to 30 pending log messages of max 255B each which takes up 7.4K of statically allocated memory. There is no dynamic allocation.
Whenever Logger is called, the log message is pushed into the LogQueue.
Whenever the Connection loop is run, it will try to send one pending message to the server.

Note that sending logs is best-effort since it's over UDP.
Related PRs:
https://github.com/SlimeVR/SolarXR-Protocol/pull/153
https://github.com/SlimeVR/SlimeVR-Server/pull/1234

I reduced the max messages from 100 to 30 because I was seeing some OOM panics. Have not seen any more OOM since then, but I'm curious how the memory budget is allocated.


SQS with https redirect (Rails/Puma)

Running RoR 5.1 with the following config:
https://github.com/awsdocs/elastic-beanstalk-samples/blob/master/configuration-files/aws-provided/security-configuration/https-redirect/ruby-puma/https-redirect-ruby-puma.config
I was unable to get the worker tier to consume jobs from SQS.  (Error logs show a 301 redirect).
Per worker environments documentation, SQS sends a POST request to http://localhost/
Because of this I believe the current config is redirecting the SQS post.
To fix the issue, modified the config as follows:
location / {
             set $redirect 0;
             if ($http_x_forwarded_proto != "https") {
               set $redirect 1;
             }
             if ($http_user_agent ~* "ELB-HealthChecker") {
               set $redirect 0;
             }
             if ($http_user_agent ~* "aws-sqsd") {
               set $redirect 0;
             }
             if ($redirect = 1) {
               return 301 https://$host$request_uri;
}

I was able to solve my issue by checking for the SQS user agent.  Wonder if this should be included  in the sample config files by default?

Hi @exige81 ,
You are right - the SQS daemon on a worker environment sends a POST request to http://localhost/ on port 80.
This config example, as stated in its comment, is for environments that are configured to support HTTPS. I am curious why you wanted to configure a worker environment to support HTTPS.

Hi @dankhen,
I don't really want to configure my worker environment to support HTTPS, however I deploy both my web and worker environments from the same source.
Ideally, it would be nice if .ebextensions config files could be namespaced to a specific environment so that I could ignore the HTTPS config for my worker environment, but there doesn't seem to be a way to set environment specifc configs at this time.
If you're aware of a better way to handle this, I'm open to suggestions.

I'll discuss with our service team and follow up. Thanks!

@exige81 ,
After much deliberation on the service team, we'd like to communicate our thoughts about your solution, modifying the example, and configuration file environment-scoping.
For your needs, you did the right thing. From the narrow standpoint of using the same .ebextensions for both web and worker environments, your change indeed takes care of doing the HTTPS redirection only on the web server, and dropping it on the worker tier.
However, the broader notion of using the same code base (the same source bundle) for deploying multiple environments, especially for multiple tiers, isn't a supported Elastic Beanstalk scenario. Since we don't support and test it, it may or may not work, and we can't recommend it. Therefore, we wouldn't want to publish an example that would imply it's a supported or recommended use case. We have to decline to change the example.
For the same reason, while your idea of environment-scoping for configuration files would be good if sharing configuration files was supported, we're not likely to pursue it for the current supported scenarios.
Thanks for posting these ideas!

@exige81 did you ever find a solution to this.

@CaseJnr the workaround is to modify the https-redirect-ruby-puma.config example as shown in the first post of this issue.   This prevents the redirect if the user agent is from aws-sqsd the which is the SQS daemon