New Features Added: Individual Cell Sizing, Merged Cells & Vertical Alignment

Hi Kit,
I have added the following features to your code:

The ability to individually size cells (I added this to the CellProp DU)
The ability to created merged cells vertically, horizontally and both vertically & horizontally
Vertical alignment of text in a cell and in a merged cell

One thing I did notice when creating the Vertical Alignment feature was that I could not use the following type names in the DU as follows:
type VerticalAlignment =
| Bottom
| Center
| Top
due to the compiler confusing the names in the pattern matches on lines 457-472 in FsExcel.fs. For example, when wanting to use 'Center' in the DU for the VerticalAlignment, I kept getting the following error:
This expression was expected to have type
'VerticalAlignment'
but here has type
'HorizontalAlignment'
To resolve this, I would have needed to write in the code in lines 457-472:
match v with
| VerticalAlignment.Bottom -> ....
| VerticalAlignment.Center -> ...
| VerticalAlignment.Top -> ...
(and the same for the HorizontalAlignment DU)
and when writing a program to use this feature I would need to write (for both  Horizontal & Vertical Alignment):
HorizontalAlignment HorizontalAlignment.Center
VerticalAlignment Center
HorizontalAlignment Right
VerticalAlignment VerticalAlignment.Bottom
which is cumbersome and not consistent.
Hence, I chose the names:
type VerticalAlignment =
| Base
| Centre
| TopMost
Please note the British English spelling of 'Centre'.
I completed your course "F Sharp from the Ground Up" in summer 2022 and hence I am still fairly new to F#, so I am not sure if this is an error on my part or an error with the F# compiler. I am happy to discuss this issue with you further should you wish.
Kind regards,
Emilia

@emigajda This is amazing work. I cannot thank you enough.  I'll take me a few days to go through it but at first glance it looks perfect.  I can't wait get this merged and try it out.
To find that you came did this after taking the course - well, wow.
Thanks again, I'll be back in touch soon.

Hi Kit,
I have realised that my Merge feature is quite limited as stands and so I will be extending its functionality to allow for merging between named cells and merging cells given a depth/span from a particular starting cell (and vice versa). Hopefully I should have this ready within the next few days!
Kind regards,
Emilia

Great! I have a few things to tidy up which I can do separately over a
similar timescale.
Once we have your stuff fully in - and given that (to be confirmed)
ClosedXml no longer depends on System.Drawing.Common - I am thinking of
calling this Release 1.0.0.
What do you think?  No pressure on you re timescale.
Thanks!
On Fri, 24 Feb 2023 at 08:11, emigajda @.***> wrote:

Hi Kit,
I have realised that my Merge feature is quite limited as stands and so I
will be extending its functionality to allow for merging between named
cells and merging cells given a depth/span from a particular starting cell
(and vice versa). Hopefully I should have this ready within the next few
days!
Kind regards,
Emilia
—
Reply to this email directly, view it on GitHub
https://github.com/misterspeedy/FsExcel/pull/38#issuecomment-1443066203,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGDPLWKVQGKFHFMKOC5G2DWZBULFANCNFSM6AAAAAAVDKW6CA
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

Oh yes, and I'll have a think about the naming issue too.
On Fri, 24 Feb 2023 at 08:42, Kit Eason @.***> wrote:

Great! I have a few things to tidy up which I can do separately over a
similar timescale.
Once we have your stuff fully in - and given that (to be confirmed)
ClosedXml no longer depends on System.Drawing.Common - I am thinking of
calling this Release 1.0.0.
What do you think?  No pressure on you re timescale.
Thanks!
On Fri, 24 Feb 2023 at 08:11, emigajda @.***> wrote:

Hi Kit,
I have realised that my Merge feature is quite limited as stands and so I
will be extending its functionality to allow for merging between named
cells and merging cells given a depth/span from a particular starting cell
(and vice versa). Hopefully I should have this ready within the next few
days!
Kind regards,
Emilia
—
Reply to this email directly, view it on GitHub
https://github.com/misterspeedy/FsExcel/pull/38#issuecomment-1443066203,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGDPLWKVQGKFHFMKOC5G2DWZBULFANCNFSM6AAAAAAVDKW6CA
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

@emigajda I've fixed some failing tests, in case that is helpful.


test: remove tests covered by hoodie-store

Hey :),
I added all tests that were solely dependant on hoodie.store to  the new hoodie-store repository.
I think they are not needed here then anymore in the future.
Best,
Finn

LGTM :+1: :sunglasses:

perfect :+1: LGTM


Path needs to be absolute in Marathon 0.16.0-RC1

Suddenly paths has to be absolute inside of groups.
$ curl -s -X PUT https://marathon/v2/groups -d '{"id":"/why","apps":[{"id":"seriosly"}]}' | jq .

{
  "message": "Object is not valid",
  "details": [
    {
      "path": "/apps(0)/id",
      "errors": [
        "Path needs to be absolute"
      ]
    },
    {
      "path": "/apps(0)",
      "errors": [
        "AppDefinition must either contain one of 'cmd' or 'args', and/or a 'container'."
      ]
    }
  ]
}

Fixed by #3547


Assert key is not in Dynamic Attributes

A changing key attribute (but not passed as the key parameter) could cause havoc. Force key to always be static.
This is of particular interest to compile to iDOM build steps, since a runtime attr(name, value) would be impossible to catch:
var attrs = { key: 'key' };

elementOpenStart('div');
for (var name in attrs) {
    attr(name, attrs[name]);
}
elementOpenEnd('div');
elementClose('div');

It doesn't seem like we should even allow a static attribute named 'key' or (better) for a pre-rendering flow use some attribute other than 'key'.

It doesn't seem like we should even allow a static attribute named 'key'

I was planning on using $('[key="keyname"]') to hook into my own code, though I'm exploring other ideas.

(better) for a pre-rendering flow use some attribute other than 'key'

That might tie in nicely with https://github.com/google/incremental-dom/issues/50?

Also worth noting, if the statics and key are properly done, the attribute and the NodeData#key will always be in sync:
var key = 'key';
var statics = ['id', 'id', 'key', key];

function render() {
  statics[3] = key;
  elementVoid('div', key, statics);
}

patch(container, render);
key = 'other';
patch(container, render);

That's because the new key param will force a new div to be created, and it'll have the proper key attribute.

Closing due to certain situations where a key cannot be in the statics array:
function render(items) {
  items = items.map((el, i) => {
    return
;
  });
  return
{items}
;
}

// - - -

var _statics13 = ["id", "id"];

function render(items) {
  items = items.map(function (el, i) {
    return _jsxWrapper(function () {
      return elementVoid("div", i, _statics13, "key", i);
    });
  });
  elementOpen("div");
    items.forEach((item) => item());
  return elementClose("div");
}

In this case, to properly hoist the statics, I cannot include key.


feat: Copy text with mouse selection

Simple mouse text selection capability. Future work will include highlighting the background of selected text.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

1 of 51 (1.96%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.9%) to 60.063%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/domain/services/events.rs
0
9
0.0%

src/domain/services/bubble_list.rs
1
12
8.33%

src/application/ui.rs
0
30
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/domain/services/events.rs
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>2:
-0.9%

Covered Lines:
1901

Relevant Lines:
3165

💛  - Coveralls


(fix) use new plugin syntax

There were the following issues with your Pull Request

Commit: 9c63bd687f2c54e1b76db79df8b965aab726a97d
Commits must be in the following format: %{type}(%{scope}): %{description}
Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert

Guidelines are available at https://github.com/rustless/rustless

This message was auto-generated by https://gitcop.com


xSQLServerSetup: ASServerMode Parameter

[Replace this with a description of your pull request]
This Pull Request (PR) fixes the following issues:
Fixes #388 (Can only install Analysis Services in the default (Multi-Dimensional Server Mode))

[X] Change details added to Unreleased section of CHANGELOG.md?
[X] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[ ] Examples appropriately updated?
[X] New/changed code adheres to Style Guidelines?
[ ] Unit and (optional) Integration tests created/updated where possible?

This change is

Hi @craigofnz, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, MSBOT;

Codecov Report

Merging #391 into dev will decrease coverage by -1%.
The diff coverage is 50%.

@@         Coverage Diff         @@
##            dev   #391   +/-   ##
===================================
- Coverage    63%    63%   -1%
===================================
  Files        31     31
  Lines      3092   3094    +2
===================================
+ Hits       1978   1979    +1
- Misses     1114   1115    +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4304e00...f45221d. Read the comment docs.

@craigofnz Thanks for your contribution!
Tests are failing. You have tab's in the file, can you replace them with 4 whitespaces?
https://ci.appveyor.com/project/PowerShell/xsqlserver/build/5.0.867.0#L45
Would you be up for writing Pester test for this functionality?

Beside these small fixes I commented on, I would need tests for this change. Would you be up to the task to create those tests? If you are new to pester, or if you want help to create the tests in their entirely, I can help you.

Reviewed 2 of 4 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

DSCResources/MSFT_xSQLServerSetup/MSFT_xSQLServerSetup.psm1, line 624 at r2 (raw file):

        [ValidateSet('MULTIDIMENSIONAL','TABULAR','POWERPIVOT', IgnoreCase = $false)]
        [System.String]
        $ASServerMode,

Please add this parameter to the comment-based help above. You can use the same parameter description as in the README.md

DSCResources/MSFT_xSQLServerSetup/MSFT_xSQLServerSetup.psm1, line 975 at r2 (raw file):

$setupArguments['ASServerMode'] = "$ASServerMode"

Should work without the double quotes?
$setupArguments['ASServerMode'] = $ASServerMode

DSCResources/MSFT_xSQLServerSetup/MSFT_xSQLServerSetup.psm1, line 1365 at r2 (raw file):

        [ValidateSet('MULTIDIMENSIONAL','TABULAR','POWERPIVOT', IgnoreCase = $false)]
        [System.String]
        $ASServerMode,

Please add this parameter to the comment-based help above. You can use the same parameter description as in the README.md

Comments from Reviewable

@craigofnz Do you have time to finish this one? If you feel that you don't have time, then please tick 'Allow edits from maintainers' to the right here, around Notifications. Then I can help you get this finished.

Since this has been idle for a while, I will label this one as abandoned.

Closing and reopening the PR to get the correct CLA status.

Closing this PR as this work is being continued in PR #964. Thanks to @craigofnz for the initial work on this!


Feature Request: Gamelib targets

Describe the feature request
Right now the cmake support contains a add_app function to define a game executable. These contain all the translation units used in the game, and it automatically links against the engine. This is fine, but prevents code re-use game-side.
Justification
If I wanted to create game-side unit-tests for code, I would want to create a static gamelib that the game and tests use. This is not feasible without the ability to specify the static gamelib.
Additional context
I want to test red nightmare

I believe this now exists thanks to HDK integration


Impossible to rotate due to error Invalid rotation, must be a multiple of 90 degrees

When pdf page is a result of scan, it may not be with rotation of 'multiple of 90 degrees'.
For now, it is impossible to use e.g. 94 angle.
Other libs e.g. pdfium allows to rotate to any angle.
Configuration:

Web browser and its version:
Operating system and its version:
PDF.js version: 2.7.570
Is a browser extension: no

Steps to reproduce the problem:

Pdf is created as a result of scan  (and text recognition is done where angle is detected)
Try to use getViewport({ rotation: 94});
=> Invalid rotation, must be a multiple of 90 degrees

What is the expected behavior? (add screenshot)
Expect that we can use angle e.g. 94 so that the page is rendered properly
What went wrong? (add screenshot)

Attach (recommended) or Link to PDF file here:

Please note that that part of the ISSUE_TEMPLATE is always required in order for any issue to be actionable.

PDF.js version: 2.7.570

That version is no longer supported, please find the latest releases at https://mozilla.github.io/pdf.js/getting_started/#download

Pdf is created as a result of scan (and text recognition is done where angle is detected)
[...]
Expect that we can use angle e.g. 94 so that the page is rendered properly

In that case this is actually a bug in the scanning and/or the PDF-creation software, rather than the PDF.js library.
In order to simplify the overall rotation handling in both the viewer and the API, please note that we purposely only support rotation in multiple of 90 degrees (and this issue does seem like an edge-case).
Closing as answered (or possibly even WONTFIX).

@Snuffleupagus is it possible to leave it as an enhancement or this is no change it will be fixed?


[BUG]When using remote proxy api ,all bots will stuck at initializing.

when all banned and reload the proxy  ,all bots will stuck at initializing.

You need to post more info (your settings) or a video of the problem happening. Please no illegal things or you will be banished from this repo.

This problem starts from 1.1.4#323 version . All defaut settings . I add only 2 api links https://api.proxyscrape.com/?request=getproxies&proxytype=socks4&timeout=10000&country=all
https://api.proxyscrape.com/?request=getproxies&proxytype=socks5&timeout=10000&country=all

I reverted it https://github.com/openbullet/openbullet/commit/253c9c7aa3b61281519ee09b8a0ba9dbb24fc6e0


COLLABORATE WITH LOGX PERP DEX

LogX is a perp that launched q3 mainnet 2023, they got so many things going for them since then plus a great community behind them. I know with the integration of Zksyn on that perp dex, it will boost Zksync TVL, and also get more buzz and excitement to Zksync just as gmx/arb. Also launch some integration quest on LogX alerting people about the integration too.

Nice project zkysnc needs to come in

I would love to trade future on zksync ✅

linea ağında kullanmıştım, zksyncta da iyi olabilir tabi


fix: account for extmarks/conceal for inline imgs

Fixes #155
I'd like to test this for a day or two before merging it. But the code should be done.

Awesome @benlubas !

@3rd  I think this is good to go. I have another PR in the works to fix a few more bugs that are related but not caused by this PR that I'll probably get up later today or tomorrow depending

Thank you so much @benlubas, and awesome work on https://github.com/nvim-neorg/neorg/pull/1397!


⚠ Bofrost.de has degraded performance

In 1a03098, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1832 ms

Resolved: Bofrost.de performance has improved in 03d9a7d.


#1251 fix function parameter diff bug

Description
Fixes #1251
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[x] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[x] No style issues: $ flake8
[x] All tests pass: $ python run-tests.py --unit
[x] The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.
Further checks:

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works

Coverage error is something that was already failing before ...


Include release-* branches when pushing tags

tags are pushed to release branches - this change should make sure github publishes official version containers on it.

@n1r1 @slintes I guess the only way to test it is to merge and then push a dummy tag to see if we are happy with the result

the only way to test it is to merge...

and to backport to a release branch 😉

and then push a dummy tag

/lgtm

/approve


Don't have an insert key on mac

Mac's don't have an insert key and fn+enter does not open the gui

I have been using LYSEP Corp's "ButOSX" and just learned about "CuralOSX" but it seems that they have different gui keys.But the mac does not have an insert key


Add avatar and issue labels to template repositories

This PR adds template units for avatar and issue labels that allow a user to generate a repository from a template and include the template's avatar and issue labels.

lint error

lint error

Fixed. I guess I don't get a codecov comment this time after CI succeeds.


Provide umd target building pipeline

Related with #3.

Coverage remained the same at 100.0% when pulling ecd567889e9808ee8af647764f929bceb6c1d958 on feature/umd into 1a5422576d35f325069d103988862b2eadfd707d on master.

Coverage remained the same at 100.0% when pulling 896a9c6c4ece73e9b55209a65e503842c2783389 on feature/umd into 1a5422576d35f325069d103988862b2eadfd707d on master.


Change disconnect msg protocol to more appropriate

NOTICE is more appropriate than PRIVMSG: the user shouldn't respond to this (see IRC RFC) and on an actual client PRIVMSG opens a new window etc.
Change the sender from "gitter" (ostensible a client/service) to this.host (= the server itself)

@Gargaj what's the best way to test this?

Easiest is probably shutting down the server while your client is connected.

So #65 uses an ERROR message rather than NOTICE. Which would be the most appropriate in this situation?

@Gargaj thanks. can you clean up conflicts and i'll look to merge.

I don't think that's necessary if the other one was merged; ERROR works fine for me too.


Document how to adjust the font

I was trying to adjust the font, which you can, for #raw, do by using #show raw: it => ..., but here you'll need to use raw.line.
To save the next person some work, I've added an example to the manual.

Btw, I noticed that typst-mantys doesn't work with the main/nightly version of typst right now, I had to change the following:
diff --git a/api.typ b/api.typ
index 4684b32..b214854 100644
--- a/api.typ
+++ b/api.typ
@@ -17,8 +17,8 @@

 #let dtype( t, fnote:false, parse-type:false ) = {
   if mty.not-is-func(t) and mty.not-is-lambda(t) {
-    if parse-type or type(t) != "string" {
-      t = type(t)
+    if parse-type or type(t) != str {
+      t = str(type(t))
     }
   }

Furthermore, as you can see on the rendered example, it might be nice to have some kind of line-height/line-gutter option to adjust spacing of the lines (I'm pretty sure passing the value to row-gutter in the table should be enough [for now?]).

Thanks for your input. Somehow I completely missed your contribution.
Since the code changed since November I will close this request, but add your contribution to the manual.
Mantys should work with the current version of Typst and hopefully will be available in the package repository in the next few days.
I'm working on the line height adjustments, but simply using row-gutter adds ugly gaps when combined with line highlights. Maybe there is a better solution.


Can't build project

Hi, I'm trying to run you project(npm run dev) and receive an error:
Fatal error in ../deps/v8/src/api.cc, line 1051
Check failed: !value_obj->IsJSReceiver() || value_obj->IsTemplateInfo().

==== C stack trace ===============================
node(v8::base::debug::StackTrace::StackTrace()+0x16) [0x15c5c06]
node(V8_Fatal+0xe8) [0x15c2d48]
node(v8::Template::Set(v8::Local<v8::Name>, v8::Local<v8::Data>, v8::PropertyAttribute)+0x107) [0x9f2817]

Can you help me please?

What version of Node are you using? The version supported is 4.x and you can use NVM to run multiple node versions on your host.


x42-plugins: 20211016 -> 20220107

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/x42-plugins/versions.
meta.description for x42-plugins is: "Collection of LV2 plugins by Robin Gareus"
meta.homepage for x42-plugins is: "https://github.com/x42/x42-plugins"
meta.changelog for x42-plugins is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
/nix/store/7yxkqzh5zi9qknfs9kfh4qjl01da7iss-x42-plugins-20220107/bin/x42-tuna passed the binary check.
/nix/store/7yxkqzh5zi9qknfs9kfh4qjl01da7iss-x42-plugins-20220107/bin/x42-matrixmixer8x8 passed the binary check.
/nix/store/7yxkqzh5zi9qknfs9kfh4qjl01da7iss-x42-plugins-20220107/bin/x42-dpl passed the binary check.
/nix/store/7yxkqzh5zi9qknfs9kfh4qjl01da7iss-x42-plugins-20220107/bin/x42-fil4 passed the binary check.
/nix/store/7yxkqzh5zi9qknfs9kfh4qjl01da7iss-x42-plugins-20220107/bin/x42-darc passed the binary check.
/nix/store/7yxkqzh5zi9qknfs9kfh4qjl01da7iss-x42-plugins-20220107/bin/x42-meter passed the binary check.
/nix/store/7yxkqzh5zi9qknfs9kfh4qjl01da7iss-x42-plugins-20220107/bin/x42-spectr passed the binary check.
/nix/store/7yxkqzh5zi9qknfs9kfh4qjl01da7iss-x42-plugins-20220107/bin/x42-mixtri passed the binary check.
/nix/store/7yxkqzh5zi9qknfs9kfh4qjl01da7iss-x42-plugins-20220107/bin/x42-scope passed the binary check.
/nix/store/7yxkqzh5zi9qknfs9kfh4qjl01da7iss-x42-plugins-20220107/bin/x42-stepseq passed the binary check.
/nix/store/7yxkqzh5zi9qknfs9kfh4qjl01da7iss-x42-plugins-20220107/bin/x42-fat1 passed the binary check.
11 of 11 passed binary check by having a zero exit code.
11 of 11 passed binary check by having the new version present in output.
found 20220107 in filename of file in /nix/store/7yxkqzh5zi9qknfs9kfh4qjl01da7iss-x42-plugins-20220107

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
x42-plugins

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/7yxkqzh5zi9qknfs9kfh4qjl01da7iss-x42-plugins-20220107 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A x42-plugins https://github.com/r-ryantm/nixpkgs/archive/2040c11beacb6aec51f9a5630f6c55e5a74de957.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/7yxkqzh5zi9qknfs9kfh4qjl01da7iss-x42-plugins-20220107
ls -la /nix/store/7yxkqzh5zi9qknfs9kfh4qjl01da7iss-x42-plugins-20220107/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

x42-plugins

Maintainer pings
cc @magnetophon for testing.

@magnetophon Feel free to do a follow-up PR with that!


ads: unify ads protocol handling across type urls

This PR unifies the ads protocol handling logic across type urls using WatchedResources and also removes inconsistencies.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
9516aac53c22441c533a3afd67aac54e5e05fd1b
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
9516aac53c22441c533a3afd67aac54e5e05fd1b
link
/test lint_istio

gencheck_istio
9516aac53c22441c533a3afd67aac54e5e05fd1b
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
9516aac53c22441c533a3afd67aac54e5e05fd1b
link
/test lint_istio

gencheck_istio
9516aac53c22441c533a3afd67aac54e5e05fd1b
link
/test gencheck_istio

unit-tests_istio
9516aac53c22441c533a3afd67aac54e5e05fd1b
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
9516aac53c22441c533a3afd67aac54e5e05fd1b
link
/test lint_istio

gencheck_istio
9516aac53c22441c533a3afd67aac54e5e05fd1b
link
/test gencheck_istio

unit-tests_istio
9516aac53c22441c533a3afd67aac54e5e05fd1b
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
9516aac53c22441c533a3afd67aac54e5e05fd1b
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
9516aac53c22441c533a3afd67aac54e5e05fd1b
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
6d6a509de94063268ccc918ad27095ae9ba07720
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

But I am happy to see this!

Sure. No problem

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
6d6a509de94063268ccc918ad27095ae9ba07720
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
6d6a509de94063268ccc918ad27095ae9ba07720
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

By the way in my I tried to refactor and modify the logic - I think this is
just refactorings (?)
On Fri, Jul 3, 2020, 7:15 AM Istio Automation<EMAIL_ADDRESS>wrote:

@ramaraochavali https://github.com/ramaraochavali: The following tests
failed, say /retest to rerun all failed tests:
Test name Commit Details Rerun command
unit-tests_istio 6d6a509
https://github.com/istio/istio/commit/6d6a509de94063268ccc918ad27095ae9ba07720
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/25192/unit-tests_istio/15794 /test
unit-tests_istio
integ-pilot-k8s-tests_istio 6d6a509
https://github.com/istio/istio/commit/6d6a509de94063268ccc918ad27095ae9ba07720
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/25192/integ-pilot-k8s-tests_istio/15350 /test
integ-pilot-k8s-tests_istio
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/25192#issuecomment-653568535, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXKIBRZBKYDZGAKZLKTRZXRX5ANCNFSM4OPWLXIQ
.

It also fixes inconsistencies of stale nonce handling across resource types. Rds handles it  and Eds does not handle stale nonce at all. I am and trying to fix the inconsistency and handle the protocol uniformly across all type urls.

PTAL when you get chance- if there is an overlap with the other PR, we can wait till that is merged and see if this is needed or we can decide what is the best way to move forward based on what you think. My main intention was to refactor the protocol handling to a separate function so that the inconsistencies can be avoided

No let's merge this one first if it works - mine doesn't work. But i think
this may move us to consistently wrong... Our entire xds handling doesn't
really match the expectation of envoy. But we should probably be consistent
then fix things up
On Fri, Jul 3, 2020, 8:03 AM Rama Chavali<EMAIL_ADDRESS>wrote:

PTAL when you get chance- if there is an overlap with the other PR, we can
wait till that is merged and see if this is needed or we can decide what is
the best way to move forward based on what you think. My main intention was
to refactor the protocol handling to a separate function so that the
inconsistencies can be avoided
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/25192#issuecomment-653587287, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXPTOSAABNIOZJYEGBDRZXXLLANCNFSM4OPWLXIQ
.

Also yes the test client (adsc) is different than envoy behavior, at the
very least it doesn't include resource names in ack
On Fri, Jul 3, 2020, 8:05 AM John Howard<EMAIL_ADDRESS>wrote:

No let's merge this one first if it works - mine doesn't work. But i think
this may move us to consistently wrong... Our entire xds handling doesn't
really match the expectation of envoy. But we should probably be consistent
then fix things up
On Fri, Jul 3, 2020, 8:03 AM Rama Chavali<EMAIL_ADDRESS>wrote:

PTAL when you get chance- if there is an overlap with the other PR, we
can wait till that is merged and see if this is needed or we can decide
what is the best way to move forward based on what you think. My main
intention was to refactor the protocol handling to a separate function so
that the inconsistencies can be avoided
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/25192#issuecomment-653587287, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXPTOSAABNIOZJYEGBDRZXXLLANCNFSM4OPWLXIQ
.

/test all

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
6d6a509de94063268ccc918ad27095ae9ba07720
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
6d6a509de94063268ccc918ad27095ae9ba07720
link
/test integ-pilot-k8s-tests_istio

lint_istio
8ca0ddebba2716ed9dbf0bffff886eb2da4c0153
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
fd8de393434fb792b940aa21bc473020c4264be6
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@howardjohn  PTAL. This is ready for review. All tests are passing (I made few changes to pass both version and nonce so that the protocol works correctly). Removed all inconsistencies across type urls. The new shouldRespond handles all the ADS protocol logic. Also moved to WatchedResources so that we can build on top of this. Left few TODOs for further work once we are good with this and merged.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
ccc20242deb415687ba29ac9fe9a367c1a986193
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-k8s-tests_istio

@ramaraochavali: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-telemetry-k8s-tests_istio

integ-galley-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-telemetry-k8s-tests_istio

integ-galley-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-telemetry-k8s-tests_istio

integ-galley-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-operator-controller-tests_istio

release-test_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-telemetry-k8s-tests_istio

integ-galley-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-operator-controller-tests_istio

release-test_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-telemetry-k8s-tests_istio

integ-galley-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-operator-controller-tests_istio

release-test_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-telemetry-k8s-tests_istio

integ-galley-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-operator-controller-tests_istio

release-test_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-telemetry-k8s-tests_istio

integ-galley-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-operator-controller-tests_istio

release-test_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-ipv6-k8s-tests_istio

lint_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-telemetry-k8s-tests_istio

integ-galley-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-operator-controller-tests_istio

release-test_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-ipv6-k8s-tests_istio

lint_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test lint_istio

gencheck_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-telemetry-k8s-tests_istio

integ-galley-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-operator-controller-tests_istio

release-test_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-ipv6-k8s-tests_istio

lint_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test lint_istio

gencheck_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test gencheck_istio

integ-security-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-telemetry-k8s-tests_istio

integ-galley-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-operator-controller-tests_istio

release-test_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-ipv6-k8s-tests_istio

lint_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test lint_istio

gencheck_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test gencheck_istio

integ-security-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-telemetry-k8s-tests_istio

integ-galley-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-operator-controller-tests_istio

release-test_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-ipv6-k8s-tests_istio

lint_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test lint_istio

gencheck_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test gencheck_istio

integ-security-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

If you use the existing active I am pretty sure there is a race condition
where OnConnect will access the Active map in a different goroutine - if
you look at my pr about the typeurl there is some commentary. My solution
was not great...
On Mon, Jul 6, 2020, 8:44 PM Istio Automation<EMAIL_ADDRESS>wrote:

@ramaraochavali https://github.com/ramaraochavali: The following tests
failed, say /retest to rerun all failed tests:
Test name Commit Details Rerun command
unit-tests_istio ec73d42
https://github.com/istio/istio/commit/ec73d426db750cc9a13e648f35683e8159185c28
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/25192/unit-tests_istio/15947 /test
unit-tests_istio
integ-telemetry-k8s-tests_istio ec73d42
https://github.com/istio/istio/commit/ec73d426db750cc9a13e648f35683e8159185c28
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/25192/integ-telemetry-k8s-tests_istio/15380 /test
integ-telemetry-k8s-tests_istio
integ-galley-k8s-tests_istio ec73d42
https://github.com/istio/istio/commit/ec73d426db750cc9a13e648f35683e8159185c28
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/25192/integ-galley-k8s-tests_istio/15366 /test
integ-galley-k8s-tests_istio
integ-operator-controller-tests_istio ec73d42
https://github.com/istio/istio/commit/ec73d426db750cc9a13e648f35683e8159185c28
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/25192/integ-operator-controller-tests_istio/3817 /test
integ-operator-controller-tests_istio
release-test_istio ec73d42
https://github.com/istio/istio/commit/ec73d426db750cc9a13e648f35683e8159185c28
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/25192/release-test_istio/15254 /test
release-test_istio
integ-multicluster-k8s-tests_istio ec73d42
https://github.com/istio/istio/commit/ec73d426db750cc9a13e648f35683e8159185c28
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/25192/integ-multicluster-k8s-tests_istio/5965 /test
integ-multicluster-k8s-tests_istio
integ-distroless-k8s-tests_istio ec73d42
https://github.com/istio/istio/commit/ec73d426db750cc9a13e648f35683e8159185c28
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/25192/integ-distroless-k8s-tests_istio/8624 /test
integ-distroless-k8s-tests_istio
integ-ipv6-k8s-tests_istio ec73d42
https://github.com/istio/istio/commit/ec73d426db750cc9a13e648f35683e8159185c28
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/25192/integ-ipv6-k8s-tests_istio/1636 /test
integ-ipv6-k8s-tests_istio
lint_istio ec73d42
https://github.com/istio/istio/commit/ec73d426db750cc9a13e648f35683e8159185c28
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/25192/lint_istio/15383 /test
lint_istio
gencheck_istio ec73d42
https://github.com/istio/istio/commit/ec73d426db750cc9a13e648f35683e8159185c28
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/25192/gencheck_istio/13974 /test
gencheck_istio
integ-security-k8s-tests_istio ec73d42
https://github.com/istio/istio/commit/ec73d426db750cc9a13e648f35683e8159185c28
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/25192/integ-security-k8s-tests_istio/15644 /test
integ-security-k8s-tests_istio
integ-pilot-k8s-tests_istio ec73d42
https://github.com/istio/istio/commit/ec73d426db750cc9a13e648f35683e8159185c28
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/25192/integ-pilot-k8s-tests_istio/15504 /test
integ-pilot-k8s-tests_istio
integ-mixer-k8s-tests_istio ec73d42
https://github.com/istio/istio/commit/ec73d426db750cc9a13e648f35683e8159185c28
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/25192/integ-mixer-k8s-tests_istio/13848 /test
integ-mixer-k8s-tests_istio
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/25192#issuecomment-654581017, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXK2ZMCNEQY76REEEJTR2KKZLANCNFSM4OPWLXIQ
.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-telemetry-k8s-tests_istio

integ-galley-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-operator-controller-tests_istio

release-test_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-ipv6-k8s-tests_istio

integ-security-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-mixer-k8s-tests_istio

gencheck_istio
730ce81d0eacb9f5ec7ad47c6e1fc26344802696
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-telemetry-k8s-tests_istio

integ-galley-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-operator-controller-tests_istio

release-test_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-ipv6-k8s-tests_istio

integ-security-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
ec73d426db750cc9a13e648f35683e8159185c28
link
/test integ-mixer-k8s-tests_istio

gencheck_istio
730ce81d0eacb9f5ec7ad47c6e1fc26344802696
link
/test gencheck_istio

unit-tests_istio
730ce81d0eacb9f5ec7ad47c6e1fc26344802696
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for pointing that out. I think having separate watched resources for experimental makes sense for now instead of complicating it. I have followed the same pattern

Ok sgtm. Haven't looked at the code yet - I assume that means my pr for the
type url is compatible with this? Or perhaps it's obsolete. Either way,
I'll hopefully approve this tomorrow then can merge my on top? Does that
make sense?
On Mon, Jul 6, 2020, 10:10 PM Rama Chavali<EMAIL_ADDRESS>wrote:

Thanks for pointing that out. I think having separate watched resources
for experimental makes sense for now instead of complicating it. I have
followed the same pattern
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/25192#issuecomment-654604366, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXOM6DCWBKWKOCBYYTDR2KU3TANCNFSM4OPWLXIQ
.

Yes. That makes sense. PTAL in detail whenever you get time. No rush


Follow the Freedesktop XDG base directory standard (in Linux)

On Linux, Gradle currently creates a $HOME/.gradle/ (or $HOME/.gradle-kotlin-dsl/) folder in the user's home directory. Most applications/programs don't create a folder in the user's home directory anymore, but instead use the Freedesktop XDG standard – found here: http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html.
Using this standard:

$XDG_CACHE_HOME says "temporal/non-essential" files go to $HOME/.cache/
$XDG_CONFIG_HOME says "configuration files" go to $HOME/.config/
$XDG_DATA_HOME says "data files" go to $HOME/.local/share/

This is just a request to consider using this standard. It makes a lot of sense; it is easy for the user to understand, makes it easier to backup / locate / restore / manage / clear user's data, and creates less clutter in the user's home directory.
Thanks in advance...and thanks so much for everyone's hard work on this – it's amazing!

As much as I would like something like this, I don't think we're going to do this for a few reasons:

We need to provide a familiar experience across all major platforms (Linux, macOS, Windows).  ~/.gradle (GRADLE_USER_HOME) does that for the most part.  If we were to adopt the XDG standard for Linux, I think we would want to do the proper thing for every platform (e.g., using %AppData% on Windows) and that would make things more different for better or worse.
We have backwards compatibility concerns.  People rely on configuration files in GRADLE_USER_HOME to keep their builds working, so we would need to support both locations for awhile.  Similarly, some people expect to be able to copy GRADLE_USER_HOME and reuse it.
We have cross-version concerns.  Some of the directories under GRADLE_USER_HOME are shared by multiple versions of Gradle.  We can't update the already released versions of Gradle, so we would have to either live with two copies of some things or support both locations.
I think there's also an issue with people using an old wrapper jar to install newer version of Gradle. This would stop working or use the old location.

If there's a lot of interest in this, maybe there are some smaller steps we could take to make this better.

I am also highly in support of this, our home directory deserves to be free!

I too would like to raise support for this issue.  My use case:   I periodically back up my $HOME directory using rsync.  I pass --exclude=~/.cache/ to rsync to avoid backing up cache-able files.  While waiting for the backup to complete today, I noticed it was taking a pretty long time.   Looking at the logs, it was spent mirroring many gigs of ~/.gradle/caches.
If Gradle had followed the pattern of putting its caches in a consistent folder, it would have saved me the time of having to look into this, and adding more special cases to my backup scripts.

Although actually, almost everything in the folder is some sort of cache. This would be the structure as I see it:

put the gradle.properties into ${XDG_CONFIG_HOME:-~/.config}/gradle
everything else goes into ${XDG_CACHE_HOME:-~/.cache}/gradle

So the change wouldn't have to be big.
That can't currently be replicated because the gradle.properties is only searched for in GRADLE_USER_HOME. A first step could be to simply search the above config location additionally. Then we could set GRADLE_USER_HOME to .cache/gradle and it should work rudimentarily.

+1 for this. I can set Gradle to use the proper dirs, but it should really use them by default. Please reconsider.

As for the GRADLE_USER_HOME concern, lots of projects use the XDG standard and still have their own flags / env vars to specifically use another location.
You could do the same; if GRADLE_USER_HOME is set, only use that directory (maybe with an info message?), otherwise use the XDG folders

Please follow the XDG directory standard. Gradle could check for ~/.gradle and default to the old bahaviour but allow (and default to) the XDG standard.

@big-guy the suggestion of @dragetd seems to be a very neat one, don't you think, for two years or so? the current behaviour is very cumbersome in windows corporate environments as all the distributed file caches follow the windows %appdir% structure. you want me to create ticket for this, or change the title here to make it a platform independent problem?

Please help to clean my home directory and follow the XDG Base Directory Specification [1].
Thanks for doing Gradle! I use it since a few days and enjoy it.
[1]  https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html

Hm, this is unfortunate.
For those stumbling over this in the future, I use a script that helps me here:
#!/bin/sh

FAKE_HOME="${XDG_CONFIG_HOME:-$HOME}/.config/noXDG"

# Get the real path of this script
SCRIPT=$(readlink -f "$0")

# And the called command
CMD="$(basename $0)"

# Exec
which -a "$CMD" | {
  while read -r EXEPATH; do
    if [ "$(readlink -f $EXEPATH)" != "$SCRIPT" ]; then
      exec "$EXEPATH" "$@"
    fi
  done
  echo "fake-home could not find executable shadowed by $CMD" >&2
  exit 1
}

This is in my .local/bin directory and has symlinks for any app onto fake-home to fix this bug.
As for gradle, maybe the developers are willing to at least discuss it again if it was contributed as an external contribution? One that respects backward-compatibility and is configurable?

Yeah, given the support for this feature it seems a little odd that it was closed without any clarifying comments as to why.

@big-guy, @donat  here from apple where they expect files: https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPFileSystem/Articles/WhereToPutFiles.html. user home is a nogo there. they have a cache directory as well.
for the reasons above, there seems to be a solution for all of them:

operating system specific locations are the rule, not the exception, gradle is sticking out. gradle sticking out breaks the backup experience as well, as it does not backup essential user data but a huge gradle cache,  if one does not exclude it.
for backward compatibility one can check if .gradle exists for a couple of time.
running multiple versions of gradle is not an issue, 2 copies wil stay, or a user will link the directories if bothering too much.
if the old wrapper jar is used, also not problem. whoever has a problem will with pleasure upgrade.

Please consider reopening ...

This feature is still missing and especially for such a widely used tool I find it surprising that this is not being prioritised.

@big-guy if you ask for smaller steps, can you imagine that you put created files which can be lost in xdg_cache_dir ? this would already solve the backup problem. default is easy for all operating systems:

linux: ~/.cache/gradle/
windows: %LOCALAPPDATA%
macos: ~/Library/Caches/gradle/


fix: escape the .net filter subsitution for shells

The filter substition is directly embedded into the command, which means that " quotes will behave according to the shell. Resulting in something along the lines of:
dotnet test --filter "FullyQualifiedName=Foo.Bar(val: "Hello World")"

The shell will interpret this and pass an invalid string to dotnet test, resulting in the following error:

2023-08-01T20:20:59.7326742Z [xUnit.net 00:00:00.24] Cmg.DataLabGateway
.IntegrationTests: Exception filtering tests: Incorrect format for
TestCaseFilter Missing Operator '|' or '&'. Specify the correct format and
try again. Note that the incorrect format can lead to no test getting
executed.

This change will simply replace all occurrences of " with \", which should be interpreted by the shell correctly.
Closes #53

I can look into the issues w/ RWX_ACCESS_TOKEN_STAGING 🤔

Fixed in #57 (released in https://github.com/rwx-research/captain/releases/tag/v1.11.3). Thanks for your help with this!


HabitRPG is now called Habitica, URLs have changed

See awesome-selfhosted#105.

Thanks a lot for the notification @Kickball :+1:


Avoid const generics for nD

It's very hard up to impossible to write something generic/dynamic around a NativeArray.

Can you provide any more detail? Can you list what you've tried? There are couple dozen examples of writing generic code on a NativeArray in the algorithm mod.
It's imperative that geoarrow-rs is able to represent dimensions more than just XY, and so the generic is unlikely to be removed.
I've also been experimenting with a NativeGeometryAccessor trait, so you can implement a function like
pub fn algorithm(array: impl NativeGeometryAccessor<2>) {
    for i in 0..array.len() {
        let geom = array.value_as_geometry(0);
        let geo_geom = geom.to_geo();
        // Do something with your geometry
    }
}

In the end, it didn't matter anymore. So wrapping into a dyn NativeArray is the way to go. I was at some point trying to return a typed generic array which is obviously impossible.
Still believe there are better ways to model multiple dimensions. Where do you see the benefit, and why is it unlikely to go away?

Right you can't return a typed generic array.

Still believe there are better ways to model multiple dimensions.

Like what? Would love some examples

Where do you see the benefit, and why is it unlikely to go away?

We need to be able to statically know the memory layout of the array. Otherwise we'll pay a dynamic dispatch penalty when accessing every row of every child of every array. That means we need to know "This is a polygon array with 2D geometries" or "this is a MultiPoint array with 3D XYZ geometries".

Like what? Would love some examples

For example rstar and nalgebra.

I'm less familiar with nalgebra, but numpy has both generic and untyped array constructs. The generic in geoarrow arrays is equivalent to the generics on PyArray, which needs to statically know type and dimension. The dyn NativeArray is similar to dyn Array in arrow or to the numpy PyUntypedArray, which makes you downcast to a concrete array to do more operations.

As far as I can tell, const generics are only used for the dimensions, not for the actual data. This is basically what I try to suggest here.

The const generics are used in the underlying coordinate buffers: https://github.com/geoarrow/geoarrow-rs/blob/b6eb8d2ac9e5c13795c06b76316b4aad39000957/src/array/coord/separated/array.rs#L16-L19

That would need to change of course as well.

If we don't have a const generic there, we would need to either pay a runtime penalty of inferring the dimension for every coordinate, or we'd need to always store 4 dimensions even if we're only using two.
I still don't understand what you're proposing

const generics are only used for the dimensions, not for the actual data

I don't understand this statement. 3D coordinates are actual data

Well dimensions in ndarray are always 2 for geometries, only the shape changes which are not const generics. Geoarrow is using const generics for the shape. There would be a negligible overhead since the value is valid for the whole array and hence only needs to be checked once.

Well dimensions in ndarray are always 2 for geometries, only the shape changes which are not const generics.

That is relevant for geoarrow for the interleaved coordinate buffer case, but not for the separated coordinate buffer case. To handle separated coordinates we need to have one separate underlying Arrow buffer per coordinate dimension. So we either need to have a Vec<Buffer>, which then has an extra heap indirection on every coordinate access, or we can have an array of buffers, but that needs a const generic

Also it would still be typed just not directly with a const generic.


Eliminate empty lines in .nt serializations

RDFlib's .nt serialization is ending up with an empty line at the beginning of the file that doesn't need to be there. It's not harmful, but is unnecessary and ugly; can we eliminate this?

RDFlib's N-Triples serialization has an extra blank line at the end. pySBOL3's sorted N-Triples format takes the output of RDFlib's N-Triples serialization and sorts it. The sort puts that empty blank line at the beginning.
I don't know why RDFlib puts an extra blank line at the end of an N-Triples file. Here is a short example of that:
>>> import rdflib
>>> g = rdflib.Graph()
>>> g.add((rdflib.URIRef('sbol3'), rdflib.RDF.type, rdflib.URIRef('package')))
<Graph identifier=Nce436cfb72f04910be1cb0c2b4d1d3eb (<class 'rdflib.graph.Graph'>)>
>>> print(g.serialize(format='nt11'))
<sbol3> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <package> .

>>>

We can tackle this in a couple of different ways. We could remove the blank line in both N-Triples and Sorted N-Triples formats by filtering them. We could also filter out the blank line only in sorted N-Triples since it moves to the front of the file and is more obvious than the blank line at the end.
I don't know if this is a bug in the RDFlib N-Triples serialization, or if it is a feature.


update the legal term texts

This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines

[ ] The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

[ ] Each command and parameter has a meaningful description.
[ ] Each new command has a test.

(see Authoring Command Modules)

Closing in favor of https://github.com/Azure/azure-cli/pull/3261


Request credentials for an os-climate bucket

Requesting credentials for github user: aditigautam78
Requesting credentials for the bucket:  OS-Climate data
Email address to send a credential download link<EMAIL_ADDRESS>Request checklist:

[ ] User can establish connection with the bucket
[ ] User can read files from the bucket
[ ] User can write files to the bucket

Thank you for your interest in OS-Climate! Can you please let me know know what interests you about OS-Climate and what repos you would like to be a part of? If you have any additional information to provide, we'd appreciate hearing from you before we open up access. Thanks!

@MichaelTiemannOSC - are you able to help with this request?

Glad to have you involved!  We are in the final stage (?) of shifting all the physrisk data from private buckets to data hosted by ASDI.  @ModeSevenIndustrialSolutions may have visibility into when that may happen.  If not as soon as I think, he can give you read-only credentials and ability to list buckets within the physrisk space.  But the ASDI-hosting will make everybody's life much easier.


Modals should use mouseup for backdrop

Describe what feature you'd like. Pseudo-code, mockups, or screenshots of similar solutions are encouraged!
Modals currently use on:mousedown to detect if the user clicks on the backdrop. This seems like an odd decision, given that most UI libraries use on:mouseup (or on:click) because that matches with other components. I doubt anyone would want a button that triggers upon mousedown. Might seem like a small change, but in my eyes, on:mouseup just feels right - mainly because you, me and probably everyone else is used to it.
What type of pull request would this be?
Enhancement
Any links to similar examples or other references we should review?
Some modals which use mouseup.
https://mui.com/material-ui/react-dialog/#basic-dialog
https://docs.svelteit.dev/modals
https://chakra-ui.com/docs/components/modal/usage#control-focus-when-modal-closes
https://ant.design/components/modal#examples
https://illright.github.io/attractions//docs/components/modal
https://tailwindui.com/components/preview#component-47a5888a08838ad98779d50878d359b3
https://flowbite.com/docs/components/modal/#default-modal
https://daisyui.com/components/modal/#modal-that-closes-when-clicked-outside
If you actually tried them, you'll probably find a shocking difference when using mousedown ones.
https://skeleton-docs-skeleton-labs.vercel.app/utilities/modals
https://www.svelteui.org/core/modal

Copying some of the discussion from Discord over here - I've recalled why we opted for mouseup over mousedown. This has to do with how certain interactions with the modal contents can play out.
In short, if you have text or an input within the modal you might wish to use your mouse down click down, select the text, and then let up when ready. But sometimes your mouse will end up over the backdrop when you do this, which means if we close the modal when on:mouseup fires on the backdrop. This would cause the undesired behavior of accidentally closing the modal while trying to select text. That's no good.
@tizu69 pointed out that modals like MUI do not suffer from this issue though, and it appears they're tracking a combination of events. Imagine there's three ways to go about this:

using on:click - this would be subject to the select drag issue
using on:mousedown - only tracks clicks that start on the backdrop
using both on:mousedown/up - ensuring both click events happen over the backdrop

Number 1 is outright bad, and not a good solution. Number two was our fix for the prior issue, and works well enough in most situations. While number three is likely what MUI uses. It's more complicated, but perhaps a desired change here if we want to make sure the click behavior is working per the user's expectations. It's an extra safeguard.

I would love to work on this issue.

Sure @Mahmoud-zino, I've assigned this to you. Thanks.


faulty requirements pyasn1_modules

Hey there,
I'm trying to conda build oauth2client but it doesn't work since the requirements in oauth2client/setup.py specifies pyasn1_modules while on pypi etco the module is known as pyasn1-modules (dash and not underscore).

Error: No packages found in current osx-64 channels matching: pyasn1_modules >=0.0.5

No idea how to solve it?

Thanks. We've never noticed becaused pip resolves it with no issues.
Here is the PyPI project:
https://pypi.python.org/pypi/pyasn1-modules

Thanks, I could bypass the thing by modifying the conda recipe to build towards the underscore variant.

No need to close, it's easy for us to change, I was just trying to figure out why we had never noticed.


setuptools 34 requires pyparsing >= 2.0.3

Setuptools 34.0.1-34.1.1 doesn't coexist with pyparsing 1.5.7, failing with the following error (which can be found in various places across Google):
$ virtualenv env
$ env/bin/pip install --upgrade pip wheel setuptools==34.1.1
...
$ env/bin/pip install pyparsing==1.5.7
Collecting pyparsing==1.5.7
Installing collected packages: pyparsing
  Found existing installation: pyparsing 2.1.10
    Uninstalling pyparsing-2.1.10:
      Successfully uninstalled pyparsing-2.1.10
Successfully installed pyparsing-1.5.7
$ env/bin/python -c 'import setuptools.version'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/tmp/env/local/lib/python2.7/site-packages/setuptools/__init__.py", line 12, in <module>
    import setuptools.version
  File "/tmp/env/local/lib/python2.7/site-packages/setuptools/version.py", line 1, in <module>
    import pkg_resources
  File "/tmp/env/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 72, in <module>
    import packaging.requirements
  File "/tmp/env/local/lib/python2.7/site-packages/packaging/requirements.py", line 59, in <module>
    MARKER_EXPR = originalTextFor(MARKER_EXPR())("marker")
TypeError: __call__() takes exactly 2 arguments (1 given)

I've seen the conversation in #940, which states that only installing from wheels is supported, but this is some pretty non-obvious breakage. I've also just found pypa/packaging#91 and pypa/packaging#93, but not until after discovering the dependency issue and going to write a pull request.
As a wheel build doesn't exist for previous versions (pip install --only-binary pyparsing pyparsing==1.5.7 fails) would it be reasonable to set a dependency in setuptools to be explicit?

I'd rather not place the dependency in the wrong place as a workaround for a known issue, as then I have to manage the workaround, which should be more work than just getting the issue fixed in packaging, which is the right thing to do. It would not make sense to have this dependency declared in setuptools except for this issue. Since the traceback implicates packaging and the issue is filed there, it seems it would be best to put the pressure on that package to release the appropriate fix.


Hardlinks fuse

Report the right number of hardlinks for directories in fuse mounts

How do we solve this?

Uhm, what code was added in this PR that was not in the code that I merged yesterday?
Besides, I added a very small commit on top of your code, so that the number of hardlinks is correctly displayed in the fuse mount: https://github.com/restic/restic/commit/6275d69a3612c1fd8c14cb099e67ddd140081af4
As far as I can see, this already works, this is in the fuse mount for two archived hard linked files test and test-hard:
$  stat test test-hard
  File: test
  Size: 4         	Blocks: 1          IO Block: 512    regular file
Device: 2ah/42d	Inode: 8391094     Links: 2
Access: (0644/-rw-r--r--)  Uid: ( 1000/     fd0)   Gid: (  100/   users)
Access: 2017-02-10 21:14:04.554814170 +0100
Modify: 2017-02-10 21:14:04.554814170 +0100
Change: 2017-02-10 21:14:07.018138855 +0100
 Birth: -

  File: test-hard
  Size: 4         	Blocks: 1          IO Block: 512    regular file
Device: 2ah/42d	Inode: 8391094     Links: 2
Access: (0644/-rw-r--r--)  Uid: ( 1000/     fd0)   Gid: (  100/   users)
Access: 2017-02-10 21:14:04.554814170 +0100
Modify: 2017-02-10 21:14:04.554814170 +0100
Change: 2017-02-10 21:14:07.018138855 +0100
 Birth: -

I have added the correct report of the number of hardlinks for directories in case of fuse mounts.
The currect number is 2 (. plus the dir itself) plus the number of subdir (as .. is implement as a hard link to the parent).

As far as I know that's not always the case: First, there are only very few file systems that even allow hard linked directories (problems outlined here: http://askubuntu.com/a/525129), second the link count for directories returned from the stat syscall varies by file system, so I think we can just leave it at one.
Is there anything else in this code that needs to be merged? I must admit I don't have an overview any more...

No, it was only the dir part.
Normally, you can not use hard links for reasons as described by the article you refering to.
However, usually the filesystem is implemented such that the number of hardlinks of a directory equals two plus the number of subdirs contained by that dir. Two because because the dir name and . is a hardlink and .. in all the subdirs are also hardlinks. Just use ls -al and you will see

So, do you think we really need to implement this for the fuse mount? Or is this just for completeness' sake?

Well, it is up to you.
While comparing the fuse mount with my test backup dir, I was confused that the link numbers in fuse where not matching the link numbers in my test dir.
Actually, for the same reason, it is not entirely clear to me why . and .. are not present.
Personally, I have no problems with that but users might be confused.

 I didn't notice that until now!
Ok, you convinced me, I'll extract your work on the fuse directory implementation and merge that. I'll open a new PR just with the commits shortly, and I'll close this PR for now.

I've extracted your code to PR #800, please have a short look if everything is in there.

I think . an .. should definitely be there, unless adding them is a major issue.

I'll add an issue to track this.

See #802.


Migrate to spago@next

Migration to new spago.
@i-am-the-slime can you have a look at this? Haven't used the new spago yet. Will that still work with the old spago or does that require the .dhalls to be present?

Haven't done this before. I'm not up-to-date. Let's see if it works?

https://github.com/purescript-contrib/setup-purescript/issues/37


Don't apply the gradle-versions-plugin

If you see this error:
An exception occurred applying plugin request [id: 'de.fayard.buildSrcVersions', version: '0.5.0']
> Failed to apply plugin [id 'de.fayard.buildSrcVersions']
   > Cannot add task 'dependencyUpdates' as a task with that name already exists.

then remove the gradle-versions-plugin
plugins {
-    id("com.github.ben-manes.versions") version "0.25.0"
    id("de.fayard.buildSrcVersions") version "0.5.0"
}

It's already applied by the plugin

It's not crashing anymore


Add Matrix mentions utils [wip]

This PR should add utilities to help with creating Matrix spec compliant mention HTML.

Part of https://github.com/matrix-org/matrix-rich-text-editor/issues/692

As input, functions might accept:

a Matrix mention URL
a potentially ambiguous display name
any room aliases that are available

As output, functions should return:

a valid mention URL and anchor/body text combination
any other useful information required by the library (e.g. the mention type required by matrix-org/matrix-rich-text-editor#709)

Reference
Valid mention URL and anchor/body text combinations according to the Matrix spec:

When mentioning users, use the user’s potentially ambiguous display name for the anchor’s text. If the user does not have a display name, use the user’s ID.
When mentioning rooms, use the canonical alias [fallling back to alias then room ID] for the room. In all cases, use the alias/room ID being linked to as the anchor’s text.

The text component of the anchor should be used in the event’s body where the mention would normally be represented, as shown in the example above.

Codecov Report
Patch coverage: 96.27% and project coverage change: +2.96 :tada:

Comparison is base (9767c3b) 86.85% compared to head (8fb7b9b) 89.82%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #695      +/-   ##
============================================
+ Coverage     86.85%   89.82%   +2.96%
============================================
  Files           143       80      -63
  Lines         16291    13751    -2540
  Branches        761        0     -761
============================================
- Hits          14150    12352    -1798
+ Misses         1953     1399     -554
+ Partials        188        0     -188

Flag
Coverage Δ

uitests
?

uitests-android
?

unittests
89.82% <96.27%> (+2.17%)
:arrow_up:

unittests-android
?

unittests-ios
?

unittests-rust
89.82% <96.27%> (+0.07%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/matrix_mentions/src/mention.rs
96.25% <96.25%> (ø)

crates/matrix_mentions/src/lib.rs
100.00% <100.00%> (ø)

... and 65 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Closing in favor of #717


Collapse, don't hide, parameter tuning panel.

Show as a clickable dropdown in the tab bar at the top.

See https://github.com/damellis/sensors/commit/eb95d807166b7b2e3fe036fd9b36445be39c65be.
There is an open issue (https://github.com/braitsch/ofxDatGui/issues/57) of how to collapse it by default instead of being opened. I will follow up on this.