Embed OpenAL Library Files for Mac/Linux

Summary of feature
Simply embeds the library files into the EXE file  for Mac/Linux just like it does for Windows so that no one has to manually mess with projects settings and grab the  library files .
Comments
Ill admit Im being a bit lazy but I bet Im not the only who thinks having a million dll's for a final  release is a mess.
Does this have a proposal?
Include the library files for Linux/Mac single file publish just like it is for Windows.

Set the IncludeNativeLibrariesForSelfExtract MSBuild property to true.

From @Kuumba123 on duplicate issue #1698
This is re-issue of issue that was immedilatly closed (https://github.com/dotnet/Silk.NET/issues/1697 and yes I already had everything setup in project/publish settings otherwise my program wouldn't have worked regardless if I was using Silk.NET) next time please dont just immediatly close issues , I wouldn't have opened either of these issues unless I know there was a problem. I guess Ill try to explain a bit more depth what the issue is. So normally when I want write a .NET 6 cross platform app I go to publish and then select the platform I want to publish for (mac , linux etc). Depending on witch platform I select the libraries (that generally get via nugget) I include in my C# project the libraries simply include different library files (dll,so files etc) based on the platform I am publishing for. However for some reason with Silk.NET (more specficly openAL) it doesnt include the propery library files if I publish for anything other than windows so if I try to run the program Ill get an error as soon as it tries to run any code that uses Silk.NET. Now I could just go in the source code and grab the correct library files (libopenal.so and libopenal.dylib in my case) and just copy them to the same directory as the Linux and Mac EXE witch fixes the problems. I could also just force users to just install openAL but I dont like doing that (especally for linux cause of all the distros). But preferable this should all be taken care of by the libraries and not by me copying library files and messing with my the files included in my project. Anyways hopefully you folks understand what Im talking about.

Can you send me your csproj please

thanks for reopening :) , right here is C# project file:
<Project Sdk="Microsoft.NET.Sdk">
	<PropertyGroup>
		<OutputType>WinExe</OutputType>
		<TargetFramework>net7.0</TargetFramework>
		<ImplicitUsings>enable</ImplicitUsings>
		<PublishSingleFile>false</PublishSingleFile>
		<SelfContained>false</SelfContained>
		<Nullable>enable</Nullable>
		<Configurations>Debug;Release;Linux;Mac-x64;Mac-ARM64</Configurations>
		<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
	</PropertyGroup>
	<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Linux|AnyCPU'">
	  <Optimize>True</Optimize>
	</PropertyGroup>
	<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Mac-x64|AnyCPU'">
	  <Optimize>True</Optimize>
	</PropertyGroup>
	<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Mac-ARM64|AnyCPU'">
	  <Optimize>True</Optimize>
	</PropertyGroup>

  <ItemGroup>
    <None Remove="UI\ImGuiShadders\GLSL\imgui-frag.glsl" />
    <None Remove="UI\ImGuiShadders\GLSL\imgui-vertex.glsl" />
    <None Remove="UI\ImGuiShadders\HLSL\imgui-frag.hlsl.bytes" />
    <None Remove="UI\ImGuiShadders\HLSL\imgui-vertex.hlsl.bytes" />
    <None Remove="UI\ImGuiShadders\Metal\imgui-frag.metallib" />
    <None Remove="UI\ImGuiShadders\Metal\imgui-vertex.metallib" />
    <None Remove="UI\ImGuiShadders\SPIR-V\imgui-frag.spv" />
    <None Remove="UI\ImGuiShadders\SPIR-V\imgui-vertex.spv" />
  </ItemGroup>

  <ItemGroup>
    <EmbeddedResource Include="UI\ImGuiShadders\GLSL\imgui-frag.glsl" />
    <EmbeddedResource Include="UI\ImGuiShadders\GLSL\imgui-vertex.glsl" />
    <EmbeddedResource Include="UI\ImGuiShadders\HLSL\imgui-frag.hlsl.bytes" />
    <EmbeddedResource Include="UI\ImGuiShadders\HLSL\imgui-vertex.hlsl.bytes" />
    <EmbeddedResource Include="UI\ImGuiShadders\Metal\imgui-frag.metallib" />
    <EmbeddedResource Include="UI\ImGuiShadders\Metal\imgui-vertex.metallib" />
    <EmbeddedResource Include="UI\ImGuiShadders\SPIR-V\imgui-frag.spv" />
    <EmbeddedResource Include="UI\ImGuiShadders\SPIR-V\imgui-vertex.spv" />
  </ItemGroup>

  <ItemGroup>
    <PackageReference Include="ImGui.NET" Version="<IP_ADDRESS>" />
    <PackageReference Include="Silk.NET.OpenAL" Version="2.17.1" />
    <PackageReference Include="Veldrid" Version="4.9.0" />
    <PackageReference Include="Veldrid.StartupUtilities" Version="4.9.0" />
  </ItemGroup>

  <ItemGroup>
    <Folder Include="Misc\" />
  </ItemGroup>

</Project>

Ill also include the publish profile for linux (windows publish file xml is pretty much the exact same) since that might help solve this issue:
<?xml version="1.0" encoding="utf-8"?>
<!--
https://go.microsoft.com/fwlink/?LinkID=208121.
-->
<Project>
  <PropertyGroup>
    <Configuration>Linux</Configuration>
    <Platform>Any CPU</Platform>
    <PublishDir>bin\publish\PogTro-linux-x64</PublishDir>
    <PublishProtocol>FileSystem</PublishProtocol>
    <_TargetId>Folder</_TargetId>
    <TargetFramework>net7.0</TargetFramework>
    <SelfContained>true</SelfContained>
    <RuntimeIdentifier>linux-x64</RuntimeIdentifier>
    <PublishSingleFile>true</PublishSingleFile>
    <PublishTrimmed>true</PublishTrimmed>
  </PropertyGroup>
</Project>

The IncludeNativeLibrariesForSelfExtract property is not present anywhere in those files, please include it in your csproj or publish profile.

my appologizes that was my main project I plan on using Silk.NET.OpenAL with , I should have posted the test project I made. Heres the test project:
<Project Sdk="Microsoft.NET.Sdk">

	<ItemGroup>
		<PackageReference Include="Silk.NET.OpenAL" Version="2.17.1" />
	</ItemGroup>
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net6.0</TargetFramework>
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>
    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
	  <IncludeNativeLibrariesForSelfExtract>true</IncludeNativeLibrariesForSelfExtract>
  </PropertyGroup>

</Project>

heres the linux publish file:
<?xml version="1.0" encoding="utf-8"?>
<!--
https://go.microsoft.com/fwlink/?LinkID=208121.
-->
<Project>
  <PropertyGroup>
    <Configuration>Release</Configuration>
    <Platform>Any CPU</Platform>
    <PublishDir>bin\Release\net6.0\publish\linux</PublishDir>
    <PublishProtocol>FileSystem</PublishProtocol>
    <_TargetId>Folder</_TargetId>
    <TargetFramework>net6.0</TargetFramework>
    <RuntimeIdentifier>linux-x64</RuntimeIdentifier>
    <SelfContained>true</SelfContained>
    <PublishSingleFile>true</PublishSingleFile>
    <PublishTrimmed>false</PublishTrimmed>
    <IncludeAllContentForSelfExtract>true</IncludeAllContentForSelfExtract>
    <IncludeNativeLibrariesForSelfExtract>true</IncludeNativeLibrariesForSelfExtract>
	  <IncludeNativeLibrariesForSelfExtract>true</IncludeNativeLibrariesForSelfExtract>
  </PropertyGroup>
</Project>

You haven’t installed the OpenAL Soft package. Silk.NET will not automatically include binaries unless you ask it to and change your code to use OpenAL soft.

It’s worth noting that macOS should work OOTB as we use the system implementation if we can find it, but knowing Apple they’ve probably deprecated it…

I havne't had a chance to test on Mac since I would neeed my uncle's Laptop for that (still dont have my own Mac) . However give that I am having these problems with Linux I would assume it would have similar problems on Mac as well.

Apple ships an OpenAL implementation and while it is deprecated, it is still functional in modern versions of the OS. This is purely a Linux issue. Before you report that something is broken on a particular platform, please make sure it actually is.
Please install OpenAL using your Linux distribution's package manager, or if you don't want to require that use OpenAL Soft. This will involve installing the Silk.NET.OpenAL.Soft.Native package and setting your GetApi calls to true for the soft parameter.


[Bug]: K8s secret vault-operator-creds is not documented

Describe the bug
When deploying the vault operator, it references a K8s secret called vault-operator-creds.  The origins of it are not documented
From the name, I assume that it is used to authenticate the operator itself to the Vault.
Could you please document its purpose. Possibly with a rough sketch how to set it up.
Ideally with a little script on how to roll out the required app-roles in Vault itself.
TIA

Hi @cypherfox! Thanks for reporting. You're totally right. The secret is expected to hold two fields to access Vault:

VAULT_ROLE_ID
VAULT_SECRET_ID

My suggestion is to make the secret name configurable via the values file and document this.


Fix fast jit issues

Fix br if not clear_value issue
Fix i64.DIV/REM issue: i64 result rax/rdx may be overwritten by following i32 load eax/edx

LGTM


Consider unpackage-ing

The code here is useful for exploring various cosmological concepts however, much of the code in the actual AstronomyCalc package should be replaced with functions available in other widely-used packages such as Astropy and emcee.  Instead of bundling this work as a new package, I would recommend publishing as a collection of notebooks.
Submitted as part of JOSE Review.
openjournals/jose-reviews#261

I agree that there are several highly optimised packages out there for the calculations presented in the tutorials. However, the key goal of this package is to show the students how the concepts or equations taught in the classroom can be coded up and give them tasks where they would be asked to use some functions or go beyond it. Using the widely-used packages during teaching may help them learn using these packages but not developing them.

I am considering to instead extend the notebook with advanced examples using the widely-used packages. This would direct them to try out these packages after learning the basic methods. @kelle what do you think?


Release patrol_cli v1.1.4, patrol v1.0.9

I feel I need your green light, @jBorkowska @mateuszwojtczak.


建议支持嵌入hexo

https://github.com/imsun/gitment/issues/1#issuecomment-292842991
在此另开issue讨论

#12

我加了，但是Error: Issues are disabled for this repo报这个错误，我还在研究

 https://advance-esthetic.us/rf-facial-machines


Make oss-migration play nicely with apiext.

It needed to include many things that it wasn't including.
Side note: we really need to document how the require.yaml's work.
Signed-off-by: Flynn<EMAIL_ADDRESS>

See also: k8s-config/*/require.yaml in emissary.git

Also, the Service is missing?

This might already be a problem with rel/v2.1.0, but CI is failing because
Error: the lock file (Chart.lock) is out of sync with the dependencies file (Chart.yaml). Please update the dependencies

A helm dependency update is in order.

Superseded by #34.


[JSDoc] Add missing documentation for botbuilder-dialogs-adaptive Actions folder 1/3

Addresses # 2602
Description
This PR adds all the missing JSDoc documentation for botbuilder-dialogs-adaptive based on the errors thrown. Some documentation is ported and adapted from botbuilder-dotnet.
Specific Changes

Ported documentation from botbuilder-dotnet
Added @private for private methods.
Added JSDoc comments in 12 files
Fixed unnecessary semicolon warnings.

Testing
In the following image there is a sneak peek about the ESLint Report with no JSDoc errors.

Thanks @sw-joelmut ,  I solved those paste errors. Regarding this:

There are some changes, that are not related to JSDoc comments and library

Do you mean the unnecessary semicolon warnings? Should I revert changes like that?

Thanks @sw-joelmut , I solved those paste errors. Regarding this:

There are some changes, that are not related to JSDoc comments and library

Do you mean the unnecessary semicolon warnings? Should I revert changes like that?

I'm seeing this files.

Thanks @sw-joelmut , I solved those paste errors. Regarding this:

There are some changes, that are not related to JSDoc comments and library

Do you mean the unnecessary semicolon warnings? Should I revert changes like that?

I'm seeing this files.

Solved updating the fork and changing the PRs branch from main to master to main again, practically changing the branch and selecting it again.

I think this description is wrong.
@ceciliaavila this was ported exactly from CS, where DeleteActivity.cs's description is a duplicate to SendActivity.cs.
I corrected the description in the latest commit, as well as all other changes requested.

@iscaltritti-sw Please solve conflicts and make sure the build passes so we can promote it

Conflicts solved, build passes. All ready to go, @denscollo

Promoted


Typo fix (plural to singular) on msg ext search commands

Pretty sure this is supposed to be singular, not plural

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/messaging-extensions/how-to/search-commands/respond-to-search.md
91
12
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/messaging-extensions/how-to/search-commands/respond-to-search.md
91
12
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


LUA file is installed still VLC is giving issue

Hi,
My vlc is giving "syncplay.lua not found error" even thought syncplay.lua is installed in proper directory.

I only use Syncplay on Windows and most of the other developers only use Syncplay on Linux with mpv, but we'll do our best to get this to work...

What OS and version of VLC are you using?
What folder is cli.luac in? If it is a different folder, then use that folder.
Are the permissions/owner for syncplay.lua the the same as for cli.luac? If not, then try and make the syncplay.lua file have the same details

See https://github.com/Syncplay/syncplay/issues/102


Get rid of minor Julia versions in the breadcrumbs

See above. Right now it shows "Julia 1.1.0" in the breadcrumbs, which is incorrect and often out of sync.  I think just saying "Julia" would be good enough for now.  We can deal with it again when Julia releases a 2.0 version

cc @DrDrij, what are your thoughts? I think this is grabbing the kernel information from the conf.py:
jupyter_kernels = {
    "julia": {
        "kernelspec": {
            "display_name": "Julia 1.1.0",
            "language": "julia",
            "name": "julia-1.1"
            },
        "file_extension": ".jl"
    }
}

Do we just change the display name?

If it is just grabbing the kernel information, it should keep updated. I think it is useful to know which version was used to run the code.

It gives the (incorrect) impression that the code only runs on a particular minor version of Julia, which is incorrect. If you want that sort of information, you could see it in the coverage.

I would disagree that it gives that impression as most blogs and kernels will have the version it runs. I don't assume it wouldn't run with anything later (e.g., Julia v1.2.0 which is the current latest release, and the version people default to when installing Julia the first time). No strong feeling on whether it would work with the long term support release (Julia v"1.0.4"). We could add a note if there is anything that requires a new feature (e.g., 1.3.0 for threads).

Worth noting that the kernel information isn't necessarily even up-to-date; i.e., conf.py could be out of sync with what comes out of jupyter kernelspec list. You'd need to grab info from nbconvert to see what the display name is for the kernel that's actually used.
I've submitted a commit and I'll check if this is fixed in the next hourly build.
We can change it back later if that's what @Nosferican and @jlperla decide.

Great.  BTW, note that the "Python" lectures just say "Python" in the breadcrumb, without even saying Python 3, so this is much more consistent with the general site.

You can see that this has been fixed in the preview-lectures.quantecon.org/jl lectures.


Use the new url scheme and drop latest

Makes it work with the new url schema of CLDR. I have to drop support to get the latest, the version of CLDR has to be passed explicitly.

Thank you!


Stickers will crash!

Receiving a sticker will put the bot in an infinite loop. It will error with the offset, never update the offset position and continuously try and fail.

Seems this is a duplicated with your previous issue. Isn't it?

yes, i get this too. was just trying with the debugger to see what was going on.
I'm using
		this.bot = new TelegramBot(token, {
			polling: true
		});

		// FIXME - same message repeats
		bot.on('sticker', function(input) {
			console.log("sticker", input);
			TelegramAdapter.showFileInfo(input);
		});

is there another way to use the service, with polling not webhook?
for example where can we set the value for long polling?
is my understanding that to do that we would call  getUpdates
from the app and the app would have to keep track of the offset?
TelegramBot.prototype.getUpdates = function (timeout, limit, offset) {

when using long polling, more events will stream in, so the offset needs to be adjusted on each incoming event, not just when the poll is made?
Thanks for any advice.

this works:
		// FIXME - node API crashes currently
		// https://github.com/yagop/node-telegram-bot-api/issues/16
		bot.on('message', function(input) {
			console.log("message", input);
			if (input.sticker) {
				TelegramAdapter.showFileInfo(input.sticker, input.chat.id);
			}
			if (input.photo) {
				TelegramAdapter.showPhotoInfo(input.photo, input.chat.id);
			}
			// TelegramAdapter.showFileInfo(input);
		});

btw related question - is there any way in the telegram UI for getting the file_id for a photo? that was why i had to write that little script above....

With Telegram UI you means Web / Android / iOS client? None of them I think.

Please proceed to issue #36 as it handles this particular bug!
Thanks @Beyondem and @dcsan for your time and effort in this. See you there!


Defining new IMPLICIT cast without function from boolean to sys.bit and implementing it in various views

Description
Currently for a customer query we are are observing a performance degradation when query includes sys.indexes.is_primary_key = 1 in where clause. We reproduce it with large number of objects in database
1000 tables, 1000 index, 1000 PK, 10000 Columns and 2000 types. We found that there was an incorrect row estimation due to following filter leading to nested loop:
(CASE WHEN indisprimary THEN 1 ELSE 0 END)::"bit" = 1)
To improve the row estimation we removed all the problematic case statement and are using direct cast by defining new IMPLICIT cast without function from boolean to sys.bit. I have tested the same with the repro setup, and other DDL scripts, it always generates GOOD plan with accurate row estimation.
I have extended the solution to the following views and functions :
Views -
sys.indexes
sys.all_columns
sys.types
sys.systypes
sys.all_objects
sys.triggers
sys.all_views
sys.index_columns
sys.dm_exec_sessions
sys.all_sql_modules_internal

Function -
sys.columns_internal()
Signed-off-by: Tanya Gupta<EMAIL_ADDRESS>Issues Resolved
BABEL-5215
Test Scenarios Covered

Use case based -

Boundary conditions -

Arbitrary inputs -

Negative test cases -

Minor version upgrade tests -

Major version upgrade tests -

Performance tests -

Tooling impact -

Client tests -

Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 74.376%

Totals

Change from base Build<PHONE_NUMBER>5:
0.0%

Covered Lines:
44795

Relevant Lines:
60228

💛  - Coveralls


Update README.md

No longer a header only library
See https://github.com/zuhd-org/easyloggingpp

Could you please update the repo link as well? Thank you!


Enhance docker buster image

while installing RPi-Jukebox-RFID in docker I get a lot of
debconf: falling back to frontend: Readline
Messages.
Found a fix and implemented it:
https://github.com/phusion/baseimage-docker/issues/58#issuecomment-47995343
Linked issue: #715

Not sure if it is necessary for stretch. I will test and update it accordingly

ah ... too late.
it would be better to set
DEBIAN_FRONTEND=noninteractive

right in the RUN section you need it. That way you can still use the interactive frontend when you are manually testing with the dockerimage

Just make a new PR 😉

yeah, as soon as I got my hands on a running computer and the time to patch this up.
but if you beat me to it, I won't complain.


Add attribute for SubscriptionGroupConfig

Which Issue(s) This PR Fixes

Fixes #6889
Brief Description
Add attribute for SubscriptionGroupConfig like TopicConfig

How Did You Test This Change?
Unit test

Codecov Report

Merging #6891 (94f9896) into develop (91d8ee1) will decrease coverage by 0.05%.
The diff coverage is 17.17%.

@@              Coverage Diff              @@
##             develop    #6891      +/-   ##
=============================================
- Coverage      42.67%   42.63%   -0.05%
+ Complexity      9111     9107       -4
=============================================
  Files           1125     1127       +2
  Lines          79875    79910      +35
  Branches       10383    10387       +4
=============================================
- Hits           34087    34067      -20
- Misses         41520    41569      +49
- Partials        4268     4274       +6

Impacted Files
Coverage Δ

...e/rocketmq/common/SubscriptionGroupAttributes.java
0.00% <0.00%> (ø)

...pache/rocketmq/common/attribute/AttributeUtil.java
0.00% <0.00%> (ø)

...ols/command/consumer/UpdateSubGroupSubCommand.java
0.00% <0.00%> (ø)

...protocol/subscription/SubscriptionGroupConfig.java
50.44% <44.44%> (-0.04%)
:arrow_down:

.../broker/subscription/SubscriptionGroupManager.java
66.46% <80.00%> (+1.36%)
:arrow_up:

...ache/rocketmq/broker/topic/TopicConfigManager.java
54.49% <100.00%> (-4.10%)
:arrow_down:

... and 24 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Middleware to time and log delays between request and reponse (with code)

I wrote a middleware so that we can easily time delays between request and success/failure. I thought I could share if anyone is interested. It does not work if a second similar request is sent before a response to the first one is received. If you know how to deal with this, let me know.
Here is the output:

Dispatching A_REQUEST
Received A_SUCCESS after 500ms

Here is how to activate it for a single request via meta in a RSA action:
meta: { timer: [A_SUCCESS, A_FAILURE] } or meta: { timer: A_SUCCESS }
And here is the middleware:
// Holds a timestamp for each expected action
const timers = {}

const apiTimeLoggerMiddleware = (store) => (next) => (action) => {
  if (action.meta && action.meta.timer) {
    const expected = action.meta.timer
    if (typeof expected === 'string' || expected instanceof String) {
      timers[expected] = new Date().getTime()
      console.log(`Dispatching ${action.type}`)
    } else if (Array.isArray(expected)) {
      const timestamp = new Date().getTime()
      for (const item of expected) { timers[item] = timestamp }
      console.log(`Dispatching ${action.type}`)
    } else {
      console.error(`${action.type} has a \'timer\' meta with unexpected type of ${typeof expected}.`)
    }
  }

  if (action.type in timers) {
    console.log(`Received ${action.type} after ${new Date().getTime() - timers[action.type]}ms`)
  }

  return next(action)
}

export default apiTimeLoggerMiddleware

FWIW I really am grateful you posted this - it helped me write my own middleware to solve something so thanks for that.

This could also be a helpful guideline or recipe like #74 was written by @patrickgordon ?


Update Node.js version for Travis

Update Node.js version for Travis

Not that surprising, but it works on v6, yay :)

Should this change 5 to 6 rather than just adding 6?
It is really just a major semver version bump than a new release branch IMHO.
See also: NodeJS as part of 6.0.0 have renamed stable to current in nodejs/node/pull/6318

Yes, let's drop testing on Node.js 5. We're only interested in testing on current and LTS releases.

Node.js v5 will continue to be supported for the next two months in order to give developers currently using v5 time to transition to Node.js v6. - https://nodejs.org/en/blog/release/v6.0.0/

@sindresorhus while I doubt there'd be regressions that affect just v5, it seems sensible to keep testing until official support is withdrawn. Especially in the first few weeks when people won't necessarily have upgraded.

It is really just a major semver version bump than a new release branch IMHO.

@ntwb it's a major bump because of the breaking changes, which weren't previously in v5.


OAuth2 State Parameter Issue

Title: OAuth2 State Parameter Issue
Description:

I have updated my envoyproxy config from v1.16.0 v3alpha oauth2 filter to the example provided for v1.27.0 to have oauth flow for one of my mesh components -- however I see an issue where the state parameter has the wrong protocol.  Prior to upgrading the version, the state parameter would be https -- however after version upgrade to v1.27.0 it always is set to http.

I was looking to see if anyone had any insight or if there are any discrepancies in the oauth2 filter api code? Any help is greatly appreciated!

Not sure the exact change, but you could have a look at https://www.envoyproxy.io/docs/envoy/latest/version_history/version_history and https://github.com/envoyproxy/envoy/commits/main/source/extensions/filters/http/oauth2.
CC @derekargueta @mattklein123

I see in the commented section in the oauth2 filter code that the scheme is defaulted to https, but it doesn't seem to be the case though https://github.com/envoyproxy/envoy/blob/release/v1.27/source/extensions/filters/http/oauth2/filter.cc#L405
In order to fix the issue I was having, I had to add this scheme_header_transformation to overwrite it from http to https.


Changing themes shouldnt cause a cascade of actions to get dispatched

To reproduce change themes and notice that components get rerendered and redux actions  unrelated to theme changes get unnecessarily dispatched again


Accepting ghost text left "No suggestions" box and inaccessible lines

Type: Bug
I had a Copilot ghost text that I could not accept with tab. Tab would actually add characters into the document, pushing out the ghost text.
Once I hit Accept in the ghost text overlay, the "No suggestions" stayed around and the cursor can't be moved up/down anymore with keys, just left/right.

 I hit the tab-indents-ghosttext-but doesn't-accept before; but can't repro a second time afterwards.

No, special keybindings or settings in this area?

@jrieken nope, double-checked

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!

We closed this issue because we are unable to reproduce the problem with the steps you describe. Chances are we've already fixed your problem in a recent version of VS Code. If not, please ask us to reopen the issue and provide us with more detail. Our issue reporting guidelines might help you with that.
Happy Coding!


deps: Update dependencies with npm update

This PR is the result of running npm update that includes updates to 28 modules, removing ~80 insecure dependencies resolved from devDependencies and reducing some native module errors that occur from fsevents when running npm install.
I tested with npm run dev and it seems to work just as well as it did before npm update. No errors in the console (for me) and no build errors. Definitely worth doing more testing before merging, though!

Thanks Tierney!


[BUG] HardFault - Exception came from non-secure FW in thread mode

Describe the bug
Using v202212.00 TFM example
After setting the configuration, and generating key and cert onboard and resetting device, receive HardFault (directly after this step: https://github.com/FreeRTOS/iot-reference-stm32u5/blob/main/Getting_Started_Guide.md#reset-the-target-device)
Device ends up in unrecoverable boot loop.
Host

Host OS: MacOS
Version: Monterey 12.0.6

To Reproduce

Provision/configure device up to step "Reset the target device"
Device ends in unrecoverable boot loop

Expected behavior
Connect to AWS IoT Core
Device Logs
[INF] Starting bootloader
[WRN] This device was provisioned with dummy keys. This device is NOT SECURE
[INF] Primary image: magic=good, swap_type=0x1, copy_done=0x3, image_ok=0x1
[INF] Scratch: magic=unset, swap_type=0x1, copy_done=0x3, image_ok=0x3
[INF] Boot source: primary slot
[INF] Swap type: none
[INF] Primary image: magic=good, swap_type=0x1, copy_done=0x3, image_ok=0x1
[INF] Scratch: magic=unset, swap_type=0x1, copy_done=0x3, image_ok=0x3
[INF] Boot source: primary slot
[INF] Swap type: none
[INF] Bootloader chainload address offset: 0x3a000
[INF] Jumping to the first image slot
[WRN] This device was provisioned with dummy keys. This device is NOT SECURE
[Sec Thread] Secure image initializing!
TF-M isolation level is: 0x00000002
TF-M FP mode: Software
Booting TFM v1.5.0

<INF>        0 [None      ] HW Init Complete. (app_main.c:177)
<INF>        9 [OTAUpdate ] OTA Agent: Secure Image version 1.5.0, Non-secure Image Version: 1.0.0 (ota_update_task.c:1338)
<INF>        9 [OTAUpdate ] Waiting until MQTT Agent is connected. (ota_update_task.c:1367)
<INF>      120 [MQTTAgent ] Client Certificate: CN=stm32u5_001, SN:0x4991B79C5C0E92B0 (mbedtls_transport.c:335)
<INF>      120 [MQTTAgent ] Issuer: CN=stm32u5_001 (mbedtls_transport.c:336)
<INF>      120 [MQTTAgent ] Valid From: 1970-01-01, Expires: 2069-12-31 (mbedtls_transport.c:337)
> FATAL ERROR: HardFault
Here is some context for the exception:
    EXC_RETURN (LR): 0xFFFFFFBD
    Exception came from non-secure FW in thread mode.
    xPSR:    0x20000003
    MSP:     0x30022BF8
    PSP:     0x3002E6F8
    MSP_NS:  0x200BF3F0
    PSP_NS:  0x2005C5B8
    Exception frame at: 0x2005C5B8
        R0:   0x00000201
        R1:   0x00000000
        R2:   0x00000200
        R3:   0x00000201
        R12:  0x0000000A
        LR:   0x080EBCA9
        PC:   0x080EB0F2
        xPSR: 0x21000000
    CFSR:  0x00000000
    BFSR:  0x00000000
    BFAR:  Not Valid
    MMFSR: 0x00000000
    MMFAR: Not Valid
    UFSR:  0x00000000
    HFSR:  0x40000000
    SFSR:  0x00000048
    SFAR: 0x00000201
[INF] Starting bootloader
[WRN] This device was provisioned with dummy keys. This device is NOT SECURE
...<loop>

The hard fault is caused because I did not import the root certificate.
After running the following to import AmazonRootCA3.pem:
pki import cert root_ca_cert
-----BEGIN CERTIFICATE-----
MIIBtjCCAVugAwIBAgITBmyf1XSXNmY/Owua2eiedgPySjAKBggqhkjOPQQDAjA5
MQswCQYDVQQGEwJVUzEPMA0GA1UEChMGQW1hem9uMRkwFwYDVQQDExBBbWF6b24g
Um9vdCBDQSAzMB4XDTE1MDUyNjAwMDAwMFoXDTQwMDUyNjAwMDAwMFowOTELMAkG
A1UEBhMCVVMxDzANBgNVBAoTBkFtYXpvbjEZMBcGA1UEAxMQQW1hem9uIFJvb3Qg
Q0EgMzBZMBMGByqGSM49AgEGCCqGSM49AwEHA0IABCmXp8ZBf8ANm+gBG1bG8lKl
ui2yEujSLtf6ycXYqm0fc4E7O5hrOXwzpcVOho6AF2hiRVd9RFgdszflZwjrZt6j
QjBAMA8GA1UdEwEB/wQFMAMBAf8wDgYDVR0PAQH/BAQDAgGGMB0GA1UdDgQWBBSr
ttvXBp43rDCGB5Fwx5zEGbF4wDAKBggqhkjOPQQDAgNJADBGAiEA4IWSoxe3jfkr
BqWTrBqYaGFy+uGh0PsceGCmQ5nFuMQCIQCcAu/xlJyzlvnrxir4tiz+OpAUFteM
YyRIHN8wfdVoOw==
-----END CERTIFICATE-----

The example ran successfully.
These instructions should be added to the getting started guide. I also am not sure if HardFault is the expected behavior if the server CA cert is missing.

@dhwalters423
Thank you for reporting this along with your solution. I suspect a hard fault wasn't the intended behavior here. @paulbartell Can you take a look?

@dhwalters423 Thanks for the report. I am looking into the issue.

@paulbartell Has there been any update on this issue?


Only downloading a portion of a set

I can download sets, but not every song will download. Ex set is 62 songs long, only 50 downloaded

Dupe: https://github.com/Miserlou/SoundScrape/issues/24


write scripts to generate for benchmarks

Benchmarks are currently generated by hand.
There should be a reproducible way to generate them, for example:
./build.py benchs
This would generate a json file from bonnie++ which would in turn be used by benchs/benchmarks.html

bench target added to build.py


Angular pREST doesn't work in Angular 5.1.0

I have made some tests using angular-prest package in the newest version of Angular (5.1.0).
Some of the packages used in angular-prest are deprecated.
I want to know if you guys think it's interest that we update the package to be consistent with Angular changes.

feel free to send a PR, but always keep in mind ... maintain compatibility with the current API if possible

Done!
PR: https://github.com/prest/angular-prest/pull/3


gdal install for v0.10 branch

gdal needs to be installed for v0.10 branch
pure gdal pip install breaking

  FileNotFoundError: [Errno 2] No such file or directory: 'gdal-config'

  During handling of the above exception, another exception occurred:

  Traceback (most recent call last):
    File "/tmp/pip-install-00calwbp/gdal_746a34329f7340e9b7b4d8b405e8576a/setup.py", line 181, in get_gdal_config
      return fetch_config(option, gdal_config=self.gdal_config)
    File "/tmp/pip-install-00calwbp/gdal_746a34329f7340e9b7b4d8b405e8576a/setup.py", line 83, in fetch_config
      raise gdal_config_error(e)
  gdal_config_error: [Errno 2] No such file or directory: 'gdal-config'

  Could not find gdal-config. Make sure you have installed the GDAL native library and development headers.
  [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.

Ran into the same issue yesterday, it seems for pip you need to install the exact same version of gdal as you have installed on the system itself, which is kind of impossible to specify for all machines in the requirements. I guess we could install gdal either via conda or linux packages
?

Also I never understand why rasterio will work so easily on pip but gdal won't, when rio is based on gdal... :sob:

added info to readme to install gdal before with conda


order2 auth + redirects

TRACKED IN https://artsyproduct.atlassian.net/browse/PURCHASE-352

It seems like we have two log in pages an switch based on the sd.NEW_AUTH_MODAL. Are we still using the old /app/auth app?
cc @xtina-starr

Thanks for considering this @yuki24! I feel like there are so many paths to keep track of when looking at auth 😅

Nice test coverage! Just a few minor comments.

One additional consideration for this is analytics coverage like the intent for example. Perhaps that can be addressed in a separate PR.


duplicate default key in dns answers json

Got this while deploying a kubernetes stack:
{
    "default": {
        "recurse": [
            "<IP_ADDRESS>"
        ],
        "a": {
        	"rancher-metadata.": {"answer": ["<IP_ADDRESS>"]},
		"rancher-metadata.rancher.internal.": {"answer": ["<IP_ADDRESS>"]}
		}
    },
    "default": {
        "recurse": [
            "<IP_ADDRESS>"
        ],
        "a": {
        	"rancher-metadata.": {"answer": ["<IP_ADDRESS>"]},
		"rancher-metadata.rancher.internal.": {"answer": ["<IP_ADDRESS>"]},
		"master.": {"answer": ["<IP_ADDRESS>"]},
		"master.rancher.internal.": {"answer": ["<IP_ADDRESS>"]},
		"kubelet.": {"answer": ["<IP_ADDRESS>"]},
		"kubelet.rancher.internal.": {"answer": ["<IP_ADDRESS>"]},
		"proxy.": {"answer": ["<IP_ADDRESS>"]},
		"proxy.rancher.internal.": {"answer": ["<IP_ADDRESS>"]}
    	}

    },

    "<IP_ADDRESS>": {
        "recurse": [
            "<IP_ADDRESS>"
        ],
        "a": {
        	"rancher-metadata.": {"answer": ["<IP_ADDRESS>"]},
		"rancher-metadata.rancher.internal.": {"answer": ["<IP_ADDRESS>"]},
		"api-server.": {"answer": ["<IP_ADDRESS>"]},
		"api-server.rancher.internal.": {"answer": ["<IP_ADDRESS>"]}
    	}

    },

    "": {}
}

Tested with rancher server version - v0.47.0-rc2
Had few containers with network set to "host" mode in host.
There are no duplicate entries for "default" in dns answers json file.
Made sure that DNS resolution to rancher-metadata works fine from with in the host net containers when io.rancher.container.dns lable is set to "true".


Set Swift 5.8 as the minimum supported version

Set Swift 5.8 as the minimum supported version.
Removed CI job for Ubuntu 20.04.
Bumped swift-nio and swift-collections versions on the manifest.

Thanks @3a4oT  Just wondering - Are there any particular needs you had for upgrading this, or were you just cleaning it up?

@paulofaria Do you have any thoughts on this? I know you've been hesitant to update swift-tools versions in the past, but NIO is at 5.8 compatibility

Thanks @3a4oT Just wondering - Are there any particular needs you had for upgrading this, or were you just cleaning it up?

Hello, thanks for asking. The main driver was that we should support what Swift-NIO supports regarding the minimum required Swift tools. Swift itself doesn't support Ubuntu 20.04 anymore, so I dropped 5.4-5.6. I thought that bumping the version to 5.8 would be too aggressive, but I still believe it's the right thing to do :)

Hey @3a4oT, I think this is good to go if you just make the following changes:

Remove dependency changes in Package.swift
Run the formatter: docker run --rm -v ./:/repo ghcr.io/nicklockwood/swiftformat:latest /repo

Let me know if you need any help!

Let's follow SwiftNIO compatibility.

Hey @3a4oT, I think this is good to go if you just make the following changes:

Remove dependency changes in Package.swift
Run the formatter: docker run --rm -v ./:/repo ghcr.io/nicklockwood/swiftformat:latest /repo

Let me know if you need any help!

Thanks! I have applied your suggestions to the rebased commit.

Let's follow SwiftNIO compatibility.

Set swit tools version to 5.8

I'm okay merging this and dropping 5.8 after NIO does.

By the way, I think we should be explicit about our versioning support. The main question is do we phrase it as "the three latest released Swift versions" or do we phrase it as "we follow SwiftNIO support"? @NeedleInAJayStack

I agree. I think phrasing it as "we follow SwiftNIO support" makes sense at the moment while we're pretty reliant on NIO. If at some point we drop that dependency in favor of full Swift Concurrency we can reevaluate.
@3a4oT Could you add a Support section to the README between Encoding Results and Contributing that says:
This package supports Swift versions in [alignment with Swift NIO](https://github.com/apple/swift-nio?tab=readme-ov-file#swift-versions).

Otherwise, everything looks great! Thanks for contributing!!

Nice work @3a4oT! 🙂

I'm okay merging this and dropping 5.8 after NIO does.

By the way, I think we should be explicit about our versioning support. The main question is do we phrase it as "the three latest released Swift versions" or do we phrase it as "we follow SwiftNIO support"? @NeedleInAJayStack

I agree. I think phrasing it as "we follow SwiftNIO support" makes sense at the moment while we're pretty reliant on NIO. If at some point we drop that dependency in favor of full Swift Concurrency we can reevaluate.
@3a4oT Could you add a Support section to the README between Encoding Results and Contributing that says:
This package supports Swift versions in [alignment with Swift NIO](https://github.com/apple/swift-nio?tab=readme-ov-file#swift-versions).

Otherwise, everything looks great! Thanks for contributing!!

Done


Add another ItemKey variant for float BPM values

Right now, MP4 has its integer and float BPM atoms map to the integer BPM atom:
https://github.com/Serial-ATA/lofty-rs/blob/f4be1e3775e233847f1620fb4295302817f95341/src/tag/item.rs#L280
These are different values, and should not collide with each other. There should be an IntegerBpm and (FloatBpm | PreciseBpm) ItemKey variant.
I do not know yet if other tag formats have a specified float BPM item.

I suggest to introduce IntegerBpm for values that are known to be restricted (ID3v2 TBPM, MP4 tmpo). For all values with unknown precision Bpm should be used as before.
Reading is unambiguous, but writing could become challenging.

Lofty should not implement any semantics and instead leave it to the client: #335
If the client wants to ensure that at least one of the values is written it needs to set both and implement the desired conversion/rounding.


do not work with android 14

Thanks @SaurabhAlmighty
I will check

you can check with new android device api level above 13

Working fine @SaurabhAlmighty  on android 14 and 15

when can i check?


Color values can't be changed

local test = Color(255,255,255,255)
print(test)
test.r = 1
print(test)
print(test.r)

result:
255 255 255 255
255 255 255 255
1

iirc, rawset should be working as expected. I will do some testing later as I'd certainly prefer the elegance of a single line than a lot of checks.
Color[1] should work. And maybe Color["r"].


[Transforms] Fixes for ShorthandPropertyAssignments and exported namespaces

This change revises how JIT substitution works in the printer. Previously we had two hooks for substitution on TransformationContext: identifierSubstitution and expressionSubstitution. Now, we instead have a single hook, onSubstituteNode, which adds an additional isExpression parameter that will be provided a value indicating whether the node to be substituted is expected to be used as an expression.
This change allows us to easily add substitutions for a node that is neither an identifier nor an expression, such as a ShorthandPropertyAssignment.
Fixes #7862.
Fixes the following tests:

tests/cases/conformance/es6/destructuring/declarationsAndAssignments.ts
tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesWithModuleES6.ts
tests/cases/conformance/internalModules/moduleDeclarations/invalidInstantiatedModule.ts
tests/cases/compiler/giant.ts
tests/cases/compiler/privacyImportParseErrors.ts
tests/cases/compiler/shorthand-property-es6-amd.ts
tests/cases/compiler/shorthandPropertyAssignmentInES6Module.ts

:+1:


Coloring issue with cmder

While using cmder [http://cmder.net/] there's a styling issue that I can see while using react-native
Screenshots on a related issue here
https://github.com/cmderdev/cmder/issues/1568

I'm experiencing a colouring issue too, here are the screens:

CMDER

CMD
Many of the colours are changed, any fix for this?

@DentFuse Your issue is different. The "Orange" is red because CMDER doesn't seem to support more than 16 colors, so Chalk falls back to the closest supported color.

@sindresorhus Thank you for your quick reply :) Is this the reason for purple appearing blue and pink appearing purple too?

Yes

Nothing we can do here. This is affected entirely by how the terminal emulator (cmder in this case) consume escape sequences.


[AutoPR resources/resource-manager] Add on error deployment ARM

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/2560

Codecov Report

Merging #2084 into restapi_auto_resources/resource-manager will decrease coverage by <.01%.
The diff coverage is 0%.

@@                             Coverage Diff                             @@
##           restapi_auto_resources/resource-manager    #2084      +/-   ##
===========================================================================
- Coverage                                     53.1%    53.1%   -0.01%
===========================================================================
  Files                                         4774     4774
  Lines                                       119587   119602      +15
===========================================================================
  Hits                                         63510    63510
- Misses                                       56077    56092      +15

Impacted Files
Coverage Δ

...t/resource/resources/resource_management_client.py
66.66% <0%> (-10.11%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e28a6a0...56f20d3. Read the comment docs.

@AutorestCI rebase

Rebase done and pushed to the branch

(message created by the CI based on PR content)


:fire: How i aling text post and change the size?

Hello everyone,
how i change the text  size   of fonts
and on the content i like to  aling the text  to left
like
text-align: left;
were i add these?

i copy the css/main.css to root and add
main {
margin: auto;
padding: 25px;
flex: 1 0 auto;
max-width: 900px; /change the widh page/
font-size: 16px;  /change size to fonts/
}
but if i add
text-align: left;
all the content and page go to left and look awful


Removed external server request

Please  eliminate requests to external servers (eg. fonts.googleapis.com in CSS) and add the feature to local load.
Three reasons:
 - Security.
 - Privacy.
 - Speed.
Speed:
There is only performance improvement if the file is in the cache of the user, otherwise a new connection and a new DNS request is added. As the chances of another site using the same URL (eg. fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,600,700,300italic,400italic,600italic) are very low, performance will be less in most cases.
Privacy:
Least sent the user IP address and the referer, the external server could monitor user views. Also, if the external server send a cookie could be illegal under European law.
Security:
All problems linked server, your site will have, the higher the number of servers, the greater the probability of failure, with the possibility that future vulnerabilities could reach your site by it is procedure.

Hello @FranBar,
GoolgeFonts are somewhat difficult to implement locally. What you are suggesting is true. However, I can't change any of these settings currently because it will cause backwards compatibility issues. I think even in future versions, AdminLTE will use Google Fonts to provide an example of font customizability. At the same time, it will allow developers to easily change that setting by adding the link to the HTML files instead of the  CSS file. This way, a simple change to the SASS variables and the link from which the developer chooses to load their fonts will change the dependency on Google fonts to local or other resources.
Thanks for the suggestion!

If someone is interested:
http://stackoverflow.com/questions/8966740/how-to-host-google-web-fonts-on-my-own-server
http://www.localfont.com/
I will continue using AdminLTE is one of the best templates, although I have to manually make these changes.
Thank you.

eg. fonts.googleapis.com .... the greater the probability of failure ...

Lets hope it never happens. If google servers were compromised that would be quite a disaster and font serving would concern me the least :) You cant do much with CSS declarations.

I suggest this https://google-webfonts-helper.herokuapp.com/fonts/source-sans-pro?subsets=latin

Quite thin fonts are barely visible on mobile devises.

Please fix this in AdminLTE upstream, do not suggest changing the AdminLTE configuration to the user.
Requesting a resource from an external server by default is not allowed in a production environment!

Please reopen, this is not fixed!

Requesting a resource from an external server by default is not allowed in a production environment!

Not allowed by who? :) Take a look at what @almasaeed2010 wrote up there. I don't think there is great chance he will not implement your PR. I would not want those changes neither.

If this is not fixed I’m afraid we’ll have to fork AdminLTE.

@mirabilos I personally don't think there is anything wrong with you forking. That's the best approach so you can keep up with the changes by merging from upstream while having that one line removed.


Not returning the correct children for a newly defined component

I've tried to ask this question on stackoverflow, but no luck there. Hence, I'm submitting this as an issue.
Original question: https://stackoverflow.com/questions/47618989/enzyme-not-returning-the-correct-children-for-a-newly-defined-component
I'm expecting the following test to pass:
const Foo = ({ children }) => (

    {children}

);

describe('<Foo />', function () {
  it('always renders a
', function () {
    const foo = mount(
      <Foo>

      </Foo>
    );

    expect(foo.children().html()).to.equal('

');
  });
});

However, the above would give me:
AssertionError: expected '

' to equal '

'

Temporary fix
I found that I can simply chain two children() calls to make this work:
describe('<Foo />', function () {
  it('always renders a
', function () {
    const foo = mount(
      <Foo>

      </Foo>
    );

    expect(foo.children().children().html()).to.equal('

');
  });
});

Inconsistency
If I just use a normal div instead of the Foo component to wrap the inner div, I'll get the right result. That is,
describe('<Foo />', function () {
  it('always renders a
', function () {
    const foo = mount(

    );

    expect(foo.children().html()).to.equal('

');
  });
});

Furthermore, I found that foo.children().html() returns exactly the same string as foo.html(). Hence the following expect would pass:
expect(foo.html()).to.equal(foo.children().html());

Question
If that's the expected behaviour, why?
Is there a neater way to get the children than just to chain it twice?

This is intentional. When you mount a component, you get that component - you need .children() to get at the thing it renders.


Can't draw Chinese Text

When I want to draw chinese characters with function drawtext, output  unreadable code on the image, who could help me to fix the error? thanks!

hi, only a few characters are supported, i.e. ascii 0 to 55 or so...

I drew it by converting unicode to images after building a font dictionary using GNU Unifont.


Added namespace for cert-manager-operator

Added namespace for cert-manager-operator

Thanks for catching that, I missed the namespace when I ported it over from my config


fix negate/eql methods; add transpose method

some bugfix and minor improvement #9

I started implementing the transpose method on my side and had some issues with unit tests (and then didn't have the time to continue!). Issues were caused by the eql` method. You fixed everything!
Thanks a lot for this! :-)


Bump version to 1.3.1

Signed-off-by: Sayali Gaikawad<EMAIL_ADDRESS>Description
Bump version to 1.3.1
Issues Resolved
Part of https://github.com/opensearch-project/opensearch-build/issues/1805
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Hi @opensearch-project/k-nn  team, can someone take a look at failing CIs and let me know if anything needs to be changed?
Thanks!

@gaiksaya Can you update this  https://github.com/gaiksaya/k-NN-1/blob/1.3.1/.github/workflows/CI.yml#L38 to '1.3.1'
The

Hi @opensearch-project/k-nn team, can someone take a look at failing CIs and let me know if anything needs to be changed? Thanks!

@gaiksaya, I think the issue is with https://github.com/gaiksaya/k-NN-1/blob/1.3.1/.github/workflows/CI.yml#L38, which needs to be updated to 1.3.1. I'm testing it, the github action is running.
I guess it is copying both zip files opensearch-knn-<IP_ADDRESS>-SNAPSHOT.zip and opensearch-knn-<IP_ADDRESS>-SNAPSHOT.zip from distributions to BWC resources which is causing BWC Tests to fail.

Codecov Report

Merging #331 (bcc35c8) into 1.3 (20352a3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                1.3     #331   +/-   ##
=========================================
  Coverage     83.41%   83.41%
  Complexity      889      889
=========================================
  Files           127      127
  Lines          3841     3841
  Branches        361      361
=========================================
  Hits           3204     3204
  Misses          475      475
  Partials        162      162

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20352a3...bcc35c8. Read the comment docs.

@gaiksaya  Could we change CI as @peterzhuamazon did in #334 so that we wont have to update this for every patch?

@gaiksaya Could we change CI as @peterzhuamazon did in #334 so that we wont have to update this for every patch?

Removed. Looks like good approach.
Thanks!


Improved icons

We have currently used https://icons.polkadot.network/ .
Frankly, there are not so many options.

creating new custom icons may be the best option

Most of the icons have been updated recently. They are good now.
Improvements are welcome however ^^


add community section

Description
In the handbook, we have covered many topics in detail, but there is limited information on how we interact with the community. I believe we should add a separate community section in the handbook.
Related Issue(s)

Checklist

[ ] I have read the contribution guidelines
[ ] I have considered the performance impact of these changes
[ ] Suitable unit/system level tests have been added and they pass
[ ] Documentation has been updated

Deferring my review to @Hasmin-AC to free up some of my day.

Thanks, @gdziuba, for the review!

Thanks a lot for the PR @sumitshinde-84 !


Gov: add shank for spl governance program

Automatically generate an Anchor IDL by annotating the Account structs and Instruction enum with shank macros.

Blocked by: https://github.com/metaplex-foundation/shank/pull/32

Blocked on https://github.com/metaplex-foundation/solita/issues/71. Due to enum types like VoteThreshold, the SPL Governance IDL cannot be used by Anchor to deserialize its own accounts. Specifically this throws when initializing the BorshAccountsCoder object.
One other really nice thing that's missing is a metadata mapping for accounts, that allows Anchor / Solita to deserialize accounts using a prefixed enum to the accounts (rather than an Anchor Account Discriminator). Adding something like a {metadata: mapping: {}} to map between the prefix and the account type is the final step in using this IDL to deserialize governance accounts in the Explorer.
This would make the Anchor IDL spec more useable for SPL IDLs.

Adding something like a {metadata: mapping: {}} to map between the prefix and the account type is the final step in using this IDL to deserialize governance accounts in the Explorer.

Would love to understand more. Please file an issue in the solita repo with an example of what you need.
Alternatively you might be able to work around your issue using the idl hook (at least until we fix this properly).

To generate the Anchor idl: cargo install shank-cli && shank idl from inside governance/programs

Would the generated sdk work with any instance of spl-governance? In other words can programId be provided for api calls?

@SebastianBor yes shank can work for any program id deployment. I've removed the declare_id! statement.
Now the anchor idl must be generated with shank idl -p GovER5Lthms3bLBqWub97yVrMmEogzX7xNjdXpPPCVZw

FYI even with the declare_id! statement solita will only generate a default for the program id in the generated code that is overridable when calling instructions.
But overriding during the shanking process via CLI is a viable option as well to get the default to the desired value.

Thoughts on merging this @SebastianBor ?


Crop content of Python crash course

We have 1.5h time - the materials should fit in there.
Topics we should/cover: (from @thawn 's course in Paris)

Variable assignment

Working with strings & comments

Lists

For loops

If conditions

Functions:

Make Documentation and Simplification subheaders of custom functions
Add method functions (class.method()) as function call example to functions notebook

[x] modify functions notebook (@jo-mueller)

[x] grade notebooks in must do and optional as well as give entry points to different programming levels (@jo-mueller)

[x] Split presentation in two parts and link in Readme (@thawn )

@jo-mueller

[ ] there are still two PDF slide sets in your session, but there is only one ppt file in the owncloud folder. Is that correct?
[ ] There still are a lot of notebooks. As far as I remember, we agreed to delete the ones that are marked as optional (and link to the bioimage analysis notebooks instead

My part is done.

Hi @thawn ,
I originally just added a comment in the readme that pointed at the notebooks of interest, but I've now removed the others entirely and added a See also section in the respective readme. As for the slides - maybe something didn't sync properly? I see two pdfs in the repo and also in the teaching materials on cloudstore.

I see the following files in the repo:

and I see the following files in the cloud:

can you please make sure that python_basics.pdf (currently 13 pages) matches the slides (10_python_basics.ppt) you are going to show (currently 31 slides)?
I have also found some obsolete slides and a movie in my folder. I have removed those in pull request #28 . Maybe, you could merge that one, once you are sure that the pdfs in your python basics session are correct.
Cheers,
Till

Also, we should make sure that the dates and authors on the ppt slides and the pdfs are correct

@thawn ah, I see. Thanks for spotting it! I removed the old data_structures.pdf and updated the pdf in the repo.


OSC-Platform-020: Download rest of ESG documents from S&P Global

There are around 32000 documents to be downloaded in addition to the existing 8500. For now we shall only do a SFTP from the existing S&P Global repository:
URL: sftp://edx.spglobal.com/Products/ESGFilings
Port: 22
ESGD5020
027p3Y+0$
Likely this will need to be automated with a daily process in the future. Note: Dependency on S&P adding the remaining documents in the SFTP folder.

new count is 75K (we will receive updated versions of the original ~8500).  Related LF Jira:  https://jira.linuxfoundation.org/plugins/servlet/theme/portal/2/IT-24329

Updated info for S&P Global docs:
URL: sftp://edx.spglobal.com/Products/ESGFilings
Port: 22
ESGD5020
27wr0N$,i

the ~75K reports are now available
Here is the credential which you can use to access the documents from sftp path, attaching along here excel file that contains the document definition. I placed all the files in one folder as multiple folder creation was not allowing under same account, so you can get all the docs from one folder.

HostURL: sftp://edx.spglobal.com/Products/ /Products/OSC-ESG
UserName: ESGD5020
Password: 27wr0N$,i
Port: 22

@redmikhail will investigate and see where best to put in S3 bucket.  what is lifecycle process for these files?

ingest from S&P bucket [write a notebook to call osc-ingest tools]
load into pachyderm and version it [@caldeirav are we using pachyderm or DVC?]
load into iceberg tables on CL2
@HeatherAck to follow up with @JeremyGohBNP to determine ingestion pipeline process.

Eric can do this download  using lfdp which can set remotes for download and upload. Running locally on Erics machine.  LFTP has a smart funtcion which moves new and changed . Can move this to a container .
Mikhail would like to see this in a repeatable fashion , move it to AWS as a virtual machine or container.
Like to have it spawned and run on a shared instance.
Eric is working on getting this in a reproducable and predictable manner for Azure . Take what he has done and apply to AWS but need to know what folder to put it in.

Working for Azure -
Eric needs to find a way to automate it.  Need a way to containerize this .   Eric needs to know the folder in AWS .   @redmikhail to provide the folder location

@eoriorda It should go to s3://redhat-osc-physical-landing-647521352890/SPGI_ESG_Filings/ together with the initial drop of ESG documents unless I am misreading what it is for

eric b. pending credentials from @redmikhail - will move files; test automation using GitHub actions (sync operation, copy over new files, job to run at X interval - containerized but manually triggered)

@MightyNerdEric can you please let us know if this is complete?

@rynofinn to work with @MightyNerdEric to resolve credential issues

Current status: 16.7k files have been transferred of 78k. The first week of this transfer has been very inefficient, but it's now settled into a constant pace. At the current transfer rate, it will take another week to complete.
However, now that I full access to the AWS account, I can properly setup a direct transfer (rather than using my own computer as a midpoint), so that will hopefully increase the throughput. But I can't guarantee that; given how little of my own total bandwidth is being used, it's entirely possible that we're already seeing the maximum transfer rate.

70870 as of 3-Oct.


Upcoming next release - 2.12.0

I'm going to release next version 2.12.0 in a few days.
Please help with:

review existing issues - may be some is easy to fix and there is willing for it
review existing PR - may be some can be merged

Changes in upcoming release:
https://github.com/mojohaus/versions-maven-plugin/compare/versions-maven-plugin-2.11.0...refs/heads/master

Please review the PR for #648

@ajarmoniuk please let me know when I can do release.
Do you want add something more?

I've just begun working on #213, but I think it could take a couple of days (one or two).

I'm almost done with #231 which I consider a bug (I don't think it was intentional to allow downgrading), but I've added a feature to allow it and fixed the behaviour somehow (it did not work at all for ranges).

I'm very glad to next release, we have many bug fixes and improvements.
Of course I want not to wait to resolve all opened issues.
So next release will be at 5 of September.
Unless you discover some of critical issue.
Big thanks to @ajarmoniuk

Done.


unparser does not unparse correctly

If you krun the program closed-variable-capture.lambda, which is (lambda z.(z z)) (lambda x.lambda y.(x y)), with our very first language definition in the tutorial, 1_k/1_lambda/lesson_1, the result is lambda z . (z z) lambda x . lambda y . (x y).  This is incorrect; for example, it does not even parse correctly.  @laurayuwen, this is something you will have to soon start looking into.  (@dwightguth, I asked @laurayuwen to look into unparsing as a potential research topic for her)

so, I don't know offhand exaghry why this is happening, because I am pretty sure the naive unparsing algorithm used by --output pretty should be able to handle at least this simple of a case, but I will comment that in general --output pretty is not intended to be sound, it's intended to run with as fast an asymptotic running time as possible (I haven't done the math but I think it's n log n). I ran this example with --output sound, which is intended to be the full NP-hard unparsing algorithm, and it generates an unambiguously parseable result.
@laurayuwen you should investigate why AddBracketsFilter is determining that it does not need a bracket around lambda z . (z z). I suspect it relates to the recent modifications I made to that class to make it run in linear time, which must not have handled a case correctly. See if you can find a way to fix the algorithm without getting rid of the linear time requirement.


[Install issue]: ChromaDB Orjson Issue

What happened?
Installing ChromaDB on a Google Colab notebook like I have done many times before, and ran into this error.
Not sure what caused it, I tried uninstalling and installing again, to no avail.
Versions
chromadb-0.5.5
Relevant log output
Collecting chromadb
  Using cached chromadb-0.5.5-py3-none-any.whl.metadata (6.8 kB)
Requirement already satisfied: build>=1.0.3 in /usr/local/lib/python3.10/dist-packages (from chromadb) (1.2.1)
Requirement already satisfied: pydantic>=1.9 in /usr/local/lib/python3.10/dist-packages (from chromadb) (2.8.2)
Collecting chroma-hnswlib==0.7.6 (from chromadb)
  Using cached chroma_hnswlib-0.7.6-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (252 bytes)
Collecting fastapi>=0.95.2 (from chromadb)
  Using cached fastapi-0.112.0-py3-none-any.whl.metadata (27 kB)
Collecting uvicorn>=0.18.3 (from uvicorn[standard]>=0.18.3->chromadb)
  Using cached uvicorn-0.30.5-py3-none-any.whl.metadata (6.6 kB)
Requirement already satisfied: numpy<2.0.0,>=1.22.5 in /usr/local/lib/python3.10/dist-packages (from chromadb) (1.26.4)
Collecting posthog>=2.4.0 (from chromadb)
  Using cached posthog-3.5.0-py2.py3-none-any.whl.metadata (2.0 kB)
Requirement already satisfied: typing-extensions>=4.5.0 in /usr/local/lib/python3.10/dist-packages (from chromadb) (4.12.2)
Collecting onnxruntime>=1.14.1 (from chromadb)
  Using cached onnxruntime-1.18.1-cp310-cp310-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl.metadata (4.3 kB)
Collecting opentelemetry-api>=1.2.0 (from chromadb)
  Using cached opentelemetry_api-1.26.0-py3-none-any.whl.metadata (1.4 kB)
Collecting opentelemetry-exporter-otlp-proto-grpc>=1.2.0 (from chromadb)
  Using cached opentelemetry_exporter_otlp_proto_grpc-1.26.0-py3-none-any.whl.metadata (2.3 kB)
Collecting opentelemetry-instrumentation-fastapi>=0.41b0 (from chromadb)
  Using cached opentelemetry_instrumentation_fastapi-0.47b0-py3-none-any.whl.metadata (2.1 kB)
Collecting opentelemetry-sdk>=1.2.0 (from chromadb)
  Using cached opentelemetry_sdk-1.26.0-py3-none-any.whl.metadata (1.5 kB)
Requirement already satisfied: tokenizers>=0.13.2 in /usr/local/lib/python3.10/dist-packages (from chromadb) (0.19.1)
Collecting pypika>=0.48.9 (from chromadb)
  Using cached PyPika-0.48.9.tar.gz (67 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Requirement already satisfied: tqdm>=4.65.0 in /usr/local/lib/python3.10/dist-packages (from chromadb) (4.66.5)
Collecting overrides>=7.3.1 (from chromadb)
  Using cached overrides-7.7.0-py3-none-any.whl.metadata (5.8 kB)
Requirement already satisfied: importlib-resources in /usr/local/lib/python3.10/dist-packages (from chromadb) (6.4.0)
Requirement already satisfied: grpcio>=1.58.0 in /usr/local/lib/python3.10/dist-packages (from chromadb) (1.64.1)
Collecting bcrypt>=4.0.1 (from chromadb)
  Using cached bcrypt-4.2.0-cp39-abi3-manylinux_2_28_x86_64.whl.metadata (9.6 kB)
Requirement already satisfied: typer>=0.9.0 in /usr/local/lib/python3.10/dist-packages (from chromadb) (0.12.3)
Collecting kubernetes>=28.1.0 (from chromadb)
  Using cached kubernetes-30.1.0-py2.py3-none-any.whl.metadata (1.5 kB)
Requirement already satisfied: tenacity>=8.2.3 in /usr/local/lib/python3.10/dist-packages (from chromadb) (9.0.0)
Requirement already satisfied: PyYAML>=6.0.0 in /usr/local/lib/python3.10/dist-packages (from chromadb) (6.0.1)
Collecting mmh3>=4.0.1 (from chromadb)
  Using cached mmh3-4.1.0-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (13 kB)
Collecting orjson>=3.9.12 (from chromadb)
  Using cached orjson-3.10.7.tar.gz (5.1 MB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  error: subprocess-exited-with-error

  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> See above for output.

  note: This error originates from a subprocess, and is likely not a problem with pip.
  Preparing metadata (pyproject.toml) ... error
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

@95, this is interesting. I've just tried to install the latest Chroma (0.5.5):
%pip install chromadb

on a clean new Colab notebook, and it did not raise any error. Can you try doing the same? I'd suspect some cached dependencies may be causing this issue.

this is the same error as #2648, seems that the project has released missing wheels now with https://github.com/ijl/orjson/issues/509. Can you retest?

Closing this as it is stale. Please let me know if it still persists and Im happy to reopen it!


Is it possible to use the other symbols like () instead of ` ?

Is it possible to use the other symbols like () instead of ` ?

Wouldn't that break the use of template literals for props and other stuff?

Why would you need it? Strictly speaking, you can always replace template literal with an equivalent function call, but you will loose magic of template literals.
styled.div`color: red;` === styled.div([ 'color: red;' ])

styled.div`color: ${someColor};` === styled.div([ 'color: ', ';' ], someColor)

@vdanchenkov I got it, thx!

See here for an explanation of why exactly we use tagged template literals: mxstbr.blog/2016/11/styled-components-magic-explained


GDScript: Report property type errors

Before, inline getters and setters were of type SuiteNode which were not checked by the gdscript analyzer. resolve_class_body only checked FunctionNode members.
To fix #53102 I transformed those inline getters and setters into FunctionNodes. Please check the example code provided in the issue.
Additionally, I also added some missing checks to old-style getset-properties:

Getter must return a value and have zero parameters. If the property has a type, the returned type of the getter must be a variant or a compatible type.
Setter must have a single parameter. If the property has a type, the parameter must be a variant or a compatible type.
If the property is untyped, either the getter return type or the setter parameter must be a variant or their type must be compatible.

One other thing: if you could add integration tests for those cases it would be great. See the documentation for info about how those work.

@vnen Thanks for your detailed review! Things I did:

Fixed the things in your comments exactly as you told me to. See Commit 649849c

Added some test cases for properties. It's not a simple task, because there are so many things which could be tested. Adding tests for all different kinds of errors is cumbersome, because each test can only check one error. Added some simple tests in commit 1fdded2

I rebased those 3 commits to master without squashing. Hope that's what you expected.


Jwoo/ios custom element update

Resolves the issue #2220
it will break shared model unit test (I need to update the test).

replaced by #2325


Pcons are getting refilled even though they're disabled in pcon window

This means that I ended up with Pcons on storage characters and other characters that are not supposed to have them.

Would be great if you could disable this Low on pcon message. I've set my thresholds to 250 to always have a stack of each pcon and my chat is spammed with this message every time I refill.

@UltraPower31 Are you saying you get the message despite having enough items in storage to refill up to the desired threshold?
I too have all thresholds set to 250 and the message only displays when I don't have enough stock in my Xunlai Chest.
If the issue persists in 5.7 please open a separate issue, as this one was fixed in 5.7 (92be443).


Add sibling GltfWriter library into cesium-native

This is a preliminary draft PR, but I wanted to open it asap to give cesium-native people the chance to point out anything especially egregious or misaligned with the philosophy of the cesium-native libraries. The goal of this library is to provide a general purpose GLTF writer for the Cesium ecosystem (primarily the tilers) that accepts a constructed CesiumGltf::Model object and serializes that to a glTF or GLB std::vector<std::uint8_t> (without the proliferation of tinygltf:XXX types throughout our codebases).
This PR is still in an alpha state, but has support for writing glTFs with embedded uris and glbs without references to external binary content. Self-contained glbs are of primary concern for the terrain tiler and we plan to have full support for those first (i.e we won't wait for the library to support every possible configuration of serialized glTF before merging this).
Design Decisions

I started initially by mimicking the JavaScript functions that generate Cpp code for parsing, but I realized that it would actually be faster to just use https://kakoune.org/ and https://neovim.io/ macros to generate the writing classes as I go. The primary benefit of this is that the (semi-automatically) generated serialization code is very easy to read and debug, but tightly coupled to the rapidjson API. I should clarify that only the PRIVATE api right now is coupled to rapidjson, if simdjson added a sax writing API tomorrow we could change the classes around without changing the public API at all. I don't know how much of a real issue this is, as rapidjson appears to be the fastest C++ library in existence for serialization of structs to a json string.
I'm using magic_enum in a few places to automatically convert enums to strings in a few places. I'm not attached to this library at all, but just wanted something that would let me automatically convert the CesiumGltf enums to strings without adding additional code to generate these functions in the JS code.
I added the JsonObjectWriter.cpp class to deal with the potential extras object that can be placed inside almost any glTF object. It's a simple recursive implementation but I'm willing to change it to iterative if we're worried about pathological inputs causing stack overflow errors. I've never seen an extras objects with more than 4-5 layers of nesting so I decided not to optimize this part yet.
We are planning on writing a lot of glb assets as quickly as possible, so I was considering making the writing API move only to minimize allocations. E.g when you want to take your CesiumGltf::Model and serialize it to a glTF or glb byte array the CesiumGltf::Model becomes unusable to reduce redundant allocations. I plan on adding move support no matter what, but do people think it's excessive to mandate moving in our API to force people to use the more performant path?

Upcoming Builder
The last thing we want to do is include our builder pattern from the terrain tiler in this library (to make the construction of a CesiumGltf::Model object less verbose, e.g:
  auto watermaskGltfImage = GltfImageBuilder()
      .name("watermask")
      .imageType(GltfImageType::PNG)
      .buffer(std::move(asPNGByteArray), GL_UNSIGNED_BYTE)
      .filter(GL_NEAREST, GL_NEAREST)
      .dimensions(waterMask.MaskWidth, waterMask.MaskHeight)
      .wrapST(GL_CLAMP_TO_EDGE, GL_CLAMP_TO_EDGE)
      .toImage();

  CesiumGltf::Model model = GltfBuilder()
      .addVertexBuffer(VertexAttribute("POSITION", positions, GL_FLOAT, GltfType::VEC3))
      .addVertexBuffer(VertexAttribute("NORMAL", normals, GL_FLOAT, GltfType::VEC3))
      .addIndices(Indices(indices, GL_UNSIGNED_SHORT))
      .addImage(std::move(watermaskGltfImage))
      .buildInterleaved()

   std::vector<std::uint8_t> gltfArray = CesiumGltf::writeModelToByteArray(std::move(model), WriteFlags::glTF | WriteFlags::PrettyPrint);

   // write gltfArray to disk

We started this in the terrain tiler, I'm currently porting it to CesiumNative and swapping all the uses of raw OpenGL enums to the corresponding CesiumGltf enums. (Haven't pushed any of these commits yet).
Extensions
@IanLilleyT and I had a discussion about how to handle extensions this morning. Ideally we would want to be able to do something like
 GltfBuilder()
    .addVertexAttribute(...)
    .addVertexAttribute(...)
    .addExtension([](CesiumGltf::Model& model) {
      model.extensionsUsed.emplace_back("blah");
        // add whatever we need for this extension
     })
     .buildConcatenated();

The problem with this arises when we want to serialize the extension to a json string. If extensions are implemented like KHR_draco_mesh_compressionJsonHandler where the attributes are hardcoded as attributes on structs, it makes it impossible for the GltfWriter to serialize arbitrary extensions / user provided extensions. We think that making it more like the JsonValue::Object type would solve this issue. In other words we don't think cesium-native's writer should be responsible for being aware of all extensions in existence, and that tilers should be able to plug in their own tiler specific extensions as necessary.

@jtorresfabra Thanks for review, feedback addressed (with exception of @baothientran 's comment on the exception handling in SkirtMeshMetadata, unsure what I should do for that).
Also merged with origin/main

Before merging add CesiumGltfWriter to https://github.com/CesiumGS/cesium-native#card_file_boxlibraries-overview

Before merging add CesiumGltfWriter to https://github.com/CesiumGS/cesium-native#card_file_boxlibraries-overview

https://github.com/CesiumGS/cesium-native/pull/210 Created a PR for that.

Thank you @baothientran !

@kring I added an issue addressing your concerns / discussing what we'll change going forward: https://github.com/CesiumGS/cesium-native/issues/213


fix typo in proxy auth (stream/ws_client.py)

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix below CI error on kuberenets-client/python PR 1567
./kubernetes/base/stream/ws_client.py:453:31: F821 undefined name 'coniguration'

Which issue(s) this PR fixes:

Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @yliaog


Support Alarm to feishu

fix #6192
Support Alarm to feishu

Please submit the related documentation about the APIs.

Please submit the related documentation about the APIs.

The document of alarm has not been updated yet.

The document of alarm has not been updated yet.

Which document？

Which document？

You are contributing an alarm related feature, but don't know where is alarm document?

You are contributing an alarm related feature, but don't know where is alarm document?

en/setup/backend/backend-alarm.md ？

en/setup/backend/backend-alarm.md ？

We also need the Feishu's documentation about its HTTP service. Could you share it too?

We also need the Feishu's documentation about its HTTP service. Could you share it too?

@JaredTan95 Could you review and test this locally?

@JaredTan95 Could you review and test this locally?

We also need the Feishu's documentation about its HTTP service. Could you share it too?

https://open.feishu.cn/document/ukTMukTMukTM/ucTM5YjL3ETO24yNxkjN#756b882f
Should I add this to the  alarm document(backend-alarm.md)?

We also need the Feishu's documentation about its HTTP service. Could you share it too?

https://open.feishu.cn/document/ukTMukTMukTM/ucTM5YjL3ETO24yNxkjN#756b882f
Should I add this to the  alarm document(backend-alarm.md)?

Should I add this to the alarm document(backend-alarm.md)?

We don't need it, I just want it be clear in the PR. And does it have open and testable interface we could use? All other notifications have. Otherwise, I can't tell how the reviewer could check whether the feature is good.

And please resolve the conflicting with the master branch.

Should I add this to the alarm document(backend-alarm.md)?

We don't need it, I just want it be clear in the PR. And does it have open and testable interface we could use? All other notifications have. Otherwise, I can't tell how the reviewer could check whether the feature is good.

And please resolve the conflicting with the master branch.

alarm-settings.yml in the bootstrap module should be updated too.

updated

alarm-settings.yml in the bootstrap module should be updated too.

updated

@HendSame Any idea about how we could test?

@HendSame Any idea about how we could test?

@HendSame Any idea about how we could test?

Reference document  https://www.feishu.cn/hc/zh-cn/articles/360024984973

@HendSame Any idea about how we could test?

Reference document  https://www.feishu.cn/hc/zh-cn/articles/360024984973

@HendSame Please follow the comment and update your branch. We can't update it, as you don't open the write access to the upstream for your fork repo.

@HendSame Please follow the comment and update your branch. We can't update it, as you don't open the write access to the upstream for your fork repo.

Note this This branch is out-of-date with the base branch. We can't merge unless you sync with the master branch.

Note this This branch is out-of-date with the base branch. We can't merge unless you sync with the master branch.


Uniform node dimensions

Back in the Java implementation of our algorithm, we had a flag to signify whether or not node dimensions are uniform. If the user set this flag, we would take centers of simple nodes into account and not perform the costly clipping point calculations. Could you please investigate if we lost this during the port to JavaScript?

I exposed uniformNodeDimensions option d5008a0293b6018ca43a8c7bc89ace897b6d540e


[Cosmos] Throughput APIs

This adds support for throughput-related APIs to the Cosmos SDK for Rust, including:

Specifying throughput offers when creating databases and containers, via a field on the CreateDatabaseOptions/CreateContainerOptions type.
Reading throughput offers for a database or container, via the ::read_throughput method on ContainerClient and DatabaseClient
Replacing throughput on a database or container, via the ::replace_throughput method on ContainerClient and DatabaseClient

These APIs are largely modelled on similar ones we have in the Go SDK, but I've tried to make sure they stayed "Rusty" and am happy to deviate from those if things look off.
The Go SDK created a separate "OffersClient" that was internal, to support reading/replacing offers, since they're a separate resource and the logic to read/replace them is similar for both databases and containers. Instead of that, I've added helper functions to our internal CosmosPipeline type. I think that approach works well here.
Offers don't quite follow the standard pattern for generating the "resource link" for signing requests when authenticating with a key. Specifically, they require that the link be "only the _rid of the offer you wish to retrieve". So I've added some special-casing to ResourceLink to handle that. Part of the goal of refactoring to use a custom ResourceLink type was to allow exactly this kind of special-casing, in a clear way.

@microsoft-github-policy-service rerun


Increase max range

I was noticing that there is a hard cut at 50M, 50000 unreal units for Acoustics.  Is there a way to adjust this? I am working with some bends around a corner and it just ends up being 52m away.  I can always adjust things in the level to make everything work, but if there's a way to adjust this to a max/min distance I would be interested in finding out where it is.
Working in UE 5.0.   Looking to test in 5.1 when the new marketplace plugin releases.

In the Probes tab, under Advanced Parameters, you can adjust the Simulation Region to achieve this. You will need to redo the Probes calculation and bake after you change this.

I have tried this but it does not increase the distance to which the sound emitter stops working with acoustics.  After the 5000 unit mark it defaults back to normal Attenuation.

I've tried dramatically increasing the simulation region to 4x the default amount, but it still stops at 5000 units

I have baked it again after recalculating.

Update.  I didn't know there was a limit on the debug draw line.  After 5,000 units it stops drawing and its in the plugin source.

Yes it is!  I can't wait for Epic to get the update approved and test this out and see if it works on the quest.


about rev_rec_plus

If I set Model = 'rev_rec_plus'in trai.py (line 64), the results is not good as  Model = 'rev_rec'. Do I need to modify other parameters, like pre_task = 'rev_rec' in trai.py (line 65)？ Thanks a lot.

Main Reasons:

In our paper, all experiments are repeated for multiple times on a specific setting (a different dataset or model setting) and the average performance is reported.
Since we do NOT explicitly select or set a same random seed for our experiments, the results in every training may have some slight randomness, i.e., the parameters in neural networks are randomly initialized at the beginning.  Despite this fact, according to the extensive experimental results, the setting 'rev_rec_plus' is better in average than 'rev_rec' on three datasets, namely BIWI, KS20, and KGBD datasets.

Solutions:

Considering that results of 'rev_rec_plus' is quite close to 'rev_rec' on BIWI and IAS-Lab datasets, you can simply run the same setting for several times to compare their average performance.
You can also change the hyper-parameters provided in the source codes, such as temperature (t), epochs, rnn_size to get further potential improvement (note that the default parameters are not necessarily the optimal),
You can directly download the best models provided in the repository. They can reproduce the same experimental results in our paper.

Thank you for your attention.

Main Reasons:

In our paper, all experiments are repeated for multiple times on a specific setting (a different dataset or model setting) and the average performance is reported.
Since we do NOT explicitly select or set a same random seed for our experiments, the results in every training may have some slight randomness, i.e., the parameters in neural networks are randomly initialized at the beginning.  Despite this fact, according to the extensive experimental results, the setting 'rev_rec_plus' is better in average than 'rev_rec' on three datasets, namely BIWI, KS20, and KGBD datasets.

Solutions:

Considering that results of 'rev_rec_plus' is quite close to 'rev_rec' on BIWI and IAS-Lab datasets, you can simply run the same setting for several times to compare their average performance.
You can also change the hyper-parameters provided in the source codes, such as temperature (t), epochs, rnn_size to get further potential improvement (note that the default parameters are not necessarily the optimal),
You can directly download the best models provided in the repository. They can reproduce the same experimental results in our paper.

Thank you for your attention.


Fix AssetLoader to load name of node without mesh

Currently AssetLoader only load name with nodes contains mesh. The hotfix load every node's name no matter the mesh. It'll set the node name "node" if name not found.
Test
test with mac and gltf_viewer devtool

Hi @iamlkj , this PR is almost ready, do you think you can make the suggested change to AssetConfiguration to allow for a configurable fallback name?

Sorry, too busy recently. Just push a new revision with default name in config please check.

I've made some changes and squashed the commits, I will merge this PR after the presubmits pass.

I've made some changes and squashed the commits, I will merge this PR after the presubmits pass.

Thanks for helping


Automated Package Upgrade

:tada: This PR is included in version 1.3.39 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Containerizing Reddison client for Tomcat

I am thinking of the possibility of separating out the Reddison client from Tomcat container. Is there any way to do that? or do I always have to use RedissonSessionManager with Tomcat? I am using AWS Elasticache Redis. Thanks.
Redisson version - 3.10

Is there a way to implement Tomcat Session Manager out of Tomcat?

Came across something like this CloudMembershipServiceMBean & wondering whether I can leverage this for Reddison Client? it will good if Reddison Pro have some thing like this.
https://tomcat.apache.org/tomcat-9.0-doc/api/index.html?org/apache/catalina/tribes/membership/cloud/CloudMembershipServiceMBean.html

Correct me if I wrong, tribes nodes are completely independent and store state on their own. While all Redisson based Managers use Redis as common storage. Could you explain what benefits will you get with channel group implemented by Redisson?

I was initially thinking of de-coupling the logic to connect to Redis. However, as you have said it seems not necessary as we can define it in context.xml and even though it is tightly coupled it is the way how Tomcat works.

Also if Reddison client is leveraging the context.xml how it will support features like passing a Auth Password and In-Transit Encryption (TLS) ?

through config defined in yaml or json format


Get the last sequence of return_sequences=True

I have a sequence-to-sequence model where the encoder LSTM has return_sequences=True. I want to get only the last sequence of the returned sequences. How can I do ?
PS I know with return_sequences=False I'll have the last sequence but I can't do this.

`from keras.models import Model
from keras.layers import Input
from keras.layers import LSTM, RepeatVector
import numpy as np
train_x = np.array([1.0, 1.0, 1.0]).reshape((1, 3, 1))
train_y = np.asarray([[1, 1, 1]])
inputs1 = Input(shape=(3, 1))
seqs = LSTM(1, return_sequences=False)(inputs1)
x = RepeatVector(3)(seqs)
x = LSTM(3)(x)
model1 = Model(inputs=inputs1, outputs=x)
model1.compile(optimizer='adam', loss='mean_squared_error')
model2 = Model(inputs=inputs1, outputs=seqs) ## the output is the encoder part
model2.compile(optimizer='adam', loss='mean_squared_error')
model1.fit(train_x, train_y)
model2.layers[0].set_weights(model1.layers[0].get_weights()) #set the weights from the trained model
print(model2.predict(train_x))`
I think this is what you want. The the above sample code is a sequence to sequence model that takes input of 3 Dims and the output is 3 Dims too.
The first model 'model1' fits the data and update the weights in the training process.
After training the model, we initialize another model by the encoder part of the 'model1' and get the output sequence from using the prediction function.

You can use functional model and Lambda layer like this:
last_timestep = Lambda(lambda x: x[:, -1, :])(lstm_layer)


I removed my account from authenticator app and now I am trying to login it's asking to approve from authenticator or enter passcode but I cannot. Is there any other option to login?

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ee6ac70d-5853-6a3a-0964-23b46910b4c4
Version Independent ID: a5beda87-9845-8807-6221-7fdc64079587
Content: Passwordless sign-in with the Microsoft Authenticator app - Azure Active Directory
Content Source: articles/active-directory/authentication/howto-authentication-passwordless-phone.md
Service: active-directory
Sub-service: authentication
GitHub Login: @Justinha
Microsoft Alias: justinha

Hello @thesuraj2011 , thank you for reaching out to us. Can you pls tell what is the ask here?

Hello!
Just checking to see if you have had a chance to see the previous response. Kindly let us know if it answers your question and if you need further assistance on this issue.

Can you try deleting the Authenticator method?:

And, try re-installing/re-setting the Authenticator app by following these  steps?

Hello!
Just checking to see if you have had a chance to see the previous response. Kindly let us know if it answers your question and if you need further assistance on this issue.

after deleting its working but now not able to see notification in mobile.
On Wed, Jul 28, 2021 at 11:04 AM HarshitaSingh-MSFT <
@.***> wrote:

Hello!
Just checking to see if you have had a chance to see the previous
response. Kindly let us know if it answers your question and if you need
further assistance on this issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/78789#issuecomment-888023556,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APPEUUFD7W6FLVTXNKYETUDTZ6JG3ANCNFSM5A5IZDPA
.

Try Change your default security info method.

Hello!
Just checking to see if you have had a chance to see the previous response. Kindly let us know if it answers your question and if you need further assistance on this issue.

Hello!
Just checking to see if you have had a chance to see the previous response. Kindly let us know if it answers your question and if you need further assistance on this issue.

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


timeout

I want to interval 2 seconds before cards adding  but set timeout  function not proper working in my device. in computer browser the code is running correctly but in android device it stoped when interval is true and donot back to the game start view.....plz help me>??????????
code is here********************************
//when card is empty*********************************************
if (this.cards.length == 0) {
vm.goToAddCard();
}
goToAddCard() {
var vm = this;
this.game_interval = true;
this.game_start = false;
setTimeout(() => {
alert("Done");
vm.game_interval = false;
vm.game_start = true;
console.log("game_start==", vm.game_start);
console.log("game_interval==", vm.game_interval);
vm.addNewCards();
}, 2000);
//html code is  here********************

.........so on

Hello, Not sure if this is still an issue, can you please create a plunkr to demo this?


Valve is no longer working with tomcat 8.5.50

Upgrading to tomcat 8.5.50, the valve stop working, instead of giving access to the application, the valve is redirecting to form.
I tried to debug the cause, I do not understand why yet, but I notice the difference between previous tomcat version.
Prior to 8.5.50, after a successfull authentication the org.bsworks.catalina.authenticator.oidc.BaseOpenIDConnectAuthenticator.performAuthentication(Request, HttpServletResponse) method was redirecting to the original URI, then
performAuthentication is called again and following code was returning true
// check if resubmit after successful authentication
if (this.matchRequest(request))
return this.processResubmit(request, response);
in tomcat 8.5.50, matchRequest is returning false for some reasons so the valve is redirecting to form instead of the application

Version 2.3.0 of the authenticator addresses this issue.