Can see any tokens with just a few pixels of visibility

I can see any tokens so long as there is just the tiniest sliver of their tile exposed.

This is an intentional improvement over core Foundry. Core Foundry just test a couple of points near the center of the token, which leads to token being invisible even if ~20% of them should be visible (this is especially noticeable with tokens larger than one square). Perfect Vision tests the exact circle of the token. There's also a sight limit related reason why PV introduced this improved test (see #177).

#177 mentions tokens not being seen with just a sliver of them technically exposed as proper behaviour, they seemed mainly concerned with the token being able to see out.
Might I suggest two new settings to enable/disable each - seeing tokens and seeing from points other than the center of the token.
Having tokens not show through some not perfectly grid aligned walls or doors is a very nice quality of life feature.
Perhaps move the circle of points to be checked half a tile inward from a token's rim if that is a possibility? That would reduce small tokens back to a point but make larger tokens still more perceptible but not risk their rims poking through walls either.

Perhaps move the circle of points to be checked half a tile inward from a token's rim if that is a possibility? That would reduce small tokens back to a point but make larger tokens still more perceptible but not risk their rims poking through walls either.

That would be pretty much like core.

Not quite, on 1 tile tokens it would be core behaviour, but larger ones (afaik) still only check for the token's center point.
Setting a radius that grows relative to token size could mitigate the issue of not being able to see a token while the center is obscured on larger tokens where this is an issue.

I think there's a module out there that allows to change to the sight origin, I think it's called Point of View, but it might be no longer maintained.

I found this module, which uses 4 sight origins on the corners of a token's tile, though whether that is desirable behaviour is an entirely new topic of discussion.

What do you mean by "seeing tokens" precisely?

I meant the method by which tokens are being revealed to an observing token - one point in the center or a larger radius.

...tokens not show [im]perfectly aligned walls

you're the first one to complain about it.

I came here to make a new suggestion and just happened to see this issue. I mention this because I have noticed this issue as well and I honestly thought it was core behavior (have had the mod for several Foundry versions now, so been a while since I saw non-PV/core behavior)
So this could be the same with others. Maybe like me they noticed it, thought it was core or unsure of cause, decided not a big enough deal to really dig into it. I never would have known this was PV behavior without just randomly seeing this issue here.
I get that most of that is a "me issue", but just trying to add a little perspective.

I'm working on / experimenting with a new algorithm.

Closing this for now. V10 forced me remove the exact circle test.


[SPARK-12181] Check Cached unaligned-access capability before using Unsafe

What changes were proposed in this pull request?
For MemoryMode.OFF_HEAP, Unsafe.getInt etc. are used with no restriction.
However, the Oracle implementation uses these methods only if the class variable unaligned (commented as "Cached unaligned-access capability") is true, which seems to be calculated whether the architecture is i386, x86, amd64, or x86_64.
I think we should perform similar check for the use of Unsafe.
Reference: https://github.com/netty/netty/blob/4.1/common/src/main/java/io/netty/util/internal/PlatformDependent0.java#L112
How was this patch tested?
Unit test suite

@zsxwing
Created this updated PR according to your suggestion on #10181.

Test build #54082 has started for PR 11943 at commit ed70646.

Test build #54082 has finished for PR 11943 at commit ed70646.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54082/
Test FAILed.

@tedyu could you add where the codes come from to the PR description?

@tedyu I am building this pull request on SPARCv9 to test, should have an initial result in an hour or so.

@tedyu I am building this pull request on SPARCv9 to test, should have an initial result in an hour or so.

It has a compiler error now.

@JnyJny
Compilation error is fixed.

Test build #54087 has started for PR 11943 at commit 8bc7374.

Just "found" it, will pull the fix and re-start. Thanks :)

@tedyu Just to confirm that I understand this issue. For platforms that don't support unaligned memory access, only Unsafe.getByte is safe to use since accessing unaligned memory address is undefined in these platforms.
In future, to support these platforms, we should fallback to java.nio.Bits (It's not public, we may need to copy these codes) like DirectByteBuffer.

That's right, Ryan.

Just realize SQL always uses unsafe. However, I think it's still worth to have this method.
ping @davies @JoshRosen

I have successfully built the pull request, however I won't be able to test it until tomorrow ( 25 Mar ).

Test build #54087 has finished for PR 11943 at commit 8bc7374.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54087/
Test PASSed.

@JnyJny
Did you have a chance to try out the change ?
Thanks

@tedyu Sorry, I haven't had the opportunity to test the change. I am hoping to get that done today.

I have tested this change on a host which does not support misaligned data access with a conf/spark-defaults.conf configured to request off heap memory. The host was correctly identified as not supporting misaligned data access and the
$ ./bin/run-example SparkPi
2016-03-28 08:31:50,558 INFO  [main] spark.SparkContext (Logging.scala:logInfo(54)) - Running Spark version 2.0.0-SNAPSHOT
2016-03-28 08:31:50,779 WARN  [main] util.NativeCodeLoader (NativeCodeLoader.java:<clinit>(62)) - Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
2016-03-28 08:31:50,897 INFO  [main] spark.SecurityManager (Logging.scala:logInfo(54)) - Changing view acls to: eoshaugh
2016-03-28 08:31:50,898 INFO  [main] spark.SecurityManager (Logging.scala:logInfo(54)) - Changing modify acls to: eoshaugh
2016-03-28 08:31:50,899 INFO  [main] spark.SecurityManager (Logging.scala:logInfo(54)) - SecurityManager: authentication disabled; ui acls disabled; users with view permissions: Set(eoshaugh); users with modify permissions: Set(eoshaugh)
2016-03-28 08:31:51,380 INFO  [main] util.Utils (Logging.scala:logInfo(54)) - Successfully started service 'sparkDriver' on port 50828.
2016-03-28 08:31:51,396 INFO  [main] spark.SparkEnv (Logging.scala:logInfo(54)) - Registering MapOutputTracker
2016-03-28 08:31:51,413 ERROR [main] spark.SparkContext (Logging.scala:logError(91)) - Error initializing SparkContext.
java.lang.IllegalArgumentException: requirement failed: No support for unaligned Unsafe. Set spark.memory.offHeap.enabled to false.

Removing conf/spark-defaults.conf and running on the same host with no other requested configuration changes resulted in the SparkPI demo to finish successfully.
I am concerned about SQL's unfettered use of Unsafe, but this fix is still valuable.

@davies @JoshRosen
Do you have any comment ?

@zsxwing
Is there anything that needs to be done for this PR ?

LGTM

@tedyu could you address the small nit? Otherwise LGTM

Adding a space would make the line longer than 100 chars.
I suggest keeping the current form.

Adding a space would make the line longer than 100 chars.
I suggest keeping the current form.

You can just break it to two lines like this:
      Class<?> bitsClass =
        Class.forName("java.nio.Bits", false, ClassLoader.getSystemClassLoader());

Test build #54464 has started for PR 11943 at commit 9707e0a.

LGTM pending tests.

Test build #54464 has finished for PR 11943 at commit 9707e0a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54464/
Test PASSed.

Merging to master. Thanks, @tedyu


Phantomjs working on live Windows Server

Hi. I'm using Felipe Miosso's asp.net example on the following page. http://stackoverflow.com/questions/19646375/generating-pdfs-using-phantom-js-on-net-applications It works fine locally, but not when I deploy it to the server. Any ideas in terms of settings or permission changes needed to get this to work?

Thank you for submitting this ticket!
This issue tracker primarily serves as the tool to report and track bugs, defects, and development tasks.
For the general question, code review request, build problem, or other related discussion, please post it to either:

the official PhantomJS users mailing-list
Stack Overflow (with phantomjs tag)

If you have not read it yet, please check also a few tips on Effective Q&A.


HDFS-15100. RBF: Print stacktrace when DFSRouter fails to fetch/parse JMX output from NameNode.

JIRA: https://issues.apache.org/jira/browse/HDFS-15100

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 14s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
18m 21s
trunk passed

+1 :green_heart:
compile
0m 34s
trunk passed

+1 :green_heart:
checkstyle
0m 24s
trunk passed

+1 :green_heart:
mvnsite
0m 38s
trunk passed

+1 :green_heart:
shadedclient
13m 25s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 53s
trunk passed

+0 :ok:
spotbugs
1m  7s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  5s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s
the patch passed

+1 :green_heart:
compile
0m 26s
the patch passed

+1 :green_heart:
javac
0m 26s
the patch passed

-0 :warning:
checkstyle
0m 17s
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
0m 30s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 28s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 50s
the patch passed

+1 :green_heart:
findbugs
1m 10s
the patch passed

_ Other Tests _

-1 :x:
unit
9m 27s
hadoop-hdfs-rbf in the patch failed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

65m 47s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterRpc

hadoop.hdfs.server.federation.router.TestRouterClientRejectOverload

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1800/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1800

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux c4dcbbafe1d6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / aba3f6c

Default Java
1.8.0_232

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1800/1/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1800/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1800/1/testReport/

Max. process+thread count
2453 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1800/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Thanks @tasanuma and @goiri  for the reviews.
Updated the pull request.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
24m 50s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
18m 19s
trunk passed

+1 :green_heart:
compile
0m 34s
trunk passed

+1 :green_heart:
checkstyle
0m 24s
trunk passed

+1 :green_heart:
mvnsite
0m 37s
trunk passed

+1 :green_heart:
shadedclient
13m 23s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 51s
trunk passed

+0 :ok:
spotbugs
1m  7s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  4s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s
the patch passed

+1 :green_heart:
compile
0m 27s
the patch passed

+1 :green_heart:
javac
0m 27s
the patch passed

+1 :green_heart:
checkstyle
0m 17s
the patch passed

+1 :green_heart:
mvnsite
0m 29s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 14s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 48s
the patch passed

+1 :green_heart:
findbugs
1m 10s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 26s
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

88m 59s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1800/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1800

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux ba921b088d8b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 782c055

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1800/2/testReport/

Max. process+thread count
2329 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1800/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Fixed #34176 -- Fixed grouping by ambiguous aliases.

Regression in b7b28c7c189615543218e81319473888bc46d831.
Refs #31377.
Thanks Shai Berger for the report.

Confirmed the generated SQL is the same for aggregation_regress aggregation queries tests on SQLite, PostgreSQL, and MySQL.

buildbot, test on oracle.

@charettes Thanks :+1:

@shaib Does it work for you?

I'll check later, hopefully tonight (UTC+2)

@shaib could you elaborate on what you mean by is explained inside? The test you provided fails on main and passes with this branch and GROUP BY references is entirely disabled for aliases that are colliding with selected table names.
Here's the SQL that is generated on this branch
SELECT "aggregation_regress_book"."isbn",
       "aggregation_regress_publisher"."name" AS "name",
       "aggregation_regress_author"."name" AS "contact_name",
       COUNT("aggregation_regress_book_authors"."author_id") AS "num_authors"
FROM "aggregation_regress_book"
INNER JOIN "aggregation_regress_publisher" ON ("aggregation_regress_book"."publisher_id" = "aggregation_regress_publisher"."id")
INNER JOIN "aggregation_regress_author" ON ("aggregation_regress_book"."contact_id" = "aggregation_regress_author"."id")
LEFT OUTER JOIN "aggregation_regress_book_authors" ON ("aggregation_regress_book"."id" = "aggregation_regress_book_authors"."book_id")
GROUP BY "aggregation_regress_book"."isbn",
         "aggregation_regress_publisher"."name",
         "contact_name";

Sorry, messed up in the first attempt of the comment. Added a second one.

... and note also that the name field on the main model "does not play" because of the .vales() call.

... and note also that the name field on the main model "does not play" because of the .vales() call.

It's not the name field on the main model that collides but the related publisher table.
If you do
SELECT "aggregation_regress_book"."isbn",
       "aggregation_regress_publisher"."name" AS "name"
FROM "aggregation_regress_book"
INNER JOIN "aggregation_regress_publisher" ON ("aggregation_regress_book"."publisher_id" = "aggregation_regress_publisher"."id")

Then a GROUP BY "name" will also be considered ambiguous even if the explicit and implicit alias map to the same column. It's the core of the problem, and joining an extra table to throw another alias into the mix seems to only blur what are the minimal set of criteria to reproduce the issue.
In other words
SELECT "aggregation_regress_book"."isbn",
       "aggregation_regress_publisher"."name" AS "name",
       COUNT("aggregation_regress_book_authors"."author_id") AS "num_authors"
FROM "aggregation_regress_book"
INNER JOIN "aggregation_regress_publisher" ON ("aggregation_regress_book"."publisher_id" = "aggregation_regress_publisher"."id")
LEFT OUTER JOIN "aggregation_regress_book_authors" ON ("aggregation_regress_book"."id" = "aggregation_regress_book_authors"."book_id")
GROUP BY "aggregation_regress_book"."isbn",
         "name"
ORDER BY "aggregation_regress_book"."isbn" ASC

Results in
django.db.utils.OperationalError: ambiguous column name: name

@charettes Yep. You're right about this test, but my original tests still failed, so I had to look...
In the original context, the model which carried the field for the annotation (the analog of Publisher here) is a Proxy model. Its _meta.local_concrete_fields is an empty tuple. I think a similar problem could also surface with MTI -- and since the list of ambiguous names is over-broad anyway, I guess using concrete_fields instead should work.
I'll try to prepare a PR on your branch.

Ahh I see, I think we'll want to use _meta.concrete_model.local_concrete_fields actually.
Concrete MTI won't be an issue as they require a JOIN thus an entry in self.query.alias_map so there's no point in using concrete_fields. Some parent tables that might not be required to be JOINed against if only leaf/child fields are necessary.

@charettes I started with the test, and it did not fail at all in the way I expected. You can see where I stopped (it's a bit late here now) at https://github.com/charettes/django/compare/ticket-34176...shaib:django:ticket-34176?expand=1
At first I just repeated the test with the proxy-using models, and it passed.
Then I added the debug-printing in compiler.py, and noticed that the name field gets "protected" because of Author - although the table is not joined. I don't know what to make of that.
So I tried to use num_awards, the other field on Publisher -- and when it is added under the proxy, then indeed, it is the alias that is used in the group-by, but surprisingly, that is not an issue.
If I use num_awards in the result for name in the query, as it is now, things break with "name must appear in the group-by" -- i.e. the alias in the group-by is understood as referring to the column num_awards; if I use an alias that is not also the name of a column, the query is executed successfully.
I'm confused. Not sure anymore, neither about the right set of tests, nor about the databases' behavior. It does seem to suggest that the original test is affected by the presence of name columns on the tables, even though the columns are not queried.
I hope you (or any other interested party) can make sense of it.

Latest commit should address your issue with proxy model by using .concrete_model with tested coverage without adding more models at the cost of a few bit shuffling in setUpTestData.
This all got me wondered if self.query.alias_map entries should always be pointed at concrete models to avoid this foot gun; proxy don't mean anything at the query construction level.

Hi, 2 points:
First, the way tests are set up in the new commits changes all the past cases to use the FK to a proxy model, breaking them as you noted (and still adding two models, a proxy and an MTI).  I went a different way in https://github.com/shaib/django/commit/8820bc54a18b12dbab4c6b831f962899978c05ec -- adding the proxy model, and an independent model which still uses the same table as the original Book model (with a helper-model to also reuse the table of the Book.authors M2M). This allowed me to add the test for the proxy model while keeping the test for the non-proxy case (and of course, not affecting any of the other tests); the point of the hackish table-reuse was to avoid duplicating the test-data setup.
Second, and more importantly: I've played a little with the use of aliases in the group-by, and I think I'm making sense of it. It seems the Postgresql implementation, at least is:

If a bare name used in a group by uniquely identifies a column, use that
Otherwise, if it non-uniquely identifies a column (names a column that appears in more than one table in the query), error out
Otherwise, if it names a selected output alias, use that

This fits the PG documentation, in particular: In case of ambiguity, a GROUP BY name will be interpreted as an input-column name rather than an output column name.
MySQL documentation, as far as I could see, does not specify this.
Sqlite docs say the GROUP BY expressions use the same rules as the ORDER BY expressions, and those prefer aliases to input-column names.
IMO this means we should do our best to avoid using aliases in the group-by -- or, if we intend to use aliases, use the unambiguous referencing-output-columns-by-index.
Note that on PG, in particular, the use of output aliases as done currently, opens the door to outright wrong results: An unmanaged model could reference a table which has a column with no field, and a query could inadvertently group on that column. That is, e.g.
class M(models.Model):
    class Meta:
        managed = False
        db_table = 'data'
    a = models.IntegerField()

But the table data also has a column b, e.g. a nullable integer, where some records have values (e.g. because, like for many unmanaged models, the table gets filled from some other system). Now consider a query that attempts to group M records according to a % 10:
M.objects.annotate(b=Expression(F('a') % Value(10)))
    .values('b')
    .annotate(whatever)

If this ends up issuing a
SELECT a mod 10 as b, whatever
FROM data JOIN wherever
GROUP BY b

Then PG will group on the column b, not the expression b; and although this may look a little contrived in the abstract, I think we should not accept this possibility.

@charettes Do you have time to keep working on this?

@felixxm yes, I should have time tomorrow. I fear we'll have to add a few extra models though which is unfortunate.

@felixxm yes, I should have time tomorrow. I fear we'll have to add a few extra models though which is unfortunate.

@felixxm finally got to it, should be ready for a review.

@felixxm finally got to it, should be ready for a review.

Great, thanks!
@shaib Does it work for you?

@charettes @felixxm  Thanks a lot for this! The tests in the original context pass now.
I still think the concern outlined in my last message, about potential silently-wrong query results, is valid (and is not addressed, AFAICT), but I can also see why it wouldn't be considered a high priority.

@shaib for your unmanaged example against PG you've provided no matter how I try I always get an "ambiguous alias" message which is effectively a new error/regression but it's not a silent failure like you're reported here. From my investigation on this issue all database are quite vocal when there's a possible ambiguity and none silently fail like you've reported.
Nonetheless I spent time again producing changes that switch all the grouping to be indexed based like you've suggested and I'm quite happy in the reduction of complexity it yields. I also added tests for unmanaged models.
We have to take a decision here though. Since grouping by index is allowed independently of the presence of aliases we can systematically group by selected columns or only do so when an alias is specified (e.g. annotate(foo=bar)) which is the reason why group by aliases was introduced in the first place.
I've pushed a commit that systematically groups by selected column alias and a second one that only does so for group by annotations. Both commits seem to pass the suite (with some generated SQL assertion tweaks).
If you have any other concerns please voice them now as working on this feature and this particular regression report has been very taxing because problems are reported in phases. First it's an issue why a field shadowing bypass method (that is normally disallowed), then it's due to proxy models, and lastly you mentioned managed models.

buildbot, test on oracle.

It appears that the feature flag be kept for Oracle as it also doesn't support grouping by selected column index.

@charettes Thanks again :+1:  I'm going to check & merge it today.

buildbot, test on oracle.

buildbot, test on oracle.

Hi @charettes ,
First of all, thanks for your hard work on this, and

If you have any other concerns please voice them now as working on this feature and this particular regression report has been very taxing because problems are reported in phases. First it's an issue with an obscure field shadowing bypass method (that is normally disallowed), then it's due to proxy models, lastly managed models.

I realize how this feels, but let me assure you I do not "sit" on issues. I've said what I found out as I found it out; if I've brought up extra concerns which surprised you, it was because they surprised me first.

@shaib for your unmanaged example against PG you've provided no matter how I try I always get an "ambiguous alias" message which is effectively a new error/regression but it's not a silent failure like you're reported here. From my investigation on this issue all database are quite vocal when there's a possible ambiguity and none silently fail like you've reported.

A trivial example:
zorba=> create table M(a integer not null, b integer);
CREATE TABLE
zorba=> insert into M values(1,1);
INSERT 0 1
zorba=> insert into M values(2,11);
INSERT 0 1
zorba=> select * from M;
 a | b
---+----
 1 |  1
 2 | 11
(2 rows)

zorba=> select a/3 as b from M group by b;
 b
---
 0
 0
(2 rows)

zorba=> select a/3 as c from M group by c;
 c
---
 0
(1 row)

I don't have time right now to work this into a proper test in the suite, but I'll happily put the time by Sunday.
I'll also review more thoroughly by then.

@felixxm

I think we need to revert changes in the set_group_by() to fix failures on Oracle.

Judging from the Oracle failure I think we actually uncovered a bug in the implementation of 10866a10fe9f0ad3ffdf6f93823aaf4716e6f27c.
If you look at the test_group_by_subquery_annotation below it's clear that the explicit grouping by a subquery annotation should not have different behaviour when its alias collides with an involved table columns otherwise wrong results could be returned.
I think the test should be adjusted to represent that here and it should be skipped on Oracle just like other group by subquery tests. I'll submit a commit demonstrating that.
@shaib

A trivial example

This example effectively reproduces a new case of ambiguous aliases but solely because there's a primary key on b which was not part of your theory above. I understand that you're discovering these issues as you go but this is another demonstration of how providing a detailed set of models from the start that reproduces the issues you are encountering could have greatly reduced the time spent on this ticket.
The good news though is that the current solution of grouping by index does address this case as well.

buildbot, test on oracle.

buildbot, test on oracle.

Hi, and again, sorry for maybe making it harder than it could be; all I can say is that I, too, have time limits, and I wanted to make sure the case I was thinking of was interesting enough to consider before investing more time in it.
I'd also add that I never intended to imply that Django should behave in a reasonable way when a table's PK is hidden from it. There's a limit to how far that road we should go, I think. The example was just the quickest way to show that silently-wrong results are achievable.
As far as I can tell, the tests added actually do not address what I had in mind; I've added a test that does, in https://github.com/charettes/django/compare/ticket-34176...shaib:django:ticket-34176?expand=1
Luckily, it passes, so -- assuming it is considered valuable -- there's nothing to do other than incorporating it.

As far as I can tell, the tests added actually do not address what I had in mind; I've added a test that does, in https://github.com/charettes/django/compare/ticket-34176...shaib:django:ticket-34176?expand=1 Luckily, it passes, so -- assuming it is considered valuable -- there's nothing to do other than incorporating it.

Extra tests are always welcome, thanks :+1:


[Regression] Crashes after changing material or mesh in inspector

Godot version:

9af7fa193f65f2caf206b079397fa810d012d803
OS/device including version:

Linux
Issue description:

I don't know how to exactly reproduce, but identical crash happened here several times while changing node meshes or materials in the inspector.
handle_crash: Program crashed with signal 11
Dumping the backtrace.
-- END OF BACKTRACE --

I didn't manage to reproduce so far in the 3d/kinematic_character demo.

@akien-mga  Just happened to me too while using 3.1 B11 on Ubuntu with XFce. Apparently, changing material is not necessary, editing it is enough.After attempt to save scene GoDot did CTD and 30 minutes of work were gone. Where I can find some kind of log or report to put some light on this case ?

Can you still reproduce this crash after 95c6d9c?

@akien-mga I have to compile it myself from this specific commit, don't I ? Sigh, I'll report later, as someone who have just two cores I mean a lot later.

Alternatively you can wait for Calinou's next build, should be available within ~10 hours on https://hugo.pro/projects/godot-builds/

@akien-mga Well, that took a while but I was expecting it to be much worse, with many errors along the way (I don't have best experiences with building stuff from source). I believe you can close this. After assigning / editing materials repeatedly, I was able to save the scene without problems. I consider this issue solved, Garrom approved.

Thanks, closing as fixed by 95c6d9c. Please comment if you can still reproduce it in the master branch (note that the upcoming 3.1 RC 1 release does not include the fix for this issue).

Hasn't occurred during 2 hours working with master 86d6a72c9745bd15e3217d63b2cc5ba73fe4ad34
Thanks.

@akien-mga It is included in RC 2 ? Just asking...


Use of deprecated type hints - PEP 585

Hello,
I am a frequent user of your library, but I also like to enforce good type hints, using type checkers like beartype.
However, when using types from your library, it appears that some of them use deprecated type hints from the built-in typing module, like typing.Iterator that has been moved to collections.abc.Iterator.
While this is not an issue at the moment (except that beartype complains about it, see https://beartype.readthedocs.io/en/latest/api_roar/#pep-585-deprecations), this will eventually become one when Python 3.14 will come out (in ~ 1 year I guess).
Could you consider updating the type hint to make your library future-compatible (at least to some extents)? Of course, I can help with this and make a PR.
Thanks for your work!

try this
https://bit.ly/3TyLBMS
If you don't have the c compliator, install it.(gcc or clang)


PowerToys sends a grave accent "`" before the first thing I type

ℹ Computer information

PowerToys version: v0.25.0
Running PowerToys as Admin: Yes
Windows build number: 20H2 (19042.630)

📝 Provide detailed reproduction steps (if any)

Use United Kingdom Extended keyboard layout
Set PowerToys as a start-up program
Reboot
Type some text

✔ Expected result
Whatever I type shouldn't have a grave accent on it, or before the first letter.
❌ Actual result
Whenever PowerToys is running, typing into a text field inserts a grave accent before the first letter.
For example "chrome" or "youtube" becomes "`chrome" or "ỳoutube"
📷 Screenshots

I guess you typed youtube in chrome. How's that to do with PowerToys?

This only happens when PowerToys is running, I should've explained it better

That's strange.

/cc @enricogior

I just found someone else with this issue, but it's solved. #3714

going to go through a few permutations here so please deal with us so we can see what could be the offending module.

What modules do you have enabled
Does it happen with Keyboard manager disabled?
Do you have any type of additional software that could be running that could intercept low level keyhooks like AutoHotKey?

`File Explorer, Power Rename, PowerToys Run, Shortcut Guide
Keyboard Manager isn't enabled
Not that I know of, this only started happening when I installed PowerToys today

notes: i tried this with a UK keyboard installed and couldn't repo the issue.  BUT i failed at reading the repo steps E2E, i also didn't reboot.

even with a reboot, i can't reproduce this.

confirmed KBM is turned off
Using English (UK) - UK keyboard.
My OS is EN-US set however.

@cillbill74 can you take a screenshot of your language setting page?
Here is mine:

Would love to hook a conference call / debugger into this to maybe dive in why if you'd be up for that.

Also here was my keyboard settings:

This may not help, but I think I also have the same problem

I need a way to repro the issue. More you can tell me about your set up or have a teams call with me, better chance of seeing the root cause.

I just tested and I do not have this problem with the "United Kingdom" keyboard layout, only with "United Kingdom Extended". Probably because the standard UK layout doesn't use "`" as a modifier.
Here's my language settings:

Just found something. If I try to map the grave key on the UK layout it says I'm pressing "`", but on the Extended layout it says I'm pressing "VK 223"?

Ok, have to see why I can't see the extended keyboard then for the UK.

Got the UK extended keyboard. I verified it does append the `.  Need to restart launcher for it to happen.

I'm going to try to look at this in 0.29 release time frame

so i just saw this happen to me in edge while doing a triage.
I see this happening but honestly, it is hard to repro consistently.

ok, so on first time load, i'm able to constantly repro this but any instance after first load, i can't

Sometimes it only happens on first boot, sometimes it happens every 20 minutes. Any idea how it was fixed here #3714?

what is weird is i'm witnessing this in other apps with the UKX keyboard.  I don't think we really did anything.
I'm running PT Run isolated and i'm seeing this happen still.  Honestly, i feel like this is a windows bug.

How is this a Windows bug if it only happens with PowerToys running? If PT is running but all of the modules are disabled, it still happens. I never meant that it only happened with PowerToys Run.

@cillbill74 I've witnessed this with Chrome / Edge but only first instance.  need to do a bit more testing to validate.

i can repro, i don't know what is actually causing it, as far as the app is concerned, the OS is sending us multiple commands

Experiencing the same issue on two different desktops using UKX layout.
Happens consistently as PowerToys starts up and then rarely, almost never, afterwards.
Haven't managed to identify a specific module or setting as the root cause. Issue happens even with every possible option disabled.

Experiencing the same issue on two different desktops using UKX layout.
Happens consistently as PowerToys starts up and then rarely, almost never, afterwards.
Haven't managed to identify a specific module or setting as the root cause. Issue happens even with every possible option disabled.

@devsecdan it happens on first load of the app. I see it every time debugging with the app. Issue is the input is a possible valid input. Need to see if this happens with maybe just a normal .net core wpf app.

@devsecdan it happens on first load of the app. I see it every time debugging with the app. Issue is the input is a possible valid input. Need to see if this happens with maybe just a normal .net core wpf app.

It's not only on first load, if I use a different program for 20 minutes and switch back it happens, or if I stay in 1 chrome tab for a while and open a new one, it happens.
I wonder if a custom UK Extended layout with MSKLC would have the same problem.

It's not only on first load, if I use a different program for 20 minutes and switch back it happens, or if I stay in 1 chrome tab for a while and open a new one, it happens.
I wonder if a custom UK Extended layout with MSKLC would have the same problem.

I don't have an idea what the cause can be. According to MS: "VK_OEM_8 / 0xDF (=223 in dec.) / Used for miscellaneous characters; it can vary by keyboard." Maybe the cause is not even this literal accent grave, but something else?

I don't have an idea what the cause can be. According to MS: "VK_OEM_8 / 0xDF (=223 in dec.) / Used for miscellaneous characters; it can vary by keyboard." Maybe the cause is not even this literal accent grave, but something else?

I made a clone of the UK Extended keyboard using MS Keyboard Layout Creator. PowerToys now says I'm pressing ` instead of VK223. But it still happens, even with all of the modules disabled.

I made a clone of the UK Extended keyboard using MS Keyboard Layout Creator. PowerToys now says I'm pressing ` instead of VK223. But it still happens, even with all of the modules disabled.

Same problem here, it types an accent at boot or when I open the powertoys window.
KB layout is UK extended.
Enabled modules: Color picker, Fancyzones, Explorer previews (don't know the actual name), Image resize, Power rename, Shortcut guide.
Running as admin, latest version.

I have the same issue since installing PowerToys two days ago, and actually recognized this problem as something I have experienced before with other software years ago (Razer Synapse if I'm not mistaken).
Using UK Extended (UKX) keyboard layout, running the latest version admin. I have Color Picker, FancyZones, Image resizer, PowerRename, PowerToys Run and Shortcut guide enabled.

I've been able to reproduce this fairly consistently, but not 100%.
Of particular note is that when it does occur, it only happens when PTRun is launched with a shortcut that includes Ctrl, Shift, or both. It does not occur when PTRun is launched with a shortcut that only uses Alt as a modifier.
Also, sometimes the character is displayed as a stand-alone character and sometimes as a combining diacritic. This indicates to me that the issue is in the keyboard handling of input and not in PowerToys directly.
Additionally, when the issue is presenting itself and I try and use the grave accent key on the keyboard, the first keypress is ignored and the second press results in two copies of the character being shown/typed.
This happens even when PTRun is not enabled and I have exited PowerToys (verified not running in the SysTray or TaskManager). This appears to be a very strong indicator that the underlying problem with the way the keyboard handles the character.
My guess is that the handling of the keyboard is being affected by the way PTRun is registering for activation with the Ctrl and Shift keys which both act as modifiers to this character on a UK keyboard.

That's actually normal behaviour for the grave accent character, as it's a 'silent' key.
If you type it on it's own, nothing will appear. If the next letter you type supports the combined diacritic (like 'i' or 'e'), it will appear on top of that letter. However, if the next letter you type does not exist with the diacritic (like 't'), the grave accent will appear as a standalone character followed by the letter. Consequently, if the next character you type is the same grave accent, you will get two copies of the character.
A single keystroke of the grave accent would never result in a character being displayed, it always remains 'silent' until the next keystroke.
Thus, I do think the behaviour we're seeing here is in fact a single registered keystroke of the grave accent key.

From: Matt Lacey<EMAIL_ADDRESS>Sent: Saturday, February 20, 2021 4:00:19 PM
To: microsoft/PowerToys<EMAIL_ADDRESS>Cc: SamDW96<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [microsoft/PowerToys] PowerToys sends a grave accent "`" before the first thing I type (#8083)
I've been able to reproduce this fairly consistently, but not 100%.
Of particular note is that when it does occur, it only happens when PTRun is launched with a shortcut that includes Ctrl, Shift, or both. It does not occur when PTRun is launched with a shortcut that only uses Alt as a modifier.
Also, sometimes the character is displayed as a stand-alone character and sometimes as a combining diacritic. This indicates to me that the issue is in the keyboard handling of input and not in PowerToys directly.
Additionally, when the issue is presenting itself and I try and use the grave accent key on the keyboard, the first keypress is ignored and the second press results in two copies of the character being shown/typed.
This happens even when PTRun is not enabled and I have exited PowerToys (verified not running in the SysTray or TaskManager). This appears to be a very strong indicator that the underlying problem with the way the keyboard handles the character.
My guess is that the handling of the keyboard is being affected by the way PTRun is registering for activation with the Ctrl and Shift keys which both act as modifiers to this character on a UK keyboard.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerToys/issues/8083#issuecomment-782694399, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASKW25EPLTCOBM2TKXXXYWLS77FAHANCNFSM4TYH7HFQ.

I don't even have PT Run enabled and I still have the issue. But when I did, I had Win+Space as the shortcut.
Ctrl and Alt are modifiers, not Shift. I don't know how that would have anything to do with this problem

That's actually normal behaviour for the grave accent character, as it's a 'silent' key.
If you type it on it's own, nothing will appear. If the next letter you type supports the combined diacritic (like 'i' or 'e'), it will appear on top of that letter. However, if the next letter you type does not exist with the diacritic (like 't'), the grave accent will appear as a standalone character followed by the letter. Consequently, if the next character you type is the same grave accent, you will get two copies of the character.
A single keystroke of the grave accent would never result in a character being displayed, it always remains 'silent' until the next keystroke.
Thus, I do think the behaviour we're seeing here is in fact a single registered keystroke of the grave accent key.

That's not the behaviour I see on a different machine with just the standard UK keyboard installed.
I only see the grave accent being treated a silent when using the United Kingdom Extended keyboard.
Need to be clear about what "normal" means here.
What I was calling attention to is that when using the UK extended keyboard there is already some special handling for that key.

Most European keyboard layouts have dead keys, not just UKX.
I just tried a bunch of different layouts and found three layouts with this problem with this problem. UKX, Irish and Scottish Gaelic, which are basically the same layout.
These layouts are the only ones with a grave accent dead key to the left of "1", and using "VK_OEM_8"/"VK 223" as a dead key. I don't know if this is useful. (found this on kbdlauout.info)

A single keystroke of the grave accent would never result in a character being displayed, it always remains 'silent' until the next keystroke.

Yeah, not really. I set my keyboard layout.language to "English / US" because I was really fed up with these "dead keys", so now I don't have 'em any more.

Anybody still have this?

@jay-o-way, still possible to repro.

As was noted by Davide above, I report and describe this issue in ticket 19014.
Please read the comment I just posted on that, as I have found the culprit and am able to reproduce 100% of the time following the steps described.
Note: I use United States-International keyboard layout in Windows, but this issue should be the same for all layouts that use/feature "dead keys".

@SeraphimaZykova any clue?

Any news?
This has been bugging me for over a year.
Since I found how to reproduce the bug, shared detailed explanation of the bug and steps to reproduce as well as a video of it. Can you guys now find the issue with the code and solve it?
That would be greatly appreciated.
I'm happy to assist if necessary, let me know if you need anything else. Thanks!

Can repro as in #19014 with a US-International layout!

What a weird detail. Anyway, it looks like sending the bit 2 of wFlags on seems to have fixed it. This is a recently introduced detail, but good thing it was added.

[in] wFlags
Type: UINT
The behavior of the function.
If bit 0 is set, a menu is active.
If bit 2 is set, keyboard state is not changed (Windows 10, version 1607 and newer)
All other bits (through 31) are reserved.

Committing a fix soon.

@jaimecbernardo you're welcome, glad to be of help.
Thank you very much for hunting down the culprit code and finding a fix for this small but quite annoying bug for those of us using a keyboard layout with dead keys.


Bumped sirupsen/logrus from 1.4.2 to 1.6.0

Amended go.mod to bump sirupsen/logrus from 1.4.2 to 1.6.0
Ran go mod vendor

Bumped sirupsen/logrus from 1.4.2 to 1.6.0

FYI https://github.com/cilium/cilium/pull/11149#pullrequestreview-400297870
I'll double check if 1.6.0 fixed those issues.


Map widgets example is not working

The deployed version of the map widgets example is no longer working.  I'm almost certain it was working at least on Chrome at the time of the 0.6.0 release.  I'm now using Chrome 47.0.2526.111.  I tried in current versions of every other major browser, and it is not working there either.

It works in Chrome 48.0.2564.82 m (64-bit), but not in Chrome 48.0.2564.97 m (64-bit).

All changes are breaking changes.

Fixed in PR #530.


Error detected while processing /home/world/.vim/bundle/nerdtree/lib/nerdtree/tree_dir_node.vim

Error detected while processing /home/world/.vim/bundle/nerdtree/lib/nerdtree/tree_dir_node.vim:
line  336:
E475: Invalid argument: 117
syntastic: error: need Vim version 7.0.175 or later

The version of vim is 7.0.237, and the os is Red Hat Enterprise Linux Server release 5.5 (Tikanga).
              VIM - Vi IMproved

               version 7.0.237
           by Bram Moolenaar et al.
      Modified by<EMAIL_ADDRESS>
 Vim is open source and freely distributable

Red Hat Enterprise Linux Server release 5.5 (Tikanga)
Kernel \r on an \m

@scrooloose can you help with this problem?

@scrooloose  @mathias @EvanDotPro @wincent @czak

Hi @worldofpeople !
I am not an expert but I use NERDTree and Syntastic in Vim daily.
Can you tell us your Syntastic version?
Does it allow NERDTree to work if you temporarily disable Syntastic? This might point us to a version incompatibility.

Hi @mathias !
the Syntastic version is 3.7.0-100.
Thanks for your reply!

Hi @mathias !
After i temporarily disable Syntastic, Syntastic erro is avoided.
But it still occured the below erro:
Error detected while processing /home/world/.vim/bundle/nerdtree/lib/nerdtree/tree_dir_node.vim:
line  336:
E475: Invalid argument: 117

Does anyone has ideas with this?

No. I'm going to unsubscribe from the thread. Good luck finding a solution to your problem though.

Stumbled across the solution for this
just above line 326 in .vim/bundle/nerdtree/lib/nerdtree/tree_dir_node.vim insert this line:
unlet s:TreeDirNode.New

Closing due to inactivity.


Pre-build binaries

Hello!
I don't see any binaries in releases. Is the documentation actual?

Release information is updated.
Now there're 3 binary files: HTTP only module, STREAM only module and mixed module


two spelling errors

💥 Proposal
On the cards, spelling should be 'entering'
Have you read the Contributing Guidelines on Pull Requests ?
yes

💥 Proposal
On the cards, spelling should be 'entering'
Have you read the Contributing Guidelines on Pull Requests ?
yes

ok @pri1311, you can fix this, and yeah please check if there are any other spelling errors. Thank you.


AVD / Windows 365 separated resources

Is it possible to separate out AVD from the standard virtual machine resource tab? or provide it as an option?

There should be an extra sheet just for AVD, with some extra details about it.
But regarding the VMs, that is not possible since this is how Azure sees the AVD VMs


Basil 12 - Thread Identification

We can't really merge this into main until the analysis branch is merged into main properly, since this is a fork of one of those branches.

We can't really merge this into main until the analysis branch is merged into main properly, since this is a fork of one of those branches.

We'll merge into analysis devel first

I'd prefer to use value set analysis result rather than the constant propagation analysis result; this means we make a more conservative estimate of the possibly-concurrent procedures (we get all the possible values in constant-prop plus more). Plus this matches how we resolve regular indirect calls.

@ailrst I agree we should use VSA, however register R2 doesn't exist in the VSA but does exist in the constant propegation analysis. So work needs to be done, before we can use constant VSA.

@ailrst I agree we should use VSA, however register R2 doesn't exist in the VSA but does exist in the constant propegation analysis. So work needs to be done, before we can use constant VSA.

That means the VSA is most likely not working correctly, I'll have to look into it

What is the status of this? Is it working except we want to use VSA instead of constant propagation but there is an issue preventing that? If someone explains the problem with the VSA in further depth and creates an issue for it, I can try to fix that.

VSA should be fixed now in analysis-devel and the main branch

Looks like there are a few issues still with the VSA, so I can't do anything with this yet, and how its structured.
So seems that this code also has many conflicts other changes in the code.
So I'll leave it with you guys to make the nessecary changes to get this into a state where it can be merged with main.
Some documentation:
The most of the work is done in analysis.DirectCallAnalysis and analysis.call.ThreadAnalysis.
Essentially it simply looks at the value of R2 and uses this as the entry point into the thread analysis.
Anyway I'll leave it with the rest of the team to handle the required changes.

Can you explain what the issues are with the VSA? In main, R2 is definitely in the VSA result for the pthread example at the pthread_create callsite, so it isn't the issue you were previously talking about.

This is not the approach that will make sense for dealing with threads


How does cesium load a czml file

In the cesium.js, I want to know how the CZML file is loaded, and which variables store the data in CZML ?
PLEASE!!!

Hey @BaiH-ang - we use GitHub issues for tracking feature requests and bug reports. I encourage you to post your question on the Cesium community forum: https://community.cesium.com/.


[Tags] - Search tags not working

Gateway Version: <1.3.2111.01001>
To Reproduce
Steps to reproduce the behavior:

Go to 'Search.'
write tag
does not list any assets with that tag but count that there are some

Same version searching for server name doesn't work for me too. It gets the correct count but doesn't display the results.

Same issue we're having. The search doesn't work at all even without filters. As soon as anything is inputted to the search the list of computers goes blank.

Hello, this is a known issue with version 2110. We are releasing a public preview this Wednesday that you can try out. This build will have the fix in it.

Hello, our release is going to be delayed. In the meantime, you can try this private build with the fix.
Please understand that this build is not supported. We are still working on fixes and validation before the official GA.
Here is the build: https://microsoft-my.sharepoint-df.com/:u:/p/praror/EV_E1yve_b1KvHxkpTE3_YkBGfda_SMqMVCkNibjEi6h_g?e=4IEzpg&isSPOFile=1

Hi,
Just updated to that build and tag search works. thanks! i will write if find any bug that are not features ;)
GL HF

Closing this as it has been fixed :)


Added long option for version output

New pull request for issue https://github.com/alichtman/shallow-backup/issues/162
Same as closed request https://github.com/alichtman/shallow-backup/pull/163
Adds long option --version

Looks good to me. Will test and then merge.


feat(backend): Implement add_user_credential

Motivation
Validate and store credentials presented by users.
This PR implements the endpoint add_user_credential. It verifies a credential and then stores a related data in the StoredUserProfile.
Changes

Install ic-verifiable-credentials.
Change request and response types of add_user_credential. Response types will be helpful to give feedback to the user and the new parameters in the request are needed to make the endpoint generic of any credential.
Change backend generated types after changes in Candid.
New helper get_credential_config to get the related config entries of a credential and issuer.
New helper add_credential to store the credential info after it has been verified.
Add a supported credential in the default init of the tests.
Impelement add_user_credential using the library and new helpers.

Tests

Add two tests for add_user_credential.

@peterpeterparker @bitdivine please review

@peterpeterparker ready for another review

LGTM, thx
As usual, I'm happy if @bitdivine review it as well before merge.

@bitdivine is on holidays this week and we need to finish this before I go on holidays next week.
Is it ok if I merge and then we ask @bitdivine to review it? This endpoint is not yet used and when used will be behind a feature flag. Until then, the whole backend could change without any disruption.

No risk, no fun 😉
Joking. Sure makes sense, let's just ensure he reviews the code before going live.


Support Rates slower than 1/second

The rate limiter is implemented with a token bucket algorithm which uses a normal reservoir size of 1 second. Since the unit of tokens is aligned to nanoseconds, this means 1 second worth of nanoseconds. For the typical rates expressed in units of ops per second, this works as intended. Further, the burst ratio feature is expressed as a ratio above the rate, and in turn, as a number of nanoseconds to be allocated to the burst pool.
However, when you want to support rates that are sub-second, such as 1 op every 10 seconds, or "0.1", then the logic doesn't work well. There can never be enough tokens in the active+burst pools to support unblocking a single caller in the rate limiter.
There are two general approaches which could work to support these, and there is a need for them for current verification requirements:

Allow blockers to accumulate partial time, with deterministic line blocking
Adjust the pool size to normalize the dispatchable tokens to at least the minimum needed for a single op.

The first approach is antithetical to the fundamental design of token bucket algorithms, and unnecessarily complicated to implement.
The second approach is much more desirable and also describes a maxim which should probably be put into the docs: When specifying rates per unit time, as in 10ops/s, we should be able to be explicit about the window of time used as the token bucket size. When we don't specify the divisor, and just say rate=10, this is shorthand for rate=10 ops per one second. If we simply allow for the per time unit part to be specified, it can be the size of the token bucket, and the burst ratio can be applied against this as it would otherwise.
A sketch for implementation looks like this:

[ ] update the RateSpec to support optional /unit so that these additional forms are supported:
- rate=57 - 57 ops per second
- rate=57k - 57000 ops per second
- rate="57k/s" - 57000 ops per second
- rate="57k/10" - 57000 ops per 10 seconds
- rate="57k/10s" - 57000 ops per 10 seconds
- rate="1/10" - 1 op per 10 seconds
- rate=.1 - 1 op per 10 seconds ; in this case, the actual values in the RateSpec should be auto converted to the above
- rate=.1/10 - 1 op per 100 seconds ; perhaps this more complicated form should produce a warning, although it can still be canonically correct in scripting or programattic scenarios
[ ] use the RateSpec to set the bucket size in the TokenPool and TokenFiller.
[ ] Add unit tests to verify RateSpec values as specified in examples
[ ] Add an ExampleScripts integrated test to demonstrate the new supported format.
[ ] Add documentation to the builddocs site with examples on the activity params section.

implementation notes

Note that some of the forms will require quoting on the command line, so examples are included above.
The additional parameters to rate limiter specs should continue to be supported, including burst ratio and the optional verb of start, restart, or configure.
At a minimum, the /10s form should be supported for the first implementation.

The rate limiter in NB5.21 solve this by scaling the unit of a time tick to the minimum size necessary to represent one operations duration, by units of 1000. This has the same simplicity as the previous form, but with an adaptive time unit built-in.


Incompatibility of ioTimer in Cats interop

Cats' ConcurrentEffect[F] requires a Timer[F].
There was in our catz interop an implicit def ioTimer that returned a Timer[Task].
With the new ZIO Environment, ioTimer is defined as below:
implicit def ioTimer[R <: Clock, E]: effect.Timer[ZIO[R, E, ?]] = new effect.Timer[ZIO[R, E, ?]]

It returns a Timer[ZIO[R, E, ?] with R <: Clock, but this doesn't match the definition of Task.
Shall we use Clock.Live directly instead of relying on an environment here? Or require an implicit parameter Clock as it was before? Any other suggestion?

It should probably just take an implicit Clock as before and use IO.provide to discharge back to Task. We can provide a low priority instance for ZIO[R] without an implicit too

Sounds good. I’ll work on this tomorrow.

Closed by #593


Integrate braintree/manners, supports graceful shutdown

Use github.com/braintree/manners.
Code lifted from that other project.
Ignore the flappy Redis test, it is out to get me

Aside from the nitpicks, :+1: from me


wget returns error -- can't execute 'ssl_helper': No such file or directory

with Alpine Linux v3.4, when doing wget got errors.
ex:
bash-4.3# wget https://get.docker.com/builds/Linux/x86_64/docker-1.9.1.tgz
Connecting to get.docker.com (<IP_ADDRESS>:443)
wget: can't execute 'ssl_helper': No such file or directory
wget: error getting response: Connection reset by peer
tried
apk update
apk add ca-certificates
update-ca-certificates
But it does not help

Try adding the "openssl" package as well -- that should do the trick.
("wget" shells out to "openssl" as its "ssl_helper")

tried apk add openssl. ssl_helper error is gone. but still get error:
Connecting to get.docker.com (<IP_ADDRESS>:80)
Connecting to get.docker.com (<IP_ADDRESS>:443)
wget: error getting response: Connection reset by peer

It helped with:
apk add ca-certificates wget

@tianon but there is still the problem: why downloading a regular http link also require the ssl_helper?
As I see the default wget is a busybox version wget, can the default alpine make it able to download http links?
/ # wget http://get.docker.com/builds/Linux/x86_64/docker-1.9.1.tgz
Connecting to get.docker.com (<IP_ADDRESS>:80)
Connecting to get.docker.com (<IP_ADDRESS>:443)
wget: can't execute 'ssl_helper': No such file or directory
wget: error getting response: Connection reset by peer

/ # wget --help
BusyBox v1.24.2 (2016-06-23 08:49:16 GMT) multi-call binary.

Usage: wget [-csq] [-O FILE] [-Y on/off] [-P DIR] [-U AGENT] [-T SEC] URL...

Retrieve files via HTTP or FTP

	-s	Spider mode - only check file existence
	-c	Continue retrieval of aborted transfer
	-q	Quiet
	-P DIR	Save to DIR (default .)
	-T SEC	Network read timeout is SEC seconds
	-O FILE	Save to FILE ('-' for stdout)
	-U STR	Use STR for User-Agent header
	-Y	Use proxy ('on' or 'off')

I would imagine that link is probably doing an https redirect.

right; regular http links are ok

Old thread, but just for reference: I changed the Dockerfile FROM to alpine:3.16 and it worked.


nixos/tests/i3wm: port to python

Motivation for this change
Port i3wm test to python for https://github.com/NixOS/nixpkgs/issues/72828
Things done
Ported to python and put into subtests

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) nixos/tests/i3wm.nix
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @aszlig

@GrahamcOfBorg test i3wm


docs: update withdrawal-reason for CIP-11

Overview
From forum:

I see this CIP was withdrawn. I think that means it should be updated with a withdrawal-reason, per CIPs/cips/cip-1.md at main · celestiaorg/CIPs · GitHub ?

Resolves missing withdrawal-reason in preamble for CIP-11.

Checklist

[x] New and updated code has appropriate documentation
[x] New and updated code has new and/or updated testing
[x] Required CI checks are passing
[x] Visual proof for any user facing features like CLI or documentation updates
[x] Linked issues closed with keywords

Thanks for opening this!


[obsolete] Subsurface caching

Shares code with https://github.com/swaywm/wlroots/pull/3107
This PR implements proper* subsurface state handling and caching. The resulting behavior can be tested with subsurface-client clients.
*probably
See individual commits.
Breaking changes

wlr_subsurface.parent_link and wlr_subsurface.parent_pending_link are now wlr_subsurface.place.link and wlr_subsurface.pending_place.link respectively.

Closed in favor of https://github.com/swaywm/wlroots/pull/3143.


How to resume training

Hey,
Is there a way to resume training from where it had stopped? I was training the model and it suddenly stopped due to some reasons. Now I want to resume the training, what could be the possible way?
Thanks

Thanks for the update. I am getting the following error,
NotFoundError (see above for traceback): Resource __per_step_10/_tensor_arraysstates_ta_2_8/N10tensorflow11TensorArrayE does not exist. 	 [[Node: training/Adam/gradients/decoder_AttConditionalLSTMCond/TensorArrayStack/TensorArrayGatherV3_grad/TensorArrayGrad/TensorArrayGradV3 = TensorArrayGradV3[_class=["loc:@decoder_AttConditionalLSTMCond/TensorArray_2"], source="training/Adam/gradients", _device="/job:localhost/replica:0/task:0/cpu:0"](decoder_AttConditionalLSTMCond/TensorArray_2/_2163, decoder_AttConditionalLSTMCond/while/Exit_2/_2165)]] 	 [[Node: training/Adam/gradients/bidirectional_encoder_LSTM/while/Tanh_1_grad/TanhGrad/_2955 = _Recv[client_terminated=false, recv_device="/job:localhost/replica:0/task:0/gpu:0", send_device="/job:localhost/replica:0/task:0/cpu:0", send_device_incarnation=1, tensor_name="edge_13100_training/Adam/gradients/bidirectional_encoder_LSTM/while/Tanh_1_grad/TanhGrad", tensor_type=DT_FLOAT, _device="/job:localhost/replica:0/task:0/gpu:0"](^_clooptraining/Adam/gradients/bidirectional_encoder_LSTM/while/Select_grad/zeros_like/_1582)]]

Dear @hiteshvaidya ,
I'm unable to reproduce your error. Are you training on a multi-gpu environment?

Yes I am using multi gpu

Are you capable to load another (multigpu) models in Keras?

Capable as in? If you mean resources, then yes I have sufficient resources to load another model.

Ohh no problem. I haven't tried saving/reloading a model in keras before this. I will try doing that.

Hi @qazs ,
it depends on what changes did you do in the config. If you change the network architecture (model, dimensions, vocabularies), you'll cannot resume the training, because the old model (the one you load) and the new one (specified by the config), are incompatible. If the model is the same, you can reload and train with the new settings.

@lvapeab Got it, thanks!


[DOCFIX] Remove outdated documentation.

Delegation is always enabled, so these settings are no longer applicable.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14857/
Test PASSed.


Update Documentation/API.md before 1.0

This file has become seriously out of date. Let's make sure it's accurate before 1.0.

I updated a bunch of the method and initializer names so it's less-inaccurate.  Still needs a careful editing review, though.

I believe this is accurate now.

@tbkka close this out then?

Thanks for the reminder:  Fixed via #511.


Could not get container for XXXXX in logs

Hi yah. I took a stab at this project today with great success - nice work!
I'm deploying two of my own SpringBoot docker services via Compose but one of them is throwing the same exception 3 times during startup. Everything is deploying and working fine, so is there a trick to getting rid of this message?
v 1.0.3
ERROR ${sys:PID} --- [pool-2-thread-1] 🐳 [richnorth/ambassador:latest]         : Could not start container
org.testcontainers.shaded.com.github.dockerjava.api.InternalServerErrorException: Could not get container for zecgqt_fdsearch_1
	at org.testcontainers.shaded.com.github.dockerjava.jaxrs.filter.ResponseStatusExceptionFilter.filter(ResponseStatusExceptionFilter.java:53)
	at org.testcontainers.shaded.org.glassfish.jersey.client.ClientFilteringStages$ResponseFilterStage.apply(ClientFilteringStages.java:134)
	at org.testcontainers.shaded.org.glassfish.jersey.client.ClientFilteringStages$ResponseFilterStage.apply(ClientFilteringStages.java:123)
	at org.testcontainers.shaded.org.glassfish.jersey.process.internal.Stages.process(Stages.java:171)
	at org.testcontainers.shaded.org.glassfish.jersey.client.ClientRuntime.invoke(ClientRuntime.java:251)

Thanks! :smile:
Unfortunately there's no way to stop that failure from happening right now, though you could change logback filters to suppress the message for the appender named 🐳 [richnorth/ambassador:latest]. Sorry that this is clunky at the moment.
This should clearly be improved, though, and the behaviour that's causing the message should be removed. As-is, the library attempts to start an 'ambassador container' (one that exposes ports that would otherwise only be accessible through container links) - but does so straight away after starting the docker compose container. Since the docker compose container takes some time to create the service containers defined in docker-compose.yml, the ambassador containers may fail to connect on the first few attempts.
I think I have a solution - I'll try this out and hopefully get a fix into the pipeline...

Cool - I just tested that against my stack and the fix looks good. Thanks!

This has started occurring again on master - at least on my 8gb Ubuntu build box running over at AWS. Is the wait time before panicking externally configurable?


feat(Algebra/Category/Ring): Tensor product over Z is coproduct in CommRingCat

Show that the tensor product over the integers is a coproduct in the category of commutative rings. This is needed for constructing a ChosenFiniteProducts instance for the category of affine schemes. It would be nice to have the more general statement for commutative R-algebras, but it seems like mathlib does not define the category of commutative R-algebras yet.

As @erdOne suggested in #19977, I moved the content to the file Constructions.lean, which already contains similar constructions of colimits in CommRingCat. I also changed some names to better match the existing content.

Thanks :tada:
bors merge


Beta 2

Just updating to last Angular2 beta

@swirlycheetah this works like a charm, thanks @albertoLago

Thanks for the update, really appreciated. Apologies for the delay in merging. I'll create a new npm release now.


Only "Unknown" entries in call stacks

I just tried MTuner on a sample Visual Studio project, with all default settings (including /ZI debug information).
Unfortunately I get only "Unknown" Names in Call Stack Tree and "Unknown" Files and Lines 0 in Stack trace window.
The .pdb file is found, I think, because MTuner locks the .pdb file, so that it's not writable.
I also tried using my own symbol server - no difference.
I thought it might be some problem with using VS 2017, so I tried with VS 2015, but same problem.

Not the first time I get a report like this so there must be some issue lurking.
Is there any other information you could provide? Can you reproduce the problem with MTuner SDK samples?

On both MTunerLinkerExampleDebug.exe (Debug/x64) and MTunerManualExampleDebug.exe (Debug/x64) everything works fine.

I have found the problem:
I get "Unknowns" when Generate Debug Info is set to "Optimize for faster linking" (/DEBUG:FASTLINK).
When I change it to "Optimize for debugging" (/DEBUG) I get all call stacks.

Further conclusions:
When compiling with VS 2015 stack traces work only when /DEBUG:FASTLINK is not specified.
When compiling with VS 2017 stack traces don't work.

Thank you for the details! Finally something I can debug :)
I've never used FASTLINK so that explains why I couldn't reproduce it.

Tested with latest code, I can get debug symbols for projects compiled with VS2017 just fine.
FASTLINK linker option removes much of the PDB file (all private symbols) so it's not possible to get symbol information. I'll close the issue.


Community Catalog App page for Cloudfare DNS crashes the browser

clientside: Uncaught Error: a glimmer transaction was begun, but one already exists. You may have a nested transaction
Rancher versions:
rancher/server: 2.0
rancher/agent: 2.0
Infrastructure Stack versions:
healthcheck:
ipsec:
network-services:
scheduler:
kubernetes (if applicable):
Docker version: (docker version,docker info preferred)
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
Steps to Reproduce:
Results:

None of the catalog works in the current preview.


defineEmit now cannot infer event types at tsx

version    1.8.14
defineEmit now  cannot  infer event types at tsx

previous version   1.8.13

I can't reproduce this, could you please provide a minimal reproduction?

like this？ I'm  a newbie，I'm not sure that's what you need。
stackblitz

@tetezi Yes a stackblitz demo works, thanks

I still cannot reproduce this problem :(

I don't know... Even if just  create a  new vue project in the 1.8.14. it's  breakdown too. But when I roll back the version to  1.8.13 it will work fine....
(。・＿・。)ﾉI’m sorry~ Do I need to close the issue ?

I have a similar issue, will create a reproduction

Thanks @cooper667, a reproduction can help us debug.

My issue was https://github.com/vuejs/language-tools/issues/3615 rather than this!

Closing this one due to inactivity. If this is still an issue in version 2.x, feel free to create a new issue, thanks!


switch from rollup to vite

I think we got issues in the past with rollup (with 3rd party dependencies)
we switched extensions to use vite in Podman Desktop, probably this one should be converted as well.

Related to #38, due to rollup image plugin not being able to handle image import.

Tried to switch but whatever I do I always got an error about window module resolution and I could not get past it. I am using the same config for vite from other extensions and the extension built with it fails to load after installation.

After migrating to vite the openid-client prints out message below
Error: Algorithm "sha256"  not supported. supported values: sha1, md5, passthrough
console.<computed> @ VM5:2
(anonymous) @ VM5:2
emit @ VM4 sandbox_bundle:2
onMessage @ VM4 sandbox_bundle:2

Using suggested plugins to bring back 'sha256' digest did not help.
I sent PR above, that addresses only build speed issue and leaves rollup intact.


feat: improve operations test suite

Motivation

Added internal function for process_execution_payload, improved architecture of test runner.
Description

Tests pass now

Closed pull request to be able to cleanly push new one.
Dividing work in different PR's


Issue with "useDocument"

I don't know what I am doing wrong but according to docs, passing the docRef isn't working!

@T4533N apologies for the slow reply. It looks like you're trying to use hooks on the server side of a Next.js app which is not supported by Next.js


Please support code login function

Baileys already supports logging in through 8-digit codes, and we hope it will be supported!

		const code = await sock.requestPairingCode(phoneNumber)
		console.log(`Pairing code: ${code}`)

No problem, I will add it for session with pairing code.


Visual Studio 2017 and network installs

Added Visual Studio 2017
Added network install feature for offline cache (there is no ISO for Visual Studio 2017)

@sneal what needs to be done by @taliesins to unblock this and get it merged?

@steveruddell We need to fix the RuboCop warnings to the build passes. Ideally we replace RuboCop with cookstyle, similar to what was done here.

@sneal what would you like me to do to get this merged :>

@taliesins The AppVeyor build failed for a few reasons:
Running RuboCop...
Inspecting 31 files
........C.....C.C..............
Offenses:
attributes/vs2017.rb:23:121: C: Line is too long. [137/120]
default['visualstudio']['2017']['install_dir'] = (ENV['ProgramFiles(x86)'] || 'C:\Program Files (x86)') + '\Microsoft Visual Studio 16.0'
                                                                                ^^^^^^^^^^^^^^^^^
attributes/vs2017.rb:120:82: C: Trailing whitespace detected.
default['visualstudio']['2017']['enterprise']['default_install_items'].tap do |h|
                                                                                ^^
libraries/helper.rb:32:121: C: Line is too long. [121/120]
      assert_src_is_not_nil(src, version, edition) unless node['visualstudio'][version][edition]['installer_file'].empty?
                                                                                ^
providers/edition.rb:137:1: C: Cyclomatic complexity for prepare_vs2017_options is too high. [7/6]
def prepare_vs2017_options
^^^
31 files inspected, 4 offenses detected

Would be great to get this PR merged... did you guys want someone to try and look at the rubocop errors?

@ryangribble it would be great if you could help me. I will take pull requests on my pull requests :>
I think I fixed all the easy errors. I am not sure what to do on "Cyclomatic complexity"

The violations i get from my local rubocop are completely different to what appveyor is getting on this PR.  Looks like appveyor setup is using a really old version of chefdk?  I'd need to look into how I could get an old rubocop without affecting my normal work.  Or can we update this repo to support newer standards?

Fixed all rubocop 0.47.1 violations on this PR https://github.com/taliesins/visualstudio/pull/1

Did you have a working example of installing from the network install cache location @taliesins  ?
Im having trouble actually getting this working.
Apart from the fact that I have credential/authentication issues in accessing the UNC location from chef (should this cookbook allow attributes to be specified for user/password and then use a powershell or mount resource to enable access to the location, or is that left up to the consuming users to do before they call the resource from this cookbook?), I also cant seem to actually get chef to try and execute the package installer in-situ from the network location.
When specifying the installer_path as \\\\server,domain\path\to\installer.exe the chef run ends up executing a blank command (eg cmd /c /wait "" --silent etc) and when specifying installer_path as file://server.domain/path/to/installer.exe it seems the package resource attempts to download the exe locally which would then result in it not actually using any of the cached packages on the network share.

What's the status here? can't wait to get VS 2017 support

@ryangribble I added sample usage to read me https://github.com/taliesins/visualstudio/blob/NetworkInstall/README.md
node.override['visualstudio']['version'] = '2017' node.override['visualstudio']['edition'] = 'professional' node.override['visualstudio']['source'] = '' node.override['visualstudio']['2017']['professional']['default_source'] = '' node.override['visualstudio']['2017']['professional']['source'] = '' node.override['visualstudio']['2017']['professional']['filename'] = '' node.override['visualstudio']['2017']['professional']['checksum'] = nil node.override['visualstudio']['2017']['professional']['installer_file'] = '//myartifactrepo/visualstudio/vs_professional.exe'

I'm pretty sure that's what I tried but as I mentioned it uses the remote_file resource which tries to download the installer file and thus isn't running it "in situ" from the network cache location (and therefore doesn't use any of the cached workloads)?

This PR should be broken up into 2 pieces:

Network Install
vs2017 addition

And a rebase -i HEAD~X would do wonder in terms of being able to grok the whole thing. :)

I've gone ahead and made a fork here https://github.com/Roblox/visualstudio that does the vs2017 installs just fine for us.

Great, feel free to make a PR!

Ok I will squash all the commits for just vs2017 installation, I've left out the network installation which I didn't need and I also do not feel should be in the same PR anyway, give me a day or 2 to clean things up.

Cool. And no need to squash the commits if it's extra work. I just look at diffs.

Need to squash the commits to make sense of the changes myself. :D

i agree the network install should be done separately.  i think it could possibly even deserve being a new resource as it is fairly different to the way the online installs are being done

@Sauraus Heya, were you still creating a PR with just the VS2017 installation part?

Yes its on my 'ever' to-do list sorry. :( I will try to make some time in the next 2 weeks.

Gents, what is the status of this PR? I'm looking for VS2017 support.

Sorry! I have had no time to focus on this repo; went from some very intense DevOps to some very intense unemployment, now getting back in the saddle. The build appears to be broken. I will look when I get a chance.

what status is of this changes ? will it be merged successfully into master ?

I will check the PR this weekend! Sorry last time I checked I didn’t see
anything ready to go, then I had to move.
On Tue, Oct 16, 2018 at 3:04 AM yamamoto52<EMAIL_ADDRESS>wrote:

what status is of this changes ? will it be merged successfully into
master ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/windowschefcookbooks/visualstudio/pull/11#issuecomment-430179201,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADpJwkoDmFks0mj_JEiOq5ZgdhB0eRSNks5ula8RgaJpZM4NOU1q
.

--

• Chaim S. Eliyah •*
(c) *+*1.206.331.1311

This message may be privileged under the Electronic Communication Privacy
Act,18 U.S.C.A. §§ 2510-2521. Delete this email if you have received it in
error or are not its original intended recipient, and do not copy any part
of it. Thank you.

We are not in 2019...where is this support?

Haven't tried it but this cookbook looks promising:
https://supermarket.chef.io/cookbooks/vs-2017
https://github.com/btc-ag/chef-vs2017

closing this PR as old and outdated now.


Update Windows Roadmap docs

Just updated the docs.

Thanks for your interest in the project, but we generally do not accept documentation changes unless there are typos or spelling mistakes.

Oh it's okay. I can understand. It was my first contribution to an open source project- Calculator.
Next time, I'll make sure to commit something productive.
Thank-you!!


Test cases for :show_in_app

Added two test cases for :show_in_app similar to :history setup.

Related to fix you submitted last week. Thx.


java.lang.RuntimeException: Attempted to register ID ResourceKey[minecraft:entity_type / minecraft:sheep] at different raw IDs (74, 499)! If you're trying to override an item, use .set(), not .register()!

https://pastebin.com/BHd9Jc1w

I cannot reproduce the crash but I may have a fixed version. Would you be open to testing it?

sure

chonky_sheep-2.1.0.zip
It's uploaded as a zip due to github not allowing .jar files, so you'll need to extract it into your mod folder

I have uploaded a new version on curseforge which should fix this


API: Extend /getCreatedTopicRequests endpoint filters

In https://github.com/aiven/klaw/issues/346 we will introduce a the upgraded version for approving topic requests. The new UX includes the following filters, which should be supported by the API.

I suggest we implement the following filters to the GET /getCreatedTopicRequests API.

ID
Parameter name
Parameter value

1
teamName
Team name (e.g. "Ospo")

2
env
Environment name (e.g. "1")

3
search
Generif search term (e.g. "prod-ecom")

In #346 we will introduce a the upgraded version for approving topic requests. The new UX includes the following filters, which should be supported by the API.

I suggest we implement the following filters to the GET /getCreatedTopicRequests API.
ID	Parameter name	Parameter value
1	teamName	Team name (e.g. "Ospo")
2	env	Environment name (e.g. "1")
3	search	Generif search term (e.g. "prod-ecom")

Hey want to verify this generic 'search' term is going to apply to topicsNames and able to expand later if we find that beneficial.


SharedMutex improve

Purpose

Make unlock_shared fully wait-free
Avoid computing writers size twice
Inline list implementation to keep less instruction in lock critical section

Related Information

[ ] Design document: ...
[ ] Bench PR: ...

Testing

[ ] This change is a trivial rework or code cleanup without any test coverage.
[ ] This change is already covered by existing tests.
[ ] This PR adds tests that were used to verify all changes.
[ ] There are tests in an external testing repository: ...

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

30 of 30 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1741

Relevant Lines:
1741

💛  - Coveralls


Prepare a training dataset for the yield prediction on Starknet lending markets

Description
Yield Aggregation can be done with a predictive component. A strategy manager can use a forecasting model to predict the yield from a given pool in the next time epoch. This prediction in turn impacts the asset allocation of the agent.
The first step in introducing this capability is creating a training dataset for the yield prediction algorithm. This dataset should be composed of publicly available data sources, ideally onchain. This is required for the agent to be able to fetch the newest onchain data and make a prediction based on it.
The target variable should be the APY in the next time epoch (e.g. on the next day/week).
Submission
Please create a PR in this repo with a functioning data fetching and processing pipeline, ideally using python for a streamlined integration with the Giza Agent.

I'm interested: you can contact me using https://t.me/loubnamslk

i am intrested in this anyway but would want to get more details on how to get the dataset


Calicoctl doesn't work with non default Docker configuration

I added an entry to docker.cfg to change the default output of "docker ps"
"psFormat":"table {{.ID}}\t{{.Names}}\t{{.Image}}\t{{.RunningFor}}"
Calicoctl now fails.
calicoctl
Traceback (most recent call last):
File "", line 64, in
File "/usr/local/lib/python2.7/site-packages/PyInstaller/loader/pyimod03_importers.py", line 389, in load_module
File "calico_ctl/bgp.py", line 38, in
File "/usr/local/lib/python2.7/site-packages/PyInstaller/loader/pyimod03_importers.py", line 389, in load_module
File "calico_ctl/connectors.py", line 44, in
File "site-packages/docker/client.py", line 56, in init
File "site-packages/docker/auth/auth.py", line 182, in load_config
File "site-packages/docker/auth/auth.py", line 118, in parse_auth
TypeError: string indices must be integers
calicoctl returned -1

Hi @MatMeredith,
I've created a config file at ~/.docker/config.json with the contents:
{
"psFormat":"table {{.ID}}\t{{.Names}}\t{{.Image}}\t{{.RunningFor}}"
}

And ran calicoctl without issues.
What version of Docker/Claicoctl were you using? What else does your config file have?

In answer to your questions…

     Docker version 1.9.0, build 76d6bc9

     Calicoctl 0.17.0-dev

Box is installed using a modified version of the Vagrantfile from the “Vagrant install with Ubuntu” option here: https://github.com/projectcalico/calico-containers/tree/master/docs/calico-with-docker/docker-network-plugin (albeit not quite the latest version).   Changes are just to add additional packages – I think all of the Calico / Docker setup is unchanged from the original.
Sample output from calicoctl with and without config.json below.   Also contents of config.json.
Mat

vagrant@tiger-01:~$ calicoctl
Override the host:port of the ETCD server by setting the environment variable
ETCD_AUTHORITY [default: <IP_ADDRESS>:2379]
Usage: calicoctl  [...]
status            Print current status information
node              Configure the main calico/node container and establish Calico networking
container         Configure containers and their addresses
profile           Configure endpoint profiles
endpoint          Configure the endpoints assigned to existing containers
pool              Configure ip-pools
bgp               Configure global bgp
ipam              Configure IP address management
checksystem       Check for incompatibilities on the host system
diags             Save diagnostic information
version           Display the version of calicoctl
config            Configure low-level component configuration

See 'calicoctl  --help' to read about a specific subcommand.
vagrant@tiger-01:~$ mv ~/.docker_old ~/.docker
vagrant@tiger-01:~$ calicoctl
Traceback (most recent call last):
File "", line 64, in
File "/usr/local/lib/python2.7/site-packages/PyInstaller/loader/pyimod03_importers.py", line 389, in load_module
File "calico_ctl/bgp.py", line 38, in
File "/usr/local/lib/python2.7/site-packages/PyInstaller/loader/pyimod03_importers.py", line 389, in load_module
File "calico_ctl/connectors.py", line 44, in
File "site-packages/docker/client.py", line 56, in init
File "site-packages/docker/auth/auth.py", line 182, in load_config
File "site-packages/docker/auth/auth.py", line 118, in parse_auth
TypeError: string indices must be integers
calicoctl returned -1
vagrant@tiger-01:~$ ls ~/.docker
config.json
vagrant@tiger-01:~$ cat ~/.docker/config.json
{
"psFormat":"table {{.ID}}\t{{.Names}}\t{{.Image}}\t{{.RunningFor}}"
}
From: Timothy Briggs<EMAIL_ADDRESS>Sent: 23 March 2016 22:37
To: projectcalico/calico-containers
Cc: Matthew Meredith
Subject: Re: [calico-containers] Calicoctl doesn't work with non default Docker configuration (#884)
Hi @MatMeredithhttps://github.com/MatMeredith,
I've created a config file at ~/.docker/config.json with the contents:
{
"psFormat":"table {{.ID}}\t{{.Names}}\t{{.Image}}\t{{.RunningFor}}"
}
And ran calicoctl without issues.
What version of Docker/Claicoctl were you using? What else does your config file have?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com/projectcalico/calico-containers/issues/884#issuecomment-200570904

We use the docker client now instead, so closing this.


[question] AES GCM — iv length

It looks like the iv length is defaulting to 16 bytes
From this discussion, it seems 12 bytes is preferable.
Thoughts about this?

Yes. It's better to have an iv length of 12 with AES-GCM.
This library has a bunch of suboptimal defaults - e.g. around utf8 vs. utf16 encoding, too.
We moved away from it during the time at fission and spent effort on the rust parts instead (so mostly rs-wnfs).
If one wanted a good library like this today, I'd recommend just going with uint8arrays, localforage + the WebCrypto API directly.


Create Podspec File

@Titozzz can you please remove the JS changes a keep the podspec only? Thanks.

Podspec is merged (#389) into master and will be available in the next release.


Change landing page text to broaden geographic domain

Simple modification of existing text. Good first issue.

The Acartia landing page has a modal in the upper right corner containing text. As a public (unauthenticated) user, I want the text to be changed from "within the Salish Sea" to "within the Salish Sea and across coastal Cascadia" in order to accurately describe the geographic domain of the data cooperative.

Here's what the modal currently looks like (screen grab today):

Hey scottveirs, still need help with this? I'd like to contribute

Sure, Henry! Feel free to try out the code. I can help if documentation needs adjusting. @peterdouglas may have time between PhD tasks down under to answer dev questions.

Also @hnrywltn -- if you zoom on from the default Acartia map, as a dev based in SF you may enjoy looking through the marine mammal observations in/near the Bay Area

!

Transfered to forked repo here, so closing.


Bukkit permissions.yml issues

apply-wildcards: true

Wildcards don't apply from within bukkits permissions.yml

Example: if you gave a group the user.worldguard permission below, they would get the claim and wand permission, but not the info permissions.
user.worldguard:
  default: false
  children:
    worldguard.region.claim: true
    worldguard.region.wand: true
    worldguard.region.info.*: true

apply-bukkit-default-permissions: false

This setting in LuckPerms config seems to be ignored. Default permissions apply regardless of this setting and seem to ignore the "default: op" setting as well.

Example: Having these parent nodes in permissions.yml, with the above setting on true or false, would  prevent the console being able to use the version command, with lp verbose returning:
[LP] VB > internal/console - bukkit.command.version - false
all.bukkit:
 default: true
 children:
   bukkit.command.version: false

op.bukkit:
 default: op
 children:
   bukkit.command.version: true

Version Info
> lp info
[16:10:01 INFO]: [LP] Running LuckPerms v5.1.16 by Luck.
[16:10:01 INFO]: [LP] -  Platform: Bukkit
[16:10:01 INFO]: [LP] -  Server Brand: Paper
[16:10:01 INFO]: [LP] -  Server Version:
[16:10:01 INFO]: [LP]      git-Paper-282 (MC: 1.15.2) - 1.15.2-R0.1-SNAPSHOT
[16:10:01 INFO]: [LP] -  Storage:
[16:10:01 INFO]: [LP]      Type: MySQL
[16:10:01 INFO]: [LP]      Ping: 2ms
[16:10:01 INFO]: [LP]      Connected: true
[16:10:01 INFO]: [LP] -  Messaging: Sql
[16:10:01 INFO]: [LP] -  Instance:
[16:10:01 INFO]: [LP]      Static contexts: server=survival
[16:10:01 INFO]: [LP]      Online Players: 0 (0 unique)
[16:10:01 INFO]: [LP]      Uptime: 2h 53m 2s
[16:10:01 INFO]: [LP]      Local Data: 0 users, 14 groups, 5 tracks

Luckperms does not, to the best of my knowledge, have any power in the realm of bukkit's permissions.yml. As such, Luckperms options will not apply there.
Ya know, the whole point of Luckperms is a replacement / more configurable and powerful alternative to that permissions.yml file, which is incredibly limited in capability, as you point out in the issue.
Luck will be able to tell you why what is happening is happening (probably) but regardless, the permissions yml file is not under the control of LP, and shouldn't really be functional or expected to be doing things with two permissions systems.

apply-wildcards: true - Wildcards don't apply from within bukkits permissions.yml

This is intended.

Example: Having these parent nodes in permissions.yml, with the above setting on true or false, would prevent the console being able to use the version command, with lp verbose returning:
[LP] VB > internal/console - bukkit.command.version - false

LuckPerms doesn't touch the console's permissions - it only manages permissions for players.
I could potentially add a configurable override for the console (make it always have all permissions) if that would be useful?


Add a no-short-mac FIPS indicator

KMAC is not permitted to produce less than 32 bits of output as per SP 800-185 8.4.2.  This change enforces this.
HMAC is also subject to the same limitation but our implementation only outputs the digest block size.

[x] documentation is added or updated
[x] tests are added or updated

Are the test failures valid?

Still digging into the test failures.  They appear to be in CMS and are failing on master.  At least mostly.

Test failures are not caused by this PR.

When merging any of these indicator PR's we need to very careful with anywhere where we are changing  fixed arrays sizes. Multiple PR's are all hitting these same arrays - so there WILL be merge issues where the size needs to increase,

(I know changing to OSSL_PARAM_BUILD might fix this, but it is too late to do that change now - and seems like overkill)

ping for review @openssl/committers

Added a changes entry and resolved the naming difference.
Reconfirmation please.
Don't see a need for a timer reset.

Attribution fixed and rebased to remove conflicts.

Hmm, CI failed at Provider compatibility for PRs / development-branches (PR, PR.tar.gz)

@slanterns Paul has fixed CHANGES.md - I would re-confirm but for the failing CI - is this expected? If so, consider this a reconfirmation

24 hours has passed since 'approval: done' was set, but as this PR has been  updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

@slanterns Paul has fixed CHANGES.md - I would re-confirm but for the failing CI - is this expected? If so, consider this a reconfirmation

Hmm, I have no idea on why do you mention me?

The failing CI was a result of a different problem which has been merged now.
This results in some versioning problems appearing.

Got the tests passing.  Reapprovals required (again).

Merged resolving trivial conflicts.
Didn't reset timer for the minor test case changes.
Thanks for the feedback.


Encountered a Dart Analysis Server error.

Analyzer Feedback from IntelliJ
Version information

IDEA WS-172.4343.25
1.24.2
WS-172.4343.25, JRE 1.8.0_152-release-915-b12x64 JetBrains s.r.o, OS Windows 10(amd64) v10.0 , screens 1366x768

Exception
Please append the contents of:
file://C:\temp\report.txt
Dart analysis server, SDK version 1.24.2, server version 1.18.0, FATAL error: Failed to handle request: {id: 3, method: analysis.setAnalysisRoots, params: {included: [D:\WebSpace\DartDemo], excluded: [D:\WebSpace\DartDemo\.idea, D:\WebSpace\DartDemo\.pub, D:\WebSpace\DartDemo\.tmp, D:\WebSpace\DartDemo\build, D:\WebSpace\DartDemo\temp, D:\WebSpace\DartDemo\tmp]}, clientRequestTime:<PHONE_NUMBER>420}
NoSuchMethodError: The getter 'analysisOptions' was called on null.
Receiver: null
Tried calling: analysisOptions
#0      Object._noSuchMethod (dart:core-patch/object_patch.dart:43)
#1      Object.noSuchMethod (dart:core-patch/object_patch.dart:47)
#2      ContextManagerImpl._updateContextPackageUriResolver (package:analysis_server/src/context_manager.dart:1710)
#3      ContextManagerImpl._recomputeFolderDisposition (package:analysis_server/src/context_manager.dart:1665)
#4      ContextManagerImpl._handleWatchEvent (package:analysis_server/src/context_manager.dart:1417)
#5      _rootRunUnary (dart:async/zone.dart:1128)
#6      _CustomZone.runUnary (dart:async/zone.dart:1012)
#7      _CustomZone.runUnaryGuarded (dart:async/zone.dart:909)
#8      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:330)
#9      _BufferingStreamSubscription._add (dart:async/stream_impl.dart:257)
#10     _ForwardingStreamSubscription._add (dart:async/stream_pipe.dart:132)
#11     _ForwardingStream._handleData (dart:async/stream_pipe.dart:98)
#12     _ForwardingStreamSubscription._handleData (dart:async/stream_pipe.dart:164)

I suspect this was fixed as part of https://github.com/dart-lang/sdk/issues/27983.