[Feature/extensions] Add Action for Validate detector API call

Signed-off-by: Frank Lou<EMAIL_ADDRESS>Description
Create an action implementing ExtensionRestHandler with routes for the Post detector API calls.
Issues Resolved
Fixes https://github.com/opensearch-project/opensearch-sdk-java/issues/221
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mloufra @owaiskazi19 build is failing due to changes in (merged) SDK PR #253 that have not yet been merged here in #725.  Hopefully when #725 is merged this will pass.

Codecov Report

Merging #732 (4ca48de) into feature/extensions (fa81e2e) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@                   Coverage Diff                    @@
##             feature/extensions     #732      +/-   ##
========================================================
- Coverage                 53.35%   53.29%   -0.06%
  Complexity                 2658     2658
========================================================
  Files                       290      291       +1
  Lines                     16056    16067      +11
  Branches                   1686     1687       +1
========================================================
- Hits                       8566     8563       -3
- Misses                     6872     6886      +14
  Partials                    618      618

Flag
Coverage Δ

plugin
53.29% <0.00%> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...va/org/opensearch/ad/AnomalyDetectorExtension.java
0.00% <0.00%> (ø)

...opensearch/ad/rest/RestValidateDetectorAction.java
0.00% <0.00%> (ø)

.../java/org/opensearch/ad/AnomalyDetectorRunner.java
36.90% <0.00%> (-5.96%)
:arrow_down:

...ava/org/opensearch/ad/model/TimeConfiguration.java
100.00% <0.00%> (ø)

...c/main/java/org/opensearch/ad/util/ParseUtils.java
60.57% <0.00%> (+0.14%)
:arrow_up:

...opensearch/ad/indices/AnomalyDetectionIndices.java
40.21% <0.00%> (+0.21%)
:arrow_up:


dashboard button press doesn't work as expected

I'm currently trying to figure out why selecting a button and pressing Enter key is not working
I get a E21: Cannot make changes, 'modifiable' is off instead
config
local alpha = require("alpha")
local dashboard = require("alpha.themes.dashboard")

dashboard.section.buttons.val = {
  dashboard.button("SPC f f" , "  Find file", ":Telescope find_files hidden=true no_ignore=true<CR>"),
}

alpha.setup(dashboard.config)

The weird thing is that if used
dashboard.button("<leader>ff" , "  Find file", ":Telescope find_files hidden=true no_ignore=true<CR>")

instead, then pressing enter key works.

NOTE: I also have <leader>ff keymapped using
leader is <space>
vim.api.nvim_set_keymap("n", "<leader>ff", ":Telescope find_files hidden=true no_ignore=true<cr>", { noremap = true, silent = true } )

Found the cause of problem
https://github.com/goolord/alpha-nvim/blob/534a86b348b741ada5bb0d4b83c2c3da6763352a/lua/alpha/themes/dashboard.lua#L53
sc should be changed to sc_
sc will contain raw string. Ex: SPC ff
sc_ is the formatted string. Ex: <leader>ff
It's the same for startify
https://github.com/goolord/alpha-nvim/blob/534a86b348b741ada5bb0d4b83c2c3da6763352a/lua/alpha/themes/startify.lua#L47

goood catch, i must have messed this up at some point when reverting some changes recently. thanks

https://github.com/goolord/alpha-nvim/commit/d54ce84559ee50500a1133d1c58daf9cd715525b

I have the same issue now @goolord any way to fix it? It happens when I update to nvim nightly NVIM v0.8.0-dev-971-g3e0c262a6

what does your config look like? works fine on my machine

nvm @goolord , I  found the issue. I used this code
 button("h", "  Hapoon File  ", ":lua require('harpoon.ui').toggle_quick_menu()<cr>"),
which cause the bug -> change to   button("h", "  Hapoon File  ", "<cmd>lua require('harpoon.ui').toggle_quick_menu()<cr>") and it works fine


chef-client fails to start on sles 10 with floating point exception.

This issue is already in jira and in the state confirmed. Url given below.
https://tickets.opscode.com/browse/CHEF-4892?page=com.googlecode.jira-suite-utilities:transitions-summary-tabpanel
Actual issue: Installation goes well. If i try to start chef-client after installation it says Floating point exception and comes out.
Is there any workaround for us to make it work on sles 10?

There is no workaround and no plans to support SLES 10 with omnibus packages.  I suspect that we never will support it.

I got a workaround..Ruby is installed outside chef , installed the required gems for chef and pointed chef to the new ruby. I tested with a small recipe to create a file and it worked well. But not sure whether this setup will support all chef resources.


[api-docs] Update past date to past tense in GameSDK Store docs

A new commit was made into the api-docs repo. This issue was created automatically. Need to review if we made any change to the library for this commit.
https://github.com/discord/discord-api-docs/commit/4dfcf2d3dc3c94ccb620cf9a800b11f1b71e1777

ncn


Versioned CBOR

Started new package cardano-ledger-binary:
This package introduces new Encoding and Decoder wrappers that can change their behavior depending on a version, which corresponds to major protocol version. This package introduces new conceptws and consolidates all the old ones that were spread around different packages:

Introduced Version in its own module and make it safe to construct
Switch from ReaderT to manual Version passing to recover      representational role
All decoders and encoders as well as FromCBOR/ToCBOR classes      from cardano-binary package
Re-exports Annotator functionality from cardano-binary package,      with plans to migrate it completely in the future
Moved dropper from cardano-binary
Test suites from cardano-binary and cardano-data as vintage test      suites
FromSharedCBOR from cardano-data package
Data.Coders module from cardano-data package
Data.Twiddler module from cardano-data package into a test-lib
Improved Roundtripping tests and sophisticated way to display CBOR      encoded blobs that was transferred from ouroboros-consensus repo.
Custom decoders/encoders from Cardano.Ledger.Serialization module      from cardano-ledger-core package
Implement round trip test for all To/FromCBOR instances. Discovered      major bug with SlicedByteArray and fix it in cborg package:      https://github.com/well-typed/cborg/pull/301

Note that this PR resolves https://github.com/input-output-hk/cardano-ledger/issues/3014

Yes, it does, except only the first half of it. This PR only implements the library that is capable of versioned CBOR. A subsequent PR will be submitted that actually applies this new interface throughout ledger.


get username from oauth2_proxy and forward this to protected backend

Hi, is there a way to get username from oauth2_proxy and forward this to protected backend as basic auth or X-header?

https://bl.duesterhus.eu/20180119/#1.1.6

Headers are forwarded as:
"X-Forwarded-Email": [
<EMAIL_ADDRESS>],
"X-Forwarded-User": [
"xyz78"


Support configuration of key trust values.

Close #14 through an initial implementation of trust values.

Would love to see support for this. @n1tr0g - anything I can do to help this along?


Fix expected params for createSource in README

Summary & motivation

stripe.createSource requires type being passed in, but our README did not reflect this.
See https://github.com/stripe/react-stripe-elements/issues/253#issuecomment-426154651 for reference.
Testing & documentation

Manual.

LGTM

We don't cut new releases for docs changes, so no further action necessary.


models don't load with connecter enabled

Describe the bug
models don't load with connecter enabled
Steps to reproduce

load my modpack
2.start game and models don't load

...
Logs
No response
Additional context
latest.log
logs are here

its Ducklib

https://www.curseforge.com/minecraft/mc-mods/duclib adds entity models and animations that are unlike java models

i don't have a mod called duclib

"Mixin config duclib.mixin.json does not specify "minVersion" property"

is that the issue tho?

its a guess, with the context of models not rendering and that being the first error, its just a hunch, however I am not 100% sure. You should do a debug log

theres also alot of supplementaries, moonlight in it, or doggy talents

i have been using them before and no problom happens its only when i enable this mod

it'd be helpful for the dev to know which mod is causing the issue. All these mods I have said are guesses so you can determine which one is the one conflicting it. Which is why you should do your part in trying get it to solved.

It started happening after this update

The new update

Which mods exactly are required to reproduce this issue?

so i am using a big modpack so i will just send you the link to the file since i can't send it here casue its big

https://legacy.curseforge.com/minecraft/modpacks/wilderness-odyssey/files/4809326 this is it

That link may not work give me a sec

Please use binary search or otherwise track down the exact mod(s) causing the issue

Closing as cannot reproduce


Recover items placed in NPC when player is disconnected

Resolves: https://github.com/MUnique/OpenMU/issues/534
Notes:

[x] Chaos Goblin Failed mix - can not be recovered
[ ] Chaos Goblin Successful mix - new item can not be recovered

Can be handled in another issue/PR (?)
Options:

Restore items before mixing (all the ingredients are recovered)
Automatically place the successful item in the first slot that can fit the item

[x] Jerridon (JOH restore)

When trying to disconnect after a failed/successful mix:
2024-12-22 03:08:23.255 +08:00 [Error] [MUnique.OpenMU.GameServer.GameServer] Couldn't Save at Disconnect. Player: "0 - [Server 0]"
Microsoft.EntityFrameworkCore.DbUpdateConcurrencyException: The database operation was expected to affect 1 row(s), but actually affected 0 row(s); data may have been modified or deleted since entities were loaded.


Investigate if it makes sense to have the builder generated

It might make sense to have the builder generated with something like sundrio.
Some benefits I see:

Reduce boilerplate
Support for nesting (e.g. with ContainerEntry etc)
Align with the rest of the ecosystem
Visitors (?)

I also see points, where it might not make sense:

Relatively small number of classes and properties
Custom logic (passing a logger to build)
The build process has sideffects (not just a building a pojo).

Eitherway, let's have a look and see what's best for the project

Builders are now properly generated.


"Not authorized" error when trying to login to Home Assistant app externally

I don't think this is a bug in your code but hoping you can help me out.
I'm running Traefik and Home Assistant in docker containers. Bridge networking with HA behind Traefik (of course).
I have crowdsec bouncer & geoblock middleware add-ons enabled on HA service. This works as expected externally with browser & HA app.
When I add your google-oidc-auth middleware add-on externally HA in browser works as expected but when using the app the browser opens and ends with "Not authorized". I believe this page is presented by HA but I've been unable to see anything in either Traefik or HA logs with an error.
URL that is opened by HA app:
https://hostname.duckdns.org/oidc/callback?state=13c2ef0266fb05d1105b2c532bc4f42f&code=4%2F0AeaYSHAWFHd98dvaNRX1BiQrqgvzNdcyqvI7OFgbo9koZQ_APndDH0ZjyNLCZqTgXuaf9A&scope=email+openid+https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fuserinfo.email&authuser=0&prompt=none
I should also note that I have added traefik's interface accessible to HA to the trusted proxies list in HA's configuration.yaml file. As well as cleared any cookies during testing.
Any thoughts or suggestions?

HA in browser works as expected but when using the app the browser opens and ends with "Not authorized"

I haven't tried this myself, but from my some reading it appears to be known issue with HA ^1 ^2. Are you using the Android or IOS apps?
My guess is that the native apps for Home Assistant are not honoring the redirects issued by the proxy or are not persisting the cookie that is set by the proxy the proves you're authorized. If you add debug: true into this middleware's config you might get a little bit more logging.
My ideal user flow would be to have Home Assistant use the X-Forwarded-User header that is set by this middleware to bypass the authentication on the HA side. That is similar to what BeryJu/hass-auth-header provides but it seems the apps don't work.

Thanks for your reply.
I'm using the Android app.
I've read about the authentication discussions in Home Assistant. I should have specified I don't expect this to log me into HA with user mapping. But function as a first step login and require me to login to HA after this passes me to the app. This is how using the browser works currently (externally). It's just the app that seems to have difficulties.
I've enabled debug: true through label on the HA container but don't see any extra log data aside from my crowdsec bouncer and geoblock log entries.
"traefik.http.middlewares.googleoauth-homeassistant.plugin.googleoauth.debug=true"
I agree with your ideal user flow but for now would be happy with it working as a secondary login step.

https://github.com/andrewkroh/google-oidc-auth-middleware/assets/4565752/01a30930-1e6b-4ebf-b7be-aeb3f5863efb
I tried it using the IOS app. It looks like the app opens an iframe to handle the redirect to Google, but when Google redirects back it keeps the iframe open. It would redirect back into the native app without the iframe (e.g. redirect to homeassistant://auth-callback), b/c this is where the CSRF protection cookie should present. That cookie is necessary to complete authentication.
But in order to redirect to an app you would need to use a different type of oauth flow (https://developers.google.com/identity/protocols/oauth2/native-app) and different Google oauth credentials. Otherwise, with the standard web app flow you cannot redirect out of the iframe and back to the app since Google will disallow you to setup a redirect_uri for homeassistant://auth-callback.
You would probably need to run a dedicated middleware for the app flow since it uses different oauth creds. Additionally this middleware would need to construct the redirect URI differently than it does today. Currently it builds the URI based on the browser's requested scheme (https or http) and the host name in the request. It would need a config option to say to use homeassistant://auth-callback.
And all of that assumes that if the iframe did redirect back to the app that it just work from there, and that seems like a long shot. So I don't think this is easy to do without some proper support from the HA app.

Wow thanks for the detailed testing & explanation. Way over my head. I have some learning to do as I get time but it sounds like I'm better to disable this auth middleware for this service for now.
Thank you so much for your time looking into this for me. I very much appreciate it!


Organize OCA Bundle folders for Mines Act Permits versions

Signed-off-by: Stephen Curran<EMAIL_ADDRESS>

@Jsyro -- please see the tweaks I made to better organize the Mines Act Permit OCA Bundle versions.  I think this is a little easier to work with.  Please confirm this is how you would like the folders/bundles organized.
@wadeking98 @cvarjao -- Note that in this PR, the location of the OCABundles for the Mines Act Permit will move. As such, wallets with the "ocabundles.json" already loaded will have the wrong path, and will not find (get a 404) the OCABundles.json files for the Mines Act Permit IDs -- even though they are in JSON list. Once they reload this file and get the new paths, the OCABundle.json will work resolve properly.
Question for you is what triggers a wallet to retrieve the ocabundles.json file?  Worst case is that there is no branding on the credentials.
FYI: I'll be putting another PR Real Soon Now to add the SHA256 to the ocabundles.json file.

Will do.


[SPARK-39930][SQL] Introduce Cache Hints

What changes were proposed in this pull request?

This ticket intends to add query hints for cache behaviors, users can perform actions like the use/skip/cache/uncache, etc on the cached results by the following hints.

RESULT_CACHE: spark will use cache by default, this hint keeps this behavior but will cache the child plan if uncached yet.

NO_RESULT_CACHE:with this hint, we can skip the default behavior to bypass the cached data if it is cached

RESULT_UNCACHE: with this hint, we can remove the cached data.

RESULT_CACHE and NO_RESULT_CACHE are borrowed from oracle, FYI,https://docs.oracle.com/database/121/TGDBA/tune_result_cache.htm#TGDBA647., while RESULT_UNCACHE's added accordingly via the naming rule.
Similar ideas can also be found in MySQL, FYI https://dev.mysql.com/doc/refman/5.7/en/query-cache-in-select.html
Maybe we can add more cache hints like RESULT_RECACHE to refresh the cached data, or maybe some cache behaviors that relate to metadata.
Why are the changes needed?

As a supplement for CACHE/UNCACHE commands, pure SQL users can operate the cache in their queries directly without extra definitions. Also, cache skipping is supported by hints.
Does this PR introduce any user-facing change?

yes, this PR brings some new hints
How was this patch tested?

new tests for ut

test dist by hand

cc @cloud-fan @MaxGekk @HyukjinKwon @wangyum, PTAL when you have time.

I like the idea.

To close the loop: CACHE TABLE abc AS SELECT id from range(0,1) should be sufficient. If it fails with view already exists, we can either rerun it with a different name, or drop the temp view first.

For a multi-tenant scenario like Thrift Server, if we explicitly cache/uncache some plans or relations, it will affect other's request


initialization of the EVQE population with more than one circuit layer

Initialization with more than one circuit layer, may help by initializing the individuals in more complex states. This can help avoid local minima. Closes #26

Please add entry to changelog.

I added the changelog entry.


Not Able to open ML and Android Courses from the Courses Dashboard

When opening the ML Ops and Android Development Courses It redirects to 100xdevs.com and we have to login again
also not  able to access this courses from app.100xdevs.com dashboard.
we can access the other courses.
below video shows the issue:-
simplescreenrecorder-2024-03-04_18.59.03.webm

Dude, They've provided the content in harkirat.classx.co.in , if you are part of the cohort, you can access the content from the view content button of that course button, and then access it from there wherever the ML Ops/ And. dev. course is written.

hey, this repo supports for app.100xdevs.com only!!!

Yeah,I know we can access it from harkirat.classx.co.in but if we see to access the courses from app.100xdevs.com then it should be accessible from there also.
It's easy to open those courses from app.100xdevs.com
It's just my thought

you can access it from app.100xdevs.com @akshayK2021
Can u mention ur issue more clearly

I have attached the video above plz refer to that,
After clicking on view courses it doesn't open the content of courses for ML and Android it navigate us to harkirat.class.co.in and we are logged off. You can see the issue in attachment.


feature: document aternative way to build CSS in isolation and not with CSS imports from JS

Do you want to request a feature or report a bug?
Feature

What is the current behavior?
The documentation of webpack explains only one method for loading CSS, the one with CSS import from Javascript.
https://webpack.js.org/guides/asset-management/#loading-css
As discussed here,
https://www.sitepoint.com/community/t/webpack-what-do-you-think-of-this-way-building-css-and-javascript-separately/284349
there is another method. Not worse or better. It depends of what one prefers.
I would like to resolve this issue by documenting in short the existence of another method. This issue is about updating the documentation.
The other method:
It is possible to build CSS in isolation, without CSS imports from Javascript, with the benefits of:

faster build time with the potential to parallelize more with parallel-webpack, because Javascript does not need to be parsed to parse the SASS/CSS.
following the SASS tradition (see link above)
separate configs (hard to understand but no source-maps in ES6 Javascript, while keeping source-maps for SASS wins me 2s build time), and

If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?
Document in short that there is another method. Here is a suggestion. It must be short because people will have a hard time to agree. Or small details may not be supported (like using a dummy js file with an import to the global css file). Forget the details. Just say to people it is possible.
Suggestion:
"Although it is not the official way, it is possible to bundle CSS in isolation without CSS imports from Javascript. It can be useful to speed up the build with parallel-webpack, or to follow the tradition of CSS."
If this is a feature request, what is motivation or use case for changing the behavior?

It can be very useful for people to know there is another way. I regret I could not find it there in the first place.
The webpack community may see a new way, and the update of this documentation may raise new ideas for webpack to speed up build time in a simple way.

Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.

One of webpacks core concepts is the idea of one dependency graph with all modules (js + css). Building CSS in isolation sounds like a step backwards to me. I won't recommend this as official way.
In addition to this, it's weird to use webpack when building SASS in isolation. In this case just to a task runner to build sass i. e. gulp...

One of webpacks core concepts is the idea of one dependency graph with all modules (js + css). Building CSS in isolation sounds like a step backwards to me. I won't recommend this as official way.

Fine. Just curious: is it possible to parallelize builds, as parallel-webpack does, with all modules loaded together? How can it work in parallel since Javascript needs to import CSS from many files?

In addition to this, it's weird to use webpack when building SASS in isolation. In this case just to a task runner to build sass i. e. gulp...

When building SASS in isolation, it is simpler to use webpack for all builds. Otherwise, one needs to download gulp and to learn gulp.


Refusing to install angularfire2 as a dependency of itself

I'm trying to follow the installation instructions.
I've done this task before, but now it fails in the application directory.
Despite the fact that it works (installation) on the parent directory, the angularfire2 module is not found by the compiler neither by VisualStudio.
Obs:
I reinstalled everything and still doesn't work!
Version info
Obs:
I reinstalled everything and still doesn't work!

ng - v
angular-cli: 1.0.0-beta.19-3
node: 6.9.1 and 6.9.4
os: win32 x64
npm -v npm -v
4.0.1 / 4.1.2

How to reproduce these conditions
npm install angularfire2 firebase --save
Debug output
PS C:\Projetos\lab\angularfire2> npm install angularfire2 --save
npm ERR! Windows_NT 10.0.14393
npm-debug.log.txt
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "install" "angularfire2" "--save"
npm ERR! node v6.9.1
npm ERR! npm  v4.0.1
npm ERR! code ENOSELF
npm ERR! Refusing to install angularfire2 as a dependency of itself
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     https://github.com/npm/npm/issues
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Projetos\lab\angularfire2\npm-debug.log

I'm really dumb!!!! It's so embarrassing to me!
I changed the project´s name and worked fine!!
Sorry!

Thanks for change the message!

:)
Refusing to install package with name "angularfire2" under a package
also called "angularfire2". Did you name your project the same
as the dependency you're installing?

When you have the "package.json" with project "name" attribute exactly same as the name of dependency you required to install you will face this issue.


meta: use new metadata

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a505142) 82.68% compared to head (54923a4) 82.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
- Coverage   82.68%   82.61%   -0.08%
==========================================
  Files          47       47
  Lines        3847     3848       +1
==========================================
- Hits         3181     3179       -2
- Misses        536      539       +3
  Partials      130      130

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


IS-18001: Switch file ecoding to utf-8 from utf-8-sig

Ref IS-18001

@mMaydew something on the way for this?


[11.x] Add toFilled Helper Function for Array Manipulation

This pull request introduces a new helper function toFilled to the Laravel framework. The toFilled function provides a convenient way to fill a portion of an array with a specified value, allowing for customizable start and end indices. This addition enhances array manipulation capabilities within Laravel applications.
Functionality
Signature
function toFilled(array $arr, $value, int $start = 0, int $end = null): array

Parameters

array $arr: The original array to be modified.
$value: The value to fill the array with.
int $start: The index to start filling from (can be negative, defaults to 0).
int $end: The index to stop filling at (can be negative, defaults to the length of the array).

Behavior

Fills the array from the start index to the end index with the specified value.
Handles negative indices by converting them to positive indices relative to the array's length.
Leaves the original array unmodified.

Benefits

Improved Array Manipulation: Simplifies the process of filling parts of arrays with a specified value.
Enhanced Readability: Provides a clear and concise method for array manipulation tasks.
Consistency: Integrates with existing Laravel functionality and conventions.

This addition aligns with Laravel's commitment to providing useful and expressive tools for developers.
Examples
$array = [1, 2, 3, 4, 5];

// Fill from index 2 to end
$result = Arr::toFilled($array, '*', 2);
// Result: [1, 2, '*', '*', '*']

// Fill from index 1 to 4
$result = Arr::toFilled($array, '*', 1, 4);
// Result: [1, '*', '*', '*', 5]

// Fill entire array
$result = Arr::toFilled($array, '*');
// Result: ['*', '*', '*', '*', '*']

// Fill with negative indices
$result = Arr::toFilled($array, '*', -4, -1);
// Result: [1, '*', '*', '*', 5]

How about naming the method as Arr::fill()?

What about:
public static function fill(array $array, $value, $start = 0, $end = null)
{
    if ($array === []) {
        return [];
    }

    $count = count($array);
    $end ??= $count;

    $start = $start < 0 ? max(0, $count + $start) : min($start, $count);
    $end = $end < 0 ? max(0, $count + $end) : min($end, $count);

    if ($start > $end) {
        return $array;
    }

    if ($start === 0 && $end === $count) {
        return array_fill(0, $count, $value);
    }

    return array_replace($array, array_fill($start, $end - $start, $value));
}

Does it work when $start === $end?

toFilled imho is not a clear name. especially as you describe it as array_fill(0, 5, '*') but basically replace values with a value between two indices.

i wont allow this sorry

Can you these two more assertions? To make usage clearer and prevent future changes:
var_dump(Arr::toFilled($array, '*', 1, 1) === [1, 2, 3, 4, 5]);
var_dump(Arr::toFilled($array, '*', 1, 2) === [1, '*', 3, 4, 5]);

Seems super complicated code that needs to be maintained and the use-cases are very limited

How about naming the method as Arr::fill()?

Will rename it like so if it is available

Seems super complicated code that needs to be maintained and the use-cases are very limited

The code itself is not really complicated and the use-case is not very limited. This kind of feature have been part of the es-toolkit for a while and I have personally been using such helper for many use-cases

@newQuery Care to explain a few use-cases?

Can you these two more assertions? To make usage clearer and prevent future changes:
var_dump(Arr::toFilled($array, '*', 1, 1) === [1, 2, 3, 4, 5]);
var_dump(Arr::toFilled($array, '*', 1, 2) === [1, '*', 3, 4, 5]);

I have added this two assertions to the test file

@newQuery Care to explain a few use-cases?

Filling a portion of an array with a specific value:
Let's say you have an array of integers and you want to replace all values between indices 2 and 5 (both inclusive) with the number 7. You can achieve this like so:
$arr = [1, 2, 3, 4, 5, 6]; print_r(ArrayHelpers::fill($arr, 7, 2, 5));
Output:
Array (     [0] => 1     [1] => 2     [2] => 7     [3] => 7     [4] => 7     [5] => 6 )
In this case, the fill method replaces values at indices 2, 3, and 4 with 7, leaving the other indices untouched.
Replacing all elements in an array with a specific value:
If you want to replace every element in an array with a single value (for example, setting all ages to -1 because they are unknown), you can use your method like this:
$arr = [30, 25, 'unknown', 40]; print_r(ArrayHelpers::fill($arr, -1));
Array (     [0] => -1     [1] => -1     [2] => -1     [3] => -1 )

@newQuery Care to explain a few use-cases?

Filling a portion of an array with a specific value
Let's say you have an array of integers and you want to replace all values between indices 2 and 5 (both inclusive) with the number 7. You can achieve this like so:
$arr = [1, 2, 3, 4, 5, 6];
print_r(Arr::fill($arr, 7, 2, 5));

Output:
Array
(
    [0] => 1
    [1] => 2
    [2] => 7
    [3] => 7
    [4] => 7
    [5] => 6
)

In this case, the fill method replaces values at indices 2, 3, and 4 with 7, leaving the other indices untouched.
Replacing all elements in an array with a specific value
If you want to replace every element in an array with a single value (for example, setting all ages to -1 because they are unknown), you can use your method like this:
$arr = [30, 25, 'unknown', 40];
print_r(Arr::fill($arr, -1));

Array
(
    [0] => -1
    [1] => -1
    [2] => -1
    [3] => -1
)

In this case, the fill method replaces every element in the array with -1. The $end parameter is not specified here, so it defaults to the length of the array (null).

We expected a use case in real life. Not another example on how that function works.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

@newQuery Care to explain a few use-cases?

Filling a portion of an array with a specific value
Let's say you have an array of integers and you want to replace all values between indices 2 and 5 (both inclusive) with the number 7. You can achieve this like so:

$arr = [1, 2, 3, 4, 5, 6];

print_r(Arr::fill($arr, 7, 2, 5));

Output:

Array

(

    [0] => 1

    [1] => 2

    [2] => 7

    [3] => 7

    [4] => 7

    [5] => 6

)

In this case, the fill method replaces values at indices 2, 3, and 4 with 7, leaving the other indices untouched.
Replacing all elements in an array with a specific value
If you want to replace every element in an array with a single value (for example, setting all ages to -1 because they are unknown), you can use your method like this:

$arr = [30, 25, 'unknown', 40];

print_r(Arr::fill($arr, -1));

Array

(

    [0] => -1

    [1] => -1

    [2] => -1

    [3] => -1

)

In this case, the fill method replaces every element in the array with -1. The $end parameter is not specified here, so it defaults to the length of the array (null).

Yeah that's not what I meant, I mean how would you use this a real case scenario, because what you said is just a functionality example.
This functionality seems so niche that it does not need to be in the framework but rather as a custom macro in your code base


Links with data-remote=true do not use the normal "open link in new tab" behavior when command/control + clicked

Expected Behaviour
When a link has the data-remote tag, using the keyboard shortcut to open a link in a new tab silently fails.
Actual Behaviour
A link should one openable in a new tab; with the data-remote acting as a sprinkle of interactivity; or there should be a way to opt into that behavior.
Steps to Reproduce
See the following codepen for a minimal example: https://codepen.io/tcannonfodder/full/abgZeWP

I hate to be the bearer of bad news, but it still looks like this error is occurring; both in my app and in the CodePen (which is running 1.0.1)

🤔 let me take another look.


Question about applying the delta over scales and rotations

Hi @ingra14m thank for sharing you great work! I have a question regarding the way you apply delta over gaussian scales and rotations, why did you apply the delta in the following ways
https://github.com/ingra14m/Deformable-3D-Gaussians/blob/7830e994632416b52f58f0f2dae5813ee8598960/gaussian_renderer/__init__.py#L87-L88
instead of applying delta before activation function, e.g.
scales = pc.scaling_activation(pc._scaling + d_scaling)
rotations = pc.rotation_activation(pc._rotation + d_rotation)

The way you implement is OK for scale but it does not guarantee a valid quaternion right?

Hi, thanks for your interest.
You are absolutely correct, the form you mentioned is absolutely correct physically. After going through the delta, quaternions should be normalized to unit quaternions to be meaningful. However, doing so in my experiments reduced the quality of rendering. You can think of this delta as a kind of trick.
Also, an interesting point is that I implemented quaternion multiplication in L20, which has more physical significance compared to quaternion addition. But unfortunately, the results are not as good as simply adding quaternions.

I see, thanks for the explanation!


rename track/1.8 to track/ckf-1.8, as per our conventions

Bug Description
This charm incorrectly uses the channel name 1.8 for the workload version ckf-1.8.  This should be fixed, renaming the github branch in this repo and also adding a new track in charmhub (and likely supporting both old and new track for some time?)
To Reproduce

Environment

Relevant Log Output
-

Additional Context
No response

Are you sure about this? e.g. both notebooks and volumes come with 1.8 branch as they are upstream Kubeflow components and so is the pvc viewer.


Issues raised by @stefanv while trying out napari

This is just a placeholder for @stefanv to provide complete examples after his talk at the M&M conference.

running dask-distributed concurrently with %gui=qt in IPython doesn't work. In his words, "I can very reliably kill the kernel when using napari and dask together". The gui_qt() context manager does not suffer from this.
our labels colormap shuffle doesn't reliably separate nearby labels (that one's on me).
#424
"I just did an add_image, and the labels from the layer BELOW are displayed OVER it. Then re-ordering the layer (dragging it to top, then back down) fixes it."
adding incorrectly-transposed points (34 3D points -> 3 34D points) crashes napari after two minutes. We might want to do some magic here, especially if we do add_points(np.nonzero(arr)) — perhaps we can detect tuple as a type and transpose in that case?
the name keyword argument for napari.view is broken
in his environment, running napari from Jupyter and opening the IPython built in terminal resulted in a blank panel.
@sofroniewn's latest layout fix in #466 didn't work for him apparently

Incidentally, I advised him to go back to 82f7ceb. We might want to release 0.1.4 based on that commit while we iron out all the issues with the IPython slider.
I'll let him use this list to create fleshed out issues with reproducible examples.

Correction on one of my earlier observations: the fix in #466 worked.

@jni I presume many of these can be closed by now?

Some but not all, I can go through and call out in more detail / create new issues for the critical ones

Looking over this I think the 3 remaining issues are:

running dask-distributed concurrently with %gui=qt in IPython doesn't work. In his words, "I can very reliably kill the kernel when using napari and dask together". The gui_qt() context manager does not suffer from this.
our labels colormap shuffle doesn't reliably separate nearby labels (that one's on me).
adding incorrectly-transposed points (34 3D points -> 3 34D points) crashes napari after two minutes. We might want to do some magic here, especially if we do add_points(np.nonzero(arr)) — perhaps we can detect tuple as a type and transpose in that case?

I will make a separate issue for the first one #679
For our labels colormap - that is likely due to the num_colors setting, increasing that will increase the separation, but will make things run slower. We have #204 to discuss improve the speed, so I will cross post this there too.
For the points one - we have now #480 which discusses some stuff on sizes - so I will cross post this comment there, though maybe it deserves it's own separate issue too
I will close this issue now though as I think further discussion can happen on the other issues and we have captured the major feedback, which was on a much older version

@sofroniewn thanks for the triaging! I think the points transpose problem does require its own issue. I'll make it even though @stefanv promised to make it back in the day. ;) =P


feat: add diagnostic checks for Bethe Free Energy stream

This PR fixes #136

@bartvanerp You are right. I added tests for all cases, found one ctrl-c ctrl-v bug 🙈


Fail to render Japanese characters

Can't properly render Japanese characters from markdown card set.

Could you attach an example deck?

The example deck.
japanese-test.txt
OpenCards rendering.

hmm unfortunately I don't know any Japanese, but the example deck looks fine for me

What is your OS and version of java?

You got it correctly on your machine.
I am on a W10 machine with Java version 8 update 131 (build 1.8.0_131-b11).

I'll look into it, but it'll take some days until I get access to a windows machine.


loop.getaddrinfo accepts service names like "http" for port.

loop.getaddrinfo accepts service names like "http" for port.

Fixes #353 .

Merged by hand in 2959a97823cdf2905e343efc7f3ec8dc013970f7
Thanks a lot, Jesse.

See also https://hg.python.org/cpython/rev/3ec208c01418


Unable to import component xiaomi_aqara after upgrade to 0.103.0

Home Assistant release with the issue:
0.103.0
Last working Home Assistant release (if known):
0.102.3
Operating environment (Hass.io/Docker/Windows/etc.):
Raspbian GNU/Linux 10 (buster)
python_version	3.7.5
Integration:
https://www.home-assistant.io/integrations/xiaomi_aqara/
Description of problem:
After upgrade from 0.102.3 to 0.103.0, my home assistant service doesn't start.
Debug:
ERROR (MainThread) [homeassistant.setup] Setup failed for xiaomi_aqara: Unable to import component
Workaround: rollback to 0.102.3
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
xiaomi_aqara:
  gateways:
    - host: ip.ip.ip.ip
      mac: 11aa22bb33cc
      key: xxxxxxxxxxxxxxxx

Traceback (if applicable):

Additional information:

My issue has been fixed (module netdisco was not installed):
I went into my home assistent python environment
then:
cd /srv/homeassistant/lib/python3.7/site-packages/homeassistant/components/xiaomi_aqara
executing "python init.py" bumped into this issue
...
trying /srv/homeassistant/lib/python3.7/site-packages/netdisco.pyc
Traceback (most recent call last):
File "init.py", line 8, in
from homeassistant.components.discovery import SERVICE_XIAOMI_GW
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in _load_unlocked
File "", line 728, in exec_module
File "", line 219, in _call_with_frames_removed
File "/srv/homeassistant/lib/python3.7/site-packages/homeassistant/components/discovery/init.py", line 13, in
from netdisco.discovery import NetworkDiscovery
File "", line 983, in _find_and_load
File "", line 953, in _find_and_load_unlocked
File "", line 219, in _call_with_frames_removed
File "", line 983, in _find_and_load
File "", line 965, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'netdisco'
...
After installing netdisco (pip3 install netdisco) and rebooting my raspberry, home assistant is running again.
Shouldn't netdisco come while upgrading home assistant to 0.103.0?

same here. Using hass.io so I cannot install netdisco (I suppose)

On hassio all integrations using netdisco are broken:
Failed config
General Errors:
- Component error: yeelight - No module named 'netdisco'
- Component error: octoprint - No module named 'netdisco'

Same here, using hassio

Have this problem too, can't upgrade until it's fixed.

Issue is gone on 0.103.2 for me

Same issue with 0.103.5 on Arch.  Wemo and Roku would not import after the update.  I had to install pywemo, pyroku, then netdisco.

Issue is gone on 0.103.2 for me
0.103.2 does not work for me. Sticking to 0.102.3 for now.

Same issue on 0.103.6 on hassio.

I had no issues on 0.103.2-0.103.5, could upgrade and everything worked. Now issue is back again on 0.103.6. Have hassio-installer installed Hass.io

Same issue on 0.103.6 on hassio.


Quick.AppService - property for loadOrderGroup

Add property to loadOrderGroup for install the service

Done. New properties added to control service: LoadOrderGroup, Dependencies, StartType, User and Desktop interaction.

Done. New properties added to control service: LoadOrderGroup, Dependencies, StartType, User and Desktop interaction.


Permission to share

I am in the final stages of developing an application that brings together various news related to the front-end world.
I would like to share your posts if you allow me.
Thanks

That sounds great. :smiley:
By the way, the whole JS Rocks site is licensed under MIT, so you technically don't need to ask for permission. :smile_cat:

Thank's man :D


@angular-devkit/build-angular:browser-esbuild reloads when navigating to lazy routes for the first time, causing navigation to fail.

Command
serve
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
Similar issue: https://github.com/angular/angular-cli/issues/25455
When serving with the Vite dev server, with caching enabled but no existing cache for lazy routes, the page will reload when I click on a link to a lazy route. And in some cases, the navigation will simply fail.
https://github.com/angular/angular-cli/assets/26806995/63dafb60-555e-4922-a808-fbab0a694420
My lazy route shows a list of items in my little test case, and I am using ngFor in the template. The navigation will proceed if the template is a simple
lazy-list works!
.
Despite the reply in the related issue (https://github.com/angular/angular-cli/issues/25455), I still expect/hope Angular cache and Vite play more nicely together because I want the cache enabled for faster dev builds. A very very naive idea is that the Vite dev server only reads the cache when it first launches, only writes to the cache before it shuts down, and keeps behaving as if there is no such thing as a cache during the whole life cycle of its process.
Minimal Reproduction
I have a minimal repo with the reproduction.

No response

Facing the same issue in recently release 17rc version


When will the code and data be open source

A very meaningful job. When will the code and data be open source

We just released the code and checkpoints: https://github.com/PrieureDeSion/visualnav-transformer/releases/tag/code_release


Issues Building

Hello,
I am trying to create my own Dapr middleware and thus need to build Dapr. I am having the same issues with both dapr and components-contrib, when I go to build I get the following error at the end of the build processes.
build github.com/Azure/azure-sdk-for-go/sdk/azcore/to: cannot load github.com/Azure/azure-sdk-for-go/sdk/azcore/to: no Go source files make: *** [Makefile:64: test] Error 1
Using a browser I get a 404 from github.com/Azure/azure-sdk-for-go/sdk/azcore/to and need to go to https://github.com/Azure/azure-sdk-for-go/tree/main/sdk/azcore/to to get the Go files. Is there an issue with the URI referenced? I am not familiar with Go or Make so am having some issues in figuring out how I can change the URI to the correct dependency (figuring that is the issue).


Installing from github with yarn doesn't compile.

I've tried a few ways and it either works with yarn and not npm or works with npm but not yarn. I'm not sure how to fix this and help would be appreciated.

I dont care anymore. Frick this


OPINION: Deposit should not be released while username is in use

I like this project! The ethos of this being a real DApp not controlled by any entity or keys resonates a lot with me. I've been trying to design my own DApps with a similar ethos.
I didn't know where to say this so apologies if using an Issue is inappropriate. The README describes using a time-lock deposit that gets unlocked after 20 days with the argument that it can prevent abuse of the system. The adatag website further elaborates on this saying:

... This feature is designed to prevent users from buying up all very rare usernames, such as the 1-char ones, for nearly free and then selling them at a very high price. When a user mints an adatag, they must deposit some ADA, proportional to the length of the adatag. This deposit is always claimable only by the minter after some time, i.e., the deadline, which is a protocol parameter. The suggested deadline is 20 days. This ensures that users have a stake in the system and are discouraged from abusing it.

I'm skeptical this will prevent abuse. IMO this deposit doesn't do anything since, after the 20 days, they can get their deposit back while keeping the username. So, in the end, there was no cost to the user above the typical tx fee. All it does is delay how quickly they can purchase the 1-char usernames by 20 days (which isn't that much time). I don't see how this deters users from buying up all very rare usernames, such as the 1-char ones, for nearly free and then selling them at a very high price. Plus, after the deposit is reclaimed, the user no longer has any stake in the system.
I think the incentives would be better if either:

The transaction fee is increased inversely proportionally to the length of the username - shorter usernames should be exponentially more expensive than longer ones. This would be instead of the deposit.
The deposit is calculated the same as the current design, but it is not unlocked unless the username is burned. The deposit would act like the minUTxOValue requirement but for usernames. This forces the user to have stake in the system for the entire time the username is in use. It also incentivizes users to not keep unused usernames since there is a financial incentive to reclaim the deposit; the larger the deposit, the more users will wish to burn unused usernames.

Perhaps both options can be used together. What are your thoughts on this? Why do you think locking a deposit for 20 days is enough?

Hi @fallen-icarus, thanks for your suggestions! In my opinion, none of the proposed solutions would fully prevent the creation of a secondary market. Though, I did choose the simplest one, it's worth reconsidering the best way to prevent abuse.

prevent the creation of a secondary market

I don't think this should be the goal. IMO the real issue is people buying up usernames just to sell later. In other words, the issue is purchased usernames go unused. Having a secondary market is fine since this may be more efficient in some circumstances than just burning and re-minting:

The secondary market enables users to pay up to guarantee they get it.
Burning and re-minting creates a race - the first one to re-mint the username gets it.

I believe the price mechanism will be more fair than who can mint the username first since the latter depends on hardware and is susceptible to an MEV attack.
If the goal is to minimize unused usernames, having an exponential deposit required for the entire time will make users think twice about sitting on usernames. For example, if a really popular username required locking up 500 ADA, a user has a huge incentive to return the username. Even if the username is purchased on the secondary market, if the new owner no longer has a use for it, the 500 ADA incentivizes them to return it. If the deposit was reclaimed while the username was still in use, there is no longer an incentive to return the unused username.

For example, if a really popular username required locking up 500 ADA, a user has a huge incentive to return the username. Even if the username is purchased on the secondary market, if the new owner no longer has a use for it, the 500 ADA incentivizes them to return it.

Sorry, I misunderstood you, for this this above it makes sense, but for preventing the abuse, as you were referring to it in your first post, I do not think it would be effective, as I would say, again, it just would just raise the margin from 0 to the locked deposit. But, who knows.

Hmm, thinking about it more, I suppose there is a chance users still hoard them even if the deposit is high. They would effectively be locking up ada for a few years with the hopes of the usernames potentially being worth more in the future. If their guess about the future is wrong, they can reclaim the ada at very little cost...
Have you thought about how a subscription mechanism could work?


update the Simplified translation

according to the new english version and Tranditional Chinese version
%s parts may need revising, the use of quotes seems inconsistant in both versions

oof, saw the italian one, will try to update via weblate.

Thanks @tleydxdy :)


Fix typo in image.tag default values

Return @ before sha256 in opencost.image.tag and opencost.ui.image.tag
Fix sha256 hashes

This fixes #233

When the new version would be released? Renovate autoupdated opencost as it was a patch version update and now it doesn't work everywhere


Fix subtype typo

Coverage remained the same at 99.795% when pulling 6c103836615efc01d567050f2f59a2d39f90bb4b on helgee:patch-1 into 4b02846e6332e483cc548bd6933d9a4bc5da8e7c on AndrewAnnex:master.

cool thanks for the contribution, if you find any more please go ahead and open PRs (maybe batch them up if there are a lot...)


Remove QA Certification Events Data

As an ECMPS user, I want the ability to remove QA Certification Event data so that I can update data as needed
Acceptance Criteria:
Given I am in the QA Certification Event data section
When I click on the 'Remove' option
Then I see that the relevant QA Certification Event data record is deleted
Given I chose to remove QA Certification Events Data
When I click on the 'Remove' option
Then I see a message 'Are you sure you want to remove the selected data?'
And when I click Yes
Then the data is removed
And the update shall be reflected in the QA Certification Events data section
When I select Cancel
Then I am returned to the landing screen for QA Certification Event Data
Testing
Test Case: TC1199
Tester:  @JanellC

TC1199 Passed


Fix spread move effect order

TODO:

[x] fix the 74 failing tests
[x] remove the old moveHit function and replace it with spreadMoveHit (probably should rename spreadMoveHit to moveHit)
[x] rewrite tryMoveHit to use new functions
[x] add tests for things
[x] old gens...

So yeah, if anyone has any idea why this would be undefined in a function where this is a Battle and the function was called from that battle, lemme know.

This pull request introduces 2 alerts when merging 0a5133e88734ccfea82c8239d5afd6a285a72cc9 into 51cb39a599d0f9b3dfe12087df321d3858a0d19b - view on LGTM.com
new alerts:

2 for Useless assignment to local variable

Comment posted by LGTM.com

Which part is the problem?

Also you should probably ignore the LGTM useless assignment alerts, I think they're buggy at the moment.

I'm pretty sure the assignments you removed were actually important.

Oh yeah, that's pretty easy to fix by just never using function pointers as callbacks.

I'm pretty sure the assignments you removed were actually important.

They were, but they were also wrong. They should have been didAnything = didAnything || false not didSomething = didSomething || false.

Woo! Only failing 157 tests now!

Things currently broken (according to existing tests):

[ ] The AfterMoveSecondary event doesn't seem to be running, given that Life Orb isn't dealing damage and Color Change isn't working at all.
[ ] Explosion is KOing the user without dealing any damage.
[ ] Immunity abilities, i.e. Dry Skin, don't protect the user from damage or apply their healing/stat-boosting effects
[ ] Self-switching moves don't switch the user out
[ ] On-contact events don't activate (Mummy, Rocky Helmet, Iron Barbs)
[ ] Curse doesn't activate, regardless of user's type
[ ] Air Balloon doesn't pop
[ ] Counter/Mirror Coat do nothing
[ ] Stomping Tantrum appears to be backwards, doubling BP when it shouldn't and not doubling when it should

This pull request introduces 1 alert when merging 045f0310413356e96102c8f4bfdddeec72d5e978 into 76af9369295b7154eefaf2091aab73d5a9ce927f - view on LGTM.com
new alerts:

1 for Useless assignment to local variable

Comment posted by LGTM.com

I feel like this problem is one of these

and I'm trying to solve it by just shaking the thing.

Only 2 tests remaining!!!!

All tests passing! This can actually be merged now, as the other things to do are merely to remove code duplication and give older gens the same update with respect to spread moves.

Well, nobody wrote me any tests for doubles-specific stuff like Emergency Exit activation order, and there's actually still research to do on that front, so I suppose I should write some tests at least before this is really ready.

Gah, realized last night in bed that there’s a couple obvious mistakes I made with the Counter and Emergency Exit fixes.

Actually, lemme change how I did gens 2 & 3.

I think that's everything.

I'm not sure why all of you have merge issues, but I don't.
Is rebasing a problem here?

All I did was rebase, and then the commit I was introducing was suddenly a merge conflict when it shouldn’t have been, and I had no idea that this had gone this poorly until you commented on it just now. I honestly don’t know what even happened here.

Hey, I fixed it, I think!

I see another conflict...

rip, the coauthor didn't work

(For the record, I definitely think we need to move most script functions from scripts back into battle. The distinction is way too arbitrary.

Although if we did it before this, that would probably make this one easier to review... decisions, decisions... I guess it can be your call.

If we move them before this, then the functions we're moving won't exist and I wouldn't put it past you to change your mind and decide that some of these new functions should still be in scripts.js. I vote after.

Honestly, though, this is a bit too many changes to easily review.

It's too bad your commits aren't neat enough to review them individually. :(

Anyway, can you go over why useMoveInner was added to Gen 3, and tryMoveHit were removed from Gen 4? That seems like the most non-sequitur part of this.

useMoveInner was added to Gen 3 because Gen 3's behavior when it comes to move effect order is too weird to fit into how I implemented useMoveInner for gens 4-7, so it's going to be using the old system. That is, the one that doesn't do spread move effect order properly. According to @Marty-D there's really no need for it in Gen 3, anyway. I removed tryMoveHit from Gen 4 because the only difference between it's version and Gen 7's was step order, and that's already handled in the Gen 7 version, so the only thing necessary was to override the tryImmunity step which had slightly different code in Gen 4's tryMoveHit.

Also, in hindsight, this is too much code to stuff into Scripts. This isn't just about delaying moving code out of Scripts, you're adding a whole bunch of new code into Scripts, and I think it's best to remove it first.

It's also easier to review .ts code than .js code.

(The Gen 3 and Gen 4 changes sound good, btw.)

The only actual new code is combineResults and maybe moveHitLoop. The rest is just old code moved into new functions and put into loops. That said, if you want functions moved to battle.ts, just give me a list and they'll be moved.

combineResults should definitely be moved.

Travis tests have failed
Hey @MacChaeger,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
TravisBuddy Request Identifier: 371df8a0-45e1-11e9-bd8c-75081e8e72cb

@MacChaeger - can you please fix the merge conflicts so this can land? :)
@Zarel - is letting this linger on in code review productive at this point (I agree its too big to review in a way we can be fully confident about), or can we just land it and deal with the fallout?

Oh dear.


inconsistent results for orderBy query

As far as I can tell this is specific to thinky (as opposed to raw rethinkdbdash). Given the following piece of code:
'use strict';
var thinky = require('rethinkdbdash')();

var User = thinky.createModel('users', {
  username: thinky.type.string().required(),
  email: thinky.type.string()
});

User
  .save([
    { username: 'arthur', email<EMAIL_ADDRESS>},
    { username: 'james', email<EMAIL_ADDRESS>},
    { username: 'henry', email<EMAIL_ADDRESS>},
    { username: 'william', email<EMAIL_ADDRESS>},
    { username: 'edward', email<EMAIL_ADDRESS>},
    { username: 'arthur', email<EMAIL_ADDRESS>}
  ])
  .then(function() {
    return User.orderBy('username');
  })
  .then(function(result) {
    console.log(result);
    return User.delete();
  })
  .error(function(err) {});

If you run this a number of times, you will sometimes randomly find the top two elements ({ username: 'arthur', email<EMAIL_ADDRESS>}, and { username: 'arthur', email<EMAIL_ADDRESS>}) flipped. It usually takes about four times to get the behavior to present itself.

answered and closed here: https://github.com/rethinkdb/rethinkdb/issues/4728

When I just skimmed over, it looked like a scary issue. Glad it was resolved :)


Add some hints to using os.proc with Mill

Using os.Inherit for output is known to not show up when in client-server-mode. We should mention the use of mill.modules.Jvm.runSubprocess and also give suggestions which settings work best in Mill.
Also, all links to os-lib in the documentation should go through a dedicated Mill-specific page, so that readers following it will have an option to read about those best practices. This could be the existing https://com-lihaoyi.github.io/mill/mill/External_References.html#_os_lib page, or some more dedicated.
Related:

#2059

I've been doing something like
stdout = os.ProcessOutput.Readlines(line => T.ctx().log.debug("[prefix] " + line))

where prefix is a name for what program I'm running.

Although, I guess you'd want to do that for stderr too (except maybe with log.warn)...
Too bad os.proc doesn't have an easy way to reuse groups of parameters, that's something I could use often.

Another good place to mention Jvm.runSubprocess is https://com-lihaoyi.github.io/mill/mill/Extending_Mill.html#_custom_targets_commands
which currently says

For subprocess/filesystem operations, you can use the os-lib library that comes bundled with Mill, or even plain java.nio/java.lang.Process. Each target gets its own T.dest folder that you can use to place files without worrying about colliding with other targets.

One thing that's worse about Jvm.runSubprocess is that if it exits with a nonzero exit code, it throws a generic Exception that doesn't say the command line that failed. With os.proc I was doing
    catch {
      case e: os.SubprocessException =>
        throw new RuntimeException(
          "rollup failed with exit code " + e.result.exitCode,
          e
        )
    }

etc. Otherwise if a few commands run and their output is not so different-looking from each other, it's hard to tell which one failed.
A different option would be to just log at the beginning the command line that will be run.

I switched to
    catch {
      case e: Exception =>
        throw new RuntimeException("Error running webpack", e)
    }

but then the output is harder to scan:
main.test.fastLinkJSTest java.lang.RuntimeException: Error running webpack
    io.github.nafg.millbundler.ScalaJSWebpackModule.$anonfun$bundle$3(ScalaJSWebpackModule.scala:90)
    io.github.nafg.millbundler.ScalaJSBundleModule$Test.$anonfun$fastLinkJSTest$2(ScalaJSBundleModule.scala:33)
    mill.define.Task$TraverseCtx.evaluate(Task.scala:380)
java.lang.Exception: Interactive Subprocess Failed (exit code 1)
    mill.modules.Jvm$.runSubprocess(Jvm.scala:196)
    io.github.nafg.millbundler.ScalaJSWebpackModule.$anonfun$bundle$3(ScalaJSWebpackModule.scala:86)
    io.github.nafg.millbundler.ScalaJSBundleModule$Test.$anonfun$fastLinkJSTest$2(ScalaJSBundleModule.scala:33)
    mill.define.Task$TraverseCtx.evaluate(Task.scala:380)

I think this can be closed since https://github.com/com-lihaoyi/mill/pull/3275 makes os.proc.call/os.Inherit do the right thing by default


consistency

The first part of the tutorial uses the Hello Blockchain example. The second part uses Asset Transfer. It would be great if both would use the same. Free doppio for who can make that happen.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7f1af5ea-7f46-788c-3275-ccf1d7321de8
Version Independent ID: fcbef541-15b3-936a-ce0c-e498645543bf
Content: Using applications in Azure Blockchain Workbench
Content Source: articles/blockchain/workbench/use.md
Service: azure-blockchain
GitHub Login: @PatAltimore
Microsoft Alias: patricka

@bospoort Thanks for the feedback! We are currently investigating and will update you shortly.

@bospoort I see what you are saying. I have assigned the issue to the content author to evaluate and update as appropriate.

@bospoort Thanks for the feedback. Great suggestion! I logged an item in the backlog to change this for the next release.
Thanks!
Pat
#please-close


Improve tabs padding

Add space into tabs to make the text less close from the borders.
Change .el-tabs__content padding from 1emto 2em.
Remove margin-top of h3and last olcomponent.
Potential issue:
The tabs need to have only one h3 at the begging and the last element have to be an olcomponent.

The potential issue we can deal with when it comes :)


Need to explain how to inject mock into application

When testing a Flask or Django application that uses MongoDB by using a test client, it would be useful to be able to replace the normal database object with the mongomock client. How do we do that? Something in the README would be handy.

@quantoid http://docs.mongoengine.org/guide/mongomock.html

Yes but how do you switch between normal URI for production and mongomock URI for testing? You'd have to select different settings for your app, which is easy for Django but not sure for Flask.

save this in a file called db.py, then you'll be able to just use db.foo()
*also, haven't run this in long time... so someone might want to double check it
#db.py

"""usage
from db import db
db.foo()
"""

import os

## Environment
environment = os.environ.get('ENVIRONMENT')

## Database
global mongo

if environment == 'test':
    global mongo
    import mongomock as mongo
else:
    global mongo
    import pymongo as mongo

db_uri = os.environ.get('MONGO_URI', 'mongodb://localhost')
db_name = os.environ.get('MONGO_DB', 'mydbname')
db = mongo.MongoClient(db_uri)[db_name]

Ok I think my problems are specific to flask-mongoengine.


Configure switch port number if faucet config of test cases

created hw_switch_config.yaml to provide all the info required when using a HW switch
dataplane ports can be specified and will be used when creating the FAUCET config file to use
in each test. The PC interface name connected to these ports is not used at the moment, only the
Faucet config string of each test is updated

Is this configuration approach acceptable?

I am a bit concerned about the fact that the test configs are supposed to document the correct config for each feature. Using the string formatting in these configs makes it harder for non-python-fluent people to understand how to configure things.
I think we might have to have a think about another way of either making this work or another way of documenting configuration for features.

That's true; there is the expectation that people can at least read code.
I don't think this is a concern because (IMHO) SDN engineers will be
compatible with that expectation (and it is a pretty low bar).
Separately, it would be great to have an actual non-code based manual, but
given this is an open source project.... we must allocate scarce resources.
Just making a number of minor fixes here to restore tests (my fault, I
should have requested them from you before merging).
On Wed, Jun 1, 2016 at 11:18 AM, KitL<EMAIL_ADDRESS>wrote:

I am a bit concerned about the fact that the test configs are supposed to
document the correct config for each feature. Using the string formatting
in these configs makes it harder for non-python-fluent people to understand
how to configure things.
I think we might have to have a think about another way of either making
this work or another way of documenting configuration for features.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/REANNZ/faucet/pull/98#issuecomment-222849704, or mute
the thread
https://github.com/notifications/unsubscribe/AEgZ145btjNntueG8ac1U8nKrPWFaJx3ks5qHMHHgaJpZM4Iqg7y
.

OK, all tests are now restored.
On Wed, Jun 1, 2016 at 11:21 AM, Bailey, Josh<EMAIL_ADDRESS>wrote:

That's true; there is the expectation that people can at least read code.
I don't think this is a concern because (IMHO) SDN engineers will be
compatible with that expectation (and it is a pretty low bar).
Separately, it would be great to have an actual non-code based manual, but
given this is an open source project.... we must allocate scarce resources.
Just making a number of minor fixes here to restore tests (my fault, I
should have requested them from you before merging).
On Wed, Jun 1, 2016 at 11:18 AM, KitL<EMAIL_ADDRESS>wrote:

I am a bit concerned about the fact that the test configs are supposed to
document the correct config for each feature. Using the string formatting
in these configs makes it harder for non-python-fluent people to understand
how to configure things.
I think we might have to have a think about another way of either making
this work or another way of documenting configuration for features.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/REANNZ/faucet/pull/98#issuecomment-222849704, or mute
the thread
https://github.com/notifications/unsubscribe/AEgZ145btjNntueG8ac1U8nKrPWFaJx3ks5qHMHHgaJpZM4Iqg7y
.

Sorry about the bad string substitution, I pushed the change too quickly

No problem. I am breaking out changes one by one you made in your test
script and adding them (for example, just added the OF1.3 flow-style
matches). Should be fully integrated today.
On Thu, Jun 2, 2016 at 12:01 AM, Davide Trentin<EMAIL_ADDRESS>wrote:

Sorry about the bad string substitution, I pushed the change too quickly
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/REANNZ/faucet/pull/98#issuecomment-222971779, or mute
the thread
https://github.com/notifications/unsubscribe/AEgZ17ysFEkAQNp9taohr_KH5KsXDm66ks5qHXSugaJpZM4Iqg7y
.


Revert "Revert "MGDCTRS-1143 chore: update copy text and add link""

Reverts bf2fc6cc711aee1a0c2a/cos-ui#533
Brings back the changes for MGDCTRS-1143 when we're ready for them.

added the "do not merge" label

Removed the "do not merge" label, since we are playing to release this on Wednesday.


Uncaught exception in low implementation.

🐛 Bug Report
Server crash when aborting wrk when using fast-proxy with 0http with low server
Ref: https://github.com/fastify/fast-proxy/issues/35
To Reproduce
I have the following code:
(Happens also without undici)
    const { proxy } = fastProxy({
      base: 'http://localhost:4000',
      undiciOptions: {
        connections: 4000,
        pipelining: 20,
        requestTimeout: 5000,
      },
    });
    const { router, server } = cero({
      server: low(),
    });

    router.all('/*', (req, res) => proxy(req, res, req.url, {}));

    server.listen(3000, (socket) => {
      if (socket) {
        console.log('HTTP server ready!');
      }
    });

With an additional restana server listening on port 4000
Then run
wrk -t8 -c50 -d20s http://localhost:3000/api/v1/test
hit CTRL-C to stop wrk.
Result:
process abort on with the following error:
Invalid access of discarded (invalid, deleted) uWS.HttpResponse/SSLHttpResponse.
There was an uncaught exception. I'm now going to commit suicide; farewell all.

When I'm using 0http without low it doesn’t  happen
Expected behavior
The process should not abort if I stop wrk
Your Environment

node version: 12
fast-prxy version: latest
os: Mac

I think I had a similar issue with my side project that heavily borrows from 0http. I will try to help ASAP, if it is a similar issue

From what I recall, uWS can REALLY lose its... colour, when you try to set a header that has already been set, even if it is in another case (IIRC). From what I see in curl, this happens with the Date header. But I am not entirely convinced this is the whole problem.
curl -v http://localhost:3000/api/v1/test
*   Trying ::1...
* TCP_NODELAY set
* Connected to localhost (::1) port 3000 (#0)
> GET /api/v1/test HTTP/1.1
> Host: localhost:3000
> User-Agent: curl/7.64.1
> Accept: */*
>
< HTTP/1.1 200 OK
< Date: Wed, 09 Sep 2020 14:32:17 GMT
< date: Wed, 09 Sep 2020 14:32:18 GMT
< connection: keep-alive
< content-length: 0
< uWebSockets: v0.17
< Content-Length: 0
<
* Connection #0 to host localhost left intact
* Closing connection 0

I think I am onto something:
It appears wrk sometimes aborts some requests. Whenever this happens, the exception occurs. The only way I figured how to check for this condition is by using onAborted uWS function and setting a property in resWrapper called __isAborted as true. Whenever __isAborted is true, we cannot set headers or write status.
class HttpResponse extends Writable {
  constructor (uResponse, uServer) {
    super()

    this.res = uResponse
    this.server = uServer

    this.statusCode = 200
    this.statusMessage = 'OK'

    this.__headers = {}
    this.headersSent = false

    this.res.onAborted(() => {
      this.__isAborted = true
    })

    this.on('pipe', _ => {
      this.__isWritable = true
      if (!this.__isAborted) writeAllHeaders.call(this)
    })
  }

  setHeader (name, value) {
    this.__headers[toLowerCase(name)] = [name, toString(value)]
  }

  getHeaderNames () {
    return Object.keys(this.__headers)
  }

  getHeaders () {
    const headers = {}
    forEach(this.__headers, ([, value], name) => {
      headers[name] = value
    })
    return headers
  }

  getHeader (name) {
    return this.__headers[toLowerCase(name)]
  }

  removeHeader (name) {
    delete this.__headers[toLowerCase(name)]
  }

  write (data) {
    if (this.__isAborted) {
      return
    }
    this.res.write(data)
  }

  writeHead (statusCode) {
    if (this.__isAborted) {
      return
    }
    this.statusCode = statusCode
    let headers
    if (arguments.length === 2) {
      headers = arguments[1]
    } else if (arguments.length === 3) {
      this.statusMessage = arguments[1]
      headers = arguments[2]
    } else {
      headers = {}
    }
    forEach(headers, (value, name) => {
      this.setHeader(name, value)
    })
  }

  end (data = '') {
    if (this.__isAborted) {
      return
    }
    this.res.writeStatus(`${this.statusCode} ${this.statusMessage}`)

    if (!this.__isWritable) {
      writeAllHeaders.call(this)
    }

    this.finished = true
    this.res.end(data)
  }

  getRaw () {
    return this.res
  }
}

The problem is that while it helps us to avoid exception and the uWS seems to function withour errors, wrk reports the following:
nikolayshamberg@Nikolays-MacBook-Pro fastProxy % wrk -t1 -c50 -d10s http://localhost:3000/api/v1/test
Running 10s test @ http://localhost:3000/api/v1/test
  1 threads and 50 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     0.00us    0.00us   0.00us     nan%
    Req/Sec     0.00      0.00     0.00       nan%
  0 requests in 10.01s, 3.33MB read
  Socket errors: connect 0, read 25130, write 0, timeout 0
Requests/sec:      0.00
Transfer/sec:    340.30KB

There is still something wrong that I cannot figure out yet.

Update
With my changes, it appears the lackluster performance only impacts fast-proxy, as I forgot to set prioRequestsProcessing: false, when testing with restana.
Here are the benchmarks:
Restana
Route used:
app.get('*', function (req, res) {
  res.send('some string')
})

Without uWS:

nikolayshamberg@Nikolays-MacBook-Pro fastProxy % wrk -t8 -c50 -d10s http://localhost:4000/api/v1/test
Running 10s test @ http://localhost:4000/api/v1/test
  8 threads and 50 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.11ms  677.96us  23.70ms   97.22%
    Req/Sec     5.61k   816.48     6.93k    93.31%
  450749 requests in 10.10s, 65.34MB read
Requests/sec:  44622.50
Transfer/sec:      6.47MB

with uWS:

nikolayshamberg@Nikolays-MacBook-Pro fastProxy % wrk -t8 -c50 -d10s http://localhost:4000/api/v1/test
Running 10s test @ http://localhost:4000/api/v1/test
  8 threads and 50 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   670.16us  124.88us   2.86ms   93.03%
    Req/Sec     8.99k   517.82     9.69k    81.06%
  722187 requests in 10.10s, 76.45MB read
Requests/sec:  71503.70
Transfer/sec:      7.57MB

However, enabling uWS makes performance in fast-proxy rather lackluster. I do not have intimate knowledge of fast-proxy, so I can only imagine the reasons for it.
I will draft a PR as soon as anyone reviews this and the last comment.

Hi @schamberg97 thanks for addressing this issue.
I will review your PR over the weekend.

Moved to: https://github.com/jkyberneees/low-http-server/pull/2


Can't use  without  element

When using <ibm-label> without having <input> element, the following exceptions thrown:

Yep, right now ibm-label only works on a limited subset of our form components. We have a few PRs open around standardizing our inputs, so hopefully we can expand it's use in the future!

So, with several of the changes we've made to our form controls it doesn't really make a whole lot of sense to use ibm-label with them - they already support all the same Inputs. At the moment the path forward seems to be standardizing and abstracting those parts of the template/component class internally (of course all our internal components will be exported for general use :+1:)


Replacing XFCE with Cinnamon

name: xenial
encrypted: yes, locked

Hi,
I'm having trouble switching to Cinnamon.
I installed Cinnamon with apt-get without issues. But since logging out from Ubuntu makes me return to Chrome OS immediately, I have no idea how to actually run it. Ideally, I'd like to do so with a single command just like how it works with XFCE.
~ Best regards and merry christmas.

Never mind, I found this :)
https://tr1t.wordpress.com/2015/04/21/installing-mint-cinnamon-in-crouton/


File directive # flake8: noqa also suppresses isort errors

The file directive # flake8: noqa does not only suppress flake8 errors but also isort ones.
I would expect the flake8 directive to suppress only flake8 errors, being equivalent to:
[tool.ruff.lint.per-file-ignores]
"my_filename.py" = ["F"]

This was the behavior before replacing flake8+isort with ruff.

Thanks! From my perspective this is working-as-intended. # flake8: noqa is interpreted as "suppress all lint errors", and unorganized imports is a form of lint error.
Similarly:
[tool.ruff.lint.per-file-ignores]
"my_filename.py" = ["F"]

This wouldn't match Flake8's behavior either, since # flake8: noqa doesn't mean "Ignore the F rules", it means "Ignore all Flake8 rules", which includes the Pycodestyle rules (E, W) and any plugins you have installed. So that would be too narrow.
If you only want to ignore the F rules, I suggest using per-file ignores instead.

Thanks for your reply, @charliermarsh.
Forget my above comment about the equivalence to ignoring F rules, which is not precise.
The key points are: for our files marked with the directive # flake8: noqa

before using ruff, we were using flake8+isort

all Flake8 rules were ignored but not isort ones: the imports were sorted

we replaced flake8+isort with ruff and we expected the same behavior

however now the imports are no longer sorted

If this behavior change is fine from your perspective, would you consider it worth mentioning explicitly in the docs to make it even clearer?
For example, maybe something like:

Note that Ruff will treat Flake8's # flake8: noqa directive as equivalent to # ruff: noqa, thus suppressing all linting violations, not only Flake8 ones (e.g. also isort).

instead of:

Note that Ruff will also respect Flake8's # flake8: noqa directive, and will treat it as equivalent to # ruff: noqa.


Use existing CSR to generate certificate

Hi, - a feature request please :smiley:
I have a server that I want to generate a cert for. I can generate for my IIS server (very easy to use, great tool) but unfortunately my other app insists on generating its own private key and a CSR. Checking the main letsencrypt site, this is an option that is supported - and I've made it work using the --csr and --manual options and copy pasted verification file from my MBP to the my Windows server IIS website.
It would be great not to have to have to fiddle doing that and have the great automation of this tool handle a CSR input.
Thanks!

If anyone wants to see this enhancement, add your +1 (via add your reaction) to the first comment of this issue.

Yep that would be great!

That would be really helpful for third party CSR files for IIS websites

Would be awesome to have this option.
I need a certificate for my hmail server. Up to now I use a StartSSL certificate for both, the mailserver itself and the webmail website. Now I created a new certificate for the website by using letsencrypt-win-simple and it works perfect! But I can't use the same certificate for the mailserver, because of the missing private key file. So I would need to use my own existing key file. Or, alternatively, is it possible to access the private key file, lws uses to create the certificate?
Thanks a lot!!! :-)

Just had a little light bulb moment. Rather than requesting a custom CSR for a target generated from one of the existing plugins, an externally generated CSR could actually be the target, i.e. this feature could be implemented as a target plugin.
I'd like to get some confirmation that people are still waiting on this though, because it's been awfully quiet recently.

Hi @WouterTinus - Any luck with the approach to generate certificate using CSR on windows?
Primarily the issue here I got a java based vendor application which allows HTTPS through its own application settings, based on keystore, hence in my case no way than using CSR.
I tried to import domain verified certificate got through win-acme, however that failed with error:
"certificate reply does not contain public key"
On linux certbot allows generation of certificate using CSR. Optionally is there any way to get certbot for windows?

might be simpler to just setup IIS as a reverse proxy?
https://www.sapho.com/documentation/how-to-configure-microsoft-iis-http-server-as-a-reverse-proxy-for-sapho-server-running-on-apache-tomcat/

The basic principle works, but it still requires more fine tuning, e.g. handling of private keys etc. I hope it will be in one of the next releases.

OK, got a workaround to make it work. Basically I had to use certificate PEM files convert to PFX and then create keystore file using PFX which can directly be passed to tomcat. Reference URL
Still I believe the old technique of requesting certificate using CSR should be implemented for windows client same as certbot allows.

Just thought it worth flagging that I'd still love for this functionality to be available. 3 years on and every 3 months I (or if I can find someone else with a MBP with time) sit and copy paste values from my MBP shell window into a file on my Windows Server so I get a new cert that I then upload into my server. Oh to just be able to run the tool/script/functionality on the Windows server - then I could get anyone in the company to do it! Thanks for adding the milestone flag - I'm excited!

This was finally released in version 2.0.9!


Migrating Purview workflow recordings to the azure-sdk-assets repository

Offline confirmed with Harsha, it's not ready to add this guide in our onboarding guide now.


Chapter-2 error while getting the Housing datasets

I am very new to python
Can someboody help me in debugging the below.
I am getting this while getting the Housing datasets
**req = meth(req)
File "C:\Users\HP\Anaconda3\envs\tf1\lib\urllib\request.py", line 1249, in do_request_
raise TypeError(msg)
TypeError: POST data should be bytes, an iterable of bytes, or a file object. It cannot be of type str.**
python version : 3.7.6

Can you post the code you are using?


IImageService.IsValidRequest is called twice for each image URL

This is first called inside the GetImageServiceForRequest() function (except for the case where it matches a service by request path prefix). Then it is called again later for the resource path, but this seems redundant to me? Is there some reason the second call is required?

I can't think of a scenario where we would need to call it twice. It's probably a hangover from refactoring. Will trace through and see why.

Check it for the remote file service also as if will get called twice there as well on a different code path.

Does it... Bugger, Can you give me some line numbers.

It all happens in GetImageServiceForRequest(). The first block of the code matches an image service on a prefix, but never calls IsValidRequest() at all. So I suspect the code in ProcessImageAsync() that you changed was originally added to make sure it got called for remote processing that matches a specific prefix. However for the local file service it calls it specifically and then for the last line:
services.FirstOrDefault(s => string.IsNullOrWhiteSpace(s.Prefix) && s.IsValidRequest(path) && s.GetType() != typeof(LocalFileImageService));
it also calls it. So in the case where a custom IImageService is used, it will still get called twice again.
I think the correct solution is to completely remove the call in ProcessImageAsync() that you modified, and instead put all the code to call IsValidRequest() entirely in GetImageServiceForRequest(). I originally was going to do that but I was not sure of the implications of changing that. But I have a better grasp on that now so I will attempt a fix in my tree and you can take a look at it.

Ah I see now. If it is a custom, unprefixed service we are still calling it twice.
The fix is trivial then:
    // Check whether the path is valid for other requests.
    // We've already checked the unprefixed requests in GetImageServiceForRequest().
    if (!string.IsNullOrWhiteSpace(currentService.Prefix) && !currentService.IsValidRequest(resourcePath.ToString()))
    {
        return;
    }

We need to call IImageService.IsValidRequest later on in the pipeline for requests with a prefix because we need to manipulate the url first to separate out the composite parts before sanitising.


temperature typo in chat-gpt.ts

fix(#45)
fix(#47): ever
fix(#47): no strict
fix(#47): instead
fix(#47): all cost
fix(#47): copy prompt off
fix(#47): copy full prompt off
fix(#47): copy prompt back, again
fix(#47): don't copy
fix(#48): reject for now
fix(#48): reject too
fix(#48): non-relevant/not a bug report
fix(#48): codebase
fix(#48): relevant, but not a bug
feat(#48): close not relevant
feat(#48): typo
feat(#48): repo
feat(#48): just, no relevance
feat(#48): not a bug report print
feat(#48): refs
fix(#47): flexible
fix(#47): context brackets
feat(#48): tell me quality problems
feat(#48): don't formulate
feat(#48): awesome then problems
feat(#48): suits
feat(#48): don't generate
feat(#48): three commas
feat(#48): bullets
feat(#48): no example
feat(#48): log summary
feat(#48): no example.ts, only missing
feat(#48): miss back
feat(#48): precise
feat(#48): statements
feat(#48): only bullet points
feat(#48): typos
feat(#48): negative
feat(#48): formulation problems
feat(#48): typos
feat(#48): some
feat(#48): doesn't work
feat(#48): pre
feat(#48): prompt + rules gets simplifed
feat(#48): violated
feat(#48): no feat
feat(#48): context, rules
feat(#48): precise
feat(#48): what to fix
feat(#48): precise
feat(#48): matching
feat(#48): violated
feat(#48): refine more
feat(#48): refine more
feat(#48): fix it
feat(#48): important
feat(#48, #47): please fix
feat(#47, #48): star
feat(#47, #48): analyzed
feat(#47, #48): enough
feat(#47, #48): typo, understand
feat(#47, #48): related
feat(#47, #48): besides
feat(#47, #48): context
feat(#47, #48): rich
feat(#47, #48): no points
feat(#48, #47): flexible
feat(#48, #47): remove
feat(#48, #47): reasonable
feat(#48, #47): try back
feat(#48, #47): try back
feat(#48, #47): not clear
feat(#48, #47): refine
feat(#48, #47): don't include, no steps
feat(#48, #47): deep look
feat(#48, #47): pre, examples
feat(#48, #47): enought
feat(#48, #47): enought
feat(#48, #47): simplified
feat(#48, #47): example
feat(#48, #47): matched
feat(#47, #48): simple
feat(#47, #48): no title declaration
feat(#47, #48): no system
feat(#47, #48): no system
feat(#47, #48): temp
feat(#47, #48): confusion
feat(#47, #48): 0.7t
feat(#47, #48): strict
feat(#47, #48): no rules
feat(#47, #48): strict
feat(#47, #48): simpler
feat(#47, #48): tips, improve, only
feat(#47, #48): 0.5t
feat(#47, #48): focis
feat(#47, #48): formatting
feat(#47, #48): indents
feat(#47, #48): no indent
feat(#47, #48): summary only
feat(#47, #48): back
feat(#47, #48): example
regex
t typo

PR-Codex overview
This PR increases the temperature for generating chat responses in chat-gpt.ts.
Detailed summary

Increased temperature for chat response generation from 0.1 to 0.5.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@rultor merge

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 4min)


Layer Acceptance Tests

Add acceptance tests for SAM and Serverless using Lambda Layers.

Closing as Serverless acceptance tests are in place.


update auth

We are currently running auth 0.9 in gcloud-php and would like to update gRPC to match.
The only usage I found of the auth module was in interop_client.php. As is such, I moved the dependency to require-dev since it is only being used in tests.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@stanley-cheung when you have a moment could you please review

ok to test

We are having trouble with jenkins today. Do you mind rebasing this branch on top of master again to see if it will trigger the tests to run please? Thanks.

@stanley-cheung Rebased! Let me know if this helps.

ok to test

The interop tests failed on Jenkins. They are likely flakes on other languages, with which we have other issues tracked. However, due to some other Jenkins issue, I wasn't able to manually retry these tests where I normally am able to.
Do you mind if I take this and re-submit a PR from my account to see if that helps?

Sure, sounds good!
On Fri, Jul 8, 2016, 11:59 AM Stanley Cheung<EMAIL_ADDRESS>wrote:

The interop tests failed on Jenkins. They are likely flakes on other
languages, with which we have other issues tracked. However, due to some
other Jenkins issue, I wasn't able to manually retry these tests where I
normally am able to.
Do you mind if I take this and re-submit a PR from my account to see if
that helps?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/grpc/grpc/pull/7240#issuecomment-231398736, or mute
the thread
https://github.com/notifications/unsubscribe/AB-8hwoCRo4ygbV89HcHKuaJUoms3-n3ks5qTnPNgaJpZM4JGbBp
.

I created #7283. Do you mind going there and comment "I signed it"?

Closing this in favor of #7286 to get around some Jenkins issue


Changed click event hook to use preventDefault rather than return false

I have a use case where I'm using links in a dropdown menu that relies on the clicks bubbling up to the menu to tell it when to close the menu. Returning false in the click event hook was preventing my menu from closing when I used a route transition or action in the dynamic link. My solution is to use preventDefault rather than return false to keep the default anchor behavior from activating and to also let the click bubble up whenever the anchor is clicked.
This also seems to fill the use case in your TODO so I removed it.

This looks good to me, and thanks for the pull request.
One thing I'm wondering is whether we should still allow users to prevent actions from bubbling if they pass bubbles=false -- or even params.bubbles=false -- and I bet the first one works with this PR as-is but the second doesn't.
So basically, maybe make a change like:
bubbles: Ember.computed.alias('params.bubbles'),
click: function(event) {
   // ...

  if (this.get('bubbles') !== undefined) {
     return this.get('bubbles');
  } else {
     return true;
  }
}

And if possible, maybe add a test to confirm that works?
Let me know what you think!

Sure, it sounds like it'd probably be a good idea to let the user control it. I'll make the changes as soon as I get a minute.

Hmm, looks like there are some CI failures for later Ember versions that seem legitimate. I think those types of errors occur when the test tries to visit a URL external to the Ember app. So in some case, we're ending up in the wrong place. I can take a look at this and try to fix it later if you want.

Sure, I'd appreciate it. Thanks

I figured out a fix (wasn't a major issue), so I'll merge this, add my commit on top of it, and bump the version. Thanks again for the PR.

Thank you for fixing the tests / merging it.


Disable Tampermonkey

They put extension detection i think, we might need other trigger to open it instead of trigger it on enter website

fixed in v0.17.0

I don't think that fixed it. I'm running on the latest release (4 hours ago) and they still tell me to disable tampermonkey.

I don't think that fixed it. I'm running on the latest release (4 hours ago) and they still tell me to disable tampermonkey.

fixed again


simplify test setup with github-action-add-on-test, fixes #21

The Issue

#21

The github setup should be using github-action-add-on-test
How This PR Solves The Issue
Use it.

Please check this @julienloizelet, thanks.

This fails DDEV HEAD just because that's failing right now. Will be fixed in

#20

Hi @rfay ,
LGTM but we could also remove the DDEV_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} at the top of the file:
the DDEV_GITHUB_TOKEN is in fact also handled by the add-ons-test action itself.

Removed, thanks!


Update rbenv init instructions

The README details evaling rbenv init -, but for some shells (such as fish) there's a difference in what should be run. It turns out that rbenv init on its own will print correct instructions, so we should point users to running that command instead.

Thanks!


redmine: Rework module and update package

Description of changes
Tested that each individual patch is working.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

It seems master is broken?

@GrahamcOfBorg test redmine

@aanderse @megheaiulian Could you have a look again? Would be great if we could get this in :)

@ofborg test redmine.mysql redmine.pgsql

@aanderse Thanks! I'm going to push some more patches soon. I want to apply some hardening options to the systemd unit.


When a guest leaves, the API says the bot does instead?

When a guest user joins, userJoin data shows this:
{
    "avatarID": "base05",
    "role": 0,
    "id": 12590082,
    "guest": true
}

When that same guest leaves, userLeave shows this:
{
    "avatarID": "rock14",
    "badge": "rockset-g",
    "gRole": 0,
    "grab": false,
    "id": 3942480,
    "ignores": [],
    "joined": "2013-12-13 03:57:43.388000",
    "language": "en",
    "level": 16,
    "notifications": [],
    "pp": 591692,
    "pw": true,
    "role": 3,
    "slug": "lil-buddy",
    "status": 1,
    "sub": 0,
    "username": "Lil*Buddy",
    "vote": 1,
    "xp": 124604
}

Lil*Buddy is our bot's name.  He's not actually leaving.  I can duplicate this over and over, I'm sure it's the guest that's triggering this.

that's maybe because a guest is not a real user and he's defined by some undefined/null values, so if the code has been wrote in the way that if undefined/null user is passed it's the bot itself that it's choosen we end up in this situation. That needs a look at the code.

looking into the issue atm, might've found it. Will be fixed in next patch release

Next released version (not sure when) will have this issue resolved.
User Object will be:
 { id: 0, guest: true}

if a guest leaves in the new version


WebExtensions version

Hi,
Is there a WebExtensions version of this in the works? Firefox 57 is around the corner and I would like to see this addon live on. No pressure :')

Hi,
I am testing Firefox Developer edition which is already on version 57, it would be awesome if this extensions had version with WebExtensions support.

It seems that @chao, the creator of RESTClient, have started to work on it: https://github.com/chao/RESTClient/commits/RESTClient3

The update is published!!!


After some time it seems to randomly just Freeze

After what appears to be a random amount of time things just Freeze.
Happens in both Editor and Build, no Crash log or anything, Editor log appears to just Cut off without saying anything is wrong.
CPU Usage seems to continue going, however the editor or game itself just stops responding.

This has happened over 5 times now, Ill try to find a way to reproduce it consistently.


Ignore Configmap mounted in DeploymentConfig

What type of PR is this?
/kind bug
What does does this PR do / why we need it:
When creating applications on OpenShift Kubernetes, a (12-factor) best practice is to externalize the configuration in a ConfigMap. When mounting this ConfigMap in the DC, odo is not working anymore because it expects a volume with a PVC. As odo cannot manage ConfigMap yet, we should ignore them (as we ignore empty volume) to  apply best practices while using odo.
Which issue(s) this PR fixes:
This is an alternance for waiting for the PR2142 and PR2601
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

[ ] I have read the test guidelines

How to test changes / Special notes to the reviewer:

/ok-to-test

How to test changes / Special notes to the reviewer:

Can you please provide some steps to test these changes?

To reproduce the error, please follow:

Create a component using odo (odo create java:11 my-component --app my-app)
Create a ConfigMap (oc create configmap cm-test)
Mount the ConfigMap in the DC created by odo (oc set volume dc/my-component --add --configmap-name=cm-test --mount-path=/tmp)
Run the command odo list --app my-app

Without the fix, you will have the message 'no PVC associated with Volume Mount volume-xxxx'

@mik-dass The step "make test-cmd-push" failed but where can I get more logs about the error.

@mik-dass The step "make test-cmd-push" failed but where can I get more logs about the error.

The odo verbose error log is here https://travis-ci.com/github/openshift/odo/jobs/428010783#L1147

/retest

hello @mik-dass, I have spent some time trying to fix the Travis CI. It is very weird because each time I run a test (make test-xxx) I've got different problems and some tests OK became KO and viceversa.
Is it a expected behaviour? If so, how can I fix my PR to make it all green?

hello @mik-dass, I have spent some time trying to fix the Travis CI. It is very weird because each time I run a test (make test-xxx) I've got different problems and some tests OK became KO and viceversa.
Is it a expected behaviour? If so, how can I fix my PR to make it all green?

The tests are failing due a flake https://github.com/openshift/odo/issues/3454. You can restart the jobs to make Travis go green.