Error for building without folly

hi everyone!
If we first build folly and after this we build mapd-core, the building works. but if we don't build folly and add -DENABLE_FOLLY=OFF it raises the follow error:
2018-10-16T21:20:34.2292400Z CMake Warning at CMakeLists.txt:437 (add_executable):
2018-10-16T21:20:34.2292990Z   Cannot generate a safe runtime search path for target initdb because there
2018-10-16T21:20:34.2293720Z   is a cycle in the constraint graph:
2018-10-16T21:20:34.2294440Z
2018-10-16T21:20:34.2296260Z     dir 0 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib]
2018-10-16T21:20:34.2296820Z       dir 1 must precede it due to runtime library [libz.dylib]
2018-10-16T21:20:34.2297930Z     dir 1 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_build_env/lib]
2018-10-16T21:20:34.2298250Z       dir 0 must precede it due to runtime library [libbz2.dylib]
2018-10-16T21:20:34.2298390Z
2018-10-16T21:20:34.2298660Z   Some of these libraries may not be found correctly.
2018-10-16T21:20:34.2298800Z
2018-10-16T21:20:34.2298960Z
2018-10-16T21:20:34.2877460Z CMake Warning at CMakeLists.txt:441 (add_executable):
2018-10-16T21:20:34.2879110Z   Cannot generate a safe runtime search path for target mapd_server because
2018-10-16T21:20:34.2879550Z   there is a cycle in the constraint graph:
2018-10-16T21:20:34.2880190Z
2018-10-16T21:20:34.2882230Z     dir 0 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib]
2018-10-16T21:20:34.2882670Z       dir 1 must precede it due to runtime library [libz.dylib]
2018-10-16T21:20:34.2883340Z     dir 1 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_build_env/lib]
2018-10-16T21:20:34.2883500Z       dir 0 must precede it due to runtime library [libbz2.dylib]
2018-10-16T21:20:34.2883570Z
2018-10-16T21:20:34.2883740Z   Some of these libraries may not be found correctly.
2018-10-16T21:20:34.2883820Z
2018-10-16T21:20:34.2883940Z
2018-10-16T21:20:34.8783710Z CMake Warning at Tests/CMakeLists.txt:46 (add_executable):
2018-10-16T21:20:34.8784660Z   Cannot generate a safe runtime search path for target MapDQLCommandTest
2018-10-16T21:20:34.8785220Z   because there is a cycle in the constraint graph:
2018-10-16T21:20:34.8785680Z
2018-10-16T21:20:34.8787760Z     dir 0 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib]
2018-10-16T21:20:34.8788270Z       dir 1 must precede it due to runtime library [libz.dylib]
2018-10-16T21:20:34.8789390Z     dir 1 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_build_env/lib]
2018-10-16T21:20:34.8789630Z       dir 0 must precede it due to runtime library [libbz2.dylib]
2018-10-16T21:20:34.8789790Z
2018-10-16T21:20:34.8789970Z   Some of these libraries may not be found correctly.
2018-10-16T21:20:34.8790120Z
2018-10-16T21:20:34.8790240Z
2018-10-16T21:20:34.9038050Z CMake Warning at Tests/CMakeLists.txt:10 (add_executable):
2018-10-16T21:20:34.9039330Z   Cannot generate a safe runtime search path for target PlanTest because
2018-10-16T21:20:34.9040510Z   there is a cycle in the constraint graph:
2018-10-16T21:20:34.9040720Z
2018-10-16T21:20:34.9042750Z     dir 0 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib]
2018-10-16T21:20:34.9043590Z       dir 1 must precede it due to runtime library [libz.dylib]
2018-10-16T21:20:34.9044690Z     dir 1 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_build_env/lib]
2018-10-16T21:20:34.9044950Z       dir 0 must precede it due to runtime library [libbz2.dylib]
2018-10-16T21:20:34.9045090Z
2018-10-16T21:20:34.9045300Z   Some of these libraries may not be found correctly.
2018-10-16T21:20:34.9045440Z
2018-10-16T21:20:34.9045540Z
2018-10-16T21:20:34.9470270Z CMake Warning at Tests/CMakeLists.txt:47 (add_executable):
2018-10-16T21:20:34.9471190Z   Cannot generate a safe runtime search path for target
2018-10-16T21:20:34.9471730Z   DBObjectPrivilegesTest because there is a cycle in the constraint graph:
2018-10-16T21:20:34.9472110Z
2018-10-16T21:20:34.9474110Z     dir 0 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib]
2018-10-16T21:20:34.9474550Z       dir 1 must precede it due to runtime library [libz.dylib]
2018-10-16T21:20:34.9475590Z     dir 1 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_build_env/lib]
2018-10-16T21:20:34.9475840Z       dir 0 must precede it due to runtime library [libbz2.dylib]
2018-10-16T21:20:34.9475970Z
2018-10-16T21:20:34.9476170Z   Some of these libraries may not be found correctly.
2018-10-16T21:20:34.9476330Z
2018-10-16T21:20:34.9476470Z
2018-10-16T21:20:34.9803700Z CMake Warning at Tests/CMakeLists.txt:48 (add_executable):
2018-10-16T21:20:34.9804350Z   Cannot generate a safe runtime search path for target GeoTypesTest because
2018-10-16T21:20:34.9804610Z   there is a cycle in the constraint graph:
2018-10-16T21:20:34.9804770Z
2018-10-16T21:20:34.9806930Z     dir 0 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib]
2018-10-16T21:20:34.9807440Z       dir 1 must precede it due to runtime library [libz.dylib]
2018-10-16T21:20:34.9808500Z     dir 1 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_build_env/lib]
2018-10-16T21:20:34.9808760Z       dir 0 must precede it due to runtime library [libbz2.dylib]
2018-10-16T21:20:34.9808900Z
2018-10-16T21:20:34.9809110Z   Some of these libraries may not be found correctly.
2018-10-16T21:20:34.9809280Z
2018-10-16T21:20:34.9809410Z
2018-10-16T21:20:35.0091010Z CMake Warning at Tests/CMakeLists.txt:43 (add_executable):
2018-10-16T21:20:35.0091680Z   Cannot generate a safe runtime search path for target UpdelStorageTest
2018-10-16T21:20:35.0092020Z   because there is a cycle in the constraint graph:
2018-10-16T21:20:35.0092420Z
2018-10-16T21:20:35.0094350Z     dir 0 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib]
2018-10-16T21:20:35.0094860Z       dir 1 must precede it due to runtime library [libz.dylib]
2018-10-16T21:20:35.0095900Z     dir 1 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_build_env/lib]
2018-10-16T21:20:35.0096140Z       dir 0 must precede it due to runtime library [libbz2.dylib]
2018-10-16T21:20:35.0096280Z
2018-10-16T21:20:35.0096450Z   Some of these libraries may not be found correctly.
2018-10-16T21:20:35.0096640Z
2018-10-16T21:20:35.0096750Z
2018-10-16T21:20:35.0340220Z CMake Warning at Tests/CMakeLists.txt:42 (add_executable):
2018-10-16T21:20:35.0340860Z   Cannot generate a safe runtime search path for target AlterColumnTest
2018-10-16T21:20:35.0341240Z   because there is a cycle in the constraint graph:
2018-10-16T21:20:35.0341840Z
2018-10-16T21:20:35.0343980Z     dir 0 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib]
2018-10-16T21:20:35.0344430Z       dir 1 must precede it due to runtime library [libz.dylib]
2018-10-16T21:20:35.0345550Z     dir 1 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_build_env/lib]
2018-10-16T21:20:35.0345820Z       dir 0 must precede it due to runtime library [libbz2.dylib]
2018-10-16T21:20:35.0346360Z
2018-10-16T21:20:35.0346580Z   Some of these libraries may not be found correctly.
2018-10-16T21:20:35.0346700Z
2018-10-16T21:20:35.0346810Z
2018-10-16T21:20:35.0678800Z CMake Warning at Tests/CMakeLists.txt:41 (add_executable):
2018-10-16T21:20:35.0679480Z   Cannot generate a safe runtime search path for target ImportTest because
2018-10-16T21:20:35.0679910Z   there is a cycle in the constraint graph:
2018-10-16T21:20:35.0680820Z
2018-10-16T21:20:35.0683140Z     dir 0 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib]
2018-10-16T21:20:35.0683650Z       dir 1 must precede it due to runtime library [libz.dylib]
2018-10-16T21:20:35.0684760Z     dir 1 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_build_env/lib]
2018-10-16T21:20:35.0685050Z       dir 0 must precede it due to runtime library [libbz2.dylib]
2018-10-16T21:20:35.0685210Z
2018-10-16T21:20:35.0685420Z   Some of these libraries may not be found correctly.
2018-10-16T21:20:35.0685560Z
2018-10-16T21:20:35.0685700Z
2018-10-16T21:20:35.1110950Z CMake Warning at Tests/CMakeLists.txt:39 (add_executable):
2018-10-16T21:20:35.1111680Z   Cannot generate a safe runtime search path for target StorageTest because
2018-10-16T21:20:35.1112080Z   there is a cycle in the constraint graph:
2018-10-16T21:20:35.1112510Z
2018-10-16T21:20:35.1114390Z     dir 0 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib]
2018-10-16T21:20:35.1114850Z       dir 1 must precede it due to runtime library [libz.dylib]
2018-10-16T21:20:35.1115900Z     dir 1 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_build_env/lib]
2018-10-16T21:20:35.1116180Z       dir 0 must precede it due to runtime library [libbz2.dylib]
2018-10-16T21:20:35.1116350Z
2018-10-16T21:20:35.1116540Z   Some of these libraries may not be found correctly.
2018-10-16T21:20:35.1116680Z
2018-10-16T21:20:35.1116790Z
2018-10-16T21:20:35.1502560Z CMake Warning at Tests/CMakeLists.txt:36 (add_executable):
2018-10-16T21:20:35.1503370Z   Cannot generate a safe runtime search path for target ResultSetTest because
2018-10-16T21:20:35.1503630Z   there is a cycle in the constraint graph:
2018-10-16T21:20:35.1503820Z
2018-10-16T21:20:35.1505850Z     dir 0 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib]
2018-10-16T21:20:35.1506310Z       dir 1 must precede it due to runtime library [libz.dylib]
2018-10-16T21:20:35.1507350Z     dir 1 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_build_env/lib]
2018-10-16T21:20:35.1507620Z       dir 0 must precede it due to runtime library [libbz2.dylib]
2018-10-16T21:20:35.1507770Z
2018-10-16T21:20:35.1507950Z   Some of these libraries may not be found correctly.
2018-10-16T21:20:35.1508900Z
2018-10-16T21:20:35.1509260Z
2018-10-16T21:20:35.1767820Z CMake Warning at Tests/CMakeLists.txt:7 (add_executable):
2018-10-16T21:20:35.1768460Z   Cannot generate a safe runtime search path for target ExecuteTest because
2018-10-16T21:20:35.1768820Z   there is a cycle in the constraint graph:
2018-10-16T21:20:35.1769100Z
2018-10-16T21:20:35.1770970Z     dir 0 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib]
2018-10-16T21:20:35.1771280Z       dir 1 must precede it due to runtime library [libz.dylib]
2018-10-16T21:20:35.1771920Z     dir 1 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_build_env/lib]
2018-10-16T21:20:35.1772310Z       dir 0 must precede it due to runtime library [libbz2.dylib]
2018-10-16T21:20:35.1772400Z
2018-10-16T21:20:35.1772490Z   Some of these libraries may not be found correctly.
2018-10-16T21:20:35.1772570Z
2018-10-16T21:20:35.1772620Z
2018-10-16T21:20:35.2117990Z CMake Warning at Tests/CMakeLists.txt:8 (add_executable):
2018-10-16T21:20:35.2118460Z   Cannot generate a safe runtime search path for target RunQueryLoop because
2018-10-16T21:20:35.2118930Z   there is a cycle in the constraint graph:
2018-10-16T21:20:35.2119160Z
2018-10-16T21:20:35.2120970Z     dir 0 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib]
2018-10-16T21:20:35.2121370Z       dir 1 must precede it due to runtime library [libz.dylib]
2018-10-16T21:20:35.2122410Z     dir 1 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_build_env/lib]
2018-10-16T21:20:35.2122640Z       dir 0 must precede it due to runtime library [libbz2.dylib]
2018-10-16T21:20:35.2122760Z
2018-10-16T21:20:35.2122930Z   Some of these libraries may not be found correctly.
2018-10-16T21:20:35.2123050Z
2018-10-16T21:20:35.2123170Z
2018-10-16T21:20:35.2485120Z CMake Warning at Tests/CMakeLists.txt:40 (add_executable):
2018-10-16T21:20:35.2485520Z   Cannot generate a safe runtime search path for target StoragePerfTest
2018-10-16T21:20:35.2486110Z   because there is a cycle in the constraint graph:
2018-10-16T21:20:35.2486350Z
2018-10-16T21:20:35.2488260Z     dir 0 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib]
2018-10-16T21:20:35.2488580Z       dir 1 must precede it due to runtime library [libz.dylib]
2018-10-16T21:20:35.2489230Z     dir 1 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_build_env/lib]
2018-10-16T21:20:35.2489380Z       dir 0 must precede it due to runtime library [libbz2.dylib]
2018-10-16T21:20:35.2489450Z
2018-10-16T21:20:35.2489550Z   Some of these libraries may not be found correctly.
2018-10-16T21:20:35.2489630Z
2018-10-16T21:20:35.2489680Z
2018-10-16T21:20:35.2761700Z CMake Warning at Tests/CMakeLists.txt:11 (add_executable):
2018-10-16T21:20:35.2762280Z   Cannot generate a safe runtime search path for target ProfileTest because
2018-10-16T21:20:35.2762550Z   there is a cycle in the constraint graph:
2018-10-16T21:20:35.2762960Z
2018-10-16T21:20:35.2765070Z     dir 0 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib]
2018-10-16T21:20:35.2765460Z       dir 1 must precede it due to runtime library [libz.dylib]
2018-10-16T21:20:35.2766110Z     dir 1 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_build_env/lib]
2018-10-16T21:20:35.2766250Z       dir 0 must precede it due to runtime library [libbz2.dylib]
2018-10-16T21:20:35.2766340Z
2018-10-16T21:20:35.2770590Z   Some of these libraries may not be found correctly.
2018-10-16T21:20:35.2770660Z
2018-10-16T21:20:35.2770720Z
2018-10-16T21:20:35.3090920Z CMake Warning at Tests/CMakeLists.txt:37 (add_executable):
2018-10-16T21:20:35.3091400Z   Cannot generate a safe runtime search path for target
2018-10-16T21:20:35.3092110Z   ResultSetBaselineRadixSortTest because there is a cycle in the constraint
2018-10-16T21:20:35.3092560Z   graph:
2018-10-16T21:20:35.3092690Z
2018-10-16T21:20:35.3094450Z     dir 0 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib]
2018-10-16T21:20:35.3095190Z       dir 1 must precede it due to runtime library [libz.dylib]
2018-10-16T21:20:35.3096250Z     dir 1 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_build_env/lib]
2018-10-16T21:20:35.3096510Z       dir 0 must precede it due to runtime library [libbz2.dylib]
2018-10-16T21:20:35.3096680Z
2018-10-16T21:20:35.3096880Z   Some of these libraries may not be found correctly.
2018-10-16T21:20:35.3097010Z
2018-10-16T21:20:35.3097130Z
2018-10-16T21:20:35.3378390Z CMake Warning at Tests/CMakeLists.txt:44 (add_executable):
2018-10-16T21:20:35.3378770Z   Cannot generate a safe runtime search path for target TopKTest because
2018-10-16T21:20:35.3378960Z   there is a cycle in the constraint graph:
2018-10-16T21:20:35.3379030Z
2018-10-16T21:20:35.3381240Z     dir 0 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib]
2018-10-16T21:20:35.3381790Z       dir 1 must precede it due to runtime library [libz.dylib]
2018-10-16T21:20:35.3382850Z     dir 1 is [/Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_build_env/lib]
2018-10-16T21:20:35.3383160Z       dir 0 must precede it due to runtime library [libbz2.dylib]
2018-10-16T21:20:35.3383330Z
2018-10-16T21:20:35.3383520Z   Some of these libraries may not be found correctly.
2018-10-16T21:20:35.3383680Z
2018-10-16T21:20:35.3383790Z
2018-10-16T21:20:35.4154820Z -- Generating done
2018-10-16T21:20:35.5093940Z -- Build files have been written to: /Users/vsts/conda-bld/mapd-core-cpu_1539724402879/work/build
2018-10-16T21:20:35.5332670Z + make ParserFiles
2018-10-16T21:20:35.7098030Z Scanning dependencies of target ParserFiles
2018-10-16T21:20:35.7403080Z Generating Parser.cpp
2018-10-16T21:20:35.7594220Z /Users/vsts/conda-bld/mapd-core-cpu_1539724402879/work/Parser/parser.y contains 1 useless nonterminal and 2 useless rules.
2018-10-16T21:20:35.7623290Z /Users/vsts/conda-bld/mapd-core-cpu_1539724402879/work/Parser/parser.y contains 5 shift/reduce conflicts and 2 reduce/reduce conflicts.
2018-10-16T21:20:35.8336670Z Built target ParserFiles
2018-10-16T21:20:35.8619880Z + make
2018-10-16T21:20:36.6413730Z Scanning dependencies of target Utils
2018-10-16T21:20:36.7164910Z [  0%] Building CXX object Utils/CMakeFiles/Utils.dir/StringLike.cpp.o
2018-10-16T21:20:37.0123300Z [  1%] Building CXX object Utils/CMakeFiles/Utils.dir/Regexp.cpp.o
2018-10-16T21:20:37.0629720Z In file included from /Users/vsts/conda-bld/mapd-core-cpu_1539724402879/work/Utils/Regexp.cpp:28:
2018-10-16T21:20:37.0631440Z In file included from /Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/../include/boost/regex.hpp:28:
2018-10-16T21:20:37.0633220Z In file included from /Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/../include/boost/regex/config.hpp:44:
2018-10-16T21:20:37.0641690Z In file included from /Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/../include/boost/config.hpp:44:
2018-10-16T21:20:37.0643460Z /Users/vsts/conda-bld/mapd-core-cpu_1539724402879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/../include/boost/config/detail/select_stdlib_config.hpp:18:12: fatal error: 'cstddef' file not found
2018-10-16T21:20:37.0644200Z #  include <cstddef>
2018-10-16T21:20:37.0644430Z            ^~~~~~~~~
2018-10-16T21:20:37.5114660Z 1 error generated.
2018-10-16T21:20:37.5148450Z make[2]: *** [Utils/CMakeFiles/Utils.dir/Regexp.cpp.o] Error 1
2018-10-16T21:20:37.5152940Z make[1]: *** [Utils/CMakeFiles/Utils.dir/all] Error 2
2018-10-16T21:20:37.5156580Z make: *** [all] Error 2
2018-10-16T21:20:38.2800210Z Source cache directory is: /Users/vsts/conda-bld/src_cache
2018-10-16T21:20:38.2800640Z Downloading source to cache: v4.1.1_b8967cd5e8.tar.gz
2018-10-16T21:20:38.2801470Z Downloading https://github.com/mapd/mapd-core/archive/v4.1.1.tar.gz

any idea about how to workaround this problem?
cc @pearu @andrewseidl

Which version of boost are you using, and how was it installed? https://stackoverflow.com/questions/13404500/compile-boost-c11-clang-mac-cannot-find-cstddef#13404829


Merge main into feature/click-cli

resolves #

Description

Checklist

[ ] I have read the contributing guide and understand what's expected of me
[ ] I have signed the CLA
[ ] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[ ] I have run changie new to create a changelog entry

@iknox-fa I assume this is good to close!


Handling of numbers

Triggered by Issue #18, I deeply considered the handling of numeric sequences. And I identified the following four patterns:

A pattern where a word separator is inserted after the numeric sequence (e.g., abc123_def)
A pattern where a word separator is inserted before the numeric sequence (e.g., abc_1st_def)
A pattern where word separators are inserted both before and after the numeric sequence (e.g., abc_123_def)
A pattern where no word separators are inserted around the numeric sequence (e.g., a1b2c_def)

Corresponding to these patterns, the following four functions can be provided for each conversion:

pub fn xxx_case_with_nums_as_last(&str) -> String
pub fn xxx_case_with_nums_as_head(&str) -> String
pub fn xxx_case_with_nums_as_word(&str) -> String
pub fn xxx_case_with_nums_as_part(&str) -> String

Among these, xxx_with_nums_as_last is the current default function.
pub use xxx_case_with_nums_as_last as xxx_case;

This issue can be reframed as whether or not to treat the beginning of a numeric sequence as the start of a word.
// Treat the beginning of a numeric sequence as the start of a word.
ThisIsThe10thItem  --> this_is_the_10th_item
ThisIs10Items --> this_is_10_items

// Not treat the beginning of a numeric sequence as the start of a word.
TheImportanceOfI18nSupport --> the_importance_of_i18n_support
Windows11IsAnOs --> windows11_is_an_os

How about symbols?

// Treat the beginning of a numeric sequence as the start of a word.
ThisIsThe10thItem  --> this_is_the_10th_item
ThisIs10Items --> this_is_10_items

// Not treat the beginning of a numeric sequence as the start of a word.
I18nSupport --> i18n_support
Windows11IsAnOSByMS --> windows11_is_an_os_by_ms

// Treat a numeric sequence as upper case
I18NSupport --> i18n_support


Add information of reload4j fork

Provide link to reload4j project, initiated by original author of Apache log4j 1.x.

We usually avoid linking to other projects, but this one is definitely helpful for Log4j users. Made a small change to make the text more contextual.
Thanks a lot 💯

Thank you @captn3m0
Given the omnipresence of log4j 1.x on the web, and the gain provided by the reload4j project for those users, what would you think of adding reload4j as a dedicated version in the support table ?
Something like this :

I think this will mostly confuse users rather than being helpful. If reload4j ends up gaining usage, we can give it its own page.
I don't want to mingle two products in the same page, since our API is used programmatically and such entries will confuse tools.

I fully understand this position. 👌
thanks


Maintainer Status?

Wondering: Is anyone maintaining this repository?  This is the repository listed by default in the Ionic Native documentation.  Functionality like Clear Button (#171) have been sitting around for months. I have a working solution but it's not worth putting together pull requests if we're not going to get them pulled into this main repo.

Do you have the working version on Github? wouldn't mind taking a look, i don't see it in your forks.

@NickyYo You can find the changeset I'm talking about here.

Bump, I am also curious about this -- @VitaliiBlagodir ?

It appears that the maintainer hasn't been active since November last year.

This repo is inactive because user isn't working... no is more active see https://github.com/VitaliiBlagodir

In instances where the maintainer is no longer active, does anyone know if there is a way for someone else to take ownership? Does github allow this without action from the current maintainer?

GitHub admin no will give access of repo to other users (see TOS) but anyone can fork project and make changes.
I can't because I'm not code Java, but if you know, fork this and add issue warning other users to send changes to you.

yeah forking kind of sucks tho since now there are a ton of forks all over the place. It is kind of a shame. This plugin is actually pretty good at what it does and just needs someone to keep up with the PRs at least. I wish there was a non-native solution that looked like the native pickers. Even ionic's components look funky to me and they are the best out there (unless I am missing something).

I've opened a separate issue with Ionic to see what the policy moving forward should be for these situations.


pkg/runtest: check arch requirement early

Need to check arch requirement early as some programs
may fail to deserialize on some arches due to missing syscalls.
See discussion on #2380.
Also support negative arch requirements (-arch=amd64).

Excellent! This fix unsupported syscall in TestParsing for #2380. Thanks!


Duplicate GlobalKey error when updating child during layout

Hi! I'm trying to write a layout builder widget that passes another widget's size to build its child. It kinda works similarly to LayoutBuilder, except it takes a child argument which is the widget that its size is passed to the builder function. To measure the child's size, it's added as a child to the layout builder widget using updateChild method, then at the layout phase, after laying out the child, its size (and the widget itself) is passed to the builder (indirectly using invokeLayoutCallback and owner.buildScope). Finally, the widget returned by the builder is used to update the child using updateChild.
It works as expected but if the child widget is used in the builder it will result in inflating and laying out the widget twice. To prevent this I used a wrapping widget for the child widget with a global key to allow the framework to do its thing and move the element to its new place in the tree. The end result.
Finally to the error.
Steps to Reproduce

Run flutter create bug.
include the file in lib provided above.
change main.dart to the following

import 'package:flutter/material.dart';
import 'size_layout_builder.dart';

final firstKey = GlobalKey(debugLabel: 'first');

void main() {
  WidgetsFlutterBinding.ensureInitialized();
  runApp(TestApp());
}

class TestApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: TestWidget(),
      ),
    );
  }
}

class TestWidget extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return SizeLayoutBuilder(
      child: Container(
        key: firstKey,
        padding: const EdgeInsets.all(32.0),
        color: Colors.green,
      ),
      builder: (context, size, _) {
        return Container(
          padding: const EdgeInsets.all(32.0),
          color: Colors.blue,
          child: Container(
            key: firstKey,
            padding: const EdgeInsets.all(32.0),
            color: Colors.green,
          ),
        );
      },
    );
  }
}

Expected results:
Expect no errors, correct me if I'm wrong, but since the global key of child widget and widget with same key in builder don't exist in the tree at the same time (once the tree is finalized) there should not be any errors
Actual results:
An exception is thrown by the framework stating that Multiple widgets used the same GlobalKey (firstKey). If I removed the firstKey global key, or the wrapping widget's key the error disappears.
════════ Exception caught by widgets library ═══════════════════════════════════
The following assertion was thrown while finalizing the widget tree:
Multiple widgets used the same GlobalKey.

The key [GlobalKey#56c45 first] was used by multiple widgets. The parents of those widgets were:
- _WrapperWidget-[GlobalKey#76b2a SizeLayoutBuilderChildWrapperKey]
- Padding(padding: EdgeInsets.all(32.0), dependencies: [Directionality], renderObject: RenderPadding#f0c9c relayoutBoundary=up4)
A GlobalKey can only be specified on one widget at a time in the widget tree.
When the exception was thrown, this was the stack
#0      GlobalKey._debugVerifyGlobalKeyReservation.<anonymous closure>.<anonymous closure>.<anonymous closure>
package:flutter/…/widgets/framework.dart:246
#1      _LinkedHashMapMixin.forEach  (dart:collection-patch/compact_hash.dart:379:8)
#2      GlobalKey._debugVerifyGlobalKeyReservation.<anonymous closure>.<anonymous closure>
package:flutter/…/widgets/framework.dart:193
#3      _LinkedHashMapMixin.forEach  (dart:collection-patch/compact_hash.dart:379:8)
#4      GlobalKey._debugVerifyGlobalKeyReservation.<anonymous closure>
package:flutter/…/widgets/framework.dart:189
...
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by widgets library ═══════════════════════════════════
Multiple widgets used the same GlobalKey.
════════════════════════════════════════════════════════════════════════════════```

Logs
~$ flutter doctor -v

[✓] Flutter (Channel stable, v1.17.5, on Linux, locale en_US.UTF-8)
    • Flutter version 1.17.5 at /home/akram/Desktop/tools/flutter/flutter
    • Framework revision 8af6b2f038 (10 days ago), 2020-06-30 12:53:55 -0700
    • Engine revision ee76268252
    • Dart version 2.8.4

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /home/akram/Desktop/tools/android/Sdk
    • Platform android-29, build-tools 28.0.3
    • ANDROID_HOME = /home/akram/Desktop/tools/android/Sdk
    • Java binary at: /home/akram/Desktop/tools/android/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
    • All Android licenses accepted.

[✓] Android Studio (version 3.3)
    • Android Studio at /home/akram/Desktop/tools/android/android-studio
    • Flutter plugin version 23.2.1
    • Dart plugin version 171.4424
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[✓] VS Code (version 1.39.2)
    • VS Code at /usr/share/code
    • Flutter extension version 3.7.1

[✓] Connected device (1 available)
    • AMN LX9 • 7YBNU19816107646 • android-arm • Android 9 (API 28)

• No issues found!

Code Sample
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';

final firstKey = GlobalKey(debugLabel: 'first');

void main() {
  WidgetsFlutterBinding.ensureInitialized();
  runApp(TestApp());
}

class TestApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: TestWidget(),
      ),
    );
  }
}

class TestWidget extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return SizeLayoutBuilder(
      child: Container(
        key: firstKey,
        padding: const EdgeInsets.all(32.0),
        color: Colors.green,
      ),
      builder: (context, size, _) {
        return Container(
          padding: const EdgeInsets.all(32.0),
          color: Colors.blue,
          child: Container(
            key: firstKey,
            padding: const EdgeInsets.all(32.0),
            color: Colors.green,
          ),
        );
      },
    );
  }
}

class _WrapperWidget extends StatelessWidget {
  _WrapperWidget({this.child, Key key}) : super(key: key);

  final Widget child;

  @override
  Widget build(BuildContext context) {
    return child;
  }
}

/// The signature of the [SizeLayoutBuilder] builder function.
typedef LayoutWidgetBuilder = Widget Function(
    BuildContext context, Size size, Widget child);

/// An abstract superclass for widgets that defer their building until layout.
///
/// Similar to the [Builder] widget except that the framework calls the [builder]
/// function at layout time and provides the size of the child widget.
class SizeLayoutBuilder extends RenderObjectWidget {
  /// Creates a widget that defers its building until layout.
  ///
  /// The [builder] and [child] arguments must not be null,
  /// and the returned widget should not be null.
  const SizeLayoutBuilder({
    Key key,
    @required this.child,
    @required this.builder,
  })  : assert(builder != null),
        assert(child != null),
        super(key: key);

  @override
  _SizeLayoutBuilderElement createElement() => _SizeLayoutBuilderElement(this);

  @override
  _RenderSizeLayoutBuilder createRenderObject(BuildContext context) =>
      _RenderSizeLayoutBuilder();

  /// Called at layout time to construct the widget tree.
  ///
  /// The builder must not return null.
  final LayoutWidgetBuilder builder;

  final Widget child;

  // updateRenderObject is redundant with the logic in the LayoutBuilderElement below.
}

class _SizeLayoutBuilderElement extends RenderObjectElement {
  _SizeLayoutBuilderElement(SizeLayoutBuilder widget) : super(widget);

  @override
  SizeLayoutBuilder get widget => super.widget;

  @override
  _RenderSizeLayoutBuilder get renderObject => super.renderObject;

  Element _child;

  // used to wrap widget.child with a global key so that moving it in widget.builder
  // doesn't result in rebuilding the child.
  final childKey = GlobalKey(debugLabel: 'SizeLayoutBuilderChildWrapperKey');

  @override
  void visitChildren(ElementVisitor visitor) {
    if (_child != null) visitor(_child);
  }

  @override
  void forgetChild(Element child) {
    super.forgetChild(child);
    assert(child == _child);
    _child = null;
  }

  @override
  void mount(Element parent, dynamic newSlot) {
    super.mount(parent, newSlot); // Creates the renderObject.
    onWidgetChildChanged();
    renderObject.updateCallback(_layout);
  }

  @override
  void update(SizeLayoutBuilder newWidget) {
    assert(widget != newWidget);
    super.update(newWidget);
    assert(widget == newWidget);
    onWidgetChildChanged();
    renderObject.updateCallback(_layout);
    renderObject.markNeedsLayout();
  }

  void onWidgetChildChanged() {
    // optimization for when this widget is potentially moved in widget.builder
    // since flutter doesn't have tree diffing moving the child without using a global widget
    // will result in the widget rebuilding itself unncessarily.
    final wrapper = _WrapperWidget(key: childKey, child: widget.child);
    _child = updateChild(_child, wrapper, null);
  }

  @override
  void performRebuild() {
    // This gets called if markNeedsBuild() is called on us.
    // That might happen if, e.g., our builder uses Inherited widgets.
    renderObject.markNeedsLayout();
    super
        .performRebuild(); // Calls widget.updateRenderObject (a no-op in this case).
  }

  @override
  void unmount() {
    renderObject.updateCallback(null);
    super.unmount();
  }

  void _layout(Size size) {
    owner.buildScope(this, () {
      Widget built;
      if (widget.builder != null) {
        try {
          built = widget.builder(this, size, _child.widget);
          debugWidgetBuilderValue(widget, built);
        } catch (e, stack) {
          built = ErrorWidget.builder(
            _debugReportException(
              ErrorDescription('building $widget'),
              e,
              stack,
              informationCollector: () sync* {
                yield DiagnosticsDebugCreator(DebugCreator(this));
              },
            ),
          );
        }
      }
      try {
        _child = updateChild(_child, built, null);
        assert(_child != null);
      } catch (e, stack) {
        built = ErrorWidget.builder(
          _debugReportException(
            ErrorDescription('building $widget'),
            e,
            stack,
            informationCollector: () sync* {
              yield DiagnosticsDebugCreator(DebugCreator(this));
            },
          ),
        );
        _child = updateChild(null, built, slot);
      }
    });
  }

  @override
  void insertChildRenderObject(RenderObject child, dynamic slot) {
    final RenderObjectWithChildMixin<RenderObject> renderObject =
        this.renderObject;
    assert(slot == null);
    assert(renderObject.debugValidateChild(child));
    renderObject.child = child;
    assert(renderObject == this.renderObject);
  }

  @override
  void moveChildRenderObject(RenderObject child, dynamic slot) {
    assert(false);
  }

  @override
  void removeChildRenderObject(RenderObject child) {
    final _RenderSizeLayoutBuilder renderObject = this.renderObject;
    assert(renderObject.child == child);
    renderObject.child = null;
    assert(renderObject == this.renderObject);
  }
}

class _RenderSizeLayoutBuilder extends RenderBox
    with RenderObjectWithChildMixin<RenderBox> {
  void Function(Size size) _callback;

  /// Change the layout callback.
  void updateCallback(void Function(Size size) value) {
    if (value == _callback) return;
    _callback = value;
    markNeedsLayout();
  }

  /// Invoke the layout callback.
  void layoutAndBuildChild(Size size) {
    assert(_callback != null);

    invokeLayoutCallback((constraints) {
      _callback(size);
    });
  }

  @override
  double computeMinIntrinsicWidth(double height) {
    assert(_debugThrowIfNotCheckingIntrinsics());
    return 0.0;
  }

  @override
  double computeMaxIntrinsicWidth(double height) {
    assert(_debugThrowIfNotCheckingIntrinsics());
    return 0.0;
  }

  @override
  double computeMinIntrinsicHeight(double width) {
    assert(_debugThrowIfNotCheckingIntrinsics());
    return 0.0;
  }

  @override
  double computeMaxIntrinsicHeight(double width) {
    assert(_debugThrowIfNotCheckingIntrinsics());
    return 0.0;
  }

  @override
  void performLayout() {
    assert(child != null);
    child.layout(constraints, parentUsesSize: true);
    layoutAndBuildChild(child.size);
    child.layout(constraints, parentUsesSize: true);
    size = constraints.constrain(child.size);
  }

  @override
  bool hitTestChildren(BoxHitTestResult result, {Offset position}) {
    return child?.hitTest(result, position: position) ?? false;
  }

  @override
  void paint(PaintingContext context, Offset offset) {
    assert(child != null);
    context.paintChild(child, offset);
  }

  bool _debugThrowIfNotCheckingIntrinsics() {
    assert(() {
      if (!RenderObject.debugCheckingIntrinsics) {
        throw FlutterError(
            'SizeLayoutBuilder does not support returning intrinsic dimensions.\n'
            'Calculating the intrinsic dimensions would require running the layout '
            'callback speculatively, which might mutate the live render object tree.');
      }
      return true;
    }());

    return true;
  }
}

FlutterErrorDetails _debugReportException(
  DiagnosticsNode context,
  dynamic exception,
  StackTrace stack, {
  InformationCollector informationCollector,
}) {
  final FlutterErrorDetails details = FlutterErrorDetails(
    exception: exception,
    stack: stack,
    context: context,
    informationCollector: informationCollector,
  );
  FlutterError.reportError(details);
  return details;
}

flutter doctor -v
[✓] Flutter (Channel dev, 1.20.0-7.1.pre, on Mac OS X 10.15.5 19F101, locale
    en-GB)
    • Flutter version 1.20.0-7.1.pre at /Users/taha/Code/flutter_dev
    • Framework revision 7736f3bc90 (2 days ago), 2020-07-10 16:33:05 -0700
    • Engine revision d48085141c
    • Dart version 2.9.0 (build 2.9.0-21.2.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/taha/Code/sdk
    • Platform android-30, build-tools 30.0.0
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.47.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.2

[✓] Connected device (4 available)
    • SM M305F (mobile) • 32003c30dc19668f • android-arm64  • Android 10 (API
      29)
    • macOS (desktop)   • macos            • darwin-x64     • Mac OS X 10.15.5
      19F101
    • Web Server (web)  • web-server       • web-javascript • Flutter Tools
    • Chrome (web)      • chrome           • web-javascript • Google Chrome
      83.0.4103.116

• No issues found!

Can you try to reduce your code sample to isolate the error? SizeLayoutBuilder is ~300 lines, which are probably not all relevant.

Well, I wanted to provide a working example. Most of the clutter is required by the RenderObject/Element protocol or comments to help in understanding the code. Here are the relevant parts just so you can read the gist of it, but it won't compile
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';

typedef LayoutWidgetBuilder = Widget Function(BuildContext context, Size size, Widget child);

class SizeLayoutBuilder extends RenderObjectWidget {
  const SizeLayoutBuilder({
    Key key,
    @required this.child,
    @required this.builder,
  }) : super(key: key);

  final LayoutWidgetBuilder builder;

  final Widget child;
}

class _SizeLayoutBuilderElement extends RenderObjectElement {
  _SizeLayoutBuilderElement(SizeLayoutBuilder widget) : super(widget);

  @override
  SizeLayoutBuilder get widget => super.widget;

  @override
  _RenderSizeLayoutBuilder get renderObject => super.renderObject;

  Element _child;

  // used to wrap widget.child with a global key so that moving it in widget.builder
  // doesn't result in rebuilding the child.
  final childKey = GlobalKey(debugLabel: 'SizeLayoutBuilderChildWrapperKey');

  @override
  void mount(Element parent, dynamic newSlot) {
    super.mount(parent, newSlot); // Creates the renderObject.
    onWidgetChildChanged();
    renderObject.updateCallback(_layout);
  }

  @override
  void update(SizeLayoutBuilder newWidget) {
    assert(widget != newWidget);
    super.update(newWidget);
    assert(widget == newWidget);
    onWidgetChildChanged();
    renderObject.updateCallback(_layout);
    renderObject.markNeedsLayout();
  }

  void onWidgetChildChanged() {
    final wrapper = _WrapperWidget(key: childKey, child: widget.child);
    _child = updateChild(_child, wrapper, null);
  }

  @override
  void performRebuild() {
    renderObject.markNeedsLayout();
    super.performRebuild();
  }

  void _layout(Size size) {
    owner.buildScope(this, () {
      Widget built;
      if (widget.builder != null) {
        built = widget.builder(this, size, _child.widget);
      }
      _child = updateChild(_child, built, null);
    });
  }
}

class _RenderSizeLayoutBuilder extends RenderBox
    with RenderObjectWithChildMixin<RenderBox> {
  void Function(Size size) _callback;

  void updateCallback(void Function(Size size) value) {
    if (value == _callback) return;
    _callback = value;
    markNeedsLayout();
  }

  void layoutAndBuildChild(Size size) {
    assert(_callback != null);

    invokeLayoutCallback((constraints) {
      _callback(size);
    });
  }

  @override
  void performLayout() {
    assert(child != null);
    child.layout(constraints, parentUsesSize: true);
    layoutAndBuildChild(child.size);
    child.layout(constraints, parentUsesSize: true);
    size = constraints.constrain(child.size);
  }
}

@AkramIzz This issue has been fixed recently, via #62323

Hi @AkramIzz
i can confirm this issue  is fixed on latest master

flutter doctor -v
[✓] Flutter (Channel master, 1.21.0-6.0.pre.160, on Mac OS X 10.15.6 19G73,
    locale en-GB)
    • Flutter version 1.21.0-6.0.pre.160 at /Users/taha/Code/flutter_master
    • Framework revision 31ee51a302 (10 hours ago), 2020-08-03 17:27:21 -0700
    • Engine revision fa16c3d0ba
    • Dart version 2.10.0 (build 2.10.0-2.0.dev 0f0e04ec3a)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /Users/taha/Code/sdk
    • Platform android-30, build-tools 30.0.1
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 48.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.47.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.13.1

[✓] Connected device (5 available)
    • Taha’s iPhone (mobile) • 00008020-001059882212002E            • ios            • iOS 13.6
    • iPhone 11 (mobile)     • 1EB615AF-5AB9-4AAA-A587-A6642BB79484 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-13-6 (simulator)
    • macOS (desktop)        • macos                                • darwin-x64     • Mac OS X
      10.15.6 19G73
    • Web Server (web)       • web-server                           • web-javascript • Flutter Tools
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome
      84.0.4147.105

• No issues found!

Closing, as fixed, please write in the comments and I will reopen it.
Thank you


No good way to verify whether the command was successful

Follow the Getting Started guide and ran the command.
It was wrong as the registry was not actually listening on port 5000 -- there was the airplay receiver in the MacBook which was listening on this port and I had to disable it and reran the registry to ensure it worked.
Then I tried it with this output:
$ helmper

 _         _
| |_  ___ | | _____  ___  ___  ___
|   || -_|| ||     || . || -_||  _|
|_|_||___||_||_|_|_||  _||___||_|
                    |_|
version 0.1.3 (commit 7a22623ca5f11659d6ead6e91dedd48b1965e01f, built at 2024-05-29T20:21:22Z)

{"time":"2024-05-30T17:03:45.044219+08:00","level":"INFO","msg":"Updated all Helm repositories ✅"}
+---+----------+------------+---------+----------------+--------+---------+--------------------------+---------+----------------------------------+---------+
| # | TYPE     | CHART      | VERSION | LATEST VERSION | LATEST | VALUES  | SUBCHART                 | VERSION | CONDITION                        | ENABLED |
+---+----------+------------+---------+----------------+--------+---------+--------------------------+---------+----------------------------------+---------+
| 0 | Chart    | prometheus | 25.8.0  | 25.21.0        | ❌     | default |                          |         |                                  |         |
| 1 | Subchart |            |         |                |        | parent  | alertmanager             | 1.7.*   | alertmanager.enabled             | ✅      |
| 2 | Subchart |            |         |                |        | parent  | kube-state-metrics       | 5.15.*  | kube-state-metrics.enabled       | ✅      |
| 3 | Subchart |            |         |                |        | parent  | prometheus-node-exporter | 4.24.*  | prometheus-node-exporter.enabled | ✅      |
| 4 | Subchart |            |         |                |        | parent  | prometheus-pushgateway   | 2.4.*   | prometheus-pushgateway.enabled   | ✅      |
+---+----------+------------+---------+----------------+--------+---------+--------------------------+---------+----------------------------------+---------+
 100% [===============] (5/5) Parsing charts...
+---+--------------------------+---------------+---------------------------------------------+----------------------------------------------------------------+
| # | HELM CHART               | CHART VERSION | HELM VALUE PATH                             | IMAGE                                                          |
+---+--------------------------+---------------+---------------------------------------------+----------------------------------------------------------------+
| 0 | prometheus               | 25.8.0        | server.image.digest                         | quay.io/prometheus/prometheus:v2.48.0                          |
|   |                          |               | server.image.repository                     |                                                                |
|   |                          |               | server.image.tag                            |                                                                |
| 1 | prometheus               | 25.8.0        | configmapReload.prometheus.image.digest     | quay.io/prometheus-operator/prometheus-config-reloader:v0.67.0 |
|   |                          |               | configmapReload.prometheus.image.repository |                                                                |
|   |                          |               | configmapReload.prometheus.image.tag        |                                                                |
| 2 | alertmanager             | 1.7.*         | image.repository                            | quay.io/prometheus/alertmanager:v0.26.0                        |
|   |                          |               | image.tag                                   |                                                                |
| 3 | kube-state-metrics       | 5.15.*        | image.repository                            | registry.k8s.io/kube-state-metrics/kube-state-metrics:v2.10.1  |
|   |                          |               | image.sha                                   |                                                                |
|   |                          |               | image.tag                                   |                                                                |
|   |                          |               | image.registry                              |                                                                |
| 4 | prometheus-node-exporter | 4.24.*        | image.digest                                | quay.io/prometheus/node-exporter:v1.7.0                        |
|   |                          |               | image.registry                              |                                                                |
|   |                          |               | image.repository                            |                                                                |
|   |                          |               | image.tag                                   |                                                                |
| 5 | prometheus-pushgateway   | 2.4.*         | image.repository                            | quay.io/prometheus/pushgateway:v1.6.2                          |
|   |                          |               | image.tag                                   |                                                                |
+---+--------------------------+---------------+---------------------------------------------+----------------------------------------------------------------+
+---+--------------------------+---------------+----------------------------------------------------------------+----------+--------+
| # | HELM CHART               | CHART VERSION | IMAGE                                                          | REGISTRY | IMPORT |
+---+--------------------------+---------------+----------------------------------------------------------------+----------+--------+
| 0 | prometheus               | 25.8.0        | quay.io/prometheus/prometheus:v2.48.0                          | ❌       | ✅     |
| 1 | prometheus               | 25.8.0        | quay.io/prometheus-operator/prometheus-config-reloader:v0.67.0 | ❌       | ✅     |
| 2 | alertmanager             | 1.7.*         | quay.io/prometheus/alertmanager:v0.26.0                        | ❌       | ✅     |
| 3 | kube-state-metrics       | 5.15.*        | registry.k8s.io/kube-state-metrics/kube-state-metrics:v2.10.1  | ❌       | ✅     |
| 4 | prometheus-node-exporter | 4.24.*        | quay.io/prometheus/node-exporter:v1.7.0                        | ❌       | ✅     |
| 5 | prometheus-pushgateway   | 2.4.*         | quay.io/prometheus/pushgateway:v1.6.2                          | ❌       | ✅     |
+---+--------------------------+---------------+----------------------------------------------------------------+----------+--------+
|   |                          |               |                                                                |          | 6      |
+---+--------------------------+---------------+----------------------------------------------------------------+----------+--------+
 100% [===============] (5/5) Pushing charts...
{"time":"2024-05-30T17:11:37.045958+08:00","level":"ERROR","msg":"Put \"http://<IP_ADDRESS>:5000/v2/prometheus-operator/prometheus-config-reloader/blobs/uploads/f88757cb-bd66-47c6-8732-8b2ed79f8b0a?_state=sSf7oEYh86CKtqXghVxPogjP1jOsNI0HcYLeyci900t7Ik5hbWUiOiJwcm9tZXRoZXVzLW9wZXJhdG9yL3Byb21ldGhldXMtY29uZmlnLXJlbG9hZGVyIiwiVVVJRCI6ImY4ODc1N2NiLWJkNjYtNDdjNi04NzMyLThiMmVkNzlmOGIwYSIsIk9mZnNldCI6MCwiU3RhcnRlZEF0IjoiMjAyNC0wNS0zMFQwOToxMToxOC4wMjM5NDAyNDZaIn0%3D&digest=sha256%3Aef1ccf1c191dcea79cfb35bfab927099c600056ce1a0ce7675dc5d114ae258f6\": readfrom tcp <IP_ADDRESS>:63733-><IP_ADDRESS>:5000: stream error: stream ID 65; INTERNAL_ERROR; received from peer"}

See there was an "ERROR" message, and then I tried to list down the entries:
$ curl http://<IP_ADDRESS>:5000/v2/_catalog
{"repositories":["busybox","charts/alertmanager","charts/kube-state-metrics","charts/prometheus","charts/prometheus-node-exporter","charts/prometheus-pushgateway","kube-state-metrics/kube-state-metrics","prometheus/alertmanager","prometheus/node-exporter","prometheus/prometheus","prometheus/pushgateway","prometheus-operator/prometheus-config-reloader"]}

So I guess the charts and images had been successfully imported.
But it feels hard to judge whether the command was successful if purely looking at the command output.

Hello again @brightzheng100, I have since you opened since issue made use that Helmper exists with non-zero exit code whenever an error occurs instead of elaborating more in the error message, as this is the error message gotten back by the registry server. If you still feel it is not clear that an error occurred, please feel free to reopen the issue.


Enable adjustable fee rate for transactions

We've got @sunidhi64 working on this!

This was merged with #119.


Search result need's detail view for needs that cannot be loaded

Currently there is no handling for the case when the need from search result cannot be loaded, if the user clicks on such need its the detail view is either empty, or, if previuosly another need's detail view was displayed, is not refreshed.

A simple fix for now is to display an empty detail view without the 'contact' button for a need whoose data cannot be loaded. The more user friendly implementation depends of how we generally decide to communicate to the user the error messages. Probably part of #105


Enhancement: Support Pydantic 1 and 2 within the same app

Summary
Since Pydantic 2 contains Pydantic 1, we should support Pydantic 1 and 2 within the same application so users can make use of Pydantic's backwards compatibility layer.
We already have everything we need for this in the Pydantic plugin, it just need to be split up.
This could also simplify testing, since we could test v1 and v2 within the same environment.

This could also simplify testing, since we could test v1 and v2 within the same environment.

This would be nice!
Would this mean we would have to constrain to pydantic>=2? Or we would support v1 in either case that v1 and v2 is installed, and only v2 if v2 installed?

The latter. I did some testing with this a while ago and it seemed to work just fine.

only v2 if v2 installed?

Should read "only v1 if v1 installed"

only v2 if v2 installed?

Should read "only v1 if v1 installed"

That's actually how I read it :upside_down_face:
So yes, the plan is to support v1 if v1 is installed, and v1 + v2 if v2 is installed.

@provinzkraut this should be closed because of #2487 no?

Closed in 2487


Error upon start [0.90.0B0]

Error during setup of component evohome_cc
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/homeassistant/setup.py", line 154, in _async_setup_component
    component.setup, hass, processed_config)  # type: ignore
  File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/config/custom_components/evohome_cc/__init__.py", line 195, in setup
    evo_data['params'] = dict(hass_config[DOMAIN])
KeyError: 'evohome'

Any ideas?

Some. evohome_cc is no more - I switched it back to evohome, which makes me suspect you're using an old version of the component?
It now supports custom_updater too. so do you wanna have a go at: https://github.com/zxdavb/evohome/wiki/Installation
Let mw know whoe you get on - happy to help if you're still stuck after that.

Well, that explains it, I just needed to update my config file ;-)

Close?


Clarify Auth behavior for secure users with passwords

On this doc:
https://www.cockroachlabs.com/docs/stable/create-user.html
This snippet:
Users with passwords can authenticate their access by entering their password at the command prompt instead of using their client certificate and key.

If we cannot find client certificate and key files matching the user, we fall back on password authentication.

cockroach sql --user=jpointsman

Is inaccurate. Should read something like:
If you wish users to authenticate with a password, you can, though users will still need to provide a client certificate and key in order to connect to CRDB.

See: https://github.com/cockroachdb/cockroach/issues/22537#issuecomment-364603744

Closing in favor of https://github.com/cockroachdb/docs/issues/3549.


Support SPHINXOPTS

This pull request attempts to add support for the SPHINXOPTS.
Fixes #14.

I add an all-caps input variable SPHINXOPTS to keep consistent with the Sphinx environment variable SPHINXOPTS, if you prefer sphinx_opts, I can change it to sphinx_opts.


Update dev-best-practices.md

Type in paragraph 4.7:

Becauase -> because

Thanks again for the feedback.
Overriding CLA check and merging.


Regression test for invalid CRC ancillary chunks

Issue #430
Not sure how to test for failure with checks enabled.
cc @anforowicz

Thanks - this is great!

Not sure how to test for failure with checks enabled.

You could add a #[test] in src/decoder/mod.rs which include_bytes!("../../tests/bugfixes/issue#430.png") and then in the test configure the non-default options for the decoder + check that the expected result gets returned.  It seems a lower priority though, so it's probably fine to postpone it or do it in a separate PR.

FYI: GitHub will automatically close an issue when a PR is merged if the PR description says something like "Fixes #430"


feat(#128): Remove Duplication Between JeoLabel and LabelInstruction"

In this PR I removed JeoLabel class as unnecessary.
All the places where JeoLabel was used were replaced with LabelInstruction class.
Add unit test for LabelInstruction class.
Closes: #128.
History:

feat(#128): remove code duplication
feat(#128): fix all the code style offences
feat(#128): add unit test for LabelInstruction

PR-Codex overview
The focus of this PR is to refactor and improve the LabelInstruction class by removing code duplication and adding unit tests.
Detailed summary

Replaced usages of JeoLabel with LabelInstruction
Added LabelInstruction constructor with XmlLabel parameter
Added UUID generation for label identifier
Updated opcode() and operands() methods in LabelInstruction
Added unit tests for LabelInstruction

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@rultor merge

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 5min)


Filter logs

Filter for time, keyword and level

All comments have been adjudicated. New refracted code is to wait till after MVP to merge into dev.


Update blueprint action path filters

I noticed that after #582 landed the equation explorer dashboard didn't update. This should fix that and also add a missing filter for the graphiti data script.

We should probably remove the "home" path, right?

Thanks a lot! Merged.


firefox-devedition-bin-unwrapped: 105.0b9 -> 106.0b3

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for firefox-devedition-bin-unwrapped is: "Mozilla Firefox, free web browser (binary package)"
meta.homepage for firefox-devedition-bin-unwrapped is: "https://www.mozilla.org/firefox/"
meta.changelog for firefox-devedition-bin-unwrapped is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 106.0b3 with grep in /nix/store/x7n0bmfxbl527ii0yx52vplqlgcw3hj7-firefox-devedition-bin-unwrapped-106.0b3
found 106.0b3 in filename of file in /nix/store/x7n0bmfxbl527ii0yx52vplqlgcw3hj7-firefox-devedition-bin-unwrapped-106.0b3

Rebuild report (if merged into master) (click to expand)

Outpath calculations were skipped for this package; total number of rebuilds unknown.

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/x7n0bmfxbl527ii0yx52vplqlgcw3hj7-firefox-devedition-bin-unwrapped-106.0b3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A firefox-devedition-bin-unwrapped https://github.com/r-ryantm/nixpkgs/archive/ce858853d5ba0d51b05b780eef5c2b42442764a6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/x7n0bmfxbl527ii0yx52vplqlgcw3hj7-firefox-devedition-bin-unwrapped-106.0b3
ls -la /nix/store/x7n0bmfxbl527ii0yx52vplqlgcw3hj7-firefox-devedition-bin-unwrapped-106.0b3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

firefox-devedition-bin
firefox-devedition-bin-unwrapped

Maintainer pings
cc @taku0 @lovesegfault for testing.

Beaten by #192522, can be closed.


Update README

new features
uniformization of feature list and dependencies list
add PyOpenCL the list of optional dependencies
add a link to sample code documentation with screenshots (instead of recommending to run examples from the git repo)

LGTM


fix(README.md): remove trailing line

Remove the trailing line at end of readme

:tada: This PR is included in version 1.1.3 :tada:
The release is available on:

npm package (@latest dist-tag)
v1.1.3
GitHub release

Your semantic-release bot :package::rocket:


Pantheon?

Quote from readme:

To create the secret, first you will need to create a service account in the Pantheon project you want to push the final image to, with Storage Admin permissions.

I'm confused! I'd like to understand what that secret needs to be exactly. Sounds like e.g. the json file docker login creates to store credentials in my home directory? (I'm not really a GCP user, maybe it would be clearer otherwise.)
Thanks for making this tool! Was looking for a sane way to build docker images from inside my Kube cluster, and this sounds like an excellent solution!

Thanks for clarifying. But does this mean that the tool (for now?) only works with GCR.io as a push target?


[Bug]: 0.4.7 causes errors in old project

Current Behavior (bug)
I had a project that was last used successfully with whatever the last version of devbox was (0.4.6?) but the 0.4.7 that just came out broke it.
Similar to https://github.com/jetpack-io/devbox/issues/829, when I enter the old project the direnv init causes an error:
➜  src cd docker
direnv: loading ~/src/docker/.envrc
direnv: using devbox
direnv: using nix .devbox/gen/shell.nix
/bin/bash: line 9: export: `.': not a valid identifier
/bin/bash: line 9: export: `/Users/alan/src/docker/.devbox/gen/scripts/.hooks.sh': not a valid identifier

That .hooks.sh file does exist, fwiw, but is empty. Also, devbox shell works fine. No errors.
devbox generate direnv --force made a lot of changes to my .envrc and fixed the issue. I can now use direnv in this directory without errors. Is this expected behavior?

@altano thanks for reporting this issue. We confirmed that generating a new .envrc file (devbox generate direnv --force) will fix this issue. This was due to a change that was backwards incompatible with .envrc files.
We are making a release today that fixes the backwards incompatibility. That said, generating a new .envrc like you did is the better solution to this issue.

This error should be resolved in 0.4.8, which added backwards compatibility for projects that set up the direnv integration prior to 0.4.7.


fix reference to snazzy theme

could you rename the colorscheme to be just snazzy as well?
I renamed the colorscheme instead


Minor addition to Cybersun pen description

About the PR
Cybersun Pen description:

A high-tech pen straight from Cybersun's legal department, capable of refracting hard-light at impossible angles through its diamond tip in order to write.
has the following added to the end:
So powerful, it's even able to rewrite officially stamped documents should the need arise.
Why / Balance

Cybersun Pen's ability to rewrite stamped documents is hidden knowledge, despite being a very strong effect when utilized correctly.
CentCom Pen description isn't changed since that item is much rarer and not part of the Syndicate arsenal.
Technical details

Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

ftr its in the uplink description

Cybersun's legal department pen, invaluable for forging documents and escaping prisons. Smells vaguely of hard-light and war profiteering.
Imo "forging documents" isn't descriptive enough, sounding more like flavor text. Especially next to "escaping prisons" which the pen only helps with by being a stabbing weapon.

its also a screwdriver :trollface:

I feel like the hidden capabilities should be prominently displayed in the uplink, but hidden from the description since all players can see it.

Unlike something like the hypopen, the Cybersun pen in the uplink is not a disguised version of another item. When I call it "hidden knowledge", I mean that its functionality is not described well in the game and is only known word-of-mouth, not that it is intentionally designed to be a covert item.
Additionally, thieves get access to CS pens via their toolkit, and I think Salvage can find them as well.

Cybersun's legal department pen, invaluable for forging documents and escaping prisons. Smells vaguely of hard-light and war profiteering.

I feel that this better fits the style and tone of other item descriptions. I don't think a description has to give away all the details.
I'm fine with merging either, so please give this a consideration and let me know what you'd like to go ahead with.

That is the Uplink description, so it's already being used there. I didn't write it, I just cited it in response to the comment above it.

I feel like the hidden capabilities should be prominently displayed in the uplink, but hidden from the description since all players can see it.

Trying to hide stuff like that isn't great. Players will know the cybersun pen can do this if they stalk the repo / play a ton, but players who just pick it up won't as the description doesn't state it. Adding it to the description just makes that feature more accessible.


my (Isabel Tripp) bio is messed up!

hey everyone! I sent the Impact Labs website to a friend and they pointed out to me that my bio is truncated — it's because of a quote that isn't escaped. I was going to open a PR with the tiny copy change but I think your editing is restricted to collaborators.

Feel free to add me to the repo and I can push the change up. If you'd rather not, I actually edited my bio a little which I would love to update if you (whoever you are) don't mind hehe — doesn't have any more quotes!
"My concerns about unmitigated tech development originate in my love of reading science fiction. I try not to lean into the fiction side too heavily, but today, there's no denying that tech ethics needs to be a larger part of the conversation. I joined Impact Labs because we're making a concerted effort to attract talent to the social impact technology space. And mission-driven tech is what makes me excited about the future. On a personal note, I've worked on projects related to hydroponic farming, conflict diamond trade mitigation, the neurobiology of tumor growth, and protecting Earth from asteroids! I'm on the hunt for the world''s best cinnamon bun so please send me leads. :)"

thanks for catching that and for the new bio!


int redisReaderGetReply(redisReader *r, void **reply) error

int redisReaderGetReply(redisReader *r, void **reply) if (sdsrange(r->buf,r->pos,-1) < 0) {} after judging that the link is successful, execute hscan and return null

I don't follow.  What is the issue?

My program restarts the redis connection and executes a command similar to HSCAN filekey:fileuuis 0 match trace:* count 10. The data is successfully traversed for the first time. When the program exits and restarts the second traversal, reply=NULL is returned. The problem lies in the code I mentioned above.

My program restarts the redis connection and executes a command similar to HSCAN filekey:fileuuis 0 match trace:* count 10. The data is successfully traversed for the first time. When the program exits and restarts the second traversal, reply=NULL is returned. The problem lies in the code I mentioned above.

/* Discard part of the buffer when we've consumed at least 1k, to avoid
 * doing unnecessary calls to memmove() in sds.c. */
// if (r->pos >= 1024) {
//     if (sdsrange(r->buf,r->pos,-1) < 0) {
//         printf("get reply sdsrange < 0\n");
//         return REDIS_ERR;
//     }
//     r->pos = 0;
//     r->len = sdslen(r->buf);
// }  Comment out this code and it will be fine


[X] Have you checked to ensure there aren't other open Pull Requests for the same change?
[X] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Essentially reinstates 3fdab5a24d (#8572), which was undone by 712a95fdd (#10864) and the related fallout.
I'm not sure if it was intentional or not, but I couldn't find any comments referencing it in any of the mishegas (#10898, #10913, #10919, #10922, #10923), so I thought perhaps it was simply missed.  As someone on an older system, it would be awful nice to have!

I'm not sure why the reinstall test didn't give an error when this was initially implemented, but presumably the first couple of lines in the output of test/cask/cmd/reinstall_spec.rb need removing?
I've no idea what the codecov is on.

Waiting for confirmation from @reitermarkus on this.

What exactly does this fix?
I think it needs to be after download since this will also inspect the downloaded file and install any dependencies needed to unpack it, if I recall correctly.

Okay good I’ll help you with that

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Homebrew/brew/pull/12543#issuecomment-991695209, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AWYUKNF3Y6IIU5JBBTNMUW3UQNZHDANCNFSM5JYZLJBA
.

What exactly does this fix?

When installing a cask, it would be ideal for homebrew not to download the file then tell me it depends on a different macOS version.

I think it needs to be after download since this will also inspect the downloaded file and install any dependencies needed to unpack it, if I recall correctly.

Looking at installer.rb, satisfy_dependencies calls macos_dependencies, arch_dependencies, and yes, cask_and_formula_dependencies; I presume that latter one is what you're thinking of?  If so, perhaps it could be split?
Did I miss a follow-up issue with #8572, or did it just not get noted at the time?

Yes, splitting out macos_dependencies and arch_dependencies might work, but I think cask_and_formula_dependencies also calls this recursively for all dependencies.

Did I miss a follow-up issue with #8572, or did it just not get noted at the time?

I think this was just something I noticed while refactoring.


add AT, ES, IT, PT map centers

resolves #421

@r-pop if we're using review apps as part of the workflow, maybe we need to set up a separate google maps API key that doesn't restrict URL and set it via environment variable?


'Rate' should be 'Total' for all but one rain value ?

Love the Ecowitt integration, I installed very easily via HACS.
Feedback.
I note that all my rain sensor values are appended with 'rate' in HA entities, when I think only the first one should be 'rain rate'.
Should the others not be appended with 'total', like Daily Rain Total or Weekly Rain Total ?
I can change this inside HA entities naming override but would be better to change in Ecowitt integration.
For reference, here is all my sensors, with some names over-ridden, like the rain hourly, daily, weekly, etc entities to remove 'rate'.

good catch


switch to ocaml 4.10.2

We have very slow startup time with pfff and semgrep
when using ppxlib 0.20.0 in ocaml 4.10.0. This
seems to be fixed with 4.10.2 so let's update
our docker images to 4.10.2
test plan:
hoping CI flags anything

Ok tomorrow morning the docker image should be updated. There's a cron making those base image every wednesday.


Androud 11 CPM issue

Clasaic power menu has a delayed startup time, it takes 2 times or 3 to hold power for cpm to register then bubble msg says cpm has been gramted root permission.
Not sure why takes few times for it to actually activate the custom power menu even though the app has been granted root permission.
Magisk v28 & latested lsposed. Latest CPM.

Probably the same as #137, the hooking may be slower in some cases. If it works eventually, there isn't anything more I can do.


Make handheld flash not flash thourgh walls.

Fixes #5915
Also make it so mobs don't block the flash.

About the PR
Screenshots

Changelog

:cl: Charlese2

fix: Flashing through walls.

If it is in the same foreach loop the flashableEntities list is not populated with all the mobs in the area yet. The InRangeUnobstructed method needs a full list so it can ignore Opaque objects (players) in the obstruction check. You get inconsistent results if some mobs will block the flash and some wont depending on where it is in the loop.


xterm: 332 -> 333

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/xterm/versions.
These checks were done:

built on NixOS
ran ‘/nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333/bin/koi8rxterm -h’ got 0 exit code
ran ‘/nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333/bin/koi8rxterm help’ got 0 exit code
ran ‘/nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333/bin/uxterm -h’ got 0 exit code
ran ‘/nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333/bin/uxterm help’ got 0 exit code
ran ‘/nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333/bin/xterm -h’ got 0 exit code
ran ‘/nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333/bin/xterm help’ got 0 exit code
ran ‘/nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333/bin/.xterm-wrapped -h’ got 0 exit code
ran ‘/nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333/bin/.xterm-wrapped help’ got 0 exit code
ran ‘/nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333/bin/.koi8rxterm-wrapped -h’ got 0 exit code
ran ‘/nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333/bin/.koi8rxterm-wrapped help’ got 0 exit code
ran ‘/nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333/bin/.uxterm-wrapped -h’ got 0 exit code
ran ‘/nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333/bin/.uxterm-wrapped help’ got 0 exit code
found 333 with grep in /nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333
directory tree listing: https://gist.github.com/1317219946b26e2c85846fe9e169a9e4

cc @viric @vrthra for review

Success on x86_64-darwin (full log)
Attempted: xterm
Partial log (click to expand)
Completed installation of executables and documentation.
Use "make install-ti" to install terminfo description.
post-installation fixup
gzipping man pages under /nix/store/4ignqbldb5w2mx23yzdxm5mxd4hr4qsf-xterm-333/share/man/
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/4ignqbldb5w2mx23yzdxm5mxd4hr4qsf-xterm-333/lib  /nix/store/4ignqbldb5w2mx23yzdxm5mxd4hr4qsf-xterm-333/bin
patching script interpreter paths in /nix/store/4ignqbldb5w2mx23yzdxm5mxd4hr4qsf-xterm-333
/nix/store/4ignqbldb5w2mx23yzdxm5mxd4hr4qsf-xterm-333/bin/.koi8rxterm-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/sh"
/nix/store/4ignqbldb5w2mx23yzdxm5mxd4hr4qsf-xterm-333/bin/.uxterm-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/sh"
/nix/store/4ignqbldb5w2mx23yzdxm5mxd4hr4qsf-xterm-333

Success on x86_64-linux (full log)
Attempted: xterm
Partial log (click to expand)
shrinking /nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333/bin/.resize-wrapped
shrinking /nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333/bin/.xterm-wrapped
gzipping man pages under /nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333/lib  /nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333/bin
patching script interpreter paths in /nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333
/nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333/bin/.uxterm-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333/bin/.koi8rxterm-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333...
/nix/store/w5f067zkhadadsz7a2xh1qg435a8cirw-xterm-333

Success on aarch64-linux (full log)
Attempted: xterm
Partial log (click to expand)
shrinking /nix/store/7j7rp5rnjwz82ha4309x4k2xfwx7wkrm-xterm-333/bin/.xterm-wrapped
shrinking /nix/store/7j7rp5rnjwz82ha4309x4k2xfwx7wkrm-xterm-333/bin/.resize-wrapped
gzipping man pages under /nix/store/7j7rp5rnjwz82ha4309x4k2xfwx7wkrm-xterm-333/share/man/
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7j7rp5rnjwz82ha4309x4k2xfwx7wkrm-xterm-333/lib  /nix/store/7j7rp5rnjwz82ha4309x4k2xfwx7wkrm-xterm-333/bin
patching script interpreter paths in /nix/store/7j7rp5rnjwz82ha4309x4k2xfwx7wkrm-xterm-333
/nix/store/7j7rp5rnjwz82ha4309x4k2xfwx7wkrm-xterm-333/bin/.uxterm-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
/nix/store/7j7rp5rnjwz82ha4309x4k2xfwx7wkrm-xterm-333/bin/.koi8rxterm-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/7j7rp5rnjwz82ha4309x4k2xfwx7wkrm-xterm-333...
/nix/store/7j7rp5rnjwz82ha4309x4k2xfwx7wkrm-xterm-333


Add additional information for postcss errors (#6282)

Fixes #6282: If build compiler error has postcssNode property, add additional information to the error message. Default compiler CSS error messages are opaque. To verify:
npx create-react-app css-test
cd css-test
echo "label[for=*] { margin-right: 12px; }" > ./src/App.css
yarn build

Outputs error:

Replace css-test/node_modules/react-scripts/build.js lines:
messages = formatWebpackMessages({
  errors: [err.message],
  warnings: [],
});

With :
        let errMessage = err.message;

        // Add additional information for postcss errors
        if (err.hasOwnProperty('postcssNode')) {
          errMessage += '\n' + path.basename(
            err['postcssNode'].source.input.file
          ) + '\nCompileError: Begins at selector ' +
            err['postcssNode'].selector +' (' +
            err['postcssNode'].source.start.line + ':' +
            err['postcssNode'].source.start.column +
            ')';
        }

        messages = formatWebpackMessages({
          errors: [errMessage],
          warnings: [],
        });

Run yarn build to view new compiler error output:

Is the chunk name useful here? Can we point to the original source instead?

@iansu Useful to know the file type, original source would have definitely been preferred. Understanding is that postcss is processing the chunk not generating the chunk itself, so this would be after the chunk was generated. err['postcssNode'].source.input.file is set to the chunk name.
  postcssNode:
   Declaration {
     raws: { before: '\n  ', between: ': ' },
     type: 'decl',
     parent:
      Rule {
        raws: [Object],
        type: 'rule',
        nodes: [Array],
        parent: [Object],
        source: [Object],
        selector: 'body',
        lastEach: 2,
        indexes: [Object] },
     source: { start: [Object], input: [Object], end: [Object] },
     prop: 'background',
     value: 'var(--site-background)' } }

I thought that might be the case. I'm just not sure how useful the chunk name is, especially in dev where the chunk isn't written to disk. I guess it can be inspected via the browser devtools?

@iansu Chunk name has been removed

Thanks!


clock module ignores TZ environment variable

On glibc and musl the TZ environment variable overrides the system-wide timezone configured in /etc/localtime. The default behavior of the clock module when a timezone isn't set should probably try to match that.

Hi @hvenev , please provide more details. Example, how it should be, how it is, screenshots, etc.


Issue 162 - Update python-dateutil dependency version

I actually have a conflict with another package that depends on python-dateutil 2.7 hence upp'ing the max version to 2.8 😄

Can someone tell me what is wrong with the Travis build? It seems the /master branch is failing as well?
https://travis-ci.org/jjkester/django-auditlog

Codecov Report

Merging #184 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #184   +/-   ##
=======================================
  Coverage   83.43%   83.43%
=======================================
  Files          19       19
  Lines         513      513
=======================================
  Hits          428      428
  Misses         85       85

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a22978e...3dc61ec. Read the comment docs.

Hey @audiolion, are you able to review this PR? Thanks!

+1 Need this too!

Is anyone able to take a look to review the changes? Thanks.

Codecov Report

Merging #184 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #184   +/-   ##
=======================================
  Coverage   83.43%   83.43%
=======================================
  Files          19       19
  Lines         513      513
=======================================
  Hits          428      428
  Misses         85       85

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a22978e...3dc61ec. Read the comment docs.


The longest ascending sequence

Write a program that reads an array of ints and outputs the length of the longest sequence in strictly ascending order. Elements of the sequence must go one after another. A single number is assumed to be an ordered sequence with the length = 1.
Enter link to the question(if question belongs to any online platform) -
N/A
Tags for the question(eg - Array, Basic, Stack, etc.) -
Array, Basic
Example :

As a part of Hacktoberfest, @SarthakKeshari please assign this issue to me

@erickcernarequejo,
Go ahead, Kindly add your solution in "Arrays/1D Arrays" folder.
Deadline - 02/10/2021

Can I work on this issue?

@erickcernarequejo, Go ahead, Kindly add your solution in "Arrays/1D Arrays" folder. Deadline - 02/10/2021

Thank you @SarthakKeshari

Can I work on this issue?

You may create a new issue since this is alreadt assigned

Can I work on this issue?

You may create a new issue since this is alreadt assigned

What type of issues I can create?

Can I work on this issue?

You may create a new issue since this is alreadt assigned

What type of issues I can create?

You can create your own question and comment to get assigned

Can I work on this issue?

You may create a new issue since this is alreadt assigned

What type of issues I can create?

You can create your own question and comment to get assigned

Can I add a question that was on codechef or codeforces or any other platforms?

Can I work on this issue?

You may create a new issue since this is alreadt assigned

What type of issues I can create?

You can create your own question and comment to get assigned

Can I add a question that was on codechef or codeforces or any other platforms?

Yes, but it should be a medium level or above question as well as there are more strict review rules for them, even after successful merge they will be reviewed again by the team. Plagarism might lead to ban.

Sir please assign this issue to me
Why you should assign this to me?
i am current rated 5 star at codechef with rating of 2153 and rated expert at codeforces with rating of 1776
https://codeforces.com/profile/navjotdadwal
https://www.codechef.com/users/navjot1234
So i can handle and solve this issue


Synchronize triage configuration

This pull request was created automatically by the sync-triage-config workflow.

Thanks! That's good enough for me 🙂


How much memory is needed?

Hi, great project, congratulations, could you please let me know which Raspberry Pi 4 version did you use for the project? How much memory? What is the average memory utilization when running the software?

The software uses around 120 Mb of residential memory in my environment.


Question - Possible to change number of columns / rows

Hey, I realize this is out of scope of a chessboard, but I wanted to ask you how easy do you think it would be to modify the code to allow for more columns and rows?
I want to take a chessboard, generate a random map of green and blue tiles, and use it for a tabletop / mini simulator.
I am going to try to integrate this with slack.
Again, I know this is out of scope of your project, but just figured i'd ask you before I forked.

I don't know what you mean by "tabletop / mini simulator"
Creating a random board of NxN squares shouldn't be too difficult with a little HTML + CSS + JS knowledge. I'm not even sure I would fork chessboard.js for that purpose.

Casablanca chess has 10x10 board and two more pieces
El 17/12/2015 19:47, "Chris Oakman"<EMAIL_ADDRESS>escribió:

Closed #114 https://github.com/oakmac/chessboardjs/issues/114.
—
Reply to this email directly or view it on GitHub
https://github.com/oakmac/chessboardjs/issues/114#event-495028055.


BUG: footer text html tag

Describe the bug
The footer text is an h4. Semantically this does not make sense and it means headings are not in sequentially-descending order.
Expected behavior
I would expect the footer text to be a simple <p> tag, however, if you'd like to keep it as a heading, make it an h2.

assign this to me

Assign it to me


Dropdown shown and hidden event aren't waiting for CSS Transition

Issue https://github.com/twbs/bootstrap/issues/22760 can be reproduced in v4.3.1. Both shown and hidden event aren't waiting for CSS transition.
We measured the time when callback show.bs.dropdown and shown.bs.dropdown were executed and they differed about 2-3 ms, which is less than expected.
More info about the shown event
See docs https://getbootstrap.com/docs/4.3/components/dropdowns/#events

shown.bs.dropdown This event is fired when the dropdown has been made visible to the user (will wait for CSS transitions, to complete).

However, the event shown.bs.dropdown isn't waiting for CSS transitions to complete. See code
https://github.com/twbs/bootstrap/blob/master/js/src/dropdown.js#L208-L216
    const showEvent = EventHandler.trigger(parent, Event.SHOW, relatedTarget)

    if (showEvent.defaultPrevented) {
      return
    }

    Manipulator.toggleClass(this._menu, ClassName.SHOW)
    Manipulator.toggleClass(parent, ClassName.SHOW)
    EventHandler.trigger(parent, Event.SHOWN, relatedTarget)

I would expect a call to Util.emulateTransitionEnd(element, transitionDuration) or similar after trigger Event.SHOW and before trigger Event.SHOWN.

Hi @StabbarN,
I don't think there is a real transition during the process to show a Dropdown so that's why it's pretty fast, we just a .show class which do a display: block that's all
So for me it's a mistake in our docs 🤔
/CC @twbs/css-review

@Johann-S That makes sense. Event.SHOWN is in that case to no avail. We've added animations and I assumed that BS somehow waited for it to finish, but I was fooled or naive :).

@twbs/css-review is this still relevant for v5?