[$1000] Text selection is Inconsistency

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open any chat
Select the "Say hello" text given in top space

Expected Result:
Selection should be consistent on all platforms
Actual Result:
Selection is not consistent among all platforms
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.2.88-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/227018790-d4a32986-94ee-41b3-8188-8230508665bc.mov
https://user-images.githubusercontent.com/43996225/227018918-14996578-295f-4fab-aa02-350571ba50e5.mp4
Expensify/Expensify Issue URL:
Issue reported by: @DinalJivani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679471738156789
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013fb4b31533dd1abd
Upwork Job ID:<PHONE_NUMBER>496505344
Last Price Increase: 2023-03-27

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Job added to Upwork: https://www.upwork.com/jobs/~013fb4b31533dd1abd

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

Proposal
User can not select text consistently in different browser and desktop for hero text and description displayed at beginning of  new chat.
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
This Say Hello content generated via code below:
https://github.com/Expensify/App/blob/95d79900c5dc0441b8b933ca1fbe5d7bdaec9679/src/components/ReportWelcomeText.js#L69-L94
We can see at line 71 it will display Say hello via Text component wrapped, other text displayed  via Text component wrapped at line 74, So there is not user-select  css style property applied to these Text component, So selection behaviour is not consistence. This is the root cause of the problem.
What changes do you think we should make in order to solve the problem?
We have to apply styles.userSelectText style to Text component as shown below, so it will make text selection consistence in all browser.
 <View>
     <Text style={[styles.textHero, styles.userSelectText]}>
         {props.translate('reportActionsView.sayHello')}
     </Text>
 </View>
 <Text style={[styles.mt3, styles.mw100, styles.userSelectText]}>
   ...
 </Text>

So this will solve the problem and make text selectable consistence in all browser and desktop app. See results.
What alternative solutions did you explore? (Optional)
None.

Results
Desktop
https://user-images.githubusercontent.com/7823358/227032900-12b4b789-4a78-44db-ba19-729300a4775a.mov
Chrome
https://user-images.githubusercontent.com/7823358/227033011-ff77f952-157e-48fc-9cb2-363ecee5fcdf.mov
Safari
https://user-images.githubusercontent.com/7823358/227033044-e8d67c1b-28ad-4404-ae40-3ccef67d8aa9.mov

Proposal
to make any text selectable in react native in all platform we need add prop selectable to Text
see selectable docs
<Text selectable>select me</Text>

https://user-images.githubusercontent.com/41129870/228084734-ade4c25b-33c4-41f1-a8d5-bf85f5104a88.mov
Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~012883934e2c4dc4e7

⚠ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Text selection is Inconsistency among platform
What is the root cause of that problem?
In ScreenWrapper Component, we are using userSelect: 'auto'
https://github.com/Expensify/App/blob/7003d9544c53d267f1f70795da7bbea32b8ee43c/src/styles/styles.js#L1321-L1325
So the selection of text will depend on the browser as reference
What changes do you think we should make in order to solve the problem?
In here https://github.com/Expensify/App/blob/7003d9544c53d267f1f70795da7bbea32b8ee43c/src/styles/styles.js#L1321-L1325
We should use the text value for userSelect and WebkitUserSelect if we want the text can be selected on all platforms or use the none value if we want the text can't be selected on all platforms
I just applied this solution and did not encounter the issue mentioned in the PR
What alternative solutions did you explore? (Optional)
we can consider using -ms-user-select with the same value as userSelect and WebkitUserSelect
Result
In Chrome

In Safari

I think this has the same root cause of https://github.com/Expensify/App/issues/14402. At that time we decided to just close the issue since the changes are not that easy to test across the app.

@puneetlath, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

@tienifr that will make all text in the app selectable?

waiting on @tienifr's reply

@rushatgabhane My proposal only updateds userSelect and WebkitUserSelect in Report Screen.

Issue not reproducible during KI retests. (First week)

@puneetlath @rushatgabhane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@puneetlath, @rushatgabhane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@s77rt can you see any downside if we were to go with @tienifr's suggestion of allowing text to be selectable?

@puneetlath Not much, the only reason we didn't go with that solution earlier is that it requires a lot of testing. With that solution many elements that are currently unselectable will be selectable, that's not an issue but it's important that those have the correct cursor, e.g. the date next to the user name in report item will be selectable but the cursor is wrong.
https://user-images.githubusercontent.com/16493223/230474565-1ba962d5-ae50-4afa-aacc-4bf83d4cab46.mp4

That's actually another bug and I believe it's caused by https://github.com/Expensify/App/blob/ec1300a4a60e1e782b0419305d77d331aff58dd5/src/styles/StyleUtils.js#L519 which is a regression from https://github.com/Expensify/App/pull/1186 That's an old PR but I think the cursor we wanted to set here is actually initial and not default.

@puneetlath Request to review my proposal https://github.com/Expensify/App/issues/16420#issuecomment-1485725817 it will solve the problem specific for this issue.  I think it is not good idea to solve it globally because it will make all text selectable within app, although some places we do not need text selectable etc. Thank you.

@puneetlath i think we can go ahead with @tienifr's proposal as it only affects Report Screen. We can test everything and fix cursor issues while reviewing the PR

Just sharing my thought.
Two approach is here:
1 - Making everything selectable, then fix where selectable not need or correction need.
2 - Making selectable that only need or concern. No need to find any side effect and repair it.
Similar approach for any permission based mechanism:
1 - Making all permission open , and find out which suppose to not open and fix it.
2 - Make everything close/locked and open permission that need.
We can think which approach is good in a general way. Thank you.

Started a Slack convo to discuss here: https://expensify.slack.com/archives/C01GTK53T8Q/p1680887171271209

Ok it seems there is general agreement in that thread that we should address this globally.

just to confirm @puneetlath by globally we mean for all screens in the app?

@puneetlath @rushatgabhane this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

Let's do it @tienifr.

@rushatgabhane The PR is ready for review

Regression Test Proposal
Bug: Text selection is Inconsistency
Proposed Test Steps:

Open app
Open a new chat to another account
Verify that the welcome text ("Say hello! This is the beginning of your chat...") is selectable
Open another chat with chat history
Verify that the text selection cursor is displayed when hover over the date in a report action item

Do we :+1: or :-1:

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.1-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/17330

If no regressions arise, payment will be issued on 2023-04-26. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@DinalJivani @tienifr can you apply to the upwork job please: https://www.upwork.com/jobs/~013fb4b31533dd1abd

@puneetlath
Do we have to apply to this Upwork job?
Because till now we get offer directly on Upwork.

Yes, please apply!

@puneetlath Applied!

@puneetlath applied, thanks!

@rushatgabhane bump on the checklist.

Paid @tienifr. Just waiting on checklist for @rushatgabhane

@rushatgabhane another friendly bump on the checklist so that we can get this issue closed out and get you paid. Thanks!

Thanks @rushatgabhane!
Can you accept the Upwork offer as well so that I can pay you out?

Just waiting for @rushatgabhane to accept the Upwork offer.

All paid. Thanks everyone!


Property Grid: Stepping though adjacent filtered matches doesn't work

Repro:

open presentation-test-app
open the default sample imodel, use Items ruleset
in the tree view filter, enter "e"
step through filter matches until two adjacent "e" are found
try to step through them - notice that they're handled as one match

The issue is in third-party library: react-highlight-words, described here: https://github.com/bvaughn/react-highlight-words/issues/68.
Looks like it's not going to be fixed. Need to consider forking and fixing ourselves or looking for another library.


All links expired

Sir do you think most of the streams regardless of whether we had a good or bad internet connection does these streams always expired or it just happened now for the meantime??

Please update your list and tested.


Create jekyll-gh-pages.yml

Description of PR
How was this patch tested?
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[x] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
yamllint
0m  0s

yamllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
shadedclient
35m 33s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
shadedclient
21m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
asflicense
0m 46s
/results-asflicense.txt
The patch generated 1 ASF License warnings.

62m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5770/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5770

Optional Tests
dupname asflicense codespell detsecrets yamllint

uname
Linux 5f54f70a13af 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 972cee4f7fb6d37e83370a55968201300bd8fb56

Max. process+thread count
669 (vs. ulimit of 5500)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5770/1/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

not sure, what are you trying to achieve, if it is the trunk documentation, then it is already done and it stays here:
http://apache.github.io/hadoop/
it gets built after each commit


fix: setValue should accept null

setValue(null) throws errors, because typeof null is 'object' and  "__isResetting" in null is not allowed.

@allcontributors, please add @oyzhen for code

@all-contributors, please add @oyzhen for code


[BUG] plotting functions don't work when the number of columns is >3

import polars as pl
from functime import plotting

y = pl.scan_parquet("https://github.com/descendant-ai/functime/raw/main/data/commodities.parquet")

(
    y
    .filter(pl.col("commodity_type").eq("Aluminum"))
    .with_columns(pl.lit(1).alias("fourth_col"))
    .collect()
    .pipe(plotting.plot_panel)
)

This fails. The proposed solution is to replace this line:
https://github.com/neocortexdb/functime/blob/90e0f8d66a5ea242d546adeeafd61c60dab1eae7/functime/plotting.py#L53
With this:
entity_col, time_col, target_col = y.columns[:2]

As we do in other places of the codebase.

Closed by #101


Update index links

Fixes a few dead links from https://probml.github.io/pml-book/book1.html

Saw you might prefer issues instead of PRs -- feel free to close and consider this an issue if so (particularly since maybe you want to handle the deprecated scripts differently)!

thanks!


Drawer should not hard code colors

Describe the bug
Title and subtitle in drawer have a hard-coded color
.mdc-drawer .mdc-drawer__title {
 color:rgba(0, 0, 0, 0.87);
}

To Reproduce

setup a dark mode
text is unreadable

Expected behavior
slotted text should use --mdc-theme-on-surface variable for font color.

Thanks for reporting this issue! This is a known issue which'll be fixed in upcoming releases.
Please watch this repo for updates. We're planning to provide CSS custom properties to all themable properties of a component.


Find a way to autogenerate a PDB from the second pass build

This would be a massive relief, and we wouldn't rely on dodgy auto reflection tools like .NET Reflector to do it for us.
If this StackOverflow post is right, I should be able to do it using Mono.Cecil. It'd be perfect.
http://stackoverflow.com/questions/19770381/mono-cecil-error-generating-pdb
This is a main priority task really. The current process is a bit of a pain in the butt since you can't step through Revolution's code whilst debugging a mod - launched from the RevolutionDebugger.

Added in fbb99492706d5e6b11eb111a860dfbc1bfa365bf


Design and Spike POC Dashboard Design

Also from the view only, logged in, manage multiple conversation on 8/1 #7465 & #6983
Starting from pareto principle, the user  story is " most often I will be wanting to see performance of multiple addresses." So we could look to the dashboard as a set of pieces we bring in and reduce complexity from my wallet tabs. It's possible to bring in a few other pieces (like txs, performance, etc. ). So, the thought initially is to think through the dashboard with a fresh set of principles.

Going to just put down my thoughts here so I don't forget.
This dashboard will act as a jumping off point for users who haven't connected a wallet yet, to see what they can do with ShapeShift.
So things like what can they lend, or borrow, and liquidity pools. Then we would have call outs for specific spots to connect wallet for like tx history, their assets, and the net worth.


Bump supported Spring Boot baseline to version 3.2.x

Description
Spring Boot < 3.2.x reached end of life and it's not maintained anymore. This PR bumps the minimum supported version to 3.2.x, supporting both the 3.2.x and 3.3.x release trains.

Bump dependencies in sdk-springboot module from Spring Boot 2.x to 3.2.6
Update examples module to use new Spring Boot support with Java 17 baseline
Fix wrong sdkman and maven wrapper setup that failed the local setup
Update GHA workflow to stop testing for Spring Boot versions < 3.2.x

Issue reference
Fixes gh-1039
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[x] Extended the documentation

@artursouza I just checked this PR.. and this is what we need to do to upgrade to spring 3.2.x .. We will start refactoring the spring boot support, trying not to break existing users.

@artursouza can you please review?

Looks like CI is failing the license/synk check, but I can't view it. I'm fine with proceeding with this change given if there are vulnerabilities in Spring Boot < 3.2.x it won't be fixed and users have had some time to upgrade by now.

@cicoyle thanks for the review. I can't see the Snyk report either. @salaboy do you have access? I'm not sure which  dependency is triggering the failure.

@cicoyle when you have time can you please validate this one? now that the HTTP client is removed .. we need to upgrade the spring boot version.

@cicoyle thanks for the review. I can't see the Snyk report either. @salaboy do you have access? I'm not sure which dependency is triggering the failure.

Let me ask for permission

@ThomasVitale I am working out on the licence stuff.. but it seems that dapr-sdk-tests is still trying to get Could not find artifact io.dapr:dapr-sdk-springboot3:jar:1.12.0-SNAPSHOT  which might be because you forgot to update that dependency.

@ThomasVitale I am working out on the licence stuff.. but it seems that dapr-sdk-tests is still trying to get Could not find artifact io.dapr:dapr-sdk-springboot3:jar:1.12.0-SNAPSHOT  which might be because you forgot to update that dependency. Here: https://github.com/dapr/java-sdk/blob/master/sdk-tests/pom.xml#L132

I fixed it in FOSSA. Ignore Snyk's report on license, I disabled that going forward. Snyk is used for vulnerability reports only.

@salaboy thanks, I had missed that idk-tests was excluded from the multi-module Maven project, so the tests didn't actually run as part of the local workflow. I tried to set them up locally based on the pipeline, but I didn't manage to do it fully, I'm afraid. I pushed a change to update the dependencies in dk-tests, and remove sdk-springboot3.

@salaboy thanks, I had missed that sdk-tests was excluded from the multi-module Maven project, so the tests didn't actually run as part of the local workflow. I tried to set them up locally based on the pipeline content, but I didn't manage to do it fully, I'm afraid. I pushed a change to update the dependencies in dk-tests, and remove sdk-springboot3. Can you re-run the PR pipeline?

This is a breaking change but it might make sense for the Java community to simply move away from Springboot 2.

Yes we made the decision to move forward to spring 3.2.x .. let’s unblock
this if the PR is green

Blog: http://salaboy.com http://salaboy.wordpress.com

Github user: http://github.com/salaboy

Twitter: http://twitter.com/salaboy

Mauricio "Salaboy" Salatino -

On Wed, 26 Jun 2024 at 19:12, Artur Souza @.***> wrote:

@salaboy https://github.com/salaboy thanks, I had missed that sdk-tests
was excluded from the multi-module Maven project, so the tests didn't
actually run as part of the local workflow. I tried to set them up locally
based on the pipeline content, but I didn't manage to do it fully, I'm
afraid. I pushed a change to update the dependencies in dk-tests, and
remove sdk-springboot3. Can you re-run the PR pipeline?
This is a breaking change but it might make sense for the Java community
to simply move away from Springboot 2.
—
Reply to this email directly, view it on GitHub
https://github.com/dapr/java-sdk/pull/1050#issuecomment-2192351213, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACCMXV6EOICF7PRK6KXLZTZJMABBAVCNFSM6AAAAABJIVLXTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJSGM2TCMRRGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

@salaboy and @ThomasVitale I have spent some time looking at the build failures. According to this document: https://github.com/spring-projects/spring-framework/wiki/Upgrading-to-Spring-Framework-6.x#parameter-name-retention things have changed in Spring Framework 6.x when it comes to parameter name resolution. We have to either use Java Compiler with -parameters flag or ensure that @PathVariable and @RequestPathParam are explicitly named.
I have run an experiment using explicit naming that can be found here: https://github.com/artur-ciocanu/java-sdk/actions/runs/9696067245/job/26757186160. The GitHub Action succeeded, so we can at least try to fix these issues in the near term.
I am still looking into other build failures. I'll keep you posted.
CC: @artursouza @cicoyle

@salaboy and @ThomasVitale I have spent a few hours figuring out why the tests are failing. Here are my findings:

"parameter name resolution" - the are changes in SB 2.x and SB 3.x it is due to Spring Framework 6.x changes. The fixes are trivial I have suggested them in the previous comment.
OpenTelemetry version mismatch - it seems that as part of SB 3.x upgrade we get a new version of Zipkin reporter and this conflicts with OTEL version that is currently used in sdk-tests. Here is the error that I managed to reproduce:

Error:  Errors:
Error:    TracingIT.testInvoke:60 » NoSuchMethod 'zipkin2.Call zipkin2.reporter.Sender.sendSpans(java.util.List)'
Error:    TracingIT.testInvoke:58 » NoSuchMethod 'zipkin2.Call zipkin2.reporter.Sender.sendSpans(java.util.List)'

My suggestion for the second issue would be to upgrade OTEL to latest library, but this requires some significant changes in sdk-tests since currently it uses 0.14.0 while the latest is 1.39.0.
@artursouza and @cicoyle what are your thoughts.

@artur-ciocanu I wonder if we can rely on the OTEL stuff that comes with Spring Boot 3.x instead of adding our own dependency

@cicoyle @artursouza or @ThomasVitale could you please try to merge the "master" and see if we still have any issues with Spring Boot upgrade.

@artur-ciocanu thanks, I'll try that later today

@artur-ciocanu I have rebased this PR and pushed the changes

@artursouza and @cicoyle it seems that we need maintainers approval. The build workflows are blocked right now.
Whenever you have a chance, could you please help? Thank you.

@ThomasVitale we are almost there 😀. It seems that there is still one IT test that is failing. It is related to SDK resiliency. I will take a look on Monday and see if I can reproduce it and come up with a fix.

Thanks so much for the help @artur-ciocanu 💪💪

@ThomasVitale and @salaboy I have opened #1070 to try to fix the SDK resiliency IT failure. Let's wait until it is merged and see if it will fix the issue.

@ThomasVitale the SDK resiliency IT fix PR has been merged. Could you please merge "master" and see if things are looking good.

@artur-ciocanu thanks! I've just rebased the PR

@artursouza or @cicoyle it seems that we need maintainers approval to kick off the GitHub workflows. Could you please approve and if everything looks merge the PR.
Thank you! 🙇♀

Need to check why the build is failing

Build is still failing. I have no problem merging this once validation passes.

Let me check tomorrow one more time to see what might be the issue. Thanks for checking @artursouza 🙇

Thanks! I would like to help debug the integration tests, but I didn't manage to run them locally. I have suggested an improvement for the docs on how to establish a local setup for running the sdk-tests project. https://github.com/dapr/java-sdk/issues/1075

@artursouza and @yaron2 I have opened a tiny PR #1077 to add failure message for the failed IT test. Also I have tried to build #1050 from my fork and the GitHub workflow completed successfully. Here are is the build run: https://github.com/artur-ciocanu/java-sdk/actions/runs/9904795676.
If you could review PR #1077 and merge it to master then we could at least see what is the underlying problem.
Thank you!

@artursouza sorry for this back and forth, but you could you please merge master and retrigger the GitHub workflows.
Much appreciated.

@artursouza sorry for this back and forth, but could you please merge master and retrigger the GitHub workflows.
Thank you, much appreciated. 🙇♂

@artursouza as far as I can see the Spring Boot 3.x build was successful. The other Spring Boot builds like 2.5, 2.6, 2.7, 3.0 are stuck. However these have been removed from the test matrix in the GitHub workflow. Also if I go to https://github.com/dapr/java-sdk/pull/1050/checks everything seems to be 🟢 .
Do you think it is safe to merge this PR that the SB 3.2 and SB 3.3 builds are successful?

@artursouza and @cicoyle whenever you have a few minutes could you please take a final look, approve and merge. Thank you.

@cicoyle can you please review this?

OK. This is going to release 1.12.

@artursouza it seems to be 🟢 !!!

@holopin-bot @ThomasVitale Thank you Thomas!


Add support for react 19

When trying to render a slider in react 19 an error occurs

Updated.  Thanks for bringing this up.


Implement TCGC's SdkPackage types

Language emitters should work to move entirely to TCGC's new ecosystem. The entry point for the ecosystem is accessing .sdkPackage on the SdkContext returned from tcgc
https://azure.github.io/typespec-azure/docs/howtos/DataPlane Generation - DPG/07tcgcTypes
### Tasks
- [x] Replace logics for process operation parameters
- [x] Replace logics for server parameters
- [x] Replace logics for process operation
- [x] Replace logics for process clients
- [x] Replace logics for process response
- [x] Replace logics for process LRO
- [x] Replace logics for process body parameters
- [x] Replace logics for process examples
- [x] Replace logics for process auth
- [x] Replace logics for the util functions, e.g. addAcceptedHeader, processEtagHeader etc.
- [x] Replace logics for versioning
- [ ] Integrate with access and usage
- [ ] Pass cadl-ranch and typespec-tests
- [x] integrate with new SdkClientType design
- [x] integrate with new multipart design
- [x] integrate with uri template

TCGC dependencies:
### TCGC dependency issues
- [ ] https://github.com/Azure/typespec-azure/issues/954
- [ ] https://github.com/Azure/typespec-azure/issues/917
- [ ] https://github.com/Azure/typespec-azure/issues/916
- [ ] https://github.com/Azure/typespec-azure/issues/963
- [ ] https://github.com/Azure/typespec-azure/issues/965
- [ ] https://github.com/Azure/typespec-azure/issues/980
- [ ] https://github.com/Azure/typespec-azure/issues/217
- [ ] https://github.com/Azure/typespec-azure/issues/1088
- [ ] https://github.com/Azure/typespec-azure/issues/1060
- [ ] https://github.com/Azure/typespec-azure/issues/1164
- [ ] https://github.com/Azure/typespec-azure/issues/1259
- [ ] https://github.com/Azure/typespec-azure/issues/1153
- [ ] https://github.com/microsoft/typespec/issues/4132

### TCGC dependency issues - continue.
- [ ] https://github.com/Azure/typespec-azure/issues/965

Hi @iscai-msft @lmazuel, Java may need to start this work at June as we are working on remaining items related with TCGC model types in May. Please let me know if there is any concern.
https://github.com/Azure/autorest.java/issues/2728 (depends on TCGC to remove undefined value)
https://github.com/Azure/autorest.java/issues/2729 (depends on two issues listed)
https://github.com/Azure/autorest.java/issues/2732 (done)
https://github.com/Azure/autorest.java/issues/2730 (will adopt after TCGC released)
https://github.com/Azure/autorest.java/issues/2731 (in progress)

First API view to show the API diff: https://apiview.dev/Assemblies/Review/e0cf256f814e456bac0f0d751bd4aa9f/81e4187324194e33899d9cbb375aeb4a?diffRevisionId=46902be02c1b4f0cbe9f89e2a5137a05&diffOnly=true
There are not much public API diff. Existing diffs are caused by three cases:

client structure case: The latest revision does not generate for cadl-ranch client structure case (https://github.com/Azure/cadl-ranch/tree/main/packages/cadl-ranch-specs/http/client/structure), as it has compile error, and depends on TCGC issue: https://github.com/Azure/typespec-azure/issues/1060
anonymous parameter name change: for flattened parameter (which is also anonymous model) case, if we use the name from TCGC, we will have generation error. So I did not use the parameter name from TCGC for anonymous model.
ARM case's endpoint cannot be set: this is pending on TypeSpec team's fix. issue: https://github.com/Azure/typespec-azure/issues/217

new version of api-view: https://apiview.dev/Assemblies/Review/e0cf256f814e456bac0f0d751bd4aa9f/6104eaa1d87b4b1bbfb474632fa7365e?diffRevisionId=46902be02c1b4f0cbe9f89e2a5137a05&diffOnly=true

API view based on 7.11 main:
https://apiview.dev/Assemblies/Review/e0cf256f814e456bac0f0d751bd4aa9f/555f98a4f0254f81acf9f257841c83fe?diffRevisionId=b792a3ef67e044379ff8407f58c99dd1&diffOnly=True

7.15 API view:
https://apiview.dev/Assemblies/Review/e0cf256f814e456bac0f0d751bd4aa9f/99297657ec5a4c28a177ad9d3a984044?diffRevisionId=b792a3ef67e044379ff8407f58c99dd1&diffOnly=True
Public API diffs summary:

client structure case: The latest revision does not generate for cadl-ranch client structure case (https://github.com/Azure/cadl-ranch/tree/main/packages/cadl-ranch-specs/http/client/structure), as it has compile error, and depends on TCGC issue: https://github.com/Azure/typespec-azure/issues/1060
ARM case's endpoint cannot be set: this is pending on TypeSpec team's fix. issue: https://github.com/Azure/typespec-azure/issues/217
api version is added to builder when there are multiple servers - still wip on this.
operation group's client name change, caused by TCGC not consider @clientName to overwrite client name.

Update for Meeting 8/1:

Finished the two follow up items from last meeting:
• return type's response: Try to add logic in codegen to dislay response's desc, but have some issues remaining for handling ok response, file an issue first: https://github.com/Azure/autorest.java/issues/2878. Finish the logic to merge summary and description on return type to unblock sdkpackage adoption
• optional body case: remove content type added by TCGC for optional body case

Issues fixed:
• Override ARM endpoint param: work around from emitter side and regened, passed test, will adopt TCGC after Izzy made the change we agreed on this morning
• Found the root cause for multiple server case diff, fixed  logics and wip regen to test

Integrage with latest TCGC changes:
• Integrate with TCGC's filtered API version logics: finished and passed tests
- Merge with multipart changes, found some unexpected diffs, checking now

Update on 8/7:
latest API view: com.azure.tools:azure-typespec-tests - apiview.dev
There are only two issues remaining.

multipart (this depends on TCGC bug fix to be released)  https://github.com/Azure/typespec-azure/pull/1281
parameter order changes(maybe due to we adopt TCGC parameter spread feature, I am checking now)

Update on 8/12:
latest API view: https://apiview.dev/Assemblies/Review/e0cf256f814e456bac0f0d751bd4aa9f/e0f4e0c3e4704de89332b6229b14ad64?diffRevisionId=fbdae726b3a04e839587766478ca88eb&diffOnly=true
The diff is all due to below:

Another diff in impl:

TCGC has not supported allowReserved for path parameter yet, so I comment out the corresponding part of logic in emitter and add TODO https://github.com/Azure/autorest.java/commit/fc35d0fe3520cc668a6f2029a64284453d29874d.

Order change on property may due to a PR by @XiaofeiCao -- could you take a look?

Order change on property may due to a PR by @XiaofeiCao -- could you take a look?
kind of like this https://github.com/Azure/azure-sdk-for-java/pull/41497/files

Yes, it is. I've replied in chat:
ARM diff is expected. It's a side-effect of a bug fix:
fix, mgmt shadow properties from Resource/ProxyResource by XiaofeiCao · Pull Request #2905 · Azure/autorest.java (github.com)

generated code diffs are reordering of the shadowed properties(a side effect of the fix logic). Now properties from subclass will come before the ones from parent class.

Java released emitter version 0.20.0 with sdkpackage adoption changes in:
<EMAIL_ADDRESS>I have also verified the diffs in SDK repo and the refreshed code in SDK repo.
https://github.com/Azure/azure-sdk-for-java/pull/41666


Blank page on Android in the version of ionic2.0.0 RC.3

Ionic works in "ionic serve" but not in Android.
The page can show in "ionic serve".And It cann't show in android,but I can see "IonicAlert" when it shown.

I have fixed the issue :
It occurs when "$colors"'s  length reach 20;
I think it is a bug.

Hello, thanks for opening an issue with us! Unfortunately I cannot reproduce this issue. What device and version of Android are you seeing this issue on?

I have fixed the issue :
It occurs when "$colors"'s length over 20;
I think it is a bug.

I've got the same issue. Ionic creates css code:
http://pastebin.com/nYN81QrH
But only on Android, on iOS it is ok.
Like @982964399 - it happens only on big $colors variable.

Same issue here.

This is really blocking my development. Works fine in iOS. Android i get blank screen.
Browser it's fine. @jgw96

I have the same issue with RC3. RC2 works fine.
OnePlus X - android 6.0.1

Hello all! After further investigation this is actually a build issue. I am going to close this as a duplicate of https://github.com/driftyco/ionic-app-scripts/issues/506. Thanks!


Anti-Rationale

TL;DR: We don't need this feature, async/await is good enough for all use cases

I was a bit surprised when I came across this proposal, as I did never find Bluebird.try very useful, and didn't imagine anyone would want to standardise this functionality. I read the rationale and the linked article, and while I recognise their points I don't share their views and believe that a standardised Promise.try is just cluttering the API and not worth the effort in light of ES8. For the sake of discussion, I'd like to provide some counterarguments.

A common use case that I, and many others, have…

I cannot confirm that. I have read thousands of lines of promise code, and this use case is really rare. Not to say insignificant. Does anyone have numbers for comparison?

I have a function f that may be async, and return a Promise, or it may not - I don’t wish to have to know. However, I'd like to wrap it in a Promise so that if it is async, or if it throws, I can lean on Promise semantics and .catch to handle it.

 The only exception are libraries that invoke user-supplied callbacks (which usually doesn't happen at the start of a promise chain anyway), and to acknowledge that they are asynchronous or might throw is already half of the deal. So ok, lets just wait for it and handle errors:
try {
    await f(…);
} catch(e) {
    …
}

Problem solved.

The typical “easy to remember” way this is achieved in JS Promises is with Promise.resolve().then(f).
However, f is needlessly run asynchronously, on a future tick.

Ticks are cheap (or so we are made think), and given we don't know what the function does or when or how long it takes, this doesn't seem to matter.

new Promise(resolve => resolve(f())) achieves my goal, but is not ergonomic to write nor easy to remember. Using Promise.try(f) [gets me all this].

Only that is rarely what is actually needed. You'll typically want to pass one or more arguments to f,  for which you have the choice between
Promise.resolve(…).then(f).then(…);

new Promise(resolve => {
    resolve(f(…, …));
}).then(…);

Promise.try(() => {
    return f(…, …);
}).then(…);

(async function() {
    return f(…, …);
}()).then(…);

A topic that frequently confuses users in the #Node.js channel, is the Promise.try method provided by Bluebird. People often struggle to understand what it is, or why they should use it

That statement I can agree with (having answered a few StackOverflow questions regarding it). But it doesn't exactly suggest adding this method to the official Promise interface will help reduce the cognitive load :-)

Better error handling. […] But what if database.users.get throws synchronously?

It doesn't. When it's an asynchronous method returning a promise (assuming we know that, as is the case usually, but the article seems to suggest that we should use Promise.try even there), it will by convention never throw.

What if there's a typo or other error in the third-party database code, which we didn't write?

What if there's a typo in the code we did write? Like misspelling Promse.try, or forgetting to return a promise in one of our methods that we chain .then() onto? These kinds of mistakes are unexpected and therefore unrecoverable - the type of "crash app and alarm developer". Any code that handles such errors needs to care about synchronous exceptions anyway.
And if our goal was keep the convention of never throwing synchronously (even for unexpected mistakes), the only real solution is to put the code inside an async function where the runtime takes care of always returning a promise (and rejecting it) for us.
Or in case those aren't supported, wrapping Bluebird.method around the whole function, which is recommended over Promise.try anyway.

Better interoperability. By using Promise.try like this, you can decide for yourself what implementation you want to be working with.

Promise.resolve already provides that capability, with a much nicer interface (no overhead of callbacks).
And of course, in async functions we don't care about this anyway, since there are no (few) explicit chains and they always return native promises without giving us a choice (I'd love to see async Bluebird function(…) { … } syntax that does).

Easier to scan. The final benefit is one of readability. By starting every chain with Promise.try, all the actual 'business logic' exists within a callback at the same (horizontal) level of indentation

This is an issue that seems to be more pronounced with certain indentation styles. Personally I would have written the particular example as
function getUsername(userId) {
    return database.users.get({id: userId})
    .then(getMetadataFor)
    .then(userMetadata => userMetadata.name);
}

and have no problem at comprehending it (maybe just because I'm accustomed to the style), but I see the point for more complicated cases.
But readability is exactly the topic where async/await is absolutely unbeatable. It shines by dropping the whole method chaining:
async function getUsername(userId) {
    const user = await database.users.get({id: userId});
    const userMetadata = await getMetadataFor(user);
    return userMetadata.name;
}

(or optionally just a oneliner return getMetadataFor(await database.users.get({id: userId})).name;)

If Promise.try is made for "nicely mirroring async function", then why don't we just use async functions?

This is a really long post that's basically saying "this proposal is worthless", so I'm not sure why you thought it'd be helpful to post this.
That said, Promise.try is API, not syntax; it's not polyfillable; it's not usable in older environments; just because you never found bluebird's try useful doesn't mean many many other people have (I'm often told it's one of the 3 remaining reasons people don't ditch bluebird for native); re indentation styles, that's super subjective, and your preferred indentation violates almost every styleguide out there; Promise.resolve takes a value, and does not cover the try/catch semantics - using Promise.resolve().then takes an extra tick, as is explained in the readme.
Syntax and API should have complementary methods of achieving the same thing. async function does not replace the Promise API, and it's important to keep them as in sync as possible.

I'm not sure why you thought it'd be helpful to post this.

To help the committee evaluate community approval. I'm sharing my perspective that this method is unnecessary, and far less important than some other promise functionalities. How else is the language protected from API bloat? How else could I raise these points for discussion?

That said, Promise.try is API, not syntax; it's not polyfillable;

The polyfill looks almost trivial to me.

it's not usable in older environments

Yes. It wouldn't be natively available in any environment that didn't also already support async/await, and always require the polyfill.

I'm often told it's one of the 3 remaining reasons people don't ditch bluebird for native.

Oh, wow. Who is telling you that, and what are the other two?

Syntax and API should have complementary methods of achieving the same thing. It's important to keep them as in sync as possible.

Really, is that so? There are too many counterexamples. I'm definitely a fan of "There should be one—and preferably only one—obvious way to do it." and prefer it over TIMTOWTDI. Also, the Promise constructor API is already perfectly capable of achieving this thing, why add another method?

Every bluebird user I've talked to - the other two are finally, and conditional catch guards.
While in general I prefer having only one way to do things, TIMTOWTDI is in fact a general guideline cited by TC39 members, and having complementary syntax and API is also a general guideline.
Adding "another method" is because the Promise constructor is confusing, and currently should never be used except for two use cases:

wrapping a callback-based async API
Promise.try, in an environment without async function.

This proposal removes one of these two reasons to use the unintuitive Promise constructor.

having complementary syntax and API is also a general guideline

I'd love to see a proposal for the syntax equivalent of then with two arguments :-)

Promise.try, in an environment without async function.

It's just I think we'll never get an environment with native Promise.try but without async functions. Sure, it might be helpful in an environment with only a polyfilled promise library, but I don't think it's necessary to make it a native function.

This proposal removes one of these two reasons to use the unintuitive Promise constructor.

Thanks, that's a much better line or reasoning imo.

@bergus a) the syntax equivalent of x.then(y, z) with 2 args is try { return y(await x); } catch (e) { return z(e); }, b) the 2-arg form is legacy and only has one remaining use case, to "invert" a promise.
I don't care if an environment has a native Promise.try - what we already have is sites and projects that target a range of engines that includes "has async function" and "does not" - and both could be polyfilled/shimmed to have Promise.try.


Updates for 10/28/2020 release

Summary
Updated the ecms_profile and ecms_patternlab versions.
Metadata

Question
Answer

Did you use a meaningful pull request title?
yes

Did you apply meaningful labels to the pull request?
yes

Did you perform a self review first?
yes

Documentation reflects changes?
no

CHANGELOG reflects changes?
yes

Unit/Functional tests reflect changes?
n/a

Did you perform browser testing?
yes

Risk level
Low

Relevant links
RIG-6

LGTM! /approved


[Suggestions] Dynamic and sync the screen to the door

Suggestion Type
PIDS Preset
Suggestion
It would be great if U can pls sync the screen that says the "Please stand back from the platform doors " to the doors so that it only pops up while the door is closing? Thank U so much
Assets
No response
Implementation Details/References
No response

Not planned as it adds too much complexity, it's not possible to satisfy everyone's requirement.
This may be possible with PIDS scripting in the future, but no promise :)


Metadata Source Ingestion

Parent of #194
Parent of #233
Parent of #234
Parent of #235
Parent of #236
Parent of #237
Parent of #476
Parent of #477
Parent of #478
Parent of #499
As A SysAdmin I would like to be able to connect to a JDBC Source to pull in Metadata as a key value pair
This Story will contain several tasks:

Creating the UI (the box on the main ui grid, and the section in the menu called DataSources
Creating the service that will reach out to JDBC sources and put the data into Tempus in key value pairs.
Create the data model that will allow us to persist this connection information
Create The controller that will allow us to configure this via a rest API

The scope is limited to Drilling


Support reporting metrics to prometheus

What is the purpose of the change
Support reporting metrics to prometheus.(use PrometheusReporter or use PrometheusPushGatewayReporter)
Instructions for use
Put the following configuration into the global configuration.

remote-shuffle.metrics.reporter.promgateway.factory.class: com.alibaba.flink.shuffle.metrics.reporter.PrometheusPushGatewayReporterFactory
remote-shuffle.metrics.reporter.promgateway.host: xxxxxx
remote-shuffle.metrics.reporter.promgateway.port: 9091
remote-shuffle.metrics.reporter.promgateway.jobName: flink-remote-shuffle
remote-shuffle.metrics.reporter.promgateway.randomJobNameSuffix: true
remote-shuffle.metrics.reporter.promgateway.deleteOnShutdown: false
remote-shuffle.metrics.reporter.promgateway.interval: 60 SECONDS

This is big change. I will take a look.

As this PR has no update for a long time. Let's move the discussion to https://github.com/flink-extended/flink-remote-shuffle/pull/64.


Lock jsonschema to 3.2.0

why it needs to be locked to version 3.2?

We got around this by adding jsonschema==3.2.0 in our requirements. What we were seeing at the time was this package tried to install jsonschema 4.0.0 which got openapi-schema-validator into a recursive loop which lasted longer than our worker timeout of 60 seconds. It never got past the schema validation.
Similar problem here: https://github.com/p1c2u/openapi-spec-validator/pull/132

Well the spec validator requires the schema validator (this repo/package) - why specific the jsonschema explicitly downstream, when it is delivered upstream already? ... pinning to me is always a future problem (synchronized re-pinning or unpinning).
As both repos are under the same roof, why not coordinate by removing jsonschema dep form the spec-validator and add in here schema-validator a greater or equal pinning of the jsonschema depending on the required capabilities? ... JSON Schema 2020-12 draft comes to my mind ...

jsonschema requirement will be update to fix deprecation warning hence closing this one.


cd in procfile not working for me

When trying to run the Procfile.dev it couldn't complain
Error: Cannot find module '/Users/henk/projects/react-webpack-rails-tutorial/server.js'

Looks like foreman 0.78.0 doesn't handle cd's, no idea why.
I got it working by changing the Procfile to this:
web: rails s -p 4000
client: sh -c 'cd client && $(npm bin)/webpack -w --config webpack.rails.config.js'
hot: sh -c 'cd client && node server.js'

Thanks for the heads up.

@hampei Please see #41. Can you give me a :+1: ?


[ NEW API ] - Change Log

[ NEW API ] - Change Log
RPG

Save Classes in configuration file
Functions to edit classes using other plugin

Code:
$this->rpg = $this->getServer()->getPluginManager()->getPlugin('PocketRPG');
To-Do

Cooldown Quests
New Classes

Cooldown quests? In the way of? :P

idk ;-; is one suggestion to make best RPG plugin

No I mean, what do you mean exactly with cooldown quests?

Btw right now it is the best RPG plugin. (It's the only one LOL)

missions cooldown would like to earn XP faster or items without having to recreate the cooldowns having regard to redo missions

The whole plugin will be rewritten using the API once that's done, so the plugin will be a lot smaller size and so you will be able to use the API 😄

Going to add the API into the wiki, so we can close this issue.


Add chalk and inquirer package

Add the following NPM packages

Chalk
Inquirer

Codecov Report

Merging #30 (d4625b1) into develop (d784da9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines           15        15
=========================================
  Hits            15        15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d784da9...d4625b1. Read the comment docs.


Don't always filter out the variables category in tutorials

In tutorial mode, we always remove the variables category even if you use variable blocks in your code because the category itself doesn't have any child blocks in its definition. This fixes that bug.

Whoops, forgot to handle the namespace filters

Fixed


Does the bot-only apps that are marked isNotificationOnly surface in personal app tray?

This page does not inform the developer whether a bot-only apps that are marked isNotificationOnly: true surface in personal app tray or not.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4abeb028-952d-f6f3-3775-d74da0e5cc12
Version Independent ID: e7764a56-c0a1-11e0-fb02-bc0724ee6f7b
Content: Notification-only bots - Teams
Content Source: msteams-platform/resources/bot-v3/bots-notification-only.md
Product: msteams
GitHub Login: @laujan
Microsoft Alias: lajanuar

Thank you.


Taxonomies: Provide ability for category listing to update in the editor

Feature Description
Originally reported by @barklund
Categories don’t reload while in the editor. I know that’s pretty much by design, but in this context (where we’re all editing categories), it would be nice. Maybe have an “update categories” link somewhere to refresh? You might be editing a story, realise that you want to reorganise categories, go out to the category section to do so and the when coming back to the story, you want to reload just the category tree. It could just be a small button with a reload icon.
[Brittany] +1, this would be great too for when searching categories

Alternatives Considered

Additional Context

@littlemilkstudio will you weigh in here and point this?

a small button to refresh the categories shouldn't be bad. maybe a 2 pointer. updating the search to hit the backend instead of the current pulled down categories is probably a 3 pointer.
All depends on the UX we want here. In the description, it sounds like you and Morten are proposing different solutions to the same problem?
Should we run the problem by Andrew or Amy to weigh in on exactly what behavior they want? then accurately scope and describe the feature request?

Seems like a low prio use case to me IMO. One can just reload the editor.

Let's pause on this one and see if it remains an inconvenience/tackle it when there's a lull.


Move mxnet-dependent code to gluonts.mx

Issue #, if available: Related to #1181
Description of changes: This makes sure there is no occurrence of import mxnet, from mxnet, from mx, import gluonts.mx, from gluonts.mx anywhere in src, with the possible exception of modules from src/gluonts/mx, src/gluonts/model, src/gluonts/nursery, and other modules which are used to keep backward compatible (but deprecated) import paths.
New code:

introduced skip_encoding in gluonts.core.serde, to allow decoupling validated from mxnet dependency, and adapted validated accordingly

Moving code:

moving from gluonts.core.component -> gluonts.mx.component: equals_parameter_dict, equals_representable_block
moving from gluonts.model.common -> gluonts.mx.common: Tensor, TensorTransformer, GlobalConfig
moving gluonts.support.linalg_util -> gluonts.mx.linalg_util
moving from gluonts.support.util -> gluonts.mx.util: erf, erfinv, _broadcast_param, make_nd_diag, cumsum, export_repr_block, copy_parameters, get_hybrid_forward_input_names, weighted_average, export_symb_block, get_hybrid_forward_input_names, hybrid_block_to_symbol_block, import_repr_block, import_symb_block, HybridContext, assert_shape

Other changes:

adjust imports to reflect the above changes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Can you re-order the imports so that the gluonts.mx-lines are together?


[Bug] failed to load rendersystemdx11.dll

Before Reporting

[X] I found no existing issues matching my bug
[X] My issue is not caused by a theme

Describe the Bug
This is causing my CS2 ive also heard it can break dota2 to give an error related to "failed to load rendersystemdx11.dll"
this only happened after installing millennium
Expected Behavior
launch cs2 and be able to play competitive.
Steps To Reproduce

launch cs2 with Millennium installed
gives a "failed to load rendersystemdx11.dll" error

Operating System
Windows
Anything else?
No response

the CS2 stop crashing after i removed millennium.

Have you tried anything to fix this?
From a glance I see this

Microsoft Visual C++ 2015
is already installed
launching the game via .EXE disables VAC, Therefore competitive is disabled.

In your steam folder, find User32.dll and delete it. then try CS. if it works, try to create a new text file and name it User32.dll (essentially just an empty renamed text file) in the same spot you deleted it from and try that

Just an update, not sure if you've fixed this, but I've heard back from some community members that CS2 competitive plays fine with and without millennium.

Closing due to no response


Gaussian smoothing of atlas only allowed to be integer

The GUI lets you select real values for the Gaussian smoothing parameter (atlas building), but only the rounded integer part is applied.

corrected in current master


Training: Fix description about gang-scheduling for mpi-operator

Currently, mpi-operator supports gang-scheduling with scheduler-plugins.

/assign @terrytangyuan @alculquicondor


g++ and linux-headers in docker base images

Hi!
We are working on HA custom integration that relies on grpcio and grpcio-tools python packages and during wheel building, they fail because host OS doesn't have appropriate libraries. With some testing on HomeAssistant alpine docker image, it boils down to g++and linux-headers packages.
It is possible to SSH to the container and install these packages manually that fixes the wheel building, but it's not at all the right way to do it. Is it possible to include g++ and linux-headers in the Dockerfile for base images?
p.s. once i find out some more info about including these packages in base images, i would also ask the same question in HomeAssistant Operating System repo, perhaps being included in Dockerfile

If it's just needed to build the wheels, just add the integration here https://github.com/home-assistant/wheels-custom-integrations

Thank you for your reply, @ludeeus.
Wait, so if I add integration there, the action fail to build with "gcc" command related error (and is fixed after installing g++ and linux-headers systemwide), like so: https://github.com/home-assistant/wheels-custom-integrations/runs/1860558838.
That's the reason why i though we need to clear up the questions about g++ and linux-headers here before opening a PR in wheels-custom-integrations

https://github.com/home-assistant/wheels-custom-integrations/blob/master/requirements.json add new requirements here

Oh, that's magical! Makes total sense, thank you, @ludeeus! Closing it


Pull request, add getCountryByLocale and getCountryByName

In order to expand the usability of the library to fetch the drawables it contains, two new methods were added. They have been tested manually, and if interested I could add a new field to the test app for their usage. This pull request addresses issue  #12.
  public Country getCountryByLocale( Context context, Locale locale ) {
    this.context = context;
    String countryIsoCode = locale.getISO3Country().substring(0,2).toLowerCase();
    return getCountry(countryIsoCode);
  }

  public Country getCountryByName ( Context context, String countryName ) {
    this.context = context;
    Map<String, String> countries = new HashMap<>();
    for (String iso : Locale.getISOCountries()) {
      Locale l = new Locale("", iso);
      countries.put(l.getDisplayCountry(), iso);
    }

For making this possible, a part of public Country getUserCountryInfo(Context context) was refactored out into it's own function to be reused, and is now found in
  private Country getCountry( String countryIsoCode ) {
    getAllCountries();
    for (int i = 0; i < allCountriesList.size(); i++) {
      Country country = allCountriesList.get(i);
      if (country.getCode().equalsIgnoreCase(countryIsoCode)) {
        country.setFlag(getFlagResId(country.getCode()));
        return country;
       }
    }
  }

Thanks!

@kykrueger can you also update the readme file with your changes??

                                                                                Sure can,I'll do it when I have a break from my current project.--Kyle                                                                                Sent from my BlackBerry 10 smartphone.                                                                                From: Mukesh SolankiSent: Donnerstag, 12. Januar 2017 11:08To: mukeshsolanki/country-picker-androidReply To: mukeshsolanki/country-picker-androidCc: Kyle Krueger; MentionSubject: Re: [mukeshsolanki/country-picker-android] Pull request, add getCountryByLocale and getCountryByName (#13)@kykrueger can you also update the readme file with your changes??

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mukeshsolanki/country-picker-android","title":"mukeshsolanki/country-picker-android","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mukeshsolanki/country-picker-android"}},"updates":{"snippets":[{"icon":"PERSON","message":"@mukeshsolanki in #13: @kykrueger can you also update the readme file with your changes??"}],"action":{"name":"View Pull Request","url":"https://github.com/mukeshsolanki/country-picker-android/pull/13#issuecomment-272123908"}}}


Pre-packaged templates returning 403 when viewed

Describe the bug
When trying to access the pre-packaged templates as per the readme section, I'm presented with a 403 access denied request.
To Reproduce
Click on the links provided by the readme
Expected behavior
The links should load correctly and display the template
Please complete the following information about the solution:
n/a
Screenshots
n/a
Additional context
Add any other context about the problem here.

+1

This doesn't appear to have been resolved by the latest release yesterday, the template links still appear to go to a 403 page.


i18n tooling using Transifex

Note: @Oppia don't have the time to review the upstream pull request (https://github.com/oppia/xblock/pull/2), hence they can't get it merged. Opening it here as an intermediate solution. I've also switch to Transifex.

We'd like this XBlock to be translated to Japanese and other languages, I've also supported JavaScript translations via
django-statici18n.
Before you continue, take a look at edx/i18n-tools and edx/cookiecutter-django-app.
Summary of the Changes

Added a Makefile to help manage the translations. The file is copied and modified from: edx/cookiecutter-django-app
Created a locale link to oppia/translations to allow the i18n_tools find the po/mo files
Added oppia/translations/config.yaml which works as the configuration file of the i18n_tools command
Added requirements-dev.txt to pin development packages. Used for now only for translations.

TODO

[x] Support JavaScript translations as textjs.po
[x] Document how to update the strings properly from Transifex
[x] Manually test that the the dummy Esperanto translation is
[ ] After merge: Inform @Oppia to update their README.md to point to this XBlock

Cheese
Studio

LMS

@OmarIthawi Thanks for creating the PR. The code looks amazing, but following your advice I've been trying to run the XBlock in my devstack.
I installed your feature branch and the first error I have is the following:
Traceback (most recent call last):
  File "/edx/app/edxapp/edx-platform/cms/djangoapps/contentstore/views/preview.py", line 304, in get_preview_fragment
    fragment = module.render(preview_view, context)
  File "/edx/app/edxapp/venvs/edxapp/src/xblock/xblock/core.py", line 193, in render
    return self.runtime.render(self, view, context)
  File "/edx/app/edxapp/edx-platform/common/lib/xmodule/xmodule/x_module.py", line 1889, in render
    return self.__getattr__('render')(block, view_name, context)
  File "/edx/app/edxapp/edx-platform/common/lib/xmodule/xmodule/x_module.py", line 1297, in render
    return super(MetricsMixin, self).render(block, view_name, context=context)
  File "/edx/app/edxapp/venvs/edxapp/src/xblock/xblock/runtime.py", line 806, in render
    frag = view_fn(context)
  File "/edx/app/edxapp/edx-platform/common/lib/xmodule/xmodule/vertical_block.py", line 97, in author_view
    self.render_children(context, fragment, can_reorder=True, can_add=True)
  File "/edx/app/edxapp/edx-platform/common/lib/xmodule/xmodule/studio_editable.py", line 26, in render_children
    rendered_child = child.render(StudioEditableModule.get_preview_view_name(child), context)
  File "/edx/app/edxapp/venvs/edxapp/src/xblock/xblock/core.py", line 193, in render
    return self.runtime.render(self, view, context)
  File "/edx/app/edxapp/edx-platform/common/lib/xmodule/xmodule/x_module.py", line 1889, in render
    return self.__getattr__('render')(block, view_name, context)
  File "/edx/app/edxapp/edx-platform/common/lib/xmodule/xmodule/x_module.py", line 1297, in render
    return super(MetricsMixin, self).render(block, view_name, context=context)
  File "/edx/app/edxapp/venvs/edxapp/src/xblock/xblock/runtime.py", line 806, in render
    frag = view_fn(context)
  File "/edx/app/edxapp/venvs/edxapp/local/lib/python2.7/site-packages/oppia/oppia.py", line 85, in student_view
    'oppiaid': self.oppiaid,
  File "/edx/app/edxapp/venvs/edxapp/local/lib/python2.7/site-packages/oppia/oppia.py", line 67, in render_template
    i18n_service=self.runtime.service(self, "i18n"),
TypeError: render_django_template() got an unexpected keyword argument 'i18n_service'

I think you're working on a newer version of XBlock and XBlock-utils.
I tried upgrading the XBlock and XBlock-utils versions manually and I got a new error:
Traceback (most recent call last):
  File "/edx/app/edxapp/edx-platform/cms/djangoapps/contentstore/views/preview.py", line 304, in get_preview_fragment
    fragment = module.render(preview_view, context)
  File "/edx/app/edxapp/venvs/edxapp/src/xblock/xblock/core.py", line 202, in render
    return self.runtime.render(self, view, context)
  File "/edx/app/edxapp/edx-platform/common/lib/xmodule/xmodule/x_module.py", line 1889, in render
    return self.__getattr__('render')(block, view_name, context)
  File "/edx/app/edxapp/edx-platform/common/lib/xmodule/xmodule/x_module.py", line 1297, in render
    return super(MetricsMixin, self).render(block, view_name, context=context)
  File "/edx/app/edxapp/venvs/edxapp/src/xblock/xblock/runtime.py", line 810, in render
    frag = view_fn(context)
  File "/edx/app/edxapp/venvs/edxapp/local/lib/python2.7/site-packages/oppia/oppia.py", line 85, in student_view
    'oppiaid': self.oppiaid,
  File "/edx/app/edxapp/venvs/edxapp/local/lib/python2.7/site-packages/oppia/oppia.py", line 67, in render_template
    i18n_service=self.runtime.service(self, "i18n"),
  File "/edx/app/edxapp/venvs/edxapp/src/xblock-utils/xblockutils/resources.py", line 77, in render_django_template
    template_str = self.load_unicode(template_path)
  File "/edx/app/edxapp/venvs/edxapp/src/xblock-utils/xblockutils/resources.py", line 47, in load_unicode
    resource_content = pkg_resources.resource_string(self.module_name, resource_path)
  File "/edx/app/edxapp/venvs/edxapp/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 1215, in resource_string
    self, resource_name
  File "/edx/app/edxapp/venvs/edxapp/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 1457, in get_resource_string
    return self._get(self._fn(self.module_path, resource_name))
  File "/edx/app/edxapp/venvs/edxapp/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 1577, in _get
    with open(path, 'rb') as stream:
IOError: [Errno 2] No such file or directory: '/edx/app/edxapp/venvs/edxapp/local/lib/python2.7/site-packages/oppia/templates/oppia.html'

Can you point me to some instructions to install it? Or if we need to upgrade the dependencies version (we're in still on Ficus) we will need to plan that, to make sure others XBlocks still work.
Thanks!

@melvinsoft You'd need the same version of XBlock in Ficus:
<EMAIL_ADDRESS>
and this specific XBlock utils:

https://github.com/appsembler/edx-platform/pull/265

Please also make sure you're using the same branch of this PR omar/tx-i18n.
I've just tried it and it works fine, please try again.

Thanks @melvinsoft, I'll take a look and let you know.

@melvinsoft Please take another look. I've fixed the data and public issue.

@OmarIthawi Thanks for addressing the change! It's working now. I'm testing the Makefile commands and I've found a couple of issues. All the other commands work like a charm.
pull_translations
If you run make pull_translations without a transifex file, it's just return this exception:
Pulling conf/locale/config.yaml:locales from Transifex...
Exception: No user credentials found for host https://www.transifex.com. Edit ~/.transifexrc and add the appropriate info in there.
Traceback (most recent call last):
  ...
make: *** [pull_translations] Error 1

Do you think we should add some check in the Make command and return a proper error message and some instructions if the file isn't there, instead of returning the exception directly?
make test
This command is throwing an error, here is the stack trace I'm getting.
find . -name '__pycache__' -exec rm -rf {} +
find . -name '*.pyc' -exec rm -f {} +
find . -name '*.pyo' -exec rm -f {} +
find . -name '*~' -exec rm -f {} +
find . -name '*.pot' -exec rm -f {} +
rm -f locale/en/LC_MESSAGES/*
find oppia/translations -name djangojs.mo -exec rm -f {} +
find oppia/translations -name djangojs.po -exec rm -f {} +
find oppia/translations -name textjs.mo -exec rm -f {} +
rm -fr build/
rm -fr dist/
rm -fr *.egg-info
python run_tests.py
python: can't open file 'run_tests.py': [Errno 2] No such file or directory
make: *** [test] Error 2

make quality
echo 'TODO: Refactor quality checks from .travis.yml into this Makefile'
TODO: Refactor quality checks from .travis.yml into this Makefile
exit 1
make: *** [quality] Error 1

@melvinsoft I've removed quality and test Make rules.
Regarding the pull_translations, please take a this section of the README.

Thanks @melvinsoft! I'll merge it.

@seanlip FYI.


Add tests to helm/pkg/kube/client_test.go to cover wait.go

What this PR does / why we need it:
fixes: #13417
Special notes for your reviewer:
If applicable:

[ ] this PR contains user facing changes (the docs needed label should be applied if so)
[x] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

Why is this in client_test.go rather than creating a wait_test.go?

I am ok with it being done at the client level. I am looking for test coverage for every func in this whole folder because I want to refactor it when helm 4 development starts.

The coverage for the helm.sh/helm/v3/pkg/kube module goes from  47.6% to 57.1% with these added tests!


Add styling for non-arabic list styles

Fixes https://github.com/pradyunsg/furo/issues/261, literally translating the CSS posted by @latosha-maltba to Sass, thanks!

Thanks @yeraydiazdiaz! ^>^


Intermittent Flakiness in Feature Flags on Safari/MacOS

We have noticed an inconsistent behavior with our feature flags, specifically on Safari/MacOS. The issue manifests as a discrepancy between the network tab and the useFlags report.
In some instances, despite the network tab clearly indicating that a feature flag is enabled, useFlags reports the flag as disabled. This inconsistency is not constant but occurs intermittently and appears to be more frequent on Safari/MacOS.
Logs related to this issue are attached below for further investigation.
 "flagsmith": "3.23.2",

                      <FlagsmithProvider
                        options={{
                          environmentID:
                            getEnvVariable('VITE_FLAGSMITH_ENV_KEY') ?? '',
                          enableLogs: true,
                        }}
                        flagsmith={flagsmith}
                      >

[Log] FLAGSMITH: –<PHONE_NUMBER>190 – "ms" – "Initialising with properties" (2) (flagsmith.js, line 390)
{environmentID: "###", api: "https://edge.api.flagsmith.com/api/v1/", headers: undefined, onChange: function, cacheFlags: undefined, …}
t2 {_trigger: function, _triggerLoadingState: function, timestamp: null, isLoading: false, eventSource: null, …}
[Log] FLAGSMITH: – 0 – "ms" – "Get Flags" (flagsmith.js, line 390)
[Log] FLAGSMITH: – 1 – "ms" – "Initialising with properties" (2) (flagsmith.js, line 390)
{environmentID: "###", api: "https://edge.api.flagsmith.com/api/v1/", headers: undefined, onChange: function, cacheFlags: undefined, …}
t2 {_trigger: function, _triggerLoadingState: function, timestamp: null, isLoading: true, eventSource: null, …}
[Log] FLAGSMITH: – 0 – "ms" – "Get Flags" (flagsmith.js, line 390)
[Log] FLAGSMITH: – 2 – "ms" – "React - Initialising event listeners" (flagsmith.js, line 390)
[Log] FLAGSMITH: – 2 – "ms" – "React - Initialising event listeners" (flagsmith.js, line 390)
[Log] FLAGSMITH: – 109 – "ms" – "React - Initialising event listeners" (flagsmith.js, line 390)
[Log] COMPONENT {flag: false} (index.tsx, line 35)
[Log] FLAGSMITH: – 112 – "ms" – "React - Initialising event listeners" (flagsmith.js, line 390)
[Log] COMPONENT {flag: false} (index.tsx, line 35)
[Log] FLAGSMITH: – 349 – "ms" – "Fetch response: 200 GET0https://edge.api.flagsmith.com/api/v1/flags/" (flagsmith.js, line 390)
[Log] FLAGSMITH: – 350 – "ms" – "Loading state changed" – {error: null, isFetching: false, isLoading: false, …} (flagsmith.js, line 390)
{error: null, isFetching: false, isLoading: false, source: "SERVER"}Object
[Log] FLAGSMITH: – 350 – "ms" – "trigger called" (flagsmith.js, line 390)
[Log] FLAGSMITH: – 350 – "ms" – "React - trigger event received" (flagsmith.js, line 390)
[Log] FLAGSMITH: – 350 – "ms" – "React - useFlags flags and traits have changed" (flagsmith.js, line 390, x2)
[Log] FLAGSMITH: – 350 – "ms" – "Fetch response: 200 GET0https://edge.api.flagsmith.com/api/v1/flags/" (flagsmith.js, line 390)
[Log] FLAGSMITH: – 351 – "ms" – "trigger called" (flagsmith.js, line 390)
[Log] FLAGSMITH: – 351 – "ms" – "React - trigger event received" (flagsmith.js, line 390)
[Log] FLAGSMITH: – 351 – "ms" – "React - useFlags flags and traits have changed" (flagsmith.js, line 390, x2)
[Log] COMPONENT {flag: false} (index.tsx, line 35)
[Log] COMPONENT {flag: false} (index.tsx, line 35)

In network tab I can see one request to flagsmith edge api. (https://edge.api.flagsmith.com/api/v1/flags/)
After payload inspection I can clearly see that flag which we're interested in is enabled:
{
    "feature": {
        "id": 50575,
        "type": "STANDARD",
        "name": "sample-flag"
    },
    "feature_state_value": "",
    "enabled": true
}

It’s also worth noting that there is no segment overriding logic in place that could potentially cause this discrepancy.

Hi @ea244wmi would it be possible to get a minimal code example for this? I can't really see why safari could behave any differently here but I'm sure we'll solve it if we can get replication.

Closing for now, please re-open with any further information.


fixed home page #63

Current coverage is 57.54%

Merging #73 into master will not affect coverage as of ebffca6

@@            master     #73   diff @@
======================================
  Files           13      13
  Stmts          179     179
  Branches         0       0
  Methods          0       0
======================================
  Hit            103     103
  Partial          0       0
  Missed          76      76

Review entire Coverage Diff as of ebffca6

Powered by Codecov. Updated on successful CI builds.


Accessibility issues (focus by keyboard)

We cant to change focus from table to prevous or next element (button or other focusable html element) by tab, shift+tab keys.

That is right, I'm going to make sure:

Shift + Tab from the top-left cell will focus previous focusable element
Tab from the bottom-right cell will focus next focusable element

Thx for the feedback ;)

Hey @dmikoss ,
This is now available in 3.1.2 ;)


<EMAIL_ADDRESS>on build #2: short

Feedback from<EMAIL_ADDRESS>: short

Item
Value

Created
Thu Feb 23 2017 11:38:01 GMT-0800 (PST)

CFBundleShortVersion
1.0

CFBundleVersion
1

App uptime
3871.655

Build
2

Device type
iPhone 5s

Device name
Golson's iPhone

Screen size
320

Screen size
320px by 568px

Battery
99% Charging

Memory free
65 MB / 2911 MB

Disk free
452 MB / 11636 MB

Network IP
<IP_ADDRESS>

Link to buddybuild feedback from build 2

Feedback from<EMAIL_ADDRESS>: comment

Item
Value

Created
Thu Feb 23 2017 11:46:25 GMT-0800 (PST)

CFBundleShortVersion
1.0

CFBundleVersion
1

App uptime
4374.607

Build
2

Device type
iPhone 5s

Device name
Golson's iPhone

Screen size
320

Screen size
320px by 568px

Battery
100% Charging

Memory free
106 MB / 2894 MB

Disk free
456 MB / 11636 MB

Network IP
<IP_ADDRESS>

Link to buddybuild feedback from build 2

Feedback from<EMAIL_ADDRESS>:  ghe comment

Item
Value

Created
Thu Feb 23 2017 11:49:18 GMT-0800 (PST)

CFBundleShortVersion
1.0

CFBundleVersion
1

App uptime
13.05385

Build
2

Device type
iPhone 5s

Device name
Golson's iPhone

Screen size
320

Screen size
320px by 568px

Battery
100% Charging

Memory free
120 MB / 2946 MB

Disk free
476 MB / 11636 MB

Network IP
<IP_ADDRESS>

Link to buddybuild feedback from build 2


Refactor shell connect

Description of Changes

[ ] Wrote at least one-line docstrings (for any new functions)
[ ] Added unit test(s) covering the changes (if testable)

[ ] Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #https://github.com/spyder-ide/spyder/issues/15921
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

Hello @impact27! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/plugins/ipythonconsole/utils/shellconnect.py:

Line 90:1: E302 expected 2 blank lines, found 1
Line 202:1: W391 blank line at end of file


add expires_in as optional param for refreshAccessToken

Found that I wanted to control the expire time for oauth2 access tokens on refresh. Figured you might want this too.
Cheers.

Looks great, thank for adding this!
@lukasolson Mind adding me as a Collaborator on the npm package as well so that I can publish this change?

:+1: I've added ya


PIP Repository error

Could not install packages due to an EnvironmentError: 404 Client Error: Not Found for url: https://pypi.org/simple/gcsf/

Either you have the wrong project, or you have simply missed the "s" off the package name


derived Hash trait for PgInterval

First of all, thank you for all the hard work you put into this library.
This is required for these changes in SeaQuery to work.

Thank you!


replace stackstac with odc-stac in markdown

This notebook previously used stackstac to load the data but now uses odc.stac.  This PR just modifies the markdown in the documentation so it agrees with the code.

Hi, thanks for fixing the typo!


Add option to filter results by publication

In the filter options at the right side of the page it would be awesome if we could ask for all variants associated with a particular publication (e.g. pubmed ID).

This is completed and pushed to master!


Create useRefs hook

Was working on transitions last week and was looking into the useRegisterRefs hook, got annoyed by having to create types for the refs in the transition controller and refs a component.

Utility to create an object that automatically create refs. One ref object to rule them all, you don't have to use useRef for every element that you want to create a reference for.

always create empty array when (re)setting array refs, so you don't have to explicitly pass an empty array as initial value.

This is not possible because we don't have the type information during runtime.

separate hook to support converting ref functions to ref objects to be passed as an initial ref to this hook

We already use the useEnsuredForwardedRef hook from react-use in our projects, I think we can keep using that.

always create empty array when (re)setting array refs, so you don't have to explicitly pass an empty array as initial value.

This is not possible because we don't have the type information during runtime.

During runtime it's possible (in the array ref setter), I believe the issue is more about not being able to type this correctly, right?

During runtime it's possible (in the array ref setter), I believe the issue is more about not being able to type this correctly, right?

@ThaNarie types weren't the issue, we're now creating a new ref array in the arrayRef utility (thanks for the suggestion 😉 )


alpa should not depend on private functorch APIs

Please describe the bug
Hi, I am one of the developers for functorch. We're in the process of refactoring functorch internals. I noticed that you're using private functorch APIs in alpa: https://github.com/alpa-projects/alpa/blob/4f1495528bcb26fcfffd9de51cc299b83bb0f7a0/alpa/torch/init.py#L69-L76, which our refactor will break.
There is an easier way to implement the functorch_value_and_grad function that is more robust:
def functorch_value_and_grad(func, argnums, has_aux):
  fn = functorch.grad_and_value(func, argnums, has_aux)
  def wrapper(*args, **kwargs):
    grad, value = fn(*args, **kwargs)
    return value, grad
  return wrapper

@zou3519 Thanks for the information.
@yf225 Could we just replace the functorch_value_and_grad using the suggested one above?

closed due to inactivity. We pause the development of the pytorch frontend


org.gradle.parallel=false is broken

Expected Behavior
Using -Dorg.gradle.parallel=false on the command line should disable parallel execution of tasks
Current Behavior
Task are executed in parallel
00:00:17.183 + ./gradlew --no-daemon --project-prop jacoco=true --exclude-task classes --exclude-task jar -Dorg.gradle.parallel=false -Dorg.gradle.configureondemand=false check dependencyCheck sonarqube
00:00:19.928 Parallel execution is an incubating feature.

Thanks for reporting. It already has been reported so I am closing your issue as duplicate: https://github.com/gradle/gradle/issues/1827.


fix unclosed iterators

Relates to https://github.com/osmosis-labs/osmosis/issues/2414
What is the purpose of the change
Fix unclosed iterators
Testing and Verifying

Use custom tool to find unclosed iterators: https://github.com/baabeetaa/osmosis/issues/1
Tested manually with osmosis v11.0.0 on mainnet for ~20mins and found no unclosed iterators.

Note
Sometime i see an err in log, im not sure its is a new bug with pebbledb only (i havent tested with goleveldb) or maybe it does not relate to this PR.
11:41AM ERR recovered (default) panic.  That error you notice is #2487 (also ty for the reminder on that, I thought I made that before but clearly didn't)
It is unrelated to this PR. Thankfully its noise / a minor bug that would become more concerning as complexity grows, but is today safe.


Remove duplicate setup for TRUCK_CHANNEL_electric_enabled

registerChannel was being called twice for TRUCK_CHANNEL_electric_enabled, causing it to error at loading time and not update that telemetry field.

Thank you


typing in the fields do not work

When I try to enter the card data, typing does not work ... I type, type and the character does not appear in the field.

Hi @williamwps .
Can you share snippet of your plugin implementation in your app?

Closing this issue because of in-activty, feel free to reopen this issue if issue still persist in latest version of the package.


rename Cartesi DApp

Seems the commit message is too long

Maybe we can use app instead of application for variable names.

This will need a rebase.

rebased


Queue up diamonds and then create transactions serially for all diamonds in queue every 5 seconds

This prevents users from encountering the You're doing that a bit too quickly. Please wait a second or two and try again. error when giving diamonds in rapid succession.

coming up with a more elegant solution


Feature/replication result propagation

Please note that for legal reasons we require you to sign the
Contributor Agreement
before we can accept your pull requests.

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/208/


Add CacheWithDisposal to cache resources that require disposal

Whenever an element is fetched from the cache, a value is returned along with a deref function
that must be called to allow the element to be returned.  Once evicted, the object can only be
disposed of after all its references have been returned to the cache.
The implementation is mostly just mixing a reference count onto each entry in the cache.
And now, a rant.
Caching resources that require disposal (such as anything with a file descriptor) is difficult
in garbage-collected languages, because of garbage collection.  Only memory presure triggers
GC, so it is entirely inappropriate for handling other resources.  But the lack of destructors
leaves no way to force resource cleanups.  Instead we have to return an explicit function that
returns the object to the pool.  A language such as C++ calls destructors at clear places, and
would allow returning special object references that handle lifetimes.  In fact it already has
shared_ptr in the standard library.

This change is

Codecov Report

Merging #1044 (a5df24f) into master (4895fae) will decrease coverage by 0.03%.
The diff coverage is 34.78%.

@@            Coverage Diff             @@
##           master    #1044      +/-   ##
==========================================
- Coverage   46.22%   46.19%   -0.04%
==========================================
  Files         152      153       +1
  Lines       12315    12358      +43
==========================================
+ Hits         5693     5709      +16
- Misses       5896     5918      +22
- Partials      726      731       +5

Impacted Files
Coverage Δ

cache/cache.go
0.00% <0.00%> (ø)

cache/refcnted.go
43.24% <43.24%> (ø)

config/logger.go
64.28% <0.00%> (-10.72%)
:arrow_down:

gateway/operations/listobjects.go
0.00% <0.00%> (ø)

catalog/mvcc/cataloger_list_entries.go
85.34% <0.00%> (+0.12%)
:arrow_up:

catalog/mvcc/cataloger_create_repository.go
66.66% <0.00%> (+7.40%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4895fae...c41d96b. Read the comment docs.

Not responding on Reviewable because it asks for permissions on my (public) repos in order to work on Treeverse repos.  Not responding inline because Reviewable put comments from @ozkatz on a single mega-comment up top.
Sorry.

cache/refcnted.go, line 82 at r1 (raw file):
  	entry := v.(*cacheEntry)
  	err := entry.release(ret)
  	logging.Default().WithFields(logging.Fields{

cached values are opaque and might contain sensitive information, not sure I'd spill them blindly to the log.
Additionally, might be better to receive a logger in the constructor ?

Right and righter.  96144d2c07b8aad22198d282929c5cdc672de475

cache/refcnted.go, line 104 at r1 (raw file):

  	entry.acquire()
  } else {
  	v, err := setFn()

so we're serializing all setFn()s of all keys? That's an expensive operation.

We actually have to do this because LRU doesn't give us enough atomicity in its operations to be able to add reference counts.  Instead of fixing this I just sharded everything in f8edf33c494433f327eb5c6a41fc98b5bcba416e.
Thanks; PTAL!

Thanks!  Pulling...


RtspSourceBintr should not be setting rtspsrc plugin property "drop-on-latency" to TRUE.

The RtspSourceBintr is explicitly setting the "drop-on-latency" to TRUE. It should be reading, reporting, and using the default which is FALSE

Work has been pushed to the v0.27.alpha branch


Huge loss of quality after photo import

I have launched "Import from Google" from my beta Cozy. Imported photos are very poor quality. Here are two sample files, one downloaded from Google, the other from Cozy Photos.

Hi @MonsieurLanza, Is the picture from cozy-photos screen or cozy-photos download ?
The image displayed in the browser is resized to (~1000x1000) px, as we favorited the use case of quickly swiping through an album of holliday pictures over picture quality. However downloaded picture (little link on the right of the trash can in bottom bar) should returns the full-size picture.

This is image using cozy-photos download, of course.

OK, I gave it a quick look and it appears there isn't several format in the picasa endpoint as i was hoping when we discussed yesterday. We will need to properly investigate about using the GPhotos endpoint, I have informed the Product team and this will be put in out roadmap.
This issue will be kept open, and we will eventually work on it, but I cant give you a timeframe on when.
If you find a solution, I will gladly review a merge a PR :tada:


ALGO-24: develop/test SOCA LETKF

Develop functional LETKF, and demonstrate that it will work with ocean/ice for both regional and global cases.

we will focus on the regional HAT10 one month case first, in house.
this work will be done with soca-science, replicating under ewok will be done at a later date.

Changed timeline after AOP22 audit - see doc JCSDA_AOP2022_rev 2_20230105 audit. Integrate in Skylab in V4.

"this work will be done with soca-science, replicating under ewok will be done at a later date."

The original goal of getting LETKF working is finished.
Getting it integrated under ewok will not happen in skylab v4.


Add license to package.json and bower.json

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


always show all results

Hi, I filter my results by my own, can i somehow force typeahed to always show all results?

@achtan try to invoke callback with all suggestions without filtering, also set data-min-length=0 to show drop-down on focus

i'm not sure if i know what u mean, but:
<input class="form-control typeahead search" name="search" type="text"
               placeholder="NBA teams"
               autocomplete="off" spellcheck="off"
               data-source="suggestions"
               data-selected="selected"
               data-min-length=0
               data-templates="suggestion"
               data-value-key="name"/>

Template.searchFilter.helpers({
  suggestions(query, sync, callback) {
    callback(Template.instance().suggestionsResults.get());
    //return Template.instance().suggestionsResults.get(); // with this line it works
  }
});

i'm getting errors:
on input focus: Uncaught TypeError: dataset.local is not a function
on search: Uncaught TypeError: callback is not a function
with this helpers it works ok
Template.searchFilter.helpers({
  suggestions() {
    return Template.instance().suggestionsResults.get();
  }
});

@achtan suggestions function must take three arguments (query, sync, async) and you need to call sync(Template.instance().suggestionsResults.get()) to pass suggestion to typeahead plugin

@achtan btw the sample when suggestions function has three arguments should work

@achtan please try to reproduce issue with uncought TypeError in demo app and send the sample code with repro

ok with sync() it works, but there is still one issue:
if i search for "f" i got zero results
if i search for "fo" i got results for "f" search
if i search for "foo" i got results for "fo" search
and so on... there is a one-step-delay
because my data Template.instance().suggestionsResults.get() comms from server (my guess) and the suggestionshelpers is executed before the new data arrive

@achtan try to useasync as completion callback for Template.instance().suggestionsResults.get() request

but async is undefined in suggestions helpers function

@achtan async is last argument in your suggestions helper function

i know, but as i said, 3rd argument of helpers function is undefined

@achtan it seems you use v0.10.x version where async argument was second one

no i have: sergeyt:typeahead           0.11.1_1

@achtan I've added working example to demo app.


Add neutral CrvSteps per Ralf's request

Add neutral CrvSteps per Ralf's request

Hi @brownd1978,
You have proposed changes to files in these packages:

JobConfig

which require these tests: build.
@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.
:hourglass: The following tests have been triggered for b42e89ca65c339e158e2d38d03464ab1d6d8c803: build  (Build queue is empty)
About FNALbuild. Code review on Mu2e/Offline.

:sunny: The build tests passed at b42e89ca65c339e158e2d38d03464ab1d6d8c803.

Test
Result
Details

test with
:white_check_mark:
Command did not list any other PRs to include

merge
:white_check_mark:
Merged b42e89ca65c339e158e2d38d03464ab1d6d8c803 at a21fd809a8bf282f47bddbd82acbd33d36db3af7

build (prof)
:white_check_mark:
Log file. Build time: 11 min 07 sec

ceSimReco
:white_check_mark:
Log file.

g4test_03MT
:white_check_mark:
Log file.

transportOnly
:white_check_mark:
Log file.

POT
:white_check_mark:
Log file.

g4study
:white_check_mark:
Log file.

cosmicSimReco
:white_check_mark:
Log file.

cosmicOffSpill
:white_check_mark:
Log file.

ceSteps
:white_check_mark:
Log file.

ceDigi
:white_check_mark:
Log file.

muDauSteps
:white_check_mark:
Log file.

ceMix
:white_check_mark:
Log file.

rootOverlaps
:white_check_mark:
Log file.

g4surfaceCheck
:white_check_mark:
Log file.

FIXME, TODO
:white_check_mark:
TODO (0) FIXME (0) in 0 files

clang-tidy
:white_check_mark:
0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at b42e89ca65c339e158e2d38d03464ab1d6d8c803 after being merged into the base branch at a21fd809a8bf282f47bddbd82acbd33d36db3af7.
For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.


Add header

@gjtorikian @nathos @jasonrudolph
Hi guys, :smile:
I add a second header to api/ruby/basics-of-authentication/README.md  for a better overview.
Yours,
Suriyaa Kudo :octocat:

Great, thank you!

welcom
On Sun, Nov 22, 2015 at 10:18 PM, Garen Torikian<EMAIL_ADDRESS>wrote:

Great, thank you!
—
Reply to this email directly or view it on GitHub
https://github.com/github/platform-samples/pull/77#issuecomment-158774592
.

Your welcome! :smile:


Custom download url not use cache

Download bun is slowly, I use the custom url like this.
with:
  bun-download-url: "https://**/caches/bun/v1.1.24/bun-linux-x64.zip"
  bun-version: 1.1.24

But it always download from web not from cache.
Expect if cache hit the version, it can use cache, or form local toolcache dir like this.
const tc = require('@actions/tool-cache');

const cachedPath = await tc.cacheDir(extractedFolder, 'bun', '1.1.24');

const bunDirectory = tc.find('bun', '1.1.24', 'x64');

We can't ensure that the binary from custom url is always same. Also why you're using custom download url?

We can't ensure that the binary from custom url is always same. Also why you're using custom download url?

Downloading is unstable in China

I think ensure the binary same should be left up to the user, user specified the custom download and version is that he expects to be able to control the binary.
If a problem occurs, users can correct it themselves.


Create new HTTP Status Codes for backend APIs for Errors

Please resolve issues then push to the new repo here