Implement 'Edit Link' Functionality in Dashboard

Description
I've noticed that within the dashboard, each link in the table is accompanied by a menu offering several options: opening the link, editing it, or deleting it. However, the option to edit the link currently appears to be inactive and non-functional.
This feature would be incredibly useful for users who need to update or correct their shortened links without having to delete and recreate them. Implementing an active 'Edit Link' option would enhance the application's usability and user experience.
I believe this addition aligns well with the application's goal of providing a convenient and efficient way to manage shortened URLs.
Screenshots

Additional information
No response

@UrielOfir This indeed an important issue.
However I thought we can implement it in the future.
Which fields do you think users need to edit?

change the code of reduced.to after the / and change the target link.

change the code of reduced.to after the / and change the target link.

I think we first need to implement the option to choose a custom key instead of a generating one.

Do you mean that when a user creates a link he will have the option to creat it with an optional link?

Do you mean that when a user creates a link he will have the option to creat it with an optional link?

Exactly! what do you think about it?


Custom field does not work as desired

Description:
We have created a custom field of the type object selection sales channel. If I now create a dynamic product group and select this custom field as a condition, no values are displayed as a selection option. The field is empty and I can enter something, but I would expect a dropdown with all sales channels.
Environment: <IP_ADDRESS> an higher
Create a custom field with an object selection "sales channel".
Then go to a product and enter a sales channel in the custom field area.
Then create a dynamic product group with the condition of the custom field. In the selection at the end of the condition, a selection of the existing sales channels should actually appear so that I can use this as a criterion.
But:

entering the name of the sales channel does not work

Entering the ID of the sales channel does not work either
[Bildschirmfoto%2B2024-07-08%2Bum%2B16.46.00.png|https://sbp-issuetracker-attachments.s3.eu-west-1.amazonaws.com/1720450245_668bfcc59b846_Bildschirmfoto%2B2024-07-08%2Bum%2B16.46.00.png]

[public] Automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-37154.
[created from NEXT-37154, comment 486715]


chore: release main

:robot: I have created a release beep boop
swc: 0.4.28
0.4.28 (2024-12-27)
Bug Fixes

deps: update rust crate serde to v1.0.217 (#1656) (c7ccbf7)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

swc0.4.28
:sunflower:


I CANT CONNECT TO SERVER

MCVersion:1.8.x
System:Windows 11 x64

What settings are you using? Are you connecting to pakkit or directly to the server? (you need to connect to pakkit on localhost)

redesky have a SRV record
but idk pakkit have the SRV connectbility

What settings are you using? Are you connecting to pakkit or directly to the server? (you need to connect to pakkit on localhost)

I‘m connect to localhost

redesky have a SRV record
but idk pakkit have the SRV connectbility

How can i get the real address?

redesky have a SRV record
but idk pakkit have the SRV connectbility

OK,but how can I solve this problem?

redesky have a SRV record
but idk pakkit have the SRV connectbility

OK,but how can I solve this problem?

try to connect rsgg3rmpk7tz362p.ddns.net:25565(the srv record of _minecraft._tcp.redesky.gg)

redesky have a SRV record
but idk pakkit have the SRV connectbility

OK,but how can I solve this problem?

try to connect rsgg3rmpk7tz362p.ddns.net:25565(the srv record of _minecraft._tcp.redesky.gg)

Okkkkkk,thanks! I'll try!

I’ll check if SRV works properly at some point


Documented configuration by environment variable is not implemented

The README indicates a number of configuration options that can be modified using environment variables but looking at the clamd.conf file and the docker-entrypoint.sh script, none of these configuration options is implemented.

Thanks for the PR (#28 ), closing the issue


Associate existing subnet GUIDs when configuring director networks

Ref #558

In my case, when the az configuration is:
az-configuration:
  - name: AZ1
    iaas_configuration_name: default
    clusters:
      - cluster: os-compute-cluster-1
        drs_rule: MUST
        guid: 5a132e367e2a82348a21
        host_group: null
        resource_pool: PKS
      - cluster: os-compute-cluster-1
        drs_rule: MUST
        guid: d59e16f5431b8beeb615
        host_group: null
        resource_pool: PKSWorkerPool
    guid: 54e4cdfc17edc55ae5d

and will meet error when staging back the director configuration:
cc
{"errors":{"base":["Cannot delete the cluster 'os-compute-cluster-1' in the availability zone 'AZ1' of a deployed product","Cannot have multiple clusters with the same guid. Guid: 5a132e367e2a82348a21"]}}
0

This change doesn't work to fix the problem. But I can use this change to simple fix my problem: https://gitlab.eng.vmware.com/PKS/gear2/-/commit/28838ed57a3edf699ea1e619c0bc45d363df00a2, not sure if you guys can open it.

@dtimm @jaristiz FYI ^^

Closing due to age. If this is still needed, please resubmit.
-TAS Operability


how to find angular velocity

I see code use this form to cauculate w
w =angular Velocity in world space
τ = torque in world space
α = angular Acceleration in world space
I = R * local_I * R^-1
τ = I α
w = w + αΔt
(when no τ , then no change of w)
I think this is Because when the object is not deformed, the "local_I" will not change.
But I find that on wiki (L =angular momentum)
L =I w , τ=ΔL/Δt
so if "I" is const, then
τ=ΔL/Δt
τ=Δ(Iw)/Δt
τ=IΔ(w)/Δt
τ= I α
but  "I = R * local_I * R^-1" varies every frame, "I" is not const.
Is this because in one frame,we can considered "I" is const ?
And my question is why not using the form /
ΔL = Δt τ
L = L+ΔL
L = I w
(when no τ, w may be diffrent because of I is not a const)
is this because this form make "w" not change continually ?

I modify some code to test it.  it is too unstable, if using "L = I w"
https://www.youtube.com/watch?v=RbPaBqrYw08

I know the answer of problem one.
In local space "I" is const, so τ= I α is correct.
On the other word, global space I is "R * local_I * R^-1".


Dealing with relationships that own data.

We have some join tables that have fields on them (currently only one) that represents some contextual piece of data.  An example we can use is a favorite_food_list.  The favorite_food_list has many foods, but the join table between those two, call it "favorite_food_list_foods, also retains what order it is on that particular favorite_food_list, so the join table has columns like favorite_food_list_id, food_id and position.
Currently, we have position as a field on foods that is always nil, with the exception of the request where you ask for a single favorite_food_list and include?=foods.  In that case, the position field is populated from the join table.  This limits us in a few ways (can't tell you the position of a food on multiple favorite_food_lists at the same time), not to mention its obviously suboptimal for the client to have to know that this request and this request only populates that field.
I was not able to find any recommendations or parts of the spec that address this case, but if they exist I'm more than happy to be redirected there.
What is the best way to represent these kind of data points w/ our JSON API?
Thank you!

When you are having relationships with their own attributes then the best way consider those relationships as another resource along-with your main resources. In this example you will have 3 jsonapi resources.

favorite_food_list
favorite_food_list_foods ( with its own column id in db table)
foods

'favorite_food_list' will have relation with favorite_food_list_foods and favorite_food_list_foods with foods.
I know it is little different than database concept but this is the exact way to handle this scenario in jsonapi.org 1.0 standard.

Note that you can add a meta member on resource identifier objects inside relationship linkage data.
{
  "data": {
    "type": "foo",
    "id": "bar",
    "relationships": {
      "baz": {
        "data": [{ "type": "baz", "id": "1", "meta": { "rank": 5 }, ...]
      }
    }
  }
}

@beauby This seems like a good option, thanks.  Follow up question:
One thing that I think has added a lot of confusion for us is the difference between the related and self links on a relationship.  I don't think we need something that complex.
Ideally, we can just say

DELETE posts/:id/comments takes resource identifiers for the comments to be deleted
POST posts/:id/comments takes full objects for the comments to be created
GET posts/:id/comments returns those comments.

I would much rather have this kind of interface than having to model join tables as routes.  This also stops us from having to only return identifiers from the POST which forces us to make another request to get what we just created.
We're currently doing it the above way, because we realized too late that that is not how it is supposed to work.  If, to be spec compliant, we have to change, we'd like to find something that involves minimal changes.


Loot - Helmet wear fixed

Resolve #1769
Issue is described here
https://github.com/webaverse/app/issues/1769

Can you dive deeper into why this is the right fix? I understand what it is, some bone is missing. But why is that? Which bone?
https://github.com/webaverse/app/pull/1777/files#diff-fcb2093ac11d9b04a179d3dedbef5c0aae4d14b7f71db90e483becca4170b7ccR1988

https://github.com/webaverse/metaversefile/pull/27


Decide where to move this repo to now that PSG has closed down

Ofcourse, moving the repo would break people's links, which I want to avoid. This issue is advanced notice that this will happen in a few months, at which point this repo will be emptied and replaced with a single README.md pointing to the new location. Is this ok for everyone ? If there are any issues with this plan, please let me know.

Do you have a new location in mind? I guess we should change the default label/annotation prefix. Even if we change the default, we could make it configurable, so people with existing clusters can keep the old one in service.

In preparation for this I added options to support overriding the annotation/label prefix and the Certificate namespace to the #30 'class' branch. So if we move and update the code to a new domain, people with existing clusters can run a backward compatible version by including these options.
-cert-namespace="stable.k8s.psg.io" -tag-prefix="stable.k8s.psg.io/kcm."

Or alternatively you can include your own custom domain and use the improved class label approach with options like:
-cert-namespace="k8s.example.com" -tag-prefix="kcm.k8s.example.com" -class="default"

@luna-duclos If the repo is remaining on github, rather than replacing this one with a README, the 'Transfer ownership' button could be used to create a redirect.
Redirects are more friendly, so if that works, I'd much prefer that.

Would this fit as a Kubernetes Incubator project?
This seems like the sorta thing that would fit there due to how closely related to the Ingress apis it is, and also because over time it would be nice to standardize Certificate TPRs among any other things that need them (e.g. ingress controllers themselves actually).

That's a good question, I'll go over the spec and if it seems a good match, poke some people to see if they also think it's a good idea.

I believe you can transfer a repo without breaking folks' links: https://help.github.com/articles/about-repository-transfers/
(Github automatically proxies when you rename a repo, I suspect it does when you transfer too).
Definitely worth at least suggesting this as an incubator project if it's going to continue to be worked on. Note that there is another project doing ingress certs (https://github.com/jetstack/kube-lego), but that one is tightly coupled to the ingress implementation, unlike this project.
Tim Hockin recently sponsored a networking incubator project (https://github.com/kubernetes-incubator/external-dns), he might be a good person to approach for guidance here -- I'll delay @-mentioning him in case you have someone else you'd prefer to reach out to.

I think moving this to the kubernetes incubator makes more sense than me moving it to my personal github namespace. @paultiplady @euank, who would you two suggest as initial points of contact for this ?

@thockin -- this project provides a simple way to generate LetsEncrypt certs in a k8s cluster, any guidance on whether it would be suitable for an incubator project?
It's complementary to kube-lego as it doesn't assume an Ingress, so it enables TLS-to-the-pod.

Hi Paul!
I have a bunch of questions about this.
Is this abandoned or actively developed?
Can it be folded into kube-lego or vice-versa?
What would be the criteria for "graduation" ?
Does it actually benefit from being in Kubernetes orgs, vs being in a
dedicated org or somewhere else?
We don't have a lot of bandwidth to manage new projects without active
maintainers, and we're sensitive to the incubator becoming a dumping ground
for unmanaged things.
On Mon, Apr 17, 2017 at 9:35 AM, Paul Tiplady<EMAIL_ADDRESS>wrote:

@thockin https://github.com/thockin -- this project provides a simple
way to generate LetsEncrypt certs in a k8s cluster, any guidance on whether
it would be suitable for an incubator project?
It's complementary to kube-lego as it doesn't assume an Ingress, so it
enables TLS-to-the-pod.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PalmStoneGames/kube-cert-manager/issues/33#issuecomment-294523127,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVJD93mTidSK48LhAgubAWipscSgEks5rw5TegaJpZM4Lmizt
.

Hi, Folks,
We are working on providing strong authentication for service to service communication on k8s (https://github.com/istio/auth). And we also planned to cover enduser to service authentication in the near future. Having a system to auto manage certificate is very useful to us. We can share our design doc if you are interested in more details. Happy to chat with you how our work can benefit each other and if your work fits in istio org: https://github.com/istio
Cheers! Wencheng

Hey Tim!
I can vouch for this project being active, @luna-duclos has been very responsive with the couple of issues I've raised recently.
I think this does offer something that would be a useful primitive in the k8s feature-set, and being concerned with encryption key material, is quite sensitive; perhaps there is some benefit to making it somewhat-official in that regard.
I'll defer to Luna on the rest -- in particular folding this into another project could be a good outcome (though I quite like that it's a small component that's easy to reason about).

Kube-lego has a lot of users, and is well regarded, but only does certs for
Ingress (AFAIK).  This does certs for pods, which is really attractive.
I think this is a place where less options, with a more robust feature set
is the right path.
We still. Need to decide if it makes sense to exist in our org(s) but
that's secondary to me.
On a personal note, this scratches an itch I personally have, so I am
interested in it :)
On Apr 20, 2017 11:34 AM, "Paul Tiplady"<EMAIL_ADDRESS>wrote:

Hey Tim!
I can vouch for this project being active, @luna-duclos
https://github.com/luna-duclos has been very responsive with the couple
of issues I've raised recently.
I think this does offer something that would be a useful primitive in the
k8s feature-set, and being concerned with encryption key material, is quite
sensitive; perhaps there is some benefit to making it somewhat-official in
that regard.
I'll defer to Luna on the rest -- in particular folding this into another
project could be a good outcome (though I quite like that it's a small
component that's easy to reason about).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PalmStoneGames/kube-cert-manager/issues/33#issuecomment-295804153,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVNzkC1wsMdZdh3QSqWTG1C-fnRhcks5rx4j5gaJpZM4Lmizt
.

Adding to @thockin - kube-cert-manager also does DNS-based checks, which kube-lego doesn't (or didn't, when I last looked), which is important for certain internal-facing systems.
As for criteria for graduation, a few things are currently lacking. those would be: Automated builds, CI and unit tests. With those done and the currently open PRs merged, I believe this project to be quite mature, stable, and useful.
kube-lego doesn't quite fit the scope of this project very well, as this is, as you've noticed, aimed at TLS for pods as well as ingresses, rather than being aimed at just ingress.
I don't currently have an org for kcm, hence why I think the k8s org might be a good fit.

@wlu2016 thanks for the note! I'll have a look at istio.

@wlu2016 you might be misunderstanding the scope of this project. service<->service communication will likely need an internally trusted and managed ca.
This project is for interacting with lets-encrypt and only currently useful for creating certificates associated with public domain names.

My 2c for @thockin's questions:

Is this abandoned or actively developed?

Actively developed, fairly low velocity.

Can it be folded into kube-lego or vice-versa?

Potentially. From my viewpoint, this into kube-lego might make sense, if only because they have more popularity (at least by github stars).
It's not my call to make though.
I also haven't looked at kube-lego enough to be certain it matches up well. Their codebase looks nice at a glance, and I suppose copying over the TPR and a few other things would effectively fold this in, but it's possible it would be easier said than done and no clue what they'd think about it (cc @simonswine)

What would be the criteria for "graduation" ?

This being deployed as an addon alongside ingress by default probably.

Does it actually benefit from being in Kubernetes orgs, vs being in a dedicated org or somewhere else?

That's a tossup in my mind.
Convergence / discoverability is nice, especially when there's TPRs involved.
The TPRs here are sugar over secrets so it's a little less important, but still worth noting.
I don't think the incubator project has been going long enough to really be certain of the tradeoffs, and I can't find enough ground to stand on in either way to form a strong opinion.

@euank, there are several scenarios we (Istio) need certificate associated with public domain names. For example, end user traffic (from browser and mobile app), ingress, services behind GCLB, etc.

FWIW, @thockin, I've had this in production for a few clients for 3-4 months now.  The DNS verification and TPRs were the essential features for our use cases.
@luna-duclos has been very responsive and there's an active community around here.

Hi @thockin we originally used kube-lego and later switched to kube-cert-manager. Frankly kcm is more capable and a lot easier to deploy and manage that kube-lego (was - it may well have improved since I used it). We use kcm for both DNS challenges (multiple DNS API accounts) and HTTP challenges (for client domains we don't control). I contributed a 'class' label system analogous to the the nginx Ingress Controller 'class' annotation.  Kcm been working great for us in production - it's a no drama service.
The DNS challenges allow us to manage certificates for services that have no Ingress. We can issue certs with kcm for cluster-hosted SMTP and LDAP servers, and for cluster-internal Services that have no Ingress.
Since the addition of support for 'class' labels and ability to issue SAN certificates, we consider kcm feature complete for us. So if incubating, it would be more after refining the code base and adding tests. I looked at kube-lego recently and the only feature I'd like to port from there that kcm is perhaps missing is using an dynamically updated Ingress to route HTTP challenges, without having to touch the Ingress Controller config. Currently I added a global routing for ACME challenge requests to kcm in the Ingress Controllers configs.
A strength of kcm vs kube-lego is that use narrows API watchs by 'class' label as well as namespace(s). This means each kcm instance watches only changes to the Ingress and TPR Certificate resources that instance manages. On a very large cluster you can use a per-project or per-DNS-account kcm instances and not waste time/overhead examining every Ingress/Certificate change. Projects like kube-lego and the Ingress Controllers have a tendency to use annotations and thus every instance of the service processes every Ingress change in the entire, potentially 5000 node, cluster.
Regards automated builds, I set that up for myself using AWS CodeBuild and contributed it (in the codebuild folder). It just need a trigger added. There's a CloudBuild PR incoming. We could also use Travis if that is preferred.
After hyping the project a bit above, my criticism of this project is that it lacks an automated test suite. If incubated I'd like to see tests added with decent code coverage. A bit of mild refactoring wouldn't hurt it either - though the code base is actually very small if you look at it, as the lego library does most the hard work.
@luna-duclos reviewed my PR's in a timely manner plus insisted on documentation updates first, so I'm happy 👍

On Thu, Apr 20, 2017 at 7:31 PM, Aaron Roydhouse
<EMAIL_ADDRESS>wrote:

Hi @thockin we originally used kube-lego and later switched to kube-cert-manager. Frankly kcm is more capable and a lot easier to deploy and manage that kube-lego (was - it may well have improved since I used it). We use kcm for both DNS challenges (multiple DNS API accounts) and HTTP challenges (for client domains we don't control). I contributed a 'class' label system analogous to the the nginx Ingress Controller 'class' annotation. Kcm been working great for us in production - it's a no drama service.
The DNS challenges allow us to manage certificates for services that have no Ingress. We can issue certs with kcm for cluster-hosted SMTP and LDAP servers, and for cluster-internal Services that have no Ingress.
Since the addition of support for 'class' labels and ability to issue SAN certificates, we consider kcm feature complete for us. So if incubating, it would be more after refining the code base and adding tests. I looked at kube-lego recently and the only feature I'd like to port from there that kcm is perhaps missing is using an dynamically updated Ingress to route HTTP challenges, without having to touch the Ingress Controller config. Currently I added a global routing for ACME challenge requests to kcm in the Ingress Controllers configs.

Does this work for Google Cloud LB, for example?

A strength of kcm vs kube-lego is that use narrows API watchs by 'class' label as well as namespace(s). This means each kcm instance watches only changes to the Ingress and TPR Certificate resources that instance manages. On a very large cluster you can use a per-project or per-DNS-account kcm instances and not waste time/overhead examining every Ingress/Certificate change. Projects like kube-lego and the Ingress Controllers have a tendency to use annotations and thus every instance of the service processes every Ingress change in the entire, potentially 5000 node, cluster.
Regards automated builds, I set that up for myself using AWS CodeBuild and contributed it (in the codebuild folder). It just need a trigger added. There's a CloudBuild PR incoming. We could also use Travis if that is preferred.
After hyping the project a bit above, my criticism of this project is that it lacks an automated test suite. If incubated I'd like to see tests added with decent code coverage. A bit of mild refactoring wouldn't hurt it either - though the code base is actually very small if you look at it, as the lego library does most the hard work.
@luna-duclos reviewed my PR's in a timely manner plus insisted on documentation updates first, so I'm happy
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Does this work for Google Cloud LB, for example?

@thockin are you asking if KCM requires an Ingress Controller like kube-lego does, or can KCM also work with LoadBalancers and no Ingress?
No KCM works without an Ingress Controller. Yes, KCM will work fine with Google Cloud LB's.
Firstly you can use DNS challenges, which is the primary method used by KCM and don't require an Ingress or LoadBalancer or any incoming Internet access at all. This is my preferred method.
Second, if you need to use an HTTP challenge, e.g. for a domain name where you don't control the DNS zone, KCM supports LoadBalancers or Ingresses or NodeIPs or HostIPs, the only requirements for HTTP challenges is that:

The certificate target domain name(s) resolve to a public IP (KCM doesn't need to know what that IP is), and
HTTP requests for the '.well-known/acme-challenge' path route to the KCM Service or Pod

(To be fair, even though kubo-lego only officially works with Ingresses, I think you could use a dummy Ingress and route the requests directly to the kube-lego Service or Pod and that would still work.)

OK, Well, I think it's a cool and useful project.  I could endorse it.  I'd
like to see a conversation with kube-lego about whether we could come
together into one community-backed effort, still.
if someone wants to write up an incubator proposal I can sponsor.
On Mon, May 1, 2017 at 8:05 PM, Aaron Roydhouse<EMAIL_ADDRESS>wrote:

Does this work for Google Cloud LB, for example?
@thockin https://github.com/thockin are you asking if KCM requires an
Ingress Controller like kube-lego does, or can KCM also work with
LoadBalancers and no Ingress?
No KCM works without an Ingress Controller. Yes, KCM will work fine with
Google Cloud LB's.
Firstly you can use DNS challenges, which is the primary method used by
KCM and don't require an Ingress or LoadBalancer or any incoming Internet
access at all. This is my preferred method.
Second, if you need to use an HTTP challenge, e.g. for a domain name where
you don't control the DNS zone, KCM supports LoadBalancers or Ingresses or
NodeIPs or HostIPs, the only requirements for HTTP challenges is that:

The certificate target domain name(s) resolve to a public IP (KCM
doesn't need to know what that IP is), and
HTTP requests for the '.well-known/acme-challenge' path route to the
KCM Service or Pod

(To be fair, even though kubo-lego only officially works with Ingresses,
I think you could use a dummy Ingress and route the requests directly to
the kube-lego Service or Pod and that would still work.)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PalmStoneGames/kube-cert-manager/issues/33#issuecomment-298486483,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVLZ-rC_zlLJMrjVNuvd4FykXKthRks5r1p1tgaJpZM4Lmizt
.

Thanks @thockin I would welcome an eventual merged or successor project. My impression is the kube-lego people only concern themselves with tight integration with a single Ingress Controller. So a unified effort depends on their community willingness to make Ingress support as just one feature of a certificate service.
On a maturity basis, you would thing that KCM's features should be ported to kube-lego as they have had more people and time to make a mature product and have much better test coverage. However, on a feature basis, there is only the one Ingress-handling feature to port from kube-lego for KCM entirely cover the kube-lego feature set, then KCM provides a laundry list of other important (IMHO) features and performance benefits on top.
In my view a successor project for both may be better to reformulate the feature set. I feel what is needed is to look at what both projects have achieved as basically mature, and then more on to:

A successor or extension to the Lego library (a key part of both current projects) to support creating/delete A/CNAME records in all the supported DNS providers, rather than just the current support for challenge TXT records. (This would enable k8s deployments to entirely automate DNS+Certificate+Ingress creation from k8s managed resources.)
A clean way to store multiple DNS/cloud provider account credentials in k8s Secrets that can be discovered and used by the certificate service, but also other k8s sevices (this could be an independent single-task service or just a TPR or Secret specification)
A heavily refactored or re-assembled kube-lego+kcm project that supports all ACME challenge types equally well (Definitely DNS and HTTPS+SNI, and maybe HTTP but that could be deprecated at this stage)

@whereisaaron, so after deploying kcm, we immediately ran into the issue how to update dns records. At first I thought the logical next step is to file an issue in xenolf/lego since it only manages TXT records. But after looking around a bit more, Kubernetes incubator already have a project to tackle the dns issue (https://github.com/kubernetes-incubator/external-dns). external-dns is trying to replace several existing projects (kops dns controller/Mate/route53-kubenetes). I would hate to have multiple projects reinvent the wheel over the same issue, and each of them support a different subset of DNS providers.

@nanliu I'm confused. kube-cert-manager can automatically solve the DNS challenges. While I think external-dns is useful (particularly for people doing the HTTP challenge), it seems tangential and well served as a separate project.

@colemickens, to clarify it's not TXT records for solving the DNS challenge, but A records for ingress resources external IP that's the gap. I agree they should be separate projects, but it would be nice to converge  kube-cert-manager, external-dns, and other k8s incubator projects to use the same DNS library. Whether it's extending xenolf/lego beyond TXT records, or some other library, it would be nice to have consistency across all the project. Right now if you aren't using AWS route53/Google CloudDNS, you have to invent your own solution DNS -> external IP for ingress resources after the certificates are created.

@nanliu yes, whether you use kube-lego or kcm, you are currently on your own for the A or CNAME records, since the underlying Lego library only handles creating and deleting TXT challenge records (for an impressive list of providers).
This was my point (1) above about my dream kube-lego/kube-cert-manager evolution including an expanded lego library that could also do A/CNAME records. Using external-dns would be another handle that, except it only covers a couple of providers right now, whereas lego already supports authentication for several dozen providers. external-dns may also not be well suit for challenges, since those TXT records only exist for some seconds during the challenge phases before being deleted again.

@mlaccetti I'm currently taking a break from opensource stuff due to medical stuff, I'll probably get back to writing a proposal in june. If someone else wants to write a proposal, that's also an option.

@luna-duclos sorry to hear that - I'll see if there is a template for the proposal and see if I can get something started.

Hey all, I'm from Jetstack and am interested in discussing a potential move into kubernetes-incubator. From our end, we're happy to see it happen if it's possible in order to drive engagement and hopefully push the project forward to stabilise it.
So far, on our end, we've avoided adding DNS challenge support as we're hoping to see some work around generic DNS management in Kubernetes (to save each project having to implement it's own set of DNS providers). It seems there's some initial work with the external-dns project, although I'm unsure whether that can currently be utilised to create arbitrary records as the ACME protocol requires.
If anyone wants to set up a call to discuss their thoughts too and work out any potential collaboration, let me know! I'll put together a proposal this week so we have something to comment on.
Sorry for the radio silence on our end around this - it's been a very busy few weeks!

@munnerz I would like to add support to KCM for creating the A/CNAME/ALIAS records to go with a certificate (previously issued with a DNS challenge). I too would rather than build it into KCM, have KCM create a k8s resource or label that e.g. external-dns watches for and creates the A/CNAME/ALIAS record for. My bias is I think it is a mistake and a barrier to scaling that external-dns is using annotations, that aren't indexed and can't be filtered or watched for, rather than labels.
Happy to take part in any call.

Hi @munnerz and @whereisaaron - I'd also like to jump onto a call.  I've got a few systems out using KCM, but would I love to see the kube community standardize on a single system that supports both modes (Ingress & TPR).

Have we had a conversation with kube-lego yet?  I'm in favor of moving this
or a derivative of it, to the incubator, but I want to only have one such
project, and not alienate kube-lego users (of which there are a lot) if we
can avoid it.
On Mon, May 22, 2017 at 9:33 AM, Ross Kukulinski<EMAIL_ADDRESS>wrote:

Hi @munnerz https://github.com/munnerz and @whereisaaron
https://github.com/whereisaaron - I'd also like to jump onto a call.
I've got a few systems out using KCM, but would I love to see the kube
community standardize on a single system that supports both modes (Ingress
& TPR).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PalmStoneGames/kube-cert-manager/issues/33#issuecomment-303152475,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVBxsOTwGdAj_y8OGalAL8f7_Z0wtks5r8bjZgaJpZM4Lmizt
.

@thockin not yet - when would be best to discuss? We're all GMT here, but I can poke people and get them on a call too.
This week I am mostly free, except for Thursday. Can we tentatively say 3.30pm UTC on Wednesday (24th)? I'm happy to rearrange if it is more convenient for others.

I have no pref, and I don't need to be there.  I just want communication :)
On Mon, May 22, 2017 at 12:30 PM, James Munnelly<EMAIL_ADDRESS>wrote:

@thockin https://github.com/thockin not yet - when would be best to
discuss? We're all GMT here, but I can poke people and get them on a call
too.
This week I am mostly free, except for Thursday. Can we tentatively say
3.30pm UTC on Wednesday (24th)? I'm happy to rearrange if it is more
convenient for others.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PalmStoneGames/kube-cert-manager/issues/33#issuecomment-303197281,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVPDL60f_leaq0ApSRt-I3jZqQZXRks5r8eJbgaJpZM4Lmizt
.

If people could make their email addresses known, either my posting here or dropping me a message at james [at] jetstack.io, I'll add you to the calendar invite!

ross [at] heptio.com - thanks @munnerz

@munnerz ahmetb at google

luna.duclos at gmail

cc @linki re. external-dns

I've merged all pending PRs that had already been reviewed in preparation of this

Is there a summary of the meeting? I unfortunately missed it and would love to find out what came out of the call.

We've created a merged repo at https://github.com/munnerz/cert-manager, it's a copy of kube-lego to start with, and the KCM codebase will be integrated into it, and from there we can then start cooperative work by submitting PRs

Awesome!  Is that to be a final home, or is the intent to apply for an
incubator repo?
On Tue, May 30, 2017 at 8:47 PM, Luna Duclos<EMAIL_ADDRESS>wrote:

We've created a merged repo at https://github.com/munnerz/cert-manager,
it's a copy of kube-lego to start with, and the KCM codebase will be
integrated into it, and from there we can then start cooperative work by
submitting PRs
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PalmStoneGames/kube-cert-manager/issues/33#issuecomment-305074550,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVBWYTMFrc6eZxmO2hB5B_5XuIvMGks5r_OLugaJpZM4Lmizt
.

The intent is to apply for an incubator repo

Here's a link to the cert-manager proposal:
https://docs.google.com/document/d/1tHKLAauxDnIAEa0csmlYrF8gbQbeJ28SJC7VHVD98OA/edit?ts=5925a631

I am trying to find out if there has been any developmemnt progress in converging kube-lego and KCM lately. I don't see any changes over at https://github.com/munnerz/cert-manager. Is there an execution timeline? @munnerz @luna-duclos

FYI. There is still https://github.com/kelseyhightower/kube-cert-manager which this code is loosely build upon and a new one https://github.com/tazjin/kubernetes-letsencrypt which is relative new. The later looks simple to use for me. All you need is to annotate services and run it. Wonder if it is worth to ping the main devs of those projects to see if they like to join the incubator.

@ahmetb I've pushed up some of my initial work on adding a Certificate resource type into the project. We'll be ramping up development on this over the next few weeks, but in all honesty I've just been very busy with client work!
I'll be dedicating some of my evenings/weekends to this over the coming weeks however, so you should see some more work going on!
For ref., I've put in a WIP PR (with a few open questions) here: https://github.com/munnerz/cert-manager/pull/5 - if you've any insight on these Q's that'd be fantastic!
@ensonic thanks for bringing that second one to my attention! As far as I'm aware, the general consensus on our end is to avoid using annotations on services and instead build a Certificate resource as part of a new API group. @tazjin if you're interested in getting involved with our efforts here, please do!!

@ensonic @munnerz  My kubernetes-letsencrypt is slightly different in that it relies only on DNS challenges and not HTTP challenges.
If there is interest in basing these projects on a new ~TRP~ CRD it'd be cool if we could share that resource definition across multiple projects. I'm planning support for that in my project.

I've been working on cert-manager quite a lot over the last few days, although not on a repo publicly right now (I'll get it opened up on github in the next few days) - I've decided to start again, and have based it heavily on custom resource definitions.
I've got some examples manifests together that I'm keen for people to look over, and have some of the functionality already required. I've heavily focused on flexibility, and am keen to not lock us into just acme as a certificate backend. You can look at the manifests here https://gist.github.com/munnerz/258d3bff69242e86a13a6ea307bbc418
Can I propose we use #kube-lego on the kubernetes slack team for development chat? It'd be good to have a less formal communication channel.

I've updated my own repo with the new code I've been working on -
I managed to issue my first certificate with it yesterday! It's not ready yet, but I'm starting to now open some more specific feature-request issues, and would welcome everyone else to do the same! https://github.com/munnerz/cert-manager
Any feedback on structure etc. would be greatly appreciated!

I've been working a fair bit more on this over the last couple of weeks, and have opened numerous issues against the repo in order to track progress/ask for feedback from the community.
Right now, cert-manager supports HTTP01 challenges for all ingress types (we are no longer tying ourselves to ingress controller implementations) as well as google clouddns and cloudflare dns providers. The DNS provider support comes from 'borrowing' each provider from xenolf/lego, with a couple of small changes to each provider. I have stuck with the golang acme package to implement the lego provider because although the xenolf/lego implementation works very well, it doesn't allow the flexibility that cert-manager requires (eg. it does not expose a mechanism to get an authorization URI so it can be reused).
I'm excited about the potential of cert-manager in the future, as it's no longer tied to ACME at all, and we should hopefully be able to implement additional Issuer types.
It's worth noting that cert-manager is still in a very early state, and is not ready yet! It needs extensive testing, as well as a test suite building up and feedback from early users.
Finally, the repo has moved to be under our jetstack-experimental organisation, although that should be evident as you'll be redirected when visiting mine :smile: https://github.com/jetstack-experimental/cert-manager.

Hello again!
I've been making a lot of progress with cert-manager and now have built out a small e2e test suite, much better logging support (using k8s events), initial support for a plain 'ca' based issuer, ACME HTTP01 and DNS01 challenge support, as well as quite a few other features!
I've got a number of quite core decisions to make over the spec of the Certificate resource (ie. https://github.com/jetstack-experimental/cert-manager/issues/86, https://github.com/jetstack-experimental/cert-manager/issues/85) that I'd like to get a bit more consensus on.
If anyone has any views to add to this, be it just a +1 or a -1, I'd really appreciate your time!
I've created an issue over in the cert-manager repository for the meeting. Provisionally I've said Mon 18th September @ 2pm UTC, however please comment on the issue if this time doesn't work for you and you'd like to attend! https://github.com/jetstack-experimental/cert-manager/issues/89


Update react to version 15.0

Today is the day when first stable version of React is released.
I hope that all popular instruments like this will support the new version soon.

Created PR https://github.com/JedWatson/react-codemirror/pull/43

Merged and published! v0.2.6 is compatible with React ^v15.0.0, thanks for the PR!


Add option to push new schemas and test

This adds an options object to schemas() allowing the user to decide if they want to allow new schemas to be pushed by default or not.

Why would you not want to post the schema to the registry? If you push a schema which is already in the registry then the registry just sends back an id without registering the schema under a new version
In which scenario would you prefer to throw an error instead of registering a new schema/version? If it's something very specific that your producer should only produce a type of message if someone has already done it once then maybe it's something that should be checked in that code.
I am just trying to understand the use case, not 100% against going forward with this.

Agree with @bencebalogh. The way I see it and taking in count the name of this project, it was meant for interacting with Confluent Schema Registry and using the schemas stored there.
If I wouldn't like to store the schema in the registry what's the point of using the library, I would just use an Avro package (avsc)

The big picture is that you might want your schemas to go through a review process before they are registered, especially when the schemas are going to be shared throughout an organization.  For example:
Scenario 1: You are working on a team where schema many services rely on a certain schema. That schema has something other than full compatibility mode enabled. You do something disruptive like adding a new field without a default value. You automatically register the schema and break things for your team.
Scenario 2: You are working at a company with many engineering teams and an analytics team. You want the analytics team to review new schemas before they are registered. Tagging an analyst in a large PR on some codebase he or she has never worked on makes for less timely reviews. The team's solution is to create a schema registry repo where new schemas can be reviewed by themselves. If approved, they are automatically sent to the schema registry for creation by a git action.
The ability to restrict the creation of new schemas is available in other libraries similar to this one (ie, https://github.com/flix-tech/schema-registry-php-client) so it isn't an idea that is totally from left field.

In your scenario:

you open a PR into the schema repo, it gets reviewed and merged
your git hook publishes the schema to the registry
you start using the schema in your app with this library
the library will perfrom a POST with the schema, the registry checks that the schema is already stored there and return its id - the registry won't save a new schema anywhere, the library caches the id and will use that from now on

I think the confusion is caused by pushing an already existing schema into registry: if a schema is already there the registry won't do anything just return the already stored schema's id.
Your scenario's example with the following schema:
{
  "type": "record",
  "name": "User",
  "namespace": "com.example.avro",
  "fields": [
    {
      "name": "id",
      "type": "int"
    },
    {
      "name": "username",
      "type": "string"
    }
  ]
}

I've started a landoop/fast-data-dev container
The git hook registers the new schema under subject users-value:

root@fast-data-dev / $ curl -X POST -H "Content-Type: application/vnd.schemaregistry.v1+json" \
> --data '{"schema": "{\"type\":\"record\",\"name\":\"User\",\"namespace\":\"com.example.avro\",\"fields\":[{\"name\":\"id\",\"type\":\"int\"},{\"name\":\"username\",\"type\":\"string\"}]}"}' \
> http://localhost:8081/subjects/users-value/versions
{"id":1}

Your app, using this library, produces its first message after startup, performing a POST request, for subject users-value:

root@fast-data-dev / $ curl -X POST -H "Content-Type: application/vnd.schemaregistry.v1+json" \
> --data '{"schema": "{\"type\":\"record\",\"name\":\"User\",\"namespace\":\"com.example.avro\",\"fields\":[{\"name\":\"id\",\"type\":\"int\"},{\"name\":\"username\",\"type\":\"string\"}]}"}' \
> http://localhost:8081/subjects/users-value/versions
{"id":1}

Let's say you've got another app, using the same schema with a different topic, called registrations. The library will perform a POST for subject registrations-value this time, but you can see the registry sees it's the same schema and returns the same schema, still does not register a new one:

root@fast-data-dev / $ curl -X POST -H "Content-Type: application/vnd.schemaregistry.v1+json" --data '{"schema": "{\"type\":\"record\",\"name\":\"User\",\"namespace\":\"com.example.avro\",\"fields\":[{\"name\":\"id\",\"type\":\"int\"},{\"name\":\"username\",\"type\":\"string\"}]}"}' http://localhost:8081/subjects/registrations-value/versions
{"id":1}

With the above I don't see why we'd not POST a schema to the registry for the first time after start as if the schema is there it'll be a noop.

closing this until further discussion

@bencebalogh Apologies for the late reply.
You are correct about some confusion I had. I see how the caching works and understand that a new schema won't be posted as your outlined above. However, I think I have slightly misstated our concerns.
We want tight control over what makes it into the schema registry. We want it to be a source of truth for which schemas are actually used or have been used. In the past, using a different registry, we ended up with a bunch of schemas that were registered, not used, and not removed.
Also, if someone is going to add a schema we want to make sure they go through the correct channels. We'd like to avoid a scenario where some new, un-approved, schema is registered. That could cause confusion.

Ah okay, that makes sense.
Wouldn't something like setting up ACLs be better? If someone forgets to set true for this flag it'll still publish a new version, if the app is not meant to.
https://docs.confluent.io/current/confluent-security-plugins/schema-registry/authorization/sracl_authorizer.html


matplotlib 3.6 deprecates pgf.common_texification

tikzplotlib with matplotlib >= 3.6 emits a deprecation warning:
tikzplotlib/_axes.py:12: MatplotlibDeprecationWarning: The common_texification function was deprecated in Matplotlib 3.6 and will be removed two minor releases later.

Hi,
This issue becomes critical because common_texification has been suppressed from matplotlib 3.8. Hence sadly, packages that use tikzplotlib now fail their tests because even just importing tikzplotlib leads to an error, unless if we specify that matplotlib should be <=3.7. :'-(
Thanks for the awesome job on tikzplotlib, by the way!

common_texification basically has been a public wrapper around the private _tex_escape method during the deprecation phase (see https://github.com/matplotlib/matplotlib/commit/336028f4d521a23d9ea2de88b1faf82eddfa5b52#diff-3ceb75d68efae3eba151a1bb856b1ea8467d64abcb0dc725ed3fa2e441e16fcaR96-R126 and https://github.com/matplotlib/matplotlib/blob/a302267d7f0ec4ab05973b984f7b56db21bf524c/lib/matplotlib/backends/backend_pgf.py#L100-L125). I do not know how https://github.com/matplotlib/matplotlib/commit/1936c948476b7d58d10f2c50003a0b9c38f30477 influences tikzplotlib as well.
While there is no solution (which I do not expect in the near future, but evaluating a possible PR should always be possible to support others which face a similar issue), you might want to try monkey-patching the corresponding method with either the old or the new implementation.

Thanks for the answer! For the moment, I just configure my CI to run with matplotlib 3.7 and it works fine.

Is there any plan to address this?

See my previous comment: You might submit a corresponding PR or decide to monkey-patch this for now. Please note that development is more or less stalled at the moment unfortunately, although there have been some notes about possible changes in the future.

Is there a solution, or need to downgrade matplotlib? :(


Memory limit error?

I’ve installed the module using composer on Magento 2.2.6 store but I get this error
$ bin/magento ok:urlrewrites:regenerate
Regenerating of URL rewrites:

----------------------------------------------------
Please, support me on:
https://www.patreon.com/olegkoval
https://api.fondy.eu/s/ghYyR
----------------------------------------------------

[Store ID: 0, Store View code: admin]:

Check https://getcomposer.org/doc/articles/troubleshooting.md#memory-limit-errors for more info on how to handle out of memory errors.

but I’ve assigned 12G and the store has about 8000 products.
$ php -i | grep memory
memory_limit => 12G => 12G
Collecting memory statistics => No

if I check PHP error log I get:
PHP Fatal error:  Allowed memory size of 134217728 bytes exhausted (tried to allocate 1048576 bytes) in /MY_STORE_PATH/vendor/magento/zendframework1/library/Zend/Db/Statement/Pdo.php on line 58
How can I run it?

Hello @teoteo
Please, test a new version of extension (1.4.x).
Best regards,
Oleg Koval

Closed.


useMotiPressable not able to return TextStyle

Is there an existing issue for this?

[X] I have searched the existing issues

Do you want this issue prioritized?

[ ] Yes, I have sponsored
[X] Not urgent

Current Behavior
When using the useMotiPressable, I tried changing the color value of a MotiText based on the pressed state like this:
import React from "react";
import { MotiText, MotiView } from "moti";
import { MotiPressable, useMotiPressable } from "moti/interactions";

const Item = () => {
  const state = useMotiPressable(({ pressed }) => {
    "worklet";

    return {
      color: pressed ? "red" : "blue",
    };
  });

  return (
    <MotiView>
      <MotiText state={state}>Click me!</MotiText>
    </MotiView>
  );
};

export const Button = () => {
  return (
    <MotiPressable>
      <Item />
    </MotiPressable>
  );
};

and I face the following TS error
No overload matches this call.
  Overload 1 of 2, '(factory: MotiPressableInteractionProp, maybeDeps?: unknown[]): Pick<UseAnimationState<any>, "__state">', gave the following error.
    Argument of type '({ pressed }: MotiPressableInteractionState) => { color: string; }' is not assignable to parameter of type 'MotiPressableInteractionProp'.
      Type '{ color: string; }' is not assignable to type 'NonNullable<AnimateProp>'.
  Overload 2 of 2, '(id: string, factory: MotiPressableInteractionProp, maybeDeps?: unknown[]): Pick<UseAnimationState<any>, "__state">', gave the following **error.**
    Argument of type '({ pressed }: MotiPressableInteractionState) => { color: string; }' is not assignable to parameter of type 'string'.ts(2769)

The code works, the color is changed when it is pressed, but the TS error still persists. So the question here is:

Is there a reason for AnimateProp to be  MotiAnimationProp<ViewStyle> instead of MotiAnimationProp<ViewStyle & TextStyle>?

For now I will be patching the package to get rid f the TS error, but  I do not know the full repercussions os changing this (and if it is even intended)
Expected Behavior
The type should be changed to allow TextStyles to be updated as well
Steps To Reproduce

Try this

import React from "react";
import { MotiText, MotiView } from "moti";
import { MotiPressable, useMotiPressable } from "moti/interactions";

const Item = () => {
  const state = useMotiPressable(({ pressed }) => {
    "worklet";

    return {
      color: pressed ? "red" : "blue",
    };
  });

  return (
    <MotiView>
      <MotiText state={state}>Click me!</MotiText>
    </MotiView>
  );
};

export const Button = () => {
  return (
    <MotiPressable>
      <Item />
    </MotiPressable>
  );
};

See the TS error

Versions
- Moti: 0.29.0
- Reanimated: 3.10.1
- React Native: 0.74.5

Screenshots
No response
Reproduction
import React from "react";
import { MotiText, MotiView } from "moti";
import { MotiPressable, useMotiPressable } from "moti/interactions";

const Item = () => {
  const state = useMotiPressable(({ pressed }) => {
    "worklet";

    return {
      color: pressed ? "red" : "blue",
    };
  });

  return (
    <MotiView>
      <MotiText state={state}>Click me!</MotiText>
    </MotiView>
  );
};

export const Button = () => {
  return (
    <MotiPressable>
      <Item />
    </MotiPressable>
  );
};

Interesting...will take a look


[stable/fluent-bit]: Track tail offsets across restarts

This enables the DB feature of the input for docker logs and will
persist the offsets of tracked files, allowing the plugin to pick
up where it left the file across restarts.
@kfox1111 @edsiper

/ok-to-test

/lgtm

Rebased onto master

@unguiculus How can we proceed here?

/lgtm


Telegram get api

add some get api in telegram package

Table of Contents of packages/messaging-api-telegram/README.md should also be updated.


history-substring-search: bind arrows in both vi and emacs keymaps

This binds the arrow keys in both the emacs and viins keymaps so up arrow will "work" in both emacs and vi mode, and regardless of whether the vi-mode plugin is loaded before or after this.
Partially fixes #2735
Note that the arrow keys still won't work in vi mode if the vi-mode plugin is loaded until #4191 is also merged, because the widgets in vi-mode are preventing terminfo mappings from working.

The following bindkeys seem to work for me. As seen here. https://github.com/sorin-ionescu/prezto/issues/516
bindkey '^[[A' history-substring-search-up
bindkey '^[[B' history-substring-search-down

Closing in favor of #4193 since #4190 made it in.


feat: added authentication

This PR contains the following-

added login, sign up pages
login and signup service handlers to post to backend
routes
protected routes

Code looks clean and self-explanatory. GTG!

Thank you for your review.

Code looks clean and well structured
UI looks clean
Good Work !

Thank you for your review.


Variable Length Support for cuDNN RNN

We want to add support for variable-length sequences to the cuDNN RNN operator, as we cannot 'fake' support via masking for LSTM (the cuDNN operator does not return a history of cell states) and bidirectional RNNs. Also, there should be some speedups for batches of sequences of very different lengths (can avoid bucketing).
The annoying part is that cuDNN requires that the sequences be sorted by sequence length, and also packed as a contiguous block of memory. PyTorch deals with this by introducing a pack_padded_sequence operator, which returns a PackedSequence object that the user can feed to cuDNN RNN. MXNet probably (?) doesn't want to take this route, and hide these details from the user (other backends eg upcoming MKL for symbol.rnn might anyways not require this) and just pack/unpack inside symbol.RNN. So some questions:

is any work being done on this already? (so I don't duplicate)
@DickJC123: what is the best way of doing the sorted packing/unpacking efficiently? Are there any plans to add this utility function to cuDNN?

@sxjscience, @piiswrong, @szha

Any comments on this?

Awesome initiative @sbodenstein
Bumping again to @piiswrong
@sandeep-krishnamurthy please label:

RNN
Feature

I don't think any one is working on this. This can be added as an option of sym.RNN. when use_mask=True, RNN can take an extra argument.
ping @DickJC123 again

I've been remiss at commenting because frankly new cuDNN features are generally advertised only upon general availability.  The cuDNN team is continually improving the feature set, and it's clear to us that sorting and packing of sequences is a customer pain point.  As such, we are working on feature improvements in this area for one of our future releases.  I'll point out that cudNN v7.1 is newly available for download, although this minor release has no new features to address variable-length sequences.  If there's more detail you are able to share about your application, whether publicly or privately, that would be very helpful.

So it seems as though we should wait a little bit before jumping in to add support. It seems as though Intel will have their RNN operator ready this month as well, so it might be a good time to revisit this then.

Any progress on this?

The newly released cuDNN v7.2 (https://developer.nvidia.com/cudnn) now supports more RNN cell use cases with options for cell clipping and padding masks.  Thanks for your patience on this, and feel free to comment on whether the new API meets your needs.

Awesome new set of features! They can be found in https://docs.nvidia.com/deeplearning/sdk/cudnn-developer-guide/index.html#features-of-rnn-functions. Since the changes will likely require API changes in RNN op, I took the liberty to repurpose @sbodenstein 's issue for the API discussion.
Desirable new features would be:

Allow packed sequence data or padding handling for variable length sequences.
Support LSTM-projection for large-scale RNNs.
RNN state clipping.

Desirable performance improvements would be:

Allow down conversion to enable HMMA when possible.
Allow algorithm search for performance tuning through findIntensity.
Reuse the space for random states when dropout is enabled.

Unclear:

What's the recommendation for _ALGO_PERSIST_*? @DickJC123 @ptrendx

Pinging @pengzhao-intel, @Sherry-Zhang @lihaofd @TaoLv

Just see the message :(  The variable length RNNin CPU side is scheduled to implement in our Q4.
@ciyongch

@pengzhao-intel: thanks! Thats useful for us to know.

@DickJC123 @ptrendx I think the new features are very useful, since we are working on large scale NLP models, where most of the models are based on RNN cells. For example, we need cell state clipping and projection clipping to make the models overcome the possible overfitting. Similarly, it would be very helpful if we can have projection in the RNN cell, in that way, we can improve the memory size to significantly improve the model capacity. So, looking forward to the new features in cuDNN v7.2 to be in MXNet.
@pengzhao-intel Also looking forward to CPU support! Thanks.

@haojin2 is driving the addition of the options for LSTM projection and rnn state clipping in #12541.

@szha, @DickJC123: TensorCore support for RNNs is currently disabled. We would really like to make use of this for training large RNN models.
Are there any plans to add support for it soon?
Also: what about a flag cudnn_use_tensorcores (similar to cudnn flags in convolution). When true, it will use tensorcores even with float32 (and handle internal downcasting or use new cudnnSetRNNMatrixMathType(cudnnRnnDesc, CUDNN_TENSOR_OP_MATH_ALLOW_CONVERSION)). If its None, it will use standard heuristics (environment variable + check for float16).

I'm not sure about adding the flag as part of the operator arguments, because this option is not meaningful to other implementation. I think instead we can have it as an environment variable similar to other performance-related features.

We definitely want to add this support, though we are currently a bit short-handed. A patch is most certainly welcome.

@szha: I'm happy to make a PR. One question about the behaviour: the flag MXNET_CUDA_ALLOW_TENSOR_CORE is set to true by default. Its behaviour is:

Only use TensorCores if DType is float16 and MXNET_CUDA_ALLOW_TENSOR_CORE is true. Presumably, the use of TensorCores will never worsen float16 training, so defaulting to TensorCore use seems reasonable.
But if DType is float32, then we can't assume the user wants to use TensorCores. But they do want a way of opting-in (and setting CUDNN_TENSOR_OP_MATH_ALLOW_CONVERSION when available).

So how about an environment variable MXNET_CUDA_TENSOR_OP_MATH_ALLOW_CONVERSION, which defaults to false, and if true, will let float32 or float64 nets use TensorCores by implicit downcasting?

Yes, I agree that the new variable is necessary. This matches the "_ALLOW_CONVERSION" flags in the cudnn interface.


Read NE columns off of CoNLL-style files

It'd be nice to be able to read the ne columns off of CoNLL-style NER files without using the raw()
method.
I've attached a patch that allows this by allowing more than word/tag/IOB columns to be returned
from iob_sents() and iob_words().
E.g. c.iob_words(None, (c.WORDS, c.POS, c.CHUNK, c.NE)) would now return [...,('Electric', 'NNP', 'I-
NP', 'I-ORG'),...] but c.iob_words() returns  [...,('Electric', 'NNP', 'I-NP'),...] as before.Migrated from http://code.google.com/p/nltk/issues/detail?id=338

There's an answer from @alexis on https://stackoverflow.com/a/46875652/610569


Issue on Windows 10

I received a message that says "perlego-downloader-main\downloader.py", line 2, in  from PIL import Image ModuleNotFoundError: No module named 'PIL'". I'm not sure which step did I do wrong.

Hello, do you have installed the Python requirements with pip3 install -r requirements.txt?

Yes, it has successfully installed the entire list. Somehow the error starts at line 2. What module is that? Maybe I can reinstall that part.

Try pip install pillow

I suppose this issue has been fixed installing the right dependences. I'm closing this issue, feel free to reopen it


Resolving relative URLs

How should a client resolve relative URLs in links and actions?

Relative to the URL from which the resource was requested?

Relative to the innermost parent "self" link?

Should they be forbidden (or at least discouraged - which is what the version 2 spec says)?

The client should absolutely resolve relative URLs and absolute path URLs.  I'm always surprised that this is not considered a best practice in APIs.  There is a very good reason to have relative URLs and absolute path URLs and there are RFCs that define how they should be resolved.  So there is no ambiguity except to specify a base URL.  I would say relative to the requested resource.  Although it would be nice to have some kind of meta data (as with HTML) to specify/override this.

See https://groups.google.com/forum/#!topic/hal-discuss/t1xld7fsYyM for a discussion in the HAL forum.


Update harbour-file-browser.desktop

Added finnish translation for desktop

Thanks. I don't know how to translate the app name in Jolla Store. Would it be a bit confusing to have the name "File Browser" in the Store and once the user has installed it, it would appear as "Tiedostoselain" in the app grid?
Can you find an example of an app which is in the Store and has a translated name? Or can you point to instructions how to translate the app name in the Store?

Atleast Jollas own apps are translated, "Clock" -> "Kello" etc in Store too.. Other than that, I have no idea. Maybe it's better to ask from Jolla/dev-care or something.

Ok. Let's try if it works.
I won't be updating the Jolla Store version soon, because I just submitted an update to there few weeks ago. So, it may take a while before this change is visible there.


Add Undo Close Tab option in tabs context menu

Closes #27851.
Allows re-opening scenes from the tabs context menu starting from the most recently closed.

I wasn't sure if a keyboard shortcut was necessary for this (something like CTRL+MAJ+T, maybe). I reused the previous_scenes list used by the prev_scene button that is always hidden (leftover code?), but even if it used again this pr don't break its behavior. If it isn't necessary anymore I can remove it.

I wasn't sure if a keyboard shortcut was necessary for this (something like CTRL+MAJ+T, maybe)
I'd really like to see a Ctrl + Shift + T shortcut for this :slightly_smiling_face:

I'll add it, I totally forgot the Maj key in French was Shift in English ^^

Would be cool to have this for scripts too.

Would be cool to have this for scripts too. (and it was also requested in the linked issue)

I saw that the script editor already had Ctrl + Shift + T for Open Recent and wrongly thought it would be similar, but it seems to be opening the first script in the recent script list. I'll take a look at it too.

I saw that the script editor already had Ctrl + Shift + T for Open Recent and wrongly thought it would be similar, but it seems to be opening the first script in the recent script list. I'll take a look at it too.

I guess you can remove that shortcut to avoid the conflict

I think that Reopen closed tabis a better name than Undo close tab.

Screenshot from google chrome

On the other hand, Firefox 66 uses Undo Close Tab:

I'm fine with either, just make sure to use the same capitalization as the rest of Godot (which is Like This).

I'm not totally sure how this plays together with the undo/redo support.

As of now it doesn't register any action into undo/redo. (But if I'm not mistaken, it is the same for all opening/closing scene related actions?)

Code seems fine overall, but I wonder what impact this will have on editor resource usage.  How would it behave e.g. on https://github.com/KOBUGE-Games/jetpaca which has big TileMaps in its level scenes, once such scenes have been opened and closed?

Unless I didn't understand what you were referring to, with these changes only the path to the closed scenes are stored, the scene themselves are still closed the same way the were.

Thanks!


Firewall/Aliases - model whereUsed test doesn't take aliases in consideration

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
When an alias is used inside another alias, the whereUsed() method of the alias won't return it, in which case people can remove an alias which is still being referenced inside another alias.
To Reproduce
create two aliases, reference the first inside the second and try to delete the first.
Expected behavior
It should prevent deletion as it would do when aliases are used in firewall rules for example.
Describe alternatives you considered
none
Environment
OPNsense 21.7.3 (amd64, OpenSSL).

seemed to be an issue with my test setup.


[question] how to create crossfade transition

When switching views, I'd like to fadeOut the old page/fadeIn the new page at the same time.
Are there any examples somewhere? There's a lot of documentation around about transitions but I haven't found anything specifically on cross fading.

Hi, thanks for filing this issue, however the issue tracker is reserved for bug reports and feature requests only, please use  gitter or forum or stackoverflowto ask questions. Thanks!

Simply define a crossfade transition and use it with router-view:
<transition name="crossfade">
  <router-view></router-view>
</transition>

Did you achieved it? I don't like I can't mix two routes view to crossfade smoothly, instead I'm getting view A fade to opacity 0, and then view B opacity to 1, but it's not crossfade, it's fade to white and then fade from white.

Simply define a crossfade transition and use it with router-view:

I'm confused by this answer, and it getting thumbs up. Is there an actual "crossfade" feature in vue-router (I find no evidence of it)... or is the suggestion to simply name a custom animation as "crossfade" and pretend that it's cross-fading ?


broker.conf documentation : wrong tokenSecretKey base64 inline description

On the website the documentation to pass a token in base64 mention to use
tokenSecretKey=data:;base64,******
However I could not have it working using (without the semicolon)
tokenSecretKey=data:base64,******
I am using the broker version 2.6.3
Context (not sure important) :

On openjdk 11.0.10
I also use two authentication mechanisms
authenticationProviders=org.apache.pulsar.broker.authentication.AuthenticationProviderTls,org.apache.pulsar.broker.authentication.AuthenticationProviderToken

This has been discussed here https://github.com/apache/pulsar/issues/6761 but led to the opposite observation.

Hi @daniel-bartz have you tried tokenSecretKey=data:;base64,******? (with the semicolon)

@Anonymitaet Yes, I tried it and it did not work for me with the semicolon.


Provide more detail in ERROR: Request not authorized email/message

Occasionally we're getting this email message ERROR: Request not authorized
Prior to the 2.8.0 release this was ERROR: Could not find saml_user value. This was changed when djangosaml was upgraded.
This message indicates someone doesn't have access to Student Explorer and not in the group from #121. However the email doesn't indicate who doesn't have authorization, this information can be looked up from the logs. It would be useful to include this in the email message and maybe even make it less of a stack dump and more of an informational message.

Were you also thinking this would include a better message for the user?


Storage of credentials

Hello!  Two questions:
Where are the credentials stored, and how are they stored (plain text??)  Is there a way we can use our tokens instead so we do not have have credentials stored off on a networked machine?  I see in issue #282 there is a way to enter tokens but unsure how to get into the table to enter them, any help on how to do that?
Where is the data stored?  I would like to be able to make backups since this is all stored on an SD card in my case, and not a high endurance one :)  I have been able to get into the docker and browse the filesystem within but unsure where the data is actually stored.
Thank you

Your username and password are not stored, they are only used to get the tokens. The tokens are stored in the tokens table in the database.
How to backup the database is documented in the docs here:
https://teslamate.readthedocs.io/en/latest/maintenance/backup_restore.html

Thank you!


Add backward compatibility to Python 3.6 (or earlier)

Right now the typing hints make this package incompatible with Python <3.9. Adding old-style typing hints will promote backward compatibility.

Addressed in b15a4d530ed7bad3dae4fbda76a323744ce314bb


Allow code-folding for selected text in editor

This is a small addition to the code folding extension that makes any selected text in the editor foldable (provided the number of lines selected is more than the minimum fold size set in the preference).
The feature can be enabled by setting the preference value "code-folding.makeSelectionFoldable": true
cc @abose

@thehogfather Wow! That was quick. Thanks for this PR!.

Thanks @thehogfather for the PR.

BTW this is still a work in progress. Amongst other things, I need to sort out issues around restoring folds based on selections. Shall update in the next few days. Case 2 below is  of particular interest:

User selects text, folds it, closes the file. When user reopens the file (without modification) the folded selected text region is restored.
User selects text, folds it, closes the file. File is modified outside the context of brackets (e.g., git). User opens the file. What is a reasonable expectation here?

@thehogfather I have added a review only tag to the title of the PR, please remove it when you feel this pr is ready to be merged!

@thehogfather I wrestled with a case similar to 2. with my brackets-persistent-history extension, where I wanted to persist the editing history between project changes and outside changes. My original idea was to invalidate the editing history on the changed part by diffing the files (similar to how you could invalidate / uncollapse changed lines) but in the end I went for a simpler solution where I add another history-step to compensate between the state in the cache and the new changes from outside of Brackets.
However the case here is slightly different so it's hard to say what the reasonable expectation would be: overall I wouldn't want Brackets to uncollapse any folds unless absolutely necessary (ie. the folded content has been modified in a way that it doesn't exist (start/end has been removed/modified) anymore), but then again how would you notice that something has changed inside a collapsed fold? One idea would be showing the change in the collapse marker but that's kinda out there too.

@petetnt quite!
The case here is also interesting because there really isn't a way to "validate" selection-based folds - any selection is valid - unlike how modifications to a file can render brace-based folds invalid. At the moment what the extension does is to use the starting line of each collapsed region to calculate the 'intended' collapsed region when the file is reopened. If the file has not changed then there is no problem. If the file has changed, then the fold might be invalidated if the start and end lines of the new and cached ranges don't match.
For now I've kept it simple. Selection folds will be restored if and only if they exist in the saved fold preferences and are reported as selection by the ViewStateManager.
It might be worth thinking about rendering selection folds ever-so-slightly differently from other types of folds in the gutter.

@abose I think this is ready to merge.

@abose I think we should target this for 1.5

It working well in all cases i tested. External modification is always a grey area, But no data is getting corrupted / opening up the folds on external modification seeems to be reasonable- which is how it is working now mostly.
All unit/integration/main view tests Passing.
Thanks for this feature @thehogfather :+1:
Merging.

Im really happy about this new feature in version 1.5.
But could one tell me if there is a possibility to safe this options?
If i restart my brackets, my html files are folded out and i have to manually fold in the stuff i dont want to see again.
There is some content i dont have to see anymore and it would be more clearly if they are folded in.
Greetings Maetzzen

Could someone tell me if the collapsed text is correctly iconified on my image (that ugly crossed square)?

@ezequias that is correct and would be and issue to raise with the theming provider you are using. @Maetzzen the fold states should persist when you close and reopen brackets. Can you report what operating system you are running?

My bracket runs on Windows 8.0

Thanks @thehogfather It's Monokai dark soda.

@Maetzzen can you confirm if there is any difference if you select a different file in your workspace before closing brackets. So fold some regions in your html file as you did before then switch to a different file and then close and reopen brackets.
Now check if the folds in your html file are restored or not.

@thehogfather
It doesnt matter which kind of file i select.
The files and their segments are minimized as long i keep the brackets opened.
But whenever i close and reopen brackets the segments arent minimized anymore.
In my html element i have a lot of content safed in different tables. And i minimize them to keep an overview but if i reopen brackets the adjustment is resetted. I hope you understand what i mean ^_^'

Yeah I understand. But I have a theory about why you are experiencing the issue. To disprove or support my theory your project needs to have multiple files. And you need to change the active editor after you've folded a code region. Hence why I asked that you select a different file (before closing brackets and after folding some regions in an intended file).
I could reproduce the issue only if I opened brackets, worked on only a single file and then closed brackets. Hope you understand what I'm trying to say.

@ezequias' issue is reported here: rainje/Monokai-Dark-Soda/issues/6, there's a suggested workaround mentioned too.

btw @Maetzzen this issue is related to #11775 so perhaps lets carry on discussions there.
Cheers

Thanks @petetnt but I didn't find the monokai main.css but only monokai.css and it does not have the mentioned text.

@ezequias Did you update the theme to 1.0.9 ? It should be fixed. Tell me if it isn't.

@rainje yes. Now looks better but I would use a minus sign with the same color of the plus sign to make it perfect. Anyway now is way better than before. Thanks for caring about me.

@thehogfather for later verisons please consider a "fold all other" / "focus mode" option , it's great when writing blogs or similar stuff