Auth-with-Ionic3-Angular4.md

Facebook Authentication with Angular4-Ionic3 and AngularFire2

Checklist

Issue number for this PR: #914
Docs included?: Yes
Test units included?: N/A
e2e tests included?:N/A
In a clean directory, npm install, npm run build, and npm test run successfully? N/A

Description

Authentication tutorial with Ionic 3 and Angular 4
Code sample

I suggest mentioning in the top that the auth example is for Facebook.

The Ionic auth service example (auth-service.ts) still contains a lot of errors:

platform is missing in constructor
afAuth.subscribe should be: afAuth.authState.subscribe
this.afAuth.signOut() should be: this.afAuth.auth.signOut();
FirebaseAuthState is deprecated: firebase.Promise

I did not check the other example code yet, but I suggest you test all the code in a fresh Ionic 3 starter.

Hi,
Your comments are referring to Auth-With-Ionic2 document, but you've
added your comments in this new PR, which refers to
Auth-With-Ionic3-Angular4 document.
There is no auth-service.ts in this article, as I wanted to keep this
article simple focusing on Angular4 and Ionic3 changes.
Please try going thru the entire document and follow steps. It should work
absolutely fine. let me know, if you face any specific issues.
On Wed, May 3, 2017 at 11:09 AM, Sybrand Hoeksma<EMAIL_ADDRESS>wrote:

The Ionic auth service example (auth-service.ts) still contains a lot of
errors:

platform is missing in constructor
afAuth.subscribe should be: afAuth.authState.subscribe
this.afAuth.signOut() should be: this.afAuth.auth.signOut();
FirebaseAuthState is deprecated: firebase.Promise

I did not check the other example code yet, but I suggest you test all the
code in a fresh Ionic 3 starter.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/angular/angularfire2/pull/917#issuecomment-298871197,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABzFLAUmXA1rwVm-2yKQKs3-OUcAwE6nks5r2FJGgaJpZM4NFfpC
.

--
Best,
Mukesh

@thegreat7 Thanks for taking the time to do feedback on this PR! However, let's try to be positive in our reviews in avoid negative symbols such as your thumbs down emoji. It would be great to see something like "Hey, great work so far. I noticed there are two missing return statements on lines 598 and 604."
It is important to provide feedback while being encouraging.

Hi @davideast :- The application is running as expected in both the browser
as well as mobile phone. The idea of writing this tutorial on similar lines
to Auth-with-Ionic-2, was to maintain the uniformity. Although I didn't
create a Auth service in this tutorial, since the focus was to showcase
Ionic3 with Angular4.
@thegreat7 :- Seems like you've followed the Auth-with-Ionic2 tutorial and
you see a return type there and you immediately compared it with this
tutorial.May I request you to run the tutorial and let me know, if you see
any issues with running the app in either browser or mobile. I'll anyway
make changes to retain uniformity.
You can also refer to sample at this location.
https://firebase.google.com/docs/reference/js/firebase.auth.FacebookAuthProvider
On Mon, May 8, 2017 at 6:58 PM, David East<EMAIL_ADDRESS>wrote:

@thegreat7 https://github.com/thegreat7 Thanks for taking the time to
do feedback on this PR! However, let's try to be positive in our reviews in
avoid negative symbols such as your thumbs down emoji. It would be great to
see something like "Hey, great work so far. I noticed there are two missing
return statements on lines 598 and 604."
It is important to provide feedback while being encouraging.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/angular/angularfire2/pull/917#issuecomment-299941851,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABzFLNewuz1kFysBfdKffA8mVmoTS49jks5r31fcgaJpZM4NFfpC
.

--
Best,
Mukesh

@davideast Done with all changes. Waiting for your review.
@katowulf FYI

🚀🚀🚀


[BE] get blogs API endpoint

Resolved at https://github.com/Hack-Weekly/tangerine-moose-blog/pull/52


How can I use Rollbar's ErrorBoundary with React Router's ErrorBoundary?

I want to catch the error from the route with createBrowserRouter's ErrorBoundary but I also want log or track it using Rollbar. When there are errors in our app, react router's error boundary catches it but it doesn't go up to Rollbar's error boundary.

I didn't use the ErrorBoundary provided by rollbar. Instead, I did this https://docs.rollbar.com/docs/react#instance-usage then catch/log the errors using rollbar.error()


Fixed a wayward 'tick' that was causing sprocket errors during asset pipeline compilation in Rails.

The key update is Line 114
The other changes are just dead space cleanup which happens automatically in my editor. :smile:

Thanks

Thank YOU for the great library.  I'm glad I could help out. :-)


[event-hubs] receiver redirect

This is a prototype for supporting receiver redirect in Event Hubs.
This requires allowing a single client to manage multiple connections. The EventHubClientManager was added to support this. The goal was to make it API compatible with EventHubClient so that the two could eventually be merged.
Background
Event Hubs supports amqp redirect on receiver links. When the amqp:link:redirect desired capability is added to the amqp receiver link the service will send a LinkRedirectError when the receiver link is created.
The LinkRedirectError contains the hostname, port, and address that should be used for creating a new connection/link to the service.
It's important to keep in mind that traditionally, a single connection managed multiple receiver links. However, it is possible (likely?) that different receiver links on the same connection will be given different redirect info in their respective LinkRedirectErrors. In this case, a new connection will need to be made for each hostname/port/address trio.
Implementation
TL;DR
The EventHubClientManager has a core connection, and creates additional connections mapped to a partition id as needed (determined by LinkRedirectErrors).
Walkthrough Example

User creates a client with redirect enabled.
User calls client.subscribe to start receiving events.
The subscription asks for partition ids.

The EventHubClientManager (used under the hood) creates a core connection based on the initial info passed to the EventHubConsumerClient.
core connection is used to get partition ids.

The subscription creates a receiver.
The receiver attempts to receive messages

core connection is used to create receiver link.
receiver link gets a LinkRedirectError.
receiver asks EventHubClientManager for a new connection given details in the LinkRedirectError.
receiver link is created from the new connection
receiver starts receiving messages

Multi-connection support
A customer should be able to use a single EventHubConsumerClient with redirect enabled. This necessitates changing the 1 client = 1 connection to allowing 1 client = many connections.
The EventHubClientManager handles managing multiple connections. It contains one core connection that is responsible for calling $management calls for getting partitionIds. The core connection is also used to create a receiver link if an existing connection doesn't already exist for the partition the receiver link is being created for.
When a LinkRedirectError is encountered, the underlying receiver gets a new connection from the EventHubClientManager and creates a receiver link again.
Auth changes
When creating the cbs connection and negotiating the claim, the name in applicationProperties should be the address returned by the LinkRedirectError. This will look different than the address typically used without receiver redirect.
TODO

[ ] Retry instantly when encountering a LinkRedirectError rather than apply the retry delay.
[ ] Ensure redirect feature is documented to explain that multiple connections are used.
[ ] Ensure redirect feature calls out that additional ports may need to be allowed in firewall rules.
[ ] Ensure all connections are closed when closing the client.
[ ] Ensure force:closed errors cause a new redirect to occur.

Can we close this in favor of #10178?

Yes we can!


Cannot run cellpose in ImageJ (Fiji)

Hi
I am trying to run the cellpose wrapper within ImageJ but get an error returned. I have attached pictures of the error code and the packages installed within the cellpose environment. Any advice as to overcome this would be appreciated

it looks like this is the wrapper you are using: https://github.com/BIOP/ijl-utilities-wrappers
please post the issue there.
but it looks like they don't support cellpose 2, so you could try pip uninstall cellpose then pip install cellpose==1.0.2


Will you release more environments?

Dear researchers,
Thanks so much for your hard work. I can imagine the huge engineering efforts required here.
May I ask if there are any plans to replicate more environments?

Currently there are some efforts to build more environments like the Track 2 of ICML-MFM-EAI challenge (https://icml-mfm-eai.github.io/challenges/#TRACK2) which will use real-to-sim environments based on ManiSkill3 for evaluation; for our environments @StoneT2000 is migrating them to ManiSkill3 first so it will take a while.


Poor performance when handling huge isolate-v8.log file

For some reason, with the dexnode I end up with an isolate-v8.log file at the size of 232 MiB.
$ ls -lah isolate-0x150008000-91458-v8.log
-rw-r--r--@ 1 sukka  staff   232M Jul 23 18:24 isolate-0x150008000-91458-v8.log

And I am stuck at this for 8 minutes, yet it is still loading:

@rbuckton Hello?

NodeJS/v8 will continue writing to the isolate log until the process exits, which can result in very large files and can take a long time to process. Unfortunately, I do not have a solution for this at the moment, so your best option is to try to isolate the scenario you are investigating as much as possible so as to reduce the size of the log file.

to reduce the size of the log file

I am profiling my script, the process only runs for 10 seconds, yet it produces 200 MiB of v8 log.
Does it have something to do with the Node.js module register? I am using dexnode -r @swc-node/register to profile my script.


Install script for indi_pylibcamera

This script creates file indi_pylibcamera.xml in /usr/share/indi to get listed in EKOS profile editor. Secondly it creates soft link in /usr/bin/indi_pylibcamera so that it can be used by other applications like INDI WebManager. It requires sudo premissions.
Usage: install.sh /indy_pylibcamera.py"

Many thanks!!!

@sajmons
I am working on an install package and tried the driver XML for the first time.
On my Raspberry Pi I have KStars 3.4.3. For any reason the driver does not get listed there in the ECOS profile editor. I can only see devices from /usr/share/kstars/indidrivers.xml. It seems that KStars/ECOS does not search in /usr/share/indi.
On my laptop I have KStars 3.6.5. When I copy the indi_pylibcamera.xml to /usr/share/indi I can see the drivers in "Others". But of course the driver can not run on my laptop.
Likely I need a newer KStars on my Raspberry Pi. Unfortunately the package repository of Raspian Bullseye has only the old version.
How have you got it working? Which version of KStars do you use?


TIS con Jetson Nano

Dear TIS,
I got a DFK 33UX273 camera connected by usb to a jetson nano.
I've been trying to use it with the jetson https://github.com/dusty-nv/jetson-inference that uses v4l2 for the camera but I can't seem to make it work. I took a look at https://github.com/TheImagingSource/nvidia-jetson-samples but they seem to work only with MIPI cameras.
Do you have any advice on how to make it work?
Kindly,
Ukhu

Dear Ukhu,
in fact, the examples delivered with our Jetson development kits, which are hosted on github, are designed to work with our MIPI cameras, and utilize the ISP of the NVIDIA platform. However, it should be possible to use the examples with slight modifications with other camera types as well. Basically, the GStreamer pipeline must be changed for this to use another camera type. If you have tiscamera installed, you should be able to replace the GStreamer element nvarguscamerasrc (which is used to deliver images from our MIPI cameras and preprocess the images using the builtin ISP) with tcambin, which delivers images from all our industrial cameras.
Please note that the images from nvarguscamerasrc are delivered in graphics memory (NVMM) whereas tcambin can only deliver images in CPU memory. The already present GStreamer element nvvidconv should take care of the required conversion. Could you please try out this change in the context of the face detection example?
Best regards
Alexander

Closed due to inactivity.


BZ2018063: QEMU guest agent - RN (all versions)

https://bugzilla.redhat.com/show_bug.cgi?id=2018063
Add RN and QEMU guest agent known issue to RN
Preview: https://deploy-preview-227--forklift-documentation.netlify.app/documentation/doc-release_notes/master/#known-issues-22_forklift

@istein1 Ready for QE. Please review.

Will this update appear for all MTV past versions too (MTV-2.0, 2.1)?

Will this update appear for all MTV past versions too (MTV-2.0, 2.1)?

@istein1 Yes. I can copy the change.


TS2339 refactoring warnings (three gray dots) appearing under javascript properties

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.60.2 (user setup)
OS Version: Windows 10 Pro 20H2, 19042.1165, Windows Feature Experience Pack 120.2212.3530.0

Steps to Reproduce:
I have a JavaScript file. It declares & defines a variable in the topmost scope, like const options = {};
Then, at some dynamic point during runtime, user configuration values (properties) are cloned from local storage into this options object:
for (const [key, field] of Object.entries(storage)) options[key] = field.value;
So obviously TypeScript validator thinks options.blahblah does not exist. Which is fine, I don't expect it to. But instead of just creating a lightbulb icon to the left when I click on its general area, it adds 3 dots under the beginning of the property name, which appear no matter what I do. They're showing 100% of the time. When I have dozens of properties being referenced all over the place, these little dotted underlines cause a large amount of visual clutter.
It's irritating because there's nothing wrong with my script, but vs code keeps treating it as somehow erroneous and shoving it in my face. It doesn't give me any valuable refactoring suggestions either. Astonishingly, it clutters my document with a hundred of these warnings, only to recommend "extracting to Fluent files" in each case. Obviously that suggestion is completely irrelevant to my use case.
 When I originally wrote this script some months ago, and validated it with ESLint, these gray dots did not exist. It's only when I came back to update it that I noticed the warnings. Naturally I went digging through the settings, but could not find anything that sounded relevant. I did some google searches and found people talking about other representations of the same rule (2339) in vs code extensions. But I couldn't find any solution or suggestion for disabling it in the TS/JS validator of vs code proper.
So I just went ahead and started blindly unchecking boxes in the settings. I figured eventually I'd reload vs code and see the dotted underlines are gone, but no such luck. So I'm wondering if a setting to disable this even exists.
Thank you 🙏

I confirmed that it's an unintended effect of that PR (#44271). I'll figure out why other, unwanted suggestions are showing up.

reportNonExistentProperty can report several kinds of errors, most of which do not contain spelling suggestions. Currently, all these errors are getting turned into suggestions. Only the did-you-mean ones should.


Upgrade Play! version from 2.5.15 to 2.5.16

No changes other than version numbers from Maven plugin or test projects point of view, but update anyway.

New 1.0.0-rc2-SNAPSHOT snapshot deployed.


integrate firefox mathml rendering

@apsexton This is basically done in the latest version. Can you check if you can crop the images. The MathML rendering does not have a dimension, thus I can not simply adjust the window size

Cropping the images is not a problem - my code already does so.


Tester opens way too many files

And possibly doesn't close them possibly, leading to runs constantly failing with too many open files.
I've done a lot of rounds of trying to find file leaks, but none seem to be showing up, meaning this is possibly just a case of, well, opening too many files at once.
Some mitigations in the interim could include making sure we don't parallelise on large corpi directly (instead, use a worker pool); trying to push worker pools more pervasively (deeply nested parallelisations within parallelisations might be blowing up combinatorial); and fixing the harness overspecialisation issue (which I'll file an issue for next).

This is still an issue, despite a few attempts to try to address it.  Some mostly circumstantial observations:

It seems to take about 3 days to happen every time
The ulimit of the machine we're testing on is 1024, so it seems like a slow trickle of file loss
We deal with an input corpus of over 1024 files, so it doesn't seem to be in the initial planning section

After running the tester for several weeks on end, there have been no file exhaustion crashes.  I'm satisfied that this is no longer an issue, and that the fix was indeed related to buggy SSH code.  Closing.


Neo4J 3 - db.find() - cypher requires parentheses in patterns

Cypher always preferred parentheses when matching nodes and patterns.  In Neo4J 3.0, it is required.  Error returned from neo4j 3.
db.find()
Neo.ClientError.Statement.SyntaxError
Parentheses are required to identify nodes in patterns, i.e. (n) (line 1, column 7 (offset: 6))\\n\"MATCH n WHERE n.key = {key} RETURN n\"\\n       ^

Cheers!


HDDS-6775. Add more performance logs to DataNode disk/container operations

What changes were proposed in this pull request?
Log warnings if any DataNode request handler spends more than 300ms, or if any block read/write takes more than 300ms.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6775
How was this patch tested?
Tested on a standalone cluster that has severe disk latency problem.

cc @duongnguyen0

LGTM.

@jojochuang should we make the threshold to be configurable? Also, this PR looks to be in good shape to merge. Can you please rebase?

hdds.slow.operation.warning.threshold needs to be added to ozone-default.xml, or as an exception in TestOzoneConfigurationFields.
https://github.com/apache/ozone/actions/runs/4286845640/jobs/7866261461?pr=3637#step:5:3378


Building on Humble with Colcon

Is there a port or guide to build this package on humble ? On humble catkin is having all sorts of issues, and lots of forums point to Colcon as the tool to build. Appreciate your help. Newbie here, sorry if this is not the right place to ask this question. Thanks !

This package is not yet ROS2 compatible. Unfortunately this is also not on our roadmap yet.
I'm willing to accept PR's which would add ROS2 support :+1:

It did compile with Galactic

I am wondering if this has a ros2 version documentation.
I am willing to help testing this package in the ros2 environment if needed.

We have discussed this internally and we'll make an effort to support ros2 humble as well. I'll keep you posted!

Hi @Timple ! What's the current status of the ROS2 branch? Should I consider using it in my simulation or is it highly unlikely that it's going to be usable in the nearest future? Thank you a lot!

It should be operational for Humble. Please go ahead and try it out!

It should be operational for Humble. Please go ahead and try it out!
edit: documentation etc are not up to date yet.

Hi Timple!
I've successfully build the project with your full_coverage_path_planner package and all the dependencies (at least the ones I'm aware of). But I'm not sure how to run the test examples.
I have copied the launch files into the ./install/full_coverage_path_planner/share/full_coverage_path_planner/ folder.
When I try to run the launch file example  I'm getting the error:
$ ros2 launch full_coverage_path_planner test_full_coverage_path_planner.launch
[INFO] [launch]: All log files can be found below /home/administrator/.ros/log/2023-06-16-15-08-37-447741-administrator-VirtualBox-118378
[INFO] [launch]: Default logging verbosity is set to INFO
[ERROR] [launch]: Caught exception in launch (see debug for traceback): Caught exception when trying to load file of format [launch]: Error trying to process rule "substitution":

Unknown substitution: find

Maybe you could give me some hints how to launch the examples? I've read your documentation in this repo, but it seems not to apply to the ros2 branch.
Thank you!

Hi @Timple,
By any chance could you give me some hints on how should I proceed?
It's been two weeks since I'm stuck and I'd really love to take a chance and test your module.
Thank you so much!

Hi @Timple, By any chance could you give me some hints on how should I proceed? It's been two weeks since I'm stuck and I'd really love to take a chance and test your module.
Thank you so much!

Hello @mikolodz.
Did you get any update?
I am also starting to use this package for ROS2 Humble. Getting error for launching.
If you have any update pls share.
Thanks

Hi @Timple, By any chance could you give me some hints on how should I proceed? It's been two weeks since I'm stuck and I'd really love to take a chance and test your module.
Thank you so much!

Hello @mikolodz.
Did you get any update?
I am also starting to use this package for ROS2 Humble. Getting error for launching. If you have any update pls share. Thanks

Hello, no, I didn’t succeed.
Maybe you could take a look into the fields2cover lib (2.0)? In the opennav_coverage ROS2 project, there is a pull request regarding the official support of the F2C. Unfortunately, It’s frozen from a while now, because it failed the tests.
You can refer to this issue (with the F2C 2.0 feature list):
https://github.com/Fields2Cover/Fields2Cover/issues/73#issuecomment-1948825774
And this PR (integration with ROS2):
https://github.com/open-navigation/opennav_coverage/pull/53#issuecomment-2373166280
If you find a way to make it running (F2C or FCPP), please let me know! :)
Regards!


Create documentation

ToDo:

[ ] How to use the image with docker-compose
[ ] How to use the container without docker-compose (Create scripts for easy start)

Wiki entry has been added. https://github.com/Galexrt/docker-zulip/wiki

Script added in scripts/docker_start.sh

Updated the wiki pages.


New DK whois

DK_HOST = "whois.dk-hostmaster.dk"  should be changed to 'whois.punktum.dk'
DK Hostmaster recently changed name to .DK aka punktum-dk
They are in the process of changing infrastructure. IANA returns this in refer:
$ whois -I plec.dk
% IANA WHOIS server
% for more information on IANA, visit http://www.iana.org
% This query returned 1 object
refer:        whois.punktum.dk
domain:       DK

PR welcome!

Closing as no reply


1500 sax解析器替換實體

修復#<!--
--  Thank you for contributing to Nokogiri! To help us prioritize, please take care to answer the
--  questions below when you submit this pull request.
--  The Nokogiri core team work off of main, so please submit all PRs based on the main
--  branch. We generally will cherry-pick relevant bug fixes onto the current release branch.
-->
What problem is this PR intended to solve?

Have you included adequate test coverage?

Does this change affect the behavior of either the C or the Java implementations?

#2773
重複#

#2775
重複#

#2779

#2773
https://www.bing.com/fd/ls/GLinkPing.aspx? IG=60B0D2239CD5446EA09B81C274DBF66A&&ID=SERP,5177.1&SUIH=4ieSXRL9zCbYVzCgp9nqpA&redir=aHR0cHM6Ly9hcHBzLmFwcGxlLmNvbS90dy9hcHAvJUU2JTk4JTlGJUU1JTlGJThFb25saW5lLSVFNiVBQyVBMSVFNCVCOCU5NiVFNCVCQiVBMyVFOSVBRCU5QSVFNiVBOSU5RiVFOSU5QSU4NyU4RCVFNyU5OSVCQiVFNSVBMCVCNC9pZDkx #2779

@Gesisfm

@HamptonMakes


axfr source does not support CAA records.

we use Octodns in our environment and we use the axfr source. we need to add support to CAA records but the current source doesn't support it.

Can do, easy peasy. Not sure why I didn't do it originally. Keep an eye out, working on it now.


Error trap needed in pykob/morse.py

On wire 11 this evening, MKOB stopped working with this error:
PyKOB 1.2.14
MorseKOB 4.0.16
Tcl/Tk 8.6/8.6
2020-12-16 18:01:10 INFO:       Record to 'Session-20201216-1801.json'
Exception in thread Internet-DataRead:
Traceback (most recent call last):
  File "C:\Users\Les\AppData\Local\Programs\Python\Python37\lib\threading.py", line 917, in _bootstrap_inner
    self.run()
  File "C:\Users\Les\AppData\Local\Programs\Python\Python37\lib\threading.py", line 865, in run
    self._target(*self._args, **self._kwargs)
  File "C:\Users\Les\Documents\GitHub\PyKOB\pykob\internet.py", line 89, in callbackRead
    self.callback(code)
  File "C:\Users\Les\Documents\GitHub\PyKOB\kobmain.py", line 101, in from_internet
    Reader.decode(code)
  File "C:\Users\Les\Documents\GitHub\PyKOB\pykob\morse.py", line 179, in decode
    mk = codeSeq[i+1]
IndexError: tuple index out of range

The problem seems to be that the program was trying to decode a code sequence from the internet that was more than 50 elements long, which is a violation of the MorseKOB / CWCom protocol.
I don't know what might be causing this error, but a trap should be added to the program to recover gracefully and possibly log helpful diagnostic information.
This seems to be a rare problem. I think we can leave it on the back burner for now.

I believe this code has been made much more robust as part of the recent 'Preferences' panel changes.  @leskerr, Could you please test again to see if you can evoke an error entering unexpected input in these fields (or their corresponding Preferences dialog settings)?

I believe this code has been made much more robust as part of the recent 'Preferences' panel changes.  @leskerr, Could you please test again to see if you can evoke an error entering unexpected input in these fields (or their corresponding Preferences dialog settings)?

The problem I run into with configuration is that (in the main window) I delete the value from wire in order to enter a different value. Currently, is seems that each keystroke change is saved. I believe that is excessive - but beyond that it causes an exception when I delete the whole box.
I'm not sure the error @leskerr had is associated with configuration, but maybe (as you suggest) changes in that area fixed this problem.

The problem I run into with configuration is that (in the main window) I delete the value from wire in order to enter a different value. Currently, is seems that each keystroke change is saved. I believe that is excessive - but beyond that it causes an exception when I delete the whole box.
I'm not sure the error @leskerr had is associated with configuration, but maybe (as you suggest) changes in that area fixed this problem.

Error handling for data packet reading was added to handle the orderly shutdown of the class. I haven't seen this exception since that was added.
pykob version 1.3.4


consul: 1.9.3 -> 1.9.4

Motivation for this change
Version bump.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 115298 run on x86_64-linux 1

1 package built:

consul


[boost-atomic] build failure

Host Environment

OS: [Windows]

To Reproduce
Steps to reproduce the behavior:
.\vcpkg install pcl:x64-windows
Failure logs
C:\vcpkg> .\vcpkg install pcl:x64-windows
Computing installation plan...
The following packages will be built and installed:

boost-asio[core]:x64-windows -> 1.77.0
boost-atomic[core]:x64-windows -> 1.77.0
boost-bimap[core]:x64-windows -> 1.77.0
boost-circular-buffer[core]:x64-windows -> 1.77.0
boost-coroutine[core]:x64-windows -> 1.77.0
boost-date-time[core]:x64-windows -> 1.77.0
boost-dynamic-bitset[core]:x64-windows -> 1.77.0
boost-endian[core]:x64-windows -> 1.77.0
boost-filesystem[core]:x64-windows -> 1.77.0
boost-foreach[core]:x64-windows -> 1.77.0
boost-format[core]:x64-windows -> 1.77.0
boost-functional[core]:x64-windows -> 1.77.0
boost-graph[core]:x64-windows -> 1.77.0
boost-interprocess[core]:x64-windows -> 1.77.0
boost-iostreams[bzip2,core,lzma,zlib,zstd]:x64-windows -> 1.77.0#1
boost-lambda[core]:x64-windows -> 1.77.0
boost-lexical-cast[core]:x64-windows -> 1.77.0
boost-math[core]:x64-windows -> 1.77.0
boost-multi-array[core]:x64-windows -> 1.77.0
boost-multi-index[core]:x64-windows -> 1.77.0
boost-numeric-conversion[core]:x64-windows -> 1.77.0
boost-parameter[core]:x64-windows -> 1.77.0
boost-phoenix[core]:x64-windows -> 1.77.0
boost-property-map[core]:x64-windows -> 1.77.0
boost-property-tree[core]:x64-windows -> 1.77.0
boost-proto[core]:x64-windows -> 1.77.0
boost-ptr-container[core]:x64-windows -> 1.77.0
boost-random[core]:x64-windows -> 1.77.0
boost-serialization[core]:x64-windows -> 1.77.0
boost-signals2[core]:x64-windows -> 1.77.0
boost-sort[core]:x64-windows -> 1.77.0
boost-spirit[core]:x64-windows -> 1.77.0
boost-thread[core]:x64-windows -> 1.77.0
boost-tokenizer[core]:x64-windows -> 1.77.0
boost-tti[core]:x64-windows -> 1.77.0
boost-uuid[core]:x64-windows -> 1.77.0
boost-variant[core]:x64-windows -> 1.77.0
boost-xpressive[core]:x64-windows -> 1.77.0
bzip2[core]:x64-windows -> 1.0.8#2
eigen3[core]:x64-windows -> 3.3.9#1
flann[core]:x64-windows -> 2019-04-07#3
liblzma[core]:x64-windows -> 5.2.5#4
libpng[core]:x64-windows -> 1.6.37#15
lz4[core]:x64-windows -> 1.9.3#3
openssl[core]:x64-windows -> 1.1.1l#3
pcl[core]:x64-windows -> 1.12.0
qhull[core]:x64-windows -> 8.0.2#2
vcpkg-cmake-config[core]:x64-windows -> 2021-09-27
zlib[core]:x64-windows -> 1.2.11#13
zstd[core]:x64-windows -> 1.5.0#1
Additional packages (*) will be modified to complete this operation.
Detecting compiler hash for triplet x64-windows...
Restored 0 packages from C:\Users\Haris\AppData\Local\vcpkg\archives in 8.533 ms. Use --debug to see more details.
Starting package 1/50: boost-atomic:x64-windows
Building package boost-atomic[core]:x64-windows...
-- Using cached boostorg-atomic-boost-1.77.0.tar.gz.
-- Cleaning sources at C:/vcpkg/buildtrees/boost-atomic/src/ost-1.77.0-89304db709.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/vcpkg/downloads/boostorg-atomic-boost-1.77.0.tar.gz
-- Using source at C:/vcpkg/buildtrees/boost-atomic/src/ost-1.77.0-89304db709.clean
-- Configuring x64-windows
-- Building x64-windows-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:155 (message):
Command failed: C:/vcpkg/downloads/tools/cmake-3.21.1-windows/cmake-3.21.1-windows-i386/bin/cmake.exe --build . --config Debug --target install -- -v -j9
Working Directory: C:/vcpkg/buildtrees/boost-atomic/x64-windows-dbg
See logs for more information:
C:\vcpkg\buildtrees\boost-atomic\install-x64-windows-dbg-out.log

Call Stack (most recent call first):
installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_build.cmake:102 (vcpkg_execute_build_process)
installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_install.cmake:41 (vcpkg_cmake_build)
installed/x64-windows/share/boost-build/boost-modular-build.cmake:105 (vcpkg_cmake_install)
ports/boost-atomic/portfile.cmake:23 (boost_modular_build)
scripts/ports.cmake:142 (include)
Error: Building package boost-atomic:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with git pull and .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
package: boost-atomic[core]:x64-windows -> 1.77.0
vcpkg version: 2021-11-02-af04ebf6274fd6f7a941bff4662b3955c64f6f42
vcpkg-tool version: Failed to get HEAD: fatal: not a git repository: 'C:\vcpkg.git'
Additionally, attach any relevant sections from the log files above.
config-x64-windows-out.log
I want to install PCL library. Please help!

@GiantDeveloper021 Please attach C:\vcpkg\buildtrees\boost-atomic\install-x64-windows-dbg-out.log

Sure.
install-x64-windows-dbg-out.log

@GiantDeveloper021 Looks like you compile with VS2015 (MSVC 19.0). One intrinsic hasn't been found: x86_vector_tools.hpp(36): error C3861: '_mm_set1_epi64x': identifier not found
Could you try to build with VS2017 or later?

@yurybura Thanks for replying. Yes i am compiling it with VS2015 because i am using librealsense library (https://github.com/IntelRealSense/librealsense/tree/legacy). If you check the link and goto compatibile platform section the library was tested on windows 10 with Visual Studio 2015 update 2 due to that i didn't compile this library with Visual Studio higher than 2015 but going to try it on VS2017.

Visual Studio 2015 update 2

I guess the intrinsic is available only since Update 3, you should be able to safely upgrade to Update 3. If you could find  _mm_set1_epi64x  in compiler headers report that to https://github.com/boostorg/atomic/issues/52.

Sorry for replying late. @Kojoley i installed VS2017 and it fixed my issue. Thanks alot @yurybura !


Replace equality operators with identity in gen_daal4py.py

Replace equality (==) and (!=) with identity (is) and (is not) as
recommended by PEP8
This is for improving code quality

Some minor quality improvements for #316

@a-mere-peasant thanks you!


A new type of notification

Hi Dragshot, i've an idea 4 add to ur library notification.
My idea consists in a new type of notification that forces the user to click on it or not, like the required messasge windows of microsoft windows, but that notification could disappear when the user click on the notification or when a time specified by the dev passes or both. That new type of notification would be used by the dev wants to make to his project displays and mandatory notification to draw the user focus and that notification flashes when de user clicks out the notification or press any key of the keyboard.
I mean the new type of notification could works like the JOptionPane that contains an JButton to confirm something (I hope you understand what I mean with this small explanation of the JOptionPane).
This new type of notification could contain an actionsListener to control specific events at the developer's discretion.

I've another idea, this idea is that the programmer can choose the size of both the width and height of the notification in a personalized or default way, as well as the position in which the notification is displayed.
All this so that the notification is easier for the user to see.


⚠ ClamAV has degraded performance

In 5fa0287, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 97 ms

Resolved: ClamAV performance has improved in 1e53791 after 5 minutes.


Feature Request: Better vertical viewing

Viewing streams on a vertical monitor puts the chat on the right side next to the video.
This makes sense if you are viewing the stream on a horizontal monitor but not on a vertical one.
Ideally it should look like how Youtube is doing it:

Fixed in Holodex 2.25


Feature request/idea Complete delegation of email templates

I'd like to have bamboo deal 100% with rendering and delivery of emails for my app.
You can see a work in progress here where I delegate my pow mailer here:
https://github.com/PolymorphicProductions/morphic.pro/blob/bamboo_mailer/lib/morphic_pro_web/pow/mailer.ex
To my bamboo mailer here:
https://github.com/PolymorphicProductions/morphic.pro/blob/bamboo_mailer/lib/morphic_pro_web/email.ex
I personally think email is not exclusive to pow and that it's better to have a single consolidated module that deals with the mail needs holistically. For me, that's bamboo as I know it best for my needs.
The current issue I have with pows extensions is that even if I delegate the mailer to bamboo, by the time the email has been created by pow its already rendered the HTML templates to its html prop which is not needed as I will be overriding it anyways via bamboo once I get to pass that data to it. I'd also like to avoid having to make a view for each extension as well.
IE the email that gets passed to the miles cast function as already rendered the view in the html. This is what I want to delegate to bamboo.
Secondly, the next issue I have currently is that I need access to the conn in my view's render which if I'm delegating from cast/1 I could gain access to it from the email but sadly Pow.Phoenix.Mailer.Mail.new/4 does not pass its conn alone with the struct it makes. Whats your thoughts about that?
Its also in Pow.Phoenix.Mailer.Mail.new/4 where I see the views render is called for the html and text values and I was trying to think how I could configure this mail to skip that altogether if I want to have that delegated to something else later on.
Anyhow thanks for all the great work thus far.

So there are two concerns here:

Render email templates and subject
Deliver the email

And the way I handle it is that the controller does both, as seen in the email confirmation callbacks:
  @doc """
  Sends a confirmation e-mail to the user.
  The user struct passed to the mailer will have the `:email` set to the
  `:unconfirmed_email` value if `:unconfirmed_email` is set.
  """
  @spec send_confirmation_email(map(), Conn.t()) :: any()
  def send_confirmation_email(user, conn) do
    url               = confirmation_url(conn, user)
    unconfirmed_user  = %{user | email: user.unconfirmed_email || user.email}
    email             = Mailer.email_confirmation(conn, unconfirmed_user, url)

    Pow.Phoenix.Mailer.deliver(conn, email)
  end

My thinking was that this is how Phoenix handles render and return response. However, after going through the Phoenix code base again , I see that the the controller actually does both at the same time. So I think you're right that the current way Pow does this doesn't make sense.
Ideally a Mail struct is set up, then cast/1 is called, and then before process/1 is called the render happens. This way you can override the behavior if necessary. I'll have to think a bit more about this though, been busy these days.

For me ideally, the concerns are as followed.
Given I'm able to configure this workflow that state I want to delegate the following to bamboo from pow:
Pow:
1: creates the shape of the email data given its not been gated by logic. IE: sender, receiver, subject, attrs and conn.
2: Pow calls cast, which I use do delegate to bamboo the needed data from pow.
Bamboo:
3: creates an email, hydrates the emails layouts, templates, headers ect.
4: At this point, you could send the email back to pow so that it could be sent off to process which could then would again delegate to bamboo for deliver_now/deliver_later
In short, the only thing I really want pow to dow\ with my emails is the control flow up to the point its time to make an email stuct. From there out I'm trying to hand all the remaining work off to bamboo.

Thoughts about the send_confirmation_email/2 in the controller callbacks example. Is the idea to possibly delegate the email and deliver calls to an intermediate module that would know based on config which modules to delegate the calls too?

Is the idea to possibly delegate the email and deliver calls to an intermediate module that would know based on config which modules to delegate the calls too?

Could be, though I think the approach I detailed above would solve all your issues. In short it would look like this:
mailer = # your mail module
type = # the unique mail name

type
|> Mail.new(assigns)
|> mailer.cast()
|> Mail.render() <--- this can be stopped by the above transformation
|> mailer.deliver()

Also, I haven't completely fleshed out the idea, but ideally you won't need any knowledge of the conn to build and deliver the email. This is what you would need for background jobs and such. It would be nice if you could easily call the send_confirmation_email/2 email from any other part of the system, right now it sits in the PowEmailConfirmation.Phoenix.ControllerCallbacks and I don't think it belongs there.

Have you looked at protocols yet? https://elixir-lang.org/getting-started/protocols.html
I'm thinking this could be a way to abstract away the implementation of each kind of email ("mail") into their own respective extension.

Yeah, I really like that concept, but I don't think it would fit for this situation?

Sorry for being vague, the general idea I was kicking around in my head was.
First: I think it would be best to try and remove the construct of an email from in the main pow lib.
IE everything from pow/lib/pow/phoenix/mailer/ should be migrated into its own lib/extension as pow its self should have to know about an email since it does not deal directly with them, only its extensions do.
From there I was thinking about how to define a behavior/protocol to define what an email should look/act like which each extension could implement on their own respectively.
In the end I was really just trying to think of better ways to decouple emails from the main lib as that's really what my main goal was really about in the first place. In that want to 100% delegate all that to bamboo.

First: I think it would be best to try and remove the construct of an email from in the main pow lib.
IE everything from pow/lib/pow/phoenix/mailer/ should be migrated into its own lib/extension as pow its self should not have to know about an email since it does not deal directly with them, only its extensions do.

Yup 💯. It would remove an unnecessary part in core. I think it should be moved over the the extensions utilities though.

From there I was thinking about how to define a behavior/protocol to define what an email should look/act like which each extension could implement on their own respectively.
In the end I was really just trying to think of better ways to decouple emails from the main lib as that's really what my main goal was really about in the first place. In that want to 100% delegate all that to bamboo.

Hmm yeah, though it would be possible to do this with the change in call logic I got in mind. Imagine this setup:
def pow_email(%Mail{type: :pow_email_confirmation_confirm_email, user: user} = mail) do
  base_email()
  |> to(user.email)
  |> subject("Your custom subject")
  |> render("confirm_email.html")
end

# ...

It's triggered when cast/2 is called. The fallback logic would be the current render handling.
Though maybe what you are thinking about is actually replacing the whole mailer call, so you can ignore the cast/process handling in the Pow mailer. A mail render call could look like this:
my_mailer.pow_email_confirmation_send_confirmation_email(user_or_assigns)

And you can impl the mails with a macro:
use Pow.Extension.Mailer,
  extensions: [...]

def pow_email_confirmation_send_confirmation_email(...) do
  base_email()
  |> to(user.email)
  |> subject("Your custom subject")
  |> render("confirm_email.html")
  |> deliver_now()
end

Also I would most likely drop conn complete, since this call can also come from another place than the endpoint/plug/controller. I think these are some great thoughts, I'll try work it through and see in what way this can be implemented.

Awesome, I like where this is going. Thank you for entertaining my ideas. 🙏Aswell great work on this lib. I'm really enjoying it.


custom material integration for android studio

Would be great to have the usual editor functionality one gets for Java also for a .mat file, like proper syntax completion, error highlighting and selected variable highlighting.
Even better would be a live shader preview.
Amazing would be a shader debugger like apple introduced this summer for metal.
I know you can't comment on not yet publicly introduced products, but getting better functionality around custom material would be welcome.

We're working on a visual material editor with real-time previews: https://github.com/google/filament/tree/master/tools/tungsten
A couple of work in progress screenshots:
https://user-images.githubusercontent.com/5298046/45185381-d63d5580-b1de-11e8-832e-978459fcfee0.gif
https://user-images.githubusercontent.com/5298046/45641781-a4947c00-ba73-11e8-9ebd-985d5001f4c5.gif

That is actually pretty neat to have. Looking forward to it.
Felt always jealous when I saw what the blender guys managed to create with the node editor there.
Realtime vertex and fragment shader preview would be separate from this, right?

It's part of it, you can see it in the screenshots. Editing the material automatically update a live preview.

@romainguy
Last commit seems to have been 5 months ago. Is it canceled or are you at it internally?

Hi there
As Michael says, in orden to use ARCore+Sceneform as a real world production framework, we need a material (sfm / mat) authoring tool (or plugin for Marín 3D Tools) for the artist guys and girls.
Is this kind of tool a milestone in the future releases plan?


[ch # 161527250] refactored validation request validation

Pull Request Test Coverage Report for Build 15

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.897%

Totals

Change from base Build 13:
0.0%

Covered Lines:
187

Relevant Lines:
195

💛  - Coveralls

Pull Request Test Coverage Report for Build 15

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.897%

Totals

Change from base Build 13:
0.0%

Covered Lines:
187

Relevant Lines:
195

💛  - Coveralls


Chore/upgrade runtime

before I merge this, @Milena-Czierlinski PTAL.

@jkoenig134 I suppose Correlation IDs and IdentityMetadata are not relevant for the app, are they?

Correlation IDs are not possible to implement and IdentityMetadata are not implemented when not needed, yes.

nice catch!


Update lsp handlers according to the neovim new lsp api

The plugin does not work with the neovim new lsp API, this pull request could fix it.

Can confirm this PR fixes problem.


Custom access policy for BYO Container is not supported

Issue

generating a presign url will get or create a policy
running revokeAllPresignURLs() will delete existing policies
As a result revokeAllPresignURLs() will remove any pre-existing policy set by the user in the blob storage container

The underlying issue is that files lib does not support byo containers with custom properties but it also does not explicitly throws an error if the users does so.
Possible solutions

Throw an error on init if the container has custom access policies defined - OR any custom setting really
Support custom containers

Hi @moritzraho , with regards to the latter Support custom containers solution, I am afraid that we might have to support too many corner cases and custom setups.
Do we have a larger overview of what could be impacting custom containers?
IMO the first solution combined to an enhancement of the documentation could be satisfying.

I am afraid that we might have to support too many corner cases and custom setups.

Yes agree,

the support for custom containers would be a challenge to maintain, as new features in azure or files lib might break it.

Do we have a larger overview of what could be impacting custom containers?

Not really, for now I only see custom policies breaking due to the way presign urls are generated and revoked but other custom settings might have more subtle impacts

I'd then suggest

going for the first solution
documenting our requirements and expectations for a BYO scenario
doing the same for aio-lib-state if needed

@sarahxxu how do you feel with that approach?

I concur

I would love that we get (1) Throw an error on init if the container has custom access policies defined - OR any custom setting really. So it makes sure we don't unexpectedly break existing setup.
(Another idea, which is even "harsher": for developers, when they use the lib, force them to explicitly switch a config flag to allow aio to overwrite/create permission policies... ? This would make it impossible to break this by chance, but is an API breaking change).

Added PR to address above issue

@tmathern do you want to take a quick look to the PR raised by Sandeep before we merge it ? https://github.com/adobe/aio-lib-files/pull/97

@moritzraho Sure, I'll take a look.
One comment:

When we test for an existing policy, I don't think there is a a guarantee that a uuidv4-like identifier was created by aio... It could be someone also has code to create those automatically using uuidv4 (since it's a good way to create identifiers). I would suggest, when aio creates policies, to prefix them with aio or aio-files to avoid confusion. So the id creation and id check could look for a policy named ${aio-prefix}-${uuidv4-id}. Wdyt?

@tmathern we would only support a single policy for a given container, as per the new change if there are more than one policies, aio-lib-files init will anyway error out(more than one policy will mean there are custom policies). So we won't need any prefix and any custom policy with uuid4 format will anyway error out.


More Intuitive Examples for Non-Eggheads ¯_(ツ)_/¯ ; I dont understand how to access the data

Add content management functionality to any site......ok how?

*Note: I'm not exactly a developer, nor am I exactly a designer. I mostly develop frontend components (HTML/CSS/some JS). I have a working understanding of PHP. All I'm trying to do is connect this CMS to a basic HTML page.
So I found this CMS, and it seemed straight forward up until it was time to access the data and apply it to the page. I just need to know how do I access my data via the API. I have generated a token. But then what? To a person that's not exactly a backend dev, the next step is just missing. I don't exactly work with JSON but I've worked with it before. So do I need to make a call to the API with the token generated...if so how? What is the syntax for the data once I'm able to access it? Is it  {{whatever.Code}}?
If there was a simple Youtube video or screenshots where there was a step by step for dummies like me, I could possibly give this a try. I've searched around but there isn't any more examples beyond me tying cockpit with some other convoluted JS/Node/Static Generator tool.
Currently I've created a collection entry for basic page data (page-title and page-content). This is just for testing purposes. But I can't seem to access the collection data. I keep getting an error whenever I add the token to the top of the page as either a script
<script src="/api/cockpit/authUser?token=0a014d090bf541dc7482939f22841e'"></script>
or as the example you have in the documentation
`
fetch('/api/cockpit/authUser?token=0a014d090bf541dc7482939f22841e')
	.then(res => res.json())
	.then(res => console.log(res));

`
Also, I'm trying to do this all locally. If thats my issue this need to be stated somewhere in the documentation, but I would figure I would be able to access the data locally. Could someone help, or email me for quick answers....thanks!

You can use php curl to access the API endpoint. or you can use axios if you simply want to connect it to your html with a basic js. Install axios using any methods you prefer, include it in your html file, then simply copy the example code in the documentation but replace fetch with axios.get and you sohuld get your data.

Ok, so I was able to get the data to come through in the console. Apparently you don't need
.then(res=> res.json()))
for Axios. Found this out after hours of researching why I kept getting
Uncaught (in promise) TypeError: res.json is not a function
Now I just need to know how I can pull certain entries from my collection and applying them on the page. Or at least how to filter entries from others. So say I made a Pages collection with an entry for page.Title, how do I echo out this page title to the page I want with Axios? Sorry for the noob questions but I'm really just trying to learn because this decoupled CMS seems pretty interesting.

That's also explained in the doc. You make a POST to your endpoint and use filter to filter the data. Here's how I did it in my recent project.
axios({
  method: 'post',
   url: '/cockpit/api/collections/get/Gallery?token='+ this.$root.apikey,
        headers: { 'Content-Type': 'application/json' },
        data: JSON.stringify({
          filter:{'_id': 12345},
          limit: 1
        })
      }).then((res) => console.log(res.data));
hope this helps


Can't create a writer with empty channel name!

We appreciate you go through Apollo documentations and search previous issues before creating an new one. If neither of the sources helped you with your issues, please report the issue using the following form. Please note missing info can delay the response time.
System information

OS Platform and Distribution (e.g., Linux Ubuntu 18.04):  Linux Ubuntu 18.04
Apollo installed from (source or binary): binary
Apollo version (3.5, 5.0, 5.5, 6.0): 5.0
Output of apollo.sh config if on master branch: master

Steps to reproduce the issue:

Please use bullet points and include as much details as possible:
I am running Apollo following these steps:
./docker/scripts/dev_start.sh
./docker/scripts/dev_into.sh
bootstrap.sh
When i want to enable the cyber bridge by typing:
bridge.sh
there came an error saying 'E0411 21:16:49.980556  8788 node_channel_impl.h:154] [cyber_bridge] Can't create a writer with empty channel name!'

Anyone know what's the problem?

I think the design does not allow empty topics, why do you need this feature?

I think the design does not allow empty topics, why do you need this feature?

I just followed the origin design of Apollo, and I did not do any change. And the previous run was fine.

I think the design does not allow empty topics, why do you need this feature?

I’m afraid I can’t find any code for "cyber_bridge" in 5.0.0. I suggest you double check your topic settings.
 auto talker = talker_node->CreateWriter<Chatter>("channel/chatter");

I’m afraid I can’t find any code for "cyber_bridge" in 5.0.0. I suggest you double check your topic settings.
 auto talker = talker_node->CreateWriter<Chatter>("channel/chatter");

Thank you, i just realized this featureis specified for LGSVL.

I’m afraid I can’t find any code for "cyber_bridge" in 5.0.0. I suggest you double check your topic settings.
 auto talker = talker_node->CreateWriter<Chatter>("channel/chatter");

Thank you, i just realized this featureis specified for LGSVL.

I solved the problem, the sensor deployed on the vehicle need to have a channel name! I will close the issue.


Supporting version 7.0.x

This library is compatible with the new noUISlider. The changes on the nouislider are not used by this library.

Any reason this hasn't been merged yet?


Is there any doc/sample Youtube-v3 (insert_video)?

the current doc/sample is out of date

simple snippet of code to upload video in ruby
`
_YT = Google::Apis::YoutubeV3
youtube = _YT::YouTubeService.new
youtube.authorization = 'your-auth-token'
opts = {:keywords=>[]}
body = {
:snippet => {
:title => 'file upload',
:description => 'description of first file upload',
:tags => opts[:keywords].split(',')
}
}
youtube.insert_video('snippet', body, upload_source:'file.mp4',content_type:'video/*')
`


[HOLD] Moved Data location from Buckets->Reference. Added documentation for upcoming Jurisdictions

Moved Data location from Buckets->Reference. Added documentation for upcoming Jurisdictions

My information submitted name Naveed iftikhar from Quetta Balochistan
Pakistan phone number<PHONE_NUMBER>51
Address. Faisal town brewery road Quetta Balochistan Pakistan
Postel coad area 87300
Bank details submitted
PK27TMFB0000000029800288
Plsss myself amount given me payment amount My given me
On Wed, Sep 6, 2023, 9:05 PM Denise Peña @.***> wrote:

@.**** commented on this pull request.
In content/r2/reference/data-location.md
https://github.com/cloudflare/cloudflare-docs/pull/10580#discussion_r1317516497
:

+3. Enter a name for the bucket.
+4. Under Location, select Specify jurisdiction and choose a jurisdiction from the list.
+5. Select Create bucket to complete the bucket creation process.

+### Using jurisdictions from Workers
+
+To access R2 buckets that belong to a jurisdiction from Workers, you'll need to specify the jurisdiction as well as the bucket name as part of your bindings in your wrangler.toml:
+
+```toml
+[[r2_buckets]]
+bindings = [

{ binding = "MY_BUCKET", bucket_name = "<YOUR_BUCKET_NAME>", jurisdiction = "" }
+]
+```

+For more information on getting started visit to Use R2 from Workers.
⬇ Suggested change
-For more information on getting started visit to Use R2 from Workers.
+For more information on getting started, refer to Use R2 from Workers.

In content/r2/reference/data-location.md
https://github.com/cloudflare/cloudflare-docs/pull/10580#discussion_r1317517004
:

+Jurisdictional Restrictions guarantee objects in a bucket are stored within a specific jurisdiction.
+
+Use Jurisdictional Restrictions when you need to ensure data is stored and processed within a jurisdiction to meet data residency requirements, including local regulations such as the GDPR.
+
+### Set jurisdiction via the Cloudflare dashboard
+
+1. Log in to the Cloudflare dashboard and select R2.
+2. Select Create bucket.
+3. Enter a name for the bucket.
+4. Under Location, select Specify jurisdiction and choose a jurisdiction from the list.
+5. Select Create bucket to complete the bucket creation process.
+
+### Using jurisdictions from Workers
+
+To access R2 buckets that belong to a jurisdiction from Workers, you'll need to specify the jurisdiction as well as the bucket name as part of your bindings in your wrangler.toml:
⬇ Suggested change
-To access R2 buckets that belong to a jurisdiction from Workers, you'll need to specify the jurisdiction as well as the bucket name as part of your bindings in your wrangler.toml:
+To access R2 buckets that belong to a jurisdiction from Workers, you will need to specify the jurisdiction as well as the bucket name as part of your bindings in your wrangler.toml:

In content/r2/reference/data-location.md
https://github.com/cloudflare/cloudflare-docs/pull/10580#discussion_r1317518314
:

+The following jurisdictions are supported:
+
+| Jurisdiction | Jurisdiction description      |
+| ---- | --------------------- |
+| eu | European Union |
+
+### Limitations
+
+During the beta, the following services will not interact with R2 resources with assigned jurisdictions:
+* Super Slurper
+* Logpush
+
+### Additional considerations
+
+Once an R2 bucket is created, the jurisdiction can't be changed.
⬇ Suggested change
-Once an R2 bucket is created, the jurisdiction can't be changed.
+Once an R2 bucket is created, the jurisdiction cannot be changed.
—
Reply to this email directly, view it on GitHub
https://github.com/cloudflare/cloudflare-docs/pull/10580#pullrequestreview-1613710674,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4M4HOGDWBI66KMLQDXP3YTXZCNK7ANCNFSM6AAAAAA4NPK7IE
.
You are receiving this because you commented.Message ID:
@.***>


Missing Javadoc

Hello! I find in your Code Conventions that

All public and protected methods should be fully defined with Javadoc.

However, I still witness some likely missing Javadoc for public methods in the following files:

engine/src/main/java/org/terasology/engine/rendering/RenderHelper.java
engine/src/main/java/org/terasology/engine/rendering/assets/font/FontDataBuilder.java
engine/src/main/java/org/terasology/engine/math/Rotation.java
engine/src/main/java/org/terasology/engine/logic/behavior/core/BehaviorTreeBuilder.java
......

Would you like to add Javadoc for these methods or classes, or they are just not that important?
If there is anything I can help with?

Hi @CoolKangaroo2022,
just because the code conventions urge everybody to provide Javaodoc does not mean that they magically appear 🙈
We're trying to add docstrings here and there, mostly based on the boy scout rule when we're touching the files anyways, or had to investigate related code for any reason.
We do appreciate any contribution, be it providing the perfect docs or just writing down what you think the methods or classes are (supposed to be )doing (yay for using Cunningham's Law). The documentation should help developers to use the code, so it's usually helpful to state assumptions or invariants/contracts of methods or classes, or give usage guides.
We're not trying to get "100% doc coverage" like this, though:
/** Get the title. */
public String getTitle() { return title; }

Do you have some insights you want to share, or took some notes on code you've already looked at, or do you have questions about specific parts of the code you hoped to find answers for in the Javadoc?

Do you have some insights you want to share, or took some notes on code you've already looked at, or do you have questions about specific parts of the code you hoped to find answers for in the Javadoc?

@CoolKangaroo2022 Are you still around and interested to respond to the above question or even help add JavaDoc?


[iOS] AudioObjectRemovePropertyListener: no object with given ID 0

Bug
When in PRD environment, the Player still plays its audio even if you are out of the screen who mounted it. On Xcode log every time I navigate back to the video screen and go back, it logs the message: App[XXX:XXX] AudioObjectRemovePropertyListener: no object with given ID 0
Platform

iOS

Environment info
System:
OS: macOS 10.15.4
CPU: (6) x64 Intel(R) Core(TM) i5-8500B CPU @ 3.00GHz
Memory: 45.71 MB / 8.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 12.8.0 - /usr/local/bin/node
Yarn: 1.22.4 - ~/.yarn/bin/yarn
npm: 6.10.3 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 13.4, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
IDEs:
Android Studio: 3.6 AI-192.7<IP_ADDRESS>41897
Xcode: 11.4.1/11E503a - /usr/bin/xcodebuild
npmPackages:
react: 16.9.0 => 16.9.0
react-native: 0.61.2 => 0.61.2
npmGlobalPackages:
react-native-cli: 2.0.1
Library version: 4.4.5
Steps To Reproduce

Implement  screens A and B, B must have the VideoPlayer with a m3u8 running (using react-navigation 4.0.10)
While the video playing, go back to screen A

Expected behaviour

VideoPlayer be properly unmounted as its listeners on iOS

+1


Editor: make custom bold font config working

Fixes #18737
While correcting the typo, I found another problem'chen, I'm not sure how to handle that:

if you only set the main_font_bold path, nothing happens
setting the main_font path only, breaks the UI, all bold text disappears
only if you set the both main_font and main_font_bold paths, it works as
the author of the PR #18113 intended

This has slightly improved the kerning of some professional fonts, shouldn't that be also configurable?
diff --git a/editor/editor_fonts.cpp b/editor/editor_fonts.cpp
index 26f16e282..867c2c837 100644
--- a/editor/editor_fonts.cpp
+++ b/editor/editor_fonts.cpp
@@ -124,7 +124,7 @@ void editor_register_fonts(Ref<Theme> p_theme) {
                CustomFont.instance();
                CustomFont->set_hinting(font_hinting);
                CustomFont->set_font_path(custom_font_path);
-               CustomFont->set_force_autohinter(true); //just looks better..i think?
+               //CustomFont->set_force_autohinter(true); //just looks better..i think?
        }

        /* Custom Bold font */
@@ -135,7 +135,7 @@ void editor_register_fonts(Ref<Theme> p_theme) {
                CustomFontBold.instance();
                CustomFontBold->set_hinting(font_hinting);
                CustomFontBold->set_font_path(custom_font_path_bold);
-               CustomFontBold->set_force_autohinter(true); //just looks better..i think?
+               //CustomFontBold->set_force_autohinter(true); //just looks better..i think?
        }

        /* Custom source code font */

@capnm Sounds like it should be configurable, maybe try to ask on IRC?

Thanks for fixing the type ! (kind of embarrassing mistake... I was super tired and just wanted to upload the pr...)
Next time I will give myself more time ;)


Cython Temp Fix

Temporarily removing Cython for now before sorting out deploy issue.

Codecov Report

Merging #261 (ccc8326) into master (b48aaf6) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #261   +/-   ##
=======================================
  Coverage   76.01%   76.01%
=======================================
  Files          44       44
  Lines       14001    14001
=======================================
  Hits        10643    10643
  Misses       3358     3358

Impacted Files
Coverage Δ

exetera/_version.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48aaf6...ccc8326. Read the comment docs.


remove the sorting of public read requests and make the rest of public accumulated data readonly

Please read contributing guidelines and remove this line.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#6760  👈
#6749
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @just-mitch and the rest of your teammates on  Graphite


Block Editor: Fixing Small Issues

Minor changes to make it easier for Sage to do view-side edits.
Still not fixed: block editor workspace collapses text when exiting the new block popup from another editor view ( #137 ).

This change is

Review status: 0 of 11 files reviewed at latest revision, 2 unresolved discussions.

src/factory_utils.js, line 1221 at r1 (raw file):

 * @param {string} inputType Type of input (statement, value, dummy).
 * @param {string} blockTypeName Name of block, given by user.
 * @param {string} opt_blockStarterText Starter text to place on block, given by

{string=}

src/controller/block_editor_controller.js, line 103 at r1 (raw file):

   * @param {string} inputType Type of input (statement, value, dummy).
   * @param {string} blockTypeName Name of block, given by user.
   * @param {string} opt_blockStarterText Starter text to place on block, given

{string=}

Comments from Reviewable

Review status: 0 of 11 files reviewed at latest revision, 2 unresolved discussions.

src/factory_utils.js, line 1221 at r1 (raw file):
Previously, svouse wrote…
{string=}

Done.

src/controller/block_editor_controller.js, line 103 at r1 (raw file):
Previously, svouse wrote…
{string=}

Done.

Comments from Reviewable

Comments from Reviewable

Review status: 0 of 11 files reviewed at latest revision, 5 unresolved discussions.

src/controller/project_controller.js, line 91 at r2 (raw file):

   * @param {string} blockType Name of the block to add to the project.
   * @param {!string} libraryName The library to add it to.
   *

Nit: Remove line between @param and @return

src/model/block_library.js, line 73 at r2 (raw file):

      types.push(blockType);
    }
    return types;

What is the point of this change? It looks like it does the same thing in more lines.

src/view/block_editor_view.js, line 45 at r2 (raw file):

   *     BlockDefinition is in.
   */
  constructor(blockDefinition, blockLibrary) {

Why does the block editor view need to know about the library?
I don't see it used below, nor would I expect it to be.

Comments from Reviewable

Review status: 0 of 10 files reviewed at latest revision, 3 unresolved discussions.

src/view/block_editor_view.js, line 45 at r2 (raw file):
Previously, chynu (celine choo) wrote…
When adding a block through the project controller, we need to specify which library it should be added to. Without a "current library" kind of reference, there is no way to tell which library the current BlockDefinition belongs to. I wasn't sure where to place the library, so I put it in the BlockEditorView to be consistent with the "current [ResourceName]" being in the editor views (i.e. the current toolbox is this.toolbox in ToolboxEditorView, etc.). That being said, it did feel a little strange putting in the library within the view, since it isn't really shown in the editor.
Another thing that we can do is have a dropdown of library choices in the new block popup. Presumably the user would always have to use the new block popup to create a block anyway. Perhaps it is better to remove the blockLibrary reference and use the popup to know which library to add a block to?

But this view is concerned with the block editing.  It shouldn't be responsible for adding it to the project  / library. Allow the project controller to add the block to the appropriate place in the project.

Comments from Reviewable

Review status: 0 of 10 files reviewed at latest revision, 3 unresolved discussions.

src/view/block_editor_view.js, line 45 at r2 (raw file):
Previously, AnmAtAnm (Andrew n marshall) wrote…
But this view is concerned with the block editing.  It shouldn't be responsible for adding it to the project  / library. Allow the project controller to add the block to the appropriate place in the project.

I see.. I removed the references to the block library.

Comments from Reviewable

Review status: 0 of 10 files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable


Create variables that are independent from t

There are scalar variables that have the same value for all periods
There is no need to calculate its value independently for each of the periods

e.g. of a variable: elapsed_months

There are two possibilities:

create an independent class for scalars (variables independent of t),
still use ModelVariable class.

For example, if you have the same expense value for each month which you read from an assumption table, you can do it the following way:
expense = ModelVariable()

@assign(expense)
def expense_formula(t):
    if t == 0:
       return <read-from-assumptions-table>
   return expense(t-1)

In that way, we only read from a table once (which is computationally expensive operation) and then only read the value from the previous period.
In that way, we don't have to introduce any other class (e.g. ModelScalar). Fewer classes means simpler code.
However, we should check if introducing a scalar would help with speed. If so, then it might be worth to introduce it.
So thanks for this suggestion, I'll check it and get back to you.

The functionality has been impemented in https://github.com/acturtle/cashflower/commit/b6bb2bede4c5ee816e00aba1972f0400b81c8b71
It has been implemented as new attribute of ModelVariable called scalar.
For example:
bar = ModelVariable(modelpoint=policy, scalar=True)

@assign(bar)
def bar_formula():
    return assumption["table"].loc[657]["B"]

Note that the formula doesn't have a parameter t.


The sign-in button is not showing

I don't know if this is because I do not have a URL or what. Please help!

Any one?