Inserting A Junction Issues

ref https://discourse.nodered.org/t/how-to-find-a-junction/93461/18
Current Behavior
Inserting a link into a wire defaults to placing the junction at the mid-point of the wire, rather than where the user clicked.
If the workspace is zoomed, the insert position is not calculated correctly
Expected Behavior
When inserting a Junction when workspace is zoomed or when inserting a Junction into a wire the Junction should be located at the insertion point
Steps To Reproduce
Zoom workspace and right click to insert a Junction.
Select a wire and right click to insert a Junction
Example flow
paste your flow here

Environment

Node-RED version: 4.05
Node.js version: 20
npm version: 10
Platform/OS: PiOS
Browser: Edge

I thought it might be relevant to add that using the alt+shift+lasso method does put the junction somewhat in a relative location to the mouse drag, BUT this is also affected by the zoomed workspace issue.


Improve the user experience of CM

Based on the direct feedbacks from users I'm adding some points which can help improve the user experience while using CM

[x] While using path as inputs to CM scripts, both absolute and relative paths including user home expansion, must be supported.
[x] Auto deleting invalid CM cache entries - at times a CM cache entry can become invalid when the dependent file(s) get removed. In such cases we would need CM cache to be removed transparently
[x] Simplify the README files - a short description of a given CM script and a simple run command to try it should be at the top.
[x] Create a main usage file for script automation. - WIP here
[x] Adding a dependency graph in script readme using mermaid
[x] Adding a hash check for file downloads

We now support relative path in cm docker and also has support for mermaid dependency graph generation which is now used for mlperf-inference.


display tag name brackets in scenegraph

cool change!

Should we do this for all of them?

@dmarcos we're displaying ID || tagName so this is just for the ones with just tagName

I think it's more consistent and useful if you can see both all the time <a-entity id="redBox">. It reinforce the idea that the scene graph is actually the DOM

but maybe that will make the scenegraph too wide, just thinking that we need to add icons there for actions for the entities, the visibility toggle icons (eyes),... it could take half of the screen

I know that adding <a-scene> makes the problem a bit worse but the scenegraph being too wide is already a problem with deep hierarchies. How are we going to deal with it?

Can we find a way to display the html tags without taking too much space? I think it's a good idea.

What about something like this? (coder-colors). Adding the < > will helps also to differentiate the components' icons (if at the end we'll leave them there) from the entity actions icons, and it will give a better vision of the DOM.

I really like it. It conveys that those icons are part of the DOM too :).
If you think about it there won't probably be many elements with IDs in the average experience so the wide scenegraph is less of a problem in practice. People use IDs to mark key elements in the page. I expect to see most of the entities with no ID.

How do we deal anyways with scengraphs with 3 or more levels? Is the scene graph panel adapting already the width?

I expect to see most of the entities with no ID.
Yep you're right

How do we deal anyways with scenegraphs with 3 or more depth levels? Is the scene graph panel adapting already the width?
Right now is not adapting, but we could make it adapt. I also don't expect to have so many depth levels and even if you have them.
Another option is to make it fixed size and add scroll when needed (maybe after 3 levels) and the user could horizontal scroll (I know that sucks) or change the size of the sidebar. But probably this one is harder to implement too.

Unity even doesn't support horizontal scrolling, you need to resize the scenegraph.


Improving the docs: browser testing!

The testing guidelines have very little information about what functional browser testing looks like in D&D, and the stuff that's there now might be a bit out-of-date.
Also, in different code reviews of the same browser test spec, I've received conflicting information from reviewers about what "best practice" should be for a particular line. Maybe we could add some more guidance around what our best practices are for browser testing?
Current behavior

From the "Browser testing" section of the "Testing" guidelines page:

Most CFPB projects use behave for browser testing.

From the code reviews I've described: no guidance on whether we have a clear preference for toBe.(true) vs. toBeTruthy() vs. toBeTrue(), and when we might choose one over another.

Expected behavior

Inclusion of protractor in the description of what we use. It's used across consumerfinance.gov in general (and particularly on some specific tools).
If there are coding best practices that we have a clear preference for at the Bureau, we state what they are. For example, if we prefer to use .toBeTrue() or .toBe(true) to evaluate the value produced by something like .isDisplayed() rather than toBeTruthy() (because .isDisplayed() will always deliver a Boolean promise), we could state that. And if we truly want it up to the discretion of each individual programmer, we state that.

Thanks for bringing this up.
There is a difference between truthy and true.  toBeTruthy (Jasmine) / to.be.ok (Chai BDD) and toBeTrue() (Jasmine) / ``to.be.true (Chai BDD) in how they'll evaluate out and we've tried to use true over truthy whenever we can because it is more strict. I think guidance on that is helpful!
I don't think we should issue guidance on what type of syntax to use. It looks like all the syntax above is in Jasmine, which is the best supported tool for Protractor, but there's been talk about switching to Mocha Chai to keep it consistent with our unit tests. We also want to leave ourselves open in case there's a better tool for testing other things like React. I think we should describe what is used rather than offer guidelines here. (Also, I'm not sure what syntax uses toBeTrue(), I tried searching in projects to research it but came up empty.)

There is a difference between truthy and true. toBeTruthy (Jasmine) / to.be.ok (Chai BDD) and toBeTrue() (Jasmine) /to.be.true (Chai BDD) in how they'll evaluate out and we've tried to use true over truthy whenever we can because it is more strict. I think guidance on that is helpful!

Then maybe that's all the guidance needed, rather than syntax standards: "When looking at how things evaluate, be as strict as possible."
(Personal note: when first starting Jasmine/Protractor browser tests at the Bureau, I had tests written using toBe( true) and was advised to change them to toBeTruthy(). Several months later, told by someone else that they should be changed back. Knowing that we lean more towards strict evaluation would be helpful to know when deciding if a code review change request is actually the best choice for a particular situation.)
Finally, toBeTrue() is used in a Jasmine add-on. I hadn't checked if the Bureau was using it specifically, but it could be something that outside folks are using or new folks have experience with. Maybe another vote in the "don't talk about specific syntax" column!

@sebworks has some good starter notes here: https://gist.github.com/sebworks/edb4c89c4e8c244812f2dac3d6f77a89
I'm prodding him to add to them to the repo!


Resize from border with multiple directions not only bottom right

I managed the resize from border using custom handles:

but it doesn't matter which border you drag from it always resizes as if you were dragging from bottom right.

I managed the resize from border using custom handles:

but it doesn't matter which border you drag from it always resizes as if you were dragging from bottom right.

I have a big project to expand customization capabilities. But for this it is necessary to change the API. I will create a ticket and link all related tasks to it. Stay tuned ♥

Thanks @cuire amazing work by the way if i have time I'd love to contribute in the future!😋


fix: containerized test are working

A change made a while ago to the container fixture removed by mistake the line running the test function itself, resulting in the test cases not running, yet returning a positive response.
This change fix that.
Issue ticket number and link
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Ran all the tests with failed data to see they are failing as expected, then fixed them and verified the result changed as well.
Checklist:

[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key (if applicable)
[ ] I have updated labels (if needed)

@Omeramsc either rebase this PR or LMK if I can make GitHub do it (Which will make it diverge from your local tracker)

@Omeramsc for next time - if you're using the "update branch" button in GitHub, its better to open the attached menu and select "rebase".


Fix aws authentication issues with assume role

Description
Fix require Externald when not needed #61
Set profile to default when using assume role and user doesnt pass Role name
Update aws sdk to version #64
Issues Resolved
#61
#64
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Hey @ekirmayer thanks for your contribution, the CI checks failed, please try to address them. Thanks

Thanks @ekirmayer.


Examples showing escape characters ""

I've been getting some strange behavior while defining examples. I've defined an example using annotations as follows
@Operation(
            responses = {
                    @ApiResponse(responseCode = "400", description = "Invalid request", content = @Content(
                            schema = @Schema(implementation = FieldViolations.class),
                            examples = {
                                    @ExampleObject(
                                            name = "Bad input",
                                            value = EXAMPLE_VALUE
                                    )
                            }
                    )),
            }
    )

With EXAMPLE_VALUE being defined as
public static final String EXAMPLE_VALUE =
            "{\n" +
            "  \"priority\": \"low\"\n" +
            "}";

I would expect that the example output would look something like this
examples:
  Bad input:
    description: Bad input
    value: "{
                "priority": "low",
            }"

Instead, this is how it is defined
examples:
  Bad input:
    description: Bad input
    value: "{\n  \"priority\": \"low\"\n}"

I am using the swagger-maven-plugin version 2.1.11 to generate definition files and have the plugin defined in the POM as
<plugin>
  <groupId>io.swagger.core.v3</groupId>
  <artifactId>swagger-maven-plugin</artifactId>
  <version>2.1.11</version>
  <configuration>
      <outputFileName>swagger</outputFileName>
      <outputPath>${project.build.directory}/${project.name}-${project.version}</outputPath>
      <outputFormat>JSONANDYAML</outputFormat>
      <prettyPrint>TRUE</prettyPrint>
      <configurationFilePath>${project.basedir}/src/main/resources/swagger-config.yaml</configurationFilePath>
      <alwaysResolveAppPath>true</alwaysResolveAppPath>
      <sortOutput>true</sortOutput>
  </configuration>
  <executions>
      <execution>
          <phase>compile</phase>
          <goals>
              <goal>resolve</goal>
          </goals>
      </execution>
  </executions>
</plugin>

Are the escape characters being in the examples intended? I tried rendering the definition file using Swagger-UI and they don't seem to handle the "\" characters either. I'm wondering if this is intended or if there is a workaround for this.

Hello,
So, what was the answer to this request ?
Thank you :).

The ExampleObject is taking a inline representation of a json string, so you don't need to put the newline character "\n" in it
The correct answer would be : "{" +
""priority":"low"" +
"}"

The ExampleObject is taking an inline representation of a json string, so you don't need to put the newline character "\n" in it The correct answer would be : "{" + ""priority":"low"" + "}"

Thank you for the answer.
And sorry for taking so long to respond.
But, how do I escape the double quotes '"' in my JSON example ?


Adds non randomized rod velocity

About the PR

Changed the check for randomized velocity so non-randomized velocity rods will fire in the direction they're facing when fired.
Why / Balance

Needed for Wizard Rod polymorph
Technical details

Velocity by default will be set to world rotation vec * max speed. If Randomize velocity is enabled, it will behave as it did before.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

OnMapInit for immovable rod system, the check was changed for randomized velocity so if it's not randomized velocity by default will be set to world rotation vec * max speed. If Randomize velocity is enabled, it will behave as it did before.

livrah ops


chore: make prettify also fix changesets

Currently, on a pull request, prettier will test changesets, and ensure they match the desired formatting. It will not, however, fix these changesets when you run prettify. This PR now includes changesets in the prettify command to ensure that they are correct
This issue can be seen in PRs like #2649 , where checks failed based on the changeset file

Awesome thanks!


fix(#135): sanitise  when creating branch

Fixes #135

Current dependencies on/for this PR:

main

PR #136   👈

This stack of pull requests is managed by Graphite.

Merge activity

Jan 15, 8:16 PM: @MartinBernstorff merged this pull request with Graphite.


Support .pcss file extension

Hello.
I've faced a problem: when I had selectors.pcss file with custom selectors and importFrom option — it didn't work, but there were no errors or warnings, nothing. Then I've tried to change file extension to .css — and it started work! And even errors about non-existent files.
So:

I think this plugin should support .pcss file extension (syntax of PostCSS with plugins not always CSS compatible).
There should be errors for "ignored" (non-supported) files (formats, file extensions) which specified in the importFrom option (and maybe somewhere else).

importFrom will be removed in future versions of this plugin as it is a non-standard feature.
Read more about this here : https://github.com/csstools/postcss-plugins/discussions/192


Added installation instructions for Fedora

Thank you for your contribution.  However, I have packaged the dependencies in my copr since a few months ago already, and as of yesterday, the editor itself as well.  What do you think about including instructions on how to use those instead?

I have packaged the dependencies in my copr since a few months ago already, and as of yesterday, the editor itself as well. What do you think about including instructions on how to use those instead?

I think building from source is likely a use case too, but using the copr repo is a nice additional option that we could mention.


Streamline integration tests

How to categorize this PR?

/area dev-productivity
/kind cleanup
What this PR does / why we need it:
Few streamlining in integration tests:

Don't tolerate already existing resources.
From https://github.com/gardener/gardener/blob/master/docs/development/testing.md#writing-integration-tests,

don't tolerate already existing resources (~dirty test environment), code smell: ignoring already exist errors

Streamline logs for test Namespace in tests, sometimes we use project namespace, sometimes we use test namespace etc.

Use a checksum of a random UUID for unique resource names

Reset fakeClock time in BeforeEach()

Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

NONE

/assign

/test pull-gardener-integration

/lgtm


Adding extra file extensions

This pull request is me adding the following file extensions/names:

.desktop
.directory
.menu
_service
_osc
.install

What are these file extensions used for?

.desktop files are desktop configuration files that serve as application launchers on Linux systems. .directory files are identical in their syntax to desktop configuration files, except they specify folders or directories in desktop menus for Linux systems. Both have an INI-type syntax. .menu files are XML files that specify the structure of application menus. _service files are XML service files used by Open Build Service (OBS) to download sources. _osc is a shell script file used by the OBS too. .install files are shell scripts referred to by PKGBUILDs, they perform pre-, post- and peri- install and/or remove actions for their respective Arch package. For example, here's an .install file for the Moksha window manager:
post_install() {
  update-mime-database usr/share/mime > /dev/null
  update-desktop-database -q
}

post_upgrade() {
  post_install
}

post_remove() {
  post_install
}

Are they file extensions or full filenames?
I'm just a little hesitant to add something like _service or _osc as a suffix match, as it would then affect filenames like these:
./notes_on_service
./how_to_service
./room_service

If they're matching full names only, every time, it's probably better not to treat them as extensions:
&[data-name="_service"]

Yeah _service and _osc are the full names of the files, not their extensions so you're right. I just didn't know how to include that name without treating them as extensions.

Looks great, thanks! :+1:


chore: change add to import in files

Notes

I've ran tx pull -a just to update translations, so that's why you see some noise in the files changed. If you want I can rollback it :)

Questions

Is renaming just the label and value enough? Or should I go through the 3 codebases and rename every "addFile", "addFolder", etc.?

Also related with https://github.com/ipfs-shipyard/ipfs-companion/issues/817#issuecomment-621929597


HEIC converter

Description of the new feature / enhancement
high quality converter for HEIC images ... ideally automatic conversions when pictures are downloaded from apple device
Scenario when this would be used?
when pictures are downloaded or sent from apple device
Supporting information
No response

/dup #1934


Run pandas.test() in package tests

Also run the Pandas test suite on the packages produced to improve confidence on the packages shipped.

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Does this test failure ring any bells? Guessing we are missing something, but not sure what
______ ERROR at setup of TestParquetPyArrow.test_s3_roundtrip_explicit_fs ______
file $PREFIX/lib/python3.11/site-packages/pandas/tests/io/test_parquet.py, line 798
      @pytest.mark.single_cpu
      def test_s3_roundtrip_explicit_fs(self, df_compat, s3_resource, pa, s3so):
file $PREFIX/lib/python3.11/site-packages/pandas/tests/io/conftest.py, line 54
  @pytest.fixture(scope="session")
  def s3_base(worker_id):
E       fixture 'worker_id' not found
>       available fixtures: add_doctest_imports, all_arithmetic_functions, all_arithmetic_operators, all_binary_operators, all_boolean_reductions, all_logical_operators, all_numeric_reductions, all_reductions, any_float_dtype, any_int_dtype, any_int_ea_dtype, any_int_numpy_dtype, any_numeric_dtype, any_numeric_ea_dtype, any_numpy_dtype, any_real_numpy_dtype, any_signed_int_ea_dtype, any_signed_int_numpy_dtype, any_skipna_inferred_dtype, any_string_dtype, any_unsigned_int_numpy_dtype, axis, axis_1, axis_frame, box_with_array, box_with_array2, bytes_dtype, cache, capfd, capfdbinary, caplog, capsys, capsysbinary, closed, compare_operators_no_eq_ne, comparison_op, complex_dtype, compression, compression_ext, compression_format, compression_only, configure_tests, datapath, datetime64_dtype, datetime_frame, datetime_series, df_compat, df_cross_compat, df_full, dict_subclass, doctest_namespace, ea_scalar_and_dtype, engine, feather_file, fixed_now_ts, float_ea_dtype, float_frame, float_numpy_dtype, fp, frame_or_series, fsspectest, inclusive_endpoints_fixture, index, index_fixture2, index_flat, index_flat2, index_or_series, index_or_series2, index_or_series_obj, index_or_series_or_array, index_with_missing, indexer_al, indexer_ial, indexer_li, indexer_si, indexer_sl, indexer_sli, int_frame, ip, iris, join_type, jsonl_file, keep, lexsorted_two_level_string_multiindex, mixed_type_frame, monkeypatch, multiindex_dataframe_random_data, multiindex_year_month_day_dataframe_random_data, names, non_dict_mapping_subclass, np_nat_fixture, np_nat_fixture2, nselect_method, nullable_string_dtype, nulls_fixture, nulls_fixture2, object_dtype, object_series, observed, ordered, other_closed, pa, pytestconfig, rand_series_with_duplicate_datetimeindex, record_property, record_testsuite_property, record_xml_attribute, recwarn, s3_base, s3_resource, s3so, salaries_table, series_with_multilevel_index, series_with_simple_index, sort_by_key, spmatrix, strict_data_files, string_dtype, string_series, string_storage, string_storage2, tick_classes, timedelta64_dtype, timezone_aware_date_list, tips_file, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory, tz_aware_fixture, tz_aware_fixture2, tz_naive_fixture, unique_nulls_fixture, unique_nulls_fixture2, using_array_manager, using_copy_on_write, utc_fixture, utc_fixture2, writable
>       use 'pytest --fixtures [testpath]' for help on them.

Does this test failure ring any bells? Guessing we are missing something, but not sure what
______ ERROR at setup of TestParquetPyArrow.test_s3_roundtrip_explicit_fs ______
file $PREFIX/lib/python3.11/site-packages/pandas/tests/io/test_parquet.py, line 798
      @pytest.mark.single_cpu
      def test_s3_roundtrip_explicit_fs(self, df_compat, s3_resource, pa, s3so):
file $PREFIX/lib/python3.11/site-packages/pandas/tests/io/conftest.py, line 54
  @pytest.fixture(scope="session")
  def s3_base(worker_id):
E       fixture 'worker_id' not found
>       available fixtures: add_doctest_imports, all_arithmetic_functions, all_arithmetic_operators, all_binary_operators, all_boolean_reductions, all_logical_operators, all_numeric_reductions, all_reductions, any_float_dtype, any_int_dtype, any_int_ea_dtype, any_int_numpy_dtype, any_numeric_dtype, any_numeric_ea_dtype, any_numpy_dtype, any_real_numpy_dtype, any_signed_int_ea_dtype, any_signed_int_numpy_dtype, any_skipna_inferred_dtype, any_string_dtype, any_unsigned_int_numpy_dtype, axis, axis_1, axis_frame, box_with_array, box_with_array2, bytes_dtype, cache, capfd, capfdbinary, caplog, capsys, capsysbinary, closed, compare_operators_no_eq_ne, comparison_op, complex_dtype, compression, compression_ext, compression_format, compression_only, configure_tests, datapath, datetime64_dtype, datetime_frame, datetime_series, df_compat, df_cross_compat, df_full, dict_subclass, doctest_namespace, ea_scalar_and_dtype, engine, feather_file, fixed_now_ts, float_ea_dtype, float_frame, float_numpy_dtype, fp, frame_or_series, fsspectest, inclusive_endpoints_fixture, index, index_fixture2, index_flat, index_flat2, index_or_series, index_or_series2, index_or_series_obj, index_or_series_or_array, index_with_missing, indexer_al, indexer_ial, indexer_li, indexer_si, indexer_sl, indexer_sli, int_frame, ip, iris, join_type, jsonl_file, keep, lexsorted_two_level_string_multiindex, mixed_type_frame, monkeypatch, multiindex_dataframe_random_data, multiindex_year_month_day_dataframe_random_data, names, non_dict_mapping_subclass, np_nat_fixture, np_nat_fixture2, nselect_method, nullable_string_dtype, nulls_fixture, nulls_fixture2, object_dtype, object_series, observed, ordered, other_closed, pa, pytestconfig, rand_series_with_duplicate_datetimeindex, record_property, record_testsuite_property, record_xml_attribute, recwarn, s3_base, s3_resource, s3so, salaries_table, series_with_multilevel_index, series_with_simple_index, sort_by_key, spmatrix, strict_data_files, string_dtype, string_series, string_storage, string_storage2, tick_classes, timedelta64_dtype, timezone_aware_date_list, tips_file, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory, tz_aware_fixture, tz_aware_fixture2, tz_naive_fixture, unique_nulls_fixture, unique_nulls_fixture2, using_array_manager, using_copy_on_write, utc_fixture, utc_fixture2, writable
>       use 'pytest --fixtures [testpath]' for help on them.

Yeah I believe this would need pytest-xdist installed for this to work (or else we don't have this exactly correct for working running this locally). Here's what we install for our CI runs
https://github.com/pandas-dev/pandas/blob/018967465f2b8994041b8e220118078682c08e63/ci/deps/actions-38.yaml#L12-L17

Gotcha. Have gone ahead and included those.

Looks some tests are due to our high memory tests
Could you augment the pd.test call as pd.test(extra_args=["-m not clipboard and not single_cpu", "--skip-slow", "--skip-network", "--skip-db", "-n=2"])?

Thanks Matthew! 🙏
Pushed a change along these lines.

E   AssertionError: Series are different
E
E   Series values are different (42.85714 %)
E   [index]: [0, 1, 2, 3, 4, 5, 6]
E   [left]:  [nan, 7.071067811865475e+16, 0.0, 0.0, 0.0, 0.0, 0.0]
E   [right]: [nan, 7.071068e+16, 0.7071068, 0.0, 0.7071068, 1.414214, 0.0]

pandas/_libs/testing.pyx:167: AssertionError

So I am not confident that the test are being correctly skipped as I am seeing these test warnings
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.9/site-packages/pandas/tests/io/test_html.py:375
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.9/site-packages/pandas/tests/io/test_html.py:375
  $PREFIX/lib/python3.9/site-packages/pandas/tests/io/test_html.py:375: PytestUnknownMarkWarning: Unknown pytest.mark.slow - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    @pytest.mark.slow

We define these markers in pyproject.toml so I'm not sure if the tests running here are aware of the markers defined there

Thanks Matthew! 🙏
Let's see if @jorisvandenbossche has any other thoughts 🙂

Anything else needed here?

Thanks Matthew and Joris! 🙏
Merging this in so we get some level of testing going forward. Happy to follow up though if other things are needed


eat-api Version 2

The eat-api will change its API to version 2 with support for the new unit based pricing system.
All changes can be found here:
PR: https://github.com/TUM-Dev/eat-api/pull/12
When does it change?
01.01.2020

I'm guessing this bug is fixed and can be closed?

I'm guessing this bug is fixed and can be closed?


fix can't detect objects with euclidean_cluster on 96boards in V1.8 #…

Status
DEVELOPMENT
Description
fix issue 1532
don't get clusters/objects on V1.8
Related PRs
List related PRs against other branches:

branch
PR

fix/euclidean_cluster_96boards
1532

Todos

[ ] Tests

Steps to Test or Reproduce

play a bag
select eculidean_cluster detector
check with topic /bounding_boxes and rviz

@aicarmark Is this PR still valid?


[2023 API call Social media Quarterly reminders] Marketing

Yearly Spreadsheet Media Inventory
Media Description
#MicroProfileMarketing highlights @MicroProfileIO around the world. It looks for #OSSContributors wishing to brainstorm new ideas, simplify processes, create and maintain effective communication messages, etc. Join its bi-monthly Monday discussions  #OSS
https://bit.ly/calendar-zoom-minutes
Quarterly reminder
1 every quarter
Ideally, a reminder goes out 4 times per year, always on a Monday before the call.
Design Card
Highlight Monday,
Every other Monday
10 to 11 AM PDT
Notes

nice

Scheduled


Possible issue with decoding subnormals

On simd-json.rs we discovered that -5.96916642387374e-309 which is a valid representable floating point number couldn't get parsed. I suspect the same issue exists in simdjson.
I'll add a (possibly failing) test case and if required a fix to it later when I get around to it but  wanted to throw in an issue to keep track of it.
The change was to extend the exponent rage to 1e-323.

What DBL_MIN for you?
I think it should be...
2.2250738585072014e-308
My suspicion is that you are going into the subnormals.

In Rust what is f64::MIN_POSITIVE?

The problem comes from how it is parsed -5.96916642387374e-309 is parsed as<PHONE_NUMBER>87374e-323 (if I didn't miscount) and 1e-323 is still represented correctly

re-reading the current state of the c++ code I am wrong, the location the check happens moved since I translated it to rust :) so simdjson doens't have the same problem!

Did you try to write a test? If not, I will...

I changed the title from very small to subnormal. I think subormal is more than just very small.

I've not been on a workable computer yet, I'll add one when I get home tonight, kind of don't want to do it over the web interface :D

No worries, I will check it in. It just just one new file to create.

Let us test it out: https://github.com/lemire/simdjson/pull/328

I merged the check and it looks fine. Please reopen if you think that the issue is still there.


Add doctests to Github CI

Objective

Test documentation examples with the Github CI too.

Solution

Add a separate step for doctests in valence-tests.

--doc seems to be mutually exclusive with all other targets
https://github.com/rust-lang/cargo/issues/6669 relevant.

61f22798 is the commit that introduced the failing doc tests.

I'd prefer if we fixed those first.

On it.


Updated dependencies, moved to SpeedTools 3.2.4.

Coverage remained the same at 72.151% when pulling 30d8f02397c350185c5d3ec198a5bead00f33f2f on dev into 6fca5a4c4c5821012d03c5740dcefc9ba14db598 on master.


docs: Updated README with information about the authentticators

BREAKING CHANGE: this release introduces a new authentication scheme

tagged @dpopp07 and @mediumTaj mainly for awareness about the readme/authentication updates

Pushed an amended commit with the requested updates


Panic in dubb writer after close: nil dereference

Unsure yet what's causing this. Need to look into it, but appears to happen after closing, which should be a nop instead of dereferencing nil.
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x107378]

goroutine 1 [running]:
panic(0x1dd0e0, 0xc82000c120)
        /usr/local/Cellar/go/tip/src/runtime/panic.go:500 +0x18c
go.spiff.io/dagr/outflux/internal/dubb.(*Buffer).writer(0x0, 0x253c8780b31)
        /Users/ncower/go/src/go.spiff.io/dagr/outflux/internal/dubb/buffer.go:236 +0x18
go.spiff.io/dagr/outflux/internal/dubb.(*Buffer).Write(0x0, 0xc820111e1d, 0x0, 0xffe3, 0xc820111da8, 0xe901, 0x725230)
        /Users/ncower/go/src/go.spiff.io/dagr/outflux/internal/dubb/buffer.go:253 +0x21
go.spiff.io/dagr/outflux.(*Proxy).Write(0xc8200127d0, 0xc820111e1d, 0x0, 0xffe3, 0x1, 0x0, 0x2fe840)
        /Users/ncower/go/src/go.spiff.io/dagr/outflux/outflux.go:132 +0x47
main.(*porthole).Listen(0xc820010800, 0x2fe840, 0xc82019a0a0)
        /Users/ncower/go/src/go.spiff.io/janus/janus.go:111 +0x316
main.main()
        /Users/ncower/go/src/go.spiff.io/janus/janus.go:164 +0x1c3

dubb has been removed, but this is likely an error in the Proxy or Proxy usage. dubb just happened to be the thing to hit the nil deref first.


cannot re-use a name that is still in use

Describe the bug
cannot re-use a name that is still in use
FATA[0000] 1 error occurred:
  * cannot re-use a name that is still in use

** General info (please complete the following information):**

Helmwave 0.12.7

Expected behavior
deploy

fix in #151


missing catch or finally after try

Describe the bug
After click on download, it show "missing catch or finally after try"
To Reproduce
Steps to reproduce the behavior:

paste YT link.'
Click on 'download'
See error

Add logs from DevTools
Please go to y2mp3 menu -> Toggle Developer Tools or hit ctrl+Alt+j (on windows) or
⌘+⌥+j (on mac), if there are error messages please include them.
SyntaxError: Missing catch or finally after try
at new Script (node:vm:100:7)
at Object.t.decipherFormats (file:///C:/Users/Night/AppData/Local/Programs/y2mp3/resources/app.asar/resources/app.bundle.js:2:1430236)
at runMicrotasks ()
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async Promise.all (index 0)
at async t.getInfo (file:///C:/Users/Night/AppData/Local/Programs/y2mp3/resources/app.asar/resources/app.bundle.js:2:1427178)

Expected behavior
The Video or audio file didn't download
Screenshots
If applicable, add screenshots to help explain your problem.

OS: Windows
Version 10 Pro
App Version v2.5.8

Additional context
Add any other context about the problem here.

What's the url you are trying to download?

https://www.youtube.com/watch?v=52fGG37_0_E
i also try on other url, it show the same error

Seems like it's a problem with the downloading package which affects windows devices
Can you try the pre-release version please?

It's a problem with one of the core packages
https://github.com/fent/node-ytdl-core/issues/1204
Please try the following version: https://github.com/moshfeu/y2mp3/releases/tag/v2.5.9-alpha

It's working now. thx =D


Cut Reviewable boilerplate from commit messages

This change is

Thanks! :heart:
bors r+

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Travis CI: Upgrade to Python 3.7 production release

Upgrade Python 3.7 from pre-release to production release in alignment with travis-ci/travis-ci#9069  @bdbaddog
http://scons.org/guidelines.html
Contributor Checklist:

[ ] I have created a new test or updated the unit tests to cover the new/changed functionality.
[ ] I have updated master/src/CHANGES.txt directory (and read the README.txt in that directory)
[ ] I have updated the appropriate documentation

@bdbaddog The tests did not pass!

That's fine. It's a "new" platform.
PR's to fix the issues are welcome.


Version 1.7.1 — unable to start sidekiq

On Ruby 2.2.7, Ubuntu 16.04, we are seeing the following with 1.7.1.
❯ be sidekiq-pool -C config/sidekiq-pool.yml
2018-06-12T18:48:12.281Z 31042 TID-ow2lr5o32 INFO: Starting new pool
2018-06-12T18:48:41.725Z 31042 TID-ow2lr5o32 INFO: Adding child with args: (-g homebase.default -q default,10 -q critical,20 -q low,1 -c 10) in , waiting for busy: true
2018-06-12T18:48:41.729Z 31042 TID-ow2lr5o32 INFO: Waiting for child 31234 to be busy break in 29
/Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/lib/sidekiq/pool/cli.rb:280:in `run_after_fork_hooks': undefined method `after_fork_hooks' for Sidekiq::Pool:Module (NoMethodError)
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/lib/sidekiq/pool/cli.rb:214:in `block in fork_child'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/lib/sidekiq/pool/cli.rb:199:in `fork'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/lib/sidekiq/pool/cli.rb:199:in `fork_child'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/lib/sidekiq/pool/cli.rb:75:in `block (2 levels) in start_new_pool'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/lib/sidekiq/pool/cli.rb:73:in `times'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/lib/sidekiq/pool/cli.rb:73:in `block in start_new_pool'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/lib/sidekiq/pool/cli.rb:72:in `each'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/lib/sidekiq/pool/cli.rb:72:in `start_new_pool'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/lib/sidekiq/pool/cli.rb:28:in `run'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/bin/sidekiq-pool:10:in `<top (required)>'
	from /Users/kig/.rbenv/versions/2.2.7/bin/sidekiq-pool:23:in `load'
	from /Users/kig/.rbenv/versions/2.2.7/bin/sidekiq-pool:23:in `<top (required)>'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/bundler-1.15.4/lib/bundler/cli/exec.rb:74:in `load'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/bundler-1.15.4/lib/bundler/cli/exec.rb:74:in `kernel_load'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/bundler-1.15.4/lib/bundler/cli/exec.rb:27:in `run'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/bundler-1.15.4/lib/bundler/cli.rb:362:in `exec'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/bundler-1.15.4/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/bundler-1.15.4/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/bundler-1.15.4/lib/bundler/vendor/thor/lib/thor.rb:387:in `dispatch'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/bundler-1.15.4/lib/bundler/cli.rb:22:in `dispatch'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/bundler-1.15.4/lib/bundler/vendor/thor/lib/thor/base.rb:466:in `start'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/bundler-1.15.4/lib/bundler/cli.rb:13:in `start'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/bundler-1.15.4/exe/bundle:30:in `block in <top (required)>'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/bundler-1.15.4/lib/bundler/friendly_errors.rb:121:in `with_friendly_errors'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/bundler-1.15.4/exe/bundle:22:in `<top (required)>'
	from /Users/kig/.rbenv/versions/2.2.7/bin/bundle:23:in `load'
	from /Users/kig/.rbenv/versions/2.2.7/bin/bundle:23:in `<main>'

As a result, sidekiq-pool comes up, but sidekiq processes keep dying and respawning indefinitely.
After looking into this error, it appears that the method run_after_fork_hooks has been added into lib/sidekiq/pool.rb with 1.7.1. but pool.rb is not required from lib/sidekiq/pool/cli.rb (which is the only file required by the executable).
After adding a missing reqiure to cli.rb, I got another error:
2018-06-12T18:53:04.541Z 33281 TID-owdrdtn59 INFO: Waiting for child 33467 to be busy break in 29
/Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/lib/sidekiq/pool/cli.rb:281:in `run_after_fork_hooks': undefined method `each' for nil:NilClass (NoMethodError)
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/lib/sidekiq/pool/cli.rb:215:in `block in fork_child'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/lib/sidekiq/pool/cli.rb:200:in `fork'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/lib/sidekiq/pool/cli.rb:200:in `fork_child'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/lib/sidekiq/pool/cli.rb:76:in `block (2 levels) in start_new_pool'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/lib/sidekiq/pool/cli.rb:74:in `times'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/lib/sidekiq/pool/cli.rb:74:in `block in start_new_pool'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/lib/sidekiq/pool/cli.rb:73:in `each'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/lib/sidekiq/pool/cli.rb:73:in `start_new_pool'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/lib/sidekiq/pool/cli.rb:29:in `run'
	from /Users/kig/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/sidekiq-pool-1.7.1/bin/sidekiq-pool:10:in `<top (required)>

And this is when I gave up, and reverted to 1.7.0 that works like a charm.
Thanks!

@kigster thank you for the report. Added a fix and releases 1.7.2 version.

👍🏽


⚠ Secret Website 3 has degraded performance

In 43b541c, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 3715 ms

Resolved: Secret Website 3 performance has improved in 1a34483.


adds missing smoke text fixture for Projects

Since we changed the name of this entity (from spaces to project), whenever I run these commands:
npm run app-build:smoke
npm run test:smoke:build

I added this file in https://github.com/Kong/insomnia/commit/c3f92d0603aeb82cd0de672974d8ad1465c2f26f during the initial conversion and @develohpanda removed it in https://github.com/Kong/insomnia/commit/ef8168bcef8c601a2afe8ff3682fef8ba1643ea3.  I can't see where that discussion happened but my recollection was that the thinking was that it doesn't matter since it'll just be created on the CI.  However, I frequently run the smoke tests locally and I'd like to not have to continually clean up this file after every run.

we should add fixtures/basic-designer to .gitignore so that no new changes will be committed.

why?  I don't see the harm in leaving the correct files here on disc.  In fact, I'd kinda like to know if something changes in the future to make sure it's expected.

This fixture is representing the last supported state of the Insomnia Designer database.

Ok ,so maybe this is an answer to the "why" from above?  If you remove the fixtures altogether it almost works: (2 of 11 pass)
[app]
[app] ><EMAIL_ADDRESS>spectron:build /home/dimitri/src/github.com/Kong/insomnia/packages/insomnia-smoke-test
[app] > cross-env BUNDLE=build xvfb-maybe jest --detectOpenHandles --testPathPattern core
[app]
[server]
[server] ><EMAIL_ADDRESS>serve /home/dimitri/src/github.com/Kong/insomnia/packages/insomnia-smoke-test
[server] > ts-node server/index.ts
[server]
[app] watchman warning:  Recrawled this watch 9 times, most recently because:
[app] dir missing from internal stateTo resolve, please review the information on
[app] https://facebook.github.io/watchman/docs/troubleshooting.html#recrawl
[app] To clear this warning, run:
[app] `watchman watch-del /home/dimitri/src/github.com/Kong/insomnia ; watchman watch-project /home/dimitri/src/github.com/Kong/insomnia`
[app]
[server] Listening at http://localhost:4010
[app]  FAIL  core/migration.test.ts (32.646 s)
[app]   ● Migration › can skip migration and proceed onboarding
[app]
[app]     waitUntilTextExists waitUntil condition timed out after 10000ms
[app]
[app]       at node_modules/webdriverio/build/commands/browser/waitUntil.js:24:19
[app]       at Browser.wrapCommandFn (node_modules/@wdio/utils/build/shim.js:63:29)
[app]       at Browser.waitUntilTextExists (node_modules/@wdio/utils/build/shim.js:63:29)
[app]
[app]   ● Migration › can migrate and proceed onboarding
[app]
[app]     waitUntilTextExists waitUntil condition timed out after 10000ms
[app]
[app]       at node_modules/webdriverio/build/commands/browser/waitUntil.js:24:19
[app]       at Browser.wrapCommandFn (node_modules/@wdio/utils/build/shim.js:63:29)
[app]       at Browser.waitUntilTextExists (node_modules/@wdio/utils/build/shim.js:63:29)
[app]
[app]  PASS  core/app.test.ts (72.117 s)
[app]
[app] Test Suites: 1 failed, 1 passed, 2 total
[app] Tests:       2 failed, 1 skipped, 8 passed, 11 total
[app] Snapshots:   0 total
[app] Time:        104.819 s
[app] Ran all test suites matching /core/i.
[app] Failed with exit code: 1
[app] Output:
[app]
[app] npm ERR! code ELIFECYCLE
[app] npm ERR! errno 255
[app] npm ERR<EMAIL_ADDRESS>spectron:build: `cross-env BUNDLE=build xvfb-maybe jest --detectOpenHandles --testPathPattern core`
[app] npm ERR! Exit status 255
[app] npm ERR!
[app] npm ERR! Failed at the<EMAIL_ADDRESS>spectron:build script.
[app] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[app]
[app] npm ERR! A complete log of this run can be found in:
[app] npm ERR!     /home/dimitri/.npm/_logs/2021-09-16T19_21_58_979Z-debug.log

It's going to fall further and further out of sync, but the migration smoke tests will ensure that from this last known state of the Designer database we can always migrate into Core.

Ok, so I think I better understand by this point in your response.  Is the answer here because these fixtures are intended to be from the database state from designer?  If so, why does the change that add a new file?  Because of the migration?
To quote from the git docs:

A gitignore file specifies intentionally untracked files that Git should ignore.

but it continues:

Files already tracked by Git are not affected

So, and my testing confirms this, simply adding fixtures to a /packages/insomnia-smoke-test/.gitignore does not stop git from tracking further changes on these files because git is already tracking these files and will continue to do so until they are removed.  Granted, new files will not be tracked.  So.. in effect it does (almost by accident?) fix the problem.  But this also means that changes to any of the existing files will still be tracked.  What to do...
Well... all the same, since what you suggested does solve my immediate issue it's better than nothing.  I did 367028261fd58dc2b1f43b244768428e3aa2b6b6.  However, it'd be cool if we had some other way to do this with git.  Lemme know your thoughts.  Hopefully the above is coherent enough to make sense.

this is being done as part of https://github.com/Kong/insomnia/pull/4049


Webchat UI does not scale appropriately on iPhones

Webchat UI components do not scale well on iPhone devices: the message boxes are small, the font of the messages is tiny and the input box is very narrow, which makes it hard to interact with it using fingers.
This is what I see on iPhone 6 (the behavior on iPhone X is similar, but even worse):

Is this in a native WebView. or an Iframe?

also, make sure you are using a mobile meta-tag: https://github.com/Microsoft/BotFramework-WebChat/issues/537#issuecomment-314180249

This surfaces in a native WebView. meta-tag helped, thank you!

That's great. I will close this for now.


Provides a manage command to manually update solr schema

this will need to be harmonized with the work on #3

Working in qa for s&co


androidx support

please update for android x support

Are you sure it gives problem? I'm testing it


Fix typo in error code for duplicate entry

Codecov Report
Patch coverage has no change and project coverage change: -0.35 :warning:

Comparison is base (15d3ac9) 78.45% compared to head (750a798) 78.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   78.45%   78.11%   -0.35%
==========================================
  Files          17       17
  Lines        4373     4373
  Branches      987      951      -36
==========================================
- Hits         3431     3416      -15
- Misses        711      723      +12
- Partials      231      234       +3

Impacted Files
Coverage Δ

myhoard/restore_coordinator.py
77.64% <0.00%> (-0.67%)
:arrow_down:

... and 3 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Support exact options for #has_select?

How about having the possibility to match the exact group of options for a select element?
Maybe the same could apply to the ones selected...

Uhh, that already exists.

You can find this, unsurprisingly in the documentation for has_select?, http://rubydoc.info/github/jnicklas/capybara/Capybara/Node/Matchers#has_select%3F-instance_method

I was talking about being able to provide an option with the exact option you want to be matched, not a subset of them. Aren't they working that way now?

Are there any plans to support something like :with_selected for a partial match?


Bookmark - Add capability to save as bookmark  on a  new query inside the query tool

Add new:  the capability to save as bookmark on a new query

Update from John:  for the time being, work on this enhancement is going to be put on hold, there are other code changes that may have a significant impact on this feature

Should now create a bookmark when checkbox is selected inside the query tool dialog.

I do not see a pull request for this?

Bookmarks should not be created on 'data.finish'. This means that 1. The bookmark is only created IF the query finishes 2. Even if the query will finished, the user has to wait for the query to finish to use it 3. (the big issue) Try this:
-Run a big query where you try to save the bookmark in the query tool
-Before it finishes, open the query tool and make sure that the 'Save as Bookmark' checkbox is off (defaulted that way)
-Wait for the original query to finish
Result: The original query is not saved because the checkbox is now not checked
The bookmark should be save as soon as the query is run, in the $submitButton.click() block. You will have all of the info you need there, and is the fastest and safest way to do it.

closing this issue


Able to merge in UTF-8 supporting fork of Linenoise into our version?

See here:
https://github.com/yhirose/linenoise/tree/utf8-support
Would be great if we had UTF-8 support for this, as it's really an issue especially for a programming language that can use Unicode characters.

UTF-8 support would be fantastic!  I worked on this a little bit last year, but I don't remember which stumbling blocks I encountered that prevented me from finalizing the work.  I'm on vacation right now, but I'll have a look after I get back.

Another fork worth looking at: https://github.com/arangodb/linenoise-ng

Other work in this area:

https://github.com/antirez/linenoise/pull/27
https://github.com/antirez/linenoise/issues/25

(Note to self: look at journal entries for late March/early April 2016)

Another fork to consider incorporating (not UTF-8 related, but still): https://github.com/antirez/linenoise/issues/113

linenoise-ng supposedly has Windows support. That would be really awesome :) Then we can support UTF-8 and all operating systems!

@samcv I added support in the multi-byte branch - I can't merge this until LibraryMake provides a C++ equivalent to CC and other Makefile.in variables, though.  I'm currently using some GCC-specific build flags to get it working on Linux, but it won't work on Windows (unless GCC is used there too)

Are the requirements from LibraryMake available now?
If not, how can I point my project to use the multi-byte version of this?  I've tried to clone the repository and build it myself, but there are no "build from source" instructions and I was unable to figure it out on my own.
Thanks!

@mcreenan I just took a quick look at the LibraryMake source - from what I can tell, sadly, that information is still not available =(
If you're using GCC, cloning the repository and doing a zef install . should just work - let me know if it doesn't.  If you're willing to put in the time, the C++ code could be ported to straight up C, and then I could merge the branch into master!

Ah. zef install . did work after I uninstalled the published version.  Thanks!
I'll look into porting, but I haven't done C or C++ in 10+ years.


How do I make validation fail if a claim is not present at all?

So if a claim is present, I can use my own validation function to accept or reject based on the value. Cool. But if the claim isn't present at all, then verify_and_validate says the token is valid, because there was no input to run the validation function on, therefore the validation never failed? How do I make a claim required?
In my application Joken is only used for validation, with another service written in another language doing token generation. Taking a black box approach to the other service, if I can't enforce that the claims are added during token generation, I must check that they are present during validation instead.
I have reduced my problem down to this minimal example, with two passing tests and one failing. I used sub as an example here, but it goes for all types of claim really:
defmodule TokenTest do
  use DataCase

  defmodule ProperToken do
    use Joken.Config

    @impl true
    def token_config do
      %{}
      |> Joken.Config.add_claim("sub", fn -> nil end, fn val, _, _ -> val == true end)
    end
  end

  defmodule EmptyToken do
    use Joken.Config

    @impl true
    def token_config, do: %{}
  end

  describe "dummy tokens rejected" do
    test "accept token with sub true" do
      signer = Joken.Signer.create("HS256", "a key")

      {:ok, token, _} = EmptyToken.generate_and_sign(%{"sub" => true}, signer)

      {:ok, _} = ProperToken.verify_and_validate(token, signer)
    end

    test "reject token with sub false" do
      signer = Joken.Signer.create("HS256", "a key")

      {:ok, token, _} = EmptyToken.generate_and_sign(%{"sub" => false}, signer)

      {:error, _} = ProperToken.verify_and_validate(token, signer)
    end

    test "reject token with no sub" do
      signer = Joken.Signer.create("HS256", "a key")

      {:ok, token, claims} = EmptyToken.generate_and_sign(%{}, signer)

      # ok
      assert "sub" not in Map.keys(claims)

      # MatchError
      {:error, _} = ProperToken.verify_and_validate(token, signer)
    end
  end
end

Hi @mathiasose ! There is an enhancement to Joken to pass options and one of them will certainly be to tell if a claim is mandatory.
Meanwhile, you can use an after validate hook to do exactly that. It would look something like this:
defmodule MyExternalServiceToken do
  use Joken.Config

  @impl true
  def token_config do
    # your validations for known claims
  end

  @impl Joken.Hooks
  def after_validate(_, {:ok, claims} = result, input) do
    # validate claim presence only
  end
  def after_validate(_, result, input), do: {:cont, result, input}
end

See documentation for hooks here.
If this works for you I'll close the issue, ok?

Thanks! This is what I came up with, which works for my tests cases:
  @required_claims MapSet.new(["sub", "aud", "exp", "iat", "nbf"])

  @impl Joken.Hooks
  def after_validate(_, {:ok, claims} = result, input) do
    claims =
      claims
      |> Map.keys()
      |> MapSet.new()

    @required_claims
    |> MapSet.subset?(claims)
    |> case do
      true ->
        {:cont, result, input}

      _ ->
        diff = MapSet.difference(@required_claims, claims) |> MapSet.to_list()
        {:halt, {:error, [message: "Invalid token", missing_claims: diff]}}
    end
  end

  def after_validate(_, result, input), do: {:cont, result, input}

There is an enhancement to Joken to pass options and one of them will certainly be to tell if a claim is mandatory.

Is this enhancement somewhere? I looked through the open PRs and recent commits and do not see it. I think all claims should be required by default and only opt in to making them optional. Seems to better follow the principle of 'secure by default'

Hi @jsmestad ! Just seen your comment. Sorry for not commenting earlier.
I am thinking of a release plan to add that behaviour...

Add the hook to Joken 2.x series and document it.
Change the default behaviour and add parsing of claims options on 3.x series

Since this is a breaking change (in behaviour and not API) I think this is safer. What do you think? I am reopening this issue until we sort it out.

I will release a minor version with the first step on this. Then we can think of what we want for version 3.x.
I'll open an issue about a possible version 3.x.


Update biomodels download URL

The previous EBI link stopped working, which was breaking the unit
tests. I've updated it to the Caltech mirror.

Coverage remained the same at 76.562% when pulling 3643b3fa12df83f42a34718e45ed82ca58ecee32 on alubbock:biomodels_url into f78619c0978e6a3dcec762e0b28c67410ec97fc7 on pysb:master.

Seems to be working now... Do we believe the Caltech mirror is going to be more stable than the EBI one, in the long term?

Actually I just realized the solution for the tests is to mock out the biomodels download. We don't need to test that the biomodels website is working, we only need to test our code that sends the request and parses the response.

Coverage increased (+0.01%) to 76.574% when pulling 03575926ee74d747a8e131c4e8224042be651508 on alubbock:biomodels_url into f78619c0978e6a3dcec762e0b28c67410ec97fc7 on pysb:master.

I added both Biomodels mirrors as a switchable option, and used a mock to use a local SBML file from BioNetGen for the unit tests.

Coverage increased (+0.02%) to 76.584% when pulling b28b9839036d1c0ff3375c1d6a2b6ed0c244edfc on alubbock:biomodels_url into f78619c0978e6a3dcec762e0b28c67410ec97fc7 on pysb:master.


No Textures Glitch

No textures been loading, how to even add USD file textures??

Image textures just dont apply at all into the map, its just a white material with no nodes.

Hi! MiEx by default uses MaterialX for the materials (which comes with USD by default). It uses this in order to be able to support biome colours and animated textures. Unfortunately, Blender does not support MaterialX. In the latest release ( https://github.com/BramStoutProductions/MiEx/releases/tag/v1.2.2 ) MiEx now comes with an extra resource pack called UsdPreviewSurface. If you enable that, MiEx will create UsdPreviewSurface materials instead of MaterialX materials. Blender can import UsdPreviewSurface.
Unfortunately, UsdPreviewSurface doesn't allow me to handle biome colours or animated textures, so you'd have to fix the materials after importing. The biome colours are still available as vertex colours, which you can access with the Color Attribute node. You'd want the Cd color attribute. You multiply this with the texture in order to get the tinted version. Animating the textures is more difficult. You'd need to scale up the UVs so that it only shows a single frame and then animate the offset using an expression.
Please let me know if the latest version using the UsdPreviewSurface resource pack enabled works better!

About virus things browsers saying, is this a false flag?

It is indeed a false flag. I don't really know what's triggering it. I'm not getting it myself.

It is indeed a false flag. I don't really know what's triggering it. I'm not getting it myself.

Also after using MiEx my computer just slowed down, with ranging from 2 minutes to 4 minutes, weird freezes happening in my computer and more, is this normal?

It's normal for it to slow down your computer while you're actively using it, because MiEx uses many cores to speed up loading worlds and exporting worlds. But it should not slow down your computer after MiEx has been closed! The only thing that I can think of is maybe anti-virus going through the USD files that it created or the base_resource_pack files which it extracts from your Minecraft install. Those can be quite a lot of files, which could maybe take a bit for your anti-virus to check. But the anti-virus shouldn't be checking all of that anyways, so I'm not sure what's exactly going on.
But I'm not getting any of that myself (I am using Windows Defender), so it would be difficult for me to reproduce this slowing down. Could you check in Task Manager which processes are using up a lot of your CPU and Disk?

It's normal for it to slow down your computer while you're actively using it, because MiEx uses many cores to speed up loading worlds and exporting worlds. But it should not slow down your computer after MiEx has been closed! The only thing that I can think of is maybe anti-virus going through the USD files that it created or the base_resource_pack files which it extracts from your Minecraft install. Those can be quite a lot of files, which could maybe take a bit for your anti-virus to check. But the anti-virus shouldn't be checking all of that anyways, so I'm not sure what's exactly going on.
But I'm not getting any of that myself (I am using Windows Defender), so it would be difficult for me to reproduce this slowing down. Could you check in Task Manager which processes are using up a lot of your CPU and Disk?

No process using my CPU except Discord and Chrome.


Problem saving parallel experiment to resultsdb

What is the current behavior?
Qubit indexes are encoded wrongly for saving a parallel experiment. This is the problem line in composite_analysis.py:
device_components=[Qubit(qidx) for qidx in sub_qubits],
It can be fixed with
device_components=[Qubit(qidx[0]) for qidx in sub_qubits],
Steps to reproduce the problem
When trying to save a parallel experiment right now, the error output is:
{"errors":["Invalid components for device ibm_nairobi: Q(0,),Q(2,)"]}
@yaelbh I don't know if this should go into #115 or done in a separate PR.

For another reason (addressing Chris' comments), I changed the code that you're pointing here. Can you please check again the current status?

It's working now, thank you!


Fixed ipmo error message and links in README.md

Fixed broken link in README due to master -> main
Fixed blank error message from the Import-Module call for the ModulesToImport key. $error seemed to be null at that point so I just changed it to reference psitem instead, seems to work.
I didn't bump the version number because I wasn't sure if it was still required? When I ran build.ps1 it read from somewhere what the latest already was (presumably the gallery?) and just bumped it by one. So I left it as 0.6.0 in the manifest.

Question ... In the CONTRIBUTING.md file you provide a snippet to put in our profiles. You suggest we can open our console's working directory to be of the git/project directory from within our editor (presumably vscode). How do I do this in vscode?
Regardless I did make the below as I was testing just by right clicking in File Explorer while holding shift and chose Open PowerShell window here... (Windows PowerShell 5.1). But that is when I learnt the current working directory is C:\Windows while the profile loads via this method, so the relative reference to .\BuildOutput\PSProfile is not true at that point. So not only is the below fugly as hell, but also a waste of time in hindsight lol. Ping me on Discord if it doesn't make sense.
$PSProfileBuildOutput = Get-ChildItem '.\BuildOutput\PSProfile' -ErrorAction SilentlyContinue

$module = if ($PSProfileBuildOutput) {
    $PSProfileBuildOutput | Sort-Object -Property CreationTime | Select-Object -First 1 | ForEach-Object {
        try {
            Import-Module $_ -ErrorAction Stop
        }
        catch {
            Write-Warning "Error(s) when importing PSProfile from the BuildOutput folder:`n$($Error[0])`nFalling back to installed version"
            Import-Module PSProfile
        }
    }
}
else {
    Import-MOdule PSProfile
}

Regarding the profile snippet in CONTRIBUTING.md, I think that might be moot at this point, but I'll definitely review and clean it up as needed. Trying to digest your question around VSCode more, as that's what I'm using for 99% of my IDE work


Titles on mobile appear too large

The font for the titles is too large (breaking the title up at times)

Fixed via 609aba009179f379a83fbe73c5dfb18dacaccbc1


Update format_pr.yml

Codecov Report
Base: 84.18% // Head: 84.18% // No change to project coverage :thumbsup:

Coverage data is based on head (22cc25e) compared to base (72a3ee9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   84.18%   84.18%
=======================================
  Files          21       21
  Lines        1043     1043
=======================================
  Hits          878      878
  Misses        165      165

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/110791

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/111744

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/112592

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/113586

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/114600

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/117054

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/118830

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/120450

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/121044

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/121475


Merge refs/heads/master into alpha

Merge refs/heads/master into alpha

This PR has been merged into alpha and tagged as 2.0.0-alpha-202308211416. Thanks for your contribution!


Chart inside UICollectionViewCell is not fitting

Hi
I am displaying chart in UICollectionViewCell on a subview and setting the chartframe as cell.subview.bounds but it doesn't fit in that subview.
It's having  chartSize = (width = 183, height = 55)
chartInnerFrame = (origin = (x = 41.35302734375, y = 10), size = (width =<PHONE_NUMBER>5625, height = -10.649999999999999))
Does chartInnerFrame have to do something with this, because it is not drawing the chart within the specified chartSize.

Probably the final size of the cell hasn't been calculated when passing the frame to the chart? The inner frame is where the chart's contents (inside the axes) is displayed, if the height is -10 it means there's something wrong with the frame. You also could use autolayout https://gist.github.com/i-schuetz/f6e285eb0c86bb831510

Thanks, it helped. Issue resolved by setting layout and updating them before cell loads.


Bug: lexical/markdown's $convertFromMarkdownString is hardcoded to transform code with a transformer and does not emit  tags

$convertFromMarkdownString and an empty transformer list, CODE blocks are still converted
$convertFromMarkdownString does not emit <code> tags wrapped in <pre> as it usually done for preformatted code blocks. If nothing else this is useful to distinguish inline code from block code.

Lexical version: 0.12.5
Steps To Reproduce

Use $convertFromMarkdownString with a transformers argument as an empty array or with e.g. QUOTE

$convertFromMarkdownString("this is text\n> this is a quote\n```c\nint main(int argv, char **argv)\n{\n    return -1;\n}\n```\n> this is a quote", [QUOTE])

Observe forced transformations on code blocks

If an empty transformer array is given then no QUOTE transformations occur as expected, but CODE transforms still do.

Link to code example: https://codesandbox.io/p/sandbox/awesome-goldberg-vgj4s2

The current behavior

The function $convertFromMarkdownString implicitly transforms CODE blocks with internal logic despite passing no CODE transformer that would otherwise match the blocks.
<code> tags are not wrapped in <pre> tags

The expected behavior

Calling $convertFromMarkdownString with an empty array of transformers should effectively be a no-op.
<code> tags are wrapped in <pre> tags, or at least conditionally through some config

I found dynamically opting code transformer is marked as TODO here:
https://github.com/facebook/lexical/blob/9d247acc42998b4de3ed079069584ebde701640b/packages/lexical-markdown/src/MarkdownImport.ts#L62-L64

I noticed this also and figured it may be the core issue here. Nevertheless useful to track TODOs as real tickets. I also just updated the original post and title to reflect that core issues here.
The highlighting issues I was having were resolved by properly adding a theme and CSS, see the discussion.
The remaining two items here I think are real bugs (acknowledging that the first is remarked as a TODO in the code). From @2wheeh, the second issue seems to even have unit tests in the playground that are contrary to the actual behavior. They appear to check for <pre> tags wrapping <code>, but in practice this behavior is not observed.

<pre> tag is generated on exportDOM and converted to <code> on importDOM.
lexical uses just <code> on createDOM for both inline code and code block

about the unit test, it is for testing export and import (i.e copy/paste case)

once you copy/cut the code block and inline code from lexical editor and paste it to some other wysiwyg editor, you would find it renders correctly. that's because <pre> tags wraps when exporting.

So, in the lexical editor, no <pre> wrapping in the DOM seems correct behavior.
sorry for confusing you at first comment in your discussion. 🥲
to config css:

for code block: theme.code ('PlaygroundEditorTheme__code' in playground)
for inline code: theme.text.code ('PlaygroundEditorTheme__textCode' in playground)


add the ability to retry coarse steps with a smaller timestep

Sometimes the level-by-level retries fail for hydro problems, especially with strong cooling. Limiting the timestep on each level to the cooling time on each level fixes the problem, but increases the computational cost by over an order of magnitude. In principle, we should be able to re-try the whole coarse timestep when the retries for a given level fail.
This requires additional memory usage to be able to restore the state from the previous coarse timestep (all MultiFabs on all levels must be stored), but we could follow Castro and copy the backup data to host memory to reduce GPU memory pressure.
See: https://github.com/AMReX-Astro/Castro/blob/main/Source/driver/Castro_advance_ctu.cpp#L486-L514

This is not an issue for the shock-cloud problem anymore, now that we are using a custom interpolater object.


Bytes ByteArray Optimizations

PR description
Optimizations aimed at reducing get and set calls by specializing calls.

Switch to MutableArrayWrappingBytes for

Fixed Issue(s)

Looks like you need to run spotless though. :)

Test failure is unrelated, feel free to merge and open an issue for the OOM.

It fails field testing when loaded into Besu.
I'll isolate the issue and add tests for what broke.  I think it's my compareTo optimizations for byte arrays


Question: g++ 8 support

Hi,
I have noticed that g++ version 8.4.0 fails to compile specific example I have, which uses nexus with two different services, which require different invocation signatures. It compiles fine with clang++ version 8, though.
Do you maybe know if this is a specific g++ deficiency, or cib code could be modified in a way to handle this old g++ version as well?
Compiler error I am seeing is as follows:
/repo/github/cib-examples/ticker-extended/src/main.cpp:146:16:   required from here
/repo/github/cib-examples/external/cib/cib/nexus.hpp:50:53: error: invalid conversion from ‘void (*)(const spread_ind&)’ to ‘cib::traits::interface_t<publish_ticker>’ {aka ‘void (*)(std::__cxx11::basic_string<char>, const std::__cxx11::basic_string<char>&)’} [-fpermissive]
                     cib::service<clean_service_tag> = service_impl;

Code I am trying to build is here:
https://github.com/WojciechMigda/cib-examples/blob/main/ticker-extended/src/main.cpp
Thanks!

Thank you for submitting this issue! 😀
I don't typically use std::string in my code, so I didn't run into this issue. The problem is my code has it's own tuple that it uses instead of std::tuple. I wasn't fully qualifying cib::tuple and cib::make_tuple, this was causing some of the std equivalents to get called instead. I have a fix pending review.

Thank you for such a prompt response! I am not sure this issue relates specifically to std::string. It more seems like g++-8 tries to match feature invocation to a wrong service.


Add Windows support to hello_world

Continuation of #84751 (cc @GroovinChip). That PR was closed due to being outdated. In the meantime, macOS support has been added. This PR adds Windows support.
The command I used to generate is:
flutter create --platforms=windows --template=app --project-name "hello_world" --org "io.flutter.examples" .

The running result on Windows looks like this:

Related: #84306
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

macOS support was added in https://github.com/flutter/flutter/pull/86534 afaic.

see also https://github.com/flutter/flutter/pull/84899

cc @cbracken for review

I'm sorry we never got around to reviewing this. However I am unsure if this is actually worth doing, so I would recommend discussing whether or not we should do this on the issue.


Heartbeat support?

Thank you for writing a great AMQP library for Rust!
I'm using this library at work, and I've run into a use-case where it would really help to have AMQP heartbeat support. Do you have any suggestions about how heartbeat support could be implemented, and where to start? Thank you for any pointers you can provide!

Hi @emk , I'm glad to hear that you find this library useful.
Heartbeat is indeed one of the missing features. It should not be that hard to implement.

Make heartbeat/heartbeat interval a configuration option.
Negotiate heartbeat interval with server's Tune request and send interval along with a connection::TuneOk frame.
If negotiated interval is > 0, then we need to start sending heartbeats on channel 0. I guess we should start a new thread, which will do this in the specified intervals. It is only necessary to send heartbeats if there was no traffic sent through the connection during the heartbeat interval.
Receive heartbeats (they should come on channel 0), and reset a heartbeat received timer. In the heartbeat thread check if heartbeat timer exceeds the heartbeat interval * 2, if so, then just close the connection (without connection.close). Somehow notify consumers/producers (?).

Definitely an awesome library so far. Heartbeat support would be a great feature to implement, no doubt. I'll see if I can get around to opening a PR for this ASAP.

Ok, opened up initial PR on getting this in order. I am giving it some practical testing now.


Upgrade to Rails 5

I picked off where #427 left off. There's a few more gems that needed to be updated and some minor code changes.
I'm still getting some random failures that I think are omniauth related. Still investigating.

I'm getting this error locally too
ActionView::Template::Error: nil is not a valid asset source
    app/views/application/_nav.html.slim:9:in `_app_views_application__nav_html_slim__1550834241246068923_79168440'
    app/views/layouts/application.html.slim:7:in `_app_views_layouts_application_html_slim__587618798759587358_37113340'
    test/test_helper.rb:86:in `login_via_github'
    test/integration/maintaining_repo_subscriptions_test.rb:7:in `triage_the_sandbox'
    test/integration/maintaining_repo_subscriptions_test.rb:35:in `block in <class:MaintainingRepoSubscriptionsTest>'

This only happens when we're using the login_via_github test helper which uses the omniauth stubs. Sometimes avatar_url is nil, sometimes it isn't. I added logging and sometimes current_user is nil and sometimes it isn't. Really not sure where this is coming from.

I am getting a different failure on this branch -
F

Failure:
ReposControllerTest#test_trying_to_create_repo_without_logged_in_will_redirect_to_login_page:
Expected response to be a redirect to <http://test.host/users/auth/github?origin=%2Frepos%3Frepo%255Bname%255D%3Dcodetriage%26repo%255Buser_name%255D%3Dcodetriage> but was a redirect to <http://test.host/users/auth/github?origin=%2Frepos>.
Expected "http://test.host/users/auth/github?origin=%2Frepos%3Frepo%255Bname%255D%3Dcodetriage%26repo%255Buser_name%255D%3Dcodetriage" to be === "http://test.host/users/auth/github?origin=%2Frepos".

Investigating more.

Branch is green, I commented out teaspoon tests. We should revisit our javascript testing story. I have to run to a meeting. I'm fine to deploy and work on bugs when I get back.

Rails 5 beta is live on production


CNI helm template include/exclude options

The CNI is a strategic solution to move away from using an init container with NET_ADMIN privileges; however, the helm template does not allow the option to set CIDR ranges or ports to include or exclude from the service mesh.
These are required for us to continue using init containers which access pod-external services, use statefulsets (We are aware of improvements to statefulset compatibility but have not upgraded or tested this internally), or to implement strict MTLS.
We have considered setting pod annotations, as suggested in the documentation; however, this is not suitable because we operate in a service oriented team structure and the requirements for exclusions must be cluster-wide and transparent to application teams.
Also considered is moving all of our infrastructure to within the service mesh, although this is not currently possible as we are not in a position to implement multi-cluster Istio deployments.
I was aware of previously raised issues on the istio-init github page, before these were merged and closed.
I am also aware of the Kubernetes sidecar container work, and on a piece of work to move the proxy to within a plugin.
Thanks,
Elliot

You can add the annotations supported by Istio CNI in your injection template, starting from Istio 1.4.0. See https://github.com/istio/istio/pull/17334. Just set the injectedAnnotations field in your injection template with the desired annotations.

@ElliotPM Please reopen this issue if the solution above doesn't work for you.


Feature request: Death animations

Instead of just immediately freezing, players should show their explosion animation when they die (would require protocol update).

will be out in the next release.


Make a PR to trigger a new release

We need a new release which contains PR: https://github.com/casdoor/casdoor-nodejs-sdk/pull/19

@qianxi0410


Crash after update to .Net9

When I start the BarcodeScanning.Native.Maui Version=2.0.0 for .Net Maui Version 9, the app crashes, when I close the preview window:
System.NotSupportedException: 'Unable to activate instance of type BarcodeScanning.BarcodeAnalyzer from native handle 0x7ff7cfc138 (key_handle 0x5ec2f95).'
I tested it on Android 13, Pixel 4a
It worked fine in the older Version 1.6.0 in .Net Maui 8. The only problem was, when I started the preview for the first time it freeses. It happend only seldom and always for the first time after some longer perion of time (like next day).

Try to set CameraEnabled to false and the wait a little bit using await Task.Delay(100) before navigating away.
As for the freeze, in my experience, it only happens when the Debugger is attached.

I added the delay, unfortunatelly I have still the same problem on Android:
System.NotSupportedException: 'Unable to activate instance of type BarcodeScanning.BarcodeAnalyzer from native handle 0x7ff7cfc138 (key_handle 0x5dfe99a).'
The freeze of the View happens in a store app unfortunatelly, but I don't have there the delay befor navigating back.

I tested this on Barcodescanning.Test project and only time i get the exception is if CameraEnabled isn't set to false before navigating back. Please share some of your code if it differs from the code below.
Working code (for me):
private async void CameraView_OnDetectionFinished(object sender, OnDetectionFinishedEventArg e)
{
      if (e.BarcodeResults.Count > 0)
      {
          Barcode.CameraEnabled = false;
          await Shell.Current.GoToAsync("..");
      }
}

And also working:
protected override void OnDisappearing()
{
      base.OnDisappearing();
      Barcode.CameraEnabled = false;
}
private async void CameraView_OnDetectionFinished(object sender, OnDetectionFinishedEventArg e)
{
      if (e.BarcodeResults.Count > 0)
          await Shell.Current.GoToAsync("..");
}

ScannerMauiApp2.zip
Hi,
thank you for your quick answer. I added an sample app, which also crash, when I close the ScannerPage with the "X" on the top left page side.

I took a quick look at your code and the diagnosis is the same... it looks like the Handler gets disconnected and everything disposed before the camera stops.
Unfortunately i don7t have time to do the whole debugging, especially as I don't have any experience with the packages that you are using for MVVM model.
Overriding OnDisappearing() and setting CameraEnabled = false; in the code behind of the page should fix this issue.

ScannerMauiApp2.zip
Hi, I updated the project to the latest Nuget Package & changed the binding to the CameraEnabled  (deleted the Mode property) and the QR Code Scanner works now very well!
Thank you for your help!

See last comment

Hmm... I'm still having this problem in the .NET 9 / 2.1.1 variant. We were using 1.4.0 in .NET 8 and that worked just fine. Now it always crashes when we navigate away. CameraEnabled was always already set to false before we do that, otherwise it wouldn't work in .NET 8 / 1.4.0 either.

I tested it onl ywith Android 13 / Pixel 4a. You can also enable/disable the camera, when the page receives OnAppearing / OnDisappearing in code behind.

I found a workaround:
This used to be the correct way to do it in the 1.4.0 / .NET 8 variant, but no longer works now:
// Clean up barcode scanner page before we navigate away.
scanView.TapToFocusEnabled = false;
scanView.TorchOn = false;
scanView.OnDetectionFinished -= OnScan;
scanView.CameraEnabled = false;
// Disconnect handler as documented to prevent memory leaks
scanView.Handler?.DisconnectHandler();
scanView = null;

To get it to work again, I must now add this ugly hack:
// Clean up barcode scanner page before we navigate away.
scanView.TapToFocusEnabled = false;
scanView.TorchOn = false;
scanView.OnDetectionFinished -= OnScan;
scanView.CameraEnabled = false;
// Workaround for BarcodeScanning.Native.Maui #112
await Task.Delay(100);
// Disconnect handler as documented to prevent memory leaks
scanView.Handler?.DisconnectHandler();
scanView = null;

So it turns out, it doesn't have anything to do with the navigation. I must now wait before disconnecting the handler. Whereas previously, I had to disconnect it first.

As there were basically three different threads that were involved in barcode detection on Android it looks like there is some race condition where BarcodeAnalyzer gets disposed but _barcodeScanner.Process is still running in the background and then trying to access the disposed instance of BarcodeAnalyzer as it is registered as OnSuccessListener and OnCompleteListener.
I guess this happens on 9.0 more often as DisconnectHandler() is called automatically (link).
I am planning to do a rework of the BarcodeAnalyzer (again...) on Android to use TasksClass.Await(task) to make everything run synchronously on the same background thread. This should prevent at least some of the crashes.


Endpoints not protected

Steps to reproduce:

Run Server
Call endpoint for instant by clicking "try it out"

It is not necessary to authorize first as control is being passed to controller body.
Curl gets direct to execution part (skips security restrictions)

The issue for which this demo project was uploaded #1913 , was related to the Swagger UI. The demo project is to show this issue. Securing the service endpoints is not implemented as it is not required for this issue.


Support for High Availbility

Hello,
Recently I faced some issues while using csi-wekafs plugin, which csi-wekafs-controller POD stucked by some reason and then all csi-wekafs-node PODs can't communicate with csi-wekafs-controller POD.
And It seems that csi-wekafs-controller POD which was spawned from statefulset is not configured as supporting HA, only number of replicas is set to 1.
I'm wondering that If I change replicas: 1 to replicas: 3 or something else, then all behaviors like attaching, resizing, mounting, unpublishing, ... are working well?
Thanks.

Hello Louis,
First of all, if you have encountered a controller pod freeze, please open an issue and provide the logs of wekafs container for the csi-wekafs-controller-X so we would be able to analyze it and resolve the issue.
It is important to provide the whole log rather than last lines, since some important information is printed only in the beginning of plugin execution. Also, if you are aware of some specific issue that caused the pod to freeze, please specify it.
In general, CSI specifications require full idempotence for operations. Weka CSI plugin is by intention developed to be completely stateless, and preserves all the necessary data on Weka storage or inside Kubernetes manifests.
Repeating requests for operations should be handled by all controllers independently (and it might happen practically in parallel).  Hence, having too much controllers could increase risk of some race conditions, but even in such case, if from some reason request fails, it will succeed on the next retry.
So you definitely can set number of replicas to 2 or 3. Please feel free to report any issues if you observe such. And don't forget the wekafs container logs of all controller replicas, of course.

Hello Louis,
The plugin was updated with 2 controller replicas by default.

Thanks @sergeyberezansky .
BTW, Is the next release version going to named as "2.0", not "1.0"?
And when will the next version be released?

The version will be released together with Weka 4.2, pretty soon.
It will be indeed called 2.0.
Thank you

Thanks.
Is it compatible with Weka <IP_ADDRESS>?

Hi, although some of the new functionality might work, it requires at least version 3.14, and for full feature support, version 4.2 is required.
Regardless, i would suggest you to coordinate upgrade with the customer success team

Implemented in release 2.0.0


istio 1.5.0 Mixer Report failed with: UNAVAILABLE:Cluster not available

I'm having this issue.
https://github.com/istio/istio/issues/22029
What does it affect? and how can I fix it?

The issue was on my side, that I still wanted to use the deprecated mixer and an out of process mixer adapter. This setup didn't work anymore. I solved the issue by disabling the mixer feature (default with istioctl 1.5.x) and using envoy filters instead of a mixer adapter.

I'm using Knative, is this why I'm getting the issue?

I spoke with Knative and they said, mixer is not a requirement for them.  Is this something we can just turn off?  Will we lose any Istio features?  How do I fix it?

When you use the istioctl version 1.5.x, mixer is automatically turned off. Which values/parameters are you setting in regards to istioctl? I am also using istio 1.5.1 in combination with knative serving.

I'm having this same issue.

I am having the same issues on v1.5.1 and the pods are continuously restarting. There is no error in telemetry logs. Should i downgrade to a lower version for istio ?
It is a blocker for me. Any suggestions?

I am facing the same Error with 1.6.2. Does anyone have solution?

@brijchavda Is your istioctl version in lien with your remote version of Istio on the cluster as well as your proxies?

You need to keep the below components and the error goes away
istio-egressgateway-85f46c7774-5hg84    1/1     Running   0          4d10h
istio-ingressgateway-85576dff98-vmj2x   1/1     Running   0          4d10h
istio-tracing-8584b4d7f9-9b8hc          1/1     Running   0          4d10h
istiod-5cbfb7db8f-52kxk                 1/1     Running   0          4d10h
kiali-696bb665-9pcrv                    1/1     Running   0          4d10h

@brijchavda Is your istioctl version in lien with your remote version of Istio on the cluster as well as your proxies?

client version: 1.6.0
control plane version: 1.6.2
data plane version: 1.6.2 (148 proxies)
I am not using istioctl to do anything. How does client version matter.?

You need to keep the below components and the error goes away
istio-egressgateway-85f46c7774-5hg84    1/1     Running   0          4d10h
istio-ingressgateway-85576dff98-vmj2x   1/1     Running   0          4d10h
istio-tracing-8584b4d7f9-9b8hc          1/1     Running   0          4d10h
istiod-5cbfb7db8f-52kxk                 1/1     Running   0          4d10h
kiali-696bb665-9pcrv                    1/1     Running   0          4d10h

I have everything except egressgateway, Which we disabled purposefully.

The warning message itself is fairly innocuous. It means that your proxies are configured to report to Mixer, but aren't successfully finding Mixer. So, I wouldn't worry about it other than it filling up your logs. Mixer restart loops, which are also mentioned here, were typically triggered by missing configuration (partial installs).
Mixer is deprecated and has been disabled by default since 1.5. 1.7 will be the last release in which it is packaged with Istio. Disabling it should not cause any harm unless you are fully trying to use some of its features.

ok, I need Mixer on, as we have an 'out of process' adapter, what config do I need?
I don't have citadel on, is this required?

@jurgenweber what is the context for your question? are you seeing issues with your OOP adapter? Note that 1.7 should now ship with a Mixer-based shim for maintaining functionality of OOP adapters. It should work for the next set of releases (with a bit of special configuration), but with the 1.8 release, moving over to Wasm-based Envoy extensions will be the recommendation.

no, I am seeing the error in the OP and I am just stating that turning it off is not a solution for us, I need it on.

how did you install?  do you have unhealthy pods?  can you open a different issue covering setup and issues and impact?

Hi @douglas-reid as requested; https://github.com/istio/istio/issues/26815

Closing in favor of the 1.6.8 report.


Xcode 12, Undefined symbols __ubsan_handle_type_mismatch_v1 for architecture x86_64

[REQUIRED] Step 1: Describe your environment

Xcode version: Version 12.0 (12A7209)
Firebase SDK version: 6.33.0
Firebase Component: FirebaseAnalytics
Component version: 4.7.0
Installation method: Zip file

[REQUIRED] Step 2: Describe the problem
Steps to reproduce:
What happened? How can we make the problem occur?

The project itself compiles successfully on Xcode 11.*
Switched to Xcode 12 (12A7209), fails to compile on simulator with the following
Followed the readme instructions on the firebase zip file, the issue still exists

ld: warning: Could not find or use auto-linked framework 'FBLPromises'
Undefined symbols for architecture x86_64:
  "___ubsan_handle_type_mismatch_v1", referenced from:
      -[BNDProtocolProxyBase setForwardTo:] in BNDProtocolProxyBase.o
      -[BNDMethodSignature getArgumentTypeAtIndex:] in BNDProtocolProxyBase.o
      -[BNDMethodSignature getReturnArgumentType] in BNDProtocolProxyBase.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

If you have a downloadable sample project that reproduces the bug you're reporting, you will
likely receive a faster response on your issue.
Relevant Code:

These symbols are not from Firebase. A Google search shows http://cocoadocs.org/docsets/Bond/6.5.0/. It looks something is inconsistently build with the Xcode Undefined Behavior Sanitizer.
Closing since it does not seem to be a Firebase issue, but can reopen if there's evidence otherwise.