Move FSDP module transformation to transform_module

This moves the modification of them Module inside FSDPTransform.transform_module.
There currently are no changes how it operates.
This is the first step towards a composable FSDP Transform, I filed #987 to discuss the broader plan.
cc @crcrpar @lantiga

Thank you @crcrpar


Add support for Context modifiers in Skills with Subskills

e.g. Knowledge (geography) +13 (+18 in cold or icy terrain)

Craft (alchemy) +13 (+21 to create alchemical items)


The files in this directory（\LSP-lua\meta）will always be deleted, causing an exception

OS: Windows7
When opening the lua file for the second time，The files in this directory（Package Storage\LSP-lua\meta）will always be deleted, causing an exception

#39


Fetch many events

Closes #316
This is not done, it is just a copy of some code and cleaning it up a little. I do not want to invest more time in this if this is something that you feel is not needed here.
Personally I think this gives a lot of value.

For contributor use:

[x] Targeted PR against master branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[x] Code follows the standards mentioned here
[ ] Updated relevant documentation
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

Codecov Report

Merging #319 (91cebc2) into master (a31496d) will decrease coverage by 1.10%.
The diff coverage is 22.80%.

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
- Coverage   52.41%   51.31%   -1.11%
==========================================
  Files          36       36
  Lines        1778     1822      +44
==========================================
+ Hits          932      935       +3
- Misses        724      766      +42
+ Partials      122      121       -1

Flag
Coverage Δ

unittests
51.31% <22.80%> (-1.11%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/flowkit/services/events.go
35.89% <22.80%> (-37.64%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a31496d...91cebc2. Read the comment docs.

There are some test failures here and I do not understand why they fail. Somebody who knows the internals of the emulator better then me need to take a look at it :/

Can  this be merged? I want to realease go with the flow v2 but need this in orrder to do so.

This PR still includes at least two bugs.
If I run events for block range it says that start is greater than last block even though it is not:
./main events get A.1654653399040a61.FlowToken.TokensDeposited --start 39460719 --end 39460729 --network mainnet
Fetching events {A.1654653399040a61.FlowToken.TokensDeposited 39460719 39460729}
❌ Command Error: client: rpc error: code = OutOfRange desc = start height 39460719 is greater than the last sealed block height 16781410

➜  flow-cli git:(fetch-many-events) flow blocks get latest -n testnet

Block ID		66f8e600c5cbce941015ff78f47ded311171d229137f45a8817cec3d893d8b88
Parent ID		c098095e48972f299e1a233214807409bc44ec39b2c9af72bf3e45ae9e4f6f65
Timestamp		2021-07-22 12:20:12.657971498 +0000 UTC
Height			39460761
Total Seals		1
Total Collections	0

The other bug is if I run get event for last 20 blocks I get result when I specify single event but not if I specify multiple events
➜  flow-cli git:(fetch-many-events) ./main events get A.1654653399040a61.FlowToken.TokensDeposited --last 20 --network mainnet
Fetching events {A.1654653399040a61.FlowToken.TokensDeposited 16781447 16781467}

Events Block #16781454:
    Index	4
    Type	A.1654653399040a61.FlowToken.TokensDeposited
    Tx ID	2c996dc12a4aeef7d4dc26274b49ddc5c181f0af4b31fb9eb1a192494ee64de4
    Values
		- amount (UFix64): 44.99999999
		- to (Address?): 0xab970f62ff24fd15

... (more events)

➜  flow-cli git:(fetch-many-events) ./main events get A.1654653399040a61.FlowToken.TokensDeposited A.1654653399040a61.FlowToken.TokensWithdrawn --last 20 -n testnet
Fetching events {A.1654653399040a61.FlowToken.TokensDeposited 39460915 39460935}
Fetching events {A.1654653399040a61.FlowToken.TokensWithdrawn 39460915 39460935}

(no events)

Fetching events doesn't seem to work for me if I get events:
./main events get A.7e60df042a9c0868.FlowToken.TokensWithdrawn --last 30 -n testnet
Fetching events {A.7e60df042a9c0868.FlowToken.TokensWithdrawn 39462308 39462338}

(no events)

The transaction that should cause the events is:
flow transactions get 1aacded1a9883b6682dadb01535c59f83a2a08162a43e1bd7a51798704f182b1 -n testnet

Status		✅ SEALED
ID		1aacded1a9883b6682dadb01535c59f83a2a08162a43e1bd7a51798704f182b1
Payer		df9c30eb2252f1fa
Authorizers	[df9c30eb2252f1fa]

Proposal Key:
    Address	df9c30eb2252f1fa
    Index	0
    Sequence	132

No Payload Signatures

Envelope Signature 0: df9c30eb2252f1fa
Signatures (minimized, use --include signatures)

Events:
    Index	0
    Type	A.7e60df042a9c0868.FlowToken.TokensWithdrawn
    Tx ID	1aacded1a9883b6682dadb01535c59f83a2a08162a43e1bd7a51798704f182b1
    Values
		- amount (UFix64): 0.10000000
		- from (Address?): 0xdf9c30eb2252f1fa

Steps to reproduce: create an account and then fetch the events caused by that account creation.

I really do not understand what is going on here. Both of the following examples work for me.
flow events get A.7e60df042a9c0868.FlowToken.TokensWithdrawn --last 30 -n testnet
Fetching events {A.7e60df042a9c0868.FlowToken.TokensWithdrawn 39470915 39470945}

Events Block #39470924:
    Index	1
    Type	A.7e60df042a9c0868.FlowToken.TokensWithdrawn
    Tx ID	cc7b7c0bd59a0e64abd691cbf4ebb5240e737fc9aa6483213df5aa8503e9d101
    Values
		- amount (UFix64): 0.00010000
		- from (Address?): 0x8374dbb762ce2d7c

Events Block #39470940:
    Index	1
    Type	A.7e60df042a9c0868.FlowToken.TokensWithdrawn
    Tx ID	9ebc96f0ff2ac3c75b9b9ba84397b1c177a30dcb99818c5e594b3541a7b7276a
    Values
		- amount (UFix64): 0.00010000
		- from (Address?): 0x8374dbb762ce2d7c

and
flow events get A.0b2a3299cc857e29.TopShot.Withdraw A.0b2a3299cc857e29.TopShot.Deposit --last 10 --network mainnet

this returns both deposit and withdraw events.
I ran make install in this branch and my flow version is
Commit: fc8841bdcefb9fffc9a7286eb946432e536c5530

I just used the testnet faucet to fund my account in tx 1da0ba974c84082b03ae6d16367162ca1d8b5a1be2f61fc2681ccd3935b783eb and fetching events from that with
flow events get A.7e60df042a9c0868.FlowToken.TokensDeposited A.7e60df042a9c0868.FlowToken.TokensWithdrawn A.7e60df042a9c0868.FlowToken.TokensMinted  --last 300 -n testnet
Fetching events {A.7e60df042a9c0868.FlowToken.TokensDeposited 39471216 39471465}
Fetching events {A.7e60df042a9c0868.FlowToken.TokensWithdrawn 39471216 39471465}
Fetching events {A.7e60df042a9c0868.FlowToken.TokensMinted 39471216 39471465}
Fetching events {A.7e60df042a9c0868.FlowToken.TokensDeposited 39471466 39471516}
Fetching events {A.7e60df042a9c0868.FlowToken.TokensWithdrawn 39471466 39471516}
Fetching events {A.7e60df042a9c0868.FlowToken.TokensMinted 39471466 39471516}

Events Block #39471397:
    Index	3
    Type	A.7e60df042a9c0868.FlowToken.TokensWithdrawn
    Tx ID	1da0ba974c84082b03ae6d16367162ca1d8b5a1be2f61fc2681ccd3935b783eb
    Values
		- amount (UFix64): 0.00010000
		- from (Address?): 0x8c5303eaa26202d6

Events Block #39471397:
    Index	1
    Type	A.7e60df042a9c0868.FlowToken.TokensMinted
    Tx ID	1da0ba974c84082b03ae6d16367162ca1d8b5a1be2f61fc2681ccd3935b783eb
    Values
		- amount (UFix64): 1000.00000000

Events Block #39471397:
    Index	2
    Type	A.7e60df042a9c0868.FlowToken.TokensDeposited
    Tx ID	1da0ba974c84082b03ae6d16367162ca1d8b5a1be2f61fc2681ccd3935b783eb
    Values
		- amount (UFix64): 1000.00000000
		- to (Address?): 0x69915b410cca3c65

    Index	4
    Type	A.7e60df042a9c0868.FlowToken.TokensDeposited
    Tx ID	1da0ba974c84082b03ae6d16367162ca1d8b5a1be2f61fc2681ccd3935b783eb
    Values
		- amount (UFix64): 0.00010000
		- to (Address?): 0x912d5440f7e3769e

I found your events in block 39461954
flow events get A.7e60df042a9c0868.FlowToken.TokensWithdrawn A.7e60df042a9c0868.FlowToken.TokensDeposited A.912d5440f7e3769e.FlowFees.TokensDeposited flow.AccountCreated flow.AccountKeyAdded -n testnet --start 39461954 --end 39461955


Add new entry to A to Z re GP systems

Description
Add entry for GP system supplier names to A to Z of NHS health writing - after March Style Council.
Updated after conversation with Olivia.
Related issue

Follow up after March Style Council meeting

Checklist

[ ] Tested against the NHS.UK frontend testing policy (Resolution, Browser & Accessibility)
[ ] Code follows the NHS.UK frontend coding standards
[ ] Version number has been increased in package.json (using SEMVER)
[ ] CHANGELOG entry - not yet
[x] Whats new page entry
[x] Page updated date

Hi @DomBaker, would you mind checking the code please and merging? I'll then ask Olivia to double check the content on staging before we release. Thanks very much.


CollectedBuildOutput from solution does not include output from cross-targeting projects

Repro:
Test.sln
  SingleTfm.csproj:   <TargetFramework>net451</TargetFramework>
  MultiTfm.csproj:    <TargetFrameworks>net451;netstandard1.3</TargetFrameworks>

<Project>
  <Target Name="Build">
    <MSBuild Projects="Test.sln" Targets="Build">
      <Output TaskParameter="TargetOutputs" ItemName="CollectedBuildOutput" />
    </MSBuild>
    <Message Text="@(CollectedBuildOutput, '%0A')" />
  </Target>
</Project>

Expected output
 C:\proj\SingleTfm\bin\Debug\net451\SingleTfm.dll
 C:\proj\MultiTfm\bin\Debug\net451\MultiTfm.dll
 C:\proj\MultiTfm\bin\Debug\netstandard1.3\MultiTfm.dll

Actual
 C:\proj\SingleTfm\bin\Debug\net451\SingleTfm.dll

Details
Microsoft (R) Build Engine version <IP_ADDRESS>955 for .NET Core
and
Microsoft (R) Build Engine version <IP_ADDRESS>955 for .NET Framework

Team Triage:
This doesn't seem like something we could easily change. The Build target has a single value return currently and there are potentially many assumptions made around this. Since this output is generated via the solution metaproj generation, the only way we could change this would be to change the contract of Build to return multiple values.
What is the use case for this? Is there another way to do this?

Actually, the build target has zero returned output for cross-targeting projects. Should it have returned at least one item?

What is the use case for this?

I would like to compile a particular solution configuration and get a list of all assemblies produced for that solution configuration.

Is there another way to do this?

Sure. Set CustomAfterMicrosoftCommonCrossTargetingTargets to a file that contains this:
<Project>
  <Target Name="Build"
    DependsOnTargets="_SetBuildInnerTarget;DispatchToInnerBuilds"
    Returns="@(InnerOutput)" />
</Project>

Though it seems like it should be a last-resort.

Having encountered this same issue, the triage response seems odd. In the file Microsoft.Common.CrossTargeting.targets the Build target is documented as:
 <!--
  ============================================================
                                       Build

   Cross-targeting version of Build.

   [IN]
   $(TargetFrameworks) - Semicolon delimited list of target frameworks.

   $(InnerTargets)     - The targets to build for each target framework. Defaults
                         to 'Build' if unset, but allows override to support
                         `msbuild /p:InnerTargets=X;Y;Z` which will build X, Y,
                         and Z targets for each target framework.

   [OUT]
   @(InnerOutput) - The combined output items of the inner targets across
                    all builds.
  ============================================================
  -->
  <Target Name="Build" DependsOnTargets="_SetBuildInnerTarget;DispatchToInnerBuilds" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" />
  <Target Name="_SetBuildInnerTarget" Returns="@(InnerOutput)" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
    <PropertyGroup Condition="'$(InnerTargets)' == ''">
      <InnerTargets>Build</InnerTargets>
    </PropertyGroup>
  </Target>

Note that the output is indicated as @(InnerOutput), but the Build target lacks a Returns attribute. Please correct me if I'm wrong, but there are other Build targets that return multiple output items. The metaproject generation for solution files is an example.
It would appear, based on the documentation comment, that returning the coalesced output items is the  original intent.

I have also encountered this issue and I agree with @williamb1024. (By the way, the Rebuild target lacks the Returns attribute too.) As for workarounds, another one is to invoke the MSBuild task building the inner cross-targeting project(s) with the DispatchToInnerBuilds target instead of Build. This workaround doesn't use the CustomAfterMicrosoftCommonCrossTargetingTargets hook (what if another package wants to set it?)

Closing as this is stale and I don't need changes here anymore. See workaround above https://github.com/Microsoft/msbuild/issues/2148#issuecomment-305033099

That workaround should, at minimum, be able to be toggled on/off because it works.  It makes separate distinct results come per project (one per target) and from that point one could write build scripts around that behavior... even if it violates some past assumptions.
As it stands, msbuild is just not providing any values to TargetOutputs for these projects... which violates the hell out of assumptions already.  It doesn't even provide the MSBuildSourceProjectFile which it most certainly has a single value for, and which is guaranteed by the documentation to be provided.
This is not just a "oh well, it's hard to fix because we return only a single value as it stands, so we won't fix it".  It's a bug.  Maybe some other switch/flag is needed to gate access to new functionality so legacy can continue as it is, but this is unintuitive and contrary to documentation/expectation.

Any chance this one might be reopened?
It is not very consistent that Build returns something for 1 TFM but not for multiple TFMs (especially when the targets doc say it should do so).

@rainersigwald can we please reopen the issue? We are adding the proposed workaround into dotnet/runtime and linking back to this issue (https://github.com/dotnet/runtime/pull/35606/files/a2c6b29240d46342244e1b2e6e669cca74261e52#r458357395).


Attempting to take screenshot of current focus window fails with Assertion failed: (bitmap != NULL), function createStringFromMMBitmap

Robotgo version (or commit ref):
version  v<IP_ADDRESS>6, Sierra Nevada!

Go version:
go version go1.11.4 darwin/amd64

Gcc version:
Apple LLVM version 10.0.1 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin18.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

Operating system and bit:

Resolution:

Can you reproduce the bug at Examples:

[ x] Yes (provide example code)
[ ] No
[ ] Not relevant

Provide example code:

package main

import (
	"fmt"
	"github.com/go-vgo/robotgo"
)

func main() {
	fmt.Println("version ", robotgo.GetVersion())
	activeMeta := robotgo.GetActive()
	fmt.Printf("%+v\r\n", activeMeta)
	activePid := robotgo.GetPID()
	fmt.Printf("%+v\r\n", activePid)
	activeName, err := robotgo.FindName(activePid)
	fmt.Println("error ", err)
	fmt.Printf("%+v\r\n", activeName)
	x, y, w, h := robotgo.GetBounds(activePid)
	fmt.Printf("%d, %d, %d, %d\r\n", x, y, w, h)
	bitmap := robotgo.CaptureScreen(x, y, w, h)
	defer robotgo.FreeBitmap(bitmap)
	robotgo.SaveCapture("saveCapture.png", x, y, w, h)
}

Log gist:
https://gist.github.com/amlwwalker/8384c8234f521687f047fe04ab7560ff

Description
I am attempting to grab the window the focus and then take a screen shot of it. I understand the approach to doing so is to first get the PID, then from that I can get the coordinates of the windows position and its size based on the PID and then I can use CaptureScreen to capture the window at these dimensions. Finally I can saveCapture to take a screenshot and store it.
I get an assertion failure as shown in the gist, I think the GetBounds is returning the wrong coordinates (I know it is, the first value is all over the place (811008, 512, 48, 124).
Any ideas where I am going wrong?
...

@vcaesar hey, I see you are quite prevalent on the commits to this repo, I wondered if you maybe able to give me some hints to the above? Be great to solve this - unless there is a more robotgo way to get a screen shot of the currently focused window?

It is due to duplicate ( #210 ), and is a bug in GetBounds().

This is not possible on OSX and I used applescript in the end. See here: https://github.com/therecipe/qt/issues/995#issuecomment-549542934

Thanks for your feedback; I cannot answer every question because time is limited, other features and projects are being developing, and the computer equipment and environment configuration are different.


Simplify pdig attach

Instead of live patching the process when we attach to it, let it run until the next syscall[*]. Then use the syscall instruction that just trapped to call prctl() twice with the parameters we need.
Also, store the SECCOMP filter on the target's stack (below the red zone), instead of allocating and freeing memory.

Note: this first syscall is currently not instrumented, though nothing fundamental prevents this

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

86b0424 Drop debug message that failed to compile in debug mode

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign gnosek
You can assign the PR to them by writing /assign @gnosek in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Apologies to reviewers ;) the first commit is a tiny bug fix, then the next two make things happen, and the final two are just moving code around.

LGTM label has been added.  Git tree hash: dbe8c0528cc8d3a3aa9432d5c23db6266ca6a0f5

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leodido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz, leodido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fntlnz,leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I found a bug somewhere in the clone path so I hope this doesn't get merged automatically

/hold

Adding an hold so it does not get merged @gnosek

New changes are detected. LGTM label has been removed.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

a5fa2df Handle CLONE/initial SIGSTOP events properly in any order

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign fntlnz
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign fntlnz
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign fntlnz
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign fntlnz
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/unhold

/hold cancel

LGTM label has been added.  Git tree hash: ca32e52cd0bb351902bff949bf97cefc5267f525

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leodido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Rename '_fmr_header.class' to packet_class

If any of the Flipper headers are included in a C++ context, this name
breaks compilation. Rename it to avoid the conflict.

Maybe we could call this type instead? Or does that still result in a keyword conflict?

type is totally fine, too.


frontend: Add comment to explain MiddlewareLowercase

Just adding a comment to try to clarify the purpose of MiddlewareLowercase, since I saw some recent confusion around it.

Opened a non-forked PR for this as https://github.com/Azure/ARO-HCP/pull/352.


Governance package in Cairo

🧐 Motivation
Governance is a must have, we need it in Cairo guys.
📝 Details
https://docs.openzeppelin.com/contracts/4.x/governance

Agree! But closing this issue since it's a duplicate of #294.


Optimise SVG loading

Currently SVGs getting loaded multiple times, for example https://www.netcentric.biz/icons/chevron-right.svg is requested over 30 times on the homepage right now.

I think using the default decorateIcon approach is not the best idea for this use case. We should load chevron-right.svg only once.


Add 2D dimension

I have added the ability to take measurements in 2D. Toggler added, you can use it to switch to 2D measurement mode and get measurements at the top point.
Attached a screenshot

@aka-blackboots , Hi, for some reason, the Eslint check does not pass. In the main branch, the same problem

Hi, all our efforts are now going towards this library, which will likely substitute both web-ifc-viewer and web-ifc-three. You can check the dimensions there, and feel free to open a PR if you think they need improvement!

@agviegas  Hi! How is it better than web-ifc-viewer?

Some of the reasons are:

It's more modular & flexible
It's much faster to load models
It consumes way less memory
Has better postprocessing
It has way more tools (and all new tools are going to be here)
It's going to be maintained in the long term
The whole documentation + tutorials + testing is going to be release by the end of the summer


minlength, maxlength to work with dictionaries

When specifying a dictionary with arbitrary keys using propertyschema and valueschema, the use of minlength would be handy to prevent empty dictionaries.

I've written a patch, pending in Pull Request #159


design how to show authorship of posts

thinking a static about page for all of them will be easy and suffice


POC for polysemy

Changelog
- description: |
    POC for polysemy
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context
Using polysemy to simplify tests.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist

[ ] Commit sequence broadly makes sense and commits have useful messages
[ ] New tests are added if needed and existing tests are updated. See Running tests for more details
[ ] Self-reviewed the diff

In the current state, I am neutral:

We don't really save on boilerplate
We don't add boilerplate either
The multiple reader context is nice to have, but not essential.

One advantage is that you could log in the functions being tested and then capture those logs in a test annotation like this:
           ┏━━ test/cardano-cli-golden/Test/Golden/Byron/SigningKeys.hs ━━━
        38 ┃ hprop_deserialise_nonLegacy_signing_Key :: Property
        39 ┃ hprop_deserialise_nonLegacy_signing_Key = propertyOnce $ localWorkspace $ do
        40 ┃   skeyBs <- LBS.readFile "test/cardano-cli-golden/files/input/byron/keys/byron.skey1"
           ┃   │ [info]  [T.G.B.SigningKeys#40] Reading bytestring from file: test/cardano-cli-golden/files/input/byron/keys/byron.skey1
        41 ┃     & trapFail @IOException
           ┃     ^^^^^^^^^^^^^^^^^^^^^^^
           ┃     │ Expected Right: test/cardano-cli-golden/files/input/byron/keys/byron.skey1: openBinaryFile: does not exist (No such file or directory)
        42 ┃
        43 ┃   fromEither (deserialiseFromBytes Crypto.fromCBORXPrv skeyBs)
        44 ┃     & trapFail @DeserialiseFailure
        45 ┃     & void

so I'm wondering why polysemy and not some other effect system?

Mainly due to familiarity and ecosystem - in particular the logging library polysemy-log.  We could select a different effect system but we may need to implement the libraries we want and we should also apart from performance evaluate how good the errors are.

All in all, I'm not convinced:

There is no significant reduction of boilerplate
By adding dependencies to https://github.com/tek/polysemy-conc and https://github.com/haskell-works/hw-polysemy we put ourselves in a very niche part of the Haskell ecosystem, and this is not good for long term maintenance. The bus factor here would be very small.

If we are convinced this is important, I would wait a few months to see if this part of the ecosystem gains traction.


Benchmark is not fair, So the speed can't be trusted

Thanks for the cache package, it helps me a lot.
But I find some problems with the result when I read the Benchmarks result carefully.
BenchmarkFreeCacheSet-8               	11068976	       703 ns/op	     328 B/op	       2 allocs/op
BenchmarkBigCacheSet-8                	10183717	       478 ns/op	     304 B/op	       2 allocs/op

BenchmarkBigCacheSetParallel-8        	34233472	       148 ns/op	     317 B/op	       3 allocs/op
BenchmarkFreeCacheSetParallel-8       	34222654	       268 ns/op	     350 B/op	       3 allocs/op

The main problem is why the more times the test function run, the longer avg time it costs.
As we all know, the first number means the times the test function runs, and the second means the average of each time cost. And the bench time is the same according to -benchtime=4s.
So I got confused about why this happened. It's impossible.
I read the source code of the benchmark test, and finally, I found where the problem lies.
https://github.com/allegro/bigcache-bench/blob/98e08029e2a1964c70a4e55c5324c004b8826c9c/caches_bench_test.go#L32-L34
for i := 0; i < b.N; i++ {
	cache.Set([]byte(key(i)), value(), 0)
}

This is not a good code for the benchmark test, because it uses b.N as parameters.
b.N stands for how many times the function will be executed.
Under the same time duration, the function which is faster will be executed more times.
So the b.N will go bigger than the other one.
As b.N goes bigger, it will set more elements to the cache, leading the whole function to take more time definitely.
So I think it is an unfair benchmark for the faster one.
Or we can have the tests in which we set the benchtime to 1s, 2s, 3s, 4s, 5s, 6s, and 7s.
And we will see the FreeCache goes faster than BigCache in the beginning, but it will spend more avg time with the benchtime going up, although it runs more times than BigCache.
In my option, since the benchmark remains controversial, who is the faster between BigCache and FreeCache should be reconsidered.

In addition, I think the benchmark should add the case where the struct is used as the value rather than the []byte,
especially when compared to the Map or Sync.Map.
Because we usually use the cache to store our instances of the struct rather than the []byte, in this case, the cost of serialization should be considered in the BigCache and FreeCache.

@LawyZheng good point. Waiting for PRs with new benchmarks

@LawyZheng good point. Waiting for PRs with new benchmarks

already created a PR https://github.com/allegro/bigcache-bench/pull/11

PR has been merged successfully. After you guys update the README in both repositories, I will close this issue.


RDKIT Based Modeling and Documentation

Let's do an RDKIT based example that shows the process of using SageWorks for rapid prototyping.
References:

https://www.kaggle.com/code/vladislavkisin/tutorial-ml-in-chemistry-research-rdkit-mol2vec

ADME Properties: Absorption, Distribution, Metabolism, and Excretion. Knowing these can help optimize drug delivery and efficacy.
Toxicity: You'll definitely want to predict if a compound could be toxic to humans or other organisms.
Binding Affinity: Knowing how well a molecule will bind to a target protein can be key for drug design.
Stability: How long does the molecule last under various conditions? This impacts shelf life and effectiveness.
LogP: The partition coefficient between water and octanol. It gives you an idea about the drug's solubility in fat versus water, which affects how it'll be distributed in the body.
pKa: This property helps you understand how a molecule will behave at different pH levels, affecting its solubility and stability.
Molecular Weight: It often correlates with other important properties like permeability and solubility.
Tautomeric Forms: Some molecules can exist in multiple tautomeric forms, and these can have different properties.
Bioavailability: How much of the drug will actually make it into the bloodstream when administered in various forms (oral, IV, etc.).
Drug-Drug Interactions: If your molecule is likely to interact with other commonly-used drugs, that’s key info.
Resistance Profile: For antimicrobial drugs, how quickly might pathogens develop resistance?


Add option to split by dups or using TreeKO algorithm

You need to change the tool version to @VERSION@+galaxy1

You mean version="@VERSION@+galaxy1" ?
That turns into  (Galaxy Version 3.1.1+galaxy1)

Yes:
<tool id="ete_genetree_splitter" name="ETE GeneTree splitter" version="@VERSION@+galaxy1">

See https://galaxy-iuc-standards.readthedocs.io/en/latest/best_practices/tool_xml.html#tool-versions

Can you also add a test for the new feature?

Can I?... Yes,
Do I want to.? No :smile:
Give me some time


Changed default cache mode

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.093%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4911

Relevant Lines:
6056

💛  - Coveralls


Generate StructureMap from FHIR Mapping Language

Coverage decreased (-0.01%) to 94.057% when pulling 6b7190efccd24a094978f2a034b45611d6f1d11d on cody-fhir-mapper-to-structure-map into 6dbdb7f6206bfc00d097b505d8ba1e164e1cabe3 on main.


wip: centralize Dokka configuration and plugins into repo tools

Issue #
(none)
Description of changes
Work in progress: This PR and its companion PRs don't actually work yet. Posting here for debugging...
Companion PR: https://github.com/awslabs/aws-kotlin-repo-tools/pull/47
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Abandoning for now.


jedis excetion with redis-cluster binding multi ip addresses

1.firstly, i try to comment the bind setting in the redis.conf
2. then i build the cluster with  ./redis-trib.rb create <IP_ADDRESS>:6379  <IP_ADDRESS>:6380 <IP_ADDRESS>:6381
3.then i use JedisCluster to visit my cluster with such Exception:
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
.......
4.same problems with "bind <IP_ADDRESS>" in redis.conf

@mechine
Thanks for reporting.
Can you elaborate it by specifying Redis version / Jedis version, and pasting full stack trace?

@mechine are you still having this issue?
Can you please issue a cluster info and cluster nodes in your master redis cluster nodes and post the results here?.
I've just made a test and it works without problem for me.

@HeartSaVioR  @marcosnils
Thanks for answering.
Sorry for being  late.
I think i have found the reason by using "cluster nodes":
when i create the cluster by:
./redis-trib.rb create <IP_ADDRESS>:6379 <IP_ADDRESS>:6380 <IP_ADDRESS>:6381
i can visit the cluster using jedis,while when create the cluster by:
./redis-trib.rb  create <IP_ADDRESS>:6379 <IP_ADDRESS>:6380 <IP_ADDRESS>:6381
then the cluster is unvisitable.


Slider:fix lint warn var declared in global scope

exFirst -> o.v.exFirst
eyFirst -> o.v.eyFirst
Suggested here: https://github.com/espruino/BangleApps/pull/3259#discussion_r1524804030

I tried this change with my slidertest app - seems to work as expected!


Update Posts “license”

Automatically generated by Netlify CMS

👷 Deploy Preview for delightful-unicorn-e44224 processing.

Name
Link

🔨 Latest commit
04526abd8ce44c6300873f47ae5dcb5348ba80b5

🔍 Latest deploy log
https://app.netlify.com/sites/delightful-unicorn-e44224/deploys/62faa90a9c3177000983cd05


Falco audit rules not working for Azure kubernetes Service

We have deployed the Falco k8s_audit_rules.yaml. After the deployment, It seems only the falco_rules.yaml section is working.
These are some falco rules that are working.

Log files were tampered
Shell history had been deleted or renamed
Privileged container started
Error File below / or /root opened for writing
Notice A shell was spawned in a container with an attached terminal
A shell configuration file has been modified
Docker or kubernetes client executed in container
Unexpected connection to K8s API Server from container

But for K8s-audit rules, the most important rules are as follows and they doesn't seem to be working.

Detect any attempt to create a namespace outside of a set of known namespaces
Detect any attempt to create a pod in the kube-system or kube-public namespaces
Detect any attempt to create a serviceaccount in the kube-system or kube-public namespaces
Detect any attempt to modify/delete a ClusterRole/Role starting with system
Detect any attempt to create a ClusterRoleBinding to the cluster-admin user
Detect any attempt to create a Role/ClusterRole with wildcard resources or verbs
Detect any attempt to create a Role/ClusterRole that can perform write-related actions
Detect any attempt to create a Role/ClusterRole that can exec to pods
Detect any attempt to create a deployment
Detect any attempt to delete a deployment
Detect any attempt to create a service
Detect any attempt to delete a service
Detect any attempt to create a configmap
Detect any attempt to delete a configmap
Detect any attempt to create a namespace
Detect any attempt to delete a namespace
Detect any attempt to create a service account
Detect any attempt to delete a service account
Detect any attempt to create a cluster role/role
Detect any attempt to delete a cluster role/role
Detect any attempt to create a clusterrolebinding
Detect any attempt to delete a clusterrolebinding

Provide me some documentations with respect to Azure Kubernetes Service. I've tried to deploy the audit enabling yaml as well as Webhook config. those also doesn't seem to be working.

@prakash1097: There is not a label identifying the kind of this issue.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

How do i add label?

Hi @prakash1097 is there any update on this?


cmd/compile: TypedArrays are not pinned in memory

What version of Go are you using (go version)?

$ go version
go version go1.11.4 linux/amd64

What version of Node are you using?

$ node --version
v10.13.0

Does this issue reproduce with the latest release?
Yes. This occurs at master, as well.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/twifkak/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="//home/twifkak/.go"
GOPROXY=""
GORACE=""
GOROOT="/home/twifkak/usr/opt/go"
GOTMPDIR=""
GOTOOLDIR="/home/twifkak/usr/opt/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build919054145=/tmp/go-build -gno-record-gcc-switches"

What did you do?
Created a js.TypedArray in a Go program running under wasm, and then mutated it in a JS callback.
What did you expect to see?
The TypedArray would be successfully mutated, which the Go program could subsequently inspect.
What did you see instead?
In some circumstances, I would get:
TypeError: Cannot perform %TypedArray%.prototype.set on a detached ArrayBuffer

My suspicion is that the GC is moving the underlying byte arrays in times of memory pressure, because the easiest way to trigger this is to decrease the initial heap size, either using wams or by modifying asm.go.
Background
I'm doing this to keep a long-running Go-wasm process around and repeatedly call a Go function from JS, without leaking the input/output objects due to lack of cross-heap GC.
The code to reproduce it is at https://github.com/ampproject/amppackager/pull/220 but requires a test file I haven't checked in -- if you're interested in running it, let me know and I'll add one.
Let me know if I'm holding it wrong and there's some simpler way of achieving my goal.

@neelance

Hmm, this is unfortunate. Calling memory.grow (which may happen at any time) invalidates the existing ArrayBuffer for the memory. Since typed arrays are based on this ArrayBuffer, they stop working as well.
With the current state of WebAssembly the only solution that I see is to not pass the typed array directly but instead wrap it in a custom helper that can create the correct typed array on demand and the user is not allowed to keep a reference to this typed array. This is quite cumbersome.
The threads proposal might save us: It used a SharedArrayBuffer instead of an ArrayBuffer and it seems like it would never detach.

Ah, I was able to get the wrapper approach to work, but boy is it a lot of cruft! Also, will this leak the TypedArray pointers over time?
Until the threads proposal lands, would it be possible to create a second, non-growing memory instance to be used as an arena to communicate over?

I was able to get the wrapper approach to work, but boy is it a lot of cruft. Also, will this leak the TypedArray pointers over time?

Depends on your implementation. I'm not sure what you did.

The threads proposal is indeed interesting. Until the proposal lands, would it be possible to create a second, non-growing memory instance to be used as an arena to communicate over?

I don't see a good way to make this work with Go's memory management.

I currently don't see anything worthwhile that we could do prior. You can still use typed arrays right now, you just shouldn't hold a reference to them from JavaScript. For example the way that the net/http code is using them is fine.

Does it make sense to add a line of documentation clarifying this ?

Sure, why not.


Better use for timestamps

Need a method to get all journal lines in a certain time window:

after time X
before time Y
between time X and time Y

Need the same for worksharing logs


Need document to detail about /healthz feature in Dapr

Need document to detail about /healthz feature in Dapr

This is cover in this PR #487 https://github.com/dapr/docs/pull/487


[EXE] Implement Different learning algorithm from scratch with visualization

One of the most important component of neural networks is the learning algorithms it uses.
Since for most of the beginners it is like a black box.
I am planning to contribute code for these learning algorithms. These will include:

Gradient Descent
Momentum based Gradient Descent
Nesterov Accelarated Gradient Descent
AdaGrad
RMSProp
Adam
It will be a .ipynb file with complete implementation from scratch also with proper visualization as well as documentation, so that beginners can get a better understanding of these concepts.

@iamarpan Good idea! Please go ahead, but do read the contributing guidelines and look at one or two of the latest project folders. Many thanks !

@gimseng Sorry was a bit occupied with office work. Can I pick this one now?


Selected radio button is not selected on print preview

Detailed description
I'm using Win10 and opened site to print the page, and there were an issues with checked radio buttons - all radio buttons are unchecked on print preview.
Steps to reproduce the issue

Open https://www.carbondesignsystem.com/components/radio-button/code
Check 2nd radio button (First won't see, because menu is overflowed the content)
Then open print preview
And you can see that checked radio button is unchecked.

Screenshots

Select second option https://serving.photos.photobox.com/24397782b7008303d1ad933021445cc6b7e6d69d9eaaa4f6fa4ea3bd1afcceddc313e2b6.jpg
View from Chrome print preview https://serving.photos.photobox.com/8965748325d48320ad7e3339c9571b7f90f0bea29570a994c38beaf18c6d4b944d5a6967.jpg

Print styles are not something we currently support, we are also in the middle of updating all of these pages. Feel free to open a PR if this is something you require. Thanks!


e magazine page buttons

Ok sir i will keep that in mind , thank you very much sir.
On Thu, Mar 10, 2022 at 4:55 PM Sameer Nayak @.***>
wrote:

@.**** approved this pull request.
Hey @surbhiujawane https://github.com/surbhiujawane, great work. Here
are some suggestions:-

Try to use the @media https://github.com/media query when you are
designing a mobile view.
Provide proper file name so that it would be clearly understood
among all those CSS files

—
Reply to this email directly, view it on GitHub
https://github.com/E-Cell-SSTC/E-Cell-Website/pull/56#pullrequestreview-905691902,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVM52K5FMFMKUSHMDKD7QHTU7HL25ANCNFSM5QJUD3OA
.
You are receiving this because you were mentioned.Message ID:
@.***>


No region item in regionDidExit

No region item is send in the event : regionDidExit
I'm not a specialist in Java so i'm not sure it works and i don't know how to test it.
So be careful ! :D

Thank you :+1:
It seems correctly, I'll test it tomorrow morning (I have no beacons here).


Bring back split terminal icon instead of having it only in a dropdown

it would be nice to bring back the split terminal icon directly in action bar so that we don't have to do 3 clicks to spilt our terminals
In the screen shot below you'll see where the split terminal icon was and it is not there anymore which makes me sad.

Closing since it's a duplicate xD


Final Project

The freeCodeCamp curriculum is lacking something, IMO. A project which is built from the heart of the developer.
I think FCC should have one final, CRUD application project, with specific user requests(i.e. should be secure, should be responsive, should allow anyone in the world to visit(if that's not already the case), whatever). Anyway a "final" real project, where the students submit to the forum asking to be hacked, to better learn their craft. But this last, boss-level project is based upon being able to build out an entire application on the students own. It is a final challenge, and may need an additional certificate?
Let me know what you think. Thanks, FCC team

I think a constraint here would be how to go about testing the application. The challenges and projects currently on FCC are tested through automated tests. I don't know if that can properly implemented for a CRUD application


Fix the clojars link

Thanks for the heads up on the Clojars link.  It turns out that, after using google for version 0.1.0 as the artifact's group name, I realized that I should use com.google, so I sorted that out with Clojars and published 0.1.1 and 0.2.0 under com.google.  I updated the latest version in the readme to 0.2.0 as well and merged in pr #31


fix(search): reduce minimum length filter from 3 to 2 characters

Modify elasticsearch filter settings for shorter search terms
Change min length parameter from 3 to 2 in SettingsBuilder.java to allow shorter search terms.
Changes

Modified min_length parameter in elasticsearch filter settings from 3 to 2
This change improves search functionality for multilingual environments

issue #11721
Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[x] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Hello @chriscollins3456
I submitted this PR a week ago and would appreciate your feedback when possible. Please let me know if you need any additional information or changes from my side.
Thanks for maintaining this great project!

Please make this option configuration and happy to include this, maintaining the 3 char default.


Support different log level for module, hostif and networkif

Modified the code to support different log level for module, hostif and networkif.

@iTetsuyaMurakam thanks, can you rebase? The branch conflicts with current master.

@iTetsuyaMurakami I applied the last commit in your branch to the master.
This project uses rebase and merge method to merge PR to avoid including unnecessary merge commits like you have in your branch Merge remote-tracking branch 'upstream/master'.
If you make a PR, please pull the latest master branch and rebase your updates on top of it.


[REQUEST]

I dont want ob to reorganize headers
there are many sites which doesn't accept the reorganized ob headers

In which way does it reorganize headers? Can you show screenshots?

This is what i want it to look like:

This is how is send it:

so i get a error from the api

Ah yes it's definitely Extreme.NET's fault. You should open an issue on my Extreme.NET fork not here.


TransactionRollbackError: canceling statement due to conflict with recovery
DETAIL:  User query might have needed to see row versions that must be removed.

View details in Rollbar: https://rollbar.com/Zooniverse/Zooniverse_Aggregation/items/76/
Traceback (most recent call last):
  File "./aggregation_api.py", line 1903, in <module>
    project.__migrate__()
  File "./aggregation_api.py", line 1072, in __migrate__
    cur.execute(select)
TransactionRollbackError: canceling statement due to conflict with recovery
DETAIL:  User query might have needed to see row versions that must be removed.

doesn't seem to have reoccurred


Redirect does not terminate the response, which may be confusing

I got caught by surprise that redirect doesn't terminate the response. Added myself a redirect! like so, but maybe this needs to at least be documented or an option added to stop the response:
module Grape
  module Extensions
    module RedirectExtension
      def redirect!(url, options = {})
        redirect url, options
        throw :error, status: @status, headers: @header
      end

      Grape::Endpoint.send(:include, self)
    end
  end
end

Additionally: Not setting the format results in a xml rendering exception. Presumably Grape defaults to xml unless the format is set. And presumably since redirect doesn't halt the chain, xml attempts to render nothing:
This fails:
get '/' do
  redirect '/v1'
end

With this xml error:
<error>
<message>cannot convert String to xml</message>
</error>

This redirects correctly:
format :json
get '/' do
  redirect '/v1'
end

Grame really defaults (should default :)) to JSON, not sure what the deal here is, you might want to dig a bit deeper?

Might be grape-roar interfering and defaulting to xml.


update minio fullname with releaseName to prevent collision in naming

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] DCO signed
[ ] Chart Version bumped
[ ] Variables are documented in the README.md

/assign @nitisht


Add relaySource to walletlink event

Summary
This adds a relaySource property to wallet link request events. The new property is so that we can more easily distinguish in the client what the source of the request is – either a WalletLinked Extension or a direct Client -> Dapp connection.
We send 'injected_sdk' if the source is the SDK which the CBW Extension has injected or 'sdk' if it is a standard SDK installed on a dapp page.
How did you test your changes?
I built the CBW SDK locally, installed it on the Extension and a test dapp, and verified it sent the correct value in the various configurations.

Wysłano z telefonu Samsung
-------- Oryginalna wiadomość --------Od: willn-cb @.> Data: 26.04.2023  00:23  (GMT+01:00) Do: coinbase/coinbase-wallet-sdk @.> DW: Subscribed @.***> Temat: [coinbase/coinbase-wallet-sdk] Add relaySource to walletlink event
  (PR #868) Summary
This adds a relaySource property to wallet link request events. The new property is so that we can more easily distinguish in the client what the source of the request is – either a WalletLinked Extension or a direct Client -> Dapp connection.
We send 'injected_sdk' if the source is the SDK which the CBW Extension has injected or 'sdk' if it is a standard SDK installed on a dapp page.
How did you test your changes?
I built the CBW SDK locally, installed it on the Extension and a test dapp, and verified it sent the correct value in the various configurations.
You can view, comment on, or merge this pull request online at:
  https://github.com/coinbase/coinbase-wallet-sdk/pull/868
Commit Summary
565a3b6  Add relaySource to walletlink event
File Changes  (1 file)
M
packages/wallet-sdk/src/relay/WalletSDKRelay.ts
(8)

Patch Links:
https://github.com/coinbase/coinbase-wallet-sdk/pull/868.patch
https://github.com/coinbase/coinbase-wallet-sdk/pull/868.diff
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.>
[
{
@.": "http://schema.org",
@.": "EmailMessage",
"potentialAction": {
@.": "ViewAction",
"target": "https://github.com/coinbase/coinbase-wallet-sdk/pull/868",
"url": "https://github.com/coinbase/coinbase-wallet-sdk/pull/868",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
@.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]

Review Error for cb-jake @ 2023-04-26 16:36:20 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

Duplicate of #

lgtm

Duplicate of #


Crowdin (translations) support

https://developer.crowdin.com/api/v2/
Add tasks to upload and download translations from crowdin.

Crowdin has builtin Github support: https://support.crowdin.com/github-integration/


proposal: doc: more overview of Go repo for new contributors

Scenario:
I want to contribute with a fix (or investigation) in an open issue and need directions to start. The contributor guidelines (https://golang.org/doc/contribute.html) are focused on describing the tooling and the overall approval process, but I'm feeling lack of orientation on the technical end.
For instance, how is the project organised? What each directory is for? What are the tools available? How do we test? How do we track test coverage? How does the /test/fixedbugs/ directory work? If I'm fixing a bug should I create a file on fixedbugs or a _test file? Or both?
Those are a few things that come to my mind at the moment, but this is by far not an exhaustive list.
I think having a "walkthrough"-like kind of guide teaching the high level organisation of the code, architectural components and the standard contribution process for writing a fix it would be a great addition to the contribution guide.
I offer myself to help writing it, as long as someone spend the time teaching me how it works.

Re: test/fixedbugs, there is a README.md in test/. That answers both of your questions on it.
There are also other .md files spread throughout the codebase which explain other things. Perhaps they can be linked from somewhere more accessible.
But documentation on project organisation and tooling (especially for compilers) is something that needs work.

Thanks for the comment @agnivade. My whole point is actually that... I know there are a lot of information spread around READMEs and other .md and doc.go files, but still takes some effort for someone new to learn how to navigate all those files and the project structure. For instance, I knew beforehand about fixedbugs, but for someone new that may not be an obvious place to look at.
So what I'm thinking here is more like a "kickstart" document laying over the overall project structure, giving a high level description of every component and how you approach changes in each one. The contributing guide mentions some of those things very briefly, which can easily pass unnoticed (e.g.: testing stuff).
I'll be digging that further over the next few days and probably write something on my personal blog, but it would be useful to have some official documentation consolidating all of this in a place easily accessible for everyone.

Just a note: I'd prefer if this "dev intro" doc was brief, and mostly just linked to other pages and markdown files. We want to avoid duplicating information, and I personally prefer a tree of doc files than a single long doc file.

Hi @danicat. Thanks for offering to help with this. We're happy to accept docs that fit into the overall doc strategy.
Probably the best next step is to put together a more detailed outline of what content you want to see in the doc. Exactly what's in the outline would help us figure out whether it's an addition to contribute.html, whether it's one new doc, multiple new docs, and so on.
/cc @tbpg FYI

/cc @ostenbom who is giving a talk at GopherCon about his difficulties when starting to contribute. I think he had trouble with tests in particular; we don't have a single doc that outlines how each part of Go is tested, and how to efficiently and properly test specific changes.

Hi again @danicat. If you would like to move forward with this proposal, see my last comment https://github.com/golang/go/issues/32741#issuecomment-505605938. Otherwise, we can close this for now, and feel free to submit a new proposal if you have a more concrete plan you'd like help evaluating.

Closing for now.


defining a validator causes mypy: maximum semantic analysis iteration count reached

Initial Checks

[X] I have searched GitHub for a duplicate issue and I'm sure this is something new
[X] I have searched Google & StackOverflow for a solution and couldn't find anything
[X] I have read and followed the docs and still think this is a bug
[X] I am confident that the issue is with pydantic (not my code, or another library in the ecosystem like FastAPI or mypy)

Description
Hi, I'm getting the mypy INTERNAL ERROR: maximum semantic analysis iteration count reached error when defining a validator in a model via a helper function. Note that declaring the type of the validator makes mypy not crash anymore (see example). Also the issue occurs only with pydantic.mypy plugin.
mypy tests/test_validators2.py
Deferral trace:
    tests.test_validators2:13
    tests.test_validators2:11
    tests.test_validators2:11
    tests.test_validators2:11
    tests.test_validators2:11
    tests.test_validators2:11
    tests.test_validators2:11
    tests.test_validators2:11
    tests.test_validators2:11
    tests.test_validators2:11
    tests.test_validators2:11
    tests.test_validators2:11
    tests.test_validators2:11
    tests.test_validators2:11
    tests.test_validators2:11
    tests.test_validators2:11
    tests.test_validators2:11
    tests.test_validators2:11
    tests.test_validators2:11
tests/test_validators2.py: error: INTERNAL ERROR: maximum semantic analysis iteration count reached
Found 1 error in 1 file (errors prevented further checking)

Example Code
import pydantic

def get_my_custom_validator(field_name: str) -> classmethod:
    @pydantic.validator(field_name, allow_reuse=True)
    def my_custom_validator(cls, v: int) -> int:
        return v

    return my_custom_validator

def foo():
    class MyModel(pydantic.BaseModel):
        number: int
        custom_validator = get_my_custom_validator("number")
        # custom_validator: classmethod = get_my_custom_validator("number")  # does not crash

    pass

Python, Pydantic & OS Version
pydantic version: 1.10.7
            pydantic compiled: True
                 install path: /home/.../.cache/pypoetry/virtualenvs/...-aO4xbsjX-py3.10/lib/python3.10/site-packages/pydantic
               python version: 3.10.4 (main, Apr 27 2022, 18:18:04) [GCC 9.4.0]
                     platform: Linux-5.14.0-1054-oem-x86_64-with-glibc2.35
     optional deps. installed: ['dotenv', 'typing-extensions']

mypy: both 1.0.1 and 1.1.1 give the same error

pyproject.toml configuration:

[tool.mypy]
python_version = "3.10"

plugins = [
  "pydantic.mypy"
]

check_untyped_defs = true
ignore_missing_imports = true
namespace_packages = true
strict = true

disallow_any_generics = false
disallow_incomplete_defs = false
disallow_subclassing_any = false
disallow_untyped_calls = false
disallow_untyped_decorators = false
disallow_untyped_defs = false
no_implicit_optional = false
no_implicit_reexport = false
strict_equality = false
warn_return_any = false
warn_redundant_casts = true
warn_unused_ignores = true

[tool.pydantic-mypy]
init_forbid_extra = true
init_typed = true
warn_required_dynamic_aliases = true
warn_untyped_fields = false

Affected Components

[ ] Compatibility between releases
[ ] Data validation/parsing
[ ] Data serialization - .dict() and .json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - construct(), pickling, private attributes, ORM mode
[X] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

I believe the issue here is coming from the fact that in v1, you can have non-annotated fields, and the mypy plugin treats those as fields. I did a bit of playing with the mypy plugin and it will be a bit hard to resolve this.
Fortunately this will be easier in v2 as we don't allow un-annotated fields. In v2 you still get a spurious error saying we don't allow un-annotated fields, but at least you don't get the INTERNAL ERROR and if you ignore that error I think everything else will behave fine.
All this said, I found a tweak that seems to make all existing tests pass, though I don't fully understand what's going on. But considering all tests pass and it prevents the INTERNAL ERROR I think it's an improvement. I'll open a PR with it shortly.

This should be fixed now in the just-released v1.10.8, which should be available through PyPI shortly.


[GLUTEN-1632][CH]Daily Update Clickhouse Version (20230710)

Auto commit by gluten daily build, please check the build status and merge it if it's green.

Compatible with current gluten


Making docs and README in sync

Some sections were better in README - copied them over to docs
Some sections were better in docs - copied them over to README
No change in code

Codecov Report

Merging #5 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage   98.74%   98.71%   -0.03%
==========================================
  Files          17       16       -1
  Lines         478      467      -11
==========================================
- Hits          472      461      -11
  Misses          6        6

Impacted Files
Coverage Δ

django_query_profiler/settings.py
100.00% <ø> (ø)

..._query_profiler/query_profiler_storage/__init__.py
100.00% <0.00%> (ø)

..._query_profiler/django/db/backends/sqlite3/base.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4582c7c...ff23bde. Read the comment docs.

Codecov Report

Merging #5 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage   98.74%   98.72%   -0.02%
==========================================
  Files          17       16       -1
  Lines         478      472       -6
==========================================
- Hits          472      466       -6
  Misses          6        6

Impacted Files
Coverage Δ

django_query_profiler/settings.py
100% <ø> (ø)
:arrow_up:

..._query_profiler/django/db/backends/sqlite3/base.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4582c7c...ff23bde. Read the comment docs.


Feature Request – DataTables sorting/filtering/searching for public DBs list

Can I assign myself for this?
I'm a big boy, I can handle it.

By all means, go ahead! I've added you as a collaborator, so you can assign the ticket to yourself.
Quick question, do you want to do this on the front end (via js) or backend (via traditional request-response)?

Only on front end, because: I don't think we have more than 1000 table entries listed and for that low amount of data, even devices with lower HW capabilities have the power to do the sorting/filtering stuff.

My pleasure! Thanks for suggesting improvements and taking the action to implement them!
If you're doing it on the front end, I was thinking about the same thing for the server browser, do you think you could implement that as well? (if so, I'll open a new issue for it)

Yep, I can implement it for the server browser, too.
Do we have a dev server for testing these kind of things? If not, can you help me to set up one, please?

No dev server, but pretty easy to set up, provided you have Go installed. If you don't, I can provide you with the current dev binary and other resources. Changing html / javascript does not need server update or restart, so it should be pretty straightforward to test.
Let me know on skype if you have time and I can walk you through it.


added ansible-openshift-virt-day2 repo team

Need to add a new repository for creating Ansible content for managing day 2 operations of OCP Virt

think i did this wrong, reopening a new PR

@bontreger repositories themselves are not being tracked via Peribolos, only the team management and the association to repositories. You can make a new request for a repository by creating a new issue here

@bontreger is this repo still needed/wanted? if so, can you raise an issue as per Andys above comment

no movement - closing. if its still needed please create an issue/re-open


Support Request:

Describe Your Problem:
After installing the plugin and using the automatic account creation set up, it seems that while HomeBridge is able to see the Roomba, homekit detects it as not responding.
Expected behavior:
Since it's going through Homebridge, I would expect the accessory to work in homekit with the other accessories.
Logs:
[11/27/2022, 1:53:44 PM] [Pedro] Succefully connected to roomba Pedro
[11/27/2022, 1:53:46 PM] [Vivint] Device not (yet) supported [ID]:110 [Type]:lgit_poe_wifi_device [EquipmentCode]:undefined [Name]:Driveway-Bridge
[11/27/2022, 1:53:46 PM] [Vivint] Removing 0 accessories
[11/27/2022, 1:53:46 PM] [Vivint] Adding 0 accessories
[11/27/2022, 2:02:02 PM] [Pedro] Set Pedro To Clean

Config:
{
    "bridge": {
        "name": "Homebridge 9AD2",
        "username": "*6",
        "port": 51786,
        "pin": "*",
        "advertiser": "bonjour-hap"
    },
    "accessories": [],
    "platforms": [
        {
            "name": "Config",
            "port": 8581,
            "auth": "form",
            "theme": "auto",
            "tempUnits": "f",
            "lang": "auto",
            "platform": "config"
        },
        {
            "refreshToken": "*",
            "apiLoginRefreshSecs": 1200,
            "platform": "Vivint"
        },
        {
            "name": "Roomba",
            "email": "*",
            "password": "*",
            "roombas": [
                {
                    "autoConfig": true,
                    "info": {
                        "ver": 2
                    }
                }
            ],
            "manualDiscovery": false,
            "lowBattery": 20,
            "offAction": "pause:dock",
            "status": "cycle:clean",
            "eveStatus": "inverted:cycle:clean",
            "bin": "filter:contact",
            "ignoreMultiRoomBin": false,
            "hideStuckSensor": false,
            "disableMultiRoom": false,
            "platform": "iRobotPlatform"
        }
    ]
}

Node Version:
v18.12.1
NPM Version:
8.19.2
Homebridge Version:
8.19.2
Plugin Version:
2.1.16
Operating System:
Ubuntu

Please try the latest beta:

Looks like it's detecting it now when it's online. Though it seems like it's still being shown as a fan though, I'm guessing that's something being worked on since I think I recall seeing other threads about it.


Fixed Mac icon size and updated the 'plus' to match the actual Aquarius+ Logo

I fixed the Mac icon size to match Mac App icons.  I had selected iOS size before which make the icon bigger than the others when on the Mac dock.  I also updated the 'plus' to better match the actual logo.
I have also included the updated Windows .ico file.  This one matches what Microsoft recommends with a transparent background.  I have included the original PNG in case you would like to add back the white background.
AquariusPlusEmu_icons.zip

Thank you. I need to check if the windows icon will be visible enough. It might needs the white outline on the whole icon (not just the '+').

Ok, I checked on Windows. Looks fine! Thanks again.


Gallery home page sprites demo drops dart and gpu frames

Add showPerformanceOverlay: true to the MaterialApp in app.dart to see.

Fixed!


Any plan to use PagedListAdapter from arch-component?

android.arch.paging.PagedListAdapter

Haven't looked at how they would integrate yet, but it's a cool idea. Should be a separate artifact especially since the paging lib is still in alpha.


Add http 429 error handling

This pull request included an error handling process while handling HTTP 429 TOO MANY REQUESTS error.
Here's a sample of matrix.org's HTTP 429 reply:

{'errcode':'M_UNKNOWN', 'error': '{"errcode":"M_LIMIT_EXCEEDED","error":"Too Many Requests","retry_after_ms":3438}'}

Which would cause an uncaught KeyError in the original implementation.
Also, in order to deal with other non-standard 429 replies, I added a default_429_wait_ms=5000 attribute to be used as a default waiting time if the server didn't provide one.
Signed-off-by: Andy Fu<EMAIL_ADDRESS>

I believe this is addressing same bug as https://github.com/matrix-org/matrix-python-sdk/issues/193. @eternal-flame-AD are you seeing this behavior on all 429 responses or just a subset of them?

(We'll keep #193 open even after merging this to track the upstream issue with Synapse.)

I saw this behaviour every time I triggered a 429 response at matrix.org home server.

I will update the documentation later this day.

LGTM. Thanks!


All DoH endpoint return NXDOMAIN for pretty much any domain, DoT & DoQ works normally

dnslookup google.com https://dns.dnswarden.com/g
dnslookup 1.10.1-11687
Server: https://dns.dnswarden.com/g

dnslookup result (elapsed 272.164527ms):
;; opcode: QUERY, status: NXDOMAIN, id: 57709
;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version 0; flags:; udp: 1232
                                                                                ;; QUESTION SECTION:
;google.com.    IN       A

It works fine at my fine. Can you re-check it?
 .\dnslookup.exe google.com https://dns.dnswarden.com/g
dnslookup v1.10.1
Server: https://dns.dnswarden.com/g

dnslookup result (elapsed 114.2265ms):
;; opcode: QUERY, status: NOERROR, id: 11108
;; flags: qr rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 0

;; QUESTION SECTION:
;google.com.    IN       A

;; ANSWER SECTION:
google.com.     165     IN      A       <IP_ADDRESS>

Still failing here, I've tried from my local ISP, Warp, and my VPS in Japan. Curl also fail
ubuntu@arm:~$ curl -I https://google.com --doh-url https://dns.dnswarden.com/g -v
* Found bundle for host dns.dnswarden.com: 0xaaaace510580 [serially]
* Server doesn't support multiplex (yet)
*   Trying 2a09:8280:1::1:da1b:443...
* TCP_NODELAY set
* Hostname 'dns.dnswarden.com' was found in DNS cache
*   Trying 2a09:8280:1::1:da1b:443...
* TCP_NODELAY set
* Connected to dns.dnswarden.com (2a09:8280:1::1:da1b) port 443 (#1)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*   CAfile: /etc/ssl/certs/ca-certificates.crt
  CApath: /etc/ssl/certs
* Connected to dns.dnswarden.com (2a09:8280:1::1:da1b) port 443 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*   CAfile: /etc/ssl/certs/ca-certificates.crt
  CApath: /etc/ssl/certs
* SSL connection using TLSv1.3 / TLS_AES_128_GCM_SHA256
* ALPN, server accepted to use h2
* Server certificate:
*  subject: CN=dns.dnswarden.com
*  start date: Mar 21 04:11:56 2024 GMT
*  expire date: Jun 19 04:11:55 2024 GMT
*  subjectAltName: host "dns.dnswarden.com" matched cert's "dns.dnswarden.com"
*  issuer: C=US; O=Let's Encrypt; CN=R3
*  SSL certificate verify ok.
* Using HTTP2, server supports multi-use
* Connection state changed (HTTP/2 confirmed)
* Copying HTTP/2 data in stream buffer to connection buffer after upgrade: len=0
* Using Stream ID: 1 (easy handle 0xaaaace53e5a0)
> POST /g HTTP/2
Host: dns.dnswarden.com
accept: */*
content-type: application/dns-message
content-length: 28

* We are completely uploaded and fine
* SSL connection using TLSv1.3 / TLS_AES_128_GCM_SHA256
* ALPN, server accepted to use h2
* Server certificate:
*  subject: CN=dns.dnswarden.com
*  start date: Mar 21 04:11:56 2024 GMT
*  expire date: Jun 19 04:11:55 2024 GMT
*  subjectAltName: host "dns.dnswarden.com" matched cert's "dns.dnswarden.com"
*  issuer: C=US; O=Let's Encrypt; CN=R3
*  SSL certificate verify ok.
* Using HTTP2, server supports multi-use
* Connection state changed (HTTP/2 confirmed)
* Copying HTTP/2 data in stream buffer to connection buffer after upgrade: len=0
* Using Stream ID: 1 (easy handle 0xaaaace538df0)
> POST /g HTTP/2
Host: dns.dnswarden.com
accept: */*
content-type: application/dns-message
content-length: 28

* We are completely uploaded and fine
* old SSL session ID is stale, removing
* Connection state changed (MAX_CONCURRENT_STREAMS == 100)!
< HTTP/2 200
< date: Sun, 19 May 2024 07:13:42 GMT
< content-length: 39
< server: dnswarden-sin
< content-type: application/dns-message
< strict-transport-security: max-age=31536000; includesubdomains; preload
<
* Connection #1 to host dns.dnswarden.com left intact
* a DOH request is completed, 1 to go
* old SSL session ID is stale, removing
* Connection state changed (MAX_CONCURRENT_STREAMS == 100)!
< HTTP/2 200
< date: Sun, 19 May 2024 07:13:42 GMT
< content-length: 39
< server: dnswarden-sin
< content-type: application/dns-message
< strict-transport-security: max-age=31536000; includesubdomains; preload
<
* Connection #0 to host dns.dnswarden.com left intact
* a DOH request is completed, 0 to go
* DOH: Bad RCODE type A for google.com
* DOH: Bad RCODE type AAAA for google.com
* Closing connection 0
curl: (6) Couldn't resolve host name

Seems to work fine currently

I have the same problem. I've tried it on Chrome built-in DNS settings and PersonalDNSFilter (Android).

@h1toru No, it's different from this issue. It has been weeks now since it returned 502, I've given up

@tina-hello @h1toru , something is really wrong with DoH and I didn't notice it until now. 502 error is new, let me see what is happening as i haven't touched or tweaked anything in a while.

@bhanupratapys This is most likely a dupe of #41

@h1toru No, it's different from this issue. It has been weeks now since it returned 502, I've given up

i see. i don't have enough knowledge to know that, but yeah it's not working for quite sometime now.


Inconsistent Cart Total on cart page vs Review checkout page

Environment Details

Spartacus: dev branch
Browser: chrome

Steps to Reproduce
Add qty 1 of product1 to cart
Add qty 2 of product2 to cart 0 -> It should show 3 items in mini cart
Go to cart page -> It says cart total (3 items)
Proceed to the "Review" Step of checkout
Observed Results

On cart page, the number of items is the total number of items in cart.
On Review checkout page, the number of items is the total number of different items in cart.
The cart total on cart page is different to the cart total on Review Checkout page.

Spike what's wrong and talk to your tech lead and Bill about the solution.

Tested. Items cart total now is displayed properly on review page.


[Feature request] Allow Franz to live solely in the Mac's menu bar

I was hoping you could add an option to hide Franz from the dock, and be able to open it with just a click on the menu bar icon.
Feature Description
On Mac, a checkbox would allow you to hide the icon in the dock, and keep it solely in the menu bar. When Franz is not the active window (i.e. the window is closed or behind another app's window, but Franz is still running), clicking on the menu bar icon would open the window. If Franz is the active window, then clicking on the menu bar icon will show a dialog box with the quit option, much like it does now.
Motivation and Context
Many apps that mostly run in the background implement this feature. In particular, the "clicking on the menu bar icon to open the window, and clicking again to show the quit button" is something done by AirMail. These features are especially useful when I constantly keep an app open (e.g. for notifications), but only occasionally want to see the window.

Not a full solution but until (or if) this gets implemented you can hide mac apps by editing the plist file.
https://lifehacker.com/5280456/hide-your-mac-menu-bar-and-dock-for-a-cleaner-desktop
Keep in mind if you want the icon back you'll have to manually update the plist again.


Bug 1486449 - Allow Council to invite new Reps

I'll have a look into the failed test tonight.

I'll have a look into the failed test tonight.

I'll have a look into the failed test tonight.

Mh, this must have been some kind of dependency update or something along that, as this also fails on master now: https://travis-ci.org/mozilla/remo/jobs/423322060
@akatsoulas could you have a look at this as I would like to have a deployment after merging this PR here? Thanks so much in advance!


feat: add edit comment feature

Overview
Closes #76
This pull request adds edit an existing report feature. It's disabled by default.

Gotta add more tests it seems. Have to keep it at 90%+


fix: Update Orchestrator core to remove Tar dependency on 6.1.0

Description
Compliance fix - remove dependencies on tar 6.1.0 and below, all tar deps resolve to 6.1.6 now
Task Item
#minor

Coverage remained the same at 55.895% when pulling 2bc3ce41c8265117b90984024c47a72e7f2d33c4 on tachou/orchTarCompliance into 019cdc4642a5898d2ea4c440ac264aed6fcd3c44 on main.

@taicchoumsft there are still some issues with the tar dependency. Could we have missed a spot?
[INFO] |CVE-2021-32803                          |tar 6.1.0                               |High                          |                              |
[INFO] |||||
[INFO] |CVE-2021-32804                          |tar 6.1.0

@taicchoumsft there are still some issues with the tar dependency. Could we have missed a spot?
[INFO] |CVE-2021-32803 |tar 6.1.0 |High | |
[INFO] |||||
[INFO] |CVE-2021-32804 |tar 6.1.0

Thanks for the links @cwhitten , the logs show we have some other instances, for instance in packagemanager: https://github.com/microsoft/BotFramework-Composer/blob/019cdc4642a5898d2ea4c440ac264aed6fcd3c44/extensions/packageManager/yarn.lock#L4252
Will fix now.

Thanks very much Tai!


Need help to add Middleware to the Producer Or Can I extend the ProduceBuilder to add more Handler.

Description
ASP.Net core C#
I am trying to add the OpenTelemetry Kafka Instrumentation - Distributed Tracing to Producer. The Kafka Instrumentation is 100% working.
I need to add this Instrumentation to Producer as a middleware or separate handler where I can easily hook or unhook this.
I would like to whether we can add a middleware to the Producer. If yes, could any one provide the sample program.
Also, I am looking at the other option of extending the ProducerBuilder to add the handler  - say TracingHandler.
How do I extend this and use the ProducerBuilder class?

it doesn't extend easily. i think you'd need to create a new ProducerBuilder class that replicated all the existing methods + added your new handler. And this would return a different type of Producer, which wraps the existing one to intercept the produce calls and delivery results. You wouldn't necessarily have to keep the builder pattern - you could have a different style of api.

I have a similar use case @Leela-SR, and I'm solving it with KafkaFlow, which is built on top of Confluent's .NET Client and exposes that kind of functionality.
https://farfetch.github.io/kafkaflow/docs/guides/middlewares/

I have resolved the Middleware problem using Chain of Responsibility Pattern.
I add the Middleware (handlers) to LinkedList and execute the handlers on ProduceAsync call.


heatmap only

Is there a way to only use the heatmap (false.glsl)
I tried adding it as a toggle and all I get is a greyscale in all content (sdr/hdr) [with and without hdrtoys.js in the scripts dir]
CTRL+a change-list glsl-shaders toggle "~~exe_dir/shaders/false.glsl" ; show-text "Heatmap"

The attached file is what happens when I toggle the shader

it would be nice to have a heatmap on demand, but idk whats up.

only use the heatmap

All things in hdr-toys.conf are required, just replace tone-mapping to false. if you add false.glsl only, mpv won't feed hdr image to shaders.

Append include=~~/hdr-toys.conf to your mpv.conf

https://github.com/natural-harmonia-gropius/hdr-toys/blob/master/hdr-toys.conf

copy, I'll play around with it later.
I'm not trying to setup the whole suite right now -- but I'd love a luminance heatmap shader (similar to the HDR WCG JXR viewer app)


[BUG] Conflict between Simple Calendars Chinese Translation and the Simplified Chinese FVTT Core Translation module

Seems like SC has some confict with Simplified Chinese FVTT core translation with PF2E.
I only turn on the Chinese core trans module and SC, and all actor all unable to use.
If I delete the cn.json in the lang, problem solved.
And I noticed that after the last release some commite has been approved into cn.json, so I wonder could you please publish a new realse to see if the conflict can be fixed? Thank you.
(FVTT 10.285 SC 2.1.10 FVTT core chinese translation module 10.285)

This has been fixed in version 2.1.18


Front end file size validation

disregard the previous commits... I had a requestType property before I realized there was a dropletOptions object.

Excellent addition! :+1: Although is there any chance we could bundle the filesizeLimit as part of the options configuration to be consistent?

Given this logic, the mimeTypes should also be in there.

On Jan 14, 2015, at 6:24 PM, Adam Timberlake<EMAIL_ADDRESS>wrote:
Excellent addition!  Although is there any chance we could bundle the filesizeLimit as part of the options configuration https://github.com/macroplant/EmberDroplet/blob/file-size-validation/dist/ember-droplet.js#L160 to be consistent?
—
Reply to this email directly or view it on GitHub https://github.com/Wildhoney/EmberDroplet/pull/80#issuecomment-70019692.

I agree :+1:

Thanks! :beers: All merged.


disk corruption issues

Hello,
A couple of problems I encountered while using ExFat.DiscUtils with a vmdk virtual disk formatted ExFat:

The below code was used to copy files placed in a host directory to an empty directory in a VM.
Then, we power on the VM ,delete the files from the VM manually via file explorer, then power off the VM.
Doing this a couple of times (copying files to VM then deleting them and re-copying) with lots of files or directories causes disk corruption.
Specifically, fill the host directory with 300-400 files, execute the given code, then delete the files copied into the VM (manually).
After repeating this a couple of times the file system becomes corrupted.
This has been reproduced a couple of times but seems a bit random.

Copying an empty file (can be done with the below code) causes disk corruption.
It seems this happens every time we copy empty files.

Code used:
private static void Test(string vmdkPath, int partitionNumber, string pathInHost, string pathInVm)
{
	using (VirtualDisk disk = new DiscUtils.Vmdk.Disk(vmdkPath,FileAccess.ReadWrite))
	using (ExFatFileSystem fs = new ExFatFileSystem(disk.partitions[partitionNumber].Open()))
	{
		string[] hostDirFilePaths= Directory.GetFiles(pathInHost, "*.*", SearchOption.TopDirectoryOnly);

		foreach (string hostFilePath in hostDirFilePaths)
		{
			string vmFilePath = Path.Combine(pathInVm, Path.GetFileName(hostFilePath));

			string dst = Path.Combine(fs.Root.FullName, vmFilePath);

			using (Stream dstStream = fs.OpenFile(dst, FileMode.Create, FileAccess.ReadWrite))
			using (Stream sourceStream = File.Open(hostFilePath, FileMode.Open, FileAccess.Read))
			{
				CoptStream(sourceStream, dstStream);
			}
		}
	}
}

private static void CopyStream(Stream srcStream, Stream dstStream)
{
	int bufferLength = (int)Math.Min(srcStream.Length, 4*1024*1024);
	byte[] buffer = new byte[bufferLength];
	int bytesRead= 0;

	while((bytesRead = srcStream.Read(buffer,0,bufferLength))>0)
	{
		dstStream.Write(buffer,0,bytesRead);
		if(bytesRead < bufferLength)
		{
			break;
		}
	}
}

Thanks,
Chris

It sure looks like a bug. I'll take a look at it.

I guess that creating an empty file causes the same problem too.

Regarding problem 1. If you find a way to reproduce it all the time, I'm interested. Also, if you have a chkdsk log explaining it, I'm also interested.

@chrisrob5349 a version 0.9.9 was released and fixes empty files error. However I need to search more regarding your random error, so any reproductible code is very welcome 😄

I added a test named RandomReadWriteTest in class EntryFilesystemWriteTests: it randomly adds and removes files, but does not seem to fail (the .vhdx in checked by chkdsk after test).
So if you find something to help, it will help 😉

Hi,
Appreciate the fast response!
I've looked into it again, and it seems creating files does work fine.
It seems the corruption happened because the following two lines from my code snippet:
using (VirtualDisk disk = new DiscUtils.Vmdk.Disk(vmdkPath,FileAccess.ReadWrite))
using (ExFatFileSystem fs = new ExFatFileSystem(disk.partitions[partitionNumber].Open()))
were originally  (same but without the using statements):
VirtualDisk disk = new DiscUtils.Vmdk.Disk(vmdkPath,FileAccess.ReadWrite)
ExFatFileSystem fs = new ExFatFileSystem(disk.partitions[partitionNumber].Open())
So it seems that not properly disposing the VirtualDisk, ExFatFileSystem objects causes corruptions.
In addition, I am getting corruptions when copying directories from host to VM.
I am getting these when copying simple directories like empty directories or directories with only a few files inside.
Chkdsk results arent informative, typically being "Corruption was found while examining files and directories".
If you could test moving\creating directories, It would be great.
Anyways, I will try to pinpoint my errors and find reproducible code.
Thanks!

That's the opposite: not disposing the disk will cause corruption.
There is a new version 0.9.10 released, you can already use it.
Now I am going to implement move tests.


Dev 1289 cms improvements

feat: sort media by most recently uploaded & auto focus search

Hi @cameronnapoli, this is great work of the Firebase backend, but I'm not sure we want to include firebase as a core dependency (it's quite big). How about publishing it as a separate package?
Also, I'm not sure I understand the other sort media change.
Can you link to existing issues/open new ones for both changes?

Closing for now


Userinfo command bugged

The user info command doesn't work when users outside of the server are provided

Fixed, cause not possible


Changing os.path to posixpath to prevent issues

Changing os.path to posixpath to prevent issues when using pyminio in Windows environments.
os.path uses the current system file system separator and adjust all its functions to that. MinIO is always a posix path system. When using Pyminio in a Windows system, the paths got undesirable changed, because os.path set them to comply with Windows file system format.
This update prevents that issue to happen.

[X] All tests are green.

Related issue:
https://github.com/IamTugy/pyminio/issues/36

@novama Perfect!!
any chance you could create a tests with the failed path?


gntp.errors.NetworkError: [Errno 61] Connection refused

Hello I am getting this error. Please help me. I am new to this.
import gntp.notifier
gntp.notifier.mini("Here's a quick message")

Error:
Growl error
Traceback (most recent call last):
  File "/Users/mayukhsarkar/anaconda3/lib/python3.6/site-packages/gntp/notifier.py", line 197, in _send
    s.connect((self.hostname, self.port))
ConnectionRefusedError: [Errno 61] Connection refused

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/mayukhsarkar/anaconda3/lib/python3.6/site-packages/gntp/notifier.py", line 243, in mini
    result = growl.register()
  File "/Users/mayukhsarkar/anaconda3/lib/python3.6/site-packages/gntp/notifier.py", line 98, in register
    return self._send('register', register)
  File "/Users/mayukhsarkar/anaconda3/lib/python3.6/site-packages/gntp/notifier.py", line 205, in _send
    raise errors.NetworkError(exc)
gntp.errors.NetworkError: [Errno 61] Connection refused

Do you have growl running?


createLink: Include anchor, handle test server 405

While beginning to work on the createLinkClick() function, I realized that POSTing to the local live-server instance produced a 405 without a JSON body; added logic to handle this, refactoring the existing logic in the process.
Also, after early experimentation with creating an actual short link via the user interface, realized it would be good to include the anchor for the generated link in both the success and error responses.

Coverage decreased (-0.05%) to 98.094% when pulling 41dda2a9ff08f1fa841603552dfa86067f5d6054 on ui-create-link-touchup into 5219fa59589c96f6138984285724f87215c1d94c on master.


DOT language support

Hi CodeMirror folk!
What's the chances of getting some support for DOT in CodeMirror?
https://en.wikipedia.org/wiki/DOT_(graph_description_language)
http://www.graphviz.org/Documentation.php

Not good, unless you do it yourself. See the mode wish list


Spec Counter does not have accurate damage values on ToB and CoX bosses

Is your feature request related to a problem? Please describe.
Since some of the NPCs have scaled EXP (just in general as well as varies with party size), the special counter will often give you the wrong damage amount with BGS/arclight (anything where the amount of damage is important as opposed to whether or not you actually hit like DWH), and in cases where everyone is speccing at once or in quick succession you may miss the damage amount entirely. This also happens in chambers of xeric (I believe?) and I think other bosses with scaled hp/exp as well, such as KQ (but in many of these cases barring cox/tob it isn't too relevant since presumably you'd be solo and see your own hits clearly.)
Describe the solution you'd like
If possible make the plugin read properly based on what the client witnesses you speccing as opposed to based off exp in these rooms/situations, or if possible make the plugin account for the equations/party size scalings that effect this to make it accurate.
Describe alternatives you've considered
Not much to do as an alternative in many situations where you're all speccing at once since obviously a finite amount of hits appear.

fixed in 8674a4f998ada7708de842ec98e9cc098b4c385c


logs folder is always created whenever armi is imported

An empty logs folder is created in the current working directory whenever the armi.context module is imported, which is whenever armi itself is imported. Here's the stack trace for context (no pun intended):
https://github.com/terrapower/armi/blob/7d9ef5f8c0db459da167e3330fc6aa932d0255ce/armi/__init__.py#L61
https://github.com/terrapower/armi/blob/7d9ef5f8c0db459da167e3330fc6aa932d0255ce/armi/_bootstrap.py#L37
https://github.com/terrapower/armi/blob/7d9ef5f8c0db459da167e3330fc6aa932d0255ce/armi/context.py#L333
This behavior results in an army of logs folders scattered across the user's working drive wherever an ARMI application has been executed, even if they were not used at all. We should consider creating the logs folder at runtime, as needed, instead of upon import.

Reasonable request for sure. It'd be nice to not make that many log folders. We could maybe default to a location in APPDATA/profile space so as to not clutter rundirs. I think we only need the logs folders if the number of MPI nodes is >1 anyway, so that should be pretty easy to detect and avoid.


Image Analytics: Add-on name not translated

In the Image Analytics add-on, the name in the menu refuses to translate.

Fixed via https://github.com/biolab/orange-canvas-core/pull/267.


[Fix/TFlite] Fix tflite allocation

Now, memory alllocation is handled outside of each layer.
Accordingly, allocating out tensor shouldn't be done inside a layer.
For the same reason, loss layer backwarding needs some fix, for now
it is just commented and will be handled soon
This patch handles the issue for tflite layer
Self evaluation:

Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Jihoon Lee<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.4.20191203. Thank you for submitting PR #858. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

:memo: TAOS-CI Version: 1.4.20191203. Thank you for submitting PR #858. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.


Improve website on parameters section Alignment Options for argument --save_unaligned

Description of feature
The description of parameter --save_unaligned reads: "Where possible, save unaligned reads from either STAR, HISAT2 or Salmon to the results directory." but if I got it right then does the pipeline offer mappers BWA, Bowtie2, and STAR, but not HISAT2 nor Salmon.

Thanks for reporting @aghr
Fixed by #395


os: implement os.nice

this implements os.nice (which linked to a unix system call, changing process priority) function.
with this commit, rustpyhton works as below.
>>>>> import os
>>>>> os.nice(0)
0
>>>>> os.nice(-1)
-1
>>>>> os.nice(-10)
-11
>>>>> os.nice(10)
-1
>>>>> os.nice(20)
19
>>>>> os.nice(20)
19
>>>>> os.nice(-20)
-1
>>>>> os.nice(-12)
-13
>>>>> os.nice(-100)
-20

Thank you for your kind comment!
I changed as you mentioned. please check it out.


Better Documentation on Images

How do I use the imageBuilder and imageDirectory attributes? And also what is the correct syntax for integrating images?

Hi @T0M0F
I agree documentation images could be improved


biologic_echem_extract_write_plot.py

The 'biologic_echem_extract_write_plot' code seems to place the generated .pdf figure in the png subdirectory and not the pdf subdirectory

Thanks, now it works correctly. And sorry for posting the issue in the wrong repo. Rookie mistake


remove scroll banner

please remove the scroll banner
we will check it afterwards

can you explain a bit more about the issue?

The thing is that we don't know the branding guidelines for the set of logos we are using here(because we just use them as our tech stacks and for our events, not something like sponsorships or so)

Either we can look for each logo about their branding guidelines and check if it's applicable for our use case(which is displaying the tech stacks we use without causing any legal issues), or worst case remove it.. I would prefer the first option.

i compiled all the information i could find regarding this. here

Looks like we can use only GitHub logo then..
I guess removing the whole thing should be a better option. If you feel there is a better option let us know, or else feel free to remove the logos.

We can list them as plain texts instead of the logos. I don't think there will be any problem if you don't use any of their trademarked assets.

Okay.. let me know your plan and how are you going to implement it.

@ezhil56x @Karsker  how do you think it looks? Any suggestions?

I don't think those brands would have any issues with using their logos, unless it implies, they are somehow connected with our work. We are anyway explicitly stating that we are using their products.