Resolve issue 43

Please do not peer review this PR yet. I created it only to get the Travis to run build and to check coverage diff.

Codecov Report

Merging #44 into master will increase coverage by 0.49%.
The diff coverage is 93.11%.

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   90.32%   90.81%   +0.49%
==========================================
  Files           6        6
  Lines        2056     2166     +110
==========================================
+ Hits         1857     1967     +110
  Misses        199      199

Impacted Files
Coverage Δ

pyodata/v2/model.py
91.11% <93.11%> (+0.74%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff05be5...6f98345. Read the comment docs.

Please do not peer review this PR yet. I created it only to get the Travis to run build and to check coverage diff.

There is Draft Pull Requests feature for that purpose:
https://github.blog/2019-02-14-introducing-draft-pull-requests/

Thank you!


Added Authorization token to endpoints

Added token verification for each endpoint except for Customer
To generate token using Postman:
Use the login API:

For the other APIs update the Authorization field to use the Bearer Token value
Example:

If that is not working then add the header following header:
Key: Authorization
Value: Bearer <token_value>

Endpoints have been change to account for Bearer token. Please check the updated Swagger


Added date() function to Cypher

I've begun implementing Cypher's temporal functions in AGE, beginning with date().
Here it is in action.
SELECT * FROM cypher('graph', $$
    RETURN date()
$$) as (today agtype);
    today
--------------
 "2023-08-13"
(1 row)

It could also be converted to PostgreSQL's date type, but the record returned by AGE must first be converted to any of PostgreSQL's character types (char, varchar, or text).
SELECT TO_DATE(today, 'YYYY/MM/DD') FROM cypher('graph', $$
    RETURN date()
$$) as (today text);
--
-- or
--
SELECT today::date FROM cypher('graph', $$
    RETURN date()
$$) AS (today varchar(255));

Limitations
Although the date() function in Cypher accepts an optional zone parameter to specify what timezone to return, it isn't implemented here yet. Currently, the local time zone is returned. Hopefully, that will be implemented soon.

@Allison-E
I did not find date function in the openCypher specification (your link refers to Neo4J doc, not openCypher).
Also, I was able to achieve the result using a PG function. Do you think we should add another implementaiton of date while we can use PG's?
(pg-15.4) agedev=# SELECT TO_DATE(today, 'YYYY/MM/DD') FROM cypher('graph', $$
    RETURN pg_catalog.now()
$$) as (today text);
  to_date
------------
 2023-10-23
(1 row)

@Allison-E You are not using the current master branch. The master is on 1.4.0, not 1.3.0.
@rafsun42 I think it is okay to include Neo4j functions as they created the openCypher documentation. Considering how vague and incomplete the openCypher specification can be, it is a good idea to look at Neo4j for clarifications.

Hi @rafsun42, thanks for pointing out that pg_catalog.now() could be used in your comment. I think, however, that having the date() function alongside PostgreSQL's pg_catalog.now() would make for an easier adaptation for the people who move from Neo4j to Apache AGE. @jrgemignani's comment is also valid.
@jrgemignani, I'll rebase the code to the current master branch.

@Allison-E The conflicts still exist. Also, there should not be any 'rebase' or 'merge' commit.

@Allison-E The conflicts still exist. Also, there should not be any 'rebase' or 'merge' commit.

All done, @rafsun42.

@Allison-E The date function does not work with the examples in this page.

@Allison-E The date function does not work with the examples in this page.

Sorry, I don't think I understand, @rafsun42. Can you please describe what you are trying to do that isn't working?

@Allison-E
The following query does not work. The date function should be able to take a single argument as shown in the PG's doc.
SELECT * FROM cypher('graph', $$ RETURN date('1999-01-08') $$) as (a agtype);

ERROR:  function ag_catalog.age_date(agtype) does not exist
LINE 1: SELECT * FROM cypher('graph', $$ RETURN date('1999-01-08') $...
                                                    ^
HINT:  No function matches the given name and argument types. You might need to add explicit type casts.

@rafsun42, I was hoping to work on that soon.


render#domReady: this => self

Within the context of the domReady() function, this no longer refers to the Dataviz instance--need to use self instead.
Thanks!

Nice catch, thanks @theopolisme 👍  I'll get this merged and prepped for a release shortly.

Thanks for your contribution @theopolisme! Could you please send a quick message to<EMAIL_ADDRESS>


Documentation misleading on IMPORT data

Hi,
I was trying to understand how the data can be imported to crate. I used 'crash' to connect to a remote crate node. Then I populated a json file in my local machine (where crash is running). I tried to do COPY FROM providing the file:// URL and the data was never getting imported.
I had to re-read the documentation 5 times to catch on the point that the file to be imported should be locally present to the crate node to import. Can the documentation be made cleared regarding this aspect.
Not everyone would be running crate and crash on the same instance.
-Nibin

hi @nibin
thanks for the feedback! we'll try to improve the documentation about COPY FROM.
also, we're happy to take contributions 🤗
https://github.com/crate/crate/blob/master/blackbox/docs/sql/dml.txt#L378 would be the starting point

Hi, @nibin thanks for the feedback - we have improved our docs in that area, but since it is quite complex to explain we hope to have written something that is easier to understand :)
https://crate.io/docs/reference/en/latest/sql/reference/copy_from.html#file
Cheers!


problem with Windows authentication using Identity server

Question
Hello guys,
I m using identity server with windows authentication and i get this error, after the redirection to my application (an MVC core v 3.0). the error is in the attached image.

notice that the authentication using windows works (when display identity server page, it show me that i m logged in ), but the error occurred when OpenIdConnectHandler try to deserialize some object to json (view attached file error's message).

this is what i got by hooking the OpenIdConnect Middleware event

I dont know if I missed my configuration at some point or this is a bug.
Thank you in advance for your answer.
Minimal working example
   // <code goes here>

Relevant parts of the log file
An unhandled exception occurred while processing the request.
ArgumentException: IDX21106: Error in deserializing to json: '[PII is hidden. For more details, see https://aka.ms/IdentityModel/PII.]'
Microsoft.IdentityModel.Protocols.OpenIdConnect.OpenIdConnectMessage..ctor(string json)

OpenIdConnectProtocolException: Failed to parse token response body as JSON. Status Code: 500. Content-Type: text/html; charset=utf-8
Microsoft.AspNetCore.Authentication.OpenIdConnect.OpenIdConnectHandler.RedeemAuthorizationCodeAsync(OpenIdConnectMessage tokenEndpointRequest)

Exception: An error was encountered while handling the remote login.
Microsoft.AspNetCore.Authentication.RemoteAuthenticationHandler<TOptions>.HandleRequestAsync()

Stack Query Cookies Headers Routing
ArgumentException: IDX21106: Error in deserializing to json: '[PII is hidden. For more details, see https://aka.ms/IdentityModel/PII.]'
Microsoft.IdentityModel.Protocols.OpenIdConnect.OpenIdConnectMessage..ctor(string json)
Microsoft.AspNetCore.Authentication.OpenIdConnect.OpenIdConnectHandler.RedeemAuthorizationCodeAsync(OpenIdConnectMessage tokenEndpointRequest)

Show raw exception details
OpenIdConnectProtocolException: Failed to parse token response body as JSON. Status Code: 500. Content-Type: text/html; charset=utf-8
Microsoft.AspNetCore.Authentication.OpenIdConnect.OpenIdConnectHandler.RedeemAuthorizationCodeAsync(OpenIdConnectMessage tokenEndpointRequest)
Microsoft.AspNetCore.Authentication.OpenIdConnect.OpenIdConnectHandler.HandleRemoteAuthenticateAsync()

Show raw exception details
Exception: An error was encountered while handling the remote login.
Microsoft.AspNetCore.Authentication.RemoteAuthenticationHandler<TOptions>.HandleRequestAsync()
Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

Please, still waiting for a guidance if any one has an idea about the cause of this exception.


ipfs interoperability / integration

Camlistore and IPFS seem potentially complementary.
Services that IPFS might be able to provide to Camlistore:

A decentralized (encrypted) blobstore (although not sure how enumeration would work)
A convenient publishing mechanism that doesn't require the original node to say online ("permanent")
Maybe discovery/key exchange/trust?

What is IPFS please ?

It's a global distributed filesystem, sort of like a Bittorrent swarm exchanging Git objects.
eg:
ipfs add -r ~/
...
added QmTK7afhbEgSYv5659RDsD6t3oA4nmkYuszejnTbWCrQDa /Users/eric/go/src/camlistore.org/pkg/wkfs
added QmPkqztr9CUF1aXQwkXU5DdcAEByJho6J2ooUyg4cb65XC /Users/eric/go/src/camlistore.org/pkg

and now I can access that directory from other IPFS nodes:
http://gateway.ipfs.io/ipfs/QmPkqztr9CUF1aXQwkXU5DdcAEByJho6J2ooUyg4cb65XC/fs/
There are definitely some thorny areas of overlap (they both support chunking, have a static filesystem schema) but it seems like the two projects have very different and complementary aims.

I've done some work over the weekend, and have gotten camlistore to work with the same multihash keys as IPFS. My next step is to try to make camlistore work as a datastore for ipfs and vice versa.

@aslakg any update on your work or observations of ipfs and perkeep?

I wired up blob storage but had some issues.

sha-224 vs ipfs hashing is suboptimal
chunking is done differently
EnumerateBlobs is really hard to implement.  I ended up using IPLD links and advancing and tracking a head node.  You want something like unixfs and a global lock to update the latest head.

Would love to compare what I have with the version by @aslakg

@lindner i think this is @aslakg's branch https://github.com/perkeep/perkeep/compare/master...aslakg:multihash

@lindner Do you think possible to avoid a global lock by using a consensus algorithm? Because of bitcoin crypto-commerce boom there are so many academic and startup teams plus the Linux Foundation umbrella Hyperledger blockchain projects. Focused on trying to avoid a 'global lock' because it produces a 'global block' that impacts scalability.
On a different thread inquiring about multi-user and IPFS @mpl recently answered
"I don't think there's any plan for now at how to implement multi-user,
except probably the existing "user == gpg key identity" relation as
the basis of it all.
So, maybe?"
Block Chain Smart Contracts Working group in Seattle has been working thru IPFS integration.  https://www.meetup.com/Blockchain-Smart-Contracts-Seattle-Working-Group/events/252474449/
Also I tired deploying Camlistore for https://foodlifeline.org/ cooler (since discontinued). We encountered multi-user issues. Our brute force solution was to turn the system off overnight and back-on-again in the morning (thus literally avoiding any conflicts). This got me involved with Hyperledger and thinking about consensus algo to deal with multi-user issues.

@cliveb to clarify, when I said "maybe?", I actually meant I have no idea and opinion on the subject for now. :-)

Maybe I can tempt @bradfitz to come out to speak on the Merkle Ecosystem on 9/4 or 9/18. Because privacy is important to families (multi-users). https://www.meetup.com/Blockchain-Smart-Contracts-Seattle-Working-Group/events/254017318/

I would like to second (nteenth?) interest in this. IPFS seems likely to gain traction as a backbone for a number of different distributed web projects, and being able to leverage both that work and the potential visibility of being a compelling high-level application of that technology seems like it could benefit Perkeep in some significant ways.

Question: Does IPLD conflict with Perkeep's approach?
https://github.com/ipld/ipld

There are some issues with IPFS

hashing/chunking strategy are different.
IPNS provides stable names vs permanodes.  Permanodes are better.
Perkeep has indexing over a single data set, IPFS doesn't.
to store private data you will want to either use private ipfs instances
or you will need to encrypt.
IPFS doesn't have an easy way of enumerating blobs.

I'm a bit overloaded at the moment, so I haven't had a chance to work on
this for a while.  I'd be interested in seeing where convergence with some
underlying IPFS tech takes us.  I do like multformats work (
https://github.com/multiformats)
On Mon, Oct 15, 2018 at 1:12 PM Micah Redding<EMAIL_ADDRESS>wrote:

Question: Does IPLD conflict with Perkeep's approach?
https://github.com/ipld/ipld
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/perkeep/perkeep/issues/625#issuecomment-429996125,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAF5y8Fmp1Y1LYam7wZSfGy0mqGQr044ks5ulOwcgaJpZM4FKDqL
.

Yes, I was imagining Perkeep being built on top of a private IPFS instance. Are there reasons that wouldn't work?

Are there any updates on this?

From the comparison with IPFS :

Perkeep should probably have an IPFS backend.

Is there such a backend available now?


feat(input): Style and animate textarea according to Material Design

Bug, feature request, or proposal:
Text areas are not styled according to current Material Design guidelines.
What is the expected behavior?
Text areas should be outlined in a rounded box with hover and ripple animations.
What is the current behavior?
Text areas are basically unstyled.
What are the steps to reproduce?
Create a text area using md-input-container and mdInput:
    <md-input-container floatPlaceholder="always">
      <md-placeholder>Placeholder</md-placeholder>
      <textarea mdInput type="text" required></textarea>
      <md-hint>Hint Text</md-hint>
      <md-error>Error Message</md-error>
    </md-input-container>

What is the use-case or motivation for changing an existing behavior?
Using multi-line text areas with whitespace consistent with the rest of Material Design.  The current behavior styles text areas as resizable text inputs with extra initial height, which looks wrong.
Which versions of Angular, Material, OS, browsers are affected?
Angular 4.0.1, Material 2.0.0-beta.3

Dupe of #3984

fgfg


tinysparql: upstream patch to fix a test that is broken on some platforms

Adds the upstream fix of the upstream issue 474 as a patch.

cc @emilazy as follow up from https://github.com/NixOS/nixpkgs/pull/343907
Things done

Built on platform(s)

[X] x86_64-linux (gnu)
[X] x86_64-linux (musl)
[X] aarch64-linux (gnu)
[X] riscv64-linux (gnu)
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build pkgsMusl.tinysparql


Resizing vscode panes is very laggy

Resizing panes in vscode causes the area of the preview window to change. The preview keeps getting updated while resizing, causing it to become very laggy.
To Reproduce
(See video as well)

Open a .typ file
Open the preview in a different pane.
Try resizing the code pane by dragging the separator with the mouse.
The resizing is very laggy.

https://github.com/Enter-tainer/typst-preview/assets/46323945/1331430e-1f57-4669-926f-75065e9551e4
Expected behavior
The preview doesn't cause the resizing to be laggy. (Using just the pdf viewer in vs code doesn't have this problem at all). I don't know enough of the technical implementation of this extension, to know what it "should" do, but I imagine it can postpone the (expensive) updates until the mouse is released again.
Package/Software version:
VSCode version(Help -> About):
Version: 1.82.1
Commit:<PHONE_NUMBER>d557a81c9d0b5f8a5a1e9274db5585

Date: 2023-09-08T08:41:36.199Z
Electron: 25.8.0
ElectronBuildId: 23503258
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 6.4.6-76060406-generic

typst-preview extension version: v0.8.0

PR #120 should resolve this issue a little bit. Please wait for the next release!


How to save and load the trained model?

How to save and load the trained model?

for saving you can do(assuming model name is 'model'):
model.save("somename.model")
or if model name is eg model_ppo then:
model_ppo.save("somename.model")
for loading the model (assuming its uploaded to your notebook  ):
model_ppo=model_ppo.load("somename.model")


Fix typo in base_estimator::infer

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Run the algorithm when the slice order is unknown

Hi, thanks for sharing the code. I wonder if it is possible to use the algorithm when the slice order is unknown, i.e., svr.ParZ.SlOr is unknown. I tried to set svr.ParZ.SlOr to an empty array, but got the following error: Inappropriate slice order identified, SKIPPING. Is there a solution to this problem?

Hi Junshen, that's a good point. Would recommend setting
for v=1:NV
svr.slOrd{v}=([1:4:NY(v,3) 3:4:NY(v,3) 2:4:NY(v,3) 4:4:NY(v,3)])';
end
with NV the number of stacks and NY(v,3) the number of slices of stack v. This is 2x temporal subdivision of stack acquisition with 2 levels, so kind of natural choice for distributed coverage of slice axis in the absence of other information. Have checked that it is suboptimal when compared to real order of slices, but for certain orderings may provide acceptable results.
Hope it helps, any other question, don't hesitate to raise.

Thanks for answering. Will try this setting.


support gulp.src, gulp.dest

e.g.
gulp.src(['*.js', '*.json'])
.pipe(electron({ ... }))
.pipe(gulp.dest('release'))

yeah, this is how this should work. right now this makes no sense

+1

+1

+1

+1

This looks like a great project, but it is not able to fit in with complex gulp pipelines because of the non-standard syntax.


Vscode crashes sometimes when performing some actions like closing a file

I am using vscode-insiders for a relatively long time on linux with a screenreader. That may be relevant as it's likely this bug is triggered by screenreader usage.
Generally sometimes when performing some actions, vscode crashes. I have hard time describing that because it doesn't always happen, however:
When the vscode is set to open new untitled file on startup, then closing this file quite often triggered this crash. I saw it also sometimes being triggered by closing editors displaying extension info, by switching views, etc. It's quite random, but not rare, and affects both electron6 and electron7 versions of vscode including newest insiders build.
Environment:
os: linux
using orca screenreader from git master (if relevant)
vscode version info from about dialog:
Version: 1.42.0-insider
Commit: ae08d5460b5a45169385ff3fd44208f431992451
Date: 2020-02-05T20:04:52.050Z
Electron: 6.1.6
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Linux x64 5.5.2-arch1-1

Well, I am not sure if it is the same bug, but I can trigger a segfault by pressing esc key in the explorer view, in the file tree. Not sure if that is still reproducible in electron7, need to wait for appropriate build to test it.

Can you please follow the steps in https://github.com/Microsoft/vscode/wiki/Native-Crash-Issues to get at more details around the crash and attach the result here? Thanks!

Seems to me like current upgrade to electron7 may have fixed this bug. There are slowdowns, but no crash this day, and this never happened before.


WIP: [Release] Verify release-17.0.0-rc2

PR to verify Release Candidate

@github-actions crossbow submit  --group verify-rc-source --param release=17.0.0 --param rc=2

@ursacomputing please benchmark

@ursabot please benchmark

@github-actions crossbow submit  --group verify-rc-binaries --group verify-rc-wheels --param release=17.0.0 --param rc=2

The verify-rc-binaries-wheels-windows is the exact same issue as on 16.0.0 which was not a blocker (ORC failure if TZDIR is not set): https://github.com/apache/arrow/pull/41235#issuecomment-2060264968
The verify-rc-binaries-wheels-linux-conda-latest-amd64 seems to be an issue. I am trying to understand what the problem is.


Install with patch supported?

Does this plugin support installing neovim with patch?
asdf-python supports Install with --patch.

Hello 👋🏼
I believe it partially supports it. You can install any given branch or even a specific commit:
https://github.com/richin13/asdf-neovim/blob/1fb2f664449c57fa9b236094b947eb2e1d969ddf/bin/utils.sh#L45-L48
It should work as long as the url https://github.com/neovim/neovim/archive/${version}.tar.gz for whatever value for ${version} you choose 👍🏼

Hey @twnaing, not sure if this is the functionality you were looking for but I discovered there was a bug when trying to install neovim using a specific commit. The bug's was fixed in 5b19ea5 👍🏼
Usage:
asdf install neovim ref:1f1863ed54355c314a5016560809e65c3fb0cb79

(Also pushing closed this automatically, feel free to re-open it the resolution doesn't satisfy you)

@richin13 I think it is not. This feature let user install any (specific commit or stable) with provided patch.
If you look at the link I provided, you will better understand, I think.


Cleanup delete schema

I was going to do more in this PR but there is a dependency on count so I'm going to break that dependency before going further with this.

Current coverage is 92.76%

Merging #1604 into master will decrease coverage by -0.03% as of 3fde775

@@            master   #1604   diff @@
======================================
  Files           87      87
  Stmts         5538    5539     +1
  Branches      1055    1055
  Methods          0       0
======================================
- Hit           5139    5138     -1
  Partial         14      14
- Missed         385     387     +2

Review entire Coverage Diff as of 3fde775

Powered by Codecov. Updated on successful CI builds.


Reduce the final bundle size

Hey!
First, thanks for the project, it seems pretty awesome and I definitely like to recommend it to anyone needing to record the terminal and sharing on the web.
Unfortunately, there's an aspect of this project that I, personally, don't like too much: the final bundle size, which according to bundlephobia is 133.2 KB of minified+gzipped JS just for the player.
One of the reasons for this, I think, is the fact that this library basically embeds React minified inside the final bundle, and React itself is quite big. I think there are other things that are helping yet more to reach that size.
So, given this, I would like to suggest a few possibilities to improve the situation:
a) Remove React.js dependency from the final bundle, using import or require to import the module on demand from the node_modules folder; (that would be better)
b) Use Preact (maybe with preact/compat) instead of React, given that it's smaller and better suited for widgets and embedded components;
This would help to reduce the final bundle size quite a bit, and would also allow to avoid conflicts with React already used in the page itself, by allowing to share dependencies code between other libraries.
What do you think? Is this possible to do?

The new version has been merged to mainline branch and released to npmjs.org (currently at 3.0.0-rc.1). You can read more details about the rewrite on the blog.


Add in_place suffix for BigInteger methods

Description

This pull request introduces a standardized naming convention for methods in the BigInteger module, specifically targeting functions where the self mutable value is modified in-place. The convention adds the in_place suffix to method names to provide clarity and consistency in the codebase.
closes: #781

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against correct branch (master)
[x] Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[x] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[x] Re-reviewed Files changed in the GitHub PR explorer

@Pratyush I thought about this PR and because the MulAssign or AddAssign traits of the Rust library use the suffix Assign, we will necessarily have mul_assign or add_assign which will be present somewhere in the code.
To unify everything, wouldn't it be better to rename everything throughout the code with an assign suffix rather than in_place. And for example the instances of square_in_place would also become square_assign, what do you think?

I'd much rather have a _assign indeed. What do people think?

Not more than adding thein_place suffix?  If it helps with naming consistency down the line before 1.0 I think that's a valid effort (and we should deprecate the previous names, not just remove them)

Ah I assumed it was to do it for all of the other traits too, like Field and GroupOn Feb 28, 2024, at 8:51 AM, Michele Orrù @.***> wrote:
Not more than adding thein_place suffix?  If it helps with naming consistency down the line before 1.0 I think that's a valid effort (and we should deprecate the previous names, not just remove them)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

[EDIT]To phrase better my comment:
In Field we have
double_in_place (from AdditiveGroup)
neg_in_place (from AdditiveGroup)
sqrt_in_place
square_in_place
inverse_in_place
frobenius_map_in_place

I think it's nice to have either (1) in_place everywhere except trait implementations of std::ops::*, OR (2) _assign everywhere. I'd be consistent with whatever we pick, and propagate this change to ark-ff and ark-ec, deprecating old function calls that will be removed for 1.0.
I fear having intermediate solutions will make the naming conventions of the library confusing.
@Pratyush In your comment, are you implying that having _assign only for BigInt is acceptable?
@tcoratger What do you think?

@mmaker Agreed, I found it confusing at the beginning like in Montgomery backend for exemple we have:

add_assign
sub_assign
double_in_place
neg_in_place

The std library always uses the _assign suffix for all operations so for me it would be worth changing everything to have consistent naming everywhere (_assign in a std like style) in the codebase. But would agree that this is quite a massive change of a big part of the function names of the whole library.

"Assignment operators" is the C term, so _assign made sense for operators, and hence maybe sensible for methods resembling operator methods, ala mul2_assign.
Afaik _in_place was always more traditional overall, and std uses in_place for pointers, so nothing wrong with _in_place either, but maybe resembling operators should be the priority.
Also, big integers are bigish for high performace code, so if a non-in-place variant feels particularly rediculous for operation foo, then foo could be the in-place variant, and _cloned could be the non-in-place variant, but again maybe resembling operators should be the priority.

So my rough rule-of-thumb has been to use _assign for the binary operators, and _in_place for the unary ones (negate_in_place, square_in_place, etc). Happy to uniformize the notation to avoid confusion though.


MIMETYPE & EventSource problems, support for Compression?

Im trying to setup a project using webpack, webpack-hot-middleware, webpack-dev-middleware, react-hot-loader, express, compression. At the moment I have it somewhat working but there are all sorts of errors that are happening every second or so in the console:

WebSocket connection to 'ws://localhost:3000/sockjs-node/815/n0qb0sv2/websocket' failed: Connection closed before receiving a handshake response
EventSource's response has a MIME type ("text/html") that is not "text/event-stream". Aborting the connection.

In the network console all the content is constantly being refreshed with a bunch of eventsource  error and xhr_streaming errors:

xhr_streaming?t=1498...
eventsource (cancelled)

webpack config:
var path = require('path');
var webpack = require('webpack');

module.exports = {
  entry: [
    'webpack-hot-middleware/client?path=/__webpack_hmr&timeout=20000',
    './app/index.js'
  ],
  output: {
    path: path.join(__dirname, 'dist'),
    filename: 'bundle.js',
    publicPath: '/static/'
  },
  module: {
    loaders: [
      {
        test: /\.js$/,
        loaders: ['react-hot', 'babel'],
        include: path.join(__dirname, 'app'),
        exclude: /(node_modules)/
      }
    ]
  },
  plugins: [
    new webpack.optimize.OccurenceOrderPlugin(),
    new webpack.HotModuleReplacementPlugin(),
    new webpack.optimize.DedupePlugin(),
  ]
};

express server:
var path = require('path');
var express = require('express');
var webpack = require('webpack');
var config = require('./webpack.config.js');
var compression = require('compression');

var app = express();
var compiler = webpack(config);

app.use(compression({level: 9}));
app.use('/dist', express.static(__dirname + '/dist' ));

app.use(require('webpack-dev-middleware')(compiler, {
  noInfo: true,
  publicPath: config.output.publicPath
}));

app.use(require('webpack-hot-middleware')(compiler, {
  log: console.log,
  path: '/__webpack_hmr',
  heartbeat: 10 * 1000
}));

app.get('*', function (req, res) {
	res.sendFile(path.join(__dirname + '/index.html'));
});

app.listen(3000, 'localhost', (err, result) => {
  console.log('http://localhost:3000/');
});

At the moment the current setup makes my computers fan go crazy. To the point where I have to close the tab the app is running so that my browser doesn't crash.

the sockjs and xhr_streaming responses are nothing to do with this lib, something else must also be trying to connect a socket.
I can't seem anything obviously wrong with that config, but the result you're getting for the EventSource implies that something other than the correct middleware is handling that response.
If you curl -v localhost:3000/__webpack_hmr, what do you get? You should get a text/event-stream response when things are wired up correctly.

I get the following response:
*   Trying ::1...
* connect to ::1 port 3000 failed: Connection refused
*   Trying <IP_ADDRESS>...
* Connected to localhost (<IP_ADDRESS>) port 3000 (#0)
> GET /__webpack_hmr HTTP/1.1

> Host: localhost:3000
> User-Agent: curl/7.43.0
> Accept: */*
>
< HTTP/1.1 200 OK
< X-Powered-By: Express
< Access-Control-Allow-Origin: *
< Content-Type: text/event-stream;charset=utf-8
< Cache-Control: no-cache, no-transform
< Connection: keep-alive
< Date: Sun, 24 Jul 2016 18:12:18 GMT
< Transfer-Encoding: chunked
<

data: 💓

I tried to run his code on app and this is what I get from it. I think it could be his entry point.

@kennetpostigo yes I get the same response but I chose that entry point because its the same as the one in the example of this repository.
Heres my output in my console:
*   Trying ::1...
* connect to ::1 port 3000 failed: Connection refused
*   Trying <IP_ADDRESS>...
* Connected to localhost (<IP_ADDRESS>) port 3000 (#0)
> GET /__webpack_hmr HTTP/1.1

> Host: localhost:3000
> User-Agent: curl/7.43.0
> Accept: */*
>
< HTTP/1.1 200 OK
< X-Powered-By: Express
< Access-Control-Allow-Origin: *
< Content-Type: text/event-stream;charset=utf-8
< Cache-Control: no-cache, no-transform
< Connection: keep-alive
< Date: Sun, 24 Jul 2016 18:20:00 GMT
< Transfer-Encoding: chunked
<

data: 💓

@sandysaders @glenjamin I think I discovered the issue here, its not the entry point you choose. In your express code I noticed that you have it serving the dist file path. However you have to keep in mind that the public path is /static/. In the html file you have to make sure the script tag src attribute is /static/bundle.js. Other wise you get all those errors because I think you might have /dist/bundle.js like I did. Make this change and see if the errors go away as they did for me.

Thanks for the suggestion @kennetpostigo that fixed the problem.


Add enclave inspection in legionctl

Legionctl tool should contain command to get list of enclaves.

Also we can add --cluster instead of  --edi and env:EDI_URL configurations to simplify configuration of legionctl.

As far as i understand, it needs Liara to get a list of enclaves. Am i right?


Fix typo in maven local directory path

Context
Fix typo (/Users/\[username]/m2/... -> /Users/\[username]/.m2/...)
Contributor Checklist

[X] Review Contribution Guidelines.
[X] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[X] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[X] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
[ ] Provide unit tests (under <subproject>/src/test) to verify logic.
[X] Update User Guide, DSL Reference, and Javadoc for public-facing changes.
[X] Ensure that tests pass sanity check: ./gradlew sanityCheck.
[ ] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

Thank you!


REPL: render evaluation results in a visually distinct manner

e.g. color-coding, crlf character

We could birng this up in the next ux meeting. Since we already do some color coding as shown in the attached picture
fyi @misolori
I think @roblourens also had some feedback in the past how we should better differentiate between input and output.

Inspiration from chrome devtools:

Dup of https://github.com/microsoft/vscode/issues/37363


Allow disabling watch mode for tests

Not sure which way it's better to accomplish, but I need to be able to disable watch mode to run tests on CI

Temporary fixed this by installing package directly from my fork on github:
npm i -D https://github.com/caffeinum/hardhat-nodemon/tree/patch-1

Amazingly, it worked without any testing. Great job on correct config!

Great.
Running super() when there's no watch flag was the intended use case, but was missed out in development.
Thanks, i'm merging this!


[sil] Allow createTrivial{Store,Load}Or to optionally handle non-owne…

…rship sil functions.
This is just convenient if you want to have a pass work transparently with both
ownership and non-ownership SIL.
Chopped off from the larger pred-memopt update commit to ease review.
rdar://31521023

@swift-ci smoke test and merge


:sparkles: add prefix to k-redux-factory

fixes #56

Coverage increased (+0.06%) to 97.98% when pulling 3778ea80da8e6ff25ddddf632ecce84b033779f0 on prefix into d532efae4e6ee825f9be7bea6c6cf580aa645fcc on master.

Waiting for https://github.com/alakarteio/k-redux-factory/pull/87 to be published

With a yarn link to https://github.com/alakarteio/k-redux-factory/pull/87 :


keep the session longer on mobile

Session cookie is a way to keep security. But it might make a bad user experience on the mobile or PWA.
When you switch to use different apps and switch back to the mobile safari or PWA, your session has been terminated.
So you always need to login again.
Removing the maxAge settings can make the cookie existing longer until 2 weeks.
For a better user experience, we can add the remember me checkbox in the future.

Oh my.. We've been looking into this, considering #160 but completely missed this (assuming it was default value).
So nice to get a fresh pair of eyes. Thank you!


Error: invalid authentication config: open /run/kube-apiserver/token-auth-file: no such file or directory

lokoctl version v0.1.0-169-gef479dc9 (HEAD of master today).
Following the quickstart guide for AWS doesn't lead to a working cluster; the apiserver is not running:
[...]
Flag --insecure-port has been deprecated, This flag will be removed in a future version.
I0425 12:13:32.553216       1 server.go:656] external host was not specified, using <IP_ADDRESS>
I0425 12:13:32.553634       1 server.go:153] Version: v1.18.2
Error: invalid authentication config: open /run/kube-apiserver/token-auth-file: no such file or directory
Usage:
  kube-apiserver [flags]
[...]

Possibly a regression from c0d340374a4bc0a92cf1a00ba3adb489d9b85ce9
/cc @invidian

This also means a bug in the CI, that should be running for AWS. I guess that checking that the cluster is up is done by the CI, but maybe I'm wrong. If not, we should add a test there too for all platforms.

I'm guessing the problem is that the /run/kube-apiserver directory doesn't exist. I don't see yet what is different in the CI setup for the directory to exist.

      {{- if eq (int .Values.apiserver.replicas) 1 }}
        - name: data
          mountPath: /run/kube-apiserver

The directory is only mounted if eq (int .Values.apiserver.replicas) 1, i.e. it only works with setting controller_count = 1 in the lokocfg (as done in the CI setup).

This also means a bug in the CI, that should be running for AWS. I guess that checking that the cluster is up is done by the CI, but maybe I'm wrong. If not, we should add a test there too for all platforms.

The problem is, that we don't set HA setup in the CI and this is what was failing. Perhaps we should.
Thanks for reporting @schu. PR with the fix is opened: #353.


Packer Images Multiple Regions

Hello,
Is there any chance that we could get the same functionality that is offered with ami_regions added into packer-azure?  https://www.packer.io/docs/builders/amazon-ebs.html#ami_regions
Customers that are in multiple regions on azure today have to build a image in each region and update images in each region which is a extreme amount of overhead.  Having the ability to create the image once and then having packer copy that image would be HUGE!
Thank you,
Brandon

opened in current repo - https://github.com/hashicorp/packer/issues/6192


Fix READMEs

Some more fixes for #9353
/CC @rbhanda @leecow

@rbhanda I'm wondering that the CVEs from #9356 are not listing CVE-2024-20672 | .NET Denial of Service Vulnerability mentioned as notable changes in 6.0.31, 7.0.20 and 8.0.6.


Joint limits and resolutions should be loaded from PlannerParameters

These are initialized by the SetRobotActiveJoints function on PlannerParameters. It seems like we should allow these settings to override the robot's limits, if they are set.

Closed since we haven't been able to replicate this.


Multitenant logging infrastructure for customer workloads

User story

As an engineer I want to be able to access a history of logs for my components in order to investigate ongoing operational issues
As an admin I want my logs to only be readable by a specific list of people
As an engineer I want to be able to scrape logs per namespace

### Step 0: Proof Of Concept
- [ ]  https://github.com/giantswarm/roadmap/issues/1131

### Step 1: Read path: OAuth support
- [ ] https://github.com/giantswarm/roadmap/issues/3226
- [ ] https://github.com/giantswarm/giantswarm/issues/29750
- [ ] Figure out how to get tenants from the oauth groups

### Step 2: Ingest per tenant logs (Write path)
- [ ] https://github.com/giantswarm/giantswarm/issues/29072
- [ ] https://github.com/giantswarm/giantswarm/issues/28022
- [ ] https://github.com/giantswarm/giantswarm/issues/29074

### Step 3: Teleport support (internal use only)
- [ ] https://github.com/giantswarm/giantswarm/issues/29719
- [ ] Get rid of user/password to access the Loki Datasource from grafana

### Final steps
- [ ] https://github.com/giantswarm/giantswarm/issues/25198
- [ ] https://github.com/giantswarm/giantswarm/issues/29580

CNCF sandbox logging operator might be interesting, https://kube-logging.dev/ https://github.com/kube-logging/logging-operator

We are blocked waiting for the RFC to be merged

Closed as Duplication of #3558


LiveReload

Add gulp-livereload (a LiveReload server) to the watch task pipeline for being used along with the LiveReload Chrome Extension.
This will allow developers to automatically refresh the DOM when a file is modified.
Consider integrate it with the css:watch task too, may require some code reengineering.

Closed by #886


doc missing: How to use releaseTools.debBuild?

Issue description
I'm trying to build a debian package out of a nix package. I have:
let
  pkgs = (import ./default.nix);
  vm   = pkgs.vmTools.diskImageFuns.debian8x86_64 {};
  args = {
    diskImage = vm;
     src  = pkgs.vim;
   };
in
pkgs.releaseTools.debBuild args

but I get:
error: value is a function while a set was expected, at /home/user/nixpkgs/vimdeb.nix:11:2
I feel that documentation is missing on how to properly use that function (also same for releaseTools.rpmBuild.
Steps to reproduce
Save the above expression as vimdeb.nix and call it with nix-build ./vimdeb.nix
Technical details

system: "x86_64-linux"
host os: Linux 3.10.0-957.el7.x86_64, CentOS Linux, 7 (Core)
multi-user?: no
sandbox: no
version: nix-env (Nix) 2.2.1
channels(user): "nixpkgs-19.09pre173445.796a8764ab8"
nixpkgs: /home/user/.nix-defexpr/channels/nixpkgs

Also: Can someone help me building direct and transitive dependencies from nixpkgs package expressions as deb or rpm packages?

You're missing a {} :)
let
  pkgs = import ./default.nix {}; # Compare with `import <nixpkgs> {}`
  vm   = pkgs.vmTools.diskImageFuns.debian8x86_64 {};
  args = {
    diskImage = vm;
     src  = pkgs.vim;
   };
in
pkgs.releaseTools.debBuild args

Oh that's embarrasing.
But now I get this output (only the last few lines):
patching sources
configuring
no configure script, doing nothing
building
no Makefile, doing nothing
running tests
no Makefile or custom buildPhase, doing nothing
installing

checkinstall 1.6.2, Copyright 2009 Felipe Eduardo Sanchez Diaz Duran
           This software is released under the GNU GPL.

The checkinstallrc file was not found at:
/nix/store/wa35g83h4xpv0nadq688hgn2r90ay06l-checkinstall-1.6.2/sbin/../checkinstallrc

Assuming default values.

*****************************************
**** Debian package creation selected ***
*****************************************

This package will be built according to these values:

0 -  Maintainer: [ root@(none) ]
1 -  Summary: [ Package created with checkinstall 1.6.2 ]
2 -  Name:    [ openssl-1.0.2r ]
3 -  Version: [ 0.0.0 ]
4 -  Release: [ 1 ]
5 -  License: [ GPL ]
6 -  Group:   [ checkinstall ]
7 -  Architecture: [ amd64 ]
8 -  Source location: [ openssl-1.0.2r-bin ]
9 -  Alternate source location: [  ]
10 - Requires: [  ]
11 - Provides: [ openssl-1.0.2r ]
12 - Conflicts: [  ]
13 - Replaces: [  ]

Enter a number to change any of them or press ENTER to continue:

Installing with /bin/sh -c make install...

========================= Installation results ===========================
make: *** No rule to make target 'install'.  Stop.

****  Installation failed. Aborting package creation.

Cleaning up...OK

Bye.

[   28.254749] reboot: Power down

src  = pkgs.vim.src;

Jup that helps a bit. I'm currently trying to build the whole chain of dependencies recursively, which is a whole lot more complex.

btw, this is WIP here: https://nixos.wiki/wiki/Nixpkgs/Building_RPM_DEB_with_nixpkgs

Seems resolved


Breadcrumbs and Run History Blade Disappear After Refreshing Page

Describe the Bug with repro steps

Select a Logic App Consumption resource

Navigate to Overview > Run history

Select any run ID

When the designer loads, notice the breadcrumbs and list of run IDs

Refresh the page

Breadcrumbs and list of run IDs disappear

What type of Logic App Is this happening in?
Consumption (Portal)
Are you using Preview Designer or GA Designer
Preview
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
N/A - Happens with all workflows

Screenshots or Videos

Browser
Edge, Chrome
Additional context
No response
AB#24245984

This is unfortunently a limitation to how Azure Portal works. When we move to the new designer in consumption and add run history list to it we can make sure it's all 1 blade so at least that doesn't disappear.


Make textfield view style uniform for all TextInputLayout

The drop down is currently using FilledBox instead of OutlinedBox. Use the theme to set the style to OutlinedBox as default
Originally reported by @jingtang10

@joiskash can you confirm if this is fixed by #229 ? thanks!

Yup its fixed :)


Fresh app doesn't work on Safari 14

Issue summary
We've received complaints that a fresh app created with the App CLI is not working on Safari, even though it works on other browsers. The app first asks for cookie access, then for data access to read the cookies, but it ends up in an infinite loop after that point - it reloads and then asks for data access again.
Expected behavior
The app should ask for the permissions once and then work normally from that point.
Actual behavior
The app continuously asks for access to cookies, and when it reloads it actually shows the contents of the page for a second, before asking for access again.
Steps to reproduce the problem

Create a new app with the CLI.
shopify serve.
Open the brand new app on Safari and accept the permissions as they are requested.

Specifications

Browser: Safari 14
Operating System: macOS 10.15.7

This should no longer be an issue after we removed the dependencies on 3rd party cookies.


Cannot deploy yaml file via Kubernetes Edge Agent to Portainer Instance

I connected the Kube Edge Agent to Portainer Instance, however I cannot deploy via yaml file: Error: 2020/12/16 04:27:04 [DEBUG] [chisel,monitoring] [endpoint_id: 19] [status: ACTIVE] [status_time_seconds: 274.100978] [timeout_seconds: 270.000000] [message: ACTIVE state timeout exceeded] 2020/12/16 04:27:09 server: proxy#1:R:<IP_ADDRESS>:60882=><IP_ADDRESS>:9001: Closed 2020/12/16 04:29:12 http error: Unable to deploy Kubernetes stack (err=Error from server (NotFound): the server could not find the requested resource ) (code=500)
Yaml file:
apiVersion: v1
kind: ServiceAccount
metadata:
name: rabbitmq
kind: Role
apiVersion: rbac.authorization.k8s.io/v1
metadata:
name: rabbitmq
rules:

apiGroups:

""
resources:
endpoints
verbs:
get
list
watch

kind: RoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
name: rabbitmq
namespace: rabbits
subjects:

kind: ServiceAccount
name: rabbitmq
namespace: rabbits
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: Role
name: rabbitmq (edited)

We're aware of this issue and are planning to address it via https://github.com/portainer/portainer/issues/4321#issuecomment-727674657 in CE 2.1.0.


GUI/Pane Customization Question

I am modifying the CSS to create a light color theme. Where can I modify the background and colors of the Panes/Widgets?

https://github.com/Freeboard/freeboard/blob/master/css/freeboard.css
Line 1379
You have to change it on freeboard.min.css though. Or edit freeboards.css as you want then minify it back.
.gridster .gs_w { 	background: #2a2a2a; 	padding: 0px; 	margin: 0px; 	overflow: hidden; 	z-index: auto; 	-webkit-touch-callout: text; 	-webkit-user-select: text; 	-khtml-user-select: text; 	-moz-user-select: text; 	-ms-user-select: text; 	user-select: text; }

Thank you. Must have missed that line.


As Portal User, I want to be able to go back to previous question on curated experience

From @aroubin on December 6, 2018 21:12
Sometimes users will want to go back to previous question in curated experience so that they can change some of their responses.
Copied from original issue: Microsoft/Access2Justice#878

I agree that this needs to be in sprint soon.  Users need a back button while in the curated experience.

Back button in CE or GA is in the current sprint.  The team is working on this now.
Thanks,
Kellye Bennett
Legal Navigator Project Manager
Legal Services Corporation
<EMAIL_ADDRESS>Office of Information Technology
3333 K Street, NW
Washington, DC 20007
P:<PHONE_NUMBER>
E: bennettk<EMAIL_ADDRESS>From: Jada Breegle<EMAIL_ADDRESS>Sent: Wednesday, April 10, 2019 12:40 PM
To: LSCOIT/LegalNavigator<EMAIL_ADDRESS>Cc: Kellye Bennett<EMAIL_ADDRESS>Assign<EMAIL_ADDRESS>Subject: Re: [LSCOIT/LegalNavigator] As Portal User, I want to be able to go back to previous question on curated experience (#721)
I agree that this needs to be in sprint soon. Users need a back button while in the curated experience.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://github.com/LSCOIT/LegalNavigator/issues/721#issuecomment-481768077, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Arpp9KUY1_c_YROuSJ2qIV1j-H97Q-cHks5vfhP6gaJpZM4aCd2B.
Caution External Email Alert!
This message was sent from someone outside of LSC. Please do not click on links or open attachments unless you recognize the source of this email and know that the content is safe. If you believe that this email is a phishing attempt or contains malicious files or offensive content please contact the OIT HelpDesk.
OITHELPDESK mailto:oithelpdesk.lsc.gov

Does this include a back button for when I click out of the site from the action plan?

The desired behavior is for a new window to load when user clicks on an external link, which would in theory maintain the step the user is in within the Guided Assist (CE).

yeah, that's not currently happening.  I just tried the domestic violence flow in AK

@lbirdpew This issue is "In Progress" and the development team is currently working on the fix in the development environment for this sprint.  Once resolved, it will be assigned to me for testing.  If you'd like to be included in testing, please let me know.  Once the fix is completed, the new code will be migrated to the stage environment and available for other stakeholders to review.  The sprint ends on April 16th. Hope this helps.

No worries, i was just curious if there was another issue for it.

Back Button added to Guided Assistant - Ready for PO review

@KellyeDC The Back button works, but I lose my previous answers. Is this the desired behavior?

@grawdon This is not the overall desired behavior, however, this user story is only for implementing the back button feature.  The save interview answers along the way feature is a separate issue.


Fix excluded files and folder deletion triggers

Fixes https://github.com/aspnet/dotnet-watch/issues/90, https://github.com/aspnet/dotnet-watch/issues/93

Bugfix: Trigger on new project.json file structure
Bugfix: Trigger on folder deletion
Add test for folder deletion

Please review @moozzyk @kichalla @ajaybhargavb

:watch:

Updated

:shipit: from me

:shipit:


Fix ZLIB decompression in BiDiGzipFilter

To decompress deflate-encoded requests one should use the InflaterInputStream class, not DeflaterInputStream. The latter actually is used for compressing requests on the fly.
This change adds the parameter gzipCompatibleInflation for controlling the mode of ZLIB decompression.
Also it fixes a minor bug, when a broken inflater could stay in the thread local storage.

LGTM, thanks!


support for config from toml file

if I am not wrong as pip audit uses OSV internally,
osv-scanner supports the config from toml file, it will be easy to maintain if pip audit provides argument to take config from toml to set config like ignoring vulnerable.

Hi @prathapbelli! In the future, please use our issue templates. In particular, the "Feature Request" template is probably the appropriate one here.
By default, pip-audit does not use the OSV REST API -- it uses PyPI's vulnerability API, which is similar but distinct. It can use the OSV API via -s osv, but we generally don't encourage users to do that unless they have a specific reason to avoid the PyPI API (e.g., firewall restrictions).
Given that, it's unlikely that we could directly reuse the same config format the osv-scanner uses. Doing so would also pose challenges for integration with pip, which is on our eventual roadmap -- pip has its own configuration file, so we don't want to either modify it or add another file into the mix without coordinating with them.
TL;DR: This is probably out of scope for us, currently. Our recommendation is to use the CLI flags for things like vulnerability masking; if your use case involves large numbers of ignored vulnerabilities, then you can create a wrapper script that munges them into the pip-audit CLI.


wallet-server: update suggested systemd unit

Use Type=Forking. By default, Type=Simple is used and it expects that the daemon stays forking in the foreground. However, lbrycrdd does the opposite and forks/goes to background. This confuses systemd a little bit:
Dec 09 10:30:28 lbry.devass.club systemd[1]: lbrycrdd.service: Unit process 12237 (lbrycrdd) remains running after unit stopped.

So basically it thinks that the unit stops working instantly. When the correct type is used, systemd should be able to handle this situations, along with restarts, properly.
See also: AUR systemd service

thanks @derlaft! review coming soon

@derlaft how are you running lbrycrdd? it should only fork if you use the -daemon flag

closing. please reopen if you return and answer https://github.com/lbryio/lbry.tech/pull/368#pullrequestreview-834405545

how are you running lbrycrdd?

As described in the documentation.
    Process: 520 ExecStart=/home/user/.bin/lbrycrdd -datadir=/home/user/.lbrycrd -pid=/home/user/.lbrycrd/pid -dbcache=100 -claimtriecache=128 -par=1 -memfile=16 (code=exited, status=0/SUCCESS)

By default (without pid= and with no Type=forking) behavior described in the issue exists.

it should only fork if you use the -daemon flag or if you have daemon in your config file

That's not the case for me or for authors of that AUR package.


Add a sorting button for user files

According to the issue #1543, this update adds a functionality that allows users to sort their files on the dashboard by name or size.

.

Please add a brief description about the purpose of this PR, in addition to the screenshot.

Please add a brief description about the purpose of this PR, in addition to the screenshot.

Thank you for your advice. I've added the description.


⚠ Bofrost.es has degraded performance

In 857d8fb, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 2619 ms

Resolved: Bofrost.es performance has improved in d4c25a1 after 6 minutes.


Closure Subset C

[x] Improving the Chain of Synchronous Steps.
[x] C.1 Close the YARP ports connections associated to the telemetry entries in portInConfig and instantiated by the main Node.js process.
[x] C.2 Stop reading the respective YARP ports (similar to turning off the port listeners).
[x] ~C.3 Complete the unfinished processing or responses to the pending requests. => use "drain"~
[x] C.3 - Stop sending "real-time telemetry data" messages (notifications) to subscribers.
[x] Merged C into B.

C.2 Stop reading the YARP ports - UPDATE

* In order to "remove" the listeners, we could set again the `onRead`'s callback with a void function since there is no listener removal implemented on **Yarp.js**:

This turned to be a very unreliable solution as if we set the onRead's callback using the object tracked by the yarp.portHandler, returned by the yarp.portHandler.get(<port-name>) method, instead of the object portIn directly returned by yarp.portHandler.open, the node process crashes almost systematically. The choice of getting the port tracked by yarp.portHandler would allow to handle the cases where the the port is closed somewhere else in the application code.
On top of that, the setting of onRead's callback uses C++ bindings which means there is an interaction with the OS (running some C++ library implementing those bindings), so probably the call to those bindings is asynchronous anyway, not giving us a feedback on the task completion. Having that in mind, the simplest and safest approach would be to use a function pointer, either pointing to a void function (disconnection state), either pointing to the ICubTelemetry.prototype.updateState.

C.3 Stop sending "real-time telemetry data" messages (notifications) to subscribers
There is a synchronous task sending generating the telemetry data from the updated buffer this.state and sending it to the subscribers. We implement here the following change:

We introduce ICubTelemetry.startNotifier and ICubTelemetry.stopNotifier for activating/deactivating the ICubTelemetry.generateTelemetry periodic call, instead of starting it automatically when creating the object icubtelemetry.
For this purpose, we split the setInterval callback definition from the timer definition itself.
The notifier is stopped in this step of the server closure, which is equivalent to removing all the subscriber listeners.

Merged C into B
Steps C.1 to C3 were merged in the Subset B as these are all synchronous:
B.1 ━┳━━━━> C.2 ━━━━> C.3
     ┗━━━━> C.1

B.1 ━┳━━━━> B.3 ━━━━> C.4
     ┗━━━━> B.2 (Yarp ports disconnection: asynchronous, no impact on other tasks)

Actual Closure subset C

[x] C.1 - Close all the websockets.
[x] This unlocks the server closure (promises closeTelemServerPromise and closeConsoleServerPromise:
https://github.com/ami-iit/yarp-openmct/blob/c02a36840fc3465604ab7aa175be912951a25052/iCubTelemVizServer/terminationHandler.js#L33-L52
[x] C.2 - Run the "resolve" ("thenable") of [closeTelemServerPromise AND closeConsoleServerPromise AND C.1](*). No other pending tasks are scheduled, so the process graciously exits on its own.

Note
(*) Actually the resolution of [closeTelemServerPromise AND closeConsoleServerPromise] would suffice but we want to make sure that all the steps leading to C.1 have completed without issues. This way an abnormal closure of the server (for other reasons than the closure of all sockets) won't go unnoticed.


lose the a param in the entrust_setup_tables?

when i run
php artisan migrate

the has errors,the errors message :
[Illuminate\Database\QueryException]
  SQLSTATE[42000]: Syntax error or access violation: 1103 Incorrect table name     '' (SQL: alter table `role_user` add constraint `role_user_user_id_foreign` foreign key (`user_id`) references `` (`id`) on elete cascade on update cascade)
  [PDOException]
  SQLSTATE[42000]: Syntax error or access violation: 1103 Incorrect table name ''

when i  add the  param users in the "on"  method the in xxx_entrust_setup_table.php at 28 lines. it's work

the prblem is here:
   $table->foreign('user_id')->references('id')->on('')                 ->onUpdate('cascade')->onDelete('cascade');

@siptik you can try add the 'users' in the on(''),like this ：
$table->foreign('user_id')->references('id')->on('users') ->onUpdate('cascade')->onDelete('cascade');

when I do this ,it's work

I also had this issue. While it was easy to fix, I didn't have time to look into what was causing it in the first place.

Okay I had a quick mooch of the source code. The reason this isn't populated for some people is the users table name is read from the config file in config/auth.php in the providers array:
'providers' => [
'users' => [
'driver' => 'eloquent',
'model' => frankrostron\User::class,
'table' => 'users',
],
Ensure 'table' is set with the name of your users table in this array before running the php artisan entrust:migration command

+1


PowerShell Script to assign licenses not working

I followed the PowerShell Script to copy licenses from one user to another user and it is not working

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 073b885d-191e-8c00-fa59-ad83ba79ec10
Version Independent ID: 4bd5799d-9baf-90b6-634d-398fbea6b66f
Content: Assign Microsoft 365 licenses to user accounts with PowerShell - Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/assign-licenses-to-user-accounts-with-microsoft-365-powershell.md
Service: microsoft-365-enterprise
GitHub Login: @kelleyvice-msft
Microsoft Alias: kvice

@NiteshSharma2K19 Considering the nature of the issue,  please open a service ticket in your tenant and follow with them for the resolution. We proceed to close it as here we are limited to documentation fixes and improvements only.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

Hi Yogesh,
Sorry but you are mistaken. The issue is with the script mentioned on the
page not with my tenant. Please try to run the script in your test
environment.
On Tue, 4 Oct 2022, 10:41 Yogesh Kumar, @.***> wrote:

@NiteshSharma2K19 https://github.com/NiteshSharma2K19 Considering the
nature of the issue, please open a service ticket in your tenant and follow
with them for the resolution. We proceed to close it as here we are limited
to documentation fixes and improvements only.
We will be very happy if you can share the outcome or resolution with us
if you see documentation update is required. We will certainly update this
documentation with that valuable information. Thanks again, for taking out
some time to open the issue. Appreciate and encourage you to do the same in
future also.
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/microsoft-365-docs/issues/9870#issuecomment-1266405984,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AL4ZFOLG2AXHIWQ2OFSDHLLWBO4BLANCNFSM6AAAAAAQ33NGIY
.
You are receiving this because you were mentioned.Message ID:
@.***>

@NiteshSharma2K19 reopening it for further investigation. Thanks

@NiteshSharma2K19 Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/9887
Once the author approves, the changes will be live.
Thanks
Sri


Add wrapping for image titles in listing

Fixes #4233

Thanks @lb-, I'll review this this evening 🙂.

@thibaudcolas thanks for picking that up, I have done my best to make the changes requested. Let me know if more are needed.


Zone / Schedule Labels

Is there a way for this to pull in the existing zone and schedule labels (and ideally images) from rachio? I just set this up naively but everything appears in homekit as "zone 1", "zone 2" etc. even though they have names in rachio. Do you have to maintain the names in each place?

It should be pulling in the names as you have them configured. Make sure they show correct in homebridge first. You may have to remove the accessory in homekit and re add it if it is stuck thinking you want the names to be zone1, zone 2

Yeah, I guess it maybe just took time to sync because they appeared later. Though there are a bunch of unnamed switches still (in addition to my named switches).
https://github.com/valiquette/homebridge-rachio-irrigation/assets/718368/3e3d4e45-04ff-45b1-805a-ec91502e9e93

The schedule names don't get set if you selected to have switches enabled for easy turning on and off of schedules.
The controller standby switch also does not get properly named to something like Hibernate or Standby.
The zone names do get set properly though.
Thanks for this great plugin!


Enable rpm signature checking when building images

@jupierce: PTAL.

@jupierce: updated, PTAL.

@smunilla FYI. refresh-images will now have an option which attempts to verify RPM signatures. Try using the aos-signed-building-betatest.repo variant next time you run the job.


Adds show & tell to standup template

This adds our (new!) weekly show & tell to the standup template, including a link to the docs.

Great! Merging.


Error message for transitive artifact dependencies with targets the package doesn't directly interact with

Address #11260. Produces an error message like described by @weihanglo here:
error: could not find specification for target "x86_64-windows-msvc"
  Dependency `bar v0.1.0` requires to build for target "x86_64-windows-msvc".

Note that this is not a complete fix for #11260.

I suggest that this doesn't entirely fix #11260. I would expect artifact dependencies to work, not generate an error message.

Oops that's my fault. I though it was just target spec not found but it turns out not. Cargo should learn all targets required by artifact dependencies, probably after unit graph is created.
Thanks Eric for calling out and sorry for the wrong pointer, @jofas 😞.

I would expect artifact dependencies to work

Me too :sweat_smile:

sorry for the wrong pointer

No worries. In the issue it sounded like getting all the necessary targets for building artifact dependencies isn't trivial and I assumed a change like that required some more procedural overhead than a simple PR (does cargo have RFCs as well?). With some more hints on where I need to look in order to add the required targets for transitive artifact dependencies to RustcTargetData, I'd love to extent this PR!

https://github.com/rust-lang/cargo/blob/99b13692dd30d19caf4bfdb81edf9e65c9af0655/src/cargo/core/compiler/build_context/target_info.rs#L919-L925
AFAICT, if we make this function recursive and call it for each dependency, we should get all the necessary targets for transitive dependencies, no? I haven't found a way yet to get the Package or Manifest objects from Dependency. Maybe from the BuildContext.packages? If we could pass BuildContext down to the RustcTargetData::new, that is. I'll keep digging and see if I can find something more concrete. Any thoughts on my idea?

if we make this function recursive and call it for each dependency, we should get all the necessary targets for transitive dependencies, no?

I am afraid it won't work, or requests for too many targets then it really needs. We should also consider optional dependencies and the feature resolution. I believe Cargo doesn't need every disabled target platform toolchain to exist on the host machine.

I am afraid it won't work, or requests for too many targets then it really needs. We should also consider optional dependencies and the feature resolution. I believe Cargo doesn't need every disabled target platform toolchain to exist on the host machine.

Will that really be a problem? Sure, creating TargetInfo (which is where rustc must be executed) seems to be computationally expensive, so it would be unfortunate if we get it for more targets than needed during compilation. I'm asking, because I can't see how we'd be able to use the UnitGraph (which I'm assuming is the graph containing all the dependencies and how to compile them) for choosing the right targets for RustcTargetData, as for creating the UnitGraph, we need RustcTargetData.

r? @weihanglo

@bors r+

:pushpin: Commit 4bdface19a46443d5a0e1f8ff9606eb80f776d94 has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit 4bdface19a46443d5a0e1f8ff9606eb80f776d94 with merge 816772ba5cebe051938d2e71e1e95c8b7e6e9cd0...

:broken_heart: Test failed - checks-actions

I posted #11766 to fix the issue with CI failing.

@bors retry

:hourglass: Testing commit 4bdface19a46443d5a0e1f8ff9606eb80f776d94 with merge 524231f43f602a553216548a81e4ae22be8dd905...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 524231f43f602a553216548a81e4ae22be8dd905 to master...

For fixing the root issue, I'll take a deep look next week and see if I can find anything useful.

Great, please let me know if you find anything I could help with.


incubator/jaeger Support deadline override in cassandra schema job

Is this a new chart
No
What this PR does / why we need it:
With the default activeDeadlineSeconds of 120, in our cluster the jaeger-cassandra pods may not be available quickly enough for the job to complete. After its 120 second deadline, the job is aborted and will not be retried. We would like to increase this deadline in our configuration so that this chart may fully install without manual intervention.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @naseemkullah
👋

/lgtm

/ok-to-test

/do-not-merge

I wonder why this was added in the first place. I’d go as far as removing the active deadline seconds or having it wrapped around an if (default to not set) @n8than


Not installing styled-componnets

While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/react
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   peer react@">= 16.8.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/styled-components
npm ERR!     styled-components@"" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/react-dom
npm ERR!   peer react-dom@">= 16.8.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/styled-components
npm ERR!     styled-components@"" from the root project
Version Details
"react-native": "0.64.1",
"react": "17.0.1",

Something about this error message seems really mangled and missing. I'm not quite sure what's going on but if you still need help, consider going to StackOverflow or describing what exactly you're doing in terms of executing commands, the package.json entries you have, and so on.
For instance, I've never seen csnative, so if that's your package then something is definitely going wrong there.


Return citations in AiMessage

Introduce Citation class and return a List<Citation> inside the AiMessage.
Make sure Citation structure works for Gemini, Azure OpenAI, Cohere and other LLM providers that have this feature.
Discussed in https://github.com/langchain4j/langchain4j/discussions/1583

Originally posted by Goldritter August 12, 2024
Hi,
I try to use the VertexAiGeminiChatModel to answer a question and verify the answer with an attached Datastore.
It does work, but the document citations are missing in the AiMessage. The received Response  contains the citations in grounding_metadata part but the generate Method does not extract these information.
Does anybody has an idea how I can get these Info with the Options from Langchain?
Best regards Marcus

This is not a bad solution. But the citations can have different form, e.g links, styles or BibTex formats. And it might depents on the usecase.
If possible/feasable a Function<Response, Citation> as a paramter would be cool. So developers can specify by themself the content and/or form of the Citation. And sometimes the citations are refernced in the text, so it would be realy cool to have also a Function<Response, String> for the text on the AIMessage. This might to allow to incoperate citation links directly into the text.

@Goldritter could you pelase provide examples of such Function<?,?> usages?

For example in dev.langchain4j.model.vertexai.VertexAiGeminiChatModel the method  public Response<AiMessage> generate(List<ChatMessage> messages, List<ToolSpecification> toolSpecifications) has in line 277 following code:
return Response.from(                 AiMessage.from(ResponseHandler.getText(response)),                 TokenUsageMapper.map(response.getUsageMetadata()),                 FinishReasonMapper.map(ResponseHandler.getFinishReason(response))             );
If you change the method header to public Response<AiMessage> generate(List<ChatMessage> messages, List<ToolSpecification> toolSpecifications, Function<Repsonse, String) responseFunction)  you could replace ResponseHandler.getText(response) with responseFunction.apply(response) and responseFunction is a Function<Response, String> which for example can extract the citations from the response and create a HTML-Text where the citations are added as Citationtext.  into the text.
And if you don't use your own responseFunction you can use the original method call to use ResponseHandler.getText(response) by
 public Response<AiMessage> generate(List<ChatMessage> messages, List<ToolSpecification> toolSpecifications) {     return generate(List<ChatMessage> messages, List<ToolSpecification> toolSpecifications, ResponseHandler::getText);
If you want to be more generic, you can write an AIMessageBuilder, where R is the class of the response, wehre you can set building method like setTextExtractor(Function<R,String> textExtractor) or setCitationExtractor(Function<R,Citation> citationExtracor).
For VertexAIGeminiChatModel the call might be
AIMessageBuilder.<Response>builder().setTextExtractor(myTextExtractor).setCitationExtractor( myCitationExtracor);}
The Builder can then be added to the VertexAIGeminiChatModel or other Models. And You can have there the "standard" functions to extract the elements from the response, but also give developers give the possibility to make adjustments for the own/special usecases.
I hope I have expressed myself well enough and understandably.

@Goldritter, I see, nice customization idea! We can definitely think about it once we are done with the basic citation support

Is there any information when this issue will be resolved?

@Goldritter I have no capacity for this right now. Would you like to help with this? 🙏

I would like to, but I have actually no access to the gemini account and so can not test the implementation :(.
Sorry.

@glaforge can we help with access somehow?
Perharps it can be implemented for the new Gemini module that has free API keys?


Accept/Revert actions are missing from "Resolve save conflict".

Azure Data Studio Version:
1.5.2
Issue:

If contents on the disk are newer than contents in the editor you would get an error message "Failed to save 'xxxx': The content on disk is newer. Please compare your version with the one on disk." But when I clicked on compare there was no Accept/Revert buttons like presented in this picture form VSCode:
https://code.visualstudio.com/docs/getstarted/tips-and-tricks#_preventing-dirty-writes

It's showing like this:

I've tested it in VSCode, and it's OK in VSCode, the problem only exists in ADS.
I'm on ArchLinux so I don't have the latest version but I couldn't find any related issue in the latest changelog

FYI: This issue still exists in 1.13.1 (I'm running on Windows).

This issue still exists in 1.50.1


documentation: update readme

mention eth_getProof requirement for eth1 rpc (thanks @lightclient for pointing this out)
italicize disclaimer

@ncitron not sure where you got the information that Infura doesn't support eth_getProof but it does.

@ryanschneider it was from me. At the time, the docs weren't clear that infura supported eth_getProof. Sorry for the misinformation!

@ryanschneider it does however seem that infura does not support eth_createAccessList though which helios requires. I will however update the readme to reflect this. Thanks for pointing this out.


Incident Density does not respect layer definition queries

Run the Incident Density tool on the last 30 days layer.
Now run the Incident Density tool on the month before last layer.
The results are the same.
Compare this to running the Buffer tool on the same two layers. Buffer respects the definition query, Incident Density does not.
Expected Behavior
I would expect the tool to respect the definition query on the layer.
Your Environment
Incident Analysis 4.0.1 - ArcMap 10.5.0

@BobBooth So does Incident Density use ALL of the from the layer, instead of the data filtered by the Def. Query? When it does NOT honor it, what is the output? Trying to write up the Known Issues list for IA and want to include this.

So it seems it is using the full list of data points, though the analysis option to snap to features is reducing the number from 5532 initial data points down to 1961 data points. The option we set in the tool is:
SNAP_NEARBY_INCIDENTS_TO_CREATE_WEIGHTED_POINTS —Nearby incidents will be aggregated together to create a single weighted point. The weight for each point is the number of aggregated incidents at that location.

So the ICOUNT field shows how many points were aggregated together. A quick summary on that field shows that it was made from ALL of the original data ponits.
Count:	1961
Minimum:	1
Maximum:	50
Sum:	5532
Mean:	2.82101
Standard Deviation:	3.474697
Nulls:	0

I can replicate this issue, going to explore further

Waiting on a response from GP folks, but right now it seems like the Optimized Hot Spot Analysis tool that is included in both the ArcMap and Pro versions of this model may automatically bypass layer definition queries, and run on the entire dataset.
If this is the case, then the question becomes: Does changing the tool to enable definition queries defeat the purpose of calculating incident density? After all, wouldn't they just use Emerging Hot Spot Analysis in Pro if they wanted to filter/explore the layer by time? If users wanted to run Optimized Hot Spot Analysis on a subset of their data, they could specify an analysis field instead of aggregating all points by weighted values. Could we surface that analysis field as a parameter in our model? Either way we need to link to the Optimized Hot Spot Analysis tool doc in both our tool documentation and IA template documentation so people better understand what the tools do.

According to the team that maintains the OHSA tool, it should respect layer definition queries, and when I run the OHSA tool out of the box, I'm getting an error about a missing OID field on the definition query layers.
This issue is related to https://github.com/Esri/solutions-geoprocessing-toolbox/issues/521 and the common denominator is that they both primarily rely on OHSA. Still looking for a potential fix to both tools

Found easy workaround and fix for #521, but this is still an issue

@Dbarnes1 & @mfunk  - an easy fix for this might be to copy the input features to a new, in_memory feature class before running the rest of the tool on it - that copy features would respect definition queries of any sort (should anyway) and would also add a new OID field that would solve https://github.com/Esri/solutions-geoprocessing-toolbox/issues/521

@BobBooth is correct, here is the output once you add copy features:
All Incidents:

Last 30 days:

I'll be submitting a PR with the improved version of the Incident Density tool later on.

At least in ArcMap 10.5, the feature class to feature class step has to happen before the Project features step. Project does not seem to respect the definition query, but FC to FC does.

I removed the associated known issue from the documentation

@BobBooth this will be ready to verify once the PR is merged in both the map and pro toolboxes

Verified - I got the same results shown as correct above (Tested on 10.4)


Wallpaper switcher doesn't work

Device: Samsung Galaxy A25
OS: Android 14
I have selected a folder for the wallpapers, activated wallpaper switching, and set the interval to 1 minute. The wallpaper is never changing, even if the app is running in the foreground, and the phone is not sleeping. I have turned off all energy optimizations for the app in the settings, but it doesn't make any difference.
Also the widget to switch wallpapers only works, if the app is open, which defeats the purpose of the widget.
I think a background service is needed to achieve the auto wallpaper switching.

It already uses background service, you need to disable battery optimizations for Peristyle for it to work.

Added a dialog to disable battery optimizations when auto wallpaper is enabled.


8406 option set numeric values

I don't particularly like the way prefer_values is passed down (feels very ad-hoc) but wasn't sure how deep I should go refactoring.  Do you have any suggestions or is this approach OK?

Thanks @smoyth!  I just addressed all your comments and added the missing response CSV spec.


Add title to new request

As user I want to add a title when creating a new request in order to get a better overview in my request list.
Acceptance criteria:

When an user creates a request, the user has to select a topic and to specify a title.
The title is a string (about 50 chars long, HTML input field).
The title becomes part of the channel name. The new channel name will be "[topic name] - [title]".

moved to https://github.com/assistify/Rocket.Chat/issues/23


Wrong asset-manifest with two ExtractTextPlugin instances

webpack config
I am intended to handle the styles in different ways between my source codes and node_modules.
The styles from node_modules will extracted to static/css/node_module_styles_[md5:contenthash:base64:6].css, and the styles from my source codes will be extracted to static/css/main.8a41ccd7.css.
rules:
// absPath is the function which returns a absolute path
{
    test: /\.css$/,
    oneOf: [
        {
            include: absPath('src'),
            exclude: /\.plain\.css$/,
            use: [
                {
                    loader: 'style-loader',
                    options: {
                        sourceMap: env === 'development',
                    }
                },
                {
                    loader: 'css-loader',
                    options: {
                        importLoaders: 1,
                        camelCase: true,
                        sourceMap: env === 'development',
                        modules: true,
                        localIdentName,
                    },
                },
                'postcss-loader',
            ],
        },
        {
            include: absPath('node_modules'),
            use: ExtractTextPlugin.extract({
                fallback: 'style-loader',
                use: ['css-loader'],
            }),
        }
    ],
}

plugins:
[
    new ManifestPlugin(),
    new ExtractTextPlugin({
        filename: 'static/css/[name].[contenthash:8].css',
    }),
    new ExtractTextPlugin({
        filename: 'static/css/node_module_styles.[md5:contenthash:base64:6].css',
    }),
]

I find that default behavior to generate a manifest:
manifest = files.reduce(function (manifest, file) {
    manifest[file.name] = file.path;
    return manifest;
}, seed);

https://github.com/danethurber/webpack-manifest-plugin/blob/ae03fbdcd4ba8073f66efd7b97eec8df318b0c87/lib/plugin.js#L148
Actually the files are most same.
// main.css
{
    path: '/static/css/main.8a41ccd7.css',
    name: 'main.css',
    isInitial: true,
    isChunk: true,
    isAsset: false,
    isModuleAsset: false
}

//  extracted texts from main.css
{
    path: '/static/css/node_module_styles.24Lqg8.css',
    name: 'main.css',
    isInitial: true,
    isChunk: true,
    isAsset: false,
    isModuleAsset: false,
}

The names of two chunks are same. Refer to the code in extract-text-webpack-plugin:
https://github.com/webpack-contrib/extract-text-webpack-plugin/blob/master/src/index.js#L135
The later item of files array will overwrite the the former. So the asset-manifest file would be wrong.
Actually result
{
  "main.css": "/static/css/node_module_styles_24Lqg8.css",
  "main.js": "/static/js/main.7a857630.js",
}

What I expect
{
  "node_module_styles.css": "/static/css/node_module_styles_24Lqg8.css",
  "main.css": "/static/css/main.8a41ccd7.css",
  "main.js": "/static/js/main.7a857630.js",
}

webpack-manifest-plugin: 1.3.2
extract-text-webpack-plugin: 3.0.2
webpack: 3.8.1

ATM this is not something we are going to fix: see #63
Just use the map options to change the name according to what you need


Add cypress stub test

Currently we do not have e2e testing infrastructure.

[x] add a cypress stub
[x] add a test:e2e npm action that will run the "smoke test" cypress test

Added in #353


Update FAQ block type code example

The example code for the faq block type was outdated. Those are the same fixes as in https://github.com/rohberg/volto-accordion-block/issues/1

I just noticed that the two test failures are from redirects in links.
* https://github.com/plone/training/runs/7249210720?check_suite_focus=true#step:5:3035

* https://github.com/plone/training/runs/7249210720?check_suite_focus=true#step:5:3082

I could either fix them in a separate PR and you can merge main into your branch, or you can fix them as part of this PR. Please let me know. Thank you!

It was just a tempoararily broken link: https://github.com/plone/training/runs/7249210720?check_suite_focus=true#step:5:3086
With a re-run of the test it's fine now.
Just ping us on Discord channel "documentation" https://discord.com/channels/786421998426521600/862642144401031188 if an unrelated test failure happens.
A re-run of tests can be done by heading over to tab "actions" and restart failed tests like the linkcheck.

Oh, that's right. We don't run linkcheckbroken with it erroring it out on either broken or redirect, like we do in plone/documentation. Maybe we should?
In any case, those two redirect links must be fixed, either in this PR or another.

In any case, those two redirect links must be fixed, either in this PR or another.

Done in #627.
@mliebischer once you restore the figure, we can merge. Thank you!


Gradle error: Module depends on one or more Android Libraries but is a jar

I tried adding hellocharts as a dependency in Android Studio 1.5 via File > Project Structure > App > Dependencies > +
I'm getting this error:
Warning:Module 'com.github.lecho:hellocharts-library:1.5.8' depends on one or more Android Libraries but is a jar

I have absolutely no clue what to do. Googling the error doesn't really turn up anything that's useful for me (I'm a bit new to gradle)
Is this an issue with HelloCharts? My project?

Okay nvm. I've solved it by replacing
compile 'com.github.lecho:hellocharts-library:1.5.8'

with
compile 'com.github.lecho:hellocharts-library:1.5.8@aar'

It's kind of weird because the original line was placed their by AS, not me..?


Rewrite parser in nom

https://github.com/Geal/nom

Or maybe use something like https://github.com/kevinmehall/rust-peg/blob/master/tests/test_arithmetic.rs

if you need any help using nom, please let me know :wink:

Am literally working on this right now. Loving nom so far, great job!
Thanks for the offer. I'll let you know if I run into any issues


Questions of calculating the loss of padded part when model performed pre-training

Hello, I am sorry to ask you but I'm very curious about this part.
It seems to be the s3prl upstream models are calculating the padded part when performed pre-trained. For example, as following the figures:
Example 1 (Tera)
The frames around 270 ~ 320 are padded parts (for running at batch-level)

And we can know that the recovered zero-padded frames are weird

The following figure is the true (real) spectrogram

I think this will cause makes model confusing at the pre-training level.
Here the 2nd figures are given:

The order is the same as in the first figure part.
And, this leads to loss explosion like the following figure:

If we want to prevent calculating the loss of the zero-padded part, what could we have to change the code?
And it seems that predict the 'silence' part well, but not well in the zero-padded part.

Following from issue https://github.com/s3prl/s3prl/issues/342,
it looks like you have modified our code, for:

Our dataset does bucketing, so that in each batch all the utterances have the same length (for most cases, if not paddings are added, but since the bucketing was applied the paddings won't be in a long length). Thus it is not normal to have such long padding as shown in your example.
We calculate the actual length of each utterance without padding here: https://github.com/s3prl/s3prl/blob/6e4d75b4e149f662bb419a154109f0ac663f958d/s3prl/pretrain/mockingjay/task.py#L82 then we set those index with zero paddings to zero attention (meaning the model will not consider those time stamps): https://github.com/s3prl/s3prl/blob/6e4d75b4e149f662bb419a154109f0ac663f958d/s3prl/pretrain/mockingjay/task.py#L93-L94
A mask_label is applied, so the model will only have to predict the masked input, and certainly NOT the zero padding part. Please track the process of creating this mask_label here: https://github.com/s3prl/s3prl/blob/6e4d75b4e149f662bb419a154109f0ac663f958d/s3prl/pretrain/mockingjay/task.py#L155 and applying it to the loss: https://github.com/s3prl/s3prl/blob/6e4d75b4e149f662bb419a154109f0ac663f958d/s3prl/pretrain/mockingjay/pretrain_expert.py#L265

I am pretty certain our original code will NOT generate faulty examples like the ones shown above,
and it is NOT normal for the loss to explode like that.
Can you check that the above points are implemented correctly?
To me it looks like your loss is spiking mainly due to not following our implementation in 3).
FYI, I will be closing issue https://github.com/s3prl/s3prl/issues/342 since it looks like you have resolved the error,
but feel free to reopen it again if I'm mistaken.
Andy

Dear @andi611,
Thanks for replying.
I think this problem was caused by the old version because I downloaded s3prl last October, and only modified some interesting parts.
Further, in the last issue #342, I also guess that this has occurred to the s3prl version problem.
From now, I will update all from your recent framework and try to solve this problem. We will be touch in soon.

Dear @andi611,
I have another question.
If we set the sequence_length from config_model.yaml as 1500 (default), it means the maximum sequence length is around 1,500 frames.
So the pre-trained model is performed until 1,500 sequences, right?
In this regard, I have some questions what if we set the maximum sequence length as 1,500.
What happens to the 3,000 frames of utterance file after the pre-training procedure in the feature extracted task or fine-tuning downstream task?

the given wav file will be feature extracted from the pre-trained model until 1,500 sequences.

the given wav file will be feature extracted from the pre-trained model until the end of that sequence?

I'm very curious about the maximum sequence length. Because I have the other datasets (not LibriSpeech), so very sensitive to set that parameter. Please help!

I think this problem was caused by the old version because I downloaded s3prl last October, and only modified some interesting parts.
Further, in the last issue #342, I also guess that this has occurred to the s3prl version problem.

I don't think this is the case...
This is our repo back from last Sept: https://github.com/s3prl/s3prl/tree/2a6894515bb7fbd9a619fba43ce035d5a8ecf401
Everything I've talked about has already been implemented.
In fact, I believe we implemented those from the very beginning.
For example:

The bucketing dataset, and
The label mask so the model is not asked to predict the padding: https://github.com/s3prl/s3prl/blob/2a6894515bb7fbd9a619fba43ce035d5a8ecf401/s3prl/pretrain/mockingjay/pretrain_expert.py#L260
Calculating true length without padding: https://github.com/s3prl/s3prl/blob/2a6894515bb7fbd9a619fba43ce035d5a8ecf401/s3prl/pretrain/mockingjay/task.py#L81-L82
Ignore padding timestamps:
https://github.com/s3prl/s3prl/blob/2a6894515bb7fbd9a619fba43ce035d5a8ecf401/s3prl/pretrain/mockingjay/task.py#L93-L94

As such I would highly appreciate it if you could not imply that it is our older versions that caused those errors.
Because I believe our implementations (whether old or current version) does not exhibit those faulty behaviors/errors.
Please correct me if I'm mistaken.

So the pre-trained model is performed until 1,500 sequences, right?

This is partially correct. We will randomly sample a sub-sequence from the whole sequence:
https://github.com/s3prl/s3prl/blob/6e4d75b4e149f662bb419a154109f0ac663f958d/s3prl/pretrain/bucket_dataset.py#L80-L84
so it is not always performed from the start.
However, note that you can disable this any train on the whole sequence ignoring the max length.

In this regard, I have some questions what if we set the maximum sequence length as 1,500.

We simply forward the sequence in chunks (of length determined by sequence_length being 1500) and concatenate the results:
https://github.com/s3prl/s3prl/blob/6e4d75b4e149f662bb419a154109f0ac663f958d/s3prl/upstream/mockingjay/builder.py#L203-L211
Please let me know if you have any more questions :)


Adding Python and C++ versions of ImageGradient.

The test image doesn't match the textbook figure 10-16.

@ajpmaclean I'd rather we do not add another copy of the full head dataset. Could you use the existing FullHead.mhd dataset?

Should be able to. I'll look into it.
Andrew Maclean
On 30 Nov 2017 22:16, "Bill Lorensen"<EMAIL_ADDRESS>wrote:

@ajpmaclean https://github.com/ajpmaclean I'd rather we do not add
another copy of the full head dataset. Could you use the existing
FullHead.mhd dataset?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lorensen/VTKExamples/pull/90#issuecomment-348159224,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIJ4OzsjI3zTXq8e6McbnQxl4iJFdwUvks5s7o6lgaJpZM4QwAGM
.