Cannot find struct, variant or union type structx_... in this scope

Hello
I'm trying to run simple examples with structx, but can't make it work
use structx::*;

struct RectangleTidy {
    dimensions : Structx!{
        width  : u64,
        height : u64,
    },
    color     : Structx!{
        red   : u8,
        green : u8,
        blue  : u8,
    },
}

fn main() {
	let some = structx!{
		a: 1u8,
		b: 2f32,
		c: structx!{
			a: "coucou",
			b: [34; 5],
			},
		};
}

I have the following in Cargo.toml
[package]
name = "test_structx"
version = "0.1.0"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
structx = "0.1.8"

[build-dependencies]
inwelling = "0.5"

[package.metadata.inwelling]
structx = true

And in build.rs
fn main() {
	inwelling::to( "structx" );
}

The compiler does not seems to create or locate the anonymous structs correctly
$ cargo build
   Compiling test_structx v0.1.0 (/home/ydejonghe/ethercat/test_structx)
error[E0412]: cannot find type `structx_height_width` in this scope
 --> src/main.rs:4:18
  |
4 |       dimensions : Structx!{
  |  __________________^
5 | |         width  : u64,
6 | |         height : u64,
7 | |     },
  | |_____^ not found in this scope
  |
  = note: this error originates in the macro `Structx` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0412]: cannot find type `structx_blue_green_red` in this scope
  --> src/main.rs:8:17
   |
8  |       color     : Structx!{
   |  _________________^
9  | |         red   : u8,
10 | |         green : u8,
11 | |         blue  : u8,
12 | |     },
   | |_____^ not found in this scope
   |
   = note: this error originates in the macro `Structx` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0422]: cannot find struct, variant or union type `structx_a_b_c` in this scope
  --> src/main.rs:16:13
   |
16 |       let some = structx!{
   |  ________________^
17 | |         a: 1u8,
18 | |         b: 2f32,
19 | |         c: structx!{
...  |
22 | |             },
23 | |         };
   | |_________^ not found in this scope
   |
   = note: this error originates in the macro `structx` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0422]: cannot find struct, variant or union type `structx_a_b` in this scope
  --> src/main.rs:19:6
   |
19 |           c: structx!{
   |  ____________^
20 | |             a: "coucou",
21 | |             b: [34; 5],
22 | |             },
   | |_____________^ not found in this scope
   |
   = note: this error originates in the macro `structx` (in Nightly builds, run with -Z macro-backtrace for more info)

Some errors have detailed explanations: E0412, E0422.
For more information about an error, try `rustc --explain E0412`.

Am I missing something ?

Oops structx!{} in structx!{}!
Your code constructs nested structx!{}s, which I hadn't thought of.
structx!{ a: 1u8, b: 2f32, c: structx!{ a: "coucou", b: [34; 5], }  };

It will compile after removing field c.
However, I'm considering to support nested structx!{} in version 0.1.9

Okay, so no nested structx :sweat_smile:
But I still get the same errors while having field c commented
$ cargo build
   Compiling test_structx v0.1.0 (/home/ydejonghe/ethercat/test_structx)
error[E0412]: cannot find type `structx_height_width` in this scope
 --> src/main.rs:4:18
  |
4 |       dimensions : Structx!{
  |  __________________^
5 | |         width  : u64,
6 | |         height : u64,
7 | |     },
  | |_____^ not found in this scope
  |
  = note: this error originates in the macro `Structx` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0412]: cannot find type `structx_blue_green_red` in this scope
  --> src/main.rs:8:17
   |
8  |       color     : Structx!{
   |  _________________^
9  | |         red   : u8,
10 | |         green : u8,
11 | |         blue  : u8,
12 | |     },
   | |_____^ not found in this scope
   |
   = note: this error originates in the macro `Structx` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0422]: cannot find struct, variant or union type `structx_a_b` in this scope
  --> src/main.rs:16:13
   |
16 |       let some = structx!{
   |  ________________^
17 | |         a: 1u8,
18 | |         b: 2f32,
19 | | //         c: structx!{
...  |
22 | | //             },
23 | |         };
   | |_________^ not found in this scope
   |
   = note: this error originates in the macro `structx` (in Nightly builds, run with -Z macro-backtrace for more info)

Some errors have detailed explanations: E0412, E0422.
For more information about an error, try `rustc --explain E0412`.

Didn’t reproduce it. Would you plz tell the platform info, e.g. x86_64-pc-windows-msvc?

Yes, I forgot to mention it:

os: ubuntu 20.04
toolchain:
stable-x86_64-unknown-linux-gnu (default)
rustc 1.68.2 (9eb3afe9e 2023-03-27)
gcc: gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
clang: 10.0.0-4ubuntu1

Before I finish installing Ubuntu 20.04, would you mind running some scripts to help analysis?
Change to manifest directory ( the one containing Cargo.toml ), and
find target/debug/build -name invoked.timestamp -exec ls -l --full-time {} \;

and show the output.

Sure, here is  the output
$ find target/debug/build -name invoked.timestamp -exec ls -l --full-time {} \;
-rw-r--r-- 1 ydejonghe yves 48 2023-04-06 11:16:51.696834993 +0200 target/debug/build/structx-ca030776c8a3f99f/invoked.timestamp
-rw-r--r-- 1 ydejonghe yves 48 2023-04-06 11:16:45.092835277 +0200 target/debug/build/syn-23c11cb3969bdef4/invoked.timestamp
-rw-r--r-- 1 ydejonghe yves 48 2023-04-06 18:44:45.715679723 +0200 target/debug/build/test_structx-d5956c9627b0d64e/invoked.timestamp
-rw-r--r-- 1 ydejonghe yves 48 2023-04-06 11:16:45.080835277 +0200 target/debug/build/serde-b4f1b1467f0b03db/invoked.timestamp
-rw-r--r-- 1 ydejonghe yves 48 2023-04-06 11:16:45.144835275 +0200 target/debug/build/proc-macro2-c5954e779c9f87d5/invoked.timestamp
-rw-r--r-- 1 ydejonghe yves 48 2023-04-06 11:16:45.068835278 +0200 target/debug/build/quote-30b258d11e299ebe/invoked.timestamp
-rw-r--r-- 1 ydejonghe yves 48 2023-04-06 11:16:45.420835263 +0200 target/debug/build/indexmap-505c3e24aba69b59/invoked.timestamp

The crate structx need to collect structx!{}/Structx!{} instances in downstream crates and generate the struct definitions. This kind of "dependency inversion" is not supported by cargo, and crate inwelling comes to the rescue.
This is an inwelling issue.

I'm glad to mention that structx 0.1.9 has been published, which supports nested anonymous structx.


Expose configuration for plugins directory

ATM the plugins directory is hard coded to:
private void updatePlugins() {
    final File pluginsDirectory = new File(OSystemVariableResolver.resolveSystemVariables("${ORIENTDB_HOME}", ".") + "/plugins/");

I'd like to be able to define a property in the server configuration to specify the location of this instead.
Should help with embedding where the runtime environment is different from the shrink-wrap distribution.

It would also be kinda nice if you could install a plugin from a URL, so we can embed a plugin into an OSGI bundle and then install it based on the resource url?  And avoid the entire plugins/ directory completely?

Exposed Plugin Manager instance in OServer class
new "plugin.loadAtStartup" to decide if load plugins at startup
new "plugin.directory" settings to assign a different directory


Add math-based activation layers

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (39b5bc2) to head (3c3bb13).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           15        16    +1
  Lines          220       237   +17
  Branches        18        18
=========================================
+ Hits           220       237   +17

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


go_1_12: init at go 1.12

Motivation for this change
The build cache is now required as a step toward eliminating $GOPATH/pkg. Setting the environment variable GOCACHE=off will cause go commands that write to the cache to fail. I've updated all the packages that I could find and are using go without using buildGoPackage.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[x] macOS (sandbox off)
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

 I tested the entire PR on Darwin myself, but unlike ofborg I’m running APPFS.

@GrahamcOfBorg build go_1_12

@GrahamcOfBorg build prometheus

The last darwin build error just look like resource depletion. I think we can ignore this given that you already build on macOS.

This was the build error log of prometheus: https://dl.thalheim.io/RRa5YdOzO7l0jKJ1cV01aA/prometheus.log

Ok. Maybe this was caused by my zfs filesystem or some other random stuff.


Table plugin creates multiple div elements while typing

Description
When the table plugin is enabled, a div with the class trumbowyg-table-resize-layers is added to the DOM. This div is added after every click or character typed into the tumbowyg editor, which can mean hundreds of new divs are created.
How to reproduce?
Codepen: If you right-click and Inspect the editor, you can see the divs added while typing. The bug is caused by the allowHorizontalResize option, and doesn't appear when disabled by:
plugins: {
      table: {
        allowHorizontalResize: false
      },

Nice catch! :)
Need to be fixed in fact!

With version 2.28.0 it seems that this issue is back, but slightly different. The editor now creates multiple trumbowyg-table-resize-vertical-handle elements:


Swap internal resources for cluster ingress/egress

The current setup doesn't work with the proposed new ingress. This will fix it. This PR provisions the public IP under Amaterasu's resource group for increased control. Also, drop the unused load balancer.
This is all because we're shifting to a simpler ingress scheme on AZ.

Looks like terraform is struggling, so we're going to merge this and see if we can apply the changes from the main branch.


[tbs.co.jp] ExtractorError: Empty playlist

[x] I've verified and I assure that I'm running youtube-dl 2017.03.10
[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[x] Site support request (request for adding support for a new site)

Hi,
I can watch the video with firefox.
Don't know if it's really a bug or a site support request: is TBS japan included ?
$ youtube-dl -v -f best  "http://www.tbs.co.jp/seriku/movie/player.html?bctid=15atm0082_020"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-f', u'best', u'-v', u'http://www.tbs.co.jp/seriku/movie/player.html?bctid=15atm0082_020']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.03.10
[debug] Python version 2.7.9 - Linux-3.16.0-4-amd64-x86_64-with-debian-8.7
[debug] exe versions: avconv 11.8-6, avprobe 11.8-6, rtmpdump 2.4
[debug] Proxy map: {}
[generic] player: Requesting header
WARNING: Falling back on generic information extractor.
[generic] player: Downloading webpage
[generic] player: Extracting information
[generic] Brightcove video detected.
[download] Downloading playlist: 競技動画｜TBSテレビ：世界陸上北京
[generic] playlist 競技動画｜TBSテレビ：世界陸上北京: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[brightcove:legacy] AQ~~,AAAABl_qIFk~,1zrlVCWCJHPiZuBbgHyJP7aD-Sqnohj-: Downloading playlist information
ERROR: Empty playlist; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 761, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 427, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/brightcove.py", line 290, in _real_extract
    return self._get_playlist_info(player_key[0])
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/brightcove.py", line 333, in _get_playlist_info
    raise ExtractorError('Empty playlist')
ExtractorError: Empty playlist; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

http://www.tbs.co.jp/seriku/movie/player.html?bctid=15atm0082_020 is gone, and other videos on tbs.co.jp are now on YouTube, which can be downloaded. For example:
[1]$ youtube-dl -vF "http://www.tbs.co.jp/gomen_aishiteru/"
[debug] System config: []
[debug] User config: ['-v', '--add-metadata', '--xattrs', '-o', '~/tmp/%(title)s-%(id)s.%(ext)s']
[debug] Custom config: []
[debug] Command-line args: ['-vF', 'http://www.tbs.co.jp/gomen_aishiteru/']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.07.15
[debug] Git HEAD: d20b1c672
[debug] Python version 3.6.2 - Linux-4.11.9-1-ARCH-x86_64-with-arch-Arch-Linux
[debug] exe versions: ffmpeg 3.3.2, ffprobe 3.3.2
[debug] Proxy map: {}
[generic] gomen_aishiteru: Requesting header
WARNING: Falling back on generic information extractor.
[generic] gomen_aishiteru: Downloading webpage
[generic] gomen_aishiteru: Extracting information
[download] Downloading playlist: 日曜劇場『ごめん､愛してる』
[generic] playlist 日曜劇場『ごめん､愛してる』: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[youtube] M4vAd_i6_ko: Downloading webpage
[youtube] M4vAd_i6_ko: Downloading video info webpage
[youtube] M4vAd_i6_ko: Extracting video information
[youtube] M4vAd_i6_ko: Downloading MPD manifest
[info] Available formats for M4vAd_i6_ko:
format code  extension  resolution note
249          webm       audio only DASH audio   47k , opus @ 50k, 169.84KiB
139          m4a        audio only DASH audio   48k , m4a_dash container, mp4a.40.5@ 48k (22050Hz), 187.61KiB
250          webm       audio only DASH audio   61k , opus @ 70k, 217.59KiB
171          webm       audio only DASH audio  101k , vorbis@128k, 365.04KiB
251          webm       audio only DASH audio  117k , opus @160k, 415.50KiB
140          m4a        audio only DASH audio  127k , m4a_dash container, mp4a.40.2@128k (44100Hz), 498.42KiB
278          webm       256x144    144p  103k , webm container, vp9, 30fps, video only, 388.92KiB
160          mp4        256x144    DASH video  115k , avc1.4d400c, 30fps, video only, 419.07KiB
242          webm       426x240    240p  232k , vp9, 30fps, video only, 843.26KiB
133          mp4        426x240    DASH video  247k , avc1.4d4015, 30fps, video only, 893.74KiB
243          webm       640x360    360p  417k , vp9, 30fps, video only, 1.44MiB
134          mp4        640x360    DASH video  593k , avc1.4d401e, 30fps, video only, 1.52MiB
244          webm       854x480    480p  760k , vp9, 30fps, video only, 2.35MiB
135          mp4        854x480    DASH video 1159k , avc1.4d401f, 30fps, video only, 2.93MiB
247          webm       1280x720   720p 1505k , vp9, 30fps, video only, 4.46MiB
136          mp4        1280x720   DASH video 2171k , avc1.4d401f, 30fps, video only, 5.62MiB
248          webm       1920x1080  1080p 2540k , vp9, 30fps, video only, 7.91MiB
137          mp4        1920x1080  DASH video 4264k , avc1.640028, 30fps, video only, 11.88MiB
17           3gp        176x144    small , mp4v.20.3, mp4a.40.2@ 24k
36           3gp        320x180    small , mp4v.20.3, mp4a.40.2
43           webm       640x360    medium , vp8.0, vorbis@128k
18           mp4        640x360    medium , avc1.42001E, mp4a.40.2@ 96k
22           mp4        1280x720   hd720 , avc1.64001F, mp4a.40.2@192k (best)
[download] Finished downloading playlist: 日曜劇場『ごめん､愛してる』

Feel free to open a new issue if another video is broken.


BUG: failed to set locale

TASK [bigbluebutton : Install required packages] **************************************************************************************************************
ok: [bbbtest1]

TASK [bigbluebutton : set version of java to use] *************************************************************************************************************
ok: [bbbtest1]

TASK [bigbluebutton : Ensure localisation files for 'en_US.UTF-8' are available] ******************************************************************************
ok: [bbbtest1]

TASK [bigbluebutton : Get current locale and language configuration] ******************************************************************************************
ok: [bbbtest1]

TASK [bigbluebutton : Parse 'LANG' from current locale and language configuration] ****************************************************************************
fatal: [bbbtest1]: FAILED! => {"msg": "Unexpected templating type error occurred on ({{ locale_status.stdout | regex_search('LANG=([0-9A-Za-z_.-]+)', '\\\\1') | first }}): 'NoneType' object is not iterable"}

What was bbb_system_locale set to? And can you provide me with the output of localectl status?

bbb_system_locale was not set (so it has the default value: en_US.UTF-8)
localectl status
   System Locale: n/a
       VC Keymap: n/a
      X11 Layout: n/a


./rudr: /usr/lib/x86_64-linux-gnu/libcrypto.so.1.1: version `OPENSSL_1_1_1' not found (required by ./rudr)

Output of helm version:
version.BuildInfo{Version:"v3.0.0", GitCommit:"e29ce2a54e96cd02ccfce88bee4f58bb6e2a28b6", GitTreeState:"clean", GoVersion:"go1.13.4"}
Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.3", GitCommit:"b3cbbae08ec52a7fc73d334838e18d17e8512749", GitTreeState:"clean", BuildDate:"2019-11-14T04:24:29Z", GoVersion:"go1.12.13", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.5", GitCommit:"20c265fef0741dd71a66480e35bd69f18351daea", GitTreeState:"clean", BuildDate:"2019-10-15T19:07:57Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
Digital Ocean

Describe the bug
helm install rudr charts/rudr
$ kubectl logs -f -l app.kubernetes.io/name=rudr                                                             master
./rudr: /usr/lib/x86_64-linux-gnu/libcrypto.so.1.1: version `OPENSSL_1_1_1' not found (required by ./rudr)

OAM yaml files used
N/A
What happened:

What you expected to happen:
Relevant screenshots:
How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:

Sorry for that, I'm building image to fix this, it takes some time.

I have manually pushed image oamdev/rudr:latest (amd64), you could give a try again.

Thank u It's working now.


Update GUI

Add padding to MEM/GUP Max clock.
Should make the text inside the texbox a bit more readable.
Update release executable with the latest changes.

starts to think it would be neater if you could just get writer privilege

I don't mind , depends on @OneB1t tho.
I added a bit more fixes , can you check out how it is on your end ?

Sorry I only have GCN1

I was just asking for gui feedback , not to load a bios , tho you can load even if it's gcn1


unsubscribe w/o passing whole list

the confluent library has this limitation:
https://github.com/confluentinc/confluent-kafka-go/issues/1193
can sarama mitigate this?

I don’t think we have any way to unsubscribe from a topic in general…

darn, how is that possible? I don't understand what's happening


fix(#137): add a special rule for "sku"

Fixes #137

Coverage remained the same at 100.0% when pulling 2e63355f2130944841397daf8131ad942ac8cea7 on mdacosta:fix/137 into abb399111aedd1d62dd418d7e0217d85f5bf22c9 on blakeembrey:master.

Can we put Sku back to the list?


Reduce memory usage for linking at prediction time

Currently requires 5GB
Model files are here: s3://ai2-s2-scispacy/data/linking_model/
Run the model with this: python3 scripts/linking.py --medmentions_path data/medmentions --umls_path data/umls_2017_aa_cat0129.json --k 1,2,10,100,1000 --model_path data/linking_model

Training still requires 150GB of memory, but addressing that is a different PR


Change custom marker position.

Hello,
I'm trying to add my custom image as Marker on MapView. I want set this Marker coordinates to my localization.
My problem is that I can't center the marker on point, it is placed above actual localization.
There is my code:

Here is the result:

I tried to set centerOffset, but it didn't solve the problem.

@Anytram did you find the solution?


fix(ng): describe by for input validation errors

PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?
Set the proper describe by when error message is visible on an input. The error message had the aria-describeby when it should of been the input instead.
Issue Number:
closes #3561
What is the new behavior?
When an error occurs the input will now be described by the error message.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Shouldn't the commit message be something like fix(forms):


Build pulls in both static and shared library of libwebsockets if available

If both variants are installed they're linked to ttyd which is incorrect. I couldn't find quick solution (time constraints) using the current layout so I used pkgconfig instead to pick up the correct library.
Link to pkgconfig variant, https://cgit.freebsd.org/ports/plain/sysutils/ttyd/files/patch-CMakeLists.txt
FreeBSD 13.1 / 13.2-BETA2
CMake: 3.25.1
libwebsockets: 4.3.2

https://github.com/warmcat/libwebsockets/blob/main/cmake/libwebsockets-config.cmake.in#L18
https://github.com/tsl0922/ttyd/blob/main/scripts/cross-build.sh#L88
It is set by upstream, I'm doing similar hack in ttyd's cross-build script too.


How to config for Valheim mod ?

Hello there,
How to config for Valheim mod ?

Hey. This is not possible right now. Maybe I will add support for mods in the future.

Can you guide the customizations, so that I can customize the Valheim server start with Bepinex ?
I don't have go-lang background, so I can't depend on it


Question: Any way to constrain documents indexed by an ArangoSearch View?

This is an optimization related question. I have a large collection of documents where I would like to link and search a smaller subset of documents to an arangosearch index. The goal is to reduce the size of the index and improve query performance by eliminating a large number of invalid candidate documents. I don't see a way to do this via the current API (unless I missed it), but this could be achieved by being able to link a view conditionally based on the value / evaluation of a specified document field (to act as an index gate). I realize I could create another indexed collection that would contain the searchable documents, but I would prefer not to have to have duplicate documents in two places and deal with synchronization issues.
Thank!

What you describe is a partial index and it's already on our radar, but it's not implemented and there is also no ETA currently.


Word highlighting leaks text models

Does this issue occur when all extensions are disabled?: Yes/No

[x] Yes

VS Code Version: 1.94.0
OS Version: MacOS Sonoma (14.4.1)

Steps to Reproduce:

Open VSCode
create new file (CMD+N)
input random text
close file (CMD+A -> delete -> CMD+W)
create new file again (CMD+N)

Attach Video:
https://github.com/user-attachments/assets/d05a1225-2e59-43ae-af41-c46623cfb8d2

I can reproduce.
@Yoyokrazy can you please take a look, this is a regression from https://github.com/microsoft/vscode/commit/6092f245833f7c7431825878819766716684a5b0
Specifically an editor no longer seems to get disposed when closing it when it is dirty. Steps:

start a window on a folder without editors opened
open an editor, type in it, close it
do not save
run the "Log Working Copies" action

=> 🐛 the editor that was just closed is still in there
The fact that the number for the untitled number increases is a variant of this issue: we only re-use a previously used untitled editor number if that previous editor model was disposed.
I think this meets the bar for being a candidate.

@Yoyokrazy @rebornix this looks super fishy:
https://github.com/microsoft/vscode/blob/dc265add0b37d88dcf955ef83c8d483e35af242c/src/vs/editor/contrib/wordHighlighter/browser/wordHighlighter.ts#L702
and
https://github.com/microsoft/vscode/blob/dc265add0b37d88dcf955ef83c8d483e35af242c/src/vs/editor/contrib/wordHighlighter/browser/wordHighlighter.ts#L725
Anytime I make a click into the editor and change the selection, the model gets resolved and never disposed.
Besides the fact that a model reference must be disposed, I really do not understand why the model has to be resolved like this when it should just be there from the code editor 🤔

Besides the fact that a model reference must be disposed, I really do not understand why the model has to be resolved like this when it should just be there from the code editor

This is done specifically to enable the use of multi-model occurrence highlighting in notebooks. The issue in the notebook case for the following situation:

editor focus in cell A, with highlights requested throughout the entire notebook
cell A scrolled off the viewport
cell X scrolled into the viewport, WH is spun up, query is detected, and requests occurrences.

occurrences should be seeded off the cell that was scrolled off the viewport, with a disposed model
trigger an occurrence request based off the stored position and URI within the static WordHighlighter.query (which requires resolving the disposed model from cell A)

The fix for this is quite small, just disposing the stored IReference after the occurrence request is resolved and decorations are rendering. I'm surprised that the testing we have in place for occurrence highlighting didn't catch the leaked disposables, I'll make an item to add that check in as a debt item as well.

Yeah would be really good to have a unit test for this 👍

Verification Steps:

with occurrence highlighting set to either singleFile or multiFile
open any file, make a selection
close the file
run Log Working Copies from the command palette and ensure that the file is not present in the list


Update to naga 0.5

Matches recent release of wgpu 0.9. Note that naga::front::wgsl::ParseError doesn't store the shader source anymore and now requires it to be passed explicitly when calling err.location or err.emit_to_string.

Thank you very much, works like a charm.


Zero size files problem with progress not being called

When downloading a file with 0 bytes, it is completed correctly and returns true from DownloadFileAsync. But the progress is never reported. The UI remains at 0% althought the operation is done. The API should call the progress reporter in this case so that the client code can update the UI. Even if no bytes are transferred, the file is created. So, technically the operation is 100% completed.
I think this loop is never entered because both offset and fileLen are 0:
while (offset < fileLen || readToEnd) {
. . .
ReportProgress(progress, fileLen, offset, bytesProcessed, DateTime.Now - transferStarted);
. . .
}

Good point.

Done. Gone live with 29.0.0:

Fix: Always send progress reports after file download, even for zero-length files

https://www.nuget.org/packages/FluentFTP/29.0.0


Composability & custom Dockerfiles

One of the major flaws in buildpacks is that they're tricky to compose and customize. Docker offers, basically, the other end of the spectrum: you can add whatever you want.
It would currently be a pain to, for example, use Node + Python. Just like buildpacks, we have a Node platform and a Python platform, and no first-class mechanism for using them together.
Can anyone think of a better way?

I like @jesperfj idea of publishing docker images instead of writing out big Dockerfiles in init that will go stale as we make improvements

I agree; one of our benefits is making upstream patches for you.
The question to answer here is: do we really need templating? That was a big factor into my decision to write Dockerfile templates into platforms; we talked a lot initially about how Dockerfiles are limiting and how we would need to templatize them.
I'm not sure that is true, but we should ensure that we'll be able to do everything we want with published docker images.

I propose that we keep the templates for now, but that we also begin to adopt Docker images where it makes sense.
For instance, the Go language is has very few versions and little variability. I definitely think we should publish a heroku/go image for each version. This might be the same for Node.js and even for the base Ruby versions.
Each language can then still have a template which in some cases (i.e. Go and Node.js) will select the appropriate base image and in other cases (i.e. Ruby) do that and also apply additional instructions.

@tt +1, I can do most of what node does with version tags, but I doubt that's true for ruby.

The tricky bit is - this leaves the platforms coupled to the plugin :(
Let's come up with some ideas on alternatives to that, specifically.

Right now each platform exposes (or will expose):

name, the platform's name
detect(dir), to detect the platform on init
mountDir(), the directory into which to mount the local app volume

Additionally, the platforms object provides a list of platforms (the detect order).
How can we provide this data externally (removing everything in /platforms)? Ideally, via some data attached to the Dockerfile / image itself on the registry.

https://github.com/heroku/heroku-docker/tree/compose uses docker hub images (https://registry.hub.docker.com/u/hunterloftis/node/). The local Dockerfile begins with just FROM owner/image[:tag] and can be extended by adding more Dockerfile commands below.
 Upstream changes to the image can still be incorporated since we're using FROM instead of templates this time around.

This feels right.


Sales page (and any other place that shows sortable release date in the context of a game's price) should use first-buyable-on-Steam date

Feature Description
I love https://github.com/SteamDatabase/steamdb.info-issues/issues/367 because it lets me more easily find games that aren't going to get cheaper any time soon, or notice the five years old title that did just get cheaper.
At least for the Sales page, I'm basically diametrically opposed in evaluation to #748, who claimed:

Solution: Year filter should look only at Store Release Date. What do we care about year when game was added to Steam? Date of releasing the game is more important.

 Developers put the weirdest things there. Lately I've seen a whole bunch of random solo developer games that released in 2022 but claimed to be from 2019/2020.
To give you a practical example, right now, if I sort for oldest games, I do indeed find https://store.steampowered.com/app/318300/Phineas_and_Ferb_New_Inventions/ - discounted for the first time in around five years. Great!
But there's also as "Feb 1991" https://steamdb.info/app/1260920/ with 7 Feb 2022 as the actual release date, and thus a very low 35% discount (and 2020 depots). Or "Jan 1997" https://steamdb.info/app/1257950/ which launched on Steam in August 2020. Or how about https://steamdb.info/app/1519140/ , a "2004" Early Access game. How even?
For the purpose of looking at sales, these are newer releases. They shouldn't be at the very top of the oldest Steam releases on sale.
It's commendable that, right now, for "Release Date", SteamDB shows when they actually released on Steam. As a side note I feel the "Store Release Date" should also be on the overview table and not hidden in the Information tab, as it seems like something that'd help more users than for example the not very actionable Last Change Number. But on the page you sort by release date to buy things, it lists the nonsense date instead.
(For Early Access titles, it's also more useful to have the first-buyable date than the 1.0-release date, since the latter is very often rather arbitrary in nature. SteamDB's Release Date is unfortunately the 1.0 date, like for https://steamdb.info/app/644930/info/ .)
P.S.: I believe for a short while in the last year or two, the sales page actually showed Steam availability dates rather than fake store dates? Or maybe I was hallucinating.

For you sales date is more important, for me release date. Depending on what one is searching for we should have both.
Either way, as much as I hate to say, it's ultimately something that Steam has to fix, the messed up data is on their side. Any attempts to fix it on steamdb.info side wouldn't be better than ducktaping. Since Steam dates are unreliable I would rather pull this piece of information from other sources, but it would be difficult to automate connections.

For you sales date is more important, for me release date.

Do note that I'm also talking about the Sales page, while you are talking about info shown on Algolia.


Update age groupings for voter address counts

see: hackoregon/civic/issues/150 and https://github.com/hackoregon/neighborhoods-2018/pull/48

closed by #59


Repro for Javalin Bug Report

The diff for this is entirely deletions so it won't make any sense.
Checking out this PR's branch should give you a pretty stripped-down repro case though!

The bug for this repro was fixed!


Prevent users from accidentally throwing away edits, by making the Es…

…cape key also finish, not cancel
I'm not sure this is a good change though. Sometimes I legitimately find myself pressing escape because I want to cancel and throw away what I'm doing. But when I'm editing a form, I instinctively press it and want to save. Thoughts?

Now that I think about it, should they be in the finish function? Not a blocker but might be better to share the code and do it even when you click finish? not sure

I'm going to look at that next. unsavedFeature in EditMode can go away, we can share one finish function between "new X" and edit, etc.


Login fails when configured for local install

I configured the App to point to our locally hosted TFS instance but it fails to connect.  I can see all the requests in the IIS log but they all return 401.
Do I need to enable some specific authentication method on the app in IIS?
We are using ADSF on Zendesk to authenticate if that makes a difference.
I did enter my secondary credentials but that doesn't seem to help.
2016-05-18 22:57:48 <IP_ADDRESS> GET /tfs/_apis/wit/fields - 443 - <IP_ADDRESS> Mozilla/5.0+(Windows+NT+6.3;+Win64;+x64;+Trident/7.0;+rv:11.0)+like+Gecko https://xxx.zendesk.com/agent/tickets/10349 401 2 5 78
2016-05-18 22:57:48 <IP_ADDRESS> GET /tfs/_apis/projects $top=100&$skip=0 443 - <IP_ADDRESS> Mozilla/5.0+(Windows+NT+6.3;+Win64;+x64;+Trident/7.0;+rv:11.0)+like+Gecko https://xxx.zendesk.com/agent/tickets/10349 401 2 5 83

In order to use the app against  TFS on-premises you will need to enable basic authentication in TFS.
WARNING: Basic authentication sends username and passwords in plaintext. You should consider configuring TFS to use SSL in order to secure communication when using basic auth.

That did it. Thanks!


feat: TLSOption

What does this PR do?
It allows to create dynamic config resources: TLSOption.
Motivation
See #129
More

[x] Yes, I updated the tests accordingly
[x] Yes, I ran make test and all the tests passed

@maythamalfouadi Is this what is needed ?

Yep! Thank you @mloiseleur !

Good catch ! I fixed the example with 2e3c787


Add config option for oauth redirect

This pull request should resolve #121.
Added a redirectURL configuration option and if this is missing will default to the baseUrl.

I will update the README


[BUG] HTML generated by cython -3a renders all C code in single line

Describe the bug
cython -3a command generates C code which is rendered to single line:
To Reproduce
Code to reproduce the behaviour:
cdef int a = 3
cdef int b = 5

print(a * b)

Expected behavior
C code rendered in browser should be splited into several lines
Environment (please complete the following information):

OS: Any
Python version 3.9
Cython version master

Additional context
Issue was introduced by following commit:
commit 0b4370678e5b00a020cd990f922964d3aba59884
Author: Stefan Behnel<EMAIL_ADDRESS>Date:   Sat Jul 16 22:14:48 2022 +0200

    Reduce overhead in the code writer when writing out simple code without newlines.

 Cython/Compiler/Code.pxd |  1 +
 Cython/Compiler/Code.py  | 19 ++++++++++++-------

0b4370678e5b00a020cd990f922964d3aba59884 (just reposting to get a link the commit)


A rule works only one time

I created a rule to trigger an light switch node from a motion node to turn light on and light off.
But it works only the first time.
My current workaround is to activate Disable when trigger and reactivate after 1 minute, but it is not nice.
If I deactivate Ignore duplicate it also works, but I don't want to switch it multiple times.

I am using the latest snapshot version.
Disable when trigger is disabled
Dampening: None
two Operations: light on now, light off after 30 seconds.

For that case a good enhancmend could be a resetable timer:

signal on is received and 30 seconds timer start.
if timer ends, another operation will execute
if a second on signal is received and timer is running, it will reset or create e new timer an will disable the old one

I hope anyone can understand me.

@pgollor I guess the problem with your motion sensor node.
For example, your motion sensors sends 1 when there is a motion detected. and it should not send 0 at all. In this case, the first-time your rule satisfied and triggers operations. As you have enabled ignore duplicate rule needs 0 to reset. But your node never send 0. This is the problem. You have to send 0 immediately when you do not see a motion.
Hope this approach will help you.

I want to independent of the high level time from the motion sensor and I disabled sending the off state. Because I want to use multiple motion sensors for one light node.
But I tried it to send also the off state and it works.
I didn't know the intention behind some functions from MyController. Sorry for that.
Thank you for your help and sorry for this issue.
But without a resetting timer it would power off the light multiple times. For example a person would go throw the floor over 5 minutes, but the switch off time is 1 minute.
Maybe this function could be en enhancement for the future? The solution could be, every new state will reset the rule.


Document IAlwaysRunResultFilter and IAsyncAlwaysRunResultFilter

New filters have been added during 2.1-preview1.
The following documentation page should be updated to include those types: https://docs.microsoft.com/en-us/aspnet/core/mvc/controllers/filters

Reference:

https://github.com/aspnet/Mvc/issues/7105
https://github.com/aspnet/Mvc/pull/7120
https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.Abstractions/Filters/IAlwaysRunResultFilter.cs
https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.Abstractions/Filters/IAsyncAlwaysRunResultFilter.cs


Removing bug from package name.

Package name as it currently stands is a racial slur that does not
describe the project. Since the project is self-described in README.md as
"Node.js native addon build tool", this commit changes all references to
"nnabt" to remove the bug.

Checklist

[x] npm install && npm test passes
[x] tests are included
[x] documentation is changed or added
[x] commit message follows commit guidelines

Description of change

Package name as it currently stands is a racial slur that does not
describe the project. Since the project is self-described in README.md as
"Node.js native addon build tool", this commit changes all references to
"nnabt" to remove the bug.

duplicate of https://github.com/nodejs/node-gyp/issues/2168, please take discussion there, and changes to "gyp" should be directed to https://github.com/nodejs/gyp-next as we vendor in the gyp/ directory and no longer consider other edits to that directory

This is incorrect. This is a PR, not just a feature request. Please reopen.

Please isolate the changes in gyp/ from this PR, we don't accept changes to that directory here. Please also use #2168 to find resolution on this question. It's an ongoing discussion and while this might be a reasonable proposal, that's all it is and #2168 should be considered the place to find consensus.

And for what it's worth in terms of consensus, I'm -1 on this change.

Closing.  Too many conflicts.

Not fixed. Package still racist.


Added tests to upgrade jobs: tempest + pre-upgrade VM's life check

 (3) S53P3 Cover S50P6 test automation for upgrade


where is the data_instances2 folder?

in the train.py ,  the trainging parameters includes files in the folder of data_instances.
But i can not find the folder.
Can you help me ?

@pvskand

Hi.
This is same as issue #4 and hence am closing this. I'll upload the files very soon. Please bear with me.


Allow snippet parameterization

In many places there is code like:
auto pos = std:: ... ();

We should be able to decide what is the actual type of pos object:
auto pos ... ;
const auto pos ... ;
auto const pos ... ;

There are also lambdas with parameter like auto const value. We can parameterize:
auto value
auto const value
const auto element
...

For now it should be OK to give 3 options for return objects:
// const on:
auto <obj> // None
auto const <obj> // Right
const auto <obj> // Left

// lambda parameter:
[] (<lambda_parameter>)

Done in described manor. If we will find need for more parameters new issue can be created.


Investigate why there is a 100ms-200ms difference with current production

It may be because we have one or two extra hops (loadbalancer -> nginx -> php vs nginx -> php), but ideally we should see if there's anything we can do about it.

A bit of optimizing later and we're now pretty close! most notably removing the IPv6 support from the ELB (since EKS still doesn't support IPv6, so all those requests were timing out, ha) did most of the trick:
$ echo "GET https://k8s.omegaup.com" | vegeta attack -duration=30s -rate=50 | vegeta report
Requests      [total, rate, throughput]         1500, 50.03, 49.86
Duration      [total, attack, wait]             30.087s, 29.98s, 107.251ms
Latencies     [min, mean, 50, 90, 95, 99, max]  99.053ms, 142.88ms, 105.223ms, 269.756ms, 359.827ms, 477.787ms, 528.652ms
Bytes In      [total, mean]                     22345500, 14897.00
Bytes Out     [total, mean]                     0, 0.00
Success       [ratio]                           100.00%
Status Codes  [code:count]                      200:1500
Error Set:

$ echo "GET https://omegaup.com" | vegeta attack -duration=30s -rate=50 | vegeta report
Requests      [total, rate, throughput]         1500, 50.03, 49.86
Duration      [total, attack, wait]             30.084s, 29.98s, 103.702ms
Latencies     [min, mean, 50, 90, 95, 99, max]  102.628ms, 114.437ms, 105.185ms, 110.462ms, 123.518ms, 403.771ms, 571.472ms
Bytes In      [total, mean]                     22345500, 14897.00
Bytes Out     [total, mean]                     0, 0.00
Success       [ratio]                           100.00%
Status Codes  [code:count]                      200:1500
Error Set:


Add an option to run script in new console

This is slightly but importantly different from the existing option to run script in dedicated console. For example, sometimes I want to interactively look at the workspace of the completed script before and after a change: if it runs in a dedicate console the second will overwrite the first.
Two existing mechanisms can achieve this, but they're somewhat unwieldy: Open in external system console always opens a brand new console, but system consoles are (at least on windows) substantially annoying (lack of autocomplete, plot interactivity issues, etc.). One can also manually open new consoles to run separate versions of the script, but that relies on the user to remember to do that each time, plus multiple clicks to create and give focus to the right consoles.
This is conceptually related to #6851 but while that one appears to be a bug, this is a feature request so I put 'em up separately.

So would you like to have a new console every time you run the same file? The only problem I see with this is that we'd have to add new option to all our already crowded Configuration per file run options.

@ccordoba12 I could see this being useful for cleanly reproducible research (at least on the small scale), in ensuring that the output of an analysis script don't depend on or is affected by previous results, other functions/methods not explicitly imported, arbitrary variables/objects in the environment, etc, and serving as a catalyst/enforcer of good practices.

I run into this problem very often, this would be a very useful feature!


Only hide modal, when it is shown.

This small patch fixes issue #4383 (perf: Modal remove unnecessarily calls ionicClickBlock).

@MartinMa, could you clean this up (remove that second merge commit)? As such I won't be able to merge. Thanks.

 Should be good to go now. Thanks.

I'm closing this pull request in favor of #6160.


Ramda: prop doesn't work on undefined

Hi there, thanks for this awesome project! Helps so much to have working type definitions for libraries when working with Flow.
In the Ramda documentation, they mention that the prop method should return undefined if the parameter passed in is undefined:
R.prop('x', {}); //=> undefined

The signature that they mention with Ramda 0.25.0 is:
s → {s: a} → a | Undefined

I tried using the ? maybe operator with the $ElementType<O, T> return value, but Flow complains about "an indexer property is missing in undefined" (Try Flow)
declare function prop<T: string, O: ?Object>(key: T, o: O): ?$ElementType<O, T>;
declare function prop<T: string, O: ?Object>(
  key: T,
  ...rest: Array<void>
): (o: O) => ?$ElementType<O, T>;
declare function prop<T: string, O: ?Object>(
  __: $npm$ramda$Placeholder,
  o: O
): (key: T) => ?$ElementType<O, T>;

I also tried adding further overloads to the prop function with use of void and null, but this ran into the wrong signature being selected and a function being returned instead of ?T (as in #1965). (Try Flow)
declare function prop<T: string>(key: T, o: null | void): void;
declare function prop<T: string>(
  key: T,
  ...rest: Array<void>
): (o: null | void) => void;
declare function prop<T: string>(
  __: $npm$ramda$Placeholder,
  o: null | void
): (key: T) => void;

What would be the correct approach here? How can undefined values also be supported with prop?

Ah the joys of trying to do static typing with dynamic functional programming. 😬
I haven't found an obvious way to support this request given the utility types that Flow provides. It sure would be grand, and also I haven't seen a way.
I would just ignore the error with a // $FlowFixMe or similar, whatever you use to track errors that are known unresolvable issues.
ccing @LoganBarnett, but closing for now. Feel free to reopen if you object.

Ok, thanks for the feedback. Would be interested to hear if the situation changes.


docs.rs downloads the build image before starting the web server

This is a recent regression; I haven't bisected the change yet. It caused this mornings ~5 minute downtime.
Nov 09 16:52:37 docsrs sudo[21231]:   ubuntu : TTY=pts/0 ; PWD=/home/ubuntu/docs.rs ; USER=root ; COMMAND=/bin/systemctl restart docs.rs
Nov 09 16:52:37 docsrs cratesfyi[21281]: 2020/11/09 16:52:37 [INFO] rustwide::cmd::sandbox: pulling image rustops/crates-build-env from Docker Hub
Nov 09 16:52:38 docsrs cratesfyi[21281]: 2020/11/09 16:52:38 [INFO] rustwide::cmd: [stdout] 25fa93f27f05: Pulling fs layer
Nov 09 16:52:38 docsrs cratesfyi[21281]: 2020/11/09 16:52:38 [INFO] rustwide::cmd: [stdout] 25fa93f27f05: Waiting
Nov 09 16:54:34 docsrs cratesfyi[22776]: 2020/11/09 16:54:34 [INFO] rustwide::cmd: [stdout] 25fa93f27f05: Download complete
Nov 09 16:56:09 docsrs cratesfyi[22776]: 2020/11/09 16:56:09 [INFO] rustwide::cmd: [stdout] Status: Downloaded newer image for rustops/crates-build-env:latest
Nov 09 16:56:12 docsrs cratesfyi[22776]: 2020/11/09 16:56:12 [INFO] docs_rs::web: Running docs.rs web server on http://<IP_ADDRESS>:3000

This regressed in 1aa36cc2010d68903ec38726b3a2a3c7e073eea8; cc @pietroalbini

I think this is the issue: it blocks on init in the current thread instead of running it in the build queue reader.
https://github.com/rust-lang/docs.rs/blob/1aa36cc2010d68903ec38726b3a2a3c7e073eea8/src/utils/daemon.rs#L65


Texture property isn't available at "load" event handler

Hi guys,
I got a problem in PIXI.loaders.Loader class where the texture property is undefined all the time you want to access by load event handler.
The proof concept is very simple, just copy and paste the html below and run in any simple http server.
<html>
<head>
  <title></title>
</head>
<body>

  <script src="bin/pixi.js"></script>
  <script type="text/javascript">
    var renderer = PIXI.autoDetectRenderer(800, 600,{backgroundColor : 0x1099FF});
    document.body.appendChild(renderer.view);

    // create the root of the scene graph
    var stage = new PIXI.Container();

    // address of some awesome image
    var image = "http://www.stylefe.com/wp-content/uploads/2015/05/Scarlett-Johansson-Scarlett-Johansson.jpg"

    // Setup a loader to request image
    var loader = new PIXI.loaders.Loader;

    // Add image to load queue
    loader.add('image', image)

    // Listen 'load' event for this image
    loader.on('load', function(aLoader, resource){

      // Dump entire resources will expose "texture" property in console
      console.log('resource', resource)

      // With timeout is possible to get texture properly... but this is so ugly!
      setTimeout(function(){
        console.log('texture', resource.texture)
      }, 500)

      // Try to access texture property
      console.log("resource.texture = %s", resource.texture) // this will print undefined on console
    })

    loader.load()

    animate();
    function animate() {
        requestAnimationFrame(animate);

        // render the container
        renderer.render(stage);
    }

  </script>
</body>
</html>

The good thing is I have a solution and I'll post the pull request for the resource loader author.
If someone can't to reproduce this issue, let me know please.
Thanks,

Ok, here is the pull request I sent to @englercj
I hope this can help.
Thanks.

Closing this since it is a resource-loader bug and not pixi related.


dev -> main-beta

:tada: This PR is included in version 2.0.0-beta.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Property:statusStartDate

Label
Status Start Date

Definition
The date on which the recorded status first became applicable.

Usage

Existing property

Existing class

Existing property identifier

Format
Date

Required
No

Repeatable
No

Constraints
ISO 8601 date format. See https://www.w3.org/TR/NOTE-datetime

Examples
2012-09-27

Notes

Definition: Start date of a status of the Collection (conservation or development Status?)
Format: Date
Constraint:  ISO 8601 date format, resolved to day, month or year

Development status

Full ISO dates are hard to generate so agreed to use the following format:
https://www.w3.org/TR/NOTE-datetime

Closed after discussion by working group 3rd March 2022 along with statusEndDate, replaced by instance of TemporalCoverage


pm: device_runtime: Fix documentation

pm_device_runtime_enable and pm_device_runtime_disable no longer return -ENOSYS.

@nashif CI failures are not related with the PR.

@nashif CI failures are not related with the PR.

you will need to rebase, but I am going to merge this knowing that this is a non-issue.


return pandas

Detailed Description
It would be great to have an option to return a pandas dataframe
Possible Implementation

format='pandas' return a pandas dataframe. Should be able to do this for all endspoints once, rather than doing it lots and lots of time

This repo - https://github.com/SheffieldSolar/PV_Live-API
has a nice function where by default it returns a dataframe. I think its a nice function to have
You might be able to set response_type and see if it works, or adjust the code a bit to work for that
It might be easier to add something to the 'format' query param and then have an option to not return as pandas dataframe.

Its now been added


integrate game director

This will provide a web UI.
Currently waiting on the game director to be released.

Game director added: e78de02363800fbd55df0fd681286a327295537b
Documentation from upstream added too: 55d1a312b3ace04519c7e595d9ec7bfdcf1dcb40


The redis_proxy filter that envoy has implemented does not support read requests routing in redis M/S clusters mode！

Title: The redis_proxy filter that envoy has implemented does not support read requests routing in redis M/S clusters mode！
Description:

The redis M/S cluster mode is relatively frequently used in prod env。but，Control read requests routing. This only works with Redis Cluster. Therefore, will it consider adding support for read requests routing in M/S cluster mode in future new versions of envoy?

cc redis cluster owners: @weisisea @HenryYYang


CODE_OF_CONDUCT has been modified by the insertion of numerical points instead of dashes

…s instead of dash

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

I am very grateful to EddieHub Community for providing such beginner-friendly projects in order to practice my initial PRs.

I'm not sure that this is a change that needs to be made as the items have no hierarchy to them. If you are looking for a simple first issue then please let us know and we will help you find something that needs updating in the docs @IAMSKJha

I agree with @krishguptadev: we should keep the file exactly how it was provided.


Implement wrapper API SendBundleSpan

This MR introduces a new wrapper API SendBundleSpan that can automatically submit bundles across multiple block spans, specifically from req.BlockNumber to req.BlockNumber + span-1 (inclusive) to simplify the end-user experience when competing for block space.
Because the req.Txs does not get re-signed on each bundle block, there will be at most 1 successful bundle execution per function call.

The initial implementation is too complicated for what it should be; closing in favor of #2.


Release memory

The current KafkaConsumer code includes support for allocating buffers from MemoryPool when allocating bytes for requests to Brokers. However, the code doesn't release them back to the pool and hence, rendering pooling moot. Currently, it works because it uses MemoryPool.NONE which just mallocs buffer every time a buffer is requested. However, this won't work if a different memory pool implementation is used.
The consumer can't just release the pool back into the memory because the fetch requests keep on holding on to the references to the pool in CompletedFetch objects which live across multiple poll calls. The idea here is to use ref counting based approach, where the ClientResponse increments ref count every time a CompletedFetch object is created and decrement when the fetch is drained after a poll calls returning records.
For the rest of the things such as metadata, offset commit, list offsets it is somewhat easier as the client is done with the response bytes after response future callback is completed.
This PR also adds the ClientResponseWithFinalize class for debugging purposes as well protected by linkedin.enable.client.resonse.leakcheck flag. The class uses finalizer to check whether there is some issue in code due to which the buffer wasn't released back to the pool yet. However, during in an actual production setting, the finalizers are costly and hence, not enabled by default.
I have tested this by running this on one of the prod experimental boxes with finalizer enabled to make sure I didn't miss any usecases.

The checks fail due to a problem with java version according Radai Rosenblatt for SSLTransportLayerTest. Everything works fine while running on local
./gradlew cleanTest rat checkstyleMain checkstyleTest :clients:unitTest :core:unitTest --no-daemon -PxmlFindBugsReport=true -PtestLoggingEvents=started,passed,skipped,failed

Do check https://github.com/tusharg1993/kafka/pull/2 for review discussions.


Error after upgrading to 1.12.2

Verify canary release

[X] I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue
none
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Windows
Which canary version will you have in your reproduction?
turbo 1.12.2
Describe the Bug
The error after upgrading turbo to 1.12.2, which worked fine before with 1.11.3

(base) PS D:\WorkStudio\web\mine\fulfillment-fe> pnpm build

><EMAIL_ADDRESS>build D:\WorkStudio\web\mine\fulfillment-fe
> turbo run build

Turborepo did not find the correct binary for your platform.
We will attempt to install it now.
Installation has failed.

***

Turborepo failed to start.

Turborepo detected that you are running:
windows 64

***

We were not able to find the binary at:
turbo-windows-64/bin/turbo.exe

We looked for it at:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>D:\WorkStudio\web\mine\fulfillment-fe\node_modules\.pnpm\node_modules
D:\WorkStudio\web\mine\fulfillment-fe\node_modules
D:\WorkStudio\web\mine\node_modules
D:\WorkStudio\web\node_modules
D:\WorkStudio\node_modules
D:\node_modules
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>D:\WorkStudio\web\mine\fulfillment-fe\node_modules\.pnpm\node_modules
C:\Users\Administrator\.node_modules
C:\Users\Administrator\.node_libraries
C:\Program Files\nodejs\lib\node

***

We did not find any binaries on this system.
This can happen if you run installation with the --no-optional flag.

***

If you believe this is an error, please include this message in your report.
 ELIFECYCLE  Command failed with exit code 1.
(base) PS D:\WorkStudio\web\mine\fulfillment-fe>

Expected Behavior
Expect to compile worded fine
To Reproduce
See bug description
Additional context
No response

The identical issue.

I've verified that both the latest canary, 1.11.4-canary.4 and latest patch, 1.12.2 of turbo-windows-64 contain the correct binary. Can you verify that you have a version of turbo-windows-64 that matches the version of turbo in your node_modules?
Can you verify that you are installing with optional dependencies? i.e. not passing --omit optional or equivalent when installing?

There are certain issues present on my machine. According to the turbo.js code, when it is unable to detect the binary, it will execute
function installUsingNPM(){}
and install it in the directory represented by
const turboPath = path.dirname(require.resolve('turbo/package')).
However, on my machine, running the command npm install --loglevel=error --prefer-offline --no-audit --progress=false in this directory does not have any effect.
It seems that the binary listed under optionalDependencies in the package.json file have not been installed.
I have now modified the code in such a manner that it is functioning properly.
- function installUsingNPM() {
+ function installUsingNPM(platform,resolvedArch) {
   const turboPath = path.dirname(require.resolve('turbo/package'));

   const env = { ...process.env, npm_config_global: undefined };

   child_process.execSync(
-    `npm install --loglevel=error --prefer-offline --no-audit --progress=false`,
+    `npm install turbo-${platform}-${resolvedArch} -D --loglevel=error --prefer-offline --no-audit --progress=false`,
     { cwd: turboPath, stdio: "pipe", env }
   );
 }

I've verified that both the latest canary, 1.11.4-canary.4 and latest patch, 1.12.2 of turbo-windows-64 contain the correct binary. Can you verify that you have a version of turbo-windows-64 that matches the version of turbo in your node_modules?
Can you verify that you are installing with optional dependencies? i.e. not passing --omit optional or equivalent when installing?

I cannot find turbo-windows-64 in global node_modules

Upgrade to 1.12.3 is working


Linux users SBAT read docs to install dependencies

Expected Behavior
SETUP.md contains steps that work for both Linux and macOS users
Current Behavior
SETUP.md steps have not been tried on a Linux machine

Duplicate to https://github.com/celo-org/celo-monorepo/issues/16


Sometimes long responses are not completely received by http-response source.

Description:
When using a request sink and responses source, if the response is a long one, sometimes only a part of the response is captured by the responses source.

Resolved, hence closing this issue.


Architecture Support: s390x

As MQ can be deployed on Z systems, I believe useful functionality for mq-ansible would be
to install MQ on s390x-based systems.

I currently do not have permission to assign myself to this issue. However, I will be opening a PR for this work later today.


Teacher Features modal is missing link to teacher forum

When Lisa first showed the teacher features modal last week, there was a link to our talkphysics teacher forum.
This link isn't present in the live version and there is IMHO no other sensible place to have this link.
Not sure if this is an oversight or a policy decision. Either way, I think the forum link is really important and would best be placed here.

Closed in 2dbfefeb828edac76cac5058352c1cb3efe48d4e


aead/subtle: change bazel visibility to public

Copied from https://github.com/google/tink/pull/718:
Hey.
Thanks for the nice library!
We want to use aead/subtle in a project that is built with Bazel. However, aead/subtle's default visibilty stops us from doing that. I understand the docs in a way that suggests using subtle pkgs is intended use; keeping in mind that extra care is required. Thus, add public visibility on the Bazel level, just like kwp/subtle does it.
Cheers.

Thanks for this PR, this LGTM. Could you please sync to main before I go ahead and merge it?

This was done in https://github.com/tink-crypto/tink-go/commit/b0b39f1d46298e5e4203321f11cff166042aff1a


update deps

Scylla v0.14 and all of the others
Added new dev dependency for running all the tests that were starting with "truncate table" serially instead of in parallel ( i got some errors until i figured out to run with --test-thread=1 )

ok
bumped workspace version 0.2.0, there are breaking changes:

select_paged has different argument type
the "Cursor" pub typedef was not used anymore

@gabriel-v LGTM, do you know why this error occurs on the CI? https://github.com/Jasperav/Catalytic/actions/runs/11437836428/job/31829718889?pr=48. If the CI is ok, I will publish the new version!

here you go
https://github.com/gabriel-v/Catalytic/actions/runs/11445259484
errors in order:

cargo lock version = 4 was from my local nightly compiler, when switched to stable, it now outputs version = 3
muted some clippy errors about comment string formatting, unrelated to patch
muted clippy error on dead code (Field::attribute, undocumented, for macro?) - plz review
removed "... and type is not null" from materialized view example - this errors (as type is not PK) in scylla >5.4.X, 6.x but not scylla 5.2.X nor cassandra 3.11
updated CI compiler toolchain to the newer one i had locally, since the compiler error text tests depend closely on compiler version (different structs implementing missing trait get printed)

Thanks a lot @gabriel-v, I published the changes!


Rename rawValueBone to just rawBone

We have a stringBone, a relationalBone, a fileBone... and now a rawValueBone? Why isn't this just be called rawBone, to comply with the already existing naming convention?  Or, let's rename stringBone, relationalBone, fileBone ... into stringValueBone, relationalValueBone and fileValueBone...
The type should be changed to "raw" instread of "rawvalue" as well.

Same here, the window for non-necessary breaking changes for ViUR3 is closed as it has landed in production. As this is a new feature and im not aware of it being used yet we might make an exception here if everybody is very unhappy with this, otherwise i'd keep it. (In my opinion that name is fine, if you see a stringBone or colorBone you know whats inside, that's not such descriptive with "raw") @XeoN-GHMB @AchimSchumacher @skoegl @sveneberth ?


[Held on 356685] [$500] Remove the #admins room when it doesn't create unique value to the admin

Problem: When a paid workspace is created, we automatically create and show the #admins room in the LHN. This makes sense today because we intro the Guide through this room. But with Stage 2 onboarding we will start doing that in the Expensify DM. Most of these workspaces only have one admin, so there is nothing for that single admin to do in the #admins room till there is either (1) another admin (2) there is a policy audit log to review. This means there is a room, largely useless, crowding the LHN at a time where we want the admin to focus on onboarding (in the Expensify DM)
Solution: Don't show the #admins room in the LHN till there is (1) another admin (2) there is a policy audit log to review.
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f092fdaad337d237
Upwork Job ID:<PHONE_NUMBER>851234304
Last Price Increase: 2024-02-09

The #announce room will not be shown till there are 3+ members. That change is being worked on https://github.com/Expensify/App/issues/34929

We can start working on this, but hold the PR till https://github.com/Expensify/Expensify/issues/356685 is fully implemented.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Don't show the #admins room in the LHN till there is (1) another admin (2) there is a policy audit log to review.
What is the root cause of that problem?
This is an improvement
What changes do you think we should make in order to solve the problem?
Here, we decide if a report must be part of the option list in LHN. And, here, we decide if a report can be accessed. To implement this improvement, we can prevent access to the report if it is an #admin room with only one participant (i.e. only one admin) and if there are no more policy audit logs. We can make the following changes within canAccessReport here
// We hide #admin rooms when a) Only one participant is there and b) No Visible Action is present
if (isAdminRoom(report) && (report?.participantAccountIDs ?? []).length === 1) {
    const lastVisibleAction = ReportActionsUtils.getLastVisibleAction(report?.reportID ?? '');
    if(ReportActionsUtils.isCreatedAction(lastVisibleAction)) {
       return false;
    }
}

What alternative solutions did you explore? (Optional)

There is a related change for #announce room that @allroundexperts is working on, so I am going to assign this one to him as well.

@anmurali in https #34929, we're planning not to create the announce room until the workspace has 3 members, do we want the same behavior here? The issue description here suggests we'd still create it but just not show it in the LHN, which is different? Was that on purpose?

Proposal
Updated.
If we are creating #admin room report in BE, then we can remove the #admin creation here in FE.
I have updated the proposal accordingly.

we're planning not to create the announce room until the workspace has 3 members, do we want the same behavior here? The issue description here suggests we'd still create it but just not show it in the LHN, which is different? Was that on purpose?

That’s interesting. While there is similarity between #admin and #announce rooms, I can also think of differences between them like:

When there are two admins, I am not sure if admins would want to carry out admin activity over 1:1 DM. Would a dedicated #admin room seem ideal here?
Even if there is only one admin, there may be policy audit logs that can get generated. It such cases, we might want to show them in #admin room.

If we do this in BE that would solve the problem whereas in FE we need to prevent creation of #admin room. Otherwise, I think the alternative approach is for FE to show/hide in LHN accordingly.

@francoisl - let's piggy back on the logic we followed for # announce room!

I think they are different, right? If we don't create the #admins room on workspace creation, and the lead goes to the Expensify DM and wants to talk to the guide, there would be no #admins room unless they've added three members to the workspace? 😕

But we don't assign a guide on Free workspaces created from NewDot at the moment, as far as I can tell. Or are you thinking about a post wave-5 world without Free workspaces anymore?

Right, we're going to stop creating new free workspaces soon, before we kill existing free workspaces.

Been tied up with other issues, getting back to this tomorrow!

👋 Can someone confirm the hold on this one?

For now we're prioritizing building the phase 1 functionality for Guided Setup Stage 2.

Almost done with implementation of the core logic for Phase 1 and Phase 2, will get back to this after it's done.

Phase 2 got somewhat put on hold for a bit to help with site stability issues. Should be able to resume on this shortly I hope.

Still delayed with remaining phase 2 implementation tasks and other priorities.

Given that there's a fair amount of code in the backend that relies on the #admins room existing, I think it's best to keep creating it when we create the workspace and, and instead just no longer pin it and show it in the LHN.
For now I'll update the backend to no longer pin the room when we create it, and then we can update the client with some variation of @rojiphil's proposal above.

The backend changes to no longer pin the admins room are now live, @rojiphil do you want to revisit your proposal?
I think we'll need to change report?.participantAccountIDs ?? []).length === 1 from the proposal, because we also invite a guide to the admins room. We can probably just filter out values from the participants list that match PolicyUtils.isExpensifyTeam(), and then see if there's only 1 value left.

The backend changes to no longer pin the admins room are now live, @rojiphil do you want to revisit your https://github.com/Expensify/App/issues/36236#issuecomment-1937096535?

@francoisl I have updated the proposal to ignore expensify team members in determining the number of participants in #admin reports. Please assign me here so that I can raise a PR for this.

@rojiphil when can we expect a PR?

Still working on this. Expected to be ready for review tomorrow my day.

@allroundexperts PR is ready for review.

@rojiphil let me know once you've accepted the Upwork offer.
@allroundexperts do you think we should create a regression test for this one? I think it could be helpful.

let me know once you've accepted the Upwork offer.

@sakluger Accepted the offer. Thanks.

Thanks @rojiphil, all paid.

Regression test

Sign-in using a new account
When the onboarding modal is displayed, select Manage my Team’s expenses and complete the onboarding steps.
Verify that the LHN does not show #admins room
Go to Account Settings—>Workspaces—>3DotMenu
Select the Menu Option Go to #admins room
Verify that the #admins report is shown and the LHN displays the #admins report
Navigate to any other report.
Verify that the #admins report is not shown in LHN
Follow steps 4,5 and navigate back to #admins room
Leave a comment in #admins room and navigate to any other report.
Verify that the #admins report remains shown and does not hide anymore.

Do we 👍 or 👎 ?

$500 approved for @allroundexperts


Remove the develop branch references from the contribution guide

The contributing guide referenced a "develop" which we do not use.

@settermjd Is the change fine for you?

Looks good to me mate.


New Keylogger chars like ^ or ` not working

To reproduce this issue run the client with keylogger enabled and press ^ (under Escape).

~~
++=_-)0(9*8&7^6%5$4#3@2!1~~
the above is what i wrote to test the keylogger and it seems to work for me :D

This is working for me as well.  What kind of keyboard do you have?  Under my escape key is the tilde key (OemTilde)

@MaxXor, took a look here: http://clasfaculty.ucdenver.edu/tphillips/GermanKeyboardLayout.html
"The characters ² ³ { [ ] } \ @ € µ ~ are accessed by holding the Alt Gr key and tapping the other key.
The Alt key on the left will not access these additional characters.

Tap on an accent key once, let up, then tap on a vowel to produce accented characters. (ô á ù etc.)
Note that the semi-colon and colon are accessed by holding down the shift key (large arrow up)."

Because these are dead keys, they won't be processed.  Take a peek at the method at line 73 ('xClient.Core.Keyloggers.WinApi.KeyboardNativeMethods')

why should i use the last commit !!
the keylogger already works fine for me
but github doesn't show ' ~ when there are no spaces between them, instead it shows them like that '~
so every key i have pressed is logged correctly @d3agle

@DragonzMaster , haha sorry!

no problem bro
I hope you find a fix for @MaxXor problem

lol yea I press ^ once and then again to show it, works fine without the keylogger. :(

@MaxXor , When you say it works fine without the keylogger, do you mean that with the keylogger enabled and the client running, your ^ key doesn't function as it would without the keylogger enabled?

Correct.

Oh boy.  I will look into this, that doesn't sound good

@MaxXor , could you try something for me?  I don't have a german keyboard to test this on, but I wonder if the dead key has a state that is being reset the first time you press it.  I noticed that sometimes when starting the client with keylogger enabled, keys would be reset if they were already enabled.  For example, if I had Numlock toggled off prior to starting the client, when I pressed Numlock to turn it on, it would turn it off as soon as i pressed and released it.  I have a feeling this could be due to clearing the keyboard buffer in https://github.com/MaxXor/xRAT/blob/dev/Client/Core/Keylogger/WinApi/KeyboardNativeMethods.cs#L85.
  For example, Try accenting some characters a few times and see what it outputs.

I did what you said, but it didn't work. I'll try removing this line and see what happens. :D

Thanks!  I just realized, someone recently raised this issue with the programmer who wrote this library, and he claims to have fixed it.  I wonder if the problem is with our logic?
https://github.com/gmamaladze/globalmousekeyhook/issues/4

Thanks, I've read it. Urutar also said it's not gone yet. :D Let's see if he can fix it!

Sent a pull request with some fixes, along with a possible dead-key fix. #186, needs to be tested!

Tested on Windows 8 VM with success!


Revamping documentation + fixing a few problems in notebooks.

Updated all docs to linen (unless I missed something), changed the structure of the website a bit and reflected changes in README.md

Codecov Report

Merging #603 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #603   +/-   ##
=======================================
  Coverage   80.44%   80.44%
=======================================
  Files          55       55
  Lines        4199     4199
=======================================
  Hits         3378     3378
  Misses        821      821

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8befd4...84871e7. Read the comment docs.

This is a huge improvement, thanks!


shard-aware implementation.

Hi Lg,
Thank you for this amazing driver,
recently am working on modified elixir driver on top of GenStage, now looking to add the shard-aware feature to the driver, but I need a little help to figure out the right way to implement it.
https://github.com/scylladb/scylla/blob/master/docs/protocol-extensions.md
as you know Scylla is shared nothing model, which fit perfectly into erlang/elixir world
The goal of shard-aware is to have one connection per shard(core), this way we can send queries directly to the core which will process it( this will save cpu cycles and IPC bandwidth).
imagine this flow :  lookup(token) gives -> GenStage producers ( producers number for a given token depends on the replication factor) -> The producer/s process it and pass it as batch query to consumer/s who will send to the socket(which will process it right away as the full batch belong to this logical core).
Can we discuss this pls ?
Thank you

Hi @LuaiKamel, I wasn't aware the extension was published yet. I'll have a look at how I think we should implement this and I'll get back to you.
Cheers,
LP

Hi LP, Thank you for your quick response, I'm really excited and looking forward to work with you regarding this implementation.
I did notice that you are planning to do ring rebuild in your TODO list , I was thinking of this as well :
1 - one active connection with registered events [supervised genserver]
2 - recompiling the ring module to rebuild it self as soon as the active connection recv an event.
Cheers,
Lk

@lpgauth Here is the function I implemented in elixir, will do more tests to make sure everything work fine.
  def lookup_shard(token, nr_shards, ignore_msg) do     biased_token = token +  (1 <<< 63)     biased_token = biased_token <<< ignore_msg     tokl = biased_token &&& 0xffffffff     tokh = (biased_token >>> 32) &&& 0xffffffff     mul1 = tokl * nr_shards     mul2 = tokh * nr_shards     sum = (mul1 >>> 32) + mul2     sum >>> 32   end

One comment on this: @lpgauth this would be quite beneficial for your deployment. We already published the official spec on this, and this is available in scylla-enterprise-2018.1.5 and above and scylla-2.3.0 and above.
Let me know if there is anything I can do to help this being implemented.

I implemented everything and going to open source it in near future. I would be happy to help as well.


[crash/fuzzing] Resources exhaustion (CPU/MEM) using wasmprinter::print_bytes()

During fuzzing of wasmprinter, I trigger a resources exhaustion bug leading to full CPU usage when parsing a crafted wasm module. The file is only 650 bytes in size.
Download: huge_cpu_usage_wasmprinter.zip
Repo:
use std::env;
use std::fs::File;
use std::io;
use std::io::Read;

/// Read the contents from file path
fn read_contents_from_path(path_str: &String) -> Result<Vec<u8>, io::Error> {
    let mut buffer: Vec<u8> = Vec::new();
    let file_path = std::path::PathBuf::from(path_str);

    println!("file_to_process: {:?}", file_path);

    let mut file = File::open(file_path)?;
    file.read_to_end(&mut buffer)?;
    drop(file);
    Ok(buffer)
}

fn main() {
    println!("Start debugging of wasmprinter_parser");
    let args: Vec<String> = env::args().collect();

    // verify file_to_process is provided
    if args.len() != 2 {
        println!("Usage: wasmprinter_parser <file_to_process>\n");
        return;
    }

    // read data from provided file
    let data = read_contents_from_path(&args[1]).expect("cannot read file content");

    // call the fuzzing target
    wasmprinter::print_bytes(&data).is_ok();

    println!("No crash, everything is OK\n");
}

Here is another one that trigger an error this time:
memory allocation of<PHONE_NUMBER> bytes failed[1]    12638 abort (core dumped)

Download: mem_alloc_failed_wasmprinter.zip

Thanks for the report! Turns out those are both the same issue, fixed by #53.


[RelatedIdents] Fix an assertion failure if two invalid declarations have the same base name

We need to check both the USR and the display name because multiple distinct decls might have the same USR. For example, the following declarations have the same USR with a single ERROR_TYPE parameter despite being distinct declarations.
func bar(body: Invalid) {}
func bar(ignoreCase: Bool, body: Invalid) {}

The display name contains the argument labels, which is sufficient to distinguish these declarations.
rdar://126803702

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test


Problem with Ultrasonic sensor

When I run Ultrasonic_client in Pi, The RC car can't move because it has an obstacle in front, How Can I fix it?

Did u connect the trig and echo pins correctly to the pin number in the
program??
On Tue 3 Apr, 2018, 1:32 AM marcusvn<EMAIL_ADDRESS>wrote:

When I run Ultrasonic_client in Pi, The RC car can't move because it has
an obstacle in front, How Can I fix it?
[image: image]
https://user-images.githubusercontent.com/35937697/38213449-61fe7438-36eb-11e8-951a-892f2d144727.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hamuchiwa/AutoRCCar/issues/91, or mute the thread
https://github.com/notifications/unsubscribe-auth/AgOJunp0SieLGR0YyhMmnjJlJhoOQ6Ctks5tkoPHgaJpZM4TEAdX
.

Did u check if your ultrasonic sensor is working with simple program??
On Tue 3 Apr, 2018, 11:54 AM marcusvn<EMAIL_ADDRESS>wrote:

Yes already bro
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/hamuchiwa/AutoRCCar/issues/91#issuecomment-378141451,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AgOJuuWXfDIDigL6vpUuXXkCWOIR4uDSks5tkxWHgaJpZM4TEAdX
.

When I use ultrasonic sensor test, I think it working but when I run rc_driver it already "Stop, obstacle in front"

@marcusvn There is a threshold set to 30, from your picture the measurement is 9, anything blocking the ultrasonic sensor?

What is the blocking ultrasonic sensor? I do not understand?

Did u change anything in the code???
On Tue 3 Apr, 2018, 6:56 PM marcusvn<EMAIL_ADDRESS>wrote:

What is the blocking ultrasonic sensor? I do not understand?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/hamuchiwa/AutoRCCar/issues/91#issuecomment-378249120,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AgOJusNuU3lpTXfYhn380f57pq7Q-CCqks5tk3hygaJpZM4TEAdX
.

No I don't change anything in code!

@hamuchiwa  Did you connect Ultrasonic sensor direct with Raspberry Pi ?

When I run for test Ultrasonic Sensor I had limited distance ?

PlZ @marcusvn help me with your connection pics of ultrasonic sensor with respberry pi


Fix STL10 repr

Fixes https://github.com/pytorch/vision/issues/968

Codecov Report

Merging #969 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #969   +/-   ##
=======================================
  Coverage   60.03%   60.03%
=======================================
  Files          64       64
  Lines        5054     5054
  Branches      754      754
=======================================
  Hits         3034     3034
  Misses       1817     1817
  Partials      203      203

Impacted Files
Coverage Δ

torchvision/datasets/stl10.py
29.85% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b3a1b6...b6464ed. Read the comment docs.


Fix looping forever at 100% CPU if socket is closed

Can you please provide a more elaborate explanation (ideally with an example use case) to help understand the reason for this change? Thanks.

It's a bugfix.  The logic is wrong.  To reproduce:
sock = XXXServer.new
server = HTTP::Server.new ...
server.bind sock
server.listen

# Appears to work, but CPU spikes to 100% and process never exits
sock.close

I still don't follow. Sorry.
The reproduction doesn't help because it's incomplete. And I don't understand how it should work. server.listen blocks until the server is closed. Since there is no other concurrent code that could close the server, it will never return. So sock.close can't be reached.
I'm very skeptical about an idling HTTP server saturating the CPU. It should just be in waiting when there's nothing to do.

I still don't follow. Sorry.
The reproduction doesn't help because it's incomplete. And I don't understand how it should work. server.listen blocks until the server is closed. Since there is no other concurrent code that could close the server, it will never return. So sock.close can't be reached.
I'm very skeptical about an idling HTTP server saturating the CPU. It should just be in waiting when there's nothing to do.

The example was from memory simplified from my real code and missing a spawn call which is corrected above.
The existing HTTP::Server ignores closed socket status and spins forever if the socket is closed.
Simplified HTTP::Server example:
loop do
  # Normally blocks but immediately return nil if the socket is closed.
  io = begin
    server.accept?
  rescue ex
    handle_error ex
    nil
  end

  if io
    ...spawn and handle request...
  else
    # The current code contains no else handler so... busy loop if closed because accept? returns nil when closed.
    # Also the handle_error path sets sock to nil conflating socket is closed with every other error.  That's fixed too.
  end
end

It seems poor form to ignore a public api's (accept?)  return value when it indicates it can't continue.  Especially bad in a loop.

I see, yeah it makes sense now. I suppose the culprit is that closed? was expected to return true when the bound socket is closed. But it does not.
The fix looks good overall.
We should probably still check closed? as loop condition to immediately stop accepting new requests. The shutdown procedure iterates through all sockets, closing each one. But closing a socket can block.

Perhaps I was micro optimizing but:

For idle servers the fiber waits on accept?. closed? is never checked (because the socket will return nil and loop ends)
For VERY busy servers with more than one socket closed? may be called, but only when closing which is a rare event compared to the extra conditional branch ofuntil closed?  Is the conditional branch worth it?
Also single responsibility principle.  The accept? check can't be removed without adverse consequences - to me that makes it responsible for continued accepting rather than closed?.

Socket#close can block on open tcp sockets depending on SO_LINGER.  Is the same true for an accepting server socket?  I thought it returned immediately.

Okay, you're probably right, this is fine.

Ping: Will this 3 line fix make it in 1.1.0?


Update to openssl 3.0.12

See also https://github.com/eclipse-openj9/openj9/pull/18338.

@sxa can we get an exception to the freeze. If not, @keithc-ca can you open a dup PR at ibmruntimes?

Is the code freeze over?

code freeze lifted.


Fix bug with slash in query param

Consider only the base url when calculating the route

Closes #28

Coverage increased (+0.3%) to 99.522% when pulling 29a5ed4dcbac40d14712b565516781311dbcd0ba on fix-query-param-bug into 07c0c2a364ab1978a86198630464f1a58a905d15 on master.


Page Up / Down in Recent topics is not working as expected in some cases.

Page Up / Page Down tends to scroll more than it is expected, which results in the user missing a topic entirely.
This was reported by @cyphase :
While paging through the Recent Topics view, I noticed that the Page Up / Page Down buttons were causing me to miss a topic each time. It may not be 100% missed 100% of the time – there are instances where you can see the very top of the topic row for instance – but mostly.
For example, if I'm at the top of the view, and the bottom-most visible topic is "zulip in the clouds", when I page down I might see that "zulip in space" is now the top-most topic. But if I then scroll back up a bit, I'll see that between those two topics is "interdimensional zulip", which was paged over.
This is Firefox on Linux, in case that becomes relevant.
Also – and this certainly might be a separate issue – I find that I am sometimes not able to start paging down right away when switching to the Recent Topics view. It seems that the scroll area doesn't have focus. I haven't been able to figure out a reliable reproducer for this yet.
Possibly direction for debugging:
So it turns out, unsurprisingly, that the issue here is that the compose bar is hiding that "skipped" topic. If I remove the compose bar via the browser inspector, paging seems to work very correctly. And even without removing it, the symptoms are consistent with that being the case.
Discussion: https://chat.zulip.org/#narrow/stream/9-issues/topic/recent.20topics.20page.20up.2Fdown

Adding a release goal tag since this is a bug that makes the app look somewhat broken, and may not be super deep.

Should we consider this a lower priority than @amanagr 's other release goal issues?


【Dynamic Regions】after apply new region split config，QPS fluctuates regularly

Bug Report

What version of TiKV are you using?
./tikv-server -V
TiKV
Release Version: 6.0.0-alpha
Edition: Community
Git Commit Hash: https://github.com/tikv/tikv/commit/95c4d0ed36369c254b1bee36eb007004ee834948
Git Commit Branch: heads/refs/tags/v6.1.0-nightly
UTC Build Time: 2022-04-21 10:58:55
Rust Version: rustc 1.60.0-nightly (1e12aef3f 2022-02-13)
Enable Features: jemalloc mem-profiling portable sse test-engines-rocksdb cloud-aws cloud-gcp cloud-azure
Profile: dist_release
2022-04-24T10:07:55.070+0800 INFO k8s/client.go:107 it should be noted that a long-running command will not be interrupted even the use case has ended. For more information, please refer to https://github.com/pingcap/test-infra/discussions/129
./pd-server -V
Release Version: v6.1.0-alpha-40-g1d8eba0
Edition: Community
Git Commit Hash: https://github.com/tikv/pd/commit/1d8eba08d9907ef1a6fdebd1ebf6b218b9338d91
Git Branch: feature/region_monitor
UTC Build Time: 2022-04-22 12:21:42
2022-04-24T10:07:55.245+0800 INFO k8s/client.go:107 it should be noted that a long-running command will not be interrupted even the use case has ended. For more information, please refer to https://github.com/pingcap/test-infra/discussions/129
./tidb-server -V
Release Version: v6.1.0-nightly
Edition: Community
Git Commit Hash: 571d97bb16f6f69fcbcf74648380da3c2e80a3fb
Git Branch: heads/refs/tags/v6.1.0-nightly
UTC Build Time: 2022-04-20 23:02:41
GoVersion: go1.18
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
2022-04-24T10:07:55.385+0800 INFO k8s/client.go:107 it should be noted that a long-running command will not be interrupted even the use case has ended. For more information, please refer to https://github.com/pingcap/test-infra/discussions/129
What operating system and CPU are you using?
8core、32G
Steps to reproduce
update some config
region-max-keys =<PHONE_NUMBER>00
region-max-size = "1.3GB"
region-split-keys =<PHONE_NUMBER>0
region-split-size = "1GB"
What did you expect?
QPS remains stable
What did happened?

/assign busyjay

/type enhancement


refactor(touchevent) -  improve shadow swiping class check

Previously, we modified the targetEl to ensure element.closest(swipingClass) to always finding the correct element. But it does not work cross browser since event path is different from safari to chrome. This refactor introduce a new method to find the closest matching element with nested shadowRoot, so its now working the same way as the non shadow components.
So swipe action trigger inside shadow-component will be blocked if either <Element> or <Inner-element> contains no swiping class.
<Element class="no-swiping">
<Inner-element class="no-swiping">
<shadow-comp />
     <Inner-element>
</Element>

Hey @weiz18, thanks! But can you give me some minimal live example of what it fixes (where now it will be broken)? Just for better understanding what we are fixing here :)

Sure. will attach a minimal live example when i have some time.  Basically, current implementation of finding the closest target on shadow root only works with one level. So if you have a deep nested dom structure where the no swiping class is on the outer most element, it will fail to find it in the path.
,

Still not sure what is the issue, because right now tested the following:

        <custom-1>
          <custom-2>

Hello world

          </custom-2>
        </custom-1>

And everything works as expected for me in Safari, Chrome and FF. There is no swiping  over this elements

Hey, @nolimits4web  sorry for the late response, was away for a couple of days.  I have attached a demo reproducing the issue. https://jsfiddle.net/qhzwom26/31/ . as you can see in the demo, the child element is still moving despite no-swiping class being set on the parent element.  I think the key here is to set the shadow root mode to open in order to reproduce.  let me know if you need more info.
thanks

Merged, thanks!

nice. thanks a lot


Is this gem thread-safe?

Hi,
I was interested in using this gem in my multi-threaded rails application until I ran across this documentation for the underlying librato-metrics ruby client: https://github.com/librato/librato-metrics#thread-safety
Can you provide some clarity on the thread-safety guarantees of this gem?
Thanks!

Yep, this gem and librato-rack are fully threadsafe. Happy to answer any more specific questions if you have them.

Thank you. :

No prob, happy to help. :-)


Setting config from env (e.g. HUGO_PARAMS_MYPARAM) does not overwrite params defined in theme modules

I may be wrong here (because I suspected this to just work).

OK, I tried to create a failing test -- but failed, so I guess my observation wasn't entirely correct. Hmm...


Simplify lookupLedger().

Reviewers: @nbougalis @JoelKatz
Probably replaces #820

It'd be nice to have a log at warning level if walkHashBySeq throws. Also, I'm not sure why the hash of the ledger is called next, but it should probably be called something else -- even hash is better.
:+1:

It'd be nice to get David's comments addressed. With that said, this gets a :+1: from me. I won't mark it as passed. Tom, feel free to do so, unless you wish to address the comments.

I did all the comments.  The ternary was weird, I think it evolved from something else, murdered it too and rebased.

Are we good to go?

Merged as e742da73bd10bb0ada28775ce2c58a02392f9aec