Multi classification on GPU runs fast only the first time

Hello.
It is not an imagination, checked many times in R an Python, latest or one of the latest builds.
Using params like:

multi:softmax, num_class=5, gpu_hist, gradient_based, eta=1.0 (for random forest) trees: 200 and boost rounds 15
only the first run is fast. Trying to run this training even for second time (the same language or other) finishes it MUCH SLOWER,
What is even more weird, the time elapsed for next runs are high for any CPU/GPU. Much better Workstation shows the same or even slower execution compared to my cheap laptop. And!!!! MUCH SLOWER then CPU, for WS it is a special choque.
Three details more:

regression training runs with the same acceleration on GPU as it should. Doesn't matter form R or Python or C-API.
Being persistent (running code many-many times) finally leads to freezes in graphical interface (more then 15 sec before it became responsible again). I continued and everything hanged. Only power button helped.
We used latest Ubuntu and latest Win 10. XGB - 1.5.0 Your night builds and compiled from source code. All the same.

 But even after crashing or getting error messages all we back to normal for the next runs. It means that nVidia drivers are fine.
Checking library I saw cuda context creation, but NONE to destroy it after use.

Need solution ASAP, since we need to tune the model running it with many diff. params. And in such case each second counts.

I am sorry to hear about your trouble. To help us identify the root cause, I will ask you a few questions.
Have you run into this issue in multiple machines? Or is it specific to your workstation? So far I have not run into this issue myself; our testing server runs the XGBoost code multiple times over and it does not freeze.
Please post your training script so that we can run it ourselves and see if the problem occurs on our side. If not, the issue may be with the specific machines you are using (e.g. broken CUDA runtime or drivers).

Hello Philip
Thanks for an immediate answer. Sending you the code (Python for sake of compatibility) and data in zip.
Once more: GPU is engaged.
About run times (for you - to estimate the ratio). First Run: 35 sec, fastest of the next runs: 56.2 sec.
Switching to uniform and hist (core i5 - 4 cores + 4 hyperthreds) gives 14.5-15.5 sec
We are using Random Forest and boosted Random Forest params suggested in your docs.
VERY strange, since in other tests with reg:xxx models GPU calculations are much faster than CPU.
On Saturday, May 22, 2021, 1:25:39 AM GMT-5, Philip Hyunsu Cho @.***> wrote:
I am sorry to hear about your trouble. To help us identify the root cause, I will ask you a few questions.
Have you run into this issue in multiple machines? Or is it specific to your workstation? So far I have not run into this issue myself; our testing server runs the XGBoost code multiple times over and it does not freeze.
Please post your training script so that we can run it ourselves and see if the problem occurs on our side. If not, the issue may be with the specific machines you are using (e.g. broken CUDA runtime or drivers).
Speeds are the same in R and Python. And consistent for my laptop (i5, 10th gen, simple MX330 2Gb GDDR5) or workstation (do not have all specs on hands, but one of the latest Ryzen 7 and RTX2080). So, WS has the same time as my laptop for GPU!!!???
Dying from a desire to hear what happens.
And, I'd really appreciate if you will provide to me EXACT indications how to use in Python xgboost which I compiled locally (not through pip for stable build or nightly builds). Want to see what happens in this case. Please!!!!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

xg-test.zip
Sending it here

Hello to the developers team.
Were you able to execute an example code several times, looking at how it works, including GPU/CPU?
For the moment is you could confirm the case - will be very important.
I just hope that it is really the issue when resources were allocated, context created but due to changes in trees some of them are not de-allocated where it should.
But also the presence of context creation - and no destruction in compiled library is worrying me.

I'm looking into them today.  Thanks for the patience.

Running it in a bash loop.  Will update the progress once it's finished.

Ran it 32 times with Python loop on CUDA 11, so far I haven't been able to reproduce it. Log and modified code are attached below.  The code changes are:

"hist" -> "gpu_hist"
Added for loop.

#!/usr/bin/env python
# coding: utf-8

# In[29]:
import pandas as pd
import numpy as np

# from collections import Counter
import os
import xgboost as xgb
from sklearn.metrics import accuracy_score
from sklearn.model_selection import train_test_split
import time

# from ray import tune

dfs = pd.read_excel("input.xlsx", sheet_name="Sheet1", engine="openpyxl")

# In[188]:
X = dfs[
    [
        "f01",
        "f02",
        "f03",
        "f04",
        "f05",
        "f06",
        "f07",
        "f08",
        "f09",
        "f10",
        "f11",
        "f12",
        "f13",
    ]
]
y = dfs[["class"]]
Xtrain, Xtest, y_trv, y_tsv = train_test_split(X, y, test_size=0.25)
ytrv = np.array(y_trv)
for i in range(len(ytrv)):
    if ytrv[i] < 0:
        ytrv[i] = ytrv[i] + 2
    else:
        ytrv[i] = ytrv[i] + 1
ytsv = np.array(y_tsv)
for i in range(len(ytsv)):
    if ytsv[i] < 0:
        ytsv[i] = ytsv[i] + 2
    else:
        ytsv[i] = ytsv[i] + 1

# print(y_test['class'].values)
# print(Xtest.values)
dtrain = xgb.DMatrix(Xtrain.values, label=(ytrv))
dtest = xgb.DMatrix(Xtest.values, label=(ytsv))

# set xgboost params
param = {
    "eval_metric": "auc",
    "sampling_method": "uniform",  # or 'gradient_based', or 'uniform'
    "tree_method": "gpu_hist",  # or gpu_hist
    "colsample_bynode": 0.85,
    "subsample": 0.9,
    "nthread": 4,
    "min_child_weight": 3,
    "max_depth": 3,  # the maximum depth of each tree
    "eta": 1.0,  # the training step for each iteration
    "max_bin": 16,
    "num_parallel_tree": 200,
    "objective": "multi:softmax",  # error evaluation for multiclass training -
    "num_class": 5,
}  # the number of classes that exist in this datset

# num_round = 20  # the number of training iterations
# training and testing - numpy matrices

for i in range(32):
    t = time.process_time()
    bst = xgb.train(param, dtrain, num_boost_round=15)
    print(time.process_time() - t)

    preds = bst.predict(dtest)

    # evaluate predictions
    predictions = [round(value) for value in preds]
    accuracy = accuracy_score(ytsv, predictions)
    print("Accuracy: %.5f%%" % (accuracy * 100.0))

9.535810864
Accuracy: 67.14197%
9.145630353
Accuracy: 67.14197%
9.193478827
Accuracy: 67.14197%
9.127465213
Accuracy: 67.14197%
9.164171840999998
Accuracy: 67.14197%
9.176722685999998
Accuracy: 67.14197%
9.152670914000005
Accuracy: 67.14197%
9.147816884999997
Accuracy: 67.14197%
9.15949061900001
Accuracy: 67.14197%
9.164212014
Accuracy: 67.14197%
9.173735972000003
Accuracy: 67.14197%
9.201629443000002
Accuracy: 67.14197%
9.187759968000009
Accuracy: 67.14197%
9.144264339999992
Accuracy: 67.14197%
9.213034332000007
Accuracy: 67.14197%
9.146277424000004
Accuracy: 67.14197%
9.188005726
Accuracy: 67.14197%
9.221451680000001
Accuracy: 67.14197%
9.157122442999992
Accuracy: 67.14197%
9.131143097000006
Accuracy: 67.14197%
9.165762540999992
Accuracy: 67.14197%
9.147889808000002
Accuracy: 67.14197%
9.138431462
Accuracy: 67.14197%
9.151869046000002
Accuracy: 67.14197%
9.16471638600001
Accuracy: 67.14197%
9.137945572000007
Accuracy: 67.14197%
9.14844348699998
Accuracy: 67.14197%
9.154025891000003
Accuracy: 67.14197%
9.124639075000005
Accuracy: 67.14197%
9.136131904000024
Accuracy: 67.14197%
9.239540196000007
Accuracy: 67.14197%
9.260099731000025
Accuracy: 67.14197%

First thing to ask. Do you have nVidia GPU? If yes, which driver you are using?
Second thing: can you share the xgb build which you are using?
I want to check both things, since your machine definitely uses GPU correctly.

BTW.
Try, pls to use 'gradient_based' or explain me well why I should not use it?

First thing to ask. Do you have nVidia GPU? If yes, which driver you are using?

Yes.  Ubuntu 20.04 with driver 460.73.01.  Also:
$ nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2020 NVIDIA Corporation
Built on Wed_Jul_22_19:09:09_PDT_2020
Cuda compilation tools, release 11.0, V11.0.221
Build cuda_11.0_bu.TC445_37.28845127_0

Second thing: can you share the xgb build which you are using?

The commit I used 7e846bb9652bb263414a49257fc6b9327ef848d3  since you mentioned you have compiled from source without listing the commit you are using.  I can try other commits too if you have specific one in mind.

Try, pls to use 'gradient_based' or explain me well why I should not use it?

Just trying to run your script with minimum amount of changes, changed to gradient and running, right now the result looks pretty normal.
11.597548842999998
Accuracy: 68.00992%
11.407566096
Accuracy: 68.00992%
11.357898647999999
Accuracy: 68.00992%
11.376000288
Accuracy: 68.00992%
11.482708076000002
Accuracy: 68.00992%
11.413722822000004
Accuracy: 68.00992%
11.449749834000002
Accuracy: 68.00992%
11.433931326000007
Accuracy: 68.00992%
11.491348352999992
Accuracy: 68.00992%
11.474730394000005
Accuracy: 68.00992%
11.465334377999994
Accuracy: 68.00992%
11.446381126999995
Accuracy: 68.00992%

Important!
The same driver.
Made 2 things:

Pushed GPU from auto mode to performance mode always
Installed the latest night build for python
Executed under python 3: stable times, quite fast for my weak GPU
Tried python 2: stable times, but nearly 2 times slower... and a bit lower accuracy (1%) for the same code and conditions.
Thus, started under python3 again. And guess what: execution times like for python 2!
So, to avoid thermal issues of laptop video card left it w/o any actions, to cool down a chip.

Slow!
Closed terminal window and started it again in other one, with python3
Slow!
Log off - OS GUI crashed! Text terminal, reboot
Computer restarted, the check in python3.
Normal speed!

Any ideas?

It appears that the issue is specific to your machine. Consider renting GPU-enabled machines from cloud services, such as Amazon EC2.

Jupiter uses Python 3 by default, so you never saw the issue.
I will use xbg under Python 3 only. But the issue is detected, so I highly recommend inserting the check for Python version, blocking GPU!!! under Python2

XGBoost actually never supports Python 2. pip install xgboost will fail if you use Python 2.

I'm not entirely sure how you run xgboost under py2, there should be a lots of syntax errors ..
I will add the check, thanks for the suggestion!

I mean  and  as a command. p3 - fine, just p - problems


Support escape sequences in vi-ins-mode-string & vi-cmd-mode-string

Thanks for this great library! It appears at present escape sequences are not supported for vi-ins-mode-string & vi-cmd-mode-string. I tried setting the following:
set editing-mode vi
# enable mode strings in prompt
set show-mode-in-prompt on
# vi-insert mode use a bar cursor
set vi-ins-mode-string \1\e[6 q\2
# vi-command use a block cursor
set vi-cmd-mode-string \1\e[2 q\2

But the result was the literal escape sequence in my prompt:
example [main] in src/console/example
\e[6>

I found this while trying to use my bash-rsi repo with this library.

Hello, glad to hear you enjoy it !
So the problem might lie in the formatLastPrompt() function down in the internal/ui/prompt.go file.
I use an already escaped "\1" and "\2" strings to match, so maybe there is a redundant backslash in the backticked strings.
I'll try to fix this by the end of the week.
In the meantime, did you see that you can set the cursor style through inputrc options ?
You can use cursor-vi-insert, cursor-emacs, etc. Maybe it does not fit your use case though...
See https://github.com/reeflective/readline/wiki/Options#options and look the cursor-<keymap-name> option.
Ping me if needed.

Thanks @maxlandon I did see the cursor options, but I was initially hoping to keep my config the same between bash and this library. Maybe Chet Ramey would be interested in adding them to readline! I was able to match the functionality I had with vi-ins-mode-string & vi-cmd-mode-string using the following config and the sample console app:
$if example
set cursor-vi-insert beam
set cursor-vi beam
set cursor-vi-command block
set cursor-vi-move block
set cursor-vi-visual block
set cursor-vi-opp block
$endif

Okay there is one important thing I had forgot and which makes your request unsatisfiable here...
So basically if you go into the code, you will see that the cursor is reprinted many many times (not only when the insertion mode changes, but also on redisplays), and so any cursor sequence you might include in the prompt string will actually have no effect...
As for the current configuration snippet: it's taste and colors so do as you please, but I would probably advise against changing the cursor-vi-opp value, since it's very useful to know when you are in the middle of a command (most of the time, as you know, you are happy of knowing where you are at in your sequence because you have accidentally typed the wrong key)... but hey, just my two cents...
Original readline: I had to briefly check the code when writing this library, however I have no idea how complicated it would be to include those in the original C lib. Try your luck !
Keeping this open for some time, in case any of us (or someone else) has an idea on how to solve this better. Unfortunately it seems unlikely to me...

Setting vi-ins-mode-string & vi-cmd-mode-string is pretty effective at changing the cursor in GNU readline, at least for my use case. I think your implementation is more robust, but it would be nice to stay compatible with GNU readline. I stole my config originally from this stackoverflow post.

Update on this:
I tried again to make the behavior with escape sequences in prompt to be compatible with the legacy GNU C readline code.
Currently there is a bug in parsing .inputrc values that include non-escaped spaces.
I'm waiting for the person who wrote the inputrc package to fix this, as I'm not very very familiar with the parsing logic inside.
After this is solved, the behavior should be consistent and this issue solved.

@maxlandon awesome, thanks for the update

Fixed in #59 , prompt escapes work correctly based on my tests !


Style guide fixit day updates [WIP]

Closes #3248
Style guide FixitDay updates:

Change H2+ to sentence case
Add {% include copy-clipboard.html %} where necessary
Fix formatting broken by the copy-to-clipboard widget
Other minor style updates.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/2fc5c1a6a810eb6e5cafb6a894fe44e9841b28a5/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/cc53f6d05a984eef916b9ff09506534aca9b568b/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/fc46fcad4a4b70a4b300c077ab7be66a53668281/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/c706ad0fdb1f772da7d1d989025e2ed419ac2ff1/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/20dcd5433defb7b0be2514e709d8a42e26ca4287/

Review status: 0 of 49 files reviewed at latest revision, all discussions resolved, all commit checks successful.

v2.1/column-families.md, line 27 at r2 (raw file):

For example, let's say we want to create a table to store an immutable blob of data (`data BYTES`) with a last accessed timestamp (`last_accessed TIMESTAMP`). Because we know that the blob of data will never get updated, we use the `FAMILY` keyword to break it into a separate column family:

{% include copy-clipboard.html %}

I think you need to add backslashes at the end of each code block line in order for somebody to copy/paste correctly

v2.1/commit-transaction.md, line 38 at r2 (raw file):

{% include copy-clipboard.html %}
~~~ sql

I think this need to be split into a code block for each command

v2.1/create-security-certificates.md, line 46 at r2 (raw file):

`node.crt`   | Server certificate
`node.key`   | Key for server certificate
`client.<user>.crt` | Client certificate for `<user>` (for example: `client.root.crt` for user `root`)

Suggestion: use "i.e.," instead of "for example"

v2.1/create-view.md, line 56 at r2 (raw file):

{% include copy-clipboard.html %}
~~~ sql

Needs backslashes at the end of each line (I'll add this to the Style Guide)

v2.1/debug-zip.md, line 32 at r2 (raw file):

- If you experience severe or difficult-to-reproduce issues with your cluster, Cockroach Labs might ask you to send us your cluster's debugging information using `cockroach debug zip`.

{{site.data.alerts.callout_danger}}The file produced by cockroach debug zip can contain highly sensitive, unanonymized information, such as usernames, passwords, and your table's data. You should share this data only with Cockroach Labs developers and only after determining the most secure method of delivery.{{site.data.alerts.end}}

Callouts can be written in Markdown if you move the liquid tags to their own lines

v2.1/delete.md, line 100 at r2 (raw file):

As you can see, one difference is that `TRUNCATE` does not return the number of rows it deleted.

{{site.data.alerts.callout_info}}The TRUNCATE statement removes all rows from a table by dropping the table and recreating a new table with the same name. This is much more performant than deleting each of the rows. {{site.data.alerts.end}}

Same as above (Although, I don't think this isn't urgent since it renders the same for the user)

v2.1/float.md, line 94 at r2 (raw file):

~~~

## Supported casting & conversion

Change & to "and"

v2.1/inet.md, line 81 at r2 (raw file):

~~~

## Supported casting & conversion

Change & to "and"

v2.1/int.md, line 91 at r2 (raw file):

~~~

## Supported casting & conversion

Change & to "and"

v2.1/interval.md, line 89 at r2 (raw file):

~~~

## Supported casting & conversion

Change & to "and"

v2.1/jsonb.md, line 189 at r2 (raw file):

{% include computed-columns/jsonb.md %}

## Supported casting & conversion

Change & to "and"

v2.1/string.md, line 88 at r2 (raw file):

~~~

## Supported casting & conversion

Change to "and"

v2.1/timestamp.md, line 98 at r2 (raw file):

~~~

## Supported casting & conversion

Change to "and"

v2.1/uuid.md, line 110 at r2 (raw file):

{% include faq/auto-generate-unique-ids_v1.1.html %}

## Supported casting & conversion

Change to "and"

Comments from Reviewable

 , with some minor edits!

Review status: 0 of 49 files reviewed at latest revision, 14 unresolved discussions, all commit checks successful.

Comments from Reviewable

v2.1/column-families.md, line 27 at r2 (raw file):
Previously, lhirata wrote…
I think you need to add backslashes at the end of each code block line in order for somebody to copy/paste correctly

I don't think it's a requirement. I checked in the SQL shell..the copy-to-clipboard function works fine without the backlashes.

Comments from Reviewable

v2.1/float.md, line 94 at r2 (raw file):
Previously, lhirata wrote…
Change & to "and"

Gah! I had one whole commit just for "&" to "and" changes, and it didn't show up  here :cry:

Comments from Reviewable

v2.1/create-security-certificates.md, line 46 at r2 (raw file):
Previously, lhirata wrote…
Suggestion: use "i.e.," instead of "for example"

But it is an example :thinking:

Comments from Reviewable

v2.1/commit-transaction.md, line 38 at r2 (raw file):
Previously, lhirata wrote…
I think this need to be split into a code block for each command

Because it's a transaction, I think it should be one code block

Comments from Reviewable

Review status: 0 of 49 files reviewed at latest revision, 14 unresolved discussions, all commit checks successful.

v2.1/float.md, line 94 at r2 (raw file):
Previously, Amruta-Ranade (Amruta Ranade) wrote…
Gah! I had one whole commit just for "&" to "and" changes, and it didn't show up  here :cry:

Done.

v2.1/inet.md, line 81 at r2 (raw file):
Previously, lhirata wrote…
Change & to "and"

Done.

v2.1/int.md, line 91 at r2 (raw file):
Previously, lhirata wrote…
Change & to "and"

Done.

v2.1/interval.md, line 89 at r2 (raw file):
Previously, lhirata wrote…
Change & to "and"

Done.

v2.1/jsonb.md, line 189 at r2 (raw file):
Previously, lhirata wrote…
Change & to "and"

Done.

v2.1/string.md, line 88 at r2 (raw file):
Previously, lhirata wrote…
Change to "and"

Done.

v2.1/timestamp.md, line 98 at r2 (raw file):
Previously, lhirata wrote…
Change to "and"

Done.

v2.1/uuid.md, line 110 at r2 (raw file):
Previously, lhirata wrote…
Change to "and"

Done.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/be23818bfb72b635a3275fa6f759272c644532e5/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/552c5e8d8c9b2e6e46396af6033bf3034eeac736/

Review status: 0 of 49 files reviewed at latest revision, 14 unresolved discussions, some commit checks failed.

v2.1/create-security-certificates.md, line 46 at r2 (raw file):
Previously, Amruta-Ranade (Amruta Ranade) wrote…
But it is an example :thinking:

Oops, I meant "e.g.," but I suppose that's just a style preference so up to you!

Comments from Reviewable

Review status: 0 of 49 files reviewed at latest revision, 13 unresolved discussions, some commit checks failed.

v2.1/commit-transaction.md, line 38 at r2 (raw file):
Previously, Amruta-Ranade (Amruta Ranade) wrote…
Because it's a transaction, I think it should be one code block

Good point. I think I did that in my PR so I'll update mine back.

Comments from Reviewable

Review status: 0 of 50 files reviewed at latest revision, 13 unresolved discussions, all commit checks successful.

v2.1/commit-transaction.md, line 38 at r2 (raw file):
Previously, lhirata wrote…
Good point. I think I did that in my PR so I'll update mine back.

I think it'd actually be nice to split this into multiple blocks because the user would enter each of these one at a time anyway. As is, it can't be pasted into the sql shell.

v2.1/create-security-certificates.md, line 46 at r2 (raw file):
Previously, lhirata wrote…
Oops, I meant "e.g.," but I suppose that's just a style preference so up to you!

Yeah, we should probably have a documented convention. For this type of "example", where it's not in a sentence, I personally prefer e.g.,. In any case, if you stick with for example, please replace the colon with a comma.

v2.1/create-view.md, line 56 at r2 (raw file):
Previously, lhirata wrote…
Needs backslashes at the end of each line (I'll add this to the Style Guide)

We all clarified that we don't use backslashes in multi-line SQL examples, so this is good as-is.

Comments from Reviewable

v2.1/commit-transaction.md, line 38 at r2 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
I think it'd actually be nice to split this into multiple blocks because the user would enter each of these one at a time anyway. As is, it can't be pasted into the sql shell.

I tried copy-pasting a transaction as a single code block, and it works fine. IMO, it makes sense to have it as a single code block.

Comments from Reviewable

v2.1/create-security-certificates.md, line 46 at r2 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Yeah, we should probably have a documented convention. For this type of "example", where it's not in a sentence, I personally prefer e.g.,. In any case, if you stick with for example, please replace the colon with a comma.

Done.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/27bffe0b5abbe5208b8c753d542ff8d72ccbdf48/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/29eeecbc6715f1cf132d8abed8281a21f54a15e6/


Update thrift clients to use generated code

What changed?

Update thrift clients to use generated code
Create many alias functions in common/types/mapper/thrift to make code generation simpler

Why?
To reduce manual work

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 018d1a10-69f2-4b8f-b023-915a0bf308d6

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 62.682%

Totals

Change from base Build 018d18ff-bc57-475e-bf15-bdd3678589d1:
0.06%

Covered Lines:
91940

Relevant Lines:
146676

💛  - Coveralls


Safari : getAccessToken() always returns false

The token is getting successfully from the server, but getAccessToken() always return false
when I debugging into the method, I see that this._storage -> length = 0
looks like the token didn't saves in the _storage.

OS: MacOs 10.15.5

Browser: Safari

Version 13.1.1
"angular-oauth2-oidc": "10.0.3",

We'll need a way to reproduce this, to be able to reliably help....
(Just as a guess, Safari refuses to give localStorage access in Incognito mode, iirc?)

Hi,
Would be happy to help reproduce if you guide me what information is needed or how to accurately debug.
This happens in normal browsing mode (not Incognito).
Thanks

Thx for asking! A (rather long, but extremely good) post explaining "minimal repro's" by Jon Skeet (okay, it's about Stack Overflow questions, but it also applies to issues) can be super helpful to read if you have the time.
The short of it is that we don't have your context, so you need to help us get there. Preferably with minimal effort to us. A handful of "steps" that one of us could take to see the exact issue you're seeing is what we need.
Two typical ways to do that is:

Creating a StackBlitz example, or a cloneable repository, with as little code as possible/needed
Telling us how to modify the sample project in clear and concise steps

in both cases the end result should be that we can see the error you describe.

when I change the following row:
this.oAuthService.setStorage(sessionStorage);
to:
this.oAuthService.setStorage(localStorage);
the problem solved.
so the problem is with sessionStorage only.
I'm using normal browsing mode, not Incognito.

Hey OP! Please let us know if/when you've had a chance to look at my previous suggestions and were able to help us reproduce the issue, so we could reopen this thread at a time when the rest of us can help out.


Android: why does the feed list redraw when I finish reading a story?

I'm reading a story, hit the Done button, and get taken back to an empty feed list that takes a half second to populate.

This also happens on the story list (feed detail). User talks about it here: https://getsatisfaction.com/newsblur/topics/returning-to-all-stories-always-starts-from-the-beginning-of-the-list-on-android.
Thing is, we used to preserve position. Can you change this so that the view scrolls to where the last selected story is when you go back to the story list from the story detail?

@samuelclay Thanks for articulating what the real issue is much more succinctl than I did!

Fixed in #662 on all devices with sufficient memory.

Can you change this so that the view scrolls to where the last selected story is when you go back to the story list from the story detail?

This was fixed some months ago.  Again, though, the system can throw out the old state if it needs to recover memory.  I just tested this on three devices and the position was maintained on all of them.  If this can be repro'd on a healthy device, please file a new issue (this one is not strictly related).


Wrong Indexes on Referenced Documents

I noticed that doctrine creates indexes for referenced documents in a way not effective.
for example, I have a document like that
<?php

class User {

    /**
     * @MongoDB\Id
     */
    protected   $id;

    /**
     * @MongoDB\ReferenceMany(targetDocument="Smartizer\EventxBundle\Document\User")
     * @MongoDB\Index
     */
    protected   $follows;

}

a record will get  stored like that in mongo db

{
	"_id" : ObjectId("4e8109858ead0e3d23000000"),
	"follows" : [
		{
			"$ref" : "User",
			"$id" : ObjectId("4e50033f8ead0ebd0e000009")
		}
	]
}

when I create schema, an index gets created for follows  and when I run explain() on this query, I get a result that says that the index was used. but running the query itself gets no results at all.

db.User.find({"follows" : ObjectId("4e80f4ed8ead0e8c1d000000") }).explain()

{
	"cursor" : "BtreeCursor follows_1",
	"nscanned" : 0,
	"nscannedObjects" : 0,
	"n" : 0,
	"millis" : 0,
	"nYields" : 0,
	"nChunkSkips" : 0,
	"isMultiKey" : true,
	"indexOnly" : false,
	"indexBounds" : {
		"follows" : [
			[
				ObjectId("4e80f4ed8ead0e8c1d000000"),
				ObjectId("4e80f4ed8ead0e8c1d000000")
			]
		]
	}
}
}

the following query gets the results as expected, but explain() says that the index wasn't used.

db.User.find({"follows.$id" : ObjectId("4e80f4ed8ead0e8c1d000000") }).explain()

{
	"cursor" : "BasicCursor",
	"nscanned" : 4,
	"nscannedObjects" : 4,
	"n" : 1,
	"millis" : 0,
	"nYields" : 0,
	"nChunkSkips" : 0,
	"isMultiKey" : false,
	"indexOnly" : false,
	"indexBounds" : {

	}
}

as far as I understand, doctrine needs to create indexes on $id fields instead of the old way.
this problem will force me to find every reference field in my all documents and add indexes like that manually

db.User.ensureIndex({"follows.$id": 1})

This works as expected now.


feat: integrate Units (SDV354, SDV364) + Test fix

feat:  Saving unit settings concerning distance, temperature and pressure inside the API for each user in the namespace=userId. If a unit is changed, the unit gets changed in the storage API inside the namespace of the selected user. (SDV354, SDV364)
The loadsettingsUnits function is needed for SDV366. It loads the units of the selected user from the API into the state,
Additionally one test for the storageClient is pushed. It checks if a read-request for a non-existent key is handled properly.

Also please update merge request title & description


Encrypted channels feature request

Is it possible to have encrypt channels such HTTPS for using the Mass Mimikatz which now uses HTTP?

I don't see why not! will take a stab at this today!

@Lexus89 done as of commit 7d2ba3c63a533df4a9a4501da3d72313d07ff4d7


[Code] 3.11.17 的代码没merge到主分支

Please search before asking

[X] I searched in the issues and found nothing similar.

Please read README

[X] I have read the troubleshooting section in the README in detail.

使用的版本
3.11.17
系统 System
aa
复现步骤 Reproduce step
⏰
你看到了什么错误？What errors do you see?
⏰
你期望看到什么？What did you expect to see?
⏰
还有其他的内容吗？Anything else?
No response
你是否愿意提交一份 PR 来修改这个错误？Are you willing to submit a PR?

[ ] 我愿意提供 PR! I'm willing to submit a PR!

之前没来得及，现在更新了


Provider Shouldn't Require Definition of Both Sides of Integration/Monitor Relationship (Circular Dependency)

Provider version 1.0.84 forces both sides of the Integration/Monitor† relationship to be defined, which is inappropriate. Other providers do this via association resources or they allow the relationship to be set on one side of the relationship.
†There may be other circular resource dependencies in the provider that need to be worked out, as well, but I'm starting with this one.
I'd suggest studying how some of the big providers do many-to-many relationships and pick/implement an option that makes sense.
There are problems with the current behavior. Here are two of them:

I must remember to modify the relationship on both sides, otherwise I get a problematic terraform plan.
There is a circular dependency between the two, so I am forced to hardcode an ID on one of the sides. For instance:

resource "site24x7_slack_integration" "experimental" {
  ...
  # i have to do this:
  monitors = ["207348000022635025"]
  # because i cannot do this, due to the circular dependency.
  monitors = [site24x7_website_monitor.home_page__stage__jaj_test.id]
}

resource "site24x7_website_monitor" "home_page__stage__jaj_test" {
  ...
  third_party_service_ids     = [
    site24x7_slack_integration.experimental.id
  ]
}

At first blush, I think it probably makes the most sense to define the integration relationship from the monitor side, which would look like this:
resource "site24x7_slack_integration" "experimental" {
  ...
  # _no_ monitors array specified!
}

resource "site24x7_website_monitor" "home_page__stage__jaj_test" {
  ...
  # monitor defines which integrations it has
  third_party_service_ids     = [
    site24x7_slack_integration.experimental.id
  ]
}

Here is the fuller example of my current, problematic use case, as I am forced to implement it now.
resource "site24x7_slack_integration" "experimental" {
  alert_tags_id  = []
  critical_alert = true
  down_alert     = true
  monitors = ["207348000022635025"]
  name           = "JAJ Test Default (#experimental) Webhook)"
  selection_type = 2
  sender_name    = "Site24x7"
  tags           = []
  title          = "$MONITORNAME is $STATUS"
  trouble_alert  = true
  url            = data.aws_ssm_parameter.slack_webhook_url__default.value
}

# I'm using this to experiment with https://github.com/site24x7/terraform-provider-site24x7/issues/261
resource "site24x7_website_monitor" "home_page__stage__jaj_test" {
  display_name                = "JAJ test"
  website                     = "https://stage.example.com/"
  check_frequency             = "1"
  credential_profile_id       = local.credentials.stage_basic_auth_id
  ignore_cert_err             = false
  location_profile_id         = site24x7_location_profile.united_states.id
  match_regex_severity        = 2
  matching_keyword_severity   = 0
  matching_keyword_value      = "need housing assistance"
  timeout                     = 30
  unmatching_keyword_severity = 2
  use_name_server             = false
  monitor_groups              = []
  third_party_service_ids     = [
    site24x7_slack_integration.experimental.id
  ]
}

(#246 might be another example of an inappropriate circular relationship.)

We wanted to start using terraform for setup and we got the same issue with webhook integration. Hopefully someone fixes this

I could temporary bypass it, hopefully
`resource "site24x7_webhook_integration" "webhook_integration" {
...
monitors                        = []
lifecycle {
ignore_changes = [monitors]
}
}`


rdar://problem/26867815 Prevent crashes when accessing ObjC generic members

Two problems:

Emitting debug info for ObjC generic class instances in ObjC extension contexts would attempt to emit debug info for type parameters that don't really exist at runtime.
We currently emit initializers as true generics, even if they come from Objective-C (rdar://problem/27796375), but would fail to diagnose uses of them from ObjC generic extensions, leading to IRGen crashes when we try to call them with nonexistent metadata. There are some tradeoffs and code that would break if we changed this that are out of scope for Swift 3, so for now diagnose uses of initializers from within ObjC generic extensions.

@swift-ci Please smoke test OS X

@adrian-prantl and @slavapestov, do you mind reviewing these changes?


REST Exports

Hey all,
i stumbled upon this PR #692 in the process of creating REST-Api endpoints for one of my projects. Unfortunately this aproach didn't fit my purposes so I wrote an "export REST view" myself (looking forward to also write an import REST view). So my question now: Is it in the sense of this project to also provide "non-admin" views, REST-like views, utilizing resources etc. ?
If so I would refactor my code, enhance it further and open a PR.
Thanks in advance.

Any Thoughts about this ?

@chgad
Could you say why the ExportView doesn't fit with your requirerments ?


help with coverage.py

Hello,
I have a spades generated assembly file (.fasta) that I am trying to trim for both length and coverage.
I have successfully run the script for length Filter_length.py but the filter_coverage script is just not working, the output is always a blank fasta file no matter the coverage number provided
e.g.
./filter_coverage.py 1 ./fasta.file
./filter_coverage.py 2 ./fasta.file
./filter_coverage.py 5 ./fasta.file
I can see there are definitely contigs with coverage that should be trimmed.
Any ideas?
Thanks in advance
Dan

Hi Dan,
Found a bug in the assembly header-matching regex that was preventing any header from matching. Try the new version, it should work.
Justin

should be fixed in most recent commit.


jTDS: support running JDBC tests with jTDS driver

Description
This PR is a part of a change originally implemented in #2320.
This change to JDBC test harness introduces the jtds_jdbc_schedule list file. To run the test from this new file instead of jdbc_schedule file it is necessary to set useJTDSInsteadOfMSSQLJDBC environment variable to true:
useJTDSInsteadOfMSSQLJDBC=true mvn test

Changes from #2860 PR are required to run jTDS tests successfully.
For jtds_jdbc_schedule file the intention is to use original tests unmodified where possible. Test for which modifications were required (mostly due to data types and error handling differences) are copied with jtds- prefix.
Github workfow file jdbc-tests-with-jtds.yml is included, but tests there are failing until #2860 is integrated. It is based on jdbc-tests-with-parallel-query.yml workflow file.
Issues Resolved
#2137
Test Scenarios Covered
The following tests from the original list are included:

sqlBatch
errorHandling
storedProcedures
transactions

Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Alex Kasko<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 74.047%

Totals

Change from base Build<PHONE_NUMBER>5:
0.0%

Covered Lines:
44427

Relevant Lines:
59998

💛  - Coveralls


Ratio Component Refactor + Jest Testing Coverage

Jira
http://vjira2:8080/browse/BDS-987
Summary

Refreshes the ratio component's internals + adds testing coverage support via Jest (including visual regression testing)

Screenshot snapshots for VRT in the <bolt-ratio> component

Details

Cleans up and refactors the ratio component to simplify rendering logic + allow for more easily testing the Shadow DOM-related rendering behavior + conditional behavior based on support for CSS Custom properties
Adds several new Jest tests to the Ratio component — checking the ratio component’s Twig rendering and the web component rendering!
Also adds two new visual regression tests to the ratio component (one with a vanilla HTML5 <video> example and the other with a vanilla <img> tag example)
Updates then .boltrc config + Jest-related logic to copy over the example video asset used for demos & testing
Updates the Jest test fixture logic to auto-copy over any non-image assets (previously these were not copied over)

Fixes an issue where the Jest testing environment didn’t have the Bolt webfonts correctly copied over + wasn’t allowed to access these assets when being served from the www folder
This should also address previous VRT tests / test differences noticed with the button component

Tests out adding a few component-specific examples to the component's schema file directly (potential emerging pattern on how we can handle demoing some of these examples automatically)
Updates the <bolt-ratio> component schema to differentiate between Web Component vs Twig-specific props
Adjusted the docs site schema table logic to better differentiate between the deprecated vs non-deprecated prop options

Deprecated
The ratio component's aspect-ratio-height and aspect-ratio-width props are deprecated and will be removed in Bolt v3.0.
How to test

Confirm all Travis CI build tests passing
Spot check other component examples and page prototypes to verify consistent behavior / styling

Thanks @adamszalapski!


@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I rerendered the recipe in conda-forge/pythonqwt-feedstock#5.


Error: 'Atoms within vdW radius of central atom:', '2'

Dear Morfeus developer,
I'm Daniele Veclani, and I'm trying to use your software for calculating the cone angle and solid angle. I've used one of your .xyz files, and the program runs smoothly. However, when I use my own .xyz file, the program crashes with the following error:
"Traceback (most recent call last):
File "/home/daniele/anaconda3/envs/morfeus/bin/morfeus", line 10, in
sys.exit(main())
^^^^^^
File "/home/daniele/anaconda3/envs/morfeus/lib/python3.12/site-packages/morfeus/main.py", line 20, in main
fire.Fire(
File "/home/daniele/anaconda3/envs/morfeus/lib/python3.12/site-packages/fire/core.py", line 143, in Fire
component_trace = _Fire(component, args, parsed_flag_args, context, name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/daniele/anaconda3/envs/morfeus/lib/python3.12/site-packages/fire/core.py", line 568, in _Fire
component, remaining_args = _CallAndUpdateTrace(
^^^^^^^^^^^^^^^^^^^^
File "/home/daniele/anaconda3/envs/morfeus/lib/python3.12/site-packages/fire/core.py", line 693, in _CallAndUpdateTrace
component = fn(*varargs, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^
File "/home/daniele/anaconda3/envs/morfeus/lib/python3.12/site-packages/morfeus/cone_angle.py", line 84, in init
raise ValueError("Atoms within vdW radius of central atom:", atom_string)
ValueError: ('Atoms within vdW radius of central atom:', '2')"
Here the .xyz file used:
C8H5O2.txt
This is thye command used:
morfeus cone_angle C8H5O2.xyz - 1 - print_report
Waiting for for kindly reply.
Best regards,
Daniele Veclani.

Hello! The cone angle is not defined if the central atom is within the vdW distance of other atoms. You would need to make sure that your central atom is sufficiently far away from all the other atoms.


Upgrades

...

GitHub really doesn't make this easy. 😆
I've pointed the main README to your fork and I'm going to archive the repo now. Thank you for forking, and good luck with it! https://github.com/BrianHicks/nix-script/commit/124d7004b9e925a7ff2c0710ae9eb7c14d46a587


Odd assertion error since v1.30

What version of gRPC and what language are you using?
This bug occurs in v1.30 and up
What operating system (Linux, Windows,...) and version?

MacOS Catalina 10.15.7 (local machine running client)
Ubuntu bionic (when project is deployed using v1.30)

What runtime / compiler are you using (e.g. python version or version of gcc)
Unrelated.
What did you do?
I'm having a pretty odd issue with PECL GRPC v1.30 and up (but not v1.29.1 and below) and I would love to get some input or pointers. Since v1.30 I'm getting an assert error (specified below). I brought this up in Gitter and someone told me to make a bug report, so here it is.
This assert is thrown by the following line: https://github.com/grpc/grpc/blob/master/src/core/tsi/ssl_transport_security.cc#L473
This issue is pretty complex, so I haven't build a reproduction yet, but I'll commit some time to it if it's really necessary. I'm hoping that the data I've provided below is clear enough.
What did you expect to see?
I expected the call to finish, as it has before, but it doesn't.
What did you see instead?
[PHP-FPM    ] Oct 15 13:42:48 |INFO   | REQUES Matched route "app_overview_list". method="GET" request_uri="https://<IP_ADDRESS>:8000/api/account/personal/list?limit=500&offset=0" route="app_overview_list" route_parameters={"_controller":"App\\Controller\\OverviewController::list","_route":"app_overview_list","entity":"personal"}
[PHP-FPM    ] Oct 15 13:42:48 |INFO   | SECURI Guard authentication successful! authenticator="App\\Security\\StubAuthenticator" token={"Symfony\\Component\\Security\\Guard\\Token\\PostAuthenticationGuardToken":"PostAuthenticationGuardToken(user=\"Foo Bar\", authenticated=true, roles=\"ROLE_FOOBAR\")"}
[PHP-FPM    ] E1015 15:42:48.435412000<PHONE_NUMBER> ssl_transport_security.cc:473]     assertion failed: (int)peer->property_count == current_insert_index
[Web Server ] Oct 15 15:42:48 |INFO   | SERVER GET  (200) /favicon.ico ip="<IP_ADDRESS>"
[Web Server ] Oct 15 15:42:48 |ERROR  | SERVER issue with server callback error="unable to fetch the response from the backend: unexpected EOF"

Anything else we should know about your project / environment?
On the client side (PHP) I use the following to connect to the server (through NGINX with a GRPC pass):
return new AccountAPIClient($host, [
    'credentials' => Grpc\ChannelCredentials::createSsl(\file_get_contents($caFilePath)),
]);

On the server side (Golang) we use the following:
// Set TLS options
grpc.Creds(credentials.NewTLS(&tls.Config{
    ClientAuth:   tls.RequireAndVerifyClientCert,
    Certificates: []tls.Certificate{certificate},
    ClientCAs:    certPool,
})),

The NGINX config we use (which creates the actual mTLS connection):
server {
  listen 7790 ssl http2;
  client_max_body_size 15m;
  server_name foo.bar.com;

  ssl_certificate /etc/freeipa/certs/server.crt;
  ssl_certificate_key /etc/freeipa/certs/server.key;

  location ~ ^/foo.bar.* {
    grpc_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
    grpc_ssl_certificate /etc/private/ssl/foobar/foobar-client.crt;
    grpc_ssl_certificate_key /etc/private/ssl/foobar/foobar-client.key;
    grpc_pass grpcs://foobarservers;
    access_log /var/log/nginx/access_foobar_7790.log;
    error_log /var/log/nginx/error_foobar_7790.log;
  }
}

So I suppose this can only be reproduced when PHP is invoked via Nginx? Yes a reproducible test case would be great.
But let me get this straight. Which of the following is your setup?

some client makes a request to Nginx, possibly for a .php page, PHP-FPM is dispatched to handle the PHP request.  Nginx is re-routing that grpc request to a Go gRPC server with grpc_pass?

It isn't clear to me where PHP and Nginx are sitting in the end-to-end path from your description. Can you clarify that please? Thanks.

@stanley-cheung It's the second setup. A PHP client makes a gRPC request to NGINX and which is then rerouted. When using haproxy the same issue occurs, so it really looks to be more a PHP client side issue than a grpc_pass issue. 🤔
If this doesn't add enough information, I'll try and build something reproducible tomorrow :)

I see. So the set up is
PHP gRPC Client <--> Nginx <--> Go gRPC Server

In that case, does this error happen if you remove Nginx from the picture (just for the sake of understanding the problem a little better?) i.e. what if you connect the PHP gRPC Client directly to a  gRPC server directly?

And one more question, where does PHP-FPM come into play? Asking because I see PHP-FPM as the process spitting out that log line error of ssl_transport_security.cc:473 in the original post. Does this mean that there's another server serving some front-end requests and that server is running PHP-FPM on the side to execute the .php scripts? Just trying to get to your set up as close as possible. If that part can be eliminated, i.e. if the problem can be reproduced with the PHP gRPC client running from the CLI that would simplify things. However, if the problem has to be reproduced with this extra PHP-FPM process, then it introduces another layer of complexity.

In that case, does this error happen if you remove Nginx from the picture (just for the sake of understanding the problem a little better?) i.e. what if you connect the PHP gRPC Client directly to a  gRPC server directly?

I'll try that and report back @stanley-cheung, but the issue also happens with haproxy, so I'm pretty certain that it's not NGINX, but def. better to test it and be sure. 👍

The PHP-FPM error you see if because of me running symfony serve to run the client locally. Sorry for the confusion.

@stanley-cheung I've been able to setup a testing repository now, but there I'm not getting any issues even though it should be an exact replication of what I have. After some checking it seems that the freeipa SSL certificates (which NGINX is using) are causing issues, not the actual GRPC server.
This is the certificate I'm currently using (anonymized):
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number: 361 (0x169)
        Signature Algorithm: sha256WithRSAEncryption
        Issuer: O = I.FOOBAR.NL, CN = Production CA
        Validity
            Not Before: Jun  12 05:30:34 2020 GMT
            Not After : Jun  12 05:30:34 2021 GMT
        Subject: O = I.FOOBAR.NL, CN = sta-hello-world-in.stage.virt.i.foobar.nl
        Subject Public Key Info:
            Public Key Algorithm: rsaEncryption
                RSA Public-Key: (2048 bit)
                Modulus:
                    REMOVED
                Exponent: 65537 (0x10001)
        X509v3 extensions:
            X509v3 Authority Key Identifier:
                keyid:REMOVED

            Authority Information Access:
                OCSP - URI:http://ipa-ca.i.foobar.nl/ca/ocsp

            X509v3 Key Usage: critical
                Digital Signature, Non Repudiation, Key Encipherment, Data Encipherment
            X509v3 Extended Key Usage:
                TLS Web Server Authentication, TLS Web Client Authentication
            X509v3 CRL Distribution Points:

                Full Name:
                  URI:http://ipa-ca.i.foobar.nl/ipa/crl/MasterCRL.bin
                CRL Issuer:
                  DirName:O = ipaca, CN = Certificate Authority

            X509v3 Subject Key Identifier:
                REMOVED
            X509v3 Subject Alternative Name:
                DNS:hello-world-staging.i.foobar.nl, othername:<unsupported>, othername:<unsupported>, DNS:sta-hello-world-in.stage.virt.i.foobar.nl

This is the cert that works whilst testing (anonymized in the same way):
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number:
            REMOVED
    Signature Algorithm: sha256WithRSAEncryption
        Issuer: O=mkcert development CA, OU=<EMAIL_ADDRESS>(Mitchell), CN=mkcert<EMAIL_ADDRESS>(Mitchell)
        Validity
            Not Before: Jun  1 00:00:00 2019 GMT
            Not After : Oct 20 11:10:59 2030 GMT
        Subject: O=mkcert development certificate, OU=<EMAIL_ADDRESS>(Mitchell)
        Subject Public Key Info:
            Public Key Algorithm: rsaEncryption
                Public-Key: (2048 bit)
                Modulus:
                    REMOVED
                Exponent: 65537 (0x10001)
        X509v3 extensions:
            X509v3 Key Usage: critical
                Digital Signature, Key Encipherment
            X509v3 Extended Key Usage:
                TLS Web Server Authentication
            X509v3 Basic Constraints: critical
                CA:FALSE
            X509v3 Authority Key Identifier:
                keyid:REMOVED

            X509v3 Subject Alternative Name:
                DNS:example.com, DNS:*.example.com, DNS:example.test, DNS:localhost, IP Address:<IP_ADDRESS>, IP Address:0:0:0:0:0:0:0:1
    Signature Algorithm: sha256WithRSAEncryption
         REMOVED

Anyone able to give any insight in why my currently live certificate (that works just fine before v1.30) doesn't work now. It's seems to be related to this MR: https://github.com/grpc/grpc/pull/22863

Would this be reproducible just with a simple client that can be launched with symfony serve? Does Nginx have to be run to cause the error to happen?

Would this be reproducible just with a simple client that can be launched with symfony serve? Does Nginx have to be run to cause the error to happen?

Good question @stanley-cheung. I've just checked and NGINX does not have to run for this error to happen. When using this certificate in the Golang server the same happens if I directly connect to it from the PHP client (either by using php ./client/index.php or by running symfony serve).
So it seems that the cert that I'm using is hard to parse by grpc/grpc for some reason 🤔

Would this be reproducible just with a simple client that can be launched with symfony serve? Does Nginx have to be run to cause the error to happen?

Good question @stanley-cheung. I've just checked and NGINX does not have to run for this error to happen.
When using the "invalid" certificate in the Golang server the same happens if I directly connect to it from the PHP client (either by using php ./client/index.php or by running symfony serve).
So it seems that the certificate is not being parsed correctly by grpc/grpc somehow. 🤔

I've published the simple setup I'm using locally to test. I cannot share the messed up certificate though as that leaks a lot of information, sorry.

Ah, I think the problem is caused by https://github.com/grpc/grpc/blob/master/src/core/tsi/ssl_transport_security.cc#L356-L389, where otherName is currently not parsed as peer information. The fix should be straightforward: we either increase the index even when a not recognized SAN name passed in(preferred), or we remove that ASSERT check.
Thanks @stanley-cheung for working with the user on this issue! I wouldn't be able to spot the problem without the initial investigation work. I will work a fix in the next couple of days.

@ZhenLian Thanks for looking into this!

Thank you both for taking the time to look into it at all. 😊

I hereby confirm that the fix works. Thanks again @stanley-cheung and @ZhenLian

Oh, I just saw this update :) Great to hear it works for you!
IIRC, gRPC releases new minor versions every month, but I am not sure about the patch version. Looking at https://github.com/grpc/grpc/releases, it seems the patch is weekly released or bi-weekly released. Maybe @stanley-cheung can confirm this?

@stanley-cheung @ZhenLian Last release was 21 days ago. Can anyone release this fix please/tell me when it will be released? 😅

@ping-localhost You can find the release information at https://github.com/grpc/grpc/issues/24589#issuecomment-730317941. Please let me know if you have any other questions. Thanks!


Add accessibility statement

⚠ As mentioned on #2, We need to fetch upstream the main branch in order to see an up-to-date code diff. If I compare it to jupyter/accessibility it only shows one commit, so I don't think the error was in my process this time.
This is a draft accessibility statement edited from the W3C Accessibility Statement Generator Tool. It only applies to JupyterLab.

Below are thoughts copied from quansight-labs/jupyter-a11y-mgmt #52.
Things I think we should add
From Make your website or app accessible and publish an accessibility statement  - Gov.UK, there are a few things we need to do. I've added check boxes to the quote to show what I think is covered in the above draft.

Your statement needs to cover:

[x] whether your website or mobile app is ‘fully’, ‘partially’ or ‘not’ compliant with accessibility standards
[x] if it’s not fully compliant, which parts of your website or mobile app do not currently meet accessibility standards and why (for example, because they are exempt or it would be a disproportionate burden to fix things)
[ ] how people can get alternatives to content that’s not accessible to them
[x] how to contact you to report accessibility problems - and a link to the website that they can use if they’re not happy with your response.

With this and the other resources, I think we may want to add

How people can get alternatives to content that's not accessible to them (mentioned above).
An accessibility monitoring methodology section (ie. the testing work). This could be a link to a document that goes more into detail about this process since I doubt it is the main focus for everyone reviewing this statement.
Maybe a note about open source. We'd have to be sure not to let this sound like an excuse, but rather a note about response times and that there's no support for this work.
A way for people to report they'd like to be reached out if/when we are testing (like Gatsby's Surveys and Research section). Since I think this could come off wrong, we may want to mention like "for outreach in any potential paid testing opportunities." At the same time, it'd be useful to know we have people available if we want to apply for funding this kind of work in the future.

What next
To move forward, I would like to know a few things.

[ ] What seems to be inaccurate or missing from this current draft?
[ ] What's on your wish list of statement additions?
[ ] How would we like to collaborate on this next? Is it a good time to open a PR, or do y'all find it easier to iterate elsewhere first?
[ ] I filled this out for JupyterLab. Is there any supporting project we think should be included (ex. the notebook file)?
[ ] Where should this file go?

How people can get alternatives to content that's not accessible to them (mentioned above).
An accessibility monitoring methodology section (ie. the testing work).

Agree - I propose we start this as a result of this initial testing phase.

Maybe a note about open source. We'd have to be sure not to let this sound like an excuse, but rather a note about response times and that there's no support for this work.

💯  - this is completely acceptable and helps set clear expectations

A way for people to report they'd like to be reached out if/when we are testing (like Gatsby's Surveys and Research section). Since I think this could come off wrong, we may want to mention like "for outreach in any potential paid testing opportunities." At the same time, it'd be useful to know we have people available if we want to apply for funding this kind of work in the future.

+1 on this - do we want to use an email for this? if so which would be best?

[ ]  I filled this out for JupyterLab. Is there any supporting project we think should be included (ex. the notebook file)?
I think @gabalafou and @tonyfast  would have better ideas but right now I can only think of retrolab and by inheritance from JLab: binder and JupyterHub

[ ]  Where should this file go?
In the /docs directory - also we might want to ask folks in the projects above if they want to x-link to this from their own docs/repo for maximum coverage and avoid having 100 different statements in multiple repos

What seems to be inaccurate or missing from this current draft?
What's on your wish list of statement additions?

A link to the roadmap?

I filled this out for JupyterLab. Is there any supporting project we think should be included (ex. the notebook file)?

Because of the grant and my own mental well being, I have had to keep my focus a bit narrowly on JupyterLab. For me that includes paying attention to anything upstream (Lumino, CodeMirror) but giving carefully limited attention to anything downstream (Notebook v7).

Where should this file go?

An accessibility statement for JupyterLab should go in the JupyterLab repo, no?
Also I'm not as concerned about where the file lives as much as how to get to it. For example, I think if somebody visits the JupyterLab repo, they should be able to search the keyword "accessibility" and find a link to this statement on that page.

Replying to non-inline comments!
@trallard

[x] I added a note about open-source response times under ### Feedback and Formal complaints
[ ] I don't think we have any kind of private group contact point for testing or for the wider accessibility contributors, so if it makes sense to use my Quansight email we could use that.
[ ] I can add a note about JupyterLab being a foundation for other projects and that our accessibility is at least somewhat interlinked. I'm would rather not call out projects I don't think we've tested here, though I'm open if you have different thoughts.
[x] I moved the file to docs/resources

@gabalafou

[ ] I agree with you that that's a good structure for the statement. Do I think this does that? Eh… it does it very formally. I'm not confident it's approachable. I chose this mainly because it helped me get something done and gave me pointers to cover things I never would've though of in my inexperience.

We could group the headers differently, though, and still benefit from W3C's guidance. Like use the outline you mentioned as a base for three main sections and lower the hierarchy of the existing headers to be grouped under those, if you think that would help navigation.

[x] I added a link to the roadmap under ### Measures to support accessibility. Thanks for the reminder!
[ ] An accessibility statement for JupyterLab should probably have a presence in the JupyterLab repo, yeah. Probably in the docs and in the repo itself somewhere. Do you think it should only be there, or does it belong in both JupyerLab and jupyter/accessibility? I don't think I have a strong opinion on that.

I don't think we have any kind of private group contact point for testing or for the wider accessibility contributors, so if it makes sense to use my Quansight email we could use that.

I would rather just redirect folks to jupyter/accessibility instead of personal emails

I can add a note about JupyterLab being a foundation for other projects and that our accessibility is at least somewhat interlinked. I'm would rather not call out projects I don't think we've tested here, though I'm open if you have different thoughts.

👍🏽  this sounds like a good approach
Thanks for all the work here @isabela-pf

@trallard I personally think this is clean enough to be merged. There's still some feedback I haven't addressed which is why I hadn't pushed for it. The core of the draft statement is here, though.

The question on adding this to the JLab repo will be discussed in the upcoming a11y meeting.
We can then proceed with either opening a PR with the statement or a PR linking to the statement here.
Apart from this - the PR looks good to merge, WDYT @isabela-pf ?


How do I set the default volume to 100% in Wordpress audio player?

I've seen some code that people suggest, but I am a novice when it comes to website code and I'm not sure exactly where in WordPress I put the code.  I've tried pasting their code in a few different places but it never works....  Luckily I know where I have pasted it and am able to delete it so I don't mess things up!
I'm using the built in audio player in WordPress but it defaults to 80% volume and I would like it to default to 100% .  If you have something that works, that would be great.  Plus any help on where exactly to paste the code in WordPress would be a big help.  I'm a beginner when it comes to website stuff.  I'm able to do a few things but don't know much and don't want to mess up my existing site.
Thanks so much.

Anyone have an idea on this?

Hi @dobro03, you will find the default volume setting in the wp-mediaelement.js file (located in wp-includes/js/mediaelement):
In the line 86:
settings.startVolume = 0.2;
Set the startVolume setting to:
settings.startVolume = 1;
Notes:

Don't forget that this option is overrided by user cookie.
As long as WordPress include the minified version of wp-mediaelement (wp-mediaelement.min.js), so you may need to edit the wp-mediaelement and minify it.

I hope this help.

Thanks for the reply Qoraiche.  I looked in that file and it only goes to line 84.  Nothing after.  I also didn't see anything titled settings.startVolume =0.2 on the page.
When I did a search for this problem someone suggested going into the media element-and-player.js file and change startVolume on line 2992 1.0 from .8.    That didn't seem to do anything.
On your NOTES not sure won't either means.  Does that mean I need to clear cookies to see if this works?  Also not sure what you mean to "minify it".
Thanks for any help.  Much appreciated.

Hello again @dobro03, oops sorry my mistake. the answer updated!

I never could find line 86 in that file, (only went to 84) BUT I did see startVolume .8 in 2 files:
mediaelement-and-player.js and mediaelement-and-player.min.js    I changed that to 1.0 and it still didn't work.  But thanks to Qoraiche I deleted cookies from my website in my browser and then that fixed the problem.  Thank you Qoraiche!
One last question:  when WordPress has an update do I have to do this everytime?  If so, any other way to do this?  Thanks again!

@dobro03 did see my first updated answer?

Yes.  In my wp-mediaelement.js file it only goes to line 84.   I believe I have the correct file?   Any file that started with wp didn't have startVolume in the media element folder for some reason.  But I did see that in mediaelement-and-player.js and mediaelement-and-player.min.js
Will I always need to update this if WordPress does its many updates?  Thank you!

@dobro03 , copy-paste the following gist & minify:
https://gist.github.com/Qoraiche/e597c6726de673b041dd1771259b94ba#file-wp-mediaelement-js-L42

Qoreaiche-
I am not a website guy so thank you for your patience.  So paste this in the wp-mediaelement.js file?  Do I just add this to the existing code at the bottom of that file OR do I overwrite the existing code.  Also, I looked up minify but I would be nervous to try to do that unless there is a plug-in that does that automatically?   Appreciate all your help.....

it's okay, you can minify using an online javascript-minifier. and yes overwrite the wp-mediaelement.min.js file with the minified version of the gist I gave you.

Thank you so much!!


feat: define ergodic actions

Also prove that a function is ergodic iff the corresponding IterateMulAct action
is ergodic.

[x] depends on: #14933
[x] depends on: #14891

bors merge


Error when Viewer randering blank data ->  There is no text key "OK" in en-US Issue has appear

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
make react View like this below

    const initValue = () => {
        return "## Color Syntax Plugin\n" +
            "\n" +
            "Click the color picker button on the toolbar!\n" +
            "\n" +
            "## Table Merged Cell Plugin\n" +
            "\n" +
            "| @cols=2:merged |\n" +
            "| ------ | ------ |\n" +
            "| table | table2 |\n" +
            "\n" +
            "## Code Syntax Highlighting Plugin\n" +
            "\n" +
            "```python\n" +
            "print(\"Hello world\")\n" +
            "```\n" +
            "\n" +
            "```html\n" +
            "<div id=\"editor\"><span>baz</span></div>\n" +
            "```\n" +
            "\n" +
            "## Chart Plugin\n" +
            "\n" +
            "$$chart\n" +
            ",category1,category2\n" +
            "Jan,21,23\n" +
            "Feb,31,17\n" +
            "\n" +
            "type: column\n" +
            "title: Monthly Revenue\n" +
            "x.title: Amount\n" +
            "y.title: Month\n" +
            "y.min: 1\n" +
            "y.max: 40\n" +
            "y.suffix: $\n" +
            "$$\n" +
            "\n" +
            "## UML Plugin\n" +
            "\n" +
            "$$uml\n" +
            "partition Conductor {\n" +
            "  (*) --> \"Climbs on Platform\"\n" +
            "  --> === S1 ===\n" +
            "  --> Bows\n" +
            "}\n" +
            "\n" +
            "partition Audience #LightSkyBlue {\n" +
            "  === S1 === --> Applauds\n" +
            "}\n" +
            "\n" +
            "partition Conductor {\n" +
            "  Bows --> === S2 ===\n" +
            "  --> WavesArmes\n" +
            "  Applauds --> === S2 ===\n" +
            "}\n" +
            "\n" +
            "partition Orchestra #CCCCEE {\n" +
            "  WavesArmes --> Introduction\n" +
            "  --> \"Play music\"\n" +
            "}\n" +
            "$$\n" +
            "\n" +
            "\n"
    }

    const viewerRef = useRef();
    useEffect(() => {
        //db에서 데이터를 읽어오기
        const markDownData = localStorage.getItem("data")
        // viewerRef.current.getInstance().setMarkdown(markDownData)
    }, [])

    return (
        <Viewer
            // initialValue={initValue()}
            viewer={true}
            ref={viewerRef}
            plugins={pluginList}
        />
    )
}

Expected behavior
it's same as Toast UI Editor API Sample page
Screenshots

Additional context
using plugin list
 * toast-ui chart plugin
 */
import<EMAIL_ADDRESS>import chart from '@toast-ui/editor-plugin-chart';

/***
 * toast-ui codeSyntaxHighlight plugin
 */
import 'prismjs/themes/prism.css';
import<EMAIL_ADDRESS>import codeSyntaxHighlight from '@toast-ui/editor-plugin-code-syntax-highlight';

/***
 * toast-ui colorSyntax
 */
import 'tui-color-picker/dist/tui-color-picker.css';
import<EMAIL_ADDRESS>
import colorSyntax from '@toast-ui/editor-plugin-color-syntax';

/***
 * toast-ui tablemergeCell
 */
import<EMAIL_ADDRESS>
import tableMergedCell from '@toast-ui/editor-plugin-table-merged-cell';

/***
 * toast-ui uml
 */
import uml from '@toast-ui/editor-plugin-uml';

/***
 * embded video plugin
 */
import videoPlugin from '@leeonfield/editor-plugin-video';

export const pluginList = [
    chart,
    codeSyntaxHighlight,
    colorSyntax,
    tableMergedCell,
    uml,
    // videoPlugin
]

@laskdjlaskdj12
Sorry for late replying.
It is difficult to know the exact cause with the example code.
Can you give me code sandbox for debugging?

@laskdjlaskdj12 Sorry for late replying. It is difficult to know the exact cause with the example code. Can you give me code sandbox for debugging?
How solve？

Yeah i'll give as tomorrow
First of all i figure it out that cause
I'll leave that as well
@xiaosaturn

For short. it was crash from i18n "kr" problem in one plugin that import to editor and view

Hi, how did you fix this problem ,

@seawenzhu It is Plugin crash witch in Localization Problem.
i just remove each plugin with different localizations. (ex kr-KR Plugin and en-US Plugin combination  in Plugin List)
if you want to solve this problem, remove plugin and run for serveral time.
And by the way it might specify localization plugin problem. But definitely plugin crash in plugin list


Add: Turkish Language

Add: Turkish Language

Hi @oguzhantasimaz, thanks for your contribution. For translation changes we use Weblate as platform where people can translate and modify out interface strings. https://hosted.weblate.org/projects/evcc/evcc/
To avoid conflicts we do not direclty modify translations in this project. Since you've already done a lot of work here and the Turkish translation in Weblate is empty right now this way might work without major conflicts. I'll give it a try.
But please provide additional changes via Weblate.

Really nice to see more Turkish- thank you!

Thank you!
For further translation work, which we very much welcome, I would kindly ask you to use the Weblate tool, as it simplifies the workflow considerably.


more details about hyper-parameter settings?

Hi,
Thanks for sharing the code! Could you also share the hyper-parameter settings to reproduce  53.09% joint accuracy on MultiWOZ 2.1?
I cannot get this result by directly running the code (without modification) parallelly on two P100 GPUs. I get 52.16% at the 29th epoch  (best on dev set).
I also found that a paper ("Efficient Context and Schema Fusion Networks for Multi-Domain
Dialogue State Tracking") reported that your model achieves only 52.57%, which result is now shown at paperswithcode.

@zengyan-97
Sorry for the late reply..!
The 52.57 is the previous result (arxiv version).
And we found there is non-deterministic function scatter_add.
(Please see, https://pytorch.org/docs/1.4.0/notes/randomness.html)
So, we report the result 53.01  by averaging 10 results


Setup Celestia Testnet

Setup Celestia Testnet

Node is up

@maximxmoroz  https://docs.celestia.org/nodes/bridge-node#hardware-requirements

@altbro please setup mainnet bridge as well


[D2] 1.5 Week 11 Submission

To be completed on Week 11, Thurs: 16 March

[ ] 2 working features, more the merrier
[ ] Refine Design
[ ] Update diagrams based on the feedback + review

Completed on 16 March


Fix fallback logic for image and video element accessibility and title fields

This fixes #1128 (the issue where the alt and title tags cannot be set to an empty string in the inspector).
I believe this is a stop-gap fix. A more comprehensive fix for the meaning of null/emptyString/undefined for properties in general needs to be thought out.

Does this fix #1128 ?

Sorry for the confusion, I've closed https://github.com/google/web-stories-wp/pull/1341 and rolled it into this PR.


Improved review prompt, open to write action

I don’t really like that the App Store gives zero context in the modal; I felt unsure about what was going to happen in this view. 😐
Even though I just tapped “leave a review”.
What do you think?

Sent with GitHawk

@BasThomas not bothered by it. Is there a better option?
Sent with GitHawk

Don't think so. It's fine :)


Weird escaping of asterisk in Markdown

The Markdown output marks required configuration properties with **\*** which then renders as *****. This does not seem to be correct, simple \* can be used to escape the asterisk character. Or perhaps I misunderstood the behavior?

The intention was a bold asterisk *, which was rendered correctly according to my tests.
This can be customized with a custom template.
Default asterisk directive: link
Default MD template: link
Overriding the asterisk macro should be possible like this (removed the bold format)
[#macro asterisk option][#compress]
[#-- check if the option is required --]

    [#if option.required]
        [#assign areThereRequired = true]

[#-- adjust the output format and use #t to strip new lines and spaces --]

        [#if format == "MD"]
            \*
        [#else]
            *
        [/#if]

    [/#if]
[/#compress][/#macro]

I am unsure about interaction with the variable and printing the legend at the end of the template.
This might be related in that case.


Use shell_escape to escape command arguments if necessary to avoid

issues with unusual characters in arguments. Fixes issue #6.

Coverage increased (+0.3%) to 73.661% when pulling 1caefc6376c32ed5b077f7e5bf44a2bae7505177 on gurgeous:amd_shell_escape into dd2078a32125c49ef3f31197bfd85c7d3b876125 on piotrmurach:master.

Sweet!


MCTS not giving what is expected

Hi,
I find a hidden bug in current MCTS. The two routes bellow are almost the same despite the templates at first step are different.

And by accident, I find a shorter route which can hardly be found by current MCTS.

The reason I guess is that despite after first iteration, the Q and N updated along the route, but in the second iteration, when different template is chosen, and the same expandable molecule is encountered, the experience got from the first iteration is gone.
So, my suggestion is the Q and N should be inherited from past iteration when the same expandable molecule is encountered in the next iteration. By the way, I find several target molecules have the same problem when I check their routes.

Thanks so much for the feedback. This is very interesting, and I would like to look closer at this.
Could you be so kind and provide details about your setup:

what is the input SMILES?
what is the stock, expansion, and filter models?
can you provide me a configuration file in case you have non-default settings?

I think in general that the first case, when two templates generate the same pre-cursors only one child node should be added to the search tree. This is something that we have seen before, and is on our to-do list to fix.

The target is 'C#CC1=CC=CC(NC2=NC=NC3=CC(OCCOC)=C(OCCOC)C=C32)=C1'.
The stock, expansion are regular default respectively: zinc, full_uspto, and none filter.
The shorter route I found just sets up: cutoff_number:10, iteration_limit: 1000.

I think in general that the first case, when two templates generate the same pre-cursors only one child node should be added to the search tree. This is something that we have seen before, and is on our to-do list to fix.

This is a better idea.

Hi, SG:
Thank u for your immediate reply. But I have no idea if you got what I meant.
In your first remark, I wanna know if the meaning of "grouping" is "when two templates generate the same pre-cursors only one child node should be added to the search tree" you mentioned above? if so, I think grouping near-identical precursors like the first step of the two longer routes is meaningful, because it is the same expandable mol at first step that leads to the same steps afterwards in the second route compared with the first route. So it should be grouped when the same expandable mol is encountered from a different template at next iteration, then I believe the shorter route may be found within 100 iteration despite of its lower probability. By the way, I can not get the meaning of "How to generalize this to no. of precursors > 2 is also something that is not clear how to do", my idea is no matter how many number of precursors, as long as a same expandable mol is found within the precursors from a different template, it should be grouped.
In your second remark, I agree it is an inherent feature of the algorithm + expansion policy. And I think what I mentioned above  could fix this: illuminated by your comment "when two templates generate the same pre-cursors only one child node should be added to the search tree", my idea is that when two templates generate near-identical precursors, in which there is a same expandable mol, only one child node should be added to the search tree. Then the shorter route may be found easily within 100 iteration despite of its lower probability.
In your third remark, I indeed used the older uspto expansion policy named "full_uspto_model" with 46695 unique templates. And I also find the newest USPTO model named "uspto_keras_model" is more powerful than the older one, despite the number of its unique templates fewer than 46695. So I wanna learn how to filter and curate it from the older templates, is there any publication to be followed? Thank u very much.

We will adress this in a future release:
There will be an option controlling the grouping of sibling nodes in the MCTS algorithm. I will have three valid choices:

No grouping - this is the current behavior, and will continue to be the default
Group on identical - this will only group sibling nodes if all molecules / pre-cursors in the two nodes are the same
Group on expandable - this will only group sibling nodes if all expandable molecules in the two nodes are the same (the molecules / precursors in stock will be excluded from the comparison)
The difference between 2. and 3. is a really minor implementation issue, so we will leave the choice to the user.
Hopefully this will enable the search to identify the short route in your example.

Regarding your question on the USPTO dataset:
I am not following what you mean with "learn how to filter and curate it from the older templates"? The new USPTO model is described in this publication: https://pubs.acs.org/doi/10.1021/acs.jcim.2c01486
and is not easily comparable to the old one because of the very different approaches to manipulate the reaction data.

We will adress this in a future release: There will be an option controlling the grouping of sibling nodes in the MCTS algorithm. I will have three valid choices:

No grouping - this is the current behavior, and will continue to be the default
Group on identical - this will only group sibling nodes if all molecules / pre-cursors in the two nodes are the same
Group on expandable - this will only group sibling nodes if all expandable molecules in the two nodes are the same (the molecules / precursors in stock will be excluded from the comparison)
The difference between 2. and 3. is a really minor implementation issue, so we will leave the choice to the user.
Hopefully this will enable the search to identify the short route in your example.

Hello, Samuel:
Is this new release still on your agenda? or this plan has been cancelled? Thank u very much.

Hello.
We are in the process of preparing a new release that will include these features
It should be available in the beginning of December

Feature for grouping sibling nodes available in new release:
search:
  algorithm_config:
    mcts_grouping: partial

Feature for grouping sibling nodes available in new release:
search:
  algorithm_config:
    mcts_grouping: partial

So kind of u!  Does it work for retrostar after a little of modification?

We haven't introduce this for Retro*, our focus has been on the MCTS algorithm. The implemention would be completely different for Retro*


Add export functionality for Alerts changelog

basic csv export of history https://github.com/smartchicago/trailsyserver/commit/7a1ebaaf653fe47368d3d203e5519a6680db49c0


Add-in deployment now under Settings > Integrated apps > Add-ins

Documentation should be updated with correct navigation for Admin Center.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e62dfa25-e420-38e4-ff47-05cca62d14ec
Version Independent ID: 5ea03ce0-38b9-e005-a430-e98442e2ec83
Content: Deploy add-ins in the admin center - Microsoft 365 admin
Content Source: microsoft-365/admin/manage/manage-deployment-of-add-ins.md
Service: o365-administration
GitHub Login: @Sirkkuw
Microsoft Alias: sirkkuw

@QuickBASIC Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/2900
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @QuickBASIC Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@msbemba Thank you very much for the contribution and updating the documentation with PR. @QuickBASIC Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Fix "More info" links in options menu

The class=" attribute was never closed for these elements, causing
html parsing to fail, but not fail badly enough, so the links were
still visible, just didn't work.

I am 100% sure I tested it and it was working 😮
Anyway, thanks for this! LGTM


chore: add MIT license file

add MIT license file per https://github.com/alexellis/actions-batch/blob/e62f1d9fc880d58b9ba84fff2019fa3b529c6894/README.md?plain=1#L255-L257

I think this is probably something the maintainer should do, but thanks for the contribution. For admin related tasks, an issue would work great. Thanks.


[Clappr | MP3] Possibility to support audio files

Environment
Google Chrome 75
Clappr 0.3.6 (Newest)
IMA SDK plugin for Clappr / IMA SDK plugin preroll only
Description
Is it possible to support ads when playing audio content? Seems to be reasonable usecase to make the user to listen to some audio advert when playing some content.
Test
VAST: https://pubads.g.doubleclick.net/gampad/ads?sz=640x480&iu=/124319096/external/single_ad_samples&ciu_szs=300x250&impl=s&gdfp_req=1&env=vp&output=vast&unviewed_position_start=1&cust_params=deployment%3Ddevsite%26sample_ct%3Dlinear&correlator=
Source: https://file-examples.com/wp-content/uploads/2017/11/file_example_MP3_5MG.mp3

I tested it with sample audio and sample VAST tag. Seen behaviour is that both advert and content start to play together. Once advert comes to end, content starts to play from the beginning.

@oFilipMalinowski  I have released a new version which should support audio only.
I have done some testing with the provided mp3 source and vast linear preroll tag and it seems to work the following in most cases :

on desktop linux, Chrome and Firefox are displaying pre-roll (and then mp3 source is played)
on desktop Mac OSX, Safari is not displaying pre-roll video but is playing pre-roll audio (and then mp3 source is played)
on android (Samsung Galaxy S5), Chrome is not displaying pre-roll video but is playing pre-roll audio (and then mp3 source is played)
on android (Samsung Galaxy S5), Samsung browser is not displaying pre-roll video but is playing pre-roll audio (and then mp3 source is played)
on android (Samsung Galaxy Tab 4), Chrome is not displaying pre-roll video but is playing pre-roll audio (and then mp3 source is played)
on iOS (iPad mini), Safari is not displaying pre-roll video but is playing pre-roll audio (and then mp3 source is played)

My recommendations are to use "still image" video pre-roll for audio only source.

displaying / not displaying pre-roll video

This is actually acceptable behaviour. Result is good as I don't expect to show any video when playing audio-only content. For me it's more logical to keep video ads with video content, and audio ads with audio content only.
I tested it a bit with some content from my MediaServer and it is working good.
Can be closed. Thanks!


Suggestion: Improve README

Add screenshots to the README

One nice suggestion to attract people is adding screenshots to the README;
With that people will see the package behavior and downloads/stars will increase.

:)

Thanks @lucaslovato for the suggestion :)
Unfortunately I usually don't pay attention to stars, since they don't pay my bills 😅
But it's definitively a good tip, since it could help people choosing the right library according to their needs.
I will do that!

Closed by #88


Make simulation linear

Codecov Report

Merging #977 (119a483) into develop (45ff65c) will decrease coverage by 0.13%.
The diff coverage is 9.71%.

:exclamation: Current head 119a483 differs from pull request most recent head d11e80e.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45ff65c...d11e80e. Read the comment docs.


API-2411: Handover of api-revocation-frontend and totp-generator to the API Services team

@gokyo tests are failing locally

@edgarjimenez fixed now

@gokyo tests are still failing for me


[Local] Create docker volumes from volumes defined in devfile

What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind feature
/area devfile
/area local
What does does this PR do / why we need it:
This PR implements a storage adapter (based off of the Kube storage adapter code) for odo when deploying components to Docker. When deploying or updating local Docker containers, odo determines the unique number of volumes in the devfile and creates Docker volumes for them. Then, when odo is deploying each container, it determines which volumes need to be mounted to it and where. When determining if a container needs to be updated, odo will compare the volumes for the container in the devfile against the volumes mounted in the container, if any differ, odo will update the container with the new (or modified) volume.
Unit tests provided for the new storage adapter, as well as new integration test scenarios to verify the volume gets created and is mounted to the container.
Which issue(s) this PR fixes:
Fixes https://github.com/openshift/odo/issues/2849
How to test changes / Special notes to the reviewer:

Run make test and make test-cmd-docker-devfile-push to verify the unit and integration tests pass (if running integration tests, make sure pushtarget set to Docker and Docker is installed)

Manual verification:

Enable experimental mode and set pushtarget to Docker
Run odo create java-spring-boot
Run odo push
Verify that the containers deploy successfully and that a "springbootpvc" volume exists (docker volume ls)
Exec into one of the containers that mount the volume and verify the mount path is there.

/approve

/approve

/retest Fails due to github issues earlier

More infra flakes from the OpenShift CI:
Installing from release registry.svc.ci.openshift.org/ci-op-rnixkgi
/release@sha256:02ae8b21c29fda5e7b5f88a581ab2197d477f9b6ba7bdcb0422326e18b77e1fb
AWS region: us-west-1 (zones: us-west-1a us-west-1b) level=warning msg="Found override for
release image. Please be warned, this is not advised" level=info msg="Consuming Install Config
from target directory" level=fatal msg="failed to fetch Cluster: failed to fetch dependency of
\"Cluster\": failed to generate asset \"Platform Permissions Check\": validate AWS credentials:
checking install permissions: error simulating policy: Throttling: Rate exceeded\n\tstatus code:
400, request id: ba65da45-7f22-4cfe-a663-07ab4551a2ad"
--

/test v4.3-integration-e2e-benchmark


y-partykit: deprecate persist: true

While y-partykit's persistence layer was useful to not need a storage layer, in practice it caused too many issues. Further, it's not really useful when there are deep edit chains across clients. This PR deprecates it's usage, and adds a warning to remove it in the future.

another idea is to use persist:true to save the document to DO storage (instead of every edit)

As discussed, closing this in favour of keeping persist and reimplementing it in a safer way.


feat: Minor updates and docker-compose compatibility

Description and Motivation
Added some minor tweaks to package.json commands and added docker-compose compatibility.

Related Issues

Checklist:

[x] I have read Migaloo's contribution guidelines.
[x] My pull request has a sound title and description (not something vague like Update index.md)
[x] All existing and new tests are passing (if any).
[x] I updated/added relevant documentation.
[x] The code is formatted properly using eslint

@carlthelooper could you maybe change this pr to release? thanks

Actually almost have the fix to allow the docker-compose to read in the .env file.  I'll post a new PR against release with the fix shortly.


[SUI] Polish Launch Parameters setting controls

Summary of the Pull Request
Performs some cleanup in the Settings UI for the Launch Parameters settings:

Updates all NumberBox controls in the Settings UI to have a Compact SpinButtonPlacementMode instead of an inline one. This alleviates the XAML bug where the spin button would appear over the number box's input value.
Fixes an issue where a long X/Y value would resize the settings controls weirdly. This was fixed by introducing a Grid inside the main grid and applying a width to the number boxes.
Rename "Use system default" checkbox to be more clear. Propagate the new localized string into expander preview.

Closes #14558

Should we also have the (Default, Default) text in the expando replaced with "Let system position window"

Should we also have the (Default, Default) text in the expando replaced with "Let system position window"

Ask and you shall receive:

Tested with resizing the window too. Nothing gets cropped.

"let system position window, centered" is a funny juxtaposition. In that specific case, it means "Let system select which monitor" (but we should phrase it better...)

@msftbot merge this in 10 minutes


Issue Reporter: Don't show anything when no duplicates are found

Testing #46595
The No results found phrase pushes the whole UI down and caught me by surprise: I actually didn't know what that was about for a couple seconds.

@joaomoreno Instead of removing it, what if it was just changed to No similar issues found? It seems useful to me to explicitly tell the user that we didn't find any duplicates. I experimented with adding some progress text that shows up when a search is being done, but because search is fast and debounced to every 300ms when typing, it just added a lot of ugly flashing. I think showing some sort of indicator that a search is being done would be a better experience though

Sure, works too


Sample code to How to use.

Hi there,
I'm new to android, I just wanted to use the app in my upcoming project. Please give us wiki link or sample code to how to use the library in code like in Sticky Headers Recyclerview.

@Naresh-Katta You'll find all the information you need on the sample project. There are examples on how to use each type of sticky header there.

The sample doesn't show how to pass data and headers to the adapter how it will it fetch from collections we passed


Grandpa: import blocks with bad justification

Currently, if a block is provided with a justification and the justification is bad we discard the block. Instead we should import the block, discarding the justification, and requesting a justification from sync. The peer that provided the block should be reported for misbehavior.

It might be easier to do this after #1619 and #1669 because those changes are likely to conflict. But I'm happy to mentor anyone on this task as a good starter for getting into the GRANDPA code.


Improving how headscale handles the client startup process

As discussed in Gitter (https://gitter.im/headscale-dev/community?at=60a9618c801b07264e631b7f), there is some weirdness in how the tailscale clients first interact with the control server in the /map endpoint.
The client uses tailcfg.MapRequest to indicate the different stages of its startup process. At the beginning of the interaction, the client just expects an updated tailcfg.DERPMap - not the full list of its peers. It will close the connection as soon as it receives the first tailcfg.MapResponse.
With this PR headscale closes the connection when the client is expecting so, in these initial interactions to /map.  In these stages it does not start the keepAlives either.
I don't think this is completely solved, so I added a few more logging messages to track this.

Let's merge then!


Update create_accessions.py to send v2 requests

Update the test script that creates random accessions so it can optionally do so
using the v2 API endpoints. This allows a limited form of fuzz testing of the v2
API: it doesn't check for correctness but can detect if the request handler bombs
out on what ought to be valid input.

Current dependencies on/for this PR:

main

PR #591   👈

PR #592

This comment was auto-generated by Graphite.


YAMALE schema generation

The simple_(base/wlcg)_schema.yaml need to be converted to a 'python yamale module' compatible schema.
var: {type: yamale_type(), required: true, use_default: false}

should become
var: yamale_type()

for the entire schema file.

Hey @maany
What filename should the yamale compatible schema be stored as? For the last output schema, we were using command line flag -o for taking filename as user input, we could do it via another flag or have a pre-defined filename.

Hey @snehasi , we could use a -s flag to specify the output file for the schema. I'd pass "augmented_site_level_schema.yaml" as the value to the -s flag via puppet.

In Phase 7, we must dynamically change type field in lightweight_components from
lightweight_component:
    deploy: list(include('doms'))

to
lightweight_component:
    deploy: deploy: include('doms')

This is necessary to account for the fact that we split the lightweight_components in phase_6 based on the entries present in the deploy section of the site_level_config_file.


Extra spaces between the code when running generator

Hey, I want to add support for VK_EXT_mesh_shader to ash. Unfortunately I have a problem running the generator. There are extra spaces between the code.
use std :: fmt ; use crate :: vk :: bitflags :: * ; use crate :: vk :: definitions :: * ; use crate :: vk :: enums :: * ;

I did the following to get the ash generator running:

I downloaded LLVM for bindgen and set LIBCLANG_PATH to C:\Program Files\LLVM\bin.
I cloned the newest version of ash
I ran cargo run --release --bin generator from the root directory.

The generator runs without issues, but the code looks weird. Running cargo fmt works, I just was curious if its a bug or just intended behaviour.

I ran into the same issue a while back.  See https://github.com/ash-rs/ash/pull/305.
Try to update your crates.


Fixed channel_id in Unit annotations always 144 and unit_id always 1 in BlackrockIO

The channel_id und unit_id values were determined in a for loop and saved to a list. When reading them to set the annotations the temporary variables that contain only the last values were read. Now the values are read from the list as originally intended.

This pull request was supposed to be at NeuralEnsemble, I will reopen it there. Sorry for the mistake.


Ramp Tool: save list of surviving validators to disk

At the end of a Ramp TPS, it would be very useful to have a single file that contains the list of validator identity pubkeys that survived each round.   Perhaps a simple yaml file is sufficent:
round1:
  - pubkey1
  - pubkey2
  - pubkey3
round2:
  - pubkey1
  - pubkey2

Also log! the results too please

@mvines what should be logged? Looks like surviving validators are logged when delegating sol

Ah, right. nm then


Phaser.Physics.P2.Body anchor problem

Hi,
in the documentation of the P2 written

Note: When a game object is given a P2 body it has its anchor x/y set to 0.5, so it becomes centered.

which causes a lot of problems , because when the sprite[lets say a 32*32]  is added on x,y , the square of the tile is on x+16,y+16 because of the note above
now when i set the anchor to (0,0) the texture get updated , but the collision bounders still the same as if the anchor is (0.5,0.5)
Tried to use body.offset , but as above only the texture get updated , so did not work
Tried to use     sprite.body.setRectangle(sprite.width,sprite.height,16,16,0); ,but the collision stop to work
So what to do in this case ?

Update:
found solution
   sprite.body.setRectangle(sprite.width,sprite.height,sprite.width/2,sprite.height/2,0);
then apply the collision groups
but is the above scenario is bug or not ?

Thank you for taking the time to open this issue. However, official support for Phaser 2 has now ended as we focus on preparing Phaser 3 for beta release. In a bid to keep the project tidy, and avoid confusion, we are closing all v2 related issues.
This does not mean your issue won't be looked-at. In November 2016 the Phaser CE (Community Edition) project began. The aim of Phaser CE was to allow the community to continue v2 development. Since then it has gained significant traction, with many updates and releases.
If you are still interested in having your issue investigated we strongly recommend testing the latest Phaser CE release. And only if the problem persists, opening an issue on the Phaser CE repo.


[cPP CHANGE] inconsistent bullets in FIA_X509_EXT.1.1/Rev

What is the change request for the cPP? Please describe.
In the bullet list that specifies the revocation methods, the two CRL listings are slightly different. One starts with "a Certificate ..." while the other one just says "Certificate ...". They should both be the same.
Describe the solution you'd like
Make these two lines start the same:

o a Certificate Revocation List (CRL) as specified in RFC 5280 Section 6.3,
o Certificate Revocation List (CRL) as specified in RFC 5759 Section 5,

Either remove the "a" from the first line, or add an "a" at the beginning of the second.
Describe alternatives you've considered
N/A
Additional context
Consistency (it looks strange to list the two lines differently given they are basically the same except for the RFC being referenced)

Change implemented. We're all impressed with your eagle eyes.


Add ffmpeg to requirements

Hi @enescakir i made the changes! Just tag me so i can push.
Cheers mate!