Feature Tracker: Local Dependencies and/or Arbitrary git:// Dependencies

Right now it's only possible to depend on packages via package.elm-lang.org without manual copying into the elm-stuff folder. This means there's no way to test against unreleased versions of dependencies, one of the most common use cases for library writers. For instance I'm trying to write a new version of IO but it relies on a change in a new version of elm-lang/core that is currently unreleased so I need to manually cp the packages to do it.
A nice feature would be to have (in elm-stuff) a file local-dependencies.json that would include paths to directories that have elm-package packages in them and when installing a package they would be checked before trying to install from the central repository.
Furthermore, I think having the central repo be the only way to depend on a library is a bad idea. If we could depend on arbitrary git:// repos that had elm packages in them it would be much easier to install packages and we wouldn't have to depend on a central repository that may go down or be outdated.

I am having the same difficulty with elm-lang/core, but I do not want to do something drastic to resolve this. My main worry is that we do something that decreases reproducibility.
Am I correct that the local-dependencies.json idea is primarily for people who want to test packages or code with unreleased versions? It's just a way to say, "actually, look at the code here"?
I think depending on arbitrary git repos is problematic for a couple reasons.

Tags can be moved and deleted.
Repos can be deleted.

When reproducibility is a goal, I think these are a big deal.
What I had in mind that may resolve both of these. I'd like to make it possible to list multiple package repositories. At the moment, there is only the central public one at package.elm-lang.org, but for industrial users who don't want everything open source, the ideal thing is to run the same service internally. That way you can publish and get all the same benefits without releasing the code publicly. You'd have a config file somewhere that lists package repos you care about: [ "http://package.elm-lang.org", "https://intranet.mycompany.com", "http://localhost:8000" ]
Does this idea address the root concerns you have?
As I'm writing this, I see that I don't fully understand the goals of the git repo thing. Can you say exactly what you want to do that your suggestion is solving?

As a developer, when I push up packages to an official repo, I feel a responsibility to maintain that code for others.  Here's two examples I can think of:
I depend on a library from elm-lang, but find a bug.  I send a pull request to fix it, but want to depend on the fixed version now. I suppose a local server would work here, but it's a little annoying to need a server running to build my dependency.  What if I want to share my code with a friend?  Am I right to think they'd also have to check out the fixed version of my dependency manually, build it, and then serve it in their own local repository? (Assume we're not at a company where we might have a central private repository).
What if a package maintainer abandons their release on elm-lang.org, but I want to make fixes and continue working on it for my own project?  Once again, I could maintain my own repo server, but that imposes extra work on everyone that might want to use my code.   However, I don't really want to push my "fork" up to elm-lang.org because not only might it confuse people, but I don't want to be on the hook for maintaining that project for years to come when I wasn't the original developer.
However, I can see the consequences of allowing another developer to pull from a git repository means it may not conform to the appropriate versioning semantics or even exist.  I guess that would be a decision any developer wanting to use my code would have to make - is it worth the potential instability?
Anyway, these feelings may be irrational or have other simpler solutions - so what would you do in these cases Evan?

@evancz

I think depending on arbitrary git repos is problematic for a couple reasons.
Tags can be moved and deleted.
Repos can be deleted.
When reproducibility is a goal, I think these are a big deal.

Suggestion:

Mark application as "application" and make them unpublishable
Enforce that NO module in the official registry has a git dependency
Allow git dependencies for applications only and for nested git modules

This means the following holds. All modules are on the registry and if you install any module of the registry which has dependencies it will only pull dependencies of the registry.
Application developers can depend on private modules through git links.
Application developers can fork a dependency on git and change a nested dependency with a git link. This allows them to change any dependency as long as they convert all parents to git dependencies.
Assumption: We assume application developers are smart and use their own cached git servers with immutable tags. Application developers can shoot themself in the foot, library developers cannot shoot themself in the foot

I like Raynos' idea, only allow published dependencies in published packages. Arbitrary git dependency would be really helpful, I'm currently working off an unmerged core branch, and though its api might change slightly before being merged, it's really useful to move forward using it

Please share your opinions on this draft of this idea!

Oh thanks I should read through this thread
On Feb 9, 2015 6:21 PM, "Evan Czaplicki"<EMAIL_ADDRESS>wrote:

Please share your opinions on this draft of this idea
https://groups.google.com/forum/#!topic/elm-discuss/6QYqpBaGW1c!
—
Reply to this email directly or view it on GitHub
https://github.com/elm-lang/elm-package/issues/87#issuecomment-73612817.

I really like John's proposal. Is there any workaround until this issue is resolved other than copying the clone of the dependency to be used?

A smooth solution to this may encourage folks to send pull requests and fixes instead of just logging complaints.  A smooth workflow for forking and running libraries could fracture the community if done incorrectly (as evancz points out), but done well this could really boost library maintenance productivity IMO.

Has anything changed on this front recently? I just finished a pretty big project with several useful libraries that really that should be published packages, but I as I can't include the WIP packages in my project, I'm not sure how to refactor them. I also want to fork and improve some libraries I ended up using, but same problem. I really love this language, and want to give back!

https://github.com/elm-lang/package.elm-lang.org/issues/105 is asking about some of the same stuff and I'm trying to guide it towards getting some concrete proposals out there so we know all the details that'd change and their implications. I think this is increasingly important so I expect it to get attention relatively soon.

I know people want this, so I'd rather trick in my personal todo list rather than here.

For what it's worth I think having private packages on package.elm-lang.org would fit my needs.

I would really prefer if issues that people obviously want just remain open so that I can follow along, instead of the constant closing, moving, aggregating, to-do-listing and just-disappearing.
I know open issues can feel like, well, "issues". But people understand that these things take time, and I  know many projects with 1000+ open tickets where I would never take that as a sign of low quality or any other problems (c.f. Tensorflow, VSCode, Ansible)
As it is currently done, I keep chasing issues from one ticket to another to find the one that's actually relevant. Only to often arrive at a dead end such as this.

Any news on this? I love Elm as a programming language, but I think having private dependencies is a huge deal. I really hope this gets fixed soon. It's been two years now and some really great solution proposals. What gives?

Try this out and see if it helps - https://www.npmjs.com/package/elm-github-install


Can we create a multi line graph with continuous time intervals(Ex: 10:15-10:30-10:45-11:00) on x axis and plot data according to time and y axis integer value?

Can we create a multi line graph with continuous time intervals(Ex: 10:15-10:30-10:45-11:00) on x axis and plot data according to time and y axis integer value?

Hi,
The issue queue is to be used for reporting defects and problems with C3.js, in addition to feature requests and ideas.
It is not a catch-all support forum.
For general support enquiries, please use the Google Group at https://groups.google.com/forum/#!forum/c3js.
All questions involving the interplay between C3.js and any other library (such as AngularJS) should be posted there first!
Thank you!


Overwrite symlinks with optional flag - fix for #689

Add symlink overwrite behavior to fix file exists error when restoring a symlink that already exists
Before creating the restored symlink, check os.Lstat:

If it returns an error indicating the file does not exist, proceed to symlink creation
If it returns any other error, propagate the error up to the caller
If the fileInfo indicates the entry is a symlink AND --no-overwrite-symlinks was set in the restore command, propagate an error to the caller
If --no-overwrite-symlinks was NOT set, remove the existing symlink before proceeding to symlink creation
Else the file exists but it is not of type symlink. Halt the operation and propagate an error indicating we tried to restore a symlink over a file system entry that already existed but was not a symlink.

Added case to TestSnapshotRestore that fails before this fix and succeeds after this fix. The case is simply to restore the same snapshot into the same directory twice in a row, where the second restore will be on top of the first one.
Added test case to ensure --no-overwrite-symlinks throws an error as expected if restoring into a directory where a symlink already exists at the path symlink creation is attempted.
Added test case to ensure that the restore operation fails if a symlink is needed to be restored to the same path as an existing non-symlink filesystem entry with the same name.

I don't know the test features thus I wonder if we have in the tests this 3 cases :

Creation of a relative symlink in the same directory
Creation of a relative symlink in a different directory
Creation of an absolute symlink
All that with a change of owner ?

I don't know the test features thus I wonder if we have in the tests this 3 cases :

Creation of a relative symlink in the same directory
Creation of a relative symlink in a different directory
Creation of an absolute symlink
All that with a change of owner ?


Validating webhook

Fix #19 missing item for configuring validatingWebhook
Depends on #50

@JAORMX I've added both, let me know if you think it's accurate


optimised docker CI test in GH action

Description
While trying POC on GitHub action we realised that docker 19.03 and Java 11 are part of runner that comes with Ubuntu-20.04 already has those requirements satisfied. (ref: https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md)
Testing
NA
Documentation

https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md

Hmm wonder why the circleci jobs didn't run here


BUG: Drop orphaned records from asset db in v6 downgrade.

Remove records that no longer refer to equities from equity_symbol_mappings and
asset_router.

the PR looks good but my mouse died so clicking accept is currently a challenge


TypeError: Couldn't find jasmine environment

Getting:
TypeError: Couldn't find jasmine environment. Make sure that you are using "setupJasmine" in jasmine/jest environment or that you provided proper jasmine environment when calling "setupJasmine"
I can see where in the setup-polly-jest code this is happening:
function setupJasmine(Polly, defaults = {}, ctx = global) {
  if (!ctx.jasmine || ctx.jasmine && typeof ctx.jasmine.getEnv !== 'function') {
    throw new TypeError('Couldn\'t find jasmine environment. Make sure that you are using "setupJasmine" in ' + 'jasmine/jest environment or that you provided proper jasmine environment when calling "setupJasmine"');
  }

It doesn't look like the setupJasmine method is intended for external consumption as it's wrapped by setupPolly - I'm guessing that the ctx param is there for testing.
So in my case the global doesn't have a jasmine object - visible when debugging. What have I not setup to cause this to happen?
Versions:
    "setup-polly-jest": "0.6.0",
    "@pollyjs/adapter-node-http": "4.0.3",
    "@pollyjs/core": "4.0.2",
    "@pollyjs/persister-fs": "4.0.2",
    "jest": "25.1.0",

NodeJS 12.14.1

Hey @guyellis! I guess as mentioned in the caveats section some major changes in freshly released jest 25 broke the code of this library. I'll need some time to look into it and figure out what's going on there

Hmm... do you mind creating a reproduction example? I just tried it with the latest versions of jest and polly and everything seems to work fine. Are you sure you are running jest with jasmine set as a test runner (it should be by default)?

@gribnoysup I am using:
  testRunner: 'jest-circus/runner',

So I'm guessing that's the issue. I didn't realize that Jasmine needs to be the test runner. I ran into a known issue with Jasmine where it "fails silently on afterAll within a describe block" which is why I switched to jest-circus. That was a while back. Let me see if I'm able to switch back to Jasmine.
How difficult would it be for setup-polly-jest to use jest-circus? Or is this something that PollyJS does not support?

It's on my TODO list for some time already, but I just didn't have time to get to it yet. I guess I'll open an issue for circus support for visibility and will probably change the error message for now to something that mentions jest/jasmine2 specifically, not just jest
The silent thing should be fixed in the latest released version hopefully after #6 was merged. Please feel free to open a new issue for this one if it's still happening for you

Perhaps a question in that error message like "Do you have something other than Jasmine2 set against testRunner in your jest.config.js file?"
I know that gets wordy but might help divert this sort of question.
Thank you for creating this module and supporting it! You are awesome! :trophy:

Yeah, good idea! I'll probably include a mention of testRunner config option in the message. I think wordy is really not that bad in this case, better to be verbose 👍

Hey @guyellis! I just added support for jest-circus in the latest release if you want to try it out

I'll try it out. Thanks @gribnoysup


Multiple triggers

I think the documentation should explain if and how you can have multiple triggers in one project....

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 369aefa6-74da-3001-f835-15abdfffd5d6
Version Independent ID: 2cc2a2db-d059-3252-7a1a-4261b7d3c37c
Content: Develop Azure Functions using Visual Studio
Content Source: articles/azure-functions/functions-develop-vs.md
Service: functions
Product: unspecified
GitHub Login: @ggailey777
Microsoft Alias: glenga

@r3plica Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

@r3plica yes, you can add multiple functions to a function app project, where each function uses a different trigger. If you are asking about multiple triggers for a single function, that isn't supported.
I will try to clarify the article.


Copy Image to Clipboard

Describe the feature and the current behavior/state.
Currently, CopyToClipboard will only accept a string or a number. In the extension I am working on, I would love to be able to copy an image to the clipboard.
Will this change the current API? How?
I propose that  CopyToClipboard should accept the ClipboardItem interface as well.
Who will benefit from this feature?
This will enable developers to write arbitrary data to the clipboard, allowing for more advanced functionality.
Any Other info.
https://developer.mozilla.org/en-US/docs/Web/API/Clipboard/write

I Hope will implement this feature soon, need it too. 🙏🏻

Available in v1.43


Fixing mono build after instance() -> instanciate() name change

In PR #49693 verb uses of instance() were changed to instantiate(), but the change was half-baked for Mono build. Two errors were introduced:

in editor tools in GodotIdeManager.cs a reference to constructor of class Instance was changed erroneously,
in glue extensions in PackedSceneExtensions.cs a change in naming was accidentaly omitted.

Both cause mono version of godot with glue enabled to not build.

Thanks!


net - mgmt build pipelines should switch to unified pipelines

Currently there are instructions for publishing mgmt libraries at https://github.com/Azure/adx-documentation-pr/blob/master/engineering/adx_netsdk_process.md#signing-and-publishing-nuget-packges, that process currently has a build pipeline and a release pipeline that gets auto triggered. However with the new unified pipelines we can put those into the same pipeline which will make finding the artifacts easier in the instructions. Currently the instructions say to find the deployments under the summary of the build however when the DevOps UI changes for unified pipelines those don't currently show up on the build summary page, I"m not sure if that is a DevOps bug or a design change but in either case I think switching to a unified pipeline will make this process much simpler.
I would do that for both "net - mgmt" and "net - mgmt - pr".
cc @erich-wang @shahabhijeet @mitchdenny

I'll address it when I have time

From a quick look at the pipeline, it looks like this was done so I'm going to close this out as stale.   Please feel free to reopen if this is still needed.


question about fine tuning falcon

Hello
I ran the falcon classification task uaing the following command:
!python falcon_classification.py --lora_r 64 --epochs 1 --dropout 0.1 # finetune Falcon-7B on newsgroup classification dataset
Upon inspecting the model, I find that many of the layers  are full rank and not the lower rank
from transformers import AutoModelForCausalLM
model = AutoModelForCausalLM.from_pretrained("experiments/classification-sampleFraction-0.99_epochs-1_rank-64_dropout-0.1/assets")

Here is a screenshot showing this

Is this expected behavior ?

Great question @charlesmartin14 .
When you do model = AutoModelForCausalLM.from_pretrained("experiments/classification-sampleFraction-0.99_epochs-1_rank-64_dropout-0.1/assets"), the base model, i.e., Falcon-7B gets loaded, without the LoRA config.
So yes, what you see in the screenshot is expected behaviour.
In order to load the low rank matrices, you will have to also do:
model = PeftModel.from_pretrained(model, peft_model_id),
where peft_model_id= "experiments/classification-sampleFraction-0.99_epochs-1_rank-64_dropout-0.1/assets"
The above line will load the low rank matrices trained via LoRA.
Following is the full sequence of steps:
    config = PeftConfig.from_pretrained(peft_model_id)

    bnb_config = BitsAndBytesConfig(
        load_in_4bit=True,
        bnb_4bit_quant_type="nf4",
        bnb_4bit_compute_dtype=torch.float16,
    )

    model = AutoModelForCausalLM.from_pretrained(
        config.base_model_name_or_path,
        quantization_config=bnb_config,
        trust_remote_code=True,
    )
    model = PeftModel.from_pretrained(model, peft_model_id)
    model.eval()

Let me clarify just tp be sure
"The above line will load the low rank matrices trained via LoRA."
I am looking to load only the LoRA delta/update and not the full model + LoRA

Hi @charlesmartin14,
It seems like AutoModelForCausalLM.from_pretrained does load in LoRA weights by default.

As seen from above, the loaded model has both the Base Model layers, as well as LoRA layers.
To inspect LoRA weights, you can use the nifty utility function get_peft_model_state_dict.
Here's an example following your code:
from peft import get_peft_model_state_dict

for layer_id, layer in get_peft_model_state_dict(model).items():
    print(layer_id, layer.shape)

>>>
transformer.h.0.self_attention.query_key_value.lora_A.weight torch.Size([64, 4544])
transformer.h.0.self_attention.query_key_value.lora_B.weight torch.Size([4672, 64])
transformer.h.0.self_attention.dense.lora_A.weight torch.Size([64, 4544])
transformer.h.0.self_attention.dense.lora_B.weight torch.Size([4544, 64])
...

As you can see from the output, each LoRA matrices B and A are of correct shapes for a rank-64 decomposition.

Closed due to inactivity.


Stop record when  Storage is almost full

I would much appreciate it if you could integrate this to the next update.
Stop logging when storage is at 70% filled.

We are working on this for a future release. Also looks like this pull request contains other things than changing the logging. Closing.


Add script to cache provider artifacts for faster startup.

This should be run during template docker image creation and will greatly increase yaml template startup.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @Polber


Compatibility with PowerMock

This issue was raised before (https://github.com/nhaarman/mockito-kotlin/issues/9), and few things changed since then.
Currently it's possible to use PowerMock with kotlintest and mockito-kotlin using this setting:
@RunWith(PowerMockRunner::class)
@PowerMockRunnerDelegate(KTestJUnitRunner::class)
@PrepareForTest(ContextCompat::class)
class TestSpec: BehaviorSpec() {
....
            PowerMockito.mockStatic(ContextCompat::class.java)
            Mockito.`when`(ContextCompat.checkSelfPermission(any(), any())).thenReturn(PackageManager.PERMISSION_GRANTED)

Currently PowerMock works well with mockito2, since version 2.10.0 of mockito, so I used the following gradlde dependencies:
dependencies {
    testImplementation "io.kotlintest:kotlintest:2.0.5"
    testImplementation "com.nhaarman:mockito-kotlin:1.5.0"
    testImplementation "org.mockito:mockito-core:2.13.0"
    testImplementation "org.powermock:powermock-api-mockito2:2.0.0-beta.5"
    testImplementation "org.powermock:powermock-module-junit4:2.0.0-beta.5"
}

Note that I still need to include mockito-core:2.13.0 since powermock works good with mockito 2.10 and above, but the mockito in mockito-kotlin is 2.8.9.
Is it possible to upgrade mockito-kotlin to use the latest mockito?

This will come naturally in a new release. In the mean time, you can depend on the specific version yourself.


chromium: 60.0.3112.90 -> 61.0.3163.79 [security]

Motivation for this change
security update, please backport
CVE-2017-5111
CVE-2017-5112
CVE-2017-5113
CVE-2017-5114
CVE-2017-5115
CVE-2017-5116
CVE-2017-5117
CVE-2017-5118
CVE-2017-5119
CVE-2017-5120
includes https://github.com/NixOS/nixpkgs/pull/28857
Things done
Building right now, at about 60%

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Force pushed with another patch, necessary for building. Build at 80% now.

With the two commits atop 17.09, the builds failed for me at the very end:
cp: missing destination file operand after '/nix/store/xh6cymx3facbnr8r932cl7ynbl7m8hwa-chromium-61.0.3163.79/libexec/chromium/swiftshader/'
Try 'cp --help' for more information.
builder for ‘/nix/store/j1fhcws9hflg2dsam2zczg0k095fmv42-chromium-61.0.3163.79.drv’ failed with exit code 1
cannot build derivation ‘/nix/store/w214xwrpaffvaqr6wgy8bdcn4bgdsbjg-chromium-61.0.3163.79.drv’: 1 dependencies couldn't be built

swiftshader apparently got integrated recently. trying a build without swiftshader, as per latest patch ...

pushed another installPhase fix, running another build ...

pushed fix as per feedback
starting another build ...

Nice :)

Hmm, I tried to port this to 17.03 but I failed.  WIP: https://github.com/vcunat/nixpkgs/commits/p/chromium-17.03
It's theoretically possible that the commit works but I'm repeatedly hitting the Ryzen bug in the particular case.  You can try on your machine.

@bendlas @aszlig I think this change is breaking enable_swiftshader = true; support:
cp -v "$buildPath/swiftshader/"*.so "$libExecPath/swiftshader/"

It looks like the swiftshader-related .so files are only generated when enable_swiftshader = true;, that's why you had to remove the cp (it defaults to false).
But now swiftshader files are never copied, even when they are generated. So headless WebGL in Chromium is broken on NixOS right now.
I have a build running to confirm whether it is as I say.

Interesting. That must have been the time, the flag was defaulted to false. I deleted those lines, because the .so files had vanished from the build and made the cp fail. In hindsight, it would have made more sense to insert a conditional instead, or even look for the flag ...
Thanks for digging this one out. I hope your build succeeds!

I have a build running to confirm whether it is as I say.

@bendlas Can confirm, the build succeeds with enable_swiftshader = true; and cp -v "$buildPath/swiftshader/"*.so "$libExecPath/swiftshader/" reintroduced, and this makes SwiftShader based WebGL work again.
The graphics look a little off/corrupted when swiftshader is used vs my normal GPU, but that's an upstream problem, not a nixpkgs problem.
So I think we should thange the derivation to copy exactly when enable_swiftshader is given.
I'll file a new issue to track this.


Add theming variable for show/hide component's background-color

Feature Request
Description
As of now, show/hide component's background-color is set as transparent. But if in future it is changed to something else, it will break us (as there is no theming variable). And hence, we want show/hide component's background-color to be themable.

We don't see the background-color being changed in the foreseeable future. If it does change, we'll release a major version bump for this package with and upgrade guide to help migrate to the new version without introduction breaking changes in your app unknowingly.


Work out a heuristic for determining the charset

From https://github.com/MyIntervals/PHP-CSS-Parser/pull/688#issuecomment-2330767391:
In essence: have some heuristic to determine the input encoding (BOM, @charset, try a few common charsets and pick the first one that doesn’t produce errors), then convert to UTF-8 and, from that point on, all the tokens of interest to us will be ASCII-only and can be parsed using regular string functions.

We can follow what browsers do: https://developer.mozilla.org/en-US/docs/Web/CSS/@charset

We can follow what browsers do: https://developer.mozilla.org/en-US/docs/Web/CSS/@charset

Yes good idea. Though browsers have a Content-Type header that may include a charset= specifier that we don’t have. But we can definitely follow what browsers do absent charset=.

Though browsers have a Content-Type header that may include a charset= specifier that we don’t have (as well as the resolved charset of the referring document).

We can use the value provided to Settings::withDefaultCharset in its place.


Add support for python3.6

API output is treated as bytes, son when defining header variable with string causes python 3 to get a utf-8 string which cannot be concatenated with a bytes object. The simplest solution in my opinion is to declare set header as a byte string.

@comtom Although I think this solves the problem of bytestrings when using this package in a Python 3 environment, it's not a very graceful way of adding Python 3 support. I think it would be a larger project to completely port this over (involving something like python-future http://python-future.org/overview.html). I can put this on my list of things to do when I have time.
Assuming this string/bytestring compatibility is the only area that has issues, a likely better solution is to change how .tostring() is being called throughout the package and make it compatible for both Python 2 & 3. To do this, it looks like we can use a call to .decode() in place of encoding="utf-8" inside the .tostring() method. See SO article discussion here https://stackoverflow.com/a/48671499. Thoughts?

.decode() was my first approach, but I discovered that a byte-string is expected when calling toString() method. I didn't test extensively this solution on python2.7 but it seems to work fine. On python3.6 I did tested a lot more and couldn't find any case that could break it.
I know it looks "hacky", but it is the recommended way for maintaining backwards compatibility
Maybe we can accept this approach now and then implement a more clean solution and include some tests.

Thanks for doing the research - I agree this is a good enough workaround for now until the entire bundle is updated for full Python 3+ support. Appreciate the help.


Stop using basic aer internal private attributes

Summary
This commit fixes the usage of internal only explicitly private
attributes of basicaer's job class. These look they were used to
manually create a job id which was manually set ahead of time despite
still being a random uuid and then launching a simulation from that
constructed job object. Which is both the incorrect order to run a
simulation (runs generate jobs, not the other way around) but also
served no functional purpose. This commit removes this as this is a
blocker for Qiskit/qiskit-terra#5128 which is upgrading the basic aer
provider to use the latest versioned provider interface which removes
all of those private methods and also moves to a synchronous execution
model.
Details and comments
This needs to be included in the next 0.9 release to unblock Qiskit/qiskit-terra#5128 (I had to make the same change in that PR to fix basic aer usage with the migrated code in terra)

From what I recall the code has been around quite some time. It was more or less a copy of the code from the simulators that created and submitted a job. It was done so we could skip doing the qobj validation, which the simulators used to do, which used to take a significant amount of time. At least this is my best recollection. If it can be simpler now its fine.

Yeah, the simulator run path used to actually do validation 3 times, once in qobj generation via marshmallow, once in jsonschema, and then once again in the simulator code, but even once was pointless and didn't accomplish anything (since it was all internal to qiskit). It was a real mess and a complete waste of electricity. I removed all of that a long time ago once I saw how awful it all was.
Most of this code (in the migrated terra side version) will need to be removed anyway since it doesn't serve a purpose with the new backends interface (and there not being a qobj anymore), but that's a later refactor.


Remove disabling the obstacle detection in the startup plan

Need to discuss with Jonathan if they are going to use this more often or if we want to test it during a CM. Based on this, we may need to remove the set check obstacle to false command in the startup plan.

@kbrowne15 any update on this?

We are still testing this in CMs and it will probably be quite a while if at all before we actually turn obstacle detection on for good. Should we close this issue for now?

Sure sounds good.


Native implementations using function pointers not updated with the closure changes

With the recent changes to closures, now the first parameter of a lambda function is a map<any|error> value. Native functions which makes use of parameters of a lambda function should take this into account.
Originally reported in Slack: https://ballerina-platform.slack.com/archives/C47EAELR1/p1555461582018400

This was fixed for remove() in tables with PR #15059. Need to verify other std lib functions using lambda functions don't have the same issue.

This requires verification from standard library side.

We are not using in the StdLib modules.


Annoying popup

I changed the ip of my router from <IP_ADDRESS> to <IP_ADDRESS>.  Now I'm constantly getting a popup saying that my antminers at address 192.168.4.* aren't responding, but they have been changed to the new router ip.  The app doesn't seem to want to forget about the old ip pool

Can you please post the details of the popup - e.g. screenshot & copy & paste the error message?

my Ip address is <IP_ADDRESS>

You can edit the NetworkDevicesConfiguration.xml file found in ~/.config/MultiMiner on Linux and OS X and found in %appdata%\MultiMiner on Windows. Remove the old entries, save, and re-launch MultiMiner.

Closing issue due to lack of response. Please reopen if issues persist.


popovers: Migrate user_card_popover module to Tippy.

Description:
This PR is part of our ongoing effort to migrate from Bootstrap-based popovers to Tippy. I'm planning to split this migration into some steps:
Plan:

[ ] Migrate user_sidebar_popover.
[ ] Migrate message_user_card_popover.
[ ] Migrate user_card_popover.

Checklist for manual testing:

Keyboard Navigation
Positioning
Visual Appearance
Dark/Light Theme Compatibility
Scrolling Behavior
Narrow/Wide Screen Rendering

Fixes part of #23632.

I tested the user group info popover, and it works for me!

This changes the behavior in really short windows: after this PR, the top (rather than the middle) of the popover is shown when there isn't enough room. That seems better than what we have in main.

I made it about halfway through reading this. I think the overall approach for that first half looks reasonable; posted a handful of comments. I think a good next step would be to pull out a corrected version of the "extract user_card_popover.js" commit and the related non-functional renaming prep stuff as its own prep PR -- that should merge fairly quickly and let us shrink the size of this for future reviews considerably.

I merged the little prep commits as the series ending with 472ef3d890c8943fb01323eb9d1fa3da46288aa4

In the stream settings > subscribers UI, I noticed that the popover doesn't open from a partially hidden row at the very bottom edge of the table. I don't see this issue on CZO.

In the stream settings > subscribers UI, I noticed that the popover doesn't open from a partially hidden row at the very bottom edge of the table. I don't see this issue on CZO.

That's some weird behavior we've seen more than once. The issue is with Tippy. It's putting the "data-reference-hidden" attribute on elements that aren't actually hidden, like the one at the bottom. I tried debugging this in tippy.esm.js and looked through tippyCreate.ts, but no luck.

I've tackled the feedback as best as I can. I've also opened follow-up issues to get rid of the popover-content and popover-title classes (#26821) and to fix the problem Alya spotted (#26823).
One more thing left to do is get user_card_popover.test.js to pass. It's based on Bootstrap popovers, and I couldn't make it work. The test only checks the avatar URL in the popover, so maybe we can just test the load_medium_avatar function and skip all the mocking in that test; I'm not sure.

The test failure is in the user_card_popover.js test, needing a new stub. Looking at the test, I feel like it is at the wrong abstraction layer, and simply mocks too much to really check much, so I elected to just delete the test.
In the future we can write a test that just tries to verify the data calculations for what parameters to pass to the rendering function after some refactoring, if we feel it warranted.

OK I pushed back here with a few changes to tests to preserve coverage on people.js that happened to be mainly through user_card_popover.test.js, then deleting that test file, and the rest of this PR, which looks good aside from the new comment I added to explain this somewhat arcane bit without duplicating the existing explanation:
diff --git a/web/src/user_card_popover.js b/web/src/user_card_popover.js
index ffae7defff..d2d7781db4 100644
--- a/web/src/user_card_popover.js
+++ b/web/src/user_card_popover.js
@@ -546,6 +546,7 @@ function toggle_sidebar_user_card_popover($target) {
         "left",
         undefined,
         (instance) => {
+            /* See comment in get_props_for_popover_centering for explanation of this. */
             $(instance.popper).find(".tippy-box").addClass("show-when-reference-hidden");
         },
     );

I added a handful more commits to remove the Bootstrap tooltip/popover library, and clean up most of the legacy popovers.js module. I'll start a chat.zulip.org thread about the remaining handful of functions.

Updates:

In the Migrate all user card popovers to Tippy commit, the class that was being used in the web/e2e-tests/user-status.test.ts to verify that the user card was open ("user_popover") was removed. Updated the class in the test to "user_popover_email" in that same commit, which is a class that is part of the user_card_popover_content.hbs template.

Diff:
diff --git a/web/e2e-tests/user-status.test.ts b/web/e2e-tests/user-status.test.ts
index ea9c2a1da6..8f2251176e 100644
--- a/web/e2e-tests/user-status.test.ts
+++ b/web/e2e-tests/user-status.test.ts
@@ -18,7 +18,7 @@ async function open_set_user_status_modal(page: Page): Promise<void> {
         {},
         menu_icon_selector,
     );
-    await page.waitForSelector(".user_popover", {visible: true});
+    await page.waitForSelector(".user_popover_email", {visible: true});
     // We are using evaluate to click because it is very hard to detect if the user info popover has opened.
     await page.evaluate(() =>
         document.querySelector<HTMLAnchorElement>(".update_status_text")!.click(),


test: codecov opt

Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Update boost version on readthedocs

Version on the monodrive- client says  boost_1_73_0 but the documentation says Boost 1.65.1

Closed with #243

Closed with #243

Closed with #243

Closed with #243


Section to include the Ctype extension check?

Hi
In which section I should include the extension ctype (Character type checking)?
Do you think better create a section "type-related" or include ctype in string section?

I think it should go into string as the ctype functions deal with strings.

Ok, I will implement this.
After this, we will have all obligatory requirements extensions to install symfony framework. (http://symfony.com/doc/current/reference/requirements.html#required)
Regards!


Pending translations

Describe the bug
Missing translations that require changes in the code:

"Learn to Earn" button
"Price for 100,000 sats:" and date labels in chart - price screen
"digg your way through these lessons and earn" (earn screen)
"To unlock, answer the question:"(earn screen)
"pay this business" (map screen)
RootNavigator Titles:

Settings
Transaction History

Default earn transactions (copyBitcoin, whoControlsBitcoin, ..). Not sure how processing descriptions affects app performance but if is not possible we need to add it in the backend
"You have been logged out" the key is in i18n files but is not used in the alert
"XXXX is your verification code fore Bitcoin Beach Wallet" SMS (backend)
"on_us" types of transaction in payment details
"User not found" I guess is a backend response, if you can not parse it then maybe we need to add a key/code to the errors thrown by backend (I prefer the key because allow to use directly against i18n component).
"To" and "From" (transactions in Main screen)
"a few seconds ago" - "XX minutes ago" (transactions in Main screen)
in iOS the back button is using "Primary" but I guess is not a missing translation. Maybe we just need to use "common.back"
"set a note" placeholder in receive screen
"Hey there! I need some help with Bitcoin Beach Wallet" whatsapp default message

The translations that did not require changes in the code were updated in the PR https://github.com/GaloyMoney/galoy-mobile/pull/112
@nicolasburtey we need to define which term will be used in the app Sats or Satoshis (including push notifications) and how we will manage backend related translations

Remaining after PR #117 :

Default earn transactions (copyBitcoin, whoControlsBitcoin, ..). Not sure how processing descriptions affects app performance but if is not possible we need to add it in the backend
"XXXX is your verification code fore Bitcoin Beach Wallet" SMS (backend)
"on_us" types of transaction in payment details
"User not found" I guess is a backend response, if you can not parse it then maybe we need to add a key/code to the errors thrown by backend (I prefer the key because allow to use directly against i18n component).
"To" and "From" (transactions in Main screen)

The last bullet is done on the backend here

closed in favor of https://github.com/GaloyMoney/galoy/issues/384


fix(backend): URL Reader readTree gets rid of archive directory name dependency

Closes #4230
This PR updates the URL Reader's readTree behavior to NOT expect the name of the top level directory contained inside the Tarball/Zip. readTree should work without it. The motivation of this change is to get rid of GitHub/GitLab/etc.-specific URL readers having to guess the name of the directory, thus leading to bugs in different scenarios.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)

@Rugvip Would love your 👀 on this! 🙏

@Rugvip Would love your 👀 on this! 🙏

@backstage/maintainers Another gentle ping that we should have this before tomorrow's release. 🙏

@backstage/maintainers Another gentle ping that we should have this before tomorrow's release. 🙏

Thanks! Yeah, will wait.

Thanks! Yeah, will wait.


Support connecting to Unix domain socket from Python

gRPC channels can be created from a URI, not just a host:port pair. This is currently used for connecting to Unix domain sockets.
This feature is not usable from Python, because grpc.beta.implementations.insecure_channel (and secure_channel) take the host and port as separate arguments (with the port as a number), and that seems to be the only supported way of creating channels.
Both functions immediately combine the host/port into a single string, and passing a URI there seems to work as expected. So the real problem is deciding what the interface should look like.

+1, also looking for this as well

+1. For now I'll just use port number "0" and construct my server with "unix:/tmp/socket:0" as socket path.
This discrepancy between the client and server APIs are quite annoying.

I believe that this has been fixed since the integration of pull request 5701 - am I missing anything?


Review allow_equivalents: all design decision for BERO

to avoid having to hack OBI, ENVO and NCIT:
ERROR Equivalence: <http://purl.obolibrary.org/obo/NCIT_C179199> == <http://purl.obolibrary.org/obo/NCIT_C1127>
ERROR Equivalence: <http://purl.obolibrary.org/obo/ENVO_01001479> == <http://purl.obolibrary.org/obo/ENVO_01001784>
ERROR Equivalence: <http://purl.obolibrary.org/obo/OBI_2100024> == <http://purl.obolibrary.org/obo/OBI_0003012>
ERROR Equivalence: <http://purl.obolibrary.org/obo/ENVO_01001483> == <http://purl.obolibrary.org/obo/ENVO_00010504>
ERROR Equivalence: <http://purl.obolibrary.org/obo/OBI_0002781> == <http://purl.obolibrary.org/obo/OBI_0002783>

This occurs during the prepare_release step :
sh run.sh make prepare_release IMP=false

We decided to skip the checks for inferred equivalences. Alternatively we could remove the offending axioms from the ontologies 1 by 1.
Thoughts @cmungall ?

This is an example how you get explanations:
sh run.sh robot explain -i ../../bero.owl --axiom "'Omacetaxine' EquivalentTo 'Omacetaxine Mepesuccinate'" -o explain.md

Can you also share the output of ls -l imports/*_import.owl to see how large the imports are?

explain.md: When I ran the command above, I got:
ERROR Input ontology contains 1 triple(s) that could not be parsed:
 - <https://www.wikidata.org/wiki/Q2306597> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> _:genid2148965403.

INVALID FORMAT ERROR unknown format: md
For details see: http://robot.obolibrary.org/errors#invalid-format-error

and when I replaced the .md to .txt , I still got the same error.
Imported files:
-rw-r--r--  1 HHegde  staff  504065193 May 26 13:10 src/ontology/imports/chebi_import.owl
-rw-r--r--  1 HHegde  staff     147574 May 26 12:58 src/ontology/imports/ecocore_import.owl
-rw-r--r--  1 HHegde  staff     147857 May 26 13:27 src/ontology/imports/edam_import.owl
-rw-r--r--  1 HHegde  staff    6583353 May 26 13:11 src/ontology/imports/envo_import.owl
-rw-r--r--  1 HHegde  staff  137010643 May 26 13:13 src/ontology/imports/go_import.owl
-rw-r--r--  1 HHegde  staff   11500194 May 26 13:28 src/ontology/imports/mesh_import.owl
-rw-r--r--  1 HHegde  staff    3760208 May 26 12:57 src/ontology/imports/mop_import.owl
-rw-r--r--  1 HHegde  staff   18048921 May 26 13:10 src/ontology/imports/ncbitaxon_import.owl
-rw-r--r--  1 HHegde  staff  344918918 May 26 13:27 src/ontology/imports/ncit_import.owl
-rw-r--r--  1 HHegde  staff    7701400 May 26 12:58 src/ontology/imports/obi_import.owl
-rw-r--r--  1 HHegde  staff      76487 May 26 12:58 src/ontology/imports/omo_import.owl
-rw-r--r--  1 HHegde  staff     676248 May 26 13:27 src/ontology/imports/pato_import.owl
-rw-r--r--  1 HHegde  staff    5853306 May 26 12:58 src/ontology/imports/po_import.owl
-rw-r--r--  1 HHegde  staff   12063663 May 26 12:59 src/ontology/imports/to_import.owl

Released files:
-rw-r--r--  1 HHegde  staff<PHONE_NUMBER> May 26 14:40 ../../bero.owl
-rw-r--r--  1 HHegde  staff   425830749 May 26 14:40 ../../bero.obo
-rw-r--r--  1 HHegde  staff<PHONE_NUMBER> May 26 14:40 ../../bero.json
-rw-r--r--  1 HHegde  staff<PHONE_NUMBER> May 26 14:39 ../../bero-full.owl
-rw-r--r--  1 HHegde  staff   425830778 May 26 14:39 ../../bero-full.obo
-rw-r--r--  1 HHegde  staff<PHONE_NUMBER> May 26 14:39 ../../bero-full.json
-rw-r--r--  1 HHegde  staff        2547 May 26 14:39 ../../bero-base.owl
-rw-r--r--  1 HHegde  staff         537 May 26 14:39 ../../bero-base.obo
-rw-r--r--  1 HHegde  staff        1695 May 26 14:39 ../../bero-base.json

Explain: check here http://robot.obolibrary.org/explain
Instead of -o write --explanation

@matentzn sometimes ELK has trouble giving explanations when it's the result of mutual subClassOf relations. Could that be the case here?

defin. possible! Thank you!

@hrshdhgd in this case, i dont know how to debug this ticket without major efforts. We will also not learn why https://github.com/NCI-Thesaurus/thesaurus-obo-edition/issues/76 which is a pity, since @cmungall cannot reproduce it.

https://douroucouli.wordpress.com/2018/09/04/debugging-ontologies-using-owl-reasoning-part-2-unintentional-entailed-equivalence/
On Fri, May 27, 2022 at 5:47 AM Nico Matentzoglu @.***>
wrote:

@hrshdhgd https://github.com/hrshdhgd in this case, i dont know how to
debug this ticket without major efforts. We will also not learn why
NCI-Thesaurus/thesaurus-obo-edition#76
https://github.com/NCI-Thesaurus/thesaurus-obo-edition/issues/76 which
is a pity, since @cmungall https://github.com/cmungall cannot reproduce
it.
—
Reply to this email directly, view it on GitHub
https://github.com/berkeleybop/bero/issues/3#issuecomment-1139587020,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAMMONODEQ62BXMGEI25XLVMC77PANCNFSM5XAXR5XQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


turn off spelling suggestions in search field on fairs

I think it’s unlikely that you would want this anywhere. I used the Safari developer console to add the autocomplete="off" and autocorrect="off" attributes to the input, which finally disabled it in Safari.
I think it was specifically autocorrect, but it's probably best to just disable all options: http://davidwalsh.name/disable-autocorrect
So, this should be moved to force.

@katarinabatina do we want this disabled on non-embedded force as well? when it's viewed in iPad safari, or on a computer?

yeah I would think so
[A.] Katarina Batina
Artsy http://artsy.net/
<EMAIL_ADDRESS>            @katarinabatina <https://twitter.com/katarinabatina>

253 225 5812
On Fri, Apr 24, 2015 at 11:53 AM, Laura Brown<EMAIL_ADDRESS>wrote:

@katarinabatina https://github.com/katarinabatina do we want this
disabled on non-embedded force as well? when it's viewed in iPad safari, or
on a computer?
—
Reply to this email directly or view it on GitHub
https://github.com/artsy/eigen/issues/396#issuecomment-95975270.

ok, can you make a force issue?

I'm going to close since the force issue is closed.


[SPARK-35080][SQL] Only allow a subset of correlated equality predicates when a subquery is aggregated

What changes were proposed in this pull request?
This PR updated the foundNonEqualCorrelatedPred logic for correlated subqueries in CheckAnalysis to only allow correlated equality predicates that guarantee one-to-one mapping between inner and outer attributes, instead of all equality predicates.
Why are the changes needed?
To fix correctness bugs. Before this fix Spark can give wrong results for certain correlated subqueries that pass CheckAnalysis:
Example 1:
create or replace view t1(c) as values ('a'), ('b')
create or replace view t2(c) as values ('ab'), ('abc'), ('bc')

select c, (select count(*) from t2 where t1.c = substring(t2.c, 1, 1)) from t1

Correct results: [(a, 2), (b, 1)]
Spark results:
+---+-----------------+
|c  |scalarsubquery(c)|
+---+-----------------+
|a  |1                |
|a  |1                |
|b  |1                |
+---+-----------------+

Example 2:
create or replace view t1(a, b) as values (0, 6), (1, 5), (2, 4), (3, 3);
create or replace view t2(c) as values (6);

select c, (select count(*) from t1 where a + b = c) from t2;

Correct results: [(6, 4)]
Spark results:
+---+-----------------+
|c  |scalarsubquery(c)|
+---+-----------------+
|6  |1                |
|6  |1                |
|6  |1                |
|6  |1                |
+---+-----------------+

Does this PR introduce any user-facing change?
Yes. Users will not be able to run queries that contain unsupported correlated equality predicates.
How was this patch tested?
Added unit tests.

Test build #137374 has started for PR 32179 at commit 26a6e97.

Test build #137379 has started for PR 32179 at commit c504288.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41952/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41956/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41952/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41956/

cc @maropu @viirya @dongjoon-hyun
This is a long-standing correctness issue, not sure if we should fail 2.4.8 RC2 or not.

Is it a regression in 2.4?

Test build #137379 has finished for PR 32179 at commit c504288.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41956/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137379/

Is it a regression in 2.4?

No, it's a long-standing bug.

Got it. Thank you for pinging me, @cloud-fan .

The fix looks small and not complicated. I'm fine to drop RC2 if you think it is better to include the fix in 2.4.8 too.

BTW, is it necessary to be a subquery with aggregation? From the fix, I cannot tell how aggregation affects it.

Test build #137374 has finished for PR 32179 at commit 26a6e97.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137374/

BTW, is it necessary to be a subquery with aggregation? From the fix, I cannot tell how aggregation affects it.

SPARK-17348 provides some explanations on why aggregate is causing the issue. Basically, when a correlated predicate is pulled up, all attributes from the inner query will be added as GROUP BY columns. When the mapping is not one-to-one, for instance a + b = outer(c) in the example above, both a and b will be added as group by columns, and the count(*) will count the number rows for each combination of (a, b), instead of (a + b).
https://github.com/apache/spark/blob/7ff9d2e3eec514962e891420dbb3961e85826612/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala#L878-L901
Pull up correlated predicates through Aggregate:
https://github.com/apache/spark/blob/3e218ade9cf6becc5de8b20a4385e345021a509d/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala#L258-L264

Could you check the relevant UT failures, @allisonwang-db ?
org.apache.spark.sql.AnalysisException
[info]   Correlated column is not allowed in a non-equality predicate:

Test build #137401 has started for PR 32179 at commit f722d03.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41977/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41977/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41977/

Test build #137401 has finished for PR 32179 at commit f722d03.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137401/

retest this please

Test build #137413 has started for PR 32179 at commit f722d03.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41989/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41989/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41989/

Test build #137413 has finished for PR 32179 at commit f722d03.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137413/

Test build #137437 has started for PR 32179 at commit 56e4090.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42012/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42012/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42012/

Test build #137437 has finished for PR 32179 at commit 56e4090.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137437/

@allisonwang-db can you sync your branch to the latest master to Github Actions build can run properly?

Test build #137498 has started for PR 32179 at commit 03f4487.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42072/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42072/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42072/

Test build #137498 has finished for PR 32179 at commit 03f4487.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137498/

The last one seems to fail with the relevant UT. Is it a flakiness? Let me retrigger the tests.
org.apache.spark.sql.SubquerySuite.SPARK-35080: correlated equality predicates contain only outer references

Retest this please

Test build #137537 has started for PR 32179 at commit 03f4487.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42111/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42111/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42111/

Test build #137537 has finished for PR 32179 at commit 03f4487.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137537/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42134/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42134/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42134/

Test build #137601 has started for PR 32179 at commit 652b854.

Test build #137601 has finished for PR 32179 at commit 652b854.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137601/

Hm, the failed test is subquery-related:

org.apache.spark.sql.SubquerySuite.SPARK-35080: correlated equality predicates contain only outer references

Can you take a look?

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42181/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42181/

Test build #137652 has finished for PR 32179 at commit 84f91b2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137652/

thanks, merging to master/3.1/3.0/2.4!

During backport, I found that https://issues.apache.org/jira/browse/SPARK-31225 is not in 2.4, which makes the error message a bit confusing. @viirya shall we backport https://issues.apache.org/jira/browse/SPARK-31225 to 2.4 as well? cc @yaooqinn

Only affects explain output? Then looks good to me.

LGTM

During backport, I found that https://issues.apache.org/jira/browse/SPARK-31225 is not in 2.4, which makes the error message a bit confusing. @viirya shall we backport https://issues.apache.org/jira/browse/SPARK-31225 to 2.4 as well? cc @yaooqinn

@yaooqinn can you help to create the backport PR? I think we just need to update the golden files and the new tests added in this PR.

@yaooqinn please ping me if you create the backport PR. Thanks.

OK, I will try to raise a PR today (+08:00)

Hello @SparkQA @cloud-fan  @viirya @yaooqinn   @allisonwang-db , do you know if the configuration was introduced, the reason why im asking is because we have some pipelines and they are failing after the upgrade to 2.4.8 from 2.4.5
This is really critical to me
We started to see errors as follow:
Exception in thread "main" org.apache.spark.sql.AnalysisException: Correlated column is not allowed in predicate (outer(p2.NAME) = replace(disc_model_anchor.dis_name, 'CPF', 'ADM')):
Aggregate [first(amount#3835, false) AS first(amount)https://github.com/apache/spark/pull/12269]

Hi @adelaocampos this is indeed a breaking change. Such query patterns are blocked because can potentially lead to incorrect results, and there is no configuration to allow the behavior. The check is very strict right now. If you don't mind sharing your query, we can see if there is a way to bypass the correlated subquery check here.


split data_model_json_fields.go into multiple files

Why make this pull request?
split data_model_json_fields.go into multiple files
What has changed
[Summarize what components of the repo is updated]
[Link to xdb-apis/xdb-golang-sdk PRs if it's on top of any API changes]

API change link: ...
Golang SDK change link: ...
Server Component 1: ...
Server Component 2: ...

How to test this pull request?
[If writing Integration test in Golang SDK repo, please provide link to the pull request of Golang SDK Repo]
[It's recommended to write integration test in Golang SDK repo, and enabled in this server repo first,
without enabling in the SDK repo. After this PR is merged, enable and merge the integration test in the SDK repo]
[Alternatively if Java/other SDK repo is preferred, then just test locally against server PR.
After the server PR is merged, merge the integration test in the SDK repo]
Checklist before merge
[ ] If applicable, merge the xdb-apis/xdb-golang-sdk PRs to main branch
[ ] If applicable, merge the xdb-apis/xdb-apis PRs to main branch
[ ] Update go.mod to use the commitID of the main branches for xdb-apis/xdb-golang-sdk

Actually, maybe the file names can start with “data_models_***” ? Or put them all under a new package? It will be easier to find with others

make sense, I'll create a new package


Postgres Non Super User Connection

Describe the bug
I created a database on RDS with postgres. When I connect with the admin user created by AWS everything works fine. When I created another user so I don't use the admin user, I get:
Exception in thread "main" org.postgresql.util.PSQLException: ERROR: permission denied for database prisma
Even though I can connect with that user to that DB and run queries against default$default
To Reproduce
Steps to reproduce the behavior:
Create AWS RDS Postgres and create another user with following commands:
CREATE ROLE services_role;
GRANT USAGE ON SCHEMA "default$default" TO services_role;
GRANT ALL PRIVILEGES ON ALL TABLES IN SCHEMA "default$default" TO services_role;
GRANT ALL PRIVILEGES ON ALL SEQUENCES IN SCHEMA "default$default" TO services_role;
create user test with encrypted password 'test';
GRANT services_role TO test;
Now I can connect to the db with that user however prisma running on Heroku gives me the error stated in the description.
Expected behavior
I should be able to connect.
Screenshots
Versions (please complete the following information):

Connector: Postgres
Prisma Server: Installed on heroku, not sure how to check
prisma CLI: prisma/1.27.4
OS: OS X High Sierra
other dependencies:  None

Additional context
Add any other context about the problem here.

Hi @smojtabai
You will also need to provide that access to the management schema in addition to the default$default schema as prisma will require that schema to store the migration metadata and other additional information

@pantharshit00 great find.


cChocoSource

it appears this code was a copy and paste of the cChocoInstallPackage resource.
When attempting to add a source it tries to locate a nuget xml file which obviously it won't find as adding a source does not require this.

I know this is an old one - can't see anything in the code for this. Can you confirm this is still an issue and provide the relevant logs?

Going to go ahead and close this now. We can always reopen it later when we have more information.


Allow non secure (no SSL certificate) connections

Can you please allow connections to the piHole instances that don't use SSL certificates. Right now I'm getting an "Session Error: The certificate for this server is invalid." I can only press "OK" and then after a second it gets back to this message.

I'm having the same issue...

Interesting it works for me. Are you still having problems?


[error] [default] Error sending telemetry FetchError: unable to verify the first certificate

Problem: Github copilot chat works properly, but the line completion is reporting error and not working.
Network Env: Corporate LAN with VPN, but coworkers copilot work just fine under same network.
OUTPUT MESSAGE
2024-10-08 12:58:39.422 [info] [certificates] Removed 1 expired certificates 2024-10-08 12:58:40.147 [info] [fetcher] Using Helix fetcher. 2024-10-08 12:58:40.147 [info] [code-referencing] Public code references are enabled. 2024-10-08 12:58:40.154 [info] [auth] Successfully authenticated 2024-10-08 12:58:41.615 [error] [default] Error sending telemetry FetchError: unable to verify the first certificate     at fetch (/home/xx/.vscode/extensions/github.copilot-1.236.0/node_modules/@adobe/helix-fetch/src/fetch/index.js:99:11)     at processTicksAndRejections (node:internal/process/task_queues:95:5)     at cachingFetch (/home/xx/.vscode/extensions/github.copilot-1.236.0/node_modules/@adobe/helix-fetch/src/fetch/index.js:288:16)     at rae.fetch (/home/xx/.vscode/extensions/github.copilot-1.236.0/lib/src/network/helix.ts:93:22) {   type: 'system',   _name: 'FetchError',   code: 'UNABLE_TO_VERIFY_LEAF_SIGNATURE',   errno: undefined,   erroredSysCall: undefined
Test RESULT :   Developer: Github Copilot Chat diagnose
GitHub Copilot Chat

Extension Version: 0.21.0 (prod)
VS Code: vscode/1.94.0
OS: Linux

Network
User Settings:
  "github.copilot.advanced": {
    "debug.useElectronFetcher": true,
    "debug.useNodeFetcher": false
  }

Connecting to https://api.github.com:

DNS ipv4 Lookup: <IP_ADDRESS> (0 ms)
DNS ipv6 Lookup: Error: getaddrinfo ENOTFOUND api.github.com
Electron Fetcher (configured): HTTP 200 (86 ms)
Node Fetcher: HTTP 200 (577 ms)
Helix Fetcher: HTTP 200 (602 ms)

Connecting to https://api.githubcopilot.com/_ping:

DNS ipv4 Lookup: <IP_ADDRESS> (1 ms)
DNS ipv6 Lookup: Error: getaddrinfo ENOTFOUND api.githubcopilot.com
Electron Fetcher (configured): HTTP 200 (240 ms)
Node Fetcher: Error: unable to verify the first certificate
Helix Fetcher: Error: unable to verify the first certificate

Documentation
In corporate networks: Troubleshooting firewall settings for GitHub Copilot.
**TRIED SOLUTION **
Reintall vscoede/extensions
Reinstall CA-certifacates
Contacted to IT, but since there are no other similar report, the issue should be a local PC problem.

This repository does not cover inline completions and instead just chat (I know it is a bit confusing, apologies for that). It is recommended you file an issue over at https://github.com/orgs/community/discussions/categories/copilot or contact GitHub support


Always Expanded ?

Hello. Is it possible to set parent to be always expanded and prevent for collapsing ?

In the upcoming 2.0.0 release (currently on master) you should be able to override shouldItemViewClickToggleExpansion to return false, and then set your own click listener that calls toggleExpansion only on parent views you want to expand/collapse

Edited the above to reflect recent changes, let me know if that doesn't work for you. You can check out the snapshot while we work on releasing 2.0.0

Hi Paul,
I'm using version 2.0.3 but the method shouldItemViewClickToggleExpansion() has been deprecated. What is the method replaced it?
Thanks.

Hi @rinlv,  shouldItemViewClickToggleExpansion should still be available in 2.0.3:
https://github.com/bignerdranch/expandable-recycler-view/blob/master/expandablerecyclerview/src/main/java/com/bignerdranch/expandablerecyclerview/ViewHolder/ParentViewHolder.java#L140
Are you not finding it in your project?

Oh, my mistake, thanks you very much. It's mean, i have override method shouldItemViewClickToggleExpansion on my ParentViewHolder class


DBZ-6225 Treat BOOLEAN as TINYINT(1) consistently

https://issues.redhat.com/browse/DBZ-6225
The snapshot phase uses the JDBC driver metadata to resolve the column mappings; however, during streaming, if a CREATE TABLE ddl statement is used, the column mapping is based on that of the DDL, which was not treating a BOOLEAN column as TINYINT(1); instead, it treated the column as BOOLEAN, which is incorrect for MySQL.

About the test changes let's take the test method paseBooleanDefaultValue.  If we create such a table using the following SQL and then check the contents of the table we'll find that the column a contains 9 rather than true.
CREATE TABLE test (a boolean not null default '9');
INSERT INTO test values ();

The test changes effectively mirror what we expect in the table and mirror what we ultimately would be emitted as part of the change event since BOOLEAN is technically a synonym for TINYINT(1), which isn't necessarily 0/1 or false/true.

Superseded by referenced PR.


v1. Namespace is forbidden: User cannot list resource "namespaces" in API group.

Any idea why would this happen? Seems like the Go app can't list the namespaces. What can I do in this case?
It is configured for AWS ECR the same registry works fine on minikube, but in dev cluster, it doesn't.
Here is the error:
`time="2020-10-21T05:10:45Z" level=info msg="Starting up..."
time="2020-10-21T05:10:45Z" level=info msg="Using AWS Account: 81xxxxxxxx"
time="2020-10-21T05:10:45Z" level=info msg="Using AWS Region: ca-central-1"
time="2020-10-21T05:10:45Z" level=info msg="Using AWS Assume Role: arn:aws:iam::81xxxxxxx:role/xxxxxxxxxx"
time="2020-10-21T05:10:45Z" level=info msg="Refresh Interval (minutes): 60"
time="2020-10-21T05:10:45Z" level=info msg="Retry Timer: simple"
time="2020-10-21T05:10:45Z" level=info msg="Token Generation Retries: 3"
time="2020-10-21T05:10:45Z" level=info msg="Token Generation Retry Delay (se
ERROR: logging before flag.Parse: E1021 05:11:37.436054       1 reflector.go:199] github.com/upmc-enterprises/registry-creds/vendor/k8s.io/client-go/tools/cache/reflector.go:94: Failed to list *v1.Namespace: namespaces is forbidden: User "system:serviceaccount:kube-system:default" cannot list resource "namespaces" in API group "" at the cluster scope`
It is on an infinite loop outputting the error above.

I am also encountering this when running in minikube.
minikube version: v1.14.2
commit: 2c82918e2347188e21c4e44c8056fc80408bce10

Running into this with K3s in an on-premise setup as well..

You have to allow the serviceaccount that you are using to list some resources from kubernetes otherwise it will fail like yours it's failing. It is failing because doesnt have the enough permissions to be able to do some actions (in th is case list all the namespaces). You can define new permissions or create anoñther serviceAccount to avoid editing the default one that comes from Kubernetes.

What is the permissions that this app need? Do you assume that it should run as admin?

What is the permissions that this app need? Do you assume that it should run as admin?

No that's wrong, you should'nt run as admin. In my case I added the permissions:
namespace: list, get, watch
secrets: get, list, watch, create, update, patch and delete
serviceaccount: all the permissions.
Remember that the app list all namespaces, and updates or creates secrets to that namespace with the secrets to allow that namespace to dowload the images from the private repository

@Keralin What do you mean "in your case"? Are there different use cases?

Sorry for the delay, I just added to this PR with the files you will need. https://github.com/upmc-enterprises/registry-creds/pull/103

i only configured the secrests.yml and deployment.yml for AWS ECR and got the following error in the pod
 Failed to list *v1.Namespace: namespaces is forbidden: User "system:serviceaccount:kube-system:default" cannot list resource "namespaces" in API group "" at the cluster scope

@ac5tin I think you are missing the api_groups = "" permission


GH-545 restrict default geo to local

Prevent creation of the default endpoint if we are using  the LoadBalanced strategy  and the lb-attribute-geo-code label on a gateway does not match the default geo in the policy spec

Build images job failing for odd reason, created an issue for it https://github.com/Kuadrant/kuadrant-operator/issues/580

Verified locally that the DNSPolicy tests are still working:
./bin/ginkgo -p --procs 10 --focus "DNSPolicy" -tags integration ./controllers/...
Running Suite: Controller Suite - /home/mnairn/go/src/github.com/kuadrant/kuadrant-operator/controllers
=======================================================================================================
Random Seed:<PHONE_NUMBER>

Will run 20 of 147 specs
Running in parallel across 10 processes
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•••••••••SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•••••••••••

Ran 20 of 147 Specs in 43.668 seconds
SUCCESS! -- 20 Passed | 0 Failed | 0 Pending | 127 Skipped

Ginkgo ran 1 suite in 50.270835805s
Test Suite Passed

Don't like merging with failing tests but needs must.


Some types incompatibility in user attributes

https://www.traccar.org/forums/topic/oshibka-v-pochtovom-otpravlenii-cherez-atributy-javalangboolean/
Mail attributes must be strings in backend https://github.com/tananaev/traccar/blob/master/src/org/traccar/notification/NotificationMail.java
But in the web client they have different types https://github.com/tananaev/traccar-web/blob/master/web/app/store/UserAttributes.js
boolean is boolean
What will we do? I think making them all strings on web side will decrease users ease of use.

Of course the right thing is to allow boolean value, but we also need to think about backward compatibility.


Mixtral GPTQ with TP=2 not generating output

In the new vllm 0.3 release mixtral with gptq does not generate any output anymore. Loading the model works fine, when calling the llm.generate it gets stuck.
from vllm import SamplingParams
import torch

model_name = "TheBloke/Mixtral-8x7B-Instruct-v0.1-GPTQ"
llm = vllm.LLM(model=model_name, quantization="gptq", dtype=torch.float16, tensor_parallel_size=2, max_model_len=16000, revision="gptq-4bit-32g-actorder_True", gpu_memory_utilization=0.75, enforce_eager=False)
llm.generate(formatted_prompt[0], sampling_params=SamplingParams(temperature=0.1, max_tokens=100))

Currently using:

python 3.11.*
vllm-0.3.0+cu123 -> tried also the current git repo
cuda 12.3

The worker seems to be stuck in the llm_engine.step() function / _run_workers call.

Can you try adding disable_custom_all_reduce=True? Just ruling out a possibility.

I have the same issue with AWQ and this config:
llm = LLM(
    model="TheBloke/Mixtral-8x7B-Instruct-v0.1-AWQ",
    tensor_parallel_size=2,
    gpu_memory_utilization=0.75,
    max_model_len=256,
    disable_custom_all_reduce=True,
    enforce_eager=True
)

This works fine for me:
llm = LLM(
    model="TheBloke/Mixtral-8x7B-Instruct-v0.1-GPTQ",
    quantization="gptq",
    dtype=torch.float16,
    tensor_parallel_size=2,
    max_model_len=16384,
    revision="gptq-4bit-32g-actorder_True",
    gpu_memory_utilization=0.75,
    disable_custom_all_reduce=True,
    enforce_eager=True)

I have the same issue with AWQ and this config:
llm = LLM(
    model="TheBloke/Mixtral-8x7B-Instruct-v0.1-AWQ",
    tensor_parallel_size=2,
    gpu_memory_utilization=0.75,
    max_model_len=256,
    disable_custom_all_reduce=True,
    enforce_eager=True
)

I think there is an issue with that awq quant specifically, try using this one: https://huggingface.co/casperhansen/mixtral-instruct-awq
it worked for me! just be sure to set enforce_eager=True like you did before

@hanzhi713 Thanks! Works with the disable_custom_all_reduce command

@SebastianBodza Which GPU model are you using?

@hanzhi713 2x RTX 3090 with Cuda 12.3

@SebastianBodza Can you try this potential fix? https://github.com/vllm-project/vllm/pull/2760
Remember to recompile vLLM from source by pip install -e .

Still not working for me. I don't know if it is relevant, but I have to run NCCL_P2P_DISABLE=1 to load the model

I think there is an issue with that awq quant specifically, try using this one: https://huggingface.co/casperhansen/mixtral-instruct-awq

it worked for me! just be sure to set enforce_eager=True like you did before
For me, this also resolved the issue

Still not working for me. GPUs stuck at 150W usage and not returning. I don't know if it is relevant, but I have to run NCCL_P2P_DISABLE=1 to load the model

@SebastianBodza What error do you observe when you don't set NCCL_P2P_DISABLE=1? This might be relevant since if you can't let NCCL use P2P, custom all reduce shouldn't use it too, and custom all reduce can't function without P2P.

When not setting NCCL_P2P_DISABLE=1 the Model loading freezes. Just like in  https://github.com/vllm-project/vllm/issues/1801

@SebastianBodza I see. Then it's expected that it will also freeze with custom all reduce enabled. The underlying cause might be like #1801 in which the driver is buggy.

@hanzhi713 Thanks for the fixes. I am not too sure if they were necessary, however SinanAkkoyun seems to approve them, sorry for that. Could we add a check for P2P and implement a fallback with disable_custom_all_reduce enabled or throwing an error?
For me the vllm version 0.3.0 is working with nvidia drivers 535.154.05.
Anybody relying on the official nvidia stream for rhel 9 just downgrade.

@SebastianBodza Hi, I didn't approve any changes, I just approved that the other awq model provided + enforce_eager=True works for me, does it for you?

@hanzhi713 Thanks for the fixes. I am not too sure if they were necessary, however SinanAkkoyun seems to approve them, sorry for that. Could we add a check for P2P and implement a fallback with disable_custom_all_reduce enabled or throwing an error?
For me the vllm version 0.3.0 is working with nvidia drivers 535.154.05. Anybody relying on the official nvidia stream for rhel 9 just downgrade.

@SebastianBodza Unfortunately, I don't think there's a good way to detect that. We already checked P2P support via cuda runtime API (NCCL likely uses the same check), and the check passed. Basically, the problem is that the runtime reports that it supports P2P, but the underlying implementation is buggy.

I ran in to this with exllamav2 as well, the maintainer added a fix that just did a quick check to see if it was safe to move tensors between devices, and used that to determine if it was safe. The Nvidia drivers seem to have consistent issues on 4090s properly reporting this info.
https://github.com/turboderp/exllamav2/blob/1c67f97f3d2a968605a9c31ab791a05c85bb7879/exllamav2/compat.py#L10
https://github.com/turboderp/exllamav2/issues/85


LDT updates to allow compilation with gfortran 10+

Description
Issue #843 discusses a number of syntax errors found by gfortran 10 and 11, which were reproduced on Discover.  Generally the bugs fall into three categories:

At least one instance where an optional argument is used by a Fortran subroutine that does not have an interface (explicit, or created via a module); this is illegal in ISO Fortran.
The readgfrac and readlaisai function calls are made with inconsistent argument lists, which causes newer gfortran to give a cryptic syntax error.
The use of binary integer constants with parameters in readSMOPSsmObs is illegal under ISO Fortran; instead these constants must be used in DATA statements.

The fixes fall into five categories:

Update gfrac and lai/sai Fortran read codes to use the same number of arguments (2).
Update the gfrac and LAI/SAI C codes to remove unnecessary arguments.
Update FLAKE code to move read_FLake_lakedepth into FLAKE_paramsMod, allowing use of optional argument.
Modified readSMOPSsmObs to move usage of binary integer constants to DATA statements.
Minor editorial changes along the way.

Test compilations were made with GFORTRAN 10 and 11, plus existing official modules lisf_7_intel_19_1_3_304 and lisf_7_gnu_9.3.0_gmao_openmpi_4.0.4.  No runtime tests were performed.
Note:  Issue #843 also implicates LIS (and possibly LVT), but this pull request is restricted to LDT.
Testcase
Recommend testing this code with existing unit test suite.

I just realized this fix is oriented toward master.  Should I redo this for support/lisf-public-7.3?

I'm replacing this pull request with PR #851, which targets support/lisf-public-7.3.


Simplify and optimize wasmi codegen

Due to historical reasons the wasmi codegen that converts from Wasm bytecode to its internal wasmi bytecode still performed many checks that have already been covered by the wasmparser based Wasm validation.
This PR eliminates all or most of those unnecessary duplicate checks for some reasonable speedups in translation time.
Locally I was able to see roughly 15% speedup in the translation benchmark.
In detail this PR

Removes the emulated ValueStack during translation time and replaces it with a glorified ValueStackHeight counter.
Simplifies the LocalsRegistry to no longer deal with local variable types so that it also became a glorified counter.
Removes tons of type checks during translation time. These are unnecessary since the Wasm validation already performs them.


Sample Resource System Design

Definitely! This actually ties into something else: the poor state of the sampler resource system. > You'd really want a good way to store your parser state (so you can avoid reparsing everything repeatedly like you said).
I started trying to revamp it, but ran into issues and kind of gave up. I'll write you a better response in a few days (please ping me if you don't hear back). Even before you said that, I was already thinking with your Dioxus experience probably would have some good ideas for how to solve that (assuming you'd be interested in helping with/contributing to that kind of thing).

@KerfuffleV2 I'm not entirely sure what your goals are with the sampler resources system. There are two main approaches I have seen within different projects:

Trait/tuple approach: Axum uses this approach with the FromRef. It makes it so that middleware (or samplers in a chain) can check at compile time if the resource has been inserted. It allow samplers to check if dependancies have been added before the chain to verify that the sampling order is correct
AnyMap approach: Dioxus uses a Rc<RefCell<anymap>> to store context state. llm-samplers could use a similar approach to allow any state to be inserted into the map. There could be functions that insert the correct type for common resources like the previous tokens. This could be more flexible because the types are erased so you don't need to deal with any generics, but it cannot verify the sampling order at compile time

Really sorry I didn't follow up on that. Approach 2 is the one I was looking at:

but it cannot verify the sampling order at compile time

I think we might be talking about different things though. By "resources" I mean the resources the sampler needs access to. For example the logits (RW access), the RNG (RW access), the last tokens (RO access). Right now those resources are hardcoded and if you want to give a sampler access to some other kind of resource (just for example, a classifier-free guidance sampler would need access to the CFG logits and maybe some other params from it).
Some samplers may need RW access to multiple types of resource at the same time. For example Mirostat manipulates/filters the logits and also uses RNG to pick a token (it calls the rand distrib sampler internally).
That's already getting a little complicated because we're talking about needing mutable access to multiple things at the same time, but if it's at all possible I also really want to avoid having to copy data around. For example, with long context models that support 128K context size, that last tokens resource could have 100K+ items in it. There are also models with very large vocab. LLaMA models have a pretty small vocab (you probably already know this) at only 32K entries, but there are some models with 250K+ vocab. So that means there will be 250K logits items before filtering.
So what I really want to do is access a reference for those things instead of making the user actually copy them for sampler use, but that means mutable access to multiple slices at the same time. And that's basically where I ran into trouble and didn't manage to make further progress... So I got distracted and wandered off.
I stuck what I had so far in a branch: https://github.com/KerfuffleV2/llm-samplers/tree/resource-experiment - Note, this is incomplete and doesn't even compile currently.
Any doesn't normally support lifetimes but from what I found out, doing this is actually legal: https://github.com/KerfuffleV2/llm-samplers/blob/b670b508f2d23ee605a980fecc69ad533702b3cd/src/resource.rs#L62-L89
And we could say that whatever resources get type-erased have to have a lifetime at least however long. The problem is trying to access multiple mutable ones simultaneously, like the RNG state + logits.

That does seem sound. https://docs.rs/better_any/latest/better_any/index.html might be useful as a more general approach to Any with lifetimes

To get multiple references to elements in the hashmap, you can use https://rust-lang.github.io/hashbrown/hashbrown/struct.HashMap.html#method.get_each_mut in the hashbrown library (this is the library that backs std's hashmap)

https://docs.rs/better_any/latest/better_any/index.html might be useful as a more general approach to Any with lifetimes

Thanks! I didn't find that one when I was looking around. I don't mind adding relatively lightweight dependencies like that.

To get multiple references to elements in the hashmap, you can use https://rust-lang.github.io/hashbrown/hashbrown/struct.HashMap.html#method.get_each_mut

This looks really interesting. But:
"This method is available only if the nightly feature is enabled."

This looks really interesting. But:
"This method is available only if the nightly feature is enabled."

I think I linked to the wrong docs. That is the version that rust uses. I think that nightly feature lines up with std's version of nightly. The crates.io version of the crate has that feature on stable: https://docs.rs/hashbrown/0.14.2/hashbrown/hash_map/struct.HashMap.html#method.get_many_mut

Oh, thanks! Sorry, I should have done a little more digging there. I've started work on v0.0.7 in #9, however that one probably won't have the resource system overhaul.
It involves one pretty large change, removing type variables from the samplers and just always using u32 for token ids and f32 for logits. This massively, massively simplifies basically everything and also makes the interface easier to use.
I also found a weird bug in the Mirostat2 sampler where it was sampling rand_distrib twice. That probably won't have a huge effect on performance but I believe you were using Mirostat2 in your chain from the other issue so maybe it'll be a tiny bit faster now.


csv: use png for kepler icon

fix #68
the base64 is generated via
base64 -w 0 -i kepler.png

verified by https://operatorhub.io/preview thanks @husky-parul

doesn't seem to be the fix


NullPointerException when running

java -jar ~/.dtf/binaries/GenerateAIDL-1.0.jar -i system-apps/test.apk -d
Loading DEX into object.
Creating DexDbHelper.
About to process DEX...
Writing: test.aidl
Exception in thread "main" java.lang.NullPointerException
at com.jakev.genaidl.App.processDex(App.java:198)
at com.jakev.genaidl.App.main(App.java:320)

Fixed: https://github.com/jakev/GenerateAIDL/commit/37fa0f62212caffbd39bc99856e67bd29ef2a167


Optimize animations

This PR is created to optimize the AnimaionMixer _process_animation.
void AnimationMixer::_process_animation(double p_delta, bool p_update_only) {
	_blend_init();
	if (_blend_pre_process(p_delta, track_count, track_map)) {
		_blend_capture(p_delta);
		_blend_calc_total_weight();
		_blend_process(p_delta, p_update_only);
		_blend_apply();
		_blend_post_process();
		emit_signal(SNAME("mixer_applied"));
	};
	clear_animation_instances();
}

Benchmarking methods:
I made some benchmarks of how long each of these methods takes for one 3D model, using animation_tree.
Some explanations to understand the results.
Units of measurement: usec.
is_process = _blend_pre_process
weight = _blend_calc_total_weight
Master:

You can see here that the _blend_process, _blend_pre_process and _blend_calc_total_weight methods take the most time.
I will show the results that are in this PR.

You can see that blend_process has improved by 30%, blend calc_total_weight has improved by 15% and _blend_pre_process has improved by 50%.
Real project benchmarks:
Master:
Project FPS: 56 (17.85 mspf)
Project FPS: 56 (17.85 mspf)
Project FPS: 56 (17.85 mspf)
Project FPS: 56 (17.85 mspf)
Project FPS: 55 (18.18 mspf)
Project FPS: 55 (18.18 mspf)
Current PR:
Project FPS: 68 (14.70 mspf)
Project FPS: 69 (14.49 mspf)
Project FPS: 66 (15.15 mspf)
Project FPS: 66 (15.15 mspf)
Project FPS: 68 (14.70 mspf)
Here you can see a pretty good + 22%. Note that #92554 also improves animation performance, which with this PR adds 40% to performance.
How to test:
Here #92554 in the benchmark section is Animation_test.zip project. After opening, fps will be output to the console.
What was done:
Animation:

For enums, the size was reduced from 4 to 1 byte.
Added the get_tracks method.

AnimationTree:

I made track_map a pointer in order not to copy maps.

AnimationMixer:

The first is to use getptr instead of has + operator[].
The second is to use int count = a->get_track_count(); In order to store in a register the number of iterations.
Used the method already created in animation.h to take the array. const Vector<Animation::Track *> tracks = a->get_tracks();
In the method post_process_key_value I cache whether there is GDVIRTUAL_CALL. That is, there will be only 1 check per _blend_process call.

Probably closes: #92693

I would say that by itself it won’t be enough but with the pr you mentioned it might close it as it reduces it cost a lot more(40% as you stated when combining it )
Either way this is great job and hopefully it gets merged quick in 4.4  along with your other great optimizations pr’s.

Either way this is great job and hopefully it gets merged quick in 4.4 along with your other great optimizations pr’s.

There are no compatibility problems or any major innovations here, this is just an optimization of what already exists.
So I think this would work well for 4.3 as well

Animation does not support multi-core

@WOLFxxxxxx It has nothing to do with this PR you are talking about. This PR is an optimization for several allocations in the blending process and does not address multithreading. That will have to be done in another PR. Please confine the discussion here to the topic of the implementation that this PR does.

I think it's time to merge it with 4.4, no conflicts related to this PR have been found

Thanks!


Migrate extension to the Camunda Community Hub

Hello! I hope today finds you well! My name is Rin Oliver, and I'm a Technical Community Builder at Camunda. I'm opening this issue today to ask if you might be interested in migrating this extension over to the Camunda Community Hub?
We'd love to hear your feedback on how we might improve the overall community extension development process for maintainers and contributors moving forward, and learn more about what you'd like to see from this initiative in the future.
If migrating this extension something you'd be interested in, I can send you the instructions for doing so via email, or whatever communication method works best for you. If you are no longer able to maintain this extension, if it is migrated to the Hub I would be more than happy to add a lifecycle badge to it indicating that the project is in need of a new maintainer.
I'm also more than happy to schedule a call and talk over this in more detail if that would be preferable to you, for whenever best suits your schedule over the next few weeks.
Thank you so much for your time. I look forward to hearing from you.

Hi @aabouzaid! As this has been migrated to the community Hub, I'll go ahead and close this issue! Thanks so much! :)

@celanthe Thanks Rin :+1:


hello-world-nginx 404 error

Installed app on OSX 10.10.3 using this command: brew cask install kitematic
Setup application
Created new Docker account
Clicked the 'Create' button on the first item on the Recommended list which is 'hello-world-ngix'
ISSUE: failed to get image from the hub (see error message in screenshot)

Everything worked fine when creating a debian container

Thanks for the issue,
If you click on the Docker CLI button and try this on the command line:
docker pull kitematic/hello-world-nginx
does it work?

I have the same problem as the OP. I can login to Docker site from the Kinematic app. When I run the Docker CLI and
docker pull kitematic/hello-world-nginx
I get:
bash-3.2$ docker pull kitematic/hello-world-nginx
Pulling repository kitematic/hello-world-nginx
FATA[0000] Get https://index.docker.io/v1/repositories/kitematic/hello-world-nginx/images: dial tcp: lookup index.docker.io on <IP_ADDRESS>:53: read udp <IP_ADDRESS>:53: connection refused

It seems like you're using a local DNS server, maybe try:
echo "<IP_ADDRESS>" > /etc/resolv.conf

Ok, works now when I turned off DNScrypt and was using OpenDNS IPs, and put in <IP_ADDRESS> as a fallback.

Good to hear. Closing this issue for now. Please re-open if you are still running into this problem.
Thanks!


5pm-a-search-by-course-name

This pull request closes #33. This branch adds a page and form where a user can enter a course name, and start/end quarter and receive the respective information. The branch also adds a new controller for the back end to interact with the archived course repository (as well as adds respective testing for new files added in the front and back end).

Ok, so there seems to be a bug here:

As you can see when we do this sequence of operations, we get CS130A still in the table.  Kobe and I tried debugging this for a while and had no luck.   So I'm going to merge this even with the known bug in place, and perhaps the W21 class will have a bug to work on.

at least 20 points for this... possibly 30 or 40 depending on what ends up happening with the bug.  I'm hopeful that after everything else is merged, we can come back and try to fix this.

Oh no @pconrad and I both reviewed at the exact same time and Conrad merged, would you mind making a separate PR to address these?

Andrew's comments were fixed and resolved in PR #81


Update PluginInstall signature for consistency

This make PluginInstall a little bit more consistent with the rest of the api code base 🐮:

Make enable and acceptAllPermissions optional
Adds PrivilegeFunc to make it ask for login if the daemon error is an   HTTP Unauthorized (just like image pull/push).
Add a AcceptPermissionsFunc and remove Reader/Writer from the   signature. The idea is to not force interactive input/output and let   the user of the API defines the behavior for accepting permissions.

/cc @thaJeztah @runcom @tiborvass @calavera @stevvooe @icecrime
Related PR : https://github.com/docker/docker/issues/23570
🐸
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>

:clap: LGTM

LGTM
A few comments around intent of NoEnable.

@stevvooe Updated with Disabled

LGTM

LGTM


Let sidebar uppercase more than dvc in labels made from slugs

Fixes #3601

Last Q. There's also the opposite feature i.e. some words are kept lower case, like and. Where is that defined? Thanks

Ah thanks for the info. Will mention in https://github.com/iterative/gatsby-theme-iterative/issues/17


Define blockspecification more generic and in seperate file

Blockspecification will be used to recognise the specific blocks from the text and also to get te appropriate text for the reverse operation.
remarks

[ ]  separate definition of block converters from their actual usage (separate files ?)
[ ]  construct blocks object from JSON specification of blocks

optionaly:

[ ] probably you can also use some helper functions for the block specification, so that repetitions are avoided:

probably you can derive the number of arguments from the number of placeholders

think about alliasses e.g. gf and greenflag

problems solved with predicate:
"set pen color to %1"
"length of %1"
"%1 contains %2?"
"%1 of %2"
"change %1 effect by %2"
"set %1 effect to %2"

done


Added option to turn off conversion to relative path

Fixes #66
This option is helpful when you need to use aliased path for template or style.

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   96.42%   96.42%
=======================================
  Files           1        1
  Lines          28       28
  Branches        5        5
=======================================
  Hits           27       27
  Misses          1        1

Impacted Files
Coverage Δ

index.js
96.42% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2dc887...f3de85b. Read the comment docs.

This is so useful! Allows using webpack aliases to resolve the problem compatibly. Please merge :)

@TheLarkInn ping.