How to use this in Objective-C ?

I have imported @import KUIPopOver; in .h file still I'm unable to call showPopover(sourceView: UIVIew) method.

@karthikmandava7
not yet support objective-c,
I will release Objetive-c to work. If you need work, send me PR ^-^

@Kofktu Please let me know once done with support of Objective-C. Thanks.

@karthikmandava7
I'll have to check out a little more about how you can use extensions in Objective-C with Swift.


\cdots definition wrong when amsmath loaded after unicode-math

From Herbert:
\documentclass{article}
\usepackage[no-math]{fontspec}
\usepackage{unicode-math}
\usepackage{amsmath}
\makeatletter
% \def\@cdots{\mathinner{\unicodecdots}}
\makeatother
\setmathfont{XITS Math}
\begin{document}
$\cdots$
\end{document}

Uncomment the redefinition to fix. Unicode-math uses \mathinner{\cdots} here, which leads to infinite recursion in this case since \cdots in turn uses \@cdots.

Oh dear! Very sorry for the slow followup!!


Document LF code highlighting with pygments

This adds a new page in the Tools section of the handbok. We can use this page for documenting tools that can be used for documenting LF code. This PR adds a description of the pygments plugin that I created for code highlighting. We can also add a description of our docusaurus setup here.

The main benefit is that it can be part of an automated flow. Also, pygments can produce SVG and HTML output. I added both points to the description.


Add git_depth get parameter

Closes #106
Adds the git.depth get parameter that - when set to a positive integer - causes the resource to use git pull --depth N to create a shallow clone of the git repo.
I've used the git.depth name for two reasons:

it matches with the name the same parameter had in https://github.com/jtarchie/github-pullrequest-resource
if more git-related parameter will be added in the future, they can use the same "namespacing" git.*

I have very little experience with Go, so no offense taken for any comment about the style :)

@itsdalmo sure thing 👍 I've renamed the parameter (and added a note in the README about migrating from the older resource)

@itsdalmo I've rebased on master and now I can't run task generate anymore. I edited the generate files manually, hoping that the CI would work instead, but Travis seems to be having the exact same issue.
Do you know what it could be?
flag provided but not defined: -o
Usage of counterfeiter:
  -generate
    	Identify all //counterfeiter:generate directives in the current working directory and generate fakes for them
flag provided but not defined: -o

Hey @gabro - Seems like Counterfeiter has made a new release that broke our use of it here. I've made #111 to fix the problem, once that is merged you'll need to rebase your branch off the new master (or just merge in the changes from master).

Sure! I'll subscribe and rebase once it's merged 👌 thanks

It's merged now, along with a few other minor (unrelated) changes 👍

Rebased


Reinstate download and save dialogs for MakeCode

Download dialogs only show on the code page, but the save dialogs are shared (much like the tour).

As discussed on chat this does seem to have built despite what GH says.


Add spellcheck target

Do not merge
Adds spellcheck target.
Currently just counts the number of words classed as spelling mistakes, hopefully this number is the same on all platforms (looks like the Linux package will be an older hunspell version for Travis CI, by default) and will gradually go down.

Hunspell doesn't deal with multiple dictionaries independently (state is affected by the order they are read), which makes dictionary tests too complex.


Adjust colour scaling on RMS map in validation plot

Currently the colour map limits for the RMS panel in the validation plot are hardcoded. Now that EMU like data are also being processed these limits do not make sense.
We draw these from the data directly, taking 16th and 84th percentiles against the RMS map.

Addressed by #133


(PUP-10015) Add support for arbitrary equality to pip provider

Without this patch the pip provider doesn't correctly parse pip freeze
output specified with arbitrary equality.
https://www.python.org/dev/peps/pep-0440/#arbitrary-equality
This is manifest with triple === separating the package name from the
package version, e.g.
$ pip freeze | grep pytz
pytz===2012f
By not correctly parsing this output, puppet tries to continually
install this package on each run.
The patch updates the regex to handle arbitrary equality.

This was already approved in the PR targeting master.

@joshcooper
I am having this issue.
$python_packages = ['argparse', 'regex', 'prometheus_client']
  package { $python_packages:
    ensure   => installed,
    provider => pip3,
}

causes this every time:
Notice: /Stage[main]/Monitoring/Package[argparse]/ensure: created
Notice: /Stage[main]/Monitoring/Package[prometheus_client]/ensure: created


write code that will turn standardized crimes into viz/text summary

This is blocked by #23

top _ types of crimes (per year) (per month potentially) to show as data visualizations


Update README.md

Removed documentation for manual builds since this is now automated.

Summary
Explain the goal of this change and what problem it is solving. Format this cleanly so that it may be used for a commit message, as your changes will be squash-merged.
Test Plan
How did you test these changes? Please provide the exact scenarios you tested in as much detail as possible including commands, output and rationale.

Codecov Report

Merging #956 (65b94f7) into develop (e472383) will decrease coverage by 0.32%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #956      +/-   ##
===========================================
- Coverage    59.53%   59.21%   -0.33%
===========================================
  Files           41       42       +1
  Lines         5689     5720      +31
===========================================
  Hits          3387     3387
- Misses        1865     1896      +31
  Partials       437      437

Impacted Files
Coverage Δ

util/diff.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e472383...65b94f7. Read the comment docs.


buttons are messed up in Issue at Notes section

Hello,
i found a messed up buttons at existing notes (comments) in a issue.

The icon with bin is edit button. etc.
Redmine version is 4.0
Can you reproduce that please?

Check the latest release 😉

Its fixed :) Thank you very much. btw v2.0 is amazing :)


Realtime FastAdapter sort feature

Hello, i have read this : https://github.com/mikepenz/FastAdapter/issues/51 , truly understand Sort() of arrays, but in some cases the fast adapter should not be clear() , and add new sorted array of items to it, i just wonder if something can be make to support this feature in realtime when we add an item, when delete or when move ... This is very important when some app have really big list of items and they modify the content of adapter. Thanks

Hi,
you can provide your own item list implementation to any model adapter. https://github.com/mikepenz/FastAdapter/blob/develop/library-core/src/main/java/com/mikepenz/fastadapter/adapters/ModelAdapter.java#L42

@FabianTerhorst , any documentation for that or how to use in more detail ? Thank you
For example we have a AbstractItem with three data : Title, Signal, Capacity ect ....
Just need when make changes to adapter to have the ability to automatic sort by : signal for example or anything else.
How can we do that ?

Its basically the interface for the implementation that is managing the items list. You could for example add an own add implementation and call own calculated adapter callbacks. There is currently no documentation for it, thats true. Your implementation would look similar to the default one but without the default behavior you don't want to have. https://github.com/mikepenz/FastAdapter/blob/develop/library-core/src/main/java/com/mikepenz/fastadapter/utils/DefaultItemListImpl.java

I understand that and really thanks for your explanation. Can you help a little to understand it better if you can...
So i have implemented :

FastItemAdapter<SampleItem> fastadapter;
class SampleItem extends AbstractItem<SampleItem, SampleItem.ViewHolder>

in the SampleItem class there are some variables like :
Name, Signal, Width , etc....
How to make some modification to this to be able to make the adapter to sort the items inside it by Signal e.x ? So when new items added, deleted or moved, the adapter to be able to resort they ?
It would be really great help if someone provide help for this, because i have writed my self hundred of lines to manually make this but sometime it not working or produce bugs like : https://github.com/mikepenz/FastAdapter/issues/694

There is already an implementation that is sorting the items after adding moving ect. https://github.com/mikepenz/FastAdapter/blob/develop/library-core/src/main/java/com/mikepenz/fastadapter/utils/ComparableItemListImpl.java

And you won't be able to use FastItemAdapter for that, better use the FastAdapter and add the model adapters to it.

I see, so this is how i use it :
This is the item class :
private class SampleItem extends AbstractItem<SampleItem, SampleItem.ViewHolder> {

        String capabilities;
        String signal;
        String security;

        public SampleItem() {
        }

        SampleItem(String ssid, String kanali, String frekuenca, String gjeresia_e_kanalit, String bssid, String capabilities, String signal, String security) {
            this.capabilities = capabilities;
            this.signal = signal;
            this.security = security;
        }

        //The unique ID for this type of item
        @Override
        public synchronized int getType() {
            return 0;
        }

        //The layout to be used for this type of item
        @Override
        public synchronized int getLayoutRes() {
            return R.layout.wifi_scanner_view_list;
        }

        //The logic to bind your data to the view
        @Override
        public synchronized void bindView(@NonNull ViewHolder viewHolder, @NonNull List<Object> payloads) {
            //call super so the selection is already handled for you
            super.bindView(viewHolder, payloads);
            //viewHolder.setIsRecyclable(false);
            //bind our data
            //set the text for the name
            viewHolder.capabilities.setText(capabilities);
            viewHolder.signal.setText(signal);
			viewHolder.security.setText(security);
            }

        }

        //reset the view here (this is an optional method, but recommended)
        @Override
        public synchronized void unbindView(@NonNull ViewHolder holder) {
            super.unbindView(holder);
            holder.capabilities.setText(null);
            holder.signal.setText(null);
        }

        //Init the viewHolder for this Item
        @NonNull
        @Override
        public synchronized ViewHolder getViewHolder(@NonNull View v) {
            return new ViewHolder(v);
        }

        //The viewHolder used for this item. This viewHolder is always reused by the RecyclerView so scrolling is blazing fast
        class ViewHolder extends RecyclerView.ViewHolder {
            TextView capabilities;
            TextView signal;
            TextView security;

            ViewHolder(View view) {
                super(view);
                capabilities = view.findViewById(R.id.wifi_capabilities);
                signal = view.findViewById(R.id.signal_text);
                security = view.findViewById(R.id.wifi_security);
            }
        }
    }

FastAdapter :
private FastItemAdapter<SampleItem> fastadapter;
and for adding item i use :
fastadapter.add(new SampleItem("TKIP","-45","WPA");
can you help how to modify the class to automatic sort by signal please, sorry my low English, Best regards.

FastAdapter<SampleItem> fastadapter;
fastAdapter.addAdapter(0, new ModelAdapter<SampleItem>(itemListImpl, interceptor));
``´

@FabianTerhorst , Without making any modification in the SampleItem class ? Just to call this method ?
And how we build itemListImpl or interceptor because no documentation for that i'm sorry ...

you have to store the reference of the ModelAdapter somewhere ofc to add item to it. No modification of the items is required for that.  An sample for the interceptor is https://github.com/mikepenz/FastAdapter/blob/b77477ec100e27e31ffba16dade9fa5031e5cb6c/app/src/main/java/com/mikepenz/fastadapter/app/ModelItemActivity.java#L51 for example, but in your case the interceptor will return the value without nay changes. The item list impl is the class i posted before
https://github.com/mikepenz/FastAdapter/blob/develop/library-core/src/main/java/com/mikepenz/fastadapter/utils/ComparableItemListImpl.java

This isn't stackoverflow.

@FabianTerhorst , I just make a joke, i know that no need for clarification, i just need when add item, delete or move in real time (not added to array first) to make the adapter automatically sort those damn items , i am really sad with that.


Show "time remaining" for each medication

Hi @waseefakhtar, Please assign this to me, if this issue is still open

Hi @waseefakhtar, Please assign this to me, if this issue is still open

Done! :)

@waseefakhtar
Will pick this up
Once this P.R got merged
https://github.com/waseefakhtar/dose-android/issues/30

@waseefakhtar
Raised a P.R. for this
Please review.


Logo Design Proposal

Dear Sir/Madam,
Hi, my name is Munadi Kiehl. I'm a graphic designer and I would like to collaborate on your open source project and to propose free icon/logo design. If you're interested in, please, let me know.
Best Regard,
Munadi Kiehl

@fr34kyn01535

Well we are still looking for a new logo, could you show us a proposal?

Hi @fr34kyn01535, and thank you for your reply!
Could you please clarify some information that I could take into account to develop the most suitable design.

Where do you plan to use the logo - only for web or somewhere else?
Should it include any text or any specific object?
Colorful or black & white?
Any other wishes?

Best,
Munadi Kiehl

Our current CI consists of the following banner-size logos which are basically just text:
 (on dark background)
 (on light background)
and the following square logo for social media, favicon etc:

I am currently reworking the logo to be similar across all our services, my current idea something like this (it is just a text logo again):

I don't have no idea for a square logo but i want to go away from the fontawesome-rocket logo we are currently using.
Our current CI colors are:
RocketMod #13bfc1
RocketHarbor (The new name for the plugin repository) #c30125
RocketObservatory (Anti hack) #ef981b
RocketPlus #17b30f

Hi @fr34kyn01535, thanks for all the information you give it to me! I will consider it in my design :)

Hi @fr34kyn01535, I made some option of Rocket Logo, I use colors from your current CI . Please have a look. I'm waiting for your feedback.

I really appreciate your work, you did a brillant job. Unfortunatly I am not a big fan of the 3d look and find it a little to easy to just add a rocket next to the text. If you are still willing to work out some more ideas I'd propose a flatter style with fewer different colors, maybe let the symbol become more part of the text.

Not really into logo design but maybe this will give some ideas

@baranmod i am really digging this logo! Can you drop me a mail at<EMAIL_ADDRESS>with your terms?

Hi @fr34kyn01535. This is the Rocket Logo become a part of the text. If there any revision, please just tell me. I'm waiting for your feedback.

I hope you like it.
I'll provide all size and type file you needed.

@munadikiehl could you drop me an e-mail aswell please with your terms?

Hi @fr34kyn01535. Thanks for your feedback! I’ll prepare all the required file you needed via email<EMAIL_ADDRESS>Is that correct email sir?

Hi @fr34kyn01535. I ‘ve sent you email, but action is delayed.
Final-Recipient: rfc822<EMAIL_ADDRESS>Action: delayed
Status: 4.7.0
Remote-MTA: dns; mail.bam.yt. (<IP_ADDRESS>, the server for the domain bam.yt.)
Diagnostic-Code: smtp; 451 4.7.0 Temporary server error. Please try again later. PRX5
Last-Attempt-Date: Thu, 12 Jul 2018 00:02:34 -0700 (PDT)
Will-Retry-Until: Fri, 13 Jul 2018 23:36:13 -0700 (PDT)

Hi @fr34kyn01535. I’ve sent you email twice, but action is still delayed. I don’t know why this could happen.

It should work now, sorry.


Auto-Update to version 0.10.1

This is an automated issue created by the auto-update workflow following up a new Release of CLIc.
Release Information

Release Tag: 0.10.1
Changelog: View Changelog

Please review the changes and update the dependencies accordingly.

This is an automated issue created by the auto-update workflow following up a new Release of CLIc.
Release Information

Release Tag: 0.10.1
Changelog: View Changelog

Please review the changes and update the dependencies accordingly.


Project POST endpoint to accept geometry collection

Overview
This PR contains the following changes

Project POST endpoint to accept geometry collection

This PR contains the following types of changes

[x] New feature (change which adds functionality)
[x] Enhancement (improvements to existing functionality)

How Has This Been Tested?

Locally

Dont merge this during the demo though (just in case)!


Unexpected TypeError in LBFGS

I have the following code that I would expect to work both with GradientDescent and LBFGS, but the LBFGS one fails:
# this works
x0 = jnp.zeros(n_features)
solver = jaxopt.GradientDescent(loss)
solver.run(x0, A, b, lmbda)

# this doesn't works
x0 = jnp.zeros(n_features)
solver = jaxopt.LBFGS(loss)
solver.run(x0, A, b, lmbda)

This was unexpected, as according to the documentation solver.run has the same API in both cases. Here is the full notebook: https://gist.github.com/fabianp/6c3250512778e0612cbc49a60e32ff00

Fixed in #239


esCleaner occasionally fails with KeyError

Requirement - what kind of business use case are you trying to solve?
We want to remove old indices from ElasticSearch.
Problem - what in Jaeger blocks you from solving the requirement?
Cleaning itself works, but occasionally it fails and needs a restart. This produces noise in our alerting system. We can silence the alert for this, but then we would not notice actual failures.
The process exits with this Traceback:
Traceback (most recent call last):
  File "/es-index-cleaner/esCleaner.py", line 106, in <module>
    main()
  File "/es-index-cleaner/esCleaner.py", line 40, in main
    ilo = curator.IndexList(client)
  File "/usr/local/lib/python3.7/site-packages/curator/indexlist.py", line 31, in __init__
    self.__get_indices()
  File "/usr/local/lib/python3.7/site-packages/curator/indexlist.py", line 72, in __get_indices
    self._get_index_stats()
  File "/usr/local/lib/python3.7/site-packages/curator/indexlist.py", line 149, in _get_index_stats
    iterate_over_stats(stats_result)
  File "/usr/local/lib/python3.7/site-packages/curator/indexlist.py", line 121, in iterate_over_stats
    for index in stats['indices']:
KeyError: 'indices'

Proposal - what do you suggest to solve the problem or improve the existing situation?
—
Any open questions to address
—
Versions

ElasticSearch: 6.8.2
Jaeger: 1.14.0

@svenwltr any idea what the error means? Is there any way to reproduce it on a demo setup?

@pavolloffay I just took a quick look into the code of the curator lib. To me it looks like it happens when one of the requests to Elasticsearch fails, as it catches an specific kind of exceptions, but continues anyway.
Probably our ES cluster is just responding too slow. I did not manage to reproduce it yet.

Experiencing the same with Amazon's ES and Jaeger operator 1.14

Would anybody of you be able to catch the error type?

This is effecting me too.

This is effecting me too.

Any update on the issue?

It is happening to me too. Not just te esCleaner, it happens with the es rollover too.

Apparently, it's a permission issue as pointed out by @roberth1988 here: https://github.com/jaegertracing/jaeger/issues/1691#issuecomment-861341232

I don't think it's all due to the permission issue. We are running a es cluster without permission control even.


image_optim: init at 0.26.3

Things done
# I have tested jpeg-archive
out=$(nix-build ./default.nix -A jpeg-archive)
$out/jpeg-archive --help # throws error, but it's should do so
$out/jpeg-compare --help
$out/jpeg-hash --help
$out/jpeg-recompress --help

# I have tested image_optim
sudo rm -rdf /tmp/test-images
mkdir -p /tmp/test-images
cp /nix/store/p98jdsj0vxjzsfdmff68frydk3db50m2-ruby2.5.3-image_optim-0.26.3/lib/ruby/gems/2.5.0/gems/image_optim-0.26.3/spec/images/icecream.gif /tmp/test-images/icecream.gif
cp /nix/store/p98jdsj0vxjzsfdmff68frydk3db50m2-ruby2.5.3-image_optim-0.26.3/lib/ruby/gems/2.5.0/gems/image_optim-0.26.3/spec/images/lena.jpg /tmp/test-images/lena.jpg
cp /nix/store/p98jdsj0vxjzsfdmff68frydk3db50m2-ruby2.5.3-image_optim-0.26.3/lib/ruby/gems/2.5.0/gems/image_optim-0.26.3/spec/images/rails.png /tmp/test-images/rails.png
cp /nix/store/p98jdsj0vxjzsfdmff68frydk3db50m2-ruby2.5.3-image_optim-0.26.3/lib/ruby/gems/2.5.0/gems/image_optim-0.26.3/spec/images/test.svg /tmp/test-images/test.svg
cp /nix/store/p98jdsj0vxjzsfdmff68frydk3db50m2-ruby2.5.3-image_optim-0.26.3/lib/ruby/gems/2.5.0/gems/image_optim-0.26.3/spec/images/transparency1.png /tmp/test-images/transparency1.png
cp /nix/store/p98jdsj0vxjzsfdmff68frydk3db50m2-ruby2.5.3-image_optim-0.26.3/lib/ruby/gems/2.5.0/gems/image_optim-0.26.3/spec/images/transparency2.png /tmp/test-images/transparency2.png
cp /nix/store/p98jdsj0vxjzsfdmff68frydk3db50m2-ruby2.5.3-image_optim-0.26.3/lib/ruby/gems/2.5.0/gems/image_optim-0.26.3/spec/images/vergroessert.jpg /tmp/test-images/vergroessert.jpg
cd ~/projects/nixpkgs
out=$(nix-build ./default.nix -A image_optim)
(cd /tmp/test-images && $out/bin/image_optim --no-threads --verbose --allow-lossy --jpegoptim-allow-lossy true --jpegoptim-max-quality 85 --pngquant-allow-lossy true --pngquant-quality 0..85 -r .)

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

have a question: can update bot execute update.sh or similar script to update packages and make pull request with the update?

@GrahamcOfBorg build image_optim


UI does not show connection between main workflow and exit handler workflow

Is this a BUG REPORT or FEATURE REQUEST?:
BUG
What happened:
UI does not show connection between main workflow and exit handler workflow
What you expected to happen:
Exit handler workflow won't start until the main workflow is completed, so UI should display exit workflow dependency.
How to reproduce it (as minimally and precisely as possible):
Check any workflow with exist handler in UI.
Anything else we need to know?:
Environment:

Argo version: v2.1.0-alpha1

Fixed on UI side


Cannot read property 'indexFinger' of undefined

Hello,
according to the documentation
var hand = frame.hands[0];
var indexFinger = hand.indexFinger;
is supposed to return the indexFinger Finger() object.
This function however doesn't seem to work.
Best Regards,
Sebastian Lohrmann

nvm, I figured out, that you can only detect fingers after you made sure, that the hand is tracked
(frame.hands.length>0)


How do I prepare the OTB dataset?

Dear Zhou,
Thanks for your excellent work!
How do I prepare the OTB dataset?
How to download the OTB_query_test, OTB_query_train, and OTB_videos?
--OTB_sentences
|-- OTB_query_test
|-- OTB_query_train
|-- OTB_videos
Thank you!

Hello, I have also encountered the same problem. How did you solve it? Looking forward to your answer very much

You can get help from #6.


Update README.md

Change the structure and improve wording

Here is an API I would like to consume (in JS for simplicity)

// Scenario 1 (basic usage)

// class name that acts as an entry point
import Fingerprinter  from "FingerprintJS"

// simple init procedure
let fingerprinter = Fingerprinter.init()

// get device fingerprint
let fingerprint = fingerprinter.getFingerprint()

// Scenario 2, advanced usage
import Fingerprinter  from "FingerprintJS"

let fingerprinter = Fingerprinter.init({option1: "value", option2: "value"})

// get fingerprint with options
let fingerprint = fingerprinter.getFingerprint({installedApps: true})

// use fingerprint
console.log(fingerprint.userId)
console.log(fingerprint.signals) // array of signals, e.g. list of apps

// use a specific signal
fingerprint.signals[0]

This is not directly applicable, but hopefully can be helpful in simplifying your API


Delete duplicate travis.yml

The contents here are now in the root .travis.yml, and this file is now out of sync with the FB internal repository.

Thank you for the fix @yns88


broken link

https://github.com/ubcgif/em_examples/blob/master/notebooks/maxwell1_fundamentals/Magnetic_Dipole_Harmonic.ipynb no longer exists, hence this failure: https://travis-ci.org/ubcgif/em/builds/163201456. @sgkang : can you point @thast to the moved / updated notebook? Thanks!

#310

(need to add the Binders badge, just notice it is missing)

closed with #310


Lepiter should support classTrait method annotations

When we want to reference a class-side Trait method we have to write use class instead of classTrait:

Fix in the <class> token:

Working solution with not ideal but a satisfactory consequence:


Adding exit code if leaks founded and output to STDOUT

It's will be usefull for CICD pipeline or pre-commit hook, like in gitleaks

Hi, thanks for the suggestion.
I'm gonna add a special cli argument for this feature in the next release


SSO/SAML support

Hi dear stackstorm maintainers/community!
I've been working on a PR to implement SSO/SAML using whatever we currently have as a base (st2-auth-backend-sso-saml2) and some other bits and pieces of SSO through the main st2 repository.
I asked around in slack if this had any traction and apparently not, so I just went ahead and started implementing some of it because we need that for our strategy at the company I work for.
Are there any other guidelines regarding contribution other than these items?
https://github.com/StackStorm/st2/blob/abb694b85f75dc543ecea7df6b87def4bce53309/CONTRIBUTING.rst
https://docs.stackstorm.com/development/index.html
I am currently focusing on getting it working on manual tests and will write proper tests afterwards, but can I count on some assistance to further validate/refine this as it progresses?
here's a bit of how it looks so far..
https://user-images.githubusercontent.com/1406885/164324464-29150514-1b5c-415d-bb71-d1e5f2cf568a.mp4
if you have any SAML/SSO material, that would be lovely as well.. currently I've been trying to base the implementation off gravitational/teleport
thanks!!

thanks for the input @rush-skills !
1 - not yet... i have not looked into the RBAC handling on stackstorm, but if it is as simple as I think it might be, it would just be a matter of mapping groups to roles from the SSO backend (so just a config in the backend should do it)
2 - it should work in parallel to ldap but I am not sure.. the SSO backend as it's currently implemented is parallel to the standard auth mechanisms
3 - the CLI login is somewhat like this:

user issues 'st2 login --sso'
the CLI creates a local HTTP (unencrypted) web server on the user PC, at a random port, with urls:

/*********** -> random string to initiate the login flow on the browser
/callback -> endpoint for the browser to finish the login flow with the SSO response
/success -> redirect endpoint to just show the login succesful details

the CLI creates a random AES key
the CLI issues a SSO request on the auth componnt at /auth/sso/request/cli, providing the random AES key and the callback URL. the key will be used to encrypt the response back to the CLI

the auth generates a random ID for this SSO request, and creates a SSO request object in the database (containing the ID, expiration time (eg 2min), the key, and the type (eg web/cli))
the auth component then sends the request to the SSO backend, providing the ID it should use for the request (the same as the SSO request above)
the SSO backend does its thing and provides back the SSO URL, that should be used for the user to login on the browser..
as part of the login flow, it's configured to send the SSO response back to ST2 at /auth/sso/callback
the SSO URL is propagated back to the CLI on the response to this SSO request

the CLI then provides the user with the message "Please finish the SSO login in the URL:".. providing the local web server's URL

once this is done, the CLI sits idle waiting for the response at /callback, for 90 seconds, or it times out

the user visits the local URL (e.g. http://localhost:42343/ee4b73ff-73df-4f3c-9830-026f913bc072), and then gets redirected to the proper IDP

the IDP does the authentication, and then redirects the user to /auth/sso/callback, with the SSO response
the auth component parses the incoming response, and asks the SSO backend for the ID associated with that response
the auth backend then validates if the ID is valid by checking the database, and whether it has expired.. upon validation, the request is deleted from the DB and may not be used again
once the SSO request itself is validated, the auth component goes back to the SSO backend and asks it to parse it and provide the associated details of the logged in user

here we would (i guess) just need to do a role/group mapping and provide back to the SSO backend for rbac to work

the auth component gets these details and then creates a token
the auth backend detects that this was a CLI request (which needs key encryption due to the HTTP webserver locally), and then encrypts the content with the key
once encrypted, the content is sent back to the CLI using the callback url (e.g. http://localhost:42343/callback), and the user is redirected to /success for the OK message on the browser

the CLI decrypts the content with the key and stores the token just like it used to do with regular auth
done :)

this is more or less what goes on.. in the CLI case there's this encryption key, but in the web case I think we just need to do some cross-site request checks, but that's still to be implemented and validated

@pimguilherme These steps seem good to me.
Can you open your PR(s) and I can review the code/test the feature and come back at you better

Hi @rush-skills ! Thanks for getting back to me :)
I will create the PR in the code this week and let you know! Cheers

Hey @rush-skills ! Thanks for reaching out.. unfortunately I did not make any progress as there were other internal priorities in the company.. many of them involved in internal stackstorm automations but this PR got a bit of a halt.. gladly we should be putting more effort into it starting this week.. hopefully to resolve and finish it :)
I will now try to open the PR to get things going and update this ticket
Cheers!

Hey @pimguilherme
That looks great and a lot of effort. Thanks for the contribution!
If you can start adding more docs and descriptions to the PR, I can try setting them up next week and testing the changes.

hey @rush-skills , I am starting by trying to make tests here:
https://github.com/StackStorm/st2-auth-backend-sso-saml2/pull/16
are you familiar with this code? it looks like the makefile is broken and it doesn't look like other st2-auth-backend modules use a Makefile in general.. I just wanted to check before doing any changes, otherwise I will just try to tinker around and make it work
cheers!

hey @rush-skills , I am starting by trying to make tests here: StackStorm/st2-auth-backend-sso-saml2#16
are you familiar with this code? it looks like the makefile is broken and it doesn't look like other st2-auth-backend modules use a Makefile in general.. I just wanted to check before doing any changes, otherwise I will just try to tinker around and make it work
cheers!
Haven't got much experience, but indeed the tests are broken for the repo. From what I see, it still uses CircleCI (we are migrating to GitHub Actions now) with Please ython 2 build (which again is deprecated). I can try creating an issue and picking it up later, but that won't be soon I guess.

Feel free to tinker around and change the tests however you want in the meanwhile.

awesome, thanks for confirming! I will try to make the Makefile make sense and use python3.6, and will leave the circleci part for later.. after working a bit on this I will try to document steps for you to be able to manually try the SSO flow
cheers!

hey @rush-skills ! i have concluded a somewhat "big" part of the saml2 backend.. would you be able to take a quick look? tests seem OK.. just want to have some input to have a feel of how it looks
thanks!

also, would you be able to confirm if this is an OK approach to assigning user roles? https://github.com/StackStorm/st2/pull/5664/commits/c9d3f4396197572425cac3f112191b34a84e40fe
at the moment, we are deleting all roles for as pecific user and recreating them based on each SSO login.. I remember seeing some alternative to this but just wanted to check before committing more time to it
cheers!

hi @rush-skills ! I have deleted some old comments and compiled the latest status:
To implement this change I had to update the following repositories:

st2 (https://github.com/StackStorm/st2/pull/5664)

everything basically ready

still need to fully validate generic changed files / their tests

still need to implement CSRF protection

still need to work on the st2client

most tests should be ready already (there's currently an unexpected, unrelated breaking test)

code changes

st2auth + st2common

added saml-backend as a default dependency of st2auth (still need to point to st2's org, it's currently using my own repo)

added cli/web login endpoints on SSO request (GET /auth/sso/request/web or POST /cli)

added SSO request database model for storing pending/requested logins and validate callbacks and expiration

added a UUID request_id to SSO requests

added a BaseSingleSignOnBackendResponse class to better communicate response with sso backends

added remote group + role syncing to the ProxyAuthHandler, based on provided proxy groups on the request (reusing same code as the SStandaloneAuthHandler

added SSO backend required method get_request_id_from_response, to be able to check agaisnt pending SSO requests in the database

created a TokenResourceManager to implement some SSO logic in to token generation

updated openapi endpoints for sso

addede some helpers methods to st2common access services

added a crypto method to read keys from dict directly

st2client

added --sso option to CLI and integrated with the backend (still needs some tests/validation but should be working)

copied crypto.py code to the st2client package for key encryption (not sure how to deal with this best)

added a SSOInterceptorProxy class responsible for spinning up a local server to wait for incoming callback from the backend, with the auth details :)

misc details

prior to processing callbacks, the incoming SSO request id is validated and database model is deleted so it's not longer usable

sso uses ProxyAuthenticationHandler

callback response differs between CLI and WEB initial requests

cli-based login has encrypted response based on incoming key provided by caller (since the callback to the CLI webserver is usually HTTP)
web-based login callback populates the st2session cookie so the user is authenticated and redirects them to normal usage of the GUI

st2web (https://github.com/StackStorm/st2web/pull/983/files)

should be 100% ready (hopefully haha)
added a login button that redirects to /auth/sso/request/web
configurable via config.json
added some tests

st2-auth-backend-saml2 (https://github.com/StackStorm/st2-auth-backend-sso-saml2/pull/16)

updated some pylint definitions from base repository
updating pysaml2 lib to latest
implemented and tested the saml2 backend and integration with the SSO handler
added some fixtures for testing with keycloak responses
added some logging :)

st2-dockerfiles (https://github.com/StackStorm/st2-dockerfiles/pull/55)

adding xmlsec1 as a dependency to st2auth container

st2-docker (https://github.com/StackStorm/st2-docker/pull/246/files)

added a local keycloak at 3011 with pre-populated stanley user and StackStorm realm
enabling RBAC by default
enabling SSO by default (in the backend and gui)
adding RBAC mappings to st2admin (via assignments) and stanley (via group mapping)

to test this, you should:
mkdir /tmp/st2-test
cd /tmp/st2-test
# clone test docker files
git clone git@github.com:pimguilherme/st2-dockerfiles.git
cd st2-dockerfiles

# checkout feat/saml-test
git checkout feat/saml-test

#build images base and then st2auth and st2web locally
docker build -t stackstorm/st2:3.8dev . --build-arg ST2_VERSION=3.8dev
docker build -t stackstorm/st2auth:3.8dev . --build-arg ST2_VERSION=3.8dev
docker build -t stackstorm/st2web:3.8dev . --build-arg ST2_VERSION=3.8dev

cd /tmp/st2-test

# clone st2-docker modified with keycloak
git clone https://github.com/pimguilherme/st2-docker
cd st2-docker

git checkout feat/saml

# cleanup before :)
docker-compose down

# cleanup old volumes (BEWARE IF YOU DONT WANT TO DELETE LOCAL TEST DATA)
docker volume rm $(docker volume ls | grep -Po 'st2-\S+')

# bring up the composer
ST2_VERSION=3.8dev docker-compose up -d

# wait for st2web to be healthy
# login to web ui
# click the SSO button
# login user with `stanley/Ch@ngeMe`

haven't been able to test this exactly but it's basically wht I do.. I will update next week
i think this is pretty much it!! please let me know
cheers!

@pimguilherme Wow, this is a lot of work. Thanks for the update!
I haven't got the chance to test these changes yet, will try to follow the instructions and test them next week.
Cheers,
Ankur

sounds good @rush-skills , thanks! :)
I was able to validate the steps worked, and I will keep on working further on this and should very soon be fully done.. in any case the testing steps should be working in the meantime
cheers!

hi @rush-skills @cognifloyd @armab  (tagging some people I see are quite active around here :)
I just wanted to follow up on this PR.. would you be able to help us merge it? I think it's basically ready, pending basically some docs, and some help on getting the CI to pass
Please let me know if there's anything I can do to help
thanks!

Hey @pimguilherme. Apologies, I had been on leave during the summer and didn't get a chance to test it out.
Ideally, we will need the docs updated and CI passing to merge the PRs, while at least one person from @StackStorm/tsc doing hands-on testing with the same. I can try to dedicate some effort to it, but that involves building and including the packages from the PRs and using that in our test env, which is quite a pain currently with the rather complicated test/build/package pipeline (which is being fixed by @cognifloyd with the introduction of pants).
In the meanwhile, if you need any specific help with CI, feel free to point out the errors and one of us will have a look and try to get it sorted.

Hey @rush-skills , thanks! I will work on updating the docs and the CI, and also make myself available to help on whatever you guys need to test it out (perhaps following the instructions on one of the last posts could be a starting point for some initial tests)
The CI was passing a few weeks ago, so it is probably related to some recent changes.. probably also not something very big.. I will try to work it out and reach out if needed
Cheers!

Hi @rush-skills ! Further updates.. I think things are 100% ready for the merge :)
CIs are passing and DOC has been updated
I have updated the summary comment a few comments back with all the PRs
Please let me know if theres any further help I can provide
Cheers!

Hey @pimguilherme
So I am finally having a look at this and starting to test the PR(s). I will do the docker testing followed by testing the core packages later.
For now, the first issue I face is when I run

docker build -t stackstorm/st2:3.8dev base --build-arg ST2_VERSION=3.8dev

I get
Step 17/34 : RUN TEMP_DEB="/tmp/st2.deb" &&   curl -o "$TEMP_DEB" -L 'https://output.circle-artifacts.com/output/job/54542eb6-74d4-4211-a3a2-785d4f57ed71/artifacts/1/packages/focal/st2_3.8dev-1_amd64.deb' &&   apt update &&   apt install --fix-missing -y "$TEMP_DEB" &&   rm -f "$TEMP_DEB"
 ---> Running in a11658607680
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    23  100    23    0     0     47      0 --:--:-- --:--:-- --:--:--    47

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

Building dependency tree...
Reading state information...
4 packages can be upgraded. Run 'apt list --upgradable' to see them.

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

Reading package lists...
E: Invalid archive signature
E: Internal error, could not locate member control.tar.{zstlz4gzxzbz2lzma}
E: Could not read meta data from /tmp/st2.deb
E: The package lists or status file could not be parsed or opened.
The command '/bin/sh -c TEMP_DEB="/tmp/st2.deb" &&   curl -o "$TEMP_DEB" -L 'https://output.circle-artifacts.com/output/job/54542eb6-74d4-4211-a3a2-785d4f57ed71/artifacts/1/packages/focal/st2_3.8dev-1_amd64.deb' &&   apt update &&   apt install --fix-missing -y "$TEMP_DEB" &&   rm -f "$TEMP_DEB"' returned a non-zero code: 100

Hi guys! Checking to see if there was any luck here and anything I can do to help
Cheers!

Our org is migrating to Okta for SSO, and this is a critical feature for our continued use of Stackstorm. Is there an ETA for this feature becoming available?

Our org is migrating to Okta for SSO, and this is a critical feature for our continued use of Stackstorm. Is there an ETA for this feature becoming available?

Hi @cydergoth ! happy to see interested parties here :)
we have been using this branched implementation of SSO in our company and it's been working well.. we still need the stackstorm maintainers to help us merge this into the main code to get it all worked out.. @rush-skills is helping us on that but I think he has a bit on his plate now
I would requested you to try it out following the steps at the end of this comment: https://github.com/StackStorm/st2/issues/5625#issuecomment-1192960089
if you need any help setting it up, I would love to help (you could try to point the SSO backend to your company's OKTA setup (provided its saml) to see if the current proposal will help you)
thanks!

@pimguilherme I'm definitely interested in testing out this SSO/SAML implementation. It should be a lot smoother than the solution I hacked together with OAuth2-Proxy.
I should have some time next week to set this up in our development environment and do some thorough testing. Thank you and your team for getting this together.

@pimguilherme I'm definitely interested in testing out this SSO/SAML implementation. It should be a lot smoother than the solution I hacked together with OAuth2-Proxy.
I should have some time next week to set this up in our development environment and do some thorough testing. Thank you and your team for getting this together.

that's great to hear @thozook ! initially we also hacked something together just to get it working and now we were able to dedicate some time to get it into the community :)
your help testing will be of great value, cheers! if you have any questions please let me know \o

Hi all, nice to see this has.kicked off some interest as we like ST2 :-)
I am busy dealing with a certain OpenSSL issue but I will try to carve out some time next week to test this. Not sure what ingress controller we will be using, possibly Istio

:100:  More testing and feedback would be highly appreciated.
At this moment the release team is preparing the v3.8 https://github.com/orgs/StackStorm/projects/29
and we definitely want to plan this big feature for the next v3.9.

I was able to test this out yesterday. After getting everything setup(had to adjust the web port to 8080 due to things already setup on my machine), I was able to run the SSO authenticating against Keycloak without issues.
I then tried to setup SSO with Azure AD(Adjusted metadata_url but kept entity_id the same), but I get an error page with the message:
{"faultstring":"Internal Server Error"}
Watching the logs of the st2auth container, it has the following messages:
2022-11-08 15:31:45,933 INFO [-] 54d661a5-42ef-440e-89b5-54d98b44ada5 - GET /sso/request/web with query={} (method='GET',path='/sso/request/web',remote_addr='<IP_ADDRESS>',query={},request_id='54d661a5-42ef-440e-89b5-54d98b44ada5')
2022-11-08 15:31:45,944 INFO [-] destination to provider: https://login.microsoftonline.com/##TENANTID##/saml2
2022-11-08 15:31:45,944 INFO [-] REQUEST: <ns0:AuthnRequest xmlns:ns0="urn:oasis:names:tc:SAML:2.0:protocol" xmlns:ns1="urn:oasis:names:tc:SAML:2.0:assertion" ID="id_7849cb85-6829-41af-b9d3-4cbe256bd0a2" Version="2.0" IssueInstant="2022-11-08T15:31:45Z" Destination="https://login.microsoftonline.com/##TENANTID##/saml2" ProtocolBinding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST" AssertionConsumerServiceURL="http://localhost:8080/auth/sso/callback"><ns1:Issuer Format="urn:oasis:names:tc:SAML:2.0:nameid-format:entity">http://localhost:8080</ns1:Issuer></ns0:AuthnRequest>
2022-11-08 15:31:45,945 INFO [-] AuthNReq: <ns0:AuthnRequest xmlns:ns0="urn:oasis:names:tc:SAML:2.0:protocol" xmlns:ns1="urn:oasis:names:tc:SAML:2.0:assertion" ID="id_7849cb85-6829-41af-b9d3-4cbe256bd0a2" Version="2.0" IssueInstant="2022-11-08T15:31:45Z" Destination="https://login.microsoftonline.com/##TENANTID##/saml2" ProtocolBinding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST" AssertionConsumerServiceURL="http://localhost:8080/auth/sso/callback"><ns1:Issuer Format="urn:oasis:names:tc:SAML:2.0:nameid-format:entity">http://localhost:8080</ns1:Issuer></ns0:AuthnRequest>
2022-11-08 15:31:45,945 INFO [-] HTTP REDIRECT
2022-11-08 15:31:45,946 INFO [-] 54d661a5-42ef-440e-89b5-54d98b44ada5 - 307 0 13.105ms (method='GET',path='/sso/request/web',remote_addr='<IP_ADDRESS>',status=307,runtime=13.105,content_length=0,request_id='54d661a5-42ef-440e-89b5-54d98b44ada5')
2022-11-08 15:31:46,176 INFO [-] 670d9388-62f7-4fc2-a1c3-49fe31ff7379 - POST /sso/callback with query={} (method='POST',path='/sso/callback',remote_addr='<IP_ADDRESS>',query={},request_id='670d9388-62f7-4fc2-a1c3-49fe31ff7379')
2022-11-08 15:31:46,183 ERROR [-] Signature Error: Signature missing for response
2022-11-08 15:31:46,183 ERROR [-] XML parse error: Signature missing for response
2022-11-08 15:31:46,183 ERROR [-] Failed to call controller function "post" for operation "st2auth.controllers.v1.sso:idp_callback_controller.post": Signature missing for response
Traceback (most recent call last):
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/st2common/router.py", line 632, in __call__
    resp = func(**kw)
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/st2auth/controllers/v1/sso.py", line 145, in post
    raise e
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/st2auth/controllers/v1/sso.py", line 96, in post
    original_sso_request = self._validate_and_delete_sso_request(response)
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/st2auth/controllers/v1/sso.py", line 55, in _validate_and_delete_sso_request
    request_id = SSO_BACKEND.get_request_id_from_response(response)
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/st2auth_sso_saml2/saml.py", line 196, in get_request_id_from_response
    authn_response = self._get_authn_response_from_response(response)
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/st2auth_sso_saml2/saml.py", line 180, in _get_authn_response_from_response
    authn_response = saml_client.parse_authn_request_response(
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/saml2/client_base.py", line 841, in parse_authn_request_response
    resp = self._parse_response(
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/saml2/entity.py", line 1496, in _parse_response
    response = response.loads(xmlstr, False, origxml=xmlstr)
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/saml2/response.py", line 528, in loads
    self._loads(xmldata, decode, origxml)
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/saml2/response.py", line 344, in _loads
    self.response = self.signature_check(
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/saml2/sigver.py", line 1760, in correctly_signed_response
    raise SignatureError('Signature missing for response')
saml2.sigver.SignatureError: Signature missing for response
2022-11-08 15:31:46,186 ERROR [-] API call failed: Signature missing for response
Traceback (most recent call last):
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/st2common/middleware/error_handling.py", line 49, in __call__
    return self.app(environ, start_response)
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/st2common/router.py", line 746, in as_wsgi
    resp = self(req)
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/st2common/router.py", line 644, in __call__
    raise e
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/st2common/router.py", line 632, in __call__
    resp = func(**kw)
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/st2auth/controllers/v1/sso.py", line 145, in post
    raise e
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/st2auth/controllers/v1/sso.py", line 96, in post
    original_sso_request = self._validate_and_delete_sso_request(response)
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/st2auth/controllers/v1/sso.py", line 55, in _validate_and_delete_sso_request
    request_id = SSO_BACKEND.get_request_id_from_response(response)
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/st2auth_sso_saml2/saml.py", line 196, in get_request_id_from_response
    authn_response = self._get_authn_response_from_response(response)
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/st2auth_sso_saml2/saml.py", line 180, in _get_authn_response_from_response
    authn_response = saml_client.parse_authn_request_response(
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/saml2/client_base.py", line 841, in parse_authn_request_response
    resp = self._parse_response(
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/saml2/entity.py", line 1496, in _parse_response
    response = response.loads(xmlstr, False, origxml=xmlstr)
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/saml2/response.py", line 528, in loads
    self._loads(xmldata, decode, origxml)
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/saml2/response.py", line 344, in _loads
    self.response = self.signature_check(
  File "/opt/stackstorm/st2/lib/python3.8/site-packages/saml2/sigver.py", line 1760, in correctly_signed_response
    raise SignatureError('Signature missing for response')
saml2.sigver.SignatureError: Signature missing for response (_exception_class='SignatureError',_exception_message='Signature missing for response',_exception_data={})
2022-11-08 15:31:46,188 INFO [-] 670d9388-62f7-4fc2-a1c3-49fe31ff7379 - 500 39 12.066ms (method='POST',path='/sso/callback',remote_addr='<IP_ADDRESS>',status=500,runtime=12.066,content_length=39,request_id='670d9388-62f7-4fc2-a1c3-49fe31ff7379')

(Sanitized company identifying info in the above logs of course)
I tried some troubleshooting and attempted adding the following settings to see if they made a difference:
"extra_pysaml2_sp_settings": {
        "want_response_signed": "False",
        "want_assertions_signed": "False"

But the message was the same.
My configs I have setup are as follows:
Stackstorm side:
sso_backend_kwargs = {
    "entity_id": "http://localhost:8080",
    "metadata_url": "https://login.microsoftonline.com/##TENANTID##/federationmetadata/2007-06/federationmetadata.xml",
    "extra_pysaml2_sp_settings": {
        "want_response_signed": "False",
        "want_assertions_signed": "False"
    }
 }

Azure Side:
Identifier (Entity ID): http://localhost:8080
Reply URL (Assertion Consumer Service URL): http://localhost:8080/auth/sso/callback

thanks for the very valuable test @thozook !!
could you try with
"extra_pysaml2_sp_settings": {
        "want_response_signed": false,
        "want_assertions_signed": false

as these are supposedly json?
if not, could you give it a second try settingt he AzureAD setting to sign responses?

ideally just setting the pysaml2 settings should resolve this situation.. the implementation of extra settings was done exactly for these kinds of scenario
also didn't plan for the error to come out so generic for the end user as "Internal Server Error" (I remember having the intention of being at least a bit more descriptive), but anyway..

Thanks @thozook ! that's something I have nevery come across.. I will try to replicate it using AD as well
Would you be able to try the second approach, where you would sign the responses on AD?
Cheers!

Perhaps you could also give this configuration a try?
"extra_pysaml2_sp_settings": {
        "want_response_signed": false,
        "want_assertions_signed": false
        "want_assertions_or_response_signed": true,

or
"extra_pysaml2_sp_settings": {
        "want_response_signed": false,
        "want_assertions_signed": true

I'm wondering if your assertions are signed.. It's strange that it's trying to validate signature because you have defined you want neither signatures

@pimguilherme Thank you for those screenshots, they helped me find out what was incorrect in my settings.
I had left the Attributes and Claims section to the default settings on Azure. After adjusting it to match what you have setup, the SSO flow worked perfectly for me.
I was even able to remove the settings for "want_response_signed" and "want_assertions_signed" after setting the SAML signing option to sign both the response and assertion.

that's great to hear! :) if you have any other issues please report them \o

Do these clarifications need to be added the st2docs PR to avoid such confusion in the future?

I think it's worth adding as we find out some of these examples, but in the end we provide a bit of a "generic" interface to saml configuration and the tweaking / adjusting of particular setups is more in the hands of the admin (hoping these generic configs are enough to provide any tweaking needed)
Some things are definitely worth documenting like the need of the claim being Username.. I will update the docs!

Your https://output.circle-artifacts.com/output/job/9492f18c-c1f6-4232-a3a7-a45a9e5423bc/artifacts/1/packages/focal/st2_3.8dev-1_amd64.deb this link from file  st2-dockerfiles/base/Dockerfile  is not work same issue in st2web. Can I get updated link?

Hey! I will rebuild it later today and update the ticket!
On Fri, Feb 24, 2023, 11:12 sidharth61 @.***> wrote:

Your
https://output.circle-artifacts.com/output/job/9492f18c-c1f6-4232-a3a7-a45a9e5423bc/artifacts/1/packages/focal/st2_3.8dev-1_amd64.deb
this link from file st2-dockerfiles/base/Dockerfile is not work same issue
in st2web. Can I get updated link?
—
Reply to this email directly, view it on GitHub
https://github.com/StackStorm/st2/issues/5625#issuecomment-1443738577,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKXPJJFCDG2CYS6DXMPBHDWZC6V7ANCNFSM5T5JLGXQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

sure! I have rebuilt them @sidharth61 , thanks :)
@nzlosh @armab @cognifloyd do you think this is still going to make 3.9.0?

I'm focused on revamping the developer tooling around contributing to StackStorm, so I'm having a hard time switching focus to reviewing other changes in ST2. But, Improving SSO is an awesome thing, so I do want to see you work merged ASAP, preferably in 3.9.
Please ask for PR reviews in #development on slack. If no one responds after a few days to a week (time for people across time zones to see it), post again in the #tsc channel.

Got it! Will do, thanks @cognifloyd !
I will try to engage people on those channels
Cheers!

Is SSO officially supported in st2 v3.8.0? I don't see it specified in the release notes:
https://docs.stackstorm.com/changelog.html#november-18-2022
However, I see that it's part of the config file for the tagged v3.8.0 release:
https://github.com/StackStorm/st2/blob/v3.8.0/conf/st2.conf.sample

@pimguilherme  for Azure AD for entity_id I am using my domain name with port number. I am getting error "{"faultstring":"Invalid referer -- it should be either some localhost endpoint or the SSO configured entity"}" I am not localhost as you used in config. Do I also have to use localhost instead of my domain name?

Is SSO officially supported in st2 v3.8.0? I don't see it specified in the release notes: https://docs.stackstorm.com/changelog.html#november-18-2022
However, I see that it's part of the config file for the tagged v3.8.0 release: https://github.com/StackStorm/st2/blob/v3.8.0/conf/st2.conf.sample
This release note mentions that SSO/SAML support with be part of the next release: https://stackstorm.com/2022/12/v3-8-0-released/

Hi @rite2hhh ! SSO was partly implemented in 3.8.0 (it was done so a while ago), but it was never really fully supported.. The foundation for SSO was there but no specific SSO mechanism was fully implemented. This PR aims to implement the SSO backend + SAML fully for usage.
if you are looking for SSO/SAML in stackstorm, it would be very helpful if you could test it out with these steps and see if it works for you :)
https://github.com/StackStorm/st2/issues/5625#issuecomment-1192960089
Cheers!

@sidharth61, I think you should use the domain/port combination that is used by your users to access stackstorm. Can you please confirm that's the case? And then you should also configure it in Azure AD like this:

Cheers!

@pimguilherme I need instruction for enabling ssl. For azure sso I need this ssl enabled. Don't find any documentation. I made some changes but not working for me.i also generated ssl cert using code that is provided to create free certificate and enabled ssl option.

Hi @sidharth61 ! You should be able to use SSL normally.. in the example above there is SSL enabled (https://stackstorm.homolog.etc). Can you confirm if you have been able to configure stackstorm to serve using SSL? This depends a lot on how you are deploying Stackstorm
Thanks!

@pimguilherme I enabled ssl by changing this ST2WEB_HTTPS: ${ST2WEB_HTTPS:-0} in file st2-docker/docker-compose.yml. Also enabled - "${ST2_EXPOSE_HTTPS:-<IP_ADDRESS>:443}:443" this and changed ip address from <IP_ADDRESS> to <IP_ADDRESS> , copied ssl certificate in folder /etc/ssl/st2 inside st2web container. After this restarted nginx service and st2web container started showing error.

@pimguilherme can you provide me steps how to enable ssl. After I enabled ssl in st2web I am getting ssl issue with st2api baseurl.

@cognifloyd need help with ssl. I deployed stackstorm container. Enable ssl for st2web as it is described in s2web dockerfile and generated free ssl. But getting issue with api url redirecting to 308. What other changes should I do to make ssl work . Attest provide some documentation for enabling ssl for docker

@pimguilherme I deployed stackstorm like you described in this thread. I changed ip from <IP_ADDRESS> to <IP_ADDRESS> . Enabled ssl option st2web as you have described  and generated free ssl using given code but getting issue on line 141 in nginx config st2.conf. That has url related to st2auth. Can you tell if I have to enable ssl in other containers also. I need help in this issue.

+1 for interested parties here. I have been running automation with stackstorm-ha deployed in AWS for the past 6 months and it has been working great. The worst part is user management, so SSO would be amazing.
Let me know if I can do anything to help.

I am looking to integrate aws cognito with st2 for SSO, do we have any documentation on SSO set up yet? I have st2 set up in AWS EKS, so I am unclear how I can update SSO configs for st2, is that supported yet?

You can follow https://github.com/StackStorm/st2/issues/5625 this for sso
On Mon, Mar 11, 2024 at 5:47 PM rrahman-nv @.***> wrote:

I am looking to integrate aws cognito with st2 for SSO, do we have any
documentation on SSO set up yet? I have st2 set up in AWS EKS, so I am
unclear how I can update SSO configs for st2, is that supported yet?
—
Reply to this email directly, view it on GitHub
https://github.com/StackStorm/st2/issues/5625#issuecomment-1988308089,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABEK5FAQKEMZZECSA7PBRYLYXWOFLAVCNFSM5T5JLGX2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJYHAZTAOBQHA4Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

This solution worked for me
On Tue, Mar 12, 2024 at 1:27 AM sidharth singh @.***>
wrote:

You can follow https://github.com/StackStorm/st2/issues/5625 this for sso
On Mon, Mar 11, 2024 at 5:47 PM rrahman-nv @.***>
wrote:

I am looking to integrate aws cognito with st2 for SSO, do we have any
documentation on SSO set up yet? I have st2 set up in AWS EKS, so I am
unclear how I can update SSO configs for st2, is that supported yet?
—
Reply to this email directly, view it on GitHub
https://github.com/StackStorm/st2/issues/5625#issuecomment-1988308089,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABEK5FAQKEMZZECSA7PBRYLYXWOFLAVCNFSM5T5JLGX2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJYHAZTAOBQHA4Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi @pimguilherme,
First and foremost, this PR is very helpful and it's surely a lot of work. Thanks for your contribution.
I got a chance to try the steps listed at the end of this comment: https://github.com/StackStorm/st2/issues/5625#issuecomment-1192960089
But I'm getting the below error:

8.917 E: Invalid archive signature
8.917 E: Internal error, could not locate member control.tar.{zstlz4gzxzbz2lzma}
8.917 E: Could not read meta data from /tmp/st2.deb
8.917 E: The package lists or status file could not be parsed or opened.

I noticed that the same issue was reported by @rush-skills, here: https://github.com/StackStorm/st2/issues/5625#issuecomment-1268596745
Looks like the .dep package is no longer available at the source, do you know how can I make this work?

hey @ArpanBalpande, thanks for reaching out! I remember I used to build this package through Circle CI and reference its artifact link.. I will try to rebuilt it today and capture the steps

Solution worked for me as well.
Thanks @pimguilherme for sharing the steps above, some extra effort is required to build image from your branch to run and test.
I feel the MR's need to merged asap and available in next release. The feature helps not only with single sign (SAML2) only as combination of RBAC make more worthy with AD groups to work.


Is it possble to convert MediaRecorder data to byte array or stream? I have seen your codes but couldn't figure it out??

Here is my code, i wanted to work with audio
mRecorder = new MediaRecorder();
mRecorder.setAudioSource(MediaRecorder.AudioSource.MIC);
mRecorder.setOutputFormat(MediaRecorder.OutputFormat.THREE_GPP);
mRecorder.setOutputFile(mFileName);
mRecorder.setAudioEncoder(MediaRecorder.AudioEncoder.AMR_NB);
    try {
        mRecorder.prepare();
    } catch (IOException e) {
        Log.e(LOG_TAG, "prepare() failed");
    }

    mRecorder.start();

I want my output as a byte array or stream not any file.

Seems it is possible:
https://stackoverflow.com/a/42750515


Move propPath predicate functions to path

The Last Update

This PR addresses the last two items on this issue by moving the propPath predicate function over to their path names:

propPathEq -> pathEq
propPathSatisfies -> pathSatisfies

Once these are merged we can close out that issue and ship the long awaited 0.12.0

Coverage remained the same at 100.0% when pulling 7599b73603a0dfdcb078f6dd11e283a0af0bf40b on chore/move-path-preds into ed99fbf35ff8c693068e3a5bccca13c0e111409b on master.

Bummer, need to add back the docs files, just wiped them :smh:

Lol yeah i was wondering where they went :) the danger of force-push

Okay @bennypowers and @dalefrancis88 I was able to get all the requested changes added and still include the docs. 🔴 👁 for some final review!


fix: Updating docs for mkcert

Description
Adding mkcert details to install instructions for all clouds and updating current 2.7 version with these changes
Added these details for Azure for vNext
Fixes instances of kubefirst for capitalization (other branding updates)
Related Issue(s)
None found
How to test
Validate that content appears where expected before this step https://kubefirst.konstruct.io/docs/aws/quick-start/install/cli#create-your-new-kubefirst-cluster for each cloud

Since it's not in the commit message, for history, there is also a lot of correction of branding naming in this commit.
@konstructcarrie there is also the addition of Azure in 2.7, is it wanted also? Just want to be sure as this PR was just for mkcert from my understanding.

@konstructcarrie you also need to remove Azure references in the sidebar for 2.7

@konstructcarrie you also need to remove Azure references in the sidebar for 2.7

Yeah I did that but there are also imports/references that I'm not sure how to remove that are killing the build.
@mrsimonemms
If you're able to help me sort that out ☝  I can remove the Azure bits from this PR and we can chat about how you want to go about publishing that (given that it's available and we have no specific ETA on a 2.8 release). Let's catch up tomorrow :D

I can give a look tomorrow to fix the build if Simon doesn't have time, let me know.
Even if we release 2.8 tomorrow, Azure is now available in 2.7, so the docs should be in 2.7 also @mrsimonemms :)

I've created a PR to add the fix into this PR - please take a look and see if you're happy adding into this PR.


useTabBarItemFocusTransition breaks hook rule, why still use it this way?

Bug

in BubbleTabBar.tsx,
const animatedFocusValues = useMemo(
    () =>
      tabs.map((_, index) =>
        // eslint-disable-next-line react-hooks/rules-of-hooks
        useTabBarItemFocusTransition({
          index,
          selectedIndex,
          duration,
          easing,
        })
      ),
    // eslint-disable-next-line react-hooks/exhaustive-deps
    [tabs, duration, easing]
  );

the way useTabBarItemFocusTransition was used breaks the react hooks rules, which are:

Call them at the top level in the body of a function component.
Call them at the top level in the body of a custom Hook.

is there another way to define animatedFocusValues?

I changed the code, moving useTabBarItemFocusTransition to TabBarItem component:
const animatedFocus = useTabBarItemFocusTransition({
    index,
    selectedIndex,
    duration,
    easing,
  });

it works fine as expect.


Create Navigation Components

The following components will be created:

[ ] Breadcrumbs
[ ] Menu
[ ] Navbar
[ ] Pagination
[ ] Speed Dial
[ ] Steps
[ ] Tab

Each will be considered completed once all the following have been completed:

Component Created
Examples Created
Documentation Created
Tests Created

COMPONENTS CREATED

[ ] Breadcrumbs
[ ] Menu
[ ] Navbar
[ ] Pagination
[ ] Speed Dial
[ ] Steps
[ ] Tab

EXAMPLES CREATED
Breadcrumbs
Menu
Navbar
Pagination
Speed Dial
Steps
Tab

DOCUMENTATION CREATED

[ ] Breadcrumbs
[ ] Menu
[ ] Navbar
[ ] Pagination
[ ] Speed Dial
[ ] Steps
[ ] Tab

TESTS CREATED

[ ] Breadcrumbs
[ ] Menu
[ ] Navbar
[ ] Pagination
[ ] Speed Dial
[ ] Steps
[ ] Tab


Example Does not compile IDE 2

The example sketch does not compile with a standard nano board selected.  Seems to be unable to find the #include   library.  Do I need to add this?

Sorry, I'll fix it right away.

Please test with the new version, 0.1.2, and please let me know if it works or not. It takes a few hours for this to refresh in the arduino library registry, so I guess you can just import the library first, downloaded from here.
https://docs.arduino.cc/software/ide-v1/tutorials/installing-libraries/

Hi,
Thanks for the quick response!  Compiles and seems to be working fine.
I was able to update from the library manager, so I guess its fully live
now.
Regards,
MArk
------ Original Message ------
From "Shuncey Balba" @.>
To "shunceyb/MultiMAX6675" @.>
Cc "markrob1066" @.>; "Author"
@.>
Date 6/11/2024 1:50:49 AM
Subject Re: [shunceyb/MultiMAX6675] Example Does not compile IDE 2
(Issue #1)

Please test with the new version, 0.1.2, and please let me know if it
works or not. It takes a few hours for this to refresh in the arduino
library registry, so I guess you can just import the library first,
downloaded from here.
https://docs.arduino.cc/software/ide-v1/tutorials/installing-libraries/
—
Reply to this email directly, view it on GitHub
https://github.com/shunceyb/MultiMAX6675/issues/1#issuecomment-2159846858,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYKXTYNVCOTXMX3FFS4CGALZG2F3TAVCNFSM6AAAAABJDMKTUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJZHA2DMOBVHA.
You are receiving this because you authored the thread.Message ID:
@.***>


Corrects the use of anytree.search.find_by_attr

Also fixes #330

Note: Remove the elimination of possible duplicates using set in region.find as it can remove regions with the same name but on a different hierarchy. However, it does check for exact match when filtering for the parent.
parcellation.get_region() is now responsible for sieving the results and allowing the exact match to be returned instead of throwing an error.
Example:
import siibra
p = siibra.parcellations["waxholm 4"]
p.get_region("lateral olfactory tract")

was raising RuntimeError: Spec lateral olfactory tract resulted in multiple matches: Nucleus of the lateral olfactory tract, Olfactory white matter. but now returns lateral olfactory tract.

@xgui3783, I've converted back to a draft. It seems some more thought needs to be given to have it more concise and clear.
Also, I am not sure additional tests are necessary since when the initial correction was made, there were a few failing tests. However, I am considering adding a test for getting a colormap since a map (not all) should be able to find a unique region in the parcellation for all its regions.

Codecov Report

Merging #331 (1c9722b) into main (3426085) will increase coverage by 0.11%.
The diff coverage is 24.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
+ Coverage   35.87%   35.99%   +0.11%
==========================================
  Files          60       60
  Lines        5315     5303      -12
==========================================
+ Hits         1907     1909       +2
+ Misses       3408     3394      -14

Impacted Files
Coverage Δ

siibra/__init__.py
66.66% <ø> (ø)

siibra/configuration/configuration.py
43.37% <0.00%> (ø)

siibra/configuration/factory.py
22.47% <0.00%> (ø)

siibra/core/atlas.py
84.48% <ø> (ø)

...bra/features/connectivity/regional_connectivity.py
21.29% <0.00%> (+0.38%)
:arrow_up:

...a/features/tabular/regional_timeseries_activity.py
28.75% <ø> (ø)

siibra/retrieval/requests.py
44.40% <0.00%> (ø)

siibra/volumes/neuroglancer.py
21.42% <0.00%> (ø)

siibra/volumes/nifti.py
18.91% <0.00%> (ø)

siibra/volumes/parcellationmap.py
37.13% <25.00%> (ø)

... and 2 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

#335 summarizes all the issues.

since significant changes were made to Region.find, perhaps it's prudent to add some tests there too.
What are the expected behaviors of Region.find etc

Added a few important use cases and checks.


Feature to write CSS property when click property value in tooltip

Based on the idea presented in #131, my team created feature that writing CSS property when click tooltip value item!
If you look at the image below, you can intuitively understand it.

And there were additional code changes as follows.

Disabled next button in case of incorrect answer when calling game.check. Because game.check was called every time the css property was clicked.
Added cover behind tooltip. This is to prevent other tooltip from appearing when clicking on the property value in tooltip.

I'll be waiting for  your review and approval.
Thank you!

Hello @thomaspark I guess you're busy.😂 Can you review this PR when you have time?

Hey @qowlz, sorry for the delayed review! Overall, it's working well. Thanks so much. Just a couple points of discussion:

Playing around with it made me realize the tooltip behavior is inconsistent (it was inconsistent before too). mouseenter opens the tooltip, mouseleave doesn't close it, click once closes it, click again doesn't open it. What if we used clicks as the main interaction, and remove the hover behavior entirely? An added benefit of this is that it would work on mobile, where the new feature is most useful.
Clicking the levels menu repeatedly no longer toggles it closed. This can be fixed by reverting line 114 in game.js.
At line 353, there's this line: $("code").css('cursor', 'pointer');. How about we move it to see and scope it to the tooltip using the selector .tooltip code?

Let me know your thoughts.

Hey @thomaspark Thank you for review!
My thoughts on the suggestions are as follows.

I think that is great suggestion! I'll fix it like that.
game.js line 114 should be toggle instead of show. I'll fix it soon.
I'll fix this part as you said

Hey @thomaspark I'm done above changes. I'd appreciate it if you could review it. :)

Hey @qowlz, I like the changes we made. Thanks for your team's hard work.
A couple more things I noticed:

When clicking the shorthand property flex-flow, it's filled with flex-flow: <flex-direction>;. Something like flex-flow: row nowrap would work better, which are the defaults.
A tricky issue is that when the existing input code isn't perfectly formed, there's some buggy behavior. For example, when the input is:

flex-direction: ;
order: 5;

And we click a tooltip like justify-content: center, the input becomes:
flex-direction: order;
order: 5;
justify-content: center;

And some quick usability improvements:

After clicking a tooltip, let's focus the input field again.
When the level menu is open and we open a code tooltip, let's close the level menu since it can block the tooltip.

Thank you for review and bug reporting!
I'll fix everything you told.

Hey @thomaspark, I'm done task you said. I look forward to your review. :)

Hello @thomaspark , we've been waiting for your reply for almost a month. 😂
I'm really sorry, but can you confirm just one more time?

Hi all,
The new feature is working super! I just noticed two things in my testing:

When clicking a property name that's mentioned inside the tooltip (align-items for align-self, flex-direction and flex-wrap for flex-flow), the behavior is buggy.
For example, clicking align-items inside the align-self tooltip will add align-self: align-items; the first time. Additional clicks will append align-items: ; each time.
I think the expected behavior would be either to fill in the clicked property with its default value, or ignore the click. What do you think?

Instead of setting cursor: pointer; in JS on line 373, how about we move it to the CSS?

Hi @thomaspark
First, Thank you for review and testing!
My thoughts on the cases that you told as follows.

In this case, I think it's better to ignore the click. I will change the code to ignore the click.
That's good idea. I will move that

Hey @thomaspark
I finished editing code!
I'll be waiting for your quick review. :)

Hi @qowlz, it looks ready to go! Thanks to you and @dayo2n, @moo-nerim, @2Ju0 for your major contribution.


Changed Code in Paint to i18next

This PR fixes issue #1378

[x] Webl10n replaced everywhere in Paint Activity
[x] Tutorials checked, working Fine
[x] Tutorials, converted to their languages
[x] No conflicts

@llaske , could you please review it

Thanks.
There is two issues:

[ ] The language file is load continuously

[ ] The tooltip on buttons is not localized

On this former issue, I suggest you to read https://github.com/llaske/sugarizer-doc/issues/42#issuecomment-1777916993

@llaske, added tooltip localization
fixed continous loading, could you please review it please

The continuous loading is still here on my side.

@Vishalk91-4  are you still working on it?

@Vishalk91-4 are you still working on it?

Yes, I'll fix it, got ill in the last 3 days, so couldn't contribute, getting back to it now

Fixed in https://github.com/llaske/sugarizer/pull/1487


feat: preparation for fastify@5

Ref: fastify/fastify#5116
Checklist

[x] run npm run test and npm run benchmark
[x] tests and/or benchmarks are included
[ ] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin
and the Code of conduct

@simoneb, Please create a next branch for this pull request.

done and rebased

Hmm, I think this repo can use the standard workflow, but it first needs to change on main


Improve crate 4.x support

Since cratedb 4.0 timestamp is deprecated and may be removed any time soon. This update, provide timestamptz support for cratedb >= 4.0

Same applies to other data types we use:

https://crate.io/docs/crate/reference/en/4.2/appendices/release-notes/4.0.0.html#general

Deprecated types have been aliased so nothing is going to break for the next couple of releases I'd imagine, but since we're at it, I suggest we take care of the other types too---string, long and not sure what else?

Same applies to other data types we use:

https://crate.io/docs/crate/reference/en/4.2/appendices/release-notes/4.0.0.html#general

Deprecated types have been aliased so nothing is going to break for the next couple of releases I'd imagine, but since we're at it, I suggest we take care of the other types too---string, long and not sure what else?

not a problem, but there is a substantial difference, timestamp generates billions of logs in crate, the others don't.

not a problem

I saw the new commit, good stuff!

timestamp generates billions of logs in crate, the others don't.

Shaw! I wonder why.


[ci] fetch git history to prevent errors while executing make targets

our make system requires some prerequisites being done prior executing targets. though it does not fail actual tests but may create confusion while searching CI logs for errors.
fatal: No names found, cannot describe anything.
Usage:
  semver bump (major|minor|patch|release|prerel <prerel>|build <build>) <version>
  semver compare <version> <other_version>
  semver get (major|minor|patch|release|prerel|build) <version>
  semver --help
  semver --version
Arguments:
  <version>  A version must match the following regex pattern:
             "^[v|V]?(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)(\-[0-9A-Za-z-]+(\.[0-9A-Za-z-]+)*)?(\+[0-9A-Za-z-]+(\.[0-9A-Za-z-]+)*)?$".
             In english, the version must match X.Y.Z(-PRERELEASE)(+BUILD)
             where X, Y and Z are positive integers, PRERELEASE is an optional
             string composed of alphanumeric characters and hyphens and
             BUILD is also an optional string composed of alphanumeric
             characters and hyphens.
  <other_version>  See <version> definition.
  <prerel>  String that must be composed of alphanumeric characters and hyphens.
  <build>   String that must be composed of alphanumeric characters and hyphens.
Options:
  -v, --version          Print the version of this tool.
  -h, --help             Print this help message.
Commands:
  bump     Bump <version> by one of major, minor, patch, prerel, build
           or a forced potentially conflicting version. The bumped version is
           shown to stdout.
  compare  Compare <version> with <other_version>, output to stdout the
           following values: -1 if <other_version> is newer, 0 if equal, 1 if
           older.
  get      Extract given part of <version>, where part is one of major, minor,
           patch, prerel, build.
  validate Check version string is valid
fatal: No names found, cannot describe anything.

the option of fix is for each checkout add following configuration:
with:
  fetch-depth: 0

fixed with #1549


multi-call

Is it possible to make multicall in one request ? How ?
(RFC: system.multicall)

This client does not support multicalls.
A feature that could possibly be added by a succeeding maintainer, that I am currently looking for, see #49.


ctx.sendChatAction is undefined

The logging results in: { reply: [Function: reply], sendChatAction: undefined }
Why is sendChatAction undefined?
P.S. The search function is called directly from a middleware — bot.on(':text', search)

The solution is to use either ctx.api.sendChatAction or ctx.replyWithChatAction. Closed now.


how to get access to history data

Hello! Thank you very much for this library, I would like to know if it is possible to access the history of the airport and limit it by dates, and if it is possible to access the history of flight paths by aircraft (latitude, longitude and elevation).

Hi - this is not possible. You will have to first download the full history and then filter on the client side. The library is just a wrapper over HTTP calls made by the FR24 pages, so it cannot implement any complex logic.
Search by flightpath is not possible because there is no such data on FR24 pages.


High cpu usage Dart 99 on m1 macbook air

I'm developing flutter using Intellij IntelliJ IDEA 2021.2.4 (Community Edition), and I'm facing problem with high cpu usage for dart (99)
This tracker is for issues related to:

Analyzer

Dart 2.15.1

MacOSX  Monterey 12.2

Flutter 2.8.1 • channel stable

Another note, It happens while debugging in android only, iOS is fine

Me too, I have a macbook pro M1, and it is bad, any build that I start with flutter my machine die, and this happens only with flutter projects, I have some native android projects with multiple modules and a lots of dependencies and this problem does not happen.

I'd suggest updating to the (just) released latest Flutter/Dart and let us know if you're still seeing this.

Deleting all flutter files, caches and configs from my Mac seems to solve the problem, but is still bad the build time and memory consumption. I believe that this problem will be fixed when the team finish the m1 support for flutter

I'd suggest updating to the (just) released latest Flutter/Dart and let us know if you're still seeing this.

I have just upgraded to Flutter 2.10.2, and so far it seems to be solved, didn't happen yet.

Same issue here, also on Mac M1. By following this issue in Dart Code repo I ended up here.
I can tell it's still happening with Flutter 2.10.3 and Dart 2.16.1.
I've noticed some dart processes keep running even after I close VS:

(In the Activity Monitor they show as "Kind: Intel", in case that matters).
maganap@Magas-Air projects % ps -A | grep 69006
69006 ??       498:54.84 /Users/maganap/development/flutter/bin/cache/dart-sdk/bin/dart --disable-dart-dev --packages=/Users/maganap/development/flutter/packages/flutter_tools/.packages /Users/maganap/development/flutter/bin/cache/flutter_tools.snapshot daemon

I also noticed this same process runs when opening a Flutter project in VS, but it's only for a few seconds, then it disappears. Apparently in some situations it does not, and gets stuck at 100% CPU, but I haven't been able to tell exactly when.  I only notice they are stuck when I start burning my hands laying on the macbook air  xD

By killing the process it all goes back to normal (CPU ~40ºC on idle)... until it happens again.
In the other thread they mentioned it could be caused by VS not handling properly the dart extensions, so here's more info in case it helps:
[✓] Flutter (Channel stable, 2.10.3, on macOS 12.0.1 21A559 darwin-arm, locale en-GB)
    • Flutter version 2.10.3 at /Users/maganap/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7e9793dee1 (10 days ago), 2022-03-02 11:23:12 -0600
    • Engine revision bd539267b4
    • Dart version 2.16.1
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/maganap/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] VS Code (version 1.65.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.36.0

[✓] Connected device (1 available)
    • Maga's iPhone (mobile) • 99a0972ee9d455d6d9435741c1ee5b0c131ee172 • ios • iOS 15.3.1 19D52

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

From Visual Studio -> Developer: Show Logs... -> Extension Host:
[2022-03-12 16:13:35.481] [exthost] [info] Extension host with pid 285 started
[2022-03-12 16:13:35.481] [exthost] [info] Skipping acquiring lock for /Users/maganap/Library/Application Support/Code/User/workspaceStorage/f61138b9d15b00215d4feb54d357a3da.
[2022-03-12 16:13:35.588] [exthost] [info] ExtensionService#_doActivateExtension vscode.microsoft-authentication, startup: false, activationEvent: 'onAuthenticationRequest:microsoft'
[2022-03-12 16:13:35.605] [exthost] [info] ExtensionService#_doActivateExtension vscode.debug-auto-launch, startup: true, activationEvent: '*'
[2022-03-12 16:13:35.609] [exthost] [info] ExtensionService#_doActivateExtension vscode.git-base, startup: true, activationEvent: '*', root cause: vscode.github
[2022-03-12 16:13:35.612] [exthost] [info] ExtensionService#_doActivateExtension vscode.ipynb, startup: true, activationEvent: '*'
[2022-03-12 16:13:35.616] [exthost] [info] ExtensionService#_doActivateExtension Dart-Code.dart-code, startup: true, activationEvent: 'workspaceContains:pubspec.yaml'
[2022-03-12 16:13:35.641] [exthost] [info] ExtensionService#_doActivateExtension yzhang.markdown-all-in-one, startup: true, activationEvent: 'workspaceContains:README.md'
[2022-03-12 16:13:35.745] [exthost] [info] ExtensionService#_doActivateExtension vscode.markdown-math, startup: false, activationEvent: 'api', root cause: yzhang.markdown-all-in-one
[2022-03-12 16:13:35.846] [exthost] [info] ExtensionService#_doActivateExtension vscode.git, startup: true, activationEvent: '*'
[2022-03-12 16:13:35.863] [exthost] [info] ExtensionService#_doActivateExtension vscode.github, startup: true, activationEvent: '*'
[2022-03-12 16:13:35.978] [exthost] [info] ExtensionService#_doActivateExtension Dart-Code.flutter, startup: false, activationEvent: 'api', root cause: Dart-Code.dart-code
[2022-03-12 16:13:36.029] [exthost] [info] ExtensionService#_doActivateExtension bierner.markdown-image-size, startup: false, activationEvent: 'api', root cause: yzhang.markdown-all-in-one
[2022-03-12 16:13:36.071] [exthost] [info] Eager extensions activated
[2022-03-12 16:13:36.430] [exthost] [info] ExtensionService#_doActivateExtension vscode.emmet, startup: false, activationEvent: 'onStartupFinished'
[2022-03-12 16:13:36.438] [exthost] [info] ExtensionService#_doActivateExtension vscode.merge-conflict, startup: false, activationEvent: 'onStartupFinished'
[2022-03-12 16:13:36.441] [exthost] [info] ExtensionService#_doActivateExtension vscode.github-authentication, startup: false, activationEvent: 'onAuthenticationRequest:github'

"Kind: Intel" – we have not yet ported our Flutter tools to run natively under M1 – this may be us paying the cost of emulation (Rosetta2).
CC @mit-mit – seems this could/should be closed and pointed to migration work on the Flutter side?

The Flutter tracking issue is https://github.com/flutter/flutter/issues/60118

Same issue on my side as well. Any work around?

M1 support is now available in Flutter. If anyone is still having issues with Flutter 3.0 or later, kindly file a new issues with as many details as possible.

I didn't experience any issue with Flutter 3, It supports M1 and works fine.


oracle-instantclient: support aarch64-darwin

Description of changes
Add support for aarch64-darwin (m1) for oracle-instantclient.
https://www.oracle.com/database/technologies/instant-client/macos-arm64-downloads.html
Oracle only release libs in DMG files, so unpack cmd is bit different. x86-64_darwin should also be updated later.
It also includes minor patch (rel). Tested working on M1.
My team is using this package actively, I will maintain this package if it's okay.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[x] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4477

I believe the merge conflict in this PR is just in the maintainer list. Is there anything I can do to help get the changes made and this PR merged?

Oh I'm sorry. I completely forgot to send fix.. Will check this week.
2024년 11월 21일 (목) 오전 6:16, Josh Asplund @.***>님이 작성:

I believe the merge conflict in this PR is just in the maintainer list. Is
there anything I can do to help get the changes made and this PR merged?
—
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/335529#issuecomment-2489556334,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AL74KBMBI4NHDRA2J4QEHFT2BT3ZFAVCNFSM6AAAAABMWDM5ROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBZGU2TMMZTGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hey @aca, you can close this PR because changes were merged in the https://github.com/NixOS/nixpkgs/pull/366184 PR. Thanks for your attempt. I wouldn't do the same fast without your work 🙇♂


Searching in Metrics Explorer is extremely slow

What did you do?
Opened metrics explorer and searched for a 12-char string.
What did you expect to see?
Results (pretty quickly)
What did you see instead? Under which circumstances?
It clearly ran the search for every keystroke, and over our 4565 metrics, this took a few seconds
Likely cause
It seems the nexucis/fuzzy package is slow (or we just have too many metrics)
Potential solutions

Find a much faster fuzzy search implementation
Debounce keypresses in the search field
Only search on enter or button press
When a search finishes, skip intermediate keystrokes and search only the most up-to-date input value

Actually, when there aren't many results, it's fast (almost instantaneous).
It's when I search for something very common that the latency is really noticeable.
Maybe that means it's the actual rendering that's slow?

I Have the same problem

Hello from the bug scrub!
This might all be very different with the new UI. We are closing this and would like to ask you to file a new issue if the new UI has a similar problem.


Remove extra init from SelectivityVector

Remove extra calls to SelectivityVector::updateBounds()
Do not call updateBounds when the bounds are either known or will be
overwritten. Add a resizeFill method that sets the size and contents
and does not call updateBounds.
Add LocalSelectivityVector interfaces that initialize the vector from
another vector or from size and value.
Fix SelectivityVector::== to only consider bits in between begin_ and
end_.

The point is not to call updateBounds on init. This is in top 10 of profile in Kevin’s test. So, whenever the selectivity vector will be written right after being acquired, merge the init into the acquire. There is no case ever of a sel vector from resource not getting overwritten first thing.
So, simplified call sites.

Added a test for the  new variants of things in EvalCtx.


Sync with Video

Any examples on how I can sync a live video recording using GPUImage with the live audio recording of AudioKit.
Thanks!

This would be more a discussion group item rather than issue since its not really a bug or anything.  But no, we don't have an example like that.


DepthGaussianNoise integration test fails on some HW

I noticed DepthGaussianNoise fails on my machine but works fine in the CI server.
The integration fails:
[ RUN      ] GaussianNoise/RenderPassTest.DepthGaussianNoise/ogre2
/home/matias/Projects/ign/src/ign-rendering/test/integration/render_pass.cc:357: Failure
Expected equality of these values:
  255u
    Which is: 255
  ma
    Which is: 0
[  FAILED  ] GaussianNoise/RenderPassTest.DepthGaussianNoise/ogre2, where GetParam() = "ogre2" (12204 ms)

To be more specific the integration expects an alpha value (packed/encoded) of 255, but instead it's 0.
Upon closer examination, this is because the test uploads this colour texture:

However the texture is of format R8G8B8_SRGB, therefore GPUs are allowed to do whatever they want with the alpha value.
In the case of my AMD Radeon RX 560 2GB using Mesa drivers, it decides to fetch an alpha of 0 instead of 255, thus causing the test to fail.
This bug should fix itself in the Ogre 2.2 version, because Ogre 2.2 explicitly forbids the use of RGB888 textures in the GPU. The PFG_RGB8_* family of pixel formats can only be used for CPU operations.
Environment

OS Version: Xubuntu 18.04 LTS
Source or binary build? https://github.com/ignitionrobotics/ign-rendering/commit/07c4ca96c924db4004ccab9e0b7a1e6ac5b1b033

Rendering plugin: ogre2

[x] running on real hardware

Rendering system info:

direct rendering: Yes
    Preferred profile: core (0x1)
    Max core profile version: 4.6
    Max compat profile version: 4.6
    Max GLES1 profile version: 1.1
    Max GLES[23] profile version: 3.2
OpenGL vendor string: X.Org
OpenGL renderer string: Radeon RX 560 Series (POLARIS11, DRM 3.40.0, 5.11.0-051100-generic, LLVM 10.0.1)
OpenGL core profile version string: 4.6 (Core Profile) Mesa 20.1.3 (git-663fa46287)
OpenGL core profile shading language version string: 4.60
OpenGL core profile context flags: (none)
OpenGL core profile profile mask: core profile
OpenGL version string: 4.6 (Compatibility Profile) Mesa 20.1.3 (git-663fa46287)
OpenGL shading language version string: 4.60
OpenGL context flags: (none)
OpenGL profile mask: compatibility profile
OpenGL ES profile version string: OpenGL ES 3.2 Mesa 20.1.3 (git-663fa46287)
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20

08:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Baffin [Radeon RX 550 640SP / RX 560/560X] [1002:67ff] (rev cf)

root      1680  1.4  0.5 2840064 165080 tty7   Ssl+ 18:35   0:27 /usr/lib/xorg/Xorg -core :0 -seat seat0 -auth /var/run/lightdm/root/:0 -nolisten tcp vt7 -novtswitch
matias   11249  0.0  0.0  17988  1032 pts/2    S+   19:05   0:00 grep --color=auto Xorg

Description

Expected behavior: Test should pass
Actual behavior: Test fails

Steps to reproduce

Run ign/build/ignition-rendering5/bin/INTEGRATION_render_pass
Use AMD Radeon RX 560 2GB HW, Mesa drivers.

Workaround
Run the test with LIBGL_ALWAYS_SOFTWARE=1
Other
This bug is incredibly low priority for me; given that the CI does its job, I can comment out the failing lines involving alpha or workaround it with SW, and that it should fix itself with Ogre 2.2

I may have closed https://github.com/ignitionrobotics/ign-rendering/issues/175 too soon. This test had been flaky on macOS CI.


How to add preventOverflow

Hi, and thank for this ember wrapper of the lib.
At the moment it works nicely, except I was wondering how can I add preventOverflow with boundaries (.ember-application in our case)?
Thanks.

You can pass an object for modifiers:
{{#ember-popper
  modifiers=(hash
    preventOverflow=(hash
      boundariesElement=".ember-application"
    )
  )
}}

modifiers just gets directly passed to popper so you can configure it per the popper docs

Awesome! Thank again.


File Systems mounted on junctions fail

Windows Version
Microsoft Windows [Version 10.0.22631.3007]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-1
Distro Version
Arch Linux
Other Software
n/a
Repro Steps
https://github.com/microsoft/WSL/issues/3759 Previously reported, and not fixed.
mkdir c:\general
mkdir c:\general\work

create VHD
mount VHD on a folder c:\general\work
in WSL go to /mnt/c/general/work  and get Input/output error
[d3x0r@tundra sack-gui]$ ls /mnt/c/general/work
ls: cannot access '/mnt/c/general/work': Input/output error

Expected Behavior
Use folder like any other folder on system.
Actual Behavior
Unable to access partitions mounted on folders as a junction.
Diagnostic Logs
No response

/logs

Thank you @d3x0r. The fix for this should be in the latest insider build now (22635.3350  has the fix).