Error installing awsebcli

Orb version:
2.0.1
What happened:
During 'Setting Up Elastic Beanstalk CLI' Step, receiving the following error:
Installing collected packages: click, userpath, packaging, argcomplete, pipx
Successfully installed argcomplete-3.1.1 click-8.1.5 packaging-23.1 pipx-1.2.0 userpath-1.8.0
WARNING: You are using pip version 20.3.4; however, version 23.2 is available.
You should consider upgrading via the '/usr/bin/python3 -m pip install --upgrade pip' command.
creating virtual environment...
creating shared libraries...
upgrading shared libraries...
installing awsebcli...
Fatal error from pip prevented installation. Full pip output in file:
    /home/circleci/.local/pipx/logs/cmd_2023-07-17_17.58.20_pip_errors.log

pip seemed to fail to build package:
    PyYAML<5.5,>=5.3.1

Some possibly relevant errors from pip install:
    error: subprocess-exited-with-error
    AttributeError: cython_sources

Error installing awsebcli.

Exited with code exit status 1

Expected behavior:
It should install awsebcli correctly.
Additional Information:
Was working fine earlier today, this is pretty recent.

+1

This coincides with the release of Cython 3.0...

Orb version:
2.0.1
What happened:
During 'Setting Up Elastic Beanstalk CLI' Step, receiving the following error:
Installing collected packages: click, userpath, packaging, argcomplete, pipx
Successfully installed argcomplete-3.1.1 click-8.1.5 packaging-23.1 pipx-1.2.0 userpath-1.8.0
WARNING: You are using pip version 20.3.4; however, version 23.2 is available.
You should consider upgrading via the '/usr/bin/python3 -m pip install --upgrade pip' command.
creating virtual environment...
creating shared libraries...
upgrading shared libraries...
installing awsebcli...
Fatal error from pip prevented installation. Full pip output in file:
    /home/circleci/.local/pipx/logs/cmd_2023-07-17_17.58.20_pip_errors.log

pip seemed to fail to build package:
    PyYAML<5.5,>=5.3.1

Some possibly relevant errors from pip install:
    error: subprocess-exited-with-error
    AttributeError: cython_sources

Error installing awsebcli.

Exited with code exit status 1

Expected behavior:
It should install awsebcli correctly.
Additional Information:
Was working fine earlier today, this is pretty recent.

as a workaround for the eb/setup, you can bypass the orb and configure the step as follows:

run: |
sudo wget https://bootstrap.pypa.io/get-pip.py
sudo python3 ./get-pip.py
sudo pip install "pyyaml<5.4"
sudo pip install --upgrade setuptools
sudo pip install --upgrade pip awsebcli

@NMPHalpern
Thank you for sharing the workaround! We had the same problem in our environment and were having trouble, but we will adopt this one.

@NMPHalpern Thanks for the workaround. Can confirm this is working for us.
I'll leave this open as the orb is still broken, but at least we're deploying again.

Having the same issue...

Having the same issue. The workaround worked perfect! Since I execute eb/setup once on every environment, I went ahead and made the workaround a reusable command to avoid copy pasting the same lines multiple times:
commands:
  setup-ebcli:
    steps:
      - run:
          name: 'Install pip and awsebcli'
          command: |
            sudo wget https://bootstrap.pypa.io/get-pip.py
            sudo python3 ./get-pip.py
            sudo pip install "pyyaml<5.4"
            sudo pip install --upgrade setuptools
            sudo pip install --upgrade pip awsebcli

I just call that one command on any jobs that need it like this:
jobs:
  job-name-goes-here:
    steps:
      - checkout
      - setup-ebcli

Will there be a fix any time soon?

Hey Everyone,
Thanks for opening this issue. I am taking a look at this now and will include this in the next release.
Thanks again for reporting!
Best,
Brian

Hey Everyone,
Thanks for opening this issue. I am taking a look at this now and will include this in the next release.
Thanks again for reporting!
Best, Brian

Hi Brian, any ETA on fixing this? Attempts to run 'pip install awsebcli' fail every time, due to this pyaml issue. installing an older version of PyYAML is not an option for me as a workaround -- and per the aws cli thread on this same issue, PyYAML 6.0.1 has resolved the issue with cython, but awsebcli (note: EBcli, not regular cli) caps at PyYAML<5.5). I'm guessing your next update of awsebcli will make it compatiable with PyYAML 6.01 ?
I need to use the awsebcli on a new system I'm setting up, so this is a pressing issue for me, any updates would be greatly appreciated, thansk!

Hey @m-hollow,
I investigated this further and it seems like awsebcli will not work with the latest version of PyYAML. It definitely gets capped at 5.5` and it's on the maintainers to change that.
I took a look at the logs and it seems that the setuptools library, which is responsible for building and installing Python packages, encountered an issue during the setup of the PyYAML package. It's using a deprecated parameter in the setup.cfg file:
Collecting PyYAML<5.5,>=5.3.1 (from awsebcli)
  Downloading PyYAML-5.4.1.tar.gz (175 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 175.1/175.1 kB 2.1 MB/s eta 0:00:00
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'error'

PIP STDERR
----------
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [62 lines of output]
      /tmp/pip-build-env-e3gev5v9/overlay/lib/python3.10/site-packages/setuptools/config/setupcfg.py:293: _DeprecatedConfig: Deprecated config in `setup.cfg`
      !!

              ********************************************************************************
              The license_file parameter is deprecated, use license_files instead.

              By 2023-Oct-30, you need to update your project and remove deprecated calls
              or your builds will no longer be supported.

              See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
              ********************************************************************************

      !!

Having said that, I've determined that installing the awsebcli will not work with pipx, which enables users to install the awsebcli in an isolated environment to ensure they don't interfere with other tools running on Python.
It will install with pip but this can be problematic because the awsebcli can conflict with other installed packages, especially when dealing with different project requirements.
I've tried installing with virtualenv following the instructions from the awsebcli repository but am running into the same error.
@BenGale  @NMPHalpern @tubone24 @AbdelrahmanManz @paulipotter @GhassenRjab
The work around above installs the cli with pip. Does this solution work for you all? Let me know and I'll get a fix out by Monday at the latest.

@brivu Can confirm the workaround above still works for me.

@brivu Can confirm the workaround above still works for me.

Abdel, what version of PyYAML is installed when you use the workaround?
Based on the workaround instructions --
run: |
sudo wget https://bootstrap.pypa.io/get-pip.py
sudo python3 ./get-pip.py
sudo pip install "pyyaml<5.4"
sudo pip install --upgrade setuptools
sudo pip install --upgrade pip awsebcli
I'm assuming it's 5.3.x -- which I can't run, I've encountered issues in the Elastic Beanstalk configuration in AWS when using PyYAML 5.3.1, and it's also been mentioned (in the similar thread about awscli) that it has security issues as well.
But I may be misunderstanding something about the workaround. Could someone please explain how this workaround even works? I'm not getting what's going on --
• why the wget line to obtain get-pip.py ? why is this necessary if one already has pip installed?
• why 'upgrade setuptools' ? what does this achieve?
•(as already asked) what version of PyYAML gets installed?
thanks, I appreciate it!

Hey @m-hollow - You're right, it's 5.3.1. Can you send me some info about the security issue for the aws cli?

so there's a thread about this same issue as it pertains to awscli (vs awsebcli), with this:
"We do not recommend installing an older version of PyYAML as PyYAML version 5.3.1 is associated with CVE-2020-14343 that was fixed in version 5.4."
here's the thread:
https://github.com/aws/aws-cli/issues/8036
Also, when I did an EB deployment with PyYAML 5.3.1 I wound up with configuration errors in EB -- however, I can't say absolutely they were caused by pyyaml, but the degradation to 5.3.1 (from previously a working 5.4) was the new variable, so to speak, in my deployments at the time.

@m-hollow I added a comment to the same issue in their repository. If everyone here can also do the same, hopefully we can get some traction and have them fix it sooner rather than later.


CNF-13181: Allow partial completion before moving to next CGU

Before this change, when multiple CGUs were chained together, the first CGU had to completely finish before the next CGU was allowed to start. This meant that if one cluster failed, the next CGU could not start for the remaining clusters.
Now, by setting the blockingCRCompletionMode annotation to partial, dependent CGUs start for clusters that are compliant with the previous CGUs.
/cc @jc-rh

/lgtm

/lgtm

/approve


Encapsulate SyncButton as a Widget to Simplify Implementation

Description:
Currently, the SyncButton handler function is passed through ui:options in rjsf, which is not ideal as ui:options are meant for rendering guidance. This adds unnecessary complexity to the code.
To address this, we need to encapsulate the SyncButton into a custom widget (e.g., SyncButtonWidget). Doing so will not only simplify the logic but also make it more maintainable and scalable, especially as we plan to add the SyncButton to additional locations such as the Operation Review Page.
This task includes:

Creating a SyncButton widget that handles the sync logic.
Refactoring the existing implementation to remove the use of ui:options for passing handler functions .

@pbastia Created this card to handle sync button widget


⬇  pytest: install and configure Pytest

added pytest and pytest-django to pipfile
created pytest ini config file

Maybe you should add configuration to run PyTest tests in GitHub actions as well.

Please rebase


live555 change from April 6 causes breaking change

Hi, I am working on a camera with a raspberry pi zero and I successfully compiled this project yesterday but today I'm getting an error that TCPStreamSink.hh is missing. I did some investigation and found that live555 project updated today. The CMakeList.txt file is referring to the "latest" package.
This issue is easily reproducible by 1. cloning the project, 2. "cmake ." and 3. "make". at 98% of the make process the compilation fails.

@mpromonet thank you so much for the hot fix. Just confirming that it now compiles successfully.

Hi kshala,
Finally I fix the problem and revert to the last live555 since commit https://github.com/mpromonet/v4l2rtspserver/commit/be67798772d00929c4af6b0b31f2bbea6d49c3b4
Best Regards,
Michel.


Improve error messages for 403's

Attempts to update or delete public collections return a standard 403 message with no useful detail. Let's add verbiage along the lines of "Cannot delete a public collection via Curator API" and "Updating a public collection is not allow; you must create a revision."
I suggest simply adding an error_detail parameter to this function, where it can then be passed as detail=<error detail> to ForbiddenHTTPException constructor.

I think this may be ameliorated by my updates to the notebooks per my comments here.

In fact, yes: you should see the error we return here now with the latest notebooks on my development branch in the curation repo

Made edits to give a good message for 403 in response to PATCH /collections/{collection_id}


[ZT] Remove special-class divs

Closing this out as it's serving a purpose (preventing the weird hugo bug that's frustrating)


Typo: Vector Databases

In this page: https://github.com/zahaby/intro-llm-rag/blob/main/main-aspects/vectorstores.md
It is preferable to remove the "is" word below in "in a way that is":

...
Either way, fantastic and helpful repo. Thanks! 🙌

In this page: https://github.com/zahaby/intro-llm-rag/blob/main/main-aspects/vectorstores.md
It is preferable to remove the "is" word below in "in a way that is":

...
Either way, fantastic and helpful repo. Thanks! 🙌

Thank you very much for thoroughly reviewing the documentation.


Inability to set custom console command description programatically

I'm requesting this feature after asking if what I wanted to do was already possible via the yii channel on freenode, and being told no, and asked to open an issue here.
Basically I have a Yii 2 app , advanced template, with a bunch of console commands, quite a few of which are functionally similar. I've abstracted that functionality out to an inherited class of yii\base\Action, in this case console\components\actions\PullSyncAction, and, with some parameters that I set up on that action, I can thus configure it under the actions method of my console controller to handle multiple actions, all of which kind of do a similar. It all seems to work well.
You can see a gist of what I mean here
My question is, would it be possible to introduce a way to set the action description (what shows up next to the console command on the command line) programatically in the actions method array of the controller, rather than culling the description from the comment above the action.
With the current method of using the comment above the action, and with no way to set the description programatically via that actions array, I can't provide descriptions to each of my controller actions.

You can do so via:

https://github.com/yiisoft/yii2/blob/master/framework/console/Controller.php#L428
https://github.com/yiisoft/yii2/blob/master/framework/console/Controller.php#L440
https://github.com/yiisoft/yii2/blob/master/framework/console/Controller.php#L450
https://github.com/yiisoft/yii2/blob/master/framework/console/Controller.php#L460
https://github.com/yiisoft/yii2/blob/master/framework/console/Controller.php#L482
https://github.com/yiisoft/yii2/blob/master/framework/console/Controller.php#L540


Revert "7470 - added onLayout to textinput perent component & used dynamic he…"

Reverts Expensify/App#9294
Fixes https://github.com/Expensify/App/issues/10085

Merging to fix the deploy blocker. Thanks @marcaaron!

🚀 Cherry-picked to staging by @luacmartins in version: 1.1.86-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by @yuwenmemon in version: 1.1.86-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Store documentation images inside repository.

Fix #399

:tada: This PR is included in version 1.0.1 :tada:
The release is available on:

1.0.1
GitHub release

Your semantic-release bot :package::rocket:


[ENG-10566][eas-cli] add selectedImage to build metadata

Why
To accomplish https://linear.app/expo/issue/ENG-10566/create-a-banner-that-links-people-to-changelog-on-build-details-pages www needs to know which image was selected by the user to run the build on.
Companion to https://github.com/expo/universe/pull/13889
How
Add the selectedImage field to the build's metadata, so we know what value the user put in their eas.json->build->profile->platform->image.
Test Plan
After https://github.com/expo/universe/pull/13889 is merged and I regenerate GQL schema test manually

/changelog-entry chore Add selectedImage and customNodeVersion information to build metadata


Nuimo controller component based on SDK

This is a continuation of the Nuimo device integration as in PR https://github.com/home-assistant/home-assistant/pull/1487, but now with the help of the SDK.
Example entry for configuration.yaml:
nuimo_controller:
  mac: 'CE:B5:12:25:21:89'

See PR https://github.com/home-assistant/home-assistant.github.io/pull/865 in home-assist.io for further instructions
Checklist:
If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If code communicates with devices, web services, or a:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Nuimo controller component based on SDK

Cool controller, didn't see this thing before. It would be good to be able to support multiple controllers on the same HA instance. Any idea how to do this?
Maybe just having a name for each of it and using this in the messages might already be enough.

@open-homeautomation good idea, I'll add this

🐬


Attack animation loop 1.19.2/1.19.4/1.20.1

https://github.com/NerdyPuzzle/MCreator-Nerdys_Geckolib_Plugin/assets/87606666/a7938899-e203-49bc-a291-42e345525cc0

It's because you used the aggression animation and not the attack animation. The aggression animation plays on loop while the mob is angry.

so what could it be

Perhaps you have a loop in the animation

Does the issue persist if you put the animation into "play once" mode in blockbench?

will test in a bit to see

ah it seems to fix it idk why in 2023.1 version of the plugin  it was fine being loop but that is fine for me to fix my animations for 2023.3

It's the geckolib mod's new feature, blockbench loop modes take priority over code.

ah ok

Idk why I kept this issue open but it should be closed.


Console output function case is incorrect

Challenge Return a Value from a Function with Return has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

// Example
function minusSeven(num) {
  return num - 7;
}

// Only change code below this line
function timesFive(num) {
  return num * 5;
}

The code above passes the test, but the console output shows the function in lower case only: timesfive(5) === 25 instead of timesFive(5) === 25 like it should.

Hi @jdsandifer! Thank you for reporting this issue.
It appears that this issue is a duplicate of #9583. That issue was fixed recently. The changes are present in the beta, and will be released as soon as the beta is released. 👍
I'm closing this as a duplicate.. Happy coding!


0.37.3 causes a black window for Hain

Original issue: appetizermonster/hain#81
Reverting to 0.37.2 seems to fix this. Let me know if you need more information from me.

I think you want to open an issue here https://github.com/atom/electron/issues

On it.


How to make annotations for the images without any object?

Hello, thank you very much for sharing this great code.
I encounter a problem when I train this detection model on my own custom dataset. I do not know how to make the annotation for the images without any object? The bbox shoud cover whole images? I trained the model for single object detection.

@cltdevelop in this particular code, images without annotations is ignored. As seen in the code below. If you just leave them blank that's fine. However if you'd like to use them, you'll have to configure some code.
https://github.com/jwyang/faster-rcnn.pytorch/blob/28db6d0b313220d200b739f4e22410fbe35529f4/lib/roi_data_layer/roidb.py#L75-L86

OK, thank you!
So if I want to use the images without bbox, how to configure this code.

@cltdevelop
I'm not sure. I haven't done the configurations myself. I just know you'll be starting from this code. Otherwise you can label the annotations a certain class and ignore that class during classification. That's a quick and dirty way. Good luck.

I tried to comment out filter_roidb however I get the following error:
Traceback (most recent call last):   File "trainval_net.py", line 312, in <module>     data = next(data_iter)   File "/home/ubuntu/anaconda3/envs/pytorch_p27/lib/python2.7/site-packages/torch/utils/data/dataloader.py", line 188, in __next__     batch = self.collate_fn([self.dataset[i] for i in indices])   File "/home/ubuntu/frcnn_sep12/faster-rcnn.pytorch/lib/roi_data_layer/roibatchLoader.py", line 74, in __getitem__     gt_boxes = torch.from_numpy(blobs['gt_boxes']) RuntimeError: the given numpy array has zero-sized dimensions. Zero-sized dimensions are not supported in PyTorch
I am trying to see how I can add a zero or zero-sized tensor for images having no bounding boxes however I am intrigued by the following piece of code, whether would it create complications given a zero tensor. @jwyang Your guidance on this will be really helpful.
`
# check the bounding box:
not_keep = (gt_boxes[:,0] == gt_boxes[:,2]) | (gt_boxes[:,1] == gt_boxes[:,3])
keep = torch.nonzero(not_keep == 0).view(-1)
    gt_boxes_padding = torch.FloatTensor(self.max_num_box, gt_boxes.size(1)).zero_()
    if keep.numel() != 0:
        gt_boxes = gt_boxes[keep]
        num_boxes = min(gt_boxes.size(0), self.max_num_box)
        gt_boxes_padding[:num_boxes,:] = gt_boxes[:num_boxes]
    else:
        num_boxes = 0

        # permute trim_data to adapt to downstream processing
    padding_data = padding_data.permute(2, 0, 1).contiguous()
    im_info = im_info.view(3)

    return padding_data, im_info, gt_boxes_padding, num_boxes
else:
    data = data.permute(0, 3, 1, 2).contiguous().view(3, data_height, data_width)
    im_info = im_info.view(3)

    gt_boxes = torch.FloatTensor([1,1,1,1,1])
    num_boxes = 0

    return data, im_info, gt_boxes, num_boxes

`

Hey there, is there any solution for this?


Implement ＠defer "June 2023" response format

Implements the latest (as of 2024-12-17) ＠defer incremental response format as seen in examples and spec edits.
This shouldn't be merged as-is, as at least the end-to-end tests with the Router will fail.
There may be a way to have both the "old" (20220824) and latest formats working but not sure this would be useful.

🛠 Docs Preview Building...

Configuration
{
  "repoOverrides": {
    "apollographql/apollo-kotlin@main": {
      "remote": {
        "owner": "apollographql",
        "repo": "apollo-kotlin",
        "branch": "defer-incremental-response-format-june-2023"
      }
    }
  }
}

e2da85981d4735fb33f48f5cb75e01db33ee1b62


Documentation

Basically we only want to document what functions are provided and what their semantics and interface is.

Fine tune later.


About nginx proxy authentication issues

Description
If I use nginx as a proxy, can I pull the image without authentication, but push the image with nginx's basic auth authentication?

Closing. Please ask in https://github.com/distribution/distribution/discussions


Abnormal calculated value

Describe the bug
import { render,effect } from "solid-js/web";
import { createSignal } from "solid-js";
function Counter() {
const [count, setCount] = createSignal(0);
const increment = () => setCount(count() + 1);
setInterval(()=>{
console.log('xxxx--->',count()) // Why two different values printed here when changed the count value
},2000)
effect(()=>{
console.log(count())
})
return (

{count()}次

);
}
render(() => , document.getElementById("app")!);
Your Example Website or App
https://playground.solidjs.com/anonymous/3330aa56-7de4-41d7-a472-4c1c7fd888c0
Steps to Reproduce the Bug or Issue
1.click button
2.look console.log
Expected behavior
expected print the only last value
Screenshots or Videos
No response
Platform

OS: Windows10
Browser: Chrome
Version: 108.0.5359.124

Additional context
No response

I don't see any issues...

click buton then print:
xxxx---> 0
xxxx---> 1
........
click again when the count()=2 then print:
xxxx---> 0
xxxx---> 2
xxxx---> 0
xxxx---> 2
........

This is a playground problem, every time  you edit the code, it uses the same iframe for output.
without explicit cleanup  you ended up with multiple intervals running for each edit.

you can manually clearInterval in solid onCleanup hook.
https://playground.solidjs.com/anonymous/88f46233-3bc4-416d-b9f2-2062acc6fc04

or just referesh the output, after an edit, to start fresh.

Well not a playground problem, just a memory leak. The same thing happens if you boot up a Vite app with the same code.

playground / hmr
though, the playground could just refresh.

fwiw you would not see the leaked signal if you use createEffect instead of effect, which i'm actually not familiar with: https://playground.solidjs.com/anonymous/bc37be78-caa1-4cef-892f-57ad0997b331

Yeah it doesn't really matter which you use effect is an alias for createRenderEffect. This is just HMR when you don't clean up. Closing.


[Cosmos DB] Allow PITR restore with identity

Related command

az cosmosdb restore
Description

az cosmosdb restore --assign-identity {identity} --default-identity {identity}'
Add new ability to provide a user identity when restoring a Cosmos DB account with Continuous backup mode
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

Cosmos DB

hi @yonzhan, there are a few CI pipelines failing and the failure (Deprecated config in setup.cfg) doesn't look to be related to my change.  Can you help take a look and see why they've failed?
The same pipelines were passing last week.

/azp run


Make install process Windows compatible

Move node_module archiving to Procfile tar command, so it only run on Heroku, and fixes #1331 for those that run on Windows or don't have tar installed. It also adds node before the bower command which makes it Windows compatible.

Updated @vernak2539 . I'm sorry I didn't understand the comment.

:+1:

The archive is created in order to allow TravisCI to not run npm install.
It's what Bootstrap does, except they use Python and AWS.

right on

:+1:


Better error message if database is locked.

Fixes #546.

It’s not ideal, but there is no portable way to detect that particular issue in sled.


support cobo vault multisig import and signature

Description
Add Cobo Vault integration in this PR:

add Cobo Vault QRCode Scanner and Displayer
add Cobo Vault File reader
add fingerprint when generating extendedPublicKeyImporter
add BraidDetails to multisig when fetching UTXOs
add Cobo Vault extended public key import process
add wallet export process for Cobo Vault
add signature importer for Cobo Vault

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Does this PR fix an open issue?

[ ] Yes
[x] No

@soralit sorry but there are conflicts to resolve due to the merging of the cold card PR.

Note: this PR requires https://github.com/unchained-capital/unchained-wallets/pull/47 and https://github.com/unchained-capital/unchained-bitcoin/pull/23.

@waldenraines @humanumbrella Thanks for your review. Will resolve the issues mentioned above soon.

@waldenraines @humanumbrella Hi, I have already resolved conflicts with coldcord PR and moved bc-ur usage to unchained-wallets. Can you have a review again when you got any time?

Hi @soralit -
We will get to this as soon as we can. We are working on finishing up another project.
Sorry for the delays and we appreciate your patience!

Hi @soralit -
We will get to this as soon as we can. We are working on finishing up another project.
Sorry for the delays and we appreciate your patience!

OK, thanks a lot. My team can start testing next week.

Hi @bucko13 , Thank you for your review and sorry for the late reply, I'm busy on another work these days and our QA is still working on the functionality tests, I will fix the issues later. Thanks a lot.

Hi @bucko13 sorry for the late commits, I have fix the code styling issues. Please have a review when you have time.
Also modified related text to be more meaningful @waldenraines

Hi @bucko13 sorry for the late commits, I have fix the code styling issues. Please have a review when you have time.
Also modified related text to be more meaningful @waldenraines

@waldenraines @bucko13 @humanumbrella Thanks for your time and we have fixed all the comments, would you please review this pr again ?

@waldenraines @bucko13 @humanumbrella Thanks for your time and we have fixed all the comments, would you please review this pr again ?

Thanks for the updates! We will review ASAP and let you know if there's anything else.

Thanks for the updates! We will review ASAP and let you know if there's anything else.

Thanks for the updates! We will review ASAP and let you know if there's anything else.

Thanks a lot! and looking forward to the feedback

Thanks for the updates! We will review ASAP and let you know if there's anything else.

Thanks a lot! and looking forward to the feedback

@bucko13 @humanumbrella @waldenraines Hope everything works well. any feedback on this PR?

@bucko13 @humanumbrella @waldenraines Hope everything works well. any feedback on this PR?

I believe my Cobo device should arrive sometime today, so I will now be able to give this a full review / test with the device in the coming days.
I apologize for the delay, thank you for your patience!

I believe my Cobo device should arrive sometime today, so I will now be able to give this a full review / test with the device in the coming days.
I apologize for the delay, thank you for your patience!

I believe my Cobo device should arrive sometime today, so I will now be able to give this a full review / test with the device in the coming days.
I apologize for the delay, thank you for your patience!

no worries, Thanks a lot!

This prevents me from being able to test signing. Unsure if the problem is in unchained-wallets or here.

@aaronisme @soralit it looks like this is still an issue (see original comment above). We tested this with another user and another device and came out with the same result. Was this a known issue in your development, is there something on the user end that would cause this?

This prevents me from being able to test signing. Unsure if the problem is in unchained-wallets or here.

@aaronisme @soralit it looks like this is still an issue (see original comment above). We tested this with another user and another device and came out with the same result. Was this a known issue in your development, is there something on the user end that would cause this?

I think it is due to the old firmware on your device.
the caravan integration is only available on the pre-release btc-only firmware of Cobo Vault. we will send you the pre-release firmware via mail, sorry for that

Hi Soralit / CoboVault Team -
Some high level notes here. I tried to test again with the new firmware and was unable to test all the way (stuck on signing using regtest). I have detailed some of that at the end of this review and will send over the relevant files to help debug.

Please make sure you have added CoboVault to the test suite and make sure you can pass the same tests as Coldcard!
We would like to remove the Scan Cobo Wallet button, and instead use a shared button which will require some design input. Essentially instead of Import Wallet Configuration We can call it Import Wallet which will launch a modal with a selector, defaulted to Caravan. But if you choose CoboVault - then the flow continues as you have now.
Similarly we'd prefer no new Show Wallet For Cobo Vault button in the upper right after loading a wallet in Caravan, we'd like to use the same idea as ^ with a shared button and a selector
We need to make the BIP32 path editable in Caravan's xpub importer interface to match the other keystores. This will require revisions to the unchained-wallets class so it can handle this requirement. See unchained-capital/unchained-wallets#47 (review)
On usability -

When importing a wallet config from Caravan to CoboVault:

within the extendedPublicKeys section, the 'method' should be ignored for cobo purposes. The CoboVault appears to reject a wallet config as invalid if any of the other keys are missing the 'method' tags. Sometimes the method is not known and therefore missing.
Once an xpub is identified (by fingerprint) make sure to honor the BIP32 path, don't assume that it is m/45' (e.g. for P2SH). There is no requirement that all of the xpubs are at the same BIP32 path, so this will require allowing multiple Derivations.

QR code scanner:

Label what the zoom slider does, first thought it was a progress bar.
Maybe a note that if it’s taking a long time to scan to pause the video and step through the QR codes one by one.

Signing:

Must display transaction details in text on the signing page so the user can read them and verify as they sign, see Coldcard signing for an example.
We are unable to sign for transactions from a 1-2 P2SH testnet wallet with 1 key from cobo (m/45') and 1 from Ledger (m/45'/1'/0'): Read error invalid transaction error after scanning the 10 QR codes for the transaction. I will send more details about this including config file and transaction PSBT via email.

Hi, Justin
Thanks for the feedback and for the feedback here is some of our thoughts.

Please make sure you have added CoboVault to the test suite and make sure you can pass the same tests as Coldcard!
We will do the test suite as ColdCard
We would like to remove the Scan Cobo Wallet button, and instead use a shared button which will require some design input. Essentially instead of Import Wallet Configuration We can call it Import Wallet which will launch a modal with a selector, defaulted to Caravan. But if you choose CoboVault - then the flow continues as you have now.
We understand this change, Will you handle it or our team handles it in this PR? If our team handles it, would you please share with us some design requirements?

Similarly we'd prefer no new Show Wallet For Cobo Vault button in the upper right after loading a wallet in Caravan, we'd like to use the same idea as ^ with a shared button and a selector
OK

We need to make the BIP32 path editable in Caravan's xpub importer interface to match the other keystores. This will require revisions to the unchained-wallets class so it can handle this requirement. See unchained-capital/unchained-wallets#47 (review)
On usability -
OK, I think we will follow the ColdCard, user can generate children's paths from our provided extended public key.

within the extendedPublicKeys section, the 'method' should be ignored for Cobo purposes. The CoboVault appears to reject a wallet config as invalid if any of the other keys are missing the 'method' tags. Sometimes the method is not known and therefore missing.
OK, we will do it

Once an xpub is identified (by fingerprint) make sure to honor the BIP32 path, don't assume that it is m/45' (e.g. for P2SH). There is no requirement that all of the xpubs are at the same BIP32 path, so this will require allowing multiple Derivations.
Sure, the same change as the question mentioned before

Label what the zoom slider does, first thought it was a progress bar.
We will change to different icons
Maybe a note that if it’s taking a long time to scan to pause the video and step through the QR codes one by one.
OK, we will add an note to it.

Must display transaction details in text on the signing page so the user can read them and verify as they sign, see Coldcard signing for an example.
Sure, will do

We are unable to sign for transactions from a 1-2 P2SH testnet wallet with 1 key from cobo (m/45') and 1 from Ledger (m/45'/1'/0'): Read error invalid transaction error after scanning the 10 QR codes for the transaction. I will send more details about this including config file and transaction PSBT via email.
I think this issue has been resolved via emai.

We will make the changes in the following days and Thank you for all the feedback.


HSEARCH-2324 Use Double.MAX_VALUE as the default distance in spatial queries

…  (when missing the latitude and/or longitude)
https://hibernate.atlassian.net/browse/HSEARCH-2324
The issue was that distance computation worked differently with our custom spatial layer on Lucene than with Elasticsearch. It was solved by aligning our spatial layer on Elasticsearch's behavior, which seems more sensible. That required to detect missing longitudes/latitudes, which were previously silently replaced by 0.
I also replaced some sentences in the docs: I had to re-read that several time before I understood it was about the behavior when doing distance projection or distance sort on non-spatial fields. Which essentially won't work. Which isn't surprising, so is it really worth mentioning... ?

Here! All your concerns should have been addressed:

I only do as little double boxing as possible (see the last commit)
I added a commit (the last one) that changes the projection result for missing coordinates from Double.MAX_VALUE to null.

The sort behavior is unchanged: entities without coordinates are considered furthest by default. It seems to me that it should stay that way for now: it's more or less consistent with the previous behavior (which used the distance to (0,0), which for most coordinates is a large distance).
By the way, the fact that we now return null for projections is likely to trigger NPEs in some applications... Maybe we should postpone that last commit to Hibernate Search 6.0?

merged


Docs/EquivalentMutations: Conditionals Boundary example.

(drive by comment out of interest of the subject) :)
Consideration 1
May be worthwhile to consider how the type information can be used to reduce equivalent mutations for the ROR mutation operator.
In dextool the implementation of type aware schemas for bool/float/enum/pointer reduce equivalent mutants by 10-40%. Note though it is highly dependent on the design of the SUT. Flight critical code loves enums. Googletest? Not so much.
Our conclusion where that ROR is not recommended for large projects if it is not type aware because there are too many junk/equivalent mutants which makes it hard/too expensive if the process requires all survived mutants to be manually inspected.
dextool ROR
Consideration 2
Is ROR implemented? If so, is RORG implemented? If not I would strongly recommend it. It reduced the amount of mutants by a considerable amount.
I think I have the numbers laying around somewhere just not in my not-so-elephant-memory.


Update prometheus-rules.yaml

Ignore KubeletTooManyPods on fargate nodes as it's its normal behavior.

This comes from the mixin repo https://github.com/kubernetes-monitoring/kubernetes-mixin/blob/12773f7181057163a3761913bb629d7ce9e13bca/alerts/kubelet.libsonnet#L39-L46 Please open PR there.


original 1.1 docs

Contents all files in original v1.1 docs, except for the man folder and warning.png image

CLA: I signed it!

CLA update mail: I signed it!

@linfan Thanks for initializing the work.
@dchen1107 - Hi Dawn, as I mentioned before, we're translating v1.1 docs into Chinese. Till now, we've finished most part of it. But just few of the translated docs are proofread. So we're going to submit the docs into this repo and hoping the github PR review process can help proofing the docs.
The work will be done in these steps:

Upload all original docs. This is what this PR do.
Upload docs already reviewed in next PR.
Upload docs haven't reviewed one by one in sepereated PRs. And later getting reviewed and merged.
Doing step 3 repeatedly until all original docs are replaced by translated docs.

Does that sounds reasonable to you?
For step3, can @caesarxuchao @Random-Liu @freehan @xiang90 @hongchaodeng and other Chinese speaking developers help with it, if you have time?

@david-mcmahon does this belong here?

I'm going to close. I believe the proper location is over in kubenretes.github.io

@eparis, I assume not.  cc @johndmulhausen


ec2 stop action, if no instances remaining end stop attempt

Coverage decreased (-0.08%) to 82.001% when pulling 189b68fcad944e0456afba6beb018a5ce5cd586a on kapilt:bug-fix-s3-missing-policy-statement into 4463b0209f33054b2bad7428029557ffcd2ea797 on capitalone:master.


increased copy right year to 2018

removed the special "first year", now just, first - last year

Coverage remained the same at 92.355% when pulling 1c0101755e1e580748dd7a97c4b7af37d49bb2b7 on acki-m:feature-increased-copy-right-year into 7232d523ae5a3c42ba830132c47a5d75c654f338 on rttrorg:master.


Aborting installation.   npm install --save --save-exact --loglevel error react react-dom react-scripts has failed.

npx create-react-app basics
Creating a new React app in C:\Users\Ritik Sinha\Desktop\reactjs\basics.
Installing packages. This might take a couple of minutes.
Installing react, react-dom, and react-scripts...
npm ERR! Invalid or unexpected token
npm ERR!      C:\Users\Ritik Sinha\AppData\Roaming\npm-cache_logs\2019-04-09T05_31_07_862Z-debug.log
Aborting installation.
npm install --save --save-exact --loglevel error react react-dom react-scripts has failed.
Deleting generated file... package.json
Deleting basics/ from C:\Users\Ritik Sinha\Desktop\reactjs
Done.

@RitikSinha what is the exact issue you're facing?

@RitikSinha
Try:
npm cache clean --force
and then:
create-react-app basics

I noticed that you have a space in your username, so you may need to update your version of npx, which suffers from #6512.

Problem is solved. 😀😀.
I just uninstalled node js and delete all its files in local and cache and all the node modules and npm and npm cache folder
In this directory
C:\Users\Ritik Sinha\AppData\Roaming
(AppData folder was hidden in my case)
And then reinstall node js.. And it worked 😅..

That was last option for me. Actually I have tried everything but none worked for me. Thanks guys for your concern. 😊


SelectAll - how we can do?

Could anyone help me understand how to select all the text without being able to access the TextEditController?
Regards.

@carmas123 you can pass your own controller into the text field. There is a prop for that. Then you’ll be able to do whatever you want

@vasilich6107 ReactiveTextField don't have TextEditController

@carmas123 ouch(
Will think about possible solutions

@joanpablo is it bug or feature?

I think that exposing TextEditingController is a bad idea. I think that the best solution is to make a custom controller to handle some functionality, like selection or other.

Hi @carmas123
I release standalone package for text field with exposed controller
https://pub.dev/packages/reactive_text_field
Check how to access the controller in example
https://github.com/artflutter/reactive_forms_widgets/blob/master/packages/reactive_text_field/example/lib/main.dart#L47
Does it looks suitable for your needs?

Thank you so much now I try and let you know

However I think that the best way to realize it (selectAll) is performing a simplified method like this:
form.control('input').selectAll()

@carmas123 not all inputs support selecting all
Basically only textfield siblings could have this functionality
So it will bring us into the case when we implement control specific actions in the form engine which is not a good practice

Hi @vasilich6107,
I like the way you have implemented the ReactiveTextField.onControllerInit. Could you please include it in the implementation of the ReactveTextField from Reactive Forms? And instead of having two ReactiveTextFields  (that may be confusing) Have just one, the original? I will merge it if you create a PR.
Thanks in advance.

After this change, I will also upgrade the version of Flutter for Reactive Forms and I will include all new properties that are new in this latest Flutter version.

Ok, will include the implementation

@joanpablo I did several PRs with controller exposure and props updates

Hi @carmas123,
We have just released version 11.0.0, which exposes the TextEditingController for selection purposes.


[hotfix] fix camelCase method names from getfieldName to getFieldName

What changes were proposed in this pull request?
fix camelCase method names from getfieldName to getFieldName
Why are the changes needed?
getfieldName is not standardized in naming
Does this PR introduce any user-facing change?
none
How was this patch tested?
TestTableOpsUtils

Hi @zhuangchong thanks a lot for your contribution. We just fixed the CI issue, can you please rebase your PR against latest main branch?

Thanks.
lgtm


Add more file extensions

This PR adds a few more file extensions to match all languages bundled with Atom.
Before

After

Closes #9518

:+1:

:metal:
Is this ready to :ship:?

LGTM!

Is this ready to :ship:?

Yes, unless we wanna add more file types. But I think limit it to only languages that are initially bundled with Atom is a good place to draw the line.

I just noticed a missing extension. language-ruby or language-ruby-on-rails (im not sure.. maybe both) ships with .html.erb highlighting support. That kind of files are also not supported.

When trying locally, it seems that .erb also catches .html.erb.

Sorry @simurai. I missed it on the list :( Good job :)


Ruby Version Warnings

When I run vim with system Ruby I get a these warnings.

What could be causing these and how to fix them?

I use rvm to manage Ruby versions. The errors disappear if I set the system Ruby as main.
$ rvm use system --default

I would prefer to set one of the rvm rubies as my default.

Plugin vim-iterm-rspec is the problem. It uses ruby vim feature – the one vim was compiled with (system), while a list of installed gems comes from rvm env. I have got rid of these warnings by commenting out the plugin in ~/.vim/vundles/vundle.

Thanks @faucct, I was able to comment it out in my ~/.vim/vundles/ruby.vundle
Bundle "ecomba/vim-ruby-refactoring"
Bundle "tpope/vim-rails.git"
Bundle "tpope/vim-rake.git"
Bundle "tpope/vim-rvm.git"
Bundle "vim-ruby/vim-ruby.git"
Bundle "keith/rspec.vim"
" Bundle "skwp/vim-iterm-rspec"
Bundle "skwp/vim-spec-finder"
Bundle "ck3g/vim-change-hash-syntax"
Bundle "tpope/vim-bundler"


pin xlrd version to 1.2.0

this should fix the most recent failures... it looks like something behaves different with version 2.0

Version 2.0.0 removed support for anything else than .xls, so .xlsx is no longer supported: https://github.com/python-excel/xlrd/commit/c6d642b4a2688df5855b06ebb0403f1806805fbb

Thank you @maekke


Amstrad 3" Drive Requires GW Reset After Each Disk

I'm finding I have to run a GW reset after every disk to get the drive to seek back the track 0 after transferring a disk.  If I don't it starts from where it last finished and then hits the stops.  I sold find that after running GW reset it seems to over seek when returning to track 0 like it keep trying to move but can't for a split second.  I have wired my drive for DS1 (Drive B)

Are you using a tested cable/adapter to connect to the 26-pin Amstrad drive? It sounds like there is some kind of problem with the /TRK0 signal. When seeking to track 0 the Greaseweazle will seek outward until that signal is asserted. If the signal looks already asserted, then no seeking will occur and your next read will continue further inwards! Quite why it would then decide to seek properly on/after reset I'm not sure. But if it's then over-seeking... I would guess that the TRK0 signal is not well connected. Perhaps it floats?

I did a quick continuity check and it appears to have continuity on the cable but you are probably right as it doesn't seem that happy .  I have another drive in a PCW I can pull later and try it.

That would be good. No 3.5" drives?

I just pulled the A drive out my PCW.  This one behaves differently, it fails with "Command Failed: Seek: Track 0 not found".  The drive definately seems to try to move back to track 0.  I am using the same cable and it has continuity between the pin 18 on the greaseweazle F7 v2 and the drive pin.  I have swapped back to the other drive and this is working albeit with the original issue.

Maybe try increasing the seek time? Like gw delays --step=10000

Also, trk0 signal is pin 26 at greaseweazle end. And dome three inch drives may need 12v power and/or more current. Perhaps you could externally power the drive?

Sorry yes TRK0 is pin18 on the Amstrad drive.  I think the power supply is the issue, I've got the drive powered up inside the PCW and the data cable connected to the GW and this is now reading discs but difficult to tell if the trk seeking issue has gone as the drive is back in the metal shroud but seems promising.  Possibly the voltage is too low on the 5v.

Not surprising really. Only 3.5 drives generally seem reliable on usb power and even that's not universal

You accounted for 5v and 12v pins being swapped on amstrad power connector?

It was definately the power supply on the 5v.  I made a little adapter to power it from a single 12v PSU (1.5a) with a step down module to 5v, reversed as you say, I reflowed the connections on this little board and tweaked the voltage up a touch, it now seems to work flawlessly.  Thanks for the advice.

I should mention power requirements in the wiki. I'll do that then close the ticket.

Done.

Done.


Fix a crash when transforming functions in modules.

When transforming a module declaration and block, a containing function
declarations parent pointer ends up pointing and the synthetic module
block and module declaration nodes.
If a function is contained in such a module declaration, and any of its
preceding statements are transformed, the getOrCreateEmitNode
triggered by visitParameter fails because getSourceFileOfNode fails
to find a SourceFile for the synthetic module declaration nodes.
This change avoids the crash by finding original nodes in
getSourceFileOfNode.

I am unsure what the intended invariant of the AST structure is here.

Is getSourceFileOfNode wrong to assume its input will never point into a synthesized node tree, and its parent pointer chain will always end up at a SourceFile? This is what this PR fixes.
Alternatively, is it a bug that a non-synthetic FunctionDeclaration has a parent pointer to a synthetic node? It looks as if getOrCreateEmitNode assumes this cannot happen in its call to getSourceFileOfNode
Lastly, is it a bug that the top level ModuleDeclaration ends up with an undefined parent pointer, and it should lead to some source file?

I presume @rbuckton might know?

Is getSourceFileOfNode wrong to assume its input will never point into a synthesized node tree, and its parent pointer chain will always end up at a SourceFile? This is what this PR fixes.

Transformed nodes (i.e. nodes with the NodeFlags.Synthesized flag set) are not expected to have parent pointers, and the parent of a parse-tree node (i.e. a node without NodeFlags.Synthesized set) should never be modified.
Generally this means that getSourceFileOfNode does not work on transformed nodes. Perhaps we should instead add a Debug.assert to the top of getSourceFileOfNode to more formally prevent this case.

Alternatively, is it a bug that a non-synthetic FunctionDeclaration has a parent pointer to a synthetic node? It looks as if getOrCreateEmitNode assumes this cannot happen in its call to getSourceFileOfNode

Yes, this is a bug. There are only a few places where we explicitly set the parent pointer in order to synthesize an AST for the checker (namely for --emitDecoratorMetadata), otherwise modifying the parent should be avoided.
In the case of getOrCreateEmitNode, the only reason it walks up the spine for any node is so that we can clean up emitNodes on parse tree nodes that might end up being reused during incremental parsing scenarios. We don't bother doing that for synthesized nodes, since they only live until emit completes.

Lastly, is it a bug that the top level ModuleDeclaration ends up with an undefined parent pointer, and it should lead to some source file?

It is not a bug to have an undefined parent if the ModuleDeclaration was created during transformation (i.e. has the NodeFlags.Synthesized bit set).

I do not believe this is the correct fix for this issue. I would be more interested in finding the specific case where the parent pointer for a parse-tree node is being modified. Since this is a before transform, there may still be some incorrect assumptions in the ts.ts transform where it assumes it is the first transformation to run.

@rbuckton thanks for the thorough explanation! That's really helpful.
I've traced this a bit longer, and (by using Object.defineProperty with a debugger call) discovered this stack:
    at setParentPointers (src/compiler/binder.ts:4253:21)
    at src/compiler/binder.ts:4254:43
    at visitNodes (src/compiler/parser.ts:41:32)
    at Object.forEachChild (src/compiler/parser.ts:273:24)
    at setParentPointers (src/compiler/binder.ts:4254:9)
    at Object.getModuleInstanceState (src/compiler/binder.ts:19:13)
    at Object.isInstantiatedModule (src/compiler/checker.ts:254:29)
    at shouldEmitModuleDeclaration (src/compiler/transformers/ts.ts:2456:20)
    at visitModuleDeclaration (src/compiler/transformers/ts.ts:2574:18)
    at visitTypeScript (src/compiler/transformers/ts.ts:538:28)

This looks as if getModuleInstanceState is violating the invariants here, but it's unclear to me how to fix.

I filed https://github.com/microsoft/TypeScript/issues/34644 to track this.

The issue is that getModuleInstanceState depends on parent pointers being set, so it walks the tree and sets them. When the module declaration is synthesized but contains original nodes nested in it, this is a problem, since the original nodes will have their parent pointers rebound.
I’ve just fixed this locally by cloning the tree in getModuleInstanceState if it’s synthesized, replacing any non-synthesized descendants with synthesized clones. It feels a little clunky to me though, so I’m curious if @rbuckton has a more clever idea.

@mprobst I talked to @rbuckton and he suggested that the caller of getModuleInstanceState just call it with the original parse tree node instead of the transformed/synthesized node. This means that custom transformers can’t actually affect whether or not a module declaration gets emitted to JS, but that seems fine for now.
ts.ts:
function shouldEmitModuleDeclaration(nodeIn: ModuleDeclaration) {
    const node = getParseTreeNode(nodeIn, isModuleDeclaration);
    // if we can't find a parse tree node, assume the node is instantiated.
    return node ? isInstantiatedModule(node, !!compilerOptions.preserveConstEnums || !!compilerOptions.isolatedModules) : true;
}

We need to get this in in the next couple days for 3.7, so let me know if you want to update it here. Otherwise, or if I don’t hear from you by Wednesday-ish, I’ll open a new PR. Thanks for the investigation!

@andrewbranch thanks for the help. Done, and rebased onto current master.

@typescript-bot cherry-pick this to release-3.7


Workflow should be able to ignore CancellationFailure and finish successfully

Expected Behavior
Workflow code should be able to catch CancellationFailure, handle or ignore it and be able to finish executing successfully.
Test https://github.com/Spikhalskiy/java-sdk/commit/eada50399b6d24c77d4b6e37cd500907594a189a#diff-a2baafb2fd6213bafb49077bd60c8efeedc6c15df86437e9c8e2ef87ce23625cR58
expected to pass
Actual Behavior
Test fails. Workflow doesn't get a chance to fully swallow and ignore CancellationFailure and is forced to finish with EVENT_TYPE_WORKFLOW_EXECUTION_CANCELED

We did the exact thing in TypeScript a while ago.
We only complete with cancelled if cancellation of the Workflow was requested and the workflow propagates an exception that is considered cancellation.
https://github.com/temporalio/sdk-typescript/blob/733b01ee9913c255cea8913222c1232bf1bda3a4/packages/workflow/src/errors.ts#L38

After discussion with @mfateev we decided that it's too much of the breaking change to the current concept of scopes. It's not a bug, it's designed this way right now. Once the scope is requested to be canceled, it's considered canceled new commands have to be scheduled in the detached scope. We may reconsider this decision and design in the future, but when we design JavaSDK 2.x which will not strive to maintain compatibility and will revisit all the existing concepts and APIs.


Missing code needed to enable IFolderPicker DI

To get the Toolkit working, one additional line needs to be added to the builder. Along with the reference to IFolderPicker, a reference to MainPage needs to be added:
            builder.Services.AddSingleton<IFolderPicker>(FolderPicker.Default);
            builder.Services.AddTransient<MainPage>();

Without that MainPage reference, the program aborts with:
{Microsoft.UI.Xaml.UnhandledExceptionEventArgs}
    Exception: {"Cannot dynamically create an instance of type 'xxxx.MainPage'. Reason: No parameterless constructor defined."}

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 85d8bed7-9442-56fa-3227-b0295e9ae651
Version Independent ID: 85d8bed7-9442-56fa-3227-b0295e9ae651
Content: FolderPicker - .NET MAUI Community Toolkit - Community Toolkits for .NET
Content Source: docs/maui/essentials/folder-picker.md
Product: dotnet-communitytoolkit
GitHub Login: @VladislavAntonyuk
Microsoft Alias: joverslu

Seems like this was resolved but the issue wasn't closed. Let me do that now. Thanks for raising this with us!


Write a Swift program to convert inches to miles

Description
Write a Swift program to convert inches to miles
1 mile = 63360 inches
Input  : 316800
Output : 5

How to contribute

Save the solution in ConvertInchesToMiles.swift file
Add ConvertInchesToMiles.swift file in convert-inches-to-miles folder

!assign


Pluck some low hanging concurrency fruit

Make the shutdown flag on servers be per thread to save contention on
the lock that must guard it.

LGTM, can merge when testing allows.

So all Jenkins flakes are unrelated (Python, Ruby)


🍒 Cherry pick PR #6458 to staging 🍒

🍒 Cherry pick https://github.com/Expensify/App/pull/6458 to staging 🍒

🚀 Cherry-picked to staging by @chiragsalian in version: 1.1.16-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Use traditional import to fix #55

For #55 , simply use from .. import .. as .. instead of importlib.
The import will only affect the current function scope, which should be acceptable.

Replaced by #67l


Fix/southwoks/userid

Pull Request Test Coverage Report for Build 194

123 of 133 (92.48%)  changed or added relevant lines in 15 files are covered.
41 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.1%) to 57.346%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/app/client/src/ui/dialogs/openBotDialog/openBotDialog.tsx
3
4
75.0%

packages/app/main/src/services/luisApiService.ts
0
1
0.0%

packages/app/main/src/settingsData/reducers/savedBotUrlsReducer.ts
10
11
90.91%

packages/emulator/core/src/facility/botEndpoint.ts
3
4
75.0%

packages/sdk/ui-react/src/widget/autoComplete/autoComplete.tsx
85
86
98.84%

packages/sdk/ui-react/src/widget/index.ts
0
1
0.0%

packages/app/client/src/data/sagas/servicesExplorerSagas.ts
7
11
63.64%

Files with Coverage Reduction
New Missed Lines
%

packages/app/client/src/ui/editor/appSettingsEditor/appSettingsEditor.tsx
1
74.42%

packages/app/client/src/ui/editor/emulator/emulator.tsx
8
81.88%

packages/app/client/src/data/sagas/servicesExplorerSagas.ts
32
48.17%

Totals

Change from base Build 192:
0.1%

Covered Lines:
5425

Relevant Lines:
8901

💛  - Coveralls


Firefox is removing support for registerContentHandler

See https://www.fxsitecompat.com/en-CA/docs/2018/navigator-registercontenthandler-has-been-removed/
I noticed that this repository contains some code that tries to register the site on which it runs as a content handler for some feed types. This will stop working once Firefox 62 is released (scheduled for the beginning of September, https://wiki.mozilla.org/Release_Management/Calendar ).
Firefox is also thinking about removing built-in feed support, so like Chrome I expect you would soon want/need an add-on if you wanted to handle RSS/Atom feeds opened in "normal" browser tabs by redirecting them to newsblur.

This has already happened - I've reinstalled my system and I can't add Newsblur to the RSS subscription options from goodies.

For anybody seeing this thread, here are some options for managing RSS in Firefox:
https://support.mozilla.org/en-US/questions/1244312


Is there a way to specify which pages of the PDF to generate?

Nope, sorry, you have to split the pdf after creating it.


error installing nem2-cli

Hi,
NPM is throwing an error when installing nem2-cli
I managed to make it work, I think it would be nice to have a look at it and amend the tutorial to make the experience smoother.
CONFIG
-Ubuntu 16.04
-Node v 10.10
-NPM 6.4.1
COMMAND
$> (sudo) npm i -g nem2-cli
ERROR
/usr/bin/nem2-cli -> /usr/lib/node_modules/nem2-cli/bin/nem2-cli

<EMAIL_ADDRESS>install /usr/lib/node_modules/nem2-cli/node_modules/bufferutil
prebuild-install || node-gyp rebuild

prebuild-install WARN install EACCES: permission denied, mkdir '/usr/lib/node_modules/nem2-cli/node_modules/bufferutil/build'
gyp ERR! configure error
gyp ERR! stack Error: EACCES: permission denied, mkdir '/usr/lib/node_modules/nem2-cli/node_modules/bufferutil/build'
gyp ERR! System Linux 4.13.0-36-generic
gyp ERR! command "/usr/bin/node" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /usr/lib/node_modules/nem2-cli/node_modules/bufferutil
gyp ERR! node -v v10.10.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: prebuild-install || node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/jls/.npm/_logs/2018-09-09T02_24_58_264Z-debug.log
SOLUTION FOUND
sudo npm install -g nem2-cli --unsafe-perm=true --allow-root

Hi @decentraliser,
Thanks for your feedback! It seems your ubuntu user has some permission issues to install npm packages. As it could help other people, we could add a reference to how to solve this particular issue in the docs.
Community contributions are highly appreciated. If there is anything it could be added or improved, I encourage you to suggest improvements directly in the page, by clicking "Edit on Github" button at the top-right part of the website.


[go_router] GoRouterState doesn't carry data when the app is opened using deep link in Android

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Set up a deep link by following the instructions provided in this Flutter documentation.
Launch the application on an Android emulator (or physical device).
Terminate the application (by pressing the stop button)
Execute the following command:

 adb shell 'am start -a android.intent.action.VIEW \
    -c android.intent.category.BROWSABLE \
    -d "http://example.com/details"' \
    com.example.foo

Expected results
The console should print
matchedLocation = /details

Actual results
The console prints
matchedLocation = /

Code sample
Minimum reproducible code:
void main() {
  final router = GoRouter(
    routes: [
      GoRoute(
        path: '/',
        builder: (_, __) => Scaffold(
          appBar: AppBar(title: const Text('Home Screen')),
        ),
        routes: [
          GoRoute(
            path: 'details',
            builder: (_, __) => Scaffold(
              appBar: AppBar(title: const Text('Details Screen')),
            ),
          ),
        ],
      ),
    ],
    redirect: (context, state) {
      print('matchedLocation = ${state.matchedLocation}');
      return null;
    },
  );

  runApp(MaterialApp.router(routerConfig: router));
}

Screenshots or Video
No response
Logs
Version:
go_router: ^10.1.0

More info:
iOS Devices: The app functions correctly in all scenarios, regardless of whether it is terminated or running (either in the background or foreground).
Android Devices: The app operates seamlessly when it's active (in either the background or foreground). However, issues arise when the app is in a terminated state.
I discovered that related issues have been addressed, but I'm unclear on the resolution.
Flutter Doctor output
Doctor output
[✓] Flutter (Channel master, 3.8.0-13.0.pre.79, on macOS 13.3.1 22E261 darwin-arm64, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.3)
[✓] IntelliJ IDEA Community Edition (version 2022.3)
[✓] VS Code (version 1.80.1)
[✓] Connected device (3 available)
[✓] Network resources

• No issues found!

Hi @iLoveDocs. Thanks for filing this. From the closed issue you referenced, it seems to have been fixed with https://github.com/flutter/engine/commit/be57de6decff4ddaf6abbb318b1093620b417ee1. Can you upgrade to the latest master to confirm this?

@dam-ease, indeed, that solution worked. I apologize for my lack of familiarity with GitHub, which made it difficult for me to identify the branch where this issue was resolved. I mistakenly assumed that it was related to the go_router package.


Invisible to Plex

Hello,
I was hoping to use google drive to store some movies and then stream them through plex since I get unlimited storage while I am a student. I have my own dedicated private server set up running Ubuntu Server 14.04 (headless). I have installed google-drive-ocamlfuse, and it does work as far as letting me access files through an SSH connection. I have also installed Plex on this server, and have been able to stream movies from a local directory just fine. However, when I try to add a library in Plex and guide it to my ocaml-fuse mount point, the folder is not there. As soon as I unmount, Plex can see the folder again and access it just fine. I don't think it is a permissions issue, but it could be. I have added the Plex user to both my user's group and that of fuse as well. I have also tried mounting with different filesystems (i.e. ext3, which then shows up as fuse.ext3) and that did not help. I simply cannot seem to figure this out. Any help is greatly appreciated.

use the -oallow_other argument when starting google-drive-ocamlfuse! :)

Thank you! Add a space in between the -o and the allow_other and it works beautifully! :) Thanks again, I've been banging my head against the wall for weeks with this one.

Sorry for reopening this, but does this still work? I keep reading that PLEX will cause google to ban you for 24 hrs.


ReadOnlyRootFileSystem support needs to be added in Dapr controlplane components

Hello @mukundansundar  , As discussed in today's meeting [FYNDNA]
The ReadOnlyRootFileSystem  support is not available for dapr controlplane components (except sidecar) in Dapr 1.10.6
However the same vulnerability has been also reported in following dapr components
dapr-dashboard
dapr-sentry
dapr-sidecar-injector
dapr-operator
dapr-placement-server
I am raising this issue as per our discussion (targeting for 1.12 release)
Please let me know if you need any more details on this

Hi!
Can this be enabled please?


ENH: Implement one line code to draw vertical lines for multiple figure lines.

Same as #27, so close this issue.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_189c2e71-0427-41ac-b577-e80cec7b7bab/pull/1 is merged into live branch.
Auto archive content to https://github.com/OPS-E2E-PPE/docs-archive-test-target_189c2e71-0427-41ac-b577-e80cec7b7bab.git

Docs Build status updates of commit ec9e103:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Archive_master_2019-09-25-05-30-09 has been deleted or has been force pushed: fatal: Couldn't find remote ref Archive_master_2019-09-25-05-30-09

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Mast: Watch (?-i:^Tariq Faqira$)

Mast requests the watch of the watch_keyword (?-i:^Tariq Faqira$). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

(?-i:^Tariq Faqira$) has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Rejected by Daniil in Charcoal HQ. Reason: 'There is no reason to watch the username, all posts have been caught for other reasons and spammer is not hopping sites.'


Upgrade to latest open release

This needs to be tested against 11.0 SP9 and upgraded if necessary.

Retarget to current open release: 11.0 SP12.

Updated and tested to current open release: 11.0 SP12 and created pull request for the same

Verified on 11.0 SP12, SP15


add Del(JobId string) method to Disque

Aim of this method is to be able to delete a Job in Disque thanks to his ID.

Great suggestion!  I've merged the commit into a feature branch and will pull it into master shortly.  I renamed the Del function to Delete for clarity and added a unit test assertion that ensures the enqueued job is deleted.  Thanks again!


[ENHANCEMENT]  Inference Time Logger

We would like to add a timer for the inference process in Marqo so we can monitor the processing time for each step.

Design
The main body of inference process is in the function marqo.s2_inference.s2_inference.vectorise() . We can break down the whole process by the following diagram:

We will only logger the time for the processes marked by *. Reasons:
model loading : this is often a one-time process. It may take 10 seconds around (depending on the model size) to load the model into the cache for the first time. However, after the first loading, it shouldn’t take more than 1ms second to load.
output type conversion : this step often takes less than 1ms.
output type conversion : this step often takes less than 1ms.
Therefore, for each vectorise() function call, we will generate 4 time logger that report the preprocessing time for vectorise, data downloading, data preprocessing , and data encoding .
@tomhamer @jn2clark @vicilliar

An example output looks like this.

INFO:marqo.s2_inference.s2_inference:loaded ViT-B/32 on device cpu with normalization=True
INFO:marqo.s2_inference.clip_utils:  Data(Text) preprocess complete | Batch size: 1 | Total time 0.003s | Average time 0.003s.
INFO:marqo.s2_inference.clip_utils:  Data(Text) encode complete | Batch size: 1 | Total time 0.042s | Average time 0.042s.
INFO:marqo.s2_inference.clip_utils:Vectorise complete | Batch size: 1 | Total time 2.339s | Average time 2.339s.
INFO:marqo.s2_inference.clip_utils:  Data(Image) download complete | Batch size: 8 | Total time 0.004s | Average time 0.001s.
INFO:marqo.s2_inference.clip_utils:  Data(Image) preprocess complete | Batch size: 1 | Total time 0.009s | Average time 0.009s.
INFO:marqo.s2_inference.clip_utils:  Data(Image) encode complete | Batch size: 1 | Total time 0.037s | Average time 0.037s.
INFO:marqo.s2_inference.clip_utils:Vectorise complete | Batch size: 8 | Total time 0.050s | Average time 0.006s.

@wanliAlex Does timing the data downloading step need to be implemented in multiple places in the code? Or is there only piece of code dedicated to data downloading?

Is your plan for this for clip only? or is it necessary to add these logs to hf_utils, onnx_clip_utils, random_utils, sbert_onnx_utils, and sbert_utils as well?

@pandu-k  sorry i missed this comment somehow.
@vicilliar
To answer the question, YES. Theoretically, we need to put this timer logger in every model_utils.py since all the downloading, encoding, and conversion are separated.
However, I would say clip is the main model that deals with images, which requires downloading. Apparently, we don't need to download the text (string) input.


Bitmask Signatures

For signature longevity, it might be ideal to be able to exclude the operand bits for an instruction byte with a bitmask.

**brandon said ur a skid
**

hahahhahahahhaa


chore: Prepare release 3.2.1

Detail

Prepare release 3.2.1. This is the main reason why we need to do it: #2341
Temporarily reverting #2326 as it's a new feature, which we shouldn't include in a patch release. Will re-add it after this PR.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 6894bb332c900d262168db25ab6a2503d4ad9854
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: e9aea391b113e31bf9f696052da51a3a22a1682e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 6894bb332c900d262168db25ab6a2503d4ad9854
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: e9aea391b113e31bf9f696052da51a3a22a1682e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: d0106f0a400a7c7faf4814f360ac5d15eff1042d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: d0106f0a400a7c7faf4814f360ac5d15eff1042d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


docs: add driver migration guide

Fixes #334

Related to https://github.com/GoogleCloudPlatform/cloud-sql-proxy/pull/1500.


Update peerDeps for Electron 22

Tested with 22 and it works great

any update on merging this?

@wesbos Can you update the devDependencies, yarn.lock, examples/ folder and README too? Thanks!

@wesbos I see this was created yesterday https://github.com/maxogden/menubar/pull/412
@amaurym is there a rough timeline for this to merge in?

I'm fine to merge this as soon as https://github.com/maxogden/menubar/pull/404#issuecomment-1368998928 is addressed!
@wesbos seems like he's not replying, @danielzev would you like to create a new PR?

@amaurym @danielzev Will this work https://github.com/maxogden/menubar/pull/414?

Superesed by #414


using DelayedJob results in multiple email Amazon SES emails

I'm using delayed_job to send emails with the Hominid Amazon SES gem.  When I do not use delayed job to send my emails, a single copy of each email (correctly) is delivered.  When I delay the email with delayed job, every email gets duplicated.
I have a 'puts' statement in the caller method and it only ever gets printed once:
UserMailer.delay.new_user_activation(email_to_mail, activation_url, first_name, school_name)
puts "\n\n\n\n\nSENDING ACTIVATION INSTRUCTIONS\n\n\n\n\n"

I have a 'puts' statement in the callee method and it also only ever gets printed once:
mail(to: email, from: "\"User Activations\"<EMAIL_ADDRESS>subject: "Hi #{first_name}! Please Activate your User Account.").deliver
puts "\n\n\n\n\n\nnew_user_activation\n\n\n\n\n"

My output from the worker I'm running shows that only one dj is added, and successfully processed:
[Worker(host:bp.local pid:34672)] Class#new_user_activation completed after 2.1800
[Worker(host:bp.local pid:34672)] 1 jobs processed at 0.4474 j/s, 0 failed ...

Despite all this (which appears that I'm only sending one email), two emails are sent.  When I use the exact same code sans the 'delay' call, only one email is delivered.
I've checked with Amazon SES and everything is working fine on their end.  I've done tons of digging and found delayed job is the only variant between single and duplicate email deliveries.
Any help would be great.
-Ben

I had the same problem as he! This section in the Readme not working with SES.

You may also wish to consider using Active Job with Action Mailer which provides convenient .deliver_later syntax that forwards to Delayed Job under-the-hood.

ruby '2.7.1'

gem 'rails', '~> <IP_ADDRESS>'
gem 'delayed_job', '4.1.10'
gem 'delayed_job_active_record', '4.1.7'
gem 'aws-sdk-s3', '~> 1'
gem 'aws-sdk-rails'


Miss closing button for left-col in home page

Try to build by original theme and find out the differences.
Try to build on windows.

This is a new feature in latest indigo theme. It's fixed by updating theme version.


Watch policies configured by Gateway params

Description
Add new policiesToSync field to the GatewayClass parameters, which allows users to specify GVRs of policies to watch
Verification steps
Currently the watch only adds a log message when an event is triggered

Start the development environment
Apply the ConfigMap with the updated parameters to watch AuthPolicies:kubectl apply -f config/quick-start/control-cluster/cluster-config/configmap.yaml

Edit the GatewayClass to reference the parameterskubectl edit gatewayclass kuadrant-multi-cluster-gateway-instance-per-cluster -o yaml

spec:
  controllerName: kuadrant.io/mgc-gw-controller
  parametersRef:
    group: ""
    kind: ConfigMap
    name: gateway-params
    namespace: multi-cluster-gateways

Ensure the AuthPolicies CRD is installedkubectl apply -f https://raw.githubusercontent.com/Kuadrant/kuadrant-operator/main/config/crd/bases/kuadrant.io_authpolicies.yaml

Edit the controller ClusterRole to have the ability of watching AuthPolicieskubectl edit clusterroles mgc-manager-role

Add the following rule- apiGroups:
  - kuadrant.io
  resources:
  - authpolicies
  - ratelimitpolicies
  verbs:
  - get
  - list
  - watch

Run the controller from this branch (either build new image or run locally ensuring no other instance of the controller is running in cluster)
Create an AuthPolicykubectl apply -f https://raw.githubusercontent.com/Kuadrant/kuadrant-operator/main/config/samples/kuadrant_v1beta1_authpolicy.yaml

Verify the event is logged in the controller2023-10-10T10:00:30Z    INFO    Got watch event for policy      {"controller": "gateway", "controllerGroup": "gateway.networking.k8s.io", "controllerKind": "Gateway", "Gateway": {"name":"prod-web","namespace":"multi-cluster-gateways"}, "namespace": "multi-cluster-gateways", "name": "prod-web", "reconcileID": "a3277e6e-51c3-4cd8-bdea-d6b8b81e4606", "obj": {"apiVersion": "kuadrant.io/v1beta1", "kind": "AuthPolicy", "namespace": "default", "name": "toystore"}}
...
2023-10-10T10:00:30Z    INFO    Syncing policy  {"policy": {"apiVersion":"kuadrant.io/v1beta1","kind":"AuthPolicy", ...

👀

Tested locally works as expect saw the logs

Thanks @R-Lawton I just pushed a commit with small improvements including the suggestion you made

/lgtm


fix: rsa generation with web workers

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master     #5   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          10     10
  Lines          84     91    +7
  Branches        6      7    +1
=====================================
+ Hits           84     91    +7

Impacted Files
Coverage Δ

src/keys/rsa.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cd18c5...95276c4. Read the comment docs.


Deprecate node 16, use only latest supported node

See https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/lambda-at-edge-function-restrictions.html#lambda-at-edge-restrictions-runtime

Location: https://github.com/asaaki/rust-wasm-on-lambda-edge/blob/1df3d8b91b8c365a1e989ec28816d25d6a1aaeda/.github/workflows/ci.yaml#L12-L20
notes

also update ubuntu image
use single version for node; no need to promote almost EOL (April 2025)
node v22 is not supported on either lambda or lambda edge


Streaming body

It would be nice if this crate implemented the streaming Body trait as provided by http-body.
For context, I'm in the midst of writing a client for a specific REST API, and I would like it to be agnostic to the HTTP client implementation; E.g. any consumer of my crate should be able to use any HTTP client they want. Of all the HTTP client crates I've checked, only isahc uses the http crate as part of its public API, meaning it's the only generic client that a user could choose. :sob: The REST API needs to stream both request and response bodies.
I'm hoping efforts like this crate can help push the ecosystem in the direction of standardizing on a minimal set of types for making HTTP requests so that end users are not tied directly to a specific style (async or sync), client implementation (isahc vs reqwest vs surf vs ... ), or executor framework (tokio vs async-std vs std::thread vs ... )

@parasyte http-client already supports a streaming body as it relies on AsyncBufRead. I'm not a fan of allocating owned buffers, and have had bad enough experiences with tokio-rs/bytes that I prefer we stick to std's AsyncRead / AsyncBufRead types instead. This should provide end-users with the most control over how data is allocated.

so that end users are not tied directly to a specific style (async or sync)

I too would like for others to adopt what http-client provides, but being generic over sync / async is probably not in scope for this crate unfortunately. The differences are large enough that if we would try to support both, the end-user experience would likely be less good.
Hope this makes sense!


[feat] Do not do segwit related computations before the actual upgrade

We do not have to do the following things before SEGWIT_BLOCK = 481_824:

Compute tx_bytes_segwit
Compute wtxid
Compute wtxid root and witness commitment

Update compute_and_validate_tx_data function to reflect that.
Hint: return Default::default() for the wtxid merkle root for such cases.
Reading: https://learnmeabitcoin.com/technical/transaction/wtxid/

@m-kus Can you assigned it to me

without any changes , during the scarb test show this error  test e2e:tests/data/full_169.json .../Users/pavitra/learning/raito/./scripts/data/integration_tests.sh: line 32: python: command not found

without any changes , during the scarb test show this error test e2e:tests/data/full_169.json .../Users/pavitra/learning/raito/./scripts/data/integration_tests.sh: line 32: python: command not found

You need to install python? Then: https://github.com/keep-starknet-strange/raito?tab=readme-ov-file#build-dependencies


NIFI-4040: Continue if SFTP failed getting user home directory

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

+1, merging

Not sure why but the PR has not been closed automatically. Could you close it @ijokarumawak ? Thanks!

@pvillard31 This PR has been automatically closed, it seems it just took longer. Thanks for reviewing!


page unload should checkpoint

this is a regression.  we used to checkpoint on page unload (eg close the tab or reload).

reverted with https://github.com/twosigma/beaker-notebook/commit/b93e7a61f257b91c5c6dcf36c11041870f9bee12
but strangely fixing the typo window.unload to window.onunload does not fix.

http://stackoverflow.com/questions/4945932/window-onbeforeunload-ajax-request-problem-with-chrome

both reload and close work back at 2b5df57 on July 24


DeleteElementTree throws Foreign Key Constraint error when deleting an element that is referenced in other elements as code scope

Describe the bug
When using deleteElementTree() function from ElementTreeWalker.ts to delete an element, if an element is referenced by other elements in their code scopes, it throws Foreign key constraint error.
To Reproduce
Steps to reproduce the behavior:

Create the first element
Create the second element that references the first element in its code scope
Use deleteElementTree() on the first element
See "error deleting element" error (errorNumber: 65553)

Expected behavior
When deleting an element, processElementTree() function in ElementTreeBottomUp class should also process the elements that reference the element in their code scopes.
Possible solution to this issue:
export abstract class ElementTreeBottomUp {

+ protected shouldVisitCodeScopes(_elementId : string, _scope : ElementTreeWalkerScope) { return true; }

  /** The main tree-walking function */
  protected processElementTree(element: Id64String, scope: ElementTreeWalkerScope) {
    const subModel = this._iModel.models.tryGetModel<Model>(element);
    if (subModel !== undefined) {
      if (this.shouldExploreModel(subModel, scope))
        this._processSubModel(subModel, scope);

      if (this.shouldVisitModel(subModel, scope))
        this.visitModel(subModel, scope);
    }

+   if (this.shouldVisitCodeScopes(element, scope))
+     this._processCodeScopes(element, scope);

    if (this.shouldExploreChildren(element, scope))
      this._processChildren(element, scope);

    if (this.shouldVisitElement(element, scope))
      this.visitElement(element, scope);
  }

+ private _processCodeScopes(element: string, parentScope: ElementTreeWalkerScope) {
+   const scope = new ElementTreeWalkerScope(parentScope, element);
+   this._iModel.withPreparedStatement("select ECInstanceId from bis.Element where CodeScope.id=?", stmt => {
+       stmt.bindId(1, element);
+       while (stmt.step() === DbResult.BE_SQLITE_ROW) {
+           const elementId = stmt.getValue(0).getId();
+           this.processElementTree(elementId, scope);
+       }
+   });
+ }
}

Desktop (please complete the applicable information):

iTwin.js Version 3.6.1
Node Version 18.16.0

The "element tree" is based on parent-child relationships between elements. Your repro steps describe a different relationship, based on code scope. Your second element is therefore not part of the first element's tree and the behavior you describe is expected.
@swwilson-bsi can correct me if I misunderstand.


[DEM-1109] Added custom names for adapters

The timestamp instrument adapter, virtual DAC instrument adapter and virtual AWG instrument adapter can now have a custom instrument name.

Might be superseded by #681

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2
- Added 2

See the complete overview on Codacy


Fix codelens action for opening a dropdown on parametrized tests in windows 10

Fixes #8627. When the path of an actual test file (given by vscode.Uri.fsPath) is later compared against the fullPath of a single item of tests.TestFiles the drive letter mismatches and aborts further actions despite the rest of the path is the same.

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[x] Has a news entry file (remember to thank yourself!)
[x] Appropriate comments and documentation strings in the code
[x] ~Has sufficient logging.~
[x] ~Has telemetry for enhancements.~
[x] Unit tests & system/integration tests are added/updated
[x] ~Test plan is updated as appropriate~
[x] ~package-lock.json has been regenerated by running npm install (if dependencies have changed)~
[x] ~The wiki is updated with any design decisions/details.~

Codecov Report

Merging #8647 into master will decrease coverage by 0.72%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #8647      +/-   ##
==========================================
- Coverage   59.11%   58.38%   -0.73%
==========================================
  Files         520      520
  Lines       23938    23571     -367
  Branches     3870     3866       -4
==========================================
- Hits        14150    13762     -388
- Misses       8869     8881      +12
- Partials      919      928       +9

Impacted Files
Coverage Δ

...nt/testing/common/services/discoveredTestParser.ts
17.35% <66.66%> (+1.25%)
:arrow_up:

...nt/datascience/jupyter/invalidNotebookFileError.ts
0% <0%> (-75%)
:arrow_down:

.../client/datascience/jupyter/jupyterConnectError.ts
0% <0%> (-66.67%)
:arrow_down:

...science/jupyter/jupyterKernelPromiseFailedError.ts
0% <0%> (-50%)
:arrow_down:

...ent/datascience/jupyter/jupyterWaitForIdleError.ts
0% <0%> (-50%)
:arrow_down:

...cience/jupyter/jupyterDebuggerNotInstalledError.ts
50% <0%> (-30%)
:arrow_down:

src/client/common/utils/platform.ts
64.7% <0%> (-23.53%)
:arrow_down:

src/client/language/characters.ts
12% <0%> (-21.34%)
:arrow_down:

src/client/datascience/cellFactory.ts
51.51% <0%> (-19%)
:arrow_down:

src/client/testing/codeLenses/main.ts
60% <0%> (-17.78%)
:arrow_down:

... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 358b7d2...e0c9327. Read the comment docs.

Should i write a test for this? I have no experience in writing tests for TypeScript code...

why is the coverage decreased that much?!

This is just missing a test.

@ericsnowcurrently I added a test. I am not really happy with all that mocking, though. But it ensures that respective parts of the method TestDisplay.displayFunctionTestPickerUI,  that are responsible for showing the picker. can be reached.

Don't worry about squashing.  We always squash-and-merge for PRs. :)

@ericsnowcurrently Thanks a lot for your very detailed review! I really appreciate that! I'll go through your suggestions and advices and change the respective parts.
Regarding the coverage i was really puzzled when i saw that there were no tests at all for the TestDisplay class... Thats the reason i setup the respective suite in general but also wasn't completly sure how to structure it because i didn't now if you would adapt to it or what else should be in there. So i am happy to lay a foundation for future tests of that class.

So perhaps you mean you'd rather have functional tests

I always prefer to have some kind of real/unmocked functionality in tests i write (be it unit or functional tests...). Since i am developing most of the time in python where mocking is really easy and flexible i am always careful when i need to mock. Sometimes i have the feeling that in the end you test that you configured your mocks right, which possibly masks other errors that bubble up later. Of course i know that especially in unit tests you need to mock when the surrounding depeneds a lot on the state of other classes/objects (like in this case with TestDisplay).

@ericsnowcurrently I changed the tests according to your suggestions. In order to keep the git history clean i would prefer to squash the testing related commits into one as there are five commits that have a lot of changes in between.

i just saw that something changed with the FileSystem class because compiling fails?

Don't worry about squashing.  We only squash-and-merge when landing PRs, so that will be done automatically.

Again, thanks for all your work on this.  I really appreciate your willingness to accommodate my various suggestions. :smile:

Again, thanks for all your work on this. I really appreciate your willingness to accommodate my various suggestions. 😄

Thank you for your help and suggestions! I found that super helpful and really appreciate that! You explained everything and it made sense to me. This has definitely taken me further in terms of writing tests in general and in learning typescript!


Fetch salvage info from GuildWars process

Scan for assertion formula < ITEM_FORMULAS
Look for the table address in that function

That table has (I think) 1497x 20-byte entries.  h0010 is the number of entries in the material table, and h0014 is the pointer to the material table

Eg. formula info

We’re doing this

https://github.com/gwdevhub/GWToolboxpp/commit/b058952f176bb4bc7fae4565827a78973fa2062b


administrator -> organizer

Were there any instances of admin?
(Aside from our whole directory named admin :) The link to those docs is called "Administration", I believe, which I think is nice and descriptive.)

No, looks like just the stuff in the admin dir and in some review notes that have been taken care of.


x/mobile: Android example doesn't work in Android Studio

What version of Go are you using (go version)?
go version go1.10.1 darwin/amd64
Does this issue reproduce with the latest release?
yes.
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/renato/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/renato/go"
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/vz/dnr6kc0d4z76tk0mjxdbswxh0000gp/T/go-build312264261=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Checkout the gomobile project.
Open the example/bind/android project with Android Studio (latest version: 3.1.2) as instructed in the README.

What did you expect to see?
The project should "Gradle sync" successfully when opened in Android Studio.
Furthermore, when editing the Android MainActivity.java, under the app dir, in Android Studio, the Go package-exported Java bindings (import hello.Hello;) should be reachable.
What did you see instead?
Android Studio's sync failed with:
Unable to resolve dependency for ':app@debug/compileClasspath': Failed to transform file 'hello.aar' to match attributes {artifactType=android-exploded-aar} using transform ExtractAarTransform

The package hello is not visible from the Java code in MainActivity.java.

Strangely, the build succeeds:

Only the sync fails:

Is this something I should report to Android Studio?

meet same issue...

I found a temporary walk-around in my environment, use plugin 'com.android.tools.build:gradle:2.3.2' instead of "3.x.x" in build.gradle of top directory,  then, change the 'implementation' to 'compile' in app/build.gradle would work.

I found a temporary walk-around in my environment, use plugin 'com.android.tools.build:gradle:2.3.2' instead of "3.x.x" in build.gradle of top directory, then, change the 'implementation' to 'compile' in app/build.gradle would work.


Mock server

@AnetteTaivere to make writing the expected results easier, you can add:
for (AnalysisResult analysisResult : response) {
    System.out.println(analysisResult.toString());
 }

in front of line 124 in GoblintAnalysis to print out the final response passed to consume
A good follow-up test would be a test where explodeGroupWarnings is set to true, with the same results from file messagesResponse. This would then cover convertGroupExplode in GoblintMessagesResult (the first test covers convertGroup instead)


Pause Buyback swapping

Pause OUSD to OGN Buyback swapping functionality.

The vote has passed and comments addressed. This should be ok for deploy IMHO

@DanielVF could you maybe take over deploying this thing?

@sparrowDom Hit me up on discord and I can bring you up to speed on our contract deployment process. So that dvf and tomlinton are not the only ones who are familiar with it...