Using ContiguousCellFormat as a marker alone

This is much simpler version. Instead of adding the APIs to ContiguousCellFormat we are just using as a marker. If so we directly use the package private methods of those cells - currently Only KV and BBKV are marked as ContiguousCellFormat . So this is simple and much easier to understand.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 16s
branch-2.3 passed

+1 :green_heart:
checkstyle
1m 32s
branch-2.3 passed

+1 :green_heart:
spotbugs
2m 46s
branch-2.3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 20s
the patch passed

-0 :warning:
checkstyle
0m 26s
hbase-common: The patch generated 6 new + 118 unchanged - 0 fixed = 124 total (was 118)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 35s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 59s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 24s
The patch does not generate ASF License warnings.

42m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 159e821a5179 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 94ce48b173

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 34s
branch-2.3 passed

+1 :green_heart:
compile
1m 16s
branch-2.3 passed

+1 :green_heart:
shadedjars
4m 59s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  0s
branch-2.3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 17s
the patch passed

+1 :green_heart:
compile
1m 19s
the patch passed

+1 :green_heart:
javac
1m 19s
the patch passed

+1 :green_heart:
shadedjars
5m  2s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 21s
hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
1m 30s
hbase-common in the patch passed.

-1 :x:
unit
142m  7s
hbase-server in the patch failed.

168m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 31da3e807b0b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 94ce48b173

Default Java
AdoptOpenJDK-1.8.0_232-b09

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/3/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-common.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/3/testReport/

Max. process+thread count
4083 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 46s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m  4s
branch-2.3 passed

+1 :green_heart:
compile
1m 45s
branch-2.3 passed

+1 :green_heart:
shadedjars
7m  7s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 18s
hbase-common in branch-2.3 failed.

-0 :warning:
javadoc
0m 46s
hbase-server in branch-2.3 failed.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 42s
the patch passed

+1 :green_heart:
compile
1m 49s
the patch passed

+1 :green_heart:
javac
1m 49s
the patch passed

+1 :green_heart:
shadedjars
7m 31s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 19s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 42s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 47s
hbase-common in the patch passed.

-1 :x:
unit
153m 36s
hbase-server in the patch failed.

189m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0b874ebb9ca1 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 94ce48b173

Default Java
AdoptOpenJDK-11.0.6+10

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/3/testReport/

Max. process+thread count
3734 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 13s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 32s
branch-2.3 passed

+1 :green_heart:
checkstyle
1m 30s
branch-2.3 passed

+1 :green_heart:
spotbugs
2m 45s
branch-2.3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 17s
the patch passed

-0 :warning:
checkstyle
0m 26s
hbase-common: The patch generated 6 new + 118 unchanged - 0 fixed = 124 total (was 118)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m  8s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m  2s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 25s
The patch does not generate ASF License warnings.

42m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux feaac7433d49 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 94ce48b173

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/4/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Be careful @ramkrish86 .. you are missing the JIRA from this PR summary.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  8s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 10s
branch-2.3 passed

+1 :green_heart:
compile
1m 30s
branch-2.3 passed

+1 :green_heart:
shadedjars
5m 51s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 19s
hbase-common in branch-2.3 failed.

-0 :warning:
javadoc
0m 40s
hbase-server in branch-2.3 failed.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 58s
the patch passed

+1 :green_heart:
compile
1m 37s
the patch passed

+1 :green_heart:
javac
1m 37s
the patch passed

+1 :green_heart:
shadedjars
5m 58s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 18s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 49s
hbase-common in the patch passed.

-1 :x:
unit
124m  3s
hbase-server in the patch failed.

154m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b94154583c5f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 94ce48b173

Default Java
AdoptOpenJDK-11.0.6+10

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/4/testReport/

Max. process+thread count
4274 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

-0 :warning:
yetus
0m  8s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 30s
branch-2.3 passed

+1 :green_heart:
compile
1m 18s
branch-2.3 passed

+1 :green_heart:
shadedjars
5m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 59s
branch-2.3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 13s
the patch passed

+1 :green_heart:
compile
1m 18s
the patch passed

+1 :green_heart:
javac
1m 18s
the patch passed

+1 :green_heart:
shadedjars
4m 58s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 21s
hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
1m 29s
hbase-common in the patch passed.

+1 :green_heart:
unit
141m  2s
hbase-server in the patch passed.

167m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 569df1b004f3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 94ce48b173

Default Java
AdoptOpenJDK-1.8.0_232-b09

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/4/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-common.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/4/testReport/

Max. process+thread count
3346 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 45s
branch-2.3 passed

+1 :green_heart:
checkstyle
1m 35s
branch-2.3 passed

+1 :green_heart:
spotbugs
2m 45s
branch-2.3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 21s
the patch passed

-0 :warning:
checkstyle
0m 26s
hbase-common: The patch generated 6 new + 193 unchanged - 0 fixed = 199 total (was 193)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m 25s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m 55s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

47m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux dbab62577179 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 94ce48b173

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/5/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 43s
branch-2.3 passed

+1 :green_heart:
compile
1m 19s
branch-2.3 passed

+1 :green_heart:
shadedjars
5m 14s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 59s
branch-2.3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 21s
the patch passed

+1 :green_heart:
compile
1m 18s
the patch passed

+1 :green_heart:
javac
1m 18s
the patch passed

+1 :green_heart:
shadedjars
5m  1s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 22s
hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
1m 32s
hbase-common in the patch passed.

+1 :green_heart:
unit
144m 23s
hbase-server in the patch passed.

171m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e34481899464 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 94ce48b173

Default Java
AdoptOpenJDK-1.8.0_232-b09

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/5/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-common.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/5/testReport/

Max. process+thread count
4759 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 10s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  4s
branch-2.3 passed

+1 :green_heart:
compile
1m 27s
branch-2.3 passed

+1 :green_heart:
shadedjars
5m 49s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 18s
hbase-common in branch-2.3 failed.

-0 :warning:
javadoc
0m 39s
hbase-server in branch-2.3 failed.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 51s
the patch passed

+1 :green_heart:
compile
1m 28s
the patch passed

+1 :green_heart:
javac
1m 28s
the patch passed

+1 :green_heart:
shadedjars
5m 46s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 17s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 43s
hbase-common in the patch passed.

+1 :green_heart:
unit
147m 46s
hbase-server in the patch passed.

178m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e62c90c27972 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 94ce48b173

Default Java
AdoptOpenJDK-11.0.6+10

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/5/testReport/

Max. process+thread count
3906 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 33s
branch-2.3 passed

+1 :green_heart:
compile
1m 18s
branch-2.3 passed

+1 :green_heart:
shadedjars
5m  6s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  0s
branch-2.3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 14s
the patch passed

+1 :green_heart:
compile
1m 19s
the patch passed

+1 :green_heart:
javac
1m 19s
the patch passed

+1 :green_heart:
shadedjars
5m  3s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 21s
hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
1m 21s
hbase-common in the patch passed.

-1 :x:
unit
7m 10s
hbase-server in the patch failed.

32m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c9bdfa767d8b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / b612260bec

Default Java
AdoptOpenJDK-1.8.0_232-b09

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/6/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-common.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/6/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/6/testReport/

Max. process+thread count
787 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/6/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 32s
branch-2.3 passed

+1 :green_heart:
checkstyle
1m 41s
branch-2.3 passed

+1 :green_heart:
spotbugs
2m 42s
branch-2.3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 13s
the patch passed

-0 :warning:
checkstyle
0m 27s
hbase-common: The patch generated 4 new + 193 unchanged - 0 fixed = 197 total (was 193)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 29s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m 28s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 24s
The patch does not generate ASF License warnings.

43m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux ede5ecc22cca 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / b612260bec

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/6/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 14s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 57s
branch-2.3 passed

+1 :green_heart:
compile
1m 31s
branch-2.3 passed

+1 :green_heart:
shadedjars
6m 19s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 19s
hbase-common in branch-2.3 failed.

-0 :warning:
javadoc
0m 45s
hbase-server in branch-2.3 failed.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 12s
the patch passed

+1 :green_heart:
compile
1m 34s
the patch passed

+1 :green_heart:
javac
1m 34s
the patch passed

+1 :green_heart:
shadedjars
6m 19s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 17s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 38s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 46s
hbase-common in the patch passed.

-1 :x:
unit
17m 12s
hbase-server in the patch failed.

48m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 54b070daf02c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / b612260bec

Default Java
AdoptOpenJDK-11.0.6+10

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/6/testReport/

Max. process+thread count
955 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/6/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 54s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 14s
branch-2.3 passed

+1 :green_heart:
checkstyle
1m 49s
branch-2.3 passed

+1 :green_heart:
spotbugs
3m 10s
branch-2.3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  4s
the patch passed

-0 :warning:
checkstyle
0m 31s
hbase-common: The patch generated 4 new + 193 unchanged - 0 fixed = 197 total (was 193)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
21m 23s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m 44s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

51m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 54e7694cc171 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / f490913764

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/7/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 33s
branch-2.3 passed

+1 :green_heart:
compile
1m 17s
branch-2.3 passed

+1 :green_heart:
shadedjars
5m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  0s
branch-2.3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 11s
the patch passed

+1 :green_heart:
compile
1m 18s
the patch passed

+1 :green_heart:
javac
1m 18s
the patch passed

+1 :green_heart:
shadedjars
4m 57s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 21s
hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
1m 22s
hbase-common in the patch passed.

+1 :green_heart:
unit
134m 25s
hbase-server in the patch passed.

160m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/7/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 588791b843e3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / f490913764

Default Java
AdoptOpenJDK-1.8.0_232-b09

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/7/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-common.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/7/testReport/

Max. process+thread count
3895 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/7/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@huaxiangsun , @saintstack
I have updated as per the comments. Pls review.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 23s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 53s
branch-2.3 passed

+1 :green_heart:
compile
1m 30s
branch-2.3 passed

+1 :green_heart:
shadedjars
6m  7s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 18s
hbase-common in branch-2.3 failed.

-0 :warning:
javadoc
0m 40s
hbase-server in branch-2.3 failed.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 18s
the patch passed

+1 :green_heart:
compile
1m 35s
the patch passed

+1 :green_heart:
javac
1m 35s
the patch passed

+1 :green_heart:
shadedjars
6m 47s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 18s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 47s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 44s
hbase-common in the patch passed.

-1 :x:
unit
140m 19s
hbase-server in the patch failed.

172m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c4142fefe815 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / f490913764

Default Java
AdoptOpenJDK-11.0.6+10

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/7/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/7/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/7/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/7/testReport/

Max. process+thread count
3716 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/7/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 39s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 20s
branch-2.3 passed

+1 :green_heart:
checkstyle
1m 40s
branch-2.3 passed

+1 :green_heart:
spotbugs
2m 45s
branch-2.3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 33s
the patch passed

+1 :green_heart:
checkstyle
1m 39s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 45s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m  5s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 23s
The patch does not generate ASF License warnings.

47m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/8/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 78308c3f5fc0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / f490913764

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/8/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  8s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 12s
branch-2.3 passed

+1 :green_heart:
compile
1m 21s
branch-2.3 passed

+1 :green_heart:
shadedjars
4m 57s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 57s
branch-2.3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 12s
the patch passed

+1 :green_heart:
compile
1m 18s
the patch passed

+1 :green_heart:
javac
1m 18s
the patch passed

+1 :green_heart:
shadedjars
5m  0s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 21s
hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
1m 20s
hbase-common in the patch passed.

+1 :green_heart:
unit
133m 25s
hbase-server in the patch passed.

159m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/8/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f981c66c1208 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / f490913764

Default Java
AdoptOpenJDK-1.8.0_232-b09

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/8/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-common.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/8/testReport/

Max. process+thread count
4298 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/8/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 32s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 15s
branch-2.3 passed

+1 :green_heart:
compile
1m 35s
branch-2.3 passed

+1 :green_heart:
shadedjars
6m 12s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 19s
hbase-common in branch-2.3 failed.

-0 :warning:
javadoc
0m 41s
hbase-server in branch-2.3 failed.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 23s
the patch passed

+1 :green_heart:
compile
1m 38s
the patch passed

+1 :green_heart:
javac
1m 38s
the patch passed

+1 :green_heart:
shadedjars
6m 13s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 17s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 36s
hbase-common in the patch passed.

+1 :green_heart:
unit
140m 31s
hbase-server in the patch passed.

172m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2f57c6f0e828 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / f490913764

Default Java
AdoptOpenJDK-11.0.6+10

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/8/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/8/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/8/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/8/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/8/testReport/

Max. process+thread count
3721 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/8/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 33s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  9s
branch-2.3 passed

+1 :green_heart:
checkstyle
1m 56s
branch-2.3 passed

+1 :green_heart:
spotbugs
3m 19s
branch-2.3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  5s
the patch passed

+1 :green_heart:
checkstyle
1m 45s
the patch passed

+1 :green_heart:
whitespace
0m  1s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
20m 15s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m  3s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 24s
The patch does not generate ASF License warnings.

48m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/9/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 8372bd036ab1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / f490913764

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/9/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 20s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  7s
branch-2.3 passed

+1 :green_heart:
compile
1m 27s
branch-2.3 passed

+1 :green_heart:
shadedjars
5m 46s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 19s
hbase-common in branch-2.3 failed.

-0 :warning:
javadoc
0m 38s
hbase-server in branch-2.3 failed.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 47s
the patch passed

+1 :green_heart:
compile
1m 30s
the patch passed

+1 :green_heart:
javac
1m 30s
the patch passed

+1 :green_heart:
shadedjars
5m 45s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 17s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 41s
hbase-common in the patch passed.

+1 :green_heart:
unit
130m 59s
hbase-server in the patch passed.

161m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3bbafd226a32 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / f490913764

Default Java
AdoptOpenJDK-11.0.6+10

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/9/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/9/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/9/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/9/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/9/testReport/

Max. process+thread count
3844 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/9/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 54s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 33s
branch-2.3 passed

+1 :green_heart:
compile
1m 40s
branch-2.3 passed

+1 :green_heart:
shadedjars
6m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 14s
branch-2.3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 12s
the patch passed

+1 :green_heart:
compile
1m 24s
the patch passed

+1 :green_heart:
javac
1m 24s
the patch passed

+1 :green_heart:
shadedjars
5m  5s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 22s
hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
1m 24s
hbase-common in the patch passed.

+1 :green_heart:
unit
136m 43s
hbase-server in the patch passed.

167m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/9/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c6c677b2ef0a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / f490913764

Default Java
AdoptOpenJDK-1.8.0_232-b09

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/9/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-common.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/9/testReport/

Max. process+thread count
3443 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/9/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

All clear in this now. I will push this by EOD IST.

@saintstack  - finished all comments. Will push this unless objections.

@ramkrish86 I think there is an @anoopsjohn  ask in the above and I have a question on how the test was run but otherwise, looks good to me.

@saintstack  - The test I used to verify this was a standalone test (not JMH) where I measure the E2E time for adding millions of cells to the tree map. Some thing that you see in https://issues.apache.org/jira/browse/HBASE-24754.
Apart from that a cluster test was also performed and I can ask @pankaj72981  to share that report.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 13s
branch-2.3 passed

+1 :green_heart:
checkstyle
1m 32s
branch-2.3 passed

+1 :green_heart:
spotbugs
2m 36s
branch-2.3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 11s
the patch passed

+1 :green_heart:
checkstyle
1m 33s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
16m 42s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 55s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

41m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/10/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 113e02276611 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 2bcab163b6

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/10/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

-0 :warning:
yetus
0m  8s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 36s
branch-2.3 passed

+1 :green_heart:
compile
1m 18s
branch-2.3 passed

+1 :green_heart:
shadedjars
5m  4s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 59s
branch-2.3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 14s
the patch passed

+1 :green_heart:
compile
1m 19s
the patch passed

+1 :green_heart:
javac
1m 19s
the patch passed

+1 :green_heart:
shadedjars
5m  1s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 21s
hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
1m 21s
hbase-common in the patch passed.

+1 :green_heart:
unit
134m  5s
hbase-server in the patch passed.

160m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/10/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2e12dc3d7afa 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 2bcab163b6

Default Java
AdoptOpenJDK-1.8.0_232-b09

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/10/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-common.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/10/testReport/

Max. process+thread count
4019 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/10/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 30s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 56s
branch-2.3 passed

+1 :green_heart:
compile
1m 29s
branch-2.3 passed

+1 :green_heart:
shadedjars
5m 43s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 18s
hbase-common in branch-2.3 failed.

-0 :warning:
javadoc
0m 38s
hbase-server in branch-2.3 failed.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 55s
the patch passed

+1 :green_heart:
compile
1m 28s
the patch passed

+1 :green_heart:
javac
1m 28s
the patch passed

+1 :green_heart:
shadedjars
5m 45s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 18s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 38s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 36s
hbase-common in the patch passed.

+1 :green_heart:
unit
131m 13s
hbase-server in the patch passed.

161m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/10/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2776

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 1f2576671ddb 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 2bcab163b6

Default Java
AdoptOpenJDK-11.0.6+10

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/10/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/10/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/10/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/10/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/10/testReport/

Max. process+thread count
3747 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2776/10/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


fix: don't count falses in summary

following up on #578
will add/fix tests asap

@georgegevoian @paulfitz would you like me to add a test that specifically checks this new behavior ? or fixing the existing test was enough ?


Add doc and spec for empty-else node

Follow https://github.com/whitequark/parser/pull/652.
This PR adds doc and spec for empty-else node.
Below is a description of empty-else node.

Empty else differs from the missing (or implicit) else for pattern
matching, since
the latter one raises a NoMatchingPattern exception. Thus, we need a
way to distinguish this two cases in the resulting AST.

https://github.com/whitequark/parser/blob/v<IP_ADDRESS>/doc/AST_FORMAT.md#with-empty-else
Below are the differences between each AST (empty-else only appears in the last case).
% ruby-parse -e 'case foo; when bar; end'
(case
  (send nil :foo)
  (when
    (send nil :bar) nil) nil)

% ruby-parse -e 'case foo; when bar; else; end'
(case
  (send nil :foo)
  (when
    (send nil :bar) nil) nil)

% ruby-parse -e 'case foo; in bar; end'
(case-match
  (send nil :foo)
  (in-pattern
    (match-var :bar) nil nil) nil)

% ruby-parse -e 'case foo; in bar; else; end'
(case-match
  (send nil :foo)
  (in-pattern
    (match-var :bar) nil nil)
  (empty-else))

This PR has also added a spec for CaseNode to clarify the difference in behavior.

Thanks!
(Sorry for the delay, I missed the notification. Don't hesitate to ping me after one day or two)


fix(abi): eth_call execution revert decoding

Description
eth_call calls return "execution reverted" errors via "error" JSON-RPC field.

Solution

Current dependencies on/for this PR:

master

PR #42   👈

This stack of pull requests is managed by Graphite.


Horizontal Line in Dark Mode Does Not Appear

Describe the bug
When using Bookstack in dark mode and you use the "horizontal line" button when building your page it places a horizontal line in your page but you are unable to see it as long as you are in dark mode.
Steps To Reproduce

Turn on dark mode
Create a new page
Place horizontal line via the button right below the page name
As you can see its not viewable. Change to light mode or export a Contained Web File and it will appear

Expected behavior
For the horizontal line to be visible in dark mode
Screenshots
Dark Mode

Light Mode

Your Configuration (please complete the following information):

BookStack v0.29.3
PHP 7.3.18 (cli) (built: May 15 2020 16:10:31) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.18, Copyright (c) 1998-2018 Zend Technologies
Docker

Additional context
N/A

Thanks for report @ReaHe. A fix has been applied to be part of v0.30.


Problem memory range and ReadAsync

Hi,
I got a problem with MemoryRange when there is an offset in ReadAsync.
I use the same code that there is in M;System.IO.TextReader.ReadAsync(System.Memory{System.Char},System.Threading.CancellationToken).cs
I create an unit test that raise the problem.

Thanks!


Campaigns: UX for the save action on the add and edit views.

As a user I would like to know if my campaign has been created/edited successfully
There is currently no success message on save so the user continues to create multiple campaigns with the same name.

@clarkepaul something shouldn't be both an enhancement and a bug ;-)

Yup was oversite, was thinking it was more an enhancement on this one

I think it's legit to class as a bug since it seems broken at the mo.

This is a duplicate of #5516


Changed office-ui-fabric-react version from 2.0.0 which don't exist

…t all, to 2.34.2 which is the latest v2 release.
If you don't think 2.34.2 is the best, at least use 2.0.1 or 2.0.2 which exists.

Q
A

content fix?
yes

What's in this Pull Request?
Changed which version of Office UI Fabric to include as 2.0.0 is non-existent.

@wobba,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

thx Mikael.


create a live broadcast room

Hello,
how should I create a live broadcast room after the user login, and then start the broadcast?

Create a live broadcast, then run this project to connect to it. Not sure what you're asking.

Holaa


Merge API Into Main

Problem Statement
The need to be able to analyze audio and video for similarity to a text prompt.
Current Situation
Currently, it is not possible to compare audio and video content to a text prompt directly, leading to limitations in our ability to extract meaningful insights.
Proposed Solution
We propose to create custom scripts that leverage advanced techniques such as vectorization and semantic search. These scripts will enable us to compare audio and video content to a given text prompt effectively.
By implementing this solution, we will be able to achieve our goal of analyzing audio and video for similarity to a text prompt. This will significantly enhance our capabilities in various applications such as content analysis, search, and recommendation systems, opening up new possibilities for insights and automation.


It's unclear on the source of User Accounts during Azure SQL Database Deployment

During the Deployment of SQL Database(s), the documentation is silent on the source of User Accounts for the Server Administrator and Database Connection User...
Ex.1
 ...and...
Ex.2

...

Are these User Accounts created during deployment? (One is to assume NOT since one of the requirements, in Ex.1 is the Db Administrator must have 'Create' Access - but how/where is this access defined?)
If Accounts are assumed to exist - then where are they defined?  In the App?, in the local DB? On Azure SQL? In Azure AD?

Some relevant links to any pre-requisite Account Setup steps may be helpful for this article.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 71a44c72-d256-fbee-ea70-2eb7472f8182
Version Independent ID: 157027ff-0bad-828d-a442-a98acd219fba
Content: Publish an ASP.NET Core app to Azure with Visual Studio
Content Source: aspnetcore/tutorials/publish-to-azure-webapp-using-vs.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @wadepickett
Microsoft Alias: wpickett

Are these User Accounts created during deployment?

Yes


server exception

Maybe my problems are from MariaDB-1:10.3.9?

@yuri25  Hi mariadb is not supported due to fact it don't support JSON column. (I dunno if latest version support it)
Can you test with Mysql or Pgsql
It is because we use spatie packages which used JSON column.

Unfortunately to check under mysql or postgresql I do not have possibility. My version of the Mariab 10.3.9 It seems that the format should be supported.
https://mariadb.com/kb/en/library/dynamic-column-api/
It is very unfortunate if the problem is connected with Mariab ... Installation and further work were carried out without errors ...

can you check if you have json fields in mariadb . Sometime laravel do magic of changing json to text where database don't support it.
Is there any reason to stick with mariadb when we have pgsql or mysql? I know we should not force it but Laravel community forced us to use it due to the fact we love json support in relational database

and please give us console log output error message :)

Can't reproduce, we need Laravel/console logs, do you have correct write file permission on storage folder ?

[2018-09-02 19:59:53] production.ERROR: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '>'$."en"' = ? and idis not null limit 1' at line 1 (SQL: select * frompostswhereslug->'$."en"' = test and idis not null limit 1) {"userId":1,"email":"ptz2007@gmail.com","exception":"[object] (Illuminate\\Database\\QueryException(code: 42000): SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '>'$.\"en\"' = ? andidis not null limit 1' at line 1 (SQL: select * frompostswhereslug->'$.\"en\"' = test and idis not null limit 1) at /***path***/vendor/laravel/framework/src/Illuminate/Database/Connection.php:664, Doctrine\\DBAL\\Driver\\PDOException(code: 42000): SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '>'$.\"en\"' = ? andidis not null limit 1' at line 1 at /***path***/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php:82, PDOException(code: 42000): SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '>'$.\"en\"' = ? andid is not null limit 1' at line 1 at /***path***/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php:80)

Can you do some adaptation or patch? Mariadb is used everywhere and by default goes to most webhosts ....

You're lucky, this specific driver package is just what you need, i just tested it and it works perfectly ;)
You just have to do :

composer require ybr-nx/laravel-mariadb
change connections.mysql.driver config to 'mariadb'

It worked! Thank you very much!


feat: Allow block on tags_context and extra_context

This makes tags_context and extra_context block receivable and it defines a scope for the tags/extra.
Before:
posts.each do |post|
  Raven.tags_context(post_id: post.id)
  # do something
end
Raven.context.tags.delete(:post_id)

After:
posts.each do |post|
  Raven.tags_context(post_id: post.id) do
    # do something
  end
end

THX!

Hi, I added a comment here: https://github.com/getsentry/raven-ruby/commit/0b257441ec37ffbf8a39a7c97a496570cd9d28f7. Please take a look.

@rivayama -- Is there a specific reason that we didn't add this capability for user context?
Just wondering or if this is a good opportunity for me to make a PR :wink:


WebUI Query Autocomplete does not work with firefox

It is working fine with chrome but the autocomplete is not showing with firefox.

We don't currently have an autocomplete feature in the WebUI that I'm aware of. This sounds like the autocomplete that's included in all browsers. If you switch your browser, of course the autocomplete from the old browser will be gone.
The WebUI is also deprecated so we are not accepting PR's for it anymore. If you still need the WebUI, feel free to fork the code for that and run it as a separate project. It would be really easy to just set up an Nginx server to serve the files.


Add config target generation and installation

This enables simpler linking and header file inclusion in
application that uses this package.

I don't know why github is not reporting this on the PR but this breaks CI for Linux: https://travis-ci.org/github/cross-platform/dspatch/pull_requests

I added some bug fix and it has resolved the build.

Excellent, looks good now. Thanks for this!


Add max connection to variable

should be able to change the max connection
reopen - https://github.com/metal3-io/mariadb-image/pull/5

cc. @bfournie @derekhiggins @dtantsur @elfosardo @kashifest

/lgtm
/ok-to-test

/lgtm

/test-ubuntu-integration-main

@derekhiggins @elfosardo
why did the merge fail?

From above

Merging can be performed automatically once the requested changes are addressed.
I guess @dtantsur has to confirm that the changes he requested were done

/hold
Until issues solved, otherwise this blocks tide merging other PRs

@derekhiggins @tuminoid @elfosardo
https://github.com/metal3-io/mariadb-image/pull/12
I couldn't find the cause, so I created a new PR.


Curve3D: sample_baked_with_rotation() returns error, while otherwise behaving as expected

Godot version
4.0-beta8
System information
Windows 11
Issue description
Whenever I call the sample_baked_with_rotation() function on a Curve3D, the function seems to work as intended, however also throws out the error below:
E 0:00:02:0712   _ready: The target vector can't be zero.
  <C++ Error>    Condition "p_target.is_zero_approx()" is true. Returning: Basis()
  <C++ Source>   core/math/basis.cpp:1041 @ looking_at()
  <Stack Trace>  World.gd:21 @ _ready()

Note that in my project sample_baked_with_rotation() is being called in _ready() on World node for demonstration as per the Steps to reproduce.
I'm using what I think are sensible Curve3Ds, and I'm passing it reasonable offset values, for example in the below Steps to reproduce.
Also a problem in 4.0-beta7.
Steps to reproduce
var curve = Curve3D.new()
curve.add_point(Vector3(0,0,0))
curve.add_point(Vector3(10000,0,0))
var offset = curve.get_closest_offset(Vector3(5000,0,0))
print(curve.sample_baked_with_rotation(offset))
# returns error

Minimal reproduction project
N/A

The error is not on sample_baked_with_rotation or get_closest_offset. Is on _bake a internal function.
And it as nothing to do with big/small numbers or the number 0.
var curve = Curve3D.new()
curve.add_point(Vector3(1,2,3), Vector3.ZERO, Vector3.ZERO)
curve.add_point(Vector3(3,2,1), Vector3.ZERO, Vector3.ZERO)
curve.sample_baked(50)

The above will give you the same error.
The error occurs when because of the out param of the first point is zero, this will not give you a error:
var curve = Curve3D.new()
curve.add_point(Vector3(1,2,3), Vector3.ZERO, Vector3.LEFT)
curve.add_point(Vector3(3,2,1), Vector3.ZERO, Vector3.ZERO)
curve.sample_baked(50)

TL;RD - The error occurs when the curve is linear.

Thank you for looking into it! I tested again by setting a non zero value for the out param of all of my curves, and agree that I'm not getting an error.
Does this mean that the error is intended behaviour, and I should just be specifying a start out param for every curve? Or should the error not appear?

@CousCous4 sorry for the late reply, I didn't check email recent days. I think could have been fixed by https://github.com/godotengine/godot/pull/69726. Can you confirm it?

Tested on 4.0-beta9, it's not throwing the error anymore, and seems to be working correct.
I think the issue can be closed @Chaosus.

I appear to be still getting this error on Godot v4.0.2.stable.official [7a0977ce2]
I have the following code in a larger function -- I am calculating a path using the nav server and then adding the points from the returned nav path to a Curve3D.  Using the original commented out line of newCurve.add_point(pos) causes the get_baked_length call to throw the "The target vector can't be zero." error.  If I comment that out as I have and add a phony value to the "out" vector the error does not get thrown.
	#TODO: Adding points 1 at a time like this probably causes a malloc at every add call.  Determine if there is a way to add all the points in bulk with a single call.
	for pos in path:
		#TODO: Return to the commented out line which just adds the "pos" but does not set the "in" and "out" vectors to the curve.  This is to work around the following bug:
		# https://github.com/godotengine/godot/issues/70047
#		newCurve.add_point(pos)
		newCurve.add_point(pos, Vector3.ZERO, Vector3(0.001, 0.001, 0.001))

	# Store the total length in case we need it, but mainly just force the baking to happen now
	# so that the maximum amount of work is done in this function.  Keeping the work here means
	# if this function is spawned in a background thread, then we push as much as possible to the background.
	#TODO: This next line is sometimes throwing an error "The target vector can't be zero."  I think this is simply a bug in the "bake" function.  See the TODO on the add_point call a few lines above.
	# https://github.com/godotengine/godot/issues/70047
	totalLength = newCurve.get_baked_length()

Here is the full function call so you can see the above snippet in its full context.  startVector and endVector are the start/end points of the nav path we are calling.  The purpose of the function is to be called from inside a thread so I can move the nav calculations to their own thread.  I seem to get the error whether I call via a thread or call directly (although when calling through a thread the stack trace gets truncated.
func update(startVector : Vector3, destVector : Vector3, closeEnough : float = 5.0):
	#TODO: Move this check into a checkIfUpdateShouldHappen() function so we don't spin up a thread just to check if we
	#need to update.  Care needs to be taken to avoid the check being called twice though if called through that code path.
	var closeEnoughSquared : float = closeEnough*closeEnough
	if curve != null:
		if cachedDestVector.distance_squared_to(destVector) < closeEnoughSquared:
			return

	cachedDestVector = destVector

	var queryParams = NavigationPathQueryParameters3D.new()
	var queryResult = NavigationPathQueryResult3D.new()

	# Set the parameters for the navigation calculation that the nav server will do.
	queryParams.map = owner.get_world_3d().navigation_map
	queryParams.start_position = startVector
	queryParams.target_position = destVector
	queryParams.metadata_flags = NavigationPathQueryParameters3D.PATH_METADATA_INCLUDE_NONE
#	queryParams.path_postprocessing = NavigationPathQueryParameters3D.PATH_POSTPROCESSING_EDGECENTERED

	NavigationServer3D.query_path(queryParams, queryResult)
	var path : PackedVector3Array = queryResult.path

	var newCurve : Curve3D = Curve3D.new()
	newCurve.bake_interval = closeEnough

	#TODO: Adding points 1 at a time like this probably causes a malloc at every add call.  Determine if there is a way to add all the points in bulk with a single call.
	for pos in path:
		#TODO: Return to the commented out line which just adds the "pos" but does not set the "in" and "out" vectors to the curve.  This is to work around the following bug:
		# https://github.com/godotengine/godot/issues/70047
#		newCurve.add_point(pos)
		newCurve.add_point(pos, Vector3.ZERO, Vector3(0.001, 0.001, 0.001))

	# Store the total length in case we need it, but mainly just force the baking to happen now
	# so that the maximum amount of work is done in this function.  Keeping the work here means
	# if this function is spawned in a background thread, then we push as much as possible to the background.
	#TODO: This next line is sometimes throwing an error "The target vector can't be zero."  I think this is simply a bug in the "bake" function.  See the TODO on the add_point call a few lines above.
	# https://github.com/godotengine/godot/issues/70047
	totalLength = newCurve.get_baked_length()

	completedIndex = 0

	curve = newCurve
	if debugPath3D != null:
		#TODO: This should prbably be done with call_deferred or something like that to ensure thread safety since the main thread is potentially using the DebugPath3D.
		debugPath3D.curve = curve

I'm experiencing this with Godot 4.2.2 stable (mono) as well. @akien-mga should this ticket be re-opened?


CI: Bump pre to Python 3.13, standard to 3.12

Start testing on Python 3.13. This PR:

Bumps the default (standard) version to Python 3.12
Bumps the pre version to Python 3.13

cc @krassowski to double check this will not have any effect on the lab CI, w.r.t the ongoing work in https://github.com/jupyterlab/jupyterlab/pull/16852


This link seems not working

https://code.visualstudio.com/docs/python/tutorial-django

it works...


Boards: riotboot dfu support

Contribution description
It's a  bootloader that adds USB device firmware upgrade (DFU) support

Testing procedure

look at inf in folder boards/doc.txt
Find dfu-util info on http://dfu-util.sourceforge.net/
Tested with dfu-util v0.9

Issues/PRs references
None

please add a better description at this PR  remember you took some days how compile the bootloader, add step by step how you compile te bootloader. that way  will do  easy for us compile that too.


Add license

This looks like a wonderful viewer! Would love to experiment with it for projects at https://github.com/umd-mith/. Do you have a license in mind for the code?

@raffazizzi That's a great question. I think we'd lean MIT License though not 100% sure. It's definitely free for open use. As a heads up, we may be renaming this to something a little less generic in the near future which would include renaming the NPM package. We'll inform out about that when it happens. Thanks for your interest. We'd appreciate any feedback!

@raffazizzi Curious, how'd you come across this repo?

I was told that the Univ of Tennessee worked on a IIIF A/V viewer, couldn't find much on Google, but ended up on your GitHub profile and saw this repo there 😀

Ah, yes! This is the Tennessee IIIF/AV project https://rfta.lib.utk.edu/ that may have been mentioned, source code here: https://github.com/utkdigitalinitiatives/canopy. The viewer in the canopy pretty is pretty tied into that Gatsby repo. This viewer hopes to do some of what the RFTA project was doing but be more modular and work across manifest canvases.

Hi @raffazizzi. We have added the MIT License. Thank you again for creating the issue.


Permanent b2fuse mount instructions added

Hopefully providing useful instructions for creating a permanent mount point utilizing b2fuse.
My commit comments seem to have not made it past my dev machine... guess I did something wrong... (was pretty much the title of this pull request)

Apologies, I completely forgot about this. Thank you for your contribution. Closes #18


Saving and reloading JSON changes order

The numbers on the left side create the order when a JSON is reloaded.  These numbers should be run operation counts like they are in Jupyter, and saving and reloading JSON should not reorder a dnotebook.

sorry for the late reply, i don't think this bug exist again at the moment, i made a quick test using https://playnotebook.jsdata.org/

sorry for the late reply, i don't think this bug exist again at the moment, i made a quick test using https://playnotebook.jsdata.org/


build: improve devcontainer.json

Copy paste in some improvements to the devcontainer from evmts added by @o-az

closing for now as this is out of date, feel free to open a new PR or reopen this one with updates

I have no memory of making this pr lol

9 months in internet time is an eternity


replace payment method text with an image on the checkout page

I want to know if you can add an image instead of the name of the payment method at checkout, for example paypal

Currently there is no way to add image for payment method, you need to add logic for that.

I am closing this issue, feel free to reopen anytime


Manually setting expired tokens ruins routing

I was testing a scenario when a user does not return to his session long enough so that both his tokens are expired.
So I would login normally and then set the token in localStorage manually with localStorage.setItem("token","{token: '[expired_token]', refreshToken:'[expired_token]'}"). Straight after this nothing happens with the page and all navigation is broken - changing urls or tapping anchors does not do anything. Interestingly enough, calling router.navigateToRoute works still but only if I don't try changing the url first.
Hard reloading the page with the expired tokens still in the storage works correctly in 99% of the cases. But sometimes I observe the same issue - navigation stops working right after reload.

Probably something local... closing for now

there was a quite similar issue. must be something with the interceptor i guess

investigating at the moment... I explicitly call isAuthenticated in the activate method to force a token refresh. If the refresh token is expired itself then isAuthenticated throws and that stops activate completely

this is something to do with updateTokenCallstack. When refresh token fails for any reason the callstack gets rejected and this breaks activate flow, even though all the methods are in the try/catch

ok, my problem was in the isAuthenticatedAsync which is my wrapper around isAuthenticated. Something is not right when this function is promisified - rejections still break execution even when try/catch us used. I will submit a PR for a true async function later, which I successfully tested here...

a case for 'never log, always throw'. hmm, would callback(new Error(..)) work? or callback(()=> throw new Error())?

Returning false would do I recon, it will enable promisification :) or, a
true async function, which rethrows
On Wed., 8 Aug. 2018, 7:04 pm doktordirk<EMAIL_ADDRESS>wrote:

a case for 'never log, always throw'. hmm, would callback(new Error(..))
work? or callback(()=> throw new Error())?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/SpoonX/aurelia-authentication/issues/400#issuecomment-411338405,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADimvOqxkshsUtnIGmE2RsEv8R8cobiOks5uOqmEgaJpZM4VzSNf
.

as such that'll be better. would mean a 4.x and still maintaining the 3.x branch though. but then, i kinda would like a bigger refactoring anyways, it got untidy at places


Option to add additional attribute types to media files with .html()

Hi, I'm currently using the following code to display an image of product on a site I am working on,
{{ page.media.images|first.html(page.header.title,'product-image')|raw }}

And I would like to add the microdata attribute itemprop="image". The  problem is that the media function .html() doesn't provide a way to do this according to the documentation. Rather than having to rewrite my code to manually create the desired HTML tag, it would be convenient to able to to do something like:
some-image.html('title of image', 'alt-text', 'class', 'custom-attribute="custom-value")

I think at this point you are better off just building the HTML and using the media .url() method to get the actual URL of the image.

Fair enough. I was able to achieve the desired html by writing the following, which ended up being more concise anyways.:
<img class="class" itemprop="image" src="{{ page.media.images|first.url }}" alt="{{ page.header.title }}." />


[Feature Request] Make it possible to configure the start reading button to open the last chapter

Why/User Benefit/User Problem
In EH the chapter function is not used for chapters but for the individual revisions of the gallery. For this reason you will want to open the last/newest chapter in almost all cases for these sources. However, the floating start button opens the oldest/first unread chapter which is undesirable for this source. A configuration option to reverse this behaviour would make it possible to start reading the content in EH/EXH without scrolling to the end of the page first.
Translated with www.DeepL.com/Translator (free version)
What/Requirements
A new option in the settings (maybe EH/EXH exclusive) to reverse the behaviour of the start button to open the newest/last chapter instead.

This will be in the next release


Provide a no-op SW that will be served by the dev environment.

R: @gaearon @Timer
This adds in a "no-op" service-worker.js at the root of the dev environment's web server.
It works around the issue of someone serving their dev and prod environments from the same port and ending up with a production service worker that controls their dev environment.
If a user finds themselves in that situation, then the next time the browser checks for an updated service worker, the "no-op" version will be installed instead, and immediately force any open pages to reload, so that they're once again talking directly to the dev server.
(The caveat here is that, as with all things service worker-y, this assumes that build/service-worker.js was served using reasonable cache headers. I took a look at how the recommended serve module responds to requests for the build/service-worker.js, and it does appear to use a very short cache lifetime, so that's good!)
Fixes #2272

The caveat here is that, as with all things service worker-y, this assumes that build/service-worker.js was served using reasonable cache headers.

I tried a hard refresh which only worked for one page reload, so if this kicks in after a hard refresh that's still a welcomed change.

Maybe we should make a middleware that serves it and hide this from the User?

This would also guarantee its only applied in DEV more strongly.

I pushed a change that moves this file into a middleware so it's served automatically.


Mobile Quantity Left-Click Option

Like in Mobile, you can change the left-click option when withdrawing from the bank from 1 to 5, 10, X and All

Duplicate of #1647
https://github.com/runelite/runelite/wiki/Rejected-or-Rolled-Back-Features


MetastoreReplicationJob: Add number of reducers from config for Step1 runMetaStoreCompareJob

…b.java: Add number of reducers from config for Step1 runMetaStoreCompareJob
The old code missed one place to specify number of reducers, and also had an extra one (for a Map-Only job).

@zshao Looks good, but it looks like there is a build failure?


⚠ ClamAV has degraded performance

In 2348054, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: ClamAV performance has improved in 8a0e694.


Misformatted text

| Article | Description | |--- | --- | |
etc. looks misformatted

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3021284e-b0f8-4076-da82-0d38c70443ed
Version Independent ID: 0a9b2d6c-7f1d-e09b-f696-7b25b2629035
Content: Cortana voice commands - Cortana UWP design and development - Cortana
Content Source: docs/voice-commands/vcd.md
Product: cortana
GitHub Login: @kbridge
Microsoft Alias: jobucy

Good catch, thanks. Fixed.


Surface Compatibility

I am porting my vanilla LiveView project to use the Surface library (https://github.com/surface-ui/surface).
I would like to keep using this library to test components in isolation, but I can't get the two libraries to work properly.
The error that comes up when trying to simply pass a Surface Live Component to live_assign as I normally would is that the component does not have the pid attribute.
Could you add support for surface components? Or can I have some pointers on how this library deals with components in isolation so I could try to propose a solution myself?
Thank you.

I have never used surface. Can you provide me a simple repo with its usage and a failing test so I can investigate?
I see they have their own sigil and slot format, so it might be a bit difficult to make it work for both, but I can give a look.

Thank you for your response.
Here's a repo with a simple example: https://github.com/jpyamamoto/demo
The two important files are lib/demo_web/components/counter.ex and test/demo_web/components/counter_test.exs.
By doing this example I was able to notice that the error I mentioned previously about a missing PID was my fault, and actually it seems like the library works correctly when you don't have prop assigns, or when you pass all the props, despite them having a default value.
The surface library allows you to give props a default value, so you don't need to pass them.
This doesn't work with live_isolated_component as it will throw an error due to missing values in the assigns.

I have not forgotten about this. I've take a couple of brief looks and:

Looks like Surface rendering is completely different though it is built on top of LV. How do you call surface component from a LiveView template (with sigil_H/2)? Is there any way to render a component dynamically in surface templates (sigil_F)?
I might not be able to pull this out, but I'm willing to find a middle ground solution, just currently I don't know what it'll look like as I'm not familiar at all with Surface. Would you be willing to work with me on this?

Thank you!

Hey, I've just added a way to customise LiveViews to be used as mock views in LiveIsolatedComponent (see #42 ). Can you check if this is enough for it to work?


Enable new win-arm64 platform

This PR enables the new Windows on Arm (win-arm64) platform, by implementing the required APIs, reading topology information via Windows API.

_win-arm64_cmake-config.log
_win-arm64_cmake-build.log
_win-arm64_init-test.log
_win-arm64_cache-info.log
_win-arm64_cpu-info.log
_win-arm64_isa-info.log

Build on win-arm64
cmake . -G "Visual Studio 16 2019" -A ARM64 cmake --build .

@malfet Could you review it? Thanks!

related PR:
https://github.com/pytorch/pytorch/pull/72424

@malfet Can I do anything else to close this and the related PR?

any updates on this?

any updates on this?

Not on my side, but I'd happily close this!

Can this be merged, please?

Any plans on merging this PR ?

(@gaborkertesz-linaro is on holiday now and planning to address the comments in couple of weeks)

I hope I've fixed all of your findings, please let me know if I missed any of them!
Unfortunetaly I wasn't able to setup building with LLVM by CMake, but I've built with '-Wall' by MSVC compiler.

@malfet What do you think?


Style the button on "Roadmap to your DSA" page

Is your feature request related to a problem? Please describe.

The current button is very simple and doesn't go with the theme of the website

Describe the solution you'd like

Style the button according to the theme of the website

@Shruti3004 Please assign this issue to me. I want to work on it.

Duplicate of #185 #206


File history for renamed files, with '--follow' equivalent to show the complete history

Feature Description
Consider the scenario where a given file has 1+ change in its commit history, then the file is renamed using git mv or so, and then the file receives another change.
In the command line git, you can get the log changes before renaming the file using --follow.
When viewing the same history in the Web UI, the history of that file ends where the file was last renamed. Giving the false impression of history lost.
A simple button/check to activate the --follow option would be much appreciated. In fact, I'd say this should be enabled by default.
To see it, given a file that was renamed, check its history in the web UI and then compare it with the following:
As Gitea does:
git log FILE

As Gitea should do:
git log --follow FILE

Screenshots
No response

Hello
Looks like it was removed intentionally https://github.com/go-gitea/gitea/commit/58a4407acb04b329e94e92977b1414feb309d5de
Could it be made switchable? Somewhere in config. Not every installations have large repos, but having full history rather convenient.

I would like to add that viewing the git blame in the Web UI will show you commits from before the rename. This might induce a head scratching moment because some of the commits in the blame may not be visible in the Web UI history.