Cannot customise spec.kubelet.flags on AL2023 due to quoting of node labels

Description
Observed Behavior:
Customising the NodeClass with userdata in the format specified for AL2023 with custom Kubelet flags causes the Kubelet to crash loop. It is unable to start.
Expected Behavior:
Customising the NodeClass with userdata in the format specified for AL2023 allows you to customise Kubelet flags.
Reproduction Steps (Please include YAML):
Due to how the customised node labels are passed through userdata and nodeadm, we can't further customise Kubelet flags when using AL2023 (or presumably any other OS using nodeadm).
When defining our EC2NodeClass (only relevant config shown):
apiVersion: karpenter.k8s.aws/v1beta1
kind: EC2NodeClass
spec:
  amiFamily: AL2023
  userData: |
    apiVersion: node.eks.aws/v1alpha1
    kind: NodeConfig
    spec:
      kubelet:
        flags:
          - --registry-qps=0

What ends up in /etc/eks/kubelet/environment:
NODEADM_KUBELET_ARGS="--kubeconfig=/var/lib/kubelet/kubeconfig --image-credential-provider-bin-dir=/etc/eks/image-credential-provider --image-credential-provider-config=/etc/eks/image-credential-provider/config.json --node-ip=<IP_ADDRESS> --cloud-provider=external --hostname-override=ip-10-13-36-108.ec2.internal --config=/etc/kubernetes/kubelet/config.json --config-dir=/etc/kubernetes/kubelet/config.json.d --node-labels="karpenter.sh/capacity-type=spot,karpenter.sh/nodepool=default" --registry-qps=0"

Since double quotes are used here, the additional flags are interpreted as a continuation of the node labels, and kubelet cannot start:
Jul 06 08:18:48 ip-10-13-36-108.ec2.internal kubelet[2072]: E0706 08:18:48.510504    2072 run.go:74] "command failed" err="failed to validate kubelet flags: invalid node labels: 'default --registry-qps=0' - a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')"

The unfortunate workaround is to add the extra flag into the kubelet config directly:
  userData: |
    #!/bin/bash
    echo "$(jq '.registryPullQPS=0' /etc/kubernetes/kubelet/config.json)" > /etc/kubernetes/kubelet/config.json

The other workaround is to do something like this -
spec:
  userData: |
    apiVersion: node.eks.aws/v1alpha1
    kind: NodeConfig
    spec:
      kubelet:
        config:
          registry-qps: 0

That's a better workaround actually. Thanks!
Note that the config file parameters are slightly different to the flags though:
    apiVersion: node.eks.aws/v1alpha1
    kind: NodeConfig
    spec:
      kubelet:
        config:
          registryPullQPS: 0

Looks like this might be an issue with the way that the NodeConfig gets parsed by AL2023 AMI. @jigisha620 is planning to track this down and open an issue against that repo if one isn't already there.


Deprecating clone-simulator config and defaulting it to always ON

The clone-simulator config is deprecated and need not be passed. The clone simulator feature is always ON in Bluepill going forward.
@ob Can you please take a look?

Fixing the failing tests.

Note: This should also fix https://github.com/linkedin/bluepill/issues/384

This might break UI tests. Closing this PR for now and will open a new PR with more UI tests and fixes on top of these changes.


Legal Screen for Debug Log (EXPOSUREAPP-5029)

Added legal Screen for the Debug Log Feature

Tested on Samsung S8. Aside of Matthias comments - looks good!


Support for mixed proof with revocable/non-revocable credentials

This is an issue with existing anoncreds implementations (indy-sdk and credx) and is illustrated in an aca-py integration test:
https://github.com/hyperledger/aries-cloudagent-python/blob/main/demo/features/0454-present-proof.feature#L120
When a proof includes both revocable and non-revocable credentials, and the request includes the revocation timestamp at the REQUEST level, then the proof will fail (even though it should pass).
Note that when the revocation interval is requested at the ATTRIBUTE level, the proof will pass (see integration test https://github.com/hyperledger/aries-cloudagent-python/blob/main/demo/features/0454-present-proof.feature#L100)

Hi @ianco,
AFAIK (quite new to this!), the reason why this is failing is because when there is a Request level revocation interval, anoncreds expects that all attributes / predicates will come with a timestamp of which the revocation state in the proof is updated to (should be in the interval). This will, as you have mentioned, fail if the credential does not support revocation.
Does this mean that Request level revocation requirement is not requiring all attributes have to have this non-revoke proof, but only those that are revocable?

Does this mean that Request level revocation requirement is not requiring all attributes have to have this non-revoke proof, but only those that are revocable?

@whalelephant Yes I think that is correct. The proof request indicates that the credential should not be revoked. If the credential isn't revokable it means it can never fail as it can't be revoked (at least that's my understanding).
@ianco I would be curious to know in that case how you would request that a credential is revokable (i.e. I want to only verify revocable credentials)? Or is that something you would check after you've received the credential and can't indicate in the proof request?

Regards the use case, does this help? Suppose you are asking for a credential type (e.g., by schemaId or schemaName) from any issuer, and some issuers provide revocable and others non-revocable credentials.  You will accept any credential, but if they are revocable, you want the NRP to be included.  From AnonCreds, you want the cryptographic verification to be complete, and then (presumably) there would be other logic (outside of AnonCreds) to determine if the source credentials are acceptable (e.g., do you trust the issuer).
Equally interesting is the same case and the verifier does NOT specify a revocation interval.  If a holder has a revocable credential that it uses in the presentation, should it include an NRP?  I assume the answer is no, but am not sure what the AnonCreds holder software does.

and the verifier does NOT specify a revocation interval. If a holder has a revocable credential that it uses in the presentation, should it include an NRP?

In this case No the holder shouldn't include an NRP, and I don't believe it does.  A revoked credential will verify, so there is no need to provide a "non-revocation proof".

and some issuers provide revocable and others non-revocable credentials. You will accept any credential, but if they are revocable, you want the NRP to be included.

Currently, if you specify the revocation interval at the ATTRIBUTE level, the proof will be accepted regardless of whether the credential is revocable or not.  If you specify the revocation interval at the REQUEST level, then the presentation will fail.  So it's possible to support this use case, however the verifier needs to know how to ask for the proof.

Currently, if you specify the revocation interval at the ATTRIBUTE level, the proof will be accepted regardless of whether the credential is revocable or not.

This is not the case for this current repo, if a revocation interval is specified, it should require rev_reg_id and therefore NRP.
Does this satisfy both types of non-revoke requests as feature to implement and test?
If an interval is defined in either request or attribute level, we should be verifying NRP iff the credential supports revocation.


Change in Oracle JCE Code Signing CA in IBM JDK - java IBM i

Hello,
IBM to os400 java lvl 21 add only newes certificate (https://www.ibm.com/support/pages/node/6437873) :
New Oracle signer certificate is used to sign cryptographic provider.
Owner: CN=JCE Code Signing CA,OU=Java Software Code Signing, O=Oracle Corporation
Issuer: CN=JCE Code Signing CA,OU=Java Software Code Signing, O=Oracle Corporation
Serial number: 3C:9E:B1:89:F7:33:D3
Valid from: Jul 6 23:48:44 2016 GMT until Dec 31 00:00:00 2030
and now 	bcprov-jdk15to18-169.jar is not work - he have another cert - in jar, there are two BC 1024KE and 2048KE certificates and in 2048 we see the signature by ORACLE but the serial number is 3c9eb1fc89f733d3. IBM in java have  Serial number: 3C:9E:B1:89:F7:33:D3
Can you put a newer Oracle signature certificate in .jar?

We have the latest Oracle cert. I'm not sure what is going on with the serial number, but the JCE cert actually using the subject key identifier of the issuing key not the serial number to match it up. Exactly what error are you seeing?

Is i error log:
Caused by: java.lang.SecurityException: JCE cannot authenticate the provider BC
at javax.crypto.Cipher.getInstance(Unknown Source)
at javax.crypto.Cipher.getInstance(Unknown Source)
......
Caused by: java.util.jar.JarException: file:/WOLF/WolfPgpBatch/lib/bcprov-jdk15to18-169.jar is not signed by a trusted signer.
at javax.crypto.a.a(Unknown Source)
at javax.crypto.a.a(Unknown Source)
at javax.crypto.a.a(Unknown Source)

other:
Caused by: java.lang.SecurityException: JCE cannot authenticate the provider BC
at javax.crypto.Cipher.getInstance(Unknown Source)
at javax.crypto.Cipher.getInstance(Unknown Source)
... 14 more
Caused by: java.util.jar.JarException: file:/WOLF/WolfPgpBatch/lib/bcprov-jdk14-137.jar is not signed by a trusted signer.
at javax.crypto.a.a(Unknown Source)

sorry in bcprov-jdk15to18-169.jar i have this problem:
The library interface was incompatible with the previous one

dghgit problem is activated when IBM add to only java:
Latest news of Java on IBM
April, 2021:  New Oracle signer certificate
New Oracle signer certificate is used to sign cryptographic provider.
Owner: CN=JCE Code Signing CA,OU=Java Software Code Signing, O=Oracle Corporation
Issuer: CN=JCE Code Signing CA,OU=Java Software Code Signing, O=Oracle Corporation
Serial number: 3C:9E:B1:89:F7:33:D3
Valid from: Jul 6 23:48:44 2016 GMT until Dec 31 00:00:00 2030
GMT For details, check https://www.ibm.com/support/pages/apar/IJ26310
Once you upgraded to following levels, the old certificate is not recognized anymore. You may encounter with similar exception listed in above page.
Java 8    SR6 FP25
Java 7    SR10 FP75
Java 7.1 SR4 FP75
Third-party JCE provider users should be careful before upgrading.
Once the issue occurred, contact your provider vendor to update the provider.

OK. Sorry for problem and create issue. Now i have more information about cert and JDC Oracle and i think so mus rewrite program and add new bcprov-jdk15to18-169.jar Thanks for help.


Reference number validation message link on already registered page

The link for the reference number validation message links to the input rather than the label. When you click the validation message you should see the name of the field (Reference number) rather than just the input.
This can be fixed by moving the id linked to in the message to the label rather than the input.
Discovered on mobile.

Verified


Thank you so much for creating this library. It works wonderfully for both Android and IOS. Keep up the great work!
I looked for a comment section to thank you, so I hope this is okay. Sorry for bugging your issue backlog.

Hi!
Many many thanks! I always really appreciate compliments about this project! It makes the hundreds of hours I spent squeezing my brain on it worth it! 😊
No problem at all on creating this issue, I also do the same on projects that I really like 😅
Feel free to open issues about bugs or suggestions at any time!
Be sure you made my day brighter!

many thanks , genius @SrBrahma

cheers, mate! amazing project

this package is pure gold! thank you 👍

Many thanks! 🤗

Thanks mate 😁🙏🏻


License

MIT license is mentioned in readme but there is no license to be found anywhere.
Thanks for this, works out great!

thanks @FrankvdStam, license added!


ci: Add Docker Dependency Updates to Dependabot

Description
This change adds Docker dependency management to the existing Dependabot configuration. The new configuration checks for Docker updates monthly, targeting the main branch. Commit messages for Docker-related updates will be prefixed with "deps(docker)".
fixes #56

#62
#61
#60  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JackPlowman and the rest of your teammates on  Graphite

Merge activity

Oct 5, 3:49 PM EDT: @JackPlowman started a stack merge that includes this pull request via Graphite.


Fix config flow, group is removed from sensor on removal of group

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

17 of 17 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.008%) to 97.001%

Totals

Change from base Build<PHONE_NUMBER>:
0.008%

Covered Lines:
2652

Relevant Lines:
2734

💛  - Coveralls


improve AsyncSpan API: make #asyncFinish and #prepareForAsync can not invoke more than once

Please answer these questions before submitting pull request

Why submit this pull request?

[ ] Bug fix

[ ] New feature provided

[ ] Improve performance

Related issues

Bug fix

Bug description.

How to fix?

New feature or improvement

Describe the details and related test reports.
improve AsyncSpan API: make #asyncFinish and #prepareForAsync can not invoke more than once
make the API more strong: make the plugin code bug fail-fast

By learning your design,
it seems that asyncStop and isInAsyncMode are very different things to do,
isInAsyncMode is only viewed in the asyncFinish method,
asyncStop has view and assignment in the asyncFinish method, and there is code logic in the middle,
obviously It will still be executed multiple times.

sorry for my merge mistake

Please make sure your submitted PR has been well discussed and have the clear goal. Open too many PR will make you too hard to follow.

/run e2e


[HOLD for payment 2023-06-23] [HOLD for payment 2023-06-21] Web - Chat - Cursor on staging link is not pointer

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Open any report
Copy current URL and send in report
Hover on link to observe that cursor is not pointer

Expected Result:
App should display pointer cursor on links
Actual Result:
App displays normal cursor on staging expensify links
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/567fa792-9217-4243-80bc-1ab5e25554be
https://github.com/Expensify/App/assets/93399543/554e5083-aba1-4a2b-9d2b-4be7b915adc3
Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686648377836269
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

It's possibly related to https://github.com/Expensify/App/issues/19717 as their fix changed styles of link.

Actually this is the offending https://github.com/Expensify/App/pull/19545.

@youssef-lr all these PRs seem to be linked to https://github.com/Expensify/App/issues/19717
I think we should consider reverting

This is caused by my PR but reverting it is not the solution because we were adding the pointer cursor not to the link but to its parent which showed the pointer at places around the link -
https://github.com/Expensify/App/assets/31413407/6aef044c-2c0d-4045-b767-567c45a6e803
The root cause for this issue is that for some reasons links like https://staging.new.expensify.com/random_text_here are rendered in div rather than a which is wrong.
https://github.com/Expensify/App/assets/31413407/cc9318c9-bc07-44d5-b8ff-e34007642172
So, we need to figure out why links are rendered in div and change it to a to fix it the right way.

Ahh gothcu. Do you think you might be able to find a fix? We can always revert than implement the new solution in a follow up PR as this is a deploy blocker. If we can't find the fix quickly then we'll have to revert.

Sounds good to me @parasharrajat.

@parasharrajat another clue, why do links to https://new.expensify.com/r/801524823110380 e.g. not staging, work? They're internal as well. Do you think we're doing something differently when handling staging links?

@youssef-lr I found a solution basically for internal links since they are rendered as div we can explicitly set cursor pointer here (for other links it is default) -
https://github.com/Expensify/App/blob/6e8435ec6cba470dae50262439f2bacecea9222f/src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly.js#L68-L71
This would solve all the related issues without a regression.

Sure @parasharrajat, but since you are aware about the internal links special handling and all the related issues. can you provide your suggestions on the solution above?

@parasharrajat I can go ahead and close this?

FYI - @sakluger - all that's needed here is the reporting payment for @adeel0202 ($250)

Just sent you an offer through upwork @adeel0202!
https://www.upwork.com/jobs/~0117619b8e4dbdc25f


config passwd = yes   of no effect or I misunderstood its purpose?

built a fresh debian package (from the state of #121), installed, seems to work!  if I got it correct, default configuration has config passwd = yes and that should have created a user entry in the /etc/passwd for me, but I think it isn't happening:
$> grep passwd /etc/singularity/singularity.conf
# If /etc/passwd exists within the container, this will automatically append
config passwd = yes

$> grep -1 passwd /etc/singularity/singularity.conf
# DEFAULT: yes
# If /etc/passwd exists within the container, this will automatically append
# an entry for the calling user
config passwd = yes

$> whoami
yoh

$> singularity shell /tmp/container.img
Singularity/container.img> whoami
whoami: cannot find name for user ID 47521

container was freshly generated using sudo singularity bootstrap /tmp/container.img examples/debian.def  . I was expecting for user yoh to be known inside the container

can you show me the bottom few lines of the /etc/passwd in your container and grep yoh /etc/passwd?
Also, can you try to run singularity with debugging enabled:
singularity --debug shell /tmp/container.img
and send me the output?
Thanks!

well -- when I run it without sudo, permission is denied to access
/etc/passwd:
$> singularity shell /tmp/neurodebian.img
Singularity/neurodebian.img> cat /etc/passwd
cat: /etc/passwd: Permission denied
Singularity/neurodebian.img> ls -ld /etc/passwd
-rw------- 1 0 0 1257 Jul  8 20:24 /etc/passwd

and even if I make it readable to everyone while under root, upon then non-root invocation -- it is not readable again:
$> sudo singularity shell --writable /tmp/neurodebian.img
[sudo] password for yoh:
Singularity/neurodebian.img> chmod a+r /etc/passwd
Singularity/neurodebian.img> ls -l /etc/passwd
-rw-r--r-- 1 root root 1197 Jul  8 17:01 /etc/passwd
Singularity/neurodebian.img> exit

$> singularity shell /tmp/neurodebian.img
Singularity/neurodebian.img> tail /etc/passwd
tail: cannot open '/etc/passwd' for reading: Permission denied
Singularity/neurodebian.img> ls -ld /etc/passwd
-rw------- 1 0 0 1257 Jul  8 20:26 /etc/passwd
Singularity/neurodebian.img> exit

output of debug sent via email (does it have any privatish data? on a quick look didn't see)

Well, that is weird... What is your umask set to?
Long story short, when singularity is called as a non-root user,
/etc/passwd and /etc/group within a container are modified outside the
container and bind'ed back into the container to account for the user
calling the container. /etc/passwd|group are copied from the container to
the session directory, then lines are appended to those files referencing
the calling user, and then those files are bounded back into the container
ontop of the originals. Soo... What I think might be going wrong would have
to do with umask. I have to check the code, but it is possible I didn't
preserve the permissions of those files when I created the copies.
What is your umask set to? Can you open it up and see if that fixes it?

On Fri, 08 Jul 2016, Gregory M. Kurtzer wrote:

Well, that is weird... What is your umask set to?

here we are talking! ;)   mine is the one which gives pain more often
than it helped I think --  077  ;)

Long story short, when singularity is called as a non-root user,
/etc/passwd and /etc/group within a container are modified outside the
container and bind'ed back into the container to account for the user
calling the container. /etc/passwd|group are copied from the container to
the session directory, then lines are appended to those files referencing
the calling user, and then those files are bounded back into the container
ontop of the originals. Soo... What I think might be going wrong would
have
to do with umask. I have to check the code, but it is possible I didn't
preserve the permissions of those files when I created the copies.

What is your umask set to? Can you open it up and see if that fixes it?

opened up!  besides some empty line in the tail of /etc/passwd:
systemd-bus-proxy:x:103:106:systemd Bus Proxy,,,:/run/systemd:/bin/false
yoh:x:47521:47522:Yaroslav Halchenko,,,:/home/yoh:/bin/zsh
it all works -- whoami works and permissions are set sanely.
DO NOT TRUST USERS HAVING A SANE UMASK -- but preserve it inside I guess  ;)
Cheers!
Yaroslav O. Halchenko
Center for Open Neuroscience     http://centerforopenneuroscience.org
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
Phone: +1<PHONE_NUMBER>                       Fax: +1<PHONE_NUMBER>
WWW:   http://www.linkedin.com/in/yarik

Fixed in [master 2a7c530], thanks!


modern-cpp-kafka: init at 2023.03.07

Description of changes
Adds a derivation for modern-cpp-kafka.

NOTE
Using my fork that patches some cmake build setup temporarily. Won't be required once my PR
is accepted upstream. Alternatively I could apply my fixes as an inline-patch while still using the official repo.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Oh and one more thing, can you change the commit message ( and the PR title) to modern-cpp-kafka: init at 2023.03.07 ?

A few things are still left.

The commit message ( and PR title) is still named "kakfa" instead of "kafka".

From here it gets pedantic, but we want to keep the commit history in a good quality:

The commit message of the maintainership commit does not fit. You can find other good examples in the history of that file: https://github.com/NixOS/nixpkgs/commits/master/maintainers/maintainer-list.nix
Therefore, the maintainership commit should be separate from any packages and you can just directly write it into the package commit itself.

After that it should be good to go.

A few things are still left.
* The commit message ( and PR title) is still named "kakfa" instead of "kafka".

From here it gets pedantic, but we want to keep the commit history in a good quality:
* The commit message of the maintainership commit does not fit. You can find other good examples in the history of that file: [`master`/maintainers/maintainer-list.nix (commits)](https://github.com/NixOS/nixpkgs/commits/master/maintainers/maintainer-list.nix)

* Therefore, the maintainership commit should be separate from any packages and you can just directly write it into the package commit itself.

After that it should be good to go.

@nagy split and reworded the maintainer commit, I hope it's good to go now

The commit message is still "kakfa" . After that, its good.

The commit message is still "kakfa" . After that, its good.

Whoops, sorry about that. Good to go

Result of nixpkgs-review pr 251825 run on aarch64-darwin 1

1 package built:

modern-cpp-kafka


[tests] Skip float64 tests if unsupported by XPU hardware

Adds float64 type checking to the check_type_supported function in test_core
Extends the use of check_type_supported in test_core to a few tests where we have float64 inputs/outputs
Adds float64 type checking to test_libdevice

Close #888
I would suggest keeping commits separate so we can more easily revert if problems pop up later.

I would suggest keeping commits separate so we can more easily revert if problems pop up later.

If you would like to do that, please squash 590967d and d875563, and rebase them with the latest llvm-target.

No impact on PVC pass rate:
PR:
2024-04-19T22:10:33.0443857Z ========= 6066 passed, 52 skipped, 675 xfailed, 583 warnings in 23.52s =========

llvm-target:
2024-04-19T20:23:44.7830108Z ========= 6066 passed, 52 skipped, 675 xfailed, 582 warnings in 23.27s =========

The additional warning appears spurious. I checked the last few commits in llvm-target and the number of warnings seems to vary - perhaps based on which runner is used? In any case I didn't see any warnings as a result of the commits above.
I will just squash and merge, the revert or bisect ability is not that important for small changes.


F-14 booth Radio presets

Since booth Radios goes cracy with the Preset knobs i found the error and eliminate it in BIOS but i think this change affects FP.
Here the changes left old / right new
Pilot

RIO

here the new readouts for frequencies:

the lua with this changes
F-14B.zip

Is this official or beta? Which should I use for testing?

this is for booth stable and beta.  That was a know bug from the beginning of the F-14.
We had the problem with the preset switch that ist counts false after you go over the 30.

OK, changes UHF and VUHF to use the functions for getting the display data.

fixed in 4.0.11alpha


:broom: remove mako code and dependnecy

Changes

Remove supporting code for Mako performance tests
Remove Mako dependency

/kind cleanup

Release Note

Remove Mako dependency

/hold
for serving PR https://github.com/knative/serving/pull/12266 to be merged in first

looks like the Mako dependency is used by a bunch of other repos as well, eventing and so on, so might not be able to remove it just yet

/close
we need to figure out the plan in eventing first


[Loader] wrong style when appears inside a Modal

[Loader] rendered inside a Modal will be white on white
Steps
Create a Loader inside of the content of the modal
Expected Result
Loader should be none "inverted" (white on black) but regular, but because of the fact that Modal has .dimmer behind it, the loader becomes inverted
Actual Result
Loader inside of Modal should be visible
Version
2.4.2
Testcase
https://jsfiddle.net/7ucjso1y/

This has already been fixed in the community fork Fomantic-UI
See your adjusted jsfiddle here
https://jsfiddle.net/lubber/r8fcuak3/1/

Can I just replace the css file?

Can I just replace the css file?

Usually Fomantic-UI is backward compatible to SUI, so you can try that.
However, since the last release of SUI in 2018 we already fixed around 500+ bugs or added new features, so the FUI css is probably only correctly working together with FUI JS as well.

The problem with fui is that is doesn't have React components :/

The problem with fui is that is doesn't have React components :/

As said, the CSS Part is 99% compatible to SUI React (1% "missing" because we improved the rating component and have lots of new components, which SUI React does not cover, because they are bound to the latest Version of SUI). So unless you have the need of new features, it should work by just using the CSS file of FUI and keep everything else from SUI(-React) as it is.
AFAIK the SUI react team is working on a FUI compatibility layer.

The problem with fui is that is doesn't have React components :/

Just want to add, as lubber-de mentioned. That its absolutely possible to use the FUI CSS along with Semantic UI React.
We are currently using this pattern for an internal tool that serves dozens of operational members and developers and have been happy with the stability.
I'd encourage you to check out FUI (fomantic UI).
If you find this helpful, consider contributing some code of your own to either project (check out the "good first issue" tag)

Thank you, but As I've mentioned, I'm using SUIR, therefore, there is no reason to load a larger css file just for fixing "one small issue". I'm fixing it in my code.

Thank you, but As I've mentioned, I'm using SUIR, therefore, there is no reason to load a larger css file just for fixing "one small issue". I'm fixing it in my code.

Not quite sure I understand you. You can use FUI less to completely replace the css from SUI. Not only would it fix the issue you describe, but hundreds of other bugs as well.
I doubt the size difference between SUI css and Fomantic CSS would be substantive but if you have a very special use case and you're only using select components, you could just import the matching less modules from FUI by adjusting the theme file to your liking.

Thanx for the explanation, I'll take a look at it


Placement of markers by user

Is it possible to allow markers to be set by an user? I figured out how to place markers statically.

Hey, right now it is not. In the future we could support a livewire version of the map with this functionality ( feel free to set in a pr ).

Closing this for now. Further discussion can be done in a PR


An error occurred while rendering a label when contextOptions.requestWebgl1 is true

What happened?
const viewer = new Cesium.Viewer("cesiumContainer", {
  contextOptions: {
      requestWebgl1: true,
  },
});

function addLabel() {
  viewer.entities.add({
    position: Cesium.Cartesian3.fromDegrees(-75.1641667, 39.9522222),
    label: {
      "text": "text",
    },
  });
}
addLabel();

the code above will produce an error:
TypeError: Failed to execute 'texSubImage2D' on 'WebGLRenderingContext': parameter 9 is not of type 'ArrayBufferView'.

here is sandcastle example
Reproduction steps
No response
Sandcastle example
No response
Environment
Browser: Chrome 129
CesiumJS Version: 1.122
Operating System: windows11

Thanks for the report @eclosion!
I believe this is a regression from https://github.com/CesiumGS/cesium/pull/12100.

Has version 1.123 not been modified?

Has version 1.123 not been modified?


jackson-databind:2.11.0 shipped with this library is a security vulnerability

I made sure...

[x] I read the README.md
[x] I looked over the examples and wiki
[x] my issue hasn't been asked or solved before

Question
According to checkmarx jackson-databind:2.11.0 has three vulnerabilities.

CVE-2021-20190 8.1 Deserialization of Untrusted Data vulnerability pending CVSS allocation
Cxced0c06c-935c 5.9 Uncontrolled Resource Consumption vulnerability pending CVSS allocation
CVE-2020-36518 7.5 Out-of-bounds Write vulnerability pending CVSS allocation

Provides transitive vulnerable dependency com.fasterxml.jackson.core:jackson-databind:2.11.0

CVE-2021-20190 8.1 Deserialization of Untrusted Data vulnerability pending CVSS allocation
Cxced0c06c-935c 5.9 Uncontrolled Resource Consumption vulnerability pending CVSS allocation
CVE-2020-36518 7.5 Out-of-bounds Write vulnerability pending CVSS allocation
CVE-2022-42003 7.5 Deserialization of Untrusted Data vulnerability pending CVSS allocation
CVE-2022-42004 7.5 Deserialization of Untrusted Data vulnerability pending CVSS allocation

Sent a pull request with just this update.
https://github.com/instagram4j/instagram4j/pull/704


java.lang.NoClassDefFoundError when using this library in conjunction with the Jenkins Pipeline Shared Library Groovy Plugin

Expected Behavior
I am trying to execute the following spec:
package hello

import com.homeaway.devtools.jenkins.testing.JenkinsPipelineSpecification

class TestSpec extends JenkinsPipelineSpecification {

    def utils = null

    def setup() {
        utils = loadPipelineScriptForTest("../../../src/hello/Utils.groovy")
    }

    def "a sample test" () {
        given:
        Utils mockedUtils = GroovyMock(global: true)
        mockUtils.mockedMethod("hello") >> "world"

        when:
        utils.testMethod("hello")

        then:
        1 * mockUtils.mockedMethod("")

    }
}

Actual Behavior
I am receiving the following exception when I run my test:
org/jboss/modules/ModuleClassLoader
java.lang.NoClassDefFoundError: org/jboss/modules/ModuleClassLoader
	at java.base/java.lang.Class.forName(Class.java:340)
	at com.homeaway.devtools.jenkins.testing.LocalProjectPipelineExtensionDetector.getClassesOfTypeInPackage(LocalProjectPipelineExtensionDetector.java:88)
	at com.homeaway.devtools.jenkins.testing.JenkinsPipelineSpecification.setupSpec(JenkinsPipelineSpecification.groovy:1018)
Caused by: java.lang.ClassNotFoundException: org.jboss.modules.ModuleClassLoader
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:602)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
	... 3 more

Steps to Reproduce
Please include a numbered list of steps that other people can use to recreate the "Actual Behavior."

Open the included sample project and open it in IntelliJ
Within intellij, execute the test by click on the green arrow next to the dest definition.

Additional Information
I am using this library in conjunction with this Gradle plugin, since the plugin does a whole lot of boiler plate stuff to enable Jenkins shared library stuff to compile locally.
I have a very simple build.gradle file:
plugins {
    id "com.mkobit.jenkins.pipelines.shared-library" version "0.10.1"
    id 'groovy'
}

repositories {
    jcenter()
    mavenCentral()
    maven { url 'https://repo.jenkins-ci.org/releases/' }
}

dependencies {
    implementation 'org.codehaus.groovy:groovy-all:2.4.15'

    testImplementation 'com.homeaway.devtools.jenkins:jenkins-spock:2.1.2'
    testImplementation "org.spockframework:spock-core:1.2-groovy-2.4"
}

configurations.all {
    exclude group: "com.ibm.icu"
}

It seems that the issue only happens when I run the test from within IntelliJ (when I run them from gradlew build I don't get the same exception), so I am also going to open a ticket with the JetBrains team to see what's going on.

So I traced the source of the exception to this block of code in the LocalProjectPipelineExtensionDetectore.java file:
			try {
				clazz = Class.forName( classname );
			} catch( ClassNotFoundException e ) {
				failures.put( classname, e );
				continue;
			}

The value for classname is org.jboss.marshalling.ModularClassResolver$2 when it throws the exception.

I noticed the stack trace did not line up with the methods, since I ended up digging into the source of JDK, and thought something seemed funny. I changed the project SDK version from 14 to 1.8 and it worked fine.

I am reopening this issue since it looks like there is a compatibility issue with newer versions of Java. If I run ./gradlew test with Java 8, there are no issues. However if I run the same command with Java 11, I get that NoClassDefFoundError exception. It looks like there was a change in the JDK that wrapped the ClassNotFoundException with a NoClassDefFoundError. Not sure why. But line 89 of LocalProjectPipelineExtensionDetector.java isn't catching the exception:


fix: move updateViaGitHub to Dubya

:tada: This PR is included in version 1.0.0-alpha.33 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fzf sixels image preview empty on Windows Terminal Preview + pwsh + chafa on Windows

Checklist

[X] I have read through the manual page (man fzf)
[X] I have searched through the existing issues
[X] For bug reports, I have checked if the bug is reproducible in the latest version of fzf

Output of fzf --version
0.55.0 (fc69308)
OS

[ ] Linux
[ ] macOS
[X] Windows
[ ] Etc.

Shell

[ ] bash
[ ] zsh
[ ] fish
[X] pwsh

Problem / Steps to reproduce
Windows Terminal Preview now supports sixels. The stable release of Windows Terminal does not yet support it.
Problem:
In pwsh, on Windows Terminal Preview, when you run ls -name *.png | fzf --preview 'chafa -s 50x50 -f sixels {}', the preview window is empty.
Steps:

Get Windows Terminal Preview here: (https://github.com/microsoft/terminal/releases/tag/v1.22.2362.0).
Run scoop install fzf chafa.
Run ls -name *.png | fzf --preview 'chafa -s 50x50 -f sixels {}' in directory that has png files.

I also encountered a similar problem, and I was able to reproduce it on Windows Terminal + gitbash:
echo hello | fzf --preview='type ls'

PS: This problem doesn't occur in the VScode Terminal + gitbash

This is issue related to sixels image previews on Windows. Your issue seems to be related to text previews.
Also, I cannot reproduce your issue. See the image below.

This is on Git Bash + Windows Terminal.
What version is your git and fzf?

This is issue related to sixels image previews on Windows. Your issue seems to be related to text previews.
Also, I cannot reproduce your issue. See the image below.  This is on Git Bash + Windows Terminal.
What version is your git, fzf, and Windows Terminal? And what font do you use in Windows Terminal?

Window version: windows 11 家庭中文版  23H2  22631.4037
Git version: 2.42.0.windows.2
Windows Terminal version: 1.20.11781.0
fzf version: 0.55.0
Font: Cascadia Mono

This is issue related to sixels image previews on Windows. Your issue seems to be related to text previews.
Also, I cannot reproduce your issue. See the image below.  This is on Git Bash + Windows Terminal.
What version is your git, fzf, and Windows Terminal? And what font do you use in Windows Terminal?

Window version: windows 11 家庭中文版  23H2  22631.4037
Git version: 2.42.0.windows.2
Windows Terminal version: 1.20.11781.0
fzf version: 0.55.0
Font: Cascadia Mono

I can't reproduce it with Cascadia Mono. The preview works for me.

Git: git version 2.46.0.windows.1
fzf: 0.55.0 (fc69308)
Windows Terminal: 1.21.240823001

Does it work in non-fullscreen mode? e.g. --height=-1

Yes, ls -name *.png | fzf --height=-1 --preview 'chafa -s 50x50 -f sixels {}' works.

Also, if the image is too large and it is displayed, some residue is left from the large image when you go to a smaller image.

Large image:

Going to a smaller image:

Yes, ls -name *.png | fzf --height=-1 --preview 'chafa -s 50x50 -f sixels {}' works.

This works, but clicking to select something is broken.

I just saw this issue and I have 2 relevant issues open in the chafa project. See Chafa-#217 and Chafa-#218. Also a issue in wezterm which I think is more related to #3646 and #3486 but I suspect there are underlying issues connecting all of these. There's additional complexity introduced when using ssh and tmux fwiw.
I believe there are overlapping issues with fzf and chafa. Why I came here in the first place was actually to ask about $FZF_PREVIEW_COLUMNS and $FZF_PREVIEW_LINES since these do not appear to be calculated in a way that is compatible with chafa's (though if you read the issue there's some confusion there too).
I'll keep working with the chafa team but it may be good to at least have these cross linked and note that this issue appears to be cross platform.

It's a long story.
We currently have two different renderer implementations for Windows, one is based on tcell library which is used when opening fzf in full-screen mode. The other is "light renderer" which was added later to support --height option on Windows.

https://github.com/junegunn/fzf/blob/master/src/tui/tcell.go
https://github.com/junegunn/fzf/blob/master/src/tui/light_windows.go

"Light" renderer has image support (using simple pass-through mechanism), but tcell renderer does not, so that's why image is only shown when --height is given.
I tried removing the tcell renderer and using the light renderer even in full-screen mode, but it turned out to have an issue with non-ASCII characters, so I had to revert the decision.
https://github.com/junegunn/fzf/commit/559fb7ee4552312f59a4bbe428199db9f5aa1247
We need to find a way to fix https://github.com/junegunn/fzf/issues/3799


UTXO screen

does not match the design

@Denis-Asipenko
Please see this task - https://github.com/BeamMW/ios-wallet/issues/52
also all statuses received from the SDK and match with the desktop application.
https://github.com/BeamMW/beam/blob/08e7a492bd56954001dcd856a4575718443a35d9/ui/viewmodel/utxo_view.cpp (line 56)

checked


Unclear NPM message during SPFx project provision

Category

[x] Question
[ ] Typo
[ ] Bug
[ ] Additional article idea

Expected or Desired Behavior
More information what it means the specific npm version was found.
Observed Behavior
When I create a new project using SPFx I see the following message during the configuration or installation. I don't get any clue out of it what it actually means.

Is it good? Is it bad? Is it just an information like we found npm in a specific version? Does it mean this will be used for the installation of all NPM packages?
Steps to Reproduce
Create a new SPFx project using version 1.5.0.

@StfBauer , thanks. That's indeed an information we provide as part of the flow that can help us in the investigation in case of potential issues.
If you believe that is confusing we can definitively think about removing it in the future versions or move it somewhere else.

@lucabandMSFT What do you think about having this information more at the beginning. Similar what I did in the PnP generator.

Something like this. Right somewhere in the generator, it is definitely confusing:

SPFX:     1.8.2
Installer: npm 6.1.0

This is spat out by Yeoman by default, but it's not something we're going to remove at this point.


Add an SSL/TLS certificate

Any website or application that has a login system should be using an ecrypted connection.
There's only so much valuable data that an attacker could get by intercepting a Relaxio login (so far?), but TLS will give a little extra protection for users who unfortunately reuse passwords across multiple services, and could help prevent cleartext email addresses from being added to a spam list.

Depending on your hosting provider, Let's Encrypt makes it fairly simple, and it's a free service by a nonprofit.

This issue becomes less urgent since you commented in #59 about removing the login system. Although the Web at large is slowly moving toward TLS everywhere, and search engines look more favorably on sites with an encrypted connection than those without, so it's still not a bad idea.


Disable OpenQA::Test::TimeLimit by ENV variable or when running within debugger

Disable OpenQA::Test::TimeLimit when running within debugger
Add option to disable test timeout with env variable

hm, https://codecov.io/gh/os-autoinst/openQA/pull/3555/diff?src=pr&el=tree#diff-dC9saWIvT3BlblFBL1Rlc3QvVGltZUxpbWl0LnBt shows that the latter code was never called but we are not running the test under a debugger – or so I thought.


walletkit-java not found on bintray

Could not GET 'https://dl.bintray.com/brd/walletkit-java/com/breadwallet/core/corecrypto-android/6.2.2/corecrypto-android-6.2.2.aar'. Received status code 403 from server: Forbidden
Disable Gradle 'offline mode' and sync project

Hi @DrewCarlson, this is blocking me. Could you upload the artifacts to another maven?
If you could share the artifacts I could add them locally too.

When the source code for 4.10.0 is published, you'll find all bintray repositories replaced.  The two missing dependencies redacted and walletkit are included as git submodules+composite gradle builds.
If you'd like to make the artifacts permanently available, publishing to a maven repository (like Artifactory) is documented here: https://github.com/blockset-corp/walletkit/tree/core-6.2.2/WalletKitJava#publishing
Though to unblock yourself, checking out the core tag, running ./gradlew publishToMavenLocal, and then adding the mavenLocal() repository is likely the quickest path forward.

Could I use ZacSweers/redacted-compiler-plugin (he has artifact at repo.maven.apache.org/maven2) or do I have to use your fork?

Resolved with the latest release, see https://github.com/breadwallet/brd-mobile


bicycle parking type strings are not translatable

I registered to https://www.transifex.com/ideditor/id-editor with intention of translating values displayed for Polish iD version during selecting bicycle_parking tag value. It appears that this value is not translatable.
To reproduce:

request pl version of iD
select/create amenity=bicycle_parking node
see section "Typ" (name of section is translated)
see "stands, wall_loops, rack..." placeholder and values in dropdown
register on https://www.transifex.com/ideditor/id-editor/
go to https://www.transifex.com/ideditor/id-editor/translate/#pl
select either presets or core, search for translatable values containg "wall", "loops" etc
no values are found

I would expect that this values are translatable.

Yes see #2708
The tags in OpenStreetMap are basically free-form entry, but expected to contain English values.  For the fields with a strict set of defined values (like the mountain bike difficulty) we support translation of the values, and for the fields where the user can type in anything they want, we haven't thought up a good way to support i18n, and instead just lookup the most common values from taginfo.

In this case it is strict set of defined values. I will open a new issue for that.


Use esp32 devkit also for BLE presence sensing

Describe you new feature you'd like
Usually these devkits can be used through ESPHome for BLE based presence sensing. Given that they are now flashed with custom firmware, is there a possibility to enable this additional usage for the device?

Unfortunately, the BLE libraries are too big for the flash size.  It isn't just a matter of turning on BLE, the library sizes of WiFi and BLE are very large and each consumes ~1Mb per library.  If you do both you don't have room for anything else like OTA updates, a UI, or any custom firmware.
The other wart with BLE on the ESP32 is that it shares a radio with WiFi so when you have both enabled one or the other suffers.  I guess this is a long way around to say that until ESPSomfy RTS will probably not be adding BLE capabilities anytime soon.

I see. All clear, thank you for the explanation. On 19 Jun 2024, at 18:05, rstrouse @.***> wrote:
Unfortunately, the BLE libraries are too big for the flash size.  It isn't just a matter of turning on BLE, the library sizes of WiFi and BLE are very large and each consumes ~1Mb per library.  If you do both you don't have room for anything else like OTA updates, a UI, or any custom firmware.
The other wart with BLE on the ESP32 is that it shares a radio with WiFi so when you have both enabled one or the other suffers.  I guess this is a long way around to say that until ESPSomfy RTS will probably not be adding BLE capabilities anytime soon.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

I am going to close this out.  I don't think BLE can be added to the current platform.


Nginx redirect error

Summary
nginx Image redirect error

Steps to reproduce

Start up a container with with NGINX_MODE=REDIRECT
Webpage return 404.

What is the expected correct behavior?
Webpage should be redirected to the NGINX_REDIRECT_URL

Relevant logs and/or screenshots
2022/07/07 02:19:39 [error] 1231#1231: *4 open() "/etc/nginx/<WEBROOT><REDIRECT_URL>" failed (2: No such file or directory), client: 0.0.ip.address, server: localhost, request: "GET / HTTP/1.1", host: "host.url.com"

Environment

Image version / tag:  tiredofit/nginx:latest
Host OS: archlinux

Possible fixes

Resolved in 6.1.5


Decouple render instruction creation from rendering

This pull request changes vector tile rendering so instruction creation is no longer done in an animation frame.
Instruction creation is not supposed to perform any canvas operations any more, so it makes sense to do it as soon as all source tiles have finished loading. In the future, this could be done in a worker.
To avoid blocking interactions and animations during rendering, we now only render new tile images when no interaction or animation is going on, or when we have a lower resolution interim tile available. Even when rendering a high fidelity map, we spend no more than 100 ms in a frame, to avoid blocking interactions that the user might start when the map image from the previous render has settled.
The result of these changes is an improved user experience, where the map is much more responsive to user interactions.

This is now ready for review.

https://21-4974939-gh.circle-artifacts.com/0/examples/mapbox-style.html is a good example to test the improvements in perceived performance.

I have now cleaned up the commit history. Thanks for any review.

ping @gberaudo

Thanks for the review @fredj.


Line level

Line levels are a special brand of spirit level used for leveling across longer distances. They can be attached to a tightly pulled string to find level between two stakes in the ground to find level ground.
Line levels are a much more cost-conscious alternative to line laser levels.

Stabila Plastic Line Level (STB40479)

Sola UZ

Features

Compact, lightweight, handy
Resistant against water, heat and cold
Break-resistant acrylic tube vials
Practical V-groove

Swanson Tool LLA001 4-Inch Aluminum Line Level


Refactor javadocs to work with recent JDK

Split from my initial submission in #12, as requested.

Thanks for that!


[Decompiler] Improve reverse field lookup

Improve the reverse field lookup.  Now we can correctly handle the cases described in https://github.com/water111/jak-project/issues/161.  We also should support inline basics, more types of nested field access, better "get pointer to thing in array", and support for fancy boxed arrays (print and inspect for array type now pass type propagation).
After this PR, KERNEL.CGO:
144/211 functions attempted type analysis (68.25%)
125/144 functions that attempted type analysis succeeded (86.81%)
125/211 functions passed type analysis (59.24%)

Pull Request Test Coverage Report for Build 444501363

130 of 274 (47.45%)  changed or added relevant lines in 4 files are covered.
73 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.7%) to 80.709%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

common/type_system/TypeSystem.cpp
1
2
50.0%

common/type_system/TypeFieldLookup.cpp
82
225
36.44%

Files with Coverage Reduction
New Missed Lines
%

common/type_system/TypeSystem.cpp
73
71.71%

Totals

Change from base Build 440614997:
-0.7%

Covered Lines:
18212

Relevant Lines:
22565

💛  - Coveralls


[Doc] Create the top page of Read the Docs

New Documentation
Create the top page of Read the Docs.
1st/2nd level of the following items will go to the top page.
The latest document created in this Issue can be found in:
https://autoware.readthedocs.io/en/feature-documentation_rtd/
Menu Items
Overview
Users Guide

Installation

Build

Docker Image
Source Build
Cross Build

Setup (Yolo etc...)

Tutorials

Quick Start
etc...

Packages

Developers Guide

Development Process
Design & Architecture

Overview
Design Rule (Namespace etc...)
Detection (Each Component Design)
Localization
etc...

API

Community

Mailing List
Slack

First work is to create menu list in this issue as shown above.

Yang's comment

We should have a dedicated Partner section, within which we should have sections for OEMs (vehicle integration tutorials), for platform vendors (enablement on various hardware platforms & SoCs), for use case service vendors (example cases or instructions of where to dive in for typical use case scenarios implementation)
For the system architecture, high level diagram will be hard to automate, probably does not make sense to automate either. But we do need to keep an update to date version of this as releases move on. Having said that, for a set of services which Autoware has defined already and people are familiar with, such as NDT, Tracking, detection, we should be able to automate node level diagram synchronisation with code update.

https://autoware-developer.slack.com/archives/CBY5ZGR08/p1535447645000100

Let me know any levels of feedback.
Not all items listed in this channel are there, but we can add them step by step.
I’ll try to create a initial file of the top page.

Setup initial index.rst that can be found in Read the Docs:
https://autoware.readthedocs.io/en/feature-documentation_rtd/

It seems that the base directory should be moved from Autoware/docs/ to Autoware/docs/en/


Fix constraint rendering for expressions and foreign key constraint types

resolves https://github.com/dbt-labs/dbt-core/issues/7417
resolves https://github.com/dbt-labs/dbt-core/issues/7480
resolves https://github.com/dbt-labs/dbt-core/issues/7416

Description

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[x] I have run changie new to create a changelog entry

Let's add examples for each type of constraint + usage with expression in our docs


'Data for  experiment ... could not be found.' error when a job fails

When fetching results for a Qiskit job that failed because the quota was exceeded, the AzureQuantumProvider throws an error:
Job id 5dc72a0a-3911-11ec-9598-00155db11bbe Job Status: job incurred error
Result(backend_name='ionq.qpu', backend_version='1', qobj_id='Qiskit Sample - 3-qubit GHZ
circuit', job_id='5dc72a0a-3911-11ec-9598-00155db11bbe', success=False, results=
[ExperimentResult(shots=1024, success=False, meas_level=2, data=ExperimentResultData(),
header=QobjExperimentHeader())])-----------------------------------------------------------------------
---- QiskitError Traceback (most recent call last) /tmp/ipykernel_8079/1369783936.py in <module>
11 print(result) 12 counts = {format(n, "03b"): 0 for n in range(8)} ---> 13
counts.update(result.get_counts(circuit)) 14 print(counts) 15 plot_histogram(counts)
/usr/local/lib/python3.7/site-packages/qiskit/result/result.py in get_counts(self, experiment) 278
dict_list = [] 279 for key in exp_keys: --> 280 exp = self._get_experiment(key) 281 try: 282 header =
exp.header.to_dict() /usr/local/lib/python3.7/site-packages/qiskit/result/result.py in
_get_experiment(self, key) 390 391 if len(exp) == 0: --> 392 raise QiskitError('Data for experiment
"%s" could not be found.' % key) 393 if len(exp) == 1: 394 exp = exp[0] QiskitError: 'Data for
experiment "Qiskit Sample - 3-qubit GHZ circuit" could not be found.'

Recommendation is to directly pass up the ErrorCode and ErrorMessage since they are determined by the hardware providers directly.


pythonPackages.stestr: init at 2.6.0

Motivation for this change
Add test dependency for qiskit #78772 @jonringer
Depends on #78876 and #78877
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@doronbehar I'm OK with letting this PR lapse, but thanks for your review. I'd originally thought several packages needed stestr (see linked PRs), but I found they can be tested with pytest, which is simpler/better-supported. Maybe slightly slower tests b/c not parallelized, but acceptable. And if I really need parallel tests, I can do that with pytest-xdist.


Add type hints

Added type hints as discussed in https://github.com/facebookresearch/schedule_free/issues/34.
For params and lr, I used the same type hints as torch's SGD / Adam optimizers which are a bit more generic than what is mentioned in the schedulefree doc strings. Feel free to change it if you're not happy with my current version.

Thank you! I will do a release in the next few days including this change.


Generating example data for Primitive Schema and enhanced support for data-type formats

Description
The ModelObject source has been updated to - 1) Identify Primitive type schemas and 2) Fall back to the "type" property if a correct format cannot be identified or is not specified.
Related Issue
https://github.com/adobe/ride/issues/25
https://github.com/adobe/ride/issues/24
How Has This Been Tested?
Added following unit-tests to ModelObjectTest - testPrimitiveSchemaDefinitionModelInstance() and testFallBackToSchemaTypeIfFormatCannotBeIdentified()
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Reviewing.

@enortonAtAdobe I assume you are talking about the "eclipse-java-google-style.xml". I was unable to import the settings. Are you using the same one?

yes, I'm able to import the formatter into eclipse. are you using that tool?  in that same repo, there is also a formatter for intellij if that's the ide of your choice. essentially, the main thing I'm noticing in the PR is that the style guide calls for 2 spaces for indentation (not tabs, not 4 spaces)

@enortonAtAdobe I am using Eclipse. Did you import using - >Window -> Preferences -> Java -> Formatter -> Import ?

@nbhusare:
Not sure what version of Eclipse you're on, or what the menu path is on Windows, but on version 2018-12 on Mac its:
Preferences -> Java -> CodeStyle-> Formatter -> Import

@tedcasey I am using: Eclipse DSL Tool, Version: 2018-12 (4.10.0), Build id: 20181214-0600

@nbhusare Can you tell me where you downloaded the styleguide from?  This is the one you should be using: https://github.com/google/styleguide/blob/gh-pages/eclipse-java-google-style.xml

@tedcasey The "eclipse-java-google-style.xml" was corrupted for some reason. I have imported the right now and reformatted the code changes. Pushed the same.

Merged.  I'll build a release soon.


Feature/issue 60 link users to site

@miltontony ready for review

@saeedmb8 @miltontony I tested the migration locally, works 100 :)

👍


Add shellcheck

And attempt to add it to travis too (I hope that works)

[Current coverage][cc-pull] is 91.48%

Merging [#110][cc-pull] into [master][cc-base-branch] will decrease coverage by 1.05%

@@             master       #110   diff @@
==========================================
  Files            50         52     +2
  Lines          2778       2855    +77
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           2571       2612    +41
- Misses          207        243    +36
  Partials          0          0

Powered by Codecov. Last updated by [2aa0b79...93e0477][cc-compare]
[cc-base-branch]: https://codecov.io/gh/markstory/lint-review/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/markstory/lint-review/compare/2aa0b790499c75447ca6c96a4d91d13b3984b07f...93e04777758e678beb2e3c6f6c2f0ea79d3dd021
[cc-pull]: https://codecov.io/gh/markstory/lint-review/pull/110?src=pr

Nice work!


npm install is failing for me

Currently debugging running npm install after cloning this project - I'm not sure what this error is:
gitpod /workspace/prettier-plugin-go-template (master) $ npm i
npm ERR! code ECONNREFUSED
npm ERR! syscall connect
npm ERR! errno ECONNREFUSED
npm ERR! FetchError: request to<EMAIL_ADDRESS>failed, reason: connect ECONNREFUSED <IP_ADDRESS>:4873
npm ERR!     at ClientRequest.<anonymous> (/home/gitpod/.nvm/versions/node/v16.13.2/lib/node_modules/npm/node_modules/minipass-fetch/lib/index.js:110:14)
npm ERR!     at ClientRequest.emit (node:events:390:28)
npm ERR!     at Socket.socketErrorListener (node:_http_client:447:9)
npm ERR!     at Socket.emit (node:events:402:35)
npm ERR!     at emitErrorNT (node:internal/streams/destroy:157:8)
npm ERR!     at emitErrorCloseNT (node:internal/streams/destroy:122:3)
npm ERR!     at processTicksAndRejections (node:internal/process/task_queues:83:21)
npm ERR!  FetchError: request to<EMAIL_ADDRESS>failed, reason: connect ECONNREFUSED <IP_ADDRESS>:4873
npm ERR!     at ClientRequest.<anonymous> (/home/gitpod/.nvm/versions/node/v16.13.2/lib/node_modules/npm/node_modules/minipass-fetch/lib/index.js:110:14)
npm ERR!     at ClientRequest.emit (node:events:390:28)
npm ERR!     at Socket.socketErrorListener (node:_http_client:447:9)
npm ERR!     at Socket.emit (node:events:402:35)
npm ERR!     at emitErrorNT (node:internal/streams/destroy:157:8)
npm ERR!     at emitErrorCloseNT (node:internal/streams/destroy:122:3)
npm ERR!     at processTicksAndRejections (node:internal/process/task_queues:83:21) {
npm ERR!   code: 'ECONNREFUSED',
npm ERR!   errno: 'ECONNREFUSED',
npm ERR!   syscall: 'connect',
npm ERR!   address: '<IP_ADDRESS>',
npm ERR!   port: 4873,
npm ERR!   type: 'system'
npm ERR! }
npm ERR!
npm ERR! If you are behind a proxy, please make sure that the
npm ERR! 'proxy' config is set properly.  See: 'npm help config'

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/gitpod/.npm/_logs/2022-03-05T21_07_03_751Z-debug.log

Looks like your .npmrc config is pointing to a local registry. Atleast npm is trying to access the packages from localhost.

That's what it sounds like... but I haven't setup an .npmrc for this repo, and that's a run on a fresh https://gitpod.io machine cloned from this repo :/

After testing agan this still fails on a fresh gitpod machine... I'm not sure why it's erroring for me exactly

Very weird, I just reinstalled all dependencies yesterday evening and it went without any problems.I'm using Node 16.
I also have no local registry running or anything.

thanks a lot for sorting that out!


Update opentelemetry to 0.18

opentelemetry was pulling in tonic 0.6.2 while iroh uses the latest 0.8. With this update we don't have a 2 versions of tonic in the build anymore.

thanks, that’s great


Changes to "Add Liquidity" Widget

At top of widget change "Add Liquidity Protection" to "Add Single-Sided Liquidity"
this part was already changed Change "Full coverage date" to "Coverage date" and show date 30 days from now instead of 100 days

@Ran73Cohen just changing the title of the popup when it is single side staking

@Ran73Cohen just changing the title of the popup when it is single side staking


travis: staged builds experiment

This PR introduces staging to our travis pipeline. Currently all instances perform:

compilation of lnd
linting
compilation and installation of btcd binaries
installation of bitcoind binaries

In total this adds about 3 minutes to each of our 5 instances, resulting in roughly 12 minutes of redundant execution time. Additionally, if if a build fails to compile or lint we detect this 5 separate times, consuming precious instances from other builds.
We alleviate this by adding an initial Build phase, which runs a single instance performing the actions above. This has the benefit of quickly sanity checking the pr before moving on to the more expensive unit or integration test suites, and failing faster for common mistakes. It also warms up the build caches for the Test stage in one fell swoop.
For instance, if 5 people push changes at the same time, they can all get immediate feedback regarding compilation or linting issues, and potentially save hours waiting for other people's test to finish or fail before finding out they had a spelling error. This doesn't alleviate all possible issues, e.g. the 5 instances may already be consumed by test suites, but it does make a sizable step towards minimizing time-to-failure in common scenarios.

Remove 'experiment' from commit msg

moved pr body to commit message, will merge once the build finishes 🎉

I'm no connaisseur of travis config files, but the output definitely looks great!

Here's the link I consulted https://docs.travis-ci.com/user/build-stages/


Offline Detection?

is there a way to detect offline state in the network, so we can serve different content, using the hooks?

I think this would be a great addition to the useNetworkStatus hook. I think the Online/offline events API could be used.

Hi :)
I created a pull request for this feature -> #45

We shouldn't land support for navigator.onLine API because the API itself is unreliable.
https://natalian.org/2012/07/16/navigator.onLine/
https://blog.superhuman.com/building-reliable-apps-on-unreliable-networks-3f75743fc457
The way browsers implement navigator.onLine means that you would likely need to do something much more custom to get what you are actually after.
Per MDN, in Chrome and Safari, if the browser is not able to connect to a local area network (LAN) or a router, it is offline; all other conditions return true. So while you can assume that the browser is offline when it returns a false value, you cannot assume that a true value necessarily means that the browser can access the internet.

As mentioned by @anton-karlovskiy the method used for the pull request is fragile but if you still want to use offline detection using the navigator.onLine API you can checkout -> https://github.com/jaredpalmer/the-platform#usenetworkstatus
I think we can close this issue? :)


Support for CUDA kernels

🚀 Feature

Hi there 👋
From the main readme file I noticed that Thunder except custom kernels, but only the ones that are written in Trition.
Is there a plan to support CUDA kernels?
Motivation
I'm only in the beginning of the custom kernels journey, so I might misunderstand something.
From what I saw online, there are many of highly optimized CUDA kernels already available (since CUDA has been around for quite a while). Plus, there is a high chance that someone with a lot of experience in writing CUDA kernels (but not Trition) want's to use Thunder (or even integrate into an existing project).
I personally would like to write custom CUDA kernels for the LitGPT repo after I finish reading PMPP book.

Hello Andrei,
Thunder can work with any custom kernel, not just the ones written in Triton. Any function that accepts and returns PyTorch tensors can be registered to work with Thunder. Here's a tutorial on connecting CUDA kernels with the PyTorch interface: https://pytorch.org/tutorials/advanced/cpp_extension.html
Once registered in PyTorch these CUDA extensions can be registered in Thunder with OperatorExecutor.register_implementation.
We have one example executor using cross_entropy CUDA kernel from the Apex project:

Executor code: https://github.com/Lightning-AI/lightning-thunder/blob/main/thunder/executors/apex_entropyex.py
CUDA kernel code: https://github.com/NVIDIA/apex/blob/master/apex/contrib/csrc/xentropy/xentropy_kernel.cu
PyTorch C++ interface: https://github.com/NVIDIA/apex/blob/master/apex/contrib/csrc/xentropy/interface.cpp

Hey Ivan,
Thanks for the answer.

Any function that accepts and returns PyTorch tensors can be registered to work with Thunder.

Sounds promising.
Maybe the Readme file should reflect this too, what do you think?
...

- TransformerEngine
- PyTorch eager
- custom kernels, including those written with OpenAI Triton and Nvidia CUDA

In fact, any function that accepts and returns PyTorch tensors can be registered to work with Thunder, what makes it compatible with any custom kernel.

...

?

@IvanYashchuk I was thinking whether it would make sense to have a PyCUDA option as well. This would give us an option to be more decoupled from PyTorch's extension mechanism (and the C++ ABI).

PyTorch supports CUDA Array Interface and any project that works with this interface can accept and write to PyTorch Tensors including PyCUDA (https://documen.tician.de/pycuda/tutorial.html#interoperability-with-other-libraries-using-the-cuda-array-interface), Numba (https://numba.readthedocs.io/en/stable/cuda/kernels.html), CuPy (https://docs.cupy.dev/en/stable/user_guide/kernel.html), and others.

That's right! I think a tutorial that shows how to add a CUDA kernel using the CUDA array interface without necessarily having to build a PyTorch extension would be great /cc @t-vi

Yeah, if anyone has suggestions for a great cuda kernel, I'll take them, or I ask the people on cuda mode...

I have made the demo for this weeks cuda mode lecture with cuda-python and that seemed to work well enough that I'd make it into a Thunder example.

You are talking about Flash Attention lecture (haven't seen it yet)?
If it's, so I think it would be a cool (and somewhat flashy) example.

We have https://github.com/Lightning-AI/lightning-thunder/blob/main/notebooks/extend_thunder_with_cuda_python.ipynb now, so I'm closing this.


Upgrade Extension Package to AsyncPackage

Fixes #204

Allows further updates / versions to be accepted by Extensions Marketplace
Allows running in Visual Studio 2019, without legacy/deprecated API issues

Breaking changes

C++ Build tools now target v140 (Visual Studio 2015)
Removes any support for Visual Studio versions pre 2015

Other changes

Move from VSSDK Helper packages to source packages - This allows direct targeting of API & reduces additional "noise" when including the current versions, e.g. Helper packages *.11 requires *.10, requires *.9 etc

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This looks great!!  Can someone review?

I think I will need to create a new AxoCover entry in the marketplace, since this would break the old VS support, and I would like to avoid that.

@chrish619 Thanks for that work - works like a charm. I pulled it to my repository to be used with other features and just build my local vsix package and using it on daily basis. Thanks

I'd love to see this on VS marketplace.

Author of that plugin does not really respond on any comments. I really don't know what needs to be done to put that on VS Marketplace - I don't even know if I am allowed to put that under new name/account. Noone really want to take Axodox's glory :)

Since this plugin version is no longer compatible with old VS I think it should be uplodaed as a separate entry in VS marketplace. Unfortunately I am having some health issues since last year, and it is hard for me to even do what is needed at my workplace, much less for free time.
At this point the best way would be to create an organization on github, and let the community manage AxoCover in the future.

@axodox , sorry to hear that. I really hope you will get better 😟. I don't have much time and all that things 'organisation on github' is new to me. But if I will find enough time then I will be happy to try that. Thanks for permission


Unlock on enter

closes #181

Hey, can you make a new branch forked from master (rather than forked from in_memory_wallet_unlock) with these changes?

a new branch forked from master

https://github.com/project-serum/spl-token-wallet/pull/187

@jhlx  which style do you prefer?
https://github.com/project-serum/spl-token-wallet/pull/182/commits/fb4b5e3110e10d425fd6a8d5919661bf22530465

Ah we should use the other PR, since that one is branched from master.


SIGSEGV on JavaThread "C2 CompilerThread0"

Please provide a brief summary of the bug
After some time of operation, the application crashes on the same thread. Initially, the problem was with Java 11.0.12, then we decided to upgrade to 11.0.16 (we did not update to the latest one, because it does not support some types of encryption). Supposedly the problem is in C2 CompilerThread0.
Please provide steps to reproduce where possible
I don't know how to reproduce it. But there is an assumption that the problem is in our application. Please help me figure it out.
Expected Results
No crashes
Actual Results
SIGSEGV (0xb) at pc=0x00007f7b523ed3a0, pid=3169304, tid=3169321

JRE version: OpenJDK Runtime Environment Temurin-11.0.12+7 (11.0.12+7) (build 11.0.12+7)
Java VM: OpenJDK 64-Bit Server VM Temurin-11.0.12+7 (11.0.12+7, mixed mode, tiered, compressed oops, g1 gc, linux-amd64)
Problematic frame:
V  [libjvm.so+0xc393a0]  Node::uncast() const+0x0
Current thread (0x00007f7b4cfef000):  JavaThread "C2 CompilerThread0" daemon [_thread_in_native, id=3169321, stack(0x00007f7acfdfe000,0x00007f7acfeff000)]
Current CompileTask:
C2:327560470 1366054       4       ru.naumen.modules.dashboards_v3_4_5.DashboardDataSetService::formatGroup (4005 bytes)

SIGSEGV (0xb) at pc=0x00007fd5adde4b70, pid=1348, tid=1660

JRE version: OpenJDK Runtime Environment Temurin-<IP_ADDRESS>+1 (<IP_ADDRESS>+1) (build <IP_ADDRESS>+1)
Java VM: OpenJDK 64-Bit Server VM Temurin-<IP_ADDRESS>+1 (<IP_ADDRESS>+1, mixed mode, tiered, compressed oops, g1 gc, linux-amd64)
Problematic frame:
V  [libjvm.so+0xc3ab70]  Node::uncast() const+0x0
Current thread (0x00007fd5a9032000):  JavaThread "C2 CompilerThread0" daemon [_thread_in_native, id=1660, stack(0x00007fd541713000,0x00007fd541814000)]
Current CompileTask:
C2:582092926 4697502       4       ru.naumen.modules.dashboards_v3_4_5.DashboardDataSetService::formatGroup (4005 bytes)
What Java Version are you using?
openjdk version "<IP_ADDRESS>" 2022-08-12 OpenJDK Runtime Environment Temurin-<IP_ADDRESS>+1 (build <IP_ADDRESS>+1) OpenJDK 64-Bit Server VM Temurin-<IP_ADDRESS>+1 (build <IP_ADDRESS>+1, mixed mode)
What is your operating system and platform?
Ubuntu 20.04.5 LTS, x64
How did you install Java?
Binary archive, tar.gz.
Did it work before?
No response
Did you test with the latest update version?
Yes

Did you test with other Java versions?
openjdk version "11.0.12" 2021-07-20
OpenJDK Runtime Environment Temurin-11.0.12+7 (build 11.0.12+7)
OpenJDK 64-Bit Server VM Temurin-11.0.12+7 (build 11.0.12+7, mixed mode)

Relevant log output
https://drive.google.com/file/d/1ahlas6Sjgs0B9j4NZV5MyjePy0PLlqHX/view?usp=sharing

@rus-99-pk You will need to update to the latest <IP_ADDRESS> - you can load your own certificates if the one you are using is no longer bundled.

Hi, @karianna!
Why do you think, that is a Java version problem?

I don'y know for sure but a number of C2 compiler bugs were fixed between 11.0.16 and <IP_ADDRESS>

OK. Thank you!