[$2000] Workspace - When adding a new member, add another screen to invite users

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Access staging.new.expensify.com
Login with any account
Go to Settings -> Workspaces -> Open any workspace -> Manage members
Invite a new user -> Tap in search field

Expected Result:
User can see the list of his contacts without interference.
Actual Result:
When adding a new member to the workspace (using search), the user and search box is overlaid with keyboard. And also when scrolling up, the "Invite" button is hidden, which hides users from the list completely.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/218290993-26bdbdb1-dd0d-40aa-9f68-8eac52712cc1.mp4
https://user-images.githubusercontent.com/93399543/218290966-af63fa68-6016-441e-bfab-94cc659e2e80.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0182c8f1bfbd7b65ae
Upwork Job ID:<PHONE_NUMBER>069547520
Last Price Increase: 2023-02-21

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Job added to Upwork: https://www.upwork.com/jobs/~0182c8f1bfbd7b65ae

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

Triggered auto assignment to @thienlnam (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Guessing this can be external.  I did a quick-check to see if this bug might be occurring in other places on the app but wasn't able to find.

Proposal
Please re-state the problem that we are trying to solve in this issue.
The screen is covered by the the personal message view thus the user cannot see the input box where they are typing.
What is the root cause of that problem?
the root cause is using the flex-shrink: 0 styling which is causing the personal message view to move up along with the keyboard.
What changes do you think we should make in order to solve the problem?
We should remove the flex-shrink styling for the personal message view to not bump up along with the keyboard & instead stay in it's position when the search box is focused.

Proposal
When the height of the screen is small and the height of the keyboard is large, the pop-up invitation message input box will cover the above search box
We'd better move this invitation message input box to another new page WorkspaceInviteMessagePage
https://github.com/Expensify/App/blob/e31cb5349e802a0c7386e6d171834344f63322a9/src/pages/workspace/WorkspaceInvitePage.js#L263-L274
inviteUser() {
    ...
    this.setState({shouldDisableButton: true}, () => {
        const logins = _.map(this.state.selectedOptions, option => option.login);
        const filteredLogins = _.uniq(_.compact(_.map(logins, login => login.toLowerCase().trim())));
-       Policy.addMembersToWorkspace(filteredLogins, this.state.welcomeNote || this.getWelcomeNote(), this.props.route.params.policyID);
-       Navigation.goBack();
+       Navigation.navigate(ROUTES.getWorkspaceInviteMessageRoute(this.props.route.params.policyID, filteredLogins))
    });
 }

class WorkspaceInviteMessagePage extends React.Component {

    render() {
        return (
            ...
           <TextInput
		    label={this.props.translate('workspace.invite.personalMessagePrompt')}
		    autoCompleteType="off"
		    autoCorrect={false}
		    numberOfLines={4}
		    textAlignVertical="top"
		    multiline
		    containerStyles={[styles.workspaceInviteWelcome]}
		    value={this.state.welcomeNote}
		    onChangeText={text => this.setState({welcomeNote: text})}
		/>
            ...
        );
    }
}

https://user-images.githubusercontent.com/20135674/218670339-99d570a5-d5fa-4c87-81b5-a33483a64c4c.mp4
Waiting for your suggestions

Looks like something related to react-navigation may have been mentioned in this issue discussion.
As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.
Feel free to drop a note in #expensify-open-source with any questions.

Proposal
Please re-state the problem that we are trying to solve in this issue.
When keyboard is open on the new member invite page, the user list and search box is partially hidden.
What is the root cause of that problem?
We show invite button component, privacy message component, invite message component above the keyboard on user searching the user list. As keyboard takes considerable amount of screen space and other components mentioned above also takes considerable screens space, we are end up with only limited screen space to show the search and list component.
What changes do you think we should make in order to solve the problem?
There are multiple ways to solve this.

We can reduce the number of components we show above keyboard on search. For example we can move the invite message component from the showing above the keyboard by removing the component here and adding it next to the options list selector - https://github.com/priyeshshah11/App/blob/main/src/pages/workspace/WorkspaceInvitePage.js#L337
We don't show any component above the keyboard
we can reduce the sizes of components which we show above the keyboard.

@mallenexpensify  But regardless of any option, we would require answer from design team to let us know what is the expected behaviour and what components to show. I can make the required changes from the design team as well.
Optional:
We can make these changes only for small screen devices by check the screen size. Because for bigger screens we won't have these issues.
What alternative solutions did you explore? (Optional)
None

@mollfpr can you please review the above proposals?

But regardless of any option, we would require answer from design team to let us know what is the expected behaviour and what components to show.

@abdulrahuman5196, correct, thanks for pointing out.  I was able to reproduce but didn't think of how we should show.  I wonder if we should just minimize this area, possibly removing some/most of the text? (sorry, I have a weird issue where Github doesn't allow me to post images)
https://www.screencast.com/t/Qx38wyZu5JPs

Reviewing proposals now!

@priyeshshah11 I try your solution, but it's not working.

@abdulrahuman5196 Could you provide the screenshot for your suggestion before we ask for the design team's opinion?

Thanks @mollfpr, my bad I don't know why it worked for me then but it's not working now.

@priyeshshah11 Could you share the screenshot of the result?

@priyeshshah11 Could you share the screenshot of the result?

@mollfpr Screenshot for above proposal

Sorry @priyeshshah11 on second thought will be helpful if you can record it with focus the search input and focus on the message input 😅

@mollfpr There you go
https://user-images.githubusercontent.com/38547776/219018381-a20f8551-97b6-4472-bfaa-3ca571116100.mov

Thanks @priyeshshah11!

@abdulrahuman5196 Could you provide the screenshot for your suggestion before we ask for the design team's opinion?

@mollfpr  I asked the design team's opinion because there are multiple UI ways to solve this.
But as requested I am providing a sample of my suggestion.
1) Suggestion is to hide the privacy when the search field is focused and reduce paddings on the invite message component. This can free up atleast one row of extra space
https://user-images.githubusercontent.com/46707890/219037813-cdf991bd-a144-45e4-9c0f-7cb4e744c2ac.mov

2) We can reduce the invite message component to show one line alone on the input when Search field is focused. This could provide us with atleast 2 more rows of extra space
https://user-images.githubusercontent.com/46707890/219038879-186a60ea-9897-4e5d-bc1e-813a5a99a983.mov
Note: We can also try variations of the above suggestion to get other desired outputs as well. For example not hiding privacy and reducing invite message component alone to one liner.
Reference video without my change
https://user-images.githubusercontent.com/46707890/219040314-763d2d00-968d-4868-b96a-16a4df02b262.mov

Thanks, @abdulrahuman5196 that helps a lot! I like option 2 better.

@shawnborton We need your help here. The main issue is the input message is covered a lot of space in the options selector and needs more space for the user to scroll through the options while using the search input.
We have several proposals that will enhance the UI/UX.

Creating a new page for only submitting the message when inviting new members to the workspace. Ref https://github.com/Expensify/App/issues/15083#issuecomment-1429264426
Make the message input not overlap when the search input is focused. Ref https://github.com/Expensify/App/issues/15083#issuecomment-1431238247
Hide some of the components/some of the height from the message input when the search input is focused. Ref https://github.com/Expensify/App/issues/15083#issuecomment-1431373699

Also, you can put other preferred expected results about the issue. Thanks!

Started a discussion here

Thanks for raising Shawn.  Is sounds like @priyeshshah11 recommendation here is the consensus winner. Do you and @thienlnam and @mollfpr agree?
https://user-images.githubusercontent.com/22508304/219520833-69697a53-7b49-4c67-a58a-44761ca01c8e.mov

I am concerned about @priyeshshah11's proposal result. The keyboard is not closed after selecting the option on the workspace invite page. We need to blur the search input to show the message input. On mWeb/Safari we can use the Done button on the keyboard, but on iOS, there's no Done button. The other way to blur the search input is, to scroll the options selector.

I am concerned about @priyeshshah11's proposal result. The keyboard is not closed after selecting the option on the workspace invite page. We need to blur the search input to show the message input. On mWeb/Safari we can use the Done button on the keyboard, but on iOS, there's no Done button. The other way to blur the search input is, to scroll the options selector.

@mollfpr Touching outside the view does close the keyboard & also pressing return in the keyboard does the same thing but yes we can blur the input on the options being selected during the PR.

but yes we can blur the input on the options being selected during the PR if needed.

Actually, now I think we don't really need to do this as scrolling in the list & pressing return does dismiss the keyboard.

Still waiting for clarity on Slack...

@thienlnam @mollfpr what do you two propose we do next to keep this moving along?

@mallenexpensify We have confirmation https://expensify.slack.com/archives/C01GTK53T8Q/p1677081968232459?thread_ts=1676566457.352139&channel=C01GTK53T8Q&message_ts=1677081968.232459
@thienlnam @mallenexpensify Do we agree with the new expected?

@mollfpr I would like to volunteer to implement the new screens/flow if possible please.

@priyeshshah11 We have the proposal from @hellohublot with the push page solution, but the proposal is not following our template.
@mallenexpensify How do we act about the proposal not following our template? I should have caught that earlier, sorry.

Yes, the new expected behavior makes sense to me - we're adding a new screen to the invite page.

How do we act about the proposal not following our template? I should have caught that earlier, sorry.

Please instruct contributors towards our template and have them re-submit their proposal in accordance with our guidelines
However, since we changed the solution for the job - let's take new proposals for how to implement the new flow outlined here

Proposal
Please re-state the problem that we are trying to solve in this issue.
We want to update the invite members experience by creating a new page to input the optional message after user selects the members from the invite page list.
What is the root cause of that problem?
In existing flow - When adding a new member to the workspace (using search), the user and search box is overlaid with keyboard. And also when scrolling up, the "Invite" button is hidden, which hides users from the list completely.
What changes do you think we should make in order to solve the problem?

For this solution we already have all the UI components and should be a straight-forward implementation.

Changes in the existing invite page

Remove the optional message component and privacy link component
Update "Invite" button to "Next" which will route to new message input page.
"Next" button to be disabled when no users are selected

New message input page

Add Multiple avatar components to show the invited members icons as mentioned in the copy
Show the optional message component and privacy link component.
Initiate the invite API when user presses invite button.

What alternative solutions did you explore? (Optional)
N/A

@abdulrahuman5196 Your proposal have the right way to start. We can use Form.js to handle this and have the draft values safe in Onyx, like what we did for the ACH forms.
cc @thienlnam

@abdulrahuman5196 Your proposal have the right way to start. We can use Form.js to handle this and have the draft values safe in Onyx, like what we did for the ACH forms.
cc @thienlnam

@mollfpr  Yes. Agree. Kindly let me know if any more information is required from my end.
Note: Leaving out very level low details from proposal as code diff in proposal is not encouraged now.

@thienlnam What do you think about us using Form.js for the invite page?

Yeah that makes sense to me, the form component should be used for cases like this so 👍

We have the https://github.com/Expensify/App/issues/15083#issuecomment-1429264426 from @hellohublot with the push page solution, but the proposal is not following our template.

I think our template might have been updated since Feb 11.  @hellohublot, based on your previous proposal, would you like to submit a new one following the new template?  I'd like to wait for your reply before hiring another.

Proposal
Please re-state the problem that we are trying to solve in this issue.
When adding a new member to the workspace (using search), the user and search box is overlaid with keyboard. And also when scrolling up, the "Invite" button is hidden, which hides users from the list completely.
What is the root cause of that problem?
When the height of the screen is small and the height of the keyboard is large, then the user click the search box, the pop-up invitation message input box will cover the above search box
What changes do you think we should make in order to solve the problem?

https://user-images.githubusercontent.com/20135674/218670339-99d570a5-d5fa-4c87-81b5-a33483a64c4c.mp4

Thanks, We'd better move the multi-line input box to another new page WorkspaceInviteMessagePage, and use user_id_list to pass the parameters between pages. Not only to adding FullPageNotFoundView + HeaderWithCloseButton + FormSubmit + FormAlertWithSubmitButton, but I will strictly follow to https://github.com/Expensify/App/blob/2df7f866e4f7747714af991930d02176d9234405/src/pages/settings/Security/CloseAccountPage.js and https://github.com/Expensify/App/blob/2df7f866e4f7747714af991930d02176d9234405/src/pages/workspace/WorkspaceInvitePage.js to complete the combination
I can't put git diff directly, but this new page will definitely can't be code reviewed in 3 days, so I want to get your approval, to submit a proposal with full git diff, and then submit the same PR
What alternative solutions did you explore? (Optional)

If there is design support, in addition to the screenshot of my video, we can display the people we will invite in a small area of another page

We can reuse this page into a global page MultilineInputPage. If there is a need to enter long text in the future, we can directly reuse it

📣 @hellohublot! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01509ca2c74bfc7073

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@hellohublot We will have the page according to the design, and I like to have the page built with our Form component where we can use the draft values if the user still needs to finish the process.
@mallenexpensify @thienlnam I'll leave it to you to decide who we gonna pick.

@abdulrahuman5196 Was the first proposal regarding the new UI changes from the discussion, so going to move forward with that - please also use Form.js for the invite page

📣 @abdulrahuman5196 You have been assigned to this job by @thienlnam!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

Sorry for having you resubmit your proposal @hellohublot, it seems we had a misunderstanding on our end regarding the change in solution.  You did provide a solid solution in the correct format on your second proposal, so we'd love to see you help out on other issues

Echoing @thienlnam , sorry @hellohublot for asking you to resubmit when we were looking for a different solution.  My intent was to move the issue along and to be fair since you originally proposed a solution.

@mallenexpensify @mollfpr @thienlnam @abdulrahuman5196 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Not sure why Melvin was triggered. Working on the PR.

FYI: It seems MultipleAvatar component is not honering LARGE icons even though its props is mentioning its supported and doesn't seems to have different size support fully integrated like Avatar component.
I will add the required support to MultipleAvatar component as well to support all sizes the current Avatar supports. We would have to make sure current MultipleAvatar flows works as expected along with this change.
Reference:
https://github.com/Expensify/App/blob/main/src/components/MultipleAvatars.js#L56-L64
https://github.com/Expensify/App/blob/main/src/components/Avatar.js#L71-L82
Are we fine? Wanted to confirm as it would take some more time to fix MultipleAvatar component as well and it was not included in original proposal (will try to be fast but would be very close call to finish in 3 day bonus timeframe) .
@thienlnam  @mollfpr

Thanks @abdulrahuman5196. No problem for me! cc @thienlnam

Just posting as update on working status:
I have almost done with action items expect for MultipleAvatar component.
It seems MultipleAvatar component has lots of hardcoded styles to support only small and default avatar sizes.
https://github.com/Expensify/App/blob/06f75ab3cdc7c4d4b2184753d5cb3502d478d98e/src/components/MultipleAvatars.js#L56-L64
It won't be effective to add large icon as an another check to just support our current requirement. So I am working on making it generic to support all avatar sizes which is like re-writing the component. Will provide a PR once the changes are done.

Not Overdue

Being worked on PR Melvin

Update on the implementation
Completed with generic implementation on MultipleAvatars component when they stack horizontally.
Only Minor finishes alone are pending to complete all the requirements. Created a draft PR if anyone wants a quick peek at current code status (Might not be tidy though, need some brushing).

Nice, good idea to reuse that component.

Created a PR for the changes - https://github.com/Expensify/App/pull/15672
@mollfpr  @thienlnam
One action item of translated text is alone pending. Who is required to give the translated strings?
We need translated strings for the below
            inviteMessageTitle: 'Add message',
            inviteMessagePrompt: 'Make your invitation extra special by adding a message below',
            personalMessagePrompt: 'Message',

I will get those translations for you

Thank you for the translations.
I have updated the PR, kindly review and let me know on any changes required - @thienlnam @mollfpr

@mallenexpensify, @mollfpr, @thienlnam, @abdulrahuman5196 Eep! 4 days overdue now. Issues have feelings too...

PR is still in review.

@mallenexpensify, @mollfpr, @thienlnam, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

PR is in final review phase should be closed out in couple of days.

@mallenexpensify, @mollfpr, @thienlnam, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

PR is still in review

@mallenexpensify, @mollfpr, @thienlnam, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

We're getting very close with the review https://github.com/Expensify/App/pull/15672

@mallenexpensify, @mollfpr, @thienlnam, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

Possible merge conflict with PR, being worked on https://github.com/Expensify/App/pull/15672#issuecomment-1528755205

Not overdue. PR is pushed and in staging. Waiting for prod deployment, assuming it should happen sooner, since it has been couple of days in prod.

Hi team, I think it would be fair to re-evaluate the compensation for this feature request issue. Since we had to do more stretch to get this feature request into going. On high level, This involved refractor of MultipleAvatars component from hard coded values to generic implementation which made the component much scalable for future usecases, minor refractors on Form component as well, and the creation of new page itself and further polishes and followups which took month's effort to get the feature rolling.
cc: @mallenexpensify @mollfpr @thienlnam @luacmartins
PR reference - https://github.com/Expensify/App/pull/15672

@abdulrahuman5196 what amount do you think is fair?

@luacmartins Hi, I am fine with any amount increase team thinks its fair for this. I don't have any specific request.

[@mollfpr / @abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr / @abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr / @abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Since this isn't an issue rather than a feature request and improvement, no offending PR and checklist should be added.

[@mollfpr / @abdulrahuman5196] Determine if we should create a regression test for this bug.

We should update the current test case for invite members. I'll propose the regression step.

Update for Manage Members - Invite TC

Navigate back to Workspace editor
Click on Manage Members
Verify your account is the only one in the list
Verify there are 2 buttons to invite or remove members
Verify the remove button is disabled if no members are selected
Verify there’s a checkbox to Select all
Click on the Next button
Verify that a search is displayed
Search for a user that you have access to and has an avatar set up
Select the user
Verify a green tick is displayed on the right side
Verify the search is cleared after selecting the user
Verify that bottom docked there is a text box with a invite message you can edit
Click on the Next button
Remove the default message from the text box
Click on the Invite button
Verify that the new Workspace member is displayed on the members list
Verify the that the user avatar loads for the new member in the member list
Verify that an email invite is received in the secondary user email inbox
Verify that the email invite doesn't include the invite message since it was deleted
Invite several more members include at least 1 account you have access to, the rest can be made up emails
Include this message in the invite text box "Testing the invite message & more"
Verify that it displays the selected member avatars
Reload the page
Verify that the members selected before remains the same and the input message is back to default
Click on the Invite button
Verify that the email invite includes the invite message and that is correctly rendered

I also think we need to update Manage Members - Invite - Error test (Online/Offline) TC too, but I haven't got the time to add it.

Hi team, When you are available, could you kindly check on this request?
https://github.com/Expensify/App/issues/15083#issuecomment-1547708809
https://github.com/Expensify/App/issues/15083#issuecomment-1548011910
cc: @mallenexpensify

refractor of MultipleAvatars component from hard coded values to generic implementation which made the component much scalable for future usecases, minor refractors on Form component as well, and the creation of new page itself and further polishes

Apologies for the delay @abdulrahuman5196.  I'm not the most well-versed on the technical details. it's often best/easiest when you propose the amount then we can 👍, 👎 or propose another amount.  The expected behavior was

User can see the list of his contacts without interference.

It sounds like the amount of work that went into achieving that behavior required a lot more work than just a single bug fix.  Based on the $2000 job amount, what percentage of additional work, outside of the single bug fix, do you think was necessary to get the PR deployed to production?  Generally we default to 25, 50 and 100% when considering payment amounts.

Thank you for response @mallenexpensify. I think 50% or 100% should be good(Since time bonus is also not possible on this fix).
🎉  for 100%
👍  for 50% (this is equal to time bonus)
👎  for current compensation (no change)
@luacmartins @thienlnam @mollfpr

@mallenexpensify I think that a 50% bonus seems fair in this case.

@mallenexpensify  As the team is agreeing on 50% bonus as a fair update in this case.
I am fine with the team's decision as well. Kindly do the needful.
cc: @luacmartins

Thanks all. @abdulrahuman5196 @mollfpr , can you please accept the job and reply here once you have?  https://www.upwork.com/jobs/~01478651038f1ade96
Reminder to add the $1000, 50% when paying :)

@mallenexpensify Accepted, thank you!

@mallenexpensify accepted the invite.

Paid @mollfpr and @abdulrahuman5196 , thanks!
TC GH created!
https://github.com/Expensify/Expensify/issues/286287


Update README.md

Update README to include instruction to increase vm.max_map_count

Hi @rogierm,
The instruction you mentioned is actually commented on the 5th bullet of the docker-compose instructions, maybe we should change that to make it more clear?
Cheers

We should create a wiki and build links in the README

Hi @austin-taylor,
That would be a good idea, although the only issue is that Wiki can't be contributed through PR, and I guess it would impact as well the current VulnWhisperer web page, as for now is being build from the README; definitely something to check :)
BR

Hi Quim, the page looks very clear to me now! I'm sure I wouldn't miss it again :). Thanks!

Thank you! :)


feat: add cliff-jumper to record consistent changelog

📑 Summary
This pull request is related to a feature request and has no association with the source codebase, just add a highly customizable(and customized) Changelog generator commonly called cliff-jumper.
You can see CHANGELOG.md file follows Conventional Commit specifications.
🔗 Related issues
No context

To me yesterday, there seems to be no problem even if I check it again after I woke up. It looks good to me! Bump 🎉


Not sure how to proceed with HttpBasicAuthenticator

When using postman, the api I need to tap is listed as using basic authentication. I see references to HttpBasicAuthenticator here at vba-web, but I have no idea how to tap it.
I'm using Access, so in order to get the elements of vba-web into my accdb database, I import all of the modules in src other than WebAsyncWrapper.cls. The only cls in there looks to be related to authentications is IWebAuthenticator.cls.
This compiles:
Dim Auth As New IWebAuthenticator
This does not:
Dim Auth As New HttpBasicAuthenticator
As I understand it from the docs, IWebAuthenticator is to be used for implementing a custom authenticator. All that I've seen makes me think that HttpBasicAuthenticator is an out of the box authenticator. But then how do I use it?
Refs:
https://github.com/VBA-tools/VBA-Web/wiki/Authentication
https://github.com/VBA-tools/VBA-Web/wiki/Implementing-your-own-IWebAuthenticator
That second link has this phrase: If the built-in authenticators don't meet your needs, you can create your own.
There don't seem to be any built in authenticators?

Got it...by digging around in the xlsm installer file, found the authenticators dir and the cls files for the built-in authenticators.

Could be maybe mentioned in the documentation.
Unfortunately the Installer can not run on my work PC because of some group policy so an alternative way how to get the BasicAuthenticator would be nice.


What is the maximum duration time of vibration in ios

Description
I am making an exercise app, and I have the haptic activated when the round starts, the problem is that a round lasts 50 seconds, if it passes 25 seconds it stops vibrating, this only happens on iOS, I would like to know if there is a restriction in the library about the maximum haptic time, this problem in android does not happen.
My example code

const options = {
enableVibrateFallback: false,
ignoreAndroidSystemSettings: true
};
const interval = useRef(null);
const hapticLight = () => {
trigger("impactLight", options)
}
useEffect(() => {
interval.current = setInterval(() => {
hapticLight()
},  100);
return () => clearInterval(interval.current);
}, []);

Package version
"react": "17.0.2",
"react-native": "0.66.5",
"react-native-haptic-feedback": "^2.0.0",
Example visual

I have the same issue, is there any limitation, or property that needs to be set?

A bit of a hack, but I had a similar issue and switched the trigger method to notificationSuccess and no longer had the issue. It felt similar enough for our use case.

I resolved this with the following patch, hope it's of use.
react-native-haptic-feedback+2.2.0.patch
diff --git a/node_modules/react-native-haptic-feedback/ios/RNHapticFeedback/RNHapticFeedback.mm b/node_modules/react-native-haptic-feedback/ios/RNHapticFeedback/RNHapticFeedback.mm
index cf75baf..1ca2da3 100644
--- a/node_modules/react-native-haptic-feedback/ios/RNHapticFeedback/RNHapticFeedback.mm
+++ b/node_modules/react-native-haptic-feedback/ios/RNHapticFeedback/RNHapticFeedback.mm
@@ -100,11 +100,10 @@ RCT_EXPORT_METHOD(trigger:(NSString *)type options:(NSDictionary *)options)
         impactGeneratorMap = [[NSMutableDictionary alloc] init];
     if ([impactGeneratorMap objectForKey:key] == nil){
         [impactGeneratorMap setValue:[[UIImpactFeedbackGenerator alloc] initWithStyle:style] forKey:key];
-        [[impactGeneratorMap objectForKey:key] prepare];
     }
-    UIImpactFeedbackGenerator *generator = [impactGeneratorMap objectForKey:key];
-    [generator impactOccurred];
-    [generator prepare];
+    [[impactGeneratorMap objectForKey:key] prepare];
+    [[impactGeneratorMap objectForKey:key] performSelector:@selector(impactOccurred) withObject: nil afterDelay:0.0f];
+    [[impactGeneratorMap objectForKey:key] prepare];
 }

 -(void)generateNotificationFeedback:(UINotificationFeedbackType)notificationType{

Is this related to a limitation of iOS regarding the haptics? Would be glad to have a reference, but couldn´t find anything. The diff is only triggering the prepare again, or am i missing something @jpitkanen17

Is this related to a limitation of iOS regarding the haptics? Would be glad to have a reference, but couldn´t find anything. The diff is only triggering the prepare again, or am i missing something @jpitkanen17

@mkuczera The extra prepare call might be redundant and something I tried before figuring the real solution out.
The actual solution is this call
 [[impactGeneratorMap objectForKey:key] performSelector:@selector(impactOccurred) withObject: nil afterDelay:0.0f];
The key difference is the delay 0.0f which overrides the previous haptics call. I tested this with a slider that would stop vibrating on every click after a while and this fixed it. The only "bug" is that sometimes the you can feel the vibration being cancelled.


A question about  neuronbot2 SDF file in myself gezebo world

English is not my native language,sorry for any spelling mistakes.
The following is my development environment：
．Ubuntu 18.04
．ROS Melodic Morenia
．Gazebo 9
．neuronbot2 melodic-devel branches
I try to put the neuronbot2 SDF file in Gazebo world I created, but when I run the world roslaunch file I get the error:
[ WARN] [1612512193.870927121, 0.102000000]: missing <topicName>, set to /namespace/default: ///imu_data
[FATAL] [1612512193.870970057, 0.102000000]: missing <frameName>, cannot proceed
 [FATAL] [1612512193.870993188, 0.102000000]: Error Loading Parameters!
[ INFO] [1612512193.945489233, 0.102000000]: Starting plugin DiffDrive(ns = //)
[ WARN] [1612512193.945560189, 0.102000000]: DiffDrive(ns = //): missing <rosDebugLevel> default is na
[ INFO] [1612512193.946622894, 0.102000000]: DiffDrive(ns = //): <tf_prefix> =
[ WARN] [1612512193.946689266, 0.102000000]: DiffDrive(ns = //): missing <commandTopic> default is cmd_vel etc...
And I run rostopic list , I only get  /tf /tf_static and gazebo topic
How can I use keyboard_control and gmapping?

It's OK to speak Chinese here.
How do you include NeuronBot SDF into your Gazebo world?
What's your launch file? Do you understand how we include those launch files in neuronbot2_world.launch?

你好
這是我所建立ROS的Package：https://github.com/SilasYoome/Gazebo_world_test_neuronbot2.git
gazebo_world.launch為主要啟動的launch檔，啟動後會放入我自創的世界cat.world之中
在工作空間頁面roslaunch world_bringup gazebot_world.launch會出現上面所說的錯誤訊息
在將 NeuronBot SDF檔案中<link name="imu_link">,
<plugin name='differential_drive_controller' filename='libgazebo_ros_diff_drive.so'>,
<plugin name='neuronbot2_joint_state_right_wheel' filename='libgazebo_ros_joint_state_publisher.so'>
<plugin name='neuronbot2_joint_state_lefft_wheel' filename='libgazebo_ros_joint_state_publisher.so'>
旗下的程式碼註解掉後錯誤訊息會消失
初步推論應該是gazebot插件造成的問題，或是可能與NeuronBot2中ROS的節點有關？

在測試過您的Package後，我們的設備無法重現您的錯誤，麻煩確認是否安裝gazebo所需要的Package，如gazebo-plugins。
另外，建議配合neuronbot2_description並在launch file中開啟robot_state_publisher，否則neuronbot2中各joint的tf不會被publish。


failed to cleanup volume on terminating pod

Describe the bug
When terminating a pod with a volume created by TopoLVM, the volume is not cleaned up properly.
Probbably this problem happens because of using Kubernetes v1.19. Although TopoLVM doesn't support k8s v1.19 yet, it'll be done with the following issue.
https://github.com/topolvm/topolvm/issues/218
So let's investigate this problem with #218 .
slack discussion:
https://topolvm.slack.com/archives/CSXMYS3L2/p1606896433053000
Here is the detail (c-p from slack).
The kubelet log of terminating pod.
I1202 16:04:14.786783  476958 kubelet_pods.go:939] Pod "topolvm-test-2-es-default-2_uat-es(47251506-0d40-41ac-a60f-4c6a0e1596c4)" is terminated, but some volumes have not been cleaned up

topolvm-node received delete request from kubelet properly.
topolvm-node's log.
{"level":"info","ts":1606897350.6796362,"logger":"driver.node","msg":"NodeUnpublishVolume called","volume_id":"d87cc6a0-43f1-4970-86ba-8aa2aa8f010e","target_path":"/var/lib/k8s/kubelet/pods/4331c1d5-13e0-4ce1-8071-ff7fd8a51e4e/volumes/kubernetes.io~csi/pvc-4db743eb-53d8-4ab3-93ad-839e269732cc/mount"}
{"level":"info","ts":1606897385.0484025,"logger":"driver.identity","msg":"Probe","req":""}
{"level":"info","ts":1606897398.4616272,"logger":"driver.node","msg":"NodeGetVolumeStats is called","volume_id":"d87cc6a0-43f1-4970-86ba-8aa2aa8f010e","volume_path":"/var/lib/k8s/kubelet/pods/4331c1d5-13e0-4ce1-8071-ff7fd8a51e4e/volumes/kubernetes.io~csi/pvc-4db743eb-53d8-4ab3-93ad-839e269732cc/mount"}

However, the termination of PVC, that is corresponding to the volume, was blocked because there is a finalizer "kubernetes.io/pvc-protection".
Name:          elasticsearch-data-topolvm-test-es-default-1
Namespace:     uat-es
StorageClass:  topolvm-provisioner
Status:        Terminating (lasts 50m)
Volume:        pvc-4db743eb-53d8-4ab3-93ad-839e269732cc
Labels:        common.k8s.elastic.co/type=elasticsearch
               elasticsearch.k8s.elastic.co/cluster-name=topolvm-test
               elasticsearch.k8s.elastic.co/statefulset-name=topolvm-test-es-default
Annotations:   pv.kubernetes.io/bind-completed: yes
               pv.kubernetes.io/bound-by-controller: yes
               volume.beta.kubernetes.io/storage-provisioner: topolvm.cybozu.com
               volume.kubernetes.io/selected-node: svr6781hp360
Finalizers:    [kubernetes.io/pvc-protection]
Capacity:      2Gi
Access Modes:  RWO
VolumeMode:    Filesystem
Mounted By:    topolvm-test-es-default-1
Events:        <none>

It means that there is a problem in terminating pod.
In addition, there is a error in lvmd, that is issued by kubelet.
I1202 16:10:04.786722  476958 kubelet.go:1993] SyncLoop (housekeeping)
I1202 16:10:04.786922  476958 kubelet_pods.go:939] Pod "topolvm-test-es-default-1_uat-es(4331c1d5-13e0-4ce1-8071-ff7fd8a51e4e)" is terminated, but some volumes have not been cleaned up
I1202 16:10:04.787046  476958 kubelet_pods.go:939] Pod "topolvm-test-2-es-default-2_uat-es(47251506-0d40-41ac-a60f-4c6a0e1596c4)" is terminated, but some volumes have not been cleaned up
E1202 16:10:04.802338  476958 kubelet_volumes.go:154] orphaned pod "ab8d3ba5-e202-48f1-bf07-b4c2a48c99f3" found, but volume paths are still present on disk : There were a total of 1 errors similar to this. Turn up verbosity to see them.
I1202 16:10:04.802357  476958 kubelet_pods.go:1720] Orphaned pod "4331c1d5-13e0-4ce1-8071-ff7fd8a51e4e" found, but volumes not yet removed.  Reducing cpu to minimum
I1202 16:10:04.802486  476958 kubelet_pods.go:1720] Orphaned pod "47251506-0d40-41ac-a60f-4c6a0e1596c4" found, but volumes not yet removed.  Reducing cpu to minimum

Environments

Version: v0.6.0
Kubernetes version: v1.19

To Reproduce
Not sure.
Expected behavior
Suceeded to remove Pod, PVC, PV, and LV properly.
Additional context
After restarting kubelet, all pod, pvc, and LV were deleted as expected.

This was caused by a misconfiguration of mountPath and hostPath and not a TopoLVM bug.
Therefore, we would like to close this issue.


Enhancement/luiseV/linkgcs

Gives the user who requests the score export OWNER access to the cloud storage score file.

Tests are failing because of AssertionError: No api proxy found for service "memcache"

I can look at it tomorrow (Europe time :) )

For future reference in case we do need the tests to pass:
The tests pass when the stubs are registered utils.py
from google.appengine.api import apiproxy_stub_map
from google.appengine.api.memcache import memcache_stub
from google.appengine.api.app_identity import app_identity_stub
apiproxy_stub_map.apiproxy.RegisterStub('memcache', memcache_stub.MemcacheServiceStub())
apiproxy_stub_map.apiproxy.RegisterStub('app_identity_service', app_identity_stub.AppIdentityServiceStub())

A hack would be to do something like if os.env(flask_conf) == "test": .... (though there's almost certainly a better fix)

Closing due to v3 being the master branch now.
Someday we'll figure out how to make the test suite pass with this code...


Support of SHIFT key for mutilple select

AS of now ztree only supports multiple selection utilizing the Ctrl key. I wonder how difficult it would be to allow selections based on SHIFT key too?

If you load data of nodes with the async, which nodes will be selected when you press the 'shift' key?  This is the key about your quesion.

I am loading the tree in sync mode, but the topic is AFTER the tree has loaded and is displayed, you can use the CTRL key to select multiple nodes. On modern OS it is also possible to use the SHIFT key to select intervals of nodes. But this seems to be not supported in zTree....
example:
Node1
Node2 (child of 1)
Node3
Node4
Node5
First I select Node1, then i press SHIFT and keep it pressed while clicking on Node4.
Expected result: Nodes1 to 4 are now selected
Actual Result: Only Node4 gets selected

I understand it in sync mode.
But I'm worried about what should I do in async mode. This is why I don't support SHIFT key.
I'm very confused about it.

I see what you mean, well basically I would expect the tree either

to remember the two "end points" of the SHIFT selection and add every new node received in async mode to the selection if it is "IN"
or 2) ignore the SHIFT selection for newly received nodes completely.
I assume BOTH is fine from UI perspective. It just needs to be clearly communicated and consistent. From that I would propose 1)

This code can support SHIFT.
Bug this code can't support with async mode.
You can refer it.
<!DOCTYPE html>

  <TITLE></TITLE>
  <meta http-equiv="content-type" content="text/html; charset=UTF-8">
  <link rel="stylesheet" href="../../../css/demo.css" type="text/css">
  <link rel="stylesheet" href="../../../css/zTreeStyle/zTreeStyle.css" type="text/css">

[ core/click.html ]

Cool stuff, adapted and added it to my code. SMall issue is with selecting nodes of different levels. The behaviour for draging such multiple selections is difficult to describe but it doesnt seem to be consistent. Sometimes only a single node is then dragged, sometimes......
I will have to find some time and analyse this in depth.
For now BIG Thanx for the code snippet

sorry, zTree can't support this.
example:
A --> A1/ A2/ B3
B --> B1/ B2/ B3
A1 --> A11 / A12 / A13
If you select A/A2/A1/A12, and you drag these nodes to B3's children.  So how will I do with A11 / A13 ??
there are some difficult to do, because this plugin will support so many ideas for every one, so zTree can't support drag the nodes which have different parentNode.

Thanks for the code snippet. I have a very simple, flat tree and being able to SHIFT+select is wonderful. My next challenge is to try to replicate multi-select on mobile (where there are no SHIFT or CTRL buttons).

@dearsina
you can use beforeCheck and selectNode() method .


Feature Request: variable panel widths

Apparently the lib itself doesn't have the corresponding method, I've tried to set it programatically using LayoutParams but I keep getting an error message that says "HEIGHT should always be MATCH_PARENT) but this is the code im trying .
slidingUpPanel.setLayoutParams(new LayoutParams(x, LayoutParams.MATCH_PARENT))
please advice how to do this

Is there any solution for create a 50-50% height both elements?

I have a similar problem while using the panel with a ViewPager. I have asked the question here. Can someone please help ?

Closing this. For different sizes of the panel, just use a different parent layout.


[SIL Diagnostics] Improve diagnostics for capture of inout values in escaping autoclosures.

Currently, when an inout or mutating self is passed to an escaping, autoclosured parameter, the error message looks as follows:
foo(x)
  error: escaping closure captures 'inout' parameter 'x'
  note: captured here

The error message refers to a closure even though there is no closure is in the source code. This PR improves the error message and makes the note more actionable for autoclosures:
foo(x)
  error: escaping autoclosure captures 'inout' parameter 'x'
  note: pass a copy of 'x'

rdar://problem/60551844

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - a2d38f608f0126c529459a5b2a7d04f588944d00

@swift-ci Please smoke test Linux Platform


Use production level new style syntax

from jsonclasses import jsonclass
from jsonclasses_pymongo import pymongo

@pymongo
@jsonclass
class Article:
    title: str
    content: str

This is implemented in version 2


Stating figure as a multiple (e.g. "#.#X")?

Hi!  I'm using a data viz tool that allows me to specify a custom number format using d3-format.  For my dashboard, I have a table currently that has a column specifying an entity (let's say students for this example) and another column that specifies a number (lets say test score).
For the test scores column, I am stating the scores as figures relative to the average test score.
For example, let's say the average test score was 70, Student A got a 90, Student B got a 50 and Student C got an 70  Dashboard would populate as follows:

Student
Relative Test Score

Student A
1.3

Student B
1.0

Student C
0.6

For the figures in the Relative Test Score column, I would like to add an "x" character in the end to denote that the figure is a multiple.  Something like this.

Student
Relative Test Score

Student A
1.3x

Student B
1.0x

Student C
0.6x

Is it possible for me to do this?

Try this:
const formatNumber = d3.format(".1f");

function formatMultiple(x) {
  return `${formatNumber(x)}×`;
}


BadResultException not in exceptions.py

Hey, I just got a little confused when try: catch'ing a BadResultException. I was expecting to find it in exceptions.py, but it's in query.py. Am I being a tool and there's actually a good reason? :)
See here: https://github.com/jeffjenkins/MongoAlchemy/blob/master/mongoalchemy/query.py#L35
Cheers,
Ben

this was released earlier this year. closing


Implement "usage" tutorial as screencast video

Define the "usage" section from the readme as a tutorial for  https://github.com/veracioux/tuterm .
then record it with asciinema as explained in tuterm
compile the .cast in an animated svg with  svg-term-cli  https://asciinema.org/a/377532
Then we could embed it in the readme like

alternatively, check https://martinheinz.dev/blog/94


warcli wrapping kubectl

What commands do we want to wrap from kubectl ?

[ ] logs?
[ ] port forwarding to individual tanks
[ ] port forwarding to lightning nodes

Useful to know network status:

are the tanks running?
logging is good to go
run a scenario

We lifted logs into warcli here  35fc9ed8cf12c78bd724ee2cacfab98c05167c8a

We also now have warnet status which gives info about the network and running scenarios in the same command.


[eas-cli] Bump dependencies

Why
Routine task but also because we need to use a new feature
How
Bump versions
Test Plan
Let CI run

/changelog-entry chore Bump Expo package dependencies


Adds a delete confirmation dialog

This PR adds a confirmation dialog before removing a slide.
Fixes #1754

@viddo: can you review this, please?

Frontend tests were OK :+1: (details)

Looks straight forward, so :+1:
I suppose there is some basic test there already?
Btw, thanks for notifying, I'll add it to the list of modals to keep in mind when implementing the news ones. This is for odyssey, right?

Frontend tests were OK :+1: (details)

Yes, this is just for odyssey.
There are tests for the slide model and panel, but I didn't add it for this particular feature.


NPE in InterfaceTypeImpl.isDirectSupertypeOf

Analyzer Feedback from IntelliJ
Version information

IDEA AI-181.55<IP_ADDRESS>56338
2.1.0-edge.a2eb050044eec93f0844667b8b6132e858467e4e
AI-181.55<IP_ADDRESS>56338, JRE 1.8.0_152-release-1136-b06x64 JetBrains s.r.o, OS Mac OS X(x86_64) v10.13.6 unknown, screens 1344x840, 1280x800

Exception
Please append the contents of:
file:///private/var/folders/pd/5nkbdv0909n1vw71tt31yy900000gn/T/report1.txt
Dart analysis server, SDK version 2.1.0-edge.a2eb050044eec93f0844667b8b6132e858467e4e, server version 1.20.5, error: Failed to handle completion domain request: {id: 19070, method: completion.getSuggestions, params: {file: /Users/ianw/my/code/flutter/flowcharter/lib/function_picker_page2.dart, offset: 6888}, clientRequestTime:<PHONE_NUMBER>940}
NoSuchMethodError: The method 'substitute2' was called on null.
Receiver: null
Tried calling: substitute2(_List len:1, _List len:1)
#0      Object.noSuchMethod (dart:core/runtime/libobject_patch.dart:50:5)
#1      InterfaceTypeImpl.isDirectSupertypeOf (package:analyzer/src/dart/element/type.dart:1508:27)
#2      InterfaceTypeImpl.isMoreSpecificThan (package:analyzer/src/dart/element/type.dart:1591:16)
#3      TypeImpl.isSubtypeOf (package:analyzer/src/dart/element/type.dart:2583:12)
#4      OpType._computeRequiredTypeAndFilters.<anonymous closure> (package:analyzer_plugin/src/utilities/completion/optype.dart:217:29)
#5      LibraryElementSuggestionBuilder.visitClassElement (package:analysis_server/src/services/completion/dart/local_library_contributor.dart:58:30)
#6      AbstractClassElementImpl.accept (package:analyzer/src/dart/element/element.dart:126:53)
#7      ImportedReferenceContributor._buildSuggestions (package:analysis_server/src/services/completion/dart/imported_reference_contributor.dart:84:12)

Thanks for reporting this issue! This was previously reported at https://github.com/dart-lang/sdk/issues/34563; please follow along there.

Duplicate of https://github.com/dart-lang/sdk/issues/34563


HDDS-5723. Increase time limit of Ozone acceptance tests.

What changes were proposed in this pull request?
Increase acceptance test timeout from 120 minutes to 150 minutes, since new upgrade/downgrade acceptance tests sometimes push the acceptance test run time over 2 hours.
What is the link to the Apache JIRA
HDDS-5723
How was this patch tested?

Existing acceptance test run.

I had initially moved the TODO comment since it corresponded to integration tests, not acceptance tests. I will remove it instead. HDDS-5270 has been resolved as a duplicate and we can track speeding up acceptance tests in HDDS-5730.

@errose28 Can you confirm if the test failure is unrelated?

Test failure is unrelated. Looks like CI failed to start a mini ozone cluster.
From org.apache.hadoop.ozone.scm.TestSCMInstallSnapshotWithHA.txt in the log bundle, the timeout happened here:
	at org.apache.ozone.test.GenericTestUtils.waitFor(GenericTestUtils.java:225)
	at org.apache.hadoop.ozone.MiniOzoneClusterImpl.waitForClusterToBeReady(MiniOzoneClusterImpl.java:228)
	at org.apache.hadoop.ozone.scm.TestSCMInstallSnapshotWithHA.init(TestSCMInstallSnapshotWithHA.java:104)

Logs show the cause of the timeout was a networking issue:
Caused by: java.net.ConnectException: Connection refused

Test failure is not related to PR. Going a head with commit, as failed test is totally unrelated to this. In this way we can save one CI run resources

Thank You @errose28 for the fix and everyone for the review


'Dot' not found

Hi,
I recently downloaded the toolkit, using pip install onto_tool, and I have run into an error when dunning it:
FileNotFoundError: [WinError 2] "dot" not found in path.
I have checked 'where dot' and windows tells me that no path was found. I tried checking to make sure graphviz was installed, and I ran 'pip install graphviz' but it said I had already done so. I also tried installing pipdot, and that was also already installed.
Maybe this is a problem I'm having on my local machine, maybe its a problem with pathing, but I haven't been able to troubleshoot it elsewhere.
Thank you for your help!

Hi Cameron
You need to install Graphviz from https://graphviz.org/ and ensure that the
dot.exe file is in your path.
Hope this helps
Peter
On Tue, 22 Aug 2023, 13:38 Cameron More, @.***> wrote:

Hi,
I recently downloaded the toolkit, using pip install onto_tool, and I have
run into an error when dunning it:
FileNotFoundError: [WinError 2] "dot" not found in path.
I have checked 'where dot' and windows tells me that no path was found. I
tried checking to make sure graphviz was installed, and I ran 'pip install
graphviz' but it said I had already done so. I also tried installing
pipdot, and that was also already installed.
Maybe this is a problem I'm having on my local machine, maybe its a
problem with pathing, but I haven't been able to troubleshoot it elsewhere.
Thank you for your help!
—
Reply to this email directly, view it on GitHub
https://github.com/semanticarts/ontology-toolkit/issues/118, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIFYTF4Y7WBREWFHLWLWYLXWSR37ANCNFSM6AAAAAA3Z3JG3Y
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Peter,
This did help, but I set the bin folder as a user variable and the dot.exe file as a system variable, but dot is still missing
Cameron

I downloaded GraphViz, set the bin and exe file in my system variables, and the issues sorted themselves out!

I downloaded GraphViz, set the bin and exe file in my system variables, and the issues sorted themselves out!

Sounds good. If you've any notes that might help others please just add
them to this issue, and enjoy using the toolkit
On Fri, 25 Aug 2023, 02:19 Cameron More, @.***> wrote:

I downloaded GraphViz, set the bin and exe file in my system variables,
and the issues sorted themselves out!
—
Reply to this email directly, view it on GitHub
https://github.com/semanticarts/ontology-toolkit/issues/118#issuecomment-1692618950,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIFYTD7C6FI2UGO2VX7FYDXW74SNANCNFSM6AAAAAA3Z3JG3Y
.
You are receiving this because you commented.Message ID:
@.***>


Face tracking: pass through preserveDrawingBuffer prop to WebGLRenderer

Used for face tracking with Three.js Face Mesh.
Setting this property to true lets the rendered canvas be redrawn, allowing for screenshots of the face mesh. In my case, this is done with html2canvas. If the property is not set to true, html2canvas is not able to capture it.
Since this can theoretically lead to degraded performance, it should be an optional property. Therefore, in this implementation, it is an optional property read into the constructor for MindARThree.

Hi Thanks for the PR! and sorry about the very late reply.
How about just calling mindarThree.renderer.preserveDrawingBuffer = true after you instantiate mindarThree.
I'm not very convinced it's a necessary change to MindAR. If we are to support that, I guess a more generic way is to add a parameter rendererParams in the constructor, which will pass along to the renderer constructor. So we can put anything including preserveDrawingBuffer as a property of rendererParams

Hi! Sorry for the late reply on my end as well.
I just tried switching to instead calling mindarThree.renderer.preserveDrawingBuffer = true after instantiating mindarThree, and it did not work. When I set preserveDrawingBuffer that way, it does not include the face mesh in the screenshot (same thing happens if I don't set preserveDrawingBuffer at all).

add preserveDrawingBuffer as option for the renderer is best way for screenshot. thanks.


400 - Bad request - Maximum content length.

Bug description
When running the command I get the following:
◇  Detected 2 staged files:
     tests/Fixtures/TicketSource/events.index.json
     tests/Unit/TicketSourceAPITest.php
│
◇  Changes analyzed
│
└  ✖ OpenAI API Error: 400 - Bad Request

{
  "error": {
    "message": "This model's maximum context length is 4097 tokens. However, you requested 5838 tokens (2909 in the messages, 2929 in the completion). Please reduce the length of the messages or completion.",
    "type": "invalid_request_error",
    "param": "messages",
    "code": "context_length_exceeded"
  }
}

My changes aren't particularly big. I've create a text file and added a single new test to my test suite.
git diff --cached
diff --git a/tests/Fixtures/TicketSource/events.index.json b/tests/Fixtures/TicketSource/events.index.json
index 0434c49..9d4b7e7 100644
--- a/tests/Fixtures/TicketSource/events.index.json
+++ b/tests/Fixtures/TicketSource/events.index.json
@@ -1 +1 @@
-{"statusCode":403,"headers":{"Date":"Sun, 30 Apr 2023 14:36:54 GMT","Content-Type":"text\/html; charset=UTF-8","Transfer-Encoding":"chunked","Connection":"keep-alive","Cache-Control":"max-age=15","Expires":"Sun, 30 Apr 2023 14:37:09 GMT","X-Frame-Options":"SAMEORIGIN","Report-To":"{\"endpoints\":[{\"url\":\"https:\\\/\\\/a.nel.cloudflare.com\\\/report\\\/v3?s=Vw41yz6s0hMgWrkbJWmSYwVZFcOoT5bKhg4TVpDimLV6VSBiGHbvdlD6K3Tmn4MsBLoimlt275%2FXaZUYlOrsKNGJdvlLuJ5T8qPlcXMmDD713bOkB92QDZRCoV2cHXTkdQRKCwFs\"}],\"group\":\"cf-nel\",\"max_age\":604800}","NEL":"{\"success_fraction\":0,\"report_to\":\"cf-nel\",\"max_age\":604800}","Strict-Transport-Security":"max-age=31536000; includeSubDomains; preload","X-Content-Type-Options":"nosniff","Server":"cloudflare","CF-RAY":"7c008508f889dcdb-LHR","alt-svc":"h3=\":443\"; ma=86400, h3-29=\":443\"; ma=86400"},"data":"<!DOCTYPE html>\n\n\n\n  \n\n<title>Attention Required! | Cloudflare<\/title>\n<meta charset=\"UTF-8\" \/>\n<meta http-equiv=\"Content-Type\" content=\"text\/html; charset=UTF-8\" \/>\n<meta http-equiv=\"X-UA-Compatible\" content=\"IE=Edge\" \/>\n<meta name=\"robots\" content=\"noindex, nofollow\" \/>\n<meta name=\"viewport\" content=\"width=device-width,initial-scale=1\" \/>\n<link rel=\"stylesheet\" id=\"cf_styles-css\" href=\"\/cdn-cgi\/styles\/cf.errors.css\" \/>\n\n


Fix typo in VectorIterator::operator +

@ghogen : Thanks for your contribution! The author, @mikeblome, has been notified to review your proposed change.


docs: Fix incorrect field name in license choice examples

Field name is plurar not singular per 1.

Field name is plurar not singular per 1.

"plural"


Allow Image Overrides

This pull request is to allow for all images to be overridden, it allows me to update the giphy button, see attached image.
Cheers for your work on this OSS project :)

Allow edits from maintainers, should be enabled now


fix: Hide organizer section when there is no information

fix: Hide organizer section when there is no information
Fixes #1209
Changes:
Before:

After:

I resolved the conflicts, please take a look again @iamareebjamal


Blade bug with @lang directive

Laravel Version: 6.0.0
PHP Version: 7.2.19

Description:
On Laravel 6, using @lang directive will throw ViewException. (Method Illuminate\Translation\Translator::getFromJson does not exist).
Because @lang directive renders as app('translator')->getFromJson('...') which was removed in this update.
Steps To Reproduce:
Simply try to use @lang directive with not existing key.

Try tun run php artisan view:clear - it should solve the problem.


FancyZone math question

While doing stylecop fixes, i came across this line.  I bet it isn't the only spot where we'll have math order of operation questions.
in GridEditor.xaml.cs, namely ArrangeGridRects
there is this line.
zone.HorizontalSnapPoints[pointsIndex++] = _rowInfo[walk].End + spacing / 2 - top;
The math here due to lack of parenthesis could be incorrect.  What is the correct math?

This is SA1407 , currently 8 in Fancy zones

Both issues leverage same math.
I'm assuming the math is this
_rowInfo[walk].End + (spacing / 2) - top;

@TheMrJukes any chance you can clarify the math here?
I'm assuming the math is this
_rowInfo[walk].End + (spacing / 2) - top;

verified my assumption was correct.

Fix available in 0.15.0 https://github.com/microsoft/PowerToys/releases


Doesn't play sounds in Safari nor in the App (Mac OS X Yosemite)

Messenger doesn't play sound clips in the Mac.
Neither Safari in its web form nor in Messenger desktop stand alone app.
The bubble shows in both, but when clicked to play the spinning circle goes forever.
Please advice,
Thank you!

Normal behavior, NWJS doesnt support sound nor video right now

Will be fixed in a near release for the app, ask apple for safari.


NetIOStats: Misleading and Incorrect

Two problems exist with NetIOStats().
Firstly the underlying call to sg_get_network_io_stats_diff returns the stats from the last call or from system start up if it is the fist call. The result includes the system time that the stats were taken over. This field (systime) is not included in the struct returned by the function, making the results almost useless as no rate can be estimated.
SysTime: time.Duration(int(v.systime))*time.Second, can convert intervals(followup calls).
Once the systime is included a second problem is made clear.
The underlying function depends on the fact that the same OS thread will make the call. Currently different  threads, depending on the scheduler, call the function.
Other functions might have the same drawback/problem, but I have not investigated this.
For example, if three call were made, the second one 10 seconds after the first and the third 1 second after the second then the stats for the third might be for 1 second (if it was called from the same thread as the second) or for 11 seconds(if it was called from the same thread as the first) or for the the system uptime(if it was called from a new thread).
stats := statgo.NewStat()
go func() {
	for _, netstats := range stats.NetIOStats() {
		fmt.Println(netstats)
	}
}()
go func() {
	time.Sleep(10 * time.Second)
	for _, netstats := range stats.NetIOStats() {
		fmt.Println(netstats)
	}
}()
go func() {
	time.Sleep(11 * time.Second)
	for _, netstats := range stats.NetIOStats() {
		fmt.Println(netstats)
	}
}()

A solution might be to start up a goroutine (in init()) that is is bound to an OS thread (using runtime.LockOSThread()) and waits for calls on a channel.
This will unfortunately require a restructure of most of the code..

Yep I've noticed the problem exists with the Cpu counters too but less visible.
Thanks for the detailed report I'll think about it your proposed solution sounds legit.

hey @HeinOldewage hopefully it does not change to much the interface and should solve the issue

Thank you for the quick feedback/fix.
I did a quick peek and it looks good.
I do have a question about C.sg_shutdown() in Stat.free() , should that not be called on the same thread as C.sg_init(1) ? If so that should be moved to case <-s.exitMessage:
I have no easy way to test this and libstatgrab's documentation does not mention anything about sg_shutdown.
Thanks again.

The manpage does not mention the cleanup nor the initialization has to be called from the main thread, in fact only some functions are using thread local mainly I assume to maintain the time of the last call.
For consistency I would probably do it anyway.


[Ground-24] Refactor Hive Plugin using Ground REST

Still needs more work but much cleaner than previous. Would like to get this started and will incrementally merge

Can one of the admins verify this patch?

Can you rebase onto master and squash the commits into one, for cleaner history?

Ok to test

test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ground-PRB/20/
Test FAILed.

Thanks for the feedback, @maasg! Always good to get more eyes on the code. Appreciate your help.

Thanks everyone! I will include all reviews, update and submit revision by
this weekend
thanks again
regards
Krishna
On Wed, Mar 22, 2017 at 11:05 AM, Vikram Sreekanti<EMAIL_ADDRESS>
wrote:

Thanks for the feedback, @maasg https://github.com/maasg! Always good
to get more eyes on the code. Appreciate your help.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ground-context/ground/pull/55#issuecomment-288488010,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFcNjBLKEdo5Mr-4p929oWxCNrixgQ7Bks5roWLVgaJpZM4MkABn
.

Since the plugins were moved out of this repo, you probably want to recreate this PR in the ground-context/plugins repo.

Thanks, Kevin. Krishna and I already spoke about this, and he's aware of the situation / was part of the decision to move the plugins to a separate repo.

Closing this as project moved to a different location
opening a new one


Fix for chrome binary not found error and also works for chromium based base browser

fixes https://github.com/zvovov/whatsapp-web/issues/44


Anyway to sort query result by random ?

Ex: Post::search('*')-> inRandomOrder()->take(10)->get();

I think it will be available in v4.0 out of the box


chore: add semantic-release

Pull Request Test Coverage Report for Build 176

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.205%

Totals

Change from base Build 172:
0.0%

Covered Lines:
89

Relevant Lines:
91

💛  - Coveralls


Try rehydrating NamespaceNotActive from Unavailable errors

We want to change the status code to be Unavailable, this is the first step in making this change.

Decided to create a new error instead of changing the semantics of the current one.


How to run

Hi, I am currently trying to run your code. However, I am confused with the path problems. I am writing this issue to ask could you please give detailed instructions such as: Under path ~/../improved_CcGAN, run $ bash ./RC-49/RC-49_64x64/CcGAN/scripts/run_train.sh

Please forget it. I have run it but it seems the cuda version on my computer is not suitable.


Added CSS file with Arizona official colors and fonts

Added a CSS file (derived from the w3 framework) and edited defaults to be Arizona colors and fonts sourced from official website.
Also, edited navbar to show all subpages on small screen dropdown, and edited header image position to remain on screen for small screens. Previously, it was moving up off of the screen to create whitespace below.

Navbar issues for mobile still exist but this update does it's job.


Feature/update readme

Update readme

Update links
Create troubleshooting section for init container issue solution

Changes no longer applicable


Cypress fails testing link to Wiley Online Library

Where to find the issue

https://www.coronawarn.app/en/blog/2021-08-05-statistictiles/ "Explanation of the statistic tiles in the Corona-Warn-App"
https://www.coronawarn.app/de/blog/2021-08-05-statistictiles/ "Erläuterung der Statistikkacheln in der Corona-Warn-App"

Describe the issue
The Cypress test check_links.js fails with an HTTP 503 error (Service Unavailable) when testing the link to https://onlinelibrary.wiley.com/doi/abs/10.2307/3315826.n1.
[RESPONSE 503] https://onlinelibrary.wiley.com/doi/abs/10.2307/3315826.n1 on 'http://localhost:8000/de/blog/2021-08-05-statistictiles'
[RESPONSE 503] https://onlinelibrary.wiley.com/doi/abs/10.2307/3315826.n1 on 'http://localhost:8000/en/blog/2021-08-05-statistictiles'

The site https://onlinelibrary.wiley.com appears to be now using DDoS protection by Cloudflare. This is a new situation. Previously checks to this website were not causing an error response.
Steps to reproduce
Open a web browser and check that the link https://onlinelibrary.wiley.com/doi/abs/10.2307/3315826.n1 is available when accessed manually.
Execute
npm run test:open
In Cypress console select check_links.js to execute this test.
Note 2 failed tests and examine contents of log file
cwa-website/cypress/logs/broken_links_result.txt
Suggested change
Options:

Ignore HTTP 503 (Service Unavailable) as a hard error. Instead, treat HTTP 503 as a temporary error and show success, or
Do not test https://onlinelibrary.wiley.com

Perhaps @brifemu could look at the best way to resolve this issue?

Hi @MikeMcC399  it is a pleasure to be able to communicate with you again after such a long time. I have created a PR for this problem, it is a temporary PR. I have left a small comment in the PR about how to fix this error in the future. Right now I am quite busy with several projects, so I will personally take care of this in depth in a few weeks.
#2554

@brifemu
Thank you for giving your attention to this issue!

PR #2554 needs a tweak to work. I will comment in the PR.

This issue is now resolved through PR #2554.

The output from the Cypress test suite (npm test) is
 √  All specs passed!

@brifemu

PR https://github.com/corona-warn-app/cwa-website/pull/2434 has caused PR #2554 to be reverted.

https://github.com/corona-warn-app/cwa-website/blob/eae3ba81c1f28a0564467e543b6cbe868e0ef1f1/cypress/integration/check_links.js
is missing the entry
'https://onlinelibrary.wiley.com/doi/abs/10.2307/3315826.n1'
I will submit a new PR to put this back again.

@MikeMcC399 Thanks.

PR https://github.com/corona-warn-app/cwa-website/pull/2574 is submitted to fix this issue again.

Resolved once again.


Remove trailing comma to fix lint

Coverage remained the same at 34.211% when pulling 06a124d1f47ad5853905580acc9dbff4ca7f55de on matthewmueller:patch-1 into 36abdc77c5f79b074ff4107abf970c443f1be7b3 on zeit:master.

Thanks.


invalid literal for int() with base 10 when using memory viewer -a

using the following command
voltron view memory -a 0x0804a07c yields the error in the subject
i tried any kind of format, such as-
0x0804a07c
0804a07c
"0x0804a07c"
"0804a07c"
now, my python is "meh" at best so the only i understand is that you have a format string that you are using to parse the memory address. other then the address should be in hex i'm getting nothing

Derp. Fixed in 3ced980707fec29530ea5969e373b5353894b9ba.

Any of the formats you tried should work now.


Split functionality into separate packages

Proposal
Split the PyPi package for smarthoise-sdk to:

smartnoise-sql -- the sql layer that wraps opendp core
smartnoise-synth -- the synthesizers
smartnoise-evaluator -- the stochastic evaluator and RL-based testing
dpsdgym -- a differentially private version of sdgym, as faithful as possible to the original

These would each have a top-level folder in the sdk repository, each with independent PyPi setup, requirements.txt, CI test scripts, etc.  The REST service would remain at top level and will have independent CI tests.
At the same time, move each of these to independent top-level namespaces.  For example, import smartnoise-synth or import snsynth.
Goals
These 4 components are independent of one another, and users will typically only be using one or two of them.  Splitting to separate packages allows better dependency resolution and smaller footprint.  Additionally, the new OpenDP library is stable enough for us to switch over now, and will be announced more broadly on September 22.  It makes sense to make both changes at the same time:
from opendp.core import *
from snsql import PrivateReader

In this example, the user wants to use core library and SQL wrapper side-by-side.
Moving the SDK packages to new namespaces allows us to make a cleaner break from previously-deprecated functionality in the existing SDK package.  There is still the question of what to name the new namespaces.
One option would be to hoist them all as siblings to a top-level smartnoise namespace, e.g. import smartnoise.synth; import smartnoise.sql.  This is similar to how we currently stack core and sdk packages under a single namespace, and has the same issues: edit-enabled installs of multiple packages stacked in the same namespace are problematic.  Furthermore, unlike e.g. opendp.core and opendp.meas, these two smartnoise namespaces are meant to be installed independently.
Using names like snsynth might be less cumbersome for developers than smartnoise-synth.

This proposal essentially turns us into a monorepo, with all the advantages and disadvantages that entails.  The codebase is not too large, and the CI for each sub-feature can be configured to run only when the paths associated with that feature change.  But we will need to maintain ability to make bug fixes to the old versions of the library before split, and will likely have different version tags for each project in the repo, updated at different frequencies.


Improve documentation about creating a new Smart Answer

I've added example content for the landing, question and outcome page templates. I think this leaves us with a slightly more realistic Smart Answer.

LGTM 👍


Simplify Elements example by using Math.max

Used Math.max to simplify the lineWidth logic in elements example. The if statement was a little harder to follow, using Math.max makes it easier to figure out what's going on at a glance and reduces code size.

Finally got around to updating the rest of the examples. Thanks for the feedback 👍


ERR_PACK cast problem / inconsistent definition (master branch)

Originally ERR_PACK cast all arguments to unsigned long, this was patched in commit c3ddb263315c7196b488f384b3bc82cd474c8698 to no cast and then in commit d82c27589b5f9e9128f1ae9fce89fadd03c1c229 it was partially reverted by explicitly casting the first l (library) argument to unsigned int (instead of long). However, also the f (function) and preferably also the r (reason) arguments should be cast to unsigned since the arguments are normally of int, as advertised in the man page of ERR_PACK: https://github.com/openssl/openssl/blob/master/doc/crypto/ERR_load_strings.pod
Not casting leads to compiler warnings (with -Wsign-conversion):
include/openssl/err.h:137:59: warning: conversion to ‘unsigned int’ from ‘int’ may change the sign of the result [-Wsign-conversion]
   ( ((unsigned int)((l) & 0x0FF) << 24L) | (((f) & 0xFFF) << 12L) | ((r) & 0xFFF) )
where the error indicator is under the second shift-left.

The masking means the error can't happen, the compiler is wrong.  But we should fix this.

https://github.com/openssl/openssl/pull/1385

Thanks for the fix. I agree the compiler is wrong in that the mask prevents the sign flip.
By the way, note  that the code is no longer safe on a platform with 16bits int/32bits long (I don't know if OpenSSL is supported on any of those). Can I suggest to cast to uint32_t instead? I should have suggested that in the first place, I'm sorry...

We don't support a 16 bit int. Lots of stuff will break in such an environment.

We don’t support 16bit platforms.  For now long is fine, since the table is a long.  Will fix in the future,  I think.

Just a final note: the << will actually work on the level of the unsigned int, the cast to unsigned long is only done afterwards. But as long as you're using at least 32bit integer, there indeed isn't any problem.

Changing from long to uint32_t is a bigger change than we can do this late in the cycle, I think.  But ping @emilia :)

How do you mean long? In  pull request #1385  you cast to unsigned int? That was where I suggested making that explicitly uint32_t which is internally the same on x86_64 but safe on any platform...

It's used to build error table definitions and the error table field is a long.

It's unclear to me looking at the description here as to whether we are looking at this for 1.1.0 or not. I'm putting it against that milestone for now...@richsalz is that appropriate?

I think a longer-term issue about the ERR API and structures is already recorded.  This simple fix of fixing the casts, in #1385 is for 1.1.0

So can I close this in favour of that (lets only track it one place)?

One’s an issue, one’s a PR.  I view it as RT and PR, but YMMV.

Still confused. #1385 seems to have been closed, but I can't find it in the repo?

I never pushed :(  Rebased and just pushed it.

Ok. So can I change the milestone on this to post 1.1.0?

No, I just pushed it.  It’s done. ☺

Ok...so this issue can be closed right?


Add 28-Day Active Telemetry

Add 28-day anonymous active user count for online scanner. Routes activity data through internal API to drop extra metrics that App Insights automatically sends.

@antross endpoint updated


Add retry logic for Azure service management operations

Removed separate 'driver' concept, collapsed it into the 'manager' object.
Changed from io.Reader to []byte for carrying the request payloads.
Use same api version for all requests.
Fixes #24
Fixes #25
cc: @ahmetalpbalkan @Snesha @jeffmendoza

realized we're actually maintaining 2 azure management SDKs in Go. that probably shouldn't be the case. Consider improving the official one we have.

yep, working on that too

:+1:


Lifecycle Expand Shorthand

What: Expand any shorthand notation in the input Impls.
Why: Parent issue https://github.com/Green-Software-Foundation/ief/issues/78
DoD:

[ ] Create a test IMPL which can drive the development of this issue.
[ ] Implement spec as per Expand Shorthand

Closing as now obselete


Ditch the aws module which uses cloudformation

This ditches the telia-oss/asg/aws module in favor of directly using a launch configuration and an ASG. For testing, this is much faster to iterate with.

This is pretty much good to go excluding the clean up of var.instance_count. I used it to test the new version.

Let me know if the change I just pushed was what you had in mind for splitting the different IAM roles.


Expressive theme – Tooltip

Tooltip
Default
Having trouble inspecting the tooltip because I can't force it to stay open...

[ ] link looks like it might still be 14px, should be 16/22px

Only custom icon

- [ ] Is it possible for this version to have a 20x20 icon, or will it change all the icons in the "default" tooltip group?
Definition tooltip
⭐  looks good!
Icon tooltip

[ ] Could you tell me what size the container is? It looks a little smaller than the "default uncontrolled tooltip"
[ ] When the tooltip is direction left or right, there's a tiny white line that appears between the carat and container box. I'm not seeing it in the Carbon storybook example, can you check if it's a bug in our storybook?

@oliviaflory yeah seems like bumping up the icon for Only custom icon will change the icon size for the default variation as well...


📃: adding drum kit game

🔴 Title :Drum kit game
🔴 Tech stack :html ,css , javascript
🔴 Objective :The Drum Kit is an interactive web application that allows users to play various drum sounds using both mouse clicks and keyboard inputs. It features seven different types of drum sounds, each associated with a unique button on the screen and a corresponding key on the keyboard.
🔴 Summary :
📸 Screenshots

✅ Details to Include When Taking the Issue:
Name :Priya Rani
Participant Role (Specify the Open Source Program name, e.g., GSSOC, Hacktoberfest, etc.):GSSOC, Hacktoberfest,

Happy Contributing! 🚀
Wishing you all the best on your open source journey. Enjoy! 😎

already available


ceph-salt not found

Which repo is ceph-salt suppose to be found in when running zypper in ceph-salt as I am unable to get this working which is like step 1 of installing ceph cluster on Suse Enterprise 15.3 SP3.
I am following these instructions. https://documentation.suse.com/ses/7/html/ses-all/deploy-bootstrap.html
I assume I'm missing a repo or something obvious like I am supposed to pull it from here or set the repo to github or something?
Kind Regards
Loading repository data...
Reading installed packages...
Package 'ceph-salt' not found.
Resolving package dependencies...
Nothing to do.

Official SUSE builds of ceph-salt for SLE are only available as part of the SUSE Enterprise Storage product, which is no longer available to new customers (see https://www.suse.com/download/ses/). If you're an existing customer, you should have access to the appropriate repositories as part of your subscription.


⚠ SceneTime has degraded performance

In 42a1c31, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1596 ms

Resolved: SceneTime performance has improved in 1c41fdf after 10 minutes.


Link to API docs for http_server is incorrect

 Issue by sethladd
Originally opened as dart-lang/sdk#19093

Looks like something changed.
Go to http://pub.dartlang.org/packages/http_server
Click link to API docs: https://api.dartlang.org/docs/channels/stable/latest/http_server.html
End up here: https://api.dartlang.org/apidocs/channels/stable/dartdoc-viewer/home

 Comment by efortuna

Added NeedsInfo label.

 Comment by efortuna

Yep. I did some big house cleaning on the server end, and Alan told me he thought that the urls that were api.dartlang.org/docs/etc were no longer being used. Can we change the links on pub.dartlang.org? The "docs" as opposed to "apidocs" in the url is the old style....

Set owner to @efortuna.

 Comment by sethladd

CC Emily, as I'm not sure if the bug is with dartdocviewer and its redirects?

cc @efortuna.

 Comment by sethladd

The best thing to do is to remove the doc link in the pubspec.yaml. pub.dartlang.org will then default to the right docs in dartdocs.org

 Comment by sethladd

This is why redirects are so important to maintain.

 Comment by efortuna

adding Bob and Natalie on cc.
Can we just change the paths on pub.dartlang.org instead? I'm willing to help out to make that happen so we only have one link system to worry about.

cc @munificent.
cc @nex3.
Removed the owner.

 Comment by alan-knight

It's probably good to do this, but the link from pub works now.
And we're going to have multiple URL spaces to deal with for a long time. The google search results very often refer to old URL schemes. Sometimes very old.

 Comment by munificent

Right. This URL is coming from the pubspec, so we just need to remove it from there and republish.

 Comment by sethladd

We should do this, we're going to remove the package API docs from api.dartlang.org

Set owner to @skabet.
Removed Priority-Unassigned label.
Added Priority-Medium, Triaged labels.

This can be closed, yes?

Yep, looks like it was fixed.


3 AM gaming UI

About the PR

Dark mode UI
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

tweak: We replaced your eyeballs.

Going to wait for checks to finish and then I'll merge


no sensor

I get this text with active torrents.
Maybe its because of name of integration?
sensor.smartbox_active_torrents

Could you please provide your card definition?

Could you please provide your card definition?

type: custom:transmission-card sensor_entity_id: smartbox display_mode: compact hide_header: true default_type: active
I have integration with two different name

Please check in the Developer Tools -> States that the sensor sensor.smartbox_status exists and has a valid value.

Please check in the Developer Tools -> States that the sensor sensor.smartbox_status exists and has a valid value.

According to line 60, 69-75 (see [1]) no sensor is displayed for status if the down speed sensor's value (in your case sensor.smartbox_down_speed) is undefined. Did you disable this sensor?
https://github.com/amaximus/transmission-card/blob/main/transmission-card.js#L60

According to line 60, 69-75 (see [1]) no sensor is displayed for status if the down speed sensor's value (in your case sensor.smartbox_down_speed) is undefined. Did you disable this sensor?
https://github.com/amaximus/transmission-card/blob/main/transmission-card.js#L60

It's enabled :)

Just pushed a new release (0.12.1) that addresses this issue.
Please update the card and get back to me with results.

Just pushed a new release (0.12.1) that addresses this issue.
Please update the card and get back to me with results.

Many thanks for your work!

Does it work as you expected?

Does it work as you expected?

Yes, it's work properly!


lint: run all possible checks on short commit msg

Actually two changes here.
lint: run all possible checks on short commit msg

Refactor linting into 3 phases where phase 3 only runs if phase 1 succeeds.
The commit message will be shown before any linting messages to make it easier to identify.
Added check on long Lines in commit description.
Cleaned up some dead comments.

linting: add options interface for customization
The initial option allows setting of the max line length in the commit message.  This will help position for when some method of customizing is selected.

Re-pushed to address semicolon  problems with function declarations and late rebase.  Lots of LOL for me.
This should address the concerns (or many of them) in issue #818.


fix bugs in issuer-server

fixing manifest filtering in issuer server
adding trycatch to listen method
fixing ms sleep
create new method for sleeping

Closes #135

Codecov Report
Attention: Patch coverage is 4.68750% with 61 lines in your changes missing coverage. Please review.

Project coverage is 47.36%. Comparing base (1d0fffc) to head (91680a9).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   47.45%   47.36%   -0.10%
==========================================
  Files          62       61       -1
  Lines        8682     8701      +19
  Branches      286      291       +5
==========================================
+ Hits         4120     4121       +1
- Misses       4561     4579      +18
  Partials        1        1

Components
Coverage Δ

applicant
57.50% <34.80%> (-0.44%)
:arrow_down:

common
43.59% <91.17%> (-0.37%)
:arrow_down:

issuer
65.56% <47.13%> (-2.05%)
:arrow_down:

server
59.87% <10.00%> (+2.17%)
:arrow_up:


match desktop search and highlight results

Summary
Searching posts will now match the search done in the webapp and highlights the words that match
Ticket Link
https://mattermost.atlassian.net/browse/MM-44517
https://mattermost.atlassian.net/browse/MM-52670
Release Note
Fixed search results to match the webapp.
Added results highlight that matches the words being searched.

Building app in separate branch.


JDA 3 RoleManager setColor()

When you set a role color in .queue() after execution the thread not closes!
http://prntscr.com/diftch
http://prntscr.com/diftfo

Also having this issue, running JDA 3.0_BETA_103. The thread won't close after set the role color.

Ok, i'm trying to make a rainbow tag:

r_a variable represents the role.

for(Role a : Main.jda.getGuildById("163106828274761728").getRoles()) {
            if(a.getName().equalsIgnoreCase("Admin")) {
                r_a = a;
                break;
            }
 }

Changing the tag color:

r_a.getManager().setColor(getColor()).queue();

Get color method:

    public static Color getColor() {

        if(atual == 0) {
            atual++;
            return Color.BLUE;
        }
        else if(atual == 1) {
            atual++;
            return Color.CYAN;
        }
        else if(atual == 2) {
            atual++;
            return Color.GREEN;
        }
        else if(atual == 3) {
            atual++;
            return Color.MAGENTA;
        }
        else if(atual == 4) {
            atual++;
            return Color.ORANGE;
        }
        else if(atual == 5) {
            atual++;
            return Color.PINK;
        }
        else if(atual == 6) {
            atual++;
            return Color.RED;
        }
        else if(atual == 7) {
            atual = 0;
            return Color.YELLOW;
        }
        return Color.YELLOW;
    }

The color is from java.awt.Color

Every time wich the tag color is changed one thread is started and not finalized.

Are you making sure that the previous color has been set, and a Role update received, before trying to set the color again?

Forgive me here, but what thread do you think is not being closed?

Every time when you set a role color a new thread is opened and after execution it not closes.

@HeyZeer0 You really should look in to switch cases 👀
As for the thread not closing. Could you provide some solid evidence such as pictures from VisualVM showing the thread being opened and not closed?

Thanks @TheEpTic after using the VisualVM i indentified the error and fixed it, the issue can be closed.


Create codeql-analysis.yml

I got the idea to add some code quality analyzers, since we are invested in nice code anyway.
GitHub suggested its (beta) code analyze tool.
This is a pretty basic config, but with push to master and cornjob turned off. I only really care about pull requests. Kodiak will keep the branches up to date anyway.

If it's only going to give these java errors, there won't be much use for it.


Row Vector Enhancement for Pyvelox

Description
The initial PR created here contains base functions and it was a motivation to support PyVelox Substrait integration.
The next steps could include some of the features discussed in the intial PR and extend further.

getitem to include a newer functionality which C++ doesn't offer
Adding Resize method

cc @kgpai


Add bailan rochas y cheatas by nene malo

Song Name
bailan rochas y cheatas
Artist Name
nene malo
Source
Youtube
Youtube Link
TMbVE0cDEISjz7Ka
Direct File Link
https://www.youtube.com/results?search_query=nene+malo
Song ID
56
Start Offset [ms]
5
Extra
Created from Auto Nong.
Created for level: 95068752

reject
invalid YouTube link


Feature Request : Delete Positions With a certain Value

Dear All,
I am not sure how many of us here would find this feature request useful, but I will still go ahead and list it here,. In-case any or few might up vote this :)
As there is already a feature to disable positions older than x number of days.
I have a scenario where some chinese devices, like TK103, etc. Keeps sending Data with New fixtime or devicetime even when the vehicle/device is static/stationary. In such a case even the filter duplicate feature would not work, as it checks for the time.
So to remove such records,. I had been usually running a direct MySQL query to delete all records, which had protocol column a certain value lets say GPS103, and speed value = 0
So for a better option, which can be adapted or used as and how users require, based on device specific data. here is my feature request

User can configure columns, and the values it should contain.
And the frequency at which this delete option should run.
And at that set interval/frequency, the server would check for the position table, specified columns for the set values, and delete them.

I am thinking of using it to clear all junk values, such as GPS Data received when vehicle is stationary. etc.,

It sounds too complicated. Can you please be more specific about the positions that you want to remove. You can use filtering by speed and/or distance when vehicle is stationary.

There is a new "static" filter in development version of traccar which filters devices with speed=0. But it's an all or nothing filter.

By the way, if someone calls or texts your device (at least GPS103 ones), it will wake up and try to update its position. This can easily happen with prepaid sim card numbers which have been assigned to someone else in the past.

Also I want to note that (about) zero speed values used to detect trips, if you filter/remove zero speed positions thoughtless, you will probably loose trips functionality in reports.
Best solution is configure device to sleep (do not send positions) while it is not moving.

Abyss777, the problem is that those devices wake up when they receive a phone call or text, even not from the admin number. So even if you tell them to sleep, that won't work if it's a previously assigned number which receives commercial calls or texts all the time. Unless of course, you use the deep sleep functionality of (some of) these devices, which cuts the phone network completely when sleeping.

They should sleep again after call/text.


chore(main): release 0.34.0

:robot: I have created a release beep boop
0.34.0 (2024-12-16)
Features

check for additional install paths on windows (45bd1dc)

Bug Fixes

remove duplicated paths on windows when creating a task (fb4acb9)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.34.0
:sunflower:


[$1000] Web -  Account B's reactions on tasks assigned to self by account A are not dynamically updating on account A

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

On account A  go inside chat with account B
Click on Plus inside composer > assign task > give a title > click next
Click on assignee and select self (Account A) > create task
Go back to the chat with account B page
On account B hover over the last created task and react on it
Observe if the reactions are showing up on account A

Expected Result:
Reactions from account B should show up on account A as well without any further actions
Actual Result:
Reactions from account B are not being dynamically visible on account A. The reactions appear if only account A reloads the page, switches chat and comes back or reacts on the task.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.37-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/975a230d-8729-4d43-9cfa-e69ef5ec99b7
https://github.com/Expensify/App/assets/93399543/a2c9207e-ab81-4d28-89d3-378d43b30256
Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688629159314669
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016254cf6ea7a843f1
Upwork Job ID:<PHONE_NUMBER>064214528
Last Price Increase: 2023-07-11

This seems to be the BE issue. BE does not push events.
And there is another BE issue.
If react on the task preview message, BE responds as below. But reaction is added successfully.

@allroundexperts I just tested and I still have to refresh on account A to see the reaction, moving to internal (I'm betting this is a known issue)

@allroundexperts I made this internal - but I think this must be related to something larger (but i can't easily find an exact issue or project) should we keep open or close for now?

@allroundexperts do you have an idea what larger issue this might be related to?

This is still a problem but @allroundexperts but if we think the root cause is being worked on else where can we close?


[BEAM-5445] Clarifies that SpannerIO currently does not support unbounded writes.

Clarifies that SpannerIO currently does not support unbounded writes.

R: @udim

Thanks.


[CU-8689p0gfb] Allows users to unpublish articles

Task linked: CU-8689p0gfb Can't unpublish articles


Clean up offenses related to the placement of parens

All tests should pass and all functionality should be identical.

Coverage remained the same at 90.855% when pulling 109e8ce9bf7618906eb433d784567f80be1e29bd on mo-nathan:cop-parens into a360f142aa3f701007f58f590285f0437a1d4af1 on MushroomObserver:master.

Nathan:
Thanks so much for doing this. (It's probably something that's more suitable for someone at my pay grade, rather than someone with your skills. But I haven't gotten around to it.)
After everything is fixed, you might consider removing the fixed Cops from .rubocop_todo.yml.  (Minimal documentation about the point of that file is at https://rubocop.readthedocs.io/en/latest/configuration/#automatically-generated-configuration.)
Joe

@JoeCohen The fun thing about doing volunteer work is there are no pay grades!  Personally I find fixing stuff like this kind of relaxing.  A friend of mine has described it as "comfort coding".  So don't worry about that.  I had noticed the .rubocop_todo.yml and have removed a few things from there that are now deprecated.  I think we should get the existing list down to zero before taking on those.  Right now I'm dealing with the low hanging fruit.  The hard stuff is going to be the "Metrics" offenses.