core branch to support backend CI

#1188  👈
feature/proof-of-stake

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lazynina and the rest of your teammates on  Graphite


Schema editor refactor

Before submitting a pull request, please make sure the following is done...

Fork the repo and create your branch from master.
If you've added code that should be tested, add tests!
If you've changed APIs, update the documentation.
Ensure the test suite passes (npm test).
Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.云数 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Starting replication process with Procfile

The README of the project says that the replication process can be started with a procfile:
# Procfile
rails: bundle exec rails server --port $PORT
litestream: bin/rails litestream:replicate

It seems though that if bin/rails litestream:replicate executes asynchronously, foreman (or whatever process monitor) would exit, stopping the other processes as well, correct?
I'm asking this because this is what's happening when I try this setup (when I run the puma plugin it works).
This seems to affect other commands like restore as well, which makes it hard to implement sequential logic (e.g. restoring the db before running  bin/rails db:prepare — useful when migrating to a new server for distaster recovery)

Interesting. I can successfully run litestream with the puma plugin in Rails 8 but running as a separate process just exits. An excerpt from my Kamal config.
servers:
  web:
    - <IP_ADDRESS>
  worker:
    hosts:
        - <IP_ADDRESS>
    cmd: bin/jobs
  litestream:
    hosts:
      - <IP_ADDRESS>
    cmd: bin/rails litestream:replicate

Any logs? I'd love to fix this, but would need a bit more info around what is going on


Ugly wide black border

I presume transparency somehow doesn't work?

Hi @DaarkWel,
Unfortunately this seems to happen in some environments, I don't know why, but it's most likely an SDL3 issue. I was hoping this update would fix it.
This is how it looks like on my PC:
https://i.imgur.com/uGaucb4.png
I should probably create an issue about this in the SDL3 repository, with a 'Minimal Reproducible Example'.

Hi @DaarkWel,
Can you tell me more about your environment? OS, SDL version (preferrably commit version) and etc? I'm trying to reproduce here but without success... maybe your SDL3 is not the most up-to-date version available.

I'm using Archlinux (updated), SDL3 latest from AUR (https://aur.archlinux.org/packages/sdl3). I guess it's from tag preview-3.1.6 judging from PKGBUILD. I don't use any DE just Openbox, I have desktop transparency with compton, I play some games so my hardware is working all right. Maybe the reason is my pretty old machine (AMD FX CPU, AMD Radeon HD 7750 (amdgpu driver)).

This explains a lot, actually.
I have one machine with XFCE and another one with Openbox, the one with Openbox also opens with ugly black borders... but I have ignored this since this runs a somewhat old Slackware.
However, I decided to run a WM on my machine with XFCE and the ugly black borders is there again... so this is clearly something related to compositor, and etc... but I can't point exactly what you should do to fix this.


Default not styled html select doesn't work.

Anyone else has this problem that select doesnt work ?
I made select like this.
<select id="random-select" onchange="myomyo();">                                 <option id="1">1</option>                                 <option id="2">2</option>                                 <option id="3">3</option>                                 <option id="4">4</option>                                 <option id="5">5</option>                                 <option id="6">6</option>                             </select>
And jquery like this
$('#random-select').change(function(){     alert($(this).val()); })
And problem is that sometimes i need to tap select twice to fire this event.

ALready fixed in dev


Cannot find place to set task group id for tasks

I want to set task_group_id for each task in a single project for limiting concurrent executing task instances. But I cannot find any place  to set this task_group_id even I find it in the database. So Any idea on how to set it

it seems we do not have task group for pydolphinscheduler yet

Hey, I find a place to set task group id when I get my workflow api response. It's task_definition_json in Workflow class, but the source code have not provided this variable setting yet. So I have to override Workflow class and task_definition_json method, where task_group_id is an optional parameter and give each task taskGroupId and its value in its dict. I hope this may help and I am looking forward to see this issue would be solved in the future.

Hey, I find a place to set task group id when I get my workflow api response. It's task_definition_json in Workflow class, but the source code have not provided this variable setting yet. So I have to override Workflow class and task_definition_json method, where task_group_id is an optional parameter and give each task taskGroupId and its value in its dict. I hope this may help and I am looking forward to see this issue would be solved in the future.

we will add it in version 4.0.4


can we hide appbar

i have facing issue hide app bar in of webview
can anyone help.

Duplicate of #73


File line count variable

What's missing?
A variable containing the line number of the currently open file ({file_lines_count})

Related to #48, which means I'm not currently sure how to implement this.

I've done some research and now I know how to do this. Going to implement it later.

The current problem is that certain files (or specifically the editor of the file) don't have line counts, like images for example. What should happen in this scenario? Should we just show an x or some other character?

Good question... Let me think about it

I'll just use the hyphen (-) for now

Nice


@conda-forge-admin, please add bot automerge

Additional comment:
@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/de-strahlenschutz-feedstock#2.


Tests for NDMG

Add testing suite for ndmg pipeline that is travis-compliant (or not, depends on the size of the test cases).
testing suite should be command line executable.
travis executable scripts:

test BIDs utilities

make dummy files that are named properly according to bids spec, and are named to mirror the test subjects subset; however, the files will all be empty. this will facilitate just checking that the BIDs parsing works, despite the fact that testing on a full BIDs dataset would not be executable by travis.

test that files are produced where we expect them to be (QA, as well as all other derivatives)
test basic properties of derivatives: fMRI connectomes are dense; dMRI are sparse; dMRI contain off-diagonal edges.
make dummy data for fMRI nusiance correction. add low pass signal, add linear, quadratic, and scalar drift. add gaussian noise. verify that the nuisance correction recovers something close to zero signal.
verify that fMRI timeseries are n x t for t timesteps.

non-travis executable scripts (since this test case will be too big/complex, and travis is memory/compute limited):

accepts a set of AWS credentials.
identify a subset of subjects to use for testing. This can supplement our existing "test batch" of subjects, available in the aws bucket at aws s3 cp --no-sign-request s3://mrneurodata/bids_test.tar.gz ./
modify so that the test subjects are stored in a BIDs format on AWS. this will facilitate execution of the cloud container.
launch a job, and check in the background every n seconds for successful completion of the job. The NDMG aws utility already has a function for doing this, so it will just be a matter of setting this up to run on its own node.

verify after the script reports "completed" that you can query for the data on aws, that it exists, and that the proper files are produced.

use DICE overlap with brain-extracted registered brain, to confirm that the DICE scores exceed a particular threshold (registration success)
execute ndmg_bids with dmri and fmri on testing data, confirm all derivatives produced successfully.
confirm basic known properties about the produced connectomes: dMRI separated left/right hemisphere after ASE, fMRI has homotopic connectivity > heterotopic connectivity.

Add testing suite for ndmg pipeline that is travis-compliant (or not, depends on the size of the test cases).

It is definitely imperative that the tests be run on push, whether through travis or circle CI.

testing suite should be command line executable.

I'm not sure what you mean here, but if you mean anything other than pytest, I disagree. It's important to be in Python and not clutter the package executable name space, that way we get to make assertions about data values, see lines of failure, and intercept the execution to evaluate small components independently.

test BIDs utilities

make dummy files that are named properly according to bids spec, and are named to mirror the test subjects subset; however, the files will all be empty. this will facilitate just checking that the BIDs parsing works, despite the fact that testing on a full BIDs dataset would not be executable by travis.

We should just download a real BIDS dataset instead - there are many publicly available - and process it for 1 subject.

test that files are produced where we expect them to be (QA, as well as all other derivatives)
test basic properties of derivatives: fMRI connectomes are dense; dMRI are sparse; dMRI contain off-diagonal edges.
-make dummy data for fMRI nusiance correction. add low pass signal, add linear, quadratic, and scalar drift. add gaussian noise. verify that the nuisance correction recovers something close to zero signal.
verify that fMRI timeseries are n x t for t timesteps.

For many of these you should just store the test result somewhere, process the data, and assert that the two files are identical. This breaks in stages when you change actual pipeline logic, but when it's cleaning things up or refactoring the data should be unchanged.

non-travis executable scripts (since this test case will be too big/complex, and travis is memory/compute limited):

The testing script for the ndmg BIDS app runs two sessions through the DWI pipeline, on Circle CI. I don't think any of the tests below make much sense, and certainly not to be run outside of any CI package. To test the pipeline, you should run the pipeline on data somewhere you trust, compute hashes of the results, store those, and compare the hashes of the outputs to the outputs produced during execution on test time. These should be 100% automatic, not require any credentials for a resource, and do more than a subjective comparison. For testing cloud functionality, you should look into moto, a boto3 mock-client for exactly this purpose.


Ability to validate besu config file / command line

Description
As a developer, I want to be able to validate my besu config file (or command line) so that I can make sure it is valid without starting besu.
I think it makes sense to do this as a besu subcommand.
Acceptance Criteria

besu validate-config --config-file=besu.conf
besu validate-config --unknown-option
Above commands would print out any pico CLI exceptions, but not start besu

Expected behavior: [What you expect to happen]
I would like to see any errors, or a "success" message, without needing to start besu
Actual behavior: [What actually happens]
Currently I need to start besu with the given config file / command line and if it's valid (besu starts) I kill besu.

i will work on this


build prometheus on amd64 need >512mb memory to work

while running make build on the following VM
prometheus (master) $ free -h
             total       used       free     shared    buffers     cached
Mem:          489M       209M       280M        12M       6.8M        67M
-/+ buffers/cache:       134M       354M
Swap:           0B         0B         0B

i tried two times to build, but failed with the following message
make -C config
make[1]: Entering directory `/home/vagrant/go/src/github.com/pyk/prometheus/config'
make[1]: Nothing to be done for `all'.
make[1]: Leaving directory `/home/vagrant/go/src/github.com/pyk/prometheus/config'
curl -o /home/vagrant/go/src/github.com/pyk/prometheus/.build/cache/go1.4.linux-amd64.tar.gz -L https://golang.org/dl/go1.4.linux-amd64.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    85  100    85    0     0      6      0  0:00:14  0:00:12  0:00:02    23
100 60.3M  100 60.3M    0     0   620k      0  0:01:39  0:01:39 --:--:--  829k
tar -C /home/vagrant/go/src/github.com/pyk/prometheus/.build/root -xzf /home/vagrant/go/src/github.com/pyk/prometheus/.build/cache/go1.4.linux-amd64.tar.gz
touch /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/bin/go
cp -a /home/vagrant/go/src/github.com/pyk/prometheus/Godeps/_workspace /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/gopath
ln -s /home/vagrant/go/src/github.com/pyk/prometheus /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/gopath/src/github.com/prometheus/prometheus
make -C tools
make[1]: Entering directory `/home/vagrant/go/src/github.com/pyk/prometheus/tools'
make -C rule_checker
make[2]: Entering directory `/home/vagrant/go/src/github.com/pyk/prometheus/tools/rule_checker'
TMPDIR=/tmp GOROOT=/home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go GOPATH=/home/vagrant/go/src/github.com/pyk/prometheus/.build/root/gopath /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/bin/go build -o rule_checker .
make[2]: Leaving directory `/home/vagrant/go/src/github.com/pyk/prometheus/tools/rule_checker'
make[1]: Leaving directory `/home/vagrant/go/src/github.com/pyk/prometheus/tools'
make -C web
make[1]: Entering directory `/home/vagrant/go/src/github.com/pyk/prometheus/web'
# Note that embed-static.sh excludes map files and the
# non-minified bootstrap files.
../utility/embed-static.sh static templates | /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/bin/gofmt > blob/files.go
make[1]: Leaving directory `/home/vagrant/go/src/github.com/pyk/prometheus/web'
TMPDIR=/tmp GOROOT=/home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go GOPATH=/home/vagrant/go/src/github.com/pyk/prometheus/.build/root/gopath /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/bin/go build -o prometheus -ldflags " -X main.buildVersion 0.10.0 -X main.buildRevision 79a4a6d -X main.buildBranch master -X main.buildUser vagrant@priceable -X main.buildDate 20150218-04:27:53 -X main.goVersion 1.4" .
go build github.com/prometheus/prometheus/stats: /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: fork/exec /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: cannot allocate memory
go build github.com/prometheus/prometheus/storage/metric: /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: fork/exec /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: cannot allocate memory
go build github.com/prometheus/prometheus/storage/local/flock: /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: fork/exec /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: cannot allocate memory
go build github.com/syndtr/goleveldb/leveldb/util: /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: fork/exec /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: cannot allocate memory
go build github.com/syndtr/goleveldb/leveldb/comparer: /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: fork/exec /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: cannot allocate memory
go build github.com/syndtr/gosnappy/snappy: /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: fork/exec /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: cannot allocate memory
go build github.com/prometheus/prometheus/utility/test: /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: fork/exec /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: cannot allocate memory
go build github.com/prometheus/prometheus/storage/remote: /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: fork/exec /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: cannot allocate memory
go build github.com/prometheus/prometheus/storage/remote/opentsdb: /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: fork/exec /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: cannot allocate memory
go build github.com/prometheus/prometheus/web/httputils: /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: fork/exec /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: cannot allocate memory
go build github.com/prometheus/prometheus/web/blob: /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: fork/exec /home/vagrant/go/src/github.com/pyk/prometheus/.build/root/go/pkg/tool/linux_amd64/6g: cannot allocate memory
make: *** [build] Error 1

after upgrading a VM
prometheus (master) $ free -h
             total       used       free     shared    buffers     cached
Mem:          993M       234M       759M        12M        13M        99M
-/+ buffers/cache:       121M       872M
Swap:           0B         0B         0B

now it succes to build & run flawlessly
prometheus (master) $ ./prometheus -config.file=../prometheus-getstarted/prometheus.conf
prometheus, version 0.10.0 (branch: master, revision: 79a4a6d)
  build user:       vagrant@priceable
  build date:       20150218-05:03:49
  go version:       1.4

Thanks for the report!
Yes, sorry - this is expected. Prometheus needs around 600MB of RAM to build (as measured by running make build in a cgroup and looking at memory.max_usage_in_bytes). To my knowledge there's not much we can do about that at the moment. Maybe the Go compiler will become more modest in its memory usage in the future. For now you'll need to build Prometheus on a machine with at least that much memory and a bit of headroom for the rest of the OS.
Closing.


North West | Zabihollah Namazi | Module-User-Focused-Data | Form Controls | Sprint 2

I had anouther branch and pull request for this branch but the problem was that there was two projects added in that branch.
I made a new branch only with commits from the form controls.
thanks

Hi
thanks for your suggestions and I fixed them please check them again.
many thanks

I updated the code and added requirement for choosing colour too.
thanks

added the requirement for name input and set to show element is focused
thanks


feat: Progress page cantons

Dropdown size

What's the problem?

the width of the dropdown :-P
I just looked over the pages..

In my opinion the width is fine and gives the page a bit more structure


Travis tests intermittently fail with an extra process error

While working on https://github.com/dw/mitogen/pull/658 I noticed this would happen sometimes:
======================================================================
ERROR: tearDownClass (doas_test.DoasTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/dw/mitogen/tests/testlib.py", line 529, in tearDownClass
    cls.dockerized_ssh.check_processes()
  File "/home/travis/build/dw/mitogen/tests/testlib.py", line 478, in check_processes
    counts
AssertionError: Docker container 'mitogen-test-e71a28532b8fc46f' contained extra running processes after test completed: {u'doas <defunct>': 1, u'ps': 1, u'sshd': 1}

Example:
https://github.com/dw/mitogen/pull/658/commits/90d51fcbbd6eb07f5bdb1bdbf6f57ed97013401c this commit passed travis
The commit right after to remove debug logging again failed travis: https://github.com/dw/mitogen/pull/658/commits/e1382861854f38b1736ac598eb70e58beb341c08
even though previously without -vvv travis passed here: https://github.com/dw/mitogen/pull/658/commits/e85720f4d5cdff59d952eae67ec6bf85702a10ba
It seems unrelated to changes made in the PR, but will need to investigate further to be sure

Duplicates #694


Created Hangman project in python and CountofWord in java

PR accepted @sumit-awasthi
Successfully merged to HacktoberFest_22 repo.
🚀🚀👍


updated readme and added action input detail file

added all the details of the action in the readme
added input details in Action_inputs.md
create-secret part is now optional

Removing myself from the reviews.. I was more interested in the implementation side of things.. I'll take a look at your other PRs. 😄


CUDA_LIBRARY_PATH on Ubuntu

Some users of RustaCUDA have found that setting CUDA_LIBRARY_PATH isn't sufficient to allow them to build cuda-sys: https://github.com/bheisler/RustaCUDA/issues/15
I ran into a similar problem while setting up my Travis-CI builds for RustaCUDA on an Ubuntu VM which might be related. If I set CUDA_LIBRARY_PATH to /usr/local/cuda-8.0/targets/x86_64-linux/lib, it could find libcublas.so and libcudart.so but not libcuda.so (which is in /usr/local/cuda-8.0/targets/x86_64-linux/lib/stubs for some reason).

Is there a good solution to this yet?

Setting
export C_INCLUDE_PATH="/usr/local/cuda/include"
export LIBRARY_PATH="/usr/local/cuda/lib64"

works for me on Ubuntu 16.04 and 18.04. I don't have CUDA_LIBRARY_PATH set.

Changing the path that the GCC linker searches for includes and libraries - that seems like a pretty big hammer. I'd prefer to figure out why CUDA_LIBRARY_PATH doesn't work and fix cuda-sys, if possible.


implement /operations/:asset_code/:asset_issuer endpoint

fixes #392

a test related to effects is failing.. do you think is due to the changes of this PR?

Sounds similar to https://github.com/stellar/go/issues/396

@bartekn the only thing that pops in my mind is that some scenario are not reset correctly after some tests.. i've changed the scenario for some operations tests as you can see in the diff.. any idea about fixing it?

CI is green! :heavy_check_mark:
Mike Fair ask me to extend the new query with filter only by asset_issuer and not by asset_code case, i will work on it.

@bartekn can you review the changes? thanks.

This endpoint, as currently designed is not something I'm willing to merge.
It's simply unclear to me what "it would be nice to have an endpoint exposed by horizon to retrieve all the operations regarding a particular assetCode/issuer pair" concretely means.  For example:  Why aren't allow_trust operations being included in the result set?  Surely they do "regard" the asset being trusted.  This issue is a blocker.
Other issues:

/operations/assets/:asset_issuer/:asset_code  violates our conventions for building endpoints in horizon.
An asset at present can only be specified on the query string using the type/issuer/code triplet.  Before we start representing assets in the path we need to agree upon the format.
The nesting is wrong even is we did have that agreed upon format;  If anything it should be /assets/:asset/operations
No docs 😛

I've got an interest in seeing this functionality integrated and have helped others asking how to achieve similar results (though most folks are looking for the all the current trustlines of an asset; some of the people, like myself, also need operations/payments/effects for an issuer's asset(s)).

Why aren't allow_trust operations being included in the result set?

I definitely agree any operation involving the asset ought to be included (change_trust, allow_trust, mange_offer, payment, path_payment, all of them); /payments could be similarly extended to involve only operations creating a transfer of the asset.

what "it would be nice to have an endpoint exposed by horizon to retrieve all the operations regarding a particular assetCode/issuer pair" concretely means.

As for the utility of getting "operations involving an asset", issuers and workflow authors can find all sorts of great uses for this kind of a filtered feed.  When you're the issuer of an asset and you're writing code for the community of folks dealing in that asset, getting a filtered stream of operations for the asset is exceedingly useful.  The same goes for the /payments and /effects feeds, at which point it seems weird to exclude /transactions but I'm not going to make a fuss over it.
Some examples off the top of my head:

if you have a rule that says "Only Authorized Accounts can make offers to sell/buy this asset", there's no native way to enforce an "authorized buyers/sellers" list (if you're trying to create a "Service Coin" controlling which accounts can deal in the side of the coin you need helps prevent fraud).  Revoking the trustline authorization of any account that executes a manage_offer operation to buy/sell the asset (breaking the Issuer's rule) is one way to create that effect.
If you "require authorization", seeing the "change_trust" operation can inform you of the account id to begin the authorization workflow.
If you are trying to create a visualization graph for how the asset has changed hands over its lifetime, the feed of operations filtered just for that asset makes your life much easier.
If you are trying to set up some kind of "smart contract" that uses the transfer of an asset from one account to another to cause some kind of reactionary effect to happen somewhere else in the ledger or even off chain (e.g. if an asset is being used to track what account currently controls the ownership or authorized access to another system (like a 'dealer button' in a poker game), seeing the asset transfer operation come through can trigger updates in the other systems; I have a process where an account sending an asset to another account triggers updating a trustline on the issuer account. Horizon makes this kind of detection cumbersome as inspecting ledger events by asset is not an exposed concept).

More generally, "Accounts" that hold many "Assets" are how individual holders might see and view the utility of the ledger; but on the service/asset issuers side the worldview is reversed.  The "Asset" has many "Trustors", or clients. The Issued Asset Object has many "balances" that are its Holders.  It also has "offers".  It'd be great if it could have "custom data" too.  Many folks have noticed a lot of utility in creating a "type 2" account object for creating a registered assets concept in the system.  Issuers and Application authors, care about the many accounts transacting in their asset.  Horizon currently offers little assistance to them on this front.

The nesting is wrong even is we did have that agreed upon format; If anything it should be /assets/:asset/operations

I definitely prefer this approach too.  It mirrors /accounts/:accountid/operations which reinforces the idea of "assets" as a first class object in the system.

An asset at present can only be specified on the query string using the type/issuer/code triplet.

/assets/native/operations?
while alphanum4 and alphanum12 are mutually exclusive types, keeping type in the asset id is prudent.
/assets/credit_alphanum4/:asset_issuer/:asset_code/operations
/assets/credit_alphanum12/:asset_issuer/:asset_code/operations

Is there any symbol you could see approving to mean a "wildcard" for the asset_code?  This way an Issuer could easily query for all the operations of all the assets it issues processed through the same code base?
This assets path fits perfectly with another feature many folks need/want:
/assets/type/:asset_issuer/:asset_code <--- An "account like" result for the asset
/assets/type/:asset_issuer/:asset_code/balances <--- All the current holders of an asset
/assets/type/:asset_issuer/:asset_code/balances/:accountid <--- A specific holder's trustline

I have a bad feeling about performance of new queries.

A table could be created like the effects/operations_participants table for accounts if this really becomes an issue,
custom expression indexes can absolutely reach inside jsonb columns
Creating an "assets" table like accounts to give Assets a numeric 'id' would help a lot

One thing to keep in mind is that if they are being used, then people are finding them useful and finding a way to make the lookups fast is worth exploring; if they are somewhat slow, but provide functionality that is useful to some, not possible without the queries, and less frequently used, then the performance impact is not often actualized.
This feature, and the feature to look up all the holders of an asset by issuer or issuer/asset_code, are the two biggest missing features I think Horizon should be providing that I inform people they have to run their own Horizon node and add their own queries to get.

@MikeFair thanks for the exhaustive explanation.

Why aren't allow_trust operations being included in the result set?

i'm not filtering the results using a particular operation type so all the operations are retrieved at the moment.
let's agree on an url convention so i can update the PR.

@phra @nullstyle @bartekn
@nullstyle Thanks for bringing up the points to enhance the feature.
After thinking about it some more, the use cases I've seen, and what information/usage the users and devs have at the time of the initial request, and what they would want to be able to access, I believe:

the "triplet" should move type to the end, making it: /assets/:asset_issuer/:asset_code/:asset_type
End users will be told the issuer/asset_code they are looking for, but the type is more of an 'asset property' than an 'asset identifier'.  Long story short, the only useful 'asset_type' at the moment is the keyword 'native' to distinguish it from the others.  The alphanum4/12 distinction is fairly pointless for identification purposes.  By placing it on the end, it can regularly be left off the path without causing any ambiguity.  The question then is what do to about 'native' which I address below.

the /operations feature should be available at every level.
/assets/operations <--- would exclude inflation, manage_data, set_options (maybe optional here)
/assets/:asset_issuer/operations <-- all operations for assets involving the specific asset_issuer
/assets/:asset_issuer/:asset_code/operations <-- all operations for all types of that issuer/code pair
/assets/:asset_issuer/:asset_code/:asset_type/operations <-- all operations for the specific asset

The intent is to eventually add /transactions, /payments, and /effects endpoints as well

The question then becomes how to handle "native"
a) Make "native" a magic string for the issuer field in the path
b) Use: asset_issuer = networkId / network master account ; asset_code = XLM; asset_type = 'native'
c) Create /assets/native and /assets/issued/:asset_issuer/:asset_code/:asset_type for the paths
d) Exclude 'Native' from the concept of the /assets endpoint ensuring all assets have an issuer/code
e) Don't use '/' to make "paths" but instead use an encoding convention for a single path element string
This would be like /assets/[:asset_issuer],[:asset_code],[:asset_type]/operations
and /assets/native/operations
The format is an 'opaque string encoding convention' that must be 'resolved' to identify an asset(s)

I don't know what the intention is for the future of asset types, but I think they should be removed as part of an asset's identification; for native I'd prefer to see the networkId used as the issuer and 'native' used as the asset_code, or something else that keeps with the convention.
If the intention is for the issuer to reuse the same asset_code and have many "types" of it then this is probably better handled by extending the asset/trustline record data, instead of including the asset_type as a prefix in the asset identifier.  The current types 'credit_alphanum4/12' imply a correlated type 'debit_alphanum4/12'.  I think this would be better handled by having a 'credit_limit', 'credit_balance', and 'debit_limit', 'debit_balance' properties of the trustline.
I get the necessity of an asset's type to identify the code workflows and rules to apply when processing operations/effects; but I steadfastly disagree that the system should encourage/allow an account to hold the same issuer/asset_code pair and multiple asset_types.  The confusion to users would be endless.  If an account cannot hold multiple of the same issuer/asset code pair then :asset_type becomes a 'property' of the asset/trustline and not a typical path 'identifier' that users are regularly concerned with.
For example, I don't usually distinguish between credit card USD, debit card USD, check USD, and cash USD.  They are all various types of USD, and we don't usually consider those distinct types until we first think of the currency we're looking to deal in.  United States/USD/credit_card, and United States/USD/bank_loan are far more intuitive than credit_card/United States/USD, and bank_loan/United States/USD.
It appears to me that forcing the inclusion of the :asset_type into the path ahead of issuer/asset either:
(1) makes developers have to predict information they cannot know in advance;
(2) are redundant because the asset_code and issuer are distinct;
(3) if not distinct, and holder's are allowed to have multiple assets using the same issuer/code pair, then dealing with these assets becomes much more confusing and difficult in practice
Thanks for the consideration,
Mike

@nullstyle

Why aren't allow_trust operations being included in the result set? Surely they do "regard" the asset being trusted. This issue is a blocker.

with /operations/assets/:asset_issuer/:asset_code you will retrieve every allow_trust related to a specific asset using the following query, instead with /operations/assets/:asset_issuer you will retrieve every allow_trust related to that issuer using this one, so also allow_trust operation related only to the issuer and not specific to an asset.
can you elaborate more and help me out to understand your question?
PS: btw i need this feature in order to avoid to tap in my own horizon db instance and just use horizon apis, so let's discuss on how do we want to proceed with it.
/cc @MikeFair

One thing I think we can agree on is the endpoint should be changed to
/assets/:asset/operations
And remove the /operations/assets/* references.
And to add one more level, :asset_type
That means:
/assets/operations <-- all operations involving an issuer
/assets/:asset_issuer/operations
/assets/:asset_issuer/:asset_code/operations
/assets/:asset_issuer/:asset_code/:type/operations
After that, the only discussion left is what, if anything, to do about the
native asset.
On Mon, Apr 16, 2018, 2:52 AM Francesco Soncina<EMAIL_ADDRESS>wrote:

@nullstyle https://github.com/nullstyle
Why aren't allow_trust operations being included in the result set? Surely
they do "regard" the asset being trusted. This issue is a blocker.
with /operations/assets/:asset_issuer/:asset_code you will retrieve every
allow_trust related to a specific asset using the following query
https://github.com/stellar/go/pull/398/files#diff-b4ca44f9b397d755f06e2cb7e66409cbR110,
instead with /operations/assets/:asset_issuer you will retrieve every
allow_trust related to that issuer using this one
https://github.com/stellar/go/pull/398/files#diff-b4ca44f9b397d755f06e2cb7e66409cbR128,
so also allow_trust operation related only to the issuer and not specific
to an asset.
can you elaborate more and help me out to understand your question?
PS: btw i need this feature in order to avoid to tap in my own horizon
db instance and just use horizon apis, so let's discuss on how do we want
to proceed with it.
/cc @MikeFair https://github.com/MikeFair
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stellar/go/pull/398#issuecomment-381544582, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACMqLWN191-Cn9Vn5VzHeoMwTWM15TLbks5tpGnpgaJpZM4TMu1o
.

@MikeFair

/assets/operations <-- all operations involving an issuer

where is the issuer parameter? do you mean assets?

@MikeFair https://github.com/MikeFair
/assets/operations <-- all operations involving an issuer
where is the issuer parameter? do you mean assets?

There isn't one for that endpoint; that literally means all operations for
assets.

@MikeFair ok.
@nullstyle do you agree with the proposed changes so i can proceed to implement them?

sorry for the bump, but we really need this feature implemented in horizon.
retrieving operations regarding a specific asset (asset_code + asset_issuer pair) is a fundamental feature and there were often discussions about this topic on the stellar slack.
can someone of the team give out some ideas on how do we want to proceed? /cc @bartekn /cc @nullstyle

@phra While I have a pending, and long response to all the discussion that has happened, I want to give you a heads up about how to proceed:  I think you should fork horizon and do the work you need to do to unblock yourself.
There are still plenty of design discussions that we need to consider and I simply don't have the time to properly vet your work or integrate into horizon as a whole.  It appears that you've got the most pressing needs for this to be included and I don't think we have any competing solutions in progress;  In the meantime I believe you should maintain your own fork.

i think we will switch to a graphql endpoint exposing core and horizon dbs in readonly mode using postgraphile like in this repository: https://github.com/TinyAnvil/stellar-graphql-docker
atm it's an easier solution compared to managing our own fork of horizon. also because we lack go devs :man_shrugging:
i will reconsider to use an horizon fork only if we will experience problems with postgraphile.
for the moment let's leave the PR open.

@phra Using the graphql solution looks like a great idea.
Instead of leaving this PR open, let's instead reopen it when we continue the discussion.  It's effortless to do so and we can get tasks with incomplete technical designs off of the lists we scrub each sprint.

The existence of those other tools doesn't the warrant closing this PR.
And at the moment I doubt this PR will get reopened later because I've seen no evidence that old closed PRs ever get revisited.  There's nothing that will tell anyone to come back and look at it.

The search engine will bring people back to the issue, and you and phra are free to continue the conversation here as long as you'd like, of course.  He opened the issue and it sounds like he's got a better path in front of him and it doesn't seem like he'll be contributing much to the code.  I certainly don't have the time to work with him on the issue, unfortunately.

How many other closed PRs have promises to get reopened later when people "get around to discussing them"?

To what promises are you referring?  This discussion seems to be taking an accusatory turn and I'm not keen to engage.  Let me say my piece and I'll be out:  While we work to solve everyone's problems and incorporate everyone's feedback, sometimes we can't incorporate a PR and will close it.  By clicking the merge button on a pull request I am vouching for the code; Until I'm happy with it I won't give my vote, and I don't promise my vote until I see what I'm voting on.  That sounds a little too aggressive for my tastes but I don't know of a softer way to be strictly accurate.  We're dealing with money in this project, stuff of real world impact, so some careful scrutiny of any addition seems warranted.
Now, in this specific case we've got no one to push the code forward, so it seems fine to close it.  We can always open it up later when there is someone to build the code and press the project forward.

or outright reject it and let the community know this isn't a feature you'll take from them

I'll pick the third option; I'll let the feature cook for longer and perhaps on the next attempt it will be up to my personal quality bars with minimal intervention.  Listen, I can understand that not getting your particular need met by the official release is frustrating and I hear and am sorry for my part in that frustration.  We're working to bring more engineers into the team to help improve on our ability to make changes to our fork of horizon, but for the meantime we're a bit (that is to say, lot) short on platform team engineering.  I wish I had more time, skill, eloquence, and social energy to properly engage on every issue up for inclusion into horizon.  I don't and I apologize for that deficit.  I'm still not willing to compromise on the API's quality, as I personally define it.

How about redoing it to make "asset identifiers" a query string filter on the /operations path?

This is the least offensive way, in my opinion, at the moment for filtering an operation by assets.  It doesn't fundamentally change the objections I have with this PR.
@MikeFair here's what I would recommend:  Open a new issue in which the community can discuss your specific use case.  API design isn't supposed to happen in pull requests.  Attract an audience and come up with a design.  Make reference to this pull request to give other readers a historical path to follow should they care.  From that design issue the feature can proceed.


Show filtered stats

This PR fixes #105866

Hi @isidorn
I've created a PR. Let me know if there's anything missing or any changes to do.
Thanks.

@pfongkye thanks a lot for this PR. I will review it in detail and test it out tomorrow

@pfongkye thanks for your PR, I tried it out and seems to work good. Here's my feedback:

You are bringing back layout code for the shrink and grow of the Repl Filter, however the repl filter does not properly shrink and grow - it does not work with your changes. What I suggest is to remove this code completly from this PR and if you would like to tackle the shrink / grow issue please create an additional PR and test it out.
So from the above this PR should only contain the Badge which shows the number of filtered items work
Once you filter for some term that is nonexistent the debug console will be empty but the badge will not show anything. I suggest to show "showing 0 of N". That will make it more clear. And I suggest to also change that in problems view to be consistent

Thanks!

@isidorn
Thanks for the feedback.
I'll make the necessary changes and create another issue for the shrink/grow problem. I'll keep you updated.

Great thanks. Just ping me once it is ready for review again.

@isidorn  friendly ping to let you know the PR is ready for review.
I created an issue for the layout: #107230

Looks great! Merging in and I will push some polish commits on top of this work.
Thanks a lot for your work!

Pushed some minor improvements via https://github.com/microsoft/vscode/commit/a47bf985eff0f2c0ae190d606ecc1a79054a02de

Pushed some minor improvements via a47bf98

@isidorn  I like the refactoring since it's cleaner now. However, I noticed that a scenario has been left out.
When you pause the debugger and begin to type in the filter, the badge will be updated.  However, if you hit continue on the debugger, the badge will not be updated, showing x of n will remain the same even though there are more lines appearing.
I used the following listener for this scenario: this._register(this.tree.onDidChangeContentHeight(() => this.refreshReplElements(false))); but maybe there is a better solution.

@pfongkye great catch. I have tackled this via 8e8267805f


Support buffer-oriented callbacks

If the API supported buffer-oriented callbacks (int write_buffer(const uint8_t *buffer, size_t size, int32_t timeout_ms, void *arg) and int read_buffer(uint8_t *buf, size_t size, int32_t timeout_ms, void *arg)), it would be easier to take advantage of hardware FIFOs and DMAs to reduce CPU load.
I worked around the byte-oriented API by having the write_byte and read_byte callbacks read/write into an intermediate buffer and performing the actual transfer once the correct number of bytes had been requested. This works but is a little clunky and is less efficient than a zero-copy transfer of the buffer that already exists in nmbs->msg.buf.

Yes, I thought about it when writing the library, but at the end I opted for keeping the interface and the internal code simple, leaving the choice of buffering (albeit in a less efficient way) to the end user.
Plus, in a typical modbus application you are not going to move a lot of bytes anyway, so I don't think the overhead should be that impactful.
Anyway, If implementing these 2 platform callbacks does not upset the library too much, I would be happy to receive a PR of this feature

Here is my idea. It works in my tests (it's inefficient due to several calls to recv, but that can be improved separately). If it looks like an acceptable approach I'll make a PR which also updates the docs
https://github.com/jonathangjertsen/nanoMODBUS/commit/b8129ff439559933c51ab92176f8311fc5c6bf89

A the end I bit the bullet and decided to migrate the read/write interface to multi-byte functions only, inspired by your code. You can find the code + docs in the multibyte_platform_funcs branch.
Let me know what you think of it, as an user of the library.

Looks very good! This would let me remove a couple hundreds of lines of wrapper code. It would also be more robust since the wrapper doesn't need to anticipate the number of times the nanomodbus library will call the read callback.

Fine, closing this with 7e6ce4f4fdc767d31b65c5edec6e693821a37abd


a11y inspect: contrast report should either show AA or AAA, not both, aka contextually shown

currently does a blanket report of contrast, when it should be contextual to font size

I submitted #204 to address contextually displaying contrast testing results based on WCAG's guidelines for normal and large text.
This guideline is chosen based on font size and weight criteria, and is then used to compute a AA and AAA rating for the rules that pertain to that size classification of the selected text, so that the metatip can display the relevant pair of results.


Typo on blog post (v1.9 release notes)

Sorry if this is in the wrong repo. It's not clear to me where to file issues related to the blog or where to view the source documents which contain its content in order to send a fix PR. Will someone inform me?
At https://deno.com/blog/v1.9#allow-lists-for---allow-env-and---allow-run it states:

For example --alow-read=/tmp grants read permission only to the ./tmp directory.

The first path is absolute and the second is relative. Instead, it should state one of the following:

For example --alow-read=/tmp grants read permission only to the /tmp directory.
For example --alow-read=tmp grants read permission only to the ./tmp directory.

Additionally: The linked scripts in the example code block in that section return 404s for me:
$ deno run --allow-env=DEBUG,LOG https://deno.com/blog/v1.9/env_permissions.ts
$ deno run --allow-run=deno https://deno.com/blog/v1.9/run_permissions.ts

https://deno.com/blog/v1.9/env_permissions.ts
https://deno.com/blog/v1.9/run_permissions.ts

@jsejcksn Thanks for the reports! Now these are fixed.

Hi @kt3k:
Thanks for updating the paths.
There still seem to be two unresolved issues:

The script URLs still return 404 errors:

% deno run https://deno.com/blog/v1.9/env_permissions.ts
Download https://deno.com/blog/v1.9/env_permissions.ts
error: Import 'https://deno.com/blog/v1.9/env_permissions.ts' failed: 404 Not Found

% deno run https://deno.com/blog/v1.9/run_permissions.ts
Download https://deno.com/blog/v1.9/run_permissions.ts
error: Import 'https://deno.com/blog/v1.9/run_permissions.ts' failed: 404 Not Found

In regard to my initial question:

Sorry if this is in the wrong repo. It's not clear to me where to file issues related to the blog or where to view the source documents which contain its content in order to send a fix PR. Will someone inform me?

Is this the right place to post blog-related issue reports in the future? Also, how can I send a PR to fix issues in the blog?

For 1. we updated the urls of scripts

https://deno.com/blog/v1.9/env_permissions.ts -> https://deno.com/v1.9/env_permissions.ts
https://deno.com/blog/v1.9/run_permissions.ts -> https://deno.com/v1.9/run_permissions.ts

Please try these commands.
deno run --allow-env=DEBUG,LOG https://deno.com/v1.9/env_permissions.ts
deno run --allow-run=deno,echo https://deno.com/v1.9/run_permissions.ts

For 2. we're currently maintaining the blog source code in a private repository, and there's no explicit place for getting feedback for it. I'll talk about this with core members. But for the moment, please create issues in this repository.


Set default locale globally in app

It would be awesome if we could set a default locale for arrow globally. Right now it's hardcoded to en_us in several places in the code. If we could set a global default then it would be easier to integrate with packages like Babel and Flask-Babel.
I'm imagining an API like this:
import arrow
from .myapp.i18n import get_locale

# It can be set statically...

arrow.set_locale_default('sv_se')

# ... or dynamically like this:

def get_arrow_locale():
    return get_locale().lower()

arrow.set_locale_default(get_arrow_locale)

Agreed. A PR for this would be helpful if you have the time

I took a whack at this ticket and solved the issue with a global default variable that gets set with a call to arrow.set_locale_default(), but a stranger on the internet told me it was a bad idea and could lead to trouble. I'd really like this feature implemented... does anyody have any bright ideas on how to solve this without a global variable?


Do not delete services first before saving them in the management app

Port of https://github.com/Jasig/cas/pull/1264 for master

Added the gretty plugin to mgmt app
Fixed issues with context scans and bean resolution
Fixed a bug with oauth callback service where auto-insertion of the callback could not be loaded by the management app due to caching. Forcing a reload.

Requires a new inspektr release, 1.3 to protect against NPEs when services are saved automatically and there is no spring security context available yet on startup.

When creating a new service, it was generating an error, right? I don't remember checking that.
Regarding 3), it may explain: https://github.com/leleuj/cas-pac4j-oauth-demo/issues/21
+1

1.3 Inspektr is now available in central. Merging.


[3.0] Optimize InvokeTelnetHandler code format

What is the purpose of the change
see more information from #7813

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #7839 (87bd8c0) into 3.0 (97aec36) will decrease coverage by 0.40%.
The diff coverage is 65.00%.

@@             Coverage Diff              @@
##                3.0    #7839      +/-   ##
============================================
- Coverage     58.16%   57.76%   -0.41%
+ Complexity      402      401       -1
============================================
  Files          1080     1080
  Lines         43799    43803       +4
  Branches       6530     6509      -21
============================================
- Hits          25477    25304     -173
- Misses        15492    15664     +172
- Partials       2830     2835       +5

Impacted Files
Coverage Δ
Complexity Δ

...g/apache/dubbo/qos/legacy/InvokeTelnetHandler.java
70.67% <65.00%> (-2.20%)
0.00 <0.00> (ø)

...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java
36.00% <0.00%> (-45.34%)
0.00% <0.00%> (ø%)

...va/org/apache/dubbo/rpc/support/AccessLogData.java
47.88% <0.00%> (-42.26%)
0.00% <0.00%> (ø%)

...ng/transport/dispatcher/all/AllChannelHandler.java
62.06% <0.00%> (-34.49%)
0.00% <0.00%> (ø%)

...bo/config/event/listener/LoggingEventListener.java
37.50% <0.00%> (-25.00%)
0.00% <0.00%> (ø%)

...ntext/event/AwaitingNonWebApplicationListener.java
48.48% <0.00%> (-24.25%)
0.00% <0.00%> (ø%)

...dubbo/common/status/support/LoadStatusChecker.java
46.15% <0.00%> (-15.39%)
0.00% <0.00%> (ø%)

...ng/transport/dispatcher/WrappedChannelHandler.java
47.82% <0.00%> (-15.22%)
0.00% <0.00%> (ø%)

...mmon/threadpool/support/AbortPolicyWithReport.java
85.00% <0.00%> (-12.50%)
0.00% <0.00%> (ø%)

...in/java/org/apache/dubbo/common/utils/JVMUtil.java
81.13% <0.00%> (-11.33%)
0.00% <0.00%> (ø%)

... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97aec36...87bd8c0. Read the comment docs.


interactive bots: Create Mention bot.

GCI Task --> https://codein.withgoogle.com/dashboard/task-instances/5632906363928576/

As far as I can tell, most of the feedback so far was addressed (or even all of it). I'm approving the related task to let Viraat start working on something else.

Merged!  Thanks @ViRu-ThE-ViRuS @alenavolk @roberthoenig


getting event details from log_entries

I am new to pygerduty and still exploring.
I have a case were i need to get the event details from a log entry...
I know get_trigger_log_entry() gets me the details but the return i am getting is just
<LogEntry: contexts=[], created_at=u'2016-05-02T11:42:42Z', agent=<Container: type=u'service'>, type=u'trigger', id=u'someID', channel=<Container: type=u'email', summary=u'SomeSummary'>>
Is there a way i can completely get this info with pygerduty. The return of incidents.show has the link to
the log entry but does not give me the content of it.
Is there an attribute to get this content that I am missing.
Can some one please help me with my requirement. Thanks in advance.

pygerduty is a pretty thin wrapper around the API and can do most things the API can do. If you want to get a list of LogEntry's from an incident then you could call log_entries.list() on an incident. For example:
incident = pd.incidents.list().next()
for entry in incident.log_entries.list():
    print entry

Let me know if this is not what you're asking.

Thanks a lot for getting back @gmjosack
I will be a bit more specific. I am looking for additional details of my alerts like body of the alerts which i can get from the pagerduty api
https://(SomeDomain).pagerduty.com/api/v1/incidents/(:id)/log_entries/(LogEntry:id)?include[]=channel
is there a pygerduty way of fetching this details. Thanks in advance.

I believe that should work as one of the following:
incident.log_entries.list(include=["channel"])

or
incident.log_entries.show("SOME_ENTRY_ID", include=["channel"])

Thanks a lot @gmjosack that worked.


XEmbed support

FWIW, I took a crack at adding this last night and quickly found resistance in WindowBuilder, which lacks this support for X11.
Unless there was sufficient interest in using XCB or xlib directly, which would not really flow with the Windows/OSX code paths, it seems like this depends upon: https://github.com/rust-windowing/winit/issues/159

I believe I figured this out, and it's not too invasive.  I submitted a pull request for it: https://github.com/jwilm/alacritty/pull/2786


Upgrade to (moved ServerName) alpha releases

We will actually want to merge this as there are incompatible changes in the dev-dependencies.

Published 0.26.0-alpha.2.


react-native-orientation-locker OrientationModule Conflicting with react-native-sensors

Describe the bug

To Reproduce
Steps to reproduce the behavior:
Override OrientationModule when two packages installed.

install react-native-orientation-locker & react-native-sensors
When build in development throwing error as per screen shot above.

Expected behavior
Orientation module name should be renamed or should implement canOverrideExistingModule. It should run with both packages.
Desktop (please complete the following information):

React Native Version: 0.63.4
Device Android, Android simulator
Version latest

Same error ;
I am using
React Native Version: 0.63.4
Device Android, samsung with android 11

Same issue

Same issue

@DanielMSchmidt Can you provide quick fix for this issue ?

Hey guys, while we don't have a fix. I worked around the problem using the previous version.
Work for me.
npm i<EMAIL_ADDRESS>

Hey guys, while we don't have a fix. I worked around the problem using the previous version.
Work for me.
npm i<EMAIL_ADDRESS>
thanks , it works.

Is there any other way to fix it, without forking the whole repository and changing the file names?
https://github.com/react-native-sensors/react-native-sensors/compare/v7.0.2...v7.2.0

Hey folks, I have a PR with the fix, can you please test the new pre-release: https://github.com/react-native-sensors/react-native-sensors/pull/383 and approve if its working as expected

Just so you know, android has the same problems

@DanielMSchmidt Although #383 fixed a build error with Xcode / iOS, this module error still appears on Android. It looks like the module named "Orientation" is taken by org.wonday.orientation.OrientationModule as well as com.sensors.RNSensor (when sensor of name "Orientation" is made).
I would love to make a PR on react-native-orientation-locker because it looks like the amount of changes needed would be smaller, but I'm unsure if they're as active as this repo as been. Hm...

:tada: This issue has been resolved in version 7.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Adding a checking for the first and last verses in passage

Adding a checking for the first and last verses in passage of the same book

Awesome! Well done!


test: System engine checks

Testing compatibility with the system engine

On hold due to failing integration tests - https://github.com/firebolt-db/firebolt-python-sdk/actions/runs/3574475549/jobs/6009786226
I suspect this is due to a known bug on "IF EXISTS".


FEAT-#4664: Finalize compatibility support for Python 3.6

What do these changes do?
Run almost all tests from modin/pandas/test with only a few cases skipped.

[x] commit message follows format outlined here
[x] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] signed commit with git commit -s
[x] Resolves #4664
[x] tests added and passing
[x] module layout described at docs/development/architecture.rst is up-to-date
[x] added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

Thanks @mvashishtha, I think I've addressed all your comments, please take another look!
@devin-petersohn @RehanSD
For reference, here's the set of groupby-related tests which are skipped now because older pandas gives weird exceptions from within our implementation. I decided to skip them instead of trying to fix, because they're mostly edge cases related to zero-rows dataframes IIRC.
To see those failures one has to remove skippings in the test_groupby.py.
========================================================================= short test summary info =======================================================================
FAILED modin/pandas/test/test_groupby.py::test_groupby_with_kwarg_dropna[col_name_multi_by-True] - IndexError: index -1 is out of bounds for axis 0 with size 0
FAILED modin/pandas/test/test_groupby.py::test_groupby_with_kwarg_dropna[col_name+level_name-True] - IndexError: index -1 is out of bounds for axis 0 with size 0
FAILED modin/pandas/test/test_groupby.py::test_groupby_with_kwarg_dropna[col_name-False] - TypeError: 'NoneType' object is not subscriptable
FAILED modin/pandas/test/test_groupby.py::test_groupby_with_kwarg_dropna[col_name-True] - TypeError: Expected tuple, got str
=============================================================== 4 failed, 12 passed, 85 warnings in 54.51s ==============================================================


Upgrade Arcmutate 1.1.2 -> 1.1.3

This PR contains the following updates:

Package
Type
Update
Change

Arcmutate
build
patch
1.1.2 -> 1.1.3

[ ] If you want to rebase/retry this PR, check this box

Warning
Renovate's suggested commit message is being replaced with improved initial commits to enable automerging. As a side effect, these suggested commit messages might have changed. Consider comparing the initial commit message and this message to determine the most suitable one. Please leave feedback in #sys-renovate.

Suggested commit message:
Upgrade Arcmutate 1.1.2 -> 1.1.3

Thanks for testing 😄!


Document Mamba in installation manual

The installation manual does not mention mamba at all: https://i4ds.github.io/Karabo-Pipeline/installation_user.html
The readme.md currently only states, which is not too helpful for novice users:

Therefore, we recommend using the libmamba solver for installation.

We need a simple, easy to follow installation description. This means:

[ ] Explain how to install conda, set up python environments, use libmamba, all step-by-step
[ ] Either align readme.md with documentation or instead link from readme.md to documentation

I'd expect a manual to look like:
Initial installation
wget ...
bash Miniconda3-latest-Linux-x86_64.sh
conda install -n base conda-libmamba-solver
conda config --set solver libmamba
conda create -n karabo-env python=3.9
conda activate karabo-env
conda install -c i4ds -c conda-forge -c nvidia/label/cuda-11.7.0 karabo-pipeline

Update an existing installation
bli bla blubb

https://docs.conda.io/en/latest/miniconda.html#linux-installers
We should probably guide people towards a specific miniconda installation: Linux x64 with Python 3.9, no?

See #287 why this is important. The current documentation apparently didn't guide André towards mamba.

done in #291

Hmm.. it's still inconsistent in README.MD. Can you either remove those installation sections or synchronize it with the manual?

Installation in -batch mode and into a certain -path (which might make sense for CSCS)
bash Miniconda3-py39_22.11.1-1-Linux-x86_64.sh -b -p /scratch/miniconda3


BUGFIX Installer redirect to home/ (without domain)

This fixes a bug where the installer redirects to home/ ('home' as the domain) as the url as opposed to localhost/home.
To reproduce:

Use chrome (untested in other browsers)
composer create project silverstripe/installer
Run through the installer

Expected:

Silverstripe installs and it takes you to the success page

Actual:

SilverStripe installs and takes you to a different domain (ie. 'http://home')

The problem seems to be, any URL starting with // (two slashes) is normalised by the browser to an absolute URL by removing both slashes meaning //home becomes just home (as in http://home)

As this is the installer, I don't yet have a .env. However, post-install my SS_BASE_URL is being set to my hostname correctly.
Pre-install, it tries to work out a relative base url, which it correctly does as /. However, on the line I fixed, it also concatenates the BASE_URL with another / and then the URL segment 'home' (ie. //home).
The redirect to that page happens in the browser and chrome is treating //home as its own domain (ie. http://home) and i'm guessing other browsers would too.
The extra / which is being added on the fixed line needs to remain in case a user is installing silverstripe into a directory. eg. http://localhost/my-website where BASE_URL would become /my-website.

I'm just thinking there might be a bug in includes/constants.php.
https://github.com/silverstripe/silverstripe-framework/blob/3b06385b7d4b7aab0408e21cf62668da35d3b210/src/includes/constants.php#L99-L153
That logic is meant to remove the trailing slash. If there's a problem in the way BASE_URL is set, it would be better to fix it there.


Update storage-c-plus-plus-how-to-use-queues.md

edit the library reference

Hi @zhimingyuan, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (zhyuan). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

Sorry, I will use azure-content-pr to submit my pr, will close this one


Add new issue templates following contributing guide

Codecov Report

Merging #80 (a845eac) into main (e77bbcf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   94.74%   94.74%
=======================================
  Files          13       13
  Lines        1826     1826
=======================================
  Hits         1730     1730
  Misses         96       96

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add support for title and message in Android

iOS ActionSheet has native support for optional title and message props, which look like this:

This adds support for a similar UI in the Android version:

@brentvatne this looks good

Let's get this in! cc: @brentvatne

Is this PR or some other method of support for the title prop likely to be added anytime soon? seems to have stalled

@chris-divvito if you're willing to fix this merge conflict and make sure this is working correctly, I'd be happy to merge it in!

if someone wants to test this, it should be good to go: https://github.com/expo/react-native-action-sheet/pull/78

Is there a problem with this PR? I'd love to see this merged.

@JulianKingman I'll test this tomorrow and merge it in then if it works.

Closing due to #78


Add support for controlled gates to mpl drawer

Summary
This commit adds support to the mpl drawer for drawing gates with an
arbitrary number of controls on them. Currently the drawer incorrectly
represents these gates as a large multiqubit custom gate. This fixes
that so it shows the original gate and then adds the controls to it.
Details and comments
Fixes #3763

When
qr = QuantumRegister(3, 'q')
circuit = QuantumCircuit(qr)
circuit.append(HGate().control(2), [qr[0], qr[1], qr[2]])
circuit.draw('mpl')

I'm getting the following error:
qiskit-terra/qiskit/visualization/matplotlib.py in _draw_ops(self, verbose)
    844                         'ccx', 'cx', 'cz', 'cu1', 'ccz', 'cu3', 'crz',
    845                         'cswap']:
--> 846                     disp = op.op.base_gate_name
    847                     num_ctrl_qubits = op.op.num_ctrl_qubits
    848                     num_qargs = len(q_xy) - num_ctrl_qubits

AttributeError: 'ControlledGate' object has no attribute 'base_gate_name'

Yes base_gate_name got removed in #3773. This should now be base_gate.name
I think it's fine to do a box now and refine later if possible.

Ok, I'll update this to adjust for that api change


Fix scaledownhandler lookup duplicate handling

Just something I happened to notice when examining Eclipse's redundant null check warnings. Not tested, nor have I run into this or fully looked into what this even does. But initialRef was never assigned any other value than null, and the fix here looks kind of obvious.

@andytaylor  can you comment?

This was my code after all


New Feature: add --type=template to onyo get

The parent issue is #673
Allow onyo get to return data about templates. The type should be called template. This issue supplants #552.
All templates already must be valid YAML files, so all template content is also queryable. This could be quite handy if someone is managing a large collection of templates.

only template files should be considered; no directories

this means that one cannot query directories under the templates dir. I am comfortable with this limitation

Pseudo Keys:

onyo.is.asset: False
onyo.is.directory: False
onyo.is.template: True
onyo.is.empty: True or False depending if the template contents are empty (see #674)
onyo.path.relative: path relative to the template directory (.onyo/templates) rather than repo root
onyo.path.file: path relative to repo root
onyo.path.parent: path to parent directory relative to the template directory

Tasks

[ ] add to onyo_get
[ ] add to onyo get
[ ] shell completion
[ ] help text
[ ] tests

Open questions:

should -i and -x be honored?
should one be able to pass template files to onyo set and onyo unset? (see meta issue)

I had the same reaction, but it /must/ be true, because otherwise we wouldn't be able to set any keys/values into it.
Thus templates must be valid YAML.

It should be considered what happens for a file .onyo/templates/readme.md.

If that's used as a template, it will fail. If it's not intended for that it should be .onyoignored.

The main use-case was "close to yaml".

I get were that was coming from, but it would only ever make sense, if onyo new was used interactively with --edit and no other option given (including no layering template). I don't think we should consider this. It would mean to have this thing work with exactly one command with very particular options and fail in every other usecase for a template (with quite a bit of effort in implementation to allow for it in the one usecase where it could work).


CRUD App review

Does the Kotlin driver make I you use models like that, how do you support dynamic schema?
getenv is a very bad way to get your URI - it's not secure
I'm missing any error handling.
You don' check the connection works in setupConnection.
Why createDatabase? and what on earth is maxDocuments?
should updateMultipleDocuments be updateAllDocuments - or add a filter?
Why are you using $regex in a simple tutorial - we don't really advise using $regex in most cases.
Paging with Skip and Limit is pretty controversial too although it's almost OK here.

@mohit-sharma-87 this repo has a master branch that should be main. Better rename that.

Read from a file, or hard code.
Env is a dangerous mistake that keeps getting propogated.
On Tue, 13 Jun 2023, 12:36 Diego Freniche, @.***> wrote:

@.**** commented on this pull request.
In src/main/kotlin/Setup.kt
https://github.com/mongodb-developer/kotlin-driver-quick-start/pull/1#discussion_r1227978847
:

   listAllCollection(database = database)

   dropCollection(database = database)

   listAllCollection(database = database)

}
+}

+fun setupConnection(

databaseName: String = "sample_restaurants",
connectionEnvVariable: String = "MONGODB_URI"
+):

   MongoDatabase {

val connectString = if (System.getenv(connectionEnvVariable) != null) {

   System.getenv(connectionEnvVariable)

@johnlpage https://github.com/johnlpage I think security here is beyond
the scope of this Quick Start example. Also, getting the connection string
from an ENV variable is way better than hardcoding it. Which way of
accessing these kind of secrets will you propose here? Thanks
—
Reply to this email directly, view it on GitHub
https://github.com/mongodb-developer/kotlin-driver-quick-start/pull/1#discussion_r1227978847,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABB6CVWMY5OPU22YHT3AZPLXLBGCPANCNFSM6AAAAAAZC6DKRQ
.
You are receiving this because you were mentioned.Message ID:
<mongodb-developer/kotlin-driver-quick-start/pull/1/review/1476936318@
github.com>


Start adding PHPUnit tests and Travis integration

@tyler-sommer Please review this and let me know if this is a direction you'd be willing to take Packages toward.
This adds a few PHPUnit tests to start, with the test configuration, and allows Travis to run these automatically when you push to Github.

@bdandoy Could you please take a look at this and (perhaps) help get the package maintainer's feedback?

Quoting the developer, who cannot reply at this moment: "tell him it needs to be spaces instead of tabs, and to change the namespace to simple Terramar\Packages\Tests"

@tyler-sommer @jardayn The new files have been updated with spaces for formatting, and tests were moved to the "Terramar\Packages\Tests" namespace.


Update jablotron to 0.1.5

Please update my adapter ioBroker.jablotron to version 0.1.5.
This pull request was created by https://www.iobroker.dev c0726ff.

RE-CHECK!


Json serialize

By default, bayes.vb.MVN and bayes.vb.Gamma are not serializable with JSON. This PR provides a matching encoder and decoder to enable this.
IMO this is very handy when you want to easily read and write intermediate results to disk, e.g. in a pydoit-workflow where the posterior from one experiment is the prior of a subsequent one.

If that is too specific, let me know. This BayesEncoder and bayes_hook can easily moved somewhere else, e.g. to my examples, if I am the only one to use it.


Add support for rune pouch

Tracks values of runes in the rune pouch

I actually don't own a rune pouch yet to test this out. lol.
I'll work to grab one so that I can test this out.

Hah, no worries - I did some testing myself but it definitely wouldn't hurt to have someone else verify it.

I bought a rune pouch. I'll pull this code locally and test it out later :)

Did a pass of code review, and the code generally looks sound. I'll patch it in a bit and play around with it just to double check functionality and edge cases.

Tested it out and it seems to work well. Thanks for this!


link  would be nice

In the description to the "Configure-EnterpriseApplication.ps1" some pointing link would be nice to add. I am looking for this, and not finding.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a6cd7dfe-c3e8-b150-143e-ee63c2c077dd
Version Independent ID: 4546a968-bf64-1eae-1205-e89c4b2161f9
Content: Test-OAuthConnectivity (ExchangePowerShell)
Content Source: exchange/exchange-ps/exchange/Test-OAuthConnectivity.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@petersonal2 Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Query regarding the send_sip_register()

Hi Steve,
How are you? I was building a simple SIP client and stumbled upon your library. I went through the code and found that in the register method, you are getting a register_address parameter, which is not referenced anywhere in the code.
def send_sip_register(self, register_address, register_frequency=3600)
Could you please let me know whether you have updated version of the code? Also if you have any sample script that uses this library, could you please upload the same here. Thanks!
-Andy

Hey, thanks for sharing the details. I will take a look at the other scripts.


add ajax monad as an example

Refs GH-14. Do you think it's better to keep tracing monad as well or should I remove it from examples?

:+1:

As far as I can tell, there's only jQuery.ajax( url [, settings] ) or jQuery.ajax( settings ).
That probably leaves us with a couple of options:
bind: fn (x : Request) f =
  $.ajax x.url {dataL x.payload, complete: f}

Or:
bind: fn (x : Request) f =
  ($.ajax x.url).complete f

Indeed I was wrong. I thought about $.get x.url x.payload f. :\ Sorry.

Awesome, I can fix that up locally.

Merged and pushed to http://roy.brianmckenna.org/


Update sort triangle

This PR updates sorting triangle for each column. Before this fix unicode symbols are displayed with different height (and sort of size) - same in Spark UI, so I replaced them with ▲ and ▼, which are a little bit fat, but at least consistent in size.
Currently:

After:

Again, this is very minor and subjective, so all ideas/suggestions are super welcome. Happy to close, if someone finds these triangles inappropriate.

@ryan-williams please review.

Test comment


Website not working

I was trying the algorithm on https://emadehsan.com/csp/ but when I click on "cut" I get the following error,  is there a self-hosting version of it?

Hi @Ladvace, sometimes this issue can be avoided by pausing the ad blocker (which might be causing CORS error). But I think my deployment on Heroku's free tier might not be functioning well.
The deployment folder has the code you are looking for to run this website & server locally.

This program It is not working. When pressing this button, nothing happens:

Can you please let me know if there is a problem with it?
Thank you,


Clean install fails to run on MacOS 10.13.6

A clean install of swc through npm fails to run on MacOS 10.13.6
Reproducing
Step 1:
npm i -D @swc/core @swc/cli

Step 2:
npx swc src/index.js

Result:
dyld: lazy symbol binding failed: Symbol not found: ____chkstk_darwin
  Referenced from<EMAIL_ADDRESS>(which was built for Mac OS X 10.15)
  Expected in: /usr/lib/libSystem.B.dylib

dyld: Symbol not found: ____chkstk_darwin
  Referenced from<EMAIL_ADDRESS>(which was built for Mac OS X 10.15)
  Expected in: /usr/lib/libSystem.B.dylib

Abort trap: 6

Expected behavior:
A clean install should work properly.
Also, following the steps described in the installation guide about setting up the rust toolchain in order to compile swc for unsupported platforms did not work and npm keeps downloading the pre-built binary.

Thanks a lot for the quick fix! It is working as expected now.


Prevent Sale Amount Entered From Being Greater Than Shares Owned

@pwdel   So could we use The external Library for this Ui as well ?

Yes we could.
So I would like a holistic look at what external libraries we introduce into the code to try to avoid introducing too many and creating a base that is harder to maintain.
That being said, some core functionality could be probably very much improved with a refactor with certain types of libraries.
Here is where I have put a discussion board for different kinds of library ideas for all sorts of purposes across the entire frontend app.
https://github.com/orgs/openpredictionmarkets/projects/2
I would say, if you have a good idea, perhaps start a ticket on that project exactly for the library you would suggest. I aim to put a bunch more suggested libraries in there to evaluate soon too.
What do you think?

Fixed in v0.0.3, currently on branch "profilepage"


Using packer just throws exception at startup

ConfuserEx Version:[INFO] Confuser.Core 1.5.0+b5197549e4 Copyright c 2014 Ki, 2018 - 2021 Martin Karing
[INFO] Running on Microsoft Windows NT 6.2.9200.0, .NET Framework v4.0.30319.42000, 64 bits

Target Framework: 4.6.2

Steps to Reproduce:
[assembly: Obfuscation(Exclude = false, Feature = "packer:compressor")]
[assembly: Obfuscation(Exclude = false, Feature = "preset(minimum);-anti debug;")]

cd bin\Release
Confuser.CLI -n -o=%CD%\..\Confused %CD%\TestApp.exe

When I try running the resulting exe in the Confused directory, it just throws an exception immediately on startup:
System.Reflection.ReflectionTypeLoadException
  HResult=0x80131602
  Message=Unable to load one or more of the requested types. Retrieve the LoaderExceptions property for more information.
  Source=mscorlib
  StackTrace:
   at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
   at System.Reflection.RuntimeModule.GetTypes() in f:\dd\ndp\clr\src\BCL\system\reflection\module.cs:line 1118
   at Main(String[] )

The LoaderExceptions property refers to all of the assemblies that were supposedly packed into the executable.
(Also, assuming this can be fixed, is there a way to exclude specific assemblies from being packed?)

Is there any way you can send the test application you are using over? The packer would work fine and there are unit tests in place that verify that it is in fact working. So the issue is caused by something specific in your application.
You can exclude assemblies by not adding them to the confuser project. All assemblies that are being protected are packed into one assembly.


Production Use

Also, would it be possible to know within a single source, and not different, scattered, statements, what "Production Use" is and why it isn't allowed within the subscription's licensing terms?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fe2c630f-bb11-e092-d5c1-263ba42fb18e
Version Independent ID: 80e2c72a-f2b1-2901-5606-c3bf164bc256
Content: Visual Studio subscriptions license terms
Content Source: subscriptions/vs-license-terms.md
Service: unspecified
GitHub Login: @evanwindom
Microsoft Alias: jaunger

@Nathan-Tarin Thanks for your inquiry and apologies for the late reply.
@evanwindom @prrana Is this something that we could update the docs with?


Create new project: Project start date produces 500 error

Sign up as an FRO

create new project

Go to project start date - by default it's populated with today's date

Go into the dropdown and pick "choose a month"

A second later this comes up, I think as a pop-up / overlay?

This also happens with the end date field!
Not sure what the priority for this should be - putting it as for the next release but please feel free to deprioritize if need be.

Duplicate of #832.


only frontend

Is it possible to use tdlib with only front end without back end?
It's possible, but please refer to it.
For example, operating on a client using only a reactant

TDLib is a Telegram client. It operates with Telegram backend.


html loads painfully slow

We recognized very poor loading performance of the generated html output for larger projects.
You can even recognize a short delay by opening the example report for jquery.
As our library is about 30k lines of code distributed amongst around 200 modules you're really annoyed if navigating through modules and back to main page as its getting rendered everytime.
I assume this is due to a live creation of the charts from data. Maybe preprocessing the charts would be a much better solution. Anyway I don'T know if thats possible without larger impacts,

I wanna try to render using reactjs and styled-component for not loading slow


Delete unnecessary spaces

When copying from the web page, there is an unnecessary space after the code.

@changeworld : Thanks for your contribution! The author, @gregvanl, has been notified to review your proposed change.

Thanks @changeworld for your edits.
Reference: I reviewed, and all changes are whitespace edits. No apparent change to layout rendering. Merging.


meta-cache支持复用

PR types
New features
PR changes
OPs
Describe
meta-cache支持复用

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


How can I override CTRL+F keybinding?

CTRL+F is a standard key binding for most shells (sh, bash, zsh, fish) for moving forward a character.  So installing fzf has really screwed up my terminal usage since 20 years of memory means I need ctrl+f to do what its always done :)
I see in .conf.d/fzf/ its declared  but I don't really want to edit that file since I'd like to be able to upgrade if things change in the future.   Is there an easy way to just say "reset ctrl+f to existing shell"?
I'm not great with fish yet, still learning the differences.   I saw in the docs you say to do:
set --universal fzf_fish_custom_keybindings

but Do not try to set fzf_fish_custom_keybindings in your config.fish  but I don't understand where I would set it if not in config.fish.  Then I don't understand how I can just remove your binding thats overriding the defaults.  I don't want to change the binding to something else, just remove it

bind --erase --all \cf

seems to be all you need for this.   I'll leave this ticket open for discussion since I think its bad practice to override such an important default keybinding as movement in shells but if you disagree we can close this.

bind --erase --all \cf

seems to be all you need for this.   I'll leave this ticket open for discussion since I think its bad practice to override such an important default keybinding as movement in shells but if you disagree we can close this.

Hi @sontek! Did you try https://github.com/PatrickF1/fzf.fish#using-custom-key-bindings?

Hi @sontek! Did you try https://github.com/PatrickF1/fzf.fish#using-custom-key-bindings?

but that seems to overwrite all the default keybindings? Not just give the ability to customize?    My big concern is this is squashing an extremely important default keybinding for shells, so it doesn't seem to be a good default.   It removes the ability to move forward on the command line

but that seems to overwrite all the default keybindings? Not just give the ability to customize?    My big concern is this is squashing an extremely important default keybinding for shells, so it doesn't seem to be a good default.   It removes the ability to move forward on the command line

but that seems to overwrite all the default keybindings? Not just give the ability to customize?

You're right. It's not ideal but I don't think it's a big deal because it's just 4 simple lines of code you can almost copy and paste. My hands are also tied by my previous (less informed) decisions. Now that probably thousands of people are using this plugin, I can't just change the defaults or settings on them.

It removes the ability to move forward on the command line

Can you explain this statement more? How come you don't use the arrow keys? I'm trying to understand my users' setups and work styles so I can make key bindings better in the future

but that seems to overwrite all the default keybindings? Not just give the ability to customize?

You're right. It's not ideal but I don't think it's a big deal because it's just 4 simple lines of code you can almost copy and paste. My hands are also tied by my previous (less informed) decisions. Now that probably thousands of people are using this plugin, I can't just change the defaults or settings on them.

It removes the ability to move forward on the command line

Can you explain this statement more? How come you don't use the arrow keys? I'm trying to understand my users' setups and work styles so I can make key bindings better in the future

I think most people who are using the CLI are trying to stay on the homerow rather than using arrow keys, which is why ctrl+f and ctrl+b exist in the shells.   It is just an ergonomic thing so that my fingers don't have to move off and prevent me from typing.
There are also other shortcuts that work the same way for better movement than arrow keys.  For example I use alt+f / alt+b as well for jumping words instead of characters.  Ctrl+A / Ctrl+E to go to front and back of a line.

I think most people who are using the CLI are trying to stay on the homerow rather than using arrow keys, which is why ctrl+f and ctrl+b exist in the shells.   It is just an ergonomic thing so that my fingers don't have to move off and prevent me from typing.
There are also other shortcuts that work the same way for better movement than arrow keys.  For example I use alt+f / alt+b as well for jumping words instead of characters.  Ctrl+A / Ctrl+E to go to front and back of a line.

Ah you must be a pro Emacs user!

I think most people who are using the CLI are trying to stay on the homerow rather than using arrow keys

I would disagree with this. I think most people use arrow keys, a small minority use vim-bindings, in which case they either use arrow keys or h and l, and a small minority use all of Emacs-bindings. So I think overall Ctrl+F isn't a HUGE problem, but it is a pretty big problem. I wish I had known earlier :(
But thanks for enlightening me. I'll think harder about a solution even if there's no clean one.

Ah you must be a pro Emacs user!

I think most people who are using the CLI are trying to stay on the homerow rather than using arrow keys

I would disagree with this. I think most people use arrow keys, a small minority use vim-bindings, in which case they either use arrow keys or h and l, and a small minority use all of Emacs-bindings. So I think overall Ctrl+F isn't a HUGE problem, but it is a pretty big problem. I wish I had known earlier :(
But thanks for enlightening me. I'll think harder about a solution even if there's no clean one.

Btw @sontek, you mentioned you were new to Fish. I want to say this: welcome! I hope you'll love it and make it your new home. Since you're still learning Fish and the different variable types, may I recommend
this wonderful guide that got me started: cookbook.fish? Also, I recently made an edit to it just for you. See this section https://github.com/jorgebucaran/cookbook.fish#how-do-i-set-variables-in-fish

Btw @sontek, you mentioned you were new to Fish. I want to say this: welcome! I hope you'll love it and make it your new home. Since you're still learning Fish and the different variable types, may I recommend
this wonderful guide that got me started: cookbook.fish? Also, I recently made an edit to it just for you. See this section https://github.com/jorgebucaran/cookbook.fish#how-do-i-set-variables-in-fish

Hey there. For me Ctrl+F is also confusing because it's fish default key binding to accept autosuggestion and I used to it.

Hey there. For me Ctrl+F is also confusing because it's fish default key binding to accept autosuggestion and I used to it.

Try using the right arrow key for now. I’m thinking now of how I can fix
this without a rough transition for tons of people.
On Sun, Jan 24, 2021 at 9:04 AM Nikita Hrytsai<EMAIL_ADDRESS>wrote:

Hey there. For me Ctrl+F is also confusing because it's fish default key
binding to accept autosuggestion and I used to it.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/PatrickF1/fzf.fish/issues/83#issuecomment-766395080,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAPAJEFNT2FF5T3E2R6HU6TS3RHK3ANCNFSM4WGOI5DQ
.

Try using the right arrow key for now. I’m thinking now of how I can fix
this without a rough transition for tons of people.
On Sun, Jan 24, 2021 at 9:04 AM Nikita Hrytsai<EMAIL_ADDRESS>wrote:

Hey there. For me Ctrl+F is also confusing because it's fish default key
binding to accept autosuggestion and I used to it.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/PatrickF1/fzf.fish/issues/83#issuecomment-766395080,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAPAJEFNT2FF5T3E2R6HU6TS3RHK3ANCNFSM4WGOI5DQ
.

@angrypie @sontek if I change it to Alt+F, would that work for you?

@angrypie @sontek if I change it to Alt+F, would that work for you?

@PatrickF1 That would still stomp on default Fish key mappings as well as standard shell mappings.
For fish specifically these are the two default bindings for movement:
bind --preset \ef forward-word
bind --preset \cf forward-char

Since these already had special meaning, during autocompletion (when there is no forward to go to) fish special cases them to do "forward total completion" and "forward next word in completion"

I suspect that there are more fish (and standard shell users) who are used to using these standard keystrokes more than ones who have specialized their usage to this specific plugin.   The first thing I had to do when using this plugin was learn how to teach it not to step on those keybindings

@PatrickF1 That would still stomp on default Fish key mappings as well as standard shell mappings.
For fish specifically these are the two default bindings for movement:
bind --preset \ef forward-word
bind --preset \cf forward-char

Since these already had special meaning, during autocompletion (when there is no forward to go to) fish special cases them to do "forward total completion" and "forward next word in completion"

I suspect that there are more fish (and standard shell users) who are used to using these standard keystrokes more than ones who have specialized their usage to this specific plugin.   The first thing I had to do when using this plugin was learn how to teach it not to step on those keybindings

@sontek Thanks for the info! I was also unaware of that binding. Now I see it in the default bindings. What do you think about Ctrl+Alt+F then?

I suspect that there are more fish (and standard shell users) who are used to using these standard keystrokes more than ones who have specialized their usage to this specific plugin.

I can't be sure but I agree now, based on the volume of people asking me to change this. And for that reason I will change it.

@sontek Thanks for the info! I was also unaware of that binding. Now I see it in the default bindings. What do you think about Ctrl+Alt+F then?

I suspect that there are more fish (and standard shell users) who are used to using these standard keystrokes more than ones who have specialized their usage to this specific plugin.

I can't be sure but I agree now, based on the volume of people asking me to change this. And for that reason I will change it.

@sontek For me it's more convenient to be able just put set --global ... or something in my config to override few defaults.

@sontek For me it's more convenient to be able just put set --global ... or something in my config to override few defaults.


which model of BERT  ?

There are 15 models offered.  Which one is used?

I'm sorry, I just saw this message. I didn't pay attention to the news during the holidays these days
I downloaded it from this link
https://huggingface.co/google-bert/bert-base-uncased
And I added a new online link to the application
Thank you for your comment


Minor Changes for Documentation

Codecov Report

Merging #297 (c463eaf) into master (2d84b6c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #297   +/-   ##
=========================================
  Coverage     83.92%   83.92%
  Complexity     1101     1101
=========================================
  Files           148      148
  Lines          3209     3209
  Branches        391      391
=========================================
  Hits           2693     2693
  Misses          421      421
  Partials         95       95

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d84b6c...c463eaf. Read the comment docs.


Add associated TimeStorage

Add associated TimeStorage to allow implementors to select between u32 and u64 as backing storage for Timers
Still testing if this actually makes sense.

I am closing this again, as the resulting interface will make it very hard for libraries to use.


/api/v3/vulnerabilities/servers/{id} params Groups

the code
update_server = Cyberwatch_Pyhelper().request(
method="put",
endpoint="/api/v3/vulnerabilities/servers/{id}",
params={'id': ID , 'description': "description", 'groups': [1] }
)
doesn't update the group but update description.

Thanks for reporting this.
We will include a fix it in the next release.

Hello,
For PUT and POST methods, you need to use body_params instead of params as follows:
update_server = Cyberwatch_Pyhelper().request( method="put", endpoint="/api/v3/vulnerabilities/servers/{id}", body_params={'id': ID , 'description': "description", 'groups': [1] } )
This information has been added in the documentation.

Hello,
I can update groups but I have an other issue link to it
--endpoint="/api/v3/vulnerabilities/servers/1"
Traceback (most recent call last):
File "api/ajout_group_asset.py", line 136, in
update_server = Cyberwatch_Pyhelper().request(
File "....env/lib/python3.8/site-packages/cyberwatch_api.py", line 50, in wrapper
params_id = kwargs.get("params").get("id")
AttributeError: 'NoneType' object has no attribute 'get'

Hello,
Apologies for the delayed response. This problem has been addressed and released. We now suggest to use only body_params and changed the code accordingly.
Regards,


Add PnP Typescript Preset

Fixes this bug
https://github.com/storybookjs/storybook/issues/6905
See also
https://github.com/storybookjs/storybook/issues/6899

@igor-dv is there the possibility that you finish this PR yourself? Would be great to have this merged some time soon!

Yeah, I have plans to do this at the weekend

merged to a different branch so I could working on it


Dazfuller/threshold bytes

This resolves issue #20 by renaming the variable in the code and adds in an alias for the maxBytes option to ensure backwards compatibility

Codecov Report

Merging #22 (f573a32) into main (21083e7) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   92.50%   92.36%   -0.14%
==========================================
  Files          11       12       +1
  Lines         240      249       +9
==========================================
+ Hits          222      230       +8
- Misses         18       19       +1

Impacted Files
Coverage Δ

...m/elastacloud/spark/excel/ExcelParserOptions.scala
97.67% <100.00%> (+0.11%)
:arrow_up:

...m/elastacloud/spark/excel/parser/ExcelParser.scala
91.30% <100.00%> (ø)

.../scala/com/elastacloud/spark/excel/ExcelScan.scala
85.71% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.