Enum value not assingable to typeof Enum

TypeScript Version:  3.4.0-dev.20190223

Search Terms: enum, typeof enum, not assignable, dynamic enums
Code
enum E {
  Foo = 'Foo'
}

const castedE = E as typeof E;
const fun = (e: typeof E) => e;
fun(castedE.Foo) //  Argument of type 'E' is not assignable to parameter of type 'typeof E'.

Agree it is not a usual usecase, but from the error message it seems like a bug. It is encountered when user tries to dynamically temper with enums.
Expected behavior: No error
Actual behavior:
 Argument of type 'E' is not assignable to parameter of type 'typeof E'.

Playground Link: link
Related Issues:
https://github.com/Microsoft/TypeScript/issues/28102
https://github.com/Microsoft/TypeScript/issues/17690
https://github.com/Microsoft/TypeScript/issues/22781
(not sure how much related)

typeof E represent the type of the container object for the enum. At runtime, enums have an object that contains the enum values (unless you have a const enum). So the type of typeof E would be equivalent to Record<"Foo", E>.
Depending on what you want to achieve you can fix the error either by passing in the enum:
const fun = (e: typeof E) => e;
fun(castedE)

Or by chaining the type of the parameter:
const fun = (e: E) => e;
fun(castedE.Foo)

or relative to castedE

const castedE = E; // no cast really necessary
const fun = (e: typeof castedE[keyof typeof castedE]) => e;
fun(castedE.Foo)

I want to pass the value, not the container, so only either of the two last options are relevant. I wanted to avoid exposing the original enum E, only the modified version, which means I have to take the last one. Thanks for explanation, it solved my issue.
However, I still think that the fact that castedE in  const castedE = E as typeof E; behaves differently and I daresay in a non intuitive way might be an issue for other users.


Replace esperanto with babel

Esperanto is deprecated, and on build it's been nagging about switching to something supported like babel. The transition was straightforward and it seems to work fine. Probably needs testing by people who aren't me though.

Ping @bhuga

Thanks for the ping. I'd wanted to take a look at the upstream electron-boilerplate, but it seems like they've removed esperanto and replaced it with...nothing? I'll land this next Tuesday, and take a look at bumping electron while I'm there.

it seems like they've removed esperanto and replaced it with...nothing?

The commit history isn't clear, but it looks like they replaced esperanto with babel at one point, then removed that later?

It looks like babel was replaced with rollup in this commit; rollup is mainly a module bundler, it doesn't look like the ES6 transpiler plugin is being used.

better late than never

I looked in to bumping electron-boilerplate and it's a pretty dramatic change app.js is just gone. We're on our own!


Bug: authenticate checks wrong passReqToCallback field

File: /lib/strategy.js line 161 should check context.options.passReqToCallback instead of context.passReqToCallback. passReqToCallback is under options.

Fixed in 0.5.1


Add a Yamllint config and fix remaining violations

With the supplied config and the changes here, and using the newly released 1.9.0 version of yamllint (which contains a bug fix for false positives I found in our repo), the report is now squeaky-clean:
yamllint . -f parsable

Compilation finished at Tue Oct 24 10:19:09

Gaprindashvili backport details:
$ git log -1
commit ab007f0544f541dbd4c6a1135b670475b4405015
Author: Jason Frey<EMAIL_ADDRESS>Date:   Mon Nov 27 11:06:57 2017 -0500

    Merge pull request #16292 from imtayadeway/yamllint

    Add a Yamllint config and fix remaining violations
    (cherry picked from commit 3e436cce31aee3d7b605d5f67fdfe74ab5a0c4bb)


Refactor csr controller to prepare extend more checks(for example, check if a csr is from flightctl device)

…eck if a csr is from flightctl device)

/assign @zhujian7

@zhujian7  You're right, this csr controller is meant to only handle csr from managed cluster, this line of code make sure only csr from managed cluster get handled, the agent-registration csr won't be watched in this controlelr.
https://github.com/stolostron/managedcluster-import-controller/blob/b1ccdeaa020f31ac73023f28506967782c442eea/pkg/controller/csr/manager.go#L39
Thanks for helping me think it through!
/close

/lgtm

/override ci/prow/sonar-pre-submit


User switching with script/delayed_job

I've added options -u and -g which are used to perform permissions changes. This prevents having to jump through hoops in production when starting the daemon with something like upstart.
I noticed another pull request (#266) open for this, but I didn't like that it duplicated existing behavior in the daemons gem. I also fixed a Rails 3 deprecation warning in a different commit (grays@da07875e), I didn't include it in the pull request because I don't want to make assumptions about why it wasn't already changed.

So, any hope of this?

Trying it out on DJ master w/ daemons 1.0.10. Can see the options getting set correctly but can't get it to change users when it daemonizes.
sudo ./script/delayed_job start -u matt
{:pid_dir=>"/Users/matt/projects/delayed_job_test/tmp/pids", :user=>"matt", :group=>"matt", :quiet=>true}
Process runs as root.

Works for me in production on linux with daemons 1.1.4
I'll investigate and see what could be causing it not to work.

Daemons gem version seems like a likely starting point.

I finally had time to date a look at this, it's working fine in production for us, and in development:
 % sudo ./script/delayed_job start -u ambethia -g staff
Changing process privilege to ambethia:staff
delayed_job: process with pid 50798 started.

 % ps ux | grep 50798
ambethia 50798   0.2  2.4  2574612 102120   ??  S     6:46AM   0:01.62 delayed_job

What you might have noticed running as root was the sudo process, not the dj worker itself while the worker was is spinning up:
root           50971   0.0  0.1  2468716   2360 s006  S+    6:54AM   0:00.02 sudo ./script/delayed_job start -u ambethia -g staff

Have you had a chance to look at this again yet? It's a really tiny change to Delayed::Command that just passes along an existing option Daemons already supports.


[New term] Telemetry

1. Please describe why this term needs to be added
What this term is about? (briefly)

Telemetry is one of the additional three factors introduced in Beyond the Twelve-Factor App. Developing your application is only the first aspect of a cloud-native developer’s job.

Why this term needs to be added? (briefly)

Telemetry is an essential part of any cloud-native app these days and it's also included in the new 15-factor guidelines.

2. Checklist

[X] The suggested term fits the cloud native definition or is essential to understanding cloud native terms. (We hope to avoid adding general or broad terminologies)
[X] There is no existing issue yet. (shift+click to check existing issues)
[X] I understand that maintainers will assess if the term should be part of the Glossary. (Please be patient)
[X] I want to work on this term. (If not checked, maintainers will assign another volunteer)

(Note)
Maintainers will assign a label after assessment procedure.
(from triage/awaiting to triage/accepted or triage/not accepted)
A contributor can be assigned to this issue after the issue get the triage/accepted label.
The assignee needs to check Style Guide.

Thanks for your suggestion, this term has been approved for the Glossary!

Howdy! I'd like to pick this one up.

@CathPag Please can I be assigned this issue?

Same, here, @FavourDaniel. We work on one issue/PR at a time.


Spelling

Fixes misspellings identified by the check-spelling action.
The misspellings will be reported at https://github.com/jsoref/cppwinrt/actions/runs/8574313379
The action will report that the changes in this PR would make it happy: https://github.com/jsoref/cppwinrt/actions/runs/8574313511
(Sorry, I'm heading out and these are running behind a CI task that's validating things, but I'm fairly confident in the changes...)

Hey, I'm recovering from a concussion 🤕, so I've been taking it easy...

I should note that it jumped the queue, I have >400 repositories to go.

Am I missing the spelling.yml in this PR?
Sorry to hear about the concussion. Hope you get some rest.

spelling.yml isn't included, if you're interested, I'm happy to make a PR with it :). -- I'll have to make some adjustments as I develop these PRs using the bleeding edge version (it's how I test changes), but I generally contribute the latest supported version (although I do hope to ship a new version soonish -- as, sadly, the latest release has dependencies on some of those node16 components...).

Got it - no rush on the workflow but that would be neat. Thanks again.


Unicode Line breaking algorithm

Line breaking seems to be a common issue (#79 #77) that could be addressed once and for all by implementing the Unicode Line Breaking Algorithm.
It's probably a lot of effort to implement fully but would also allow correct hyphenation on long words.

Thanks for pointing that out.

Also from my point of view that would indeed be the best solution. I would definitely not implement this as part of easytable though but that should be a library of its own.
There are already libraries that can do more elaborated line breaking (as discussed on stackoverflow) like:

https://commons.apache.org/proper/commons-text/javadocs/api-release/org/apache/commons/text/WordUtils.html
https://github.com/davidmoten/word-wrap

One could think about integrating any of those (maybe with scope provided in the pom.xml file) and creating a property for text cells where one can select the library or function to use for word wrapping.
Not sure though if it is worth the effort. Issue #77 for instance is easy to solve with a cell type of its own and issue #79 is already improving the current mechanism.

There are already some implementations in other languages:

https://github.com/aoitaku/unicode-line_break
https://bitbucket.org/emptypage/uniseg-python/src/default/
https://github.com/foliojs/linebreak
https://github.com/hatukanezumi/Unicode-LineBreak/

There isn't any for java seemingly though.


Create tilesets from image collections

This PR

Adds a new feature

Describe the changes below:
Supports Tiled image-collections tilesets by creating one tileset per image.
This is a quick solution for #4780 .
This is not the most efficient way to do it but it is useful when prototyping/developing and requested by several users.
Let me know if some change is required.

Any interest in this?
If not, no problem, I'll move that code out of Phaser.

Had to fix the PR up a bit, but happy to merge 👍

Thank you!


Improv WiFi works most of the time but not always.

Hi,
I have seen that improv wifi is not really reliable.
It works most of the time but not always.
Sometimes, when I try to flash the ESP8266, it asks me for the WiFi SID and password,
I enter the credentials, and then it hangs on this screen.
It happen on my implementation here:
https://sblantipodi.github.io/glow_worm_luciferin/beta.html
and on the one on the official esp web tools page.

Is this a bug? I tried changing the router and the esp8266 but same problem.

So this can be caused by:

The implementation of Improv on your device
The device unable to reliably connect to the Wi-Fi

Can you try to use the demo firmware that ESP Web Tools website tries to install?

Hi balloob, thanks for the answer.
Sometimes it happen even with the demo here:
https://esphome.github.io/esp-web-tools/
Is there a reference implementation that shows how to correctly implement it?
thanks

We do not currently have a reference implementation.

I confirm that the problem happens even with the demo on the official esp web tools page.

the tools hangs after entering the WiFi credential.
I'm trying to debug it using my implementation, it seems that sometimes credentials are not received by the ESP,
esp web tools wait for an answer from the ESP and ESP wait for the credentials.
is there a way to tell esp web tools to retry sending credentials if no answer is received?

I'll look into adding a timeout to the command. Can you try it with a different device?

@balloob I can also confirm this being an issue in my effort to support improv on the squeezelite-esp32 project, for which I am exposing an installer here: https://sle118.github.io/squeezelite-esp32-installer/
In my case, there were 2 factors to consider

Our implementation is multi-threaded, which initially resulted in IMPROV packets overlapping with logs from other threads. This was easily fixed by using the esp-idf's uart_write_bytes, which grabs an exclusive lock on the serial port during transmission.
Our console i/o thread starts roughly at 4 seconds after resetting the device with a substantial amount of logs produced during that time.

Being able to setup the "boot timeout" period is a critical feature, as users have to try multiple times with the current 1 sec timeout for the improv stack to be recognized. I have forced various timeout durations in my local npm modules and can confirm this makes a positive difference.
Note that as of writing this, the improv enabled code hasn't been committed yet to the squeezelite-esp32 repo; coexistence with our telnet implementation as well as our web interface, which pipes UI commands back into the console thread made this a bit more tricky to implement. It's worth noting that I have written the improv implementation in 'c' to possible release a stand-alone library for others to use.

You can use the new_install_improv_wait_time option to extend the delay on how long it will wait for the Improv response.

This will certainly improve new installations, but I am referring to using the improv button as stand alone when not actually flashing binaires. Perhaps this is an issue I should open separately in that repo instead of here then again I'll see if that mechanism, used by the installer, could be leveraged as stand alone.
For the record, here is the link to the work in doing
https://github.com/sle118/squeezelite-esp32/issues/187

When you start ESP Web Tools to just use Improv, you need to be very fast to hit connect + select the device within 4 seconds from booting to have Improv not respond?

@balloob I just pushed a possible enhancement for the ones (like me) who'd like to use improv serial as a stand-alone option, outside of the "new flash" context. This allows specifying a custom timeout like this:
<improv-wifi-serial-launch-button id="button_improv_serial" learnMoreUrl="https://www.esphome.io/components/improv_serial.html" timeout="5000"></improv-wifi-serial-launch-button>
let me know your thoughts

So now I am a bit confused. We're discussing this in the ESP Web Tools repo but your example code shows the standalone Improv Wi-Fi SDK. You don't need to use that one, as the ESP Web Tools can provide installation + provisioning.
Did you see my question about that one has to be very fast to hit connect to actually send Improv within 4 seconds of a device booting up?

For the new installation, I'll definitely go with the manifest approach, which fits my requirements. As for the standalone button, I did hijack this issue involuntarely because I had not fully checked the implementation.  I opened a new issue in the sdk-serial-js repo instead. The reason why I am using the stand-alone button is that my UI will show the "provision wifi" button until/if user actually picks a firmware to flash on the system. This is to provide a simple way to provision wifi and check logs without going the route of picking up an actual firmware from the list.
Here's the link to the serial sdk issue.
As for myself, using the manifest timeout for the esp-web-tools button will do the trick.
https://github.com/improv-wifi/sdk-serial-js/issues/95

Improv SDK doesn't provide an option to show logs or funding URL.
I think that you've made it yourself so difficult with all the different versions per device! Why not just have a simple UI that shows the latest?

We are only two developers and can't possibly cover all scenarios in our limited regression tests for squeezelite-esp32. In a production environment with a team ready to take issues and respond in a timely manner, I would not go that far out. But in that situation, being able to roll back to the previous release has often been the best contingency plan for our users.
The ability to play music and synchronize multiple zones, once it has become a given in a home, cannot suffer failure ever. Experience let me to realize that not being able to play music when needed can quickly become a P1 issue, and that rolling back is often the best course of action.
I've had lights not automatically turning on our off without a comment. But music playback failure is not an option here. It's mission critical ;)

Alright, well your call. Something like this but with a version dropdown would allow you to always use ESP Web Tools.
Will close this issue as it's Improv SDK related.


ContractConfigurator-HistoricMissions.netkan

Hoping I'm allowed to install these .craft files to Ships based on https://github.com/KSP-CKAN/CKAN/issues/1134

Unsure how I'll get the stuff from StockCraft into the Ships/VAB folder and until that is solved this shouldn't be merged.

The StockCraft were never meant to be installed to Ships. ContractPacks have .craft files inside the GameData folder to create ships inside the contracts themselves (eg. a specific craft to rescue from orbit).
Thanks to @Postremus for pointing that out to me.


cri: Implement runtime handler support

Fixes #1751
Signed-off-by: Sebastien Boeuf<EMAIL_ADDRESS>

@mrunalp @runcom PTAL, I'd like to get some input about the first draft of the implementation of the runtime handler before I go further.

@runcom @mrunalp PR updated!

@sboeuf could you pick up
https://github.com/kubernetes-sigs/cri-o/pull/1820/commits/ff2c3e1909ec3d1526509bba0a5dd92fc1c9c417
https://github.com/kubernetes-sigs/cri-o/pull/1820/commits/2451ac0a9ae60b1babe4f3f0e10c58f5775e7f78
so this PR becomes our 1.12 PR since you've already cherry-picked the bump PR?
Also, we need to fixup reference to 1.12 under common/test/... for stuff like critest and the like
Thanks!

@mrunalp please could you get some feedback about https://github.com/kubernetes-sigs/cri-o/pull/1822#commitcomment-30795678 and https://github.com/kubernetes-sigs/cri-o/pull/1822#commitcomment-30795675 ;)

@runcom @mrunalp  @tallclair
I have updated this PR:

Added a new function ValidateRuntimeHandler() that is called both from the moment the runtime handler is passed from CRI, and for every time we want to know the runtime path. No duplication of code doing the verification this way.
I am returning an error if the runtime handler passed by CRI is not valid (empty or not found or invalid_value)
I have modified the function (r *runtime) Path(...) so that it can return an error now. This function is basing the validation of the runtime handler on the same function ValidateRuntimeHandler().
I have cherry-picked the two commits you mentioned @runcom

I hope this covers all your previous comments, let me know if I missed anything.

Looks ok, @tallclair would you mind doing a last review on this?

/test all

@sboeuf There are unit test failures in travis:
--- FAIL: TestUpdateFromFile (0.00s)
	config_test.go:50: Expecting: "untrusted", got: ""
	config_test.go:50: Expecting: "trusted", got: ""
--- FAIL: TestToFile (0.00s)
	config_test.go:50: Expecting: "untrusted", got: ""
	config_test.go:50: Expecting: "trusted", got: ""

@mrunalp I took care of the failure you mentioned

@sboeuf Thanks! It looks like the integration tests are failing in travis.

@sboeuf I've pushed a commit to this PR to take care of a default for Runtimes and deprecating Runtime

/test all

/test all

/test all

/test all

/test all

@sboeuf please rebase this whole PR to latest master as my commits are based on your PR+latest_master

/test all

/retest

tests look busted but not because of this PR

/retest

@runcom thanks I'll take a look today!

/retest

ok, tests are failing because of the merge conflicts :cry: @sboeuf when you rebase and push force, it's going to be working again.

/test all

damn, still conflicts after recent merges :)

Looks like everything is cool in #1847 which is the rebased version of this PR.
I'd say let's rebase this @sboeuf and do another tests run and then we can merge, backport to 1.12 and release 1.12.
Thanks

@runcom I am sorry I couldn't review this PR yesterday, let me do this right now.
About the rebase, why didn't you rebase directly on this one? And that's great to see that #1847 is passing!

About the rebase, why didn't you rebase directly on this one? And that's great to see that #1847 is passing!

I haven't cause I didn't want you to git reset --hard because I changed the commits :). We can also close this one and go with #1847, what do you think? that's already rebased and passing and I've cherry-picked your commit from here, sounds good?

@sboeuf if it's ok for you we can go with #1847 , ok to close this?

@runcom oh yeah sure we can use #1847, I'm fine with that, just please take a look at the comments I left on #1822 ;)

@runcom oh yeah sure we can use #1847, I'm fine with that, just please take a look at the comments I left on #1822 ;)

awesome, thanks a lot for the comments @sboeuf I'll fix them in #1847 and ping you there once ready for another, hopefully final, review

@runcom

awesome, thanks a lot for the comments @sboeuf I'll fix them in #1847 and ping you there once ready for another, hopefully final, review

Cool :smiley:

taken care of all your comments in #1847 , let's move the discussion there now @sboeuf


Remove deprecated functions from main source tree

I think you had your deprecated functions for a while already.
Let's clean up the source tree and move the to the deprecated folder (nothing is lost) before the next release.
This also helps me merging your changes into the Octave version of matGeom (which I am currently merging and I will pass you all the "improvements")

it's fine for me, merged!


Perfect Square Patch

Before jumping into Pr first comment for assign.
Problem statement : Create a function that takes an integer and outputs an n x n square solely consisting of the integer n.
Probelm Link : https://edabit.com/challenge/omTRzwvBibk4etBkx
Choose one Cateorgy - Very Easy, Easy, Medium, Hard, Very Hard, Expert
question category : Medium

Before submitting a PR please Check some details.

[X] fileName formet should be in camelcase
example- returnTheNextNumber.py
[X]  Choose label for Problem , example- "good first issue", "easy"
[X]  In file there should be problem statement and link to problem

/* Problem-Task : This program will add two numbers
 * Problem Link : https://edabit.com/challenge/SFzHtm63XT6EYNHWY
*/
int main() {
    int bla;
    return 0;
}

This repository is vaild for HacktoberFest2020
Read before making PR - How to contribute on Github
Good Luck,

I would like to work on this. Please assign.

I'll be glad to work on this issue.


Release v0.9.17

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

🚀
/approve


Install go-spacemesh gpu-post libs

Motivation
Enable Smapp users to be able to setup var-post.
Installer

Installer need to install the various files to the go-spacemesh target directory. See list of files per platform here: https://github.com/spacemeshos/SMIPS/issues/48
A release of go-spacemesh should include these files for each platform in the release artifacts.
Update CI to include these files in the installer at build-time and install them in the go-spacemesh directory as part of Smapp install.
Verify that go-spacemesh executable for linux and macOS already had the rpath adjustment applied to it. Should be part of go-spacemesh build CI.

Go-spacemesh process management

Ensure that go-spacemesh process is always launched with working directory set to the exe directory and not another dir.

Here's some reference code that @sudachen wrote in the post repo that can be used as reference for Smapp ci to obtain the artifacts per platform from a gpu-post github release. https://github.com/spacemeshos/post/blob/develop/Makefile.Inc


Migrate license to Apache 2.0

As per request, even tho I don't personally care to be in the NOTICE file.
Permission granted by Nono, Levi, and Dis.

Just getting my permission in stone here! I agreed.

Also agree.

Once merged, please issue a new release to update the license and notice on npm and the cdn.

I just got home. Let me review this tomorrow and make sure I understand the full ramifications of a license change. Since the other license holders have already said something in agreement here, I hope nobody would be offended that (if I approve) I hit the merge button.
Also, @ayyaruq - thanks for looking at the build system, and I'll push another release after I review.


Bug 1801154: manifests/: Throw away unused high cardinality apiserver duration buckets

This shouldn't have any effect on our alerts or dashboards as the buckets are cumulative and for those purposes the remaining buckets should be sufficient.
Note: this change was made in "upstream" kube-promethues repo, see background for this https://github.com/coreos/kube-prometheus/pull/387

/assign @tnozicka PTAL, thanks!

/retest
doesn't seem to be related.

/lgtm


How can I turn off apheleia-mode for Latex-mode?

I want to disable apheleia-mode for the Latex-mode. I have tried following solution but it did not help.
What I tried, which did not help:
(apheleia-global-mode +1)
(defun app/LaTeX-mode-hook ()
  (apheleia-global-mode -1))
(add-hook 'LaTeX-mode-hook 'app/LaTeX-mode-hook)

Is there any way to disable apheleia for a major mode like LaTeX-mode?

I have solved it using https://emacs.stackexchange.com/a/72882/18414:

(defun app/LaTeX-mode-hook ()
 (apheleia-mode -1))
(add-hook 'LaTeX-mode-hook 'app/LaTeX-mode-hook)

Yeah, you need to disable the local mode, not the global one.


feature: look for local plugins in dev.path ignoring the case

Did you check the docs?

[X] I have read all the lazy.nvim docs

Is your feature request related to a problem? Please describe.
The git repo cloned from github can have any case, e.g. both https://github.com/l3mon4d3/luasnip/ and https://github.com/L3MON4D3/LuaSnip work. When the repo is cloned from https://github.com/l3mon4d3/luasnip/, lazy.nvim can't find it with https://github.com/L3MON4D3/LuaSnip.
Describe the solution you'd like
Since github allow any case of the repo url. It's safe the assum that there won't be another repo with only different case. So I thought when looking for the local plugin the case can be ignored.
Describe alternatives you've considered
This can be solved by setting the name of the plugin.
Additional context
https://github.com/NixOS/nixpkgs/pull/221781

The name wil be whatever you use. Some systems are case-sensitive. It's up to the user to use the correct case-sensitive name


Fix bw64 cksize v2

closes #39
the test currently wouldn't have caught this issue, but it's better than nothing and difficult to check

That makes sense. I think there are a few other places we're using those macros too which might need the same.

Yeah, the other uses of these are in places where the type doesn't matter (whereas the behavior of writeValue depends on the type), so i didn't bother. Maybe it's worth doing?

Ah yeah, good point. I guess it's unnecessary then.


docs: update buttons design guidelines

Codecov Report

Merging #695 (4dc45b8) into dev (81ab701) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 4dc45b8 differs from pull request most recent head 8d0c3a0. Consider uploading reports for the commit 8d0c3a0 to get more accurate results

@@           Coverage Diff           @@
##              dev     #695   +/-   ##
=======================================
  Coverage   87.51%   87.51%
=======================================
  Files         174      174
  Lines        4349     4349
  Branches     1455     1455
=======================================
  Hits         3806     3806
  Misses        278      278
  Partials      265      265

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81ab701...8d0c3a0. Read the comment docs.


Econnrefused fetchPrivKey

I follow all instructions, active and install developer in tv but when try to connect received alway the same errors (I tried macos and windows version same issues).
Please make sure "Key Server" in Developer Mode App is turned on during device setup.
Error invoking remote method 'device-manager/fetchPrivKey':
Error: connect ECONNREFUSED <IP_ADDRESS>:9991
Macos Ventura 13.1 - Windows 11 - LG 65B8

@komax74 I did notice that it's attempting to connect on 9991 whereas the default port is 9922.
It could also be something blocking the port within your network. From your Mac, try to NetCat to the port to see if the route is available e.g. nc -vnzu <IP_ADDRESS> 9991 and nc -vnzu <IP_ADDRESS> 9922

Is there a solution yet?
I have successfully added my TV to ver. 1.8.2 (AppImage), I could not add the TV to a Windows version 1.8.2, also tried downloading 1.9 AppImage - still no luck. It tells me to enable the Key Server, which is enabled.
Since 1.8.2 still works, where does it store its settings? Arch Linux

Could you try to access http://ip:9991/webos_rsa? It's the private key for your TV.

@mariotaku I tried with 'nmap' and 'nc' - this port is closed on the TV, while 9922 is open.
$ nc -vnzu <IP_ADDRESS> 9991
$ nc -vnzu <IP_ADDRESS> 9922
$ nmap -p 9922,9991 <IP_ADDRESS>
Starting Nmap 7.93 ( https://nmap.org ) at 2023-01-26 22:17 CST
Nmap scan report for <IP_ADDRESS>
Host is up (0.0019s latency).

PORT     STATE  SERVICE
9922/tcp open   unknown
9991/tcp closed issa

Nmap done: 1 IP address (1 host up) scanned in 0.03 seconds                                                                                ```

Another confusion I have is the persistence of the version 1.8.2. I deleted folder 'dev-manager-desktop' from both /home/user/.config and from /home/user/.cache and it still remembers my TV name and the key and recreates those 2 folders. I suspect this could be the issue.

@0x09AF Thanks for checking out v1.9.0. The terminal is still work in progress in the renewed version. It will be available again soon.

Closing the issue for now. Please reopen if it happens on v1.9+.


Dynamic snippets does not work

s:last_completion_dictionary is always an empty dictionary, causing https://github.com/OmniSharp/omnisharp-vim/blob/master/autoload/OmniSharp.vim#L1086 to always fail.
I think this is because https://github.com/OmniSharp/omnisharp-vim/commit/9bfd3f7cd21b5b0855fcfd75156bb5713c855eab#diff-74bda44d257dfad5e1de8e418a18554dL101-L104 moved CBGetCompletions -> action#CBGet but did not update the script-local s:last_completion_dictionary.
I can confirm behavior is restored by replacing s:last_completion_dictionary -> g:last_completion_dictionary, though I don't think this is a satisfactory fix. Maybe adding a global setter and calling it from within the CBGet callback could work.

Oh right, good debugging, thanks. I'll have a look a bit later.


Meeting AV Filters sample: JavaScript

The original sample was built with Vite and supports HTTPS out of the box (which is mandatary). Does this sample configuration support HTTPS out of the box as well?

@nandin-borjigin - We have added the steps in readme where the localhost url is pointed to ngrok url starting with HTTPS. If required we can change the localhost configurations also to run the sample on HTTPS port.

@nandin-borjigin  - Resolved the PR comments, Can you review the changes once


feat: add Macchina-CLI/macchina

Macchina-CLI/macchina: A system information frontend with an emphasis on performance
$ aqua g -i Macchina-CLI/macchina

How to confirm if this package works well
Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well.
Please confirm if this package works well yourself as much as possible.
Command and output
$ macchina --help
Usage: macchina-linux-aarch64 [OPTIONS]

Options:
  -v, --version                Prints version information
  -o, --show <SHOW>            Displays only the specified readouts
  -d, --doctor                 Checks the system for failures
  -U, --long-uptime            Lengthens uptime output
  -S, --long-shell             Lengthens shell output
  -K, --long-kernel            Lengthens kernel output
  -C, --physical-cores         Toggles between logical and physical cores
  -s, --current-shell          Toggles between the current shell and the default one
  -t, --theme <THEME>          Specify the name of the theme
  -l, --list-themes            Lists all available themes: built-in and custom
  -c, --config <CONFIG>        Specify a custom path for the configuration file
      --ascii-artists          Lists the original artists of the ASCII art used by macchina
  -i, --interface <INTERFACE>  Specify the network interface for the LocalIP readout
  -h, --help                   Print help information

Thank you!

v4.83.0 is out 🎉
https://github.com/aquaproj/aqua-registry/releases/tag/v4.83.0


Question -- If the data is snappy compressed, is it possible to decompress when parse it with rdb-tools ?

Hi,
your question is very unclear, there's no snappy compression in redis, and i'm not sure what you want to achieve.
i can only assume that you mean that the rdb file was compressed, and you want to parse it directly from the compressed form.
you can do that by using the python functions (not the CLI), there's a parse_fd function that takes a file object, you can pass it a file like object that wraps a file object and does the decompression.
if that's not what you mean, please provide more info.

Thanks for info. The data object stored in the redis db is snappy compressed , when it saved as redis backup files, is there way can use python to extract and decompress the data object?
For redis db, I can use:
r = redis.Redis( ...)
keys = r.randomkey()
y = r.get(keys)
y2 = snappy.uncompress(y)
return y2

ohh.
maybe implement a new callback class, that derives from the json callback class.
then on each callback, do your decompression, and forward the decompressed data to the json class method.

Thanks


Updated links to Shapeless and Spire GitHub repositories

This is instead of the blank pages they currently point to.

Thanks, Jon!

There's probably more I could do without too much effort, but this should fix the most glaring complaint!


error /home/pi/HAP-NodeJS/node_modules/mdns/lib/advertisement.js:56

Hi,, i have an error when i run node Core.js:
pi@raspberrypi:~/HAP-NodeJS $ sudo node Core.js
*** WARNING *** The program 'nodejs' uses the Apple Bonjour compatibility layer of Avahi.
*** WARNING *** Please fix your application to use the native API of Avahi!
*** WARNING *** For more information see http://0pointer.de/avahi-compat?s=libdns_sd&e=nodejs
*** WARNING *** The program 'nodejs' called 'DNSServiceRegister()' which is not supported (or only supported partially) in the Apple Bonjour compatibility layer of Avahi.
*** WARNING *** Please fix your application to use the native API of Avahi!
*** WARNING *** For more information see http://0pointer.de/avahi-compat?s=libdns_sd&e=nodejs&f=DNSServiceRegister
HAP-NodeJS starting...
Parsing accessory: Fan_accessory.js
Parsing accessory: GarageDoorOpener_accessory.js
Parsing accessory: Light_accessory.js
Parsing accessory: Lock_accessory.js
Parsing accessory: TemperatureSensor_accessory.js
Parsing accessory: Thermostat_accessory.js
Parsing accessory: desktop_light_accessory.js
Parsing accessory: light_accessory.js
/home/pi/HAP-NodeJS/node_modules/mdns/lib/advertisement.js:56
dns_sd.DNSServiceRegister(self.serviceRef, flags, ifaceIdx, name,
^
Error: dns service error: name conflict
at Error (native)
at new Advertisement (/home/pi/HAP-NodeJS/node_modules/mdns/lib/advertisement.js:56:10)
at Object.create as createAdvertisement
at Advertiser.startAdvertising (/home/pi/HAP-NodeJS/lib/Advertiser.js:43:30)
at Accessory._onListening (/home/pi/HAP-NodeJS/lib/Accessory.js:465:20)
at emitNone (events.js:67:13)
at HAPServer.emit (events.js:166:7)
at HAPServer._onListening (/home/pi/HAP-NodeJS/lib/HAPServer.js:169:8)
at emitNone (events.js:67:13)
at EventedHTTPServer.emit (events.js:166:7)
pi@raspberrypi:~/HAP-NodeJS $
any idea?,, thanks

See my comment at bottom: https://github.com/KhaosT/HAP-NodeJS/issues/139

This did not fix the issue for me


Native Distributable with JavaFX WebView "libprism_xx.dylib can't be opened"

Describe the bug
When I package and sign a native distributable for MacOS I get the following error when executing the app and opening the WebView: "libprism_es2.dylib" can't be opened because Apple cannot check it for malicious software. Do I have to adjust how I include JavaFX or how I sign the app? I use the JavaFX gradle plugin for the integration.
Affected platforms

[ ] All
[x] Desktop
[ ] Web (K/JS) - HTML based API
[ ] Web (K/JS) - Canvas based API
[ ] iOS
[ ] other

Versions

Kotlin version*: 1.7.10
Compose Multiplatform version*: 1.3.0
OS version(s)* (required for Desktop and iOS issues): macOS Monerey Version 12.1
OS architecture (x86 or arm64): arm64

To Reproduce
Steps and/or the code snippet to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Screenshots

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Allow for dollar signs in feature flag keys

ugh, should i maybe just get rid of validation at this point...? Why is $ needed? It's not used in any common encodings and is more on the side of something that could be passed in as a mistake imo.


Invalid sourcemaps for sass when adding IconfontWebpackPlugin

Expected Behavior
Plugin does not affect sass sourcemaps
Actual Behavior
Breaks sass sourcemaps
Steps to Reproduce the Problem
Sass sourcemap without IconfontWebpackPlugin

clone config-example
npm i
npm start
open index.html from dist folder and inspect div.hello and span.icon

Sass sourcemap with IconfontWebpackPlugin

uncomment line 35 in webpack.config.js
uncomment lines 3-7 in hello-icon.scss
npm start
open index.html from dist folder and inspect div.hello and span.icon

The sources with IconfontWebpackPlugin are messed
Example Link

Link: config-example

Wow cool thanks for the information 👍
I will take a look.
The sourcemaps are generated by postcss and usually that works well

Can you do me a favour and try if this works:

Remove all scss & css & iconfont loader settings
npm i --save-dev scss-config-webpack-plugin
Add the following to your webpack config:

const ScssConfigWebpackPlugin = require('scss-config-webpack-plugin');

module.exports = {
  plugins: [
    // SCSS Configuration for .css .module.css and .scss .module.scss files
    // see https://github.com/namics/webpack-config-plugins/tree/master/packages/scss-config-webpack-plugin/config
    new ScssConfigWebpackPlugin(),
  ],
};

Try if sourcemaps work as expected

If it works you can use the plugin or its underlying config like this:
https://github.com/namics/webpack-config-plugins/blob/6bf7421bf492dba2d1b62e1889c3970c2f48b4bf/packages/scss-config-webpack-plugin/config/development.config.js#L12-L53


coveralls installation issue?

#coveralls-1.1 (https://pypi.python.org/pypi/coveralls)
C:\Users\RD\Anaconda3\pkgs_rd\coveralls-1.1>pip install setup.py
Error: could not find the version that satisfies the requirement setup.py
Version: Python 3.6.1 !Anaconda 4.4.0 (32-bit) ! (default, date, time) [MSC v.1 900 32 bit (intel)] on win32

To install coveralls-python please either use
pip install coveralls

to install the most recent release, or
python setup.py install
in your cloned repository to install from source. pip install setup.py would be searching the Python package repository for a package named setup.py.


Crashes audio drivers

For some reason, launching ComfyUI with this node pack in the custom_nodes folder crashes my sound drivers.

It both stops music from playing, as well as breaks the audio on videos currently playing.
Unfortunately I don't have any more information to share. I'm not getting any errors about it in the Comfy log.
This started happening after I took an update this last week.
It also happens with this node-pack:
https://github.com/dchatel/comfyui_facetools/issues/22
But not my other 94 node packs...
It was discussed here previously: https://github.com/comfyanonymous/ComfyUI/issues/4135

Try downloading the ComfyUI_windows_portable  again and only installing LayerStyle?

Try downloading the ComfyUI_windows_portable again and only installing LayerStyle?

I have done this.
I used a new fresh checkout of ComfyUI (though not the portable version).
And I have only LayerStyle in my custom_nodes folder, and I get the same result.

Thanks for your reply.
I have tried this. I used a new fresh checkout of ComfyUI (though not the portable version). And I have only LayerStyle in my custom_nodes folder, and I get the same result.
I have no idea what's going on though.

Sorry, I have no idea about this, If you get more detailed information, please let me know.

Will do! It's extremely weird behavior.
It has to be some kind of library that both this and facetools are using, and that library has to be broken on my end.
That makes the most sense to me. I was hoping someone would have any clue ^^


configmap e2e: use labels and label selector

The Bound Service Account Tokens feature creates a configmap kube-root-ca.crt in every namespace. Use a label to select the test objects we create.
/hold
wait for the tests to pass

/lgtm

/lgtm

https://travis-ci.org/github/kubernetes-client/python-base/jobs/752929229
=========================== short test summary info ============================
FAILED kubernetes/e2e_test/test_client.py::TestClient::test_configmap_apis - ...
FAILED kubernetes/e2e_test/test_watch.py::TestClient::test_watch_configmaps
============ 2 failed, 246 passed, 2 warnings in 165.50s (0:02:45) =============

The failing tests are in the python repo. The one in this repo has passed.
kubernetes/base/dynamic/test_client.py::TestDynamicClient::test_configmap_apis PASSED

/hold cancel

https://travis-ci.org/github/kubernetes-client/python-base/jobs/752929229
=========================== short test summary info ============================
FAILED kubernetes/e2e_test/test_client.py::TestClient::test_configmap_apis - ...
FAILED kubernetes/e2e_test/test_watch.py::TestClient::test_watch_configmaps
============ 2 failed, 246 passed, 2 warnings in 165.50s (0:02:45) =============

The failing tests are in the python repo. The one in this repo has passed.
kubernetes/base/dynamic/test_client.py::TestDynamicClient::test_configmap_apis PASSED

/hold cancel


[AIRFLOW-3040] Enable ProBot to clean up stale Pull Requests

Make sure you have checked all steps below.
Jira

[x] My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-3040
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.

Description

[x] Here are some details about my PR, including screenshots of any UI changes:

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
N/A

Commits

[x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[x] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

Codecov Report

Merging #3883 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3883      +/-   ##
==========================================
- Coverage   77.49%   77.47%   -0.02%
==========================================
  Files         200      200
  Lines       15887    15887
==========================================
- Hits        12312    12309       -3
- Misses       3575     3578       +3

Impacted Files
Coverage Δ

airflow/jobs.py
82.48% <0%> (-0.27%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b82fcb...d6732a5. Read the comment docs.


Fixing checkstyle issues in opencensus and opentelemetry extensions.

LGTM once the build passes

@xvrl Can you give a +1 again? Had missed a couple fixes earlier.

@xvrl : Build passed except one flaky test
https://confluentinc.semaphoreci.com/workflows/411b7614-a2d5-414c-97b6-e372bae2f95b?pipeline_id=c49dde08-853e-43b2-98a3-25dceddd9112
Can you approve this?


$PATH doesn't include java binary in adoptopenjdk/openjdk10 image

This makes it impossible to set an entry point as just 'java'.   I ran into this using jib-maven-plugin which has an opinionated build process that only allows 'java' as the entry point.

@jrivard I'm a it confused.  On your O/S do you not have to add $JAVA_HOME/bin to your $PATH?

@karianna I'm not sure what your asking exactly.  I'm talking about inside the docker image, not on my own OS.  The final image entry point is just 'java' and because that is not in the image's path it won't execute.  This doesn't have anything to do with my O/S.
A test case would be, if you run /bin/bash inside the image, you should just be able to run 'java' without specifying the full path to the binary.

@gdams the docker image 'adoptopenjdk/openjdk10'.  I don't know what homebrew is.

@jrivard Can you please update your docker image, I'm suspecting it to a very old one.
$ docker run --rm -it adoptopenjdk/openjdk10:nightly java -version
Picked up JAVA_TOOL_OPTIONS: -XX:+UseContainerSupport
openjdk version "10.0.2-adoptopenjdk" 2018-07-17
OpenJDK Runtime Environment (build 10.0.2-adoptopenjdk+13)
OpenJDK 64-Bit Server VM (build 10.0.2-adoptopenjdk+13, mixed mode)

$ docker run --rm -it adoptopenjdk/openjdk10 java -version
Picked up JAVA_TOOL_OPTIONS: -XX:+UseContainerSupport
openjdk version "10.0.1-adoptopenjdk" 2018-04-17
OpenJDK Runtime Environment (build 10.0.1-adoptopenjdk+10)
OpenJDK 64-Bit Server VM (build 10.0.1-adoptopenjdk+10, mixed mode)

Closing due to adoptopendjk11 release and this issue seems to be solved there.


bpffs: Cache mountinfo result

Scanning /proc/self/mountinfo whenever a map is opening is expensive as the
string scanning is CPU intesive.

This change is

test-me-please


[DOCFIX] Add metrics doc on k8s

Add how to get JSON metrics and Prometheus metrics on k8s.

@LuQQiu PTAL. Thanks!

@LuQQiu Organized it in a way that different sinks have their own sections of Config, Get snapshot, and Visualization. PTAL

alluxio-bot, merge this please


righs -> rights

This typo appears to be on all the pages but I figured I would just fix one and let you know :)

Thank you. I had missed it definitely.


Todo app - Step 44: Passes with incorrect code

Describe the Issue
The regex test allows you to pass with this code.
const deleteTask = (buttonEl) => {
  const dataArrIndex = taskData.findIndex(
    (item) => {
      item.id === buttonEl.parentElement.id
      buttonEl.parentElement.remove();
      taskData.splice(dataArrIndex, 1)
    }
  );
}

Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-localstorage-by-building-a-todo-app/step-44
Tests:
https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-localstorage-by-building-a-todo-app/64faf874364ec308f875f636.md
Your code

Expected behavior
To not pass with incorrect code.
Screenshots
No response
System

Device: [e.g. iPhone 6, Laptop]
OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 22]

Additional context
Forum: https://forum.freecodecamp.org/t/learn-localstorage-by-building-a-todo-app-step-44/719638/4

is an extra check needed to make sure the arrow function is not edited in this case?


Change spec and protocol id

When we changed the spec name we invalidated the old chain specs. This cleans up the old vitalam stuff by:

Change the runtime spec to not be tied to this "node"
Remove all instances of vitalam
Update the protocol id to dscp rather than vam

Note we will have to re-generate the staging chainspec but I can't do that yet

FYI the chain spec for this was created using:
./scripts/make-new-cluster-genesis.sh -o oem:oem:1152921504606846976 -o t1:t1:1152921504606846976 -o t2:t2:1152921504606846976 -v oem-0:oem:oem -v oem-1:oem:oem -a bn:oem:oem -a ipfs-bn-light:oem:oem -a api-ipfs-light:oem:oem -a id-light:oem:oem -v t1-0:t1:t1 -v t1-1:t1:t1 -a api-ipfs-light:t1:t1 -a id-light:t1:t1 -a api-ipfs-light:t2:t2 -a id-light:t2:t2  -c ghcr.io/digicatapult/dscp-node:v3.0.1-chore_change-spec-protocol-id inteli-stage

from the https://github.com/digicatapult/dscp-flux-infra repo. The companion PR that updates the secrets is at https://github.com/digicatapult/dscp-flux-infra/pull/20


Case consistency

WASM -> Wasm, GRAV -> Grav, etc.
We also have some sections in the sidebar in title case and others in headline case.

Closed by #https://github.com/suborbital/docs/pull/155


Template type checking for vue not work after upgrade v1.0.14

Vue doctor md show no errors.

Or how can i install another version?

v1.0.14 isn't working properly for me either.
E.g.

For builds to compile successfully right now you can install a previous version like so:
yarn add -D<EMAIL_ADDRESS>You can also change the installed version of volar:

Can you reproduce this problem in https://github.com/johnsoncodehk/volar-starter?


Emergency timeout of 5 minutes for clipper

Do not let users burn money if the clipper stalls too much.

Maybe implement with GNU timeout when calling clip :)

Made it 10 instead.


Tagged releases 2.7.91 and 2.7.92 are very confusing

The latest tagged release is 2.7.11, so it's really confusing that there are (very old) tagged releases named 2.7.91 and 2.7.92. :/

Just ran into this as well. Would be great if these tags could be removed or a new tag could be added.

Sorry for the confusion. I believe this is now fixed (per my tagging) but feel free to sing out if it is still an issue.


Allow message.fatal to be null

Based off #17, this allows a user to create a message that has the indeterminate fatal value of null.

How about a new .info method, like .fail, that sets fatal: null?
Reasoning: so this doesn’t need to be a major version, and so that we don’t have four (quite a lot) parameters in .message?

I like it, wasn't fond of the method signature either. Will amend.

Back with you @wooorm 👍

Looks good, could you remove that one referenced line, and include docs in the readme? It’s all ✅ if that’s done!

Done @wooorm, sorry I should've done that to begin with!

Thanks so much Brendan for working on this! 👏

Awesome, thank you!


Cannot acces some tabs on verified contract

https://scan.tomochain.com/address/0xecaeb3e5f5a918bf18491963216141e38847471d
Try clicking on Code or Read contract
Tested under ubuntu 18.04 x64:

Mozilla Firefox 65.0.1
Chromium 72.0.3626.121

known issue in 1.3.0, we are trying to fix it, thanks for creating the issue.

Fixed at some days ago


Enhance "save metrics" so that there are daily snapshots

Enhance the "save metrics" code so that metric data is save in daily snapshot files.  The system should maintain daily snapshots for the last 90 days.

I made changes to the code to implement this ability while addressing issue #8. Closing this ticket as fixed.


chore: swift-on-device local overrides

🚀 Deployed on https://66edc1bfde4e9a4815d732a8--cozy-fox-0defec.netlify.app


Adding new Ticket custom fields

Hi,
Thanks for making panichelpdesk available, nice work. I'm an integrator with just moderate coding  knowledge. How do we add new custom fields eg. Site Code, Device type, etc to tickets?
Regards,

Hi @mike1573, The only way I know to have it is to have a local fork of the package and make the customizations there. I still don't have enough advanced Laravel knowledge, and also I've not yet covered that functionality explicitly in the package, so for now I can't tell you any better option.
Please send me some feedback if you got a successful attempt with that.


Feature requests?

are you taking feature requests?

Ability to color the text (for example using a css class to show a red text for dangerous commands
The ability to use FontAwesome (or other) icon classes as image instead of having to provide the svg source.
Ability to group items. Like a Group of items replicating the main menu called "Main Menu" and a Group of items called "User Account" which contains things like password reset, 2fa and logout etc, and when filtered, for those bread crumb categories to be shown somehow like "User Account -> Set Up 2fa" see my crappy current implementation (my own js/css etc in screenshot)

Dark Mode :)

Hi Phil,
dark mode is already there :-)
<cmd-dialog theme="dark"></cmd-dialog>
 ```

> 1. Ability to color the text

I will add that

> 2. The ability to use FontAwesome

This is missing by intention, I don't want to limit users to specific service like Google Fonts or FontAwesome. [Lit element](https://lit.dev/) have his own shadow DOM and CDN source will be hardcoded in the element.

> 3. Ability to group items

I will thing about that, now there is a flat schema and fuzzy search will have an issue with structure.

It's a pet project, be patient please or you can send PR

Wow, the new GitHub cmd+k menu is great! I will definitely take some inspiration there :)


Will Asap7 be supported by openlane

Now asap7 is supported by openroad, but now openlane has a process starting from integration. How can I use openlane to support asap7  by using this tool?

Probably not, I'm afraid. It's not high on our priority list.


Filtering service plans by service broker id results in CF-DatabaseError

Issue
/v2/service_plans?q=service_broker_guid:<guid> fails with CF-DatabaseError.
Context
cloud_controller_v2 version 2.136.0
Steps to Reproduce
Run cf curl /v2/service_plans?q=service_broker_guid:<guid>.
Expected result
List of service plans for a specific service broker.
Current result
HTTP/1.1 500 Internal Server Error

{
   "description": "Database error",
   "error_code": "CF-DatabaseError",
   "code": 10011
}

Root Cause
The following database query is executed...

Changing the query in psql leads to another error: column reference "active" is ambiguous.

@philippthun, thank you for raising this issue.  We have managed to reproduce it, and are investigating the cause.

Hi @philippthun this has been fixed in https://github.com/cloudfoundry/cloud_controller_ng/pull/1385 so it should be in the next Cloud Controller release.
You can @ssisil if this is something you want to us to release soon. Thanks!


Real-valued features

Thanks for wapiti, great tool!
How hard would it be to make it possible to use real-valued features (as opposed to only binary features)? My use case is to exploit word embeddings and soft word classes. Currently they have to be discretized.

Not sure if I get you here but doesn't this depends on how you write your pattern. AFAIK, this only happens when you use %t.


Conditionally return target JSON root value

An empty JSONPath query (non-standard) or a query containing just the root identifier ($) will return the target JSON document in its entirety.
from jsonpath import findall

rv = findall("$", {'a': [1, 2, 3], 'b': 42})
print(rv)  # [{'a': [1, 2, 3], 'b': 42}]

But there is no way to conditionally return the target root (or an empty result/node list) using a filter selector. This is a known limitation in the IETF JSONPath Base. See https://github.com/ietf-wg-jsonpath/draft-ietf-jsonpath-base/issues/390.
We can stray into Python and use jsonpath.match().
from jsonpath import match

data = {'a': [1, 2, 3], 'b': 42}
rv = [data] if match("$[@ < 50]", data) else []
# ...

But that is not great or always an option.
One solution is to add an additional root identifier. A root Identifier that is functionally equivalent to wrapping the target JSON value in a single-element array. I suggest the circumflex (U+005E ^ aka caret) character for this purpose. I've been calling this the "fake root identifier".
from jsonpath import findall

data = {'a': [1, 2, 3], 'b': 42}

# Implicitly wrap `data` in an array.
<EMAIL_ADDRESS>< 50]", data)  # [{'a': [1, 2, 3], 'b': 42}]
<EMAIL_ADDRESS>> 50]", data)  # []

# Same as explicitly wrapping `data`.
<EMAIL_ADDRESS>< 50]", [data])  # [{'a': [1, 2, 3], 'b': 42}]
<EMAIL_ADDRESS>> 50]", [data])  # []

Closed by #51.


Site is broken while syncing large site to s3

Hello, and thanks for this great plugin.
I'm building a large e-commerce site with gatsby and s3-hosting where we have approx 25k pages which means there are approx 50k files that need to be synced (counting the page-data-files) to s3 when we deploy a new version. We have used your plugin to sync to the bucket which we use CloudFront in front of the bucket. Normally, everything goes smoothly.
However, when we are doing larger code changes (meaning almost all files will be changed), there are some issues with that the files are not uploaded fast enough. This means that the end-users will get an index.html file that points to page-data files that return 404 since they are not uploaded yet. This is a quite big deal for us as that means the site is unavailable for a couple of minutes (it takes a while to upload all 50k pages).
I'm really afraid of when we run into the problem that the sync to s3 fails halfway through, which would mean a broken build until the next build is up and running.
Do you have any good ideas on how we can solve this issue? I guess a good solution would be to do some kind of "bucket"-rotation, i.e ask your plugin to sync to a separate bucket and once that's finished, point CloudFront to the new bucket. Any ideas on how that can be done easily?
Thanks!

Hi Marcus,
I think your approach of using multiple buckets is a good idea. If you'd like to automate the process, you can use AWS CLI (or AWS SDK) to change the Origin of your CloudFront distribution.
When you run gatsby-plugin-s3 deploy you can use the --bucket CLI argument to specify which bucket you'd like to upload to.
Hope this helps,
Josh

Hi Marcus
In my team we also have the same problem, but we are uploading the files directly to s3 after compilation without using this plugin, I just wanted to use the plugin to solve the problem, but I see that not work
Did you solve the problem? If so, I would like to know how
Thanks


XX[0] OR XX[1]

May I ask if the XX [0] and XX [1] in your input represent two inputs of the original image

Yes, XX[0] and XX[1] represent the input of coarse stage and fine stage respectively. For example, XX[0] is 112x112 images and XX[1] is 224x224 images. More detail aboult this setting can be found at issue 3.

Thank you very much for your answer


Cannot find module in sveltekit project

Describe the bug
The module cannot find it's internal files, should be vite related problem but not sure.
To Reproduce
Steps to reproduce the behavior:

pnpm create svelte
Install @jsquash/png
Exclude optimization in vite.config.ts
import any @jsquash modules e.g. @jsquash/png
pnpm dev
See error

Reproduction URL
https://codesandbox.io/p/github/lknlknim/sveltekit-jsquash/main
Expected behavior
No error
Module Versions
2.1.4
Additional context
The import was located in /src/routes/image/+server.ts
Tried both npm / yarn / pnpm, all giving the same error.
Even copy the module folder to local folder won't work
What I was trying to achieve is to make it available on Cloudflare Pages functions(Cloudflare Worker) with Sveltekit to get rid of Cloudflare Image and Cloudflare Image Resize.

This is because you're trying to run it Server Side in Node.js. As stated in the README, this package is built for the Browser. Node.js cannot import wasm files like the browser does 😿 .
There are much better image libraries already out there for Node.js that I can recommend:

Sharp - High performance Node.js image processing
Libsquoosh - From the creators of squoosh.app, it's no longer maintained but still works. Even production Next.js falls back to it.

If you want to dynamically process images you could try create a Cloudflare Worker with the Page Functions, however I am not familiar with that (Functions Documentation).
Best of luck! 🤞

Thanks for the quick response. I still got little confusion. So does it support V8 WITHOUT BROWSER?
I was trying to do what you're saying. Sveltekit with svelte-adapter-cloudflare will bundle the whole website into Cloudflare Pages, and all server endpoints are extracted into single workers file aka Pages Functions / Cloudflare workers.
Do you mean this library ONLY not working in development because of Node.js, and it'll work in Cloudflare Workers in production?
In fact I did tried Cloudflare Workers with wrangler dev in local and it's not working too. I'll try to deploy that and test.

I can't build with sveltekit project, the entry file can be found but the sibling files can't be found.
import { error } from '@sveltejs/kit';
import { dev } from '$app/environment';

import { IMAGE_ID_KEYWROD } from '$lib/config/keyword';
import { getObject } from '$lib/server/cloudflare/r2';
import { IMAGE_BUCKET_PATH } from '$lib/server/cms/image';

import decodeJpeg, { init as initJpegWasm } from<EMAIL_ADDRESS>import encodePng, { init as initPngWasm } from<EMAIL_ADDRESS>import JPEG_DEC_WASM from '../../../node_modules/@jsquash/jpeg/codec/dec/mozjpeg_dec.wasm?url';
import PNG_DEC_WASM from '../../../node_modules/@jsquash/png/codec/squoosh_png_bg.wasm?url';

export function GET({ platform, url }) {
	const id = url.searchParams.get(IMAGE_ID_KEYWROD);
	if (!id) {
		throw error(412, 'Missing ID');
	}

	return getObject(platform!, `${IMAGE_BUCKET_PATH}/${id}`).then((object) => {
		if (!object) {
			throw error(404, 'Image not found');
		}

		if (dev) {
			return new Response(object.body);
		}

		return object
			.arrayBuffer()
			.then((buffer) =>
				Promise.all([initJpegWasm(JPEG_DEC_WASM), initPngWasm(PNG_DEC_WASM)])
					.then(() => decodeJpeg(buffer))
					.then((data) => encodePng(data))
			)
			.then((buffer) => new Response(buffer));
	});
}

import { sveltekit } from '@sveltejs/kit/vite';
import { defineConfig } from 'vite';
import mkcert from 'vite-plugin-mkcert';
import autoprefixer from 'autoprefixer';

export default defineConfig({
	server: { https: true },
	plugins: [sveltekit(), mkcert()],
	css: {
		postcss: {
			plugins: [autoprefixer()]
		}
	},
	optimizeDeps: {
		exclude: [
			'@jsquash/jxl',
			'@jsquash/avif',
			'@jsquash/webp',
			'@jsquash/png',
			'@jsquash/jpeg',
			'@jsquash/resize'
		]
	},
	build: {
		rollupOptions: {
			plugins: [],
			external: [
				'@jsquash/jxl',
				'@jsquash/avif',
				'@jsquash/webp',
				'@jsquash/png',
				'@jsquash/jpeg',
				'@jsquash/resize'
			]
		}
	}
});

node:internal/event_target:1083
  process.nextTick(() => { throw err; });
                           ^
Error [ERR_MODULE_NOT_FOUND]: Cannot find module 'C:\Projects\travel-suggest\node_modules\.pnpm\@jsquash+jpeg@1.2.0\node_modules\@jsquash\jpeg\utils' imported from C:\Projects\travel-suggest\node_modules\.pnpm\@jsquash+jpeg<EMAIL_ADDRESS>    at new NodeError (node:internal/errors:406:5)
    at finalizeResolution (node:internal/modules/esm/resolve:233:11)
    at moduleResolve (node:internal/modules/esm/resolve:845:10)
    at defaultResolve (node:internal/modules/esm/resolve:1043:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:383:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:352:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:228:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:85:39)
    at link (node:internal/modules/esm/module_job:84:36)
Emitted 'error' event on Worker instance at:
    at [kOnErrorMessage] (node:internal/worker:326:10)
    at [kOnMessage] (node:internal/worker:337:37)
    at MessagePort.<anonymous> (node:internal/worker:232:57)
    at [nodejs.internal.kHybridDispatch] (node:internal/event_target:807:20)
    at exports.emitMessage (node:internal/per_context/messageport:23:28) {
  url: 'file:///C:/Projects/travel-suggest/node_modules/.pnpm/@jsquash+jpeg@1.2.0/node_modules/@jsquash/jpeg/utils',
  code: 'ERR_MODULE_NOT_FOUND'
}

I also can't build with the with-vite example, is there extra steps to do?
I just git cloned it, pnpm i then pnpm build
PS C:\Projects\jSquash\examples\with-vite> pnpm build

><EMAIL_ADDRESS>build C:\Projects\jSquash\examples\with-vite
> vite build

vite v4.5.0 building for production...
transforming (34) node_modules\.pnpm\@jsquash+jxl<EMAIL_ADDRESS>early exit. This happens when Promises returned by plugins cannot resolve. Unfinished hook action(s) on exit:
(commonjs--resolver) resolveId "./codec/enc/avif_enc_mt" "C:/Projects/jSquash/examples/with-vite/node_modules/.pnpm/@jsquash+avif<EMAIL_ADDRESS>(commonjs--resolver) resolveId "./codec/enc/jxl_enc_mt_simd" "C:/Projects/jSquash/examples/with-vite/node_modules/.pnpm/@jsquash+jxl<EMAIL_ADDRESS>(commonjs--resolver) resolveId "./codec/enc/jxl_enc_mt" "C:/Projects/jSquash/examples/with-vite/node_modules/.pnpm/@jsquash+jxl<EMAIL_ADDRESS>(vite:worker-import-meta-url) transform "C:/Projects/jSquash/examples/with-vite/node_modules/.pnpm/@jsquash+avif<EMAIL_ADDRESS>(vite:worker-import-meta-url) transform "C:/Projects/jSquash/examples/with-vite/node_modules/.pnpm/@jsquash+jxl<EMAIL_ADDRESS>(vite:worker-import-meta-url) transform "C:/Projects/jSquash/examples/with-vite/node_modules/.pnpm/@jsquash+jxl<EMAIL_ADDRESS>error during build:
Error: Unexpected early exit. This happens when Promises returned by plugins cannot resolve. Unfinished hook action(s) on exit:
(commonjs--resolver) resolveId "./codec/enc/avif_enc_mt" "C:/Projects/jSquash/examples/with-vite/node_modules/.pnpm/@jsquash+avif<EMAIL_ADDRESS>(commonjs--resolver) resolveId "./codec/enc/jxl_enc_mt_simd" "C:/Projects/jSquash/examples/with-vite/node_modules/.pnpm/@jsquash+jxl<EMAIL_ADDRESS>(commonjs--resolver) resolveId "./codec/enc/jxl_enc_mt" "C:/Projects/jSquash/examples/with-vite/node_modules/.pnpm/@jsquash+jxl<EMAIL_ADDRESS>(vite:worker-import-meta-url) transform "C:/Projects/jSquash/examples/with-vite/node_modules/.pnpm/@jsquash+avif<EMAIL_ADDRESS>(vite:worker-import-meta-url) transform "C:/Projects/jSquash/examples/with-vite/node_modules/.pnpm/@jsquash+jxl<EMAIL_ADDRESS>(vite:worker-import-meta-url) transform "C:/Projects/jSquash/examples/with-vite/node_modules/.pnpm/@jsquash+jxl<EMAIL_ADDRESS>    at process.handleBeforeExit (file:///C:/Projects/jSquash/examples/with-vite/node_modules/.pnpm/rollup@3.29.4/node_modules/rollup/dist/es/shared/node-entry.js:25902:28)
    at Object.onceWrapper (node:events:629:26)
    at process.emit (node:events:514:28)
 ELIFECYCLE  Command failed with exit code 1.

Thanks @lknlknim, alas, I don't think currently I can make this work for your use case.
You have encountered two problems from the provided code.
One is a bug in Vite (#37) that is blocking modules that use multi-threading.
The second is some issues I'd need to solve to support Node.js. I've documented them in #38, however, I can't guarantee any timeline where I can fix that. Perhaps there might be some other WebAssembly libraries out there that would work for your scenario?

I did some experiments and made it works on Cloudflare Workers, both local and production. Seems like what I was trying to do is impractical.
Having both jpeg/png/webp/avif/hxl, decode/encode, resize into 1 Workers will bloat the bundle size to >6MB where Workers free tier is limited to <1MB. So even if we can build it with Sveltekit we still can't deploy to Cloudflare Pages free tier and even if it does it'll potentially extend the boot time. It's better to use with standalone Workers instead of gluing with web frameworks which is having tighter bundle size budget.
With Cloudflare Pages/Workers we can use service binding to invoke standalone Workers without external request. And splitting this into 11 standalone Workers for each image format may do the tricks.


Feature/tailwind prefix

This pull request will contain two features:

Config rollup postcss to inject build styles at the very top of the Consumer project so plugin styles can easily overwrite if necessary.

Prefix all tailwind classes so in the situation that the Consumer project is using tailwind as well, there will be no conflicts between the plugin and the Consumer.

Breaking changes:

class skt-w-container has been renamed to skt-w-root-container since the old name had conflicted with a tailwind class with the same exact name.

Hey @hikack everything looks good to me. Thanks.


onBlur not firing on Textfield with label prop "Email"

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example:

https://codesandbox.io/s/material-ui-email-focus-bug-gfccrk?file=/src/App.js

Steps:
0. Only on Chrome (Open Chrome)

Import TextField component and
Place two Textfields on the page one with the label="Email"
Tab through Inputs
Result: TextField with label="Email" will never lose its focus.

Current behavior 😯
Any TextField with the label set to "Email" will not fire onBlur
Expected behavior 🤔
Tabbing away from a TextField with the label set to "Email" should fire the onBlur method
Context 🔦
onBlur should remove the Mui focused styles and trigger any validation I want to do on an input
Your environment 🌎

npx @mui/envinfo
   Browser: Chrome
    System:
    OS: macOS 12.6
  Binaries:
    Node: 16.17.1 - ~/Library/Caches/fnm_multishells/42802_1667242433233/bin/node
    Yarn: 1.22.19 - ~/.yarn/bin/yarn
    npm: 8.15.0 - ~/Library/Caches/fnm_multishells/42802_1667242433233/bin/npm
  Browsers:
    Chrome: 107.0.5304.87
    Edge: Not Found
    Firefox: 106.0.2
    Safari: 16.1
  npmPackages:
    @emotion/react: 11.10.4 => 11.10.4
    @emotion/styled: 11.10.4 => 11.10.4
    @mui/base:  5.0.0-alpha.99
    @mui/core-downloads-tracker:  5.10.7
    @mui/icons-material: 5.10.6 => 5.10.6
    @mui/material: 5.10.7 => 5.10.7
    @mui/private-theming:  5.10.6
    @mui/styled-engine:  5.10.7
    @mui/system:  5.10.7
    @mui/types:  7.2.0
    @mui/utils:  5.10.6
    @mui/x-date-pickers: ^5.0.4 => 5.0.4
    @types/react: 18.0.19 => 18.0.19
    react: 18.2.0 => 18.2.0
    react-dom: 18.2.0 => 18.2.0
    typescript: 4.8.3 => 4.8.3

Do you have any password manager plugins installed? I could reproduce the bug, but when I disabled my 1Password, it started to work correctly.

Is this something that I need to report with 1Password or something ya'll are going to handle?

@michaldudak , I started a discussion with 1Passowrd. this is def a 1pass bug. I updated the sandbox to show the same behavior with a regular input type=email. Thanks again for your quick response. I will update this thread once i hear back from them.


24 hour timestamps not working in Compact mode

(original issue #315 )
This option seems to only work in Cozy message display mode, enabling it for Compact mode does not change any timestamps to 24h format.

Update: I personally don't need any need for this option anymore since Discord now allows you to change the UI language which will affect how the timestamps are displayed. Changing the language to English UK will enable 24h format while keeping everything in English.

I don't think English UK has been there a while ago when I last checked for it, but I suppose sinceit's there now I don't need it anymore either.


Changing "when" to "onResolve" or "onComplete"

It doesn't matter for normal promises, but I think it matters for more advanced use cases where the promise API is just one way of consumption. Looking at a list of functions, onResolve / onComplete are way more expressive than when.

Specifically when just tells that it's something event based, but not on which event the callback is fired. Could be when new data is available on a stream or when there's an error or when …. onResolve clearly indicates which event happens.

onComplete definitively means finished. Other Apis that make requests typically use onComplete. onResolve is using yet more terminology that makes entry into things like amp even more prohibitive.  Complete > Resolve.

@J7mbo Somebody mentioned complete would indicate success. I don't necessarily think so, just mentioning in case others feel that way.

complete sounds like the complete action itself instead of the event being fired.

@kelunik Well take a look at jQuery (great example, I know!), I think we had onSuccess, onFail and onComplete, the latter was always executed. Then again that's now .success, .error and .always so not entirely a great comparison. Complete is a positive word so maybe it indicates success. How about onFinish?

@PeeHaa A promise is a placeholder for the outcome of an operation. And that operation is complete then. It won't change anymore.
@J7mbo They still have complete. I like onComplete more than onFinish, can't really tell why. Neither does really fit with Promise though. And we already have resolve on the Deferred part.

Also ping @rdlowrey

In some contexts onComplete makes more sense and in some contexts onResolve makes more sense, but promises resolve, they don't complete. However, I think part of the issue here is that you are implementing Promise directly in places where you shouldn't. For example, I don't think it makes sense for a stream to implement Promise directly a stream isn't primarily a placeholder for some single future value.
function ($stream) {
    yield $stream; // this doesn't read well at all. What are we even waiting for here?
}

I would prefer this:
function ($stream) {
    yield $stream->awaitEnd();
}

Regarding the name when(), I'm struggling to think of a context in which it makes sense:
a()->when($b); // in English this reads as "do $a when $b", which is the opposite of what the code does

@joshdifabio One such example of (optional) emits as a stream is Artax. The main purpose of request is to return the response, but it emits updates as Artax opens sockets, completes TLS handshakes and follows redirects.

@kelunik

And that operation is complete then.

My point was that calling the method complete tells me it's the action if completing something instead of onComplete telling me it's an event based on the completion.

Oh, I didn't mean complete as a method name, but the complete in onComplete.
As we have Deferred::resolve, Promise::onResolve makes sense.

@bwoebi You wanted 2-3 days to think about it. How do you feel now?

I still really don't like it.
I do not feel like it helps understanding anything.
For random API parts, more expressive names are typically fine.
when() however is quite a unique part of the API. It's not your typical callback, but you need to exactly know what it is. Calling it onResolve just tells you a small part of its function. But it lets you ask another question: "When is a Promise resolved? What will resolve it?" As such, you either way need to have a closer look at the documentation, at which point there's no advantage of calling it onResolve() vs when().
when() is simply just short and concise. Moreover when() sounds a bit like then(), suggesting for people from other Promise APIs that it must be related, making it easier for them.
onResolve() feels like a step backwards for me.

Not saying I disagree with the gist @bwoebi, but saying something sounds like something else to make something more clear is weird imo.

It's just a single advantage, not the whole argument ;-)
It's more the type of thing which would make me decide on something if all other advantages and disadvantages are about equivalent.

I do not feel like it helps understanding anything.

It makes the API consistent. We have Deferred::resolve, why introduce a new term when instead of using the existing API name?

when() however is quite a unique part of the API. It's not your typical callback, but you need to exactly know what it is.

You can bring that argument for every single name. It's not an argument.

when() is simply just short and concise. Moreover when() sounds a bit like then(), suggesting for people from other Promise APIs that it must be related, making it easier for them.

Indeed, and that's an argument against using when(). Because it's really not then(), but rather similar to done(). It's not chainable, you shouldn't throw in it, and it doesn't make sense to return a value from it.

onResolve() feels like a step backwards for me.

Could you explain why it's backwards?

It makes the API consistent. We have Deferred::resolve, why introduce a new term when instead of using the existing API name?
The Deferred is just one implementation, which returns a Promise when some method is called. It's a separate API from Promise. It makes sense to model the naming of the Deferred methods after the method(s) of the Promise, but not vice-versa.
You can bring that argument for every single name. It's not an argument.
Most APIs do not have so much complexity behind. - No.
Indeed, and that's an argument against using when(). Because it's really not then(), but rather similar to done(). It's not chainable, you shouldn't throw in it, and it doesn't make sense to return a value from it.
I just disagree. If it were the same, we'd call it then(). Throw/return/chain are just one thing: it transforms the promise. There's the only difference. We do not return a transformed promise. For everything else, it's quite the same thing.
Could you explain why it's backwards?
Our current naming is totally fine and you're proposing something worse…

The Deferred is just one implementation, which returns a Promise when some method is called. It's a separate API from Promise. It makes sense to model the naming of the Deferred methods after the method(s) of the Promise, but not vice-versa.

It's the standard implementation. resolve + onResolve work fine together, it's clear from the name that they're related. Can you propose something for Deferred matching when?

Throw/return/chain are just one thing: it transforms the promise. There's the only difference.

It's not the only difference. The second difference is one callback instead of two. And transforming the promise or not is exactly the difference between then and done.

Can you propose something for Deferred matching when?

resolve perfectly matches when … when callbacks are triggered basically upon the state change of the Promise. That state change is triggered by resolving, so that's totally fine.

It's not the only difference. The second difference is one callback instead of two. And transforming the promise or not is exactly the difference between then and done.

Well, I never liked the name done() … But I'd even prefer done() over onResolve() … it's just too clumsy for me...

Our promises aren't really complex, they're quite simple, as they don't have any chaining or something like that. They just fire a simple callback (or a set of them) on resolution.

Tell that someone who's never interacted with Promises in his life ;-)

the state change of the Promise

In that case our streams shouldn't extend Promise.

Well, I never liked the name done() … But I'd even prefer done() over onResolve() … it's just too clumsy for me...

Using done is only possible if we use two callbacks, otherwise it's not compatible with other existing implementations.

Tell that someone who's never interacted with Promises in his life ;-)

Not being able to understand things is mostly not due to promises, but rather due to generators or not understanding the event loop is the scheduler.


Fixes for RuntimeExceptions in maintenance Runnables, NPE caused by missing TTL on DNSSEC keys, only create SignedZoneKeys for Names that have keys, and fixed an oversight where we weren't converting to millis when calculating next refresh for a given SignedZoneKey.

closes #904


cp wpa_supplicant.conf

rm -rf tmp
[ -f wpa_supplicant.private.conf ] && \ 		cp wpa_supplicant.private.conf boot/wpa_supplicant.conf || \ 		cp tmp/wpa_supplicant.conf boot/wpa_supplicant.conf
cp: tmp/wpa_supplicant.conf: No such file or directory
make: *** [boot/wpa_supplicant.conf] Error 1
wpa_supplicant.conf exists and is populated with credentials

Yeah, I use a .gitignored wpa_supplicant.private.conf, because I want wpa_supplicant.conf to be a blank template that can be safely committed to a repo.
I'll obv fix it, but I have to figure out how to validate it properly first.
For now you can:
cp ./wpa_supplicant.conf ./wpa_supplicant.private.conf
make write_stuff_to_boot SD=/dev/…

SD= parameter above is optional in case /Volumes/boot is not mounted.
Running make write_stuff_to_boot skips the lengthy image writing process and skips straight to only copying all us-specific files. It's safe to re-run it multiple times as long as the card wasn't run in the RBP yet.

Very good to know about ‘make write_stuff...’


Python 3.7 breaks cocotb because of changes in the logging framework

When running cocotb testbenches on Python 3.7 I get the following traceback
Traceback (most recent call last):
  File "/run/media/andy/Data/Autocopter/fpga/rectification/cocotb/cocotb/__init__.py", line 68, in <module>
    log.setLevel(_default_log)
  File "/usr/lib/python3.7/logging/__init__.py", line 1308, in setLevel
    self.manager._clear_cache()
  File "/usr/lib/python3.7/logging/__init__.py", line 1267, in _clear_cache
    logger._cache.clear()
AttributeError: 'SimBaseLog' object has no attribute '_cache'

It seems that python now tries to clear some cache on a log level change if the logger has Logger as a base class. It is not immediately obvious to me how to fix this except adding a dummy _cache member and giving it an empty clear function.

Nevermind. Fixed it: https://github.com/potentialventures/cocotb/pull/647


Problem with overwriting value

this is a hotfix for the problem #687
fixes #687
The real fix needs to be removing this patch https://github.com/Microsoft/sqlopsstudio/blob/master/src/vs/platform/configuration/common/configurationModels.ts#L101 because its important for catching these kind of problems in the future.

@anthonydresser regarding moving the isFrozen patch is a bunch of the SQL Ops code assumes the configurations aren't readonly.    We'll need to rewrite several blocks of code to enable that, but I agree we should do that.

@anthonydresser I'll merge this now and kick off new builds for Feb release testing.


Game plays without sound when battery is low due to battery warning

I'm not sure if this is intentional or not but when I launch a game, the text-to-speech voice plays "Urgent warning: your battery level is at n%" and then the game proceeds to launch albeit with no sound. When the console (R36S in my case) is plugged in to DC prior to launching the game, the game audio plays as does normally.

Then charge your device.  It will start exhibiting other issues when the battery is low as well.  If you prefer to live on the edge, you can turn off the battery level warning in ES in the start menu>sound settings.


adds download files job

Fixes #691

Hmm not sure why SimpleCov isn't working.  Maybe the tests just need ran again?
Other than my one question above this LGTM.

The glacial test fixes were merged to main so those changes can now be merged here.


Implement Custom Clientside Scalars

This PR enables custom scalar parsing on the client side. Values are parsed lazily, only when accessed.
As default, the following scalars are implement as follows:
DateTime: (value: string) => new Date(value),
Date: (value: string) => new Date(value),
Time: (value: string) => new Date(value),
JSON: (value: string) => JSON.parse(value),

Arrays and nested arrays of custom scalars are supported.
Custom parsing implementations can be configured with the .init function:
import dates from "./dates";

dates.init({
    scalars: {
        DateTime: (v: string) => new Date(new Date(v).getTime() * 1.2),
    },
});

This feature is similar to what is being discussed at Apollo Client here: https://github.com/apollographql/apollo-feature-requests/issues/368
Right now only the canonical examples Date and JSON are supported, because not only the custom parse function is needed, but also a type mapping.
For this, the question is if it has to be either provided on codegen-time or it can be configured in runtime with a config-factory approach, where a type generic is passed and thus assigns the right type to the fields in Typescript.


feat: auto detect storage volumeMount while setting it in volumeMounts

Description
Now we could only use PVC or emptyDir storage for seek-peer in this helm chart. I add a detection in extraVolumeMounts if user sets storage in volumeMounts when there's no persistent storage
Related Issue

Motivation and Context

I've successfully fix lint, is there any progress？