Flutter-bug

======== Exception caught by widgets library =======================================================
The following assertion was thrown building ProductsHome(dirty, dependencies: [MediaQuery], state: _ProductsHomeState#22e31):
textBaseline is required if you specify the crossAxisAlignment with CrossAxisAlignment.baseline
'package:flutter/src/widgets/basic.dart':
Failed assertion: line 4369 pos 15: 'crossAxisAlignment != CrossAxisAlignment.baseline || textBaseline != null'
Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
https://github.com/flutter/flutter/issues/new?template=2_bug.md
The relevant error-causing widget was:
ProductsHome file:///E:/MyProjects/FlutterProjects/bessi/bessi_app/lib/posts/products.dart:25:13
When the exception was thrown, this was the stack:
#2      new Flex (package:flutter/src/widgets/basic.dart:4369:15)
#3      new Row (package:flutter/src/widgets/basic.dart:4739:8)
#4      _ProductsHomeState.build (package:bessi_app/posts/products.dart:453:36)
#5      StatefulElement.build (package:flutter/src/widgets/framework.dart:4691:27)
#6      ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4574:15)
...

Hi @AbbasHoseini,  when filing issues please try to fill all or some of the information requested in the issue template.

Issue Template
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
- https://flutter.dev/
- https://api.flutter.dev/
- https://stackoverflow.com/questions/tagged/flutter?sort=frequent

If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports

Steps to Reproduce

Please tell us exactly how to reproduce the problem you are running into.

Please attach a small application (ideally just one main.dart file) that
reproduces the problem. You could use https://gist.github.com/ for this.

If the problem is with your application's rendering, then please attach
a screenshot and explain what the problem is.

1. ...
2. ...
3. ...

Please tell us which target platform(s) the problem occurs (Android / iOS / Web / macOS / Linux / Windows)
Which target OS version, for Web, browser, is the test system running?
Does the problem occur on emulator/simulator as well as on physical devices?

Target Platform:
Target OS version/browser:
Devices:

Run your application with `flutter run --verbose` and attach all the
log output below between the lines with the backticks. If there is an
exception, please see if the error message includes enough information
to explain how to solve the issue.

Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.

Finally, paste the output of running `flutter doctor -v` here.

Please share the details  requested in the above template to better address the issue.
Thank you.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


OSMDashboard Mapping : Highlight Trails Based on Frequency with Consistent Width

Describe briefly your feature:
This feature allows users to visualize their most frequently walked paths on a map with a trail thickness corresponding to how often they walk that path. The width of the trail should remain consistent even when zooming in or out of the map.
Describe the solution you'd like:

Implement a mechanism to track the number of times a user walks a specific path.
When displaying the map, calculate the thickness of each trail segment based on its corresponding walk frequency data. More frequently walked paths should have a greater thickness.
Ensure the trail width remains consistent regardless of the map zoom level. This can be achieved by adjusting the width based on the zoom level or using a dynamic line width that scales with the zoom.

Describe alternatives you've considered:

Using different colors to represent trail frequency instead of thickness. This might be less intuitive for users.
Disabling the zoom-independent width altogether. This could lead to trails becoming too thin or thick at different zoom levels, making it difficult to see the map details.

Additional Context:

Issue Closed.


Cross-compile for Windows and others; automate this

Ideally, we should have a makefile entry for a cross-compilation to Windows and, ideally, it could be tested on Wine (and, absolutely ideally, tested automatically via travis --- but currently this involves compiling a custom GHC, so we'd hit the travis timeout).
Edit: I've split off just creating binaries for OSX as #77.
Edit: I've split off just creating binaries for Windows as #78.

It's now getting easier, thanks to ingenuity of many hackers, but I've found that it's easiest for me to compile using the Windows Ci service AppVeyor. I hope the service stays long as good as it is now, so I'm closing the issue.


chore: bump logflare version

This will include bugfix for https://github.com/supabase/supabase/issues/22605, as well as many other improvements to the ingestion pipeline

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 60.063%

Files with Coverage Reduction
New Missed Lines
%

internal/gen/keys/keys.go
5
11.76%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
6870

Relevant Lines:
11438

💛  - Coveralls

on hold, need to do a hotfix.


docs: add story about configuring HMR

This story explains how to configure HMR for an Angular app.
A link to this story could be used in the warning text that appears when running ng serve --hmr.

Maybe change this link to point to this story instead? https://github.com/angular/angular-cli/blob/2be0bf2d533e75617da0db034ffc2dc9cd5555db/packages/%40angular/cli/tasks/serve.ts#L79

Hey @filipesilva, thanks for reviewing.
I updated the index you mentioned and rebased off master.

Hello, I'm kinda confused on what's the right way of setting up HMR. I read your guide and the one provide by angularclass/angular-hmr. Both are completely different. The one provided by you is really simple, but lacks of demonstration how it would work with some store in my case ngrx/store. The one from angularclass, uses some hooks in order to do same things plus coordinate the store, delete ng generated styles and etc. So I wander, is it possible to do the same with your example and how. probably this has nothing to do with angular-cli, but anyways I want to understand why there are those both ways of setting up HMR and which one is correct


Implemented fully BMI compliant transport code into troute

Conversion of data frames in the DA forcing module into BMI compliant arrays and reassembly in troute: wrote routines for all dataframe import into troute, and applied it to most dataframes
Additions

Modules with auxiliary functions to help convert dataframes to/from arrays:

-- bmi_df2array: Functions to disassemble dataframes into constituent numpy arrays (or individual variables) of either integer or float types. This includes converting any string-based dataframe entries (such as gauge IDs) to arrays based on ASCII-encoding, wherein one string array-like object gets converted into two 1D numpy arrays: a series of ASCIIs in one int array and an array comprised of the length of each string entry. Datetime entries are converted to seconds relative to a troute-internal time reference (which is, a priori, arbitrary).
-- bmi_array2df: The reverse of the latter. If applicable (for string-like entries such as gauge IDs), first reassembling a list of strings from the two constituent files (ASCII encoded array and ASCII string length array); or, for time arrays, reassembling lists of Datetime objects. Then, reassemble the applicable dataframes.
Removals

On the t-route side, the dataframe import option is kept as a debugging feature, which can be enables through the flag "legacy_bmi_df" in DataAssimilation. This shall be removed in the near future.

Changes

Lion's share of the code changes are in model_DAforcing (dataframe -> array conversions), and DataAssimilation (array conversions -> dataframe. The latter is implemented in the {NudgingDA, PersistenceDA, RFCDA} child classes of AbstractDA.

In the (dataframe -> array) direction, the following dataframes were converted: usgs_df, reservoir_usgs_df, reservoir_usace_df, reservoir_rfc_dataframe, q0/t0, waterbody_df, lastobs

In the (array -> dataframe) direction, the following dataframes were implemented for bmi import into troute: usgs_df, reservoir_usgs_df, reservoir_usace_df, reservoir_rfc_dataframe. There was existing code for the last three (lite_restart and lastobs), which shall be harmonized with the current commit in the near future.

Testing

Should not interfere with normal operation. A full-featured BMI test case will be constructed.

Screenshots
Notes

Todos

Harmonizing lite_restart and lastobs code with the existing additions.

Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows project standards (link if applicable)
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist
Target Environment support

[ ] Windows
[ ] Linux
[ ] Browser

Accessibility

[ ] Keyboard friendly
[ ] Screen reader friendly

Other

[ ] Is useable without CSS
[ ] Is useable without JS
[ ] Flexible from small to large screens
[ ] No linting errors or warnings
[ ] JavaScript tests are passing

Checks have passed now, adapted location of modules in folder structure


chore: Lock environment installation file versions

Issue #, if available:
Description of changes:
chore: Lock environment installtion file versions
I tested the new bootstrap.sh script on Sagemaker, EMR, EC2-linux, and RStudio. All four workspace types could read and write from mounted studies.
I built a new AMI with provision-rstudio.sh file and the RStudio instance was able to read and write from mounted studies.
Checklist:

[x] Have you successfully deployed to an AWS account with your changes?
[x] Have you successfully tested with your changes locally?

AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jn1119

Have you verified the vendor guidance for the specific versions added here? Are they safe to use security/bug wise and are actively been supported?

I looked into finding the security release notes of the software, and was unable to find security and vendor guidance for all the software. What I can confirm is that all of the software we're using and locking down, is the latest version that is available on YUM for our linux server. Since they're the latest version that is available, I think it would be safe to assume that all bug/security related issues that are known and solvable has been resolved.

According to codecov there is a branch coverage drop by more than one percent. Do you know why the check still passes? My assumption was that any drop more than 0.1 percent will fail the check.

Looks like the check is now failing as expected. I think CodeCov is not analyzing this PR correctly. It might be because this PR only has changes in scripts, which isn't testable. The drop in coverage is an error and is probably a result of this
https://github.com/awslabs/service-workbench-on-aws/pull/470/checks?check_run_id=2520195837
 project root: .
    Yaml found at: codecov.yml
    -> Found 1 reports
==> Detecting git/mercurial file structure
==> Reading reports
    - file not found at ./coverage/coverage-final.json
--> No coverage data found.

The drop is a false alarm because CodeCov wasn't able to find coverage-final.json


more examples would be helpful

I am new to semantics and I am not really able to figure out exactly how it works .bootstrap has a format like

            Blah blah

            Blah blah

In semantic I am not able to find equivalent to .container I guess it is .ui.page but it doesn't exactly behave as one
What I am suggesting is please create some example pages so that newcomers like me who are used to bootstrap can quickly get started with semantics .Best part would be to convert these [bootstrap examples] (http://getbootstrap.com/getting-started/#examples) to their semantic equivalents to help new developers to get started quickly.

I'm new to semantic-ui & I'm experiencing the negative margin-top too when trying to use .ui.page.grid to mimic bootstrap's .container as suggested here: http://stackoverflow.com/a/28676816
My html is as followed:
  body.menu.pushable
    .ui.fixed.inverted.menu
      .ui.page.grid
        .left.menu
          a.item(href='#') Brand
          a.item(href='/dashboard') Dashboard

        .right.menu
          a.borderless.item(href='/logout') Logout

    .pusher
      .full.height
        .main.container
          block content
      .ui.footer.vertical.segment

Can anyone explain why it is happening & the semantic-ui way to resolve this? Also is there any update on the progress of adding .container support?

Container is in 2.0 which will be available june 1st. You are probably experiencing collapsing margins.


color should be same as bg of PARENT

Fixes Issue #37
(use --ED-surface-4 for text color)

About to board. Will take care of this tomorrow.

Yeah, it's a useful trick. CSS before custom properties was a pain!


Chat - Suggestion list is not shown for new email and new chat

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to https://staging.new.expensify.com/
Tap on Fab
Tap new chat
Enter a new email id, a new user for a new chat
and select it
Enter @ in compose and enter new email of new chat just created

Expected Result:
When user enters @ in compose and enter new email of new chat just created, the suggestion list must display the new email with avatar
Actual Result:
When user enters @ in compose and enter new email of new chat just created, the suggestion list does not display the new email
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.67-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentatio
https://github.com/Expensify/App/assets/78819774/5f4d39bd-f5b8-49cf-8a23-26e13bfa5c75
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Checking with the team https://expensify.slack.com/archives/C049HHMV9SM/p1695028446884819

No response, I need to bump this tomorrow morning

bumped

Chatted with Kevin in person and the decision is that this is a feature, not a bug. The new email is not yet validated so they can't be tagged.


0 value features causing issues with reverse scaling

Hello -
I was getting some nonsense loss function results in my final prediction (ex: MSE >100000 for 0-1 scaled features) and I believe I figured out the source of the issue.
I believe the reverse scaling function was having an issue with my "precipitation" features, which are normally 0. I am working on my own fix but just wanted to pass along.

That's strange, let me know if you find anything. I guess the standard normalization scheme might have stability issues if std dev is very low? We've tested on a dataset  that also involves precipitation and has lots of 0s with poor results. Maybe related to this issue...


Source $TMPDIR variable if it exists

Would fix #250.

Coverage decreased (-5.6%) to 32.142% when pulling 093117370b1f4a2fedd8cf62231884a77cabe3a1 on chiraag-nataraj:master into 38a62b6d477caf713c17d94d433b4d7c04f5206e on newsboat:master.

Cool, thank you very much, @chiraag-nataraj!


Fix NPM security updates

WIP

hey @thekiwi I reviewed the list of packages you upgraded up to this point and I feel comfortable with all of them:

lerna / nyc are just dev dependencies
mongoose, I am familiar with this upgrade and should not cause issues (on siteflow we are already using 5.13.9 and newer changes are just fixes). we should also be fine with the latest mongodb driver upgrade.
swagger-ui-dist is only used on examples
webpack-dev-server this also contains fixes only

I think we can safely bump a few ones more, will continue with such work and will mark as ready for review once I'm done with it.

@thekiwi @pierissimo this is the initial set of libraries I am more familiar with. I think we should be fine with all those upgrades. After this, I will check if we can also resolve some others and I will document an exception for the ones that cannot be fixed without significant effort.


Better error message when forgeting a comma

Problem Description
While executing a script, if someone forgets a comma in writing multiple commands in script,
it is giving scrary error message. Is there any chance that we get better error message?
Code Example
[tasks.run]
description = "Run all the binaries in sph_function_approx crate and generate data files for plotting"
script = [
       "cargo run --bin kernel_1d_plot"
       "cargo run --bin sin_func_sph_approx"
]
/// paste code here

Error Stack/Info (if any)
dinesh@Personal (master *) /home/dinesh/research/notes/sph/sph_function_approx $
|  Personal desktop => cm results
[cargo-make] INFO - cargo-make 0.13.0
[cargo-make] INFO - Using Build File: Makefile.toml
[cargo-make] INFO - Task: results
thread 'main' panicked at 'Unable to parse external descriptor, expected a right bracket, found a string at line 11', src/descriptor.rs:173:27
note: Run with `RUST_BACKTRACE=1` for a backtrace.

i could add the filename but the parser is not in my control

I think this can be learnt from experience.


TV requires authorization for every request

Every time Alexa sends a request to the TV through samsungctl, the command line shows "WARNING:root:Waiting for authorization..." and the TV shows a message asking to approve of the connection with samsungctl. This lasts for about one second and then the command line displays "Failed to send message to TV: timed out". If I quickly press enter on the TV remote to allow the connection, then the command works, but this ruins the point of the skill, which is of course to not have to use the remote. The Allshare settings say that connections with samsungctl are allowed but it still asks for every request. What can I do to make it permanently allow the connection so that the skill will work properly?

What tv model do you have? you shouldn't need to authorize it multiple times.

The scan shows that the model number is UN46ES8000.

Hmm im not sure. I just use the https://github.com/Ape/samsungctl library. I would say try and use the library by hand to see if it works on the TV. if not raise an issue on there as they may be more help


KAFKA-13287: Upgrade RocksDB to <IP_ADDRESS>

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@ableegoldman I think I have already seen this specific failure in another PR. But I agree with you that we need to keep an eye on this.

I even found the PR:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11250/9/


Investigate Sector Segregation needs

Stephanie will look into it.
Governance Plan?

will capture through our processes going forward


Position logic not in line with CSL spec.?

I don't know Haskell. However, I've been reading the CSL spec and I've encountered what I think may be incorrect behavior within citeproc. I practical terms, given two repeated, identical citations with identical locators, the resulting position value should be solely "Ibid", and not "ibid-with-locator".
So:
Lorem [@cross1973, p. 125] ipsum [@cross1973, p. 125].

should yield:
Lorem (Cross, Canaanite Myth, 125) ipsum (ibid.).

but, instead, we get
Lorem (Cross, Canaanite Myth, 125) ipsum (ibid., 125).

The relevant portion of the spec is HERE (under "position").
The issue comes at the very last stipulation:

Preceding cite does have a locator: if the current cite has the same locator, the position of the current cite is “ibid”. If the locator differs the position is “ibid-with-locator”. If the current cite lacks a locator its only position is “subsequent”.

As far as I can tell, this library only tests to see if a locator is supplied rather than if it matches the previous locator value. Thus, even if the current citation is identical to the previous one, the result is "ibid-with-locator" because, indeed, a locator is supplied.
I copied the CSL sheet that I was using and imported it into Zotero to see if the JS implementation worked as expected and, indeed, it did.

Thanks for the report.  I assume this is not style-dependent
behavior, but should be the way ibid and ibid-with-locator
always work?
+++ Jack Weinbender [Jun 28 16 18:44 ]:

I don't know Haskell. However, I've been reading the CSL spec and I've
encountered what I think may be incorrect behavior within citeproc. I
practical terms, given two repeated, identical citations with identical
locators, the resulting position value should be solely "Ibid", and not
"ibid-with-locator".
So:
Lorem [@cross1973, p. 125] ipsum [@cross1973, p. 125].
should yield:
Lorem (Cross, Canaanite Myth, 125) ipsum (ibid.).
but, instead, we get
Lorem (Cross, Canaanite Myth, 125) ipsum (ibid., 125).
The relevant portion of the spec is [1]HERE (under "position").
The issue comes at the very last stipulation:
Preceding cite does have a locator: if the current cite has the same
locator, the position of the current cite is “ibid”. If the locator
differs the position is “ibid-with-locator”. If the current cite
lacks a locator its only position is “subsequent”.

As far as I can tell, this library only tests to see if a locator is
supplied rather than if it matches the previous locator value. Thus,
even if the current citation is identical to the previous one, the
result is "ibid-with-locator" because, indeed, a locator is supplied.
I copied the CSL sheet that I was using and imported it into Zotero to
see if the JS implementation worked as expected and, indeed, it did.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, [2]view it on GitHub, or [3]mute the
thread.
References

http://docs.citationstyles.org/en/stable/specification.html?highlight=ibid#choose
https://github.com/jgm/pandoc-citeproc/issues/241
https://github.com/notifications/unsubscribe/AAAL5GRP7au3vB104-DjkE7dfmWzSeDgks5qQc34gaJpZM4JAsjl

Yes, I should have been more clear. The "ibid" and "ibid-with-locator" are the position values, not style macros (or the like), so this is not style-dependent.


[WIP]Move production suites fromTravis to circle ci

Moving Production suites to Circle CI.
Tested on Circle CI:smiley:
Followups

Figure out how will we handle cache storing since now cache is both for production and development(till now cache key is dependent on development requirements )
Do some profiling on making these tests more efficient. (Probably use a new bionic docker image for production)
Clear travis hack code for adding travis path in our codebase.

@timabbott @amanagr Could you have a look at this?

Pushed to trigger CI.

@timabbott  I have made the changes requested. Some commits are also changed so kindly have a look at them.
Before merging this I think we should resolve the commit
Since this is definitely not the correct way of solving this. Do you want me to have some kind of workaround in puppet files?

One thing I notice after reading this is we can probably rename tools/ci/production-helper over tools/ci/production and just put the sudo in the CircleCI config; seems like a good follow-up cleanup.

Merged, thanks @arpit551!  I love how much cleaner the production scripts are now than they were before.


MSID: 87030 Version: 2 DOI: 2<IP_ADDRESS>72888

[PLACE MANUSCRIPT AND EDITOR DETAILS HERE WHEN AVAILABLE] See step 3
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=87030)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/87030/v2)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>72888)
[ ] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/87030/v2/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/87030)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/87030

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/87030

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/87030/v2/87030-v2.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/87030)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

elocations missing from references


About OomError

Most functions in Vulkan can return VK_ERROR_OUT_OF_HOST_MEMORY and VK_ERROR_OUT_OF_DEVICE_MEMORY. In fact most functions can only return one of these two errors.
This is reflected in vulkano by the fact that a lot of functions can return OomError.
However in practice it is very unlikely that an out-of-memory error actually happens, with the exception of vkAllocateMemory.
The API would be much more convenient to use if an out of memory error returned by Vulkan resulted in a panic instead of returning an error, like it's the case for the core Rust.
Again, with the exception of DeviceMemory which would still return OomError.

(this issue is for discussion about the problem, not something that is currently planned)

If a the device memory is filled with cached textures/meshes and an important command returns VK_ERROR_OUT_OF_DEVICE_MEMORY, you would probably want to release some textures/meshes and repeat the command. Is this something that vulkano could handle?

@Mixthos Currently yes, but if OomError is turned into panicking like this issue suggests, then no.
The reasoning is that the chance that anything returns OUT_OF_DEVICE_MEMORY are very low if you except the commands that allocate memory.
For example why would creating a fence or a semaphore return out of memory? A fence or a semaphore is usually just an integer.

I guess it depends on what the drivers do. Maybe we could test this for each function before changing it? Preferably in most drivers, in case one of the drivers has some weird behaviour.

Well, drivers are more or less non-existing today. The ones that exist don't do many optimizations. We can't assume that if it works today it will likely work tomorrow.

The only added convenience is not having to call unwrap(), right? In that case I wouldn't want to give up the ability to recover from an error in case it does happen at some point in time. Otherwise there's no way to easily implement a patch to the application if it crashes on a new driver.

Or there could be two versions of each of these functions. For Example:
fn newSafe(device: &Arc<Device>) -> Result<Arc<Fence>, OomError>;
fn new(device: &Arc<Device>) -> Arc<Fence> {
    Fence::newSafe(device).unwrap()
}

That looks like a good idea.
This would be similar to the difference between [] and .get() in the stdlib for example.

If you tell me the naming convention you want to use and which functions should be left out, I could implement that and let you work on the harder stuff. ;)

I thought something like this:
pub fn raw(device: &Arc<Device>) -> Result<Foo, OomError> { ... }

#[inline]
pub fn new(device: &Arc<Device>) -> Arc<Foo> {
    Arc::new(Foo::new(device).unwrap())
}

This way the raw function would be the lowest-level thing possible, not using Arc and returning all possible errors.
For objects that can return an error other than just OOM, I think we can keep the OOM error part of the possible errors. For example I think we can keep OomError inside SamplerCreationError.

If you tell me the naming convention you want to use and which functions should be left out, I could implement that and let you work on the harder stuff. ;)

That would be nice :)
However you should keep in mind that some constructors that currently return OomError may return something else in the future. It may be tricky to figure out which ones.

Just to be sure I got it right before I do the rest:
    /// Creates a new pool.
    ///
    /// The command buffers created with this pool can only be executed on queues of the given
    /// family.
    ///
    /// # Panic
    ///
    /// Panicks if the queue family doesn't belong to the same physical device as `device`.
    ///
    #[inline]
    pub fn raw(device: &Arc<Device>, queue_family: &QueueFamily)
               -> Result<CommandBufferPool, OomError>
    {
        assert_eq!(device.physical_device().internal_object(),
                   queue_family.physical_device().internal_object());

        let vk = device.pointers();

        let pool = unsafe {
            let infos = vk::CommandPoolCreateInfo {
                sType: vk::STRUCTURE_TYPE_COMMAND_POOL_CREATE_INFO,
                pNext: ptr::null(),
                flags: 0,       // TODO:
                queueFamilyIndex: queue_family.id(),
            };

            let mut output = mem::uninitialized();
            try!(check_errors(vk.CreateCommandPool(device.internal_object(), &infos,
                                                   ptr::null(), &mut output)));
            output
        };

        Ok(CommandBufferPool {
            pool: Mutex::new(pool),
            device: device.clone(),
            queue_family_index: queue_family.id(),
        })
    }

    /// Creates a new pool.
    ///
    /// The command buffers created with this pool can only be executed on queues of the given
    /// family.
    ///
    /// # Panic
    ///
    /// - Panicks if the queue family doesn't belong to the same physical device as `device`.
    /// - Panicks if the device or host ran out of memory.
    ///
    #[inline]
    pub fn new(device: &Arc<Device>, queue_family: &QueueFamily)
               -> Arc<CommandBufferPool>
    {
        Arc::new(CommandBufferPool::raw(device, queue_family).unwrap())
    }

Is there a reason the original constructor is inlined and should I undo it?

Also: CommandBufferPool is named "Command Pool" in the spec. I think vulkano should use the same names as the spec when there isn't a good reason not to.

@Mixthos Your gist looks good. I usually inline functions that I think are short. Here it's really ambiguous.
Could you please open an issue for that name problem, so that I don't forget?

I opened an issue for the name.
That function doesn't look short to me. ;)

Should I do the same for CustomRenderPass? The macro confuses me. ;)

Should I do the same for CustomRenderPass?

Yes. If it's too hard, it's not a problem.

Should I add the raw constructor to them as well?

Yes, why not.

Ok, I'll do that.
I noticed that Surface::is_supported is returning the wrong error type. (vkGetPhysicalDeviceSurfaceSupportKHR can return VK_ERROR_SURFACE_LOST_KHR as well). Should I add a comment for that like you did for Surface::get_capabilities?

I'm assuming vkBindImageMemory and vkBindBufferMemory shouldn't allocate memory. If I'm wrong, tell me, and I'll revert my changes to bind_memory.

What should I call the panicking version of SwapchainImage::from_raw? from_raw_raw sounds weird. ;)

I created a pull request: #32.

SwapchainImage::from_raw doesn't need a raw/non-raw version for now.
Swapchain::new() must return an Arc to the swapchain for technical reasons. Therefore it doesn't make sense to provide a function that returns an Arc<Swapchain> but non-Arc SwapchainImages. Therefore it's no use creating non-Arc SwapchainImages.

This way the raw function would be the lowest-level thing possible, not using Arc and returning all possible errors.

Out of curiosity, what is the reason for automatically wrapping all objects in an Arc? Couldn't Vulkano just use references and let the engine that uses Vulkano wrap it in an Arc when that engine needs to share it across multiple threads?

Something like this seems cleaner:

That's a usability problem with Rust. I had already talked about it back in 2015 in a gist (which I don't have time to find right now).
I'm already using vulkano in a real project, and here is an example code that I have:
pub struct BatchSystem<R> {
    /// Queue used to transfer buffers to textures.
    transfer_queue: Arc<Queue>,

    /// Queue used to draw sprites.
    gfx_queue: Arc<Queue>,

    /// Pool for the various command buffers used in this system.
    cb_pool: Arc<CommandBufferPool>,

    /// The graphics pipelines used to draw sprites.
    pipeline_no_depth: Arc<GraphicsPipeline<SingleBufferDefinition<SpriteVertex>,
                                            pipeline_layout::CustomPipeline, R>>,
    pipeline_depth: Arc<GraphicsPipeline<SingleBufferDefinition<SpriteVertex>,
                                         pipeline_layout::CustomPipeline, R>>,

    render_pass: Arc<R>,
    render_pass_subpass: u32,

    /// Texture.
    texture: Arc<ImmutableImage<format::R8G8B8A8Srgb>>,

    /// Descriptor set
    descriptor_set: Arc<pipeline_layout::set0::Set>,

    /// List of queue submissions that are pending execution.
    queue_submissions: Arc<Mutex<Vec<Arc<Submission>>>>,

    .. other fields...
}

Now imagine writing the same thing with lifetimes.
Since you can't put the "dependee" and the "depender" in the same struct, you would have to split this BatchSystem in at least 5 different structs.
If then another type named Foo wants to use BatchSystem internally, it would have to split in 5 different structs as well. Then if another type wants to use Foo internally, it would have to split in 5 different structs as well. This would make the whole program unusable.

I also started making some structs generic over the kind of references that they need, like Fence or #29 .
However there's a safety problem caused by the fact that a Deref implementation could return a different object every time, forcing the types to always check that the object is correct.
I'm hesitating between continuing this way or providing a custom Deref-like trait that would be unsafe and that would be forced to return the same object every time.

Here is the gist if anyone is curious.

Ok. This seems like something that should be added to Rust in the future if somebody can figure out a way do do it without screwing up the type system.

Here is the gist if anyone is curious.

Thanks!

This is possible:
use std::mem;

struct Instance {
}

impl Instance {
    pub fn new() -> Instance {
        Instance {}
    }
}

struct Device<'a> {
    instance: &'a Instance,
}

impl<'a> Device<'a> {
    pub fn new(instance: &'a Instance) -> Device<'a> {
        Device { instance: instance }
    }
}

struct CommandPool<'a> {
    device: &'a Device<'a>,
}

impl<'a> CommandPool<'a> {
    pub fn new(device: &'a Device<'a>) -> CommandPool<'a> {
        CommandPool { device: device }
    }
}

struct CommandBuffer<'a> {
    pool: &'a CommandPool<'a>,
}

impl<'a> CommandBuffer<'a> {
    pub fn new(pool: &'a CommandPool<'a>) -> CommandBuffer<'a> {
        CommandBuffer { pool: pool }
    }
}

struct Assets<'a> {
    instance: Instance,
    device: Device<'a>,
    pool: CommandPool<'a>,
    buffer: CommandBuffer<'a>,
}

fn main() {
    let mut assets = unsafe { mem::uninitialized::<Assets>() };

    assets.instance = Instance::new();
    assets.device = Device::new(&assets.instance);
    assets.pool = CommandPool::new(&assets.device);
    assets.buffer = CommandBuffer::new(&assets.pool);
}

But you can't move it: http://is.gd/q5IFK6

Is using a Box okay? http://is.gd/4f2pyP

Well, that's unsafe.

The same thing with an Arc: http://is.gd/9bWfsL
I don't think it's too bad. Maybe there are ways to make it safer?

I don't really understand.
If the plan is to put this macro in vulkano, then you're blindly assuming that the user just wants an instance, a device, a pool and a command buffer.
If the plan is to put this macro in the user's code, then they have to write unsafe code, which is bad.

The macro is generic. The struct I used was just an example.
Your example could look like this:
pub struct BatchSystem<'a, R: 'a> {
    /// Queue used to transfer buffers to textures.
    transfer_queue: Queue<'a>,

    /// Queue used to draw sprites.
    gfx_queue: Queue<'a>,

    /// Pool for the various command buffers used in this system.
    cb_pool: CommandBufferPool<'a>,

    /// The graphics pipelines used to draw sprites.
    pipeline_no_depth: GraphicsPipeline<'a, SingleBufferDefinition<SpriteVertex>,
                                            pipeline_layout::CustomPipeline, R>,
    pipeline_depth: GraphicsPipeline<'a SingleBufferDefinition<SpriteVertex>,
                                         pipeline_layout::CustomPipeline, R>,

    render_pass: R,
    render_pass_subpass: u32,

    /// Texture.
    texture: ImmutableImage<'a, format::R8G8B8A8Srgb>,

    /// Descriptor set
    descriptor_set: pipeline_layout::set0::Set<'a>,

    /// List of queue submissions that are pending execution.
    //queue_submissions: Arc<Mutex<Vec<Arc<Submission>>>>,
}

// ...

fn main() {
    // ...
    let batch_system = make_assets!(BatchSystem<'a, R> {
        transfer_queue: create_transfer_queue(/*...*/),
        gfx_queue: create_gfx_queue(/*...*/),
        cb_pool: create_cb_pool(/* ... */),
        pipeline_no_depth: create_pipeline_no_depth(/* ... */),
        pipeline_depth: create_pipeline_depth(/* ... */),
        render_pass: create_render_pass(/* ... */),
        render_pass_subpass: create_render_pass_subpass(/* ... */),
        texture: create_texture(/* ... */),
        descriptor_set: create_descriptor_set(/* ... */),
    });
}

Each created value can be borrowed to create the ones after it.

But isn't that totally out of scope of vulkano?
As I said I started rewriting some structs to be generic over Deref<Target = Foo> instead of using Arc<Foo> directly.
Once that's done, the user can get that macro from another crate.

But isn't that totally out of scope of vulkano?

Probably.

Once that's done, the user can get that macro from another crate.

I created a crate for it: self-ref
It's safer than the version I posted here.

I guess I'm going to close this.


[Bug] oneOf merge wrong

Check the version of webpack-merge you are using. If it's not the newest version, update and try again (see changelog while updating!).
If the issue is still there, write a minimal script showing the problem and expected output. You can also set up a repository (even better).
Include the script to the issue. Mention Node version and OS in your report.

version 4.2.2
const { stringify } = require('javascript-stringify')
const smartMerge = require('webpack-merge').smart

describe.only('merge test', () => {
  test('merge', () => {
    const a = {
      rules: [
        {
          test: /\.js$/,
          oneOf: [
            {
              resourceQuery: /inline/, // foo.css?inline
              use: 'url-loader',
            },
            {
              resourceQuery: /external/, // foo.css?external
              use: 'file-loader',
            },
          ],
        },
      ],
    }
    const expectResult = stringify(a)
    expect(stringify(smartMerge(a, a))).toBe(expectResult)
  })
})

It seems to work if you use loader instead of use but I know that's not ideal.
Likely I'll drop the support for merge.smart as it's difficult to support and it has surprising corner cases like this.


Rule 0 Addition (Sage)

i am held at gunpoint to do this myself

This will actually end up being rule 1 and I don't think it's a good addition either


Combine the readOffsets and readWithRuns

Overview
It appears that the readOffsets and readWithRuns complete the same task. The only difference is that readWithRuns has a condition for runs within the bitmap. To provide concise code, the two functions can be combined under readWithRuns.
Pull request checklist

[x] I have read the contributing guide.
[x] I have agreed to the Contributor License Agreement.
[x] I have updated the documentation.
[x] I have resolved any merge conflicts.
[x] I have included tests that cover my changes.
[ ] All new and existing tests pass.
[ ] Make sure PR title conforms to convention in CHANGELOG.md.
[ ] Add appropriate changelog label to PR (if applicable).

Code review checklist
This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.

[ ] Ensure that any changes to external docs have been included in this pull request.
[ ] If the changes require that minor/major versions need to be updated, tag the PR appropriately.
[ ] Ensure the new code is properly commented and follows Idiomatic Go.
[ ] Check that tests have been written and that they cover the new functionality.
[ ] Run tests and ensure they pass.
[ ] Build and run the code, performing any applicable integration testing.
[ ] Make sure PR title conforms to convention in CHANGELOG.md.
[ ] Make sure PR is tagged with appropriate changelog label.

I'm going to close this for now... looks like there are some subtle difference between these two that makes them difficult to combine.


sap.m.Select ignores sapUiSizeCozy in headerContent of ObjectPageLayout

OpenUI5 version:
I found the bug on 1.71.38, minimal example ist on nightly build
Browser/version (+device/version):
Chrome Version 92.0.4515.159
IE Version 1909 Build 18363.1714
probably everywhere
Any other tested browsers/devices(OK/FAIL):
every tested scenario FAIL
URL (minimal example if possible):
https://plnkr.co/edit/gTxIx9BvTChZovBZ?preview
Credit:  https://stackoverflow.com/users/5846045/boghyon-hoffmann
(allowed me to use it in comments of https://stackoverflow.com/questions/69192953/sap-m-select-ignores-sapuisizecozy-in-headercontent-of-objectpagelayout?noredirect=1#comment122353591_69192953)
User/password (if required and possible - do not post any confidential information here):
not needed
Steps to reproduce the problem:

create ObjectPageLayout with cozy css class (XML View)
create Select in the headerContent (optional: ComboBox to compare)

What is the expected result?
All controlls are displayed in cozy style
What happens instead?
Select is displayed in compact style
This results in an inconsistant look, especially if controlls are displayed next to eachother.
Any other information? (attach screenshot if possible)
https://i.stack.imgur.com/Zh6es.png

Hello @erchie,
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,
Patric

Hi @

Hi @erchie ,
The issue will be fixed with next version.
Regards,
Nayden


Should inclusion of referenced images in PertinentOtherEvidenceSequence be enforced?

It is my understanding that the PertinentOtherEvidenceSequence should contain all instances referenced anywhere in the content tree, and failing to do so would technically be non-compliant. See sect_C.17.2.3

[evidence in PertinentOtherEvidenceSequence] shall include, but is not limited to, all current evidence referenced in the content tree

When constructing an SR object, highdicom has all the available information to ensure that this has been done correctly (i.e. no referenced instance in the content tree has been omitted from the evidence parameter), but it currently does not do so.
I would suggest that one improvement could be to add code to the SR constructor that walks the content tree and raises an exception if any evidence is missing. Unfortunately I think it will not be possible to automatically add the evidence as some information (such as series instance uid) may be missing from the references in the content tree.
Thoughts? @hackermd

Good catch!
There are several aspects:

Recording all evidence that is referenced in the content tree.
Extracting the relevant information automatically from items contained in ContentSequence or from the passed evidence.
Deciding whether the evidence should go into CurrentRequestedProcedureEvidenceSequence or PertinentOtherEvidenceSequence.

We should be able to determine all evidence based on the value type of content items (IMAGE, COMPOSITE, etc.) passed via content. You are right that the SeriesInstanceUID is not contained in the content items, but is required to reference the SOP instances via CurrentRequestedProcedureEvidenceSequence or PertinentOtherEvidenceSequence. Therefore, the corresponding SOP instances (pydicom.dataset.Dataset objects) have to be passed via evidence. I agree with you that it would be beneficial to add checks that ensure that's actually the case.
However, we currently also use evidence to copy the corresponding study-level metadata. Can we assume that all SOP instances referenced in the content tree are part of the same study? @dclunie could you kindly confirm this contraint?

I just realized that we probably incorrectly include references for the instances in evidence in PertinentOtherEvidenceSequence, but should rather include them in CurrentRequestedProcedureEvidenceSequence. See Current Requested Procedure Evidence Sequence:

Full set of Composite SOP Instances, of which the creator is aware, which were created to satisfy the current Requested Procedure(s) for which this SR Document is generated or that are referenced in the content tree.

I was wondering about that too. I think that's probably more correct but I'm not sure it's 100% right either. The entry for PertinentOtherEvidenceSequence reads

Other Composite SOP Instances that are considered to be pertinent evidence by the creator of this SR Document. This evidence must have been acquired in order to satisfy Requested Procedures other than the one(s) for which this SR Document is generated.

So I think the deciding factor is whether the evidence is part of the same Request Procedure as the SR or not, and I don't know how this relates to Study. I'm not completely sure on the definition of Requested Procedure, but what if something along the following lines happened: someone has a CT scan (one requested procedure) which gives rise to study. Some arbitrary length of time later, perhaps an AI based project, a physician (or possibly an AI model) reviews the images and generates an SR and SEG instance based on his/her/its analysis of the study. Would that be a different Requested Procedure? In which case, would the SEG instance go into Current Requested Procedure Evidence, and the original CT scan instances go into Pertinent Other Evidence when generating the SR?

So the deciding factor is whether the evidence is part of the same Requested Procedure as the SR or not, and I don't know how this relates to Study. I'm not completely sure on the definition of Requested Procedure, but what if something along the following lines happened: someone has a CT scan (one requested procedure) which gives rise to study. Some arbitrary length of time later, a physician (or possibly an AI model) reviews the images and generates an SR and SEG instance based on his/her/its analysis of the study. Would that be a different Requested Procedure? In which case, would the SEG instance go into Current Requested Procedure Evidence, and the original CT scan instances go into Pertinent Other Evidence when generating the SR?

Excellent questions! I don't know to be honest. It would be worth discussing with @dclunie, @seandoyle, @fedorov and @pieper.

Yes, very important things to sort out.  I don't know the exact answer but I think you are on the right track and would be glad to discuss.

This issue was closed by #67


UnboundLocalError: cannot access local variable 'sampled_conv_messages' where it is not associated with a value

Error: cannot access local variable 'sampled_conv_messages' where it is not associated with a value
Traceback:
File "/usr/local/lib/python3.9/site-packages/streamlit/runtimescript_runner.py", line 565, in _run_script
exec(code, module.dict)
File "/home/user/projects/GPT/dashboard.py", line 59, in
processed_messages = preprocess_messages(user_messages, total_desired_number_of_messages, number_of_words_max_per_message)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/user/projects/GPT/utils/functions.py", line 83, in preprocess_messages
sampled_messages.append(sampled_conv_messages)
^^^^^^^^^^^^^^^^^^^^^

You've left an unchecked path here (which led to sampled_conv_messages being referenced before being assigned to):
if (number_of_messages_to_sample <= 3):
            if not (number_of_messages_to_sample == 0):
                sampled_conv_messages = conversation_messages[:number_of_messages_to_sample]
        else:
            sampled_conv_messages = conversation_messages[:3] + get_ordered_random_sample(conversation_messages[3:], number_of_messages_to_sample - 3)

Will push a PR to fix it later this week

Modify the preprocess_messages function as follows (though even after making this change, I still get an error about my message exceeding the maximum context length of 4097 tokens.)
`def preprocess_messages(user_messages, total_desired_number_of_messages=150, number_of_words_max_per_message=40):
# ...
for conversation in range(len(user_messages)):
# ...
if (number_of_messages_to_sample <= 3):
if not (number_of_messages_to_sample == 0):
sampled_conv_messages = conversation_messages[:number_of_messages_to_sample]
else:
sampled_conv_messages = conversation_messages[:3] + get_ordered_random_sample(conversation_messages[3:], number_of_messages_to_sample - 3)
    # Initialize sampled_conv_messages as an empty list if it hasn't been assigned a value
    if not sampled_conv_messages:
        sampled_conv_messages = []

    sampled_messages.append(sampled_conv_messages)
# ...
return user_messages`


Multiple issues - scanner and gateway

For scanner connectivity to aqua server API you have hardcoded HTTP protocol, please parameterize it as in our case we have it over HTTPS and I have to edit your template to make it work for us
https://github.com/aquasecurity/aqua-helm/blob/5.3/scanner/templates/scanner-deployment.yaml#L51

added support in #231


Merging logfiles up front?

Hi everybody, got a question regarding logfiles from a cluster. We got a varnish plus cluster running, each node writing its own logfile. Do we need to merge them after we ship them to the goaccess host for analysis? Or is it sufficient to use the multiple log file feature. Note: those files and thus their entries are from the same time span.

There's no need for merging them. I'd just feed the into goaccess, e.g.,
goaccess cluster1.log cluster2.log


Windows zoom shortcuts

Operation System: Windows 10, 64-bit
Beaker version:0.8.0-prerelease7
To zoom in takes three keypresses (ctrl,shift+[the =+ key next to backspace]). I think the shift key being required here is a bug.
Zooming out with ctrl+[the -_ key] works fine.
And finally, ctrl+numpad - and ctrl+numpad + don't do anything, where in Chrome and Firefox it zooms out and in.
Related issue: #1071

Whoops well that's dumb! Thanks for reporting. I'll get that fixed.

Fixed in master. Thanks again.


requirements.txt supported for train but not deploy?

I'm installing GluonCV via a requirements.txt file in my source_dir, which seems to be working fine for my training job but then ignored when the container starts up for inference: leading to ModuleNotFoundError.
I guess I could install the dependency inline in the script with something like the below, but then the requirements.txt functionality is kind of inconsistent right? I could have just done inline installs in the first place...
subprocess.call([sys.executable, "-m", "pip", "install", "--upgrade", "gluoncv"])

Is processing requirements.txt on inference startup a potential enhancement? Or an idea that's already been considered and decided against for some reason? Would it be implemented here, or in the base sagemaker-containers?

Hi @athewsey, this actually is supported. Details can be found here: https://sagemaker.readthedocs.io/en/stable/using_mxnet.html#use-third-party-libraries
Please feel free to re-open this issue if you run into any problems.


Entities bulk insert support

https://godoc.org/github.com/lib/pq#hdr-Bulk_imports
For others DBs, we can improve this case reusing prepared statements.

The https://github.com/markbates/pop (v3.x) repo has been moved to https://github.com/gobuffalo/pop (v4.x). The markbates/pop repo has been put into READ-ONLY mode and will no longer be updated. You may continue to use this repository, but be aware no more updates will be made on it.
If this is issues is still relevant, please open a new issue on the repository.
For more information on this move see https://github.com/markbates/pop/issues/164
Thank you so much and I apologize in advance for any trouble this may cause you.


strange behavior - just checking - node-red admin hash-pw does not work when put in to the settings.js

I don't see a bug on this - however it might as well be a raspberry / node.js problem
The authentication for the editor is working, however the password is always rejected.
I get entries in the log that indicates the access attempt so I presume things are fine
1 Jan 20:47:06 - [trace] runtime event: {"id":"runtime-deploy","payload":{"revision":"d751713988987e9331980363e24189ce"},"retain":true}

I wrote the small snippet below (for some reason is required a package.json - the generated password did also not work.
node -e "console.log(require('bcryptjs').hashSync(process.argv[1], 8));" your-password-here
It is a clean raspberry 3 with the small raspberry pi os  (no ui) and ssh, mc, wifi and node 12.20.0 - and node.red seems fine without security.
firmware is:
pi@pi3test:~/test $ uname -a
Linux pi3test 5.4.79-v7+ #1373 SMP Mon Nov 23 13:22:33 GMT 2020 armv7l GNU/Linux

If there are no known problems / wierd behaviors then just close this one - I can run without security for the time being.

Please read the template you were shown when you opened this issue. It asks you to raise questions on the Forum, Slack or Stack Overflow first as we only use issues for actual defects in the code.
It also gathers all the required information we need to be able to make a start on debugging any issue.
We need to see the changes you made to settings.js and exactly which instance of the file you edited.
It's also not 100% clear what problems you are seeing here, is it

That you can sign into the editor, but you can't deploy?
You can't sign into the editor at all?

Please read the template you were shown when you opened this issue. It asks you to raise questions on the Forum, Slack or Stack Overflow first as we only use issues for actual defects in the code.
It also gathers all the required information we need to be able to make a start on debugging any issue.
We need to see the changes you made to settings.js and exactly which instance of the file you edited.
It's also not 100% clear what problems you are seeing here, is it

That you can sign into the editor, but you can't deploy?
You can't sign into the editor at all?

I will switch to slack in the morning if I find the time @hardillb

I will switch to slack in the morning if I find the time @hardillb


error on account creation

Was creating 3 accounts, two went though with no problem. Third one generated the error message, "missing an  active authority"
the account name was 17 characters in case that has an affect.

It's maximum 16 characters.

In any case, the error should probably be a bit more clear 👍

thanks .. wondered if the length may have been the problem


Help with linker xtensa-esp32-elf-gcc not found

I'm having issues with xxtensa linker.
I used cargo generate to generate esp no std template and then executed cargo build.
Could anyone help pleasE?

You need to install the linker manually from https://github.com/espressif/crosstool-NG/releases, or let espup do it for you.


feat: init pod controllers

What type of PR is this?

feat
What does this PR do?

synchronize pod to sub clusters
Which issue(s) does this PR fix?

Fixes #146
Special notes for your reviewer:

Screenshots (if applicable):

Additional Comments:

 synchronize pod to sub clusters

/cc @xyz2277 @duanmengkk @wangyizhi1

/approve
/lgtm


Switch to container-based infrastructure for travis.

See: http://blog.travis-ci.com/2014-12-17-faster-builds-with-container-based-infrastructure/
Also sets up caching for the $HOME/.m2 directory, which should speed up build times by not downloading dependencies on every build.

:+1:

:+1:


HP Aruba JL256A profile is missing

Device Vendor: Aruba (HP)
Device Model: Aruba JL256A 2930F-48G-PoE+-4SFP+ Switch
System Object Identifier (SysOID): <IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS>.21
List of critical metrics that you expect in the profile (does not need to be all-inclusive, just a general idea of your expectations):

IF-MIB
IP-MIB
OSPF-MIB
TCP-MIB
UDP-MIB

Please provide a public gist with a sanitized (sensitive information removed) SNMP walk of the device. Providing MIB files is not a substitute for an SNMP walk and failure to provide one here will result in delays for closing this issue. The output of these commands shows the "true story" of what a device will respond to in SNMP and is used to ensure that our profiles are efficient and accurate for your devices.
Gist Link: https://gist.github.com/pvadhyaphal/980b40c54695a5accea7533ead9e07d7

Example SNMP walk commands:
# v2c example
snmpwalk -v 2c -On -c $COMMUNITY_STRING $IP_ADDRESS . >> snmp_walk.out

# v3 example
snmpwalk -v3 -l authPriv -u $USERNAME -a MD5|SHA -A $AUTH_PASS -x DES|AES -X $PRIV_PASS -ObentU -Cc $IP_ADDRESS . >> snmp_walk.out

Thanks, we have this in queue to build a profile for the device.  After the issue gets closed you will want to pull the newest image and rediscover the aruba devices.


inputRange must be monotonically non-decreasing 0, NaN iOS

Hi
We are facing this issue on iOS same code is working perfectly fine on Android.

same.  seems to occur when using the value prop.  Wonder if the package maintainer will help 😉.  Did you ever work around this?


Detect python module presence without ExtDep_xxx.cmake file

A lot of our ExtDep_xxx.cmake files are glorified wrappers around a python3 -c 'import xxx' command. We might simplify this and make it more adaptable by making it possible to specify external dependencies as py::xxx in the pkg.info files.
One complication is whether or not we want to be able to specify a minimal version, although that might get somewhat out of hand.

The extracted version would be the __version__ attribute (as in the ExtDep_Numpy.cmake file).


NO-MERGE: Percy scroller fix

Testing percy action

Moved to ready to review to try trigger the visual_tests action

You can trigger the action by adding the 'visual-test-ready' tag

You can trigger the action by adding the 'visual-test-ready' tag

Cool, Idk why the previous PR added automatically the 'visual-test-ready' tag

Percy action working well. is ignoring dynamic scroller closing PR.


Integrate dashboard endpoint

Made changes to add the new filter by impact button and the new query params we agreed on in this document
https://docs.google.com/document/d/1zuGw8ay-Pgy8FSeJCOqYZd0BEouY68E5eiUxtR_97pc/edit#

Unfortunately I can't figure out which branch the dashboard back end updates are on so I wasn't able to test properly. I think I'll need this working before I can make sure the rest is integrated properly :")

Even with the new changes to dashboard I'm not getting anything back from the endpoint. I think this is due to a lack of vulnerabilities in the db but I'm not sure

List of changes:

finalized request to dashboard endpoint and integrated it so the data fills up the Paginated Table component
added loading state when a request is being sent --> needs error handling but we're def out of time for that
formatted enums to match strings --> everywhere you see enumToString()
created some reusable variables in the "helper/enums" folder


ENH: stats.yeojohnson: improve bounds

Reference issue
This is a follow-up improvement to #18852, which addressed under- and overflow in the Yeo-Johnson transform.
What does this implement/fix?
As suggested by @mdhaber, this PR implements an exact* formula to determine the lower and upper bounds on lambda in the Yeo-Johnson transform to avoid underflow and overflow (on the given input data, but also on unknown future input).
Important notes about this PR:

This PR further increases the search space for lambda relative to the comparatively conservative bounds introduced by #18852.
Overflow can now be avoided for input data up to 1e303 (which is close to double precision's maximum of 1e308), up from about 1e200.
Underflow can unfortunately only be avoided for input data up to 1e-150, which is not an improvement over the current state. The reason for this is that other parts of Scipy, specifically the implementation of Brent's method in scipy.optimize.fminbound, are not equipped to deal with extremely small (or large) input data.
Instead of optimising over lambda directly, this PR optimizes over $λ' := \textrm{tanh}(λ)$. This is done because the increased search space for lambda (1) is sufficiently large that the implementation of Brent's method overflows. By optimising over the transformed lambda, we avoid that overflow.
*Under- and overflow can appear in two places: as the result of the Yeo-Johnson transform itself ($((1 + x) ^ λ - 1) / λ$), and in its numerator ($(1 + x) ^ λ - 1$). Overflow can be avoided by constraining lambda to an interval, but to avoid underflow a more complex constraint on lambda would need to be imposed in general. For that reason, underflow cannot be entirely avoided. Right now, the implementation accepts that underflow could in theory still occur in the numerator.

@lsorber how does this relate to gh-19652? Please coordinate with the author of that. In the meantime, I need to finish reviewing gh-19631 to finish up with BC before returning to YJ.

Closing due to inactivity here and in gh-19016, but feel free to open this PR in smaller chunks according to the plan in gh-19016.


See if and where an item is localized

While peeking, it would be great to have information about whether an item is localized in any child Publications and if so, exactly where (or at least a summary with a link to Where Used?)

Suggestion from @robrtc on Twitter:
https://twitter.com/robrtc/status/684711444101869568

Note that this is a heavy query, so we probably only want to include the information on-demand.


C5050 warning on use of 'import std.memory'

In a module unit I should be able to 'import std.memory' without incurring the C5050 warning, given that the Visual Studio 22 settings are correct. Here is the resulting command line that fails with C5050:
/JMC /experimental:module /permissive- /ifcOutput "x64\Debug\" /GS /W4 /Zc:wchar_t /ZI /Gm- /Od /sdl /Fd"x64\Debug\vc143.pdb" /Zc:inline /fp:precise /D "_DEBUG" /D "_CONSOLE" /D "_UNICODE" /D "UNICODE" /errorReport:prompt /WX- /Zc:forScope /RTC1 /Gd /MDd /std:c++latest /FC /Fa"x64\Debug\" /nologo /Fo"x64\Debug\" /Fp"x64\Debug\ExImCore.pch" /diagnostics:column
Are these command line options correct? Or is the warning caused by a bug?
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9fe706e6-2d81-6a6a-4aa6-399e14943372
Version Independent ID: 918d287f-c642-9858-b1a1-e197716f91de
Content: Compiler Warning C5050
Content Source: docs/error-messages/compiler-warnings/c5050.md
Product: visual-cpp
Technology: cpp-diagnostics
GitHub Login: @corob-msft
Microsoft Alias: corob

@rtischer8277
I'm sorry you're having trouble with your build. Unfortunately, there isn't enough information in your report to tell you what's gone wrong. More importantly, this isn't the right place to ask, either. If you think the product may have a bug (as opposed to a bug in the docs) then you should report the issue on Developer Community. Since this otherwise sounds like a product support question best handled by Developer Community, I'm closing the issue.

np. I have submitted the bug on Developer Community. Once I get it resolved, I'll be sure and circle back here and see if I can add anything to this doc page.


fcm is not working with desktop

I need more info here. Stack trace. Versions of packages. Code snippet. Etc.


License File needed

I want to use this for Arabic & Persian support for license file is not included to assure that its legal to use this code. Can u guys include perhaps an MIT license ?

Added in  fff0914 . thank you and have fun 👍


getAllRepliesToKnownPosts: All jobs have failed

I set up FediFetcher for Mastodon but am getting this error:
‣ Run python find_posts.py --lock-hours=0 --access-token=*** -c="./config.json" 2024-07-10 15:55:07 UTC: Starting FediFetcher 2024-07-10 15:55:07 UTC: Getting context for home timeline 2024-07-10 15:55:08 UTC: Error getting timeline toots: Error getting URL https://my_domain.com/api/v1/timelines/home. Status code: 401. It looks like your access token is incorrect. 2024-07-10 15:55:08 UTC: Job failed after 0:00:01.044772 Traceback (most recent call last): File "/home/runner/work/FediFetcher/FediFetcher/find_posts.py", line 1667, in  timeline_toots = get_timeline(arguments.server, token, arguments.home_timeline_length) File "/home/runner/work/FediFetcher/FediFetcher/find_posts.py", line 362, in get_timeline response get_toots(url, access_token) File "/home/runner/work/FediFetcher/FediFetcher/find_posts.py", line 401, in get_toots raise Exception( Exception: Error getting URL https://my_domain.com/api/v1/timelines/home. Status code: 401. It looks like your access token is incorrect. Error: Process completed with exit code 1.
This is my config.json:
{
"access-token": "my_access_token",
"server": "my_server.com",
"home-timeline-length": 200,
"max-followings": 80,
"from-notifications": 1
}
My Mastodon app has these permissions:
read read:accounts
read:favourites
read:follows
read:lists
read:notifications
read:search
read:statuses

Here is your error:

Status code: 401. It looks like your access token is incorrect.

so yeah, your access token is incorrect. Try to regenerate it and ensure you don’t make any errrors with copy and paste.
If you are using GitHub actions (which the issue title seems to indicate, please also note this section the readme:

Yeah, you need to remove this line:
https://github.com/Coehill/FediFetcher/blob/7b0b40fd25329f057f8e42eebc20c5e1b7403831/config.json#L2
as it stands you are providing the access token ACCESS_TOKEN rather than your actual access token.

I will close this now as there has been no response. Please feel free to re-open if this doesn't resolve the issue.

@nanos Thanks, the action is now running for me. I made a few small edits to the readme since I misinterpreted the instructions.
https://github.com/nanos/FediFetcher/pull/149


Repos with a Large Number of Changesets may Require a Server Workspace

The default behavior creates a workspace instance that uses a local workspace. This is fine of repos that have a small number of changesets, but in repos with thousands of changesets, I found it necessary to use a Server workspace location when creating the workspace.
Because this repo isn't being maintained, I didn't properly wire this capability in as an option and instead just modified and ran the source for my purposes. However, I did create a pull request for illustrative purposes (https://github.com/git-tfs/git-tfs/pull/1338).
In case others run into the same issue, though, the specific error I received was:

TF400030 – The local data store is currently in use by another operation. Please wait and then try your operation again. If this error persists, restart the application.

https://github.com/git-tfs/git-tfs/blob/1355d5ff048b28764c27f0b0bff71e82a09f625d/src/GitTfs.VsCommon/TfsHelper.Common.cs#L726

I am interrested in why the number of changesets matter for a server workspace, especially as I regularly deal with
projects which have > 1000000 changesets. To my knowledge, the number of files in the workspace are the deciding point to
chose a server workspace over a local workspace.
Did I miss something?

I think you're correct @siprbaum. I based my description on my memory of this answer on Stack Overflow, which led me to this documentation for Azure DevOps. I suppose I misinterpreted "100,000 items in the workspace" as changesets, not files. However, that said, iirc changesets in TFVC would mean distinct copies of the files, so maybe items means the number of files in all changesets? Meaning for example, if you had 5k files and you changed all of them in 5k changesets, you'd have 25m items (5k x 5k)? I could be wrong but I believe that would be consistent with the number of files and changesets I migrated. The smaller and less active repos worked fine using the default Local location, but not for the larger, more active repos.
Regardless of how TFVC defines item though, the ability to use a Server location proved useful in my situation and I wanted to share in case it works for others (and as a reminder for myself).

So you are using that server workspace only to get rid of that TF400030 error you mentioned?
Or does it also have any performance benefits?
Looking only at the error message, I isn't at least obvious in any way why this should solve the problem that
the workspace is accessed by different operations simultaniously ... which leaves me a little puzzled.

This was not about a performance fix, but instead only resolving the TF400030 error. This blog post referenced in the SO answer I previously mentioned, calls out that specific error and another that can occur when using a Local workspace. Those three articles lead me down the path of determining how this project creates the workspace, and thus the example pull request I created.
Prior to making the changing, some of the repos I migrated would consistently stop with that error. I don't recall if they always stopped at the same point or not. After changing the workspace location, I no longer received that error and was able to let the process run to completion.


ci: action dependency updates

Updating github actions to their latest versions. Additionally adding a dependabot configuration to scan and monthly upgrade these actions in the future.

Security and possible breaking changes


*: notify snapshot apply

What is changed and how it works?
Issue Number: Close #12057.
What's Changed:
In the past, it relies on base tick to check if a snapshot is applied.
If the base tick is set to a very large value, it will take a long time
to detect snapshot is finished. This PR adds a casual message to notify
peer actively.

Check List
Tests

Unit test

Release note
None

/merge

/merge


Correct SFTP remote_file tests

Description
Corrects URI in remote_file sftp test
Issues Resolved
Initial #4750 merge incorrectly tested 'ftp' scheme.

tests are broken now though.

Paging @jkerry - author of original merge.

 Any idea why the tests are suddenly broken? They have been stable for a few months easy

Nvm, just looked at the changes. I'll poke at this soon

Rebased pull with suggested changes.

well this is definitely more-correct, but i'm also mildly concerned the tests weren't broken before...


fix(options): add proper path-checking for filter in windows

Regex didn't include backslashes for windows environments so the plugin never included licenses.

This change is

Oh man, thank you!

missed one slash! https://github.com/Microsoft/license-checker-webpack-plugin/pull/5


missing canvg and html2canvas dependencies when building using docker-compose

Bug description
When building superset using docker compose, the webpack will build node_modules without optional the optional dependencies canvg and html2canvas. This results in an error message when the superset_node container runs.
How to reproduce the bug
Navigate to superset directory and run docker compose up.
Screenshots/recordings

Superset version
master / latest-dev
Python version
3.9
Node version
16
Browser
Chrome
Additional context
No response
Checklist

[X] I have searched Superset docs and Slack and didn't find a solution to my problem.
[ ] I have searched the GitHub issue tracker and didn't find a similar bug report.
[ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

Fixed by https://github.com/apache/superset/pull/27091

I'm still seeing this error when running in docker


Questions about the dropout feature

Dear TT members,
There are LLK implementations of dropout sub-op in an elem-wise unary op.
(llk_math_eltwise_unary_sfpu_dropout_init, llk_math_eltwise_unary_sfpu_dropout)
I wrote a compute api header for dropout and modified SFPI code to run dropout op properly.
There seem to be two main things to check about the current implementation.
The management of a random state.
In general, compute api follows this call sequence; xxx_init() and xxx().
The random state is initialized with seed argument from dropout_init() then is used in dropout().
In other words, the same random state is used every time the dropout API is executed.
The random state must be managed separately as a uint16_t or uint32_t data format tile. (related to https://github.com/tenstorrent-metal/tt-metal/issues/4624)
performance aspect
Dropout uses 16-bit PRNG. It must return a result that satisfies the p value passed as an argument.
The following is a table measuring the dropout rate of one tile according to seed and p value with 0, 0 Tensix.

p
dropout rate (%)(seed = 0)
(seed = 3407)

0.9 (58982)
95
87

0.7 (45875)
83
73

0.5 (32768)
70
45

0.3 (19660)
55
20

0.1 (6553)
38
4

I pushed moreh/dropout branch to check this feature. :)
test code is test_eltwise_unary_dropout.cpp.


feat(plugins): allow to import separate plugins

Finally I succeed to achieve that !
With that PR, folks will be able to choose which plugins they want to import and not all of our plugins.
Examples:
Importing Util
import $ from 'jquery';
import Util from 'bootstrap/dist/plugins/util';

Importing Popover
import $ from 'jquery';
import 'popper.js';
import 'bootstrap/dist/plugins/tooltip';
import Popover from 'bootstrap/dist/plugins/popover';

This PR would help a lot in that case: https://github.com/symfony/webpack-encore/issues/338
TODO

[x] Update our docs

Finally I won't remove js/dist files because it should be a breaking change but I'll update our docs to stop mention them

ping @XhmikosR

ping @XhmikosR

Isn't there any way to not add yet another set of generated files to the repo?
Shouldn't we test these files too?

Yep I'm not confortable with adding a new set of dist files... I thought about deleting our js/dist folder but it can be helpful for those who don't use bundlers
Those files don't have to be tested because the logic is the same.
Bundlers are used a lot nowaday, so we should be able to provide distinct plugins

Please wait for @mdo's feedback too.

This wouldn't be a patch release, this would be a minor or major as it adds new functionality IMO. Could be convinced otherwise though.
That aside, does anything change once we've removed the jQuery dependency? Does this gain us anything long term? Is there a path forward without generating more dist files?

Nope nothing will change about that when jQuery will be removed, I choose to build our plugins in UMD (our other dist files are in UMD too, except js/dist) because it's compatible with most of bundlers so we'll keep those file for a long time.
Unfortunately there is no other path, for example Popper.js (see https://cdnjs.com/libraries/popper.js) is built in three format (UMD, ESM and IIFE)

The issue is that even without jQuery, your plugins still depend on Util, and these internal dependencies are incompatible with bundlers if they rely on global variables all the time.
One solution could be to turn the existing js/dist into UMD ones all the time. It would still work for people using them globally (that's the point of UMD: it works for both global-based loading and CommonJS)

Unfortunately it's doesn't work if we build our js/dist files in UMD, because the scope of Util won't be reachable for our other plugins, that's why I let them in IIFE

@Johann-S that's not true. UMD builds can still expose their export to be consumed by others. That's the whole point of UMD.

I tried what you said @stof and that's what I think too, but that's not what I get... Maybe I miss something in my Rollup config 🤔

Finally I found a solution using only Babel without Rollup.
But for those who do not use a bundler, to use our plugins they will have to add ['default'] for example:
Util['default'].getUid('test')

For me it's a breaking change, but with this solution no new dist files... Any feedbacks ?
/CC @XhmikosR and @mdo

@Johann-S I don't know enough about it at the moment to make a call myself. Might need to ask you to explain more over Slack?

Sure @mdo will talk about it on Slack 👌

Hi everybody !
Finally I made a change in my script, and...

No new dist files
No breaking change
One dev deps nuked

So IMO, we should merge that asap.
/CC @XhmikosR if you can check my docs change 😄 , and @mdo to notice you

@Johann-S how does jquery work for you? i always get TypeError: $ is undefined (referenced in util.js:64:5)
import $ from 'jquery';
import 'bootstrap/js/dist/util';
import 'bootstrap/js/dist/carousel';

my project is setup with a rollup config where i already tried a thousand things for making jquery work :(

Pretty difficult to help you without seeing your Rollup config @donni106

thanks. ok, currently it is the following. but i tried with setting globals or commonjs stuff before. i read a few things but nothing made any changes.
const path = require('path');
const babel = require('rollup-plugin-babel');
const resolve = require('rollup-plugin-node-resolve');
const commonjs = require('rollup-plugin-commonjs');

const fileDest = 'script.js';

module.exports = {
  input: path.resolve(__dirname, '../src/tx_theme/js/main.js'),
  output: {
    banner: '',
    file: path.resolve(
      __dirname,
      `../dist/typo3/typo3conf/ext/theme/Resources/Public/JS/${fileDest}`
    ),
    format: 'umd',
    globals: {},
    name: 'script',
  },
  external: ['jquery'],
  plugins: [
    babel({
      exclude: 'node_modules/**',
    }),
    resolve(),
    commonjs(),
  ],
};


Scrollbar issue

I'm trying to stop the content div from moving when the menu opens and closes. I know it's because the scroll bar comes and goes, but cannot figure how to either fix the div or maintain the scollbars always.
Am I missing something?

I just ran into this same issue and the code fix above works like a charm.  Thanks @FrDH


chore: increase vacuum batch size

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
As we've support batch delete for object store, we can increase batch size of each vacuum task, so that to reduce overhead of small tasks.
Checklist

[x] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)

LGTM!


Fix windows path error

Fix error due to formation of url from file paths on windows
during CI/CD.
Use of PosixPath does not work -> not implemented error.
Use of Path.as_posix() does not seem to work either!
Fix by splitting into parts and manually joining with '/'

Fix error due to formation of url from file paths on windows
during CI/CD as_posix method of Path


Update parameter ConnectionModeInSecondaryRole to include SSMS options #5211

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[X] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[X] Documentation
[ ] Build system

Purpose

Maps SSMS options "No", "Read-intent only", and "Yes" to SMO options for ConnectionModeInSecondaryRole. See https://github.com/sqlcollaborative/dbatools/issues/5211
Also fixed a minor typo in New-DbaAgentSchedule.ps1: changed "of" to "if".
Approach

Based off of mapping in New-DbaAgentSchedule.ps1 per suggestion from @wsmelton .
Commands to test

Set-DbaAgReplica -SqlInstance MyInstance -AvailabilityGroup MyAG -Replica MyInstance -ConnectionModeInSecondaryRole 'Yes'
New-DbaAvailabilityGroup -Primary MyInstance -Name MyAG -ConnectionModeInSecondaryRole 'Read-intent only'
Screenshots

Learning

super cool change, thank you Mike!


[XI18N] Unknown option: '--progress'

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)
- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [x] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

Angular CLI: 6.1.0
Node: 8.11.3
OS: darwin x64
Angular: 6.1.0
... animations, cli, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, platform-server, router
Package                           Version
@angular-devkit/architect         0.6.8
@angular-devkit/build-angular     0.6.8
@angular-devkit/build-optimizer   0.6.8
@angular-devkit/core              0.6.8
@angular-devkit/schematics        0.7.0
@ngtools/webpack                  6.0.8
@schematics/angular               0.7.0
@schematics/update                0.7.0
rxjs                              6.2.2
typescript                        2.9.2
webpack                           4.8.3
Repro steps

ng xi18n --output-path src/locales/ --progress false
The log given by the failure

Unknown option: '--progress'
Desired functionality

The --progress option seemed to have been removed in 6.1, with no mention of it in the changelog or any migration examples.
Mention any other details that might be useful

Worked fined in 6.0.9

Same with the e2e option, --progress was there, and now it's not working anymore.

@hansl does your commit also fix the --progress option for the e2e command? As this issue was referenced when closing this other one: https://github.com/angular/angular-cli/issues/12057
Thanks!


Auto-fuzz: Build docker image for fuzzer generation

This PR follows #1306 which includes logic to build the docker image for the fuzzer generation process and run a simple ls command in a docker container of the built image. The addition of the logic does not affect the process of manager.py. There will be another PR later to change the flow of manager to use the docker container to do the fuzzer generation process.
This PR needs rebase after the docker file created in #1306 has been merged.

This PR is closed because the approach has been changed. New PR is coming in later.


Sequential bot.on() blocks don't work as expected

Hey authors,
There's a glitch in middleware composer which doesn't allow to use more than one bot.on() block. Steps to reproduce:
// Uncomment to effectively disable the `on("text")` block below.
//bot.on("callback_query", async (ctx, next) => await next(ctx))

bot.on("text", async (ctx, next) => {
  ctx.reply(`Got ${ctx.message!.text!}`)
  await next(ctx)
})

Cheers!
Alex

There's a pull request for this. Please consider.


[BEAM-8019] Updates Dataflow client

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Thanks! Any notes as to how this generated?

There's documentation available internally. Not sure if this can be easily generate purely using Beam repo.

Do you know why the Google Cloud Dataflow client library is not part of https://github.com/googleapis/google-cloud-python?

I do not know the answer.
@busunkim96 @tseaver -- Do you know what is need to include Dataflow apis in the google-cloud-python package?

@aaltay I'm not sure which API you mean:  is it this REST API?  If so, we would need to have somebody from within Google commission adding support for that API.

We recently moved all the code in google-cloud-python to separate repos named python-{api}. For example, the repository python-bigquery has the google-cloud-bigquery package.
Is the Dataflow client generated using google-api-python-client? That library is used to generate libraries at runtime from the discovery document (https://dataflow.googleapis.com/$discovery/rest?version=v1b3).
@leahecole is there a good DPE to direct this question to?

The client file in this repo is generated by https://github.com/google/apitools. I assume they will generate client libraries with same capabilities even if there might be slight changes.
The generated version here is also for the rest api. I am not sure who/how often the related discovery document is updated.

Dataflow client was generated by running apitools genclient utility [1] on the Dataflow discovery document [2].
[1] https://github.com/google/apitools/blob/master/apitools/gen/gen_client.py
[2] https://www.googleapis.com/discovery/v1/apis/dataflow/v1b3/rest

Hmm, the cloud client libraries team doesn't maintain that repo. The GitHub team (https://github.com/orgs/google/teams/apitools) looks promising if you're looking for someone to reach out to.

@busunkim96 - let's say we can consider switching to google-api-python-client. What would be the process? Who would own the new repo?

Hi @aaltay. You can already talk to the API using google-api-python-client.

pip install google-api-python-client

from googleapiclient import discovery

client = discovery.build("dataflow", "v1b3")

I think I'm missing important context here about Beam and/or Dataflow. Adding @davidcavazos who works on Dataflow in Cloud DevRel.


Allow multiple nested marks

Previously we only ever allowed one mark to be set against an error in the
statck. If we attempted to nest them, then we would end up clearing all
the errors in the stack when we popped to the mark.

Fixed the issue raised by @t8m and added the additional test case suggested by @paulidale. Please take another look.

This pull request is ready to merge

Pushed. Thanks.


Move Icon related packages out

Hey @loklaan ,
I think we should move the Icon related packages back to its own repo. Sorry about this, I know I asked to put them in here initially 🤦♂
But now since things are changing a lot in Radix I think it will make more sense this way.
Would you mind tackling that when you get a chance, please? I think you'll be much more efficient at doing this than me.
Thanks a lot!

@peduarte No worries.
Could you elaborate on the reasons, for posterity's sake?

Absolutely.
Iteration
Quite often I’m iterating with how Radix and website are built and work together. Next I wanna try a gatsby theme. Having icon packages in there means I need to also consider side effects and ensuring nothing I do impacts that
Modulz output
I’d like this repo to try and resemble what the Modulz output would be like. Which is a design system and docs.
Productivity
The icon library is pretty stable and as a result not much work is done on there.
Radix, website and Radix System on the other hand are heavily WIP. Multiple commits a day and releases a week. As well as many Netlify builds per week.
Having them all as a monorepo requires pre-building them all and as a result everything takes much longer.
Extras

I also want to remove commilint, this library still in alpha and it’s slowing me down. Once things are more stable I’ll add back in as well as automated change log
And finally, for simplicity sake. As the team grows I’d like the component team to just focus on components. By removing icon related stuff it’ll simplify onboarding

@benoitgrelard Hey do you think you could take this one? It needs to be moved to this repo: https://github.com/modulz/radix-icons