[BUG] Service Bus: Unable to set AutoDeleteOnIdle when ForwardDeadLetteredMessagesTo is set

When creating or updating ServiceBus topic subscriptions AutoDeleteOnIdle setting will be ignored if ForwardDeadLetteredMessagesTo property is set.
Expecting the AutoDeleteOnIdle to be set no matter if ForwardDeadLetteredMessagesTo is set or not.
Sample code:
using System;
using System.Threading.Tasks;
using Microsoft.Azure.ServiceBus.Management;

namespace AutoDeleteOnIdle
{
    class Program
    {
        static async Task Main(string[] args)
        {
            var connectionString = "your connection string here";
            var managementClient = new ManagementClient(connectionString);
            var topic = await managementClient.CreateTopicAsync("testtopic");
            SubscriptionDescription subDescription = new SubscriptionDescription(topic.Path, "testsubscription")
            {
                AutoDeleteOnIdle = TimeSpan.FromHours(1),
                ForwardDeadLetteredMessagesTo = "deadletterqueue"
            };
            await managementClient.CreateSubscriptionAsync(subDescription);
        }
    }
}

If the line with "ForwardDeadLetteredMessagesTo" is removed everything works as expected.
Environment:

Name and version of the Library package used: Microsoft.Azure.ServiceBus 5.1.1 - older versions seem to have the same behavior.
Hosting platform or OS and .NET runtime version: Azure ServiceBus, test project .net core 3.1 console application
dotnet --info
.NET SDK (reflecting any global.json):
Version:   5.0.101
Commit:    d05174dc5a

Runtime Environment:
OS Name:     Windows
OS Version:  10.0.18363
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\5.0.101\
Host (useful for support):
Version: 5.0.1
Commit:  b02e13abab
.NET SDKs installed:
2.1.801 [C:\Program Files\dotnet\sdk]
2.2.401 [C:\Program Files\dotnet\sdk]
2.2.402 [C:\Program Files\dotnet\sdk]
3.0.100-preview8-013656 [C:\Program Files\dotnet\sdk]
3.1.101 [C:\Program Files\dotnet\sdk]
3.1.201 [C:\Program Files\dotnet\sdk]
5.0.100 [C:\Program Files\dotnet\sdk]
5.0.101 [C:\Program Files\dotnet\sdk]
.NET runtimes installed:
Microsoft.AspNetCore.All 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.1.23 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.2.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.1.23 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.2.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.0.0-preview8.19405.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.1.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.1.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.1.10 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 5.0.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 5.0.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.1.23 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.2.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.0.0-preview8-28405-07 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.10 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 5.0.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 5.0.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.0.0-preview8-28405-07 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 3.1.1 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 3.1.7 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 3.1.10 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 5.0.0 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 5.0.1 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

IDE and version : Visual Studio 16.8.3

//cc: @JoshLove-msft:  This may impact the T2 library as well.

Thank you for your feedback.  Tagging and routing to the team best able to assist.

@Bubelgin Thanks for raising this issue.
For the forwarding logic to work, the queue/subscription must exist. Hence if you set forwardDeadLetterMessagesTo setting, you can't enable AutoDeleteOnIdle on the same entity. This is by design.
Do let us know if you have any follow up questions.

In our particular use case, a topic represents a store and each subscription represents a driver, each message on the subscription represents an order. If the order is not picked up by the driver after x minutes the order expires and goes to the dead letter queue where they're processed accordingly so enabling dead letter functionality is necessary.
On the other hand, there can be a lot of unique drivers over time so we want to eventually clear unused subscriptions that have not been active which also requires the AutoDeleteOnIdle to be set.
ForwardDeadLetterMessagesTo does target a particular queue that already exists and AutoDeleteOnIdle is supposed to delete the subscription, not the target queue so I don't exactly understand the reason why both functionalities can't coexist. It's like saying that if you have ForwardDeadLetterMessagesTo set on a subscription then you can't delete the subscription which is not true.
Are we supposed to manually setup scheduled workers to scan and clear each subscription that has not been used for a duration when AutoDeleteOnIdle is meant to do exactly that? Any suggested workarounds or plans to change this?
As a side note, if you're using Service Bus explorer you can set the AutoDeleteOnIdle property correctly even when ForwardDeadLetterMessagesTo is set.

@Bubelgin the problem in this cases arises when the autoDeleteOnIdle counts down and deletes the subscription while it still has data that was meant to be deadlettered and forwarded to the queue.
Without knowing much about your use-case and architecture, so this is just my guess -

why not have each driver simply be a consumer on a subscription (and not a separate subscription)? It seems that the 1:1 mapping between driver and subscription is causing the problem.

Perhaps each store needs to be a subscription and each driver can be a receiver application on that subscription?

I'm seeing the same problem with the ForwardTo being set.
I can see why the receiving  queue must exist for forwarding from a subscription to work, although that doesn't prevent me from deleting the queue or setting up OnIdle deletion of the queue and have it disappear (looking at the subscription the portal gives you no clue that anything is wrong, but that's another issue).
But I don't understand why setting up subscription forwarding and OnIdle deletion are mutually exclusive. I can delete the subscription any time myself, right?
Another thought is that the pattern doesn't hold for topics - I can make topics delete on idle, regardless of wether there are subscriptions attached to it. Sure, the underlying mechanism is different, but the idea is the same.
If it's just an implementation problem I think this should be addressed. And if not, maybe you could elaborate as to how it is beneficial.

@Bubelgin the problem in this cases arises when the autoDeleteOnIdle counts down and deletes the subscription while it still has data that was meant to be deadlettered and forwarded to the queue.
Without knowing much about your use-case and architecture, so this is just my guess -
* why not have each driver simply be a consumer on a subscription (and not a separate subscription)? It seems that the 1:1 mapping between driver and subscription is causing the problem.

* Perhaps each store needs to be a subscription and each driver can be a receiver application on that subscription?

Switching the setup would not work in our scenario and having multiple clients for the same subscription introduces way more concurrency and performance problems than it solves. As @et1975 mentioned I don't see why these functionalities should be mutually exclusive.
As a use case, I just want my messages to be deadlettered and forwarded to a queue if message TTL expired (say 30 minutes).
Unrelated to that I want the subscription to be deleted if it's not been active for 1 day, at that point I don't care if there are any messages in the queue or if they're going to deadletter as it's meant to be deleted anyway.
If it's not currently possible due to some internal way it's written I'd like to raise this as a feature request.

@Bubelgin  We're investigating this internally and will come back with our findings.


RKE2 apiserver cert is missing hostname SAN entries

Tracking issue for fixing RKE2 apiserver cert is missing hostname SAN entries from RKE2 on branch master:

https://github.com/rancher/rke2/issues/1739

Validated on master branch commit eda65b19d9893a033c681ab5b0045d7a0e29d6cb
This has all of the node-name, node-ip, tls-san values, and node-external-ip values when set. When nothing is set, it correctly has the hostname and private ip.


change(ui): Enable the progress bar feature by default, but only show progress bars when the config is enabled

TODO
This change needs:

[ ] A changelog feature entry asking for user testing
[ ] A post on the forums encouraging users to test it after it is released, and mentioning the known issue with estimates
[ ] A mention in the Arborist call

I haven't done the changelog entry because there is a release PR open for the changelog.
Motivation
Currently the progress-bars feature turns on progress bars and file logging when it is enabled.
To make it easier for users to test progress bars, we can make the progress bars configurable with zebrad.toml. This allows us to compile the progress-bar feature by default, but not activate it for every user by default.
(Activating progress bars by default could be a breaking change for some users that expect Zebra to write logs to standard output.)
Close #7363
Close #7364
Complex Code or Requirements
When the progress bar feature is activated, the log file also needs to be activated (unless the user has specifically turned it off).
I added a summary and detailed config, because we might want to have an "expert" mode. But we need to know what users want first!
Solution

Add a config for progress bars, which is only used when the progress-bars feature is enabled
If they are not enabled, log a message telling users how to enable them
Enable the progress-bars feature by default in Zebra builds

Review
This is a low priority feature, it doesn't need to go in the 1.3.0 release.
Reviewer Checklist

[ ] Will the PR name make sense to users?

[ ] Does it need extra CHANGELOG info? (new features, breaking changes, large changes)

[ ] Are the PR labels correct?
[ ] Does the code do what the ticket and PR says?

[ ] Does it change concurrent code, unsafe code, or consensus rules?

[ ] How do you know it works? Does it have tests?

Follow Up Work
Work out which progress bars users want.

The progress_bar or log_file fields are not there.

This is the intended behaviour, because those fields are optional. Fields only get added to the default config if they are required.
The default for progress_bar is currently "no progress bars", and the default for log_file is "no log file" (log to the terminal). This PR doesn't change that.

This looks great, I think there's a small mistake in the second commit not using the default log file path when none is provided but progress bars are enabled.

If i add progress_bar = "summary" to the config i also need to add log_file = "zebra.log" to make it work properly.

[ ] I think this is the same bug, and I'd like to fix it in deserialization, so we don't need to remember to call a special method to get the correct value for log_file.

We could add a new Disabled member to the ProgressConfig enum and make that the default to fix this problem.

I tried that first, but then I realised that Some(Disabled) was the same config as None. So the setting for a disabled progress bar is None (no setting). This lets us change the default later if we want to, without asking everyone to modify their configs.

indicatif-log-bridge looks like a promising alternative if it works with howudoin

We don't use the log crate, we use tracing, so that integration won't work for us. (In particular, we use tracing-subscriber and tracing-appender, rather than the tracing feature log.)

Another option is to document very well how do we expect users to use this feature in this stage. I will like to know that too.

[ ] I had planned on doing this in the changelog, forums, and Arborist call, but you're right, some user documentation is needed.

We don't use the log crate, we use tracing, so that integration won't work for us. (In particular, we use tracing-subscriber and tracing-appender, rather than the tracing feature log.)

The tracing-appender shouldn't be a problem, we could pass it a different writer that calls suspend(|| write(msg)) if we add suspend() to howudoin.

We don't use the log crate, we use tracing, so that integration won't work for us. (In particular, we use tracing-subscriber and tracing-appender, rather than the tracing feature log.)

The tracing-appender shouldn't be a problem, we could pass it a different writer that calls suspend(|| write(msg)) if we add suspend() to howudoin or switch to using indicatif directly. I'll create an issue for this, users should at least be able to see warnings in their terminal alongside progress bars.

Or we could have a tracing subscriber that calls add_warn, instead of writing to the terminal.

Another option is to document very well how do we expect users to use this feature in this stage. I will like to know that too.

This is documented in the README and API reference in commit 9e82ebd748.

Looks like one of them config_tests is hanging, probably because activating the progress bars using that config doesn't show the logs that the test is looking for.
I'll see if I can fix the test.

Looks like one of the config_tests is hanging, probably because activating the progress bars using that config doesn't show the logs that the test is looking for.
I'll see if I can fix the test.

Ok that should be fixed now!

TODO
After this PR merges, add:

[x]  A changelog feature entry asking for user testing
[ ]  A post on the forums encouraging users to test it after it is released, and mentioning the known issue with estimates
[ ]  A mention in the Arborist call

I have done the first task in PR #7610, I'll put the rest in the appropriate Slack channels.


Added the Martian template as an asset

This PR is to make longranger work in LSF mode in the pipeline.
I haven't had any issue with my tests so far (the test profile of this pipeline). The only change I had to make was adding this template, which I guess you had uncommitted in your checkout
I'll leave this as a draft PR until we've confirmed it works for everyone
PR checklist

[ ] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

@muffato Try adding --jobmode=lsf to LONGRANGER_ALIGN ext.args and running it.

In an interactive session with 12 cores:

Vanilla checkout: 3m 5s
With --jobmode=lsf: 4m 59s

At the last dev day, I did the same on a 16-core interactive session:

by default: 4m 33s (why is that slower than on the 12 cores machine ? Perhaps other factors, like how busy the node is, maybe different CPU models)
With --jobmode=lsf: 4m 42s

which shows how variable the runtime can be.
Overall, I'm not too troubled by the difference on this test dataset. I'm reinsured that I can see the jobs filling up bjobs when run in LSF jobmode.


build: add explicit title update to docker annotations

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.055%

Totals

Change from base Build<PHONE_NUMBER>1:
0.0%

Covered Lines:
12117

Relevant Lines:
15865

💛  - Coveralls


Add getElementXML commands

Returns current element values (from main blackboard)
in XML format.
Change-Id: Ic4afe26d19009900dad8ee4c4ad80411f808befe
Signed-off-by: Patrick Benavoli<EMAIL_ADDRESS>

[ ]   General Comment
 @krocard @OznOg @dawagner @louizo : please review
 :-1: I think we can come up with another design.
 @dawagner  @OznOg  @louizo @krocard
WIP: redesign proposed by Kevin & I. Still rework to be done, CConfigurableContext to given retrieve from XML in many cases... Just to take the temperature with this version
 structureTo/FromXML to be aligned with serializeXmlSettings ?
 @cc6565 Please resubmit against serialization_api branch.
[ ]   File: parameter/ConfigurableElementAccessor.cpp:L1-87
 hungarian leftover in pParameterBlackboard.
[ ]   File: parameter/ConfigurableElementAccessor.cpp:L1-87
 useless comments (here and below).
[ ]   File: parameter/ConfigurableElementAccessor.cpp:L1-87
 coding style: keep an argument name but comment it.
[ ]   File: parameter/ConfigurableElementAccessor.cpp:L1-87
 woot ?
[ ]   File: parameter/ParameterMgr.cpp:L86-94
 <mutex> header removal: unrelated
[ ]   File: parameter/ConfigurableElementAccessor.h:L1-82
 nope.
[ ]   File: parameter/ConfigurableElementAccessor.h:L1-82
 Is there really a need for this class to derive IXml* interfaces? What it really does is wrapping a serializable/deserializable element.
[ ]   File: parameter/ParameterMgr.cpp:L1317 (5c3a350)
 It seems strange to me that a configuration access would serve as serializing something else than the settings.
 right
[ ]   File: parameter/ConfigurableElement.cpp:L70 (5c3a350)
 By design, only CConfigurableElement::structureToXml returns false, right? Then, you can simply call return structureToXml(xmlElement, serializingContext).
 yep, rework: structureTo/From to be declared at element side to avoid this

This pull request is now managed with CodeReviewHub. Refresh.

@krocard @OznOg @dawagner @louizo : please review

:-1: I think we can come up with another design.

@dawagner  @OznOg  @louizo @krocard
WIP: redesign proposed by Kevin & I. Still rework to be done, CConfigurableContext to given retrieve from XML in many cases... Just to take the temperature with this version

structureTo/FromXML to be aligned with serializeXmlSettings ?

@cc6565 Please resubmit against serialization_api branch.

@krocard done: PR #270

Thanks @cc6565, removing the resubmit.


Update json-diff to 0.6 seriesx

Featuring better access to underlying diffs.
We don't make use of it just yet though.

@rohdealx what do you think about this change?


added a warning tip for use image() helper

Description (required)

added a warning tip for use image() helper
Related issues & labels (optional)

https://github.com/withastro/astro/issues/10468

Hi @liruifengv!
Let's discuss this, because I think the fix for docs is actually to emphasize in content collections that you are no longer using the layout property anymore, because your Markdown/MDX files are no longer actual pages (that can control their own layout). In content collections, these files now only provide some content and metadata.
See the Step 10 here: https://docs.astro.build/en/tutorials/add-content-collections/#generate-pages-from-a-collection I think this is the real issue, that your frontmatter no longer handles your layout. Instead, your [slug].astro file does.
So, I don't see the solution as something for the image page, but instead something that makes it clear that your Markdown files should NOT attempt to use a layout when they are entries in a collection, because they are no longer a page that can/does control that.
What do you think? Is there a spot this could be clearer in one of these pages: content collections, Markdown/MDX guide, or even Pages (where we discuss markdown pages) because not every markdown file is a "Markdown page" -- only the ones in src/pages/ are. Those last two pages were written before content collections existed, so it makes sense that they don't fully explain the difference when collections are involved.

Thank you for adding this helpful content @liruifengv ! It took me a while, but what do you think about my suggestion instead? This emphasizes right upfront that the property is only available for Markdown/MDX pages (with a link and an extra definition).
Although it doesn't say you can't use this with content collections, I think it makes it clear about when you CAN use it. What do you think?

Looks great!


Postgres Index Optimization and Benchmarking

Introduction
This document outlines the process of optimizing indexes in a Postgres database and conducting before-and-after benchmarks to evaluate the performance impact of these optimizations on specific check queries.
Repository File References

Migrations: Located in internal/storage/postgres/migrations
Queries: Located in internal/engines

Optimization Process
Initial Analysis

Description: Assess the current indexing strategy and identify potential areas for improvement.
Tools Used: [List any analysis tools or scripts used]
Findings: Summarize the key findings from the initial analysis.

Index Optimization

Optimization Strategies: Detail the specific index optimizations implemented.

Strategy 1: [Description]
Strategy 2: [Description]
...

Implementation Details: Provide SQL commands or scripts used for the optimization.

Benchmarking Setup
Environment Details

Postgres Version: [Version]
Operating System: [OS]
Hardware Specifications: [Hardware details]

Benchmarking Methodology

Queries Tested: List the check queries used for benchmarking, as found in the internal/engines folder.

Query 1: SQL statement
Query 2: SQL statement
...

Procedure: Describe the benchmarking process, including how many times each query is run and how metrics are collected.

Benchmark Results
Before Optimization

Query 1:

Average Execution Time: [Time]
Additional Metrics: [Any other relevant metrics]

Query 2:

Average Execution Time: [Time]
Additional Metrics: [Any other relevant metrics]

...

After Optimization

Query 1:

Average Execution Time: [Time]
Additional Metrics: [Any other relevant metrics]

Query 2:

Average Execution Time: [Time]
Additional Metrics: [Any other relevant metrics]

...

Analysis and Conclusions

Performance Improvements: Highlight the key improvements in query performance post-optimization.
Recommendations: Offer any further recommendations based on the benchmarking results.

Appendix

Additional Notes: [Any other notes or observations]
Scripts/Commands Used: Provide any scripts or commands used during the optimization and benchmarking process.

/bounty $400

/attempt #863

@saifxd7, I have assigned this task to you. Happy hacking 🚀

/attempt #863

Hi @tolgaOzen  i have initially seen the issues and have made the initial analysis of the database . Should i share how i would approach for optimizing the database?

Hello @Min2who, @saifxd7 is currently dealing with the issue. You can share it with him or you can collaborate with him on the development

@saifxd7 are you still working?

Yes @Min2who, I'm working on it!

Hello @saifxd7, firstly, we have reviewed your PR and changing old migration files is dangerous for those who previously used Permify and should not be done. Additionally, since we want this issue to be analyzed more thoroughly, we would like to assign one more person to elaborate on it.

i would like to work in it.If you can assign me

@Min2who, I'm assigning you. Happy hacking 🚀

Hello @Min2who, are there any updates?

Hello @Min2who, are there any updates?

Hey @tolgaOzen was travelling for a bit. I will submit my progress in a week. Is it fine ?

/attempt #863

Hi @tolgaOzen could you please assign to me

Throwing my hat in the ring with an /attempt #863

Hi @ayewo, I'm assigning you. Happy hacking 🚀

Hello @ayewo, is there any progress?

I will like to add my name in queue @tolgaOzen.
I have good experience with Postgres indexes.
references:

https://medium.com/@mohanishp1/optimizing-time-series-queries-b9fe7715ccea
https://medium.com/@mohanishp1/indexing-a-blessing-in-vertical-scaling-e037c3063b05

Hey @tolgaOzen
Thanks for the status check.  Hopefully I’ll be able to continue this week.

Hi @ayewo are you working on this?

Hey @tolgaOzen I would like to contribute to this issue if @ayewo is not working.
@ayewo please let us know.

I'm feeling much better and have already started working on this!

Hey @ayewo can we collaborate?

Hello @ayewo, is there any progress?


[suggestion] Modpack Compatibility

Hey there,
just wondering if you could change some little things to ensure modpack compatibillity:
first thing
let HF have an option to have its own wheat / potatoe /vanilla crops
this would would be really helpful in terms of mod seperation since some mods rely on ludicricious amounts of crops and insane money production with automation / blacklisting crops seems to take alot of immersion from the mod
the other thing
let it have its own powerbar on HF-tools only.
With other mods hungerbar-drains can be countered to a point where the mod will get broken
with its own powerbar this would be way easier to handle :)

First: I'm not keen on this, I wanted to keep things more tied in than separate. But I understand what you mean. If I ever was (unlikely). I'd probably rename the vanilla ones to something like 'wild potato' or whatever. To distinguish them. Possibly even let you sell them still but maybe to just a npc and only a certain amount a day. Unlikely to happen though, just a thought.
Two: I originally had my own energy system but I didn't like it, and much prefer using food. It's something I haven't ruled out entirely though since it could work, but it just seems like adding another hardcore aspect which not 100% keen on.

Chromogen:
B:"Drops from vanilla crops not sellable"

I would like to throw in my 2 cents.
Best of both worlds on the vanilla crops by incorporating a "seed bundle" block. Its only function is if you give it 9 seeds/vanilla crops it will give you a HF seed bundle of that type.
With this improvement json files in /crops/  where we can define what crops the seed block accepts  and /store/   Where we can define what can be sold and for how much. So for instance we can sell pams harvestcraft honey etc.
^By doing above you can increase compatibility and immersion. Take agricraft for example. I personally have created json files for all the seeds in my pack from immersive engineering to actually additions to be compatible with json files.

@ecoay The first suggestion wouldn't work unless it had a cost to use. Otherwise you're just getting seeds for free. But nah, I do have a plan on what I'd like to do with that already.
As for json nah, i'm sticking with crafttweaker way, it's just easier for me to support than writing my own system. In 0.6 you can add support for crops with that, and you can already add stuff to stores in 0.5 using it.

Could we possibly also get minetweaker support for what drops from each of the nodes in the mines? Would allow for some interesting modpacks.

Technically you should be able to edit the drops for the normal rocks at least with something that lets you edit loot tables. Granted doesn't help with the other nodes :P

Hehe. I can attest to this. Even Progression has some trouble affecting a specific node. If you feel it would not break the mod, it would be awesome to have. But it is your mod/decision in the end and I (we the fans) will be happy with what you decide.


Cargo uses wrong dep version when dep is declared in [workspace.dependencies]

Problem

Steps
Workspace's Cargo.toml:
[workspace.dependencies]
arrayvec = { version = "0.7", features = ["serde"] }

Workspace member's Cargo.toml:
[dependencies]
arrayvec = { workspace = true }

Remove git and registry in ~/.cargo to force cargo re-download all deps.
Run cargo build
The member crate uses arrayvec-0.4.12 rather than arrayvec-0.7.1

Possible Solution(s)

Notes
Output of cargo version: cargo 1.55.0-nightly (3ebb5f15a 2021-07-02)

The ability to use workspace dependencies hasn't been implemented (see #8415). cargo build should print out several warnings to indicate that there are unrecognized fields:
warning: /ws/Cargo.toml: unused manifest key: workspace.dependencies
warning: /ws/foo/Cargo.toml: dependency (arrayvec) specified without providing a local path, Git repository, or version to use. This will be considered an error in future versions
warning: /ws/foo/Cargo.toml: unused manifest key: dependencies.arrayvec.workspace

When a dependency does not have a version, git, or path, Cargo treats it as version="*". As the warning mentions, this will be an error in the future.
Did those warnings not show up?

They did show up but I ignored them :( Thank you for clarification.

Ok, I'm going to close as this is generally working as expected.  I imagine the warning could become an error, as it has been around for 6 years.


Correct an issue where an extra linebreak is added to a source list

When specifying the architecture for a source, an extra linebreak is added to the source list file, which apt reports as invalid. This change removes the extra linebreak.

Withdrawing this PR until I can figure out where the discrepancy is. Sorry!


[Native Image] Update ubi9 version to 9.3 in python3-ubi

Related Content Pull Request
Related PR:
Related Issues
Related: CRTX-105771
Description
Update the ubi9 version to 9.3 in python3-ubi dockefile.

we need to change the version to the server version

that needs to be done only in py3-native, notice that this is the base ubi image


feat(KONFLUX-4272): Update latest PaC config in run-stage-max-concurrency.sh

Description
Follow up change based on https://github.com/konflux-ci/e2e-tests/pull/1382
Remove non-PAC build configs from run-stage-max-concurrency.sh script and use the latest templating env variable.
Issue ticket number and link
KONFLUX-4272
Type of change
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Locally tested the changes against stage cluster.
source user.env
export THRESHOLD=3500 MAX_THREADS=300 MAX_CONCURRENCY_STEPS=2 COMPONENT_REPO=https://github.com/rh-perf-test-org/devfile-sample RUN_ON_STAGE=true
./tests/load-tests/ci-scripts/max-concurrency/load-test.sh
./tests/load-tests/ci-scripts/max-concurrency/collect-results.sh

Checklist:
I have performed a self-review of my code.

Thank you Rahul!


[move-function] Implement move function support for address only vars.

I have to make a few other changes to make this work for loadable vars, but I
wanted to get this in.
Behind a flag.

Just to provide a little bit of context, I found that when I was looking at the codegen out of SILGen that SILGen was emitting code that used reinitialization via assign like operations (e.x.: store [assign], copy_addr [take]). I had to teach the memory analysis about this to ensure that we stopped propagating moves at that block.

@swift-ci smoke test


NetworkedMultiplayerPeer lacks some exposed methods

The only information exposed to GDScript of a remote peer is its id (int).
I propose to expose something like get_remote_ip(int id) and get_remote_port(int id) to facilitate anyone who want to implement some kind of NAT trasversal.

I was studying how this can be made and I thought adding a binding to GDScript would be easy modifying only networked_multiplayer_enet.h and networked_multiplayer_enet.cpp in modules/enet but it would be better to implement it in the super class NetworkedMutliplayerPeer also. I would make a PR to implement this but I haven't experience in C/C++ stuff so I don't want to do this in a wrong way.
Also, looking in thirdparty/enet I saw this:
https://github.com/godotengine/godot/blob/4b4ed9b72454dea13bd5f0935806519e67f13fbc/thirdparty/enet/godot.cpp#L189-L233
My first thought was to bind a method to expose EnetAddress from peer_map but I can't say it is the best way.

I think it would be better if only NetworkedMutliplayerPeerEnet exposes this information, since there might be NetworkedMutliplayerPeer-s which do not have an ip or a port.


Abigen support for tuple return values

abigen! panics with :
error: proc macro panicked ...   = help: message: called Result::unwrap() on an Err value: MissingData("cannot parse custom type with no components")
when parsing an ABI containing functions which return tuples, e.g.
 fn my_tuple_function(gas_: u64, amount_: u64, asset_id_: b256, params: () ) -> (u64, u64);

So after trying a few things (experiences can be found at https://github.com/FuelLabs/fuels-rs/tree/vnepveu/feat-support-tuple-type):

The "major" blocker for this PR is the "no-orphans" rule of Rust.

Basically, by definition, a tuple is a foreign type. And the thing with foreign types is that you can implement only traits that are defined in the current crate. Issue being that we need to implement the Tokenizable trait, which is defined in a particular crate (fuels-core but that's not the issue).
Passing it over to @digorithm.
A solution I've observed, but is very complicated, in ethers-rs: https://github.com/gakonst/ethers-rs/blob/78c87b11269fe94da6d09a04035afd8367fd3ae5/ethers-core/src/abi/tokens.rs#L79.


Improve pod autoscaling guide

What this PR does / why we need it:
Improves the pod autoscaling guide.

Following our conversation the other day, I clarified a few more things in the pod autoscaling guide @ialidzhikov.

/retest

/lgtm

What needs to happen now for the PR to be merged, please?

/approve

Thank you @rfranzke !


Choos plan button text is not visible in the dark mode

Describe the bug
Choos plan button text is not visible in the dark mode.
To Reproduce
Steps to reproduce the behavior:

Goto https://flash-fathom-ai.vercel.app/pricing
Look second and third card.

Expected behavior
Text must be visible in the dark mode.
Screenshots

I can fix this bug under hacktoberfest as i already setup this project in my local system. @Suraj-kumar00 please assign it to me.

hello @Suraj-kumar00, I fix this issue may i raised a pull request. waiting for you response.......

@Suraj-kumar00 this issue is fixed in PR #60 so you can close this now


Does not work for TypeScript

As soon as my *.vue uses lang="ts" the breakpoints don't work anymore.

I close this one, because this seems to be more a problem Vue(-cli)
https://github.com/vuejs/vue-cli/issues/6479


aws - batch job and batch job definition [draft PR]

Looking for feedback on batch job particle and batch job definition particle. Need to add testing, potentially introduce error handling or retry logic, and improve sync_state/update functions. Unsure on how to handle is_state_equivalent function.

@faizanfahmed thanks for pr! If you haven't already I would recommend creating an example file so that you could try out creating and terminating your particle. It will help us review as well. We have all aws examples in this folder https://github.com/capitalone/Particle-Cloud-Framework/blob/master/examples/particle/aws/ if you want to take a look

I'll definitely add and start running through the lifecycle. Thanks!

#80

Definitely need to add unit test as well. Looks like Moto does support Batch. But I'm not sure how complete it is. https://github.com/spulec/moto/tree/7f0b1d679591a6b69f5d620b2b0ff0a311ed7582/moto/batch
Otherwise, we use Placebo as well. @anovis added a tool to help making generating Placebo test. https://github.com/capitalone/Particle-Cloud-Framework/pull/114

looks like small merge conflict. once you fix it looks ready to merge. thanks for pr!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Faizan Ahmed seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


always enque via active_job interface when defined in cron job config

This should help to prevent #300 by setting active_job: true in config/schedule.yml

Seems fine thanks! I'll be back to this one after Sidekiq v7 support (#369) is merged (we're so close!).

Another aproch for preventing #300 would be to ducktype the enque method:
if klass_const
  if klass_const.respond_to?(:perform_later)
    enqueue_active_job # ...
  elsif klass_const.respont_to?(:perform_async)
    enqueue_sidekiq_worker # ...
  else
    # log error / raise
  end
end

@hqm42 could you please update from master?


Insufficient sanitization in rich text fields

Currently, Saleor does very basic sanitization of Editor.js content through the SanitizedJSONField, but it's not enough to prevent malicious staff users from inlining JavaScript if a renderer recklessly uses it to set innerHTML of an element.
We should use a tool like bleach with a short list of allowed tags and attributes to make sure clean_text_data actually prevents scripting attacks.
@mmiszy said he could provide a list of tags and attributes that are necessary for Editor.js to function.
It's a hardening task, as any client should sanitize untrusted content, so we're keeping the ticket public and will not assign a CVE.

It seems that the only tags that Editor.js uses in Saleor Dashboard are:

b
i
a[href]

Bleach has since been deprecated (see here https://github.com/mozilla/bleach/issues/698), people are migrating to nh3 wich seems very fast.


Upgrade Guzzle7 adapter to 1.0

Your library fixes php-http/guzzle7-adapter to 0.1.1. Can you upgrade it to "^1.0" ? There are basically no changes between 0.1 and 1.0.

Already done and released in https://github.com/lokalise/php-lokalise-api/pull/21

I see you guys released it two days ago, great, thanks!


Some question about BlockMerging.

@WXinlong Thanks for sharing your work, and i have some question for the function of BlockMerging. When i run the test code with my data. I encountered a IndexError that the actual index which was generated through the code "x,y,z = (pts[:,0]/gap).astype(np.int32)" was out of bounds for axis 1 with size of volume. I didnot change any code except training and testing with my data.  I am curious to know the the function of BlockMerging and the meaning of the following code:
gap = 5e-3
volume_num = int(1. / gap)+1+200
volume = -1* np.ones([volume_num,volume_num,volume_num]).astype(np.int32)
volume_seg = -1* np.ones([volume_num,volume_num,volume_num]).astype(np.int32)
Looking for you reply, Thank You!

Hi, the BlockMergeing part is borrowed from SGPN, as said in our paper. The code you mentioned aim to remove deplicate instances.

您好，我也在blockmerging这里出现了问题。不同的是我用的都是S3DIS数据以及训练好的model，
但还是出现了   index 129 is out of bounds for axis 0 with size 100这个问题，请问您解决了吗？


Fix inner line spacing of links

Problem Description:
The line spacing of links is too big.
Expected Behavior/Solution:
The line spacing should be smaller.
Requirements:

[x] Fix line-height css attribute on RecordLinks

Needed for promotion:
If an item on the list is not needed, it should be crossed off but not removed.

[x] Wireframe/Mockup - Mike
[ ] ~Committee discussions - Sarah~
[ ] ~Feasibility/Team discussion - Sarah~
[ ] ~Backend requirements - TBD~
[x] Frontend requirements - Kam
[ ] ~Questions~

UAT/LUX Examples:

https://lux-front-tst.collections.yale.edu/view/person/c225d5e4-8767-4a25-802b-af054d5e8f52  (shrink window size to view this change in Events Containing Objects Created By)

Dependencies/Blocks:
N/A
Related Github Issues:
N/A
Related links:

Bugherd: https://www.bugherd.com/projects/284041/tasks/2142

Wireframe/Mockup:
Current:

Expected:

@kamerynB is this OK to move to reviewable?

Approved by UAT

Looks good in prod, closing


feedback: mmap for keeping Model in VRAM when Flash Attention is used

Goal
Feedback from WiseFarAI:
I am also wondering if you guys use Mmap and other ways of keeping the model in Vram memory and if/when Flash Attention is used. Since these parameters cannot easily be observed (their current setting) or changed from within the UI. Sometimes it seems like it tries to reload the model mid-conversation and the generation speed drops from 6 tokens to 2 per second.

@vansangpfiev assigning to you to investigate,  cc @dan-homebrew - will have a call with Sang next week


Can the {% feed_meta %} helper tag pull feed dynamically?

I was wondering if the {% feed_meta %} can pull feeds dynamically, that is, based on the page it's on. In my case, I don't have a "posts" collection but collections by other names
feed:
  collections:
    skills:
      path: '/feeds/skills.xml'
    thinklist:
      path: '/feeds/thinklist.xml'
    words:
      path: '/feeds/words.xml'

So I expect that when I'm on the "skills" archive the {% feed_meta %} helper tag should pull feeds on this page, not the default /feed.xml which is blank in my case since I don't have a _post collection. And so on for others...
Or if there's a way to make all three feeds show in the head section on my site's tree?

Hi @softcomux, I came across the same issue so I submitted a pull request for generating meta links to all collections (see #254).
Would that help in your situation? Or would you need to be able to tell {% feed_meta %} which link to generate? If so, feel free to chime in and explain your use case, if it's still relevant. Thanks!


feat: add additional content for lottery published email

This PR addresses #838

[x] Addresses the issue in full
[ ] Addresses only certain aspects of the issue

Description
Please include a summary of the change and which issue(s) is addressed.
How Can This Be Tested/Reviewed?
Provide instructions so we can review, including any needed configuration, and the test cases that need to be QAd.
Author Checklist:

[ ] Added QA notes to the issue with applicable URLs
[ ] Reviewed in a desktop view
[ ] Reviewed in a mobile view
[ ] Reviewed considering accessibility
[ ] Added tests covering the changes
[ ] Made corresponding changes to the documentation
[ ] Ran yarn generate:client and/or created a migration when required

Review Process:

Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

I don't understand why the backend unit test is failing…it seems to be some problem with auth tokens, which I don't believe any of my code affected.

We can only run scripts once, so we will have to create a new script that runs with the strings, similar to how we have addLotteryTranslations and addLotteryTranslationsCreateIfEmpty. There's some extra documentation here and this PR may be helpful as well.

Thanks @emilyjablonski I wasn't exactly sure what approach to use here. I'll give that a look and fix.

OK, I've backed out of updating translations in the old script, and created a new script endpoint. I'm not really sure how to test it though. A few other tests I looked through for the script runner seem to validate that the script was run, but mock all the DB access. I don't know how to validate I actually updated translations successfully without mangling the JSON somehow.

Hey @jaredcwhite a couple things:

you're missing exposing your new service function in the api. You'd need to create that endpoint in the script runner controller where you can more or less copy how the other script runner endpoints live. That would all you to test locally but hitting the api targeting that new endpoint

You should add unit tests for your new script runner service function. We do mock up the db reads/writes in our unit tests but thats mostly so we can isolate logic and strongly recommend test coverage for all script runner service functions. Since they are built to only run once, if it fails in prod or produces wonky results it would be a pain to then fix

Thanks @YazeedLoonat for the pointers! 🙏🏻  I'll look into all of that.

@YazeedLoonat OK, I should be good to go with those two points, although the actual verification of what the updated JSON looks like in the DB I had to do manually when testing locally. Happy to keep iterating if you have a suggestion.
@KrissDrawing I think you can start working on #837 either by going off of this branch, or creating a new one with a similar approach. Whichever seems easiest.

Please add description and testing info to the PR template. Merge conflicts need addressing

From the PR linked above, we already had the updateForLanguage helper - I wonder if we should re-use that? There's some duplication going on with updateLanguage

OK, this is ready for review again!


Removing all sizes from ImageResizer make settings crush when trying to add new size

Steps to reproduce

remove all sizes
add size

Expected behavior
Size is added
Actual behavior
Settings crushes

Since it's a crash let's fix it for 0.18


Error while building ninja on macOS, High Sierra, 10.13.3

I got this error. FAILURE: Build failed with an exception.

Where:
Build file '/Users/jacobsoderman/github/scrcpy/server/build.gradle' line: 1

What went wrong:

A problem occurred evaluating project ':server'.
  java.lang.UnsupportedClassVersionError: com/android/build/gradle/AppPlugin : Unsupported major.minor version 52.0

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

* Get more help at https://help.gradle.org

BUILD FAILED in 39s
ninja: build stopped: subcommand failed.

/Söder

Unsupported major.minor version 52.0

You need Java 8.

OK. Thanks. But I read further down and downloaded the .jar instead.
But I then got this error.
$ ninja
ninja: error: '/Users/mainuser/github/scrcpy-server.jar', needed by 'server/scrcpy-server.jar', missing and no known rule to make it
/Söder

What was the initial meson command you executed?

In the readme file, under Prebuilt server, after I've specified the path the downloaded scrcpy-server-v1.0.jar,
meson x --buildtype release --strip -Db_lto=true
-Dprebuilt_server=/path/to/scrcpy-server.jar
cd x
ninja
sudo ninja install
It was then I typed "ninja" I got that...
/Söder

I'm having the same issue:
/scrcpy$ meson x --buildtype release --strip -Db_lto=true -Dprebuilt_server=~/Documents/scrcpy-server-v1.0.jar

WARNING: You are using 'ANSI_X3.4-1968' which is not a a Unicode-compatible locale.
WARNING: You might see errors if you use UTF-8 strings as filenames, as strings, or as file contents.
WARNING: Please switch to a UTF-8 locale for your platform.
The Meson build system
Version: 0.37.1
Source dir: /home/z003utcv/Documents/scrcpy
Build dir: /home/z003utcv/Documents/scrcpy/x
Build type: native build
Project name: scrcpy
Native c compiler: cc (gcc 6.3.0)
Build machine cpu family: x86_64
Build machine cpu: x86_64
Found pkg-config: /usr/bin/pkg-config (0.29)
Native dependency libavformat found: YES 57.56.101

cd x
ninja

ninja: error: '../server/~/Documents/scrcpy-server-v1.0.jar', needed by 'server/scrcpy-server.jar', missing and no known rule to make it

Native dependency libavcodec found: YES 57.64.101
Native dependency libavutil found: YES 55.34.101
Native dependency sdl2 found: YES 2.0.5
Build targets in project: 6

@abacao Try using the full absolute path for the server:
meson x --buildtype release --strip -Db_lto=true -Dprebuilt_server="$HOME"/Documents/scrcpy-server-v1.0.jar

I now understand I had to rename the server file.
But now at ninja run, I got this problem, I think has to do with adb. How do I set the path for that?
$ ninja run
[0/1] Running external command run.
exec: No such file or directory
2018-03-12 21:49:49.302 scrcpy[10239:797835] ERROR: "adb push" returned with value 1
FAILED: meson-run
/usr/local/opt/python/bin/python3.6 /usr/local/Cellar/meson/0.45.0/libexec/bin/meson --internal commandrunner /Users/mainuser/github/scrcpy /Users/mainuser/github/scrcpy/x '' /usr/local/opt/python/bin/python3.6 /usr/local/Cellar/meson/0.45.0/libexec/bin/meson scripts/run-scrcpy.sh
ninja: build stopped: subcommand failed.

So, it's fixed?

Option 1 solved the problem
https://stackoverflow.com/a/28208121/7540894


Merge master to deploy

To ship passing the generated Fastfile ID and success/failure to the analytic ingester

@asfalcone Over-the-shoulder 👍 's this


[ WEB] Bump web version

Is there any timeline for bumping the web dependency. Currently it is at  web: ^0.5.1 and 1.0.0 is available.

Hello @anovis, this new version requires Dart 3.4, so don't expect us to bump too fast. You can still use dependency override of you need it faster.


[WIP] Expose port

Hi @sharksforarms, I'll rapidly need this feature. Can I help you in any way ? :D

@sharksforarms there have been recent changes that introduced merge conflicts here. What is the current status of this branch?

@sharksforarms Can I merge it into my fork, resolve the conflict and submit a new pull request ?

Also why Travis is failing when building openssl ?

Not sure about openssl. Try to sync with the lastest master and see if you get the same result

@softprops Can you explain why there is all theses:
    params_list: HashMap<&'static str, Vec<String>>,
    params_hash: HashMap<String, Vec<HashMap<String, String>>>,

why the params: HashMap<&'static str, Value>, isn't enought ?

@softprops, using the macro json!(), we can get rid of params_list and param_hash. I'm currently testing it alone and it seems to work well :D

closing this in favor of the now merged https://github.com/softprops/shiplift/pull/127

Can be closed @softprops.


User is directly getting access to site without asking for code

I am using rails 5.2 and two_factor_authentication 2.1.1. I am following exact steps mentioned in https://github.com/Houdini/two_factor_authentication/blob/master/README.md and https://www.rubydoc.info/gems/two_factor_authentication/1.1.5. When user signs in it get direct access to site without asking for code. It worked once and all of a sudden stopped working.

I am having the same issue here, it worked in the first time but never again

Currently its working for me I added create_direct_otp method to my user model and made this true config.delete_cookie_on_logout = true  in devise.rb file.
But if you just config.delete_cookie_on_logout = false this true and don't add create method to user model it does not work.

New Problem:
I am getting below error,
/usr/local/rvm/gems/ruby-2.5.1/gems/activerecord-5.2.0/lib/active_record/dynamic_matchers.rb:22:in method_missing': undefined local variable or method has_one_time_password' for User (call 'User.connection' to establish a connection):Class (NameError)
Did you mean?  has_secure_password
it is not allowing me to add has_one_time_password field in my app.

The config.delete_cookie_on_logout = true was enough for me, thanks for the help, it's working now

+1 config.delete_cookie_on_logout = true -- That's all you need to do.


LovelyTextInputDialog - no negative button

Hi
Is it possible that you will add negative button to LovelyTextInputDialog?

.setNegativeButton()

Sorry but I can't find .setNegativeButton on LovelyTextInputDialog, it has only confirmation button support.

Hi, you are right - currently there is no negative button for TextInputDialog. Maybe I will introduce it, but a bit later - currently I'm busy on other projects.
You can also try to add it yourself and make a pull request :)


2019 Macbook Pro Support

Does not appear to work with the 2019 Macbook Pros.

https://github.com/DanielStormApps/Fanny/issues/31

Yep. Same problem.

Resolved in https://github.com/DanielStormApps/Fanny/commit/cec8011c7d7f9460afbb530b689594232208bad8 👍


improve accuracy of NOT warning

Current coverage is 81.07% (diff: 100%)

Merging #4583 into master will decrease coverage by <.01%

@@             master      #4583   diff @@
==========================================
  Files          1294       1294
  Lines         44111      44111
  Methods           0          0
  Messages          0          0
  Branches       7014       7014
==========================================
- Hits          35762      35761     -1
+ Misses         5646       5645     -1
- Partials       2703       2705     +2

Powered by Codecov. Last update eab235b...8516d31


Add Azure CosmosDB MongoDB vCore option for agent memory

This is pretty much an exact duplication of the current teachability code, except it uses MongoDB vCore instead of ChromaDB.  Why?  Because ChromaDB stores all its information in memory, so it is not ideal for long conversations or for containers/vms that delete everything on restart.  This allows memories to be stored and recalled via a permanent database rather than an ephemeral one, and it is not stored in memory on the virtual machine so it will not slow down the execution of the agent workflow.
@sonichi @victordibia
Why are these changes needed?
Currently, AutoGen stores memories using ChromaDB.  While easy to use and capable, ChromaDB must store information in memory, which is difficult for low-memory virtual machines like Azure WebApps or FuntionApps (they have around 500mb).  These files allow AutoGen to store memories in an external vector database using Azure CosmosDB for MongoDB vCore and perform vector searches on them.
The code automatically sets up the vector databases and creates vector indexes on them.
Related issue number
Closes Issue #3066
Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[X] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

I like the idea of extending to different vector DBs. Can we do it without code duplication? @thinkall does the current vector DB abstraction allow an extensible design here?

@sonichi thank you for your response.  I would love to do this without any code duplication, but the original memory module has ChromaDB entangled in the code, no abstractions or interfaces at all.  I had to pretty much rewrite everything from scratch.

This PR is against AutoGen 0.2. AutoGen 0.2 has been moved to the 0.2 branch. Please rebase your PR on the 0.2 branch or update it to work with the new AutoGen 0.4 that is now in main.

Hi @tyler-suard-parker - it looks like things have evolved quite a bit since you sent in this valuable contribution. Think about whether you would like to update with @thinkall's suggestions or perhaps engage with us on the new 0.4 codebase. Closing for now and please reopen if you want to revive this work.

@rysweet That is the nicest closing message I have ever received on a pull request.  Thank you!


Update Ironboard for client changes

[ ] version number endpoint
[ ] update download urls
[x] update ironboard with new protocol logic (https://github.com/flatiron-labs/ironboard/commit/45c58d545cc8ef28c7ce8c06e54feafb07c5c30b)

pretty sure this is done? we can reopen or create a separate ticket if there is something outstanding


Language names do not display native translations

The language name drop down should display the native translation for each language.
Dependent on dotnet/runtime#44739

Added workaround for translations with hard-coded names in native languages


Get content after setContent?

I'm trying to evaluate some arbitrary HTML but can't find how to retrieve the resulting html. I have no problem generating an image though. What am I missing?
      ph.createPage(function(page) {
        page.setContent(html, 'http://github.com', function() {
          console.log(page.content);
          page.renderBase64('PNG', function(base64) {
            console.log(base64);
          });
        });
      });

page.content is undefined, but the image from renderBase64 looks as it should. My end goal is to evaluate some javascript and retrieve the resulting HTML.

Just realised that I needed to retrieve it in a callback.
page.get('content', function(html) {
  console.log(html);
});


Update OidcConstants.java

According to :
https://apereo.github.io/cas/6.5.x/authentication/OIDC-Authentication.html

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Text layout: ensure RentedList are returned in case of exceptions

What does the pull request do?
As discussed at https://github.com/AvaloniaUI/Avalonia/pull/10013#issuecomment-1399584795, ensure all RentedList<T> are returned to the pool if exceptions are thrown during text layout, by using finally blocks.
Avoids exceptions in debug mode, especially with some unit tests.

You can test this PR using the following package version. 11.0.999-cibuild0028922-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

You can test this PR using the following package version. 11.0.999-cibuild0028999-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]


SEG-26

What does this PR do?
Added support for user traits specified in snake case.
Are there breaking changes in this PR?
No.
Any background context you want to provide?
Integration doesn't send the user traits if specified in snake case which segment generally allows to do with other integration.
Is there parity with the server-side/android/iOS integration components (if applicable)?
No.
Does this require a new integration setting? If so, please explain how the new setting works
No.
Links to helpful docs and other external resources
NA

Closing this PR as it's merged to upstream.


What are the advantages of using a JIT for several operators ?

Hi,
MKL-DNN is using xbyak to generate the codes for some of the operators (conv, pooling, etc) in every forward pass. I wonder what are the advantages here by doing this.
To get optimal performance by hand coding the implementation in asm ? How much is the gain compare to implementing it by using C++ and SIMD instructions ?  Why does it generate the codes in every run ?
Thanks!

In MKL-DNN we use XByak to implement low level kernels directly in assembly. The same results can be achieved implementing these kernels using C++ intrinsics, however JIT code generation has two advantages. The first is portability. XByak does not require assembler to generate code, does not rely on compiler intrinsics or inline assembly syntax, and generates the same machine code with any compiler. The second is that we can generate low level kernels for specific problem shape and size, resulting in better performance. For instance in convolutions with padding we do not process zeroes reducing the number of operations necessary to compute the convolution. With inline assembly this requires writing multiple variants of the same kernel to cover possible corner cases.
Code generation happens at topology initialization stage. Once primitive is created you can execute it multiple times on different data buffers without code generation.
Hope this helps.
Regards,
Vadim

/cc @naibaf7

/cc @Maratyszcza

@bhack
Yup, LibDNN uses these advantages as well, but for GPUs.

@vpirogov Thanks for your reply. I checked the source codes again, yes, the codes was generated in the kernel construction time.
Since mkl-dnn is using Xbyak, the portability is very limited.
Do you have any benchmark comparing mkl-dnn with caffe, mxnet ? How much faster is it ?
Thanks!

At Intel Labs we have a research project, called LIBXSMM (https://github.com/hfp/libxsmm), which also relies on runtime code generation at a higher level than Xbyak. LIBXSMM is used in Baidu's DeepBench suite (https://github.com/baidu-research/DeepBench, https://software.intel.com/en-us/articles/intel-xeon-phi-delivers-competitive-performance-for-deep-learning-and-getting-better-fast) for non-square convolutions (but could be used for squared as well). Under samples/dnn we have a couple of scripts for benchmarking layer performance.

@alheinecke I have star-ed libxsmm for long time, didn't know that it also has these dnn kernels implemented. I will give it a check. Thanks very much!

@blackball Could you please elaborate on the statement that using XByak limits portability?
MKL-DNN is not a framework, it's a framework acceleration library. So you can't make comparison of MKL-DNN vs Caffe or MXNet. Currently MKL-DNN is integrated into Intel's fork of Caffe and provides significant acceleration to CPU code path in comparison with BVLC Caffe.

@vpirogov Some of the Intel contributed GPU kernels are merged in the @naibaf7 official Caffe Opencl branch. Will mkl-dnn add GPU device type in engine?

/cc @gongzg

@vpirogov for instance, XByak lacks support for ARM platform which is widely used in consumer devices.
The reason why I asked for comparison with other libs is mkl-dnn has the full functionality to construct a full convolutional network as it shows in examples/simple_net.cpp.

@blackball Thanks for clarification. XByak-optimized kernels are dispatched only for supported architectures. The rest will run reference implementation and it's possible to implement ARM-specific code path. In any case low level optimizations will not be portable between incompatible architectures.

@bhack Adding support for Intel HD Graphics via OpenCL is one of the directions we are investigating.

@vpirogov @blackball There was an old ARM rip-off Xbyak at https://github.com/wanabe/xtaak

@bhack Thanks!


Health data is no longer visible after device deasignation

After I removed the device assignation from a patient, as a doctor I am unable to see the  health data.

fixed in #526


[BUG] (1.14.4) Server Crashed.

What happened?

Modpack Limitless Server for some reason crashed, randomly.

What should happen?

No crash I suppose.

Steps to reproduce

Start server.
Have it open for awhile
Crash.

Versions

Mod Version: 1.1.5
MC: 1.14.4
Forge: 28.1.107

Crash report

https://gist.github.com/Gbergz/3186fa85994ea40e71908b6491c37ae0

Additional info

Actually no idea if this has to do with the mod or not. Reporting to just to be safe.

This is an lag problem.
ServerHangWatchdog detected that a single server tick took 60.00 seconds (should be max 0.05)

So it's a lag problem, no mods actual fault? Because i've been getting this alot and it's been calling out "false crashreports" on mods wildly.

Maybe it is an mod, maybe not. You can try deleting entities using this python script
https://github.com/Fenixin/Minecraft-Region-Fixer
(Don't know what parameters right now)

Just writing here now because got another "crash" https://gist.github.com/Gbergz/3753c9c9d85f473cf06a96cd50440843
probably not your mod but i really want to report it anyways. Have a look at it.

🤔 looks like this happened while stopping the server. I think it can simply be ignored because it simply attempted to get an value from the world while it was already unloaded


feat: use spotify's metadata for the track object

Now it will return Spotify URLs, titles, and artists name.

thanks!


fix: https.get would make a http request

closes #6

cc @jhiesey who is interested in this too

Published as 1.0.0.


Is there an unminified version? "eval" should not be used.

Is there an unminified version? "eval" should not be used.
It should be a direct zuck.js and I can start it as new Zuck and not "eval".

The dist/ scripts are generated by webpack. If you don't want this version you should use src/ version and compile with your own tools


minishift CI - dumping logs does not work

The "kubectl logs -l name=benchmark-operator ..." in error() subroutine in tests/common.sh does not work in minishift.
[bengland@bene-laptop ripsaw]$ kubectl -n my-ripsaw logs --tail=40 -l name=benchmark-operator -c benchmark-operator
error: expected 'logs (POD | TYPE/NAME) [CONTAINER_NAME]'.
POD or TYPE/NAME is a required argument for the logs command
See 'kubectl logs -h' for help and examples.

[bengland@bene-laptop ripsaw]$ oc version
oc v3.11.0+0cbc58b
kubernetes v1.11.0+d4cacc0
features: Basic-Auth GSSAPI Kerberos SPNEGO

Server https://<IP_ADDRESS>:8443
kubernetes v1.11.0+d4cacc0

If we're going to continue using minishift for CI (do we have to?), we have to either use lowest-common-denominator features or special-case minishift.

I just ran this on the minishift CI environment and it worked for me:
[root@porthos ripsaw]# kubectl get pods -n my-ripsaw
NAME                                  READY   STATUS    RESTARTS   AGE
benchmark-operator-5b45cd5b76-rpv87   3/3     Running   0          42s
[root@porthos ripsaw]# kubectl -n my-ripsaw logs --tail=40 -l name=benchmark-operator -c benchmark-operator
{"level":"info","ts":1569960302.3184342,"logger":"cmd","msg":"Go Version: go1.12.5"}
{"level":"info","ts":1569960302.3186076,"logger":"cmd","msg":"Go OS/Arch: linux/amd64"}
{"level":"info","ts":1569960302.3186367,"logger":"cmd","msg":"Version of operator-sdk: v0.8.1"}
{"level":"info","ts":1569960302.3187146,"logger":"cmd","msg":"Watching namespace.","Namespace":"my-ripsaw"}
{"level":"info","ts":1569960302.4359102,"logger":"leader","msg":"Trying to become the leader."}
{"level":"info","ts":1569960302.5256808,"logger":"leader","msg":"No pre-existing lock was found."}
{"level":"info","ts":1569960302.5333478,"logger":"leader","msg":"Became the leader."}
{"level":"info","ts":1569960302.6351092,"logger":"metrics","msg":"Metrics Service object created","Service.Name":"benchmark-operator","Service.Namespace":"my-ripsaw"}
{"level":"info","ts":1569960302.637106,"logger":"proxy","msg":"Starting to serve","Address":"<IP_ADDRESS>:8888"}
{"level":"info","ts":1569960302.6377394,"logger":"ansible-controller","msg":"Watching resource","Options.Group":"ripsaw.cloudbulldozer.io","Options.Version":"v1alpha1","Options.Kind":"Benchmark"}
{"level":"info","ts":1569960302.6380959,"logger":"kubebuilder.controller","msg":"Starting EventSource","controller":"benchmark-controller","source":"kind source: ripsaw.cloudbulldozer.io/v1alpha1, Kind=Benchmark"}
{"level":"info","ts":1569960302.7387812,"logger":"kubebuilder.controller","msg":"Starting Controller","controller":"benchmark-controller"}
{"level":"info","ts":1569960302.8391335,"logger":"kubebuilder.controller","msg":"Starting workers","controller":"benchmark-controller","worker count":1}
[root@porthos ripsaw]#

@bengland2 when you ran this was the operator running at the time?

@bengland2 @dry923 we no longer use minishift CI environment, so can we close this ? or is this an issue that's applicable to other issues as well?

yes as far as I'm concerned.

No I meant you can close it.  BTW my minikube client kubectl is v0.16

ooh okay cool sorry for confusion, thanks @bengland2


Fix: IE11 does not support getRootNode

IE11 does not support getRootNode.
When parent.contains(child) is false, IE11 raises Unable to get property 'toString' error.
This PR adds a check that rootNode is not undefined.
https://developer.mozilla.org/en-US/docs/Web/API/Node/getRootNode

I checked and it fixes #1159

thanks!


hugolib: Add disableKinds option

This PR adds a new flag or configuration options that takes a slice of pageKind's that will not be generated or part of any page collection.

One note: I have tested this locally, so I'm pretty confident that it works -- just wanted a second opinion opinion on names and similar.


⚒[Fix]: added rated books side by side

Description

In Rated books page added books side by side
Also formatted the code.

Affected Dependencies
How has this been tested?
GIF Before

If any UI Changes, Use this to record or else specify NA

GIF After
Checklist

[x] I have followed the Contribution Guidelines.
[x] My changes do not edit/add any unrequired files.
[x] My changes are covered by tests.

New merge caused conflicts 👀

Not getting why this happend.

Try pushing to this branch again

The changes done from this branch are already merged in master.

I will close this.


[tests-only][full-ci]Throw proper ocis-wrapper connection error message

Description
This PR adds test code to throw better error messages when ocis-wrapper is not reachable during the test run.
Now the error will be thrown like this

Related Issue

Fixes https://github.com/owncloud/ocis/issues/6315

How Has This Been Tested?

Locally

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[x] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[x] Acceptance tests added
[ ] Documentation ticket raised:

Reminder to backport this in stable as well


Swift 3 compatibility

Hey, I'd love to see this lib available in Swift 3 so I can implement it in my project.
Thanks 😄

Hi @lfarah ,thanks for your interest. Will work on it this weekend.


Completed the judgment of a custom function, and kinds of return values

Coverage decreased (-0.5%) to 37.984% when pulling 52b7ff5335694aeda86e72a8a3de9d667797ee35 on BlBana:master into a3a8e8dbca467a1913a00b58cca5649dbe4149bd on wufeifei:master.


Flash main.bin without OTA

Hello Achim,
Flashing main.bin using OTA works fine, and the device works as expected. Excellent!
But OTA flashing needs quite some time, and does not work without an internet connection. So I would like to flash main.bin directly with esptool.
I erased the ESP, downloaded main.bin from Releases and flashed to the ESP using:
./esptool -p /dev/cu.wchusbserial14510 --baud 115200 write_flash -fs 1MB -fm dout -ff 40m 0x0 rboot.bin 0x1000 blank_config.bin 0x2000 main.bin

Uploading works OK, but when resetting, the LCM.... Access Point the led on the ESP blinks every second, but the LCM Access Point does not appear.
This is the log, the Esp keeps rebooting
even.txt
BTW : The Ravencore code used LCM too and can be installed with and without OTA (Ref. https://github.com/RavenSystem/esp-homekit-devices/wiki/Installation).
Both methods work OK for me, so I expected no trouble using the same procedure with your main.bin.
Can you see what goes wrong with my esptool command?

@gerardwr
Firts do a full erase:
esptool.py erase_flash
The Error:
ets Jan 8 2013,rst cause:2, boot mode:(3,7)
The reason for this problem is that the current of the power supply is insufficient.
Solution：At least 3.3V 300mA of power supply.
Also Placing a Cap will help your power issues.
furthermore the command is:
esptool.py -p /dev/cu.usbserial-A50285BI --baud 115200 write_flash -fs 1MB -fm dout -ff 40m 0x0 rboot.bin 0x1000 blank_config.bin 0x2000 otaboot.bin
So remove the Dot at te beginning.

Thanks for your prompt reaction, is appreciated.
Hmmm, that's not it :-(
The ESP is erased.
I flash to an WemosD1Mini directly connected to my Mac. Also powering from a PowerBank after flashing does not solve the issue. Have been using the Wemos for years without any trouble so I think power is not the issue here.
After boot the ESP..... is reported in the AccessPoint list of my Mac, but the LCM.... is not.

Considering the DOT, I use the esptool executable in my working directory, so ./esptool refers to that.
Any other suggestions, maybe?

Addition to my message above:
Uploaded just now the Ravencore main.bin with the same esptool command, and to the same WemosD1Mini and there is no issue there. Works as expected.
So the issue seems be somewhere in flashing the main.bin

@gerardwr
It works the same way as the Ravencore system.
Installation without OTA
Download my main.bin from my git here, You also need rboot.bin and blank_config.bin.
Then, continue with Installation, replacing otaboot.bin with main.bin
esptool.py -p /dev/<your_ESPPort> --baud 115200 write_flash -fs 1MB -fm dout -ff 40m \
0x0 rboot.bin 0x1000 blank_config.bin 0x2000 main.bin

It's posible when using LCM you need to restart you deve twice before seeing the LCM-XXXX accespoint. I already placed the issue with @HomeACcessoryKid

UPDATE
Started all over again, it's working now ;-)
Must have made some error myself while gathering the required files :-(
This works for me:

download this repo
download rboot.bin from https://github.com/AchimPieters/ESP8266-HomeKit-Button/blob/master/rboot.bin
download blank_config.bin from https://github.com/AchimPieters/ESP8266-HomeKit-Button/blob/master/blank_config.bin
download main.bin from https://github.com/AchimPieters/ESP8266-HomeKit-Motion-Sensor/releases/download/0.0.2/main.bin
erase ESP8266 flash

esptool.py erase_flash

flash the 3 firmware files

./esptool -p /dev/cu.wchusbserial14510 --baud 115200 write_flash -fs 4MB -fm dout -ff 40m 0x0 rboot.bin 0x1000 blank_config.bin 0x2000 main.bin

after reset the WiFi AP "Motion....." appears:

After that selecting SSID and entering password you can JOIN.
The advantage for me using this procedure is:

it's fast, main.bin is now flashed in 30 seconds, OTA downloading of main.bin takes many minutes
after downloading of the files, no internet required anymore

@AchimPieters
Thanks for sharing, and your support.

@gerardwr
Followed your szepbystep instruction managed to flash the motion sensor. When adding, Incorrect setup code was reported. :( Used 44245376 and 55898144, both found in AchimPieter's files. Any advise?

@gerardwr Followed your stepbystep instruction managed to flash the motion sensor. When adding, Incorrect setup code was reported. :( Used 44245376 and 55898144, both found in AchimPieter's files. Any advise?

Same issue here, serial monitor shows the following:

@gerardwr Followed your stepbystep instruction managed to flash the motion sensor. When adding, Incorrect setup code was reported. :( Used 44245376 and 55898144, both found in AchimPieter's files. Any advise?

Same issue here, serial monitor shows the following:

I was able to add the Detector using this QRcode:

Where this QRCode is coming from????
On Tue, Nov 9, 2021 at 6:09 PM KiLLuuuhh @.***> wrote:

@gerardwr https://github.com/gerardwr Followed your stepbystep
instruction managed to flash the motion sensor. When adding, Incorrect
setup code was reported. :( Used 44245376 and 55898144, both found in
AchimPieter's files. Any advise?
Same issue here, serial monitor shows the following:
[image: image]
https://user-images.githubusercontent.com/74672908/140970090-6debdc0f-c17c-44b5-a7a2-82a65543d229.png
I was able to add the Detector using this QRcode:
[image: qrcode]
https://user-images.githubusercontent.com/74672908/140971338-b8287346-0682-47f0-a387-f6a62fb7f6bc.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/AchimPieters/ESP8266-HomeKit-Motion-Sensor/issues/2#issuecomment-964354641,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AODDF4LVIOF5MDUHKQDMNG3ULFIURANCNFSM4I5BZXOQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Where this QRCode is coming from????
…
On Tue, Nov 9, 2021 at 6:09 PM KiLLuuuhh @.***> wrote: @gerardwr https://github.com/gerardwr Followed your stepbystep instruction managed to flash the motion sensor. When adding, Incorrect setup code was reported. :( Used 44245376 and 55898144, both found in AchimPieter's files. Any advise? Same issue here, serial monitor shows the following: [image: image] https://user-images.githubusercontent.com/74672908/140970090-6debdc0f-c17c-44b5-a7a2-82a65543d229.png I was able to add the Detector using this QRcode: [image: qrcode] https://user-images.githubusercontent.com/74672908/140971338-b8287346-0682-47f0-a387-f6a62fb7f6bc.png — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AODDF4LVIOF5MDUHKQDMNG3ULFIURANCNFSM4I5BZXOQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

The .bin file provided by @gerardwr pointed to another release. I downloaded the source folder and extracted the QRCode.


Off by one error when reading chunks

Addresses:
rlmcpherson/s3gof3r#55

Good find, thanks for the fix! Looks like the OBOE was introduced by the slicePool changes.


Added canScrollVertically, canScrollHorizontally

After overriding methods from API 14 zoomed in ImageViewTouch can be panned in ViewPager and ViewPager can be switched after reaaching Images edge.

Is it possible to merge this PR?

It appears that this project is abandoned. A few issues unanswered, a few PRs unanswered...


Added clean data command

Added command to clear data via command line. I am using this plugin often to clean up my setups where I migrate data into the shop. As I primarily work from the command line the cleanup is the only time I use the administration. This pull request shall fix the lack of a cleanup command.
I am willing to add a completion feature if https://github.com/shopware/shopware/pull/1488 is merged.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/PT-9478
Please use this issue to track the state of your pull request.

hey @JoshuaBehrens
Sorry for the late answer!
The corresponding ticket was closed. If this change is still relevant for you, please feel free to create a new PR.


-bash: rbenv: command not found

I'm running Mac 10.9 with Xcode 5.0.1 Command Line Tools installed. I'm trying to follow rbenv's "Installation" steps under "Basic GitHub Checkout":
git clone https://github.com/sstephenson/rbenv.git ~/.rbenv
echo 'export PATH="$HOME/.rbenv/bin:$PATH"' >> ~/.bash_profile
echo 'eval "$(rbenv init -)"' >> ~/.bash_profile
...I restart Terminal and receive this error:
-bash: rbenv: command not found
My .bash_profile previously contained these paths for node/npm and git:

export PATH="/usr/local/bin:/usr/local/git/bin:$PATH"

...after following the steps above my .bash_profile now looks like this:

export PATH="/usr/local/bin:/usr/local/git/bin:$HOME/.rbenv/bin:$PATH"
eval "$(rbenv init -)"

Here are my troubleshooting answers:
which rbenv
(no response)
...and:
echo $PATH | grep --color=auto "$(rbenv root)/shims"
-bash: rbenv: command not found
Any ideas as to what I need to edit in my .bash_profile to get rbenv working?

Restart your shell
exec -l $SHELL

@alishahpakneeds that command you shared solved a similar issue for me, thank you.

@alishahpakneeds that command you shared solved my problem to install ruby, thank you.

@aliabbas-2012 Solved the problem here!

Resolved removing ~Rbenv validation from /.bash_profile

You can run the command by setting its path
RUN PATH="$HOME/.rbenv/bin:$PATH" rbenv install ${RUBY_VERSION}


ImportError: cannot import name 'ws_received_send_signal_task

Hi,
Getting error  ImportError: cannot import name 'ws_received_send_signal_task when importing anything from this package.
Any suggestions, to fix this are appreciated, Thanking in advance.

Here are steps I took

Created virtual env., activated it

$ cd ~/Python_environments
$ python -m venv universal-notifications-test
$ source ~/Python_environments/universal-notifications-test/bin/activate

Created Django project

(universal-notifications-test)$ cd ~/Python_projects
(universal-notifications-test)$ pip3 install Django==2.2.7
(universal-notifications-test)$ pip3 install universal_notifications
(universal-notifications-test)$ pip3 install mysqlclient
(universal-notifications-test)$ django-admin startproject universalNotificationsTest
(universal-notifications-test)$ cd universalNotificationsTest

Edited universalNotificationsTest/settings.py to use mysql DB

# Database
# https://docs.djangoproject.com/en/2.2/ref/settings/#databases
DATABASES = {
    'default': {
        'ENGINE': 'django.db.backends.mysql',
        'NAME': 'db_name',
        'USER': 'db_user',
        'PASSWORD': 'db_pwd',
        'HOST': '<IP_ADDRESS>',
        'PORT': '',
    }
}

Ran migrations

(universal-notifications-test)$ python manage.py migrate
(universal-notifications-test)$ python manage.py runserver

Stopped server, add new blog app

(universal-notifications-test)$ python manage.py startapp blog

Edited universalNotificationsTest/settings.py to add django.contrib.sites, blog, universal_notifications apps

INSTALLED_APPS = [
    'django.contrib.admin',
    'django.contrib.auth',
    'django.contrib.contenttypes',
    'django.contrib.sessions',
    'django.contrib.messages',
    'django.contrib.staticfiles',
    'django.contrib.sites', # ++
    'blog', # ++
    'universal_notifications' # ++
]

Edited blog/models.py as

from django.db import models

class Blog(models.Model):
    published = models.BooleanField(default=True)
    title     = models.CharField(max_length=50)
    content   = models.TextField(null=True, default='')

    class Meta:
        db_table = "blogs"

    def to_dict(self):
        return {
            'id': self.id,
            'published': self.published,
            'title': self.title,
        }

Made migrations, and migrated

(universal-notifications-test)$ python manage.py makemigrations
(universal-notifications-test)$ python manage.py migrate

Now when I try to import something from universal_notifications, it shows errors as
9.1 Edited blog/models.py as

from django.db import models
from universal_notifications.notifications import EmailNotification

class Blog(models.Model):
    published = models.BooleanField(default=True)
    title     = models.CharField(max_length=50)
    content   = models.TextField(null=True, default='')

    class Meta:
        db_table = "blogs"

    def to_dict(self):
        return {
            'id': self.id,
            'published': self.published,
            'title': self.title,
        }

9.2 Error shown as
Watching for file changes with StatReloader
Exception in thread django-main-thread:
Traceback (most recent call last):
  File "/usr/lib/python3.6/threading.py", line 916, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.6/threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "~/Python_environments/universal-notifications-test/lib/python3.6/site-packages/django/utils/autoreload.py", line 53, in wrapper
    fn(*args, **kwargs)
  File "~/Python_environments/universal-notifications-test/lib/python3.6/site-packages/django/core/management/commands/runserver.py", line 109, in inner_run
    autoreload.raise_last_exception()
  File "~/Python_environments/universal-notifications-test/lib/python3.6/site-packages/django/utils/autoreload.py", line 76, in raise_last_exception
    raise _exception[1]
  File "~/Python_environments/universal-notifications-test/lib/python3.6/site-packages/django/core/management/__init__.py", line 357, in execute
    autoreload.check_errors(django.setup)()
  File "~/Python_environments/universal-notifications-test/lib/python3.6/site-packages/django/utils/autoreload.py", line 53, in wrapper
    fn(*args, **kwargs)
  File "~/Python_environments/universal-notifications-test/lib/python3.6/site-packages/django/__init__.py", line 24, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "~/Python_environments/universal-notifications-test/lib/python3.6/site-packages/django/apps/registry.py", line 114, in populate
    app_config.import_models()
  File "~/Python_environments/universal-notifications-test/lib/python3.6/site-packages/django/apps/config.py", line 211, in import_models
    self.models_module = import_module(models_module_name)
  File "/usr/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "~/Python_projects/universalNotificationsTest/blog/models.py", line 2, in <module>
    from universal_notifications.notifications import EmailNotification
  File "~/Python_environments/universal-notifications-test/lib/python3.6/site-packages/universal_notifications/notifications.py", line 35, in <module>
    from universal_notifications.backends.websockets import publish
  File "~/Python_environments/universal-notifications-test/lib/python3.6/site-packages/universal_notifications/backends/websockets.py", line 6, in <module>
    from universal_notifications.tasks import ws_received_send_signal_task
ImportError: cannot import name 'ws_received_send_signal_task'

Not sure it will help, but the install command on documentation main page is with a dash

pip install universal-notifications

instead of what I seem to notice in your issue (underscore)

pip install universal_notifications


parse containerid for a pid from cgroup as a hex chain

address https://github.com/grafana/beyla/issues/588

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.esara seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0da32eb) 79.85% compared to head (a0224ec) 69.14%.

Files
Patch %
Lines

pkg/internal/helpers/container/container.go
50.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #589       +/-   ##
===========================================
- Coverage   79.85%   69.14%   -10.72%
===========================================
  Files          70       67        -3
  Lines        5917     5801      -116
===========================================
- Hits         4725     4011      -714
- Misses        971     1506      +535
- Partials      221      284       +63

Flag
Coverage Δ

integration-test
69.14% <50.00%> (-0.32%)
:arrow_down:

unittests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@mariomac I updated the unit tests while also allowing it to work with the previous regex (for docker) and then check for k8s cgroups before bailing out
this is working with both my EKS and GKE clusters, but I would really to make it work for [@Krisztian Fekete] as well, before considering to merge it

How about searching for the last hex block (that might also have additional characters after it, which is always (?) scope) in the string?

my original change was something like
-var dockerCgroup = regexp.MustCompile(`^\d+:.*:.*/docker.*-([\da-fA-F]+)\.scope`)
+var dockerCgroup = regexp.MustCompile(`([0-9a-f]{64})`)

but that failed a few of the unit tests originally, so we decided to keep it compatible with the previous unit tests examples
even though, I think they are no longer valid if running in k8s, they would all pass now and the current change works with a few real examples I included in the unit tests from various container runtime configurations

I think they are no longer valid if running in k8s, they would all pass now and the current change works with a few real examples I included in the unit tests from various container runtime configurations

If the tests are not valid, I think we should adjust them :). Do you perhaps have an example of IDs in k8s that you can share please?

I think they are no longer valid if running in k8s, they would all pass now and the current change works with a few real examples I included in the unit tests from various container runtime configurations

If the tests are not valid, I think we should adjust them :). Do you perhaps have an example of IDs in k8s that you can share please?

hi, I updated all the tests and included the examples both as comments in the code and in the unit tests


Select HTML tag including inner HTML | FEATURE REQUEST

I would love to have a feature where you select a tag, enter a Keyboard Shortcut and the whole HTML element with it's children is selected. Would make for easy HTML element repositioning (especially large elements) in the document.

Already included, Emmet does this via Emmet: Balance (inward) and Emmet: Balance (outward).
See this answer on Stackoverflow for a complete keybinding setup combined with the Expand Select and Shrink Select (those two do basically the same for selecting inside strings, braces, etc.)

Wow! Thanks @kaiwood, I didn't know that!


Internal functional interface in Kotlin format in an uncompilable way

If you're just submitting a feature request or question, no need for the above.
When I'm using an internal functional interface, the formatting puts the fun keyword in front of the internal keyword causing the code to be un-compileable.
For example, the following class:
internal fun interface DragonSlayingStrategy {
    fun execute()
}

Will end up as follows after running spotless:
fun internal interface DragonSlayingStrategy {
    fun execute()
}

The above code using Spotless Gradle plugin (version 6.22.0) with this configuration:
spotless {
        kotlin {
            target(
                fileTree("${project.rootDir}/$name") {
                    include("**/*.kt")
                },
            )
            diktat("1.2.3").configFile("${rootProject.rootDir}/config/diktat/diktat-analysis.yml")
        }
    }

Here you can see the output log of the issue:
 @@ -3,6 +3,6 @@
/**
·*·Strategy·interface.
·*/
-internal·fun·interface·DragonSlayingStrategy·{
+fun·internal·interface·DragonSlayingStrategy·{
····fun·execute()
}

The issue was reported to Spotless and pin-point to dektat as can be seen in this Issue: https://github.com/diffplug/spotless/issues/1865
A code example that reproduces the issue can be found here: https://github.com/yonatankarp/spotless-bug-example
Please note that the issue still happens even when all costume configs are disabled.

@yonatankarp thanks for reporting the issue. We will look on it

This problem was solved in diktat-1.2.5. Please, move to diktat-2.0.0. However, if you need spotless, then move to diktat-1.2.5.

Thanks @diphtongue ! Seems to solve the problem 🙏
I'm closing the issue


Create Gitlab::Pipeline.pipeline_test_report

This method fetches the test report for a pipeline available
through the Unit test report feature.

Thank you ❤


[DOC] Add a reference for MERLIN anomaly detector

Describe the issue linked to the documentation
we recently added the MERLIN anomaly detection algorithm but there is no reference to the original paper
https://ieeexplore.ieee.org/document/9338376
need to add this to the docstrings
Suggest a potential alternative/fix
No response

fixed by
https://github.com/aeon-toolkit/aeon/pull/1707


README is backwards

After using serde for a while, I'm now pretty sure that the README is backwards. It has:

How to use serdes convenience features for nightly
How to use them in a hacky way on stable
How does serde work?

The correct order should be:

How does serde work?
How to use serdes convenience features for nightly
How to use them on stable if you absolutely must

Currently, the README is very confusing for people that are not deep into the language and don't know about feature flags and the difference between nightly and stable, but would be okay with some boilerplate. It also makes the impression that the framework is not fully usable on stable.

That's a great point! I'll shuffle the order.

I agree. It's great once you get the hang of it - but I struggled.
My example was I had  an object like
Result<T, Err> where T: serde::Serialize

and I wanted it to become
{"success": true, "data": "test"}

for example if the result was Ok(String::from("test")).
An example like this would be great - I can paste it here if you think it would be helpful

I think the build system emphasis should be reversed from skade@'s suggestion. Behind the scenes stable+syntex is hacky, however the user-facing surface area only has a few minor warts. Since Rust users in general are encouraged to stick with Rust stable, and since serde's stable integration is pretty workable, I think the docs should read like, "Here's the one true way to do it (stable+syntex). And oh, by the way check out the appendix for ways to smooth it over in nightly."
The dithering between stable and nightly in the getting started docs adds a needless layer of complication for newcomers. It'd be nice to smooth that over and give new users one less choice to think about.
I'd volunteer for an update pass on the docs and starter examples if this approach gained consensus.

(stable+syntex)

I'm not sure having this is the one true way. I avoid syntex for that use and really don't like serdes serialization macros.

Erick addressed the order in #428. Please reopen if you know a better order.


[Bug]: sbb-autocomplete does not stop keyboard event on pressing enter

Preflight Checklist

[X] I have read the Contributing Guidelines for this project.
[X] I agree to follow the Code of Conduct that this project adheres to.
[X] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Bug type
Functionality
It affects the following packages
Components
Which version of Lyne Components are you using
No response
Operating system
No response
Browser / Browser version
No response
Input mode
Mouse/Keyboard
Additional settings
No response
What happened?
The propagation/default action of the keyboard event on selecting a auto complete list item using the enter key is not stopped.
Expected behavior should be to stop this event to prevent further form actions.
Steps to reproduce the issue

trigger auto complete drop down by focusing a auto complete input
selecting a item using the arrow keys
select a item using enter

Relevant log output
No response

In the Enter case, we should call event.preventDefault() and add a test.

I have one addition: On selection of an item no change event is triggered. It is possible to fix this issue within this bug?


model downloading

Hi!
Thanks for sharing this awesome work!
One question : where can I download the LLaMA in huggingface format so i can be able to run the commands?
Thanks!

Hi, @AmeenAli we have used the LLaMAs from
https://huggingface.co/decapoda-research


Is there a way to delete/ revoke created certificates from lets encrypt?

We no longer require few certificates and want to delete them but I didn't find any relevant method. Is this supported?

If this is still important to you please open up an issue at the official project: https://git.coolaj86.com/coolaj86/greenlock.js.
I just rewrote the ACME API to support Let's Encrypt v2, so this would be a good time to add that functionality.
If it's important I can add it without too much trouble, but so far it's been needed so rarely (only two mentions) that I simply haven't.


"Upgrade strategy needs to be set" but docs say Optional

I tried to POST to:
curl --user <access>:<secret> -XPOST https://<rancher-host>/v1/projects/<project>/services/<service>/?action=upgrade
and got
{
  "id": "6b889bae-9e71-4e5d-aca1-ce33128d15ec",
  "type": "error",
  "links": {},
  "actions": {},
  "status": 422,
  "code": "MissingRequired",
  "message": null,
  "detail": null,
  "fieldName": "Upgrade strategy needs to be set"
}

Yet the docs at http://docs.rancher.com/rancher/api/api-resources/service/ currently list all parameters as optional. Also worth noting is that I can't seem to find definitions of the parameter types anywhere in the docs: http://docs.rancher.com/rancher/api/api-resources/serviceUpgrade/. I ended up looking at the UI with a debugger to figure out the proper contents + type. Expected was that either parameters are optional or that docs reflect API.
Thanks!

They are mutually-optional.. you need to send one or the other.  There is a page for those fields but they're not linked for some reason:
http://docs.rancher.com/rancher/api/api-resources/inServiceUpgradeStrategy/
http://docs.rancher.com/rancher/api/api-resources/toServiceUpgradeStrategy/
@prachidamle Can you look into why the links aren't generated there (or to any of the types in the above 2 links)

@vincent99 found the bug and added a fix to generate the links needed. PR https://github.com/rancher/go-rancher/pull/53 contains this fix as well.

Fixed the docs based on PR and published it.

Verified that latest docs generation fixes this issue.

@deniseschannon I don't see them in the docs:
http://docs.rancher.com/rancher/api/api-resources/