HAWQ-1258. segment resource manager does not switch back when it cannot resolve standby host name

If use does not configure standby host, segment will not switch to standby server; If segment cannot resolve target server no matter the master server or the standby server, the target server for sending IMAlive heart-beat is switched as well.

@paul-guo- @linwen Please review, thanks!

LGTM

+1

+1


Add default_list in config for new todos

Create todos fastly and easily.
Maybe, if  there is only one list, it should automaticaly considered as the default one.

LGTM, but please jnclude at least one test for this.

Is this enough ?


InvalidServicePrincipalCredentials on tags update (PUT)

Relevant e2e build is here.

There was "coneection reset by peer" on an attempt to refresh token.
I think we need to look into adding retries to avoid transient network failures across our codebase. It's not only about pkg/util/aad.GetToken - It looks like there are other places like this. For example, populateTenantIDFromMSI here:
https://github.com/Azure/ARO-RP/blob/8b52dd6adcf40b33d3aeba8d38fe748c585fe618/pkg/util/instancemetadata/prod.go#L70-L73
It looks like Azure SDK for Go has retry logic implemented here, but we do not use it as far as I can see.

Also:
https://github.com/Azure/ARO-RP/blob/3ff8ae876a36f7237ecc3d2d00ea257f25d23114/pkg/env/dev.go#L49-L51
But I think it's ok not to add retries here and inpkg/util/instancemetadata/prod.go. RP will fail on startup in case of network issue and systemd will restart it + we will notice it.
I do not see any other places where we need retries for tokens. So  #634 should help.


Permission already defined

Hi I've tried to install microG on my Linage (Android 7.1) smarthphone.
fdroid gives me this error if I try to install core:

However if installed extended privileges of fdroid, so maybe this is clashing with microG core, but I'm not sure.

@theScrabi: Is it possible that you have GApps installed?

No, it's a freshly installed linage.

Ok never mind, I had the wrong Unified NLP installed (headpalm).


2.9.2 Unable to find python.exe

when i select the python path, it said: "Unable to find python.exe".
my python path: D:\Python_3_9_12
my email<EMAIL_ADDRESS>

This does not seem to be a spleeter related issue, so I close it.
Feel free to reopen and provide more details if you feel it is.


groupby keyword documentation does not match use capabilities

When I make requests and use the groupby keyword for methods such as:  latest, the groupby keyword is limited to MNET, GACC, and SUBGACC and other key words result in a MesoPyError.
Docs state:
groupby: string, optional
Results can be grouped by key words: state, county, country, cwa, nwszone, mwsfirezone, gacc, subgacc
e.g. groupby='state'
However, behavior is:
latest = meso.latest(stid=','.join(afc), groupby='nwszone')
MesoPyError                               Traceback (most recent call last)
 in ()
----> 1 latest = meso.latest(stid=','.join(afc), groupby='nwszone')
/usr/local/lib/python3.6/site-packages/MesoPy.py in latest(self, **kwargs)
331         kwargs['token'] = self.token
332
--> 333         return self._get_response('stations/latest', kwargs)
334
335     def precip(self, start, end, **kwargs):
/usr/local/lib/python3.6/site-packages/MesoPy.py in _get_response(self, endpoint, request_dict)
160         except urllib.error.URLError:
161             raise MesoPyError(http_error)
--> 162         return self._checkresponse(json.loads(resp.decode('utf-8')))
163
164     def _check_geo_param(self, arg_list):
/usr/local/lib/python3.6/site-packages/MesoPy.py in _checkresponse(response)
119         elif response['SUMMARY']['RESPONSE_CODE'] == -1:
120             format_error = response['SUMMARY']['RESPONSE_MESSAGE']
--> 121             raise MesoPyError(format_error)
122         else:
123             raise MesoPyError(catch_error)
MesoPyError: 'GROUPBY must be either MNET, GACC, or SUBGACC.'
This is true for key words:  state, county, country, cwa, nwszone, and mwsfirezone.  And that last one seems like a typo, should mwsfirezone actually be:  nwsfirezone?

Hi N8geo,
You are correct that our documentation and actual API are inconsistent WRT groupby valid arguments. However, I am afraid the issue is slightly deeper, in that I can't commit that the groupby argument actually changes the API function whatsoever. It probably needs to be deprecated as a whole from the API.
We have started an internal discussion to this end. But at this point the most relevant answer is that the docs are definitely wrong (both in MesoPy and our online resources) and the API error output is correct, it will only allow MNET, GACC and SUBGACC as values (before it does nothing with them)


Tunnel Reminder

So I've been thinking, why does every tunnel require a friendly reminder page? Isn't that up to the creator if they want to take the risk of abusers? An option to bypass it when starting a server would be nice.
Something like this:
const tunnel = await localtunnel({ subdomain: "xyz", port: 8080, bypassTunnelReminder: true });

I have a big project I've been planning to make that uses localtunnel but I can't ever since nobody can get on my site but me.
Thanks for the amazing repository and I hope you understand!

Hey!
Unfortunately for your use-case, where you want to host a big project, i'd recommend you either setup a cheap VPS and hook it up to a domain (super easy and you can get one as cheap as $2.50/mth via vultr or digitalocean i think).... or use ngrok for the time being.
I dislike the tunnel reminder / ip-password gate page as much as everyone else but the abuse is against me by causing my hosting provider's IPs to be flagged as a source of phishing/malware and also causing my loca.lt domain to be flagged by browsers as dangerous. That's why I didn't allow the tunnel creator to bypass the page. Otherwise, the bad guys would just bypass it themselves (by modifying their phishing scripts) and carry on as usual.
The current version of the tunnel reminder page (IP-password protected) is working quite well when it comes to fighting off abusers, i haven't got a single phishing/malware report since implementing it. 🔥
That being said, it's not a permanent solution and I'm still thinking about alternative ways to fight off abuse without having to use a password protected page etc. I might force people to create an account with me in order to have custom subdomains and/or tunnels last longer than like 15min or something. That way I have more data on abusers and can automatically ban them when phishing reports come in.

Ok, thank you very much! I used to use ngrok but the funny thing is I actually like localtunnel better.


plugin has to 'catch up' with the prompt when writing fast

https://github.com/JohnTheGr8/Flow.Plugin.Bang/assets/74494805/e18a85c4-e9ce-4124-9abb-0a3239828d2b

That's normal. It's using debounce I think. Since you don't wanna spam their servers until you're done typing.


master to main for readme and docs

The edit on github link now points to main instead of master

Codecov Report

Merging #486 (4cd0969) into main (e4e1087) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
- Coverage   96.49%   96.48%   -0.02%
==========================================
  Files          35       35
  Lines        1627     1622       -5
==========================================
- Hits         1570     1565       -5
  Misses         57       57

Impacted Files
Coverage Δ

src/Javis.jl
96.86% <0.00%> (-0.07%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4e1087...4cd0969. Read the comment docs.


Add min/max to metrics summary

What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Related issues
A list of issues either fixed, containing architectural discussions, otherwise relevant
for this Pull Request.
Additional Notes
Anything else we should know when reviewing?

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#995  👈
#994
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @GeorgeHahn and the rest of your teammates on  Graphite

Merge activity

Sep 16, 4:10 PM EDT: @GeorgeHahn merged this pull request with Graphite.


Problem in running router example

I am facing the below error when I am trying to run the router example
`Looking for chainloader:
Found /usr/local/includeos/includeos/chainloader Type:  ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), statically linked, stripped
[ WARNING ] Running with sudo
* Initializing Autoconf plugin
[ Autoconf ] Running auto configure
[ Netconf ] Configuring network
[ Netconf ] ! WARNING: Found more configs than there are interfaces
[ Network ] Creating stack for VirtioNet on eth0
[ Inet4 ] Bringing up eth0 on CPU 0
[ Inet4 ] Network configured (52:54:00:12:34:56)
IP: 		<IP_ADDRESS>
Netmask: 	<IP_ADDRESS>
Gateway: 	<IP_ADDRESS>
DNS Server: 	<IP_ADDRESS>
[ Kernel ] Exception thrown when initializing plugin: No IP4 stack found for [1] (missing driver?)
IncludeOS v0.12.0-rc.2-dirty (x86_64 / 64-bit)
+--> Running [ IncludeOS Router Service ]`
[ Routeconf ] Reading route table #0...
	**** PANIC ****
CPU: 0, Reason: terminating with uncaught exception of type net::Stack_not_found: No IP4 stack found for [1] (missing driver?)
Heap is at: 0x4ca000 / 0x7fdffff  (diff=129064959)
Heap usage: 905 / 126945 Kb
[0] 0x0000000000113200 + 0x0fc: panic
[1] 0x000000000019b730 + 0x1ae: default_terminate_handler()
[2] 0x0000000000195c70 + 0x00e: std::__terminate(void ()())
[3] 0x0000000000199200 + 0x02a: __cxxabiv1::failed_throw(__cxxabiv1::__cxa_exception)
[4] 0x00000000001990e0 + 0x0af: __cxa_throw
[5] 0x000000000010f870 + 0x3ed: net::Inetnet::IP4& net::Super_stack::getnet::IP4(int)
[6] 0x00000000002132e0 + 0x31a: net::Routenet::IP4 net::parse_route<rapidjson::GenericValue<rapidjson::UTF8, rapidjson::MemoryPoolAllocatorrapidjson::CrtAllocator > >(rapidjson::GenericValue<rapidjson::UTF8, rapidjson::MemoryPoolAllocatorrapidjson::CrtAllocator > const&)
[7] 0x0000000000212340 + 0x26b: net::load_routing_table_from_cfg(int)
[8] 0x0000000000100170 + 0x04b: Service::start()
[9] 0x00000000001025f0 + 0x236: OS::post_start()
[10] 0x0000000000137a90 + 0x067: kernel_start
[11] 0x0000000000134eb3 + 0x041: long_mode
[ VM_PANIC ] CPU: 0, Reason: terminating with uncaught exception of type net::Stack_not_found: No IP4 stack found for [1] (missing driver?)`
In general, how to run the examples provided. Because for some files README is provided and for some it is not.
Is there any document where some guidelines are provided for developing a new functionality ?

Hi. Are you using master or dev branch? Both works fine for me here. How do you boot your services? Looks like you booted with only one network card. net::Stack_not_found: No IP4 stack found for [1] (missing driver?) (this is a bit misleading tho).
Are you using boot . to run the example? This will look into the vm.json and add 2 network cards.
(Btw, for a big code block, use triple ``` at the start and end)

Thanks it worked. Why are we using name of the service binary to boot for tcp example ?
What's the difference between boot . and boot 'name of service binary' ?

boot . means it looks in the directory . if it is a CMake project, create dir build/, builds and boot the newly built binary in the build/ directory.
boot <path_to_service_binary> will take any IncludeOS binary and boot it (in qemu).
Kinda 😄

Got it.
@AndreasAakesson  Is there any document which provides an example on how to build a functionality from scratch?.
I am going through "readthedocs".
Just wanted to know if there are any other resources.

What kind of functionality do you wanna make? A service? Or some OS functionality?
We don't have much more resources than readthedocs and our tests, examples and source code.

Planning to built a service. Thanks for the response.

We got a gitter channel that you are more than welcome to join and ask questions (or just talk!). About Google Groups - not sure.

Great !!


TypeAdapter for generics with variable key?

Trying to figure out what the type adapter should look like for a JSON response that is of the form shown below (note that varKey1, varKey2 .. are not constant strings i.e. can vary)?
{
  "varKey1": {
    "occupations": [
      {
        "value": "val1",
        "name": "name1"
      },
      {
        "value": "val2",
        "name": "name2"
      }
    ]
  },
  "varKey2": {
    "occupations": [
      {
        "value": "val1",
        "name": "name1"
      },
      {
        "value": "val2",
        "name": "name2"
      }
    ]
  }
}

Thanks for reaching out.  I think this is a perfect question for a question-answer forum like Stack Overflow.
For this case, this could be modeled as a map:
@AutoValue public class Foo {
  public abstract Map<String, Occupations> getOccupations();
}


Adding docker file

Please take a look at https://github.com/openshift/ocm-container/blob/master/Dockerfile for inspiration; it uses 2 step build process and has section on installing oc

Please take a look at https://github.com/openshift/ocm-container/blob/master/Dockerfile for inspiration; it uses 2 step build process and has section on installing oc

Thanks, Tomas, will be making changes as suggested


Add rbx to travis.yml

Need to add rubysl-test-unit as a dependency to make rubinius happy.

Is this still relevant @dgeb @pboling?
If so, please reopen :)


[Filter] - use cases

@oterral
I created a summary of the filter use cases. Sent to your email@swisstopo

Received  thx


BSKT Zone_Asset addition

Description
Adding token: BSKT from chain Solana
See BSKT/USDC Pool 1515
Checklist
Adding Assets
If adding a new asset, please ensure the following:

[x] Asset is registered to the Cosmos Chain Registry.

The description and/or extended_description of the asset in the Chain Registry is informative.

[x] Add asset to bottom of zone_assets.json.

The IBC channel referenced in path must be registered to the Chain Registry.
osmosis_unlisted defaults to true (until the respesentation and transferring of the new asset has been validated)
Note that it is recommended to include an X (fka, Twitter) profile URL with each asset.

On-chain liquidity
For each new asset, please provide the plan for on-chain liquidity of the asset: (choose one)

[x] Ready -- A liquidity pool has been created. The pool ID is: 1515
[ ] Soon -- A pool will be created. (See: Pool Setup Guilde.)

[ ] (optional) A preview of the Osmosis Zone app with the new asset added is requested for creating the pool. (Supercharged Liquidity pools cannot be created via Osmosis Zone app)

[ ] StreamSwap -- The token is, or will be, going through a StreamSwap stream; thus, the token should be listed without requiring on-chain liquidity. A Pool ID will be provided in this PR following the stream's completion once the team has had a chance to create a pool using the earned funds.

There seems to be an issue with the denoms and I'm unable to find BSKT on Portal bridge.

There seems to be an issue with the denoms and I'm unable to find BSKT on Portal bridge.

Hey @JeremyParish69 Really want to work through this and get it fixed up.
What information can I provide that will help resolve?

Hey, thanks for circling back.
For users to be able to transfer tokens, they'll need an interface. I was assuming that you'd arranged with Wormhole to have BSKT added to Portal Bridge, here: https://portalbridge.com/.
After selecting Solana as the Network, I'm not able to find BSKT among the list of tokens.
Are you in contact with Wormhole team in pursuit of getting it added there?
Or how else were you able to transfer tokens (and is that feasible for users to use that method)?

Is this version of Portal Bridge interface, BSKT doesn't show up in the search.

Users would need to be able to select the asset there.

Thanks @JeremyParish69 We've spent the last few months working with the wormhole team to get their connect-widget updated to allow non-native tokens such as bskt to be supported, which is why we have a custom version of it on our website. We can place it in another place on the website, so it's more accessible, even if we want it on it's own page.
Agreed that it should be in a better place. We can get working on this over the next 24 hours and have it in a better position. What else do we need to do, to have BSKT registered correctly as an osmosis asset? Ideally we want to have osmosis pools set up and the token integrated into the current ecosystem, while letting users traverse chains too

That's great! It's already working as preview asset, but I'll need to hardcode the URL to the bridging interface into our frontend. So if there will be a dedicated page on your website with the widget at the top, I'd just ask for the URL to it and we can proceed.


The latest update breaks it for mongoose 4+

Is there a specific version? It does pass the test locally and on Travis with Mongoose 4.

same for me

It has breaking changes from 1.0

Oh right, I should have guessed. The breaking change is the reason why I bumped to 2.0 per semantic versioning.


Add support for RDS instances

Add support to power RDS instances on and off. Use the same tagging approach to identify the instances to control. Add a new boolean flag, --rds, to indicate that RDS instances should also be controlled. If this flag is false, then the app should behave as normal.

@vecknishwaran can you update the doc for RDS?

@chuckleberry49,
This one is done. Let us know if you have any questions.


Error with API

Solved

Please make sure to regenerate your API key as it was exposed and was sent via email to everyone who subscribed to notifications for this project.


Loading into LM Studio - Defaults to Portuguese

If Unsloth 3.2 is pulled into LMStudio the chat defaults ALL responses into Portuguese by default.
Pulling from here: annagoncalves2/unsloth-Llama-3.2-3B-Instruct-bnb-4bit-glosa-gguf
Not sure what's not working right.

I am pretty sure that is a portuguese-trained model.... You want unsloth/Llama-3.2-11B-Vision-Instruct-bnb-4bit


Relicense to dual MIT/Apache-2.0

This pull request was automatically generated because my scripts detected that
everyone in the relicensing issue agreed to
relicensing.
License headers in files were not updated, if they exist. I've reproduced an
example license header below if you want to copy-paste it in. If you don't
have license headers, don't feel compelled to add
them.
// Copyright 2016 energy-monitor-rs Developers
//
// Licensed under the Apache License, Version 2.0, <LICENSE-APACHE or
// http://apache.org/licenses/LICENSE-2.0> or the MIT license <LICENSE-MIT or
// http://opensource.org/licenses/MIT>, at your option. This file may not be
// copied, modified, or distributed except according to those terms.

I recommend publishing a new patch version (the z in x.y.z) so that the
metadata propagates to crates.io.
Please be sure to check the README.md for style. I've try to
review these PRs as they go out, but I might miss something.
Thanks for relicensing!
(For my bookkeeping: this is repository id energy-monitor-rs-8ffa825b-76c8-4045-b4ad-826e0dc1e25f)

Is there a reason the toml file says MIT OR Apache-2.0 for the license instead of MIT/Apache-2.0 like other Rust libraries (e.g. libc)?
Additionally, you've changed the copyright holder in the MIT license from Connor Imes (me) to The energy-monitor-rs Developers.  Is this necessary?
Also, should the copyright year be updated to 2016?

The OR is part of the SPDX standard, whereas the slash is an ad hoc thing cargo does in addition to SPDX expressions.
The change in copyright is not necessary, although might be desirable if there are multiple contributors, I don't know for sure. the year does not need to be updated.  There's an issue on the rust repo where gerv gives some advice about that, but I'm on my phone ATM and can't find it
Sent from my Android device with K-9 Mail. Please excuse my brevity.


Sending ListPlaylistInfoCommand failed: An item with the same key has already been added

First of all, thank you for identifying and fixing the issue in #14 so quickly! I've downloaded the update and it seems the problem was fixed, though there is another issue preventing the display of the playlist contents itself. I seem to be getting a couple different error messages, as below:

The queue is also blank and does not show the contents, though nothing causes a crash this time. The play/volume controls are working as expected and do play what's in the queue despite not showing it. I don't know much about Windows applications and I'm not sure how you obtained the stack trace last time but would you know how I could retrieve and supply useful debugging data from the Store app?

Well, you were lucky that #14 was easy to identify and that I could reproduce it 😁
I got the stack trace from the anonymized Windows telemetry reports, but those are only sent on hard crashes.
The store version is basically impossible to debug most of the time since it's all compiled to native code on submission, sadly.
However, this is an error obtained while parsing results from an MPD command, so in a way it's much easier to debug! 😀
I'm guessing from afar that this is a bug in the way I'm transforming results from the listplaylistinfo command into a list of tracks.
I'd like to have the raw command output from your server so I can see what's wrong:
You can get it using another client library, the python one seems to be the easiest to setup:

I should add some form of Debug view to the app so that one can see the raw MPD requests/responses as they come, but for the time being that's all I got. 😓

I've pushed a fix that should mitigate this problem in the next release.

I've pushed a fix that should mitigate this problem in the next release.


Packaging MacOS & Dave-24 & Dave-19

By error I though that each build must be done on each platform, but the problem was that I was setting wrong params for electron-packager.
Just build and tested this three scenarios: Linux build from linux, Mac build both from linux and MacOs.

Hello @ricardovb! Thanks for updating the PR.

In the file src/main/python/utils/dave_endpoint.py, following                are the PEP8 issues :

Line 13:1: E265 block comment should start with '# '
Line 13:1: E303 too many blank lines (3)
Line 14:1: E302 expected 2 blank lines, found 3
Line 18:38: E211 whitespace before '('
Line 29:36: E251 unexpected spaces around keyword / parameter equals
Line 29:38: E251 unexpected spaces around keyword / parameter equals
Line 34:34: E251 unexpected spaces around keyword / parameter equals
Line 34:36: E251 unexpected spaces around keyword / parameter equals
Line 48:33: E251 unexpected spaces around keyword / parameter equals
Line 48:35: E251 unexpected spaces around keyword / parameter equals

There are no PEP8 issues in the file src/main/python/utils/dave_reader.py !

In the file src/main/python/utils/file_utils.py, following                are the PEP8 issues :

Line 8:20: E211 whitespace before '('
Line 11:1: E302 expected 2 blank lines, found 1
Line 11:18: E211 whitespace before '('
Line 26:14: E211 whitespace before '('

In the file src/test/python/test/utils/test_dave_engine.py, following                are the PEP8 issues :

Line 24:1: E302 expected 2 blank lines, found 1

There are no PEP8 issues in the file src/test/python/test/utils/test_file_utils.py !

Hello @ricardovb! Thanks for updating the PR.

In the file src/main/python/utils/dave_endpoint.py, following                are the PEP8 issues :

Line 26:33: E225 missing whitespace around operator

There are no PEP8 issues in the file src/main/python/utils/dave_reader.py !

There are no PEP8 issues in the file src/main/python/utils/file_utils.py !

In the file src/test/python/test/utils/test_dave_engine.py, following                are the PEP8 issues :

Line 24:1: E302 expected 2 blank lines, found 1

There are no PEP8 issues in the file src/test/python/test/utils/test_file_utils.py !

Hello @ricardovb! Thanks for updating the PR.

There are no PEP8 issues in the file src/main/python/utils/dave_endpoint.py !

There are no PEP8 issues in the file src/main/python/utils/dave_reader.py !

There are no PEP8 issues in the file src/main/python/utils/file_utils.py !

There are no PEP8 issues in the file src/test/python/test/utils/test_dave_engine.py !

There are no PEP8 issues in the file src/test/python/test/utils/test_file_utils.py !

Hello @ricardovb! Thanks for updating the PR.

In the file src/main/python/server.py, following                are the PEP8 issues :

Line 13:6: E211 whitespace before '('
Line 18:6: E211 whitespace before '('
Line 45:37: E251 unexpected spaces around keyword / parameter equals
Line 45:39: E251 unexpected spaces around keyword / parameter equals
Line 47:38: E211 whitespace before '('
Line 48:13: E128 continuation line under-indented for visual indent
Line 51:38: E251 unexpected spaces around keyword / parameter equals
Line 51:40: E251 unexpected spaces around keyword / parameter equals
Line 53:39: E211 whitespace before '('
Line 54:13: E128 continuation line under-indented for visual indent
Line 67:1: E305 expected 2 blank lines after class or function definition, found 1

There are no PEP8 issues in the file src/main/python/utils/dave_endpoint.py !

There are no PEP8 issues in the file src/main/python/utils/dave_reader.py !

There are no PEP8 issues in the file src/main/python/utils/file_utils.py !

There are no PEP8 issues in the file src/test/python/test/utils/test_dave_engine.py !

There are no PEP8 issues in the file src/test/python/test/utils/test_file_utils.py !

Hello @ricardovb! Thanks for updating the PR.

In the file src/main/python/server.py, following                are the PEP8 issues :

Line 44:37: E251 unexpected spaces around keyword / parameter equals
Line 44:39: E251 unexpected spaces around keyword / parameter equals
Line 46:38: E211 whitespace before '('
Line 47:13: E128 continuation line under-indented for visual indent
Line 50:38: E251 unexpected spaces around keyword / parameter equals
Line 50:40: E251 unexpected spaces around keyword / parameter equals
Line 52:39: E211 whitespace before '('
Line 53:13: E128 continuation line under-indented for visual indent
Line 66:1: E305 expected 2 blank lines after class or function definition, found 1

There are no PEP8 issues in the file src/main/python/utils/dave_endpoint.py !

There are no PEP8 issues in the file src/main/python/utils/dave_reader.py !

There are no PEP8 issues in the file src/main/python/utils/file_utils.py !

There are no PEP8 issues in the file src/test/python/test/utils/test_dave_engine.py !

There are no PEP8 issues in the file src/test/python/test/utils/test_file_utils.py !


hotkey: Update deprecation notice for '*' hotkey.

This PR updates the shortcut of the deprecation notice for '*' hotkey. On macOS, it should be 'Cmd + s' instead of 'Ctrl'.

Testing Plan:
GIFs or Screenshots:
macOS -

Windows:

Nice, merged, thanks @akashnimare!  As a follow-up, we might want to extract a function for util.has_mac_keyboard() for this use case, so that we don't have the check copied in a bunch of places.

Oh yes, I think we should add that check.


0.29 window content disappears during resize in High Sierra

Which operating system does the issue occur on? MacOS 10.13.6 High Sierra
Since upgrading Alacritty to 0.29 from Homebrew, all window content disappears during resizes, but the title bar stays visible. See screencast video.

Duplicate of https://github.com/jwilm/alacritty/issues/1471.

Hi, thanks for looking at this - I'm not sure this is the same bug because (a) the edges of the window don't show up in the video I sent, it looks quite different from the one in #1471, and (b) this didn't happen on 0.25 on High Sierra which I've been using for a month+ and which worked perfectly well, so if it is the same issue, it seems like it might be a regression. Also I'm not using a specific branch or commit, just whatever comes out of Homebrew, which seems like it ought to be a 'last known good' or similar :-)

Even if this is not exactly the same issue, I'd be surprised if the cause wouldn't be the same. So I think tracking it in the other issue should be fine and I'd recommend subscribing to that.

OK will do. Thanks.


link_to_add_association: option for some kind of inline partial?

Hello,
first kudos for cocoon, I'm making my way for using it for interacting with OpenERP from Rails. Hopefully will publish about this soon.
So basically I'm using cocoon along with cells. And in this context, I may need nested forms BUT the forms definitions may not be a partial file, they may be inline templates that I transcode automatically (via XSLT) from the OpenERP XML dialect form definitions.
Or said it straight: that would be cool if you could support some kind of inline template definition for the link_to_add_association partial. I think this could be useful in other contexts too. What do you think?

try this one:
.links       = link_to_add_association f, :user_permissions, partial: 'permissions/shared/user_permission_fields', class: 'btn btn-primary' do         %i.fa.fa-fw.fa-database


[Outlook] (calendar props) Sensitivity, all-day event

Docs Build status updates of commit 8d05300:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/objectmodel/preview-requirement-set/office.context.mailbox.item.md
:white_check_mark:Succeeded

docs/reference/objectmodel/preview-requirement-set/outlook-requirement-set-preview.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@danielebercovici Can you take a look? Thanks.

Docs Build status updates of commit b143a91:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/objectmodel/preview-requirement-set/office.context.mailbox.item.md
:white_check_mark:Succeeded

docs/reference/objectmodel/preview-requirement-set/outlook-requirement-set-preview.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


pass drone exec args to drone-exec container

This PR makes it so that drone exec args (such as --cache, --deploy, etc.) are passed to the drone/drone-exec container. Without this, it seems that these args of drone exec are no-ops.

Thanks for hooking those up. It might make sense (as a follow-up pr) to set more of the build attributes [1], without which plugins may not execute. These include:

commit branch (Build.Branch)
commit sha (Build.Commit)
comment event (Build.Event=push, or perhaps configurable)
drone url (System.Link which can come from the DRONE_TOKEN [2])

We may also need a way to provide secrets via the command line. The .drone.sec file likely cannot be decrypted locally since the private key stays private. These could, however, be provided as global variables [3] in which case they would get injected the same way.
[1] https://github.com/drone/drone-cli/blob/71031283a3948e4f726043de453762c8da83b4cb/drone/exec.go#L149
[2] https://github.com/drone/drone-cli/blob/71031283a3948e4f726043de453762c8da83b4cb/drone/handle.go#L17
[3] https://github.com/drone/drone-cli/blob/71031283a3948e4f726043de453762c8da83b4cb/drone/exec.go#L154


TAJO-1530: Display warn message when the query kill button is clicked in Web UI

You can test clicking kill button confirmation during the following command.
tsql -c 'create table t(a int)'
tsql -c 'insert into t select 1'
tsql -c 'select a from t union select sleep(10) from t'

Hi, @babokim . Could you review your issue? The change is just trivial Javascript code.

This patch looks good to me. Here is my +1.
The Travis CI failed but it may be caused by TAJO-1526. This issue is trivial and not related any test case. All tests passed on my laptop. So I'll commit soon.

Thank you, @babokim !  :)


Add alternate type for proto::cosmos::tx::v1beta1::TxRaw that is compatible with ledger.

I could be a little off base here as my understanding of this is pretty shallow at best. Ledgers expect a specific version of "SignDoc" that must have all json objects sorted by key. you can see the spec here. It seems to me that that would requires a different form for Raw, as the current implementation separates "auth_info" and "body". When these are passed to the ledger, they must first be sorted. The sorted version is signed, and then transforming back into Raw causes a jumble, and invalidates the signature. Is my understanding of this problem correct?

Perhaps both body and auth_info will need different implementations as well.

To my knowledge the only format the Ledger supports is Amino JSON, which predates and is orthogonal to Protobufs.
There's no support for Amino in this crate. If there's enough interest we could support Amino JSON, but that's a question for #309

FWIW, I wrote an Amino library a couple years ago, though it was mainly aimed at the binary format:
https://github.com/iqlusioninc/crates/tree/main/stdtx
It does have JSON support, although at this point I couldn't tell you what state it's in.

So the problem I'm having in particular is how to package up the TxRaw after signing. I can properly get the json payload to the ledger and sign it, but I don't know how I can then take the signature that's returned, and bundle it into TxRaw. There's very little documentation around for me to go off of so I'm wandering in the dark a bit haha.

You need to use the LegacyAminoJson sign mode: https://docs.rs/cosmrs/latest/cosmrs/tx/enum.SignMode.html#variant.LegacyAminoJson
I believe the transaction will need to be encoded in the Amino binary wire format (even though the signature is over the JSON).
The easiest way to confirm any of this would be to find a working transaction and use cosmrs to parse it. That should give you an idea of what the inputs to cosmrs need to be.

That's very helpful thank you. I'll look into that right now!

The easiest way to confirm any of this would be to find a working transaction and use cosmrs to parse it. That should give
you an idea of what the inputs to cosmrs need to be.

Could you elaborate on that idea a little more?

Find the Protobuf binary serialization of any working transaction signed by a Ledger and parse that.
We can add it to the test vectors if you'd like.
I can look for one if you want.

I switched to using the legacy amino sign mode but my transactions are still failing the signature verification step.

I believe that's because they need to be serialized using the Amino binary encoding. Are you doing that?

Steps:

Tx info is serialized with serde_json and sent via apdu to the ledger.

{
 "account_number": {number},
 "chain_id": {string},
 "fee": {
   "amount": [{"amount": {number}, "denom": {string}}, ...],
   "gas": {number}
 },
 "memo": {string},
 "msgs": [{arbitrary}],
 "sequence": {number}
}

the data returned and converted to a signature via
Signature::from_der(data.as_slice())

The I build the TxRaw
        let anys = msgs.iter().map(|msg| msg.to_any()).collect::<Result<Vec<_>, _>>().unwrap();
        let tx_body = tx::Body::new(anys, memo.clone(), timeout_height);
                    let signer_info = SignerInfo {
                        public_key: Some(public_key.into()),
                        mode_info:  ModeInfo::Single(Single { mode: SignMode::LegacyAminoJson }),
                        sequence:   account.sequence,
                    };
                    let ledger_auth_info = AuthInfo { signer_infos: vec![signer_info], fee: fee.clone() };
                    let raw = cosmos_sdk_proto::cosmos::tx::v1beta1::TxRaw {
                        body_bytes:      tx_body.into_bytes().unwrap(),
                        auth_info_bytes: ledger_auth_info.into_bytes().unwrap(),
                        signatures:      vec![signed.to_vec()],
                    }

I believe that's because they need to be serialized using the Amino binary encoding. Are you doing that?

at what point in the process are you suggesting it be serialized using the Amino binary encoding?
I'm just using
let tx_commit_response = tx_raw.broadcast_commit(client).await?;

to broadcast

FWIW here's stdtx's Amino JSON builder:
https://github.com/iqlusioninc/crates/blob/0d941bae638dbb25182b69e2bdbc33ded047bc2e/stdtx/src/amino/builder.rs#L73-L106

at what point in the process are you suggesting it be serialized using the Amino binary encoding?

I don't know it's actually doing that. The transaction is hopefully still Protobuf even though it's using Amino JSON for signing.
I'm just guessing here. This is why we need an example transaction which uses SignMode::LegacyAminoJson

This is why we need an example transaction which uses SignMode::LegacyAminoJson

Not exactly sure the easiest way to get something like that. I'm so close to making this work this is literally the last step I'm stuck on ahah.

You won't be able to with stdtx.
It will need to use https://docs.rs/cosmrs/latest/cosmrs/tx/struct.Raw.html#method.broadcast_commit, but you'll have to actually solve this issue before that will work

sounds good to me. Well thanks for your help on this issue! Really appreciate it. If you come up with any other ideas for how to get this to work let me know. This is the repository I'm currently working on for reference.

Following up here! Did some digging and found that tmkms uses your stdtx package to solve exactly this problem. Examples can be found in tx_signer.rs. I'll be using that as an example, and hopefully I can get this all sorted.

@tony-iqlusion you mentioned above that it might be possible to get amino support within cosmrs and I think that's exactly what my use case requires! I'll try and build around that for now, but as a long term goal that would be fantastic.


debian stretch: local repos print error message

Hi, nice job.
On my system I get the following error message output when working in a local (non remote) repository:
fatal: ambiguous argument 'origin/master..': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

The problem stems from an unchecked git diff --stat origin/master in the case where origin has not been set (i.e. no remote exists). I have a pull request ready though and will submit it here in a bit.

this was a good issue.


how to run on my dataset

i can not run the example code on my dataset, anyone can run it well? can you send your code to my mail
<EMAIL_ADDRESS>thanks

what's the format of your data?
you should make the same mask as the example ( CamVid ).


Webpack fails to compile after a second run through tests, the error object that should contain the error only has an empty string

Do you want to request a feature or report a bug?

What is the current behavior?
Currently, whenever I run a my tests (for Angular), the first time around succeeds in running the tests but the second time it encounters some sort of error and fails. The error is:
[../../../../../app recursive \.spec\.ts$] ./app \.spec\.ts$ 160 bytes {main} [built]
[../../../../../app/test.ts] ./app/test.ts 4.66 kB {main}
[../../../../../demo/polyfills.ts] ./demo/polyfills.ts 8.16 kB {polyfills}
[../../../../core-js/es6/parse-float.js] ./node_modules/core-js/es6/parse-float.js 96 bytes {polyfills}
[../../../../core-js/es6/parse-int.js] ./node_modules/core-js/es6/parse-int.js 92 bytes {polyfills}
[../../../../core-js/es6/reflect.js] ./node_modules/core-js/es6/reflect.js 718 bytes {polyfills}
[../../../../zone.js/dist/async-test.js] ./node_modules/zone.js/dist/async-test.js 3.23 kB {vendor}
[../../../../zone.js/dist/fake-async-test.js] ./node_modules/zone.js/dist/fake-async-test.js 17 kB {vendor}
[../../../../zone.js/dist/jasmine-patch.js] ./node_modules/zone.js/dist/jasmine-patch.js 6.36 kB {vendor}
   [0] multi ./demo/polyfills.ts 28 bytes {polyfills}
[../../../../zone.js/dist/long-stack-trace-zone.js] ./node_modules/zone.js/dist/long-stack-trace-zone.js 6.22 kB {vendor}
[../../../../zone.js/dist/proxy.js] ./node_modules/zone.js/dist/proxy.js 5.6 kB {vendor}
[../../../../zone.js/dist/sync-test.js] ./node_modules/zone.js/dist/sync-test.js 1.41 kB {vendor}
<EMAIL_ADDRESS>./node_modules/<EMAIL_ADDRESS>40 kB {vendor}
<EMAIL_ADDRESS>./node_modules/<EMAIL_ADDRESS>3.6 kB {vendor}
    + 298 hidden modules

ERROR in

Nothing more is outputted. I checked to see if for some reason the error wasn't being logged to the console but it turns out that it's just an empty string in this scenario. If I make another change and the tests attempt to run again I get the error:
WARNING in ./app/components/graph-line/graph-line.component.spec.ts
Module build failed: TypeError: Cannot read property 'flags' of undefined
      at resolveAlias (DIR/node_modules/typescript/lib/typescript.js:23972:36)
      at checkAliasSymbol (DIR/node_modules/typescript/lib/typescript.js:42658:26)
      at checkImportBinding (DIR/node_modules/typescript/lib/typescript.js:42688:13)
      at Object.forEach (DIR/node_modules/typescript/lib/typescript.js:1499:30)
      at checkImportDeclaration (DIR/node_modules/typescript/lib/typescript.js:42709:32)
      at checkSourceElement (DIR/node_modules/typescript/lib/typescript.js:43018:28)
      at Object.forEach (DIR/node_modules/typescript/lib/typescript.js:1499:30)
      at checkSourceFileWorker (DIR/node_modules/typescript/lib/typescript.js:43091:20)
      at checkSourceFile (DIR/node_modules/typescript/lib/typescript.js:43071:13)
      at getDiagnosticsWorker (DIR/node_modules/typescript/lib/typescript.js:43135:17)
      at getDiagnostics (DIR/node_modules/typescript/lib/typescript.js:43121:24)
      at Object.getEmitResolver (DIR/node_modules/typescript/lib/typescript.js:23049:13)
      at DIR/node_modules/typescript/lib/typescript.js:70489:69
      at runWithCancellationToken (DIR/node_modules/typescript/lib/typescript.js:70245:24)
      at getDeclarationDiagnosticsForFileNoCache (DIR/node_modules/typescript/lib/typescript.js:70488:20)
      at getAndCacheDiagnostics (DIR/node_modules/typescript/lib/typescript.js:70501:26)
 @ ./app \.spec\.ts$
 @ ./app/test.ts
Firefox 55.0.0 (Mac OS X 10.12.0) ERROR
  Error: Module build failed: TypeError: Cannot read property 'flags' of undefined
      at resolveAlias (DIR/node_modules/typescript/lib/typescript.js:23972:36)
      at checkAliasSymbol (DIR/node_modules/typescript/lib/typescript.js:42658:26)
      at checkImportBinding (DIR/node_modules/typescript/lib/typescript.js:42688:13)
      at Object.forEach (DIR/node_modules/typescript/lib/typescript.js:1499:30)
      at checkImportDeclaration (DIR/node_modules/typescript/lib/typescript.js:42709:32)
      at checkSourceElement (DIR/node_modules/typescript/lib/typescript.js:43018:28)
      at Object.forEach (DIR/node_modules/typescript/lib/typescript.js:1499:30)
      at checkSourceFileWorker (DIR/node_modules/typescript/lib/typescript.js:43091:20)
      at checkSourceFile (DIR/node_modules/typescript/lib/typescript.js:43071:13)
      at getDiagnosticsWorker (DIR/node_modules/typescript/lib/typescript.js:43135:17)
      at getDiagnostics (DIR/node_modules/typescript/lib/typescript.js:43121:24)
      at Object.getEmitResolver (DIR/node_modules/typescript/lib/typescript.js:23049:13)
      at DIR/node_modules/typescript/lib/typescript.js:70489:69
      at runWithCancellationToken (DIR/node_modules/typescript/lib/typescript.js:70245:24)
      at getDeclarationDiagnosticsForFileNoCache (DIR/node_modules/typescript/lib/typescript.js:70488:20)
      at getAndCacheDiagnostics (DIR/node_modules/typescript/lib/typescript.js:70501:26)
  at http://localhost:9876/_karma_webpack_/main.bundle.js line 36 > eval:1

I have researched this as best as I can and have tried whatever suggestions were provided but no luck has come from it. The issue has been getting worse and worse, which is baffling me.
If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?
The expected behavior is that it would output an error to indicate what's wrong or to continue compiling and run the tests. As of right now I cannot determine what the issue is.
If this is a feature request, what is motivation or use case for changing the behavior?
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
npm: 5.0.3 Node: 7.4.0 webpack: 3.4.1 OS: Mac OS Sierra

Could you try --display-error-details?

@sokra I am not able to due to it being run through Angular. But I do believe I made a discovery. This issue seems to happen whenever I am updating .spec.ts files. If I update a regular file, this is what appears during the build:
  0% compiling
 10% building modules 0/1 modules 1 active ...o-waveform-graphing\app /\.spec\.ts$/
 30% building modules 1/2 modules 1 active ...o-waveform-graphing\app /\.spec\.ts$/
 50% building modules 2/3 modules 1 active ...ts\graph-line\graph-line.component.ts
 70% building modules 3/3 modules 0 active
 71% sealing
 75% advanced module optimization
 76% basic chunk optimization pass 2
 76% basic chunk optimization pass 3
 83% module order optimization
 84% module id optimization
 86% chunk order optimization
 87% chunk id optimization
 88% hashing
 90% chunk assets processing
 91% additional chunk assets processing
 92% chunk asset optimization
 94% asset optimization
 95% emitting

But when I update a spec file, this is what it outputs before having an error:
  0% compiling
 10% building modules 0/1 modules 1 active ...o-waveform-graphing\app /\.spec\.ts$/
 30% building modules 1/2 modules 1 active ...o-waveform-graphing\app /\.spec\.ts$/
 70% building modules 3/3 modules 0 active
 71% sealing
 75% advanced module optimization
 76% basic chunk optimization pass 2
 76% basic chunk optimization pass 3
 83% module order optimization
 84% module id optimization
 87% chunk id optimization
 88% hashing
 90% chunk assets processing
 91% additional chunk assets processing
 92% chunk asset optimization
 94% asset optimization
 95% emitting

I can force this to happen by just making a change and saving. If I change it and save it again, the whole application recompiles and the test runs just fine. It seems to be an every other type situation, unless I make changes too quickly in the spec file. Some times if I give it awhile it might work after a change, other times it'll break back-to-back before finally working again. So, maybe there's an issue with it trying to build/find the spec files?
Here's the angular file that pulls it all in, which should look familiar to the output red text:
// This file is required by karma.conf.js and loads recursively all the .spec and framework files

import 'zone.js/dist/long-stack-trace-zone';
import 'zone.js/dist/proxy.js';
import 'zone.js/dist/sync-test';
import 'zone.js/dist/jasmine-patch';
import 'zone.js/dist/async-test';
import 'zone.js/dist/fake-async-test';
import { getTestBed } from '@angular/core/testing';
import {
  BrowserDynamicTestingModule,
  platformBrowserDynamicTesting
} from '@angular/platform-browser-dynamic/testing';

// Unfortunately there's no typing for the `__karma__` variable. Just declare it as any.
declare let __karma__: any;
declare let require: any;

// Prevent Karma from running prematurely.
__karma__.loaded = function () {};

// First, initialize the Angular testing environment.
getTestBed().initTestEnvironment(
  BrowserDynamicTestingModule,
  platformBrowserDynamicTesting()
);
// Then we find all the tests.
const context = require.context('./', true, /\.spec\.ts$/);
// And load the modules.
context.keys().map(context);
// Finally, start Karma to run the tests.
__karma__.start();

Hopefully this provides some more insight into the issue at hand. I'm not sure if it's directly a webpack issue or if there's an error elsewhere that causes webpack to fail. I've tried both including and excluding spec files from building and linting in the hopes of seeing some sort of change, but it hasn't had any effect.

I'm having the same issue, I get: -


improve cpp template (add more event handler)

THIS PROJECT IS IN DEVELOPMENT MODE. Any pull requests should merge to branch dev, otherwise will be rejected immediately.
Describe your changes
improve cpp template (add more event handler)
Issue ticket number and link
Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[x] I have checked readme and add important infos to this PR (if it needed).
[x] I have added/adapted some tests too.

@halx99
Can be merged


[WIP][IGNORE] Update UI dependencies (testing Gladorme branch from PR #1207)

Attempting to revive branch Gladorme:ui/deps-update in PR #1207
Testing whether build is green and CI actions pass w/o the weird ci / build-storybook issues from before
TODO

[ ] Remove numbro from components package (those utils moved to core)
[ ] Manual testing

Notes

nvm install v18.16.0
nvm use
node -v

v18.16.0

Ugh build-storybook is taking 33 minutes and counting so far, not a good sign, maybe we need to upgrade Storybook as part of this PR 🤔

Alright found a related issue with a fix! See: https://github.com/storybookjs/test-runner/issues/301
“this can be resolved by updating the npx wait-on command to npx wait-on tcp:<IP_ADDRESS>:6006 (or whatever the correct address is for the http-server”
I don’t have time to dig further into that to confirm right now but it should help us move forward with these updates

Would love to get ECharts upgraded too in #1332 but running into issues with Jest


[Tour of Beam] [Task] Support templated hints for examples and challenges

What needs to happen?
Hints for ToB challenges need to support templates for different SDKs
Issue Priority
Priority: 3
Component
tour-of-beam

.take-issue


Add option to view default settings in single plain text file

Pretty self explanatory. I don't have anything against the new UI or anything but I don't like that I can no longer see the default settings in a single plain text file.

I'd also like an option to view the user settings as a raw file, (without the little pencils).

@garfieldbanks "workbench.settings.openDefaultSettings": false

@bpasero
That's not quite what I'm looking for. I want to actually see the default settings, but I don't want any dropdowns or anything. Just a raw text file.

Got it 👍

@garfieldbanks Thanks for filing an issue for this. May I know if you do not want edit icon or you also do not like to new Grouping and Search bar in default settings? Also, may I know the reason/use case of why you want to see Default settings old way? This will help us in filling the gaps and finding the right balanced solution.
Thanks

@sandy081
How about a button at the very bottom that opens a new tab with the raw file? Kind of like when you preview something.

@garfieldbanks I can definitely do that or have a command to show the raw file.
But, I am kind of more interested to know why you would like to need it in first place which the current thing is not doing?

Disabling Quick outline/Go to Symbol/Go to line/Find/Folding was done in favour of new rich functionality in Default Settings.

Advanced Search and filtering
Rich Grouping

I would be more interested to know what is missing in new Default settings that is there in Old one and how is it being helpful? So that I can look in bringing the new default settings on par with old one or have an option to show the raw file.
Thanks

Thanks for the new Defaults Settings UI.
With the new integrated search, it's fast to find what we are looking for.
The old UI was useful to get offline documentation of all settings.
Keybindings UI still uses the old UI. For coherence, both defaults settings and keybindings should have a similar UI.

@sandy081
I don't see any way the new UI could be changed or even that it needs to be changed to be on par with the old one. I actually think it's good.
But a button or command to view the raw file would definitely be nice.

@pierredewilde May I know what you mean by offline documentation?

The old UI was useful to get offline documentation of all settings.

@garfieldbanks Definitely, I will provide a command to view default settings as raw file

I mean a documented list of all settings to print. Raw (json) file is OK for that purpose.

Added a new command to open Default settings as raw workbench.action.openRawDefaultSettings


How to use the main address after setting context-path

Hi,
Thanks for reading this.
I am using Nginx + shinyProxy to deploy the website, I have some trouble related to the subpath.
Assuming the main website is www.xxx.com.
I would like to 1) make the shiny deployed as www.xxx.com/shinys/app/XXXX.  2) At the same time, www.xxx.com can be visited for another index.html I have.
Without setting the Nginx, by only setting the "context-path", I managed to make the 1) work. However, the main address  www.xxx.com is unable to be visited.
Shall I give up the setting for "context-path"  but try something else like modifying the Nginx setting? or some setting related to the landing page?
Any suggestions would be appreciated.
Thanks

Yeah, need to set the Nginx . Changing location and proxy_pass to http://<IP_ADDRESS>:8080/shnys/


Move data type macros into dbt-core

Part of resolution for https://github.com/dbt-labs/dbt-utils/issues/598
See also: https://github.com/dbt-labs/dbt-utils/pull/586
Related to https://github.com/dbt-labs/dbt-core/issues/5317, but does not actually resolve that tech debt

Description

Move type_{X} macros from dbt-utils into dbt-core. In almost all cases, these macros are just a sugarier interface for api.Column.translate_type, which leverages built-in type capabilities
Add functional tests for these data types

After some back-and-forth on what the right interface ought to be, we've landed on keeping the existing one. Users can confidently access a "string" type for data type casting, by calling macro named type_string, which returns the correct word for string (text, varchar, etc) on that database
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[x] I have run changie new to create a changelog entry

@dbeatty10 Thanks for the quick review! Next steps:

I'm going to merge this PR
The next step will be to update + merge the PRs in adapter plugin repos
The final step can be to update + merge the PR in dbt-utils
The docs PR can be merged at any point


Iteration4-frontend

Codecov Report

Merging #57 (ea62538) into iteration4 (5367501) will decrease coverage by 0.53%.
The diff coverage is 50.00%.

@@              Coverage Diff               @@
##           iteration4      #57      +/-   ##
==============================================
- Coverage       73.94%   73.41%   -0.54%
==============================================
  Files              18       17       -1
  Lines             426      425       -1
  Branches           21       21
==============================================
- Hits              315      312       -3
- Misses            111      113       +2

Impacted Files
Coverage Δ

WePay/views/__init__.py
100.00% <ø> (ø)

WePay/views/bill.py
44.89% <40.00%> (-1.92%)
:arrow_down:

WePay/views/topic.py
55.00% <100.00%> (+2.36%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

resolve conflict

💯

+1

Good job guys +1

👍

🥇


[Removal]:

Hotspot Name
Gigantic Metal Poodle
Hotspot b58 Address
112HCB2A4z76v4Tvc2gdJptzXbjXkEBNf3v8jW4mw3mTGqWtTzBN
Discord Handle
No response
Hotspot Manufacturer
RAKwireless
Removal Reason
Guys, Seeing is believing. Hotspot is set on balcony. I'm working on network setting after i bought it.  Please review my appeal and let me focus on fixing the network issue.
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information

We have taken into account this removal request in the next iteration of the denylist. It may take some time before it's processed. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.


Long input question

I notice that your work seems ignore the long input by using below codes, I wonder the computation of prec, recall and f1 socre if ignore these too, and just use the short part in test dataset.
 if token_encode_len > token_len + 2:
                continue

Hi, these lines are used for testing other datasets but forgot to remove. As you can see at the line 220 and 233 in run.py, we use the datasets directly from TPLinker, where the text length in train set is not longer than 100. We also calculated that the text length of the test sets would not exceed 150. And the output of  data_processor.py will output the simple statistics.


Hyper-V is not vailable in my Win10 Home. How can i use Vitualbox instead HyperV

I have installed Vagrant and created box with Ubuntu/Trusty64. I am able to see the this ''Ubuntu/Trusty64'' in virtualBox.
Machine status is Aborted and when I double click on it says ''Failed to open a session the virtual machine."
Can I get help resolving this

      I have installed Vagrant and created box with Ubuntu/Trusty64. I am able to see the this ''Ubuntu/Trusty64'' in virtualBox.

Machine status is Aborted and when I double click on it says ''Failed to open a session the virtual machine."
Can I get help resolving this

Issue resolved.


Fixes/reload plugin urls

Makes plugin action urls come from a consistent location
Adds plugin action urls to json response on plugin move

@FinalAngel Please have a look.

LGTM. However, we need a test for this. Can be in a future PR though, let's just not forget.

Is this for 3.2?

Yes, this is a bug-fix.

The real fix will be done by frontend.

This requires editing the documentation here https://github.com/divio/django-cms/blob/develop/docs/reference/plugins.rst#add_url

@yakky how so? no change has been made to those properties. Do you mean to add the get_ methods as public api?

@czpython we probably want to add the frontend fix in here. Let's see if I can do that today quickly. Please keep open

@czpython exactly. We can even deprecate the attributes (which were actually born as properties) and make the new get_ methods official

@czpython I added the JS logic for this. There are some inconsistency problems though. The current urls scheme requires urls to be:
{
    add_plugin: "/en/admin/cms/page/add-plugin/",
    edit_plugin: "/en/admin/cms/page/edit-plugin/76/",
    move_plugin: "/en/admin/cms/page/move-plugin/",
    copy_plugin: "/en/admin/cms/page/copy-plugins/",
   delete_plugin: "/en/admin/cms/page/delete-plugin/76/"}

but your are suffixed with _url. This causes a mashup which doesn't work.
I added console.log so you can debug it as well.

please see the PR here @czpython https://github.com/czpython/django-cms/pull/1

@yakky if it's ok with you I'd like to tackle the deprecation of the properties in a separate pr along with the documentation changes.
The plan would be that each get_action_url() method checks if a value comes back from the property, if so then each method is responsible for raising the deprecation warning for that property.
Ok for you?

@czpython :+1:


Adding pr template and contributing guidlines for new contributors

@Jhemming93
If this was here would your life been easier? Are there errors and cases I missed? Is this written well or should I reword anything?

@allcontributors add @Jhemming93 for review


Random deref response should contain dereffed IRI in responded triples

The DummyDataAccessModule produces random descriptions of an IRI. Currently these describing triples consist of three random long values. The subject or the object of these triples should contain the requested (encoded) IRI so that they are describing triples indeed.

Is this really a necessary requirement?
I agree that responded triples should contain the encoded IRI for real, but I don't think that the DummyDataAccessModule should produce realistic data. It is for testing purposes. If it would be realistic, a triple ex:A ex:P ex:B should be returned for dereferencing ex:A and ex:B (depending on the definition of what dereferencing does).

done, just for convenience


Remove UUID from queued message

Prevents this:
250 Message Queued (9E4BCB7C-6006-451E-BA1D-7F80FCABBE72.1) (9E4BCB7C-6006-451E-BA1D-7F80FCABBE72.1)
Due to the changes in https://github.com/baudehlo/Haraka/commit/167a65452b0d26db3b19cf3ecdef8bcc4f588231

Hrmph. Note to self...find that place in the elasticsearch plugin where I strip that off and remove that code...

No, wait, it would be handy to have UUID in DATA response for debugging purposes.

@celesteking   This has been closed for ages and doesn't stop the UUID from being displayed at the DATA response if you actually read the issue.

issue, what issue darlin?
that's how i see it https://gist.github.com/celesteking/47b6eba047953ad18222

https://github.com/haraka/Haraka/blob/master/connection.js#L1650
It's always added in connection.js - so you can't be running the version from Github master.

Did you actually test that? I'm on v2.7.3, and https://github.com/haraka/Haraka/blob/master/connection.js#L1684 sets msg. somehow, msg is null on that line.

bump


WIP: Testing Documentation

Codecov Report

Merging #80 (34c8cfe) into main (05409d8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   96.89%   96.89%
=======================================
  Files         185      185
  Lines        6178     6189   +11
=======================================
+ Hits         5986     5997   +11
  Misses        192      192

Impacted Files
Coverage Δ

ellar/core/routing/operation_definitions.py
88.46% <100.00%> (+2.09%)
:arrow_up:

ellar/core/routing/websocket/__init__.py
100.00% <100.00%> (ø)

ellar/core/routing/websocket/route.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


feat(useLazyQuery): add interface for lazy query return

Currently result of useQuery have a type UseQueryReturn, but result of useLazyQuery doesn't have any type defined

/rebase

I'm interested in this fix too, but @baitun I think instead of<EMAIL_ADDRESS>it should be just ''@apollo/client/core'


Correct contradicting information and fix typo in config.md

Line 73 and Line 110 appear to contradict themselves - I've changed line 73 to be consistent with 110 (production default is MySQL, with a second alternative of sqlite3). Also fixed a little typo.

MySQL is the production default, and sqlite3 the local / dev default. Don't think it's worth including that info here, think this makes things clearer.


Add SELECTORS override option, fix current TITLE selector

Description
Adds the ability to override Constants.SELECTORS if passed in via search options. This should alleviate some of the urgency to update npm every time Google changes things. It does change Constants.SELECTORS permanently, but I can't think of a reason why you wouldn't want that.
Also fixes the current TITLE selector so all tests pass (from https://github.com/LuanRT/google-this/issues/66)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have checked my code and corrected any misspellings

It looks like the selectors may have changed again already. I've got a thought on how it might be made more reliable in the long-term over at #69 if you want to take a look.

@download13
Yes indeed they have. I'm currently preparing to refactor this library and kind of want to get rid of the selectors mess, it used to work fine but now it's becoming annoying (in fact, the old selectors used in earlier versions of the library kept working for an entire year, but now the updated ones barely last 1 month :/).

Cool, both are good ideas.
I only need the organic search results, so the structure approach seems more appealing to me. Just playing around with Google now:
> results = Array.from(document.querySelectorAll("h1")).find(n => n.innerText == "Search Results")

Search Results

> Array.from(results.parentElement.querySelectorAll("h3")).map(a => a.innerText)
(9) ['Test Definition & Meaning - Merriam-Webster', 'Speedtest by Ookla - The Global Broadband Speed Test', 'TEST | Home', 'TEST Definition & Usage Examples', 'Self-Testing At Home or Anywhere', 'COVID-19 Testing: What You Need to Know', 'TEST | definition in the Cambridge English Dictionary', 'Fast.com: Internet Speed Test', 'Test']0: "Test Definition & Meaning - Merriam-Webster"1: "Speedtest by Ookla - The Global Broadband Speed Test"2: "TEST | Home"3: "TEST Definition & Usage Examples"4: "Self-Testing At Home or Anywhere"5: "COVID-19 Testing: What You Need to Know"6: "TEST | definition in the Cambridge English Dictionary"7: "Fast.com: Internet Speed Test"8: "Test"length: 9[[Prototype]]: Array(0)

> Array.from(results.parentElement.querySelectorAll("*[style='-webkit-line-clamp:2']")).map(a => a.innerText)
...

Perhaps it might be a good temporary solution to use non-class selectors until the refactor happens.

any update?


Fix bom trimming

thanks we will test this soon (we need a upgrade to 17 first)
@SimonCropp don't forget the github releases? That one is still on 17.1.1

this is on nuget. is it not working for you?
i will manually fix the GH release


Prevent showing tooltip on popover

Hi! I need < a > tag which shoud display tooltip on cursor moving and should drop popover on clicking. But tooltip is also shown when I move cursor above popover. Check it: https://jsfiddle.net/ivictbor/re15cuby/

Hi @ivictbor!
You appear to have posted a live example (https://fiddle.jshell.net/ivictbor/re15cuby/show/light/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

line 15, column 7: W013: Bootstrap version might be outdated. Latest version is at least 3.3.2 ; saw what appears to be usage of Bootstrap 3.0.0
line 19, column 7: W013: Bootstrap version might be outdated. Latest version is at least 3.3.2 ; saw what appears to be usage of Bootstrap 3.0.0

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

linked 3.3.2 https://jsfiddle.net/ivictbor/re15cuby/2/ , issue still exists

I'm not sure I understand but that could be cause I'm on a mobile device at the moment. But for me everything is displaying as I would expect unless there is something I'm missing.

Please explain what you mean by "on cursor moving". Do you mean hover?

Duplicate of http://stackoverflow.com/questions/28951100/prevent-showing-tooltip-on-popover

Based on the SO conversation, this isn't a bug per se, but rather an artifact of how the "sibling" tooltip/popover insertion strategy works, which can be avoided by setting the container: 'body' option and thus choosing the alternative "body" insertion strategy.
It's definitely not great, but it's not really fixable without rewriting the tooltip plugin.
We're looking at ways to improve things in v4 though.

Many thanks cvrebert ! Works great!


model.api.get(url, config) ignores config.dataTransformer if config.save == false

Szenario

set save == false to use a custom Model.save() function later

set dataTransformer function to transform response to work with vuex-orm models

I also tried out setting safe after dataTransformer without success.
Code
Model.api().get(url, {
  save: false,
  dataTransformer: ({ data, headers }) => {
    // Do stuff with headers...
    // Do stuff with data...
    return data
  }
})

Expected
Function dataTransformer should be called regardless of save configuration. At least I can't see why it shouldn't.

The dataTransformer is designed to work with the save option. If you choose not to save then processing the response is entirely up to you. However, I do feel the transformer should be executable albeit manually. Something that’ll need to be considered.
In the meantime there are two avenues you could take to work around this:

Create a reusable transformer method that you can pass in the config but also use if you choose not to save, the outcome will be the same.

const dataTransformer = ({ data, headers }) = {
  // Do stuff with headers...
  // Do stuff with data...
  return data
}

// With save
Model.api().get(url, { dataTransformer })

// Without save
Model.api().get(url, { save: false }).then(dataTransformer)

Call getDataFromResponse to invoke the transformer and return the expected transformed response, which will probably be your preferred approach.

const request = await Model.api().get(url, {
  save: false,
  dataTransformer: ({ data, headers }) = {
    // Do stuff with headers...
    // Do stuff with data...
    return data
  }
})

// Invoke the `dataTransformer`
const response = request.getDataFromResponse()

There's about 99 ways to achieve this but you get the gist...

@maspio Hi! Do you have any updates on this?

Closing the issue due to inactivity. Please feel free to open another issue if there's anything 👍


Fixed NPE with Project Rimfactory Revived

issue was butcher.curjob...
prf handles things... differently... but the try-catch should be the least impactful fix

Will add nullcheck for the currentJob instead as its null for the machine.
I try to avoid try/catch if possible :)


Update go 1.21 and fix lint issues

What this PR does / why we need it

Updated github workflows to use go 1.21
Updated root and test go.mod to use go v1.21
Update tools like linters to latest
Fix lint issues
Removed deprecated linters deadcode, varcheck, structcheck, unparam

Which issue(s) this PR fixes

Fixes #
Describe testing done for PR

Build the Tanzu CLI
Perform basic lifecycle ops
Unit tests, Lint checks

Release note

Tanzu CLI is updated to latest go v1.21

Additional information
Special notes for your reviewer

LGTM. Thanks for all the changes to use go v1.21 Let's file an issue to address the linter that needs to be enabled after addressing the errors.

Created JIRA to fix the disbaled lint issues


Documentation of inplace is Counter-intuitive

The documentation for the inplace parameter says:
inplace : bool, default True, meaning return a deepcopy of ``result``
    Whether to alter timestamps in-place.

The description of the default value (True, meaning return a deepcopy of ``result`` )  sounds like the opposite of what Whether to alter timestamps in-place means. Isn't a deep copy only returned when inplace is False?

Yes, that's incorrect. What likely happened here is that the default was changed from False to True at some point but I forgot to change latter, meaning return a deepcopy of ``result`` . Thanks for pointing this out.


Allow scroll to viewed comment even a file is marked as 'viewed'

Close #23466
Right now on pull request "files Changed" tab, if a file is viewed, when the comments' links are visited, the comment will not be shown as the file is folded after viewed. This PR is to improve the behavior, to make the comment seen even the related file is folded, like on github.
And right now scroll position will be remembered and hence it won’t scroll to hashed comment after refreshing, this PR also adjust the scroll position remembering behavior: When there is hash comment in url, do not remember the scroll position.
Before:
https://user-images.githubusercontent.com/17645053/225512079-6cf79581-9346-44cf-95d6-06919642e6a8.mov
After:
https://user-images.githubusercontent.com/17645053/225523753-3f6728f2-977b-4ed0-a65c-63dcef2ace80.mov

Codecov Report

Merging #23513 (e0c9898) into main (f521e88) will increase coverage by 0.01%.
The diff coverage is 44.37%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main   #23513      +/-   ##
==========================================
+ Coverage   47.14%   47.15%   +0.01%
==========================================
  Files        1149     1154       +5
  Lines      151446   152195     +749
==========================================
+ Hits        71397    71766     +369
- Misses      71611    71963     +352
- Partials     8438     8466      +28

Impacted Files
Coverage Δ

cmd/dump.go
0.67% <0.00%> (ø)

models/actions/run.go
1.64% <0.00%> (-0.08%)
:arrow_down:

models/packages/package.go
45.45% <0.00%> (-1.13%)
:arrow_down:

models/user/search.go
77.50% <0.00%> (-6.29%)
:arrow_down:

modules/actions/github.go
0.00% <0.00%> (ø)

modules/actions/workflows.go
0.00% <0.00%> (ø)

modules/doctor/storage.go
31.93% <0.00%> (ø)

modules/setting/git.go
45.45% <ø> (ø)

modules/storage/minio.go
1.51% <0.00%> (-0.06%)
:arrow_down:

modules/structs/user.go
100.00% <ø> (ø)

... and 35 more

... and 16 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

When non-login users access, it is still a bit strange. Is it possible to fix it in this PR?
width 600:

width 1500:

But after refresh, it becomes correct:

Ah, login user with viewed comment also have this issue:
width 600:

width 1500:

(Refresh dones't work)

When non-login users access, it is still a bit strange. Is it possible to fix it in this PR? width 600:  width 1500:  But after refresh, it becomes correct:
Ah, login user with viewed comment also have this issue: width 600:  width 1500:  (Refresh dones't work)

I am not sure what is the specific issue, can you specify?

It will be out of alignment with some special the window width.

Also minor nitpick: The Anchor lands directly on the text of the comment, not a little above, so it's very "cramped". (See second screenshot)

It will be out of alignment with some special window width.

Also minor nitpick: The Anchor lands directly on the text of the comment, not a little above, so it's very "cramped". (See second screenshot)

I cannot reproduce this after applying this PR. In these lines:
commentDiv[0].scrollIntoView({
  behavior: 'auto',
  block: 'center',
  inline: 'center'
});

The comment div will be scrolled to the middle of the screen.

It will be out of alignment with some special window width.

Also minor nitpick: The Anchor lands directly on the text of the comment, not a little above, so it's very "cramped". (See second screenshot)

I cannot reproduce this after applying this PR. The comment div will be in the middle of the screen because of these lines:
commentDiv[0].scrollIntoView({
  behavior: 'auto',
  block: 'center',
  inline: 'center'
});

You need to create a comment with multiple lines, and ensure they are long enough to be outside of the window.

Maybe this is the real problem.
If we use center, when the height of window is short, it will show the middle part of this comment.
Width is not related, Height is related.

Maybe this is the real problem. If we use center, when the height of window is short, it will show the middle part of this comment. Width is not related, Height is related.

I see. I changed the scroll to middle because the header part of the page has various height. So it might be complicated to have it scrolled exactly to the top of the comment div. Header part example:

And if we leave it as it was(commentDiv[0].scrollIntoView({}) with no options), the div will go beneath the header

So middle might work better in most cases.

In Github it seems that it works well, maybe we can fix it better as maybe it is a good example.
(just a suggestion, not blocking, I'm sorry I know little about ui, I can't give code suggestions.)
https://github.com/yp05327/test/pull/4/files#r1138279659

In Github it seems that it works well, maybe we can fix it better? As it is a good example. (just a suggestion, not blocking, I'm sorry I know little about ui, I can't give code suggestions.)
https://github.com/yp05327/test/pull/4/files#r1138279659

It's alright, i think this can be improved. Just added a commit to use scrolltop instead. Feel free to try

It looks awesome now.👍

Since this is a rewriting of old code, I guess it's better either using jQuery or use Vanilla JS ....
Now the code looks a little strange, different approaches are mixed together ....
ancestorDiffBox[0]?.querySelector?.('.diff-file-header');
$('.diff-detail-box')[0].offsetHeight + diffHeader.offsetHeight;

Maybe I'm missing something, but did this introduce an extra top offset that's incorrect on the sticky header?

Screenshot made on 46addc1f938abefd346a7a74d815f6c4faaa6818

I can reproduce as well. Sorry we missed that.

I see the issue, the sticky header offset needs to be changes whether the row has 1 or 2 lines. I don't think the regression is from this PR but it's actually from https://github.com/go-gitea/gitea/pull/23271. I'm preparing a fix.

https://github.com/go-gitea/gitea/pull/23549 will fix it.


fix: two releases using the same chart in different version fails

@yxxhero I thinks we also need add namespace in to alias.
releases:
- name: elasticsearch
  chart: elastic/elasticsearch
  namesapce: ns1
  version: 7.17.3
- name: elasticsearch
  chart: elastic/elasticsearch
  version: 7.17.3
  namespace: ns2

the alias will be same. WDYT? @mumoshu

@yxxhero Ahh, good point! The aliases would be ns1/elasticsearch and ns2/elasticsearch, respectively, right? LGTM then!

@mumoshu all done

@mumoshu all done?

LGTM


A column theoretical content of the algorithms(txt doc) beside the implemented algos.

Adding a column of the theoretically applied algos as given in the book, beside the column of all the implemented algos would make it easier to refer to the algos rather than again and again opening the book to look that particular algo. In this particular column links can be added that can jump directly to the point of the txt doc of the theo. algo. as done in the applied algo column.
I would like to work on this if approved by the organisers.

@coderop2 I think aimacode-pseudocode does the same that you are suggesting. correct me if I am wrong.

What i was saying is adding that column along with all the implemented algos column for easier reference.

@coderop2 I got your point. yes, that will be good.

So if the organisers approve this i can complete it..


Update Game.xaml

Removed references to Jochi in Game.xaml

Hi @kcc1988, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;


Fix: BigQueryVectorStore crashes on BQ tables with more than 5000 rows

Fixes #364

@thomasfitze thanks for your contribution! integration tests are green now, could you fix the linter, please?


Kibana multi-tenancy Error 500 on Tenant list

Hi,
When I hit the Tenants tab, it lists only Private and Global, and there's an error message at the top:
Error 500 Internal Server Error: An internal server error occurred

Nothing in the ES logs, but the following in kibana log (which is now syslog (!)):
May  5 15:25:34 node01 kibana[28394]: {"type":"error","@timestamp":"2017-05-05T13:25:34Z","tags":[],"pid":28394,"level":"error","message":"Uncaught error: \"value\" required in setHeader(\"authorization\", value)","error":{"message":"Uncaught error: \"value\" required in setHeader(\"authorization\", value)","name":"Error","stack":"Error: Uncaught error: \"value\" required in setHeader(\"authorization\", value)\n    at ClientRequest.OutgoingMessage.setHeader (_http_outgoing.js:355:11)\n    at new ClientRequest (_http_client.js:85:14)\n    at Object.exports.request (http.js:31:10)\n    at Object.exports.request (https.js:199:15)\n    at HttpConnector.request (/usr/share/kibana/node_modules/elasticsearch/src/lib/connectors/http.js:161:23)\n    at sendReqWithConnection (/usr/share/kibana/node_modules/elasticsearch/src/lib/transport.js:210:35)\n    at Object._.applyArgs (/usr/share/kibana/node_modules/elasticsearch/src/lib/utils.js:256:19)\n    at bound (/usr/share/kibana/node_modules/elasticsearch/node_modules/lodash/dist/lodash.js:957:21)\n    at _combinedTickCallback (internal/process/next_tick.js:73:7)\n    at process._tickDomainCallback (internal/process/next_tick.js:128:9)"},"url":{"protocol":null,"slashes":null,"auth":null,"host":null,"port":null,"hostname":null,"hash":null,"search":"","query":{},"pathname":"/searchguard/api/v1/multitenancy/info","path":"/searchguard/api/v1/multitenancy/info","href":"/searchguard/api/v1/multitenancy/info"}}
May  5 15:25:34 node01 kibana[28394]: Debug: internal, implementation, error
May  5 15:25:34 node01 kibana[28394]: Error: Uncaught error: "value" required in setHeader("authorization", value)
May  5 15:25:34 node01 kibana[28394]: at ClientRequest.OutgoingMessage.setHeader (_http_outgoing.js:355:11)
May  5 15:25:34 node01 kibana[28394]: at new ClientRequest (_http_client.js:85:14)
May  5 15:25:34 node01 kibana[28394]: at Object.exports.request (http.js:31:10)
May  5 15:25:34 node01 kibana[28394]: at Object.exports.request (https.js:199:15)
May  5 15:25:34 node01 kibana[28394]: at HttpConnector.request (/usr/share/kibana/node_modules/elasticsearch/src/lib/connectors/http.js:161:23)
May  5 15:25:34 node01 kibana[28394]: at sendReqWithConnection (/usr/share/kibana/node_modules/elasticsearch/src/lib/transport.js:210:35)
May  5 15:25:34 node01 kibana[28394]: at Object._.applyArgs (/usr/share/kibana/node_modules/elasticsearch/src/lib/utils.js:256:19)
May  5 15:25:34 node01 kibana[28394]: at bound (/usr/share/kibana/node_modules/elasticsearch/node_modules/lodash/dist/lodash.js:957:21)
May  5 15:25:34 node01 kibana[28394]: at _combinedTickCallback (internal/process/next_tick.js:73:7)
May  5 15:25:34 node01 kibana[28394]: at process._tickDomainCallback (internal/process/next_tick.js:128:9)
May  5 15:25:34 node01 kibana[28394]: {"type":"response","@timestamp":"2017-05-05T13:25:34Z","tags":[],"pid":28394,"method":"get","statusCode":500,"req":{"url":"/searchguard/api/v1/multitenancy/info","method":"get","headers":{"host":"localhost:8200","x-authenticated-user":"faxmodem","x-forwarded-server":"kibana.example.com, <IP_ADDRESS>","x-forwarded-host":"kibana.example.com, <IP_ADDRESS>:8000","x-forwarded-for":"<IP_ADDRESS>, <IP_ADDRESS>","via":"1.1 kibana.example.com, 1.1 <IP_ADDRESS>:8000","cas-user":"faxmodem@example.com","referer":"https://kibana.example.com/app/searchguard-multitenancy","kbn-version":"5.3.2","dnt":"1","accept-encoding":"gzip, deflate","accept-language":"en,en-US;q=0.8,fr;q=0.5,de;q=0.3","accept":"application/json, text/plain, */*","user-agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0","x-authenticated-group":"common","connection":"Keep-Alive","sg_tenant":"__user__"},"remoteAddress":"<IP_ADDRESS>","userAgent":"<IP_ADDRESS>","referer":"https://kibana.example.com/app/searchguard-multitenancy"},"res":{"statusCode":500,"responseTime":23,"contentLength":9},"message":"GET /searchguard/api/v1/multitenancy/info 500 23ms - 9.0B"}

I have a guess, seems like a bug in the plugin. Are you using the plugin with SSO (like JWT or proxy auth)? I guess you have basicauth.enabled set to false, and multitenancy.enabled set to true, right?

yes exactly

I can confirm that this is actually a bug in the plugin which occurs whenever the credentials are not stored in the authorization header of the request, and either the "authinfo" or "kibanainfo" endpoint is called. Basic Auth, Kerberos and JWT all use the "authorization" header, that's why the existing tests did not reveal this bug.
Proposed solution: Examine all headers in the requestHeadersWhitelist setting of kibana, and copy them over. Also, pay attention to the default "authorization" header when this setting is empty.
Needs to be fixed in the next release.
@faxm0dem Thanks for reporting!

Can you please try this snapshot for Kibana 5.3.1:
https://cdn.filestackcontent.com/E3BS0gR1QSW2Qz21OzYR
If you also have Basic Auth enabled (e.g. for the Kibana server user), make sure to have proxy auth first, and Basic Auth second in sg_config.yml.

hmmm kibana doesn't manage to connect. Maybe it's because kibana 5.3.1 isn't compatible with ES 5.3.2?

Sorry, I was under the impression that you use 5.3.1 based on another bug report you issued. KI 5.3.1 against ES 5.3.2 should work, you will just see a warning in the Kibana log. But we can build a snapshot for 5.3.2 as well.
However, I just tried the KI 5.3.1 / ES 5.3.2 scenario locally, and it works here. Can you please share

the Kibana log where connection to ES fails
the kibana.yml file
the sg_config file

Anything suspicious in the ES log files?

Sorry, it was a problem on my end: ES had died for some reason.
Your modified version works!
I can list tenants, and the RO/RW permissions seem to work as expected.
Thanks very much for fixing this so quickly

I think I spoke too quickly: the tenant list works, the kibana indices are created, but when trying to access them in "Discovery" tab, I get the following error:
Config: Error 404 Not Found: [document_missing_exception] [config][5.3.1]: document missing, with { index_uuid="6ZAMNlX-SSKDBBebh86Tww" & shard="0" & index=".kibana_1865400007_sandbox" }

So the error above appears when trying to configure the default index pattern.
 The plugin should check this when opening the tenants tab, and print a warn message if the settings differ. Are you sure the configs you posted are the correct ones, or do I miss something here?

sorry, I used sed to change the password, and it also changed the username.
The setting is okay

Ok, understood. To pinpoint the problem we will send you a snapshot for ES 5.3.2, to rule out any issues that might stem from the version difference.
Is this a test cluster? Because if it is, I'd like you to delete the data directory or at least any already created Kibana index. Would that be possible on your side?

It's the prepoduction cluster, so I can't delete the data.
However, I can with some additional work respawn a test cluster

Ok. So I assume that you already have some objects in the default .kibana index, right? If that is the case, are you able to access those when choosing the "Global" tenant?

yes, the Global tenant works fine.
all other tenants, Private included fail when trying to save a default index-pattern:
Config: Error 404 Not Found: [document_missing_exception] [config][5.3.1]: document missing, with { indexuuid="dnq3Ujp1S7-5XLzzinl76w" & shard="0" & index=".kibana-460255123_foo" }

I have a test cluster up&running with the same symptoms. I will try to delete all kibana indices and report back.

I'm able to reproduce the behavior now with the setup and configs you provided. I'll investigate and report back soon.

Can you please try this Kibana plugin snapshot with 5.3.2 for both Kibana and Elastic?
https://cdn.filestackcontent.com/PdYbw24hRVSI5hp00bMB
We still need to investigate the root cause of your issue though. KI 5.3.1 should work with ES 5.3.2, regardless of the warning in the logs.

It seems to work on my test cluster, but not on the production one.
In all cases I don't have any 500 errors anymore.
I'm currently investigating

Thanks for your help here!
We're tracking this issue now in:
https://github.com/floragunncom/search-guard-module-kibana-multitenancy/issues/8
https://github.com/floragunncom/search-guard-module-kibana-multitenancy/issues/9

I have an odd issue on the production cluster: when adding a new index pattern to the Global tenant, I get the following in the ES log as soon as I click on Create:
No cluster-level perm match for User [name=faxmodem, roles=[common]] [IndexType [index=.kibana, type=index-pattern]] [Action [indices:data/write/bulk]] [RolesChecked [sg_role_myorg, sg_role_kibana_god]]
No permissions for {}

This doesn't happen for any other tenant

@jochenkressin sorry for poking you but shall I open a different issue for the Global tenant behaviour?

@faxm0dem This is actually expected, but wrongly documented behavior. Since ES 5.3, you also need to have bulk write permissions on the Kibana index. The reason why this happens only for the Global tenant is that this tenant refers to the original .kibana index and that it is written by the configured Kibana server user. For all other tenants, we re-write the original request, and these re-written requests have the respective permissions implicitly, including the bulk permissions.
We will update the docs on this to make the behaviour more clear.
I'd like to keep this issue open until v3 of the Kibana module, including proxy auth support, will be released.
Thanks for your input!

ack, thanks for the clarification

Will close this, status will be tracked here https://github.com/floragunncom/search-guard-kibana-plugin/issues/23


Mahou tsukai incompat ?

Hey i'm aplaying a modpack with friends and on this modpack we have the mahou tsukai mod installed as well as the dungeon gears mod. There is a bug where i can't damage my tamed wolf (wich i need for mahou tsukai) and i reported this issue on reddit, a mahou tsukai dev told me that it might be the dungeon gear mod that is turing off friendly fire for pets and it might be turned back on in the config but i can't find anything about friendly fire on pets.

Issue has been resolved in latest version: 3.0.21


Cannot install via cargo

When building with cargo there are no binaries compiled

NVM, i needed to build imgurs-cli. I got it now


fix(Manifoldness): avoid exception on bad input surfaces

@francoisbonneau try to upgrade your branch with this change

Should I wait for Francois input before merging?


[CAMEL-20577] Avoid rest routes dupes

In the case of a Camel Spring Boot application that defines rest routes in camel-xml-io-dsl, rest routes in java dsl, and rest routes spring beans xml, the rest routes are loaded twice in the context and the application cannot start.
I noticed that rests defined in camel-xml-io-dsl and java route configuration are loaded first, together, without issues, but when the rests defined in the spring beans xml are loaded into the camel context, the getContext().getRestDefinitions() contains both the rests defined in the spring beans xml and the rests defined via java or camel-xml, this is why they are loaded twice, getRests() contains only rests defined in the beans xml dsl.
I'm opening the PR in draft, I'd like to execute more tests.

I'll merge this one, I'm adding tests in camel-spring-boot repository


Fix block order sw-property-option-list

1. Why is this change necessary?
Currently the block is closed to early and makes extending the file a little harder
2. What does this change do, exactly?
Closes the block at the correct position
3. Describe each step to reproduce the issue or behaviour.
N/A
4. Please link to the relevant issues (if any).
N/A
5. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-21942
Please use this issue to track the state of your pull request.

Hi @MelvinAchterhuis, you are right its a bit hard to extend, but unfortunately this would be potentially a breaking change and could only be done in a major. Thanks in any case for your support.

@dfrancos-hub , then this still should be labeled as "Scheduled" as it can be merged with <IP_ADDRESS>, correct?

hi @MelvinAchterhuis, in that case, in order to include it in the <IP_ADDRESS> we need to include the deprecation information as described here https://developer.shopware.com/docs/resources/guidelines/code/backward-compatibility . Thanks again in advance.

Hi @MelvinAchterhuis, we need to close PRs that are inactive for a while, including this one. Please open a new PR when you could continue. Thanks


Update to apply to ALL Clouds

Comment about West US only applies to commercial cloud (not Mooncake, Fairfax, or BlackForest)
Configuration server or additional process server prerequisites - list of URLs is specific to commercial cloud.  Need to either provide links to existing docs with the correct URLs for sovereign clouds or put details in here
*note these comments apply to multiple ASR docs :(

Hi @nluedeman, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@nluedeman : Thanks for your contribution to the Azure documentation! The author, @rayne-wiselman, has been notified to review your proposed change.

Hi, I'm not clear on what the changes are here or why they're required. Please provide some more context.

Hi there. Just to add, I'm in the process of checking what changes we need across the ASR doc set for cloud differences. Let's not make the change at the PR level for a single doc. Better to identify across the set and make changes in a controller manner.

agreed.  FYI, this is what is documented for MAG.
https://docs.microsoft.com/en-us/azure/azure-government/documentation-government-services-monitoringandmanagement#site-recovery
I'm internal<EMAIL_ADDRESS>so just ping me in Skype if have
more questions.
On 2/1/2017 9:53 AM, Rayne Wiselman wrote:

Hi there. Just to add, I'm in the process of checking what changes we
need across the ASR doc set for cloud differences. Let's not make the
change at the PR level for a single doc. Better to identify across the
set and make changes in a controller manner.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/azure-docs/pull/599#issuecomment-276694702,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQg8q-tElDGr2brsl9Hh532b719pHaRgks5rYKqHgaJpZM4Lz2yC.

Hi, please close this PR. I've made some changes to an include so that the govt URLs are included in each doc. I'll let you know when I submit that

@rayne-wiselman Thanks for the review. I'll close this pull request, For similar situations in the future, add an appropriate pull request comment, and automation will close the pull request. Thanks.


Fix some keys logic in issue identifier

keys may be None if there is no comic archive.
IssueString.as_string will convert None to empty string so use None comparison before.

ca is guaranteed to be not none by the time this executes see lines https://github.com/comictagger/comictagger/blob/fc4eb4f002a11ceb0a06e2eb78421d3b61ba5ae3/comictaggerlib/issueidentifier.py#L335 and https://github.com/comictagger/comictagger/blob/fc4eb4f002a11ceb0a06e2eb78421d3b61ba5ae3/comictaggerlib/issueidentifier.py#L339
This "issue" has existed since 2013<PHONE_NUMBER>deacd12e5d8658cb835b44127adbdb so I doubt it actually causes any issues. In any case I would rather change it to:
        # we need, at minimum, a series and issue number
        if not (keys["series"] and keys["issue_number"]):
            self.log_msg("Not enough info for a search!")
            return []


[ci:component:github.com/gardener/etcd-backup-restore:0.6.2->0.6.3]

Release Notes:
Fixed the sorting of snapshots.

LGTM