segfault handling large file in visual mode

Reproducible segfault found in vim under specific circumstances

In terminal with X support and mouse=a
Large file of 213,708 lines (~20 Mib)
Go to visual block edition (^V), select about 44 characters for each line (about 9,189,444 characters)
Delete those characters
Press escape and wait a few seconds
Segfault

Built against the master branch on a Debian jessie with a simple ./configure && make
Details
Program received signal SIGSEGV, Segmentation fault.
__GI___libc_free (mem=0x12414940) at malloc.c:2929
2929	malloc.c: No such file or directory.
(gdb) where
#0  __GI___libc_free (mem=0x12414940) at malloc.c:2929
#1  0x00007f7acf3559d6 in ?? () from /usr/lib/x86_64-linux-gnu/libXt.so.6
#2  0x00007f7acf34d6a0 in XtAppProcessEvent () from /usr/lib/x86_64-linux-gnu/libXt.so.6
#3  0x0000000000500d67 in xterm_update () at os_unix.c:7332
#4  0x0000000000504cd0 in RealWaitForChar (fd=0, msec=msec@entry=0, interrupted=interrupted@entry=0x0, check_for_gpm=0x0) at os_unix.c:5823
#5  0x00000000005077cf in mch_breakcheck (force=force@entry=0) at os_unix.c:5470
#6  0x00000000005828cf in ui_breakcheck_force (force=force@entry=0) at ui.c:376
#7  0x00000000005828f7 in ui_breakcheck () at ui.c:356
#8  0x000000000049c615 in vgetorpeek (advance=advance@entry=1) at getchar.c:2044
#9  0x000000000049d880 in vgetc () at getchar.c:1608
#10 0x000000000049dbe9 in safe_vgetc () at getchar.c:1804
#11 0x00000000004e49fd in normal_cmd (oap=oap@entry=0x7fff2f068c90, toplevel=toplevel@entry=1) at normal.c:628
#12 0x00000000005c0bf5 in main_loop (cmdwin=0, noexmode=0) at main.c:1355
#13 0x00000000005c1e6d in vim_main2 () at main.c:908
#14 0x000000000041005e in main (argc=<optimized out>, argv=<optimized out>) at main.c:419

Important this crash only occurs when I'm running glipper that captures X clipboard and is lagging a lot (due to the fact that it captures megabytes of clipboard for each row change in the visual block).
This may make X events be sent in an unexpected / non-standard way

Built against the master branch on a Debian jessie with a simple ./configure && make

Which version of Vim would that be?  (output of  :version  may be useful).
It's perhaps related to this old item mentioned in ":help todo":
X11: Putting more than about 262040 characters of text on the clipboard and
pasting it in another Vim doesn't work.  (Dominique Pelle, 2008 Aug 21-23)
clip_x11_request_selection_cb() is called with zero value and length.
Also: Get an error message from free() in the process that owns the selection.
Seems to happen when the selection is requested the second time, but before
clip_x11_convert_selection_cb() is invoked, thus in X library code

@romuald
Looks like this issue is also the same as the one mentioned in the comment of #1023.
In my reply to the comment, I guessed that the crash appeared to be caused by an application which interferes with selection data exchanges between Vim and the X11 server.
Some time later, One of the follow-ups reported the existence of such an application called klipper.
Now you reported on another application, glipper.
As far as I can tell, Vim implements the selection mechanism in a fairly standard way using the Intrinsics (Xt), and the protocol says nothing about applications working like klipper or glipper; therefore, Vim currently doesn't know what to do when such an application tries accessing to Vim's clipboard while Vim and the X server are talking one another about the ongoing selection data transfer.
Although I think it's not impossible for Vim to reject such an access if it knows the window ID of the clipboard application, I'm not sure if there's a reliable way to know the ID through WM_NAME or WM_CLASS because Vim cannot know those WM_* values a priori.
Also, there might be a desktop environment API which makes it possible for Vim to work cooperatively with the clipboard application, but its use means that Vim has to be built in such a way that it is closely tied with the desktop environment to be used with even if it is built as a terminal application.
For those two reasons, it's too much for Vim to address the issue.  Personally, I'd say klipper and glipper should have been made configurable in that they don't provide the service to applications that don't want it.

This has nothing to do with klipper or glipper.  Those just make it easier to expose the bug since they request the selection when they see that something has asserted ownership, in order to preserve the contents past the lifetime of the original application.  Without them, one may perform large deletes like this, thus asserting ownership, but never actually have something else request the selection.
In a couple minutes I was able to reproduce the problem, using just two vim instances (no clipboard manager), resulting in the two backtraces below.  The steps were similar to the original issue, except manually requesting the selection from the second vim.

Build latest Vim -- ./configure --with-features=huge --with-x --enable-gui=no && make
Build large file to test with -- for i in $(seq 6); do cat src/tag.c >> bigflie; done
Start Vim A -- ./src/vim -u NONE -i NONE -N -n bigfile
Start Vim B -- ./src/vim -u NONE -i NONE -N -n
In Vim A, copy everything and assert the CLIPBOARD selection -- :%y +
In Vim B, paste from the clibpard -- "+p

Note that you may get partial contents of the file or even an error that there is nothing in the register

Wait for a few seconds
Go back to Vim A and try to use it
Crash

The crash seems to happen a bit more reliably if there's nothing in CUT_BUFFER0 (since Vim will fallback to that if CLIPBOARD is "empty"), so an additional step 0 of xprop -root -remove CUT_BUFFER0 may help.
(gdb) bt
#0  0x00007f592c00d2e7 in kill () at ../sysdeps/unix/syscall-template.S:84
#1  0x0000561ac77b1b91 in may_core_dump () at os_unix.c:3363
#2  0x0000561ac77b1b49 in mch_exit (r=1) at os_unix.c:3329
#3  0x0000561ac78802b7 in getout (exitval=1) at main.c:1539
#4  0x0000561ac776bd5f in preserve_exit () at misc1.c:9614
#5  0x0000561ac77afaac in deathtrap (sigarg=6) at os_unix.c:1154
#6  <signal handler called>
#7  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#8  0x00007f592c00e3fa in __GI_abort () at abort.c:89
#9  0x00007f592c04abd0 in __libc_message (do_abort=do_abort@entry=2,
    fmt=fmt@entry=0x7f592c13fd58 "*** Error in `%s': %s: 0x%s ***\n")
    at ../sysdeps/posix/libc_fatal.c:175
#10 0x00007f592c050f96 in malloc_printerr (action=3,
    str=0x7f592c13fdd0 "double free or corruption (!prev)", ptr=<optimized out>,
    ar_ptr=<optimized out>) at malloc.c:5049
#11 0x00007f592c0517de in _int_free (av=0x7f592c373b00 <main_arena>, p=0x561aca405a50,
    have_lock=0) at malloc.c:3905
#12 0x00007f592d458bd9 in OwnerTimedOut (closure=0x561aca0046a0, id=<optimized out>)
    at ../../src/Selection.c:556
#13 0x00007f592d450790 in XtAppProcessEvent (app=0x561ac9b10710, mask=2)
    at ../../src/NextEvent.c:1328
#14 0x0000561ac77b6a9c in xterm_update () at os_unix.c:7332
#15 0x0000561ac77b4657 in RealWaitForChar (fd=0, msec=0, check_for_gpm=0x0, interrupted=0x0)
    at os_unix.c:5823
#16 0x0000561ac77b41d3 in mch_breakcheck (force=0) at os_unix.c:5470
#17 0x0000561ac784b0ef in ui_breakcheck_force (force=0) at ui.c:376
#18 0x0000561ac784b0bf in ui_breakcheck () at ui.c:356
#19 0x0000561ac77365a1 in vgetorpeek (advance=1) at getchar.c:2044
#20 0x0000561ac7735e52 in vgetc () at getchar.c:1608
#21 0x0000561ac77362eb in safe_vgetc () at getchar.c:1804
#22 0x0000561ac777fc06 in normal_cmd (oap=0x7ffc94c8e850, toplevel=1) at normal.c:628
#23 0x0000561ac787ffaf in main_loop (cmdwin=0, noexmode=0) at main.c:1355
#24 0x0000561ac787f76b in vim_main2 () at main.c:908
#25 0x0000561ac787eedb in main (argc=7, argv=0x7ffc94c8ea48) at main.c:419

and
(gdb) bt
#0  0x00007f86f84eb2e7 in kill () at ../sysdeps/unix/syscall-template.S:84
#1  0x000055a4d6bebb91 in may_core_dump () at os_unix.c:3363
#2  0x000055a4d6bebb49 in mch_exit (r=1) at os_unix.c:3329
#3  0x000055a4d6cba2b7 in getout (exitval=1) at main.c:1539
#4  0x000055a4d6ba5d5f in preserve_exit () at misc1.c:9614
#5  0x000055a4d6be9aac in deathtrap (sigarg=6) at os_unix.c:1154
#6  <signal handler called>
#7  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#8  0x00007f86f84ec3fa in __GI_abort () at abort.c:89
#9  0x00007f86f8528bd0 in __libc_message (do_abort=do_abort@entry=2,
    fmt=fmt@entry=0x7f86f861dd58 "*** Error in `%s': %s: 0x%s ***\n")
    at ../sysdeps/posix/libc_fatal.c:175
#10 0x00007f86f852ef96 in malloc_printerr (action=3,
    str=0x7f86f861de90 "double free or corruption (top)", ptr=<optimized out>,
    ar_ptr=<optimized out>) at malloc.c:5049
#11 0x00007f86f852f7de in _int_free (av=0x7f86f8851b00 <main_arena>, p=0x55a4d8622840,
    have_lock=0) at malloc.c:3905
#12 0x00007f86f9936bd9 in OwnerTimedOut (closure=0x55a4d8221340, id=<optimized out>)
    at ../../src/Selection.c:556
#13 0x00007f86f992d6ae in DoOtherSources (app=app@entry=0x55a4d8049710)
    at ../../src/NextEvent.c:1155
#14 0x00007f86f992e2c7 in XtAppNextEvent (app=0x55a4d8049710, event=0x7ffcca3f4210)
    at ../../src/NextEvent.c:1247
#15 0x000055a4d6bf0a0b in xterm_update () at os_unix.c:7317
#16 0x000055a4d6bee957 in RealWaitForChar (fd=0, msec=-1, check_for_gpm=0x7ffcca3f4524,
    interrupted=0x7ffcca3f45b0) at os_unix.c:5890
#17 0x000055a4d6bee385 in WaitForCharOrMouse (msec=-1, interrupted=0x7ffcca3f45b0)
    at os_unix.c:5578
#18 0x000055a4d6bee282 in WaitForChar (msec=-1, interrupted=0x7ffcca3f45b0) at os_unix.c:5508
#19 0x000055a4d6be9508 in mch_inchar (buf=0x55a4d6f4171c <typebuf_init+60> "", maxlen=68,
    wtime=-1, tb_change_cnt=7) at os_unix.c:481
#20 0x000055a4d6c84fb2 in ui_inchar (buf=0x55a4d6f4171c <typebuf_init+60> "", maxlen=68,
    wtime=-1, tb_change_cnt=7) at ui.c:195
#21 0x000055a4d6b71e14 in inchar (buf=0x55a4d6f4171c <typebuf_init+60> "", maxlen=204,
    wait_time=-1, tb_change_cnt=7) at getchar.c:3065
#22 0x000055a4d6b71a9b in vgetorpeek (advance=1) at getchar.c:2841
#23 0x000055a4d6b6fe52 in vgetc () at getchar.c:1608
#24 0x000055a4d6b702eb in safe_vgetc () at getchar.c:1804
#25 0x000055a4d6bb9c06 in normal_cmd (oap=0x7ffcca3f4970, toplevel=1) at normal.c:628
#26 0x000055a4d6cb9faf in main_loop (cmdwin=0, noexmode=0) at main.c:1355
#27 0x000055a4d6cb976b in vim_main2 () at main.c:908
#28 0x000055a4d6cb8edb in main (argc=7, argv=0x7ffcca3f4b68) at main.c:419

This has nothing to do with klipper or glipper. Those just make it easier to expose the bug since they request the selection when they see that something has asserted ownership, in order to preserve the contents past the lifetime of the original application. Without them, one may perform large deletes like this, thus asserting ownership, but never actually have something else request the selection.

It looks to me that the second sentence explains well why those two applications do have something to do with the crash, which appears to contradict the assertion of the first sentence.
Anyway, the issue appears to be due to a lack in the convention established since X11.5 of the selection mechanism as to what to do when the owner is asked to share its clipboard content with another application which tries getting involved in the sequence of ownership and data transfer between the "eligible" participants.
Hmm, if we knew any good way for the owner to check if the requestor who sent a SelectionNotify event was eligible for aborting current ongoing ownership and data transfer, the issue might be fixed...  Any thoughts?

It looks to me that the second sentence explains well why those two applications do have something to do with the crash, which appears to contradict the assertion of the first sentence.

My point was that those applications aren't doing anything out of the ordinary, as I then demonstrated by using two instances of Vim instead of involving any clipboard managers.  The clipboard managers aren't interrupting anything.  They're just another client that requests the contents of the selection.

Anyway, the issue appears to be due to a lack in the convention established since X11.5 of the selection mechanism as to what to do when the owner is asked to share its clipboard content with another application which tries getting involved in the sequence of ownership and data transfer between the "eligible" participants.

Maybe I'm missing something, but I don't see why you're focusing on this since the issue can easily be replicated without any "ineligible" (although I disagree with that characterization) participants.

My point was that those applications aren't doing anything out of the ordinary,

True, the purpose of them is not out of the ordinary, but the way of attaining that matters.  From my point of view, they should wait until all the transfer sequence completes so that they won't interfere with the assumed scenario of the established convention.  Hopefully, this would clarify the meaning of "eligible."

as I then demonstrated by using two instances of Vim instead of involving any clipboard managers.

Thanks to your report, I came to know of that.
In my previous comment, I rather tried to talk about the cause of the crash found in common in both the clipboard managers and Vim, not that I was insisting on that the clipboard case only mattered.
Actually you raised a new issue.
For the clipboard managers, I hope the issue will be fixed by having them wait until selection sequence completes so that they won't interfere with applications observing the convention.
As for the case you reported, however, we need to handle the case the convention didn't assume.   Looks very tricky.

The clipboard managers aren't interrupting anything.

As i explained, they actually do that...

They're just another client that requests the contents of the selection.

So, that's the root cause of all the issues...

Would you try this patch?
https://gist.github.com/ichizok/548dda4bd3839a517c5b0a66d4cbf3e5
Contents:
to paste correctly,

treat PropertyNotify event with priority than Selection(Notify|Request)

to prevent SEGV,

set notify callback to XtOwnSelection to prevent automatically freeing selection-value by libxt
and manage memory for selection-value in clip_x11_convert_selection_cb

Thanks for the patch.
Unfortunately, my PC used for vim development hasn't been fully functioning since last Saturday due to a memory module failure, and now I'm waiting for the arrival of parts for replacement.  Also, I'm not 100% sure if that replacement will do for restoring the functionality.
In the meantime, it is by no means my intention to block the review process because of that personal reason, as the issue seemingly has remained unresolved for years.   I'd rather be happy if someone would review the patch and even give a go to get the process on the fast track.

Hi Bram, Kiichi(ichizoku) and All,
2017-7-11(Tue) 4:34:34 UTC+9 ichizok:

Would you try this patch?
https://gist.github.com/ichizok/548dda4bd3839a517c5b0a66d4cbf3e5
Contents:
to paste correctly,
treat PropertyNotify event with priority than Selection(Notify|Request)
to prevent SEGV,
set notify callback to XtOwnSelection to prevent automatically freeing selection-value by libxt
and manage memory for selection-value in clip_x11_convert_selection_cb

I confirmed that his patch solved the following problems written in the todo list.
> X11: Putting more than about 262040 characters of text on the clipboard and
> pasting it in another Vim doesn't work.  (Dominique Pelle, 2008 Aug 21-23)
> clip_x11_request_selection_cb() is called with zero value and length.
> Also: Get an error message from free() in the process that owns the selection.
> Seems to happen when the selection is requested the second time, but before
> clip_x11_convert_selection_cb() is invoked, thus in X library code.

I think this patch is great👍
Best regards,
Hirohito Higashi (h_east)

Seems I have to admit I was wrong...
Somehow I took it into my head that our editor fully supported the X11 selection mechanism specified by ICCCM.  But now I cannot be sure of that.  Currently, the editor appears  to support atomic transfers only, not incremental transfers yet, since none of the API to implement the latter is found in src/ui.c.
Roughly speaking, because of a limitation every X11 implementation inherently has (See XMaxRequestSize(3)), selection data transfers have to be done incrementally for selections which are large relative to the return value of XMaxRequestSize().  Unfortunately, X Toolkit Intrinsics (Xt) does not do that automatically for us for free.
I'll read up on the issue with the documents mentioned above, all of which are dated back to 1994...


Updated Contributers

Closing this as it has been stalled for a long time.
@videetssinghai, please try going through the tutorial again if you're interested.


[Code duplication] Extract protocols to sub-project/package

Here's the thing. We have at least 3 written on Go different projects where we use marshalling/unmarshalling of the protocol's frame:

CLI
Fn
FDK-go

In order to keep them consistent, we might need to put protocols into a sub-package (like fnext) or sub-project (it's up to us decide hopefully).

cli and fdk use same structs right?
we tried having the server rely on fdk models but it didn't work very well, it's a strange dependency since we have to update the swagger to generate the models to import the changed models and then we're stuck with some weird version of the fdk we're importing that doesn't exist in the released fdk until we land a feature. also for the server we're making judicious use of db:"" struct tags which don't make sense in fdk models.
so, seems like we're at optimal already for this? i take it we want to eliminate issues like https://github.com/fnproject/fdk-go/issues/23#issuecomment-385472882 but that has a lot of context around what went wrong (can't use swagger to switch on content type, change wasn't made with compatibility in mind, cli doesn't seem to stay up to date with fdk updates). in this case, i don't think it's a good idea to rope in fn server to this discussion.

rewriting to say same-ish thing, this is a dupe of https://github.com/fnproject/cli/issues/156 btw.
fn server and CLI (sender) play a different role than the fdk (receiver), for one, i don't think those need to be co-located. importing fn into cli seems like it won't go well, this will be hard to maintain. after we have cloud events i don't think there's really a lot of complications around all our protocol stuff (#957). right now it's really bad since we have 4 protocols basically. i foresee us maybe importing some kind of package like github.com/fnproject/cloudevent (or maybe official one some day) but that won't handle the STDIN/STDOUT, it will just have struct definitions, we can pretty easily marshal / unmarshal that struct to/from stdin/stdout. anyway i think the issue is mostly to do #785 (get rid of all formats but cloud event), then all we're left with is the cli and the server are both constructing docker images and there's some duplicate code there. maybe one day we figure out how to extract that, but i'm not sure the tradeoffs are worth it anyway (managing 3rd party dep is no fun).

Sorry, you've posted just a minute before i've posted PR for FDK https://github.com/fnproject/fdk-go/pull/24 =/

stale


configuration ignored with emacs26

Describe the bug
Emacs26 ignores configuration files located in home. (.emacs.d/init.el).
To Reproduce
Steps to reproduce the behavior:

update channels to last nixos-unstable
install emacs26
run emacs

Observed behavior
Default configuration is loaded.
Expected behavior
Configuration from .emacs.d/init.el is loaded.
Workaround
use emacs25

What exact version of emacs are you using? I'm using 26.3, and the ~/.emacs.d/init.el file seems to be loading fine for me.
readlink -f $(which emacs)
/nix/store/jwyvrzjzzc99aihm0r7gjx4vh0dqrfmz-emacs-26.3/bin/emacs-26.3


handle empty pole vector for timevector calculation

The automatic timevector calculation sometimes encounters empty vectors. The small random systems used in the test suite sometimes fail (#438).
Escape the LaTeX formula in the docstring to avoid warning messages. Sphinx can still handle it.

Coverage decreased (-0.1%) to 86.489% when pulling 1603e85a992d6a769c7123e8f599842d7eacdd29 on bnavigator:timevector-fix into 51c797e97ef43f15bdee87e40d0e2d932dfff6a7 on python-control:master.


Add servlet 2.2 instrumentation

Description
Adding instrumentation for old servlet versions (2.2-3.0). This is used in boomi. The implementation is almost similar to servlet-3.0.

Testing
Tested with rest API in boomi which uses servlet-2.5 and able to instrument everything there except response headers.
Checklist:

[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been merged and published in downstream modules

Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@kaushal02 we should add tests as well


Different version compatibility

Check compatibility with different version of hadoop, hive, oozie, pig etc.

I have implemented teamcity plugin for this purpose https://github.com/presidentio/teamcity-matrix-build-plugin

Supported versions:

hive - 1.0.0 and higher
hadoop - 2.4.0 and higher
oozie - 4.2.0
Please, comment here version you need and I'll try to make it compatibile.

Required support of cdh 4.6

Supported:

Technology
Version

Hadoop
2.2.0 or higher

Hive
1.0.1 or higher

Oozie
4.0.0 or higher

Flume
1.5.0 or higher

Zookeeper
3.4.5 or higher

Kafka
<IP_ADDRESS> or higher

Pig
0.12.0 or higher

Platform
Version

CDH
5.2.0 or higher

HDP
2.2.0 or higher


rar: Invalid checksum

The rar cask was recently updated in https://github.com/caskroom/homebrew-cask/pull/36083, but the checksum appears to be invalid.
$ brew cask install rar
==> Caveats
Instructions on using rar and unrar are available in

  /usr/local/Caskroom/rar/5.5.b5/rar/rar.txt

==> Satisfying dependencies
==> Downloading http://www.rarlab.com/rar/rarosx-5.5.b5.tar.gz
######################################################################## 100.0%
==> Verifying checksum for Cask rar
==> Note: running "brew update" may fix sha256 checksum errors
Error: Checksum for Cask 'rar' does not match.

Expected: 9beef59f8fb6210eb00c1b52bd69884e36f51ca233daf657769a7dbe3a45da0f
Actual:   a0ae92f5cf0c16cccbc2067292396135e16477594ce026eae9120ad82769470e
File:     /Users/martin/Library/Caches/Homebrew/Cask/rar--5.5.b5.tar.gz

To retry an incomplete download, remove the file above.
Error: Install incomplete.

Still invalid after retrying download:
$ rm /Users/martin/Library/Caches/Homebrew/Cask/rar--5.5.b5.tar.gz
$ brew cask install rar
==> Caveats
Instructions on using rar and unrar are available in

  /usr/local/Caskroom/rar/5.5.b5/rar/rar.txt

==> Satisfying dependencies
==> Downloading http://www.rarlab.com/rar/rarosx-5.5.b5.tar.gz
######################################################################## 100.0%
==> Verifying checksum for Cask rar
==> Note: running "brew update" may fix sha256 checksum errors
Error: Checksum for Cask 'rar' does not match.

Expected: 9beef59f8fb6210eb00c1b52bd69884e36f51ca233daf657769a7dbe3a45da0f
Actual:   a0ae92f5cf0c16cccbc2067292396135e16477594ce026eae9120ad82769470e
File:     /Users/martin/Library/Caches/Homebrew/Cask/rar--5.5.b5.tar.gz

To retry an incomplete download, remove the file above.
Error: Install incomplete.

brew update does not help. Downloading the file with curl also gives a different checksum:
$ curl -sO http://www.rarlab.com/rar/rarosx-5.5.b5.tar.gz
$ gsha256sum rarosx-5.5.b5.tar.gz
a0ae92f5cf0c16cccbc2067292396135e16477594ce026eae9120ad82769470e  rarosx-5.5.b5.tar.gz
$ tar -vxf rarosx-5.5.b5.tar.gz
x rar/
x rar/acknow.txt
x rar/default.sfx
x rar/license.txt
x rar/order.htm
x rar/rar
x rar/rar.txt
x rar/rarfiles.lst
x rar/readme.txt
x rar/unrar
x rar/whatsnew.txt

https://github.com/caskroom/homebrew-cask/pull/36295

run in a similar problem
bash-3.2$ brew cask install filezilla
==> Satisfying dependencies
==> Downloading https://downloads.sourceforge.net/filezilla/FileZilla_Client/3.31.0/FileZilla_3.31.0_macosx-x86.app.tar.bz2
######################################################################## 100.0%
==> Verifying checksum for Cask filezilla
==> Note: running "brew update" may fix sha256 checksum errors
Error: Checksum for Cask 'filezilla' does not match.
Expected: 188e8d9af77dbcdd6176fb7eeca19083fff6f22e41331a1927c78c73c1faa769
Actual:   7a07d3f7cca5c0b38ca811984ef8da536da32932d68c1a6cce33ec2462b930bf
File:     /Users/steffen/Library/Caches/Homebrew/Cask/filezilla--3.31.0.tar.bz2
To retry an incomplete download, remove the file above.
brew cleanup, brew cask cleanup nor update is helping
Any idea?
THX!


Add transposer kernels for reordering field data.

We need to reorder field data as we switch between x, y, and z orientations.
First commit adds transposing operation from x to y.
Select type stuff we have to do here is a bit annoying, and it is mainly due to the extention of the base field type in CUDA backend to support device arrays in Fortran. Any suggestion here is welcome @JamieJQuinn.

Refactored all the transpose functions into one as we agreed, but kept the cuda kernels as they are due to performance concerns.
Also, renamed transpose and trans into reorder. The name tranpose stuck from the original Xcompact3D implementation, but the operation we're carrying out is not any more a transpose I believe. It is always local and just reorders data into x, y, or z directions so that we can use our 1D tridiagonal solver. What do you think about this? I added all the renaming stuff in a single commit and easily convert back if people disagree.

Refactored all the transpose functions into one as we agreed, but kept the cuda kernels as they are due to performance concerns.
Also, renamed transpose and trans into reorder. The name tranpose stuck from the original Xcompact3D implementation, but the operation we're carrying out is not any more a transpose I believe. It is always local and just reorders data into x, y, or z directions so that we can use our 1D tridiagonal solver. What do you think about this? I added all the renaming stuff in a single commit and easily convert back if people disagree.

reorder seems sensible to me

Added a simple test, please let me know if there is anything you want to add. I plan to merge tomorrow.

Looking good to me. I think in the future we could move checkperf into a separate test module because it is used in other tests too. But this is outside the scope of this PR.

Can someone also comment here the reasoning behind refactoring the individual reorder functions (e.g. trans_x2y) into the switch-style reorder(u_y, u, RDR_X2Y)?
To me, the calling code remains semantically identical so there's no reduction in complexity there, and there has to be a separate kernel for every direction anyway, so we haven't reduced complexity on the backend. I feel like I'm missing the advantage of introducing this new switch statement.

Can someone also comment here the reasoning behind refactoring the individual reorder functions (e.g. trans_x2y) into the switch-style reorder(u_y, u, RDR_X2Y)?

To me reorder(... RDR_X2Y) feels cleaner because you have a single subroutine to do the work, you don't have to setup 6 different ones, all having the same set of input and output definitions that is error prone. When reading the code it felt simpler that way to be more concise.

Can someone also comment here the reasoning behind refactoring the individual reorder functions (e.g. trans_x2y) into the switch-style reorder(u_y, u, RDR_X2Y)?

It helped us to remove some of the backend procedures and we ended up having fewer lines.
Also, we need separate kernels in the CUDA backend but in the OpenMP backend we can actually have a single subrotuine doing all the reorderings based on the switch parameter.


Consul binary not found when puppet agent is daemonized

Sometimes the consul binary cannot be found when resolving facts on a system.  This results in information like the consul_version fact not being available to puppet modules.  It turns out that the problem happens because the default install location of the consul binary symlink is /usr/local/bin.  When the puppet agent is daemonized on system start it is run by the init process which does not have /usr/local/bin in its path.  If puppet is run by a user with sudo puppet agent -t this all works fine because typically /usr/local/bin is in the path, but all automated runs will fail to resolve these facts.
There are a couple of possible solutions to this problem.  I didn't submit a PR because I figured it would be better to discuss what the right fix is first.  Solutions are:

Modify the fact so that it points to the absolute path of the consul binary (/usr/local/bin/consul).
Modify /etc/sysconfig/puppet on all systems to include /usr/local/bin in the path.

The first solution seems like it makes sense, but the problem is that the bindir variable in the consul module is configurable, and there is no way to read bindir from a custom fact.  The second solution requires a global modification to the system in order for this to work.  I guess one possible solution is it make it so that the bindir location is not configurable and symlink into a location that is guaranteed to exist (/usr/bin) instead.

Blarg :(
/usr/local/bin "feels" like the right place to put a randomly downloaded file.
As a work around you could change the bin dir:
https://github.com/solarkennedy/puppet-consul/blob/605f5a705187f5783df20a67d0eb70b978a3ae09/manifests/init.pp#L16
Also we could "hack" the path in the fact itself.

I agree that /usr/local/bin "feels" like the right place.  It just, sadly, doesn't seem to work.  And I assume I'm not the only person affected by this.  It would be unfortunate to require all users of the module to set bin_dir in order to get facts to resolve.
When you say "hack" the path, are you referring to setting the fact's binary to use an absolute path like /usr/local/bin/consul?  That solution would be fine with me, just that the bin_dir could not be changed then.

This is the first time this issue has been raised, but yes you are probably not the only person to be affected.
When I say "hack" I mean literally adjust the path in the environment during execution of the fact to include /usr/local/bin/ if it ins't in there.

Hey, that actually sounds like a pretty good solution to me.  I'd be happy to submit a patch if you're serious about the solution.

Yea man, shipit.


[Minor] Handle 403 response to send the message as HTTP response

The message from WebApplicationException Permission Denied is not sent back as HTTP response from broker. This minor patch fixes that.
Existing
$ curl -X POST "http://<host:port>/query/sql"      -H "Content-Type: application/json"      -d '{"sql":"<QUERY>", "queryOptions": "useMultistageEngine=true"}' -v
Note: Unnecessary use of -X or --request, POST is already inferred.
*   Trying <IP>...
* TCP_NODELAY set
* Connected to <HOST> (<IP>) port <port> (#0)
> POST /query/sql HTTP/1.1
> Host: <host:port>
> User-Agent: curl/7.64.0
> Accept: */*
> Content-Type: application/json
> Content-Length: 158
>
* upload completely sent off: 158 out of 158 bytes
< HTTP/1.1 403 Forbidden
< Content-Length: 0
<
* Connection #0 to host <host> left intact

With this Change
$ curl -X POST "http://<host:port>/query/sql"      -H "Content-Type: application/json"      -d '{"sql":"<QUERY>", "queryOptions": "useMultistageEngine=true"}' -v
Note: Unnecessary use of -X or --request, POST is already inferred.
*   Trying <IP>...
* TCP_NODELAY set
* Connected to <HOST> (<IP>) port <port> (#0)
> POST /query/sql HTTP/1.1
> Host: <host:port>
> User-Agent: curl/7.64.0
> Accept: */*
> Content-Type: application/json
> Content-Length: 158
>
* upload completely sent off: 158 out of 158 bytes
< HTTP/1.1 403 Forbidden
< Content-Type: application/json
< Content-Length: <50>
<
* Connection #0 to host <HOST> left intact
{"code":403,"error":"Permission denied"}

This would be useful when the failed table names are returned as from the change made in https://github.com/apache/pinot/pull/13195

Codecov Report
Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (59551e4) to head (7df438d).
Report is 535 commits behind head on master.

Files
Patch %
Lines

...pinot/broker/api/resources/PinotClientRequest.java
0.00%
10 Missing :warning:

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #13292       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.75%
+ Complexity      207        6      -201
=============================================
  Files          2436     2459       +23
  Lines        133233   135664     +2431
  Branches      20636    20982      +346
=============================================
- Hits          82274        6    -82268
- Misses        44911   135658    +90747
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
<0.01% <0.00%> (-0.01%)
:arrow_down:

integration1
<0.01% <0.00%> (-0.01%)
:arrow_down:

integration2
0.00% <0.00%> (ø)

java-11
?

java-21
<0.01% <0.00%> (-61.63%)
:arrow_down:

skip-bytebuffers-false
<0.01% <0.00%> (-61.75%)
:arrow_down:

skip-bytebuffers-true
0.00% <0.00%> (-27.73%)
:arrow_down:

temurin
<0.01% <0.00%> (-61.75%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hi @Jackie-Jiang, can you PTAL for this minor fix?

@Jackie-Jiang That's a bit more effort I suppose as that requires refactoring the existing exception mappers into a common package ( possibly pinot-spi ) and making them as providers to Jersey Starter. At present using '@provider' binds exception mapper in the runtime. How about creating that refactoring as a starter task in issues for interested folks to pick it up?


Allow providing custom bins for summing scores

The --rank option allows summing scores over a particular rank. In essence, the taxonomic groups at that rank serve as bins for scores, and scores are then summed over all predictions that fall into the bin.
It would be useful to allow providing custom 'bins' for this purpose, especially when supplying a custom list of classes between which to predict, which cannot be used in conjunction with --rank (because we can't really know how to bin by a given rank).
One way to provide a custom binning when using custom classes would be a simple mapping file (custom class to custom bin).

Ideas: First column is what the user wants to bin. Second column is the name of the bin for that item.
Species,bin
Orthomiella rantaizana,bin1
Orthomiella sinensis,bin2

Genus,binName

NOTE: --binfile would supply the classes. This would be instead of the --cls argument.


STDC_VERSION macro not always defined

I'm trying to use this library in a project with g++, and it seems that __STDC_VERSION__ is not defined when compiling C++ (https://gcc.gnu.org/onlinedocs/cpp/Standard-Predefined-Macros.html). This seems like it poses an issue where:

https://github.com/j123b567/scpi-parser/blob/master/libscpi/inc/scpi/cc.h#L44-L55 does not define C99
https://github.com/j123b567/scpi-parser/blob/master/libscpi/inc/scpi/cc.h#L107-L109 then does not define HAVE_STDBOOL
https://github.com/j123b567/scpi-parser/blob/master/libscpi/inc/scpi/cc.h#L161-L163 then defines HAVE_STDBOOL to be 0
https://github.com/j123b567/scpi-parser/blob/ef7112d28859ff50f5b1d870fe933579e1d1fd49/libscpi/inc/scpi/types.h#L53-L55 then defines a typedef for bool, which causes a redeclaration error in C++:

../libscpi/inc/scpi/types.h:54:27: error: redeclaration of C++ built-in type 'bool' [-fpermissive]
   54 |     typedef unsigned char bool;
      |

Should __cplusplus be used instead if it is defined to determine which language standard to define for the rest of cc.h? __cplusplus should also have values like 199711L and 201103L.

You can always define HAVE_STDBOOL=1 yourself - on command line or in scpi_user_config.h so you can try if it fixes the compilation.
Feel free to provide PR which solve this.

I think I'm getting away with using
#if (!HAVE_STDBOOL) && (!_GLIBCXX_HAVE_STDBOOL_H)
    typedef unsigned char bool;
#endif

C++98 should have stdbool.h so should be fixed by #139

Please reopen if it is still an issue.


Language injections might block access to the file

Having a following fragment in the file:
[
  #"alpha=https://[${fleet.alpha.services.fleetKubernetes.externalIp}]:2380"
  "beta=https://[${fleet.beta.services.fleetKubernetes.externalIp}]:2380"
]

(Etcd peer list, where the first entry is commented)
Causes neovim to be stuck in loop with E79: Cannot expand wildcards; Press ENTER or type command to continue every time the file is changed, making it impossible to do anything without disabled highlight (:TSDisable highlight), except quitting vim via hard reset, caused by "alpha=https://[${fleet.alpha.services.fleetKubernetes.externalIp}]:2380" being interpreted as language name, and trying to find matching parser:
Executing command: "vimglob() { while [ $# -ge 1 ]; do echo "$1"; shift; done }; vimglob >/tmp/nvim.lach/C9dClA/41 /nix/store/b9c39jpv0pciszc2bsjw72yjvgyk58ig-vim-pack-dir/pack/myNeovimPackages/start/rainbow-delimiters.nvim/parser/#\"alpha=https://[${fleet.alpha.services.fleetKubernetes.externalIp}]:2380\".*"

E79: Cannot expand wildcards

Executing command: "vimglob() { while [ $# -ge 1 ]; do echo "$1"; shift; done }; vimglob >/tmp/nvim.lach/C9dClA/42 /nix/store/b9c39jpv0pciszc2bsjw72yjvgyk58ig-vim-pack-dir/pack/myNeovimPackages/start/rust-tools.nvim/parser/#\"alpha=https://[${fleet.alpha.services.fleetKubernetes.externalIp}]:2380\".*"

E79: Cannot expand wildcards

Executing command: "vimglob() { while [ $# -ge 1 ]; do echo "$1"; shift; done }; vimglob >/tmp/nvim.lach/C9dClA/43 /nix/store/b9c39jpv0pciszc2bsjw72yjvgyk58ig-vim-pack-dir/pack/myNeovimPackages/start/telescope-manix/parser/#\"alpha=https://[${fleet.alpha.services.fleetKubernetes.externalIp}]:2380\".*"

E79: Cannot expand wildcards

Executing command: "vimglob() { while [ $# -ge 1 ]; do echo "$1"; shift; done }; vimglob >/tmp/nvim.lach/C9dClA/44 /nix/store/b9c39jpv0pciszc2bsjw72yjvgyk58ig-vim-pack-dir/pack/myNeovimPackages/start/telescope-symbols.nvim/parser/#\"alpha=https://[${fleet.alpha.services.fleetKubernetes.externalIp}]:2380\".*"

E79: Cannot expand wildcards

I'm not sure who is responsible for escaping glob here, might escalate this issue to neovim itself, but for this grammar plugin, maybe not every comment should be parsed as language identifier?
https://github.com/nix-community/tree-sitter-nix/blob/master/queries/injections.scm#L2

Can also be triggered on nixpkgs:
https://github.com/NixOS/nixpkgs/blob/612f97239e2cc474c13c9dafa0df378058c5ad8d/pkgs/development/python-modules/werkzeug/default.nix#L72


Improve performance by reducing the number of times the same data is parsed

getJSONStringForValidation(external: external, payload: payload) is not unnecessarily repeated in the forEach loop for every rule
the JsonLogic object is created only once in the Rule and stored in a private var. This avoids the rather expensive parsing of the JsonLogic object many times if the same rule is evaluated for many certificates

@alexchornyi @SchulzeStTSI can you provide an ETA when this PR is reviewed and also just in general maybe clarify how actively this project is still maintained?

@SchulzeStTSI I saw you merged my PR in SwiftCBOR (thank you!) - any chance to get this one also reviewed and merged soon?


Ia tweak experiment another approach

This PR is not intended to be merged to master, but to illustrate the idea for new content organisation.
Changes:

Introduce "Building for modern Web" section (our intro to WebFu)
Move "Web components" to "Architectural patterns" for better exposure
Group "Glossary" and former "Base Technologies" under "Reference"
Rename "Javascript" to "ES Features"

@Meggin  @petele

:+1:

Closing for now


Add missing element items xs:pattern, xs:totalDigits,

xs:fractionDigits, dfdl:property

Add missing xs:restriction child elements
Add missing dfdl:escapeScheme element and the escapeScheme attributes
add missing dfdl:newVariableInstance element
add additional missing dfdl:format attributes
add a preceeding space if missing when auto completing an attribute

Closes #587
Closes #588
Closes #591
Closes #592
Closes #593
Closes #609

This pull request should have been an issue


False positive after using a member from an aliased import

Given:
import blah as blah2

x: blah2.Dict[str] = 42

This linter will raise an error which appears spurious:
demo.py:1:1: FA100 Missing from __future__ import annotations but imports: blah2.Dict

I think the fix is that visit_Import should have the asname branch nested within the if alias.name == "typing": branch rather than separate from it.

Makes sense, I will accept a PR for this fix! 👍


Update caliban, caliban-zio-http to 1.2.3

Updates

com.github.ghostdogpr:caliban
com.github.ghostdogpr:caliban-zio-http

from 1.2.2 to 1.2.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.ghostdogpr" } ]

labels: library-update, early-semver-patch, semver-spec-patch

Superseded by #49.


Docker deployment

I deployed this in Docker for a project I'm involved in. It includes a docker-compose file, which lets you stand up the entire project with one command.
Would you like me to wrap that up in a PR and contribute it back to the project?

I added that PR
#4


Exception: Error: Unable to access jarfile

i got an error when i try to php bin/cake.php AssetCompress.AssetCompress build. always showing error like this.
Exception: Error: Unable to access jarfile in [/Applications/MAMP/htdocs/cakephp/vendor/markstory/mini-asset/src/Filter/AssetFilter.php, line 100] 2017-05-23 04:35:23 Error: [RuntimeException] Error: Unable to access jarfile in /Applications/MAMP/htdocs/cakephp/vendor/markstory/mini-asset/src/Filter/AssetFilter.php on line 100 Stack Trace: #0 /Applications/MAMP/htdocs/cakephp/vendor/markstory/mini-asset/src/Filter/YuiJs.php(48): MiniAsset\Filter\AssetFilter->_runCmd('java -jar "" --...', '') #1 /Applications/MAMP/htdocs/cakephp/vendor/markstory/mini-asset/src/Filter/FilterCollection.php(66): MiniAsset\Filter\YuiJs->output('/Applications/M...', '') #2 /Applications/MAMP/htdocs/cakephp/vendor/markstory/mini-asset/src/Output/Compiler.php(73): MiniAsset\Filter\FilterCollection->output('/Applications/M...', '') #3 /Applications/MAMP/htdocs/cakephp/vendor/markstory/asset_compress/src/Shell/Task/AssetBuildTask.php(74): MiniAsset\Output\Compiler->generate(Object(MiniAsset\AssetTarget)) #4 /Applications/MAMP/htdocs/cakephp/vendor/markstory/asset_compress/src/Shell/Task/AssetBuildTask.php(48): AssetCompress\Shell\Task\AssetBuildTask->_buildTarget(Object(MiniAsset\AssetTarget)) #5 /Applications/MAMP/htdocs/cakephp/vendor/markstory/asset_compress/src/Shell/AssetCompressShell.php(74): AssetCompress\Shell\Task\AssetBuildTask->build() #6 /Applications/MAMP/htdocs/cakephp/vendor/cakephp/cakephp/src/Console/Shell.php(458): AssetCompress\Shell\AssetCompressShell->build() #7 /Applications/MAMP/htdocs/cakephp/vendor/cakephp/cakephp/src/Console/ShellDispatcher.php(230): Cake\Console\Shell->runCommand(Array, true, Array) #8 /Applications/MAMP/htdocs/cakephp/vendor/cakephp/cakephp/src/Console/ShellDispatcher.php(182): Cake\Console\ShellDispatcher->_dispatch(Array) #9 /Applications/MAMP/htdocs/cakephp/vendor/cakephp/cakephp/src/Console/ShellDispatcher.php(128): Cake\Console\ShellDispatcher->dispatch(Array) #10 /Applications/MAMP/htdocs/cakephp/bin/cake.php(34): Cake\Console\ShellDispatcher::run(Array) #11 {main}

Looks like you are missing a jarfile. If you want to use yuicompressor, you'll need to provide the path to the jar file.


Board size in Flip activity is not optimized

The board size in Flip activity don't use the dimension of the game.
So for a 7x7 game the window fit to the screen:

But for a 4x4 game there is a large gap at the bottom of the grid:

Fixed in https://github.com/llaske/sugarizer/commit/d98a415f4d21a11b911ac438fa57ffe8a0637a25


[Telework]: Update: front end "Before you begin" section

User Story
“As a user I want accurate up to date instructions reflecting the new 5.0 workflow and features so I can get manage my submission properly.”
Tasks
Steps needed to achieve this feature.
Delete second bullet 'this agreement must be finished in one session"
Edit second Button "You can save your progress, it will be auto saved to the drafts folder"
New Bullet after "your session will time out..." "if you supervisor does not  process this telework agreement in 60, it will expire in this system."
Acceptance Criteria
The checklist the product owner uses to decide whether a story is done. Objective and discrete answers (such as a yes/no) that can be tested.

This is done through the release notes feature


Refactor use of name, tmp, show triplet

There are $2^3 = 8$ possibilities. Refactor so these are clear.
Possibly create a function to assist.
A possible implementation is using Val. E.g.,
function foo(::Val{true}, x)
  return x + 1
end

function foo(::Val{false}, x)
  return x - 1
end

function foo(x)
  if x > 0
    return foo(Val(true), x)
  else
    return foo(Val(false), x)
  end
end

Some notes on behaviour, for a given source:

source is a file:

name
tmp
show
remarks

non-empty
as provided
ignore
use get_table if you want a DF

empty
true
ignore
table name: "t_<safe_filename>"

empty
false->true
false
ditto

empty
false
true
returns DF (for debugging)

source is another table: TBD since now the scope of TIO also
includes API usage from TEM.


Transfer to python3 for use within ROS Noetic

I propose that a new branch for ROS Noetic is opened and this code is merged there (not on master)

Great, thanks for doing this. I created the ros-noetic branch where this can be merged.

Great, thanks for doing this. I created the ros-noetic branch where this can be merged.

I've redirected PR to ros-noetic branch

Thanks!


[KARAF-6279] Upgrade to Pax Web 7.2.10

NB: Pax Web 7.2.10 release is on the way, I will relaunch Jenkins for this PR when available on Maven Central.

retest this please

retest this please

retest this please

retest this please


Error: No named parameter with the name 'keyboardDismissBehavior'.

https://github.com/peng8350/flutter_pulltorefresh/blob/75f05219af3734690e1b7cfbdafe4f8d083d3ac6/lib/src/smart_refresher.dart#L434
Error: No named parameter with the name 'keyboardDismissBehavior'.
keyboardDismissBehavior:ScrollViewKeyboardDismissBehavior.manual,
^^^^^^^^^^^^^^^^^^^^^^^
../../../../Applications/flutter/packages/flutter/lib/src/widgets/scroll_view.dart#588 Context: Found this candidate, but the arguments don't match.
const CustomScrollView({
^^^^^^^^^^^^^^^^

I have the same issue, how did you fix it?

Found the fix, for others: https://stackoverflow.com/questions/65838381/flutter-run-error-no-named-parameter-with-the-name-keyboarddismissbehavior.

Download 1.6.3, change the folder name to 1.6.4, and then go to ../flutter/.pub-cache/hosted/pub.dartlang.org to replace 1.6.4.


"12 Pictures Downloaded"

I'd really prefer for my status to not be changed to the amount of pictures I've downloaded, but I can't seem to disable it. Display current game activity is off in Discord, but its just ignoring that in favor of this message.

I use a second account that I made just for this utility, that way my
friends don't see my status as downloading images
On Fri, Sep 28, 2018, 11:18 lopalop2<EMAIL_ADDRESS>wrote:

I'd really prefer for my status to not be changed to the amount of
pictures I've downloaded, but I can't seem to disable it. Display current
game activity is off in Discord, but its just ignoring that in favor of
this message.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Seklfreak/discord-image-downloader-go/issues/107, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AYGgAT1ZtEm5VoTSTW0afcpkLd6hqd-qks5ufmftgaJpZM4W_PS2
.

That is what I'm doing now, but it seems like more of a workaround than a solution.

In main.go try commenting out the two lines which call updateDiscordStatus()
On Fri, Sep 28, 2018, 11:55 lopalop2<EMAIL_ADDRESS>wrote:

That is what I'm doing now, but it seems like more of a workaround than a
solution.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Seklfreak/discord-image-downloader-go/issues/107#issuecomment-425533312,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYGgAV-4mmGW71V1pGvgth5zNgcrtXbFks5ufnC_gaJpZM4W_PS2
.


In-protocol consolidation - target not liable

Extends MaxEB https://github.com/michaelneuder/consensus-specs/pull/3 to allow in-protocol consolidation.
A Consolidation operation moves all balance from validator source to validator target without leaving the active set. This operation is authorized by the source withdrawal credentials, and the target validating key.
Slashing liability
In this implementation

source is liable for target's slashable offenses before the consolidation event
target is not liable for source's slashable offenses before the consolidation event

Rationale
To get around the binary nature of slashed status, if the source validator is slashed, it is "un-consolidated" from the target validator. The un-consolidated validator transitions from exited to slashed and active. It will not participate in duties but it will re-use the existing validator record to track exit queue churn and correlated penalties

Closing in favour of

https://github.com/michaelneuder/consensus-specs/pull/14


Fix unembed_response for embeddings larger than the source bqm

Closes #256

Codecov Report

Merging #259 into master will decrease coverage by 0.1%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   94.44%   94.33%   -0.11%
==========================================
  Files          31       31
  Lines        1799     1801       +2
==========================================
  Hits         1699     1699
- Misses        100      102       +2

Impacted Files
Coverage Δ

dimod/embedding/transforms.py
95.83% <60%> (-1.31%)
:arrow_down:

dimod/response.py
84.77% <0%> (-0.42%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ebac58...3f86b92. Read the comment docs.


MAINT: Remove unused futures related methods from asset finder.

These methods became unused during the course of reworking futures to support
continuous futures.

Coverage increased (+0.08%) to 87.323% when pulling 24f78a1d59f0fd9534c2578b3fb3bf3f9e820593 on remove-unused-future-methonds-from-asset-finder into eb2e7d8a97a22a62646057947305b15560f9db7d on master.


Right to Left direction does not work when a list is activated

I've set my text direction as right-to-left in Chrome. When I type normally, everything is good. However, when I click on the bulleted list, the text direction reverts to left-to-right direction. See the problem is action below:

I reproduced the problem above on the Squire demo integration.

This is because the dir="rtl" attribute is on the <li> rather than the <ul>. If you're only expecting users to use an rtl language, you could just set a dir="rtl" attribute on the div representing the whole editable area. Fixing this on a more fine-grained level is tricky.


Editing warps bug

Factorio version
Version number: 1.0.0
Scenario version
Version number: 6.1
Bug description
When editing a warp or after confirmed / canceled the action all warps are enabled whether or not you are actually able to.
Expected behavior
Enabled state not changing on edit

This should have been fixed by pr #190 but will need to confirm this.

I have now confirmed that this bug is fixed following the merge of the pr.


readme: add banner and cleanup

I forgot the README snippets were tested with tuttest.
With the scripts absent there's nothing to be tested so let's also have this workflow removed in this PR: https://github.com/hdl/conda-misc/blob/master/.github/workflows/tuttest.yml


fix driver:local in prefixing volumes with current dir name

If we have a docker-file with root level volumes and we do a kompose up using that docker-file, libcompose will add an additional _ followed by the current directory name.
docker-compose.yml used
version: '2'
services:
  mariadb:
    image: 'bitnami/mariadb:latest'
    volumes:
      - 'mariadb-data:/bitnami/mariadb'
    environment:
      - MARIADB_USER=bn_wordpress
      - MARIADB_DATABASE=bitnami_wordpress
      - ALLOW_EMPTY_PASSWORD=yes
  wordpress:
    image: 'bitnami/wordpress:latest'
    ports:
      - '80:80'
      - '443:443'
    volumes:
      - 'wordpress-data:/bitnami/wordpress'
      - 'apache-data:/bitnami/apache'
      - 'php-data:/bitnami/php'
    depends_on:
      - mariadb
    environment:
      - MARIADB_HOST=mariadb
      - MARIADB_PORT=3306
      - WORDPRESS_DATABASE_USER=bn_wordpress
      - WORDPRESS_DATABASE_NAME=bitnami_wordpress
      - ALLOW_EMPTY_PASSWORD=yes
volumes:
  mariadb-data:
    driver: local
  wordpress-data:
    driver: local
  apache-data:
    driver: local
  php-data:
    driver: local

- apiVersion: v1
  kind: PersistentVolumeClaim
  metadata:
    creationTimestamp: null
    labels:
      io.kompose.service: kompose_apache-data
    name: kompose_apache-data
  spec:
    accessModes:
    - ReadWriteOnce
    resources:
      requests:
        storage: 100Mi
  status: {}
- apiVersion: v1
  kind: PersistentVolumeClaim
  metadata:
    creationTimestamp: null
    labels:
      io.kompose.service: kompose_php-data
    name: kompose_php-data
  spec:
    accessModes:
    - ReadWriteOnce
    resources:
      requests:
        storage: 100Mi
  status: {}
kind: List
metadata: {}

$ kompose -f docker-compose.yml up
WARN Unsupported root level volumes key - ignoring
WARN Unsupported depends_on key - ignoring
INFO We are going to create Kubernetes Deployments, Services and PersistentVolumeClaims for your Dockerized application. If you need different kind of resources, use the 'kompose convert' and 'kubectl create -f' commands instead.

INFO Deploying application in "default" namespace
INFO Successfully created Service: mariadb
INFO Successfully created Service: wordpress
FATA Error while deploying application: Deployment.extensions "mariadb" is invalid: [spec.template.spec.volumes[0].name: Invalid value: "komposefiles_mariadb-data": must match the regex [a-z0-9]([-a-z0-9]*[a-z0-9])? (e.g. 'my-name' or '123-abc'), spec.template.spec.containers[0].volumeMounts[0].name: Not found: "komposefiles_mariadb-data"]

Since kubernetes doesn't allow _ in the objects created so kompose up will fail to deploy it.
As a solution we replace _ to - and we can then deploy it successfully.
$ kompose -f docker-compose.yml up
WARN Unsupported root level volumes key - ignoring
WARN Unsupported depends_on key - ignoring
INFO We are going to create Kubernetes Deployments, Services and PersistentVolumeClaims for your Dockerized application. If you need different kind of resources, use the 'kompose convert' and 'kubectl create -f' commands instead.

INFO Deploying application in "default" namespace
INFO Successfully created Service: mariadb
INFO Successfully created Service: wordpress
INFO Successfully created Deployment: mariadb
INFO Successfully created PersistentVolumeClaim: komposefiles-mariadb-data
INFO Successfully created Deployment: wordpress
INFO Successfully created PersistentVolumeClaim: komposefiles-wordpress-data
INFO Successfully created PersistentVolumeClaim: komposefiles-apache-data
INFO Successfully created PersistentVolumeClaim: komposefiles-php-data

Your application has been deployed to Kubernetes. You can run 'kubectl get deployment,svc,pods,pvc' for details.

- apiVersion: v1
  kind: PersistentVolumeClaim
  metadata:
    creationTimestamp: null
    labels:
      io.kompose.service: kompose-apache-data
    name: kompose-apache-data
  spec:
    accessModes:
    - ReadWriteOnce
    resources:
      requests:
        storage: 100Mi
  status: {}
- apiVersion: v1
  kind: PersistentVolumeClaim
  metadata:
    creationTimestamp: null
    labels:
      io.kompose.service: kompose-php-data
    name: kompose-php-data
  spec:
    accessModes:
    - ReadWriteOnce
    resources:
      requests:
        storage: 100Mi
  status: {}
kind: List
metadata: {}

CC: @kadel @cdrage
Fixes #550

@procrypt this doesn't seem to work, here's the full test (using Compose file from https://github.com/kubernetes-incubator/kompose/issues/554#issuecomment-294752322). Note that version says 0.4.0, but the SHA is correct.
[dkarlovi@fredo kompose_underscore-test]$ kompose version
0.4.0 (87fa7cb)
[dkarlovi@fredo kompose_underscore-test]$ pwd
/home/dkarlovi/Development/R&D/DevOps/Kubernetes/kompose_underscore-test
[dkarlovi@fredo kompose_underscore-test]$ kompose -f underscore-pvc.yml convert --stdout | grep PersistentVolumeClaim -A 5
WARN Unsupported root level volumes key - ignoring
WARN Unsupported depends_on key - ignoring
WARN Unsupported hostname key - ignoring
WARN Kubernetes provider doesn't support build key - ignoring
  kind: PersistentVolumeClaim
  metadata:
    creationTimestamp: null
    labels:
      io.kompose.service: komposeunderscoretest_broker
    name: komposeunderscoretest_broker
--
  kind: PersistentVolumeClaim
  metadata:
    creationTimestamp: null
    labels:
      io.kompose.service: komposeunderscoretest_cache
    name: komposeunderscoretest_cache
--
  kind: PersistentVolumeClaim
  metadata:
    creationTimestamp: null
    labels:
      io.kompose.service: komposeunderscoretest_db
    name: komposeunderscoretest_db

I've figured it out: if you leave the root-level volumes: block, it doesn't work. If you remove it, it does work.
kompose says it's ignoring it, but that doesn't seem to be the case.

@dkarlovi Did you build kompose correctly after fetching my branch. It seems to work fine when I run kompose convert, Please take a look at the output below using the docker-compose file you provided.
$ kompose convert -f dev.yml --stdout  | grep PersistentVolumeClaim -A 5
WARN Unsupported root level volumes key - ignoring
WARN Unsupported depends_on key - ignoring
WARN Unsupported hostname key - ignoring
WARN Kubernetes provider doesn't support build key - ignoring
  kind: PersistentVolumeClaim
  metadata:
    creationTimestamp: null
    labels:
      io.kompose.service: komposefiles-broker
    name: komposefiles-broker
--
  kind: PersistentVolumeClaim
  metadata:
    creationTimestamp: null
    labels:
      io.kompose.service: komposefiles-cache
    name: komposefiles-cache
--
  kind: PersistentVolumeClaim
  metadata:
    creationTimestamp: null
    labels:
      io.kompose.service: komposefiles-db
    name: komposefiles-db

Please make sure you build kompose correctly and try it again.

@procrypt @dkarlovi , its working for me,
$ kompose version
0.5.0 (HEAD)

output is:
$ kompose convert -f docker-compose.yml --stdout  | grep PersistentVolumeClaim -A 5
WARN Unsupported root level volumes key - ignoring
WARN Unsupported depends_on key - ignoring
  kind: PersistentVolumeClaim
  metadata:
    creationTimestamp: null
    labels:
      io.kompose.service: procrypt-mariadb-data
    name: procrypt-mariadb-data
--
  kind: PersistentVolumeClaim
  metadata:
    creationTimestamp: null
    labels:
      io.kompose.service: procrypt-wordpress-data
    name: procrypt-wordpress-data
--
  kind: PersistentVolumeClaim
  metadata:
    creationTimestamp: null
    labels:
      io.kompose.service: procrypt-apache-data
    name: procrypt-apache-data
--
  kind: PersistentVolumeClaim
  metadata:
    creationTimestamp: null
    labels:
      io.kompose.service: procrypt-php-data
    name: procrypt-php-data

Make sure you are building from this PR only:
 git fetch upstream pull/557/head:driver_local

@surajnarwade  @procrypt if it's working for you two, let's just assume I've PEBKACed because of my inexperience with Go and that it works for me too, I just can't reproduce it. :)
I've followed the instructions to check out the PR branch locally, did a build and my kompose version still doesn't say HEAD, it states the exact commit SHA1.
Here's what I did:
[dkarlovi@fredo kompose]$ git remote
origin
[dkarlovi@fredo kompose]$ git fetch origin pull/557/head:driver_local
From https://github.com/kubernetes-incubator/kompose
 * [new ref]         refs/pull/557/head -> driver_local
[dkarlovi@fredo kompose]$ git checkout driver_local
Switched to branch 'driver_local'
[dkarlovi@fredo kompose]$ git branch -vv
* driver_local 12808ac vendor_update
  master       46426fb [origin/master] Merge pull request #558 from cdrage/add-dependencies-to-makefile
[dkarlovi@fredo kompose]$ make
go build -ldflags="-w -X github.com/kubernetes-incubator/kompose/cmd.GITCOMMIT=12808ac" -o kompose main.go
[dkarlovi@fredo kompose]$ cd ../kompose_underscore-test/
[dkarlovi@fredo kompose_underscore-test]$ ../kompose/kompose version
0.5.0 (12808ac)
[dkarlovi@fredo kompose_underscore-test]$ ../kompose/kompose convert -f underscore-pvc.yml --stdout | grep PersistentVolumeClaim -A 5
WARN Unsupported root level volumes key - ignoring
WARN Unsupported depends_on key - ignoring
WARN Unsupported hostname key - ignoring
WARN Kubernetes provider doesn't support build key - ignoring
  kind: PersistentVolumeClaim
  metadata:
    creationTimestamp: null
    labels:
      io.kompose.service: komposeunderscoretest_broker
    name: komposeunderscoretest_broker
--
  kind: PersistentVolumeClaim
  metadata:
    creationTimestamp: null
    labels:
      io.kompose.service: komposeunderscoretest_cache
    name: komposeunderscoretest_cache
--
  kind: PersistentVolumeClaim
  metadata:
    creationTimestamp: null
    labels:
      io.kompose.service: komposeunderscoretest_db
    name: komposeunderscoretest_db

@procrypt why this can't be fixed as it was done in https://github.com/kubernetes-incubator/kompose/pull/509 ?
I think here we need to normalize only in https://github.com/kubernetes-incubator/kompose/blob/master/pkg/loader/compose/compose.go#L341 ?

So with this we take care of it at source so we don;t have problems later since the data is scattered in all over the place?

@surajssd Thanks I have updated the PR.

@procrypt tests, functional ones.

Hey @procrypt ! Almost there. Could you update your commit messages with what you wrote here? Otherwise, code LGTM.

code lgtm. Can you explain the main update in glide @procrypt ?

Same question here. what was reason for updating those vendored libraries?

@procrypt @kadel Can you help to make sure this PR being merged in the upcoming release this week? We have some Bitnami compose files need this fix on this iteration (end by next Thursday). I tested it. The only concern from me is the vendor update.

@cdrage @kadel @ngtuna I don't think vendor update is required so I removed it.

@procrypt LGTM :)

Ideally some tests should be added, but I don't see any issues arising because of this.
LGTM.
@kadel Wanna have a quick-lookover this before we merge this in before today's release?

@cdrage I'm adding the tests in a while.

I am gonna merge this as all reviewers have approved.


Graphical Context Map in VSC: Be able to configure generation folder and generated file types

Hello! I'm using Context Mapper in Visual Studio Code in a documentation only project. I have some suggestions to improve the workflows with the extension to make it leaner and easier to use:
The graphical context map is always generated into the folder <projectRoot>/src-gen. It would help if this path is configurable in the settings when the extension is used in non-Java projects that have different folder structures.
Additionally, when generating the graphical context map the user has to select the file types (png, svg, dot with all preselected by default). Within a project the team usually decides which formats to use and does not want to select the file type every time the file is generated. Therefore it would help if the file types are configurable in the settings and that the selection dropdown only shows up if there is no specific configuration in the settings.

Thanks @dArignac for reporting your suggestions! I am aware that the usability in the extension can be improved and I like your ideas.
I hope we can do something here soon; time permitting :) PRs are of course always welcome as well...


[Paginator] Please add hidePageRangeActions property for mat-paginator just like hidePageSize

Feature Description
Hi, I was using mat-paginator and I wanted to give a feature request. I do not want range action div in paginator.
So can we add a property in mat paginator named as @Input() hideRangeActions: boolean just like @Input() hidePageSize: boolean

Use Case
If I have set the property hideRangeActions = "true" then below div will hide and only page size div will be coming

Validation
If I am using mat-paginator then only one of the input property can be true not both hideRangeActions = "true" or hidePageSize = "true"

It wouldn't be much of a paginator if the actions were hidden since the user won't have the ability to change the page.

@crisbeto User can change the page size which will show the number of results according to items per page drop-down selected value. So one of the property should be false as I wrote validation above.

I don't think we would add an option for this since I think it's somewhat of an edge case to not want to support actually changing pages. It may make sense to swap this out for a custom component. You could also use display: none on that part of the control, but this is brittle since the DOM structure of the component could change over time.


CreateSubscription() receives data updates from simulated tags fluently, but not from actual PLC data updates, possible reason?

Connecting to GE IGS,
CreateSubscription() receives data updates from simulated tags fluently, but not from actual PLC data updates except for initial update immediately after subscription, no more data received, possible reason?
UaExpert monitors fluently too.
double requestedPublishingInterval = 0;
uint maxNotificationsPerPublish = 2000;
byte priority = 0;

if (IsGood(CreateSubscription(requestedPublishingInterval, maxNotificationsPerPublish, true, priority, out uint subscrId)))
{
                SetPublishingMode(true, [subscrId], out uint[] respStatuses);

                var monitorRequests = tagsToMonitor.Select((i, n) => new MonitoredItemCreateRequest(i,
                    MonitoringMode.Reporting, new MonitoringParameters((uint)n, 0, null, 100, false))).ToArray();

                if (IsGood(CreateMonitoredItems(subscrId, TimestampsToReturn.Both, monitorRequests, out MonitoredItemCreateResult[] monitorCreateResults)))
                {...}
}

I made a test program exactly with the TestClient code from LibUA demos (the latest pull), in which:
client.CreateMonitoredItems(subscrId, TimestampsToReturn.Both,
                [
                    new MonitoredItemCreateRequest(
                        new ReadValueId(new NodeId(2, args[1]), NodeAttribute.Value, null, new QualifiedName()),
                        MonitoringMode.Sampling,
                        new MonitoringParameters(clientHanlder, 500, null, 100, false)),
                ], out monitorCreateResults);

above code monitors nothing, not even the initial updates, neither simulated nor real PLC tags.
change to MonitoringMode.Reporting, above code works well with simulated tags but not for my PLC tags.
while UaExpert always monitors ok.

Can you share a Wireshark capture with security set to None with Wireshark, then with your libua client?

Sorry, not possible so far, it's found in a production environment. I don't even have similar environment to reproduce it locally, as is my headache too, otherwise, i would have located the line causing the problem in the source.
Finally, I had to reimplemented and done the client with h-opc-cli, and it works perfectly after i forked it and made minor changes.
If any further discover, i'll infom here.

It's difficult to say what might be different because it could be anything from subscription configuration to connection/auth configuration.


Add Travis Support

If you add Travis to this project all the push and all the PR can be tested on multiple platfork. See Build Matrix

I've been wanting to do that for a while, it's in my todo list for the Swift-1.2 release.


Short solution needed: "Get dot product of arrays" (python-numpy)

Please help us write most modern and shortest code solution for this issue:
Get dot product of arrays (technology: python-numpy)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

Get dot product of arrays/matrices


Missing target OS and ROS2 version in Installation instructions

In the installation instructions found here, it would be good to state clearly what are the supported OS, ROS2 versions and FRI versions.
Also the requirements are missing, e.g. installed ros2-humble-desktop-full

openjournals/joss-reviews#6138

the requirements are resolved using rosdep:
rosdep install --from-paths src -i -r -y

I will try to explicitly state the ROS version, although it is already hinted at in the instructions, source /opt/ros/humble/setup.bash.
I agree that the OS is assumed to be Ubuntu. This should be fixed. Ideally, Windows support should be added here

added individual build status in https://github.com/lbr-stack/lbr_fri_ros2_stack/pull/203


Improve documenatation of which files matter in App Designer

App Designer ships with a bunch of example files that should be deleted. Improve documentation of which files shouldn't be changed and why
From the 2019 convening: https://docs.google.com/document/d/1_4x9x3eHxo4qevBRlpmCC9L2bVlUkAQuAlidT8wJDzI/edit#heading=h.264josm5lg7

Some progress has been made in explaining files and also the grunt command to empty things out is documented:
https://docs.odk-x.org/getting-started-2-architect/?highlight=wipe#useful-grunt-commands


fix/load dotenv

Types of changes

[ ] Bug fix (a non-breaking change which fixes an issue)
[x] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
in nuxt.config.js
When accessing the env property as process.env.variables, you were looking at dotenv unconditionally.
Depending on the value of NODE_ENV I wanted to switch dotenv. This is because nuxt.config.js can get values for the desired environment from process.
Checklist:

[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[x] All new and existing tests are passing.

Hi, @katanazero86 thanks for PR. But at least with the current version, this is intentional behavior. Please see here for why.
You can specify alternative dotenv file when starting with --dotenv argument. And can also use it in package.json:
"scripts": {
   "dev": "nuxt dev --dotenv .env.dev
}

@pi0
Hi.
Thanks for the quick feedback, and thanks for sharing the link to the article!
I am glad that I am learning one thing like this.
Watch out for COVID-19 and hope you have a happy day.
Thank you!


[Bug] Sonarr’s dates don’t work

Sonarr dateadded & firstairdate don’t work because they return their date as text instead of a date object.

This wasn't an issue for Radarr.

:tada: This issue has been resolved in version 1.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[DDC] Create incremental mode in DDC for evaluation

Short description
Make ProgramCompiler.emitFunctionIncremental define symbols used in emitted JavaScript.
Problem
dartdevc's ProgramCompiler is does not currently support incremental compilation, which is needed for expression evaluation. We created workarounds for  incremental function compilation to work, which are good for initial implementation but need to be replaced by proper implementation for stability.
Expression evaluation needs to be able to compile dart expressions to JavaScript snippets that can be evaluated in the browser in scope of the current breakpoint. Currently the JavaScript generated by ProgramCompiler.emitFunctionIncremental is missing symbol definitions for symbols used in the evaluated expression.
As a temporary workaround, current implementation of ExpressionEvaluator (in dwds) sends supporting information to the ExpressionCompiler (in dartdevc), which uses it to create additional statements defining symbols for libraries and fields.  This workaround might break on ddc changes, and does not support all module systems.
Example
class Class {
  final int field;
  final int _field;
  Class(this.field, this._field);
}

void main() {
  var instance = Class(1, 2);
  print('$instance'); // ** Breakpoint here **
}

To evaluate the expression instance._field on breakpoint here line, expression compiler produces the following JavaScript code:
function(local, instance) {
  let web__main = require('web/main').web__main;
  let _field = dart.privateName(web__main, "_field");
  return instance[_field];
}

where only the statement  return instance[_field]; is actually produced by the ddc. The first two are generated inside the expression compiler, and are needed to re-define symbols used in the produced JavaScript but not necessarily available in the current scope.
Suggestion:
The program compiler has all the information needed to define the library and symbols variables. We can make emitFunctionIncremental emit  code that can be evaluated in the current scope without workarounds:
In general, for every symbol used in the evaluated expression, we need to re-define the symbol's variable and and, transitively, all symbols used in that definition. The symbols might include fields, types, constants, libraries, etc.
After that, we can remove the workaround code and all no longer needed supporting information send from the debugger, to minimize data transfer.
Follow up with changes in dwds
https://github.com/dart-lang/webdev/issues/1139
Related
https://github.com/dart-lang/sdk/issues/44979
https://github.com/dart-lang/sdk/issues/44713
https://github.com/dart-lang/sdk/issues/44713
https://github.com/dart-lang/sdk/issues/44933
https://github.com/dart-lang/sdk/issues/44813
https://github.com/dart-lang/sdk/issues/44686

replaced by https://github.com/dart-lang/webdev/issues/1139 with better explanations.

/cc @nshahan, @Markzipan - note that this relates to our general conversation about encapsulating DDC's output.
@annagrin - in general, we have been discussing to get to a place where DDC's output is sealed better. We'd like for everything it emits to be self contained or explicitly exposed using a js API. For expression evaluation, we had discussed that we would attach to each library/module objects exposing what an incremental output would need. That way the output of emitFunctionIncremental can access everything it needs without using an enclosing scope.
Besides expression evaluation, we want to similarly shift to generate the bootstraping logic to the DDC codebase. We've noticed that bootstrappers in flutter tools and webdev are using DDC's output directly in ways that may not be robust or easy to detect for us whether we are breaking an unspoken convention

@sigmundch definitely, that would be our next step after collecting feedback during dogfooding - I presume that proper encapsulation will require some design and bigger compiler changes.


Cleaning, fitting with paper conventions, and adding docstrings

…ns_utils, rename variables according to paper

Update readme describing what the various "examples" scripts do


When attempting to register Windows worker nodes to a RKE2 cluster, the rancher-wins service is unable to start

Rancher Server Setup

Rancher version: v2.6.5-rc9
Installation option (Docker install/Helm Chart): Helm Chart

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc):

Proxy/Cert Details:

Information about the Cluster

Kubernetes version: v1.22.9+rke2r2
Cluster Type (Local/Downstream): Downstream

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider): Custom

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom) Standard

If custom, define the set of permissions:

Describe the bug

When attempting to register a Windows node to an RKE2 cluster, I am seeing the following error:
INFO: Windows feature: 'Containers' is installed. Installation will proceed.
INFO: Using default agent configuration directory C:/etc/rancher/wins
INFO: Using default agent var directory C:/var/lib/rancher/agent
INFO: Successfully tested Rancher connection.
INFO: Checking if rancher-wins service exists
INFO: rancher-wins isn't installed, continuing
INFO: Downloading Wins from https://FQDN/assets/wins.exe
INFO: Successfully downloaded the wins binary.
INFO: Generating Cattle ID
INFO: Successfully downloaded Rancher connection information.
INFO: Checking if rancher-wins service exists.
INFO: rancher-wins service not found, enabling agent service.
INFO: Starting rancher-wins service.
Start-Service : Service 'Rancher Wins (rancher-wins)' cannot be started due to the following error: Cannot start
service rancher-wins on computer '.'.
At C:\Users\Administrator\install.ps1:658 char:9
+         Start-Service -Name $serviceName
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OpenError: (System.ServiceProcess.ServiceController:ServiceController) [Start-Service],
   ServiceCommandException
    + FullyQualifiedErrorId : CouldNotStartService,Microsoft.PowerShell.Commands.StartServiceCommand

This is a regression occurring from issue https://github.com/rancher/rancher/issues/37628, but since it is different from that original issue, we will track this error in this new issue.
To Reproduce

Setup Rancher and navigate to the UI in a browser.
Create a standard user and login to Rancher as that user.
Create a custom RKE2 cluster and add Window worker nodes.
In Powershell, verify that you see the above error messages.

Result
Windows worker nodes are unable to register to the created RKE2 cluster.
Expected Result

Windows worker nodes should be able to register to the created RKE2 cluster.

After side conversations, we will close this issue out and keep the original issue out as it is all related and will be easier to track.


SWS-182 Improve layouting

Before this change. the details node would sometimes be placed into the 'reviews' box.
The change tells the layout engine to make adjustments after the first round.
Also the spacing factor has been reduced so that nodes are closer together.
Now with this change:

https://issues.jboss.org/browse/SWS-182
See also #65 for some changes to coloring.

Pull Request Test Coverage Report for Build 151

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 29.749%

Totals

Change from base Build 147:
0.0%

Covered Lines:
168

Relevant Lines:
475

💛  - Coveralls


Consider integrating with React Axe

https://github.com/dequelabs/react-axe/
React Axe would handle all of the DOM analysis for us so we wouldn't be recreating the wheel here. We would get the added benefit of having warnings synchronized between the console and the browser window as well.
I am not even sure if it's really possible at this point, as it doesn't look like react-axe exposes its logic. We might also consider forking it and exposing logic as a hook that we can use for both console warnings and our overlay components. Thoughts?

Interesting idea!
I'm not sure if this would be worth it for a couple of reasons:

I feel like the overlays are superior to console warnings, which are just a bunch of messages that are hard to decipher and link to a specific node. I mean, if you want the console logs, then maybe using react-axe should be used instead?
Our component variant is much more flexible in its application. Meaning, you don't have to run axe on your entire app, but wrap it around components. I didn't look too closely at the implementation of react-axe, so maybe it could be modified to only run on specific component trees.
I don't see react-axe doing anything special in terms of DOM analysis. It just seems to format the violations and print them to console.

Yeah, I haven't vetted the idea thoroughly so it's possible there are some gaps. I want to explore it a bit more before adding to the conversation.
As far as not needing console logs, perhaps that's true. But I like waving as many flags as possible if they can nudge developers in the right direction. That would be my main motivation for adding them.


Configuration Cache compatible version of the Capture thermal throttling sample

I initially created this PR to capture thermal throttling.
Using buildFinished hook made it incompatible with configuration cache.
Inspired by this, I adjusted the implementation which is now working fine when configuration cache is enabled

Using GE plugin is the way to go


ZREST_UTIL has Corelation ID always set as 0 for servicebus POST

Transaction ZREST_UTIL has Corelation ID always set as 0 for service bus POST scenario and there is always only one entry in ZREST_UTIL as a result of this. I did some debugging and figured that the problem is in method SET_GUID of class ZCL_REST_FRAMEWORK. The return parament "GUID" never gets populated with any value within the method SET_GUID but the calling program of the method is expecting a value to be returned and the returned value is being used for further processing which happens to be null in this scenario.

Hello @smithesht - Thanks for reaching out to us on your query. Please could you check what value is maintained in 'REPROCESS' field  of Table 'ZADF_CONFIG'. It should be left blank and this field is reserved for future versions use. Thanks, Krishna

Yes, I changed the 'REPROCESS' field as blank in table 'ZADF_CONFIG' and did not fix the issue. Looks like the resolution is to make 'REPROCCESS' table field blank and also make a minor change to the method SET_GUID of class ZCL_REST_FRAMEWORK by populating value into return parameter 'GUID'. I have made this change in my instance of code and seems to have fixed the issue.

Thanks @smithab - Smitha for sharing the correction and feedback. Please could you share a pull request for the commit. We are also in the process of testing the same in our staging environment as it seems there is some difference in version of the code in master branch with our staging environment. Thanks, Krishna

I am not sure how to share a pull request. I use the offline version of ABAPGit.

hi, depending on the size of your change, you can either do the changes online, https://help.github.com/en/github/managing-files-in-a-repository/editing-files-in-your-repository
or use abapGit to download the package as zip, extract the zip, and use a normal git client from there


Refactor integration test app paging

What does the pull request do?
#15542 started causing integration tests to fail on Windows and I had no idea why until I managed to get a screen recording (see #16546). Turns out that our integration tests run on a really small screen and adding the "Embedding" tab caused our tabs to expand to 3 columns, leaving little room for the content:

Besides that, all tabs being defined in the MainWindow.xaml file was getting a bit unwieldy anyway.
This PR refactors the IntegrationTestApp to use a ListBox to handle the paging (which will ensure that the tabs don't grow horizontally) and moves each page into its own view (to ease of mantenence):

Because paging now potentially requires scrolling to offscreen elements, I had to add support for the UIA IsOffscreen property in order for WinAppDriver to scroll elements into view.
It also moves selecting the page in the test project to a base class as we may need to handle scrolling manually on macOS at some point (Appium on macOS doesn't scroll elements into view automatically) - this isn't a problem yet as the items fit comfortably on-screen on macOS.

Why isn't FromClip the default? It seems to represent "the right thing" when thinking about offscreen elements

It's a very good question and I don't know the answer; WPF and UWP do it like this so I just copied them, which is what we generally do as a default these days.


*: rename repo from pingcap/ticdc to pingcap/tiflow

What problem does this PR solve?
Finish step-6 in https://github.com/pingcap/tiflow/issues/3749 for release-4.0
What is changed and how it works?

Run the following script

sed -i "s/github.com\/pingcap\/ticdc/github.com\/pingcap\/tiflow/g" $(find . -type f|grep -vE "bin/|.git")
sed -i "s/pingcap\/ticdc/pingcap\/tiflow/g" $(find . -type f|grep -vE "bin/|.git")
make fmt

Change project name from ticdc to tiflow in Makefile

Check List
Tests

Unit test
Integration test

Release note
None

/run-all-tests

/merge


Move the details of C99 identifier mangling out of ProjectModel

Move the details of C99 identifier mangling out of ProjectModel and down into Basic.  It looks as if at some point this was meant to be able to fail because it might remove all the characters and end up with an empty string, but now that it replaces characters it doesn't seem possible for it to end up with an empty string assuming it was given a non-empty string.

I wonder if this should be in utilities

The previous version would throw if the result was an empty string, because it doesn't mangle the first character (IIRC)?

@aciidb0mb3r Yes, Utilities would probably be better.  I put it together with the shell escaping code, but Utilities is probably a better home for both of them.

@ddunbar I addressed this in the commit message actually.  It looked like the code had originally been written to potentially remove invalid characters, which could lead to an empty string even when the input wasn't empty.  But at least in the sate of the code as I found it, that couldn't happen, since it always replaced unsupported scalars with _.  Also, the error being thrown was project-model related and not about C99 identifier mangling in general.  We can make it throw again, but I think the better thing to do is to either: a) precondition that the string isn't empty, or b) make sure the output string is never empty.  If the point here is to take an arbitrary input string and make it valid C99, it doesn't seem that throwing is a good solution.

And as I mentioned, I don't think it would actually ever throw, because it no longer makes the string shorter.

Ah, I see your point. I do remember it doing that at one point, it must have changed (for all I know it might have been me that changed it at some point).

@aciidb0mb3r @ddunbar  Do you think this should be in Utilities instead?  If so, shouldn't the shell-escaping code also move down?

I do think this should be in Utilities because this is not general enough for basic. I am not sure about shell escaping, It feels like a Basic thing but I wouldn't mind it being in utilities.

I agree Utilities seems better although I would feel much happier about that if we had a good name for Utilities.

Ok.  I will move this to Utilities and possibly move ShellEscaping in a separate PR.

This got stalled, going to make the discussed changes, test, and merge this now.  I am not going to rename Utilities at the moment, would be a different PR.

@swift-ci please test

(that test was requested to see if the CI incremental-build changes are working — I know this still needs to be rebased)

@swift-ci please test linux

@swift-ci please test linux platform

@swift-ci please test

@swift-ci please test

I've moved it to Utilities now.  I'll also add a performance test, but wanted to update the PR and kick off the correctness testing.

Hmm, those failures suggest that not all the diffs got pushed to the PR (I specifically fixed the problem it's erroring out about).  Investigating.

Turns out I hadn't pushed the latest changes.  Testing again.

@swift-ci please test

The Linux failure is puzzling, since apparently the build and the tests all succeeded.  The failure seems to be in the automation that happens after that.

I'll do some more local testing before merging.


Set min anchor channel fee to 1 sat/vbyte

With us moving to the Zeus LSP that is lnd based, we could get force closes because lnd sets a max anchor channel fee, to make sure our min fee is never above lnd's max, we just set our min fee to 1 sat/byte to be safe.

Recent changes are just because anchor channels are new to us


Need function similar to queryObject that unprojects coords when nothing is selected

This is needed to complete deck.gl support for using external event handling.
See discussion in #818.

Duplicate of (part of) #2151


DBT + SQL Grammar

Hi 👋
It seems like this grammar is only for the jinja template. Is there a grammar I can use to parse the SQL + jinja dbt model code?

One option could be using existing SQL tree-sitter parsers in conjunction with this one, but the dialects they support are limited. :/


how to map a nested pojo

I have a User Entity ,and User have a UserDetail  ,I want to seprate  them
@HBTable("User")
public class User implements HBRecord {
	@HBRowKey
	private String id;
	@HBColumn(family = "user", column = "name")
	private String name;
	@HBColumn(family = "user", column = "email")
	private String email;
	@HBColumn(family = "user", column = "password")
	private String password;

      //just familyColumn,   detail Columns  in Another class
	@HBColumn(family = "detail", column = "")
	private UserDetail  detail;

	@Override
	public String composeRowKey() {
		return id;
	}

	@Override
	public void parseRowKey(String rowKey) {
		this.id = rowKey;
	}
}

detail Columns  in Another class

public class UserDetail{
	@HBColumn(family = "detail", column = "address")
	private String address;
	@HBColumn(family = "detail", column = "photo")
	private String photo;
}

can you give me some advice? thanks

@geosmart I see that you intend to keep two columns address and photo (under the same family detail) in separate class. Currently, nested POJOs are not supported.
However, if you're ok with it, you can try either of the 2 alternatives:

Annotate fields in UserDetail class with JsonProperty so that you can use it as below:

@HBColumn(family = "user", column = "detail")
private UserDetail  detail;

(as you know, above will serialize the UserDetail object into a JSON string with column name detail

Move address and photo to User class (call it UserRaw or something). You can create a class User that acts as a wrapper class around UserRaw class that has the desired subclasses like User.Details etc

Thankyou,as your answer, finally I have move the nested POJO as Json property


Use sBTC wallet in favor of peg wallet or dkg wallet

My understand is that the best term is "sBTC wallet" to describe the wallet holding the deposited BTC. Not peg wallet or dkg wallet.
Search revealed that peg wallet is used at least once in the current docs on main. See also https://github.com/stacks-network/sbtc/issues/278

All docs updated


Cannot send minimum long value (-2^63) with emit

Description of the problem
When trying to send the minimum int64/long value -2^63 via alt.emitServer in client code or IPlayer.Emit in server code, the other end just receives a 0.
The same thing happens when sending the uint64/ulong value 2^63 from the js client to the server, but sending the same value from server to client works as expected (this asymmetrical behaviour is probably explained by the fact that the js client does not check whether it should use MValueInt or MValueUInt, it just always converts a BigInt to MValueInt).
Reproduction steps
alt.emitServer('test', BigInt("-9223372036854775808"), BigInt("-9223372036854775807"), BigInt("9223372036854775808"), BigInt("9223372036854775809"));

[ClientEvent("test:test")]
public void TestEvent(User user, long a, long b, ulong c, ulong d)
{
        Console.WriteLine(a); // "0"
        Console.WriteLine(b); // "-9223372036854775807"
        Console.WriteLine(c); // "0"
        Console.WriteLine(d); // "9223372036854775809"
}

Expected behaviour
Sending -2^63 and 2^63 should work as they are a valid values for long or ulong respectively.
Additional context
No response
Operating system
Windows 10
Version
9.0-rc2

@LennartF22 Please try this again with the newest version of the module


Consider limitations of the AssemblyScript

The AssemblyScript doesn't support those features yet:

Type conjuction and disjunction

Therefore, it's not possible to extending the multiple interfaces

When generic extensions are composite, the compiler falls into the stack overflow
Virtual method is not implemented yet

Therefore, abstract class is vulnerable

Virtual method is not implemented yet

virtual methods should works in usual and abstract classes. If you have any problems with it plz fill issue

@MaxGraey Well, I saw that virtual method and abstract class are not supported yet from the below article.
https://github.com/AssemblyScript/assemblyscript/wiki/Status-and-Roadmap
Thanks for your replying.


Block human access to /metrics

/metrics only accessible internally now, /write accessible from outside via grafana auth.


Add display names to cache tasks in build

Pull Request Test Coverage Report for Build 541181757

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 43.538%

Totals

Change from base Build 539729717:
0.0%

Covered Lines:
24933

Relevant Lines:
52476

💛  - Coveralls


Can the code translate the other langurage

like the title, i hopefully it can be translated into other languages, not just English. But it's too hard for me. How do I change the code?

@FeiGenb
Hello FeiGenb
The app does not support languages other than English.
If you wish to support languages other than English, please translate the contents of "/web/index.html".
Please check Whisper for supported languages for voice input.


warn user if skipping migrations

If a user manually modifies the version in fern.config.json then we should warn if there were any skipped migrations.

+1 cool idea

Closing this issue because this is something we wont be working on.


Read black options in format_dev script

Summary
Comparing repos with black requires that we use the settings as black, notably line length and magic trailing comma behaviour. Excludes and preserving quotes (vs. a preference for either quote style) is not yet implemented because they weren't needed for the test projects.
In the other two commits i fixed the output when the progress bar is hidden (this way is recommonded in the indicatif docs), added a scratch.pyi file to gitignore because black formats stub files differently and also updated the ecosystem readme with the projects json without forks.
Test Plan
I added a line-length vs line_length test. Otherwise only my personal usage atm, a PR to integrate the script into the CI to check some projects will follow.

Current dependencies on/for this PR:

main

PR #5827   👈

This comment was auto-generated by Graphite.


Feature/705 no reconsent

need to merge this branch into https://github.com/Tonomy-Foundation/Tonomy-App-Websites/pull/95


Update flyway-core to 9.19.3

About this PR
📦 Updates org.flywaydb:flyway-core from 9.4.0 to 9.19.3
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (9.4.0).
You might want to review and update them manually.
core/src/main/scala/akka/persistence/postgres/db/ExtendedPostgresProfile.scala

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.flywaydb", artifactId = "flyway-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.flywaydb", artifactId = "flyway-core" }
}]

labels: test-library-update, early-semver-minor, semver-spec-minor, old-version-remains, commit-count:1

Superseded by #343.


2 Bugs + Suggestion

Suggestion:
Make the join guilds so that there can be guilds you need to join and be in to login and servers that you just auto join when you login.
Bug:

Registered role doesn’t work, doesn’t apply role at all.
Alt checking with cookies and IP’s are Broken

Ver: 0.4.4-alpha

On bug 2, to be more specific, its a false detection not a console error. Like in the url you can see ?ERR=ANTIALT but the user never was signed in on that account or an alt