Add the Concept Pages to Selector Class

Description:

We want to add the ability to display a specific amount of items with the selector per a certain amount of pages.
This will need to calculate the max number of pages based on the total number of items.

There are a few new functions that need to be added:

IncrementPage() -- Increments the page and adjusts the currentY value.
DecrementPage() -- Decrements the page and adjusts the currentY value.

There are a few functions that will need to be adjusted when the concept of pages are added:

MoveUp() -- This will need to adjust based if the current Y is greater than the max display rows * currentPage, Increment the page.
MoveDown() -- This will need to adjust based if the current Y is less than the max display rows * currentPage, Decrement the page.
Draw() -- The draw function will need to be adjusted to only draw the items for the current page.
SetData() -- The max pages needs to be clamped in some way. This should also be done in the CTOR.

Some more variables should be added to the SelectorParams:

int maxDisplayRows

The Selector class should also keep track of the currentPage and max pages:

int m_CurrentPage, m_MaxPages.

We may also want to add the ability to scroll the page down rather than change pages.
We would need to have flags to set if the selector uses scrolls or flips pages.
The scroll would need to shift where the display start it as you scroll down, the display start would increase by 1 if the currentY is greater than the max display rows.

New branch as created to address this feature.
feature-Add-Pages-and-Scrolling-to-Selector

SelectorPagesFiles.zip
My First Version of Selector with Page Functionality

Param for the number of Items per page
Go forwards or back a page with E/Q keys
Changes dynamically when m_Data is changed with SetData()
Page # Bar with customizable on-screen location (with centering on a given x coordinate)

Attached is a zip with a few things I have worked on. I have not finished the scrolling selector yet, but I have a (probably) working SelectorPages class found in SelectorPages.h. With it is a barebones game state for testing it out. My implementation is a bit messy, but it should serve as a solution to the original problem of too many options to fit on screen. I have not noticed any glairing bugs yet, but I have also not tested it with Items or Equipment. Further polishing is likely.
Just as a note, I refrained from making SelectorPages a child of Selector because I thought they should be considered entirely separate, even if conceptually similar. This doesn't have to be the case if you choose to implement it differently (and probably more cleanly) than I did.

@Brugoski Awesome, I will give this a look today or over the weekend. Thank you.

@Brugoski This looks great! It does look like it would work for sure. The way I started the implementation is different. I will do some more testing then push it to this branch.
I have changed the SelectorParams struct to this:
struct SelectorParams // I find this cleaner looking
{
	int x{ 20 }, y{ 10 }, columns{ 1 };
	int currentX{ 0 }, currentY{ 0 };
	int spacingX{ 20 }, spacingY{ 5 };
	int maxRows{ 1 };
	std::wstring cursor{ L"->" };
};

I only added the maxRows, removed the constructor, and added default initialization. I find that cleaner.
I then added the concept of the m_CurrentPage and m_MaxPages to the selector. For the drawing of the items, all you have to do is offset where you are looking at in the data vector to only see entries within the current page.
I should hopefully be done my testing today and push to the branch.
If my testing does not come out as desired, I will try to implement what you have done. The code looks good, and I like the idea of having the DrawPages as an std::function. That way, the user can determine how it is drawn.
Thanks.

@dwjclark11 Thanks for the feedback! I hope testing goes well, I suspected there might be a clean way of adding a page system into the original Selector. I'll look forward to seeing how you phrase the implementation.


Marketplace doesn't reflect the deprecated status

Testing microsoft/vscode#150746

Find a deprecated extension that is in the list of deprecated extensions and supports the new deprecated UI (redhat.vscode-wsdl2rest, auchenberg.vscode-browser-preview, ms-vscode.vscode-typescript-tslint-plugin)
Click on the extension to open the extension editor, click on the extension name to open the extension page in the browser
Note that there is no standardized indication that the extension is deprecated on the Marketplace page.

@kimadeline thanks for opening this issue. We designed the issue with this in mind, because Marketplace unfortunetly does not yet support the concept of deprecated extensions. We believe this will come in the future, so I will close this as a duplicate of https://github.com/microsoft/vsmarketplace/issues/23


Add note to readme how to install with npm

See https://forum.blockstack.org/t/importing-blockstack-js-as-a-script-like-https-cdn-blockstack-org-blockstack-min-js/5881

You can now import the library via unpkg
See script here: https://github.com/blockstack/blockstack.js/blob/master/mdincludes/script-dist-file.md


Rust: Add NL Autoweg 100km/h

The locale related parts of the code currently are getting a bit hairy.
I don't have a good design in mind, so I am waiting to implement some more so I can spot patterns before doing anything.

It matches quite nicely

except for the shoulders being much too wide. I will update the spec to add width to the shoulders as a separate PR.

Fibonacci/all_same_vec/small_vec
                        time:   [26.728 ns 26.750 ns 26.777 ns]
Found 10 outliers among 100 measurements (10.00%)
  1 (1.00%) low severe
  2 (2.00%) low mild
  6 (6.00%) high mild
  1 (1.00%) high severe
Fibonacci/all_same_hashmap/small_vec
                        time:   [102.27 ns 102.57 ns 102.94 ns]
Found 7 outliers among 100 measurements (7.00%)
  6 (6.00%) high mild
  1 (1.00%) high severe
Fibonacci/all_same_vec/big_vec
                        time:   [317.44 ns 318.72 ns 320.08 ns]
Found 7 outliers among 100 measurements (7.00%)
  4 (4.00%) high mild
  3 (3.00%) high severe
Fibonacci/all_same_hashmap/big_vec
                        time:   [5.6465 us 5.6609 us 5.6757 us]
Found 9 outliers among 100 measurements (9.00%)
  7 (7.00%) high mild
  2 (2.00%) high severe


Quiz exercises: Fix Synchronized Mode Due Date Validation

Checklist
General

[ ] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Client

[x] I followed the coding and design guidelines and ensured that the layout is responsive.
[x] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[x] I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Closes #5772
Description

For a quiz whose mode is synchronized, the due date was set to start date + duration + grace period (5 seconds) on the server side. When editing the quiz, the due date is never modified even though the start date is changed. Therefore, it is possible that the release date and start date are modified in such a way that: due date < release date < start date. This caused the quiz date to be invalid. To prevent the situation, the due date is set to be undefined (for synchronized mode), so that the quiz date is considered valid.
Steps for Testing

Prerequisites:

1 Instructor
1 Course
1 Quiz Exercise whose mode is synchronized

Log in to Artemis
Navigate to Course Administration
Select the Course
Click Exercises
Edit the Quiz Exercise
Modify the Release Date to be after the old Start Date
Modify the Start Date to be after the old Start Date and before the new Release Date
Verify that the Quiz Exercise can be saved

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Class/File
Branch
Line

quiz-exercise-detail.component.ts
79.71%
95.08%

Screenshots

Before
https://user-images.githubusercontent.com/10885503/204447348-cba540f7-cefb-4364-9121-1e3a239a08fc.mov
After
https://user-images.githubusercontent.com/10885503/204447388-bbe0b4cf-9102-432c-8c5a-a62478cb2828.mov

Codecov Report
Base: 75.63% // Head: 79.92% // Increases project coverage by +4.28% :tada:

Coverage data is based on head (7dc5993) compared to base (b27d53d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5899      +/-   ##
=============================================
+ Coverage      75.63%   79.92%   +4.28%
- Complexity         0    12353   +12353
=============================================
  Files           1117     2125    +1008
  Lines          44289    84226   +39937
  Branches        8364    12633    +4269
=============================================
+ Hits           33499    67315   +33816
- Misses          5621     9385    +3764
- Partials        5169     7526    +2357

Flag
Coverage Δ

client
75.63% <100.00%> (+<0.01%)
:arrow_up:

server
84.67% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ises/quiz/manage/quiz-exercise-detail.component.ts
79.71% <100.00%> (+0.04%)
:arrow_up:

...e/tum/in/www1/artemis/domain/AssessmentUpdate.java
100.00% <0.00%> (ø)

...ervice/compass/umlmodel/classdiagram/UMLClass.java
90.27% <0.00%> (ø)

...emis/web/rest/errors/CaptchaRequiredException.java
100.00% <0.00%> (ø)

.../in/www1/artemis/service/ldap/LdapUserService.java
32.14% <0.00%> (ø)

...s/jenkins/JenkinsBuildPlanLinkInfoContributor.java
25.00% <0.00%> (ø)

...tum/in/www1/artemis/domain/lecture/OnlineUnit.java
100.00% <0.00%> (ø)

.../domain/submissionpolicy/LockRepositoryPolicy.java
100.00% <0.00%> (ø)

...a/de/tum/in/www1/artemis/domain/BonusStrategy.java
78.78% <0.00%> (ø)

...va/de/tum/in/www1/artemis/web/rest/vm/LoginVM.java
90.90% <0.00%> (ø)

... and 999 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

I got some issues with setting of Start Working Time after the quiz was generated. Steps to reproduce:

Create the quiz with the Schedule Quiz Start
Save the Quiz and wait unitl it starts
Reset the quiz and edit it
Try to set the Start Working Time after the Visible From -> Not working and shows the error

Hi @evgeny1984, after resetting the quiz, the visible from date was changed to 1 year later as implemented here. In your screenshot, the visible from date is Nov 28 2023. That's why it is considered invalid.


Drupal migration

Criteria for inclusion

Has an impact on marketing and front-of-house operations if content were not available
Content needs to be editable (therefore needs to be in Prismic)
Priority activity for Wellcome Collection
Viewed more than 100 times in past year - except as noted below.

Content to be included that does not fulfil inclusion criteria

Past  exhibitions, but not all of the associated articles and galleries – with some rewriting to fit the page and be in the past tense
All publications/books, whether they’ve had much traffic or not.

Taxonomy
We currently have these sections that pages are put into:

Visit us
What's on
What we do
About this site

Types that have been used recently (in 2018)

Basic page e.g.
Book e.g.
~Event~
~Exhibition season~
Front page (homepage only)
Landing page (https://wellcomecollection.org/books <= the only one)
Press release e.g.
Webforms (see below)

Types that have not been used recently (pre 2018)

Basic landing page (there are only two)
Artefacts e.g.. These include

Articles
Audio
Credits
Essay
Event
Image gallery
Interactive
Interview
Learning resource
Podcast
Profile
Publication
Social media
Video

Structure
All content has

A main image (promo image)
Title

Some content has

Children pages

Web forms (data collection)

https://wellcomecollection.org/youth-and-community-workers-sign (email signup)
https://wellcomecollection.org/young-people-aged-14-19-sign (email signup)
https://wellcomecollection.org/teachers-sign (email signup)
https://wellcomecollection.org/ideas-hub-register-your-interest
https://wellcomecollection.org/submit-your-sleep-stories
https://wellcomecollection.org/contact-us
https://wellcomecollection.org/stay-touch
https://wellcomecollection.org/complete-survey
https://wellcomecollection.org/what-er-are-you
https://wellcomecollection.org/ask-researchers
https://wellcomecollection.org/self-guided-group
https://wellcomecollection.org/guided-tours

Questions

What do we do with content that seems to have seemingly been split into multiple sections e.g. https://wellcomecollection.org/what-we-do/working-wellcome-collection? Could we potentially have these as 1 page with section headers, and potentially a overview nav at the top?
When bringing over publications
What would we need to have a Drupal content freeze on new content, and use the info page already on Prismic? From looking at recently published content, some form of list of erlevant onward journey content? Although, as mentioned above, it feels like a lot of that content could be put into 1 page (maybe we do both). This content was created recently (11 April)

https://wellcomecollection.org/what-we-do/research-network
https://wellcomecollection.org/what-we-do/hub
https://wellcomecollection.org/what-we-do/hub-award

Basic page with basic page children
Are these landing / listing pages?

Another question potentially how do we retire content in the future.

Press images https://wellcomecollection.org/press/press-images

Reminder to store drupal API in prismic.

Questions for the DB:

How many pages in What we do section and published?

First steps
Could we have a go at the "What we do" section, here is a spreadsheet of that content (I'll be making it slightly more tidy and rich):
https://docs.google.com/spreadsheets/d/1jSHEf3q7-sJFCQVsXDiflr2QUMVijkuAgFlzi-6oSEI/edit#gid=0

Answered questions:

What shall we do with press images: Press images https://wellcomecollection.org/press/press-images

We have approval to get rid of them entirely as these photos aren't any good.

[ ] Promo text as meta description
[ ] Adding non-Prismic content to content lists
[ ] Visit us page (map component?)
[ ] Update newsletter with new logo and content
[ ] Make Rachael new main contact at dotmailer


Added pooch registries for data files

Description

Added pooch as a [dev] dependency and added a file to create and store data file registries for pybamm-data.
Added dataloader method to fetch data files from pybamm-data and store it under local cache folder and import it in notebooks wherever needed with specified paths.
Removed data files from local repo under pybamm/input
Data files under pybamm/input/parameters have not been removed or included in the pooch registries.
Added documentation, tests and an example notebook for pybamm.DataLoader class.

Fixes #4026
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

[x] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[x] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
[ ] All tests pass: $ python run-tests.py --all (or $ nox -s tests)
[x] The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).
Further checks:

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works

Ran the Build and publish package CI to build whls on my branch, and the sizes have been reduced by almost 15-20MB for POSIX and Windows distributions - https://github.com/santacodes/PyBaMM/actions/runs/9162618687.

I think this is good to go on my end, but I just had a question about skipping tests without networks – @santacodes, the pytest decorator + no_internet_connection() we have will prevent the tests from failing, but this is just for the unit and the integration tests. Is there a way we can cleanly extend this behaviour for the example scripts and notebooks which make use of the data files, in specific? It's not a big deal though, because we expect that most people have internet access nowadays somehow or the other.

I think this is good to go on my end, but I just had a question about skipping tests without networks – @santacodes, the pytest decorator + no_internet_connection() we have will prevent the tests from failing, but this is just for the unit and the integration tests. Is there a way we can cleanly extend this behaviour for the example scripts and notebooks which make use of the data files, in specific? It's not a big deal though, because we expect that most people have internet access nowadays somehow or the other.

For notebooks and scripts, I am thinking we could add an error-handling method to raise an Error, pooch raises socket.gaierror by default when there is no network connection as it cannot create a socket connection with the upstream URL.
The second option would be to check for the internet connection before actually fetching data files from upstream and warning the user about network connectivity.
I think both can be implemented, but I am not sure which would be more optimal for scripts and notebooks specifically.

For notebooks and scripts, I am thinking we could add an error-handling method to raise an Error, pooch raises socket.gaierror by default when there is no network connection as it cannot create a socket connection with the upstream URL. The second option would be to check for the internet connection before actually fetching data files from upstream and warning the user about network connectivity. I think both can be implemented, but I am not sure which would be more optimal for scripts and notebooks specifically.

I thought of that but both of these options should ideally stay outside and abstracted away from the content inside the notebooks and scripts, which isn't quite viable and seems over-engineered... I opine that we should skip them for now. We can help out on a per-user basis if someone tries to use nox -s scripts or nox -s examples without an internet connection. Another reason why I say this is because we do not include any of the example scripts or notebooks inside the sdist or the wheel, which means that people have to come to GitHub or browse the online documentation to access them anyway, and accessing GitHub requires access to an internet connection.

Maybe we should refer to the reST-based heading for PyBaMM Data instead of adding an HTTP(S) link to our documentation? Otherwise, this failing link will keep failing for all the release candidates until we have the v24.5 release out – the link is pointing to stable, not latest. @santacodes, could you make this change in the notebook?

Changing to ../api/pybamm_data.rst won't help – could you add a heading under the PyBaMM Data page and use reST syntax to link to it? Something under this SO post should help

Changing to ../api/pybamm_data.rst won't help – could you add a heading under the PyBaMM Data page and use reST syntax to link to it? Something under this SO post should help

I tried referencing headers, but sphinx doesn't seem to render it as a link no matter what, even when I reference the pybamm_data.rst to reference the documentation header as they are not under the same directory. It only works by referencing the notebook's path like in my last commit, or by referencing docs/source/api/pybamm_data.rst:#pybamm.DataLoader. They both mean the same thing, so I will leave it up to you to decide further.

I think this should be okay, then, thanks for the explanation. Not sure if there is a better way to link them unless we switch to MyST completely for the codebase, which is something for a later time


Update README.md

Clarify and update using instruction

Component and Directive import
Import main theme from NPM (optional)
Example of event binding
PS. Awesome project! I just use it with my app :)

Thanks will merge and update the readme for next major release which is out when Angular 5 is out.


Automated tests

Feature request
It would be great if a test suite could verify that everything is working properly. The interactions are pretty finicky and things can break in odd places by doing minor changes in others.
This would make the library much more maintainable and easier to refactor in the future, while giving more peace of mind to users that upgrades are safe.
Should be relatively easy to add gray box e2e testing using:
https://github.com/wix/Detox
Tests could be added to initiate scrolls and touches, then assert whether things are positioned correctly.
Another possibility is to convert the Example app to use Storybook:
https://storybook.js.org/
https://www.learnstorybook.com/intro-to-storybook/react-native/en/get-started/
It would then be possible to use loki to do screenshot diff testing for the stories (this wouldn't really test dynamic interactions though, only static rendering):
https://github.com/oblador/loki

@andreialecu we really need this. It was an issue with v1 and v2 (#2) to pass a ref and initiate programmatically scrolling from the tests, but now it should be easy. I'm experienced with storybook, jest, and enzyme, but not with detox. I will be looking into it thought the week to see how to set up things.

This would make the library much more maintainable and easier to refactor in the future, while giving more peace of mind to users that upgrades are safe.

❤ 🚀

React navigation uses detox with circle. I will use it as an starting point.

Here is a nice article about adding detox: https://medium.com/@oriharel/how-i-learned-to-stop-worrying-and-love-merging-to-master-a7e2edc0924e


docs: chinese docs of developer guide overview

@nicecui thanks, and it looks good to me after resolving the conflicts.


[v2] Translations approach

💥 Proposal
An umbrella issue to track the translations work for v2 and guide the design and implementation on the feature in v2. Give suggestions and feedback on this issue.
Some initial thoughts:

Translations should be a core feature built into Docusaurus core, not implemented specifically by any plugins
We expose a current locale value in the context. Elements which need it can read from it
For performance reasons, each translated website should be its own website (can be done via adding a /<locale>/ to the baseUrl). This is basically sharding the website bundle so that the main bundle doesn't contain routes for each locale. If performance isn't a concern, then probably there's no need to do this

Follow this issue for updates.
Some tools to consider using:

https://github.com/globalizejs/globalize
https://facebook.github.io/fbt/
https://react.i18next.com/
https://github.com/i18next/react-i18next/

Issues with v1 translations

Build times are slow, especially when combined with versioning
https://stackoverflow.com/questions/59125516/versioned-docusaurus-site-returns-404-for-the-other-languages
#586
#648
#2206
#2266
#2278
#2306
#2471

Have you read the Contributing Guidelines on issues?
Yes

Do you plan use an approach like the react-i18n-intl? In the v1, we have the crowdin to make the translations, but this put the limitation to assume that the default language is english. Is a plan to v2 change this architecture, to make possible the developer submit your own translations and we use a framwork to read them?

There are two things we need to translate here:

UI and React components - Those can be powered by i18n libraries such as FBT and react-i18n-intl
Documentation - I presume the docs for another language would be side-by-side with the original docs:

docs
├── introduction.md
├── introduction.jp.md
├── introduction.es.md
...

@yangshun would #2302 need to be completed first, or will versioning stay similar enough as presented to the user?

@nebrelbug Versioning might change a bit. We might end up doing ////. IMO locale should be a first class feature in Docusaurus.

//// meaning something like /en/docs/v2/somedoc-name?

@nebrelbug Sorry I had to wrap the text in a code tags for it to show. But you got it!

We would still love to be able to use crowdin if that is possible.

There are many potential solutions for i18n in v2 that we are thinking about.
I think for regular MD docs, we should stick to integrating with a SaaS that allows uploading MD files directly, so that translators can work in full doc context, instead of translating key/value pairs.
Keeping compability with Crowdin is probably important to v1 users.
We also need to validate that Crowdin and other i18n SaaS providers works great with MDX (ie docs pages embedding React components for interactive demos). If you have feedback on that I'm interested.

I've been exploring using Docusaurus for a multilingual site, only to realize v2 doesn't have any i18n layer. I have some experience with localizing products/documentation in various forms, including some automated localization pipelines, so here are my thoughts on how I would expect i18n to be handled:

I'd prefer i18n of an open-source project to be SaaS platform agnostic, so that Docusaurus users could pick the SaaS of their choice, or stick with an open-source localization solution.
MD/MDX, while not being the easiest format for localization purposes, is something Docusaurus has committed to use, so an external localization solution or process needs be able to work with MDX as a source and produce MDX as a target.
Scalability of building/deploying a multilingual site is a concern. Adding a number of languages on top of a multi-versioned site adds even more complexity. However, it's unlikely that older versions of the documentation will need to continue to be translated or regularly rebuilt. Ideally, making a versioned snapshot would mean that the current state of the site and all its current translations is frozen, built, and not being rebuilt unless explicitly asked. This would potentially allow to have many versions that would not slow down the builds. Only the latest version of the site would be actively translated and built.
For the speed of development, it is best for the developers or content creators to focus on the source language only, and build/preview only that language. This means that until explicitly asked, it should be fine to compile only the source language, and have the site functional. Ideally, docusaurus could be told to build a specific language (including live-reload scenarios), or to build all languages at once. With this, translations that are being automatically committed to the site repo (in continuous localization scenarios) would not slow down the development.
For SEO, bookmarking and link sharing, a cleanest way is to have each language exposed explicitly in the URL, with the language negotiation being performed at each page level. For example:

Visiting / URL on a multi-lingual site would redirect to a language-specific URL (e.g. /en/, /de/, /fr/) based on available languages for that URL, and user's browser language preferences.
Visiting /some-folder/some-page/ would redirect the user to e.g. /en/some-folder/some-page/, /de/some-folder/some-page/ or /fr/some-folder/some-page/. An ability to provide deep links that auto-resolve to the target user's language is a must when using them in the product UI, marketing emails, and so on.

Translating content takes some time, so if a page is missing in a specific language, it shouldn't break the build; If one goes to a language-specific URL, and the page doesn't exist [yet], the site could show a 404 page that says "this page is not available in your language yet, but you can switch to another language it is available in: xx, yy, zz."
It should be possible to allow for a partial translation of websites. In other words, a situation where a particular page doesn't exist in a particular language, is valid and should not be considered temporary. Unresolved document IDs referenced from sidebars.js must not break the build, but hide that link from the document tree, and give a warning in the console log.

Proposal
A set of localizable files include docusaurus.config.js, sidebars.js and content folders (blog/, docs/). Imagine that you can have them sitting together in some common subfolder, e.g. content/. So the structure becomes:
content/
      blog/
      docs/
      docusaurus.config.js
      sidebars.js
node_modules/
src/
static/
package.json
...

All localizable content needed by plugins needs to be externalized into JavaScript/TypeScript/JSON files and reside in the content/ folder as well. Ideally there would be some common format and file naming convention that all plugins are expected to use.
Running docusaurus build without parameters would compile only the site inside the default (content/) subfolder, with its local config, sidebars and content.
An external localization process would need to take the source content/ folder and create localized variants of this folder, for example, content-de/, content-fr/, etc. Running Docusaurus against a specific content folder would render that portion of the site. For example, docusaurus build content-fr would try to load content-fr/docusaurus.config.js relative to the current working directory, and resolve all the documents relative to that file.
Each content variant needs to have its unique root URL (mount point) so that the variants can be deployed to the target site independently. This could be done directly in each version of docusaurus.config.js, but it might be cleaner to have them listed in some global config. content-de/ would get a /de/ root URL, content-fr/ would map to /fr/, and so on. The default content/ folder, depending on the source language, would also get a specific root URL, e.g. /en/. Having a root URL other than / is necessary for per-URL language redirects.
Making a version of a site means that the current state of these content folders needs to be duplicated. For example, when one decides to cut a version 1.x, what would be done is:

content folder is copied to content-1.x folder, and the root URL of the versioned copy changes from its current one, e.g. /en/, to /en/1.x/
content-de folder is copied to content-de-1.x with /de/1.x/ root URL
content-fr folder is copied to content-fr-1.x with /fr/1.x/ root URL
...and so on.

Similarly, running docusaurus deploy <content-directory> would deploy this specific directory. It would be handy to have globs supported, so that one could say docusaurus deploy * to deploy all content directories, or docusaurus deploy *-1.x to redeploy all the content directories that end with -1.x.
Docusaurus would likely need to have static pre-rendered maps of all files for each of the content directories so that it can do quick lookups and per-URL language-based redirects, and that language negotiation/redirect portion will be shared across all content variants. Redeploying a particular language or a particular version would update these static maps, allowing to dynamically render the language switcher on all the pages.
Current workaround
Right now it should be possible to mimic the behavior I described above to some extent by creating a side project for each language variant and deploying each sub-site independently to a subdirectory of a global site. Symlinking directories like node_modules, src and some common files might help in keeping all these versions in sync. A global 404 handler might be used to dynamically switch to an available language-specific variant of the page if a generic URL is provided.
Sorry if that's a lot of text to process. :) Would love to hear your thoughts.

Thanks for your feedback @iafan . I agree with you on most parts. If you are on discord, that could be useful that we chat before I start working on this feature

@slorber Of course. I DM'ed you on Discord.

Hey there. I'm closing this issue in favor of a new one: https://github.com/facebook/docusaurus/issues/3317
I'm working on i18n, and have already integrated a few feedbacks from this issue already.


Run go fmt across all files

Simply ran go fmt . from the root of this repo.

Pull Request Test Coverage Report for Build 904244304

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.203%

Totals

Change from base Build 904234950:
0.0%

Covered Lines:
988

Relevant Lines:
1027

💛  - Coveralls


Add zf1s/zend-filter as required dependency to composer.json

ViewRenderer in zf1s/zend-controller directly depends on Zend_Filter Classes

@dmnc @falkenhawk can this be merged? Given that the version number is updated to the current version by @Anyqax?

@smhg yes. It just better reflects the realities of the code.

I wasn't aware of this PR. If you have time, please submit a pull request to https://github.com/zf1s/zf1/pulls - this repo is readonly, updated automatically when new zf1s version is released

closed in favor of https://github.com/zf1s/zf1/pull/171


Changes in nesting of describe causes unexpected changes in reporting

main :: Effect Unit
main = Aff.launchAff_ do
  Runner.runSpec [ Reporter.consoleReporter ] do
    Spec.describe "A" do
      Spec.it "should be under A" (pure unit)
    Spec.describe "B" do
      Spec.describe "B-1" do
        Spec.it "should be under B-1" (pure unit)
    Spec.describe "C" do
      Spec.it "should be under C" (pure unit)

produces the following summary as expected
Running tests for package: spec-nested-describe-bug
A
  ✓ should be under A
B » B-1
  ✓ should be under B-1
C
  ✓ should be under C

Summary
3/3 tests passed

However, removing the Spec.describe "B-1" block
main :: Effect Unit
main = Aff.launchAff_ do
  Runner.runSpec [ Reporter.consoleReporter ] do
    Spec.describe "A" do
      Spec.it "should be under A" (pure unit)
    Spec.describe "B" do
      Spec.it "should be under B" (pure unit)
    Spec.describe "C" do
      Spec.it "should be under C" (pure unit)

the other top level blocks are collapsed so everything is under "A"
Running tests for package: spec-nested-describe-bug
A
  ✓ should be under A
  ✓ should be under B
  ✓ should be under C

Summary
3/3 tests passed

@pete-murphy thank you for the report, I'm looking into it.


Question about code in moco/builder.py

Hi,
Thanks for your impressive work.
In moco/builder.py, line 63:
self.queue[:, ptr:ptr + batch_size] = keys.T
I suppose that the keys is a Tensor with the batch_size dim, and T is a float scaler attribute of self as self.T .
So an AttributeError AttributeError: 'Tensor' object has no attribute 'T'  would be raised if I directly run the train code.
Should it be self.T(I guess)? or any specific setting i missed?
Regards,

keys.T is transpose of keys: https://pytorch.org/docs/stable/tensors.html#torch.Tensor.T

same problem，is maybe pytorch version（mines is pytorch 1.10）

same problem，is maybe pytorch version（mines is pytorch 1.10）

I just try torch 1.2 , it is ok

Hi,
Thanks for your impressive work.
In moco/builder.py, line 63:
self.queue[:, ptr:ptr + batch_size] = keys.T
I suppose that the keys is a Tensor with the batch_size dim, and T is a float scaler attribute of self as self.T .
So an AttributeError AttributeError: 'Tensor' object has no attribute 'T' would be raised if I directly run the train code.
Should it be self.T(I guess)? or any specific setting i missed?
Regards,

hello,did you solve this problem?


Support playing audio streams in reverse

Godot version:
v3.0.3.stable.official.e649ec7
OS/device including version:
Windows 10
Issue description:
There currently doesn't seem to be an API for playing audio streams in reverse / backwards.
AudioStreamSample has a LOOP_PING_PONG LoopMode which alternates between playing forwards and backwards. However, you can't only play a sample backwards, and you can't play an AudioStreamOGGVorbis backwards.
Ideally, there would be some API on AudioStreamPlayer (and AudioStreamPlayer2D/3D) to play audio backwards. Perhaps a reverse field or an extra argument to play()?
For what it's worth, Unity allows playing audio in reverse by setting pitch scale to a negative value, so that's another idea.
My own use-case is a rewind / reverse-time effect, where (among other things) music and sound effects are played backwards.

Would there be a play_speed property which could simply be set to a negative value?

As of 3.0.3, AudioStreamPlayer and co. have a pitch_scale property which controls play speed (resulting in both time scale and pitch shift, hence the name I guess). However, if you set it to a negative value, the audio just stops playing.

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!

......don't have negative pitch

Nope its not closed yet 😈
I Just fund a solution I guess


[alerts] Need for fast-track analog alerts

This is a note that we should at some point have a discussion whether there is a need for additional fast track alerts that completely side-step the current alert subsystem.
I.e., the current alert subsystem is still sequential in nature, and even for critical alert events that are configured to escalate ASAP, it still takes a few cycles until an escalation action is triggered.
Fast-track asynchronous escalation paths could be used to address this issue, but these would have to be inserted manually for a specific small subset of critical alerts conditions.

CC @tjaychen @zi-v @cdgori @arnonsha @eunchan @johannheyszl


Allow specifying config file argument without suffix

My use case is that I have a --model argument to my program, which contains data to be loaded when the program starts and saved when the program ends. I would like to add a config file whose name is just the model filename + a .yml suffix, without the user having to specify that explicitly.
This could be accomplished by making the --model argument a is_config_file_arg=True argument, except that then the model file itself will be treated as the config, where I want the file with the .yml suffix to be taken. For that a default suffix to add to is_config_file_arg=True arguments would be helpful.

This is a pretty niche use-case, so I'd rather not add args to the API unless more people need this.
You should also be able to get this behavior by subclassing configargparse.ArgumentParser, over-riding _open_config_files and modifying the command_line_args before passing them to super. _open_config_files(..)


.Any() fails on collections using a in-line null check

Issue Title
.Any() fails on collections using a in-line null check
General
.NET Core Version: 3.1.201
public class TestClass
{
     public List<string> listOfStrings { get; set; }
}

static void Main(string[] args)
{
     TestClass test = new TestClass();

     if(test.listOfStrings?.Any(s => s == "Hello"))
     {
          // do something
     }
}

test.listOfString?.Any() should return a bool if it finds any string that are equal to "Hello". .NET is complaining that it can't implicity convert type 'bool?' to 'bool'
https://docs.microsoft.com/en-us/dotnet/api/system.linq.enumerable.any?view=netframework-4.8

When the member after ?. evaluates to a value type, the evaluated type of the ?. expression is a Nullable wrapper over that type, because the ?. operator is just a syntactic shortcut for  a?.B() becomes (a != null ? a.B() : null).
In your case, it expands to
List<string> tmp;
if ((tmp = test.listOfStrings) != null ? tmp.Any(s => s == "Hello") : null))
{
    // do something
}

but the if-expression isn't a valid boolean expression (it's an expression that evaluates to Nullable<bool>, aka bool?).  You can use ?? false (or ?? true) to express the behavior for when listOfStrings was null:
if (test.listOfString?.Any(s => s == "Hello") ?? false)
{
    // do something
}

(Closing since there's not a product bug here, just nuance of a C# language feature)


6.0: [LICM] Bail on unreferenceable storage.

Explanation: Fix a compiler crash caused by an insufficiently conservative optimization.
Some structs that are imported from C have storage that can't be referenced in Swift.  For example, Foundation.Decimal.  Such structs cannot be formed in SIL via the struct instruction.
LICM moves code out of loops.  Part of this involves forming values which were previously in addresses.  To form a struct value, the struct instruction is used.  This isn't legal if the struct in question has storage that can't be referenced in Swift.
Here, a bailout is added to check whether any struct which would need to be formed during the pass has unreferenceable storage.
Scope: Affects code involving imported types with unreferenceable storage in release builds.
Issue: rdar://127013278
Original PR: https://github.com/apple/swift/pull/73240
Risk: Low.  Introduces a new bailout to a pass.
Testing: Added regression test.
Reviewer: Andrew Trick ( @atrick ), Meghana Gupta ( @meg-gupta )

@swift-ci please test


Slightly Modified Android Export Script for Illustrator

Not a meaningful change and the PR has no explanation of why the change was made. Closing.


Include Jars as a deployable entity

Pull Request Checklist

[ ] Pull request is based on WIP branch
[ ] Pull request includes a description of the change and the reason behind it
[ ] pytest passes locally
[ ] flake8 apparate tests passes locally
[ ] CHANGELOG has been updated
[ ] Version in _version.py has been updated
[ ] README has been updated (if applicable)

Closing this PR as this work is incorporated in #9


Make icon default color explicit, and respond to dark mode

Please verify the following:

[x] yarn test jest tests pass with new tests, if relevant
[x] yarn lint eslint checks pass with new code, if relevant
[x] yarn format:check prettier checks pass with new code, if relevant
[x] README.md (or relevant documentation) has been updated with your changes

Describe your PR
I noticed the icons on the community screen weren't updating for dark mode.
Color isn't explicitly set by those icons, but it matches text color in our design system by default.
Here I explicitly assign a default color for icons, and make sure it updates with the theme.

Before
After

I got a local test failure but it doesn't look related to my changes. Letting it run on CircleCI in case it's a problem with my environment.
    Blocked 1 postinstall. Run `bun pm untrusted` for details.

        ❌ Installing bun dependencies (wow these are heavy)

    The following error occurred:

        Error: Command failed: npx expo install --fix
    Warning: Root-level "expo" object found. Ignoring extra keys in Expo config: "name", "displayName", "ignite"
    Learn more: https://expo.fyi/root-expo-object
    (node:33834) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
    (Use `node --trace-deprecation ...` to show where the warning was created)
    The following packages should be updated for best compatibility with the installed expo version:
<EMAIL_ADDRESS>- expected version: 1.6.4
<EMAIL_ADDRESS>- expected version: ~3.10.1
    Your project may not work correctly until you install the expected versions of the packages.
    bun add v1.1.21 (70ca2b76)
    Resolving dependencies
    Resolved, downloaded and extracted [0]
    Saved lockfile

    error: FileNotFound creating node-gyp tempdir
    Error: bun add<EMAIL_ADDRESS><EMAIL_ADDRESS>exited with non-zero code: 1
    Error: bun add<EMAIL_ADDRESS><EMAIL_ADDRESS>exited with non-zero code: 1

:tada: This PR is included in version 10.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Further improve streaming manager logging

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.81%. Comparing base (b48bb4f) to head (719aafa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1152      +/-   ##
==========================================
+ Coverage   96.77%   96.81%   +0.04%
==========================================
  Files          23       23
  Lines        2079     2075       -4
==========================================
- Hits         2012     2009       -3
+ Misses         67       66       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Full-duplex implementation for PulseAudio including common files

This is the PulseAudio implementation for full duplex including all common files and test changes (and alsa) to compile successfully.

I will close this to create PR from a dev branch and add some additional comments. Sorry for the inconvenience.


Remove useless checks

The requirement that mode is equal to NC_MPIIO or NC_MPIPOSIX or NC_PNETCDF is checked, but is not ever used after this point.  NC_MPIIO is now the same as NC_PNETCDF and NC_MPIPOSIX is deprecated.
Once the execution gets down into NC_open, the mode has NC_MPIIO set automatically (if(useparallel) flags |= NC_MPIIO;) where flags is the same as mode.

This PR is fine, but note that I am preparing another PR with some comprehensive changes to how and where mode flags are handled. See #392.
I will proceed on #392 after a few more of the outstanding PRs get merged.
The main change is that inappropriate mode flags will no longer be silently corrected. If you specify NC_NETCDF4 when doing an nc_open(), it will not be silently ignored. Attempting to use NC_NETCDF4 on a non-netcdf-4 file will return an error. Similarly for other formats.

This should be orthogonal to your changes.  The application should not have to pass in the type of file that it is opening since the library will determine that on open.   Create is a whole different issue.
There will be issues if the file is of a type not supported by the current library build, but that handling will happen down below the nc_open_par() routine.

I agree this is orthogonal. I just wanted to let you know another PR on this topic is coming soon for consideration.

Pulling in now to a bulk merge that will go in tonight or tomorrow.

I think this should not be merged.  After some additional testing, it looks like my PR did a few too many deletions...


Minifyied version for browser

Add minifyied version for using in browser.

This package is really really large for the browser. Also with minification; it still requires unicode/so.js which alone is 1.68 MB minified.
I've switched to slugify, as this package doesn't seem to be maintained and its way to big. (Latest commit 85ded30  on 18 Apr 2015)


fix: revert #144

#144 multiplies q by sm_scale, which may cause numerical issues when q is a fp8 data type.
This PR reverts the change and multiply logits by sm_scale at the end of aggregation.

Okay I think I made a mistake here, in decode kernels, we first cast q to fp16 then multiply it by sm_scale, so it's not a issue.


Fix Inference API status check, allow modelLoadInfo to be passed as prop

To reduce the number of calls made to the inference API status check, we let modeLoadInfo to be passed in as a prop - if not provided as a prop, it makes the api call directly as it always has. This allows the Model Page in moon-landing, which needs to make the status check request, reuse the model status instead of making another call. See discussion here: https://github.com/huggingface/moon-landing/pull/6975
Also I believe the status API got out of sync at some point with the actual API returned by api-inference - fixed now. This is why currently every model says This model can be loaded on the Inference API on-demand even when that isn't the case.

Hi there! This part of the code now lives in huggingface.js, so I'll close this PR.


It is either failing with "no such file or directory" (https://build.golang.org/log/0ecf2d811aae2b0426aea143c6e9ef2a037d6764)
or with "resource temporarily unavailable" (https://build.golang.org/log/f9b25e8ddf1db276b56b3fafcb33d366887e5649
Building Go cmd/dist using /opt/freeware/lib/golang.
Building Go toolchain1 using /opt/freeware/lib/golang.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
unknown XCOFF segment data section: .go.buildinfo
getXCOFFscnum not implemented for section .go.buildinfo
unknown XCOFF segment data section: .go.buildinfo
getXCOFFscnum not implemented for section .go.buildinfo

go tool dist: FAILED: /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/pkg/tool/aix_ppc64/link -o /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/pkg/tool/aix_ppc64/go_bootstrap /ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/go-tool-dist-603817487/cmd/go/_go_.a: exit status 2
Building Go toolchain2 using go_bootstrap and Go toolchain1.
go tool dist: FAILED: /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/pkg/tool/aix_ppc64/go_bootstrap install -gcflags=all= -ldflags=all= -i cmd/asm cmd/cgo cmd/compile cmd/link: fork/exec /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/pkg/tool/aix_ppc64/go_bootstrap: resource temporarily unavailable

It does look like these were passing a few days ago, but not finding any obvious culprit CLs.
/cc @bradfitz @dmitshur any ideas?

https://go-review.googlesource.com/c/go/+/174298 is outstanding for this.

/cc @Helflym

That CL is in and that particular bug is fixed. Other AIX problems remain.


Update of the status bar on the hide menu is now called at the completion

This fix the bad update when switching form two contentViewController with different status bar colors.
When called alongside with a hideMenuViewController the statusBarNeedsAppearanceUpdate called outside the completion block of the hideMenuViewControllerAnimated caused the status bar to switch back to the previous contentViewController, since this is triggered before the completionBlock of the animation in setContentViewController.
Before fix :

After fix :

looks so much better!

I merged it in our Fork (https://github.com/AutoScout24/RESideMenu/commit/63685f9fdce736a168a40005c75b5209d940165b)

@Loadex how did you make the status bar white ? In my project it's white until I used RESideMenu now my status bar it's black and I can't change the color how to do it please ?


[Bug]: Deleting administrator user throws error in 'Members' page.

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When user is in 'Members' page and an admin user is deleted, page throws error. (refer video for detail walkthrough)

https://loom.com/share/91d301a63fe2439eb346e189ce87ed35
Expected behavior: On page refresh the user must be redirected to home page.
Steps To Reproduce

Login with UserA and create an org
In Org > Share > Manage Users > Invite users > Enter UserB email id and provide Administrator role
In another browser login with UserB details and verify UserA organization is present. Now in the organization present > Share > Manage users > Delete UserA from the list.
Go back to UserA browser and click on refresh and observe the error.

Environment
Release
Version
Cloud

We no longer have the error toast messages, instead we get a blank screen on clicking back we end up on homepage. Attached the video for reference
https://github.com/appsmithorg/appsmith/assets/161307325/968a4cd5-5fe4-40e6-910e-a4dd64f80745


attribute d: Expected number, "M NaN NaN A NaN Na…

Hello everyone, we are currently developing a platform that makes use of its apexcharts component, which is a single-page application and we use requirejs. However, since we cannot provide stability through amd, we opted for the use of import through the tag. In a global form. When loading the dependencies and generating the graphs, the processor works correctly, however when we change routes to other micro views it sends us a series of errors in the console indicating the following message
apexcharts:6 Error:  attribute d: Expected number, "M NaN NaN A NaN Na…".

Any idea what is causing the error?
`var options = {
series: data.series,
chart: {
height: 350,
type: 'line',
toolbar: {
show: false,
}
},
dataLabels: {
enabled: false
},
stroke: {
width: 4,
curve: 'smooth',
dashArray: 0
},
legend: {
fontFamily: 'Lufga-Regular,sans-serif',
tooltipHoverFormatter: function(val, opts) {
return val;
}
},
markers: {
size: 0,
fontFamily: 'Lufga-Regular,sans-serif',
hover: {
sizeOffset: 6
}
},
xaxis: {
fontFamily: 'Lufga-Regular,sans-serif',
categories: data.categories
},
tooltip: {
y:{
title: {
formatter: function (val) {
return val
}
}
}
},
grid: {
borderColor: '#f1f1f1',
}
};
		let lineChart=document.getElementById(`${data.idChart}`)

		if(lineChart){
			var chart = new ApexCharts(document.querySelector('#${data.idChart}'), options);
			chart.render();
		}`

having now the same issue 130k errors in the browser - and site is not responsive
apexcharts-card.js?hacstag=331701152201:1 Error:  attribute d: Expected number, "M 0 NaN".

Add route listener and use v-if


Add Support for Transfers Between Withdrawn Accounts - (Spec PR #601)

PR Description
Add Support for Transfers Between Withdrawn Accounts - (Spec PR #601)
Fixed Issue(s)

Fixes #406

@vitorpy I will review this today.  Thanks for your help (and patience)

Sorry 'bout the delay, had to leave town to visit family for the weekend and my laptop isn't one of the things I grabbed. I'm working on this now.


OVS2.5 with DPDK2.2 configure group table ,finally execution action is "drop"

hi， all
With my environment, OVS 2.5.0 with DPDK 2.2.0, I use the flow command to realise my function.

ovs-vsctl set bridge br-int-R protocols=OpenFlow10,OpenFlow11,OpenFlow12,OpenFlow13
ovs-ofctl -O OpenFlow13 add-group br-int-R group_id=10,type=all,bucket=mod_dl_src:00:4A:E4:25:6B:02,bucket=mod_dl_dst:51:23:40:3E:2B:02,bucket=dec_ttl
ovs-ofctl -O OpenFlow13 add-flow br-int-R "table=50,priority=1,ip,nw_dst=<IP_ADDRESS>/<IP_ADDRESS>,actions=group:10"

but after configure this, I found that using different commands to see different flow entry view.
1.#ovs-ofctl dump-flows br-int-R
NXST_FLOW reply (xid=0x4):
cookie=0x0, duration=1390.625s, table=50, n_packets=3361843122, n_bytes=847184466744, idle_age=0, priority=1,ip,nw_dst=<IP_ADDRESS>/24 actions=drop
2.#ovs-ofctl dump-flows br-int-R -O OpenFlow13
OFPST_FLOW reply (OF1.3) (xid=0x2):
cookie=0x0, duration=72.050s, table=50, n_packets=264937817, n_bytes=66764329884, priority=1,ip,nw_dst=<IP_ADDRESS>/24 actions=group:10
And in the dathpath dpif, the finally execute action is "drop".
ovs-appctl dpif/dump-flows br-int-R
recirc_id(0),in_port(2),eth(dst=00:4a:e4:25:6b:02),eth_type(0x8100),vlan(vid=100),encap(eth_type(0x0800),ipv4(dst=<IP_ADDRESS>/<IP_ADDRESS>,frag=no)), packets:460802320, bytes:116122184640, used:0.000s, actions:drop
Could someone tell me ,what's wrong with my configuration? thanks.

i  am sorry to here ask question ,now i get it to ovs-discussion .


fixed ak expire handler bug

fixed ak expire handler bug

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Subdiagram improvements

This PR addresses #113, but it's still work in progress. I've started by fixing the example from that issue and by following the plan laid out by Sasha. The next steps are to add the extra functionality.
TODO

[x] get_location to retrieve the local origin of the Subdiagram
[x] qualify diagram names by prefixing them with a given name
[x] with_name (unclear whether this function can be used easily in Python, given that its most natural style involves nested lambda expressions)
[x] boundary_from to return points on the boundary of a given Subdiagram given a direction vector
[x] show_labels to show label names on top the diagram
[ ] style as an attribute to the Subdiagram class (unclear whether this is useful for the current API)
[ ] Bonus: label on arrow?
[ ] Documentation

I agree withName is a bit too aggressive for python. It looks like there is also a with_names function though that might be better.

It looks like there is also a with_names function though that might be better.

Yes, you are right, with_names looks more appropriate for us. I've replaced with_name with with_names and added some examples (translated from Haskell) in the documentation.
I think I'll move the task of adding labels to arrows to a separate issue (and PR) since it appears a bit more involved at first sight, especially if we want it to work on arrows with arbitrary trails (shafts).


BP Form - Class "JEventDispatcher" not found...

Hello,
migration from j3.9 to j4
php 8.2.18
url: https://orgamed-services.com/nous-contacter.html
"BP Form" first install.
without captcha, everything is fine
but activating captcha on BP Form module returns an error : Class "JEventDispatcher" not found
do i miss something?
thanks

Hi. You are using a Joomla! 3 module version in Joomla! 4. Module for Joomla! 4 is almost ready (there are 2 issues we need to fix before releasing) but not sure about release date. Most likely end of month. New module have more features and is mostly incompatible with previous one so you would need to create the form again.

don't i feel stupid ?  :( yes i do !!!!


Add aria2 for alternate download method.

aria2 is a very excellent download tool, than can speed up downloading.
Use aria2 for downloading if exists. axel is another download tool, but it cannot handle redirect gracefully.

I really like the idea of using aria2, but have a few remarks about the PR. If you're happy and willing to make the changes I'll merge it.

currently has no test coverage
should be driven by a configuration, something like sdkman_download_tool=curl|aria2
would like aria2 to give some progress, not dumping all output to /dev/null

Sorry, I'm not familiar with cucumber, I don't know how to test.
I've already add sdkman_download_tool configuration.

Okay, I can help with writing some new tests. However, I can only really merge if all the current tests are passing.

Test passed. It's my fault that I forgot to set default fallback sdkman_download_tool.

Typo is easy to fix. You mean that we should consider curl as default download tool, without checking aria2 is existed?

Hi @marc0der. I've already merged your upstream codes and reformated my codes again. Please checkout. Let me know if you have any questions.

No it won't, it merely opens a sub-shell.
On Fri, 24 Mar 2017, 07:10 Feng Yu<EMAIL_ADDRESS>wrote:

@abcfy2 commented on this pull request.
In src/main/bash/sdkman-utils.sh
https://github.com/sdkman/sdkman-cli/pull/497#discussion_r107845322:

fi

curl ${curl_params} "$1"

if [[ "${sdkman_download_tool}" == 'aria2' ]]; then

aria2c --dir=$(dirname "$2") --out=$(basename "$2") $aria2_params "$1"

No. $() will automatic escape the spaces and other special characters.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sdkman/sdkman-cli/pull/497#discussion_r107845322, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAI0Bq_a3DWHfA-J1EinRVUUC-0Yjwhwks5ro2xOgaJpZM4LHfnV
.

 Add aria2c as download alternative


Copy pdf text?

Hi, I have a pdf text, how to copy text?

iOS Version: 9/10
Xcode Version: 8.2
Swift Version: 3.0

There is currently no way to copy text inside of a pdf. This would involve parsing the font and text of the PDF, which while on the roadmap, is not currently implemented.


⚠ Bofrost.lu has degraded performance

In d8aa24d, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1328 ms

Resolved: Bofrost.lu performance has improved in b977623.


Preconditioner

This pull request implements a new preconditioner intended to improve the condition of the equation system matrices and solving #87. The preconditioner appears to be working as expected, although it does not appear to solve the issue with MUMPS where the equation system suddenly crashes for no apparent reason.

I've been through it in some detail and think it looks ready to go now!


Fix cursor interaction with transformed UI elements

Objective
This is a simple proof of concept to correct UI interaction with rotated and scaled UI elements. Not sure what to do about clipping.
Included in the PR is an example, button_transform, to prove it behaves as expected.
Solution
Project the cursor's coordinates onto a local coordinate system defined by the UI entity's local basis vectors before doing bounds checking.
This should be a very cheap operation, and so far only changes a couple of lines in ui_focus_system.

It's good to see this fix work, but I'm not sure that this is good behavior to support :) See the discussion about a dedicated UI transform type in #4213.

I think a ui system that can only ever support axis aligned rectangles for interaction might be extremely limiting. Fusion 360, Blender, and various drawing apps all make use of ui elements that don't fit that model, and dial style menus are popular particularly on touch devices.
I don't really mind either way though. I wrote this code a while ago for a 2d/sprite ui system (since flexbox is too inflexible for my project), and was pleasantly surprised to find it could be ported to bevy_ui's interaction system.

I think a ui system that can only ever support axis aligned rectangles for interaction might be extremely limiting. Fusion 360, Blender, and various drawing apps all make use of ui elements that don't fit that model, and dial style menus are popular particularly on touch devices.

I'd imagine this is a fundamental building block, though. And supporting non-rectangle interaction could be specialized (such as for the dial menus). At that point, it's up to the user (or a more specific Bevy UI element) to handle "true" interaction imo

supporting non-rectangle interaction could be specialized (such as for the dial menus).

That's true, and other primitives such as ellipses and SDFs could be useful for bespoke UI elements.
That said, this draft is just about enabling non-axis aligned rects, which may be useful in their own right.

@ickk sorry for the delay, would you be able to rebase this PR?

@ickk sorry for the delay, would you be able to rebase this PR?

Umm.. I could, but it's a bit complicated since GlobalTransform moved to an Affine3A representation; I'm not sure how expensive calling .compute_transform is. There were also still unanswered questions in this draft, like what to do with the clipping (which this draft just comments out I think...)


default light colors list.focusHighlightForeground too close to list.activeSelectionBackground

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.57.1 and Insiders
OS Version: Windows 10

Hi, I'm writing an extension contributing a theme.
package.json
"themes": [
      {
        "label": "my theme",
        "uiTheme": "vs",
        "path": "./themes/my-color-theme.json"
      }
]

my-color-theme.json
{
  "name": "my theme",
  "semanticHighlighting": true,
  "semanticTokenColors": {
    "keyword": { "foreground": "#00f" }
  }
}

I only want to provide some semantic token colors and don't have any workbench colors. It works well inheriting default light theme until 1.57, probably by #122893
I know I can add list.focusHighlightForeground in my theme to bypass this. But I'd like to simply inherit all default colors.
Steps to Reproduce:

Open command palette and type to filter

https://github.com/microsoft/vscode/commit/97a719dd9b6f56ae724df1beb79944596d998eb6 added "list.focusHighlightForeground": "#9DDDFF" to light_vs.json. I think this should have gone directly in the default for list.focusHighlightForeground
Note, light_vs.json should not contain much colors, as our light defaults already reflect our light theme.

I think this should have gone directly in the default for list.focusHighlightForeground

This was intentionally only added to our light theme (and not as the default) because this broke with nearly all light themes in the marketplace.

Currently all light theme that don't define `l
ist.highlightForeground" (or `list.focusHighlightForeground

Here's what I see when changing the light default of listHighlightForeground to 9DDDFF

Need to look at this with @misolori.
There's no easy restoring of the old state, and we need to discuss what's the direction forward.

New attempt:

The default of list.focusHighlightForeground is now:

if the theme defines list.activeSelectionBackground it is list.highlightForeground
else #9DDDFF

This comes from the observation that existing themes that modified list.activeSelectionBackground made it work with list.highlightForeground.


Infinite reconnection retries using an expired certificate

I really like the way pushy provides connection persistency with APNS using automatic reconnects.
But, as far as I can see, there is a problem with this feature. Our push notifications delivery service maintains a set of APNS clients connected over a long period of time to be able to deliver notifications instantly. In the following case the APNS client attempts to reconnect indefinitely and there is no way to subscribe to the reconnect event while the connection is successful and no notifications are sent:

The connection was successful while the certificate was valid
In the meantime the certificate expired and the APNS disconnected the client
The client connects indefinitely until disconnect() is called and the log is filled with the following error

javax.net.ssl.SSLException: Received fatal alert: certificate_unknown
        at sun.security.ssl.Alerts.getSSLException(Alerts.java:219)
        at sun.security.ssl.SSLEngineImpl.fatal(SSLEngineImpl.java:1666)
        at sun.security.ssl.SSLEngineImpl.fatal(SSLEngineImpl.java:1634)
        at sun.security.ssl.SSLEngineImpl.recvAlert(SSLEngineImpl.java:1800)
        at sun.security.ssl.SSLEngineImpl.readRecord(SSLEngineImpl.java:1083)
        at sun.security.ssl.SSLEngineImpl.readNetRecord(SSLEngineImpl.java:907)
        at sun.security.ssl.SSLEngineImpl.unwrap(SSLEngineImpl.java:781)
        at javax.net.ssl.SSLEngine.unwrap(SSLEngine.java:624)
        at io.netty.handler.ssl.JdkSslEngine.unwrap(JdkSslEngine.java:82)
        at io.netty.handler.ssl.SslHandler.unwrap(SslHandler.java:1098)
        at io.netty.handler.ssl.SslHandler.unwrap(SslHandler.java:970)
        at io.netty.handler.ssl.SslHandler.decode(SslHandler.java:904)
        at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:387)
        at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:245)
        at io.netty.channel.ChannelHandlerInvokerUtil.invokeChannelReadNow(ChannelHandlerInvokerUtil.java:83)
        at io.netty.channel.DefaultChannelHandlerInvoker.invokeChannelRead(DefaultChannelHandlerInvoker.java:154)
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:354)
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:145)
        at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:1078)
        at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:117)
        at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:527)
        at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:484)
        at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:398)
        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:370)
        at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:742)
        at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:145)
        at java.lang.Thread.run(Thread.java:745)

Wouldn't it be better to provide a way to subscribe to a reconnect event even if connected (which would not succeed immediately like it does now) and let the client decide if reconnection should go ahead or better yet don't try to reconnect when it's certain that subsequent request will not work like in the above case.
Currently if one maintains a set of APNS clients there is no way around this but to periodically check each client's isConnected() attribute.
Thanks for developing this awesome library.

Wouldn't it be better to provide a way to subscribe to a reconnect event even if connected…

I definitely see where you're going, and this is actually what we used to do in the pre-HTTP/2 days. Now that reconnection is much less frequent, though, I'm worried that exposing reconnection listeners would introduce a lot of complexity/generality for for a pretty specific problem.
One thing we learned about reconnection listeners is that, when you're just looking at an exception, it's hard to tell the difference between an expired certificate and some other transient problem. To check for expired certificates specifically, it seems like callers could achieve the same thing more reliably by keeping track of X509Certificate#getNotAfter(). Would that work in your case? If not, why?

You are right that would be better and would work, but it would cover only the cases when the certificate expires. Certificates might stop working because they are removed from the developer account. I think I'll stick to checking isConnected() periodically for all clients and disconnecting the ones that don't seem to able to reconnect.

Certificates might stop working because they are removed from the developer account.

That's a good point, and not a case I'd really been thinking about.

I think I'll stick to checking isConnected() periodically for all clients and disconnecting the ones that don't seem to able to reconnect.

That seems a little risky, since there may be false positives due to normal reconnection. If you have a monitoring platform you like, how about using an ApnsClientMetricsListener instead? You could look for an unusual increase in the number of connection attempts and set alarms accordingly. Does that seem reasonable?

That seems a little risky, since there may be false positives due to normal reconnection. If you have a monitoring platform you like, how about using an ApnsClientMetricsListener instead? You could look for an unusual increase in the number of connection attempts and set alarms accordingly. Does that seem reasonable?

Thanks, I haven't thought of that, this solution sounds much better and I think I'll used it since I do have a monitoring platform. It provides just the information that I thought was missing so I'm going to close the issue.

Cool! Glad to hear that will work for you, and thanks for all your patience in exploring the options!


compilation error: duplicate definition of item

Hi, I wanted to use wtl-rs in designing of a new app, but attempt to compile wtl-rs resulted in errors:
error[E0592]: duplicate definitions with name item
--> pkg\winapi\src\macros.rs:148:13
|
148  |             pub unsafe fn $variant(&self) -> &$fieldtype {
|             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|             |
|             duplicate definitions for item
|             other definition for item
|
::: pkg\winapi\src\commctrl.rs:2496:1
|
2496 | UNION!(TVINSERTSTRUCTA, itemex, item, item_mut, TV_ITEMA);
| ---------------------------------------------------------- in this macro invocation
|
= note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0592]: duplicate definitions with name item_mut
--> pkg\winapi\src\macros.rs:152:13
|
152  |             pub unsafe fn $variantmut(&mut self) -> &mut $fieldtype {
|             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|             |
|             duplicate definitions for item_mut
|             other definition for item_mut
|
::: pkg\winapi\src\commctrl.rs:2496:1
|
2496 | UNION!(TVINSERTSTRUCTA, itemex, item, item_mut, TV_ITEMA);
| ---------------------------------------------------------- in this macro invocation
|
= note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
What would be the right approach to fix the errors?
Thanks from Arizona!

I have fixed this bug, and other bugs that I came across, and published the latest code here: https://github.com/phoenicyan/wtl-rs. It compiles with Rust 1.48. I did not find how to contribute into this repo, so I created new copy.


[Need help] Any way to reset the chosen value from outside the picker?

I'd like to reset the chosen values from outside the picker. When a value is chosen in the modal picker a state is set. When the user then presses a button the values are submitted to my API. When the API then returns an OK status I want to reset the values chosen in the modal picker. This doesn't seem to happen when I pop the route.
Any ideas?

I did a dirty hack but for now it solves the problem:
So what i did was, i created a ref in the ModalPicker, and when i'm gonna clear the data from my view, i set the state from ModalPicker and set the state from my view.
It's a dirty hack but for now is better than nothing.
Component:
            <ModalPicker
              ref={(input) => { this.test = input; }}
              data={positionsArray}
              initValue={positionsArray[0].label}
              onChange={(option) => this.setState({selectedPosition:option.key})} />

      clear=()=>{
        this.teste.setState({selected:"---"})
          this.setState({
            selectedPosition:0,
          })
      }


Setup Tasks

Taking a step toward separating concerns

Black Duck Security Report
Merging #70 into master will not change security risk.
Click here to see full report


Update macdown to 0.7.1

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

It was released 3 hours ago.
Its new sha256 is 4b26fb70b399cd998f226a78f81cd74348da19a8953aca80169fd7d00667496c.


Re-enable Gateway conformance tests

Please provide a description of this PR:

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
52c0c568836379ff67c482c200f0a482576e6772
link
unknown
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-mc_istio
52c0c568836379ff67c482c200f0a482576e6772
link
unknown
/test integ-telemetry-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-mc_istio


Fix nacos registry memory leak

What is the purpose of the change
Fix https://github.com/apache/dubbo/issues/9202
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #9261 (7661fd2) into 3.0 (3b9d6af) will decrease coverage by 0.18%.
The diff coverage is 30.00%.

@@             Coverage Diff              @@
##                3.0    #9261      +/-   ##
============================================
- Coverage     64.76%   64.58%   -0.19%
+ Complexity      329      328       -1
============================================
  Files          1206     1206
  Lines         51802    51817      +15
  Branches       7716     7688      -28
============================================
- Hits          33551    33466      -85
- Misses        14637    14729      +92
- Partials       3614     3622       +8

Impacted Files
Coverage Δ

...org/apache/dubbo/registry/nacos/NacosRegistry.java
50.76% <30.00%> (-1.02%)
:arrow_down:

...ache/dubbo/remoting/transport/AbstractChannel.java
75.00% <0.00%> (-12.50%)
:arrow_down:

...dubbo/common/status/support/LoadStatusChecker.java
50.00% <0.00%> (-11.54%)
:arrow_down:

...mmon/threadpool/support/fixed/FixedThreadPool.java
80.00% <0.00%> (-7.50%)
:arrow_down:

.../common/threadpool/serial/SerializingExecutor.java
70.37% <0.00%> (-7.41%)
:arrow_down:

...ng/transport/dispatcher/all/AllChannelHandler.java
62.06% <0.00%> (-6.90%)
:arrow_down:

.../org/apache/dubbo/rpc/protocol/tri/WriteQueue.java
68.75% <0.00%> (-6.25%)
:arrow_down:

.../threadpool/support/limited/LimitedThreadPool.java
83.33% <0.00%> (-5.56%)
:arrow_down:

...mmon/threadpool/support/AbortPolicyWithReport.java
78.94% <0.00%> (-5.27%)
:arrow_down:

...o/rpc/protocol/injvm/DefaultParamDeepCopyUtil.java
57.89% <0.00%> (-5.27%)
:arrow_down:

... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b9d6af...7661fd2. Read the comment docs.

org.apache.dubbo.registry.zookeeper#RegistryChildListenerImpl might have same issue.


no address no emails only with Enable Stripe credit card form

Entry:
First: there are two types of possible payment.
stripe checkout - it transfer to stripe website and you need to type all card details + addres
in my case there is no copied address there.
Test show me all info email adress etc.

Payment using a form on merchant page.
Here we have a form on our shop
image

Here we put only credit/debit card number and pay. There is no needs to add address.
In this method(Enable Stripe credit card form ) i have no email.

Pay by stripe checkout is OK but I need to write again the address.
@getdatakick can you check this if you have the same problem?
Pay using Enable Stripe credit card form

I believe this is configuration problem. Please check your stripe configuration, specifically AVS settings.


Meshes that are described in animation tracks should be ignored

Nodes referenced in animations should not be merged.

Done. See https://github.com/godot-extended-libraries/scene_merge/commit/7ee9b73d4a2269d93a8ad37db5f7fcc254cb2ef6


Revert "Update rubocop-rspec 3.0.3 → 3.0.4 (patch)"

Reverts sanger/sm_workflow_lims#452

This Revert PR is no longer necessary because the problem has been fixed.

Closing this as it is not necessary to revert anymore.


JetBrains displays Runtime Analysis finding pages

Demo Video of feature in VS Code:
https://appmap-io.zoom.us/rec/share/lBo4ME8KFPu1-lqsVLB4DMQlVpZdzTdUyp_i_eJ_spQwP48rerZ-KvHa2lvZ7Y_e.Y8HXf-Abd_UeX54m (Passcode: 0176M=qx)


portability documentation

It would be good to mention just which OS's this is known to work on. The need for 64 bit values for modern disk sizes may be a complication for some OS's too, so it's probably worth a mention.
I've been maintaining similar portable code in git-annex, so I compared the two.
The OS's I'm confident disk-free-space works on, after testing: Linux, OSX, Windows, Debian kFreeBSD. Probably regular FreeBSD, but I don't know for sure. OpenBSD: Don't know.

I remember that before I released disk-free-space, I tested it on the following platforms: Linux (i386, x86_64, arm, ppc), OS X (don't remember the version, probably ~10.7), Windows XP 32 bit, FreeBSD 9.0 (i386). statvfs is a somewhat new function, but for example FreeBSD seems to support it since 5.0 which was released on January 2003. It also appears that it is supported by netbsd and solaris.


[Stripchat] Add extractor

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[ ] Improvement
[x] New extractor
[ ] New feature

Description of your pull request and other information
Adds extractor for the webcam site, https://stripchat.com/

One thing I could use a little help on is how to allow Ctrl-C to work safely.
For example, if I use yt-dlp with a chaturbate.com address, and I run Ctrl+C, it cleans up safely and creates a working MP4 file. But using this extractor, if I Ctrl+C, I get an unusable MP4 file. If I let the stream end on its own accord (like when the model goes offline), the MP4 is fine.

After some debugging with folks in Discord, it doesn't look like it has anything to do with the extractor, but with the default downloader args sent to ffmpeg. So this should be ready for review.


Assert that interfaces are applied to sources

The Fetchable, Transformable, Queryable, and Updatable interfaces should assert that they're being applied to instances of Source. In that way, they can guarantee that the source implements Evented.

Superceded by #328, which removes the Source class from the base Orbit project and requires each interface to verify its own dependencies.


Add chain specific account prefix support for relayer keys

Fixes #25

I think we should try considering pubkey prefix too from config

Closing this in favour of #40


[BUG] RHEL 8.3 crc provides vague WARN when pdnsd service is running (Failed public DNS, Wildcard DNS)

General information

OS: Linux (RHEL 8.3)
Hypervisor: KVM
Did you run crc setup before starting it (Yes)?
Running CRC on: Laptop

CRC version
CodeReady Containers version: 1.25.0+0e5748c8
OpenShift version: 4.7.5 (embedded in executable)

CRC status
CRC VM:          Running
OpenShift:       Unreachable (v4.7.5)
Disk Usage:      17.7GB of 32.74GB (Inside the CRC VM)
Cache Usage:     13.4GB
Cache Directory: /home/david.bensimon/.crc/cache

CRC config
- consent-telemetry                     : no

Host Operating System
NAME="Red Hat Enterprise Linux"
VERSION="8.3 (Ootpa)"
ID="rhel"
ID_LIKE="fedora"
VERSION_ID="8.3"
PLATFORM_ID="platform:el8"
PRETTY_NAME="Red Hat Enterprise Linux 8.3 (Ootpa)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:redhat:enterprise_linux:8.3:GA"
HOME_URL="https://www.redhat.com/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 8"
REDHAT_BUGZILLA_PRODUCT_VERSION=8.3
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="8.3"

Steps to reproduce
Context: I recently received a Laptop from IBM with RHEL 8.3. IBM's RHEL image is peculiar in that pdnsd is installed, which may differ from a typical RHEL installation. pdnsd is a DNS server designed for local caching of DNS information. Unfortunately it silently gets in the way of setting up CodeReady Containers. Because of this, while attempting to install CodeReady Containers you may get warnings related to DNS resolution not working correctly.

Run crc setup
Run crc start -p pull-secret.txt

Expected

Expected local Openshift cluster to be started started and wildcard on apps-crc.testing to works.
Expected crc setup to detect pdnsd package is installed, pdnsd service is running, and offer to disable the service or remove the package.
Expected crc start output WARN error to better indicate the cause of the DNS issue.

Actual
Due to the error below, Web console is accessible but deployed applications are not.
$ crc start -p pull-secret.txt
...
WARN Failed public DNS query from the cluster: ssh command error:
command: host -R 3 quay.io
err: Process exited with status 1\n : Host quay.io not found: 2(SERVFAIL)
...
WARN Wildcard DNS resolution for apps-crc.testing does not appear to be working
...

Additionally (out of scope of this bug) crc makes changes to DNS resolution server in /etc/resolv.conf is and adds hosts in /etc/hosts which do not seem to be restored when running crc delete. This may leave the user unable to resolve domain names after running crc setup; crc start; crc stop; crc delete
Notes
This is very similar to what was previously reported by arturobrzut in issue #1663 back in Nov 2020, which has since gone stale.
I opened this bug to request that we modify crc setup to have it perform an additional checks for the pdnsd package and service, thereby guiding the user to resolve the issue. To resolve the issue, see fix below.
Fix

Disable the conflicting pdnsd service:

sudo systemctl stop pdnsd.service
sudo systemctl disable pdnsd.service

Add the following lines to /etc/NetworkManager/dnsmasq.d/crc.conf in order to use Google's Public DNS servers (<IP_ADDRESS> and <IP_ADDRESS>), as well as DNS provided by your router. You should verify your router address or local DNS server address, in my case it's <IP_ADDRESS> so I added the following lines:

server=<IP_ADDRESS>
server=<IP_ADDRESS>
server=<IP_ADDRESS>

crc start will now run without DNS errors.

We are working on vsock which will ideally remove those configurations. With 1.26.0 release we are adding doc section around how you can use vsock.

And even without vsock, I'm not sure we would be adding automatic configuration on non-default RHEL installs. We should detect problematic situations better though (for example, error out early if we detect that a DNS server is running, which means we can't configure dnsmasq correctly).


Expose V's install dir and examples via ENV vars

As the title states it would be nice to be able to get info about where these locations are from the shell.
For me it'd be nice to have them when testing vab against the official examples.

@Larpon setup-v now has output! check the doc here!

Perfect! Thanks @ulises-jeremias !


docs: add migration guide for v2

Closes #
📝 Description
Adds migration guide to migration from chakra v1 to chakra v2.

My pleasure ! ⚡ 😊  Thanks for the review @TimKolberger 💞


Intellij IDEA doesn't recognizes modules and directories

Description
directory:

module:

Versions

IntelliJ:

IntelliJ IDEA 2018.2.5 (Ultimate Edition)
Build #IU-182.4892.20, built on October 16, 2018

The version of intellij-emberjs:

2018.2.4-0

is there any chance to look at this ? Seems like a basic thing to have for an ember plugin.

@teejayhh it is quite hard to implement properly and for me personally it's not a high priority. I'm happy to review pull requests that implement it though.

Where does one start to fix this?

hey @Turbo87
Thanks for supporting this! Any news towards this issue? While the warnings themselves do not seem important, actually if you try to create diagrams using Webstotm for instance, they will have some issues.
For example, following one shows how the diagrams appear with the issue and how they do if you change pathing to "./baseroute".
Regards

Any news towards this issue?

still the same status as in my last comment. if someone wants to implement this feel free. I'm currently maxed out in my open-source work capacity.


Proposal: Add Logging driver for fluentd

I think that some more Logging driver make users happy!
This is the first for more logging drivers for Fluentd.
See the files for more details.

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "proposal-logger-driver-fluentd" git@github.com:tagomoris/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

This will update the existing PR, so you do not need to open a new one.

I'm sorry to miss it. I added.

:+1:

:+1:

:+1:

:+1:

:+1:

:+1:

:+1:

:+1:

:+1:

hey all we get it you want this, but can you not +1, because it makes feedback hard to read :), we promise we will do our best to review this as soon as possible

adding this seems fine to me

@jfrazelle Just a background. @tagomoris is a maintainer of Fluentd (http://www.fluentd.org/), and I'm from Treasure Data sponsoring Fluentd project.
We recently started seeing more people adopting Docker + Fluentd. For example. Google's Kubernetes adopted Fluentd as a default log collector. But this uses Fluentd's 'tail' input plugin for log files, so it's not something performant and config files become messy...

https://github.com/GoogleCloudPlatform/kubernetes/tree/master/cluster/addons/fluentd-elasticsearch

Digital ocean wrote a documentation about how to centralize Docker logs into one place, using Fluentd. But as I mentioned above, it tails log files.

https://www.digitalocean.com/community/tutorials/how-to-centralize-your-docker-logs-with-fluentd-and-elasticsearch-on-ubuntu-14-04

We'd like to have a way to directly push the logs from Docker to Fluentd, which is more performant and reliable. Just in case, @tagomoris already wrote a code so that you can review.

https://github.com/tagomoris/docker/tree/logger-driver-fluentd

Logging is the essential part of the immutable infrastructure, so hope Docker has a flexible way to centralized logs using the solution like Fluentd.

:+1:

Definitely +1 as long as we can ping for issues. @tagomoris @kzk do you plan to contribute code for this?
Also, proposal doc is probably longer than the actual implementation will be :)

I already have a complete code for this feature.
So I've just created a pull request #12876.

can you then combine this with that one so there are not two threads for the same feature and close this one

@cpuguy83 I can give you our point of contacts for you guys. Please reach out to me at<EMAIL_ADDRESS>

I think we can close this, because now it is real PR #12876


Fix empty string match

Hi,
I've found a bug while using cherrypy framework.
When mapper.routematch('') is called (internally inside of cherrypy) Routes raise RoutesException('URL or environ must be provided'), which is wrong. I've registered URL handler for that route and it has to resolve.
Traceback (most recent call last):
  File "/home/wk/src/pyenv-3.5/lib/python3.5/site-packages/cherrypy/_cprequest.py", line 642, in respond
    self.get_resource(path_info)
  File "/home/wk/src/pyenv-3.5/lib/python3.5/site-packages/cherrypy/_cprequest.py", line 760, in get_resource
    dispatch(path)
  File "/home/wk/src/pyenv-3.5/lib/python3.5/site-packages/cherrypy/_cpdispatch.py", line 524, in __call__
    func = self.find_handler(path_info)
  File "/home/wk/src/pyenv-3.5/lib/python3.5/site-packages/cherrypy/_cpdispatch.py", line 539, in find_handler
    config.environ = request.wsgi_environ
  File "/home/wk/src/pyenv-3.5/lib/python3.5/site-packages/routes/__init__.py", line 23, in __setattr__
    self.load_wsgi_environ(value)
  File "/home/wk/src/pyenv-3.5/lib/python3.5/site-packages/routes/__init__.py", line 52, in load_wsgi_environ
    result = mapper.routematch(path)
  File "/home/wk/src/pyenv-3.5/lib/python3.5/site-packages/routes/mapper.py", line 715, in routematch
    raise RoutesException('URL or environ must be provided')
routes.util.RoutesException: URL or environ must be provided

This PR fixes that.

@bbangert ping

Looks good, it's just missing a CHANGELOG entry, and I'll be happy to merge it.

@bbangert done.
BTW, it's worth mentioning in CONTRIBUTING.md file :)

Thanks!