Can't rename a file/folder when only changing its case on a case insensitive filesystem (Windows, macOS)

Bugsquad note: This issue has been confirmed several times already. No need to confirm it further.

Godot version:
3.0.3-stable
OS/device including version:
Windows 10
Issue description:
I was renaming a folder called 'UI' to 'ui' and received a message saying "Error moving: res://ui/". There used to be a similar issue in 3.0
Steps to reproduce:
Create a folder called "UI" and try to rename it to "ui".

That's a limitation of Windows, most tools on Windows (including explorer.exe) won't let you rename a folder or file to only change the case (Windows doesn't care about case).
So you'd have to rename it to something else like "UI_" before renaming it to "ui".
Maybe the error message can be improved though.

Windows doesn't care about case

Starting with Redstone 4 (April 2018 update) Windows 10 should support case-sensitive file system mode, you can enable it on per directory basis using following command:
fsutil file setcasesensitiveinfo <directory_path> enable

@bruvzg: Not everyone is on Win10, y'know...

Starting with Redstone 4 (April 2018 update) Windows 10 should support case-sensitive file system mode, you can enable it on per directory basis using following command:
fsutil file setcasesensitiveinfo <directory_path> enable

That might be interesting to put in the Godot docs (e.g. http://docs.godotengine.org/en/latest/getting_started/workflow/project_setup/project_organization.html ) so that Windows 10 users know about it. Since Godot cares about case, it would be a good practice to use that option for Godot project folders on Windows.

I thought I fixed this in master some time ago... Did I forget to cherry pick my own fix? I'll check.

So you'd have to rename it to something else like "UI_" before renaming it to "ui".

This sounds like a workaround that could be automated?

Wasn't this fixed by #15959? It's closed but it was manually merged.

Wasn't this fixed by #15959? It's closed but it was manually merged.

That commit made it to 3.0.3-stable at any rate, so it seems not to be enough: 000caef6

I recall this issue was fixed for a bit but as mentioned is no longer working.

It's also present on OSX High Sierra

@UgisBrekis sounds like we've got a regression on our hands.

It's also present on OSX High Sierra

macOS can use both case sensitive and case insensitive HFS+/APFS filesystems, renaming doesn't work on case insensitive volumes and works on case sensitive (tested with master 0a1c1c660). By default system volume is case insensitive.

Windows 10: I just renamed the folder with an additional space, then go back and take the space out.
Not a big deal. Annoying, but not a big deal.

Renaming a folder's name to a new case is still an issue in Windows 10, as of Godot v3.1.1.stable.official. There are 2 ways to work around this.

As mentioned previously, rename the folder in Godot to a new name and then rename back to the previous name under a new case. (ex. "Folder" -> "sprite_folder" -> "folder")
As of this date, you can open File Explorer and rename the folder's name case without visible errors.

In both cases, Godot will reimport your assets in the renamed folder(s).

Why doesn't this have the bug label?

Not just folders, it's also scripts, scenes, resources.

On the Mac the behavior of file_exists() is return true whether it is upper or lower cased. But the rename will perform the case flip rename from one to the other. Interesting.
Here is gdscript code for that:
func _ready() -> void:
	var file:File=File.new()
	var dir:Directory = Directory.new()

	# Create lower case file if not present
	if !dir.file_exists("res://test.gd"):
		file.open("res://test.gd", File.WRITE)
		file.store_string("contentsomething")
		file.close()

	#Rename to upper case
	var err=dir.rename("res://test.gd","res://TEST.gd")
	print(err)
	print("File exists: ",dir.file_exists("res://test.gd"))
	print("File exists: ",dir.file_exists("res://TEST.gd"))
	pass # Replace with function body.

This is still happening on latest Mac versions, how should we work around this and why isn't this fixed already? Sounds like a simple issue for a problem that's been reported almost 5 years ago 🤷

This is still happening on latest Mac versions, how should we work around this and why isn't this fixed already? Sounds like a simple issue for a problem that's been reported almost 5 years ago shrug

Contributors fix issues on a best-effort basis, so it can take a while for seemingly simple issues to be resolved if there's not much interest from contributors.
Working around this is easy. For example, if you want to rename ABC.tscn to abc.tscn:

Rename ABC.tscn to abc.tscn_
Rename abc.tscn_ to abc.tscn.

This gives you some hints as to implementing this in the engine code in C++ :slightly_smiling_face:

Ran into this one today. Not sure if I can fix it myself but would love to see it fixed 😅

MacOS 12.6
Godot 4.0.beta1 also in Godot 3.5

macOS 12.6
Godot 4.0.beta1 / Godot 3.5

Recent macOS versions default to a case-insensitive filesystem, so this is expected.

Still happens in Godot 4.2.2 using Windows 10.. it's not an error of Windows 10, it's 100% Godot's fault.

@SirisX I can't reproduce this on 4.3.rc 3978628c6 on Windows 11 23H2 (on a case-insensitive NTFS filesystem):
https://github.com/user-attachments/assets/46b25dac-dd8a-493f-9916-7138666cd603
What antivirus program do you use? Can you reproduce this on 4.3.rc2?

It was happening to a folder and script within the folder that was defining a class of the same name. I got around it by renaming it to something else entirely.. it may also be a github issue.


Client.search overwrites earlier searches before completion

So I discovered that when I call LDAP search, if I do two searches in parallel (saying using Bluebird Promises), the first search never emits any events. There are no searchEntrys, no errors, and no end. It appears that even though API leaves the impression that you can perform two searches across the same client in parallel, you really can't the second search actually overwrites the first search, causing the first search to hang forever.
var ldap = require('ldap');
var Promise = require('bluebird');

var ims = ldap.createClient({
  url: 'ldaps://directory'
});

var imsSearch = Promise.promisify(ims.search, ims);
var imsSearchComplete = function (dn, opts) {
  return imsSearch(dn, opts).then(function (res) {
    return new Promise(function (resolve, reject) {
      var results = [];

      res.on('searchEntry', function (entry) {
        results.push(entry.object);
      });
      res.on('error', function (err) {
        if (err) throw err;
      });
      res.on('end', function () {
        resolve(results);
      });
    })
  });
};

Promise.props({
  classes: imsSearchComplete(
    'ou=calendar',
    {
      scope: 'sub',
      filter: '(&(id=667)(objectClass=OrgClass))'
    }
  ),
  persons: imsSearchComplete(
    'ou=people',
    {
      scope: 'sub',
      filter: '(objectClass=OrgPerson)'
    }
  )
}).then(function (results) {
  //this never fires because the results.classes promise never resolves because the 'end' event is never emitted. Only results.persons resolves correctly.
});

E.g. Even the API appears to imply making multiple calls at once to the same client is possible, but in actuality you actually have to wait for each search to end before starting the next search.

It would be valuable to enable debug logging in ldapjs (via node-bunyan) to ensure that this issue is not caused by external control flow problems.

I went to test this again to see if I could figure out the bunyan logger stuff and found the the order of the promises even affects whether they successfully finish or not.
If the persons search is second the classes search never finishes. But if classes is second they both finish successfully. Weird.
The persons search is expected to return oodles of records, the classes only 1.

I have a log but I have to figure out how to redact it and still keep it useful for you, because it's full of personal information I can't expose (it's also 300 lines long because of the number of persons retrieved from LDAP).
I can see both searches in the log. I can also see SearchEntries for the one that never emits events, as well, so it does ultimately get and parse that result from the server. Again the callbacks 'res' argument never triggers the appropriate events for some reason.

After analyzing the logs myself it did end up being the external flow control. Something about running promisify causes the callback registering the event listeners to be delayed until after those events had already fired in some instances.
When I rewrote it as a flat promise it worked as expected.

Hi @jvanalst, I'm having exactly the same problem as you. I tried to write a flat promise as you have suggested but no luck. It works fine when I'm using "ldap", but not "ldaps". I saw you are also using ldaps, could you provide some details on how you solved the problem, please? Thanks.
'use strict';

var ldap = require('ldapjs');
var _ = require('lodash');
var bluebird = require('bluebird');

var LDAP_ADDR = 'ldaps://ldapserver';
var USER = 'user';
var PASSWORD = 'password';
var CAS = ['OUR_CA']

var log = console.log;

var users = ['user_a', 'user_b', 'user_c'];

var client = ldap.createClient({
  url: LDAP_ADDR,
  tlsOptions: {
    ca: CAS
  }
});

var base = 'OU=Users,DC=com';
var userCount = users.length;
var searchCount = 0;
var endCount = 0;

function searchAsync(user) {
  return new Promise(function (resolve, reject) {
    var opts = {
      filter: '(samAccountName=' + user + ')',
      scope: 'sub',
      attributes: ['dn']
    };

    client.search(base, opts, function(err, result) {
      var entries = [];

      var currentCount = ++searchCount;
      log('SEARCH_CB: %s/%s', currentCount, userCount);

      result.on('searchEntry', function (entry) {
        // log(entry.object.dn);
        entries.push(entry);
      });

      result.on('error', function (err) {
        log('ERROR');
        reject(err);
      });

      result.on('end', function (result) {
        endCount++;
        log('END: %s/%s', currentCount, userCount);
        resolve(entries);
      });
    });
  });
}

// callback style
client.bind(USER, PASSWORD, function () {
  return bluebird.map(users, searchAsync)
    .then(function () {
      log('unbind');
      client.unbind();
    });
});

I create and end a new client as part of every search (promise). It's a bunch of overhead, but it seemed unavoidable.

@jvanalst I'm trying a possible solution which might work. https://github.com/mcavage/node-ldapjs/issues/329

⚠ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.
Please include a minimal reproducible example
when opening a new issue.


Windows API DLL

The main focus of this PR is to bring in support for a user mode API for OpenThread on Windows. This is done by exposing most all control path APIs in openthread.h via a new DLL, otApi.dll.
In order to export the functions in a DLL, every function that was to be exported needed to be prefixed with __declspec(dllexport) and __declspec(dllimport) for the code linking in the function. This was achieved with the use of the OTAPI define.
To allow for both x64 and x64 calling conventions on Windows, we use the OTCALL define, which syntactically, must come after the return type.
This causes a fairly ugly addition to the openthread headers. If someone has a better suggestion on how to do this, I am all ears.
The change also brings in the last week or two of driver changes.

Current coverage is 73.27% (diff: 0.00%)

Merging #882 into master will decrease coverage by 0.94%

@@             master       #882   diff @@
==========================================
  Files           113        112     -1
  Lines         16627      16620     -7
  Methods        2299       2295     -4
  Messages          0          0
  Branches       2008       2008
==========================================
- Hits          12341      12178   -163
- Misses         3619       3765   +146
- Partials        667        677    +10

Powered by Codecov. Last update f600840...c87222d

Can you please nudge Travis? The build failure didn't repro on my build for the latest commit.

Ping. Any comments on these changes?

Having a look.

The OTAPI part makes sense. That is pretty standard stuff.
The OTCALL part is kinda weird. I'm not sure I understand why it is necessary. Is Windows doing some sort of weird cross-architecture linking?

Essentially, Windows (I don't know why) has different calling conventions for x86 and x64. The OTCALL handles that.

It looks like travis might need to be kicked. The break seems unrelated.

It seems Travis failed in the same place. Can anyone tell me why it is failing here?
======================================================================
FAIL: test (__main__.Cert_5_1_07_MaxChildCount)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/openthread/openthread/examples/../tests/scripts/thread-cert/Cert_5_1_07_MaxChildCount.py", line 120, in test
    self.assertEqual(self.nodes[ED].get_state(), 'detached')
AssertionError: 'child' != 'detached'

How is the child still attached? Any why would my PR cause it?

I believe it's not your PR, we have seen the same test failing in our local branches.

I submitted #925 in attempt to address the 5.1.7 failures.

Anything left for me to address to merge this?

Need to remove some files that snuck into this PR:

exampels/apps/cli/ot-cli
examples/platforms/posix/libopenthread_posix_settings.cpp


[Guide - The New Architecture] What Backward Compatibility Is

This PR introduces the topic of backward compatibility in the new architecture refactoring and adds some pointers to relevant sections within the guide.

This is green on my end, can we merge it?


[docs] Changed ENV vars from code to complete list

Description
User Stories

As a technical stakeholder i want to know all possible changes to my deployments during an upgrade to prevent issues

Value

Prevention of Issues

Acceptance Criteria

[ ] List of changed ENV vars can be created for every release

Variable Name
Introduced in version
Default Value
Description
dependencies with user  other components

Definition of ready

[ ] Everybody needs to understand the value written in the user story
[ ] Acceptance criteria have to be defined
[ ] All dependencies of the user story need to be identified
[ ] Feature should be seen from an end user perspective
[ ] Story has to be estimated
[ ] Story points need to be less than 20

Definition of done

Functional requirements

[ ] Functionality described in the user story works
[ ] Acceptance criteria are fulfilled

Quality

[ ] Code review happened
[ ] CI is green (that includes new and existing automated tests)
[ ] Critical code received unit tests by the developer

Non-functional requirements

[ ] No sonar cloud issues

Configuration changes

[ ] The next branch of the ocis charts is compatible

@dragonchaser @kobergj As discussed in the standup
@mmattel FYI


Fix typos and formatting in ARCOptimization.rst

This isn't affecting the generated content at all as far as I can see, and all of the .rst files are about to move to markdown.  Thanks, but this isn't actually improving things.


"examples/add-and-commit.js" throw "Error: Invalid path: xxx" on windows

os: windows 7
nodegit: 0.18.3
This line will throw "Error: Invalid path: xxx"

index.addByPath(path.join(directoryName,  fileName))

I changed it to the following, it's ok

index.addByPath(directoryName + '/' + fileName)

Thank you for the bug report, @BoyBoBo! I have opened #1346 which fixes the problem.


chore: improve experience when using docker

Hi! I noticed a couple of things that made me crazy when I was trying to build a PHP generator. Each time I changed something I had to rebuild the whole docker image, where in reality we don't need that. By COPY ./ / docker image was not optimal.
So I added the docker-compose with the mounted whole repository as volume and tweaked the npm scripts to use the docker-compose config. Super simple and it improves performance. Now the Dockerfile is a base image.
Another thing is the docker pipeline. I noticed we don't test if changes made by users are not breaking the Docker Image, and open source has free pipelines... so profit and profit 😄

Gonna fix it in https://github.com/asyncapi/modelina/pull/1198
You are gonna have the same problems in https://github.com/asyncapi/modelina/pull/1196 until the PR is merged.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.424%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4767

Relevant Lines:
5026

💛  - Coveralls

/rtm

Gonna need to wait for release workflow to be done before I can merge this.

this new docker image. I can't figure out from the workflow, is the idea to push it somewhere?
also, what "~" refers too?

You need to be more specific. What file do you refer to? If that's the pipeline the ~ refers to nothing. With each push the pipeline will be executed

this new docker image. I can't figure out from the workflow, is the idea to push it somewhere?

Just to ensure that it can be compiled 🙂
Contributors use this docker image to run the black-box tests, in order to not install all the dependencies themself.

/rtm

@all-contributors please add @Ferror for infra


Formulas in README

Make .pngs of them and drop them in a project folder.
RIP me

Migrating this to the other README issue.


Remove Spark-Wallet

Spark Wallet is not maintained anymore.  We need to remove it because it doesn't work with latest CLN versions.
What would be a good alternative?  RTL?

A patched version of Spark Wallet has been pushed to the dockers repo.


GA release of

Package name: @google-cloud/domains
Current release: BETA
Proposed release: GA
Instructions
Check the lists below, adding tests / documentation as required. Once all the "required" boxes are ticked, please create a release and close this issue.
Required

[ ] 28 days elapsed since last beta release with new API surface
[ ] Server API is GA
[ ] Package API is stable, and we can commit to backward compatibility
[ ] All dependencies are GA

Optional

[ ] Most common / important scenarios have descriptive samples
[ ] Public manual methods have at least one usage sample each (excluding overloads)
[ ] Per-API README includes a full description of the API
[ ] Per-API README contains at least one “getting started” sample using the most common API scenario
[ ] Manual code has been reviewed by API producer
[ ] Manual code has been reviewed by a DPE responsible for samples
[ ] 'Client Libraries' page is added to the product documentation in 'APIs & Reference' section of the product's documentation on Cloud Site

Waiting for stable release.


Debug performance issues in large responses + add download button

get a really big response and run the dev tools profiler on it to see what is eating up performance.
adjust the threshold if needed.
also need to ensure we don't virtualize other media types (files, images etc)

More context
https://discord.com/channels/1135330207960678410/1302055605544026132/1302055605544026132

I think it needs a min-height as well


Implementable on embedded system?

Is this library implementable on an embedded device like the nucleo-f429ZI? I'm having problems with the included libraries and how to make them work for the embedded device. Anny help or direction would be verry useful.

I also wanted to know weather this can be used with STM32 microcontroller


Package request: planka

Project description
The realtime kanban board for workgroups built with React and Redux
Metadata

homepage URL: https://planka.app/
source URL: https://github.com/plankanban/planka
license: AGPL3+
platforms: linux

Add a :+1: reaction to issues you find important.

There is a systemd service. So we could make a NixOS option pretty trivially after packaging.

Looks like it requires Nginx, node.js, and postgresql to build.

Would like to say I'm very interested in this as well. Are there any previous implementations, e.g., in third-party public flakes?

Found an updated and maintained Docker image: https://hub.docker.com/r/linuxserver/planka

@Tanvir1337x
Heh, yeah. I currently have a docker image of it deployed on my server, but I'd honestly rather use a hacky unmaintained flake over a well-maintained docker image, any day. :P

Looks like it requires Nginx, node.js, and postgresql to build.

I might have missed something, but don't see where Nginx is a dependency. Should'nt the nixpkgs just try to reproduce this ?
https://docs.planka.cloud/docs/installation/manual_installation/debian_ubuntu


Dynamic?

When will we be able to dynamically call pipelines within this activity?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ed77a05e-c9fd-ead1-d767-8b41be183634
Version Independent ID: 0f61d8b7-2736-056c-b17e-ed7ad06a413e
Content: Execute Pipeline Activity in Azure Data Factory - Azure Data Factory
Content Source: articles/data-factory/control-flow-execute-pipeline-activity.md
Service: data-factory
GitHub Login: @chez-char

@mirsky72 - Thanks for brining this to our attention. We will investigate it further and update you shortly.

@mirsky72 Thanks for the question. Github forum is dedicated for docs related issues. For any technical queries or clarifications, we encourage to utilise Microsoft Q & A platform. Kindly raise your query on Microsoft Q&A Platform


minWidth/minHeight/maxWidth/maxHeight missing on 0.19?

On updating to 0.19 (from 0.17) I found warning on unsupported styling of minWidth/minHeight/maxWidth/maxHeight. I didn't find anything regarding to these in the breaking change release note and since these are the new stuff only be added since 0.17, any chance this is a mistake?

They were never supported to begin with -- the fact that they showed up in the documentation was a mistake.

Hmm, I was using maxHeight and minHeight effectively in 0.19, but now with 0.20.0-rc I get red the red screen of death.  What is the alternative to allow a view to prevent a view from growing/shrinking beyond a certain height?

height: min(this.state.measuredHeight, maxHeight)

:+1:

@ide That doesn't seem like a great solution as you need to set the state in onMeasure which will re-render the UI. Previously the min/max values would be followed without having to re-render the component.
Is there an alternative way which doesn't require the component to render twice?

No, the layout engine doesn't support that.


Some functions emitted as UNREACHABLE even when reachable/keep-unreachable-funcs is used

I’ve attempted a decompilation of an older Win32 DLL which was compiled using Visual C++ 4 and detected appropriately by RetDec. 553 of 4015 detected functions are being decompiled as UNREACHABLE. For example, this function (simple C++ object constructor):
; function: function_100532ef at 0x100532ef -- 0x100533cb
0x100532ef:   55                     	push ebp
0x100532f0:   8b ec                  	mov ebp, esp
0x100532f2:   6a ff                  	push -1
0x100532f4:   68 b3 33 05 10         	push 0x100533b3
0x100532f9:   64 a1 00 00 00 00      	mov eax, dword ptr fs:[0]
0x100532ff:   50                     	push eax
0x10053300:   64 89 25 00 00 00 00   	mov dword ptr fs:[0], esp
0x10053307:   83 ec 04               	sub esp, 4
0x1005330a:   53                     	push ebx
0x1005330b:   56                     	push esi
0x1005330c:   57                     	push edi
0x1005330d:   89 4d f0               	mov dword ptr [ebp - 0x10], ecx
0x10053310:   8b 4d f0               	mov ecx, dword ptr [ebp - 0x10]
0x10053313:   e8 80 ef 01 00         	call 0x10072298
0x10053318:   c7 45 fc 00 00 00 00   	mov dword ptr [ebp - 4], 0
0x1005331f:   8b 45 f0               	mov eax, dword ptr [ebp - 0x10]
0x10053322:   c7 00 e8 16 08 10      	mov dword ptr [eax], 0x100816e8
0x10053328:   8b 45 f0               	mov eax, dword ptr [ebp - 0x10]
0x1005332b:   c7 40 30 00 00 00 00   	mov dword ptr [eax + 0x30], 0
0x10053332:   8b 45 f0               	mov eax, dword ptr [ebp - 0x10]
0x10053335:   c7 40 20 00 00 00 00   	mov dword ptr [eax + 0x20], 0
0x1005333c:   8b 45 f0               	mov eax, dword ptr [ebp - 0x10]
0x1005333f:   c7 40 34 00 00 00 00   	mov dword ptr [eax + 0x34], 0
0x10053346:   8b 45 f0               	mov eax, dword ptr [ebp - 0x10]
0x10053349:   c7 40 24 00 00 00 00   	mov dword ptr [eax + 0x24], 0
0x10053350:   8b 45 f0               	mov eax, dword ptr [ebp - 0x10]
0x10053353:   c7 40 28 00 00 00 00   	mov dword ptr [eax + 0x28], 0
0x1005335a:   8b 45 f0               	mov eax, dword ptr [ebp - 0x10]
0x1005335d:   c7 40 2c 00 00 00 00   	mov dword ptr [eax + 0x2c], 0
0x10053364:   8b 45 f0               	mov eax, dword ptr [ebp - 0x10]
0x10053367:   c7 40 38 00 00 00 00   	mov dword ptr [eax + 0x38], 0
0x1005336e:   8b 45 f0               	mov eax, dword ptr [ebp - 0x10]
0x10053371:   c7 40 3c 00 00 00 00   	mov dword ptr [eax + 0x3c], 0
0x10053378:   8b 45 f0               	mov eax, dword ptr [ebp - 0x10]
0x1005337b:   c7 40 40 00 00 00 00   	mov dword ptr [eax + 0x40], 0
0x10053382:   8b 45 f0               	mov eax, dword ptr [ebp - 0x10]
0x10053385:   c7 40 44 00 00 00 00   	mov dword ptr [eax + 0x44], 0
0x1005338c:   8b 45 f0               	mov eax, dword ptr [ebp - 0x10]
0x1005338f:   c7 40 48 00 00 00 00   	mov dword ptr [eax + 0x48], 0
0x10053396:   e9 00 00 00 00         	jmp 0x1005339b
0x1005339b:   c7 45 fc ff ff ff ff   	mov dword ptr [ebp - 4], 0xffffffff
0x100533a2:   8b 45 f0               	mov eax, dword ptr [ebp - 0x10]
0x100533a5:   e9 13 00 00 00         	jmp 0x100533bd <function_100532ef+0xce>
0x100533aa:   8b 4d f0               	mov ecx, dword ptr [ebp - 0x10]
0x100533ad:   e8 66 ea 01 00         	call 0x10071e18
0x100533b2:   c3                     	ret
0x100533b3:   b8 80 65 08 10         	mov eax, 0x10086580
0x100533b8:   e9 a3 f1 01 00         	jmp 0x10072560 <unknown_10072560>
0x100533bd:   8b 4d f4               	mov ecx, dword ptr [ebp - 0xc]
0x100533c0:   64 89 0d 00 00 00 00   	mov dword ptr fs:[0], ecx
0x100533c7:   5f                     	pop edi
0x100533c8:   5e                     	pop esi
0x100533c9:   5b                     	pop ebx
0x100533ca:   c9                     	leave
0x100533cb:   c3                     	ret

Currently decompiles to:
int32_t function_100532ef(void) {
    // entry
    abort();
    // UNREACHABLE
}

This seems like it could very well be the same bug as #41, but I am not sure since RAII does not appear to be involved in all of these failures, so decided to open a separate issue.
I ran RetDec with the command retdec-decompiler.sh -k file.dll. I also tried with the extra --backend-no-opts flag to rule out a backend optimiser causing the problem, with the same result.
Unfortunately I don’t have the rights to upload the original binary here, but I am willing to perform additional testing. Please let me know if there is any more information that I can provide, or if you can suggest a specific area of the RetDec code which I might look into to try to find or fix the root cause myself.
Thanks for this great software!
Git revision 1db0cb6379bd59a4c885b04eac8bf51a6d0f400f
macOS 10.12.6, Apple Clang 9<IP_ADDRESS>

This is very likely a case when LLVM works agains us (see this comment). Our flow: binary -> decoding -> LLVM IR -> our optimizations -> LLVM optimizations -> llvmir2hll -> C. What likely happened here is that LLVM IR that came out of our optimization passes have some dubious constructions in it (e.g. something that causes undefined behaviour). Because LLVM passes are designed primarily for compilation, they often discard such code. We need to either hack LLVM to not do it, prevent our passes to generate such code (not always possible with reversed assembly), or write some kind of sanitizer. I like the sanitizer solution, because it would allow us to solve this on our end, without hacking LLVM (we could use vanilla LLVM).
This is a major problem and I added it to our roadmap. We do not really your binary, I think this is unfortunately happening quite often.

I did some digging, documented in #41 - these two issues are certainly the same. I could trace this back to a TODO comment in RetDec. Maybe I'll manage to figure out the data structures involved to fix this properly.

Pull request: https://github.com/avast-tl/retdec/pull/388

Comment related to this: https://github.com/avast-tl/retdec/pull/391#issuecomment-423171852.


Automated Latest Dependency Updates

This is an auto-generated PR with latest dependency updates. Please do not delete the latest-dep-update branch because it's needed by the auto-dependency bot.

Closing because this was already done in https://github.com/alteryx/evalml/pull/2690/


Encoding object has style and contentType

Let's say I have:
requestBody:
  content:
    application/x-www-form-urlencoded:
      schema:
        type: object
        properties:
          address:
            type: object
            properties: {}
      encoding:
        address:
            contentType: "application/json" # This is the default
            style: form # This is the default
            explode: true # This is the default

Since encoding has both a contentType and a style, what do I do with the address property?  Do I decode it as an exploded form object?  Do I extract the value of 'address' from the message body and run it through JSON.parse()?  Do I decode it as an exploded form, but run the value of each key through JSON.parse()?
Or does contentType here only apply to multipart bodies?

I am also running into this question; is there any resolution?

Also running into the same

OK, digging through this more, it was actually fixed in 3.1.0 with the following new text added to style (which, along with explode (but not allowReserved), was extended to support multipart/form-data as well):

If a value is explicitly defined, then the value of contentType (implicit or explicit) SHALL be ignored.

So that at least explains how to override contentType (default or otherwise).  The implication is that if it's not explicitly defined then contentType wins... I guess?  The style text still references query params for default values, so it's still not entirely clear, nor is it entirely clear what is supposed to happen in 3.0, but that's at least a clue.
Since allowReserved was not extended to form-data, then there needs to be a way to not use RFC6570 value expansion (with its automatic percent-encoding), so I'm going to interpret this to mean that despite the wording around defaults, part of this is changing the behavior when no explicit style is defined.
This is going to take more investigation and thought to fully unravel.

@OAI/tsc review request:  It's unclear how to clarify 3.0.4 here.  Even 3.1.1 is a bit murky, but the only thing I can think of for 3.0.4 is to more-or-less backport the 3.1.1 behavior.  Or maybe deem the area implementation-defined (where implementations can choose which of two options to support) while making the 3.1.1-compatible behavior RECOMMENDED?

We can only recommend the 3.1.1 behavior in a patch version, so let's do that.

After a great deal of GitHub archaeology, I've determined that the intent was for contentType vs style to provide approximate parity with the Parameter Object's content vs schema.  A PR is forthcoming (the previously linked PR included a bit, but I split it out as it needs a more thorough explanation and is better handled separately).


Remaining battery energy

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

It says remaining is 3.6 kWh but actually I only have 0.6 kWh left because my battery will stop discharge at 10%.
I have set my SoC end to 10%. I have 30000 Wh.
Expected behaviour
Showing 0 kWh remain when SoC is at 10%
Possible Solutions
I searched through the code but I couldn't find where the math is done. But remove SoC End before calculate the remaining kWh
Mode
lite
Context / Reason
So users don't think there is more kWh than there are

Found it in the code, I will try to make the math as I asking for
https://github.com/slipx06/sunsynk-power-flow-card/blob/706f6f14dbdee815c36edee5457148f7c081c33e/src/cards/full-card.ts#L343

Hi
At the moment the remaining energy is calculated based on total battery capacity and not shutdown SOC.

OK, what do you think of changing that?
I fix until that will be implemented is to change the shutdown SoC to 0% and the amount of energy

Le me think about adding both options


Serialization of Yggdrasil models

Hi guys
I have come across a couple of methods in the library to LoadModel and SaveModel but I haven't seen any interface provided for serialization of a model to string. I can save to a directory and serialize from there but is there a simpler way to do this?
Many thanks.

I've just seen AbstractModel::ExportProto(*mdl, &header). Perhaps this might do the trick. I'll investigate

I've been looking into the ExportProto/ImportProto interface and have used a couple of the options, to String and to Array, but when parsing back into a model none of the options seem to give me back the full original trained model. I'm doing the following:
TO SERIALIZE TRAINED MODEL INTO A STR
auto* predictionModel = dynamic_cast<gradient_boosted_trees::GradientBoostedTreesModel*>(abstractModel.get());
proto::AbstractModel modelProto;
AbstractModel::ExportProto(*predictionModel, &modelProto);
modelProto.SerializeAsString() => modelStr
TO DESERIALIZE FROM A STR BACK INTO A MODEL
proto::AbstractModel modelProto;
modelProto.ParseFromString(modelStr);
gradient_boosted_trees::GradientBoostedTreesModel predictionModel;
AbstractModel::ImportProto(modelProto, &predictionModel);
Should this give me back the full trained model or does serialization only apply to some of the model metadata but not to the whole model (in which case it's not possible to use the deserialized model for prediction)?
Thanks

Hi Jose,
a YDF model is a collection of files, most of them in protobuf format. We do not provide an built-in way to export a model to a string.
Our Javascript port (see yggdrasil_decision_forests/port/javascript ) works with zip-archives containing the model files and this has worked well for us.
AbstractModel::ExportProto() is not part of the public API of YDF and probably shouldn't be used in production - we may change this function at any time. It also does not do what you plan to do - it only exports a small part of the model (that is described in yggdrasil_decision_forests/model/abstract_model.proto. But a model consists of more files such as the model-specific header and the actual node contents.

Hi Richard
Thanks a lot for the reply and the clarification regarding the exportproto/importproto interface. It's a pity that there is no public interface for exporting/importing to/from string.
If I understand correctly, by mentioning the Javascript port you are talking now about saving to files. Should the SaveModel/LoadModel interface not provide this kind of functionality (I have a related thread opened asking this question)? This seems to be a public interface accessed through the model_library lib and in one of the tests provided in Github I see that it's expected that a saved model will have the same full description as a loaded one:
TEST(GradientBoostedTrees, SaveAndLoadModelWithoutPrefix) {
std::unique_ptrmodel::AbstractModel original_model;
// TODO: Simplify this test by having it use a toy model.
EXPECT_OK(model::LoadModel(
file::JoinPath(TestDataDir(), "model", "adult_binary_class_gbdt"),
&original_model));
std::string model_path =
file::JoinPath(test::TmpDirectory(), "saved_model_without_prefix");
EXPECT_OK(SaveModel(model_path, original_model.get(), {}));
std::unique_ptrmodel::AbstractModel loaded_model;
EXPECT_OK(LoadModel(model_path, &loaded_model, {}));
EXPECT_EQ(original_model->DescriptionAndStatistics(/full_definition=/true),
loaded_model->DescriptionAndStatistics(/full_definition=/true));
}
Am I right in expecting the two models, before and after saving/loading should be exactly the same, and both able to predict and give the same results? I ask because my tests do not show this. Before saving, the trained model has 10 trees and all the data seems to be present. After saving and loading again (this saves for me into 2 .pb files, header.pb and data_spec.pb), the model has some information about variable importance etc, but is missing the actual trees so no predictions are possible. This means, I guess, that the above test would fail?

Hi Jose,
Tl;dr: YDF could provide a way to serialize to a string, but we don't see a use case that would justify the added complexity.
A YDF model is a folder containing a variable number of files. Which files a model exactly contains depends on different factors, such as the model type and the model size. Some of the files are in protobuf format, but others are not.
As an example, consider this Random Forest model: prefixed_adult_binary_class_rf You can see that the model contains a prefixed_header.pb, an empty
prefixed_done file, a prefixed_random_forest_header.pb and other files. The only file in this folder that is not part of the model and has been added on Github for documentation purposes is prefixed_description.txt.
Calling SaveModel(absl::string_view directory, const AbstractModel* const mdl, ModelIOOptions io_options = {}) from model_library.h with a pointer to a model will create the given directory and all these files.
The code in your third comment on this issue, however, will only create a subset of these files (namely the header.pb). So it is expected that this code will not work.
The test you pointed out checks that a model that is loaded with LoadModel() and then saved with SaveModel() can be loaded again and will be unchanged. This is always the case (and if it is not, this is a bug and I'd be happy to get a repro). What will not work, however, is take a model, save a subset of files (e.g. using the code you provided in your third comment) and then loading it.
On the larger question of whether or not YDF should provide a built-in way to serialize a model to a string: Adding this functionality is possible, but we do not see the use case for it. In all the use cases that we are aware of, the user is able to just zip (or tar, or base64 encode, or ...) the model directory with a third_party tool / library. Hence, if users need a string, they can create one outside of YDF. Implementing a built-in way in YDF would be non-trivial and therefore add complexity and maintenance load.

Hi Richard
Thanks for the comments above and sorry to keep going on about this.
I'm happy to leave to one side the issue of serializing to string. My last question referred to the SaveModel/LoadModel interface which should work by saving the model to a set of files. This is the interface that seems not to be working for me. To describe briefly what I've done:

I create an abstract learner configured to be GBT (gradient_boosted_trees_config)
I create dataset and dataspec and train the model (TrainWithStatus)
Print out DescriptionAndStatistics => all seems good at this point
SaveModel (path, pointer to trained abstract model) - this interface is from version 0.2.3 of the YDT lib before prefix functionality was added => this saves only 2 .pb files, header and data_spec, to a folder
LoadModel (path, pointer to new abstract model unique pointer)
Print out DescriptionAndStatistics => these are missing the actual values of the model trees, weights, etc

From looking at the code, I suspect the problem is with the saving, as I would expect to see at least a third done file in the folder if nothing else. In terms of the model_library, the only change I can see between versions 0.2.3 and 1.2.0 is the addition of the prefix functionality but I don't imagine this has anything to do with the problem I see.
Let me know your thoughts.

Thanks for the details and patience.
It is likely that the model is being saved using the C++ model.Save method. This is not the correct way to save a model. Please see the documentation of this method for more details. The model should instead be saved using the SaveModel(model, path)  function. Note that loading a model (using "LoadModel") that was saved incorrectly (with model.Save) will raise an error.
Here is an example.
I hope this helps.


Add action typing

I'm looking to get your action first-class supported by https://github.com/krzema12/github-workflows-kt, a Kotlin DSL to write GitHub Action workflows.
They came up with a way to reduce operational load when keeping library's action wrappers in sync with actions' inputs and outputs. The solution includes onboarding https://github.com/krzema12/github-actions-typing. It's as easy as adding an extra YAML file to your repository root, and adding a simple GitHub workflow that validates this new file. Thanks to this, the code generator in the Kotlin DSL can fetch typing info provided by you instead of them, which has a number of benefits. It has no negative effects on current action consumers, they continue to use the action via regular GitHub API, as if the file wasn't there.
In this feature request, I would like to ask you if you're open to introducing such typings in your action. You wouldn't be first - there're already other actions using it, like e.g.: https://github.com/Vampire/setup-wsl or https://github.com/ReactiveCircus/android-emulator-runner (full list here).
If your answer is "yes", feel free to either add it yourself, or let me know - me or some of the library contributors would be happy to post a PR. They're also open to any kind of questions and feedback.

Hi @krzema12 thank you for submitting an issue here. We will decline at this time to include this in this repo.  This action is very focused and we desire to keep the source here focused on the specific task.

@timheuer I believe we have a misunderstanding here. Adding the typings won't make the action less focused in any way, and instead it will make it easier for certain users to consume the action.

@timheuer let me also chime in as an early adopter.
The only change and effect on your action is an additional file action-types.yml where you formally describe the types of inputs and outputs of your action, instead of just using prose.
(Usually you also have one additional GitHub workflow that does some consistency checks for the type file.)
This allows consumers of your action to see exactly and unambiguously which types your action expects and provides.
Additionally it allows libraries like github-workflows-kt (which allows to write GitHub Workflow files in Kotlin instead of YAML) to process these type information programmatically to automatically generate a class so that users of that library can easily and type-safely use your action.

My two cents as an early adopter and a contributor that tries to onboard action-types.yml to other repositories:

The only change and effect on your action is an additional file action-types.yml where you formally describe the types of inputs and outputs of your action, instead of just using prose.

This point is utmost.  I'd kindly suggest you to reconsider "This action is very focused" @timheuer, as this change stabilizes the action even more!

My understanding based on looking is this would require an additional workflow to be executed on this repo.  Is that not the case?

The workflow is not strictly required, but highly recommended to ensure the typings are valid and that they match the inputs from action.yml. It's a very simple workflow. Is it problematic in any way? It still doesn't influence the complexity of the action itself.

There is a bit more overhead for compliance on this repo -- it's maintained by 2 people and not our primary roles, so we're not eager to add things that cause more overhead for us ;-).  I'll take a re-look at adding the types (PR is appreciated) but would not likely add a workflow to the repo.

Thanks! 🙇

@timheuer for this to work on our end, this change needs to be released, i. e. available from your major version tag. Are you planning to release soon? If not, could you do it?

I'll see if I can push a release later today...in a bunch of meetings for a bit.

Released 1.3.1 and updated v1/v1.3 tags

@timheuer I see that version 1.3.1 is tagged, but it is not created as a release on GitHub. Have you stopped creating releases?
This results in @dependabot pull requests being without release notes 😲

@Gakk - yes, sorry...will try to be better here.


Accessibility not work well on TextField

For textfield with label "Name", value "John", and count limit "4/20", the talkback order like:
John, Name 4 slash 20, Edit Box
Which is not well constructed, it should be something like:
Text input for Name, current value is John, character count 4 over 20 (or 4 out of 20)
This block product launch of customer: mulligan
Please help to fix it.

Hi @webbpan0 thanks for filing this issue, can you reach out to me and @jonahwilliams internally to provide more information about this problem and steps to reproduce it inside of the Mulligan codebase?
Thanks!

Deduping this into https://github.com/flutter/flutter/issues/15187


Fix sensitive-results flaky test

Fixes

Fixes the flaky test failure in https://github.com/WordPress/openverse/actions/runs/7793875777, first reported by @sarayourfriend
Description

The test navigates from the search page to the homepage, and then enters a search term. However, in some runs, the test expects to fill in the search term before navigating to the homepage, so it fails.
I added a waitForUrl call to make sure that we're on the homepage before searching.
I realized that we don't need to go to the homepage to view the newly-loaded sensitive results. The request is sent when you toggle the sensitive switch. So, instead of going to the homepage, I added a check for sent request with the sensitive parameter.
Testing Instructions

The CI should pass
Checklist

[ ] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[ ] My pull request targets the default branch of the repository (main) or a parent feature branch.
[ ] My commit messages follow best practices.
[ ] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Merging this PR into #3759 to make sure there are no test flakiness in that PR's CI.


Python 3.12 support

This does not work yet, as we need to wait for more dependencies to be updated with support. This PR should just need the lock files regenerating when that happens.
Fixes #199

It seems that mo_pack is the one needed package not yet updated with python 3.12 support.

Hmm, it appears that cartopy is the blocker now.

py312-linux-tests: commands succeeded

🎉

resolved conflict and merged again


ARROW-10011: [C++] Make FindRE2.cmake re-entrant

@github-actions autotune everything

@github-actions autotune everything


a issue i have

hey @copy  when will you ever fix the boot versions of windows 9x and windows 2000 on v86 please

https://github.com/copy/v86/issues/1128#issuecomment-2301781635


GET HTML route for login page

Create HTML route for login page

https://github.com/otekolste/answer-hive/pull/42


⚠ Bofrost.de has degraded performance

In 4c5f46e, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1207 ms

Resolved: Bofrost.de performance has improved in 4012853 after 13 minutes.


[stablehlo] Remove potential double-free in ReorderBroadcastInDimOpAndElementwiseOp

This fix a double free that occurs when the two Broadcast operations are the same operation.

When does it happen? Can you add a test?

When does it happen? Can you add a test?

It happens in the case where you have
%1= Broadcast(....)
%2=ElementWiseOp(%1,%1, ....)
the Broadcast op will be erased two times. Concretely, it happened while I was testing iree against a jax model, using the PJRT plugin. I can add a test later.

Rebased and added a test in #17394.


allow some markdown

@rultor release, tag is 0.0.20

@rultor release, tag is 0.0.20

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.20

@yegor256 Done! FYI, the full log is here (took me 2min)


Create Indonesian README

This enhancement aims to provide a better experience for Russian-speaking users, ensuring they can fully engage with our content and features

u da man!


Update Developer Guide with implementation of Tag Type feature

Codecov Report
Base: 58.13% // Head: 58.13% // No change to project coverage :thumbsup:

Coverage data is based on head (93f0d36) compared to base (a85ed5f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #110   +/-   ##
=========================================
  Coverage     58.13%   58.13%
  Complexity      530      530
=========================================
  Files           102      102
  Lines          2066     2066
  Branches        231      231
=========================================
  Hits           1201     1201
  Misses          775      775
  Partials         90       90

Impacted Files
Coverage Δ

...clinkedin/logic/commands/CreateTagTypeCommand.java
57.14% <ø> (ø)

...edu/clinkedin/logic/commands/DeleteTagCommand.java
31.25% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


SD quick fix export

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Fix ruby path on Windows with Puppet 6

The path was wrong on my Puppet 6 Windows nodes… I guess it changed at some point, and since the module was working with Puppet 5, I made the path selection based on OS and AIO version.

sweet, can you do an issue an or even just make this like (misc) Fix ruby....?

thanks :)


Exception adding new entities after upgrading to EF 6

I'm getting this error when adding and saving a new entity after upgrading to EF 6.
Method not found: 'Void System.Data.Entity.Infrastructure.DbEntityEntry.set_State(System.Data.EntityState)'.
Any ideas?
p.s. We are using GenericRepository.EntityFramework

any solution on this ?

Sorry. I don't remember.


Make 'inferModule' work with programs containing enums

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.50%. Comparing base (9f79ac1) to head (bf9fb0b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
- Coverage   83.78%   83.50%   -0.29%
==========================================
  Files          23       23
  Lines       10586    10692     +106
  Branches     1510     1531      +21
==========================================
+ Hits         8870     8928      +58
- Misses       1716     1764      +48

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Configure explicit the metadata server for Ubuntu 16.04

Users were prompted a warning that the instance is not running on
Amazon EC2. This was fixed by telling cloud-init that this
instance is running on OpenStack.

Comment from the swiss cloud guys about this.
Yes, theoretically we could define OpenStack as a metadata source in preference (or instead of) Ec2.
But in practice I suspect that Ec2 is better tested, even on OpenStack.
I tried with OpenStack and noticed that, for example, when no user-data is set, cloud-init tries around five times to get it, even though it always gets a 404.
That slows things down a bit.
Ec2 doesn’t have that problem.
(Yes, I know, I should report that as another bug to cloud-init.  Just to illustrate my suspicion that nobody uses the OpenStack data source )-:

Oscar, Jukka is fixing this, I'll close this.


Special chars in comments are breaking the output

If protobuf fields' comments contain any quote-like symbols then something usually breaks.
i.e. ` breaks go code and ' breaks javascript.
I'll fix it later if nobody else picks the issue up first,

Thanks.  I have quite a lot on my plate at the moment.
The comments on the fields are used to generate user hints.  I can see how a ' can break this for the javascript.  I don't understand why ` would break the go code, but if it is breaking it should be investigated.

I understand :)
Well the whole HTML is stored verbatim in a variable with `-quoted string, so if a string itself contains ` then it is considered as the trailing quote. This corrupts the generated go code.


Word search options guidance

The SearchOptions reference page contained some information better suited for a conceptual page in the post-migration world.
I'm welcoming all feedback, but looking for style and layout comments in particular. Specifically, I'm wondering what parts (if any) should be marked as code.
I'm also 100% open to title suggestions and ToC placement ideas.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/toc.yml
:white_check_mark:Succeeded

docs/word/search-option-guidance.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@Rick-Kirkham I agree with all your text suggestions. Changed and updated. I also verified the wildcard guidance gets rendered properly.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/toc.yml
:white_check_mark:Succeeded

docs/word/search-option-guidance.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


License of topk?

Hi @liuzl, can you please add a license to this repo (preferably Apache/MIT)? I'm not sure if I can use this code. Thank you!

Sure, @tomerfiliba  please feel free to use this code freely! I will add a MIT license later.

Awesome, thanks! 😎


Orchestration Work

Terraform at the momment has some issues with the Chef Providers where
you really can't depend_on other resources that are outside your module.
This code is dedicated to make it work with ugly local-exec commands
that will make them to depend one of each other.
TODO: Research about Resources Deps between Modules

This is very ugly indeed but it will let us go from 0 to 100 when running $ terraform appy
I will be researching ways to add dependencies between resources inside modules.. :smile:

Works!
Apply complete! Resources: 13 added, 0 changed, 6 destroyed.

The state of your infrastructure has been saved to the path
below. This state is required to modify and destroy your
infrastructure, so keep it safe. To inspect the complete state
use the `terraform show` command.

State path: terraform.tfstate
➜  tf_delivery_cluster git:(afiune/orchestration) ✗


DB backups are not deleting when using Copy-SqlDatabase in version 0.8.957

Is this:
Just place "x" to indicate selection (e.g. "[x]")

[ ] feature
[x] bug:

System Details

Operating system name and version: Server 2012 R2
Output from $PSVersionTable:

Name                           Value
----                           -----
PSVersion                      4.0
WSManStackVersion              3.0
SerializationVersion           <IP_ADDRESS>
CLRVersion                     4.0.30319.34014
BuildVersion                   6.3.9600.17400
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0}
PSRemotingProtocolVersion      2.2

Output of dbatools version:

ModuleType Version    Name                                ExportedCommands
---------- -------    ----                                ----------------
Script     0.8.957    dbatools                            {Start-SqlMigration, Copy-SqlDatabase, Copy-SqlLogin, Copy-SqlServerAgent...}

SQL Server version for source/target
2014/2014

Steps to Reproduce
Example:

Trying to backup/restore DB's from production to staging
Run Command:

Copy-SqlDatabase -Source $prd -destination $stg -Databases Accelerator_Agris_Prod, Agris_WM_Prod -BackupRestore -Force -NetworkShare $network

No errors in shell, files to not delete from the network share

Expected Results
Example:

Trying to backup/restore DB's from production to staging
Run Command:

Copy-SqlDatabase -Source $prd -destination $stg -Databases Accelerator_Agris_Prod, Agris_WM_Prod -BackupRestore -Force -NetworkShare $network

Receive following output (if applicable)

Attached screen shots/console output

This is fixed within dev branch as referenced by issues already submitted:
#1248
#1260
Once a release is built and pushed to master this will be resolved.


doc: added help on update_flags to get flags

Added as asked by phil opp, see #461

CI's not yet quite happy.


Prevent third-party files from being installed

Description
I noticed while updating CSFML, that the CMake install target for SFML also includes all the third-party files - from headers, libs, to documentation files.
Starting with CMake 3.28 the EXCLUDE_FROM_ALL option has been introduced, which will ensure that these files are not considered for the install target.
Ubuntu 24.04 ships with CMake 3.28.
Debian 13 ships with CMake 3.30.
See Repology: https://repology.org/project/cmake/versions
I guess the primary question is, do we update the CMake requirement?
Tasks

[ ] Tested on Linux
[x] Tested on Windows
[ ] Tested on macOS
[ ] Tested on iOS
[ ] Tested on Android

How to test this PR?
Build the install target, e.g. cmake --build build --config Release --target install

@jcowgill if we went with CMake 3.28, what impact does this have for packaging SFML 3 in the Debian world? I guess in theory you can just patch it out, given that you will be using system dependencies 🤔

A solution that doesn't require raising the CMake version is to instead use this technique. I've used this before. It's a bit more verbose, but I find it preferable to an increase in our CMake requirement.

@jcowgill if we went with CMake 3.28, what impact does this have for packaging SFML 3 in the Debian world? I guess in theory you can just patch it out, given that you will be using system dependencies 🤔

It doesn't have any impact really. I'm packaging SFML against the development version of Debian which is already on CMake 3.31. I expect most other Linux distros will be using something fairly recent as well when packaging new library versions.
It is an issue for any users trying to compile SFML themselves on older distros though (like Ubuntu 22.04). CMake 3.28 was released December 2023, so this change drops support for all pre-2024 distros. I guess it's a question of where you draw the line.

https://github.com/SFML/SFML/compare/master...exclude_from_all
Here is an implementation of what I was saying. It's pretty simple and ensures Ubuntu 22.04 LTS users still have a seamless experience building the library.


WIP: fix examples

Please fix the license issue
ERROR the following files don't have a valid license header:
examples/greeter/proto/greeter.proto
ERROR one or more files does not have a valid license header

@chickenlj
Fixed license issue,
And please merge this, release a tag 0.1.0


Custom ops are incompatible with Tensorflow Java SDK

Hello! I'm working on serving a tfdf model with the Java SDK. I tried the solution describe here, where you pass the compiled .so file for the tf-df library to TensorFlow.loadLibrary before calling SavedModelBundle.load. I ran into this exception
        Caused by:
        org.tensorflow.exceptions.TFInvalidArgumentException: No shape inference function exists for op 'SimpleMLLoadModelFromPathWithHandle', did you forget to define it?
            at org.tensorflow.internal.c_api.AbstractTF_Status.throwExceptionIfNotOK(AbstractTF_Status.java:87)
            at org.tensorflow.SavedModelBundle.load(SavedModelBundle.java:623)
            at org.tensorflow.SavedModelBundle.access$000(SavedModelBundle.java:67)
            at org.tensorflow.SavedModelBundle$Loader.load(SavedModelBundle.java:97)
            at org.tensorflow.SavedModelBundle.load(SavedModelBundle.java:357)

I asked around the tensorflow/Java Github here and they're conclusion seems to be there's an issue with the custom ops defined as part of this library in that they don't implement the SetShapeFn. Any idea on how much work it would be to fix this compatibility issue?

TF-DF ops are now compatible with TF Java. See this issue for more details.


Vue-cli + Rollup plugin babel: Unexpected Situation arose

I am building a library with vue-cli ( for the dev part ) and rollup to build the library.
I updated everything to the latest  version and I started to receive this error
(babel plugin) Error: An unexpected situation arose. Please raise an issue at https://github.com/rollup/rollup-plugin-babel/issues. Thanks!
Simply swapping babel preset in babel.config.js from
module.exports = {
  presets: ["@vue/app"]
};

To
module.exports = {
  presets: [
    [
      "@babel/preset-env",
      {
        useBuiltIns: "usage"
      }
    ]
  ],
  plugins: ["@babel/plugin-syntax-dynamic-import"]
};

Fixed both the build and the dev ( rollup and vue-cli respectively )
Relevant part of package.json (post adding preset-env)
    "@babel/core": "^7.3.4",
    "@babel/plugin-syntax-dynamic-import": "^7.2.0",
    "@babel/preset-env": "^7.3.4",
    "@vue/cli-plugin-babel": "^3.5.0",
    "@vue/cli-plugin-eslint": "^3.5.0",
    "@vue/cli-plugin-unit-jest": "^3.5.0",
    "@vue/cli-service": "^3.5.0",
    "@vue/eslint-config-prettier": "^4.0.1",
    "@vue/test-utils": "^1.0.0-beta.20",
    "babel-eslint": "^10.0.1",
    "babel-jest": "^24.3.1",
    "eslint": "^5.15.1",
    "eslint-plugin-vue": "^5.2.2",
    "husky": "^1.3.1",
    "lint-staged": "^8.1.5",
    "rollup": "^1.6.0",
    "rollup-copy-plugin": "^0.1.0",
    "rollup-plugin-babel": "4.3.2",
    "rollup-plugin-commonjs": "^9.2.1",
    "rollup-plugin-node-resolve": "^4.0.1",
    "rollup-plugin-replace": "^2.1.0",
    "rollup-plugin-vue": "^4.7.2",
    "vue": "^2.6.8",
    "vue-template-compiler": "^2.6.8",

This looks like a bug with the @vue/app preset.

Could you share repository with the issue reproduced? Hard to tell what's wrong without being able to test it.

@Andarist yes sure, this evening I should have it online!

@Andarist Okay I tried to revert the fix and now.. is working even with @vue/app. What I did in between was switching my node version (broken npm)
Closable I think, sorry for the delay and the fuss!


Guest facts shown with no useful information

When running a simple provision/login/finish command I've noticed the guest facts are shown:
> tmt run provision -h virtual login finish
/var/tmp/tmt/run-014

/plans/default
    provision
        how: virtual
        facts: {'in_sync': False, 'arch': None, 'distro': None, 'kernel_release': None, 'package_manager': None, 'has_selinux': None, 'is_superuser': None, 'os_release_content': {}, 'lsb_release_content': {}}
        user: root
        image: fedora
        memory: 2048 MB
        disk: 40 GB
        arch: x86_64
        list_local_images: False
        progress: booting...
        multihost name: default-0
        arch: x86_64
        distro: Fedora Linux 38 (Cloud Edition)
        summary: 1 guest provisioned

They are shown at the very beginning, with no useful information. Let's show them later when we know something about the guest? And, perhaps, in verbose mode only?

That does not look correct, TBH, more like a forgotten debug output or something.

Aaah, right, it's testcloud.py being smart and printing all attributes of the guest.

The root cause is that the value of key facts is not None, and its value is printed by ProvisionTestcloud.go().

https://github.com/teemtee/tmt/blob/main/tmt/steps/provision/testcloud.py#L655

$ python3 -m pdb ~/.virtualenvs/tmt/bin/tmt run provision -h virtual login
> /home/huanli/.virtualenvs/tmt/bin/tmt(3)<module>()
-> try:
(Pdb) b tmt/steps/provision/testcloud.py:642
Breakpoint 1 at /home/huanli/.virtualenvs/tmt/lib/python3.10/site-packages/tmt/steps/provision/testcloud.py:642
(Pdb) b tmt/steps/provision/testcloud.py:656
Breakpoint 2 at /home/huanli/.virtualenvs/tmt/lib/python3.10/site-packages/tmt/steps/provision/testcloud.py:656
(Pdb) c
/var/tmp/tmt/run-005

/plans/foo
    provision
        how: virtual
> /home/huanli/.virtualenvs/tmt/lib/python3.10/site-packages/tmt/steps/provision/testcloud.py(642)go()
-> for key, value in data.items():
(Pdb) ll
612  	    def go(self) -> None:
613  	        """ Provision the testcloud instance """
614  	        super().go()
...<snip>...
642 B->	        for key, value in data.items():
643  	            if key == 'memory':
644  	                self.info('memory', f"{value} MB", 'green')
645  	            elif key == 'disk':
646  	                self.info('disk', f"{value} GB", 'green')
647  	            elif key == 'connection':
648  	                self.verbose('connection', value, 'green')
649  	            elif key == 'key':
650  	                if value:
651  	                    self.info('key', fmf.utils.listed(value), 'green')
652  	            elif key == 'ssh_option':
653  	                if value:
654  	                    self.info('ssh options', fmf.utils.listed(value), 'green')
655  	            elif value is not None:
656 B	                self.info(key, value, 'green')
657
...<snip>...
(Pdb) pp data
TestcloudGuestData(role=None,
                   guest=None,
                   facts=GuestFacts(in_sync=False,
                                    arch=None,
                                    distro=None,
                                    kernel_release=None,
                                    package_manager=None,
                                    has_selinux=None,
                                    is_superuser=None,
                                    os_release_content={},
                                    lsb_release_content={}),
                   port=None,
                   user='root',
                   key=[],
                   password=None,
                   ssh_option=[],
                   image='fedora',
                   memory=2048,
                   disk=40,
                   connection='session',
                   arch='x86_64',
                   image_url=None,
                   instance_name=None,
                   list_local_images=False)
(Pdb) c
> /home/huanli/.virtualenvs/tmt/lib/python3.10/site-packages/tmt/steps/provision/testcloud.py(642)go()
-> for key, value in data.items():
(Pdb) c
> /home/huanli/.virtualenvs/tmt/lib/python3.10/site-packages/tmt/steps/provision/testcloud.py(642)go()
-> for key, value in data.items():
(Pdb) c
> /home/huanli/.virtualenvs/tmt/lib/python3.10/site-packages/tmt/steps/provision/testcloud.py(656)go()
-> self.info(key, value, 'green')
(Pdb) p key, value
('facts', {'in_sync': False, 'arch': None, 'distro': None, 'kernel_release': None, 'package_manager': None, 'has_selinux': None, 'is_superuser': None, 'os_release_content': {}, 'lsb_release_content': {}})
(Pdb) c
        facts: {'in_sync': False, 'arch': None, 'distro': None, 'kernel_release': None, 'package_manager': None, 'has_selinux': None, 'is_superuser': None, 'os_release_content': {}, 'lsb_release_content': {}}
> /home/huanli/.virtualenvs/tmt/lib/python3.10/site-packages/tmt/steps/provision/testcloud.py(642)go()
-> for key, value in data.items():
(Pdb) q

To fix it, can we just ignore key facts? @psss and @happz

That's the correct evaluation, and testcloud skipping facts field would help, but this would be quite a sad solution for me.
I'm not very fond of how these provision plugins print the info about guests, they often print fields shared among all guests, plus their own, and there's no single method that would take care of the shared set of keys. And then we get this, there's Guest.show() which prints facts, ignoring the field would have to be in all plugins, tomorrow we can spot the same in podman or artemis plugins... This calls for some "shared part" vs "custom part" solution. They all accept --image but artemis does not print it, but it has two lines to print out SSH options, which each plugin should print out anyway... Very unsatisfactory mess. Ignoring facts would indeed fix the immediate issue, but the underlying cause would be left untouched, ready to re-appear next week somewhere else :/
Maybe a GuestData.show() method to take care of this - print (or not...) fields from GuestData, then plugins can override the parent method and print only their fields as they wish. That could bring some peace, core code would take care of stuff like facts, role, name, and ssh options, testcloud plugin would print out its own fields like arch or memory.
Sometime after that, we could start moving stuff around - e.g. artemis also supports arch, all of them should one day support hardware... All plugins except connect accept --image, do we really need all of them to add their own info('image', image)? Some day, a new plugin will forget to add this line... I'd prefer leaving no space for such omissions, for that we might add mixing guest data classes with just fields from their respective area - beaker, artemis, testcloud, they all support some kind of arch/image/HW selection, we might add an "HW selectable guest" set of fields, and so on.

The solution outline by @happz makes very good sense to me. Maybe two common show() methods will be needed, one before the actual provision steps are performed and one once we know everything about the guest, including the guest facts. Not sure whether, as a quick hot fix, we should not ignore the field for testcloud now to provide a nice output.

Hotfix proposed in #2129, let's keep this issue to track the proper solution as suggested by @happz.


Apply code formatting to output parameter type documentation

When generating documentation for our code it would be nice to apply code formatting to the output type of a method:

PS: ignore the description part that starts with the code formatted String. I'll need to fix my description.
I really appreciate all of your hard work and mention that there's no need to rush a fix for this and to release a version immediately, this can definitely wait.

Thanks @pozil! This makes sense.
Don't worry about me rushing 😅 , it's all good. I like to keep a bit of time open throughout my week for these kind of things and they have been quick fixes so far

Thanks once more!


⚠ Elearn has degraded performance

In 64b1fac, Elearn (https://learn.stjohn.edu.et/app) experienced degraded performance:

HTTP code: 500
Response time: 28140 ms

Resolved: Elearn performance has improved in 31553e3.


[Cyberpunk Red] it.json updated, translation key fixed

A key was wrong, thus there was an error in the current Italian version of the sheet.
Changes / Comments
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ ] Does the pull request title have the sheet name(s)? Include each sheet name.
[x] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Fixed italian translation
Added a two-columns format for gear section, for managing separately Cyberware and Gear (like the actual character sheet).

The is now some conflicts, you need to fix them for this to be approved


[Feat] Firecrawl🔥 Integration

Hi all,
Opening this issue after chatting with Rodrigo. It would be awesome to add a Firecrawl web loader / tool for people to use it to scrape, crawl and extract LLM ready data from the web.
Would love to hear your thoughts on how we can best integrate it.

https://docs.firecrawl.dev/sdk/langchain
Thinking this could be accomplished by making use of the existing docloader langchain integration from firecrawl. Would that be an acceptable implementation?

@Eliotdoesprogramming That could work I believe.

What's probably better is not even use langchain itself, but use the firecrawl implementation that was done there. Here is the pr link @Eliotdoesprogramming https://github.com/langchain-ai/langchain/pull/20364
Eliot, Let me know if you want to tackle this otherwise we can start on it tomorrow/thursday.

Tagging @rafaelsideguide, who will tackle this.

Closed by https://github.com/langflow-ai/langflow/pull/2359


[d3d9] GTA IV - Broken rendering since the last commit

As of 1150121, the game looks like this:

With the previous commit, the game looks normal:

I'm well aware the game has some issues right now, but the problem is reproducible using an old trace from Joshua-Ashton/d9vk#99.
Software information
Grand Theft Auto IV, latest version that has been released yesterday.
System information

GPU: RX 580 4GB
Driver: Mesa Git + ACO
Wine version: Proton 5.4-TkG
DXVK version: 1150121

Apitrace file(s)

GTAIV_trace.tar.xz

Log files

GTAIV_d3d9.log
GTAIV_dxgi.log

I guess the real culprit is f6b26b302d9c0c9760b47b881ce6667f8f021424.
@Joshua-Ashton can we revert this? The whole depth-stencil hazard thing is clearly not working, and was only masked by the fact that we were using GENERAL layout for all depth buffers.


Failed to download friday's subtitle.

ip: <IP_ADDRESS> (US)
Traceback (most recent call last):
File "subtitle_downloader.py", line 158, in
friday.main()
File "/content/Subtitle-Downloader/services/friday.py", line 313, in main
r'
(.+)
', res.text)[0].strip().replace('，', ',')
IndexError: list index out of range

ip: <IP_ADDRESS> (US) Traceback (most recent call last): File "subtitle_downloader.py", line 158, in friday.main() File "/content/Subtitle-Downloader/services/friday.py", line 313, in main r'(.+)', res.text)[0].strip().replace('，', ',') IndexError: list index out of range

Please provide download links or title

Friday update its website view. All titles can't be downloaded.
eg:https://video.friday.tw/drama/detail/2130

Friday updated its website view. All titles can't be downloaded. eg:https://video.friday.tw/drama/detail/2130

Fixed


Chore/unit testing services

rather would just do some cherry-picking from this into a different branch and present it as an alternative PR shortly

dropping this PR --> in favor of new one in branch task/make-baseline that:

merges in what we had brewing in dev--> #1
aims to merge to main (no more dev)
passes PR-check


after upgrading to xcode 12.0 getting 'folly/json_pointer.h' file not found

Please provide all the information requested. Issues that do not follow this format are likely to stall.
Description
After upgrading to Xcode 12.0 I am no longer able to build my project and am getting 'folly/json_pointer.h' file not found.
I've also tried building a completely new project to compare, however the new project also gets the same issue
To reproduce:
npx react-native init AwesomeProject
cd AwesomeProject
npx react-native run-ios

I am also getting the same  'folly/json_pointer.h' file not found
fatal error: 'folly/CppAttributes.h' file not found
fatal error: 'folly/Unicode.h' file not found
fatal error: 'folly/concurrency/UnboundedQueue.h' file not found
React Native version: 0.63.2
mac OS 10.15.4
xcode 12.0
I downgraded back to xcode 11.7 and had to try and clean everything and was able to get my build working again:
cd ./guest-app/ios && npx rimraf Pods && pod cache clean --all && npx rimraf build
watchman watch-del-all
yarn cache clean
npx rimraf ~/Library/Developer/Xcode/DerivedData && npx rimraf $TMPDIR/metro-* && npx rimraf $TMPDIR/react-* && npx rimraf $TMPDIR/haste-*
cd ./guest-app && npx rimraf node_modules

not sure if I had tried the above if I could have got xcode 12.0  to work with my build

I have the same issue after upgrading to react native 0.71.1, this is my Podfile
require_relative '../node_modules/react-native/scripts/react_native_pods'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

platform :ios, min_ios_version_supported
prepare_react_native_project!
# If you are using a `react-native-flipper` your iOS build will fail when `NO_FLIPPER=1` is set.
# because `react-native-flipper` depends on (FlipperKit,...) that will be excluded
#
# To fix this you can also exclude `react-native-flipper` using a `react-native.config.js`
# ```js
# module.exports = {
#   dependencies: {
#     ...(process.env.NO_FLIPPER ? { 'react-native-flipper': { platforms: { ios: null } } } : {}),
# ```
flipper_config = ENV['NO_FLIPPER'] == "1" ? FlipperConfiguration.disabled : FlipperConfiguration.enabled
linkage = ENV['USE_FRAMEWORKS']
if linkage != nil
  Pod::UI.puts "Configuring Pod with #{linkage}ally linked Frameworks".green
  use_frameworks! :linkage => linkage.to_sym
end

install! 'cocoapods', :deterministic_uuids => false
permissions_path = '../node_modules/react-native-permissions/ios'

pod 'Firebase', :modular_headers => true
pod 'FirebaseCore', :modular_headers => true
pod 'FirebaseCoreInternal', :modular_headers => true
pod 'GoogleUtilities', :modular_headers => true

pod 'BVLinearGradient', :path => '../node_modules/react-native-linear-gradient'
#Permissions
pod 'Permission-Camera', :path => "#{permissions_path}/Camera"
pod 'Permission-MediaLibrary', :path => "#{permissions_path}/MediaLibrary"
pod 'Permission-Microphone', :path => "#{permissions_path}/Microphone"
pod 'Permission-Notifications', :path => "#{permissions_path}/Notifications"

target 'Tbit' do
  config = use_native_modules!

  # Flags change depending on the env values.
    flags = get_default_flags()

  use_react_native!(
    :path => config[:reactNativePath],
    # Hermes is now enabled by default. Disable by setting this flag to false.
    # Upcoming versions of React Native may rely on get_default_flags(), but
    # we make it explicit here to aid in the React Native upgrade process.
    :hermes_enabled => flags[:hermes_enabled],
    :fabric_enabled => flags[:fabric_enabled],
    # Enables Flipper.
    #
    # Note that if you have use_frameworks! enabled, Flipper will not work and
    # you should disable the next line.
    :flipper_configuration => flipper_config,
    # An absolute path to your application root.
    :app_path => "#{Pod::Config.instance.installation_root}/.."
  )

  target 'tbitMobileTests' do
    inherit! :complete
    # Pods for testing
  end

  post_install do |installer|
    react_native_post_install(
      installer,
      # Set `mac_catalyst_enabled` to `true` in order to apply patches
      # necessary for Mac Catalyst builds
      :mac_catalyst_enabled => false
    )
    __apply_Xcode_12_5_M1_post_install_workaround(installer)
  end
end


Oauth MicrosoftAccount Token Request Issue

I'm trying to figure out how to configure oauth with a MicrosoftAccount.
Within the Microsoft.AspNetCore.Authentication.OAuth project, in the OAuthHandler.ExchangeCodeAsync(...) function it creates a tokenRequestParameters Dictionary.
protected virtual async Task<OAuthTokenResponse> ExchangeCodeAsync(string code, string redirectUri)
        {
            var tokenRequestParameters = new Dictionary<string, string>()
            {
                { "client_id", Options.ClientId },
                { "redirect_uri", redirectUri },
                { "client_secret", Options.ClientSecret },
                { "code", code },
                { "grant_type", "authorization_code" }
            };

            var requestContent = new FormUrlEncodedContent(tokenRequestParameters);

            var requestMessage = new HttpRequestMessage(HttpMethod.Post, Options.TokenEndpoint);
            requestMessage.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
            requestMessage.Content = requestContent;
            var response = await Backchannel.SendAsync(requestMessage, Context.RequestAborted);
            if (response.IsSuccessStatusCode)
            {
                var payload = JObject.Parse(await response.Content.ReadAsStringAsync());
                return OAuthTokenResponse.Success(payload);
            }
            else
            {
                var error = "OAuth token endpoint failure: " + await Display(response);
                return OAuthTokenResponse.Failed(new Exception(error));
            }
        }

My application on Azure requires that I include a resource parameter  with my application Id.  It would appear that your code doesn't allow modifying these parameters.
Unless there is some secret sauce I'm unaware of, can you confirm either
a) that this is a design issue
or
b) how to include the resource parameter in a token request

I was able to configure the app on Azure to by-pass this issue.  Microsoft is no longer requesting the resource parameter.
While I no longer require the ability to do this at this time, I do see an issue with the implemented design if there is no way to include Oauth parameters when making token requests.

Well just my luck...  Azure is asking for the resource parameter again.  Not sure why, or what changed.

It appears to be related to which authorization and token endpoints are used.  There are two available.
options.AuthorizationEndpoint = "https://login.microsoftonline.com/[guid]/oauth2/v2.0/authorize";
options.TokenEndpoint = "https://login.microsoftonline.com/[guid]/oauth2/v2.0/token";

These require a resource parameter below;
options.AuthorizationEndpoint = "https://login.microsoftonline.com/[guid]/oauth2/authorize";
options.TokenEndpoint = "https://login.microsoftonline.com/[guid]/oauth2/token";

We switched to the v2 endpoints a long time ago. Why are you using the v1 endpoints?
https://github.com/aspnet/Security/blob/32177cad1eb1eb6be8ad89a7dba1a1637c0d0786/src/Microsoft.AspNetCore.Authentication.MicrosoftAccount/MicrosoftAccountDefaults.cs#L13-L15

First time hooking the Oauth up to Microsoft.  Just copied the values from the Azure Portal.  They have both there.

Are you not using the pre-built Microsoft.AspNetCore.Authentication.MicrosoftAccount? It handles these things for you.

I was not using it originally no.  When I did, it was not working for me (for other reasons).  So I was manually setting things up.  Had copied the endpoints from Azure Portal and got to the resource issue.  Which I was able to resolve by setting the parameter manually.  I do have the pre-built one now working though.
Might be useful to highlight the old endpoints don't work.  While it might be intuitive for those in the 'know'.  It's not so intuitive to someone going through it for the first time.


Add gptj notebooks

Adds two GPT-J notebooks:

generative inference
Finetuning on the MNLI dataset

These notebooks have cached executables but do not have cached checkpoints, as the caches made the experience worse.

Looks good!
Minor comments:

In each notebook, make prominent at the start that an IPU-POD16 (or Bow-POD16?) is needed (it's mentioned but hidden in code cell 2 lower down)
In the fine-tuning notebook, mention it that it takes several hours to do the fine-tuning (i.e., 20-22s * 400, which is why there's the option to just evaluate the existing checkpoint)
Presumably also update the README_first.ipynb to include these 2 notebooks

Thanks for review @nmb-paperspace , I added your suggestions.


snapshot calls data

#before
Map<String, dynamic> data = snapshot.data();
#after
Map<String, dynamic> data = snapshot.data.data();
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[ ] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] The analyzer (flutter analyze) does not report any problems on my PR.
[ ] I read and followed the Flutter Style Guide.
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[ ] I updated CHANGELOG.md to add a description of the change.
[ ] I signed the CLA.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[ ] No, this is not a breaking change.

google i signed it

@googlebot I signed it!

LGTM, thanks @shibilshibik


Add custom transforms to convenience functions, and other API improvement

Description
Following https://github.com/CAREamics/careamics/issues/231, there is a lack of flexibility in the way users can specify the transforms in the config convenience functions. The choice to users comes down to using only the default augmentations or no augmentation at all.
In passing, I also added the dataloader_params parameter by request of students during the MBL course.
This PR does a few things:

Refactor TRANSFORMS_UNION type in its own module in order to find it more easily.
Add an augmentations parameter that allows user to pass non-default augmentations. These augmentations are still turned off by use_augmentations.
Force transforms to be passed as Pydantic models.
Add dataloader_params to allow setting PyTorch dataloader parameters (as expected by the configuration).
Rename model_kwargs to model_params for clarity.
Refactor the convenience functions and tests in order to minimize duplicated code.

Summary:

What: Allow users to pass non-default augmentations and dataloader parameters.
Why: Enable cases where augmentations are useful but need to be different from the default ones (e.g. no rotations), and cases where users might want to add some dataloader parameters.
How: Added two new parameters to the convenience functions.

Changes Made

Addded: transform_union.py to hold TRANSFORMS_UNION.
Modified: configuration_factory.py, corresponding tests and the imports of TRANSFORMS_UNION.

Related Issues

Fixes https://github.com/CAREamics/careamics/issues/231

Breaking changes
Any call that uses the convenience functions together with the parameter model_kwargs.
This PR will require an update to the doc and the examples.

Please ensure your PR meets the following requirements:

[x] Code builds and passes tests locally, including doctests
[x] New tests have been added (for bug fixes/features)
[x] Pre-commit passes
[ ] PR to the documentation exists (for bug fixes / features)

I typed the transforms differently in the end, and added further refactoring and some error raising!


How to change the shape of the tag.

Hi very cool library how to change the shape of the tag like from elliptic square to just square ...

I am using mTagGroup.getInputTagText() but its returning empty why?

Any updates on this thread?


useCookies updates only on nextTick

Environment

Operating System: Darwin
Node Version:     v16.15.1
Nuxt Version:     3.1.2
Nitro Version:    2.1.2
Package Manager<EMAIL_ADDRESS>Builder:          webpack
User Config:      srcDir, builder, modules, app, proxy, image, runtimeConfig, webpack, build, router, css
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-yhreot?file=app.vue
Describe the bug
If you change value on useCookie() and after that try to get the same cookie you will get old value of cookie. But on nextTick value will change
Additional context
No response
Logs
No response

This is expected behavior from Vue.
From vue documentation:

However, it should be noted that the DOM updates are not applied synchronously. Instead, Vue buffers them until the "next tick" in the update cycle to ensure that each component updates only once no matter how many state changes you have made.

I think the same principle applies to useCookie. If you want to read a value from a variable, you can use username.value. no need to initialize a new one.

This is the case - we use watch to set the cookie.
I think nuxt/nuxt#13020 is the issue to follow, however - a shared cookie state should resolve the issue.


Update supported files and add columns to 3T T1 info

Added MDS_UPDRS_Part_II__Patient_Questionnaire.csv and Modified_Schwab___England_Activities_of_Daily_Living.csv to list of supported PPMI files
Added Study Date and Imaging Protocol (with field strength values) columns to file saved by download_3D_T1_info()

Thanks for a great PR @michellewang!


Improve quoting options; Restore API-default quoting; Add bz2 support

This PR improves adds improved quoting options for CSVs:
-q or --quote_character for the API QuoteCharacter field
-Q or --quote_escape_character for the API QuoteEscapeCharacter field
-A or --allow_quoted_record_delimiter for the API AllowQuotedRecordDelimiter field (boolean)
There is a minor change in behavior between this PR and 728788a, which introduces a discrepancy with the API's quoting defaults by setting QuoteCharacter to the empty string (disabled) instead of " (double-quote char). The current PR restores " as the default quote delimiter while allowing other options to be used with -q.
This PR also adds support for bzip2-compressed (.bz2) files.

Thanks a lot for PR! I've just come back from vacation and will examine this soon.


[Feature Request] Create a dev build without a watcher

Why I need this:
I want to be able to create a single build for each time django renders a template.
A file watcher has to be started and maintained throughout the course of the django server's lifetime. On the other hand, we can just do a build each time django renders a template, since its development. This will also ensure any files that might have been missed by the file watcher.
API suggestion
cra-build-watch --no-watch
I'm a python guy and have a limited knowledge of webpack. However, I am ready to help if you can point me in the right direction.
Thanks/

I'm not sure I fully understand what you want to achieve but unfortunately I won't have the time this week to look into it in depth. I'll come back at it later on when my schedule allows it.

Nvm, I figured it out myself..
https://github.com/pycampers/react-pages/blob/master/nodejs/config/webpack.config.dev.js

Alright, glad you found a solution to your problem. Good job. :+1:

Cool! 😄


Automatic file conversion

Description of the new feature / enhancement
If you try to change a file extension by renaming it, you may be asked whether you only want to rename the file or convert it directly (e.g. from .jpg to .bmp).
Scenario when this would be used?
You wouldn't have to use an online converter every time and would save time.
Supporting information
No response

/dup https://github.com/microsoft/PowerToys/issues/9743


Adding to stdlib/pathlib?

Hi, I love this module and use it all the time. Many thanks for everyone's work!
Given platformdirs provides such key functionality with a fairly small footprint, is it insane to think that maybe it could be added to the Python standard library?
Given that pathlib already has Path.home(), maybe it could just be added to pathlib? Accessed with from pathlib import PlatformDirs? And then function identically to the way it does now?

This is a question to the core developers, however as far as I know, there's been an active effort to have less in the standard library as it's easier to update . 🤔 You can open an issue for the core developers at https://github.com/python/cpython/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc

Please link to this issue if you open an issue there, thanks!

I started a discussion thread on the Python ideas board.

The reception was cautiously positive I'd say. The utility was definitely recognised.
Actually they didn't feel size of the stdlib is an issue – only whether users benefit more from the functionality being in the stdlib or available as a package. Their main concerns being:

the frequency of new releases that platformdirs receives – but this seems mostly to do with your release policy of making new releases for pretty much every commit, correct?
feature updates would be only possible at most once a year, and fixes would be slow to release and permeate through the Python ecosystem.

As a current maintainer, your opinion is the most important one here. Do you think users would benefit significantly from having it as a separate package with the possibility of rapid updates? And how often are breaking changes likely, in your view?
To me as an outsider, the pace of change of operating systems seems slow enough that stability feels like not really a concern.

From my point of view there's benefit in both. It could even operate the same way importlib.resources does today where it is still released on its own but periodically mirrored into the standard library.

And yes, I think the project is stable enough nowadays and we don't plan any major changes.

Maybe going into the standard library we could fix that macOS issue? I forget which one but it would be a major change.

Yeah we could have another round of deep review before we cut over, I would only do that though if you get verbal acord that the project would be accepted into the standard library, probably in a mirrored fashion as is importlib.resources is.

There are no verbal agreements, the steps for acceptance would be to find a core dev to sponsor, write up a PEP, submit it for community discussion (and update the PEP if needed), then submit it to the steering council for acceptance. PEP 1 has the details.
A good reference is PEP 680 ("tomllib: Support for Parsing TOML in the Standard Library"), that added (the read-only parts of) tomli to the stdlib.
A mirrored fashion sounds sensible, it would make it easier to contribute bug fixes and new features. The common parts of tomli and tomlib remain very similar too. (I recently checked and they were almost identical.)

Yes, it would maybe be a good opportunity to tidy up some things or change some things if you guys wanted. In a way, it's a chance for any last really big breaking changes. Namespaces, for example, if there were any lingering regrets from the past however many years.
I also wondered whether, for a PEP proposal, you might see it as desirable to slim down the package by only returning the paths as Path objects, whereas currently everything is doubled for both Paths and strings, right? Just an idea though.

By the way, since no one really asked for my opinion and I was the one who came here with irritating ideas keen to make more work for everyone – I'm very happy to contribute in any way I can :)

By the way, since no one really asked for my opinion and I was the one who came here with irritating ideas keen to make more work for everyone – I'm very happy to contribute in any way I can :)

It would be great if you could write up the PEP proposal, I would be happy to review it and push it through. We can be co authors in that sense if you're fine with that 👋

I can have a stab at it, sure. As long as you don't mind a multitude of questions about the implementation :)


Add-on seems to fail when running tests on ember-cli-2.8.0

We are trying to use the addon within our app, and it seems to be working, but our tests fail with
Promise rejected after user can switch between editing and preview mode: Cannot get styles on an element that doesn't exist

Initially, we thought the problem is with our own lifecycle, since the editor is placed in a tab that renders or doesn't render depending on a property, but putting it outside of that scope, so it's always rendered doesn't make a difference.

I think I've encountered this in our apps as well. It seems that the lifecycle subtly changed.

Unfortunately, I've had to remove ember-autoresize until we figure out what's happening here.

@tim-evans any updates on this? Just saw a new version pushed, so wanted to check.

I'll take a look

I just released another version. Could you test against that?

I was experiencing the same issue, and upgrading to the latest seems to have fixed it. Thanks bawd!
For anyone upgrading: I removed the dependency altogether (and the associated bower dep: dom-ruler) then reinstalled from scratch (ember install ember-auto-resize).

❤