Project pillars

Moves various files (basically the ones not dependent on fs and logicalplan and data) into a new project pillars, which is a dependency of core.

@wemrysi these are the files that I could move out without tackling the big mess of the filesystem stuff entangled with logicalplan and now qscript.
I don't know yet if this will make core compile times faster by much, but it's a start. And in any case, it makes our dependencies a bit clearer.

Thanks for breaking the seal on this, after looking at the usages, what do you think about

Move quasar/console into the effect package (probably deserves to be made algebraic at some point)
Put all of the effect stuff into an effect project
Move jscore and javascript into their own project, js?
Leave csv, namegen and stacktrace in core for now (or can put them into pillars but it would be less compelling)

Also, if we moved the Data#toJs functionality, which is only used in quasar.api.services.query.compile and the mongodb connector, into mongodb then the only project that would need js would be mongodb. I think we could replace the usage in api.services with a conversion to EJson, though it might require a pretty-printer or somesuch, so we can punt on this if so (but sounds like we'll need it eventually).

@wemrysi I think it makes sense to have a js project containing javascript and jscore, so I went ahead and did that. (Side note - typed "package" instead of "project" in a commit message :/ )
Regarding the creation of an effects project, and what should go in it:

I think quasar/console makes sense into effects, since it's interacting with the environment.
I would consider putting csv into effects. We explicitly create a java.io.StringReader in csv, which is performing IO.
I would also consider putting stacktrace into effects, as stacktraces only come into play when we are running the code and thus performing IO.
I think namegen would be fine in either pillars or core. I'm fine putting it in core for now.
I don't see a reason for LiftedOps.scala to be in effects, so I'd move that into the fp package object in foundation. It's useful for effect-related operations, but really it's just a general functional operation involving Free.

And then with effects and js both their own projects, there would be nothing left in pillars, and so pillars would be deleted.
Let me know what you think.

Also, I think it would be great to remove core's dependency on js. We could then have:
     core,
// / / | \ \
      js,       \         \          \
//     |         \         \          \
     mongodb, skeleton, postgresql, sparkcore,
//      \ \ | / /
          main,

Once the old mongo backend is gone and replaced with the new qscript-based mongo connector, we can delete Data and use EJson exclusively. So we'll definitely need to replace the api.services Data#toJs call at some point.
Also, looking at that diagram, if the functionality in js is 100% mongodb-specific, and no other backends could benefit from it, we could move it into the mongodb project. Though since small projects are the goal (both for understanding/isolating dependencies and for sbt compile times), keeping js separate very well may be the best way to go.

Does js need to depend on core? If so, it’s probably just some bits that need to be detangled, right? Like conversion to/from Data?

@alissapajer

I'd prefer to keep csv out of effect (do you mind the singular naming?) as I see the latter as being more focused on core, generic algebraic effects (adding console is fine as we hope to make that algebraic when time permits). csv could move to main as it is needed by both repl and and web if you want to get it out of core.
I just checked and stacktrace isn't used by anything, so let's delete it!
I'm fine with LiftedOps in effect or foundation with a small preference of just leaving it where it is as I'm not sure if we use it anywhere but for effects at the moment as it is tied to the sort of Ops pattern that we've adopted for those.

@sellout right, we could put js parallel with core then, or even above core where it is now, parallel with ejson. I suppose then, in general, it's best to push each project "up" in the dependency graph as high as possible.

@wemrysi ok cool, here's the plan then:

effect will be a singularly named new project, with console moved into it
pillars will be deleted, as it's been replaced with effect and js
stacktrace will be deleted (yay!)
csv will be moved into main, assuming all the dependencies work out, else it will stay in core
LiftedOps will stay in effect for now

@wemrysi passing this back to you - I believe I have made all the changes we discussed!

:shipit:

@wemrysi cool, it's yours to merge!

Ok, will do once I hear from Travis.

@alissapajer Any idea if the rearrangement caused any of these classloader errors? Given the packages involved, I suspect they may be related to #1242 (or whatever introduced the spark dependencies), but I'm not sure and we have so few successful builds that it is hard to tell from the travis history.
I can see that as of this build things were ok, so must have happened sometime after that.

@wemrysi so, one interesting thing is that I only see that JarClassLoader: Warning in one of the four builds (mongo 2.6). Two others passed (3.0 RO and 3.2), and the third hung (3.0) in the same way we've been seeing in master for a while. So either the errors are specific to that build, or it's a flukey as-yet unexplained thing that may or may not be related to this PR. I'm going to restart the build to see if we consistently get those errors or not, and additionally see if I can replicate the problem locally.

Here's a gist with the classloader issue since travis overwrites previously build files when you restart a build :/

Updates:

Reran the travis build. Builds #s 2,3,4 all passed. Build 1 hung at the end. No builds showed the classloader errors.
Locally running sbt test, sbt oneJar, and sbt doc all complete sucecssfully with no errors/warnings.

@wemrysi I ran the travis build a third time. Builds 1-3 all failed with the message
No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.

The build has been terminated

which is how all the "hung" builds fail these days, with each build hanging at a different stage. Build 4 passed.
I have not been able to replicate the classloader issue locally or remotely, and I can't think of how this PR would cause that issue.

@alissapajer You only see it in the 2.6 one because they are runtime errors/warnings when starting the server and the 2.6 build is the only build we attempt this in (it doesn't have anything to do with 2.6, that just happens to be the first build which is the one we pick, arbitrarily). To reproduce it locally, you'd have to run the server.
Anyhow, it doesn't look like it has anything to do with this PR, so I'll merge and investigate.

@wemrysi ah I see where we run scripts/testJar in scripts/build now.


Legend tooltip bug for a nested data with .time() method

Legend tooltip sometimes is not shown in case of the nested data with a time method used.
Line plot:
https://jsfiddle.net/55sckm6h/3/
The same bug applies to the tooltip of the alpha rectangle in a tree map:
https://jsfiddle.net/55sckm6h/4/
But without the .time() method tooltips work fine:
https://jsfiddle.net/55sckm6h/5/
Looks like it was introduced in 1.7.4 version.

I'm having the same problem here.


ClickHouseDatabaseMetaData.getTables dont ignoreError

because getTables method is very commonly used. Just for me, I don't import org.lz4:lz4-java:1.8.0 but because ClickHouseDatabaseMetaData.getTables ignore error, I debug for a long time.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Gravity direction resetting to down when travelling between dimensions.

Whenever I enter a nether portal or end portal, my gravity direction resets downwards. I can still change it after I enter the portal.
I have the latest version of the mod, and Fabric version 0.12.12.

There is a config option to maintain the same gravity direction


Continue broadcast/verify for transactions with empty receipts

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (c2816ca 2022-09-14T00:14:35.602522Z)
What command(s) is the bug in?
forge script
Operating System
macOS (Apple Silicon)
Describe the bug
I just sent out a bunch of transactions on Polygon and it seems like some were not received/discarded by the rpc (perhaps --slow would have helped me here).
If I try to continue the run with --resume, I get the message:
source .env && forge script deploy --rpc-url $RPC_POLYGON --private-key $PRIVATE_KEY_2 --verify --etherscan-api-key $POLYGONSCAN_KEY --with-gas-price 38gwei -vvvv --ffi --resume
[⠆] Compiling...
No files changed, compilation skipped
##
Checking previously pending transactions.

Transactions saved to: /Users/lain/git/eth/GangWar/broadcast/deploy.s.sol/137/run-latest.json

Error:
Received an empty receipt for 0x71c527453996ba1c52969f5e30dfd345b95141058f9455ba6372afd198019c67
Received an empty receipt for 0x0cb9192bfa9d9765840518d41ead4ea7d366ff076f433b5f6e7cbad9207fe001
Received an empty receipt for 0x462cbd26b381052de3c084211576938c313f5498c3a79e8bbe4f9e1c9b8dc85f
Received an empty receipt for 0x3787c9a791e62b5c798eb217d7b2dae12111639db5d944da0ee22d3eb8a2ab04
Received an empty receipt for 0xebb7bde630743a752964fac473edd49ca2a0d39988f00e01a663e8f29417c7c9
Received an empty receipt for 0xf96172fcea9aab147e2c041fff9bda4a2678fa91c203647bc3e85987c71f739f
Received an empty receipt for 0x36e1126e417a1641f28cc3b21408f39f35a7402fd7269aaef348ec9e07744982
Received an empty receipt for 0x507c8520730bd404617c1bced3c1d3c944d4e9818209d93cfbd4ce7aaf18895d
Received an empty receipt for 0x20d6944e8ba31221edb69dd52ae6d0c55044a90df52b39e7d7d996525b30125c
Received an empty receipt for 0xa2f3abc64e10819018830cea84b9b683c532c8b2a243885ac3bb416bb3e43582
Received an empty receipt for 0xeff670c6ca6bbc2b0f4304efd20a28c149cb3df0a5f37e6ae187b146f4cbc85b
Received an empty receipt for 0x105159a2a30b5dc7e805fc0b51596b7ed8a5d305e2a66e3ad1ddc3db9b4b262b
Received an empty receipt for 0xbf2675c87adf05486d6a2ee62a032582e93157f01eba41371af617b082f1a59e
Received an empty receipt for 0x8ef61430ee404874ce73cf8a14ed8ff39dd4ac33a5f28ecf243bc02dae30f623
Received an empty receipt for 0x4ec4c838b3f772d40c908682f0e2387be608bc77ea777a3ea5680bb8494e0b08
Received an empty receipt for 0x7460833183b9803b702e44afcc043e99106a0527a823596260a8d963dd6960f4
Received an empty receipt for 0x15996af234cd5edb109c226b167010639be403a37577a5fda751a5a593ad4c85
Received an empty receipt for 0xe9a7562346a4ebf82803f6b37c750a5602d215545bb6189f0ff2056f912cc963
Received an empty receipt for 0x141037375f75d3f7249a838ff13fd8ca4bdf21d98e36cc0ecdad966f28f4ff8c
Received an empty receipt for 0xec0243d0c9cfcd428a2c2f205466c223e457eba5d91b0e3b4e3d08573f6119c4
Received an empty receipt for 0x1f065143636a41442ead63e082f7188f8393f25242b2069ec2f9dd9847e2a433
Received an empty receipt for 0x00d4db0615f132bf58e1b2022c03385fba70cbb7733bef3ae673aadac8f48fbf
Received an empty receipt for 0xe8244c0012938bd39021b4499a4b1c6d8c6f47ebf75dc8befa45370c0e952a63
Received an empty receipt for 0xe98a53134a2756778ce42a2e77b89be40597cd1ffc7a7bc010d1e4ee222472f3
Received an empty receipt for 0x4f92f463b06aa023c1ab0bdeb16428c329f6283d01aefc5d2f0d7a25ed0960f1
Received an empty receipt for 0x67049c590a363f05272fb79c5561ff5ea6b773140a76784c22e2c25ce02299bb
Received an empty receipt for 0xcf7372f4cc5d39706887a0e2aa826b76a845c8cabe465b0b07f50fb278660753

 Add `--resume` to your command to try and continue broadcasting
    the transactions.

Now I'm stuck, since I'm unable to verify the current (already deployed contracts) and it won't re-send the remaining transactions.
I can probably just remove those transactions from the 'run-latest.json' and continue, but wanted to raise the issue here first.
Here's a link to the 'run-latest.json':
https://github.com/0xPhaze/gang-war/blob/master/broadcast/deploy.s.sol/137/run-latest.json

experiencing a similar issue.
broadcasting txn to a local Anvil node with forge script script/FortressInit.s.sol:FortressInit --fork-url http://anvil:8545 --broadcast --resume —slow
getting Received an empty receipt for 0x3866e1cb6c3dc812b4173fa88a1877d3621b947a4d81bd095da26c62deeb9b62.

@0xPhaze @johnnyonline is this still an issue?

@mds1 not anymore for me ser.


WIP: fix #25143 Successive calls to precacheImage() throw an exception

I still can't figure how to write unit test for this...

Fixes https://github.com/flutter/flutter/issues/25143. /cc @jonahwilliams

unit test added

Awesome!

tests-windows https://github.com/flutter/flutter/pull/25159/checks?check_run_id=39791787 failed because of time out :-?

I restarted the windows tests

They all passed! 🎉

LGTM. Thanks for the tests.


Update tsg_pvs

Updated
Signed-off-by: ranjithwingrider<EMAIL_ADDRESS>

Adding newly to the latest page


[CHANGE]: Add member management to operation views

Desired Change
Add member management, (the same as in groups views) to the operation views.
Reason/Motivation for Change
Support the management of operation members in the GUI.
Impact of Change
No response

added in 3a035355be4ae0e871861664a341b727eed34fe9.


Vsync doesn't work on macOS 12 (OpenGL)

This is forked from #1885. Vsync with Metal now works well, but OpenGL does not.
https://github.com/glfw/glfw/issues/1990

@hajimehoshi is this still an issue?

This is no longer an issue.


User Interface Enhancement

Related Issue

Description
Added Navbar button background  while hovering over it
Screenshots

We regret to inform you that we are closing the pull request you submitted as it does not include an issue number and appears to be a case of spam. Kindly ensure to check our guidelines and procedures for creating pull requests in the future.
Thank you for your understanding.


Migrate Partner Release to 1ES supporting yml

Goal is to replace this release with this new build pipeline.
Example successful release
Related to Azure/azure-sdk-tools#7941

/check-enforcer override

@microsoft-github-policy-service rerun

/check-enforcer override


message_type table is empty

Bug description

I used "appd tx send * *" for the transfer operation, and I can see this message in the transaction data table, but it cannot be correctly written into the message table. He reported the following error. Does anyone have a solution
Jun 06 16:37:35 node-2 callisto[421725]: 4:37PM ERR error while handling message err="pq: insert or update on table \"message_0\" violates foreign key constraint \"message_type_fkey\"" height=84083 module=mess>
bdjuno=# select * from message_type;
 type | module | label | height
------+--------+-------+--------
(0 rows)

Steps to reproduce

Expected behavior

What is the role of the message_type table?

I don't see handle_msg.go in "modules/bank", is it related to this?

How were you able to resolve this error @nezha90? I'm getting the same error when trying to parse some messages from custom cosmos modules.

@VitoNaychev  put message_type module before messages module in config file


CLOUDSTACK-8683: process cmd_line.json for shared network VR in cloud-early-config

SSH access on link_local_ip is blocked for shared VR
MS is unable to program rules on VR. Vm deployment also fails as the DHCP entries cannot be added.
Fixed by processing cmd_line.json in cloud-early-config similar to isolated VR

Test:

Deploy Vm successful
Can access VR from host via ssh on link_local_ip on port 3922

Awesome, @kishankavala!
Will wait for the build/travis to vote/merge it.
Cheers,
Wilder

looks good :+1: but, should this processing be part of the setup_[router|vpcrouter|dhcpserver] itself?

LGTM :+1:
@karuturi, should we perhaps create an issue to follow up on this? I think we should refactor the early-config a bit and, as you mentioned, move the processing away to a more specific place.
Cheers,
Wilder

@wilderrodrigues agreed. we can take it up as a new issue


Fix octal escape sequence error

This fixes the install problem in #4.

@klorenz - Could we get this merged? This library is very handy :)


Added SuccessHttpResponseCode hook setting

Revamp of PR https://github.com/adnanh/webhook/pull/259
Issue 1, 2 and 3 should have been taken care of.
I'm struggling with item 4 though. First time writing go, and I'm a bit lost. I suspect I should modify webhook_test.go and do something very similar to
// test with custom return code
{"empty payload", "github", nil, `{}`, false, http.StatusBadRequest, `Hook rules were not satisfied.`, ``},
// test with custom invalid http code, should default to 200 OK
{"empty payload", "bitbucket", nil, `{}`, false, http.StatusOK, `Hook rules were not satisfied.`, ``},

@adnanh would you mind filling in the blanks here? (I'd be happy to read your patch and learn how to do it myslef for the next patch!) Or alternatively, explaining the details, including how to run tests locally, and I should be able to wrap it up.

Any chance we could get closure on this? I'm recommend using this tool in https://github.com/aioobe/dead-simple-jekyll-comments but it's annoying to instruct people to patch it / use a fork.

Hey, sorry for the wait, I'll get this in as soon as I can. Life is busy at the moment, but hopefully I'll find a few hours this week to get this done.

Thank you very much :-)

And thank you for creating this awesome little tool. It's used on a daily basis for processing comments over at programming.guide.

Cool :-) I created it to scratch my own itch, but it's evolved quite a bit since then thanks to this wonderful community.


Chrome binary location should be configurable

Did do what you mentionned
Executed the script
Got this:
Downloading Chrome Webdriver
100% |####################################################################################################################################|
DONE!
Traceback (most recent call last):
File "/Users/nicolas/Library/Python/3.7/bin/deletefb", line 10, in
sys.exit(run_delete())
File "/Users/nicolas/Library/Python/3.7/lib/python/site-packages/deletefb/deletefb.py", line 105, in run_delete
two_factor_token=args.two_factor_token
File "/Users/nicolas/Library/Python/3.7/lib/python/site-packages/deletefb/tools/login.py", line 41, in login
driver = setup_selenium(driver_path, chrome_options)
File "/Users/nicolas/Library/Python/3.7/lib/python/site-packages/deletefb/tools/chrome_driver.py", line 52, in setup_selenium
return webdriver.Chrome(executable_path=driver_path, options=options)
File "/Users/nicolas/Library/Python/3.7/lib/python/site-packages/selenium/webdriver/chrome/webdriver.py", line 81, in init
desired_capabilities=desired_capabilities)
File "/Users/nicolas/Library/Python/3.7/lib/python/site-packages/selenium/webdriver/remote/webdriver.py", line 157, in init
self.start_session(capabilities, browser_profile)
File "/Users/nicolas/Library/Python/3.7/lib/python/site-packages/selenium/webdriver/remote/webdriver.py", line 252, in start_session
response = self.execute(Command.NEW_SESSION, parameters)
File "/Users/nicolas/Library/Python/3.7/lib/python/site-packages/selenium/webdriver/remote/webdriver.py", line 321, in execute
self.error_handler.check_response(response)
File "/Users/nicolas/Library/Python/3.7/lib/python/site-packages/selenium/webdriver/remote/errorhandler.py", line 242, in check_response
raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.WebDriverException: Message: unknown error: cannot find Chrome binary
May be I am not installing the app correctly and globally ... Where should the chrome binary be ?
Originally posted by @nottavi in https://github.com/weskerfoot/DeleteFB/issues/95#issuecomment-569897059

https://github.com/weskerfoot/DeleteFB/issues/95#issuecomment-569911512


Add Docker files to get a working instance

Was able to build and run with this docker configuration.

Tks for your docker configuration.


Split Java bindings apart to produce one .java file per class

Java bindings currently put all output into one file with factory methods to instantiate derived classes.
This is not very java-ish. We need a file per class and a custom java generator in FFIG to accomplish this.

Duplicate of #347


ci: bump docker image version for CI docs publishing

Coverage decreased (-0.07%) to 66.029% when pulling fb80122da84ad1dd4acd5acb2b14af33673a8531 on fix-ci-docs into eaacdc676bba2c5289fd4a3897b5ed16acef0839 on master.

:tada: This PR is included in version 2.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Bug]: Unable to turn off autosaving

Your Persisted.nvim config
{
        save_dir = "sessions/",
        autoload = false,
        autosave = false,
}

Error messages
No response
Describe the bug
What I expect to happen
Not saved session
What actually happens
Session is saved
I did some small research. I guess it is related to the https://github.com/olimorris/persisted.nvim/blob/main/lua/persisted/init.lua#L148-L153 block.
Small test:
local function check(conf)
    if (conf.options.autosave and type(conf.options.should_autosave) == "function")
        and not conf.options.should_autosave()
    then
        print("not saving")
    else
        print("saving")
    end
end

-- Works as expected
-- autosave = true and should_autosave = true
local config1 = {}
config1.options = {}
config1.options.autosave = true
config1.options.should_autosave = function()
    return true
end

check(config1)
-- output: saving

-- Doesn't work as expected
-- autosave = false and should_autosave = true
local config2 = {}
config2.options = {}
config2.options.autosave = false
config2.options.should_autosave = function()
    return true
end

check(config2)
-- output: saving

-- Works as expected
-- autosave = true and should_autosave = false
local config3 = {}
config3.options = {}
config3.options.autosave = true
config3.options.should_autosave = function()
    return false
end

check(config3)
-- output: not saving

-- Doesn't work as expected
-- autosave = false and should_autosave = false
local config4 = {}
config4.options = {}
config4.options.autosave = false
config4.options.should_autosave = function()
    return false
end

check(config4)
-- output: saving

Reproduce the bug
Setup minimal.lua with my config.
1 Enter vim.
2. Escape vim.
3. ls sessions/ | wc -l
4. in sessions folder is a saved session.
Final checks

[X] I have made sure this issue exists in the latest version of the plugin
[X] I have tested with the minimal.lua config file above and still get the issue
[X] I have used SessionSave to save the session before restarting Neovim and using SessionLoad
[X] I have made sure this is not a duplicate issue

yeah, I'm facing the same issue too. I hope we get a fix I love the plugin so much but I am unable to turn off autosaving. please help if there is a fix.

@ewok thanks for raising this.
To confirm my understanding is correct, you expect:

When autosave = false, Persisted should never save a session automatically
Only when autosave = true should the plugin call the should_autosave function and based on it boolean output, save the session

@olimorris Yes that's right. imho autosave = false should completely turn off the autosaving, but it does't. Thank you!

@olimorris confirming! Now works like a charm. Thank you so much 👍🏼

closing


[Bug Report] When dynamically set the disabled attribute of cascader's options, the children items of options will be disabled as expected, while the first-floor items are still abled.

Element UI version
2.13.1
OS/Browsers version
chrome 81.0.4044.129
Vue version
2.6.11
Reproduction Link
https://codepen.io/azurecho/pen/VwvWbaG?editors=1000
Steps to reproduce

selected one item of cascader (and the handleChange() method will set other first-floor item to be disabled)
then re-check the cascader, you'll find other first-floor items are still abled, while their children are correctly disabled

What is Expected?
the first-floor items should also be set disabled
What is actually happening?
the first-floor items are still abled

And I think the problem maybe in Line 46 of cascader-panel/src/node.js
get isDisabled() {
    const { data, parent, config } = this;
    const disabledKey = config.disabled;
    const { checkStrictly } = config;
    return data[disabledKey] ||
      !checkStrictly && parent && parent.isDisabled; // here
}

because the first-floor nodes don't have parent, instead they have this.isDisabled.


"Error : Failed to Connect to Tango Services" after updating to Hopak release in Unity

Hi @chaosemer ,
I'm getting this error "Failed to Connect to Tango Services" after updating to Hopak release in Unity.
I wonder if Hopak release is stable?
Same app used to work fantastic in previous releases.
I'm using Tango Development Kit.
Any help....please.

Hi,
I've forwarded your message to @chaosemer, thanks for the report!

Unfortunately, the Tango development kit tablet is no longer supported by the latest SDK.
You can buy a Phab 2 Pro for further development or stick with an older SDK. You should not need to update the SDK to continue building Tango apps.

Thanks.


Repository hooks are not accessible by Integration

I could not get the list of repository hooks with Integration authorization using this functions https://github.com/google/go-github/blob/master/github/repos_hooks.go#L109
I receive the error:
GET https://api.github.com/repos/MyOrgName/MyRepoName/hooks: 403 Resource not accessible by integration [] ( 1 repositories) in MyRepoName

It works well if we authorize by OAuth2 token, but not by Integration.
Could you please suggest any other way how could I get the list of the repository hooks with the Integration?
If I there are no any yet do you have plans to implement this in the near future?
Thanks

This sounds like a GitHub API question, not a go-github-specific issue.
I'm not sure what the answer is. I don't see anything on this topic at https://developer.github.com/v3/repos/hooks/#list-hooks.
I'd suggest searching through the rest of GitHub documentation, and if you don't find anything, try contacting GitHub support. At the top of https://developer.github.com/v3/, it says:

If you have any problems or requests please contact support.

If you find that there is something that can be applied to go-github code to improve it, we welcome such enhancements, so please let us know.

Thanks @shurcooL
Yes, you're right, this is a question for the GitHub API.
It's not possible to get hooks list this way as it's not even in their list of available endpoints for app:
https://developer.github.com/v3/apps/available-endpoints/


Update Docker Compose setup and docs for an Ethereum node on the host

This removes Parity from the Docker Compose setup and instead defaults to connecting to an Ethereum node running on the host (host.docker.internal:8545). This allows developers to spin up Parity or Ganache on the host independently of the Graph Node / IPFS and Postgres.
We can work on adding a default Ganache image to the setup, but I think leaving that to developers keeps things most flexible; i.e., we're not making any assumptions about how users set up Ganache, Parity or geth.

I don't have much experience with running docker. @nenadjaja do you wanna take a look?


test PR compile issue

Test PR and see if it is work

now that CI has been fixed, please close this PR.


Multiple fixes to DER encoder

Specifically:

Implemented dynamic components sorting at the SET encoder
OCTET STRING and BIT STRING encoders fixed to produce primitive encoding only

Codecov Report

Merging #41 into master will increase coverage by 0.09%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   81.61%   81.71%   +0.09%
==========================================
  Files          25       25
  Lines        3645     3653       +8
==========================================
+ Hits         2975     2985      +10
+ Misses        670      668       -2

Impacted Files
Coverage Δ

pyasn1/type/namedtype.py
83.07% <100%> (ø)
:arrow_up:

pyasn1/codec/der/encoder.py
100% <100%> (+15.78%)
:arrow_up:

pyasn1/codec/cer/encoder.py
78.82% <100%> (+0.25%)
:arrow_up:

pyasn1/type/univ.py
77.73% <66.66%> (-0.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0dbb71...4d60b78. Read the comment docs.


Fix incorrect duplicate mock warning.

Summary
This fixes a regression introduced by: https://github.com/facebook/jest/pull/8153
I've fixed it by using the same logic already present for modules, which also check to be sure the file path isn't a match before warning.
Test plan
I added an e2e test that catches the behavior to ensure this regression will not happen again.
To reproduce manually:

Run yarn jest packages/jest-haste-map/src/__tests__/index.test.js (or any other test)
Make any change to a mock file, for example add a comment to packages/jest-config/src/__mocks__/fs.js
Run Jest again, the warning jest-haste-map: duplicate manual mock found: fs incorrectly shows up

Codecov Report

Merging #8167 into master will decrease coverage by <.01%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master    #8167      +/-   ##
==========================================
- Coverage   62.29%   62.28%   -0.01%
==========================================
  Files         265      265
  Lines       10433    10434       +1
  Branches     2533     2535       +2
==========================================
  Hits         6499     6499
  Misses       3352     3352
- Partials      582      583       +1

Impacted Files
Coverage Δ

packages/jest-haste-map/src/index.ts
81.5% <40%> (-0.24%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb9624...898b547. Read the comment docs.


Add ParallelCountBytes

Made it and CountBytes compute an MD5, so I could check that they match
(they do).

Inspired by the performance difference between the previous CL and gsutil I wrote a simple example of a multithreaded reader that keeps the bytes in order for processing.
This indeed goes faster than before: 12s vs the earlier 42s. So now we match gsutil's 11.98s.
$ target/appassembler/bin/ParallelCountBytes gs://<redacted>/dbsnp_138.b37.256m.vcf
gs://<redacted>/dbsnp_138.b37.256m.vcf: 901305932 bytes.
Reading the whole file using 4 threads...
Read all 901305932 bytes in 12s.
The MD5 is: 0xDD9CE9E581559B57F9E08A8883276AE6

This looks fine to me, however I believe this example cloud be easier if using a fixed size ExecutorService.

OK, I think you'll find this version much cleaner. Its output still matches.

Is this OK for merge?

You know, this PR is now a perfect illustration of a problem with the current adversarial way that review is done. One person's job is to write the code and fix it, the other person's job is to make sure it doesn't go in with anything bad in it. This seems reasonable but the result is that even with perfectly reasonable and capable people we occasionally end up with a PR like this one that is delayed by 3 weeks just because of a typo and a disagreement about what belongs in this PR or another. This sort of delay could be very painful and make a PR hard to merge (luckily that doesn't seem to be the case here).
If we instead had a collaborative model where the coder could indicate that they trust the reviewer to just go ahead and fix typos directly themselves, together we could get things moving a lot quicker.

Jean - apologies - I'm trying to help clear a bit of the backlog, but it's taking longer for me to be meaningful than it should.  It looks like this can still be merged.  Unfortunately, GH tools aren't the best for reviewer submitted changes to a PR. (unlike internal ones)

LGTM

@jean-philippe-martin Please don't read this latency in merging the PR as me not appreciating your work/effort (I appreciate both in fact). This PR adds an example to a non-master branch that is (sadly) stalling for other reasons (see #770). So, even though it might be frustrating from your viewpoint, there was no actual reason to speed the merge. Otherwise, I would have cherry-picked your comments in a different PR and added the fixes myself. That said, thanks Jean-Philippe :)
@jean-philippe-martin @lesv Regardless of the more general discussion, I would still love to see my comments (unnecessary "it" and closing channel in CountBytes) fixed. Now I can take care of them myself without cherry-picking :)

@mziccard no offense taken, this is really about the process and not the people. And you're absolutely right, since this branch is off-master there isn't as much change and so not as much urgency to merge. I agree 100% with you that both your comments should be addressed. Since this was merged I'll do it in a different PR.
@lesv thanks, and no need to apologize! We're doing things the normal way, it's just that the normal way might perhaps be improvable. No harm done in this case anyways.


Adapt to changed test names

Now that we use the "main" taskcat config, instead of a separate one for CI, we need to adapt to the slightly different test names.
Side-note: We could also dynamically pull out the test names from the taskcat config, run load_vars, and the across step ... but that's for another day.

To unblock CI I'll merge that without approvals.
@satya-dillikar , @aaronmeza , @leclaist


Add $url method to hono client to extract an endpoint's url

Hello,
This change is a proof of concept of a simple feature request. In our project, we are using Hono RPC and need to extract the URL of a Hono router endpoint for mocking in tests.
let fetchMock = getMiniflareFetchMock()

const { pathname, hostname } = hono.client.api.bar.$url()

fetchMock
        .get(hostname)
        .intercept({
          method: "POST",
          path: pathname,
        })
        .reply(200, {}, { headers: { "content-type": "application/json" } }),

This will mock the request to http://localhost:8777/api/bar by using the proposed $url method of the Hono client.
The $url method returns a URL representing the full url of the configured client request.
Do you think this is good to add to the client? If so, can you guide me in improving the type definitions to include $url?

And also to let me know if I should write more tests and if they are in the right file. Thank you for your amazing library!
Author should do the followings, if applicable

[ ] Add tests
[ ] Run tests
[ ] yarn denoify to generate files for Deno

Hi @renzor-fist !
This is a very interesting feature. I'll consider whether we should implement it and how to go about it. Please give me a minute. Thanks!

Hi @renzor-fist,
After consideration regarding this feature, I've concluded that it would be a valuable addition to the main. Thank you for introducing such a great feature!

If so, can you guide me in improving the type definitions to include $url?

You can simply use intersection types to achieve this. Update the following lines in the mentioned file:
https://github.com/honojs/hono/blob/4d8034ea89b6414f22554df7558b99833ec4cddc/src/client/types.ts#L10-L20
To look like:
type ClientRequest<S extends Schema> = {
  // existing code...
} & {
  $url: () => URL
}

For testing, it should suffice to verify against the actual values you've written. Should there be any type-related errors, they'll be thrown accordingly.
Thank you for your contribution.

@renzor-fist
Great work! LGTM.
I'll merge it, but given that this is a new feature rather than a mere fix, I'll merge it into the next branch. This will be released for a minor version release, which should be coming up soon. Thank you for your contribution!


Update peer dependency to 2.1.0 as TypeScript nightly will be 2.1.0

We are updating our nightly version to be 2.1.0 tonight. (merged PR)

@adidahiya thanks!


Should SingleSpaceAfterConstructFixer fix "if(" ? BracesFixer does.

Support question
I was surprise when I saw a PR from a fellow colleague pass the build with if( in the codebase, while we're using PSR-12 as a coding standard. I expected EasyCodingStandard (and the underlying PHP-CS-Fixer) to report it as wrong and propose if ( with a space instead.
So I looked at SingleSpaceAfterConstructFixer, tried to include it explicitly in my project, and it still doesn't report any errors. Why is that ?
Thanks for your insights.
gnutix

Relates to https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5757

I upgraded ECS to v9.4.40 and it fixed an issue I hadn't noticed : ECS only reported the first error it had found... Now I do have the error about the if( reported !
The only remaining issue is why I cannot write Blob|string $blob /* A blob instance or a blob URI */, with SingleSpaceAfterConstructFixer. :man_shrugging:

@gnutix , please provide reproduceable cases using vanilla PHP CS Fixer without any proxy tool as well as version of PHP CS Fixer you are using.
providing only info about proxy tool is adding extra effort on our side to figure out missing details.
anyway, big thanks for raising the issues and ideas. also, do not hesitate to propose how to fix them ;)

solved in #5913


Allow to use pre-installed binaries

Motivation
Potentially, tailscale(d?) have been installed via a separate workflow step to manage the Tailscale version via an external tool (e.g. via conda-forge - tailscale, tailscaled). This change allows tailscale/github-action action to simply use these installed binaries rather than forcing the user to download additional binaries.

I just noticed that this would also solve #56 (and supersede #103) as brew install tailscale can be run in a separate step.

FYI, I tested the latest commit in a personal project and it worked nicely.

@borchero , could you rebase this

@jayvdb sorry for the delay, finally done :smile:

ping @knyar & @patrickod


Disable auto-sorting

Allow to disable AutoSorting for MemberwisePropertyEditors

SortByName should be a a PropertyGrid property only, and it shouldn't specifically mention members.

Having it in both each memberwise property editor instance and the parent grid introduces unnecessary sync issues.
Sorting editors by name is a general behavior that any editor implementation is free to use in its own implementation as it sees fit. MemberwisePropertyEditor is the first one to do so, but others could rely on that as well in the future. They may or may not be displaying type members.
I don't think there is a good use case where one instance sorts by name and another one doesn't.

Please change the implementation so each MemberwisePropertyEditor asks its `ParentGrid´ whether or not "sort by name" should be applied, with no field that stores this.


ReplCommentConnection

Hiya! Just a small tip for your package, did you know you can fetch a Repl project's comments?
query Repl($id: Int!) {
  replById(id: $id) {
    comments(count: 1000000) {
      ...on Repl {
        pageInfo {
          nextCursor
        }
        items {
          // The Comment Fields...
        }
      }
    }
  }
}

I would assume you could. This gem is nowhere near done, I'm still working through basic Client methods, so just give me time lol

Of course, I just remembered it :)

Hi @RayhanADev  thank you for your suggestion, I think I have added it here: https://github.com/Coding-Cactus/repltalk/commit/3682bd2cbeed1c1d00478c2e4155cb7c5a3e9b25
If you have any more suggestions, please let me know!


Open Get date and interim numbers

Type of change

[x] New feature
[ ] Bug fix
[ ] Security patch
[ ] Documentation update

Description
This PR contains the 3.1 spec features GetDate and interim numbers. I've changed AllowCoordinationNumber to DisableCoordinationNumber since it's hard to set true as default value in go when false is the default value for boolean and sql.NullBool and every other solutions isn't that great. The renaming of the option should be included in v4 of Personnummer spec since it's more sens to disable it than allowing it.
Checklist

[x] I have read the CONTRIBUTING document.
[x] I have read and accepted the Code of conduct
[x] Tests passes.
[x] Style lints passes.
[x] Documentation of new public methods exists.

Seems to be something wrong with github certs

2023/03/24 20:45:27 Get "https://raw.githubusercontent.com/personnummer/meta/master/testdata/list.json": tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2023-03-24T20:45:27Z is after 2023-03-21T23:59:59Z

Seems to be something wrong with github certs

2023/03/24 20:45:27 Get "https://raw.githubusercontent.com/personnummer/meta/master/testdata/list.json": tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2023-03-24T20:45:27Z is after 2023-03-21T23:59:59Z

I think they changed keys a few days ago. Might just be that we need to re-run the tests now. :)


New version: POMDPModelTools v0.2.4

Registering package: POMDPModelTools
Repository: https://github.com/JuliaPOMDP/POMDPModelTools.jl
Created by: @zsunberg
Version: v0.2.4
Commit: 2ffeb59842052986e3260ae03036b2bdbf85e6dc
Reviewed by: @zsunberg
Reference: https://github.com/JuliaPOMDP/POMDPModelTools.jl/commit/2ffeb59842052986e3260ae03036b2bdbf85e6dc#commitcomment-37964566

this was a mistake - accidentally bumped the version twice. Please close. See #11313


demo: on each page link to setup template

would be perfectly helpful to understand how it's done asap, to have on every page of the demo a direct deeplink to it's tsx template file
e.g.
on:
https://liveviews.cc/auto-complete
link to:
https://github.com/beenotung/ts-liveview/blob/master/server/app/pages/auto-complete-demo.tsx

maybe also show the code with syntax highlight

yeah! As always there is a tool advertising...  The lightest suitable tool I know so far is
prismjs https://github.com/PrismJS/prism/

only 2KB minified & gzipped (core). Each language definition adds roughly 300-500 bytes.
supports tsx and more see https://prismjs.com/#supported-languages
should support your usage of embedded css in tsx

prismjs looks like great choice, mush smaller than highlight.js

I can get the basic syntax highlight working; trying to figure out how to enable two languages syntax highlight at the same time.

the example code is a scroll box (hard to see) where highlighting of inline code is demonstrated:
https://prismjs.com/#examples
got there from this issue and the mentioned merge: https://github.com/PrismJS/prism/issues/2776

Updated the deployed version to show source code of each demo pages.
Will explore using regex to extract /* css */ and /* html */ and wrap them into corresponding <code class="language-xxx"> (hence there will be nested <code>)
Screenshot of current version https://liveviews.cc/auto-complete:

Maybe it would be helpful to omit the import statements for simplicity

looks great!

just found, the prism.js file seems to be loaded twice
(found it because seeing a flickering when loaded the page with throttled speed)

The double loading phenomenon is expected, because the style and script tag is included in the component, not directly in the app skeleton, hence if the component is used multiple times, the resources will be loaded multiple times. On another hand, if the component is not used in that page, it's not loaded.
Normally, subsequent loading should be answered from the browser cache.
I can think up a workaround, to inject the resources only once by marking a flag in the render context, and inject them in a place of dom that will not be removed throughout the whole life cycle.
This workaround may work but it'll (slightly) increase the complexity.

when starting to dive a little deeper into the stunning demo by looking into webdev tools,
on the very first look the direct loading of prism.js and prism.css is a little diluting/diminishing the great benefits of your solution: size, speed and simplicity.
Of course it's great to be able to directly look into the setup and one should keep it!
Since you already hide the setup code and make users to click a button to show it
-> what do you think about loading all the resources needed for showing the setup on this click too?

what do you think about loading all the resources needed for showing the setup on this click too?

That is a great suggestion!
We can load the additional js and css upon the click event.
In additional, the long code that are hidden by default can also be loaded lazily.
That is possible for clients with javascript enabled, but it'll require a full page load for clients without/disabled javascript. So I prefer to keep the code content inline but load the js and css lazily.
On the other hand, I'll try to do the parsing and code generation (wrapping span with classes) on the server at boot-time or build-time. This way may result in lighter runtime 🤔


Don't need to check if source and dest regs are different because resolver.mov takes care of this.

https://github.com/dplassgit/d2lang/blob/18378e5779f29ca3c3e9f01dfa9d99ba43bf9eae/src/com/plasstech/lang/d2/codegen/x64/CallCodeGenerator.java#LL99C11-L104C12

That's the only example in the codebase, and it does it so it can document why it ISN'T called.


Validate shape of array variables

Issue:

When an MXFusion Variable is created using MXNet ndarray or Numpy array, shape passed is not validated, resulting in incorrect shape being assigned to  the Variable object.
If the shape if None, Variable's shape is defaulted to (1, ) which could be incorrect based on the value passed.

Example:
data = mxfusion.Variable(value=mx.nd.zeros(shape=(3,2))) print(data.shape)  # Prints (1, ) which is incorrect
Description of changes:

Assign the correct shape for array variables when shape passed is None.
Make existing shape validation checks to run in all code paths.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #68 into develop will increase coverage by 0.04%.
The diff coverage is 65%.

@@             Coverage Diff             @@
##           develop      #68      +/-   ##
===========================================
+ Coverage    82.88%   82.92%   +0.04%
===========================================
  Files           69       69
  Lines         3628     3637       +9
  Branches       667      670       +3
===========================================
+ Hits          3007     3016       +9
+ Misses         413      412       -1
- Partials       208      209       +1

Impacted Files
Coverage Δ

mxfusion/components/variables/variable.py
84.28% <65%> (+1.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2544457...808c705. Read the comment docs.

Just created Issue #73 for tracking this later on.


Replace"What's Up? #devfest" section with What's Up? #digitalnepal

No need for background photo here. Just plain White or bit gray is fine.

Done!

thanks. pls delete the background photo for this one?


Count default method?

Sometimes I just want to see the valid pixel counts for a mosaic, so I implemented this in #676. Creating an issue just for visibility.

done ine #676 🙏


Unauthorized Crawlera Header

HI,
Current Crawlera plans Basic and Advanced are unable to use the provided Docker image without changing its config.toml file.
The default config file includes the "X-Crawelera-Cookies: disable" header, that is no now only available on the Enterprise tier.

Well, I see no problems in providing their own configuration file to a docker image. It is possible to mount your own file with -v flag ¯_(ツ)_/¯


Governance rules for Fn Project

Introducing some lightweight governance rules for the Fn Project.
This is based on the Prometheus governance as it's lightweight and works well.
Closes #1093

few tiny comments, this is basically ready to green button to me -- thanks, this is great.
fwiw, the only thing this doc didn't make crystal clear to me after reading it pretending to be a user that knows nothing is that in general this document applies to a relatively rare set of circumstances, mostly wrt governance itself (e.g. add a repo, add a member, remove a member, change consensus rules), and most things in general should be opened as issues on a particular repo to discuss / slack and explicitly not as things to discuss in the forum in the manner outlined here. again, just wasn't perfectly clear, even though it is clearly stated that that is the case it's buried in the 'Technical Decisions' section and imo would do well to be clearly stated at the beginning. but that's just, like, my opinion, man.


physical card printing

https://www.makeplayingcards.com/custom-print-game-cards.aspx
https://www.makeplayingcards.com/promotional/card-game-boxes.html
https://www.qinprinting.com/custom-card-sets/
prob some others too look around
https://www.printmagic.com/trading-card-printing/trading-cards/
the main constraint seems to be foil booster packs. one option is to sticker them instead of printing on the foil. another is, just don't sell booster packs? booster packs can be virtual-only then players can have a deck printed that they already own the cards?
foil+sticker/label approach: https://printninja.com/printing-resource-center/printing-options/custom-game-printing/packaging-options/booster-pack/

https://www.thegamecrafter.com/make/products/PokerBooster
https://alibaba.com/showroom/foil-packaging-for-trading-cards.html
or if foil boosters are too difficult then we could do "deck packs" where a whole deck is a large booster. to get away from foil
or paper boosters

https://www.thegamecrafter.com/make/products/PokerBooster
https://alibaba.com/showroom/foil-packaging-for-trading-cards.html
or if foil boosters are too difficult then we could do "deck packs" where a whole deck is a large booster. to get away from foil
or paper boosters

maybe we can use this? https://cardpress.com/products/create-your-own-playing-card?variant=44156487303413
or smth like it. seems really affordable for a prototype


Building on #275

Netlify is happy so I'm happy.
This doesn't need a version bump because there's no behaviour changes.


Add tests for device json fetching

Describe the bug
Would be great to add a Client test for that one. This method must be quite robust, so it's important we have it covered with tests.
Expected behavior
Nice and clean tests to ensure we have got that functionality covered
Blocked by #22

Closed by #31


EthStorage Devs Meeting #29 Agenda

Meeting Info

Apr 25, 2023, 10:00 UTC+8
Duration: 60 minutes
Meeting link
Anyone can comment on the agenda where they would like this to be discussed.

Agenda

Protocol/App/Research progress
TBA

Application

W3URL

Verifiable gateway -benchmark (ongoing) - Done

EthStorage

Mining Test / 2 issues reported
4844 devnet (encode prove, contract verify, get/set versioned hash, and verify KZG proof)

Research

LSD - will share on Friday

https://github.com/ethstorage/eip4844-blob-hash-getter

TODO:

ECN DA interview this week
PEEPanEIP web3:// this week
Prepare for community day of EdCon 2023

Application

EthStorage testnet

ChainId apply 3335: pr (https://github.com/QuarkChain/chains/pull/1)
Test doc update the code, user can use it to deploy and test.
Implementation (Code review updated)
Integration test (need to tune parameters)
deploy testnet (need to redeploy)

Merged Storage Contract: https://github.com/ethstorage/storage-contracts/pull/14
Debug mining-code together with ping.
Try to impelement plonk by python.

Research:
Zk decoder on halo2:
have finished poly evaluation, https://github.com/privacy-scaling-explorations/halo2/pull/169
the whole circuit implementation is in progress.
NEXT:

Verifier Solidity code-gen;
CUDA support/ parallelism;
Recursive (Can it be associated with whole mining process)

Recording: https://drive.google.com/file/d/1he8i-vtEtS6IGDuJCwmz3IyAJ_98Zvyn/view?usp=share_link


chore(deps): :arrow_up: update dependency @commitlint/cli to ^18.2.0

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

@commitlint/cli (source)
^18.1.0 -> ^18.2.0

Release Notes

conventional-changelog/commitlint (@commitlint/cli)
v18.2.0
Compare Source
Note: Version bump only for package @commitlint/cli

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: package-lock.json
undefined


Star Wars D6 v.2.41

Changes / Comments

refactor sheet code to use CSE
implement datalists for skillnames
various minor changes.
fixes an issue that cause breaking attribute, skill, weapon and armour lines in zoom level <100%.
fixes several style glitches

Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[x] Is this a bug fix?
[x] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.

Doing some more testing.

It appears as though the most recent 'update' to the WEG Star Wars D6 (At some point over the last three days) has irrevocably ruined and otherwise disrupted quite literally every PC and NPC's sheets in my WEG SWD6 game. 1's are now 0's. 2's are now 0's. 3's are now 1's. And a myriad of misc number alterations.
You might have just killed the campaign I was partaking in permanently! Have you never heard of testing your code? I doubt reversion even will fix it.
Also the new UI is ass, to add insult to injury. There's a massive amount of wasted blank space, stats and skills alone takes up thrice the space it used to. The only notable improvements I can see are the active-toggles for force powers and the name/gender/similar section being more readable.

You could have made it an optional, off by default toggle. You did not.

Dear Kevak,
First, thank you for your honest feedback.
Secondly, I'm pretty sorry that you encountered those terrible issues. However I do not really understand them as I only modified design and layout, not behaviour or data. And of course I do testing with characters from version 2.32 without data change.
In addition all my 1+ year old campaign characters (3 PCs of real players and 10+ NPCs) are fully functional and without change.
Anyways, please help me fix the issues you encountered.

Dear Kevak,
First, thank you for your honest feedback.
Secondly, I'm pretty sorry that you encountered those terrible issues. However I do not really understand them as I only modified design and layout, not behaviour or data. And of course I do testing with characters from version 2.32 without data change.
In addition all my 1+ year old campaign characters (3 PCs of real players and 10+ NPCs) are fully functional and without change.
Anyways, please help me fix the issues you encountered.

I hope this review will give you an idea of what you did wrong. I decided to not make review comments for every single duplicate fuckup. clearly your testing was inadequate or you flat didn't notice.

Force-setting values to a specific number DELETES what the players and GM's have it set at. Let me repeat that. By forcibly setting Value=1 for a given attribute, lets say PER, every single time that sheet is initialized, it has a chance of PER being set to 1. You did not take adequate steps to preserve player data.

This applies for Value=2, Value=3, and so on. Init is Initialize. You decided to stick it before Value setting.  You did this. This was not part of the original valuecode.

Dear @NopeDotWav,
Thank you for your comment and feedback. I hope all your destroyed games are back after the revert happened yesterday.
Still if you encounter 3D to 1D transition this is because you have never changed the sheets default values to real user inputs. Basically there is no data loss as there was no data saved at all.
I'm not saying this is your fault. It is mine. I assumed everybody changes default values and my assumption was wrong.
However, having no persisted values for a skill for example can cause issues in normal roll mechanism as well even without my changes. Reasoning: the roll mechanism uses the persisted values that can be checked at Attributes & Abilities tab.
If you have encountered any other kind of data loss related to my prior change please notify me.
Once more you are right, I did test all the cases regarding the PC sheet change that I was aware of.
I missed testing all the possible browser zoom levels that caused some fractions in the layout. These issues are fixed for now.
I missed testing the other sheet types (sheet, container) as I tried to change only PC (NPC) related code. I was wrong, again, with the scoping.
Thanks

Dear @Kevak,

This applies for Value=2, Value=3, and so on. Init is Initialize. You decided to stick it before Value setting.  You did this. This was not part of the original valuecode.
Your above statement is simply not true.

Other than this I accept all the blame about not testing long & wide enough and making false assumptions.
I would be happy if you could help me fixing the issues we have as I see much energy and willingness of helping in you.
Thank you.


Installation tutorial correction

Did you find a doc bug or broken link that needs to be fixed?

What is the file name(s) where you found the bug?

What is the current text that needs to be fixed or removed? (You can copy and paste)

What should the documentation say instead?
qiskit should be installed in python at least 3.6 or later

Are there other related issues or pull requests about this bug?

Does existing documentation need to be updated with new content?

Which files need to be updated?
https://qiskit.org/documentation/getting_started.html

What content needs to be updated or replaced? (You can copy and paste)
python=3
What new content needs to be added?
have to fix it -> qiskit should be installed in python at least 3.6 or later
i followed that instruction but it didn't work at all .
I tried python=3.7 and it worked

Sorry this had no attention at the time.  The Getting Started guide has been updated to no longer reference conda at all, so I'll close this as stale, but please feel free to re-open if there's more to discuss.


New features: custom end sound, start/end commands, progress bar color

I've extended this app with some features I'm finding useful, so I thought I'd submit them in a PR for your consideration. From the CLI help:
  -p, --play-sound <filepath>   Play a sound file when the timer expires
  --start-command <filepath>    Execute a shell command ansynchronously at the start of the timer. WARNING: The command is passed directly to a shell with the same user permissions this program runs under -- use with caution!
  --end-command <filepath>      Execute a shell command ansynchronously at the end of the timer. WARNING: The command is passed directly to a shell with the same user permissions this program runs under -- use with caution!
  -c, --progress-color <color>  Color of the progress bar, as a valid colors.js text color (default: "red")

--play-sound is useful to customize the sounds played for different timers, and especially useful on systems that aren't supported natively by node-notifier
--start-command and --end-command are handy for automating any tasks at the beginning/end of a Pomodoro, such as logging start/end timestamps to a tracking file. I personally use it with a script I wrote that plays a sound every X seconds, kind of a mindfulness thing: https://gist.github.com/thehunmonkgroup/f7eb52913c4049d5e35007def3bfe026
--progress-bar is pretty obvious...the red isn't my favorite, and colors.js provides others, so this just exposes those options.

Awesome work man!
How about we make the play sound default and add an option for start the app on quiet or silent mode?
About the start and end command, can you describe an use case?
I'm planning to rewrite the whole code as ES6 with TS, wanna help out?
Thanks!

Sure, I might be interested in helping w/ the rewrite -- my Node chops are decent.
Check my original post for some use cases for the start/end scripts -- I think point #2 in the list covers that pretty well...
I think having the play file by default would be good. We'd need to add a few stock sound files available and pick one that plays when no arg is passed. Currently I play a sample of a crowd cheering and clapping...a little much for a default, but it does give me the option to raise my fist at the end of every Pomodoro. :)

Hey @thehunmonkgroup, tested and it looks awesome.
Going to merge this and work on the rewrite.
Thanks again.

@icarcal awesome thanks!


[DOC] Scheduler section

Scheduler section added inside Timers section

Let's close this PR and create a new one that integrates the Scheduler documentation in the WorkerPool section with improved examples


Allow support in LDA, BayesianLDA, SubspaceLDA, and BayesianSubspaceLDA for unique target class in training.

There is currently a check that catches if training data only presents one class (even if pool contains more). This is causing issues in subsampling for small data sets. I've checked, and the core model does not have an issue with setting nc=1. So this should be fixable. But this issue will first require:

[x] #40

@ablaom. The nc>1 check (here) is needed for SubspaceLDA and BayesianSubspaceLDA otherwise an empty LDA projection (see here)would be returned which would be useless for prediction purposes since it can't be indexed.
To confirm this consider the code below
julia> using MultivariateStats

julia> X = rand(5, 5)
5×5 Matrix{Float64}:
 0.555036  0.139782   0.729986  0.482666  0.339284
 0.045016  0.912916   0.566781  0.110083  0.495788
 0.324991  0.951135   0.753715  0.103505  0.828286
 0.280403  0.0956383  0.81681   0.816009  0.729258
 0.481897  0.0691072  0.732923  0.466879  0.85996

julia> y = repeat([1], 5)
5-element Vector{Int64}:
 1
 1
 1
 1
 1

julia> MS = MultivariateStats.fit(SubspaceLDA, X, y)
SubspaceLDA{Float64}([-0.29327457564634163 0.1534893245245258 -0.2696064616419766 -0.9042894037076474; 0.5866129709626009 0.326541071371388 0.3829256117011211 -0.2502906497483902; … ; -0.4167183019348414 0.5496947477763965 0.6558223828359053 0.0336032691015139; -0.3134889660861893 0.5780745687681941 -0.4876749454831045 0.34415795865052956], Matrix{Float64}(undef, 4, 0), Float64[], [0.4493506606668266; 0.4261169426767129; … ; 0.5476237687453269; 0.5221533324801207;;], [5])

julia> projLDA = MS.projLDA
4×0 Matrix{Float64}

For the LDA and BayesianLDA, I now remember the reason I added the nc > 1 check. Your right that the code works in when you removed the nc > 1 check, but that only works for a SimpleCovariance() estimator. For more general estimators from CovarianceEstimation.jl, at least two classes are required. Even in the case of a SimpleCovariannce estimator it would fail for SimpleCovariance(;corrected=true). To show this consider the julia code snippet below:
julia> using MLJ, MLJMultivariateStatsInterface
[ Info: Precompiling MLJMultivariateStatsInterface [1b6a4a23-ba22-4f51-9698-8599985d3728]

julia> X = MLJ.table(rand(5, 5))
Tables.MatrixTable{Matrix{Float64}} with 5 rows, 5 columns, and schema:
 :x1  Float64
 :x2  Float64
 :x3  Float64
 :x4  Float64
 :x5  Float64

julia> y = categorical(repeat([1], 5))
5-element CategoricalArrays.CategoricalArray{Int64,1,UInt32}:
 1
 1
 1
 1
 1

julia> mach = machine(LDA(cov_b=SimpleCovariance(;corrected=true)), X, y)
Machine trained 0 times; caches data
  model: LDA(method = gevd, …)
  args:
    1:  Source @008 ⏎ `Table{AbstractVector{Continuous}}`
    2:  Source @605 ⏎ `AbstractVector{Multiclass{1}}`

julia> fit!(mach)
[ Info: Training machine(LDA(method = gevd, …), …).
┌ Error: Problem fitting the machine machine(LDA(method = gevd, …), …).
└ @ MLJBase C:\Users\OKON SAMUEL\.julia\packages\MLJBase\rQDaq\src\machines.jl:617
[ Info: Running type checks...
[ Info: Type checks okay.
ERROR: PosDefException: matrix is not positive definite; Cholesky factorization failed.
[...]

julia> mach = machine(LDA(cov_b=SimpleCovariance()), X, y)
Machine trained 0 times; caches data
  model: LDA(method = gevd, …)
  args:
    1:  Source @914 ⏎ `Table{AbstractVector{Continuous}}`
    2:  Source @618 ⏎ `AbstractVector{Multiclass{1}}`

Thanks for the explanation. Still, we could be less restrictive: only throw and informative error if using an estimator different from the default  SimpleCovariance(), yes?

Thanks for the explanation. Still, we could be less restrictive: only throw an informative error if using an estimator different from the default SimpleCovariance(), yes?

Yes, that's possible.


Adds new wrap mode 10 - Hanging Indent, With Parentheses.

Adds a new wrap mode Hanging Indent, With Parentheses (10).
Fixes #941.

Codecov Report

Merging #1344 into develop will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop     #1344   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           34        34
  Lines         2242      2264   +22
=========================================
+ Hits          2242      2264   +22

This is awesome, a big improvement already! Thank you!


Add broadcast join for dataframes.

Manage broadcast join for dataframes.
User can now specify in merge, join and update methods if he wants a broadcast join with the boolean parameter "broadcast".
A broadcast join may be more efficient than sort merge join (Spark default) between a small dataframe and a big daframe. It gives every node a copy of a the small dataframe, which reduces the number of shuffle between partitions. By default, Spark performs it if a dataframe is smaller than ~10MB, but the user should be able to force it.

Codecov Report

Merging #1360 into master will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1360      +/-   ##
==========================================
- Coverage   95.22%   95.12%   -0.11%
==========================================
  Files          34       34
  Lines        7705     7707       +2
==========================================
- Hits         7337     7331       -6
- Misses        368      376       +8

Impacted Files
Coverage Δ

databricks/koalas/frame.py
96.58% <100.00%> (-0.16%)
:arrow_down:

databricks/koalas/__init__.py
85.10% <0.00%> (-8.52%)
:arrow_down:

databricks/koalas/generic.py
97.13% <0.00%> (-0.41%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d7427f...044f238. Read the comment docs.

@LucasG0 Thanks for your first contribution!
I really like the idea to have a way to indicate broadcast join.
I guess we should have a discussion about how we should have the way.

Adding an argument to indicate broadcast join (the current way here)

Pros:

Users can easily know which function supports broadcast join by its signature.

Cons:

We usually hesitate to add extra arguments without a special reason.
We might need another way to indicate left side should be broadcasted.

(we can make broadcast take both left and right, or something, though.)

Adding broadcast method to DataFrame.
Adding broadcast function separately as the same as PySpark's functions.py.

Pros:

We don't need to manage each function one-by-one.
Users can easily apply both left and right sides.

Cons:

Users might not know which function will be affected.

cc @HyukjinKwon @itholic

@ueshin , Thanks for arranging the discussions! Let me take a look at this tomorrow.
@LucasG0 , I really welcome to your first contribution to Koalas. Thanks very much :D

Thanks for your answers @ueshin @itholic ! :)
First, I would like to notice that only one side needs to be broadcasted during a brodcast join.
About the different ways to implement it :

Adding an argument to indicate broadcast join (the current way here).
It seems to be the only way to use the existing update method with a broadcast join.
However, I agree that managing functions one par one may be a significant issue.

Adding broadcast method to DataFrame.
I think it is a good way. We should choose between small_df.broadcast(large_df) or
large_df.broadcast(small_df). The first way seems more intuitive, as the small DataFrame
is the one to be broadcasted.
We may call it broadcast_join, to explicit that broadcast is used for joining purpose. It could
avoid confusion with broadcast variables in Spark, which are not necessarily used to join.

Adding broadcast function separately as the same as PySpark's functions.py.
As for the 2nd way, it could be broadcast_join(small_df,large_df).
However, I find the 2nd way fits more, as we want this functionality on DataFrame. Moreover, it
seems less explicit for user on which DataFrame should be broadcasted.

So I think the second way is the more interesting. :)

Sorry, I have to describe more about 2) and 3).
I meant broadcast method or function should return Koalas DataFrame containing Spark DataFrame with broadcast hint.
So the usage of 2) and 3) in my mind were like:
left_df.merge(right_df.broadcast(), ...)

or
left_df.merge(F.broadcast(right_df), ...)

instead of adding broadcast_join.
Then we can reuse the current implementation without any additional work and Spark will handle the broadcast hint properly.

Alright, these ways are indeed better !
I find 2) fits more but we can use 3) to avoid adding extra methods in DataFrame.

Alright, these ways are indeed better !
We could use 2) as it targets specifically DataFrame or 3) to avoid adding extra methods in DataFrame.

left_df.merge(right_df.broadcast(), ...)

I also think this way is good for now.
(But in the future, It would be better to use something like AQE to make it work automatically ??)

We could even do both 2) and 3) like DataFrame.merge, koalas.merge, DataFrame.melt and koalas.melt.
One nit on 2) is though, DataFrame.broadcast isn't friendly to users who come from PySpark compared to koalas.broadcast. But I don't really have a strong preference. Let me leave it to @ueshin.

Then shall we take 3) ?
@LucasG0 Could you update this PR as we discussed? Thanks!

Then shall we take 3) ?

Yes I agree. I feel Hyukjin's latest comment making sense.

Let's go for 3) then !
It seems that there is no way to test that a pyspark DataFrame has broadcast hint.
It is possible to test if a broadcast join occured, by using the test of PySpark itself
https://github.com/apache/spark/pull/8801/files#diff-7c2fe8530271c0635fb99f7b49e0c4a4R1086.
However, I wonder if it is relevant to reproduce this test in Koalas tests, so for now I just tested equality between koalas dataframe and the one with broadcast hint.

Let's go for 3) then !
It seems that there is no way to test that a PySpark DataFrame has broadcast hint.
It is possible to test if a broadcast join occurred, by using the test of PySpark itself
https://github.com/apache/spark/pull/8801/files#diff-7c2fe8530271c0635fb99f7b49e0c4a4R1086.
However, I wonder if it is relevant to reproduce this test in Koalas tests, so for now I just tested equality between koalas DataFrame and the one with broadcast hint.

LGTM.
@LucasG0 Could you update the PR description?

LGTM, too. 👍

Thanks! merging.

Nice, thanks !


moved exercises into subdirectory

The issue is alive as #63, but it doesn't look like there's a corresponding pull request. Now there is.

Thanks @cyborgsphinx! This is the very last active track that needs to move the exercises. It will be great to all the code that deals with the deprecated exercise locations.
The build is failing—would you have a chance to take a look at that?

I suspect the root CMakelists.txt file needs to be updated to reference the new exercise locations.

I agree that the CMakeLists.txt file needs updating. I've never actually used cmake before, aside from executing cmake -G "Unix Makefiles", so I'm not sure how to make it work. I've tried a few things, like just modifying the working directory, to no real success.

Something like this patch should work, though I didn't fully test it.
I can look up how to make a PR against this PR (?) tomorrow, but feel free to make those changes yourself if you get to it first.

That seems to work. Thanks.

LGTM 👍

I'm going to go ahead and merge this. If it needs improvements later it can be done in a separate pull request. Thanks all :heart: :heart:


feat: show measurement database and retention policy wildcards

Closes #22390

[x] Well-formatted commit messages
[x] Rebased/mergeable
[x] Tests pass
[x] Documentation updated or issue created: https://github.com/influxdata/docs-v2/issues/3201

Requires https://github.com/influxdata/influxql/pull/47

 $ influx -database mydb -precision rfc3339
Connected to http://localhost:8086 version 1.8.10
InfluxDB shell version: 1.8.10
> SHOW MEASUREMENTS ON *.*
ERR: error parsing query: found *, expected identifier at line 1, char 22

Is this feature not on 1.8.10 yet?

@est - new features are going into the 2.X influxdb. The 1.8.X line is only receiving security updates at this point.

new features are going into the 2.X influxdb

https://docs.influxdata.com/influxdb/v1.8/query_language/explore-schema/#show-measurements
says

The following queries with wildcards characters () are also allowed:
SHOW MEASUREMENTS ON . to show all databases and all RPs
SHOW MEASUREMENTS ON . to show a specific database and all its RPs

I assume it's available on 1.8, but no?

@est - looks like a Documentation bug.  Here's my reference from the VP of Product:
https://github.com/influxdata/influxdb/issues/3318#issuecomment-859302318
Let me dig a little deeper to make sure of the status.

@est -- what is preventing you from moving to 2.x?

@timhallinflux  I don't have root access on the influxd server 😭 (need great many loops to upgrade)


feat: add ms selection by shelfmark

Codecov Report
Base: 46.73% // Head: 46.55% // Decreases project coverage by -0.17% :warning:

Coverage data is based on head (4518959) compared to base (0c92e5c).
Patch coverage: 20.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   46.73%   46.55%   -0.18%
==========================================
  Files          26       26
  Lines        1575     1581       +6
==========================================
  Hits          736      736
- Misses        839      845       +6

Impacted Files
Coverage Δ

src/lib/metadatahandler.py
34.14% <0.00%> (-1.76%)
:arrow_down:

src/lib/utils.py
45.95% <33.33%> (-0.95%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Refactored libfuncs to use the BlockExt trait

Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.86%. Comparing base (936d258) to head (e784c25).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #681      +/-   ##
==========================================
- Coverage   91.87%   91.86%   -0.01%
==========================================
  Files         116      116
  Lines       34227    34200      -27
==========================================
- Hits        31445    31418      -27
  Misses       2782     2782

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Can't able to install sharp module in windows 10

npm-debug.log
Step to reproduce:
Using below node and npm versions
λ node -v
v6.9.0
λ npm -v
3.10.8
λ npm install sharp --save
                                                                                D:\Work\ocr-api\node_modules\sharp>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin\\..\..\node_mod ules\node-gyp\bin\node-gyp.js" rebuild )  else (node "" rebuild )                                                                                Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.                                            MSBUILD : error MSB3428: Could not load the Visual C++ component "VCBuild.exe". To fix this, 1) install the .NET Framework 2.0 SDK, 2) install Micros  oft Visual Studio 2005 or 3) add the location of the component to the system path if it is installed elsewhere.   System Windows_NT 10.0.15063
gyp ERR! command "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "rebui
ld"
gyp ERR! cwd D:\Work\ocr-api\node_modules\sharp
gyp ERR! node -v v6.9.0
gyp ERR! node-gyp -v v3.4.0
gyp ERR! not ok
npm WARN<EMAIL_ADDRESS>No description
npm WARN<EMAIL_ADDRESS>No repository field.
npm ERR! Windows_NT 10.0.15063
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "install" "sharp" "--save"
npm ERR! node v6.9.0
npm ERR! npm  v3.10.8
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the sharp package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs sharp
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls sharp
npm ERR! There is likely additional logging output above.
`
Please find attached file for detailed verbose log generated npm install --verbose sharp

Hello, please see https://github.com/lovell/sharp/issues/483#issuecomment-229372709

I am getting error while installing sharp package I am using windows 10 pro 64bit and node version is 18.14.0 and npm version is 9.3.1 please help me with this

@santhosh3 Please open a new installation issue and answer all of the questions if you still require help.


Uprev pydantic-core to 0.31.0

Updates to computed_field: a return type is now required. It will be inferred from return type annotations
Replaces is_instance validators w/ json_or_python validators

Requires https://github.com/pydantic/pydantic-core/pull/598 and https://github.com/pydantic/pydantic-core/pull/599
All tests passing locally, will mark as ready for review once we cut the core release

please update

please review


ci(pypi_release): Update distribution build process

Change the distribution building process to use build instead of setuptools:

The python -m build method is recommended
The tar step is problematic (see the recent build failure preventing a PyPI release). This gets rid of that step
A wheel is built and uploaded as well instead of just the source

Tests:

Tested in esptool repo (it's the same workflow): https://github.com/radimkarnis/esptool/actions/runs/10700997779
Resulting release here: https://test.pypi.org/project/esptool-ghtest/4.8.1/#files

LGTM!


error: undefined method `chomp' for nil:NilClass

This is printed to my terminal after every successful print. Printing seems to happen fine though.
I'm using ruby 1.9.2p290 (2011-07-09 revision 32553) [x86_64-darwin11.1.0] with RVM.
Just sayin'

Cheers, I'll give it a look.

Looks like net-ssh has changed its API. exec! no longer returns anything. I'll patch this now.
https://github.com/xoebus/oode/blob/master/lib/oode/net/session.rb#L41

@oliland: This should be fixed now if you update the program.

Fixed :) nice one!


x64 version of dotnet when x64 platform is set in portal

In Azure portal, I set platform to x64 in the application settings. Then added "platform": "x64" under "buildOptions" in aspnet-core app's project.json file (along with win7-x64 RID). Our app is targeting SDK "1.0.0-preview2-003121". After the deployment, I received HTTP Error 502.5 - Process Failure. On Kudu's CMD, I ran the executable under d:\home\wwwroot and received:

An attempt was made to load a program with an incorrect format. (Exception from HRESULT: 0x8007000B)

searched this error on related repos, which led me to: https://github.com/aspnet/KestrelHttpServer/issues/1118 suggesting that we need to have dotnet.exe x64 in PATH before x86. Unfortunately, we don't have x64 bit available on Azure websites (dir "D:\Program Files" vs dir "D:\Program Files (x86)").
To overcome this shortcoming, I have installed dotnet x64 at D:\home\site\deployments\tools like:
cd D:\home\site\deployments\tools

curl -O https://dotnetcli.azureedge.net/dotnet/Sdk/1.0.0-preview2-003121/dotnet-dev-win-x<IP_ADDRESS>-preview2-003121.zip

unzip dotnet-dev-win-x<IP_ADDRESS>-preview2-003121.zip

It would be very much appreciated if, in addition to x86 dontet-cli, we receive x64 counterpart installed (with all the SDK versions available for x86) out of the box, so we don't need to install in every App Service (we have seven dedicated services for the affected app). Also, if possible, would be nice if this transition in PATH (dotnet-x64 before dotnet-x86 and viceversa) happen when we change the bitness in portal.
Thanks.

Indeed, the need for 64 bit has come up, and it's something we need to look at.

Talking to @kirillg (from DocDB team), it's supposed to still work with 32 bit, albeit a bit slower in some scenarios.

@davidebbo, @kirillg, we were hitting the following NotSupportedException at CreateDocumentQuery callsite:

Partition routing information cannot be extracted from the query when running in a 32-bit preferred process. To complete your query and avoid this exception, uncheck the "Prefer 32-bit" option in your project properties window, on the Build tab.

@am11, which .Net Core DocumentDB NuGet version are you using?

@am11 Also is this a single partition collection or a partitioned collection?
Can you paste a sample of the DocDB query that is failing with this error.
Are you using the .NET Core SDK for DocumentDB(1.0.0) or the .NET Framework SDK(1.11.0) in your application?

@kirillg, we are using .NET Framework v4.5.1 and DocuemntDB is v1.11.0.
@rnagpal,
It is a single partitioned collection, but our base class supports both single and partitioned collections to engage various services. All the other consumers of base are x64 Cloud Services.
Nonetheless, this exception emerged in web application, as we upgraded the base project to v1.11.0  and some minor unrelated code changes in base class. This web application (ASP.NET Core, TFM net451) has been running since early 2016 and was building as a 32-bit process on Azure App Service.  By installing dotnet.exe x64 in deployments/tools directory (which is already in PATH), our auto-deployment from GitHub is now compiling the x64 web-application and the exception has been disappeared.

Can you paste a sample of the DocDB query that is failing with this error.

We are calling CreateDocumentQuery<Document>(selfLink, new FeedOptions{MaxItemCount=1}, docId) on an instance of Microsoft.Azure.Documents.Client.DocumentClient in the base. I suppose it generates a pretty basic SELECT query under the hood in this case.

@am11, just to confirm you're using the DocumentDB nuget package for the Full .Net framework inside a .Net Core web app?
Could you instead use the DocumentDB .NET Core NuGet? https://www.nuget.org/packages/Microsoft.Azure.DocumentDB.Core

@kirillg, these terminologies since .NET Core are pretty confusing. :)
ASP.NET Core MVC can run on full .NET Framework as well as .NET Core.
We are using .NET Framework v4.5 TFM.
(TFM = Target Framework Moniker)

@am11 We found the root cause of the regression in v1.11.0 of .NET Framework SDK and we will be releasing an update pretty soon but if you use our .NET Core DocumentDB package that Kirill pointed out, this issue will NOT repro. The .NET Core version of DocumentDB SDK is fully API compatible with the .NET Framework version and shares most of the code, so I'd recommend using our .NET Core SDK for DocumentDB portion of your app. But if you have to stick with .NET 4.5 for some reason, then you cannot use the .NET Core version.

@am11 Until we release a hotfix for this, you have several options:

Use SDK version 1.10.0 which will not have this issue of running your query against a single partition on a 32 bit web application. Note that we always had the requirement of 64 bit when using a cross partition query(in case of partitioned collection case). 32 bit app should work for a single partition query and we will fix that soon.

Compile/Deploy your Web application as 64bit which you seem to have already done and confirmed that you don't see this error.

Use the async version of the DocumentQuery instead of using the sync versions. This includes calling .FirstOrDefault() or .ToList() on the query. For example converting the following query:
var query = client.CreateDocumentQuery(documentCollectionUri).AsEnumerable();
foreach (var family in query )
{
// process each family
}
To:
var query = client.CreateDocumentQuery(documentCollectionUri).AsDocumentQuery();
while (query.HasMoreResults)
{
var feedResponse = await query.ExecuteNextAsync();
foreach (var family in feedResponse)
{
// process each family
}
}

Please let me know if you have any comments.

@am11 We have now fixed that 32-bit issue in our .NET SDK 1.11.2 release so there is no requirement of 64 bit anymore using DocumentDB SDK, though we recommend using 64-bit host processing for improved performance.

@rnagpal, thanks a lot for the information and follow-ups and sorry for not reverting earlier. I moved on to another project at company after employing the dontet-x64 workaround in Kudu.
Earlier, I discussed with the members of our backend team, they suggested that this predicament doesn't warrant the changes in their base class, given all the rest of our services have bitness set to 64.
Cheers and our kudus to @rnagpal, @kirillg and the team for fixing the issue promptly! 👍 🎉

How did you accomplish this workaround? I'm trying to use a native library that only has a 64-bit version. It's crazy that all this time in, only 32-bit .NET Core is available.

It's crazy

That it is. We get OOTB installation of x86 & x64 variants when it comes to Ruby, Python, node.js and many other frameworks, but for .NET Core it's only x86. If there is an issue in having both on the system, then it should be only x64 instead or user should have a choice. In Azure Portal -> AppService -> Settings, if we change the architecture to x64, it has no impact on .NET Core (dotnet-cli remains x86)..

workaround

My initial workaround (see top comment) was do download dotnet-sdk in x64, and put it in PATH as per Kudu documentation; D:\home\site\deployments\tools directory.
The direct download links to the SDK are available in release notes, f.ex: https://github.com/dotnet/core/blob/master/release-notes/download-archives/2.0.3.md


fix backlink

i read the faq and i saw  its means image code . and it will error 404 on my device. but the better view is use baclink to the FAQ as mentioned on article
[hacktobersfest]

Thanks Chris!


Update entrypoint.sh

Resolves #558
~using the ISCE2 plugin here as guide.~
~Hoping that -m ensures the correct raider is used/found. Though I am not sure.~
~Do you have ideas @asjohnston-asf?~

I am trying to resolve this and currently I believe there is some issue occurring after #557 was merged.
I believe there is an issue with docker entrypoint.sh and the pyproject.toml related to scripts vs. entrypoints. From what I can see from hyp3 libraries is there is an entrypoint specified.
Here is a good example:

pyproject.toml for the burst hyp3 plugin
entrypoint.sh for same repo.

Note that we are using the project.scripts.
I do not think python -um <script> works.
When I go inside the docker container:
(RAiDER) raider@2e406d8ffb2b:~/work$ python -um raider.py ++process calcDelaysGUNW -m HRES -f S1-GUNW-A-R-137-tops-20211219_20211207-020132-00124W_00046N-PP-41ba-v3_0_0.nc
/opt/conda/envs/RAiDER/bin/python: Error while finding module specification for 'raider.py' (ModuleNotFoundError: No module named 'raider'). Try using 'raider' instead of 'raider.py' as the module name.

Now,
raider.py ++process calcDelaysGUNW -m HRES -f S1-GUNW-A-R-137-tops-20211219_20211207-020132-00124W_00046N-PP-41ba-v3_0_0.nc

Works with our entrypoint. I am not sure what is the preferred way of proceeding. Thank you for your guidance @asjohnston-asf

This reverts #557. It's unclear why python raider.py... does not work as it does in various other plugins e.g. this.
In DockerizedTopsApp, we are using the now antiquated setup.py as here. However, here we have setup.py and pyproject.toml. It's unclear to me how to expose scripts in this fashion.

@jlmaurer - this is ready to be merged. Thank you, @jhkennedy.

@cmarshak @jhkennedy I can't seem to merge yet, seems there are unresolved requested changes.

@jhkennedy has to approve.


Allow to include a custom inbox query as control variable.

This is related to: https://github.com/KartikTalwar/gmail.js/issues/48
The problem here is that I receive wrong emails in my extension when I select them from inbox tab.
Navega, software developer at Appfluence Inc.

Looks good to me. Consider it merged!


mediaDevices.enumerateDevices() polyfill in adapter.js

Add a mediaDevices.enumerateDevices polyfill for Chrome using existing MediaStreamTrack.getSources().

@jan-ivar do you think it's possible to shim MST.getSources with this? Would be nice if people who used it would get the functionality and a warning :-)

@fippo sorry just saw your comment. I'd rather not shim non-standard APIs because I worry it works against convergence by allowing people to never update. We want to converge on the spec, not on something else.
For instance, my latest patch here actually removes the MST.getSources() shim from Firefox (that never did anything) in favor of the spec one.

Don't people normally copy adapter.js anyway? (I would think linking directly to it would be a cross-origin warning in many browsers).

@juberti - please let me know if anything else is needed here as well. I'm excited for feedback.

Guess this too needs a rebase and a test....


float zoom level

Nowaday tangram api is zooming previous tiles level to show float zoom level. Is it possible unzooming next level to show float level?

To clarify, the current behavior in tangram-es is to show the tiles for zoom level Z when the view is within the range [Z, Z+1). This was chosen to match the behavior of tangram-js. I can imagine alternative schemes:

zoom Z tiles are shown for views in the range [Z - 0.5, Z + 0.5)
zoom Z tiles are shown for views in the range (Z - 1, Z]

I believe the reason for the current behavior is to reduce the number of tiles needed to cover the screen - this usually improves performance without a noticeable loss in visual quality because vector tiles scale nicely. @bcamper: do you know if there are other reasons for this behavior?

Yes that's right, we previously experimented with the [Z - 0.5, Z + 0.5) approach, but generally that led to unnecessary feature density (and additional draw call performance hit) in the [Z - 0.5, Z] range. I've found the current behavior to be a better balance that still keeps the logic simple.
It's possible we might offer a way to customize this in the future (such as via a custom data source parameter to "remap" tile coordinates), but for now I anticipate keeping this behavior.


Wrong (exchanged) issue and expiry dates in RAT-certificate

Avoid duplicates

[x] Bug is not mentioned in the FAQ
[x] Bug affects both Android and iOS, for specific issues / questions that apply only to one operating system, please raise them in the respective repositories:

Android repository
iOS repository

[x] Bug is not already reported in another issue

Technical details

Device name: Xiaomi Mi 10 Lite 5G
iOS/Android version: 11
App version: CWA 2.5.1

Describe the bug
RAT-Test taken on July 23 (sample collection according to the certificate 2021-07-23T09:03:30Z).
A RAT-certificate was generated using a link from the test booking platform with the CWA app. CovPass Check claims "Zertifikat ungueltig" even though the test was just a some hours ago (other check apps also fail, an Austrian one with "zeitlich abgelaufen"). A development build of CWA 2.7 claims "Technisches Ablaufdatum: Gueltig bis 23.07.21".
Decoding the QR-Code (I don't want to post that here as it contains personal information) with https://github.com/ehn-dcc-development/ehn-sign-verify-python-trivial gives the following anonymized output:
KID in the unprotected header.
Signature           : 9v3FozjKAUo= @ ES256
Correct signature againt known key (kid=9v3FozjKAUo=)
Issuer              : DE
Experation time     :<PHONE_NUMBER>
Issued At           :<PHONE_NUMBER>
Health payload      : {
    "dob": "XXXX-XX-XX",
    "nam": {
        "fn": "Xxxxx",
        "fnt": "XXXXX",
        "gn": "Xxxxxx",
        "gnt": "XXXXXX"
    },
    "t": [
        {
            "ci": "URN:UVCI:V1:DE:D7GA1FONW8XWCRHHH95TES6KU8",
            "co": "DE",
            "is": "Robert Koch-Institut",
            "ma": "1604",
            "sc": "2021-07-23T09:03:30Z",
            "tc": "Löwen-Apotheke",
            "tg": "840539006",
            "tr": "260415000",
            "tt": "LP217198-3"
        }
    ],
    "ver": "1.3.0"
}

(I repeated that decoding also with some other tools, but always got to the same results)
According to this the expiration time<PHONE_NUMBER> is 2021-07-23T09:18:28 UTC, which does match the CWA 2.7 output.
And the issue date<PHONE_NUMBER> is 2021-07-25T09:18:28 UTC, i.e. in the future.
It seems that the expiration date and issue date in the the certificate are exchanged, making the RAT certificate invalid from the start.
Steps to reproduce the issue
I don't really know, it probably involves going to some "Löwen-Apotheke" but I have not tried to look up any details of the test-provider but this should be possible using the IDs from the certificate.
It did happen to two people who were tested at the same provider.
Expected behaviour
The RAT-certificate should validate with CovPass Check and other apps
Possible Fix
I don't really know where exactly all the data is generated, but even if it is supplied by the test center there could be some validation that at least expiration > issuedAt.
Additional context
That certificate was not obtained by (or for) me but was reported in the CCTG community channel (#cctg:bubu1.eu on matrix).

The test center seems to be using the EcoCare provider for generating the certificate. The URL for importing it into CWA was generated at https://web.prod.ndident.com/web/dashboard.

For issues with covpass please use the dedicated repo
https://github.com/Digitaler-Impfnachweis/covpass-ios/issues

The issue I described is not an issue with CovPass but with a wrong (already expired) RAT-certificate that was given the user by CWA. I just mentioned CovPass because that is the recommended way to such a certificate.
As I laid out the dates in the certificate are wrong, any software that will do a proper validation should refuse that certificate.
For example a future CWA 2.7 version:

The certificates are signed by digitaler Impfnachweis not by cwa or the Apotheke
https://github.com/Digitaler-Impfnachweis/certification-apis

@benlorenz you can also provide me the QR code. I can forward this
<EMAIL_ADDRESS>

I have sent the QR code, thanks for forwarding this!

Hi all, I'm also affected by a similar issue. I described my problem in
https://github.com/corona-warn-app/cwa-website/issues/1648
and now discovered this tread.

Hey @benlorenz Can this issue be closed now?

I guess so, yes. I would hope that ecocare or whoever was responsible for this has fixed it in the meantime but I have no way to check (I only analyzed and forwarded it for someone else). If anyone encounters this again we can reopen the issue.

@benlorenz Thanks! You as the author should see a "Close issue" button, which you can press to close this issue.


Add 0.11 upgrade details

Coverage remained the same at 52.659% when pulling 8fe272724fbcb1df5e6a645831bb171fbd6270fe on zimiao/upgrade_0.11 into f4c3e76116974c3193b91f6923437218d525c19e on pai-0.11.y.


Factbase::Pre

@rultor release, tag is 0.0.22

@rultor release, tag is 0.0.22

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.22

@yegor256 Done! FYI, the full log is here (took me 8min)


[kjobctl] Add application profile API

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add application profile API for kjobctl.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/test all

/assign @trasc

Since this will unblock some other PRs (#2413, #2394), lets go with what we have not and fix-up where necessary.
/lgtm
/approve


fixed 1 by 1

Closing #806

@jkdizajn said that it's better

Now it's broken even more 😅

Now it's broken even more
What's wrong with that ?