Fix Windows not hitting breakpoints

Fix Windows not hitting breakpoints.

Slight differences in the uri and location.uri was causing windows breakpoints not to be hit.

Updating the content of the uri to better match made the breakpoints work for Mac, Linux and Windows.

Closes #968

Functionality wise, I tested it on Linux and Windows and execution stopping on defined brakepoints worked on both platforms.
+1

It seems more likely that it requires a fix similar to what was needed to fix the infoset diff viewer:

@rthomas320 @lrbarber Yeah that is probably what the issue is but that will be in a separate PR. I am starting to work on that now.


Add docs for configuring vector databases

Summary
This PR adds documentation for "how to configure vector database".

@elisalimli I will check and see if I can find the issue with the SDK. We can merge after that has been resolved.

@elisalimli Fern are fixing the issue with the SDK generator, you can track it here: https://github.com/fern-api/fern/issues/2760

@elisalimli the issues with json from sdk should be fixed now. Please finalize this.


[BUG] Feature Page 404

Feature Page 404

Please add hactoberfest and GSSoC24 tag. You can assign me for this issue.

@4F24L Sure, you can proceed with it, please follow the guidelines mentioned in #42

@4F24L Are you working on this issue ?

Nope, currently I'm not. You can work on this if you want !!

@SaranshBangar Assign this issue to me I want to work on this issue.. also provide the content I should add on the page

@amitroy-thedev You can work on it, please make sure to follow the guidelines mentioned in #42
@dev129 I am really sorry but @amitroy-thedev asked to be assigned first on this issue

Okay

@SaranshBangar Can you provide the content I should be adding in the feature page

@SaranshBangar

What i should add on the featured items?

@amitroy-thedev Hard code some items now as the database is not setup correctly, take some inspiration from dribbble or godly for the designs


chore: fix some comments

Checking your account, this PR appears to be a possibly automated attempt to farm green squares on github. closing.


unable to execute 'gcc': No such file or directory

Hi,
I was trying to create a docker image for my python script and upload it to AWS ECR and then use it in Lambda. Our python runtime is 3.8 shown on the AWS console so I just followed this manual:
https://docs.aws.amazon.com/lambda/latest/dg/images-create.html#images-create-from-base
But I got the error when I run docker build -t image-name .

#6 14.02     gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -I/var/lang/include/python3.8 -c bitarray/_bitarray.c -o build/temp.linux-x86_64-3.8/bitarray/_bitarray.o
#6 14.02     unable to execute 'gcc': No such file or directory
#6 14.02     error: command 'gcc' failed with exit status 1

I double checked and I have gcc installed on my macOS:

Warning: gcc 11.2.0 is already installed and up-to-date.
To reinstall 11.2.0, run:
brew reinstall gcc

Would appreciate some help on resolving this. thanks!
EDIT:
This issue originates from me unable to import a CPython library cytoolz when running my script on Lambda, so I consulted these issues:
https://github.com/ethereum/web3.py/issues/1456#issuecomment-866862759
https://github.com/Miserlou/Zappa/issues/1717#issuecomment-445821158
To simulate the runtime using docker. If there is a better way to import cytoolz without using docker I would also def appreciate some hints!
Thx!!

I ran into the same issue and fixed it installing the gcc package before pip install
RUN yum install gcc -y

gcc is not a part of the base image, so it needs to be installed with the command above


Networking: Write a Web Browser | Duplicated answers, only one right

Describe the Issue
So, in the course "Scientific Computing with Python", in the chapter of "Networking: Write a Web Browser", the first exercise asks what the code will create, with multiple choice answer. The problem is that the first and last option ("A simple web server") is duplicated, but only the last one will be marked as correct.
Affected Page
https://www.freecodecamp.org/learn/scientific-computing-with-python/python-for-everybody/networking-write-a-web-browser
Steps to Reproduce

See that 1st option and the 4th option is the same
Choose the 1st option, get "Sorry, that's not the right answer. Give it another try?" as a response (see first image)
Choose the 4th option, having the same text but different position, get "Encore!" as a response (see second image)

Recommended fix or suggestions
Put either both options as correct or change the 1st one, which is the wrong one, with a different text
Screenshots
No response

Hey @TrynaChill,
Thank you for reporting this issue.
Take a closer look at both answers, they are differing a bit

A simple web server.
A simple web browser.

As there isn't anything to fix here, I'm going to close the issue.
Thank you and happy coding.

srry, i missread it, im reallly srry


"Anonymous answers" option is displayed incorrectly after form answers have been submitted

Steps to reproduce:

Open an active assessment event with "anonymous answers" activated option
Fill in any form and turn off "anonymous answers" option (deactivate)
Close assessment event and reopen the same form

Actual result:
"Anonymous answers" option is activated (turned on)
Expected result:
"Anonymous answers" option is deactivated (turned off)
Req ID: REQF_asss-004, REQF_asss-009
The comment from the previous developer:
There are two possible controversial moments:
"Anonymous answers" option is hardcoded on FE side, that always display turned on mode.
After turning on “isAnonymous” option  in survey and submitting the form http://vm-a834f9ac-1c23-40f2-9461-618361703efd.premium.cs2.netpoint-dc.com:8081/#!/Assessment/getList - query returns changed “isAnonymous“ mode for any others “isAnonymous” form fileds in current project (see attached picture). It is needed to discuss with backend if it’s an expected behavior.

@vanekbr Please, re-check bug with next input data:

Create assessment event with Anonymity: on, Show all forms on one page: on;
Start to participate;
Scroll down;
Fill in last form;
Turn off Anonymity;
Save changes;
Reopen assessment.

Actual result: Anonymity is on
Expected result: Anonymity is off


Commands that are too long write over the command prompt

They should probably instead go to the next line.

I'm using a Bash Shell on a Debian Machine.

I've finally figured out how to reliably reproduce this issue. Unfortunately, #160 didn't fix it.

Start gitsh in a small terminal emulator window.
Run a command that launches a pager or some other curses interface, e.g. log or !less somefile.txt or !vim.
Resize the terminal emulator window while the pager (etc.) is running.
Quit the pager.
Type a long command: it will wrap without adding a new line and overwrite the prompt.
Resize the terminal emulator window again.
Continue typing: the wrapping will be fixed.

I think I have a solution to this: it looks like Readline.readline sets ENV['COLUMNS'], and tput cols will read ENV['COLUMNS'], so we're just telling Readline something that it already knows.
stty size seems to produce more reliable output, ignoring the environment variable.

An stty(1) based fix for this is work-in-progress on the branch gb-window-resize

This is the GNU implementation: http://git.savannah.gnu.org/cgit/coreutils.git/tree/src/stty.c#n1586
This is the Apple: http://www.opensource.apple.com/source/adv_cmds/adv_cmds-149/stty/stty.c
Most BSDs look identical to the Apple one.
GNU falls back to $COLUMNS on systems that don't have TIOCGWINSZ, but there should be none of those. Linux documents theirs in ioctl_list(2) and OpenBSD in tty(4).
You could call IO.ioctl directly from Ruby! Or just stick with shelling out to stty(1).

@mike-burns After experimenting with IO.ioctl, I think it's going to be tricky to make it work across platforms without direct access to the constants in sys/ioctl.h, which Ruby doesn't expose.
That said, POSIX requires both stty and tput, but not the size and lines/cols arguments we're using here, and anecdotally, stty size doesn't work on Solaris.
It seems like the best bet would be to try these commands in order:

stty size
env COLUMNS='' tput cols and env LINES='' tput lines
tput cols and tput lines


[4.0] Sema: Coerce [keyPath:] index to rvalue.

Explanation: The type checker would attempt to construct an invalid AST for the index argument to a base[keyPath: kp] expression when kp is an lvalue.
Scope: Affects anyone using var key path values.
Issue: SR-5384 | rdar://problem/33160409.
Risk: Low, small bug fix to key paths. Shouldn't affect other code.
Testing: Swift CI

@swift-ci Please test

@rudkx Does this look good for 4.0?

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 074956cef0a08d223dc3f112b1af398a4634e63a
Test requested by - @jckarter

@swift-ci Please test macOS


Roll Engine from 5fa79de88daf to c5ee2e4c35c6 (3 revisions)

https://github.com/flutter/engine/compare/5fa79de88daf...c5ee2e4c35c6
2022-01-27<EMAIL_ADDRESS>Source the Vulkan headers from KhronosGroup/Vulkan-Headers (flutter/engine#31097)
2022-01-27<EMAIL_ADDRESS>Roll Skia from 2710bcfc68d3 to ddc34d96c44b (7 revisions) (flutter/engine#31117)
2022-01-27<EMAIL_ADDRESS>[Android] Get the right frame_budget when device frame_rate is not 60 (flutter/engine#30924)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Is this project deprecated?

Hi, I'm interesting to use react native with angular 2,
but this project is stopped developing 2 month ago..
I want to know this project's roadmap.. then I decide either using it or transiting to Native Script.

This project is experimental, it is not under active development.
Currently, it is only maintained to continue working with the latest versions of Angular and React Native.

@mlaval
Thank you so much!


Cert manager certificates provider

Please describe the motivation for this PR and provide enough
information so that others can review it.
Please mark with X for applicable areas.

[X] New Functionality
[ ] Documentation
[X] Install
[X] Control Plane
[ ] CLI Tool
[X] Certificate Management
[ ] Networking
[ ] Metrics
[ ] SMI Policy
[X] Security
[ ] Tests / CI System
[ ] Other

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

Yes.
This PR adds cert-manager as a certificates provider for osm.
fixes #1200
Broadly, this PR will enable certificate requests be made in the form of cert-manager CertificateRequest resources, to be signed by a pre-configured Issuer resource. This allows for certificates to be signed by issuer types both core to cert-manager, as well as external.
To enable the cert-manager provider, set the provider to cert-manager (--certificate-manager=cert-manager), as well as the CA secret and issuer options as needed.
      --cert-manager-ca-secret string       Kubernetes Secret containing cert-manager's CA certificate (default "osm-ca")
      --cert-manager-issuer-group string    cert-manager issuer group (default "cert-manager.io")
      --cert-manager-issuer-kind string     cert-manager issuer kind (default "Issuer")
      --cert-manager-issuer-name string     cert-manager issuer name (default "osm-ca")

When a certificate issuance is attempted, a new CertificateRequest resource is created, and once signed and ready, it's signed certificate is copied and the resource is deleted.
Working on this PR there are a few questions/notes from my side:

I have added kubeConfig *rest.Config as a parameter to the certificate manager getter, since we need to construct a cert-manager API client.

It seems the service certificates validity option from the CLI is not taken into account until renewal, is this intentional?

I have created a local cache for Certificaters like the others, however experimented with using CertificateRequets as my source of truth, using labels:

	CertificateRequestCommonNameLabelKey = "openservicemesh.io/common-name"
	CertificateRequestManagedLabelKey    = "openservicemesh.io/managed"
	CertificateRequestRevisionAnnotationKey = "openservicemesh.io/revision"

Which meant CertificateRequests were not deleted, and could be recovered in the event that the controller pod restarted. I was having trouble testing this since it seems the interface consuming this was always expecting the private key to be present (which is lost since the CertificateRequest resource doesn't store this).

What happens when the control plane pod is restarted? At a glance, it looks like there is no longer a watch for renewing those certificates that were issued before the control plane pod restarted.

I have used the v1beta1 cert-manager API for this. We should have v1 released in the next few weeks (:tada:), which should be a simple sed replace on the import string. We may want to hold this PR for that release.

Here are some minimal bootstrap manifests to make this work (with cert-manager installed):
kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v0.16.1/cert-manager.yaml

apiVersion: cert-manager.io/v1alpha2
kind: ClusterIssuer
metadata:
  name: selfsigned
spec:
  selfSigned: {}
---
apiVersion: cert-manager.io/v1alpha2
kind: Certificate
metadata:
  name: osm-ca
  namespace: osm-system
spec:
  isCA: true
  duration: 2160h # 90d
  secretName: osm-ca
  commonName: osm-system
  issuerRef:
    name: selfsigned
    kind: ClusterIssuer
    group: cert-manager.io
---
apiVersion: cert-manager.io/v1alpha2
kind: Issuer
metadata:
  name: osm-ca
  namespace: osm-system
spec:
  ca:
    secretName: osm-ca

/assign @draychev

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

Yes.

Would you mind sharing the related code section in this PR, do we have the code referencing the copyright of the original project?

This PR adds cert-manager as a certificates provider for osm.
fixes #1200
Broadly, this PR will enable certificate requests be made in the form of cert-manager CertificateRequest resources, to be signed by a pre-configured Issuer resource. This allows for certificates to be signed by issuer types both core to cert-manager, as well as external.

Working on this PR there are a few questions/notes from my side:

I have added kubeConfig *rest.Config as a parameter to the certificate manager getter, since we need to construct a cert-manager API client.

We create an API client once and pass it around to packages that require it: https://github.com/openservicemesh/osm/blob/main/cmd/osm-controller/osm-controller.go#L128

It seems the service certificates validity option from the CLI is not taken into account until renewal, is this intentional?

This doesn't seem intentional. Would you mind following this up with an Issue so that we can fix it.

I have created a local cache for Certificaters like the others, however experimented with using CertificateRequets as my source of truth, using labels:

	CertificateRequestCommonNameLabelKey = "openservicemesh.io/common-name"
	CertificateRequestManagedLabelKey    = "openservicemesh.io/managed"
	CertificateRequestRevisionAnnotationKey = "openservicemesh.io/revision"

Which meant CertificateRequests were not deleted, and could be recovered in the event that the controller pod restarted. I was having trouble testing this since it seems the interface consuming this was always expecting the private key to be present (which is lost since the CertificateRequest resource doesn't store this).

This is interesting and needs further discussion. Feel free to tweak the code as appropriate. I think it would be a good idea for the certificates to be recovered if the controller pod restarted. However, our certificate managers are using an in-memory cache which is the reason we haven't run into this issue yet.

What happens when the control plane pod is restarted? At a glance, it looks like there is no longer a watch for renewing those certificates that were issued before the control plane pod restarted.

That is correct, the functionality to retrieve previously issued certs upon a restart doesn't exist. The certificates are cached in memory, and eventually we will need to support the use case of being able to retrieve the certs issues prior to a restart..

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

Yes.

Would you mind sharing the related code section in this PR, do we have the code referencing the copyright of the original project?

So I answered yes to this since we are importing 	github.com/jetstack/cert-manager v0.16.1 for the APIs, which is under APACHE 2.0 . Do you need me to make a reference of that somewhere in the repo?

This PR adds cert-manager as a certificates provider for osm.
fixes #1200
Broadly, this PR will enable certificate requests be made in the form of cert-manager CertificateRequest resources, to be signed by a pre-configured Issuer resource. This allows for certificates to be signed by issuer types both core to cert-manager, as well as external.

Working on this PR there are a few questions/notes from my side:

I have added kubeConfig *rest.Config as a parameter to the certificate manager getter, since we need to construct a cert-manager API client.

We create an API client once and pass it around to packages that require it: https://github.com/openservicemesh/osm/blob/main/cmd/osm-controller/osm-controller.go#L128

Indeed but we need the raw rest.Config in order to build the cert-manager client set https://github.com/openservicemesh/osm/pull/1482/files#diff-8e159052305a0fbaed4cff35a012495fR195
At least to my knowledge! :grimacing:

It seems the service certificates validity option from the CLI is not taken into account until renewal, is this intentional?

This doesn't seem intentional. Would you mind following this up with an Issue so that we can fix it.

:+1:

I have created a local cache for Certificaters like the others, however experimented with using CertificateRequets as my source of truth, using labels:

	CertificateRequestCommonNameLabelKey = "openservicemesh.io/common-name"
	CertificateRequestManagedLabelKey    = "openservicemesh.io/managed"
	CertificateRequestRevisionAnnotationKey = "openservicemesh.io/revision"

Which meant CertificateRequests were not deleted, and could be recovered in the event that the controller pod restarted. I was having trouble testing this since it seems the interface consuming this was always expecting the private key to be present (which is lost since the CertificateRequest resource doesn't store this).

This is interesting and needs further discussion. Feel free to tweak the code as appropriate. I think it would be a good idea for the certificates to be recovered if the controller pod restarted. However, our certificate managers are using an in-memory cache which is the reason we haven't run into this issue yet.

What happens when the control plane pod is restarted? At a glance, it looks like there is no longer a watch for renewing those certificates that were issued before the control plane pod restarted.

That is correct, the functionality to retrieve previously issued certs upon a restart doesn't exist. The certificates are cached in memory, and eventually we will need to support the use case of being able to retrieve the certs issues prior to a restart..

Sure, sounds good to me. I may branch of this and re-implement that approach and see if I can get things in a working state. I didn't want to change up much outside of the certificates manager for this PR.

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

Yes.

Would you mind sharing the related code section in this PR, do we have the code referencing the copyright of the original project?

So I answered yes to this since we are importing  github.com/jetstack/cert-manager v0.16.1 for the APIs, which is under APACHE 2.0 . Do you need me to make a reference of that somewhere in the repo?

I think that should be okay. /cc @michelleN

Think this should be good for another review!
I noticed that the expiration time was being double base64 encoded on the ca bundle secret.. Not sure if it was intentional so took that out. Let me know if I should revert that change though.

In the meantime, I'm going to branch off and see if I can get the strategy using the CertifcateRequest resource as a source of truth working.

Think this should be good for another review!
I noticed that the expiration time was being double base64 encoded on the ca bundle secret.. Not sure if it was intentional so took that out. Let me know if I should revert that change though.

Thanks @JoshVanL , going to test this change.

Codecov Report

Merging #1482 into main will increase coverage by 0.86%.
The diff coverage is 65.26%.

@@            Coverage Diff             @@
##             main    #1482      +/-   ##
==========================================
+ Coverage   44.05%   44.91%   +0.86%
==========================================
  Files         109      113       +4
  Lines        4572     4847     +275
==========================================
+ Hits         2014     2177     +163
- Misses       2558     2670     +112

Impacted Files
Coverage Δ

cmd/osm-controller/validate.go
0.00% <0.00%> (ø)

pkg/certificate/types.go
0.00% <ø> (ø)

cmd/osm-controller/certificates.go
24.44% <9.09%> (-14.02%)
:arrow_down:

...g/certificate/providers/certmanager/certificate.go
60.00% <60.00%> (ø)

cmd/osm-controller/osm-controller.go
32.35% <71.42%> (+3.32%)
:arrow_up:

cmd/cli/install.go
65.69% <73.33%> (+0.89%)
:arrow_up:

...icate/providers/certmanager/certificate_manager.go
73.33% <73.33%> (ø)

pkg/certificate/providers/certmanager/helpers.go
80.48% <80.48%> (ø)

pkg/certificate/encode.go
77.35% <87.50%> (+1.80%)
:arrow_up:

pkg/certificate/providers/certmanager/debugger.go
100.00% <100.00%> (ø)

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68aad0e...4ef8c65. Read the comment docs.

Hey @shashankram, I have made those changes, and made cert-manager an option for the demo. (export CERT_MANAGER=cert-manager)

Hey @shashankram, I have made those changes, and made cert-manager an option for the demo. (export CERT_MANAGER=cert-manager)

That's awesome, going to give this a try again.

Hey @shashankram, I have made those changes, and made cert-manager an option for the demo. (export CERT_MANAGER=cert-manager)

That's awesome, going to give this a try again.

I added a commit to test this as a part of our CI, where we have scenarios using tresor, vault, and now cert-manager.

Hey @shashankram, I have made those changes, and made cert-manager an option for the demo. (export CERT_MANAGER=cert-manager)

That's awesome, going to give this a try again.

I added a commit to test this as a part of our CI, where we have scenarios using tresor, vault, and now cert-manager.

@JoshVanL the change looks great and we even have it passing the CI with a scenario for cert-manager. Have a few comments, otherwise this change is good to go.

Hey @shashankram, I have updated the PR with the changes you have suggested. Ready for another look!

@draychev would you mind reviewing this change?

Hey @shashankram @draychev
Is the CI stuck? Looks like it has everything it needs :grimacing:

Hey @shashankram @draychev
Is the CI stuck? Looks like it has everything it needs 😬

The only thing this was missing was resolving merge conflicts with main, and @draychev has handled this so this is good to merge.

@shashankram awesome, thanks!

@shashankram awesome, thanks!

@JoshVanL are there any changes pending with the cert-manager integration? Would be great to file issues for those.

@shashankram No I think that's it for me! I will open up a PR on the cert-manager website with a note, ready for osm v0.3.
Nothing from the cert-manager side needs changes.
I did go down the route of trying the implement the CertificateRequest resources as a consistent cache, though ran into problems with the private key not staying around, and the Envoy returning errors. https://github.com/JoshVanL/osm/blob/cert-manager-certificates-provider-cr-sot/pkg/certificate/providers/certmanager/certificate_manager.go
I think it makes sense to implement something like that when there is a larger effort around have a consistent cache for all providers, wdyt?


Handle floating point input and right justify numbers in input fields

Allow full floating point number with exponents such as "1.345e+5" as input. Also have the value right-justified in the input field '       1.345e+5'.

Added "text-right" to className to right-justify input numbers. Can't close because doesn't accept scientific notation.

Merged into master, and closing. Note: a separate issue is going to be written for floating-point (scientific notation) input.


[SPARK-10831][SQL][DOC]Add more configuration description

spark.sql.planner.sortMergeJoin
spark.sql.codegen
spark.sql.caseSensitive
spark.sql.dialect

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build started.

Test build #43017 has started for   PR 8917 at commit 82ec136.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43016/
Test FAILed.

Test build #43017 has finished for   PR 8917 at commit 82ec136.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43017/
Test PASSed.

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build started.

Test build #43025 has started for   PR 8917 at commit 1659f3b.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43024/
Test FAILed.

Merged build finished. Test FAILed.

Test build #43025 has finished for   PR 8917 at commit 1659f3b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43025/
Test PASSed.

ok, thanks for the review.


Is the repo dead?

I am asking because I am not seeing any response to PR's or issues for quite some time?
Any ideas guys?

+1


⚠ Bofrost.at has degraded performance

In 0e34533, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 881 ms

Resolved: Bofrost.at performance has improved in ccb3dc4.


Add design patterns examples

Codecov Report
Attention: Patch coverage is 62.50000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 89.36%.  Consider uploading reports for the commit c86988a to get more accurate results

Files
Patch %
Lines

...shtanko/patterns/behavioral/strategy/CreditCard.kt
0.00%
5 Missing :warning:

...ko/patterns/behavioral/strategy/PayByCreditCard.kt
0.00%
1 Missing :warning:

...rns/creational/builder/examples/product/Product.kt
75.00%
1 Missing :warning:

...al/factorymethod/examples/buttons/WindowsButton.kt
0.00%
1 Missing :warning:

...nal/prototype/examples/simple/ConcretePrototype.kt
50.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   89.38%   89.36%   -0.03%
==========================================
  Files        1378     1381       +3
  Lines       33342    33355      +13
  Branches     9934     9934
==========================================
+ Hits        29803    29807       +4
- Misses       1611     1620       +9
  Partials     1928     1928

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


builtin for int to errno constant string translation

Per discussion in #2082, it would be nice to have a way to translate an errno integer into the corresponding constant string.
Describe the solution you'd like

Could make a builtin function that does the translation. You'd probably want to store the int -> string mapping as a readonly bpf map that the prog can access. And only load the map if the script uses that builtin.
Originally posted by @danobi in https://github.com/iovisor/bpftrace/discussions/2082#discussioncomment-1801628

+1 this would be very nice. It's annoying to have to look that up all the time.


Bucket alias

This going to develop. Change if you like.... Threw this together somewhat fast so feel free to make changes.

Current coverage is 98.63%

Merging #42 into develop will increase coverage by +0.01% as of 3d90b26

@@            develop     #42   diff @@
=======================================
  Files            57      57
  Stmts          1597    1615    +18
  Branches          0       0
  Methods           0       0
=======================================
+ Hit            1575    1593    +18
  Partial           0       0
  Missed           22      22

Review entire Coverage Diff as of 3d90b26

Powered by Codecov. Updated on successful CI builds.


TabView sample: cannot rearange tabviewItems

Describe the bug
TabView sample cannot rearange tabviewItems
Steps to reproduce the bug
Run the gallery, look for tabview.
Try to rearange tabviewitems.
Prohibition sign appears and one cant move the item to different location.
Expected behavior
TabViewItem relocates

@roonius, thank you for filing this issue. I am not able to reproduce it (I can rearrange the tabs) in the Store version of the app. Can you provide more information please?
Specifically, which version of the app are you running (version found in app settings)? Is this from the Store or built from the master branch on GitHub? Which sample within the TabView page are you trying?

I built from the master branch:

On all tabitems i get "not allowed" sign when trying to drag/relocate tab:

Ah! Thank you for the clarification.
This specific sample is currently broken pending a framework fix that will go into WinUI 2.5 - https://github.com/microsoft/microsoft-ui-xaml/pull/2634
Do the other samples on this page work ok for you?

Oh, interesting. You're also running the WinUI 3.0 version of the Gallery. CC: @MikeHillberg will changes from 2.5 get ported into 3?

Yes but it's not there yet. WinUI3/Preview2 will include WinUI2.4.

I have verified that this issue is fixed in the master branch of the Xaml Controls Gallery. The fix will take some time to propagate to the other endpoints (like the Store version and the WinUI 3.0 Preview version) but it is expected to get to all of those endpoints eventually - so I'm going to close this issue.

Thank you @stmoy


Issue with k8s.io/docs/concepts/services-networking/network-policies/

This is a Bug Report

IP addresses in the ranges <IP_ADDRESS>–<IP_ADDRESS> and <IP_ADDRESS>–<IP_ADDRESS> (ie, all of <IP_ADDRESS>/16 except <IP_ADDRESS>/24)
I think this sample is not correct, should except sample be <IP_ADDRESS>/8?
if except <IP_ADDRESS>/24, the subnet will be <IP_ADDRESS>, all <IP_ADDRESS>/16 will be excepted

Problem:
Proposed Solution:
Page to Update:
https://kubernetes.io/...

@douwilliam I think your network address calculations are off.
An exception <IP_ADDRESS>/24 means the mask for the exception is 24 bits of 1 and then the rest is 0 ie<PHONE_NUMBER>111111111100000000 or <IP_ADDRESS>
/triage support


Missing ending " in README example usage

what

Added a missing quote in README usage code example

why

It was missing.

references

@korsakjakub thanks. If you can help out with the failing checks, much appreciated.


Load thumbnail

I went ahead and change the the laod thumbnail to a env flag that defaults to false to avoid surprise changes

Ive realize there some extra commits in this pr
I will remove them.
Would you like me to keep the change to workspace?

This pr has to many unrelated changes I am therefore closing it and instead opening a more straight foward pr #7


Instead of static json for the demo, use IndexedDB

Write a JS script to preload the data.

Makes more sense to use a restify demo application instead.


macOS installation (build from source) fails

Running the installation for "build from source" for mac fails.
https://mxnet.incubator.apache.org/install/index.html?platform=MacOS&language=Python&processor=CPU#validate-mxnet-installation
It has you run a shell script.
Two issues:

It detects a previous version, but fails to remove it.

MXNet 1.0.0.post4 is already installed.
This installation might interfere with current installation attempt.
Do you want to remove installed version? (y/n): y
Skipping mxnet as it is not installed.
MXNet 1.0.0.post4 is already installed.
This installation might interfere with current installation attempt.
Do you want to remove installed version? (y/n): y
Skipping mxnet as it is not installed.
MXNet 1.0.0.post4 is already installed.
This installation might interfere with current installation attempt.

Then later the test fails:

BEGIN: Test MXNet
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "mxnet/__init__.py", line 24, in <module>
    from .context import Context, current_context, cpu, gpu, cpu_pinned
  File "mxnet/context.py", line 24, in <module>
    from .base import classproperty, with_metaclass, _MXClassPropertyMetaClass
  File "mxnet/base.py", line 214, in <module>
    _LIB = _load_lib()
  File "mxnet/base.py", line 205, in _load_lib
    lib = ctypes.CDLL(lib_path[0], ctypes.RTLD_LOCAL)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/ctypes/__init__.py", line 365, in __init__
    self._handle = _dlopen(self._name, mode)
OSError: dlopen(/Users/markhama/mxnet/python/mxnet/../../lib/libmxnet.so, 6): Library not loaded: /usr/local/opt/ffmpeg/lib/libavcodec.57.dylib
  Referenced from: /usr/local/opt/opencv/lib/libopencv_videoio.3.3.dylib
  Reason: image not found
0a1,2
> [[2. 2. 2.]
>  [2. 2. 2.]]

ERROR: Following files differ: mxnet_test.log mxnet_test.expected
ERROR: MXNet test failed
END: Test MXNet

:-(

Importing mxnet yields a warning:
>>> import mxnet
dyld: warning, LC_RPATH ${ORIGIN} in /Users/markhama/Library/Python/2.7/lib/python/site-packages/mxnet/libmxnet.so being ignored in restricted program because it is a relative path
>>>

@mxnet-label-bot [Installation, Doc, OSX]

@mxnet-label-bot: ["Good First Issue"]

If we go with https://github.com/apache/incubator-mxnet/pull/12388 then this issue will be moot. We wouldn't be using that script. However, if we get the script updated and working, it can be an alternative install option for users.

@aaronmarkham Seems like the validate-mxnet-installation anchor link does not go to the intended page. Can you please check the URL once again ?

#12388 was merged and that removed this script from the instructions. I also moved validation to a separate page to reduce the complexity of the install page.
@piyushghai Glad to hear that the instructions work for you!
This issue can be closed.


Global variables

To be able to work with once-generated data through all anonymizations need to add global variables.

Released in v1.8.0


FINOS participants can send/receive emails using @finos.org mailing-lists

Description
Validate that banks can receive and send emails via @finos.org mailing-lists
Comparison matrix for alternative mailing-list systems - https://docs.google.com/spreadsheets/d/1xECnLFhq-AZJ4t1JArn1n20AVHM5wvRsj6-3t7YUfbY
Next Steps
-[ ] Developers (how many?) from a financial institution validates he/she is able and allowed to access and sign up to https://lists.cloudfoundry.org
-[ ] Setup a Groups.io Enterprise Trial account (using "lists.finos.org" as domain)
-[ ] Create<EMAIL_ADDRESS>hosted on Groups.io
-[ ] Test all current FINOS use cases for mailing-list use and management
Additional FINOS history : https://finosfoundation.atlassian.net/browse/ODP-38

I've been thinking about this and the work we've done around collaboration on GitHub.com https://finosfoundation.atlassian.net/wiki/spaces/FDX/pages/75530554/Code+Hosting .
I believe that emails have always been used - and especially now - with 2 main purposes:

Announcements and notifications, mostly via<EMAIL_ADDRESS>First level support, via<EMAIL_ADDRESS>
All the PMC and project mailing lists have very low traffic; 90% of the communication is from FINOS staff and 99% have no responses, which is in turn an announcement or notification.
I believe that setting up conversations like GitHub Team discussions could be a better option, especially considering the possibility to fall back to emails. Via https://github.com/finos/open-developer-platform/issues/22 we will provide better documentation and best practices.
@mcleo-d - are you ok to close this issue and follow progress on https://github.com/finos/open-developer-platform/issues/22 ?

@maoo - Let's keep this issue open, but evaluate the way forward based on the results of #22.
James.

Given the introduction of LFX in our infrastructure, we are going to rely on those collaboration tools.
Closing issue and marking it with LFX label.


fix: trigger parcels refetch on move

Description
Change QUERY_DIM so that a refetch of parcels is triggered when the user pan around the map.
The value should be low enough to not miss parcels and high enough to avoid redundant refetches.
Issue
fixes #306
Checklist:

[x] My commit message follows the Conventional Commits specification
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have tested my code
[x] My changes generate no new warnings
[x] My PR is rebased off the most recent develop branch
[x] My PR is opened against the develop branch

Alert Reviewers
@codynhat @gravenp

Since the change of QUERY_DIM is so drastic here, I am a bit curious about what other values > .025 performed like.

With the new implementation using the bounding box index it changed the magnitude of the result of the operation that we compare to QUERY_DIM.

Anecdotally, were those higher values still resulting in "ghost" parcels?

Yes in case of vertical panning parcels that should be center of the screen wouldn't be there.
The value could be a bit higher for the x axis and a bit lower for the y axis, we could have to have two QUERY_DIM (QUERY_DIM_LON and QUERY_DIM_LAT) but 0.025 seems to fit reasonably well for both.

Thanks for being all over this, @tnrdd! Based on that explanation, this is good to go from my perspective.
@codynhat, ready for your review and merge.


params javadocs

This PR includes javadocs for params.hpp. A few components from javadoc.hpp are still missing in the documentation so this is still a draft.
These files were probably not the best place to start with the javadocs, which is something we could discuss.

I'm going to merge this because something is better than nothing, but it still needs editing


Support of timing functions

Hi,
Would it be possible to support timing functions like https://github.com/cats-oss/Sica#easingfunctions in ViewAnimator?
Thanks for this library.

@Narayane I was thinking about that feature some time ago. How would it work? Do each element get a specific animation time?

Potentially. I'll keep you in touch :)

Hi @marcosgriselli,
I've tried to follow this approach but it doesn't work with your extension UIView.animate()...
Even when I add parameter options: [.curveEaseInOut] to your extension UIView.animate(), it doesn't seem take in account at runtime, move is the save with and without...
Do you have any idea on how to make it?
Thanks.

@Narayane the reason why the options don't work on that particular function is that the animation is using springs (https://developer.apple.com/documentation/uikit/uiview/1622594-animatewithduration). We need to create a new function that uses the UIView animation API that doesn't use springs.
Here's what the function will look like:
 static func animate(views: [UIView],
                    animations: [Animation],
                    reversed: Bool = false,
                    initialAlpha: CGFloat = 0.0,
                    finalAlpha: CGFloat = 1.0,
                    delay: Double = 0,
                    animationInterval: TimeInterval = 0.05,
                    duration: TimeInterval = ViewAnimatorConfig.duration,
                    options: UIView.AnimationOptions = [],
                    completion: (() -> Void)? = nil) {

    guard views.count > 0 else {
        completion?()
        return
    }

    views.forEach { $0.alpha = initialAlpha }
    let dispatchGroup = DispatchGroup()
    for _ in 1...views.count { dispatchGroup.enter() }
    DispatchQueue.main.asyncAfter(deadline: .now() + delay) {
        for (index, view) in views.enumerated() {
            view.alpha = initialAlpha
            view.animate(animations: animations,
                         reversed: reversed,
                         initialAlpha: initialAlpha,
                         finalAlpha: finalAlpha,
                         delay: Double(index) * animationInterval,
                         duration: duration,
                         options: options,
                         completion: { dispatchGroup.leave() })
        }
    }

    dispatchGroup.notify(queue: .main) {
        completion?()
    }
}

I'll create a release later this week with support for this but for the moment that function should be enough to drop-in and use in your project.


v3 - bug - grid padding behaviour is wrong

Ionic version:  (check one with "x")
[ ] 1.x
[ ] 2.x
[x] 3.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
Having a normal grid (one row, one col - test), its padding is off the charts, even when I see it is just 5px.

I have many grids usages, and it happened only in 2 of them..
Expected behavior:
When removing the padding: 5px  from the grid class:

As you can see, the difference is not 5px in each direction..
Related code:
<ion-grid>
    <ion-row>
        <ion-col>A</ion-col>
    </ion-row>
</ion-grid>

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
    Cordova CLI: 6.5.0
    Ionic Framework Version: 2.3.0-201703231941
    Ionic CLI Version: 3.0.0-beta.4
    ios-deploy version: Not installed
    ios-sim version: Not installed
    OS: Windows 10
    Node Version: v6.9.1
    Xcode version: Not installed

I've released a new version 3.0.0-beta.1 with this fix, here are some steps to upgrade with the latest versions:
https://docs.google.com/document/d/1vGokwMXPQItZmTHZQbTO4qwj_SQymFhRS_nJmiH0K3w/edit?usp=sharing
Thanks! 🙂

@brandyscarney Thanks for the fix
Can I ask why did you add "@angular/animations"? Where do you use it?

@AmitMY It is a peer dependency for Angular: https://github.com/angular/angular/blob/master/CHANGELOG.md#animation-package

@brandyscarney Oh, I was sure it was optional. Thanks for the link

@AmitMY I think maybe it should be, but Angular has it listed as a peer dependency on @angular/platform-server:
https://github.com/angular/angular/issues/15427#issuecomment-288824375
https://github.com/angular/angular/issues/15450#issuecomment-289027132
I actually just messaged the Angular team about it, so I'll let you know!

@AmitMY So it is a peer dependency on purpose, however since we are not using platform-server we decided to remove it from Ionic. I released a new version that doesn't need animations or platform-server<EMAIL_ADDRESS>

@brandyscarney Thanks for the very quick responses and updates.
So far, beta is stable except for that one bug https://github.com/driftyco/ionic/issues/10863


Add Categories to the match-items

Result items may have categories added from Nano / SearchService in v 5.5.0+
The field should be added as an optional field in the types.

Fixed in cd8772e2c89a223dd023082b65214cb1522a63b1


Make index error message more user friendly

The error message output when an invalid index is entered is too
technical.
Resolve #237

Codecov Report

Merging #275 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #275   +/-   ##
=========================================
  Coverage     83.89%   83.89%
  Complexity     1121     1121
=========================================
  Files           127      127
  Lines          3037     3037
  Branches        402      402
=========================================
  Hits           2548     2548
  Misses          401      401
  Partials         88       88

Impacted Files
Coverage Δ
Complexity Δ

...in/java/seedu/address/logic/parser/ParserUtil.java
98.57% <ø> (ø)
29.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f5a922...2c6beb3. Read the comment docs.


Update STM32WL

Hold on this might be bad because of how the cores are specified in the algos. I guess the tests will tell.


Possibility to differentiate between canceled & failed sign in

There is currently no possibility to differentiate between a canceled sign in (e.g. the user pressed the back button to leave the auth method picker) and a failed sign in attempt.
As far as I can see this always results in RESULT_CANCELED as a return code.
By consequence it is difficult to show an according message to the user only if the login failed, as for a canceled login I do not want to show an error message (user decided to cancel the login).
Would it be an idea to introduce something like a RESULT_SIGN_IN_FAILED return code?
Or how is this inteded to be used in general?

#357 has that goal in mind: your activity would have to implement (I'm hoping to find a way around that) AuthUI.SignInResult:
public interface SignInResult {
    void onAuthUISuccess(IdpResponse data);

    void onAuthUIFailure(int resultCode);
}

You could get different failure codes from the resultCode. There is still a lot more work to be done, but I think something like that will happen by 2.0.

Ok, thank you for the information.
And to break the code of conduct :) -> is there an ETA for the next release? Some milestone?

I have to say that this is currently really a blocker for me regarding usability. The way it is now I have to tell the user that the sign in failed even if he consciously pressed on the back button and cancelled the sign in process.
Is there possibly at least some workaround or something similar?
Or do you possibly have a suggestion on how to handle this case from a UI point of view?
I am really a bit struggling (sorry if this is the wrong place to ask for help, please be so kind to redirect me if needed).

@Juchar Haleluya! This issue will probably be fixed in v1.1.0. Sorry about not getting it done in #357 like I had originally planned. In the end, we didn't change the public api so I decided to hold back on a ResultCodes refactor.
You can check out the progress of this refactor here: #426.

A fix for this issue has been released in version 1.1.0


Add shortcuts

Add two shortcuts for commands:

Delete Horizontal White Space
Find All References

@GKotfis : Thanks for your contribution! The author, @gewarren, has been notified to review your proposed change.


Internal "Cannot invoke this object" error

Requires two files - if I place the grammar into the test file the bug goes away. You can also comment out the <?before> alternation and the parse will complete. The complete error text is at the bottom of the file. I think something isn't correctly initializing $!state{'indent'} in the source, but I haven't figured out how to correctly initialize it.
-- Perl6/Parser/Pure/Grammar.pm6 --
{use Grammar::Debugger;
grammar Perl6::Parser::Pure::Grammar
{
proto rule statement_control { <...> }
token statement_control:sym {  }
rule statementlist
{
| <?before <.[)]}]>> # Commenting this out unbreaks the debugger
| <statement_control>*
}
rule TOP {  }
}
}
-- t/01-single-token.t --
use v6;
use Test;
use Perl6::Parser::Pure::Grammar;
plan 1;
my $g = Perl6::Parser::Pure::Grammar.new;
ok $g.parse( Q{} ),  Q{runs};
-- cut --
-- the error --
6 t/01-single-tokens.t
1..1
TOP

r
|  statementlist
Cannot invoke this object (REPR: Null; VMNull)
in block  at /home/jgoff/.rakudobrew/moar-master/install/share/perl6/site/sources/0915E37B99013FE906246809B378838A8288E251 (Grammar::Debugger) line 116
in regex statementlist at /home/jgoff/breaks-grammar-debugger/lib/Perl6/Parser/Pure/Grammar.pm6 (Perl6::Parser::Pure::Grammar) line 9
in block  at /home/jgoff/.rakudobrew/moar-master/install/share/perl6/site/sources/0915E37B99013FE906246809B378838A8288E251 (Grammar::Debugger) line 123
in regex TOP at /home/jgoff/breaks-grammar-debugger/lib/Perl6/Parser/Pure/Grammar.pm6 (Perl6::Parser::Pure::Grammar) line 14
in block  at /home/jgoff/.rakudobrew/moar-master/install/share/perl6/site/sources/0915E37B99013FE906246809B378838A8288E251 (Grammar::Debugger) line 123
in block  at t/01-single-tokens.t line 10
-- cut here --

I should mention that this is XUbuntu Linux running in a Windows host, looking at the code in the area of failure reminded me of this.
I've just run into the same problem on another grammar (really the same one but it's hand-rolled), and I can give you some more help, assuming I don't track it down myself tonight.
It's most likely the $!state hash being corrupted in some fashion, doing 'say $!state.perl' before the self!cache-wrapped call works, doing the same immediately inside the call fails with the error mentioned above.

Actually doing some more research I've eliminated everything reasonable in your code and still get the VMNull, so I'm wondering more and more whether it's a problem with Terminal::ANSIColor... I'll remove that and see if I come up with a different response.

FWIW the no precompilation workaround solved the issue I had on ubuntu

FWIW the no precompilation workaround solved the issue I had on ubuntu

I'll give that a try tonight, thanks a lot.

It's even simpler than I suspected. Any grammar with a hyphen in a rule name should trigger the bug.

I hit this same issue too.  My quoted-string rule triggers it reliably:
  token single-quote { "'" }
  token double-quote { "\"" }
  token word { \w+ }
  rule phrase { <word> [<word>]* }
  rule single-quoted-string { <single-quote><phrase><single-quote> }
  rule double-quoted-string { <double-quote><phrase><double-quote> }
  rule quoted-string { [ <single-quoted-string> | <double-quoted-string> ] }

This code works fine if I don't include use Grammar::Tracer.

Me too. Problem goes away with no precompilation;. Thanks @vendethiel++.
I should have looked first but instead golfed before coming here to file a bug and finding this one. The following is probably all moot given that it's clearly related to precompilation. But one never knows and it's very different from the scenarios already covered and I don't want to waste what I've got just in case.
Here it is on glot.io: https://glot.io/snippets/ffrhmnf20i#
Main script:
use lib '.';
use foo;

Module foo:
say $*DISTRO;
use Grammar::Tracer;
grammar foo {
  token TOP       { <bar> | a }
  token bar       { <!before b> }
}
foo .parse: 'x'

displays in stdout:
debian (9.stretch)
TOP

and then on stderr:
===SORRY!===
Cannot invoke this object (REPR: Null; VMNull)

Curiously <!before .>, ?before, after, !after, ?after all fail with . or x but <before b> and <?before b> work while !before b and any after form still fails with b.


Introduce NAC

Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

...

New functionality

...

Test plan
How are these changes tested?

[ ] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

#2628  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sanketkedia and the rest of your teammates on  Graphite


WIP/POC: Remove exclusive range syntax

Expendable proof of concept for removing exclusive ranges (...) from the language.
Discussed in https://github.com/crystal-lang/crystal/issues/4214

Closing to stop spamming the PR queue with this WIP.


Issues with updateBlockSchema on a Extension for ElementContent

Has anyone had an issue when trying yo add to the content on the summary for the ElementContent?
using updateBlockSchema
public function updateBlockSchema($blockSchema)
    {
        $blockSchema['content'] = $this->owner->getCustomPersona();
        // $blockSchema['content'] = $this->owner->getSummary();

        return $blockSchema;
    }

You need to pass the variable in by reference and it doesn't need to be returned from the method.
public function updateBlockSchema(array &$blockSchema)

Hi @hadlee-lineham-wundermanthompson, thanks for taking the time to post to the issue tracker.
The issue tracker is reserved for reporting bugs and we don’t provide support via the issue tracker. There are great community support options where you can get help including our forum, Stack Overflow (remember to tag as silverstripe) and even Slack.
I’ll close this issue now but if you find the problem is within the module (and can provide replication steps), feel free to reopen the issue.


List all available algorithms under CoFI documentation

What algorithms do we have under each category?

write that into a separate markdown file in the documentation

(Use optimize._minimize.MINIMIZE_METHODS for scipy)
Need to work with #69 #106

Will be added to techlauncher fork so close here for now.


Typography - em, type size on Chrome

Just read it in #151 that Kevin set em to 14px, which by default is 16px. I wonder if it is not being applied and overwriting the browser default, and it is the cause of extra large types on Chrome?
everthing is larger on Chrome:

incorrect size resulting in misaligned lables:

@thatbudakguy if you're looking at other typohraphy issues maybe you could help take a look at this?

@xinyil yeah, i'll look into this

it is being applied correctly, and it affects all browsers equally - if you set it to 16px all the text gets larger, including in chrome. I'm gonna close this bc whatever's going on in Chrome (if it's still happening) probably isn't related to setting the em value.

if by misaligned you mean the alignment of the text inside the "pill" not being centered, I think this is fixed in this commit, which should be in qa. if it doesn't look right still, let me know!


Test for new codeowners file

This is simply a test of the new codeowners file.
I will close this pr shortly.

Closing this pr. I will open requests to change this in our other repositories.


GIf not showing up after relanching OBS

Hi and i'd love to tell you i love your soft before telling you my issue ! keep up to nice work ;)
So here it is, when i set up clr in both CC and OBS it works fine but when i quit an re-start obs clr is broken for all gifs, i have to go into CC and re-link the gifs one by one to theire window path ( even know it's right already) then it will works again.
useless to say it s a pain to relink all gifs after every reboot / restart of obs
any clues on how to fix this issue ?
with love and chocolate, Cptnchoco

I think the issue is CC not closing the web socket properly when OBS restarts. So the CLR page is not communicating with CC after restart.
Please try the following:
Close and reopen OBS, GIF should not work as stated above.
Close and reopen CC. Try the GIF. Likely it should work if it is the socket connection. (Give it a few seconds)
If that does not work, close and restart OBS a 2nd time.
Please share the results.

i ll do some testing on wednesday and share the result here, since then have a good one mate !

I reworked how the CLR browser closes out connections when ControlCast closes. I was able to restart both CC and OBS and have it auto reconnect to send images/gifs.
Please try and reproduce this on 0.3.3 Thanks!


Logo

Hi. I am a graphic designer. I volunteer to design a logo for open source projects. I can design it for you to use it in the readme file. What dou you say?

Hi, it would be great! Thanks for the Offer


How to deal with overlapping markers?

I have multiple markers that can potentially all appear in the same spot.
I would like to manipulate their z-index to be able to decide which one to show on top, but I haven't found a way to add styles to the inline CSS generated for the marker element's parent div? Is there any documentation about this?

@SachaG Just adding z-index to your Marker component would do the trick. No need to add it to the marker element's parent div. Have you tried that?

Oh you're right actually. I thought I had tested that already but I might've been missing the position: absolute or relative to make the z-index work. Sorry about that!

No worries @SachaG, we're here to help!


DIfferents type of DB population at start

Solved, the file had to be in the "spring-petclinic-rest-master/src/main/resources/db/hsqldb" directory no in the mysql one


DMP-1350: Extend IntegrationBase

Description:

made integration tests that need the full Spring application context started extend IntegratonBase, in line with other integration tests
pulled up common dependency ObjectMapper to IntegratonBase

Mario doesn't have github push access yet so creating this PR off the back of this one: https://github.com/hmcts/darts-api/pull/833 in order to get the pipelines built.


[V2V] Forces a targeted refresh of the created VM

Over time, we had issues with the destination provider refresh, making the whole migration fail just because the newly created VM doesn't appear in the inventory.  For some time already, virt-v2v-wrapper provides the UUID of the VM created during the conversion.
This pull request makes the migration workflow trigger a targeted refresh, that will ensure that the VM will appear in the VMDB.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1794005

@agrare I am not so sure, I mean:
https://github.com/ManageIQ/manageiq-providers-ovirt/blob/master/app/models/manageiq/providers/redhat/inventory/collector/target_collection.rb#L120
and it seems that uuid_from_ems_ref (Line 260) will work fine when given just a uuid.

OpenStack provider takes UUID of a (newly created) VM and passes it to refresh even the VM is not yet in vmdb. https://github.com/ManageIQ/manageiq-providers-openstack/blob/master/app/models/manageiq/providers/openstack/cloud_manager/event_target_parser.rb#L51-L52

Okay great, @fdupont-redhat once you queue the refresh with that target this should be ready for some live testing

Thanks @borod108 and @aufi.
@agrare I updated code to queue the refresh and applied the patch to a nightly build: 2020-02-03, where event handling fails for RHV (https://gitter.im/ManageIQ/manageiq-providers-ovirt?at=5e3be78515941335585c52a9). And the targeted refresh is successfully triggered and populates the VMDB, which allows migration to complete.
I didn't test on OpenStack as our lab is currently down, but I'm pretty confident.

Just the one comment then this looks good to me

:tada: this is awesome thanks @fdupont-redhat !

Ivanchuk backport details:
$ git log -1
commit e0797d35c44467268f3e06b1098fdf5433e0d362
Author: Adam Grare<EMAIL_ADDRESS>Date:   Thu Feb 6 09:19:57 2020 -0500

    Merge pull request #19743 from fdupont-redhat/v2v_do_targeted_refresh

    [V2V] Forces a targeted refresh of the created VM

    (cherry picked from commit 8c65f0517a063efc3f607b9892de52243c05d7e1)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1805814


Satellite Crash

Version of Advanced Rocketry
1.5.0-36
Have you verified this is an issue in the latest unstable build
Y
Version of LibVulpes
0.4.0-53
Version of Minecraft
1.12.2
Crash report or log (if applicable)
https://paste.dimdev.org/unidiwigej.mccrash
Description of the problem
I built a rocket with a satellite and guidance computer and I gave the guidance computer a planetary chip with earth selected as the destination.  Then I opened the satellite bay when the rocket returned causing the crash.  I'm pretty sure dynamic surroundings/orelib is involved.  If you need more info let me know.

Does this occur without DynamicSurroundingsCore installed?

I haven't tested and it happens somewhat randomly so I'm not sure how to recreate it.  But just messing around with stuff causes it to happen.  So I'm not sure

idk if it's still an issue or not

are you able to test and verify with the latest build please?

Yea I can't really recreate it so I guess I'll close this issue, I'll make a new issue if anything happens


Request failed: Error: Request failed with status code 403

The plugin has been working on an iMac. I installed it on a Beaglebone Black yesterday and get this error continuously.
[5/28/2021, 3:29:08 PM] [Wyze] Request failed: Error: Request failed with status code 403
[5/28/2021, 3:29:08 PM] [Wyze] Response (Forbidden): {"description":"Request forbidden."}
[5/28/2021, 3:29:08 PM] [Wyze] Error getting devices: Error: Request failed with status code 403

I am also seeing this same error.  I have been using this plugin for about a year.
Any ideas?
Steve Q

Have you by any chance referenced a second instance of Homebridge to your Wyze account? That may be related to my errors.

Bryan

On Jun 5, 2021, at 7:26 AM, SteveQ2 @.***> wrote:
I am also seeing this same error. I have been using this plugin for about a year.
Any ideas?
Steve Q
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/misenhower/homebridge-wyze-connected-home/issues/41#issuecomment-855247899, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALDUI43PO4W47JTN5EOYYSLTRIX3HANCNFSM45W7EL4Q.

Error 403 has been fixed. See:
https://github.com/misenhower/homebridge-wyze-connected-home/issues/37?_pjax=%23js-repo-pjax-container

Bryan

On Jun 5, 2021, at 7:26 AM, SteveQ2 @.***> wrote:
I am also seeing this same error. I have been using this plugin for about a year.
Any ideas?
Steve Q
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/misenhower/homebridge-wyze-connected-home/issues/41#issuecomment-855247899, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALDUI43PO4W47JTN5EOYYSLTRIX3HANCNFSM45W7EL4Q.


Simplify lookup, browse and search functions

Remove specific search function in favor of a single typed function:

mbApi.browseArtist(query)  with mbApi.browse('artist', query)
mbApi.lookupArtist('ab2528d9-719f-4261-8098-21849222a0f2') with mbApi.lookup('artist', 'ab2528d9-719f-4261-8098-21849222a0f2')
mbApi.searchArtist({query: 'Stromae'})  with mbApi.search('artist', {query: 'Stromae'})

Resolves #822

If you are happy with this one @Haschikeks , I like to merge it.

But we should keep in mind, that this is a breaking API change.

Very true.
I will write add a warning in the release notes.
We are still releasing as 0.x.x versions, which means the API is subject to change.
Although I think this one is received well, we should soon release 1.0.0.
Thanks for your review @Haschikeks, much appreciated.


Bug: Illogical "Avoid computing higher temperatures on no_speech"

Anyone noticed that instead of silence when no_speech_threshold is triggered it's outputting hallucinations?
Processing segment at 00:00.000
DEBUG: Compression ratio threshold is not met with temperature 0.0 (0.846154 > 0.800000)
[00:29.500 --> 00:29.780]  Sottotitoli creati dalla comunità Amara.org
Processing segment at 00:30.000
DEBUG: Compression ratio threshold is not met with temperature 0.0 (0.846154 > 0.800000)
[00:30.000 --> 00:59.980]  Sottotitoli creati dalla comunità Amara.org

Respectively from json:
            "temperature": 0.0,
            "avg_logprob": -0.37790222728953643,
            "compression_ratio": 0.8461538461538461,
            "no_speech_prob": 0.8777729868888855,

            "temperature": 0.0,
            "avg_logprob": -0.30678143220789295,
            "compression_ratio": 0.8461538461538461,
            "no_speech_prob": 0.9770684242248535,

I've used compression_ratio_threshold=0.8.

False alarm, I thought that compression_ratio_threshold matters too in "silence", forgot that only logprob_threshold is considered.

But wait, if it's not "silence" then why it doesn't go through all fallbacks?

Here it breaks fallbacks because it's "silence":
https://github.com/SYSTRAN/faster-whisper/blob/44f7e589478866546bfcd1d105e254a74e2caad5/faster_whisper/transcribe.py#L721-L725
But here it's not "silence" anymore:
https://github.com/SYSTRAN/faster-whisper/blob/44f7e589478866546bfcd1d105e254a74e2caad5/faster_whisper/transcribe.py#L455-L463

Example of the bug introducing the bad hallucination loop:
DEBUG: Compression ratio threshold is not met with temperature 0.0 (6.677966 > 2.400000)
[04:17.320 --> 04:29.020]  been doing it for a long time. I'm a professional. I'm a professional. I'm a
[04:29.020 --> 04:29.340]  professional. I'm a professional. I'm a professional. I'm a professional. I'm
[04:29.340 --> 04:34.560]  a professional. I'm a professional. I'm a professional. I'm a professional. I'm
[04:34.560 --> 04:38.360]  a professional. I'm a professional. I'm a professional. I'm a professional. I'm
[04:38.360 --> 05:03.750]  a professional. I'm a professional. I'm a professional. I'm a professional. I'm

No hallucination loop with the bugfix:
Processing segment at 03:07.560
DEBUG: Compression ratio threshold is not met with temperature 0.0 (6.677966 > 2.400000)
DEBUG: Compression ratio threshold is not met with temperature 0.2 (8.533333 > 2.400000)
DEBUG: Compression ratio threshold is not met with temperature 0.4 (8.884615 > 2.400000)
[04:17.320 --> 04:22.640]  got me feeling natural. Finding a natural-seeming way to fail at any given task.
[04:23.700 --> 04:27.140]  In each of the commercials that I'm in, I'm the one who simply can't go on
[04:27.140 --> 04:33.340]  without the product. It's ridiculous that we don't have the product. Show them.
DEBUG: Reset prompt. prompt_reset_on_temperature threshold is met 0.600000 > 0.500000
Processing segment at 03:23.580
DEBUG: Log probability threshold is not met with temperature 0.0 (-1.344815 < -1.000000)
DEBUG: Log probability threshold is not met with temperature 0.2 (-1.150256 < -1.000000)
[04:33.340 --> 04:35.340]  No, you shouldn't.
[04:36.020 --> 04:36.300]  Please.
[04:36.560 --> 04:37.520]  You wanna see?
[04:38.020 --> 04:39.080]  Yeah, I wanna see.
[04:43.260 --> 04:44.120]  She's amazing.
[05:03.870 --> 05:05.110]  I just...
[05:05.110 --> 05:05.650]  I...
Processing segment at 03:39.560

Bugfix is merged.


Modal Dialog element

Pull Request Template
Description

Replaced the <div> element in the modal creation with the dialog.
We append the  element to the target.
And replaced the target element remove with close() method that is part of the  tag

GitHub Issue

#1124

Type of Change
Please delete options that are not relevant, and select all options that apply.

✅ Enhancement

How have you tested this?
Test this with any form of modal. Please check for any odd behaviours.
Testing Checklist

✅ Existing Tests still pass
✅ Ran locally on my machine

Code Quality Checklist

✅ My code follows the guidelines of XYZ
✅ My code has been commented
✅ Documentation has been updated
✅ New and existing unit tests pass locally with my changes
✅ Main has been merged into this PR

Looking at this again, there are a whole array of issues that I need to handle. I am closing this and will reopen when those are handled.


perf: simplified check for rendering ready.

Contains
Remove unnecessary check for rendering ready.
Removed condition saves 10ms-15ms. (activity "Queueing Visible Chunks" takes ~18ms)
Removed condition check that near chunks ready too. It's useless because LightMerger(chunk final loading) made it valid for rendering early.
Fixes #4007
How to test
Try compare FPS changes :(
Or compare "Queueing Visible Chunks" activity changes.

I'd been wondering about ways of making that check cheaper. I didn't think to ask if it could be removed entirely!
I guess, in the absence of anyone who can speak up as to what sort of edge case that is guarding against, this is a "if it needed to be there (and the failure mode isn't obvious), there should be a test for it" sort of thing.

@keturn I must to proove that edge case not exists now then. :3 otherwise I can to cache for it.
P.S.
I think that it os outdated after introduce LighMerger(needs dig in commit history)
@Cervator this code by manu3D :(

welp, I guess you will need to become the expert @DarkWeird .

Going to take a chance on this and merge it, since it seemingly tests out yet any hidden meaning might remain in the dark without somebody truly able to speak to it. Better have less code and keep an eye out than leave in mystery code and wonder if we're missing major performance boosts for no reason? 🤷


[WIP] Warn about deprecated formats

Context
We're deprecating representations that are used less frequently, leaving just JSON and CSV.
The API itself should inform users of the deprecations.
Changes proposed in this pull request
Add the following headers:

Link: <https://....json>; rel="alternate" for .yaml or .ttl
Link: <https://....csv>; rel="alternate" for any .tsv or .xlsx
Warning: 299 - "Miscellaneous Persistent Warning" "yaml is deprecated and will be removed" for all deprecated formats

Trello: https://trello.com/c/DyKxUdyA/2638-add-format-change-comms-to-api
See also:

https://tools.ietf.org/html/rfc7234#section-5.5.7
https://www.iana.org/assignments/link-relations/link-relations.xhtml

Guidance to review

Do the warning messages make sense?
Is the logic for generating an alternate URL correct?
I'm not used to java, so feel free to suggest how I can make my code more idiomatic

This isn't finished, as at the moment there is a problem with responses that already return a link header for pagination.
The existing header is not visible from the responseContext.getHeaders() object, presumably because it's set at a lower level. This doesn't happen when the response headers are added via jersey's response builder (see test).

Adding the content type makes sense, I'll add that and extend the warning message.
I'm not sure whether adding additional alternates is worth it, particularly if we're providing multiple URLs for the same resource.
I was also wondering whether we should have alternate links on every success response, not just the deprecated formats. Each representation could link to each (non-deprecated) representation, instead of each deprecated representation linking to a preferred alternative.
It would help discoverability more generally, but it would make the deprecation notice less clear, so not sure if it's worth the added complexity. If we're implementing like this as a filter, that would mean there's two places we have to define (or inspect?) the supported content types for every endpoint.

Ok, let's keep it simple and offer a single alternative with type.
After the deprecation period is over and we remove the warnings, we can consider adding alternate links for all resources.

I think this is ready for review again now.
I've changed the format of the warning header, as I'd inadvertently put more than one warning-text value in.
Example response:
curl -I 'localhost:8080/records.yaml'
HTTP/1.1 200 OK
Date: Fri, 20 Jul 2018 11:21:00 GMT
Link: <?page-index=2&page-size=100>; rel="next",<http://localhost:8080/records.json>; rel="alternate"; type="application/json"
Warning: 299 - "yaml is deprecated and will be removed. See 'Link' header for a format to use instead."
Content-Type: text/yaml;charset=UTF-8
Content-Security-Policy: default-src 'self' www.google-analytics.com; connect-src 'self' www.google-analytics.com; img-src 'self' www.google-analytics.com; script-src 'self' www.google-analytics.com; font-src data:;
X-Content-Type-Options: nosniff
Strict-Transport-Security: max-age=10886400; includeSubDomains
X-XSS-Protection: 1; mode=block
Cache-Control: no-transform
Content-Length: 0

I noticed that the alternate header is absolute whereas the rel header is relative but I'm not sure if this matters?
I'm also unsure about the correctness of the link headers with a type parameter. @arnau I followed your example of ; type="application/json but I couldn't find any examples elsewhere to verify that "type" is the correct parameter name here. All I found is RFC 2068 which allows for arbitrary key value pairs.

re. relative vs absolute: I tens to prefer absolute links in headers but historically registers has used relative links. In the case of the alternate, because it's a different url not a change of parameter you should at least have an absolute path (i.e. /records/foo.yaml) instead of a relative one.
re. "type", this attribute name is the one used by HTML when using rel="alternate" and as far as I can tell W3C tends to use it this way but I haven't found any source that makes it formal.

@michaelabenyohai, I've implemented all the suggestions one (see comment above). Can you take another look?

I think there might be a small bug actually:
The CSV values are generated as:
<?page-index=2&page-size=100>; rel="next",<http://localhost:8080/records.csv>; rel="alternate"; type="text/csv; charset=UTF-8"
(note the quoting of the type part)
I think that should be:
<?page-index=2&page-size=100>; rel="next",<http://localhost:8080/records.csv>; rel="alternate"; type="text/csv"; charset="UTF-8"
or possibly
<?page-index=2&page-size=100>; rel="next",<http://localhost:8080/records.csv>; rel="alternate"; type=text/csv; charset=UTF-8

I've pushed one more commit to deal with the above problem.

@MatMoore good catch, I think it should be:
<?page-index=2&page-size=100>; rel="next",<http://localhost:8080/records.csv>; rel="alternate"; type="text/csv"; charset="UTF-8"

As it keeps consistency in quoting values like we do with rel.

@arnau I've solved this by just stripping out the charset part. I don't think we need it here?

I did a quick check to https://www.w3.org/TR/tabular-data-model/ and I think you are right as UTF-8 is the default charset there.


Explicit button type to prevent form submit

In HTML5 Spec, the button element has a default behavior to submit the form.
When the tree is inside a form, the expand/collapse button submit the form unintentionally.
This commit fixes it adding type="button" explicitly.
If you can merge it fast I would be very grateful 😁  (I need it on another open-source project)
Thanks a lot!

Great point! Thanks for the pull request. The updated code is now available in v0.1.15

Really thank you!


Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

#26820  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @FlorentClarret and the rest of your teammates on  Graphite

/merge


[libc 1.0] Put a big warning to Linux's dirent docs

This fixes my bug https://github.com/rust-lang/libc/issues/2669 .
We cannot change type for d_name field, because this will break tests. So the only thing we can do is to document dirent behavior.
The question remains what are exact rules for dealing with dirent, but this is left to Rust specification

CI is failing, but it seems this is not because of my patch

We should resolve the issue instead of emitting warnings on 1.0 as we can introduce breaking changes there.


New UPX unpacking stub for ELF ARM not recognized

It seems like sample 906ad27e3afe5c0d92ab3c543478f5dd9a999f22f16b837f3f2bf7e18ee54762 uses some kind of new UPX unpacking stub which seems different what we have for ARM. Please investigate whether it is indeed some new unpacking stub for ARM ELFs. What is interesting here that it contains masked UPX metadata header where UPX! is replaced with YTS. Renaming it back makes our unpacker work again.

Solved by #929.

Thanks for taking care of it!


Can't access swarm service via Host IP

Rancher Version:
latest
Docker Version:
1.10.3
OS and where are the hosts located? (cloud, bare metal, etc):
Ubuntu 16 on EC2
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single Node with MySAL
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Swarm
Steps to Reproduce:

Start new Rancher instance.
Add Github Auth.
Add Swarm Environment.
Switch to this new Environment.
Add 2 EC2 hosts.
Add a Ghost Project from the Catalog
After it is done initializing, try to access Ghost from it's host IP

Results:
HTTP ERROR 504
Expected:
200 OK and a Ghost homepage
CLI

Hosts

Endpoint

I fixed this by updating my security group to allow HTTP connections (port 80). Sorry for the noise!


Fixed actual show plan command

Fixed the actual show plan command from the command palette.
Fixes https://github.com/Microsoft/sqlopsstudio/issues/2618

@abist I'll merge this so I can include in today's test pass.


Install on Ionic 3

Hi,
What is the way to install this component on an Ionic 3 project?
Thank you

You could try out something like described in a PR of another web component I published:
https://github.com/fluster/web-social-share/pull/6/commits/26fb97d02de98722045418a2812ae02617b96706
Let me know if it works but generally speaking I'm more focus to support recent versions

Hi @peterpeterparker,
Thank you for the quick response !
I followed Simon Grimm tutorial.
It is tutorial for version: 1.1.1
The problem now is that the canvas result is not showing.
See my issue I opened about it: https://github.com/fluster/web-photo-filter/issues/10


perf(light-clients):use errors.New to replace fmt.Errorf with no parameters

Description
string formatting takes time (even if there's nothing to format), and also that the errors.New is optimized away.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
[ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/).
[ ] Added relevant godoc comments.
[ ] Provide a conventional commit message to follow the repository standards.
[ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
[ ] Re-reviewed Files changed in the GitHub PR explorer.
[ ] Review SonarCloud Report in the comment section below once CI passes.

Changed already merged in https://github.com/cosmos/ibc-go/pull/6249


Replace broken image in README file

Fix broken image for RunMD
The image that was linked to from the README.md file was broken in imgur. I replaced the URL to the correct one from GitHub

I think the change looks good, thank you for fixing!


[WIP] Chain async actions in promises to prevent overlap

A possible fix for #907, opening PR to run tests.  If it works, it will merit a longer explanation / discussion.
Credit for the beautiful idea of using JS promises to prevent any overlap in async libgit2 calls goes to @johnhaley81.

I think we should also include an nonBlocking option for each async call. That way the consumer of the library can decide whether or not they want something to run in a "blocking" state or not.
Ex: Say I want to do a fetch but I also want to calculate the diff of a commit at the same time. These don't really affect each other and the fetch can take a very long time.
I would say that nonBlocking would be the exception though since you almost always want the safety without having to think about it.

This is no longer needed.


Micro doesn't quit after closing terminal ; stays open with high CPU usage

Description of the problem or steps to reproduce
Micro doesn't quit; it stays open with high CPU usage after quitting Konsole with KDE "Close Window" or using Ctrl+W in Yakuake.
Happens with the following commands:
sudo crontab -e
sudo visudo

Doesn't happen with the non-sudo versions of the commands.
My .bashrc:
EDITOR=/usr/bin/micro
VISUAL=/usr/bin/micro

My sudoers:
Defaults env_keep += "EDITOR"
Defaults env_keep += "VISUAL"

Screenshot

Specifications

Commit hash: b9763856
OS: EndeavourOS
Terminal: Yakuake/Konsole

Same: https://github.com/zyedidia/micro/issues/2148

Fixed.


OnnxToLinalg ReduceMean Failing

https://github.com/llvm/torch-mlir/pull/3008

Fixed through https://github.com/llvm/torch-mlir/pull/3008


Dashboard Token Listing: TREE

Discord Handle of Submitter: nezz9461
Token Symbol: TREE
Network: Base
Token Address: 0x65e9B4Ae7885BD3E4e1CC4f280863b859d231FC2
Network Explorer Link: https://basescan.org/address/0x65e9B4Ae7885BD3E4e1CC4f280863b859d231FC2
Is a Super Token? true
Address of Underlying Token:  0x6888c2409D48222E2CB738eB5a805A522a96CE80
SVG Logo Link: https://imgur.com/UEilIbS
Coingecko or Hardcoded Price?: Coingecko
Coingecko ID: treeplanting
Harcoded Price (if Coingecko ID is unavailable):
Token HEX Color: #7AA229
Info on Listing: Farcaster community, want to use supertokens to rent adland ad spaces in their own native currency: https://warpcast.com/~/channel/treeplanting
Please close only after token has been added to resolver!

listing done: https://console.superfluid.finance/base-mainnet/supertokens/0x65e9B4Ae7885BD3E4e1CC4f280863b859d231FC2?tab=streams


Add group and school search to the non-dsi faf journey

Changes in this PR
Step 3 for the non-dsi faf journey is now choosing School or Group and step 4 is the check your group/school page.

 FaF - None DfE Single School navigation


Fixed bower.json

I've faced difficulties while using PruneCluster with grunt-bower-concat, it seemed that the filepaths in "main" property were wrong, so that's the fix.

My bad, everything is ok, it was just the 1.1.0 version.


Some small corrections for the installation README

Thank you! It is not about how to install Nmstate per-se but how to use pip.


fix: dart process not able to find tailwindcss in path

Description
When running jaspr serve on some devices, the dart process isn't able to find tailwindcss command in the path.
Type of Change

🛠 Bug fix

Ready Checklist

[x] I've read the Contribution Guide.
[ ] In case this PR changes one of the core packages, I've modified the respective CHANGELOG.md file using
the semantic_changelog format.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added myself to the AUTHORS file (optional, if you want to).

Fix for issue 289
Let me know if there is a need for changes in the CHANGELOG.md or if I missed anything else.

Thanks. I updated the changelog.


msms does not work on macOS catalina

Hi,
I use this excellent pyvol plugin on macOS Mojave. However, after I upgraded to macOS catalina, the pyvol plugin does not work probably because catalina does no longer support 32 bit binary msms which may be required for the pyvol process. Unfortunately, I could not find the source code of msms and it seems no longer maintained. Is there any way to work the pyvol plugin on macOS catalina?

Thanks for bringing this up. The program (msms) used for surface triangulation is only available pre-compiled right now. The version for MacOS is only available in a 32 bit binary right now. I have reached out to Scripps to see if they will release a 64 bit version or let me compile the source code. If they won't do that, I can integrate a different surface triangulation program. I'll update you when I have a fix.

I haven't gotten any response from Scripps yet. I am not sure when I will have time to get to implementing a work around on Catalina. I'll reach out when I get to it.


Widget snippets generate unused import

The stateless/stateful/animation controller widget snippets generate an unused import in Flutter 3.24, so I think that the snippets should be updated. (might need to determine when the foundation import was made obsolete for the snippet)
For example, given an empty Dart file, selecting the stateless snippet generates
import 'package:flutter/foundation.dart';
import 'package:flutter/widgets.dart';

class MyWidget extends StatelessWidget {
  const MyWidget({super.key});

  @override
  Widget build(BuildContext context) {
    return const Placeholder();
  }
}

If you then run dart analyze on the snippet, you get
Unused import: 'package:flutter/foundation.dart'. Try removing the import directive. • unused_import
Related issue: https://github.com/dart-lang/sdk/issues/49081

Flutter Doctor
[✓] Flutter (Channel stable, 3.24.1, on macOS 14.6.1 23G93 darwin-x64, locale
    en-BE)
    • Flutter version 3.24.1 on channel stable at
      /Users/navaronbracke/Documents/flutter
    • Upstream repository git@github.com:navaronbracke/flutter.git
    • FLUTTER_GIT_URL = git@github.com:navaronbracke/flutter.git
    • Framework revision 5874a72aa4 (12 days ago), 2024-08-20 16:46:00 -0500
    • Engine revision c9b9d5780d
    • Dart version 3.5.1
    • DevTools version 2.37.2

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/navaronbracke/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/navaronbracke/Library/Android/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      17.0.10+0-17.0.10b1087.21-11572160)

[✓] VS Code (version 1.92.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.94.0

[✓] Connected device (3 available)
    • iPhone Xs (mobile) • A1C65549-1101-4825-B9ED-41E7C098ACD5 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-17-5 (simulator)
    • macOS (desktop)    • macos                                • darwin-x64
      • macOS 14.6.1 23G93 darwin-x64
    • Chrome (web)       • chrome                               • web-javascript
      • Google Chrome 128.0.6613.113

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Should the Flutter team be the ones adding the Flutter snippets to the Flutter SDK version of the analyzer, instead of the analyzer in the Dart SDK containing (generators for) code that can't be tested with just the Dart SDK?

@DanTup

I don't seem to be able to reproduce this in 3.24.1 in an empty file:
https://github.com/user-attachments/assets/ec00ceaa-07c4-4e9d-9e6f-51bee386936d
The imports aren't hard-coded, but are computed by the server from the types that are referenced in the snippets (there are many places where we might write a reference to a type and need to import it, so there is code to determine the "best" import to add - eg. we don't want to import the real src/ file that contains the types used in the snippet). My feeling is that something is wrong wrong here (or we're first importing a library for one type, then later import a library that also includes it along with other referenced types).
@navaronbracke is it possible you could capture a log while reproducing this? Ideally in a new project (to minimize differences between us):

close the empty file
run the Dart: Capture Analysis Server Logs command from the palette (F1)
open the empty file
use the stless snippet
click cancel on the logging notification to stop logging and open the log file
attach the log here

Thanks!
@lrhn

Should the Flutter team be the ones adding the Flutter snippets to the Flutter SDK version of the analyzer, instead of the analyzer in the Dart SDK containing

Currently there's no mechanism for snippets that aren't built into the server (written in Dart). Probably the ideal solution is that any package can provide snippets - there's an issue for that at https://github.com/dart-lang/sdk/issues/32103, although it only has three 👍 's so far so I don't know how much demand there is from 3p packages.

Looking back at my video, cupertino also seems an odd (though valid) choice here. I wonder if snippets should have some preferred imports that are added first (or whether there's some way a package could express some preference for which libraries to prefer).

@DanTup I also cannot reproduce it on a new project. Strangely enough the project that I reproduced it with was upgraded to Flutter 3.24.0 (I can still repro it there, though)
I did update that project's pubspec from Flutter 3.24.0 / Dart 3.5.0 to use Flutter 3.24.1 / Dart 3.5.1 and now I also cannot reproduce it there. Maybe something got fixed in the hotfix release?

If you mean you updated the environment in the pubspec to require Dart 3.5.1, I wouldn't expect that to change anything here (you'd have still been using the same compiled analysis server that shipped with 3.5.1 even if the SDK constraint was lower).
I wonder if some server state caused us to enumerate the libraries in a different order and that resulted in us adding different imports. I can't see any obvious reason for this, though I do see that we discover files in the server using Folder.getChildren() and the docs for that say "in no particular order". I don't know what would influence that order though (or how stable it would be across IDE sessions etc.).
Out of interest, when you try now - does it select the same cupertino.dart library that my video showed or something else?

Out of interest, when you try now - does it select the same cupertino.dart library that my video showed or something else?

I never had any snippets provide cupertino imports.
That said, I did an SDK upgrade to Flutter 3.24.2 / Dart 3.5.2 and the bug reappeared in that old project.
I did capture the log this time:
Dart-Code-Log-2024-08-04 19-33-28.txt
I can't really tell why an existing project would be affected, but a new one isn't. (although the existing project was originally created a while back and had a few SDK upgrades since, so it's not a "fresh" workspace)

Thanks, the logs show a file being opened (lib/test.dart) with the content "\n", typing st and then the completion response containing this snippet:
{
    "additionalTextEdits": [
        {
            "insertTextFormat": 2,
            "newText": "import 'package:flutter/foundation.dart';\nimport 'package:flutter/widgets.dart';\n\n",
            "range": {
                "end": {
                    "character": 0,
                    "line": 1
                },
                "start": {
                    "character": 0,
                    "line": 1
                }
            }
        }
    ],
    "documentation": {
        "kind": "markdown",
        "value": "Insert a Flutter StatefulWidget with an AnimationController."
    },
    "filterText": "stanim",
    "insertTextFormat": 2,
    "insertTextMode": 1,
    "kind": 15,
    "label": "Flutter Widget with AnimationController",
    "sortText": "zzzstanim",
    "textEditText": "class ${1:MyWidget} extends StatefulWidget {\n  const ${1:MyWidget}({super.key});\n\n  @override\n  State<${1:MyWidget}> createState() => _${1:MyWidget}State();\n}\n\nclass _${1:MyWidget}State extends State<${1:MyWidget}>\n    with SingleTickerProviderStateMixin {\n  late AnimationController _controller;\n\n  @override\n  void initState() {\n    super.initState();\n    _controller = AnimationController(vsync: this);\n  }\n\n  @override\n  void dispose() {\n    _controller.dispose();\n    super.dispose();\n  }\n\n  @override\n  Widget build(BuildContext context) {\n    return ${0:const Placeholder()};\n  }\n}"
}

When I try to reproduce on 3.42.2 I get different imports, but ones that produce the same problem:
import 'package:flutter/animation.dart';
import 'package:flutter/cupertino.dart';

The first import is added as we try to resolve AnimationController but then for other symbols we pick cupertino which also includes AnimationController, making it redundant (although interestingly I see UNNECESSARY_IMPORT where you see to have unused_import?).
Some ideas:

When we add a new import for an Element in DartFileEditBuilder, we check whether that import includes all Elements tied to another pending import, and if so replace that pending import with this one.
During DartFileEditBuilder.finalize(), loop over the pending imports and see if any of them are to import only elements available in other pending imports (in which case, remove it).
Run some code in a command on the snippet afterwards, that "cleans up" after applying the original edits (though we'd have to be careful not to remove anything we didn't just add)
Have snippets "preferred" import that they will always select first if a symbol is not already imported (for example using widgets here).. this is probably simplest, but it doesn't avoid the same issue cropping up in different places if more code starts to import elements this way

One slight concern I have is that these edits are all built in-line when computing code completions (these edits are not delayed until resolve), so any additional work here is going into the completion time. I wonder if we should change snippets so their edits (or at least imports) are computed lazily?
@bwilkerson any thoughts about this?

I don't have a definitive answer, but yes, I have thoughts. :-)

Assuming that we're already not adding an import if there's already a pending import that would already make the element available in scope, then it seems like an oversight that we're not already doing this.

I'm a bit concerned about the cost of that approach, especially if we're already partially optimizing the list as we're building it. I suspect that the first item will be more performant just by virtue of keeping the list minimal at all times.

It sounds to me like this would be difficult to get right, largely because of the need to not remove imports that weren't added.

I generally prefer general solutions like (1) over more targeted solutions like (4) just because they tend to minimize future problems. Sometimes the complexity of the general solution make it prohibitive, but it doesn't sound like that's the case here.

I wonder if we should change snippets so their edits (or at least imports) are computed lazily?

That's an interesting optimization. I don't know how often snippets are causing performance problems, though, so I don't know whether it's a problem worth solving.
@keertip Something to keep in mind as we start to look at the performance of completion post-refactoring.

Assuming that we're already not adding an import if there's already a pending import that would already make the element available in scope, then it seems like an oversight that we're not already doing this.

The first part is correct, we do check existing imports to see if they cover the new element, but we don't check if any existing imports may now be redundant. We'd need to store some additional info against pending imports for this (because we can only remove a pending import if it's only being used to provide those elements, and the caller hasn't explicitly called importLibrary for it, and then it was just reused by an Element import).
I think doing this might be the nicest solution though - it does mean a bit more looping as we're adding imports, but given the number of imports being added is likely very small, it's probably significantly less than the existing work to locate a non-src import, for example. I'll try doing this.

That's an interesting optimization. I don't know how often snippets are causing performance problems, though, so I don't know whether it's a problem worth solving.

We did have some reports of perf issues here in the past (because each snippet would perform some of the same work) which we solved in https://github.com/dart-lang/sdk/commit/092bdb17d31f9c94092567acd83a08785e4c5a40. I don't know of any complaints since then so perhaps it's not worth changing now, but it's something to keep in mind (we don't build the edits up-front for other kinds of completions as they're handled via resolve instead).


N28: Oxygengine + NavMesh

Part of #852

i've used GIF hosted on my repo since these never change and GIF no matter how much i optimize it, it refuses to go down to 2 MB : D

i've replaced links to external gif with one bound to specific commit to preserve it when file gets moved or replaced or something

if needed i could cut length of the gif till gets 2 mb, but 10 seconds is already short tho

@PsichiX I'm going to make the decision to say that Gifs and other media must be hosted on our repo, and must be smaller than 2.5MB to be included. Although I believe you won't edit that commit, and it should be available, I do still believe that it could cause a headache down the road if something did go wrong. Having the media in our repo does provide a strong guarantee around that.
As for size, that is a strong restriction regardless. Gifs aren't the greatest format for size, maybe we can look into mp4 down the line, but we don't have that now :) Hopefully this works for you!

I'll try to revisit #636 later this month, if I get time - GIF wrangling always ends up being a fairly large chunk of the review process, and I feel like there has to be an easier way :)

ok, will cut the length (lowering resolution only increases the size xD)

ok, i've cut length of the gif animation to 2.5 mb @17cupsofcoffee @AngelOnFira